From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:11:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:11:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297127.506028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na4t9-0002xs-Ul; Fri, 01 Apr 2022 00:11:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297127.506028; Fri, 01 Apr 2022 00:11:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na4t9-0002xl-Rr; Fri, 01 Apr 2022 00:11:39 +0000
Received: by outflank-mailman (input) for mailman id 297127;
 Fri, 01 Apr 2022 00:11:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na4t7-0002xb-U7; Fri, 01 Apr 2022 00:11:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na4t7-0001sr-Rp; Fri, 01 Apr 2022 00:11:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na4t7-0004sr-HF; Fri, 01 Apr 2022 00:11:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1na4t7-0003X1-Gk; Fri, 01 Apr 2022 00:11:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IXz+cfjy7YGXKrQtaBnmU0xlH/ufCWt7Hrnsq09YIds=; b=QAyiBwkX46IpEI957Yyc+xj2UO
	f117LXZ7aL51W0lxUjYpz4BDRLI/W4A3N0EuXpr8rSHNH73jM9k89vTTDZFywJSo4jdXxxJMzEEsP
	PGlkXPOChh9hdsjM2C8x/amtFaYnoOmOj94of5pZakJFh9HPi+6D2Qx63MeAXbO2jl8U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169078-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169078: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
X-Osstest-Versions-That:
    xen=8a87b9a0fb0564f9d68f0be0a0d1a17c34117b8b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 00:11:37 +0000

flight 169078 xen-unstable-smoke real [real]
flight 169085 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169078/
http://logs.test-lab.xenproject.org/osstest/logs/169085/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 169064

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
baseline version:
 xen                  8a87b9a0fb0564f9d68f0be0a0d1a17c34117b8b

Last test of basis   169064  2022-03-31 09:00:34 Z    0 days
Testing same since   169078  2022-03-31 19:01:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jason Andryuk <jandryuk@gmail.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
Author: Jason Andryuk <jandryuk@gmail.com>
Date:   Wed Mar 30 14:17:22 2022 -0400

    libxl: constify libxl__stubdomain_is_linux
    
    libxl__stubdomain_is_linux can take a const pointer, so make the change.
    
    This isn't an issue in-tree, but was found with an OpenXT patch where it
    was called with only const libxl_domain_build_info available.
    
    Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
    Acked-by: Anthony PERARD <anthony.perard@citrix.com>

commit e45ad0b1b0bd6a43f59aaf4a6f86d88783c630e5
Author: Jason Andryuk <jandryuk@gmail.com>
Date:   Wed Mar 30 14:17:41 2022 -0400

    xl: Fix global pci options
    
    commit babde47a3fed "introduce a 'passthrough' configuration option to
    xl.cfg..." moved the pci list parsing ahead of the global pci option
    parsing.  This broke the global pci configuration options since they
    need to be set first so that looping over the pci devices assigns their
    values.
    
    Move the global pci options ahead of the pci list to restore their
    function.
    
    Fixes: babde47a3fed ("introduce a 'passthrough' configuration option to xl.cfg...")
    Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
    Acked-by: Anthony PERARD <anthony.perard@citrix.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:28:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:28:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297136.506043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na593-0004X2-EY; Fri, 01 Apr 2022 00:28:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297136.506043; Fri, 01 Apr 2022 00:28:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na593-0004Wv-BW; Fri, 01 Apr 2022 00:28:05 +0000
Received: by outflank-mailman (input) for mailman id 297136;
 Fri, 01 Apr 2022 00:28:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i0v6=UL=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1na591-0004Wo-RK
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:28:04 +0000
Received: from sonic316-55.consmr.mail.gq1.yahoo.com
 (sonic316-55.consmr.mail.gq1.yahoo.com [98.137.69.31])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94c7d5ec-b152-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:28:00 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic316.consmr.mail.gq1.yahoo.com with HTTP; Fri, 1 Apr 2022 00:27:57 +0000
Received: by kubenode531.mail-prod1.omega.ne1.yahoo.com (VZM Hermes SMTP
 Server) with ESMTPA ID 0aca7176e3c3f08bb38673ef093c6c98; 
 Fri, 01 Apr 2022 00:27:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94c7d5ec-b152-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1648772877; bh=REYhcQUlmotzb05VyvmHeoG0pRdoVYI7C+xj0CPn9NQ=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=EHxVOZHKUaGIofvCW/X9PTBQEWjZRew2iCrLSeUloes/JMklF/I6cMhbBL3i3LQeyoaJFsW+fV2hZwSATk93gI0dGRBIfzaiG2mR75KkoKrWWTKy6bb3kxltyR1VhCWhO6JJGmGdYC7Pgff2L1WT4V+ngH1wdu83TwzWn+I09+O9T8XnxXam/QuBK/VoZalqAFlio2Qjya4I02J1uY8EaNEuvbA4a1u4/63fSzJN9VqV6+S0/+mUT18E+UR+JahgtbAwb/Vs7w4F/YShVj+7JAEkFeJEhh438Uy0l1ZI314dUwvKe+Iy1lJKaTaiRXBjTyvj9Re49hgseuGvwlMAqA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648772877; bh=aEinVykmyruplOHq4DQPnWkG3tuYx4/QXl8dYsfPGjr=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=nYhK5/MZWO14y+kXXj9dLqQ1Yk6srE+/kk6+Tprx3hi/785m7P+REOUfId1cjzv4lTGxbGbq7DCyVhuHyvPZoCOKuTepT3vdxF4dvN1mzltbaOztG1KViy0dQQmXM7KBpW1QfGHaqKe8Lz56hzJJX+zaPZiskZQSaazbeZDhBfyNLDF1mfq7Xc1Hk8yJJTKY6UDymRMn4p3vwWLJuGb0FxgbrenxVjF8y5cfsQBhkyq+3s0MmcOytO2M5VfKCHjXFinH77FfSfTjoxNA1fNZOA3usjLACLyML/NOdEmyUoIYtnXrL0zSSpXknCrkQ2iOLJStlbpfSui/9uHkBy64Mw==
X-YMail-OSG: nupj4QcVM1nf5x8sd0DV0uoSBB_jnm2b_JkpTn8I2u6uYV9KrOHIdOuFryeXyPf
 g0eCI35QNWwfzT9wUCRlobPvHIn.OyhEtt4QsXDqrbi_K.BdjtKlxndXZjHeRhbwY3OoBPXM0o3v
 ARZ9uIko2ZF7l4BRK1mxq9.yF_fMA2_XFhYMsI3WX2Q6g2LiMwL5ttVb7kloueZTFSTlakHFx7Dg
 hcRbQe.kBOhBNqyysEi1j8XGs33hFRSNnQ4_IrKb0Pa6ZRi3l5iSYtHYnhZfUT5K.XPwAZmUBb8h
 QWPz2_oWKeSQgXsyvsoubO3vgrZ8EZhzsDAWlkuDkuNdah9h3RsnGldle0j2UsHEB8bOK9548n62
 V6Njxu7pG.dJaS64wtUEKhO8W47pNN.rrwfiwDoFZLi0dIJ7LpCwIgPMP._ADRtb0P61NMlDZX6Q
 T9iVxu2c3OShC393LrgFYR7GklnrVhj0r9uexo.7KO3YiN8wa3zTliplA2oPUC4soaqHWdUBfYU7
 Y2Fe2d0cieXY_RQmuSZJOQ4dHT6y62DyKHVWAj0uYe_RNR_WY5UOqn042oH09dPVBQzs9JMxDFK0
 s_TUjTE3k_zDu4T00NUoPJ4r_eYOVqbMQmFrSvSZqLSl1yzqEoPhWzaPIeI_NsxWcEuztZJZ13zJ
 STzVKJ3RWSLC3biT6dD4NMaH3TrMAXTt6F8wYlt4s.xXnueVw8rjyK4Y4LHXG1n5Kpf1C6SWhtUh
 LGwDYFkAcQU.9DLWrP95WaJ0RVNVKaYDmnCDTJxM0ZPFIZXCmoyjh4FhIdDO2gcJdCreuEfB4P9w
 LauZWBCukFfqjEaCVLT9tu54p_KQaD4LzZoNCxowN5J6plK_7UTktMK0xkAaHDEuPi3giBlOuBOX
 5uMqs9Ivs4DdJlHs6uslu6o1q7gIAWGgyCbPQw2ccVXs9aosQcNcrLqcZ7APw0gmD6Lae2rz1EXA
 VfRDeDCReS2FfCJh9Bi3QUIH.zD0PnHndmr7k74Gub6RZEylzfUf.DqMcYnlCmfAWnJd5GiUXPmI
 Nwl4XwOGZTSoN7L4ekEeCfIAeATDy1aDGIJJpPNBYESIEbpRfq9QpjkGUBaA1rc7NgN.gtnMHt66
 w8fkWgf_tw3aReoc0Y.nWqtzZr_9fG90Ptmv.XGBIdcE62rVoWv49lah45qzRyaRyB0wLnNhE7Gr
 zuNHbIzjDNkXS0QAGgF56bhLwpdLS9Bgkuj7Jjx4zSH9NvwKZQW3wGgR1_oqnFXEbepvzqtR_i45
 vVy4JIM5bErswBDQeMkyC4t552wXkumk1IejQP6n4GW5wn3KiZs5L4Yoiz7DLRmX1AIEwFEko8wS
 jSK4KFoAUr5E_CytaxYuLtslQIOPhrwWflTePaNCYVvcMwkXAasDt2h_RhDTVvtLjeVB0vcErWCL
 3G0MIbtOBLe7RTadQCQiDyMD..CWVzA_xUQ4WQ5qMPdH5MKHDFKuwjqao6vl1OOK2Fx..BMo7_5y
 ._Xv7MZ2MQFNmxizM1.S3NORK78u5m8aZrV5ooiev7rjud0fQE2VHf4sEXSlVF0EnVir0tFg4pI1
 wYKu5EC5snlDSsWpD_lVxaCZZMxYDCni8ic8OxjsWvRVoPiQp7TDV9xXBwEWmc9iv3WQ_zwThfI4
 NfXl5R2fr4rDJ6q.f894wAZS7kWcJt1bQL5vPjwKQyRjEprtmSNmpfityIQ4xW9MGtCflzgpR1Hg
 GdEhkkFRZyRYP3_Cl7CV_DhEKXVwfDz3Q_tFR9cQXP8Ogx8zTYoYx4gIA6xRHK7he.KsWkvyBD8g
 yutUSapb7H5u3NqcGeSdOQc.v5XOihzJzcmDq7654akFyhvJVBF.5v7qOzJPsECPxAQ652Wj8qKF
 Du1ZrYBo84Wvy8HIahy3E.1cQk7K8W7XuzvI6p0DPCqhw3.cjru76QDNmX2zO5crZwLr7bGpxSlq
 QjvBZM4xX10xwAgQWT0LNQtkwkXxlxWj21Hh0tjI7YTM885th5.9OxtZhKbxknO7eOpAYieoZJPk
 rEUoG1nA_7VApqYDSm8bhfY749zMF2_I2tkfQKh9FQGiOPj48sLeOHuoPxYuTsTyYXEsw8j_guCR
 Uam.aRg6RycQ4SoBGsLvequBSbAIcDYGF2NAaakR.mwzuAkQhUtyWg7.01.Z8PupFZmBUFKhX13w
 gttO8m8Cu4luzBfiO.1O0kqnaVWuflPXeXYm1QK2zfBtt3vYC3g61EXtZpjKN7ZKHTSpSUcGIL63
 I70QsmBCh2wc-
X-Sonic-MF: <brchuckz@aim.com>
Message-ID: <9db571e8-aa01-c4a3-a7e3-aa93a49d6e06@netscape.net>
Date: Thu, 31 Mar 2022 20:27:52 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access
 to Intel IGD opregion
Content-Language: en-US
From: Chuck Zmudzinski <brchuckz@netscape.net>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
References: <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz.ref@netscape.net>
 <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz@netscape.net>
 <YkSQIoYhomhNKpYR@perard.uk.xensource.com>
 <4b40eb36-71b5-d3dc-8551-73a684bff2dc@netscape.net>
In-Reply-To: <4b40eb36-71b5-d3dc-8551-73a684bff2dc@netscape.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 2773

On 3/31/22 2:32 PM, Chuck Zmudzinski wrote:
> On 3/30/22 1:15 PM, Anthony PERARD wrote:
>> Hi Chuck,
>>
>> On Sun, Mar 13, 2022 at 11:41:37PM -0400, Chuck Zmudzinski wrote:
>>> When gfx_passthru is enabled for the Intel IGD, hvmloader maps the IGD
>>> opregion to the guest but libxl does not grant the guest permission to
>> I'm not reading the same thing when looking at code in hvmloader. It
>> seems that hvmloader allocate some memory for the IGD opregion rather
>> than mapping it.
>>
>>
>> tools/firmware/hvmloader/pci.c:184
>>      if ( vendor_id == 0x8086 )
>>      {
>>          igd_opregion_pgbase = mem_hole_alloc(IGD_OPREGION_PAGES);
>>          /*
>>           * Write the the OpRegion offset to give the opregion
>>           * address to the device model. The device model will trap
>>           * and map the OpRegion at the give address.
>>           */
>>          pci_writel(vga_devfn, PCI_INTEL_OPREGION,
>>                     igd_opregion_pgbase << PAGE_SHIFT);
>>      }
>>
>> I think this write would go through QEMU, does it do something with it?
>> (I kind of replying to this question at the end of the mail.)
>>
>> Is this code in hvmloader actually run in your case?
>
> Hi Anthony,
> ...
> So the conclusion is that hvmloader does allocate the three pages in the
> guest for the opregion and writes a value for the opregion address, but
> it appears it is overwritten later with the error value when the guest
> cannot access the opregion and with the correct value when the guest can
> access the opregion.
>
> So I agree that I should understand what is going on here better. I
> tentatively think the call to pci_writel in hvmloader can be safely
> removed because that value seems to be changed later on somewhere.

After discovering how the device model recovers the offset
of the opregion from the page boundary, I am now certain
that what we currently have in hvmloader is necessary. We
do need to call pci_writel in hvmolader because that is where
we write the mapped value of the page-aligned address of
the opregion in the guest, and then the device model reads
that value, recovers the offset of the opregion to the page
boundary, and writes the address of the beginning of the
opregion, not the page-aligned address that hvmloader wrote,
into the config attribute of the Intel IGD that is passed
through to the guest. That is why it seemed to me that the
address was changed somewhere. The device model modifies
it so it is the actual address of the opregion and not the address
of the page boundary that immediately precedes the opregion.
I hope this is an acceptable explanation of what we currently
have in hvmloader.

Regards,

Chuck


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:34:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:34:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297140.506054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Em-0005vE-3U; Fri, 01 Apr 2022 00:34:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297140.506054; Fri, 01 Apr 2022 00:34:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Em-0005v7-0N; Fri, 01 Apr 2022 00:34:00 +0000
Received: by outflank-mailman (input) for mailman id 297140;
 Fri, 01 Apr 2022 00:33:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5El-0005v1-8U
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:33:59 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a309a66-b153-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:33:57 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C32876187D;
 Fri,  1 Apr 2022 00:33:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D70F7C340EE;
 Fri,  1 Apr 2022 00:33:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a309a66-b153-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773235;
	bh=vfmf2C08q6OsbwZcbUBkq57f0KXC7iAFpbtu/pP9fUo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=J4OrLCNNFip75Tonb0PtChnVw2Bc5Xx/pJMGogkIh4NaTselluXmfbBZrZ3aOHkr1
	 w9qrf5akO5znt65ogonHseHJX0mVqPZm9gtQm0vczZ2vWyQPYuuXIAbeGj849SUZil
	 OoeNFyW00SBt0ridWw5qrPvPIctu5VFV/sefQ6BhzcvmyOo2GRGxwsVlv8W4HlvJ8P
	 YLEqBUHbltqjvDWuKbE5A833VeSte6DvDnDbi+Kd2SaBaMLyolsEzWmVEPuATXjKHm
	 VJPZotEraSjsxr+jFiJM+p8Hhw/OhFIlNa4rGf7j4n66fS1X36qpPocb2yr49BaMp8
	 /np2NZ/dKBj6g==
Date: Thu, 31 Mar 2022 17:33:54 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, 
    Volodymyr_Babchuk@epam.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v3 1/5] xen: introduce xen,enhanced dom0less property
In-Reply-To: <5c2cc1dd-d070-a88c-0e49-bca9ba56900c@xen.org>
Message-ID: <alpine.DEB.2.22.394.2203311703070.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop> <20220128213307.2822078-1-sstabellini@kernel.org> <3a00dff8-c213-616e-48b0-6e2b6f30dbce@xen.org> <alpine.DEB.2.22.394.2203221653230.2910984@ubuntu-linux-20-04-desktop>
 <5c2cc1dd-d070-a88c-0e49-bca9ba56900c@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 25 Mar 2022, Julien Grall wrote:
> On 23/03/2022 00:08, Stefano Stabellini wrote:
> > On Sat, 29 Jan 2022, Julien Grall wrote:
> > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > > > index 6931c022a2..9144d6c0b6 100644
> > > > --- a/xen/arch/arm/domain_build.c
> > > > +++ b/xen/arch/arm/domain_build.c
> > > > @@ -2963,6 +2963,7 @@ static int __init construct_domU(struct domain *d,
> > > >                                     const struct dt_device_node *node)
> > > >    {
> > > >        struct kernel_info kinfo = {};
> > > > +    const char *dom0less_enhanced;
> > > >        int rc;
> > > >        u64 mem;
> > > >    @@ -2978,6 +2979,12 @@ static int __init construct_domU(struct domain
> > > > *d,
> > > >          kinfo.vpl011 = dt_property_read_bool(node, "vpl011");
> > > >    +    rc = dt_property_read_string(node, "xen,enhanced",
> > > > &dom0less_enhanced);
> > > > +    if ( rc == -EILSEQ ||
> > > 
> > > I think the use an -EILSEQ wants an explanation. In a previous version,
> > > you
> > > wrote that the value would be returned when:
> > > 
> > > fdt set /chosen/domU0 xen,enhanced
> > > 
> > > But it is not clear why. Can you print pp->value, pp->length, strnlen(..)
> > > when
> > > this happens?
> > 
> > I added in dt_property_read_string:
> > 
> > printk("DEBUG %s %d value=%s value[0]=%d length=%u
> > len=%lu\n",__func__,__LINE__,(char*)pp->value,
> > *((char*)pp->value),pp->length, strlen(pp->value));
> > 
> > This is the output:
> > (XEN) DEBUG dt_property_read_string 205 value= value[0]=0 length=0 len=0
> 
> Thanks posting the log!
> 
> For convenience, I am copying the comment on top of dt_property_read_string()
> prototype:
> 
>  * Search for a property in a device tree node and retrieve a null
>  * terminated string value (pointer to data, not a copy). Returns 0 on
>  * success, -EINVAL if the property does not exist, -ENODATA if property
>  * doest not have value, and -EILSEQ if the string is not
>  * null-terminated with the length of the property data.
> 
> Per your log, the length is NULL so I would have assumed -ENODATA would be
> returned. Looking at the implementation:
> 
>     const struct dt_property *pp = dt_find_property(np, propname, NULL);
> 
>     if ( !pp )
>         return -EINVAL;
>     if ( !pp->value )
>         return -ENODATA;
>     if ( strnlen(pp->value, pp->length) >= pp->length )
>         return -EILSEQ;
> 
> We consider that the property when pp->value is NULL. However, AFAICT, we
> never set pp->value to NULL (see unflatten_dt_node()).
> 
> So I think there is a bug in the implementation. I would keep the check
> !pp->value (for hardening purpose) and also return -ENODATA when !pp->length.
> 
> Most of our device-tree code is from Linux. Looking at v5.17, the bug seems to
> be present there too. This would want to be fixed there too.

I have added a patch to fix dt_property_read_string. I am about to send
it out as patch of v4 of the series. I'll also follow-up on Linux.

I am thinking of keeping the -EILSEQ in domain_build.c for hardening
purposes.


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:35:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:35:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297143.506065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Fn-0006Sv-F8; Fri, 01 Apr 2022 00:35:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297143.506065; Fri, 01 Apr 2022 00:35:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Fn-0006So-Ay; Fri, 01 Apr 2022 00:35:03 +0000
Received: by outflank-mailman (input) for mailman id 297143;
 Fri, 01 Apr 2022 00:35:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5Fl-0006Sa-OR
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:35:01 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 900e8736-b153-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:35:00 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 99ACBB8227A;
 Fri,  1 Apr 2022 00:34:59 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB51BC340EE;
 Fri,  1 Apr 2022 00:34:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 900e8736-b153-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773298;
	bh=jnr3ygKO8CAVdT+15YHoss+zHbMtAIEXiyHmYDI2Myg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=qQQQkVRlcS8S6GDR6IK/2XRgepiKTYrFuTBLOzRripm6ka9/RuKDiCf5Zblyrx9cd
	 HByiOF9K+0B+9P/4I+MlOy7564zjLhR0IfygGGAK9K9TcEI0MQcC+5x9eSOsY5sYE6
	 5r9Bq4jrJyoc2+t0yjPom0WlC9GE+dgE/83JShEHa7Ie3GwGIUgJ0gOaH2BZkmkejj
	 drtp+0zyQDu+9TPOsljO5oUXXcOvRng7oMFUK1PIsvOEtACrva4EWL7s9heeiMhWCq
	 zMbdQlOhIgskW/A6xyu5U0fNjRfLPJ0hRH/p3hHh6wezq2AfmepDFeC2H1OWXp3c1J
	 TRU5qxKeEOZfQ==
Date: Thu, 31 Mar 2022 17:34:57 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, 
    Volodymyr_Babchuk@epam.com, Luca Miccio <lucmiccio@gmail.com>, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v3 3/5] xen/arm: configure dom0less domain for enabling
 xenstore after boot
In-Reply-To: <799f69b2-f581-9f5f-004a-8f9f790aba2a@xen.org>
Message-ID: <alpine.DEB.2.22.394.2203311341220.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop> <20220128213307.2822078-3-sstabellini@kernel.org> <e55c03f6-5b20-ce9c-ce88-11dc85623dce@xen.org> <alpine.DEB.2.22.394.2203221722430.2910984@ubuntu-linux-20-04-desktop>
 <799f69b2-f581-9f5f-004a-8f9f790aba2a@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 25 Mar 2022, Julien Grall wrote:
> On 23/03/2022 01:18, Stefano Stabellini wrote:
> > On Sat, 29 Jan 2022, Julien Grall wrote:
> > > On 28/01/2022 21:33, Stefano Stabellini wrote:
> > > > +    rc = evtchn_alloc_unbound(&alloc, true);
> > > > +    if ( rc )
> > > > +    {
> > > > +        printk("Failed allocating event channel for domain\n");
> > > > +        return rc;
> > > > +    }
> > > > +
> > > > +    d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port;
> > > > +
> > > > +    return 0;
> > > > +}
> > > > +
> > > >    static int __init construct_domU(struct domain *d,
> > > >                                     const struct dt_device_node *node)
> > > >    {
> > > > @@ -3014,7 +3043,19 @@ static int __init construct_domU(struct domain
> > > > *d,
> > > >            return rc;
> > > >          if ( kinfo.vpl011 )
> > > > +    {
> > > >            rc = domain_vpl011_init(d, NULL);
> > > > +        if ( rc < 0 )
> > > > +            return rc;
> > > > +    }
> > > > +
> > > > +    if ( kinfo.dom0less_enhanced )
> > > > +    {
> > > > +        rc = alloc_xenstore_evtchn(d);
> > > > +        if ( rc < 0 )
> > > > +            return rc;
> > > > +        d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL;
> > > 
> > > I think it would be easy to allocate the page right now. So what prevent
> > > us to
> > > do it right now?
> > 
> > Because (as you noted as a comment to the following patch) as soon as
> > d->arch.hvm.params[HVM_PARAM_STORE_PFN] is set the guest can continue
> > with the initialization and will expect the right data to be set on the
> > page.
> 
> I think you misunderstood my question. From my understanding, at the moment,
> Linux would break with your proposal. So you need to modify the kernel in
> order to support what you are doing.

Linux does not break with this proposal. I wrote a longer explanation
[1] some time ago.

In short: the master branch and any supported versions of Linux boots
fine with this proposal without changes, however it wouldn't be able to
use PV drivers when started as dom0less kernel.

To be able to use the new feature, this patch is required [2].

Old unsupported and not updated Linux is the only one to break. You gave
an excellent suggestion on thread [1], which resulted in me writing
patch #1 "xen: introduce xen,enhanced dom0less property" to retain
compatibility with older unpatched and unsupported kernels.

[1] https://marc.info/?l=xen-devel&m=164142956915469
[2] https://marc.info/?l=xen-devel&m=164203595315414


> IOW, we have room to decide the approach here.
> 
> Xenstore protocol has a way to allow (re)connection (see
> docs/mics/xenstore-ring.txt). This feature looks quite suited to what you are
> trying to do here (we want to delay the connection).
> 
> The main advantage with this approach is the resources allocation for Xenstore
> will be done in the place and the work in Linux could be re-used for
> non-dom0less domain.
> 
> Have you explored it?

Luca (CCed) is the original author. I don't know if he explored that
approach. I have not looked into it in any details but I think there
might be challenges: in this case there is nothing on the shared page.
There are no feature bits as it has not been initialized (xenstored is
the one initializating it).

Keep in mind that Luca and I have done many tests on this approach, both
the Xen side, the Linux side (very many different kernel versions) and
complex configurations (both network and block PV drivers, DMA mastering
devices, etc.) If we changed approach now we would lose some of the
value of the past efforts. But if required, I'll try to schedule time to
do a proper research of your suggestion.


> > In other words: it is not enough to have the pfn allocated, we
> > also need xenstore to initialize it. At that point, it is better to do
> > both later from init-dom0less.c.
> See above. My main concern with your proposal is the allocation is split and
> this making more difficult to understand the initialization. Could you write
> some documentation how everything is meant to work?

I can document it a lot better for sure. I'll do that.


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:35:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:35:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297146.506076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5GC-0006yp-NB; Fri, 01 Apr 2022 00:35:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297146.506076; Fri, 01 Apr 2022 00:35:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5GC-0006yi-Jg; Fri, 01 Apr 2022 00:35:28 +0000
Received: by outflank-mailman (input) for mailman id 297146;
 Fri, 01 Apr 2022 00:35:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5GA-0006no-AQ
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:35:26 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f1c30de-b153-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 02:35:25 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id E782EB822B3;
 Fri,  1 Apr 2022 00:35:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 462D7C340F2;
 Fri,  1 Apr 2022 00:35:23 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f1c30de-b153-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773323;
	bh=8PbnGsilja+yuut14P2stMTcQd6UuYjlv35HDSwoKA8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=JlWRS7vVrHJNK/vgMdJM/3rpFSu4SteUlohobtJnip+HQKbqmJEpUST/+/ByXVT1I
	 aFIqgzWJ46lh4QMpb1GgORdnZjI20CWX0jipgFl4CP1j292tT8Ok4LV5GdBaf+Azk6
	 lH/f7vXAokpqyuV+mw/binjyLWlswiMFDLVnN66aGNdiDdxDXJdElQrvkZEXJejTds
	 c+kD6cg8rTEQcXirl5+6Y3S9LzXzathKRESvsb/jmvxpgA2iVLDUi7/Xw1vj2+aeOu
	 OgMOKZUu5cJjjA1WCVYAy3LCii2ZNDn1zt1TQUZBBOQs8vVM3C27DQX8M8ZP0gA2JZ
	 AHQqwLfevJ6Kw==
Date: Thu, 31 Mar 2022 17:35:22 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, 
    Volodymyr_Babchuk@epam.com, Luca Miccio <lucmiccio@gmail.com>, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v3 5/5] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <07fa2884-e497-250b-53ab-dd452b501920@xen.org>
Message-ID: <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop> <20220128213307.2822078-5-sstabellini@kernel.org> <395710eb-ba51-eb67-1519-2a949326f699@xen.org> <alpine.DEB.2.22.394.2203221821520.2910984@ubuntu-linux-20-04-desktop>
 <07fa2884-e497-250b-53ab-dd452b501920@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 28 Mar 2022, Julien Grall wrote:
> On 23/03/2022 02:50, Stefano Stabellini wrote:
> > On Sat, 29 Jan 2022, Julien Grall wrote:
> > > On 28/01/2022 21:33, Stefano Stabellini wrote:
> > > > +    libxl_uuid uuid;
> > > > +    uint64_t v;
> > > > +    int rc;
> > > > +
> > > > +    printf("Init dom0less domain: %d\n", info->domid);
> > > > +    dom.guest_domid = info->domid;
> > > > +    dom.xenstore_domid = 0;
> > > > +    dom.xch = xc_interface_open(0, 0, 0);
> > > > +
> > > > +    rc = xc_hvm_param_get(dom.xch, info->domid, HVM_PARAM_STORE_EVTCHN,
> > > > &v);
> > > > +    if (rc != 0) {
> > > > +        printf("Failed to get HVM_PARAM_STORE_EVTCHN\n");
> > > > +        return 1;
> > > > +    }
> > > > +    dom.xenstore_evtchn = v;
> > > > +
> > > > +    /* Console won't be initialized but set its data for completeness
> > > > */
> > > > +    dom.console_domid = 0;
> > > 
> > > I find a bit odd you set the domid but not the event channel, page. Can
> > > you
> > > explain?
> > > 
> > > Actually, can you explain why only half of the structure is initialized?
> >   We are only using the struct xc_dom_image parameter for
> > xc_dom_gnttab_init, and nothing else. We only need very few fields in
> > it. Basically we could call xc_dom_gnttab_seed directly and then we
> > wouldn't need struct xc_dom_image at all. Only the needed fields are
> > currently populated.
> 
> I would prefer if we don't use xc_dom_image and call xc_dom_gnttab_seed().
> This would:
>   1) reduce the risk that one of the unitialized field is will be mistakenly
> use
>   2) extra documentation (currently missing) to explain which fields is used.

I have done that, it is in v4


> > > > +
> > > > +    /* Alloc magic pages */
> > > > +    if (alloc_magic_pages(info, &dom) != 0) {
> > > > +        printf("Error on alloc magic pages\n");
> > > > +        return 1;
> > > > +    }
> > > > +
> > > > +    xc_dom_gnttab_init(&dom);
> > > 
> > > This call as the risk to break the guest if the dom0 Linux doesn't support
> > > the
> > > acquire interface. This is because it will punch a hole in the domain
> > > memory
> > > where the grant-table may have already been mapped.
> > > 
> > > Also, this function could fails.
> > 
> > I'll check for return errors. Dom0less is for fully static
> > configurations so I think it is OK to return error and abort if
> > something unexpected happens: dom0less' main reason for being is that
> > there is nothing unexpected :-)
> Does this mean the caller will have to reboot the system if there is an error?
> IOW, we don't expect them to call ./init-dom0less twice.

Yes, exactly. I think init-dom0less could even panic. My mental model is
that this is an "extension" of construct_domU. Over there we just panic
if something is wrong and here it would be similar. The user provided a
wrong config and should fix it.


> > > > +
> > > > +    libxl_uuid_generate(&uuid);
> > > > +    xc_domain_sethandle(dom.xch, info->domid,
> > > > libxl_uuid_bytearray(&uuid));
> > > > +
> > > > +    rc = gen_stub_json_config(info->domid, &uuid);
> > > > +    if (rc)
> > > > +        err(1, "gen_stub_json_config");
> > > > +
> > > > +    rc = restore_xenstore(xsh, info, uuid, dom.xenstore_evtchn);
> > > > +    if (rc)
> > > > +        err(1, "writing to xenstore");
> > > > +
> > > > +    xs_introduce_domain(xsh, info->domid,
> > > > +            (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET,
> > > > +            dom.xenstore_evtchn);
> > > 
> > > xs_introduce_domain() can technically fails.
> > 
> > OK
> > 
> > 
> > > > +    return 0;
> > > > +}
> > > > +
> > > > +/* Check if domain has been configured in XS */
> > > > +static bool domain_exists(struct xs_handle *xsh, int domid)
> > > > +{
> > > > +    return xs_is_domain_introduced(xsh, domid);
> > > > +}
> > > 
> > > Would not this lead to initialize a domain with PV driver disabled?
> > 
> > I am not sure I understood your question, but I'll try to answer anyway.
> > This check is purely to distinguish dom0less guests, which needs further
> > initializations, from regular guests (e.g. xl guests) that don't need
> > any actions taken here.
> 
> Dom0less domUs can be divided in two categories based on whether they are xen
> aware (e.g. xen,enhanced is set).
> 
> Looking at this script, it seems to assume that all dom0less domUs are Xen
> aware. So it will end up to allocate Xenstore ring and call
> xs_introduce_domain(). I suspect the call will end up to fail because the
> event channel would be 0.
> 
> So did you try to use this script on a platform where there only xen aware
> domU and/or a mix?

Good idea of asking for this test. I thought I already ran that test,
but I did it again to be sure. Everything works OK (although the
xenstore page allocation is unneeded). xs_introduce_domain does not
fail: I think that's because it is usually called on all domains by the
toolstack, even the ones without xenstore support in the kernel.


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:38:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:38:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297153.506086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JN-0007p6-AC; Fri, 01 Apr 2022 00:38:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297153.506086; Fri, 01 Apr 2022 00:38:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JN-0007oz-7N; Fri, 01 Apr 2022 00:38:45 +0000
Received: by outflank-mailman (input) for mailman id 297153;
 Fri, 01 Apr 2022 00:38:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JM-0007ot-IX
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:44 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 155129bd-b154-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:38:43 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 3BCFCB822B4;
 Fri,  1 Apr 2022 00:38:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2372C340EE;
 Fri,  1 Apr 2022 00:38:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 155129bd-b154-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773522;
	bh=gD62MWAs68ym0DrdkBwu/7pHjmZ6s8wQ6W/cJ2XWfnY=;
	h=Date:From:To:cc:Subject:From;
	b=uNhelSy9DrEG93gfTjadm1VWBqYNdF/owDTro7EPqXZ6R4GxRsKC1bfShzu0CpKhP
	 9Z8QYK6Sw+fArxVlSpzrSnsUk/q8l5CB1pj/qMBA5aSBMOGeC26z36QqP+/+xjymx6
	 +0nHFhxDEyJEDxvyoUGqbYAvwjOoeEvAt7oQUIMkRED1MnMGSSdUdanZhhXtIN4Rqi
	 yaU4XK4GVTPK2bbWay1hqTtBCGbDqt7YxEOFyoghS7n+dAdtB+WHNTVvLd84/RrA/h
	 7OmtvHO36mHm2LOYI9aeGTSNxVwtsM3oFhLZWiKuJSJ+aG284n/JJFN7QSUzBytKzp
	 2ZgoQjmbAE+Ug==
Date: Thu, 31 Mar 2022 17:38:41 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, 
    julien@xen.org, Volodymyr_Babchuk@epam.com
Subject: [PATCH v4 0/9] dom0less PV drivers
Message-ID: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi all,

Currently dom0less guests cannot use PV drivers because they don't have
access to xenstore. Also, the hypervisor node in device tree is missing
so they don't detect that they are running on Xen (thus, they don't try
to enable PV interfaces.)

This patch series enables dom0less guests (on ARM) to use PV drivers.

Instead of initializing xenstore immediately at boot, dom0less guests
get access to xenstore later. They delay the initialization until they
receive a notification via the xenstore event channel (which is
available at boot.)

An example workflow is as follows:
- all domains start in parallel, dom0less guests are immediately running
- when dom0 is up and running, the init-dom0less application is called
- dom0less guests receive the notification and initialize xenstore
- now xl network-attach/disk-attach works as expected for dom0less domUs

The patch series introduces a new dom0less device tree option
"xen,enhanced" (in the Xen device tree) to specify whether PV interfaces
should be enabled/disabled for the dom0less guest.

This patch series is based on Daniel P. Smith's "Introduce XSM ability
for domain privilege escalation".

Cheers,

Stefano


Luca Miccio (3):
      xen/arm: configure dom0less domain for enabling xenstore after boot
      xenstored: send an evtchn notification on introduce_domain
      tools: add example application to initialize dom0less PV drivers

Stefano Stabellini (6):
      xen/dt: dt_property_read_string should return -ENODATA on !length
      xen/arm: implement domU extended regions
      xen/arm: temporarily elevate idle_domain privileged during create_domUs
      xen: export evtchn_alloc_unbound
      xen: introduce xen,enhanced dom0less property
      docs: document dom0less + PV drivers

 docs/features/dom0less.pandoc         |  43 ++++-
 docs/misc/arm/device-tree/booting.txt |  18 ++
 tools/helpers/Makefile                |  13 ++
 tools/helpers/init-dom0less.c         | 323 ++++++++++++++++++++++++++++++++++
 tools/xenstore/xenstored_domain.c     |   3 +
 xen/arch/arm/domain_build.c           |  91 +++++++++-
 xen/arch/arm/include/asm/kernel.h     |   3 +
 xen/common/device_tree.c              |   2 +-
 xen/common/event_channel.c            |   2 +-
 xen/include/xen/event.h               |   3 +
 10 files changed, 493 insertions(+), 8 deletions(-)
 create mode 100644 tools/helpers/init-dom0less.c


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:38:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:38:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297154.506098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JV-00087v-Hu; Fri, 01 Apr 2022 00:38:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297154.506098; Fri, 01 Apr 2022 00:38:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JV-00087o-Ey; Fri, 01 Apr 2022 00:38:53 +0000
Received: by outflank-mailman (input) for mailman id 297154;
 Fri, 01 Apr 2022 00:38:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JU-0007ot-Jc
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:52 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19dab748-b154-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:38:51 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 95DB1617E0;
 Fri,  1 Apr 2022 00:38:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2444C340EE;
 Fri,  1 Apr 2022 00:38:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19dab748-b154-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773530;
	bh=oYEfEy8l6U2mW9uUtnlJVJBSNPmHg0BOI3Jqw79zWpg=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=LosAIRx8EKkGN5sN23o9zUGgfNfLlCKnRLhMacfccGCKaVcYxbYN3GzBUtPqO06HB
	 M47J9rOmaxAZVnwTFRwZt5ndc3rvuyZkljYDm3U1FP8VSg3hX3h5rBw9QGQhRgv59y
	 qQx6CSu13szrd64JCj83L/cMIh9tAvcFDMDAElns3ZFUoVg07vCssUeisidAInWzGw
	 1DfyTtKXHlOOqE03tvcjcnwYBeJXkH9nfvIll3vFK7hhhGLj3UphepbwUwd+RXxcxh
	 5hcmYMBAMo3czQM4ujHKzCpftNLgh3tBUXdOv4opoppiSZc6yaFmMKintJDGTarcE4
	 lc1JwRlNvj+DA==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v4 1/9] xen/dt: dt_property_read_string should return -ENODATA on !length
Date: Thu, 31 Mar 2022 17:38:39 -0700
Message-Id: <20220401003847.38393-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

When the length is zero (pp->length == 0), dt_property_read_string
should return -ENODATA, but actually currently returns -EILSEQ because
there is no specific check for lenght == 0.

Add a check now.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 xen/common/device_tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 4aae281e89..db67fb5fb4 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -198,7 +198,7 @@ int dt_property_read_string(const struct dt_device_node *np,
 
     if ( !pp )
         return -EINVAL;
-    if ( !pp->value )
+    if ( !pp->value || !pp->length )
         return -ENODATA;
     if ( strnlen(pp->value, pp->length) >= pp->length )
         return -EILSEQ;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:38:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:38:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297155.506109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JX-0008Q2-TI; Fri, 01 Apr 2022 00:38:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297155.506109; Fri, 01 Apr 2022 00:38:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JX-0008Pp-Oc; Fri, 01 Apr 2022 00:38:55 +0000
Received: by outflank-mailman (input) for mailman id 297155;
 Fri, 01 Apr 2022 00:38:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JV-0007ot-Jh
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:53 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1a09a9bd-b154-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:38:52 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 16DED618A9;
 Fri,  1 Apr 2022 00:38:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CD37C340F3;
 Fri,  1 Apr 2022 00:38:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a09a9bd-b154-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773530;
	bh=0OtIcFrEIw2wTkzpgYCWd4LgGMpb5c1u12rgi3DHK38=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=KWikBJvm4a+e3wfh3njIghbLerNy6nw4RSt8iHiG8bOGESxipbVQy3Zpy9KdbY3/a
	 rhMGulC4chjFfoIhRAR5so1fAht0Cn6T2xlIM5uOY32dvRLDi4kfhFohiaNhksAU4t
	 iahVtefSe6bm44nSEOIAexzHIP97W8d7+AXsYqk273CFRdz/a2IcwmYRCqGuMEm89o
	 RhF7jnNGMMQ4WHjcyRUbPjdT3qCjqoeyyUpyAy4YyNf1+JxO+RKsj9JR9bEU175/wi
	 rl+63tkacU+wm9Fz5Tm3/7MGwZvSct2Vk1jIcl/SMGwdT7b/Irp0MryIfEIEy8EUQr
	 /nZZM+lC2OmhQ==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v4 2/9] xen/arm: implement domU extended regions
Date: Thu, 31 Mar 2022 17:38:40 -0700
Message-Id: <20220401003847.38393-2-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Implement extended regions for dom0less domUs. The implementation is
based on the libxl implementation.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 xen/arch/arm/domain_build.c | 42 ++++++++++++++++++++++++++++++++++---
 1 file changed, 39 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8be01678de..b6189b935d 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1324,6 +1324,35 @@ out:
     return res;
 }
 
+#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
+
+static int __init find_domU_holes(const struct kernel_info *kinfo,
+                                  struct meminfo *ext_regions)
+{
+    unsigned int i;
+    uint64_t bankend[GUEST_RAM_BANKS];
+    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
+    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
+
+    for ( i = 0; i < GUEST_RAM_BANKS; i++ )
+    {
+        ext_regions->bank[ext_regions->nr_banks].start =
+            ALIGN_UP_TO_2MB(bankbase[i] + kinfo->mem.bank[i].size);
+
+        bankend[i] = ~0ULL >> (64 - p2m_ipa_bits);
+        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
+        if (bankend[i] > ext_regions->bank[ext_regions->nr_banks].start)
+            ext_regions->bank[ext_regions->nr_banks].size =
+                bankend[i] - ext_regions->bank[ext_regions->nr_banks].start + 1;
+
+        /* 64MB is the minimum size of an extended region */
+        if ( ext_regions->bank[ext_regions->nr_banks].size < MB(64) )
+            continue;
+        ext_regions->nr_banks++;
+    }
+    return 0;
+}
+
 static int __init make_hypervisor_node(struct domain *d,
                                        const struct kernel_info *kinfo,
                                        int addrcells, int sizecells)
@@ -1374,10 +1403,17 @@ static int __init make_hypervisor_node(struct domain *d,
         if ( !ext_regions )
             return -ENOMEM;
 
-        if ( !is_iommu_enabled(d) )
-            res = find_unallocated_memory(kinfo, ext_regions);
+        if ( is_domain_direct_mapped(d) )
+        {
+            if ( !is_iommu_enabled(d) )
+                res = find_unallocated_memory(kinfo, ext_regions);
+            else
+                res = find_memory_holes(kinfo, ext_regions);
+        }
         else
-            res = find_memory_holes(kinfo, ext_regions);
+        {
+            res = find_domU_holes(kinfo, ext_regions);
+        }
 
         if ( res )
             printk(XENLOG_WARNING "Failed to allocate extended regions\n");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:38:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:38:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297156.506113 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JY-0008U2-7P; Fri, 01 Apr 2022 00:38:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297156.506113; Fri, 01 Apr 2022 00:38:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JY-0008St-1u; Fri, 01 Apr 2022 00:38:56 +0000
Received: by outflank-mailman (input) for mailman id 297156;
 Fri, 01 Apr 2022 00:38:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JV-00087e-OR
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:53 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1aaad07d-b154-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 02:38:52 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 3AEF8B82277;
 Fri,  1 Apr 2022 00:38:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D83C34113;
 Fri,  1 Apr 2022 00:38:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1aaad07d-b154-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773531;
	bh=9T3+bPtIQN0ln8b/3Ruflzv/jD4YwkoEfs6vAbEsKuo=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=bZubmMK4hA+QRJdgCDdVehxIiX1RH8Ke1lwWCqwQgR806kzHp6rt0hv8Vk8+2ZEDa
	 Zn7hQqnBTjrvR/r8511EpVtOo5WkNEibo1SFIV0unGDaZsSKlC4+S7LKkSxX2ZDBx4
	 8Y3lbNRNrGJwFXrJRvOn1PzTnA9oJo+mL0IZpQAud+ncZWgL4HVNvmkPXsKN7XGTKS
	 aBb4wlk95Lz3rhhBgwXYChylN3e7Csy+vwikE7Z23FpKZYKMr4jo2WRapq9gdaDW8J
	 xfymAwEmm868NeGswBzyIo0Tfyg3PC9M2OTIwN5tCKbSzf8lCfbAu4hDY0Sp4Txl05
	 VxYTIjX+udKMw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v4 3/9] xen/arm: temporarily elevate idle_domain privileged during create_domUs
Date: Thu, 31 Mar 2022 17:38:41 -0700
Message-Id: <20220401003847.38393-3-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

create_domUs might call functions that perform XSM checks on the current
domain, which is idle_domain at this time. Temporarily elevate
idle_domain privileges in create_domUs.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 xen/arch/arm/domain_build.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index b6189b935d..100a4959a8 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -27,6 +27,7 @@
 #include <asm/setup.h>
 #include <asm/cpufeature.h>
 #include <asm/domain_build.h>
+#include <xsm/xsm.h>
 
 #include <xen/irq.h>
 #include <xen/grant_table.h>
@@ -3210,6 +3211,8 @@ void __init create_domUs(void)
     struct dt_device_node *node;
     const struct dt_device_node *chosen = dt_find_node_by_path("/chosen");
 
+    xsm_elevate_priv(current->domain);
+
     BUG_ON(chosen == NULL);
     dt_for_each_child_node(chosen, node)
     {
@@ -3291,6 +3294,8 @@ void __init create_domUs(void)
         if ( construct_domU(d, node) != 0 )
             panic("Could not set up domain %s\n", dt_node_name(node));
     }
+
+    xsm_demote_priv(current->domain);
 }
 
 static int __init construct_dom0(struct domain *d)
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:38:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:38:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297157.506121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JY-0000CP-Or; Fri, 01 Apr 2022 00:38:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297157.506121; Fri, 01 Apr 2022 00:38:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JY-0000Aw-HX; Fri, 01 Apr 2022 00:38:56 +0000
Received: by outflank-mailman (input) for mailman id 297157;
 Fri, 01 Apr 2022 00:38:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JW-0007ot-Jz
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:54 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1b095c28-b154-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:38:53 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id CEC9DB822B6;
 Fri,  1 Apr 2022 00:38:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27851C34111;
 Fri,  1 Apr 2022 00:38:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b095c28-b154-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773531;
	bh=I6q904V+oM8H31/r5qy2ckfV9oZRtQr/EXcn4FzU6PE=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=ONe7h6hEItE8BISUA855nbRyVlJGnEeOXzJPNEFJTGb6iRgBzjRzDd45bUkgXdk0U
	 ARH7PGJRRBM82+ziePeNFPhBanYNmyHDK6xwcPL6/DEEykRi9w/re8qLY0zb6M6Gw9
	 ZhhUeA802QTFvmYMpD0fjTOtYQD2KynMj+fnCezJN/1YlTAnODsp+rUlZQs7BHPZXn
	 duwBvStInn9OoP/pboY5bWf5sUtcKnQQrtTRP3yjxcYIcfPiFEVFrfk96nxb814hQ6
	 st3z7c/mZ1I4w/Q9r2nxMWX/kT07Ld1olEunc5zbGY2/wgwDU5voVMdN1C7oVGJvI5
	 9lSEszHas/9/Q==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v4 4/9] xen: export evtchn_alloc_unbound
Date: Thu, 31 Mar 2022 17:38:42 -0700
Message-Id: <20220401003847.38393-4-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

It will be used during dom0less domains construction.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 xen/common/event_channel.c | 2 +-
 xen/include/xen/event.h    | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index ffb042a241..2f6a89f52d 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -289,7 +289,7 @@ void evtchn_free(struct domain *d, struct evtchn *chn)
     xsm_evtchn_close_post(chn);
 }
 
-static int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc)
+int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc)
 {
     struct evtchn *chn;
     struct domain *d;
diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h
index 21c95e14fd..987e88623a 100644
--- a/xen/include/xen/event.h
+++ b/xen/include/xen/event.h
@@ -71,6 +71,9 @@ void evtchn_free(struct domain *d, struct evtchn *chn);
 /* Allocate a specific event channel port. */
 int evtchn_allocate_port(struct domain *d, unsigned int port);
 
+/* Allocate a new event channel */
+int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc);
+
 /* Unmask a local event-channel port. */
 int evtchn_unmask(unsigned int port);
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:38:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:38:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297158.506130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JZ-0000M7-Hv; Fri, 01 Apr 2022 00:38:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297158.506130; Fri, 01 Apr 2022 00:38:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JZ-0000Ix-4o; Fri, 01 Apr 2022 00:38:57 +0000
Received: by outflank-mailman (input) for mailman id 297158;
 Fri, 01 Apr 2022 00:38:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JW-00087e-HM
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:54 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1aa9e15e-b154-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 02:38:53 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1EB84618B4;
 Fri,  1 Apr 2022 00:38:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94378C340F3;
 Fri,  1 Apr 2022 00:38:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1aa9e15e-b154-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773531;
	bh=4iBLNVmcXHYfyGJi5ahq2ucMYYpPYTlArhpqmmGmD68=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=nugHhDmuLVPBKwkBQFWcN8GC9tJA2q4fcSaHcK1pdagbiVrSuwuVgnIop0kIBoH/A
	 aJHeqD8LdELqK4dxoaghbBO3GwG+TR2bHcIfjeCbEjBWkO1UvO5DGiUzH5YWGcqA1Q
	 rv7xy4fNT/pXsPDiRrlot0E+ZO5M4Mm7K5A4IgklNkUyjMtyQ+oP0cYm3A1hb/6s66
	 jo7xAfSO6mmPiLY4uK0xbsN/nkpW/cCpBMbXKKiFyZg4+6Z8xNpgsyOcCwSUhcQekv
	 Rfkv/xxDn79yK18/6YuXoX6M+ScGfnifrhJYX0vHMmQYmaVpcjq99PyjhVcqZj8E5N
	 M05PTB8JymzxQ==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v4 5/9] xen: introduce xen,enhanced dom0less property
Date: Thu, 31 Mar 2022 17:38:43 -0700
Message-Id: <20220401003847.38393-5-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Introduce a new "xen,enhanced" dom0less property to enable/disable PV
driver interfaces for dom0less guests. Currently only "enabled" and
"disabled" are supported property values (and empty). Leave the option
open to implement further possible values in the future (e.g.
"xenstore" to enable only xenstore.)

The configurable option is for domUs only. For dom0 we always set the
corresponding property in the Xen code to true (PV interfaces enabled.)

This patch only parses the property. Next patches will make use of it.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v4:
- move xen,enhanced to the bottom of the list
- do not set kinfo.dom0less_enhanced for dom0

Changes in v3:
- improve commit message

Changes in v2:
- rename kinfo.enhanced to kinfo.dom0less_enhanced
- set kinfo.dom0less_enhanced to true for dom0
- handle -ENODATA in addition to -EILSEQ
---
 docs/misc/arm/device-tree/booting.txt | 18 ++++++++++++++++++
 xen/arch/arm/domain_build.c           |  7 +++++++
 xen/arch/arm/include/asm/kernel.h     |  3 +++
 3 files changed, 28 insertions(+)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index a94125394e..92097c4969 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -188,6 +188,24 @@ with the following properties:
     An empty property to request the memory of the domain to be
     direct-map (guest physical address == physical address).
 
+- xen,enhanced
+
+    A string property. Possible property values are:
+
+    - "enabled" (or missing property value)
+    Xen PV interfaces, including grant-table and xenstore, will be
+    enabled for the VM.
+
+    - "disabled"
+    Xen PV interfaces are disabled.
+
+    If the xen,enhanced property is present with no value, it defaults
+    to "enabled". If the xen,enhanced property is not present, PV
+    interfaces are disabled.
+
+    In the future other possible property values might be added to
+    enable only selected interfaces.
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 100a4959a8..b22fe95d92 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3150,6 +3150,7 @@ static int __init construct_domU(struct domain *d,
                                  const struct dt_device_node *node)
 {
     struct kernel_info kinfo = {};
+    const char *dom0less_enhanced;
     int rc;
     u64 mem;
 
@@ -3165,6 +3166,12 @@ static int __init construct_domU(struct domain *d,
 
     kinfo.vpl011 = dt_property_read_bool(node, "vpl011");
 
+    rc = dt_property_read_string(node, "xen,enhanced", &dom0less_enhanced);
+    if ( rc == -EILSEQ ||
+         rc == -ENODATA ||
+         (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) )
+        kinfo.dom0less_enhanced = true;
+
     if ( vcpu_create(d, 0) == NULL )
         return -ENOMEM;
 
diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h
index 874aa108a7..c4dc039b54 100644
--- a/xen/arch/arm/include/asm/kernel.h
+++ b/xen/arch/arm/include/asm/kernel.h
@@ -36,6 +36,9 @@ struct kernel_info {
     /* Enable pl011 emulation */
     bool vpl011;
 
+    /* Enable PV drivers */
+    bool dom0less_enhanced;
+
     /* GIC phandle */
     uint32_t phandle_gic;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:38:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:38:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297159.506136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Ja-0000Yr-AM; Fri, 01 Apr 2022 00:38:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297159.506136; Fri, 01 Apr 2022 00:38:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5JZ-0000Vm-QI; Fri, 01 Apr 2022 00:38:57 +0000
Received: by outflank-mailman (input) for mailman id 297159;
 Fri, 01 Apr 2022 00:38:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JX-0007ot-K3
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:55 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1b451931-b154-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:38:54 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2BBB8618AB;
 Fri,  1 Apr 2022 00:38:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A5B1C34112;
 Fri,  1 Apr 2022 00:38:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b451931-b154-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773533;
	bh=1MIKxVGlrxQHtL44VHiQsIws8+/TOeEKbJHjXPBZ7lI=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=LuuxqOnSU2PMw/gWnGe3y0YcxCQe8Kz2xM2QdKzoO0nPrGoikibDmr/yuYLoweInC
	 hE1VvltYj+rH1mbTxz4lJnKIplr4rdytWH96OmGSLRZ++JQBJskqx4MgG/0UTa35lD
	 8yF2MCptNaNvuFZXxR7rkXjN3UoXvnfP9AH6YGaphinRVIRWsMnBe8xnEwVWwAY13q
	 Xy6MfcfqnVYM/seGEQwesKU/Hrw/LzwiNQBkzjegOefRRtvUkZKI4ARTorkPRsIfqC
	 BuN0WSbGd/3DDD2d3s3BaiV7khHLYh5/uzx6Msa4jvXhnLvmg75JADIW/9acsWaDuf
	 gTaeJ82lDBNqw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Luca Miccio <lucmiccio@gmail.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v4 7/9] xenstored: send an evtchn notification on introduce_domain
Date: Thu, 31 Mar 2022 17:38:45 -0700
Message-Id: <20220401003847.38393-7-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

When xs_introduce_domain is called, send out a notification on the
xenstore event channel so that any (dom0less) domain waiting for the
xenstore interface to be ready can continue with the initialization.

The extra notification is harmless for domains that don't require it.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v2:
- drop the new late_init parameter
---
 tools/xenstore/xenstored_domain.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index ae065fcbee..0543f49670 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -493,6 +493,9 @@ static struct domain *introduce_domain(const void *ctx,
 		/* Now domain belongs to its connection. */
 		talloc_steal(domain->conn, domain);
 
+		/* Notify the domain that xenstore is available */
+		xenevtchn_notify(xce_handle, domain->port);
+
 		if (!is_master_domain && !restore)
 			fire_watches(NULL, ctx, "@introduceDomain", NULL,
 				     false, NULL);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:38:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:38:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297160.506145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Jb-0000iw-40; Fri, 01 Apr 2022 00:38:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297160.506145; Fri, 01 Apr 2022 00:38:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Ja-0000dR-Dh; Fri, 01 Apr 2022 00:38:58 +0000
Received: by outflank-mailman (input) for mailman id 297160;
 Fri, 01 Apr 2022 00:38:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JX-00087e-HS
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:55 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b312796-b154-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 02:38:53 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id C13F9B822B4;
 Fri,  1 Apr 2022 00:38:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19EB2C34115;
 Fri,  1 Apr 2022 00:38:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b312796-b154-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773532;
	bh=bKlaACyobMzZqVlommlo53UDbjiZ7/QiZBJFdbFnFaw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=sr8JLH+zcSmfPwQCUPAKzjR2SLXM3cPGkNvqmUK/Qt0Axlv8YNEXep1m+DUwNFTsK
	 1X3skIp36V/NB7Aua1xcSZzqmfNiwO5Ad+s28fZVAk45823hv2qUXnbDSOYvF1f6ML
	 OTT0DgbwrM+fPBvQ3JfQ2e7nmgKkgaT0XDzX/s3eMqB1Ebm81/geyedF5lV28KFLa0
	 xMCcGdueg5ugJMJ8PH7ZH9X1J1x9EAoBMFWCLoD87IUaLVf9VBCWGP9dr1xHgTGAe2
	 KGQPt1DRwFv/4rPmUgkLGXBYCFnOAHTWf5bcKmXQ08jvaa1+OY9n9aS1ws2t0W4SAL
	 kxpma20BU3j4w==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Luca Miccio <lucmiccio@gmail.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v4 6/9] xen/arm: configure dom0less domain for enabling xenstore after boot
Date: Thu, 31 Mar 2022 17:38:44 -0700
Message-Id: <20220401003847.38393-6-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

If "xen,enhanced" is enabled, then add to dom0less domains:

- the hypervisor node in device tree
- the xenstore event channel

The xenstore event channel is also used for the first notification to
let the guest know that xenstore has become available.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

---
Changes in v3:
- use evtchn_alloc_unbound

Changes in v2:
- set HVM_PARAM_STORE_PFN to ~0ULL at domain creation
- in alloc_xenstore_evtchn do not call _evtchn_alloc_unbound
---
 xen/arch/arm/domain_build.c | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index b22fe95d92..a8ad95ce40 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -28,6 +28,7 @@
 #include <asm/cpufeature.h>
 #include <asm/domain_build.h>
 #include <xsm/xsm.h>
+#include <xen/event.h>
 
 #include <xen/irq.h>
 #include <xen/grant_table.h>
@@ -2806,6 +2807,8 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo)
     int ret;
 
     kinfo->phandle_gic = GUEST_PHANDLE_GIC;
+    kinfo->gnttab_start = GUEST_GNTTAB_BASE;
+    kinfo->gnttab_size = GUEST_GNTTAB_SIZE;
 
     addrcells = GUEST_ROOT_ADDRESS_CELLS;
     sizecells = GUEST_ROOT_SIZE_CELLS;
@@ -2880,6 +2883,13 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo)
             goto err;
     }
 
+    if ( kinfo->dom0less_enhanced )
+    {
+        ret = make_hypervisor_node(d, kinfo, addrcells, sizecells);
+        if ( ret )
+            goto err;
+    }
+
     ret = fdt_end_node(kinfo->fdt);
     if ( ret < 0 )
         goto err;
@@ -3146,6 +3156,25 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo)
     return 0;
 }
 
+static int __init alloc_xenstore_evtchn(struct domain *d)
+{
+    evtchn_alloc_unbound_t alloc;
+    int rc;
+
+    alloc.dom = d->domain_id;
+    alloc.remote_dom = hardware_domain->domain_id;
+    rc = evtchn_alloc_unbound(&alloc);
+    if ( rc )
+    {
+        printk("Failed allocating event channel for domain\n");
+        return rc;
+    }
+
+    d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port;
+
+    return 0;
+}
+
 static int __init construct_domU(struct domain *d,
                                  const struct dt_device_node *node)
 {
@@ -3210,6 +3239,14 @@ static int __init construct_domU(struct domain *d,
     if ( rc < 0 )
         return rc;
 
+    if ( kinfo.dom0less_enhanced )
+    {
+        rc = alloc_xenstore_evtchn(d);
+        if ( rc < 0 )
+            return rc;
+        d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL;
+    }
+
     return rc;
 }
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:39:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:39:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297161.506152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Jb-0000zD-Rx; Fri, 01 Apr 2022 00:38:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297161.506152; Fri, 01 Apr 2022 00:38:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Jb-0000wH-Ej; Fri, 01 Apr 2022 00:38:59 +0000
Received: by outflank-mailman (input) for mailman id 297161;
 Fri, 01 Apr 2022 00:38:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JY-0007ot-KL
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:56 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1c1ac557-b154-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:38:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 9E1E3618B8;
 Fri,  1 Apr 2022 00:38:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF26EC340F2;
 Fri,  1 Apr 2022 00:38:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c1ac557-b154-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773534;
	bh=SyJ8d/AZr5XFzu3v/AGdBw4+YWs6wkcRBAD8+aGiIR8=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=ZNcF/aqp8YX0OngKR48lncjoj4oL3Gi2+JJHtCOdyA2QN/Kq7MCfGqZuJBFFR6EF7
	 7TxsX4uFnSgfelEtrkvyZVBSNITXikzOppt7A75SrAO1impSlpVT1bsDHAZpjKXHTd
	 lJYpdwrWCrPdesQCZcou81J0K4uRZ7rIxcDO3IOF2BH6Ain5V79Ymfv6m40D+hKaIs
	 DUrRdWD1HtmOjxOPfjqIgTIuxQ0I/9ZmjNum0jbdWitO8B4OMJ/BqgCkTE3jRdz5Gg
	 2tN0UieyjWC3vXnW3dLjYmekJaqBoVnwKKT/YbNjPLq4Rhfq9ioUX9sWd/8LWmunPw
	 qSDQ4wMfiPlTg==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v4 9/9] docs: document dom0less + PV drivers
Date: Thu, 31 Mar 2022 17:38:47 -0700
Message-Id: <20220401003847.38393-9-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Document how to use the feature and how the implementation works.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 docs/features/dom0less.pandoc | 43 ++++++++++++++++++++++++++++++++---
 1 file changed, 40 insertions(+), 3 deletions(-)

diff --git a/docs/features/dom0less.pandoc b/docs/features/dom0less.pandoc
index c9edb529e1..725afa0558 100644
--- a/docs/features/dom0less.pandoc
+++ b/docs/features/dom0less.pandoc
@@ -90,6 +90,46 @@ Otherwise, they may be unusable in Xen (for instance if they are compressed).
 
 See docs/misc/arm/device-tree/booting.txt for more information.
 
+PV Drivers
+----------
+
+It is possible to use PV drivers with dom0less guests with some
+restrictions:
+
+- dom0less domUs that want to use PV drivers support should have the
+  "xen,enhanced" property set under their device tree nodes (see
+  docs/misc/arm/device-tree/booting.txt)
+- a dom0 must be present (or another domain with enough privileges to
+  run the toolstack)
+- after dom0 is booted, the utility "init-dom0less" must be run
+- do not run "init-dom0less" while creating other guests with xl
+
+After the execution of init-dom0less, it is possible to use "xl" to
+hotplug PV drivers to dom0less guests. E.g. xl network-attach domU.
+
+The implementation works as follows:
+- Xen allocates the xenstore event channel for each dom0less domU that
+  has the "xen,enhanced" property, and sets HVM_PARAM_STORE_EVTCHN
+- Xen does *not* allocate the xenstore page and sets HVM_PARAM_STORE_PFN
+  to ~0ULL (invalid)
+- Dom0less domU kernels check that HVM_PARAM_STORE_PFN is set to invalid
+    - Old kernels will continue without xenstore support (Note: some old
+      buggy kernels might crash because they don't check the validity of
+      HVM_PARAM_STORE_PFN before using it! Disable "xen,enhanced" in
+      those cases)
+    - New kernels will wait for a notification on the xenstore event
+      channel (HVM_PARAM_STORE_EVTCHN) before continuing with the
+      initialization
+- Once dom0 is booted, init-dom0less is executed:
+    - it allocates the xenstore shared page and sets HVM_PARAM_STORE_PFN
+    - it calls xs_introduce_domain
+- Xenstored notices the new domain, initializes interfaces as usual, and
+  sends an event channel notification to the domain using the xenstore
+  event channel (HVM_PARAM_STORE_EVTCHN)
+- The Linux domU kernel receives the event channel notification, checks
+  HVM_PARAM_STORE_PFN again and continue with the initialization
+
+
 Limitations
 -----------
 
@@ -107,9 +147,6 @@ limitations:
   information, the GIC version exposed to the domains started by Xen at
   boot is the same as the native GIC version.
 
-- No PV drivers. There is no support for PV devices at the moment. All
-  devices need to be statically assigned to guests.
-
 - Pinning vCPUs of domains started by Xen at boot can be
   done from the control domain, using `xl vcpu-pin` as usual. It is not
   currently possible to configure vCPU pinning without a control domain.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:39:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:39:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297162.506163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Jd-0001A7-1H; Fri, 01 Apr 2022 00:39:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297162.506163; Fri, 01 Apr 2022 00:39:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Jc-00014u-60; Fri, 01 Apr 2022 00:39:00 +0000
Received: by outflank-mailman (input) for mailman id 297162;
 Fri, 01 Apr 2022 00:38:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5JZ-0007ot-KP
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:38:57 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1ba970c0-b154-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:38:54 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C1EB7618CB;
 Fri,  1 Apr 2022 00:38:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2859CC340F0;
 Fri,  1 Apr 2022 00:38:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ba970c0-b154-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773533;
	bh=aVUhLT0k6h5mW+XusXYNb4z2CYJuj6jR5xtLUX9su5M=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=Ir72MTrGrRy2EOi7JInOLn7cruQ7kEHSvKpOcWVdTEUdKqUw9I4eCbEEOtpW3S0oI
	 WyP+GzNyLMK9UPouiHfw979AOim5RF3ZM8d9JPTI6wKojzSXb2aBAiHjUiAuRxOz9S
	 rb8/iS450aZVqwBoOgJORj2CMT6d27g5E8Hf71Dgsk3vXTRvCExW3XFz5okDb393uu
	 r6UtcBA+7GPC/dhMmqzGsNWoiKF99IvmWpKt0cYCv/BxnWCXt+ZcTstfWhhGAim26P
	 fWX6Dy2+hVUcpyNHkBgOTaDgz0eOONIy1NbgQwI09buAwZJzPcVbGe42rbcjKd8wyU
	 GTomF3CPizitw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Luca Miccio <lucmiccio@gmail.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v4 8/9] tools: add example application to initialize dom0less PV drivers
Date: Thu, 31 Mar 2022 17:38:46 -0700
Message-Id: <20220401003847.38393-8-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

Add an example application that can be run in dom0 to complete the
dom0less domains initialization so that they can get access to xenstore
and use PV drivers.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
---
Changes in v4:
- only alloc xs page (no other magic pages)
- add xenstore permissions
- check all return values
- rename restore_xenstore to create_xenstore
- set target_memkb
- set start_time properly
- close xs transaction on error
- call xc_dom_gnttab_seed instead of xc_dom_gnttab_init
- xs_open instead of xs_daemon_open

Changes in v3:
- handle xenstore errors
- add an in-code comment about xenstore entries
- less verbose output
- clean-up error path in main

Changes in v2:
- do not set HVM_PARAM_STORE_EVTCHN twice
- rename restore_xenstore to create_xenstore
- increase maxmem
---
 tools/helpers/Makefile        |  13 ++
 tools/helpers/init-dom0less.c | 323 ++++++++++++++++++++++++++++++++++
 2 files changed, 336 insertions(+)
 create mode 100644 tools/helpers/init-dom0less.c

diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile
index 7f6c422440..8e42997052 100644
--- a/tools/helpers/Makefile
+++ b/tools/helpers/Makefile
@@ -10,6 +10,9 @@ ifeq ($(CONFIG_Linux),y)
 ifeq ($(CONFIG_X86),y)
 PROGS += init-xenstore-domain
 endif
+ifeq ($(CONFIG_ARM),y)
+PROGS += init-dom0less
+endif
 endif
 
 XEN_INIT_DOM0_OBJS = xen-init-dom0.o init-dom-json.o
@@ -26,6 +29,13 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h
 
+INIT_DOM0LESS_OBJS = init-dom0less.o init-dom-json.o
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxentoollog)
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenstore)
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenlight)
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenctrl)
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenevtchn)
+
 .PHONY: all
 all: $(PROGS)
 
@@ -35,6 +45,9 @@ xen-init-dom0: $(XEN_INIT_DOM0_OBJS)
 init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS)
 	$(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS)
 
+init-dom0less: $(INIT_DOM0LESS_OBJS)
+	$(CC) $(LDFLAGS) -o $@ $(INIT_DOM0LESS_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenevtchn) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(LDLIBS_libxenguest)  $(APPEND_LDFLAGS)
+
 .PHONY: install
 install: all
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c
new file mode 100644
index 0000000000..dc9ccee868
--- /dev/null
+++ b/tools/helpers/init-dom0less.c
@@ -0,0 +1,323 @@
+#include <stdbool.h>
+#include <syslog.h>
+#include <stdio.h>
+#include <err.h>
+#include <stdlib.h>
+#include <sys/time.h>
+#include <xenstore.h>
+#include <xenctrl.h>
+#include <xenguest.h>
+#include <libxl.h>
+#include <xenevtchn.h>
+
+#include "init-dom-json.h"
+
+#define XENSTORE_PFN_OFFSET 1
+#define STR_MAX_LENGTH 64
+
+static int alloc_xs_page(struct xc_interface_core *xch,
+                         libxl_dominfo *info,
+                         uint64_t *xenstore_pfn)
+{
+    int rc;
+    const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT;
+    xen_pfn_t p2m = (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET;
+
+    rc = xc_domain_setmaxmem(xch, info->domid,
+                             info->max_memkb + (XC_PAGE_SIZE/1024));
+    if (rc < 0)
+        return rc;
+
+    rc = xc_domain_populate_physmap_exact(xch, info->domid, 1, 0, 0, &p2m);
+    if (rc < 0)
+        return rc;
+
+    *xenstore_pfn = base + XENSTORE_PFN_OFFSET;
+    rc = xc_clear_domain_page(xch, info->domid, *xenstore_pfn);
+    if (rc < 0)
+        return rc;
+
+    return 0;
+}
+
+static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t,
+                            domid_t domid, char *path, char *val)
+{
+    char full_path[STR_MAX_LENGTH];
+    struct xs_permissions perms[2];
+
+    perms[0].id = domid;
+    perms[0].perms = XS_PERM_NONE;
+    perms[1].id = 0;
+    perms[1].perms = XS_PERM_READ;
+
+    if (snprintf(full_path, STR_MAX_LENGTH,
+                 "/local/domain/%u/%s", domid, path) < 0)
+        return false;
+    if (!xs_write(xsh, t, full_path, val, strlen(val)))
+        return false;
+    return xs_set_permissions(xsh, t, full_path, perms, 2);
+}
+
+static bool do_xs_write_libxl(struct xs_handle *xsh, xs_transaction_t t,
+                              domid_t domid, char *path, char *val)
+{
+    char full_path[STR_MAX_LENGTH];
+
+    if (snprintf(full_path, STR_MAX_LENGTH,
+                 "/libxl/%u/%s", domid, path) < 0)
+        return false;
+    return xs_write(xsh, t, full_path, val, strlen(val));
+}
+
+static bool do_xs_write_vm(struct xs_handle *xsh, xs_transaction_t t,
+                           libxl_uuid uuid, char *path, char *val)
+{
+    char full_path[STR_MAX_LENGTH];
+
+    if (snprintf(full_path, STR_MAX_LENGTH,
+                 "/vm/" LIBXL_UUID_FMT "/%s", LIBXL_UUID_BYTES(uuid), path) < 0)
+        return false;
+    return xs_write(xsh, t, full_path, val, strlen(val));
+}
+
+/*
+ * The xenstore nodes are the xenstore nodes libxl writes at domain
+ * creation.
+ *
+ * The list was retrieved by running xenstore-ls on a corresponding
+ * domain started by xl/libxl.
+ */
+static int create_xenstore(struct xs_handle *xsh,
+                           libxl_dominfo *info, libxl_uuid uuid,
+                           evtchn_port_t xenstore_port)
+{
+    domid_t domid;
+    unsigned int i;
+    char uuid_str[STR_MAX_LENGTH];
+    char dom_name_str[STR_MAX_LENGTH];
+    char vm_val_str[STR_MAX_LENGTH];
+    char id_str[STR_MAX_LENGTH];
+    char max_memkb_str[STR_MAX_LENGTH];
+    char target_memkb_str[STR_MAX_LENGTH];
+    char cpu_str[STR_MAX_LENGTH];
+    char xenstore_port_str[STR_MAX_LENGTH];
+    char ring_ref_str[STR_MAX_LENGTH];
+    xs_transaction_t t;
+    struct timeval start_time;
+    char start_time_str[STR_MAX_LENGTH];
+    int rc;
+
+    if (gettimeofday(&start_time, NULL) < 0)
+        return -errno;
+    rc = snprintf(start_time_str, STR_MAX_LENGTH, "%jd.%02d",
+            (intmax_t)start_time.tv_sec, (int)start_time.tv_usec / 10000);
+    if (rc < 0)
+        return rc;
+
+    domid = info->domid;
+    rc = snprintf(id_str, STR_MAX_LENGTH, "%u", domid);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(dom_name_str, STR_MAX_LENGTH, "dom0less-%u", domid);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(uuid_str, STR_MAX_LENGTH, LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid));
+    if (rc < 0)
+        return rc;
+    rc = snprintf(vm_val_str, STR_MAX_LENGTH,
+                  "vm/" LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid));
+    if (rc < 0)
+        return rc;
+    rc = snprintf(max_memkb_str, STR_MAX_LENGTH, "%lu", info->max_memkb);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(target_memkb_str, STR_MAX_LENGTH, "%lu", info->current_memkb);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(ring_ref_str, STR_MAX_LENGTH, "%lld",
+                  (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(xenstore_port_str, STR_MAX_LENGTH, "%u", xenstore_port);
+    if (rc < 0)
+        return rc;
+
+retry_transaction:
+    t = xs_transaction_start(xsh);
+    if (t == XBT_NULL)
+        return -errno;
+
+    rc = -EIO;
+    /* /vm */
+    if (!do_xs_write_vm(xsh, t, uuid, "name", dom_name_str)) goto err;
+    if (!do_xs_write_vm(xsh, t, uuid, "uuid", uuid_str)) goto err;
+    if (!do_xs_write_vm(xsh, t, uuid, "start_time", start_time_str)) goto err;
+
+    /* /domain */
+    if (!do_xs_write_dom(xsh, t, domid, "vm", vm_val_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "name", dom_name_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "cpu", "")) goto err;
+    for (i = 0; i < info->vcpu_max_id; i++) {
+        rc = snprintf(cpu_str, STR_MAX_LENGTH, "cpu/%u/availability/", i);
+        if (rc < 0)
+            goto err;
+        rc = -EIO;
+        if (!do_xs_write_dom(xsh, t, domid, cpu_str,
+                             (info->cpupool & (1 << i)) ? "online" : "offline"))
+            goto err;
+    }
+
+    if (!do_xs_write_dom(xsh, t, domid, "memory", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "memory/static-max", max_memkb_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "memory/target", target_memkb_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "memory/videoram", "-1")) goto err;
+
+    if (!do_xs_write_dom(xsh, t, domid, "device", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "device/suspend", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "device/suspend/event-channel", "")) goto err;
+
+    if (!do_xs_write_dom(xsh, t, domid, "control", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/shutdown", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/feature-poweroff", "1")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/feature-reboot", "1")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/feature-suspend", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/sysrq", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-multiprocessor-suspend", "1")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-xs_reset_watches", "1")) goto err;
+
+    if (!do_xs_write_dom(xsh, t, domid, "domid", id_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "data", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "drivers", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "feature", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "attr", "")) goto err;
+
+    if (!do_xs_write_dom(xsh, t, domid, "store/port", xenstore_port_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "store/ring-ref", ring_ref_str)) goto err;
+
+    if (!do_xs_write_libxl(xsh, t, domid, "type", "pvh")) goto err;
+    if (!do_xs_write_libxl(xsh, t, domid, "dm-version", "qemu_xen")) goto err;
+
+    if (!xs_transaction_end(xsh, t, false)) {
+        if (errno == EAGAIN)
+            goto retry_transaction;
+        else
+            return -errno;
+    }
+
+    return 0;
+
+err:
+    xs_transaction_end(xsh, t, true);
+    return rc;
+}
+
+static int init_domain(struct xs_handle *xsh, libxl_dominfo *info)
+{
+    struct xc_interface_core *xch;
+    libxl_uuid uuid;
+    uint64_t xenstore_evtchn, xenstore_pfn;
+    int rc;
+
+    printf("Init dom0less domain: %u\n", info->domid);
+    xch = xc_interface_open(0, 0, 0);
+
+    rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN,
+                          &xenstore_evtchn);
+    if (rc != 0) {
+        printf("Failed to get HVM_PARAM_STORE_EVTCHN\n");
+        return 1;
+    }
+
+    /* Alloc xenstore page */
+    if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) {
+        printf("Error on alloc magic pages\n");
+        return 1;
+    }
+
+    rc = xc_dom_gnttab_seed(xch, info->domid, true,
+                            (xen_pfn_t)-1, xenstore_pfn, 0, 0);
+    if (rc)
+        err(1, "xc_dom_gnttab_seed");
+
+    libxl_uuid_generate(&uuid);
+    xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid));
+
+    rc = gen_stub_json_config(info->domid, &uuid);
+    if (rc)
+        err(1, "gen_stub_json_config");
+
+    /* Now everything is ready: set HVM_PARAM_STORE_PFN */
+    rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN,
+                          xenstore_pfn);
+    if (rc < 0)
+        return rc;
+
+    rc = create_xenstore(xsh, info, uuid, xenstore_evtchn);
+    if (rc)
+        err(1, "writing to xenstore");
+
+    rc = xs_introduce_domain(xsh, info->domid,
+            (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET,
+            xenstore_evtchn);
+    if (!rc)
+        err(1, "xs_introduce_domain");
+    return 0;
+}
+
+/* Check if domain has been configured in XS */
+static bool domain_exists(struct xs_handle *xsh, int domid)
+{
+    return xs_is_domain_introduced(xsh, domid);
+}
+
+int main(int argc, char **argv)
+{
+    libxl_dominfo *info = NULL;
+    libxl_ctx *ctx;
+    int nb_vm = 0, rc = 0, i;
+    struct xs_handle *xsh = NULL;
+
+    /* TODO reuse libxl xsh connection */
+    xsh = xs_open(0);
+    if (xsh == NULL) {
+        fprintf(stderr, "Could not contact XenStore");
+        rc = -errno;
+        goto out;
+    }
+
+    rc = libxl_ctx_alloc(&ctx, LIBXL_VERSION, 0, NULL);
+    if (rc) {
+        fprintf(stderr, "cannot init xl context\n");
+        goto out;
+    }
+
+    info = libxl_list_domain(ctx, &nb_vm);
+    if (!info) {
+        fprintf(stderr, "libxl_list_vm failed.\n");
+        rc = -1;
+        goto out;
+    }
+
+    for (i = 0; i < nb_vm; i++) {
+        domid_t domid = info[i].domid;
+
+        /* Don't need to check for Dom0 */
+        if (!domid)
+            continue;
+
+        printf("Checking domid: %u\n", domid);
+        if (!domain_exists(xsh, domid)) {
+            rc = init_domain(xsh, &info[i]);
+            if (rc < 0) {
+                fprintf(stderr, "init_domain failed.\n");
+                goto out;
+            }
+        } else {
+            printf("Domain %u has already been initialized\n", domid);
+        }
+    }
+out:
+    libxl_dominfo_list_free(info, nb_vm);
+    return rc;
+}
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 00:46:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 00:46:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297185.506197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Qj-00065z-GZ; Fri, 01 Apr 2022 00:46:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297185.506197; Fri, 01 Apr 2022 00:46:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na5Qj-00065s-D8; Fri, 01 Apr 2022 00:46:21 +0000
Received: by outflank-mailman (input) for mailman id 297185;
 Fri, 01 Apr 2022 00:46:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1na5Qi-00065m-7J
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 00:46:20 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2469a72b-b155-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 02:46:19 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id E3654618B4;
 Fri,  1 Apr 2022 00:46:17 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F14CDC340EE;
 Fri,  1 Apr 2022 00:46:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2469a72b-b155-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648773977;
	bh=nL9OOS2GUK9hVMygYq7DQDwBRpyIvChJ46/D+IotTPY=;
	h=Date:From:To:cc:Subject:From;
	b=dqdSbn9TTy3oGM2lkkrVCTZTNSFA9ek4UshBPEPNCXQ0mfYwe4NHlcxGiXnCjpo72
	 ObAIdp+wQbhFKe0MQOYStUB9R+b1BQwajcC5pPP5PdjUcqzccV3o5XjvrpRSy/Hzsd
	 C1YPAoCM/Ry463nQECOX4RinywUTHzRu/rSdAi50MNhSfmFivPT8+Quz/V/QapfDHs
	 yIV+QcjvYwePbgwX0ieZ2762SyJrZQ9HCtgFIwzZB5tcSw1P/pykoX59k6RDpNDzSj
	 +txUKqux8A1i0w9VNXo706Ws40D2f9I1BPG47j9EgTVRKs1BuSuKwvTOY/lAvF6/fx
	 ZznWJ3xvaVZ6A==
Date: Thu, 31 Mar 2022 17:46:16 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: robh+dt@kernel.org, frowand.list@gmail.com
cc: sstabellini@kernel.org, devicetree@vger.kernel.org, julien@xen.org, 
    xen-devel@lists.xenproject.org
Subject: [PATCH] of: of_property_read_string return -ENODATA when !length
Message-ID: <alpine.DEB.2.22.394.2203311740450.2910984@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

When the length of the string is zero of_property_read_string should
return -ENODATA according to the description of the function.

However, of_property_read_string doesn't check pp->length. If pp->length
is zero, return -ENODATA.

Without this patch the following command in u-boot:

fdt set /chosen/node property-name

results in of_property_read_string returning -EILSEQ when attempting to
read property-name. With this patch, it returns -ENODATA as expected.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 8e90071de6ed..da0f02c98bb2 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -439,7 +439,7 @@ int of_property_read_string(const struct device_node *np, const char *propname,
 	const struct property *prop = of_find_property(np, propname, NULL);
 	if (!prop)
 		return -EINVAL;
-	if (!prop->value)
+	if (!prop->value || !pp->length)
 		return -ENODATA;
 	if (strnlen(prop->value, prop->length) >= prop->length)
 		return -EILSEQ;


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 04:53:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 04:53:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297216.506253 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na9Hp-0005Bq-JK; Fri, 01 Apr 2022 04:53:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297216.506253; Fri, 01 Apr 2022 04:53:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na9Hp-0005BP-BK; Fri, 01 Apr 2022 04:53:25 +0000
Received: by outflank-mailman (input) for mailman id 297216;
 Fri, 01 Apr 2022 04:53:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na9Hn-0005BF-KX; Fri, 01 Apr 2022 04:53:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na9Hn-0004Ox-Dn; Fri, 01 Apr 2022 04:53:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na9Hn-0002VL-5R; Fri, 01 Apr 2022 04:53:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1na9Hn-0005aY-4x; Fri, 01 Apr 2022 04:53:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=j8KEnp8i73HAAr6ZrzOTE+X86dU4F1o11VSSZ4Bs9ZE=; b=ZR0F+tDZaEJMsr81G3J6+sfGmI
	fnFPl+zvkxvZlzn+aeOGu8xyTXmjILta96Idizinkj9VSlEB7PHYa9LQ+I+eQKJu4goZkr6tJ6khD
	Og6WpfzQMxwFMC9NEpRW2VY4ELIX4LZRnx/eOvSb5hKN3FY6GZEaoSbZBpSqqgjTMfos=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169055-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169055: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=787af64d05cd528aac9ad16752d11bb1c6061bb9
X-Osstest-Versions-That:
    linux=13776ebb9964b2ea66ffb8c824c0762eed6da784
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 04:53:23 +0000

flight 169055 linux-linus real [real]
flight 169095 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169055/
http://logs.test-lab.xenproject.org/osstest/logs/169095/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm       8 xen-boot            fail pass in 169095-retest
 test-arm64-arm64-libvirt-xsm 13 debian-fixup        fail pass in 169095-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 169095 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 169095 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 169095 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 169095 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168997
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168997
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168997
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168997
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168997
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168997
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168997
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168997
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                787af64d05cd528aac9ad16752d11bb1c6061bb9
baseline version:
 linux                13776ebb9964b2ea66ffb8c824c0762eed6da784

Last test of basis   168997  2022-03-29 20:43:57 Z    2 days
Testing same since   169055  2022-03-31 02:32:32 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abel Vesa <abel.vesa@nxp.com>
  Adam Wujek <dev_public@wujek.eu>
  Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
  Alain Volmat <alain.volmat@foss.st.com>
  Alexandre Belloni <alexandre.belloni@bootlin.com>
  Alexey Khoroshilov <khoroshilov@ispras.ru>
  Alistair Delva <adelva@google.com>
  Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
  Amelie Delaunay <amelie.delaunay@foss.st.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Ansuel Smith <ansuelsmth@gmail.com>
  Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
  Bartosz Dudziak <bartosz.dudziak@snejp.pl>
  Benjamin Coddington <bcodding@redhat.com>
  Bhupesh Sharma <bhupesh.sharma@linaro.org>
  Biju Das <biju.das.jz@bp.renesas.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Cai Huoqing <cai.huoqing@linux.dev>
  Caleb Connolly <caleb@connolly.tech>
  Chen-Yu Tsai <wenst@chromium.org>
  ChiYuan Huang <cy_huang@richtek.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Clemens Gruber <clemens.gruber@pqgruber.com>
  Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
  Colin Ian King <colin.i.king@gmail.com>
  Conor Dooley <conor.dooley@microchip.com>
  Daire McNamara <daire.mcnamara@microchip.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Latypov <dlatypov@google.com>
  Daniel Mack <daniel@zonque.org>
  Dave Gerlach <d-gerlach@ti.com>
  Dave Jiang <dave.jiang@intel.com>
  Dave Kleikamp <dave.kleikamp@oracle.com>
  Dave Wysochanski <dwysocha@redhat.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dirk Buchwalder <buchwalder@posteo.de>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Osipenko <dmitry.osipenko@collabora.com> # T30 Nexus7
  Drew Fustini <dfustini@baylibre.com>
  Emil Renner Berthing <kernel@esmil.dk>
  Florian Fainelli <f.fainelli@gmail.com>
  Gabriel Fernandez <gabriel.fernandez@foss.st.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Giulio Benetti <giulio.benetti@benettiengineering.com>
  Guenter Roeck <linux@roeck-us.net>
  Gustavo A. R. Silva <gustavoars@kernel.org>
  Haimin Zhang <tcs_kernel@tencent.com>
  Hector Martin <marcan@marcan.st>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Jacky Bai <ping.bai@nxp.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  Jami Kettunen <jami.kettunen@somainline.org>
  Jamie Iles <quic_jiles@quicinc.com>
  Jeff LaBundy <jeff@labundy.com>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jesse Taube <Mr.Bossman075@gmail.com>
  Jie Hai <haijie1@huawei.com>
  Johann Neuhauser <jneuhauser@dh-electronics.com>
  John David Anglin <dave.anglin@bell.net>
  Jonathan McDowell <noodles@earth.li>
  Jonathan Neuschäfer <j.neuschaefer@gmx.net>
  José Expósito <jose.exposito89@gmail.com>
  Julia Lawall <Julia.Lawall@inria.fr>
  Kajol Jain <kjain@linux.ibm.com>
  Konrad Dybcio <konrad.dybcio@somainline.org>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  Lee Jones <lee.jones@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Lionel Vitte <lionel.vitte@free.fr>
  Lionel Vitte <lionel.vitte@gmail.com>
  Loic Poulain <loic.poulain@linaro.org>
  Luca Weiss <luca@z3ntu.xyz>
  Luis Chamberlain <mcgrof@kernel.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
  Marek Vasut <marex@denx.de>
  Marijn Suijten <marijn.suijten@somainline.org>
  Mark Brown <broonie@kernel.org>
  Martin Botka <martin.botka@somainline.org>
  Martin Povišer <povik+lin@cutebit.org>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Maxime Ripard <maxime@cerno.tech>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Tretter <m.tretter@pengutronix.de>
  Michal Simek <michal.simek@xilinx.com>
  Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
  Nageswara R Sastry <rnsastry@linux.ibm.com>
  Neil Armstrong <narmstrong@baylibre.com>
  NeilBrown <neilb@suse.de>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nikita Yushchenko <nikita.yoush@cogentembedded.com>
  Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
  Olga Kornievskaia <kolga@netapp.com>
  Olivier Dautricourt <olivier.dautricourt@orolia.com>
  Padmarao Begari <padmarao.begari@microchip.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paul Cercueil <paul@crapouillou.net>
  Pavel Skripkin <paskripkin@gmail.com>
  Peng Fan <peng.fan@nxp.com>
  Peter Ujfalusi <peter.ujfalusi@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Petr Vorel <petr.vorel@gmail.com>
  Philipp Zabel <p.zabel@pengutronix.de>
  Pratyush Yadav <p.yadav@ti.com>
  Puranjay Mohan <p-mohan@ti.com>
  Qing Wang <wangqing@vivo.com>
  Quentin Schulz <quentin.schulz@theobroma-systems.com>
  Rakesh Pillai <pillair@codeaurora.org>
  Rob Herring <robh@kernel.org>
  Robert Marko <robimarko@gmail.com>
  Rohit Agarwal <quic_rohiagar@quicinc.com>
  Sanjay R Mehta <sanju.mehta@amd.com>
  Sascha Hauer <s.hauer@pengutronix.de>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Sinthu Raja <sinthu.raja@ti.com>
  Stephan Gerhold <stephan@gerhold.net>
  Stephen Boyd <sboyd@kernel.org>
  Suman Anna <s-anna@ti.com>
  Sven Peter <sven@svenpeter.dev>
  Taniya Das <tdas@codeaurora.org>
  Thierry Reding <thierry.reding@gmail.com>
  Thierry Reding <treding@nvidia.com>
  Tim Blechmann <tim@klingt.org>
  Tom Rix <trix@redhat.com>
  Tomasz Moń <tomasz.mon@camlingroup.com>
  Tony Lindgren <tony@atomide.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Ulrich Hecht <uli+renesas@fpond.eu>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vignesh Raghavendra <vigneshr@ti.com>
  Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
  Vinod Koul <vkoul@kernel.org>
  Wang Qing <wangqing@vivo.com>
  Xin Tan <tanxin.ctf@gmail.com>
  Xin Xiong <xiongx18@fudan.edu.cn>
  Xiyu Yang <xiyuyang19@fudan.edu.cn>
  Yang Li <yang.lee@linux.alibaba.com>
  Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  zhaoxiao <zhaoxiao@uniontech.com>
  Zhou Wang <wangzhou1@hisilicon.com>
  Zi Yan <ziy@nvidia.com>
  Zixun LI <admin@hifiphile.com>
  Zong Li <zong.li@sifive.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   13776ebb9964..787af64d05cd  787af64d05cd528aac9ad16752d11bb1c6061bb9 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 05:07:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 05:07:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297224.506264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na9Vf-000730-PS; Fri, 01 Apr 2022 05:07:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297224.506264; Fri, 01 Apr 2022 05:07:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1na9Vf-00072t-Lo; Fri, 01 Apr 2022 05:07:43 +0000
Received: by outflank-mailman (input) for mailman id 297224;
 Fri, 01 Apr 2022 05:07:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na9Vd-00072e-Nj; Fri, 01 Apr 2022 05:07:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na9Vd-0004y5-LB; Fri, 01 Apr 2022 05:07:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1na9Vd-00035W-Dr; Fri, 01 Apr 2022 05:07:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1na9Vd-000421-DM; Fri, 01 Apr 2022 05:07:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rp8Nvq50fYbsAZNue11guFmntkbi2k84qGjscxgmae4=; b=H/OImg+Vqzbqb3r7HmH1nkkzVW
	yFzfyxSZrk5MFktHw+K7kPWqdEbdVJthjplxXu6kdhbeIujrUe9lKNzDXRFNk2CItnwrTUfwGfJ8P
	wwtXW4hFGgJaGUQK2PQnNokkgNv+egbOMtuJzk6xBgexvOTnCQZS53b3YqprtMlrCuxc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169090-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169090: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
X-Osstest-Versions-That:
    xen=8a87b9a0fb0564f9d68f0be0a0d1a17c34117b8b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 05:07:41 +0000

flight 169090 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169090/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
baseline version:
 xen                  8a87b9a0fb0564f9d68f0be0a0d1a17c34117b8b

Last test of basis   169064  2022-03-31 09:00:34 Z    0 days
Testing same since   169078  2022-03-31 19:01:44 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jason Andryuk <jandryuk@gmail.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8a87b9a0fb..e7cfcdc671  e7cfcdc6719d586eb7cdb62d40275a7d17fe6760 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 05:46:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 05:46:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297234.506281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naA6h-0002mw-Lh; Fri, 01 Apr 2022 05:45:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297234.506281; Fri, 01 Apr 2022 05:45:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naA6h-0002mp-IO; Fri, 01 Apr 2022 05:45:59 +0000
Received: by outflank-mailman (input) for mailman id 297234;
 Fri, 01 Apr 2022 05:45:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naA6g-0002mf-Hs; Fri, 01 Apr 2022 05:45:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naA6g-0005cK-G3; Fri, 01 Apr 2022 05:45:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naA6g-0004tQ-8g; Fri, 01 Apr 2022 05:45:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naA6g-0000YH-8G; Fri, 01 Apr 2022 05:45:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Tqx7gXUrzrInkZNoUbZ0M17JxHIb6A8Zei1SlJTEORc=; b=sQ0/gjpW6IvE1seh3/IK6dIcQm
	rzqKkIC/OCgHn8dVfeptduXw6twVqTfnnREJmzGg8iK8AWdh/4Ljt2j9Nr14/vh5CV3xK6ePyzduv
	vcX2nU7PgIV3ajvTj5K+tA0LVpgg4XGaA6O6d6ZHzGqVya9/jriAHQXILW9/8nKMHXT4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169069-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169069: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=55637a2894babca97945eeca1da0d431f74f8627
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 05:45:58 +0000

flight 169069 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169069/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 55637a2894babca97945eeca1da0d431f74f8627
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   31 days
Failing since        168258  2022-03-01 01:55:31 Z   31 days  265 attempts
Testing same since   169004  2022-03-30 02:24:42 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Yi Li <yi1.li@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1236 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 05:59:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 05:59:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297243.506292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naAJb-0004ND-1i; Fri, 01 Apr 2022 05:59:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297243.506292; Fri, 01 Apr 2022 05:59:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naAJa-0004N6-V0; Fri, 01 Apr 2022 05:59:18 +0000
Received: by outflank-mailman (input) for mailman id 297243;
 Fri, 01 Apr 2022 05:59:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naAJZ-0004Mw-BX; Fri, 01 Apr 2022 05:59:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naAJZ-0005pA-40; Fri, 01 Apr 2022 05:59:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naAJY-0005Qc-Sr; Fri, 01 Apr 2022 05:59:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naAJY-00055D-SN; Fri, 01 Apr 2022 05:59:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=E0lMVnGx6Xuh9uMnbSJ8/5wTuSggloYpothrjgSADL8=; b=tC4UE0qs7n+MKKASpnMSJNzVpz
	SsQQpOz5L5GiXBUGCePLmhNa+/OFFDkrghiOCytuccME9IKRTq3cRkrpgXJGPDozheTyZe4V2051W
	no4zJdxmJrw+0frw+0GPu0S071HLJcpZpkeYFriKGQahDhruJPP3Dh6hWB2eAAxUg/S4=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.16-testing bisection] complete test-amd64-amd64-livepatch
Message-Id: <E1naAJY-00055D-SN@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 05:59:16 +0000

branch xen-4.16-testing
xenbranch xen-4.16-testing
job test-amd64-amd64-livepatch
testid livepatch-run

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  dcd44e3b9ad2f0491bd7f4751232a389e4ee57e7
  Bug not present: 27dc916a39e8be9de331a580a43f10ef85633133
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169099/


  commit dcd44e3b9ad2f0491bd7f4751232a389e4ee57e7
  Author: Bjoern Doebel <doebel@amazon.de>
  Date:   Thu Mar 10 07:35:36 2022 +0000
  
      xen/x86: Livepatch: support patching CET-enhanced functions
      
      Xen enabled CET for supporting architectures. The control flow aspect of
      CET require functions that can be called indirectly (i.e., via function
      pointers) to start with an ENDBR64 instruction. Otherwise a control flow
      exception is raised.
      
      This expectation breaks livepatching flows because we patch functions by
      overwriting their first 5 bytes with a JMP + <offset>, thus breaking the
      ENDBR64. We fix this by checking the start of a patched function for
      being ENDBR64. In the positive case we move the livepatch JMP to start
      behind the ENDBR64 instruction.
      
      To avoid having to guess the ENDBR64 offset again on patch reversal
      (which might race with other mechanisms adding/removing ENDBR
      dynamically), use the livepatch metadata to store the computed offset
      along with the saved bytes of the overwritten function.
      
      Signed-off-by: Bjoern Doebel <doebel@amazon.de>
      Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
      Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
      Tested-by: Jiamei Xie <jiamei.xie@arm.com>
      (cherry picked from commit 6974c75180f1aad44e5428eabf2396b2b50fb0e4)
      
      Note: For backports to 4.14 thru 4.16, there is no endbr-clobbering, hence no
            is_endbr64_poison() logic.


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.16-testing/test-amd64-amd64-livepatch.livepatch-run.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.16-testing/test-amd64-amd64-livepatch.livepatch-run --summary-out=tmp/169099.bisection-summary --basis-template=168513 --blessings=real,real-bisect,real-retry xen-4.16-testing test-amd64-amd64-livepatch livepatch-run
Searching for failure / basis pass:
 169048 fail [host=himrod0] / 168513 [host=elbling0] 168503 [host=albana0] 168484 [host=godello1] 168136 [host=pinot0] 168063 [host=chardonnay0] 168015 [host=elbling0] 167997 [host=godello1] 167894 [host=godello0] 167620 [host=chardonnay1] 167401 [host=elbling0] 167218 [host=godello1] 166959 [host=pinot1] 166394 [host=fiano0] 166322 [host=godello0] template as basis? using template as basis.
Failure / basis pass flights: 169048 / 168513
(tree with no url: minios)
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 4dcddbba664cc91e2c1952498e80d8025891b9ad
Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 29a2f95d36d2a01bcacc0f3136801b2d9197f4d7 d239552ce7220e448ae81f41515138f7b9e3c4db cfd29b83a26f35f49f074f06169ce4cadfdebf0d
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#b1b89f9009f2390652e0061bd7b24fc40732bc70-b1b89f9009f2390652e0061bd7b24fc40732bc70 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c74\
 37ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#29a2f95d36d2a01bcacc0f3136801b2d9197f4d7-107951211a8d17658e1aaa0c23a8cf29f8806ad8 git://xenbits.xen.org/osstest/seabios.git#d239552ce7220e448ae81f41515138f7b9e3c4db-d239552ce7220e448ae81f41515138f7b9e3c4db git://xenbits.xen.org/xen.git#cfd29b83a26f35f49f074f06169ce4cadfdebf0d-4dcddbba664cc91e2c1952498e80d8025891b9ad
Loaded 10006 nodes in revision graph
Searching for test results:
 168513 [host=elbling0]
 168993 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 4dcddbba664cc91e2c1952498e80d8025891b9ad
 169047 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 29a2f95d36d2a01bcacc0f3136801b2d9197f4d7 d239552ce7220e448ae81f41515138f7b9e3c4db cfd29b83a26f35f49f074f06169ce4cadfdebf0d
 169075 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 4dcddbba664cc91e2c1952498e80d8025891b9ad
 169077 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 29a2f95d36d2a01bcacc0f3136801b2d9197f4d7 d239552ce7220e448ae81f41515138f7b9e3c4db cfd29b83a26f35f49f074f06169ce4cadfdebf0d
 169080 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 4dcddbba664cc91e2c1952498e80d8025891b9ad
 169081 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 9cd9650377d564f56126b2974097f54e0318dd27
 169083 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 351428de6feee3769a0ba69fdab3f521be85e891
 169048 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 4dcddbba664cc91e2c1952498e80d8025891b9ad
 169084 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 27dc916a39e8be9de331a580a43f10ef85633133
 169088 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db dcd44e3b9ad2f0491bd7f4751232a389e4ee57e7
 169091 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 27dc916a39e8be9de331a580a43f10ef85633133
 169093 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db dcd44e3b9ad2f0491bd7f4751232a389e4ee57e7
 169097 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 27dc916a39e8be9de331a580a43f10ef85633133
 169099 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db dcd44e3b9ad2f0491bd7f4751232a389e4ee57e7
Searching for interesting versions
 Result found: flight 169047 (pass), for basis pass
 For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 27dc916a39e8be9de331a580a43f10ef85633133, results HASH(0x55c2279caaf0) HASH(0x55c2279a7fd0) HASH(0x55c2279a82d0) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1\
 e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 351428de6feee3769a0ba69fdab3f521be85e891, results HASH(0x55c2279c6c60) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c\
 23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 9cd9650377d564f56126b2974097f54e0318dd27, results HASH(0x55c2279c4c58) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 29a2f95d36d2a01bcacc0f3136801b2d9197f4d7 d239552ce7220e448ae81f41515138f7b9e3c4db cfd29b83a26f35f49f074f06169ce4cadfdebf0d, results HASH(0x55c2279bdb98) HASH(0x55\
 c2279bcaf0) Result found: flight 169048 (fail), for basis failure (at ancestor ~242)
 Repro found: flight 169077 (pass), for basis pass
 Repro found: flight 169080 (fail), for basis failure
 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 107951211a8d17658e1aaa0c23a8cf29f8806ad8 d239552ce7220e448ae81f41515138f7b9e3c4db 27dc916a39e8be9de331a580a43f10ef85633133
No revisions left to test, checking graph state.
 Result found: flight 169084 (pass), for last pass
 Result found: flight 169088 (fail), for first failure
 Repro found: flight 169091 (pass), for last pass
 Repro found: flight 169093 (fail), for first failure
 Repro found: flight 169097 (pass), for last pass
 Repro found: flight 169099 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  dcd44e3b9ad2f0491bd7f4751232a389e4ee57e7
  Bug not present: 27dc916a39e8be9de331a580a43f10ef85633133
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169099/


  commit dcd44e3b9ad2f0491bd7f4751232a389e4ee57e7
  Author: Bjoern Doebel <doebel@amazon.de>
  Date:   Thu Mar 10 07:35:36 2022 +0000
  
      xen/x86: Livepatch: support patching CET-enhanced functions
      
      Xen enabled CET for supporting architectures. The control flow aspect of
      CET require functions that can be called indirectly (i.e., via function
      pointers) to start with an ENDBR64 instruction. Otherwise a control flow
      exception is raised.
      
      This expectation breaks livepatching flows because we patch functions by
      overwriting their first 5 bytes with a JMP + <offset>, thus breaking the
      ENDBR64. We fix this by checking the start of a patched function for
      being ENDBR64. In the positive case we move the livepatch JMP to start
      behind the ENDBR64 instruction.
      
      To avoid having to guess the ENDBR64 offset again on patch reversal
      (which might race with other mechanisms adding/removing ENDBR
      dynamically), use the livepatch metadata to store the computed offset
      along with the saved bytes of the overwritten function.
      
      Signed-off-by: Bjoern Doebel <doebel@amazon.de>
      Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
      Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
      Tested-by: Jiamei Xie <jiamei.xie@arm.com>
      (cherry picked from commit 6974c75180f1aad44e5428eabf2396b2b50fb0e4)
      
      Note: For backports to 4.14 thru 4.16, there is no endbr-clobbering, hence no
            is_endbr64_poison() logic.

Revision graph left in /home/logs/results/bisect/xen-4.16-testing/test-amd64-amd64-livepatch.livepatch-run.{dot,ps,png,html,svg}.
----------------------------------------
169099: tolerable ALL FAIL

flight 169099 xen-4.16-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/169099/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-amd64-amd64-livepatch   13 livepatch-run           fail baseline untested


jobs:
 test-amd64-amd64-livepatch                                   fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 08:05:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 08:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297266.506318 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naCHo-0000Zk-OC; Fri, 01 Apr 2022 08:05:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297266.506318; Fri, 01 Apr 2022 08:05:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naCHo-0000Zd-L6; Fri, 01 Apr 2022 08:05:36 +0000
Received: by outflank-mailman (input) for mailman id 297266;
 Fri, 01 Apr 2022 08:05:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qQ+P=UL=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1naCHn-0000ZX-0X
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 08:05:35 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0616.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::616])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8091a800-b192-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 10:05:33 +0200 (CEST)
Received: from DU2PR04CA0245.eurprd04.prod.outlook.com (2603:10a6:10:28e::10)
 by AS1PR08MB7513.eurprd08.prod.outlook.com (2603:10a6:20b:480::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.16; Fri, 1 Apr
 2022 08:05:30 +0000
Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28e:cafe::6f) by DU2PR04CA0245.outlook.office365.com
 (2603:10a6:10:28e::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.26 via Frontend
 Transport; Fri, 1 Apr 2022 08:05:30 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Fri, 1 Apr 2022 08:05:30 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Fri, 01 Apr 2022 08:05:30 +0000
Received: from d5134fc149b7.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6A5E4EBA-4671-48D8-96B0-769CEFB5ECFD.1; 
 Fri, 01 Apr 2022 08:05:24 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d5134fc149b7.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Apr 2022 08:05:24 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by VI1PR0802MB2254.eurprd08.prod.outlook.com (2603:10a6:800:9c::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Fri, 1 Apr
 2022 08:05:14 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a%5]) with mapi id 15.20.5123.025; Fri, 1 Apr 2022
 08:05:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8091a800-b192-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WRN4do4qBu6wBjqe8E+nmbXoCO6sd2CBSRuXawIVIyE=;
 b=LEheabHq6Egs8056/knoKqQjp2QEnNj7vp/owk+oJ1lQD8/5rgLtu4Ee2AGZPZmqpf1Anjk2ks+45va9dhUgewVXGbRtl+uvysicwFr1BBixU24fNd/NbHSEuUQQpHwfTQJeGYETPtBFdPssEAh7swIuT0Dc4kwb2rrX1sfzqKM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OuzDJ/lM/VkiiPYkc86/utxHKZUq67xyf2d75wUT9LD1RyJjnWN5KI4Lupg0cNOzLL2KtS7TTr4iRvQllzG1NBKE9N9r6brCkE3PxSi6IlgAsADafcb9qsDKbVySQ2Y+MYvbriMn86BtQ5CreFTcYqn6OQaQxxAztteD7GuJ99TqM8ra2NTc5AV77TrYTXTmttx7Rp3VYwr0nGBwcTOKh4lNzAMATY8GvFdfWHJXk/f+hThlX3AfxELczJgacyS2c+jXn+9MZZeuVdLpZ4PvLgK2bplcVb62QeybPYCZX6iscAOnMZqfghQw9pBAcsawCH3AlfasRDwDOKLUiy273Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WRN4do4qBu6wBjqe8E+nmbXoCO6sd2CBSRuXawIVIyE=;
 b=dr3PmMLtTS/4dOkJLZQdSpgMHfTY0R2FAMkVIIutYjZemr6N6IhGGFIaUcXOjuVAs/ony25Kt+Qi8agwRgPUcU6qC06t6eUG9ufQyZg3oiHAaMck2GjbSnQsqQd5Hr/JIy4C8DZCPZ1+yNTfvV0Db3BLBIecJMSMj41NTaRw5QISbULJ6Uk7N9wf9hBalRn90JhwVbsY8ku9CyPiI0BubB5ghxJ6qNlO0pyWc8T7onPzBbvkyRObZukCrmIKy8YiG4D22xT/G8lmvvXHeh8DqE1iGLyS/bzd192aCvlrMbdoaRBIzdBB9LHC39xniwugJyzrgxvOpRdypyLSE9sxFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WRN4do4qBu6wBjqe8E+nmbXoCO6sd2CBSRuXawIVIyE=;
 b=LEheabHq6Egs8056/knoKqQjp2QEnNj7vp/owk+oJ1lQD8/5rgLtu4Ee2AGZPZmqpf1Anjk2ks+45va9dhUgewVXGbRtl+uvysicwFr1BBixU24fNd/NbHSEuUQQpHwfTQJeGYETPtBFdPssEAh7swIuT0Dc4kwb2rrX1sfzqKM=
From: Henry Wang <Henry.Wang@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "jgross@suse.com" <jgross@suse.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, "julien@xen.org" <julien@xen.org>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, Stefano Stabellini
	<stefano.stabellini@xilinx.com>
Subject: RE: [PATCH v4 1/9] xen/dt: dt_property_read_string should return
 -ENODATA on !length
Thread-Topic: [PATCH v4 1/9] xen/dt: dt_property_read_string should return
 -ENODATA on !length
Thread-Index: AQHYRWD1ghazNy9i8k6ND1boTze3v6zas2fw
Date: Fri, 1 Apr 2022 08:05:13 +0000
Message-ID:
 <PA4PR08MB6253935C99999D6966BD801592E09@PA4PR08MB6253.eurprd08.prod.outlook.com>
References:
 <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-1-sstabellini@kernel.org>
In-Reply-To: <20220401003847.38393-1-sstabellini@kernel.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F93DDA69FA79414B8A2C00372C0D39AF.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: c660bb97-e253-4989-dc5b-08da13b66387
x-ms-traffictypediagnostic:
	VI1PR0802MB2254:EE_|DB5EUR03FT063:EE_|AS1PR08MB7513:EE_
X-Microsoft-Antispam-PRVS:
	<AS1PR08MB751344BA903B22BDBABD65BB92E09@AS1PR08MB7513.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KKJqTV5FUEWLuQsxEYIQWUMDSdFxrmQMw66t5Un0M5Ba6dT31pLc13BpLdkaJkbyWC6nVuyNa68xanogKXMt41VZdPgQ1sziwnuhk2o7ASlx/rmDKnf4frT+EvRRMW6GlPrrJZ9YWnYs7SH8gegxWJxXaNVA9huWXUKUk1ciT+zCAQG7Kbg0hh1eD77Ew4gf4jsNu7uBBnFkLlgOXFjAPQWLVfZHvApepeYPjPmKjVUBFrzRKWYW5MaD5zD1IV9VhISi/53ZGPHo8lzbykCOjzD7zrDFTBoEyR9rNTf19b8JBs225++nkK807g+z9wUnuC3dCXC1HRlif0R+X4z9WODTBwOeF6j3duu9EagoyO3Zf5SFQfWhbSnzhRGJxQyaHnz/o6kz+ujz+ggOjiQ/JcByOmIU7X+E67FO8mFfpWu8P9Fzskmyfeq4fPJm7EBHLBNe8Q/MS1wsAhr0XzpSRF+99ueAxp9pW1uUzTRBFfLg1TdR0eLazKps17yKY8Us7LsKVMblRabu0z6Ka5ee+lLjpJkawB71CkRZ+CJnnwNWsHRkWXFytydh/JV7iTYLdesYduO0V/YAdHiy73rDby1LHsvU6lB3KhLcI4EWJce1E0JUvql4HzOHu/XToU0YhOgfyPhe2T7fnOmlIKyM2MvqxywONWGZpKExHWOZH5vWonu+hEox1F9VexEuoCxuWJYpJK/GdKtp1M0Lw4q2xg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(38070700005)(110136005)(8676002)(26005)(66556008)(186003)(66476007)(66446008)(76116006)(66946007)(64756008)(316002)(4326008)(86362001)(508600001)(2906002)(33656002)(8936002)(83380400001)(52536014)(55016003)(5660300002)(7696005)(9686003)(122000001)(71200400001)(38100700002)(6506007)(53546011);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2254
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3f32e6b7-6354-4a77-9b0d-08da13b659e1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wu+fuC1nGq4jepIqpuxFz3CRC4nKcS3i6bQEXWWKoIN7/4d5LM+DmFGJ6/xkjDxAIQoH9CtwBlo1XuYK16hqD8PcAjo4djMZR9CnGxrvTUKiE1FQ/4yV6jrgV5hkhkCyARU/cZyX9nVtdlT29rYGbhrZ4YqnDCHyqlsGW0RKH4ErAKZS0NyhBfz0wkOOf+Lak/WuKxCsRE6rqIWioA/pVyHrGRsjbKb/SPJUr8EAJVVwIZT+fei4Jr4DcE2QxF9T2i2tcU3G7NZ1X7S0vRakPqCoQFz1nezJjGsyLuZPH7BDfT6kgIvoEl+3Dfj16pw4b3t9NFL8Q8gMkQWfAIT/BFUKS+l51eTrcKnXoqNdJ1Foy0TbtWtcNrwuKBeMUYDCy61w3U0Bp85XVmi1rP4p+n80qRhP2tTftMA6dlIbbbI+NORKUqSvljwgclGurjl6xXgko/LqjiV2zo5k5nLN1mKTzzlswg7whs5Bt2c/PFAN0H9irjHIEUxUfRblXGSbMofj+V8xMw3sDV0qTQwg/LtztKW6sQnyXWNMR1tY7/ynL9yqFaC438TwYuBoC18yXcpFEL4Y7MmNQnXez+VMEymR8cNQHrW3NVhaWt78QiAL32G87cBNMSqOSWcH99Nj2WzU3E1BTEJBMvPa7166TRD7GHpgk+AZ2l3YbG58Lrr5vVjjyAadfSbmN//32O+I
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(7696005)(6506007)(9686003)(2906002)(47076005)(316002)(53546011)(54906003)(83380400001)(336012)(110136005)(70586007)(8676002)(4326008)(86362001)(70206006)(52536014)(81166007)(5660300002)(356005)(40460700003)(107886003)(508600001)(36860700001)(55016003)(186003)(26005)(33656002)(82310400004)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 08:05:30.1014
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c660bb97-e253-4989-dc5b-08da13b66387
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7513

Hi Stefano,

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Stefano Stabellini
> Sent: Friday, April 1, 2022 8:39 AM
> To: xen-devel@lists.xenproject.org
> Cc: sstabellini@kernel.org; jgross@suse.com; Bertrand Marquis
> <Bertrand.Marquis@arm.com>; julien@xen.org;
> Volodymyr_Babchuk@epam.com; Stefano Stabellini
> <stefano.stabellini@xilinx.com>
> Subject: [PATCH v4 1/9] xen/dt: dt_property_read_string should return -
> ENODATA on !length
>=20
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>=20
> When the length is zero (pp->length =3D=3D 0), dt_property_read_string
> should return -ENODATA, but actually currently returns -EILSEQ because
> there is no specific check for lenght =3D=3D 0.
>=20
> Add a check now.
>=20
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

Reviewed-by: Henry Wang <Henry.Wang@arm.com>

> ---
>  xen/common/device_tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 4aae281e89..db67fb5fb4 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -198,7 +198,7 @@ int dt_property_read_string(const struct
> dt_device_node *np,
>=20
>      if ( !pp )
>          return -EINVAL;
> -    if ( !pp->value )
> +    if ( !pp->value || !pp->length )
>          return -ENODATA;
>      if ( strnlen(pp->value, pp->length) >=3D pp->length )
>          return -EILSEQ;
> --
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 08:36:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 08:36:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297272.506329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naClJ-0003rU-6x; Fri, 01 Apr 2022 08:36:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297272.506329; Fri, 01 Apr 2022 08:36:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naClJ-0003rN-2Q; Fri, 01 Apr 2022 08:36:05 +0000
Received: by outflank-mailman (input) for mailman id 297272;
 Fri, 01 Apr 2022 08:36:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naClH-0003rH-Md
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 08:36:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naClH-0000cB-87; Fri, 01 Apr 2022 08:36:03 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naClH-0007JR-1R; Fri, 01 Apr 2022 08:36:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=CveRPQi/o9UbDyGR19L62x+fJcdwB+G3zOCh9jvbha0=; b=pwvT14ZhaP9+jU21zYBObD0EsX
	rsyoC+DU2QJb0S/YOBvz5R6ZjoSUdBb0jrrmx3TBho0enNtp+SP1Oxmd30sER3b9egF+kuMDvKFo9
	Ly4EgYh7KCn+Gvvdyldh1MEtSp1Kod8IH3GB4F/oqweDcYBxjsiWXOyStRy9UP23Vj/c=;
Message-ID: <d7fa66f4-6053-8c1c-3fb0-29e419f7591e@xen.org>
Date: Fri, 1 Apr 2022 09:36:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v3 3/5] xen/arm: configure dom0less domain for enabling
 xenstore after boot
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, jgross@suse.com,
 Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop>
 <20220128213307.2822078-3-sstabellini@kernel.org>
 <e55c03f6-5b20-ce9c-ce88-11dc85623dce@xen.org>
 <alpine.DEB.2.22.394.2203221722430.2910984@ubuntu-linux-20-04-desktop>
 <799f69b2-f581-9f5f-004a-8f9f790aba2a@xen.org>
 <alpine.DEB.2.22.394.2203311341220.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2203311341220.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 01/04/2022 01:34, Stefano Stabellini wrote:
>>> Because (as you noted as a comment to the following patch) as soon as
>>> d->arch.hvm.params[HVM_PARAM_STORE_PFN] is set the guest can continue
>>> with the initialization and will expect the right data to be set on the
>>> page.
>>
>> I think you misunderstood my question. From my understanding, at the moment,
>> Linux would break with your proposal. So you need to modify the kernel in
>> order to support what you are doing.
> 
> Linux does not break with this proposal. I wrote a longer explanation
> [1] some time ago.

I guess I should not have written "broken" here. But instead point out 
that...

> 
> In short: the master branch and any supported versions of Linux boots
> fine with this proposal without changes, however it wouldn't be able to
> use PV drivers when started as dom0less kernel.
> 
> To be able to use the new feature, this patch is required [2].

... without the extra patch is Linux, you would not be able to take 
advantage of this feature.

>> IOW, we have room to decide the approach here.
>>
>> Xenstore protocol has a way to allow (re)connection (see
>> docs/mics/xenstore-ring.txt). This feature looks quite suited to what you are
>> trying to do here (we want to delay the connection).
>>
>> The main advantage with this approach is the resources allocation for Xenstore
>> will be done in the place and the work in Linux could be re-used for
>> non-dom0less domain.
>>
>> Have you explored it?
> 
> Luca (CCed) is the original author. I don't know if he explored that
> approach. I have not looked into it in any details but I think there
> might be challenges: in this case there is nothing on the shared page.
> There are no feature bits as it has not been initialized (xenstored is
> the one initializating it).
I agree there is nothing today. But here, we have the liberty to 
initialize the feature bits in Xen.

> 
> Keep in mind that Luca and I have done many tests on this approach, both
> the Xen side, the Linux side (very many different kernel versions) and
> complex configurations (both network and block PV drivers, DMA mastering
> devices, etc.) If we changed approach now we would lose some of the
> value of the past efforts.

I appreciate the effort you put into testing this approach. However, 
this is an external interface that we will consider stable as soon as 
the two sides (Xen and Linux) are committed. So I want to make sure we 
are not putting ourself in a corner.

One major issue I can forsee with your approach is the xenstore 
initialization seem to only works for HVM. In theory, we may have the 
same need for PV (e.g. in the case of Hyperlaunch).

How would your proposal work for PV guest?

Note that I now that PV guest may not work without Xenstore. But I don't 
see any reason why we could not start them before Xenstored.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 08:44:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 08:44:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297277.506340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naCtn-0005Lu-3U; Fri, 01 Apr 2022 08:44:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297277.506340; Fri, 01 Apr 2022 08:44:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naCtn-0005Ln-0Q; Fri, 01 Apr 2022 08:44:51 +0000
Received: by outflank-mailman (input) for mailman id 297277;
 Fri, 01 Apr 2022 08:44:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naCtk-0005Ld-VO; Fri, 01 Apr 2022 08:44:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naCtk-0000lw-Me; Fri, 01 Apr 2022 08:44:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naCtk-0003zX-6S; Fri, 01 Apr 2022 08:44:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naCtk-0001Qw-4c; Fri, 01 Apr 2022 08:44:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6Scvp0iiJp6PwdXzMJtBmem1G8KTenOzCITB8MpCcMU=; b=V9BA2ehrjv9M6BecMLSfU5vDEZ
	cWr+CxqMZO2PXm5135W1kSXNZbMBoIrJYFneGxGwLc8HlnuotqcEZDN5/ttHbTkmxv/6seyq9w6va
	2l5lUwnjd9TGWLX/CNHFaL2kRPakgTqGTfcRpyIzOGfdmTEHNN5gljpaul2sXtL7nxrg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169063-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169063: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8eec96b7b8d937d40e2e7988edb8bbd08598c715
X-Osstest-Versions-That:
    xen=8eec96b7b8d937d40e2e7988edb8bbd08598c715
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 08:44:48 +0000

flight 169063 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169063/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169003
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169003
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169003
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169003
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169003
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169003
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169003
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169003
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169003
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169003
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169003
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169003
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  8eec96b7b8d937d40e2e7988edb8bbd08598c715
baseline version:
 xen                  8eec96b7b8d937d40e2e7988edb8bbd08598c715

Last test of basis   169063  2022-03-31 08:34:51 Z    1 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 08:59:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 08:59:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297285.506351 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naD7i-0006tS-EY; Fri, 01 Apr 2022 08:59:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297285.506351; Fri, 01 Apr 2022 08:59:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naD7i-0006tL-AR; Fri, 01 Apr 2022 08:59:14 +0000
Received: by outflank-mailman (input) for mailman id 297285;
 Fri, 01 Apr 2022 08:59:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naD7h-0006tB-1V; Fri, 01 Apr 2022 08:59:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naD7g-00010p-UW; Fri, 01 Apr 2022 08:59:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naD7g-0004v8-Jv; Fri, 01 Apr 2022 08:59:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naD7g-0004xT-JQ; Fri, 01 Apr 2022 08:59:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=zpmeEVrEpbmO0R9MASkqaiOA2bQVOECkYrUj7/+9mi0=; b=RGNs7Dz5BHal1zJEUognYqcHDw
	AyAKRXcrwzvETVm/8wKgduEb4elgvwLk8iigTS8B8Rwhal54XTRFWaekt4zMjSKEpjHyAHLHNfHMA
	a0jtI4qM1g1twtwTO7kcIQj2QnuK9Wkh52YvuYgSnn/0JuSUYftQMUIdUKva5PSURHoE=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.14-testing bisection] complete test-amd64-i386-livepatch
Message-Id: <E1naD7g-0004xT-JQ@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 08:59:12 +0000

branch xen-4.14-testing
xenbranch xen-4.14-testing
job test-amd64-i386-livepatch
testid livepatch-run

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  72a75b9c2ce36ed573a2eb201ac63ca22bedb889
  Bug not present: 6db64187700d6d1ce23f49e667c24f1c7ebe11f8
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169105/


  commit 72a75b9c2ce36ed573a2eb201ac63ca22bedb889
  Author: Bjoern Doebel <doebel@amazon.de>
  Date:   Thu Mar 10 07:35:36 2022 +0000
  
      xen/x86: Livepatch: support patching CET-enhanced functions
      
      Xen enabled CET for supporting architectures. The control flow aspect of
      CET require functions that can be called indirectly (i.e., via function
      pointers) to start with an ENDBR64 instruction. Otherwise a control flow
      exception is raised.
      
      This expectation breaks livepatching flows because we patch functions by
      overwriting their first 5 bytes with a JMP + <offset>, thus breaking the
      ENDBR64. We fix this by checking the start of a patched function for
      being ENDBR64. In the positive case we move the livepatch JMP to start
      behind the ENDBR64 instruction.
      
      To avoid having to guess the ENDBR64 offset again on patch reversal
      (which might race with other mechanisms adding/removing ENDBR
      dynamically), use the livepatch metadata to store the computed offset
      along with the saved bytes of the overwritten function.
      
      Signed-off-by: Bjoern Doebel <doebel@amazon.de>
      Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
      Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
      Tested-by: Jiamei Xie <jiamei.xie@arm.com>
      (cherry picked from commit 6974c75180f1aad44e5428eabf2396b2b50fb0e4)
      
      Note: For backports to 4.14 thru 4.16, there is no endbr-clobbering, hence no
            is_endbr64_poison() logic.


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.14-testing/test-amd64-i386-livepatch.livepatch-run.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.14-testing/test-amd64-i386-livepatch.livepatch-run --summary-out=tmp/169105.bisection-summary --basis-template=168506 --blessings=real,real-bisect,real-retry xen-4.14-testing test-amd64-i386-livepatch livepatch-run
Searching for failure / basis pass:
 169028 fail [host=elbling1] / 168506 [host=fiano0] 168493 [host=huxelrebe0] 168061 [host=albana0] 168013 [host=chardonnay0] 167964 [host=albana1] 167908 [host=elbling0] 167629 [host=fiano0] 167415 ok.
Failure / basis pass flights: 169028 / 167415
(tree with no url: minios)
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c039fa7ff09729de07bc7ebcdd4878340bfaf252 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 2dd4b9b3f84019668719344b40dba79d681be41c cbadf67bcab4e29c883410db393f4f5ef34df04a
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#c039fa7ff09729de07bc7ebcdd4878340bfaf252-b1b89f9009f2390652e0061bd7b24fc40732bc70 git://xenbits.xen.org/qemu-xen-traditional.git#3c659044118e34603161457db99\
 34a34f816d78b-3c659044118e34603161457db9934a34f816d78b git://xenbits.xen.org/qemu-xen.git#d7d6a60e73ee21e82f0bac2036153ccccf996e6c-83aebe33dc76760f911162f9e7a4b98a4929776b git://xenbits.xen.org/osstest/seabios.git#2dd4b9b3f84019668719344b40dba79d681be41c-d239552ce7220e448ae81f41515138f7b9e3c4db git://xenbits.xen.org/xen.git#cbadf67bcab4e29c883410db393f4f5ef34df04a-1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
Loaded 12651 nodes in revision graph
Searching for test results:
 167415 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c039fa7ff09729de07bc7ebcdd4878340bfaf252 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 2dd4b9b3f84019668719344b40dba79d681be41c cbadf67bcab4e29c883410db393f4f5ef34df04a
 167629 [host=fiano0]
 167812 []
 167822 []
 167864 []
 167908 [host=elbling0]
 167964 [host=albana1]
 168013 [host=chardonnay0]
 168061 [host=albana0]
 168493 [host=huxelrebe0]
 168506 [host=fiano0]
 168862 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 10b09aa2541de4c3c49b9343e9bc04e19f0ae4f8
 168986 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
 169061 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c039fa7ff09729de07bc7ebcdd4878340bfaf252 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 2dd4b9b3f84019668719344b40dba79d681be41c cbadf67bcab4e29c883410db393f4f5ef34df04a
 169065 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
 169066 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 7e5c603cba0823fd97456984f4cfc21c4c831b52 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 4eff93e7b0d093fd9347f2d533dada49854290fe c45c2c2e09295ef3008a79d78673af0819ff4e4f
 169068 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 33189f05278345eab608ff56e87905bdeacdbd47 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 15bb12ed367babfe212c8a90d384b11849d98573
 169028 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
 169070 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 63c50d3ff2854a76432b752af4f2a76f33ff1974 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 496fb0be938a30971af05ffe0e58bb65643a0971
 169073 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 5e7db069bde7ce50fe15e42dbd2468d294ae78db
 169076 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db cc080e630fa105d6924142be5ddb430756779528
 169082 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 37e594c58ff43aa2d65f49bfde106ecaffbbeeac
 169087 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 6db64187700d6d1ce23f49e667c24f1c7ebe11f8
 169092 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 72a75b9c2ce36ed573a2eb201ac63ca22bedb889
 169096 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 6db64187700d6d1ce23f49e667c24f1c7ebe11f8
 169101 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 72a75b9c2ce36ed573a2eb201ac63ca22bedb889
 169104 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 6db64187700d6d1ce23f49e667c24f1c7ebe11f8
 169105 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 72a75b9c2ce36ed573a2eb201ac63ca22bedb889
Searching for interesting versions
 Result found: flight 167415 (pass), for basis pass
 For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 6db64187700d6d1ce23f49e667c24f1c7ebe11f8, results HASH(0x5601c5ac2bc0) HASH(0x5601c5a927f8) HASH(0x5601c5ac7bc0) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1\
 e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 37e594c58ff43aa2d65f49bfde106ecaffbbeeac, results HASH(0x5601c5ad0088) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9\
 e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db cc080e630fa105d6924142be5ddb430756779528, results HASH(0x5601c5ace080) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 5e7db069bde7ce50fe15e42dbd2468d294ae78db, results HASH(0x5601c4bfb1f8) For basis\
  failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 63c50d3ff2854a76432b752af4f2a76f33ff1974 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 496fb0be938a30971af05ffe0e58bb65643a0971, results HASH(0x5601c5ac9448) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 33189f05278345eab608\
 ff56e87905bdeacdbd47 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 15bb12ed367babfe212c8a90d384b11849d98573, results HASH(0x5601c5aac9d0) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 7e5c603cba0823fd97456984f4cfc21c4c831b52 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 4eff93e7b0d093fd9347f2d533dada49854\
 290fe c45c2c2e09295ef3008a79d78673af0819ff4e4f, results HASH(0x5601c5ac31c0) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c039fa7ff09729de07bc7ebcdd4878340bfaf252 3c659044118e34603161457db9934a34f816d78b d7d6a60e73ee21e82f0bac2036153ccccf996e6c 2dd4b9b3f84019668719344b40dba79d681be41c cbadf67bcab4e29c883410db393f4f5ef34df04a, results HASH(0x5601c5aaa0c8) HASH(0x5601c5a89288) Result found: flight 168862 (fail), for \
 basis failure (at ancestor ~616)
 Repro found: flight 169061 (pass), for basis pass
 Repro found: flight 169065 (fail), for basis failure
 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b1b89f9009f2390652e0061bd7b24fc40732bc70 3c659044118e34603161457db9934a34f816d78b 83aebe33dc76760f911162f9e7a4b98a4929776b d239552ce7220e448ae81f41515138f7b9e3c4db 6db64187700d6d1ce23f49e667c24f1c7ebe11f8
No revisions left to test, checking graph state.
 Result found: flight 169087 (pass), for last pass
 Result found: flight 169092 (fail), for first failure
 Repro found: flight 169096 (pass), for last pass
 Repro found: flight 169101 (fail), for first failure
 Repro found: flight 169104 (pass), for last pass
 Repro found: flight 169105 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  72a75b9c2ce36ed573a2eb201ac63ca22bedb889
  Bug not present: 6db64187700d6d1ce23f49e667c24f1c7ebe11f8
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169105/


  commit 72a75b9c2ce36ed573a2eb201ac63ca22bedb889
  Author: Bjoern Doebel <doebel@amazon.de>
  Date:   Thu Mar 10 07:35:36 2022 +0000
  
      xen/x86: Livepatch: support patching CET-enhanced functions
      
      Xen enabled CET for supporting architectures. The control flow aspect of
      CET require functions that can be called indirectly (i.e., via function
      pointers) to start with an ENDBR64 instruction. Otherwise a control flow
      exception is raised.
      
      This expectation breaks livepatching flows because we patch functions by
      overwriting their first 5 bytes with a JMP + <offset>, thus breaking the
      ENDBR64. We fix this by checking the start of a patched function for
      being ENDBR64. In the positive case we move the livepatch JMP to start
      behind the ENDBR64 instruction.
      
      To avoid having to guess the ENDBR64 offset again on patch reversal
      (which might race with other mechanisms adding/removing ENDBR
      dynamically), use the livepatch metadata to store the computed offset
      along with the saved bytes of the overwritten function.
      
      Signed-off-by: Bjoern Doebel <doebel@amazon.de>
      Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
      Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
      Tested-by: Jiamei Xie <jiamei.xie@arm.com>
      (cherry picked from commit 6974c75180f1aad44e5428eabf2396b2b50fb0e4)
      
      Note: For backports to 4.14 thru 4.16, there is no endbr-clobbering, hence no
            is_endbr64_poison() logic.

pnmtopng: 209 colors found
Revision graph left in /home/logs/results/bisect/xen-4.14-testing/test-amd64-i386-livepatch.livepatch-run.{dot,ps,png,html,svg}.
----------------------------------------
169105: tolerable ALL FAIL

flight 169105 xen-4.14-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/169105/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-amd64-i386-livepatch    13 livepatch-run           fail baseline untested


jobs:
 test-amd64-i386-livepatch                                    fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:03:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:03:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297295.506365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naE7R-0005MK-Fj; Fri, 01 Apr 2022 10:03:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297295.506365; Fri, 01 Apr 2022 10:03:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naE7R-0005MD-C9; Fri, 01 Apr 2022 10:03:01 +0000
Received: by outflank-mailman (input) for mailman id 297295;
 Fri, 01 Apr 2022 10:03:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naE7Q-0005M7-7z
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:03:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naE7O-0002Ao-SZ; Fri, 01 Apr 2022 10:02:58 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naE7O-0005TH-Ld; Fri, 01 Apr 2022 10:02:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=6WOOY55Mk/aEsld4fjQTMfqo+ou2Urf2TW1TJp6ak8w=; b=5MS1IUpSIWDs6ALRpAvqSft/rZ
	cn9FMkQN3HI0Dtqc+muppgmyZ67/lc0ebWE2Rp8EkjH+++z4LM+mkEkukL9ymEM2VWnof7bSY2kBt
	ipa22qSqyP7Haw3zoaGa3mcpZBOSRjqb8MX+802iIlKpXBJj+83Xv0l/i02X371BDuYs=;
Message-ID: <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>
Date: Fri, 1 Apr 2022 11:02:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v3 5/5] tools: add example application to initialize
 dom0less PV drivers
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, jgross@suse.com,
 Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop>
 <20220128213307.2822078-5-sstabellini@kernel.org>
 <395710eb-ba51-eb67-1519-2a949326f699@xen.org>
 <alpine.DEB.2.22.394.2203221821520.2910984@ubuntu-linux-20-04-desktop>
 <07fa2884-e497-250b-53ab-dd452b501920@xen.org>
 <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 01/04/2022 01:35, Stefano Stabellini wrote:
>>>>> +
>>>>> +    /* Alloc magic pages */
>>>>> +    if (alloc_magic_pages(info, &dom) != 0) {
>>>>> +        printf("Error on alloc magic pages\n");
>>>>> +        return 1;
>>>>> +    }
>>>>> +
>>>>> +    xc_dom_gnttab_init(&dom);
>>>>
>>>> This call as the risk to break the guest if the dom0 Linux doesn't support
>>>> the
>>>> acquire interface. This is because it will punch a hole in the domain
>>>> memory
>>>> where the grant-table may have already been mapped.
>>>>
>>>> Also, this function could fails.
>>>
>>> I'll check for return errors. Dom0less is for fully static
>>> configurations so I think it is OK to return error and abort if
>>> something unexpected happens: dom0less' main reason for being is that
>>> there is nothing unexpected :-)
>> Does this mean the caller will have to reboot the system if there is an error?
>> IOW, we don't expect them to call ./init-dom0less twice.
> 
> Yes, exactly. I think init-dom0less could even panic. My mental model is
> that this is an "extension" of construct_domU. Over there we just panic
> if something is wrong and here it would be similar. The user provided a
> wrong config and should fix it.

Ok. I think we should make explicit how it can be used.

>>>>> +
>>>>> +    libxl_uuid_generate(&uuid);
>>>>> +    xc_domain_sethandle(dom.xch, info->domid,
>>>>> libxl_uuid_bytearray(&uuid));
>>>>> +
>>>>> +    rc = gen_stub_json_config(info->domid, &uuid);
>>>>> +    if (rc)
>>>>> +        err(1, "gen_stub_json_config");
>>>>> +
>>>>> +    rc = restore_xenstore(xsh, info, uuid, dom.xenstore_evtchn);
>>>>> +    if (rc)
>>>>> +        err(1, "writing to xenstore");
>>>>> +
>>>>> +    xs_introduce_domain(xsh, info->domid,
>>>>> +            (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET,
>>>>> +            dom.xenstore_evtchn);
>>>>
>>>> xs_introduce_domain() can technically fails.
>>>
>>> OK
>>>
>>>
>>>>> +    return 0;
>>>>> +}
>>>>> +
>>>>> +/* Check if domain has been configured in XS */
>>>>> +static bool domain_exists(struct xs_handle *xsh, int domid)
>>>>> +{
>>>>> +    return xs_is_domain_introduced(xsh, domid);
>>>>> +}
>>>>
>>>> Would not this lead to initialize a domain with PV driver disabled?
>>>
>>> I am not sure I understood your question, but I'll try to answer anyway.
>>> This check is purely to distinguish dom0less guests, which needs further
>>> initializations, from regular guests (e.g. xl guests) that don't need
>>> any actions taken here.
>>
>> Dom0less domUs can be divided in two categories based on whether they are xen
>> aware (e.g. xen,enhanced is set).
>>
>> Looking at this script, it seems to assume that all dom0less domUs are Xen
>> aware. So it will end up to allocate Xenstore ring and call
>> xs_introduce_domain(). I suspect the call will end up to fail because the
>> event channel would be 0.
>>
>> So did you try to use this script on a platform where there only xen aware
>> domU and/or a mix?
> 
> Good idea of asking for this test. I thought I already ran that test,
> but I did it again to be sure. Everything works OK (although the
> xenstore page allocation is unneeded). xs_introduce_domain does not
 > fail:

Are you sure? If I pass 0 as the 4th argument (event channel), the 
command will return EINVAL. However, looking at the code you are not 
checking the return for the call. So you will continue as if it were 
successful.

So you will end up to write nodes for a domain Xenstored is not aware 
and also set HVM_PARAM_STORE_PFN which may further confuse the guest as 
it may try to initialize Xenstored it discovers the page.

> I think that's because it is usually called on all domains by the
> toolstack, even the ones without xenstore support in the kernel.

The toolstack will always allocate the event channel irrespective to 
whether the guest will use Xenstore. So both the shared page and the 
event channel are always valid today.

With your series, this will change as the event channel will not be 
allocated when "xen,enhanced" is not set.

In your case, I think we may want to register the domain to xenstore but 
say there are no connection available for the domain. Juergen, what do 
you think?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:15:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:15:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297299.506376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEJW-0006ra-KN; Fri, 01 Apr 2022 10:15:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297299.506376; Fri, 01 Apr 2022 10:15:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEJW-0006rT-Fa; Fri, 01 Apr 2022 10:15:30 +0000
Received: by outflank-mailman (input) for mailman id 297299;
 Fri, 01 Apr 2022 10:15:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JkNZ=UL=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1naEJV-0006rN-Es
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:15:29 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on061d.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::61d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a6c9b71c-b1a4-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 12:15:27 +0200 (CEST)
Received: from AM5PR0502CA0008.eurprd05.prod.outlook.com
 (2603:10a6:203:91::18) by DB9PR08MB6683.eurprd08.prod.outlook.com
 (2603:10a6:10:2ad::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.16; Fri, 1 Apr
 2022 10:15:15 +0000
Received: from AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:91:cafe::9d) by AM5PR0502CA0008.outlook.office365.com
 (2603:10a6:203:91::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.26 via Frontend
 Transport; Fri, 1 Apr 2022 10:15:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT017.mail.protection.outlook.com (10.152.16.89) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Fri, 1 Apr 2022 10:15:15 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Fri, 01 Apr 2022 10:15:15 +0000
Received: from 9f101230581b.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D11FBE42-38CF-4A1A-A616-6632D55FC670.1; 
 Fri, 01 Apr 2022 10:15:08 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f101230581b.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Apr 2022 10:15:08 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM8PR08MB6546.eurprd08.prod.outlook.com (2603:10a6:20b:355::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19; Fri, 1 Apr
 2022 10:15:06 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310%7]) with mapi id 15.20.5123.021; Fri, 1 Apr 2022
 10:15:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6c9b71c-b1a4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NyIcrG2CditFEVAGnksGjvybLKcGcz1xBLOn6iY9TKw=;
 b=g9yQqa2Cd2vDJWWA9piHfLG7jeDszQOmbxtMCTDMeb1kUlqKsktE5z0shLZVLMw7PXEmhe/TnsTBEUN1cPoiJHJbRPNBylRo6J32BAtka1DmcmlhiABzZt5sJMFXo47rAjBv2MogpGeoH74hG3qlWhRJv8Ey/RRcPZ2/CrPBA+E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 80cf41e2151537b1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c0dD9hpu3Bs6O2x1bzPseLoEAhB8jX+FBJ4frcW58hdhJy9YDuJs0iAjJjcRNEe0okaTGXo44pseIaMhozKwNH9aZ8ZRSN7jx1Snxw2AP3x8ZL+M11nMC3IvEsn3uU1JPikxBnCwv8WPW4A0AaNCrxxVPxi39tTMgxsMY6FB6TiN8M6be35/f3PktzD1vEvXVR6WE+l77XXMylw+c8JfJSx04X1H5nLO2KDetcCD1ZULX4DNQSmimX/G6wp7oIaeWuT0CVDtMlMKCDDOetVjruqBUmVlETgfK5z0wXVGEqPDJTH/hpZFU8R4iMqhgcy3VXeEOQhDK917a0UH0pXHog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NyIcrG2CditFEVAGnksGjvybLKcGcz1xBLOn6iY9TKw=;
 b=Aln3wi6oRObG2PP29x6qCMfyWivzd9pFJrT9fPN6irk8jGCGtvtcZdsVzam6N6kiUJPcNbZe+7bnPN3hESLE1SwEBxUrHSWNRZjXHqmPnol7GFP8SlYa8G/j1au3dGxKJ9lF6UXiTxKEQPdnImWJvk2RWRVNYo+D7XE1XUwVtuhWN0CUodzEniQekFD3eu40I0Kb3kUtMJBGskU6F70cZl1DYFpELWxfqZ5SeBAdvUQHQGRki4xjb6TSveLVtp/5cQgMA8I6DajhO2rq/J5IUCBwq2GkkXa9H/g7CnFi9/+tZoMGSzw6QBypAoqWpZ/+ONPEMg57JX0eTPPXaaeU/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NyIcrG2CditFEVAGnksGjvybLKcGcz1xBLOn6iY9TKw=;
 b=g9yQqa2Cd2vDJWWA9piHfLG7jeDszQOmbxtMCTDMeb1kUlqKsktE5z0shLZVLMw7PXEmhe/TnsTBEUN1cPoiJHJbRPNBylRo6J32BAtka1DmcmlhiABzZt5sJMFXo47rAjBv2MogpGeoH74hG3qlWhRJv8Ey/RRcPZ2/CrPBA+E=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <volodymyr_babchuk@epam.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Thread-Topic: [PATCH v4 3/8] x86/EFI: retrieve EDID
Thread-Index: AQHYROQoBKP2/eH5XEKfptm0g77zk6za2O6A
Date: Fri, 1 Apr 2022 10:15:06 +0000
Message-ID: <08098A0F-D405-408E-AF63-190BC0BF43A5@arm.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
In-Reply-To: <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 81960768-fed5-4da1-6e32-08da13c88408
x-ms-traffictypediagnostic:
	AM8PR08MB6546:EE_|AM5EUR03FT017:EE_|DB9PR08MB6683:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB66831FBB8906BBF6A8FF4744E4E09@DB9PR08MB6683.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 1jZE3WlHVB2qkWDT7z83ex0UJ7OVKte0876v7EmAPbTsm++9F41uDSgK+Q4scQRndahetmPEJNsVPVU3dQRztx1q9CoYa0wZZwgA6bxm78cyIDFfx/IJRl0VezxFhaHyBbGwKBdgVKvrDe3fRCXF5dD8heW9ZnlQMVCYmSdreolNtput7EIYyMRnu3/i053mc66JCaH6z+rlm1nATdfyUr0HT5ZQhTdSFHjWd2XyaufPzADdNQ4/B5lMXE7sc5Y7+G+bAIK584QRatkvTDyl4cZ+SRQFQDDIv1WNPWQa/HsdtAp0tFWYwYkHQLzGVJHMTW1mZCro6dsHdwFFZwk2FW/uq7GUoCHL74aRNS95EAmTiQ01u+DMt5JTOvp5keRPruxMkF2coDB1uV4XwR9f2FuYMZSAtZLFhUMiPEpgIrF0Ag5bhI4bg6PSo506LyA8OORRLVHHwjHokbRC3FiOmtetRiE6xniLfrL0TJBlURkwujlytEhjvUDVAr90ktGyLESgxqjvBPeKDEARR86RvkbY+ZtEkmt0WFol3aLMDBKiF6igpIO5shxi5TH8EX3lItwSceOT3rxGc1IgarsSMXC8hjjFc/kifq7F8jpr0k/4MU0PHl4EDuOlu+pla+79KUZGToTGF7R44TdRF9OLcUakubZaM9/FWPRcRgrgbXq/fftM3A4xokvEsDjZKaMEnKTfop9D9GXOaeFvqht6yCvfSQz4zmU87dCNj5MA9ylcktyqLdgNrsupBpdxhJwr
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(4326008)(2906002)(122000001)(66946007)(5660300002)(36756003)(6506007)(8936002)(66476007)(86362001)(53546011)(8676002)(4744005)(66446008)(64756008)(66556008)(6512007)(54906003)(71200400001)(2616005)(6916009)(508600001)(38100700002)(6486002)(186003)(76116006)(38070700005)(26005)(33656002)(316002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <F8A50FCE23779E468773569C95085778@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6546
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b12f3b1f-dc60-41be-a1ac-08da13c87e86
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wrHXZ+jRyL/tMvwInLfafLbq5EAaGip20XWMBgHUyfLS7VFPatIXwn0PfYtsrA1qLNVcYS04tEFkzYAVWnNrONAxBnQc9ArL6aa1pf1wp3m4v8AVobCpup9ieYCmOqUyK37hYQJGhWbkfOt/LQIZBuch7R4lP3IE9YaxVVB++yyDCIlu4vWiP7hHk4oBYnAVCRjVeokqcw3mAfkESjT2kaVjBEPqWldOZs63RdAU4hwVbvxtexXQXA7UW9MXW14GxLWtO+AB6wl+9BRX9s+48GVijZkKWSkxFtEb/GsX04n626vYxZGU9KaDM33bLBrRj+TCLCup37QQ00+g3/eP3WQiG5oRZfXfoN1cMQXC0sijr8vmnln1alGJo79Om7HTtjVIukvKtz6ZqAbG076MEoUwsXnMkNz+2ccPyk6N5hJUB1+5a8zPcoapDR+PWNejgyWQu1KcauqRap46Cew3R2BEA08afZ1eMWRRVTxtIjG+Bid7WqvcLmRfeN6MuoiQL0pXBgtrQuAjoIMKeo9iegimRSrH/YaRY4j+h2Fd8V22+13wcp2utMiWXJiFGOGblZ4G1kpvyq8hX0bVohOZ19V6+jnatoVUXc+fts5/jIHcMaitXvIQ+ofU2v5QC1T8vT3hpFuEVPw7GikWbPO4DiA7A2gunAmHnPxhXjhJFmlpKb2Ls3ciRAGyugYYfJn0
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(54906003)(2906002)(36756003)(4744005)(4326008)(6862004)(8936002)(316002)(47076005)(6512007)(5660300002)(336012)(2616005)(82310400004)(26005)(40460700003)(186003)(508600001)(6506007)(86362001)(53546011)(70206006)(8676002)(33656002)(70586007)(81166007)(6486002)(356005)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 10:15:15.5253
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 81960768-fed5-4da1-6e32-08da13c88408
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6683



> On 31 Mar 2022, at 10:45, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> When booting directly from EFI, obtaining this information from EFI is
> the only possible way. And even when booting with a boot loader
> interposed, it's more clean not to use legacy BIOS calls for this
> purpose. (The downside being that there are no "capabilities" that we
> can retrieve the EFI way.)
>=20
> To achieve this we need to propagate the handle used to obtain the
> EFI_GRAPHICS_OUTPUT_PROTOCOL instance for further obtaining an
> EFI_EDID_*_PROTOCOL instance, which has been part of the spec since 2.5.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Hi Jan,

For the arm and common part, the changes looks good to me.

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

I tested also the whole serie in the sense that it boots properly on arm,
unfortunately I could not test the functionality.

Cheers,
Luca



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:21:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:21:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297303.506387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEPR-0008Ib-8Z; Fri, 01 Apr 2022 10:21:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297303.506387; Fri, 01 Apr 2022 10:21:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEPR-0008IU-5G; Fri, 01 Apr 2022 10:21:37 +0000
Received: by outflank-mailman (input) for mailman id 297303;
 Fri, 01 Apr 2022 10:21:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naEPP-0008IO-F2
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:21:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naEPO-0002UO-Dk; Fri, 01 Apr 2022 10:21:34 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naEPO-0006XR-72; Fri, 01 Apr 2022 10:21:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=WY7qYO4qwmcmb1mZ8BPp1zRbDkGk/TofJiVnNMkVnpQ=; b=lUvagXL9veQPFa+bKF8j6DTWiD
	eo8uMoEmbljjrPqQ+oYaDtNPvMmdj+aw1JSPWJ/NjUlm9CFgnXAed8NM7Gs+7C9CGBQlOR2cep4qf
	Arf6nJmmxPIOfdAdj7I5Ecac6T+bSvXRiG097Fvmp4U6d2431A26DtZJjovNuF6qi6YQ=;
Message-ID: <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
Date: Fri, 1 Apr 2022 11:21:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220401003847.38393-8-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I have posted some comments in v3 after you sent this version. Please 
have a look.

On 01/04/2022 01:38, Stefano Stabellini wrote:
> +static int init_domain(struct xs_handle *xsh, libxl_dominfo *info)
> +{
> +    struct xc_interface_core *xch;
> +    libxl_uuid uuid;
> +    uint64_t xenstore_evtchn, xenstore_pfn;
> +    int rc;
> +
> +    printf("Init dom0less domain: %u\n", info->domid);
> +    xch = xc_interface_open(0, 0, 0);
> +
> +    rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN,
> +                          &xenstore_evtchn);
> +    if (rc != 0) {
> +        printf("Failed to get HVM_PARAM_STORE_EVTCHN\n");
> +        return 1;
> +    }
> +
> +    /* Alloc xenstore page */
> +    if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) {
> +        printf("Error on alloc magic pages\n");
> +        return 1;
> +    }
> +
> +    rc = xc_dom_gnttab_seed(xch, info->domid, true,
> +                            (xen_pfn_t)-1, xenstore_pfn, 0, 0);
> +    if (rc)
> +        err(1, "xc_dom_gnttab_seed");
> +
> +    libxl_uuid_generate(&uuid);
> +    xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid));
> +
> +    rc = gen_stub_json_config(info->domid, &uuid);
> +    if (rc)
> +        err(1, "gen_stub_json_config");
> +
> +    /* Now everything is ready: set HVM_PARAM_STORE_PFN */
> +    rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN,
> +                          xenstore_pfn);

On patch #1, you told me you didn't want to allocate the page in Xen 
because it wouldn't be initialized by Xenstored. But this is what we are 
doing here.

This would be a problem if Linux is still booting and hasn't yet call 
xenbus_probe_initcall().

I understand we need to have the page setup before raising the event 
channel. I don't think we can allow Xenstored to set the HVM_PARAM (it 
may run in a domain with less privilege). So I think we may need to 
create a separate command to kick the client (not great).

Juergen, any thoughts?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:27:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:27:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297307.506397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEVE-0000Vk-U6; Fri, 01 Apr 2022 10:27:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297307.506397; Fri, 01 Apr 2022 10:27:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEVE-0000Vd-Qk; Fri, 01 Apr 2022 10:27:36 +0000
Received: by outflank-mailman (input) for mailman id 297307;
 Fri, 01 Apr 2022 10:27:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naEVC-0000VX-RQ
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:27:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naEVB-0002aJ-Nj; Fri, 01 Apr 2022 10:27:33 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naEVB-00073m-Gr; Fri, 01 Apr 2022 10:27:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=v79uHVZcuhwVxT49cZ1znI60Cbqgl8zSt4BbRZLNmFM=; b=MHXsoTlcndzLjRl2PNunR5Rgtb
	+O0PytIMrlWh1s57ko2RSEIy/iIuUQrftalVrlyx7nn5PWf/sDoiBWvCTWeIjd80azdCnPtGYw/lN
	meCXpJ0WbNYpYY3RU/nVFWYfrnJowAAa+dxABmBtyS7rzfXjoxJCP3TRwCGY4arX68eA=;
Message-ID: <e3c60e34-98f5-8854-c979-37e3a5ba4e69@xen.org>
Date: Fri, 1 Apr 2022 11:27:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v3 5/5] tools: add example application to initialize
 dom0less PV drivers
From: Julien Grall <julien@xen.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, jgross@suse.com,
 Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop>
 <20220128213307.2822078-5-sstabellini@kernel.org>
 <395710eb-ba51-eb67-1519-2a949326f699@xen.org>
 <alpine.DEB.2.22.394.2203221821520.2910984@ubuntu-linux-20-04-desktop>
 <07fa2884-e497-250b-53ab-dd452b501920@xen.org>
 <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop>
 <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>
In-Reply-To: <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 01/04/2022 11:02, Julien Grall wrote:
> Hi Stefano,
> 
> On 01/04/2022 01:35, Stefano Stabellini wrote:
>>>>>> +
>>>>>> +    /* Alloc magic pages */
>>>>>> +    if (alloc_magic_pages(info, &dom) != 0) {
>>>>>> +        printf("Error on alloc magic pages\n");
>>>>>> +        return 1;
>>>>>> +    }
>>>>>> +
>>>>>> +    xc_dom_gnttab_init(&dom);
>>>>>
>>>>> This call as the risk to break the guest if the dom0 Linux doesn't 
>>>>> support
>>>>> the
>>>>> acquire interface. This is because it will punch a hole in the domain
>>>>> memory
>>>>> where the grant-table may have already been mapped.
>>>>>
>>>>> Also, this function could fails.
>>>>
>>>> I'll check for return errors. Dom0less is for fully static
>>>> configurations so I think it is OK to return error and abort if
>>>> something unexpected happens: dom0less' main reason for being is that
>>>> there is nothing unexpected :-)
>>> Does this mean the caller will have to reboot the system if there is 
>>> an error?
>>> IOW, we don't expect them to call ./init-dom0less twice.
>>
>> Yes, exactly. I think init-dom0less could even panic. My mental model is
>> that this is an "extension" of construct_domU. Over there we just panic
>> if something is wrong and here it would be similar. The user provided a
>> wrong config and should fix it.
> 
> Ok. I think we should make explicit how it can be used.
> 
>>>>>> +
>>>>>> +    libxl_uuid_generate(&uuid);
>>>>>> +    xc_domain_sethandle(dom.xch, info->domid,
>>>>>> libxl_uuid_bytearray(&uuid));
>>>>>> +
>>>>>> +    rc = gen_stub_json_config(info->domid, &uuid);
>>>>>> +    if (rc)
>>>>>> +        err(1, "gen_stub_json_config");
>>>>>> +
>>>>>> +    rc = restore_xenstore(xsh, info, uuid, dom.xenstore_evtchn);
>>>>>> +    if (rc)
>>>>>> +        err(1, "writing to xenstore");
>>>>>> +
>>>>>> +    xs_introduce_domain(xsh, info->domid,
>>>>>> +            (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + 
>>>>>> XENSTORE_PFN_OFFSET,
>>>>>> +            dom.xenstore_evtchn);
>>>>>
>>>>> xs_introduce_domain() can technically fails.
>>>>
>>>> OK
>>>>
>>>>
>>>>>> +    return 0;
>>>>>> +}
>>>>>> +
>>>>>> +/* Check if domain has been configured in XS */
>>>>>> +static bool domain_exists(struct xs_handle *xsh, int domid)
>>>>>> +{
>>>>>> +    return xs_is_domain_introduced(xsh, domid);
>>>>>> +}
>>>>>
>>>>> Would not this lead to initialize a domain with PV driver disabled?
>>>>
>>>> I am not sure I understood your question, but I'll try to answer 
>>>> anyway.
>>>> This check is purely to distinguish dom0less guests, which needs 
>>>> further
>>>> initializations, from regular guests (e.g. xl guests) that don't need
>>>> any actions taken here.
>>>
>>> Dom0less domUs can be divided in two categories based on whether they 
>>> are xen
>>> aware (e.g. xen,enhanced is set).
>>>
>>> Looking at this script, it seems to assume that all dom0less domUs 
>>> are Xen
>>> aware. So it will end up to allocate Xenstore ring and call
>>> xs_introduce_domain(). I suspect the call will end up to fail because 
>>> the
>>> event channel would be 0.
>>>
>>> So did you try to use this script on a platform where there only xen 
>>> aware
>>> domU and/or a mix?
>>
>> Good idea of asking for this test. I thought I already ran that test,
>> but I did it again to be sure. Everything works OK (although the
>> xenstore page allocation is unneeded). xs_introduce_domain does not
>  > fail:
> 
> Are you sure? If I pass 0 as the 4th argument (event channel), the 
> command will return EINVAL. However, looking at the code you are not 
> checking the return for the call. So you will continue as if it were 
> successful.
> 
> So you will end up to write nodes for a domain Xenstored is not aware 
> and also set HVM_PARAM_STORE_PFN which may further confuse the guest as 
> it may try to initialize Xenstored it discovers the page.

^ if it discovers

> 
>> I think that's because it is usually called on all domains by the
>> toolstack, even the ones without xenstore support in the kernel.
> 
> The toolstack will always allocate the event channel irrespective to 
> whether the guest will use Xenstore. So both the shared page and the 
> event channel are always valid today.
> 
> With your series, this will change as the event channel will not be 
> allocated when "xen,enhanced" is not set.
> 
> In your case, I think we may want to register the domain to xenstore but 
> say there are no connection available for the domain. Juergen, what do 
> you think?
> 
> Cheers,
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:34:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:34:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297314.506415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEby-00022C-R8; Fri, 01 Apr 2022 10:34:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297314.506415; Fri, 01 Apr 2022 10:34:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEby-000225-No; Fri, 01 Apr 2022 10:34:34 +0000
Received: by outflank-mailman (input) for mailman id 297314;
 Fri, 01 Apr 2022 10:34:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Yu3J=UL=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1naEbx-00021z-LK
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:34:33 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 50fc3838-b1a7-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 12:34:32 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7B10621A98;
 Fri,  1 Apr 2022 10:34:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 392DE132C1;
 Fri,  1 Apr 2022 10:34:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id nlFiDDfVRmIvfAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Apr 2022 10:34:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50fc3838-b1a7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1648809271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vnvunBp12WVZ5MfSOIaP/1IkLI2hQWFNdjbD04ScTMI=;
	b=OyZ81FAr1IYiPTY7vCte+heJfRr+Nlz9ePtE9rnkrn6urynuBgx+Q2m9O7jrMFAn43wtIz
	XY0RZFp3vrog3O+uAvux/2kybX+OyhCaCbUfMCf6fSuksgI8/be91kljxEL/UHY3bXly92
	a3WqIeMZdlv1DfNnesAaTiOEoxEZRTE=
Message-ID: <2b5ef30a-5164-c685-e3bb-24dd29ad4236@suse.com>
Date: Fri, 1 Apr 2022 12:34:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com,
 Volodymyr_Babchuk@epam.com, Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop>
 <20220128213307.2822078-5-sstabellini@kernel.org>
 <395710eb-ba51-eb67-1519-2a949326f699@xen.org>
 <alpine.DEB.2.22.394.2203221821520.2910984@ubuntu-linux-20-04-desktop>
 <07fa2884-e497-250b-53ab-dd452b501920@xen.org>
 <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop>
 <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 5/5] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------qUMytYHzjO0weO8DwlM069mT"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------qUMytYHzjO0weO8DwlM069mT
Content-Type: multipart/mixed; boundary="------------sl1yTNdcFLrfAQlxex87YKgm";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com,
 Volodymyr_Babchuk@epam.com, Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <2b5ef30a-5164-c685-e3bb-24dd29ad4236@suse.com>
Subject: Re: [PATCH v3 5/5] tools: add example application to initialize
 dom0less PV drivers
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop>
 <20220128213307.2822078-5-sstabellini@kernel.org>
 <395710eb-ba51-eb67-1519-2a949326f699@xen.org>
 <alpine.DEB.2.22.394.2203221821520.2910984@ubuntu-linux-20-04-desktop>
 <07fa2884-e497-250b-53ab-dd452b501920@xen.org>
 <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop>
 <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>
In-Reply-To: <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>

--------------sl1yTNdcFLrfAQlxex87YKgm
Content-Type: multipart/mixed; boundary="------------CAz4mKPLj6aqvA3XUWVyA7OQ"

--------------CAz4mKPLj6aqvA3XUWVyA7OQ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDEuMDQuMjIgMTI6MDIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgU3RlZmFubywN
Cj4gDQo+IE9uIDAxLzA0LzIwMjIgMDE6MzUsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToN
Cj4+Pj4+PiArDQo+Pj4+Pj4gK8KgwqDCoCAvKiBBbGxvYyBtYWdpYyBwYWdlcyAqLw0KPj4+
Pj4+ICvCoMKgwqAgaWYgKGFsbG9jX21hZ2ljX3BhZ2VzKGluZm8sICZkb20pICE9IDApIHsN
Cj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgcHJpbnRmKCJFcnJvciBvbiBhbGxvYyBtYWdpYyBw
YWdlc1xuIik7DQo+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAxOw0KPj4+Pj4+ICvC
oMKgwqAgfQ0KPj4+Pj4+ICsNCj4+Pj4+PiArwqDCoMKgIHhjX2RvbV9nbnR0YWJfaW5pdCgm
ZG9tKTsNCj4+Pj4+DQo+Pj4+PiBUaGlzIGNhbGwgYXMgdGhlIHJpc2sgdG8gYnJlYWsgdGhl
IGd1ZXN0IGlmIHRoZSBkb20wIExpbnV4IGRvZXNuJ3Qgc3VwcG9ydA0KPj4+Pj4gdGhlDQo+
Pj4+PiBhY3F1aXJlIGludGVyZmFjZS4gVGhpcyBpcyBiZWNhdXNlIGl0IHdpbGwgcHVuY2gg
YSBob2xlIGluIHRoZSBkb21haW4NCj4+Pj4+IG1lbW9yeQ0KPj4+Pj4gd2hlcmUgdGhlIGdy
YW50LXRhYmxlIG1heSBoYXZlIGFscmVhZHkgYmVlbiBtYXBwZWQuDQo+Pj4+Pg0KPj4+Pj4g
QWxzbywgdGhpcyBmdW5jdGlvbiBjb3VsZCBmYWlscy4NCj4+Pj4NCj4+Pj4gSSdsbCBjaGVj
ayBmb3IgcmV0dXJuIGVycm9ycy4gRG9tMGxlc3MgaXMgZm9yIGZ1bGx5IHN0YXRpYw0KPj4+
PiBjb25maWd1cmF0aW9ucyBzbyBJIHRoaW5rIGl0IGlzIE9LIHRvIHJldHVybiBlcnJvciBh
bmQgYWJvcnQgaWYNCj4+Pj4gc29tZXRoaW5nIHVuZXhwZWN0ZWQgaGFwcGVuczogZG9tMGxl
c3MnIG1haW4gcmVhc29uIGZvciBiZWluZyBpcyB0aGF0DQo+Pj4+IHRoZXJlIGlzIG5vdGhp
bmcgdW5leHBlY3RlZCA6LSkNCj4+PiBEb2VzIHRoaXMgbWVhbiB0aGUgY2FsbGVyIHdpbGwg
aGF2ZSB0byByZWJvb3QgdGhlIHN5c3RlbSBpZiB0aGVyZSBpcyBhbiBlcnJvcj8NCj4+PiBJ
T1csIHdlIGRvbid0IGV4cGVjdCB0aGVtIHRvIGNhbGwgLi9pbml0LWRvbTBsZXNzIHR3aWNl
Lg0KPj4NCj4+IFllcywgZXhhY3RseS4gSSB0aGluayBpbml0LWRvbTBsZXNzIGNvdWxkIGV2
ZW4gcGFuaWMuIE15IG1lbnRhbCBtb2RlbCBpcw0KPj4gdGhhdCB0aGlzIGlzIGFuICJleHRl
bnNpb24iIG9mIGNvbnN0cnVjdF9kb21VLiBPdmVyIHRoZXJlIHdlIGp1c3QgcGFuaWMNCj4+
IGlmIHNvbWV0aGluZyBpcyB3cm9uZyBhbmQgaGVyZSBpdCB3b3VsZCBiZSBzaW1pbGFyLiBU
aGUgdXNlciBwcm92aWRlZCBhDQo+PiB3cm9uZyBjb25maWcgYW5kIHNob3VsZCBmaXggaXQu
DQo+IA0KPiBPay4gSSB0aGluayB3ZSBzaG91bGQgbWFrZSBleHBsaWNpdCBob3cgaXQgY2Fu
IGJlIHVzZWQuDQo+IA0KPj4+Pj4+ICsNCj4+Pj4+PiArwqDCoMKgIGxpYnhsX3V1aWRfZ2Vu
ZXJhdGUoJnV1aWQpOw0KPj4+Pj4+ICvCoMKgwqAgeGNfZG9tYWluX3NldGhhbmRsZShkb20u
eGNoLCBpbmZvLT5kb21pZCwNCj4+Pj4+PiBsaWJ4bF91dWlkX2J5dGVhcnJheSgmdXVpZCkp
Ow0KPj4+Pj4+ICsNCj4+Pj4+PiArwqDCoMKgIHJjID0gZ2VuX3N0dWJfanNvbl9jb25maWco
aW5mby0+ZG9taWQsICZ1dWlkKTsNCj4+Pj4+PiArwqDCoMKgIGlmIChyYykNCj4+Pj4+PiAr
wqDCoMKgwqDCoMKgwqAgZXJyKDEsICJnZW5fc3R1Yl9qc29uX2NvbmZpZyIpOw0KPj4+Pj4+
ICsNCj4+Pj4+PiArwqDCoMKgIHJjID0gcmVzdG9yZV94ZW5zdG9yZSh4c2gsIGluZm8sIHV1
aWQsIGRvbS54ZW5zdG9yZV9ldnRjaG4pOw0KPj4+Pj4+ICvCoMKgwqAgaWYgKHJjKQ0KPj4+
Pj4+ICvCoMKgwqDCoMKgwqDCoCBlcnIoMSwgIndyaXRpbmcgdG8geGVuc3RvcmUiKTsNCj4+
Pj4+PiArDQo+Pj4+Pj4gK8KgwqDCoCB4c19pbnRyb2R1Y2VfZG9tYWluKHhzaCwgaW5mby0+
ZG9taWQsDQo+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKEdVRVNUX01BR0lDX0JB
U0UgPj4gWENfUEFHRV9TSElGVCkgKyBYRU5TVE9SRV9QRk5fT0ZGU0VULA0KPj4+Pj4+ICvC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRvbS54ZW5zdG9yZV9ldnRjaG4pOw0KPj4+Pj4NCj4+
Pj4+IHhzX2ludHJvZHVjZV9kb21haW4oKSBjYW4gdGVjaG5pY2FsbHkgZmFpbHMuDQo+Pj4+
DQo+Pj4+IE9LDQo+Pj4+DQo+Pj4+DQo+Pj4+Pj4gK8KgwqDCoCByZXR1cm4gMDsNCj4+Pj4+
PiArfQ0KPj4+Pj4+ICsNCj4+Pj4+PiArLyogQ2hlY2sgaWYgZG9tYWluIGhhcyBiZWVuIGNv
bmZpZ3VyZWQgaW4gWFMgKi8NCj4+Pj4+PiArc3RhdGljIGJvb2wgZG9tYWluX2V4aXN0cyhz
dHJ1Y3QgeHNfaGFuZGxlICp4c2gsIGludCBkb21pZCkNCj4+Pj4+PiArew0KPj4+Pj4+ICvC
oMKgwqAgcmV0dXJuIHhzX2lzX2RvbWFpbl9pbnRyb2R1Y2VkKHhzaCwgZG9taWQpOw0KPj4+
Pj4+ICt9DQo+Pj4+Pg0KPj4+Pj4gV291bGQgbm90IHRoaXMgbGVhZCB0byBpbml0aWFsaXpl
IGEgZG9tYWluIHdpdGggUFYgZHJpdmVyIGRpc2FibGVkPw0KPj4+Pg0KPj4+PiBJIGFtIG5v
dCBzdXJlIEkgdW5kZXJzdG9vZCB5b3VyIHF1ZXN0aW9uLCBidXQgSSdsbCB0cnkgdG8gYW5z
d2VyIGFueXdheS4NCj4+Pj4gVGhpcyBjaGVjayBpcyBwdXJlbHkgdG8gZGlzdGluZ3Vpc2gg
ZG9tMGxlc3MgZ3Vlc3RzLCB3aGljaCBuZWVkcyBmdXJ0aGVyDQo+Pj4+IGluaXRpYWxpemF0
aW9ucywgZnJvbSByZWd1bGFyIGd1ZXN0cyAoZS5nLiB4bCBndWVzdHMpIHRoYXQgZG9uJ3Qg
bmVlZA0KPj4+PiBhbnkgYWN0aW9ucyB0YWtlbiBoZXJlLg0KPj4+DQo+Pj4gRG9tMGxlc3Mg
ZG9tVXMgY2FuIGJlIGRpdmlkZWQgaW4gdHdvIGNhdGVnb3JpZXMgYmFzZWQgb24gd2hldGhl
ciB0aGV5IGFyZSB4ZW4NCj4+PiBhd2FyZSAoZS5nLiB4ZW4sZW5oYW5jZWQgaXMgc2V0KS4N
Cj4+Pg0KPj4+IExvb2tpbmcgYXQgdGhpcyBzY3JpcHQsIGl0IHNlZW1zIHRvIGFzc3VtZSB0
aGF0IGFsbCBkb20wbGVzcyBkb21VcyBhcmUgWGVuDQo+Pj4gYXdhcmUuIFNvIGl0IHdpbGwg
ZW5kIHVwIHRvIGFsbG9jYXRlIFhlbnN0b3JlIHJpbmcgYW5kIGNhbGwNCj4+PiB4c19pbnRy
b2R1Y2VfZG9tYWluKCkuIEkgc3VzcGVjdCB0aGUgY2FsbCB3aWxsIGVuZCB1cCB0byBmYWls
IGJlY2F1c2UgdGhlDQo+Pj4gZXZlbnQgY2hhbm5lbCB3b3VsZCBiZSAwLg0KPj4+DQo+Pj4g
U28gZGlkIHlvdSB0cnkgdG8gdXNlIHRoaXMgc2NyaXB0IG9uIGEgcGxhdGZvcm0gd2hlcmUg
dGhlcmUgb25seSB4ZW4gYXdhcmUNCj4+PiBkb21VIGFuZC9vciBhIG1peD8NCj4+DQo+PiBH
b29kIGlkZWEgb2YgYXNraW5nIGZvciB0aGlzIHRlc3QuIEkgdGhvdWdodCBJIGFscmVhZHkg
cmFuIHRoYXQgdGVzdCwNCj4+IGJ1dCBJIGRpZCBpdCBhZ2FpbiB0byBiZSBzdXJlLiBFdmVy
eXRoaW5nIHdvcmtzIE9LIChhbHRob3VnaCB0aGUNCj4+IHhlbnN0b3JlIHBhZ2UgYWxsb2Nh
dGlvbiBpcyB1bm5lZWRlZCkuIHhzX2ludHJvZHVjZV9kb21haW4gZG9lcyBub3QNCj4gID4g
ZmFpbDoNCj4gDQo+IEFyZSB5b3Ugc3VyZT8gSWYgSSBwYXNzIDAgYXMgdGhlIDR0aCBhcmd1
bWVudCAoZXZlbnQgY2hhbm5lbCksIHRoZSBjb21tYW5kIHdpbGwgDQo+IHJldHVybiBFSU5W
QUwuIEhvd2V2ZXIsIGxvb2tpbmcgYXQgdGhlIGNvZGUgeW91IGFyZSBub3QgY2hlY2tpbmcg
dGhlIHJldHVybiBmb3IgDQo+IHRoZSBjYWxsLiBTbyB5b3Ugd2lsbCBjb250aW51ZSBhcyBp
ZiBpdCB3ZXJlIHN1Y2Nlc3NmdWwuDQo+IA0KPiBTbyB5b3Ugd2lsbCBlbmQgdXAgdG8gd3Jp
dGUgbm9kZXMgZm9yIGEgZG9tYWluIFhlbnN0b3JlZCBpcyBub3QgYXdhcmUgYW5kIGFsc28g
DQo+IHNldCBIVk1fUEFSQU1fU1RPUkVfUEZOIHdoaWNoIG1heSBmdXJ0aGVyIGNvbmZ1c2Ug
dGhlIGd1ZXN0IGFzIGl0IG1heSB0cnkgdG8gDQo+IGluaXRpYWxpemUgWGVuc3RvcmVkIGl0
IGRpc2NvdmVycyB0aGUgcGFnZS4NCj4gDQo+PiBJIHRoaW5rIHRoYXQncyBiZWNhdXNlIGl0
IGlzIHVzdWFsbHkgY2FsbGVkIG9uIGFsbCBkb21haW5zIGJ5IHRoZQ0KPj4gdG9vbHN0YWNr
LCBldmVuIHRoZSBvbmVzIHdpdGhvdXQgeGVuc3RvcmUgc3VwcG9ydCBpbiB0aGUga2VybmVs
Lg0KPiANCj4gVGhlIHRvb2xzdGFjayB3aWxsIGFsd2F5cyBhbGxvY2F0ZSB0aGUgZXZlbnQg
Y2hhbm5lbCBpcnJlc3BlY3RpdmUgdG8gd2hldGhlciB0aGUgDQo+IGd1ZXN0IHdpbGwgdXNl
IFhlbnN0b3JlLiBTbyBib3RoIHRoZSBzaGFyZWQgcGFnZSBhbmQgdGhlIGV2ZW50IGNoYW5u
ZWwgYXJlIA0KPiBhbHdheXMgdmFsaWQgdG9kYXkuDQo+IA0KPiBXaXRoIHlvdXIgc2VyaWVz
LCB0aGlzIHdpbGwgY2hhbmdlIGFzIHRoZSBldmVudCBjaGFubmVsIHdpbGwgbm90IGJlIGFs
bG9jYXRlZCANCj4gd2hlbiAieGVuLGVuaGFuY2VkIiBpcyBub3Qgc2V0Lg0KPiANCj4gSW4g
eW91ciBjYXNlLCBJIHRoaW5rIHdlIG1heSB3YW50IHRvIHJlZ2lzdGVyIHRoZSBkb21haW4g
dG8geGVuc3RvcmUgYnV0IHNheSANCj4gdGhlcmUgYXJlIG5vIGNvbm5lY3Rpb24gYXZhaWxh
YmxlIGZvciB0aGUgZG9tYWluLiBKdWVyZ2VuLCB3aGF0IGRvIHlvdSB0aGluaz8NCg0KSW4g
bXkgb3BpbmlvbiBzdWNoIGEgZG9tYWluIHNob3VsZCBub3QgYmUgcmVnaXN0ZXJlZCB3aXRo
IFhlbnN0b3JlLg0KDQpBdCBsZWFzdCBDLXhlbnN0b3JlZCBzaG91bGQgd29yayBtb3N0bHkg
Y29ycmVjdGx5LiBJIHRoaW5rIHRoZQ0KImludHJvZHVjZWQiIHN0YXR1cyBpcyB0ZXN0ZWQg
ZXZlcnl3aGVyZSBpdCBzaG91bGQgYmUgdGVzdGVkLg0KDQpCYXNpY2FsbHkgdGhpcyBpcyBz
aW1pbGFyIHRvIHRvZGF5J3Mgc3RhdHVzIG9mIHhlbnN0b3JlLXN0dWJkb206IGl0DQppcyBu
ZXZlciBpbnRyb2R1Y2VkLCBidXQgWGVuc3RvcmUgaXRzZWxmIGlzIGhhcHB5IHdpdGggaXQg
ZXhpc3RpbmcuIDotKQ0KDQpBbmQgZXZlbiB0b2RheSB0aGUgZmlyc3Qgbm9kZXMgZm9yIGEg
bmV3IGRvbWFpbiBhcmUgYmVpbmcgY3JlYXRlZA0KYmVmb3JlIHRoZSBkb21haW4gaXMgb2Zm
aWNpYWxseSBpbnRyb2R1Y2VkLg0KDQoNCkp1ZXJnZW4NCg==
--------------CAz4mKPLj6aqvA3XUWVyA7OQ
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------CAz4mKPLj6aqvA3XUWVyA7OQ--

--------------sl1yTNdcFLrfAQlxex87YKgm--

--------------qUMytYHzjO0weO8DwlM069mT
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJG1TYFAwAAAAAACgkQsN6d1ii/Ey/M
egf/SLJGHdxMdLVsN0djz8pDiFxUGVrrRHjz9COtCURsIg1s6t8jTE8sknZRn9W4nZhVOOi6OI3C
9z+ZIX8WjgY76PJfCcuJtigqrbf7HshUDT0Y/z+dNQ5Conxd3O2IN6jftG94tTbFlk+5jq/9MCZL
zOGDzttE+cWS64+5YQNaM7sYxzI57QnH9J3US5d0H6lRCoKXo2HoKeD2aQwRHBZR/+pMG45rMjTD
dOej4NAUnTUR5aWNS2/E++wWgsln1Dl2+ojE/YtFN3IqqKlitfiKxKH7F3Qb+MVjwHOKx6BPIefy
BEaVPrHtINux63eJI+8Tg5JeXBSyO3Lf5dGdu4V7HQ==
=BzoV
-----END PGP SIGNATURE-----

--------------qUMytYHzjO0weO8DwlM069mT--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:46:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:46:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297319.506429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEni-0003eo-Vc; Fri, 01 Apr 2022 10:46:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297319.506429; Fri, 01 Apr 2022 10:46:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEni-0003eh-Sa; Fri, 01 Apr 2022 10:46:42 +0000
Received: by outflank-mailman (input) for mailman id 297319;
 Fri, 01 Apr 2022 10:46:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Yu3J=UL=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1naEnh-0003eb-6W
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:46:41 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02a7e451-b1a9-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 12:46:39 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 268F61FD00;
 Fri,  1 Apr 2022 10:46:39 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D6883132C1;
 Fri,  1 Apr 2022 10:46:38 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 44w8Mw7YRmIaBAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Apr 2022 10:46:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02a7e451-b1a9-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1648809999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=26NEk7VUw7+DjntA35ch5bBv1llhNsW1xqQQFxBntHE=;
	b=fRU+bptA5bc5ckMjZcQERmL0k9HJEUzAy4AcBfKqU7RnkBLH3vCVxv8Xnv4wBpOHoGf10C
	v8hXNSb9Zxokd4bPFdDF9HWuHZTblFAwI1HcPq+awirlIZGg2117aCZ0BKMJRbAvTpyLuU
	gsOmtsYEVL0Xb6GwfmuHTrVqb5zwB9A=
Message-ID: <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
Date: Fri, 1 Apr 2022 12:46:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------Ldw0HiRYns5gC0Tccu07ONYW"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------Ldw0HiRYns5gC0Tccu07ONYW
Content-Type: multipart/mixed; boundary="------------GNxH0YUAEABkxBSGYVkx0oX0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
In-Reply-To: <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>

--------------GNxH0YUAEABkxBSGYVkx0oX0
Content-Type: multipart/mixed; boundary="------------EUHIbn803tWTjlfPTHDzJLNa"

--------------EUHIbn803tWTjlfPTHDzJLNa
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDEuMDQuMjIgMTI6MjEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBJ
IGhhdmUgcG9zdGVkIHNvbWUgY29tbWVudHMgaW4gdjMgYWZ0ZXIgeW91IHNlbnQgdGhpcyB2
ZXJzaW9uLiBQbGVhc2UgaGF2ZSBhIGxvb2suDQo+IA0KPiBPbiAwMS8wNC8yMDIyIDAxOjM4
LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+PiArc3RhdGljIGludCBpbml0X2RvbWFp
bihzdHJ1Y3QgeHNfaGFuZGxlICp4c2gsIGxpYnhsX2RvbWluZm8gKmluZm8pDQo+PiArew0K
Pj4gK8KgwqDCoCBzdHJ1Y3QgeGNfaW50ZXJmYWNlX2NvcmUgKnhjaDsNCj4+ICvCoMKgwqAg
bGlieGxfdXVpZCB1dWlkOw0KPj4gK8KgwqDCoCB1aW50NjRfdCB4ZW5zdG9yZV9ldnRjaG4s
IHhlbnN0b3JlX3BmbjsNCj4+ICvCoMKgwqAgaW50IHJjOw0KPj4gKw0KPj4gK8KgwqDCoCBw
cmludGYoIkluaXQgZG9tMGxlc3MgZG9tYWluOiAldVxuIiwgaW5mby0+ZG9taWQpOw0KPj4g
K8KgwqDCoCB4Y2ggPSB4Y19pbnRlcmZhY2Vfb3BlbigwLCAwLCAwKTsNCj4+ICsNCj4+ICvC
oMKgwqAgcmMgPSB4Y19odm1fcGFyYW1fZ2V0KHhjaCwgaW5mby0+ZG9taWQsIEhWTV9QQVJB
TV9TVE9SRV9FVlRDSE4sDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgJnhlbnN0b3JlX2V2dGNobik7DQo+PiArwqDCoMKgIGlmIChy
YyAhPSAwKSB7DQo+PiArwqDCoMKgwqDCoMKgwqAgcHJpbnRmKCJGYWlsZWQgdG8gZ2V0IEhW
TV9QQVJBTV9TVE9SRV9FVlRDSE5cbiIpOw0KPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAx
Ow0KPj4gK8KgwqDCoCB9DQo+PiArDQo+PiArwqDCoMKgIC8qIEFsbG9jIHhlbnN0b3JlIHBh
Z2UgKi8NCj4+ICvCoMKgwqAgaWYgKGFsbG9jX3hzX3BhZ2UoeGNoLCBpbmZvLCAmeGVuc3Rv
cmVfcGZuKSAhPSAwKSB7DQo+PiArwqDCoMKgwqDCoMKgwqAgcHJpbnRmKCJFcnJvciBvbiBh
bGxvYyBtYWdpYyBwYWdlc1xuIik7DQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDE7DQo+
PiArwqDCoMKgIH0NCj4+ICsNCj4+ICvCoMKgwqAgcmMgPSB4Y19kb21fZ250dGFiX3NlZWQo
eGNoLCBpbmZvLT5kb21pZCwgdHJ1ZSwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHhlbl9wZm5fdCktMSwgeGVuc3RvcmVf
cGZuLCAwLCAwKTsNCj4+ICvCoMKgwqAgaWYgKHJjKQ0KPj4gK8KgwqDCoMKgwqDCoMKgIGVy
cigxLCAieGNfZG9tX2dudHRhYl9zZWVkIik7DQo+PiArDQo+PiArwqDCoMKgIGxpYnhsX3V1
aWRfZ2VuZXJhdGUoJnV1aWQpOw0KPj4gK8KgwqDCoCB4Y19kb21haW5fc2V0aGFuZGxlKHhj
aCwgaW5mby0+ZG9taWQsIGxpYnhsX3V1aWRfYnl0ZWFycmF5KCZ1dWlkKSk7DQo+PiArDQo+
PiArwqDCoMKgIHJjID0gZ2VuX3N0dWJfanNvbl9jb25maWcoaW5mby0+ZG9taWQsICZ1dWlk
KTsNCj4+ICvCoMKgwqAgaWYgKHJjKQ0KPj4gK8KgwqDCoMKgwqDCoMKgIGVycigxLCAiZ2Vu
X3N0dWJfanNvbl9jb25maWciKTsNCj4+ICsNCj4+ICvCoMKgwqAgLyogTm93IGV2ZXJ5dGhp
bmcgaXMgcmVhZHk6IHNldCBIVk1fUEFSQU1fU1RPUkVfUEZOICovDQo+PiArwqDCoMKgIHJj
ID0geGNfaHZtX3BhcmFtX3NldCh4Y2gsIGluZm8tPmRvbWlkLCBIVk1fUEFSQU1fU1RPUkVf
UEZOLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIHhlbnN0b3JlX3Bmbik7DQo+IA0KPiBPbiBwYXRjaCAjMSwgeW91IHRvbGQgbWUg
eW91IGRpZG4ndCB3YW50IHRvIGFsbG9jYXRlIHRoZSBwYWdlIGluIFhlbiBiZWNhdXNlIGl0
IA0KPiB3b3VsZG4ndCBiZSBpbml0aWFsaXplZCBieSBYZW5zdG9yZWQuIEJ1dCB0aGlzIGlz
IHdoYXQgd2UgYXJlIGRvaW5nIGhlcmUuDQoNClhlbnN0b3JlIChhdCBsZWFzdCB0aGUgQyB2
YXJpYW50KSBpcyBvbmx5IHVzaW5nIHRoZSBmaXhlZCBncmFudCByZWYNCkdOVFRBQl9SRVNF
UlZFRF9YRU5TVE9SRSwgc28gaXQgZG9lc24ndCBuZWVkIHRoZSBwYWdlIHRvIGJlIGFkdmVy
dGlzZWQNCnRvIHRoZSBndWVzdC4gQW5kIHRoZSBtYXBwaW5nIGlzIGRvbmUgb25seSB3aGVu
IHRoZSBkb21haW4gaXMgYmVpbmcNCmludHJvZHVjZWQgdG8gWGVuc3RvcmUuDQoNCj4gDQo+
IFRoaXMgd291bGQgYmUgYSBwcm9ibGVtIGlmIExpbnV4IGlzIHN0aWxsIGJvb3RpbmcgYW5k
IGhhc24ndCB5ZXQgY2FsbCANCj4geGVuYnVzX3Byb2JlX2luaXRjYWxsKCkuDQo+IA0KPiBJ
IHVuZGVyc3RhbmQgd2UgbmVlZCB0byBoYXZlIHRoZSBwYWdlIHNldHVwIGJlZm9yZSByYWlz
aW5nIHRoZSBldmVudCBjaGFubmVsLiBJIA0KPiBkb24ndCB0aGluayB3ZSBjYW4gYWxsb3cg
WGVuc3RvcmVkIHRvIHNldCB0aGUgSFZNX1BBUkFNIChpdCBtYXkgcnVuIGluIGEgZG9tYWlu
IA0KPiB3aXRoIGxlc3MgcHJpdmlsZWdlKS4gU28gSSB0aGluayB3ZSBtYXkgbmVlZCB0byBj
cmVhdGUgYSBzZXBhcmF0ZSBjb21tYW5kIHRvIA0KPiBraWNrIHRoZSBjbGllbnQgKG5vdCBn
cmVhdCkuDQo+IA0KPiBKdWVyZ2VuLCBhbnkgdGhvdWdodHM/DQoNCkkgdGhpbmsgaXQgc2hv
dWxkIHdvcmsgbGlrZSB0aGF0Og0KDQotIHNldHVwIHRoZSBncmFudCB2aWEgeGNfZG9tX2du
dHRhYl9zZWVkKCkNCi0gaW50cm9kdWNlIHRoZSBkb21haW4gdG8gWGVuc3RvcmUNCi0gY2Fs
bCB4Y19odm1fcGFyYW1fc2V0KCkNCg0KV2hlbiB0aGUgZ3Vlc3QgaXMgcmVjZWl2aW5nIHRo
ZSBldmVudCwgaXQgc2hvdWxkIHdhaXQgZm9yIHRoZSB4ZW5zdG9yZQ0KcGFnZSB0byBhcHBl
YXIuDQoNCg0KSnVlcmdlbg0K
--------------EUHIbn803tWTjlfPTHDzJLNa
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------EUHIbn803tWTjlfPTHDzJLNa--

--------------GNxH0YUAEABkxBSGYVkx0oX0--

--------------Ldw0HiRYns5gC0Tccu07ONYW
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJG2A4FAwAAAAAACgkQsN6d1ii/Ey8t
gQf+N5Dki9x35s/aK9ZyTrPc86Efw6QxNDvQleG1/J+hDEbMYEKuCyQo5fnqYouP0Z2kMQ8j1xJv
L66kno1jqf75XM2aFeTo7bl2mGxVuQC9yt+Qq9WGWX1lVKB8srHhNZHSDzf8fjheFW5/cLzQv4Ju
iXLshRnGKYMUm3mqeaDIr8Xd5XUfSPyw7rd/8nRfo3A0p/bgDoHDzdakRYPDouf9IAJjsOGFfUgk
+NtqMLWIIgZ2j6Ft55RCKQWdvtcvDzj0sFtXj7wK5tLzUolRojyEiqfCGuao1aV1Ui6BsIAwL3/T
/wu5YJA+fMFU7+qDMzT2av5gsopIMUW88726zr/n9Q==
=AiMh
-----END PGP SIGNATURE-----

--------------Ldw0HiRYns5gC0Tccu07ONYW--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:47:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:47:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297322.506440 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEod-0004CB-Aw; Fri, 01 Apr 2022 10:47:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297322.506440; Fri, 01 Apr 2022 10:47:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEod-0004C4-6n; Fri, 01 Apr 2022 10:47:39 +0000
Received: by outflank-mailman (input) for mailman id 297322;
 Fri, 01 Apr 2022 10:47:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bus8=UL=citrix.com=prvs=083938fea=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1naEob-00047q-79
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:47:37 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 234457a6-b1a9-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 12:47:35 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 234457a6-b1a9-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648810055;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=lqhAYgH4gAJlMNkPJYi2gTZVGoHazDa+FAuusKfEXzU=;
  b=Ub2vah5eQlScxG2Nkf0Mzi17w+NDJfxOWXmTY3Qn4m1E3jXfWywCHngJ
   0B+tlEqmxjZubPrBj1LNs51vFhsmt7LhJHbXGbtnju7eQy8nKjuyjsHE8
   Yo50qFYyLCt1fyqw+p1f1MEJpr6FiVfUTp6O+ld3KZ0rtkZ2cMwOR5Csd
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68157099
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LKaSDapb7xR6bbkPvUp5wXEg2XdeBmJ9ZRIvgKrLsJaIsI4StFCzt
 garIBmPbP2Oa2v8L9pyOtzj/UoFu5HQzNRlHAJs/y5jEiMa8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Yqq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBHJfWork0ax1hDgZSEbdh25vAL0b4mJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI7zjfALADSJTKR6zM6PdT3Ssqh9AIFvHbD
 yYcQWQ/NUmfO0weUrsRIIk8oeCyvHO4SgZV+EKLpIgs00bDwDUkhdABN/KKI4fXFK25hH2wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3nsOGm3XKmDZVUkdPEwLm/7/p0SZSRu6zN
 WQ2wDAU8IEK8HW2afXRRTqbhHmKgFk1Do84//IB1CmBza/d4gC8D2cCTyJcZNFOiPLaVQDGx
 XfSwYq3WGUHXKm9DCvEq+zK9W/a1T09dzdqWMMScecSDzAPSqkXhwmHcNtsGbXdYjbdSWCpm
 GDiQMTTatwuYS83O0eToAivb9GE/MGhousJCuP/BD3NAuRRPtLNWmBQwQKHhcus1a7AJrV7g
 FAKmtKF8McFBoyXmSqGTY0lRe/1t6nYameE0A8yQvHNEghBHVb5Iui8BxkkeS9U3jssI2e1M
 Cc/RysPjHOsAJdaRfAuON/gYyjb5aPhCc7kRpjpgilmOfBMmPu81Hg2Pya4hjm1+GB1yP1XE
 crLIK6EUCdBYYw6nWXeegvo+eJyrszI7TiIHs6TItXO+ef2WUN5vp9ebgPUN7ppvf7cyOgXm
 v4GX/a3J9xkeLWWSkHqHUQ7dzjm8VBT6UjKlvFq
IronPort-HdrOrdr: A9a23:gpqRY63+DcCMaYwy7zceYgqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="68157099"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>
Subject: [PATCH v9 0/2] xen: Report and use hardware APIC virtualization capabilities
Date: Fri, 1 Apr 2022 11:47:11 +0100
Message-ID: <20220401104713.22291-1-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Jane Malalane (2):
  xen+tools: Report Interrupt Controller Virtualization capabilities on
    x86
  x86/xen: Allow per-domain usage of hardware virtualized APIC

 docs/man/xl.cfg.5.pod.in              | 15 ++++++++++++++
 docs/man/xl.conf.5.pod.in             | 12 +++++++++++
 tools/golang/xenlight/helpers.gen.go  | 16 ++++++++++++++
 tools/golang/xenlight/types.gen.go    |  4 ++++
 tools/include/libxl.h                 | 14 +++++++++++++
 tools/libs/light/libxl.c              |  3 +++
 tools/libs/light/libxl_arch.h         |  9 ++++++--
 tools/libs/light/libxl_arm.c          | 14 ++++++++++---
 tools/libs/light/libxl_create.c       | 22 ++++++++++++--------
 tools/libs/light/libxl_types.idl      |  4 ++++
 tools/libs/light/libxl_x86.c          | 39 +++++++++++++++++++++++++++++++++--
 tools/ocaml/libs/xc/xenctrl.ml        |  7 +++++++
 tools/ocaml/libs/xc/xenctrl.mli       |  7 +++++++
 tools/ocaml/libs/xc/xenctrl_stubs.c   | 17 ++++++++++++---
 tools/xl/xl.c                         |  8 +++++++
 tools/xl/xl.h                         |  2 ++
 tools/xl/xl_info.c                    |  6 ++++--
 tools/xl/xl_parse.c                   | 19 +++++++++++++++++
 xen/arch/x86/domain.c                 | 29 +++++++++++++++++++++++++-
 xen/arch/x86/hvm/hvm.c                |  3 +++
 xen/arch/x86/hvm/vmx/vmcs.c           | 10 +++++++++
 xen/arch/x86/hvm/vmx/vmx.c            | 13 ++++--------
 xen/arch/x86/include/asm/hvm/domain.h |  6 ++++++
 xen/arch/x86/include/asm/hvm/hvm.h    | 10 +++++++++
 xen/arch/x86/sysctl.c                 |  4 ++++
 xen/arch/x86/traps.c                  |  5 +++--
 xen/include/public/arch-x86/xen.h     |  5 +++++
 xen/include/public/sysctl.h           | 11 +++++++++-
 28 files changed, 280 insertions(+), 34 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:47:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:47:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297323.506451 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEog-0004UQ-M5; Fri, 01 Apr 2022 10:47:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297323.506451; Fri, 01 Apr 2022 10:47:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEog-0004UF-Iz; Fri, 01 Apr 2022 10:47:42 +0000
Received: by outflank-mailman (input) for mailman id 297323;
 Fri, 01 Apr 2022 10:47:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bus8=UL=citrix.com=prvs=083938fea=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1naEof-0004So-9h
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:47:41 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2451c320-b1a9-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 12:47:38 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2451c320-b1a9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648810058;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=2BLqI1DpBbLVHiwrG1X/wkMPwOmygL+LM/7pOBRmcNM=;
  b=SUsSa1nIaYu0rKx6uECoi/WtTIad/RDZgjsZcS+rlp8QlGejlnCgzwFJ
   A2YgnkCjkgEJ1eTB0LcIY4LlmajlykQ6IFgxi5QJmH+dvzAQYf5cjcKeR
   y4qaKXpOMiOzXTxk7l/N/wq3QrpPDqiKA+xzGUlLyD/XMUqzW71XUcsXO
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67768402
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:C3ZvrKrIs2kghD5iy8kVeAElQcteBmL4ZRIvgKrLsJaIsI4StFCzt
 garIBnQaamDa2KjKowia4Xi/BsCv5bTm9I3TQplrC1mHixA95uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Yqq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBE67xoOA0bkRjGntyZ6RY9biYcUqCrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI7zjfALADSJTKR6zM6PdT3Ssqh9AIFvHbD
 yYcQWQwM0qQP0UVUrsRII0xjfWUuzqvSjRnrV2Oh7gT/GX9kyUkhdABN/KKI4fXFK25hH2wv
 Xna9m70BhUbMt23yjef9H+owOjVkkvTWp8WFbC+3u5nhhuU3GN7ICMRUVy3sPyokHmUUthUK
 1EX0ic2pK10/0uuJvHxVgO1iGSJtRkdX5xXCeJSwAOC0K3P+C6CG3MJCDVGbbQOpMIwADAny
 FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcdYQcUQA1D5MPsyKkxhB/SStdoEIauk8b4Xzr3x
 li3QDMW3utJy5RRjuPioA6B02nESoX1ohAdywbqZmaM015CbdSpPYW25F+EvcR9M9PMJrWeh
 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GpxcEQIFd
 nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONl1Hw2DaJz9zq0+KTJrU3ZE
 c3EGSpLJSxGYZmLNBLsG48gPUYDn0jSP1/7S5Hh1AiA2rGDfnOTQrptGALQMrBmsfne+FSEr
 os32y62J/N3CrKWjs7/q9N7ELz3BSJjWcCeRzJ/KIZv3TaK6El+UqSMkNvNiqRunrhPl/egw
 51OchQw9bYLvlWecV/iQik6MNvHBM8jxVpmbX1EFQv5gBALPNfwhJrzgrNqJNHLAsQ4lqUqJ
 xTEEu3daslypsPvoGpFN8Cn/N0/LHxGR2umZkKYXdT2RLY4LyShxzMuVlKHGPUmZsZvifYDn
 g==
IronPort-HdrOrdr: A9a23:qO/ABK6L/O7CL83ywgPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="67768402"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v9 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
Date: Fri, 1 Apr 2022 11:47:13 +0100
Message-ID: <20220401104713.22291-3-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220401104713.22291-1-jane.malalane@citrix.com>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Introduce a new per-domain creation x86 specific flag to
select whether hardware assisted virtualization should be used for
x{2}APIC.

A per-domain option is added to xl in order to select the usage of
x{2}APIC hardware assisted virtualization, as well as a global
configuration option.

Having all APIC interaction exit to Xen for emulation is slow and can
induce much overhead. Hardware can speed up x{2}APIC by decoding the
APIC access and providing a VM exit with a more specific exit reason
than a regular EPT fault or by altogether avoiding a VM exit.

On the other hand, being able to disable x{2}APIC hardware assisted
virtualization can be useful for testing and debugging purposes.

Note:

- vmx_install_vlapic_mapping doesn't require modifications regardless
of whether the guest has "Virtualize APIC accesses" enabled or not,
i.e., setting the APIC_ACCESS_ADDR VMCS field is fine so long as
virtualize_apic_accesses is supported by the CPU.

- Both per-domain and global assisted_x{2}apic options are not part of
the migration stream, unless explicitly set in the configuration file,
so it is safe to migrate a guest that doesn't have assisted_x{2}apic
set in its config file between hosts that have different support for
hardware assisted x{2}APIC virtualization.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Christian Lindig <christian.lindig@citrix.com>
CC: David Scott <dave@recoil.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>

v9:
 * Fix style issues
 * Fix exit() logic for assisted_x{2}apic parsing
 * Add and use XEN_X86_MISC_FLAGS_MAX for ABI checking instead of
   using XEN_X86_ASSISTED_X2APIC directly
 * Expand commit message to mention migration is safe

v8:
 * Widen assisted_x{2}apic parsing to PVH guests in
   parse_config_data()

v7:
 * Fix void return in libxl__arch_domain_build_info_setdefault
 * Fix style issues
 * Use EINVAL when rejecting assisted_x{2}apic for PV guests and
   ENODEV otherwise, when assisted_x{2}apic isn't supported
 * Define has_assisted_x{2}apic macros for when !CONFIG_HVM
 * Replace "EPT" fault reference with "p2m" fault since the former is
   Intel-specific

v6:
 * Use ENODEV instead of EINVAL when rejecting assisted_x{2}apic
   for PV guests
 * Move has_assisted_x{2}apic macros out of an Intel specific header
 * Remove references to Intel specific features in documentation

v5:
 * Revert v4 changes in vmx_vlapic_msr_changed(), preserving the use of
   the has_assisted_x{2}apic macros
 * Following changes in assisted_x{2}apic_available definitions in
   patch 1, retighten conditionals for setting
   XEN_HVM_CPUID_APIC_ACCESS_VIRT and XEN_HVM_CPUID_X2APIC_VIRT in
   cpuid_hypervisor_leaves()

v4:
 * Add has_assisted_x{2}apic macros and use them where appropriate
 * Replace CPU checks with per-domain assisted_x{2}apic control
   options in vmx_vlapic_msr_changed() and cpuid_hypervisor_leaves(),
   following edits to assisted_x{2}apic_available definitions in
   patch 1
   Note: new assisted_x{2}apic_available definitions make later
   cpu_has_vmx_apic_reg_virt and cpu_has_vmx_virtual_intr_delivery
   checks redundant in vmx_vlapic_msr_changed()

v3:
 * Change info in xl.cfg to better express reality and fix
   capitalization of x{2}apic
 * Move "physinfo" variable definition to the beggining of
   libxl__domain_build_info_setdefault()
 * Reposition brackets in if statement to match libxl coding style
 * Shorten logic in libxl__arch_domain_build_info_setdefault()
 * Correct dprintk message in arch_sanitise_domain_config()
 * Make appropriate changes in vmx_vlapic_msr_changed() and
   cpuid_hypervisor_leaves() for amended "assisted_x2apic" bit
 * Remove unneeded parantheses

v2:
 * Add a LIBXL_HAVE_ASSISTED_APIC macro
 * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
 * Add a return statement in now "int"
   libxl__arch_domain_build_info_setdefault()
 * Preserve libxl__arch_domain_build_info_setdefault 's location in
   libxl_create.c
 * Correct x{2}apic default setting logic in
   libxl__arch_domain_prepare_config()
 * Correct logic for parsing assisted_x{2}apic host/guest options in
   xl_parse.c and initialize them to -1 in xl.c
 * Use guest options directly in vmx_vlapic_msr_changed
 * Fix indentation of bool assisted_x{2}apic in struct hvm_domain
 * Add a change in xenctrl_stubs.c to pass xenctrl ABI checks
---
 docs/man/xl.cfg.5.pod.in              | 15 +++++++++++++++
 docs/man/xl.conf.5.pod.in             | 12 ++++++++++++
 tools/golang/xenlight/helpers.gen.go  | 12 ++++++++++++
 tools/golang/xenlight/types.gen.go    |  2 ++
 tools/include/libxl.h                 |  7 +++++++
 tools/libs/light/libxl_arch.h         |  5 +++--
 tools/libs/light/libxl_arm.c          |  9 ++++++---
 tools/libs/light/libxl_create.c       | 22 +++++++++++++---------
 tools/libs/light/libxl_types.idl      |  2 ++
 tools/libs/light/libxl_x86.c          | 28 ++++++++++++++++++++++++++--
 tools/ocaml/libs/xc/xenctrl.ml        |  2 ++
 tools/ocaml/libs/xc/xenctrl.mli       |  2 ++
 tools/ocaml/libs/xc/xenctrl_stubs.c   |  2 +-
 tools/xl/xl.c                         |  8 ++++++++
 tools/xl/xl.h                         |  2 ++
 tools/xl/xl_parse.c                   | 19 +++++++++++++++++++
 xen/arch/x86/domain.c                 | 29 ++++++++++++++++++++++++++++-
 xen/arch/x86/hvm/vmx/vmcs.c           |  4 ++++
 xen/arch/x86/hvm/vmx/vmx.c            | 13 ++++---------
 xen/arch/x86/include/asm/hvm/domain.h |  6 ++++++
 xen/arch/x86/include/asm/hvm/hvm.h    |  5 +++++
 xen/arch/x86/traps.c                  |  5 +++--
 xen/include/public/arch-x86/xen.h     |  5 +++++
 23 files changed, 187 insertions(+), 29 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index b98d161398..6d98d73d76 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1862,6 +1862,21 @@ firmware tables when using certain older guest Operating
 Systems. These tables have been superseded by newer constructs within
 the ACPI tables.
 
+=item B<assisted_xapic=BOOLEAN>
+
+B<(x86 only)> Enables or disables hardware assisted virtualization for
+xAPIC. With this option enabled, a memory-mapped APIC access will be
+decoded by hardware and either issue a more specific VM exit than just
+a p2m fault, or altogether avoid a VM exit. The
+default is settable via L<xl.conf(5)>.
+
+=item B<assisted_x2apic=BOOLEAN>
+
+B<(x86 only)> Enables or disables hardware assisted virtualization for
+x2APIC. With this option enabled, certain accesses to MSR APIC
+registers will avoid a VM exit into the hypervisor. The default is
+settable via L<xl.conf(5)>.
+
 =item B<nx=BOOLEAN>
 
 B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest
diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
index df20c08137..95d136d1ea 100644
--- a/docs/man/xl.conf.5.pod.in
+++ b/docs/man/xl.conf.5.pod.in
@@ -107,6 +107,18 @@ Sets the default value for the C<max_grant_version> domain config value.
 
 Default: maximum grant version supported by the hypervisor.
 
+=item B<assisted_xapic=BOOLEAN>
+
+If enabled, domains will use xAPIC hardware assisted virtualization by default.
+
+Default: enabled if supported.
+
+=item B<assisted_x2apic=BOOLEAN>
+
+If enabled, domains will use x2APIC hardware assisted virtualization by default.
+
+Default: enabled if supported.
+
 =item B<vif.default.script="PATH">
 
 Configures the default hotplug script used by virtual network devices.
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index dd4e6c9f14..dece545ee0 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1120,6 +1120,12 @@ x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart)
 if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil {
 return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
+if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
+}
+if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
+}
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
 if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
@@ -1605,6 +1611,12 @@ xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart)
 if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil {
 return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
+if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
+}
+if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
+}
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
 if err := x.Vpmu.toC(&xc.vpmu); err != nil {
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 87be46c745..253c9ad93d 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -520,6 +520,8 @@ Vuart VuartType
 }
 ArchX86 struct {
 MsrRelaxed Defbool
+AssistedXapic Defbool
+AssistedX2Apic Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 94e6355822..cdcccd6d01 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -535,6 +535,13 @@
 #define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
 
 /*
+ * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has
+ * assisted_xapic and assisted_x2apic fields for enabling hardware
+ * assisted virtualization for x{2}apic per domain.
+ */
+#define LIBXL_HAVE_ASSISTED_APIC 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 207ceac6a1..03b89929e6 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -71,8 +71,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
                                                libxl_domain_create_info *c_info);
 
 _hidden
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info);
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo);
 
 _hidden
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 39fdca1b49..7dee2afd4b 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1384,14 +1384,15 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
     }
 }
 
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info)
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo)
 {
     /* ACPI is disabled by default */
     libxl_defbool_setdefault(&b_info->acpi, false);
 
     if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
-        return;
+        return 0;
 
     LOG(DEBUG, "Converting build_info to PVH");
 
@@ -1399,6 +1400,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
     memset(&b_info->u, '\0', sizeof(b_info->u));
     b_info->type = LIBXL_DOMAIN_TYPE_INVALID;
     libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH);
+
+    return 0;
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 15ed021f41..88d08d7277 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -75,6 +75,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
                                         libxl_domain_build_info *b_info)
 {
     int i, rc;
+    libxl_physinfo info;
 
     if (b_info->type != LIBXL_DOMAIN_TYPE_HVM &&
         b_info->type != LIBXL_DOMAIN_TYPE_PV &&
@@ -264,7 +265,18 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     if (!b_info->event_channels)
         b_info->event_channels = 1023;
 
-    libxl__arch_domain_build_info_setdefault(gc, b_info);
+    rc = libxl_get_physinfo(CTX, &info);
+    if (rc) {
+        LOG(ERROR, "failed to get hypervisor info");
+        return rc;
+    }
+
+    rc = libxl__arch_domain_build_info_setdefault(gc, b_info, &info);
+    if (rc) {
+        LOG(ERROR, "unable to set domain arch build info defaults");
+        return rc;
+    }
+
     libxl_defbool_setdefault(&b_info->dm_restrict, false);
 
     if (b_info->iommu_memkb == LIBXL_MEMKB_DEFAULT)
@@ -457,14 +469,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) {
-        libxl_physinfo info;
-
-        rc = libxl_get_physinfo(CTX, &info);
-        if (rc) {
-            LOG(ERROR, "failed to get hypervisor info");
-            return rc;
-        }
-
         if (info.cap_gnttab_v2)
             b_info->max_grant_version = 2;
         else if (info.cap_gnttab_v1)
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 42ac6c357b..db5eb0a0b3 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -648,6 +648,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
                                ("vuart", libxl_vuart_type),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
+                               ("assisted_xapic", libxl_defbool),
+                               ("assisted_x2apic", libxl_defbool),
                               ])),
     # Alternate p2m is not bound to any architecture or guest type, as it is
     # supported by x86 HVM and ARM support is planned.
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index e0a06ecfe3..7c5ee74443 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -23,6 +23,15 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
     if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed))
         config->arch.misc_flags |= XEN_X86_MSR_RELAXED;
 
+    if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV)
+    {
+        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic))
+            config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC;
+
+        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic))
+            config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC;
+    }
+
     return 0;
 }
 
@@ -819,11 +828,26 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
 {
 }
 
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info)
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo)
 {
     libxl_defbool_setdefault(&b_info->acpi, true);
     libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
+
+    if (b_info->type != LIBXL_DOMAIN_TYPE_PV) {
+        libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
+                                 physinfo->cap_assisted_xapic);
+        libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
+                                 physinfo->cap_assisted_x2apic);
+    }
+    else if (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) ||
+             !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)) {
+        LOG(ERROR, "Interrupt Controller Virtualization not supported for PV");
+        return ERROR_INVAL;
+    }
+
+    return 0;
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 712456e098..32f3028828 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -50,6 +50,8 @@ type x86_arch_emulation_flags =
 
 type x86_arch_misc_flags =
 	| X86_MSR_RELAXED
+	| X86_ASSISTED_XAPIC
+	| X86_ASSISTED_X2APIC
 
 type xen_x86_arch_domainconfig =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index b034434f68..d0fcbc8866 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -44,6 +44,8 @@ type x86_arch_emulation_flags =
 
 type x86_arch_misc_flags =
   | X86_MSR_RELAXED
+  | X86_ASSISTED_XAPIC
+  | X86_ASSISTED_X2APIC
 
 type xen_x86_arch_domainconfig = {
   emulation_flags: x86_arch_emulation_flags list;
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 7e9c32ad1b..2033d20eab 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -239,7 +239,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 
 		cfg.arch.misc_flags = ocaml_list_to_c_bitmap
 			/* ! x86_arch_misc_flags X86_ none */
-			/* ! XEN_X86_ XEN_X86_MSR_RELAXED all */
+			/* ! XEN_X86_ XEN_X86_MISC_FLAGS_MAX max */
 			(VAL_MISC_FLAGS);
 
 #undef VAL_MISC_FLAGS
diff --git a/tools/xl/xl.c b/tools/xl/xl.c
index 2d1ec18ea3..31eb223309 100644
--- a/tools/xl/xl.c
+++ b/tools/xl/xl.c
@@ -57,6 +57,8 @@ int max_grant_frames = -1;
 int max_maptrack_frames = -1;
 int max_grant_version = LIBXL_MAX_GRANT_DEFAULT;
 libxl_domid domid_policy = INVALID_DOMID;
+int assisted_xapic = -1;
+int assisted_x2apic = -1;
 
 xentoollog_level minmsglevel = minmsglevel_default;
 
@@ -201,6 +203,12 @@ static void parse_global_config(const char *configfile,
     if (!xlu_cfg_get_long (config, "claim_mode", &l, 0))
         claim_mode = l;
 
+    if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0))
+        assisted_xapic = l;
+
+    if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0))
+        assisted_x2apic = l;
+
     xlu_cfg_replace_string (config, "remus.default.netbufscript",
         &default_remus_netbufscript, 0);
     xlu_cfg_replace_string (config, "colo.default.proxyscript",
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index c5c4bedbdd..528deb3feb 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -286,6 +286,8 @@ extern libxl_bitmap global_vm_affinity_mask;
 extern libxl_bitmap global_hvm_affinity_mask;
 extern libxl_bitmap global_pv_affinity_mask;
 extern libxl_domid domid_policy;
+extern int assisted_xapic;
+extern int assisted_x2apic;
 
 enum output_format {
     OUTPUT_FORMAT_JSON,
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 117fcdcb2b..89448cca97 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2761,6 +2761,25 @@ skip_usbdev:
 
     xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
 
+    if (b_info->type != LIBXL_DOMAIN_TYPE_PV) {
+        e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0);
+        if (!e)
+            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l);
+        else if (e != ESRCH)
+            exit(1);
+        else if (assisted_xapic != -1) /* use global default if present */
+            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic);
+
+        e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0);
+        if (!e)
+            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l);
+        else if (e != ESRCH)
+            exit(1);
+        else if (assisted_x2apic != -1) /* use global default if present */
+            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic,
+                              assisted_x2apic);
+    }
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index a5048ed654..279936a016 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -50,6 +50,7 @@
 #include <asm/cpuidle.h>
 #include <asm/mpspec.h>
 #include <asm/ldt.h>
+#include <asm/hvm/domain.h>
 #include <asm/hvm/hvm.h>
 #include <asm/hvm/nestedhvm.h>
 #include <asm/hvm/support.h>
@@ -619,6 +620,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt;
+    bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
+    bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
     unsigned int max_vcpus;
 
     if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) )
@@ -685,13 +688,31 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         }
     }
 
-    if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
+    if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED |
+                                     XEN_X86_ASSISTED_XAPIC |
+                                     XEN_X86_ASSISTED_X2APIC) )
     {
         dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
                 config->arch.misc_flags);
         return -EINVAL;
     }
 
+    if ( (assisted_xapic || assisted_x2apic) && !hvm )
+    {
+        dprintk(XENLOG_INFO,
+                "Interrupt Controller Virtualization not supported for PV\n");
+        return -EINVAL;
+    }
+
+    if ( (assisted_xapic && !assisted_xapic_available) ||
+         (assisted_x2apic && !assisted_x2apic_available) )
+    {
+        dprintk(XENLOG_INFO,
+                "Hardware assisted x%sAPIC requested but not available\n",
+                assisted_xapic && !assisted_xapic_available ? "" : "2");
+        return -ENODEV;
+    }
+
     return 0;
 }
 
@@ -864,6 +885,12 @@ int arch_domain_create(struct domain *d,
 
     d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED;
 
+    d->arch.hvm.assisted_xapic =
+        config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
+
+    d->arch.hvm.assisted_x2apic =
+        config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
+
     return 0;
 
  fail:
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 53d97eaf13..da62e384d1 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1134,6 +1134,10 @@ static int construct_vmcs(struct vcpu *v)
         __vmwrite(PLE_WINDOW, ple_window);
     }
 
+    if ( !has_assisted_xapic(d) )
+        v->arch.hvm.vmx.secondary_exec_control &=
+            ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
+
     if ( cpu_has_vmx_secondary_exec_control )
         __vmwrite(SECONDARY_VM_EXEC_CONTROL,
                   v->arch.hvm.vmx.secondary_exec_control);
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index af9ee7cebb..9048688860 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3344,16 +3344,11 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
 
 void vmx_vlapic_msr_changed(struct vcpu *v)
 {
-    int virtualize_x2apic_mode;
     struct vlapic *vlapic = vcpu_vlapic(v);
     unsigned int msr;
 
-    virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
-                                cpu_has_vmx_virtual_intr_delivery) &&
-                               cpu_has_vmx_virtualize_x2apic_mode );
-
-    if ( !cpu_has_vmx_virtualize_apic_accesses &&
-         !virtualize_x2apic_mode )
+    if ( !has_assisted_xapic(v->domain) &&
+         !has_assisted_x2apic(v->domain) )
         return;
 
     vmx_vmcs_enter(v);
@@ -3363,7 +3358,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
     if ( !vlapic_hw_disabled(vlapic) &&
          (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) )
     {
-        if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) )
+        if ( has_assisted_x2apic(v->domain) && vlapic_x2apic_mode(vlapic) )
         {
             v->arch.hvm.vmx.secondary_exec_control |=
                 SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE;
@@ -3384,7 +3379,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
                 vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W);
             }
         }
-        else
+        else if ( has_assisted_xapic(v->domain) )
             v->arch.hvm.vmx.secondary_exec_control |=
                 SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
     }
diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h
index 698455444e..92bf53483c 100644
--- a/xen/arch/x86/include/asm/hvm/domain.h
+++ b/xen/arch/x86/include/asm/hvm/domain.h
@@ -117,6 +117,12 @@ struct hvm_domain {
 
     bool                   is_s3_suspended;
 
+    /* xAPIC hardware assisted virtualization. */
+    bool                   assisted_xapic;
+
+    /* x2APIC hardware assisted virtualization. */
+    bool                   assisted_x2apic;
+
     /* hypervisor intercepted msix table */
     struct list_head       msixtbl_list;
 
diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h
index e0d9348878..6ecbe22cc9 100644
--- a/xen/arch/x86/include/asm/hvm/hvm.h
+++ b/xen/arch/x86/include/asm/hvm/hvm.h
@@ -376,6 +376,9 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value);
 extern bool assisted_xapic_available;
 extern bool assisted_x2apic_available;
 
+#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic)
+#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic)
+
 #define hvm_get_guest_time(v) hvm_get_guest_time_fixed(v, 0)
 
 #define hvm_paging_enabled(v) \
@@ -878,6 +881,8 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
 #define assisted_xapic_available false
 #define assisted_x2apic_available false
 
+#define has_assisted_xapic(d) ((void)(d), false)
+#define has_assisted_x2apic(d) ((void)(d), false)
 #define hvm_paging_enabled(v) ((void)(v), false)
 #define hvm_wp_enabled(v) ((void)(v), false)
 #define hvm_pcid_enabled(v) ((void)(v), false)
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 8659547970..7233f43e3b 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -1119,7 +1119,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
         if ( !is_hvm_domain(d) || subleaf != 0 )
             break;
 
-        if ( cpu_has_vmx_apic_reg_virt )
+        if ( cpu_has_vmx_apic_reg_virt &&
+             has_assisted_xapic(d) )
             res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT;
 
         /*
@@ -1128,7 +1129,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
          * and wrmsr in the guest will run without VMEXITs (see
          * vmx_vlapic_msr_changed()).
          */
-        if ( cpu_has_vmx_virtualize_x2apic_mode &&
+        if ( has_assisted_x2apic(d) &&
              cpu_has_vmx_apic_reg_virt &&
              cpu_has_vmx_virtual_intr_delivery )
             res->a |= XEN_HVM_CPUID_X2APIC_VIRT;
diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
index 7acd94c8eb..58a1e87ee9 100644
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -317,9 +317,14 @@ struct xen_arch_domainconfig {
  * doesn't allow the guest to read or write to the underlying MSR.
  */
 #define XEN_X86_MSR_RELAXED (1u << 0)
+#define XEN_X86_ASSISTED_XAPIC (1u << 1)
+#define XEN_X86_ASSISTED_X2APIC (1u << 2)
     uint32_t misc_flags;
 };
 
+/* Max  XEN_X86_* constant. Used for ABI checking. */
+#define XEN_X86_MISC_FLAGS_MAX XEN_X86_ASSISTED_X2APIC
+
 /* Location of online VCPU bitmap. */
 #define XEN_ACPI_CPU_MAP             0xaf00
 #define XEN_ACPI_CPU_MAP_LEN         ((HVM_MAX_VCPUS + 7) / 8)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:47:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:47:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297324.506462 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEoj-0004my-3x; Fri, 01 Apr 2022 10:47:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297324.506462; Fri, 01 Apr 2022 10:47:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEoj-0004mp-0v; Fri, 01 Apr 2022 10:47:45 +0000
Received: by outflank-mailman (input) for mailman id 297324;
 Fri, 01 Apr 2022 10:47:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bus8=UL=citrix.com=prvs=083938fea=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1naEoh-0004So-U0
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:47:44 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 27b6b7d9-b1a9-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 12:47:41 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27b6b7d9-b1a9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648810061;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=IChIKw5+UvUtq6F65KbWI+j9iwzMDEBTBRwk/2T/D80=;
  b=ZCDT9+wAVH/Sb02kEuyu3WIXuTdF5BH3qXvbWK6frvIfb1JRhe6gZ/PA
   dyLdrDt+piJsQsXski4AeKw13Ni5dcfOUEwR+mKMRex88LAjGF2aznrCW
   2fQ7xBH5Uo1uAYwQeUeW+j8mvv94L15qprTuSQpDRaLEvmUzGn8uLw/Pr
   4=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67768407
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TWOPrK2SEIXJpngiKfbD5Upxkn2cJEfYwER7XKvMYLTBsI5bp2EBn
 zMWDTyCMv+Pajf9KNggOY6ypkgH6pXUztFiHgZrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIw2IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0OusOZdQ0HIZbthepDXiVFGgNxE6pZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHJNYUS/FRpyTjdBPAraZvCX7/L9ZlT2zJYasVmQ6mBO
 ZpFMWUHgBLoRhJOBksqGo8Cx/qhj1nRdSFIq2PLqv9ii4TU5FMoi+W8WDbPQfS0QsFSkledt
 3jx1W3zCREHN/SS0TOAtHmrg4fnhjjnUYgfELm58P9Cg1CJwGEXThoMWjOTq/SjllS3Xd4ZL
 kUO4zcvtoA77kntRd74NzW7rWCFuFgAWtNWO+w89AyJjKHT5m6xBHUCCDhIa9Uktco/bT0sy
 lKN2djuAFRHsrKPTmmG3qyJtj70Mi8QRUcSaClBQQYb7t3LpIAokgmJXttlCLSyjND+BXf32
 T/ihCo0iqgXjMUL/76m5l2BiDWpzrDLUwo06wP/Tm+jqARja+aNeIiA+VXdq/FaI+6kokKp5
 SZe3ZLEtaZXUM/LxHflrPgx8K+BpPnaGQHWr0FUPoQvqTmR5neBcq5X/2QrTKt2CfosdTjsa
 U7VnApe4p5PIXenBZNKj5KN59cClva5S4m8PhzARp8XO8UqKlfblM17TRTIt10BhnTAhk3W1
 X2zVc+3RUgXBq18pNZdb7dMiOR7rszSKI66eHwa8/hF+efGDJJ2Ye1cWLdrUgzfxPnbyOky2
 4wDX/ZmMz0FDIXDjtD/qOb/12wiI3khHozRoMdKbOOFKQcOMDh/V6+OnOl7I900wvk9egL0E
 peVABAwJL3X3yCvFOl3Qio7NOOHsWhX8xrXwhDAzX73giN+MO5DHY8UdoctfKlPyQCQ5aUcc
 hXxQO3ZWq4nYm2eo1w1NMChxKQ/JEXDrV/fZEKNPWlgF6OMsiSUo7cIiCO0r3JQZsd23ONjy
 4CdOvTzGsRbHV04XJeLMJpCDTqZ5BAgpQ67ZGOQSvE7Rakm2NECx/DZ5hPvH/wxFA==
IronPort-HdrOrdr: A9a23:0OC8AKMDfADZasBcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy
 nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ
 uIqpIOa+EY22IK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="67768407"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>
Subject: [PATCH v9 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
Date: Fri, 1 Apr 2022 11:47:12 +0100
Message-ID: <20220401104713.22291-2-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220401104713.22291-1-jane.malalane@citrix.com>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and
XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and
x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization
can subsequently be enabled on a per-domain basis.
No such features are currently implemented on AMD hardware.

HW assisted xAPIC virtualization will be reported if HW, at the
minimum, supports virtualize_apic_accesses as this feature alone means
that an access to the APIC page will cause an APIC-access VM exit. An
APIC-access VM exit provides a VMM with information about the access
causing the VM exit, unlike a regular EPT fault, thus simplifying some
internal handling.

HW assisted x2APIC virtualization will be reported if HW supports
virtualize_x2apic_mode and, at least, either apic_reg_virt or
virtual_intr_delivery. This also means that
sysctl follows the conditionals in vmx_vlapic_msr_changed().

For that purpose, also add an arch-specific "capabilities" parameter
to struct xen_sysctl_physinfo.

Note that this interface is intended to be compatible with AMD so that
AVIC support can be introduced in a future patch. Unlike Intel that
has multiple controls for APIC Virtualization, AMD has one global
'AVIC Enable' control bit, so fine-graining of APIC virtualization
control cannot be done on a common interface.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>

v9:
 * Move assisted_x{2}apic_available to vmx_vmcs_init() so they get
   declared at boot time, after vmx_secondary_exec_control is set

v8:
 * Improve commit message

v7:
 * Make sure assisted_x{2}apic_available evaluates to false, to ensure
   Xen builds, when !CONFIG_HVM
 * Fix coding style issues

v6:
 * Limit abi check to x86
 * Fix coding style issue

v5:
 * Have assisted_xapic_available solely depend on
   cpu_has_vmx_virtualize_apic_accesses and assisted_x2apic_available
   depend on cpu_has_vmx_virtualize_x2apic_mode and
   cpu_has_vmx_apic_reg_virt OR cpu_has_vmx_virtual_intr_delivery

v4:
 * Fallback to the original v2/v1 conditions for setting
   assisted_xapic_available and assisted_x2apic_available so that in
   the future APIC virtualization can be exposed on AMD hardware
   since fine-graining of "AVIC" is not supported, i.e., AMD solely
   uses "AVIC Enable". This also means that sysctl mimics what's
   exposed in CPUID

v3:
 * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
   set "arch_capbilities", via a call to c_bitmap_to_ocaml_list()
 * Have assisted_x2apic_available only depend on
   cpu_has_vmx_virtualize_x2apic_mode

v2:
 * Use one macro LIBXL_HAVE_PHYSINFO_ASSISTED_APIC instead of two
 * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
 * Set assisted_x{2}apic_available to be conditional upon "bsp" and
   annotate it with __ro_after_init
 * Change XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_X{2}APIC to
   _X86_ASSISTED_X{2}APIC
 * Keep XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X{2}APIC contained within
   sysctl.h
 * Fix padding introduced in struct xen_sysctl_physinfo and bump
   XEN_SYSCTL_INTERFACE_VERSION
---
 tools/golang/xenlight/helpers.gen.go |  4 ++++
 tools/golang/xenlight/types.gen.go   |  2 ++
 tools/include/libxl.h                |  7 +++++++
 tools/libs/light/libxl.c             |  3 +++
 tools/libs/light/libxl_arch.h        |  4 ++++
 tools/libs/light/libxl_arm.c         |  5 +++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/libs/light/libxl_x86.c         | 11 +++++++++++
 tools/ocaml/libs/xc/xenctrl.ml       |  5 +++++
 tools/ocaml/libs/xc/xenctrl.mli      |  5 +++++
 tools/ocaml/libs/xc/xenctrl_stubs.c  | 15 +++++++++++++--
 tools/xl/xl_info.c                   |  6 ++++--
 xen/arch/x86/hvm/hvm.c               |  3 +++
 xen/arch/x86/hvm/vmx/vmcs.c          |  6 ++++++
 xen/arch/x86/include/asm/hvm/hvm.h   |  5 +++++
 xen/arch/x86/sysctl.c                |  4 ++++
 xen/include/public/sysctl.h          | 11 ++++++++++-
 17 files changed, 93 insertions(+), 5 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index b746ff1081..dd4e6c9f14 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3373,6 +3373,8 @@ x.CapVmtrace = bool(xc.cap_vmtrace)
 x.CapVpmu = bool(xc.cap_vpmu)
 x.CapGnttabV1 = bool(xc.cap_gnttab_v1)
 x.CapGnttabV2 = bool(xc.cap_gnttab_v2)
+x.CapAssistedXapic = bool(xc.cap_assisted_xapic)
+x.CapAssistedX2Apic = bool(xc.cap_assisted_x2apic)
 
  return nil}
 
@@ -3407,6 +3409,8 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace)
 xc.cap_vpmu = C.bool(x.CapVpmu)
 xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1)
 xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2)
+xc.cap_assisted_xapic = C.bool(x.CapAssistedXapic)
+xc.cap_assisted_x2apic = C.bool(x.CapAssistedX2Apic)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index b1e84d5258..87be46c745 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -1014,6 +1014,8 @@ CapVmtrace bool
 CapVpmu bool
 CapGnttabV1 bool
 CapGnttabV2 bool
+CapAssistedXapic bool
+CapAssistedX2Apic bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 51a9b6cfac..94e6355822 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -528,6 +528,13 @@
 #define LIBXL_HAVE_MAX_GRANT_VERSION 1
 
 /*
+ * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has
+ * cap_assisted_xapic and cap_assisted_x2apic fields, which indicates
+ * the availability of x{2}APIC hardware assisted virtualization.
+ */
+#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index a0bf7d186f..6d699951e2 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -15,6 +15,7 @@
 #include "libxl_osdeps.h"
 
 #include "libxl_internal.h"
+#include "libxl_arch.h"
 
 int libxl_ctx_alloc(libxl_ctx **pctx, int version,
                     unsigned flags, xentoollog_logger * lg)
@@ -410,6 +411,8 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
     physinfo->cap_gnttab_v2 =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2);
 
+    libxl__arch_get_physinfo(physinfo, &xcphysinfo);
+
     GC_FREE;
     return 0;
 }
diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 1522ecb97f..207ceac6a1 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -86,6 +86,10 @@ int libxl__arch_extra_memory(libxl__gc *gc,
                              uint64_t *out);
 
 _hidden
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo);
+
+_hidden
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src);
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index eef1de0939..39fdca1b49 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1431,6 +1431,11 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
     return rc;
 }
 
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo)
+{
+}
+
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src)
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 2a42da2f7d..42ac6c357b 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1068,6 +1068,8 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_vpmu", bool),
     ("cap_gnttab_v1", bool),
     ("cap_gnttab_v2", bool),
+    ("cap_assisted_xapic", bool),
+    ("cap_assisted_x2apic", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index 1feadebb18..e0a06ecfe3 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
     return rc;
 }
 
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo)
+{
+    physinfo->cap_assisted_xapic =
+        !!(xcphysinfo->arch_capabilities &
+           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC);
+    physinfo->cap_assisted_x2apic =
+        !!(xcphysinfo->arch_capabilities &
+           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC);
+}
+
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src)
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7503031d8f..712456e098 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -127,6 +127,10 @@ type physinfo_cap_flag =
 	| CAP_Gnttab_v1
 	| CAP_Gnttab_v2
 
+type physinfo_arch_cap_flag =
+	| CAP_X86_ASSISTED_XAPIC
+	| CAP_X86_ASSISTED_X2APIC
+
 type physinfo =
 {
 	threads_per_core : int;
@@ -140,6 +144,7 @@ type physinfo =
 	(* XXX hw_cap *)
 	capabilities     : physinfo_cap_flag list;
 	max_nr_cpus      : int;
+	arch_capabilities : physinfo_arch_cap_flag list;
 }
 
 type version =
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index d1d9c9247a..b034434f68 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -112,6 +112,10 @@ type physinfo_cap_flag =
   | CAP_Gnttab_v1
   | CAP_Gnttab_v2
 
+type physinfo_arch_cap_flag =
+  | CAP_X86_ASSISTED_XAPIC
+  | CAP_X86_ASSISTED_X2APIC
+
 type physinfo = {
   threads_per_core : int;
   cores_per_socket : int;
@@ -123,6 +127,7 @@ type physinfo = {
   scrub_pages      : nativeint;
   capabilities     : physinfo_cap_flag list;
   max_nr_cpus      : int; (** compile-time max possible number of nr_cpus *)
+  arch_capabilities : physinfo_arch_cap_flag list;
 }
 type version = { major : int; minor : int; extra : string; }
 type compile_info = {
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 5b4fe72c8d..7e9c32ad1b 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -712,7 +712,7 @@ CAMLprim value stub_xc_send_debug_keys(value xch, value keys)
 CAMLprim value stub_xc_physinfo(value xch)
 {
 	CAMLparam1(xch);
-	CAMLlocal2(physinfo, cap_list);
+	CAMLlocal3(physinfo, cap_list, arch_cap_list);
 	xc_physinfo_t c_physinfo;
 	int r;
 
@@ -731,7 +731,7 @@ CAMLprim value stub_xc_physinfo(value xch)
 		/* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_MAX max */
 		(c_physinfo.capabilities);
 
-	physinfo = caml_alloc_tuple(10);
+	physinfo = caml_alloc_tuple(11);
 	Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core));
 	Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket));
 	Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus));
@@ -743,6 +743,17 @@ CAMLprim value stub_xc_physinfo(value xch)
 	Store_field(physinfo, 8, cap_list);
 	Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1));
 
+#if defined(__i386__) || defined(__x86_64__)
+	/*
+	 * arch_capabilities: physinfo_arch_cap_flag list;
+	 */
+	arch_cap_list = c_bitmap_to_ocaml_list
+		/* ! physinfo_arch_cap_flag CAP_ none */
+		/* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_X86_MAX max */
+		(c_physinfo.arch_capabilities);
+	Store_field(physinfo, 10, arch_cap_list);
+#endif
+
 	CAMLreturn(physinfo);
 }
 
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 712b7638b0..3205270754 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -221,7 +221,9 @@ static void output_physinfo(void)
          info.cap_vmtrace ? " vmtrace" : "",
          info.cap_vpmu ? " vpmu" : "",
          info.cap_gnttab_v1 ? " gnttab-v1" : "",
-         info.cap_gnttab_v2 ? " gnttab-v2" : ""
+         info.cap_gnttab_v2 ? " gnttab-v2" : "",
+         info.cap_assisted_xapic ? " assisted_xapic" : "",
+         info.cap_assisted_x2apic ? " assisted_x2apic" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 709a4191ef..e5dde9f8ce 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -117,6 +117,9 @@ static const char __initconst warning_hvm_fep[] =
 static bool_t __initdata opt_altp2m_enabled = 0;
 boolean_param("altp2m", opt_altp2m_enabled);
 
+bool __ro_after_init assisted_xapic_available;
+bool __ro_after_init assisted_x2apic_available;
+
 static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 56fed2db03..53d97eaf13 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -2145,6 +2145,12 @@ int __init vmx_vmcs_init(void)
 
     ret = _vmx_cpu_up(true);
 
+    /* Check whether hardware supports accelerated xapic and x2apic. */
+    assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
+    assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode &&
+                                (cpu_has_vmx_apic_reg_virt ||
+                                 cpu_has_vmx_virtual_intr_delivery);
+
     if ( !ret )
         register_keyhandler('v', vmcs_dump, "dump VT-x VMCSs", 1);
 
diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h
index 5b7ec0cf69..e0d9348878 100644
--- a/xen/arch/x86/include/asm/hvm/hvm.h
+++ b/xen/arch/x86/include/asm/hvm/hvm.h
@@ -373,6 +373,9 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value);
 #define hvm_tsc_scaling_ratio(d) \
     ((d)->arch.hvm.tsc_scaling_ratio)
 
+extern bool assisted_xapic_available;
+extern bool assisted_x2apic_available;
+
 #define hvm_get_guest_time(v) hvm_get_guest_time_fixed(v, 0)
 
 #define hvm_paging_enabled(v) \
@@ -872,6 +875,8 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
 #define hvm_tsc_scaling_supported false
 #define hap_has_1gb false
 #define hap_has_2mb false
+#define assisted_xapic_available false
+#define assisted_x2apic_available false
 
 #define hvm_paging_enabled(v) ((void)(v), false)
 #define hvm_wp_enabled(v) ((void)(v), false)
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index f82abc2488..716525f72f 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -135,6 +135,10 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap;
     if ( IS_ENABLED(CONFIG_SHADOW_PAGING) )
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow;
+    if ( assisted_xapic_available )
+        pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC;
+    if ( assisted_x2apic_available )
+        pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC;
 }
 
 long arch_do_sysctl(
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index b0a4af8789..7f521b3beb 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -35,7 +35,7 @@
 #include "domctl.h"
 #include "physdev.h"
 
-#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014
+#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * Read console content from Xen buffer ring.
@@ -111,6 +111,13 @@ struct xen_sysctl_tbuf_op {
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
 #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2
 
+/* The platform supports x{2}apic hardware assisted emulation. */
+#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC  (1u << 0)
+#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC (1u << 1)
+
+/* Max XEN_SYSCTL_PHYSCAP_X86__* constant. Used for ABI checking. */
+#define XEN_SYSCTL_PHYSCAP_X86_MAX XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC
+
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
     uint32_t cores_per_socket;
@@ -120,6 +127,8 @@ struct xen_sysctl_physinfo {
     uint32_t max_node_id; /* Largest possible node ID on this host */
     uint32_t cpu_khz;
     uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */
+    uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_{X86,ARM,...}_??? */
+    uint32_t pad;
     uint64_aligned_t total_pages;
     uint64_aligned_t free_pages;
     uint64_aligned_t scrub_pages;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 10:49:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 10:49:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297334.506473 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEpv-00063E-Hk; Fri, 01 Apr 2022 10:48:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297334.506473; Fri, 01 Apr 2022 10:48:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naEpv-000637-ES; Fri, 01 Apr 2022 10:48:59 +0000
Received: by outflank-mailman (input) for mailman id 297334;
 Fri, 01 Apr 2022 10:48:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JkNZ=UL=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1naEpt-00062j-R3
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 10:48:57 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2062b.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::62b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54648ea8-b1a9-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 12:48:56 +0200 (CEST)
Received: from AS9PR06CA0149.eurprd06.prod.outlook.com (2603:10a6:20b:467::31)
 by AM0PR08MB4241.eurprd08.prod.outlook.com (2603:10a6:208:140::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19; Fri, 1 Apr
 2022 10:48:49 +0000
Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:467:cafe::6a) by AS9PR06CA0149.outlook.office365.com
 (2603:10a6:20b:467::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.26 via Frontend
 Transport; Fri, 1 Apr 2022 10:48:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Fri, 1 Apr 2022 10:48:49 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Fri, 01 Apr 2022 10:48:49 +0000
Received: from fe45112dfa0e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AED46784-3976-4A29-AE50-AB64376804F7.1; 
 Fri, 01 Apr 2022 10:48:42 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fe45112dfa0e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Apr 2022 10:48:42 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by VI1PR0802MB2463.eurprd08.prod.outlook.com (2603:10a6:800:bb::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Fri, 1 Apr
 2022 10:48:40 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310%7]) with mapi id 15.20.5123.021; Fri, 1 Apr 2022
 10:48:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54648ea8-b1a9-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nEKykf52DuEtf1a1mew0plP3vJPU1E8gyopbvTGoZGk=;
 b=udlT5s7Jur0o5KWOyqvfT0OFUS09fSrmlfzR5s2Yf2h4Acqga69j/VfX3lQN5hhCE00UWz0aFyNx+cfQq5IkGr/64HDjWm8NrHG4WSkVPOlEcVOP+STqpM8DtSz/ZbqHKTvMOdauWX4cfbzYo0amqCWiit/Az5j8L2dIPBT9HNU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 01a669ab249d34bd
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i1RMgAfn7FM7pznBpDiwAhzxaEb1JfLAvMggA75zSExEeSCQPspmAz3K1eb+4aHGnhjETLTnc+HsbLHzNCXoz3wIfRgy2OMSDlk0z4v4oXhyC3U8qjTZchXyLZSA8AmMJoymfgS/PJouu1lawU72xADmW7Cvnh7xHgVEgpYUEKcrAGgE7ldyv6rDsFv7Dimb4wOIHiJK66gk80olxfdWpvJqUmiclrWfsZ6cjBJc7v5GAJsdsFB4ZgkSRDBnmm5Dk2RG4n0yl1dEApWpu/EErsIuOgSnj11waDVcS4p7L5LNJ9OCmsFSS9R6XzF8QljZNO7PsB4Dflqgsfn294JePw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nEKykf52DuEtf1a1mew0plP3vJPU1E8gyopbvTGoZGk=;
 b=G9cfuZm7zcnofEC4IdWwXDiWWNsEtq0AG3hWf3k3sBQqeRHcyY5ElsaUBb+BSN7W0xWxdrkyEkP8Uz0nuKGFcUqsrpSjoNlhpTc3eWHKa+GELIGefQHgmzlZ7SHDhN2kLWnrG3ocS7f0v7qOwzkIpHAWE09lVgCnqO75/Bc9Ia/n4GQPJ0WqfbQL5E9XVZjqAqhhk8drGRv9fwAyfpyd5cyBkixGkA/ThyUsceeLGFZapE5eatw7zgdotAceQ9xzdzkd03q6mc0wCX/4REAyXg6TqNAaCPmv/Ze8vuC4fZH/AqbyooldpFiDW0TsbIsZV+k0aad/H+ms5CQx05FzOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nEKykf52DuEtf1a1mew0plP3vJPU1E8gyopbvTGoZGk=;
 b=udlT5s7Jur0o5KWOyqvfT0OFUS09fSrmlfzR5s2Yf2h4Acqga69j/VfX3lQN5hhCE00UWz0aFyNx+cfQq5IkGr/64HDjWm8NrHG4WSkVPOlEcVOP+STqpM8DtSz/ZbqHKTvMOdauWX4cfbzYo0amqCWiit/Az5j8L2dIPBT9HNU=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Juergen Gross
	<jgross@suse.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, Stefano Stabellini
	<stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v4 9/9] docs: document dom0less + PV drivers
Thread-Topic: [PATCH v4 9/9] docs: document dom0less + PV drivers
Thread-Index: AQHYRWD5icllAQcba0eQJpqKG1AfDqza4VQA
Date: Fri, 1 Apr 2022 10:48:38 +0000
Message-ID: <E19EE48D-4B06-4D02-9DF1-21830FA56AB1@arm.com>
References:
 <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-9-sstabellini@kernel.org>
In-Reply-To: <20220401003847.38393-9-sstabellini@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: a92cf5cb-6a36-4532-f8df-08da13cd3452
x-ms-traffictypediagnostic:
	VI1PR0802MB2463:EE_|AM5EUR03FT024:EE_|AM0PR08MB4241:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB424168573000606CE52A526CE4E09@AM0PR08MB4241.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Rb9GBvRYV2/PqDY+TculpqR+Gd9Zj8oZq5uBJjsivHgm2dpCQMR1BM0t+zQocvQclOUtI1q6p5oPfUoFMJECmYy/lsMAg6a6euBXsH9y8YL2K542hoEDZY0xnPBC8qfDV1VQ3FJ+whK8oaqmUx1wguyUVx1ywGm9ZobEkM9b5HydYglv9QU4huDCKapvU77hI1ERNmk1jnnWGQ8jfCDYx40dvdPjeEUdhe8Js39YCL8JfpuBBnRP07sXbFC6s6C7qsNC7W5r0B/pCT3S6lyidCL4JXglE5YYW6P8s00Hnv5beBsvHjF9Yt9QkyQBAyKdz2rT/wLJivHOI1ZivFhUt23P4H6esxcZ1i79ikW/B/2CmV+SVpmR2xZOn8c8hQ/VCLnH2ULFX5ftxwc+YBD9NulLhUCpRvZ5ZoUvywh/skAyldiLn/Jx8bwpSitSuQYcnGLCsYmvsk0nsWjjDbO9rryrcn9rDdw5GVXmpMuio0Ac0aEp3RNIcrbahip/JMBmig+mgNWuIRezaILcZ0TBco/mMaHPS74HQwP1oo+QrQIFc9BNvLSnQk+85aMsaIfgt7ta0ZjFd+qdVLOKeIXDGHYkh/kqoVTfpEkcKfF16IgsFSaFad+xEUfPASEN5GCqN8OZGjmDXety6HOAelQ3N+JpvrJ3Hu6U9Ug24OlS3YkKMre4y13pmaCo7WYOApy4zpDQ5y26R7k3RsMj2bx8C4jFxk3jQdJGkvV6MACRamorgnn5p5PHys4FGqcl9QcJfMaIckNEfXnhbVtBN48Olw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(2616005)(558084003)(38070700005)(186003)(2906002)(26005)(36756003)(122000001)(76116006)(6486002)(71200400001)(8936002)(86362001)(508600001)(5660300002)(8676002)(4326008)(38100700002)(91956017)(64756008)(6512007)(54906003)(33656002)(66476007)(66446008)(66556008)(6916009)(66946007)(53546011)(6506007)(32563001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7D7B7919B2B885409C48ECF339ADE65B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2463
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	dcc138e2-6b48-4dfb-3816-08da13cd2ea4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	V884ht4JSFf3xjSvMMd0HhseL6nSeIM6/txyze9C2gdsxRREaTWv6OQZDeCa++rxzbGRLL+rUeuxPUw1P+u5SAspARjpljHw1LchmDXqB4tjZ+10wSMaxqm5YrVAknVfFvdMJ8czOweIXTJE/VEN4dZ4ARk13QCgCsgZF72mn9QFe/tZskQsC0CsbrByleDC6QWAkS5SeGZJ9+4UVRFODykuoe6tfGMxSxZCXkRmsvwQX6Z0Sz+g8aZP1p0wazh93ieei/sM/hPqR3+gHPjaRV/3k3IvK28ls+wfMweWkQT2n00/kw1fsyYJDubGbQwtpxGQFyFrMbTBt6k8LcEaRt32qFzxGFjMAYkumtBXRcPm/dbR0iYI9xfFKScUce09HxAHI6DoCnl7jqS/+sCXaVJ7AKPKfWgKXiIP04SyX/n0SqRmbj6ui3NZW/31DGYZMBsl7ek1dCw0GPrg/dafI/eO0TBUiFdrpS2wiEgTnk5OkgXRx17TkcBPtfml9CAAOQb3N2ecqnSd730XZ4ttpxJwjY1BVS9zSCVCld4MLbP6L1iIquOQRRtvc2KnDrqgDPqtlJ/Ic7Gu8Syr0KxsmvVx0Ld4P66aNgzo/0QnbbyH+7W/kzVLKMYcM/bfF8mr46zfvNoat3ZvPmkLEJoU1fVn/gywT+Gzg7L4w4XpkX+365Y6AM/1p7XH2IbNho4x+v2GzhvHljpfkKxHMoM5sA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(26005)(54906003)(82310400004)(186003)(47076005)(6486002)(336012)(86362001)(6512007)(508600001)(107886003)(36860700001)(2616005)(81166007)(6506007)(40460700003)(4744005)(2906002)(36756003)(8676002)(316002)(70586007)(70206006)(6862004)(356005)(8936002)(5660300002)(53546011)(4326008)(33656002)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 10:48:49.2797
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a92cf5cb-6a36-4532-f8df-08da13cd3452
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4241



> On 1 Apr 2022, at 01:38, Stefano Stabellini <sstabellini@kernel.org> wrot=
e:
>=20
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>=20
> Document how to use the feature and how the implementation works.
>=20
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

Hi Stefano,

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 11:00:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 11:00:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297345.506484 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naF1L-0008Tm-Or; Fri, 01 Apr 2022 11:00:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297345.506484; Fri, 01 Apr 2022 11:00:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naF1L-0008Tf-Kg; Fri, 01 Apr 2022 11:00:47 +0000
Received: by outflank-mailman (input) for mailman id 297345;
 Fri, 01 Apr 2022 11:00:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MEhg=UL=citrix.com=prvs=083735472=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1naF1K-0008TZ-CP
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 11:00:46 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f9a1b6c1-b1aa-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 13:00:45 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9a1b6c1-b1aa-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648810844;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=K2dHehM+mmudg9X1jVQaerKfG4ugYkuraJrczdBcMA4=;
  b=ZHEBzw2rzsH7Ck8XktVCGXHkq8NAmEOnluRDjXqHfJdXIvR4jS+2sBRL
   nIr22LkxmAFuQGwEEd4JepWZgkCqAD9eiMTirolpdLUcxRXEdiJuiZHbk
   Raj2D4igCLKqo/BGgZvIEpNyCrPwRPOwYp2UsZC2zx6bKUiozjkkbeljl
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67187957
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hbwMHKz2GZ0A1K9s52F6t+e0xirEfRIJ4+MujC+fZmQN5Y8a5oE1v
 iFGDjfXfrrIN3ykOIpG3L7G8xgOuMPQx9MyTFBrpXtgESwb8sDODISTIkmhM3zOfpXIERhtt
 5RGZInJdJpsQy6Grx71PuO78SkjjvGGGLb2WIYoVswJqSpMEU/N3jo/y75RbvdUvOWE7yOxV
 fLaqsSBYQL70DMob2hIs//f8kJht/mpsmITtAVnPqgWtgePy3VNAJwhfqzgdHGQrqu4vwKZq
 0Qv6Jnjows1Kj90UovNfo7TKxFMGviIVeS3oiI+t5KK23CunQRvlPdjXBYgQR0P0W/Rw4gok
 I8lWaGYEm/FAIWdwIzxbDEAe81OFfUuFGjveCXXXWS7liUqQlO0qxlcJBhe0b4wo46bNVpm5
 /0AQA3hWzjY7w6ALBBXfcE37igrBJGD0IryIRiMxxmBZRotacirr6kneba0ddr/7yxDNa+2W
 iYXVdZgREXYexRRZUUsMc4nkeC5qGnOQ2FE713A8MLb40CLpOBw+L3kMd6Tcd2WX8RF2E2fo
 woq/UygXEtcbobGj2PYrDT83YcjnguiMG4WPJK18eRljRu/22oXAQU+Xlqnu/ipzEW5XrqzL
 mRKpXN+8vlvqyRHSPHvQEK8hHG/7icCdPZAPNQ24zCQ4fbbtlPx6m8sEWcaNY1OWNUNbSMu/
 k+EmZXuHzMHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXrnbPxuDaq0hd3dAizrz
 naBqy1WulkIpZdVjePhpwmB2m/y4MiSJuIo2unJdjO99gpnO5yeXtCx5F/Kw+ZxHNqFCVbU6
 RDohPOixOwJCJiMkgmET+MMAKyl6p65DdHMvbJ8N8J/rmrwohZPaagVuWgjfxkxbq7obBezO
 CfuVRVtCIi/1ZdARYt+eMqPBssj1sAM/vy1B6mPPrKijnWcHTJrHR2Ch2bNhwgBc2B2yMnT3
 Kt3l+72Uh727ow9kFKLqx81i+ND+8zH7Tq7qWrH5xqmy6GCQ3WeVK0INlCDBshgsv/U/1iPq
 Y4OZpbXo/m6bAEYSnOImWL0BQpXRUXX+Lis85AHHgJ9ClQO9J4d5w/5nup6Jt0Nc1V9nebU5
 HCtMnK0O3Kk7UAr3T6iMyg5AJu2BM4XhStiYUQEYAb5s1B+MN3HxPpOKPMKkUwPqbULIQhcF
 KJeJa1tw51nF1z6xtjqRcKj9NY7LkT62Frm0ujMSGFXQqOMjjfhp7fMVgDu6DMPHmyws84/q
 KenzQTVXdwIQAEKMSocQKnHI4+Z1ZTFpN9PYg==
IronPort-HdrOrdr: A9a23:Q3TEgau6fYNZjp9xtdvR4Mna7skCx4Mji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKdkrNhQYtKPTOW9FdASbsN0WKM+UyYJ8STzJ8/6U
 4kSdkFNDSSNyk0sS+Z2njBLz9I+rDum8rI5ds2jU0dNj2CA5sQtjuRYTzrdnGeMTM2Y6bRY6
 DsgfavyQDQG0g/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZRbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESstu/oXvUgZ1SxhkF2nAid0idurD
 AKmWZlAy1H0QKTQohym2qr5+Cv6kdp15ao8y7mvZKqm72GeNt9MbsYuWsRSGqo12Mw+N57y6
 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtorQaC50YvILf2RYUh5LD3xnklWKvo3RiKnLwPAa
 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJgncw1YgahDMN5Zg9Q55L66
 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cU7lutry+vE49euqcJsHwN87n4
 nASkpRsSood0fnGaS1ret2G9D2MRKAtBjWu7NjDsJCy87BrZLQQFi+dGw=
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="asc'?scan'208";a="67187957"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bf0fYw0VmFMTcKuUVnsMAeqL8HaB7M5NEP93JsKjxPljjtlSypX4LY/Hhbf1llsZeBfNsEgf6sAdDYeBX1c06EuOFyiMMT3bomXQ1++isu9JtG3wNlmb5qEN2EIhGPXdK8w6UTrHe1vJBMb+qpwlH7z/46ohvc2MsTGlpQTWKxyTOG/88Qt3RM3Je7M/LvKnlj0It+SVpVDSJxlDHNVJSdUNSokzY3Q0GFJM7hMd9d7nUPMttdSSiVagH3xZe6cd5XKak4/nVaOQwlLXVJ2AQ7FTnXLZS58B+wZVBiA8KvzKyCyw5Zuke5fJ8DOhlXo3Z0SKa5Cidr5bRvI997SMWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aVJlM6fXTWeXWUBXPgphm1y0ebSCxROLX5NLOpoXj9c=;
 b=RLM/cnBiOAAd0IKnQuG+ayWPTTqMXp3S9GiHyLPH74fOfmPMN9RB9RZwU6uOda91HeMgbgVsBurRTEMykPTiHbwwCkaNBhVrpih91qq9DVw6D0HR/btlUwtlMTWghYZFzg/hZG4yjnO7FUPcIs0KCin1YTT0hm0KEq+eJnRDSxVSFLJHq2xXxnHTeVs68e1qs1IhgSw8LXT3X0gNu9R2PhhehlnV0CgBblIBqsF5YD1lzuE87VliaYMaW+XefcTjFNQeB12xekhcYtMpbotzqD1ocAF/fVpfNojOCqvR5oRi1JPavG/PsNHfESmV2C1TDnRKLQOEuAHaA4H0DULpLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aVJlM6fXTWeXWUBXPgphm1y0ebSCxROLX5NLOpoXj9c=;
 b=i0LjNn7MQ9y9by6nCDyKF4qeEbUVNjzRtWQ65PDteTSzI1gd7V6vsS2sgEGsmFpmNf2qSv+/VWwgfnBcwdkDBn2q6NFEEUz/y8CXuZMIfxDK/vjUwVnn6NPXW2fNM0st1i0VGuFzh/vjDceX8PfYUMV0zRjCqSjqkU0+sO++cKo=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH v2 01/14] x86/P2M: rename p2m_remove_page()
Thread-Topic: [PATCH v2 01/14] x86/P2M: rename p2m_remove_page()
Thread-Index: AQHYKM46s9y6ZLRfQke/hWwPeChWGazbHb4A
Date: Fri, 1 Apr 2022 11:00:38 +0000
Message-ID: <04A30A31-2B46-4B34-A4F1-21A20DB8E7D6@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <2353ed37-e62a-4e34-7442-0638bb92dc2c@suse.com>
In-Reply-To: <2353ed37-e62a-4e34-7442-0638bb92dc2c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8438448c-41a1-4a74-bf79-08da13cedb53
x-ms-traffictypediagnostic: MWHPR03MB3085:EE_
x-microsoft-antispam-prvs: <MWHPR03MB3085C4EB803938BD020B375199E09@MWHPR03MB3085.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: XJcwmJNS5nCNNGxMS2PwpgSnKhplkEoPtxzzfLfQQA0gIWDcGzR0BvE131iOqAaTG3xpl7Wi6ep4YnyZ+Umt3TLcNwq5gYvq0L1AVRx0L+vrmfNDeS7RPeNzaRIROBpCl/GIidqPD3Zl6QC/fAxk4PvBZe09X4ouSBEhA4J9hL0lkF+URKaNyp2ihSq1aeNn000dPsFV038GBpR5PV3oMWaIWq2rDN63tSccgP3H9zraiAQWEjPxIMr6C46AeWxoZyHzX42caD5/dSRekdCLR7CJPdfa4Pk+NQo24US2EQbhUCGcGU1p7DwIQv+6AzO9JQ0VVfewV3ZDjM9kBy3LAllBMZFBmzL2THkN1zyP2zYdV0hKbNeH2AP2iFA/e1/FiTMAcaB7rttU8fdws//ueBT8+CpMv5lfXhfoCBac7ri75OHH5IZgMtIa/9u85pEAsMi7VvOK3p0Vtdc7qEACtRMGxMz/fdirmiF+8wPVpal3rcF9JB25RETD8Smo4RqWdPgCdcbPZwZXq4D+Dc20JadWOaAFkSlZ+vRNsd1qVzKfBgrsp14lm4sDJ7Ct4xoikZ3amffhS6bRUVf1hDLTWuv3l2zgEKNqHhohNK75460WUlNy9UV0xirthHKezHiBoJzYXuBQxzdjjKweOEWPQeeCYwoOyeDZGMV4+ox337BLPtocJjeCSqEqqGzccveoZ0VGt06XvIrghd6H3skdEMX9k6WMlOuCBA4pFdVQ2qwS0sOPerploVP6hHa+jR8l
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66476007)(66446008)(91956017)(4326008)(38070700005)(6486002)(6916009)(8676002)(66556008)(76116006)(54906003)(64756008)(122000001)(82960400001)(33656002)(38100700002)(36756003)(71200400001)(316002)(99936003)(2616005)(107886003)(53546011)(8936002)(5660300002)(186003)(508600001)(6506007)(558084003)(26005)(2906002)(6512007)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ckKJQ7Ul16XtAcaz47J/tPJl6xVeZi5ZJcme3uSskH0IwjdJ2FFgs4dj3onl?=
 =?us-ascii?Q?mLpsiQ2lb9Tez8F5BHSyNgXmxWY9BRTlzMuX/mQbkOqYCzC1rhNfRQGuPOr0?=
 =?us-ascii?Q?A3PneSaBiJL1NNrSTruWGH+YyOkll3UV65uPF4vL71ZV0kGtNLSWckNowvbk?=
 =?us-ascii?Q?2uYxKwjH3M6vecsag7D7kYFNQwARQUkh29ccwZHlo/mLcMhR+A6QpjyYBkRP?=
 =?us-ascii?Q?dvLxy3I4rhzN4f+aUFmcNCuL59veAJ3LZReAPAr492auGeHeGEp+GB3B+DKM?=
 =?us-ascii?Q?2W1zjTcIxWQdy/xN8VXFed5GHbyl+GlDvhm/ZpoDc9zN6Tzd4NMkS2IsYT58?=
 =?us-ascii?Q?L9WInsFGr+A5Zy8oKcB1rxfriGjqYhcsoxZM1/OinT14NPuumVXCRFOJGMCX?=
 =?us-ascii?Q?/SYWNGjxy/fiszEWStqws8lw6ca8SV5Ae68HWQmDFDLR8M6Fzlgn6iKpRDqT?=
 =?us-ascii?Q?qvGj0rX4gUnQqD4WWdX7QnGLlRvh6Au2Rf6F7BhQuvHD1LKRzXhq+lrfOLv7?=
 =?us-ascii?Q?LJ92heJHNGQ5D87Q1Txa12Z/48r2mECufKcAHz/Exiq6f/4vxTxr4rQpoDQD?=
 =?us-ascii?Q?QId3YagyoKNxo3agsU/F1hKc6bDirRgwUd+/3dN+m/fV1eASASwo+ayH7h4N?=
 =?us-ascii?Q?UFP6iXd5yD3f8Fv333gdlQpO4jYaQ6bpA6lpsyjKlqeSoUhaDvPIijq8al66?=
 =?us-ascii?Q?4j4oNhlOuGPIMf618wTPqDyurWAfJKdkUHXMLs6ycrspyoJAZjoq3gtZZQVa?=
 =?us-ascii?Q?doFQKrWzpzVNlHiJHQSvP228s18J8NoAQ4JF3NcW+9qZaA8H4fzKrVprMgyM?=
 =?us-ascii?Q?Eukrp6hivTlSo/wOY/riRwYrFKHpIxFC6c2xcsWzLlsb3/OR5vM8rL1cCopJ?=
 =?us-ascii?Q?Kl1iAM1NfwncpKCP+6/5oFrjsoLc/hzASCQEFeUTSzAdfAnSNCPjc9q+w+al?=
 =?us-ascii?Q?hHkupnjP5A/mTixvf8k0Yoe0q3755KGLuD41Aw5hngYFuh4Yqf9jSaHgKLlD?=
 =?us-ascii?Q?O5hlhKPNR4DCMqdoCsz5sFxtISPq0utyOBuqXocgHr52/9Lfze2butrWD7Hh?=
 =?us-ascii?Q?GhjR0vPPm/ImBh4ch3C7dTiHO/RG5wZRn3aRNWaV6d6dAtDDn7mieHKDPzGG?=
 =?us-ascii?Q?uY/ax8/jXddbgT1AHA225ySZnO495mT+Ym3jvie04tPI+LwWyQuEVd0BUBop?=
 =?us-ascii?Q?COLxuk0TdgxkHHvDdI7GhmMAtmBRHwRa1E7X5I09O2UiaDiIhLA5JonHkhFR?=
 =?us-ascii?Q?Tpspy1PmBsOHET2fWCCOOQSitquKAZKhmX81GIeb3etkwHsS1RjoGO5XS9nG?=
 =?us-ascii?Q?Z1U6D2fUgDK5WeRvOZKR9JGG2H/gaz7W6VHkYno76AnuN83m9f+Hk4mIXxNv?=
 =?us-ascii?Q?4LYZbPVs9efC4LgTEKW/mPTZMtud6gOYB+nTFy4v5OPnfMeLyP/Y6WQ9YwyB?=
 =?us-ascii?Q?OUUPrE2c/kvbssV8BgSQuexSE7UCUZuv7zdOgsVj2QLfBoEmpZ/ApcPIZtTk?=
 =?us-ascii?Q?6r3evzYdBK8gvHEH4YFszAQe1ItF8Ez/OR5PgkqaBosXOlb1tfWkUFEy3Zc9?=
 =?us-ascii?Q?O9Bylwvvf9OiZcdVIJUCugsBvAkpcSzqZ7l/iVp988LcCnnYLtvxcBpCAH2P?=
 =?us-ascii?Q?KglkHSGJSuvUf1rWRyWRwoz/cvUiNwHw3vTTIGKckLb+QI9wovyK0bRLUmyv?=
 =?us-ascii?Q?sRDs6AsMHMmebOBzSrqylMMD667gNEazKj0ALCTNE4FwT3oP9tf/3fXfDWhv?=
 =?us-ascii?Q?+oUMdtc4Y9geM5J+dDu7ZLE9YotPqfE=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_955D5B4E-42F8-4D79-B67D-4BB7973F2549";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8438448c-41a1-4a74-bf79-08da13cedb53
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 11:00:38.8986
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MwQSVR/pagcZyRdR1MjR37ixep+Jxl4KuV9cOQaFaZJXWCex5p9Z4ziB2gNmosiJwxSObPH2MYNNRq6bJ3fJUrHljqX/MirtW16wM40dVoo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3085
X-OriginatorOrg: citrix.com

--Apple-Mail=_955D5B4E-42F8-4D79-B67D-4BB7973F2549
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii



> On Feb 23, 2022, at 3:57 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
> This is in preparation to re-using the original name.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

--Apple-Mail=_955D5B4E-42F8-4D79-B67D-4BB7973F2549
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJG20QACgkQshXHp8eE
G+0I7Af9F6EOB6Y6K7bW/z9DtK+EPqUtbr9HQiu4XY7mASQE1BKWNAhh7yYuA4Gg
oexXkdlcl6sS01+fLqXcAMqHD2vsrbIbuXBSgRsmjshc9ZG34MtBsBQJud8/3TCs
dxk7+Bbliq6vJkmgmdClvvHrMyF5Bd2SSQFHTanqObUbjcWKRxvUcNYKcKtKNmdn
z8QGFKXUoXB1jVzh9XEDJEqyCazS84pe9qgLIU0IxB1c1OxF2kPGCaUryhfsWAzl
rYkSx8Xml85AicFgGHDmuzART2jpZAN9YK2/sy91QfX+JTb0j8xaEmmA+AWPyhO0
9OdLRJFEJSv1J/FkmfqYycdopFo3jw==
=m+Zg
-----END PGP SIGNATURE-----

--Apple-Mail=_955D5B4E-42F8-4D79-B67D-4BB7973F2549--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 12:03:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 12:03:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297352.506498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naFzg-000681-Jl; Fri, 01 Apr 2022 12:03:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297352.506498; Fri, 01 Apr 2022 12:03:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naFzg-00067u-Gn; Fri, 01 Apr 2022 12:03:08 +0000
Received: by outflank-mailman (input) for mailman id 297352;
 Fri, 01 Apr 2022 12:03:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MEhg=UL=citrix.com=prvs=083735472=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1naFze-00067n-Q3
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 12:03:06 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aed4fe86-b1b3-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 14:03:05 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aed4fe86-b1b3-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648814585;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=63QKaJFZHg2pZ4dx781z7svpQ1/2jmy9pQOGosdeSsw=;
  b=UppHvgUF9fPsEORYflQdtnC5MjeUsdC9+Eo5GLR4zJM6Re0g0ztRrH6W
   gdhIzNZPXeTN1MLl74wOl6RmK915QeUVE61wjageFgpdM/1aJg1Vng8YA
   0M/T9cZ4Qq6Th9dF3DcycU9xM0vCCH2i1HPWIQkJJ0Ii5jVrlakMUfzpK
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67659007
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:bphlkKBvOxf9dhVW/6rjw5YqxClBgxIJ4kV8jC+esDiIYAhSlGxQk
 DNbHCvTJK7JMVJBSKkiOom3908H68XdyINiHFdv+ylkFyJE8pKdXt+SfxuvZHqccsOaFktp5
 ZlPN9fKd5poFnbS9xrwYrO+8iAi26rTLlaQ5JYoHwgoLeMzYHtx2XqP4tIEv7OEoeRVIivQ6
 I2p/caHZQCrhjV6a2xP4PLe9h8z4Pn4tW8R5gA3PKEXsAfSmUdOAcNEL8ldDZdZrqq4vAKeb
 7yepF1s1jqBp3/BMvv8zvCjNBdirof6ZWBisFIPM0SZqkUE93RaPpoTbqJGMx8L02zRxbid9
 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy
 BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii
 8UxWAddaDrARh1zMHQxJbMdxqSDiHD5bGgNwL6VjfJfD2n7yQVw1P7mMcbPe8zMTsJQ9qqaj
 juYpSKjWEhcbYHBj2remp6vrrancSfTd48VDrK1sNJ3hlma3kQYCQEMVEv9qv684qK7c4wAd
 RFFonJxxUQ03HaoUNTRRCykmT2/7jEyZfZ5VOYquTjYn8I45C7GXzNZH1atcucOq8seVTEsk
 FiTkLvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkRpB/SStdoEIauk8b4Xzr3x
 li3QDMW3utJy5RRjuPioA6B02nESoX1ohAd1zjlWkylywNFbq2DSq2Lsxvw4/9GM9PMJrWeh
 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GpxcEQIFd
 nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONl1Hw2DaJz9zq0+KTJrU3ZE
 c3EGSpLJSxGYZmLNBLsG48gPUYDn0jSP1/7S5Hh1AiA2rGDfnOTQrptGALQMrBmsfne+FSEr
 os32y62J/N3CrKWjs7/q9N7ELz3BSJjWcCeRzJ/KIZv3TaK6El+UqSMkNvNiqRunrhPl/egw
 51OchQw9bYLvlWecV/iQik6MNvHBM8jxVpmbX1EFQv5gBALPNfwhJrzgrNqJNHLAsQ4lqUqJ
 xTEEu3daslypsPvoGpFN8Cn/N0/LHxGR2umZkKYXdT2RLY9LyTh8d74ZAr/si4ICyu8r8wlp
 LO8kAjcRPI+q85KVa46tNrHI4uNgEUg
IronPort-HdrOrdr: A9a23:deD4YqwZoaYwZVHj6qluKrPxn+skLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9IYgBdpTiBUJPwJU80hqQFnrX5XI3SEzUO3VHIEGgM1/qb/9SNIVydygcZ79
 YcT0EcMqy/MbEZt7eA3ODQKb9Jq7PrkNHKuQ6d9QYWcegDUdA50+4TMHf9LqQCfng+OXNPLu
 v72iMonUvERV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X
 nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR
 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCGlaDPY0L3ErXQBepF8bMtiA2jkwltls9dm3K
 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DAfeX56tQ0ubWIyUs4YkWUkxjIfLH7AJlOM1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgE082IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBLB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+laGjMiq9NllVcQ6dv/22vaIJyIEUbICbRRG+dA==
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="asc'?scan'208";a="67659007"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RH8WAvpnQqAindGz+LTE9plfcKI669qMkDe7Qv9pGZTjaVWVHF46XvGe1EyBmuAUUtkrRZSPIUtwtbqEA3hQRmo7etxR7Q1KYpOriotxZWh0v6CERL8lfwdCtQQnYcLbs1KzLwl6jTtfMNuqibYR6TUPqNZYB4NGBmtLu0OIPZfKivtiXXJ/h+wKdqR4/VGBOkqjU0icpieTNG9Aynf+yqz7Il+sALDJg/ew6tmQtasVKZbXbQrqhS8dnKeV0EMzKPlh1sXV8EbSZVboF6+hUt82DiZ3iH0y8QiOwc2vD9Q4qcO7DklizcWED4WHMeDug0aoJGA3O7ZDb8IwLhpDDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qGL7PQ5uEv/hO+1X+bG0wIFKuVWr6PHkDoNabo1ZKV0=;
 b=GWYczA6VOMrdKAyCktbAt9Ff9DbJzC67fAWcJYzwKpd0rojKvL976JWpPBsk95ei0NcyRi3McIWXW7NG3JLHtV9uzN990rfBe5bwLOl8gfEen1uo0Kxa1YYOtVqgui9h666GnB8oknw0DoCsJdIdjpfZVE67PY7yavzwY3zmq1hz+pE6mEkyVinSayzLQIG41uaKieNYCgGN4z3CTvYzz7J+PfU1FsFowKnzKohN8/9sqs2g6wQ0DtO3x5EAKrgtxtqX3/mH2XhiIl1hvkAhA39+BBOQQJYocHnCcS28iNsptug/TUiqv9cBh1D2lLJFbeT6zJYJEpXs10Pg4NQ74Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qGL7PQ5uEv/hO+1X+bG0wIFKuVWr6PHkDoNabo1ZKV0=;
 b=DGiUuH13fRD4pr+NBf8BLEkoHElDJSsW9Y4ehPpZ0Ugx6qzhDjkCIH8bgQPi+waIci9AzIEWZvZgIHlSZCspamRaFZQm6I6h59Kpks8y17IKwoIozAK1ACn/g0jS+qDGm9BAT4vpDp0SmSxv4p8udvWN1CUV4zXufTpG7LmWCt8=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()
Thread-Topic: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()
Thread-Index: AQHYKM5GC/VzGwcY0kWHMmttuUzSl6zbLyqA
Date: Fri, 1 Apr 2022 12:02:48 +0000
Message-ID: <AE149C77-2D93-4DEE-8D03-925CD6744519@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <c8ad290d-65ba-8437-276b-5d5f1d4d225b@suse.com>
In-Reply-To: <c8ad290d-65ba-8437-276b-5d5f1d4d225b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 779a07ee-c92e-4edd-05ff-08da13d78a31
x-ms-traffictypediagnostic: BL0PR03MB4161:EE_
x-microsoft-antispam-prvs: <BL0PR03MB4161680207DA87824F9280E499E09@BL0PR03MB4161.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 4exTTh1ioCKvHxvwHVVqAmFO1ouOhk8eaqBM3TR/dqI5gyTQwTmWOHA4MmQtnJUOuoK/orkKkh4yxbkEhj/ecfaRr/5PJhH52yJEeTt1DQ/Xzm6ERv5AQPWsMWeEKpUVL/kg2lqT+8U+St92kpVO4iLEs9otiYxrBl1+Df8Pl7pEA4jr2KgsUt0T63hyP8sLo62PENjgglioK9Puw3x8IasMkS7ivEmCj1G1nKhZ8MMrVxPSpeOq5it+/gKkg6YUtBepr2CkC4B+OMjARSjEl+iQp5vB+Q7fbLJMnr/sGN2ZwMl9Wr9/HOURX8FicDSMIY0kHUBFpA/P+GfTSE34zrWDrb4pB8JfITCgqaZHe4QCxK1C7NAOIe1qtnVdd+eSoifnyEjzlc5s2JTqF6ZfUWDsI1zdbQtVeODkDTlkr4kHQNM3QsDHRN5+Rd1CDBKG60mcHQvUOAflC96qOajpCSN0F3j3aH9i0g1Yc7FNbK9w/VbD0OoCZguS1W+hcQDv7v9eoRUKIhjJCOqhCFk1CWBr2Rik9fDzYfwQsl/jrQuBwUeZtKogMKr4Vc0XaSy7ynltAwAXmb/2+oQgbBeivpUQaLZDXU+acQH7fMwQdIuUvcAmGiHebDyuNCJdeXO+t8D8adNhSqD08LhWZYLwIbtiMMxKhUReVqdzANGFQQeguMk9sEAbNgz5Y+mn6BXOfFLMgs7LLGDR6J/ex69Pe5ZekxFTGcSR8afnWRJSW40r+TudnRc79FcWUDydPWjQ
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8676002)(38070700005)(66556008)(66446008)(66946007)(66476007)(64756008)(8936002)(107886003)(91956017)(2906002)(76116006)(6512007)(2616005)(6506007)(5660300002)(4744005)(33656002)(26005)(86362001)(71200400001)(186003)(53546011)(36756003)(54906003)(6916009)(38100700002)(316002)(508600001)(82960400001)(6486002)(122000001)(99936003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UEpQc3dpQXhKdmw1Nzlla2ZvUXJTTU04eHpYdXB3UGdYRkVmRHhMVWtWeEFQ?=
 =?utf-8?B?cWlqRVU4aVp3R2h0VU9WLzZ2TkR3TXhFdzZGdm5WZmNJSnRiMmljeTBjOU9P?=
 =?utf-8?B?KzdwRVVOUmMxWm1sdDd2ZHRCd2xrK2R6dFJZZVNOT2dxVUxCSUN5ajVrSnJh?=
 =?utf-8?B?eXlqK3drYks2eS9OQTUwR09tdkRGL29leFUvRi9DTjY0S2JTU3Zwckdmd3pB?=
 =?utf-8?B?Zml3VHpRcVA5V0s2eHAvUFd3dUo5K3BabGpvVDMydFIza0UyQVpXUUo0ZU9N?=
 =?utf-8?B?YUk2QWlYb2QvK3ljckxxSmlnOU45dDdJNkwwZ2p4bnQ0ZVhVZzByWnlHWlhX?=
 =?utf-8?B?ZmowNUdzZGlXTkxNSSsxK1AvbWNQTmxhRGpncU4ydVBnNTFsZlhiUVNjYWtE?=
 =?utf-8?B?M0hocHdUOGRtbkpzaFBpaml3RGFmdHI3Ync0ZTY0VEJMZDIwekh6dWIxbVlk?=
 =?utf-8?B?cUptc3o5MlhndEs3VlgvRjJFWm5XTHloNHlJdzdBUTh6Yk1DSDVQbjBlMFUr?=
 =?utf-8?B?ZHNpdHV6akZPWnZKNjhGbkdaVkhzbWpDYVlBQWJWYUtnTk52WHlZUk93YXFi?=
 =?utf-8?B?Tm9LWmlGUTMrK1p3R0daZEcvT040Q1lXWGxqMWZvbDhRUC9GYTEwbG82RjJV?=
 =?utf-8?B?V05GYUNzUlBMQTFRY1plSjczNW5tclVRV2dSM2pHdVEvSVplcHd2WjI1aGRw?=
 =?utf-8?B?L29tNnpKS3JCWlFFNS9jWXhGaTdBVUZJWUw5MHFERXhoNnJjWGg1ejJuSFlC?=
 =?utf-8?B?K1J2N2NvWSs2L1VLQTRIKzJVVlR1dSt5c3QvZlFWdFZuUFpaSjBSRm4yb0g0?=
 =?utf-8?B?UFdzWnB1WHBaNlNWdGlQcEFZcGF3WUtMdVZ2K2ROYXh6cXd5d2czYjM0Vjh2?=
 =?utf-8?B?cHg0OE4yVlFhK1Z0R1BhNlhPQlZCbkMvR3R6clV4UnJIVVRPcTErakx3bnFH?=
 =?utf-8?B?K29QWktSWFhEZThMZlkrK2I0dlpKMUIyakN4TU9lN281eGZ3OUQ2WTRJRkJM?=
 =?utf-8?B?WW9EbzdZRU0zbEdpMVdNQjMxVGdvMGNzZDlrR3BmUmJ6VUtEbjJPTUVzZ1Yr?=
 =?utf-8?B?UnhzT0liYmE1bW5od1prQXhqcGJOaytwSkFYTEN1bGVJclRrWUZPOVZnUmtu?=
 =?utf-8?B?d2g2MVpjZFA1bXVvaXlTVll6OHV0YVNtUmYvWVp6elkvUDQ3LzRmZGV1RDkz?=
 =?utf-8?B?VXIveE1IdlJkVmw4NGFrVnZTM3IreFVIcDBBMi9lSDZiZFpZU0QyKzF0OEhD?=
 =?utf-8?B?SE5JeW12NlNRN21EbGtuenh0VGdrWkNlaGw1eVAycGVObUduNFBSREdCbUEy?=
 =?utf-8?B?ei83OGtUU1R0NEY3cjBaa296bWxLUDJRZ3dFRldBL1FKQ2lTOHhkTUg2VmJS?=
 =?utf-8?B?ZnI4Q1R1Y0lYMjZtZzM5N2EyMHZjT2lTVGN5V0xtR0gxYThqYWUrZHJheEg5?=
 =?utf-8?B?Uy8reG5vZUdPdUFodC9vYXNlZmc2ZXpPbC90bEs0ZW94Q3JGeHRMUlpBcFI0?=
 =?utf-8?B?c0Yva0phcXNuQzUwWmNnMkREL0tlUDZLTE1pblZNMmlOWTZibUMvSnJ1dWVQ?=
 =?utf-8?B?NU84K3l6b3FvNHg5ZGEyN3ZiOU5IRWg3NU9TdmlVd0pCbnpFcnJiYnB0cTF1?=
 =?utf-8?B?L2xTeU1KaWJTT2xBWW5rQmE3RVFYcnQwMHVzUWh3ZXc5K3UxbTREdXVMSDYw?=
 =?utf-8?B?VmtQM0tmNEMwQjh6enZXSmxDc2dwaEU2Vlh6T1E4SVY1ellEOGpwcEdhUk85?=
 =?utf-8?B?NnZXWjRXTmdRU2FnNnZ0Z0RLSUJLY2cxay90QTZJZlU5U3BSejFFZFd6Z210?=
 =?utf-8?B?bGpTUm1MN3phazlDZGx0b25oak5YSWZVZ25ZL25yWi9pV1hmelYwODNxcDda?=
 =?utf-8?B?R1ptbnJpZVV0MlRWQlE4MGZXenpkZ0NVS0FLQXpTZ3BhYi9kTjNKZHh2SHNo?=
 =?utf-8?B?U2lsYjZJdTBQbVhiYlQxOE85R3ptMG1QUHprTDlQWVdERkp0bFZzZEhRZkw4?=
 =?utf-8?B?bWF2M0E0Z1QrZHNpcmV6VjZnYVFRdHlST0JsL0RlOWQyRktDd0U5ZXVoWURP?=
 =?utf-8?B?Z1pIODA1bUl6MTlSMnlmMDZNeWxnQlJ0RTZad0VwM1hlZE80VGNnTWgvN2l5?=
 =?utf-8?B?Rm5tT0lSTU8xWk1RdWRzTUR4cFNsTDdVN0lRVEpjU0lSZUdaS1RwdUQxakJ5?=
 =?utf-8?B?N2VjN2RGdmYyYXdTclpmMWQwcDBHT2o1RlB1Znc1ZmtreVdvbUlaY0tOcmlP?=
 =?utf-8?B?ZGdCUXBUOHp6S0MxeU9VN2gyWUZlNGwrVUZuR2pDdlZNVWRnOEFtYnA5Zm5O?=
 =?utf-8?B?MXpRL3JHRjRTdzdaZmJuK0Q4QUY3MlhFemh2QnlGVTRTMGZBNmY2UVQzekRZ?=
 =?utf-8?Q?+Y2x36qUeXp+HKrU=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_53EAF4DD-C193-42DE-B4A5-75744F4AB645";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 779a07ee-c92e-4edd-05ff-08da13d78a31
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 12:02:48.2461
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GurZSr1Lws0orKgvLR9+AI2FJXUGS+SLg7w6a8Fbk3rAnlFeaFCW+0goS6M4JrKWEUjaR3jc2Ww7w/QNjlb+alCmf3bQ0fTTwkYF5m6E//w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4161
X-OriginatorOrg: citrix.com

--Apple-Mail=_53EAF4DD-C193-42DE-B4A5-75744F4AB645
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 23, 2022, at 3:58 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> Rename guest_physmap_add_entry() to p2m_add_page(); make
> guest_physmap_remove_page() a trivial wrapper around =
p2m_remove_page().
> This way callers can use suitable pairs of functions (previously
> violated by hvm/grant_table.c).
>=20
> In HVM-specific code further avoid going through the guest_physmap_*()
> layer, and instead use the two new/renamed functions directly.
>=20
> Ultimately the goal is to have guest_physmap_...() functions cover all
> types of guests, but p2m_...() dealing only with translated ones.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Paul Durrant <paul@xen.org>

Description reads much better to me =E2=80=94 thanks!

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


--Apple-Mail=_53EAF4DD-C193-42DE-B4A5-75744F4AB645
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJG6eEACgkQshXHp8eE
G+2ZswgAzg4CzyX5RU+j80xayxGPj3DHurXWdxjVFqoULd6K73pg9MVb1UDy7Axt
aM5tYkx32SOX8+2Wgrs03qflh7RTXuGcNjWYtTmBngP+73MDUkZ/M8obVqFnnPVi
q8dHN6Mxd75DTaFysu1HuyGzNROL1fDXfpqlVkBFrymSSvjO+cZLRPRepg1qXo2V
jVzr0Je4PkPEztcX+2CzWyUorzYxrXunCLusAM3sFvjf9ti6MqsAlkp6P5z8Qdfe
3u83lsQc9uaMKbJHqBJc4TgO1WW00ylAjUFbYk27c4q5SD2RsHCgdE5pYwrB87qF
w9s0dZUeWHOd/tfg7TLU4zf3o0LExg==
=BCCh
-----END PGP SIGNATURE-----

--Apple-Mail=_53EAF4DD-C193-42DE-B4A5-75744F4AB645--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 12:13:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 12:13:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297357.506509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naG9u-0007bj-J6; Fri, 01 Apr 2022 12:13:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297357.506509; Fri, 01 Apr 2022 12:13:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naG9u-0007bc-G8; Fri, 01 Apr 2022 12:13:42 +0000
Received: by outflank-mailman (input) for mailman id 297357;
 Fri, 01 Apr 2022 12:13:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MEhg=UL=citrix.com=prvs=083735472=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1naG9s-0007bW-SX
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 12:13:40 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29181b7d-b1b5-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 14:13:39 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29181b7d-b1b5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648815219;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=faJF7Jitm0ep8Thv1crZvBWWE0xHa31Yovold151imk=;
  b=JLLEzhEdiYMllQ47EC1qQ9NppU8A5B/uWUDXkV5QmzPlLvU/hfMU2ERO
   L2EyQ8k06WHQLU5/KvGgeEITXblR71l+gZMuGMpLsXP90C2Y3AsHzy2jl
   gp4RGB6HhYxQ1t5Mqij5wJSkM03xiAkbox/pnw0HtVIP4OVpp0f7E2xJP
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67659974
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+gnXjq0s63kY9IQglPbD5UJxkn2cJEfYwER7XKvMYbSIYQITYwd3j
 TtIBzjCf73ffDO2KOnCW/218B4Fu5bWyNFmGgts/3ozFHhD+ZqZXI/IJxf+NX+bd5PIFhlut
 s4VNYSYd5tuFnPRqxuna+O+8il3jPnWHeHwYAKo1lidYCc9IMt2oU4zy4bV+7JVvOVVIz9hm
 Put+ZKENQX5imMpOGxJ4a/e8Rg+5vmvszhA5FVgNakR4A6CmyEZAqxEKPDqJRMUYGX18s1W5
 Qrn5Ovklo8M1051UrtJqp6iLgtSBOS60TGm0hK6YYD76vR5jnF0g/5T2MY0Mx8N0W3Vx4kpk
 r2hiLTrIesXFvyU8Agie0Ew/xFWZcWqL5eefBBTGeTKp6H3WyOEL8dGVSnaDqVBkgpDOklc9
 ORwFdw4Rkvra9RaYl6MYrIEaswLdKEHNW6E051q5Wmx4f0OGfgvT0hWjDPxMfhZas1mRJ7ji
 8QlhTVHQR7/RSdFZnQuVpclxcyl1nb/LidEkQfAzUY3yzC7IA1Z1bHsNJzee8CQRNUTlUGdz
 o7E1z2nWFdAboXZkGfbtCL37gPMtXqTtIY6O7C/7PFnxnGOwGgaEDUdVEehoOn/gUm7Mz5aA
 xJLpHd//PdunKCtZvrvUwWajnW/hzURVOpgHuM75CqEy5OBtm51AUBbF2UcObTKrvQeWjgCx
 lKP2dTzClRHqLSITVqN+7HSqim9UQA3B2IfYS4PTSMe/sLu5oo0i3rnXttlVaK4kNDxMTXx2
 CyR6jgzga0JiswG3Ln9+krI6w9AvbCQEFRzvF+OGDv4sEUpP+ZJerBE93D258lmFozFbWDfu
 WNdsMXO4+BTF420wXnlrPo2IJml4POMMTv5iFFpHoU8+znFx0NPbby88xkleh43b59slSvBJ
 RaK5FgPvMM70G6CN/cfXm6nNyg9IUEM//zBX+ucUNdBa4MZmOSvrHA3Ph74M4wAfSERfUAD1
 XWzLJ7E4ZUyU/0PIN+KqwE1i+BDKscWnz+7eHwD5077uYdynVbMIVv/DHOAb/oi8ISPqxjP/
 tBUOqOikksDALKjOHOPoN9OcDjmyETX47is9KS7kcbZf2Jb9JwJUaeNkdvNhaQ790iqqgs41
 i7kARIJoLYOrXbGNR+LehhehEDHBv5CQYYAFXV0Zz6AgiF7Ca72tft3X8ZnLNEPqb04pdYpH
 qZtRil1KqkWItgx029GNseVQU0LXEnDuD9iyAL+PmBlJsQwFlGRkjImFyO2nBQz4uOMnZZWi
 5Wr1x/BQIpFQAJnDc3Mb+mowU/3tn8Y8N+elWORSjWPUC0AKLRXFhE=
IronPort-HdrOrdr: A9a23:IVysw6En483tMYkGpLqFWZHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVoMkmsiaKdgLNhcYtKOTOJhILGFvAa0WKP+UyCJ8S6zJ8m6U
 4CSdkwNDSTNykDsS+S2mDReLxAoOVvsprY/ts2p00dFD2CAJsQizuRfzzrdHGeMzM2YqbReq
 DshPZvln6FQzA6f867Dn4KU6zovNvQjq/rZhYAGloO9BSOpSnA0s+1LzGomjMlFx9fy7Yr9m
 bI1ybj4L+4jv29whjAk0fO8pVtnsf7wNcrPr3MtiFVEESttu+bXvUiZ1SwhkFxnAhp0idvrD
 D4mWZiAy200QKXQoj6m2qq5+Cq6kdQ15ar8y7nvZKkm72geNtyMbswuatJNhTe8EYup9d6ze
 ZC2H+YrYNeCVfakD36/MWgbWAgqqIlyUBS4NL7okYvGLf2UoUh5bD3PXklZKsoDWb/8sQqAe
 NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blngR+jTR81Q8V1cYflnAP+NY0TIRF/f
 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjia2jPBeUCITbAupT36LI66KWjf4EJ1oI7nN
 DbXFZRpQcJCjTT4A21rep2Gzz2MReAtG7Wu7JjDrBCy8jBeIY=
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="asc'?scan'208";a="67659974"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OzHwBw97K6F03QBqi306GCb964/mwFTh/r5wUQG/lJLWB9NZ3laXPtXiEq0Nb6eso1YUHo6VCV3RI6Pkzy8vCu+KFVdACbwL/SHnHlHr9DT6LbLxQdkmQMLXxhiAIMsQRrGnS49xlnFv9syBOhxkiWs0jxU+hg2Ss+nJa1dPhQ+wQJdt8Fehtlc7zvFVXSfImcE0PKCKUB3rKKtT7nOyge0QqJoXHkCvdjmN0oOWsOE1Gq7QUhjRKjUiMotV3wjdOLQso9xzOYol+uCmBW6H456OX0EIocn1LdVCgmo47r+doJG4bf9ZjRJWbz4NmpufOahrx65FVhuSDj7eeQSPcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kAEGxWNXFtU3HbhhGY8KRY4ZPiqwIdf93K87XmZBux0=;
 b=jxk8ok3Zv3gJGA4dzUq5MVRzJER3HIc8DsXNl7DpHqFQi/40OpsKOyvTrav9X7Lh5JI+rz1PXnZOFgE04CnXvowejHwxV74nv03SaLsqUWz8oet2g5SzAp3+Pn1p5Lwcn9xw/6m++Eb1CMLdN+qBHHlyw7VMsW37xLjc4LhmqByhP3CP3OY5mkRJcPzq1xj/wejCFsbFe+ywApUHpx+Lu79ALRzDsg1gkZJtWp3wUI24gR1T57WIZA7sbBe/2vcnJwDc9EfINO74lX95GNaJYm/TdVQ5SLE8hb8yhwaGv6fKqX34s6vlpwSbsPw6v9CiObncCJ66Ftbp7R5yRuQdIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kAEGxWNXFtU3HbhhGY8KRY4ZPiqwIdf93K87XmZBux0=;
 b=bqcSEmaAVP/SqT9zHaIZiwMnRpgyxdPrH2nh8kvMFlxPyxXNfwWat24ap+TCF0Q5F1eMxfeQh7I9fa4B8RopZt7TGd4pHk2xhn26uCnPYqiAPHVuRnZ+ASDP0orAyCtKsGj5dZFSiB7/KYdj1TtpekqxSTtMl0ipQBycVIgwh7g=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV
 and HVM parts
Thread-Topic: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV
 and HVM parts
Thread-Index: AQHYKM53Hk2TW/bmsEWEq3Un0PVcU6zbMjKA
Date: Fri, 1 Apr 2022 12:13:34 +0000
Message-ID: <86F5ABBA-C4AA-4F02-944D-6210D65CC16E@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <69623630-cda7-9b2b-4f2f-09a83d5dc22a@suse.com>
In-Reply-To: <69623630-cda7-9b2b-4f2f-09a83d5dc22a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0b4ffbed-bda8-4097-cb32-08da13d90b86
x-ms-traffictypediagnostic: BN7PR03MB3553:EE_
x-microsoft-antispam-prvs: <BN7PR03MB3553523869DF3B64EAF3AF9199E09@BN7PR03MB3553.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QMNycv0RAAHEu/pJ1b2UNfz5JW9NxKIF5V7u4ZaqPYsrX4aM0oljZSonBuFbhH6Pg10OokBd9r4UO8Y0Mw4Z6zroqnZ2uprMJX9qfwk4angL/t5N6MCW12u4p1B9UgbcY/iCmZonqa/UhA2fQNFSNZKNljFUhRxS1DovqKsY1dOzktmxjBJ6LsfX/dEGjFIfBz7O+pCNTLJjqe2b/QEdcb9qFrqXvwfxdFxPfkovYlBm3uS1KMNiXtEZC4guhbh993oZ7kc963LmP/IAbSLEulolF/A5gBdOcgFXlGIlYPrgPFj2Pa87F4nuQojpmvg2pm8vprtIJc8+htpvE77XDSlsc204CTib4qHQJzgQW3A75gJfC9eF74Z7YBq/xwUzPPtQTVv2tbah67De6H25xOGv9JRZnyRzjfF+PjMX7ZMF140FLeIStvoOUf1L7RJ688gtShcIZCmnPYnJBIYmXdPyswhPXcaNffcdi6cwlNdYI9IM5+jnLM/DymHuudsb9T9br4u5LjCDB4qQm3mVNyrQvobAq7SBzVS0+DEpOV84BcfF8N9v1fw7nseKIq4cXpgQZyAD6Y3JS4pkdmRc0lG8eRK9RRNZe2b3Lr3iJb5L02Lyd0mK1Koh95sxlDQ3ai3K5WO3lUa6d545pQfhWZ/gfik9XOj11j2fBM9e5Cxj00U3+ZfgWJomY3Z8jRSF8ni5nW4sQoap2JP61ONRx+bBk87lobE0WQ/qp99gdaK64JdsJjFgeo41L6NCkaqUyW5kq1RZ0cTP5Qa2jAwgIg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(5660300002)(66446008)(66476007)(66556008)(76116006)(66946007)(64756008)(4326008)(8676002)(71200400001)(33656002)(91956017)(6486002)(508600001)(186003)(86362001)(6512007)(26005)(2616005)(2906002)(122000001)(38100700002)(99936003)(38070700005)(82960400001)(4744005)(53546011)(6506007)(36756003)(54906003)(6916009)(316002)(70780200001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SDRLZ1FnRUttU3BpL3ZpOTQ5ZHRlVmJCQ3puKzNQc2FLNWh5dWUveU1ZdlF4?=
 =?utf-8?B?Zi9tSk05NWVNOC9obzZsdFl2S1lKL3NIem50c0dzYldrTTh5T2xGNUZqMFJu?=
 =?utf-8?B?Z2RoVTFPYUx2NjJ3U3E5U3FONXVlZnhkQVNiWmJCU2hKVFlwaXY0em9QZTVZ?=
 =?utf-8?B?TlpQV0Fkbjh6RERsVmVRd3hVNk5kMklPK1lwMTh2UnpOOWlYTmZNdWFLNXJa?=
 =?utf-8?B?YU1YdWpVVlRuUklrSE45Z3RmVTEzUVRmMC9FSThibitraGxWblptMjJwWEln?=
 =?utf-8?B?TittK3VUOXFBUXI5Z2YveTJNOW8rZnZOT25UUkpsdmVDRjZUT2xnQnRycyth?=
 =?utf-8?B?cTdBM1YvS1g1MjV6UHpVbTk1TWdDNzFDd1NhNExYQklTWXNXQkllaFFwNG1T?=
 =?utf-8?B?Qk5WUjIwSnBQazlzRGIzWXA1V3ZWQTNVUEpWUWNLU3V5bW9nWGNQalFWV0xz?=
 =?utf-8?B?LzEzN3R0OFpsb29ad2NsS0pVUDRvY1BDcE85UG43YlZCUUVkNXZEcVN4dUJs?=
 =?utf-8?B?RWFwYVRtdnp0a2RvaWpMZ2kwMENLdVR0UjlZMlhnYjBteWdVSmpCOVVnOHFB?=
 =?utf-8?B?NnhCQ2M5bXdsaC9nUTdXZmpiSGVkejFXNnlqNFBnb2hmOFY0MVY2WDI1emh2?=
 =?utf-8?B?STBsT0g4VEd4Q01jaXRHbDhHcXZOcEdsV09wNEtiMWxHZ3VOZFJja1hJNStD?=
 =?utf-8?B?YmhOOWZrWWc0QWVsMGFLdkVmSnRFQ0FIckdOWUU5STJIMlAvVzNXYzFsdGZw?=
 =?utf-8?B?cXJSOWlRRWxRcEQxVkFETzhwZjlHdzJrOFE3MWdTK2FCNGpqelUyMUFHbm91?=
 =?utf-8?B?SmtFTHE1SDNUcHpMdFhUbWI0R2xlcU53ZmFvc1ZIeGJXOHpudTRtbnZyUUxn?=
 =?utf-8?B?K0hWUUpLanVlUU54bDl6alNuQmlpcmdjcWo4bEZON1RBTFNhSzNjV0V5aDdr?=
 =?utf-8?B?VkdVclhMbUd4cU5pQnhURWZzemdpMVhxOXluUVJzT0hPVXdPbEpRWXZESmVT?=
 =?utf-8?B?bnFLZlVmbWpjSU1pdU9sbnFOZzJDVFdjOGV6MGZHMVVJR2NMSkRYdWNmTWxo?=
 =?utf-8?B?cHliRG1ZYmtVNm9wbmpwN0VodWxTUUtGQXlnZExNWXhDamtmY3RIcWkzSUE2?=
 =?utf-8?B?ZXQ1R3lPa2RaNVhxSmc0amJaRmRncldYNkN5N21QejI0OEJ0RjJVQ3JjRVBN?=
 =?utf-8?B?b2hPOVNmQ01QRTV3dHN2S2V6Y0c3aUl3UW5xQ2xmdSsreklMZ3p6WTk0TVlC?=
 =?utf-8?B?Y0R1cXFuRWpIaDFKbEdrdzQvWEorNWxwdlZacXhEWFFYRzBtWGE3cVdUWDRo?=
 =?utf-8?B?UmtBRHNiWDZPSVl2OEZUVjlTYmNzZStPUFhqNklXKzZ5WXRwWmtDcGZWOHA2?=
 =?utf-8?B?WUt2YVdmTGZYWmpCSTIvNm8yY01yRGxDWnhQNXJxbUdnQUFRQUl6aU1xVWhH?=
 =?utf-8?B?MWFuWUVmR2FFeTFwU1lWY1A4WUlmRERGWlltaVd1amJoeVdkRng2aWRITjc4?=
 =?utf-8?B?MG9YaXJEelRSTkc5WnZQeU4vNVRLc1pIemkwcklkQmx6Zk9BNFh5V3pjWGd4?=
 =?utf-8?B?LytSSTZxdTc4cVY0NWF0SmcyN1M2U1Z1c0wrWVFjVGt2Mkh5Zm85bCs2M3d3?=
 =?utf-8?B?dnRCcUZQVG9SbWNBSE1HK1hmNkZaekhKc1l1cURYVnRwN3grclRHNHpEMEp2?=
 =?utf-8?B?QzYxN0doVWdLNm4yZzUxa0xpOW9sV0h6ZEkzcFNITnZoVWNWS21wQUFKeEFX?=
 =?utf-8?B?dDVvd2sxSE9YRlhLRjBCeHRQWEFDVUlsNnBFcnRjcDJHbldKSURpaHZScEsv?=
 =?utf-8?B?elVoMm5ab2kxaDhkZFBzanZjb2g1TFI1TGlXdmlNWm9NWWoyVS93QzdHNjEx?=
 =?utf-8?B?WGs2WnRwQ2U5TWR3TGpIUzBab1VKQ1lhdDFjSzFsaHlZTHJBeGNKVlRTZHEx?=
 =?utf-8?B?RGpteGkwTTJZdHlUMGxmNUYrWS9pbUcxUEFkZTA4QjhKNlVDb1pDMFJYbW54?=
 =?utf-8?B?WUtFeUhHV01mMlYxd0RSaU5JVVJMb280VkZsc2VEaDVHMDBtKzB1R1YybjBB?=
 =?utf-8?B?TGJxVHFlYVBOV3oyTUJzdml6ekNKdzhoL0NNTVhrQW9BZDBZSW90ZTROdmJR?=
 =?utf-8?B?OUpab0tmUnVjaU0vYlE2a0dKQ2NuMU1pN0RVTVExMlZkZVF0TDcwUUhHLzcv?=
 =?utf-8?B?Y1NBdVlWMCtnaDlZeWs2eThzWWU0dXNGV3haZFB6bDhUbW11Z1o4YlBiTXFY?=
 =?utf-8?B?ZE0yd2dldE1ZeXJaWCszai8xTnAzMExyZTRxQ01GbjVDU2dhakZnM1B4cjdZ?=
 =?utf-8?B?QTg0VFV2T2RnY2s0TGlPU1Q2UmkxS1V6VE9STDNxQU05Y0ovb3R4MUcvanRx?=
 =?utf-8?Q?QrJuUMebZ/nKsKII=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_822F42B9-846B-42B2-AF8C-894124EDCAB3";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b4ffbed-bda8-4097-cb32-08da13d90b86
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 12:13:34.7623
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SOwUHxvL6VrP/HbruIYYTk9Q9AI8xPoJOK+fXC53BbLsxR/+TN2pnDJ7/6LHNCglTkgjTV/3J8sZLTRO8o4ItbYOEkMZNzfLo7xXGEnV2nY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3553
X-OriginatorOrg: citrix.com

--Apple-Mail=_822F42B9-846B-42B2-AF8C-894124EDCAB3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 23, 2022, at 3:59 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> ..., moving the former into the new physmap.c. Also call the new
> functions directly from arch_iommu_hwdom_init() and
> vpci_make_msix_hole(), as the PV/HVM split is explicit there.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: George Dunlap <george.dunlap@ctirix.com>

=E2=80=9Ccitrix=E2=80=9D is spelled wrong in the email address =E2=80=94 =
not sure whether it=E2=80=99s my typo or yours. :-)

> ---
> v2: Change arch_iommu_hwdom_init() and vpci_make_msix_hole().

I think the R-b should probably have been dropped for this change, but =
in any case:

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


--Apple-Mail=_822F42B9-846B-42B2-AF8C-894124EDCAB3
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJG7G4ACgkQshXHp8eE
G+2PcwgAi1pyCGVqdohSMaogNBHz9O+LPIFbX++8sFi6ubJdu8c2m/EFnuNki1vP
AFX8sFw8Ax9LEaBGipCClou89i6vQ9cQz+SBoawFGiHfHIrEO5yqQbAelPlR0+kW
UNqrvCw4GN82rTm1q1maHm+c4phGSy2kFCya+HFmlvhTTlDQgfi93L4wkue9CdBp
A+eAf7rk/IqTPurMrwKAvkDeEpFgH+gNnk9FqET2Q9VK7lHJASvnRoP5DQKLb1VW
DfgPXgpbPhP+nkjdJA+uVnRdkyeYnVfBWJy4CR07tEUdTJ0n5wK8ne5TZqOD9uWS
UWY1bPevNQY+Zt/E9zPZ6/ON6k78Pw==
=9pxz
-----END PGP SIGNATURE-----

--Apple-Mail=_822F42B9-846B-42B2-AF8C-894124EDCAB3--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 12:37:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 12:37:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297363.506520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naGWU-0001aD-Eb; Fri, 01 Apr 2022 12:37:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297363.506520; Fri, 01 Apr 2022 12:37:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naGWU-0001a6-AA; Fri, 01 Apr 2022 12:37:02 +0000
Received: by outflank-mailman (input) for mailman id 297363;
 Fri, 01 Apr 2022 12:37:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MEhg=UL=citrix.com=prvs=083735472=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1naGWS-0001Zx-Bz
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 12:37:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ae6b21b-b1b8-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 14:36:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ae6b21b-b1b8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648816618;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=yZut03FqU3B/VwwAEiP8ClV/cH7IpgEfW721g+jE1MM=;
  b=YoVOmfgg0rVinU36rszxU24TGe1NAdBDrpfD6yTYD2ur2//YF15CaSiO
   iF1kdC8C/Dm2HGcp3HiUAwQ7mDkeTFEvPI05Lou6zpQEJzzS76zssnVUo
   ZYkRUu830R8i0dqMYSeVvwJdXrMC3slMD1HLOQUqKPsw2KUhXyAQbtc+C
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67776620
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DQK8YapTtRBEg4o8j+B+qsPyN5VeBmKbZRIvgKrLsJaIsI4StFGz/
 9cnaN20SrzTNTykP5w0PZPnthk2DaWlxtZrTQVv/CE0QysboprIXYyTfxuvNi6fdsebF048t
 c5GO4jLdpg9Ey7SqB3xP+e9p3QshauDSuelA7GbY3EvFGeIJMtZZTdLwobV1aY00YjR73qxh
 O7PT+3j1H6NizMla2gY5avfohk2tamv42kUtFZnaaoS4wTVnSAeU8hOea3pI3XGGYQFReTSq
 8QvbV2aEsE12z93V7tJR56iKhVirob6ZFTI0jwMM0SbqkAqShYai87XD9JBLxYP49m1t4opk
 o8V6cTpEV1B0pDkw4zxbTEJS0mSAoUekFP3CSDXXRu7lhCun9PEmp2CPWluVWEq0r8f7VJmr
 JT0HAslfBGb799a9ZrgIgVaambPG+GwVG8XkikIITg0lp/KS7ibK0nBzYcwMDvdGqmitBsRD
 iYUQWMHUfjOX/FAEkctAc4Dg8mhvUbATzF28VSqu5MoymeGmWSd0JC1WDbUUtmDRMETlUeEv
 GPWuW/+B3n2NvTGl2DDqCj1wLaSw2WrA+r+F5XhnhJuqHKewXYcBVs6SF2/qOGRgU+iQdNPb
 UcT/0LCqIBsqxP0EIenB3VUpla2lCAFRsEJGtd57Vzd4ajQ3CerInk9G2sphNsO65ZtGG1CO
 kWyt8ztLSxitvuSU3313qeZq3a+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adrPf4BDXxy
 DCitzUlivMYistj6kmg1QmZ2XT2/MGPF1NroFWMNo640u9nTJ6fbtCV9nbS1sl/EIq3F1++o
 kEbssfLuYjiEqqxvCCKRewMGpSg6PCELCDQjDZTInUxy9i+0yX9JN4NuVmSMG8sa59ZImGxP
 Cc/rCsLvPdu0G2Wgbibim5bI+Aj1uDeGNvsTZg4hfIeM8EqJGdrEMyDDHN8PlwBcmBxycnT2
 r/BKK5A6Er274w9k1JaoM9HjdcWKtgWnz+7eHwC503PPUCiTHCUU6wZF1CFc/o06qiJyC2Mr
 YoPaJbQkU0OAbCjCsUyzWL1BQpVRZTcLcqrw/G7i8bZelY2cI3fI6G5LUwdl3xNwP0Oy7agE
 oCVUU5E0lvv7UAr2i3RAk2PnIjHBM4lxVpiZHREFQ/xhxALPNb+hI9CJsBfVeR2q4ReIQtcE
 qBtlzOoWa8UFFwqOl01MPHAkWCVXE/13VjXZXr0PWBXklwJb1Whx+IItzDHqUEmJiG2qdE/s
 /un0AbaSoAEXANsEIDdb/fH8r97lSF1dD5aN6cQHuRuRQ==
IronPort-HdrOrdr: A9a23:jVpQQK3t/77EqvcMZcWnBAqjBQNyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHO1OkPUs1NaZLUXbUQ6TQr2KgrGSugEIdxeOldK1kJ
 0QCZSWa+eAQmSS7/yKmDVQeuxIqLLskcCVbKXlvgxQpGlRGvhdBmxCe2Km+zhNNW977O0CZf
 2hD6R81lidUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLokCs2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlawkEyzzYJLiJaYfy/gzdk9vfrWrCV+
 O85yvICv4DqE85uFvF5icFlTOQlgrGoEWStmNwyUGT3/ARAghKU/apzLgpAifx+g4uuspx37
 lM2H/cv51LDQnYlCC4/NTQUQp2/3DE6kbLAYYo/g1iuKYlGfZsRLYkjQto+VY7bVbHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7T1E5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZes6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z54HSKyGG7fIyQZ0We9igF3ekLhlTVfsufDRG+
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="asc'?scan'208";a="67776620"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FNMI5GAfqONg0CLaQr8ogQ8vbY3JgrxLeAep2T3PbfyBFGo+l1HGQHDkJM4IaybOmLjckYhmyRCqw8CbdllDCktDeae03EoRSZWUjByBO9fXefjKfpvjyNommW9pJt1TzMhafB3OE2QbBIO6F7w0UPY2+TAvf9veK1pywqT8mwkPnb+LD4g3VGyylhNLRsMtL++Rx+ZKAbKMaNJf/1J0eCBj+J4YLV0mgRAW3lJq09DV14zlMU3v3ZQXxRaIQ8PzSFgEjVwUCIYOVqdmaNapBpmyair8g++L99oYfkbw5pnQk7Bs3QgW5qmYEgAcUoEJ3GHONYeuJ2Sqjoi6+TPL3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TN6dZ/g5nNvt7Qoz9gXC0DWYwPGm35dx6bIkM5j2DhI=;
 b=K0M5iaFp0AJ4kb2tIhR+3dJZDPvQviakmShMRQ/gFQDNe2wxM7nSNDlQstJdS2hU37xRRcbMtwi9R2kyzBlWV1lRhxgucvtlXt28+DTGe0JejXORcGXBOEH13FtGBKhKAzUwiPMqnYRFxasWgXhcc5ad+TuFPeFLEyEf6Xz3iyffNcXaojGup37/ycYcWnixiNT/vtKaSmlOSf1cGS+f9cuA/0rJO9KZd+1a4Watj1ddCBv1rjW1FCTgmE5t9qyN/Pf76+ZdgtWlkB0P9bclE6ThDyR1bKfOxSCFKfjnKUbpbSzu3TJ4P7fFOQCE+icZ8ZNRRZA7NnFjV9hHFNoQJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TN6dZ/g5nNvt7Qoz9gXC0DWYwPGm35dx6bIkM5j2DhI=;
 b=ak1AwIVY+/Mi29l+QBd4LKfywNqVoVfnETPUQUZMqS4b0ugLZ3tqQp70bliorxUNrdZrBujmeYLBkc39iZ/gHufW9JyaOulCHXlGIsX/aGY+KUI0cWmhL4hjcE+U3u/S11t+T3ieZnchpPWSq/1OYNjsIqNJPNUtiJxWp0MvZWg=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH v2 06/14] x86/P2M: PoD, altp2m, and nested-p2m are
 HVM-only
Thread-Topic: [PATCH v2 06/14] x86/P2M: PoD, altp2m, and nested-p2m are
 HVM-only
Thread-Index: AQHYKM6kfiQ1SdoPe0C+8EGNLnrHw6zbOLKA
Date: Fri, 1 Apr 2022 12:36:51 +0000
Message-ID: <2716C226-F777-40D0-B7FB-85E4FECFE884@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <556f793f-e4c2-8f05-44e9-edf8b300777d@suse.com>
In-Reply-To: <556f793f-e4c2-8f05-44e9-edf8b300777d@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5f9f91f6-27fe-4ec1-3fcc-08da13dc4bfc
x-ms-traffictypediagnostic: BLAPR03MB5522:EE_
x-microsoft-antispam-prvs: <BLAPR03MB5522142182625571CCD61B0999E09@BLAPR03MB5522.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8YP2DUiWq+laADIcgUfJeJGAjaZjv2SHgz6x07snn6oeg4WNidkjwlm2rs+LDsmPfk7M5akeOcYbDrQ5UZXCK8mOGT9XiLQa75tmjM7J5Xv49b8n4OI7sVeWbfWmayqdOouRfdBs22sCFRlteRThnKERkoFas70U9TTnLl0p6XRK/JkZjLqoU0HRb8fvuF4k3eA4KH8EFPMWNU7bK9/ahXPV4Xq22w6vBqqi84QPpWASkXzhlt47TOpnJivM7Gcfe0AqQWEHo/mAHrWRPZrkwmUMZ1bKajmaGTkZz8pisXwcOD4OjIN0dZKqkfRGjqYnirzenEQZ/ypjaffHMesAUbtcOMsw7s7JteNv4CHpPv2IzGjsYiFZPMmbCXzYI4Scqq6JqElsoA1phOiI1RWiCqUsnXjew7GhxdB1aer5RNoIqY3gJ8HdCMfWUqSMlRNnWvPgDXcsNaHK7JSNjbD/Bogxt0QxDTWu8ta5gswFGCtKmo84dT5jkbKXI8vF7QDwSCJNVzzTwWnw2+YWGeXCqPMeUtH6P7+AnpzJBGatjYwTX1tS+cKUl8yoyPBfgSb9ZKOzrvyY2zVRRsoKlNU7dutCD9QUtANbfkRtNEYUR4UAaJ6WC4FACJ44aJPqLrAwfJQQvB5NI0sitYfSt/5raDpzv6ZVYjCTbgVhcIAIRp55I74Ka613za9IIM04y3nTLKDAZEBXKJGlurdpRKNQzQrhsU4+G6MpPqNpSDahw8L4ltuWxGiZO4d+OdpqsFwB
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(316002)(53546011)(54906003)(6916009)(36756003)(99936003)(122000001)(82960400001)(508600001)(6486002)(5660300002)(38070700005)(91956017)(2906002)(66556008)(66446008)(66946007)(66476007)(64756008)(8936002)(4326008)(8676002)(26005)(33656002)(71200400001)(186003)(86362001)(2616005)(76116006)(107886003)(6512007)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bmlna1R2Z1h3Ymw1K0NIUmxzNWFDM2JJQi9YM2JGOXFZc1lBS3ZJVUk4VWNs?=
 =?utf-8?B?T3hqVUQ3eUo3S0RtRzZwMjREWFRGR1NHSWNINitUOUxMR0R3UVlzUjBtUjBT?=
 =?utf-8?B?MTAyUzFnZkgvMTZyaDQyRjh3ckRveDgzbmtGMVdwWVBXZFY0YTBRUGhqSTBF?=
 =?utf-8?B?bm9uSDdNbTlBNkZRZ2VFY3dyQ043K1VHUTBWYjRvK0tZdWcwcEtHYnVaK1Zk?=
 =?utf-8?B?RlZWR2hUZ3M0ZEtWSm5Ma2FUdzUydUdSY2ZXSlBYbHR4eG93RE84QTQwd0JN?=
 =?utf-8?B?RVU3TG9JbkNCZlN6QjdZUWtFa2dpZkhpSjUxVDlNRGpwaDBGWllyZDJLSXZt?=
 =?utf-8?B?cVJYekU5Z2Nybk94OSttSHd6bkU1S2E5QU41N3pObTFKbDJwMW9HaGVlS08w?=
 =?utf-8?B?eWF5ME5LdFFEbVYvL2FRTkMyODJLOThic3AxRTMySm9DclVNZHRFK2JMY1dr?=
 =?utf-8?B?cTBrdDNFUWRpci9zbmw0L04xajcvY0xHR0JMMC9zZzF0dHZQRzRQb3FCUmpQ?=
 =?utf-8?B?OUI3VlUyMkpPcnpKYjR6MFJmaWFQNGVXYjJYM01TVnQxNTluOHk1cGIxeVI1?=
 =?utf-8?B?UjJhNkkwK2lBNFgzUWgvaFZrdC9PSStlcmVENnVUV0dDeFFSU3c0M2NpTGVO?=
 =?utf-8?B?RWdMdW5HWlE0RktZbDNIS1E0MXg2dFZ3WWlVYzRxckQ1UjFMTUhFamxBYXdH?=
 =?utf-8?B?Ynh0b0Q3NllJYjFIWXlPRjBubmNFMitXUHNZTC9pQkErelJkNUVOckllVytS?=
 =?utf-8?B?eXJVYXhjdmdjelE0ckd4WVM3cktRTmxSanlWMDFGQ3p5aWcwVkxkeG5aWDA5?=
 =?utf-8?B?WmNVZE5ZZGVSeEdBK1lwdWR4ME9pV2NLMVN3Tk02U0ZyNmZSOGJqalNIcFFD?=
 =?utf-8?B?Z1Y0V09md2tHSW5pK21tSFNqVmVWQlJsSWd1ellNVVdBZGhueTNjMUdDRVYv?=
 =?utf-8?B?bzYwMUFVMzBSQWx5Tm1uV2o4b1VJVHBnOVBPRHI0Y3JsMlpvRk0yNTcycmdv?=
 =?utf-8?B?UDB4dlFVNGQxMStTWmxoTmdPdDU4YjJUcSthWDNaVm1IOXdwRDRTVXJYa3Zx?=
 =?utf-8?B?TCtJNE5GVXdjLzN0VFNMZWxvTStlWWI3QnAwYTlBK05BTzhRc0NVaFo3R2Qr?=
 =?utf-8?B?VVdZZGxLVDB4TmZ3eEFqTUpDVzEya0ZmRXNKQlpwVlJibXorbHBVcGEyV1JJ?=
 =?utf-8?B?LzNLZTcxa0VwYjBPWmNhQzVTNnpwc1J4L25wUi9oSjM0eHFpbU5pRnkvSXVI?=
 =?utf-8?B?TkxLN2JRSnFKaXlMZ2U4VFFIMWN3anJMUGsyam56WmpxbzNwK1hseVRyR0or?=
 =?utf-8?B?eXFSMDd4cHdtQlFielE1WVpDOGk1RWc0SG9tUzBuM0RUbkFIcnFKQUNzT1Vm?=
 =?utf-8?B?SXJXK0RRdkcvLzVhNGNiWFNLRXpVanRPeWdBNTFtY0t0T3BENWQzemtMUjZ0?=
 =?utf-8?B?dmd6aE5tVlNqMUhDUGQ1UHVhbE1US1lZZ2hVUitYc2dqbmtZMzBlRnpWQkcv?=
 =?utf-8?B?R3F4eHZEeGxDTjFPMTFudWh2WEhvd1h5UENzUWlOZnhYdktJb0pCc29lSHQx?=
 =?utf-8?B?eC9COUJ3SkFFM0h4dkRWMTYxZTZPbUUyeWcxNjR5K2JGRkR2bWhaWnI2Z1cy?=
 =?utf-8?B?QjQzRnpVS3JmSlBaekJqTVhDY0NKUUpVZEhyblNQekdrRHNBWDBxR3dFWVgy?=
 =?utf-8?B?c2ZBUktZeUd3U20zL21mUmc2Qmd3WTFQRW43cjN0alN1TzZrNFh5NTVEZzcw?=
 =?utf-8?B?c2o0WGhQVVc0RUlxYzFZR091OFVpVm9tb3dOMEQ5aDVZR09jd24wVkR1NWIv?=
 =?utf-8?B?NEducWUyemRQdlljYTVZS283L2pWcWQxV0lqOFAxdm0zS3RkRUxpV3p1R1dK?=
 =?utf-8?B?UHRkNUxGNW9pN2FBK1g4dnAyaVo0YllFK0N4cnNOa3lsVklJWk1ZRHoyY2lD?=
 =?utf-8?B?cTJpYnluY1lQaUpvSHhxbXFHcmtxdmFqL0RUMThvRTlnOFM0c1pCSFpHSkph?=
 =?utf-8?B?Y0xxWTJSdHlVaGpQRTBYS1RpamxsZm8xcVVlc29EL3dFdU5nN2pDZ3ZEcUhv?=
 =?utf-8?B?OVc4eWVEQ0FJejBBOVJVTExpNW9UOUZIZ0pzVTF1Tnd3aTFGVzBMMUxpS0hz?=
 =?utf-8?B?QXdPMHNRb1BBaFJSdU9uMG15Y1UvTE9HV2FjRjZNQlRsSyszaWU3cWZNa3NR?=
 =?utf-8?B?ZHJSSHczTXJOdUJ2UFRJa2dlUzBvRmkrVTd6V1RIOXBTTm0rRFpwakFDYmxT?=
 =?utf-8?B?VDh1WVBOdy9sdk5qTjliMGY0a091NDJtd0ZWVCtvalBjSERxTmFGaElKWEpx?=
 =?utf-8?B?REMwbzJUdFBvdUpxdFEzUEhMUG1oOFEzd1MySERMNVJyeWhiVjVaai8vMk1L?=
 =?utf-8?Q?YM+bS22gYXwebeyS362SGd5aS170o2E4D5K4q?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_AAC25DB9-F22B-402D-A36A-20165589E55E";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f9f91f6-27fe-4ec1-3fcc-08da13dc4bfc
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 12:36:51.3652
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nEAPSzEhtzrsEUXJXMSgNvFHNihZ8RcNhgHvdMTGlzBe1lWBfjtefmvhFsLM5ZQNXofRMa8rqukTNAP3fR8dpykrPIQ5KQpeWlVgWYc3NEo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5522
X-OriginatorOrg: citrix.com

--Apple-Mail=_AAC25DB9-F22B-402D-A36A-20165589E55E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 23, 2022, at 4:01 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> There's no need to initialize respective data for PV domains. Note =
that
> p2m_teardown_{alt,nested}p2m() will handle the lack-of-initialization
> case fine.
>=20
> As a result, despite PV domains having a host P2M associated with them
> and hence using XENMEM_get_pod_target on such may not be a real =
problem,
> calling p2m_pod_set_mem_target() for a PV domain is surely wrong, even
> if benign at present. Add a guard there as well.
>=20
> In p2m_pod_demand_populate() the situation is a little different: This
> function is reachable only for HVM domains anyway, but following from
> other PoD functions only ever acting on the host P2M (and hence PoD
> entries only ever existing in host P2Ms), assert and bail from there =
for
> non-host-P2Ms.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Thanks,

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

> Perhaps p2m_pod_init() could be invoked from p2m_init_hostp2m(), =
leaving
> all other p2m's PoD state uninitialized. Of course at that point the
> question would be whether the PoD pieces of struct p2m_domain wouldn't
> better move into a separate structure, present only for host P2Ms.
> Together with the p2m_pod_demand_populate() adjustment this might then
> better be a separate change ...

I=E2=80=99d certainly be tempted to do that kind of clean-up.

I would just check this patch in as-is, but if you really want to pull =
the p2m_pod_demand_populate() adjustment into a separate patch to keep =
everything in the same place, feel free to drop that while retaining my =
R-b.

 -George


--Apple-Mail=_AAC25DB9-F22B-402D-A36A-20165589E55E
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJG8eEACgkQshXHp8eE
G+28IAf+NBdmhEywP32CHHC9vrxrEr9fEOz/l2znG/ufxTJC/rX/b8DImF+Sfz1h
UuU+XvvsTpLYdqaYY3PlUseJFwtmIC24AvLIsOI2X+2d7YqaSugaNlE/Kp55oKrK
6H58J4aI1oWJyMFTpbbpNyRgWGcTu1oxohdIb+/nA8rJJhx3JsDo1wWqQDLkdNCg
E0MMDnxEfsFWoWsfZ7nTW1nXvTgaiXGytie2R77ZLJ9Z2j8tG+9nJT3lOv0QP1M0
mUr+quUmgsfszCbxk391LWPeXQyVir9+hSYT3A2foTX3yBAE9q25j4LM0R4gehBj
3yAxIsQbzuhhEnrwwctbyLyGz7ow9Q==
=kU+f
-----END PGP SIGNATURE-----

--Apple-Mail=_AAC25DB9-F22B-402D-A36A-20165589E55E--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 12:47:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 12:47:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297369.506530 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naGga-00037H-H9; Fri, 01 Apr 2022 12:47:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297369.506530; Fri, 01 Apr 2022 12:47:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naGga-00037A-E7; Fri, 01 Apr 2022 12:47:28 +0000
Received: by outflank-mailman (input) for mailman id 297369;
 Fri, 01 Apr 2022 12:47:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MEhg=UL=citrix.com=prvs=083735472=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1naGgZ-000370-DV
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 12:47:27 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e116578f-b1b9-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 14:47:26 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e116578f-b1b9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648817245;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=/ghLPcuEQlzyO+59i875mOmBX4Dw5c++yzK66eXr60w=;
  b=VK+QKM03S1RdfuMit6gXGiJ8OTh7dpoWQPQm1xsUx4dcjNqrcgvAVo/J
   qcZ27bTtPxe8D56AGwZeEg8pvWRLHI8eS2vVFQEhfp9DbWCWLvgHRctpf
   lano7+nJDt0bdxnl4FTcwMl+vxamN+ZekPGz+pkpaRppWfbBZRUF6muwp
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67662523
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Emb4Oq2WFfh2+6ZZofbD5VFxkn2cJEfYwER7XKvMYbSIYQITYwd3j
 TtIBzjCf73ffDO2KOnCW/2w909T7MDUxtU3HQI9+ythEyNEoJLMXInAIhyhMS3Nc5GZEB87v
 8wTOoHJIpk9EiHR+R3xbrGx/SUni/rZG+T2YAKo1lidYCc9IMt2oU4zy4bV+7JVvOVVIz9hm
 Pv5rpGBZwb6hzMoajtF5v7d8Uhksfqrs2NA4FFmPv4S5w6CmyEZAqxEKPDqJRMUYGX18s1W5
 Qrn5Ovklo8M1051UrtJqp6iLgtSBOS60TGm0hK6YYD76vR5jnF0g/5T2MY0Mx8N0W3Vx4kpk
 r2hiLTrIesXFvyU8Agie0Ew/xFWZcWqL5eefBBTGeTKp6H3WyOEL8dGVSnaDqVBkgpDOklc9
 ORwFdw4Rkvra9RaYl6MYrIEaswLdKEHNW6E051q5Wmx4f0OGfgvT0hWjDPxMfhZas1mRJ7ji
 8QlhTVHUhvPQi1UJkwuDIsjrtaKpDrvcDtVgQfAzUY3yzC7IA1Z1bHsNJzee8CQRNUTlUGdz
 o7E1z2nWFdAboXZkGfbtCL37gPMtXqTtIY6O7C/7PFnxnGOwGgaEDUdVEehoOn/gUm7Mz5aA
 xJLpHR08PJpnKCtZtanXBinnHKJhAJCBOZ7Eao8rzGt4bWBtm51AUBbF2UcObTKrvQeWjgCx
 lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85jrtZNt+FK++jvXuBCr9h
 TuNqUADa6471JBRkf/hpBae3mzq9sOhohMJChv/YG2qzzNieJWcY5W122n5z7VQL4CUZwzU1
 JQboPS24OcLBJCLsSWCRuQRAb2kj8q43C3gbU1HRMd4qWn0k5K3VcUJuWwleh81WioRUWWxC
 HI/rz+983O60JGCSaZsK7y8BM0xpUQLPYS0D6uEBjaij3UYSeNmwM2MTRPIt4wOuBJ1+U3aB
 Xt9WZzzZZr9If47pAdav89HjdcWKtkWnAs/v6zTwRW9yqa5b3WIU7oDO1bmRrlnsPPb/V+Pq
 4cOapbiJ/BjvAvWOHa/HWk7dw1iEJTGLcqu95w/mhCrfGKK513N+9eOmOh8KuSJboxel/vS/
 2HVZ6Or4AGXuJEzEi3TMioLQOq2Bf5X9CtnVQRxbQfA8yVyOu6HsfZAH6bbiJF6rYSPO9YvF
 KJbEyhBa9wSIgn6F8M1Nsel9tU4JEX23Wpj/UONOVACQnKpfCSUkvfMdQrz7igeSC2xsMo1u
 bq70Q3HB5EEQmxf4Az+ManHI4+Z1ZTFpN9PYg==
IronPort-HdrOrdr: A9a23:2ZK+JqPb1g8Gj8BcT3D155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjzjSWE9Qr4WBkb6LW90dq7MA/hHP9OkMUs1NKZMjUO11HYVb2KgbGSoAEIXheOjNK1tp
 0QPJSWaueAdWSS5PySiGLTcrYdKZu8gduVbI/lvi5QpGpRGsVdBnJCe2Cm+zpNNW577PQCZf
 ihz/sCgwDlVWUcb8y9CHVAdfPEvcf3mJXvZgNDLwI76SGV5AnYpoLSIly95FMzQjlPybAt/S
 zuiAri/JiutPm911v1y3LT1ZJLg9Hso+EzRfBky/JlagkEuDzYJriJaIfy+QzdZ9vfrGrCpe
 O84CvI+f4DrE85MFvF5ycFkDOQrwrGo0WSt2Nwx0GT+fARDQhKe/ZplMZXdADU5FEnu8w52K
 VX33iBv54SFh/Ymj/hjuK4HC2DBiKP0AsfeMMo/jViuLElGfdsRE0kjTdoOYZFGDi/5JEsEe
 FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4Go+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+
 CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSivCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5
 jFWEMwjx9FR6svM7z44HRmyGG+fIzmZ0Wf9ih33ekNhoHB
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="asc'?scan'208";a="67662523"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MSfQKTGuZAFbHUANbwx1UCtHDDEGNFxuhDZO4FTw84T3IyEmXkxODEuNm2lx1JwOR+6ts/3uH9qRNad2dK6A44AjUo5Cpx/8LmKbujwWLsywGSSLnq0r9dqOdOEowiL8xldez4+2SWNvPp82oSYIIOLIXXzzZxAVM2uPkTTzfAGkItW/u3PbUwxfyqKf2lxBd5uyiQnSpGN8azTqJJyPhpJycl85pDsdoKVEgklbasDx2tE30CbZ0YYoPSIpBXbhRhMG79oHP9E6XjpCZbMiHM4r8WjGALtdC4ZbI25GIZLyvWFZNzyZzkeEFsXyTYkZtKL/22FYFObVtYoCupiNhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I3CEogWUl/Iv8X8F0n37ujgeDvEvj/P33m3aUItDlyc=;
 b=O8wsQttnjxEC9jItiALWdl8TgMKgKPUEOrIFa/jR2jhhsDbr5O4ON85Ax2CiokSMREgCjlHvhJ9GeYFofa8FzQOYHW8EyJR8q35pn7gcZE4HFmagTkjcXfC83ScZaiuQRfksSffYdqPycTYbGIkDtUbwm0EuMsmLA8a0mNsM/1ZMFfdfzmRSymT/ZSLWu89PcKmsKia1YJHYAqoC8rHGj70cU5X4s+lJNdFb6zBqw2eWi3ksfa+awsymTpmIk1Ok5dJobBdsTCf52CSg9TYlcw/jvDpuF6eLed+ZHTQcleEZ5apSCx7/II95pv69N8lGDsUifuy+5cgEo0J1te9gmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I3CEogWUl/Iv8X8F0n37ujgeDvEvj/P33m3aUItDlyc=;
 b=dUwuB2pZgCcQUMdFvGBVV+Pu68nrA7Fx9GCS4/AYL0aQmBs2aST0M2x71aVyj+8uzbzQsRQ3dMBBTaofXZ0B1Q4TJ57CmOgEamuXgu2itroOPP+70TuGD1Q88j+Ot0bfEA85VucGwlpzOMa8pz6iZVKEyGy1rqSNTHPs4zN0tRw=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH v2 00/14] x86/mm: large parts of P2M code and struct
 p2m_domain are HVM-only
Thread-Topic: [PATCH v2 00/14] x86/mm: large parts of P2M code and struct
 p2m_domain are HVM-only
Thread-Index: AQHYKM3WxRAA+J80qEyImVUxoLvSJazbO6OA
Date: Fri, 1 Apr 2022 12:47:20 +0000
Message-ID: <A88AF737-14B3-4EE8-BF36-5D68F9FFD780@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 463fdb30-7c73-4b5f-c6bb-08da13ddc2de
x-ms-traffictypediagnostic: BN8PR03MB4898:EE_
x-microsoft-antispam-prvs: <BN8PR03MB4898EB15AC17521E0CD9166499E09@BN8PR03MB4898.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: p953Ex7szBFMzAIex5jPq8yeI9KJbNW/Q3ColywrRmeDZkEJ6/0+HIZSf9/b70e4QdIwLma4Zevb+WZWBknRWU2FPVyp38kayg+nR7YTutUP3Us8ge0BY9Fs4YPTmIhKMu9mLNEm+f1SdGLx4Z4ntJTwPr0tUiwvbz90TYbaxjapjXaAZzaSDT4N0AD2+LuNWwfOr5rdDE7zqC+JeSAIV/W0XvGVxisWnGa0z2T4SjazdLkuJ6pO/0lWmWni1AjfC9oQzANhUekfty6HFiqnmbtUsZqN/X2Duh/zIDXYKAFC+NV6H6vdNxSpEy6lRy8nJTrzs2VIHcQ3ZQXiy2SvmSc1mCu/3mbT19e3LjgiFRrBGl/5M7z0MCZiBU5TrkEz/ZDT89c2G8D58JXUos0OpPDoHT3B3U+RFyCkVx6BosfNQRdy9WNNwrPLxCYcGQtyqS850q5vAlbkt//Cso+8EIZOf/Dp1jfjjFOz42whcaLL/pccxvn7TgG3U1hPpOqAM71aJLkC0A/JfncS6lGQhX2IxbDyRfDNEQjlh/7Zym19mBlhaDDw57mUsgQjC5niBvk+/dSTCNzmChSxFyRpx5tor8NZ+z/FLn60+9IFYkuvyn2w9Rlf43GoB+0t/vMpQTvCXJdoh2sBMef8EOkcFPPKFP5RgPMD6WQaVIvxOFuGNV7CHlreb8WLN1irXjiKjE0Xg3UXGwtgIJGKmfWXEJ9mjDI4jZOTCmHa2LcbxKkPXf3u1MCf9G6rO9E9U2WN
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(33656002)(316002)(83380400001)(76116006)(66556008)(66946007)(5660300002)(6916009)(6506007)(54906003)(8936002)(86362001)(66476007)(2906002)(53546011)(36756003)(71200400001)(2616005)(6512007)(107886003)(122000001)(38070700005)(38100700002)(4326008)(8676002)(99936003)(82960400001)(508600001)(66446008)(26005)(186003)(6486002)(64756008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aUpJL0tmQkhCVU1xWjc2YzIzZUIzcGVjQmVnbWJJUlg2STVTeUZaRjlSVUhS?=
 =?utf-8?B?ZjFXeXl0a2Y4UFMrVzkyYlVOOThJTmthdHFqWVJ1K3JtK3JZM1phbkFYc2FB?=
 =?utf-8?B?VjZCam41V1BOV0RkOExTZ0lnS1RWdjBxcXZidndzaWQvVExtbmRucnVOUzBt?=
 =?utf-8?B?RXFyd2hwTVNhVE0rT2lHb2lkRGJkNkFBMDhYR0V1N3djSkJRdGVGRUdiZGVz?=
 =?utf-8?B?ZFQ5cFdLOFN1MWxlYzJ4M2pnMDhaaElYbzVsMStlOTIvUlplWGRlMkpKTDNv?=
 =?utf-8?B?dzlic0tCQ0RCZEhseGY0NkJ1RVVGejVPT2pJR2RSMklaOE1mZ0FkNEd2SCt1?=
 =?utf-8?B?NDdtZTdOUFpRdzY0NkxoOS85WitSME5FS3B1YkFtMzJ0YklXanhPUDVMeWJj?=
 =?utf-8?B?dFU3SXdKM3RhYVNTaE1pZG1tU0FYVXl5Y2FLQ0RDRWQ1OXVQVUY3Yng3UUxq?=
 =?utf-8?B?MGk1YzZiQzVJb2RTSmtLSTJxQ2VMMG5mc1E1OXZjdXFpbHo0UFBycy9haHBG?=
 =?utf-8?B?Z2pNYVhtQlU3KzN1R2hNZDZBZGgrWW9PbU1oWkRlZ094cWFOMGh6cnNQSk82?=
 =?utf-8?B?djM1WmdBMGV0UHhpU0JuVEx0Z216bnVhOUxGODJDbzZDZlJuRzU4a2tROEky?=
 =?utf-8?B?RGN0VGd4TEFUKzg1aEd4TWJNWDBxSUc3eDIyby9WZWZQQXJoUjhiMDM3OWds?=
 =?utf-8?B?TkliaXFsK2JVdldNVEhOdUtKNDZpa0JQM0FMMGJjUGZ3SmZPOUcrYzRMMUJT?=
 =?utf-8?B?SDhqa1hML0xEdU1OMnJWWUJYTWZwM3I0OHE1a2RjZWs3RTZXeHN4U3FTNWwr?=
 =?utf-8?B?bitSdmdySXBSYWpTTmhwN3gzMlJMbzZLZEJ6b0t3U2RaY0RaU00vNHZiTFFS?=
 =?utf-8?B?UExuUno2QUJPTFF4elg0cmlnNmpINDNHWDZRU1BZU1JVVXZCcUhjcm1PUmRv?=
 =?utf-8?B?MkVCUFJHSUNwYS9VSGoyTTFEQlZRYXlVa0VTdGlOa0R0VFh5RVVCaHpwQzlR?=
 =?utf-8?B?em1VcVoxV1QrSmZjazFKOFNaR0xBZFg2Qnc2UGpPbE80bUl1aDd3dDRSUHdL?=
 =?utf-8?B?S1R2UFUxTlF3cTBId0lKajVMNmZsVDZYRXpENFRMK21GR2pNS3VINGtRNzB2?=
 =?utf-8?B?MjVmNWZnZXRxcm1YQlVPa3k3MEZOUGxTWS9NZkVWd3ZhdDd6U0l6TU0yK0lW?=
 =?utf-8?B?dmFubFR4YXIxaUpUYklWNFNPbDNJLytieGtacmlJNDFpdVRPRW9HYk1rWGE0?=
 =?utf-8?B?bWFJMDhGN01VcCtOOGZZSEZaQ3AzVlFlRnNuNVA2T1kxWHNnUUo0VzRYZVhU?=
 =?utf-8?B?bDdoT3hRZTlGem93R3ZDWWhlM2xGSS9jSnp3VzBUUmpOUEthWklwWFBhRFdw?=
 =?utf-8?B?cTh4QWhncnVoR1F6dFplMFM2REtDRmRtTHo0WEhFKzlHeWpQMFFQaHRqd21S?=
 =?utf-8?B?R0NyS0oxeG11STJpdyt4Q0tNUWxma0tpUndtM1NzT2JSaEFhNkVMT2NRSDg3?=
 =?utf-8?B?cmxPbjFxVUVuTWY1YkNlcFNoVmJOTXpaRUlQUFp0Tjl6VVZ2UTNQM0k5QS9n?=
 =?utf-8?B?UGlack8vLytoTEtsRTdPSGZMYnMvd0o1WnFOUnNZNTNVVGdJcW92RHZmUnhk?=
 =?utf-8?B?a2ptZTdHblBXbnU4aFAwbG9KY1JPY2NUeFdOU2R3UWxEU2pwN29MbW8wLy9t?=
 =?utf-8?B?YUNaNUpDVTA5WkY5OEMrQjM3UmFUbm04UzZ5ZzBQQkp5eTZxR3ZQMTRNTnBI?=
 =?utf-8?B?MmJFZFVWcElwTTFCczJxb1ZWWHpxWWExeVZrSlBCd2tlbHpOUUwweGJkeUEv?=
 =?utf-8?B?RTVIU1paVlhxK1IyclN6UFNGcTR2OUNHZWM2aGxyMmhNdGpmcVEzMFpSekpt?=
 =?utf-8?B?b1NJajdKTWRJVUx1VjJLZURlcnJHUDhuYU94ZWhYS3VSOHBVS3hJYUxqSnZ5?=
 =?utf-8?B?M1FkR0pVdmVLMWZSWDlRbG1wRTZSeTBpRVZyV1ZsdGpGV3djM2JycktSOWhO?=
 =?utf-8?B?NTZvZzRPNHBBb3NwaXRkZERPTm82MlRvMnRkMVpxcE5DTU5SMHNhaTBjVWsr?=
 =?utf-8?B?TXNNNk15enViMXpLWWFIKy9MeVp4cGcxV0grWVROaTRHbTZKTXFpdmwzeDVv?=
 =?utf-8?B?RUtHSFFKRUlrcEhaUjFiNXdzTnFkdmlTZlhHN2RiNHVXZG5lMFAvYmMxMWg0?=
 =?utf-8?B?cksxcVlxcENnRjNaL25kTFBpSkRZRlh3Qk5OUm9SZHpSVEtNRFBJSTgxZXZk?=
 =?utf-8?B?czExbm91QlRMRkltbXhTQzRjWmtpbXdTL0tVbFA3eEJTMWZIWjZwWmZsOEgw?=
 =?utf-8?B?ZGNSQmpiQVFGWnVRaG43NVYzaTBLci80Z0RndkhRV2lReFRnbUJYOFRrcnUw?=
 =?utf-8?Q?Z6hMBlkhiPx/eMm7u50P1szk77O+ap2OiD9kS?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_C24A3BBE-6CA9-4A03-B927-C72DAE569822";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 463fdb30-7c73-4b5f-c6bb-08da13ddc2de
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 12:47:20.2708
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: l1db9EgJJnTx6Q91riKJHWtre7VSx1L2awr6tOWb3b796LcwKc732/UgM/88x6Yi085Z3iU9AuDvEc/jMO75k/r5Tny3vWdamjoh3VuKdFo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4898
X-OriginatorOrg: citrix.com

--Apple-Mail=_C24A3BBE-6CA9-4A03-B927-C72DAE569822
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 23, 2022, at 3:55 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> The primary goal of this series is to leave p2m.c with, as its leading
> comment suggests, just code for "physical-to-machine mappings for
> automatically-translated domains". This requires splitting a few
> functions, with their non-HVM parts moved elsewhere.
>=20
> There aren't many changes in v2, mostly from re-basing. See individual
> patches for details.
>=20
> 01: x86/P2M: rename p2m_remove_page()
> 02: x86/P2M: introduce p2m_{add,remove}_page()
> 03: x86/mm: move guest_physmap_{add,remove}_page()
> 04: x86/mm: split set_identity_p2m_entry() into PV and HVM parts
> 05: x86/P2M: p2m_{alloc,free}_ptp() and p2m_alloc_table() are HVM-only
> 06: x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
> 07: x86/P2M: split out init/teardown functions
> 08: x86/P2M: p2m_get_page_from_gfn() is HVM-only
> 09: x86/P2M: derive a HVM-only variant from __get_gfn_type_access()
> 10: x86/p2m: re-arrange {,__}put_gfn()
> 11: shr_pages field is MEM_SHARING-only
> 12: paged_pages field is MEM_PAGING-only
> 13: x86/P2M: p2m.c is HVM-only
> 14: x86/P2M: the majority for struct p2m_domain's fields are HVM-only

OK, I think every patch has an R-b from me on it now =E2=80=94 let me =
know if I missed anything.

 -George

--Apple-Mail=_C24A3BBE-6CA9-4A03-B927-C72DAE569822
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJG9FcACgkQshXHp8eE
G+2EjQf/eZle929xBtk0cvFvcWwegfNOOZ45bB0l0J6rU8Dr0dYWbnPnOJdcoAuX
g1Ux6sxbV+oJ5FCe57ZiXtYpfLYAHzmPPYm7YLT5vrtYojTpa9F6X0I6sMCjdzSO
nucn4V8VA/RRFIOPVs9svC4nZi3XAelcj3cI/zolwY0IGANJGjdbyPbVLdfU9noz
rxci7yx+pzfaVEvbCKO2FHc15fixWniE1iT2tkNa3aZJBUzefaBLmu2O1huRun5Q
cnk1EDV+fI84XJS3AW4mIyEvzW2+/mJuRHfONjio1yfLTlLCdMzvpwEgs79DPH4d
1B9MD/38JqbOTW/RMtfPToABiuwtXQ==
=5jBM
-----END PGP SIGNATURE-----

--Apple-Mail=_C24A3BBE-6CA9-4A03-B927-C72DAE569822--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 12:48:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 12:48:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297372.506542 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naGi0-0003i6-To; Fri, 01 Apr 2022 12:48:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297372.506542; Fri, 01 Apr 2022 12:48:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naGi0-0003hz-QE; Fri, 01 Apr 2022 12:48:56 +0000
Received: by outflank-mailman (input) for mailman id 297372;
 Fri, 01 Apr 2022 12:48:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Yu3J=UL=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1naGhz-0003ho-ET
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 12:48:55 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16692a1e-b1ba-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 14:48:54 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0EBEA1FD00;
 Fri,  1 Apr 2022 12:48:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C973A132C1;
 Fri,  1 Apr 2022 12:48:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id +OzIL7X0RmIJQwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Apr 2022 12:48:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16692a1e-b1ba-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1648817334; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=aCbKnOwWP+SgmWDyXMNQ5sZD4/DUD6cpYX9yiGymmrg=;
	b=e7cf+ZmG/RWQSo4oRMa085htb9aCP/gP9TpKAoUmFpB0EFegvpDdndahtvT94JdRRbDU7x
	Rr/f2QYTgVUD6RbhC/0mdPrejNGjZ40L2Db61P2ICaRwCURelRyq+XWIbKpCkTIiphn9xh
	E/R8emvSvnjOEhAXRJpl8RCI5jU9Op4=
Message-ID: <ccee11d6-a62d-6b37-d51a-476b6e23aeb7@suse.com>
Date: Fri, 1 Apr 2022 14:48:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 7/9] xenstored: send an evtchn notification on
 introduce_domain
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-7-sstabellini@kernel.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220401003847.38393-7-sstabellini@kernel.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------C9Ax5ol14yz0s7yi2WOh6tvI"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------C9Ax5ol14yz0s7yi2WOh6tvI
Content-Type: multipart/mixed; boundary="------------UhShM0QBLutOgd398GNoMe0Z";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
Message-ID: <ccee11d6-a62d-6b37-d51a-476b6e23aeb7@suse.com>
Subject: Re: [PATCH v4 7/9] xenstored: send an evtchn notification on
 introduce_domain
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-7-sstabellini@kernel.org>
In-Reply-To: <20220401003847.38393-7-sstabellini@kernel.org>

--------------UhShM0QBLutOgd398GNoMe0Z
Content-Type: multipart/mixed; boundary="------------bpUBW6oRs0TwpT5vYT0hJxNj"

--------------bpUBW6oRs0TwpT5vYT0hJxNj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDEuMDQuMjIgMDI6MzgsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gRnJvbTog
THVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IA0KPiBXaGVuIHhzX2ludHJv
ZHVjZV9kb21haW4gaXMgY2FsbGVkLCBzZW5kIG91dCBhIG5vdGlmaWNhdGlvbiBvbiB0aGUN
Cj4geGVuc3RvcmUgZXZlbnQgY2hhbm5lbCBzbyB0aGF0IGFueSAoZG9tMGxlc3MpIGRvbWFp
biB3YWl0aW5nIGZvciB0aGUNCj4geGVuc3RvcmUgaW50ZXJmYWNlIHRvIGJlIHJlYWR5IGNh
biBjb250aW51ZSB3aXRoIHRoZSBpbml0aWFsaXphdGlvbi4NCj4gDQo+IFRoZSBleHRyYSBu
b3RpZmljYXRpb24gaXMgaGFybWxlc3MgZm9yIGRvbWFpbnMgdGhhdCBkb24ndCByZXF1aXJl
IGl0Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogTHVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFp
bC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFuby5z
dGFiZWxsaW5pQHhpbGlueC5jb20+DQo+IFJldmlld2VkLWJ5OiBCZXJ0cmFuZCBNYXJxdWlz
IDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdy
b3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K
--------------bpUBW6oRs0TwpT5vYT0hJxNj
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------bpUBW6oRs0TwpT5vYT0hJxNj--

--------------UhShM0QBLutOgd398GNoMe0Z--

--------------C9Ax5ol14yz0s7yi2WOh6tvI
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJG9LUFAwAAAAAACgkQsN6d1ii/Ey/B
2wf+MJ2yRCJETehZ3OCGpENwk+Ezld7pjZoZnU69cX1YUDwhN4IC23ywLP0xESe5we5iTfEtxn/A
6h/2ZrMJCix5EJm5sUm7NwO9Kb0E0fXZpGePUCJTzpcgOV38aLVBtCzY8GtCMUWys2whaOORW09k
FRyfcssTO11RkXjChXvc6sYvE0XBBinthH+hgynDe4z4N7rfwhCao36OxCNyN4FncPS6osK/V61y
E2ys8nF3hFCch145chhO50JWUGiHp1lT61WfcGsf6fMpfNPDJnYpK/vBXLkvj5ENRmL0v+/zMWlo
mkSkiUZsottcbksvrGbuz8tbcma3b1Gm7SZqTOPdwQ==
=PjvI
-----END PGP SIGNATURE-----

--------------C9Ax5ol14yz0s7yi2WOh6tvI--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 13:22:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 13:22:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297378.506552 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHDy-0007nI-EX; Fri, 01 Apr 2022 13:21:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297378.506552; Fri, 01 Apr 2022 13:21:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHDy-0007nB-Bd; Fri, 01 Apr 2022 13:21:58 +0000
Received: by outflank-mailman (input) for mailman id 297378;
 Fri, 01 Apr 2022 13:21:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i0v6=UL=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1naHDv-0007n0-HW
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 13:21:56 +0000
Received: from sonic308-54.consmr.mail.gq1.yahoo.com
 (sonic308-54.consmr.mail.gq1.yahoo.com [98.137.68.30])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b04019c4-b1be-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 15:21:51 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic308.consmr.mail.gq1.yahoo.com with HTTP; Fri, 1 Apr 2022 13:21:49 +0000
Received: by hermes--canary-production-bf1-665cdb9985-6p9bt (VZM Hermes SMTP
 Server) with ESMTPA ID ffbb55cd7e7ff41fe82b03603fe8d708; 
 Fri, 01 Apr 2022 13:21:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b04019c4-b1be-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1648819309; bh=753d7ijm7UQ3Hu5BfbfmQK4mp7ufvKUNuW4ug8DrL6U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=iW0siN0lsrLXIClWiyfhHZTiAF33RCyNmmnEGyDtj/rRdBjmQq8vhGBqW+28+DxK0AuiPh+b1/Q4p8+eRFmMbchpfvgHsqMKEKJmZujNPosaJaJkYMeZfw0l8aKOJO6S2TIWiRev8c/weAOAHlxeruQHy8As3wQEuA3+N1Tm3Q/2/XiARrrJV4WgBMgrsz65tFqIPZVMWFttWKKMo3OmlXlon1KwvTuivOOop5rR9ob6BWS/AnS+EjkCcOrTj2A1vMvFgq6NFEsg2pCbTwWd9SnFpAJHBTzoV/9xh0dfnS3WMPjOEXS74/GqoGSUppPxnOLXwCqXxdRgweWgZhAavA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648819309; bh=ZJ/U/vMIeOb4mn3U+q3FX4+aJjAjTir8UraGPr9DQmF=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=qHdISB8JFQKkO/Bpiswhw47e8ocj7QlnYu8qwZEZ81lSgeFC/U0pG8bLJ097/iy25lEIzuBN2ByQV9clLRmrWw0QFTegRttriIzRQUGfygmshpnuzwFCruLrLK15bYN8yWCcL+tc4xJnTXLJ13ZTdstSMvj9K1hitwO3na/2GADr6xMDfLp+fdyzzrafZwNaFQhzppA+9BSCYzYHCMEeGmgWYtx1XMb0HkkEud/gSHgtzWmqbDBQc+IRvdtWxBuHk5XRtQ7Qeia5/HHBCHYvZoYPZRu9VzReV1A6Rrv1BlQUVY/UxKjzdeqBGLK/OU5Ym4sNNxqndGww9Z29b0ty7w==
X-YMail-OSG: TnVa9PoVM1nUor48hLADRbR75l9AUwzWQ.6Qq5zsOeTwijYp.lU8ct63uf3cQr9
 dEEhUmXmo._KOUDVLlfZN2f5qpl0s8dtdaM3V.4dLQbxaXp.6HBPN39WCqEZWiMkl7Sm4zwLpela
 zsbOTg55_ByFywlaH4wH6U4jf2kPNVDVtGA.nj_gAbTqSpekqAOA2hFL5ZoMPuBdhyC_H2noVbDK
 BvxDSA5bPSBdh_VP2C3v2r3bpysJFqF92zaV8DmlL.maNOoCZatUFlqZK9rh0mqV4oaOc0BQvVFE
 hEGDizly.lwI7RzfiFz27lUDTDQ.Xm9_.5fclOzBhvKr5u7wKX.5KsmPNvrJ97XeVXOt7p47OvsX
 9wjOFRey6QAW.q9o3QCvdFuP9tjwL68Fx5I.wxu2mtRuvvjrI2hUEwESEUYnrA7zT.TPkfn2p3s.
 ixJ8AzK4AiIzlEfm15zQ7HfmeAkeHpCfvf_RlK90VNZEqqWEuC5mN32AWr86fyyiTgZhDNdb52Qx
 nOctxGV5vSu9BBcwsI5gESGGGV48TYP.utg_iZw5u6Xrif6QDyswKO6kOw7yeVCEmTU6JVoJ2tOX
 11ph_ybPo0iymjkI7yjzpGqesvYVwwmIlnwuoe5YFHjAt4p98gSLbjLQt_RowQPH1EsTkT8tNPQR
 F5trc6hON8_bLe1NAkVmfGa1II84ZULSspC0AJMLHtDjmFG2yY0YF5olBqh76ddhkK0aMcjB_7TD
 W2in7Y8nEb.JB6v4qusy9AC.X1pEicQyxUjeJJtYM5E_CXEEN64K0OFnZc9wBIbxxvkOks8Be.Lb
 4l2wYa4NWnSsjR9jLWXW4eRvpIYVUBeICp7BOWlyJTHNJC5O5dpyx0hh3VBGQffQOoB2rFI_aEFj
 ttGDDhaH3Nnmevz11oq6J1cjUv369gwo2ul2x0pneKXuPygRITNdzWB_p0uq8OxszZM4ZreViWS0
 .Q9sl.14wm7a__.7Auh3QpDy.bTXJBt69jwM.n79CfrC3tJJgOIykfzFRQ7GGhw9Px5c8yi1y2vl
 5wE5z7UT5jeecTV.ztziI8zyyYyu8Wo2zzt894QKyV7SmsMrzNgTWAGDbwcWNc4Fx1TvqHM_VnIz
 E7CzDIOa1cXj4Y8YYWFVjudnJW.THV.IWZ.vUDsx5zUCnXLkDuMbPxOWVMKiA5pFTKYeSSyHeL.n
 GELkJ0cyZ7JYDMkIXobbibeIVelnnMmaB.RZZF_XJWAsQSeAjHnhvp9U1Svf74gvCzsbITYvoV2L
 sgjXrk9pefblbYa5vjw3X2a7aaYnWhQH7GVjcAECkekZpiLpCn5rJhiQPyPJ3kaLwBzH2aCfZdMW
 mKJmwvwH8IJ_6nEtggHX0NBJIAhVp3c5upU29qQ27TajAdRLYiG.9pZ3vqMkDP.Z0VxR_7GKEpuN
 79UMnLg1RGIw2yo8jBsVJMWRvfT5iIXmkzptcEKLdBU.H.Y_VMs1jWsly1RUnvQWD3mTHfZS5ALz
 a1srehnF.ZBs27kq34oqwHpDgZOUJtMlrfXBABtn1qrEcvNosxuFwOKBtRcTtbZp4.pmYGrRsy6O
 WJFtlj8G.49M.HORhRwTc2JgLQVhI0evBjPifSTb1KevB37azDJdSW2XWZY9FLQLhWO7pKj4zmLb
 agpZIdjCGEYzBdxH7.pz1bREqTbYNzaLTrsl77HmVJRKRHleWUhshQI7pTcsQICaGc5rJx7AuGXl
 BYm3WRKFV4NFe.okhZVSysIjKmqUKWznMmfWKbhXFl2Nxv02AuBTpVEXm3Kvf5K2camcMmfuRqzp
 GUJeAfnzPfTevwA96P3siIwheIvDRvdwbS0t89oalBxEI6QE3.QZ73rYgTfXa8PG1Il_ceeDy9Qu
 Vxd_CTyhwBL4YOV0uNtxwKlj8jCbgkWue3xPSsooGRKMK0RYcF9qAgNqxEARLK_0EeD2g3VnxuZs
 yxnlMv74bFdgz9DMNuSFE8uuknmKm.opMoiCMBvF_zNzRLxXZUT2ylUXiINFVFpl603bUgCA6b7D
 wnUIRc63VffyXs64fKJOe1Gc55WE8YQR4EnfCbVbT0fzUX7c3LDUwYMpHTG9sF6aj6PFmpnH3jkY
 Ds7k1K_aAJVWlwA97YVpSikpsd98i9_nkMtBm1zfy2mcfDzsHLBhwuc0oaTIM8I0enbP7waUT7Z7
 _JeAKHO3wxf9g4mzHLsPldMC2DHjy8_vuoJ4BRsVwJCUU2U37uj04CbFgeDSvl9ltxxRqY5OzPOW
 f4_7.9XhfbzwbiQ9PkF0jzObqWTg-
X-Sonic-MF: <brchuckz@aim.com>
Message-ID: <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net>
Date: Fri, 1 Apr 2022 09:21:41 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access
 to Intel IGD opregion
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
References: <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz.ref@netscape.net>
 <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz@netscape.net>
 <78ce5809-8df4-c94e-4313-fffb1b86b771@suse.com>
 <CAKf6xpsN+uJ=AyxtrnOrQrynFL=dwC=DdT7DHnK=wx9UFtdUDQ@mail.gmail.com>
From: Chuck Zmudzinski <brchuckz@netscape.net>
In-Reply-To: <CAKf6xpsN+uJ=AyxtrnOrQrynFL=dwC=DdT7DHnK=wx9UFtdUDQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 3784

On 3/30/22 2:45 PM, Jason Andryuk wrote:
> On Fri, Mar 18, 2022 at 4:13 AM Jan Beulich <jbeulich@suse.com> wrote:
>> On 14.03.2022 04:41, Chuck Zmudzinski wrote:
>>> When gfx_passthru is enabled for the Intel IGD, hvmloader maps the IGD
>>> opregion to the guest but libxl does not grant the guest permission to
>>> access the mapped memory region. This results in a crash of the i915.ko
>>> kernel module in a Linux HVM guest when it needs to access the IGD
>>> opregion:
>>>
>>> Oct 23 11:36:33 domU kernel: Call Trace:
>>> Oct 23 11:36:33 domU kernel:  ? idr_alloc+0x39/0x70
>>> Oct 23 11:36:33 domU kernel:  drm_get_last_vbltimestamp+0xaa/0xc0 [drm]
>>> Oct 23 11:36:33 domU kernel:  drm_reset_vblank_timestamp+0x5b/0xd0 [drm]
>>> Oct 23 11:36:33 domU kernel:  drm_crtc_vblank_on+0x7b/0x130 [drm]
>>> Oct 23 11:36:33 domU kernel:  intel_modeset_setup_hw_state+0xbd4/0x1900 [i915]
>>> Oct 23 11:36:33 domU kernel:  ? _cond_resched+0x16/0x40
>>> Oct 23 11:36:33 domU kernel:  ? ww_mutex_lock+0x15/0x80
>>> Oct 23 11:36:33 domU kernel:  intel_modeset_init_nogem+0x867/0x1d30 [i915]
>>> Oct 23 11:36:33 domU kernel:  ? gen6_write32+0x4b/0x1c0 [i915]
>>> Oct 23 11:36:33 domU kernel:  ? intel_irq_postinstall+0xb9/0x670 [i915]
>>> Oct 23 11:36:33 domU kernel:  i915_driver_probe+0x5c2/0xc90 [i915]
>>> Oct 23 11:36:33 domU kernel:  ? vga_switcheroo_client_probe_defer+0x1f/0x40
>>> Oct 23 11:36:33 domU kernel:  ? i915_pci_probe+0x3f/0x150 [i915]
>>> Oct 23 11:36:33 domU kernel:  local_pci_probe+0x42/0x80
>>> Oct 23 11:36:33 domU kernel:  ? _cond_resched+0x16/0x40
>>> Oct 23 11:36:33 domU kernel:  pci_device_probe+0xfd/0x1b0
>>> Oct 23 11:36:33 domU kernel:  really_probe+0x222/0x480
>>> Oct 23 11:36:33 domU kernel:  driver_probe_device+0xe1/0x150
>>> Oct 23 11:36:33 domU kernel:  device_driver_attach+0xa1/0xb0
>>> Oct 23 11:36:33 domU kernel:  __driver_attach+0x8a/0x150
>>> Oct 23 11:36:33 domU kernel:  ? device_driver_attach+0xb0/0xb0
>>> Oct 23 11:36:33 domU kernel:  ? device_driver_attach+0xb0/0xb0
>>> Oct 23 11:36:33 domU kernel:  bus_for_each_dev+0x78/0xc0
>>> Oct 23 11:36:33 domU kernel:  bus_add_driver+0x12b/0x1e0
>>> Oct 23 11:36:33 domU kernel:  driver_register+0x8b/0xe0
>>> Oct 23 11:36:33 domU kernel:  ? 0xffffffffc06b8000
>>> Oct 23 11:36:33 domU kernel:  i915_init+0x5d/0x70 [i915]
>>> Oct 23 11:36:33 domU kernel:  do_one_initcall+0x44/0x1d0
>>> Oct 23 11:36:33 domU kernel:  ? do_init_module+0x23/0x260
>>> Oct 23 11:36:33 domU kernel:  ? kmem_cache_alloc_trace+0xf5/0x200
>>> Oct 23 11:36:33 domU kernel:  do_init_module+0x5c/0x260
>>> Oct 23 11:36:33 domU kernel:  __do_sys_finit_module+0xb1/0x110
>>> Oct 23 11:36:33 domU kernel:  do_syscall_64+0x33/0x80
>>> Oct 23 11:36:33 domU kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xa9
>> The call trace alone leaves open where exactly the crash occurred.
>> Looking at 5.17 I notice that the first thing the driver does
>> after mapping the range it to check the signature (both in
>> intel_opregion_setup()). As the signature can't possibly match
>> with no access granted to the underlying mappings, there shouldn't
>> be any further attempts to use the region in the driver; if there
>> are, I'd view this as a driver bug.
> Yes.  i915_driver_hw_probe does not check the return value of
> intel_opregion_setup(dev_priv) and just continues on.
>
> Chuck, the attached patch may help if you want to test it.
>
> Regards,
> Jason

I tested the patch - it made no noticeable difference. I still
get the same crash and call trace with the patch. Actually,
the call trace I posted here is only the first of three call
traces, and I still see all three call traces with the patch.
The patch is harmless and the i915 module with the patch
works normally when it can access the intel opregion.

Regards,

Chuck


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 13:31:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 13:31:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297383.506564 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHNK-0000t2-HL; Fri, 01 Apr 2022 13:31:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297383.506564; Fri, 01 Apr 2022 13:31:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHNK-0000sv-DS; Fri, 01 Apr 2022 13:31:38 +0000
Received: by outflank-mailman (input) for mailman id 297383;
 Fri, 01 Apr 2022 13:31:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naHNJ-0000sl-Ia; Fri, 01 Apr 2022 13:31:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naHNJ-0005mQ-7J; Fri, 01 Apr 2022 13:31:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naHNI-0003jG-Ns; Fri, 01 Apr 2022 13:31:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naHNI-0007yL-Ms; Fri, 01 Apr 2022 13:31:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Qylo4pJxEWcbaTYl9cyTSHm7dAyD01r3uxZ4X5JfWjA=; b=NZrDNcbCZvI3rY53t3+GGl2EDc
	wgiOPKXS9AflxMzuAC9E9fDG1X42809yXpK7OZAtAxlWzNtc3sT78ySol6Y7p5gTBJ+oQQPd8fp3W
	BAuR4fH2q/qtQW35Cl/AnRmy9h2DPJ+SYTLeQz0dMl66VjokUXSolxR7N26hVdwVUyrk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169072-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169072: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=cace6c6f3aca7b88afc42995f90bbefb37a0ed57
X-Osstest-Versions-That:
    qemuu=aea6e471085f39ada1ccd637043c3ee3dfd88750
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 13:31:36 +0000

flight 169072 qemu-mainline real [real]
flight 169109 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169072/
http://logs.test-lab.xenproject.org/osstest/logs/169109/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail pass in 169109-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169017
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169017
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169017
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169017
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169017
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169017
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169017
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169017
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                cace6c6f3aca7b88afc42995f90bbefb37a0ed57
baseline version:
 qemuu                aea6e471085f39ada1ccd637043c3ee3dfd88750

Last test of basis   169017  2022-03-30 08:14:57 Z    2 days
Testing same since   169072  2022-03-31 15:37:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Markus Armbruster <armbru@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Victor Toso <victortoso@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          fail    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   aea6e47108..cace6c6f3a  cace6c6f3aca7b88afc42995f90bbefb37a0ed57 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 13:36:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 13:36:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297391.506574 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHRd-0001XP-3f; Fri, 01 Apr 2022 13:36:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297391.506574; Fri, 01 Apr 2022 13:36:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHRd-0001XI-0k; Fri, 01 Apr 2022 13:36:05 +0000
Received: by outflank-mailman (input) for mailman id 297391;
 Fri, 01 Apr 2022 13:36:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naHRb-0001XC-Lj
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 13:36:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naHRY-0005pt-Oa; Fri, 01 Apr 2022 13:36:00 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naHRY-0003Qj-IB; Fri, 01 Apr 2022 13:36:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=VEyII3VL7hdfsz6IMAVFET3sFlCb63Q4mu9gWhPMCEs=; b=eOB7OmJD3jRjo+TjhgcneR/Lnu
	YrG3mCx6N3qA8n7oG5QB8tO0gi9/S8Ev7nE23Gmkv4z0RfPrdDfmx9cRcoNfDdG8Lj52vjl6ph+KI
	iR87iEd9MB06io/diD4iIY35yrFzWe8/MjmBYmO3aXs1ThUAlVM/WYspeEVTxeX6TGOk=;
Message-ID: <57312254-b599-6de5-04aa-f88907c49163@xen.org>
Date: Fri, 1 Apr 2022 14:35:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
To: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
 <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Juergen,

On 01/04/2022 11:46, Juergen Gross wrote:
> On 01.04.22 12:21, Julien Grall wrote:
>> Hi,
>>
>> I have posted some comments in v3 after you sent this version. Please 
>> have a look.
>>
>> On 01/04/2022 01:38, Stefano Stabellini wrote:
>>> +static int init_domain(struct xs_handle *xsh, libxl_dominfo *info)
>>> +{
>>> +    struct xc_interface_core *xch;
>>> +    libxl_uuid uuid;
>>> +    uint64_t xenstore_evtchn, xenstore_pfn;
>>> +    int rc;
>>> +
>>> +    printf("Init dom0less domain: %u\n", info->domid);
>>> +    xch = xc_interface_open(0, 0, 0);
>>> +
>>> +    rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN,
>>> +                          &xenstore_evtchn);
>>> +    if (rc != 0) {
>>> +        printf("Failed to get HVM_PARAM_STORE_EVTCHN\n");
>>> +        return 1;
>>> +    }
>>> +
>>> +    /* Alloc xenstore page */
>>> +    if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) {
>>> +        printf("Error on alloc magic pages\n");
>>> +        return 1;
>>> +    }
>>> +
>>> +    rc = xc_dom_gnttab_seed(xch, info->domid, true,
>>> +                            (xen_pfn_t)-1, xenstore_pfn, 0, 0);
>>> +    if (rc)
>>> +        err(1, "xc_dom_gnttab_seed");
>>> +
>>> +    libxl_uuid_generate(&uuid);
>>> +    xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid));
>>> +
>>> +    rc = gen_stub_json_config(info->domid, &uuid);
>>> +    if (rc)
>>> +        err(1, "gen_stub_json_config");
>>> +
>>> +    /* Now everything is ready: set HVM_PARAM_STORE_PFN */
>>> +    rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN,
>>> +                          xenstore_pfn);
>>
>> On patch #1, you told me you didn't want to allocate the page in Xen 
>> because it wouldn't be initialized by Xenstored. But this is what we 
>> are doing here.
> 
> Xenstore (at least the C variant) is only using the fixed grant ref
> GNTTAB_RESERVED_XENSTORE, so it doesn't need the page to be advertised
> to the guest. And the mapping is done only when the domain is being
> introduced to Xenstore.

And we don't expect the guest to use the grant entry to find the 
xenstore page?
> 
>>
>> This would be a problem if Linux is still booting and hasn't yet call 
>> xenbus_probe_initcall().
>>
>> I understand we need to have the page setup before raising the event 
>> channel. I don't think we can allow Xenstored to set the HVM_PARAM (it 
>> may run in a domain with less privilege). So I think we may need to 
>> create a separate command to kick the client (not great).
>>
>> Juergen, any thoughts?
> 
> I think it should work like that:
> 
> - setup the grant via xc_dom_gnttab_seed()
> - introduce the domain to Xenstore
> - call xc_hvm_param_set()
> 
> When the guest is receiving the event, it should wait for the xenstore
> page to appear.
IIUC, this would mean the guest would need to do some sort of busy loop 
until the xenstore page to appear.

If so, this doesn't sound great to me. I think it would be better to 
have a flag in the page to indicate whether the page is not ready.

Xenstored could then clear the flag before raising the event channel.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 13:41:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 13:41:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297395.506586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHWy-0002ws-Ow; Fri, 01 Apr 2022 13:41:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297395.506586; Fri, 01 Apr 2022 13:41:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHWy-0002wl-Ku; Fri, 01 Apr 2022 13:41:36 +0000
Received: by outflank-mailman (input) for mailman id 297395;
 Fri, 01 Apr 2022 13:41:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i0v6=UL=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1naHWx-0002wf-3p
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 13:41:35 +0000
Received: from sonic314-19.consmr.mail.gq1.yahoo.com
 (sonic314-19.consmr.mail.gq1.yahoo.com [98.137.69.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 70b0757b-b1c1-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 15:41:33 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic314.consmr.mail.gq1.yahoo.com with HTTP; Fri, 1 Apr 2022 13:41:31 +0000
Received: by kubenode532.mail-prod1.omega.ne1.yahoo.com (VZM Hermes SMTP
 Server) with ESMTPA ID 147fbedc01154233ae6896890bdd0490; 
 Fri, 01 Apr 2022 13:41:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70b0757b-b1c1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1648820491; bh=R7IEiyhZiYuDrJeDSsgqYa6dsdd7mXzc3uSpNdXDtnc=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=TT3Fhf30R/NBi+lCY2c9AeI6JPBwnVC8pJ3nznd+VVQzMyphUaFUc/ilcJJ7otfuinpwxeKnRFex7M9Ff0VGJPmP6GYYVu9k/dNzvFEM1bdhO4s0dNRbtGbeQIGErY5Ins8rEhnSvLTR48lx+8ok216bJSuFuqukGvChzgFrhXkCY+uInn6jfAr8MeePvE6heCu/u2kqCPzCpeKX/QzNDNmV84//2u3JiDjwv/u7fPy/3mIfctMDh3GArmgcp04uyzMlGSj9tJ3BhPV3EJc9lXlE9Kl/xTQU8ujbS9c18btvUpD5+Q8gtaZ4kvPJ4obdRMOvcrDvvF1awY/djCqLuQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648820491; bh=djI+MjQwS6ig1O96dbD3Nn9psbbJliVH3EMP4C7sihX=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=ctO2hPErMbtZmIsToIUyLMQQO3+mCgJ2ac4NZAJecCcfhpZ8/1CpFoESviWhHg0PokJGF1bVU3QI52FlJqu3YKh8+hefQYRF+4+MJl9cdaknKe5AheiTNDhA5n8YO7i39Jq6ozG3+6CvPRm/wpvk88rWba/5YV7ek09d1SLaO2B9IEYowQRMFRmPdZ3IGPgkIAB/5Ir9XrJsSn5Tn8HGbr5RIkaw1EQzJR3iITXno9AO25dVDVj6eV4w620seVTBQ9LexJj8TEoLb06tmGsWw+/cEkyJ8RT9jCdcESaw5XfEKO44A2Pd2kGqBT6vkos68BFA2mV4pwy8aKeFT0tmQg==
X-YMail-OSG: 9.58niQVM1m4OTH_3rfVhigKWvxw8ZKxAXqKa1q6GZqrZRTEUMN6tq21nyHm3Sg
 5E8ad3GWOpbU9tMT1zzhnO4Q02pWZ1ZY7IaxvvXaulD_NewXuSiLcSJU8yV05EZDfLaFGTyM90Vi
 ERmWczreczCGJy0Pho_p60sqzTwWasN884xdgUIMPbKSMTi1iyOBaBcj6PZ.md11QZ1FsnRC7gyV
 IdUHq14iyyUh8eRPy8IfTv5illPTMqjNAbzwceru5lJyC4pqZvoZIl01P_VcwuAqswxAI.zHxw4L
 Vni2Chooj1lE1ZYC1_vx2cg7hltzpICVTdcB8TCFhVfKkuI31I8u9Ai195h27bluLdd1JhqlCi6z
 hhlNx_eyEvPB1UxBkJOI2QR1CyY69.EV6oBIg_RKpAD0j5KsVdkBXf6wrRc6TnYzroETsiX6C_Jk
 dmyA2YfhA2Z4HdQVmm_.M.vDfxdze5tIGR.Ajo4ja34VrhnGYXPXZchdXse6d1J_MJRSYQlH9m6c
 KBEhtm6KrRRyHAr62ro.WlwoVa5UEGU2tIy_lka3RCla3yqZtT0AQ7HlnOeGAZUbbFidokp.QxVN
 JwmkOrJ__XNwxuykZcDuU2oL8gqNT9cgKN1IDCnrYRypdUlO1s.iH1IUDMTdfIjK48zWeU900vc4
 9G2MBO1eWs5FuQwZMTxYbVnO5mxfXgWvLj1kV1oD5aEQrpTfjkiPSQLNwuITOTL2s071hd9K.qTO
 JAPUdNIAE4H2mgT0KtUvT9JuzeM1YslcIzi0f5kHL_ErcTReUQzJGYZ.71AZ.40HAU5MtxvY5vwL
 dK0BwN4qaQItx5N9b14PTFlRJuiZQlAR9vxQUiBf2bPscQEYUaToAq8aXDDS4XOBA7F7a4RE4F0f
 AGuMqApANY6HfUoD5GLAjOSDhb5ZrKKjUYRd6CdcMlNf3xMXKkr5xAQ71pWvHuTpebjhMlxe.mQL
 vYOrzZyzmsX5xzMGHr6SDzMv1RrkRZPyulSkj86v0AaP28rMd1tAwdBXEXCjD5JLTkR48IdULYqh
 pI1LS59QqaeDdDq6P96J6Ic69kC78WQrok3QQUeLtHBlT8gyikQVSb7lcnegTJPQCYX2PmEX0AJL
 DtHTmJpDdzM1mSWRDAy.zifqABmphZj5lPO.5bCs3Vzb6jZPVvgBJgjacBVdYFknrWZ32R6PVB7e
 B4CueROI9vfe4Gr3MAoknwCTccRdcaMmcF_GDpRIiLPL8gdIJbctMyVG.vTOI6GdVx7.4vXv4q4S
 3Xk8Uh.doVBsL6lCh02YGSCX7JvgwrksTnLGvkhs4L3RHPBV027tzwhBpGVyI7DFbA.FBzNxEpj_
 LhfW.z64zgSgOau_PMMkzuaWHsrt6M3JdNG9zNoUjFMMCvS.FHKjEsqKF5lNIx4RYZDBy09fbpe3
 Jiqhw5K4gXpraQfaxTT.rdcnBHuVFHSyYBSyYTqvpPK63eLSxd_OR1ETwInYFC99DtdMgKd0xKrn
 SO_2FeEATsqr6.KqtD7DPFfdyiqsw9MpRZuwetLAymhIZSzwbrxqZwnA9hU6x.h13vo.9C06ZgvU
 qLwdpgv52xtPf5ljt1a26ZtT2BM6EQcBY.rC8KfOFakefEk8.x_k.KNeZ7Jc70U2fWFmk.Lf5TVP
 ax.snLl5V8T91pF85C8o5emK4Zqg1bRGUx7W.W8_ZeQb3UrzzbrmdhuCH4j7WjhtaIA0MuEvuiYH
 gJdTtF894q.ylXTjWIpUvp0H6aqtnyaBUc6O0I_b.acB9HcUsblUS_5H42w.UjlSEP2qmmoGdG6F
 rf.BSZAoy7ICUlzR3kY.LhrjUH8uHnsXqVOdclUzGuNDErcNN39NYIEG6AAd7Vn8v4KdVQ9mxfSs
 DsQ4QeOOKwsaep12aovjhyRaBU9259tvbH4.Ievesrrc.3hnJT_BmizADvwifjAfXodc7vz.9XMY
 J6qI3dwGwaJcPXLW75YCE..IPjKJW_0FIGCQYqSNIkWN.4k1b2rj.DPN3MKdLxcj3oAdCxZKlkNJ
 TmwWHcqq_hXFzF5JEQn_1YdQZppJU.YKyWZDi_imajv4bR5PFY6ogzWSFXpEpB5El_k23uJquS.P
 QIO26Bw94AY8NT57.J0Ey07E1xvyHIlYm.Gxmcu5JhaF.uk9L8cpcblVmv4_Po1u_Bvn3nuEWu3l
 UMQMWyLwQlIfyVBm.FdvvgY4rnABacssjyS.yEZ4uvOGkHMGMHuu1hhXnMDruCB7wORxrV8fKBA7
 p4tYi79l_R6ACc0E6
X-Sonic-MF: <brchuckz@aim.com>
Message-ID: <c60f8789-d91a-3076-41a4-25c2fb07fae8@netscape.net>
Date: Fri, 1 Apr 2022 09:41:23 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access
 to Intel IGD opregion
Content-Language: en-US
From: Chuck Zmudzinski <brchuckz@netscape.net>
To: Jason Andryuk <jandryuk@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz.ref@netscape.net>
 <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz@netscape.net>
 <78ce5809-8df4-c94e-4313-fffb1b86b771@suse.com>
 <CAKf6xpsN+uJ=AyxtrnOrQrynFL=dwC=DdT7DHnK=wx9UFtdUDQ@mail.gmail.com>
 <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net>
In-Reply-To: <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 4035

On 4/1/22 9:21 AM, Chuck Zmudzinski wrote:
> On 3/30/22 2:45 PM, Jason Andryuk wrote:
>> On Fri, Mar 18, 2022 at 4:13 AM Jan Beulich <jbeulich@suse.com> wrote:
>>> On 14.03.2022 04:41, Chuck Zmudzinski wrote:
>>>> When gfx_passthru is enabled for the Intel IGD, hvmloader maps the IGD
>>>> opregion to the guest but libxl does not grant the guest permission to
>>>> access the mapped memory region. This results in a crash of the 
>>>> i915.ko
>>>> kernel module in a Linux HVM guest when it needs to access the IGD
>>>> opregion:
>>>>
>>>> Oct 23 11:36:33 domU kernel: Call Trace:
>>>> Oct 23 11:36:33 domU kernel:  ? idr_alloc+0x39/0x70
>>>> Oct 23 11:36:33 domU kernel: drm_get_last_vbltimestamp+0xaa/0xc0 [drm]
>>>> Oct 23 11:36:33 domU kernel: drm_reset_vblank_timestamp+0x5b/0xd0 
>>>> [drm]
>>>> Oct 23 11:36:33 domU kernel:  drm_crtc_vblank_on+0x7b/0x130 [drm]
>>>> Oct 23 11:36:33 domU kernel: 
>>>> intel_modeset_setup_hw_state+0xbd4/0x1900 [i915]
>>>> Oct 23 11:36:33 domU kernel:  ? _cond_resched+0x16/0x40
>>>> Oct 23 11:36:33 domU kernel:  ? ww_mutex_lock+0x15/0x80
>>>> Oct 23 11:36:33 domU kernel: intel_modeset_init_nogem+0x867/0x1d30 
>>>> [i915]
>>>> Oct 23 11:36:33 domU kernel:  ? gen6_write32+0x4b/0x1c0 [i915]
>>>> Oct 23 11:36:33 domU kernel:  ? intel_irq_postinstall+0xb9/0x670 
>>>> [i915]
>>>> Oct 23 11:36:33 domU kernel:  i915_driver_probe+0x5c2/0xc90 [i915]
>>>> Oct 23 11:36:33 domU kernel:  ? 
>>>> vga_switcheroo_client_probe_defer+0x1f/0x40
>>>> Oct 23 11:36:33 domU kernel:  ? i915_pci_probe+0x3f/0x150 [i915]
>>>> Oct 23 11:36:33 domU kernel:  local_pci_probe+0x42/0x80
>>>> Oct 23 11:36:33 domU kernel:  ? _cond_resched+0x16/0x40
>>>> Oct 23 11:36:33 domU kernel:  pci_device_probe+0xfd/0x1b0
>>>> Oct 23 11:36:33 domU kernel:  really_probe+0x222/0x480
>>>> Oct 23 11:36:33 domU kernel:  driver_probe_device+0xe1/0x150
>>>> Oct 23 11:36:33 domU kernel:  device_driver_attach+0xa1/0xb0
>>>> Oct 23 11:36:33 domU kernel:  __driver_attach+0x8a/0x150
>>>> Oct 23 11:36:33 domU kernel:  ? device_driver_attach+0xb0/0xb0
>>>> Oct 23 11:36:33 domU kernel:  ? device_driver_attach+0xb0/0xb0
>>>> Oct 23 11:36:33 domU kernel:  bus_for_each_dev+0x78/0xc0
>>>> Oct 23 11:36:33 domU kernel:  bus_add_driver+0x12b/0x1e0
>>>> Oct 23 11:36:33 domU kernel:  driver_register+0x8b/0xe0
>>>> Oct 23 11:36:33 domU kernel:  ? 0xffffffffc06b8000
>>>> Oct 23 11:36:33 domU kernel:  i915_init+0x5d/0x70 [i915]
>>>> Oct 23 11:36:33 domU kernel:  do_one_initcall+0x44/0x1d0
>>>> Oct 23 11:36:33 domU kernel:  ? do_init_module+0x23/0x260
>>>> Oct 23 11:36:33 domU kernel:  ? kmem_cache_alloc_trace+0xf5/0x200
>>>> Oct 23 11:36:33 domU kernel:  do_init_module+0x5c/0x260
>>>> Oct 23 11:36:33 domU kernel: __do_sys_finit_module+0xb1/0x110
>>>> Oct 23 11:36:33 domU kernel:  do_syscall_64+0x33/0x80
>>>> Oct 23 11:36:33 domU kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9
>>> The call trace alone leaves open where exactly the crash occurred.
>>> Looking at 5.17 I notice that the first thing the driver does
>>> after mapping the range it to check the signature (both in
>>> intel_opregion_setup()). As the signature can't possibly match
>>> with no access granted to the underlying mappings, there shouldn't
>>> be any further attempts to use the region in the driver; if there
>>> are, I'd view this as a driver bug.
>> Yes.  i915_driver_hw_probe does not check the return value of
>> intel_opregion_setup(dev_priv) and just continues on.
>>
>> Chuck, the attached patch may help if you want to test it.
>>
>> Regards,
>> Jason
>
> I tested the patch - it made no noticeable difference.I still
> get the same crash and call trace with the patch. Actually,
> the call trace I posted here is only the first of three call
> traces, and I still see all three call traces with the patch.

It is probably necessary to patch intet_opregion_setup to
return from it with an error sooner if the goal is to suppress
the call traces that occur when the driver cannot access
the opregion.

Regards,

Chuck


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 13:46:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 13:46:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297400.506597 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHbo-0003e9-FB; Fri, 01 Apr 2022 13:46:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297400.506597; Fri, 01 Apr 2022 13:46:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHbo-0003e2-C5; Fri, 01 Apr 2022 13:46:36 +0000
Received: by outflank-mailman (input) for mailman id 297400;
 Fri, 01 Apr 2022 13:46:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tlS5=UL=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1naHbn-0003dw-Nl
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 13:46:35 +0000
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 24070bb6-b1c2-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 15:46:34 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 31E6532007F9;
 Fri,  1 Apr 2022 09:46:31 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Fri, 01 Apr 2022 09:46:32 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 1 Apr 2022 09:46:29 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24070bb6-b1c2-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=hVyQEouGgaEt0F6DZ
	8ddM5JOZIXmifcHPNnQCe+kV+o=; b=k09j2MDQ6Won+fqlJJSeuNSgVJMKFU+xk
	oDqAyP9dMTARdNppZUVJFbwGI0Ny0bxSVrJH5TUxtAgaKPsJlnVd5nrWNJ0Tlb7O
	XJgHQQcS+QOolORNhDRKyLKdA/6YtvnzFfhyJ0MLUezpDnjKCmQV9XeINl322Gkf
	vNtLR7P4f0+Yy+P+itBSapdvptVzW+zme2hSdHhFulj3l6RZHT03U9ZScS64y0uN
	0TCYLzTEqgE+Z5yzdkdEo9HpU2EEYJnRPQIhZ/fRiqQ6IHYFSH25y5c6QV/046pZ
	EA7Kp3rBSXA8UPBGa/KaKzKk/W94HA/6M5zzysoBIRmXlK5GRN11g==
X-ME-Sender: <xms:NgJHYpCaa6WRZRXYcek6XIMKRZt3x1ixs9YAzheplHZAbga5HAf3lw>
    <xme:NgJHYnhLZMCitwLRmbkGQWt7gVAJSaRYcCoZSFzadOq1izOFys6SVp9DKu0WmxnCb
    PvCrk3Nho4bFg>
X-ME-Received: <xmr:NgJHYklKgqD-JollNRuVgR-3tYdLxCK2V4sV_6GT_OeZb79OQQ3NT4KKlBkuY6Ah9StvX6Z8A8xfQNaCV7vZx7M0i5ZOvXi9SQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeiiedgieelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:NgJHYjyjZnTQo0voglcViDWLnpOcUspz931tyfV0d8hgWMeBpssXJA>
    <xmx:NgJHYuQs74UenpMUhAvF1vVhb5dbXK0DTGtD71EMxmTTE7aDpkr_PQ>
    <xmx:NgJHYmaRQYT5mIwmBriXWKe2on0d-ohTERoQZ-tiM9i8uVZD0wEbyg>
    <xmx:NgJHYkP3RaVCf_W3_0znTHgCJP210tcaMWdqyvptalcFxYyjAhrNSQ>
Date: Fri, 1 Apr 2022 15:46:26 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Julien Grall <julien@xen.org>
Subject: Re: preparations for 4.14.5 ?
Message-ID: <YkcCMg8+dDjxBvJW@mail-itl>
References: <466e1d4b-a4b6-0797-ca1b-1ea59a3993ba@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="1IRnIitUKwGMlx3k"
Content-Disposition: inline
In-Reply-To: <466e1d4b-a4b6-0797-ca1b-1ea59a3993ba@suse.com>


--1IRnIitUKwGMlx3k
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 1 Apr 2022 15:46:26 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Julien Grall <julien@xen.org>
Subject: Re: preparations for 4.14.5 ?

On Wed, Mar 30, 2022 at 12:16:00PM +0200, Jan Beulich wrote:
> All,
>=20
> while 4.14's general support period ended in January, we're considering
> to cut an out-of-band release due to the relatively large number of
> security relevant backports which has accumulated in just 2 months. By
> doing this we would _not_ be promising to do so again in the future.
> Please voice objections to the plan (or support for it) in the next
> couple of days.
>=20
> Since it's a little easier to "batch" releases, I would intend to keep
> 4.14.5 aligned with 4.16.1.
>=20
> Commits I have queued but not committed to the branch yet (and I won't
> until in a couple of days time, to allow for objections to the plan to
> be raised):
>=20
> dd6c062a7a4a tools/libxl: Correctly align the ACPI tables
> aa390d513a67 build: fix exported variable name CFLAGS_stack_boundary
> e62cc29f9b6c tools/libs: Fix build dependencies
> eddf13b5e940 x86emul: fix VPBLENDMW with mask and memory operand
> 6bd1b4d35c05 x86/console: process softirqs between warning prints
> 07449ecfa425 tools/libxl: don't allow IOMMU usage with PoD
> 10454f381f91 xz: avoid overlapping memcpy() with invalid input with in-pl=
ace decompression
> 0a21660515c2 xz: validate the value before assigning it to an enum variab=
le
> b4f211606011 vpci/msix: fix PBA accesses
>=20
> Please point out backports you find missing from both the respective
> staging branch and the list above, but which you consider relevant.

I'm not sure if "just" bugfix qualify for 4.14 at this point, but if so,
I'd propose:
0a20a53df158 tools/libs/light: set video_mem for PVH guests

In any case, the above should be backported to 4.15 and 4.16.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--1IRnIitUKwGMlx3k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmJHAjIACgkQ24/THMrX
1yxrnwf+KhnFwQhyepbZzudjQ2PSmKP1K/Itp18wcMgYPy1kkRLAqwpe1YhlT88k
wdaOt2IeiUnyAvyl3aFU2rbwUCW4L3WchBGfiIVam642UWSWlKzTXjMLaU2mZ4xL
eRsNV/ct9XbuHs9GugueXHl0AObM2OxhLlwgiN05lNlS4KVPKFyz6HBaQSweZuT9
VzLpJgHFAzvLlJF5zhNG1etMreFFY5cFg6Qx6u+8p1ALuU49TC2YTZsVTwhr+CY4
mR+y0gUmeR9K65vFeVXABirqF86W05J7MnNMr9YXecog7Y2bVJ3Bf1D/ZLKG0kv/
OI2Yruf0Rw6F0joVEtgDO+uiaS10Jw==
=vUWc
-----END PGP SIGNATURE-----

--1IRnIitUKwGMlx3k--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 13:50:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 13:50:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297404.506608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHf4-0004GA-VZ; Fri, 01 Apr 2022 13:49:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297404.506608; Fri, 01 Apr 2022 13:49:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHf4-0004G3-SP; Fri, 01 Apr 2022 13:49:58 +0000
Received: by outflank-mailman (input) for mailman id 297404;
 Fri, 01 Apr 2022 13:49:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AW7G=UL=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1naHf3-0004Fx-Uy
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 13:49:57 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9d95675c-b1c2-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 15:49:56 +0200 (CEST)
Received: by mail-lf1-x134.google.com with SMTP id 5so5096557lfp.1
 for <xen-devel@lists.xenproject.org>; Fri, 01 Apr 2022 06:49:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d95675c-b1c2-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=+UjquPGwFGeqwBCb89WBL58YtOG7MMP1lqm5Lsl5SDI=;
        b=L5A0O7TEbaLtciBNfvyE8wAwyB5iLGqjgF9ks9SQzE8qXCg+y0WJ/kz2kA2u0BbEft
         4QgYrjPCZ4KCokQW+GRPWBFVGdC/nsu55VRzmAbZ7UrB97b63Cf9BT7JwgpiVOw7v6uX
         tndcrIRkzRKU79d1L2cywN9bZH12QBhDEXdvcfMk+cfTfLdmY694SW2IAF7jxp4YSuqV
         H4ghKXQSIUtl5fKUF6SJZtm7eHWkaaaa9YHc2Hegqq8U03PTdd7b2Sxx1NoVnJSZQvDw
         36yssT1PfGLwrzf7/IDBv9PdjHcePe/X/DFLm46sdi0N3UK4oysuz2gOPI8aa3YE03es
         7Faw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=+UjquPGwFGeqwBCb89WBL58YtOG7MMP1lqm5Lsl5SDI=;
        b=PT24UyJv8V9KNxXYRACUUn6ylaXxGOmBTWo//YEijc9L2kjFyeULOrgUwLvftO3+6h
         ItCwTquv4piwY9GQKyxgVhkpb2kdtLrrzHDlgeY/V2PeqREEsoxn9CC8/gJ4RJqtFtL3
         7c9vHFnsO3S1vkSGbT3nYtkD9TDF7j5MLOcAbVn6acgJm61UQmdydaWxvYINvsJ/j0N9
         xiNT9rOpsCizM4MNnDRFZ0HK1amQiLKzZ8PP80zPFO66bp9/ygMqTmp2WLxxey06/Fq2
         Pe6waCo42xezx59tbty9xf46f1uxZ0xszt/FPTd8SGoQ2pBMTvXLgECUCpb+hcxss5wJ
         +lJg==
X-Gm-Message-State: AOAM531ilQZx1r/nRvjJp92rKzH4WQvKafsk9UK0h/OfNqwEzFGPUhGU
	XV9ELSTsBj5k8AFV3cdkqhFbdwjtY3w264SEjGI=
X-Google-Smtp-Source: ABdhPJyMLbS0P7Ni/ivW/xJ8aVi3h3jMAv1txZ+yu0lzm/nIfcakK1WfLyfjbni6paaBYnrMulkDdV6eEcXJSd8SlaE=
X-Received: by 2002:a05:6512:11cc:b0:44a:5770:7425 with SMTP id
 h12-20020a05651211cc00b0044a57707425mr13614617lfr.406.1648820996182; Fri, 01
 Apr 2022 06:49:56 -0700 (PDT)
MIME-Version: 1.0
References: <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz.ref@netscape.net>
 <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz@netscape.net>
 <78ce5809-8df4-c94e-4313-fffb1b86b771@suse.com> <CAKf6xpsN+uJ=AyxtrnOrQrynFL=dwC=DdT7DHnK=wx9UFtdUDQ@mail.gmail.com>
 <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net> <c60f8789-d91a-3076-41a4-25c2fb07fae8@netscape.net>
In-Reply-To: <c60f8789-d91a-3076-41a4-25c2fb07fae8@netscape.net>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Fri, 1 Apr 2022 09:49:44 -0400
Message-ID: <CAKf6xpshJAy0P4v9uhNTd-U6boivfq-yqBb3Yo02mSQnvUxRCw@mail.gmail.com>
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access
 to Intel IGD opregion
To: Chuck Zmudzinski <brchuckz@netscape.net>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 1, 2022 at 9:41 AM Chuck Zmudzinski <brchuckz@netscape.net> wrote:
>
> On 4/1/22 9:21 AM, Chuck Zmudzinski wrote:
> > On 3/30/22 2:45 PM, Jason Andryuk wrote:
> >> On Fri, Mar 18, 2022 at 4:13 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>> On 14.03.2022 04:41, Chuck Zmudzinski wrote:
> >>>> When gfx_passthru is enabled for the Intel IGD, hvmloader maps the IGD
> >>>> opregion to the guest but libxl does not grant the guest permission to
> >>>> access the mapped memory region. This results in a crash of the
> >>>> i915.ko
> >>>> kernel module in a Linux HVM guest when it needs to access the IGD
> >>>> opregion:
> >>>>
> >>>> Oct 23 11:36:33 domU kernel: Call Trace:
> >>>> Oct 23 11:36:33 domU kernel:  ? idr_alloc+0x39/0x70
> >>>> Oct 23 11:36:33 domU kernel: drm_get_last_vbltimestamp+0xaa/0xc0 [drm]
> >>>> Oct 23 11:36:33 domU kernel: drm_reset_vblank_timestamp+0x5b/0xd0
> >>>> [drm]
> >>>> Oct 23 11:36:33 domU kernel:  drm_crtc_vblank_on+0x7b/0x130 [drm]
> >>>> Oct 23 11:36:33 domU kernel:
> >>>> intel_modeset_setup_hw_state+0xbd4/0x1900 [i915]
> >>>> Oct 23 11:36:33 domU kernel:  ? _cond_resched+0x16/0x40
> >>>> Oct 23 11:36:33 domU kernel:  ? ww_mutex_lock+0x15/0x80
> >>>> Oct 23 11:36:33 domU kernel: intel_modeset_init_nogem+0x867/0x1d30
> >>>> [i915]
> >>>> Oct 23 11:36:33 domU kernel:  ? gen6_write32+0x4b/0x1c0 [i915]
> >>>> Oct 23 11:36:33 domU kernel:  ? intel_irq_postinstall+0xb9/0x670
> >>>> [i915]
> >>>> Oct 23 11:36:33 domU kernel:  i915_driver_probe+0x5c2/0xc90 [i915]
> >>>> Oct 23 11:36:33 domU kernel:  ?
> >>>> vga_switcheroo_client_probe_defer+0x1f/0x40
> >>>> Oct 23 11:36:33 domU kernel:  ? i915_pci_probe+0x3f/0x150 [i915]
> >>>> Oct 23 11:36:33 domU kernel:  local_pci_probe+0x42/0x80
> >>>> Oct 23 11:36:33 domU kernel:  ? _cond_resched+0x16/0x40
> >>>> Oct 23 11:36:33 domU kernel:  pci_device_probe+0xfd/0x1b0
> >>>> Oct 23 11:36:33 domU kernel:  really_probe+0x222/0x480
> >>>> Oct 23 11:36:33 domU kernel:  driver_probe_device+0xe1/0x150
> >>>> Oct 23 11:36:33 domU kernel:  device_driver_attach+0xa1/0xb0
> >>>> Oct 23 11:36:33 domU kernel:  __driver_attach+0x8a/0x150
> >>>> Oct 23 11:36:33 domU kernel:  ? device_driver_attach+0xb0/0xb0
> >>>> Oct 23 11:36:33 domU kernel:  ? device_driver_attach+0xb0/0xb0
> >>>> Oct 23 11:36:33 domU kernel:  bus_for_each_dev+0x78/0xc0
> >>>> Oct 23 11:36:33 domU kernel:  bus_add_driver+0x12b/0x1e0
> >>>> Oct 23 11:36:33 domU kernel:  driver_register+0x8b/0xe0
> >>>> Oct 23 11:36:33 domU kernel:  ? 0xffffffffc06b8000
> >>>> Oct 23 11:36:33 domU kernel:  i915_init+0x5d/0x70 [i915]
> >>>> Oct 23 11:36:33 domU kernel:  do_one_initcall+0x44/0x1d0
> >>>> Oct 23 11:36:33 domU kernel:  ? do_init_module+0x23/0x260
> >>>> Oct 23 11:36:33 domU kernel:  ? kmem_cache_alloc_trace+0xf5/0x200
> >>>> Oct 23 11:36:33 domU kernel:  do_init_module+0x5c/0x260
> >>>> Oct 23 11:36:33 domU kernel: __do_sys_finit_module+0xb1/0x110
> >>>> Oct 23 11:36:33 domU kernel:  do_syscall_64+0x33/0x80
> >>>> Oct 23 11:36:33 domU kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9
> >>> The call trace alone leaves open where exactly the crash occurred.
> >>> Looking at 5.17 I notice that the first thing the driver does
> >>> after mapping the range it to check the signature (both in
> >>> intel_opregion_setup()). As the signature can't possibly match
> >>> with no access granted to the underlying mappings, there shouldn't
> >>> be any further attempts to use the region in the driver; if there
> >>> are, I'd view this as a driver bug.
> >> Yes.  i915_driver_hw_probe does not check the return value of
> >> intel_opregion_setup(dev_priv) and just continues on.
> >>
> >> Chuck, the attached patch may help if you want to test it.
> >>
> >> Regards,
> >> Jason
> >
> > I tested the patch - it made no noticeable difference.I still
> > get the same crash and call trace with the patch. Actually,
> > the call trace I posted here is only the first of three call
> > traces, and I still see all three call traces with the patch.

Thanks for testing.  Sorry it didn't help.

> It is probably necessary to patch intet_opregion_setup to
> return from it with an error sooner if the goal is to suppress
> the call traces that occur when the driver cannot access
> the opregion.

It looks correct for 5.17 running in your domU.  I thought the
opregion signature check would fail.  A failure in
intel_opregion_setup would percolate up through i915_driver_hw_probe
to i915_driver_probe.  In i915_driver_probe the error should goto
out_cleanup_mmio and skip intel_modeset_init_nogem which is in your
backtrace.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 13:52:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 13:52:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297408.506619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHhb-0005d6-8r; Fri, 01 Apr 2022 13:52:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297408.506619; Fri, 01 Apr 2022 13:52:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHhb-0005cz-5p; Fri, 01 Apr 2022 13:52:35 +0000
Received: by outflank-mailman (input) for mailman id 297408;
 Fri, 01 Apr 2022 13:52:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Yu3J=UL=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1naHha-0005cr-I0
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 13:52:34 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id facbe98f-b1c2-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 15:52:33 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D57EF1FD00;
 Fri,  1 Apr 2022 13:52:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 938F81331E;
 Fri,  1 Apr 2022 13:52:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id tBxFIp8DR2LCZgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Apr 2022 13:52:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: facbe98f-b1c2-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1648821151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=NguB6iSxc8L7WWabwK13dnwd8swWgePoi39hfCPSpEY=;
	b=ZBusKjzDk/OSjs3eH6MB814259MEq/npNzadnCb6rolCzhCaVdmfRzgcorKXCEa7H4PtkC
	5uSXNCWIkasXrFEnqPf7mvPiLIm8huwjnuL9nUOMTQU31u8kDnLuyOtiO+JbsHR9D06a9L
	CguGhUgIJK3u1xZBriS0TrZViO5DlMk=
Message-ID: <5522e39c-e7b6-eecf-526d-abe6964e068c@suse.com>
Date: Fri, 1 Apr 2022 15:52:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
 <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
 <57312254-b599-6de5-04aa-f88907c49163@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <57312254-b599-6de5-04aa-f88907c49163@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------bRxBE0y580PRKxGp8TOrZBza"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------bRxBE0y580PRKxGp8TOrZBza
Content-Type: multipart/mixed; boundary="------------FYnDoI9hIIEXKq4UtDLdeSqd";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <5522e39c-e7b6-eecf-526d-abe6964e068c@suse.com>
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
 <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
 <57312254-b599-6de5-04aa-f88907c49163@xen.org>
In-Reply-To: <57312254-b599-6de5-04aa-f88907c49163@xen.org>

--------------FYnDoI9hIIEXKq4UtDLdeSqd
Content-Type: multipart/mixed; boundary="------------FiRWx61O0p1aHByu2ybUKiHy"

--------------FiRWx61O0p1aHByu2ybUKiHy
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDEuMDQuMjIgMTU6MzUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN
Cj4gDQo+IE9uIDAxLzA0LzIwMjIgMTE6NDYsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP
biAwMS4wNC4yMiAxMjoyMSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpLA0KPj4+DQo+
Pj4gSSBoYXZlIHBvc3RlZCBzb21lIGNvbW1lbnRzIGluIHYzIGFmdGVyIHlvdSBzZW50IHRo
aXMgdmVyc2lvbi4gUGxlYXNlIGhhdmUgYSANCj4+PiBsb29rLg0KPj4+DQo+Pj4gT24gMDEv
MDQvMjAyMiAwMTozOCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+PiArc3RhdGlj
IGludCBpbml0X2RvbWFpbihzdHJ1Y3QgeHNfaGFuZGxlICp4c2gsIGxpYnhsX2RvbWluZm8g
KmluZm8pDQo+Pj4+ICt7DQo+Pj4+ICvCoMKgwqAgc3RydWN0IHhjX2ludGVyZmFjZV9jb3Jl
ICp4Y2g7DQo+Pj4+ICvCoMKgwqAgbGlieGxfdXVpZCB1dWlkOw0KPj4+PiArwqDCoMKgIHVp
bnQ2NF90IHhlbnN0b3JlX2V2dGNobiwgeGVuc3RvcmVfcGZuOw0KPj4+PiArwqDCoMKgIGlu
dCByYzsNCj4+Pj4gKw0KPj4+PiArwqDCoMKgIHByaW50ZigiSW5pdCBkb20wbGVzcyBkb21h
aW46ICV1XG4iLCBpbmZvLT5kb21pZCk7DQo+Pj4+ICvCoMKgwqAgeGNoID0geGNfaW50ZXJm
YWNlX29wZW4oMCwgMCwgMCk7DQo+Pj4+ICsNCj4+Pj4gK8KgwqDCoCByYyA9IHhjX2h2bV9w
YXJhbV9nZXQoeGNoLCBpbmZvLT5kb21pZCwgSFZNX1BBUkFNX1NUT1JFX0VWVENITiwNCj4+
Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
ICZ4ZW5zdG9yZV9ldnRjaG4pOw0KPj4+PiArwqDCoMKgIGlmIChyYyAhPSAwKSB7DQo+Pj4+
ICvCoMKgwqDCoMKgwqDCoCBwcmludGYoIkZhaWxlZCB0byBnZXQgSFZNX1BBUkFNX1NUT1JF
X0VWVENITlxuIik7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gMTsNCj4+Pj4gK8Kg
wqDCoCB9DQo+Pj4+ICsNCj4+Pj4gK8KgwqDCoCAvKiBBbGxvYyB4ZW5zdG9yZSBwYWdlICov
DQo+Pj4+ICvCoMKgwqAgaWYgKGFsbG9jX3hzX3BhZ2UoeGNoLCBpbmZvLCAmeGVuc3RvcmVf
cGZuKSAhPSAwKSB7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBwcmludGYoIkVycm9yIG9uIGFs
bG9jIG1hZ2ljIHBhZ2VzXG4iKTsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAxOw0K
Pj4+PiArwqDCoMKgIH0NCj4+Pj4gKw0KPj4+PiArwqDCoMKgIHJjID0geGNfZG9tX2dudHRh
Yl9zZWVkKHhjaCwgaW5mby0+ZG9taWQsIHRydWUsDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHhlbl9wZm5fdCktMSwg
eGVuc3RvcmVfcGZuLCAwLCAwKTsNCj4+Pj4gK8KgwqDCoCBpZiAocmMpDQo+Pj4+ICvCoMKg
wqDCoMKgwqDCoCBlcnIoMSwgInhjX2RvbV9nbnR0YWJfc2VlZCIpOw0KPj4+PiArDQo+Pj4+
ICvCoMKgwqAgbGlieGxfdXVpZF9nZW5lcmF0ZSgmdXVpZCk7DQo+Pj4+ICvCoMKgwqAgeGNf
ZG9tYWluX3NldGhhbmRsZSh4Y2gsIGluZm8tPmRvbWlkLCBsaWJ4bF91dWlkX2J5dGVhcnJh
eSgmdXVpZCkpOw0KPj4+PiArDQo+Pj4+ICvCoMKgwqAgcmMgPSBnZW5fc3R1Yl9qc29uX2Nv
bmZpZyhpbmZvLT5kb21pZCwgJnV1aWQpOw0KPj4+PiArwqDCoMKgIGlmIChyYykNCj4+Pj4g
K8KgwqDCoMKgwqDCoMKgIGVycigxLCAiZ2VuX3N0dWJfanNvbl9jb25maWciKTsNCj4+Pj4g
Kw0KPj4+PiArwqDCoMKgIC8qIE5vdyBldmVyeXRoaW5nIGlzIHJlYWR5OiBzZXQgSFZNX1BB
UkFNX1NUT1JFX1BGTiAqLw0KPj4+PiArwqDCoMKgIHJjID0geGNfaHZtX3BhcmFtX3NldCh4
Y2gsIGluZm8tPmRvbWlkLCBIVk1fUEFSQU1fU1RPUkVfUEZOLA0KPj4+PiArwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgeGVuc3RvcmVfcGZu
KTsNCj4+Pg0KPj4+IE9uIHBhdGNoICMxLCB5b3UgdG9sZCBtZSB5b3UgZGlkbid0IHdhbnQg
dG8gYWxsb2NhdGUgdGhlIHBhZ2UgaW4gWGVuIGJlY2F1c2UgDQo+Pj4gaXQgd291bGRuJ3Qg
YmUgaW5pdGlhbGl6ZWQgYnkgWGVuc3RvcmVkLiBCdXQgdGhpcyBpcyB3aGF0IHdlIGFyZSBk
b2luZyBoZXJlLg0KPj4NCj4+IFhlbnN0b3JlIChhdCBsZWFzdCB0aGUgQyB2YXJpYW50KSBp
cyBvbmx5IHVzaW5nIHRoZSBmaXhlZCBncmFudCByZWYNCj4+IEdOVFRBQl9SRVNFUlZFRF9Y
RU5TVE9SRSwgc28gaXQgZG9lc24ndCBuZWVkIHRoZSBwYWdlIHRvIGJlIGFkdmVydGlzZWQN
Cj4+IHRvIHRoZSBndWVzdC4gQW5kIHRoZSBtYXBwaW5nIGlzIGRvbmUgb25seSB3aGVuIHRo
ZSBkb21haW4gaXMgYmVpbmcNCj4+IGludHJvZHVjZWQgdG8gWGVuc3RvcmUuDQo+IA0KPiBB
bmQgd2UgZG9uJ3QgZXhwZWN0IHRoZSBndWVzdCB0byB1c2UgdGhlIGdyYW50IGVudHJ5IHRv
IGZpbmQgdGhlIHhlbnN0b3JlIHBhZ2U/DQo+Pg0KPj4+DQo+Pj4gVGhpcyB3b3VsZCBiZSBh
IHByb2JsZW0gaWYgTGludXggaXMgc3RpbGwgYm9vdGluZyBhbmQgaGFzbid0IHlldCBjYWxs
IA0KPj4+IHhlbmJ1c19wcm9iZV9pbml0Y2FsbCgpLg0KPj4+DQo+Pj4gSSB1bmRlcnN0YW5k
IHdlIG5lZWQgdG8gaGF2ZSB0aGUgcGFnZSBzZXR1cCBiZWZvcmUgcmFpc2luZyB0aGUgZXZl
bnQgY2hhbm5lbC4gDQo+Pj4gSSBkb24ndCB0aGluayB3ZSBjYW4gYWxsb3cgWGVuc3RvcmVk
IHRvIHNldCB0aGUgSFZNX1BBUkFNIChpdCBtYXkgcnVuIGluIGEgDQo+Pj4gZG9tYWluIHdp
dGggbGVzcyBwcml2aWxlZ2UpLiBTbyBJIHRoaW5rIHdlIG1heSBuZWVkIHRvIGNyZWF0ZSBh
IHNlcGFyYXRlIA0KPj4+IGNvbW1hbmQgdG8ga2ljayB0aGUgY2xpZW50IChub3QgZ3JlYXQp
Lg0KPj4+DQo+Pj4gSnVlcmdlbiwgYW55IHRob3VnaHRzPw0KPj4NCj4+IEkgdGhpbmsgaXQg
c2hvdWxkIHdvcmsgbGlrZSB0aGF0Og0KPj4NCj4+IC0gc2V0dXAgdGhlIGdyYW50IHZpYSB4
Y19kb21fZ250dGFiX3NlZWQoKQ0KPj4gLSBpbnRyb2R1Y2UgdGhlIGRvbWFpbiB0byBYZW5z
dG9yZQ0KPj4gLSBjYWxsIHhjX2h2bV9wYXJhbV9zZXQoKQ0KPj4NCj4+IFdoZW4gdGhlIGd1
ZXN0IGlzIHJlY2VpdmluZyB0aGUgZXZlbnQsIGl0IHNob3VsZCB3YWl0IGZvciB0aGUgeGVu
c3RvcmUNCj4+IHBhZ2UgdG8gYXBwZWFyLg0KPiBJSVVDLCB0aGlzIHdvdWxkIG1lYW4gdGhl
IGd1ZXN0IHdvdWxkIG5lZWQgdG8gZG8gc29tZSBzb3J0IG9mIGJ1c3kgbG9vcCB1bnRpbCAN
Cj4gdGhlIHhlbnN0b3JlIHBhZ2UgdG8gYXBwZWFyLg0KDQpMb29raW5nIGZvciBpdCBldmVy
eSBzZWNvbmQgb3Igc28gd291bGQgYmUgZW5vdWdoLg0KDQo+IElmIHNvLCB0aGlzIGRvZXNu
J3Qgc291bmQgZ3JlYXQgdG8gbWUuIEkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIGhh
dmUgYSBmbGFnIA0KPiBpbiB0aGUgcGFnZSB0byBpbmRpY2F0ZSB3aGV0aGVyIHRoZSBwYWdl
IGlzIG5vdCByZWFkeS4NCj4gDQo+IFhlbnN0b3JlZCBjb3VsZCB0aGVuIGNsZWFyIHRoZSBm
bGFnIGJlZm9yZSByYWlzaW5nIHRoZSBldmVudCBjaGFubmVsLg0KDQpIbW0sIHRoZSAiY29u
bmVjdGlvbiIgZmllbGQgY291bGQgYmUgdXNlZCBmb3IgdGhhdC4NCg0KSXQgd291bGQgbWVh
biwgdGhvdWdoLCB0aGF0IGUuZy4gbGlieGwgd291bGQgbmVlZCB0byBpbml0aWFsaXplIHRo
ZQ0KcGFnZSBhY2NvcmRpbmdseSBiZWZvcmUgY2FsbGluZyB4c19pbnRyb2R1Y2UoKS4NCg0K
DQpKdWVyZ2VuDQo=
--------------FiRWx61O0p1aHByu2ybUKiHy
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FiRWx61O0p1aHByu2ybUKiHy--

--------------FYnDoI9hIIEXKq4UtDLdeSqd--

--------------bRxBE0y580PRKxGp8TOrZBza
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJHA58FAwAAAAAACgkQsN6d1ii/Ey91
Jwf/cSZ9iXfH0YO/6ZF+430/JKzF1M8sFca7sH9KUPiSnlyVRUtMpAaKl013VfkT561AfcfEJzWv
R5Om88tX7oDbnJ42xzhNzMoCcFT/eA/qff6URDpTFgOuOhpQY8jC2cDSSOSLMyFcyajswHcpHE2+
5zIdK+VbROsEB+8a/L//rB2ov9c2UzoxqlAgOGpkb3vvmLURXTjoScvAb/tCAvB8QH7vlZtLCqDp
w/WZq0eB90eqPcrn9supmgqwo+Y1ByyTm6MBiubYzgnP2mQ2LRboV6AQ6W3W/xx07Xnq8A6ben5N
U5Wk7ptssBCobe6oj9pEAMKztwVSOSak+JOkCv76yA==
=Cwd6
-----END PGP SIGNATURE-----

--------------bRxBE0y580PRKxGp8TOrZBza--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 13:53:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 13:53:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297411.506630 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHiN-0006A5-IJ; Fri, 01 Apr 2022 13:53:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297411.506630; Fri, 01 Apr 2022 13:53:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHiN-00069y-FN; Fri, 01 Apr 2022 13:53:23 +0000
Received: by outflank-mailman (input) for mailman id 297411;
 Fri, 01 Apr 2022 13:53:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JkNZ=UL=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1naHiL-00062m-Qv
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 13:53:22 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0623.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::623])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 163ef985-b1c3-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 15:53:19 +0200 (CEST)
Received: from AS9PR06CA0089.eurprd06.prod.outlook.com (2603:10a6:20b:464::14)
 by AM6PR08MB3125.eurprd08.prod.outlook.com (2603:10a6:209:46::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Fri, 1 Apr
 2022 13:53:10 +0000
Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:464:cafe::ab) by AS9PR06CA0089.outlook.office365.com
 (2603:10a6:20b:464::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.26 via Frontend
 Transport; Fri, 1 Apr 2022 13:53:10 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Fri, 1 Apr 2022 13:53:10 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Fri, 01 Apr 2022 13:53:10 +0000
Received: from ccc12a6a6123.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D80A576D-CF4C-4335-B852-6649A657AFA8.1; 
 Fri, 01 Apr 2022 13:52:59 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ccc12a6a6123.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Apr 2022 13:52:59 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM5PR0801MB1730.eurprd08.prod.outlook.com (2603:10a6:203:38::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Fri, 1 Apr
 2022 13:52:55 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310%7]) with mapi id 15.20.5123.021; Fri, 1 Apr 2022
 13:52:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 163ef985-b1c3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+RX0zrkWaF+G96cV0dhi+/BlSlqMy1i6xCHXOJTnBmA=;
 b=W+26dz6b/iC4rtRYkbwFuM/XGGNYJzv3IjsPz/B0NllBtqK40oSsW0vtzrItjpKOLLeGpWGNJJziOSte+XQ6byMrjAC75R8ODI669Y4Fn7naOyu0l3mH44+FfJ8sBYahvPsHU3c5YKvsux+7GaSXAl3d+J5xev9IXf5YhX2OQwY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 038d63446095fc2e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LeUOeCOck69er0yfigKo/uMQiAAlyKZanNphCO9JNNW79r7G+ubQ+kT6kjBFR/MXgFyIA0Czw5LIjfUiSL+8o9nb1JJhl99D+ToryXWttBJmcwIY8+osMWu0ovGxpU5EBv9lsZlFwzkV0Q3YeYagI/Wh4WkZRdOxnEVanre/44b/FCfvshx/GPpPSvkmDcy6AhJXNg3CA1/SAUGoXspYtZHiRFUzfvLAHvV9Q3RL9NTydQXWJt3I221ZdiLh3WlQSGHdrpzuik9WafBzroTKs9RLQquiFNL3LXVC1srnbFFrl/niBnXYc0eDNrbKtkiZOMrUAwkwx/6A6dURaXV7Cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+RX0zrkWaF+G96cV0dhi+/BlSlqMy1i6xCHXOJTnBmA=;
 b=PX4Rwz8I+vAw1MTyVnV8HHxKduaR/cqR6lVQTBu4MiwEr8YAhjUVTupEPwS+M0zWzo0bxilt/lfYnHbCsEM8gRiZO8D5iME74qCUkhDANZQ3BPWW1n6aBmGExuY52pbzCFG1Cal303UdwnYtcCgsW3dh1LmephjpzNPcBGjbwAUY6vMOabo8pV/FcJvZIua9gS2YasYlk+w/DAWMVTI8a0bNxhhTVuBpJezLUNZqxVza6nX2yGcd5/SxuwGAmK4dxIF5puVfvdqxJRefQmPKcURmAScgFgNLPt1HVEqK9rodQMjSNLj4mcjeRIbALuyesWm+oQBchVu7EhyOCRW6og==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+RX0zrkWaF+G96cV0dhi+/BlSlqMy1i6xCHXOJTnBmA=;
 b=W+26dz6b/iC4rtRYkbwFuM/XGGNYJzv3IjsPz/B0NllBtqK40oSsW0vtzrItjpKOLLeGpWGNJJziOSte+XQ6byMrjAC75R8ODI669Y4Fn7naOyu0l3mH44+FfJ8sBYahvPsHU3c5YKvsux+7GaSXAl3d+J5xev9IXf5YhX2OQwY=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Juergen Gross
	<jgross@suse.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, Stefano Stabellini
	<stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v4 2/9] xen/arm: implement domU extended regions
Thread-Topic: [PATCH v4 2/9] xen/arm: implement domU extended regions
Thread-Index: AQHYRWDx0w9vetaSnE2EriQcgkUblqzbFM0A
Date: Fri, 1 Apr 2022 13:52:54 +0000
Message-ID: <A5DD6DA0-A77C-4916-8FD5-DE5462739599@arm.com>
References:
 <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-2-sstabellini@kernel.org>
In-Reply-To: <20220401003847.38393-2-sstabellini@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: ceabb37a-44f3-466a-9c37-08da13e6f553
x-ms-traffictypediagnostic:
	AM5PR0801MB1730:EE_|AM5EUR03FT030:EE_|AM6PR08MB3125:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB31258F0D8F7FB51EC7C5C3B2E4E09@AM6PR08MB3125.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 JPBLhpx6GlQmaCb7f/GwjaBPwVmy3rgh7LTB3UHF87BRaUbllq6QuMxujykR7TFPp8JEoyY5pKEto6lbXhlqgkDbfc21Av+dpjzJySTAVzZ2bWqo/T6UwOaM2m/AdVDSfNOkcTAUG9xUOd6WdKvwOQJLW5GllK+j0Zh21oip4fIKBu+C4oeT88evsheyxsWMUSskp8kF4WdD68opw6MJfIh/oLpG/6gt1oY0CB3Tfdu0shmmJedhyM3Aa1HXrA+OAjeHsa5RjaaS32rZYYsLKJIWA336WVo8t1heJxr80K7YfhGxmb3HL3snSFfpPbDhNPc41BThKolsm7LQ0ZaU3P6t6a6x+qVXDBy5VE1L/9UqQk0QOFr5S3dm9hQZBfFvK/HqdRnluXVG4wu+q9cLH2els5SMGaM9Tjed0zvjHlr+C+7hB0hy35Vu0dT/yxzgOJpTlozdYtbC2zlC7X3HEqIY3SnKw+EsUiJvbE8FbyWikYypGEvnpSdUl4E8QzwDI8XOZBDZ1LtCDrjk/lcn2h8sJS66QzKXp2PvPbJ1PnY4aWkPUufBTus21oKBSHVFzLMydCQEQq/IMyPCyxcQLoKpmrB35v3uAwrLxn2nszuH6ofztjP35fM9xGErfEbK9V3aa2q4QpTEaijNGQ9XMduoQX+iMoIbtBYE7B5/fAFuvtG2rDEWvfib0FhOJ2NdYxyABKRt7EhtZyFhh82JL0EE73lKnUikAtkgxTyx+9AG893/RweXXZiDXlFcpBf7
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(66476007)(4326008)(83380400001)(8676002)(316002)(64756008)(33656002)(86362001)(36756003)(6506007)(66556008)(66946007)(76116006)(91956017)(2906002)(4744005)(8936002)(38070700005)(5660300002)(38100700002)(122000001)(508600001)(71200400001)(6486002)(6512007)(2616005)(6916009)(54906003)(186003)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <52E7B0E9A497CC41ACD99E585FC1BA6D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1730
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ca6b21af-8fe1-4e47-72ff-08da13e6ebfd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8rY+TmnZRu5vOSuG7FQXDJwKZlWv+FCBtDLC9MUwXQhMUZSRpaABlHZvsfeUfrzXCFXgyIzqdc2MjV55o+roRMBUb9CjvB928I+TttKLb2sYN8B5ESYYxlq1k2bqEO4PlvvLw3LmZlIm1usKBXcDp2huwKT1aarNtzaFnkTxJij9vJUE2H0AegVN4qOnh3Y5Cot0h91649R6ATxm5wBE4msnVwX3MfIvesGk/ZJ6ufu91U70j3xQ0pY6p1zoIu07C4Jrtpob71Z5fsJ/9g/ahehzkv89T5yOt6tJfCFe8JbLET6pZRY1Zo+1VpkW5Wc6GMCG+KJV/ULZfbMpsU2z9s1AtZcLLX1uRjM9S6/BdmkzfY/ghOmj0U5goGtjnb2t+9XP4+xA8xZQjBCS17pr6JSPcHsJFSyfuPGMO0W0xQYNs53UutbUrHV3FRZyfEE3rCSpJmzSBpxO7G8Fycm1Jm8nrAxJ4UQLIeBoy2+BHz3vClJCozGyZLXih7CET0zL9Y62LiaLMrH/b5eWOvLUVSny0tLryvbCq4QBOTRwPq/ISm4QVvS7USakiHI1VweR1LSxlyMlaabxy7RJLr1zL87aYLPIDDJ4bXuvVt1iDemY/a43cy77tvZOAcpyBxrUidV7g+wuWWrmnGtu6XOQqMJOgmTmd0rl3wbrzxOW33YVLV2Irsml1gyBUQpxhrYk
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8676002)(6862004)(4326008)(316002)(70206006)(54906003)(70586007)(6486002)(81166007)(36756003)(33656002)(356005)(86362001)(2616005)(6506007)(6512007)(47076005)(36860700001)(508600001)(40460700003)(336012)(26005)(186003)(5660300002)(4744005)(8936002)(83380400001)(82310400004)(107886003)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 13:53:10.4990
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ceabb37a-44f3-466a-9c37-08da13e6f553
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3125

Hi Stefano,

> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> +
> +static int __init find_domU_holes(const struct kernel_info *kinfo,
> +                                  struct meminfo *ext_regions)
> +{
> +    unsigned int i;
> +    uint64_t bankend[GUEST_RAM_BANKS];
> +    const uint64_t bankbase[] =3D GUEST_RAM_BANK_BASES;
> +    const uint64_t banksize[] =3D GUEST_RAM_BANK_SIZES;
> +
> +    for ( i =3D 0; i < GUEST_RAM_BANKS; i++ )
> +    {
> +        ext_regions->bank[ext_regions->nr_banks].start =3D
> +            ALIGN_UP_TO_2MB(bankbase[i] + kinfo->mem.bank[i].size);
> +
> +        bankend[i] =3D ~0ULL >> (64 - p2m_ipa_bits);
> +        bankend[i] =3D min(bankend[i], bankbase[i] + banksize[i] - 1);
> +        if (bankend[i] > ext_regions->bank[ext_regions->nr_banks].start)

Just a code style issue, the if needs a space before and after the conditio=
n

With this fixed:

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Cheers,
Luca



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:04:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:04:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297417.506641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHtR-0007pK-OP; Fri, 01 Apr 2022 14:04:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297417.506641; Fri, 01 Apr 2022 14:04:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHtR-0007pD-Kw; Fri, 01 Apr 2022 14:04:49 +0000
Received: by outflank-mailman (input) for mailman id 297417;
 Fri, 01 Apr 2022 14:04:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naHtP-0007p7-TN
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:04:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naHtN-0006T9-GQ; Fri, 01 Apr 2022 14:04:45 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naHtN-0005YA-9f; Fri, 01 Apr 2022 14:04:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ywNDoxriKSDALWk0ITu5mAZn3I5peEy1X8UuXB2U/uQ=; b=4BNkFHBjef/b77L8Xz3VVlP80C
	GL1kGLbmY4l0XhoChcLBgy0rysmDakSKGfBd1CzQC6D0Cs0x5UfhVoOHqpDDJpa+fKzIPTgBjK6cH
	f9HcyBma2g9udvO/YIJsik7WHXQC3BUp6CFprRwnJ1BHalyZn7e8ao9dtKAW4CrhpZxI=;
Message-ID: <a34092cd-0eeb-ac8b-a2f3-650f022a5e2c@xen.org>
Date: Fri, 1 Apr 2022 15:04:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
To: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
 <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
 <57312254-b599-6de5-04aa-f88907c49163@xen.org>
 <5522e39c-e7b6-eecf-526d-abe6964e068c@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <5522e39c-e7b6-eecf-526d-abe6964e068c@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Juergen,

On 01/04/2022 14:52, Juergen Gross wrote:
> On 01.04.22 15:35, Julien Grall wrote:
>> Hi Juergen,
>>
>> On 01/04/2022 11:46, Juergen Gross wrote:
>>> On 01.04.22 12:21, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> I have posted some comments in v3 after you sent this version. 
>>>> Please have a look.
>>>>
>>>> On 01/04/2022 01:38, Stefano Stabellini wrote:
>>>>> +static int init_domain(struct xs_handle *xsh, libxl_dominfo *info)
>>>>> +{
>>>>> +    struct xc_interface_core *xch;
>>>>> +    libxl_uuid uuid;
>>>>> +    uint64_t xenstore_evtchn, xenstore_pfn;
>>>>> +    int rc;
>>>>> +
>>>>> +    printf("Init dom0less domain: %u\n", info->domid);
>>>>> +    xch = xc_interface_open(0, 0, 0);
>>>>> +
>>>>> +    rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN,
>>>>> +                          &xenstore_evtchn);
>>>>> +    if (rc != 0) {
>>>>> +        printf("Failed to get HVM_PARAM_STORE_EVTCHN\n");
>>>>> +        return 1;
>>>>> +    }
>>>>> +
>>>>> +    /* Alloc xenstore page */
>>>>> +    if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) {
>>>>> +        printf("Error on alloc magic pages\n");
>>>>> +        return 1;
>>>>> +    }
>>>>> +
>>>>> +    rc = xc_dom_gnttab_seed(xch, info->domid, true,
>>>>> +                            (xen_pfn_t)-1, xenstore_pfn, 0, 0);
>>>>> +    if (rc)
>>>>> +        err(1, "xc_dom_gnttab_seed");
>>>>> +
>>>>> +    libxl_uuid_generate(&uuid);
>>>>> +    xc_domain_sethandle(xch, info->domid, 
>>>>> libxl_uuid_bytearray(&uuid));
>>>>> +
>>>>> +    rc = gen_stub_json_config(info->domid, &uuid);
>>>>> +    if (rc)
>>>>> +        err(1, "gen_stub_json_config");
>>>>> +
>>>>> +    /* Now everything is ready: set HVM_PARAM_STORE_PFN */
>>>>> +    rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN,
>>>>> +                          xenstore_pfn);
>>>>
>>>> On patch #1, you told me you didn't want to allocate the page in Xen 
>>>> because it wouldn't be initialized by Xenstored. But this is what we 
>>>> are doing here.
>>>
>>> Xenstore (at least the C variant) is only using the fixed grant ref
>>> GNTTAB_RESERVED_XENSTORE, so it doesn't need the page to be advertised
>>> to the guest. And the mapping is done only when the domain is being
>>> introduced to Xenstore.
>>
>> And we don't expect the guest to use the grant entry to find the 
>> xenstore page?
>>>
>>>>
>>>> This would be a problem if Linux is still booting and hasn't yet 
>>>> call xenbus_probe_initcall().
>>>>
>>>> I understand we need to have the page setup before raising the event 
>>>> channel. I don't think we can allow Xenstored to set the HVM_PARAM 
>>>> (it may run in a domain with less privilege). So I think we may need 
>>>> to create a separate command to kick the client (not great).
>>>>
>>>> Juergen, any thoughts?
>>>
>>> I think it should work like that:
>>>
>>> - setup the grant via xc_dom_gnttab_seed()
>>> - introduce the domain to Xenstore
>>> - call xc_hvm_param_set()
>>>
>>> When the guest is receiving the event, it should wait for the xenstore
>>> page to appear.
>> IIUC, this would mean the guest would need to do some sort of busy 
>> loop until the xenstore page to appear.
> 
> Looking for it every second or so would be enough.

This is a better than a busy loop but not by much. I would argue a 
design that requires to poll after receiving an interrupt is broken.

> 
>> If so, this doesn't sound great to me. I think it would be better to 
>> have a flag in the page to indicate whether the page is not ready.
>>
>> Xenstored could then clear the flag before raising the event channel.
> 
> Hmm, the "connection" field could be used for that.

I thought about the field but the description doesn't entirely match 
what we want. In particular, the spec says only the guest should set the 
value to 1 (i.e. reconnect). Maybe this could be relaxed?

> 
> It would mean, though, that e.g. libxl would need to initialize the
> page accordingly before calling xs_introduce()

libxl only create domain paused. So I don't think it would be necessary 
to update it.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:11:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:11:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297421.506651 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHzc-0000pw-E2; Fri, 01 Apr 2022 14:11:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297421.506651; Fri, 01 Apr 2022 14:11:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naHzc-0000pp-BF; Fri, 01 Apr 2022 14:11:12 +0000
Received: by outflank-mailman (input) for mailman id 297421;
 Fri, 01 Apr 2022 14:11:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Yu3J=UL=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1naHzb-0000pj-2Z
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:11:11 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 942b12d5-b1c5-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 16:11:09 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0F3DF2160A;
 Fri,  1 Apr 2022 14:11:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B19271331E;
 Fri,  1 Apr 2022 14:11:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id tFgKKvwHR2JCcQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Apr 2022 14:11:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 942b12d5-b1c5-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1648822269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=b5T4I/BUhiYm8R0fl+2XzTBsaChUa1rSub7WEeYdBQw=;
	b=Ux5ovpjLQ40pHrB39hmAWyE1shXjYKzcJBb7s9Agf2Rg9B8sLbp1voygPd1GqkhjdZ1CA7
	7ijVBFoxPIRvwkyg6P5rQzrqER6EyzZwAL3tC4h90/PfoxjduE6br3R5VGXRRPs5VB0MS5
	SIekvjnwCcztFYqrQZTVL894OLoUqLc=
Message-ID: <11cf2108-7210-376c-c6ac-0b5b404c0eb6@suse.com>
Date: Fri, 1 Apr 2022 16:11:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
 <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
 <57312254-b599-6de5-04aa-f88907c49163@xen.org>
 <5522e39c-e7b6-eecf-526d-abe6964e068c@suse.com>
 <a34092cd-0eeb-ac8b-a2f3-650f022a5e2c@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <a34092cd-0eeb-ac8b-a2f3-650f022a5e2c@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------Ucg8LmSg7Ye0gqYWjcOzEl0q"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------Ucg8LmSg7Ye0gqYWjcOzEl0q
Content-Type: multipart/mixed; boundary="------------VdgOorOWQQbyUILiublFBFCu";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <11cf2108-7210-376c-c6ac-0b5b404c0eb6@suse.com>
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
 <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
 <57312254-b599-6de5-04aa-f88907c49163@xen.org>
 <5522e39c-e7b6-eecf-526d-abe6964e068c@suse.com>
 <a34092cd-0eeb-ac8b-a2f3-650f022a5e2c@xen.org>
In-Reply-To: <a34092cd-0eeb-ac8b-a2f3-650f022a5e2c@xen.org>

--------------VdgOorOWQQbyUILiublFBFCu
Content-Type: multipart/mixed; boundary="------------ZSyS50h38fpkyVXDfqal718e"

--------------ZSyS50h38fpkyVXDfqal718e
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDEuMDQuMjIgMTY6MDQsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN
Cj4gDQo+IE9uIDAxLzA0LzIwMjIgMTQ6NTIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP
biAwMS4wNC4yMiAxNTozNSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpIEp1ZXJnZW4s
DQo+Pj4NCj4+PiBPbiAwMS8wNC8yMDIyIDExOjQ2LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
Pj4+PiBPbiAwMS4wNC4yMiAxMjoyMSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+Pj4gSGks
DQo+Pj4+Pg0KPj4+Pj4gSSBoYXZlIHBvc3RlZCBzb21lIGNvbW1lbnRzIGluIHYzIGFmdGVy
IHlvdSBzZW50IHRoaXMgdmVyc2lvbi4gUGxlYXNlIGhhdmUgDQo+Pj4+PiBhIGxvb2suDQo+
Pj4+Pg0KPj4+Pj4gT24gMDEvMDQvMjAyMiAwMTozOCwgU3RlZmFubyBTdGFiZWxsaW5pIHdy
b3RlOg0KPj4+Pj4+ICtzdGF0aWMgaW50IGluaXRfZG9tYWluKHN0cnVjdCB4c19oYW5kbGUg
KnhzaCwgbGlieGxfZG9taW5mbyAqaW5mbykNCj4+Pj4+PiArew0KPj4+Pj4+ICvCoMKgwqAg
c3RydWN0IHhjX2ludGVyZmFjZV9jb3JlICp4Y2g7DQo+Pj4+Pj4gK8KgwqDCoCBsaWJ4bF91
dWlkIHV1aWQ7DQo+Pj4+Pj4gK8KgwqDCoCB1aW50NjRfdCB4ZW5zdG9yZV9ldnRjaG4sIHhl
bnN0b3JlX3BmbjsNCj4+Pj4+PiArwqDCoMKgIGludCByYzsNCj4+Pj4+PiArDQo+Pj4+Pj4g
K8KgwqDCoCBwcmludGYoIkluaXQgZG9tMGxlc3MgZG9tYWluOiAldVxuIiwgaW5mby0+ZG9t
aWQpOw0KPj4+Pj4+ICvCoMKgwqAgeGNoID0geGNfaW50ZXJmYWNlX29wZW4oMCwgMCwgMCk7
DQo+Pj4+Pj4gKw0KPj4+Pj4+ICvCoMKgwqAgcmMgPSB4Y19odm1fcGFyYW1fZ2V0KHhjaCwg
aW5mby0+ZG9taWQsIEhWTV9QQVJBTV9TVE9SRV9FVlRDSE4sDQo+Pj4+Pj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICZ4ZW5zdG9yZV9l
dnRjaG4pOw0KPj4+Pj4+ICvCoMKgwqAgaWYgKHJjICE9IDApIHsNCj4+Pj4+PiArwqDCoMKg
wqDCoMKgwqAgcHJpbnRmKCJGYWlsZWQgdG8gZ2V0IEhWTV9QQVJBTV9TVE9SRV9FVlRDSE5c
biIpOw0KPj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gMTsNCj4+Pj4+PiArwqDCoMKg
IH0NCj4+Pj4+PiArDQo+Pj4+Pj4gK8KgwqDCoCAvKiBBbGxvYyB4ZW5zdG9yZSBwYWdlICov
DQo+Pj4+Pj4gK8KgwqDCoCBpZiAoYWxsb2NfeHNfcGFnZSh4Y2gsIGluZm8sICZ4ZW5zdG9y
ZV9wZm4pICE9IDApIHsNCj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgcHJpbnRmKCJFcnJvciBv
biBhbGxvYyBtYWdpYyBwYWdlc1xuIik7DQo+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVy
biAxOw0KPj4+Pj4+ICvCoMKgwqAgfQ0KPj4+Pj4+ICsNCj4+Pj4+PiArwqDCoMKgIHJjID0g
eGNfZG9tX2dudHRhYl9zZWVkKHhjaCwgaW5mby0+ZG9taWQsIHRydWUsDQo+Pj4+Pj4gK8Kg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAo
eGVuX3Bmbl90KS0xLCB4ZW5zdG9yZV9wZm4sIDAsIDApOw0KPj4+Pj4+ICvCoMKgwqAgaWYg
KHJjKQ0KPj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBlcnIoMSwgInhjX2RvbV9nbnR0YWJfc2Vl
ZCIpOw0KPj4+Pj4+ICsNCj4+Pj4+PiArwqDCoMKgIGxpYnhsX3V1aWRfZ2VuZXJhdGUoJnV1
aWQpOw0KPj4+Pj4+ICvCoMKgwqAgeGNfZG9tYWluX3NldGhhbmRsZSh4Y2gsIGluZm8tPmRv
bWlkLCBsaWJ4bF91dWlkX2J5dGVhcnJheSgmdXVpZCkpOw0KPj4+Pj4+ICsNCj4+Pj4+PiAr
wqDCoMKgIHJjID0gZ2VuX3N0dWJfanNvbl9jb25maWcoaW5mby0+ZG9taWQsICZ1dWlkKTsN
Cj4+Pj4+PiArwqDCoMKgIGlmIChyYykNCj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgZXJyKDEs
ICJnZW5fc3R1Yl9qc29uX2NvbmZpZyIpOw0KPj4+Pj4+ICsNCj4+Pj4+PiArwqDCoMKgIC8q
IE5vdyBldmVyeXRoaW5nIGlzIHJlYWR5OiBzZXQgSFZNX1BBUkFNX1NUT1JFX1BGTiAqLw0K
Pj4+Pj4+ICvCoMKgwqAgcmMgPSB4Y19odm1fcGFyYW1fc2V0KHhjaCwgaW5mby0+ZG9taWQs
IEhWTV9QQVJBTV9TVE9SRV9QRk4sDQo+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHhlbnN0b3JlX3Bmbik7DQo+Pj4+Pg0KPj4+
Pj4gT24gcGF0Y2ggIzEsIHlvdSB0b2xkIG1lIHlvdSBkaWRuJ3Qgd2FudCB0byBhbGxvY2F0
ZSB0aGUgcGFnZSBpbiBYZW4gDQo+Pj4+PiBiZWNhdXNlIGl0IHdvdWxkbid0IGJlIGluaXRp
YWxpemVkIGJ5IFhlbnN0b3JlZC4gQnV0IHRoaXMgaXMgd2hhdCB3ZSBhcmUgDQo+Pj4+PiBk
b2luZyBoZXJlLg0KPj4+Pg0KPj4+PiBYZW5zdG9yZSAoYXQgbGVhc3QgdGhlIEMgdmFyaWFu
dCkgaXMgb25seSB1c2luZyB0aGUgZml4ZWQgZ3JhbnQgcmVmDQo+Pj4+IEdOVFRBQl9SRVNF
UlZFRF9YRU5TVE9SRSwgc28gaXQgZG9lc24ndCBuZWVkIHRoZSBwYWdlIHRvIGJlIGFkdmVy
dGlzZWQNCj4+Pj4gdG8gdGhlIGd1ZXN0LiBBbmQgdGhlIG1hcHBpbmcgaXMgZG9uZSBvbmx5
IHdoZW4gdGhlIGRvbWFpbiBpcyBiZWluZw0KPj4+PiBpbnRyb2R1Y2VkIHRvIFhlbnN0b3Jl
Lg0KPj4+DQo+Pj4gQW5kIHdlIGRvbid0IGV4cGVjdCB0aGUgZ3Vlc3QgdG8gdXNlIHRoZSBn
cmFudCBlbnRyeSB0byBmaW5kIHRoZSB4ZW5zdG9yZSBwYWdlPw0KPj4+Pg0KPj4+Pj4NCj4+
Pj4+IFRoaXMgd291bGQgYmUgYSBwcm9ibGVtIGlmIExpbnV4IGlzIHN0aWxsIGJvb3Rpbmcg
YW5kIGhhc24ndCB5ZXQgY2FsbCANCj4+Pj4+IHhlbmJ1c19wcm9iZV9pbml0Y2FsbCgpLg0K
Pj4+Pj4NCj4+Pj4+IEkgdW5kZXJzdGFuZCB3ZSBuZWVkIHRvIGhhdmUgdGhlIHBhZ2Ugc2V0
dXAgYmVmb3JlIHJhaXNpbmcgdGhlIGV2ZW50IA0KPj4+Pj4gY2hhbm5lbC4gSSBkb24ndCB0
aGluayB3ZSBjYW4gYWxsb3cgWGVuc3RvcmVkIHRvIHNldCB0aGUgSFZNX1BBUkFNIChpdCBt
YXkgDQo+Pj4+PiBydW4gaW4gYSBkb21haW4gd2l0aCBsZXNzIHByaXZpbGVnZSkuIFNvIEkg
dGhpbmsgd2UgbWF5IG5lZWQgdG8gY3JlYXRlIGEgDQo+Pj4+PiBzZXBhcmF0ZSBjb21tYW5k
IHRvIGtpY2sgdGhlIGNsaWVudCAobm90IGdyZWF0KS4NCj4+Pj4+DQo+Pj4+PiBKdWVyZ2Vu
LCBhbnkgdGhvdWdodHM/DQo+Pj4+DQo+Pj4+IEkgdGhpbmsgaXQgc2hvdWxkIHdvcmsgbGlr
ZSB0aGF0Og0KPj4+Pg0KPj4+PiAtIHNldHVwIHRoZSBncmFudCB2aWEgeGNfZG9tX2dudHRh
Yl9zZWVkKCkNCj4+Pj4gLSBpbnRyb2R1Y2UgdGhlIGRvbWFpbiB0byBYZW5zdG9yZQ0KPj4+
PiAtIGNhbGwgeGNfaHZtX3BhcmFtX3NldCgpDQo+Pj4+DQo+Pj4+IFdoZW4gdGhlIGd1ZXN0
IGlzIHJlY2VpdmluZyB0aGUgZXZlbnQsIGl0IHNob3VsZCB3YWl0IGZvciB0aGUgeGVuc3Rv
cmUNCj4+Pj4gcGFnZSB0byBhcHBlYXIuDQo+Pj4gSUlVQywgdGhpcyB3b3VsZCBtZWFuIHRo
ZSBndWVzdCB3b3VsZCBuZWVkIHRvIGRvIHNvbWUgc29ydCBvZiBidXN5IGxvb3AgdW50aWwg
DQo+Pj4gdGhlIHhlbnN0b3JlIHBhZ2UgdG8gYXBwZWFyLg0KPj4NCj4+IExvb2tpbmcgZm9y
IGl0IGV2ZXJ5IHNlY29uZCBvciBzbyB3b3VsZCBiZSBlbm91Z2guDQo+IA0KPiBUaGlzIGlz
IGEgYmV0dGVyIHRoYW4gYSBidXN5IGxvb3AgYnV0IG5vdCBieSBtdWNoLiBJIHdvdWxkIGFy
Z3VlIGEgZGVzaWduIHRoYXQgDQo+IHJlcXVpcmVzIHRvIHBvbGwgYWZ0ZXIgcmVjZWl2aW5n
IGFuIGludGVycnVwdCBpcyBicm9rZW4uDQo+IA0KPj4NCj4+PiBJZiBzbywgdGhpcyBkb2Vz
bid0IHNvdW5kIGdyZWF0IHRvIG1lLiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBo
YXZlIGEgDQo+Pj4gZmxhZyBpbiB0aGUgcGFnZSB0byBpbmRpY2F0ZSB3aGV0aGVyIHRoZSBw
YWdlIGlzIG5vdCByZWFkeS4NCj4+Pg0KPj4+IFhlbnN0b3JlZCBjb3VsZCB0aGVuIGNsZWFy
IHRoZSBmbGFnIGJlZm9yZSByYWlzaW5nIHRoZSBldmVudCBjaGFubmVsLg0KPj4NCj4+IEht
bSwgdGhlICJjb25uZWN0aW9uIiBmaWVsZCBjb3VsZCBiZSB1c2VkIGZvciB0aGF0Lg0KPiAN
Cj4gSSB0aG91Z2h0IGFib3V0IHRoZSBmaWVsZCBidXQgdGhlIGRlc2NyaXB0aW9uIGRvZXNu
J3QgZW50aXJlbHkgbWF0Y2ggd2hhdCB3ZSANCj4gd2FudC4gSW4gcGFydGljdWxhciwgdGhl
IHNwZWMgc2F5cyBvbmx5IHRoZSBndWVzdCBzaG91bGQgc2V0IHRoZSB2YWx1ZSB0byAxIA0K
PiAoaS5lLiByZWNvbm5lY3QpLiBNYXliZSB0aGlzIGNvdWxkIGJlIHJlbGF4ZWQ/DQo+IA0K
Pj4NCj4+IEl0IHdvdWxkIG1lYW4sIHRob3VnaCwgdGhhdCBlLmcuIGxpYnhsIHdvdWxkIG5l
ZWQgdG8gaW5pdGlhbGl6ZSB0aGUNCj4+IHBhZ2UgYWNjb3JkaW5nbHkgYmVmb3JlIGNhbGxp
bmcgeHNfaW50cm9kdWNlKCkNCj4gDQo+IGxpYnhsIG9ubHkgY3JlYXRlIGRvbWFpbiBwYXVz
ZWQuIFNvIEkgZG9uJ3QgdGhpbmsgaXQgd291bGQgYmUgbmVjZXNzYXJ5IHRvIA0KPiB1cGRh
dGUgaXQuDQoNCk1heWJlIG5vdCBsaWJ4bCwgYnV0IHdob2V2ZXIgaXMgY2FsbGluZyB4Y19k
b21fZ250dGFiX3NlZWQoKSwNCnhjX2h2bV9wYXJhbV9zZXQoKSBhbmQvb3IgeHNfaW50cm9k
dWNlKCkgbmVlZHMgdG8gc2V0IHRoZSBmaWVsZCwgaW4NCm9yZGVyIHRvIGhhdmUgYW4gZWZm
ZWN0IG9mIFhlbnN0b3JlIHJlc2V0dGluZyBpdC4NCg0KDQpKdWVyZ2VuDQo=
--------------ZSyS50h38fpkyVXDfqal718e
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------ZSyS50h38fpkyVXDfqal718e--

--------------VdgOorOWQQbyUILiublFBFCu--

--------------Ucg8LmSg7Ye0gqYWjcOzEl0q
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJHB/wFAwAAAAAACgkQsN6d1ii/Ey9j
Vwf+KO+LAnoyGRTgZLLfgHZCxoycQqr382l4CbEOlPaXrOEQnrvybu/i7zQFihRPJ6KWgkC17QNR
4KeXj4xJQW0wanq1EknRLWNQYhoUKttgLTcQuK/7w2yt9EJkJCFvrjKwuwQVOGAwhKutiOXllMd3
kFztOtGU2J/JJGgY8nIzDHZx1fQiLT+HhlfxRs06cu+rDh0lNGoAe7ZJP84HWlak14a9Gx0XUl7f
AklRlUKxQ1ZrMFQ1Huzc+kD/8LBvlZbMUjTCNbo7Hrg4vYGdwr64Dwim91XPPjPqBvPcWoc1c132
7aKwKzbM/GIa5ssTeedx4n20UrA2rj8OFgYOnQLpNQ==
=3g9c
-----END PGP SIGNATURE-----

--------------Ucg8LmSg7Ye0gqYWjcOzEl0q--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:32:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:32:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297425.506662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIKF-0003D6-7I; Fri, 01 Apr 2022 14:32:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297425.506662; Fri, 01 Apr 2022 14:32:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIKF-0003Cz-4P; Fri, 01 Apr 2022 14:32:31 +0000
Received: by outflank-mailman (input) for mailman id 297425;
 Fri, 01 Apr 2022 14:32:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=efvt=UL=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1naIKE-0003Ct-4X
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:32:30 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8d11db65-b1c8-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 16:32:27 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 96DEA61C50;
 Fri,  1 Apr 2022 14:32:25 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C9B1C340EE;
 Fri,  1 Apr 2022 14:32:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d11db65-b1c8-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648823545;
	bh=Vj4CtnGKUb63FsBPnORkP2HBgGUmnUAO7NFD8yaKwPk=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=V9IoOOs4KK52b4HhNDRbajUpbkYDeEdjV06oDnl+DNMpRDkqplrmD3W08F4YED9VJ
	 jAfuZ8Y5mMbhfaAkDbUkzs2IMwfQ+hiv5EvUcurk2/Z6wEEZ/B/0zE1YZ5kLRRWdQZ
	 pV7Ogtr2y30/t5j9S9mgHCcO7jrYqzIRuJehDKNsn5qT5b9lBstZCfQoohJh/jxQfa
	 Hgbtvy7ZAUoW1XsDEpX0uUZZLiV/0WBINwWi+TvLx26u1gqjUwm71rFe0fuIrixSVF
	 1qFpRIhj7M0B0xcz9T10BIjWYst1pFoom8K4xhYUtnQW680IlME24TWP4xZRWOekSK
	 PbqunJ1zeLkHg==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org
Subject: [PATCH AUTOSEL 5.17 137/149] xen/usb: harden xen_hcd against malicious backends
Date: Fri,  1 Apr 2022 10:25:24 -0400
Message-Id: <20220401142536.1948161-137-sashal@kernel.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220401142536.1948161-1-sashal@kernel.org>
References: <20220401142536.1948161-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Juergen Gross <jgross@suse.com>

[ Upstream commit aff477cb8f94613f501d386d10f20019e294bc35 ]

Make sure a malicious backend can't cause any harm other than wrong
I/O data.

Missing are verification of the request id in a response, sanitizing
the reported actual I/O length, and protection against interrupt storms
from the backend.

Signed-off-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20220311103509.12908-1-jgross@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/usb/host/xen-hcd.c | 57 ++++++++++++++++++++++++++++----------
 1 file changed, 43 insertions(+), 14 deletions(-)

diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c
index 19b8c7ed74cb..4ed3ee328a4a 100644
--- a/drivers/usb/host/xen-hcd.c
+++ b/drivers/usb/host/xen-hcd.c
@@ -51,6 +51,7 @@ struct vdevice_status {
 struct usb_shadow {
 	struct xenusb_urb_request req;
 	struct urb *urb;
+	bool in_flight;
 };
 
 struct xenhcd_info {
@@ -722,6 +723,12 @@ static void xenhcd_gnttab_done(struct xenhcd_info *info, unsigned int id)
 	int nr_segs = 0;
 	int i;
 
+	if (!shadow->in_flight) {
+		xenhcd_set_error(info, "Illegal request id");
+		return;
+	}
+	shadow->in_flight = false;
+
 	nr_segs = shadow->req.nr_buffer_segs;
 
 	if (xenusb_pipeisoc(shadow->req.pipe))
@@ -805,6 +812,7 @@ static int xenhcd_do_request(struct xenhcd_info *info, struct urb_priv *urbp)
 
 	info->urb_ring.req_prod_pvt++;
 	info->shadow[id].urb = urb;
+	info->shadow[id].in_flight = true;
 
 	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&info->urb_ring, notify);
 	if (notify)
@@ -933,10 +941,27 @@ static int xenhcd_unlink_urb(struct xenhcd_info *info, struct urb_priv *urbp)
 	return ret;
 }
 
-static int xenhcd_urb_request_done(struct xenhcd_info *info)
+static void xenhcd_res_to_urb(struct xenhcd_info *info,
+			      struct xenusb_urb_response *res, struct urb *urb)
+{
+	if (unlikely(!urb))
+		return;
+
+	if (res->actual_length > urb->transfer_buffer_length)
+		urb->actual_length = urb->transfer_buffer_length;
+	else if (res->actual_length < 0)
+		urb->actual_length = 0;
+	else
+		urb->actual_length = res->actual_length;
+	urb->error_count = res->error_count;
+	urb->start_frame = res->start_frame;
+	xenhcd_giveback_urb(info, urb, res->status);
+}
+
+static int xenhcd_urb_request_done(struct xenhcd_info *info,
+				   unsigned int *eoiflag)
 {
 	struct xenusb_urb_response res;
-	struct urb *urb;
 	RING_IDX i, rp;
 	__u16 id;
 	int more_to_do = 0;
@@ -963,16 +988,12 @@ static int xenhcd_urb_request_done(struct xenhcd_info *info)
 			xenhcd_gnttab_done(info, id);
 			if (info->error)
 				goto err;
-			urb = info->shadow[id].urb;
-			if (likely(urb)) {
-				urb->actual_length = res.actual_length;
-				urb->error_count = res.error_count;
-				urb->start_frame = res.start_frame;
-				xenhcd_giveback_urb(info, urb, res.status);
-			}
+			xenhcd_res_to_urb(info, &res, info->shadow[id].urb);
 		}
 
 		xenhcd_add_id_to_freelist(info, id);
+
+		*eoiflag = 0;
 	}
 	info->urb_ring.rsp_cons = i;
 
@@ -990,7 +1011,7 @@ static int xenhcd_urb_request_done(struct xenhcd_info *info)
 	return 0;
 }
 
-static int xenhcd_conn_notify(struct xenhcd_info *info)
+static int xenhcd_conn_notify(struct xenhcd_info *info, unsigned int *eoiflag)
 {
 	struct xenusb_conn_response res;
 	struct xenusb_conn_request *req;
@@ -1035,6 +1056,8 @@ static int xenhcd_conn_notify(struct xenhcd_info *info)
 				       info->conn_ring.req_prod_pvt);
 		req->id = id;
 		info->conn_ring.req_prod_pvt++;
+
+		*eoiflag = 0;
 	}
 
 	if (rc != info->conn_ring.req_prod_pvt)
@@ -1057,14 +1080,19 @@ static int xenhcd_conn_notify(struct xenhcd_info *info)
 static irqreturn_t xenhcd_int(int irq, void *dev_id)
 {
 	struct xenhcd_info *info = (struct xenhcd_info *)dev_id;
+	unsigned int eoiflag = XEN_EOI_FLAG_SPURIOUS;
 
-	if (unlikely(info->error))
+	if (unlikely(info->error)) {
+		xen_irq_lateeoi(irq, XEN_EOI_FLAG_SPURIOUS);
 		return IRQ_HANDLED;
+	}
 
-	while (xenhcd_urb_request_done(info) | xenhcd_conn_notify(info))
+	while (xenhcd_urb_request_done(info, &eoiflag) |
+	       xenhcd_conn_notify(info, &eoiflag))
 		/* Yield point for this unbounded loop. */
 		cond_resched();
 
+	xen_irq_lateeoi(irq, eoiflag);
 	return IRQ_HANDLED;
 }
 
@@ -1141,9 +1169,9 @@ static int xenhcd_setup_rings(struct xenbus_device *dev,
 		goto fail;
 	}
 
-	err = bind_evtchn_to_irq(info->evtchn);
+	err = bind_evtchn_to_irq_lateeoi(info->evtchn);
 	if (err <= 0) {
-		xenbus_dev_fatal(dev, err, "bind_evtchn_to_irq");
+		xenbus_dev_fatal(dev, err, "bind_evtchn_to_irq_lateeoi");
 		goto fail;
 	}
 
@@ -1496,6 +1524,7 @@ static struct usb_hcd *xenhcd_create_hcd(struct xenbus_device *dev)
 	for (i = 0; i < XENUSB_URB_RING_SIZE; i++) {
 		info->shadow[i].req.id = i + 1;
 		info->shadow[i].urb = NULL;
+		info->shadow[i].in_flight = false;
 	}
 	info->shadow[XENUSB_URB_RING_SIZE - 1].req.id = 0x0fff;
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:33:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:33:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297429.506673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIKw-0003mt-JS; Fri, 01 Apr 2022 14:33:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297429.506673; Fri, 01 Apr 2022 14:33:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIKw-0003mm-GZ; Fri, 01 Apr 2022 14:33:14 +0000
Received: by outflank-mailman (input) for mailman id 297429;
 Fri, 01 Apr 2022 14:33:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AW7G=UL=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1naIKu-0003Ct-TE
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:33:13 +0000
Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com
 [2607:f8b0:4864:20::f2e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a7e407f2-b1c8-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 16:33:12 +0200 (CEST)
Received: by mail-qv1-xf2e.google.com with SMTP id k7so2147346qvc.4
 for <xen-devel@lists.xenproject.org>; Fri, 01 Apr 2022 07:33:12 -0700 (PDT)
Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:3c6c:76:9828:871b])
 by smtp.gmail.com with ESMTPSA id
 a9-20020ac85b89000000b002e2072c9dedsm2063469qta.67.2022.04.01.07.33.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 01 Apr 2022 07:33:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7e407f2-b1c8-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=lBHMZeC91ZK2tywfZph5lp9KK7X0ZdbeDNeiV0kgKAI=;
        b=HYZ2my/OxC/ZEsMBvAcR+LRHSUFTtkzIGe4/ZPBCzM3eMzQRR0Z3GVwvTfBj4ojQQC
         jssOgwlGuyUdaM4xdFpVPEVnYyzbz2q3S6Flz9MNQEmE5eqmBqftoelkSls5evqCLc7x
         i5HNC2SVHWfyykGGUCZdEVg8Rgs9GhDxxflEk+t37gzlI+WW62PPChfjTlNSItSVk9Iw
         ZrliCKNhAJ5+BP8iy5tt+3vcBpsn47A6TfzuYAsQMhlewZfWe4SyRPFQkURjqQy0rHxC
         mTdKxr4D2sRydTq0AlfyHyEwcqXzlHrEygHSwJtGuNlYnfhbIRAc7vUXXuTn93b2r2my
         C8Tw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=lBHMZeC91ZK2tywfZph5lp9KK7X0ZdbeDNeiV0kgKAI=;
        b=vaXQ+SaWC9uxer6Re5O3pnHKOPStjA2jxRZlwW8aJZrIhzlqmGmdcDt6UmoNMsl8A3
         IBG7GmuFMKdGEt0+XgOHohvPcs1HbyvV9OeGYNM3IrgTBI51d9U3+lcVEK/o0s1Mobxh
         j4MbB7DnWTBeU5Pv0FxpC9o6ATBVLFgZSBwSml2RArnT+mUv+GNiBjYF0kzZyd8DcI3j
         LxkwCioQYWK5jopChTBI7dtZSX4IU6GLONKIpBJHJAs6MuPHysqaaMXwbg4V0s8LAQDh
         WSRyFKYVi6GCpJtN+qOtVhqDamzYg4R6IkQ/Yz5v8iFSV0Syh0Ezeo2M3pK3rsMeUs5d
         Ky9Q==
X-Gm-Message-State: AOAM530ipMRnPFQJ9mNFPO95+icTS84o+2ISKpvl4WaBoP3BVx+GUvLq
	3AUCIVByHfg7VSo/ywnNa5XmzRGc2Ts=
X-Google-Smtp-Source: ABdhPJxlrj0fiVKZVXaJOyRgmS6ydclti+4tsFbT8v5kK32od7r7a1RheVCUjVvDekoxJXislPsWiA==
X-Received: by 2002:a05:6214:27e6:b0:443:6801:ac6b with SMTP id jt6-20020a05621427e600b004436801ac6bmr8337451qvb.57.1648823590182;
        Fri, 01 Apr 2022 07:33:10 -0700 (PDT)
From: Jason Andryuk <jandryuk@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Jason Andryuk <jandryuk@gmail.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2] libxl: Don't segfault on soft-reset failure
Date: Fri,  1 Apr 2022 10:32:56 -0400
Message-Id: <20220401143256.17720-1-jandryuk@gmail.com>
X-Mailer: git-send-email 2.35.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

If domain_soft_reset_cb can't rename the save file, it doesn't call
initiate_domain_create() and calls domcreate_complete().

Skipping initiate_domain_create() means dcs->console_wait is
uninitialized and all 0s.

We have:
  domcreate_complete()
    libxl__xswait_stop()
      libxl__ev_xswatch_deregister().

The uninitialized slotnum 0 is considered valid (-1 is the invalid
sentinel), so the NULL pointer path to passed to xs_unwatch() which
segfaults.

libxl__ev_xswatch_deregister:watch w=0x12bc250 wpath=(null) token=0/0: deregister slotnum=0

Move dcs->console_xswait initialization into the callers of
initiate_domain_create, do_domain_create() and do_domain_soft_reset(),
so it is initialized along with the other dcs state.

Fixes: c57e6ebd8c3e ("(lib)xl: soft reset support")
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
v2:
Add Fixes
Drop NULL check
Re-position libxl__xswait_init in callers

 tools/libs/light/libxl_create.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 15ed021f41..885675591f 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1255,8 +1255,6 @@ static void initiate_domain_create(libxl__egc *egc,
     libxl_domain_config *const d_config = dcs->guest_config;
     libxl__domain_build_state *dbs = &dcs->build_state;
 
-    libxl__xswait_init(&dcs->console_xswait);
-
     domid = dcs->domid;
     libxl__domain_build_state_init(dbs);
     dbs->restore = dcs->restore_fd >= 0;
@@ -2072,6 +2070,7 @@ static int do_domain_create(libxl_ctx *ctx, libxl_domain_config *d_config,
     cdcs->dcs.callback = domain_create_cb;
     cdcs->dcs.domid = INVALID_DOMID;
     cdcs->dcs.soft_reset = false;
+    libxl__xswait_init(&cdcs->dcs.console_xswait);
 
     if (cdcs->dcs.restore_params.checkpointed_stream ==
         LIBXL_CHECKPOINTED_STREAM_COLO) {
@@ -2172,6 +2171,7 @@ static int do_domain_soft_reset(libxl_ctx *ctx,
     cdcs->dcs.domid = domid;
     cdcs->dcs.soft_reset = true;
     cdcs->dcs.callback = domain_create_cb;
+    libxl__xswait_init(&cdcs->dcs.console_xswait);
     libxl__ao_progress_gethow(&srs->cdcs.dcs.aop_console_how,
                               aop_console_how);
     cdcs->domid_out = &domid_out;
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:33:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:33:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297430.506685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIL0-00044b-Sl; Fri, 01 Apr 2022 14:33:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297430.506685; Fri, 01 Apr 2022 14:33:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIL0-00044S-O7; Fri, 01 Apr 2022 14:33:18 +0000
Received: by outflank-mailman (input) for mailman id 297430;
 Fri, 01 Apr 2022 14:33:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AW7G=UL=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1naIKz-0003Ct-3o
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:33:17 +0000
Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com
 [2607:f8b0:4864:20::72c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aaafc2f4-b1c8-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 16:33:16 +0200 (CEST)
Received: by mail-qk1-x72c.google.com with SMTP id q200so2222185qke.7
 for <xen-devel@lists.xenproject.org>; Fri, 01 Apr 2022 07:33:16 -0700 (PDT)
Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:3c6c:76:9828:871b])
 by smtp.gmail.com with ESMTPSA id
 x18-20020a05622a001200b002eb856d7786sm1915111qtw.84.2022.04.01.07.33.13
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 01 Apr 2022 07:33:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaafc2f4-b1c8-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=tEVL8KQSMfu1CGNwcmGbmVujHFwNa0z5f5gBF9b17L0=;
        b=Pen/YLahTXvY+InrMPykWZuVWfMHj2CEBx1td8wtM8vtXZ+VS9DVQ5fwbsD8qs8JW6
         uHxjhCxLbXlVmbLehY2qfup2mjj8onU9JGhKamdIS4W+2bruq2vVJWHQKpgTcHclBT3c
         eDm80yk61uafxxC+q25hIgTrgvsK8+QfGMAkb00lzfkHMftc1jIoI1RqHdSY4oxAOZkl
         yFH230iMe69zhLAq7jeItY41Bfvf0I1aR8Bu49IGTU0ExnnaWkXxqowKXPY5OxbNCev+
         JqAUujSN+B97LMLm/07bR5OMH9OYLA1A/vz8cwQy1kVWQqL7PKLnCJjB52MIX+YaB3ot
         RSGw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=tEVL8KQSMfu1CGNwcmGbmVujHFwNa0z5f5gBF9b17L0=;
        b=MWGY26AV2SOPk5XJ3UhV09pRywnasuCS/7ETTi2In7S20FX5xg+gHm11KiWFN19Dko
         mY/wVWH/xDT4cKixlGNHXm9vBy9FG5doJ/i7ZxicIo1oGJXf0XzwEn4hurb2Q7G0pmRd
         tHu+dNb7zMJyK+YdoLafTfh6kpm6tPT6zzFtu45O5VsSHBTg+ianWqpQI/7l4F5+8AmO
         K/DAlnt/TyqjK3glAHkfb7oXX0rl+6AF7++Va+31CrHMVrpmRzIjOUHSdiJXnXV/voEQ
         +Y8ECpfBvUnN6UXXaM+cHtg12U3kWBgsy0n9aOeUf+H0O+ldObPNMBKcC/Ka81Tqe6ae
         LAFw==
X-Gm-Message-State: AOAM533CL156LFk2d0Npd8mxQwg6Jc3i3bGGNicoYUdCjmUiGyX/+v8s
	64AVVsyS1w0Ulc0Pxdm6vw+5920d5vk=
X-Google-Smtp-Source: ABdhPJwx9BzLU7NFdXRzzrzEn3GkAGQwyZ+lmNFDDnoy31BRMKYqEays8SYPFnKOnSkkmZi1YRwF5A==
X-Received: by 2002:a05:620a:a57:b0:67d:396a:8a9d with SMTP id j23-20020a05620a0a5700b0067d396a8a9dmr6904809qka.322.1648823594895;
        Fri, 01 Apr 2022 07:33:14 -0700 (PDT)
From: Jason Andryuk <jandryuk@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Jason Andryuk <jandryuk@gmail.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2] libxl: Re-scope qmp_proxy_spawn.ao usage
Date: Fri,  1 Apr 2022 10:33:10 -0400
Message-Id: <20220401143310.17743-1-jandryuk@gmail.com>
X-Mailer: git-send-email 2.35.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

I've observed this failed assertion:
libxl_event.c:2057: libxl__ao_inprogress_gc: Assertion `ao' failed.

AFAICT, this is happening in qmp_proxy_spawn_outcome where
sdss->qmp_proxy_spawn.ao is NULL.

The out label of spawn_stub_launch_dm() calls qmp_proxy_spawn_outcome(),
but it is only in the success path that sdss->qmp_proxy_spawn.ao gets
set to the current ao.

qmp_proxy_spawn_outcome() should instead use sdss->dm.spawn.ao, which is
the already in-use ao when spawn_stub_launch_dm() is called.  The same
is true for spawn_qmp_proxy().

With this, move sdss->qmp_proxy_spawn.ao initialization to
spawn_qmp_proxy() since its use is for libxl__spawn_spawn() and it can
be initialized along with the rest of sdss->qmp_proxy_spawn.

Fixes: 83c845033dc8 ("libxl: use vchan for QMP access with Linux stubdomain")
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
v2:
Change subject
Add Fixes
Change to using sdss->dm.spawn.ao

 tools/libs/light/libxl_dm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
index 9a8ddbe188..1864ee30f0 100644
--- a/tools/libs/light/libxl_dm.c
+++ b/tools/libs/light/libxl_dm.c
@@ -2567,7 +2567,6 @@ static void spawn_stub_launch_dm(libxl__egc *egc,
             goto out;
     }
 
-    sdss->qmp_proxy_spawn.ao = ao;
     if (libxl__stubdomain_is_linux(&guest_config->b_info)) {
         spawn_qmp_proxy(egc, sdss);
     } else {
@@ -2584,7 +2583,7 @@ out:
 static void spawn_qmp_proxy(libxl__egc *egc,
                             libxl__stub_dm_spawn_state *sdss)
 {
-    STATE_AO_GC(sdss->qmp_proxy_spawn.ao);
+    STATE_AO_GC(sdss->dm.spawn.ao);
     const uint32_t guest_domid = sdss->dm.guest_domid;
     const uint32_t dm_domid = sdss->pvqemu.guest_domid;
     const char *dom_path = libxl__xs_get_dompath(gc, dm_domid);
@@ -2598,6 +2597,7 @@ static void spawn_qmp_proxy(libxl__egc *egc,
         goto out;
     }
 
+    sdss->qmp_proxy_spawn.ao = ao;
     sdss->qmp_proxy_spawn.what = GCSPRINTF("domain %d device model qmp proxy", guest_domid);
     sdss->qmp_proxy_spawn.pidpath = GCSPRINTF("%s/image/qmp-proxy-pid", dom_path);
     sdss->qmp_proxy_spawn.xspath = DEVICE_MODEL_XS_PATH(gc, LIBXL_TOOLSTACK_DOMID,
@@ -2685,7 +2685,7 @@ static void qmp_proxy_spawn_outcome(libxl__egc *egc,
                                     libxl__stub_dm_spawn_state *sdss,
                                     int rc)
 {
-    STATE_AO_GC(sdss->qmp_proxy_spawn.ao);
+    STATE_AO_GC(sdss->dm.spawn.ao);
     /*
      * Until xenconsoled learns how to handle multiple consoles, require qemu
      * in dom0 to serve consoles for a stubdomain - it require at least 3 of them.
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:34:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:34:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297435.506696 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naILl-0004tZ-6E; Fri, 01 Apr 2022 14:34:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297435.506696; Fri, 01 Apr 2022 14:34:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naILl-0004tQ-34; Fri, 01 Apr 2022 14:34:05 +0000
Received: by outflank-mailman (input) for mailman id 297435;
 Fri, 01 Apr 2022 14:34:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naILj-0004tC-SW
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:34:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naILj-00071X-Dm; Fri, 01 Apr 2022 14:34:03 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naILj-0007hi-7r; Fri, 01 Apr 2022 14:34:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=QckjSnYtWxN8aKK8n0KmmGy+s/oafD5tWXX4ou/4je0=; b=tIrJv9FI4fYh6Q2ulBa0bM7JId
	bTHsT1qznJa+GsntZSLqmytQtIsnybZjTmxMTiwntgu2CpzoPyhxU8Rw7+J4GzWtqwbzOfkdmHc39
	avoo3GIQ2+P1GGdLox9M9gGzyB8myKwDcRMcO7uphA/5VGV4vBbvUKhRvPhcyjnDXlA8=;
Message-ID: <6b93c6c9-1afe-8ae9-ad7c-227ecff5cb53@xen.org>
Date: Fri, 1 Apr 2022 15:34:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v4 2/9] xen/arm: implement domU extended regions
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-2-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220401003847.38393-2-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 01/04/2022 01:38, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> Implement extended regions for dom0less domUs. The implementation is
> based on the libxl implementation.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> ---
>   xen/arch/arm/domain_build.c | 42 ++++++++++++++++++++++++++++++++++---
>   1 file changed, 39 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 8be01678de..b6189b935d 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1324,6 +1324,35 @@ out:
>       return res;
>   }
>   
> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))

I think this is the same as ROUNDUP(x, SZ_2M).

> +

> +static int __init find_domU_holes(const struct kernel_info *kinfo,
> +                                  struct meminfo *ext_regions)
> +{
> +    unsigned int i;
> +    uint64_t bankend[GUEST_RAM_BANKS];

Looking, you only seem to use one bankend at the time. So why do you 
need to store all the bankend?

This should also be s/uint64_t/paddr_t/. Same for two other instances below.

> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
> +    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
> +
> +    for ( i = 0; i < GUEST_RAM_BANKS; i++ )
> +    {
> +        ext_regions->bank[ext_regions->nr_banks].start =

The code would be easier to read if you define a local variable ext_bank 
that points to &(ext_regions->bank[ext_regions->nr_banks]).

> +            ALIGN_UP_TO_2MB(bankbase[i] + kinfo->mem.bank[i].size);
> +
> +        bankend[i] = ~0ULL >> (64 - p2m_ipa_bits);
> +        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1); > +        if (bankend[i] > ext_regions->bank[ext_regions->nr_banks].start)

Coding style:

if ( ... )

> +            ext_regions->bank[ext_regions->nr_banks].size =
> +                bankend[i] - ext_regions->bank[ext_regions->nr_banks].start + 1;

This is one of the line that could greatly benefits from the local 
variable I suggested above. It would look like:

ext_bank->size = bankend[i] - ext_bank->start + 1;

> +
> +        /* 64MB is the minimum size of an extended region */
> +        if ( ext_regions->bank[ext_regions->nr_banks].size < MB(64) )
> +            continue;
> +        ext_regions->nr_banks++;
> +    }

NIT: We tend to add a newline before the last return.

> +    return 0;

find_memory_holes() and find_unallocated_memory() will return an error 
if there are no banks allocated. I think we should do the same here at 
least for consistency.

In which case, the check should be moved in make_hypervisor_node().

> +}
> +
>   static int __init make_hypervisor_node(struct domain *d,
>                                          const struct kernel_info *kinfo,
>                                          int addrcells, int sizecells)
> @@ -1374,10 +1403,17 @@ static int __init make_hypervisor_node(struct domain *d,
>           if ( !ext_regions )
>               return -ENOMEM;
>   
> -        if ( !is_iommu_enabled(d) )
> -            res = find_unallocated_memory(kinfo, ext_regions);
> +        if ( is_domain_direct_mapped(d) )

I believe the code in the 'if' part would work properly for a dom0 that 
is not direct mapped (e.g. in the cache coloring case).

If it doesn't, I think we need...

> +        {
> +            if ( !is_iommu_enabled(d) )
> +                res = find_unallocated_memory(kinfo, ext_regions);
> +            else
> +                res = find_memory_holes(kinfo, ext_regions);
> +        }
>           else
> -            res = find_memory_holes(kinfo, ext_regions);
> +        {

... and ASSERT() here so we the person that will introduce non direct 
mapped dom0 can easily notice before the domain get corrupted.

> +            res = find_domU_holes(kinfo, ext_regions);
> +        }
>   
>           if ( res )
>               printk(XENLOG_WARNING "Failed to allocate extended regions\n");

This printk() and the others in the function should print the domain.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:37:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:37:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297442.506706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIPG-0005dv-Mv; Fri, 01 Apr 2022 14:37:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297442.506706; Fri, 01 Apr 2022 14:37:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIPG-0005do-K1; Fri, 01 Apr 2022 14:37:42 +0000
Received: by outflank-mailman (input) for mailman id 297442;
 Fri, 01 Apr 2022 14:37:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dc+m=UL=citrix.com=prvs=083d63866=roger.pau@srs-se1.protection.inumbo.net>)
 id 1naIPF-0005di-6A
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:37:41 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4674ec30-b1c9-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 16:37:39 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4674ec30-b1c9-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648823859;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=SBM3jReMSp0MTOSrb5YlZ9UJt9sCxFzYbrvxT8/ggqw=;
  b=eiKLZtdnOKneJ3vjC1jR9NSiIQrkMrSMRFAzIWDIKSlFZ3J0iSDg15LH
   yKFuiRwdtLCGjFI66R6Ffr2qV3S56vhZPw3TO98XdGsY+fQoa1J3w+BjL
   vB3tIN1Xwi3VtswBVBygaG/IepKke7I4ycU2F3xTyqHdmSodDYCJMiRl5
   0=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70164522
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZZ97BakRZlYc+zMvskYiZS3o5gy+JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIcXWiPO/vbamr1c40kbIq//UgBv8Lcz4dhHFNlpX82ECMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1rV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYVSY2GoeXoOAkWhB5GGZsJ5V/07rgGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQq6HO
 ZZEM2AHgBLoXhNuPHI7Lb0CgMzro3XEcw1Imle5nP9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt
 m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCglee22gSAx0+TkagrL+yjUvWc8JSL
 QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS9wWl2qfSpQGDCQA5oiVpMYJ88pVsHHpzi
 wHPz4iB6SFTXKO9VVOC0p3PlTeLMCE0JigQfxc9Zg4i2oy2yG0stS7nQtFmGa+zq9T6HzDs3
 jyHxBQDa6UvYd0jjPviow2e6964jt2QF1NuuF2LNo6wxlkhDLNJcbBE/rQyARxoCI+CBmeMs
 3Ef8yR1xLBfVMrd/MBhrQhkIV1I2xpnGGCE6bKMN8N4n9hIx5JFVdoPiN2ZDB01WvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMooRP8IrLF7WoXwGiausM4bFyhdEfUYXY
 8rzTCpRJSxCVfQPIMSeGY/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9zbmQp
 CjnCh4FkDISRxTvcG23V5yqU5u2Nb5XpnMnJy08e1Gu3nkoe4G066kDMZAweNEaGCZLl5aYk
 9Ftlx28P8ly
IronPort-HdrOrdr: A9a23:hNxBx6O+zWTsusBcTzf155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/exoX5PwO080lKQFmrX5WI3NYOCIghrPEGgP1/qB/9SCIVyAygc+79
 YYT0EWMrSZZjIb/KXHCWGDYqodKbK8gceVbInlvhJQpVYAUdAc0+41MHfsLmRGAC19QbYpHp
 uV4cRK4xKmZHQsd8y+Ql0IRfLKqdHnnI/vJUduPW9u1CC+yReTrJLqGRmR2RkTFxtJ3LcZ6G
 DA1yj0/L+qvf2XwgLVk0XT85NVst38zcYrPr3EtuElbhHXziq4boVoXLOP+BgzveGU8V4v1O
 LBph8xVv4Dnk/5TyWQm1/AygPg2DEh5zvJ0lmDm0bupsT/WXYTF9dBrZgxSGqV12MQ+PVHlI
 5b1WOQsJRaSTnamj7m2tTOXxZ20mKpvHsZl/IJhXA3a/pVVFZol/1RwKppKuZPIMqjg7pXUd
 WGTfusr8q+SGnqI0ww5QJUsZyRtndaJGb1fqFNgL3X79FspgEJ86Ip/r1gop4+zuNMd3A93Z
 W9Dk1JrsA7ciZEV9MLOA8+KfHHeVAlByi8cl6vHQ==
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="70164522"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UaYNmnCu4pSbJdM62yI4HnbVe6YCskTvqPBGy9PrDwBR4+DmKTTbwBojmfjFVr6MQ7BAcDZ3+pL1+QRhm9cp9DIX+KppMh3UMav4NsASvvi5c22ad3usbfVKreBpv0bRGIzoOThKHXhCip2MLhdUgXAbolWSGo7MD9Amgr0tQdDqFvJlvkucD78stJT7FiZg0DV7itnB885cl2V47dafBc0Cp/XZrtyE5uGMKbMZfVBMMKdgGUOZ8uX/p4rxS/Zv4UkCciHe/5Mp16RaLJCHEMb0mJbcRx67BxmUg1v3sqPpCGMOP49Q+ShuZXOCRaFS7i3U4qswr9HMq6Bi/Hq97Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b8SoxtM7TVWy0iuy4I2h1zyL+9dHRA10iClwSi6jFxo=;
 b=RU4Ej5wm65f8XGeonNN6JJ5mYPBgXpWOiB8retcFGEDsch3/XtO7DFHbzXd0wsF3cmu9MrX73YBXYW5npN7CCiDG1teJPJLN3Xt/HNN+5+yiwzwq0mGc4KRA9F3MK4PgRdkYLJojnORRlwyiel7k1q01ltBLe62d9qyfMvYNip3SgnlZhimbukrdMBxBOZraLe7pbqG9PkIu2JL8funfmhXdDKt06604iTjypjpObs08M9MycA0okKvFNkPSZf+qTnIBc3Aj4mDEptEtNOa+567ssr+INok0grclMUTirzRHescs7rBIDepqlM1iT8h/o2aWlVz8EUf0G6wRNC2dRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=b8SoxtM7TVWy0iuy4I2h1zyL+9dHRA10iClwSi6jFxo=;
 b=tsIu/LTWO0bq5t1aQWsEbzLTnRw5JwFjPz44CO3FPbWniRXikE678KCeX6Mm+7wEuh+9a3SSBiuTRPlruwsg6e6/nDgh0nNHHVFNu1+ap0LfJbUqAT+zAmqlpa2l4m3BBGpxG8pLyhVBZrjiLmGNE/o9df8xFJfqYeU0cxH64XM=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Subject: [PATCH 0/2] firmware: build fixes with gcc-11
Date: Fri,  1 Apr 2022 16:37:17 +0200
Message-ID: <20220401143720.23160-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO3P123CA0003.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:ba::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a6382def-dc38-4512-e8fa-08da13ed2900
X-MS-TrafficTypeDiagnostic: SA2PR03MB5801:EE_
X-Microsoft-Antispam-PRVS: <SA2PR03MB5801017AC9614151793460018FE09@SA2PR03MB5801.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: nWTXz5QGPXraiZdj9TG6aQC1nNK+AV9x9P0BNY4Zm0KURowBk973/aX3Jrz30ALqgD+dAOBaatDXyAgA0zaNbcmQknQOI8pcOufffNPu/rq8PCqJMedYf/rNXVgtFeVDF+Fr69F/hoFRV37flaZVBCmQrzrY/IhQ+bCEeZBMV8XsOL3EVmBnMpsBWFKWUG+QxQ0rKX0ZMM501Qd+MldcWo7c3u5GKp49k7vwQuR8JKdCLKJ08x/6dTnueAzCndBl6J8ciOppRokF/2SD773n4EH8Qp9c8Qd0ZI/OOhHgZdAApHGOT9xRRURxBjhjuk9UHkaSXj8riZNr8LLTQujEZiT7osoOj8L+rKLnL0MyBMRJX9X5diymNUakXXGj9ZeVT2ggk8wwVfHDgxVP9Uw0e7YA0lKj7Sk+hpDZDTgHN0LWPTM90yzXRcctRok/4KkDBUhKO/xLAkRZtx/BdqBuSjYeB0+FTRg7HEzwJphU7rOd1s0e0JH4Gd0vhFHW8eb+kzgjnHp7ATnesZXRLPJjdGtxf0TM6Ixp81V/VqKVtJUSTdxE7CB1SQJSE7SVG7WX5WjncSrKcICmJrP93uS3yIEu8by/tmnU2tRm83bC+6L4Aj6Kd+79MfJMJ6yyyD42k83uEpxpDMoW4rZoXQwsZw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(66476007)(66556008)(36756003)(8936002)(4744005)(6916009)(2906002)(66946007)(316002)(54906003)(508600001)(6486002)(6512007)(6506007)(6666004)(8676002)(4326008)(82960400001)(186003)(38100700002)(83380400001)(26005)(2616005)(1076003)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFgzZHptMU1Jak5weWFld0p0OHZWYUZ2MzZaNE8xUnpvamtycXl5RzhBWGRo?=
 =?utf-8?B?MkNnR2ZRVHJQcURjbE01dThyVEdMVGZGQkdqUE5tZ3ltY2laTkZVK3FNdk50?=
 =?utf-8?B?RzVYczdYQ1gxNHBENzEvNUZrQmprdWlUcDBTWGhBOXRMTUM3bzJGcW16eDVv?=
 =?utf-8?B?M2x3V0RiTVlRV2NDL0RUTDlzSnBwSFZQTGd4N2UwNDR2bWVmNlh4YkJESlEv?=
 =?utf-8?B?MW9hNlhZakRDeWdaV2tOczZxbVVIM3lwaEltRmpGc244MnR3czcwVUFrZjZ3?=
 =?utf-8?B?M1RJVjhmWUZRaU5Ec0ozMWtacWZRTi9VcjEvMnFoTDlTUTZsSE1HNHJHNUFn?=
 =?utf-8?B?UmcvY2FVM1hTMGlHaEdIdEE1VWtSeGNLNjlZUDhGWDFLb0pFWDJ2MWttQjd1?=
 =?utf-8?B?Zi9uckFQaGhKNm9RdmY4Z3U3TTJ1Q0hrcnN1dm9wTy9tSE5wejZsMjYwSDVN?=
 =?utf-8?B?emhpd1k5TGthbHJ2RHhRTUg3dzNGWW5tZ3ZiYktZeVJkeWhNcjNYV2xhb2lh?=
 =?utf-8?B?TTIvbCtDNkFhK1BGZVRtUWQ4dUZLcW9yL25jeHIybGxNTkIwK2s1dWhvQUxq?=
 =?utf-8?B?aGRkK2thVWNlMFhGMktFNFFSUzJJNFZDOWNMSGlxZDVybG9ZVmhwS0M3ckZa?=
 =?utf-8?B?MWhvaFFzaEF1bTl6d21vNE13eEJiaFFmb0dwYUc2OEk4RytycnZmQ1hvR0dr?=
 =?utf-8?B?Ym82VGJaTnFEWk5oQ1NsT1gyREs5QURHTHk2UlpTeVptOWxhZ3loM2VZTWc3?=
 =?utf-8?B?QnpoV1JCazBTSWdhOVVMeTd5c0RtUGtMRkFEWGtjK0JwQWorK1M3S2luMjRM?=
 =?utf-8?B?R002ZUJKYXZyQnBYejRIMjZjWXE5bE1ocDFjKy9UMmtHcVcyMVZhaGQ5Ry9l?=
 =?utf-8?B?QnEvUW9hc1ZyQ0RWdmowaUgyam5hbnY4eDhCelRXUEY2YWhBalZXOTVUU3Yz?=
 =?utf-8?B?allWVndISUM0RWVFWUR2Rzc2QkxtdWp1S2R6N091ZE50dzJrVWhWanUzVUlw?=
 =?utf-8?B?V1huWXg5cThMeEtqYjB5STkwcS9wa05HYUJxUm9LOWZXcUMxOVNXQnhZSGNE?=
 =?utf-8?B?ZFpTWUtmb2NoVWc5UXBBUC85WGNBQS9mR0NLUlJXRzJVZ2hDYmNIY1ptajEr?=
 =?utf-8?B?bTBpTDBMWTZ2aUp2endpaWViTlh2dkFFM2NsVjY4cGl1U251cUdic04xa0V1?=
 =?utf-8?B?SnJoRFYyUEF5eGdmTmxxSzZ0VVlVS0pSNmNjdFZWN3F6cTJwUE1xYmZNQUFa?=
 =?utf-8?B?aVl6YUZlVHhsWFVoaDlHYVN5ckNxWGp2OGZ3Z1BnWS8yaEpENFlHRWh6NlFv?=
 =?utf-8?B?ZnpnbkNIcFl5QkEwNE1tbGVWQmJGOWR3cDhib3NzMjl5TVJybTljaFhYQUR5?=
 =?utf-8?B?ZCtjUlczS2hwQWxxb2hzWlRBTzkwK0xnRTBFYmJVbkhlUU1ULzlyWkJQVjZU?=
 =?utf-8?B?bmtaMHg3b00xcEZxOXpnTUhDanNCUXVQVXRCdGVDeWZZenVxbDNoZkltQjNi?=
 =?utf-8?B?OGFqMXIwMFArQ01ZbG1ETDQvVnhLOUQ2UGIrbDJYVGhZOFFTSWVpZjlNYmRW?=
 =?utf-8?B?ZnFxcWM1M1doNlp4Q2kzOVNuMlZvUUgvR2ZVSDVNVng4RmE3T3hzcnd1ZmZZ?=
 =?utf-8?B?d0lDVjZyek1BbGY5czJuU1BkK1JjS1FXOGR1Vko2ZlprU3RMdzJ2WU1Ib2V3?=
 =?utf-8?B?eFJTNkJ0OUhEVjNUbHlrN2o3M1V5Z3FReUhzaE1HTjNodENDYnZxSWRNWk94?=
 =?utf-8?B?ZlU4eWorcVJJMGU0d2lDYTBTdG9BRXVvZkZiY1NWNVhHMEVsckRIQ3FuOWxl?=
 =?utf-8?B?c25ZUGVwYThwWHVmbEptb3FxSHlaM0lNL2ZGTGFtQWdOeGxQdUpyVUpveEta?=
 =?utf-8?B?Ymc2L0UvQUZZQTZkRldTTzFacDcyWFphbTQyS1pYWU1CdlJub2gyeHFlSXpN?=
 =?utf-8?B?WWF5bDRNd1J3Ymh3VzllOGpOT0Q0M1htdmVTNC9lR0hjQkRsRUdrbUt2MjRs?=
 =?utf-8?B?cGhjNXk5NWNGd1FFVXNUV1RraklYdHg3MTllRmRKUEFoYzcreUpQOGV4a3pt?=
 =?utf-8?B?N1JlK0duZ29XQlI1MlpuOThmajhRY21wT1M1Sy80bWt3cmlvemVMYm83WUJh?=
 =?utf-8?B?YU1NVGRHYUYwUmYrTEgxZUgxUUxDWlNjMWRORUI1Unk3QU95YTljVTErL2Vy?=
 =?utf-8?B?QkRFd3FLWE8rTnMxSmZtc0hmZ2VLYnlKRXBoc3FPTnR4K2dBQzZYZUhMYmY1?=
 =?utf-8?B?ckhXU2lFL0JBY3gzMEEwNEtSaHRnMjJPbGZldkFhaHR0ZGJVcERnZWVGMnRV?=
 =?utf-8?B?QldvV2hCQzhCYk11ZnBWajFhZkdhWVp0TVppS29HVHEzeWM4T0kxUT09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a6382def-dc38-4512-e8fa-08da13ed2900
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 14:37:34.3542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zEO3APC113Ebq4XSL85NcFFBhvBFxlMw+c7xclGEcxaDXoiDaOI3c/hJUhWQtM74QZihNWp7WvzE8Cl2ycP4CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5801
X-OriginatorOrg: citrix.com

Hello,

The following fixes some firmware build issues with gcc-11. Note that
dropping of .note.gnu.property section could likely be done in the
linker script in the hvmloader case, but rombios has no linker script
and such note is causing a non-working image. Other options could be
using objcopy to drop the section, but those seems more complicated than
just using the compiler command line option.

Thanks, Roger.

Roger Pau Monne (2):
  tools/firmware: fix setting of fcf-protection=none
  tools/firmware: do not add a .note.gnu.property section

 Config.mk               | 2 +-
 tools/firmware/Makefile | 2 --
 tools/firmware/Rules.mk | 6 ++++++
 3 files changed, 7 insertions(+), 3 deletions(-)

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:37:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:37:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297444.506718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIPX-00062o-5G; Fri, 01 Apr 2022 14:37:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297444.506718; Fri, 01 Apr 2022 14:37:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIPX-00062h-0L; Fri, 01 Apr 2022 14:37:59 +0000
Received: by outflank-mailman (input) for mailman id 297444;
 Fri, 01 Apr 2022 14:37:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dc+m=UL=citrix.com=prvs=083d63866=roger.pau@srs-se1.protection.inumbo.net>)
 id 1naIPV-00060A-6P
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:37:57 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5061d88b-b1c9-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 16:37:55 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5061d88b-b1c9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648823875;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=gOh+MbI5/vyzNf9U+I3QlasMd5sBpWWXSGlu8Dw3/pI=;
  b=NUvYvASnsug4bdXo2/oQbPdmjgRtXXKpeC8puzsXKT5JxWnhoAcE6RKi
   GlCb82M9S9nMMoyZ4IAZPcZ9k9t/ISkS4ixX14OSMYTgxJ3kBXHJXy2lK
   4sK4pGxW4+9wsd+GXXjc7/SAP53nLho3OHX8RpnIqnINsWBJcEAoiibb7
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67673382
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:GMiM8qxFqMnmyzK23KR6t+cIxirEfRIJ4+MujC+fZmUNrF6WrkUAm
 2RNUDrSPa6LZmHweIwna9+38EoF7JPQzINjHQc9/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YHhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplvJ/tTiMVPYvwvssYVxN5EC9aB+pGweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J8QQq2FN
 5BxhTxHYzvcSEdGBVguCpMbnMOZi1/iSBZJgQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKa9lq8i+mJmjn0MKoQCbm5+/hCkFCVgGsJB3U+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yFaGtBMBX9tbE8Uh9RqAjKHT5m6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJHub7ITlah9ZGoixy3PSI0LmEmX2gEdF5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1
 JTvs5jPtbteZX1hecHkfQnsIF1Lz6vdWNE/qQQ2d3XEy9hL0yT8FWy3yGsiTHqFyu5eJVfUj
 Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27CqCLM4AUOskgKVLvEMRSiai4hT+FfK8Ey/xXB
 HtmWZz0USZy5VpPklJauNvxIZd0n3tjlAs/tLjwzgi90Kr2WZJmYextDbd6VchgtPnsiFyMq
 753bpLWoz0CALyWSnSGquY7cAFVRUXX8Lir8qS7gMbYeVE4cIzgYteMqY4cl3tNxPoNzL6Sr
 iDgAie1CjPX3BX6FOlDUVg6AJvHVpdjt3MreysqOFejwX84ZoizqqwYcvMKkXMProSPEdYco
 yE5Rvi9
IronPort-HdrOrdr: A9a23:Er8fYKp03IRFkL+FERwdgvUaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBfhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSpQEIdxeOlNK1kJ
 0QCJSWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYWcegDUdAf0+4TMHf9LqQZfngiOXJvf6
 Dsmfav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QZiApIs+PvP+UpgNdtvpOfHHclAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="67673382"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AMgTfOOEbgSizV2T/0ybHtkedXa0//FktUTPSJRDwER5kxzzw4i/eqTD2VPDU3oglKmMGKZ5XrWMBiYPTW/CeviANQAxbk4JZVFF2pV/tfJIwOaPRPvi5pgP1OAB0NWtF85H5gxpEj60Kf36eDD+htIwx84E8vtB/46PZWIzLiXY2xJfjPhjg+9iAY5FCe4PvJ4NwuYJbspD5cj4OWbuqJvy+67jDhqzNZ+TPiBC5GpcVdqcpYfiBnmSx7gUpwEFZ4jm0ci4y4vUK7Oxnz4uroESbvTPH4wnk1ryKlHoYp0piazE/fE8VNb8PnEaZaqBJVepWpTDFsho3b3Rsuk7mw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0WF9KvEYEzdfBix0SwaBl+hEi0VZ8z9aUzi13sJkjWA=;
 b=L8MBkNjSx7UiOtV3YJlr74jXJa/dC8RSEMdu8/jOYdM7a/MMcnl8R7b3II9DnI7RHA0hvMEOU513e+u5hJzQEtpCscSkKnE23bg7At94JisdC2zzq+RQLxxKz3gYPDwJNelnbrIU/yFQ15rYbPhLawMDhIjrN6w745gdGYQs8dhMWspEBkUEkfIfjbZ5iBd9OBbLJbu2og0L1BFrUoM9l3oQhjuNGXWp+glgOvrSyHvrRNh9BjLG+Gs61FImihbA3TxX/9jdGKJlOLsoBgiUNIDEQdjDB9mDdm38JnX4cxr3KxYifL99A+l6ngZ8tTId7Hzax4fA1KF+HYsx8r8T+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0WF9KvEYEzdfBix0SwaBl+hEi0VZ8z9aUzi13sJkjWA=;
 b=mXiXkw5Yt5kRS6giOh+cEpU8uozIBNKu0/ZIaQiSaUZ+Pvlfh+wkxrT3yapsEFWgE8OR9X+78zQHT7X9/8urwAmqZZsFb1ltrFR3IYis1OFOjsXocdzu+fR6oVZ+FB0rVcsuoUBCdXqK/LRfUEe3IPU3AEMQMtrfy4aU4CmM3Yk=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH 2/2] tools/firmware: do not add a .note.gnu.property section
Date: Fri,  1 Apr 2022 16:37:19 +0200
Message-ID: <20220401143720.23160-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220401143720.23160-1-roger.pau@citrix.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO3P123CA0002.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:ba::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4879c129-b41f-4751-3986-08da13ed2f5f
X-MS-TrafficTypeDiagnostic: SN2PR03MB2398:EE_
X-Microsoft-Antispam-PRVS: <SN2PR03MB2398FE72D5BAAE4CD9F6BAA18FE09@SN2PR03MB2398.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1P2d7j14NLWb4FNcf3AY92rRol3skARChpdxMy9nqtO23ede1eWIc8eJLeoevqdFR9HVDqcl8sBi2VVLIKMKRTvEd1FBxL9zGX2ROLAVAA+5CYmmK/yyxKqhaqy1+WYmZLONWEUVzj4kNpDVqCaS1E8JDd8/BOmkxxu47k2uMwh+bFv+igFg9XfhE0STmY9JfQebNrYl5WVgNXX6/df1oCuJT0qgzFgw2NghBB9Oq+ylSej1rtqWxBpX1lN2k2HnmVlLQaq1HV4WYjJ6jPN609vuhcCc7+PYQ+oF8nFLrxRYwIdetiBXPh6OWGLULOrdDopxQPgRvk9VDLEENNMAGnL/RJdhuXT1/y3SenJmjHp3QqLaJuR2KIcNLtW3esRbW0456DxcW6HpWZS2rnS9IQbxNt4ronPl2GjCbA1Kr1PsK7uh3J8hvIqAd4aa7gylKYdlTjKOOA7wnanLmwvEIT3OhipgAweVqQ4iKAEPo9ZuT3HOJGGrm2smWz1TQkFfrNrMCvKpjjHZb8eVNwbGoQxetdgqnhoI8GU8GoTG3zpUmnA7RDAXSCFe2xDDAaf9Qg5gUrg66f4+oEbQD3pVfMuYuS3ypWZR9lLRtm/qClcvHGpTppk4UJrDs1jpIsRQ6enIGNBixptmFjkrcOzK9kCO4Q2a8oP1FkT/N6yONl9nbZZxbUi8JQGHi3lXd8zYvLFRuIihoQmYAzgM1WR59w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6916009)(107886003)(54906003)(316002)(38100700002)(82960400001)(66946007)(2906002)(6506007)(5660300002)(508600001)(83380400001)(6486002)(66476007)(8936002)(2616005)(86362001)(66556008)(26005)(4326008)(6512007)(8676002)(6666004)(186003)(1076003)(142923001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG9SKzZnd2JqSEdiSnBVbldPZnNHMXpjZUExcGtiYmJJV2c0UW5MZVBlSC92?=
 =?utf-8?B?cDN2N1lQSVhSOFdzSkFGcHdMTWRUQkFCQmxrcDFnMCtBazJtSXZtNzNuVW1Z?=
 =?utf-8?B?c2c4Nmo0M3hVZmtQZ2owaXBLUXZmaFFUOW4xNk1GQ2psOFo0L2E1ZFQ4OHJt?=
 =?utf-8?B?S3N5M0c0eEFyajR3Tlp3d1ZjWmlmWURMbWxIQW5BZVZnMmtORWViejlJQmY5?=
 =?utf-8?B?dTA4QzZrOXZLaFBaOG1DaGpqVnFzWmdiQ0Ixc0hxTkRuK3J6d1huQWc4Yll1?=
 =?utf-8?B?TTQvSldacGFHWUM5SG5IeWFkUUVLcy9pTmYwOU8vaVpaZVI4VmVJN0NwTDJW?=
 =?utf-8?B?cDFBSHZRN2U2RC91Qis4Q0c0MkdIaExHZTd0bEVTamR0ak5Rbm9na3AweWlq?=
 =?utf-8?B?MUhnQ3RpdzVIdUZtMjNZMHhjSExtR1VqL28vZU1teXA5eE9yZzYxZW14L1Bx?=
 =?utf-8?B?SlQ2VmlCemc5OEZYWTJrZWZ4OGVQbWZGTlo5OE5KRHkvcUtWQk1rVUNFaW5k?=
 =?utf-8?B?ZWpZY2ZvdHltKzN0eWw3SlNNc0NSc3ZCSXhFMkV0OXVGN0N6cmkrYVlHUDND?=
 =?utf-8?B?SWx6YkphZVlzNmVwNzc4d3pkT2ZMcG9lcHFaK2x6Ri9CTmRDTmZ3bXF5SDBq?=
 =?utf-8?B?alFlU040cG5maTdPOGR2TUtYd2g3SDVqb2RuZ2VRZnpzYjRHd1JpWXQrbTNm?=
 =?utf-8?B?MHZ1RkRqKzZxNjhzbGlqTW5LdnJDL0lxdVlqZDNVWFloWU9WSWJKcDVPVFhm?=
 =?utf-8?B?M21iaVE2TnJMaVdUL1JaOS84MThsRHF5MjFJNXRKamtzRmtXQ295SUc2cjF3?=
 =?utf-8?B?T0oydmdoOTRPN2twVUlNa2ZsZnBNTThoV2hkL1paUkFsQjBySGdibTdDbVln?=
 =?utf-8?B?cmpyRllUdms1SjZ0cEhIZGkyLzJ0U1Bua2VaYUQyaHU4SHpkRnpJT3pqcGV0?=
 =?utf-8?B?Z1ZRRVhRTUZPOG1HZW9PQkJyUTl4Zk1INGU2OGliTndMb1k2M1J2WDY0VE8x?=
 =?utf-8?B?U20zVlNqbGdoaDhVZ0tGUmp2Yk1wbm5SakNjQWg1MExmdFBENDJJa1Vnc0Zo?=
 =?utf-8?B?MUNTOVdsbUxtSUpicVpSY0JwaU1vcVVIMmErOGVrbjcwd1NJQi9IU25uRWlS?=
 =?utf-8?B?a0ZaaVNJSWRUNm9VT2VSMGRoRFhQK2RPd24waUg0Ym1jUkdjL0pmVmZHUFls?=
 =?utf-8?B?VGhiVlgwK2p4bHk4b3F2azVTUGM0bFNYK29qSkVaYzJjMVRuemhpVHEyVzUr?=
 =?utf-8?B?TlpiL3E2UlpHN25jcTFpRUF5UUwxV2N6RTFnTzAxL2NSSnQyZDJ4c3oyR3lY?=
 =?utf-8?B?dkdoY3YxZDc0OFkrTmJ3bkVxTUJUdUJxV3l2aUliRTI3dUtjV2dPeVpHdEsv?=
 =?utf-8?B?MGZGbXVsbGF6UDlMR0dHUUJIdkxjSlBmVWg4Wk5yclFjcm1kWHFpcjYvUGFS?=
 =?utf-8?B?YzdQYVl6akMzWGFzcnByMVlmYlNiSzBCc1RacXViZGR0b21KMDVLdnorSjJV?=
 =?utf-8?B?eElyaVhIbGd4SmthSk12YmFob3h0a0c4TmY1QmRoVkcwY1VSSmltdUc4NG94?=
 =?utf-8?B?bXlvUmI3SE1IMVc2dS80VU9obWc5RHlNSUpvZ0ppMDM3Mk9zdVZxeHVURDZG?=
 =?utf-8?B?UnhndWtIMXVPSy9Sb3p0QVFkVUZ1MWtpMjdkNHI1VWhYMHlXYkZYRmZGRFZJ?=
 =?utf-8?B?S2hhanlGWU9WcWZmV2FLOWJkMXdTOFlqSHp3K1ZUYVJGUzcvanNqMThpQkxR?=
 =?utf-8?B?TERJY1NmQWR0YmNZNzczcDZ2T3JvVVhVWjQ3U3UyOStudDlQTGdDTnI5MDN6?=
 =?utf-8?B?N3Z0b2VYTjVCUG5hV2hnZ0VJNzk1MXVpTHRnd3MvbC8ycVY3SGJyVmEyTk1N?=
 =?utf-8?B?Vi95K3BJR1RWMmJVTHYweUlpSHJCcVNuSHRoNFAzSEtGT2pJaU12QlVwbkM3?=
 =?utf-8?B?WWN4YzRCWDRjS0JycFNKeVdKVVZmdVc5Z1FQTTR2NllwWVg0bTBMYnpoaDFL?=
 =?utf-8?B?NmRmbGRwdFdBZjFSNkRvU0JPRGVhT1Q0UmIxSHpncEFrNnpCNmszQTljU0Qy?=
 =?utf-8?B?ZXlxSVYxVXZFY2FHdVF2NUJJdWU2YnVMK3Vkd0VlTW5IVGwyMkxnYko5Y3Iz?=
 =?utf-8?B?RXdyNW5OU0VxOUN6RnpQSlFyOHEvUnJ5NzhVak10S3ZjM2x1SUd0L1Uwdmx6?=
 =?utf-8?B?RlB4bHFXMWNRV3hzM2RFcERKSXM0QjVubUFGQ09OeEtLK2NHRTNFcndQaFhC?=
 =?utf-8?B?SGRlYnc3Ym9kUG1TY3VCQ2tSOHpyb3RZcVd5RFQ2cStzRW14dnFJSGNmWFZl?=
 =?utf-8?B?STN6amNveTdpOEVvMjA5cDI5U0NHN3o2c0pyS3krWFZjOVZuWDBaTmViSC9F?=
 =?utf-8?Q?7VPRUX9J6mz9dmRo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4879c129-b41f-4751-3986-08da13ed2f5f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 14:37:45.1011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xs8EzV7g9bMEf+3u3v+XTywaSxqHcohSjgBFURAe0FySyIcHEU1p2R3VIj0kxM5AwIUYM5mypDqD//XbdRPn2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2398
X-OriginatorOrg: citrix.com

Prevent the assembler from creating a .note.gnu.property section on
the output objects, as it's not useful for firmware related binaries,
and breaks the resulting rombios image.

This requires modifying the cc-option Makefile macro so it can test
assembler options (by replacing the usage of the -S flag with -c) and
also stripping the -Wa, prefix if present when checking for the test
output.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 Config.mk               | 2 +-
 tools/firmware/Rules.mk | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Config.mk b/Config.mk
index f56f7dc334..82832945e5 100644
--- a/Config.mk
+++ b/Config.mk
@@ -91,7 +91,7 @@ PYTHON_PREFIX_ARG ?= --prefix="$(prefix)"
 #
 # Usage: cflags-y += $(call cc-option,$(CC),-march=winchip-c6,-march=i586)
 cc-option = $(shell if test -z "`echo 'void*p=1;' | \
-              $(1) $(2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \
+              $(1) $(2) -c -o /dev/null -x c - 2>&1 | grep -- $(2:-Wa$(comma)%=%) -`"; \
               then echo "$(2)"; else echo "$(3)"; fi ;)
 
 # cc-option-add: Add an option to compilation flags, but only if supported.
diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk
index efbbc73a45..1cbe666f5e 100644
--- a/tools/firmware/Rules.mk
+++ b/tools/firmware/Rules.mk
@@ -15,6 +15,10 @@ CFLAGS += -Werror
 
 EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
 
+# Do not add the .note.gnu.property section to any of the firmware objects: it
+# breaks the rombios binary and is not useful for firmware anyway.
+EMBEDDED_EXTRA_CFLAGS += -Wa$$(comma)-mx86-used-note=no
+
 $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
 
 # Extra CFLAGS suitable for an embedded type of environment.
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:38:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:38:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297449.506729 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIQG-0006oE-DE; Fri, 01 Apr 2022 14:38:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297449.506729; Fri, 01 Apr 2022 14:38:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIQG-0006o7-A3; Fri, 01 Apr 2022 14:38:44 +0000
Received: by outflank-mailman (input) for mailman id 297449;
 Fri, 01 Apr 2022 14:38:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dc+m=UL=citrix.com=prvs=083d63866=roger.pau@srs-se1.protection.inumbo.net>)
 id 1naIQE-0005di-AC
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:38:42 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6b692d95-b1c9-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 16:38:40 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b692d95-b1c9-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648823920;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=/OHwMK2W43W0KGDBL0BTrku1ipd+E49VxB19lUZP2O0=;
  b=UOVl8ASfl5GShTg+P21h+ElLuscUZeI8Jji1MpaFoE4T1JFJRTvTUK1v
   meHz/gsMrGMtUcCOQ/uRSrLOzpdFOKmVtdSUHbPfXKWOmfg0xEg4u6QH8
   CsgBkKI4EzU8dP7j8qcVvywoNTTnip+NcW/HfveEiYpWUbWoRuiyRMb2t
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67788491
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ah1P46x90oQXAl1BAJd6t+dNxirEfRIJ4+MujC+fZmUNrF6WrkUDn
 GUZDTiEaP3bN2KgKdF+PYXg9BxS6JbVydViGwc9+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YHhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplq428TgQtG4f1hcMaCz99A3tYPe54weqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J8RTaaCN
 pNxhTxHR0XMaSUUBxAsFa0AzfWatED2KTFbpwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECvbGI7jVNUltMDwL9+KTnzB7lMz5CF
 6AK0jQ/oa8x8GmBd8TaWEWehW7emB5fZeMFRoXW9zqx4qbT5g+YAE0NQThAdMEquacKeNA66
 rOat4i3XGIy6dV5XVrYr+7J9m3qZUD5OEdYPUc5oR05D84PSW3ZpjbGVZ5dHaG8lbUZ8hmgk
 mnR/EDSa1j+5PPnNplXH3ia21pARbCTF2bZAzk7uEr/sWuVg6b/O+SVBaDzt6ooEWpgZgDpU
 II4s8af9vsSKpqGiTaARu4AdJnwuarVb2CG2wY+TsR8n9hIx5JFVdoPiN2ZDB00WvvohBezO
 BOD0e+vzME70ISWgV9fPNvqVpVCIVnIHtX5TPHEBueikbAqHDJrCBpGPBbKt0i0yRBEufhmZ
 f+zLJb9ZV5HWP8P5GfnGI8gPUoDm3lWKZX7HsugkXxKENO2ORaodFvyGADQNrpgtvPV/V29H
 hQ2H5Li9iizmdbWO0H/2YUSMUoLPT48A5X3oNZQbemNPkxtH2RJNhMb6epJl1BN90iNqtr1w
 w==
IronPort-HdrOrdr: A9a23:MkXqe612+7eaxtpPs0ZvFAqjBURyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJU80kqQFm7X5XI3SJzUO3VHHEGgM1/qF/9SNIVydygc/79
 YeT0EdMqyIMbESt6+Ti2PZYrUdKbG8gdyVbIzlvhBQpG9RGsRdB1ATMHfnLqQ6fngxObMJUL
 6nouZXrTupfnoaKuy9G3k+RuDG4/nGjojvbxIqDwMurFDmt0Lh1JfKVzyjmjsOWTJGxrkvtU
 DDjgzC/62m99W20AXV2WP/54lf3PHh1txALsqRjdV9EESkti+YIKBaH5GStjE8p++irH4sjd
 n3uh8le/9+7nvAF1vF1CfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqAw7I
 t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1UwKpsKuZOIMvG0vFoLA
 E3Z/uspcq+MGnqJEwxh1MfjOBFBR8Ib1e7qktrgL3m79EZpgE786Ii/r1vop4xzuNCd3B63Z
 W1Dk0RrsA3ciY3V9MIOA5Te7rBNoTyKSi8Q156Z26XVp06Bw==
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="67788491"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CFiuzCjOlIrhdZYuKlhYgyK4O9dhq+9EQiDR0v4W5uEzXcpVYjz6ztXC+MASFMN6/6vP8vN8/dLL5PDLPAIGU5nddulvngYLi7bLg3AMOc88dCOBgFqM0wegndb1DgtN9RTwyfxVK2xfeemyrr4MJLoV/0XH8jWCSkKZqDHrCyjc/xRK61MuvMuCEobVpN4mjN2pJvcNxCDtX+tfyPSdflFEKgxwmTLqx8gqRnvIAFkiIhyncHtkRygRVw1QaAu+flkpNzj3qa0h6mM60Qc9/U+MwBq86dajwel7UCuw6FwEsk5Zl9qPyGjaK5cbYCCTJScdydV46YtXPo+2lK6e9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TYFUjWIXSm5BoiX9qqkGPY3DZbe1Ux6jWsFf+dsp8l0=;
 b=OFL9nZFLZn+gMkl8z+fQ2sPzEguNvRqHmNDHfQZ6vIr0n6xK0oFiadLxoohcRN9kljjg8R3RWd2dfIRlB5iSXY8QPTXtIf9vXz0E2qyYmyugqGNu7d4zWOA5JY1MvbL7r8DaFLMePlJY+C/jmb9QRT51P19a1+umh8AwaJPDgGhq96ekxjVgCPCeFWb2Lgf3wOZ+y8L7xMZ+AyfUx7vJ9jPQlkyesxoOYHuvtupDTjYHnkmAay8rO72HmUP0Qzd771NBId1NPZ6OttxumOmZjsp6HS+h52ndnQpBZ8quIB7TaKmvWPmBk2wOkeeIn7jY5mO2ONVOOdD5eWYW9e+dvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TYFUjWIXSm5BoiX9qqkGPY3DZbe1Ux6jWsFf+dsp8l0=;
 b=a2m04+EYfCt77mJM25+eh4xDxLUog3NOwy5TDN3kKDPcV+AbkrOb1p9TSupH4LI5vmZDChSL4FO58qA84DeE1viLzHxG2yGuLK+DXvU4VK8Anp1N3sSOkXmP8ZSwDspCmbwSyrNR0AovOkz6AEA5yhV449MuSwFOBlvdH/WBAnM=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>
Subject: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Date: Fri,  1 Apr 2022 16:37:18 +0200
Message-ID: <20220401143720.23160-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220401143720.23160-1-roger.pau@citrix.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO3P123CA0001.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:ba::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 398b9176-914b-4117-c300-08da13ed2c31
X-MS-TrafficTypeDiagnostic: SA2PR03MB5801:EE_
X-Microsoft-Antispam-PRVS: <SA2PR03MB5801A6D49CA70207F67BF9D28FE09@SA2PR03MB5801.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rMgUV8luy/9rdP4h1BCBbx8uyNbcp6sArcm5MB1MuP9Q6uyaggosJ2X1H1i/VzqYLLdPBnKVd/5jChCGNOd/RGP3I9a92SSGdYl2OogXbTjK6w0ppyS1QybPKqnL9hI8NQw/dpaPl2x3sLhaTWIfkeNbvlMdhPEXrY9OkO68yyZnA8zCZ9htl0igVQNTVSWGblOCoiukioSf5UgQ7OBfIlWOyUWX9M4DInQB4OUm3pknI5p/fMsVs4za4sj0+QL2k2PLZtv2/kIkBk5HOZ83Nm3CrqehraUN/KzPd2r8DtK/IxKZRkUGfGdwC1FDxvONgP1nP06KQs9+NYVbiP68UJW9u5Wn41aHCO1Mr2HLjeXewRjKeln9fGCmXVsdVd3iQ7PUq/JW6H063iNlv5XkL5JF2QVTkq6ldMPhZsrhIGcezP+6wVd6nSgrFFm63230udUe2RJi7dJbOazR8Lq+nC4kinlt/O2Z7Vhg41tVxdNQGr/FXYEBk0aG9NNQg0+ufzi2saU2g6lyLFKrjgYv8Z+6VtZ0Yvfm8qpWO5B/CAJwXMnjuiYq1nqK6wLiYHL4V55LELmDCDX2u786z7xu5gvkSKBs6xEjJEUoDk+4L5UgiNj43FUQKqVQroRB82AElKKdozQo5JsERoCE9RmuQQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(66476007)(66556008)(36756003)(8936002)(6916009)(2906002)(66946007)(316002)(54906003)(508600001)(6486002)(6512007)(6506007)(6666004)(8676002)(4326008)(82960400001)(107886003)(186003)(38100700002)(83380400001)(26005)(2616005)(1076003)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVdvWWhRekZCSm02ek1MV0NHREFDak14VGc0V0RqV0cvNWVNWGNKeDVXYndi?=
 =?utf-8?B?cWNELzZ1b3A1aGgydzVXSEhEUGptSUlBKzJQUXMrU0F1MG9xbENqbkdDVXhl?=
 =?utf-8?B?L2R2bVRoR0lBZEdTNGtUS1ZuVWI0MEVSNW9zcWQ1YXpqQVVSUHluOVhnTFlY?=
 =?utf-8?B?dXpIYVAvdzFjRXkwdlRxMlcxTFJiRXVjUkJORHhIcUlTRWtYYzRkS1RhTUdq?=
 =?utf-8?B?V09TRmFFbTZKTUVabmVYSm03Wk4vUks0Y0NBd3N6NUZpUnc5blUwbmwvNklT?=
 =?utf-8?B?b1BZY09GUkZES0gyemMxNTlVYWdrbDF1TGlnbU1kWEM3aklkNmhGSGtWOTVW?=
 =?utf-8?B?M2h3YlBMN2xmT0hqM1kxaEh6UHJLeHJZZzREZmZsZU5zZWt4Mm5qeHdVQytS?=
 =?utf-8?B?alZ2VUE1RGdrbmVPL1dtOVF5MU9LbWVEazBtYlUzS1M3T0VsT2I3MnNDS3VF?=
 =?utf-8?B?QXk0YnBwelB3TUpPWW1FOEhlQ29tWGRCY0prUk1LczAwZXRzZ2FVTmdoRXNO?=
 =?utf-8?B?MzV5MWVlY2tTSkhSNUhNejlHdDlwM2QyNnh3Y3c3dUxBSHpRdTJzQ3NLaVVo?=
 =?utf-8?B?bityMHBqeFRnazlKQXprd1ZyZTI3OUFBVk1UWDh5U1hYaS81TzJaTGF1dHhB?=
 =?utf-8?B?V0kvamtmeUMyTXVHUW42N0thTkVGVHVJMHJNN0taN00yd2tKbW9wR3dvRXRy?=
 =?utf-8?B?TllyTWNmTHB2TUV2dFcrUURvdlNuWHRRNzZ3c1VrNGNqbExOY1VWVktTampm?=
 =?utf-8?B?cVBqeTJ1MGVlaXc5SG1OYzBHMDI0dzZ1V05LWFZCQnBQcDhPcHg2VitOc2Nk?=
 =?utf-8?B?bXdoOWJvQmpQakZDb05YcFpWWTlZa3dZcVpMR3Y0UGloZjBvN1lvYUEzalFs?=
 =?utf-8?B?TXJxMW8xYTh1eTlpSU1KS3IrQURaRzJHSVZMRVJJdkwvVURSMlFmQXI4VXFt?=
 =?utf-8?B?cWpKSXFoRERvSFVIU1o4ZHhUaU4zTGdmcmhiY1NnYS85UWRpQjVOSWY2b0d6?=
 =?utf-8?B?ZmVNWGZHYUliWU1NMUphSDF6eFlvaHpzYysyNDFETTlmbkR0dFhHQyticklF?=
 =?utf-8?B?QnpXUFdIU0FLS2NkL1FhaVFEM0pOREJ6K3lHRGoybTU0UEpMWVVlQUF6RDJ4?=
 =?utf-8?B?KzdTUlBMVmFNbzdUckRWYUJ3M3BzMld0M3BWMk9Dd3BLb2ptMFZjdTNoSjhp?=
 =?utf-8?B?RTBhVEp4VlYyNmlTQ3BoU1lkdDlXemV1Rmwyd05vSXcrQ1p5Y0ZJTmF1djJO?=
 =?utf-8?B?UStTZXV5S0h2aE1xdDhYRUk1N2VyK29OSThHT2dMdURPZXZrNnVKK0NCODNo?=
 =?utf-8?B?WWtQeU9sZjA0VHZ5Y3V3d1VNMVoxNWhlMllxWkhyd09abkppK0RjTFdtelRF?=
 =?utf-8?B?ZUh0bmJENE0xdk1uNzk0TzByc3U1UDFZMUJSUmZ3NlFEMHBydFh4Y2MwOFR5?=
 =?utf-8?B?MHZwb1ZJNjBETDhYRXlBaUtuWHdBMGtqK3dCTWJhKzVpaENXZllFWlZaTDlm?=
 =?utf-8?B?eFByNXpTZnQyK3Fvc2RGOXZBR01kUVdadGE5M0d0SFErcG1DaGZPTEUvSW5X?=
 =?utf-8?B?RlhEYllJc1JyaVNMVlF6aEFSRVJRQUZoRVgxSWYzNS9Eam92cmNTY0FiWFE2?=
 =?utf-8?B?dXQrT0hTK0xWbXhDSElPMUVRazFTTGg1ZGVEQmlJYk5DaVVNTXJHMk54NFpT?=
 =?utf-8?B?RFZtSFNmRTFiZ1FyN3BMd2R3MUVJbGlsZGtSMkZ0cjRpRENuVzNZTDJGdnBU?=
 =?utf-8?B?S2JmZy8vZjlZK2czSWt4NWVId0RlSXMza0VwY3pRSHhmbFZYYzhWT0hjdzVF?=
 =?utf-8?B?NmhYcEEzdGh2MVE0M1FBSDM4TEFHTE91djdXUmFOQ2doSGpxREF1ZWxIeWtx?=
 =?utf-8?B?Y2NPUGIvaFVaMU5vYkIzbEhZbnUzUWZLb2VpK1V5RzhhUUtCTVB5cmdWanhs?=
 =?utf-8?B?d2lCQVJSVXE1NjR1WG8yMk1ndjJBUzY0S0YxclJMZit5UzRnMEdrczhHZVlR?=
 =?utf-8?B?WkFUSE0vQTRoR0t2RkNlMW9BdG52NGEyeGtUaXRyc0hJTC9ZV09DL0U3QkRG?=
 =?utf-8?B?ekE2Qm9INEROZVAvWmlCSk5wWG9Vb3lYOU1ROHRzZTBqN2FxaUxUdmorUnpk?=
 =?utf-8?B?d0VCdXE2UWpMVElrREJQUU5hdUNXa1lKcVVLTGVsS0pJZHkxSmRjcDUvNEg2?=
 =?utf-8?B?L1YwbDNrcGVOUkVKQzJHVnNXaVcvZlVmK0F6U0dPc2lZTDhpNXNvTE9jTnJO?=
 =?utf-8?B?MnpETHpiYTRpd1lnUUs4azAyeVVuWFhWbmRVdi9lMllsMHU0WldUODI2RVZ3?=
 =?utf-8?B?RzBQUG1xMjJaeDFpL2JBNXg2bFRHbHJtZFNtczlMOVhTYytJQWNvdHZoZCtn?=
 =?utf-8?Q?ZWynN3SdIeI31E00=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 398b9176-914b-4117-c300-08da13ed2c31
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 14:37:39.7700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aQWgXkrvYaOfVKwH8TN5rMWOkvBVyleRLDzg+6Xmrk0qgDbTqPzYCJJnIRHHcuYkxvgHWK1+TPYQ/xhrNgQpDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5801
X-OriginatorOrg: citrix.com

Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the
Makefile doesn't get it propagated to the subdirectories, so instead
set the flag in firmware/Rules.mk, like it's done for other compiler
flags.

Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 tools/firmware/Makefile | 2 --
 tools/firmware/Rules.mk | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index 53ed4f161e..345037b93b 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -6,8 +6,6 @@ TARGET      := hvmloader/hvmloader
 INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)
 DEBG_DIR := $(DESTDIR)$(DEBUG_DIR)$(XENFIRMWAREDIR)
 
-EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
-
 SUBDIRS-y :=
 SUBDIRS-$(CONFIG_OVMF) += ovmf-dir
 SUBDIRS-$(CONFIG_SEABIOS) += seabios-dir
diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk
index 9f78a7dec9..efbbc73a45 100644
--- a/tools/firmware/Rules.mk
+++ b/tools/firmware/Rules.mk
@@ -13,6 +13,8 @@ endif
 
 CFLAGS += -Werror
 
+EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
+
 $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
 
 # Extra CFLAGS suitable for an embedded type of environment.
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:42:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:42:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297458.506740 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naITt-0008Gd-U4; Fri, 01 Apr 2022 14:42:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297458.506740; Fri, 01 Apr 2022 14:42:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naITt-0008GW-R3; Fri, 01 Apr 2022 14:42:29 +0000
Received: by outflank-mailman (input) for mailman id 297458;
 Fri, 01 Apr 2022 14:42:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tDTg=UL=citrix.com=prvs=083321efb=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1naITs-0008GQ-O4
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:42:28 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f2aee657-b1c9-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 16:42:27 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2aee657-b1c9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648824147;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=bwNyhfj/vNkzAhd56p+n597OxA11saZSTSIpegr04c4=;
  b=EffSmDAq2zQvNZdNzIFY6jxXfk7k+DeoUG0nckAJbykL5oRokfuGmtxf
   z1drJgsfrRnDgqXPL5TyRAzZX86Xn5dPD1C4j0dYf8bCG0qloce6G2za4
   mq/aNU1+bKL653GA2Xy7E3V3dbWQ/1fVCI9rG50WDRuhD2GHHut6Qjb9Z
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70164878
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rNtOIa8HIY/oPp27JNJZDrUDl36TJUtcMsCJ2f8bNWPcYEJGY0x3z
 mYaUGuFb/6MYWv9LdtzOoXk9R9Qu5LSx9AySQZkpC48E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YDgW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZugEQQPFI7LoacySUFGVDtmNrZhu5aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 JJAN2Y/M0SojxtnNHcLVq8st8CTlifbbm0FjQ6Ig6QH7D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkYO8aY0iGt6W+3i6nEmiaTcIAbErGi5+NpqFKWz20XThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1iPwQPIJTbd8slvUjPOJvUDJXQDoUwKtdvQhpJc1YxYJ0
 WbKsMmxG3t1qLaObjG0o+L8QSyJBQAZKmoLZCkhRAQD4sX+rIxbsi8jXuqPA4bu0ISrRGiYL
 ySi6XFn2u5N1ZJjO7CTpwivvt66mnTeoufZDC3zV3nt0A52bZXNi2eAuQmCtqYowGp0ozC8U
 Jk4dyq2sbhm4XKlznXlrAAx8FeBvant3Nr02wIHInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia
 1LJtAVa6fd7ZSX2PfAqOdjpWpV3kMAM8OgJsNiOMbKihbArKWe6ENxGPxbMjwgBbmBy+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWngvuqWTA503/i9K2PSfNIZ9caQfmRr1pvcus/VSOm
 /4CZpTi9vmqeLCnCsUh2dVIdg5iwLlSLc2elvG7gcbYfFI8QTtxWqKJqV7jEqQ895loei7z1
 inVcidlJJDX3BUr9S3ihqhfVY7S
IronPort-HdrOrdr: A9a23:MGkL564ovvBwJiBIxQPXwMrXdLJyesId70hD6qhwISY1TiW9rb
 HIoB17726RtN9/Yh0dcLy7V5VoBEmsk6KdgrNhWItKPjOW21dARbsKheCJrgEIWReOlNK1vZ
 0QCpSWY+eRMbEVt6jH3DU=
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="70164878"
Date: Fri, 1 Apr 2022 15:41:03 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH v2] libxl: Re-scope qmp_proxy_spawn.ao usage
Message-ID: <YkcO/2CQWEOH9ZWD@perard.uk.xensource.com>
References: <20220401143310.17743-1-jandryuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220401143310.17743-1-jandryuk@gmail.com>

On Fri, Apr 01, 2022 at 10:33:10AM -0400, Jason Andryuk wrote:
> I've observed this failed assertion:
> libxl_event.c:2057: libxl__ao_inprogress_gc: Assertion `ao' failed.
> 
> AFAICT, this is happening in qmp_proxy_spawn_outcome where
> sdss->qmp_proxy_spawn.ao is NULL.
> 
> The out label of spawn_stub_launch_dm() calls qmp_proxy_spawn_outcome(),
> but it is only in the success path that sdss->qmp_proxy_spawn.ao gets
> set to the current ao.
> 
> qmp_proxy_spawn_outcome() should instead use sdss->dm.spawn.ao, which is
> the already in-use ao when spawn_stub_launch_dm() is called.  The same
> is true for spawn_qmp_proxy().
> 
> With this, move sdss->qmp_proxy_spawn.ao initialization to
> spawn_qmp_proxy() since its use is for libxl__spawn_spawn() and it can
> be initialized along with the rest of sdss->qmp_proxy_spawn.
> 
> Fixes: 83c845033dc8 ("libxl: use vchan for QMP access with Linux stubdomain")
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:47:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:47:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297464.506751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIYH-0000X2-Ia; Fri, 01 Apr 2022 14:47:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297464.506751; Fri, 01 Apr 2022 14:47:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIYH-0000Wv-FV; Fri, 01 Apr 2022 14:47:01 +0000
Received: by outflank-mailman (input) for mailman id 297464;
 Fri, 01 Apr 2022 14:47:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tDTg=UL=citrix.com=prvs=083321efb=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1naIYG-0000Wm-Pw
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:47:00 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 94e5c217-b1ca-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 16:46:59 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94e5c217-b1ca-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648824419;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=//ZTUcOv7xWewr4kNtLTS/BFWXuZyREyUGYevWICZvM=;
  b=C8GHnIEtE+gEs2Kf+xTRQzm837NdVNkpWuDpRYtRwxaCitrK+WTcGXGO
   xnYtyt81+X5gw4+QR1hUlyhYsjuCBJMdYeTIgki0WeqnIHP3ce6QNkdDF
   3O7CzndutRs4+Z6Rcjh84Cu12pLWkG3GSliC9FoCmZ4eiE9HXOq0NiqUe
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70165387
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:l7e7v6nEbHMJtUBEGi4xVuro5gyWJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJOCmGAa6nZZGv8f9p2PI2+pkgF6JPVn94xHQRk+X8zRCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1rV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYVjtxBJGVpPUhfSJbKCBnL5FA4+7lPi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJGMWMxMU+QPHWjPH8sMZxhwvnwuUX/WBtzsAO6+oM040HMmVkZPL/Fb4OOJ43iqd9utlmcj
 nLL+SL+GB5yHN6Q0z2e6Vq3m/TC2yj8Xeo6FrS++uR7nV67yWkaCRlQXly+ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nNAKHQYWj
 2OYo/3SBgduqa+pT2nM1KjB+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm
 lhmuAB73uxO1pBTi81X6Hid21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshTVflhdwTXGY3h+Y1FAd7fb1UwZnY1Q/EcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/MnPN/rUZx7nPW9fTgAahwyRoARCnSWXFXalByCmGbKhzy9+KTSuf9X1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClE4QDt4Ua+AnOtJlk4Mt/09q9okN
 0qVAidwoGcTT1WaQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:yRiGuazG+PbV3w8zBQ6tKrPwIL1zdoMgy1knxilNoHtuA66lfq
 GV7ZcmPHDP6Qr5NEtOpTniAsW9qBHnhPtICOAqVN/INmTbUQOTXeVfBODZowEIdReRygYDvp
 0QFJSWoueAa2RHsQ==
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="70165387"
Date: Fri, 1 Apr 2022 15:42:43 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH v2] libxl: Don't segfault on soft-reset failure
Message-ID: <YkcPY8NV0sOFvYUo@perard.uk.xensource.com>
References: <20220401143256.17720-1-jandryuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220401143256.17720-1-jandryuk@gmail.com>

On Fri, Apr 01, 2022 at 10:32:56AM -0400, Jason Andryuk wrote:
> If domain_soft_reset_cb can't rename the save file, it doesn't call
> initiate_domain_create() and calls domcreate_complete().
> 
> Skipping initiate_domain_create() means dcs->console_wait is
> uninitialized and all 0s.
> 
> We have:
>   domcreate_complete()
>     libxl__xswait_stop()
>       libxl__ev_xswatch_deregister().
> 
> The uninitialized slotnum 0 is considered valid (-1 is the invalid
> sentinel), so the NULL pointer path to passed to xs_unwatch() which
> segfaults.
> 
> libxl__ev_xswatch_deregister:watch w=0x12bc250 wpath=(null) token=0/0: deregister slotnum=0
> 
> Move dcs->console_xswait initialization into the callers of
> initiate_domain_create, do_domain_create() and do_domain_soft_reset(),
> so it is initialized along with the other dcs state.
> 
> Fixes: c57e6ebd8c3e ("(lib)xl: soft reset support")
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:49:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:49:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297470.506762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIaB-00018w-Vp; Fri, 01 Apr 2022 14:48:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297470.506762; Fri, 01 Apr 2022 14:48:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIaB-00018p-S0; Fri, 01 Apr 2022 14:48:59 +0000
Received: by outflank-mailman (input) for mailman id 297470;
 Fri, 01 Apr 2022 14:48:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwaM=UL=citrix.com=prvs=08375ea47=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1naIaA-00018j-Fn
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:48:58 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id daf84789-b1ca-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 16:48:57 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: daf84789-b1ca-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648824537;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ArN5hP5IVRUTUENO0D2I9dcwaBhOhuPXd1w1bhIfECo=;
  b=Z3ALc707CZEA6XH1e+5mq3MtgjdGUn06Gc9lgQFq4afk/byPJ6mkPiAJ
   +7OJYoK243qCYIidWqI28dBSvKLb/3Soptg/fROjg87myRYLXuZtsGEhB
   pIWHpu0mC5Z+LjU3tP01vQNbtH5WRfUtaSyAlymKt88rbEyoHzTJdlZP7
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70165606
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:E/lkfq4tUimxIkq+BlKMRwxRtDnHchMFZxGqfqrLsTDasY5as4F+v
 jQaWmrSPavcZmCmf9pyYITn9BhU78CBx4I2Gwpk+y83Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThWlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSUTTwKfZT1uN09CT55I3lufpUd3q7YdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5VBMGQyMkyeC/FJEnsYKbYio8iVvEvcYRJo8mOHq5MvzmeGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYCD6TnPi/6P/0BTnHYsCd
 QpEoULCsJTe6mSPSuLeHCSBgEek5Dk9a4JAUNVhzhCSn/+8DxmiOkAISTtIadoDvcAwRCA32
 lLho+4FFQCDo5XOFyvDq+78QSeafHFMcDRcPXNsoR4tuYGLnW0lsv7Yoj+P+oaRh8a9Jzz/y
 iviQMMW1+RK1p5jO0lWEDn6b9OQSnrhE1ZdCub/BDvNAuZFiGiNPdPABb/zt6ooEWphZgPd1
 EXoYuDHhAz0MbmDlTaWXMIGF6yz6vCOPVX02AAzT8Z8rW71qi/+IOi8BQ2Swm8zba7onhezP
 SfuVf55vscPbBNGk4cpC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk3nVKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4vf/l2Pq
 owPZpbSo/idOcWnChTqHUcoBQliBVAwBIzsqtwRceiGIwF8H3omBeOXyrQkE7GJVYwM/gsU1
 hlRgnNl9Wc=
IronPort-HdrOrdr: A9a23:anr8a6DirD6GAorlHegCsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPEfP+UsssHFJo6HkBEEZKUmsuqKdkrNhQYtKOzOW9ldATbsSobcKpgePJ8SQzJ8l6U
 4NSdkcNDS0NykBsS+Y2nj4Lz9D+qj+zEnAv463pB0NLT2CKZsQlDuRYjzrSXGeLzM2YabRYa
 DsgPav0ADQHkj/AP7LZEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZjzU
 H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUjZ1TChkF2nAic0idvrD
 D+mWZmAy210QKWQoiBm2qp5+An6kd215at8y7BvZKpm72HeNtzMbs+uWseSGqC16NohqAN7E
 oAtVjpxqZ/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh5rD30XklWavoJhiKoLzP0d
 MeeP309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw9ArfZv00so5dY4Ud1J9u
 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCaZIEjhFqsAJ3XRwqSHqokd9aWvYtgF3ZEykJ
 POXBdRsnMzYVvnDYmU0JhC4nn2MROAtPTWu7ZjDrRCy8/BreDQQF6+oXgV4r6dn8k=
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="70165606"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S5ml9az2opX/9Momo0g6GOQjvjJhGXIOGR+1Q2UUHB6Xnz4E+JCspG9W+NDaZwG09whiQUN+1YqA56poSq/NILQd6pi3Cvp69sdX0llHiSQ4TCzP+u6cgeuIV0rRqoSQtqpGrD91y5kHE+xjArgsgo97EoqIXwayR4Jf7XA4kSBoTwhfJcjtQXRkol8XKSRAMsWzGfp1RqIESYA6Y3WbOMe14R2pHSnga8+h1z6bjE/QT760D39CXivwoJJ25MBTUhBHu/+zplN4LgD411XI9Fyo+cho26TiQo0NxBxzyAduuBTt7QZouOzF0p423Y+fodEe+/ACYHrw8AjVphV5/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ArN5hP5IVRUTUENO0D2I9dcwaBhOhuPXd1w1bhIfECo=;
 b=L0kfNX1SxlPpyTfobwv5ryCq4wd6X/SBsStk/XHbwCpgJNkga/9VvDBuJPU99DQLFXODxEE0ZbfIGZOrKXG6wQE3QwuoT+qLkBrOZJjd+WbM87mtQODVTn/IYHVwxfxTKOV/b/DTyHO9M68KrIqMoms0+WSiWVfzgnY3fE/8Cnm2cu2LjtRoJ8L2rONPnFfmAAgR9talFWzW68XZN32Be7RqkSJO9PKh8Lra8HWDnLLUyLPB9Qz+EkLOFUuAATvjwqOx6ykbjbjnXJne6N7fnc2eNzWfCCq1qzDjG3gxViLoRK9wpk0nfki5er00W+XGaIjkCpLBNwQglFFMeYJdaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ArN5hP5IVRUTUENO0D2I9dcwaBhOhuPXd1w1bhIfECo=;
 b=JYQnymR3N1j/umqusWliTxJywkgcTDej6KP2zJL2sw3B33J62GEjLXhKQfUoZ1sDWZYUeEjnIVQtnJGPCxlsm0aiNraNCMhhvf8TDCvEZRfgprcmdvQpK5b85xK9UTyVDhQZoaewDvKAgMmJdmtz6wuuGaora42SX6cl6ACyFyo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Topic: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Index: AQHYRdaC1Ty1lDbR3E6vxjqdlx39GKzbI4SA
Date: Fri, 1 Apr 2022 14:48:49 +0000
Message-ID: <e20b3d17-0c2a-b23f-d949-667072a54f58@citrix.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
In-Reply-To: <20220401143720.23160-2-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 924a727e-9842-4950-cde8-08da13eebbd2
x-ms-traffictypediagnostic: SN6PR03MB4365:EE_
x-microsoft-antispam-prvs: <SN6PR03MB436534D79C28F8A36BFBD784BAE09@SN6PR03MB4365.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: h5I2eM+v6SCF5dvFgswrgHY+icehtQb92JPm8w3TT5DMzZISC4qopdf9Q5Blt+kQjseva68DPBC5zQL1f/Y8GMejO2WON6ocNW+B9897a459wxWNyjeiwM9TNE+gsuTSEcR5GHZ2qa84uShFgv4vt5OuqLbSOmCOq+GVPSnDdhDWEYBcsh0e4Vk68Agx7V1VlUCruK15+A4mtMVAO1BsszRoNEj98TqEeBdO3gIRUu2Ebjl/GZQSmiVBkmQcK+2H2e33i1jdbgU2mAuYbcXF+qP4yQSwW2fixdCUm2kmoqJGx9rvvT7LacKvWopOilu1bcxIKf9OE8wgSIOL8ZoB5e8rIP+5oSOT1pLYV+3woQnY6h15YxanBbI/KaRTO6GFLFLb23E+ENdtzrQnJc156WsnFFB2vu415rFqRfEdEWkSMHKE/sZHmJ5FGHJhE5CoEzFClAsQ8yEgxU/+zIsqmyxtmYppW6JI8SmSsK1/G2YvjjyaCxVvgm+QX3GBm5wVRxVvBrQBtRDfGzCDTMCe6rAGgkUYgl1BPnRg1ipkSF1NLYdwmKiSTbZTISPLQmIJsw98bcPyq7gdBMORlijHn1l97ea5FuAiTI+/sviil2tSFuQDm7z2KpB8EVHGAaMT3WmUzWYycrC2HtTqtIZSdYPXgKFlmURS5S7brjq/RgMa41dshph1m5U322oUPdqXGmzHrCr5t7sYAO8+4uoCbKiks8QaktlJyiUQjNsLa3FhzF+nMaoFeI2WrIpTyNAGNQeDFSUXJmsSKAoe8HnIHw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(6486002)(4744005)(31696002)(107886003)(38070700005)(86362001)(71200400001)(53546011)(5660300002)(6506007)(6512007)(55236004)(31686004)(36756003)(38100700002)(122000001)(64756008)(76116006)(82960400001)(54906003)(66446008)(66556008)(508600001)(66946007)(26005)(186003)(66476007)(8676002)(110136005)(91956017)(316002)(8936002)(4326008)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QTJkQ0NrTHVRVWtTZTVNMHZOR1NxdjBtZ2VXbENDT2NGVWNPSWtoRUd3YVRR?=
 =?utf-8?B?WXRnZVVjbzBYTm1IUWZZOWR5WjFBUTUzK0U3dHB2VXAzb1JzdVltSjJOV1kr?=
 =?utf-8?B?Ulh5MURqU2lUSnljMzRkQVI5WGZWWCtyNmJjZWtOUy9mU1BWeExnUGxtMHRh?=
 =?utf-8?B?MVhTNjZ0b0UvVmkzYmpncnB4RXgwQ3dOdWNVdGhGT0JmdjFJMTRvOXZzYTA1?=
 =?utf-8?B?VmNxZzRseFpJUmhTeGhleGJoZzF3RC9BdHBvd3dja3BPY01xYStrcFJSQzJC?=
 =?utf-8?B?emIwSkNCSTczMm9HSndhMWNnMjA3NVV1S1RlZWpvQ2xIV3p6NUxqWGUxeGZ3?=
 =?utf-8?B?Z1ZlSU41MnlXNThnWHRPaTRIVWxsYnNEa3FWTEZJYTVDU2ZQcVA5Y1JUT1d5?=
 =?utf-8?B?OUw1UlIvWU83ZmI4SXYwbFRkOWhlVXEvdkQvMXNVMmNVYXlUYngzWVlzSmJp?=
 =?utf-8?B?NnpBcVdkTWpaMng3ZzV2UnpuU2JVcGtHTUYrR3lKK3Z3cHZ3RWhWVE1yTkda?=
 =?utf-8?B?NUQ1Z2xyNW9qK21hKzJtTENXa2JYc0VnZnRBRXJFakIyckQ5ejNxTEdRWjhL?=
 =?utf-8?B?bTdNN1dDamNUaklSMW13bFVrc3VoQmZRVndOV2tnbVFsTDlCalY0ZGJWYjlG?=
 =?utf-8?B?K21wb3VyVWN4L255NmoySmo0OXhDVUgyT0R2RFdPNHVhZWtEZTFicitvYSty?=
 =?utf-8?B?V1RUVktPdCtlYUZ1cUxRMjBFbnRSMjVTa3Jtb1IzWjFnUmhNRmEwN2pNenpY?=
 =?utf-8?B?Z3J3QStEdUpmc1dPVG95ak1rL2p0cTVkVmM1RVE4V1d1aXphcjNVcWdIdTZz?=
 =?utf-8?B?Z2FoazBQaGFqbGJ6dXhNcE52Smoybmxobk1GTHhnWU81L3ZQQ3FzNXE2VnZy?=
 =?utf-8?B?c3VFU3pyY2ZCb2Y3NVRER0JOWUlDeHd0ZDE3RUdmWnhkTVM2enhNVzJOb0dw?=
 =?utf-8?B?RTZMU1llSzBNSmVoTS9FYXhScGRZSHRVR0ZPSFZrNmFaZW9GTElWNFA5eHo3?=
 =?utf-8?B?RXJzV2VGOS9uNTE3dXJObzFqV1c4L3EweHFwTXBtam5VaDVleHI3TDJzNHJZ?=
 =?utf-8?B?YitVUFlBR2xiSWtCU2xtNDVSQ3ZVam96Wjh2bVpCajBFTjR5cEcybWp4TGRq?=
 =?utf-8?B?T2xnMDFaOG5TWHdmbjY0SGRTa1FpdnIwak9SS3dQNFk2OGdQcWd6WUc3WGZH?=
 =?utf-8?B?YlUzR0YvdGxoYlRmenNrY21XVUZ6aUk4bytWOUhxdFB5S0Q0VndGa2FENDZr?=
 =?utf-8?B?eDFYNHM5VHh0VG1lZzlWelpBaFp3dFI0ZWM0WkxPUXozaU1MSFJkVnE4a0R0?=
 =?utf-8?B?MVBqclFIenI4L0FRV3ZCdWViRXpKbU5EQldQd2g5c2NpcXYwMlZFSnpqQllZ?=
 =?utf-8?B?alVTWVE2bkpac0VlWlZMYlFzUWdXZmhXaUcxZTdyZWlFOFgvWVFHTG0wR3d2?=
 =?utf-8?B?T29oUlNRaDlRR3ZKSG11SVdBcnB0WFNvZFJMOGlzRmpSeXVhVzg2bnZ3YjZT?=
 =?utf-8?B?TnJtcm1nR2hqVEdrVFV6bTdLeGV0QVIybzBraHNpMThWbmlrcnNIRXp4a3RZ?=
 =?utf-8?B?R240ZVlad1dQaUJqUk1TVUM1SE94dGhVVjhRNHAwUGdFdzF0K2JNNkEybE1Y?=
 =?utf-8?B?eCtqTVlmdWsvRjk2UFRkYS9WSjg3QnlRRFRIMi8wM3U4dUZCNGppeGx5MXBJ?=
 =?utf-8?B?cEpDcm1zMDgzQzFwWDZ3M2FRRnFxK3lSRCs3bTVwVFB0ditMUXhsajFIdHY1?=
 =?utf-8?B?cWdDNHprY1BLWlhHa0ZHVkN0Q2Q1NXRkK3g3MVYzV1lUSEdoMU4ya2l5MU5N?=
 =?utf-8?B?ajVWbmlvODBjTnNZSFZQQkNLY285SHR0SjBhZldPRCt3aktqaHVNbmNJZG1C?=
 =?utf-8?B?Y01KYXQ4eXJ4S0xqUFBwNUh0MlZodWtBczF1QWJVY3U2dkVIenk3VHEydUhh?=
 =?utf-8?B?VmFsRkRISXRYL0NpczVCVG1iYW1CdVkweHJ5THh0QlJ1ZGU0VWpCWnFqODhT?=
 =?utf-8?B?eHViUEpITnNBN3N3RUVsM1d1QmtrUTR0dDVoNHZwam1lc1ZySU9LNmVHaVRW?=
 =?utf-8?B?RlJscmd0TEVwUU9obzhkZDJZODBubjdETHN1MjduNllpZEd5L3ZmUlgxZWpB?=
 =?utf-8?B?N3B2VXZNQUNXNHpRVTBBT2cwZys1SXpGNzJPbmc5UlZ2OUZMbTlxSzFRUlJU?=
 =?utf-8?B?bWlPRkpCekQwS1NhR0xDNkVRWTRibUtmWXR0a1FsSVRFZDVGa21ocCt1akl3?=
 =?utf-8?B?YzlCQlQzLzVvS01qU2JsSmMwSjI5VEZJdmxzaDJoeG9Nc2NwL3VZa1Z2R043?=
 =?utf-8?B?RzdEd2ZsempweXZ3aU0xNlhSSmlZNnpyUERHSjZRd3pSb1daVkh2Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <48C008B13BFD0647B8A81D980C3C39B6@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 924a727e-9842-4950-cde8-08da13eebbd2
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 14:48:49.9707
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TFzgtVbqLhfuiBdvvVV8i91LcoiLWhYGWYraHK9p9r/mrw7wnpQ/IDHRW8gwwZZXKUfKur0p5BEklzBaufIXR9IACdE8GuPgZjXIU+mVmyM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4365
X-OriginatorOrg: citrix.com

T24gMDEvMDQvMjAyMiAxNTozNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBTZXR0aW5nIHRo
ZSBmY2YtcHJvdGVjdGlvbj1ub25lIG9wdGlvbiBpbiBFTUJFRERFRF9FWFRSQV9DRkxBR1MgaW4g
dGhlDQo+IE1ha2VmaWxlIGRvZXNuJ3QgZ2V0IGl0IHByb3BhZ2F0ZWQgdG8gdGhlIHN1YmRpcmVj
dG9yaWVzLCBzbyBpbnN0ZWFkDQo+IHNldCB0aGUgZmxhZyBpbiBmaXJtd2FyZS9SdWxlcy5taywg
bGlrZSBpdCdzIGRvbmUgZm9yIG90aGVyIGNvbXBpbGVyDQo+IGZsYWdzLg0KPg0KPiBGaXhlczog
MzY2N2Y3ZjhmNyAoJ3g4NjogSW50cm9kdWNlIHN1cHBvcnQgZm9yIENFVC1JQlQnKQ0KPiBTaWdu
ZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCg0KQWNr
ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:50:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:50:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297473.506772 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIbJ-0002TC-9M; Fri, 01 Apr 2022 14:50:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297473.506772; Fri, 01 Apr 2022 14:50:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIbJ-0002T5-6H; Fri, 01 Apr 2022 14:50:09 +0000
Received: by outflank-mailman (input) for mailman id 297473;
 Fri, 01 Apr 2022 14:50:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tDTg=UL=citrix.com=prvs=083321efb=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1naIbH-0002Oa-OS
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:50:07 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04115178-b1cb-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 16:50:06 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04115178-b1cb-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648824606;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=eVuprM1HycjDsQgxnHjHvP/Xp4/+myD54orpOgIcw2Q=;
  b=AS1K+0u2ncKyCjLX/hGFRFN859srsjZASt6VgO20WcWzw8hPXcu3tBB2
   XX23bYe5Hew0HmP5A6NNbiaakvbsxHEuQzNuOZb0IX6dkCES2vYW3fUBo
   VFpxwlli422GfPC7EOpSKAYF3ePe1tHuCrmjwg9WgoMCyILJm75WX66re
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67771780
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ha+W4qN5gQbi1yXvrR3Nl8FynXyQoLVcMsEvi/4bfWQNrUp0hmYPy
 2FMUGyAM6qOa2r3LdEkPoW18RgH7JGDn9FqSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tcw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 f8RjKS+cAQTOaz0qsJFeTgJUCxGMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQqmBP
 pVJMVKDajzOOy8eNU88Wahmt+2whVj2SyFA+RWK8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzWuKnc7UUNMEwHh+L/g1xD4C4k3x
 1EoFjQG9IJuzXSld9rHWByAkljclD9NGNdoHLhvgO2S8Zb87wGcD2kCazdObt06qcM7LQAXO
 k+1c8DBXmI27uDMIZ6J3vLN9G7pZ3BJRYMXTXVcJTbp9eUPt23aYvjnat94WJC4gdTucd0b6
 2Db9XNu71n/YCNi6klawbwlq2/0znQqZlRsjukyYo5DxlkmDGJCT9b0gWU3Fd4acO6koqCp5
 RDoYfS24uEUFo2qnyeQWugLF7zBz6/bbG2D3AQ1R8hwqmnFF5ufkWZ4um4WyKBBaJtsRNMUS
 BWL5VM5CGF7YhNGkpObk6ruUp93nMAM5PzuV+zOb8omX3SCXFTvwc2aXmbJhzqFuBF1yckXY
 M7HGe7xXSdyIfk2l1KeGrZCuYLHMwhjnAs/s7iglE/5uVdfDVbIIYo43KymNb5htvre8FSIq
 76y9aKikn1ibQE3WQGPmaZ7ELzABSFT6UzewyCPStO+Hw==
IronPort-HdrOrdr: A9a23:Wonlcq3KjnyIhynrAwPBQQqjBRxyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/hfAV7QZnibhILOFvAt0WKC+UytJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZi6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngcOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4kzEz5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXMISaCUmRQXee
 v30lMd1vdImjTsl6aO0F3QMjzboXMTArnZuAalaDXY0JTErXkBerV8bMpiA2XkAgwbzYtBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIfLH4sJlOy1GkcKp
 gnMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNxd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDhRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dvP22J6IJzYEUaICbQxFrEmpe4PdIi89vd/HmZw
 ==
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="67771780"
Date: Fri, 1 Apr 2022 15:50:00 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Message-ID: <YkcRGIy7l48BkZQz@perard.uk.xensource.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220401143720.23160-2-roger.pau@citrix.com>

On Fri, Apr 01, 2022 at 04:37:18PM +0200, Roger Pau Monne wrote:
> Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the
> Makefile doesn't get it propagated to the subdirectories, so instead
> set the flag in firmware/Rules.mk, like it's done for other compiler
> flags.
> 
> Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT')
> Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>
> ---
>  tools/firmware/Makefile | 2 --
>  tools/firmware/Rules.mk | 2 ++
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
> index 53ed4f161e..345037b93b 100644
> --- a/tools/firmware/Makefile
> +++ b/tools/firmware/Makefile
> @@ -6,8 +6,6 @@ TARGET      := hvmloader/hvmloader
>  INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)
>  DEBG_DIR := $(DESTDIR)$(DEBUG_DIR)$(XENFIRMWAREDIR)
>  
> -EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
> -
>  SUBDIRS-y :=
>  SUBDIRS-$(CONFIG_OVMF) += ovmf-dir
>  SUBDIRS-$(CONFIG_SEABIOS) += seabios-dir
> diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk
> index 9f78a7dec9..efbbc73a45 100644
> --- a/tools/firmware/Rules.mk
> +++ b/tools/firmware/Rules.mk
> @@ -13,6 +13,8 @@ endif
>  
>  CFLAGS += -Werror
>  
> +EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
> +

I think making modification to $(EMBEDDED_EXTRA_CFLAGS) outside of
"Config.mk" is confusing and would be better be avoided.

Could you instead call $(cc-option-add ) just for that extra CFLAGS?

>  $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
>  
>  # Extra CFLAGS suitable for an embedded type of environment.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:52:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:52:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297481.506784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIdW-000376-M9; Fri, 01 Apr 2022 14:52:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297481.506784; Fri, 01 Apr 2022 14:52:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIdW-00036z-J2; Fri, 01 Apr 2022 14:52:26 +0000
Received: by outflank-mailman (input) for mailman id 297481;
 Fri, 01 Apr 2022 14:52:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwaM=UL=citrix.com=prvs=08375ea47=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1naIdU-00036s-VJ
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:52:24 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 55caf67d-b1cb-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 16:52:23 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55caf67d-b1cb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648824743;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=pezlonkQC37kwAxQaulXOLSG8IWcHk2dOo+beOFVOw8=;
  b=DyM4tRQvS7ECW3pjKcZnGqJ5iS60j7soOJcdY+MV3WIxBDhzBLKYUv2q
   sfp/kVHgC2FFFKC1YqeV1d4vFivff8gM0ouAaaiGvxaYXlJ/3j3E7Lg1h
   JzsG8FuUsi3kF975HpEiGPz3rwcpQex9cvmlMUWUeJrB0V2zzrxeg35NY
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68178260
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:seXO66jj2y2GFpyqqpyqI2JgX161WhAKZh0ujC45NGQN5FlHY01je
 htvXGGPbv7cYWOkKowkO4vn9hsBv5bUm4BkSQZk/3g3Q3gb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vU4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YToyJ4nXiL84aTNBFzlmL4l8oobgGFHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i
 88xN2o2M0SaPUUn1lE/BLcdtbmqpyfGchIblXSuq6wX8Tnp5VkkuFTqGIWMIYHbLSlPpW6Dv
 X7P9Wn9BhAcNfScxCCD/3bqgfXA9QvkXKoCGbv+8eRl6HWR22gSBRs+RVa95/6jhSaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8kCirHTMFdko4TzYAVRMXx+O5maYKp0eaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9bwgWU3+8qsO2pworOpm
 HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8R5n9hO0yT6FWy13N2YDB02WirjUWW1C
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKF/YoXs0PR/Bgj2FfK0QfUcXY
 8jznSGEVytyNEia5GDuG7d1PUEDmEjSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPjsnekhy
 P4Gb5Hi40wGCIXWO3CLmaZOfQFiBSVqXvje9p0IHtNv1yI7QQnN/deKmuh/E2Gk9owI/tr1E
 oaVAREAkgOl1SyacW1nqBlLMdvSYHq2llpiVQQENle0wXkzJ4Gp6aYUbZwserc7sudkyJZJo
 zMtIK1s3twnpuz7xgkg
IronPort-HdrOrdr: A9a23:gtCgKqBmKpGGrdblHemo55DYdb4zR+YMi2TDsHoBLiC9E/bo8/
 xG+c5x6faaslossR0b9uxoW5PhfZq/z/BICOAqVN/JMTUO01HIEKhSqafk3j38C2nf24dmpM
 JdmnFFeb7N5I5B/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="68178260"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XVfn4Vr4+blFLRU/l8YUMLqx6nAPvKe9URBwPpoY7Wu0FnVo4mLMtTHSqQ5HcKWsNs+YH8OlWwMewwEhGa+4WgVFjPzyKYZWKx+lkcL4pngxYU5aChRVvq4jUBUVN2YPbYS3JoIMC6EwUTinY18OZdqg6h9msPAgPpzQGNkdXoS78RUEIl5pU009AaQNPjOXWMVjubgj3//FhERf+HVsMuLqjS1Plk4bB39qVflwoTzTtRMTy/QGJwpWrpsZ1N6rasmMkpVxa3SoIPnPLq+Pvuyj+vW4J/XqCNqyOWi4qSgx2aOaRe1VcsTWMC5BvBOPJhxpLHXZUMKZnqxZUa+BBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pezlonkQC37kwAxQaulXOLSG8IWcHk2dOo+beOFVOw8=;
 b=KgGIteFmTaDWCf+bDh1nD9YV4o1dTtRlZwXIfyMVIWTizzOZlc849E7mglRUy3xcsj7EjY98N9Pwx/mSpPdvuTj/rrQNnJuyLxzMikR/VP8A01KIf9lTEx0AzWP7aKDUSfQOHdqJoD1XVoYej7/YcGzrNUyFxjNS1DqqPmvmi0OPPpyNB85NLxlSb2D3SSXawPmcoVxIPD8RgPWJlzrbtO7Q/0ocPrg0UqTk5i5S3fxUSSfP7AXCUlQvIoSKKy+B2u/F1uItrA0wSmUJbjJVtN9ZpEj8+E1x7U8WD5BrGuWaXBkhriSJwu/1RVZtwgQdT65vGmIfFiirPabjCWFSdA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pezlonkQC37kwAxQaulXOLSG8IWcHk2dOo+beOFVOw8=;
 b=BWWA3uCwy8JReKkR+qjn3dPJrIh9Jb4oi1zuMb17BCgkHpIljqVv7gsB5IdpfHi2E/XTXIA9c+29o4wChN5Xy+yjFMBnSE4fx2w3u03MyaP9TNpS9Giz6MBrJ8HJm1a/gZ6E+tOHGG0/yzKlRU9DgNHkhSIIZDrKZVAUUdGEwWM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH 2/2] tools/firmware: do not add a .note.gnu.property
 section
Thread-Topic: [PATCH 2/2] tools/firmware: do not add a .note.gnu.property
 section
Thread-Index: AQHYRdYPmZpfvGUBfkGAVUMDs/atUazbJFgA
Date: Fri, 1 Apr 2022 14:51:46 +0000
Message-ID: <e8e6c813-bcb8-e017-aece-e1315ba305b2@citrix.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-3-roger.pau@citrix.com>
In-Reply-To: <20220401143720.23160-3-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 24ad8ade-6e2d-4d53-6d5f-08da13ef2509
x-ms-traffictypediagnostic: DM6PR03MB4409:EE_
x-microsoft-antispam-prvs: <DM6PR03MB4409568234442FDE76295281BAE09@DM6PR03MB4409.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: nRGc9YJoYWy5VAJ2K02rOeU7cFQ01PZCIY6qK7BD4HfBv8IqG8ssHQr8QbpGgO+h/+2/4JXFhzcngERjEcAhyoYZCZqLr/9ECuE8HpQzinjCWD6Rojt2UL+Q7wpB3RSutnz0g9ybrqmXhAp4dnaYrfzlE+ZR1Em8QHDuLy5QgcSTH+J1Cx4MPe9m2kKhvcXLidPywDwsIM0gcegCWHZNbdjxeKSq5GLcbdsVmSPqLYLdJwuFAVLmvA+qG3r3Swu7DZR8Va8neZYL5DtywCDCrpqdp7mPRtSwr/Ykqm5F5GdQsGTzBEUEemqF0tDZzJF8HN0ZGP75QRS+34MhQy59NgX98xlNDwTMI3/vMBorgwMeEyZ3WYhxJDdOBXo808H5qBNWZKLqbEY6W3BtL8hRlYzspQLOZSKniT73czSTh1mW7HpOg9kgyOCil5l53vVzYzCB9gBqBXJbvNaswE4ruh17WWwSCu/msWvddOhsO3n9XmsHaPOL8YndDRtyj85NFmL/C8aIgpRrJTgfIm9C8tcTzp/Rt8yDSKO/4nu8T6hF6PgrCVYLPT5nNsGrz3E4X9/jTw3tPPqi4kyzhMUhm12zpDNQB6L9mW88PEP9WuKY/t29i3ea4DoQYsUR8C43sRFlGR66XK0hA7VErchK/tl3foeaobM2qnxKhhK5Sxej2WWVOWkXOcuhaD5ne4g2x7usuJVc9SrtL5S+69Zhn9jl76oTudQ9mzOSqC+Zle2EFtTw4cOT/gCRRzylnEx7jwNFcD+dtyK24zdl8GcgDCHAQWrAIfEpmJTbbxkbjxg=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(38100700002)(38070700005)(82960400001)(5660300002)(6486002)(110136005)(54906003)(71200400001)(508600001)(6506007)(76116006)(4744005)(66556008)(8676002)(66446008)(66476007)(316002)(8936002)(64756008)(4326008)(26005)(186003)(2616005)(107886003)(91956017)(66946007)(2906002)(86362001)(55236004)(53546011)(6512007)(31686004)(31696002)(36756003)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NHExTWNBaStuRFNHcmp2dTh1UmpjY3ZUNE9YbWdEUGd6ZUc5VG93dy9jdVVB?=
 =?utf-8?B?Wml0TmMva0xLWWYyK0QyeXczc2RLSVB1d05Femc0bkFoWkF6UFp4R2ZKZnhN?=
 =?utf-8?B?QzcyQ3BuWlZtTmZoMldXRXR2V3M1clZRdi8zTk1PTjFseVBhb0h6cTJBWVZC?=
 =?utf-8?B?M3laY0dJVnFYZ0JuR2pRUXV2QkkwVWNvanUrTFd1ZkRJL251UnZhZmxPemF5?=
 =?utf-8?B?WDd4L0hYSnJCemwwTFJ2TzlWMmhhN0E2NTg4ZVBmaXFlWXlXWU5NOVFJRTNT?=
 =?utf-8?B?MVdIc09EVTRlcVQ3a1JycndqbVYrVncwRWtCKzZ5M3BFQzhkVFJzTGNPR3Vv?=
 =?utf-8?B?SmhjZU9UODMrb0g3bVpQUmRBTExFNTRTeUt6TjJwZGVLdUQ2K3Q0cTIxNGsw?=
 =?utf-8?B?eUFPQUpNSWNtVXNlZko0dDF3YVhodzUwbm56YkEvNFVKYVFEekdCMkF6WFJ0?=
 =?utf-8?B?emJSVjgzdTczMnp6clVOK1Q5TkdtdndMbDk2QnQ4bmpOOVlVY3IvK05JNHFk?=
 =?utf-8?B?UlRJWjVsS3YxVy9rUEo0NGtaNVR3WXlYYlYySWQ2OW1KOTh3em1uMU50ZHN2?=
 =?utf-8?B?bm5NUnBxczIzdEVpb1Q4R2w5b0lBNlJvMi9DbzBaazlUQmpSdmFJSGViRW82?=
 =?utf-8?B?Zk04anVOWnNGUDVQOStua2V5OWVGZUs5ZW9kNlVGZHVwVi9iM3U5S0hmV0RG?=
 =?utf-8?B?aUh4Y1ZNVzN5M1lQUUZCemtVblFibzM1Ni9RRnVKbXZPeE01dzNhYlYvOExR?=
 =?utf-8?B?YkpMam5XVnFVcy8vQ296dExWd25CWVV2Q1J4ME5DZXRHMVU3TGVrWXZaSUtG?=
 =?utf-8?B?L2NiRlZoTXNtdlBHRmNSeGVyVDZLZW9obmR6d1dOQitxVDlsVVg1OWZPdFNu?=
 =?utf-8?B?WUk5dUxoTk4wUHA4c3Q2UVZGbWpSUjhxWkt4dkkzVWU5Qm1YS3V2YW5CcXNp?=
 =?utf-8?B?ZlpFQUIrVU84RU9uZjZGY3I1bDkzRW5qUFVDaHd0eFVVNlY3cHVMd2RPZzZ2?=
 =?utf-8?B?M0J3blFndWpjeTFVczJvd09SK08vVEM3TXNTUEpncXhNS2ZGaUtLR2h3VEdV?=
 =?utf-8?B?SERUOS9hQzE4ZDBPeEx2L2NBa2hvcVpWbmRWK0k4WEZ0cW0ycklhQzJMclkx?=
 =?utf-8?B?Y0hpeFZNNVVCem5Rd0NiQzNvUmNJWnFWdlVhN0xRbUdqdWFubmlaN2U0VHdZ?=
 =?utf-8?B?RXBIUU4vUldaTzNjSGNDbXFIU3g5VzlwQ2QwVmd5TG5CN1k3VkFLTFJRdW1i?=
 =?utf-8?B?RkQxZ01KSmNWK0k2YklJMmtIK3Z0MUI4MFNaMTlESWNVbTMvVW15RkdERHRQ?=
 =?utf-8?B?ZU9Hekc3S1ZGNkZJU2JMZmsxdnBadlpabmczaDBxZnNqbTJqbUd1R2FmVGtW?=
 =?utf-8?B?NzRDaDZCSW5oeWhWWm8vOEpENmMwSys0VzBuK0NtVXZqbGxTTUNsRGtMOVkz?=
 =?utf-8?B?WjhEbUJJMnQ1VWlRM3I5MTI1b1p5TFBGSTJoSk9MeGdFZ0RxSGdqL1h0SkJ5?=
 =?utf-8?B?U2hNazZ3bm1tanM2UWFBMVF3MEZaa1N4SzBzUEswL0Y2TFpyM0RrRDBJVU9G?=
 =?utf-8?B?MS9hYXBaK2JRZ3FkekZFYjRkNjgxYXBHejlVRy9Iczk2dWR5d1FGUkpGU1pt?=
 =?utf-8?B?Y3VuL01MQUNpTlVNYnk4V0ZvNjFEaVp3Y2JJQVBXM09FZ0pQdDFFODVmeWV4?=
 =?utf-8?B?NHp4ZThmMTgxS1VCSlRVY1FaWmdrcTNRZDNjMmhlK2JIczJ1bDhMSGVFZEVU?=
 =?utf-8?B?dGgyU0xqTEhmS1dVR3ZubThXb0tlRnduNW1zdzJpeEpuTThiQ1R3VDB2Zzhj?=
 =?utf-8?B?TE5JZVIxODIyL2pMeEdkZU1YTldCY0FnKzdmQ1B6ZVJZc1F1Y3A4UjNFbDk0?=
 =?utf-8?B?Nko1K2ZhRWFBeTFERnRQbHpQUjlld3FGQVdpdksrSWtQK2RIY2NCN21Ca3dD?=
 =?utf-8?B?YlhqQlNyczlBY1Fmc2lCUThMaG9OeDc1SnV2L0J5OFZtZU9Yc1lKZWgrcW5t?=
 =?utf-8?B?UlZEWkhjUzNwNDlNalgxbWFTb1lVRGNCNmtjWi82V1R4Z2ZTNGRFSWRpZzQ4?=
 =?utf-8?B?a2VOVnRUaVVOVTJFMVdJa2w2aUF2eVB1TldXK3M2eDUxMkxzYVI5a0F5S0Jk?=
 =?utf-8?B?REhjeHk3WUpGOXpITmVqYURUZHVCUjJRNll2aExRY1B6UzF4bWlDRkJSU2xt?=
 =?utf-8?B?SlM5MDYwY1FOaTBuQ3ZRU2tlN0h2TkZ0T1hFLzRCUE5PVmwxREJnNTRNUFpD?=
 =?utf-8?B?bzk2RE5lVFVYVlhzYVNoeWpkdGk0WU5VS1M3RTlLcG93Zi9CWThnWmhnK3Zo?=
 =?utf-8?B?UjF6NEVjVTdHZVozWXZSZmx6VTI1eHBNc1RsQlpWZmJCMmU3akRrQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <923E6168D3BE694085BED634D05D52AA@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24ad8ade-6e2d-4d53-6d5f-08da13ef2509
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 14:51:46.4426
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: T8fVHDaGGGrEW/457FN1uAW+kIgjlXgqUeNTf5Ae2mZ57nY/EIDMMrtB3tNlBwVpKpT2qQ3UxzJtv6GUhvSqnymVohiASpv0B8X2lb8uano=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4409
X-OriginatorOrg: citrix.com

T24gMDEvMDQvMjAyMiAxNTozNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBQcmV2ZW50IHRo
ZSBhc3NlbWJsZXIgZnJvbSBjcmVhdGluZyBhIC5ub3RlLmdudS5wcm9wZXJ0eSBzZWN0aW9uIG9u
DQo+IHRoZSBvdXRwdXQgb2JqZWN0cywgYXMgaXQncyBub3QgdXNlZnVsIGZvciBmaXJtd2FyZSBy
ZWxhdGVkIGJpbmFyaWVzLA0KPiBhbmQgYnJlYWtzIHRoZSByZXN1bHRpbmcgcm9tYmlvcyBpbWFn
ZS4NCj4NCj4gVGhpcyByZXF1aXJlcyBtb2RpZnlpbmcgdGhlIGNjLW9wdGlvbiBNYWtlZmlsZSBt
YWNybyBzbyBpdCBjYW4gdGVzdA0KPiBhc3NlbWJsZXIgb3B0aW9ucyAoYnkgcmVwbGFjaW5nIHRo
ZSB1c2FnZSBvZiB0aGUgLVMgZmxhZyB3aXRoIC1jKSBhbmQNCj4gYWxzbyBzdHJpcHBpbmcgdGhl
IC1XYSwgcHJlZml4IGlmIHByZXNlbnQgd2hlbiBjaGVja2luZyBmb3IgdGhlIHRlc3QNCj4gb3V0
cHV0Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJp
eC5jb20+DQoNCkl0J3Mgd29ydGggc2F5aW5nIHRoYXQgdGhpcyB3YXMgZm91bmQgZnJvbSBYZW5T
ZXJ2ZXIncyB0ZXN0aW5nLCBidXQNCnRoZXJlJ3Mgbm8gb2J2aW91cyBGaXhlczogdGFnIHRvIHVz
ZS4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 14:53:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 14:53:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297485.506795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIeB-0003i2-3y; Fri, 01 Apr 2022 14:53:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297485.506795; Fri, 01 Apr 2022 14:53:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIeB-0003hv-09; Fri, 01 Apr 2022 14:53:07 +0000
Received: by outflank-mailman (input) for mailman id 297485;
 Fri, 01 Apr 2022 14:53:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i2D4=UL=kernel.org=robh+dt@srs-se1.protection.inumbo.net>)
 id 1naIeA-00036s-2d
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:53:06 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f153ea0-b1cb-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 16:53:05 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4B4A8B82410
 for <xen-devel@lists.xenproject.org>; Fri,  1 Apr 2022 14:53:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEA28C340F2
 for <xen-devel@lists.xenproject.org>; Fri,  1 Apr 2022 14:53:01 +0000 (UTC)
Received: by mail-io1-f48.google.com with SMTP id p22so3439371iod.2
 for <xen-devel@lists.xenproject.org>; Fri, 01 Apr 2022 07:53:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f153ea0-b1cb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648824782;
	bh=/qJ5e8ApNXEslgZif3A+1qHL8sGqL8BHZ/5lwZBrzOM=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=eacsIzo2gGzLlcXr8aw/dfGWXvNK75+a417SQ6aMoBLmz1QicDGTOapgxufpt5xRy
	 lmOjT1gr1+guHHNmH9dCQWKVNa56c0rcTBbKp+v+EgoGLirpgxWbkibzx93NXD04ql
	 oFIOJ4HXR+Es2wXEaLLUsBAAvWQZPCBqWJPB/iijdCO7/hPMCRPT77LZHBT7lqa/Hn
	 VfDb1LnjwXZ5RSjBvU1B8ronPoIMdHIqTNrvl7vgWkto6UQvtFtYSdBC59MPTOdi4T
	 4NuaNxUc1ALOK4izHK+Vm0TGpolM2E1ZErrTPysPPCpNKMScwF7o5JO2ZhirUGR5i6
	 dBgYyrzuIMg8g==
X-Gm-Message-State: AOAM530NX6eqJy+ONRDHmTafFrfQ8/hNDYwrlVqtfs7/G9YJ4NQ1Zyy2
	Wk5u1resmQ2xW6XUUIVQzre1c77U7TBnbF/h7A==
X-Google-Smtp-Source: ABdhPJztqb7hywLo6jomiCi/xpWuP4Ps8FDR3Hi5OQUdcpkAmfwo4X57RxkU30wbPhT0Ng8yQ8uNFR2Z1JL0f/H8FMA=
X-Received: by 2002:a02:1107:0:b0:321:78dc:890d with SMTP id
 7-20020a021107000000b0032178dc890dmr6112922jaf.236.1648824781026; Fri, 01 Apr
 2022 07:53:01 -0700 (PDT)
MIME-Version: 1.0
References: <alpine.DEB.2.22.394.2203311740450.2910984@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2203311740450.2910984@ubuntu-linux-20-04-desktop>
From: Rob Herring <robh+dt@kernel.org>
Date: Fri, 1 Apr 2022 09:52:49 -0500
X-Gmail-Original-Message-ID: <CAL_Jsq+udUpUK3y7WOeLF2dtGs0=Jz59ed0mu_sgzstB-=TDzA@mail.gmail.com>
Message-ID: <CAL_Jsq+udUpUK3y7WOeLF2dtGs0=Jz59ed0mu_sgzstB-=TDzA@mail.gmail.com>
Subject: Re: [PATCH] of: of_property_read_string return -ENODATA when !length
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org, 
	Julien Grall <julien@xen.org>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini
<sstabellini@kernel.org> wrote:
>
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>
> When the length of the string is zero of_property_read_string should
> return -ENODATA according to the description of the function.

Perhaps it is a difference of:

prop;

vs.

prop = "";

Both are 0 length by some definition. The description, '-ENODATA if
property does not have a value', matches the first case.

>
> However, of_property_read_string doesn't check pp->length. If pp->length
> is zero, return -ENODATA.
>
> Without this patch the following command in u-boot:
>
> fdt set /chosen/node property-name
>
> results in of_property_read_string returning -EILSEQ when attempting to
> read property-name. With this patch, it returns -ENODATA as expected.

Why do you care? Do you have a user? There could be an in tree user
that doesn't like this change.

>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 8e90071de6ed..da0f02c98bb2 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -439,7 +439,7 @@ int of_property_read_string(const struct device_node *np, const char *propname,
>         const struct property *prop = of_find_property(np, propname, NULL);
>         if (!prop)
>                 return -EINVAL;
> -       if (!prop->value)
> +       if (!prop->value || !pp->length)
>                 return -ENODATA;
>         if (strnlen(prop->value, prop->length) >= prop->length)
>                 return -EILSEQ;


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 15:04:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 15:04:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297491.506806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIpY-0005GM-6x; Fri, 01 Apr 2022 15:04:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297491.506806; Fri, 01 Apr 2022 15:04:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIpY-0005GF-3X; Fri, 01 Apr 2022 15:04:52 +0000
Received: by outflank-mailman (input) for mailman id 297491;
 Fri, 01 Apr 2022 15:04:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwaM=UL=citrix.com=prvs=08375ea47=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1naIpW-0005G9-Fv
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 15:04:50 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 124d5072-b1cd-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 17:04:49 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 124d5072-b1cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648825489;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=PPqHA/MZh4eS0o+MlOz+r3ixLSalPH+ceDM5C4RiUfE=;
  b=Orgb137uutGEWQIU4oHw0azvIwWPS9v3Y/4dkZlky3oSoeEf4OFJUHFY
   lKeY+Wl7tCBegX+VuPisGt/tzpBAsglyGZKVt+87nOiOtXxna+AqqcCyj
   99dat814Tlc9Ps1mOCLS8db5NuEdyHgwPTPpxhWpCldT4Czv0B6JDHBcP
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67791584
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fgrfZK74VLdSfcsympe7zAxRtDnHchMFZxGqfqrLsTDasY5as4F+v
 mYfWDuPOPuDNGGkLdh3b4iz80gF75DUm9VkHFNtrio8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThWlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSQRjsgYvGdo946QkZUHTBgOY9GpqPIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RGNms2MUScC/FJEnkdUbJ9hNqOvHXicGFe8GPNvrEowmeGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYCD6TnPi/6P/0BTnHYsCd
 QpEoULCsJTe6mSLQeX0A0Hpm0Sjr0EQVctOF886th2Cn/+8DxmiOkAISTtIadoDvcAwRCA32
 lLho+4FFQCDo5XOFyvDq+78QSeafHFMcDRcPXNsoR4tuYGLnW0lsv7Yoj+P+oaRh8a9Jzz/y
 iviQMMW1+RK1p5jO0lWEDn6b9OQSnrhE1ZdCub/BDvNAuZFiGiNPdPABb/zt6ooEWphZgPd1
 EXoYuDHhAz0MbmDlTaWXMIGF6yz6vCOPVX02AAzT8Z8rW71qi/+IOi8BQ2Swm8zba7onhezP
 SfuVf55vscPbBNGk4cpC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk3nVKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4vf/l2Pq
 owPZpbSo/idOcWnChTqHUcoBQliBVAwBIzsqtwRceiGIwF8H3omBeOXyrQkE7GJVYwP/gsU1
 hlRgnNl9Wc=
IronPort-HdrOrdr: A9a23:mbLe1a8lxOTIP06e6cxuk+DWI+orL9Y04lQ7vn2ZKCY4TiX8ra
 uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAG0aLShxHmBi3i5qp8+M
 5bAsxD4QTLfDpHsfo=
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="67791584"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XYpZi6G+/irvyJy7vh55wLrvQlMbFmkJuxDW/mtFjmJJGub/V01ARBnT2yC08YSGm8Gm+FfAIuoH9e5MU5jY1A8mnrtpt+wG4O46Wu4BUXaaxoNDDNUYVL3l/DusYxcXYkbrHtwfh6f9YgpIA4JWrBJqMyb0HL6gB8BTUp9wpVmDPstqBSa40cih6XyDWim7rgYGWLxQhM4rR9BWugrLM2ctKkEXPJ9MUV7quFgF8svZ8NB698ilBJPEGnNSCk7GpB3c+uOkrEMm4iKy3QuzbTRe2sDl6GNG6ae+YtUfZxe9VHfy+qYO0BN+lmxld9mHUp29U5uHnFcSXfpsvG3+uQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PPqHA/MZh4eS0o+MlOz+r3ixLSalPH+ceDM5C4RiUfE=;
 b=kBHuby/fy2cgxzXR+V3bRaglCFJeQukIf1BR0WH8XqnsRKCV475IheLfYUGr1FCnEzgWBuh3cHM0fbWNMKTO00J1s2qMScPnXwEP11SR/OM6vGs4Sl/PZk9OTPQrK5LHDSqsKxBugF6V5CuU0NCeR7Ql71KCl35fETz6EMXAIDdOKyngHBPxAQPgAO5cgsIVoU3y6h2xh34U4aQRToBy79U1ImAx02ma8vWoH4T2Rx9vpayjZU5W4ywSsTSkWUy7oZRipaX26Q2qD0M5RlaKVRaAXipd9pQHrSm3MwZTzaInl2AQcdUxlqtT7teL8iM+jG8+Tx108fdf9RaFOPCreg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PPqHA/MZh4eS0o+MlOz+r3ixLSalPH+ceDM5C4RiUfE=;
 b=dv8/Oe2pls5BxKuiagIRHJ+pIUK4vd+JYydTUYAlA67NeZZ/Fn4UVPvTeec0KCKgVLfthzigaatk6ZkTeRLo2w3qeNCCFVzGIF/vXm57MEZONzF0lkI2reAsGl8wy0Dq9P0y2M7XrdjN14tj0yIP8eMs8pnv2vZ/r8cep2M7vxk=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>, Roger Pau Monne
	<roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Topic: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Index: AQHYRdaC1Ty1lDbR3E6vxjqdlx39GKzbI9kAgAAEHQA=
Date: Fri, 1 Apr 2022 15:04:44 +0000
Message-ID: <7b129a01-07c7-e856-fb5b-0c7b44a8dac5@citrix.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
 <YkcRGIy7l48BkZQz@perard.uk.xensource.com>
In-Reply-To: <YkcRGIy7l48BkZQz@perard.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cbafe306-e1d5-44b2-fc7c-08da13f0f4e6
x-ms-traffictypediagnostic: SN2PR03MB2158:EE_
x-microsoft-antispam-prvs: <SN2PR03MB2158B605148BA18C78B48376BAE09@SN2PR03MB2158.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: su3QZbQUxMa3XC4B0/dUGQSqem6Krnn3qTxJkkFb1cIbqsax7TrXLPgxtkoEkc8s5bHBJRrarqhS/pI46ezgq29i01UsuBkzv1SmIGiZ9nZKcEaj+XLdN5Fsr2hijRBGIK5IGGexBBKzIMDKBeBrZ/qHWn8qkjvi6G8fmf+pCwb22yD0gFOt79gn+tEYEy3gp1JL29iAKvqqoG/qbtqsnxhWIV8dOIb2pil9ouksfwIIlf3i/oP1i0t+/G+oVwSX0edVXDQd+MizwV9GwhHY7VHoHIiJBk+E6GbLoI8Io1V7M9kEsShcOBZkdQGpEMsjhvYbtueet46fxz31Xqaw+y5qwOM4gefB32EWpKPmx59udViPok0jlCZeTUfYfxPbO4yu31Y3eSx9cGDUC8XQpMCrUwhqI3BMADPVa05Jr+C75NgZfpPWHEZpJLHVvdDX/NvN21RbopgOII3IJLPkCW3L2/I4LZEe1LXJc4+lgub1LcrlRXt9mIp6q4zgj6VoMFJqimUrM9EJDCJ0wDnQg5HZcxgfWfm8uHURt8ck6U+SHRrjbhicnG/aTQQd8KpUz7jxmXvYJbs7rUdK+E6X6EwwpK3CFWenQHxhlaj0GQgsqvpnPhscvEzHgGLwZS+AEI5UZ1780gAY9yCclXISU5A80Znno9iwrih9f9VLXFZIt+ehU+7UKnB3DYNpvFUgmlvP2nnycuY74WKB1vRb2qqVsUWSP2/MuovEGQSlMeXD4w4fI79Eyjzz2+DhKv4ZpglcbPGoy3wfF8XJm5wdSw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(8936002)(5660300002)(82960400001)(86362001)(508600001)(31696002)(31686004)(76116006)(6486002)(55236004)(66946007)(53546011)(91956017)(64756008)(6506007)(4326008)(8676002)(38100700002)(6636002)(66446008)(66556008)(110136005)(6512007)(54906003)(66476007)(83380400001)(316002)(2616005)(26005)(186003)(36756003)(122000001)(2906002)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QUZvWlEwQk1weUdpdy83WjVxQ2tXMlMyNnZkU3IwRE1SYlNUQS85VEhGN1pY?=
 =?utf-8?B?aXZYOUM2Qnh5Mk5OTjZ3TmxiVmJVNjhGVXVIaHBJUmNzWGZmekdZeVRDdjFS?=
 =?utf-8?B?RVMwYkJSL3ZVM21oQldKVllScUNOcUd6YkNmVWlKMWsxVElzeHR5ZWdGU0hT?=
 =?utf-8?B?UTZnMHdJcXR3M240U0tiVEFxaW1xL1Y0U25IVjV5TUNzSmRyLyswREVKVys2?=
 =?utf-8?B?Q1NQNThEUUtvUmVQdWJFZlNQckNSd2pPTHR6aHQvUnhyNnhZanZmMVJmd2lr?=
 =?utf-8?B?ZU9PVkRBVElocEpZcERBcXJvYk95YXhVWTRva1R1UWVsa2dWSXY2bWF0S1Jq?=
 =?utf-8?B?ZWNmSmIzb0ZOaElMYlBUYlZlMXFMOTdPckNDYktXV1JNS2FTMlRUMUZ6b0Ro?=
 =?utf-8?B?RzlBZnh2WjVKdnJGdmY4RGpSMHJ5MmYrYmIzU1VUQ0RaaCtTcGxMR0xUeWNr?=
 =?utf-8?B?QWtNdEd6VVNRTHVGZ2U4Qk0rK1JSNTFzTlhpYzlIRnJZV1I3TzhHYWxYT1Fs?=
 =?utf-8?B?Z2xGVXZ2M1BuWFVRTDd0ZlJEQWgxTGo0WE5jSkFDaGFsaWVDa0lKR3hjUXVn?=
 =?utf-8?B?NEtRYURIS0dSN0ZtZmZZZmJERnJTS3Bic3RYdGd3N0grb1JSV3ZhcHZDS2lK?=
 =?utf-8?B?WngveGU5VDF5elJWYkZ3Qk1CVHVaTXBUcVYydFptMWR0RGxiVG5QTGdicnoy?=
 =?utf-8?B?a3pZZHJ6aCtHMDU1dEdyWFMzbHNud3N4ckYzSzlHUHJsQ2Jzc2NtbFRTUG1a?=
 =?utf-8?B?WHQ3S3FDeW9TTy93UmFLbGxPMmZ2RmpKeEI4dWl5bXA0eTdvZFVvZHpBZG5o?=
 =?utf-8?B?Z2VZNXRIZUpwQ0RqMmo1QzNad3ZEQzM3R0ZIL0VDOFZEbFNjYVN6R2Jwdmxp?=
 =?utf-8?B?ajMyNTFmUHBRa0ZxWkd2T2ZRME9Seis3SlNRNmJoaURPQzdEOGZ2a2xrenRW?=
 =?utf-8?B?U3d1SzQ3cnpnOEhjQzlTSUwwYzZZUW9sN0xQTDlUbFFSMGliS1hsTDNYR2xv?=
 =?utf-8?B?SGthR2hTRktSUVN3YWVsMURWRVcyZzNQNFUwL1QvMGpxSVFMQ1h5VjRFQ0to?=
 =?utf-8?B?TVIvR0VBTFpVeVFPbDA1Ymo0L0Z2QnBjd3Y4K3R3RkU2Tzc0alBOZ1luRVBY?=
 =?utf-8?B?MnNjdTlBeXFoN1RaNTBPK3RQNW5tNTc1bzZvNjJyMFVlb3lTbndsZU5oWUdu?=
 =?utf-8?B?eFdIOFlVQW40S2VUS3RiMGUvRHlKRVBDMTNLYkZRc3ZCV1FwSDVGWlpTTDUz?=
 =?utf-8?B?OGFDOWtLb3BFZVVuUlVPMCtKdERzOFNTejNDOTM5VVpDSC90anhyUUErSzlY?=
 =?utf-8?B?UUtncmFuOFJ5S0NQYW1KaURRNVZEa2VuYk1sQURtSkhoZnJCT0djcWpnN1hW?=
 =?utf-8?B?bm9id3Z0YzV1YXZuMUtkNEZLSXB3NE05N1N6ellDN1M2bHF5UkY3aDNtR0J2?=
 =?utf-8?B?RVBQa0R0NUZLTjhnN1NseXRLWW5wZVduc3M5Zk9JY3Bzd2RGcC9HV2FtMFY5?=
 =?utf-8?B?WDQ3NWRBYzRTbjNpN0tPS3lhRGVHa2xwSlczV2JQaDhCcmZHMkJ2ZkRsZ0cz?=
 =?utf-8?B?RklBZUd3MFBZZFZQZXBPRTh3RkVYQlpOQlpWUExic2RVRzVnaUVBbVp0bDZp?=
 =?utf-8?B?OWRXRm8ydEJRaGliK0ZiVld3M1VMeEVPVlZZYUZZeHFaeExoWlFmOEJWQ2R5?=
 =?utf-8?B?cVdGazh3T3ZiRGNia0xUcHJoKzk5NTJDMnpXN1NTd2ZmaXVIN0dtMkRWRXlo?=
 =?utf-8?B?Y1draW1WbGNrYm5YOUxRb3VDc2xmZ2JjcjhhZ1doekVYRHI5ZklzWW5Pckpk?=
 =?utf-8?B?MURkNDBhTHBpZXA2Y3dBbDF0ZkNaaDJaTDlhbDVOc1dJZ0tDTDZEUWZqLyta?=
 =?utf-8?B?Ykh5alZWSmVvd3BRdmxoZWNNamhYU2JIaGc0bWRuWlpHUkRCYXBzNUcya21Q?=
 =?utf-8?B?dXBINVVrV1F2bDZrVHNmS2hkZzNtbmlueGU5THk1S3c4cmhSVHI0eWpZK0xx?=
 =?utf-8?B?N3JlTWpLZzhFSnZYNmZMTVc1WnNmTXNjWXQvSVVvREN3VlY3c1piZ1Y5VzJE?=
 =?utf-8?B?QUliai9uNE9mRk95T2pyeUN5Rk5lQ1R2N2pGZ1F0aldUSDA3TjIwZnppbnhj?=
 =?utf-8?B?dGh1SEtSR0ViN1VRT2ovMU95TTFCOEpGWHdsdzlMc1VZUmViSGFiVXpUb0Uy?=
 =?utf-8?B?Si8vdlZyTCtUalJMUnp4MUkydnBSUDlXMjlDdmJrTVZZY05hMm1nZ2NDbktZ?=
 =?utf-8?B?KzdhRmRNQnZrUWZOcFVVRlVFVHdFN2lacmRQZ3NSTFVLeFN2UEdReUpPTDBS?=
 =?utf-8?B?eEM0VTJRYVd5ZGo1a29id1k0d0J3YktMSXhVYjFjaWUyZ1NXTC84UT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <ED6D1DEFB777764A9DFC2E7BCEEEE355@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbafe306-e1d5-44b2-fc7c-08da13f0f4e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 15:04:44.7110
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Q34bJ7kQNwilWvkd8qxAdXkN3bYyxOEzXqVb8V8ixMTtxtGIYQCoob7bdkJc6fGZYYA7vRC1u+97X63iCXoH0lfp4dfQh4VJjkzWC3qcEag=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2158
X-OriginatorOrg: citrix.com

T24gMDEvMDQvMjAyMiAxNTo1MCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IE9uIEZyaSwgQXBy
IDAxLCAyMDIyIGF0IDA0OjM3OjE4UE0gKzAyMDAsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4+
IFNldHRpbmcgdGhlIGZjZi1wcm90ZWN0aW9uPW5vbmUgb3B0aW9uIGluIEVNQkVEREVEX0VYVFJB
X0NGTEFHUyBpbiB0aGUNCj4+IE1ha2VmaWxlIGRvZXNuJ3QgZ2V0IGl0IHByb3BhZ2F0ZWQgdG8g
dGhlIHN1YmRpcmVjdG9yaWVzLCBzbyBpbnN0ZWFkDQo+PiBzZXQgdGhlIGZsYWcgaW4gZmlybXdh
cmUvUnVsZXMubWssIGxpa2UgaXQncyBkb25lIGZvciBvdGhlciBjb21waWxlcg0KPj4gZmxhZ3Mu
DQo+Pg0KPj4gRml4ZXM6IDM2NjdmN2Y4ZjcgKCd4ODY6IEludHJvZHVjZSBzdXBwb3J0IGZvciBD
RVQtSUJUJykNCj4+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPg0KPj4gLS0tDQo+PiAgdG9vbHMvZmlybXdhcmUvTWFrZWZpbGUgfCAyIC0tDQo+
PiAgdG9vbHMvZmlybXdhcmUvUnVsZXMubWsgfCAyICsrDQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCAy
IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xz
L2Zpcm13YXJlL01ha2VmaWxlIGIvdG9vbHMvZmlybXdhcmUvTWFrZWZpbGUNCj4+IGluZGV4IDUz
ZWQ0ZjE2MWUuLjM0NTAzN2I5M2IgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9maXJtd2FyZS9NYWtl
ZmlsZQ0KPj4gKysrIGIvdG9vbHMvZmlybXdhcmUvTWFrZWZpbGUNCj4+IEBAIC02LDggKzYsNiBA
QCBUQVJHRVQgICAgICA6PSBodm1sb2FkZXIvaHZtbG9hZGVyDQo+PiAgSU5TVF9ESVIgOj0gJChE
RVNURElSKSQoWEVORklSTVdBUkVESVIpDQo+PiAgREVCR19ESVIgOj0gJChERVNURElSKSQoREVC
VUdfRElSKSQoWEVORklSTVdBUkVESVIpDQo+PiAgDQo+PiAtRU1CRURERURfRVhUUkFfQ0ZMQUdT
ICs9IC1mY2YtcHJvdGVjdGlvbj1ub25lDQo+PiAtDQo+PiAgU1VCRElSUy15IDo9DQo+PiAgU1VC
RElSUy0kKENPTkZJR19PVk1GKSArPSBvdm1mLWRpcg0KPj4gIFNVQkRJUlMtJChDT05GSUdfU0VB
QklPUykgKz0gc2VhYmlvcy1kaXINCj4+IGRpZmYgLS1naXQgYS90b29scy9maXJtd2FyZS9SdWxl
cy5tayBiL3Rvb2xzL2Zpcm13YXJlL1J1bGVzLm1rDQo+PiBpbmRleCA5Zjc4YTdkZWM5Li5lZmJi
YzczYTQ1IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvZmlybXdhcmUvUnVsZXMubWsNCj4+ICsrKyBi
L3Rvb2xzL2Zpcm13YXJlL1J1bGVzLm1rDQo+PiBAQCAtMTMsNiArMTMsOCBAQCBlbmRpZg0KPj4g
IA0KPj4gIENGTEFHUyArPSAtV2Vycm9yDQo+PiAgDQo+PiArRU1CRURERURfRVhUUkFfQ0ZMQUdT
ICs9IC1mY2YtcHJvdGVjdGlvbj1ub25lDQo+PiArDQo+IEkgdGhpbmsgbWFraW5nIG1vZGlmaWNh
dGlvbiB0byAkKEVNQkVEREVEX0VYVFJBX0NGTEFHUykgb3V0c2lkZSBvZg0KPiAiQ29uZmlnLm1r
IiBpcyBjb25mdXNpbmcgYW5kIHdvdWxkIGJlIGJldHRlciBiZSBhdm9pZGVkLg0KDQpFTUJFRERF
RF9FWFRSQV9DRkxBR1MgaW4gdGhlIHJvb3QgQ29uZmlnLm1rIGlzIGNvbmNlcHR1YWxseSBicm9r
ZW4gYW5kDQpuZWVkcyBkZWxldGluZy4NCg0KWWVzLCB4ZW4vIGFuZCB0b29scy9maXJtd2FyZS8g
YXJlIGZyZWVzdGFuZGluZyBmcm9tIEMncyBwb2ludCBvZiB2aWV3LA0KYW5kIGVtYmVkZGVkIGZy
b20gbWFueSBwZW9wbGVzIHBvaW50cyBvZiB2aWV3LCBidXQgdGhpcyBkb2Vzbid0IG1lYW4NCnRo
ZXkgaGF2ZSBzaGFyZWQgYnVpbGQgcmVxdWlyZW1lbnRzLg0KDQotbm9waWUgaXNuJ3QgZXZlbiBh
IENGTEFHLsKgIEl0J3Mgc3BlbHQgLW5vLXBpZSBhbmQgaXMgYW4gTERGTEFHLsKgIFRoaXMNCmJ1
ZyBpcyBoaWRkZW4gYnkgZXZlcnl0aGluZyBiZWluZyBjYy1vcHRpb24nZCBiZWhpbmQgdGhlIHNj
ZW5lcy4NCg0KU3RhY2sgcHJvdGVjdG9yIHdlJ2QgYWJzb2x1dGVseSBoYXZlIGluIFhlbiBpZiBp
dCB3ZXJlbid0IGZvciBhIHF1aXJrIG9mDQpzdXBwb3J0aW5nIFBWIGd1ZXN0cy4NCg0KLWZuby1l
eGNlcHRpb25zIGlzIEMrKyBvbmx5IHNvIG5vdCByZWxldmFudCBmb3IgYW55dGhpbmcgaW4geGVu
LmdpdA0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 15:06:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 15:06:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297494.506816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIqg-0005ok-HN; Fri, 01 Apr 2022 15:06:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297494.506816; Fri, 01 Apr 2022 15:06:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naIqg-0005od-EF; Fri, 01 Apr 2022 15:06:02 +0000
Received: by outflank-mailman (input) for mailman id 297494;
 Fri, 01 Apr 2022 15:06:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwaM=UL=citrix.com=prvs=08375ea47=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1naIqf-0005oV-9K
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 15:06:01 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c5d0cdf-b1cd-11ec-8fbc-03012f2f19d4;
 Fri, 01 Apr 2022 17:06:00 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c5d0cdf-b1cd-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648825559;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=IcDh3n48SXGCltswn2QBP5U/83++9ulLmrd9BrfHZsE=;
  b=hZn4cigzoRIBPTQwiVrRKl2TOIPo6VsdCNAAwc0gHR0gFJQhTJrqoTYn
   d6gLSJypl9IPaVm2HR15NdKzG6q/+Uf8sr+AmXd1l/1s9/rwAtZ8MSDzi
   MLAu40sCobnt3mO0AS1Ffh6GXTJiay7TsAy0vnIIw3NNe9Bo12HpbdaZz
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67209521
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aO2tcKwBtUgdHvMJrEt6t+clxirEfRIJ4+MujC+fZmUNrF6WrkVWn
 WEbXWrQPKqJajGgKo0gYYi190xXsMfXx95hTwE5/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YHhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplqrOzSiwoN7f126dFYUZcEBsjLLZW5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 JBBOGc1NXwsZTVoP3tOEYIDwNypn2O4WjsCuHXLirootj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKhMQOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO/IV6wKmy6PO2kXaXlpbSj17Nc09pNBjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WvQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW
 lBexKByC8hUUfmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehs5bZteI2e4M
 RKO0e+02HO1FCH1BUOQS9jsY/nGMIC6TYi1PhwqRoQmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU
 ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or
 b6y9qKiln1ibQEJSnKJqdRKdwBbcCBT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5
 XazRglTz1+XuJENAVnihqxLAF83YatCkA==
IronPort-HdrOrdr: A9a23:6r9PCqiIhfG073qDkmQGB50VIHBQX3p13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3IwerwRJVpQRvnhPpICRF4B8btYOCUghrWEGgE1/qi/9SAIVywygc578
 ZdmsdFeaXN5DRB/KTHCUyDYqsdKbq8geCVbIXlvgxQpGhRAskKhWoYe2Wm+w9NNXN77PICZc
 ChD6F81l2dkAEsH72G7w4+Lo7+TrPw5ffbSC9DIyRixBiFjDuu5rK/OQOfxA0iXzRGxqpn2X
 TZkiTij5/T8M2T+1v57Sv+/p5WkNzuxp9oH8qXkPUYLT3ql0KBeJlhYbufpzo4ydvfqmrC0e
 O85ivIDf4DrE85TVvF5ycFHDOQiQrG3kWSjWNwR0GT+fARCghKUPapzrgpDCcxo3BQze2Ulp
 g7gl5x/qAnfi8p1k7Glqj1fgAvmUyurXU4l+kPy3RZTIsFcbdU6ZcS5UVPDf47bWjHAa0cYa
 FT5fvnlb1rmJKhHgfkl3gqxMbpUmU4Hx+ATERHssuJ0yJOlHQ8y0cD3sQQknoJ6Zp4EvB/lq
 j5G7UtkKsLQt4dbKp7CutEScyrCnbVSRaJNG6JO1zoGKwOJnqIoZ/q57c+4v2sZfUzvdYPsY
 WEVEkduX85ekroB8HL1JpX8grVSGH4RjjpwtE23ekxhlQ9fsucDcSuciFaryL7mYRsPiTyYY
 fGBK5r
X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; 
   d="scan'208";a="67209521"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YzQTyeVIDG5dvI0U3bknoCXW//xuXhQZBmCQG+xbQszC38g4HRrjHv8iL3E5LBOkVZq96FKwfe52UcT7cOvRrhgxuVo7txc90Q3Y/f7U3Txw1oMwPU8/mLAlpXATWD8yI/9dNfyF+Y/A2qHbJyyoZEdOLoTVPcmagVDZfE74vjc1oIe4XsCq1TBcZ9t6sMUBwIudBdCTkFxuOx59Auuibcxz6TzK8PnK8FXd/obEofHcgr2UHr0iLXFzcJkJsPNFHebLh60JLmZXpvPayfddEewCNdmcer9GuW+B4xLRu6hLZiGstc/TyODWE/CoRgbS3LzQg9o15o2Zz5CmUK8agg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IcDh3n48SXGCltswn2QBP5U/83++9ulLmrd9BrfHZsE=;
 b=AB8FOS3aYsTAdRuh++MqRmQpo4Ezlm8J7Xq2yGTOj7xhm48WZS2jWRtTfDEomn4yY/2g8KbpYkAoJRm/bkAU/0qBLaacdfwFo6ukoJ/bDHRSG6YeNadAaiz/M8ZgxbK8KaAvGCUPRDRJ5scTuTZS3ZXHXi+Xwq29nHeZnR3iO7z9o1kIZfbpChr9cwzvWWR0oy8+AQesEo+XmTOKp5vqN322YeYESVIIg6di0NS33xxEO5sRLBAOypd2rceZ1DKvrp7iVC3eNYN4rEHjdOnfPM99nF0uyVSHC+jiRNaPuN/+lCYQTzoLrR6eSwtnkGgdQ5PsCnCp3MdsOBqCutMbvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IcDh3n48SXGCltswn2QBP5U/83++9ulLmrd9BrfHZsE=;
 b=IkWqhUMbPnwetS4aNILxKd+PC8T9m3HHzypaXoUejK9FV5N/cos3Y1NqXRp5Px2qjG/tChEcPtOFk2cSh4iPXovbcTOeIjIPCRfUiBc0DbGPprmm5apxtHULndvvE+u7wr3C1cDhCmNQn+F0X328a2ZcIZ5SXfAhtg2UIob7t0s=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Topic: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Index: AQHYRdaC1Ty1lDbR3E6vxjqdlx39GKzbI4SAgAAExYA=
Date: Fri, 1 Apr 2022 15:05:54 +0000
Message-ID: <ed31e78b-087e-869b-8aa0-5d5d0f3183fd@citrix.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
 <e20b3d17-0c2a-b23f-d949-667072a54f58@citrix.com>
In-Reply-To: <e20b3d17-0c2a-b23f-d949-667072a54f58@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 64118aef-3221-410e-3355-08da13f11e5a
x-ms-traffictypediagnostic: SN2PR03MB2158:EE_
x-microsoft-antispam-prvs: <SN2PR03MB2158EE69B6E6AB4C715673BBBAE09@SN2PR03MB2158.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: h44GkBkNQl50vvC0u2+4v5OuhIQUGj5h0JrqCPzg7f9J2D57/YmEfY+WWG8Mn5uZStOzueyg95adaspv2wIf0AEsAZsrwZPO1jkMHpfMXR7WxKacUbCaT7xxr328iNjQ/6yXJK6mgWlCbFFrn+0MKX5rPsckajgl086r3WCkIezYW32yQ5+pV5ilXjbfNSEnKHD0rXvC77DDcfmTEss2J2bj8ucn7MtgIx5ljJacT1Kp8eikHRysD14ZbXNFJHYie5C97L6dlmiz6J790mAuXq0VUID7J3RHgdic4YbWUY1ZCIGI9hYPSma5t/v6T1kIniRyKsmGlzFlX36woJjJCtMGI4B05lqYM4VS6GnwxBQLV0pEGOPB3bSFQg9MyrYg5QcY6ZUMbD0Ie10FU3t6mwDwzgapN127yslem+RFUWMYYsMMwO+YX5B9uOmwsyeHJV2TdTi3XmKkcG+XOQOpmSb9hi82Rq9hVrbUKH3gMCEK6U3kHxZ/MZMG8SRR8yMwQFeVpOZKMpbcyeI7IMknrNxixRHxltuPW/bC+OUvtw1rSnzgiDbnDNRqeJF6racYABeUOeCB66WoiT7DM7tvCDA4X2DUZjH6z+GqB7N7giPAJWCOhFN7S44Dleb622a5n1O6mhJjw1wpoOALgEKOtSE53/uec7mqPJmgSKgdsAXlL58LjH0GibuxuU/+mTE3C0qXM6j41HAPAK0tnl34SfqHufHJzr/LMyMdcAwJkevrolMYfU+XgGja9w84vQ3rPaD9c3BgaWntC4BeOxDaag==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(8936002)(5660300002)(82960400001)(86362001)(508600001)(31696002)(31686004)(76116006)(6486002)(55236004)(66946007)(53546011)(91956017)(64756008)(6506007)(4326008)(8676002)(38100700002)(66446008)(66556008)(110136005)(6512007)(54906003)(66476007)(316002)(2616005)(107886003)(26005)(186003)(36756003)(122000001)(4744005)(2906002)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ODg5dWsvMkFCYXBMd3RRZG56Tks1VHdTVUFLaUlNaWhQN1NrNjRrSHdxSzZ1?=
 =?utf-8?B?V3FJSTU3d2pBeHBMaDBXS2puMXBxWTNLZzRJbTV0aEw4NVN1YW1ERmJZNWtr?=
 =?utf-8?B?K2FnQVFjcmNlWk1tQ1RsTkw1V2p4UGZQSjVKcUVzdTlNVmk5NWVnOG9Vc2hv?=
 =?utf-8?B?eHVOM2xNcWFBZFpub1NjRUJIMjArRXJ0Z3dZQ1ltV2pnTHRWdjhIUlhPWWFu?=
 =?utf-8?B?UmRyYUpJNFJPV2d2a2I4Mk9vT2RrMXFLaXp2YUVyZlZibFkzcDBLeWxYejA3?=
 =?utf-8?B?TDhvSmMvSEFGZ3ZsVG5ML0Z5WWhRVEpjUVd5ZDJKQnMzai9DRmFucmgrYjNq?=
 =?utf-8?B?dU0xK08zbG1OVXhQZlY0S05oa2hpelFHbXJLYVRPSUtyWWYrTGkyMGVKMXFG?=
 =?utf-8?B?ZVowVlA2eWxVZVN2QURZbmZEam5vck5TTnh4clNuSmNTUXJFbExGak4wODdS?=
 =?utf-8?B?Nll4RlBiYjNLM2NsWWdXb3dwVW8zUk84SHZUTGNzT281SmcvTzcxL1BVOWNO?=
 =?utf-8?B?ck5IdmtteTdIU1JqVzJIMFVWSHA2ZXJhaEVsV1dGc1VwRlRYT05TZ3M5RXF1?=
 =?utf-8?B?MlhGL2l0K2xtL2RWT1NxS2FnczFqNXNaaTJIamc2bEdvRHNDd2d5c0YwT21K?=
 =?utf-8?B?UWx1c256YUNHclJ6eHZQcDMvbnpZMHlibUdxeHEvUGZhOE9hUjlKL0FSMHZN?=
 =?utf-8?B?bU83a3hydmlRbjFpWE1iY1hnWUc0em4vUjRVdzl3T2N5UHZtWWhQMS94ak5k?=
 =?utf-8?B?WjY4WWpKK0lJc3UzbFVPRGhPL0NuRFc0VElqblNVd2IyUjhZMEpqVm5rTjA3?=
 =?utf-8?B?a0xjNmhLVWErSEZXZ3NJazdXTWIxYjhoc1FhWUdLTmg5VTNFY3dnTWhqL3Za?=
 =?utf-8?B?Mmxva1pZMXM3YXpCeWthdE51SXpZZDV4L3NKR0pramFQUkdhNUN1cU9EMlI0?=
 =?utf-8?B?U1poZlF6c3A4ZnRjcFhsazFoYVdDMlhjT0svaWd6aWlWS2h3QjEvcHhkVVV2?=
 =?utf-8?B?M2h1OGRUT2V6NkMrRkg5T0hsWlhQQS9ZWDU5TGFGV2xKcmpzaEJFZEh0SjFR?=
 =?utf-8?B?YXlHa2xLZjdaRUx5WUt1cTRiempodUhWNzkrNTMreHZ2b1IraVNZVGtoRy9q?=
 =?utf-8?B?emkzVStiWnU5NGlLbWUyQU10VGs1L294MUhnV3RJZGZDWmZoS3ZRSi9zSjJ6?=
 =?utf-8?B?TVR6THlKR29FMW5wbHJMaWZ4aFZSQ1RITUowMkZaK05Pbnh5SGEzM2Q2VGFS?=
 =?utf-8?B?ZUpzZW93S25HRkhmYnhoODFJQUhZKzBycnVtUW10ZVFuT3pzUFdNMElGUHBr?=
 =?utf-8?B?M2lDcmRNUHZMU2o5eFhnVXljdkRGaStVc1Q0U1Q0SEtVa2VwQ0lyNUhaMDJj?=
 =?utf-8?B?ZU90RVlWYWNIYnpKQVlGWWVkaVpvOUx5dFdKMjdqNHg1eHVRR3l1aFdmc2Ur?=
 =?utf-8?B?RnVWNmVUQUJvUmZrWUd4RTFpYWQ5MlNrKzBLeXF3ZzlRS0MxVVpzOXVhTjZK?=
 =?utf-8?B?ZUkvWGJnd3l6elNMRHlXdmlVL3hQODRmZEpSWDNtMzUvS2w1aTIyWC81b01D?=
 =?utf-8?B?dDhlL0lSak95alVURkpuMm83Sy9pejlsRktyYTA2bXg4MHVsd0ExV2NEclRQ?=
 =?utf-8?B?WEs3U2g2VGdhcG5mTkFyM205Q2QwSkN4SjVLSDhMTk5ZT0hlZThBbHpOcExa?=
 =?utf-8?B?TEhVOHU3MmxBMEkrUHRLZzF2aUtnOWlteCt0Q1JzVlhNUU80TzRDVUFZSTNL?=
 =?utf-8?B?RUZPTFpmNHFSaFVCZmoxYkpGK1IzYWVvdTRYdlNmU0w0dm83a29neTVQOC9m?=
 =?utf-8?B?TjFPS1hVSDFPdk1YVUFaUmVRYTlNeGFZTmdFSytRYnpMeXhwc0VSbEoydDgv?=
 =?utf-8?B?a3Q4VlI3NWRjQWtmMyswd3g1Sm5ZL01sVUZMTnNQUnJrcEtlT291dnpic1NF?=
 =?utf-8?B?dGx3S1Fnb2hESi9XMlhmWTBQK0hCV2syZUVLNzkrZ0ZkTkY4OTZHRmQ4RVdl?=
 =?utf-8?B?VjZaTnE1U2t0UG4xSnVKaFgrNTAxU3dCa1hkK1NBTGNpeS9QM0NUYkUxS2RU?=
 =?utf-8?B?U3A5WDg0SzdzeEpUSFhuK0VESXdmcGJBd1gzOVhHa3g2QXR6dE1DZTJlZTVi?=
 =?utf-8?B?c3RkclNGa25jcDV2MHZNWTNyL0wwWWtGdDB1TStaczdCbllGekpDWWN2YXhz?=
 =?utf-8?B?b2YvRk9vbmVQa2NqdUxQV2taVlF3RXJlRWpXTWYwNUc5aHR0TFQxWTNWdU5k?=
 =?utf-8?B?bVM0eUhEaFpxTm9TSmpPUlBYd09rZXpYNUZxVXVPaEFHWkRiblFpYnFpREZV?=
 =?utf-8?B?dVlLR0d6UFROOGRxM0cxS25zZnJSRXQ0REgwRCtkeE40WVhMYTR4UT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7189EE020F33414B9EC8ADCEC0CA1AEF@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64118aef-3221-410e-3355-08da13f11e5a
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 15:05:54.2526
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2cTBjdNodnMp5hCEfvDD4dlb/BGJ8FhEdVr7oPbBUUFfdkI3mjJQnJE+h41d/gAR4YBx/kkDCxDC1W01WJZwUKInVIFNj0IhcLnFIHbb/f0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2158
X-OriginatorOrg: citrix.com

T24gMDEvMDQvMjAyMiAxNTo0OCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMDEvMDQvMjAy
MiAxNTozNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPj4gU2V0dGluZyB0aGUgZmNmLXByb3Rl
Y3Rpb249bm9uZSBvcHRpb24gaW4gRU1CRURERURfRVhUUkFfQ0ZMQUdTIGluIHRoZQ0KPj4gTWFr
ZWZpbGUgZG9lc24ndCBnZXQgaXQgcHJvcGFnYXRlZCB0byB0aGUgc3ViZGlyZWN0b3JpZXMsIHNv
IGluc3RlYWQNCj4+IHNldCB0aGUgZmxhZyBpbiBmaXJtd2FyZS9SdWxlcy5taywgbGlrZSBpdCdz
IGRvbmUgZm9yIG90aGVyIGNvbXBpbGVyDQo+PiBmbGFncy4NCj4+DQo+PiBGaXhlczogMzY2N2Y3
ZjhmNyAoJ3g4NjogSW50cm9kdWNlIHN1cHBvcnQgZm9yIENFVC1JQlQnKQ0KPj4gU2lnbmVkLW9m
Zi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IEFja2VkLWJ5
OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpUaGlzIGFsc28g
bmVlZHMgYmFja3BvcnRpbmcgd2l0aCB0aGUgWFNBLTM5OCBDRVQtSUJUIGZpeGVzLg0KDQp+QW5k
cmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 15:21:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 15:21:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297502.506828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naJ5s-0008E0-2F; Fri, 01 Apr 2022 15:21:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297502.506828; Fri, 01 Apr 2022 15:21:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naJ5r-0008Dt-V9; Fri, 01 Apr 2022 15:21:43 +0000
Received: by outflank-mailman (input) for mailman id 297502;
 Fri, 01 Apr 2022 15:21:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tDTg=UL=citrix.com=prvs=083321efb=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1naJ5r-0008Dn-1g
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 15:21:43 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6dd8df26-b1cf-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 17:21:41 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6dd8df26-b1cf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1648826501;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=4GWclumcHhI4jgI+hP2WW5OXUqt9VzxoV9aUpHEXJYo=;
  b=Hm1ByJE8MaukWzShFRAWuulg7bIjeR+Jz7Ki7z7DScwiHg1CU1I1Jkis
   B4O6+f3R9au7fOeeITZPY3DgSLYd/F3LZYwRZ8/AtCVIYfLqrsfHSbHu5
   xJDELlLhc9act/WPV493k+LehDwp0E+5oyw0SdV1WcQuHot9TX5BjHuUr
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67678090
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:r+kkkai79ZZCMjgikXUoh724X161CBAKZh0ujC45NGQN5FlHY01je
 htvXWCHPfaKYmP1Ltpwao6x9xsH6p+AzdZmHQs/rX1mRHsb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vU4
 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQc5O/aUwe8faURVDXtQPKtv8e/7AWfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i
 88xN2UxM0SYMkUn1lE/LJU4rcykpSXFUAJq9VnMv44t6Ffz5VkkuFTqGIWMIYHbLSlPpW6Ho
 krW8mK/BQsVXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+aLegiaDn0AjkAYsZc
 hFKvHp1xUQvyKC1ZtntWkbg+XWGhEMRRYB+EusT4VGx6rWBtm51GVM4ZjJGbdUnsuo/Sjory
 kKFkrvVONB/jFGGYSnDr+nJ9FteLQBQdDZfPnFcEWPp9vG5+OkOYgTzosGP+UJfpvn8AnnOz
 j+Dt0DSbJ1D3JdQh81XEb0q6g9AR6QlrCZovm07vUr/t2uVgbJJgaTytjA3Ct4acO6koqGp5
 iRspiRnxLlm4WuxvCKMWv4RO7qi+uyINjbR6XY2QcVxqGn3oSbyLN0NiN2bGKuPGpxbEdMOS
 BWO0T69GbcJZCf6BUOJS9zZ5zsWIVjISo2+C6G8gitmaZltbg6XlByClmbLt10BZHMEyPllU
 b/CKJ7EJS9DVcxPkWrnL89AgORD7n1vmgvuqWXTkk3PPUy2PyXOF9/o8TKmM4gE0U9ziF6Lq
 4wGbZvblk03vS+XSnC/zLP/5GsidRATba0aYeQOHgJfCmKKwF0cNsI=
IronPort-HdrOrdr: A9a23:uzpfXq1pXznMzD6MBM8MmAqjBLAkLtp133Aq2lEZdPRUGvb4qy
 mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5
 uIG5IOceEYZmIbsS+V2meFL+o=
X-IronPort-AV: E=Sophos;i="5.90,228,1643691600"; 
   d="scan'208";a="67678090"
Date: Fri, 1 Apr 2022 16:21:35 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Message-ID: <YkcYf8fJTl+X0JRv@perard.uk.xensource.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
 <YkcRGIy7l48BkZQz@perard.uk.xensource.com>
 <7b129a01-07c7-e856-fb5b-0c7b44a8dac5@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <7b129a01-07c7-e856-fb5b-0c7b44a8dac5@citrix.com>

On Fri, Apr 01, 2022 at 03:04:44PM +0000, Andrew Cooper wrote:
> On 01/04/2022 15:50, Anthony PERARD wrote:
> > On Fri, Apr 01, 2022 at 04:37:18PM +0200, Roger Pau Monne wrote:
> >> +EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
> >> +
> > I think making modification to $(EMBEDDED_EXTRA_CFLAGS) outside of
> > "Config.mk" is confusing and would be better be avoided.
> 
> EMBEDDED_EXTRA_CFLAGS in the root Config.mk is conceptually broken and
> needs deleting.

I'm asking to remove "-fcf-protection=none" from the broken variable
EMBEDDED_EXTRA_CFLAGS, and instead only modify the CFLAGS variable of
"tools/firmware/".

As this patch show, making modification to EMBEDDED_EXTRA_CFLAGS outside
of Config.mk doesn't work because changes doesn't propagate.

So the modification I've ask for the patch goes toward deleting
EMBEDDED_EXTRA_CFLAGS, like you want.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 15:57:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 15:57:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297507.506838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naJef-00036f-UK; Fri, 01 Apr 2022 15:57:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297507.506838; Fri, 01 Apr 2022 15:57:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naJef-00036Y-RL; Fri, 01 Apr 2022 15:57:41 +0000
Received: by outflank-mailman (input) for mailman id 297507;
 Fri, 01 Apr 2022 15:57:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naJee-00036O-Of; Fri, 01 Apr 2022 15:57:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naJee-000075-Ic; Fri, 01 Apr 2022 15:57:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naJee-0004Zl-2h; Fri, 01 Apr 2022 15:57:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naJee-0002eT-1d; Fri, 01 Apr 2022 15:57:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rZgPA/mi+OWoRws/akM1JQ0zDM2XZhTWaqfxGbBExOA=; b=FysSt2wl3bTK3Bjk0ryWC0kZnk
	v3IgklECywreJRUAgzH8HjMtfB4DZtxqNBuVZwC3GvFBYJ+qTd8QYtTATrfwb6qvVpXMsNRCWsu2M
	nmoH/MdyC1Kw/RbAH6OKTEm360rq7Q5bmRJFKwfpVfChh9s9qD1rPu1GbQcBa8a9ZAjM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169074-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169074: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
X-Osstest-Versions-That:
    xen=ca304edd3ba8c19211107fd2e898249987557ce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 15:57:40 +0000

flight 169074 xen-4.14-testing real [real]
flight 169111 xen-4.14-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169074/
http://logs.test-lab.xenproject.org/osstest/logs/169111/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168506
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168506

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168506
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
baseline version:
 xen                  ca304edd3ba8c19211107fd2e898249987557ce5

Last test of basis   168506  2022-03-10 14:16:31 Z   22 days
Failing since        168862  2022-03-25 17:36:39 Z    6 days    8 attempts
Testing same since   168957  2022-03-28 21:36:20 Z    3 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 17:32:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 17:32:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297519.506864 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naL81-0004mL-Ux; Fri, 01 Apr 2022 17:32:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297519.506864; Fri, 01 Apr 2022 17:32:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naL81-0004mD-S5; Fri, 01 Apr 2022 17:32:05 +0000
Received: by outflank-mailman (input) for mailman id 297519;
 Fri, 01 Apr 2022 17:32:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naL80-0004m7-GD
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 17:32:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naL80-0002Ft-5M; Fri, 01 Apr 2022 17:32:04 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naL7z-0007p0-VE; Fri, 01 Apr 2022 17:32:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=QoeQJOExzOo1hSC278ThZyceHducjHLk0r4doA9WHPM=; b=AG06VIftBQUM4lEO6YiFgW+HWq
	piYwYyks7m6SLubGYlsZjA0W0J9aE+BBhWD4R+61YJpI25zyqN1vAGuBNZyAo61WOiDZ3SLfuXLeC
	KEdocti5Xc5YEAtpL+98mbFYoDFEtZhwYxQDTE5JfOg00sLj7m2O0bhKXHTTiDZh5TJo=;
Message-ID: <2a287b59-9ff2-6bd0-fa42-d95333fc1554@xen.org>
Date: Fri, 1 Apr 2022 18:32:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v12] xen/arm64: io: Handle data abort due to cache
 maintenance instructions
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>
References: <20220324133705.37882-1-ayankuma@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220324133705.37882-1-ayankuma@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 24/03/2022 13:37, Ayan Kumar Halder wrote:
>       /*
>        * At this point, we know that the instruction is either valid or has been
>        * decoded successfully. Thus, Xen should be allowed to execute the
> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
> index 54167aebcb..87a6240f2a 100644
> --- a/xen/arch/arm/ioreq.c
> +++ b/xen/arch/arm/ioreq.c
> @@ -47,7 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>                                struct vcpu *v, mmio_info_t *info)
>   {
>       struct vcpu_io *vio = &v->io;
> -    struct instr_details instr = info->dabt_instr;
> +    const struct instr_details instr = info->dabt_instr;
>       struct hsr_dabt dabt = info->dabt;
>       ioreq_t p = {
>           .type = IOREQ_TYPE_COPY,
> @@ -62,7 +62,6 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>            * memory access. So for now, we can safely always set to 0.
>            */
>           .df = 0,
> -        .data = get_user_reg(regs, info->dabt.reg),
>           .state = STATE_IOREQ_READY,
>       };
>       struct ioreq_server *s = NULL;
> @@ -74,12 +73,23 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>           return IO_ABORT;
>       }
>   
> +    if ( instr.state == INSTR_CACHE )
> +        p.size = dcache_line_bytes;
I think it would be best to only set the p.size when instr.state != 
INSTR_CACHE in the else here.

I can do that on commit. I will also give a chance to Stefano to reply.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 17:36:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 17:36:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297524.506874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLCG-0005TI-Kh; Fri, 01 Apr 2022 17:36:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297524.506874; Fri, 01 Apr 2022 17:36:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLCG-0005TB-Hr; Fri, 01 Apr 2022 17:36:28 +0000
Received: by outflank-mailman (input) for mailman id 297524;
 Fri, 01 Apr 2022 17:36:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naLCF-0005T5-QU
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 17:36:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLCF-0002Iy-F6; Fri, 01 Apr 2022 17:36:27 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLCF-0008HY-9F; Fri, 01 Apr 2022 17:36:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=YSBiLUeQsxFk/gSWE7D7F17hwcOAVb0byVQKts+4Xwk=; b=UI0ZRs+D7S4Shav0Q9JvLFMFBU
	RVM9z81n1/knPZHMv5CuvDXZQPLeZ7wU7emS8LUgp2rEhfMWGutW1GoSHzFYJHJENi/bg0BAgX6Bg
	ur7mHV5USGbfiX4+cNTfhdiCUoBb6uFb9hwTvHGzlQ/OC0S1DXg31n5VygLxzJWMoTpY=;
Message-ID: <ce203dce-bb00-4eeb-d0ab-5c407c070a79@xen.org>
Date: Fri, 1 Apr 2022 18:36:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v4 3/9] xen/arm: temporarily elevate idle_domain
 privileged during create_domUs
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-3-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220401003847.38393-3-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 01/04/2022 01:38, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> create_domUs might call functions that perform XSM checks on the current
> domain, which is idle_domain at this time. Temporarily elevate
> idle_domain privileges in create_domUs.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> ---
>   xen/arch/arm/domain_build.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index b6189b935d..100a4959a8 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -27,6 +27,7 @@
>   #include <asm/setup.h>
>   #include <asm/cpufeature.h>
>   #include <asm/domain_build.h>
> +#include <xsm/xsm.h>
>   
>   #include <xen/irq.h>
>   #include <xen/grant_table.h>
> @@ -3210,6 +3211,8 @@ void __init create_domUs(void)
>       struct dt_device_node *node;
>       const struct dt_device_node *chosen = dt_find_node_by_path("/chosen");
>   
> +    xsm_elevate_priv(current->domain);

Please check the return of this function and...

> +
>       BUG_ON(chosen == NULL);
>       dt_for_each_child_node(chosen, node)
>       {
> @@ -3291,6 +3294,8 @@ void __init create_domUs(void)
>           if ( construct_domU(d, node) != 0 )
>               panic("Could not set up domain %s\n", dt_node_name(node));
>       }
> +
> +    xsm_demote_priv(current->domain);

... this. For us, it should hopefully be 0. But it is a good practice to 
confirm.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 17:47:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 17:47:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297528.506886 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLMX-0006xG-KZ; Fri, 01 Apr 2022 17:47:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297528.506886; Fri, 01 Apr 2022 17:47:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLMX-0006x9-HU; Fri, 01 Apr 2022 17:47:05 +0000
Received: by outflank-mailman (input) for mailman id 297528;
 Fri, 01 Apr 2022 17:47:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naLMW-0006wz-3f; Fri, 01 Apr 2022 17:47:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naLMV-0002W3-Vk; Fri, 01 Apr 2022 17:47:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naLMV-0001To-HJ; Fri, 01 Apr 2022 17:47:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naLMV-0001Vy-Gq; Fri, 01 Apr 2022 17:47:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BfjDmjSJ6L7Hh1uELIwsHCajtv10DKtMS08AmdqK3/0=; b=Qr44p2eT3CJdaIS60dHFJJLaRT
	Fk7ZcSgDv/JE2tPp2y0HzqgPwpUHRKdwIbH0Ca4FUYgzDCNPOt2tJtLyyn4EJq0hJlr+kc6noyERD
	VonTVJpQxFCDUaCkqXDNWe2W2FlwABwZmj1mzuBtCxz4OvGr3jamVzQQerHbvDSl4l2s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169079-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169079: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
X-Osstest-Versions-That:
    xen=cd751c09a5bab9f3529901fbe4d867ad7d52e89d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 17:47:03 +0000

flight 169079 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169079/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168502
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168502

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 169040 pass in 169079
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 169040 pass in 169079
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 169040

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168502
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168502
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168502
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168502
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168502
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168502
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
baseline version:
 xen                  cd751c09a5bab9f3529901fbe4d867ad7d52e89d

Last test of basis   168502  2022-03-10 09:07:57 Z   22 days
Failing since        168863  2022-03-25 17:36:55 Z    7 days    8 attempts
Testing same since   168970  2022-03-29 04:19:26 Z    3 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 17:52:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 17:52:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297536.506897 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLS8-0008OZ-Au; Fri, 01 Apr 2022 17:52:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297536.506897; Fri, 01 Apr 2022 17:52:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLS8-0008OS-7l; Fri, 01 Apr 2022 17:52:52 +0000
Received: by outflank-mailman (input) for mailman id 297536;
 Fri, 01 Apr 2022 17:52:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naLS6-0008OM-Eu
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 17:52:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLS4-0002b8-Ha; Fri, 01 Apr 2022 17:52:48 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLS4-0000w0-AV; Fri, 01 Apr 2022 17:52:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=vaGXs0kXfTGq6WkbcoTe+cFWHmqM3O5xX2UMXuGPTUA=; b=yKlUNaMp1RcdZwB/N3NS8uiK53
	cqvB6FiQsjIAzSeId6nHwN/yCylop8iVQeHm81cdllVVhJ5UKcxNyXTEmJVI2M6r/AafXj/7UibkC
	6VRnhaKTYmMIquADfD8MneLH2j8UjONw8FAh2VKLyDx2hxPMiviq7/vPsCO2QrLbye5Y=;
Message-ID: <90fd48a1-446b-fb7d-a732-d2c1ede0921b@xen.org>
Date: Fri, 1 Apr 2022 18:52:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel@lists.xenproject.org, scott.davis@starlab.io,
 jandryuk@gmail.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YkWgXhFVq/fD72CB@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 31/03/2022 13:36, Roger Pau Monné wrote:
> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
>> There are now instances where internal hypervisor logic needs to make resource
>> allocation calls that are protected by XSM checks. The internal hypervisor logic
>> is represented a number of system domains which by designed are represented by
>> non-privileged struct domain instances. To enable these logic blocks to
>> function correctly but in a controlled manner, this commit introduces a pair
>> of privilege escalation and demotion functions that will make a system domain
>> privileged and then remove that privilege.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
>>   xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
> 
> I'm not sure this needs to be in xsm code, AFAICT it could live in a
> more generic file.
> 
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>> index e22d6160b5..157e57151e 100644
>> --- a/xen/include/xsm/xsm.h
>> +++ b/xen/include/xsm/xsm.h
>> @@ -189,6 +189,28 @@ struct xsm_operations {
>>   #endif
>>   };
>>   
>> +static always_inline int xsm_elevate_priv(struct domain *d)
> 
> I don't think it needs to be always_inline, using just inline would be
> fine IMO.
> 
> Also this needs to be __init.

Hmmm.... I thought adding __init on function defined in header was 
pointless. In particular, if the compiler decides to inline it.

In any case, I think it would be good to check that the system_state < 
SYS_state_active (could potentially be an ASSERT()) to prevent any misuse.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 17:53:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 17:53:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297540.506908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLT4-0000ZC-Qm; Fri, 01 Apr 2022 17:53:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297540.506908; Fri, 01 Apr 2022 17:53:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLT4-0000Z5-NL; Fri, 01 Apr 2022 17:53:50 +0000
Received: by outflank-mailman (input) for mailman id 297540;
 Fri, 01 Apr 2022 17:53:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naLT3-0000Yt-N1
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 17:53:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLT3-0002c7-54; Fri, 01 Apr 2022 17:53:49 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLT2-0000xm-VK; Fri, 01 Apr 2022 17:53:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Ie227fd6xRK/vVc6esJrm0lhmboy1+LECiAuDAW1Wwk=; b=1q1IcX+W+s1ot3MaalXQxTja9Q
	LuxeFkfeou5G8jxl7tQdJljNS4sjtn19ojuWglbPvCMHP8JgvJHSv3em8ftLXFDcildzBYwfNroTH
	mKbqAG08/GsE03Vcf6/e39nyRFZL7500iPNwd1MZ+A0e1jVKer/tjeb9wrPApKIN0GH4=;
Message-ID: <5c26e68b-8737-5f1c-9a03-c388a3d6e943@xen.org>
Date: Fri, 1 Apr 2022 18:53:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220330230549.26074-2-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Daniel,

On 31/03/2022 00:05, Daniel P. Smith wrote:
> There are now instances where internal hypervisor logic needs to make resource
> allocation calls that are protected by XSM checks. The internal hypervisor logic
> is represented a number of system domains which by designed are represented by
> non-privileged struct domain instances. To enable these logic blocks to
> function correctly but in a controlled manner, this commit introduces a pair
> of privilege escalation and demotion functions that will make a system domain
> privileged and then remove that privilege.
> 
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> ---
>   xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> index e22d6160b5..157e57151e 100644
> --- a/xen/include/xsm/xsm.h
> +++ b/xen/include/xsm/xsm.h
> @@ -189,6 +189,28 @@ struct xsm_operations {
>   #endif
>   };
>   
> +static always_inline int xsm_elevate_priv(struct domain *d)
> +{
> +    if ( is_system_domain(d) )
> +    {
> +        d->is_privileged = true;

The call for xsm_elevate_priv() cannot be nested. So I would suggest to 
check if d->is_privileged is already true and return -EBUSY in this case.

> +        return 0;
> +    }
> +
> +    return -EPERM;
> +}
> +
> +static always_inline int xsm_demote_priv(struct domain *d)
> +{
> +    if ( is_system_domain(d) )
> +    {
> +        d->is_privileged = false;
> +        return 0;
> +    }
> +
> +    return -EPERM;
> +}
> +
>   #ifdef CONFIG_XSM
>   
>   extern struct xsm_operations *xsm_ops;

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 18:02:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 18:02:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297545.506919 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLbo-0002AL-Mf; Fri, 01 Apr 2022 18:02:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297545.506919; Fri, 01 Apr 2022 18:02:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLbo-0002AE-Jg; Fri, 01 Apr 2022 18:02:52 +0000
Received: by outflank-mailman (input) for mailman id 297545;
 Fri, 01 Apr 2022 18:02:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naLbn-0002A8-AU
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 18:02:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLbm-0002s9-RY; Fri, 01 Apr 2022 18:02:50 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLbm-0001gU-KQ; Fri, 01 Apr 2022 18:02:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=A2qKnio56Kh0Cei+yc26F/VENUTia4qA/EmZ65l/MRA=; b=Ub18kQa8qEnnW2wUksnQGAAjqc
	jBJIRIB8m/QXV1X2pw84aaxNE7gdubqzNvrkxoSDykvrqM4vlANZ91Qr8ARe4IY/9Lj5x7MzhvNu1
	gdaI7o54ONlgYtvQWcEclF+p0ISLuIgmH9ijpPUR6G42NVu9OVu02Yw+CG8l00JTPLTk=;
Message-ID: <522e8c28-6be7-a073-ab8e-0259b68183f1@xen.org>
Date: Fri, 1 Apr 2022 19:02:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v1 1/5] xen/arm: field "flags" to cover all internal
 CDF_XXX
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, henry.wang@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220330093617.3870589-1-Penny.Zheng@arm.com>
 <20220330093617.3870589-2-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220330093617.3870589-2-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 30/03/2022 10:36, Penny Zheng wrote:
> With more and more CDF_xxx internal flags in and to save the space, this
> commit introduces a new field "flags" to store CDF_* internal flags
> directly.
> 
> Another new CDF_xxx will be introduced in the next patch.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   xen/arch/arm/domain.c             | 3 ++-
>   xen/arch/arm/include/asm/domain.h | 5 +++--
>   2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 8110c1df86..35c157d499 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -709,7 +709,8 @@ int arch_domain_create(struct domain *d,
>       ioreq_domain_init(d);
>   #endif
>   
> -    d->arch.directmap = flags & CDF_directmap;
> +    /* Holding CDF_* internal flags. */
> +    d->arch.flags = flags;
>   
>       /* p2m_init relies on some value initialized by the IOMMU subsystem */
>       if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index ed63c2b6f9..95fef29111 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -29,7 +29,7 @@ enum domain_type {
>   #define is_64bit_domain(d) (0)
>   #endif
>   
> -#define is_domain_direct_mapped(d) (d)->arch.directmap
> +#define is_domain_direct_mapped(d) (((d)->arch.flags) & CDF_directmap)

The () around (d)->arch.flags are not necessary.

>   
>   /*
>    * Is the domain using the host memory layout?
> @@ -103,7 +103,8 @@ struct arch_domain
>       void *tee;
>   #endif
>   
> -    bool directmap;
> +    /* Holding CDF_* constant. Internal flags for domain creation. */
> +    uint32_t flags;

I think this wants to live in the struct domain. So other arch can take 
advantage of it in the future.

>   }  __cacheline_aligned;
>   
>   struct arch_vcpu

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 18:06:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 18:06:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297549.506929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLfa-0002nK-6Y; Fri, 01 Apr 2022 18:06:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297549.506929; Fri, 01 Apr 2022 18:06:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLfa-0002nD-3d; Fri, 01 Apr 2022 18:06:46 +0000
Received: by outflank-mailman (input) for mailman id 297549;
 Fri, 01 Apr 2022 18:06:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naLfZ-0002n7-1i
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 18:06:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLfY-0002vD-Ju; Fri, 01 Apr 2022 18:06:44 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLfY-0001tl-Du; Fri, 01 Apr 2022 18:06:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=e8VIyunfzKnDjly8t32ZY1qEMPOpv4mVUPzhkHGNwFw=; b=wcWvZSlqkOzdQ2J0UhTZai/OoO
	FgWT1/3UmfuQ26j/22xJaArxGyBYw+8RLjTyJiEh5Oha21t5Osj7EcN4OaJpD1B4rZ/PsBs+cT/J3
	Yc4B8c/bTbtnW6eRcgyKL725JLhj32oRLBPnUC0MMyPGHMxdKurq1a+iPk7vnWQwql90=;
Message-ID: <d6198097-6d4a-2dae-01de-4de0186c97f3@xen.org>
Date: Fri, 1 Apr 2022 19:06:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v1 2/5] xen/arm: introduce CDF_staticmem
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, henry.wang@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <20220330093617.3870589-1-Penny.Zheng@arm.com>
 <20220330093617.3870589-3-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220330093617.3870589-3-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 30/03/2022 10:36, Penny Zheng wrote:
> In order to have an easy and quick way to find out whether this domain is
> on static allocation, this commit introduces a new flag CDF_staticmem and a
> new helper is_domain_on_static_allocation.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   xen/arch/arm/domain_build.c       | 5 ++++-
>   xen/arch/arm/include/asm/domain.h | 2 ++
>   xen/include/xen/domain.h          | 2 ++
>   3 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 8be01678de..4e62fd0bf1 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3191,9 +3191,12 @@ void __init create_domUs(void)
>           if ( !dt_device_is_compatible(node, "xen,domain") )
>               continue;
>   
> +        if ( dt_find_property(node, "xen,static-mem", NULL) )
> +            flags |= CDF_staticmem;
> +
>           if ( dt_property_read_bool(node, "direct-map") )
>           {
> -            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) )
> +            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !(flags & CDF_staticmem) )
>                   panic("direct-map is not valid for domain %s without static allocation.\n",
>                         dt_node_name(node));
>   
> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index 95fef29111..4379f20a12 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -31,6 +31,8 @@ enum domain_type {
>   
>   #define is_domain_direct_mapped(d) (((d)->arch.flags) & CDF_directmap)
>   
> +#define is_domain_on_static_allocation(d) (((d)->arch.flags) & CDF_staticmem)

"on" sounds strange to me and the name is bit long. How about 
"is_domain_using_staticmem()" or maybe "is_domain_static()"?

I will have a look at the rest of the series before giving my ack on 
this patch.

> +
>   /*
>    * Is the domain using the host memory layout?
>    *
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 1c3c88a14d..35dc7143a4 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -34,6 +34,8 @@ void arch_get_domain_info(const struct domain *d,
>   #ifdef CONFIG_ARM
>   /* Should domain memory be directly mapped? */
>   #define CDF_directmap            (1U << 1)
> +/* Is domain memory on static allocation? */
> +#define CDF_staticmem            (1U << 2)
>   #endif
>   
>   /*

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 18:10:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 18:10:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297553.506940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLjE-0004Ay-Lx; Fri, 01 Apr 2022 18:10:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297553.506940; Fri, 01 Apr 2022 18:10:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naLjE-0004Ar-J3; Fri, 01 Apr 2022 18:10:32 +0000
Received: by outflank-mailman (input) for mailman id 297553;
 Fri, 01 Apr 2022 18:10:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naLjC-0004Al-V8
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 18:10:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLj8-00031G-AN; Fri, 01 Apr 2022 18:10:26 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naLj8-0002A9-3z; Fri, 01 Apr 2022 18:10:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=55r6LcT9MBKzSwHanEpMP81a9g/XWoD4HG9tunkh3IU=; b=dvOU2zqpWhG5yXfrsUwnVcDpH8
	984zuSb2gmiuw8RDs2m0Ik68FSxC6Psj595svljPZpHvjKMwu5vJCS1ziCb+kuMf9etGk7IVwf6VD
	GJJ6TeKcuq2f1pavUywaqrWwqrWQIcvZQ47mDy6jRa0F0koiD+5y8qjdg9YIvLal/zCc=;
Message-ID: <9bcfabc9-3d5f-0677-5a78-2902a0fa45e7@xen.org>
Date: Fri, 1 Apr 2022 19:10:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on static
 allocation
To: Jan Beulich <jbeulich@suse.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: wei.chen@arm.com, henry.wang@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220330093617.3870589-1-Penny.Zheng@arm.com>
 <20220330093617.3870589-4-Penny.Zheng@arm.com>
 <31c1ae2d-a4d6-5445-e819-5df5a0984cdd@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <31c1ae2d-a4d6-5445-e819-5df5a0984cdd@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 30/03/2022 10:52, Jan Beulich wrote:
> On 30.03.2022 11:36, Penny Zheng wrote:
>> --- a/xen/common/memory.c
>> +++ b/xen/common/memory.c
>> @@ -35,6 +35,10 @@
>>   #include <asm/guest.h>
>>   #endif
>>   
>> +#ifndef is_domain_on_static_allocation
>> +#define is_domain_on_static_allocation(d) 0
> 
> Nit: "false", not "0".

I think we also want to evaluate d so the behavior on x86 and arm is the 
same. Something like ((void)(d), false).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 18:54:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 18:54:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297559.506958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naMPB-0008P0-Ox; Fri, 01 Apr 2022 18:53:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297559.506958; Fri, 01 Apr 2022 18:53:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naMPB-0008Ot-Lz; Fri, 01 Apr 2022 18:53:53 +0000
Received: by outflank-mailman (input) for mailman id 297559;
 Fri, 01 Apr 2022 18:53:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naMP9-0008On-Tg
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 18:53:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naMP6-0003iV-DX; Fri, 01 Apr 2022 18:53:48 +0000
Received: from [54.239.6.189] (helo=[192.168.18.123])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naMP6-0004sa-72; Fri, 01 Apr 2022 18:53:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=43AGt2kDTptRp6gsxl5KdUrnVUYUs2dh2RGyik/bBK0=; b=QOnaMZX/13Q9Nq6ffwSsRTaiaE
	YjhjPDewYXBkDYBf/WvBdsCcIk/WWlVmD5hhFMGnCbxEXtkas0XpDAMcDDco6+57pneR2MG9hdvT9
	p9728MjrCvmnjfQhDr26PKZlx0BGpAW09jKWxH+Kq4pCs5jEqAp+fnR6ZpUmC49ERb34=;
Message-ID: <6ae9a1f9-4167-46d2-df9b-9d7f626fa247@xen.org>
Date: Fri, 1 Apr 2022 19:53:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on static
 allocation
To: Penny Zheng <Penny.Zheng@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220330093617.3870589-1-Penny.Zheng@arm.com>
 <20220330093617.3870589-4-Penny.Zheng@arm.com>
 <31c1ae2d-a4d6-5445-e819-5df5a0984cdd@suse.com>
 <DU2PR08MB73251B78F8EB19E334A70876F7E19@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <eba664e6-4146-426b-5119-59fe02a96bb5@suse.com>
 <DU2PR08MB7325D94A0BFFC2A3BB0AFF08F7E19@DU2PR08MB7325.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <DU2PR08MB7325D94A0BFFC2A3BB0AFF08F7E19@DU2PR08MB7325.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 31/03/2022 11:30, Penny Zheng wrote:
> Another reason I want to keep page allocated is that if putting pages in
> resv_page_list upon dropping the last ref, we need to do a lot things on
> pages to totally let it free, like set its owner to NULL, changing page state
> from in_use to free, etc.
This is not only about optimization here. Bad things can happen if you 
let a page in state free that is not meant to be used by the buddy 
allocator (e.g. it was reserved for static memory).

I discovered it earlier this year when trying to optimize 
init_heap_pages() for Live-Update. It was quite hard to debug because 
the corruption very rarely happened. So let me explain it before you 
face the same issue :).

free_heap_pages() will try to merge the about-to-be-freed chunk with the 
predecessor and/or successor. To know if the page can be merged, the 
algorithm is looking at whether the chunk is suitably aligned (e.g. same 
order) and if the page is in state free.

AFAICT, the pages belonging to the buddy allocator could be right next 
to region reserved memory. So there is a very slim chance that 
free_heap_pages() may decide to merge a chunk from the static region 
with the about-to-be-free chunk. Nothing very good will ensue.

Technically, this is already a bug in the already merged implementation 
of the static memory allocator.

I can see two ways to fix it:
   1) Update free_heap_pages() to check whether the page has 
PGC_reserved set.
   2) Use a different state for pages used by the static allocator.

So far my preference is leaning towards 1. But I would like to hear 
other opinions.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 19:37:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 19:37:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297563.506968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naN4t-0004DK-2k; Fri, 01 Apr 2022 19:36:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297563.506968; Fri, 01 Apr 2022 19:36:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naN4s-0004DD-Vv; Fri, 01 Apr 2022 19:36:58 +0000
Received: by outflank-mailman (input) for mailman id 297563;
 Fri, 01 Apr 2022 19:36:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naN4r-0004D1-96; Fri, 01 Apr 2022 19:36:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naN4r-0004RT-4i; Fri, 01 Apr 2022 19:36:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naN4q-0000EC-S5; Fri, 01 Apr 2022 19:36:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naN4q-0003u5-Rb; Fri, 01 Apr 2022 19:36:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/7E//KkjDz4wvjAWvtCh98gyhlUIma+zGdh4EJW8wHI=; b=LPKgtDJoueUPOcUforuJb5b9Ep
	Lf0gB1JuN0XEntQeGWhdTAyhxVQkKc4JbL07rxcoFXpmhdCpp5t/xy+nLO2Ci2871YojbtlFO2LcS
	WOTnBMTTVeVVy7NTJN34da3SWCYZe8Xk/Q+exPlZi/dXcAPlvhw4MRZGJj3llKXcdCqQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169098-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169098: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=d5f81479a6e51eaf9842d05df40c631653c6230d
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 19:36:56 +0000

flight 169098 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169098/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              d5f81479a6e51eaf9842d05df40c631653c6230d
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  630 days
Failing since        151818  2020-07-11 04:18:52 Z  629 days  611 attempts
Testing same since   169098  2022-04-01 04:20:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 102515 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 19:48:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 19:48:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297572.506979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naNFZ-0005mt-7t; Fri, 01 Apr 2022 19:48:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297572.506979; Fri, 01 Apr 2022 19:48:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naNFZ-0005mm-56; Fri, 01 Apr 2022 19:48:01 +0000
Received: by outflank-mailman (input) for mailman id 297572;
 Fri, 01 Apr 2022 19:47:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naNFX-0005mc-Tz; Fri, 01 Apr 2022 19:47:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naNFX-0004fb-Qf; Fri, 01 Apr 2022 19:47:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naNFX-00019e-KK; Fri, 01 Apr 2022 19:47:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naNFX-0007wU-Jv; Fri, 01 Apr 2022 19:47:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ds7T8TesX64V94NMhzBd5REmz+9ebTqFHeb7BExiZ0s=; b=Pzrd42VGAWX83fHMd7gizOMrAr
	ozJkZ/MMpWhzkIa+u6CMrPsAol6URWz6D0YANAKVIomoAhkW3HicDzzYviE+6/IelTX2YLD21YSs9
	YsLVtKR0YME2yfd5VJQWCL0DM+SIaAPtMKRsyyWADJTV2chv2QdN/iuqPLAo6jS3coHk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169102-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169102: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=55637a2894babca97945eeca1da0d431f74f8627
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 19:47:59 +0000

flight 169102 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169102/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 55637a2894babca97945eeca1da0d431f74f8627
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   32 days
Failing since        168258  2022-03-01 01:55:31 Z   31 days  266 attempts
Testing same since   169004  2022-03-30 02:24:42 Z    2 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Yi Li <yi1.li@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1236 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 20:50:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 20:50:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297582.506996 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naODL-0003WK-Rb; Fri, 01 Apr 2022 20:49:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297582.506996; Fri, 01 Apr 2022 20:49:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naODL-0003WD-Om; Fri, 01 Apr 2022 20:49:47 +0000
Received: by outflank-mailman (input) for mailman id 297582;
 Fri, 01 Apr 2022 20:49:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1naODJ-0003W7-W3
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 20:49:46 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 425130d7-b1fd-11ec-a405-831a346695d4;
 Fri, 01 Apr 2022 22:49:44 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4B8CDB8256E;
 Fri,  1 Apr 2022 20:49:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE41DC340EC;
 Fri,  1 Apr 2022 20:49:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 425130d7-b1fd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648846182;
	bh=jEtgBQpJcj+wCxPvue6be/xKRiBRj0GT+qxovqCEaqo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=LTfgALa3U/tHu2xtmMckDdSMs/1yq3O2zKb4JzcLKTKRCQhWmSCNBeuoATvlJ5JQ+
	 +Zi13iuTmyLy8K9GtziArRRlrQ52fXnuS/diQoVZPbegkRcVIa2dva/Nt1dS42zXqM
	 SHkH+J6o5NHgo/oW5WYrWcbHTPFJvSMc4UnSvud8Jarqop001WiBP6CM7lnudXomh6
	 dqx0gxfi5le4QOz4rakaZUVGXvfYQhYF+kS3cp3RzddukBRFNEvI4O0Nmq8mbSWwQo
	 AfjeZr+ilqug4MbzlEiVY8Leq1VlgCFQwzgFWv2PPJ69asql26L8kx/srR4RdU1RNU
	 eetfk5nbyV7HQ==
Date: Fri, 1 Apr 2022 13:49:41 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rob Herring <robh+dt@kernel.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org, 
    Julien Grall <julien@xen.org>, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] of: of_property_read_string return -ENODATA when
 !length
In-Reply-To: <CAL_Jsq+udUpUK3y7WOeLF2dtGs0=Jz59ed0mu_sgzstB-=TDzA@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204011338140.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311740450.2910984@ubuntu-linux-20-04-desktop> <CAL_Jsq+udUpUK3y7WOeLF2dtGs0=Jz59ed0mu_sgzstB-=TDzA@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 1 Apr 2022, Rob Herring wrote:
> On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini
> <sstabellini@kernel.org> wrote:
> >
> > From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> >
> > When the length of the string is zero of_property_read_string should
> > return -ENODATA according to the description of the function.
> 
> Perhaps it is a difference of:
> 
> prop;
> 
> vs.
> 
> prop = "";
> 
> Both are 0 length by some definition. The description, '-ENODATA if
> property does not have a value', matches the first case.
> 
> >
> > However, of_property_read_string doesn't check pp->length. If pp->length
> > is zero, return -ENODATA.
> >
> > Without this patch the following command in u-boot:
> >
> > fdt set /chosen/node property-name
> >
> > results in of_property_read_string returning -EILSEQ when attempting to
> > read property-name. With this patch, it returns -ENODATA as expected.
> 
> Why do you care? Do you have a user? There could be an in tree user
> that doesn't like this change.

During review of a Xen patch series (we have libfdt is Xen too, synced
with the kernel) Julien noticed a check for -EILSEQ. I added the check
so that Xen would behave correctly in cases like the u-boot example in
the patch description.

Looking more into it, it seemed to be a mismatch between the description
of of_property_read_string and the behavior (e.g. -ENODATA would seem to
be the right return value, not -EILSEQ.)

I added a printk to confirm what was going on when -EILSEQ was returned:

printk("DEBUG %s %d value=%s value[0]=%d length=%u len=%lu\n",__func__,__LINE__,(char*)pp->value, *((char*)pp->value),pp->length,
strlen(pp->value));
 
This is the output:
DEBUG of_property_read_string 205 value= value[0]=0 length=0 len=0

As the description says:

 *
 * Return: 0 on success, -EINVAL if the property does not exist, -ENODATA if
 * property does not have a value, and -EILSEQ if the string is not
 * null-terminated within the length of the property data.
 *

It seems that this case matches "property does not have a value" which
is expected to be -ENODATA instead of -EILSEQ. I guess one could also
say that length is zero, so the string cannot be null-terminated,
thus -EILSEQ?

I am happy to go with your interpretation but -ENODATA seems to be the
best match in my opinion.


> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> >
> > diff --git a/drivers/of/property.c b/drivers/of/property.c
> > index 8e90071de6ed..da0f02c98bb2 100644
> > --- a/drivers/of/property.c
> > +++ b/drivers/of/property.c
> > @@ -439,7 +439,7 @@ int of_property_read_string(const struct device_node *np, const char *propname,
> >         const struct property *prop = of_find_property(np, propname, NULL);
> >         if (!prop)
> >                 return -EINVAL;
> > -       if (!prop->value)
> > +       if (!prop->value || !pp->length)
> >                 return -ENODATA;
> >         if (strnlen(prop->value, prop->length) >= prop->length)
> >                 return -EILSEQ;
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 20:50:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 20:50:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297585.507008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naOEO-0004pF-7G; Fri, 01 Apr 2022 20:50:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297585.507008; Fri, 01 Apr 2022 20:50:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naOEO-0004p8-3J; Fri, 01 Apr 2022 20:50:52 +0000
Received: by outflank-mailman (input) for mailman id 297585;
 Fri, 01 Apr 2022 20:50:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naOEM-0004ot-Hz; Fri, 01 Apr 2022 20:50:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naOEM-0005mc-FX; Fri, 01 Apr 2022 20:50:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naOEL-0004RD-U7; Fri, 01 Apr 2022 20:50:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naOEL-0001w9-Tb; Fri, 01 Apr 2022 20:50:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VzLMnOw5yW2hA0ZgIHl+hmPROjUhgWxa+uIE3CTozU8=; b=Q4InOxig5ykVxOlsVm6GT3Xd95
	TaW2f2feXPIiBC5fzaJXjs/1A0EDPDkXhuaKapxUWalUduvyUZ0imFTGi7OGasL9/vXUXZCHyp6xm
	XYJ4Nmd5OryvHpagPiJWRP8At+N7Gol0G97uml3vVZex6+CPWUwd3SE79LEa4ExHaKKU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169114-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169114: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d62a34423a1a98aefd7c30e22d2d82d198f077c8
X-Osstest-Versions-That:
    xen=e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 20:50:49 +0000

flight 169114 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169114/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d62a34423a1a98aefd7c30e22d2d82d198f077c8
baseline version:
 xen                  e7cfcdc6719d586eb7cdb62d40275a7d17fe6760

Last test of basis   169090  2022-04-01 01:01:50 Z    0 days
Testing same since   169114  2022-04-01 17:01:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jason Andryuk <jandryuk@gmail.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e7cfcdc671..d62a34423a  d62a34423a1a98aefd7c30e22d2d82d198f077c8 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 21:09:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 21:09:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297594.507019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naOWM-0006Uv-Qa; Fri, 01 Apr 2022 21:09:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297594.507019; Fri, 01 Apr 2022 21:09:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naOWM-0006Uo-NW; Fri, 01 Apr 2022 21:09:26 +0000
Received: by outflank-mailman (input) for mailman id 297594;
 Fri, 01 Apr 2022 21:09:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naOWL-0006Ue-Hs; Fri, 01 Apr 2022 21:09:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naOWL-00067n-Ea; Fri, 01 Apr 2022 21:09:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naOWL-0005Md-17; Fri, 01 Apr 2022 21:09:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naOWL-0005Gb-0Y; Fri, 01 Apr 2022 21:09:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=v4ByG4Q05zVOUNonYO6ug5sQBp/dZw5bX43lQIyX8tc=; b=gZ/eFya+TjQT3JPvSXezgjlIjV
	sWD0+LI7qKWKrenIm8WNV8OzRDZl7MlZGyU/InmmPHY0n/FRL71ExFxJsfPQMeHLUjJapLSMX8P28
	BUf7QyQkNY9V1dhq2V8AolVvbJscV/DgR4aIgdVPOsVSjB5wcK7yBb2PDnU+kC33z/Kg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169086-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 169086: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.16-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e34c16cc6ee029fa75c35bd21f75103d5502ea30
X-Osstest-Versions-That:
    xen=cfd29b83a26f35f49f074f06169ce4cadfdebf0d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 01 Apr 2022 21:09:25 +0000

flight 169086 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169086/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-xsm               6 xen-build                fail REGR. vs. 168513
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 168513

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168513
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168513
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168513
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168513
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168513
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168513
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168513
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168513
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168513
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168513
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168513
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168513
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  e34c16cc6ee029fa75c35bd21f75103d5502ea30
baseline version:
 xen                  cfd29b83a26f35f49f074f06169ce4cadfdebf0d

Last test of basis   168513  2022-03-11 05:13:34 Z   21 days
Failing since        168864  2022-03-25 17:37:01 Z    7 days    9 attempts
Testing same since   169086  2022-03-31 23:18:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Olson <Alex.Olson@starlab.io>
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 507 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 22:01:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 22:01:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297604.507029 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naPKt-00040C-Ql; Fri, 01 Apr 2022 22:01:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297604.507029; Fri, 01 Apr 2022 22:01:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naPKt-000405-Nm; Fri, 01 Apr 2022 22:01:39 +0000
Received: by outflank-mailman (input) for mailman id 297604;
 Fri, 01 Apr 2022 22:01:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i2D4=UL=kernel.org=robh+dt@srs-se1.protection.inumbo.net>)
 id 1naPKs-0003zj-Hn
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 22:01:38 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4ceadec0-b207-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 00:01:37 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id F2C52B82547
 for <xen-devel@lists.xenproject.org>; Fri,  1 Apr 2022 22:01:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB1BDC3410F
 for <xen-devel@lists.xenproject.org>; Fri,  1 Apr 2022 22:01:34 +0000 (UTC)
Received: by mail-io1-f50.google.com with SMTP id e22so4731334ioe.11
 for <xen-devel@lists.xenproject.org>; Fri, 01 Apr 2022 15:01:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ceadec0-b207-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648850494;
	bh=ZQrbLPkLo5sfQcE73yUfUj3P2ZSop1t4uB2pIrb+x5s=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=M7Gw+J81HNta4UOZK1b5DyWKrKW6HKh1VcNWFV6Pl0XWEaxxxbzWB3JxBZadCJHen
	 KqkaquNDuy6VAtgKBM+puNzLN/35Tb5J/NmiGFeBN5OX1X846buCpticFxaJCPdzgm
	 ro6wU+BpnqYsXcnqNxFhQz15zvWA4liIIn09Q4pjkr/X31wZD/hp2b0QMfh9xNYRoW
	 j+MSu9mrXbq9UZLBdfQvrYHkHndTUedPSgNX1a7A90K7c4WHQTudmQRlMNw4UU+ftq
	 HxX2uFSghDrLaquvtN5tF4JtyLV5TkbatKPsZ884vb5KNjwmKDOpt+Gth4NQ9jDmIj
	 wA1WEB2hc42MQ==
X-Gm-Message-State: AOAM5315jBGyCgpMzCj0NLf/FtA5/ocZ2lCrAwFLNjEiDDkGUP0l1CrX
	BoplQUPTYBtrqTcKtUQyLQzDO4fxeSCAhTQVsg==
X-Google-Smtp-Source: ABdhPJw+LFcARwzaNCp2hP95MsT4VXSzQqMED1c5B/P2R3LB+Lv/I0+UJvyO4WpdpbHhv1y8zZlcKAkCdFFoaahnD14=
X-Received: by 2002:a05:6638:1301:b0:323:3b47:8b3f with SMTP id
 r1-20020a056638130100b003233b478b3fmr6606952jad.291.1648850493856; Fri, 01
 Apr 2022 15:01:33 -0700 (PDT)
MIME-Version: 1.0
References: <alpine.DEB.2.22.394.2203311740450.2910984@ubuntu-linux-20-04-desktop>
 <CAL_Jsq+udUpUK3y7WOeLF2dtGs0=Jz59ed0mu_sgzstB-=TDzA@mail.gmail.com> <alpine.DEB.2.22.394.2204011338140.2910984@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2204011338140.2910984@ubuntu-linux-20-04-desktop>
From: Rob Herring <robh+dt@kernel.org>
Date: Fri, 1 Apr 2022 17:01:22 -0500
X-Gmail-Original-Message-ID: <CAL_JsqJ6Yoc-gq=qUw+cS-34ZOsxtHAA01aa+FjaBySz1vwtuQ@mail.gmail.com>
Message-ID: <CAL_JsqJ6Yoc-gq=qUw+cS-34ZOsxtHAA01aa+FjaBySz1vwtuQ@mail.gmail.com>
Subject: Re: [PATCH] of: of_property_read_string return -ENODATA when !length
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org, 
	Julien Grall <julien@xen.org>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini
<sstabellini@kernel.org> wrote:
>
> On Fri, 1 Apr 2022, Rob Herring wrote:
> > On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini
> > <sstabellini@kernel.org> wrote:
> > >
> > > From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > >
> > > When the length of the string is zero of_property_read_string should
> > > return -ENODATA according to the description of the function.
> >
> > Perhaps it is a difference of:
> >
> > prop;
> >
> > vs.
> >
> > prop = "";
> >
> > Both are 0 length by some definition. The description, '-ENODATA if
> > property does not have a value', matches the first case.
> >
> > >
> > > However, of_property_read_string doesn't check pp->length. If pp->length
> > > is zero, return -ENODATA.
> > >
> > > Without this patch the following command in u-boot:
> > >
> > > fdt set /chosen/node property-name
> > >
> > > results in of_property_read_string returning -EILSEQ when attempting to
> > > read property-name. With this patch, it returns -ENODATA as expected.
> >
> > Why do you care? Do you have a user? There could be an in tree user
> > that doesn't like this change.
>
> During review of a Xen patch series (we have libfdt is Xen too, synced
> with the kernel) Julien noticed a check for -EILSEQ. I added the check
> so that Xen would behave correctly in cases like the u-boot example in
> the patch description.
>
> Looking more into it, it seemed to be a mismatch between the description
> of of_property_read_string and the behavior (e.g. -ENODATA would seem to
> be the right return value, not -EILSEQ.)
>
> I added a printk to confirm what was going on when -EILSEQ was returned:
>
> printk("DEBUG %s %d value=%s value[0]=%d length=%u len=%lu\n",__func__,__LINE__,(char*)pp->value, *((char*)pp->value),pp->length,
> strlen(pp->value));
>
> This is the output:
> DEBUG of_property_read_string 205 value= value[0]=0 length=0 len=0

It turns out that we never set pp->value to NULL when unflattening
(and libfdt always returns a value). This function is assuming we do.
>
> As the description says:
>
>  *
>  * Return: 0 on success, -EINVAL if the property does not exist, -ENODATA if
>  * property does not have a value, and -EILSEQ if the string is not
>  * null-terminated within the length of the property data.
>  *
>
> It seems that this case matches "property does not have a value" which
> is expected to be -ENODATA instead of -EILSEQ. I guess one could also
> say that length is zero, so the string cannot be null-terminated,
> thus -EILSEQ?
>
> I am happy to go with your interpretation but -ENODATA seems to be the
> best match in my opinion.

I agree. I just think empty property should have a NULL value and 0
length, but we should only have to check one. I don't want check
length as that could be different for Sparc or non-FDT. So I think we
need this instead:

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index ec315b060cd5..d6b2b0d49d89 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -165,7 +165,7 @@ static void populate_properties(const void *blob,

                pp->name   = (char *)pname;
                pp->length = sz;
-               pp->value  = (__be32 *)val;
+               pp->value  = sz ? (__be32 *)val : NULL;
                *pprev     = pp;
                pprev      = &pp->next;
        }


It looks like setting 'value' has been like this at least since 2010.

Rob


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 22:43:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 22:43:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297638.507065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naPzh-0000q7-CJ; Fri, 01 Apr 2022 22:43:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297638.507065; Fri, 01 Apr 2022 22:43:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naPzh-0000q0-8R; Fri, 01 Apr 2022 22:43:49 +0000
Received: by outflank-mailman (input) for mailman id 297638;
 Fri, 01 Apr 2022 22:43:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1naPzf-0000pu-8f
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 22:43:47 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2fae72a6-b20d-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 00:43:45 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 06E2961AC4;
 Fri,  1 Apr 2022 22:43:44 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26A59C340F3;
 Fri,  1 Apr 2022 22:43:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fae72a6-b20d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648853023;
	bh=k+RZxHyvOZAl6E9QWvnNayngGp2nt7useuqyNj/G844=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Bg6G8dxO/J6ZJnOC9CEhkPZSA/v7/BSHz2tzcCAikbKFO0b0Zga3mo50CcME+5129
	 vQRKoRzq1X7dJYOGZWZbSMtSjANrMU1NzqhsxZOka2SLe1T5tygKKBN1vtnCfqF+09
	 c1h7yBUYwox5kyrrgRw50AC9LdJNMoSKgjc6ABANIF1OW2M0ruzkDXcjWLyc6RWssb
	 XPEReBjKkW6hKSSMNFrH/RrRHWhaXBsVJd/I2nyF1IawhC1anAfZRXmpPnoZVwDbu/
	 WiCF/mGbjHjhV/0LwCZ/RCKugrFzT5GFu5PuI7RHs88CvmNvI8zWRPTE6MSm5dvsPZ
	 PSgkRMdht8LFg==
Date: Fri, 1 Apr 2022 15:43:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rob Herring <robh+dt@kernel.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org, 
    Julien Grall <julien@xen.org>, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] of: of_property_read_string return -ENODATA when
 !length
In-Reply-To: <CAL_JsqJ6Yoc-gq=qUw+cS-34ZOsxtHAA01aa+FjaBySz1vwtuQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204011517450.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311740450.2910984@ubuntu-linux-20-04-desktop> <CAL_Jsq+udUpUK3y7WOeLF2dtGs0=Jz59ed0mu_sgzstB-=TDzA@mail.gmail.com> <alpine.DEB.2.22.394.2204011338140.2910984@ubuntu-linux-20-04-desktop>
 <CAL_JsqJ6Yoc-gq=qUw+cS-34ZOsxtHAA01aa+FjaBySz1vwtuQ@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 1 Apr 2022, Rob Herring wrote:
> On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini
> <sstabellini@kernel.org> wrote:
> >
> > On Fri, 1 Apr 2022, Rob Herring wrote:
> > > On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini
> > > <sstabellini@kernel.org> wrote:
> > > >
> > > > From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > > >
> > > > When the length of the string is zero of_property_read_string should
> > > > return -ENODATA according to the description of the function.
> > >
> > > Perhaps it is a difference of:
> > >
> > > prop;
> > >
> > > vs.
> > >
> > > prop = "";
> > >
> > > Both are 0 length by some definition. The description, '-ENODATA if
> > > property does not have a value', matches the first case.
> > >
> > > >
> > > > However, of_property_read_string doesn't check pp->length. If pp->length
> > > > is zero, return -ENODATA.
> > > >
> > > > Without this patch the following command in u-boot:
> > > >
> > > > fdt set /chosen/node property-name
> > > >
> > > > results in of_property_read_string returning -EILSEQ when attempting to
> > > > read property-name. With this patch, it returns -ENODATA as expected.
> > >
> > > Why do you care? Do you have a user? There could be an in tree user
> > > that doesn't like this change.
> >
> > During review of a Xen patch series (we have libfdt is Xen too, synced
> > with the kernel) Julien noticed a check for -EILSEQ. I added the check
> > so that Xen would behave correctly in cases like the u-boot example in
> > the patch description.
> >
> > Looking more into it, it seemed to be a mismatch between the description
> > of of_property_read_string and the behavior (e.g. -ENODATA would seem to
> > be the right return value, not -EILSEQ.)
> >
> > I added a printk to confirm what was going on when -EILSEQ was returned:
> >
> > printk("DEBUG %s %d value=%s value[0]=%d length=%u len=%lu\n",__func__,__LINE__,(char*)pp->value, *((char*)pp->value),pp->length,
> > strlen(pp->value));
> >
> > This is the output:
> > DEBUG of_property_read_string 205 value= value[0]=0 length=0 len=0
> 
> It turns out that we never set pp->value to NULL when unflattening
> (and libfdt always returns a value). This function is assuming we do.
> >
> > As the description says:
> >
> >  *
> >  * Return: 0 on success, -EINVAL if the property does not exist, -ENODATA if
> >  * property does not have a value, and -EILSEQ if the string is not
> >  * null-terminated within the length of the property data.
> >  *
> >
> > It seems that this case matches "property does not have a value" which
> > is expected to be -ENODATA instead of -EILSEQ. I guess one could also
> > say that length is zero, so the string cannot be null-terminated,
> > thus -EILSEQ?
> >
> > I am happy to go with your interpretation but -ENODATA seems to be the
> > best match in my opinion.
> 
> I agree. I just think empty property should have a NULL value and 0
> length, but we should only have to check one. I don't want check
> length as that could be different for Sparc or non-FDT. So I think we
> need this instead:
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index ec315b060cd5..d6b2b0d49d89 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -165,7 +165,7 @@ static void populate_properties(const void *blob,
> 
>                 pp->name   = (char *)pname;
>                 pp->length = sz;
> -               pp->value  = (__be32 *)val;
> +               pp->value  = sz ? (__be32 *)val : NULL;
>                 *pprev     = pp;
>                 pprev      = &pp->next;
>         }
> 
> 
> It looks like setting 'value' has been like this at least since 2010.

Yep, fixing old bugs nobody cares about, that's me :-)

I made the corresponding change to Xen to check that it fixes the
original issue (I am using Xen only for convenience because I already
have a reproducer setup for it.)

Unfortunately it breaks the boot: the reason is that of_get_property is
implemented as:

  return pp ? pp->value : NULL;

and at least in Xen (maybe in Linux too) there are instances of callers
doing:

        if (!of_get_property(node, "interrupt-controller", NULL))
            continue;

This would now take the wrong code path because value is returned as
NULL.

So, although your patch is technically correct, it comes with higher
risk of breaking existing code. How do you want to proceed?


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 23:15:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 23:15:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297643.507076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naQTg-0004At-Pk; Fri, 01 Apr 2022 23:14:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297643.507076; Fri, 01 Apr 2022 23:14:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naQTg-0004Am-MT; Fri, 01 Apr 2022 23:14:48 +0000
Received: by outflank-mailman (input) for mailman id 297643;
 Fri, 01 Apr 2022 23:14:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zo7N=UL=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1naQTe-0004Ag-O5
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 23:14:47 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 826ca2bf-b211-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 01:14:43 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id D6E443201ECF;
 Fri,  1 Apr 2022 19:14:39 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Fri, 01 Apr 2022 19:14:40 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 1 Apr 2022 19:14:38 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 826ca2bf-b211-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:message-id:mime-version:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm3; bh=WPE//5ah+E0hKk2PE+vG+xE7cWokDT9zLMikJPcvP
	jo=; b=P8Gd3YFgv9pd0SUbT6EcyeaSfmAZpfc9h91Bmm9jqmTgQky9dLaZAwRLo
	2tnfpjna0THtUDQP3bi7MYRvo4o6qpqQr32mSGEi34XWXOXCQiWXfHwnrEjJUdqj
	MP1ELbrefZEguBJDUt5DRpjq+iyE0G32w65dcmme+WG1kljgPBVKwEgnMfpMFP+q
	RgT9ypD2XZfoHo5hZgrCn+WBpdAYZsPsYgRX/ssvjd3CV+1latVEgqYokvjxhqae
	8EBKimxSKxnzu5yyrsIBq5IyM8Mkm2vsDrBej24ohP558RKl5OwSEd3t38UR+wvf
	MIJU+cBI9U9UUacOrjPw5wditOi2w==
X-ME-Sender: <xms:X4dHYjOnAN-8-w_YHL8hYtwqrQB54KvHXhhjR-Lg6Ij6fYJv8wIYCQ>
    <xme:X4dHYt8eeS4GbVG4fWE9vJi3ws8WR2Yg1d5CrdIK62fzfhjR9AdV0gzSXNrdFZzym
    6Gw5_4tLCD9WNE>
X-ME-Received: <xmr:X4dHYiTXQmq1gqNBiTBFW_F8MjS1C5yJIWahwlDT63dFIijs6L3F74U8qrM2>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeijedgudefucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfggtggusehgtderredttddunecuhfhrohhmpeffvghmihcuofgr
    rhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg
    gsrdgtohhmqeenucggtffrrghtthgvrhhnpeeuveeguefgvdeiueejfedugeevleefteek
    udefheetuddvtdduvefggfeghedtffenucffohhmrghinhepkhgvrhhnvghlrdhorhhgne
    cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhi
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:X4dHYnte0x3ODsk5b_jFEP87QWNz8bOFenNYGFKHnLayHKadFaWhIA>
    <xmx:X4dHYreAiZmgRHCasq3J-492LIgXSL4b0ylzUVWzpXCRO6Je5k2C7Q>
    <xmx:X4dHYj3UysSn19fwizrAqEvl4AzD3MPRLB_8rNg4VQoMTNB476WMyw>
    <xmx:X4dHYjQ_Ai938zRVK4Q0oACNpI449w8sd1ds5-0Fn4cBmzeWrP9_xA>
Date: Fri, 1 Apr 2022 19:14:32 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Cc: xen-devel@lists.xenproject.org
Subject: [PATCH v2] Grab the EFI System Resource Table and check it
Message-ID: <YkeHXFvgB3MwXnuR@itl-email>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Lfy7FQ1zC0j/nFNw"
Content-Disposition: inline


--Lfy7FQ1zC0j/nFNw
Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 1 Apr 2022 19:14:32 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Cc: xen-devel@lists.xenproject.org
Subject: [PATCH v2] Grab the EFI System Resource Table and check it

The EFI System Resource Table (ESRT) is necessary for fwupd to identify
firmware updates to install.  According to the UEFI specification =A723.4,
the table shall be stored in memory of type EfiBootServicesData.
Therefore, Xen must avoid reusing that memory for other purposes, so
that Linux can access the ESRT.  Additionally, Xen must mark the memory
as reserved, so that Linux knows accessing it is safe.

See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/
for details.

Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
---
 xen/arch/arm/efi/efi-boot.h |  9 +++--
 xen/arch/x86/efi/efi-boot.h |  5 ++-
 xen/common/efi/boot.c       | 77 +++++++++++++++++++++++++++++++++++--
 xen/common/efi/efi.h        |  2 +-
 xen/common/efi/runtime.c    |  5 ++-
 xen/include/efi/efiapi.h    |  3 ++
 6 files changed, 89 insertions(+), 12 deletions(-)

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index ae8627134e..767b2c9154 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -176,7 +176,8 @@ static bool __init meminfo_add_bank(struct meminfo *mem,
=20
 static EFI_STATUS __init efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRI=
PTOR *map,
                                                 UINTN mmap_size,
-                                                UINTN desc_size)
+                                                UINTN desc_size,
+                                                const EFI_MEMORY_DESCRIPTO=
R *const esrt_desc)
 {
     int Index;
     EFI_MEMORY_DESCRIPTOR *desc_ptr =3D map;
@@ -188,6 +189,7 @@ static EFI_STATUS __init efi_process_memory_map_bootinf=
o(EFI_MEMORY_DESCRIPTOR *
               desc_ptr->Type =3D=3D EfiLoaderCode ||
               desc_ptr->Type =3D=3D EfiLoaderData ||
               (!map_bs &&
+               desc_ptr !=3D esrt_desc &&
                (desc_ptr->Type =3D=3D EfiBootServicesCode ||
                 desc_ptr->Type =3D=3D EfiBootServicesData))) )
         {
@@ -393,11 +395,12 @@ static void __init efi_arch_process_memory_map(EFI_SY=
STEM_TABLE *SystemTable,
                                                void *map,
                                                UINTN map_size,
                                                UINTN desc_size,
-                                               UINT32 desc_ver)
+                                               UINT32 desc_ver,
+                                               const EFI_MEMORY_DESCRIPTOR=
 *const esrt_desc)
 {
     EFI_STATUS status;
=20
-    status =3D efi_process_memory_map_bootinfo(map, map_size, desc_size);
+    status =3D efi_process_memory_map_bootinfo(map, map_size, desc_size, e=
srt_desc);
     if ( EFI_ERROR(status) )
         blexit(L"EFI memory map processing failed");
=20
diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
index d91eb5a537..6e6a5d2224 100644
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -154,7 +154,8 @@ static void __init efi_arch_process_memory_map(EFI_SYST=
EM_TABLE *SystemTable,
                                                void *map,
                                                UINTN map_size,
                                                UINTN desc_size,
-                                               UINT32 desc_ver)
+                                               UINT32 desc_ver,
+                                               const EFI_MEMORY_DESCRIPTOR=
 *const esrt_desc)
 {
     struct e820entry *e;
     unsigned int i;
@@ -171,7 +172,7 @@ static void __init efi_arch_process_memory_map(EFI_SYST=
EM_TABLE *SystemTable,
         {
         case EfiBootServicesCode:
         case EfiBootServicesData:
-            if ( map_bs )
+            if ( map_bs || desc =3D=3D esrt_desc )
             {
         default:
                 type =3D E820_RESERVED;
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 4dd5ea6a06..ad5883133d 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -93,6 +93,23 @@ typedef struct _EFI_LOAD_OPTION {
     CHAR16 Description[];
 } EFI_LOAD_OPTION;
=20
+struct esrt_entry {
+    EFI_GUID fw_class;
+    UINT32 fw_type;
+    UINT32 fw_version;
+    UINT32 fw_lowest_supported_version;
+    UINT32 fw_capsule_flags;
+    UINT32 fw_last_attempt_version;
+    UINT32 fw_last_attempt_status;
+};
+
+struct esrt {
+    UINT32 esrt_count;
+    UINT32 esrt_max;
+    UINT64 esrt_version;
+    struct esrt_entry esrt_entries[];
+};
+
 #define LOAD_OPTION_ACTIVE              0x00000001
=20
 union string {
@@ -567,6 +584,38 @@ static int __init efi_check_dt_boot(const EFI_LOADED_I=
MAGE *loaded_image)
 }
 #endif
=20
+static UINTN __initdata esrt;
+
+static bool __init is_esrt_valid(
+    const EFI_MEMORY_DESCRIPTOR *const desc)
+{
+    size_t available_len, esrt_len, len;
+    const UINTN physical_start =3D desc->PhysicalStart;
+    const struct esrt *esrt_ptr;
+
+    len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
+    if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR )
+        return false;
+    if ( physical_start > esrt || esrt - physical_start >=3D len )
+        return false;
+    /*
+     * The specification requires EfiBootServicesData, but accept
+     * EfiRuntimeServicesData for compatibility
+     */
+    if ( (desc->Type !=3D EfiRuntimeServicesData) &&
+         (desc->Type !=3D EfiBootServicesData) )
+        return false;
+    available_len =3D len - (esrt - physical_start);
+    if ( available_len < sizeof(*esrt_ptr) )
+        return false;
+    esrt_ptr =3D (const struct esrt *)esrt;
+    if ( esrt_ptr->esrt_version !=3D 1 || esrt_ptr->esrt_count <=3D 0 )
+        return false;
+    esrt_len =3D esrt_ptr->esrt_count * sizeof(esrt_ptr->esrt_entries[0]);
+
+    return esrt_len > available_len - sizeof(*esrt_ptr);
+}
+
 /*
  * Include architecture specific implementation here, which references the
  * static globals defined above.
@@ -846,6 +895,10 @@ static void __init efi_tables(void)
 {
     unsigned int i;
=20
+    BUILD_BUG_ON(sizeof(struct esrt_entry) !=3D 40);
+    BUILD_BUG_ON(__alignof(struct esrt_entry) !=3D 4);
+    BUILD_BUG_ON(sizeof(struct esrt) !=3D 16);
+
     /* Obtain basic table pointers. */
     for ( i =3D 0; i < efi_num_ct; ++i )
     {
@@ -854,6 +907,7 @@ static void __init efi_tables(void)
         static EFI_GUID __initdata mps_guid =3D MPS_TABLE_GUID;
         static EFI_GUID __initdata smbios_guid =3D SMBIOS_TABLE_GUID;
         static EFI_GUID __initdata smbios3_guid =3D SMBIOS3_TABLE_GUID;
+        static EFI_GUID __initdata esrt_guid =3D ESRT_GUID;
=20
         if ( match_guid(&acpi2_guid, &efi_ct[i].VendorGuid) )
 	       efi.acpi20 =3D (long)efi_ct[i].VendorTable;
@@ -865,6 +919,8 @@ static void __init efi_tables(void)
 	       efi.smbios =3D (long)efi_ct[i].VendorTable;
         if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) )
 	       efi.smbios3 =3D (long)efi_ct[i].VendorTable;
+        if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) )
+	       esrt =3D (long)efi_ct[i].VendorTable;
     }
=20
 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */
@@ -1053,19 +1109,19 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHa=
ndle, EFI_SYSTEM_TABLE *Syste
     EFI_STATUS status;
     UINTN info_size =3D 0, map_key;
     bool retry;
-#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
     unsigned int i;
-#endif
=20
     efi_bs->GetMemoryMap(&info_size, NULL, &map_key,
                          &efi_mdesc_size, &mdesc_ver);
-    info_size +=3D 8 * efi_mdesc_size;
+    info_size +=3D 8 * (efi_mdesc_size + 1);
     efi_memmap =3D efi_arch_allocate_mmap_buffer(info_size);
     if ( !efi_memmap )
         blexit(L"Unable to allocate memory for EFI memory map");
=20
     for ( retry =3D false; ; retry =3D true )
     {
+        esrt_desc =3D (EFI_MEMORY_DESCRIPTOR*)EFI_INVALID_TABLE_ADDR;
+
         efi_memmap_size =3D info_size;
         status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_siz=
e,
                                                          efi_memmap, &map_=
key,
@@ -1074,8 +1130,21 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHan=
dle, EFI_SYSTEM_TABLE *Syste
         if ( EFI_ERROR(status) )
             PrintErrMesg(L"Cannot obtain memory map", status);
=20
+        for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
+        {
+            if ( is_esrt_valid(efi_memmap + i) )
+            {
+                esrt_desc =3D efi_memmap + i;
+                break;
+            }
+        }
+
+        /*
+         * We cannot pass esrt because we need to explicitly compare the
+         * descriptor pointers for equality.
+         */
         efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_si=
ze,
-                                    efi_mdesc_size, mdesc_ver);
+                                    efi_mdesc_size, mdesc_ver, esrt_desc);
=20
         efi_arch_pre_exit_boot();
=20
diff --git a/xen/common/efi/efi.h b/xen/common/efi/efi.h
index c9aa65d506..498c8dc1fa 100644
--- a/xen/common/efi/efi.h
+++ b/xen/common/efi/efi.h
@@ -27,7 +27,7 @@ extern const CHAR16 *efi_fw_vendor;
 extern const EFI_RUNTIME_SERVICES *efi_rs;
=20
 extern UINTN efi_memmap_size, efi_mdesc_size;
-extern void *efi_memmap;
+extern void *efi_memmap, *esrt_desc;
=20
 #ifdef CONFIG_X86
 extern mfn_t efi_l4_mfn;
diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
index 13b0975866..9b6a06e651 100644
--- a/xen/common/efi/runtime.c
+++ b/xen/common/efi/runtime.c
@@ -52,6 +52,7 @@ static unsigned int efi_rs_on_cpu =3D NR_CPUS;
 UINTN __read_mostly efi_memmap_size;
 UINTN __read_mostly efi_mdesc_size;
 void *__read_mostly efi_memmap;
+void *__read_mostly esrt_desc;
=20
 UINT64 __read_mostly efi_boot_max_var_store_size;
 UINT64 __read_mostly efi_boot_remain_var_store_size;
@@ -269,14 +270,14 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info *=
info)
     case XEN_FW_EFI_MEM_INFO:
         for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
         {
-            EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
+            const EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
             u64 len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
=20
             if ( info->mem.addr >=3D desc->PhysicalStart &&
                  info->mem.addr < desc->PhysicalStart + len )
             {
                 info->mem.type =3D desc->Type;
-                info->mem.attr =3D desc->Attribute;
+                info->mem.attr =3D desc =3D=3D esrt_desc ? EFI_MEMORY_RUNT=
IME : desc->Attribute;
                 if ( info->mem.addr + info->mem.size < info->mem.addr ||
                      info->mem.addr + info->mem.size >
                      desc->PhysicalStart + len )
diff --git a/xen/include/efi/efiapi.h b/xen/include/efi/efiapi.h
index a616d1238a..42ef3e1c8c 100644
--- a/xen/include/efi/efiapi.h
+++ b/xen/include/efi/efiapi.h
@@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES {
 #define SAL_SYSTEM_TABLE_GUID    \
     { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1=
, 0x4d} }
=20
+#define ESRT_GUID    \
+    { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x2=
1, 0x80} }
+
=20
 typedef struct _EFI_CONFIGURATION_TABLE {
     EFI_GUID                VendorGuid;
--=20
Sincerely,
Demi Marie Obenour
Invisible Things Lab

--Lfy7FQ1zC0j/nFNw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJHh1wACgkQsoi1X/+c
IsGDdQ//RyTKBEmNYUgRFfD0IhEQg7zXoui/D7uGkHkjyFnA9R9DfUCsRlHE17rc
uuk+D9oOWXogWLfZ7rBWSsCbrGUq+0Z/oYgCGXp90kP8G2WxWUMvS1iWmsWG6XYg
ODkDB+UFzdToyV3Pj3kjnBJ+kFMraYG1VPPAtH2qkRaDJzpOMOiwD2lWGupG8mAw
QIsX3LIBhKteRKZkIHEEGFG2Kwlzf+3tjwN53ebaG3/vuZnpguQAiq7X5VJnbXQr
cKECyz9COZsyD/ay9OMtthQ202nhHvb6s/V9kxdLbxRz1Pnts6XxFXsMPDX9xP1e
O3qHm+qWMORVM48q7ZhGqQUnc/L94FNJsiaiBqgk0KX44C7MakHy2xyOAC8VYs5Y
pHH9KwDQ+WOXU+UgLe+cybv0iDzXeZmcOCIALSTmkDxXhcyJCNSgKAALrkb3Cs3o
RG1LIrxEFHeLZW7P2Omb/tppZypoR4YpV6T50TkV4g0jSeigJH4RwxuSgRbyhDm/
CLOVAuqGkV22P+qWXzQqarmshykUl2N4WthkfX+KxOQfoo2qcpfSeN4DJcbu9jbM
iQGX38JK59qarH0AeYf+3s1r6GGP0Ee9idDfdrx/om0Hk6xWal5e2QU744BOnZjt
j9FuZ0oCA1de6VJVMBcXZfjLVPZRI0RCeJgP5DUjMVzARn0b1pE=
=i9tQ
-----END PGP SIGNATURE-----

--Lfy7FQ1zC0j/nFNw--


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 23:36:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 23:36:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297648.507087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naQoC-0006d2-Lx; Fri, 01 Apr 2022 23:36:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297648.507087; Fri, 01 Apr 2022 23:36:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naQoC-0006cv-Hz; Fri, 01 Apr 2022 23:36:00 +0000
Received: by outflank-mailman (input) for mailman id 297648;
 Fri, 01 Apr 2022 23:35:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1naQoB-0006cp-41
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 23:35:59 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7aa95997-b214-11ec-8fbc-03012f2f19d4;
 Sat, 02 Apr 2022 01:35:57 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 48CA7B8256B;
 Fri,  1 Apr 2022 23:35:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9761AC2BBE4;
 Fri,  1 Apr 2022 23:35:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7aa95997-b214-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648856155;
	bh=+iEryKsuAPI8Y89/I7krnPYE+MMmG3m2b4naH2Vixvg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=AtgFDssTeVz9IHt1HTMMn11wVNgYrCgGQd2UQJKMInWznXu2joAzlhV3Rk0e/H+9P
	 WaaScX6uUHL5zu39z5EzZk4XB82HxBk74EDJpS8nllyy4+u+1Q12wB59Zr/vM0grQ5
	 5V5wZwxQ42XC2+8G1Lq3MeFQEEsl/aEPeN+S2FRZyf/lAU/2tmgQYcR5fRp8hLiV7f
	 RGUze5r+GMXfeisTmo1D03bwDfmug8Q0j0twq/xww/GhPZFlqXQbRRA8PtBPsGvd/Z
	 Ogtcp3uvylhytENPuVfnZvw8rh73Se1k3ZjJSDKJcQ1E8pXrSM4iJ2cPx2fptKA50P
	 y2i8zKpV+XWrg==
Date: Fri, 1 Apr 2022 16:35:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 04/19] xen/arm: mm: Allow other mapping size in
 xen_pt_update_entry()
In-Reply-To: <20220221102218.33785-5-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204011605580.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-5-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
> 
> At the moment, xen_pt_update_entry() only supports mapping at level 3
> (i.e 4KB mapping). While this is fine for most of the runtime helper,
> the boot code will require to use superpage mapping.
> 
> We don't want to allow superpage mapping by default as some of the
> callers may expect small mappings (i.e populate_pt_range()) or even
> expect to unmap only a part of a superpage.
> 
> To keep the code simple, a new flag _PAGE_BLOCK is introduced to
> allow the caller to enable superpage mapping.
> 
> As the code doesn't support all the combinations, xen_pt_check_entry()
> is extended to take into account the cases we don't support when
> using block mapping:
>     - Replacing a table with a mapping. This may happen if region was
>     first mapped with 4KB mapping and then later on replaced with a 2MB
>     (or 1GB mapping).
>     - Removing/modifying a table. This may happen if a caller try to
>     remove a region with _PAGE_BLOCK set when it was created without it.
> 
> Note that the current restriction means that the caller must ensure that
> _PAGE_BLOCK is consistently set/cleared across all the updates on a
> given virtual region. This ought to be fine with the expected use-cases.
> 
> More rework will be necessary if we wanted to remove the restrictions.
> 
> Note that nr_mfns is now marked const as it is used for flushing the
> TLBs and we don't want it to be modified.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v3:
>         - Fix clash after prefixing the PT macros with XEN_PT_
>         - Fix typoes in the commit message
>         - Support superpage mappings even if nr is not suitably aligned
>         - Move the logic to find the level in a separate function
> 
>     Changes in v2:
>         - Pass the target level rather than the order to
>         xen_pt_update_entry()
>         - Update some comments
>         - Open-code paddr_to_pfn()
>         - Add my AWS signed-off-by
> ---
>  xen/arch/arm/include/asm/page.h |   4 ++
>  xen/arch/arm/mm.c               | 108 ++++++++++++++++++++++++++------
>  2 files changed, 94 insertions(+), 18 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h
> index c6f9fb0d4e0c..07998df47bac 100644
> --- a/xen/arch/arm/include/asm/page.h
> +++ b/xen/arch/arm/include/asm/page.h
> @@ -69,6 +69,7 @@
>   * [3:4] Permission flags
>   * [5]   Page present
>   * [6]   Only populate page tables
> + * [7]   Superpage mappings is allowed
>   */
>  #define PAGE_AI_MASK(x) ((x) & 0x7U)
>  
> @@ -82,6 +83,9 @@
>  #define _PAGE_PRESENT    (1U << 5)
>  #define _PAGE_POPULATE   (1U << 6)
>  
> +#define _PAGE_BLOCK_BIT     7
> +#define _PAGE_BLOCK         (1U << _PAGE_BLOCK_BIT)
> +
>  /*
>   * _PAGE_DEVICE and _PAGE_NORMAL are convenience defines. They are not
>   * meant to be used outside of this header.
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 515d0906f85b..3af69b396bd1 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1063,9 +1063,10 @@ static int xen_pt_next_level(bool read_only, unsigned int level,
>  }
>  
>  /* Sanity check of the entry */
> -static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
> +static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level,
> +                               unsigned int flags)
>  {
> -    /* Sanity check when modifying a page. */
> +    /* Sanity check when modifying an entry. */
>      if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) )
>      {
>          /* We don't allow modifying an invalid entry. */
> @@ -1075,6 +1076,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
>              return false;
>          }
>  
> +        /* We don't allow modifying a table entry */
> +        if ( !lpae_is_mapping(entry, level) )
> +        {
> +            mm_printk("Modifying a table entry is not allowed.\n");
> +            return false;
> +        }
> +
>          /* We don't allow changing memory attributes. */
>          if ( entry.pt.ai != PAGE_AI_MASK(flags) )
>          {
> @@ -1090,7 +1098,7 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
>              return false;
>          }
>      }
> -    /* Sanity check when inserting a page */
> +    /* Sanity check when inserting a mapping */
>      else if ( flags & _PAGE_PRESENT )
>      {
>          /* We should be here with a valid MFN. */
> @@ -1099,18 +1107,28 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
>          /* We don't allow replacing any valid entry. */
>          if ( lpae_is_valid(entry) )
>          {
> -            mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n",
> -                      mfn_x(lpae_get_mfn(entry)), mfn_x(mfn));
> +            if ( lpae_is_mapping(entry, level) )
> +                mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n",
> +                          mfn_x(lpae_get_mfn(entry)), mfn_x(mfn));
> +            else
> +                mm_printk("Trying to replace a table with a mapping.\n");
>              return false;
>          }
>      }
> -    /* Sanity check when removing a page. */
> +    /* Sanity check when removing a mapping. */
>      else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 )
>      {
>          /* We should be here with an invalid MFN. */
>          ASSERT(mfn_eq(mfn, INVALID_MFN));
>  
> -        /* We don't allow removing page with contiguous bit set. */
> +        /* We don't allow removing a table */
> +        if ( lpae_is_table(entry, level) )
> +        {
> +            mm_printk("Removing a table is not allowed.\n");
> +            return false;
> +        }
> +
> +        /* We don't allow removing a mapping with contiguous bit set. */
>          if ( entry.pt.contig )
>          {
>              mm_printk("Removing entry with contiguous bit set is not allowed.\n");
> @@ -1128,13 +1146,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
>      return true;
>  }
>  
> +/* Update an entry at the level @target. */
>  static int xen_pt_update_entry(mfn_t root, unsigned long virt,
> -                               mfn_t mfn, unsigned int flags)
> +                               mfn_t mfn, unsigned int target,
> +                               unsigned int flags)
>  {
>      int rc;
>      unsigned int level;
> -    /* We only support 4KB mapping (i.e level 3) for now */
> -    unsigned int target = 3;
>      lpae_t *table;
>      /*
>       * The intermediate page tables are read-only when the MFN is not valid
> @@ -1189,7 +1207,7 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt,
>      entry = table + offsets[level];
>  
>      rc = -EINVAL;
> -    if ( !xen_pt_check_entry(*entry, mfn, flags) )
> +    if ( !xen_pt_check_entry(*entry, mfn, level, flags) )
>          goto out;
>  
>      /* If we are only populating page-table, then we are done. */
> @@ -1207,8 +1225,11 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt,
>          {
>              pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags));
>  
> -            /* Third level entries set pte.pt.table = 1 */
> -            pte.pt.table = 1;
> +            /*
> +             * First and second level pages set pte.pt.table = 0, but
> +             * third level entries set pte.pt.table = 1.
> +             */
> +            pte.pt.table = (level == 3);
>          }
>          else /* We are updating the permission => Copy the current pte. */
>              pte = *entry;
> @@ -1228,15 +1249,56 @@ out:
>      return rc;
>  }
>  
> +/* Return the level where mapping should be done */
> +static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr,
> +                                unsigned int flags)
> +{
> +    unsigned int level;
> +    unsigned long mask;

Shouldn't mask be 64-bit on aarch32?


> +    /*
> +      * Don't take into account the MFN when removing mapping (i.e
> +      * MFN_INVALID) to calculate the correct target order.
> +      *
> +      * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned.
> +      * They are or-ed together and then checked against the size of
> +      * each level.
> +      *
> +      * `left` is not included and checked separately to allow
> +      * superpage mapping even if it is not properly aligned (the
> +      * user may have asked to map 2MB + 4k).
> +      */
> +     mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0;
> +     mask |= vfn;
> +
> +     /*
> +      * Always use level 3 mapping unless the caller request block
> +      * mapping.
> +      */
> +     if ( likely(!(flags & _PAGE_BLOCK)) )
> +         level = 3;
> +     else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) &&
> +               (nr >= BIT(FIRST_ORDER, UL)) )
> +         level = 1;
> +     else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) &&
> +               (nr >= BIT(SECOND_ORDER, UL)) )
> +         level = 2;
> +     else
> +         level = 3;
> +
> +     return level;

As far as I can tell this function is correct

> +}
> +
>  static DEFINE_SPINLOCK(xen_pt_lock);
>  
>  static int xen_pt_update(unsigned long virt,
>                           mfn_t mfn,
> -                         unsigned long nr_mfns,
> +                         const unsigned long nr_mfns,

Why const? nr_mfns is an unsigned long so it is passed as value: it
couldn't change the caller's parameter anyway. Just curious.


>                           unsigned int flags)
>  {
>      int rc = 0;
> -    unsigned long addr = virt, addr_end = addr + nr_mfns * PAGE_SIZE;
> +    unsigned long vfn = virt >> PAGE_SHIFT;
> +    unsigned long left = nr_mfns;
>  
>      /*
>       * For arm32, page-tables are different on each CPUs. Yet, they share
> @@ -1268,14 +1330,24 @@ static int xen_pt_update(unsigned long virt,
>  
>      spin_lock(&xen_pt_lock);
>  
> -    for ( ; addr < addr_end; addr += PAGE_SIZE )
> +    while ( left )
>      {
> -        rc = xen_pt_update_entry(root, addr, mfn, flags);
> +        unsigned int order, level;
> +
> +        level = xen_pt_mapping_level(vfn, mfn, left, flags);
> +        order = XEN_PT_LEVEL_ORDER(level);
> +
> +        ASSERT(left >= BIT(order, UL));
> +
> +        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level, flags);

NIT: I know we don't have vfn_to_vaddr at the moment and there is no
widespread usage of vfn in Xen anyway, but it looks off to use
pfn_to_paddr on a vfn parameter. Maybe open-code pfn_to_paddr instead?
Or introduce vfn_to_vaddr locally in this file?


>          if ( rc )
>              break;
>  
> +        vfn += 1U << order;
>          if ( !mfn_eq(mfn, INVALID_MFN) )
> -            mfn = mfn_add(mfn, 1);
> +            mfn = mfn_add(mfn, 1U << order);
> +
> +        left -= (1U << order);

This looks correct. I don't have any other feedback on this patch.


>      /*
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 01 23:53:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Apr 2022 23:53:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297656.507104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naR4n-0000X8-58; Fri, 01 Apr 2022 23:53:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297656.507104; Fri, 01 Apr 2022 23:53:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naR4n-0000X1-1p; Fri, 01 Apr 2022 23:53:09 +0000
Received: by outflank-mailman (input) for mailman id 297656;
 Fri, 01 Apr 2022 23:53:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIha=UL=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1naR4l-0000Wu-IG
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 23:53:07 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df84d682-b216-11ec-8fbc-03012f2f19d4;
 Sat, 02 Apr 2022 01:53:06 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8FD6B616AA;
 Fri,  1 Apr 2022 23:53:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 847FCC2BBE4;
 Fri,  1 Apr 2022 23:53:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df84d682-b216-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648857183;
	bh=1J/IGJPpqY73ftLbfVEJzfZEYZpXm+SrGHibXxEOEFY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=r8T/Zy63pIA/aUXHJcN2DeuaQVO2/yFN+ouQsgxuozGpgenRORopp5X5ECaD1cpd1
	 LPabSG2MCDKDVFoN9MvbPcYJ6xGnB51HdoJOStYUDBMkhMGTaZT7NoKQIMPv8ylycD
	 JueZsE64j4JRY1IoLP7ZnrIzIMfeBBX2H3QW31UUo3GxPp/CR2MrvgqffocC9ISooz
	 JQMzY+OiW58SrxdFMtDqp4PWLaI+++XHmU6cSMEy4cHjo1Bp5oh2lflhV4u81Z++Eo
	 tWCsK+Ub9AOpgKTwgYhKC5DAHM1xK76G0jEvnxQ2w+4EETOYXAvOQyR6mM7l6St6v0
	 JrSEPJbBcUpjQ==
Date: Fri, 1 Apr 2022 16:53:02 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 05/19] xen/arm: mm: Add support for the contiguous
 bit
In-Reply-To: <20220221102218.33785-6-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204011639430.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-6-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> In follow-up patches, we will use xen_pt_update() (or its callers)
> to handle large mappings (e.g. frametable, xenheap). They are also
> not going to be modified once created.
> 
> The page-table entries have an hint to indicate that whether an
> entry is contiguous to another 16 entries (assuming 4KB). When the
> processor support the hint, one TLB entry will be created per
> contiguous region.
> 
> For now this is tied to _PAGE_BLOCK. We can untie it in the future
> if there are use-cases where we may want to use _PAGE_BLOCK without
> setting the contiguous (couldn't think of any yet).
> 
> Note that to avoid extra complexity, mappings with the contiguous
> bit set cannot be removed. Given the expected use, this restriction
> ought to be fine.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v3:
>         - New patch
> ---
>  xen/arch/arm/include/asm/page.h |  4 ++
>  xen/arch/arm/mm.c               | 80 ++++++++++++++++++++++++++++++---
>  2 files changed, 77 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h
> index 07998df47bac..e7cd62190c7f 100644
> --- a/xen/arch/arm/include/asm/page.h
> +++ b/xen/arch/arm/include/asm/page.h
> @@ -70,6 +70,7 @@
>   * [5]   Page present
>   * [6]   Only populate page tables
>   * [7]   Superpage mappings is allowed
> + * [8]   Set contiguous bit (internal flag)
>   */
>  #define PAGE_AI_MASK(x) ((x) & 0x7U)
>  
> @@ -86,6 +87,9 @@
>  #define _PAGE_BLOCK_BIT     7
>  #define _PAGE_BLOCK         (1U << _PAGE_BLOCK_BIT)
>  
> +#define _PAGE_CONTIG_BIT    8
> +#define _PAGE_CONTIG        (1U << _PAGE_CONTIG_BIT)
> +
>  /*
>   * _PAGE_DEVICE and _PAGE_NORMAL are convenience defines. They are not
>   * meant to be used outside of this header.
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 3af69b396bd1..fd16c1541ce2 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1237,6 +1237,8 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt,
>          /* Set permission */
>          pte.pt.ro = PAGE_RO_MASK(flags);
>          pte.pt.xn = PAGE_XN_MASK(flags);
> +        /* Set contiguous bit */
> +        pte.pt.contig = !!(flags & _PAGE_CONTIG);
>      }
>  
>      write_pte(entry, pte);
> @@ -1289,6 +1291,51 @@ static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr,
>       return level;
>  }
>  
> +#define XEN_PT_4K_NR_CONTIG 16
> +
> +/*
> + * Check whether the contiguous bit can be set. Return the number of
> + * contiguous entry allowed. If not allowed, return 1.
> + */
> +static unsigned int xen_pt_check_contig(unsigned long vfn, mfn_t mfn,
> +                                        unsigned int level, unsigned long left,
> +                                        unsigned int flags)
> +{
> +    unsigned long nr_contig;
> +
> +    /*
> +     * Allow the contiguous bit to set when the caller requests block
> +     * mapping.
> +     */
> +    if ( !(flags & _PAGE_BLOCK) )
> +        return 1;
> +
> +    /*
> +     * We don't allow to remove mapping with the contiguous bit set.
> +     * So shortcut the logic and directly return 1.
> +     */
> +    if ( mfn_eq(mfn, INVALID_MFN) )
> +        return 1;
> +
> +    /*
> +     * The number of contiguous entries varies depending on the page
> +     * granularity used. The logic below assumes 4KB.
> +     */
> +    BUILD_BUG_ON(PAGE_SIZE != SZ_4K);
> +
> +    /*
> +     * In order to enable the contiguous bit, we should have enough entries
> +     * to map left and both the virtual and physical address should be
> +     * aligned to the size of 16 translation tables entries.
> +     */
> +    nr_contig = BIT(XEN_PT_LEVEL_ORDER(level), UL) * XEN_PT_4K_NR_CONTIG;
> +
> +    if ( (left < nr_contig) || ((mfn_x(mfn) | vfn) & (nr_contig - 1)) )
> +        return 1;
> +
> +    return XEN_PT_4K_NR_CONTIG;
> +}
> +
>  static DEFINE_SPINLOCK(xen_pt_lock);
>  
>  static int xen_pt_update(unsigned long virt,
> @@ -1322,6 +1369,12 @@ static int xen_pt_update(unsigned long virt,
>          return -EINVAL;
>      }
>  
> +    if ( flags & _PAGE_CONTIG )
> +    {
> +        mm_printk("_PAGE_CONTIG is an internal only flag.\n");
> +        return -EINVAL;
> +    }
> +
>      if ( !IS_ALIGNED(virt, PAGE_SIZE) )
>      {
>          mm_printk("The virtual address is not aligned to the page-size.\n");
> @@ -1333,21 +1386,34 @@ static int xen_pt_update(unsigned long virt,
>      while ( left )
>      {
>          unsigned int order, level;
> +        unsigned int nr_contig;
> +        unsigned int new_flags;
>  
>          level = xen_pt_mapping_level(vfn, mfn, left, flags);
>          order = XEN_PT_LEVEL_ORDER(level);
>  
>          ASSERT(left >= BIT(order, UL));
>  
> -        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level, flags);
> -        if ( rc )
> -            break;
> +        /*
> +         * Check if we can set the contiguous mapping and update the
> +         * flags accordingly.
> +         */
> +        nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags);
> +        new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0);

Here is an optional idea to make the code simpler. We could move the
flags changes (adding/removing _PAGE_CONTIG) to xen_pt_check_contig.
That way, we could remove the inner loop.

xen_pt_check_contig could check if _PAGE_CONTIG is already set and based
on alignment, it should be able to figure out when it needs to be
disabled.

But also this code works as far as I can tell.


> -        vfn += 1U << order;
> -        if ( !mfn_eq(mfn, INVALID_MFN) )
> -            mfn = mfn_add(mfn, 1U << order);
> +        for ( ; nr_contig > 0; nr_contig-- )
> +        {
> +            rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level,
> +                                     new_flags);
> +            if ( rc )
> +                break;
>  
> -        left -= (1U << order);
> +            vfn += 1U << order;
> +            if ( !mfn_eq(mfn, INVALID_MFN) )
> +                mfn = mfn_add(mfn, 1U << order);
> +
> +            left -= (1U << order);
> +        }
>      }
>  
>      /*
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 00:00:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 00:00:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297660.507115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRBu-0002Zx-JC; Sat, 02 Apr 2022 00:00:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297660.507115; Sat, 02 Apr 2022 00:00:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRBu-0002Zq-Ee; Sat, 02 Apr 2022 00:00:30 +0000
Received: by outflank-mailman (input) for mailman id 297660;
 Sat, 02 Apr 2022 00:00:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fP4x=UM=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1naRBt-0002Zk-1j
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 00:00:29 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e718d4e0-b217-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 02:00:27 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id BFC3BB82547;
 Sat,  2 Apr 2022 00:00:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 333A4C340F3;
 Sat,  2 Apr 2022 00:00:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e718d4e0-b217-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648857625;
	bh=dlQZtOV5jRV4NLoI7r62ZxxVGLg4mQ5qQvUr5zJ/zPk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Wro7XjBHnsxwhgC3iiHPUdK1djxtZKwiqB6jUGGmQz7R2g9DZpXIvZWFPi3kGgkgR
	 jwBoaXhTNZp6qNcdmUW5nsz0Ar2zCWwtnKz4oWt8WRNFtZGEfTtn+sYcL68Yhx7XQp
	 Y5j4IoRsuBGHENbUfAnXvTJJJSf5COfDqQWs5NjJ1ZvFJlN7g5qh5hVq9C1RxQ8ktp
	 zStIVc02+g2iegmCucMMLmMPNVzfe1aSOw/l5m3Y8olfgUJ+hq/bRA9ofwSkg4jtXZ
	 KjaFMT8ZD/N1hjgcHCrq3Oohm5pjflbmijeSikZg4NbK9VUaUiHXMCNQ56Fly6RlkE
	 WPOrVizWFKFvQ==
Date: Fri, 1 Apr 2022 17:00:24 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 06/19] xen/arm: mm: Avoid flushing the TLBs when
 mapping are inserted
In-Reply-To: <20220221102218.33785-7-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204011657080.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-7-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Currently, the function xen_pt_update() will flush the TLBs even when
> the mappings are inserted. This is a bit wasteful because we don't
> allow mapping replacement. Even if we were, the flush would need to
> happen earlier because mapping replacement should use Break-Before-Make
> when updating the entry.
> 
> A single call to xen_pt_update() can perform a single action. IOW, it
> is not possible to, for instance, mix inserting and removing mappings.
> Therefore, we can use `flags` to determine what action is performed.
> 
> This change will be particularly help to limit the impact of switching
> boot time mapping to use xen_pt_update().
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v2:
>         - New patch
> ---
>  xen/arch/arm/mm.c | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index fd16c1541ce2..7b4b9de8693e 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1104,7 +1104,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level,
>          /* We should be here with a valid MFN. */
>          ASSERT(!mfn_eq(mfn, INVALID_MFN));
>  
> -        /* We don't allow replacing any valid entry. */
> +        /*
> +         * We don't allow replacing any valid entry.
> +         *
> +         * Note that the function xen_pt_update() relies on this
> +         * assumption and will skip the TLB flush. The function will need
> +         * to be updated if the check is relaxed.
> +         */
>          if ( lpae_is_valid(entry) )
>          {
>              if ( lpae_is_mapping(entry, level) )
> @@ -1417,11 +1423,16 @@ static int xen_pt_update(unsigned long virt,
>      }
>  
>      /*
> -     * Flush the TLBs even in case of failure because we may have
> +     * The TLBs flush can be safely skipped when a mapping is inserted
> +     * as we don't allow mapping replacement (see xen_pt_check_entry()).
> +     *
> +     * For all the other cases, the TLBs will be flushed unconditionally
> +     * even if the mapping has failed. This is because we may have
>       * partially modified the PT. This will prevent any unexpected
>       * behavior afterwards.
>       */
> -    flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);
> +    if ( !(flags & _PAGE_PRESENT) || mfn_eq(mfn, INVALID_MFN) )
> +        flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);

I am trying to think of a care where the following wouldn't be enough
but I cannot come up with one:

   if ( mfn_eq(mfn, INVALID_MFN) )
       flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 00:05:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 00:05:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297664.507125 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRGK-0003DL-47; Sat, 02 Apr 2022 00:05:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297664.507125; Sat, 02 Apr 2022 00:05:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRGK-0003DE-0k; Sat, 02 Apr 2022 00:05:04 +0000
Received: by outflank-mailman (input) for mailman id 297664;
 Sat, 02 Apr 2022 00:05:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fP4x=UM=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1naRGJ-0003D8-0w
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 00:05:03 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8ac3c196-b218-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 02:05:02 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 997C2B82685;
 Sat,  2 Apr 2022 00:05:01 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F30F9C340F3;
 Sat,  2 Apr 2022 00:04:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ac3c196-b218-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648857900;
	bh=0J6Zhn+o6kNrMRjRL8gTyVauJetC1J43Q3OhYx7mxU0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=uuTh8opA//QorLd7qLakXqa4NIfSqjIZebuMUukpyFsPstw+Doto7SlITp9DBwRsf
	 vmHPJjAwIZL0kxeMZ8m1lF1BwYE0ItoZZK+a4FwHbFE5XnZ5xfeEQLCy8d8p0G10sj
	 AgGBoig4dsmgETy+aQ0kGm5nxTuyFsg4M3j4GHi8CequY4SObjJ5O7wDllR3PRS3sO
	 WxxjPKr5+dR4pb8b8JXJVy2anmogqiBaYV/YVfelIZCY2+cQcVP3900l39mwnunwPP
	 5DBZRg6pWM6P0nVeFXcZN3k4tjucHy6pzuAQcmI09+xVw0YGDuvqmUiJmPfJKpMwoz
	 B/bd8qYuOhwMg==
Date: Fri, 1 Apr 2022 17:04:59 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 07/19] xen/arm: mm: Don't open-code Xen PT update in
 remove_early_mappings()
In-Reply-To: <20220221102218.33785-8-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204011700520.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-8-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
> 
> Now that xen_pt_update_entry() is able to deal with different mapping
> size, we can replace the open-coding of the page-tables update by a call
> to modify_xen_mappings().
> 
> As the function is not meant to fail, a BUG_ON() is added to check the
> return.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Nice!


> ---
>     Changes in v2:
>         - Stay consistent with how function name are used in the commit
>         message
>         - Add my AWS signed-off-by
> ---
>  xen/arch/arm/mm.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 7b4b9de8693e..f088a4b2de96 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -599,11 +599,11 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
>  
>  void __init remove_early_mappings(void)
>  {
> -    lpae_t pte = {0};
> -    write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START), pte);
> -    write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START + SZ_2M),
> -              pte);
> -    flush_xen_tlb_range_va(BOOT_FDT_VIRT_START, BOOT_FDT_SLOT_SIZE);
> +    int rc;
> +
> +    rc = modify_xen_mappings(BOOT_FDT_VIRT_START, BOOT_FDT_VIRT_END,
> +                             _PAGE_BLOCK);
> +    BUG_ON(rc);

Am I right that we are actually destroying the mapping, which usually is
done by calling destroy_xen_mappings, but we cannot call
destroy_xen_mappings in this case because it doesn't take a flags
parameter?

If so, then I would add a flags parameter to destroy_xen_mappings
instead of calling modify_xen_mappings just to pass _PAGE_BLOCK.
But I don't feel strongly about it so if you don't feel like making the
change to destroy_xen_mappings, you can add my acked-by here anyway.


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 00:10:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 00:10:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297669.507137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRLg-0004gM-RZ; Sat, 02 Apr 2022 00:10:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297669.507137; Sat, 02 Apr 2022 00:10:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRLg-0004gF-Og; Sat, 02 Apr 2022 00:10:36 +0000
Received: by outflank-mailman (input) for mailman id 297669;
 Sat, 02 Apr 2022 00:10:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fP4x=UM=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1naRLf-0004g9-9b
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 00:10:35 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 509a62a7-b219-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 02:10:33 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 730D9B82571;
 Sat,  2 Apr 2022 00:10:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8300C2BBE4;
 Sat,  2 Apr 2022 00:10:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 509a62a7-b219-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648858232;
	bh=RX90IpVuGlGf+To2nZdQnBDTdysiH26Vn1hg4pdsYlc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=KzA/XevVq27sdAgpzAlJjUbMBB8TaEQjC/6b/H1LaOjmjgVFsuk2ftNXtEmvgQofA
	 YAsxQpT4iR0sl4H3KCcm4PKiHO8gT+amwgywXEiAuOA65R0SiMTP1zprYbJqq338yP
	 jWbD0qTvxb3QHfk1TfffxEJX2wDjkwncaS5boccwwwdVnLooqzciA653YfsHhENtBG
	 NIWBLfzZQWQZAoyqytl1FryzzqeVC3bLrLH0XJ4SWla2aIH3FgdjKZKUIpCzFwnchI
	 uBgRdQLfy4K0aCWLmM6eCI3xZr/sZtwRLJE8VWBQ6dAhs9TMhy68Mx5h/30o8bhO+o
	 1e69W9SpH1C0Q==
Date: Fri, 1 Apr 2022 17:10:30 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 08/19] xen/arm: mm: Re-implement early_fdt_map() using
 map_pages_to_xen()
In-Reply-To: <20220221102218.33785-9-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204011709140.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-9-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
> 
> Now that map_pages_to_xen() has been extended to support 2MB mappings,
> we can replace the create_mappings() calls by map_pages_to_xen() calls.
> 
> The mapping can also be marked read-only has Xen as no business to
> modify the host Device Tree.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v2:
>         - Add my AWS signed-off-by
>         - Fix typo in the commit message
> ---
>  xen/arch/arm/mm.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index f088a4b2de96..24de8dcb9042 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -559,6 +559,7 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
>      paddr_t offset;
>      void *fdt_virt;
>      uint32_t size;
> +    int rc;
>  
>      /*
>       * Check whether the physical FDT address is set and meets the minimum
> @@ -574,8 +575,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
>      /* The FDT is mapped using 2MB superpage */
>      BUILD_BUG_ON(BOOT_FDT_VIRT_START % SZ_2M);
>  
> -    create_mappings(xen_second, BOOT_FDT_VIRT_START, paddr_to_pfn(base_paddr),
> -                    SZ_2M >> PAGE_SHIFT, SZ_2M);
> +    rc = map_pages_to_xen(BOOT_FDT_VIRT_START, maddr_to_mfn(base_paddr),
> +                          SZ_2M >> PAGE_SHIFT,
> +                          PAGE_HYPERVISOR_RO | _PAGE_BLOCK);
> +    if ( rc )
> +        panic("Unable to map the device-tree.\n");
> +
>  
>      offset = fdt_paddr % SECOND_SIZE;
>      fdt_virt = (void *)BOOT_FDT_VIRT_START + offset;
> @@ -589,9 +594,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
>  
>      if ( (offset + size) > SZ_2M )
>      {
> -        create_mappings(xen_second, BOOT_FDT_VIRT_START + SZ_2M,
> -                        paddr_to_pfn(base_paddr + SZ_2M),
> -                        SZ_2M >> PAGE_SHIFT, SZ_2M);
> +        rc = map_pages_to_xen(BOOT_FDT_VIRT_START + SZ_2M,
> +                              maddr_to_mfn(base_paddr + SZ_2M),
> +                              SZ_2M >> PAGE_SHIFT,
> +                              PAGE_HYPERVISOR_RO | _PAGE_BLOCK);
> +        if ( rc )
> +            panic("Unable to map the device-tree\n");
>      }

Very good! :-)

I have a small preference for making the change to PAGE_HYPERVISOR_RO in
a separate patch because it would make it easier to revert in the
future if we need so (e.g. overlays...). But it is OK either way.


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 00:11:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 00:11:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297672.507148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRMw-0005Gr-5M; Sat, 02 Apr 2022 00:11:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297672.507148; Sat, 02 Apr 2022 00:11:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRMw-0005Gk-2O; Sat, 02 Apr 2022 00:11:54 +0000
Received: by outflank-mailman (input) for mailman id 297672;
 Sat, 02 Apr 2022 00:11:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fP4x=UM=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1naRMu-0005Ga-9S
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 00:11:52 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7ed771ea-b219-11ec-8fbc-03012f2f19d4;
 Sat, 02 Apr 2022 02:11:51 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2C6CBB82546;
 Sat,  2 Apr 2022 00:11:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E2E8C340F3;
 Sat,  2 Apr 2022 00:11:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ed771ea-b219-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1648858310;
	bh=ZncpQXriffTsBcXDYEAF8w1S2EddhxC1L2df4BKu25s=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=iAF0xYhkJLW2fGDGi+zpywnkbCwO5CiVo5NpIxDjMLWHKet/EOT+uLJZTcaVHBlqs
	 ip6czu53WThm6+dZff3X88VRPKDhztPS0VRI6ZAHcH6QPWoAYviCmpp6PurGkcRdSn
	 qdX0Kag8y4Yl3pqZVOviwDzcW95tiAankPYmjJz6zCgKS4d0iP6XHxD3qVyQ/tMBIW
	 3H6jxM77V/FMz6beS2qQ2pbZCc0LJJ6vmmUdJFCtCrbiPqVPxmqBgDB+GCJgo2v25X
	 WqtQ2Xs6SwjJuIvF96kFwWMHXSfPQdJHJ0xX3e6FoLR8wYoVBq0vPcn0T44umPL9tu
	 OnsyVM34flf/w==
Date: Fri, 1 Apr 2022 17:11:48 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 10/19] xen/arm32: mm: Re-implement setup_xenheap_mappings()
 using map_pages_to_xen()
In-Reply-To: <20220221102218.33785-11-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204011711290.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-11-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Now that map_pages_to_xen() has been extended to support 2MB mappings,
> we can replace the create_mappings() call by map_pages_to_xen() call.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>     Changes in v3:
>         - Fix build when CONFIG_DEBUG=y
> 
>     Changes in v2:
>         - New patch
> 
>     TODOs:
>         - add support for contiguous mapping
> ---
>  xen/arch/arm/mm.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index f18f65745595..1e5c2c45dcf9 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -809,7 +809,12 @@ void mmu_init_secondary_cpu(void)
>  void __init setup_xenheap_mappings(unsigned long base_mfn,
>                                     unsigned long nr_mfns)
>  {
> -    create_mappings(xen_second, XENHEAP_VIRT_START, base_mfn, nr_mfns, MB(32));
> +    int rc;
> +
> +    rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns,
> +                          PAGE_HYPERVISOR_RW | _PAGE_BLOCK);
> +    if ( rc )
> +        panic("Unable to setup the xenheap mappings.\n");
>  
>      /* Record where the xenheap is, for translation routines. */
>      xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE;
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 00:44:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 00:44:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297677.507159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRsT-00005p-NT; Sat, 02 Apr 2022 00:44:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297677.507159; Sat, 02 Apr 2022 00:44:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naRsT-00005i-KS; Sat, 02 Apr 2022 00:44:29 +0000
Received: by outflank-mailman (input) for mailman id 297677;
 Sat, 02 Apr 2022 00:44:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naRsS-00005X-0W; Sat, 02 Apr 2022 00:44:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naRsR-0001rm-R4; Sat, 02 Apr 2022 00:44:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naRsR-0000Yw-I5; Sat, 02 Apr 2022 00:44:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naRsR-0004B4-Hb; Sat, 02 Apr 2022 00:44:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oA6+EODHNKONrg4oUeW2WNZuIp9BfnQS7UFbDCaGfiY=; b=DfFumE1UZjZcc/oaUcUBhxo1pz
	b0zRmCtF7fZtfYEW0LWfy/KOITCmXZL4FlRQncI7XcscfPut8bTSTY/YP8lgWbJGMbDnG/IWJ4706
	Z3OH/H3gYiiIKo91Yas9Qnw6IcgYl7/YgY8qpqgKmP/+VIhzkFn7VomzMy7bF2T1kg04=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169100-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169100: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e8b767f5e04097aaedcd6e06e2270f9fe5282696
X-Osstest-Versions-That:
    linux=787af64d05cd528aac9ad16752d11bb1c6061bb9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 00:44:27 +0000

flight 169100 linux-linus real [real]
flight 169121 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169100/
http://logs.test-lab.xenproject.org/osstest/logs/169121/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-qcow2  8 xen-boot          fail pass in 169121-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail in 169121 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169055
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169055
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169055
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169055
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169055
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169055
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169055
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169055
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                e8b767f5e04097aaedcd6e06e2270f9fe5282696
baseline version:
 linux                787af64d05cd528aac9ad16752d11bb1c6061bb9

Last test of basis   169055  2022-03-31 02:32:32 Z    1 days
Testing same since   169100  2022-04-01 04:55:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akira Yokosawa <akiyks@gmail.com>
  Alexander Lobakin <alexandr.lobakin@intel.com>
  Alexei Starovoitov <ast@kernel.org>
  Alistair Francis <alistair@alistair23.me>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Andrew Price <anprice@redhat.com>
  Andrii Nakryiko <andrii@kernel.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anton Ivanov <anton.ivanov@cambridgegreys.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Baokun Li <libaokun1@huawei.com>
  Benjamin Beichler <benjamin.beichler@uni-rostock.de>
  Bhupesh Sharma <bhupesh.sharma@linaro.org>
  Bob Peterson <rpeterso@redhat.com>
  Borislav Petkov <bp@suse.de>
  Brendan Higgins <brendanhiggins@google.com>
  Changbin Du <changbin.du@gmail.com>
  Chris Packham <chris.packham@alliedtelesis.co.nz>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  David Gow <davidgow@google.com>
  David Hildenbrand <david@redhat.com>
  David Howells <dhowells@redhat.com>
  Derek Will <derekrobertwill@gmail.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eduardo Valentin <eduval@amazon.com>
  Eduardo Valentin <evalenti@kernel.org>
  Eelco Chaudron <echaudro@redhat.com>
  Eli Cohen <elic@nvidia.com>
  Elliot Berman <quic_eberman@quicinc.com>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frédéric Danis <frederic.danis@collabora.com>
  Gautam Dawar <gautam.dawar@xilinx.com>
  Gautam Dawar <gdawar@xilinx.com>
  Gavin Shan <gshan@redhat.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Geliang Tang <geliang.tang@suse.com>
  Glenn Washburn <development@efficientek.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Hangyu Hua <hbh25y@gmail.com>
  Herbert Xu <herbert@gondor.apana.org.au>
  hongnanli <hongnan.li@linux.alibaba.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  Jakub Kicinski <kuba@kernel.org>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <jasowang@redhat.com>
  Jean Delvare <jdelvare@suse.de>
  Jeff Layton <jlayton@kernel.org>
  Jeff Layton <jlayton@redhat.com>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jiri Olsa <jolsa@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Jonathan Corbet <corbet@lwn.net>
  Jonathan Lemon <jonathan.lemon@gmail.com>
  Kees Cook <keescook@chromium.org>
  Keir Fraser <keirf@google.com>
  KP Singh <kpsingh@kernel.org>
  lei he <helei.sig11@bytedance.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Longpeng &lt;<a href="mailto:longpeng2@huawei.com" target="_blank">longpeng2@huawei.com</a>&gt;<br>
  Longpeng &lt;<a href="mailto:longpeng2@huawei.com" target="_blank">longpeng2@huawei.com</a>&gt;<br></blockquote><div><br></div><div>Acked-by: Jason Wang &lt;<a href="mailto:jasowang@redhat.com">jasowang@redhat.com</a>&gt;</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
  Longpeng <longpeng2@huawei.com>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Magnus Karlsson <magnus.karlsson@intel.com>
  Marc Dionne <marc.dionne@auristor.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Martin Habets <habetsm.xilinx@gmail.com>
  Martin KaFai Lau <kafai@fb.com>
  Martin Varghese <martin.varghese@nokia.com>
  Masahiro Yamada <masahiroy@kernel.org>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Miaohe Lin <linmiaohe@huawei.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Kelley <mikelley@microsoft.com>
  Michael Qiu <qiudayu@archeros.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Walle <michael@walle.cc>
  Miguel Ojeda <ojeda@kernel.org>
  Milan Landaverde <milan@mdaverde.com>
  Nathan Chancellor <nathan@kernel.org>
  Nathan Chancellor <nathan@kernel.org> #Kconfig tweaks
  Oliver Hartkopp <socketcan@hartkopp.net>
  Paolo Abeni <pabeni@redhat.com>
  Pavel Skripkin <paskripkin@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Quentin Monnet <quentin@isovalent.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rafał Miłecki <rafal@milecki.pl>
  Randy Dunlap <rdunlap@infradead.org>
  Richard Weinberger <richard@nod.at>
  Rob Herring <robh@kernel.org>
  Robert Richter <rrichter@amd.com>
  Roopa Prabhu <roopa@nvidia.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Stephane Graber <stgraber@ubuntu.com>
  Stéphane Graber <stgraber@ubuntu.com>
  Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
  Terry Bowman <terry.bowman@amd.com>
  Thanh Quan <thanh.quan.xn@renesas.com>
  Tom Rix <trix@redhat.com>
  Vasant Hegde <vasant.hegde@amd.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vinod Koul <vkoul@kernel.org>
  Wang Hai <wanghai38@huawei.com>
  Wim Van Sebroeck <wim@linux-watchdog.org>
  Xiaolong Huang <butterflyhuangxx@gmail.com>
  Xuan Zhuo <xuanzhuo@linux.alibaba.com>
  Yang Li <yang.lee@linux.alibaba.com>
  Yonghong Song <yhs@fb.com>
  Yufeng Mo <moyufeng@huawei.com>
  Yuntao Wang <ytcoode@gmail.com>
  Zheng Yongjun <zhengyongjun3@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zhu Lingshan <lingshan.zhu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               fail    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   787af64d05cd..e8b767f5e040  e8b767f5e04097aaedcd6e06e2270f9fe5282696 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 03:37:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 03:37:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297694.507192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naUZw-000385-ME; Sat, 02 Apr 2022 03:37:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297694.507192; Sat, 02 Apr 2022 03:37:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naUZw-00037e-Ex; Sat, 02 Apr 2022 03:37:32 +0000
Received: by outflank-mailman (input) for mailman id 297694;
 Sat, 02 Apr 2022 03:37:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naUZv-00037U-8K; Sat, 02 Apr 2022 03:37:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naUZv-00082w-5q; Sat, 02 Apr 2022 03:37:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naUZu-00016S-PL; Sat, 02 Apr 2022 03:37:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naUZu-00022e-Or; Sat, 02 Apr 2022 03:37:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qzXLu+svl0iS1CBhczwTN/OJTSSWmNNju3NvgTWpKRM=; b=PfKNF2I9fRM6JKkPI5wBZf7yAB
	k/1kvBlC3yZKSaQy+czzpmEF8mPXXwAtxQZ3z1lLH1rxZyC0f+xSoEHW3Uwgz+tYhzjnouNgCZQmK
	7+vbu+rVSu7pO74U41P601JolpS7zhfGP1zlEbT6YQ1Rr/AbfpaMbmPjbdZRwGBcntmg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169106-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169106: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
X-Osstest-Versions-That:
    xen=8eec96b7b8d937d40e2e7988edb8bbd08598c715
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 03:37:30 +0000

flight 169106 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169106/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 169063

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169063
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169063
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169063
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169063
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169063
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169063
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169063
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169063
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169063
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169063
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169063
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169063
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
baseline version:
 xen                  8eec96b7b8d937d40e2e7988edb8bbd08598c715

Last test of basis   169063  2022-03-31 08:34:51 Z    1 days
Testing same since   169106  2022-04-01 08:47:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8eec96b7b8..e7cfcdc671  e7cfcdc6719d586eb7cdb62d40275a7d17fe6760 -> master


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 05:01:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 05:01:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297731.507243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naVtP-0005SX-SJ; Sat, 02 Apr 2022 05:01:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297731.507243; Sat, 02 Apr 2022 05:01:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naVtP-0005Rw-OH; Sat, 02 Apr 2022 05:01:43 +0000
Received: by outflank-mailman (input) for mailman id 297731;
 Sat, 02 Apr 2022 05:01:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AWb+=UM=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1naVtO-0004va-JL
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 05:01:42 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20618.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::618])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb887925-b241-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 07:01:41 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by AS8PR04MB8216.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sat, 2 Apr
 2022 05:01:39 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%7]) with mapi id 15.20.5123.019; Sat, 2 Apr 2022
 05:01:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb887925-b241-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nj3CUGduk5ot0jE105KOjp0052O9Vy1PW3f9ccCgC85HpKdiUGRqlWdnrEuHOpNrJmpGvuIQLJg3ygsvAtM7mgdYMndlakxoeSreISAO6pjs7kHupJuE17Dac1gC5TsWuYA9KHZhkhwH9U0WBjVxvn0cEmjrP4uKLRfDeFpGo0Niaon7AxJf6uUgIDqwuhy1ZzGzSBkcYDLx5ugo26ZkTY4Guka+e0AUZmz+oPsplgDAa8szSGtdTKaJgN9mAyaKHoNn1SuN98zeVqagypyjVaud64xtZTNYcwD86DjBGqjAhCLWglPNIdBZU9OrokQmMnwRIwuOxgMBtNbO4jWdOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bZ7vGsGi/qcdiA499rbx/Gu1hC5xkAzFrd0s81KB96w=;
 b=jGKOwYEPZBHwZ18LRt1qMU3H/8MT6WMaoeAqSqaFWMhhMG2EZ7xP9CT0+oOVwBF5qqC8bZ+zvl18KjSLqTHsCyRd1XhTujXXF+LknzuBG6EcsQId7zz0SBV24umlQX3lToBIRveu71lY+wY9WTZ5DN2xtb5IK/nuV6OD3cNo9M8baStCG0qO2O6TZOI/ffXXgSASr+s/Y03q41TkpOb+WqGz0h+I6iwmo/nCN9zhbuO3kz1I0xBlYqRB8J/OhbDnrdUb27hmGvp+Jcnd1tpqqkVKwNzRjFPhQQZ9s/9gAXHYQFAhD3yC/QkwwoV01Kd1y53rqVSq8pfBIlZ5aYVm/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bZ7vGsGi/qcdiA499rbx/Gu1hC5xkAzFrd0s81KB96w=;
 b=Vr6SEz296WNMC6BirVhoYFQfRkprpqxBQ+Y3u4TkWGQcHQMG8/8hSgnxODDTPglb/OECMFBF2M6w1vIJ4zxofuAnrLjC0CirVftYiIlC7wSyBH9wepmQNckq3ikWRIoVbh1elR+stlVyQbeL8B7qNf8NtMHQpLYroP8iFWCadFQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2 2/2] xen/arm: Add i.MX lpuart early printk support
Date: Sat,  2 Apr 2022 13:42:23 +0800
Message-Id: <20220402054223.10304-3-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220402054223.10304-1-peng.fan@oss.nxp.com>
References: <20220402054223.10304-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR01CA0006.apcprd01.prod.exchangelabs.com
 (2603:1096:4:191::14) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 87476c74-8e9f-4a85-cb55-08da1465de3f
X-MS-TrafficTypeDiagnostic: AS8PR04MB8216:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8216E3C62BB0CB2653E8956EC9E39@AS8PR04MB8216.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BAf+AJp8kSVdVR9JUnWaJcJdOb043PDlkYNGYBfzgkDkKXpIow2JiB3yinctFoI1HthXMTVgGLKi+5W7gLgcjdj6IljtW+FS3Xn7F4q4PabkRBdDbpfrRNoKuEhwPO/bbOfT/KOoyh5WPgt/EPgGJMEDdL1Z7eo+Ut4O0wLfD8VxLY1R/VCCqKItazyD6wucHCijsp28ZH7ufxifVq7pyhRIIN3+5buXlcCazsIvzlyFE//Oi/DjH6qtgPMbgAsLfI9VX4Os1oKUVnRqizS84XC6aKWfpgGidQp+deSzce9uz+L+PcUnNOyUTev2QP0H7ot1RDbrKYJnNR0JRMmEq9IJ5xeIvDrCujoYhBsdERo+X1fKFly8JTDUvcuyi9OSOwktgIMIyusI+FH6tNGnLvi9GqaBMQ9G/U/Nw97NB0j5FZB1/lIqrUq6GUTRlt7LQBZLk7Nsb0w8NEJfYabqOVyXYh+qC4SLllI6fObZ119pgCdXTmO2jnltHMF8V6jehX9HX4oR4PuUFIv+Mqb9H5eh/u/gjT0qIv0tM03caWaJJ5pMTmPmr2hMgHUEHZli/wL1l8tKZsQ3sFaWQ3P630SqkvYuOuybGHe+hkXWIeD1LcmvKBMhHXKVYcG+CFEZ/nNjgi0PMVjydNwcx1SdbAicA5ES8+IgMbQJv/M3+/HHMuq/m09UfhN7gSMpv03WDVBohvycBw82Bl3upzdWfv+W5QnNv1BE5Ft6x1VE2EE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(4326008)(6486002)(508600001)(38100700002)(38350700002)(66946007)(8676002)(66476007)(6666004)(66556008)(8936002)(5660300002)(86362001)(316002)(2616005)(1076003)(6512007)(6506007)(186003)(52116002)(26005)(2906002)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?W9OykXa89z5gsBIQ+K+4LzOtzAvr/4ejlUTceOf/CzG6YGX6KUJk74QR687y?=
 =?us-ascii?Q?Faj8f+eBYufnztGndvukGmKRFhOVLDr+g3cofFFCUCzKerxmbmlnxb4/5VmW?=
 =?us-ascii?Q?Ma9DjEyzTWG8betT592e0kE0oiJwzDn1pZm/U4ya31Hh0wJ8M007LPMSnr0R?=
 =?us-ascii?Q?d3GxX6eLfZUAmk/WFpyDdLrOC7qaqJYzSRofiqvib6jWpSvfr52IT2g5tz3P?=
 =?us-ascii?Q?U86hIFS5A238G9Y1eXHszR9yHk/KK+/nzJgwn36jJcX6WNMfgwVZaAzThB9H?=
 =?us-ascii?Q?peaV/bBbUR0nftzcR4vbgjjZZ9KnV4ybe5R/A/60/kXqB7W6L8O+Pr6D5Xyv?=
 =?us-ascii?Q?UIkAt+i9bRoip+EsRlB4Kksc52xx57Xx6OcTy5/7BWdj93zd0cnZhQGDMijY?=
 =?us-ascii?Q?Q2abTMan95xUhxl1xJKP8hgUznD6APyitM888Zbe/y6+TrsbRyurhUWl4bZo?=
 =?us-ascii?Q?xqwcdE48SsRZ7+CC36B0PEoY1crT+uW5ahBMwoCGE8/ZNFUT5FXv/Z6ot59L?=
 =?us-ascii?Q?JMLcA0SKzITiebJ3A7eweDAoDbfFlfGCCh/FO8zYapfesd+r+6fQO5GxitP+?=
 =?us-ascii?Q?sAnVwrfw7IH7hbY+qXk/p+JPmwX3w6Tu4OMh17ZBEdIb5bSIidmVzYngH4Hb?=
 =?us-ascii?Q?zJNyXXOdxDQZW8rRxNqpzwPiwiS6roBpt4oUzFS8goaJPn4qcyV//FRxqrUK?=
 =?us-ascii?Q?1ysHDwXbu/XwiJydMoX8vmRyGw6ciEx/mRds96AgmJmvLVW37RW8EZaqeqEP?=
 =?us-ascii?Q?lXalPEYVjvXV4W4qX8xpJQQfgxq2Di2keytDnpKlBVeSJfLHfDRxl0GiaEla?=
 =?us-ascii?Q?99l+snA1rA+JiRFAOMjHhHbym3BZaLhjOeCqu7dF2XTpvdLKIBtrs77k9+u+?=
 =?us-ascii?Q?n/78019yyy+ziKqRYIe9lYfHg3TK12MBRnp48GsnaidFJM6rDR/+6BzdgVPI?=
 =?us-ascii?Q?fx9KOklNHKPp9Ye9GHgSOki2uVgOREg2qU2QmVr9SgQ5d2KVhY0QgROn3VKw?=
 =?us-ascii?Q?BMJEYLGZ+HUn2NR214nyn8ETYYFBCe352n6JzipZsaq3fa7wJO+Gyp35EaSP?=
 =?us-ascii?Q?pbi71dGfcCNdicSnfaDHVkIToOhET6Qf3Sehh7YMbe4oBzaCUVtHzJXQedA7?=
 =?us-ascii?Q?M3xN14jKpNH0M363D3pSeZjPsLuPm7rd978rCm4Zg7T9cUw9hbO2jRyxkhp7?=
 =?us-ascii?Q?xKd64RiIike5+2FrYby6l2JjPthWX9gvFt8gGI9UjuqUzpuyQARWA2bD8yAa?=
 =?us-ascii?Q?ujqqJiMsAjVN2n430aRaUDqTmlnRaNPqW5Ket+98Oma6JEz6QP1haq7Vacz1?=
 =?us-ascii?Q?IeDAKjh7ag+v6h9ewJ2H37+T3ooEAZDjFZEC1J5c10o9ci6IkLCuX27fD6Qc?=
 =?us-ascii?Q?pt04bsKSqjhmRiVB0x3Z755U+Q7dYOVDr9e0SrbUvur7CUmNAZiU5j8nVCND?=
 =?us-ascii?Q?7wAD5X770ft/aIUPcUGDs5HfEQjajHRfGmIgKKKERytJPLi5BW1B2ZWx4dre?=
 =?us-ascii?Q?dIOyBDXxd2x7L+YO/Lk2nIfm072MmhpdU2nvMz7NOqo3wokcdspB0A0r5inU?=
 =?us-ascii?Q?wK4RBMvLV2e08YBZJHx6BELXCWrP6THKYso75gwya/ugf405bsxrLWXtNruX?=
 =?us-ascii?Q?GtOyU2vWW2JtJHSZ+3+wjBkgAiBqzyfAl4iaq9EmEyA3v04HdtVsw0iqDB1D?=
 =?us-ascii?Q?kiReMZ7q/ayMldTrpjGL9i7V+g9ijz/piKfPwROmZqtTLq8EUksQUFykDYT7?=
 =?us-ascii?Q?YCdQdzErmg=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87476c74-8e9f-4a85-cb55-08da1465de3f
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 05:01:38.9019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qzvpz8bPE0Cdn2PPG/lSGdmXll18WJBgX+lDINEYV+xZudQYvjhUtpwndRddNHSQXcobZonx/k2XEYbUDw8EPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8216

From: Peng Fan <peng.fan@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/Kconfig.debug              | 14 +++++++
 xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 +++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index 35ccd13273..842d768280 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -58,6 +58,16 @@ choice
 			This option is preferred over the platform specific
 			options; the platform specific options are deprecated
 			and will soon be removed.
+	config EARLY_UART_CHOICE_IMX_LPUART
+		select EARLY_UART_IMX_LPUART
+		depends on ARM_64
+		bool "Early printk via i.MX LPUART"
+		help
+			Say Y here if you wish the early printk to direct their
+			output to a i.MX LPUART. You can use this option to
+			provide the parameters for the i.MX LPUART rather than
+			selecting one of the platform specific options below if
+			you know the parameters for the port.
 	config EARLY_UART_CHOICE_MESON
 		select EARLY_UART_MESON
 		depends on ARM_64
@@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
 config EARLY_UART_EXYNOS4210
 	select EARLY_PRINTK
 	bool
+config EARLY_UART_IMX_LPUART
+	select EARLY_PRINTK
+	bool
 config EARLY_UART_MESON
 	select EARLY_PRINTK
 	bool
@@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
 	default "debug-8250.inc" if EARLY_UART_8250
 	default "debug-cadence.inc" if EARLY_UART_CADENCE
 	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
+	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
 	default "debug-meson.inc" if EARLY_UART_MESON
 	default "debug-mvebu.inc" if EARLY_UART_MVEBU
 	default "debug-pl011.inc" if EARLY_UART_PL011
diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
new file mode 100644
index 0000000000..f7ac78a781
--- /dev/null
+++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
@@ -0,0 +1,52 @@
+/*
+ * xen/arch/arm/arm64/debug-imx8qm.inc
+ *
+ * i.MX8QM specific debug code
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright (C) 2016 Freescale Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/imx-lpuart.h>
+
+.macro early_uart_init wb wc wd
+/* Already initialized in bootloader */
+.endm
+
+/*
+ * Wait LPUART to be ready to transmit
+ * rb: register which contains the UART base address
+ * rc: scratch register
+ */
+.macro early_uart_ready xb, c
+1:
+        ldr   w\c, [\xb, #UARTSTAT]   /* <- Flag register */
+        tst   w\c, #UARTSTAT_TDRE     /* Check FIFO EMPTY bit */
+        beq   1b                      /* Wait for the UART to be ready */
+.endm
+
+/*
+ * LPUART transmit character
+ * rb: register which contains the UART base address
+ * rt: register which contains the character to transmit
+ */
+.macro early_uart_transmit xb, wt
+        str   \wt, [\xb, #UARTDATA]  /* -> Data Register */
+.endm
+
+/*
+ * Local variables:
+ * mode: ASM
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sat Apr 02 05:01:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 05:01:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297730.507232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naVtO-0005C0-Jk; Sat, 02 Apr 2022 05:01:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297730.507232; Sat, 02 Apr 2022 05:01:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naVtO-0005Bt-GJ; Sat, 02 Apr 2022 05:01:42 +0000
Received: by outflank-mailman (input) for mailman id 297730;
 Sat, 02 Apr 2022 05:01:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AWb+=UM=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1naVtM-00057y-KR
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 05:01:40 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2062b.outbound.protection.outlook.com
 [2a01:111:f400:7d00::62b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f92749f9-b241-11ec-8fbc-03012f2f19d4;
 Sat, 02 Apr 2022 07:01:37 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by AS8PR04MB8216.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sat, 2 Apr
 2022 05:01:34 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%7]) with mapi id 15.20.5123.019; Sat, 2 Apr 2022
 05:01:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f92749f9-b241-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nCsJp3Q4//LivpClXOhZox1fILM/2EBV5GSI1hn95wsGHb+xAZJO2geRkrc+yrfYKlOMArqtxStM/+M0uabhomOS3YBREcAaENRiYl95Mm0PQKcD8nFCcf3QqQ8MeAfOL6f/24Ol0N/ryqEEqqTUYAvelEnjKh0WSabovb9w8ja2YkmJE3y1AHRd68Hk97ky1FzZL/tmYlGdUJHRxYOWMAb7XyuTDOQ+nAqlOE0yejI3sPTD1AWrsSfDbTkJiFbVKRMDSIj/bBtzEN9ovofhlz7HCduKRXoABif+lLM0MHFoq7MqpYKc4GlLJaLWl20Ux9cmScTCTWKcqAqkkg9MTw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=l44XwJrGDUd0FHxAB5NlNEEDFe2NDZEr2lOA2fO6lwo=;
 b=hHnPeWpFEeTEFcPjjR9sKRZcQw8usgwe0JhEA6esd9BLwIExJE46PG6PzWD+flRRjefP3i1dV13/08X3uEyWXUqF+w+jc3Edq4Xlt0ut0EJI2IbESrjBDcS5Tx0yi9K1z0rk3L4EHPJbt2nLYkE4FxR13PxLvGBObWlMPb0aA/Q5wVcfYYbtyw5xqlbLLo7pCeFyme4Af5Spd050MmncKFDNzmT+yBdIVyUmDmisDuhc0QCwPJWY4qcJhQeojyD1g/tQxrDA3JlnpIgVGin9SxG+pbVdx1veFc39stG3dtm1xcwI5ti9LstwSYGt2KE9Xqhq6XpaPfsmOwZ/HrVRaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=l44XwJrGDUd0FHxAB5NlNEEDFe2NDZEr2lOA2fO6lwo=;
 b=V7WEMDBrkud/kwQoEE8dWOfhhKa8lkWCbYtYofkyDqRRJftPxZlov1nFnvl3aLygn2a+iPuIudnkjwK62SXhm6sV7ZgK+q4ymrwXx5CXmeNSHKd0lgrx9hcBvKl8DpN82b47a9ybiUMrijpwzjEiud0PpXzxUvxbOHvr+vBlenM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
Date: Sat,  2 Apr 2022 13:42:22 +0800
Message-Id: <20220402054223.10304-2-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220402054223.10304-1-peng.fan@oss.nxp.com>
References: <20220402054223.10304-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR01CA0006.apcprd01.prod.exchangelabs.com
 (2603:1096:4:191::14) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cbeb6163-8925-4f41-636e-08da1465dbf7
X-MS-TrafficTypeDiagnostic: AS8PR04MB8216:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB82163A9C8EA6EA507A21B3CCC9E39@AS8PR04MB8216.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LnEto3lkIuJOZoBoahJYDrWV6s4T+GaWvrLawb6qU0fFtHwdvF67zY2o1wgg+x49AgQghq610GOw4GSkhQLMj6XeBz4fP7KagWq+jOqRsHebIzKLKH3kZP1TH2buPAjosX+J+6MmXYX7H1/BqcX+IPqlnTbIFeRuW7Js2fvkm381NX/KjWVMTZVSACXhmi6jWcObcpBqrFux3kshAzxNMyiWZ7mY+NcgFYq4CLUuUD7aq5ZaWkPEczKSvNVodinjS2nqFSQzybEJRFXfsO6ri7OtVI3rDuQt/bT5uBVfWKB2aNMr/QFhWo1mI3PygKMsWx2ombjxNq4zYLmarPi/v9UXjcZgXyS+8g0nlSIKHXeEaYkVpHVgun332h9XibcbTKJLSnxDffz11+oEzOu1on5rv3eF16feyotABJYbiUPHCduBW6R/VNY/6qfEhNTvB9C6x/Zf//ZxezS+Rkn9PIE9zTI+TVrfRf0aonF3ileTk9JUBBZKmwcmcbFu7zT9G91n5IMpSZlIBLjWrwJ3RJW7GK20VtXH+wgPmpPDPvTPE4/r36LGFGnsG2Wa08ceDL0+TJoNOAAJiEdyEFer53QoORd6zLxrEhTGBT08r/WDlQB1UvAijPANR8Dsr4JTLBuL3/oJioXheAZBE5JX8vRaayB0kWpdSv7yoepDyMIokxjmYIhmDDO6h7rB2KxGnqbPQVVU4GiBaq5lr4+32sDuYpDSE/7DFmpWTkcHWONWQSe0Fy1Wjd6EOSxm3uDAUBOLnGhLaBOUUE9CnoYripj3xK/v5PV2UYLM8x6ekYvwVgnwtnsnfva0503StXft
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(4326008)(6486002)(508600001)(30864003)(966005)(38100700002)(38350700002)(66946007)(8676002)(66476007)(6666004)(66556008)(8936002)(5660300002)(86362001)(316002)(2616005)(1076003)(6512007)(6506007)(186003)(52116002)(26005)(2906002)(83380400001)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BDPFtElNHI0ZjbzWTilvJ16VFu8QbyAfaS89SlG2FsD827LWCiONzDCnbTB3?=
 =?us-ascii?Q?6AgnHS7XHehIExY3ldQIMagx2JYntAeV1whFVK/ujni92rGxbpiZxQvyBhau?=
 =?us-ascii?Q?MAtrYAgBwtg8948j7aryfFUUzjhn+hDHS/mwLNf8Ku8Y6i8KTMNjqV15YZ+z?=
 =?us-ascii?Q?gMeadtdgkOPT/epo9X146jMXkkyEdR4kzHN4VAzUO4XWyKaQA9JbxXp62s+0?=
 =?us-ascii?Q?s7sT3Ss/DE2M6eCxMcd7ZqgZK4dami2C53/lfOboI7bYsTc/WXH/nettWTg4?=
 =?us-ascii?Q?lWlJS+O6NFsY2aYklL5kJkwn2jrSvk3jm2DUpZaSxW6452fqbJhmPZJvv1HA?=
 =?us-ascii?Q?bi5RUHF7M37kQMRwNNLETXGtoI+zzXuTC0sPk75xP51IjV8mLbzNKnhhgAdG?=
 =?us-ascii?Q?PJlWqbqWz0IsgZnG69uG9F0XGqalWvmEr/9BAN/jGuqIUHlhqGg9uVI7RGfH?=
 =?us-ascii?Q?pLfbFxeVpxy+Nsngvkk/jO2B6Okwg/3P7rF8vfIt20zFv9z+hkOncGzh86oH?=
 =?us-ascii?Q?pwKNdHQG9OEgigW0ZUgrCUuHTFsfuwG7Y7ItbeWewHZenrXrlnbf4V8QiNWc?=
 =?us-ascii?Q?vYLcGiPHCiTanIYATWa1HXfU2mVZHvy5xmQuoIYF3HgkNv+/wmYQ0oAzRw/W?=
 =?us-ascii?Q?kJxqvz2GDoaTdTvQmhM8DLf3sgsm/WJPf68psnROhszAr622xtJnWx7OWXyI?=
 =?us-ascii?Q?eyLi6dEL91NGoX3q/V5uUnKBFfznuZ5w2NizeMxCzrBIXnXspa9eOH4OzOcw?=
 =?us-ascii?Q?/c+8Aga5bgB1Qv3pgVYVNRU3H3LzqKjMOVRFPYjEUvQW6L8yTrsdVXJ03l3/?=
 =?us-ascii?Q?0ayEY5MO9mTFKLg1gd5BCilfLKOrCedMyTCnuQDlneGQbjrW4pStEoaSoVT/?=
 =?us-ascii?Q?N9tT9Oev/cAnEgi9nCK/9+s68C7hKCK39YdLeeIksSVWu4ZnQ1T1qOotA4TK?=
 =?us-ascii?Q?EPef/8tDiWHUuu2T4G0rx8x7S/PQqrxw0GQLoRPttedp1kUUAs3AAGR363pu?=
 =?us-ascii?Q?NNQH/fB6lbpIcttIxtVaF2o52Zomv6KYaGpa/nUdgMbpTw5xJbA070uVWLhD?=
 =?us-ascii?Q?NNCQlBAIHJpL6rRQg9nptVOfXXySWZ6LJpI83JxtBbGjkKvpul0DVDg21VXj?=
 =?us-ascii?Q?2mDedDZSy5JJ4bqVKeHTuY4QdvODGdHvnf946IaSk9bZPSqu0eOvieJvd+rR?=
 =?us-ascii?Q?r+vpHjzCoOgPqQky7aLb97mDg5UHOLGQUQYPPkGmrVaDbkWU0DiWMSwDsqgU?=
 =?us-ascii?Q?5jbbRlQmOiriKATZnxQlX6HHy7OOUs+fgWx+UJ/5EUwfnKT74Z5PTFt/Eh5K?=
 =?us-ascii?Q?EyujLV/zOBjfl+8lWhi3c8e2JY3bFLCXbvJr74JBVZhZ3udcyyLrffkKYCvz?=
 =?us-ascii?Q?WOPAQvd+ffM2qMPDLmTMOQ1X/RnF/a0uD5MluNC9jJEiQs8UP9Tprif6FW4n?=
 =?us-ascii?Q?UKv4uD9Ahl9OEA/QuH99gPuGaSMcXmDo3CfFNbaEbI+/Jj7F06PAbWAlJB0E?=
 =?us-ascii?Q?3b+LXRcH1+aFinkBTdUFpLPkU01pAvlqvYJwbVib5gFn9kJsP2sGNVot8TBH?=
 =?us-ascii?Q?/3cx/ioEO7aGcyjzEG7wQ72affQokt6FpZ+07Cbln9IbZjWVjD6xa+P8o2S9?=
 =?us-ascii?Q?I+l2V1WYMkVcJghq1eXC2jfEexD2LREZvMJYEaTlFfflzu3Wfb3+ViXIXNSO?=
 =?us-ascii?Q?MeJeljTnAzhITUtEsOchVzjfH3SY+DrSUKQ1fLdXZm/5300d40zHxMJf7pEo?=
 =?us-ascii?Q?5zszAuCDxw=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbeb6163-8925-4f41-636e-08da1465dbf7
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 05:01:34.4459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iHS/CIdc5jolo6kDa7OL4/RfEewYCtjiizsfDiaspmpVoS93vPDH43kMWc+ZUQLk9jDJM4OzEOdCsl3xh6CArw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8216

From: Peng Fan <peng.fan@nxp.com>

The i.MX LPUART Documentation:
https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
Chatper 13.6 Low Power Universal Asynchronous Receiver/
Transmitter (LPUART)

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/drivers/char/Kconfig      |   8 +
 xen/drivers/char/Makefile     |   1 +
 xen/drivers/char/imx-lpuart.c | 275 ++++++++++++++++++++++++++++++++++
 xen/include/xen/imx-lpuart.h  |  64 ++++++++
 4 files changed, 348 insertions(+)
 create mode 100644 xen/drivers/char/imx-lpuart.c
 create mode 100644 xen/include/xen/imx-lpuart.h

diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index 2ff5b288e2..0efdb2128f 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -13,6 +13,14 @@ config HAS_CADENCE_UART
 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
 	  based board, say Y.
 
+config HAS_IMX_LPUART
+	bool "i.MX LPUART driver"
+	default y
+	depends on ARM_64
+	help
+	  This selects the i.MX LPUART. If you have a i.MX8QM based board,
+	  say Y.
+
 config HAS_MVEBU
 	bool "Marvell MVEBU UART driver"
 	default y
diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
index 7c646d771c..14e67cf072 100644
--- a/xen/drivers/char/Makefile
+++ b/xen/drivers/char/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o
 obj-$(CONFIG_HAS_OMAP) += omap-uart.o
 obj-$(CONFIG_HAS_SCIF) += scif-uart.o
 obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o
+obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o
 obj-$(CONFIG_ARM) += arm-uart.o
 obj-y += serial.o
 obj-$(CONFIG_XEN_GUEST) += xen_pv_console.o
diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
new file mode 100644
index 0000000000..49330fd2f8
--- /dev/null
+++ b/xen/drivers/char/imx-lpuart.c
@@ -0,0 +1,275 @@
+/*
+ * xen/drivers/char/imx-lpuart.c
+ *
+ * Driver for i.MX LPUART.
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/errno.h>
+#include <xen/imx-lpuart.h>
+#include <xen/init.h>
+#include <xen/irq.h>
+#include <xen/mm.h>
+#include <xen/serial.h>
+#include <asm/device.h>
+#include <asm/io.h>
+
+#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
+#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
+
+static struct imx_lpuart {
+    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
+    uint32_t irq;
+    char __iomem *regs;
+    struct irqaction irqaction;
+    struct vuart_info vuart;
+} imx8_com;
+
+static void imx_lpuart_interrupt(int irq, void *data,
+                                 struct cpu_user_regs *regs)
+{
+    struct serial_port *port = data;
+    struct imx_lpuart *uart = port->uart;
+    uint32_t sts, rxcnt;
+
+    sts = imx_lpuart_read(uart, UARTSTAT);
+    rxcnt = imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
+
+    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
+	    serial_rx_interrupt(port, regs);
+
+    if ( sts & UARTSTAT_TDRE )
+	    serial_tx_interrupt(port, regs);
+
+    imx_lpuart_write(uart, UARTSTAT, sts);
+}
+
+static void __init imx_lpuart_init_preirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t ctrl, old_ctrl, bd;
+
+    ctrl = old_ctrl = imx_lpuart_read(uart, UARTCTRL);
+    ctrl = (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
+    bd = imx_lpuart_read(uart, UARTBAUD);
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
+	    cpu_relax();
+
+    /* Disable transmit and receive */
+    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL_RE));
+
+    /* Reuse firmware baudrate settings, only disable DMA here */
+    bd &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+
+    imx_lpuart_write(uart, UARTMODIR, 0);
+    imx_lpuart_write(uart, UARTBAUD, bd);
+    imx_lpuart_write(uart, UARTCTRL, ctrl);
+}
+
+static void __init imx_lpuart_init_postirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    uart->irqaction.handler = imx_lpuart_interrupt;
+    uart->irqaction.name = "imx_lpuart";
+    uart->irqaction.dev_id = port;
+
+    if ( setup_irq(uart->irq, 0, &uart->irqaction) != 0 )
+    {
+        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
+                uart->irq);
+        return;
+    }
+
+    /* Enable interrupts */
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp |= (UARTCTRL_RIE | UARTCTRL_TIE);
+    temp |= UARTCTRL_ILIE;
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static void imx_lpuart_suspend(struct serial_port *port)
+{
+    BUG();
+}
+
+static void imx_lpuart_resume(struct serial_port *port)
+{
+    BUG();
+}
+
+static int imx_lpuart_tx_ready(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
+}
+
+static void imx_lpuart_putc(struct serial_port *port, char c)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
+        cpu_relax();
+
+    imx_lpuart_write(uart, UARTDATA, c);
+}
+
+static int imx_lpuart_getc(struct serial_port *port, char *pc)
+{
+    struct imx_lpuart *uart = port->uart;
+    int ch;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
+	    return 0;
+
+    ch = imx_lpuart_read(uart, UARTDATA);
+    *pc = ch & 0xff;
+
+    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
+        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
+
+    return 1;
+}
+
+static int __init imx_lpuart_irq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return ((uart->irq > 0) ? uart->irq : -1);
+}
+
+static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return &uart->vuart;
+}
+
+static void imx_lpuart_start_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTSTAT);
+    /* Wait until empty */
+    while ( !(temp & UARTSTAT_TDRE) )
+	    cpu_relax();
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
+}
+
+static void imx_lpuart_stop_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp &= ~(UARTCTRL_TIE | UARTCTRL_TCIE);
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static struct uart_driver __read_mostly imx_lpuart_driver = {
+    .init_preirq = imx_lpuart_init_preirq,
+    .init_postirq = imx_lpuart_init_postirq,
+    .endboot = NULL,
+    .suspend = imx_lpuart_suspend,
+    .resume = imx_lpuart_resume,
+    .tx_ready = imx_lpuart_tx_ready,
+    .putc = imx_lpuart_putc,
+    .getc = imx_lpuart_getc,
+    .irq = imx_lpuart_irq,
+    .start_tx = imx_lpuart_start_tx,
+    .stop_tx = imx_lpuart_stop_tx,
+    .vuart_info = imx_lpuart_vuart_info,
+};
+
+static int __init imx_lpuart_init(struct dt_device_node *dev,
+                                  const void *data)
+{
+    const char *config = data;
+    struct imx_lpuart *uart;
+    int res;
+    u64 addr, size;
+
+    if ( strcmp(config, "") )
+        printk("WARNING: UART configuration is not supported\n");
+
+    uart = &imx8_com;
+
+    uart->baud = 115200;
+    uart->data_bits = 8;
+    uart->parity = 0;
+    uart->stop_bits = 1;
+
+    res = dt_device_get_address(dev, 0, &addr, &size);
+    if ( res )
+    {
+        printk("imx8-lpuart: Unable to retrieve the base"
+               " address of the UART\n");
+        return res;
+    }
+
+    res = platform_get_irq(dev, 0);
+    if ( res < 0 )
+    {
+        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
+        return -EINVAL;
+    }
+    uart->irq = res;
+
+    uart->regs = ioremap_nocache(addr, size);
+    if ( !uart->regs )
+    {
+        printk("imx8-lpuart: Unable to map the UART memory\n");
+        return -ENOMEM;
+    }
+
+    uart->vuart.base_addr = addr;
+    uart->vuart.size = size;
+    uart->vuart.data_off = UARTDATA;
+    /* tmp from uboot */
+    uart->vuart.status_off = UARTSTAT;
+    uart->vuart.status = UARTSTAT_TDRE;
+
+    /* Register with generic serial driver */
+    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
+
+    dt_device_set_used_by(dev, DOMID_XEN);
+
+    return 0;
+}
+
+static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
+{
+    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
+    {},
+};
+
+DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
+    .dt_match = imx_lpuart_dt_compat,
+    .init = imx_lpuart_init,
+DT_DEVICE_END
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/xen/imx-lpuart.h b/xen/include/xen/imx-lpuart.h
new file mode 100644
index 0000000000..945ab1c4fa
--- /dev/null
+++ b/xen/include/xen/imx-lpuart.h
@@ -0,0 +1,64 @@
+/*
+ * xen/include/asm-arm/imx-lpuart.h
+ *
+ * Common constant definition between early printk and the LPUART driver
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ASM_ARM_IMX_LPUART_H
+#define __ASM_ARM_IMX_LPUART_H
+
+/* 32-bit register definition */
+#define UARTBAUD          (0x10)
+#define UARTSTAT          (0x14)
+#define UARTCTRL          (0x18)
+#define UARTDATA          (0x1C)
+#define UARTMATCH         (0x20)
+#define UARTMODIR         (0x24)
+#define UARTFIFO          (0x28)
+#define UARTWATER         (0x2c)
+
+#define UARTSTAT_TDRE     (1 << 23)
+#define UARTSTAT_TC       (1 << 22)
+#define UARTSTAT_RDRF     (1 << 21)
+#define UARTSTAT_OR       (1 << 19)
+
+#define UARTBAUD_OSR_SHIFT (24)
+#define UARTBAUD_OSR_MASK (0x1f)
+#define UARTBAUD_SBR_MASK (0x1fff)
+#define UARTBAUD_BOTHEDGE (0x00020000)
+#define UARTBAUD_TDMAE    (0x00800000)
+#define UARTBAUD_RDMAE    (0x00200000)
+
+#define UARTCTRL_TIE      (1 << 23)
+#define UARTCTRL_TCIE     (1 << 22)
+#define UARTCTRL_RIE      (1 << 21)
+#define UARTCTRL_ILIE     (1 << 20)
+#define UARTCTRL_TE       (1 << 19)
+#define UARTCTRL_RE       (1 << 18)
+#define UARTCTRL_M        (1 << 4)
+
+#define UARTWATER_RXCNT_OFF     24
+
+#endif /* __ASM_ARM_IMX_LPUART_H */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sat Apr 02 05:01:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 05:01:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297729.507221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naVtJ-0004vn-7E; Sat, 02 Apr 2022 05:01:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297729.507221; Sat, 02 Apr 2022 05:01:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naVtJ-0004vg-3y; Sat, 02 Apr 2022 05:01:37 +0000
Received: by outflank-mailman (input) for mailman id 297729;
 Sat, 02 Apr 2022 05:01:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AWb+=UM=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1naVtH-0004va-Lp
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 05:01:35 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20614.outbound.protection.outlook.com
 [2a01:111:f400:7d00::614])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f71fecfa-b241-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 07:01:33 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by AS8PR04MB8216.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sat, 2 Apr
 2022 05:01:30 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%7]) with mapi id 15.20.5123.019; Sat, 2 Apr 2022
 05:01:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f71fecfa-b241-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aBZ2+gimV/Ia5ZdFaaje5vc3O/k9rXlh/5guzwvdfRnJGCLdfb66q4bl720QAn4UDRrHfuUjayontJjEAR5KF4LImQQZHaYdsikcyLrfB07uXfegm4jY6o1r3Us5UGsALCpzohjObtyff4fc76tOTw4IEhOGIhMBh4W1+8lfcE4bexbLHAThM9vCEwMxjSQTUlWrME6itLYale4+7cXiQnSmjh69c9eBeeh57/gEhOi+w6Hth+vpi9eQiyjeZiLnkDykv8XEFUYICX6SpyOth/FhAH+QJQmdnBgPPOkPlHVS/qfH0nGoPYGdOTIBytlzoFjAz5uGSvtvYoN1ea6T3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=t4sphDOEHNfNIqaIxfIem1SDkzqyrrnlsDDHgWUZYA4=;
 b=LcygTlZyMkvtGVHXQXWx2yIkSHCxgVEE/7RFdcYrxdPJybPGeyNQFq0pi741NJ0NUrpVXMdKEP0uRE7pQFYkVJSGe3n3DaPwR+6WNwCyOwHZUEtmGRPGcw3MXTqVKwYEFXXE07CqMsLuyVNK+oOblS8kMAVS5xJXb0fzICCQRVgypdpTwY/4JyP65CVJ9EAbwy92rQji4e38CHq12BYQrfLWiXyEvha7HyvwwTYhk9vMCaOUmhblOf8itMoTTl5pohA0lx5AMmrdhU6vzVWHD04gA3cUXSWLiVJ6NulPbcxZSlx38JbWjBWWYNybz+lHmVWYgfPZi5WnIjilGhSM4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=t4sphDOEHNfNIqaIxfIem1SDkzqyrrnlsDDHgWUZYA4=;
 b=M8yLRRxYUC+/n8eIf46HiDLPqCfhAskIEplVZC/9Gu37f9xNbxJaORQaKvGziNKc99eh13YZ0zNE+re07UNGL/d3rjyQL2NJ1H16cNEhpVGRApBHuKt0EFavXfBwBN0yOH7qhIG5v2Xg5zJ/N1Nxk3OxRCfni0+K6r2gnQKd1OQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial support
Date: Sat,  2 Apr 2022 13:42:21 +0800
Message-Id: <20220402054223.10304-1-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR01CA0006.apcprd01.prod.exchangelabs.com
 (2603:1096:4:191::14) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9090d4ee-b67d-46f2-0a95-08da1465d914
X-MS-TrafficTypeDiagnostic: AS8PR04MB8216:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8216AFE1DE77AF915F99CC66C9E39@AS8PR04MB8216.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5fWmB18fO8BpO/2iKNwS6j03AIHdawlqyiv9cZs3LgnN64PGHMS3V+f9zBf3se6gvc2UXXbhM0THIaIZdgUXz9KOuFPhahu7IVRppxhqS+ogr6DchyP8h/J3dMWsdrP2qzn/9gBsbtWajrOhJ+mwCJWIcqm5JQKfiMHji5l1qU8HMkYVQLdnDpSLx1UK8l8+iYFrPvOzJS5TVV0RWImM9Bn4QZTCW+yoJO3WtTx5r8hHwVsLxJNVSZrKQFfU7yv5xyk/alV3etnvzQZWpAg5A5Jlfwq6iYdwAe8lUuCrJ0KH6HeNQvzZpNU+4nxcSGaQYYd9iMArEhrsCj9lSNXoLIvsJTvFB8phIrihv0x7+KYeZJOFsWu5vC2I0or/+6dHdKo49uz5LZZLtVIckWpdFUeOY8ulgFG1MQbHUt/KXHun/+FluDZ/wrNNCpHYtpV3RsCEaElevHctDf0vjEMkNcaEuv4CVj841c9NqtQz4xMIXMw67s87nM53mEzAVLoUNBwlEk1B35wyr+kTNmhsi2cO8473TkPhSbplWr8sE5M9LTWDl17OBVKnc1fY3EdXTM+fhrcsnwg9GKSdPLV35riUwRhPaAsYDNH4bJAa0cXnGO98H3xAIq3wlI8CsUt0tMbjxJRMJLd/03qeWL7VfmSCRHb/73w0iiQTUAKfvl11fCsCqUQ0no8P0TMsVbIXva+gQo0ZBCQ325O8hY7axw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(4326008)(6486002)(508600001)(4744005)(38100700002)(38350700002)(66946007)(8676002)(66476007)(6666004)(66556008)(8936002)(5660300002)(86362001)(316002)(2616005)(1076003)(6512007)(6506007)(186003)(52116002)(26005)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YDBIJhulRKzQxrkWMzhL5ukKrCvNCZdTRNR0z4no8ffcvOHODTx8ln7f6OB6?=
 =?us-ascii?Q?UR3x2aYdZXon9fHnN21f92Sq/9V0QoFUPT4UU+YtLDIrkJ7Qhgp2CG/wkzWE?=
 =?us-ascii?Q?TBSd+GOuaEpvvIX3oG53SsT16hrLHkpNsQwfOh29n/VByXz2O296VNTRXwBw?=
 =?us-ascii?Q?yl6R+8g8RmUpzvF0Iy68RsEfa5Qy92LPIV7EEsHTB2K+O4NBGwplZSd8gVO0?=
 =?us-ascii?Q?U0H/lxCS2rolAut0c8WJglQbyuTxJ6k82EFtwSIGrmjnC8ysuTR8Pcf3iOlt?=
 =?us-ascii?Q?WoBo+qjLRmc9/tHEMVl6NPzFoXO6hgPHnrpIyeVOaVrJunjdkBZQdc+1seCh?=
 =?us-ascii?Q?e16MYaLi1nWCDakMQfnKqEq8au1hM9xeQ7U0/9SlHhnKyTGroSAUefBKeZWQ?=
 =?us-ascii?Q?TWvU0JKbf/i/FL47ITXBGnAEB9X0JIjyeZ6xv2+wsUiYZGzHFGBorgBYNpGR?=
 =?us-ascii?Q?sXpY3X4U1sJmgHQHltVi206xke06npvoaAUKhmARnQsLrtBbnMbNAtw8PrUd?=
 =?us-ascii?Q?qP230ck0aeSvp9D7EUwb1x2fmgvZ6eST5V6Sy7IhBxMaV0ngJNpXm9/OozLU?=
 =?us-ascii?Q?c5dTLpoLyEVpwh7WNjrC+CwrIpHQy+re3aY/FHrFECFIY7VxrjecfEibWooE?=
 =?us-ascii?Q?fBALjjLzgDxq8A3F720gsQHxc6zz183C55SxVqvEvH3IWCtuEB9zJ/KqqQTn?=
 =?us-ascii?Q?uDOlo0y9WXtvM8yQ0DGUYSjrfp/gqz1F5y6z1/m7E6V8X2OFeeGTNFftmoYS?=
 =?us-ascii?Q?J6Q1T3ufHm/EU2EMYe75uiOHSN9shKFk4M5kkVeuhp7KI2r/OImRxFlGTXfj?=
 =?us-ascii?Q?4UlKRsqn7rLlwW8is49L73gmA3RFBbrAbX9MibhOvmZ99DVnu39Emh/D6Uvu?=
 =?us-ascii?Q?8u5iee13Zl9CrPPHbxWltGp1sqaKN8MJUE1lHah6lyNJJpwYEVQJ4Yc6qrFS?=
 =?us-ascii?Q?C7JE0G+qkwYuHCv72VUurP9TrzhLEa7kbdI9Nl8mrDZslpCf+DE4Y1uGch4B?=
 =?us-ascii?Q?Zndgpo4ZedbxOPucXx9w0zvm0Kk4kL5QysGBisDrMmpvYNpnmzzLRcOa8A8B?=
 =?us-ascii?Q?kGRI/kqqAS6i5OLmbFE2ZOuRqPNgSL9zz+gsEuAjFW3wXBJDky0Nz9tMS4Kb?=
 =?us-ascii?Q?scDEio02bcAG/51L6KDACx9QH2invMAMNz+cgH3z4vBmrp7r1R6CODI+2T5P?=
 =?us-ascii?Q?2zYQZvEeZ8mFyRkojvLBihn1c49R+C7gp2YozcxxYinQmgcVb9fZFsxGsIuQ?=
 =?us-ascii?Q?peF9mpp5RF2TT5mG6AewutLI8dscJddqhe+ErdP5cj9hZwsAJgBu1+x83h0r?=
 =?us-ascii?Q?OwWEYWCik8CTKVdWJoClCGuPQ9McOtI0XikUi+l7aWQ5bqq97/jQ84dD2xTK?=
 =?us-ascii?Q?UnnrNKYppRNvehEe+9RtTQNXwGmaNa1UH9y7fSAjUSSyUPii55GU86VOaA8g?=
 =?us-ascii?Q?fB4SsinyWxA0mhhjLmPJmlse5ihZTvNR0sth4Zpog/MOQtn4UJogGBOU0PAI?=
 =?us-ascii?Q?4P7jS85gTSUQsHm1GsJpXfdWIUUij6wD53DR6gzxOGRQKb0agRlf2MmESvbL?=
 =?us-ascii?Q?7YYJPMaaSRYldcIplOJbZa6Gm9l4HyHEBb1v8vWJUOntEDkiFSuYAzDVtSpb?=
 =?us-ascii?Q?W0XpzV4sweLtKOv6AOcilgQv9G6CQNsMQBGHd4OsWa+Wu0Z07ih6StwSkQZs?=
 =?us-ascii?Q?JDhxLAMMTYhbUUZjMTe79Tv8DU7q1a1WCUcuQyG3dOJV2/rxGuh08Wu8oYE0?=
 =?us-ascii?Q?fvAxflrPAw=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9090d4ee-b67d-46f2-0a95-08da1465d914
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 05:01:29.8035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YLZqgD75ECSGvYuhnLaWaO7IjFiR5jMy/OHeCe4AIvhqUVo7PbhJSaODcZeb1pVbI+hqDYucuXeyo2gaCZOq0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8216

From: Peng Fan <peng.fan@nxp.com>

V2:
 Per Julien's comments, fix coding style issue, drop unneeded code

Add i.MX lpuart driver and i.MX8QM platform support.
 - lpuart is the uart IP used in i.MX8QM/QXP/93.
 - Very basic i.MX8QM platform support.

Peng Fan (2):
  xen/arm: Add i.MX lpuart driver
  xen/arm: Add i.MX lpuart early printk support

 xen/arch/arm/Kconfig.debug              |  14 ++
 xen/arch/arm/arm64/debug-imx-lpuart.inc |  52 +++++
 xen/drivers/char/Kconfig                |   8 +
 xen/drivers/char/Makefile               |   1 +
 xen/drivers/char/imx-lpuart.c           | 275 ++++++++++++++++++++++++
 xen/include/xen/imx-lpuart.h            |  64 ++++++
 6 files changed, 414 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
 create mode 100644 xen/drivers/char/imx-lpuart.c
 create mode 100644 xen/include/xen/imx-lpuart.h

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sat Apr 02 06:40:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 06:40:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297744.507255 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naXQY-0006xU-Ur; Sat, 02 Apr 2022 06:40:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297744.507255; Sat, 02 Apr 2022 06:40:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naXQY-0006wo-Nu; Sat, 02 Apr 2022 06:40:02 +0000
Received: by outflank-mailman (input) for mailman id 297744;
 Sat, 02 Apr 2022 06:40:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XEN3=UM=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1naXQX-0006n4-0B
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 06:40:01 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on060a.outbound.protection.outlook.com
 [2a01:111:f400:fe02::60a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b64b3d87-b24f-11ec-8fbc-03012f2f19d4;
 Sat, 02 Apr 2022 08:39:57 +0200 (CEST)
Received: from AS9PR06CA0146.eurprd06.prod.outlook.com (2603:10a6:20b:467::9)
 by AM6PR08MB3942.eurprd08.prod.outlook.com (2603:10a6:20b:ae::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.21; Sat, 2 Apr
 2022 06:39:55 +0000
Received: from AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:467:cafe::5b) by AS9PR06CA0146.outlook.office365.com
 (2603:10a6:20b:467::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30 via Frontend
 Transport; Sat, 2 Apr 2022 06:39:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT026.mail.protection.outlook.com (10.152.16.155) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Sat, 2 Apr 2022 06:39:54 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Sat, 02 Apr 2022 06:39:54 +0000
Received: from af56df743dcb.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 38C47B39-3475-4C1B-92CA-2DEDB70C998F.1; 
 Sat, 02 Apr 2022 06:39:46 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id af56df743dcb.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sat, 02 Apr 2022 06:39:46 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by DBBPR08MB4473.eurprd08.prod.outlook.com (2603:10a6:10:ce::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Sat, 2 Apr
 2022 06:39:41 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a%5]) with mapi id 15.20.5123.030; Sat, 2 Apr 2022
 06:39:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b64b3d87-b24f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ioNWpQyJnQj08KuQE8KF/JjPJM/jDM10BkTaqpaGsWE=;
 b=PXIwCcKK/5UvwL89URJoN7KIoa7zRzOXxT+yX68jMN8MjEM2V+PF4ZiXaTfggKQ66mF+sHL4k2neYgAaacJod8/NronZuxAou/5MV0JQowkf86Q3ba3L4fiDlwRjeZ2uzEza3c3YA9+h6IkbY6ObduhPzWWiH/em58jDwtHXbNQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TuYUJZDqUWJoBUUIsA5CtPCDIqStWMUD06XKdj4oHb5V+XbvR3TTeNKpOsgmu9RWbKK2YtTQ0bTZyW+3pDn9OgnEWE4m5Ap6AqeZJpCvZsHEZK1XoE3/Z/wSpKSEj1PKhWuzH4Pxe0XhUVbs+CVHAnQwgkPzSkEI3hYgBnPGQiNl/7baPWAcry90Xh+TQ45SdB/TrYtrTpNMxEDQdwI84QdBeHNxlJOgGOF79op+g6j8EQajvo31FZBnam5WTYMvhALjz6RCZLwtihjvfE86Hn7cOG7dV7KFk/94ftMkSkGBVPJDFPzTNpAec8jYfq6UhKQePyPpaP9v4ioOQAJt/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ioNWpQyJnQj08KuQE8KF/JjPJM/jDM10BkTaqpaGsWE=;
 b=dbFzQryajiZicEWznOWe39jyy6f2ze5NKFolsKfG3q1xMn3GLAuShqfD7G29lWr+gB2vojN+CTi2ZEBLSOKTUPi0M1JVdp/7lVap7qNZ43+1ea4TFnj+gGjSkeMyYYt/te/Xp6amGu7QCl3jowjm/aQa1ZSG6fw4HHRfbpPmmDD6+cqGMtFBoC3MlXhkbymXhTeHuX1QSXkNk8xOlRrCJuUkUuZVrO99cHWEzAaNzA4J89oQ++f956UUQ7oYnRsVhnu/5IbSZTVYv8qpRO0veG9Ns+GvZWgeOO5i9znrNv+16KQY7Fm2BCpRsv2fuaEOQbBNtHtq1IPe1K9QyQLLKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ioNWpQyJnQj08KuQE8KF/JjPJM/jDM10BkTaqpaGsWE=;
 b=PXIwCcKK/5UvwL89URJoN7KIoa7zRzOXxT+yX68jMN8MjEM2V+PF4ZiXaTfggKQ66mF+sHL4k2neYgAaacJod8/NronZuxAou/5MV0JQowkf86Q3ba3L4fiDlwRjeZ2uzEza3c3YA9+h6IkbY6ObduhPzWWiH/em58jDwtHXbNQ=
From: Henry Wang <Henry.Wang@arm.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "julien@xen.org" <julien@xen.org>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>
CC: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"van.freenix@gmail.com" <van.freenix@gmail.com>, Peng Fan <peng.fan@nxp.com>
Subject: RE: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
Thread-Topic: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
Thread-Index: AQHYRk7a/JjxjoNn4kiU16mgWm8EnKzcKBxw
Date: Sat, 2 Apr 2022 06:39:38 +0000
Message-ID:
 <PA4PR08MB62532071B8FF1845EA33C26892E39@PA4PR08MB6253.eurprd08.prod.outlook.com>
References: <20220402054223.10304-1-peng.fan@oss.nxp.com>
 <20220402054223.10304-2-peng.fan@oss.nxp.com>
In-Reply-To: <20220402054223.10304-2-peng.fan@oss.nxp.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 4A7036E9572BF54083CB375563038ADE.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: bebaf900-d44d-445e-5ded-08da1473990c
x-ms-traffictypediagnostic:
	DBBPR08MB4473:EE_|AM5EUR03FT026:EE_|AM6PR08MB3942:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB394285780EC72108A9DC662B92E39@AM6PR08MB3942.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jUCVAlfcHt8H2lOAztAhf78R/FgkxEZ+Cl+22pQpcmTcj9wBFtdxLU7Cm19DzT1QtbxBjCy2Fla31w4N7dYUY626cRg9GYsWAHbTWg8hVMA3lvBcxrF8q6ty9K9E8ba6a8bwrI6eakBrj0INFnp7JZQvvtRDdsLej4cPrdqdaBUcEwHU2lHE2xV1nL/871kuTuFjoiUVstll0W3yIOpVZG18dy5vKVlFWRWnm+xOwhOc4e6H5xdXxMYTBu7P6woEGEsA3DMaxVyy2fnJe8rVbBZOJkGwRsv/4qzeSQthYUzaAvtWL+23o0VTrEkR0hETpwV+FgJWFz7Y6NxvRZ1IARavz52NKNJQTrgiEBZjjLn3XtV1InGHLAFjKQcVlSpUgx03SYGeD3WOfq6ocXgPn3q17CI4JE+FYS1L8XyLBwSCAmtQdH+yKqEr7yB1xzDOsP3WEC85IDG/Q+FIhI8y3lHcEdEToajWpgAGTSCY3oanM3Y2sXUtnUopbtcfzednJWkLWnQuZMLrI+1WA1Xddqk46eRBiL/QQssGM84mweCukwa0qKIKYYKpRiJefgiy+Wlh6Imroec0p1nhU/zCBP5fg27VzswKgfOVvIiR+fIo5+ACDRUhW9/R/l1BY8VYeO3yQ6eYblQWuKPmB7kkRKeOYdfy/gi2tpbquo0mAWKc42n1chQ5MIofJiI8pwTpiIVcH5ilmGvZQqt5V7V57ejAUTM2lbQQXAOGEuqwDv4v4eqUpqkl4YoBw2Zd7yZLWj40/0f75DCT3vFbQyx9lTP42om17tls9ZJBnJl0BwTyHKAfQ5ND3ZLfwLh2eX+W
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7696005)(53546011)(83380400001)(316002)(66476007)(66446008)(64756008)(76116006)(2906002)(66946007)(86362001)(6506007)(4326008)(55016003)(66556008)(8676002)(33656002)(9686003)(508600001)(71200400001)(52536014)(8936002)(7416002)(38070700005)(30864003)(54906003)(26005)(5660300002)(186003)(110136005)(38100700002)(6636002)(966005)(122000001)(2004002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4473
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c494544e-12ab-4c70-b1b1-08da14738fa3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dW/qHfl1GouoFdzQHBoDFBDKUsKRdxOdZOb/+D309f7bef2Af4yZuds3rAuJp9n3nJtCbf81Eck05O7jWF8JiGPUIcuki6dDcnhVHzT1ZIXt5Q/zBB448taJYqOxNQrISn6pjhNqk86msS+RZGVW7XgVveejBQ17OJCVe6z+F1l7Vqp75ITmVT7iL3z8WL4Ci5PBObZ5tyVMVs3N/7tBKn2A7uLFWBZevotxIUyvnlasEbzAR2bmpQKiZCrjMPYNGr0kw0ZnnxrYduqt/b71b4tE8wl9MTb2PaNVe0z3c7p8h6U2q4EbMhNgZtMpPOiIjAOXbMQ9rNCKP0HeuFuZ3HZ1JbrWb9XfTt4KeaCWZkmkjKlukDFZAbHGiCS6nHaOtRc4DF/44QMzmnHZcTJezVYcC830UL+7ufSdWhVPTMM9H+fS52mOZ8D8njuETtyMp0VLJXDv+4y0W9HNcDwz0yMxADiasMUCtRAZ0tKZ4v4UtbVWWQYQP2f7gwvU1d3OqwzkDOn4/nJPyiwH7oJ/qdhP+xOp+ZyqptYUJPsMkurw9wPw0IDD/9kg9l68QniNtvZL1KVToJssMr24/807SyVwn5Ssf8DNisxBlnEiT6kx2ADJSZS5lcbexQXt+ExDOFd0YJOP1zayJkUUQBaEq6mpz6xwFXt9Z+/CuTXWR5SB+s3GVX1JiPd/uezdB+dFU6P98H4jctqigFYWXus2GKTlrTgz7lnFwHIqXrlQY7tSpsTv5embG18watdK66U/+BEaBQaeHOZx4dc/z5y8g9nStzKKS2SuQHkwyZdWlmg=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(52536014)(9686003)(8936002)(186003)(30864003)(26005)(966005)(70586007)(356005)(55016003)(86362001)(8676002)(4326008)(40460700003)(33656002)(110136005)(6636002)(70206006)(36860700001)(54906003)(82310400004)(336012)(2906002)(6506007)(53546011)(5660300002)(7696005)(316002)(83380400001)(508600001)(81166007)(47076005)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 06:39:54.7084
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bebaf900-d44d-445e-5ded-08da1473990c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3942

Hi Peng,

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Peng Fan (OSS)
> Sent: Saturday, April 2, 2022 1:42 PM
> To: sstabellini@kernel.org; julien@xen.org; Volodymyr_Babchuk@epam.com;
> Bertrand Marquis <Bertrand.Marquis@arm.com>
> Cc: andrew.cooper3@citrix.com; george.dunlap@citrix.com;
> jbeulich@suse.com; wl@xen.org; xen-devel@lists.xenproject.org;
> van.freenix@gmail.com; Peng Fan <peng.fan@nxp.com>
> Subject: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
>=20
> From: Peng Fan <peng.fan@nxp.com>
>=20
> The i.MX LPUART Documentation:
> https://www.nxp.com/webapp/Download?colCode=3DIMX8QMIEC
> Chatper 13.6 Low Power Universal Asynchronous Receiver/
> Transmitter (LPUART)
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

For the whole series of patch, I tested that the series will not break
current arm64 boot of Xen with and without the CONFIG_HAS_IMX_LPUART.
Unfortunately I cannot test the functionality as I do not have the board :)=
)

So, for this series:
Tested-by: Henry Wang <Henry.Wang@arm.com>

> ---
>  xen/drivers/char/Kconfig      |   8 +
>  xen/drivers/char/Makefile     |   1 +
>  xen/drivers/char/imx-lpuart.c | 275
> ++++++++++++++++++++++++++++++++++
>  xen/include/xen/imx-lpuart.h  |  64 ++++++++
>  4 files changed, 348 insertions(+)
>  create mode 100644 xen/drivers/char/imx-lpuart.c
>  create mode 100644 xen/include/xen/imx-lpuart.h
>=20
> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> index 2ff5b288e2..0efdb2128f 100644
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -13,6 +13,14 @@ config HAS_CADENCE_UART
>  	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
>  	  based board, say Y.
>=20
> +config HAS_IMX_LPUART
> +	bool "i.MX LPUART driver"
> +	default y
> +	depends on ARM_64
> +	help
> +	  This selects the i.MX LPUART. If you have a i.MX8QM based board,
> +	  say Y.
> +
>  config HAS_MVEBU
>  	bool "Marvell MVEBU UART driver"
>  	default y
> diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
> index 7c646d771c..14e67cf072 100644
> --- a/xen/drivers/char/Makefile
> +++ b/xen/drivers/char/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) +=3D mvebu-uart.o
>  obj-$(CONFIG_HAS_OMAP) +=3D omap-uart.o
>  obj-$(CONFIG_HAS_SCIF) +=3D scif-uart.o
>  obj-$(CONFIG_HAS_EHCI) +=3D ehci-dbgp.o
> +obj-$(CONFIG_HAS_IMX_LPUART) +=3D imx-lpuart.o
>  obj-$(CONFIG_ARM) +=3D arm-uart.o
>  obj-y +=3D serial.o
>  obj-$(CONFIG_XEN_GUEST) +=3D xen_pv_console.o
> diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.=
c
> new file mode 100644
> index 0000000000..49330fd2f8
> --- /dev/null
> +++ b/xen/drivers/char/imx-lpuart.c
> @@ -0,0 +1,275 @@
> +/*
> + * xen/drivers/char/imx-lpuart.c
> + *
> + * Driver for i.MX LPUART.
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <xen/errno.h>
> +#include <xen/imx-lpuart.h>
> +#include <xen/init.h>
> +#include <xen/irq.h>
> +#include <xen/mm.h>
> +#include <xen/serial.h>
> +#include <asm/device.h>
> +#include <asm/io.h>
> +
> +#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
> +#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + of=
f)
> +
> +static struct imx_lpuart {
> +    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
> +    uint32_t irq;
> +    char __iomem *regs;
> +    struct irqaction irqaction;
> +    struct vuart_info vuart;
> +} imx8_com;
> +
> +static void imx_lpuart_interrupt(int irq, void *data,
> +                                 struct cpu_user_regs *regs)
> +{
> +    struct serial_port *port =3D data;
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t sts, rxcnt;
> +
> +    sts =3D imx_lpuart_read(uart, UARTSTAT);
> +    rxcnt =3D imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
> +
> +    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
> +	    serial_rx_interrupt(port, regs);
> +
> +    if ( sts & UARTSTAT_TDRE )
> +	    serial_tx_interrupt(port, regs);
> +
> +    imx_lpuart_write(uart, UARTSTAT, sts);
> +}
> +
> +static void __init imx_lpuart_init_preirq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t ctrl, old_ctrl, bd;
> +
> +    ctrl =3D old_ctrl =3D imx_lpuart_read(uart, UARTCTRL);
> +    ctrl =3D (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
> +    bd =3D imx_lpuart_read(uart, UARTBAUD);
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
> +	    cpu_relax();
> +
> +    /* Disable transmit and receive */
> +    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE |
> UARTCTRL_RE));
> +
> +    /* Reuse firmware baudrate settings, only disable DMA here */
> +    bd &=3D ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
> +
> +    imx_lpuart_write(uart, UARTMODIR, 0);
> +    imx_lpuart_write(uart, UARTBAUD, bd);
> +    imx_lpuart_write(uart, UARTCTRL, ctrl);
> +}
> +
> +static void __init imx_lpuart_init_postirq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t temp;
> +
> +    uart->irqaction.handler =3D imx_lpuart_interrupt;
> +    uart->irqaction.name =3D "imx_lpuart";
> +    uart->irqaction.dev_id =3D port;
> +
> +    if ( setup_irq(uart->irq, 0, &uart->irqaction) !=3D 0 )
> +    {
> +        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
> +                uart->irq);
> +        return;
> +    }
> +
> +    /* Enable interrupts */
> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> +    temp |=3D (UARTCTRL_RIE | UARTCTRL_TIE);
> +    temp |=3D UARTCTRL_ILIE;
> +    imx_lpuart_write(uart, UARTCTRL, temp);
> +}
> +
> +static void imx_lpuart_suspend(struct serial_port *port)
> +{
> +    BUG();
> +}
> +
> +static void imx_lpuart_resume(struct serial_port *port)
> +{
> +    BUG();
> +}
> +
> +static int imx_lpuart_tx_ready(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +
> +    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
> +}
> +
> +static void imx_lpuart_putc(struct serial_port *port, char c)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
> +        cpu_relax();
> +
> +    imx_lpuart_write(uart, UARTDATA, c);
> +}
> +
> +static int imx_lpuart_getc(struct serial_port *port, char *pc)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    int ch;
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
> +	    return 0;
> +
> +    ch =3D imx_lpuart_read(uart, UARTDATA);
> +    *pc =3D ch & 0xff;
> +
> +    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
> +        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
> +
> +    return 1;
> +}
> +
> +static int __init imx_lpuart_irq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +
> +    return ((uart->irq > 0) ? uart->irq : -1);
> +}
> +
> +static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port
> *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +
> +    return &uart->vuart;
> +}
> +
> +static void imx_lpuart_start_tx(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t temp;
> +
> +    temp =3D imx_lpuart_read(uart, UARTSTAT);
> +    /* Wait until empty */
> +    while ( !(temp & UARTSTAT_TDRE) )
> +	    cpu_relax();
> +
> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> +    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
> +}
> +
> +static void imx_lpuart_stop_tx(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t temp;
> +
> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> +    temp &=3D ~(UARTCTRL_TIE | UARTCTRL_TCIE);
> +    imx_lpuart_write(uart, UARTCTRL, temp);
> +}
> +
> +static struct uart_driver __read_mostly imx_lpuart_driver =3D {
> +    .init_preirq =3D imx_lpuart_init_preirq,
> +    .init_postirq =3D imx_lpuart_init_postirq,
> +    .endboot =3D NULL,
> +    .suspend =3D imx_lpuart_suspend,
> +    .resume =3D imx_lpuart_resume,
> +    .tx_ready =3D imx_lpuart_tx_ready,
> +    .putc =3D imx_lpuart_putc,
> +    .getc =3D imx_lpuart_getc,
> +    .irq =3D imx_lpuart_irq,
> +    .start_tx =3D imx_lpuart_start_tx,
> +    .stop_tx =3D imx_lpuart_stop_tx,
> +    .vuart_info =3D imx_lpuart_vuart_info,
> +};
> +
> +static int __init imx_lpuart_init(struct dt_device_node *dev,
> +                                  const void *data)
> +{
> +    const char *config =3D data;
> +    struct imx_lpuart *uart;
> +    int res;
> +    u64 addr, size;
> +
> +    if ( strcmp(config, "") )
> +        printk("WARNING: UART configuration is not supported\n");
> +
> +    uart =3D &imx8_com;
> +
> +    uart->baud =3D 115200;
> +    uart->data_bits =3D 8;
> +    uart->parity =3D 0;
> +    uart->stop_bits =3D 1;
> +
> +    res =3D dt_device_get_address(dev, 0, &addr, &size);
> +    if ( res )
> +    {
> +        printk("imx8-lpuart: Unable to retrieve the base"
> +               " address of the UART\n");
> +        return res;
> +    }
> +
> +    res =3D platform_get_irq(dev, 0);
> +    if ( res < 0 )
> +    {
> +        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
> +        return -EINVAL;
> +    }
> +    uart->irq =3D res;
> +
> +    uart->regs =3D ioremap_nocache(addr, size);
> +    if ( !uart->regs )
> +    {
> +        printk("imx8-lpuart: Unable to map the UART memory\n");
> +        return -ENOMEM;
> +    }
> +
> +    uart->vuart.base_addr =3D addr;
> +    uart->vuart.size =3D size;
> +    uart->vuart.data_off =3D UARTDATA;
> +    /* tmp from uboot */
> +    uart->vuart.status_off =3D UARTSTAT;
> +    uart->vuart.status =3D UARTSTAT_TDRE;
> +
> +    /* Register with generic serial driver */
> +    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
> +
> +    dt_device_set_used_by(dev, DOMID_XEN);
> +
> +    return 0;
> +}
> +
> +static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
=3D
> +{
> +    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
> +    {},
> +};
> +
> +DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
> +    .dt_match =3D imx_lpuart_dt_compat,
> +    .init =3D imx_lpuart_init,
> +DT_DEVICE_END
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/xen/imx-lpuart.h b/xen/include/xen/imx-lpuart.h
> new file mode 100644
> index 0000000000..945ab1c4fa
> --- /dev/null
> +++ b/xen/include/xen/imx-lpuart.h
> @@ -0,0 +1,64 @@
> +/*
> + * xen/include/asm-arm/imx-lpuart.h
> + *
> + * Common constant definition between early printk and the LPUART driver
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ASM_ARM_IMX_LPUART_H
> +#define __ASM_ARM_IMX_LPUART_H
> +
> +/* 32-bit register definition */
> +#define UARTBAUD          (0x10)
> +#define UARTSTAT          (0x14)
> +#define UARTCTRL          (0x18)
> +#define UARTDATA          (0x1C)
> +#define UARTMATCH         (0x20)
> +#define UARTMODIR         (0x24)
> +#define UARTFIFO          (0x28)
> +#define UARTWATER         (0x2c)
> +
> +#define UARTSTAT_TDRE     (1 << 23)
> +#define UARTSTAT_TC       (1 << 22)
> +#define UARTSTAT_RDRF     (1 << 21)
> +#define UARTSTAT_OR       (1 << 19)
> +
> +#define UARTBAUD_OSR_SHIFT (24)
> +#define UARTBAUD_OSR_MASK (0x1f)
> +#define UARTBAUD_SBR_MASK (0x1fff)
> +#define UARTBAUD_BOTHEDGE (0x00020000)
> +#define UARTBAUD_TDMAE    (0x00800000)
> +#define UARTBAUD_RDMAE    (0x00200000)
> +
> +#define UARTCTRL_TIE      (1 << 23)
> +#define UARTCTRL_TCIE     (1 << 22)
> +#define UARTCTRL_RIE      (1 << 21)
> +#define UARTCTRL_ILIE     (1 << 20)
> +#define UARTCTRL_TE       (1 << 19)
> +#define UARTCTRL_RE       (1 << 18)
> +#define UARTCTRL_M        (1 << 4)
> +
> +#define UARTWATER_RXCNT_OFF     24
> +
> +#endif /* __ASM_ARM_IMX_LPUART_H */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> --
> 2.35.1
>=20



From xen-devel-bounces@lists.xenproject.org Sat Apr 02 07:38:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 07:38:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297748.507265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naYKj-0004M4-PX; Sat, 02 Apr 2022 07:38:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297748.507265; Sat, 02 Apr 2022 07:38:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naYKj-0004Lx-MH; Sat, 02 Apr 2022 07:38:05 +0000
Received: by outflank-mailman (input) for mailman id 297748;
 Sat, 02 Apr 2022 07:38:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naYKj-0004Ln-1N; Sat, 02 Apr 2022 07:38:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naYKi-0004Dc-Tk; Sat, 02 Apr 2022 07:38:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naYKi-0005pl-DV; Sat, 02 Apr 2022 07:38:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naYKi-00067f-Av; Sat, 02 Apr 2022 07:38:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WhTIEfnMvPcnqhaEx5jM/xwzXcmYM2DPl28WguhpOjY=; b=H46+/RmWOEhKimFugCh1eWmoM8
	s53mvrJh5uYMFSolVTIsC4zCaKeGxrqRLbCkKQN+EFRotND/w+tIMY2tZJu0XxtMkv8ISp0hmokzx
	rkHEUQM1s3FmDcWM+6X1mCDzEUYvIx9ig5zyRXNUTB9OkH7JD5Rzrnq/KyzMYKvmYPR8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169110-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169110: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=d5341e09135b871199073572f53bc11ae9b44897
X-Osstest-Versions-That:
    qemuu=cace6c6f3aca7b88afc42995f90bbefb37a0ed57
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 07:38:04 +0000

flight 169110 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169110/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169072
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169072
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169072
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169072
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169072
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169072
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169072
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169072
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                d5341e09135b871199073572f53bc11ae9b44897
baseline version:
 qemuu                cace6c6f3aca7b88afc42995f90bbefb37a0ed57

Last test of basis   169072  2022-03-31 15:37:03 Z    1 days
Testing same since   169110  2022-04-01 13:34:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   cace6c6f3a..d5341e0913  d5341e09135b871199073572f53bc11ae9b44897 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 08:13:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 08:13:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297767.507276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naYsn-0000ey-76; Sat, 02 Apr 2022 08:13:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297767.507276; Sat, 02 Apr 2022 08:13:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naYsn-0000er-3R; Sat, 02 Apr 2022 08:13:17 +0000
Received: by outflank-mailman (input) for mailman id 297767;
 Sat, 02 Apr 2022 08:13:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naYsl-0000eh-Op; Sat, 02 Apr 2022 08:13:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naYsl-0005Lf-MD; Sat, 02 Apr 2022 08:13:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naYsl-0008FN-BN; Sat, 02 Apr 2022 08:13:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naYsl-0001FT-8d; Sat, 02 Apr 2022 08:13:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2R2wGpQIflPuJlAsL6QSdpdIBCHDyIKekxt1ySqa1qU=; b=Rq9HTZVX69qc16x4KQ8AR6X7uX
	SwyvOTY75S+ktCiLjBS+8PSSzUdJUjIOz2XeW9fCHU/HJwmuwt1qeT82Q07sVZC5ZYdVCI/Ck1Ywe
	4TlyqWf3JPICvxPRWQQ18m/jNmoui33UzOBBY2GMa2VjpGT43l9YD5FdWoP+n4KwV9tc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169117-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169117: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=55637a2894babca97945eeca1da0d431f74f8627
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 08:13:15 +0000

flight 169117 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169117/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 55637a2894babca97945eeca1da0d431f74f8627
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   32 days
Failing since        168258  2022-03-01 01:55:31 Z   32 days  267 attempts
Testing same since   169004  2022-03-30 02:24:42 Z    3 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Yi Li <yi1.li@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1236 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 10:17:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 10:17:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297776.507287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naaoc-0003jH-CB; Sat, 02 Apr 2022 10:17:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297776.507287; Sat, 02 Apr 2022 10:17:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naaoc-0003jA-8A; Sat, 02 Apr 2022 10:17:06 +0000
Received: by outflank-mailman (input) for mailman id 297776;
 Sat, 02 Apr 2022 10:17:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/Uhr=UM=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1naaob-0003j4-50
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 10:17:05 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on060b.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::60b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 083aa671-b26e-11ec-a405-831a346695d4;
 Sat, 02 Apr 2022 12:17:01 +0200 (CEST)
Received: from AS9PR06CA0190.eurprd06.prod.outlook.com (2603:10a6:20b:45d::12)
 by HE1PR0802MB2394.eurprd08.prod.outlook.com (2603:10a6:3:dd::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.23; Sat, 2 Apr
 2022 10:16:52 +0000
Received: from AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45d:cafe::c2) by AS9PR06CA0190.outlook.office365.com
 (2603:10a6:20b:45d::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.29 via Frontend
 Transport; Sat, 2 Apr 2022 10:16:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT045.mail.protection.outlook.com (10.152.17.105) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Sat, 2 Apr 2022 10:16:51 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Sat, 02 Apr 2022 10:16:51 +0000
Received: from c133a11b770e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2B5490A2-39A0-47D3-ADED-36153F243760.1; 
 Sat, 02 Apr 2022 10:16:45 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c133a11b770e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sat, 02 Apr 2022 10:16:45 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by HE1PR08MB2649.eurprd08.prod.outlook.com (2603:10a6:7:2b::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19; Sat, 2 Apr
 2022 10:16:24 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::28c0:3e8d:dd75:80be]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::28c0:3e8d:dd75:80be%8]) with mapi id 15.20.5123.030; Sat, 2 Apr 2022
 10:16:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 083aa671-b26e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gDq3jqDKdD2znKf6w6nvM2pa6p9pftFfu0HJJoqqYjo=;
 b=H4XJLfd4Um4aTxu5WwWz6ukinD/t6aVRVByzBrVswEtMoCsBbY1tT/ouP5irZg3l/g+5A3vaNiNqO86NsMoBDOMF5OCbcSSOkn/ssgCYkbW4UyR4X4BmQbxNhUwbUqVlXhePl5G1dXvvko9EuYRL0CsqqxdlmGbIkHefo4XsKds=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TcNbVMLBlKekgN07hc5+SaSWyZBnKwFL6X0b5apuEmWVqRqZs9PfW81idtRgXsH4SdF+1jGFggvUSD3GSFaeswk4Ue2jgSFeJf+V8onDyb7WCHwLDbqzgEeUSzdEJa67C5ahZj/eurIdiQb454nbWD9rvrSvzIw/WYujpvKFSJRpqYgS6I5se3K10kp3dyViCqbd+bau9yz0uLy85cSH9R30kg49t0mq8FXUe818bIxk4kVpiRRRbfUj1FK3Co2WXumdE/0QboVv04heWYzhAjgjeYLLU3LmolwD3RpK9Q4UUZPLOcWl+NozZAVnHWsIXlUbdTf/AdolSphBYFP4OA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gDq3jqDKdD2znKf6w6nvM2pa6p9pftFfu0HJJoqqYjo=;
 b=H9v6rbOgoU4/D5AGRy+2mqnFfh/BdHWYa0qvLw0RdVwVUluomqWq/sL97790d/x0wJcwDQuKtwQ4XDxOmLVMkthX6dqnzYWHFIbktVF9uS5X+SxZL5d7UBDRGn5y23UZz7YFdJhZcq/4lKpkP3UGuIWZ+oDt0NE67QUz/NiNr1ETp6MGYArRYZV9MrANOpsoGiZj7VhCW6ndHHEwtFYaHAExLr/35Qls+lOsYE1jhyfJ5wRiKDjRm26Yng0i/t/kSMj17kG8gXOqC8rVxWnWKUePLjcAacmDrNOjKUdVua/XfwZ04fwnFUfzXKxy5/ZPWEtZJcFELzKu9MNkjOc0zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gDq3jqDKdD2znKf6w6nvM2pa6p9pftFfu0HJJoqqYjo=;
 b=H4XJLfd4Um4aTxu5WwWz6ukinD/t6aVRVByzBrVswEtMoCsBbY1tT/ouP5irZg3l/g+5A3vaNiNqO86NsMoBDOMF5OCbcSSOkn/ssgCYkbW4UyR4X4BmQbxNhUwbUqVlXhePl5G1dXvvko9EuYRL0CsqqxdlmGbIkHefo4XsKds=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
CC: Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on static
 allocation
Thread-Topic: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on static
 allocation
Thread-Index:
 AQHYRBnkeXnYvoANH0WdfY8GUNrlN6zXr5KAgAEgZ0CAAENNAIAAARVQgAJXEYCAANs8kA==
Date: Sat, 2 Apr 2022 10:16:21 +0000
Message-ID:
 <DU2PR08MB73256608FCF12AEF54AEAE7DF7E39@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220330093617.3870589-1-Penny.Zheng@arm.com>
 <20220330093617.3870589-4-Penny.Zheng@arm.com>
 <31c1ae2d-a4d6-5445-e819-5df5a0984cdd@suse.com>
 <DU2PR08MB73251B78F8EB19E334A70876F7E19@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <eba664e6-4146-426b-5119-59fe02a96bb5@suse.com>
 <DU2PR08MB7325D94A0BFFC2A3BB0AFF08F7E19@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <6ae9a1f9-4167-46d2-df9b-9d7f626fa247@xen.org>
In-Reply-To: <6ae9a1f9-4167-46d2-df9b-9d7f626fa247@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: AF928C687A24A14F9451BCF188FEEFC7.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 7c064529-aadb-43da-384c-08da1491e7bc
x-ms-traffictypediagnostic:
	HE1PR08MB2649:EE_|AM5EUR03FT045:EE_|HE1PR0802MB2394:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0802MB2394ACE606EAFD2CD8C0E3D1F7E39@HE1PR0802MB2394.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2lZsV+Z41hY3g/JMbm/DYV9KlTb5DTjjC609zvipCVyAv35TX2CB7mbu9sxIgt3e6k167NR+kQ+kqUaZ4BxETFzGVFoM0kuyoqgts+7DJaeekSp1BI+F1cJBtADW6pAVXrmUEwTUDy63vLErobSBDSLIVNJTGps9JhpWAPvacnL1hYU8pIY6eHZrQM7G7y4wIt6kSuFeUs3/0jcbXNj89NmgRLy22RbOaq3YwAvDE+6V2PKzjhMxX8PPz+74Ev3nRskAkmYlBe45vaSxHZbowgK9E8YBuGPhLDAQek27zR2wWkxZozI82RiImeCgCeEl5jHIexgAFt+4nVC6Tp6QdO7+nknytcJszIk+DX54y8ZbwYFtdywtaPbpYeCEF1cVzlxZ/mcCZGbFQ58+Nxpc74DzOi3PIpFOCvQD+GNihRLClJzW8jd2or/o5BZCBemnfoX5YAWq0ktUXarmk7JI4eWzvFMpkuRsdZjYqpTwlUWuxkz+yyaLJz0gNhwXneZUL2J+tleUe6oZLS8qaW7jIDo5ud7J6JGe2DijPXiW8dV4hYumApZEQwSm0e7m3+/AxEUzOGnD0ukHWB69V959noVeZEpqjgVItRF5uPMBh1lOfZRPr6oBV2PN94Mvsa/vTnK8V92VDigZSzZbXJzNhdntwLU/Da+T+rs44MuScXkciowwsYj5H1GC5dKP/D6ZyjyWItiXgaXQ4ncpogPCvA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55016003)(83380400001)(8936002)(53546011)(52536014)(7696005)(6506007)(2906002)(186003)(4326008)(316002)(33656002)(86362001)(110136005)(54906003)(5660300002)(38070700005)(38100700002)(508600001)(122000001)(26005)(71200400001)(9686003)(66556008)(8676002)(66946007)(66476007)(66446008)(76116006)(64756008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2649
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	14003cdd-142f-4171-26fa-08da1491d724
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9jRuuBi/wJCuM82SQnlUtiyUVNDAhJ0G4Nsnaychcgho3ahePVBPzhFpzNbNa1xJFibtKVafF61X9h9wVBe3rNfYe3dEBlY1vA4wawp7iM1OPPWt6GJtTqBDggXtAcT5H13FmCqNv0Czm7gbFezS5nK/YMj1lED+1lEmzDeRPdmfHyX2J1RsCO8sVzgF2ksfXoRzITjbkXBGfxxoDrrpXqAZfp7YTbvwoFQA8ySanVQxgDNPq6w67JOhH9eVC9O+LbUPi5TCtm+s6RNkga70qQ2zEgjaArspQY1kX9HPX1qn/vcRNPpFBM0ZG/BeL7lpsyWkFFip4lMCO0Gsa0NHvPiO1bwaKwDxDJgVrjltcTa25tMbCE13uycYIgrE95M1xI3k4wLVVJpzgkMHfJ3Jbs0J95gvUYCl/LoeR00xUrFKS8krxF56U3ZEi4/9NuViHhSOZRypiHUliKqsjWVbsOgZ8qaUzPPaX9jgbcRw0gxwRrmOLdSdVoBkQIv71zINzXskvqGIr10Rq4k1sjY8N+pvV+QxWw1tOECtcce2hXZWY15pmUt5AjUxey71DKWSluBxU6ZXwK3J3R9ZkTrMVtrxJvMR1IUKNXirlQoyvWhAE6NTI4Nv89Jfoo7NDUXk7FEeE67y3E+jpLkwzmxue8SQqRFcNXP0OvmZUvVG3+btnN6LteaYZGMX5NKvixdL
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(82310400004)(186003)(26005)(83380400001)(81166007)(36860700001)(356005)(9686003)(2906002)(47076005)(336012)(40460700003)(86362001)(70586007)(55016003)(70206006)(53546011)(110136005)(8676002)(33656002)(508600001)(316002)(52536014)(4326008)(8936002)(5660300002)(7696005)(6506007)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 10:16:51.6563
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c064529-aadb-43da-384c-08da1491e7bc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2394

SGkgSnVsaWVuIGFuZCBKYW4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t
OiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBTZW50OiBTYXR1cmRheSwgQXByaWwg
MiwgMjAyMiAyOjU0IEFNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47
IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hl
bkBhcm0uY29tPjsgSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPjsNCj4gQW5kcmV3IENv
b3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXANCj4gPGdlb3Jn
ZS5kdW5sYXBAY2l0cml4LmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2Vy
bmVsLm9yZz47IFdlaQ0KPiBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv
amVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MSAzLzVdIHhlbi9hcm06IHVucG9wdWxh
dGUgbWVtb3J5IHdoZW4gZG9tYWluIG9uDQo+IHN0YXRpYyBhbGxvY2F0aW9uDQo+IA0KPiBIaSBQ
ZW5ueSwNCj4gDQo+IE9uIDMxLzAzLzIwMjIgMTE6MzAsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+
IEFub3RoZXIgcmVhc29uIEkgd2FudCB0byBrZWVwIHBhZ2UgYWxsb2NhdGVkIGlzIHRoYXQgaWYg
cHV0dGluZyBwYWdlcw0KPiA+IGluIHJlc3ZfcGFnZV9saXN0IHVwb24gZHJvcHBpbmcgdGhlIGxh
c3QgcmVmLCB3ZSBuZWVkIHRvIGRvIGEgbG90DQo+ID4gdGhpbmdzIG9uIHBhZ2VzIHRvIHRvdGFs
bHkgbGV0IGl0IGZyZWUsIGxpa2Ugc2V0IGl0cyBvd25lciB0byBOVUxMLA0KPiA+IGNoYW5naW5n
IHBhZ2Ugc3RhdGUgZnJvbSBpbl91c2UgdG8gZnJlZSwgZXRjLg0KPiBUaGlzIGlzIG5vdCBvbmx5
IGFib3V0IG9wdGltaXphdGlvbiBoZXJlLiBCYWQgdGhpbmdzIGNhbiBoYXBwZW4gaWYgeW91IGxl
dCBhDQo+IHBhZ2UgaW4gc3RhdGUgZnJlZSB0aGF0IGlzIG5vdCBtZWFudCB0byBiZSB1c2VkIGJ5
IHRoZSBidWRkeSBhbGxvY2F0b3IgKGUuZy4gaXQNCj4gd2FzIHJlc2VydmVkIGZvciBzdGF0aWMg
bWVtb3J5KS4NCj4gDQo+IEkgZGlzY292ZXJlZCBpdCBlYXJsaWVyIHRoaXMgeWVhciB3aGVuIHRy
eWluZyB0byBvcHRpbWl6ZQ0KPiBpbml0X2hlYXBfcGFnZXMoKSBmb3IgTGl2ZS1VcGRhdGUuIEl0
IHdhcyBxdWl0ZSBoYXJkIHRvIGRlYnVnIGJlY2F1c2UgdGhlDQo+IGNvcnJ1cHRpb24gdmVyeSBy
YXJlbHkgaGFwcGVuZWQuIFNvIGxldCBtZSBleHBsYWluIGl0IGJlZm9yZSB5b3UgZmFjZSB0aGUg
c2FtZQ0KPiBpc3N1ZSA6KS4NCj4gDQo+IGZyZWVfaGVhcF9wYWdlcygpIHdpbGwgdHJ5IHRvIG1l
cmdlIHRoZSBhYm91dC10by1iZS1mcmVlZCBjaHVuayB3aXRoIHRoZQ0KPiBwcmVkZWNlc3NvciBh
bmQvb3Igc3VjY2Vzc29yLiBUbyBrbm93IGlmIHRoZSBwYWdlIGNhbiBiZSBtZXJnZWQsIHRoZQ0K
PiBhbGdvcml0aG0gaXMgbG9va2luZyBhdCB3aGV0aGVyIHRoZSBjaHVuayBpcyBzdWl0YWJseSBh
bGlnbmVkIChlLmcuIHNhbWUNCj4gb3JkZXIpIGFuZCBpZiB0aGUgcGFnZSBpcyBpbiBzdGF0ZSBm
cmVlLg0KPiANCj4gQUZBSUNULCB0aGUgcGFnZXMgYmVsb25naW5nIHRvIHRoZSBidWRkeSBhbGxv
Y2F0b3IgY291bGQgYmUgcmlnaHQgbmV4dCB0bw0KPiByZWdpb24gcmVzZXJ2ZWQgbWVtb3J5LiBT
byB0aGVyZSBpcyBhIHZlcnkgc2xpbSBjaGFuY2UgdGhhdA0KPiBmcmVlX2hlYXBfcGFnZXMoKSBt
YXkgZGVjaWRlIHRvIG1lcmdlIGEgY2h1bmsgZnJvbSB0aGUgc3RhdGljIHJlZ2lvbiB3aXRoDQo+
IHRoZSBhYm91dC10by1iZS1mcmVlIGNodW5rLiBOb3RoaW5nIHZlcnkgZ29vZCB3aWxsIGVuc3Vl
Lg0KPiANCg0KT2gsLCwgdGhhdCdzIGEgdGhvdXNhbmQgdHJ1ZS4NCklmIHRoZSBmcmVlIHN0YXRp
YyByZWdpb24gaXMgdGhlIGJ1ZGR5IG9mIHRoZSBhYm91dC10by1iZS1mcmVlIGNodW5rLCBjdXJy
ZW50DQpjb2RlIHdpbGwgbWVyZ2UgdGhlIHN0YXRpYyByZWdpb24gdG8gdGhlIGhlYXAsIHdoaWNo
IGlzIHVuYWNjZXB0YWJsZS4NCg0KSSdsbCBmaXggaXQgaW4gdGhpcyBwYXRjaCBzZXJpZSB0b28g
YW5kIEknbSBhbHNvIHByZWZlcnJpbmcgb3B0aW9uIDF+DQoNCkFuZCBmb3IgdW5wb3B1bGF0aW5n
IG1lbW9yeSBvbiBydW50aW1lLCBJJ2xsIGRvIHdoYXQgSmFuIHN1Z2dlc3RzLA0KYWRkaW5nIGEg
bmV3IGxvZ2ljIG9mIG1vdmluZyB0aGUgcGFnZSBmcm9tIGQtPnBhZ2VfbGlzdCB0bw0KZC0+cmVz
dl9wYWdlX2xpc3QgaW4gYXJjaF9mcmVlX2hlYXBfcGFnZSgpIGZvciByZXNlcnZlZCBwYWdlcy4g
DQoNCj4gVGVjaG5pY2FsbHksIHRoaXMgaXMgYWxyZWFkeSBhIGJ1ZyBpbiB0aGUgYWxyZWFkeSBt
ZXJnZWQgaW1wbGVtZW50YXRpb24gb2YgdGhlDQo+IHN0YXRpYyBtZW1vcnkgYWxsb2NhdG9yLg0K
PiANCj4gSSBjYW4gc2VlIHR3byB3YXlzIHRvIGZpeCBpdDoNCj4gICAgMSkgVXBkYXRlIGZyZWVf
aGVhcF9wYWdlcygpIHRvIGNoZWNrIHdoZXRoZXIgdGhlIHBhZ2UgaGFzIFBHQ19yZXNlcnZlZA0K
PiBzZXQuDQo+ICAgIDIpIFVzZSBhIGRpZmZlcmVudCBzdGF0ZSBmb3IgcGFnZXMgdXNlZCBieSB0
aGUgc3RhdGljIGFsbG9jYXRvci4NCj4gDQo+IFNvIGZhciBteSBwcmVmZXJlbmNlIGlzIGxlYW5p
bmcgdG93YXJkcyAxLiBCdXQgSSB3b3VsZCBsaWtlIHRvIGhlYXIgb3RoZXINCj4gb3BpbmlvbnMu
DQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 11:06:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 11:06:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297780.507297 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nabad-0000Lu-6q; Sat, 02 Apr 2022 11:06:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297780.507297; Sat, 02 Apr 2022 11:06:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nabad-0000Ln-3k; Sat, 02 Apr 2022 11:06:43 +0000
Received: by outflank-mailman (input) for mailman id 297780;
 Sat, 02 Apr 2022 11:06:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nabab-0000Ld-QW; Sat, 02 Apr 2022 11:06:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nabab-0008DH-K6; Sat, 02 Apr 2022 11:06:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nabab-00086v-3h; Sat, 02 Apr 2022 11:06:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nabaa-0007T5-Vq; Sat, 02 Apr 2022 11:06:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wwH//uHPgZGbri24fqaKRr6VssTu10DbUpAt5GcYp5s=; b=u1Gvyhx5T5WmZ/JM2NJG9GI/e7
	jRAhU548mwA44QU5bx//u5xxQu7ZzOus+giTcreRJUcurg3FVTKbR4BW7VuudawatqYcE9e4z/Apn
	IDuGQlL3hxfmj17e3wKeasMg2jD6BfBy3Os0UjoaCK2ak8Gu19QLNypyw2xyPC3CRB90=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169112-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169112: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
X-Osstest-Versions-That:
    xen=ca304edd3ba8c19211107fd2e898249987557ce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 11:06:40 +0000

flight 169112 xen-4.14-testing real [real]
flight 169129 xen-4.14-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169112/
http://logs.test-lab.xenproject.org/osstest/logs/169129/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168506
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168506

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168506
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
baseline version:
 xen                  ca304edd3ba8c19211107fd2e898249987557ce5

Last test of basis   168506  2022-03-10 14:16:31 Z   22 days
Failing since        168862  2022-03-25 17:36:39 Z    7 days    9 attempts
Testing same since   168957  2022-03-28 21:36:20 Z    4 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 14:26:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 14:26:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297801.507312 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naehw-0002ge-01; Sat, 02 Apr 2022 14:26:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297801.507312; Sat, 02 Apr 2022 14:26:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naehv-0002gX-T3; Sat, 02 Apr 2022 14:26:27 +0000
Received: by outflank-mailman (input) for mailman id 297801;
 Sat, 02 Apr 2022 14:26:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naehv-0002gN-5v; Sat, 02 Apr 2022 14:26:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naehv-00037g-0v; Sat, 02 Apr 2022 14:26:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naehu-0002SI-Ga; Sat, 02 Apr 2022 14:26:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naehu-0002qj-EU; Sat, 02 Apr 2022 14:26:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JER/UbhoUV2qMsQKQT4G3WflYlTrD1mg9v0QI6xzdKs=; b=TajQGoWBJCUJ7eVnMv7qgEQe3o
	J5rXE7/W/IcKbr3B171/YJZphVlX4GHbiBXex4oZd2cssKKNVfJ0rnytmjy2YD7d72eiqoWuhSpjZ
	ep/TRUVmMNgRu6tEbPRNOHG+bN8tdrgYDeOzBkMiF3hnIq/AGy+0JJEacf9MqJKBtmYw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169115-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169115: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
X-Osstest-Versions-That:
    xen=cd751c09a5bab9f3529901fbe4d867ad7d52e89d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 14:26:26 +0000

flight 169115 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169115/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168502
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168502

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 169079 pass in 169115
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169079

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168502
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168502
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168502
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168502
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168502
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168502
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168502
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
baseline version:
 xen                  cd751c09a5bab9f3529901fbe4d867ad7d52e89d

Last test of basis   168502  2022-03-10 09:07:57 Z   23 days
Failing since        168863  2022-03-25 17:36:55 Z    7 days    9 attempts
Testing same since   168970  2022-03-29 04:19:26 Z    4 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 16:00:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 16:00:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297816.507325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nagAJ-0002y5-SK; Sat, 02 Apr 2022 15:59:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297816.507325; Sat, 02 Apr 2022 15:59:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nagAJ-0002xy-PU; Sat, 02 Apr 2022 15:59:51 +0000
Received: by outflank-mailman (input) for mailman id 297816;
 Sat, 02 Apr 2022 15:59:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nagAI-0002xc-S5
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 15:59:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nagAI-0004ds-KE; Sat, 02 Apr 2022 15:59:50 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nagAI-0007ZT-EE; Sat, 02 Apr 2022 15:59:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=fGKSKvo4T12PucqAyjUkFUh8cD9XfEnPKGDQY66PD7o=; b=PrhzN2HveYJ906Z8g3WluMWdx5
	niZrajaY6ffCW+VAzOqUbxI2mSfa0aVJqEAJpScjcHvCUTHDk2Soj247R5TiZhyoLidSVs0sWZhGQ
	Jvo6QbjCdeAWdKrVKFn0h/gmEM3rhTvOhUJtpsfjxPwW7K4Nuall+5g2OLu2CJ3j++IE=;
Message-ID: <a2dafd9a-a0a9-b99d-9592-4f8e5fbb3f20@xen.org>
Date: Sat, 2 Apr 2022 16:59:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Julien Grall <jgrall@amazon.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-5-julien@xen.org>
 <alpine.DEB.2.22.394.2204011605580.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 04/19] xen/arm: mm: Allow other mapping size in
 xen_pt_update_entry()
In-Reply-To: <alpine.DEB.2.22.394.2204011605580.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 02/04/2022 00:35, Stefano Stabellini wrote:
>> +/* Return the level where mapping should be done */
>> +static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr,
>> +                                unsigned int flags)
>> +{
>> +    unsigned int level;
>> +    unsigned long mask;
> 
> Shouldn't mask be 64-bit on aarch32?

The 3 variables we will use (mfn, vfn, nr) are unsigned long. So it is 
fine to define the mask as unsigned long.

>> +}
>> +
>>   static DEFINE_SPINLOCK(xen_pt_lock);
>>   
>>   static int xen_pt_update(unsigned long virt,
>>                            mfn_t mfn,
>> -                         unsigned long nr_mfns,
>> +                         const unsigned long nr_mfns,
> 
> Why const? nr_mfns is an unsigned long so it is passed as value: it
> couldn't change the caller's parameter anyway. Just curious.

Because nr_mfns is used to flush the TLBs. In the original I made the 
mistake to decrement the variable and only discovered later on when the 
TLB contained the wrong entry.

Such bug tends to be very subtle and it is hard to find the root cause. 
So better mark the variable const to avoid any surprise.

The short version of what I wrote is in the commit message. I can write 
a small comment in the code if you want.

>>                            unsigned int flags)
>>   {
>>       int rc = 0;
>> -    unsigned long addr = virt, addr_end = addr + nr_mfns * PAGE_SIZE;
>> +    unsigned long vfn = virt >> PAGE_SHIFT;
>> +    unsigned long left = nr_mfns;
>>   
>>       /*
>>        * For arm32, page-tables are different on each CPUs. Yet, they share
>> @@ -1268,14 +1330,24 @@ static int xen_pt_update(unsigned long virt,
>>   
>>       spin_lock(&xen_pt_lock);
>>   
>> -    for ( ; addr < addr_end; addr += PAGE_SIZE )
>> +    while ( left )
>>       {
>> -        rc = xen_pt_update_entry(root, addr, mfn, flags);
>> +        unsigned int order, level;
>> +
>> +        level = xen_pt_mapping_level(vfn, mfn, left, flags);
>> +        order = XEN_PT_LEVEL_ORDER(level);
>> +
>> +        ASSERT(left >= BIT(order, UL));
>> +
>> +        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level, flags);
> 
> NIT: I know we don't have vfn_to_vaddr at the moment and there is no
> widespread usage of vfn in Xen anyway, but it looks off to use
> pfn_to_paddr on a vfn parameter. Maybe open-code pfn_to_paddr instead?
> Or introduce vfn_to_vaddr locally in this file?

To avoid inconsistency with mfn_to_maddr() and gfn_to_gaddr(), I don't 
want ot introduce vfn_to_vaddr() withtout the typesafe part. I think 
this is a bit over the top for now.

So I will open-code pfn_to_paddr().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 16:18:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 16:18:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297822.507340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nagSE-0005rl-EE; Sat, 02 Apr 2022 16:18:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297822.507340; Sat, 02 Apr 2022 16:18:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nagSE-0005re-BE; Sat, 02 Apr 2022 16:18:22 +0000
Received: by outflank-mailman (input) for mailman id 297822;
 Sat, 02 Apr 2022 16:18:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nagSC-0005rY-Mo
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 16:18:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nagSC-0005VE-B3; Sat, 02 Apr 2022 16:18:20 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nagSC-0000Pn-5Z; Sat, 02 Apr 2022 16:18:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=W1SKoUxM25j38sJNlw9ZaiKjGIJole2qbduEv16CJW4=; b=e8SQaH+rfwLLHzBg7BZQCpmseK
	gIh9HfhMwPZB05XAtgdfduvZ+NiASx5t/3j+ya35dMS4zMHjsbBOqILR9Z1GiI0rCPP2SaoH0sJxK
	38vD7Wm731MZWBmsPT6nIGLnj+GTBNQt5ezGOMTAMFeBq9a1OUEXlcVBi5dmhWQri7+c=;
Message-ID: <3a164544-7760-1f57-1af6-c80020b604f0@xen.org>
Date: Sat, 2 Apr 2022 17:18:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-6-julien@xen.org>
 <alpine.DEB.2.22.394.2204011639430.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 05/19] xen/arm: mm: Add support for the contiguous bit
In-Reply-To: <alpine.DEB.2.22.394.2204011639430.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 02/04/2022 00:53, Stefano Stabellini wrote:
> On Mon, 21 Feb 2022, Julien Grall wrote:
>> @@ -1333,21 +1386,34 @@ static int xen_pt_update(unsigned long virt,
>>       while ( left )
>>       {
>>           unsigned int order, level;
>> +        unsigned int nr_contig;
>> +        unsigned int new_flags;
>>   
>>           level = xen_pt_mapping_level(vfn, mfn, left, flags);
>>           order = XEN_PT_LEVEL_ORDER(level);
>>   
>>           ASSERT(left >= BIT(order, UL));
>>   
>> -        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level, flags);
>> -        if ( rc )
>> -            break;
>> +        /*
>> +         * Check if we can set the contiguous mapping and update the
>> +         * flags accordingly.
>> +         */
>> +        nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags);
>> +        new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0);
> 
> Here is an optional idea to make the code simpler. We could move the
> flags changes (adding/removing _PAGE_CONTIG) to xen_pt_check_contig.
> That way, we could remove the inner loop.
> 
> xen_pt_check_contig could check if _PAGE_CONTIG is already set and based
> on alignment, it should be able to figure out when it needs to be
> disabled.

My initial attempt was to do everything in a loop. But this didn't pan 
out as I wanted (I felt the code was complex) and there are extra work 
to be done for the next 31 entries (assuming 4KB granularity).

Hence the two loops. Unfortunately, I didn't keep my first attempt. So I 
can't realy show what I wrote.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 16:38:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 16:38:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297827.507351 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naglj-0008HC-70; Sat, 02 Apr 2022 16:38:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297827.507351; Sat, 02 Apr 2022 16:38:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naglj-0008H5-3o; Sat, 02 Apr 2022 16:38:31 +0000
Received: by outflank-mailman (input) for mailman id 297827;
 Sat, 02 Apr 2022 16:38:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naglh-0008Gz-R6
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 16:38:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naglh-0005pe-HX; Sat, 02 Apr 2022 16:38:29 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naglh-0001aW-Bq; Sat, 02 Apr 2022 16:38:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=oyyXIXR5axftpVf5r5+t111n3XZTLePxzNPxaWkq4bs=; b=G+97kY7C+QIhdzeyQhyapcAbhG
	k+NdB2Yu//wrp4q6DMJLIOWw34CG5x+zrzmlp5hZQGpx1oV47KLS9Lb3+EEdQKIauj7zptLUgMYKj
	vIU+IixddO4kn58QA4NJJcT8N9wGA13FRaO45xji48B0GTiAe36NVB1VpsgxLGM7HFHU=;
Message-ID: <f0d3ed02-450f-9bd1-e8ab-5594234a835d@xen.org>
Date: Sat, 2 Apr 2022 17:38:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-7-julien@xen.org>
 <alpine.DEB.2.22.394.2204011657080.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 06/19] xen/arm: mm: Avoid flushing the TLBs when
 mapping are inserted
In-Reply-To: <alpine.DEB.2.22.394.2204011657080.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 02/04/2022 01:00, Stefano Stabellini wrote:
> On Mon, 21 Feb 2022, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Currently, the function xen_pt_update() will flush the TLBs even when
>> the mappings are inserted. This is a bit wasteful because we don't
>> allow mapping replacement. Even if we were, the flush would need to
>> happen earlier because mapping replacement should use Break-Before-Make
>> when updating the entry.
>>
>> A single call to xen_pt_update() can perform a single action. IOW, it
>> is not possible to, for instance, mix inserting and removing mappings.
>> Therefore, we can use `flags` to determine what action is performed.
>>
>> This change will be particularly help to limit the impact of switching
>> boot time mapping to use xen_pt_update().
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> ---
>>      Changes in v2:
>>          - New patch
>> ---
>>   xen/arch/arm/mm.c | 17 ++++++++++++++---
>>   1 file changed, 14 insertions(+), 3 deletions(-)
>>
>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>> index fd16c1541ce2..7b4b9de8693e 100644
>> --- a/xen/arch/arm/mm.c
>> +++ b/xen/arch/arm/mm.c
>> @@ -1104,7 +1104,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level,
>>           /* We should be here with a valid MFN. */
>>           ASSERT(!mfn_eq(mfn, INVALID_MFN));
>>   
>> -        /* We don't allow replacing any valid entry. */
>> +        /*
>> +         * We don't allow replacing any valid entry.
>> +         *
>> +         * Note that the function xen_pt_update() relies on this
>> +         * assumption and will skip the TLB flush. The function will need
>> +         * to be updated if the check is relaxed.
>> +         */
>>           if ( lpae_is_valid(entry) )
>>           {
>>               if ( lpae_is_mapping(entry, level) )
>> @@ -1417,11 +1423,16 @@ static int xen_pt_update(unsigned long virt,
>>       }
>>   
>>       /*
>> -     * Flush the TLBs even in case of failure because we may have
>> +     * The TLBs flush can be safely skipped when a mapping is inserted
>> +     * as we don't allow mapping replacement (see xen_pt_check_entry()).
>> +     *
>> +     * For all the other cases, the TLBs will be flushed unconditionally
>> +     * even if the mapping has failed. This is because we may have
>>        * partially modified the PT. This will prevent any unexpected
>>        * behavior afterwards.
>>        */
>> -    flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);
>> +    if ( !(flags & _PAGE_PRESENT) || mfn_eq(mfn, INVALID_MFN) )
>> +        flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);
> 
> I am trying to think of a care where the following wouldn't be enough
> but I cannot come up with one:
> 
>     if ( mfn_eq(mfn, INVALID_MFN) )
>         flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);

_PAGE_PRESENT is not set for two cases: when removing a page or 
populating page-tables for a region. Both of them will expect an 
INVALID_MFN (see the two asserts in xen_pt_check_entry()).

Therefore your solution should work. However, technically the 'mfn' is 
ignored in both situation (hence why this is an ASSERT() rather than a 
prod check).

Also, I feel it is better to flush more than less (missing a flush could 
have catastrophic result). So I chose to be explicit in which case the 
flush can be skipped.

Maybe it would be clearer if I write:

  !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN))

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 16:47:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 16:47:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297831.507361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naguL-0001HT-2x; Sat, 02 Apr 2022 16:47:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297831.507361; Sat, 02 Apr 2022 16:47:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naguK-0001HM-Vz; Sat, 02 Apr 2022 16:47:24 +0000
Received: by outflank-mailman (input) for mailman id 297831;
 Sat, 02 Apr 2022 16:47:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1naguK-0001HG-0F
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 16:47:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naguJ-0005z9-OY; Sat, 02 Apr 2022 16:47:23 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1naguJ-0002CE-Ik; Sat, 02 Apr 2022 16:47:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=kmuwigA4T1G3RXa0Hs6iPY+1hOUBVBNRW/sgHnZDlbs=; b=mzer7mBKWGz34qzWaSuRxf/67x
	Om9qA5eyOKz+PBdmKW80rGpdhssjGD+oK/MZ6Sau7fjck2a86AY8zCnMBKwCbjjpkEKf6IBE8R4UM
	upzNlF0F/y2kvqXX9DlZTHYsRVnjZrEx1OExsWxe6REj6hF9iQw38c/YcrMMI2ZGdwK0=;
Message-ID: <b62e61bd-ea54-e41e-17de-a07dbfe477b7@xen.org>
Date: Sat, 2 Apr 2022 17:47:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Julien Grall <jgrall@amazon.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-8-julien@xen.org>
 <alpine.DEB.2.22.394.2204011700520.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 07/19] xen/arm: mm: Don't open-code Xen PT update in
 remove_early_mappings()
In-Reply-To: <alpine.DEB.2.22.394.2204011700520.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 02/04/2022 01:04, Stefano Stabellini wrote:
> On Mon, 21 Feb 2022, Julien Grall wrote:
>> From: Julien Grall <julien.grall@arm.com>
>>
>> Now that xen_pt_update_entry() is able to deal with different mapping
>> size, we can replace the open-coding of the page-tables update by a call
>> to modify_xen_mappings().
>>
>> As the function is not meant to fail, a BUG_ON() is added to check the
>> return.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> Nice!
> 
> 
>> ---
>>      Changes in v2:
>>          - Stay consistent with how function name are used in the commit
>>          message
>>          - Add my AWS signed-off-by
>> ---
>>   xen/arch/arm/mm.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>> index 7b4b9de8693e..f088a4b2de96 100644
>> --- a/xen/arch/arm/mm.c
>> +++ b/xen/arch/arm/mm.c
>> @@ -599,11 +599,11 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
>>   
>>   void __init remove_early_mappings(void)
>>   {
>> -    lpae_t pte = {0};
>> -    write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START), pte);
>> -    write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START + SZ_2M),
>> -              pte);
>> -    flush_xen_tlb_range_va(BOOT_FDT_VIRT_START, BOOT_FDT_SLOT_SIZE);
>> +    int rc;
>> +
>> +    rc = modify_xen_mappings(BOOT_FDT_VIRT_START, BOOT_FDT_VIRT_END,
>> +                             _PAGE_BLOCK);
>> +    BUG_ON(rc);
> 
> Am I right that we are actually destroying the mapping, which usually is
> done by calling destroy_xen_mappings, but we cannot call
> destroy_xen_mappings in this case because it doesn't take a flags
> parameter?

You are right.

> 
> If so, then I would add a flags parameter to destroy_xen_mappings
> instead of calling modify_xen_mappings just to pass _PAGE_BLOCK.
> But I don't feel strongly about it so if you don't feel like making the
> change to destroy_xen_mappings, you can add my acked-by here anyway.

destroy_xen_mappings() is a function used by common code. This is the 
only place so far where I need to pass _PAGE_BLOCK and I don't expect it 
to be used by the common code any time soon.

So I am not in favor to add an extra parameter for destroy_xen_mappings().

Would you prefer if I open-code the call to xen_pt_update?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 17:02:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 17:02:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297835.507373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nah8x-0003dF-Eh; Sat, 02 Apr 2022 17:02:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297835.507373; Sat, 02 Apr 2022 17:02:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nah8x-0003d8-Av; Sat, 02 Apr 2022 17:02:31 +0000
Received: by outflank-mailman (input) for mailman id 297835;
 Sat, 02 Apr 2022 17:02:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nah8w-0003d2-Aw
 for xen-devel@lists.xenproject.org; Sat, 02 Apr 2022 17:02:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nah8v-0006Ge-To; Sat, 02 Apr 2022 17:02:29 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nah8v-0007is-O1; Sat, 02 Apr 2022 17:02:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=61zOOhq4fMWl0c3FHL17jaeRFSyxSn+t6WbxNFd6Na8=; b=eixzIrQZuwv+unLqFlJVnnUjEo
	jjey82XN5Q28RY1+1JOh9sR/vcbmxEWjdDe6C36qqMVU7Re3F7raF5u7Tl97/Yshnk95m5NtEnvnZ
	C9yKTaTjXzDtaPCFznEoC6xF8JRq3k+lK2HmSy1tk/MNOzyqVfCvs2zR1y/ez3NTro6E=;
Message-ID: <7e57f963-40a0-49e4-84a3-04b17dfc8497@xen.org>
Date: Sat, 2 Apr 2022 18:02:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Julien Grall <jgrall@amazon.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-9-julien@xen.org>
 <alpine.DEB.2.22.394.2204011709140.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 08/19] xen/arm: mm: Re-implement early_fdt_map() using
 map_pages_to_xen()
In-Reply-To: <alpine.DEB.2.22.394.2204011709140.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 02/04/2022 01:10, Stefano Stabellini wrote:
> On Mon, 21 Feb 2022, Julien Grall wrote:
>> From: Julien Grall <julien.grall@arm.com>
>>
>> Now that map_pages_to_xen() has been extended to support 2MB mappings,
>> we can replace the create_mappings() calls by map_pages_to_xen() calls.
>>
>> The mapping can also be marked read-only has Xen as no business to
>> modify the host Device Tree.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> ---
>>      Changes in v2:
>>          - Add my AWS signed-off-by
>>          - Fix typo in the commit message
>> ---
>>   xen/arch/arm/mm.c | 18 +++++++++++++-----
>>   1 file changed, 13 insertions(+), 5 deletions(-)
>>
>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>> index f088a4b2de96..24de8dcb9042 100644
>> --- a/xen/arch/arm/mm.c
>> +++ b/xen/arch/arm/mm.c
>> @@ -559,6 +559,7 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
>>       paddr_t offset;
>>       void *fdt_virt;
>>       uint32_t size;
>> +    int rc;
>>   
>>       /*
>>        * Check whether the physical FDT address is set and meets the minimum
>> @@ -574,8 +575,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
>>       /* The FDT is mapped using 2MB superpage */
>>       BUILD_BUG_ON(BOOT_FDT_VIRT_START % SZ_2M);
>>   
>> -    create_mappings(xen_second, BOOT_FDT_VIRT_START, paddr_to_pfn(base_paddr),
>> -                    SZ_2M >> PAGE_SHIFT, SZ_2M);
>> +    rc = map_pages_to_xen(BOOT_FDT_VIRT_START, maddr_to_mfn(base_paddr),
>> +                          SZ_2M >> PAGE_SHIFT,
>> +                          PAGE_HYPERVISOR_RO | _PAGE_BLOCK);
>> +    if ( rc )
>> +        panic("Unable to map the device-tree.\n");
>> +
>>   
>>       offset = fdt_paddr % SECOND_SIZE;
>>       fdt_virt = (void *)BOOT_FDT_VIRT_START + offset;
>> @@ -589,9 +594,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
>>   
>>       if ( (offset + size) > SZ_2M )
>>       {
>> -        create_mappings(xen_second, BOOT_FDT_VIRT_START + SZ_2M,
>> -                        paddr_to_pfn(base_paddr + SZ_2M),
>> -                        SZ_2M >> PAGE_SHIFT, SZ_2M);
>> +        rc = map_pages_to_xen(BOOT_FDT_VIRT_START + SZ_2M,
>> +                              maddr_to_mfn(base_paddr + SZ_2M),
>> +                              SZ_2M >> PAGE_SHIFT,
>> +                              PAGE_HYPERVISOR_RO | _PAGE_BLOCK);
>> +        if ( rc )
>> +            panic("Unable to map the device-tree\n");
>>       }
> 
> Very good! :-)
> 
> I have a small preference for making the change to PAGE_HYPERVISOR_RO in
> a separate patch because it would make it easier to revert in the
> future if we need so (e.g. overlays...). But it is OK either way.

The mapping is only used for early boot. For runtime we are relocating 
the FDT and it is writable.

That said, I don't think the FDT should ever be writable. The size of 
the FDT is bounded and therefore you will likely not be able to add a 
new property/node without relocating it.

I haven't looked at latest DT overlay series. But in the previous 
version I was under the impression that only the unflatten version would 
be touched. IOW, the flatten version would be untouched. Can you confirm 
this is still the case?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 17:38:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 17:38:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297843.507384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nahhW-0006yu-Ao; Sat, 02 Apr 2022 17:38:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297843.507384; Sat, 02 Apr 2022 17:38:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nahhW-0006yn-6Q; Sat, 02 Apr 2022 17:38:14 +0000
Received: by outflank-mailman (input) for mailman id 297843;
 Sat, 02 Apr 2022 17:38:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nahhU-0006yd-P9; Sat, 02 Apr 2022 17:38:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nahhU-0006pi-L9; Sat, 02 Apr 2022 17:38:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nahhU-00060F-6M; Sat, 02 Apr 2022 17:38:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nahhT-0005OE-WA; Sat, 02 Apr 2022 17:38:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aS4GSOetrwHziAJcG9QvFtyUX8y0YS+yNUHriObTxLU=; b=OoMPfNmlsm/+hoXnMPFv8IbTbg
	A1Mx7YcXT7G0jOS/xV+fSNvm4ml7L4PFWwUvJKUL5AawCtpGqQbbKA1BmGy0UMXiSr8lXHxMTtXXr
	Sz+IWz8hfSTQdFtHA7yyfRY/rMGNForgA6YkZ20aeiIouX8+ExlIqOxfBkyXNe6seKSI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169126-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169126: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=b7f5ad4610856dc82618ed82c5cab3124be65274
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 17:38:11 +0000

flight 169126 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169126/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              b7f5ad4610856dc82618ed82c5cab3124be65274
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  631 days
Failing since        151818  2020-07-11 04:18:52 Z  630 days  612 attempts
Testing same since   169126  2022-04-02 04:20:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 102979 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 18:05:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 18:05:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297878.507491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nai7E-0003Ed-Nq; Sat, 02 Apr 2022 18:04:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297878.507491; Sat, 02 Apr 2022 18:04:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nai7E-0003EW-Jh; Sat, 02 Apr 2022 18:04:48 +0000
Received: by outflank-mailman (input) for mailman id 297878;
 Sat, 02 Apr 2022 18:04:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nai7D-0003EL-3N; Sat, 02 Apr 2022 18:04:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nai7C-0007QZ-TW; Sat, 02 Apr 2022 18:04:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nai7C-00074b-Hr; Sat, 02 Apr 2022 18:04:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nai7C-0003pk-HK; Sat, 02 Apr 2022 18:04:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=I1wFcNZBeiTInXmWUw8ypG0EHDzPaDZ0xbKDRtwYUj8=; b=UjBFmjU98aHVBuEEoGZz284rm5
	szJ/mjOUPZvXrdYYwuhjx/gUWi5Rsnj8tyNqOQQBj+mXbX1PzRvG03ozzXKtZYKtQgjJ4HTAulJU+
	s6kc9Kha+n4VQNi5mdw4v0fjXLgUwVR3hc2Msyllf+/O1F1gp0HY0OIaqOox5+RM6jwI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169119-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 169119: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e34c16cc6ee029fa75c35bd21f75103d5502ea30
X-Osstest-Versions-That:
    xen=cfd29b83a26f35f49f074f06169ce4cadfdebf0d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 18:04:46 +0000

flight 169119 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169119/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168513
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168513
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168513
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168513
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168513
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168513
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168513
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168513
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168513
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168513
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168513
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168513
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  e34c16cc6ee029fa75c35bd21f75103d5502ea30
baseline version:
 xen                  cfd29b83a26f35f49f074f06169ce4cadfdebf0d

Last test of basis   168513  2022-03-11 05:13:34 Z   22 days
Failing since        168864  2022-03-25 17:37:01 Z    8 days   10 attempts
Testing same since   169086  2022-03-31 23:18:16 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Olson <Alex.Olson@starlab.io>
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   cfd29b83a2..e34c16cc6e  e34c16cc6ee029fa75c35bd21f75103d5502ea30 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 20:14:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 20:14:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297915.507520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nak8q-00088K-Tz; Sat, 02 Apr 2022 20:14:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297915.507520; Sat, 02 Apr 2022 20:14:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nak8q-00088D-QX; Sat, 02 Apr 2022 20:14:36 +0000
Received: by outflank-mailman (input) for mailman id 297915;
 Sat, 02 Apr 2022 20:14:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nak8p-000883-Oz; Sat, 02 Apr 2022 20:14:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nak8p-0001GQ-Kn; Sat, 02 Apr 2022 20:14:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nak8o-00056A-4q; Sat, 02 Apr 2022 20:14:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nak8o-00007O-4K; Sat, 02 Apr 2022 20:14:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4rcwtAlgqd7obI6fn5fDnrkhIW7GtxsJswSQLkeonSg=; b=DOG4HbLapNmhEKY2zS7Pr2rEkd
	1U/TtfYtHObVi9E6tkRp+zRsi6GyTV0HGwC4duxkfKEBjEoWJG5k75LpjEnM2rv4zwzhBNH0SSfBh
	T9EuAlqM541V69wUiZOo/h22vWin7ftUKKtU9v9e/DC/AjFnKOjN+VwPrZ/DYTg3UBJ8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169123-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169123: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-pair:guests-nbd-mirror/debian:fail:regression
    linux-linus:test-amd64-amd64-libvirt-pair:guests-nbd-mirror/debian:fail:regression
    linux-linus:test-armhf-armhf-libvirt:host-ping-check-xen:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=8467b0ed6ce37f7e3f87aa3826627dc9cc55ecb2
X-Osstest-Versions-That:
    linux=e8b767f5e04097aaedcd6e06e2270f9fe5282696
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 20:14:34 +0000

flight 169123 linux-linus real [real]
flight 169133 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169123/
http://logs.test-lab.xenproject.org/osstest/logs/169133/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-pair        22 guests-nbd-mirror/debian fail REGR. vs. 169100
 test-amd64-amd64-libvirt-pair 22 guests-nbd-mirror/debian fail REGR. vs. 169100

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt     10 host-ping-check-xen fail pass in 169133-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 169133 like 169100
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 169133 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169100
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169100
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169100
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169100
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169100
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169100
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169100
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                8467b0ed6ce37f7e3f87aa3826627dc9cc55ecb2
baseline version:
 linux                e8b767f5e04097aaedcd6e06e2270f9fe5282696

Last test of basis   169100  2022-04-01 04:55:02 Z    1 days
Testing same since   169123  2022-04-02 01:11:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Sean O'Brien" <seobrien@chromium.org>
  Al Viro <viro@zeniv.linux.org.uk>
  Alexander Gordeev <agordeev@linux.ibm.com>
  Alexandre Belloni <alexandre.belloni@bootlin.com>
  Ali Pouladi <quic_apouladi@quicinc.com>
  Almog Khaikin <almogkh@gmail.com>
  Andre Przywara <andre.przywara@arm.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Konovalov <andreyknvl@google.com>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Anup Patel <anup.patel@wdc.com>
  Anup Patel <apatel@ventanamicro.com>
  Anup Patel <apatel@vetanamicro.com>
  Ard Biesheuvel <ardb@kernel.org>
  Arnd Bergmann <arnd@arndb.de>
  Atish Patra <atishp@rivosinc.com>
  Bagas Sanjaya <bagasdotme@gmail.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Carlos Llamas <cmllamas@google.com>
  Charan Teja Kalla <quic_charante@quicinc.com>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Chris Leech <cleech@redhat.com>
  Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Clément Léger <clement.leger@bootlin.com>
  Colin Ian King <colin.i.king@gmail.com>
  Danilo Krummrich <danilokrummrich@dk-develop.de>
  David Disseldorp <ddiss@suse.de>
  David Howells <dhowells@redhat.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dmitry Vyukov <dvyukov@google.com>
  Dongli Zhang <dongli.zhang@oracle.com>
  Dylan Yudaken <dylany@fb.com>
  Elliot Berman <quic_eberman@quicinc.com>
  Fangrui Song <maskray@google.com>
  fengping.yu <fengping.yu@mediatek.com>
  Hans de Goede <hdegoede@redhat.com>
  Haowen Bai <baihaowen@meizu.com>
  Harald Freudenberger <freude@de.ibm.com>
  Harald Freudenberger <freude@linux.ibm.com>
  Heiko Carstens <hca@linux.ibm.com>
  Hugh Dickins <hughd@google.com>
  Hugo Villeneuve <hvilleneuve@dimonoff.com>
  Hyunchul Lee <hyc.lee@gmail.com>
  Jackie Liu <liuyun01@kylinos.cn>
  Jakob Koschel <jakobkoschel@gmail.com>
  Jeff LaBundy <jeff@labundy.com>
  Jens Axboe <axboe@kernel.dk>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jiaxin Yu <jiaxin.yu@mediatek.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Joey Gouly <joey.gouly@arm.com>
  Jonghyeon Kim <tome01@ajou.ac.kr>
  Joseph Qi <joseph.qi@linux.alibaba.com>
  José Expósito <jose.exposito89@gmail.com>
  Juergen Christ <jchrist@linux.ibm.com>
  Julia Lawall <Julia.Lawall@inria.fr>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kees Cook <keescook@chromium.org>
  Kirill Tkhai <kirill.tkhai@openvz.org>
  Kris Bahnsen <kris@embeddedTS.com>
  Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
  Kuldeep Singh <singh.kuldeep87k@gmail.com>
  Lars Ellenberg <lars.ellenberg@linbit.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Loic Poulain <loic.poulain@linaro.org>
  Lv Ruyi (CGEL ZTE) <lv.ruyi@zte.com.cn>
  Marcos Alano <marcoshalano@gmail.com>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Markuss Broks <markuss.broks@gmail.com>
  Mateusz Jończyk <mat.jonczyk@o2.pl>
  Matthew Haughton <snafu109@gmail.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Mattijs Korpershoek <mkorpershoek@baylibre.com>
  Meng Tang <tangmeng@uniontech.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michal Hocko <mhocko@suse.com>
  Mike Snitzer <snitzer@kernel.org>
  Mikulas Patocka <mpatocka@redhat.com>
  Milan Broz <gmazyland@gmail.com>
  Ming Lei <ming.lei@redhat.com>
  Mohan Kumar <mkumard@nvidia.com>
  Monish Kumar R <monish.kumar.r@intel.com>
  Muchun Song <songmuchun@bytedance.com>
  Namjae Jeon <linkinjeon@kernel.org>
  Naoya Horiguchi <naoya.horiguchi@nec.com>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nikita Shubin <n.shubin@yadro.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Niklas Schnelle <schnelle@linux.ibm.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Pankaj Raghav <p.raghav@samsung.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Paulo Alcantara <pc@cjr.nz>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Hutterer <peter.hutterer@who-t.net>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Raul E Rangel <rrangel@chromium.org>
  Rik van Riel <riel@surriel.com>
  Rob Herring <robh@kernel.org>
  Roger Pau Monné <roger.pau@citrix.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Russell Currey <ruscur@russell.cc>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Sagi Grimberg <sagi@grimberg.me>
  Samuel Holland <samuel@sholland.org>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  Sergiu Moga <sergiu.moga@microchip.com>
  Shengjiu Wang <shengjiu.wang@gmail.com>
  Stefan Binding <sbinding@opensource.cirrus.com>
  Stephen Boyd <sboyd@kernel.org>
  Stephen Boyd <swboyd@chromium.org>
  Stephen Boyd <swboyd@chromium.org> # coachz, wormdingler
  Steve French <stfrench@microsoft.com>
  Sungup Moon <sungup.moon@samsung.com>
  Takashi Iwai <tiwai@suse.de>
  Tobias Klauser <tklauser@distanz.ch>
  Tom Rix <trix@redhat.com>
  Tony Krowiak <akrowiak@linux.ibm.com>
  Tony Lindgren <tony@atomide.com>
  Valentin Vidic <vvidic@valentin-vidic.from.hr>
  Vasant Karasulli <vkarasulli@suse.de>
  Vasily Gorbik <gor@linux.ibm.com>
  Victor Erminpour <victor.erminpour@oracle.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vitaly Rodionov <vitalyr@opensource.cirrus.com>
  Vlastimil Babka <vbabka@suse.cz>
  Wu Caize <zepan@sipeed.com>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>
  Xin Hao <xhao@linux.alibaba.com>
  Yinan Zhang <zhangyinan2019@email.szu.edu.cn>
  Yu Liao <liaoyu15@huawei.com>
  Yuezhang Mo <Yuezhang.Mo@sony.com>
  Yunus Bas <y.bas@phytec.de>
  Zhang Wensheng <zhangwensheng5@huawei.com>
  Zheng Bin <zhengbin13@huawei.com>
  Zheng Yongjun <zhengyongjun3@huawei.com>
  Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        fail    
 test-amd64-amd64-libvirt-pair                                fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 6148 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 02 22:28:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Apr 2022 22:28:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297928.507531 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1namER-0003w6-HU; Sat, 02 Apr 2022 22:28:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297928.507531; Sat, 02 Apr 2022 22:28:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1namER-0003vz-Ea; Sat, 02 Apr 2022 22:28:31 +0000
Received: by outflank-mailman (input) for mailman id 297928;
 Sat, 02 Apr 2022 22:28:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1namEP-0003vp-D8; Sat, 02 Apr 2022 22:28:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1namEP-0003Ru-BA; Sat, 02 Apr 2022 22:28:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1namEO-0004P1-V5; Sat, 02 Apr 2022 22:28:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1namEO-0003IC-Ud; Sat, 02 Apr 2022 22:28:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=r07diOJaNiII+ErCC1J8+JOzTo1yPSp9iM2BYI7GGfY=; b=aoMRl6YgyqpreK/rBPnTmdd5IR
	x6sZ07TQROS9cg1LoKngE31e4zFl3D9LznFpqm3EzF8RLu2sv+G+sfKbNF0agnkKlIUSC6fOoBxAk
	6KjrzXJLA9nZ02T8+czZ9S5Q2vL/3Q3mz/damaghsDd3C19KWfgPeteui7cio2E8k6X8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169128-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169128: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b328bb54c6e5510bc687302e4b717694bd441891
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 02 Apr 2022 22:28:28 +0000

flight 169128 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169128/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b328bb54c6e5510bc687302e4b717694bd441891
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   33 days
Failing since        168258  2022-03-01 01:55:31 Z   32 days  268 attempts
Testing same since   169128  2022-04-02 08:13:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Yi Li <yi1.li@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1336 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 02:03:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 02:03:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297941.507550 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1napaH-00015C-JJ; Sun, 03 Apr 2022 02:03:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297941.507550; Sun, 03 Apr 2022 02:03:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1napaH-00014l-Al; Sun, 03 Apr 2022 02:03:17 +0000
Received: by outflank-mailman (input) for mailman id 297941;
 Sun, 03 Apr 2022 02:03:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1napaF-00014b-RW; Sun, 03 Apr 2022 02:03:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1napaF-0000SQ-Oy; Sun, 03 Apr 2022 02:03:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1napaE-0007aG-44; Sun, 03 Apr 2022 02:03:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1napaE-0004Ms-2t; Sun, 03 Apr 2022 02:03:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=swcJoJ+l6YEhRXRtJP5KsFT4/ZoKu/9YBJWbAzeAN/Y=; b=L5oSGMZZr9DkpR0pU7IPsAWAGl
	/aMlC6fC1Eb+1KKlpbHjdaCZNMTo0rcym7asEP+4LJ/3NBcHImiX0+LCDlXJNf/mGe9wZcVUM1gw1
	a1Q8m0XoR3NXTyMFiPuaVKcNVNcplISBbOaIKyACyyGV1kUJxEuuddKPYPFgLuzYEB0g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169125-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169125: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d62a34423a1a98aefd7c30e22d2d82d198f077c8
X-Osstest-Versions-That:
    xen=e7cfcdc6719d586eb7cdb62d40275a7d17fe6760
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 02:03:14 +0000

flight 169125 xen-unstable real [real]
flight 169136 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169125/
http://logs.test-lab.xenproject.org/osstest/logs/169136/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 169136-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169106
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169106
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169106
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169106
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169106
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169106
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169106
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169106
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169106
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169106
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169106
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169106
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d62a34423a1a98aefd7c30e22d2d82d198f077c8
baseline version:
 xen                  e7cfcdc6719d586eb7cdb62d40275a7d17fe6760

Last test of basis   169106  2022-04-01 08:47:00 Z    1 days
Testing same since   169125  2022-04-02 03:41:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jason Andryuk <jandryuk@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e7cfcdc671..d62a34423a  d62a34423a1a98aefd7c30e22d2d82d198f077c8 -> master


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 02:44:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 02:44:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297949.507561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naqED-0005F5-Op; Sun, 03 Apr 2022 02:44:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297949.507561; Sun, 03 Apr 2022 02:44:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naqED-0005Ey-K3; Sun, 03 Apr 2022 02:44:33 +0000
Received: by outflank-mailman (input) for mailman id 297949;
 Sun, 03 Apr 2022 02:44:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naqEC-0005Eo-Lt; Sun, 03 Apr 2022 02:44:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naqEC-00019Z-HR; Sun, 03 Apr 2022 02:44:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naqEB-0001Au-VI; Sun, 03 Apr 2022 02:44:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naqEB-0004Vg-Uq; Sun, 03 Apr 2022 02:44:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VyI9qFkwKaD9AKv03ucIrzp/JE4Jgkd5LvxARMzPFQ8=; b=FD2lPd4cqqquDecaMubzyriWaB
	pqZ8LPWLAipeVudTYpaB5EjrvYiPk+zlCwvNzOyQyh4GknVsoQeFCKQ8qjvSYUri59x5uiANvZLmI
	8TNgpHFyiQ8J2CCMuvsa4IQceejtWxJQFek48nKrGkRO4jBCSC1nSelcu+1v2Jj2GIYk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169127-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169127: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=697d18b1bd2667efa418cc7d7248d5450da547e7
X-Osstest-Versions-That:
    qemuu=d5341e09135b871199073572f53bc11ae9b44897
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 02:44:31 +0000

flight 169127 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169127/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169110
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169110
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169110
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169110
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169110
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169110
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169110
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169110
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                697d18b1bd2667efa418cc7d7248d5450da547e7
baseline version:
 qemuu                d5341e09135b871199073572f53bc11ae9b44897

Last test of basis   169110  2022-04-01 13:34:58 Z    1 days
Testing same since   169127  2022-04-02 07:42:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  eop Chen <eop.chen@sifive.com>
  Laurent Vivier <laurent@vivier.eu>
  Palmer Dabbelt <palmer@rivosinc.com>
  Peter Maydell <peter.maydell@linaro.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Yueh-Ting (eop) Chen <eop.chen@sifive.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   d5341e0913..697d18b1bd  697d18b1bd2667efa418cc7d7248d5450da547e7 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 05:56:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 05:56:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297964.507572 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1natDG-0006dw-6g; Sun, 03 Apr 2022 05:55:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297964.507572; Sun, 03 Apr 2022 05:55:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1natDG-0006dp-2U; Sun, 03 Apr 2022 05:55:46 +0000
Received: by outflank-mailman (input) for mailman id 297964;
 Sun, 03 Apr 2022 05:55:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1natDE-0006df-6L; Sun, 03 Apr 2022 05:55:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1natDE-0004mz-2s; Sun, 03 Apr 2022 05:55:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1natDC-0003Cv-8V; Sun, 03 Apr 2022 05:55:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1natDC-0004jZ-5V; Sun, 03 Apr 2022 05:55:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1kTZ/XLS84p79hXJwBejdNtoVpom/p5g2I7T6+45PPI=; b=LPg8xdRBuvhbSzR3Y6g82nmeYP
	jxtMFGwa5GjGymzT9JpCXChy6cqxj8LuTgqV815PPmA318FftdbRIdA/L2IGoAoRM229faG0XKGLO
	9fOXVIycomj+U1G30UKe7Q3RPxqi4GFXPwIRjmVwpi0dIsIYqzDGQQ0dVEQxpRsGYi0s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169130-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169130: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
X-Osstest-Versions-That:
    xen=ca304edd3ba8c19211107fd2e898249987557ce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 05:55:42 +0000

flight 169130 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169130/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168506
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168506

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-xsm      22 guest-start/debian.repeat  fail pass in 169112
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169112
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169112

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168506
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
baseline version:
 xen                  ca304edd3ba8c19211107fd2e898249987557ce5

Last test of basis   168506  2022-03-10 14:16:31 Z   23 days
Failing since        168862  2022-03-25 17:36:39 Z    8 days   10 attempts
Testing same since   168957  2022-03-28 21:36:20 Z    5 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 08:39:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 08:39:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297984.507583 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1navl0-0005Mz-3h; Sun, 03 Apr 2022 08:38:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297984.507583; Sun, 03 Apr 2022 08:38:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1navkz-0005Ms-Vf; Sun, 03 Apr 2022 08:38:45 +0000
Received: by outflank-mailman (input) for mailman id 297984;
 Sun, 03 Apr 2022 08:38:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1navky-0005Mi-GV; Sun, 03 Apr 2022 08:38:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1navky-00082m-CI; Sun, 03 Apr 2022 08:38:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1navkx-0004dJ-Sw; Sun, 03 Apr 2022 08:38:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1navkx-0001Zp-S0; Sun, 03 Apr 2022 08:38:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UYMy5e+ynEvkMJLIVFHs3UaQ23elz3yxf/qpK25EVMk=; b=F5vYpVDSXPArpwXCtUmxf+nKjq
	9j3l/ypFGg7sw2zC/9HPhQbH50VTB339zbNjzHiJhC9mBMm6iBAcLUHjFTDDPCQ5iL/p49SIoke+5
	pQx9olP9kvkOewL2jmFlJLWhxqIbYtCFB4qsj3P+N4VebRcC+xADbppjkgfphwR78vWw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169135-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169135: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=7fda517c3d576b4c8d3ea9ae63e7bf441c55ade4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 08:38:43 +0000

flight 169135 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169135/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 7fda517c3d576b4c8d3ea9ae63e7bf441c55ade4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   33 days
Failing since        168258  2022-03-01 01:55:31 Z   33 days  269 attempts
Testing same since   169135  2022-04-02 22:41:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Yi Li <yi1.li@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3156 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 10:40:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 10:40:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.297994.507594 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naxeX-0000hP-Vr; Sun, 03 Apr 2022 10:40:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 297994.507594; Sun, 03 Apr 2022 10:40:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naxeX-0000hI-Re; Sun, 03 Apr 2022 10:40:13 +0000
Received: by outflank-mailman (input) for mailman id 297994;
 Sun, 03 Apr 2022 10:40:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naxeW-0000h3-MU; Sun, 03 Apr 2022 10:40:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naxeW-0001iF-Ey; Sun, 03 Apr 2022 10:40:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naxeV-0003cU-Uv; Sun, 03 Apr 2022 10:40:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naxeV-00036Y-US; Sun, 03 Apr 2022 10:40:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WypeY6qgW29Wz257Jxp9UNyZafYdRsBswbBWdpKbJHc=; b=KmmL1Pfp5FLuDEkTpkDQFH/Dk2
	IooYhEXEhSOCw/vIWtbjMX0Zagfi53L+fcgv0it+F1HmmUEdGjRezAPUmhXqGO+wOoz55eIp37eO9
	0IUiENLnu3ld5rV962cZHKMKCm0VNa1DebGcU1ONun4dw2kHO+elxDHNsCGqcDJNpnds=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169132-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169132: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
X-Osstest-Versions-That:
    xen=cd751c09a5bab9f3529901fbe4d867ad7d52e89d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 10:40:11 +0000

flight 169132 xen-4.15-testing real [real]
flight 169142 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169132/
http://logs.test-lab.xenproject.org/osstest/logs/169142/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168502
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168502

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168502
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168502
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168502
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168502
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168502
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168502
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
baseline version:
 xen                  cd751c09a5bab9f3529901fbe4d867ad7d52e89d

Last test of basis   168502  2022-03-10 09:07:57 Z   24 days
Failing since        168863  2022-03-25 17:36:55 Z    8 days   10 attempts
Testing same since   168970  2022-03-29 04:19:26 Z    5 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 11:06:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 11:06:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298003.507604 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nay3z-0003Eu-24; Sun, 03 Apr 2022 11:06:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298003.507604; Sun, 03 Apr 2022 11:06:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nay3y-0003En-V9; Sun, 03 Apr 2022 11:06:30 +0000
Received: by outflank-mailman (input) for mailman id 298003;
 Sun, 03 Apr 2022 11:06:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nay3y-0003Ed-AX; Sun, 03 Apr 2022 11:06:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nay3y-00028u-6P; Sun, 03 Apr 2022 11:06:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nay3x-0004jR-Rd; Sun, 03 Apr 2022 11:06:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nay3x-000864-R6; Sun, 03 Apr 2022 11:06:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ng4P1HYiuEkVk3GoqlVjbrossMPTUdYmjKppjoT2MJE=; b=bfzCg0+e8Dng1ZBt3zVTlOob35
	v1lkPMau5gBK7kFXYkd5iDS0gMBfFwjg7KPxft8AT3A9L75dWWcbM02BIP8O/5xEB+uVIE4qXHaTb
	5OPUsc9GQOUwQJbMXpF4gf5l6RogaKoVAOBUthjqeTpYOuYizjmeFmRLwX1D/9yhWZNY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169134-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169134: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf
X-Osstest-Versions-That:
    linux=e8b767f5e04097aaedcd6e06e2270f9fe5282696
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 11:06:29 +0000

flight 169134 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169134/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169100
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169100
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169100
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169100
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169100
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169100
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169100
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169100
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf
baseline version:
 linux                e8b767f5e04097aaedcd6e06e2270f9fe5282696

Last test of basis   169100  2022-04-01 04:55:02 Z    2 days
Failing since        169123  2022-04-02 01:11:38 Z    1 days    2 attempts
Testing same since   169134  2022-04-02 20:17:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Sean O'Brien" <seobrien@chromium.org>
  Al Viro <viro@zeniv.linux.org.uk>
  Alexander Gordeev <agordeev@linux.ibm.com>
  Alexandre Belloni <alexandre.belloni@bootlin.com>
  Ali Pouladi <quic_apouladi@quicinc.com>
  Almog Khaikin <almogkh@gmail.com>
  Alyssa Ross <hi@alyssa.is>
  Andre Przywara <andre.przywara@arm.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Konovalov <andreyknvl@google.com>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Anup Patel <anup.patel@wdc.com>
  Anup Patel <apatel@ventanamicro.com>
  Anup Patel <apatel@vetanamicro.com>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Atish Patra <atishp@rivosinc.com>
  Bagas Sanjaya <bagasdotme@gmail.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Benson Leung <bleung@chromium.org>
  Bjorn Helgaas <bhelgaas@google.com>
  Boqun Feng <boqun.feng@gmail.com>
  Carlos Llamas <cmllamas@google.com>
  Charan Teja Kalla <quic_charante@quicinc.com>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Chris Leech <cleech@redhat.com>
  Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Clément Léger <clement.leger@bootlin.com>
  Colin Ian King <colin.i.king@gmail.com>
  Danilo Krummrich <danilokrummrich@dk-develop.de>
  Darrick J. Wong <djwong@kernel.org>
  Dave Chinner <dchinner@redhat.com>
  David Disseldorp <ddiss@suse.de>
  David Gow <davidgow@google.com>
  David Howells <dhowells@redhat.com>
  David Matlack <dmatlack@google.com>
  David Woodhouse <dwmw2@infradead.org>
  David Woodhouse <dwmw@amazon.co.uk>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dmitry Vyukov <dvyukov@google.com>
  Dongli Zhang <dongli.zhang@oracle.com>
  Dylan Yudaken <dylany@fb.com>
  Elliot Berman <quic_eberman@quicinc.com>
  Eric Dumazet <edumazet@google.com>
  Fangrui Song <maskray@google.com>
  fengping.yu <fengping.yu@mediatek.com>
  Guo Xuenan <guoxuenan@huawei.com>
  Gwendal Grignou <gwendal@chromium.org>
  Hans de Goede <hdegoede@redhat.com>
  Haowen Bai <baihaowen@meizu.com>
  Harald Freudenberger <freude@de.ibm.com>
  Harald Freudenberger <freude@linux.ibm.com>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Heiko Carstens <hca@linux.ibm.com>
  Hou Wenlong <houwenlong.hwl@antgroup.com>
  Hugh Dickins <hughd@google.com>
  Hugo Villeneuve <hvilleneuve@dimonoff.com>
  Hyunchul Lee <hyc.lee@gmail.com>
  Ian Rogers <irogers@google.com>
  Jackie Liu <liuyun01@kylinos.cn>
  Jakob Koschel <jakobkoschel@gmail.com>
  Jeff LaBundy <jeff@labundy.com>
  Jens Axboe <axboe@kernel.dk>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jiaxin Yu <jiaxin.yu@mediatek.com>
  Jim Mattson <jmattson@google.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Joey Gouly <joey.gouly@arm.com>
  John Garry <john.garry@huawei.com>
  Jonghyeon Kim <tome01@ajou.ac.kr>
  Joseph Qi <joseph.qi@linux.alibaba.com>
  José Expósito <jose.exposito89@gmail.com>
  Juergen Christ <jchrist@linux.ibm.com>
  Julia Lawall <Julia.Lawall@inria.fr>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kees Cook <keescook@chromium.org>
  Kirill Tkhai <kirill.tkhai@openvz.org>
  Kris Bahnsen <kris@embeddedTS.com>
  Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
  Kuldeep Singh <singh.kuldeep87k@gmail.com>
  Lai Jiangshan <jiangshan.ljs@antgroup.com>
  Lars Ellenberg <lars.ellenberg@linbit.com>
  Li RongQing <lirongqing@baidu.com>
  Like Xu <likexu@tencent.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Loic Poulain <loic.poulain@linaro.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Lv Ruyi (CGEL ZTE) <lv.ruyi@zte.com.cn>
  Marcos Alano <marcoshalano@gmail.com>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Markuss Broks <markuss.broks@gmail.com>
  Masahiro Yamada <masahiroy@kernel.org>
  Mateusz Jończyk <mat.jonczyk@o2.pl>
  Matthew Haughton <snafu109@gmail.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Matthieu Baerts <matthieu.baerts@tessares.net>
  Mattijs Korpershoek <mkorpershoek@baylibre.com>
  Maxim Levitsky <mlevitsk@redhat.com>
  Maíra Canal <maira.canal@usp.br>
  Meng Tang <tangmeng@uniontech.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michal Hocko <mhocko@suse.com>
  Mike Snitzer <snitzer@kernel.org>
  Mikulas Patocka <mpatocka@redhat.com>
  Milan Broz <gmazyland@gmail.com>
  Ming Lei <ming.lei@redhat.com>
  Mohan Kumar <mkumard@nvidia.com>
  Monish Kumar R <monish.kumar.r@intel.com>
  Muchun Song <songmuchun@bytedance.com>
  Namjae Jeon <linkinjeon@kernel.org>
  Naoya Horiguchi <naoya.horiguchi@nec.com>
  Nathan Chancellor <nathan@kernel.org>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nikita Shubin <n.shubin@yadro.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Niklas Schnelle <schnelle@linux.ibm.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Pankaj Raghav <p.raghav@samsung.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Paulo Alcantara <pc@cjr.nz>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Gonda <pgonda@google.com>
  Peter Hutterer <peter.hutterer@who-t.net>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Prashant Malani <pmalani@chromium.org>
  Randy Dunlap <rdunlap@infradead.org>
  Raul E Rangel <rrangel@chromium.org>
  Ravi Bangoria <ravi.bangoria@amd.com>
  Rik van Riel <riel@surriel.com>
  Rob Herring <robh@kernel.org>
  Roger Pau Monné <roger.pau@citrix.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Russell Currey <ruscur@russell.cc>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Sagi Grimberg <sagi@grimberg.me>
  Samuel Holland <samuel@sholland.org>
  Sean Christopherson <seanjc@google.com>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  Sedat Dilek <sedat.dilek@gmail.com>
  Sergiu Moga <sergiu.moga@microchip.com>
  Shengjiu Wang <shengjiu.wang@gmail.com>
  Stefan Binding <sbinding@opensource.cirrus.com>
  Stephen Boyd <sboyd@kernel.org>
  Stephen Boyd <swboyd@chromium.org>
  Stephen Boyd <swboyd@chromium.org> # coachz, wormdingler
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sungup Moon <sungup.moon@samsung.com>
  Takashi Iwai <tiwai@suse.de>
  Tal Zussman <tz2294@columbia.edu>
  Tanu M <tanu235m@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tobias Klauser <tklauser@distanz.ch>
  Tom Rix <trix@redhat.com>
  Tony Krowiak <akrowiak@linux.ibm.com>
  Tony Lindgren <tony@atomide.com>
  Tzung-Bi Shih <tzungbi@google.com>
  Valentin Vidic <vvidic@valentin-vidic.from.hr>
  Vasant Karasulli <vkarasulli@suse.de>
  Vasily Gorbik <gor@linux.ibm.com>
  Victor Erminpour <victor.erminpour@oracle.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vitaly Rodionov <vitalyr@opensource.cirrus.com>
  Vlastimil Babka <vbabka@suse.cz>
  Wu Caize <zepan@sipeed.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>
  Xin Hao <xhao@linux.alibaba.com>
  Yi Liu <liu.yi24@zte.com.cn>
  Yi Wang <wang.yi59@zte.com.cn>
  Yinan Zhang <zhangyinan2019@email.szu.edu.cn>
  Yu Liao <liaoyu15@huawei.com>
  YueHaibing <yuehaibing@huawei.com>
  Yuezhang Mo <Yuezhang.Mo@sony.com>
  Yunus Bas <y.bas@phytec.de>
  Zhang Wensheng <zhangwensheng5@huawei.com>
  Zheng Bin <zhengbin13@huawei.com>
  Zheng Yongjun <zhengyongjun3@huawei.com>
  Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e8b767f5e040..be2d3ecedd99  be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 12:03:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 12:03:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298018.507616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naywS-0000vz-JO; Sun, 03 Apr 2022 12:02:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298018.507616; Sun, 03 Apr 2022 12:02:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1naywS-0000vs-Fy; Sun, 03 Apr 2022 12:02:48 +0000
Received: by outflank-mailman (input) for mailman id 298018;
 Sun, 03 Apr 2022 12:02:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naywQ-0000vi-PW; Sun, 03 Apr 2022 12:02:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naywQ-000338-Ms; Sun, 03 Apr 2022 12:02:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1naywQ-0007MM-6T; Sun, 03 Apr 2022 12:02:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1naywQ-0003Lm-63; Sun, 03 Apr 2022 12:02:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=THNoJa5sTsPg2EYGjHc6h9+TZye0/DNXzYhRfGJjeuM=; b=30eUNBEd5vSPGUpU7qHxdX2sFt
	rhfQMxUPPsaMFXie2cGjDNLvbs0n5SbCauCnatjJtJALV5RFAiHegvTNN01p0HviWkPZDo29XJuNv
	zeY1T3c7YkanVYsLJsiWNvZJH2ywrty+Viayef50K3rpFPqR/zQVRltlY49M8wTydE2c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169139-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169139: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=b7f5ad4610856dc82618ed82c5cab3124be65274
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 12:02:46 +0000

flight 169139 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169139/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              b7f5ad4610856dc82618ed82c5cab3124be65274
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  632 days
Failing since        151818  2020-07-11 04:18:52 Z  631 days  613 attempts
Testing same since   169126  2022-04-02 04:20:15 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 102979 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 15:47:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 15:47:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298028.507627 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb2Rm-0004Zx-OH; Sun, 03 Apr 2022 15:47:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298028.507627; Sun, 03 Apr 2022 15:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb2Rm-0004Zq-LL; Sun, 03 Apr 2022 15:47:22 +0000
Received: by outflank-mailman (input) for mailman id 298028;
 Sun, 03 Apr 2022 15:47:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb2Rk-0004Zg-V8; Sun, 03 Apr 2022 15:47:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb2Rk-0006md-Rc; Sun, 03 Apr 2022 15:47:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb2Rk-0002bj-A9; Sun, 03 Apr 2022 15:47:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nb2Rk-0007rH-9U; Sun, 03 Apr 2022 15:47:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OEaDw/Od/Ybs1G+wsDMtA+MsOU5d3SvibDqrVfWJb9Q=; b=C06kiCm+9CdU/dHTI5iqIk2Las
	nIDyi8ilbOPqwavhBppyhzLtIB8X0Pkacxxhb1aBDOfNCgZM5Vfn/oYP3pSYVpa0x6VZp8kKHfau8
	rMTF3lHsA3eMPU8q3tJxrcZB/aM9m0PP/H1tVmdbNYRVSPdBO2GWzTVVU7qqj6Tqcw8A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169137-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169137: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d62a34423a1a98aefd7c30e22d2d82d198f077c8
X-Osstest-Versions-That:
    xen=d62a34423a1a98aefd7c30e22d2d82d198f077c8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 15:47:20 +0000

flight 169137 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169137/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 169125 pass in 169137
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 169125
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169125
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169125

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169125
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169125
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169125
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169125
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169125
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169125
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169125
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169125
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169125
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169125
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169125
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169125
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d62a34423a1a98aefd7c30e22d2d82d198f077c8
baseline version:
 xen                  d62a34423a1a98aefd7c30e22d2d82d198f077c8

Last test of basis   169137  2022-04-03 02:08:34 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Apr 03 16:47:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 16:47:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298038.507638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb3OB-0002gS-AC; Sun, 03 Apr 2022 16:47:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298038.507638; Sun, 03 Apr 2022 16:47:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb3OB-0002gL-7E; Sun, 03 Apr 2022 16:47:43 +0000
Received: by outflank-mailman (input) for mailman id 298038;
 Sun, 03 Apr 2022 16:47:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb3OA-0002gB-9o; Sun, 03 Apr 2022 16:47:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb3OA-0008Hc-1b; Sun, 03 Apr 2022 16:47:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb3O9-0006eT-IB; Sun, 03 Apr 2022 16:47:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nb3O9-00070A-Hm; Sun, 03 Apr 2022 16:47:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RvMVAagqx4iWWESoTRxUj+takaHqcEwxecyoy9J1UWQ=; b=sLo5sa1BQ98/xw/+LnKEXZG6me
	JsbWUBalG7t8EyaG0Wl4DFjUbT5HoF4MSlV0SZd39xsWLinI2hCtAvOfxRYDXQ0+U/HM9B1hn4Jhm
	VhzMWBTWySiOd2elgtmdLzKzZz9sdA/XuzYS7bv71fbYnml95zw1aXLNFxhVF5X0A8qA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169141-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169141: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=3e130e40fc55f06f7fe019e87ed9bae957870a12
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 16:47:41 +0000

flight 169141 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169141/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 3e130e40fc55f06f7fe019e87ed9bae957870a12
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   34 days
Failing since        168258  2022-03-01 01:55:31 Z   33 days  270 attempts
Testing same since   169141  2022-04-03 08:40:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3211 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 18:21:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 18:21:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298047.507649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb4qy-0003mZ-7F; Sun, 03 Apr 2022 18:21:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298047.507649; Sun, 03 Apr 2022 18:21:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb4qy-0003mS-3d; Sun, 03 Apr 2022 18:21:32 +0000
Received: by outflank-mailman (input) for mailman id 298047;
 Sun, 03 Apr 2022 18:21:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb4qw-0003mI-Nw; Sun, 03 Apr 2022 18:21:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb4qw-0001T6-Lk; Sun, 03 Apr 2022 18:21:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb4qw-00038m-81; Sun, 03 Apr 2022 18:21:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nb4qw-00026i-7L; Sun, 03 Apr 2022 18:21:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Nn16mVfVW2d2tTI2iIWtMo7JzU3PoW6RZbsfKToDvP0=; b=K57JgaC9sNZQNJUWk0DQbYN8ym
	KEGUnNoYc01xlkMn1pXlccnHyv4X/bnDVUmBiwa+Rp39FILfAu1R3SF23c6oHgWRhy/Vh5MfWwkxO
	CRcyb0VkTumTmCK7cb3B7qGs3NhIOZ6ArcDV0hwcXk1rbLqtJKWoQ2jcziG126kjUQbI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169138-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169138: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=bc6ec396d471d9e4aae7e2ff8b72e11da9a97665
X-Osstest-Versions-That:
    qemuu=697d18b1bd2667efa418cc7d7248d5450da547e7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 18:21:30 +0000

flight 169138 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169138/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169127
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169127
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169127
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169127
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169127
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169127
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169127
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169127
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                bc6ec396d471d9e4aae7e2ff8b72e11da9a97665
baseline version:
 qemuu                697d18b1bd2667efa418cc7d7248d5450da547e7

Last test of basis   169127  2022-04-02 07:42:20 Z    1 days
Testing same since   169138  2022-04-03 02:47:41 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bruno Haible <bruno@clisp.org>
  Frederic Konrad <frederic.konrad@adacore.com>
  Frederic Konrad <konrad@adacore.com>
  Idan Horowitz <idan.horowitz@gmail.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Thomas Huth <thuth@redhat.com>
  Will Cohen <wwcohen@gmail.com>
  Yonggang Luo <luoyonggang@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   697d18b1bd..bc6ec396d4  bc6ec396d471d9e4aae7e2ff8b72e11da9a97665 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 22:56:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 22:56:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298060.507660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb98q-0003vA-6q; Sun, 03 Apr 2022 22:56:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298060.507660; Sun, 03 Apr 2022 22:56:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb98q-0003v3-3Q; Sun, 03 Apr 2022 22:56:16 +0000
Received: by outflank-mailman (input) for mailman id 298060;
 Sun, 03 Apr 2022 22:56:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb98p-0003ut-Hh; Sun, 03 Apr 2022 22:56:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb98p-00063P-DJ; Sun, 03 Apr 2022 22:56:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb98o-0000uR-T7; Sun, 03 Apr 2022 22:56:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nb98o-0000Ce-SX; Sun, 03 Apr 2022 22:56:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=u5hOeTUF8f4ZVpmxWiDWmE8aL0g4GdFb5HF5YZVcSQE=; b=wziPQ2E56aqgAQ6FoxVyXSVgrT
	s9m5oo3kwUfF8SvwDbuWNRw1fhcbU5Yd/TF7FuEXm+EqPpP5LDIVYMsFpDbMM/VyFoR++K05+bPtV
	+67pNnnIawt/DOwSa28gy/1rNda+pFZ2tPJ5nUWNumyJnOEQEtt7InL3dtA+oW046sD8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169140-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169140: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
X-Osstest-Versions-That:
    xen=ca304edd3ba8c19211107fd2e898249987557ce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 22:56:14 +0000

flight 169140 xen-4.14-testing real [real]
flight 169146 xen-4.14-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169140/
http://logs.test-lab.xenproject.org/osstest/logs/169146/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168506
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168506

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168506
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
baseline version:
 xen                  ca304edd3ba8c19211107fd2e898249987557ce5

Last test of basis   168506  2022-03-10 14:16:31 Z   24 days
Failing since        168862  2022-03-25 17:36:39 Z    9 days   11 attempts
Testing same since   168957  2022-03-28 21:36:20 Z    6 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 22:59:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 22:59:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298069.507671 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb9Bz-0004c0-Rp; Sun, 03 Apr 2022 22:59:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298069.507671; Sun, 03 Apr 2022 22:59:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb9Bz-0004bt-OY; Sun, 03 Apr 2022 22:59:31 +0000
Received: by outflank-mailman (input) for mailman id 298069;
 Sun, 03 Apr 2022 22:59:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb9By-0004bj-Bo; Sun, 03 Apr 2022 22:59:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb9By-00065k-Au; Sun, 03 Apr 2022 22:59:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nb9Bx-00012W-Rm; Sun, 03 Apr 2022 22:59:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nb9Bx-0002TF-RL; Sun, 03 Apr 2022 22:59:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eArTRpd6+lw39m09nFCsLWgwGYs9sy+bIV0uB0WjMxI=; b=Mu0bYb1u3NefO+BZPmw8AvIROr
	P4HU/Ns7pHPn1fEsVu/nbD/yCumgi7PEQZDV3ljBm6ni+HSPdB3ULDgXIuLlIwt9JyYaxClhL1S4j
	sX2ER1wNZX9PTijZsOL4FMM1xcfJ8IG+V7R9zC+uHLqy7+4vjs8wAMfUZnSH/sA8sPag=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169144-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169144: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=3e130e40fc55f06f7fe019e87ed9bae957870a12
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 03 Apr 2022 22:59:29 +0000

flight 169144 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169144/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 3e130e40fc55f06f7fe019e87ed9bae957870a12
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   34 days
Failing since        168258  2022-03-01 01:55:31 Z   33 days  271 attempts
Testing same since   169141  2022-04-03 08:40:51 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3211 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 03 23:25:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Apr 2022 23:25:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298077.507682 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb9ak-0007sQ-UV; Sun, 03 Apr 2022 23:25:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298077.507682; Sun, 03 Apr 2022 23:25:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nb9ak-0007sJ-Pj; Sun, 03 Apr 2022 23:25:06 +0000
Received: by outflank-mailman (input) for mailman id 298077;
 Sun, 03 Apr 2022 23:25:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6FyL=UN=protonmail.ch=mati7337@srs-se1.protection.inumbo.net>)
 id 1nb9aj-0007sD-B1
 for xen-devel@lists.xenproject.org; Sun, 03 Apr 2022 23:25:05 +0000
Received: from mail-4319.protonmail.ch (mail-4319.protonmail.ch [185.70.43.19])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49c3b75d-b3a5-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 01:25:03 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49c3b75d-b3a5-11ec-8fbc-03012f2f19d4
Date: Sun, 03 Apr 2022 23:24:53 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch;
	s=protonmail2; t=1649028302;
	bh=mS02nT2yAqJk/ND+iRkA4kPWNMDk+RpZ4FRHyQjDBAU=;
	h=Date:To:From:Reply-To:Subject:Message-ID:From:To:Cc:Date:Subject:
	 Reply-To:Feedback-ID:Message-ID;
	b=ZSTw1cCTIPWSYF98H/OMBKgridMh0i4or5az7aH5uv5HT7V5vv0m1fzFmdZnvr7dc
	 k0rTt756+ebOA9VEfehO0VQdhJ/GpsmvLpYnvqMGlSoig6jMMQvCU0y/WnUpeRH+x4
	 Ys4v9bppST3PmtSuOPrIQVc/2a7eHk5mws5p6iuEpo3t3ClujBeQNxT/vTIUiccyw8
	 pLd2EmdTS+srPJq1EVURLGI2K3xEzqCP8hHw5hHeCs4ICZYwn0SBczj5CzXxGnETTS
	 4M45rYX7tTGYW0HxR787pyW8Nd4VJgFfSDCAibt6kNj18HxTVLoYbK+hSw8wt2iEqs
	 XEA5ta96MyJuA==
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Mateusz <mati7337@protonmail.ch>
Reply-To: Mateusz <mati7337@protonmail.ch>
Subject: PCI passthrough: possible bug in memory relocation
Message-ID: <l3LThLG8tkJBvD-3WTxzw6TRrj7GPAN9uWh-AWqzelw75qpdP1ZLXzBV7599MWrjrHH-lRKof3b0jm1DEGrUXLJszgh5hjW25oNtHoTI9Ts=@protonmail.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello,
I'm working on resolving a bug in Qubes OS. The problem is that
when someone gives a VM too much RAM the GPU passthrough doesn't
work as intended. I think it's because in these cases RAM overlaps
with PCI addresses and memory relocation doesn't work in Xen.

Here are the memory BARs of the GPU I've tried to passthrough:
Memory at f3000000 (32-bit, non-prefetchable) [size=3D16M]
Memory at e0000000 (64-bit, prefetchable) [size=3D256M]
Memory at f0000000 (64-bit, prefetchable) [size=3D32M]

The interesting thing is that in xl dmesg hvmloader prints these
lines:
(d1) Relocating 0xffff pages from 0e0001000 to 187000000 for lowmem MMIO ho=
le
(d1) Relocating 0x1 pages from 0e0000000 to 196fff000 for lowmem MMIO hole
so it looks like it tries to move these pages to a different address
to make space for PCI memory, but for some reason it doesn't work.
Changing TOLUD to 3.5G solves the problem.
I tested it on xen 4.14.3
Here's the issue on github regarding this problem:
https://github.com/QubesOS/qubes-issues/issues/4321

Is it a bug in Xen and fixing it would fix the problem or is there
something I'm missing?
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE0RoD3+S7b5zXZ6lW6IGQZRJEAKsFAmJKKjwACgkQ6IGQZRJE
AKtoDQ/+MQmH72WfmkCzbvpfmzsMW4xWpsx9Q6yZg58eEVv/pT06CC1KD8KUnyN3
ChqBNUQ3W2CZtJG0pJ1eON2wlByFuwnnl67MX0D0oKQQDfEf/oVEUspcXvfdgzR9
vOSqkZTKmZRjKOujrbiyO0Ooyrx7ED8IJE9UcfGzi8OYsYCbRg6vZtMghYoep6c4
w2ho7XLFO0pRjzzO+ZMIWzWJq2yp4H7/8F7QXv57tcszoWCrm/THkM8AGE51ilus
N8S3mlVJM+h2hWpZus9BTxnSULNby80nK3MfWAo6XSTPc/uRo3+NegBhFOFBNkJq
YDC+sbLj9Nr4/4uOKl+lLvg0HBSr/b0qebwE1EAwlj3k9byfFjBHCrf63as7AtO0
AuCE9hFqVE+vM8HPghhvcwzuUywwAljD8kxtvKT73JP/+F7v7PfKr6zMatfGcIMP
LYX7X64dMDsi9ySbjRyWWQFPEYlDKYGFA+88qJQZISQXSykO7QqKxeGpMKL/VUhX
BTLNLa568UReIhOzR5jvzDSl6c2kSxZluKpIuQIRE1iqShnUQPbbykA5zI6NzZOk
L5k/RJuRBYoKh/BWbqZsnLOrkYOltaWmFnHb3PPWNo3bVsQVl0ifkcaEoko6KJ0r
nhbpoieuL7Yn/o3aVLPOI7PP4Qy9LqC47L7h1BsojA75JfeFak8=3D
=3DeUPS
-----END PGP SIGNATURE-----


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 01:12:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 01:12:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298085.507693 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbBGl-0003GZ-Lm; Mon, 04 Apr 2022 01:12:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298085.507693; Mon, 04 Apr 2022 01:12:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbBGl-0003GR-Fn; Mon, 04 Apr 2022 01:12:35 +0000
Received: by outflank-mailman (input) for mailman id 298085;
 Mon, 04 Apr 2022 01:12:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbBGj-0003GF-JD; Mon, 04 Apr 2022 01:12:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbBGj-0001Af-HM; Mon, 04 Apr 2022 01:12:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbBGj-0000kF-17; Mon, 04 Apr 2022 01:12:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbBGj-00034I-0d; Mon, 04 Apr 2022 01:12:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GOIm+V/3AIwhXX8NcRqA5LKkTr8LjUixOeCpd+KmJJQ=; b=gQa55FJ21zCzjlyXgsVlakrynR
	Vt8l1B6zNZkKoBWTb3cZ7jIwU7Wd5M07LwV555nRcEU33C5i971eA3JGXu3L/voa9CnTo75gmBUcW
	XzU1MZbd6IDsHNOJt6gbxImVUyHKsbTZ7PRRHKyNvzifaGqpALNmHxluVrg/exL2U4uw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169148-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169148: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=3e130e40fc55f06f7fe019e87ed9bae957870a12
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 01:12:33 +0000

flight 169148 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169148/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 3e130e40fc55f06f7fe019e87ed9bae957870a12
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   34 days
Failing since        168258  2022-03-01 01:55:31 Z   33 days  272 attempts
Testing same since   169141  2022-04-03 08:40:51 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3211 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 02:37:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 02:37:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298093.507704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbCaD-00035n-N6; Mon, 04 Apr 2022 02:36:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298093.507704; Mon, 04 Apr 2022 02:36:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbCaD-00035g-I6; Mon, 04 Apr 2022 02:36:45 +0000
Received: by outflank-mailman (input) for mailman id 298093;
 Mon, 04 Apr 2022 02:36:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbCaC-00035W-Fa; Mon, 04 Apr 2022 02:36:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbCaC-0002x2-AZ; Mon, 04 Apr 2022 02:36:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbCaB-0005EH-Ro; Mon, 04 Apr 2022 02:36:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbCaB-00030S-Qf; Mon, 04 Apr 2022 02:36:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JM24cS1Gd+YB/FugMM7fEoYtWPbShr6N2SKeB7oCeAs=; b=FYuRTOHcSHsXxv4RpTtHPGbYhE
	iCAFQeItcL/56O73Uwf/ABbVGNNTwAD3PteBfJ1Zzj3K/ycNIo3VdQDyYZ3ClHrJBtHx1F4Fnxw0d
	todd5FQ887Onbjxlp+LRcgx/8rruGPOAxS3xUSX2alLaHNeDVDY4+W2IPJ47OdZdChPg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169143-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169143: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
X-Osstest-Versions-That:
    xen=cd751c09a5bab9f3529901fbe4d867ad7d52e89d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 02:36:43 +0000

flight 169143 xen-4.15-testing real [real]
flight 169149 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169143/
http://logs.test-lab.xenproject.org/osstest/logs/169149/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168502
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168502

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168502
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168502
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168502
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168502
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168502
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168502
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
baseline version:
 xen                  cd751c09a5bab9f3529901fbe4d867ad7d52e89d

Last test of basis   168502  2022-03-10 09:07:57 Z   24 days
Failing since        168863  2022-03-25 17:36:55 Z    9 days   11 attempts
Testing same since   168970  2022-03-29 04:19:26 Z    5 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 02:37:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 02:37:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298100.507714 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbCab-0003ZW-3k; Mon, 04 Apr 2022 02:37:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298100.507714; Mon, 04 Apr 2022 02:37:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbCab-0003ZP-0q; Mon, 04 Apr 2022 02:37:09 +0000
Received: by outflank-mailman (input) for mailman id 298100;
 Mon, 04 Apr 2022 02:37:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbCaZ-0003XQ-Pj; Mon, 04 Apr 2022 02:37:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbCaZ-0002xV-Oh; Mon, 04 Apr 2022 02:37:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbCaZ-0005FV-9p; Mon, 04 Apr 2022 02:37:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbCaZ-0003pM-9O; Mon, 04 Apr 2022 02:37:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wDhwhx2Cl9U+5Tm5D4fRLdoNC8Nbo1ssPkmVQ8rZU+Q=; b=NkL9MU8IilguGZ5FY4EGd6gO+Q
	jss5UErkTicNRj9rBt9u1oUAQ1ahBBgXYztoBeXoopGTp4RVt4uxCLxR4AB3OZfx4fnAAQg3KOAnF
	sPndGPE5Y6Xk/w8frV19r08e+dt+ls4iFg+IcgP9qSlcoQUVCIvuYpv8+xwN/MXwM4qo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169150-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169150: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=3e130e40fc55f06f7fe019e87ed9bae957870a12
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 02:37:07 +0000

flight 169150 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169150/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 3e130e40fc55f06f7fe019e87ed9bae957870a12
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   34 days
Failing since        168258  2022-03-01 01:55:31 Z   34 days  273 attempts
Testing same since   169141  2022-04-03 08:40:51 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3211 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298115.507770 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvB-000356-Tr; Mon, 04 Apr 2022 05:06:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298115.507770; Mon, 04 Apr 2022 05:06:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvB-00034v-QB; Mon, 04 Apr 2022 05:06:33 +0000
Received: by outflank-mailman (input) for mailman id 298115;
 Mon, 04 Apr 2022 05:06:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvA-00021C-HU
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:32 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fd728895-b3d4-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 07:06:31 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEuy-00D8sf-RU; Mon, 04 Apr 2022 05:06:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd728895-b3d4-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=rkpZ3s8fgryeAMuUBNOS3xz/G9atdlLDsC40fwEGHdk=; b=yjAftHgYYiU99p0V+TDtV7tE0o
	gxIDDpeYBIADcBl/6V08XcvSHygoBgJp/KIAbrI1Vfw1wyw7HMDcT3JyWO9zsPQ2aL4K6lWxDyUPg
	gkou57CwzlBz5CDkD+LclThCZDYXe39Q9Anlw6/dZvOBfBEY4w89BKRoBjdLvHiz+16qOyaxShe+8
	q9yCfnyWUVHwH3AqCgWge6XPUX0WoH6fUTFvmWF0qHc/QR6AozWpxoibfat0PFrxiIhQgkzatyxR3
	PmLUvCoFkOB9ySCCIMM7gJ5eKvptEEUBQXwCg1aUR72y8eXs+G3Ba2yk/aOlPCBZvsM8AZyeq7EbR
	aKWj7NkA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 04/15] swiotlb: rename swiotlb_late_init_with_default_size
Date: Mon,  4 Apr 2022 07:05:48 +0200
Message-Id: <20220404050559.132378-5-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

swiotlb_late_init_with_default_size is an overly verbose name that
doesn't even catch what the function is doing, given that the size is
not just a default but the actual requested size.

Rename it to swiotlb_init_late.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 arch/x86/pci/sta2x11-fixup.c | 2 +-
 include/linux/swiotlb.h      | 2 +-
 kernel/dma/swiotlb.c         | 6 ++----
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index 101081ad64b6d..e0c039a75b2db 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_late_init_with_default_size(size))
+		if (swiotlb_init_late(size))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 9fb3a568f0c51..b48b26bfa0edb 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose);
 int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-extern int swiotlb_late_init_with_default_size(size_t default_size);
+int swiotlb_init_late(size_t size);
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index e0127e397335e..9a4fe6e48a074 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -281,11 +281,9 @@ swiotlb_init(int verbose)
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int
-swiotlb_late_init_with_default_size(size_t default_size)
+int swiotlb_init_late(size_t size)
 {
-	unsigned long nslabs =
-		ALIGN(default_size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
+	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
 	unsigned char *vstart = NULL;
 	unsigned int order;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298111.507726 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEv5-00021K-Lu; Mon, 04 Apr 2022 05:06:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298111.507726; Mon, 04 Apr 2022 05:06:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEv5-00021D-Iv; Mon, 04 Apr 2022 05:06:27 +0000
Received: by outflank-mailman (input) for mailman id 298111;
 Mon, 04 Apr 2022 05:06:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEv3-000216-J4
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:25 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f71367c3-b3d4-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:06:22 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEug-00D8mu-0p; Mon, 04 Apr 2022 05:06:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f71367c3-b3d4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=KJNpqDmInpKNb0Ba6QeWsT+B+VJPRpifPEMByOx0SBg=; b=2xQrfIxcemUjQVz4pRH4tfgiVa
	3XIS0/qYlgyD0IPcbkT+CtyJYQ+N/Mqk258vsL/HrJ9HMlcUeHKFXtKovNh7o7atoMd2f3vKTCcUg
	KHfpkpJdTNcrL38s2CroJ+aqT+9ezFQ2X8ReztMbBgCVgY1ouP8LtD6Hu/GXM0SuMrRr2i9sJFvGZ
	LEIXHmcRo+SqA+FqqjEZAXIcrE7HAkzJRJHErCMVKXPmI5rhQWdqKTyD4gEpiXPodWFJo6gN0/P5g
	EWuZp+Nfd0G7hWSN8tzUu5T5ISbTSQNqmWELzJb7TpltEMHqH4dECM38unbtlxp6dxC9bACDoNciX
	ZXG1SgVA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: cleanup swiotlb initialization v8
Date: Mon,  4 Apr 2022 07:05:44 +0200
Message-Id: <20220404050559.132378-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Hi all,

this series tries to clean up the swiotlb initialization, including
that of swiotlb-xen.  To get there is also removes the x86 iommu table
infrastructure that massively obsfucates the initialization path.

Git tree:

    git://git.infradead.org/users/hch/misc.git swiotlb-init-cleanup

Gitweb:

    http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/swiotlb-init-cleanup

Changes since v7:
 - rebased to Linux 5.18-rc1
 - better document the lower bound swiotlb size for xen-swiotlb
 - improve the nslabs calculation for the retry case in
   swiotlb_init_remap and swiotlb_init_late

Changes since v6:
 - use IO_TLB_MIN_SLABS instead of open coding the constant
 - call the remap callback later in swiotlb_init_late
 - set SWIOTLB_ANY for xen/x86

Changes since v5:
 - split a patch into three
 - fix setting x86_swiotlb_enable for Xen
 - fix a comment about forced bounce buffering for guest memory
   encryption
 - remove the xen_initial_domain check from
   xen_create_contiguous_region

Changes since v3:
 - fix a compilation issue on some powerpc configfs
 - fix and cleanup how forced bounce buffering is enabled for
   guest memory encryption

Changes since v2:
 - make ppc_swiotlb_flags actually work again
 - also force enable swiotlb for guest encrypted memory to cater
   to hyperv which doesn't set the host encrypted memory flag

Changes since v1:
 - skip IOMMU initialization on Xen PV kernels
 - various small whitespace / typo fixes

Diffstat:
 arch/ia64/include/asm/iommu_table.h      |    7 -
 arch/x86/include/asm/iommu_table.h       |  102 -------------------
 arch/x86/include/asm/swiotlb.h           |   30 -----
 arch/x86/kernel/pci-iommu_table.c        |   77 --------------
 arch/x86/kernel/pci-swiotlb.c            |   77 --------------
 arch/x86/xen/pci-swiotlb-xen.c           |   96 ------------------
 b/arch/arm/mm/init.c                     |    6 -
 b/arch/arm/xen/mm.c                      |   26 ++--
 b/arch/arm64/mm/init.c                   |    6 -
 b/arch/ia64/mm/init.c                    |    4 
 b/arch/mips/cavium-octeon/dma-octeon.c   |   15 --
 b/arch/mips/loongson64/dma.c             |    2 
 b/arch/mips/pci/pci-octeon.c             |    2 
 b/arch/mips/sibyte/common/dma.c          |    2 
 b/arch/powerpc/include/asm/svm.h         |    4 
 b/arch/powerpc/include/asm/swiotlb.h     |    1 
 b/arch/powerpc/kernel/dma-swiotlb.c      |    1 
 b/arch/powerpc/mm/mem.c                  |    6 -
 b/arch/powerpc/platforms/pseries/setup.c |    3 
 b/arch/powerpc/platforms/pseries/svm.c   |   26 ----
 b/arch/riscv/mm/init.c                   |    8 -
 b/arch/s390/mm/init.c                    |    3 
 b/arch/x86/include/asm/dma-mapping.h     |   12 --
 b/arch/x86/include/asm/gart.h            |    5 
 b/arch/x86/include/asm/iommu.h           |    8 +
 b/arch/x86/include/asm/xen/page.h        |    5 
 b/arch/x86/include/asm/xen/swiotlb-xen.h |    2 
 b/arch/x86/kernel/Makefile               |    2 
 b/arch/x86/kernel/amd_gart_64.c          |    5 
 b/arch/x86/kernel/aperture_64.c          |   14 --
 b/arch/x86/kernel/cpu/mshyperv.c         |    8 -
 b/arch/x86/kernel/pci-dma.c              |  114 +++++++++++++++++----
 b/arch/x86/kernel/tboot.c                |    1 
 b/arch/x86/kernel/vmlinux.lds.S          |   12 --
 b/arch/x86/mm/mem_encrypt_amd.c          |    3 
 b/arch/x86/pci/sta2x11-fixup.c           |    2 
 b/arch/x86/xen/Makefile                  |    2 
 b/drivers/iommu/amd/init.c               |    6 -
 b/drivers/iommu/amd/iommu.c              |    5 
 b/drivers/iommu/intel/dmar.c             |    6 -
 b/drivers/xen/swiotlb-xen.c              |  132 -------------------------
 b/include/linux/dmar.h                   |    6 -
 b/include/linux/swiotlb.h                |   22 ++--
 b/include/trace/events/swiotlb.h         |   29 +----
 b/include/xen/arm/page.h                 |    1 
 b/include/xen/swiotlb-xen.h              |    8 +
 b/kernel/dma/direct.h                    |    2 
 b/kernel/dma/swiotlb.c                   |  163 ++++++++++++++-----------------
 48 files changed, 252 insertions(+), 827 deletions(-)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298112.507737 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEv7-0002Gu-VQ; Mon, 04 Apr 2022 05:06:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298112.507737; Mon, 04 Apr 2022 05:06:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEv7-0002Gn-Qj; Mon, 04 Apr 2022 05:06:29 +0000
Received: by outflank-mailman (input) for mailman id 298112;
 Mon, 04 Apr 2022 05:06:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEv6-00021C-9q
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:28 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f85738bb-b3d4-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 07:06:25 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEuk-00D8oG-Qt; Mon, 04 Apr 2022 05:06:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f85738bb-b3d4-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=fpYq2gch6ejmPkcFKPjSyDr7OAs4OQSLe0uyAoUEPa0=; b=PaIuEfkhd/fM6UAW/lkkUPAGUw
	7D5xF0SVLHLn6WNNOsXP6C40xAJZcMJAp3la1OozTUK8mwJu3uWuRjEtjLg4M6bNDA86tDasdvIYU
	bo3JyS8R6vbX1G4c2tiWI6Gz3lv5HpsNhObISRr0qguR9mlnwpLVqospUKY7NcL04521npcDEwcir
	XEwLaaZPWonss1WY91g4Xlb0lxWmrYXxqGad6j85yvjhLRJu2pOsDzHuWiW+JffLV5HBKLJr+yHQT
	Dt5YABuyfjeH7DMGRPGA1eHB833fjns0mquYYUVQlHIlLbJdGUQ4POXbeGqKn3Z3w179g12ahwlLj
	L25e2fIw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 01/15] dma-direct: use is_swiotlb_active in dma_direct_map_page
Date: Mon,  4 Apr 2022 07:05:45 +0200
Message-Id: <20220404050559.132378-2-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the more specific is_swiotlb_active check instead of checking the
global swiotlb_force variable.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 kernel/dma/direct.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/dma/direct.h b/kernel/dma/direct.h
index 4632b0f4f72eb..4dc16e08c7e1a 100644
--- a/kernel/dma/direct.h
+++ b/kernel/dma/direct.h
@@ -91,7 +91,7 @@ static inline dma_addr_t dma_direct_map_page(struct device *dev,
 		return swiotlb_map(dev, phys, size, dir, attrs);
 
 	if (unlikely(!dma_capable(dev, dma_addr, size, true))) {
-		if (swiotlb_force != SWIOTLB_NO_FORCE)
+		if (is_swiotlb_active(dev))
 			return swiotlb_map(dev, phys, size, dir, attrs);
 
 		dev_WARN_ONCE(dev, 1,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298114.507758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEv9-0002km-I9; Mon, 04 Apr 2022 05:06:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298114.507758; Mon, 04 Apr 2022 05:06:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEv9-0002kS-Dv; Mon, 04 Apr 2022 05:06:31 +0000
Received: by outflank-mailman (input) for mailman id 298114;
 Mon, 04 Apr 2022 05:06:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEv8-00021C-8l
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:30 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fc2f67c5-b3d4-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 07:06:29 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEuq-00D8ox-50; Mon, 04 Apr 2022 05:06:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc2f67c5-b3d4-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=3bKOwa/vIjXDTctiHR3yrY0M3Nyf9zVmyxkMzvumqG8=; b=EB7gLsK0UvHav6B4abhaPvjJm4
	FSQhyO6o0EYvmijqssvR2Q1Gs9e9b7dbZYgZENsl7+jB7rWSFCNAlCbR1TzAA8Q1NVRTUwZMhXAYN
	+T/3Yc95IAf59JX6BzJyzdXMEVJ81KmzgtXkS84pkf42p/XCgBb24+Pe6oBHh6kTieMTt7Nj5y23Z
	wylVK+JE2wcAm+tlJTJmpJJ11tUpLjiTBDIjrztXtkuVK6/+I8gAYxYGF0MZhZA3St6JQ6dVe7QQT
	4i4Fld7CnHSKQSuWGvKwAQtoK98Bi5BCZne67U1mZDxrdJZA+51OSEmE/tuOtZVdA7Qu782BgN/Y9
	QNbBls1g==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 02/15] swiotlb: make swiotlb_exit a no-op if SWIOTLB_FORCE is set
Date: Mon,  4 Apr 2022 07:05:46 +0200
Message-Id: <20220404050559.132378-3-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

If force bouncing is enabled we can't release the buffers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 kernel/dma/swiotlb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 73a41cec9e386..98bb0eb44a7bf 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -369,6 +369,9 @@ void __init swiotlb_exit(void)
 	unsigned long tbl_vaddr;
 	size_t tbl_size, slots_size;
 
+	if (swiotlb_force == SWIOTLB_FORCE)
+		return;
+
 	if (!mem->nslabs)
 		return;
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298113.507741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEv8-0002KP-7c; Mon, 04 Apr 2022 05:06:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298113.507741; Mon, 04 Apr 2022 05:06:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEv8-0002JL-2P; Mon, 04 Apr 2022 05:06:30 +0000
Received: by outflank-mailman (input) for mailman id 298113;
 Mon, 04 Apr 2022 05:06:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEv6-00021C-NL
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:28 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fab22b87-b3d4-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 07:06:27 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEuu-00D8qZ-8m; Mon, 04 Apr 2022 05:06:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fab22b87-b3d4-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=rnJqoDznV2ailLujTKu/Jc1dJCINDF5Gg77pH2Dxx2M=; b=1iFXKtta4r+OI9SiFxTCKN3UND
	OgDrY90v7rPxIhfQCXPwwz+In7kY2H8l9KUOSQU7aCLwCYEt8N2HxW6JzPeCyvnGiJW62+ksVNaU1
	5RdWPH/iOrys+qb+LRWQ+fQbqfv060OvVAHgMyI4kfcfsqtMHT3qTxw/n/mouxLBUOjnmDpvDqbJx
	1GjFzMuSqROw+95bLlcyQgLv8r533FZvrhmZ1M6RmEm0SDC+AaBUfi8RWNV8iMaGEC7CZ5qswv8/a
	liRmKvGZ8xV8j94rKpIqvMJjXJqfdYxJUXcJubWVMWhwLHR2Q34GSX7kffJ33Me9OS8ShJwkhNCia
	MO76TOJg==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 03/15] swiotlb: simplify swiotlb_max_segment
Date: Mon,  4 Apr 2022 07:05:47 +0200
Message-Id: <20220404050559.132378-4-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Remove the bogus Xen override that was usually larger than the actual
size and just calculate the value on demand.  Note that
swiotlb_max_segment still doesn't make sense as an interface and should
eventually be removed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 drivers/xen/swiotlb-xen.c |  2 --
 include/linux/swiotlb.h   |  1 -
 kernel/dma/swiotlb.c      | 20 +++-----------------
 3 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 47aebd98f52f5..485cd06ed39e7 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -202,7 +202,6 @@ int xen_swiotlb_init(void)
 	rc = swiotlb_late_init_with_tbl(start, nslabs);
 	if (rc)
 		return rc;
-	swiotlb_set_max_segment(PAGE_SIZE);
 	return 0;
 error:
 	if (nslabs > 1024 && repeat--) {
@@ -254,7 +253,6 @@ void __init xen_swiotlb_init_early(void)
 
 	if (swiotlb_init_with_tbl(start, nslabs, true))
 		panic("Cannot allocate SWIOTLB buffer");
-	swiotlb_set_max_segment(PAGE_SIZE);
 }
 #endif /* CONFIG_X86 */
 
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index f6c3638255d54..9fb3a568f0c51 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -164,7 +164,6 @@ static inline void swiotlb_adjust_size(unsigned long size)
 #endif /* CONFIG_SWIOTLB */
 
 extern void swiotlb_print_info(void);
-extern void swiotlb_set_max_segment(unsigned int);
 
 #ifdef CONFIG_DMA_RESTRICTED_POOL
 struct page *swiotlb_alloc(struct device *dev, size_t size);
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 98bb0eb44a7bf..e0127e397335e 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -68,12 +68,6 @@ struct io_tlb_mem io_tlb_default_mem;
 
 phys_addr_t swiotlb_unencrypted_base;
 
-/*
- * Max segment that we can provide which (if pages are contingous) will
- * not be bounced (unless SWIOTLB_FORCE is set).
- */
-static unsigned int max_segment;
-
 static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT;
 
 static int __init
@@ -97,18 +91,12 @@ early_param("swiotlb", setup_io_tlb_npages);
 
 unsigned int swiotlb_max_segment(void)
 {
-	return io_tlb_default_mem.nslabs ? max_segment : 0;
+	if (!io_tlb_default_mem.nslabs)
+		return 0;
+	return rounddown(io_tlb_default_mem.nslabs << IO_TLB_SHIFT, PAGE_SIZE);
 }
 EXPORT_SYMBOL_GPL(swiotlb_max_segment);
 
-void swiotlb_set_max_segment(unsigned int val)
-{
-	if (swiotlb_force == SWIOTLB_FORCE)
-		max_segment = 1;
-	else
-		max_segment = rounddown(val, PAGE_SIZE);
-}
-
 unsigned long swiotlb_size_or_default(void)
 {
 	return default_nslabs << IO_TLB_SHIFT;
@@ -258,7 +246,6 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
 
 	if (verbose)
 		swiotlb_print_info();
-	swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT);
 	return 0;
 }
 
@@ -359,7 +346,6 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
 	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
 
 	swiotlb_print_info();
-	swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT);
 	return 0;
 }
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298116.507781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvH-0003WP-EQ; Mon, 04 Apr 2022 05:06:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298116.507781; Mon, 04 Apr 2022 05:06:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvH-0003W6-An; Mon, 04 Apr 2022 05:06:39 +0000
Received: by outflank-mailman (input) for mailman id 298116;
 Mon, 04 Apr 2022 05:06:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvF-000216-OP
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:37 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00a77307-b3d5-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:06:37 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEv3-00D8uv-7w; Mon, 04 Apr 2022 05:06:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00a77307-b3d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=PXzvxDuJ7dtq4MEwSJLJWBZwmoZU9P9omOl6CdJuIoM=; b=J0ixhsO+YSmFk3veuPhfX4XbNN
	fnLuVNVyiMyuqHMjG9Nm2j1QpkedDteZ/bUxB/nstVQR1kzCVf1HfyhjPHMtYmFcYkI5XO+PU1PO8
	vYnXgpo+osZWDdaHlagIdcKjUWiK3YcXno80RpIJtk3hBVg0z5HbCGdJRO885gGbDdwICtCuMfsc4
	LXknn7SUV16b1hVCB4GHdvg/UQJBOvxOZtFjUgeqmW9MWS9YXRDw/YqxSnJzydpaFaMXqkG9L52sO
	t12p1tMKTEuj//lEDkvoIbVNRfFdfHubUQBxqnFTG6Pyn9uHx25It5RZIGXV/Wtps3V7DHTPl4SYn
	PpSm/Nkg==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH 05/15] arm/xen: don't check for xen_initial_domain() in xen_create_contiguous_region
Date: Mon,  4 Apr 2022 07:05:49 +0200
Message-Id: <20220404050559.132378-6-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

From: Stefano Stabellini <sstabellini@kernel.org>

It used to be that Linux enabled swiotlb-xen when running a dom0 on ARM.
Since f5079a9a2a31 "xen/arm: introduce XENFEAT_direct_mapped and
XENFEAT_not_direct_mapped", Linux detects whether to enable or disable
swiotlb-xen based on the new feature flags: XENFEAT_direct_mapped and
XENFEAT_not_direct_mapped.

However, there is still a leftover xen_initial_domain() check in
xen_create_contiguous_region. Remove the check as
xen_create_contiguous_region is only called by swiotlb-xen during
initialization. If xen_create_contiguous_region is called, we know Linux
is running 1:1 mapped so there is no need for additional checks.

Also update the in-code comment.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm/xen/mm.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
index a7e54a087b802..28c2070602535 100644
--- a/arch/arm/xen/mm.c
+++ b/arch/arm/xen/mm.c
@@ -122,10 +122,7 @@ int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
 				 unsigned int address_bits,
 				 dma_addr_t *dma_handle)
 {
-	if (!xen_initial_domain())
-		return -EINVAL;
-
-	/* we assume that dom0 is mapped 1:1 for now */
+	/* the domain is 1:1 mapped to use swiotlb-xen */
 	*dma_handle = pstart;
 	return 0;
 }
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298118.507792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvM-00043Z-TU; Mon, 04 Apr 2022 05:06:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298118.507792; Mon, 04 Apr 2022 05:06:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvM-00042h-MU; Mon, 04 Apr 2022 05:06:44 +0000
Received: by outflank-mailman (input) for mailman id 298118;
 Mon, 04 Apr 2022 05:06:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvL-000216-El
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:43 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03ff5e4b-b3d5-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:06:42 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEv8-00D8yQ-5x; Mon, 04 Apr 2022 05:06:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03ff5e4b-b3d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=fPQX1tW6oEG+I0H/rxZDFlkVrHm+7UqYHxDjUft+pbI=; b=uSQNHmXng2AqqGS9vNecI5TrZb
	ckqwMNHmjFyNEdi2OAxPwf/mSfXx0n0Nk4nTcSLU2I4AhgYDA7JqEvCUreN9tmiISibq9vUYTha6z
	yXL5uCk5K+AWgUjqvusF5U2Y2X4+vHMS8BoOxveW21dDgpVJl78IFlASU3cSy+9mlXG4CzJo6ThmF
	h25qND6yZrqapnhJ94EuP346vzIzAx8l0nlzPdltTVEbHEBsJLoDvBEELPaPL0drlEVpLOrvc0+x6
	d8IdqCts8J/Akl9qIxFc83Xu0Howm75y1RKNHlPjlxwzdSFXZvI7S3EcK76Bvh7fRZIMY9cEtJf9+
	yjHrxkNQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: [PATCH 06/15] MIPS/octeon: use swiotlb_init instead of open coding it
Date: Mon,  4 Apr 2022 07:05:50 +0200
Message-Id: <20220404050559.132378-7-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the generic swiotlb initialization helper instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
 arch/mips/cavium-octeon/dma-octeon.c | 15 ++-------------
 arch/mips/pci/pci-octeon.c           |  2 +-
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c
index df70308db0e69..fb7547e217263 100644
--- a/arch/mips/cavium-octeon/dma-octeon.c
+++ b/arch/mips/cavium-octeon/dma-octeon.c
@@ -186,15 +186,12 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr)
 	return daddr;
 }
 
-char *octeon_swiotlb;
-
 void __init plat_swiotlb_setup(void)
 {
 	phys_addr_t start, end;
 	phys_addr_t max_addr;
 	phys_addr_t addr_size;
 	size_t swiotlbsize;
-	unsigned long swiotlb_nslabs;
 	u64 i;
 
 	max_addr = 0;
@@ -236,15 +233,7 @@ void __init plat_swiotlb_setup(void)
 	if (OCTEON_IS_OCTEON2() && max_addr >= 0x100000000ul)
 		swiotlbsize = 64 * (1<<20);
 #endif
-	swiotlb_nslabs = swiotlbsize >> IO_TLB_SHIFT;
-	swiotlb_nslabs = ALIGN(swiotlb_nslabs, IO_TLB_SEGSIZE);
-	swiotlbsize = swiotlb_nslabs << IO_TLB_SHIFT;
-
-	octeon_swiotlb = memblock_alloc_low(swiotlbsize, PAGE_SIZE);
-	if (!octeon_swiotlb)
-		panic("%s: Failed to allocate %zu bytes align=%lx\n",
-		      __func__, swiotlbsize, PAGE_SIZE);
 
-	if (swiotlb_init_with_tbl(octeon_swiotlb, swiotlb_nslabs, 1) == -ENOMEM)
-		panic("Cannot allocate SWIOTLB buffer");
+	swiotlb_adjust_size(swiotlbsize);
+	swiotlb_init(1);
 }
diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c
index fc29b85cfa926..e457a18cbdc59 100644
--- a/arch/mips/pci/pci-octeon.c
+++ b/arch/mips/pci/pci-octeon.c
@@ -664,7 +664,7 @@ static int __init octeon_pci_setup(void)
 
 		/* BAR1 movable regions contiguous to cover the swiotlb */
 		octeon_bar1_pci_phys =
-			virt_to_phys(octeon_swiotlb) & ~((1ull << 22) - 1);
+			io_tlb_default_mem.start & ~((1ull << 22) - 1);
 
 		for (index = 0; index < 32; index++) {
 			union cvmx_pci_bar1_indexx bar1_index;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298124.507803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvT-0004mv-4r; Mon, 04 Apr 2022 05:06:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298124.507803; Mon, 04 Apr 2022 05:06:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvT-0004me-07; Mon, 04 Apr 2022 05:06:51 +0000
Received: by outflank-mailman (input) for mailman id 298124;
 Mon, 04 Apr 2022 05:06:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvR-000216-LJ
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:49 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 06ecb1e7-b3d5-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:06:47 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvD-00D92G-6Z; Mon, 04 Apr 2022 05:06:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06ecb1e7-b3d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=jPeecmp+E0ZzlXpb63uINQaUIAShkwKKUEQA+6v0ULA=; b=Ii1tCJPiyXg5sPTFYE+KHb2F18
	vT7a3zXgGkBguT14ZpcqXThSg6pIZXlZMxuoph3vH2n+l296uwqKGLm7pTSIS3WXBaW5Q5GtcD0fQ
	v3OGPxclpzfFhMjv99D40ZEn+xFBeZawnrL7oDFhajs2Y4rM2lNL3nEIIhocl0uJl7ANT2C0cFcHg
	7XTORtvTtNRFmDKjBK2IDb0RKr3MxcLM4uRY830TuM0qoWt86X47YXJv8Co3G31OsHJDrk5kPQgBl
	tK1faVK03/V4/KbfyuJBhemCaBWYIgPkqUjMKbaPiAvSxTVjUHkfUxE5M/e2LV6sIvE7dY0bkvs1i
	rU9zo5FA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 07/15] x86: remove the IOMMU table infrastructure
Date: Mon,  4 Apr 2022 07:05:51 +0200
Message-Id: <20220404050559.132378-8-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The IOMMU table tries to separate the different IOMMUs into different
backends, but actually requires various cross calls.

Rewrite the code to do the generic swiotlb/swiotlb-xen setup directly
in pci-dma.c and then just call into the IOMMU drivers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/ia64/include/asm/iommu_table.h    |   7 --
 arch/x86/include/asm/dma-mapping.h     |   1 -
 arch/x86/include/asm/gart.h            |   5 +-
 arch/x86/include/asm/iommu.h           |   6 ++
 arch/x86/include/asm/iommu_table.h     | 102 -----------------------
 arch/x86/include/asm/swiotlb.h         |  30 -------
 arch/x86/include/asm/xen/swiotlb-xen.h |   2 -
 arch/x86/kernel/Makefile               |   2 -
 arch/x86/kernel/amd_gart_64.c          |   5 +-
 arch/x86/kernel/aperture_64.c          |  14 ++--
 arch/x86/kernel/pci-dma.c              | 107 ++++++++++++++++++++-----
 arch/x86/kernel/pci-iommu_table.c      |  77 ------------------
 arch/x86/kernel/pci-swiotlb.c          |  77 ------------------
 arch/x86/kernel/tboot.c                |   1 -
 arch/x86/kernel/vmlinux.lds.S          |  12 ---
 arch/x86/xen/Makefile                  |   2 -
 arch/x86/xen/pci-swiotlb-xen.c         |  96 ----------------------
 drivers/iommu/amd/init.c               |   6 --
 drivers/iommu/amd/iommu.c              |   5 +-
 drivers/iommu/intel/dmar.c             |   6 +-
 include/linux/dmar.h                   |   6 +-
 21 files changed, 110 insertions(+), 459 deletions(-)
 delete mode 100644 arch/ia64/include/asm/iommu_table.h
 delete mode 100644 arch/x86/include/asm/iommu_table.h
 delete mode 100644 arch/x86/include/asm/swiotlb.h
 delete mode 100644 arch/x86/kernel/pci-iommu_table.c
 delete mode 100644 arch/x86/kernel/pci-swiotlb.c
 delete mode 100644 arch/x86/xen/pci-swiotlb-xen.c

diff --git a/arch/ia64/include/asm/iommu_table.h b/arch/ia64/include/asm/iommu_table.h
deleted file mode 100644
index cc96116ac276a..0000000000000
--- a/arch/ia64/include/asm/iommu_table.h
+++ /dev/null
@@ -1,7 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_IA64_IOMMU_TABLE_H
-#define _ASM_IA64_IOMMU_TABLE_H
-
-#define IOMMU_INIT_POST(_detect)
-
-#endif /* _ASM_IA64_IOMMU_TABLE_H */
diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index bb1654fe0ce74..256fd8115223d 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -9,7 +9,6 @@
 
 #include <linux/scatterlist.h>
 #include <asm/io.h>
-#include <asm/swiotlb.h>
 
 extern int iommu_merge;
 extern int panic_on_overflow;
diff --git a/arch/x86/include/asm/gart.h b/arch/x86/include/asm/gart.h
index 3185565743459..5af8088a10df6 100644
--- a/arch/x86/include/asm/gart.h
+++ b/arch/x86/include/asm/gart.h
@@ -38,7 +38,7 @@ extern int gart_iommu_aperture_disabled;
 extern void early_gart_iommu_check(void);
 extern int gart_iommu_init(void);
 extern void __init gart_parse_options(char *);
-extern int gart_iommu_hole_init(void);
+void gart_iommu_hole_init(void);
 
 #else
 #define gart_iommu_aperture            0
@@ -51,9 +51,8 @@ static inline void early_gart_iommu_check(void)
 static inline void gart_parse_options(char *options)
 {
 }
-static inline int gart_iommu_hole_init(void)
+static inline void gart_iommu_hole_init(void)
 {
-	return -ENODEV;
 }
 #endif
 
diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h
index bf1ed2ddc74bd..dba89ed40d38d 100644
--- a/arch/x86/include/asm/iommu.h
+++ b/arch/x86/include/asm/iommu.h
@@ -9,6 +9,12 @@
 extern int force_iommu, no_iommu;
 extern int iommu_detected;
 
+#ifdef CONFIG_SWIOTLB
+extern bool x86_swiotlb_enable;
+#else
+#define x86_swiotlb_enable false
+#endif
+
 /* 10 seconds */
 #define DMAR_OPERATION_TIMEOUT ((cycles_t) tsc_khz*10*1000)
 
diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
deleted file mode 100644
index 1fb3fd1a83c25..0000000000000
--- a/arch/x86/include/asm/iommu_table.h
+++ /dev/null
@@ -1,102 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_X86_IOMMU_TABLE_H
-#define _ASM_X86_IOMMU_TABLE_H
-
-#include <asm/swiotlb.h>
-
-/*
- * History lesson:
- * The execution chain of IOMMUs in 2.6.36 looks as so:
- *
- *            [xen-swiotlb]
- *                 |
- *         +----[swiotlb *]--+
- *        /         |         \
- *       /          |          \
- *    [GART]     [Calgary]  [Intel VT-d]
- *     /
- *    /
- * [AMD-Vi]
- *
- * *: if SWIOTLB detected 'iommu=soft'/'swiotlb=force' it would skip
- * over the rest of IOMMUs and unconditionally initialize the SWIOTLB.
- * Also it would surreptitiously initialize set the swiotlb=1 if there were
- * more than 4GB and if the user did not pass in 'iommu=off'. The swiotlb
- * flag would be turned off by all IOMMUs except the Calgary one.
- *
- * The IOMMU_INIT* macros allow a similar tree (or more complex if desired)
- * to be built by defining who we depend on.
- *
- * And all that needs to be done is to use one of the macros in the IOMMU
- * and the pci-dma.c will take care of the rest.
- */
-
-struct iommu_table_entry {
-	initcall_t	detect;
-	initcall_t	depend;
-	void		(*early_init)(void); /* No memory allocate available. */
-	void		(*late_init)(void); /* Yes, can allocate memory. */
-#define IOMMU_FINISH_IF_DETECTED (1<<0)
-#define IOMMU_DETECTED		 (1<<1)
-	int		flags;
-};
-/*
- * Macro fills out an entry in the .iommu_table that is equivalent
- * to the fields that 'struct iommu_table_entry' has. The entries
- * that are put in the .iommu_table section are not put in any order
- * hence during boot-time we will have to resort them based on
- * dependency. */
-
-
-#define __IOMMU_INIT(_detect, _depend, _early_init, _late_init, _finish)\
-	static const struct iommu_table_entry				\
-		__iommu_entry_##_detect __used				\
-	__attribute__ ((unused, __section__(".iommu_table"),		\
-			aligned((sizeof(void *)))))	\
-	= {_detect, _depend, _early_init, _late_init,			\
-	   _finish ? IOMMU_FINISH_IF_DETECTED : 0}
-/*
- * The simplest IOMMU definition. Provide the detection routine
- * and it will be run after the SWIOTLB and the other IOMMUs
- * that utilize this macro. If the IOMMU is detected (ie, the
- * detect routine returns a positive value), the other IOMMUs
- * are also checked. You can use IOMMU_INIT_POST_FINISH if you prefer
- * to stop detecting the other IOMMUs after yours has been detected.
- */
-#define IOMMU_INIT_POST(_detect)					\
-	__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb,  NULL, NULL, 0)
-
-#define IOMMU_INIT_POST_FINISH(detect)					\
-	__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb,  NULL, NULL, 1)
-
-/*
- * A more sophisticated version of IOMMU_INIT. This variant requires:
- *  a). A detection routine function.
- *  b). The name of the detection routine we depend on to get called
- *      before us.
- *  c). The init routine which gets called if the detection routine
- *      returns a positive value from the pci_iommu_alloc. This means
- *      no presence of a memory allocator.
- *  d). Similar to the 'init', except that this gets called from pci_iommu_init
- *      where we do have a memory allocator.
- *
- * The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant
- * in that the former will continue detecting other IOMMUs in the call
- * list after the detection routine returns a positive number, while the
- * latter will stop the execution chain upon first successful detection.
- * Both variants will still call the 'init' and 'late_init' functions if
- * they are set.
- */
-#define IOMMU_INIT_FINISH(_detect, _depend, _init, _late_init)		\
-	__IOMMU_INIT(_detect, _depend, _init, _late_init, 1)
-
-#define IOMMU_INIT(_detect, _depend, _init, _late_init)			\
-	__IOMMU_INIT(_detect, _depend, _init, _late_init, 0)
-
-void sort_iommu_table(struct iommu_table_entry *start,
-		      struct iommu_table_entry *finish);
-
-void check_iommu_entries(struct iommu_table_entry *start,
-			 struct iommu_table_entry *finish);
-
-#endif /* _ASM_X86_IOMMU_TABLE_H */
diff --git a/arch/x86/include/asm/swiotlb.h b/arch/x86/include/asm/swiotlb.h
deleted file mode 100644
index ff6c92eff035a..0000000000000
--- a/arch/x86/include/asm/swiotlb.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_X86_SWIOTLB_H
-#define _ASM_X86_SWIOTLB_H
-
-#include <linux/swiotlb.h>
-
-#ifdef CONFIG_SWIOTLB
-extern int swiotlb;
-extern int __init pci_swiotlb_detect_override(void);
-extern int __init pci_swiotlb_detect_4gb(void);
-extern void __init pci_swiotlb_init(void);
-extern void __init pci_swiotlb_late_init(void);
-#else
-#define swiotlb 0
-static inline int pci_swiotlb_detect_override(void)
-{
-	return 0;
-}
-static inline int pci_swiotlb_detect_4gb(void)
-{
-	return 0;
-}
-static inline void pci_swiotlb_init(void)
-{
-}
-static inline void pci_swiotlb_late_init(void)
-{
-}
-#endif
-#endif /* _ASM_X86_SWIOTLB_H */
diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h
index 66b4ddde77430..e5a90b42e4dde 100644
--- a/arch/x86/include/asm/xen/swiotlb-xen.h
+++ b/arch/x86/include/asm/xen/swiotlb-xen.h
@@ -3,10 +3,8 @@
 #define _ASM_X86_SWIOTLB_XEN_H
 
 #ifdef CONFIG_SWIOTLB_XEN
-extern int __init pci_xen_swiotlb_detect(void);
 extern int pci_xen_swiotlb_init_late(void);
 #else
-#define pci_xen_swiotlb_detect NULL
 static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }
 #endif
 
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
index c41ef42adbe8a..e17b7e92a3fa3 100644
--- a/arch/x86/kernel/Makefile
+++ b/arch/x86/kernel/Makefile
@@ -68,7 +68,6 @@ obj-y			+= bootflag.o e820.o
 obj-y			+= pci-dma.o quirks.o topology.o kdebugfs.o
 obj-y			+= alternative.o i8253.o hw_breakpoint.o
 obj-y			+= tsc.o tsc_msr.o io_delay.o rtc.o
-obj-y			+= pci-iommu_table.o
 obj-y			+= resource.o
 obj-y			+= irqflags.o
 obj-y			+= static_call.o
@@ -134,7 +133,6 @@ obj-$(CONFIG_PCSPKR_PLATFORM)	+= pcspeaker.o
 
 obj-$(CONFIG_X86_CHECK_BIOS_CORRUPTION) += check.o
 
-obj-$(CONFIG_SWIOTLB)			+= pci-swiotlb.o
 obj-$(CONFIG_OF)			+= devicetree.o
 obj-$(CONFIG_UPROBES)			+= uprobes.o
 
diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c
index ed837383de5c8..194d54eed5376 100644
--- a/arch/x86/kernel/amd_gart_64.c
+++ b/arch/x86/kernel/amd_gart_64.c
@@ -38,11 +38,9 @@
 #include <asm/iommu.h>
 #include <asm/gart.h>
 #include <asm/set_memory.h>
-#include <asm/swiotlb.h>
 #include <asm/dma.h>
 #include <asm/amd_nb.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
 
 static unsigned long iommu_bus_base;	/* GART remapping area (physical) */
 static unsigned long iommu_size;	/* size of remapping area bytes */
@@ -808,7 +806,7 @@ int __init gart_iommu_init(void)
 	flush_gart();
 	dma_ops = &gart_dma_ops;
 	x86_platform.iommu_shutdown = gart_iommu_shutdown;
-	swiotlb = 0;
+	x86_swiotlb_enable = false;
 
 	return 0;
 }
@@ -842,4 +840,3 @@ void __init gart_parse_options(char *p)
 		}
 	}
 }
-IOMMU_INIT_POST(gart_iommu_hole_init);
diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index af3ba08b684b5..7a5630d904b23 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -392,7 +392,7 @@ void __init early_gart_iommu_check(void)
 
 static int __initdata printed_gart_size_msg;
 
-int __init gart_iommu_hole_init(void)
+void __init gart_iommu_hole_init(void)
 {
 	u32 agp_aper_base = 0, agp_aper_order = 0;
 	u32 aper_size, aper_alloc = 0, aper_order = 0, last_aper_order = 0;
@@ -401,11 +401,11 @@ int __init gart_iommu_hole_init(void)
 	int i, node;
 
 	if (!amd_gart_present())
-		return -ENODEV;
+		return;
 
 	if (gart_iommu_aperture_disabled || !fix_aperture ||
 	    !early_pci_allowed())
-		return -ENODEV;
+		return;
 
 	pr_info("Checking aperture...\n");
 
@@ -491,10 +491,8 @@ int __init gart_iommu_hole_init(void)
 			 * and fixed up the northbridge
 			 */
 			exclude_from_core(last_aper_base, last_aper_order);
-
-			return 1;
 		}
-		return 0;
+		return;
 	}
 
 	if (!fallback_aper_force) {
@@ -527,7 +525,7 @@ int __init gart_iommu_hole_init(void)
 			panic("Not enough memory for aperture");
 		}
 	} else {
-		return 0;
+		return;
 	}
 
 	/*
@@ -561,6 +559,4 @@ int __init gart_iommu_hole_init(void)
 	}
 
 	set_up_gart_resume(aper_order, aper_alloc);
-
-	return 1;
 }
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index de234e7a8962e..df96926421be0 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -7,13 +7,16 @@
 #include <linux/memblock.h>
 #include <linux/gfp.h>
 #include <linux/pci.h>
+#include <linux/amd-iommu.h>
 
 #include <asm/proto.h>
 #include <asm/dma.h>
 #include <asm/iommu.h>
 #include <asm/gart.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
+
+#include <xen/xen.h>
+#include <xen/swiotlb-xen.h>
 
 static bool disable_dac_quirk __read_mostly;
 
@@ -34,24 +37,83 @@ int no_iommu __read_mostly;
 /* Set this to 1 if there is a HW IOMMU in the system */
 int iommu_detected __read_mostly = 0;
 
-extern struct iommu_table_entry __iommu_table[], __iommu_table_end[];
+#ifdef CONFIG_SWIOTLB
+bool x86_swiotlb_enable;
+
+static void __init pci_swiotlb_detect(void)
+{
+	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
+	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
+		x86_swiotlb_enable = true;
+
+	/*
+	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
+	 * devices that can't support DMA to encrypted memory.
+	 */
+	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
+		x86_swiotlb_enable = true;
+
+	if (swiotlb_force == SWIOTLB_FORCE)
+		x86_swiotlb_enable = true;
+}
+#else
+static inline void __init pci_swiotlb_detect(void)
+{
+}
+#endif /* CONFIG_SWIOTLB */
+
+#ifdef CONFIG_SWIOTLB_XEN
+static bool xen_swiotlb;
+
+static void __init pci_xen_swiotlb_init(void)
+{
+	if (!xen_initial_domain() && !x86_swiotlb_enable &&
+	    swiotlb_force != SWIOTLB_FORCE)
+		return;
+	x86_swiotlb_enable = true;
+	xen_swiotlb = true;
+	xen_swiotlb_init_early();
+	dma_ops = &xen_swiotlb_dma_ops;
+	if (IS_ENABLED(CONFIG_PCI))
+		pci_request_acs();
+}
+
+int pci_xen_swiotlb_init_late(void)
+{
+	int rc;
+
+	if (xen_swiotlb)
+		return 0;
+
+	rc = xen_swiotlb_init();
+	if (rc)
+		return rc;
+
+	/* XXX: this switches the dma ops under live devices! */
+	dma_ops = &xen_swiotlb_dma_ops;
+	if (IS_ENABLED(CONFIG_PCI))
+		pci_request_acs();
+	return 0;
+}
+EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
+#else
+static inline void __init pci_xen_swiotlb_init(void)
+{
+}
+#endif /* CONFIG_SWIOTLB_XEN */
 
 void __init pci_iommu_alloc(void)
 {
-	struct iommu_table_entry *p;
-
-	sort_iommu_table(__iommu_table, __iommu_table_end);
-	check_iommu_entries(__iommu_table, __iommu_table_end);
-
-	for (p = __iommu_table; p < __iommu_table_end; p++) {
-		if (p && p->detect && p->detect() > 0) {
-			p->flags |= IOMMU_DETECTED;
-			if (p->early_init)
-				p->early_init();
-			if (p->flags & IOMMU_FINISH_IF_DETECTED)
-				break;
-		}
+	if (xen_pv_domain()) {
+		pci_xen_swiotlb_init();
+		return;
 	}
+	pci_swiotlb_detect();
+	gart_iommu_hole_init();
+	amd_iommu_detect();
+	detect_intel_iommu();
+	if (x86_swiotlb_enable)
+		swiotlb_init(0);
 }
 
 /*
@@ -102,7 +164,7 @@ static __init int iommu_setup(char *p)
 		}
 #ifdef CONFIG_SWIOTLB
 		if (!strncmp(p, "soft", 4))
-			swiotlb = 1;
+			x86_swiotlb_enable = true;
 #endif
 		if (!strncmp(p, "pt", 2))
 			iommu_set_default_passthrough(true);
@@ -121,14 +183,17 @@ early_param("iommu", iommu_setup);
 
 static int __init pci_iommu_init(void)
 {
-	struct iommu_table_entry *p;
-
 	x86_init.iommu.iommu_init();
 
-	for (p = __iommu_table; p < __iommu_table_end; p++) {
-		if (p && (p->flags & IOMMU_DETECTED) && p->late_init)
-			p->late_init();
+#ifdef CONFIG_SWIOTLB
+	/* An IOMMU turned us off. */
+	if (x86_swiotlb_enable) {
+		pr_info("PCI-DMA: Using software bounce buffering for IO (SWIOTLB)\n");
+		swiotlb_print_info();
+	} else {
+		swiotlb_exit();
 	}
+#endif
 
 	return 0;
 }
diff --git a/arch/x86/kernel/pci-iommu_table.c b/arch/x86/kernel/pci-iommu_table.c
deleted file mode 100644
index 42e92ec62973b..0000000000000
--- a/arch/x86/kernel/pci-iommu_table.c
+++ /dev/null
@@ -1,77 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#include <linux/dma-mapping.h>
-#include <asm/iommu_table.h>
-#include <linux/string.h>
-#include <linux/kallsyms.h>
-
-static struct iommu_table_entry * __init
-find_dependents_of(struct iommu_table_entry *start,
-		   struct iommu_table_entry *finish,
-		   struct iommu_table_entry *q)
-{
-	struct iommu_table_entry *p;
-
-	if (!q)
-		return NULL;
-
-	for (p = start; p < finish; p++)
-		if (p->detect == q->depend)
-			return p;
-
-	return NULL;
-}
-
-
-void __init sort_iommu_table(struct iommu_table_entry *start,
-			     struct iommu_table_entry *finish) {
-
-	struct iommu_table_entry *p, *q, tmp;
-
-	for (p = start; p < finish; p++) {
-again:
-		q = find_dependents_of(start, finish, p);
-		/* We are bit sneaky here. We use the memory address to figure
-		 * out if the node we depend on is past our point, if so, swap.
-		 */
-		if (q > p) {
-			tmp = *p;
-			memmove(p, q, sizeof(*p));
-			*q = tmp;
-			goto again;
-		}
-	}
-
-}
-
-#ifdef DEBUG
-void __init check_iommu_entries(struct iommu_table_entry *start,
-				struct iommu_table_entry *finish)
-{
-	struct iommu_table_entry *p, *q, *x;
-
-	/* Simple cyclic dependency checker. */
-	for (p = start; p < finish; p++) {
-		q = find_dependents_of(start, finish, p);
-		x = find_dependents_of(start, finish, q);
-		if (p == x) {
-			printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %pS depends on %pS and vice-versa. BREAKING IT.\n",
-			       p->detect, q->detect);
-			/* Heavy handed way..*/
-			x->depend = NULL;
-		}
-	}
-
-	for (p = start; p < finish; p++) {
-		q = find_dependents_of(p, finish, p);
-		if (q && q > p) {
-			printk(KERN_ERR "EXECUTION ORDER INVALID! %pS should be called before %pS!\n",
-			       p->detect, q->detect);
-		}
-	}
-}
-#else
-void __init check_iommu_entries(struct iommu_table_entry *start,
-				       struct iommu_table_entry *finish)
-{
-}
-#endif
diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
deleted file mode 100644
index 814ab46a0dada..0000000000000
--- a/arch/x86/kernel/pci-swiotlb.c
+++ /dev/null
@@ -1,77 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
-#include <linux/pci.h>
-#include <linux/cache.h>
-#include <linux/init.h>
-#include <linux/swiotlb.h>
-#include <linux/memblock.h>
-#include <linux/dma-direct.h>
-#include <linux/cc_platform.h>
-
-#include <asm/iommu.h>
-#include <asm/swiotlb.h>
-#include <asm/dma.h>
-#include <asm/xen/swiotlb-xen.h>
-#include <asm/iommu_table.h>
-
-int swiotlb __read_mostly;
-
-/*
- * pci_swiotlb_detect_override - set swiotlb to 1 if necessary
- *
- * This returns non-zero if we are forced to use swiotlb (by the boot
- * option).
- */
-int __init pci_swiotlb_detect_override(void)
-{
-	if (swiotlb_force == SWIOTLB_FORCE)
-		swiotlb = 1;
-
-	return swiotlb;
-}
-IOMMU_INIT_FINISH(pci_swiotlb_detect_override,
-		  pci_xen_swiotlb_detect,
-		  pci_swiotlb_init,
-		  pci_swiotlb_late_init);
-
-/*
- * If 4GB or more detected (and iommu=off not set) or if SME is active
- * then set swiotlb to 1 and return 1.
- */
-int __init pci_swiotlb_detect_4gb(void)
-{
-	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
-	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
-		swiotlb = 1;
-
-	/*
-	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
-	 * devices that can't support DMA to encrypted memory.
-	 */
-	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
-		swiotlb = 1;
-
-	return swiotlb;
-}
-IOMMU_INIT(pci_swiotlb_detect_4gb,
-	   pci_swiotlb_detect_override,
-	   pci_swiotlb_init,
-	   pci_swiotlb_late_init);
-
-void __init pci_swiotlb_init(void)
-{
-	if (swiotlb)
-		swiotlb_init(0);
-}
-
-void __init pci_swiotlb_late_init(void)
-{
-	/* An IOMMU turned us off. */
-	if (!swiotlb)
-		swiotlb_exit();
-	else {
-		printk(KERN_INFO "PCI-DMA: "
-		       "Using software bounce buffering for IO (SWIOTLB)\n");
-		swiotlb_print_info();
-	}
-}
diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
index f9af561c3cd4f..0c1154a1c4032 100644
--- a/arch/x86/kernel/tboot.c
+++ b/arch/x86/kernel/tboot.c
@@ -24,7 +24,6 @@
 #include <asm/processor.h>
 #include <asm/bootparam.h>
 #include <asm/pgalloc.h>
-#include <asm/swiotlb.h>
 #include <asm/fixmap.h>
 #include <asm/proto.h>
 #include <asm/setup.h>
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 7fda7f27e7620..f5f6dc2e80072 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -315,18 +315,6 @@ SECTIONS
 		*(.altinstr_replacement)
 	}
 
-	/*
-	 * struct iommu_table_entry entries are injected in this section.
-	 * It is an array of IOMMUs which during run time gets sorted depending
-	 * on its dependency order. After rootfs_initcall is complete
-	 * this section can be safely removed.
-	 */
-	.iommu_table : AT(ADDR(.iommu_table) - LOAD_OFFSET) {
-		__iommu_table = .;
-		*(.iommu_table)
-		__iommu_table_end = .;
-	}
-
 	. = ALIGN(8);
 	.apicdrivers : AT(ADDR(.apicdrivers) - LOAD_OFFSET) {
 		__apicdrivers = .;
diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 4953260e281c3..3c5b52fbe4a7f 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -47,6 +47,4 @@ obj-$(CONFIG_XEN_DEBUG_FS)	+= debugfs.o
 
 obj-$(CONFIG_XEN_PV_DOM0)	+= vga.o
 
-obj-$(CONFIG_SWIOTLB_XEN)	+= pci-swiotlb-xen.o
-
 obj-$(CONFIG_XEN_EFI)		+= efi.o
diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
deleted file mode 100644
index 46df59aeaa06a..0000000000000
--- a/arch/x86/xen/pci-swiotlb-xen.c
+++ /dev/null
@@ -1,96 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
-/* Glue code to lib/swiotlb-xen.c */
-
-#include <linux/dma-map-ops.h>
-#include <linux/pci.h>
-#include <xen/swiotlb-xen.h>
-
-#include <asm/xen/hypervisor.h>
-#include <xen/xen.h>
-#include <asm/iommu_table.h>
-
-
-#include <asm/xen/swiotlb-xen.h>
-#ifdef CONFIG_X86_64
-#include <asm/iommu.h>
-#include <asm/dma.h>
-#endif
-#include <linux/export.h>
-
-static int xen_swiotlb __read_mostly;
-
-/*
- * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary
- *
- * This returns non-zero if we are forced to use xen_swiotlb (by the boot
- * option).
- */
-int __init pci_xen_swiotlb_detect(void)
-{
-
-	if (!xen_pv_domain())
-		return 0;
-
-	/* If running as PV guest, either iommu=soft, or swiotlb=force will
-	 * activate this IOMMU. If running as PV privileged, activate it
-	 * irregardless.
-	 */
-	if (xen_initial_domain() || swiotlb || swiotlb_force == SWIOTLB_FORCE)
-		xen_swiotlb = 1;
-
-	/* If we are running under Xen, we MUST disable the native SWIOTLB.
-	 * Don't worry about swiotlb_force flag activating the native, as
-	 * the 'swiotlb' flag is the only one turning it on. */
-	swiotlb = 0;
-
-#ifdef CONFIG_X86_64
-	/* pci_swiotlb_detect_4gb turns on native SWIOTLB if no_iommu == 0
-	 * (so no iommu=X command line over-writes).
-	 * Considering that PV guests do not want the *native SWIOTLB* but
-	 * only Xen SWIOTLB it is not useful to us so set no_iommu=1 here.
-	 */
-	if (max_pfn > MAX_DMA32_PFN)
-		no_iommu = 1;
-#endif
-	return xen_swiotlb;
-}
-
-static void __init pci_xen_swiotlb_init(void)
-{
-	if (xen_swiotlb) {
-		xen_swiotlb_init_early();
-		dma_ops = &xen_swiotlb_dma_ops;
-
-#ifdef CONFIG_PCI
-		/* Make sure ACS will be enabled */
-		pci_request_acs();
-#endif
-	}
-}
-
-int pci_xen_swiotlb_init_late(void)
-{
-	int rc;
-
-	if (xen_swiotlb)
-		return 0;
-
-	rc = xen_swiotlb_init();
-	if (rc)
-		return rc;
-
-	dma_ops = &xen_swiotlb_dma_ops;
-#ifdef CONFIG_PCI
-	/* Make sure ACS will be enabled */
-	pci_request_acs();
-#endif
-
-	return 0;
-}
-EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
-
-IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
-		  NULL,
-		  pci_xen_swiotlb_init,
-		  NULL);
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index b4a798c7b347f..1a3ad58ba8465 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -27,7 +27,6 @@
 #include <asm/apic.h>
 #include <asm/gart.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
 #include <asm/io_apic.h>
 #include <asm/irq_remapping.h>
 #include <asm/set_memory.h>
@@ -3257,11 +3256,6 @@ __setup("ivrs_ioapic",		parse_ivrs_ioapic);
 __setup("ivrs_hpet",		parse_ivrs_hpet);
 __setup("ivrs_acpihid",		parse_ivrs_acpihid);
 
-IOMMU_INIT_FINISH(amd_iommu_detect,
-		  gart_iommu_hole_init,
-		  NULL,
-		  NULL);
-
 bool amd_iommu_v2_supported(void)
 {
 	return amd_iommu_v2_present;
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index a1ada7bff44e6..b47220ac09eaa 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -1840,7 +1840,10 @@ void amd_iommu_domain_update(struct protection_domain *domain)
 
 static void __init amd_iommu_init_dma_ops(void)
 {
-	swiotlb = (iommu_default_passthrough() || sme_me_mask) ? 1 : 0;
+	if (iommu_default_passthrough() || sme_me_mask)
+		x86_swiotlb_enable = true;
+	else
+		x86_swiotlb_enable = false;
 }
 
 int __init amd_iommu_init_api(void)
diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index 4de960834a1b2..592c1e1a5d4b9 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -30,7 +30,6 @@
 #include <linux/numa.h>
 #include <linux/limits.h>
 #include <asm/irq_remapping.h>
-#include <asm/iommu_table.h>
 #include <trace/events/intel_iommu.h>
 
 #include "../irq_remapping.h"
@@ -912,7 +911,7 @@ dmar_validate_one_drhd(struct acpi_dmar_header *entry, void *arg)
 	return 0;
 }
 
-int __init detect_intel_iommu(void)
+void __init detect_intel_iommu(void)
 {
 	int ret;
 	struct dmar_res_callback validate_drhd_cb = {
@@ -945,8 +944,6 @@ int __init detect_intel_iommu(void)
 		dmar_tbl = NULL;
 	}
 	up_write(&dmar_global_lock);
-
-	return ret ? ret : 1;
 }
 
 static void unmap_iommu(struct intel_iommu *iommu)
@@ -2164,7 +2161,6 @@ static int __init dmar_free_unused_resources(void)
 }
 
 late_initcall(dmar_free_unused_resources);
-IOMMU_INIT_POST(detect_intel_iommu);
 
 /*
  * DMAR Hotplug Support
diff --git a/include/linux/dmar.h b/include/linux/dmar.h
index 45e903d847335..cbd714a198a0a 100644
--- a/include/linux/dmar.h
+++ b/include/linux/dmar.h
@@ -121,7 +121,7 @@ extern int dmar_remove_dev_scope(struct dmar_pci_notify_info *info,
 				 u16 segment, struct dmar_dev_scope *devices,
 				 int count);
 /* Intel IOMMU detection */
-extern int detect_intel_iommu(void);
+void detect_intel_iommu(void);
 extern int enable_drhd_fault_handling(void);
 extern int dmar_device_add(acpi_handle handle);
 extern int dmar_device_remove(acpi_handle handle);
@@ -197,6 +197,10 @@ static inline bool dmar_platform_optin(void)
 	return false;
 }
 
+static inline void detect_intel_iommu(void)
+{
+}
+
 #endif /* CONFIG_DMAR_TABLE */
 
 struct irte {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:06:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:06:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298125.507808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvT-0004un-Qz; Mon, 04 Apr 2022 05:06:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298125.507808; Mon, 04 Apr 2022 05:06:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvT-0004t0-KH; Mon, 04 Apr 2022 05:06:51 +0000
Received: by outflank-mailman (input) for mailman id 298125;
 Mon, 04 Apr 2022 05:06:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvS-00021C-RI
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:50 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0865435b-b3d5-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 07:06:50 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvG-00D95w-SQ; Mon, 04 Apr 2022 05:06:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0865435b-b3d5-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=VlHGJyMm9vzjIewl+QL3o4DmXNPqBE0xLUE3ejLiJgA=; b=VvTajNYxlVH8VM8PJFY0XdrnDE
	PYMemX1VnGoK/6lMerwGvFWsXR63qtldaV9JNnljEtSNzVgnoja0hj0U4yTVPJciulZJmTsOI3InN
	9hUlVc62KvnpHo9FcY7S2qTjaXiVY8On07Etkgs7y+Zf1tacU/1T/jDeLWMfoNw99mUlitJW6j7sp
	sR3bgvz3cSLVxwfkpBzV25UYIr9nlpUkxvMpGAkcr7rxsGfZ9bUZedEDez4l3//tIzUMxcmnj07eu
	vbRPdl2Gx79fwX5yqj6ntMFxO89PZnRv3tx/aIDni2kH+augWjt6yLz05Y4QJbSg/3+OhHwoek82/
	unMzf8FA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 08/15] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled
Date: Mon,  4 Apr 2022 07:05:52 +0200
Message-Id: <20220404050559.132378-9-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Move enabling SWIOTLB_FORCE for guest memory encryption into common code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/kernel/cpu/mshyperv.c | 8 --------
 arch/x86/kernel/pci-dma.c      | 8 ++++++++
 arch/x86/mm/mem_encrypt_amd.c  | 3 ---
 3 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 4b67094215bba..5b8f2c3571601 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -337,14 +337,6 @@ static void __init ms_hyperv_init_platform(void)
 			swiotlb_unencrypted_base = ms_hyperv.shared_gpa_boundary;
 #endif
 		}
-
-#ifdef CONFIG_SWIOTLB
-		/*
-		 * Enable swiotlb force mode in Isolation VM to
-		 * use swiotlb bounce buffer for dma transaction.
-		 */
-		swiotlb_force = SWIOTLB_FORCE;
-#endif
 		/* Isolation VMs are unenlightened SEV-based VMs, thus this check: */
 		if (IS_ENABLED(CONFIG_AMD_MEM_ENCRYPT)) {
 			if (hv_get_isolation_type() != HV_ISOLATION_TYPE_NONE)
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index df96926421be0..04140e20ef1a3 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -53,6 +53,14 @@ static void __init pci_swiotlb_detect(void)
 	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
 		x86_swiotlb_enable = true;
 
+	/*
+	 * Guest with guest memory encryption currently perform all DMA through
+	 * bounce buffers as the hypervisor can't access arbitrary VM memory
+	 * that is not explicitly shared with it.
+	 */
+	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
+		swiotlb_force = SWIOTLB_FORCE;
+
 	if (swiotlb_force == SWIOTLB_FORCE)
 		x86_swiotlb_enable = true;
 }
diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c
index 6169053c28541..d732d727d3dee 100644
--- a/arch/x86/mm/mem_encrypt_amd.c
+++ b/arch/x86/mm/mem_encrypt_amd.c
@@ -432,9 +432,6 @@ void __init sme_early_init(void)
 	for (i = 0; i < ARRAY_SIZE(protection_map); i++)
 		protection_map[i] = pgprot_encrypted(protection_map[i]);
 
-	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
-		swiotlb_force = SWIOTLB_FORCE;
-
 	x86_platform.guest.enc_status_change_prepare = amd_enc_status_change_prepare;
 	x86_platform.guest.enc_status_change_finish  = amd_enc_status_change_finish;
 	x86_platform.guest.enc_tlb_flush_required    = amd_enc_tlb_flush_required;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:07:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:07:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298130.507825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvc-0005wN-52; Mon, 04 Apr 2022 05:07:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298130.507825; Mon, 04 Apr 2022 05:07:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEvb-0005wD-W1; Mon, 04 Apr 2022 05:06:59 +0000
Received: by outflank-mailman (input) for mailman id 298130;
 Mon, 04 Apr 2022 05:06:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvb-000216-6g
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:59 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d45ac54-b3d5-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:06:58 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvO-00D9D7-LO; Mon, 04 Apr 2022 05:06:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d45ac54-b3d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=cglDQ544TZBR8iIX+lAj25Nh7/wZoWF1SIJV8fBYJSc=; b=wskLiSoDsVLKEGZ1Sdhe2vLHxA
	/LFmu+C4Ch41odlEGfE4k/6biHOMWLMavXZg1/FJ/PTrBuOvNRcttQrXGPQnQX2ejO7VQl+P5h4vJ
	jjyTmth+NW0RQQNORsIdANiYQbpSIbwzbho7ETCWH+JQ1Eant6nnSsoOakf4a4SiDmtHa4gIQ2ewj
	1yuavxAdLwimQnkOJ+SrmcUXPc/FEsqsVhilArD7VqVLLg0TjTvuTMhiWfExtg0d+132+oAu/FSc+
	NdnMGNgT/WfGxUS28PWBLTMrBmwyxygrBQmBlUWTFICH/VEeaVF9jSvk+mMKaW31WvbccHzGgWs+H
	b2tNFv4A==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction
Date: Mon,  4 Apr 2022 07:05:54 +0200
Message-Id: <20220404050559.132378-11-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Power SVM wants to allocate a swiotlb buffer that is not restricted to
low memory for the trusted hypervisor scheme.  Consolidate the support
for this into the swiotlb_init interface by adding a new flag.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/powerpc/include/asm/svm.h       |  4 ----
 arch/powerpc/include/asm/swiotlb.h   |  1 +
 arch/powerpc/kernel/dma-swiotlb.c    |  1 +
 arch/powerpc/mm/mem.c                |  5 +----
 arch/powerpc/platforms/pseries/svm.c | 26 +-------------------------
 include/linux/swiotlb.h              |  1 +
 kernel/dma/swiotlb.c                 | 11 +++++++++--
 7 files changed, 14 insertions(+), 35 deletions(-)

diff --git a/arch/powerpc/include/asm/svm.h b/arch/powerpc/include/asm/svm.h
index 7546402d796af..85580b30aba48 100644
--- a/arch/powerpc/include/asm/svm.h
+++ b/arch/powerpc/include/asm/svm.h
@@ -15,8 +15,6 @@ static inline bool is_secure_guest(void)
 	return mfmsr() & MSR_S;
 }
 
-void __init svm_swiotlb_init(void);
-
 void dtl_cache_ctor(void *addr);
 #define get_dtl_cache_ctor()	(is_secure_guest() ? dtl_cache_ctor : NULL)
 
@@ -27,8 +25,6 @@ static inline bool is_secure_guest(void)
 	return false;
 }
 
-static inline void svm_swiotlb_init(void) {}
-
 #define get_dtl_cache_ctor() NULL
 
 #endif /* CONFIG_PPC_SVM */
diff --git a/arch/powerpc/include/asm/swiotlb.h b/arch/powerpc/include/asm/swiotlb.h
index 3c1a1cd161286..4203b5e0a88ed 100644
--- a/arch/powerpc/include/asm/swiotlb.h
+++ b/arch/powerpc/include/asm/swiotlb.h
@@ -9,6 +9,7 @@
 #include <linux/swiotlb.h>
 
 extern unsigned int ppc_swiotlb_enable;
+extern unsigned int ppc_swiotlb_flags;
 
 #ifdef CONFIG_SWIOTLB
 void swiotlb_detect_4g(void);
diff --git a/arch/powerpc/kernel/dma-swiotlb.c b/arch/powerpc/kernel/dma-swiotlb.c
index fc7816126a401..ba256c37bcc0f 100644
--- a/arch/powerpc/kernel/dma-swiotlb.c
+++ b/arch/powerpc/kernel/dma-swiotlb.c
@@ -10,6 +10,7 @@
 #include <asm/swiotlb.h>
 
 unsigned int ppc_swiotlb_enable;
+unsigned int ppc_swiotlb_flags;
 
 void __init swiotlb_detect_4g(void)
 {
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index e1519e2edc656..a4d65418c30a9 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -249,10 +249,7 @@ void __init mem_init(void)
 	 * back to to-down.
 	 */
 	memblock_set_bottom_up(true);
-	if (is_secure_guest())
-		svm_swiotlb_init();
-	else
-		swiotlb_init(ppc_swiotlb_enable, 0);
+	swiotlb_init(ppc_swiotlb_enable, ppc_swiotlb_flags);
 #endif
 
 	high_memory = (void *) __va(max_low_pfn * PAGE_SIZE);
diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c
index c5228f4969eb2..3b4045d508ec8 100644
--- a/arch/powerpc/platforms/pseries/svm.c
+++ b/arch/powerpc/platforms/pseries/svm.c
@@ -28,7 +28,7 @@ static int __init init_svm(void)
 	 * need to use the SWIOTLB buffer for DMA even if dma_capable() says
 	 * otherwise.
 	 */
-	swiotlb_force = SWIOTLB_FORCE;
+	ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE;
 
 	/* Share the SWIOTLB buffer with the host. */
 	swiotlb_update_mem_attributes();
@@ -37,30 +37,6 @@ static int __init init_svm(void)
 }
 machine_early_initcall(pseries, init_svm);
 
-/*
- * Initialize SWIOTLB. Essentially the same as swiotlb_init(), except that it
- * can allocate the buffer anywhere in memory. Since the hypervisor doesn't have
- * any addressing limitation, we don't need to allocate it in low addresses.
- */
-void __init svm_swiotlb_init(void)
-{
-	unsigned char *vstart;
-	unsigned long bytes, io_tlb_nslabs;
-
-	io_tlb_nslabs = (swiotlb_size_or_default() >> IO_TLB_SHIFT);
-	io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE);
-
-	bytes = io_tlb_nslabs << IO_TLB_SHIFT;
-
-	vstart = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE);
-	if (vstart && !swiotlb_init_with_tbl(vstart, io_tlb_nslabs, false))
-		return;
-
-
-	memblock_free(vstart, PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT));
-	panic("SVM: Cannot allocate SWIOTLB buffer");
-}
-
 int set_memory_encrypted(unsigned long addr, int numpages)
 {
 	if (!cc_platform_has(CC_ATTR_MEM_ENCRYPT))
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index ae0407173e845..eabdd89987027 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -15,6 +15,7 @@ struct scatterlist;
 
 #define SWIOTLB_VERBOSE	(1 << 0) /* verbose initialization */
 #define SWIOTLB_FORCE	(1 << 1) /* force bounce buffering */
+#define SWIOTLB_ANY	(1 << 2) /* allow any memory for the buffer */
 
 /*
  * Maximum allowable number of contiguous slabs to map,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 86e877a96b828..f6e091424af3d 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -266,8 +266,15 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 	if (swiotlb_force_disable)
 		return;
 
-	/* Get IO TLB memory from the low pages */
-	tlb = memblock_alloc_low(bytes, PAGE_SIZE);
+	/*
+	 * By default allocate the bounce buffer memory from low memory, but
+	 * allow to pick a location everywhere for hypervisors with guest
+	 * memory encryption.
+	 */
+	if (flags & SWIOTLB_ANY)
+		tlb = memblock_alloc(bytes, PAGE_SIZE);
+	else
+		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
 		goto fail;
 	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:07:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:07:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298138.507836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwX-0007cD-Hy; Mon, 04 Apr 2022 05:07:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298138.507836; Mon, 04 Apr 2022 05:07:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwX-0007c6-EA; Mon, 04 Apr 2022 05:07:57 +0000
Received: by outflank-mailman (input) for mailman id 298138;
 Mon, 04 Apr 2022 05:07:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvk-000216-DK
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:07:08 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 12a045d1-b3d5-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:07:07 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvW-00D9L3-0A; Mon, 04 Apr 2022 05:06:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12a045d1-b3d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=aq2ni6Lf0CpK3df5eW6dRpDmxtP8L4VBzIRLdPcEzSo=; b=FBiz0wC3YdrPGDM0rdnH/qoGXA
	VYkDtbQpvt2fI8ej400Q1jc2XmYfkdsJ5sE/ZOz4pKo2/9MdZM9x9UHa3H5PMeDKeY/LcdX4E+KDO
	TOzPsd2Euc9j1OdgmqwiGDrKzCCtMxHdYTKsyUCOMAAMqNNycXBgqAHiPNMb4ONOT9i1diZ/+B09o
	M3/pusVbyC+/w8inru8UWPzaVJOWCq3Q5YnUtzqnCsGkRRX8gHCRyEiI5lE6Ssa64NZBLBEtSPKlD
	QVo7JR+VeYC5vuM6HijKXTbzEPEucQfhkqCMgL0AlxsrHY7gO/+OUWB8pxQq6WhaYYOWAzLYgtVhj
	s35TimYQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 12/15] swiotlb: provide swiotlb_init variants that remap the buffer
Date: Mon,  4 Apr 2022 07:05:56 +0200
Message-Id: <20220404050559.132378-13-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

To shared more code between swiotlb and xen-swiotlb, offer a
swiotlb_init_remap interface and add a remap callback to
swiotlb_init_late that will allow Xen to remap the buffer the
buffer without duplicating much of the logic.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/pci/sta2x11-fixup.c |  2 +-
 include/linux/swiotlb.h      |  5 ++++-
 kernel/dma/swiotlb.c         | 36 +++++++++++++++++++++++++++++++++---
 3 files changed, 38 insertions(+), 5 deletions(-)

diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index c7e6faf59a861..7368afc039987 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_init_late(size, GFP_DMA))
+		if (swiotlb_init_late(size, GFP_DMA, NULL))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index ee655f2e4d28b..7b50c82f84ce9 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -36,8 +36,11 @@ struct scatterlist;
 
 int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
 unsigned long swiotlb_size_or_default(void);
+void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
+	int (*remap)(void *tlb, unsigned long nslabs));
+int swiotlb_init_late(size_t size, gfp_t gfp_mask,
+	int (*remap)(void *tlb, unsigned long nslabs));
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-int swiotlb_init_late(size_t size, gfp_t gfp_mask);
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 119187afc65ec..d5fe8f5e08300 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -256,9 +256,11 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
  * Statically reserve bounce buffer space and initialize bounce buffer data
  * structures for the software IO TLB used to implement the DMA API.
  */
-void __init swiotlb_init(bool addressing_limit, unsigned int flags)
+void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
+		int (*remap)(void *tlb, unsigned long nslabs))
 {
-	size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
+	unsigned long nslabs = default_nslabs;
+	size_t bytes;
 	void *tlb;
 
 	if (!addressing_limit && !swiotlb_force_bounce)
@@ -271,12 +273,23 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 	 * allow to pick a location everywhere for hypervisors with guest
 	 * memory encryption.
 	 */
+retry:
+	bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
 	if (flags & SWIOTLB_ANY)
 		tlb = memblock_alloc(bytes, PAGE_SIZE);
 	else
 		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
 		goto fail;
+	if (remap && remap(tlb, nslabs) < 0) {
+		memblock_free(tlb, PAGE_ALIGN(bytes));
+
+		nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE);
+		if (nslabs < IO_TLB_MIN_SLABS)
+			panic("%s: Failed to remap %zu bytes\n",
+			      __func__, bytes);
+		goto retry;
+	}
 	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
 		goto fail_free_mem;
 	return;
@@ -287,12 +300,18 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 	pr_warn("Cannot allocate buffer");
 }
 
+void __init swiotlb_init(bool addressing_limit, unsigned int flags)
+{
+	return swiotlb_init_remap(addressing_limit, flags, NULL);
+}
+
 /*
  * Systems with larger DMA zones (those that don't support ISA) can
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int swiotlb_init_late(size_t size, gfp_t gfp_mask)
+int swiotlb_init_late(size_t size, gfp_t gfp_mask,
+		int (*remap)(void *tlb, unsigned long nslabs))
 {
 	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
@@ -303,6 +322,7 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 	if (swiotlb_force_disable)
 		return 0;
 
+retry:
 	order = get_order(nslabs << IO_TLB_SHIFT);
 	nslabs = SLABS_PER_PAGE << order;
 	bytes = nslabs << IO_TLB_SHIFT;
@@ -323,6 +343,16 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 			(PAGE_SIZE << order) >> 20);
 		nslabs = SLABS_PER_PAGE << order;
 	}
+	if (remap)
+		rc = remap(vstart, nslabs);
+	if (rc) {
+		free_pages((unsigned long)vstart, order);
+ 
+		nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE);
+		if (nslabs < IO_TLB_MIN_SLABS)
+			return rc;
+		goto retry;
+	}
 	rc = swiotlb_late_init_with_tbl(vstart, nslabs);
 	if (rc)
 		free_pages((unsigned long)vstart, order);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:08:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:08:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298141.507847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwe-0007zF-QE; Mon, 04 Apr 2022 05:08:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298141.507847; Mon, 04 Apr 2022 05:08:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwe-0007z8-Mg; Mon, 04 Apr 2022 05:08:04 +0000
Received: by outflank-mailman (input) for mailman id 298141;
 Mon, 04 Apr 2022 05:08:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvw-00021C-Ft
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:07:20 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1a0c530f-b3d5-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 07:07:19 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvh-00D9WH-9g; Mon, 04 Apr 2022 05:07:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a0c530f-b3d5-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=zCMW1Q+QCPXYuvBuEGOZUQKFwE9OwdLFtYhltvQ29K4=; b=h90d0JdGazEf2lAqBNulU+XMv/
	508lRWfJhfGKIa5nnuHn+b7tvsEWz2AsvhE+MQH0MMBChTuOnEmKyYWD5yk6U4HBindypqWrzUFFh
	MhJpJMQ87KsLu1Kjn+XLyYx5DYL0Zbi0AacibSfjwl/FeWzykIzsI4mkT3cWk8TxoKW0XMJcQKP8p
	5ySTLFO2aybW8Laq2SQbmA+tah/Xk0/f66Z6ET15udoRDTEAxIqwwgW9UFv/Px4vOtV7oJ3BZ4mrW
	mKwPYdG12AHaOFvsZacB73FFLsCt49dOZM+lFoyO/JiFfEEU66LswcvHcdlsG0nQW8z9gKNagI0x5
	rkHwesTA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 15/15] x86: remove cruft from <asm/dma-mapping.h>
Date: Mon,  4 Apr 2022 07:05:59 +0200
Message-Id: <20220404050559.132378-16-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

<asm/dma-mapping.h> gets pulled in by all drivers using the DMA API.
Remove x86 internal variables and unnecessary includes from it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/include/asm/dma-mapping.h | 11 -----------
 arch/x86/include/asm/iommu.h       |  2 ++
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index 256fd8115223d..1c66708e30623 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -2,17 +2,6 @@
 #ifndef _ASM_X86_DMA_MAPPING_H
 #define _ASM_X86_DMA_MAPPING_H
 
-/*
- * IOMMU interface. See Documentation/core-api/dma-api-howto.rst and
- * Documentation/core-api/dma-api.rst for documentation.
- */
-
-#include <linux/scatterlist.h>
-#include <asm/io.h>
-
-extern int iommu_merge;
-extern int panic_on_overflow;
-
 extern const struct dma_map_ops *dma_ops;
 
 static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h
index dba89ed40d38d..0bef44d30a278 100644
--- a/arch/x86/include/asm/iommu.h
+++ b/arch/x86/include/asm/iommu.h
@@ -8,6 +8,8 @@
 
 extern int force_iommu, no_iommu;
 extern int iommu_detected;
+extern int iommu_merge;
+extern int panic_on_overflow;
 
 #ifdef CONFIG_SWIOTLB
 extern bool x86_swiotlb_enable;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:08:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:08:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298142.507858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwl-0008Nn-46; Mon, 04 Apr 2022 05:08:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298142.507858; Mon, 04 Apr 2022 05:08:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwl-0008Nd-0J; Mon, 04 Apr 2022 05:08:11 +0000
Received: by outflank-mailman (input) for mailman id 298142;
 Mon, 04 Apr 2022 05:08:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvu-000216-Ai
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:07:18 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18ae8fdd-b3d5-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:07:17 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvd-00D9SX-Gu; Mon, 04 Apr 2022 05:07:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18ae8fdd-b3d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=k2GXkvjY5MZ/f56SHxx5411JaZxKsGzZdPpduchxlxM=; b=SyDkm8mDvf+l0PvMChLDKGz+my
	cZtcRYXV9Hr2G9yPQ0LSgJkQ3zcbApXBDNKf18vvh9ZAvijelLU5NAursY6JK3GaQCBy6v+k3JvkN
	TL1F+dmc9RkeHdQMAE1/ibXmiYQ439Ex/5+OTvIQrM0odOarx9Qm64zowzpLUlEg7DVwxADtmAkdH
	/zPoPMsgOTR+RNnR2BfT+4JRRMrP3xk8DME1P+o0RQV1Wn78yYi6eylfhmI+5w7K1bpUeKqiLyuR5
	vbWxG/u24ODfUGo9BE8yI+4h9MoWDDg7DdRjqeIbJGrEQ7dUs9aEFnlLa/r2N6gwFuhyLxRo/Eu3c
	mgXzC/pw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 14/15] swiotlb: remove swiotlb_init_with_tbl and swiotlb_init_late_with_tbl
Date: Mon,  4 Apr 2022 07:05:58 +0200
Message-Id: <20220404050559.132378-15-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

No users left.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/swiotlb.h |  2 --
 kernel/dma/swiotlb.c    | 77 +++++++++++------------------------------
 2 files changed, 20 insertions(+), 59 deletions(-)

diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 7b50c82f84ce9..7ed35dd3de6e7 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -34,13 +34,11 @@ struct scatterlist;
 /* default to 64MB */
 #define IO_TLB_DEFAULT_SIZE (64UL<<20)
 
-int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
 unsigned long swiotlb_size_or_default(void);
 void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
 	int (*remap)(void *tlb, unsigned long nslabs));
 int swiotlb_init_late(size_t size, gfp_t gfp_mask,
 	int (*remap)(void *tlb, unsigned long nslabs));
-extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index d5fe8f5e08300..c54fc40ebb493 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -225,33 +225,6 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	return;
 }
 
-int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
-		unsigned int flags)
-{
-	struct io_tlb_mem *mem = &io_tlb_default_mem;
-	size_t alloc_size;
-
-	if (swiotlb_force_disable)
-		return 0;
-
-	/* protect against double initialization */
-	if (WARN_ON_ONCE(mem->nslabs))
-		return -ENOMEM;
-
-	alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs));
-	mem->slots = memblock_alloc(alloc_size, PAGE_SIZE);
-	if (!mem->slots)
-		panic("%s: Failed to allocate %zu bytes align=0x%lx\n",
-		      __func__, alloc_size, PAGE_SIZE);
-
-	swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
-	mem->force_bounce = flags & SWIOTLB_FORCE;
-
-	if (flags & SWIOTLB_VERBOSE)
-		swiotlb_print_info();
-	return 0;
-}
-
 /*
  * Statically reserve bounce buffer space and initialize bounce buffer data
  * structures for the software IO TLB used to implement the DMA API.
@@ -259,7 +232,9 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
 void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
 		int (*remap)(void *tlb, unsigned long nslabs))
 {
+	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	unsigned long nslabs = default_nslabs;
+	size_t alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs));
 	size_t bytes;
 	void *tlb;
 
@@ -280,7 +255,8 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
 	else
 		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
-		goto fail;
+		panic("%s: failed to allocate tlb structure\n", __func__);
+
 	if (remap && remap(tlb, nslabs) < 0) {
 		memblock_free(tlb, PAGE_ALIGN(bytes));
 
@@ -290,14 +266,17 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
 			      __func__, bytes);
 		goto retry;
 	}
-	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
-		goto fail_free_mem;
-	return;
 
-fail_free_mem:
-	memblock_free(tlb, bytes);
-fail:
-	pr_warn("Cannot allocate buffer");
+	mem->slots = memblock_alloc(alloc_size, PAGE_SIZE);
+	if (!mem->slots)
+		panic("%s: Failed to allocate %zu bytes align=0x%lx\n",
+		      __func__, alloc_size, PAGE_SIZE);
+
+	swiotlb_init_io_tlb_mem(mem, __pa(tlb), default_nslabs, false);
+	mem->force_bounce = flags & SWIOTLB_FORCE;
+
+	if (flags & SWIOTLB_VERBOSE)
+		swiotlb_print_info();
 }
 
 void __init swiotlb_init(bool addressing_limit, unsigned int flags)
@@ -313,6 +292,7 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 int swiotlb_init_late(size_t size, gfp_t gfp_mask,
 		int (*remap)(void *tlb, unsigned long nslabs))
 {
+	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
 	unsigned char *vstart = NULL;
@@ -353,33 +333,16 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask,
 			return rc;
 		goto retry;
 	}
-	rc = swiotlb_late_init_with_tbl(vstart, nslabs);
-	if (rc)
-		free_pages((unsigned long)vstart, order);
-
-	return rc;
-}
-
-int
-swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
-{
-	struct io_tlb_mem *mem = &io_tlb_default_mem;
-	unsigned long bytes = nslabs << IO_TLB_SHIFT;
-
-	if (swiotlb_force_disable)
-		return 0;
-
-	/* protect against double initialization */
-	if (WARN_ON_ONCE(mem->nslabs))
-		return -ENOMEM;
 
 	mem->slots = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO,
 		get_order(array_size(sizeof(*mem->slots), nslabs)));
-	if (!mem->slots)
+	if (!mem->slots) {
+		free_pages((unsigned long)vstart, order);
 		return -ENOMEM;
+	}
 
-	set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT);
-	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
+	set_memory_decrypted((unsigned long)vstart, bytes >> PAGE_SHIFT);
+	swiotlb_init_io_tlb_mem(mem, virt_to_phys(vstart), nslabs, true);
 
 	swiotlb_print_info();
 	return 0;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:08:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:08:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298143.507864 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwl-0008Rj-HL; Mon, 04 Apr 2022 05:08:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298143.507864; Mon, 04 Apr 2022 05:08:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwl-0008Qz-B3; Mon, 04 Apr 2022 05:08:11 +0000
Received: by outflank-mailman (input) for mailman id 298143;
 Mon, 04 Apr 2022 05:08:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEve-000216-Kg
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:07:02 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0f5e91d3-b3d5-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:07:02 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvS-00D9Gu-8c; Mon, 04 Apr 2022 05:06:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f5e91d3-b3d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=RjiwiTF3Oxb6vRH/IITMaa9hgA1bQqA9QM5+9nVyYm8=; b=mYojJH8rP+rsDTvUcL/Rr9LyRc
	QfbxMF/sAOYZNJbgDYgeYLuVB9ZrStMxJIXkPtMhoiCbVe7UghtQ/x02x7UvodNzmV7f6fI7WhvcO
	0txUaVFA+MNQnVSaVdrdxYWIabZZHsZdu5x+1F4yvFVFH/tD8zNYhuq1x/d6ZlJQxKHLQu4tKKX+5
	BwCpMsiKeNm14dtj97yy48dayCDrPzCHq90BUWXCwlstodf041pgu8aM3dn/gc8b5m9kLyXQknojd
	lCgYWmFqQ6EjPT6Etu9ywpNyaq97PXE83giDAQY9bPEHcxUUqfFyjM93I0Iq3J16FRjRJisge8d9M
	o7aPaUCA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 11/15] swiotlb: pass a gfp_mask argument to swiotlb_init_late
Date: Mon,  4 Apr 2022 07:05:55 +0200
Message-Id: <20220404050559.132378-12-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Let the caller chose a zone to allocate from.  This will be used
later on by the xen-swiotlb initialization on arm.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 arch/x86/pci/sta2x11-fixup.c | 2 +-
 include/linux/swiotlb.h      | 2 +-
 kernel/dma/swiotlb.c         | 7 ++-----
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index e0c039a75b2db..c7e6faf59a861 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_init_late(size))
+		if (swiotlb_init_late(size, GFP_DMA))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index eabdd89987027..ee655f2e4d28b 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -37,7 +37,7 @@ struct scatterlist;
 int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-int swiotlb_init_late(size_t size);
+int swiotlb_init_late(size_t size, gfp_t gfp_mask);
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index f6e091424af3d..119187afc65ec 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -292,7 +292,7 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int swiotlb_init_late(size_t size)
+int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 {
 	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
@@ -303,15 +303,12 @@ int swiotlb_init_late(size_t size)
 	if (swiotlb_force_disable)
 		return 0;
 
-	/*
-	 * Get IO TLB memory from the low pages
-	 */
 	order = get_order(nslabs << IO_TLB_SHIFT);
 	nslabs = SLABS_PER_PAGE << order;
 	bytes = nslabs << IO_TLB_SHIFT;
 
 	while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) {
-		vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN,
+		vstart = (void *)__get_free_pages(gfp_mask | __GFP_NOWARN,
 						  order);
 		if (vstart)
 			break;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:08:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:08:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298144.507871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwm-00009J-38; Mon, 04 Apr 2022 05:08:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298144.507871; Mon, 04 Apr 2022 05:08:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwl-00008i-Q3; Mon, 04 Apr 2022 05:08:11 +0000
Received: by outflank-mailman (input) for mailman id 298144;
 Mon, 04 Apr 2022 05:08:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEva-00021C-U1
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:06:59 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c8a14a7-b3d5-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 07:06:57 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvL-00D99P-6B; Mon, 04 Apr 2022 05:06:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c8a14a7-b3d5-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=EGU3aCYfuGRzuFihFFIzAejLB9aP7qktExZcXOUUDTo=; b=XFJO3BuWIzML2ej6pV6Hs2hG7b
	OujWHZ/mOVmP1h/9y/Eh1WIABps+yWAfmc33sK9GjyYHphJhmyqXkozVxoIiOtJs+sDvXu1oB75f9
	44Y1psRBfRi8yILdJ5N4zaEuXjjeg6dpyo++U8PzAS+r8j5BSXAqscTLVoA28K2s1JFNtNGt/U/yF
	dA5tNoYz6s0XoQDzxGflinXDTlhH1SI1y2yIiMFYSCM8st4bKf4x+/EH1kU8oK0sEwyg/2dtSbZ+E
	d7LQHok0iBenXqiNDSXZ35L+8dKcr4qFb9WiS85lFFkwHVqH30Taio0TBsVBInv17dFjWal5XahKY
	oNOv0IdQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 09/15] swiotlb: make the swiotlb_init interface more useful
Date: Mon,  4 Apr 2022 07:05:53 +0200
Message-Id: <20220404050559.132378-10-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Pass a bool to pass if swiotlb needs to be enabled based on the
addressing needs and replace the verbose argument with a set of
flags, including one to force enable bounce buffering.

Note that this patch removes the possibility to force xen-swiotlb
use using swiotlb=force on the command line on x86 (arm and arm64
never supported that), but this interface will be restored shortly.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm/mm/init.c                     |  6 +----
 arch/arm64/mm/init.c                   |  6 +----
 arch/ia64/mm/init.c                    |  4 +--
 arch/mips/cavium-octeon/dma-octeon.c   |  2 +-
 arch/mips/loongson64/dma.c             |  2 +-
 arch/mips/sibyte/common/dma.c          |  2 +-
 arch/powerpc/mm/mem.c                  |  3 ++-
 arch/powerpc/platforms/pseries/setup.c |  3 ---
 arch/riscv/mm/init.c                   |  8 +-----
 arch/s390/mm/init.c                    |  3 +--
 arch/x86/kernel/pci-dma.c              | 15 ++++++-----
 drivers/xen/swiotlb-xen.c              |  4 +--
 include/linux/swiotlb.h                | 15 ++++++-----
 include/trace/events/swiotlb.h         | 29 ++++++++-------------
 kernel/dma/swiotlb.c                   | 35 ++++++++++++++------------
 15 files changed, 55 insertions(+), 82 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index fe249ea919083..ce64bdb55a16b 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -271,11 +271,7 @@ static void __init free_highpages(void)
 void __init mem_init(void)
 {
 #ifdef CONFIG_ARM_LPAE
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > arm_dma_pfn_limit)
-		swiotlb_init(1);
-	else
-		swiotlb_force = SWIOTLB_NO_FORCE;
+	swiotlb_init(max_pfn > arm_dma_pfn_limit, SWIOTLB_VERBOSE);
 #endif
 
 	set_max_mapnr(pfn_to_page(max_pfn) - mem_map);
diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index 8ac25f19084e8..7b6ea4d6733d6 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -398,11 +398,7 @@ void __init bootmem_init(void)
  */
 void __init mem_init(void)
 {
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > PFN_DOWN(arm64_dma_phys_limit))
-		swiotlb_init(1);
-	else if (!xen_swiotlb_detect())
-		swiotlb_force = SWIOTLB_NO_FORCE;
+	swiotlb_init(max_pfn > PFN_DOWN(arm64_dma_phys_limit), SWIOTLB_VERBOSE);
 
 	/* this will put all unused low memory onto the freelists */
 	memblock_free_all();
diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c
index 5d165607bf354..3c3e15b22608f 100644
--- a/arch/ia64/mm/init.c
+++ b/arch/ia64/mm/init.c
@@ -437,9 +437,7 @@ mem_init (void)
 		if (iommu_detected)
 			break;
 #endif
-#ifdef CONFIG_SWIOTLB
-		swiotlb_init(1);
-#endif
+		swiotlb_init(true, SWIOTLB_VERBOSE);
 	} while (0);
 
 #ifdef CONFIG_FLATMEM
diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c
index fb7547e217263..9fbba6a8fa4c5 100644
--- a/arch/mips/cavium-octeon/dma-octeon.c
+++ b/arch/mips/cavium-octeon/dma-octeon.c
@@ -235,5 +235,5 @@ void __init plat_swiotlb_setup(void)
 #endif
 
 	swiotlb_adjust_size(swiotlbsize);
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/mips/loongson64/dma.c b/arch/mips/loongson64/dma.c
index 364f2f27c8723..8220a1bc0db64 100644
--- a/arch/mips/loongson64/dma.c
+++ b/arch/mips/loongson64/dma.c
@@ -24,5 +24,5 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr)
 
 void __init plat_swiotlb_setup(void)
 {
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/mips/sibyte/common/dma.c b/arch/mips/sibyte/common/dma.c
index eb47a94f3583e..c5c2c782aff68 100644
--- a/arch/mips/sibyte/common/dma.c
+++ b/arch/mips/sibyte/common/dma.c
@@ -10,5 +10,5 @@
 
 void __init plat_swiotlb_setup(void)
 {
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 8e301cd8925b2..e1519e2edc656 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -17,6 +17,7 @@
 #include <linux/suspend.h>
 #include <linux/dma-direct.h>
 
+#include <asm/swiotlb.h>
 #include <asm/machdep.h>
 #include <asm/rtas.h>
 #include <asm/kasan.h>
@@ -251,7 +252,7 @@ void __init mem_init(void)
 	if (is_secure_guest())
 		svm_swiotlb_init();
 	else
-		swiotlb_init(0);
+		swiotlb_init(ppc_swiotlb_enable, 0);
 #endif
 
 	high_memory = (void *) __va(max_low_pfn * PAGE_SIZE);
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index 069d7b3bb142e..c6e06d91b6602 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -838,9 +838,6 @@ static void __init pSeries_setup_arch(void)
 	}
 
 	ppc_md.pcibios_root_bridge_prepare = pseries_root_bridge_prepare;
-
-	if (swiotlb_force == SWIOTLB_FORCE)
-		ppc_swiotlb_enable = 1;
 }
 
 static void pseries_panic(char *str)
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index 9535bea8688c0..181ffd322eafa 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -120,13 +120,7 @@ void __init mem_init(void)
 	BUG_ON(!mem_map);
 #endif /* CONFIG_FLATMEM */
 
-#ifdef CONFIG_SWIOTLB
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > PFN_DOWN(dma32_phys_limit))
-		swiotlb_init(1);
-	else
-		swiotlb_force = SWIOTLB_NO_FORCE;
-#endif
+	swiotlb_init(max_pfn > PFN_DOWN(dma32_phys_limit), SWIOTLB_VERBOSE);
 	memblock_free_all();
 
 	print_vm_layout();
diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
index 86ffd0d51fd59..6fb6bf64326f9 100644
--- a/arch/s390/mm/init.c
+++ b/arch/s390/mm/init.c
@@ -185,8 +185,7 @@ static void pv_init(void)
 		return;
 
 	/* make sure bounce buffers are shared */
-	swiotlb_force = SWIOTLB_FORCE;
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_FORCE | SWIOTLB_VERBOSE);
 	swiotlb_update_mem_attributes();
 }
 
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 04140e20ef1a3..a705a199bf8a3 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -39,6 +39,7 @@ int iommu_detected __read_mostly = 0;
 
 #ifdef CONFIG_SWIOTLB
 bool x86_swiotlb_enable;
+static unsigned int x86_swiotlb_flags;
 
 static void __init pci_swiotlb_detect(void)
 {
@@ -58,16 +59,16 @@ static void __init pci_swiotlb_detect(void)
 	 * bounce buffers as the hypervisor can't access arbitrary VM memory
 	 * that is not explicitly shared with it.
 	 */
-	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
-		swiotlb_force = SWIOTLB_FORCE;
-
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) {
 		x86_swiotlb_enable = true;
+		x86_swiotlb_flags |= SWIOTLB_FORCE;
+	}
 }
 #else
 static inline void __init pci_swiotlb_detect(void)
 {
 }
+#define x86_swiotlb_flags 0
 #endif /* CONFIG_SWIOTLB */
 
 #ifdef CONFIG_SWIOTLB_XEN
@@ -75,8 +76,7 @@ static bool xen_swiotlb;
 
 static void __init pci_xen_swiotlb_init(void)
 {
-	if (!xen_initial_domain() && !x86_swiotlb_enable &&
-	    swiotlb_force != SWIOTLB_FORCE)
+	if (!xen_initial_domain() && !x86_swiotlb_enable)
 		return;
 	x86_swiotlb_enable = true;
 	xen_swiotlb = true;
@@ -120,8 +120,7 @@ void __init pci_iommu_alloc(void)
 	gart_iommu_hole_init();
 	amd_iommu_detect();
 	detect_intel_iommu();
-	if (x86_swiotlb_enable)
-		swiotlb_init(0);
+	swiotlb_init(x86_swiotlb_enable, x86_swiotlb_flags);
 }
 
 /*
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 485cd06ed39e7..c2da3eb4826e8 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -251,7 +251,7 @@ void __init xen_swiotlb_init_early(void)
 		panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
 	}
 
-	if (swiotlb_init_with_tbl(start, nslabs, true))
+	if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE))
 		panic("Cannot allocate SWIOTLB buffer");
 }
 #endif /* CONFIG_X86 */
@@ -376,7 +376,7 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
 	/*
 	 * Oh well, have to allocate and map a bounce buffer.
 	 */
-	trace_swiotlb_bounced(dev, dev_addr, size, swiotlb_force);
+	trace_swiotlb_bounced(dev, dev_addr, size);
 
 	map = swiotlb_tbl_map_single(dev, phys, size, size, 0, dir, attrs);
 	if (map == (phys_addr_t)DMA_MAPPING_ERROR)
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index b48b26bfa0edb..ae0407173e845 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -13,11 +13,8 @@ struct device;
 struct page;
 struct scatterlist;
 
-enum swiotlb_force {
-	SWIOTLB_NORMAL,		/* Default - depending on HW DMA mask etc. */
-	SWIOTLB_FORCE,		/* swiotlb=force */
-	SWIOTLB_NO_FORCE,	/* swiotlb=noforce */
-};
+#define SWIOTLB_VERBOSE	(1 << 0) /* verbose initialization */
+#define SWIOTLB_FORCE	(1 << 1) /* force bounce buffering */
 
 /*
  * Maximum allowable number of contiguous slabs to map,
@@ -36,8 +33,7 @@ enum swiotlb_force {
 /* default to 64MB */
 #define IO_TLB_DEFAULT_SIZE (64UL<<20)
 
-extern void swiotlb_init(int verbose);
-int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
+int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
 int swiotlb_init_late(size_t size);
@@ -126,13 +122,16 @@ static inline bool is_swiotlb_force_bounce(struct device *dev)
 	return mem && mem->force_bounce;
 }
 
+void swiotlb_init(bool addressing_limited, unsigned int flags);
 void __init swiotlb_exit(void);
 unsigned int swiotlb_max_segment(void);
 size_t swiotlb_max_mapping_size(struct device *dev);
 bool is_swiotlb_active(struct device *dev);
 void __init swiotlb_adjust_size(unsigned long size);
 #else
-#define swiotlb_force SWIOTLB_NO_FORCE
+static inline void swiotlb_init(bool addressing_limited, unsigned int flags)
+{
+}
 static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr)
 {
 	return false;
diff --git a/include/trace/events/swiotlb.h b/include/trace/events/swiotlb.h
index 705be43b71ab0..da05c9ebd224a 100644
--- a/include/trace/events/swiotlb.h
+++ b/include/trace/events/swiotlb.h
@@ -8,20 +8,15 @@
 #include <linux/tracepoint.h>
 
 TRACE_EVENT(swiotlb_bounced,
-
-	TP_PROTO(struct device *dev,
-		 dma_addr_t dev_addr,
-		 size_t size,
-		 enum swiotlb_force swiotlb_force),
-
-	TP_ARGS(dev, dev_addr, size, swiotlb_force),
+	TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size),
+	TP_ARGS(dev, dev_addr, size),
 
 	TP_STRUCT__entry(
-		__string(	dev_name,	dev_name(dev)		)
-		__field(	u64,	dma_mask			)
-		__field(	dma_addr_t,	dev_addr		)
-		__field(	size_t,	size				)
-		__field(	enum swiotlb_force,	swiotlb_force	)
+		__string(dev_name, dev_name(dev))
+		__field(u64, dma_mask)
+		__field(dma_addr_t, dev_addr)
+		__field(size_t, size)
+		__field(bool, force)
 	),
 
 	TP_fast_assign(
@@ -29,19 +24,15 @@ TRACE_EVENT(swiotlb_bounced,
 		__entry->dma_mask = (dev->dma_mask ? *dev->dma_mask : 0);
 		__entry->dev_addr = dev_addr;
 		__entry->size = size;
-		__entry->swiotlb_force = swiotlb_force;
+		__entry->force = is_swiotlb_force_bounce(dev);
 	),
 
-	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx "
-		"size=%zu %s",
+	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx size=%zu %s",
 		__get_str(dev_name),
 		__entry->dma_mask,
 		(unsigned long long)__entry->dev_addr,
 		__entry->size,
-		__print_symbolic(__entry->swiotlb_force,
-			{ SWIOTLB_NORMAL,	"NORMAL" },
-			{ SWIOTLB_FORCE,	"FORCE" },
-			{ SWIOTLB_NO_FORCE,	"NO_FORCE" }))
+		__entry->force ? "FORCE" : "NORMAL")
 );
 
 #endif /*  _TRACE_SWIOTLB_H */
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 9a4fe6e48a074..86e877a96b828 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -62,7 +62,8 @@
 
 #define INVALID_PHYS_ADDR (~(phys_addr_t)0)
 
-enum swiotlb_force swiotlb_force;
+static bool swiotlb_force_bounce;
+static bool swiotlb_force_disable;
 
 struct io_tlb_mem io_tlb_default_mem;
 
@@ -81,9 +82,9 @@ setup_io_tlb_npages(char *str)
 	if (*str == ',')
 		++str;
 	if (!strcmp(str, "force"))
-		swiotlb_force = SWIOTLB_FORCE;
+		swiotlb_force_bounce = true;
 	else if (!strcmp(str, "noforce"))
-		swiotlb_force = SWIOTLB_NO_FORCE;
+		swiotlb_force_disable = true;
 
 	return 0;
 }
@@ -202,7 +203,7 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	mem->index = 0;
 	mem->late_alloc = late_alloc;
 
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (swiotlb_force_bounce)
 		mem->force_bounce = true;
 
 	spin_lock_init(&mem->lock);
@@ -224,12 +225,13 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	return;
 }
 
-int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
+int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
+		unsigned int flags)
 {
 	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	size_t alloc_size;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/* protect against double initialization */
@@ -243,8 +245,9 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
 		      __func__, alloc_size, PAGE_SIZE);
 
 	swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
+	mem->force_bounce = flags & SWIOTLB_FORCE;
 
-	if (verbose)
+	if (flags & SWIOTLB_VERBOSE)
 		swiotlb_print_info();
 	return 0;
 }
@@ -253,20 +256,21 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
  * Statically reserve bounce buffer space and initialize bounce buffer data
  * structures for the software IO TLB used to implement the DMA API.
  */
-void  __init
-swiotlb_init(int verbose)
+void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 {
 	size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
 	void *tlb;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (!addressing_limit && !swiotlb_force_bounce)
+		return;
+	if (swiotlb_force_disable)
 		return;
 
 	/* Get IO TLB memory from the low pages */
 	tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
 		goto fail;
-	if (swiotlb_init_with_tbl(tlb, default_nslabs, verbose))
+	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
 		goto fail_free_mem;
 	return;
 
@@ -289,7 +293,7 @@ int swiotlb_init_late(size_t size)
 	unsigned int order;
 	int rc = 0;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/*
@@ -328,7 +332,7 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
 	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	unsigned long bytes = nslabs << IO_TLB_SHIFT;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/* protect against double initialization */
@@ -353,7 +357,7 @@ void __init swiotlb_exit(void)
 	unsigned long tbl_vaddr;
 	size_t tbl_size, slots_size;
 
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (swiotlb_force_bounce)
 		return;
 
 	if (!mem->nslabs)
@@ -704,8 +708,7 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t paddr, size_t size,
 	phys_addr_t swiotlb_addr;
 	dma_addr_t dma_addr;
 
-	trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size,
-			      swiotlb_force);
+	trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size);
 
 	swiotlb_addr = swiotlb_tbl_map_single(dev, paddr, size, size, 0, dir,
 			attrs);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:08:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:08:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298145.507877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwm-0000Je-Nu; Mon, 04 Apr 2022 05:08:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298145.507877; Mon, 04 Apr 2022 05:08:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbEwm-0000Fm-DD; Mon, 04 Apr 2022 05:08:12 +0000
Received: by outflank-mailman (input) for mailman id 298145;
 Mon, 04 Apr 2022 05:08:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yBc+=UO=bombadil.srs.infradead.org=BATV+8f3f264ef3f87e17849e+6798+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbEvt-000216-3Y
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 05:07:17 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 179d5319-b3d5-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 07:07:16 +0200 (CEST)
Received: from 089144211060.atnat0020.highway.a1.net ([89.144.211.60]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbEvZ-00D9Og-RL; Mon, 04 Apr 2022 05:06:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 179d5319-b3d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=vyC3o/8FOMoNs5PhOSLpMqWVlr8Ccnt9Kkscfc4Zyug=; b=ArsNOMOLXYFyJeTBkicZmZyYZF
	nqnXKp8lN6TwwruT1N+rxy/my+Acx8XRzcrrZukE5OuKC3OihTlAdjBwKhLM0hjaMBaWYdtkb8ESm
	Sg2R8btxcfYoAHJmgyRUWmfV/V3TiQMmdxgb1Qa2qhxFp+1+r0i1S6N/a8Wg1ZVY+re/34/aflvbL
	XpkSk1p4yE37C0oNMmhM2GB3WBOyb7w5HbKbzItUduHUcN0nVFMYXVHVE/vwaVlhB6v+8KY2t2RIU
	QhIimcOMjWPrv38RM0o3s/Ka/lVbXCbXdB6XP2g4K4GxdRbv8Z45vc9ao+h7xbO3d5Tx3XXo/BFBj
	p65wEQ2Q==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 13/15] swiotlb: merge swiotlb-xen initialization into swiotlb
Date: Mon,  4 Apr 2022 07:05:57 +0200
Message-Id: <20220404050559.132378-14-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Reuse the generic swiotlb initialization for xen-swiotlb.  For ARM/ARM64
this works trivially, while for x86 xen_swiotlb_fixup needs to be passed
as the remap argument to swiotlb_init_remap/swiotlb_init_late.

Note that the lower bound of the swiotlb size is changed to the smaller
IO_TLB_MIN_SLABS based value with this patch, but that is fine as the
2MB value used in Xen before was just an optimization and is not the
hard lower bound.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
 arch/arm/xen/mm.c               |  21 +++---
 arch/x86/include/asm/xen/page.h |   5 --
 arch/x86/kernel/pci-dma.c       |  20 ++---
 drivers/xen/swiotlb-xen.c       | 128 +-------------------------------
 include/xen/arm/page.h          |   1 -
 include/xen/swiotlb-xen.h       |   8 +-
 6 files changed, 28 insertions(+), 155 deletions(-)

diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
index 28c2070602535..ff05a7899cb86 100644
--- a/arch/arm/xen/mm.c
+++ b/arch/arm/xen/mm.c
@@ -23,22 +23,20 @@
 #include <asm/xen/hypercall.h>
 #include <asm/xen/interface.h>
 
-unsigned long xen_get_swiotlb_free_pages(unsigned int order)
+static gfp_t xen_swiotlb_gfp(void)
 {
 	phys_addr_t base;
-	gfp_t flags = __GFP_NOWARN|__GFP_KSWAPD_RECLAIM;
 	u64 i;
 
 	for_each_mem_range(i, &base, NULL) {
 		if (base < (phys_addr_t)0xffffffff) {
 			if (IS_ENABLED(CONFIG_ZONE_DMA32))
-				flags |= __GFP_DMA32;
-			else
-				flags |= __GFP_DMA;
-			break;
+				return __GFP_DMA32;
+			return __GFP_DMA;
 		}
 	}
-	return __get_free_pages(flags, order);
+
+	return GFP_KERNEL;
 }
 
 static bool hypercall_cflush = false;
@@ -140,10 +138,13 @@ static int __init xen_mm_init(void)
 	if (!xen_swiotlb_detect())
 		return 0;
 
-	rc = xen_swiotlb_init();
 	/* we can work with the default swiotlb */
-	if (rc < 0 && rc != -EEXIST)
-		return rc;
+	if (!io_tlb_default_mem.nslabs) {
+		rc = swiotlb_init_late(swiotlb_size_or_default(),
+				       xen_swiotlb_gfp(), NULL);
+		if (rc < 0)
+			return rc;
+	}
 
 	cflush.op = 0;
 	cflush.a.dev_bus_addr = 0;
diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h
index e989bc2269f54..1fc67df500145 100644
--- a/arch/x86/include/asm/xen/page.h
+++ b/arch/x86/include/asm/xen/page.h
@@ -357,9 +357,4 @@ static inline bool xen_arch_need_swiotlb(struct device *dev,
 	return false;
 }
 
-static inline unsigned long xen_get_swiotlb_free_pages(unsigned int order)
-{
-	return __get_free_pages(__GFP_NOWARN, order);
-}
-
 #endif /* _ASM_X86_XEN_PAGE_H */
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index a705a199bf8a3..30bbe4abb5d61 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -72,15 +72,13 @@ static inline void __init pci_swiotlb_detect(void)
 #endif /* CONFIG_SWIOTLB */
 
 #ifdef CONFIG_SWIOTLB_XEN
-static bool xen_swiotlb;
-
 static void __init pci_xen_swiotlb_init(void)
 {
 	if (!xen_initial_domain() && !x86_swiotlb_enable)
 		return;
 	x86_swiotlb_enable = true;
-	xen_swiotlb = true;
-	xen_swiotlb_init_early();
+	x86_swiotlb_flags |= SWIOTLB_ANY;
+	swiotlb_init_remap(true, x86_swiotlb_flags, xen_swiotlb_fixup);
 	dma_ops = &xen_swiotlb_dma_ops;
 	if (IS_ENABLED(CONFIG_PCI))
 		pci_request_acs();
@@ -88,14 +86,16 @@ static void __init pci_xen_swiotlb_init(void)
 
 int pci_xen_swiotlb_init_late(void)
 {
-	int rc;
-
-	if (xen_swiotlb)
+	if (dma_ops == &xen_swiotlb_dma_ops)
 		return 0;
 
-	rc = xen_swiotlb_init();
-	if (rc)
-		return rc;
+	/* we can work with the default swiotlb */
+	if (!io_tlb_default_mem.nslabs) {
+		int rc = swiotlb_init_late(swiotlb_size_or_default(),
+					   GFP_KERNEL, xen_swiotlb_fixup);
+		if (rc < 0)
+			return rc;
+	}
 
 	/* XXX: this switches the dma ops under live devices! */
 	dma_ops = &xen_swiotlb_dma_ops;
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index c2da3eb4826e8..df8085b50df10 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -104,7 +104,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr)
 	return 0;
 }
 
-static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
+int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 {
 	int rc;
 	unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT);
@@ -130,132 +130,6 @@ static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 	return 0;
 }
 
-enum xen_swiotlb_err {
-	XEN_SWIOTLB_UNKNOWN = 0,
-	XEN_SWIOTLB_ENOMEM,
-	XEN_SWIOTLB_EFIXUP
-};
-
-static const char *xen_swiotlb_error(enum xen_swiotlb_err err)
-{
-	switch (err) {
-	case XEN_SWIOTLB_ENOMEM:
-		return "Cannot allocate Xen-SWIOTLB buffer\n";
-	case XEN_SWIOTLB_EFIXUP:
-		return "Failed to get contiguous memory for DMA from Xen!\n"\
-		    "You either: don't have the permissions, do not have"\
-		    " enough free memory under 4GB, or the hypervisor memory"\
-		    " is too fragmented!";
-	default:
-		break;
-	}
-	return "";
-}
-
-int xen_swiotlb_init(void)
-{
-	enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN;
-	unsigned long bytes = swiotlb_size_or_default();
-	unsigned long nslabs = bytes >> IO_TLB_SHIFT;
-	unsigned int order, repeat = 3;
-	int rc = -ENOMEM;
-	char *start;
-
-	if (io_tlb_default_mem.nslabs) {
-		pr_warn("swiotlb buffer already initialized\n");
-		return -EEXIST;
-	}
-
-retry:
-	m_ret = XEN_SWIOTLB_ENOMEM;
-	order = get_order(bytes);
-
-	/*
-	 * Get IO TLB memory from any location.
-	 */
-#define SLABS_PER_PAGE (1 << (PAGE_SHIFT - IO_TLB_SHIFT))
-#define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT)
-	while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) {
-		start = (void *)xen_get_swiotlb_free_pages(order);
-		if (start)
-			break;
-		order--;
-	}
-	if (!start)
-		goto exit;
-	if (order != get_order(bytes)) {
-		pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n",
-			(PAGE_SIZE << order) >> 20);
-		nslabs = SLABS_PER_PAGE << order;
-		bytes = nslabs << IO_TLB_SHIFT;
-	}
-
-	/*
-	 * And replace that memory with pages under 4GB.
-	 */
-	rc = xen_swiotlb_fixup(start, nslabs);
-	if (rc) {
-		free_pages((unsigned long)start, order);
-		m_ret = XEN_SWIOTLB_EFIXUP;
-		goto error;
-	}
-	rc = swiotlb_late_init_with_tbl(start, nslabs);
-	if (rc)
-		return rc;
-	return 0;
-error:
-	if (nslabs > 1024 && repeat--) {
-		/* Min is 2MB */
-		nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
-		bytes = nslabs << IO_TLB_SHIFT;
-		pr_info("Lowering to %luMB\n", bytes >> 20);
-		goto retry;
-	}
-exit:
-	pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc);
-	return rc;
-}
-
-#ifdef CONFIG_X86
-void __init xen_swiotlb_init_early(void)
-{
-	unsigned long bytes = swiotlb_size_or_default();
-	unsigned long nslabs = bytes >> IO_TLB_SHIFT;
-	unsigned int repeat = 3;
-	char *start;
-	int rc;
-
-retry:
-	/*
-	 * Get IO TLB memory from any location.
-	 */
-	start = memblock_alloc(PAGE_ALIGN(bytes),
-			       IO_TLB_SEGSIZE << IO_TLB_SHIFT);
-	if (!start)
-		panic("%s: Failed to allocate %lu bytes\n",
-		      __func__, PAGE_ALIGN(bytes));
-
-	/*
-	 * And replace that memory with pages under 4GB.
-	 */
-	rc = xen_swiotlb_fixup(start, nslabs);
-	if (rc) {
-		memblock_free(start, PAGE_ALIGN(bytes));
-		if (nslabs > 1024 && repeat--) {
-			/* Min is 2MB */
-			nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
-			bytes = nslabs << IO_TLB_SHIFT;
-			pr_info("Lowering to %luMB\n", bytes >> 20);
-			goto retry;
-		}
-		panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
-	}
-
-	if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE))
-		panic("Cannot allocate SWIOTLB buffer");
-}
-#endif /* CONFIG_X86 */
-
 static void *
 xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 			   dma_addr_t *dma_handle, gfp_t flags,
diff --git a/include/xen/arm/page.h b/include/xen/arm/page.h
index ac1b654705631..7e199c6656b90 100644
--- a/include/xen/arm/page.h
+++ b/include/xen/arm/page.h
@@ -115,6 +115,5 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
 bool xen_arch_need_swiotlb(struct device *dev,
 			   phys_addr_t phys,
 			   dma_addr_t dev_addr);
-unsigned long xen_get_swiotlb_free_pages(unsigned int order);
 
 #endif /* _ASM_ARM_XEN_PAGE_H */
diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h
index b3e647f86e3e2..590ceb923f0c8 100644
--- a/include/xen/swiotlb-xen.h
+++ b/include/xen/swiotlb-xen.h
@@ -10,8 +10,12 @@ void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t handle,
 void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle,
 			     size_t size, enum dma_data_direction dir);
 
-int xen_swiotlb_init(void);
-void __init xen_swiotlb_init_early(void);
+#ifdef CONFIG_SWIOTLB_XEN
+int xen_swiotlb_fixup(void *buf, unsigned long nslabs);
+#else
+#define xen_swiotlb_fixup NULL
+#endif
+
 extern const struct dma_map_ops xen_swiotlb_dma_ops;
 
 #endif /* __LINUX_SWIOTLB_XEN_H */
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 05:54:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 05:54:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298179.507902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbFfW-0007iH-PN; Mon, 04 Apr 2022 05:54:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298179.507902; Mon, 04 Apr 2022 05:54:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbFfW-0007iA-MK; Mon, 04 Apr 2022 05:54:26 +0000
Received: by outflank-mailman (input) for mailman id 298179;
 Mon, 04 Apr 2022 05:54:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbFfV-0007i0-G0; Mon, 04 Apr 2022 05:54:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbFfV-0007BG-EC; Mon, 04 Apr 2022 05:54:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbFfU-0007Uy-SP; Mon, 04 Apr 2022 05:54:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbFfU-0007w2-Ro; Mon, 04 Apr 2022 05:54:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oyw5RsLgOfsSHbEx7DGSjL2368t43pKX8ndreJM+ShQ=; b=JWvWhiAbZFFav5CdxonYc4UPIy
	cdSm5rnPsJsC66bhVGQwPjnCaMALYRKB51SVhJLJc7ADOtvAybSjSQVD/6hbzOpQyotiQ5tMd5OMI
	2r/uEWXKn/XRK0Zr5pXwLNRorfha34RskpDocJ9wnbTfnf+Nqa41yc4CiF/GKp9sErT4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169153-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169153: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=3e130e40fc55f06f7fe019e87ed9bae957870a12
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 05:54:24 +0000

flight 169153 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169153/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 3e130e40fc55f06f7fe019e87ed9bae957870a12
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   34 days
Failing since        168258  2022-03-01 01:55:31 Z   34 days  274 attempts
Testing same since   169141  2022-04-03 08:40:51 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3211 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 06:20:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 06:20:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298187.507913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbG4O-0002Ym-UF; Mon, 04 Apr 2022 06:20:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298187.507913; Mon, 04 Apr 2022 06:20:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbG4O-0002Yf-Pq; Mon, 04 Apr 2022 06:20:08 +0000
Received: by outflank-mailman (input) for mailman id 298187;
 Mon, 04 Apr 2022 06:20:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbG4N-0002YV-GA; Mon, 04 Apr 2022 06:20:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbG4N-0007i9-DT; Mon, 04 Apr 2022 06:20:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbG4M-0000Dh-SG; Mon, 04 Apr 2022 06:20:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbG4M-0007h6-Rp; Mon, 04 Apr 2022 06:20:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WcGhVWurorsem1HAkpE2j2e3ngm7i/SRcWlZ9bIKXJ4=; b=zrscvF5JgZOeojUU5lIVjv25Qs
	jP4pJFoi9NG1Du8dfYQH81hjENBbDEBP5QhTKO/D0pYITzulohyXG9cF1p8KeipjfLrawqUHEgf6o
	jMNJMKEQYVIK2fsd2ILvkvMKlWtEqaq6SwicqnkxfrAJM91dHgsDyZjaGgvSED/V3ZvA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169145-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169145: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04
X-Osstest-Versions-That:
    linux=be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 06:20:06 +0000

flight 169145 linux-linus real [real]
flight 169155 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169145/
http://logs.test-lab.xenproject.org/osstest/logs/169155/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw 12 debian-di-install   fail pass in 169155-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169134

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 169155 like 169134
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 169155 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169134
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169134
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169134
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169134
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169134
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169134
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169134
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04
baseline version:
 linux                be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf

Last test of basis   169134  2022-04-02 20:17:55 Z    1 days
Testing same since   169145  2022-04-03 20:41:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
  Austin Kim <austindh.kim@gmail.com>
  Beau Belgrave <beaub@linux.microsoft.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Chang S. Bae <chang.seok.bae@intel.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Ingo Molnar <mingo@kernel.org>
  Joerg Roedel <jroedel@suse.de>
  Lin Yujun <linyujun809@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  linyujun <linyujun809@huawei.com>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Masahiro Yamada <masahiroy@kernel.org>
  Masami Hiramatsu <mhiramat@kernel.org>
  Nathan Chancellor <nathan@kernel.org>
  Randy Dunlap <rdunlap@infradead.org>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Stephen Boyd <sboyd@kernel.org>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Thomas Gleixner <tglx@linutronix.de>
  Yang Zhong <yang.zhong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   be2d3ecedd99..09bb8856d4a7  09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 06:21:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 06:21:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298194.507924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbG5g-000381-AX; Mon, 04 Apr 2022 06:21:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298194.507924; Mon, 04 Apr 2022 06:21:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbG5g-00037u-5t; Mon, 04 Apr 2022 06:21:28 +0000
Received: by outflank-mailman (input) for mailman id 298194;
 Mon, 04 Apr 2022 06:21:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Mpu=UO=fujitsu.com=Alan.Robinson@srs-se1.protection.inumbo.net>)
 id 1nbG5e-00037o-Iq
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 06:21:26 +0000
Received: from mail1.bemta36.messagelabs.com (mail1.bemta36.messagelabs.com
 [85.158.142.1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 73b71dbc-b3df-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 08:21:24 +0200 (CEST)
Received: (qmail 8161 invoked from network); 4 Apr 2022 06:21:18 -0000
Received: from unknown (HELO mailhost1.uk.fujitsu.com) (62.60.8.148)
 by server-7.tower-528.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384
 encrypted SMTP; 4 Apr 2022 06:21:18 -0000
Received: from nera.osd.abg.fsc.net ([172.17.20.8])
 by mailhost1.uk.fujitsu.com (8.14.5/8.14.5) with SMTP id 2346Jn5d030109;
 Mon, 4 Apr 2022 07:19:56 +0100
Received: by nera.osd.abg.fsc.net (Postfix, from userid 5004)
 id 1A288174782; Mon,  4 Apr 2022 08:19:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73b71dbc-b3df-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.com;
	s=170520fj; t=1649053283; i=@fujitsu.com;
	bh=b7vEbVpHlcau47iLeXRDHN/idN8gpdHUoNjZroKIPeE=;
	h=Date:To:Cc:Subject:Message-ID:Reply-To:References:MIME-Version:
	 Content-Type:In-Reply-To:From;
	b=AaIuI+NVYBx0pSQjblOU1uOigYvSV6YRIjvJ66Vklj/Ejksf411E887/O2drI5l/Q
	 SMZMyGyRF3qkUYgkKGzVhdiGqL6Y/4WVKwpoWtiERltD5l8WYanb/1W7nTf+htR9q8
	 l2EKb9PC/E+uGcX7wgAryjzycCyybMmwdSUFjfIhXXYAdynlS9JHmetNa0asK32Xrg
	 CzUwHoWPlEjCwUVCaNdh+7KtcfEUi22V9juMg/QzN/L4tqYWqo3mvmyOxYa24UdcW+
	 luiOexRQlX/nLZV54FX47w9lftfJhmpUZl9KG6PxCLwmYxMKGrKoyc41A6F2kykIZn
	 7fjn8hi79IEIQ==
Authentication-Results: mx.messagelabs.com; spf=pass 
  (server-7.tower-528.messagelabs.com: domain of fujitsu.com designates 
  85.158.142.210 as permitted sender) smtp.mailfrom=fujitsu.com; dkim=none 
  (message not signed); dmarc=pass (p=none sp=none adkim=r aspf=r) 
  header.from=fujitsu.com
X-Brightmail-Tracker: H4sIAAAAAAAAA1WSbUxTVxiAe257LxdCyW3RcajotNsSRmzXEpW
  zuC3G8OMOCWN/EMVYb+mF1rUVe9sJYgIbEKRbCRWIirPUiTo+Vmv50AzHJojCBjIJne2Myxxl
  UeYYk2y4NJD10vixf0/Oc97n/fOSQuknhIxkS62sxcwY5USc6J23yCbF3vosrWo5tBaNjHyKo
  YGRQtTt7CXQ7eM1IuRsbxSi9s5hDLm/2Yo+C6ajulPeGHT+7AxAvukfcdTsnCfQ/NE5HNX5eg
  Ead90kUN9CNYEazlQJUXhxGUfX5kM46vRo0KXHUzHoetMAjp54p3G02NOIbYN06JoLo2smlwi
  6y9UFaO/Hjwi6+4s02tdRR9Cu0ffp7rYKujFwAdATJ84Aut+9gNFD81Miuj9YSdB/zfwkoi/2
  +EX0gm9dLrUbN5i1B0r34Xr3nZ+JkqNppfbrf+OVYFFuB7GklDoNYLU/L8o2+MjrAjyLqFfh5
  c6eGJ5XUXI4MzseeY8jhVRHHGweDa+IRCofBm56VlhMpcOq/n5hNPQKPO1fIvgBMfUgFrYufY
  5HRTk89q1DFB2QwNGToRUWUmkwsPwQswMywmvghWWSx1gqD95reJ3/AakUGG5fJHheHcl7zo4
  C/gtBvQFnHUwDkLS80Gx5odnyvOkGwg7wttZiKNZbTYzBqFCrVAq1erNiC1Kkb1IyhxWMkrUp
  Clmz1cJErJI5xClZjlNyZaZCo05pZq0+ELkRHZcJr4Bg/b/KQZBMYvLV4j/sWVppgvaArkzPc
  HqNxWZkuUGQQpJyKG7jncTCFrOlRQZj5NKeakjGy1eJW3kt5koYE2cojqrvwAZZkniHIyIoXu
  ht5mdjT290EqyVJYqBQCCQxpewFpPB+n8/C5JIIE8U5/KVeIPZ+qw+G1mMRRbPjb3LL7Yyz5W
  sEkt4kFTrDmz9faL4cUCyfeK34Jrd/2wPLH/0/f4m77r8sZmFiUF714mpQ84M4j4orKYU3S9X
  iHuTaXpYec7l8idU3G7csGtb3VjRr3szN+l7Lw4Jb5FW55uJKeE+TJh8f1AjzXDiBXez5/w3i
  jyck9iSNzTu+eWOJ2xzbRZNk+vBDt1Jx0PBLnT40kaYXTZ2RV5/1ZSbX6WkajQ7v5y8d3dn7d
  c/pNrOfTA8EH98/RHW7ZUVtanKUzuCexw5Bbmqfc6Y2oOprW6g3fNS8/msrwSqI9kaRagr872
  rt1I+LLgheaIr65NnqC5vXDKfOrZfTcqGg76c1/6sDmXlHCyXDclFnJ5RpwktHPMfZBBxiR4E
  AAA=
X-Env-Sender: Alan.Robinson@fujitsu.com
X-Msg-Ref: server-7.tower-528.messagelabs.com!1649053277!135886!1
X-Originating-IP: [62.60.8.148]
X-SYMC-ESS-Client-Auth: outbound-route-from=pass
X-StarScan-Received:
X-StarScan-Version: 9.85.5; banners=-,-,-
X-VirusChecked: Checked
Date: Mon, 4 Apr 2022 08:19:46 +0200
To: Christoph Hellwig <hch@lst.de>
Cc: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "tboot-devel@lists.sourceforge.net" <tboot-devel@lists.sourceforge.net>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 12/15] swiotlb: provide swiotlb_init variants that remap
 the buffer
Message-ID: <20220404061946.GA1905@ts.fujitsu.com>
Reply-To: Alan.Robinson@fujitsu.com
Mail-Followup-To: Alan.Robinson@fujitsu.com, Christoph Hellwig <hch@lst.de>,
	"iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
	"x86@kernel.org" <x86@kernel.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"tboot-devel@lists.sourceforge.net" <tboot-devel@lists.sourceforge.net>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
References: <20220404050559.132378-1-hch@lst.de>
 <67c1784af6f24f3e871ddfb1478e821c@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <67c1784af6f24f3e871ddfb1478e821c@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM>
X-sent-by-me: robin@sanpedro
User-Agent: Mutt/1.9.3 (2018-01-21)
From: Alan.Robinson@fujitsu.com (Alan Robinson)

Hi Christoph,

On Mon, Apr 04, 2022 at 05:05:56AM +0000, Christoph Hellwig wrote:
> From: Christoph Hellwig <hch@lst.de>
> Subject: [PATCH 12/15] swiotlb: provide swiotlb_init variants that remap
>  the buffer
> 
> To shared more code between swiotlb and xen-swiotlb, offer a
> swiotlb_init_remap interface and add a remap callback to
> swiotlb_init_late that will allow Xen to remap the buffer the

s/the buffer//

> buffer without duplicating much of the logic.

Alan

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/x86/pci/sta2x11-fixup.c |  2 +-
>  include/linux/swiotlb.h      |  5 ++++-
>  kernel/dma/swiotlb.c         | 36 +++++++++++++++++++++++++++++++++---
>  3 files changed, 38 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
> index c7e6faf59a861..7368afc039987 100644
> --- a/arch/x86/pci/sta2x11-fixup.c
> +++ b/arch/x86/pci/sta2x11-fixup.c
> @@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
>  		int size = STA2X11_SWIOTLB_SIZE;
>  		/* First instance: register your own swiotlb area */
>  		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
> -		if (swiotlb_init_late(size, GFP_DMA))
> +		if (swiotlb_init_late(size, GFP_DMA, NULL))
>  			dev_emerg(&pdev->dev, "init swiotlb failed\n");
>  	}
>  	list_add(&instance->list, &sta2x11_instance_list);
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index ee655f2e4d28b..7b50c82f84ce9 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -36,8 +36,11 @@ struct scatterlist;
>  
>  int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
>  unsigned long swiotlb_size_or_default(void);
> +void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
> +	int (*remap)(void *tlb, unsigned long nslabs));
> +int swiotlb_init_late(size_t size, gfp_t gfp_mask,
> +	int (*remap)(void *tlb, unsigned long nslabs));
>  extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
> -int swiotlb_init_late(size_t size, gfp_t gfp_mask);
>  extern void __init swiotlb_update_mem_attributes(void);
>  
>  phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 119187afc65ec..d5fe8f5e08300 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -256,9 +256,11 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
>   * Statically reserve bounce buffer space and initialize bounce buffer data
>   * structures for the software IO TLB used to implement the DMA API.
>   */
> -void __init swiotlb_init(bool addressing_limit, unsigned int flags)
> +void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
> +		int (*remap)(void *tlb, unsigned long nslabs))
>  {
> -	size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
> +	unsigned long nslabs = default_nslabs;
> +	size_t bytes;
>  	void *tlb;
>  
>  	if (!addressing_limit && !swiotlb_force_bounce)
> @@ -271,12 +273,23 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
>  	 * allow to pick a location everywhere for hypervisors with guest
>  	 * memory encryption.
>  	 */
> +retry:
> +	bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
>  	if (flags & SWIOTLB_ANY)
>  		tlb = memblock_alloc(bytes, PAGE_SIZE);
>  	else
>  		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
>  	if (!tlb)
>  		goto fail;
> +	if (remap && remap(tlb, nslabs) < 0) {
> +		memblock_free(tlb, PAGE_ALIGN(bytes));
> +
> +		nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE);
> +		if (nslabs < IO_TLB_MIN_SLABS)
> +			panic("%s: Failed to remap %zu bytes\n",
> +			      __func__, bytes);
> +		goto retry;
> +	}
>  	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
>  		goto fail_free_mem;
>  	return;
> @@ -287,12 +300,18 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
>  	pr_warn("Cannot allocate buffer");
>  }
>  
> +void __init swiotlb_init(bool addressing_limit, unsigned int flags)
> +{
> +	return swiotlb_init_remap(addressing_limit, flags, NULL);
> +}
> +
>  /*
>   * Systems with larger DMA zones (those that don't support ISA) can
>   * initialize the swiotlb later using the slab allocator if needed.
>   * This should be just like above, but with some error catching.
>   */
> -int swiotlb_init_late(size_t size, gfp_t gfp_mask)
> +int swiotlb_init_late(size_t size, gfp_t gfp_mask,
> +		int (*remap)(void *tlb, unsigned long nslabs))
>  {
>  	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
>  	unsigned long bytes;
> @@ -303,6 +322,7 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
>  	if (swiotlb_force_disable)
>  		return 0;
>  
> +retry:
>  	order = get_order(nslabs << IO_TLB_SHIFT);
>  	nslabs = SLABS_PER_PAGE << order;
>  	bytes = nslabs << IO_TLB_SHIFT;
> @@ -323,6 +343,16 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
>  			(PAGE_SIZE << order) >> 20);
>  		nslabs = SLABS_PER_PAGE << order;
>  	}
> +	if (remap)
> +		rc = remap(vstart, nslabs);
> +	if (rc) {
> +		free_pages((unsigned long)vstart, order);
> + 
> +		nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE);
> +		if (nslabs < IO_TLB_MIN_SLABS)
> +			return rc;
> +		goto retry;
> +	}
>  	rc = swiotlb_late_init_with_tbl(vstart, nslabs);
>  	if (rc)
>  		free_pages((unsigned long)vstart, order);
> -- 
> 2.30.2
> 


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 06:59:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 06:59:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298201.507935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbGgJ-0006f6-4h; Mon, 04 Apr 2022 06:59:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298201.507935; Mon, 04 Apr 2022 06:59:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbGgJ-0006ez-1T; Mon, 04 Apr 2022 06:59:19 +0000
Received: by outflank-mailman (input) for mailman id 298201;
 Mon, 04 Apr 2022 06:59:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbGgI-0006ep-Dj; Mon, 04 Apr 2022 06:59:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbGgI-0008Np-AJ; Mon, 04 Apr 2022 06:59:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbGgH-0003Fg-O6; Mon, 04 Apr 2022 06:59:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbGgH-00033F-Ne; Mon, 04 Apr 2022 06:59:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zyjrP9RW1ui28iGxD27AxOwueWZQDdtPqVmEEORjyx4=; b=DyLLt+MPd2edJcxKkte8zsNEqh
	Co9esD05lSEpLFtxJ41VVyFwdIi0dTU7gk+6PHfP5y+Q5y1iSKsGHPSkBBequQrM8yztPSlGVndwD
	7vLgD1yWqJiOn30XS6hk9H60YiGUxlDXLFiTJ2FAMq+iUXnEq4HXC0bHv7f0GKydcdPo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169147-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169147: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
X-Osstest-Versions-That:
    xen=ca304edd3ba8c19211107fd2e898249987557ce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 06:59:17 +0000

flight 169147 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169147/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168506
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168506

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw 12 debian-di-install          fail pass in 169140

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 169140 like 168506
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 169140 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168506
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
baseline version:
 xen                  ca304edd3ba8c19211107fd2e898249987557ce5

Last test of basis   168506  2022-03-10 14:16:31 Z   24 days
Failing since        168862  2022-03-25 17:36:39 Z    9 days   12 attempts
Testing same since   168957  2022-03-28 21:36:20 Z    6 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 07:10:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 07:10:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298209.507946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbGql-0000VX-5H; Mon, 04 Apr 2022 07:10:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298209.507946; Mon, 04 Apr 2022 07:10:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbGql-0000VQ-2F; Mon, 04 Apr 2022 07:10:07 +0000
Received: by outflank-mailman (input) for mailman id 298209;
 Mon, 04 Apr 2022 07:10:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zDsC=UO=oracle.com=dongli.zhang@srs-se1.protection.inumbo.net>)
 id 1nbGqi-00006R-9d
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 07:10:06 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e42445d-b3e6-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 09:10:01 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2341piQn020990; 
 Mon, 4 Apr 2022 07:09:14 GMT
Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta01.appoci.oracle.com [138.1.114.2])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d92t95d-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 04 Apr 2022 07:09:13 +0000
Received: from pps.filterd
 (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23470ITt031697; Mon, 4 Apr 2022 07:09:12 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f6cx1x32k-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 04 Apr 2022 07:09:12 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 07:09:10 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::6c4e:65d8:4e2d:d942]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::6c4e:65d8:4e2d:d942%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 07:09:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e42445d-b3e6-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=cfVaDeBc+xYAEJUW1i4rR6c2Eono9lckX0H6AxfZXuo=;
 b=wyJNA4OUMYbbD5pyPny9T8yboUMbbBU8QOK50WX/8TdkNg3oO1BVLlQS9FpExs/96jKt
 NNLu4pDCAq5PoYQJKQwYn3BqPcdB/ComU9DR0I5KCz5HdWEw+OTjGiXZdNvdhZZA6SJ8
 MNvUR6kYHQ45D3+JEca7eEhldX6WhmvhKblobm2kf2RoyLsymy/CRRA9ed1HCkxGKgES
 maVa3ZtmPWFCcW2djIpMxd3BDJUd4NWvP6p2f+ahicOFTDS6JVanxYo9mstaDwfilTZm
 dcUxeKfbO9HDQLYOpk6+P0os/9lTuXjjdJ/squV4xh85Wi/dzWj2FGB1NX14g7OcsMY8 jw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O1wUASXnQl7ry1oF8Z6q3t3j3oqmFMXmP5h0sCJFECFMkmKgLagxF5DP1frmG8vp9cJtVOATy+ifDT7NqhFbkS03rWBz9snjHgcKe89zyyaAS+/Bjn36n1sExIj+MfyXv8eA4bywurk+WZIRXgeouJX8thRF3ryy9Z+FCbU4zd2X4D+2BPhXn4tExZmIETBikB2Th+f8zzhAgsRBshd5uR1t+obh8sOtqPS7wwxndHLOcOG/KDuHoXJtXRXCPANfCauveiajKAG94hQsgEqzdOysZFahMzb9zx9WA6PYhmGK/KLZyTrC7CVrcfwGv9DEeLZ+cF04tIsQsf00ZQFbRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cfVaDeBc+xYAEJUW1i4rR6c2Eono9lckX0H6AxfZXuo=;
 b=Iqit9bam3RE28mDD2RrOdX9GCjxVwaDJUgeUl3DA5imGwFetlS4EQVIkBiYv0C4ges/9SpEUCI7UKyUY/xc9ebDHvy4cjjtK819DKam8+8/kzWerdAsWO3EoBvnj9lRpoRBqdiczt51HHJClUU7mqKAc/BWVIhMqNr/KIooDaSBvGRIySAizGJtSKYdf85z1H1vYB+AdzdnjuYVvNP1bKwHJzNxG5pJ45qcNYlZir/rZmlOTB3xj1+lSr9GsEeCpQouHQ/Zm/Ng4HYWZCeWY+7nm/t/gaPQWeiewVHidP6fAQNvYrbrRPUx0OMPw4Be7kstWA4P9+qY0B1y+fT7PRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cfVaDeBc+xYAEJUW1i4rR6c2Eono9lckX0H6AxfZXuo=;
 b=N6HL3attkP/oERoO/RmZ4JOwAWTfXAcmLmRhA6Cte3umeVlxEeAWXiFSE7fMvgwn6sInCA73akxWsdWXra2U0jplJ5NOGSZ3YUiEug/tJgoWsyMMdVuv/W7sbK8M3ERMoYyrzK7WdQQgT6Bl/9NwWgm9KTlrlXkviyXc/eXbA1Q=
Subject: Re: [PATCH 12/15] swiotlb: provide swiotlb_init variants that remap
 the buffer
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Anshuman Khandual <anshuman.khandual@arm.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
References: <20220404050559.132378-1-hch@lst.de>
 <20220404050559.132378-13-hch@lst.de>
From: Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <54ec407f-eda2-6e28-90f9-eb48b2ec8763@oracle.com>
Date: Mon, 4 Apr 2022 00:09:08 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <20220404050559.132378-13-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0PR03CA0258.namprd03.prod.outlook.com
 (2603:10b6:a03:3a0::23) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d850cdbc-933c-4a65-b2d0-08da160a0416
X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_
X-Microsoft-Antispam-PRVS: 
	<BN6PR1001MB2340E896B177E99B615501CEF0E59@BN6PR1001MB2340.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	aX8/C9LNeDD1ritQCp/1YZyln1l87AxIe7JjjwdthQ+0b9dJOdRmyiriJtHBUK/O4ZBWdVGy3C8TXqofsgyUpydVOWv37YtnkBqft59hdQayrZoBqx66U0KgK6Y1c/i3iOEdxkJxUgGUybB9vrPpmASWUx0DKjWim5Pv5L1IM5a1PpxFbzT+oI2PmTdKttl/GM6GfW3ubpnMm2SNHA0h4s/CVjWYHbWkUcJrBFpMSXUaeZHIfcpmrtMP4iGIxcvRt73UrgCI3Exk4VxfoG5hrG+S3LzD1F2jMfoGhq2ew7nrsiuI7s7Gcgq9RH81zsLEmapIBseYipeef0KltLjJCoyyt+rCFv4eEYHRZWThEzz+InY1SacscvD7DuRCoppdRu3q3ZhL558dSx0XFbYhwE+F6/3xpdbudUDX9enMTrQMHmvv9rZze/XXoPwPOEUT4bQQLKIcRo2/Mt37DPXxmh8f1kB/S3w5pEe1qMRBXKzvBLxY9+TMtC7DPYqf7eT3nudKeXBQrhYewWqf+DoaYpfN3lAnvn0IDvFdBEQWuuOGiX/739PxgUJ3TCiyOkzCM5cc7rPuM8Y6K3Ckn6vPGiqA228YFPTymozmWOiJPXXntqLPf8QNEOnQglqGPJseOj1/A1tawxs7Am12ni9PlGzgoXN7BOC/U5Dmf2rMgIeWyK/woRFewT5bqLcb4ooFpfpWgjuPy7ptgZu6vjkt8Zd7lY3HWU1aXbNz8KWqwfE=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(53546011)(2906002)(6512007)(83380400001)(6506007)(8676002)(31686004)(66556008)(36756003)(4326008)(316002)(66476007)(66946007)(54906003)(7416002)(6486002)(508600001)(5660300002)(44832011)(8936002)(2616005)(186003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ak9PRzROa1F2VVQxN3RkMDA2V2w3QjNmbnZGNWw5NW4vUXFTZWEwVmRJZmVZ?=
 =?utf-8?B?blRvQ2ZWTHZFN1BXUDZlSjFSbjJKZU8yRktYQTdCWms3dVc4eTRRWldNaGFQ?=
 =?utf-8?B?dk4yc01jbnV3a2xYTnp0NmxScjdsQUpUTGdDa25VOWNJdFZ1Ti9mWEJVL0Nj?=
 =?utf-8?B?N3dndWxEWHd2QWhBRVJ5Smt3aGZPQTVmRnVzYXE0SmlaRFdaUmpoSHBHT3Zx?=
 =?utf-8?B?MGxielBWYzhYclNRbUVxODJoYTR1OHV6WFNVVWNTKzFzU2J3cmNrYVdVZGNH?=
 =?utf-8?B?OUdGOGxuVFdlTy9vS0dWajJ4eGdXakFpNDhOMTJJeldHZ0RXemV3MmUrenY4?=
 =?utf-8?B?ZGdua2loQmhyN1pzeElWVmhwUXBkOXNCWUxicjZ1LzJldEhYNlpwTmZzMFFU?=
 =?utf-8?B?dytNT29YbTVCQ2N4eFl3dGszQWVNUW5qMGJTdXZoMGoyUGhCVXZVREZYc3Ri?=
 =?utf-8?B?d3VhZjhHRE8vMW1wZHQwMEpkVDk0cTB0UWgxTEpDVkp2WUJ2VlBRTmcxelBS?=
 =?utf-8?B?ZmRhaW1wMXp6N0Q4ZXB3UEZOQVllbi91M292TWl5SW9Hd3l6WDZ6ZnVJK2xV?=
 =?utf-8?B?Yk1nUzgycHFzYXdobjRKZVdkbXFkKzIwcGJFQlVqY2V2QnB6QjRobHhXMU0y?=
 =?utf-8?B?T09JTmlpSG9HUjBTL0R0Yk94SllpTW5iQjlWTTYrVHlXV0JaTTM4WkFnQzNq?=
 =?utf-8?B?U2hLNlRPc3Vld3BvRUZKQndZUEFUVG5ZeUpDaW10cmF5YkJOWjZjWFlJOXNG?=
 =?utf-8?B?N282REdaVTdNMVlYL3BWMHJZSE1QUXJvTVUrTURhK0tJK1UwK01OUlI1TXAx?=
 =?utf-8?B?dzljcFFzMkphZXBNNkt6Nmk4am9lc0FOelBHTGxtTDNiV282T3Z0YmNPaTRo?=
 =?utf-8?B?d01FQ3RNY2dsMnlMN3RaU1FYR3VNbE5kMVlFSGU4Q2l0aVgzODI1V3FhejFj?=
 =?utf-8?B?YmhMUDk1NmpSWVBlNzhIMmJLQ1ZpR0lDRkdoUUkwOTI5ZnhhVWJwZE5OZ2l1?=
 =?utf-8?B?Y05qMzdmcGVnN09KOTdRVjk2dlF2Z2xENGpaQ0xCOGJFRlZQaEJQNmVkZUwy?=
 =?utf-8?B?aVh4VzB6SmYzeElKR3B3cG1BWGkwaUtKSVpDemwxSDhFVlM5ckFOYktlSzdM?=
 =?utf-8?B?M0F2dXpzUkZuTTRlc1EzSkFkNDAyRnZKY1E3S0pRSHBEaDRKVTBwbGJGME5z?=
 =?utf-8?B?bzBOWEFhRDhoR1FBSzJ3TzBkL0lxeURUN3Z5Z0xtOEp4UlB6dkFKMk1jOW9o?=
 =?utf-8?B?a2p5SE5GUm8xSkRkQUxOUWtrYm5ZWWZqRGlYWXZUTzY5SGJUYm9jRGNuYTNY?=
 =?utf-8?B?Qlc3b3NSbno1N1lrY0o4eVN6Tm9jeTNiUlc3ZzhDeVFMRXQ3ay9rbTMzV1Zk?=
 =?utf-8?B?ZEtZMzNVMnhoY3ZLbkZpUEp6Tmpva1ZzNm1sZUtPVG9mTjlLZU9VNWVtdjBJ?=
 =?utf-8?B?YnIzNTh6d2p0ekdCY1ZzSlFubmg2c0daTEZNZEtuY052bFlWL0hNalJHSVRN?=
 =?utf-8?B?RzJEYVNhWDFmVlhHS0VLb1hXbWxDMW9lMlR3RmFOVjlSa1ArdGFVNFFzTUhT?=
 =?utf-8?B?c0FSa0M5Z0UvMVNOMkI5TjFlRk9YVVpBL1p6VHJOMGlBMXFaK3VmeUVvQmda?=
 =?utf-8?B?YTFSS2JGN003V0NsYStvMWV5YklTNCsxNldXN2gySjNsNDE0K2o3NWJxODFx?=
 =?utf-8?B?OUFjVEdBU1RSZGE5RVdTK1JLb3RJWGdPeHZxOFN4VTlTZFpzWHNSS2FCajMz?=
 =?utf-8?B?eWg5WjN6U0ZXQXNoYUI3c3FXZ0R1UmRJU2swSCtLQTZ3Zm83ai9PNlRqTnhu?=
 =?utf-8?B?U3dJSXk3b0JQWEdhbFJlZTZOV2d5SCt1Q2c5Y3psaE9kVzdvU0tUR3E4YXJI?=
 =?utf-8?B?SEJHT0xpWGN0VG0yVkJmMXAwb0FvT1hNbWxjUWhZTGU0R282Vld2WU1wOHNO?=
 =?utf-8?B?aDFVZC8yd3BYZ3V2Z3hPMTh1TWh3UW5NQU5uYjlUeTh0S21QL0ZCTnNCYXJX?=
 =?utf-8?B?a1YyY2tkNUNUMzI0V3ZlaWNHM203UGZRZlY5aHBlS09hTlhKVVJsTkJhcnJR?=
 =?utf-8?B?V0cxcG8zaWgvR2UyU2VwaFI4K2hhdy8rOEthVEtlYkF5UWZQNDlGSUhqNEVx?=
 =?utf-8?B?dWhkdDlMUUwzcHZYd3dFbnBSTnYrT0pNaG9HQjRjUzNIZngzS3Rteklaa1Z5?=
 =?utf-8?B?enZaWW5uamZaTE56V2xSQkVBNDNpbHJ4N0Eydi9EZDJyZk0vRXZDYlFSM3Fh?=
 =?utf-8?B?VjgzdnRnOWxiODc5UzY4Y2JUZkMrTWdjUjdTUGxJQVZSNk9lMDJWbXlZQTEr?=
 =?utf-8?B?VEszNENBazU5Z1JWTnhtTmlraDZadnBJVFF0b0JaM1NMSmVjV3k5clIva2ND?=
 =?utf-8?Q?NrVBx07mFvEL67XyezraO+YHCpa5MIlvMOAAk?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d850cdbc-933c-4a65-b2d0-08da160a0416
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 07:09:10.3239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q6hB9PUkQroZregA5CgGo5ZUdZppcT2DmA+1CIUiOMJqsmmHEgss7AQSrF4z7Kh1q6JwXRnc1vlCCMTYxE7v5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2340
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-04_02:2022-03-30,2022-04-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0
 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204040042
X-Proofpoint-ORIG-GUID: hxCO3FgQKWRWKinXDhtkSBFm1Q-03idM
X-Proofpoint-GUID: hxCO3FgQKWRWKinXDhtkSBFm1Q-03idM



On 4/3/22 10:05 PM, Christoph Hellwig wrote:
> To shared more code between swiotlb and xen-swiotlb, offer a
> swiotlb_init_remap interface and add a remap callback to
> swiotlb_init_late that will allow Xen to remap the buffer the
> buffer without duplicating much of the logic.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/x86/pci/sta2x11-fixup.c |  2 +-
>  include/linux/swiotlb.h      |  5 ++++-
>  kernel/dma/swiotlb.c         | 36 +++++++++++++++++++++++++++++++++---
>  3 files changed, 38 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
> index c7e6faf59a861..7368afc039987 100644
> --- a/arch/x86/pci/sta2x11-fixup.c
> +++ b/arch/x86/pci/sta2x11-fixup.c
> @@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
>  		int size = STA2X11_SWIOTLB_SIZE;
>  		/* First instance: register your own swiotlb area */
>  		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
> -		if (swiotlb_init_late(size, GFP_DMA))
> +		if (swiotlb_init_late(size, GFP_DMA, NULL))
>  			dev_emerg(&pdev->dev, "init swiotlb failed\n");
>  	}
>  	list_add(&instance->list, &sta2x11_instance_list);
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index ee655f2e4d28b..7b50c82f84ce9 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -36,8 +36,11 @@ struct scatterlist;
>  
>  int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
>  unsigned long swiotlb_size_or_default(void);
> +void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
> +	int (*remap)(void *tlb, unsigned long nslabs));
> +int swiotlb_init_late(size_t size, gfp_t gfp_mask,
> +	int (*remap)(void *tlb, unsigned long nslabs));
>  extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
> -int swiotlb_init_late(size_t size, gfp_t gfp_mask);
>  extern void __init swiotlb_update_mem_attributes(void);
>  
>  phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 119187afc65ec..d5fe8f5e08300 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -256,9 +256,11 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
>   * Statically reserve bounce buffer space and initialize bounce buffer data
>   * structures for the software IO TLB used to implement the DMA API.
>   */
> -void __init swiotlb_init(bool addressing_limit, unsigned int flags)
> +void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
> +		int (*remap)(void *tlb, unsigned long nslabs))
>  {
> -	size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
> +	unsigned long nslabs = default_nslabs;
> +	size_t bytes;
>  	void *tlb;
>  
>  	if (!addressing_limit && !swiotlb_force_bounce)
> @@ -271,12 +273,23 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
>  	 * allow to pick a location everywhere for hypervisors with guest
>  	 * memory encryption.
>  	 */
> +retry:
> +	bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
>  	if (flags & SWIOTLB_ANY)
>  		tlb = memblock_alloc(bytes, PAGE_SIZE);
>  	else
>  		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
>  	if (!tlb)
>  		goto fail;
> +	if (remap && remap(tlb, nslabs) < 0) {
> +		memblock_free(tlb, PAGE_ALIGN(bytes));
> +
> +		nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE);
> +		if (nslabs < IO_TLB_MIN_SLABS)
> +			panic("%s: Failed to remap %zu bytes\n",
> +			      __func__, bytes);
> +		goto retry;
> +	}
>  	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
>  		goto fail_free_mem;
>  	return;
> @@ -287,12 +300,18 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
>  	pr_warn("Cannot allocate buffer");
>  }
>  
> +void __init swiotlb_init(bool addressing_limit, unsigned int flags)
> +{
> +	return swiotlb_init_remap(addressing_limit, flags, NULL);
> +}
> +
>  /*
>   * Systems with larger DMA zones (those that don't support ISA) can
>   * initialize the swiotlb later using the slab allocator if needed.
>   * This should be just like above, but with some error catching.
>   */
> -int swiotlb_init_late(size_t size, gfp_t gfp_mask)
> +int swiotlb_init_late(size_t size, gfp_t gfp_mask,
> +		int (*remap)(void *tlb, unsigned long nslabs))
>  {
>  	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
>  	unsigned long bytes;
> @@ -303,6 +322,7 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
>  	if (swiotlb_force_disable)
>  		return 0;
>  
> +retry:
>  	order = get_order(nslabs << IO_TLB_SHIFT);
>  	nslabs = SLABS_PER_PAGE << order;
>  	bytes = nslabs << IO_TLB_SHIFT;
> @@ -323,6 +343,16 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
>  			(PAGE_SIZE << order) >> 20);
>  		nslabs = SLABS_PER_PAGE << order;
>  	}
> +	if (remap)
> +		rc = remap(vstart, nslabs);
> +	if (rc) {
> +		free_pages((unsigned long)vstart, order);
> + 

"warning: 1 line adds whitespace errors." above when I was applying the patch
for test.

Dongli Zhang

> +		nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE);
> +		if (nslabs < IO_TLB_MIN_SLABS)
> +			return rc;
> +		goto retry;
> +	}
>  	rc = swiotlb_late_init_with_tbl(vstart, nslabs);
>  	if (rc)
>  		free_pages((unsigned long)vstart, order);
> 


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 08:09:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 08:09:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298226.507957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbHm0-0006SV-BF; Mon, 04 Apr 2022 08:09:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298226.507957; Mon, 04 Apr 2022 08:09:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbHm0-0006SO-7R; Mon, 04 Apr 2022 08:09:16 +0000
Received: by outflank-mailman (input) for mailman id 298226;
 Mon, 04 Apr 2022 08:09:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbHly-0006SI-MN
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 08:09:14 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 81fd16b7-b3ee-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 10:09:12 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81fd16b7-b3ee-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649059752;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=cdIAPN+nRF5O99z1sn39pPL7CQ56ABTaFP3lE5Tv4eI=;
  b=hi2FhSZwgPzeKcSvRyjLRHl6sDdoUovT6wJ2j4Tez06TT4cyAMiRSm7L
   ycZ/tcLfbsHcMT4hFvN9M6b5yhGVmXiTe4uzDnNRSAkYBxHey7PkTsqVg
   dIkx++XlNwJtDeQ+wl7X6SHptGELSuZnxRMzKncl4D45KcKW0Tw1FBYhJ
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67916570
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mnsItKy9g2QJXdI1jJV6t+fXxirEfRIJ4+MujC+fZmUNrF6WrkVRm
 2YaCj/XM/bYNmDzfI0lYNu280MDvJbRn4dqHgM5+CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YPhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl6pyUVgELF/33qM8EEAN+IjFubKBP5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J8fRKiDO
 JJxhTxHZjvSTiBjfWcuApMsneeB3UXAfgF8gQfAzUYwyzeKl1EguFT3C/LOcduWWYNZl1iZv
 Urd423jBhgQct2YoRKH+3SgnP7Sngv0XYsTEPuz8fsCqFGcymEcEhQ+SUqwof7/jFW3Hd1YN
 SQ8+DcqrKU03FymSJ/6RRLQiHKcpRsdR9p4GvU38h2Q0bHT5xuFB28CVXhKb9lOnN87Q3km2
 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgc/iTQsFFVfpYO5+cdq00yJHo0L/LOJYsPdRjHU3
 DaohXgFt54KztQt5rWrrF3OnGf5znTWdTId6gLSV2Ojywp2Yo+5eoClgWTmAeZ8wJWxFQfY4
 iVd8ySKxKVXVMzWynTRKAkYNOvxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj
 aK6hO+w2HOxFCbxBUOUS9joYyjP8UQGPY64PhwzRoATCqWdjCfdoElTibe4hggBanQEn6AlI
 ou8es2xF3scAqkP5GPoG7ZFi+d3m3xlmT+7qXXHI/KPi+f2iJm9E+ltDbdzRrphsPPsTPv9r
 b6zyPdmOz0ACbajM0E7AKYYLEwQLGhTOHwFg5c/SwJ3GSI/QDtJI6aImdsJItU594wIxrag1
 izsASdwlQug7UAr3C3XMxiPnpu0Bs0hxZ/6VARxVWuVN48LOt3wvP9GJ8JoJdHKNoVLlJZJc
 hXMQO3ZatxnQTXb4TUNK577qY1pbhOwggySeSGiZVACk1RIHlChFgPMFuc3yBQzMw==
IronPort-HdrOrdr: A9a23:ln87/qsCbU8Jnn4d+QsrXPK77skCkoMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN
 gsfJ4Y0I2mdfVmH56VNN1xMvdfNVa9NC4kEFjiaGgPR5t3c04klfbMkcEIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.90,233,1643691600"; 
   d="scan'208";a="67916570"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Aa45ssHW/oFA8rrzpDvfb4+mLQQ/FmHNuIvLXgBTKmBJLQ6dhMznN4nm2uCkO58MoX/lk/w3abnTU9V2XOX2wcD82xOaDOY4B8Gog42NnlBRQN5YdOU5YUPdn/7AGRMDqf1jK5r/Z+jrpWNqkxVCLuj3BWTO55nDlvjpaXUT535ZhG2/4Z2TSsnR3TIvQs9bI4ivnp8POWpH5VlQacLU9JqYQXQIKStdYLLZexDEUA2NzqFYTUGlKrpQ0P0UDR0muSzq4j15jhvAZ8ecYHG5rBm/3wmrK2mV650XQBZ1RX+YtxNk35zefgq1RsjYmC7iBnrpc1LYcR3y8GVP/4abnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HPHxqm4vhRWgFvqFN43iPqVfvXcxfZjq+Puv8C3Oo60=;
 b=iLrf0hXhC+3AMgud0T5Ms4rA/inP6UXZ0OVphgX4vrA7ZUT3hsGCiXgm4H32CYyPPvVt0vYn08eMCvTE7wmaaLS1yPD9rpRXiJ9wBsoiUbY95Uuc522vdKlHCSnIGysKQOD2pyaBw4D0FfF0Bh4vflHhgwUDeyv4mE4j/0S3mggxqisDRJ7iCB2agEtNoM2dtl4Hpd0yN1Yv6XgVfkJ9zxNUFTInWhb0UnJZ3a12zlfklXT59Q1KZ7Q/5Uq6n4xtFl6HRy2ssIPJB35n27eDRqEF9rDV3v+W/7Kfrpy3g988UmUptK0ApwKrdNMCxt84Tamj8jSMZ9ttfqfFlb4Puw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HPHxqm4vhRWgFvqFN43iPqVfvXcxfZjq+Puv8C3Oo60=;
 b=QDNnzlGS0VFf2ar0rHz7Jk3X5KSLeTky4Ee327tQAYrWepnkk1eKOomJcYRXMg1xHKuxw39Q6Zl9PE4xFWDvt5EHbsIKSlqcPdXe7elCop/H2JM2VF/Zd1387KuJuJ4ViI+LuHDPOrhLBHHVegJ6L9OL98WUX3ujSulXC3m5IPo=
Date: Mon, 4 Apr 2022 10:08:47 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
CC: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	<xen-devel@lists.xenproject.org>, <scott.davis@starlab.io>,
	<jandryuk@gmail.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Message-ID: <Ykqnj/7gEc8Omsvr@Air-de-Roger>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
 <90fd48a1-446b-fb7d-a732-d2c1ede0921b@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <90fd48a1-446b-fb7d-a732-d2c1ede0921b@xen.org>
X-ClientProxiedBy: MR2P264CA0151.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1916376c-d78f-4f8e-c871-08da16125c17
X-MS-TrafficTypeDiagnostic: BN7PR03MB3713:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB3713571790CC049D47652D478FE59@BN7PR03MB3713.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LfEe9UFzCyAESBUvrjFSTrd52t+fhY+6PtwpG0HXThF9ncQIrIwXU7qM2Yxe1i1thBdylfOazBFfB/Z4iD62qw48rxWoF9RZzatLIDrWzQKDnu3stSWm8PdA01Mq1WjsIl3HcuY7cPVn6xz706xx01FceobjJuw0w1Au7gOwUnz9gSfieM3sXo2LNA8XmKfQ3eHq7MteMX5lU+zfv3drCcOg87lRlk9hXVzLDYaI0W7yylTYysFQZFORQ8QfM/9QvYyFB8cgqz7HFSOXp+rVGcZnyiPFGkvCyo8nCgsa/8hNbF6ozPKy0wCIWQjVMvBiHGaYa2DPIEufe7UFks9S0QydqD4o1WQPWbJs5JmHUSNKBvrCTBGtMQPk22qrgiCONGt41OasQA+oB8PEwSviv8k059aq4/EVrkb96N5dQ2hlyk/JKXt8B3AQUejj3nZEkuDEC4bbAdPDZhr/azApVExYEJdOkD/O/tcvxK0no+pmKz5iDkty3FyZ1qLj7OCecUQ5ab1bCG72H+xKUe3C4moWCYDc7KcGhvjqpcLHaSuDkIrU7FZHXOEdMdSBCEBEVmQu0foAhJsyQU886TCJRx1RItP/oUWC9svA5mXJ7WXBCTmEVr/o3YFXiZ4BLH+rAVwwH68VhYpjZ3ePaRR9rg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(26005)(86362001)(9686003)(6512007)(82960400001)(6506007)(53546011)(6666004)(38100700002)(83380400001)(4326008)(66946007)(8936002)(33716001)(8676002)(5660300002)(85182001)(66476007)(66556008)(316002)(6916009)(54906003)(508600001)(6486002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkMzeTYvMUljS3N3WGRtUG11T3Fmc05VS3hyaDljcHdRVHJHY0gyNzQxQ2Qw?=
 =?utf-8?B?WENJcUNlZXVzTHJBTWNZekxMWUw0WDdURCtDQWw1S2lLMTY0RXF4eTIrRGsr?=
 =?utf-8?B?OUFEUnpGbHBubFNUT2lmUzFXcThyOGxOWTd5Vjg5eDREVWVqbjdGczVjdms2?=
 =?utf-8?B?Rlg1QVlUMGZPMUpBY0lwckcvcG9MOVY0ZUQrbE9lVVFyMTFmTUNlL0FiRmE1?=
 =?utf-8?B?Ni9KRXVoL2pIelllZW9MdURhRVFqcm9VaUlYUnRVK2dOYTB5eWUxUEREdzBH?=
 =?utf-8?B?QmdURHRPaTNhS0c0ekpCUjI3RFB1bnovZkNVTk1oZEJtckNZVXBOaCt0d09q?=
 =?utf-8?B?M3V3KzFkQ1lEZ2xpWmJnaGtDbTQvYnFDMmVXTXc2MnZPN1NpemVXTTJGYmFv?=
 =?utf-8?B?b0FJdHgyUkZXNmpDRStXZXpwU1VYa0RHc2NSMk1Tcyt2V0RpRlNqc042dm5S?=
 =?utf-8?B?VllmcUIyRXBJdS9HbHl1VUl0K25XWmlPUVBaZGtCWHU2cWVsRm04MEkyM01m?=
 =?utf-8?B?cmNhM1lOR3puY0RMajErenc3dWxYcEpHQXVQYWZoTjV3c0xKVEdwVGQ0T0Nn?=
 =?utf-8?B?M212NnpSVHFVVE9rckFMa2dMSVZGaVpTTVNaT2pIRjgxV0dXSWJxdGNoZVBp?=
 =?utf-8?B?czVJbGhEc0VNY1hySkkva3A0UmdDTGNZRzM4cTRxTmFoQ1Q0S0tkYVdUbHdv?=
 =?utf-8?B?aWVVdDNyYmJ0c2d6M0hxQ2ROcFFvUHlzNmkrK0NuQ1NCZmF4VnFwZTh4SFNN?=
 =?utf-8?B?SjFGRUsrN0N1V3lTSzh2M2dXSDNmcUtBZHFCd2hLOXArMXl2Ymh2NHhma2Ry?=
 =?utf-8?B?MFRrVUFvc3J1K0ZQNGM0TFc0VEZ2OVFldWlQZUMwNzBjY2FYWFBOaVpSakM1?=
 =?utf-8?B?bWJQdlpPWlVTdWlMWW4rU2laSEdVUGJjTUtMc0VkeFZoQjI3YlJpOUNlaitj?=
 =?utf-8?B?NXFTQTdYZ0d0eVdCRUtHZEFYWlJJWHhiTnRYbUxCZkxSSFcrcndyOUxJTmtE?=
 =?utf-8?B?T290ME5INDQ1YXE1M2J5L3UyV3BOdHE5a3BmWFdMbFVUdkllbVJVVjhnb05k?=
 =?utf-8?B?WXJUKzhJYXlFb0hiVTc1c0xDVFU2cE00RHhZZS9CVnZ2dU5tMEdpWkVBdUtw?=
 =?utf-8?B?UjFGMFRVdVFBTUxUTVVTeDZaZE1naVJ6ZGk5VnQraXhZSHJWNHF1VThHMTVJ?=
 =?utf-8?B?MzdLcGduOXNXTnpsSVVDeHJHMExlTVVHNzZESjNweDI4eFFOMk84T0NyU2Z3?=
 =?utf-8?B?NWQ4TkFFUTJtQlFGek01T1E1Q3J4U0JJSlBBZnRVd3pUdFZWQkdiZVF6Nld2?=
 =?utf-8?B?czVyUXk2ZnZDYlRwY0NURTRyc1pTSmRFNlpGd0sxSFQzWVB3bFJNUC9abHZj?=
 =?utf-8?B?RTVFNDNWekJZc0JTbWR4SVNXQzhTaHJhYmpjUXRKZFg5QU1kUm9DNHFjZTVE?=
 =?utf-8?B?Y01EM3J0dUpMOHNZTmN6WVQrZHpPckVSRThqM1JvL1NrdFl1RnNXYnBOWnha?=
 =?utf-8?B?NTNQMmpScnAwWDQ1N3RINzFTR3VtcU9SemRZWDNpOUs1R0VrM1VvN05CV1c4?=
 =?utf-8?B?V05ha0Q5ZjZDODZRVEFuTUVXRnBMTGFHcXJ1bmZ6U1BtS1lhNXpJV3I3ZkJ5?=
 =?utf-8?B?QlU1R0M0R3RZcVcrUFJpL0NDTUlEVi9ib3J3RHF0UGNGRUpzTTNGYmRFeDly?=
 =?utf-8?B?dXZlanZYbGF6eXNxeEJWV0RXSGdXekRTblREd2RablVnOHdvcDkxaG1DdXVB?=
 =?utf-8?B?My95eE5JOU15WlB3dFM0b1Jua3hvWDd1eVU4OW9HRWd6MExUSDdyYXNyOS91?=
 =?utf-8?B?NEFkUThxUnBYNHJ4dmc1TFV5RHE4UXIzUlU5VzhQTDZCMStFaEhQTXJLdjZk?=
 =?utf-8?B?WjRQUWNkelhpVk1tNGwyRmlLU01oTjVSL0paOXA2SFJyTFZsU28zRjVDdWVr?=
 =?utf-8?B?U244T1diUUtpRzdaUUUwbzVkamhpTEVZczNGR2k1ZEtHcExGZG85enNhcVpH?=
 =?utf-8?B?bnIrM0dROU1vOGZKN3k0T3ltMmYrREc2MTl1ei91UVN0dnlIVDZUa3p6bkZW?=
 =?utf-8?B?VEErS2o4dTFMNXFtQ20xQXJXUjRVenhEaCtrcCticUxYQXpOMUhHWXVKWU94?=
 =?utf-8?B?WVdOeW81YnVCUzVEZ2dsZmNqK0xDYjQ0OE1ycHEzbnZ4eGZBdjhIVmVnNjYr?=
 =?utf-8?B?a1lJS25HODdYUDdwSk9sSHhIL1NsTDdPVjlRTUlWZ2hPcXpYNjJQRmcxTkhG?=
 =?utf-8?B?dStYSTJOSW1IVFZaL3VuU2orRTJzRUFHNmxkWHRmZmpLdU8zeXB4cFkwQVZz?=
 =?utf-8?B?THp0cEh2a0lvV0FlcldWS1pGNGhWR0lwWDExTnVtY0hYTi9CU2Y3Zz09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1916376c-d78f-4f8e-c871-08da16125c17
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 08:08:53.9286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: za/Ieshjyqso5v7QIKbNDHoH9JKPGhE8tDlM36k2BmWqCknKcMv3FN2Eo1lmShAwQ1Ij3+2CwrFWLTCgiiAM4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3713
X-OriginatorOrg: citrix.com

On Fri, Apr 01, 2022 at 06:52:46PM +0100, Julien Grall wrote:
> Hi,
> 
> On 31/03/2022 13:36, Roger Pau Monné wrote:
> > On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
> > > There are now instances where internal hypervisor logic needs to make resource
> > > allocation calls that are protected by XSM checks. The internal hypervisor logic
> > > is represented a number of system domains which by designed are represented by
> > > non-privileged struct domain instances. To enable these logic blocks to
> > > function correctly but in a controlled manner, this commit introduces a pair
> > > of privilege escalation and demotion functions that will make a system domain
> > > privileged and then remove that privilege.
> > > 
> > > Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> > > ---
> > >   xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
> > 
> > I'm not sure this needs to be in xsm code, AFAICT it could live in a
> > more generic file.
> > 
> > >   1 file changed, 22 insertions(+)
> > > 
> > > diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> > > index e22d6160b5..157e57151e 100644
> > > --- a/xen/include/xsm/xsm.h
> > > +++ b/xen/include/xsm/xsm.h
> > > @@ -189,6 +189,28 @@ struct xsm_operations {
> > >   #endif
> > >   };
> > > +static always_inline int xsm_elevate_priv(struct domain *d)
> > 
> > I don't think it needs to be always_inline, using just inline would be
> > fine IMO.
> > 
> > Also this needs to be __init.
> 
> Hmmm.... I thought adding __init on function defined in header was
> pointless. In particular, if the compiler decides to inline it.

Indeed, I didn't realize, thanks for pointing this out.

> In any case, I think it would be good to check that the system_state <
> SYS_state_active (could potentially be an ASSERT()) to prevent any misuse.

My preference would be to make those non-inline then I think, we could
place them in common/domain.c maybe? There's no performance reason to
have those helpers as inline.

Another option would be what Jason suggested about creating the idle
domain as privileged and then dropping the privileges before starting
any domains (ie: before setting the system as ACTIVE).

This expands the duration the idle domain context is marked as
privileged, but OTOH we don't need to add a hook to set
is_privileged.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 10:04:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 10:04:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298232.507968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbJZO-00016U-Sj; Mon, 04 Apr 2022 10:04:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298232.507968; Mon, 04 Apr 2022 10:04:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbJZO-00016N-Oc; Mon, 04 Apr 2022 10:04:22 +0000
Received: by outflank-mailman (input) for mailman id 298232;
 Mon, 04 Apr 2022 10:04:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbJZM-00015z-Et
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 10:04:20 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9481c66a-b3fe-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 12:04:15 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9481c66a-b3fe-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649066655;
  h=date:from:to:subject:message-id:mime-version;
  bh=wd+U9l9whlTW0NoQfDgjyi98G8boMD0/950K5cWZC08=;
  b=UN6fiIp5CXlwE/EExZGzqy4yzR6lYai7unXrGDt8k4W2V5qUMEz9M3mP
   kB9jADeOl35m64TbVKbSju4+60fzdQ3MQaNoaXo5mh4BfAiWumqhgojNn
   HqPDfyVFIWx+2yjICdiQhwU2uqwGA7tAuyE4Kh69L1F2iJ5uNV7BQ0gn4
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70319170
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JSpz56Bei0hq7hVW/1/jw5YqxClBgxIJ4kV8jS/XYbTApDImg2RTy
 mBJWDrUaKyCYmP1ftpwao/lo0gCsMPRyN83QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jh3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh60
 OQTu7+hWz4yBfORms0mfERhTQthaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcHhGxp15kRRZ4yY
 eIZVx5ScD3mfSRDM1EJI8k6hevv2nrGJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+XkOK//eam1yHQOkBd
 k49wQVzlPYY6xn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mOfNIU9x4It4ut9b1cI9CWYZLREJQgIeizUIiNFi10mfJjqP/UPcszEUJd0S6
 23RxMTdr+9K5SLu60ld1Qqa695LjsKUJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLFWV8nRyXDWHLll8FSVCxCtamC0bblHRcdJythQ0yT7IdA4DM9Wei+FzfroiRe2O
 RSO6Gu9FbdYPWewbL8fXm5CI59C8EQULvy8Dqq8RoMXOvBZLVbblAkzNR/49z28yyAEzPBgU
 ap3hO7xVB72/4w8l2HoLwrcuJd2rh0DKZT7Hsukn0z+gePBPBZ4i94taTOzUwzw14vdyC39+
 NdDLcqajRJZVez1eC7M9oAPa1sNKBAG6Vre8KS7qsbrztJaJVwc
IronPort-HdrOrdr: A9a23:1a3SRq70kscvD7R1MgPXwTOBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc6AxwZJgFo6H6BEDgewKlyXcR2+gs1NiZLWzbUQeTXeVfBOjZskHd8k/Fh5dgPM
 5bGsAUYrCAbikZsS+T2njELz9K+qjgzEnHv5a48587JjsaEZ2Ioj0JfTqzIwlTfk1rFJA5HJ
 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2TiIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S
 zgnxbi7quunvmnwlv31nPV7b5RhNz9o+EzcvCku4wwEHHBmwyobINuV/mruy00mvim7BIQnN
 zFs34bTrZOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOCfx2g4FhpVRwa
 hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGrf2UIUh4bD3wXklX6vpREnBmc4a+a
 hVfYnhDc9tAB6nhyuzhBgv/DSuNk5DbStuDHJy+vB96AIm4kyR/3Fou/D3oU1wha7Va6M0kt
 gsYZ4Y4I2ncKctHNJA7aE6MIiKNlA=
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="70319170"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jw9L9ApyUm7S0iDHu1PTroJWl6W2PRAbTC2WouNC603G7kTS86jMtmNLRLps4uhHjrALSBBcV5Avgt5oJum1EdkIIm2ycpUOvT5ThnrlpMmpREevc/lO+mfOUpaotOILYbA7b1EzERlAMYL1C6yJpOKt6ZmFiCB8sQIleG74hWlivnrzzt+dr9IrhGuhCeUy4NuY2IT/xUT8PR2TA2vSE/o5wuQJEeYfbMJnDe0UsiQStNekSOUu4Q1G9g7uHhOtXarKvJnjBbMyV4dM0RnhIETIBVHd4tJ1TRrLsDwPBg2BbKFF1FFEc0PTOq4eJipsFpMOEUN19y+g7jYSI4kfpQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k+CDDSSaXAb6T7t8b1sqsKZHhME11JRkzfvhHQ7UNCg=;
 b=iCZJUchoCTjoaKt1kvhLJmdU5nypskQzqtRxhOn1gJLRlhInNoYVrCtjSktepTGOd+7TLuJthBHJC+nUNrUVWBpVnPBS6ksbG4VmIxYP4i+6KBPHy/7nt92V3WvrvqEgBiwizQQdhhu66ixi1LYHuHLGEqQDXn7I5ErpZeL7X+ArWMVD9SpoVR/Fj47xSZ0xlIOWadhfKR64HttZ1Zx4Tt/SvOauuBYGLv4SzBZ8JfuYtMNCBMBYXvm8AIWNtwkW4fo3B0wfWgMjrcsxTaBjuGr1tTNg+xgCcs9sRq4guvtUx/RpC1jXiGYoFnUHPgBIk0CQMRgVBwHMhKTPp4dMxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k+CDDSSaXAb6T7t8b1sqsKZHhME11JRkzfvhHQ7UNCg=;
 b=u0Xws78moOnDKFjvSRlHSV3WVXekiiDJkl0YvNOvOqAXgjFtVCW7fzJEfPzKQZiA+dGdZPD+QcULbKA+jueCnIrXmeCjbkuvXClk6aQx2s4hNomvHfea00Hu2B/btn2pNban28eOQjQ5ojGzWPctmGtFDaVt+VgBwOMOWLIvWPM=
Date: Mon, 4 Apr 2022 12:04:03 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
Subject: osstest: boxes pending comission
Message-ID: <YkrCkzWRW1xMvzSj@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
X-ClientProxiedBy: LO4P123CA0002.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:150::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e806d40e-4d38-4333-089f-08da162275c7
X-MS-TrafficTypeDiagnostic: CH2PR03MB5301:EE_
X-Microsoft-Antispam-PRVS: <CH2PR03MB530108C078C699CF6BEB6AE08FE59@CH2PR03MB5301.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GbRjMOJHe7xk6KMZP9ldHrJHRcIUL3Cu+PYU+H9vnFf4cRiWzG3gxOrjwh2eo13er28OkFAGoTexG2/Ib/0uW7RF2Fm88K2po/cffOhx2JUSzVZ9eTTd2prcnsR3fPwE8hFupNf8g1J5LMQw+IraKcUwOzJBHdvu5YCPvvFmJ74G/DSEi2yrJtV+YPJH69ISUpeCkBpLDoO2wyecSULKys7e3yfD+xPZySUGSTSNBNPKQDVFkBIFes4gCHaaX5sq6fALtlo5AUI3ab0ICyt6AV1pGVNp9n7e+lUiqvBjDmVZc/A3S2SfjDWVj0K6wfBZQsArraxn+9CAfVciXd8618fWCPwmuxKvga/lypFvkwvLDtyV37PKHS30xXAYkTLsBTJCto/t0n6OAFFqmlVGE9I6TdBCJkTLshcbCFvAiEeN++8Sk2lmYeo4BKWC1qW/dE22fxVC8HwSskRTYfe+O8F1i59t2xoB+r4HVChbPEfGk0PJbTRfVoJQyobX+d2q7sWQeWa6hLud06QG+HsaFQYGueiq/oLP0y/oN2Q83yXTdEVY96SP+yKEuL3vsv4+SKv5ADO8qa5diPnLjg2DitKWCP5TwAx39cY/tN+OcIpcuoENpssuC5FUHtEC0j4vX9yrxeMxkdHosClJ7kRXRYoxZ6ocHISJGMv7wVke/NvVt5IAA05aEP/7rWKYbIEfCT8h+CtIeTJn/wwJmEjNdRprAeGDGFgQqsT4sbt9RoSZUCGq6LqKgUnwtb5Esj3IHt6c+T9hBoF8gImTw/idng==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(86362001)(82960400001)(6666004)(2906002)(6512007)(9686003)(6506007)(316002)(6916009)(66556008)(66946007)(33716001)(8676002)(83380400001)(186003)(66476007)(26005)(8936002)(85182001)(508600001)(966005)(6486002)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUxXd0JJZHB1OFVUQjg4L2VXdGtBUnFIMmRmUTZjZFRqMG5MS0d5UEhDRzZm?=
 =?utf-8?B?Y2dMWitsZlYvMXRRb1kzdmMxMUl2SDBhNWxyenRnOUxlTWw1dFFmazV6M1dr?=
 =?utf-8?B?c201ZGNucHQ2YUFnTnFvYzNLTnppQ1Bab0sxNXNBdkw3NzFUZGlFV3VMdzh4?=
 =?utf-8?B?b2I2WHBsVUFoMjYyUElVa0NFSUZuR1Q2dWkwTHBSYTZzK3k4aGQyUXhiMXNR?=
 =?utf-8?B?dXJ0QzNjOHI1ZFRjOGUxM0hDZEJQUUpacVhkM3FMdWt5L3ExMSttbFlxdHoy?=
 =?utf-8?B?V0xpYlEyc0swdXlhSis1bFl4WlZrblVHcmVGNWV6NTl5UWhHYVhCenMxZUpk?=
 =?utf-8?B?ZVJJSSt2Vi93amtTd2dJcDc3MWswTHJyMUpxbGVmL0RXOGJUTGJUQ0thdHZs?=
 =?utf-8?B?aEtPRE9vbGlQZ3pPQ0xseVl3N2dJcXV0S0lSdkpTUUNIM25tRnJMaWtMU0dr?=
 =?utf-8?B?aDl1NC9ITjEyTXpBV0h5bDFRTkg3eFZsM0VkYmMzT0dOMFdhZHVsMHgzb0Z4?=
 =?utf-8?B?dGRkN1RFaXY4U0RsaFhxaFQ2V2RqTEZabkMrRjdnUklxdkUvQlFET3JpWWxQ?=
 =?utf-8?B?d0dXazJPTGZsUzlPMlZaNFJNOXpnWFNCT0JyZS9ISHZZWEVGS285WGw4U0lD?=
 =?utf-8?B?Rkx4R0FVVXRTWWdGRXhkRHcyUmtXRWxCQ1h3TDM4ZkJWalNmN3U0SXF0WVhD?=
 =?utf-8?B?c1pxUThnb2VldjB4aTVLbGVlL0FVTWI0N3lhVkJ2NExyb3d4VEM3b1pvdWdl?=
 =?utf-8?B?UFVtcXBnVkNqaGZ6cEdrckprRFhTWEozZ21mV0dYSzg3cENtb00xTmR5Q2Vx?=
 =?utf-8?B?dU5wNi9STC9lSkw2UGJ0S3RTMGhWdVIvdE02V1N6RWRjd0NPcERBOWJNUUw1?=
 =?utf-8?B?Y2NjblN1bTU0Z08vamhzUjhHWG1qTmV4emc5K29sU2JaSitCQnQvckt2NFE5?=
 =?utf-8?B?N0FqWFUxTlBRNTJtUE9iOGhOM3FkY2x5dXZibHhzM3I0MFZzSkJzeVYyUld1?=
 =?utf-8?B?bW52WW9VbjJmSStwa2NBSXpMWW1tVW5sUzZDRUpTRmdmLytrM2o2dXhudE9E?=
 =?utf-8?B?Sk4wbDMrTXdKNGJNZGxUK2hyYnd6YUJjYVBwY01kd2pCTXBwaGhGd1ZBZTB1?=
 =?utf-8?B?Y1N0STBJVkc3WWNSeFh6L0hKb3d6Z1ptM2RZSDg1cFk4RmQ4ZE5nZXROa0M3?=
 =?utf-8?B?aVpCTGRsNjNUOVBYT0dKdHVOOWRiOGJySHZkTkVEOWFPeGEyL3lYcmlUL2tP?=
 =?utf-8?B?akV2YTEwRHppaDZJbEZwZXQ5VW54UkI5Nml0RGZUTlRTTUdyYnZ2eEM2S1Mr?=
 =?utf-8?B?Z24xOEsyelcyaS9yUm10QTVvS2F0cGlnTEJrZC83TXlCNjBKREJpMjBNTGM5?=
 =?utf-8?B?ZmZBVUtxMmNCMWlKSDdXb2JqbEdyMUtpSUE0aGM2RmU5WXRFZ3crcC9yK056?=
 =?utf-8?B?WDdyakNrNndyZEhGeDVNcURoQlJLUE1RT2pzMHRzMnAzNW1YaVQrcUgydTNa?=
 =?utf-8?B?akxPN1h0SDZ6eSthbG5KZjNCZWdGYWhDK25oTFBsVlJMMnIzZWhlQlBMUkti?=
 =?utf-8?B?WG14NXZPMVk2Q0tYTWo3VDk5cTgrZnYyNGZQTjhKdHRta1dHYTBTSEJ5ejhl?=
 =?utf-8?B?TEcxaVlDdWVJelJpRkw0MUVyZ1M3VTNuRXJ3bHlBdGpDcFNWdTc3NnJydGNL?=
 =?utf-8?B?YXUrZWpqS0h3cmdtZEFNcFZMNkZxTGVhMDVqQzlzNnEyL0V0RU1nbjZHVE5t?=
 =?utf-8?B?TVBNSExlTE9Id3BDSm9uWmdNRkI5Ukg1T0RlbUszTThvNEFLRm1GNHpUYmQ2?=
 =?utf-8?B?NnBrVGNCMm1rTXNXK0RFTjdDOStiakVONUdTYUZ4a2xpQnRaS2FySndzbTBU?=
 =?utf-8?B?TllDZlNnNGtEalJrUVRWV0JyZ0lmVklCQXRzV2dyaEtwMjJYNlQxcUpBdXh6?=
 =?utf-8?B?Vm96eklQY2lnRVM0TGxCangvdjBsN2hQMEp3eG5iQ1pjT21VZlBUL3FVMFl1?=
 =?utf-8?B?aHF2UjN0aC9pK1l4dG9IVHZsSWV5UHk4YmpvQ1pxdEJaanVrY1RRYVQzWWFT?=
 =?utf-8?B?RXNPNWJlMUlyb0d4Ti94NzMyQ2FJRGZxK0FDblR0dDFHQWc3cWFrbitDVDVB?=
 =?utf-8?B?M1hCd0E2WlFaMTkwMmJISllER21UMlFzU0dINFlTanpFSVJhQmlFNTZuMnpm?=
 =?utf-8?B?a05ILzk2V0g0U3dwQWZpenorY3Y1bFhCZW1ZU2JnY3RabmJvcHMzbEl3N2ty?=
 =?utf-8?B?WVA3ZVhWSktNbzM1UmhQS0h3WW56S1FuZ0VPa0daQ3lpV05GSDJQdGF0d0g5?=
 =?utf-8?B?LzZUT1JlM3J2MllZeWtmZGdyRUFjbUl4c1RBeXlOV3FGNjF5Y1ByZz09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e806d40e-4d38-4333-089f-08da162275c7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 10:04:08.8898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zB6TvYGMx4qExL/7MP4voub4ImGFENmJQNPRHkUKbbUxHQvJEunbgUcfl0TMZOODkcLmeq0lOGR7557rGNOVDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5301
X-OriginatorOrg: citrix.com

Hello,

We have the following boxes pending commission:

italias
 * Commission flight at:
   http://logs.test-lab.xenproject.org/osstest/logs/169015/
 * Issues:
   All fine except for the leak-check errors:
     LEAKED [process 14559 run-parts] process: root     14559 14558  0 19:29 ?        00:00:00 run-parts --report /etc/cron.daily 
     LEAKED [process 14558 /bin/sh] process: root     14558  2252  0 19:29 ?        00:00:00 /bin/sh -c run-parts --report /etc/cron.daily 
     LEAKED [process 14564 /bin/sh] process: root     14564 14559  0 19:29 ?        00:00:00 /bin/sh /etc/cron.daily/apt-compat 
     LEAKED [process 14571 sleep] process: root     14571 14564  0 19:29 ?        00:00:00 sleep 1091 
   Those processes are from tasks started by cron. Disabling cron in
   rc.d during the host install doesn't seem to be honored later on,
   I'm looking into a fix for this.

joubertins
 * Commission flight at:
   http://logs.test-lab.xenproject.org/osstest/logs/169014/
 * Issues:
   * 2 network timeouts while connecting to guests. The timeout seems to
     be while executing the command, not while establishing the network
     connection.
   * 1 timeout while running update-grub on bare metal (without Xen
     installed). I've already had the raise the timeout for
     update-grub to 120s, but that's doesn't seem to always be enough.

debinas
 * Commission flight at:
   http://logs.test-lab.xenproject.org/osstest/logs/169016/
 * No issues: Arm test failing, -amd test failing due to the box being
   Intel.
 * Will bless tomorrow (5th of April) during the day unless I hear
   objections.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 10:22:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 10:22:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298237.507978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbJqO-0003S0-B8; Mon, 04 Apr 2022 10:21:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298237.507978; Mon, 04 Apr 2022 10:21:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbJqO-0003Rt-8K; Mon, 04 Apr 2022 10:21:56 +0000
Received: by outflank-mailman (input) for mailman id 298237;
 Mon, 04 Apr 2022 10:21:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DmI9=UO=redhat.com=hdegoede@srs-se1.protection.inumbo.net>)
 id 1nbJqN-0003Rn-7S
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 10:21:55 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0befc070-b401-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 12:21:53 +0200 (CEST)
Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com
 [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-128-8BYZRLUxOY68ZO9CxOEyMA-1; Mon, 04 Apr 2022 06:21:51 -0400
Received: by mail-ej1-f71.google.com with SMTP id
 qw30-20020a1709066a1e00b006e7f3de1be3so778655ejc.11
 for <xen-devel@lists.xenproject.org>; Mon, 04 Apr 2022 03:21:51 -0700 (PDT)
Received: from [10.40.98.142] ([78.108.130.194])
 by smtp.gmail.com with ESMTPSA id
 bj13-20020a170906b04d00b006e742719b9fsm2200534ejb.7.2022.04.04.03.21.49
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 04 Apr 2022 03:21:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0befc070-b401-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649067712;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NrIiVtW7zL/EZbvvEh1ijtvz57/RGSqRlI7BljZYLs4=;
	b=LUre/Wm6NpHO0CNcnHZIqvT9odDlWkBu8bui54by19DMqAwNmmC1KnUwcW/A/ENslPfPLy
	gNS5eKxW4GjCmk/P4OLIbbDT58C42aVGuovQdBz0RyJ/to57xlxHmUMHzQa4+1Xg/11/n0
	/awA19XZLDuTg/7xDISvxL2a5I+G8DQ=
X-MC-Unique: 8BYZRLUxOY68ZO9CxOEyMA-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=NrIiVtW7zL/EZbvvEh1ijtvz57/RGSqRlI7BljZYLs4=;
        b=HrDXcTVMBIUGw91qpampMGbJbg2mwnaOqOMEYm4X3ZDe0Rry1WkhbZ9njVfwsoPyQ5
         DZ5nKFMnaCM9VriWflvEH3yVMozc3qaIjbbCK0CpYVJq6dcVV4mZHGhNmCKUK4DhM7E6
         jPeUcEUxLmkQNXgG0ULe6KhNRBdbMLE4U0qTKHm3EKYVLzQter2B+IQkbI8k9MtpIBSe
         nN4dLue+wRMQduTD+R2fdsMxNJ8QCTzlPJbpn7T2Xq97zpNZxtiRKdpnFhoce/jI1PTx
         YPMiXjK1wds2rqa0nMp0WmbLkRmm3N/JvGxNQwZin32csrNCd24+pkhIPLVnJkZ5oyIT
         ouUA==
X-Gm-Message-State: AOAM533Xb7JegkQwfiSzaCj4ziTSRvOihutI15m1Rb9c/+1eIQw532zm
	bWtRDwnr/zhg7inRspPab176QmNipb754DlfrVcPIZ8EM2asu9cMrY4Crk/vg7mT0RYVbH0AZE5
	oPwUP3TIoFWBvELMOsCBZWzawN+M=
X-Received: by 2002:a17:906:a398:b0:6ce:71b:deff with SMTP id k24-20020a170906a39800b006ce071bdeffmr9828058ejz.204.1649067710279;
        Mon, 04 Apr 2022 03:21:50 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx3m+Zd29+/ftz6u00cEYEm1e5sEaOZfUaNREapxyh+NMbkZdJaoKQ+wjSusHi4JcoWwaYbYw==
X-Received: by 2002:a17:906:a398:b0:6ce:71b:deff with SMTP id k24-20020a170906a39800b006ce071bdeffmr9828042ejz.204.1649067710100;
        Mon, 04 Apr 2022 03:21:50 -0700 (PDT)
Message-ID: <98b58912-d0fe-0e4d-ef6e-3396840a1e4a@redhat.com>
Date: Mon, 4 Apr 2022 12:21:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] platform/x86/dell: add buffer allocation/free functions
 for SMI calls
To: David Laight <David.Laight@ACULAB.COM>, 'Juergen Gross'
 <jgross@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "Dell.Client.Kernel@dell.com" <Dell.Client.Kernel@dell.com>
Cc: Stuart Hayes <stuart.w.hayes@gmail.com>, Mark Gross
 <markgross@kernel.org>, "stable@vger.kernel.org" <stable@vger.kernel.org>
References: <20220318150950.16843-1-jgross@suse.com>
 <accf95548a8c4374b17c159b9b2d0098@AcuMS.aculab.com>
 <2a4573e0-4a8d-52c1-d29b-66b13bfe376f@suse.com>
 <f04348c83155404c8ae4c8e5c3abedf2@AcuMS.aculab.com>
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <f04348c83155404c8ae4c8e5c3abedf2@AcuMS.aculab.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 3/18/22 23:28, David Laight wrote:
> From: Juergen Gross
>> Sent: 18 March 2022 16:56
>>
>> On 18.03.22 16:22, David Laight wrote:
>>> From: Juergen Gross
>>>> Sent: 18 March 2022 15:10
>>>>
>>>> The dcdbas driver is used to call SMI handlers for both, dcdbas and
>>>> dell-smbios-smm. Both drivers allocate a buffer for communicating
>>>> with the SMI handler. The physical buffer address is then passed to
>>>> the called SMI handler via %ebx.
>>>>
>>>> Unfortunately this doesn't work when running in Xen dom0, as the
>>>> physical address obtained via virt_to_phys() is only a guest physical
>>>> address, and not a machine physical address as needed by SMI.
>>>
>>> The physical address from virt_to_phy() is always wrong.
>>> That is the physical address the cpu has for the memory.
>>> What you want is the address the dma master interface needs to use.
>>> That can be different for a physical system - no need for virtualisation.
>>>
>>> On x86 they do usually match, but anything with a full iommu
>>> will need completely different addresses.
>>
>> Yes, thanks for reminding me of that.
>>
>> The SMI handler is running on the cpu, right? So using the DMA
>> address is wrong in case of an IOMMU. I really need the machine
>> physical address.
> 
> That ought to be handled by the 'dev' parameter to dma_alloc_coherent().
> 
> 	David

I must admit that I'm not too familiar with all the intricate details
of the DMA API here.

So does this mean that the patch in its original form is good as is
and should be merged?

An Acked-by or Reviewed-by from someone more familiar with the DMA
APIs would be helpful.

Regards,

Hans



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 10:41:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 10:41:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298242.507990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbK9R-0005sl-7u; Mon, 04 Apr 2022 10:41:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298242.507990; Mon, 04 Apr 2022 10:41:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbK9R-0005se-3m; Mon, 04 Apr 2022 10:41:37 +0000
Received: by outflank-mailman (input) for mailman id 298242;
 Mon, 04 Apr 2022 10:41:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbK9P-0005sY-Ra
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 10:41:35 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb4c61be-b403-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 12:41:34 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb4c61be-b403-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649068894;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=uhJBpq+DahclFodW1RITXMAAJa6OZlPb/T/RNd4e1IA=;
  b=U3yK1rNtajjjuq7J044uXvVUGi2EVtRpuFXlGeUn9XGKdRk+2wsC9J2K
   nbBhLTWbqJLCC6kR8PnM1eaZ/kCAaihMUe14XQliHhIG6fi2Gt8j46dIF
   NJQvyPjee+34JuCAAxx/3CVpaQ019ccFIFtkpOwx+HLHHjETrCUBtSXoW
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67357433
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Cu7KOqj9HsumwySL22smuBsXX161XxAKZh0ujC45NGQN5FlHY01je
 htvUWvQOKvYNzHwKN9waIW/8U8Ov8DQzIBnTFduqHgyQ3kb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vR4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YRwxN6HxsrUxaD8GCAZ5HJ10+KXOCHfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiBP
 JdGNWE0BPjGS0ZsYH0LBK8ioNzrmnvgfTcJiW+a/bVitgA/yyQuieOwYbI5YOeiR9hRn0uej
 nLL+SL+GB5yHMeE1TOP/3aoh+nOtSD2QoQfEPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M/pPJ
 kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwB6J4rrZ5UCeHGdsc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYWmF/7uph2KeAg5LNkgFRB82TREMyta29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+ysjPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWB2jaD/LF7rlxBHkJPm6gKvVmSw28zb645lcfBO
 hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIYfOsIpKFLbp30yDaJ144wLuBJx+U3YE
 c3FGftA8F5AUfg3pNZIb7l1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3mGmaZOfAtiBSVqWvjLRzl/K7frzvxOQzp6VZc8ANoJJuRYokiivryTo
 SHlAx8BlwKXaL+uAVziV02PoYjHBP5XhXk6ITYtLRCv3X0iapyo96ARa908erxPyQCp5aQco
 yUtEylYPslydw==
IronPort-HdrOrdr: A9a23:Z4o7la/aj4DXD8CGh/Buk+Ewdb1zdoMgy1knxilNoENuHPBwxv
 rAoB1E73PJYVYqOE3Jmbi7Sc69qBTnhONICOgqTM2ftWzd2VdAQ7sSlLcKrweQfhEWldQtq5
 uIEZIOcOEYZGIS5a2RjXjaYrQdKbG8gd+VbIzlvhFQpG9RGsVdB1ATMHfmLqQ6fngOObMJUL
 6nouZXrTupfnoaKuy9G3k+RuDG4/nGjojvbxIqDwMurFDmt0Li1JfKVzyjmjsOWTJGxrkvtU
 DDjgzC/62m99W20AXV2WP/54lf3PHh1txALsqRjdV9EESlti+YIKBaH5GStjE8p++irH4sjd
 n3uh8le/9+7nvAF1vF1SfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqAx7I
 t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1TwKpsKuZPIMvG0vFnLA
 E3Z/uspMq+MGnqJUwxh1Mfj+BFBR8Ib1S7qktrgL3h79EZpgE686Ii/r1uop4xzuNNd3B63Z
 W2Dk0RrsA0ciY3V9MLOA5Te7rANoTyKSi8Ql56Z26XUZ06Bw==
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67357433"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CenCBjiv/AL8yaWtExKOBsubHi4XCwzCrrqwJTraFIlw8/Haf+PNWAeM9xGI1F63ulvE5Ii+XmC7a0SRc4cLO4hTGNA0ZYI/keie0VJgpQqdEyfgq9zrn5yQcZN2pQex5q5tby2++w6qVhhlF2LDGgS7RG+14MnkRM8FCG2Oq1uGC0WfcH17H9n4cu1DVKPXa6mTCXgZOgWu+8/GsNrQoTQ9tD70gC7H7rnAqrx5T56fme8cwEZfvkO4NXf7Gd34ad7YSVNuVHMkecQFIR0+MGVc8E0KmFPR3GxFVTf2VCPMpArxc+oOr9Dk4SFDX9rxn1T9BzaVxn7uuj4sCMLI+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=T90N2Kp4KnZ1HpykkkoYeJN1vbz958iNVPnDyEk4R5g=;
 b=oV4QnSp6JwSi4eJ9gWZ7F4FYJC9T0qgyGGIuU6+qbihsO+dQBIFatH3z9wEHV77PLJ3MtmOOwdA2ASlV+lz03A8gJ2ctAUF8oEzQah4DajQWKby0FrdAIWBvxtXl97lf/tIr0LyCXuv4rdskPk2DBMmXQ/0hkUP+KyzMzT1PjsfNoTQQaRFMHMiAksAQXaDa5ykfADVQNfJ08/QkjTqwzKDnp+wrNrOeowBtjRZ216ihfEr7+ui6vyBe/gdUBsOWMStXz5pCNofq08i3JVXcWeXbs5jAcNXRBOonERZvUkfzIB5X1Zuhi7vQulCIR7ur8LtXTz1YPUywen3kHp5tpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=T90N2Kp4KnZ1HpykkkoYeJN1vbz958iNVPnDyEk4R5g=;
 b=f4tInBrFQJn8A6YwZ5cqnwZYUP6BfjAijD/0F2yyAR9ot3GM+OZ2Q1IF6Cf9vXQTAvstB/7xlm4Q7QQWgUjp37iSwVPxmYCGzNxBRcAco8zrivuMBKsQ5lHpxQRQ1QZ6n3mkJ81Q32szu2QYRC8cjBpV5kUpHLpkHn6v//8lLkQ=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>
Subject: [PATCH v2 0/2] firmware: build fixes with gcc-11
Date: Mon,  4 Apr 2022 12:40:42 +0200
Message-ID: <20220404104044.37652-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0265.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a1::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 46a2222a-cb82-422d-89f5-08da1627ace3
X-MS-TrafficTypeDiagnostic: MN2PR03MB4669:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB466980CBBC07145401DE26098FE59@MN2PR03MB4669.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 04Et60iqdaEmdUN570HelOwKzN9J74TwUl3p3HK9JG5OafcD0ntOUtNStnCZB9spjR7hFFRFRgXqmKXYj6TxYBwl8i8gQSUMxIa/nw92qJ6hqwiYojH7BrfGD8OwtB+asXpygass4amZoAxBE1PRpzZXSJbMADq47nt1IfiCdSNzhgNtsbkzOi9KNL2tigNgIYDfEN17LmStGVuc7fheAIvEVplpJQ0w5H1fKfrj6vl1u3LCRbJYTCZhWbWWnZhG+fPSCkSpijOlox7fZOeapYMymLoD+dItnXIduVgKgslN/YO1g5PT/arNx51xlEh3YB8gMIhbq7/oz3ui9Z1IyvM4WOTMHgBViTE8AuImv9UM2mG+xnarkhNoJYH3PPljQk7DhgVYIRUXGs6tPG1suXHf8DEdVzWj0X1bQiL8KpZJX28cD5YZdCB4FSetYlrrgUlQIHuEdfzMl/58sDQCbmv55EbtBPImtSyTULDkEvw1xEun5kE4qEfOn6wJQi7n0UuGb+9X6aJ0sPBzQ6ZhpgtI66I8zshIUXwx22jLDYw4ugPMQfEi/W5EnGreE9TO99lBGhNLf+sXy7a0XR3Ks1C64inN1wHqh7HG6EzTMgT4u1EUsQCXUcrApOaXPRjAInOnsPHEsSo5zAjyLd/TLA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(36756003)(2906002)(6512007)(66556008)(8676002)(4326008)(38100700002)(54906003)(508600001)(5660300002)(66946007)(66476007)(316002)(6916009)(6506007)(4744005)(6666004)(8936002)(1076003)(86362001)(2616005)(83380400001)(186003)(26005)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmlVVUlLc1JnL3pMV21XQ2txcUN5S2pIanR6bjdIOTVqZkJhbVYrQk1SZTds?=
 =?utf-8?B?dHFxZzQzQ3Q5enNmUzdnb3l4ZnVEWHhBUU5UTmMyZlE2L2x2VlovNzVUd21o?=
 =?utf-8?B?SU10VFdHOFVpUEVST0JSWUQzMnJqR2VGSVlOK0ZwbVJWUGpwTXBUbHVqN2NU?=
 =?utf-8?B?dW00ZEltbjd2clBkN2VGVHB2NmNmTWxERWhST2ZONWdwYW5HdkZUQzVRbkRm?=
 =?utf-8?B?bkNTRGRhTUlXRlVjUHV4ZjZXTzFLQzhENk1LdTF1N3BRMDlxMmVYUno0R1Jv?=
 =?utf-8?B?VFZZYWthYUtKUEIyTGpMMUtQbUNLYTdmVm5sUWpqY0xTTGhPV0ZyRm1XbGlk?=
 =?utf-8?B?b3ZEUnNrK1Z0UXlpUXVWTnJ5dVBWOVF4d2FZZFNLQWJOVG90dW5PdTY4Wjlp?=
 =?utf-8?B?ZkRVNUxTUHYzaVNYemN6M3BWaE1wdHYzcjE1UFdoNjQ5NkVTYnB3LzdwTGlm?=
 =?utf-8?B?MGU1QTBmS0V1TFJkMWZkSkZVY1gzRSsyQWN3YmQvd3R6eG9OUDFlQ0lPSkts?=
 =?utf-8?B?MHZvT1RsNk4xYkJGa0Q1aERwWjY2OTFJNXdROFZCaU4rSlVld1BnNDJzRlI5?=
 =?utf-8?B?ZVNrK0ZyUVZmWXdqVFgwQVFhVUtGNGVTdG1yVURZOVM1RFBBQkFwRmJ1a0xD?=
 =?utf-8?B?dkFWVFVtZmNFYXJRblJONnVZZ0p6cEZEdG8yMVhZcGVzMlREV1VXcFhOVjZ5?=
 =?utf-8?B?b3dSM3VWcU5TWHdHUGNPdzFXRkR2cmxWWHlSSkR6UWdsTDdVVk51a0xOYk9D?=
 =?utf-8?B?T1ZOajlMTnhkcVN4UVZ1MnBVeDJUbG1ENEJxWmFzNm85V294MDNLUlkwOXdR?=
 =?utf-8?B?b2NNT2hBaTNKYUVFbG01UERoeDI0dG94c3ZEM2pacG44YTIrdWZsVk1WWnFp?=
 =?utf-8?B?WkdjNWdJY2NueUVneFhpTGYydjlXOWtEaDkrSVdnMzVucGZwdGdFTTc4dGoz?=
 =?utf-8?B?TEFrcHVlZmRRREFtbGtIaU13NWlyTEVMYXhiVThHM3NCZ1c1cmxPQ0lvWXRy?=
 =?utf-8?B?cVppUEx5WkxQamJGZWxBc2ZUWkdaT3g1cFlZSnV0bVZzVjY0T3I4M3JXZFBV?=
 =?utf-8?B?QytiV0ZtMXUxSUxaWGNidnlTNURBdkxIeXdYNEF6dHZGNUJaelE0NXVqMjdQ?=
 =?utf-8?B?dyt3Wk9QODFYVGo0ZWQ4OVI5NmN0NGV2Y3JtRVZWWS9OWXRsZUZUdUZxbnNl?=
 =?utf-8?B?bTNZUUJZbTB5cXpWblZNUEFzT05BNFU3bG92Rkh0ZkhxUjhvT1owZVhKN1po?=
 =?utf-8?B?YXFTYWZwdHNKYUNCQzA3c0tVamJPdmJHUm92cS9pcTdpZHZYbStRY0JLbmlm?=
 =?utf-8?B?ekdWa2hjUUZXZ3dxUXYrQW1YczNrdm9jQUxGYjdEMGNLUmhRZFdqZmJGUXdW?=
 =?utf-8?B?dVdDL1ZIN044M0ZBbWhTZ3RySHNOaHl4V3QzaElnSkcwREdaaDhoTVlRK2ll?=
 =?utf-8?B?THNmem9ZVUtKYUZEZlNOekIvWGVtNFQvMGh2VW02c0JCeXh4eXpuY1Ewc3FE?=
 =?utf-8?B?VUowZGVCSVhZbTFETklFeWliV200cDRuZW9DMVRCd2I3NmVhQk9TQnRWOFhC?=
 =?utf-8?B?VVNFbVh0NWxMa05rZDVUV1A3Zjk1dksvVklxSmNHelMxS09qM3JTSGppRWs2?=
 =?utf-8?B?K09uNWRaZ0xrVVRTbWlLVDFqT1dtZkFPdjZhMzlscnJ0b045SWNMUlllSzdw?=
 =?utf-8?B?QXVQUmhoWDNUc21zL1BVK1A5cmhzK2FYMGQ1Y1RLWDhZVjRjdUxHWnV4dmhY?=
 =?utf-8?B?bVoyYTRsQ1NhdHRIbzJvTm5jSnBZcUpVTlRoV0VkcWlRM21VTW1tL0FvMWRT?=
 =?utf-8?B?VTd0UGVsZzBGTlRlbnhLVnFNTkc3R0Z6SEZIWHBkN29ibVBGVlZQbVpRamVY?=
 =?utf-8?B?Umx2eDNzRmJ1R2RRVWN2QUdMbk9rcXNvSHJaNGpIZEJ3TWpyOXV3eEZ4UHFW?=
 =?utf-8?B?VzlzS1lUSHNhL3pKdUVnNFBibVB1eTFvQ3dlclVBUWJtTXl5c1l4SCtHWDZR?=
 =?utf-8?B?TU1CMkwzSnoreTBTL2VlRnVmUjVCeGpZMitzQm9DWXJHcnVQMSs4NllnSDRG?=
 =?utf-8?B?VXR6YmJ6QUduODdFNUVUeUFRNHFIQzFmemc1WXJ4T0VBVXNiblhPZjJ0N2VW?=
 =?utf-8?B?Z2ZBdno0K0RCN2xIMGxablVaMU5SUks3MVJrUTExSnhJbmFsazRqaEdvcDJV?=
 =?utf-8?B?TzRZdWE5ekdWTkNHUlQ4My8xcWJWNzZ4bUoydytzbzU0TU42QW4ramowanRK?=
 =?utf-8?B?aGtXaHpiQ0c1a2ZTbnFzclc1YUd6OW1lNEgxQitnVjhzYjAyTnJqWFRja0Jq?=
 =?utf-8?B?d0NnbHZzZHdJMjFvdDhCMVNnVE55WU1pcElheHVGbDFTa3FjcWY0Z3hYYkcy?=
 =?utf-8?Q?wW6gArfLuCkROmzQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 46a2222a-cb82-422d-89f5-08da1627ace3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 10:41:28.7099
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: whc0qick6vj8E7t8TGRRnFOzj3SOcQUiCryom/0xYiwGXUda0/M23Ny+8fYpV6xDla+NKHPGJovijwQI/+NWYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4669
X-OriginatorOrg: citrix.com

Hello,

The following fixes some firmware build issues with gcc-11. Note that
dropping of .note.gnu.property section could likely be done in the
linker script in the hvmloader case, but rombios has no linker script
and such note is causing a non-working image. Other options could be
using objcopy to drop the section, but those seems more complicated than
just using the assembler command line option.

Thanks, Roger.

Roger Pau Monne (2):
  tools/firmware: fix setting of fcf-protection=none
  tools/firmware: do not add a .note.gnu.property section

 Config.mk               | 2 +-
 tools/firmware/Makefile | 2 --
 tools/firmware/Rules.mk | 6 ++++++
 3 files changed, 7 insertions(+), 3 deletions(-)

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 10:41:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 10:41:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298243.508000 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbK9a-0006Ap-F4; Mon, 04 Apr 2022 10:41:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298243.508000; Mon, 04 Apr 2022 10:41:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbK9a-0006Ag-Bs; Mon, 04 Apr 2022 10:41:46 +0000
Received: by outflank-mailman (input) for mailman id 298243;
 Mon, 04 Apr 2022 10:41:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbK9Z-00069z-4B
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 10:41:45 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cfe990f5-b403-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 12:41:42 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfe990f5-b403-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649068902;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=T3IUeHOAUwH5jnaWVMPVxz4AYqEm6BYtGI9yr57oZZE=;
  b=CxEzMaD2pLnzPUIgOja4HjndXuK4WjiSNaLMRzV7gD3j5xmWW6DUeaxk
   2CuOSR4Sw+cwiEeKa4ldxyqC+F3+Iev/eDKxna0WpS3iE+skgLu4uG9jI
   NXHy2M3H/a2hErVUlrJuItygfKCM3jrrZnwoR4sD2Au1hCXvRBVA6pSeH
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67825388
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1qSQLKIYmf8AP2L+FE+Rq5UlxSXFcZb7ZxGr2PjKsXjdYENS1jxSn
 DROXGuGPPncZ2DxLtl/Odzn8EgAuJbXzd9nSFRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NJNicCyYBU5BbPJk78HShRcQjolbKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glv1poTRqaOD
 yYfQRlkMyziUjRPBmUOIrcSvNyj11bEbhQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3nsOGm3XKmDZVUkdPEwLm/7/p0SZSRu6zN
 WQT+hZyr4Eg5He1S9KmRQS1pC+f5U8TDo84//IB1CmBza/d4gC8D2cCTyJcZNFOiPLaVQDGx
 XfSwYq3WGUHXKm9DCvEq+zK9W/a1T09dzdqWMMScecSDzAPSqkXhwmHcNtsGbXdYjbdSWCpm
 GDiQMTTatwuYS83O0eToAuvb9GE/MGhousJCuP/BD/NAuRRPtPNWmBQwQKHhcus1a7AJrV7g
 FAKmtKF8McFBoyXmSqGTY0lRe/1tq7faGGB3QUzQ/HNEghBHVb5IOi8Bxkkei9U3jssI2e1M
 Cc/RysPjHOsAJdaRfAuON/gYyjb5aPhCc7kRpjpgilmOfBMmPu81Hg2Pya4hjm1+GB1yP1XE
 crLIK6EUCdBYYw6nWXeegvo+eJyrszI7TiIHs6TItXO+ef2WUN5vp9eawTeNrlptfzcyOgXm
 v4GX/a3J9xkeLSWSgHc8JIJLEBMKn4+BJvsrNdQePLFKQ1jcFzNwdeIqV/9U+SJR5hoq9o=
IronPort-HdrOrdr: A9a23:qGCQg6oApj2Rrh42zxP6naUaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBfhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSpQEIdxeOlNK1kJ
 0QCJSWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYWcegDUdAf0+4TMHf9LqQZfngiOXJvf6
 Dsmfav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QZiApIs+PvP+UpgNdtvpOfHHclAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67825388"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jFegkCdlijiqo34ncNwKI5oXINDJkEsts2JJyVvW98pqe2NawqCAExqLpPPIdrGVhL/2vIgMeTav9yWYMXTh2g5qLKIV7UV7JqzYn3TOSXAdW8R9x0kWPUfijMIrZ6DZy4VnBoJdtDHJIZxZou2rSDkDPm+3gsZRC2WQyJjZtrwSiXTzeGTER0KbKsH1AN1GA2nmQQ1A6SYsrlX5jmhLqlKCaRZLE3tenfvbLCGAKY8hJyPetnXNBGxrXAmu/BtnsFkdYPac3qRbnmeYehjQPcUzpv0pSHF7fL+5MTcfeV04pxTzcLZ8KLYU+6Wrwp0meb1lTO1BkoUQJmQ7RPGQJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OyBbGihEUGhAAN4xDkKaoxTfhhCkzCzAGn/Ff7r7+o4=;
 b=TPdjwmq2KC/9WWMCwZjdT7KfvXfz/1JzpKuaqv2duImQKy+7Uyn/634bK+rmZ1Ml7EC+sHvYvOmajWBo512S6P/0V43EFrHh2CibYDD1fLXQzvfdb+mAIXQgay4fZ6KL+PjKGLU7e8l447deAv5TIH4FOUBVrTrSOs9zAXpxZvgp6QF5yHw6fuf69a1N16Xeal0hTC9sx8atxmI5pu7S2+hxrR8USFe4MLaAkro5+yqCJ0qtAYdzFCfghZcl4bjDsJzeZBNIP7eHl2FAfQGM9PFFlYG99zZP1n9KhuLijPXi7vrC3TezYU/msfrmjykc1S90btjtpskCiLnqQ4aDtw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OyBbGihEUGhAAN4xDkKaoxTfhhCkzCzAGn/Ff7r7+o4=;
 b=gdP4XWAj5gKaMoSJRdsZY6Rn7xOkWglVsj+Jy0l+E8uAwGsCP2EjtnrV1AjimEzb1csrnIQ6utW8nvW1g759yMAj7uGk8Q0aNCQaC3UycH0o2j1gJmNwoh5R2SoWClzvF8QRR/6a+1pKC+I9m3D6WB1Ln99n/HMg619c4/J6xGQ=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2 1/2] tools/firmware: fix setting of fcf-protection=none
Date: Mon,  4 Apr 2022 12:40:43 +0200
Message-ID: <20220404104044.37652-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220404104044.37652-1-roger.pau@citrix.com>
References: <20220404104044.37652-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0125.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: af3af710-203d-4ec2-ffbc-08da1627af39
X-MS-TrafficTypeDiagnostic: MN2PR03MB4669:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB46696E146B5F06438C20D4518FE59@MN2PR03MB4669.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: gcB+Dd4si7tr1z1e3wMAhJ70hzi3vDMxwOtZaHeHGIkA4lrWLnseRfGWHh1EidvcNq7343KLUQgujj1/BOSFgSFbYJf/lgi4DfABFyIR0DvIDt2hN1TahkSeIWQd9fxV/hxa/bL1qAr+fSNd0Pq4z1pWyM9WlJ/VNxIMeIzuFiPCHc7GXTmJy8XN/gACoaBuZ5Ah9OtjtkiRVeW/PLctgZJNTKcz20iqTT0UgnIRnGtZRkdGEyJg1l8aRDQ7Uy4vNeHNvCZqpnFrlKXubVVbZ2LL4UBmkRyFg6ayIno/zHKHGGvhRIM4UW383jwASkTJRPZmWxUPgUNX78b4/tiHdP9wqp65BbJFPuUmPzUOY1dOx08VtkBvzRifIlmXjOSvIQoXw/5OOoNA4fvbr/Ik/6AzSUlZvV+zco7rnkcJYjBpBdXXIaebdfgRoy6pRrXoayZGuBmbCIxHi1m5bzn+vuxNDqr79G09nzUqDQKxx1YKrkTx7kzfxbNfgCV073vpP5tdmCVsnadIWB8P1j2zY5IC/LMpVF+Pi5tZrZSjCwDT8FJGkG87Fwtb4viVGM7bmXyAaqaPakPRd6lVNa4NBgC50Rctqigzi7gPx1oHPk9BaLFZnyqxgjjfFkYu4bV/N20Xd0fqZb09d8GAXgIjbQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(36756003)(2906002)(6512007)(66556008)(8676002)(4326008)(38100700002)(54906003)(508600001)(5660300002)(66946007)(66476007)(316002)(6916009)(6506007)(107886003)(6666004)(8936002)(1076003)(86362001)(2616005)(83380400001)(186003)(26005)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3YvWCtFZ1ZxejVRN1Bxd0F5TGFVRldHY0UzQWtPdWU2U0hrTDRHT2xObmlD?=
 =?utf-8?B?L2dZSEtnN1dweVZsRS82TnlFcDRaMWIxNk9CYWJKZ2JKUk5VeGFSYXpLNDdy?=
 =?utf-8?B?N1lUU0ZWRXJZdVhvRjBVak15QVd6WVk0YlRWY29SY0RJT2lnVHg0VjBrOENQ?=
 =?utf-8?B?cXhSeG1IYjkyVzRaWnR0c0lTcVNoRkl4Tklsa2RDSHVDTmtLTnNsOW55VXJ5?=
 =?utf-8?B?WGhScGFNVVVMbG9nU3FaQ1J3TDRzMFpKdFBid0dyRVhnVGUrRVZYSVNZRTZU?=
 =?utf-8?B?ZnBiMTdFTThwSnVQcDFCam9nOEdKdDI1SG5qcXYxWVl4WFdvbXhxOGlIUU4x?=
 =?utf-8?B?cCs3VFhKcndpclJnNGlIeTkxK0tnU3lOWnRLYnYrK09yVk5JV3hOa0Q0NUMz?=
 =?utf-8?B?akRmRDRTViswVzRWMjBPV0IvSmlFcmRsY0FpdllMQU5tK1h4cC9xY01peUs2?=
 =?utf-8?B?c1daS2g1cEo4VjE2UStwOXAxMmJEUWVlUnlTOG1WWndsYW9KbVZpV3IvL2dH?=
 =?utf-8?B?VkduUHlJQjJMajlDNmxBRkNWUkJMSSthSnNoYkI1TUJzenVqa2l5UmlSYUJj?=
 =?utf-8?B?ZjZvcHYvVXppVzIvcUFISDZTMVY3bjBId0dqNEVOdG4vd0UyUERMK0gzMkxS?=
 =?utf-8?B?alFNZVhLaG05NE8rM2ZBUDNra2oyKzc0VU1HdXp5T2VWcEpHSERHYUR2SEEx?=
 =?utf-8?B?K2N6U0t6ZVZQNStvT0c2VUxSbC9TcjFiVEpVc1d3VGJqcktlNzlSNVRSWTc3?=
 =?utf-8?B?bjlYTURieEZnb3ZYMFhRb3JUVGhyeG5ENTFzbkhabnRaSUo4bXBiQ2lxWmZj?=
 =?utf-8?B?QWt0SVJocFRaWUZYZG5BLy9IWUpLU3lXdzkzMHBxNS9lc3BhUjRYN085MlpD?=
 =?utf-8?B?WklGeVpPSW5tR2FqVlJjc0tDQ3NOV3k4NXFEZkw1QzRjRHVRTzc4aFJqS2Ex?=
 =?utf-8?B?cUdHbUZldStyMXpQUUt2VktvS3hGeGxLemlOSkJncTZDZEZGY09HYUFoKzR0?=
 =?utf-8?B?bGRoNjFXYURRMkRIR0ltWGVoSGdhZlpLZHl4Yk9ycmttazg5cERJNnBhcVND?=
 =?utf-8?B?ODlKWGp2LzhUenY0TTBlL3hOaTI1VkM4Qzh3QUVQRDZNamk3NG9QUEIwVnBr?=
 =?utf-8?B?cFM2Qy9UZkdNampsVHJaNkhtM3UvdE4vUTZYeDI3K1p5NjZOdG1uVEp4MmNP?=
 =?utf-8?B?QlhLVEhxODhJVWxuWEFPYUtrRmF3ZUVCTnJIVG80RlVOOStleUl3VUMvdFNS?=
 =?utf-8?B?MzF2YkJUZmM2M1FkTURZdzUwUWtXR1lFRnFtUzR6MWJxRGQ1ZHNKbEgydzV1?=
 =?utf-8?B?UXB1QmNDYjJqM1NUdjg1azQyV01oWFNyZFEzYjVLeUNvZ0tlMjhkaVEvVmxR?=
 =?utf-8?B?a1NkNHRCcGNnZ1RvQkEvM2tiRTdpdlQxSTNRUXNVSVVFS3lTVTY0bXFBdDA2?=
 =?utf-8?B?WW1GTzVSNWdRdWhETTFDNmZrMTFqcERhOW5kZEZiaytzMGF0Szd0cEJpZW43?=
 =?utf-8?B?QnozUkFpdFZ5UnVxam1JMzJ5RUJ2dVk4RXY4Wk9RVWJ3N25oNnBHbGdvQVdr?=
 =?utf-8?B?Qko3czVZdlJ0c1N1d2RTTm9zOXJ2WGtGS25za3NLbWwxVW91RGFqNHNjNnRj?=
 =?utf-8?B?SWg3QjRoMW45ajB3ZjRZYkxaYXA4SkwyWE5sbFJaZnQ4SWp1d2RWZzVEN21a?=
 =?utf-8?B?eENmOEtxRXlKcXdIcWpVQmlHZEZqTTF5Zld4L3NFR1hhRSt2Y0hJSWNBc2RO?=
 =?utf-8?B?dHEwTFlnV0tTN3dYbzJobFFFdXlWT3lPeTROaHRqRWpDWTVlMTFpYkdROXpx?=
 =?utf-8?B?aFhtMGRnbXVqVENGTUpiR3lJU1pieTU0YUo1OStWbnBwNGlEbStkSG9WQVBL?=
 =?utf-8?B?VTZudUdzNnpwUnR3UExZUTZSdlhDUzZhOC9BU3hQTFpVWGJMVnpuaVlJalVK?=
 =?utf-8?B?dEhBMjJIcFA1TXNGaklOSHFsWXJKNUErU25xdGZ0VExlYjQzdWtwZnhZbkcz?=
 =?utf-8?B?aXMxSmZHbXpLRzNhaW5OV2tuQXZ4YktWNGZjR2NVQjJ3WkdnNk5OR2RHazFO?=
 =?utf-8?B?ZXkyODBPTjVJcEp6cXMzeGI2L3E1b0tFSFJ1ZCtjalFmS2YyQ1FyNEpBdUl3?=
 =?utf-8?B?Z3R0SGsxNDUwOGRVbHdGQjFha3N6TmxYbXNPY1EyWWtnU0xHczVBY0RrR3pV?=
 =?utf-8?B?dC9FMUZucVJpUE1YYU10REtkTS9tS1VjTnJiSnNjOXpiOWtjUGdWVjZqdk95?=
 =?utf-8?B?WG5raDVyS1JNTGNRSmp0dVJXZGhRTzdWUG1vWmUxamNTdzMzWGx3eWt1RHJU?=
 =?utf-8?B?UnNaWjh6bTR6TU1QMmF6c1dRdXRkbldmRElTaW85aWxUVm9sMTFxSy9RelN2?=
 =?utf-8?Q?47sDNqNf7RkcTi14=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: af3af710-203d-4ec2-ffbc-08da1627af39
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 10:41:32.7257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QJc3ASUxZoHqCTH1k+lHgtxityfP0FsoAUKpaGprDT+HRHNjqCGHWNF96zfcdWgvm5Oy0c0N6stY7N7Znuz1LQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4669
X-OriginatorOrg: citrix.com

Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the
Makefile doesn't get it propagated to the subdirectories, so instead
set the flag in firmware/Rules.mk, like it's done for other compiler
flags.

Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Add the option directly to CFLAGS using cc-option-add.
---
 tools/firmware/Makefile | 2 --
 tools/firmware/Rules.mk | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index 53ed4f161e..345037b93b 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -6,8 +6,6 @@ TARGET      := hvmloader/hvmloader
 INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)
 DEBG_DIR := $(DESTDIR)$(DEBUG_DIR)$(XENFIRMWAREDIR)
 
-EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
-
 SUBDIRS-y :=
 SUBDIRS-$(CONFIG_OVMF) += ovmf-dir
 SUBDIRS-$(CONFIG_SEABIOS) += seabios-dir
diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk
index 9f78a7dec9..c227fe2524 100644
--- a/tools/firmware/Rules.mk
+++ b/tools/firmware/Rules.mk
@@ -15,6 +15,8 @@ CFLAGS += -Werror
 
 $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
 
+$(call cc-option-add,CFLAGS,CC,-fcf-protection=none)
+
 # Extra CFLAGS suitable for an embedded type of environment.
 CFLAGS += -ffreestanding -msoft-float
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 10:41:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 10:41:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298244.508012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbK9b-0006RN-OI; Mon, 04 Apr 2022 10:41:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298244.508012; Mon, 04 Apr 2022 10:41:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbK9b-0006R1-KZ; Mon, 04 Apr 2022 10:41:47 +0000
Received: by outflank-mailman (input) for mailman id 298244;
 Mon, 04 Apr 2022 10:41:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbK9Z-00069z-St
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 10:41:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d0cd22be-b403-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 12:41:43 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d0cd22be-b403-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649068903;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=o1g3NtJRr/7LMB+Lp/Uv15Zh/4bOG2IVjPXu7yZ4VpI=;
  b=bs9iEoZuO3OphIcoltzx+pPyn3SSKUnUkRsipULGSimNe/YHj4BioXeB
   UUyL8qv+Kj5ECeftS39xJn4xa5zCJQRaOOvo4Ft196E08z7CHksIdOY7W
   Seqvby9ZS9NvMMHRbC5/dSp0G7Oded2N5wkgx8/4vZ4hNF7sm3A8N4Mzm
   g=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67942405
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EI5KJ69JniOtPiSklmR2DrUDv36TJUtcMsCJ2f8bNWPcYEJGY0x3y
 GsZXGqHb/2ONjf8fNEjOt60oU8EvseEz982S1M6rHg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YDlW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncXqYAl4PIOTou4mYRdxEC90Z4pr/6CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4RTKqEO
 5JEAdZpRDjpTgdGJVETMbYFgPqhgynRKB1k8HvA8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt7XaEluLJ2yThV+o6FqC89/NsqE2ewCoUEhJ+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxasvBQRRt5RGO0S8xyWx+zf5APxO4QfZmcfMpp87pZwHGF0k
 A/S9z/0OdBxmOTPYHzM9JnLlzmJCyY8LmEIPwgpShRQtrEPv7oPph7IS99iFou8gdv0BSz8z
 li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp
 xDocODOvblVXflheMFgKdjh/Y1FBd7Ya1UwYnY1RvHNEghBHVb5IOi8BxkkeS9U3j4sI2OBX
 aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CKyFNoAWPsUtL1PblM2LWaJ29zqw+KTLufthU
 ap3jO72VSpKYUiZ5GTeqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9eWGZimtsRtfveyC2Mq
 o43H5LTl313Db2vCgGKoNV7BQ1bchAG6WXe9pU/mhireVE9RgnMypb5nNscRmCSt/8OybeQp
 yHkBRcwJZiWrSSvFDhmo0tLMdvHdZ1+sWg6LWorO1Op0GIkeoGh8OEUcJ5fQFXt3LYLISJcJ
 xXdR/i9Pw==
IronPort-HdrOrdr: A9a23:Rag1/6jLX4IF0K118yichH1wU3BQXiAji2hC6mlwRA09TyX5ra
 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp
 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq
 DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II=
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67942405"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AOJPakCu2Bj0j+8C0O1aJ+vPtqQvyeMsPi+btR7FlwG2eZR2awSuUKjS27rX73fXPGAwXhgQGLHM1UhDkz3HIkXjabrx5v4f72T35seklbvefWrCfo2AEldCBWB4l+pd+aLo95b/jeekIIDe9eFL4/uyfIOIpFcz8GsIz9rSJpPI94ZDOSztri4mSygJ2CugoKW0dYuRU89bwGObMLxXOgtXWekVVM6kKSUG29LiU4pPDRNCf9n7VhYkA3+1J6GEiGGSDHrMQRjEp/0vobaxNZ1cvqsXhYHMnfX6JyGQFPHiR4uJ7PjssmbWbDx0YdVlIdO8NGX6iM5+2cMVOU2hWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TrO0NN/XdxEk/kybKpxTDcn096Mdh/YZekVSRdkq44c=;
 b=DVp4izW/EOEMmDayCcfwOQvhEF074lHa6eEKT70LHJzjCVolk0sFO9sAdPOM/cym66OJ99Mp1RH91SI+W3M6H7UoSebv0W6MqSR4J2EllLf7HW2q1S4D/pEgM4fDd5KLGXw2jdr+a/XCgJRD6GUxkpZkrByLtk/xzYi7kT9GSCaPcT6S+2+zKdrDG69npJlfWmzt1+wv9wE4Emglp4NlokTIUkjZxJoM2hCKDn7VVpGsHwVUY59qvI7EAFf1u7PjWlCsnREr89Nzg+o3j11xKcXKUQP4HUzbFt21oUIqHwpgXYUIJYn55Hv6Z2toInK6epFpoTuqYLbimpwrxsUBPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TrO0NN/XdxEk/kybKpxTDcn096Mdh/YZekVSRdkq44c=;
 b=gri2DVB7XH/wNkcO+ejUgwI+zJWzO52KiP0bMVn83inQw3K3RAaHdmgBTiDmWJvbFPXRqLMfwAanlaBmovpzh85BFCghDRxL2lmQGGQjHU8Du/VUma8U9GvtUX15GGfvEQ6iMXij9PzqPNEm/MYL+NmtC6YQ1Q8EoCsm3MtkPIU=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section
Date: Mon,  4 Apr 2022 12:40:44 +0200
Message-ID: <20220404104044.37652-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220404104044.37652-1-roger.pau@citrix.com>
References: <20220404104044.37652-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0219.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9e165241-ae3f-4fae-7a80-08da1627b20c
X-MS-TrafficTypeDiagnostic: MN2PR03MB4669:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB4669039510326AE187B1C26F8FE59@MN2PR03MB4669.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mWVignJRv1EZsK1YZ0gnQdC8wMNEn3j/Q2MoTWHmjBhdbTYMiw4/OiQi/J1tWeRk2n7qveDMgIJCoaxwHRPDhRgEgpVfRdG7MuqwXHB1IjpI7uIqBd2D6eYxYBqzBgxohNHqJ0lxy8EX6xCaU9nIRPI1UlcboOnKIXVM2+DnQuZ0Lx3IGUjcu76aylwoFQfKJttMlY0aOlYQ6/waA3FAm3p2z4bj7pumeAfdZwf2rcFQdjvuJdPq68zwJe8/vNdUWnWCHmVexHL0/wHqNYsF9Yu8HQmcR70up79CCPcTG53WK1AsDQbMCFZemY1wNMyEvYqYiL6S2OgRTM2///uBpDTEBRUBlI22fhAppmPidB1pm3vyfSLaelVJpHelezKhO2TTNQjdL4Dd1XEj5NQfUR5dyIZWYJbnx+3gnse/e87No2VvOBpJE38HShwd00dPB2U/xRjt7igWyaO95Jo5YdtaIAVPfoq/Oj+0gAyI1BattCzGw88+ZdUZvwAbN/E8w4otTIbIo0UkZRHww00g/rfx5ng+iViR3KwD+20t0bOmjJYqs38kOU0c8P7xINyIZVrJhD3uv+fp8CcJZm4cGTqFyZnFjuJkwfx4ea9687vuzP/IzUoUomWRSNAErsJOFDgH5LNH9Ro0PLLY9lINw43nj284ArftpzsC1qiuveP/MYuTYTSlngTMnCQoVsVYwyJqCM5DryvDUvHbIpUrXQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(36756003)(2906002)(6512007)(66556008)(8676002)(4326008)(38100700002)(54906003)(508600001)(5660300002)(66946007)(66476007)(316002)(6916009)(6506007)(107886003)(6666004)(8936002)(1076003)(86362001)(2616005)(83380400001)(186003)(26005)(82960400001)(142923001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mk5mMXBicDh3MElvMVhJbytSL2pnV0c0bTFiQW9mVEJQdjVyU1BrN3BjUGFQ?=
 =?utf-8?B?NGZ0elZJRU1LOEh6a1dZc3RXeXl6SVBRWWN2WE8vY0hHWHlKRjIyWFdVc3l3?=
 =?utf-8?B?cFJSM1FqeXY3S05sUFdTSlJabWdZN0lqS0VPRExuc0xYZWR4cXMrdGppMEdD?=
 =?utf-8?B?OU9GQlZVQld1TkVLZnNSWjllL0JDcXl1cmtmMy8wY1hDRktqMXRCSVRibzZw?=
 =?utf-8?B?S0JldnBWS0d6YWIyTjFrWDRUb2xFYUtSaGNlNVd5bDNWdVZYZUFHRnkzT1U4?=
 =?utf-8?B?UUY1S29Pd0RJMitVZTN6Z09GN2RZc2YyZVkweVFERG9Oa1R0YnJzR1hhZGVH?=
 =?utf-8?B?aUh2Y2ZFcFpJWSs2Um44N2ZlcmdVak5iWW1RY0RVeUYxUGhpUk02clI5dzZh?=
 =?utf-8?B?cE84ODIxUlBHTGxzU1B2RU9OTjRFUXUzbXhmd2VjMTFMcktqQ2hLRnJ1TjhJ?=
 =?utf-8?B?QmhIMzEyVXhyd1ZYVW91NzY1UTRLUWxLajFaNVZ2dlFNNUVFTHUxUERQcFRL?=
 =?utf-8?B?Q1lXZjgvY3gyNzhqaEx3dWlabHlRZm5aeE81alhZb1QzczRSTW5xVUJ1bk92?=
 =?utf-8?B?QkxsRXZxUWNtclArRE15RE1UUjlPM3hTMzF5bTFnTXJYRE1ER3hTL3NENW1K?=
 =?utf-8?B?YzlpTmNrekFuaDJCeU9OMEw4N2tGeG5mV0kvUGJ3ZU5Oa1RoVWR1YUl5WTZB?=
 =?utf-8?B?VnZRbXNJZ0VLODVVdjUrR1hQc2pCOEhJWkFFZDJ1bGZzWjBGaTdaT0pjaXBh?=
 =?utf-8?B?dUFWZUxOeUtIQzZmelUydFBRSm1ycnZmTHFseThKeUpWaHdSdXU2SkYwVThP?=
 =?utf-8?B?ektTUHhtYS9BRW93bFZ6SXhpMHN4MjdMNE95aStyTjh0WTMvL0tvejZVZWsz?=
 =?utf-8?B?eUcwUU1oMEdyRW9PVDJmc3RabklOSHZFZGFFeHJQenlQeVZnZXBuKzd6THRs?=
 =?utf-8?B?eTBlbmFwNUtmS25lNk9nOFZ3WkRYTDVxdHU4K1RyU3FOS1BNdnlzcDFSOVRG?=
 =?utf-8?B?eWQ0elpqanVFT1FVMkV2akJOL0FFK0xOVHRZbTJJZkhRNXRIaW01TUFhTkVk?=
 =?utf-8?B?WjY5VmZPSXRoWHpIK0l2a0VUT1VHOHBjRkVsa3d3OHkyWVZFUWtVa21vZUlI?=
 =?utf-8?B?emlGRmR3UTk3RXk3TUJObWprV3pGUjMvdk1GdkhqK3NtRCtzR2loLzhUY1M0?=
 =?utf-8?B?b3Y3KzdYbXcwNFljKzZMa3JyaUQ1VUU4aDdBcFd4T2pVWDQrRzBTR0ZWQ2V5?=
 =?utf-8?B?MnZYWW0yejlBWmlpRnFGcFJ3d3N1aHRzbDBXa0pTK2tLZEo5V3B6aWhIaEpE?=
 =?utf-8?B?VFExaUZEdC9XVE9KQUExajVvb0VHOHVSTWR6MUNpN2RIc2ZQTUtXdTlMVUZm?=
 =?utf-8?B?L0RvVUgzOThGaFVzVHhDOHduam9XUDZDSEdsdSsrT1VUbkc5TjFCT1ZGRTJR?=
 =?utf-8?B?a3lmWDRQYlovaW45N01xZUh3R1ZCUjBvYnhSTWtpYVlSWklsWUIzcWNMWWVO?=
 =?utf-8?B?SGxES0NGaktGdlFuRnhjVU1udVM4Sk5WZ3JublBaT1RKYWFBTUpEMlpoR0lE?=
 =?utf-8?B?aW95ZjU2ZERaSE1UQ0JiZ1hqSVFhRDFvd1pEMER6cThZVm9yQzJJWUVxSnhi?=
 =?utf-8?B?c3pPTFZIdzg3QTlCblFEc2pyWnIrWExXTXAzT0RlOUZ3dVFhRlN1cDA1Y0lw?=
 =?utf-8?B?ZnVRR3BvemlMazVYSHY5Z3d6WGpGQVpreFR3WWxqR3U1ZnlHbXZsYjNDam9z?=
 =?utf-8?B?eFNzeUg1OTBnYm4yTml4RjFNZXl2UXRZU3M5UytUVlJ2QytmQzcwZGFzUG9U?=
 =?utf-8?B?enNxcnczTmkreUxxcXZhdjJhOS9QOFc3SHRmLzFkTWU5YU94Sm5iZlJlVWpL?=
 =?utf-8?B?SFpzcmNXbFpuQjJ6TlRtVXN3c25mSDFlb01GYmsvOUFHQXlXaVNYaFNpMjJi?=
 =?utf-8?B?NU53QUJIZUtBT0d2R3lLdVdOeUpWTnlYdWtpcnlCeldBU0tlSmhRSElOazBl?=
 =?utf-8?B?dnRJWndCWVdta1NoeW16bVBsNTFWMG9rdHRIbXlwUzB6WlIrS1RzNHlJZTZr?=
 =?utf-8?B?Wjhxam1OZ2lMSzFWYm5YVFdYL1l1QzRwdkV2QTZGbms1dXhKSFJHMllmZkVG?=
 =?utf-8?B?RDlFOHVGeWxuOUFUMVB5dWIvT1A0Yk5YVWJnT2p6VUFybllJNHlNQnZpdm1Y?=
 =?utf-8?B?NVdRV1RnUVNJVjJsdGdwQzhKMVB6clEydldHSUdTWEpNMFpsdDJCdmMrQTNy?=
 =?utf-8?B?c1pxc0Q0UkZlYVpZUGJtcm1xVzdUMjlSdk81blAvaUJJR2d2bWtQN1c1a3BR?=
 =?utf-8?B?RTdyZVhLaG56STRRUFgvMFRiVW5HbkRkUkg1Rm9BTG9HTjIxTE9HbElGUkFX?=
 =?utf-8?Q?qpCTsHbfl7ezr7kE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e165241-ae3f-4fae-7a80-08da1627b20c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 10:41:37.4606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YVThAmDEYlrplitSsNTNHgagvpsPPjLRDZnkrgqQS7z5dL3sozZq6krIuS0fiLTi6qdvx/8lhOJQS+BA8w4FQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4669
X-OriginatorOrg: citrix.com

Prevent the assembler from creating a .note.gnu.property section on
the output objects, as it's not useful for firmware related binaries,
and breaks the resulting rombios image.

This requires modifying the cc-option Makefile macro so it can test
assembler options (by replacing the usage of the -S flag with -c) and
also stripping the -Wa, prefix if present when checking for the test
output.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Add the option to CFLAGS.
---
 Config.mk               | 2 +-
 tools/firmware/Rules.mk | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Config.mk b/Config.mk
index f56f7dc334..82832945e5 100644
--- a/Config.mk
+++ b/Config.mk
@@ -91,7 +91,7 @@ PYTHON_PREFIX_ARG ?= --prefix="$(prefix)"
 #
 # Usage: cflags-y += $(call cc-option,$(CC),-march=winchip-c6,-march=i586)
 cc-option = $(shell if test -z "`echo 'void*p=1;' | \
-              $(1) $(2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \
+              $(1) $(2) -c -o /dev/null -x c - 2>&1 | grep -- $(2:-Wa$(comma)%=%) -`"; \
               then echo "$(2)"; else echo "$(3)"; fi ;)
 
 # cc-option-add: Add an option to compilation flags, but only if supported.
diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk
index c227fe2524..278cca01e4 100644
--- a/tools/firmware/Rules.mk
+++ b/tools/firmware/Rules.mk
@@ -17,6 +17,10 @@ $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
 
 $(call cc-option-add,CFLAGS,CC,-fcf-protection=none)
 
+# Do not add the .note.gnu.property section to any of the firmware objects: it
+# breaks the rombios binary and is not useful for firmware anyway.
+$(call cc-option-add,CFLAGS,CC,-Wa$$(comma)-mx86-used-note=no)
+
 # Extra CFLAGS suitable for an embedded type of environment.
 CFLAGS += -ffreestanding -msoft-float
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 10:47:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 10:47:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298258.508023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKFL-0007kN-KQ; Mon, 04 Apr 2022 10:47:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298258.508023; Mon, 04 Apr 2022 10:47:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKFL-0007kF-H5; Mon, 04 Apr 2022 10:47:43 +0000
Received: by outflank-mailman (input) for mailman id 298258;
 Mon, 04 Apr 2022 10:47:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1Xnj=UO=citrix.com=prvs=086167401=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nbKFJ-0007k7-JU
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 10:47:41 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a4fbb381-b404-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 12:47:40 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4fbb381-b404-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649069259;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=/4MjAvIxt3HyhcIudSp3fr7j4stAeed9wQqncqYhGLM=;
  b=AHIgArF2ACEYPs7mRG3d140vkIeRKZ6PBdAyi05VgcZ5nLI4oLz7qDf6
   Pr1Bh0Fm2EdCQNDKGzr68fU4dG9UPrVILj5qhIQVFxlfWWzevnk8Vxaoc
   24GwkGEJJCxkGpIV+JEs2XIKLvFX58oWm5eXNRNPfVFnZ/C99fm372wq2
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67927137
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:33spQakoZh7gRSsv+IS3PGPo5gzpJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaCzjUMv3ZZjb2Ko0naIrnp0sDv5SBzt43QQNr/ihmRCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1/V4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYbR12Lp3lhNonXhBpTid9PKptxbGdCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNms1M02bPHWjPH8ZS5IQ372YpUPlYgF2qnLJvqoeyHPqmVkZPL/Fb4OOJ43iqd9utlmcj
 nLL+SL+GB5yHMySz3+J/2yhgsfLnDjnQ8QCGbug7PlojVaPgGsJB3UruUCT+KfjzBTkApQGd
 hJSqnFGQbUOGFKDasOiTy2RvEC+sxctBtxTEuoR1Q/X4/+Bi+qGPVQsQjlEYd0gkcY5Qz02y
 1OE9+/U6SxTXK69EizEqOrNxd+mEW1MdDJZO3dYJecQy4O7yLzfmC4jWTqK/ESdqtTuUQ/9z
 DmRxMTVr+VC1JVbv0lXEL2uvt5NmnQrZlNujuk0djj8hu+cWGJDT9b1gbQ8xawdRLt1tnHb4
 BA5dzG2tYji962lmi2XW/kqF7q0/fuDOzC0qQcxQ8h5rWzxpiL4Idw4DNRCyKFBaJtsldjBO
 hG7hO+szMULYCvCgVFfPepd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs+16Ko
 44GZ5LVk32ykoTWO0HqzGLaFnhSRVBTOHw8g5Y/mjKrSua+JFwcNg==
IronPort-HdrOrdr: A9a23:3/pTSazvcba6ysTV5641KrPwKr1zdoMgy1knxilNoRw8SKKlfu
 SV7ZAmPHjP+VEssRAb6LW90ca7LE80maQY3WBVB8bFYOCEghrLEGgB1+vfKlTbckWUnNK1l5
 0QEJSWYOeAdGSS5vya3ODXKbkd/OU=
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67927137"
Date: Mon, 4 Apr 2022 11:47:34 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 1/2] tools/firmware: fix setting of fcf-protection=none
Message-ID: <YkrMxp66sCDKRN/Z@perard.uk.xensource.com>
References: <20220404104044.37652-1-roger.pau@citrix.com>
 <20220404104044.37652-2-roger.pau@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220404104044.37652-2-roger.pau@citrix.com>

On Mon, Apr 04, 2022 at 12:40:43PM +0200, Roger Pau Monne wrote:
> Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the
> Makefile doesn't get it propagated to the subdirectories, so instead
> set the flag in firmware/Rules.mk, like it's done for other compiler
> flags.
> 
> Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT')
> Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 11:10:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 11:10:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298264.508034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKaf-0001kK-E4; Mon, 04 Apr 2022 11:09:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298264.508034; Mon, 04 Apr 2022 11:09:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKaf-0001kD-Ap; Mon, 04 Apr 2022 11:09:45 +0000
Received: by outflank-mailman (input) for mailman id 298264;
 Mon, 04 Apr 2022 11:09:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yWRt=UO=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nbKae-0001k7-Q5
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 11:09:44 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on062c.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::62c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1d629cf-b407-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 13:09:36 +0200 (CEST)
Received: from FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::11)
 by VI1PR08MB2815.eurprd08.prod.outlook.com (2603:10a6:802:19::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 11:09:13 +0000
Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:4b:cafe::1e) by FR3P281CA0062.outlook.office365.com
 (2603:10a6:d10:4b::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.17 via Frontend
 Transport; Mon, 4 Apr 2022 11:09:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Mon, 4 Apr 2022 11:09:12 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Mon, 04 Apr 2022 11:09:11 +0000
Received: from d4730c1e2bc5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BB1400E9-77F3-4907-BBBC-1276AB0EF08A.1; 
 Mon, 04 Apr 2022 11:09:01 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d4730c1e2bc5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 04 Apr 2022 11:09:01 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by HE1PR0801MB1849.eurprd08.prod.outlook.com (2603:10a6:3:89::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 11:08:57 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 11:08:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1d629cf-b407-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DQwH8IBEUrRZJ3j95Bvc2Gpye5E4DQUGIeWr5BA972U=;
 b=yac2UkcMLMCYLJ7yHGDx4e3gn8SbtLYzo4FkMRySFsfBKQCuT879+RGJqZjZ2B9WB9n1NBTZtuGmLVTAVTugdBWjEeEm3LrCgbNAwx24NYzHN6/8+6aWg7tY7m/02md2Vw2J5enHoYyRtrwM5srGg3jH/xP1H6Kvuef636Z4qoY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1ca4555f78140d0b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nh/2EMkdAKQjAaKJ2aaHVB8jnXrKD6YPF/S3j/ihl5STt1IE8/lWecg0bc3rNuQv5TYBhbf3/hTWhnz1XfpE6N6nOjp9w7K//FOkvFd9XqgetTGFTUQlq371nyn5uUf4OG9RtJVBw3du2P95Y5HjE1Kv/fcNZON+g56cUz2Nc/koV+WnAGb2gscJWfPsZp9EmX3NdEetIYezTnHmGUAoXhDr9I7zPVk3aUgc8HsT37zLwxOjNxJNOdzbQjzeZxIyjESTG0SG76/An0If4RRK0fM5ubUh4b5E09ild4/cmmff2OWfqmQHWwKY8NjRZgW1jSRuSukIA8BpeW5xUDYRNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DQwH8IBEUrRZJ3j95Bvc2Gpye5E4DQUGIeWr5BA972U=;
 b=EYXUud7uDoRWXUT5tIV0UCIqVxfiQmqtduWcicpuL7jW48y2EkX4+4U7yAAR4apMU6arhgXEloijzWtP2Zy0f0XPObbOG8S7JqvAppHvqybd7gMRnRampTlnLC7te+vGJ0ibXWgwDp0dlpvCHobC7NSujI96i2b+hxWn4wUrzW2XIA3TK18HgEL/CzvmvAAmk4pAKycfZibzxfPWuiCMxB2I532M8pDVZH0BXjUhYyIKQTMb87sQENFZFw4JnyozNMMhIrOvZ6Ku7kXe+W8Qs4cnbRSGmM4qT+VBHH0l9SLVRhvMvue+e8ZgnmdsETEfjo+5OtT0jzHcBZj6K68Pow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DQwH8IBEUrRZJ3j95Bvc2Gpye5E4DQUGIeWr5BA972U=;
 b=yac2UkcMLMCYLJ7yHGDx4e3gn8SbtLYzo4FkMRySFsfBKQCuT879+RGJqZjZ2B9WB9n1NBTZtuGmLVTAVTugdBWjEeEm3LrCgbNAwx24NYzHN6/8+6aWg7tY7m/02md2Vw2J5enHoYyRtrwM5srGg3jH/xP1H6Kvuef636Z4qoY=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] Grab the EFI System Resource Table and check it
Thread-Topic: [PATCH v2] Grab the EFI System Resource Table and check it
Thread-Index: AQHYRh5pIZEBfe5HzkWcQzrtRd3oyazfnIKA
Date: Mon, 4 Apr 2022 11:08:56 +0000
Message-ID: <989D1F80-2CAA-4432-8780-E0104B28A634@arm.com>
References: <YkeHXFvgB3MwXnuR@itl-email>
In-Reply-To: <YkeHXFvgB3MwXnuR@itl-email>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 9677414a-63db-4188-2fc1-08da162b8c7b
x-ms-traffictypediagnostic:
	HE1PR0801MB1849:EE_|VE1EUR03FT045:EE_|VI1PR08MB2815:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB281555CE7B1DFADA0ECA53AFE4E59@VI1PR08MB2815.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2AmGNQM9pXRiAsrfBAXKFXuRbIiRtIvxbjKRvWwkBjudm3bhD5pkGY/Lc0tQ6UXi9LEj3LbyDdJaz4a/qSM4BdvLX9xe3Dr4BRENQSJzy02sDDYfmkABgHN65PwgqxAceX7VJqBu/lUh3o2aW/5WiiM1/67LBH1n7s5v8RXT7sYUZJW3oM9yXy3jQHsTzEhvGVqBfw1o10vKpZVUgztBHeGSbft99SLSOXFiTvxbt2YKaUnueLvZdC5B6p+U/swWFKMpQFV3tBMTRvuZlxGMtg/bKj6JGWsCN/a+6fLW/LI9i427yBdGUYvaz4nD52/Pbljxj8GxI86aZyb5W15Fdk62M5SeO0HF0sz1DMXe8kAOaVlSxlrWovyjNCgA6evSqGaZ/kZ9finwSHbargSK6R5HJ7wAqt5Ra/Byb7ghTe+yi6TahD+R34XzPN8zOAjupT90ykN1+I70xnAaMbBif6kalhbqnT/dLNHozqgcvqR5TJkQey7DT4vCtStP907NCYwKYocqCST9l8m46tP7tKH2jC880Y/c0CqMisbYhODjQALpuYzZGH5TvNdsQoLaFYa9RX0Uoy7+SjKQR3hFIvs1/aWXVkkD8gG56rABtdwF9Q5Sfy+rUYwxteEvfiqI86eWwn5ODPS+a29tAcwVhKF0kknq1VgwVxyTyOXUYojkGhOmgEvWjwIQr4LFSv4C5bEkAhbDjs4U9NjhegA+2sAgLyYvyX0AK3J4KgH4h6opA1UKEgYRjx7tcVaXVPkWesYXFx1koqRZpxmQzh8sFqdrsa73YFBzEfmf+2iQBpoi/dDZuQSGLXRVHYzBtAXwYdTWIsf8SoAWvnV4CvwiHQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(53546011)(83380400001)(4744005)(71200400001)(33656002)(6512007)(5660300002)(122000001)(36756003)(6916009)(38100700002)(54906003)(316002)(6506007)(186003)(8936002)(66446008)(966005)(66556008)(508600001)(66946007)(4326008)(66476007)(8676002)(91956017)(38070700005)(2616005)(6486002)(76116006)(86362001)(64756008)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <078E7B4C39A63244AFB5C4413DA4918C@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1849
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4921b7d8-ec5d-48f1-7e77-08da162b836a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	B2QfCLUjcy7xCN+bqxuvlSMp23D+aPwlnxoU5xHiWPYgvqmEB8ZJ7fRVa5PQ2HPqknJ4Bz1Ic+elCEMY4QmX9barE4iA8ZG8tlBYs1l37VJg1o1K+DW6wSgDhwP8lEPIJTSiEUR1HmQWiQLcjiN+k2fwJNeHvUU0RyRp/D5w9OnlQViGS3WKOPtAJT96m4O6qqLwWVxqpcK+rTdJq9F6kIu/ZHZM9pvNyXEg/ODMfpUpQe53uyzlzea4suLSGVgAgDT2JttyPfb19GRUlRiea7NoGk3vc5cVcQQgPNykDCEQklZWxTnqqqDjhMA/XXgzn6TnvTpUCZ1b0m21ipF+6jDDFz8JeKexC/inIK2f1eVVsJMXlMMw6FByGK+ll/40ns19kY8TnEnNEH5pcageHZwHAm+NsTwPhiHj/j9N9K3sfLEvhFHwQ5cm/JUszNqiKQDtIM8hmsNJjAVHYTYO/D6ZSamwYI/wb3klLD2k+OihlyFljOnBwOD2P0dhIbW1tTNtfd+5bEEDRwlgo9EOEIB0CSBrFFbQJVZQlJCI0rUWhnEyseN4zhuSLdWCjGMqdAYltIogLTdhpb1jfv2xXbZOgWbRvhcee2yxijsAFOj+SA/l8mWT336MubP6JlrzXzyNLfBH+QGzBOZq0wLG2c/6r3EZCoD2govKySaqx8bSrgexgIwLCt/yYcv5eiUaQhysW5GV+T1svqZxDj+959k0t/jAwwBCfT6xwCAazcT7kDqTNSdGnGfSmuqYjYvyF7eOHHKJVxfZXHZWWuhWog==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(4744005)(36756003)(336012)(33656002)(53546011)(5660300002)(966005)(508600001)(6486002)(36860700001)(8936002)(6512007)(83380400001)(2906002)(40460700003)(70586007)(186003)(54906003)(70206006)(26005)(316002)(81166007)(6506007)(356005)(47076005)(8676002)(86362001)(6862004)(82310400004)(2616005)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 11:09:12.1540
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9677414a-63db-4188-2fc1-08da162b8c7b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2815

DQoNCj4gT24gMiBBcHIgMjAyMiwgYXQgMDA6MTQsIERlbWkgTWFyaWUgT2Jlbm91ciA8ZGVtaUBp
bnZpc2libGV0aGluZ3NsYWIuY29tPiB3cm90ZToNCj4gDQo+IFRoZSBFRkkgU3lzdGVtIFJlc291
cmNlIFRhYmxlIChFU1JUKSBpcyBuZWNlc3NhcnkgZm9yIGZ3dXBkIHRvIGlkZW50aWZ5DQo+IGZp
cm13YXJlIHVwZGF0ZXMgdG8gaW5zdGFsbC4gIEFjY29yZGluZyB0byB0aGUgVUVGSSBzcGVjaWZp
Y2F0aW9uIMKnMjMuNCwNCj4gdGhlIHRhYmxlIHNoYWxsIGJlIHN0b3JlZCBpbiBtZW1vcnkgb2Yg
dHlwZSBFZmlCb290U2VydmljZXNEYXRhLg0KPiBUaGVyZWZvcmUsIFhlbiBtdXN0IGF2b2lkIHJl
dXNpbmcgdGhhdCBtZW1vcnkgZm9yIG90aGVyIHB1cnBvc2VzLCBzbw0KPiB0aGF0IExpbnV4IGNh
biBhY2Nlc3MgdGhlIEVTUlQuICBBZGRpdGlvbmFsbHksIFhlbiBtdXN0IG1hcmsgdGhlIG1lbW9y
eQ0KPiBhcyByZXNlcnZlZCwgc28gdGhhdCBMaW51eCBrbm93cyBhY2Nlc3NpbmcgaXQgaXMgc2Fm
ZS4NCj4gDQo+IFNlZSBodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMDA4MTgx
ODQwMTguR04xNjc5QG1haWwtaXRsL1QvDQo+IGZvciBkZXRhaWxzLg0KPiANCj4gU2lnbmVkLW9m
Zi1ieTogRGVtaSBNYXJpZSBPYmVub3VyIDxkZW1pQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQoN
CkhpLA0KDQpJ4oCZdmUgdGVzdGVkIHRoZSBwYXRjaCBvbiBhbiBhcm0gbWFjaGluZSBib290aW5n
IFhlbitEb20wIHRocm91Z2ggRUZJLCB1bmZvcnR1bmF0ZWx5DQpJIGNvdWxkIG5vdCB0ZXN0IHRo
ZSBmdW5jdGlvbmFsaXR5Lg0KDQpDaGVlcnMsDQpMdWNh


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 11:12:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 11:12:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298268.508044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKdl-00036y-St; Mon, 04 Apr 2022 11:12:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298268.508044; Mon, 04 Apr 2022 11:12:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKdl-00036r-Po; Mon, 04 Apr 2022 11:12:57 +0000
Received: by outflank-mailman (input) for mailman id 298268;
 Mon, 04 Apr 2022 11:12:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbKdk-00036f-Km; Mon, 04 Apr 2022 11:12:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbKdk-0004nQ-HS; Mon, 04 Apr 2022 11:12:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbKdk-00085v-64; Mon, 04 Apr 2022 11:12:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbKdk-0004ru-3s; Mon, 04 Apr 2022 11:12:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NNVwbdHVdhMU8GJpF++iUdFoVFk6M3+Eyb1BhcnMiAM=; b=xDVhP3MTRUfVe5Wz96+k73jYHg
	AhV1mNL84QXV77GLgxn2LJ3j4HYLWKdo6HURFa6azO8WY4dQU3aQZh/31iNPERCHbfQ3mlOamomf3
	i2xRSOwCacERXRnRxLyhXT3EL+iJHsqY/OStwfQKA98gQiGcWPvZl/4dD3iIbYNz1wnw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169154-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169154: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=b7f5ad4610856dc82618ed82c5cab3124be65274
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 11:12:56 +0000

flight 169154 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169154/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              b7f5ad4610856dc82618ed82c5cab3124be65274
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  633 days
Failing since        151818  2020-07-11 04:18:52 Z  632 days  614 attempts
Testing same since   169126  2022-04-02 04:20:15 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 102979 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 11:13:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 11:13:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298271.508056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKdo-0003Nt-AB; Mon, 04 Apr 2022 11:13:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298271.508056; Mon, 04 Apr 2022 11:13:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKdo-0003NY-5L; Mon, 04 Apr 2022 11:13:00 +0000
Received: by outflank-mailman (input) for mailman id 298271;
 Mon, 04 Apr 2022 11:12:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1Xnj=UO=citrix.com=prvs=086167401=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nbKdm-0003Iy-Ve
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 11:12:59 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2daac6d0-b408-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 13:12:57 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2daac6d0-b408-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649070777;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=79qDxru4c++3uxXdUmYexzW+Mtka9KfIZxQrlvhRDFA=;
  b=HdUgbQwSO0Tws6cSc3mF5T9fpposvfxL4fKlJJIgP64LZKFYOzZpNNQ7
   9ab21Ha/fphhrDHm38p6BXuG/014uUowQxYwIlIUgu4DCJXtsD+0/aqVD
   SCM0caK0PXVdLsvLnBlmus4vls8fZPuk8gEhUxqzVhL2/NZtQZAIESnV3
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67928760
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jgReRKjBTsvbdjY3A9lUofkZX161TRAKZh0ujC45NGQN5FlHY01je
 htvUWjTbqqLYTb1edt1YYy2pENXvcXXyoNiGwtupCk0Enwb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vR4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YVkSPYPdtOhaaBQGQwtYZfNo153XD0Hq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i
 88xN2U+NkSfPUUn1lE/CpVnkL7zvHrGLhYEg0zSlJY15C/M5VkkuFTqGIWMIYHbLSlPpW6Dv
 X7P9Wn9BhAcNfScxCCD/3bqgfXA9QvkXKoCGbv+8eRl6HWR22gSBRs+RVa95/6jhSaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm88wixFzk5ISg5aHFUZy1dvffMgpEdt0eaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9bwgWU3+8qsO2pworOpm
 HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8R6n9hO0yT6FWy13N2YDB00WirjUWW0C
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKF7fpnkyOBLLgzyFfK0QfUcXY
 8rznSGEVyhyNEia5GDuG7d1PUEDmEjSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPjsnekhy
 P4Gb5Hi40wGCIXWO3CLmaZOfQFiBSVqXvje9p0IHtNv1yI7QQnN/deKmuh/E2Gk9owI/tr1E
 oaVARQHmAKm1SSYcW1nqBlLMdvSYHq2llpjVQREALpi8yNLjVqHhEvHS6YKQA==
IronPort-HdrOrdr: A9a23:reG6BKCHHi4XrGjlHemU55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P
 xG+85rsyMc6QxhPE3I9urtBEDtexzhHNtOkPAs1NSZLWzbUQmTXeJfBOLZqlWKcUDDH6xmpM
 VdmsBFeaXN5DNB7foSjjPXL+od
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67928760"
Date: Mon, 4 Apr 2022 12:12:51 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property
 section
Message-ID: <YkrSs7DtAh95ndOZ@perard.uk.xensource.com>
References: <20220404104044.37652-1-roger.pau@citrix.com>
 <20220404104044.37652-3-roger.pau@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220404104044.37652-3-roger.pau@citrix.com>

On Mon, Apr 04, 2022 at 12:40:44PM +0200, Roger Pau Monne wrote:
> Prevent the assembler from creating a .note.gnu.property section on
> the output objects, as it's not useful for firmware related binaries,
> and breaks the resulting rombios image.
> 
> This requires modifying the cc-option Makefile macro so it can test
> assembler options (by replacing the usage of the -S flag with -c) and
> also stripping the -Wa, prefix if present when checking for the test
> output.
> 
> Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>
> ---
> Changes since v1:
>  - Add the option to CFLAGS.
> ---
>  Config.mk               | 2 +-
>  tools/firmware/Rules.mk | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Config.mk b/Config.mk
> index f56f7dc334..82832945e5 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -91,7 +91,7 @@ PYTHON_PREFIX_ARG ?= --prefix="$(prefix)"
>  #
>  # Usage: cflags-y += $(call cc-option,$(CC),-march=winchip-c6,-march=i586)
>  cc-option = $(shell if test -z "`echo 'void*p=1;' | \
> -              $(1) $(2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \
> +              $(1) $(2) -c -o /dev/null -x c - 2>&1 | grep -- $(2:-Wa$(comma)%=%) -`"; \
>                then echo "$(2)"; else echo "$(3)"; fi ;)

Hopefully, changing "-S" to "-c" in this macro will not break anything.
I would be of the opinion to create a new macro which deal with
assembler options. But if that works and doesn't changes CFLAGS in the
testing we do in GitLab, I guess that would be OK.

Whether you introduce a macro or keep this one:
Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 11:19:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 11:19:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298282.508067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKjn-0004SI-SY; Mon, 04 Apr 2022 11:19:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298282.508067; Mon, 04 Apr 2022 11:19:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKjn-0004SB-P8; Mon, 04 Apr 2022 11:19:11 +0000
Received: by outflank-mailman (input) for mailman id 298282;
 Mon, 04 Apr 2022 11:19:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1Xnj=UO=citrix.com=prvs=086167401=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nbKjm-0004S5-5Y
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 11:19:10 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0a5b4ba3-b409-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 13:19:08 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a5b4ba3-b409-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649071148;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=lS0BZ2bntBHObrz9QwHF+AXVZFY2durtWmtOz0UX4F4=;
  b=JTVBi7+mm/VadURY9mQy8Chf2hXnWAmRReWJBCXJWVAUHxoGsOWWFXhk
   K9aBQke9psAxj/suiRwn/voujlfJbSQCtxKpV8iqPVZxafIFv86U39fV8
   4oWigNj6Tf79/JAUVNP8t5aRv/IFjUYS7qXBpLelstNPHm7/gQ8MdWquY
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68336151
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6cQyVq0NIxXSaUiN2/bD5f5xkn2cJEfYwER7XKvMYLTBsI5bp2BWm
 GYZDT2BO/veZmrzLYtyOoTk/EtTuJHdzYdgHlZqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIw3YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Sh43haj93DJT2xvklThR1HAdHHa5vreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNaiOP
 JFHMGc2BPjGSwduCm8vUpQlp/+lq1zCUgNxpVa19YNitgA/yyQuieOwYbI5YOeiXt5Jl0yVo
 mbH+WXRARwAMtGbjz2f/RqEmevnjS79HoUIG9WQ9ONugVCV7nweDlsRT1TTiem0jAuyVsxSL
 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYW2v5+a3lW2AABJLMFcfaAILazIl4PC29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+ysjPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWB2jaD/LF7rlxBHkJPm6gKvVmSw28zb645lcfBO
 hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIYfOsIpKFLbp30yDaJ144wLuBJx+U3YE
 c3FGftA8F5AUfg3pNZIb7l1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3mGmaZOfAtiBSVqWvjLRzl/K7frzvxOQzp6VZc8ANoJJuRYokiivryTo
 SHlAx8BlwKXaL+uAVziV02PoYjHBf5XxU/X9wR1Vbp08xDPubqS0Zo=
IronPort-HdrOrdr: A9a23:KS/DOaEXwJ+XcBkipLqE0MeALOsnbusQ8zAXP0AYc31om+ij5q
 eTdZMgpHnJYVcqKRUdcL+7VJVoLUmyyXcx2/hpAV7AZniChILLFvAA0WKK+VSJcEeSygce79
 YDT0EXMqyJMbEQt6bHCWeDfeod/A==
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="68336151"
Date: Mon, 4 Apr 2022 12:19:01 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property
 section
Message-ID: <YkrUJRAGXqz7E7RB@perard.uk.xensource.com>
References: <20220404104044.37652-1-roger.pau@citrix.com>
 <20220404104044.37652-3-roger.pau@citrix.com>
 <YkrSs7DtAh95ndOZ@perard.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YkrSs7DtAh95ndOZ@perard.uk.xensource.com>

On Mon, Apr 04, 2022 at 12:12:54PM +0100, Anthony PERARD wrote:
> On Mon, Apr 04, 2022 at 12:40:44PM +0200, Roger Pau Monne wrote:
> > Prevent the assembler from creating a .note.gnu.property section on
> > the output objects, as it's not useful for firmware related binaries,
> > and breaks the resulting rombios image.
> > 
> > This requires modifying the cc-option Makefile macro so it can test
> > assembler options (by replacing the usage of the -S flag with -c) and
> > also stripping the -Wa, prefix if present when checking for the test
> > output.
> > 
> > Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>
> > ---
> > Changes since v1:
> >  - Add the option to CFLAGS.
> > ---
> >  Config.mk               | 2 +-
> >  tools/firmware/Rules.mk | 4 ++++
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Config.mk b/Config.mk
> > index f56f7dc334..82832945e5 100644
> > --- a/Config.mk
> > +++ b/Config.mk
> > @@ -91,7 +91,7 @@ PYTHON_PREFIX_ARG ?= --prefix="$(prefix)"
> >  #
> >  # Usage: cflags-y += $(call cc-option,$(CC),-march=winchip-c6,-march=i586)
> >  cc-option = $(shell if test -z "`echo 'void*p=1;' | \
> > -              $(1) $(2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \
> > +              $(1) $(2) -c -o /dev/null -x c - 2>&1 | grep -- $(2:-Wa$(comma)%=%) -`"; \
> >                then echo "$(2)"; else echo "$(3)"; fi ;)
> 
> Hopefully, changing "-S" to "-c" in this macro will not break anything.
> I would be of the opinion to create a new macro which deal with
> assembler options. But if that works and doesn't changes CFLAGS in the
> testing we do in GitLab, I guess that would be OK.

It looks like Linux already use "-c" for this macro, and with "-Wa,"
options. They just don't use grep. So asking CC to do more work here is
probably fine (adding compile stage).

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 11:33:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 11:33:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298288.508082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKxN-0006mJ-4h; Mon, 04 Apr 2022 11:33:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298288.508082; Mon, 04 Apr 2022 11:33:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbKxN-0006mC-1X; Mon, 04 Apr 2022 11:33:13 +0000
Received: by outflank-mailman (input) for mailman id 298288;
 Mon, 04 Apr 2022 11:33:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbKxL-0006lq-JV
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 11:33:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0061b922-b40b-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 13:33:09 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-TaSEFA_lPwq5gcK9hcys0Q-1; Mon, 04 Apr 2022 13:33:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB6100.eurprd04.prod.outlook.com (2603:10a6:208:13b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 11:32:59 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 11:32:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0061b922-b40b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649071988;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2vninudnNY5iyLT5yME4S0Ywt/TnpeHxiHfTBgQ6Hl0=;
	b=WcKBn/w/nmru+ddAvXmgDaNnwxgYecAumpmwzu1nfqaOUZEfLMerwXdhOSwc6iM58EDRnn
	Z+9Q8Btx/9RGVuG7GDFaWb95vCiQjsrkIbrl3WKpJgGzyFu1zwd1vYuJ4DBt6fWAGNg0kP
	AtQGBmzTrxP+vMhx9a5uRTLjDhq5Ypo=
X-MC-Unique: TaSEFA_lPwq5gcK9hcys0Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TLkUryBJGZ+mCLMNh8hCvKmDHeORW+19SkfTkid8Smkwstw9D/THdqMdh4YUSgrfwreyuLI4nwdwwMH+4rRc7s9r2/EXVuuwv5XRNsEe1D7SKXCsLT+iQiK2RAFQhO/JbcRzWoaPjBeBJ5eY30qJCaMe7fHgwUVET9R1Ofk6UliMIZlhf8wN6I8AbmF3eQ91Tor9AoXprBTMgdkTN3ngzVXpWCNzZYc27/J7jW5GByk//49HZ/YqJ7BfyJEqn3wKZ7k1VJpWIkBiiCAj84Hk268XRYtIcVFqpnQJmjV/0uJiEWSx2zLxFgSSdmB2Z1O68P3pCNZnZq9PJlFpXfSb3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2vninudnNY5iyLT5yME4S0Ywt/TnpeHxiHfTBgQ6Hl0=;
 b=O/eN1nUmYhHFU8rW0SoLU3sGIf7hWsRur6SQhEYv0OE4IRpkB6qUd22k+G4d7naufm5F6P29K13xZNI4vshLfHgMNtmhYW52yUmHcPT8GQ1sl1uOyLl6Gi0+3zb1poFdbsLt6LrFC+QmYFkU3SnYXzNbjwWvq0e+2RYUktuSzCdAlUoazFWIF2BKCgsv9a3XO2HSyiMsh/pEj5DJi1KNgOPE727K27Ee2xoTqelfYLcGKfy9PWNuv6SHkiIu9ro/cLGbqLlSVvnXFVfKvHMTW/dRs8P3QVoMrpub/QvJ+D3qwO/tKWuR3xj402F0QzM3BRdWF5xxQIgpEYBwE+Wqmw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d67bcd6d-8db4-2ac2-14e6-11eb71ceac61@suse.com>
Date: Mon, 4 Apr 2022 13:33:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on static
 allocation
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220330093617.3870589-1-Penny.Zheng@arm.com>
 <20220330093617.3870589-4-Penny.Zheng@arm.com>
 <31c1ae2d-a4d6-5445-e819-5df5a0984cdd@suse.com>
 <DU2PR08MB73251B78F8EB19E334A70876F7E19@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <eba664e6-4146-426b-5119-59fe02a96bb5@suse.com>
 <DU2PR08MB7325D94A0BFFC2A3BB0AFF08F7E19@DU2PR08MB7325.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DU2PR08MB7325D94A0BFFC2A3BB0AFF08F7E19@DU2PR08MB7325.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0002.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2c00c4af-4865-4c52-3975-08da162edf16
X-MS-TrafficTypeDiagnostic: AM0PR04MB6100:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB610069080128831BA1C564E6B3E59@AM0PR04MB6100.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lHERgtQDIuYogaNMlzIDbvirVhWbTRfiBxywnopxpIq3X4h0H1VhwKKvz24Rny0AgVMN4Lh8MWGGymSQA6pzWd0womcQ20kdrNRB1f+S8j7oXhb+YCNWQcqH05bHdsApVPtYXk1KTsE/sAZfdnY4Q38aATEh10ru4hLLz7+UU/ayTO9cXuJvKH0C9Kv2AutBhPv/o/G9MMV2ugraZg9SS6EPJvxUQhtHNQQm5yy4dJlTwwjjgUslgQc35Rv+1SEM6g7b4f7B9UqCK8Wpc4/MJGPYekLa4Y5wmZpS2pX/QISiDRjTS1EFnpX8RmD6d47ibnwQJiO0pOgOyu52/syjxcdESg/ZzA5eFxb7uJwObwIN65sY3ZnTRQO7U3mFI3+O5l1z4saaIf7AY2bP71pctDao5/DEqWzFoG5SoOPW1FNzSD+lDL5QX1YuPJ5qCx6nAFWgKTQKdRIU1Sq1hqxAfjJ9TLP8IifSDH8sUi4NIyUM0OSaBJQSuQZJlq0JflwtJoQmIloVsA9KkL2U558noF1w6luzHhhWkPc7mJUKK+qdR8LlSj+2Sg+zkUpnratXSEvqh2ZnGvM3FN9aJIKPtM36Fb1bNtNVNgGm9ZNC+q5hXAbWDyG7NaWrTXpmbPUDBrPXAZQK7pZTYrG+pAYSwW/4w/IlF+MEp5NYkw95QeHnsaBnlKOSpImfD3c8X166HnW43ONFD7aqri4KSFpDpAuDLDQTmr2JYH8M3UbSrQM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(31686004)(36756003)(2906002)(54906003)(86362001)(2616005)(38100700002)(6916009)(6512007)(26005)(6666004)(186003)(316002)(5660300002)(8676002)(66946007)(66556008)(66476007)(6486002)(53546011)(45080400002)(4326008)(508600001)(83380400001)(31696002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZldEa2Q1S1RjeHRXaWpuWlRPN3FnWGplWlVVOEp0VHdPNkRiTWcwYW1WKy85?=
 =?utf-8?B?dC9IUnJETW5ld0R6UkdCT2hmRFFDU0c1ZEl6NFFWSjg5cGtuUVdDQkdXKzl3?=
 =?utf-8?B?OEMvbFBJU3ZFc0ltZzNzbHhxazBhN0FZNndDMW0xOWMxeDhMYlptaTdGZ3RZ?=
 =?utf-8?B?OGI0bHFUdEE4bCtMbnkzVW4vR0JHSEk1Y2tBeElvUnZURllTM3hTQmhCRFdS?=
 =?utf-8?B?QTZCYjEybmdWWER3Q1dIUTJhQ2lOQ2o1MWhjNmhzb3ZzeVY2VUk0SnRFWEFz?=
 =?utf-8?B?Q3ZqQmVNKytZQ3h2TWw3MTNjMGlZU1kyT1lKQzJKbXVvUVN2TmRTZ1U3NTVL?=
 =?utf-8?B?Ujd4Y0QvdnFkY0d4bVBxTVh2Nm9LUXlDYWFKQWJEUVZ0SnJjTHhHTkdNK1pT?=
 =?utf-8?B?NVF0RUozS3paWjVxQzVwZkdPZ21WZ25PQnpyRnRUaTRIZ0grZmFqUC9ScDVR?=
 =?utf-8?B?OFRXUWFKcGd3clFMRFdpeDd1RW5TaVdGN21RZlA0eU9zcDM2a0pyMERuQ2U3?=
 =?utf-8?B?NksreVNVU2s2ZUVmMllKWlB3aThUZXdxdGlQbGx5ZC9OQXBEVFUyOGVMd05z?=
 =?utf-8?B?eU5OejVDZHR6dkNWcVRWc1V6cDhuS0ZjVXZrbkQrcXIvL1QvaStyalF3Skdw?=
 =?utf-8?B?QjBESHFuM2Yzd0RUdVFuVll0d0xEcmljaTEwN2tJcUd3VG5BVU02U21RQW1l?=
 =?utf-8?B?alNXNnFNeTRaTTRFeVoyclJKZFRRTTF6ZnZZR2tSUkdKcDF2K1FYSElwcG5h?=
 =?utf-8?B?U2VoL0dWYUZIS2syVjJlZFUvQUFaNmpLR21HU0pWdE1GMnh1cG14Z0I2TUNr?=
 =?utf-8?B?bFJ0OHU3bjdlOUUrY21HS1BUQStJY2hUUFBTR0hvcWVRUmZZUmluZGZaNUd0?=
 =?utf-8?B?dUd1SGwvNjNuSUc4VXFrcW9SSU1FSFQzNmZvMjFlMmJJMzdxeWQzSFBYL1Rx?=
 =?utf-8?B?SCtaTXl5dUJvdXRwWlNRSk9QaGhCWnRibUVMeHBseG5DZkVHY2xvUDZPMkc5?=
 =?utf-8?B?MG1lNi9GTFRVbjZESkp4U1hyM2tSNmJXK2hxVnZac2crNzNMRDJvM3ZHYlUw?=
 =?utf-8?B?RkFjRXJPQU5Na2dWUWJHa00rRGdIMlh5cy8wcUZkajJVN1dYbXAwYzdUcjhp?=
 =?utf-8?B?MFRWaHowbDg5aGp6dWpTWCtoamNXYm9PVjNQVGIrM1JlOTZyZmRwd0ttdUND?=
 =?utf-8?B?RUFlSXZZbThGYnd2eE9zMnBublZkVWFHdGlsZTRVZGg0Z0pSTEhxVW5iWWl4?=
 =?utf-8?B?VmJyWDJFKzF2SXV6eENnaXdKamFGdlF3QkxGaGx5UXAyQmQxMGZ1d0VNT2Nv?=
 =?utf-8?B?ZCtKLzJhUU5MZWFCQnJmTUNydUdnbEVPV2pHMG8wY3NQd3RNc2pOT0RRUy8w?=
 =?utf-8?B?NXM4cWRsaTdSUTlkT3dGT2NZbUo4TTdpR1VFTGg2TUFCdXVkQ0JUWGV4NEhh?=
 =?utf-8?B?amZybFljMS9NeGxuS0hPQ1BTMmNrWHNsZ3A0dzdtV2xILytRS3ZNYjNKK2t6?=
 =?utf-8?B?amtHUkxVVmJ6WlJBVVVEalpTdStER29abll2b2tzdktYMHdaYW5VRjk2K3hY?=
 =?utf-8?B?cTZlQmZMWnBGWjRoYXpreUxwUTd2MVpva3VTOUM5NmxNWEJkSEhIUVJjNUYx?=
 =?utf-8?B?cDRaM3l5Q3o0VFpma3BRdlkxL084Vyt6azBvS3RCUDFldkk1RFFsU3ZhclRX?=
 =?utf-8?B?WEZiYVhsVk8wR2g2bFBnc0FRZWRhT3pOeHZWSTB5d09VOENVNVlxV2JJaG9Q?=
 =?utf-8?B?L2svcGRLalJVb3lRQUpDVzVGZUsycUhEamFLd3VkL1hCWWUyd3BCbDQ0MUJ2?=
 =?utf-8?B?b0VGc0ttZm9SVmhBei9FY2NmTjJFb3p0S0NqeGtGelRYZE5MVXVWcjhYUlBj?=
 =?utf-8?B?WFYwUzdEbjR6NFA3SGo1Yko4bHFiYy9mdzByUlU0MStyZ3hZN0FMbmk2ZFB2?=
 =?utf-8?B?Y3Z6OFIrQ1dWTWNYekxaZmErVDU3ejNmU3BodFZKcGtqNjl3U0YyM0cxcVdk?=
 =?utf-8?B?Z2NRc2phd0tnS3NDMGtwcyswUG8wV25tQktBcVlxL3RKUGdZbHpSTDRyb2tx?=
 =?utf-8?B?OHEvQnhGcE1jRHYrZEpCampuMHA3NlNRUDlWckhuZG5Eci93cUxDZmdQWGdu?=
 =?utf-8?B?L2xWZGJOTTBobmZsc2hUTXdOeGY4S2s1UFlFbUROTjZ4RzZrUzgwMnhUWHJE?=
 =?utf-8?B?QWQwWUNSbVlYK1NmTWlxSGtUT0lwTHowRTdKVVgrNGZxRTY0dzBwNlpKU2JP?=
 =?utf-8?B?UUZKSEdhdDJ4Q3JFSmQ0TVRxcHZLVnUza3hWRUVmQkhmUU1tRU1jTGx3Q0Yr?=
 =?utf-8?B?SitoeVBxdEhVQ0dFVkQrdDgycXdJdkVDNm8wcFpsZGJ0WEJtekxnQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c00c4af-4865-4c52-3975-08da162edf16
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 11:32:59.7334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a3NIFjW/wbSN6OL6NplsbfkhFsIzBS9wdJU4/OUNhq7AzjgBJ84NC2d5dPeamTW8gn9hVDsjQD5JM3ydo6uvLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6100

On 31.03.2022 12:30, Penny Zheng wrote:
> Hi Jan 
> 
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Thursday, March 31, 2022 3:06 PM
>> To: Penny Zheng <Penny.Zheng@arm.com>
>> Cc: Wei Chen <Wei.Chen@arm.com>; Henry Wang <Henry.Wang@arm.com>;
>> Andrew Cooper <andrew.cooper3@citrix.com>; George Dunlap
>> <george.dunlap@citrix.com>; Julien Grall <julien@xen.org>; Stefano Stabellini
>> <sstabellini@kernel.org>; Wei Liu <wl@xen.org>; xen-
>> devel@lists.xenproject.org
>> Subject: Re: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on
>> static allocation
>>
>> On 31.03.2022 08:13, Penny Zheng wrote:
>>> Hi Jan
>>>
>>>> -----Original Message-----
>>>> From: Jan Beulich <jbeulich@suse.com>
>>>> Sent: Wednesday, March 30, 2022 5:53 PM
>>>> To: Penny Zheng <Penny.Zheng@arm.com>
>>>> Cc: Wei Chen <Wei.Chen@arm.com>; Henry Wang
>> <Henry.Wang@arm.com>;
>>>> Andrew Cooper <andrew.cooper3@citrix.com>; George Dunlap
>>>> <george.dunlap@citrix.com>; Julien Grall <julien@xen.org>; Stefano
>>>> Stabellini <sstabellini@kernel.org>; Wei Liu <wl@xen.org>; xen-
>>>> devel@lists.xenproject.org
>>>> Subject: Re: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on
>>>> static allocation
>>>>
>>>> On 30.03.2022 11:36, Penny Zheng wrote:
>>>>> --- a/xen/common/memory.c
>>>>> +++ b/xen/common/memory.c
>>>>> @@ -35,6 +35,10 @@
>>>>>  #include <asm/guest.h>
>>>>>  #endif
>>>>>
>>>>> +#ifndef is_domain_on_static_allocation #define
>>>>> +is_domain_on_static_allocation(d) 0
>>>>
>>>> Nit: "false", not "0".
>>>>
>>>>> @@ -405,13 +409,29 @@ int guest_remove_page(struct domain *d,
>>>> unsigned long gmfn)
>>>>>       * device must retrieve the same pfn when the hypercall
>>>> populate_physmap
>>>>>       * is called.
>>>>>       *
>>>>> +     * When domain on static allocation, they should always get
>>>>> + pages from
>>>> the
>>>>> +     * reserved static region when the hypercall populate_physmap is
>> called.
>>>>> +     *
>>>>>       * For this purpose (and to match populate_physmap() behavior), the
>> page
>>>>>       * is kept allocated.
>>>>>       */
>>>>> -    if ( !rc && !is_domain_direct_mapped(d) )
>>>>> +    if ( !rc && !(is_domain_direct_mapped(d) ||
>>>>> +                  is_domain_on_static_allocation(d)) )
>>>>>          put_page_alloc_ref(page);
>>>>>
>>>>>      put_page(page);
>>>>> +#ifdef CONFIG_STATIC_MEMORY
>>>>> +    /*
>>>>> +     * When domain on static allocation, we shall store pages to
>>>> resv_page_list,
>>>>> +     * so the hypercall populate_physmap could retrieve pages from it,
>>>>> +     * rather than allocating from heap.
>>>>> +     */
>>>>> +    if ( is_domain_on_static_allocation(d) )
>>>>> +    {
>>>>> +        page_list_add_tail(page, &d->resv_page_list);
>>>>> +        d->resv_pages++;
>>>>> +    }
>>>>> +#endif
>>>>
>>>> I think this is wrong, as a result of not integrating with put_page().
>>>> The page should only go on that list once its last ref was dropped. I
>>>> don't recall for sure, but iirc staticmem pages are put on the
>>>> domain's page list just like other pages would be. But then you also
>>>> corrupt the list when this isn't the last ref which is put.
>>>
>>> Yes, staticmem pages are put on the domain's page list.
>>> Here, I tried to only destroy the P2M mapping, and keep the page still
>>> allocated to this domain.
>>
>> Well, much depends on what you call "allocated". For populate_physmap you
>> then take pages from resv_page_list. So I'd like to distinguish "allocated" from
>> "reserved": The pages are allocated to the domain when they're on the normal
>> page list; they're reserved when they're on the new list you introduce. And
>> what you want to initiate here is an "allocated" -> "reserved" transition.
>>
>>> resv_page_list is just providing an easy way to track down the unpopulated
>> memory.
>>> '''
>>> But then you also corrupt the list when this isn't the last ref which
>>> is put.
>>> '''
>>> I'm sorry, would you like to be more specific on this comment?
>>> I want these pages to linked in the domain's page list, then it could
>>> be freed properly when domain get destroyed through relinquish_memory.
>>
>> Clearly they can't be on both lists. Hence you can put them on the new list
>> only _after_ having taken them off the "normal" list. That "taking off the
>> normal list" should happen when the last ref is dropped, not here - see
>> free_domheap_pages()'s uses of arch_free_heap_page(), recalling that
>> free_domheap_page() is what
>> put_page() calls upon dropping the last ref.
>>
> 
> Right, right, I've missed the critical point "they can't be on both lists".
> Here is a thing, put_page is a very common helper that it is also beening
> used when freeing memory on domain deconstruction. At that time, I
> don't want to put these pages in resv_page_list, I'd like them to be
> freed to the heap. This putting pages in resv_page_list thing is only for
> unpopulating memory on the runtime. So I'd suggest introducing a
> new helper put_pages_resv(...) to do the work.

I'd like to suggest to avoid introducing special case helpers as much
as possible. put_page() would better remain the single, common
function to use when dropping a ref. Any special treatment for certain
kinds of pages should happen without the callers needing to care.

> About before you mentioned that "The pages are allocated to the
> domain when they're on the normal page list; they're reserved when
> they're on the new list you introduce. " Is there a possibility that I
> still keep the pages allocated but just moving them from normal page list
> to the new resv_page_list? Of course, a few extra things needed to be
> covered, like domain_adjust_tot_pages, scrubing the pages. 

It's all a matter of definition. What I said (and what you quoted) was
merely based on my understanding of your intentions.

> Another reason I want to keep page allocated is that if putting pages in
> resv_page_list upon dropping the last ref, we need to do a lot things on
> pages to totally let it free, like set its owner to NULL, changing page state
> from in_use to free, etc. Later when populating them, we shall do the
> exact in backwards, setting the owner back to the domain, changing the
> state from free back to in_use, which seems a bit useless. And actually
> for domain on static allocation, these staticmem pages are reserved
> from the very beginning, and when it is allocated to the domain, it
> forever belongs to the domain, and it could never be used in any other way.
>  
> Later when populating the memory, we could just move the pages from
> resv_page_list back to the normal list, and also domain_adjust_tot_pages.

I don't mind the particular model you want to implement. What I do care
about is that the end result is consistent within itself, with as little
special casing (potentially) all over the code base as possible.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 11:47:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 11:47:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298293.508096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLAh-0008M9-Ef; Mon, 04 Apr 2022 11:46:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298293.508096; Mon, 04 Apr 2022 11:46:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLAh-0008M2-Bc; Mon, 04 Apr 2022 11:46:59 +0000
Received: by outflank-mailman (input) for mailman id 298293;
 Mon, 04 Apr 2022 11:46:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbLAg-0008Lw-C2
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 11:46:58 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed0651f9-b40c-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 13:46:56 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed0651f9-b40c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649072816;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=L5jW5RE6cvaWkWIcFvyidr+eAITaQpKh27PfryRVcMw=;
  b=aDZH35jMkj/Cwdlh75yz0puaOv7e4AklpqC12PQwFW0njRH0kq7NU7hm
   4LUYLedOVe3IgvuL8ot0QOxtukzfV3GRUgjCrHgSjx1OESBOOj9tG5qP9
   eTH2V5SP2UpnsZ/dAntCkh/27Zg6YD7Ydu0ikKI6vaomkEvghaevPSz3j
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67930837
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tg9BtKKJUF7+ThQ3FE+RxpUlxSXFcZb7ZxGr2PjKsXjdYENS1GZVn
 TAdXmmAPvzfY2CgedhxPNnk8UlVvZeAmNU1TwplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 I9Pq47hWCwVBKzV2/4ebzd3UDtBbbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glv15sWTa2BD
 yYfQRxxMy3dWSFRAAsoS5AEk9+Qmnv5UAQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCs5BwCSYtBONEA6RjO0KnozSnaHFdUUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZow7eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4iDGJGT9bxgbQ+0RqmBNzEJrVml
 CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdEIumkieRsybppsldrVj
 Kn74145CHh7ZiXCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikE4AALWnMnCIqeb+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwkjITWVWvxd22V01e
IronPort-HdrOrdr: A9a23:KIePPKN/bJPscMBcTqKjsMiBIKoaSvp037BL7SBMoHluGfBw+P
 rCoB1273XJYVUqOU3I5+ruBEDoexq1yXcf2+Us1NmZMjXbhA==
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67930837"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YyL+MxncujTCEgrku0eJuCTHj/yGx8+lTkXLghnqc2Ib6h5RvqJP6w5bb6fc/VvgWcZNUrLfyB+07RlrwB4PeEA3bv72hCPVzg143NnWBUuJwhakGVcuXghAm6JqZ+N4SglNJbaKQDfiU9pcZNOJuKp9xgUxn6MMSfRCg/17dymUsHm0WR66O78NJnCj0TSD/k76KGxpB84SpvnROtjEOEiojvrDAwLMLt/zlQkPxppHvOP68rg33l8Qd96LzNaLbQ0ncNfN6VW2DamIf93sgOgxQwfQKAZIyrRz67KKrzZdFkvYKL2dPje0tc+b9BhQg7wU4uK9n94GBN2CnZklyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JSroECJFTvu8DETz7yX2PPyTBY1+J/yDVqrHC/7PL8w=;
 b=BjtBpTdWvv1kB3jx+gtpz06lZmwX40tue5qAZybHMwQrbH7kXfpMPd7vq4G84wi8WgdPBua27vbC3OcR7Cg6Kb5U0GElvM8pY3I0pT5HgvaFLBAPx48qfumkDIJdcvypUujwO3hfaS3Gqy9OiGVLM2pZlphNkKWZVFSqa+LrdpzQjhZ5hKRXh+sBVYzWrnLNPSBlmfV7E0hJmMbmAbXGlE97G3v+XVU6y524nxCIFokTau2MkK1ta5hB3i5xnZfzqivIAT4vGzAhzJpnSBpcGU5DEJ7rLmvd8XSIdwZZpUanFxqT2nkmppqqRlwj5yxs62ARSoyrcnYttLdvFJmmOQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JSroECJFTvu8DETz7yX2PPyTBY1+J/yDVqrHC/7PL8w=;
 b=m2YE7rwUm/0du9oxW4aVfZOsuZbzbraDRl/WDLKE9avobqjkJZpPh5nO/tmKrbprH5BdZ7ICXTUUC9Np4R3YZI66+ZdYrpyTSIU5lOMilTDJcAsAqtriyx/S7pqgEGL5+aWlANZDxET/Z9l4aCAmxsjlF2UpmK26yB8PtDKM05w=
Date: Mon, 4 Apr 2022 13:46:46 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 1/4] x86/APIC: calibrate against platform timer when
 possible
Message-ID: <YkrapvsmmjcZkwSj@Air-de-Roger>
References: <6e540bc9-c536-84ac-fb1c-8271e7731b3e@suse.com>
 <37ee7fe7-1218-7fa3-bc29-0fb45389bf75@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <37ee7fe7-1218-7fa3-bc29-0fb45389bf75@suse.com>
X-ClientProxiedBy: LO2P123CA0013.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:a6::25) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 650a692d-d6d4-4419-ce66-08da1630cf4c
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5918:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB5918EE0C7FA72A8CDA7F48918FE59@SJ0PR03MB5918.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: QmF7teGEw2pfwV1PiTnjXD5CrADfMBD/Gdhi58Wh8XsjMYEI2sRYarNaXGQ4lTi0f9mLycDjQhNol36ip31ozVo5yI7Gk5+ReEGr2f5mwJ3BC1P7tKv+n7n0lccJdXLeGWciwK1eHb9CxzIOLvBG1vJn3Y/wL+N7f07SwXtO0dLJcdhJgtCewSzay7Uq6Z7i//KW9+HNDq0YIpNGgQ+LTkyVTxGgIG7jJmuyML7AZm7UUr7tj8VuJrlI8qy5kIRS0mtMkuC5WXTGUc8z2No4adgCrpD7y6QpT6V+rPsFVEX6RUwNgcvTqEr0HHzAjdA3p6ZjHIFHVbytEIQDIgFP4FqbJUWKXzLSePjBWfQ/UJB4eMbzs+TGhPRs21IJ+1OaYhD0SEXLj/p1RgRtgSh4LssW1GATaGq55XopZiPvbqP4XdnWcYaPeX19iPbTUAuusZCF0Me+BIlhqCOwzVZj29LkE3MOrtEvsVED5Qc1Fqjjsr7FIMW+7/WqYdmTC2ns88qgtpyCZcPJS6K0axtelrHEFOQSyhDdwzSDLajCLQjBMNJhKhOk3Vh0r0lLipj7Vksq0Jurm7KjvjJC+5UyfES1WWliQaHJohPVzNmIbE9g0wnx9WIf4QZf0vg6KStCdILAFmySx+W1MJQxF50oUA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(2906002)(33716001)(66946007)(9686003)(6666004)(66556008)(66476007)(82960400001)(85182001)(8676002)(4326008)(6512007)(316002)(5660300002)(54906003)(38100700002)(83380400001)(6916009)(186003)(508600001)(26005)(8936002)(86362001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGd3Q3RUTzJ3c25TUTJyVWc2ZlJmc2pNcFlBMnhKaElaWFRSWEZYZzdwd3VB?=
 =?utf-8?B?T2Y2WlNNUjVBZFdZSHlDK2EwdHBMNHNMU3VpanpvdlRHdUkyNTBFZjRRNG5T?=
 =?utf-8?B?dG5maWdoTTdGUG04R2tDbXkyM0J4ODVvV2Urcms3TlFjUUYyOE44aCs3WE1D?=
 =?utf-8?B?WnlVaTBmd1NHM3ZLdGFEaWE1eXlxQUlTUWFOemtHY1BoYmhhYkc3UE9nOHMr?=
 =?utf-8?B?THA2b0tqT2hpOTVVdVhIbDA0UkJPYy91MW56Q3diRzM3WEFFTitpNWhTQWJ2?=
 =?utf-8?B?bW5CUnJJL2RxWGZZUlpwV1dQL0J6VHNIZjRReEFIS3R4cHJZak9qSTRNWDBa?=
 =?utf-8?B?bzBtakxCTGt4VlFYcEFxYUtoNWwvQWtsTWV3T2pDS0VLRjVITXdENUVpTTN4?=
 =?utf-8?B?Wno2L1VCU0UzTSs0bUFsYWF3TU9wd2hMcXFoWTN5d2FmMTdhZnNKbk1kWXY1?=
 =?utf-8?B?VkJnT1lNNERkdXpEWFJ4eUxVb20wTEkvS1BxeSs4NGJQOGZVZFlBZFc5S284?=
 =?utf-8?B?bk1LMnJYS1pWRWsxOVZQRU13dkhWTlF2VlgzZlNwSHNNR3J4VGt2M2NZWXND?=
 =?utf-8?B?UlVpdVpmaFp0TWhaeEtWeVhwSUJqRjJIWmNyQ2JCRkQ3VEJadnVmMEhXS1Rw?=
 =?utf-8?B?bXIxcUNLZ3NMWm85bnJSdE5nY0lPWkx4alhLTnl6NFYzQXhZNGRTRmtscU1H?=
 =?utf-8?B?THhNL2lIellKSmcrcXhyMFZwZkxLNjZJUVd4K1poTE9KMlB0S2ZsY1dSUHB5?=
 =?utf-8?B?Z3RIb3Y0MU95VTQyL1Zwc2FzNFVMdUw1YndEeHBiWXVyem8wbXc3TWRZa0dU?=
 =?utf-8?B?QTBaUk40Rk55QTRJR214RmdQRWJYWTljRlhMVzQranUwOURseXpBaS9OdU5m?=
 =?utf-8?B?OHovZm1WTmxoL09DOTIzc3B1a0R6RjJVMi9xMGNoczJEbUg4dU00TEpEUCt3?=
 =?utf-8?B?UHNsS3VhT1FWb2l2MHZJZVpLRG1xMXE1WUtCYVdzMkc2NFMzbHZXYk05enl5?=
 =?utf-8?B?dDFRM01rbVVRY2N3WnFiZDNld2t6aU9scGJFQ3NHL0VHWWpJZnoxcDhSajVj?=
 =?utf-8?B?VEJ3NFl0dlhVVFM0b05rYmNoR05JLytVK1crUWltdkNCVXBjR00wb0VKc0Vn?=
 =?utf-8?B?TzBiUXpLQ0hEZ1BFeW0zMTVGKzlHLzBaSzFtTjljN0VPQTRhMVJHa2FzaVBS?=
 =?utf-8?B?Q2htMmNhZklacFVHS3YwTEdTMk55bWlhUnhnUlBmZWJFVU5WM2xPemJqV1Fh?=
 =?utf-8?B?Slo5VmhxbVJZMTUvOHM1bmMvandybWcrZTk0MUJLSU1wanpxRFcvcHBWcXBS?=
 =?utf-8?B?SGgyanNlZHRQMG1kcm1IQkFwWGRhSzhlVHVmZSs2WU8zWDJUTHJqUTdmdzhU?=
 =?utf-8?B?QkFvUlRrY0ZHSXZUcFY4b1hIWkM5UFBRalRkVVJQTHBHanhEejhlVXNjOGlz?=
 =?utf-8?B?OEtGVWN1ZWpYME5neWRQMjh3eUl6akxvaCtFano1VnhHRy8vZTdYOXA4UThh?=
 =?utf-8?B?V2JHak5mQ2poejJtSUppU2p2dmM0K0NXcUFLeEhYSWNQVk5WYmdMaFhTREFu?=
 =?utf-8?B?T1BudHNaaVI4bkV2NXNjS1VzNTMxcjc0aUg1MmNGSVNoM0dMb3V6bjlvbnRl?=
 =?utf-8?B?aUlYRHJ2MzZjcXYwV1VUT25LUVpzb1M5WlJSWnFmVlFhdmxLUU4xM3dwM2V1?=
 =?utf-8?B?SmtIM3M3c2lnWEhSRlU2amNSRVIyVVlzekZRRU9PNlBNOGZzOHBWM0U2SldG?=
 =?utf-8?B?R0lWVXU2YkZwcGgrVEVqQ3EzaWUreERYMmxTYzZ2VlY5TFdYdG9YWHBCYTVY?=
 =?utf-8?B?M1RpK2JBQzRsWmxlM0h4b0g1d0Q3UUs5ODFqSDhKcjAwemNld1ljZ1NHSXZG?=
 =?utf-8?B?dHU0NGJFUlBrTlliZDJSUzZJY3lOUEZlVWNXb3EwYUNqVUZhUGwxMC9LSERJ?=
 =?utf-8?B?ZzhxblFITmZ4VU9xOW5tamk1Tk5YQTZjOG42QXQ3Y1crWWRhRXZqUHR1NWxW?=
 =?utf-8?B?YjNUaS9mMzdpc0VSYWxxSkVMRUJZUGpMMW1SU3lEem8xY2sxQkJJUmM2Y3Ja?=
 =?utf-8?B?S3kxMlJRNm8zOGV0TllBMUhJNWZJNXBGeEYrbkdwWStuV3lUbTE2M1NWREgr?=
 =?utf-8?B?VXBvWGUvSE11VGlBMnI1R005VGpPRmVqdUVTREN4dCtHOEtpRmR0VnN0cTh4?=
 =?utf-8?B?UjJvNkhOei9NQzRoOWdKUmxFV3YzbzVrUDVIOUlIWnV4dkZPZ3d1MUxzZnNI?=
 =?utf-8?B?Y2lGcE1qeGtEU2xic0dHNFFOaUNGZVFKRmRQN092bUNjR2FRL2ltTkNOTFVH?=
 =?utf-8?B?ODBoNS9WdXJPRkFibGlkcWtLZVM1ejNZaHl6TEZBUngzUjAxbm8wMEI0OGdU?=
 =?utf-8?Q?/X9vqpS4EH6lKHUg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 650a692d-d6d4-4419-ce66-08da1630cf4c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 11:46:52.0223
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XpM6TT5bKaNQPSJC2owXBOz3Zk7uYZp+qIhk3/jJzvIrJPt5bY5kVUMoTtQ6TdrRgOiEBwu5+aHm1jX906p6Mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5918
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:29:44AM +0200, Jan Beulich wrote:
> Use the original calibration against PIT only when the platform timer
> is PIT. This implicitly excludes the "xen_guest" case from using the PIT
> logic (init_pit() fails there, and as of 5e73b2594c54 ["x86/time: minor
> adjustments to init_pit()"] using_pit also isn't being set too early
> anymore), so the respective hack there can be dropped at the same time.
> This also reduces calibration time from 100ms to 50ms, albeit this step
> is being skipped as of 0731a56c7c72 ("x86/APIC: no need for timer
> calibration when using TDT") anyway.
> 
> While re-indenting the PIT logic in calibrate_APIC_clock(), besides
> adjusting style also switch around the 2nd TSC/TMCCT read pair, to match
> the order of the 1st one, yielding more consistent deltas.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Open-coding apic_read() in apic_tmcct_read() isn't overly nice, but I
> wanted to avoid x2apic_enabled being evaluated twice in close
> succession. And I also wouldn't want to have the barrier there even for
> the (uncached) MMIO read.
> 
> Unlike the CPU frequencies enumerated in CPUID leaf 0x16 (which aren't
> precise), using CPUID[0x15].ECX - if populated - may be an option to
> skip calibration altogether. Aiui the value there is precise, but using
> the systems I have easy access to I cannot verify this: In the sample
> of three I have, none have ECX populated.
> 
> I wonder whether the secondary CPU freq measurement (used for display
> purposes only) wouldn't better be dropped at this occasion.

I don't have a strong opinion re those informative messages.

> --- a/xen/arch/x86/include/asm/apic.h
> +++ b/xen/arch/x86/include/asm/apic.h
> @@ -192,6 +192,9 @@ extern void record_boot_APIC_mode(void);
>  extern enum apic_mode current_local_apic_mode(void);
>  extern void check_for_unexpected_msi(unsigned int vector);
>  
> +uint64_t calibrate_apic_timer(void);
> +uint32_t apic_tmcct_read(void);
> +
>  extern void check_nmi_watchdog(void);
>  
>  extern unsigned int nmi_watchdog;
> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -26,6 +26,7 @@
>  #include <xen/symbols.h>
>  #include <xen/keyhandler.h>
>  #include <xen/guest_access.h>
> +#include <asm/apic.h>
>  #include <asm/io.h>
>  #include <asm/iocap.h>
>  #include <asm/msr.h>
> @@ -1018,6 +1019,67 @@ static u64 __init init_platform_timer(vo
>      return rc;
>  }
>  
> +static uint64_t __init read_pt_and_tmcct(uint32_t *tmcct)
> +{
> +    uint32_t tmcct_prev = *tmcct = apic_tmcct_read(), tmcct_min = ~0;
> +    uint64_t best = best;
> +    unsigned int i;
> +
> +    for ( i = 0; ; ++i )
> +    {
> +        uint64_t pt = plt_src.read_counter();
> +        uint32_t tmcct_cur = apic_tmcct_read();
> +        uint32_t tmcct_delta = tmcct_prev - tmcct_cur;
> +
> +        if ( tmcct_delta < tmcct_min )
> +        {
> +            tmcct_min = tmcct_delta;
> +            *tmcct = tmcct_cur;
> +            best = pt;
> +        }
> +        else if ( i > 2 )
> +            break;
> +
> +        tmcct_prev = tmcct_cur;
> +    }
> +
> +    return best;
> +}
> +
> +uint64_t __init calibrate_apic_timer(void)
> +{
> +    uint32_t start, end;
> +    uint64_t count = read_pt_and_tmcct(&start), elapsed;
> +    uint64_t target = CALIBRATE_VALUE(plt_src.frequency), actual;
> +    uint64_t mask = (uint64_t)~0 >> (64 - plt_src.counter_bits);
> +
> +    /*
> +     * PIT cannot be used here as it requires the timer interrupt to maintain
> +     * its 32-bit software counter, yet here we run with IRQs disabled.
> +     */
> +    if ( using_pit )
> +        return 0;
> +
> +    while ( ((plt_src.read_counter() - count) & mask) < target )
> +        continue;
> +
> +    actual = read_pt_and_tmcct(&end) - count;

Don't you need to apply the pt mask here?

> +    elapsed = start - end;
> +
> +    if ( likely(actual > target) )
> +    {
> +        /* See the comment in calibrate_tsc(). */

I would maybe add that the counters used here might have > 32 bits,
and hence we need to trim the values for muldiv64 to scale properly.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 11:56:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 11:56:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298299.508108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLJQ-0001S6-FC; Mon, 04 Apr 2022 11:56:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298299.508108; Mon, 04 Apr 2022 11:56:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLJQ-0001Rz-BJ; Mon, 04 Apr 2022 11:56:00 +0000
Received: by outflank-mailman (input) for mailman id 298299;
 Mon, 04 Apr 2022 11:55:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbLJP-0001Rs-9G
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 11:55:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3059ee67-b40e-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 13:55:57 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-F8UEe_AhOnWjy6dbOy1VCQ-1; Mon, 04 Apr 2022 13:55:56 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4677.eurprd04.prod.outlook.com (2603:10a6:20b:25::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 11:55:55 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 11:55:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3059ee67-b40e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649073357;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VJXYG/9gRpsvS/cHvl/2KW38Pb4LJYO3r15BpS2DGPY=;
	b=VPabioAgk8s0mLawM09YyaQgHPW4Y+UqpOiaLwUZkh/EEzEc1ImtO86lb/3/oed0GtfODY
	zGWbOBRn7z91O3kP9Y0ISpNcPNpQcPQsL4Osqy2PX50cLROHhlkrbLjJmiYrdPQhhyGi75
	JueH5SblmQ9izjaCSw22QUO7DCfbiCo=
X-MC-Unique: F8UEe_AhOnWjy6dbOy1VCQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N/Jgdma9NP7/q/DqSOFU5bh6bOT1DTpocqCzuOiR6VUHYXO7gl24CT4uREtaurG9FhXZWQY6HsxtyrPnMzgkQ/O1TErrUJZJItb4Ee2T2J4VNaoW5kfoVyleokntyh5u5BOPNy4Ub8QvoyEfzFbKTecY41s2NdiGlEwkJ5CeVbqpxqwpJAKhShhLP1EFupMw9g7OW/mq1AyJTw3dAeJ/B7uwLf+cw3tRJysHXBDoncmLm6O7GHz8r0swCQWSKxgkOCgUoxaqY3jfdWxjMveRiTuCMoRZUxvofABkEok8lz6ebjpaxBe6pPNux2L2O1w4QmG/0rTeKvbFPxvdXnFhCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tCKvEFJvw+lpfdXbT+KPfCyUEtPemYHb6h5cHDSCVDY=;
 b=GfIBFM6h8olQ+HvWFxF6hCzjLLO6APHh67m0TyKDMAUDHBb/bE9Iu3zUoA341bRAh4lFvbcegyzQPepMEU7eBKBbY4dQAiTu4/0RrXmJ3lgciYRugp3i0AfdW7q7DtvwFKcgUFSYCmtjo5ei6MpoUqCTTLMgG2c/Dwq/6hUsDcm+CKd1hQ6CbbuBePW3NKVFvKQ2YMIq+KJU+dBGmKtV70WMkXCJf7l6PPEggnLUE7EYyN2Fm8j+4Z0SKVnXbW6p8bcGlSSys/qy9lNmn2YNCiW4PVRJs+DiQOQb7KzG8wXJgtHZzXFJzDvvR+joosbQTRY5g897E1Y9/r0o5ERDtg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <95654e26-160e-8664-23c6-ad5e4c87f444@suse.com>
Date: Mon, 4 Apr 2022 13:55:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 1/4] x86/APIC: calibrate against platform timer when
 possible
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <6e540bc9-c536-84ac-fb1c-8271e7731b3e@suse.com>
 <37ee7fe7-1218-7fa3-bc29-0fb45389bf75@suse.com>
 <YkrapvsmmjcZkwSj@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YkrapvsmmjcZkwSj@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0049.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6ff960f0-828e-4a16-8a5e-08da16321376
X-MS-TrafficTypeDiagnostic: AM6PR04MB4677:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4677A6AD37C49F6AEED2E0DEB3E59@AM6PR04MB4677.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c3/5z0aZ6WZ/VSWEziaHk0ysAQW1CS8QD05MQgz5wbcQ86lqfhvuCYObZSbAMUrXdfKj2dLz49IKTwc+Rc7q98o4/QJva1cZ30PoywYV4jJddIU905GkOqVLAwZeojUO6ghMjrjEb9v6XqN2G53+U1hFbhnEplKTRPf4qUYdpFC7Mh3oJAyLKlKMhkoDMz96/4PloDWTo+8xvk/GBx5Hgs79vN2SYkvpKe4DBWVypRzAwJYgX0EMtb+kDfYNNsdX9I5wXkFFxa64AR65okj+NOvX8HyDmziCWEOgFoPbXDIcE779h+AjQ3SqIgW1LzHh2f45J0WyzINO0Wk5//JbVGxywm+k0roan8FnFoCsyyO0gim3Jv6nHa4DNOKyaNYvjFJJ32luFUrX38O7Fq6vGyyxq+6I4hEj0EyQ7EhS3ezumAercD6vnBOntkO/GTInLhg0exI+oZC/hrLVoZoUrGXzoyuvvW+AXj2i34iHcc5x3OfNzig3qR9pEi05KNyd1idxeIpJNiiRq0VTkYHe/acp7P/+OYFNnkiGRqC7hFifBj4GNu+G2BZ8wt1f6XeWZmwAaRVqFXRLk73WAn5p4wCKRe4T4ugEzqyD0NF02HZid3SJEQVTJyo7gvEFDSz18frQyis2pfZBdJ9t9dzC5Ma7tw8bW4nXkrLsGeh0T7p3NFN/UgSuvsH+HClEdqMOLr4EhcMlZi8fXzpL+AH6Y87H8+iJ+qkhChdaURG4g1o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6486002)(5660300002)(38100700002)(66476007)(66556008)(66946007)(8676002)(4326008)(2906002)(8936002)(31686004)(6512007)(31696002)(2616005)(36756003)(6506007)(86362001)(83380400001)(6916009)(54906003)(316002)(186003)(26005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IdePypfwG/Og3VMq5DP8YtMk+7xdd0JGhJ0dBL9/kxU5khP1UhnOfBRZFlJq?=
 =?us-ascii?Q?KPHPRKA85nfL2CeYeoMEuH3GcTvwd85rdcGq8AjCf24SgRuEnI7Zd+eanV92?=
 =?us-ascii?Q?1un5TvzNN1XS1nWBty8HLXgmshD652EUoKQmZ9FDeuT/I218UUoNJJESITMS?=
 =?us-ascii?Q?WMiEkqX6kvQ+/0gPbstr7dsAFIHMlarxstUDbi1xXo9+jCQbYvyQhdmJJpAR?=
 =?us-ascii?Q?VXCzU0G3QaJBbWCLHBym1HUrAusj7N9cW4w+pHPxGDKwV+wARNVzksCjxB6g?=
 =?us-ascii?Q?uG8CoZrihFpM2ZTdZwSDyWqHJ3fTZIj6Nm0DYDHFZRkjN2Wm2Iv7bW58Fd3z?=
 =?us-ascii?Q?06lLYWuIrzrGc8ikRusEE+asYVXsiJ5Q+rFdd5HPCC6OW2jlAkZGS3/sLt4H?=
 =?us-ascii?Q?7XzHX464Ksmts2tKeLnxCwX3TWPJmrkyNZt5ivaH3HkO/SNxqJ9xImLZIUJ/?=
 =?us-ascii?Q?Vt5NW/CoEpNZ9/AUaGaKZwZsvdCXAgnJ76xW0eW997VltJeQ6sqy4CLgPLJJ?=
 =?us-ascii?Q?/dcJh+ElhrFuQQdhsCrpZy/gn1KUUMRbVAhzQX1wacB5QkhgbNcGRp7pmItB?=
 =?us-ascii?Q?zPddcK8ePHY89UUoPoq5zwp26V+VggLkHHT5E3fpqAk9cLRAGyazoWMwgN+T?=
 =?us-ascii?Q?6Y+9G/a4cNpvzko2DmawgBsVeYT9Mt6xK0OUnOIf10ztwSSkmfVssZmb8QeU?=
 =?us-ascii?Q?KCXrTRhgQQI/eS9OwJkgXY6EGrvXLJidYewG2CHctryrh+TSVz8XgR7O/2O/?=
 =?us-ascii?Q?yRgnmKrhTZsfrit/xU9s4OvoFvjWWIZyF0NPrwzimOp2IrfrlxGHtimpv8c7?=
 =?us-ascii?Q?/pNYWEcSTMtJSECVFXlqRDd0aNvt+PHpA1gDCRgcyfj/og4OqQxmuuAQelfw?=
 =?us-ascii?Q?JrJTygsOE5U+nIXA9xYxRLUEaUYSh7EaKQqIHi93/1YHoyNNhfR0sY0nKHD2?=
 =?us-ascii?Q?/b+J6Qgfq3QFDpLdhAU6cBeiQjWKwO1/inrOz3HP9VdJHJFDEovMhhiPGLnM?=
 =?us-ascii?Q?VcuA9DLd7PAOrx9lNjL/MR5DCTdEfisAYwde//IevwXUuac4Ywi0FoRYHK4r?=
 =?us-ascii?Q?xf32JujudiQVcoxLinKifMfzoRhX155NkGydJK7lM0Z2R7GgVk6bnDF6Q4o1?=
 =?us-ascii?Q?ki/bEC4AjsUSM7XWGVL/nwRkcNbVTWcQKz1hzr2UK0KgTfHVd7tjF2kXamsu?=
 =?us-ascii?Q?yaix61fJVzgSxgfYM7eBsxRYB8QEnEspl4l+FjneAvPVM+SO49gg1rxzBeWv?=
 =?us-ascii?Q?pEkWyQFVVjbFZxr0S4o+eerT6ieWKaKaWq4akiQnE0I1gjZITtXpMZpU5hh8?=
 =?us-ascii?Q?UtKXm72I4Og7IqtlVUMVN/1CH1+BOoh7z/Ec+EATPMCve/kZw/h+TAyJg4Hp?=
 =?us-ascii?Q?WmNHtNsJzrY0QcXeVVbIGH1/9CqteqUeHyY2/Sh2sIEC1anRjsGyNM0YCUaF?=
 =?us-ascii?Q?dttr//Y4PPwqlRsgsjprXL7oQ6NktF8Get8bLXuXLSQPU4IuM4EfYxqX/Uws?=
 =?us-ascii?Q?F48tCfoqN9QG7aZudHMvr8ZZnFXVKFUaQG5vHG/YFsQdpJqicDnMh3VNbZwS?=
 =?us-ascii?Q?tLQ80yLWKaVaF35EYfOtSbgZsnoMjM0S8WZOb/JwRPiCg2CQbMb/qoeD9hJt?=
 =?us-ascii?Q?76oSrlHyp1JhTUedFDrehwClXICEBLU2KTL1PQj8z2wuAmFshj+7jHE7mAFX?=
 =?us-ascii?Q?XDeFAKl1u+QT8dB0x/JX6W4k9z52sfe0Qxi/DMhmt5J1bDzFHR/UbdABqILk?=
 =?us-ascii?Q?QjMV85G14Q=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ff960f0-828e-4a16-8a5e-08da16321376
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 11:55:55.8151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6eiwYE0oqGsZ4u/1PtvNFXDWMARBBptBSDG6zS+ktW8/4MsjlDAd8fgQDTz3MDxG2CnA8XrDD4enzClJ2Hbqaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4677

On 04.04.2022 13:46, Roger Pau Monn=C3=A9 wrote:
> On Thu, Mar 31, 2022 at 11:29:44AM +0200, Jan Beulich wrote:
>> +uint64_t __init calibrate_apic_timer(void)
>> +{
>> +    uint32_t start, end;
>> +    uint64_t count =3D read_pt_and_tmcct(&start), elapsed;
>> +    uint64_t target =3D CALIBRATE_VALUE(plt_src.frequency), actual;
>> +    uint64_t mask =3D (uint64_t)~0 >> (64 - plt_src.counter_bits);
>> +
>> +    /*
>> +     * PIT cannot be used here as it requires the timer interrupt to ma=
intain
>> +     * its 32-bit software counter, yet here we run with IRQs disabled.
>> +     */
>> +    if ( using_pit )
>> +        return 0;
>> +
>> +    while ( ((plt_src.read_counter() - count) & mask) < target )
>> +        continue;
>> +
>> +    actual =3D read_pt_and_tmcct(&end) - count;
>=20
> Don't you need to apply the pt mask here?

Oh, yes, of course. I guess I did clone an earlier mistake from
calibrate_tsc().

>> +    elapsed =3D start - end;
>> +
>> +    if ( likely(actual > target) )
>> +    {
>> +        /* See the comment in calibrate_tsc(). */
>=20
> I would maybe add that the counters used here might have > 32 bits,
> and hence we need to trim the values for muldiv64 to scale properly.

Sure - I've added "But first scale down values to actually fit
muldiv64()'s input range."

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 11:59:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 11:59:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298303.508119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLMs-00025E-VK; Mon, 04 Apr 2022 11:59:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298303.508119; Mon, 04 Apr 2022 11:59:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLMs-000257-S4; Mon, 04 Apr 2022 11:59:34 +0000
Received: by outflank-mailman (input) for mailman id 298303;
 Mon, 04 Apr 2022 11:59:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbLMq-000251-Os
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 11:59:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id afc687df-b40e-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 13:59:31 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-KQwK-yiGObCNKEx2XMbUww-1; Mon, 04 Apr 2022 13:59:30 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBAPR04MB7333.eurprd04.prod.outlook.com (2603:10a6:10:1b2::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 11:59:28 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 11:59:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afc687df-b40e-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649073571;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4SaEaNWNoyN0DoMKLTs7uxEr8L7UBTN6jBcP3HtuAtI=;
	b=fnEBlesaG187GFywNGKpxNEb5xSwubHDqRDunUsNsCZlopkyVlJ6sAL8KlCHjiBRtGr/o0
	+R0OVGoSYp4c3Opd6SSw4CXEWT5EPwnewNrCtqTL3VhdMmDGJboeC0lptyjfQlOsZe2jMr
	Z8BftXhWmOKiOnDm94KJHeFSPmtFSko=
X-MC-Unique: KQwK-yiGObCNKEx2XMbUww-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mmYOiIDe/VmY9Wj5ICR6yJvIkoc9He3sXlEom4TAIBZWC2yMxOypuhgV47Wd/lj7gvYX3aryrK8Xj7Nk5xz5IWl/p5KigCgFqnIwsMYE4Q5eXl8HNPst9PMlSxbvFzcg1L6LSuK+JYa6cXshU5tOISsAN0n5AccMN+2vsK+F/1cBk+l3PjWK/B5cmELDTEVdFP13BAfZt2t5jKPCg78PEOgeUkZQnspuz4wuORs3VCeMuLvm1QBhSFbgAVSMQo7MNon8NY6EINMQz3vMAkGdDcmOHlZ1owKFllqEI95O57E8KnRr1HQStt/exIRMlmqpFihm8QiLU36O4VRtslx5zg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v+gnQXSiO+emOGmhfMkkLu+WcLM4o9eWK594FRLHyHE=;
 b=jSOv/Oe0j7R9TCduxwJ3r/B1AS9/3vm5QS9Ts3XYrJ02IXqQz0XwebSQVjt2GU9PtSqSUi+XJBTQk/xkKro0CQzrGIMF3VKuVTPaiPQ21pRWos7duntKzpqXW/kJM+yPLaAGQMXUsxZxWYBXR7LaQR1k8nQR3BQfAVgOLdZNH1jrg12m07enbI+wqFpH1IknMnnBW6ESqSehSoFuUNEym7RbxzC3O5m7pQppEv905HkUjtojZD5FBvx2BIRd3VSzKJeyMljW0XKYMaEKmtM0lUknpcSJ6HdvNUmT0csjFMiY4Qx6lr0Axzg+1cxNKlmpuEzNS3V7RpveofFQ4lnwig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <46c3f2b3-85f9-5de3-d4da-5a2e761d4c24@suse.com>
Date: Mon, 4 Apr 2022 13:59:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <c8ad290d-65ba-8437-276b-5d5f1d4d225b@suse.com>
 <AE149C77-2D93-4DEE-8D03-925CD6744519@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AE149C77-2D93-4DEE-8D03-925CD6744519@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0011.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f23e87eb-ff9c-4ec3-15b0-08da163291f9
X-MS-TrafficTypeDiagnostic: DBAPR04MB7333:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB73331FF6B1C70EB800EA2C9CB3E59@DBAPR04MB7333.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Qa8sDjpa4txd5oDudiSm/jGsdXW1uXmMSpF6KApVLa/OofxQ/CAD7Dby2SztlN5/8BSk2zHp801NxGFCOAaMRrcaQnfvpKOW7W0E4Bwfy+iYkvDUdot27tmul90Vous5gV/WEXi61C1ZFN6KV+jdNQtBblYK30Ijjp+pHhMmZAEucmzYmvImSAgFmXf0t7JiU+ebdVLHbT091cBT9JMmIq7GwExfIMCa416Tf/496mssqxyWWxc3jBi5iL3xKcT+NtQkSnysnl6pAplCNLHjw4uSiB4yc6M7hrICjhyL/v4qMHIrlXUBooWA/lhGSZmbzG6ZexnBEYtBMDwUnx6ZYWieHULBmXvR6i+qmSwHaB8n5Xqv3r2BM//kCiPmTckEpv5Xl9KnttlfzGaXz3QNfSXDGyaRpMxN+A6/oBFFccuGnjjMkCL17gCI3/5oywL0MdqPrPjNBOcXVTARPnMZnNBmmuWYyGs+GN9C4GAFMlLzROiOUywJY399Q14mkjSuVbfmwtvVLjlNBlgBeaJBRltSo5LHGcxvrYmnT2/5sS6N/uwAmKDp0nOVP1bAJNMYQxMWpO/lxtDXumgwnLSFLaXi39m91eSlN0uzmRd5lJw3myMe0KRu4v/97RdR8qXv3U/4zN0wqNUIQzI604LBszv7SobM2bzis6IScUVayltWqtB9snyoEWrf9aT88O6G7cmQAAVKNv4NEdB7533h/3880TqQ0zt6sz9/xgWCp1w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6512007)(6486002)(2616005)(8936002)(86362001)(38100700002)(31696002)(6506007)(53546011)(2906002)(4744005)(508600001)(66556008)(26005)(186003)(316002)(4326008)(36756003)(8676002)(54906003)(66946007)(31686004)(6916009)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?m7dEiHo6QnMCbZnANaT4VgzJiwzxnuSbxqSDlXmooufaAuWa5/8nUEZeOjAW?=
 =?us-ascii?Q?x68t8B7KiIT7ISXtE4cWB6m/7Ox1PaOlNXxu2LkOV80D3hQnQKwCsyq8tIZS?=
 =?us-ascii?Q?Juc4vKUP4D42E80gZQQ5LP4NAUuTg0/eN7N67mrlDi0puSW4gqbq4kSOHxBQ?=
 =?us-ascii?Q?nttr++yWsb6Gpnwl1CG9i1Uudhg17ZFQJYUyBoeBlOz7Xm/FmqaWidgO5qKa?=
 =?us-ascii?Q?qhGc4oBHbveuRLOeUu7p06rKFb1HxeCBvf6AVnVuA7/1YSLI2XRjRK1f0ImT?=
 =?us-ascii?Q?eY1XHnW2H0QBHXZKlrR6q4eBsxF+D6MnVJ0Xyg2RgiAzxjQkTDfC+JGoTh9Z?=
 =?us-ascii?Q?/jHAro2Oaz4pK3Yhq3JHxV96IpYKkzZ8Go3RlC/YEvshdhEaVf32KMB6HEY6?=
 =?us-ascii?Q?fJfrqWzwl1wtkhIz6IIbvNgCcADzWG7MT5LMwdLOjjF/TnK6tps4uTkyop5K?=
 =?us-ascii?Q?hPSqwXkN7i5J9AJiRcU5cJ/nKSTh9el3rzoyIxrDEwbu9mwTOBhLWIpWGR4t?=
 =?us-ascii?Q?zRGtP8hSpTbMyXQgxalCXrccByJZtnB8KI7HW9+9VKm43QznuEl8lCnQbYWq?=
 =?us-ascii?Q?r2fFuhwtFhv5Vhu2FVMTG4+d23Uh5hFEbZJm6kOl8f5FTZancGc0bqUtzWnp?=
 =?us-ascii?Q?zmlQAZgyOMVAC4qHWC4iv1VSFnXX9iyo8fgVEX3lx2rkbXEaFeUVhyv9Ki3R?=
 =?us-ascii?Q?wrbuql/Yyf+KPfF7w6aCaZ1JGuvvwHC9dGynd5FOpp5R5vMHp0OONJ5mA1fa?=
 =?us-ascii?Q?Jem/qxhViRHYRP69OJ6tBhVy6W4+Y3g1RbGQHJAYUaiFKbCfsTLFNhOW39oo?=
 =?us-ascii?Q?PmJRy4uyLmQv2X2LZqPWOL65xWNwnVww2QFoEFF0YG06oUZLXU137Dr+aBDb?=
 =?us-ascii?Q?OkVGA4VcOUTc9slLz0ZwTNx6cXNJdGUoRh2z8pkqszRN9sHhyZYybyEKH99H?=
 =?us-ascii?Q?xnWDXGrnPfCxE76T+C+t8aTXG/62XLNM4TQbxpHAgK8vYSknyaYiH9FEw4yV?=
 =?us-ascii?Q?Aj+evMBbsNtkVeMEw9ZbMBOwpTvC59/iykUF43Uh0XiszGmhKCpUGvU4YW6Y?=
 =?us-ascii?Q?occqXNPHjDFihuYOVfEQdx1dgyx65y4eH9MNrzlu9hmG9TCtUh8tcDM/uA/i?=
 =?us-ascii?Q?BgW20XGvHzeHOW3nf4cra6nE9naeJgfeaFy+aP2nmaDkzXUeu2+TVRgMUTQz?=
 =?us-ascii?Q?4b9YcBksic2XgOXVUBl1IiU9XhnmazfyYgIEVm1uCHI1ter+UoWSWWXHWQdG?=
 =?us-ascii?Q?sYUcnCWZSairXKslgmZUf6yuKE6hUTP4evVM3YRaJ6kIqb00eME9B7wfzNNT?=
 =?us-ascii?Q?ijrM4G1uMh+uHXryEuZHy3ukZ4C8w/kLIko2SNWniV8AXSDy3zrV4D69yGy7?=
 =?us-ascii?Q?vz7dJA/nHfK+qzkgo0qg8Yg1IRQwGAO3KipoobUpzfVsYctfNy0uMoa71rAy?=
 =?us-ascii?Q?Oe2QB/ziBo4e35phx4VDJ1TY/c1WtsDDfa2/ye1zulyIZIqPCYrFr+fRcv0e?=
 =?us-ascii?Q?SDlRV+wXvb8PmSBlG3ztZ9MUy3oZtK3KctM4Ryl1Lyoel65Kv8zevEqW0b39?=
 =?us-ascii?Q?deCBbEaZudgosLvGTJxwmxb56IvPi17uhvwWZnQTPArzFxZ9umzjMi/zjiLP?=
 =?us-ascii?Q?7MFgRLMinB0tlXjPSKCHcQTAfQSK0xsgbKe37naNecw5qbM8IfeogCTj4842?=
 =?us-ascii?Q?pbuVFUFBDTeRvozKip6JBh8Fv9fJbxxGC1zTdJhm86RDqz4T7P3dfIUzaqBo?=
 =?us-ascii?Q?Xd8TEjoukA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f23e87eb-ff9c-4ec3-15b0-08da163291f9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 11:59:28.0323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lxDgTb4RqQTuXsdlaXjaVvcrOhyV8x2QHxVQUDdO/O92D5k0yRRqn8EwkwEAEeNISlgaDstlgvlO8ah8PBE1Hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7333

On 01.04.2022 14:02, George Dunlap wrote:
>> On Feb 23, 2022, at 3:58 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>
>> Rename guest_physmap_add_entry() to p2m_add_page(); make
>> guest_physmap_remove_page() a trivial wrapper around p2m_remove_page().
>> This way callers can use suitable pairs of functions (previously
>> violated by hvm/grant_table.c).
>>
>> In HVM-specific code further avoid going through the guest_physmap_*()
>> layer, and instead use the two new/renamed functions directly.
>>
>> Ultimately the goal is to have guest_physmap_...() functions cover all
>> types of guests, but p2m_...() dealing only with translated ones.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Reviewed-by: Paul Durrant <paul@xen.org>
>=20
> Description reads much better to me =E2=80=94 thanks!

Well - thanks to you, as iirc it is largely based on your suggestion.

> Reviewed-by: George Dunlap <george.dunlap@citrix.com>

Thanks.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 12:24:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 12:24:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298308.508130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLkr-0005MJ-5I; Mon, 04 Apr 2022 12:24:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298308.508130; Mon, 04 Apr 2022 12:24:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLkr-0005MC-2B; Mon, 04 Apr 2022 12:24:21 +0000
Received: by outflank-mailman (input) for mailman id 298308;
 Mon, 04 Apr 2022 12:24:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbLkp-0005M6-D1
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 12:24:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 24cd6949-b412-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 14:24:16 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-FBN4-9o8N3KyuFmjP7A75A-1; Mon, 04 Apr 2022 14:24:15 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3901.eurprd04.prod.outlook.com (2603:10a6:803:18::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 12:24:14 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 12:24:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24cd6949-b412-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649075056;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tjMnPwZ7m8IZ+ecuoW6woJMJGp6qfOFF3ydUULjBm7s=;
	b=Nafu83mRl8juRIT4EM0VFlFpyQD5kK3hiYEH9yCADI7qLi1jIa3wX2AgPGz5AIRRrOzfnl
	PJZ353JwYKdwqQhWOWTAAsmfk1ezw3TDAbWMYagVLG9wLFCzcoOnWg+9fbBp3Iru4Qki6S
	xdDEPUeCijNqw+JDMapI4Jpk/oEZyec=
X-MC-Unique: FBN4-9o8N3KyuFmjP7A75A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UBZK3+VkR7eK817BA8XKvu2vp1d8TW357VrZdnNy5fDM15ZpqyruST3PUgTd4yR9hyBm24yTfmCPR7adcpU50cEw1g/pBZw5NVZc+8y2GZAqPJIYHZoykO5njMKXrwFe1oiiJDhpqAwJqWCQaurzb2CBUU5F4S/qR1WolU53p3KlHec/3koiUALtnCrgK7PNglInnmVZrhGJXUMn9RW6kEwbMJaR/pzCl6TFVPLUb8Sx2m+da5vIX5115YUjp0diHS1MUlXHlVYXuRcoITVXV3+hp0/624kIdoXSTpdU4et4rwWpnixydQ1GpyzxV0wtXVJCfxLTTm91qaURQeyA0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Sxm8HqgC8PexNqelQlzfhshAZSS8Xd130eZQG9yoWY4=;
 b=F3JiEvNaSxwYIiS/dL5szzstaYY++fjwJswEzXz4lgxvevNd2xY+Z1pgZqJO06yPINFwlDesvWzwDCcsvM6spm5JvqYT+DUuHrBwdrUYtU08ofXI2B4G9ii1u425mObouHSLwzQ6Zym77CguprUmBp1zK8+Isgm6hCg16eTeskWiX5UMZPbZS1JoZZaeKLA9wkwpFhHVnMWT4wSx1DVO6yMSumpSTB/UjYHlCXZV6b1XttMDv7G2L8IHPXzfJ2d7xoHBb6eDzq2FS5LMM/cccK9CYol8X7b91DHCDxA1s2T21TTqDXhZlPmCpfIY6+1wGdRJn9kcnhXmT716mo6+bA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <42795f0b-0fe7-0bb3-a4a4-fe4da986e889@suse.com>
Date: Mon, 4 Apr 2022 14:24:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>
CC: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org, scott.davis@starlab.io, jandryuk@gmail.com,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
 <90fd48a1-446b-fb7d-a732-d2c1ede0921b@xen.org>
 <Ykqnj/7gEc8Omsvr@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ykqnj/7gEc8Omsvr@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0300.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::7) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2d238148-4fdc-424e-edb5-08da163607aa
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3901:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB390138A51D867A738BBC1C97B3E59@VI1PR0402MB3901.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	K7e5Bl5XXWnhreij3CPDoNrBwfAKj3LJdjNPI7QUq32cN8m83YJfjbEJlEuaR21Crne4AGOs/wGOlyjL14AIsckPm+O49A76U3UT2/gpauUv88I5aMkKpGwEW81IrJQ5aBH5VxVXBEzZxXcM5Qr1vQ0My7vxo2jBqo1Y6eZ5LnS+0rZL/6pwcT9cdmDxYI8vBM43k0wHM2ozyOQA3d35RIdYdIpFS/qoOQC7UcL4BbWSNXfUNXWsSuc1wOw1dtwH7Mw3La0s0eYpTb/HfM4/8Gvq27IrP+SRvwV5rEHV80Y/tYg5kdUVU0guSPkdHeI7dHeiCVRuoQF50agExi/Y1Fh0I1RvRdh1WpwN9YzQSvXdx3AryCOtzLwxkoYWJ3gAhnJpfivq4t2msZJ0ssJ3e8UC+nbAVPS3Cvdc+5AmLgn0fEWRC1Mf0siK4A1UmERlbdUF/olGFwlKW62BJY3FhCzBBcKK5OZ8W0ObHb0MTpaX1fIkAVxJGHc9tpuDNaVTgZVtx8y06T2Ccm/pQE161eT26zm0Bop7S2HZtsfOulJYP9/0WoAdRjjVugRFMzhBNMCbPlZb1Mg6z5lAOUizJ/OjkSPiToYczednIi97Qrxn1DuDGEj9KQAeh1tHYicMDQsQbGjQ71LOCW3tXSgbveZlhifTgzS5o1DxYn/mKzqGC3YPJLI2wdQZXrePiG62Xi3SAjvT9/j7AqzF5V8zn2AzUuBRLfgACqcjxBECtoc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(4326008)(54906003)(8676002)(5660300002)(6512007)(110136005)(31686004)(6506007)(6486002)(316002)(508600001)(83380400001)(66556008)(186003)(26005)(53546011)(36756003)(66946007)(38100700002)(2616005)(86362001)(31696002)(8936002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7KvcJ+j/yt79A6yPn5mXbA4bIlWi2RrcBEyNbHTAd9k8uYibya51tvSRIHO0?=
 =?us-ascii?Q?wGjYyVAdoPe5n/JEX47v+QNm1vjfBDV9eujjmrmENPVnNUOusHXdJxU7MOia?=
 =?us-ascii?Q?jRIxsyeeb4LHQ9ZuPEZ+uKNK664/N6aifdyA9PxzwTH1p8ObQIlQbUdHIWep?=
 =?us-ascii?Q?XbnWq3+DpSiTThv6OuGC2IG65jjtxDKT2vnZtMlueoSjUkFMlLFSf3KVwnVa?=
 =?us-ascii?Q?mw7H3W2JUw5O19u4xUC+76uUnT9Xexak6rq4L1VJRylkmKdyu7HI/0ot2X/k?=
 =?us-ascii?Q?E68ay5kTbLZ11CC7+wzi9NlU5nzoaL3eZgMGKBUlPcvTu1sUhYJHQFuz/UNK?=
 =?us-ascii?Q?ouHXgRCpjZQHkemscNAZ/71DwCV/3MeLGVG3CuKg9vxzfW1pocrZ6gNre+3J?=
 =?us-ascii?Q?arzZqoAinRxc8DZ7v7LKmlrYNbq8UvAUbZdLDCLyCG6vmAKKaRAIjoOea1rN?=
 =?us-ascii?Q?Mrf28UOEX+4XCAnfadSjTRX32fqul1oOulnDXPawprbJklmJPIyiMoetRNg4?=
 =?us-ascii?Q?kk/kkgx16mRF5Ffe8Tcp3LwFJnmmt8QWgzWs83Dpeen3iB4YNt1+g/9e3A9u?=
 =?us-ascii?Q?g4/CNDt7uP2DzUsIIpmuyc5aRedspKzN3+32vOm/GUZy6ppFNpJF0y92riVk?=
 =?us-ascii?Q?Fp87lxIhqE03DY0NQrMyHObv0MDqqTCzrJkoFHQRav7l6zQJb57Rq12NcnjP?=
 =?us-ascii?Q?K1tR/2Zck+YY3LcWqcnr/mqXrflX3NaZohjqAPh9LLm/T008ca6kBThfFUvq?=
 =?us-ascii?Q?+W0brMEeqyTknRVCoA/L4w6HGY9s5xMN0pFB0buIi/m0g1rttQsY/+ELU3fg?=
 =?us-ascii?Q?Dlwo2xynjmDELcQX0f4Fzaj1OppsizN1SPI2471Joz2jDDTImgVrxVwNTGUX?=
 =?us-ascii?Q?538V7kod6TC1moBLoq1e+7oXgw1iSN8T7xJqM0RU8RKhT2IwhWGsctp8YYBz?=
 =?us-ascii?Q?0+4VkcvS4WjuTGA1oYnMZynJL/kcDnJZvVA2oryN3DopQ7brLr6e85f5GaBo?=
 =?us-ascii?Q?kyxJKYjH/IV5E1fTUX1u3jMubtGpLCzkt8Y9vpdnr90fLRlH5aDBvZ/wWywW?=
 =?us-ascii?Q?xqrm85aBFg6jG0YzDNHv36F5GTcKbbvB4ZcnzlHFieMGgsMQ9Xb+4V7phzW5?=
 =?us-ascii?Q?Wp/OL0LFpw/RDFhS375/pegcsoqPL8WzCCVeaPP5PthZfHHlNtQrpRNPlWIl?=
 =?us-ascii?Q?izDTsNu2erW7PXuUZBMZwhOvAseQJs5zeL3ppAFlm2MRSX9ktumyxEXtFjLJ?=
 =?us-ascii?Q?Sq8K8yHtD+Gj64EBsv25/iQZUDaepTJzs7zOR4Q/N/uqkmjF7SYHClPpf4qR?=
 =?us-ascii?Q?4y9m2H491NM5klN4XQuJaZtzH2CDiBOcq4Z0CjrhF++UfVVlq5jvZZ41PweT?=
 =?us-ascii?Q?B/qVRy3gD5JkT62M2rjOUsYvPjCnf2BPM4XUTqkiA83EW9fDGwoJdHi47wqR?=
 =?us-ascii?Q?Z/wtPwtd7nZZK46UZeOEGBUbehq4ExP0vzfv6Cf+Dt2TLGnq7GEMMf7dzWo0?=
 =?us-ascii?Q?zq9QHW0d73NjiLOK/WXIZJ5MDu5zKDpWHH8bDGKPKS4iIp3j/OpEnzcx19Cy?=
 =?us-ascii?Q?XcDWe0bP2pW+prIvNm+uDezpfGNWrl+ufoKGcgIwnumPFnvmn573r7qY0ciU?=
 =?us-ascii?Q?wxHF6Qg6taPMrc/X/qKeReveRfzDf9M8rpjc0t6vNZhQmrPIt1ggaMFvco3l?=
 =?us-ascii?Q?yWR+jpzA4U/MDCQKs1jPrfV2K4E5Ggc3RmDoagDjJc/renPZTVLBnUX2Qmcb?=
 =?us-ascii?Q?I4780Hmcyw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d238148-4fdc-424e-edb5-08da163607aa
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 12:24:14.0283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n5l0AjwJ/umrk8JmNWW/NoMH+v5qm2ZfsuHM3ULTZXh7bRnlru9LbQOYkA5PgelWLL5Ru5FHInc4Zz5rWXkoag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3901

On 04.04.2022 10:08, Roger Pau Monn=C3=A9 wrote:
> On Fri, Apr 01, 2022 at 06:52:46PM +0100, Julien Grall wrote:
>> Hi,
>>
>> On 31/03/2022 13:36, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
>>>> There are now instances where internal hypervisor logic needs to make =
resource
>>>> allocation calls that are protected by XSM checks. The internal hyperv=
isor logic
>>>> is represented a number of system domains which by designed are repres=
ented by
>>>> non-privileged struct domain instances. To enable these logic blocks t=
o
>>>> function correctly but in a controlled manner, this commit introduces =
a pair
>>>> of privilege escalation and demotion functions that will make a system=
 domain
>>>> privileged and then remove that privilege.
>>>>
>>>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>>>> ---
>>>>   xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
>>>
>>> I'm not sure this needs to be in xsm code, AFAICT it could live in a
>>> more generic file.
>>>
>>>>   1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>>>> index e22d6160b5..157e57151e 100644
>>>> --- a/xen/include/xsm/xsm.h
>>>> +++ b/xen/include/xsm/xsm.h
>>>> @@ -189,6 +189,28 @@ struct xsm_operations {
>>>>   #endif
>>>>   };
>>>> +static always_inline int xsm_elevate_priv(struct domain *d)
>>>
>>> I don't think it needs to be always_inline, using just inline would be
>>> fine IMO.
>>>
>>> Also this needs to be __init.
>>
>> Hmmm.... I thought adding __init on function defined in header was
>> pointless. In particular, if the compiler decides to inline it.
>=20
> Indeed, I didn't realize, thanks for pointing this out.

The question isn't header or not, but declaration or definition.
Attributes like this one are meaningless on declarations (at least
on all the arches we care about; there may be subtleties), but
meaningful for definitions. Iirc even with always_inline the
compiler may find reasons why a function cannot be inlined, and
hence the intended section should be specified. Plus such an
annotation serves a documentation purpose.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 12:26:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 12:26:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298311.508141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLmh-0005z0-IN; Mon, 04 Apr 2022 12:26:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298311.508141; Mon, 04 Apr 2022 12:26:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbLmh-0005yt-Ed; Mon, 04 Apr 2022 12:26:15 +0000
Received: by outflank-mailman (input) for mailman id 298311;
 Mon, 04 Apr 2022 12:26:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbLmg-0005yf-Ht; Mon, 04 Apr 2022 12:26:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbLmg-00060c-EU; Mon, 04 Apr 2022 12:26:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbLmg-0003Vd-2W; Mon, 04 Apr 2022 12:26:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbLmg-0005Oa-1d; Mon, 04 Apr 2022 12:26:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=W5h5QZpXTBDg54mBeiD5lnM3Kgz7dug2Yv9ILvU3u3s=; b=kyLcKrOKFwNCm6pr82F4S9uM/o
	KxRfyNC/ue5I1spmHJzi0PfJ6+lpgW3xVa1SntWoS+/LXG5dQgp5QT9MCaXYHaZobGmPb+oPJTIgj
	iHKSPpSF5AJMgcDrQ6NGCKK/kuaf4a5XeRSg45Co7O3Var7duJhWvZEm4nd8vXHXr7Is=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169151-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169151: trouble: broken/fail/pass
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-credit2:<job status>:broken:regression
    xen-unstable:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d62a34423a1a98aefd7c30e22d2d82d198f077c8
X-Osstest-Versions-That:
    xen=d62a34423a1a98aefd7c30e22d2d82d198f077c8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 12:26:14 +0000

flight 169151 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169151/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit2     <job status>                 broken

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-credit2   5 host-install(5)          broken pass in 169137
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 169137 pass in 169151
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 169137 pass in 169151
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 169137 pass in 169151

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 169137 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 169137 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169137
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169137
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169137
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169137
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169137
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169137
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169137
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169137
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169137
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169137
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169137
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169137
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  d62a34423a1a98aefd7c30e22d2d82d198f077c8
baseline version:
 xen                  d62a34423a1a98aefd7c30e22d2d82d198f077c8

Last test of basis   169151  2022-04-04 01:51:47 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  broken  
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-xl-credit2 broken
broken-step test-armhf-armhf-xl-credit2 host-install(5)

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 12:43:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 12:43:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298321.508152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbM3k-0008OZ-7r; Mon, 04 Apr 2022 12:43:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298321.508152; Mon, 04 Apr 2022 12:43:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbM3k-0008OS-44; Mon, 04 Apr 2022 12:43:52 +0000
Received: by outflank-mailman (input) for mailman id 298321;
 Mon, 04 Apr 2022 12:43:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbM3i-0008OM-Ty
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 12:43:50 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df0eef6a-b414-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 14:43:49 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df0eef6a-b414-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649076229;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=NgXwQCXnFLT0lyFMWIhVIKTef2di8i+SEcClsGc1pTc=;
  b=ceD3c36pMFIYHgY5gGcSD4q86pruy+Pt9foUKGC3Nun0FDmnWEoFZ2n+
   zGHPXF3FEi6R2Pqig7QGp5IYzFatDvWM9jRAewKKMr8Jvn95EVI83bpde
   wKRGtObVDtrf8xNyQZ7N0oYYs3wNI4Nw/6nfqHEOHLHF0rfs0IeHypV3O
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68343080
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3qAlL6DnQyZJFBVW/z/jw5YqxClBgxIJ4kV8jS/XYbTApGsnhDMDx
 2VODWzXbPncZjSjLdtzPtiw905S7JSEx4VqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jh3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgy8
 /xk5duoUDx2P5f9ouEvdTUGOC1XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGjGxs3ZgeRZ4yY
 eI9ORBJSSr6USF2BX0wBIhl2+qZu1jGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiD2/lzdMHMJJKLI70jC3z5jyz1iyCkFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqVFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tWuVh6b/PuREDGQ3C94ace51qXHb4
 RA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSLyJdoIvGwifxs1WirhRdMPS
 BWO0e+2zMUNVEZGkIctO97hYyjU5faI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5DRlEUHCb2nPXG/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chUAoLYjrRUr8Tm3V00=
IronPort-HdrOrdr: A9a23:+ptEK6rqcTTdWQN5dth8xn8aV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2+
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LvEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqMq+SWnqLkwxg1MfgOBFBh8Ib1S7qwk5y4GoOgFt7T5EJxBy/r1cop8CnKhNP6Wsqd
 60d5iAr4s+PfP+XZgNdNvpfvHHeFAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="68343080"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IpZT1mAGIxjOyPVXOdMLaNOZX5xzbtZg6ngfM5oyifGvj1ZvELFfmjMI3p1mCkKy6X3hRCPCI5eNECN6ueniqU90It2kJnor8L89zImLBvLXqf/wBAsgqqcsoe5lCh0WbbGnw/uGsOrl+PutOLHnlQ9SBHdFqU9uVPrepsC33Kg3tL+wBUwAiUgQptcTfqaI4h7VjihgJMG917FEO6UKuxd70lPldXseh42X4pm5J8Btvag6eFy5oGyp0gP3pBE6BfVr3eE96V4rNX7lXdO2meDTazR/Xx7UEgyrt41wKgl//ZgnY8AYlw5XEwCNu+BSIRzlsTTd7e4oV5seXm0SiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HciF5PxIQ/A+isnDsu/+Q86UpJzaLpfYjgLF8qaTJ00=;
 b=QjJEt1fSSRsGLphpQ8X9MSr2ioHTfDW4XBGjuSkJgvX74DoWWthJAwnCwt0DOk/g5ib5TmBTmAh/BjL4j23DQzIXhY8XPGUT6VqmqCLROXAKsLtLZy/YdW1QQNH8csE7nmXytT1B54AvqrJYm+Y/kxM6IFgtwb5ngV5GUo+rc36D3avXFDm8L7vaax8rEnIRLKO0U9aOtzulLvU9wn8tEtwaOqDz1gFKsh5bNS5qpPzFA7go9yDz8cEaOjjcZFwjcWzFxYM5n+R3arSse5WRgmJSwzvUwXs4LwNvc81VxSrDslDY+yIHiFNjYsmSUpmfgpDCkTbE35LRDn24PSfgsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HciF5PxIQ/A+isnDsu/+Q86UpJzaLpfYjgLF8qaTJ00=;
 b=rMrq64PUB/eWI9MeiWdj/og/F1CeE6s8fM0jf2rPwrYVKTX5Y5vr6NDlMFgFQRfmdtbCVq6gVoBVPYOKVL3I7XsF/w6vmqm/Fe3/w9qBnmkRyX3G6HGT81mJzE43MoNAoU5LDsKTMrz18NHZ2Dkmvb30BaZ4kj5rOBv20RHszdY=
Date: Mon, 4 Apr 2022 14:43:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 1/4] x86/APIC: calibrate against platform timer when
 possible
Message-ID: <Ykrn7hTD0r7fC1WU@Air-de-Roger>
References: <6e540bc9-c536-84ac-fb1c-8271e7731b3e@suse.com>
 <37ee7fe7-1218-7fa3-bc29-0fb45389bf75@suse.com>
 <YkrapvsmmjcZkwSj@Air-de-Roger>
 <95654e26-160e-8664-23c6-ad5e4c87f444@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <95654e26-160e-8664-23c6-ad5e4c87f444@suse.com>
X-ClientProxiedBy: LO2P265CA0099.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:c::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cfc50563-e5b8-46a9-75a7-08da1638b8bf
X-MS-TrafficTypeDiagnostic: DS7PR03MB5640:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB56402FAB72FA0B04AE773AC58FE59@DS7PR03MB5640.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8b4SfyI1D/OYzAE+clrqf95ezWPO5ACeb7K9HahBEdzhul0ZCb8nyWcJoabGcoDwUwCFKS+8G9T0Ryh8Rkch0msVBZnawJwglihKg+FU38n7TRo0FWSmouFRZAvuJDfyemDMS+cI83kTAXsfXMGNFHtVvv3dpSeKUjiomvojsKsUw1AUVEkcbV0c563neXHvgvL+6EsrJAflDwCBj5E9SrfiEQizc9C7zN6MYGVyYzbgZJwm02FPNnLjPI7Ukl2SYkO1/6Ckb2VxjursKE8dkeIydtFjBLYY8orgfBVCUoEuLHh34QtWst5zeB5kCGqsCRgzftOSP+VOIJSIBRsEKANF+9biv1emlm41mKkNyAC/Jw3U369h52ld00KBVRkkJ+VjaZwwXYQGGScRB1mkTBb4J5bQ/0xB+vjQdTrLs4IjSr5hipYYr3mt1dK1Pd2jcnw7Y9t0510Ft0lxUpAd6Y+E4ZmLlR2JeBWhd64tq6NsyyytOIcVUPqwNNTWdFqYlgkg6chtYDKu4HXYGtm77RNIIlYd0Tx4zK5DrBcLOivfzOdknH906Rac+oTTEcAb9AanHnLbHxY1lUhfJ0vc6GWpIb5DHmk5VLdteC0ryIt7WgYvcYz0qK2+WCQd7mb0mqJj3vNzGOsVCrIA1MMd9Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6916009)(186003)(316002)(5660300002)(26005)(38100700002)(54906003)(8936002)(83380400001)(85182001)(66946007)(33716001)(66556008)(82960400001)(6506007)(6486002)(86362001)(6512007)(9686003)(66476007)(8676002)(508600001)(4326008)(6666004)(2906002)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0lzR0U3cmpFNjdpaU1GWGRVTWVjMWhhbGxaRjlGSFgxQ2pwdjUyT0R5dWNS?=
 =?utf-8?B?VklzWjN6WitZa01rdUtuNmI3c3ZqZUZ4QWVyUlIzRHRweHRBOVEyWU1Dbk9w?=
 =?utf-8?B?Vy84RldvdFN6NXRId1Y4V3E0V0FxaWVybGt0dGFibzJYYi9FanI5UGNsZDJy?=
 =?utf-8?B?dmNYeWRQbFVmcTAyQVpSUytUa2c5bEIyMTFJRm9YOWU2ZnA5NTlNSnh4UlJi?=
 =?utf-8?B?ZkN2UGZvMVRpK1hkZ0RqcmdGcmV0OUpHOEhnaVl0SW8yaE5Ba0dEVjNLdCtx?=
 =?utf-8?B?UnB1eTAyTlVXNjFrRWd1Wm5PUHN4VHcxdStkWWUrc0x5ZURmTGJXSlpndXp3?=
 =?utf-8?B?ZDlrem5jbks2cHhkci93b0dpRmJsRHpydE05VzFRZlZyVDRDcVdQdDdRV0pF?=
 =?utf-8?B?a1lKbFNTQmFtMUsyVGxxTDliTEc5VmZrb0w3TG9vME4zMlMwamJjR2l1MlBm?=
 =?utf-8?B?OElwKzU3T0lNVXZYSW53VXZ6aytvNDg1TE9iRzl0Sm9VbzZMRW5CL2xRUlZp?=
 =?utf-8?B?Y3Eyb2NFamhLY1c1emJnWm9DenNYR09Zd1hHaVEvWXBJekhWcE5WTVplNmEy?=
 =?utf-8?B?QXhWSzRkRi9FQW1KL0hWejBpd0FqMytkYTd3V0VRZEE3RGcxQUhTclloUXF3?=
 =?utf-8?B?S3RBR2h1Mk9PUjZkOFdoekdxMG13YmE4SEZPUHljMHVIaVpZWEluNXNwSHZK?=
 =?utf-8?B?S3J0YXR1ZkJMaS9aOFhZR1hKZ2RDWUUrRC9KaEVlUTZMc0hmeE91L0JtaS91?=
 =?utf-8?B?dHdLNHUyYllXbW9HSUFOOHFrc3JVak4rdk1peGZIYXRQNXpyc3djMUc0Ymli?=
 =?utf-8?B?NzBWNFNKUGJ5SVZJQ0h4bGFhZXF6RFNTcGJXa0R1MG93Q21VVVR3VjF2ZENn?=
 =?utf-8?B?dWZMdkVlbXpqVVY3eFBmdWZKL1RoVGc5R1pxMFBpZlR5QWxGclVMVTdDekZF?=
 =?utf-8?B?Sk4wYk1GMnRWUTlPQjFyQlkvVGg4dytzVHNsMzRWTUh1SnZTNnZIMUtTRHRE?=
 =?utf-8?B?MUUwUmh0UkRIUzFhcmxEdk1PMVR4SG1nRFpXZTZYOHkzM1FKeEdodnBzYkxO?=
 =?utf-8?B?ODFzdW5YWm5xMVQ0TUhSTnljWlE1Sm91bFZFd3JXRlMzZmdWQzhlTHZETXhB?=
 =?utf-8?B?R09OSUVHUHlWcWFlQ0VaZDZ3d1FWT2I2TENmYk94VDdzcmFoT3c2bm5wV2JK?=
 =?utf-8?B?aTJibnovMHlua0s1MU9jTWg5K1JCYk5jQjNpZWpPMEtUTDIvRklDTEdUUkNB?=
 =?utf-8?B?TTE4TWlHbTFSRGV6UmxYbXg4Nkhhb21GRExvOEpVY0tSMGlRcVN0Mm5TS05x?=
 =?utf-8?B?SVd4OTlKdE5Vb2VLYUNjV0lFYTZ1TWg5UDdQbVZQVmVOV1Fxam9takVLdUlS?=
 =?utf-8?B?UlY4dkFUV3AyMXRnMHdmOXRWWWIwLzdJalVQaGgyRGROSHBHWTRaekZuWVpx?=
 =?utf-8?B?bE5CTnZZOUJKZFQ1V1VGRlBxMmo1eWFuVEJoVkJ5UHN4MDhHdXNnTzJYSHJQ?=
 =?utf-8?B?ejltakFzSHFWcmpCWXZMeWVDblFuOXhkd3NnME9vanN4cng4NzRrZndVUUZV?=
 =?utf-8?B?eklhNDRPR0J6bUdtQVIvT00rK3FJTVA5U1ZXU3dkZ28vWkp0N0I1anl2Zzdh?=
 =?utf-8?B?TXkxUEYrcFFNVW15TXlucTF0SWZLSGpVcm9Jcnd6bTZDZWpseEFGOGdIZExa?=
 =?utf-8?B?ZzJ3UUMrK0lRNTFJckVxSzJPaVJHOEgwUFJnTGRaMTREZ0xTQ2xGam1vMGRM?=
 =?utf-8?B?NXhVbkU1ZDhJZ091c2t2czhBNVBCaDlSQW52bmh4Ykc5c01WTm41YWFOUUU0?=
 =?utf-8?B?ckdQVUF5WjFNSU5iaGlBRUZ5UGRrMDZPVXpTMzh3Y0JOQWl4K291Qk00aXNO?=
 =?utf-8?B?SmlEWC92TWxIVUNKTksxNjdkSFZVTkZxT2ZVbk1NTDAwTGJBKzB5TFNwdzdu?=
 =?utf-8?B?VUFGNjcvSm4yVVdPT3g1U0hxMFZoaVlkV2ZMS3J0U21jRUJzRW9ocDdXTys5?=
 =?utf-8?B?LzFLT09tLzBBMEVyTWU3dkJ6K1o4bTVGR3ArMkxzNnJWYkdVUnJuS1RPcXMy?=
 =?utf-8?B?QmxFWmpYSGQyNHY1UUtVaXhjeVdhTUJpT09SdkMzdWRuWUo0Z1dycGcxV3k3?=
 =?utf-8?B?Y0JJcE4vdnpxeVRTT3NKWDdNZFdiWTFBVGRrbWdNb1dza2hYQ0V0Zk1GMFNz?=
 =?utf-8?B?VU9aUGpzdFh4ejJYRklZeVE1MHFuR2pkb0lzajRrZjM5K3pta2FhektHcll3?=
 =?utf-8?B?V1MvZWF5WTh5cngycXJtOTVHbzltelE1ZnlZRHlIZEZjOVN0UlQ1aDF0STdn?=
 =?utf-8?B?YmdtUXJ2Rmw0UFJ2SWZ1TE1icXM4SEREOE9nMFllQ1dyaVlwWXhQOVE1eHUv?=
 =?utf-8?Q?LxWUM+DgYpdlzhL0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cfc50563-e5b8-46a9-75a7-08da1638b8bf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 12:43:30.1756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TON7nCy1YL1MhqgIuuCwt5t8y8nTzkq9RqSe5kAP+OcjNYwS5neVAGAEBtOU3nrlq7vzahEShFGXie4Juh0/3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5640
X-OriginatorOrg: citrix.com

On Mon, Apr 04, 2022 at 01:55:56PM +0200, Jan Beulich wrote:
> On 04.04.2022 13:46, Roger Pau Monné wrote:
> > On Thu, Mar 31, 2022 at 11:29:44AM +0200, Jan Beulich wrote:
> >> +uint64_t __init calibrate_apic_timer(void)
> >> +{
> >> +    uint32_t start, end;
> >> +    uint64_t count = read_pt_and_tmcct(&start), elapsed;
> >> +    uint64_t target = CALIBRATE_VALUE(plt_src.frequency), actual;
> >> +    uint64_t mask = (uint64_t)~0 >> (64 - plt_src.counter_bits);
> >> +
> >> +    /*
> >> +     * PIT cannot be used here as it requires the timer interrupt to maintain
> >> +     * its 32-bit software counter, yet here we run with IRQs disabled.
> >> +     */
> >> +    if ( using_pit )
> >> +        return 0;
> >> +
> >> +    while ( ((plt_src.read_counter() - count) & mask) < target )
> >> +        continue;
> >> +
> >> +    actual = read_pt_and_tmcct(&end) - count;
> > 
> > Don't you need to apply the pt mask here?
> 
> Oh, yes, of course. I guess I did clone an earlier mistake from
> calibrate_tsc().
> 
> >> +    elapsed = start - end;
> >> +
> >> +    if ( likely(actual > target) )
> >> +    {
> >> +        /* See the comment in calibrate_tsc(). */
> > 
> > I would maybe add that the counters used here might have > 32 bits,
> > and hence we need to trim the values for muldiv64 to scale properly.
> 
> Sure - I've added "But first scale down values to actually fit
> muldiv64()'s input range."

With those taken care of:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 12:45:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 12:45:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298324.508163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbM50-0000WG-Ie; Mon, 04 Apr 2022 12:45:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298324.508163; Mon, 04 Apr 2022 12:45:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbM50-0000W9-EM; Mon, 04 Apr 2022 12:45:10 +0000
Received: by outflank-mailman (input) for mailman id 298324;
 Mon, 04 Apr 2022 12:45:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbM4z-0000Vv-MD
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 12:45:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0effcccc-b415-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 14:45:08 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-6eENlGm7Pd6CY7zryhzWDQ-1; Mon, 04 Apr 2022 14:45:06 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB8910.eurprd04.prod.outlook.com (2603:10a6:102:20d::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 12:45:05 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 12:45:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0effcccc-b415-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649076308;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m5IOVzd+AUZ3xE5KkLU2uRKIhBi+56SI5faygOZqUSw=;
	b=OfbUQRDuFi2Tv3WXVyK92EsR/wDgEb+8dUdsDV9cncWXB/oJB9uhj1yMJsW8X2Tsr4zFOg
	rdsINgWUo7mw1pljWowAvDwtuTv95UAJFDh06M9Yx/8BZAlv6YuR0ziMdEzA5GQ2uskyqt
	r+O8cL7lxcS4OMnyot4iNwMxNE9ljrc=
X-MC-Unique: 6eENlGm7Pd6CY7zryhzWDQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DGuqr/WNEaV0PqHQ52N31gAY1zQwmxanRXphhtCchVxb+KBZAjIuKtkP1bvuqV2ICwQejJHsve9uf4rf8kZiVntpaiuU53aGNDxmNJW53+Y0wDFEIHeYX4XrlgPA8KfAOHLPxndjQ6aaBXKNJg0hA/F4SjRKp0bdmv0PzzgRhSroRi/EKUpp0i4Rji8c8A1OiqESOvItY+RNAix30qYwGGjlHB+R0OHrmNmCK8C8F3eOzGHLSvoqbx5K7kxH3RcAQTbxz8U6sXt5S9ekVa6FJ4mUNYpMcgM39o0yrNStp45gokXUSCHW/sIqntBhoC7FEdf4uDGFz8StehZltxpTmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m5IOVzd+AUZ3xE5KkLU2uRKIhBi+56SI5faygOZqUSw=;
 b=MC9yFRl2lHRnXYwbQlkytkGb0KbuFgm5OBuy/XqMISDsRlplxhWuZnLDhnmbaFbTmcXFsF8NtL0NdS3Eafv5ibPb3pKU5KC9kFcvEHPgUlx0jsgnD8WY+oNTDIvzo6Ruqm8rsfTmjO/vOfd3lIktKoNw5I2k0STzm7EL5Xyop5uqY7gO1R5mCVxPYDlZNByNVKWefyBTJjiro33RIhsq/MAq4HDy0U64+BPj9oC7GHBJjErv3rvDIlJkqEN9tPUy3xaN7zztCR6jxrunLXuQMTExBRk4FdfkDvnPX1uHR+wlTg6Dh4B+UlI69mtxJ8TZWnWdjbMASEo7ptOv4Ou44Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <aba2f53d-0790-d337-ce9f-76546201bcdf@suse.com>
Date: Mon, 4 Apr 2022 14:45:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property
 section
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org,
 Roger Pau Monne <roger.pau@citrix.com>
References: <20220404104044.37652-1-roger.pau@citrix.com>
 <20220404104044.37652-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220404104044.37652-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0005.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 719af704-9fa2-4bea-e678-08da1638f155
X-MS-TrafficTypeDiagnostic: PAXPR04MB8910:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB8910C9A88BD8CCA342ADF81DB3E59@PAXPR04MB8910.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9UHBmJlnPmdT6Zd4Yi+CotS+ciyAaoJqizDWhF4VV2JtHxSVo682LJJpTTr+IoiBeYxeVL2LUH5djuu2fiiENXux6RXMLlCNClPWeFCn4BvUW0VbLKhJZPQorfBC8DKhdFpuxJTPmsDS/HB8PM7e4y/+5/8A39vPYVpjlxJmFEKtqzyE5aiuROQeFj1Rk3bVY9tV/TakgtzJp0KSG19ZJJEJgHAzCn9cys1HIJey0OBILjBZRZTinb7VSJosmlug/WH4OYM0YAYIgYnPrH9LjDy5PDoGUhJtnUZkO0rUIFSKnMPZfXPl2Huyy/uRX4SBbQKfUD0juslroLVEpStqV+WcUpPgJQ+d1H4yanKcFhrYuTKJoAvVqRpT1ngvyriCsSmf2so4VGyEBlizPs5bTYt7dYyC3uh7dSDLib1i/O2ZqonlxDHmYzGVyz/JysDaFePKiugH9dybh1BjeK+HcZD/vxHjBVxQv1LfEo6zEME95t8sXOT7HU9L2PxFihgmr/P3f8b3sK5Gm80AwqRITnN9lvQe9a+iflkwpgTL6j+PxCI0Zybscn+WARyZDWI7Wne04e0Lgtor2toqHGrB6dtr/h3ryqleVqi4X3Gyach59eR6yM4WAvbzycMjsayh0hgcSvE88Zenh+xoH3Pz0MmW68ZB4YlWW3deCIB6zXEcGLCPNyELqiHx8WdY9GGkRbZBZxsshfgJ9/G94IGJxIuiGgcI7nAWwSwWGqSosp241YKXoPa3RKWqLEOttYLjnxvGSv4zZF+nSmbglJ1f+Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(4326008)(8676002)(54906003)(83380400001)(66556008)(66476007)(86362001)(316002)(66946007)(6916009)(31686004)(508600001)(6486002)(31696002)(6512007)(5660300002)(8936002)(2616005)(53546011)(38100700002)(4744005)(6506007)(186003)(26005)(2906002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aTdqN2oxQnNhOXdCWTlUeU9EUUxFYUV3SXlDR2Zibk5kMUNNT1RwZjFTYWw0?=
 =?utf-8?B?bFEzQnhkTXNYK0l6UXVmU2ZLWHBFc2RVM3VWTENzQzRhTGpuQi9kRWlmRUk5?=
 =?utf-8?B?TGdLSkQvdVA1QWdEcW1ORHNlbGVsbUxLend6RFdNWjJCRmh0aEg5akk0Z2Nk?=
 =?utf-8?B?YnRoRGNKR0V1RkRSdlBKR2M1djYvdVp3VGdxa0poYkV4L3psek93blhaZmQ2?=
 =?utf-8?B?QlNobTlYUURkc2RjTXhhZVFDOE1SZjkyTzZIWWNPTGo1Zld6eE03N2g3QVpI?=
 =?utf-8?B?bDB4dDM0T3NONHBmcURZT0U1RG9DOWhNSUlMcmtzaDZwdERUVUlXdnN0WG9Q?=
 =?utf-8?B?WUwwYnRHcWFVNENsSDg4d2dtZ3hrTDlEZ0xZMzNxWjdiQ0VZbENLQmFPMU1m?=
 =?utf-8?B?MTBXNHNsNEc4dUllbGZjV1hoM0FuWjJTTHdnUnVlZ3MvU0pHVk5MNDVEY2JB?=
 =?utf-8?B?ZlZybGpRTlUxcHRIeUZKVzNIOVhLZWhBSmJJd0xYTG5DSzV3Umo1YnZpejhN?=
 =?utf-8?B?UmQzZFZQUDN3M1BabVNDWkRrejFXZFNhclRzeWoxS2xPUGtnUThGZmFRSjlF?=
 =?utf-8?B?eXROSzJWRVlQbUsxTHFDb0pLS1FoRjZIZFZQV2o1Um9BcEpaUE84MWFKYVBZ?=
 =?utf-8?B?d1ZwRjdaODFBM3VnSUF5MVFSV2xiU2d0K1Q1WjFYcU56b2lvWTJCSnhFZUps?=
 =?utf-8?B?WG11WWNldzNzL2FrbGxiOTl2S2xQa0JMTkFvRGRGdWJ6UWo3Wkd3QmRLK3hW?=
 =?utf-8?B?YWJPeEt0c2t2TUtnNWcwc0FIbjh5K0V2bEV1ek55ekM4QXJrNzRkam1JSG42?=
 =?utf-8?B?aEdIMlpJWnB5d2NxSFg0V1NhaURCQjZ2SGpBUTJqMlV0SUc5N000bXg4Vk1B?=
 =?utf-8?B?T3FENUN3UTBjRHJ6SWdSLzRvdXB1MlBwaC8wZkh4a2ptVXErR0c1TXNOY3J0?=
 =?utf-8?B?dUF5Mko4Q25sRzY1cVloOE1yRDlNUEk5cnpOK0c0bWQ0Nk5XK1dCcXBmSmY4?=
 =?utf-8?B?bUdtbEEzNEl0YkRUNk5kK24vdjdwRENmME1hWmQ1WE40anhINGtqQjNPTW5U?=
 =?utf-8?B?OVBmdkhuT1UrMmU5STdQUTJIRnZjaDNFdUhwbWlKYmV2OTBzNFlKS05PdFlo?=
 =?utf-8?B?WGs4YSt3NjdPNWNUZ3pJcWYyYjNJS1dZUjF2ZXBMYUZZM2JnNU1qUjNVSlZn?=
 =?utf-8?B?NnpNcm9xREp0dWxNc1dPRjRyOGt2aHFEalE5OUIvcjJGV3hwRWhVOWNQVUts?=
 =?utf-8?B?UEhaeHlpYlQ0YWRlaDJGMzhUemxYVlRsSmtCY1l2SVowVDVieHVOZG1MaGdy?=
 =?utf-8?B?bWNwMXpncWlsS005SjZYOUswY0IxcmRaSjJhZkYrVGVWdG01YXBNb0hMMU02?=
 =?utf-8?B?WURrUmczcEd6MzFDRDZQWVQ0NFc1VTRyMW1ySTBBR2R2dUc4Q2Z0ancrTE1r?=
 =?utf-8?B?ME9YWklnRm8wV0ZoZVpyKytuVGpXWTBSYmtZeHIzNXpjZzB2SVNqRGJMNTdY?=
 =?utf-8?B?SmdiYlFqMkZ3Zm9heUVURVNWZjJDY0dDQVlJZGkrODE5R0lPaU5FL2ZZb0pP?=
 =?utf-8?B?ajRnanY1bFZ3UTc3YlAyejl3ZHRzTTFZZ1k3cElKNmhZTkE3cVo2Y21RMi9F?=
 =?utf-8?B?OXdKN0NUaUZyd2FOTlV6QW1UOStRcEI2ejVJaWc5dFF0TGZWUld0Q1F3UXND?=
 =?utf-8?B?eVB5a0pnY2JEQmhYWmFwTEttTk02ZUZocGIyNkJ4MXVQaVZBbWQxSUE0QW9U?=
 =?utf-8?B?UU05N3pkRkFOWjJrRlpLY3JBZTZKOHpXbFZWbEpRQkhsM1RMdjJONmFUai96?=
 =?utf-8?B?ODNIRHEwdVBudDNKcnFVV2h6Znh1VTR6NzFHdkJQTzQwb0g1SlFwN3g1YWJ3?=
 =?utf-8?B?WU5VOHRuZWN4cHJqQkJxSG04NkZUSDhKazRKYUo1RVBUcTM2UmJXaHJwY1Jj?=
 =?utf-8?B?UXluL0lyYTJyT0hEYnpOMitUb1pNbGZOem00bDJYa0ZZUVNNVkxvNGtUMlFK?=
 =?utf-8?B?VHNFVUorS3A3aDlBREFsbGRTRnVlcnVFYjZqZjBLVGdEcDQ2VHpTRkk5RDF5?=
 =?utf-8?B?Mkd0WmNIQ3FkdTZYR09lcGhzbFpZd1FMRnJ4ZE1oN0NKeWRHcVVTd3hwdG4x?=
 =?utf-8?B?R3lrQk1LY3EvbGkrd2JjWFpsVnRZbWQyU3BkcUlGbyt6ck1jdVlQMEhoR2Zr?=
 =?utf-8?B?MmFpZGxodC85cXFxdDNIV3lIbDQvaGhYbE1PNmdkRUh4dlNXOEJpdUljemYr?=
 =?utf-8?B?Y1A1bHVpc2dwTGpRYlRWZGdwUnJCQU13cG9TUWVNQndHVXhGSW9EWlpvbUVm?=
 =?utf-8?B?eEJuOE9nQ0VyMmJyaWZXQ3hDUlVhSE8zOVBkamJtY2YrRTBuM0lsZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 719af704-9fa2-4bea-e678-08da1638f155
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 12:45:05.0045
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yb2XVWgwst4zKYsYx72cOUw+W9Wutpt32IYiAJmfrRiaWYegeYD9EsatCb9sSpvdXBfKeU0DoznC77m1L1/RtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8910

On 04.04.2022 12:40, Roger Pau Monne wrote:
> Prevent the assembler from creating a .note.gnu.property section on
> the output objects, as it's not useful for firmware related binaries,
> and breaks the resulting rombios image.
> 
> This requires modifying the cc-option Makefile macro so it can test
> assembler options (by replacing the usage of the -S flag with -c) and
> also stripping the -Wa, prefix if present when checking for the test
> output.

I notice you've ack-ed and committed this patch, which I'm happy to
see. However, I don't understand why you gave your ack here, when you
did refused to ack (and to explain yourself!) for "x86emul: fix test
harness build for gas 2.36". Why is this note section useful there
but not similarly useful here (or, the other way around, useless)?

(This, as an aside, also makes pretty clear that - unlike the title
of the series suggests - this has nothing to do with gcc 11.)

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 13:03:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 13:03:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298330.508174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMN0-000310-1t; Mon, 04 Apr 2022 13:03:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298330.508174; Mon, 04 Apr 2022 13:03:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMMz-00030t-V8; Mon, 04 Apr 2022 13:03:45 +0000
Received: by outflank-mailman (input) for mailman id 298330;
 Mon, 04 Apr 2022 13:03:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbMMz-00030n-5O
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 13:03:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8008c1f-b417-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 15:03:44 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-HjaH0_T1N7qDnCWIwx8l_g-1; Mon, 04 Apr 2022 15:03:42 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5440.eurprd04.prod.outlook.com (2603:10a6:803:ce::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 13:03:40 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 13:03:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8008c1f-b417-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649077423;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6+2xlrgRHzQbJ4h/+EbSyZ1KEG/IJVa9mrLfiMZpFD0=;
	b=AJswuE4N0DOzEIEd4PX60abvVa6oFNnpUNczmhK3L7PwklfzxMqXT/xcLRYHxV93uhtrvt
	S75hUssIeauwMvCeNU2lwPNeSptdRLcPzOSe7c7WV8L2pjFjztNBW3gKmgqi8n4bVgCVwD
	D08Ff4NphhJ8aVUGKS9sBPnSU6yRTys=
X-MC-Unique: HjaH0_T1N7qDnCWIwx8l_g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mgTsLv3mPA86twYextMKvsnZkdxefdRqJShe3ptpSNAnJTqSBp2y8MqN1UX2Ac4KzSohLF1HVCUC1JEKGj/u4SL+UQtj/JxSOBkVV/LHwZkkohSV41KW3ngOJYgFB5NmWYT6OojKUObMm7e3XqRC3mu74piLqzDOmhAxSWBeMeJgsrIc30tKQC3GbHx8A3by622YaMyy8VGP5TPVyVfLdKJ+uIvMC7NWrC0hDy7JheHTSgaDrPXZEZ40hCFaIxGC3lkE2ClerNHaPXrQMX4KjJh19DqeNXdxlOx2Wsx8tXCC/q0GUzk66rtqvgmbx8UHhpnLwHI+Sh6VTN/mzh2GpQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6+2xlrgRHzQbJ4h/+EbSyZ1KEG/IJVa9mrLfiMZpFD0=;
 b=HYKRMCP7AD8L607Lcx8vPRBpuFb7PnvUpYASHc23c20i/NlndrfxatZr+CXvYEyQim+e12dLYodREIQ6TeO+7Bx9lMyq8gB4dGzZyfOrxTfsZtYH97iCC1Xrs6/OjFo7UWMCRInfa7B0nvlsCwSxvRX+PAewFUetLxnkhEB72BjBQxQ4VmPPjczBcGekImXkpBeTh3aADMN7ao7h+yokeQE1JuqgB1MdmOP+D88WZgUVgs9ec3sNNndqLQvprFVgOyyRiazC35Dk/uBPmqKzi+q6ysht6ULlPGMv1UTySX1IYmIFi9hkqB3NWcMkZv8fFlzBCm1Q7b+ZoV2k79JqKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6bd17005-b662-125b-76c9-ac971c8ac2e5@suse.com>
Date: Mon, 4 Apr 2022 15:03:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: PCI passthrough: possible bug in memory relocation
Content-Language: en-US
To: Mateusz <mati7337@protonmail.ch>
References: <l3LThLG8tkJBvD-3WTxzw6TRrj7GPAN9uWh-AWqzelw75qpdP1ZLXzBV7599MWrjrHH-lRKof3b0jm1DEGrUXLJszgh5hjW25oNtHoTI9Ts=@protonmail.ch>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <l3LThLG8tkJBvD-3WTxzw6TRrj7GPAN9uWh-AWqzelw75qpdP1ZLXzBV7599MWrjrHH-lRKof3b0jm1DEGrUXLJszgh5hjW25oNtHoTI9Ts=@protonmail.ch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0349.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 666dbf11-2a4d-4b00-b94f-08da163b8a41
X-MS-TrafficTypeDiagnostic: VI1PR04MB5440:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB544028466A627330846E371DB3E59@VI1PR04MB5440.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oPyy+c6BfpZqV5T7rMQ5Ov/wSkauM9XsHJCKRN/sXMA5z2KUTcOuO9UDeLTIQjgottvPNe/oex4m/YS8NmItf9UOkjS+CZRp/zhA2j6fOcPIzyLeFJL2FAj6gLNufBN5qzOVo1jCPowKYLs4ach5aYkaZdKxVrZ/opwicD4dKD0B05bpf1/bm/9BpBPumNxAC8sgMqzyTP9Z9+K01HpSuCqWGXCj6mG1WYafB0S3798zdwYvJ8IhViL9WZuUyiWLHBg2i031uld+7R4/xEMUhsHN8ICX+2xQSFsu82u0U5xxWMPfWtk8k32TBZn5GSlKEqakp46LT1F6jxD7aDikczqPXQNfEj9PeJXv02YA+0WCjqWmIOP1b3Y37MDHDJ9l0WvkzzfXoNoshw9n1OD1gfua6oxwn/NYCByetVO9z1imVPrRKkHJnYYf5Wrp5WnJPgRYxL3RrazirquEX3JeINxJffjiEZfag3IQ5WB90yyQ+K6lA7gb6ozdMyvNc6pW4c4crAXjBLZ0Cj+369JkP8HPHYMJ3prTdB6YVZKAwhWINMfP6sJecBgHEUUsKu8+lWrJ6Z1dxH7Dt9tNbo3/zogucSRYsLI4rM0DoaMrQurCg3ur++sDKWMkHTtSZ43ccjW3YEXaZQf3nic1oy7QLw2/5u3vE0mwI3SLll4yB4oLPBb0YVQHspmkoOdxHYxSnbmY9CpOU0Jo9U7pkwtznAWjwKTB3CTFmMt8i5Y+cbhuqksf3lo9ioiOMWOjzNTUXL4CULqw1uSk1kbOfmRju+7mQYavHgYS4X7sc9IjMGcY6fvYgmeYvT4gLPS0DUUY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(8676002)(6916009)(38100700002)(316002)(66946007)(66556008)(5660300002)(8936002)(31686004)(186003)(26005)(66476007)(4326008)(508600001)(6506007)(2616005)(966005)(86362001)(6512007)(2906002)(53546011)(6486002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Ti9pL1BORG1aVTczYzNDa0w2L1hLcEpOeTVscm1tUUZlaG51N054cHRmb0xX?=
 =?utf-8?B?ZjlPNTRWQjFTQ29aeTVmeEEyOVowTER1b1ovSk41eXlxdUFqemJqeXJQcHV3?=
 =?utf-8?B?bnI1U2JYVExxR0gzcC9mSlZ6QlFockI3Z0JQc0RFVmp2M3RGYThNR0JxN0pj?=
 =?utf-8?B?RjlSQU9mYUpGSk9GVXo2TityOXBmMG5jODI4TmtiTDNrRlo3bm9TRmVkMVJY?=
 =?utf-8?B?LzFkSktLTEoySWlZalhjTTUxb0JGekpjMmRNcjl4Vkxtd0lSQ1NtTzdFaE1E?=
 =?utf-8?B?dlVrSHRNN00vVlNWemlLS0pEQllXbVZHNGZYdVJUU3RqdXk1V0hYbWtXWE83?=
 =?utf-8?B?MmdFVDlMM1VxZlRyZ2xwTkFHVlRQc0RkV1V4VGhOVG9SVXdyRTFBdDZjT0d5?=
 =?utf-8?B?dGQwdmp1UzZEbDFlVWhWa2ovUldBWkM2K2k4TXloVi93V1dRdCtCRDB0VTFZ?=
 =?utf-8?B?MDJiajNBV1hMeE1JVHVqVnk0VC80ckJ6b05nWGFZOWJzcFhocEJoaE1UMEVX?=
 =?utf-8?B?ZmczU0RhNGtCTkh4c1B1aUVMWGhCamtSQmJFd3JaRnZTQ2VPbFAyNXpEK0da?=
 =?utf-8?B?ZUNCRjFrY3VhYmljYVRpbHI3akNEU21SSm9PcWhOb0QrY2pPc2RzQXozWXZt?=
 =?utf-8?B?amU3TGxMcm9pMFVmU0Nhank0dGxEbEMrQVVnb0JwSUwvS3RNTTZLcGs0VEZ0?=
 =?utf-8?B?dXhmVnNkM1BTdkFNZzVkUFQ4aUVSSlkwOTNoNGJrOVlLM25udGpIM1FnTW4x?=
 =?utf-8?B?SXpnZ1VweHM2RG4yT2dFcWF2MjAxNFRueWE4VENLazBvaC9aMFAySzJ3STU5?=
 =?utf-8?B?QVU3T2dicWdRNzAzMmJPd0grVzJjbmFSTkVKN2QxckwwYVBWMUN4THBzT09j?=
 =?utf-8?B?MkZTclZIbGNuVThCZENjd3FLc256djdEb0NRWU03ZTRMYllZMVJZb2RnNkw1?=
 =?utf-8?B?eWIwRzJtNlJuRXRFQlNwZ1QvLyt1TlluUXJvczlKN3FQNUowdGRSYWNVQXZj?=
 =?utf-8?B?M3U3NnBzU3F4L1QxdkFKQmZ1UXhJN3EyYlRQa3A4aXh4dWFtVVFjWFdMeWtS?=
 =?utf-8?B?eVNNNUpRbzRBcFFhZjY3Wmg3QkVNTTdVS0ZVbEpPcFUxTTRZcjkxU0pDUWUz?=
 =?utf-8?B?TWtmM0JEZU1WVTBlTFdCdkt0NkpuRmVxTnk2T1lRYnN1U3Yzb1A4U0w3VUow?=
 =?utf-8?B?M2JFRjdKcGJYWUg4Njgvb2hZRkVaU3pCRUYyajc1YXFucWV1UDR4TGNwc1FH?=
 =?utf-8?B?WGJ4MmluWkFqUEZhRGtqOExlVE5UNHBDM0d6RWZiMkxGZlBXZUpXNFdYenFJ?=
 =?utf-8?B?emYvSTFjNE9HRTZDV2R0WTgwRXUxOVBHdTdqM1E4LzJrL2txY0sxWmwyTDdI?=
 =?utf-8?B?bUNqV09hWklvWXdUU09ya2VIaHcvV1U2ZlpaRWMyMTN2ckw2SVhZMEVZcXZZ?=
 =?utf-8?B?L09JQVZ5Mm1MRmdRdFdXdmx5TjYwUXc1emlra0taODZHbHV3cDg0SXE4RGg2?=
 =?utf-8?B?QzFCY2hCQTZyUFBSMWVlV3IvREg0eDlyZ1lQYkhBZDlEU0thUThOU3FZS0lV?=
 =?utf-8?B?S0hxUU9xY0I1aHQ1RjV0QXJMQWg4SSs2OGFSRXMrNlc0R3E5WUpraDZwOG1s?=
 =?utf-8?B?K2ZvUXRha3JMaUpEK29BRTNlUCtRSW1Ra0FlaCttQitaN1ZrUTB4V3dlMk1k?=
 =?utf-8?B?YnpUYzh6UlFaQkRsZGs4VmRwQUZPRVN5OC83enRFNzhaZ1JJZFBtaW1XaHRO?=
 =?utf-8?B?Z2EvdkRPNWRKKzdoQlBVMllXbEd1eEpzKzhBc2hGR0ROZGdoRTlYbk9kcExP?=
 =?utf-8?B?RVc3LzRWT1JGQ05zbE5Qck9USnBXV2hpdmtUeXNlLyt5VmxSZUwydHdSaEly?=
 =?utf-8?B?Ry8vSDEweFkrVFY4N0FteTNlTHhVWlNHdEtWck1YMDEySmh2SWk4Q3JraHNU?=
 =?utf-8?B?ejhQR2MyUjlxSlRsOU5nQkZ3Y3hhclQrK2VSVHlDZzEvRkt0b3MvbG1xemxy?=
 =?utf-8?B?YUdyMzBkTnhjOFN0T25iSGM0MnZkU2tnRFRuU0lIRWRCTHF0S1p4RlE3KzJw?=
 =?utf-8?B?NUkxRTBvYy9QNnNsbHhYcFd1dTBCSXhNSEE5Q0FaMlpjczFRYlpHL3J3Umsv?=
 =?utf-8?B?cENYY1FSVkZkbFJwM0ZtcWFxNnBhYmdmaFpQYkJPaU5zTzBEMnpXczZoWTY0?=
 =?utf-8?B?eEpRcUhhVUsxU3B1TVVIVWkxUTAyYnFwdTl4SFFyRXBvUk5mNVdKMWxMRVNW?=
 =?utf-8?B?OVAvWUFqNFBnZzYxeVBNb1k3NkVUNHZlRHJwZTJvZnJGbzdFTGNNY2xZZEw0?=
 =?utf-8?B?SThxSDI4RnJzOFdWNWxjSEthaGNLMXlPdHpwNklPWXA4VXloenhJdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 666dbf11-2a4d-4b00-b94f-08da163b8a41
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 13:03:40.6353
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wYDHJLpZytbQHaoD13lYqCZSOvIslrhl14asUcvobVH/Fga9mK11z/hEn86aGO+fR9JmcN5qBGemHaWLowG1AA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5440

On 04.04.2022 01:24, Mateusz wrote:
> Hello,
> I'm working on resolving a bug in Qubes OS. The problem is that
> when someone gives a VM too much RAM the GPU passthrough doesn't
> work as intended. I think it's because in these cases RAM overlaps
> with PCI addresses and memory relocation doesn't work in Xen.
> 
> Here are the memory BARs of the GPU I've tried to passthrough:
> Memory at f3000000 (32-bit, non-prefetchable) [size=16M]
> Memory at e0000000 (64-bit, prefetchable) [size=256M]
> Memory at f0000000 (64-bit, prefetchable) [size=32M]
> 
> The interesting thing is that in xl dmesg hvmloader prints these
> lines:
> (d1) Relocating 0xffff pages from 0e0001000 to 187000000 for lowmem MMIO hole
> (d1) Relocating 0x1 pages from 0e0000000 to 196fff000 for lowmem MMIO hole
> so it looks like it tries to move these pages to a different address
> to make space for PCI memory, but for some reason it doesn't work.
> Changing TOLUD to 3.5G solves the problem.
> I tested it on xen 4.14.3
> Here's the issue on github regarding this problem:
> https://github.com/QubesOS/qubes-issues/issues/4321
> 
> Is it a bug in Xen and fixing it would fix the problem or is there
> something I'm missing?

I'm afraid answering this requires debugging the issue. Yet you don't
share any technical details (as to how things don't work, logs, and
alike), and the provided link also doesn't look to point to any such
information (and as an aside I consider it somewhat unfriendly to
point at such a bug as an information source, not just for reference).
I'm pretty sure this code in hvmloader did work at some point, but
since it may be used quite rarely I could see that it might have got
broken.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 13:09:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 13:09:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298335.508184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMS5-0003kr-Pl; Mon, 04 Apr 2022 13:09:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298335.508184; Mon, 04 Apr 2022 13:09:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMS5-0003kk-Mu; Mon, 04 Apr 2022 13:09:01 +0000
Received: by outflank-mailman (input) for mailman id 298335;
 Mon, 04 Apr 2022 13:09:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbMS3-0003ke-Ps
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 13:09:00 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6274b348-b418-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 15:08:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6274b348-b418-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649077738;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=w4W1mmhIJG/wrhq16Hco8z0EIArNWfq+lgavRD5CPNI=;
  b=aOy+CToA3J2NTrmzLDyTMRbI3Tegn4AKkQIPOKe7dHUOld36Iwkpc7iV
   DWV3TbBv5dcruobVqHIMrxdjyyGFPFXcwPMSGMemh35IogEqEyLIgkD2+
   0sMWNi/80niaKKb82hSac833Pz7Ys+sZpO9EKH3olX3XR75w/QqvM+tJI
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67939635
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:z4uPBahpTq/8/PAazGRHKfCBX161sRAKZh0ujC45NGQN5FlHY01je
 htvCz2GO/neM2ehLoskbdu/pk5TsZLTxtcyHABp/isxRCob9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vR4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YT0yAb3gkvYhaVp7PXlSEr1Wop2aJHfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiBN
 pFIN2EyBPjGS0RWC005UZxnprvr22ihSQJorUOyuINitgA/yyQuieOwYbI5YOeiXt5Jl0yVo
 mbH+WXRARwAMtGbjz2f/RqEmevnjS79HoUIG9WQ/PNwnEeawGBVDRQMTEa6utGwkEv4UNVaQ
 2QW8Cczqak59GSwU8LwGRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQoy
 1uIktXBFTFp9rqPRhqgGqy89G3of3JPdClbOHFCHVBtD8TfTJ8btAnwXvppApKPzf7bQR3f0
 yDQjnU7iOBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4
 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWKyC
 KMwkVkIjHO2AJdMRfUqC25WI553pZUM7fy/CpjpgiNmO/CdjjOv8iB0flK31GvwikUqmqxXE
 c7FLZf0Vy5GVPg8kGbeqwIhPVkDnH1WKYT7H86T8vha+eDGOC79pUktbjNikdzVHIvb+V6Io
 r6zxuOByglFUf2WX8Uk2dV7ELz+FlBiXcqeg5UOLoare1M6cEl8W6656e5wIORNwvUK/tokC
 1ngAye0PnKk3iaZQehLA1g+AI7SsWFX9ilkbXR1bQ/3gxDOo++Htc8iSnf+RpF+nMRLxv9oV
 fgVPcKGB/VEUDPc/DoBK5L6qeRfmN6D32pi4wLNjOADQqNd
IronPort-HdrOrdr: A9a23:oE++iaj1D7YHEoCTph49Vjt1E3BQXt4ji2hC6mlwRA09TyX+rb
 HIoB17726RtN91YhodcL+7VJVoLUmyyXcX2+ks1NWZMjUO0VHAROsO0WKI+VzdMhy72ulB1b
 pxN4hSYeeAaGSSVPyKgzVQxexQouW6zA==
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67939635"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Hj2iBmm7235YCH8N0bgJi9cWUN5NbgAe+jFhkgl9Saq0noOCxxIYb7Sk4KQ/+fKAbISBhKKLxOIUhDVyVtWAg3rJDz4NLAtcRMn3+ZCjdoluzN+tK/TcSZqtYufE+FHVr/j3cNjYrFcJNvZ35g8sWXbnyxdUI0N50VKcITgUfW10nLqCy8rNk5JkRbwEzSz9k6FZS+s/4eL4tAKLuLg3yKsC7GZ3ULcYZ1vXN+vCV8Y8wT7b9kf930zZ7jeQMDveODz7L9UKjlHPmFy96SGy+B78QkO6+3VSKwEVZUrZaBbDSr8hCXZS7au1DC/UUyx8g3BD12skjRiEPqf3XD2a7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=w4W1mmhIJG/wrhq16Hco8z0EIArNWfq+lgavRD5CPNI=;
 b=RCudkLDyaWPNIXzoaMa6QZFI3sONrziv1mG6+KbIb/4IspIjW7/Y3KXpjCM8wKvwUR5ENhT5ZefYHAbBiCD5DG+Ce7nSyI1gdSRLQFa8g4DTAppjClTTD5e4RiljAKsJdEsU49B0gjRHu1WzhhSvLsgx0vE9FM9OAAGQ6IBecPcwmsWo0n1z63db/75gM9+ET4nXycwKThPNDk57NbzD4IcBMhynUcoCI4fYRzcnVrbBK+c9NGvh8hLH0Aw+gd2HUxO8e+K5JHver0+2yvP7nOxPw+6PJ/ytB6MD05CaWgiBcmvFNkqbij8bgBkcv24QLeTaMXi5EPJzThwhylsUtg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=w4W1mmhIJG/wrhq16Hco8z0EIArNWfq+lgavRD5CPNI=;
 b=nqzf5I+KME7VwXqEwbDJQSjIiaAVLOvUl+kQvipqPxwERcywcTCH5Xz+88rr2lZejQI1QvfZsOnDl0xkijVC3slReuihob+C8Rdbipkw6c+/+JD7wEvv4Qjzqqv8P+RAoTJbhQ/a26WexFFzcemMJHvPNq+8qgydGO5WEojjBa8=
Date: Mon, 4 Apr 2022 15:08:47 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [PATCH v4 3/4] include: move STR() and IS_ALIGNED()
Message-ID: <Ykrt3/nP5EAmCDUa@Air-de-Roger>
References: <6e540bc9-c536-84ac-fb1c-8271e7731b3e@suse.com>
 <9a0cf101-17fa-cad2-e791-15d8d8cc5b79@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9a0cf101-17fa-cad2-e791-15d8d8cc5b79@suse.com>
X-ClientProxiedBy: MR2P264CA0042.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::30)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 044aeb09-103c-44af-808d-08da163c43f1
X-MS-TrafficTypeDiagnostic: CO2PR03MB2407:EE_
X-Microsoft-Antispam-PRVS: <CO2PR03MB240726C076449C1800D7BFBA8FE59@CO2PR03MB2407.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: KsNMKCBluxISJBhGHWNZ0dnJyZJ/iyqImcpdKj1KzAEqKd7n6iMktXCkbSFzVLlXw2zWOJNF/+n1ZLBGqNNiKGFAaFQ0n1looVX7Sfh0Utb8gQ3KUWqtbS6S8mmChsuB+52ELVrRpZdhHIkL2u5Ojy9K8CeKT0KFQJ1KuSB1EJ+ZgpvxxZMD4VH6/SwR3P8Fo59uLizucQzh9bdzDb1ybni16fDYVXGNq0ln1Rf6wW/LIYlh6Qu/oKTOXMoWCzwAcAvMEEjw3my7W0c7p5QJ1OZBnDHYmLU1vJw8odz/S+wVUq6xiZyFEpJVc0KGbjd5CbCqqQJNXXM6kc+OGx2VatDkamBZPojX/Kfne4pqrQ9cuUPoKdU5obF8Cg14Uj9Xe8FabjAS3Q+Vz/8mQD/5JEdPopHBqMW+dl7NhptUnolNmys3xbGlXURSONdKjM5SmeTP7XtqDQZREgzgnwEq0wJVvabG2xsucEZv/sIYxG9bKOfPjxybFwHQKBsZ3YudeVH1lkkB0oWTpc8xjikx3OBJzkGy3yWc3uLVH1Wxvq2QF+zkstPFcJbbpOMftKyWJqbJSWPKFSpZT+lEuZfqZ/h95jL30VTO9XOTQzEVZU7hOLKFP/muDb1lSQKriFuJWjDcrtnG5631pOkOHPGO+w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(54906003)(186003)(8676002)(26005)(558084003)(2906002)(316002)(33716001)(66946007)(66476007)(66556008)(4326008)(6916009)(82960400001)(38100700002)(6512007)(6666004)(5660300002)(86362001)(9686003)(8936002)(508600001)(6506007)(6486002)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkFJNklFVTFhUDFhRmlFSHRXaDVuYitFaloxSGp0VkR6bzRpK0s1dytzNXJN?=
 =?utf-8?B?U2dIQXZMMEdQVU0veDQreDBDWXp5Z3BRUnVWRkxpUVprQkVGc3RaUmhjbXda?=
 =?utf-8?B?TVBtcEV4WEhiYmpkTWJXeVFzTnhBZE9mbnNHY0xWeSsxeWZZTXNWTmp6L3F3?=
 =?utf-8?B?RTZTbGNXaWVEQU9XY1V5ZlJjUGQ5cStxWFBvUzZQY3I0QnF1YTNXWGhBUHFp?=
 =?utf-8?B?Yi9jMFhFVFNRc2xYK3l1QmZpcHA5YkgrWlZTeHA4RlVzd3FXUkh1NlptbU8x?=
 =?utf-8?B?SkRRSHRGNTRKTGdWelR6dUNkVmxrWVd3SUswSk1BQkVlZ1IyejREWlZLYUJT?=
 =?utf-8?B?d3Z5djlpMzFYZEYwVlVhZTlvekpwR2UxRDFkQ0N2N3oyeGx4ZFljSWhsNXlC?=
 =?utf-8?B?STQ1aFM0Nzk2aUsvTTNSQjNNVVJQTHFJQlh2QzA2NGlZZnUrVitvcldENEdQ?=
 =?utf-8?B?enlTZUdBMnR0YU5WMlF5Z3RkNGNwNTA4OS9hdXNUZFBZUSsxZ2VpdFJuRW05?=
 =?utf-8?B?TEJvb0VpeVIxa3hra2JPQVRHa0g0MVVaNHVpNGRGRDZSdVprTVBKVmZsNzEr?=
 =?utf-8?B?MXd0YWo5Y044V2VSNDZWOUZrdDdaRDFBV090TjE5Skk5K29LZWNZVTBSNkNj?=
 =?utf-8?B?ZTNwTEdQY2FwZWhNd1BFa29aY2Y0VWVYR21aclF2OWR3QjhCWEJtQmtScTU5?=
 =?utf-8?B?VnhUUjJFSzlxc0xqMzE4OWM1WVR2WERQRU15T29RLy9GZWtPNk1QVU4yWWli?=
 =?utf-8?B?R2tCZlh0TE5pN1V5OFcwMVlmQUV2bk0rTlBCM1dYRjdFM1ZQVCtuKzlRbURV?=
 =?utf-8?B?dFdkRmdubjJrSTBDOWkwRmtjdS9kbUdXQjRwVy9mWDkyd1FVYnN1S1d4c1k2?=
 =?utf-8?B?a2k1TVl1dVBKVnFIdmJhZVB6NWVrbnpkTEJib1JkZGxCWWJtSFZ4QzNnakZJ?=
 =?utf-8?B?VGhmdVBoYjV2ZXUwRGtsRUhXRktJaHIyNWpHRUU3SldiYlJqbkJvcHFCTjhz?=
 =?utf-8?B?NGVaTFNlVi9NeU1jd1FyV0pXN2hzam1YaEdlclJNbTArL0FlMkQ3YmxZLzZY?=
 =?utf-8?B?R0lQeXdsY0x0WWNmNU80S0lpRDQwbGFIdTJyTHB0TkNHRUpqTWVtM1ZjcnhK?=
 =?utf-8?B?R0ErS29XcFljN05mdmgxZ0VML0ZtWGppZE5oVWtWTXN0Y3dCR29yZXRQOGJ2?=
 =?utf-8?B?RG16dU9qMHZYTE9ZdjZjNFc4ckVzZWJ6d0lTRTA5bm1Cd3E5SHFXYXFDbjFV?=
 =?utf-8?B?cTBabERNaHordEFuWmErRzdCcUdXRlNTUEp3c3hNYkxlS3Nua3NCY00ySVJv?=
 =?utf-8?B?ckhiSGZuVnMwTTYxQ2luU0xHOVhKVXJiV2lndzh5ZHlwMmxDKzUrVG1pcGw5?=
 =?utf-8?B?T2VvWlk5YVQ5a0ZYeDNSckNrdEJwd3ZRNk1zdXl4cnFESTdJSGhQdi9iWlk4?=
 =?utf-8?B?SXc4dmpPeWtvL2lKWFhwVUNIWGNYYTJucDdNcU1jSE5HalNoMVRpYW5CTUlq?=
 =?utf-8?B?WEtXUEJWUDl4ekNRelZvTzBrSHlQR09PNGJzc0c0NjNnV3MvUUN2RWJmWGRF?=
 =?utf-8?B?ZUhES1YzSHlRdDBYb09yanIyMjZxWVBxSHExRFR4RHJ0bm1Gd0QzRExNRHR6?=
 =?utf-8?B?VG1rc0FrYXJNMlI3YzU0SFFpalJPbDMyTDFvS3k5ZDY3eGMzTTZLWTN1VnpZ?=
 =?utf-8?B?QWc1TzNyZ3NZNjFzaXhsc1E3VDZRcHlkSWNkK09pZHJ5V2NPVnkxaVl2Lzd6?=
 =?utf-8?B?c3ltU2dwckNpRERlUHppZTlyeFducDlZdy92b1BwOUZDTTg3VzhodXMvVWpp?=
 =?utf-8?B?aHFEV3Y0aTRyVUZYb3NaSm5sSlQ0Y3BCV1dLYnh4R0ZBRExxR1hEaTlpb3BR?=
 =?utf-8?B?alpCN0kyakxhYXRlWGdYUnVHK3MwYlVPR1lCbzBldnJ5WndQa2lORFcxWmky?=
 =?utf-8?B?azdoNzFkc3pEMXZnOVBSSjZnRUNLZlhkQUVmUUxzbS9aZlErV013N2ZLTzZU?=
 =?utf-8?B?ZE9PNkNSbGk2Y0hzTkI2VDc4L3R6RDdrbzZJeGMzMHNOMElvSmVsZkQzQVQz?=
 =?utf-8?B?STJGdVlIaDl2SFYyMk9VQXVtY092MllNWUFXOGNLMGs3QXRZQ2xwcEx4cFBS?=
 =?utf-8?B?NkIyb0ZkMlVJbStTQ2grbWZUTGhZTS93QkVNdzZzM3ZUVWNOVDRZMnR1NmJ6?=
 =?utf-8?B?anphZWhhdUxYTkNjU2JaV0ZwcUloaEx5VUlBY2E4bzBDZE9xcU5WQmlhWS9z?=
 =?utf-8?B?RUh5RUZ6bnQ0ZnphNlU3TURFbVZWQnRaRHFURklIWHBmWG00MWo5Qlg3bUIx?=
 =?utf-8?B?djRoZVFPUUFjRnU2ZjB5VThDTTlKZ3FLdkZaUEdsVFJPOG9wVFp4V01GRE1u?=
 =?utf-8?Q?4vDmuZM8M44zy0fw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 044aeb09-103c-44af-808d-08da163c43f1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 13:08:52.1345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pJrCCU54ee6aXuT7Bc3EfwgzoNjSCxEVVNjKsG57wnwaRCUIe3JDD900SZfAeFMq/GC2Iw1DZdGOi9dTwBr5Dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2407
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:31:02AM +0200, Jan Beulich wrote:
> lib.h is imo a better fit for them than config.h.

Looks like most of what's in config.h could move to lib.h.

> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 13:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 13:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298340.508196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMf2-000617-Vg; Mon, 04 Apr 2022 13:22:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298340.508196; Mon, 04 Apr 2022 13:22:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMf2-000610-Sh; Mon, 04 Apr 2022 13:22:24 +0000
Received: by outflank-mailman (input) for mailman id 298340;
 Mon, 04 Apr 2022 13:22:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbMf1-00060u-FI
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 13:22:23 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 415c60d3-b41a-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 15:22:22 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 415c60d3-b41a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649078541;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=QRbAPhnk4HVM8z+yUKxlHxgZZZ3PdMpbuZzASV2rNts=;
  b=bparVBCm8tvHg6Ao4i1g+C6xRVWWuzis7TLrnNkQNFYJlWx8pKpyqj47
   74P7tDTZVMaaNXPeFf8jkOgtziZLVecK+W9TrM7mKa4ipwr/Pu9itiQtJ
   +IMk7GkXVxJemQcSZ1e+RhzV9GKPWV/MWtHR6S+u03GPDZ8OSgDMH6lbm
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67370518
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xMumFKgvvgW1lSI8Yzbec97hX161dxAKZh0ujC45NGQN5FlHY01je
 htvXT3SbvnZYGfwKNogO4i38x5XscXRzYVnQAtprCpmEywb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vR4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YTw3EaTGmMIlaRoCHXB6eoBDwb3JO3fq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiBP
 JVBNGM/BPjGSxhWPEoGT5tjpum5uFT7UTlJpmio5oNitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrkQRAhALUVqwodGil1WzHdlYL
 iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4KPMV4QuN7JLu4FyXV2xDYzt4atI8u5pjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoetcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HzgbQ4xawZRGp8crVnl
 CJZ8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBYxaJ5YJGOyP
 BO7VeZtCHl7ZibCgUhfOdzZNijX5fK4SYSNug78MLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWOXKIodZKfQlVdRDWx/ne8qRqSwJKGSI/cEkJAP7N27IxPYtjmqVejODT+
 X+hHERfzTLCabfvcG1mtlgLhGvTYKtC
IronPort-HdrOrdr: A9a23:EM35fKN8hgIuAsBcTy/155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80lKQFm7X5WI3CYOCIghrMEGgP1/qH/9SkIVyDygc/79
 YQT0EdMqyJMbESt6+Ti2PUYrVQouVvsprY/ts2p00dMz2CAJsQljuRZDzrdXGfE2J9dOUE/d
 enl4J6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr10jegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKva/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdY11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa
 hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj8lLYIk7zI9HakGOup5Dt
 T/Q9RVfY51P70rhIJGdZE8qJiMeyXwqSylChPmHb2gLtBCB07w
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67370518"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QiqWDIPDp/bDlZu8I2uZD7bdcvlwuSmJJyxOqeWtH9JwQGfr0IpmY/8I7YK7+VVsrkL5E5sWNyKdeiqWLd3W0mDHE0jcmMRnF4f0Aa5rvkBTEZlzNlnMloEUvvoQPh7APY859d2Yy0/xx/75DU+4S+g4zHauPbuQcpgWx4gR1kZuk6mWuOzhAE50UFdBhQ4o+FIQH4YLdbPXZx25Rp1qvK3ONdDuQMJBbD06I7mJW/Lh4yWkWo2941wfDSzLTJswGTE2ZvIJamY5dn5+p8Q1FfBdP/w5EP1p2jPE5ho5bFsfoC0DdAA7JzH2qmKlWMuGOUQ2xhZBunwAgLYZ3dsuaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dM5NPhdrVPEHQ1C0IQMR/V+vTg+RJY68DtxFMMsm7ts=;
 b=f1Wfu5PB+kfup3uZLj5T4AQvJjLNY6zwsa49NvN/nc0SoTkK5TVQ+UUYTLssH4yNKZ9a8Tlk8Bebxjtc1BzZpJRwOAfaZ4E7XGwYZUDtkLTdKn7a9erejy6nsVHLPJGF96FlvotYxtGuAqgBszirn+F30DSb5LQK8oon/dQHlI4w/ehs/ydAmdPyVlpmkc8byFL0/WyvMuGG8gKtw3TJA53dpy3uhi54zCEEHXqn28nI8d5DQ8SXR7k6PbduzK65pUwLKzFFAnrgsa5zqezBPgJgLW2c0g9tHTcXIoJ7hjIIMi9eJ/zZf7jSIPR+Rgn2uR7yOUYiJ0BqGndzbXzPRg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dM5NPhdrVPEHQ1C0IQMR/V+vTg+RJY68DtxFMMsm7ts=;
 b=s10z6dHCuJfQqDI2jGXDooD4QzMwp4bnRTK4SpZpHdPwsQWFAexl9LdUnGwVOWXXVmxdN/7JDNx5hYo4ntz527nGc1IvJD9XSEi/8Mkwr1JrT8NVXDRkREjh8PhhVAPb0ZWdaHFCOLPoETFLFT3GTo1kldYJ3Gs7Bp6/M5KJuNo=
Date: Mon, 4 Apr 2022 15:22:09 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 4/4] x86/time: use fake read_tsc()
Message-ID: <YkrxAX7X1sxVf15r@Air-de-Roger>
References: <6e540bc9-c536-84ac-fb1c-8271e7731b3e@suse.com>
 <bddbec0e-acc2-03f9-fe4c-167fa5ac0ea1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <bddbec0e-acc2-03f9-fe4c-167fa5ac0ea1@suse.com>
X-ClientProxiedBy: PR0P264CA0243.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::15)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5fb85b11-333f-4e45-86b0-08da163e22fc
X-MS-TrafficTypeDiagnostic: CH0PR03MB6067:EE_
X-Microsoft-Antispam-PRVS: <CH0PR03MB606726E4B01C200DD295CB438FE59@CH0PR03MB6067.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TnwdULF1jZef/S8ERr3w3JVMLMm7QnoYpY45fSP7CBiYLN+YP8yPvRFpJ2KesLvMGreWNtSJg6iySbMIg13oSCRRJ3Lw1q8IjFb1ZzPTXCexYuiVPowB5HXy06+407pXyKfxDuod69fSTs+vAC6c8cw2KW60QLL66jKZHcerqqC50TOKH20W8ULeGJhLX2owXl6CUx1s3Eie3fAQyS0BvqiyFj0TTRK61LrINtg9gLIUnABeR/KUsWMpx5JP1URCP4Fwqzwr+xt17a6fexOuSUPbsJAMy9+nPmYGSbmRGXeUJoesvnzxt9wR9CLkEjL/1NztBxPgbOVRvSw1/+S+OCCKlAvKWc3+9o91jqajW1Es40tny8ixcpWFQql5QWjfMhm6hNzlI/CXRgRym981DSu/r7cFUI5LELqP2l5aYZI2ACEYVELZckcXtdkk6pDNjENMMsqi4oqDKWpDKMopZkjfKgfkoaLITVRpbDkwxuDVhsBSlddCQfaNTfNEu1kwp6wLs6gibX4mlNEQit2UXAsi5mNxSomU4RYiVw1oMnixERAyiKD7x2PRhXeqI9LHEwBaF2Nu60eTWpq1dX/cFjZUI5S+V19tCV8Ms7YuQ9xd2cJ1bs0USTYnLcyJseN7B01m81s+pJyUeP0w4nLj/A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6486002)(508600001)(82960400001)(86362001)(4326008)(6916009)(316002)(66556008)(66946007)(8676002)(2906002)(54906003)(66476007)(38100700002)(5660300002)(8936002)(83380400001)(33716001)(186003)(26005)(85182001)(6512007)(6506007)(6666004)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzVmZFFYd0dYaTlQQzRmTUFUTGtCSDk2Q0pUTGp0Ui9kMXNoa0c3Q05JQlpZ?=
 =?utf-8?B?aVJ1SC9US1lUbjdvSXkzZWdveE5QSWNMUGM2cThVVGl3MXhmZVRqV2pERXl5?=
 =?utf-8?B?czZuaTl4ajB6Q09INnMvNzlYOGt2aE1pcnhBVUR6dFRISzM0UkZtNXROUVdo?=
 =?utf-8?B?NmIzOFVBeU1HcGY3TUdVYnJMcTJOakhsMG9aMjhWanRsb3EvYVFuKzJxWTRi?=
 =?utf-8?B?QWhxREJqTmxDYmxoczJpd1RyT2gyV3JwMkw3NEpvWlFveUZTekJvUEUyV1Zo?=
 =?utf-8?B?WG9zeHlCTzBMQmM4RUhrUnhCalVrMUlXV3dyTTRsSHZ3UEJOb3FTaFpST1hq?=
 =?utf-8?B?RWpnN3RyMHFVQ3JIUG5BWmdlK0ZGMzZWOUxjSkpEQno0c0tMbW1yeTFvQ2Vi?=
 =?utf-8?B?VitySW9RZ0ZrdFBWTjF6THRJYklhLy8xLzlRSVNpN0xaT0VtTEs4U29DYTBh?=
 =?utf-8?B?OGtkZjBTWm9Zd1ZmNFY3YnVESjRTRCtjNkxIQ2RKVnRsamNWN1hSWHhsRDlk?=
 =?utf-8?B?UDdzV3NTZnZGNVA2cDZoSEVBdlhmSkNjb3BmMWZmYWpPS0ZrdTlkWE5vNSty?=
 =?utf-8?B?Mlp2VUpoL1RueGxHazFCeFUwY2UvZFY4RGFadFRPTzJWa3R1ajByODAwUERw?=
 =?utf-8?B?QkJMNVhjMFVlV0t0QTdZK0pSMjNNNFlnQ1YzbEhxM0ZGRmhuUWkxdW9pMkFs?=
 =?utf-8?B?cXg3cmN4dUF3d24yekxnZHJTU0gweUxWTnJRVWwzK3RzZGtwL1owdDhVOVpC?=
 =?utf-8?B?WHBGNTlLdUxCMWNab1FhVFp1NjdadURhR2ZySzA1NHFMbGYzcks5RGZRenZY?=
 =?utf-8?B?ZHhvV1JWTTNUS2hvU3BrbEhCbkd6Rkdqd0wwamFFdDBxb2VtZEJRZWMyTW13?=
 =?utf-8?B?dUhOMzVXNGxDbzB1eFBPcTlFU0dxUU40dFpSQ1VjaTU5VFpJRGNzWkMreStC?=
 =?utf-8?B?eTBDVXFENVBLa2JXZmltSUNzREp4WnptbEZxbzE4MEgvTHhuTmZrZGN4bnZB?=
 =?utf-8?B?Sm5EODhyOFFjYUo1ZFQ4dWd1Sk1DMmVCTGkzSFYrYzJVYkNKSytQNDB0eWFl?=
 =?utf-8?B?bmZjZlkyVG9PQVVZN2Q3Qnk4dDdVVC9UaTlYZ0w5TmJTcFlTZTQ3RndpRFJ4?=
 =?utf-8?B?blhtdmhXalhuRk50bEwyNk5OQTBCUU92ZzZVcWkwamtMbmcvYVNIbUpnUkxl?=
 =?utf-8?B?ZnpDMW8vMjFwS1hEdkhoT2ZWMFhSTVdkYUJTSk9iTFNubTlXTDJ2WkpNSEVj?=
 =?utf-8?B?OFFjYWpqUStvbUFOVkx3SUJ5TVNQMnNXTGFENVFJREV3REVvUlkxQUxTN0Fp?=
 =?utf-8?B?UnpMbkZCNno0NWt2RkVRTTF6QTRwZW5jMkt1Um9iZ3JzbFdndEcwVENOYWd4?=
 =?utf-8?B?ZEp6VUtZZm8zVDhoTGtKK2lKVUF6VzZURkFRamdzRzNHLzF4MFFzTjVSamRB?=
 =?utf-8?B?bFZyeXMzeHhiZEQwdHFOYXllYUNQNmdEYWp5eUNvTWFpdlFpZmVBVWpYKzJ6?=
 =?utf-8?B?US9EVzJyL05YeU80YnRvRWdYRUgyelo0bytER01tQmV1TTQ2M1hpWnUra2RH?=
 =?utf-8?B?dzhqTTI5WWtaaW5MUk1mT2ozaDZwSUUwQXRxaUpzcnBja0pONTltT2hieFcw?=
 =?utf-8?B?eTZ2WklKWjlWWnVWZkZlNk5lMVVVd012SWRnZVhNNGpHWTVOWGZmUHdvSExR?=
 =?utf-8?B?QWV4TE5WY1ROTUdaSEVFWVFDMmpuWjVQMXI0anBKN3psK1ZrNXlmcTVzYUw3?=
 =?utf-8?B?MFIybVJvWWRrL1djVGdFQVlhdWxKSkV6bnR4clNzM1oyL3BTckJSWjZpNEJC?=
 =?utf-8?B?OWcwRU5VaC96eEVBTHlpVDdERkEzbW1kdThONDhVYUpHa2Q1Q2xYYnpuRnZ6?=
 =?utf-8?B?S1F0MVdBSm51MTUwVFhrOUU1MlNCaW81c3NRNTJDU0J3TjJ3emtoRmk5OFo3?=
 =?utf-8?B?MERkaWZPTXdPUnJpV0p3MVlHTU45bWZwZUpqRExheEhFcWNaYTdWZm1MTFdq?=
 =?utf-8?B?K05lcWx6OXpSa3pKa3lHQS92U01uOWh1RVRBeUt5UmhiUE1VRUwvVVgrcUpS?=
 =?utf-8?B?YW9VMHJ1V1lFZGRLZ2x5MEpjRUdjU2NPRERZTEE4Rkt4YVZ3NWMwUUxJejdP?=
 =?utf-8?B?L3U2RWVROExzSGNwR1NiNGpuZXRhQVFyNGJuSzNmWDhLblNkUm42eHBYQXFW?=
 =?utf-8?B?MCt6TytZTUR5WVNJMXhQU0FkRDBxaExESFpiemF6eTZNN2d2OUFvNGN1UXht?=
 =?utf-8?B?a241aEhOdUZ3NHh2eFk2aW9oSm4wd1lUL2dBbk9EaTN4RVEwS1hTZjcyZ3Yx?=
 =?utf-8?B?ZWpHdFJSTVhYOVUyTXNsdnh1Yk1lSFZpRFZyZWtDa0RiK0hJQm1wVzBtWTRt?=
 =?utf-8?Q?HHnZI6zZb7rAevS0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fb85b11-333f-4e45-86b0-08da163e22fc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 13:22:15.8979
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EB6laAp2i4IrHxPdXOa2cUPCh4DmnKY8rzj9wliCqnYHIOKwtae0FFu1LIEauh9FWC5FIV+vNSb3vsJhwf3QJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6067
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:31:38AM +0200, Jan Beulich wrote:
> Go a step further than bed9ae54df44 ("x86/time: switch platform timer
> hooks to altcall") did and eliminate the "real" read_tsc() altogether:
> It's not used except in pointer comparisons, and hence it looks overall
> more safe to simply poison plt_tsc's read_counter hook.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I wasn't really sure whether it would be better to use simply void * for
> the type of the expression, resulting in an undesirable data -> function
> pointer conversion, but making it impossible to mistakenly try and call
> the (fake) function directly.

I think it's slightly better to avoid being able to call the function,
hence using void * would be my preference. What's wrong with the data
-> function pointer conversion for the comparisons?

> ---
> v2: Comment wording.
> 
> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -607,10 +607,12 @@ static s64 __init cf_check init_tsc(stru
>      return ret;
>  }
>  
> -static uint64_t __init cf_check read_tsc(void)
> -{
> -    return rdtsc_ordered();
> -}
> +/*
> + * plt_tsc's read_counter hook is not (and should not be) invoked via the
> + * struct field. To avoid carrying an unused, indirectly reachable function,
> + * poison the field with an easily identifiable non-canonical pointer.
> + */
> +#define read_tsc ((uint64_t(*)(void))0x75C75C75C75C75C0ul)

Instead of naming this like a suitable function, I would rather use
READ_TSC_PTR_POISON or some such.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 13:26:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 13:26:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298344.508207 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMiZ-0006ci-FW; Mon, 04 Apr 2022 13:26:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298344.508207; Mon, 04 Apr 2022 13:26:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMiZ-0006cb-C0; Mon, 04 Apr 2022 13:26:03 +0000
Received: by outflank-mailman (input) for mailman id 298344;
 Mon, 04 Apr 2022 13:26:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oEUQ=UO=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nbMiX-0006cV-HK
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 13:26:01 +0000
Received: from MTA-06-4.privateemail.com (mta-06-4.privateemail.com
 [198.54.122.146]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c39c0cd0-b41a-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 15:26:00 +0200 (CEST)
Received: from mta-06.privateemail.com (localhost [127.0.0.1])
 by mta-06.privateemail.com (Postfix) with ESMTP id E7C1F18000A7
 for <xen-devel@lists.xenproject.org>; Mon,  4 Apr 2022 09:25:57 -0400 (EDT)
Received: from mail-oi1-f179.google.com (unknown [10.20.151.144])
 by mta-06.privateemail.com (Postfix) with ESMTPA id C316718000A4
 for <xen-devel@lists.xenproject.org>; Mon,  4 Apr 2022 09:25:57 -0400 (EDT)
Received: by mail-oi1-f179.google.com with SMTP id j83so10055449oih.6
 for <xen-devel@lists.xenproject.org>; Mon, 04 Apr 2022 06:25:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c39c0cd0-b41a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1649078758;
	bh=7vUzavakaGaO6E0zlDOAogK+8n1PQfQHDvi1VXpo9lA=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=SMWiQ0tZSxzXtsOGHwFr4Vg++40rQH+orMfP0ei8GlAnzXEycK4thigyst03DPm0X
	 qSU3eI/sjVC8yCbY+dCGMesP86ALk6a7nzhKt7hZxtF6eN6QnN/+ktUDS7WpZEB060
	 nePUunLGUDKjidKtgBgXUQg+QvpBsMtylThkiHvvAcUR+YnaKu0+Hpi5lG4yxOknHH
	 Ejl4Zd3CBlSiN9JhmNqa3rC6ljBWKYLFxKubsfZ9zMoiM51Q+X8cYMxfV6FK4qMI1I
	 J0EYkVM9nucbcRTvIZqAk83Cxs/t3BfTOFHVbM4l9h08Bueb2NKKKkAK0uo5jkdsUN
	 nd3NGhuG8IohA==
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1649078757;
	bh=7vUzavakaGaO6E0zlDOAogK+8n1PQfQHDvi1VXpo9lA=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=YGgMWaar1wOT3v8cxJy+XO4+c7kaGgRHsCF5KAF+F5vKQOg7V0gfrHQdt22JlNMVD
	 qMjMr2T7Od3FjweEv8FYVZ6dn3zOf3AGLCBYjTbg5Dw+idaVJ18wMdMjD6L1Kbk+nh
	 c7fgp8c84y2s35zjUd1miZ6zWERzJtTEO/QwKHm74Z5XkJ3GOxASDoiig4SFjx8sZ/
	 5qGu5M2KKtwMT0JE7DPq55R+kVNCpQtKJgXzqNLNhVEANdBxn4gLsk2aQUDtRo/aOj
	 Md3NWoB44lOD8AlBSUyEtols6e43BKmRvFgTvR74MbZfBwjofqyG/Hp5PmcOTzyGFZ
	 tsQMK9DzI7RYQ==
X-Gm-Message-State: AOAM531lz0txodGU4sJ4vPlelCTPBxptuTXGTnZ1OnFE0pAVwOEB5c8F
	XxQIwlhk1xKxImxO68Sz8XVPh6Oc4jNSgcl8nf4=
X-Google-Smtp-Source: ABdhPJwt6Sihf1ZRBCb4vZTtGgqM7CG+L4hpxcjIUU1JHhhIpKBBQpz/jN9aEppAtFx27EwyGDOhfQGxN4SYY6A3svo=
X-Received: by 2002:a05:6808:128e:b0:2da:6d08:8704 with SMTP id
 a14-20020a056808128e00b002da6d088704mr9938987oiw.9.1649078757370; Mon, 04 Apr
 2022 06:25:57 -0700 (PDT)
MIME-Version: 1.0
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
In-Reply-To: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 4 Apr 2022 09:25:21 -0400
X-Gmail-Original-Message-ID: <CABfawhmZAZ5Y29Gbd2KgKj9Xp8bECX4zo7_eh6HqYCynag+QmA@mail.gmail.com>
Message-ID: <CABfawhmZAZ5Y29Gbd2KgKj9Xp8bECX4zo7_eh6HqYCynag+QmA@mail.gmail.com>
Subject: Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: xen-devel@lists.xenproject.org, Jun Nakajima <jun.nakajima@intel.com>, 
	Kevin Tian <kevin.tian@intel.com>, Jan Beulich <JBeulich@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Fri, Mar 25, 2022 at 9:34 AM Tamas K Lengyel <tamas.lengyel@intel.com> wrote:
>
> During VM forking and resetting a failed vmentry has been observed due
> to the guest non-register state going out-of-sync with the guest register
> state. For example, a VM fork reset right after a STI instruction can trigger
> the failed entry. This is due to the guest non-register state not being saved
> from the parent VM, thus the reset operation only copies the register state.
>
> Fix this by adding a new pair of hvm functions to get/set the guest
> non-register state so that the overall vCPU state remains in sync.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> ---
> v5: Switch to internal-only hvm funcs instead of adding to hvm_hw_cpu

Patch ping.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 13:29:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 13:29:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298349.508218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMmD-0007GQ-1k; Mon, 04 Apr 2022 13:29:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298349.508218; Mon, 04 Apr 2022 13:29:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMmC-0007GJ-T5; Mon, 04 Apr 2022 13:29:48 +0000
Received: by outflank-mailman (input) for mailman id 298349;
 Mon, 04 Apr 2022 13:29:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbMmB-0007GB-PV
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 13:29:47 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 41b65d81-b41b-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 15:29:31 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41b65d81-b41b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649078986;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=jNHtSpkVeVU9PK7XQzxRXedgdkQzIZtHHSiTYoudnuY=;
  b=CyQe7UQO4xjWM9C7iON9XQjg18R+0SkPtxt5LGd1Ba5/eTX11uneYHx3
   YBL0h2wMKDnIajdILw1VnFVsug7jiZWIE6kzddrJmEpO0p2iyN5OpxVU1
   8nw/FUehEp+cCfUEhmBAUvNqPmWTWL6pV3Lc/vU7g4364FvPYyo0vmXIl
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67839801
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:bsde/qpQWW61kmsJz2yoSFMI54JeBmInZRIvgKrLsJaIsI4StFCzt
 garIBmEO/qKZmf2cop3O4/j/E4E6JHXyoBiHVM+qi1jFywa9puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y+q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBFaztu9ggb0ZhNQ5OEotYwoHqeiemiJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZVJMms/NE2ojxtnGXM2Vpwuh8CRo2j6XS9WtFCWtaQF/D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IAYNSVKxrP29i0i/c9FSM
 UoZ/mwpt6da3E6hQ8T5Xha4iGWZpRNaUN1Ve8U49QWMx6z88wufQG8eQVZ8hMcO7ZFsA2Zwj
 xnQwo2vVWcHXKCppWy13ba1jg+PBXcsC0AySgkadzUouIb6mdRm5v7QdepLHKmwh9zzPDj/x
 TGWsSQz74kuYd43O7aTpg6e3W/1znTdZktsv1iMADr5hu9sTNT9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQM0d3XC3270k5JGQWy2yGsjTKuOGpxZEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPskpLlfboX01ORL4M4XRfK4Ey/xX1
 XCzK5jEMJrnIf4/kGreqxk1j9fHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgp
 SriChcBmAOg3RUq62yiMxheVV8mZr4mxVoTNi0wJ1e4nX8lZIek9qAEcJUrO7Ig8YReITRcF
 pHpp+3o7ixzdwn6
IronPort-HdrOrdr: A9a23:HE/tJa8TAPy/16lys2luk+E2db1zdoMgy1knxilNoENuHPBwxv
 rAoB1E73PJYVYqOE3Jmbi7Sc+9qFfnhONICOgqTM2ftWzd2VdAQ7sSiLcKrweQfxEWs9QtqZ
 uIEJIOeeEYb2IK9foSiTPQe71LrajlgcKVbKXlvgxQpGlRGt9dBmxCe3+m+yNNNW577c1TLu
 vi2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA
 BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z
 W2Dk1ZrsA/ciYoV9MOOA4ge7rANoWfe2OEDIqtSW6XYZ3vfUi976LK3A==
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67839801"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wk6pL53UONV7dOTI4Sudv6j26RrahzXa8yO02fSZeYPqc+ZPqhZqZczHKtW52Vf6tgR2YI1YjOcw4lqmz1U9rBxEw6P921s3UIF3wDPeB3RhgCNZu1TGSFtvYiSl9/sXZQ293xBjzb3Qj4SyAu6Y0IkpNdRlrttfooahsM2CjRIuzsR9pA3j6JngWJb7/74UgGsp2jNjiEh9e7p7aEiYNntLK8wclcC7C2LGmww2sdYdXumT0wNioQf59+QagOK9vWMxYc1MFKSYomPF9jSS7yTAlhXXQJrlbhBi7AzKDHTnhaNdd16/5dkzm+snc8XN6ALH9EVUP6taD41qlxFIQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jNHtSpkVeVU9PK7XQzxRXedgdkQzIZtHHSiTYoudnuY=;
 b=H64ntOq8q/UF4/4Eo7yqslw6B2WLQymJs/V+jVuGYHVKIwXxzdJKPAsXyzPAnk3Fo06T/ud96ia3QTN5HXstpKFEiJ99Q56LYfuyLVmxUw3CUAWxoShh7tHMfzbEAluK/jAue2yolYMs1xB+kvBzlRrtNHNuBNTskRS/b5Mosm7iAvFH785CMKzvUYWg7xRLuK6Odu6T4R6o4Ietutgyj+560NCnBIZJTM4Ny94MLXXRJA21pYlOpBV2h8SQSZfIKIxNMmItvbZTzAEm4PX6OOjs2CBDiT5OhR1jgaT+59RB0njjWE0L0pJFRJUD1PcMtqFBUrimdVftWXSlmMf8RA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jNHtSpkVeVU9PK7XQzxRXedgdkQzIZtHHSiTYoudnuY=;
 b=V1xFgEr0Fq2hjNzuvcKYPswY59rliP1H1xyBLmD84HSav7buxf3WWkZugrRreZ9Ly/DDkkJXFxrU/xvRySWxF67/q3jNoeOaocr2qPiLz2OQoz9tjOUsPJ2oODGBjiw89gvUNxdi182tcQoE3wGa4t19GaQWg1jwLbfUVG18X/Y=
Date: Mon, 4 Apr 2022 15:29:35 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property
 section
Message-ID: <Ykryv8hE30eL2y5N@Air-de-Roger>
References: <20220404104044.37652-1-roger.pau@citrix.com>
 <20220404104044.37652-3-roger.pau@citrix.com>
 <aba2f53d-0790-d337-ce9f-76546201bcdf@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <aba2f53d-0790-d337-ce9f-76546201bcdf@suse.com>
X-ClientProxiedBy: MR1P264CA0036.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2f::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1529697a-6bd5-4710-c2db-08da163f2aed
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5518:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB55183CE6093DDC2306EA7A618FE59@SJ0PR03MB5518.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hYGJ1SUvlQC3CsyFXyuQQMk5sezDfMb8Ps9nRYgUltJPLClxsJlaeNkqWd3CehUxywjQH4HEbTd+MrjmoXr8rl9ku6pJMioMlDQPWWChuCFN9S1+jeHR2I/HqGgMFnsmy1jd7vBUs4zPXwENZwhvOi6fYgdn150x/AkU6rJlOwaIafK7TDpASvK8QzbRjManQtehPUVKQ968d/nXbWc3UyfXgefKFKjAIdJofVYIXlT0ZD3cRse85krgoJsYll2CttxOMTc+WwNz/qzZkRtEh1l1KQmLpBr+7YdZWWXGFv88/hmE2feKMW28Ukgsi88m9Ldo9Ucb+OWOaXHUYmLzyl/MsPv2roT2gTBw3pTbUMPRV6+rYjUG4kVGmi+il7uXhFhlb1EhpmzSvqo2z8sQdCXiH1A7c8ijS/4kZOi2oLogjgmV0GZ8ME+DZPvBbHfmY2+rcJVV+rt0NL1ySbmIk+WQv7UvKxboUEvHvMvV4ZTv83wK4G0FJwNHYTsFaFKNkR0tcu7Wdp9mlS3V4qkflLYikMCrkD0KxKq23xnYPD/91wTzjFIqIO3CpgDnCYM1gSmmApNOUQDqAJ8lrDUbvtWE+Ih5qOw2pb4dOw64Wcg6Vx261hpUU4UuIdUlROP97eozoWOspWhHGndCQU5Hg6sIqaqT1w/aGvRQb2utUR8nXJQz75mw5/s3f4cqkoQsH+BKsM9F2/hOAsu0XbE4/g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6666004)(6512007)(6506007)(26005)(316002)(66476007)(66556008)(86362001)(186003)(83380400001)(6916009)(66946007)(8676002)(85182001)(9686003)(2906002)(6486002)(54906003)(4326008)(4744005)(82960400001)(33716001)(508600001)(5660300002)(8936002)(38100700002)(142923001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWV5VDVIOEF5Zm44VlQzTFVoTnhzQWlyQkc4Y3hVOHk1N0wzZXNsVjRwM3JD?=
 =?utf-8?B?SUZldGIzYWtJclhSM0x4aEE3UThtLy84ZnNsUUhyMHpwYTNoRjVxQVE3WTFz?=
 =?utf-8?B?RU42R05kRzh6cFQ2RWU0MXc5SzdFNnBtQldNa0pZVmFtUWk1U3FyRzZEVGor?=
 =?utf-8?B?ZitXSHFma1AxbG5Wdk5zSllNM2Rtb0crNVVDd2ZMUkxzdGhUYzhGSkFobm9r?=
 =?utf-8?B?eC84TXVSRkNET2hLU0pXNTMrVlpyOGhESmp6QkVtbjNTRHBxbHl3UUFZTTU3?=
 =?utf-8?B?NjQ0SFk4djZ1T3ZCQlN0MkZUMTJJK3grNEh0RVk4T3hEWDBpbHJoRWc5ZmQw?=
 =?utf-8?B?Tzk2OHdsek1NdjFDaXIyYWFXdzZDWE5OcWVHUHdodkFXN0daS09XcS83MW9t?=
 =?utf-8?B?emkrZlhPTUFCTGpUdmYrVUo3N3V3TFFUZXBCb2FOeVZDM1UvUUFQZS9SQmtq?=
 =?utf-8?B?ZTVwdU91cU5Mc2s1UW9hblFBdHpNdWUrazBnSzNkL2ZIeXFWZXZwakJ6ckxB?=
 =?utf-8?B?bGd5MFlySTlXb1pkd2l4SmpVVitXd0NKOGlqMjdXcld4WHFybHI3VUU1ZFBO?=
 =?utf-8?B?aHpQZU5ZQ244aGFrdWtWZWx6Zjg1RWFFZVdoV0pHbVBiTzlFWnRtc3RtVGdN?=
 =?utf-8?B?MjZEV0RYVjdwTklicjVxbXRSMjdvVVRJOFV4eDQzdU9pM3hqMEdydUlJWmJG?=
 =?utf-8?B?OStMTnJWamg3NkE2V0hOWlBHYmFUa1QrbXNzcHNlQVVKS1UzMWZIdm5DcjVH?=
 =?utf-8?B?ZUpkdFhub0tlRDdMdEpuNEpWWlFSelVuVnA3dXVZaFpKRy90TFBpSTlDb2t6?=
 =?utf-8?B?NWl4aGRydXVCSEFscitUT2R0TFA3Mk9qdkR1T3VVK0Z1YW0vR0p2M2VndlUr?=
 =?utf-8?B?RHUvSjQvdDZiMzdHUXZtc2puRVhHbTFIaHJ3dUgwZjBhUjFJN1RvRVFHRkJO?=
 =?utf-8?B?clhhV3dHUDFxYTVPNkJGT2VYM2hqOXNUOXZsck5oZCtkclNGSFdTczBRL1hV?=
 =?utf-8?B?MGE3dk96UkdXR1FGZDQzYkZiUERobXBNZW83U0M5Y1NSSS9KVElibks1WWNT?=
 =?utf-8?B?bzl1REYwSEpyV2pZdTh6dE9TQThXTURBOWJSWWJRdER3SFJUYlRTZmtTYUhY?=
 =?utf-8?B?QXFQVXBqSkRhT0c2dHNoYmlkN0w4ZnlOQVhuNEFLa05NRW44ZFV5cmtLZzZj?=
 =?utf-8?B?OTg2UStqVVZiRVc4bXo5NkY1djlCT003cW5KcWVHSndIeUszeFJiQXp1Nlpu?=
 =?utf-8?B?UjkzWTcyZW1OeTQ1S2NWb2RiQTNyNmdseEM3bTNzVFFzMWtxSTF1WDhkeHhY?=
 =?utf-8?B?YkprWTRnZ0tKaDhFV1l6LzNTaUhpTVZqTWNOMlJaVUltQ2tlOUFHT3lPK1pF?=
 =?utf-8?B?dXo1VnV1SkN6YkZscHk3RjlMbDlIMURtN1NzbXpzZHhUb05uSGU2YmdlZ2ZM?=
 =?utf-8?B?anYvQlc1cGhzZVVUWWgvT0ZKRTEvNFFnV0VyeFowY0gxaE5KNllKRHFLVmNQ?=
 =?utf-8?B?TmN1Vk43ZGY1dlI1RFlpang5VDZHbDBsY0pNMGpNZTlRQ0V6MTBCZlpUZjI5?=
 =?utf-8?B?Q1FyWDRZWVlXT2s4c3p5b1JaMzNsTG03VzB6bkE0bUt1MHFxWWtzTkw2Mzkr?=
 =?utf-8?B?RnJxRUp5d0t0S2ZJK2VnNkd6Q0ZIQWFLUWU1NjUvbTNaOHRWMzdvU0FBcWww?=
 =?utf-8?B?dEhueFRTYlMzQzR3Y1RhM3g0NFplQk9WTnBPQkF5bWtzb0FpSHVqY0g4a3J6?=
 =?utf-8?B?UDZHcnNlSzZvY3lTMDUzQkRudHVlUDJ0MmtTaWpod1FBb2Y3NTlDQW5tNTkv?=
 =?utf-8?B?VEQ1ODI3ZFN2VXoxRTBTS1NwdTRyME9wcXpPYWNFTGFxSkdKMk56MFhMUTNW?=
 =?utf-8?B?Y0RlUjJSOTQ2UG4xaHRvZHhWemU3VCt1MlBKQmxBOEpIMHVSZDQvVkoycUxm?=
 =?utf-8?B?Q1o1cDNqdkJzaHhRclRHb2prOGtsZ3djby9sUWs0V2lESzBUbmc0TndMamhG?=
 =?utf-8?B?YlYwRFRaNFBQQytlYjExRnNWd2dhdVdZWW9zRW1Eem1rK3RpTXRXdVUzaDh5?=
 =?utf-8?B?elBhekFCcXh6aE9kQkMybFZqaDJ1U0FuaVNKbXdaNnBZQWJiZmhmNUoxS1lk?=
 =?utf-8?B?aFNjS2hxVDhJYmpXYkJjaWdkZ2M2RVpYMkF3d01BTGNuZEVreWJoNUNZaWIy?=
 =?utf-8?B?OHdvWUcvVW9IbHdnTSt1NzAwbDIydkRPQ0E5eEJoOFdaL21KU3R0Mi9mL2kz?=
 =?utf-8?B?N25DMDF1NFArbUVMTW15WC9ocEJYeFBpYUE3dGt2ZEhQSVRJRWduUld3Wk5j?=
 =?utf-8?B?dlMxQVFPTlN4UkRKbVN0NmRSNmJ1V2w1ajM3ZWkrdk1IWDVJamh2Ykg4aGly?=
 =?utf-8?Q?zjj8Ww3gja9xUwh4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1529697a-6bd5-4710-c2db-08da163f2aed
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 13:29:38.6259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bGFEHv2faoodIhkbFCvj4y1j3hDbNBO8b3uwdU0Qceqqxz2wbddINHx+Rk+sCbQ8If4lHU5qgXQLqstGMFNjgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5518
X-OriginatorOrg: citrix.com

On Mon, Apr 04, 2022 at 02:45:05PM +0200, Jan Beulich wrote:
> (This, as an aside, also makes pretty clear that - unlike the title
> of the series suggests - this has nothing to do with gcc 11.)

I've started debugging this as reported as an issue associated with
building with gcc 11, until I realized it was the assembler that was
adding such section. I guess in my mind I still had the idea of fixing
the build with gcc 11, and hence the misleading subject of the cover
letter. The commit messages should be fine however.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 13:42:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 13:42:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298357.508237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMyG-0001FC-A0; Mon, 04 Apr 2022 13:42:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298357.508237; Mon, 04 Apr 2022 13:42:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbMyG-0001F5-70; Mon, 04 Apr 2022 13:42:16 +0000
Received: by outflank-mailman (input) for mailman id 298357;
 Mon, 04 Apr 2022 13:42:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbMyE-0001Ez-TJ
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 13:42:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ffb9d007-b41c-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 15:41:59 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-44uasHtQMVuJ5gjSiUW2Fw-2; Mon, 04 Apr 2022 15:42:12 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM5PR04MB3186.eurprd04.prod.outlook.com (2603:10a6:206:f::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 13:42:11 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 13:42:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffb9d007-b41c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649079732;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5soGIV/sjJ+W686H/BmlYPnlzwiAAsdQ1yMeMkMv53Y=;
	b=TKaSrAJoZQt6T0SP+cTIYEVnORfwRkA2RPjv5f0rWB19NwG2ShIgWyMh2yd6KunpHRaPn4
	7EIgR4TV0BoOoDULgxpI+fyL+lXc03n+ZCxL/MvY97S7dJ8uIBKDwVmaWGr+d+PvH7fFjl
	aL5YbqDewBvVYQTHaJMxi7PxPGyWfmk=
X-MC-Unique: 44uasHtQMVuJ5gjSiUW2Fw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d9KlpEmUmPd4HHJ6dqCuGTLXi2nliG36T1WQ5+6xMhcyngMtdn7HMwJBx/6do46w6Ef+YfI8kjGrbJ8T7dWMk8C3XRzmJ4zDHy5bJ+tZqKOrZyJ1mDNZphBVjLUFvYEjwdwPfDhwAkp4op+MzbkCHbMhR0MvuIeUWMWlod+iI9ESlD9NdJMdJiYPUXvzqpNtndAYIfWnJPJPgzg9Prxg9UVm0I8D//KGhRV2krprzNcqgZe+Jg5pWLHJ5bscCXk/iLL7mhE0DrOvXHd07ki14bCAsGit1+06MNu6XfALj7GJuqpGibxxtEHWMF++C3Ebke34oZ1b3qugBKMN1xeMnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aHoIdCEpO+jBYTPDkxu6odsSF2r1CJ9hPDTpPVF7tyI=;
 b=dMHB/+op0PloOLRQWq/fOIMlDQ+Zoa15Y/fyBXElWXYXegC4EtiYx/abUo6HrDoGHhJoi13kW1KoFyKts0PSmKzhpZcNJV79Q2mjv8XWyg0y8Qx71r3+FKL5450dUPFiqvA0t+zU5MFnHceWucZJxTt/g4JJUjNA64h1Y/GJciaDSk7yK6c1ub1CqUx8TUKPigEyPRuzhMIQhonnTV5LVAcKKAlQGBtYhDuaCqU02/DMNfqqJNT472ilJCtfJWx+u1U0Z9ixF3/XdIxz6I6JV81hfmxH3gDC1m5adaf6LgUrp4lArGva0qP9TMd0391WoBte48hzkQoksKiQCiPWhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d2bf04d9-53e1-6658-a1d7-ca61bae01141@suse.com>
Date: Mon, 4 Apr 2022 15:42:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: preparations for 4.14.5 ?
Content-Language: en-US
To: Anthony Perard <anthony.perard@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <466e1d4b-a4b6-0797-ca1b-1ea59a3993ba@suse.com>
 <YkcCMg8+dDjxBvJW@mail-itl>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YkcCMg8+dDjxBvJW@mail-itl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0014.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::19) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f1b73bf-c793-478d-9182-08da1640eb59
X-MS-TrafficTypeDiagnostic: AM5PR04MB3186:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB31868C4A4F0C73F2D7427EA3B3E59@AM5PR04MB3186.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RdEdmQxwJWyjnCz1e2l52hjCnOPK3h5dAA/D8y+CNJQIQVOZbp7BFm9X/BoQZ520EuRvJtvFRuLzDeRG4nBO2heq3UUozUwB/eEeg3aVrCAPWmTxCGWlPHqnXu3iZ++u2qqTJXSwQP42nwt+KeqCDNt3LhpMiqYiuR1Dog0EApAVKm4dI5nnL0uf9gocrg3zd8xnmU8sYlbVQPPZvHQRXwFiTBfzNJ367v/j1rrp1jp4YFGjzgZOGhTng5hz0/Xcb3hEtOJrqfclvzc04OXyP3Ewb1iDBdTKHqQ6k4bwb59WvRNm2FhRDNAVgcgXGzCqbXlPm3rZizYrI0khNKyZAoQ6n8Gg1vDHdRJc9siP3XSC/CnMhoCDBZJ3XshR99Uj+UZdag6vhjiB66oTK7cUTRh1m5NZone+M33GVc0/nEyRf4cu8p/gH3xyxyfEfW9IbWIJyfTDKv2h3n/pkvu/ueTUyth/7ewrW4xt0W6HJTq+GAAJps6pTEPumZ0n3zEUmZiKl35tsNSD1Uj+iNLNopC8YxOYwZ1Cc6tZdspc4hSFy9s/RV1UgZdoyEJqM1F4erYGH+iUITXTdUp1WUcMjffOaBuhr8WG/oDTGTBPOj6y5ZXx5Ju01li9eHqJiW7GOsXN50Z4qqWcRk+PxpNBglpmcP3PpIM8AFYnclGQJXWhiu5nLzP5LR3KaDMy2BO69NPBEKCylZzMGr0kOA6cZsUmy2O7gX0d+Na32T2m/XQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6916009)(2906002)(6486002)(26005)(31696002)(8676002)(316002)(4326008)(83380400001)(38100700002)(7116003)(8936002)(5660300002)(2616005)(31686004)(66946007)(66476007)(36756003)(66556008)(6506007)(6512007)(86362001)(186003)(53546011)(508600001)(66574015)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FtHBo5PbMJpDf1awVqra1dJlWaibPa9HPnArcHjIVHXjwjURxQYAwfXHNu9+?=
 =?us-ascii?Q?REmgMRr4sn74u6eMFzG3/B/LeE6o5JB2K8URBukqgGc4xuVMOmcxKsH2Tmgi?=
 =?us-ascii?Q?uyAAit/atkbhty9/iWNj3hNXt3ygUFp1INo4nQoHVpDhT7DllNk79yWeRZ3Z?=
 =?us-ascii?Q?j2n5+46JKnZFdTh7u3ItYpI1yJCptnar6uAFZ0XtNYYg83vCAAHNj8Y7o4Gv?=
 =?us-ascii?Q?ph47gm/BmfPnyjj/t/SVfP8qaJM5SHJlU0bYTmyO0pfsPlzhkBpNhH80/v23?=
 =?us-ascii?Q?pBmB+9uabZg43JBjX05WG93zuJoXsgbPUuuTxaKdaJwaUBw5HZYsUFoNfwZJ?=
 =?us-ascii?Q?tTjXt0KYEN37BJYVM9k3KHSnnQNdEuJR81kX014uV11omb1dC4b+t7d5pa32?=
 =?us-ascii?Q?biacHJ7r3L0EsLnnCyzfyQPwXZ89+Sg6XP2m8Irm3ZBgP2hi1ZClUDqNol4m?=
 =?us-ascii?Q?lzISyom1DJ6Xza/RHLqWuoTV816MWvTknZ6jedvCj31LF3gQ8qXSr+jQOLXp?=
 =?us-ascii?Q?Od+WAuFoN692ZvEHnDjRjUOzrsvwEzRH5A5UKP25+O6Jmfx3qSVu1wYOyLOO?=
 =?us-ascii?Q?DTLw3Ij3vLnHq0CphhRN7XVgGFjTMJo0KO1rcq9eQZNfI8i1Sdk4ixTZhxkD?=
 =?us-ascii?Q?5l/qqSOjIPPNb1fF3Ko81OG13LkUwpeGErNOTt/dhNv65fW5coP0CxUoZvh3?=
 =?us-ascii?Q?bhIEUiqhGRXbuQ1GSzcAOCIn64iAU/9p7LOdlvgnw4ipLr2OZcg4NHdcmPF/?=
 =?us-ascii?Q?VR1EKD3QW1cV8vJWCfwcpA2eNPn2Jq3e5uC6P11BqsZ3mYC3U4WaMY4ckGrM?=
 =?us-ascii?Q?WBcG7eRrlB1urmIYkLIf6F/q/9n97BDIkWHDn261gjru4j5a4V9QVuR24KTi?=
 =?us-ascii?Q?VKClOlq7Rq5+Ea8F3xmugyrloj1g/ILkDbBBDy/Ly04hlF4YXAt4oGcTY7EP?=
 =?us-ascii?Q?etwgz6PIPIJ8+nr1CmQiaTDvhSy5FxhWvqROfqyUn/Xd943/vixQXfNpcclD?=
 =?us-ascii?Q?VTjFTYxXvNH3FrAEqnMSZwXY53Vud+BD0CPE5tiJBrjX58Vcj2FmLOHcsIAN?=
 =?us-ascii?Q?zcGgK71aVXqj7fTY3snoOVPNg4RlxXPQsICdacoAOgRKSHSZkeLWlPj3Cu2I?=
 =?us-ascii?Q?AOnwPq5J1A3LusApSVFslGVIzSw/BoDhHjVhX5qlNRoLc18zHbYpGzHTQjvb?=
 =?us-ascii?Q?5jGNCpL8edZAGZNbIbsCsgM3LoB0gX5VHDHfsFnUPvEBAL7wvUIu3mODPdzg?=
 =?us-ascii?Q?kxvwQIx/+O684vaXh7RLXHGMu+N8BxWKf4AU6psbpbLI7AUWQmpYCuF2Rq5p?=
 =?us-ascii?Q?w8kHQz3EcGKoT6NlV47nKOewQR82foc8I/XhASXQdiW3yzMKfmriETMfxVlj?=
 =?us-ascii?Q?IZx4MHMWJn1dGVCn9Du9TDMAQcAuVrXEWPW1j2euR33J/HQ+akRDTfs2tU7f?=
 =?us-ascii?Q?Oogtk1mwaRBB4Q+UkWOTMYrBpvXrVPeo3Mm8S+HFCKG6L9vnki9selqyd3MI?=
 =?us-ascii?Q?skmdSM9E90LlKSiMZv90eIvFueSV3Arc33L+rlbNUneiMRl4VrUDlLjP6Fas?=
 =?us-ascii?Q?atcB6/3obm2UO2JE8j55fFNF+/jn7+6kP5ZBLEyhPnF2Q321ZD8fX9S2JXLq?=
 =?us-ascii?Q?xDahJOrbcBF3xJc0VhPxMV3SSp+xtEvxTO7IZLqIeUVbpYmAyDoX0vK28Jwr?=
 =?us-ascii?Q?SPglxmjiK/bToM5RlqbJ1LIvATAakLImzAXsGF7a05yBO3z20+N0R1crzjWo?=
 =?us-ascii?Q?ukzlmDdXIQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f1b73bf-c793-478d-9182-08da1640eb59
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 13:42:10.9985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a2oH9NikkuBA/+nCx3dlU51f4VJtwMdc4Rkimf+SsFMbEv1xFEYKtZy1ARcmfqc4rfCS7C2GAAXcsEeCtQxS7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3186

On 01.04.2022 15:46, Marek Marczykowski-G=C3=B3recki wrote:
> On Wed, Mar 30, 2022 at 12:16:00PM +0200, Jan Beulich wrote:
>> All,
>>
>> while 4.14's general support period ended in January, we're considering
>> to cut an out-of-band release due to the relatively large number of
>> security relevant backports which has accumulated in just 2 months. By
>> doing this we would _not_ be promising to do so again in the future.
>> Please voice objections to the plan (or support for it) in the next
>> couple of days.
>>
>> Since it's a little easier to "batch" releases, I would intend to keep
>> 4.14.5 aligned with 4.16.1.
>>
>> Commits I have queued but not committed to the branch yet (and I won't
>> until in a couple of days time, to allow for objections to the plan to
>> be raised):
>>
>> dd6c062a7a4a tools/libxl: Correctly align the ACPI tables
>> aa390d513a67 build: fix exported variable name CFLAGS_stack_boundary
>> e62cc29f9b6c tools/libs: Fix build dependencies
>> eddf13b5e940 x86emul: fix VPBLENDMW with mask and memory operand
>> 6bd1b4d35c05 x86/console: process softirqs between warning prints
>> 07449ecfa425 tools/libxl: don't allow IOMMU usage with PoD
>> 10454f381f91 xz: avoid overlapping memcpy() with invalid input with in-p=
lace decompression
>> 0a21660515c2 xz: validate the value before assigning it to an enum varia=
ble
>> b4f211606011 vpci/msix: fix PBA accesses
>>
>> Please point out backports you find missing from both the respective
>> staging branch and the list above, but which you consider relevant.
>=20
> I'm not sure if "just" bugfix qualify for 4.14 at this point, but if so,
> I'd propose:
> 0a20a53df158 tools/libs/light: set video_mem for PVH guests
>=20
> In any case, the above should be backported to 4.15 and 4.16.

Hmm, Anthony, I'd like to ask for your view here: This looks more
like a cosmetic change to me at the first glance. Plus it's a
little odd to see it being proposed for backporting now, when it's
already almost 4 months old and hence could have gone into 4.15.2
and 4.14.4 if it was important.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 14:00:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 14:00:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298362.508252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbNG0-0003hg-U4; Mon, 04 Apr 2022 14:00:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298362.508252; Mon, 04 Apr 2022 14:00:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbNG0-0003hZ-Ps; Mon, 04 Apr 2022 14:00:36 +0000
Received: by outflank-mailman (input) for mailman id 298362;
 Mon, 04 Apr 2022 14:00:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j0DB=UO=citrix.com=prvs=0868b7840=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nbNFz-0003hR-90
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 14:00:35 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8f022935-b41f-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 16:00:19 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f022935-b41f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649080833;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=oXPkygFoJY55e+SWucnOmDTiQ0SNIKUmYAAayH0bJjc=;
  b=DqMkVAq+DDgFMYpcySioEtcI8gveAVmLVR3Z9+88wcBCQ8yC5N55JYA4
   LQB105r42WiandC82Eq//RZ/HCzYnvQjPDvFir17lQ81Ujy9yaSC35vaC
   xk8/btMEfvDa795GRX7FoDSJuCgkk3wp8NAJ7KS2C17lUCtV3siNaEJON
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67843415
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UPB8UqMt7QUBOYrvrR2fl8FynXyQoLVcMsEvi/4bfWQNrUpxgjIEy
 jMfXmjVOPrfN2Sgc9x1PN7koB5Sv8KHxt9kTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tIw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 cRuq7eAFzgQII7ywsMvVTV6LQ19IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQqaCP
 JZANFKDajzgRQEfZ0w3Fqk+nb6Uu3ruMDZFqBGs8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW73XcPARcbUV+6p/iRiUOkXd9bb
 UsO9UIGr6I/6UiqRdnVRACjrTiPuRt0c9hNF+w37imdx6yS5ByWblXoVRYYNoZg7pVvA2V3i
 BnZxLsFGACDrpW8WFGD3YfKkgqsGhZPCl0ESQ06YQgatoyLTJ4IsjrDSdNqEaiQh9LzGC3tz
 z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNtFsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWa0bb1HRcBJG9GRF5iLJ904DNZWfhoBDyr8UWW1C
 HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66IP4IUOsQsKFTboEmCgHJ8OUi3zSDAdollZ
 /+mnTuEVy5GWcyLMhLoLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q
 o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwOzbiYp
 ijtAxAAoLc97FWeQTi3hrlYQOqHdb50rG4hPDxqOlCt2nM5Zp2o4rtZfJwyFYTLPsQ8pRKoZ
 5Hpo/m9P8k=
IronPort-HdrOrdr: A9a23:XAgVQK97p/eWyO/YoYtuk+F4db1zdoMgy1knxilNoENuHPBwxv
 rAoB1E73PJYW4qKQ0dcdDpAtjlfZtFnaQFr7X5To3SIzUO31HYbb2KjLGSjAEIfheeygcz79
 YZT0ETMqyTMbE+t7eG3ODaKadh/DDkytHSuQ629R4EJmsGC9AC0+46MHfgLqQffngdOXNTLu
 v62iMznUvYRZ1hVLXcOpBqZZmnm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerR8bMpiA2rkAgwbzYxBOe
 twrhGkX9A8N2KxoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIeLH4sJlOz1GkcKp
 gkMCgc3ocgTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbRBFrEmpe4fdIi89vdvHmZw
 ==
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67843415"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KKb+eHiTZ/B/VGdXsbj4Ks7zQ9uOpEDaQqweB5seCC0FZwGOffUUpiP4IY6KZamnsRpjD1WFGEQBfKUc+zHREzN0JmnENo2HQpiDqjeAgDNFKQwaLXiJECja3y0pX3ZQ9WqWm7K5jTzcgPct+zepxRewryxVlrNnr1E2edb6rZevgZxKskknnqdOvjjF/R7TipFDg7gzgpe8N1wpvIq6lzAZDd4/u0yrK6nHHOQT8Syddix43kW0UCCxbELxlXPYtUQv8tEpZ0thvuY6PThwC5ZHJAhwRAwt7MS08oVaGh/8zch/QBCTXdPSXJYk7wXUfmjzni2NtNbqyofuj/xQBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oXPkygFoJY55e+SWucnOmDTiQ0SNIKUmYAAayH0bJjc=;
 b=dEEEexJFFFqiV9mHjo3lOnzKlftE8kSfufuWsRrlkJk5UcULj6wcTs4py57L4PLx2sChI8kKxOn4X3iAKmfPPx+A+8NmYzIGFniml806SL1/jGL9gpZWFU4JbyfFV5ItcL0qqWoSiNvi6kaev2DE4XNM00KjYswVgf1uKxobkA8IuhtmY3ZBE5aJGfVRQ3X6jeBZPrTz4j8KrmQ/kJ299yfF7Nk43zyW0YLQmoRseTzrkyvP4y78XSKpU9TmPC0it/qxKWTqcxuyOAJTXms9i2jfrgRikoZVV4HumBi49aRldLkxtGygcg3uGKjYYpdpe4Zeqx3bpxakGADyrt0djQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oXPkygFoJY55e+SWucnOmDTiQ0SNIKUmYAAayH0bJjc=;
 b=CDdck0Bv4BGr6cV6X0/cGmqjzM4elyp97XLn5bAIH/gOY+J2ANVIGHNKQzzSBomnufLsOvS1LH4XjzkYFVdBZ6X4GrhQDPw9FUhnYWnIzTJTXoZXRVh91s2msNZCQjtWBeGg7+l845Cmm57HV391C2wg/d3Jx2P0Liv5xgo8H3Y=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property
 section
Thread-Topic: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property
 section
Thread-Index: AQHYSBCQ6RH62CeSa0GAvBWgl8BYdazfs3yAgAAVD4A=
Date: Mon, 4 Apr 2022 14:00:27 +0000
Message-ID: <2faf7cac-84c2-230e-c320-ada578748f0c@citrix.com>
References: <20220404104044.37652-1-roger.pau@citrix.com>
 <20220404104044.37652-3-roger.pau@citrix.com>
 <aba2f53d-0790-d337-ce9f-76546201bcdf@suse.com>
In-Reply-To: <aba2f53d-0790-d337-ce9f-76546201bcdf@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d5936132-9a32-4e21-e2a2-08da16437911
x-ms-traffictypediagnostic: MN2PR03MB4733:EE_
x-microsoft-antispam-prvs: <MN2PR03MB4733179B2C2869C1A64F8475BAE59@MN2PR03MB4733.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 15NCScb66x0g/BKKm8YLXIbilSc4C9MZvdoZmot0vbvOFyuSwUu5qGGd0BDx3b8vZzUMt+YUik6N9i4NWv+4vJq31DEybwMtUWdxkU1FCXn58jpHhyPfQ0jyuKOEXmiSAgdbw5om1ZZcAVP40s6jpLz1KoXAINBKSa9C0DSOF+ouLxZ76H3+RLVLiuHA0NmVe3fPm6OJg9bdrm7W8z7HHagnVF5M9g/G8YX1LvV6lJHbVffPPFxYCdKAylfWm/FPrgklTi7MYXjoLeE4AZGm+WW3PSYkHaivLGFJCGUPqVzYhWcrFd7pfQ+EsicAWomjT2LD2XF3bVwYuw14zMgIQgm9r0CGmq7jIq84DXzDGtqrNYA8DlMH6xfMC2HITiqq17+zndftqXLAfHY8HEDKEdeE/Hp2VJ7tw6g1D0507ceJtoF8ZSuKGB0FBSoRLbbXlQPrhtwmgv3Vekdjdn+IpXE0XJC2relF5MLME+oQr1lo7dncKZGQpp3ZapJaczDsoGna+47TSNCuyJolb4izEysjWI+8j8FPqSjlC5/4t52ldzA47CrJ4slQ16jWa3iRMKv9+ONNUzQH2TW+vFj1zT5GWIG7ZgGdnCVdaQQ7spm0Av4DYDWbW+ucZkDOWmXKwRYcFrlKkbS3xxe6Fu77VxzZIcEaTE0S6tfMf7Z2R916XzE6WxqdYN4pX9+cslVCU/VvjkvYXA1tutPvIH5bmjOEO6LIdlRD6LNnszQaEgZ/pgvCKnLM4AwZija5Y+to5cVUysdZggpWfuVzXAdjjrqzjSB6ro/yYH82NvOk8os=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(122000001)(5660300002)(8936002)(6486002)(508600001)(107886003)(38100700002)(2616005)(38070700005)(26005)(186003)(83380400001)(54906003)(6506007)(66556008)(66446008)(2906002)(86362001)(31696002)(6512007)(55236004)(53546011)(8676002)(316002)(4326008)(76116006)(66946007)(91956017)(66476007)(36756003)(31686004)(71200400001)(6916009)(64756008)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cEs4UGdzYlAwZW40eXMweFJwejJaM2dSMldETEZRQ2NjUjVZU0JwU3RTdXBa?=
 =?utf-8?B?ZVZpMEdtRHNnQlJ6V3NqM1hRY3VRNWN6RlZRQXdGYnNVbVZBck10dWlFWnV0?=
 =?utf-8?B?Z2wzNC9WaktwQmlmV2IxYzZ0M3BLdnZXeGtKeDZDRmVYNjlmblY1ZURHTlYx?=
 =?utf-8?B?MlZUUktza055RHBJZWg3YW55YnVwU3BsTUZ5MEpBWTNBU0gwWHkwSmdzQnRJ?=
 =?utf-8?B?TnhLdWhWVno5aml6akc0OEpObjN2OFBWM1l6MlI5VzJhQ1loR3BJNVVKREFR?=
 =?utf-8?B?ajRRWEU0NkJJbFBLQW93bkswc082QktIU3lpVWlTcDVBMWVPOGlZdVRTeHhx?=
 =?utf-8?B?Nks3SnpOM1hXZkh6VWsvOTd4dnVhOW1TK2VaTG9kNE5qaGVWMHBlTGlITGFi?=
 =?utf-8?B?Tk1zSU42NjVFY0w1Skx0UW9TbkNUVC9mcm5XS05kTXYyM0E0Nmcrc1RydGVl?=
 =?utf-8?B?cmdWb2VjQlozdkE3L2ZLd25GRDgxeERCeVBPengxLzRMUGtKeTRWUm5MN3k5?=
 =?utf-8?B?YytLdExzUkNIbHo5alRhZllLRStZbUJjbEJLdHIzN0tsZUdFdU1GbHVqc3RY?=
 =?utf-8?B?VzBlS2JjSE5XUXlQSGR1b0tmWTVJbTBVSFJWcU42dWJTMk5BTkhJTEVMSVl4?=
 =?utf-8?B?dVBiNnFUNDZXcDdqQWt5YlA3OHFTWVc4eEhpRmNpVFZzY3dmNm5XSnpIQmk0?=
 =?utf-8?B?bi9hK3pWME54c2JkbmJOVEIrZk1iVVdicFhIb0VTa3JlOStXa3lXejIwMWxq?=
 =?utf-8?B?bEpJS3gvbzZqRWN0cUQrZmJXSjN0REFYWUQyRU9VSWJUbStBNVJWUk9QLzZD?=
 =?utf-8?B?akMzTHF3VktvVit4T0pxV2EzWG53M2twa2k3VUFUeUtQUXo4dG5COXBwL2Yw?=
 =?utf-8?B?YnlPSmMybk5EZ2N3ZXRobVhDM3pkcUxaYVVOUjhjcU5uUEJ1K3pWV0FLVjIv?=
 =?utf-8?B?SzkxK2dTbzRSQzhzRkdOMDZFbjduT1NlVHZNME1SMGVqWlhTdnNkemFMcVJy?=
 =?utf-8?B?VHhMUGlteVNqbVIramsyWVc3NVlOK3lFbFhuTDROMG9WZ1c0QzNDUTVGRlF5?=
 =?utf-8?B?MVpFMWFsejI4d1BkSkVoWVpmU0twQ0FiNmRacENnbUNhUG1raDh3K3pxWEM4?=
 =?utf-8?B?V2VRT2VjTkhCeWk0YXRBUFFkOCtJdC9rZ3NPb084b25hQnYzdTlEQXNxV28w?=
 =?utf-8?B?QkNOalZFU2FFdnRIcGsxQm1GODBlUXZyUGZiSHZ1QzZNWTNNUHlwMFVrSFpC?=
 =?utf-8?B?VTZxUURzeC81ZU5ZTE5UOGo0WjhLK3d6QWJwa0kyeUdja2d0ODZ5ZHZWN2tm?=
 =?utf-8?B?ZFl3cHd6dytJRU43dXRpY1JUYkxlUkdZV2RZdUhHWlNmM3FYeDRId0ZSaTQv?=
 =?utf-8?B?aWMxYW5XRFZCWjNuMERmcEFVWkczb0haWlNTNkwrMEZhV3J5RjB5YXRYUUtT?=
 =?utf-8?B?dlRLNlUwY1EyWUVJeEtYV09UL0xDZko4a0xuV1FVYndtMUY0T2xKTWhMWGEv?=
 =?utf-8?B?a3lGbkNZLzBuM0VmSXpDMERkRVp4dkNPMi9oRWlpbHVJeVZpYTFTb0NFbEFr?=
 =?utf-8?B?U1FUMEJYbU9rU2wvRHRkN3FaMFhNaWNJQS9rZFhKMzQ4U2hXRnVaRW1mdUxJ?=
 =?utf-8?B?c3NGaEFiMmFEZXNtOUpoMWxqOUx3RnpNdFNLZm0zb3ZHY2k5ZFpjWk1acjFo?=
 =?utf-8?B?R1VsZFNXK1dwWVpRL3pmZGppK3NHb3crUUtTckhIY0dSdllsUE16OURzWVlz?=
 =?utf-8?B?QWcrbm1ncWV0V3JleEtHRmFpeHRpVERpbENCWVR0WnFKQnlyVDRzczkwU3hw?=
 =?utf-8?B?Tno1YzVWZnEyajVIbkVOdVk0Yk9sUklEOURlY1pLSFlxQzRIb2FxOXM0Zmpi?=
 =?utf-8?B?NGV3RDlxcThhTUZCSnh6STl4cFQ1MTVyUDU5d3UxSGpvbmYvamNxc3htYzRG?=
 =?utf-8?B?MUFORWN6S09GeUVmMHlaOGwxZnFZT2o2cWxDakFCeGt1MmRVaGxuc0pSMlQ3?=
 =?utf-8?B?VUJjam5QU0JxOGQxY0NSeCtTS2NBSWljbXVweUd5MnlmSE82RWU1TXg1Mmla?=
 =?utf-8?B?b0J0UXR0R2JuSG13Smo1QlNmL0RqOFUzdHhnS0YwRWE1UzlSNlVUT3hxRk0y?=
 =?utf-8?B?VGd1VHBVSjZMN3VJdUVjWjh3NEdYWlRybXVNUWExOUs2Z0Y5REkvWDlIazh2?=
 =?utf-8?B?bDNxeXI0aFQxS2EzQzluS0hDZ1Y0WHI5ZGhjWXBwV1phRXJyUjZ1ZTQ0QXdP?=
 =?utf-8?B?MW9NTEs0azIvZk0rdmRuZFpPRGFhVm1zL1hNSllaY0o3YXFIN2hySjlhVmRW?=
 =?utf-8?B?SkN5OHlQajhreXEyZjlGRGRIblNhWWZoSC95QkdUeGNWMjNwV3p0dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5712E328BF5CD146AF493964011A5FA9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5936132-9a32-4e21-e2a2-08da16437911
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2022 14:00:27.5088
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LLfspjkU9nQH5+4XYYeRPSsZpeh1MRAMJuNhQ6AGvG2JXzggHcU1+RgLtwH3RT53CcZtIstQHM30ktnG/AkAah/bwOrT6Nx2qdQ3kDHziyc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4733
X-OriginatorOrg: citrix.com

T24gMDQvMDQvMjAyMiAxMzo0NSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA0LjA0LjIwMjIg
MTI6NDAsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4+IFByZXZlbnQgdGhlIGFzc2VtYmxlciBm
cm9tIGNyZWF0aW5nIGEgLm5vdGUuZ251LnByb3BlcnR5IHNlY3Rpb24gb24NCj4+IHRoZSBvdXRw
dXQgb2JqZWN0cywgYXMgaXQncyBub3QgdXNlZnVsIGZvciBmaXJtd2FyZSByZWxhdGVkIGJpbmFy
aWVzLA0KPj4gYW5kIGJyZWFrcyB0aGUgcmVzdWx0aW5nIHJvbWJpb3MgaW1hZ2UuDQo+Pg0KPj4g
VGhpcyByZXF1aXJlcyBtb2RpZnlpbmcgdGhlIGNjLW9wdGlvbiBNYWtlZmlsZSBtYWNybyBzbyBp
dCBjYW4gdGVzdA0KPj4gYXNzZW1ibGVyIG9wdGlvbnMgKGJ5IHJlcGxhY2luZyB0aGUgdXNhZ2Ug
b2YgdGhlIC1TIGZsYWcgd2l0aCAtYykgYW5kDQo+PiBhbHNvIHN0cmlwcGluZyB0aGUgLVdhLCBw
cmVmaXggaWYgcHJlc2VudCB3aGVuIGNoZWNraW5nIGZvciB0aGUgdGVzdA0KPj4gb3V0cHV0Lg0K
PiBJIG5vdGljZSB5b3UndmUgYWNrLWVkIGFuZCBjb21taXR0ZWQgdGhpcyBwYXRjaCwgd2hpY2gg
SSdtIGhhcHB5IHRvDQo+IHNlZS4gSG93ZXZlciwgSSBkb24ndCB1bmRlcnN0YW5kIHdoeSB5b3Ug
Z2F2ZSB5b3VyIGFjayBoZXJlLCB3aGVuIHlvdQ0KPiBkaWQgcmVmdXNlZCB0byBhY2sgKGFuZCB0
byBleHBsYWluIHlvdXJzZWxmISkgZm9yICJ4ODZlbXVsOiBmaXggdGVzdA0KPiBoYXJuZXNzIGJ1
aWxkIGZvciBnYXMgMi4zNiIuIFdoeSBpcyB0aGlzIG5vdGUgc2VjdGlvbiB1c2VmdWwgdGhlcmUN
Cj4gYnV0IG5vdCBzaW1pbGFybHkgdXNlZnVsIGhlcmUgKG9yLCB0aGUgb3RoZXIgd2F5IGFyb3Vu
ZCwgdXNlbGVzcyk/DQoNClRCSCwgSSdkIGZvcmdvdHRlbiB0aGF0IHBhdGNoLg0KDQpUaGlzIHdv
cmsgb2YgUm9nZXIncyBjYW1lIGZyb20gYSByZWFsIFhlblNlcnZlciByZWdyZXNzaW9uIHdoaWNo
IGNhdXNlcw0KUm9tQklPUyB0byBleHBsb2RlLsKgIEl0IG5lZWRzIGJhY2twb3J0aW5nLg0KDQpJ
biB0aGUgbG9uZ3Rlcm0sIEkgd291bGQgbGlrZSB0byBzZWUgdXMgdXNlIHJlYWwgbGlua2VyIHNj
cmlwdHMgZm9yIHRoZQ0KYXJ0ZWZhY3RzIHdoaWNoIGhhdmUgY3VzdG9tIGxpbmsgcmVxdWlyZW1l
bnRzLCBiZWNhdXNlIHRoaXMgaXMgc3RpbGwgYQ0KYm9kZ2UuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 14:08:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 14:08:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298367.508262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbNNb-0004PW-Mh; Mon, 04 Apr 2022 14:08:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298367.508262; Mon, 04 Apr 2022 14:08:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbNNb-0004PP-Jv; Mon, 04 Apr 2022 14:08:27 +0000
Received: by outflank-mailman (input) for mailman id 298367;
 Mon, 04 Apr 2022 14:08:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Btr=UO=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nbNNZ-0004PJ-Ap
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 14:08:25 +0000
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id afcb3405-b420-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 16:08:23 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 063D95C012F;
 Mon,  4 Apr 2022 10:08:22 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Mon, 04 Apr 2022 10:08:22 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 4 Apr 2022 10:08:20 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afcb3405-b420-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=y+pWA6nTgmB2RDy/H
	qeV11THgsCg0yf3WY+brecV0do=; b=GWHMUeUBfbInsoDI+7GohxMU32Bg1RcTK
	5ICW//BwXZnIR5gU7spe7aC/dHtTuweN24QW5vlH2/Tv5jPlC7UaBiyPjBpqvZaA
	JfWXBuHc+hVscI3cHhQ0jD/uLnsP45XnXrB0vXWWE3xbQhqYor3NZLGycfto5nUs
	KDhsHMwpAGlxMps6oMzMFuySL73kaXNVvxE2SDFKlCOgGoYsT+DRGoyELO+PsDOB
	bMdNr5vniPezDYAhx6xacgj6EuLhEAWiP/8dbauyNrGqti9jnR8WNy7CxTlCJJD5
	RZN19+j2Tr1F2r8zTtODHtiUkGAvnWnX0NBZro0lQcwDpJJWiFBgg==
X-ME-Sender: <xms:1ftKYqYSaPDD3tw6xs6mIBALQR7A5HVDtvc_uUAOqIEnPH3SI6icAA>
    <xme:1ftKYtYwD0pnfI9Rv9r5g4fj-XqD1kN0BPAxVjX0e1ikbfcOJwBqX1x9GZ7PyfmjP
    e4D7HqK9_56rw>
X-ME-Received: <xmr:1ftKYk9nAL_-ppL91e_PAyamA7cRJ1--YDPgYKkfIGjrT3Z7R1JE8sVlU1zrFdRL6M8q4K4s8OWK8sB0KJHb3-TLJbFCRJPV1w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejvddgieejucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:1ftKYspitLPi_kuhySN9MwivVD6qvK5oqv0cUsLThEtsJ1LrCe0MDQ>
    <xmx:1ftKYlpQCw8d92_Iz2GMY1VKkcqHaPKWbyz-5JhxyuZpK9wasxE7JQ>
    <xmx:1ftKYqSu4DHjzL06IO1MKlnI6GV2JOKafG7UI3x2nsQggj_qAZfiSQ>
    <xmx:1vtKYmllTpz0ykYXr9uevi3BA_RAb7DoBPJd2KoAWfJIIVxOeuTjMg>
Date: Mon, 4 Apr 2022 16:08:17 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>
Subject: Re: preparations for 4.14.5 ?
Message-ID: <Ykr70scPNU0+C5dR@mail-itl>
References: <466e1d4b-a4b6-0797-ca1b-1ea59a3993ba@suse.com>
 <YkcCMg8+dDjxBvJW@mail-itl>
 <d2bf04d9-53e1-6658-a1d7-ca61bae01141@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="OJ6h1k6N1cxxusss"
Content-Disposition: inline
In-Reply-To: <d2bf04d9-53e1-6658-a1d7-ca61bae01141@suse.com>


--OJ6h1k6N1cxxusss
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 4 Apr 2022 16:08:17 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>
Subject: Re: preparations for 4.14.5 ?

On Mon, Apr 04, 2022 at 03:42:09PM +0200, Jan Beulich wrote:
> On 01.04.2022 15:46, Marek Marczykowski-G=C3=B3recki wrote:
> > On Wed, Mar 30, 2022 at 12:16:00PM +0200, Jan Beulich wrote:
> >> All,
> >>
> >> while 4.14's general support period ended in January, we're considering
> >> to cut an out-of-band release due to the relatively large number of
> >> security relevant backports which has accumulated in just 2 months. By
> >> doing this we would _not_ be promising to do so again in the future.
> >> Please voice objections to the plan (or support for it) in the next
> >> couple of days.
> >>
> >> Since it's a little easier to "batch" releases, I would intend to keep
> >> 4.14.5 aligned with 4.16.1.
> >>
> >> Commits I have queued but not committed to the branch yet (and I won't
> >> until in a couple of days time, to allow for objections to the plan to
> >> be raised):
> >>
> >> dd6c062a7a4a tools/libxl: Correctly align the ACPI tables
> >> aa390d513a67 build: fix exported variable name CFLAGS_stack_boundary
> >> e62cc29f9b6c tools/libs: Fix build dependencies
> >> eddf13b5e940 x86emul: fix VPBLENDMW with mask and memory operand
> >> 6bd1b4d35c05 x86/console: process softirqs between warning prints
> >> 07449ecfa425 tools/libxl: don't allow IOMMU usage with PoD
> >> 10454f381f91 xz: avoid overlapping memcpy() with invalid input with in=
-place decompression
> >> 0a21660515c2 xz: validate the value before assigning it to an enum var=
iable
> >> b4f211606011 vpci/msix: fix PBA accesses
> >>
> >> Please point out backports you find missing from both the respective
> >> staging branch and the list above, but which you consider relevant.
> >=20
> > I'm not sure if "just" bugfix qualify for 4.14 at this point, but if so,
> > I'd propose:
> > 0a20a53df158 tools/libs/light: set video_mem for PVH guests
> >=20
> > In any case, the above should be backported to 4.15 and 4.16.
>=20
> Hmm, Anthony, I'd like to ask for your view here: This looks more
> like a cosmetic change to me at the first glance. Plus it's a
> little odd to see it being proposed for backporting now, when it's
> already almost 4 months old and hence could have gone into 4.15.2
> and 4.14.4 if it was important.

A little context (from IRC discussion on Friday) - this was only
recently identified to fix videoram set to -1 on PVH:
/local/domain/22/memory/static-max =3D "819200"   (n0,r22)
/local/domain/22/memory/target =3D "819201"   (n0,r22)
/local/domain/22/memory/videoram =3D "-1"   (n0,r22)

And since target =3D static-max - videoram, a guest started with
mem=3Dmaxmem doesn't really have them equal.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--OJ6h1k6N1cxxusss
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmJK+9IACgkQ24/THMrX
1yzbYgf+NQ1rRT1SjBzSQxOYFSKetTg6OIVJGdMFrKnY8JiOQNR+CeirSyDSk3Bs
ODjB0zoseZVexCG/Jgw4BQTOJMQwUHed2qmUXYcDtn/lcjJPM4AlnrRHw6+Jzpy2
MIguWaK/ceZvI4HG6PB2wvnJz6GOhwQQjd0/SEnyJTMBvv3RStwWQie7YoIZ8aCZ
DAClhn5xRekSrcG/arj5IQtHErFR+bD9C6TSSZK8+3rKJVeyoeXIRN9Ft2T2VHuZ
jZbaO62/HQWrpQ+n5abFkkmZq1Aod6xvLTwrUDfJ104ar2Ig66CeyULd55Wiv1BS
JHjNWKxiXW/4L7wB1icBsccqryglUw==
=W3pE
-----END PGP SIGNATURE-----

--OJ6h1k6N1cxxusss--


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 14:21:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 14:21:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298372.508274 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbNaa-0006j5-0O; Mon, 04 Apr 2022 14:21:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298372.508274; Mon, 04 Apr 2022 14:21:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbNaZ-0006iy-Sd; Mon, 04 Apr 2022 14:21:51 +0000
Received: by outflank-mailman (input) for mailman id 298372;
 Mon, 04 Apr 2022 14:21:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DIUK=UO=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nbNaY-0006is-G0
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 14:21:50 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8ef74af1-b422-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 16:21:48 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1649082102126315.07576523892146;
 Mon, 4 Apr 2022 07:21:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ef74af1-b422-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1649082104; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=PZsN+E0o4wH9aTOlLcU9+AZoMyS4oZUwNXrTzrZyMe9/Z1mz/2pbuA7032cFbE/UKb/MmSB1P7/CnGpr4o8F4Ntga5WLul7zDoo8kW/H1DviFYA3JjbpxWFwnXqicxxdmTL95uuErE2+EBUmYlekERkQjJlQaM2NmORpn0+7za8=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1649082104; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=PuLKQ80buUJx4m098vQQ40PkNsehct9u+BDBwpDU61Q=; 
	b=n99lybPI6ITk5cdsu6XjHGVjL+NE0Ot2BXqE7oWF4cqrTIwHslMPXyuBP62vGt756v3iHRGFMCVUrd9gXslvBDKpn3VaQftsv3zyC8GzzwwY77KslVJEGvEmsItz9tzxDpxU+INkDAiaseAqRQQjRmRjVHHTYKSovVorij67U/A=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649082104;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=PuLKQ80buUJx4m098vQQ40PkNsehct9u+BDBwpDU61Q=;
	b=u9h7selzC5brKm08vsHvmCOKmi8N33wZ2VkznSZ2fclNBF8yfp0gA6kO0R8qxDRA
	GCQO6lXof0yq48jBvqa6YtSXM+/xhfDDNb0fsdzqKEV6e8E+wtqJHzNQko9ysAzLmmW
	GRlUH5elTwvLvLdr82on/tUVDDMn8Jp09O2m/Dm4=
Message-ID: <25c10763-36fa-34d4-05b6-655c08fdfee7@apertussolutions.com>
Date: Mon, 4 Apr 2022 10:21:18 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, scott.davis@starlab.io,
 jandryuk@gmail.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
In-Reply-To: <YkWgXhFVq/fD72CB@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 3/31/22 08:36, Roger Pau Monné wrote:
> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
>> There are now instances where internal hypervisor logic needs to make resource
>> allocation calls that are protected by XSM checks. The internal hypervisor logic
>> is represented a number of system domains which by designed are represented by
>> non-privileged struct domain instances. To enable these logic blocks to
>> function correctly but in a controlled manner, this commit introduces a pair
>> of privilege escalation and demotion functions that will make a system domain
>> privileged and then remove that privilege.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
>>  xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
> 
> I'm not sure this needs to be in xsm code, AFAICT it could live in a
> more generic file.

>From my perspective this is access control logic, thus why I advocate
for it to be under XSM. A personal goal is to try to get all security,
i.e. access control, centralized to the extent that it doing so does not
make the code base unnecessarily complicated.

>>  1 file changed, 22 insertions(+)
>>
>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>> index e22d6160b5..157e57151e 100644
>> --- a/xen/include/xsm/xsm.h
>> +++ b/xen/include/xsm/xsm.h
>> @@ -189,6 +189,28 @@ struct xsm_operations {
>>  #endif
>>  };
>>  
>> +static always_inline int xsm_elevate_priv(struct domain *d)
> 
> I don't think it needs to be always_inline, using just inline would be
> fine IMO.
> 
> Also this needs to be __init.

AIUI always_inline is likely the best way to preserve the speculation
safety brought in by the call to is_system_domain().

>> +{
>> +    if ( is_system_domain(d) )
>> +    {
>> +        d->is_privileged = true;
>> +        return 0;
>> +    }
>> +
> 
> I would add an ASSERT_UNREACHABLE(); here, I don't think we have any
> use case for trying to elevate the privileges of a non-system domain.

Ack.

v/r
dps


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 14:27:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 14:27:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298376.508285 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbNfi-0007MX-IY; Mon, 04 Apr 2022 14:27:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298376.508285; Mon, 04 Apr 2022 14:27:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbNfi-0007MQ-FW; Mon, 04 Apr 2022 14:27:10 +0000
Received: by outflank-mailman (input) for mailman id 298376;
 Mon, 04 Apr 2022 14:27:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbNfg-0007MG-UM; Mon, 04 Apr 2022 14:27:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbNfg-0008CN-OH; Mon, 04 Apr 2022 14:27:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbNfg-0001ud-Fb; Mon, 04 Apr 2022 14:27:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbNfg-00044h-F7; Mon, 04 Apr 2022 14:27:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+2dBBt+esbRTmbppx55gWV7S7lA8fHyI9VBcdPImC8M=; b=sSbgcWchM8C7wNLX7tjgq7JJQH
	ospNROQvtLAGckaw4nJ9jAtP6r8S2D6ytmRBbmPQFMFbQYlIVL9xb9xKz49ycKeUY+RHUY0J110m+
	mAFwf3bo3PgzHX/9cujLYK1ljLvTFO+M1PSRsoaezgaCfqWeAaoZlHEqwOmZnquti4+Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169156-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169156: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=3e130e40fc55f06f7fe019e87ed9bae957870a12
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 14:27:08 +0000

flight 169156 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169156/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 3e130e40fc55f06f7fe019e87ed9bae957870a12
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   35 days
Failing since        168258  2022-03-01 01:55:31 Z   34 days  275 attempts
Testing same since   169141  2022-04-03 08:40:51 Z    1 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3211 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 14:49:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 14:49:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298385.508296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbO1X-0001Ko-EU; Mon, 04 Apr 2022 14:49:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298385.508296; Mon, 04 Apr 2022 14:49:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbO1X-0001Kh-Ag; Mon, 04 Apr 2022 14:49:43 +0000
Received: by outflank-mailman (input) for mailman id 298385;
 Mon, 04 Apr 2022 14:49:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbO1W-0001Kb-0E
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 14:49:42 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 73804e38-b426-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 16:49:40 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73804e38-b426-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649083780;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=XbOwN9fSFt5ZN2aeCUUoAMZNnhGimNiPjlOHzFlpzs8=;
  b=W7SolaS0jawU1/Wnz5O9ujlGPBXSUo7k+mkaXYCi0+THk7rMXosxPa8Z
   4Wm8z7MkhHcKCR24soqyX7ykl4WLvyoUWaRvCUfv402/IR1TjRJueqztg
   pxWY0YMFUnPfHy9UR3aobPmcEV1a952kt7ilGaqNTwxEdk4DlP4wa7ty8
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67951437
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KgcvaarCkYbTKMgHIX2Yv3Q23KteBmLVZRIvgKrLsJaIsI4StFCzt
 garIBnSOPeIMGD3L992Ydyy8B4Cu57TytBqTlZvqn0xEH8U8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y+q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBLrDmmrwgU0RjTDxSNq5U/ILKClySvpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZVINGMzN0uojxtnHQg0GcJkoOOToHDBKz99uH+viow67D2GpOB2+Oe0a4eEEjCQfu1emUOdu
 2TH43W/BxgcPdOS0xKV/3S0nOjNkCjnHoUIG9WQ1vNsmkzV+WUVBzUfT179qv684mahX/pPJ
 kpS/TAhxYAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0
 UWG9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewcUUCEHu+Tj/bpskz7ETcRnLaOeqvD6TGSYL
 y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxFAHpg
 ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4vWoWyKRBaJ9sldrVj
 Kn74145CHh7ZibCUEOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj6xwRB2yf1iZ
 czHLa5A6Er274w9kVJaoM9Hj9cWKt0WnzuPFfgXMTz5uVZhWJJlYehcawbfBgzIxKiFvB/U4
 75i2ziikH1ivBnFSnCPq+Y7dAlSRVBiXMyeg5EHJ4arf1s9cEl8WqC5/F/UU9E890ijvryTp
 S/Vt44x4AeXuEAr3i3RMS8zMOq/BMknxZ/5VAR1VWuVN7EYSd/HxI8UdoctfKlh8+pmzPVuS
 OICddnGCfNKIgkrMRxHBXUhhOSOrCiWuD8=
IronPort-HdrOrdr: A9a23:XWV6e6xh3vZXnATpZ36aKrPxwOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WBxB8bYYOCCggWVxe5ZnOnfKlHbakjDH6tmpN
 pdmstFeaPN5DpB/L/HCWCDer5Kqrn3k5xAx92ut0uFJTsaFJ2IhD0JbDpzfHcGIDWvUvECZe
 ahD4d81nOdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInhy6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXgIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6X9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d
 FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtbkidzk7hdAAoqJ/lp
 T525RT5cBzp/AtHNFA7cc6MLyK4z/2MGTx2Fz7GyWUKEhAAQOJl6LK
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67951437"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HhMUoAXA0GiQII/q2iV+qMo3gCzNwwdxtMXHz/1x7R14iEaivL7s/ROl42DaHMNE1eivZncXGf941KrpGXE4qiRZ2Uuy1qBaC+oFrNCJA1vSwvJURgl6xPu7di4sOOk3vphmC8shZivQ3IzD0DOJ39khymltUkAZaluaqi/IoM7F3ZFsTjBjFL63JLd5p55KQkVYbxn1A352XE4HVZFoaoGf1LwgVBlpUnzZNX2GDvOu0Cgu2n/lN4N+hKIG9r0jwb1kPc4F45ZhrrY9GZIbgxTncPcgyad4UVYvIY6knxlSfBYzl2h8ga0GDeAv8KCNC69IFkdszLmkDIWtixTmtg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cY2/U7HQ2GVDu9OVSig0xymFmXpVMQst6H3h4SZSRNs=;
 b=NRjfuelYNyX/ivTwdVb5RyM3Uj1suCqYgmEyEL/++OC6jWlM64ISg03ISHrX6LmHaFua450Q+ir7wYvU0fwQDduc84cNN0VnhoBFE+ao6xg/0Hfovyq2C5oQRiLp3HpBvnOU3Qf+Ys2OVJKdA6SmQef9z8OjBmmHQErUJRXlCD1ZlXWoTQTaDxyDGRANmboVT7sproc8FPVaBS7j5iRfKTw8XlkvuXsOYIRiiBA9Nk9wx2uqYw6SoYTvN01P3JIzPVDzpaQueVDjFrfZqyhWhyriNUO2Vw59BWBl7xMOkTvEeHNylZ+ZiH+IWNxsTMvBRfBHXwRsZZgA8HvG0igvrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cY2/U7HQ2GVDu9OVSig0xymFmXpVMQst6H3h4SZSRNs=;
 b=iKZZcuyw0lgRS5EAwyIF4dEz7kpuyQwmxOPWCY9Hgnp8HvGUEP1eHMMROsbtQOsQRpYWprGPtEpv3yo9nq1PoWalthnUw2WrCp3ifUr+SFFr3K8WuqPDhw2GBAbwNex0EtmfrBGChePa9rUCdw5Fbl703EnuK2p1BR4z3RtMxoc=
Date: Mon, 4 Apr 2022 16:49:28 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	"community.manager@xenproject.org" <community.manager@xenproject.org>, Henry
 Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics
 modes
Message-ID: <YksFeCB3bcXBGfDe@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
X-ClientProxiedBy: LO4P123CA0470.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f94545a0-127b-4028-a7f0-08da164a54d4
X-MS-TrafficTypeDiagnostic: BN8PR03MB4753:EE_
X-Microsoft-Antispam-PRVS: <BN8PR03MB4753AB87D5EC10A6E7FA981B8FE59@BN8PR03MB4753.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kSTv8Kxs8s0wi9LzoRLVisHLJ4QtcT8I4HhVkZblXnqFs7Qhqr7WDaoKySVOnqD28kalN5GWcmcYtktB1EGCWcmc5DfIvSSer6J1/eLC0Spdc01w1yfolKJ3waw5WcZwHKo95NJG/q7YqOnes3EiQr4lSxQl22jnR7Z2HCAt5DG4l0jpWaodEDkNcJ7WdcIjkVanzSO3GYPgngfyA5JKvFkeRa9Geuo9utLVZXi2roAGJAavkWcNRNa9iuMjyp5CCLEH19IRSPj69qcimgR05XKVeRN8gH89/PVUpXyjjMhb72LbELI1NSG9AUtYmxsw5jARCpcaHfZFCHDBWiBDh2wGkuUHWswY21f8/JnQFeWMFZhDYgK9J0617r+qz0mg/wQfARqS888qKCfnwXl1ES6dS/z7MeCpMZjvlJnyVPNSPYKQ+8O04jzV4vmbTSzi8b/yT/VyVfb8rvhXWJorSMLTDuryI7VYOB+CCJPTCd0bChrDE/DY1K/vAt9rKbF9nj2wrBvMl58aBIUFZWmzh3bynxGGSfU8mg+1Pc8/swyU3Dhxn4g+ZAU/RXA2Jf3A4aD6zkZrCaFK2FUG6Rve0xkwqVS6zVcLe8Nz0wguMg2j/A6SWi/oHFWQYnIaF72qUdrsEs8AD2CXdUYT+YfTEy/jTfn0eVXkPbuIaMsERfbUorJA5XZMzfentYo5w8Y5SuHjxDvVBKL70H9EvOV8iamdpdA3yT0jd7qJg0tf0k4=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(54906003)(26005)(8936002)(508600001)(186003)(6486002)(86362001)(38100700002)(6916009)(83380400001)(9686003)(66946007)(66556008)(66476007)(6666004)(6506007)(2906002)(33716001)(316002)(6512007)(8676002)(82960400001)(85182001)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWdLK01ESU0rNFArYVJSaG5KRFN5RlJsWTEvMkNscUsvdGMxWVNpUXgxalha?=
 =?utf-8?B?K2lVbVBlVzgrTjNsNWN2U2M3MG1aMUZCRzhzOFAyaUF0V0EzNWRJeUF0QmxY?=
 =?utf-8?B?T2Y0UDRFUFB1bWxmSnpWM0dMZHpOUTYxakZVNUhtL1JqbE1XaWhtdy9SRlA3?=
 =?utf-8?B?SWVMUndQKzQvdWFUU3d3U2FSUWJPZ08yUFRwTElWKzUyM2VadWtCdDAwc1JC?=
 =?utf-8?B?RkdZcWR2cTdKcDQ4bFNPZ01ic1U4RXlSdFR3S1dGb2JqKzhiVzVaYmRJdHdS?=
 =?utf-8?B?TG9naGJ1Tk12emxSaURGSlJKN2dHTUhNdDZmZ2w5RVhHeDJZT0ZvcmRRSTNt?=
 =?utf-8?B?Q0hlbTNTeEpOd0RCcVd2NG95SVlObExCVWxOY0x6ODBSY1ZiUlJxV0pWNXJk?=
 =?utf-8?B?U3luNjJiRWlseUVUQ1l6VXpEVHZ2WW9MYVFRTkRXTkJpNXVDRUUxK05ld2dP?=
 =?utf-8?B?SnRNUHF2MnRvdnQxaWphQVNoMERjd2J2ZjJQbVh1VUozMW82RExGVXBPcHpL?=
 =?utf-8?B?amEyVHh1dHZ2eTlEeUlZaUxDckdKVkUyZDdLdXNQU0g3cGxJSkdMTENTRHFI?=
 =?utf-8?B?VktkSFBPdkVQdHRFeFdHbUhwYVcyRTlQVS9ZclFUMnYzOU5tSURXaGVwdGZG?=
 =?utf-8?B?SE9ITW1hUFUwWWtLUTNhcUpiQUZGbWZoMWgwb05pcC9wc2Q2SlNkZzVTM2FI?=
 =?utf-8?B?UUpYam1YVmQrK3lEY1J5MWV5bWE3eUd5UTJFaExJT1psQUtTTEU5Nnh6M1Zq?=
 =?utf-8?B?WTFnQytuZEQzWStzN21JRlNDWUo5TXZUaHI3bE5xZ2IrZDk1bUtxZ2l4ZEdD?=
 =?utf-8?B?K0MzNXJQUEtJOThqbEFnM0paZHlGaVNiUUlMdTVaVUdJSnkwOThTSitYakI5?=
 =?utf-8?B?NTA5ODBTRHZSVFZXbXo2cktvMi96TFNqWWczYVJZczNjZlZjQy94NmNIcVpI?=
 =?utf-8?B?d1lXOFNTWEFiSzI3K3ZrSjdYeU5jb1NuNHorSnRVYXM1YzRCUUVUOWlReDFT?=
 =?utf-8?B?dkxwNDR4cjJmVDU5VlBnOVYzNmtEdnVQczJ1T0FkM0ZuYTRDNHhhMjk5SDlP?=
 =?utf-8?B?MXR4NmsxdmF0YzB0NzFBdmJVL2ovbUZnQVIyTFdXUXFjSlp6b2FzclVOSU1H?=
 =?utf-8?B?NUFjZWswbEpFNVVEM2lYdDlLMlFNc25GTzdCRGxzUUlyeHdrazdSdFVtS1F3?=
 =?utf-8?B?Ujhsd3hCbzYvMjE2Mnh5OWRwOVVWN29hTGt6K2RLR2hFRVlEbVhJYXB1RVdQ?=
 =?utf-8?B?SjdISjVCVVlZeHRRQTVXSHFJd0Zvc0htL2JGZ2RhbVI1R0VsNmJ2S1l0RlZh?=
 =?utf-8?B?OWJVdzh3MHJhWXlFSU1OaVZFQ0NTRGZyK2lBNzhDYTl4MEJrUU83MWV2cGdJ?=
 =?utf-8?B?SzI2UGU0eW1GcXJpUDhjRlhldWxCamN6VUZITkg0RmtSY0xsZWYzWVgydjh1?=
 =?utf-8?B?cFdZbXNlRHRHSjRCZ25SRmFmSVFyTW9zVlFWeGtTbmJGdGFReFdKSkpZbkJ3?=
 =?utf-8?B?aXV2U1RGQ1QzUGtwMEtROTF6eU5peDlkbTFha2lWdnZGY0RQRXNJZFlJUHdp?=
 =?utf-8?B?VVFpYmwxQUNHeDUyOTJSYkI4NVlyVTZlbU1renF3RW01RkNScTRwK1oyajVj?=
 =?utf-8?B?SWtnZHF0ejJaNkZLUVB2cFVPTS9WLzEyL0VHQWRPaVRKVlRYdEpRVStBVWRC?=
 =?utf-8?B?UzEyRVc3L3NmN1Jsd0l3ejhWMWo3RUpzd0RXaVZ6bWFSYTZVOEtObEIvY2R3?=
 =?utf-8?B?RE1PcWtxKytreForYndick4rWit5QVhteFphZGxTeDJheXkyL3NoU3lEVytO?=
 =?utf-8?B?TWoyUCtpRCtYSllTQ0F4dkhUMktlS2hlYVUvanJ2UFFnQVVmK2ZrK3hsRSts?=
 =?utf-8?B?S0xad1FpV0FIMXBsdWJna2hDelB1VmE2eGxFYlFtZWZiV1BZZzNORHNrbE9N?=
 =?utf-8?B?RG5BNlQ4aUNjaXRVL1NGZURyUGlOV2p3UFJIb09XVmhjaWo4d1JyTE1HS1lE?=
 =?utf-8?B?MkExQ0JIMHNXNktGRjdoSSthS0JyQ3grRTg2cHVSWTduaXRXM0UxQmkxZlpE?=
 =?utf-8?B?Z3V5TEF0ZUQzT0szOTdkSXFqZy9VRVRZK0wrcDRQaWU0Sm5hclRqNldUc0d0?=
 =?utf-8?B?cW90ZXlEMHpvSmo0L0NjalZFelQvb3NVV0g1dDN4WHMyQWR2OUFnbzVSOGg3?=
 =?utf-8?B?RHhnazd4ZEt6ZHp1WTBVSHYzakN3L09HTTk5WWEzKyt0L281NTJ1ODY1UVlj?=
 =?utf-8?B?MlZPK3E3eUVUUGtCRi9PK3VFU2N5RkQzRG1EY1hVVEFubkFYR0hnejlNSWNI?=
 =?utf-8?B?L095dndsc2pwNWtiNVU5Qk9lWEVLdk5vVXZCb2tIOU9oNjVYSjEwYjlWUkFh?=
 =?utf-8?Q?dgTVNryM/4zMFfZA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f94545a0-127b-4028-a7f0-08da164a54d4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 14:49:33.4678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /VyIHhbh2v90qbj6in0VqO2m+pxWrE3QhV0oW5SB39as3VtC10XlyLWUA4xsKJKTgRVMI2efTdo67MHPby69qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4753
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote:
> GrUB2 can be told to leave the screen in the graphics mode it has been
> using (or any other one), via "set gfxpayload=keep" (or suitable
> variants thereof). In this case we can avoid doing another mode switch
> ourselves. This in particular avoids possibly setting the screen to a
> less desirable mode: On one of my test systems the set of modes
> reported available by the VESA BIOS depends on whether the interposed
> KVM switch has that machine set as the active one. If it's not active,
> only modes up to 1024x768 get reported, while when active 1280x1024
> modes are also included. For things to always work with an explicitly
> specified mode (via the "vga=" option), that mode therefore needs be a
> 1024x768 one.
> 
> For some reason this only works for me with "multiboot2" (and
> "module2"); "multiboot" (and "module") still forces the screen into text
> mode, despite my reading of the sources suggesting otherwise.
> 
> For starters I'm limiting this to graphics modes; I do think this ought
> to also work for text modes, but
> - I can't tell whether GrUB2 can set any text mode other than 80x25
>   (I've only found plain "text" to be valid as a "gfxpayload" setting),
> - I'm uncertain whether supporting that is worth it, since I'm uncertain
>   how many people would be running their systems/screens in text mode,
> - I'd like to limit the amount of code added to the realmode trampoline.
> 
> For starters I'm also limiting mode information retrieval to raw BIOS
> accesses. This will allow things to work (in principle) also with other
> boot environments where a graphics mode can be left in place. The
> downside is that this then still is dependent upon switching back to
> real mode, so retrieving the needed information from multiboot info is
> likely going to be desirable down the road.

I'm unsure, what's the benefit from retrieving this information from
the VESA blob rather than from multiboot(2) structures?

Is it because we require a VESA mode to be set before we parse the
multiboot information?

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I'm not convinced boot_vid_mode really needs setting here; I'm doing so
> mainly because setvesabysize also does.
> ---
> v4: Add changelog entry.
> v2: Use 0x9b instead of 0x99 for attributes check: I think the value
>     used by check_vesa also wants to be converted, to match vesa2's.
>     (Perhaps the value wants to become a #define, albeit before doing so
>     I'd question the requirement of the mode to be a color one.)
> 
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog
>  
>  ## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD
>  
> +### Changed
> + - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that
> +   this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen.
> +
>  ### Removed / support downgraded
>   - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options
>  
> --- a/xen/arch/x86/boot/video.S
> +++ b/xen/arch/x86/boot/video.S
> @@ -575,7 +575,6 @@ set14:  movw    $0x1111, %ax
>          movb    $0x01, %ah              # Define cursor scan lines 11-12
>          movw    $0x0b0c, %cx
>          int     $0x10
> -set_current:
>          stc
>          ret
>  
> @@ -693,6 +692,39 @@ vga_modes:
>          .word   VIDEO_80x60, 0x50,0x3c,0        # 80x60
>  vga_modes_end:
>  
> +# If the current mode is a VESA graphics one, obtain its parameters.
> +set_current:
> +        leaw    vesa_glob_info, %di
> +        movw    $0x4f00, %ax
> +        int     $0x10
> +        cmpw    $0x004f, %ax
> +        jne     .Lsetc_done

You don't seem to make use of the information fetched here? I guess
this is somehow required to access the other functions?

> +        movw    $0x4f03, %ax

It would help readability to have defines for those values, ie:
VESA_GET_CURRENT_MODE or some such (not that you need to do it here,
just a comment).

> +        int     $0x10
> +        cmpw    $0x004f, %ax
> +        jne     .Lsetc_done
> +
> +        leaw    vesa_mode_info, %di     # Get mode information structure
> +        movw    %bx, %cx
> +        movw    $0x4f01, %ax
> +        int     $0x10
> +        cmpw    $0x004f, %ax
> +        jne     .Lsetc_done
> +
> +        movb    (%di), %al              # Check mode attributes
> +        andb    $0x9b, %al
> +        cmpb    $0x9b, %al

So you also check that the reserved D1 bit is set to 1 as mandated by
the spec. This is slightly different than what's done in check_vesa,
would you mind adding a define for this an unifying with check_vesa?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 14:56:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 14:56:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298390.508307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbO8R-0002ky-5g; Mon, 04 Apr 2022 14:56:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298390.508307; Mon, 04 Apr 2022 14:56:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbO8R-0002kr-1u; Mon, 04 Apr 2022 14:56:51 +0000
Received: by outflank-mailman (input) for mailman id 298390;
 Mon, 04 Apr 2022 14:56:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DIUK=UO=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nbO8P-0002kl-Tn
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 14:56:49 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 72c36287-b427-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 16:56:48 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1649084197983204.3092203976147;
 Mon, 4 Apr 2022 07:56:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72c36287-b427-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1649084200; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=ShqYNoKYZx66XfZ6O5DbKl7Rg1VAkJS6qqXeXwQlwt2dsbacqjLorak/gAZ7pGWfeX1khRrQmHYKxPHggjYli1J3S4UHg2vIPzLB1Iz4x7WP8cPT4MglBaoTP3tzl1io3fhAfxU1d2K24FcgLNNeAwiJqFefOfd+C29WDGsyFLM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1649084200; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=nMNcmVrf2F6pgJCVlrEQLsJYEWaCohoN0zG8AdD682k=; 
	b=DBFHs5CYB4CZkuIzUV7uDVSWtZoV5I8yREhO/eosEX6KgI6FIYMtuwub9VXdYRDpwQbnz5jhr+VYQd8OiRs78O0lj2bzpwwhURJ79ay89RKbC3p0/o2YKui682IMJaE8wfRrcnqK4MU/qwBurONhisGFbyT42125fLgbRWVCaho=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649084200;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=nMNcmVrf2F6pgJCVlrEQLsJYEWaCohoN0zG8AdD682k=;
	b=hZlNGJ1bWt8MIR17g3M3oln6v/vMJIFPkTiw/y1xKu0n10YxJA3WjhuI7SUyvAzC
	rB3dfHtOAQazknAFngr9I5qNAYz+py7abLTaz/+0zuS2Vm3ToSq2o1ztaaHkoqyZn2T
	UBN4NKMR3U0Sgu5lnjsIao74ykF92UWzckTFWetw=
Message-ID: <4ca5a90f-17f7-791d-ffa2-f48d37ac4675@apertussolutions.com>
Date: Mon, 4 Apr 2022 10:56:13 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org, scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-3-dpsmith@apertussolutions.com>
 <YkWijXX9P1FSs61W@Air-de-Roger>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 2/2] arch: ensure idle domain is not left privileged
In-Reply-To: <YkWijXX9P1FSs61W@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 3/31/22 08:46, Roger Pau Monné wrote:
> On Wed, Mar 30, 2022 at 07:05:49PM -0400, Daniel P. Smith wrote:
>> It is now possible to promote the idle domain to privileged during setup.  It
>> is not desirable for the idle domain to still be privileged when moving into a
>> running state. If the idle domain was elevated and not properly demoted, it is
>> desirable to fail at this point. This commit adds an assert for both x86 and
>> Arm just before transitioning to a running state that ensures the idle is not
>> privileged.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
>>  xen/arch/arm/setup.c | 3 +++
>>  xen/arch/x86/setup.c | 3 +++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>> index 7968cee47d..3de394e946 100644
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -973,6 +973,9 @@ void __init start_xen(unsigned long boot_phys_offset,
>>      /* Hide UART from DOM0 if we're using it */
>>      serial_endboot();
>>  
>> +    /* Ensure idle domain was not left privileged */
>> +    ASSERT(current->domain->is_privileged == false) ;
>> +
>>      system_state = SYS_STATE_active;
>>  
>>      create_domUs();
> 
> Hm, I think you want to use the permission promotion of the idle
> domain in create_domUs() likely?

Apologies, I cherry-picked this onto a branch of staging of what I
thought was an up to date remote, but as Julien pointed out I was not.

> At which point the check should be after create_domUs, and it would
> seem that logically SYS_STATE_active should be set after creating the
> domUs.
> 
> Also, FWIW, I'm not seeing this create_domUs() call in my context,
> maybe you have other patches on your queue?
> 
>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
>> index 885919d5c3..b868463f83 100644
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -589,6 +589,9 @@ static void noinline init_done(void)
>>      void *va;
>>      unsigned long start, end;
>>  
>> +    /* Ensure idle domain was not left privileged */
>> +    ASSERT(current->domain->is_privileged == false) ;
>                                                       ^ extra space.
> 
> I think you could squash this patch with the previous one and also
> squash it with a patch that actually makes use of the introduced
> permission promotion functions (or at least in a patch series where
> further patches make use the introduced functions).

Ack, I can squash them together.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 15:03:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 15:03:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298395.508318 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOEi-0004Ha-UC; Mon, 04 Apr 2022 15:03:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298395.508318; Mon, 04 Apr 2022 15:03:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOEi-0004HT-R6; Mon, 04 Apr 2022 15:03:20 +0000
Received: by outflank-mailman (input) for mailman id 298395;
 Mon, 04 Apr 2022 15:03:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oEUQ=UO=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nbOEi-0004HN-4h
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 15:03:20 +0000
Received: from MTA-09-3.privateemail.com (mta-09-3.privateemail.com
 [68.65.122.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5bf0160b-b428-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 17:03:18 +0200 (CEST)
Received: from mta-09.privateemail.com (localhost [127.0.0.1])
 by mta-09.privateemail.com (Postfix) with ESMTP id E40B118000B3
 for <xen-devel@lists.xenproject.org>; Mon,  4 Apr 2022 11:03:16 -0400 (EDT)
Received: from mail-ot1-f52.google.com (unknown [10.20.151.174])
 by mta-09.privateemail.com (Postfix) with ESMTPA id BEBE818000AC
 for <xen-devel@lists.xenproject.org>; Mon,  4 Apr 2022 11:03:16 -0400 (EDT)
Received: by mail-ot1-f52.google.com with SMTP id
 x8-20020a9d6288000000b005b22c373759so7409962otk.8
 for <xen-devel@lists.xenproject.org>; Mon, 04 Apr 2022 08:03:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5bf0160b-b428-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1649084596;
	bh=3rv4X8v+VGFIEOQfPKafCqAi6l5xacN9nmqLtCCxR9w=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=QPD4eGBrqiawNky3ZzP0C7VYDrGdcMs9/T3CjHvlN2VPqQgBvlHe7G95ZuHcyJnJ5
	 HpMzAbDTzEU1Tg7nnKCI16soBxCqndLsIb/pQykSxrwzB0QASL576iztt8gLynNouJ
	 H5GC/2/exK07qOjA4oxk0bbot/9G/tRmPJ40GQ4+7agUJbRUVGCuU4htbFPRxRC2yE
	 Q/z8dyerOKh3rgvlyj1DsP8oeB+uIdWziwuqSVvhcmsFj37gRGoJHY2CjCD8lAU8Xn
	 0J27Nleu9tDgaWmPbSTYgfiCRV1oy9mW6K/u8PkV9W0fjpKwT5an2OuClr5Ag6CYDD
	 oiHZB5F27ld/g==
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1649084596;
	bh=3rv4X8v+VGFIEOQfPKafCqAi6l5xacN9nmqLtCCxR9w=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=QPD4eGBrqiawNky3ZzP0C7VYDrGdcMs9/T3CjHvlN2VPqQgBvlHe7G95ZuHcyJnJ5
	 HpMzAbDTzEU1Tg7nnKCI16soBxCqndLsIb/pQykSxrwzB0QASL576iztt8gLynNouJ
	 H5GC/2/exK07qOjA4oxk0bbot/9G/tRmPJ40GQ4+7agUJbRUVGCuU4htbFPRxRC2yE
	 Q/z8dyerOKh3rgvlyj1DsP8oeB+uIdWziwuqSVvhcmsFj37gRGoJHY2CjCD8lAU8Xn
	 0J27Nleu9tDgaWmPbSTYgfiCRV1oy9mW6K/u8PkV9W0fjpKwT5an2OuClr5Ag6CYDD
	 oiHZB5F27ld/g==
X-Gm-Message-State: AOAM533VxnaXFVp8YYR644Xf1wxazW9VYCnXdCziYE9olQpRFRhgAS7W
	4lomn3x1HRzbKR4hCeApb02p1UwiDHi4VOWYLVU=
X-Google-Smtp-Source: ABdhPJyS+YTZKechuqmsDoNGN6OV4rFSQOCJbOiyL8/JF+o8Gw+ww72Zs9vqALKC7L8WiPCmE2GgHNBTSyEl7la4T4U=
X-Received: by 2002:a9d:638a:0:b0:5cd:a7fc:aa89 with SMTP id
 w10-20020a9d638a000000b005cda7fcaa89mr208281otk.204.1649084596279; Mon, 04
 Apr 2022 08:03:16 -0700 (PDT)
MIME-Version: 1.0
References: <ab6bb88e90e5649c60e08a1680b3a2390441031b.1648561546.git.tamas.lengyel@intel.com>
 <10b1b71d918b7d7315b49b5932497d094f767a1e.1648561546.git.tamas.lengyel@intel.com>
 <259a550c-9657-d0d2-d58b-c7c7914fa25a@suse.com>
In-Reply-To: <259a550c-9657-d0d2-d58b-c7c7914fa25a@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 4 Apr 2022 11:02:40 -0400
X-Gmail-Original-Message-ID: <CABfawhnwA1fx+S+TO+KZE5-Fh5nOUsXyt7Km0nmDAAgF-CmXEQ@mail.gmail.com>
Message-ID: <CABfawhnwA1fx+S+TO+KZE5-Fh5nOUsXyt7Km0nmDAAgF-CmXEQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] x86/mem_sharing: add fork_complete field to mem_sharing_domain
To: Jan Beulich <JBeulich@suse.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, 
	George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Tue, Mar 29, 2022 at 11:51 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 29.03.2022 16:03, Tamas K Lengyel wrote:
> > The fork's physmap should only be populated with select special pages during
> > the setup of the fork. The rest of the fork's physmap should only be populated
> > as needed after the fork is complete. Add a field to specify when the fork is
> > complete so fork_page() can determine whether it's time to start adding entries
> > to the physmap.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks! After further consideration I'll drop this and the empty_p2m
patch from the series as there is a corner-case with PAE-mode guests
which doesn't play nice with enforcing a start with an empty p2m.
Working around that issue leads to a cascading changeset which
ultimately isn't a worthwhile effort.

Tamas


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 15:13:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 15:13:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298399.508332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOOO-0005mW-Vl; Mon, 04 Apr 2022 15:13:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298399.508332; Mon, 04 Apr 2022 15:13:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOOO-0005mP-Rd; Mon, 04 Apr 2022 15:13:20 +0000
Received: by outflank-mailman (input) for mailman id 298399;
 Mon, 04 Apr 2022 15:13:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Zjy=UO=citrix.com=prvs=08688decb=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbOOO-0005mJ-5n
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 15:13:20 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c0883a15-b429-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 17:13:17 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0883a15-b429-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649085197;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=+I1G5mO7xQT6/YZPWM4BmaRCqxUJGEjSHTbQXe0kJts=;
  b=S0sb/xcQq+M3JcFZFNgVts3KUmIGVKsBGpcN4B036gG1Fo+R0wiju4H6
   J0XCGOrZM/1Qo41H3GXgpGCGHAb9gzQEUVAfRV3Tn9Jnl+n1gUsNmdIZs
   xS70cnMCd3k53Fkni3d46oLIq0Ftrb+3oK4PFZQv2zjTbZZ9O77LaQ7pV
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67383345
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:URozVKqIUNdT/kdr9lYe3OFxf9ReBmLIZRIvgKrLsJaIsI4StFCzt
 garIBmDOf6KYTT0Ldtyboiw9kgA7JTdx99lSwNuqSg8RixB95uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y+q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBOI/0nPo9bANhDyh4NJIc5KaYHWWcmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZVCOWE0MEmojxtnOnJUMa4zh9WUr1LOKxQBlU+Vjo8v7D2GpOB2+Oe0a4eEEjCQfu1Xl0CUv
 HPb/Ez2BxgbMJqUzj/t2n6jiuLAhyrTRJMZFLr+8OVjxlKU2AQ7ExYRSUf9rfCni1WWQM5WM
 Ugd8GwvqsAa+FSwS9jhXzWxuHOeogMHQN1UDvE77weWjKHT5m6xFmUCCzJMdtEinMs3XiAxk
 E+EmcvzAj5iu6HTTmiSnop4thvrZ3JTdzVbI3ZZE01VuLEPvb3fkDrJbO5nDo6KlOTpEDf5/
 GqWtXcCmpY62JtjO7qAwXjLhDelp57sRwEz5xnKUm/N0j6VdLJJdKTztwGFsK8owJKxCwDY4
 SNaw5T2APUmV8nlqcCbfAka8FhFDd6hOSaUv1NgFoJJG9+Fqy/6JtA4DN2TyS5U3ic4ld3BP
 RS7VeB5vsY70J6WgUlfOd/Z5yMCl/WIKDgdfqqIBueim7AoHON9wAlgZFSLw0fmm1U2nKc0N
 P+zKJjwXC5AUfg6kGHqG4/xNIPHIAhkmAs/orihkXyaPUe2PibJGd/pznPQBgzG0E90iFqMq
 IsOXyd74x5eTPf/ckHqHX07djg3wYwALcmu8aR/L7fbSiI/QT1JI6KBkNsJJt0+94wIx7igw
 51IchIBoLYJrSacclvih7EKQO6HYKuTWlpgZnN8ZQ/4gid7CWtthY9GH6YKkXAc3LUL5dZ/T
 uUfetXGBfJKSz/d/C8aY4W7p4tnHClHTyrXZEJJvBBXk0ZcejH0
IronPort-HdrOrdr: A9a23:iR2rNKxWULF1ddbqVBG1KrPxzuskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4yGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87heYAotd/lq
 H5259T5cJzp/8tHNJA7dg6MLmK40z2MGTx2TGpUB3a/J9uAQO5l3ew2sRw2N2X
X-IronPort-AV: E=Sophos;i="5.90,234,1643691600"; 
   d="scan'208";a="67383345"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ka3MBAbtqNFzGmsTmXAS1f/SNov7YAReuIMFlW5StEajHmVE8YyK36C9GuvG17KEqM0zn1KcSr3f7oCfYOnwEZaQ4GUMeWOqIlMUWU3DILQwcnfWhb+4PORtipwTb48oSX/XVWNcT8KcryILBEK0dB8FEIJztk/EcXWOg9ibDOq3E7dsHJ1O1aWya7+BiJ9RMZKuFNr69fLCa3JiIeh1dkP9zkcu8zhWY6O57jE7blDJ0iFdCLdEiq02KXLqnQZEG0OLnr61arMQnwtzjZu9biV+1jRXR8yABeXht0X0HPmYpvonb8visSx9wvybMfXhCDqLmyy0Nb3vdlsaaB5QWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OgKBUul1ceWBKIm74hCd1R6uDpEodk9bv6wQWCNq7eA=;
 b=HrsXseQbv9SvB625vMS4hPri6lxXUG2o97iVRjANscBtuMXusL4gf5tYNqvbnW6rRpoMwS5Qc/HPYVFibEqUYb1kOzDYD4exyJ0Ag4Dx0EqupajQC2+8vFILVvviAxpDVp893aySk0Is+nrqX6qD+EKFB87uA6tsrgbSEtsBLE+oOd59PMUmtwPNFvnIVdic2ES6b1g6jIsBayd4Cm0YVSjZ7juw+ZyD16Qya170RGhHrY0ugrnA0dWy3vqSibEk3UCYredYRmZtWGtIfjjoJx03F509YerDpEwcNLrkjHSXFXGXmrc8HZsvvo90Aa2FDewlwjDK08GAXNBx7I0/hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OgKBUul1ceWBKIm74hCd1R6uDpEodk9bv6wQWCNq7eA=;
 b=wJ37k5e8hO6LWHBaCeTzDJhwS0J/oq1u4monQabShq4A5+z/DqseLDzlPnpCvXxObqESQxcV9f+lH4AoTRCh7Mlvdkmt3Al32ll7NA42U8VmZNFtk/CJyYYViFSJvpOm+EXlg5xMV1vdAbY0u9spqwI7HJ3w5MNvm5YOlVJs9Xk=
Date: Mon, 4 Apr 2022 17:12:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
CC: <xen-devel@lists.xenproject.org>, <scott.davis@starlab.io>,
	<jandryuk@gmail.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Message-ID: <YksK9hIbJbOXkIYd@Air-de-Roger>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
 <25c10763-36fa-34d4-05b6-655c08fdfee7@apertussolutions.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <25c10763-36fa-34d4-05b6-655c08fdfee7@apertussolutions.com>
X-ClientProxiedBy: LO4P123CA0222.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97152026-f345-4bf8-ab7f-08da164d9b44
X-MS-TrafficTypeDiagnostic: MWHPR03MB3261:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB326128F1F7426FDB4D456BA48FE59@MWHPR03MB3261.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kgv4E7DHPuQkqnyaccZiNKZ0dvLRTURIa6GCmPQQ+nQgHGzy98sG0IRasd82Zn18gMCsB4yN+DFd0f4QDa6eBC3EnT4tg2FuQR/4Ygyw/1AsWkfUjjooxWHhWJoN6Zzc4IRK6ZxWOK3DjvQlNQd/TmM+JeBJPmPB58fwELUwWjezDgJ0RmHgzFNc6guvMCrUPgcOF6KAxucL65zv3uLhCAgW0uTA/Qjo3I4w455mcLjG1pGC/A6fSrmACzOLJsO3C9RXQXZrnhoNnr5NCrC8UEhHpoFIIYCoyinEFLV6FUrWSgotJVtJJqP2NeNfbvmQ5eTJIWJBJja40YAKvaniq+R6wrUr9VFGc8/id0VbUBcXAV5ARGYltN27tQy/Hqc/5KJCpEnkeAW6o2O+L8OGlN6DLC4IB1sJ4sopwkMjEqcclr6E1cB9tpVykwqe+BhUcxLSq2aX5oqmmKZzv6RtQaFsYOR3HoymgVyKZpD0t+4ZqpExHDLqKaWyBHenQ15HL989GyatPDPPk4sXlxRiWgg8gOOojb7NTBynn0257TcxDqYiprdk2jpEbuXe5ChVOlRgt0GJ6B7fmc29M43yvcYyuTACQg/LbrJZQqWdgcq+9PAzohQg/5cYbE4vWO0CuG5tVCxg20i98fjx1p6xMw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(82960400001)(5660300002)(186003)(26005)(38100700002)(2906002)(85182001)(33716001)(83380400001)(8936002)(53546011)(107886003)(4326008)(54906003)(9686003)(8676002)(66476007)(66556008)(66946007)(6506007)(6916009)(316002)(6512007)(6666004)(86362001)(6486002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFVLQ3BmNnZtMUVKZUZnQ1NOempuNUprWVhDYU9qVHpLNkJENjV4SkpNVmVM?=
 =?utf-8?B?VHBMdUFZcjNqSXZnYnhJa3hySjQ1d3NDNUY2MEMyeFN5dzFqeThGUWQyR0ty?=
 =?utf-8?B?a25yVUpwN3g2RzFaRjY0THVJT3BZdzUvTGZ3WWkyTTBiaU9ESnZUdzlHTHlo?=
 =?utf-8?B?bXdrS2hGdDVqMmtHcmxhRlg4SW9GTW8vQWZ2U29qbnEvem14NzllamE5Q3h3?=
 =?utf-8?B?bjVaaEFqZlZYOFMvbVpvWVhsTGFpTFRJM296UFAvWGdTRXl5QURWSTZVQVNv?=
 =?utf-8?B?N1NOdDRQbEVvRzdsdmZIMVVOOGFJRUViWk8xaFJzWjZMN0t3eWhSejVlNTEw?=
 =?utf-8?B?eW5BVXEyblpkbDhhN245cjRZVjRobDNmd1R1Y2NKMTZqY1FNdjR5Q0pBWUZP?=
 =?utf-8?B?MDY4OTVJSXNmTGdMRWNFT28yQU5KdmkwdlJvM0h6eDJxYVMvNVlzUUFhZTFL?=
 =?utf-8?B?aXVDMHd6SXZ2dit5MzVVbFFxWHZUekxLZ3RtOWp6aWZMbGZtQnc2dzByQjhX?=
 =?utf-8?B?KzlXYWR3UyszNWZnNXZoSzBjNkE0WjFHQUdwYlBuZFNuNTliT24reThuT0NO?=
 =?utf-8?B?TldYc2pZQTRIeTV6QS9lT3BGeVdjUjBYc3U2R1ZXRElvOXNNNEdTSVArbUtx?=
 =?utf-8?B?M0hGQmUrUVE0QjZ6VkFudUFCQ3pFZlpoRFdXakpjbTllV3dwczk0Rk1KaGp3?=
 =?utf-8?B?K3hGajdZQUc2OUNwbThDaGxOWFp4ZTZoWHRwem1FRXNaeFBpV2x6ZWZHbVYv?=
 =?utf-8?B?U0M4NG01ZkwralVMTjVkVGZKZ0JPaHpFY3ltMHpVZW93Z0RGRUY4RnBiTlFo?=
 =?utf-8?B?Y2Z5M2lta09jMEtobFE1TGFyVk4vb2NhQytXWFpWQlAyY2I2TGp6aFRXSlZR?=
 =?utf-8?B?S015cFVER1Y5WTVkYVNRYXVsbnR6Y0RkWENWcmIyUFdDakFJRGNiZ3FSMi9G?=
 =?utf-8?B?aXZpRTUzMnNyMElMWXdCNUcrTWgzblBidmw5ZVkydGN5VlRONGZkNFcxV3Ni?=
 =?utf-8?B?U21UNGJDTDYxbVdHV3JUWVhodjlGOE9HMTNOdEhHSUhxNkltQTA0bXU0WHQy?=
 =?utf-8?B?Q01OU2FrWUFrTWxjZXRabURjVE5RQTVPNEhSWk9VSGs5Q3NUNlhFTWtSdTV5?=
 =?utf-8?B?MHZoT1ZPdDZJQTFDaEpLRXJIVGtJT2UzWGhDSXRWTmtGcUV5Q09jZU53Wmsz?=
 =?utf-8?B?ZVVpem5WVko3UUsvaEFHQnZKWG5zcXU2VFA5WkkwYjc0SElzYWs4S21BRDRl?=
 =?utf-8?B?V0JaSS9heWpNdG5vMGVVdTNIeVhoa3d5N1RKZFZaandoVzVBa0tEM1NCMkhq?=
 =?utf-8?B?WUJMNGtyaFpuNGVacUkyVDRFcXhJQkJOVjBnSXVwODZQUVJYTlVmY1d6K3Ar?=
 =?utf-8?B?amVveWYwMkV4eXg0NXVhbWhKQ2lDajRVamlmMi9YQU9yRU1lNkNLTi9KLzF5?=
 =?utf-8?B?M3NtYmxycmNWc1BseE53UnhwdVlPcHR1NU1Fd2hMc0JXZGt5U0pNSXZFVmZr?=
 =?utf-8?B?eVBMSkFsbTBkR0tXV09zQnhWV2w0QUNFZ0pTdW1Yb25HMnhMTFRzL25rWDd2?=
 =?utf-8?B?K0YyeldHdkk4WStZaXFrSUNFbkZheXJhTVpDK21LNWtJTjF0MWV4ekI1aTAr?=
 =?utf-8?B?VFEvZEdpTU9GZlNlbW54YUlXbVlyeE90WkcrczZ0dWJZTzYxcTA0YSt5azZ1?=
 =?utf-8?B?UjY3Tm9QUmZFc3M4NXI0K3REU21zWEthR2lWNGR5bEJuSGg4cWxXZTQ3RStn?=
 =?utf-8?B?RzRvQkRKWm9hcVQ5Tk4ya0VxVFZoOFE1V1RZNU9KSDQxRU1HWUEveUt1M1FO?=
 =?utf-8?B?ZU5YbjVoaXMvT2k0cGZIYmxabTBlQWRkQ1pPd1dGR0xTUTBFbmNCSC9zN3NE?=
 =?utf-8?B?UkE2SzJjeTZWUDlTdDZONmpOL1JvaURLdjZQQkdVa0w3Uys0aEZOZmZucFdw?=
 =?utf-8?B?aGhhU0NTYzNUcnNxQ3dkQzRpdFhQY2xlUENrd1BCZStVNlRBS0lzUDhKczE0?=
 =?utf-8?B?RjZRbkpYYkh5ZnpyZGlaaTc3d01FQXRoWXZmbE9ReTQ5M1RrbU9McmZYZGRo?=
 =?utf-8?B?WU05MlcwNmhaUGpkakJNR2ZKTkl5SVBBSDNvZmZ2a0IrYzNQWHNERVVhTDIr?=
 =?utf-8?B?YTE1bkg0ejN4MHpnQjZ4Rk1ORWFCa3AyYml4WFZZWitITVJJWW5QRWhDZE1h?=
 =?utf-8?B?NXVUZEFUY2tCWUxGaHZmb0VFTG82dEdNaFI5MnU3YW5jQ0t0bkZ0QkVmVUhn?=
 =?utf-8?B?NGlWRHkvaXBUdlhkVVRjV0duQnVzWDBQWWxIbWU2NmtWaEgwNjU2bVcyNVg1?=
 =?utf-8?B?aFZLWDcwSVFVNXN1YWFPcVYzdnRrbVpDVUQrRlFWL3Yra2owUUNxbXRhK1NH?=
 =?utf-8?Q?kiqW/5C/mKQQSyXM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 97152026-f345-4bf8-ab7f-08da164d9b44
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 15:13:00.2263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PDEo51W8g5mdjIvhsjeUrl3AqkyELpvtgM4z/vEtn5QzmaNTL0nJQMAGHO563M2rHfC9c6GagSwFAj5mkD4Yyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3261
X-OriginatorOrg: citrix.com

On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote:
> On 3/31/22 08:36, Roger Pau Monné wrote:
> > On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
> >> There are now instances where internal hypervisor logic needs to make resource
> >> allocation calls that are protected by XSM checks. The internal hypervisor logic
> >> is represented a number of system domains which by designed are represented by
> >> non-privileged struct domain instances. To enable these logic blocks to
> >> function correctly but in a controlled manner, this commit introduces a pair
> >> of privilege escalation and demotion functions that will make a system domain
> >> privileged and then remove that privilege.
> >>
> >> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> >> ---
> >>  xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
> > 
> > I'm not sure this needs to be in xsm code, AFAICT it could live in a
> > more generic file.
> 
> From my perspective this is access control logic, thus why I advocate
> for it to be under XSM. A personal goal is to try to get all security,
> i.e. access control, centralized to the extent that it doing so does not
> make the code base unnecessarily complicated.

Maybe others have a different opinion, but IMO setting is_privileged
is not XSM specific. It happens to solve an XSM issue, but that's no
reason to place it in the xsm code base.

> >>  1 file changed, 22 insertions(+)
> >>
> >> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> >> index e22d6160b5..157e57151e 100644
> >> --- a/xen/include/xsm/xsm.h
> >> +++ b/xen/include/xsm/xsm.h
> >> @@ -189,6 +189,28 @@ struct xsm_operations {
> >>  #endif
> >>  };
> >>  
> >> +static always_inline int xsm_elevate_priv(struct domain *d)
> > 
> > I don't think it needs to be always_inline, using just inline would be
> > fine IMO.
> > 
> > Also this needs to be __init.
> 
> AIUI always_inline is likely the best way to preserve the speculation
> safety brought in by the call to is_system_domain().

There's nothing related to speculation safety in is_system_domain()
AFAICT. It's just a plain check against d->domain_id. It's my
understanding there's no need for any speculation barrier there
because d->domain_id is not an external input.

In any case this function should be __init only, at which point there
are no untrusted inputs to Xen.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 15:18:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 15:18:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298406.508342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOSw-0006RQ-HA; Mon, 04 Apr 2022 15:18:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298406.508342; Mon, 04 Apr 2022 15:18:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOSw-0006RJ-E6; Mon, 04 Apr 2022 15:18:02 +0000
Received: by outflank-mailman (input) for mailman id 298406;
 Mon, 04 Apr 2022 15:18:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbOSu-0006RD-Us
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 15:18:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6987a5e0-b42a-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 17:17:59 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-eLw67Z-XO1GfpfF6ppzaUw-1; Mon, 04 Apr 2022 17:17:55 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR0402MB3332.eurprd04.prod.outlook.com (2603:10a6:208:22::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 15:17:54 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 15:17:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6987a5e0-b42a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649085479;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+6CoU2rRwczb21q8Va7JUfarj9XSiMD/HBppIkn9KAo=;
	b=FxOiuRK5XZSYtqgeRcA8WV8zEv0/QSfa6dy/XJhHlR8vIJWGNOn9cHIqyPLdQiifoC28Lw
	hFO3Mwt8c7n3OeuOmtJY0/q7sQKk0seUZRcyApIDPzzq2guCT25eS6vBmfShw/G1JvBVJl
	w/yE856put6Ue/bx3DmxbnO/2JfIK8Y=
X-MC-Unique: eLw67Z-XO1GfpfF6ppzaUw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YTha2m2IHaDFTrHORvKMZ57EHrnAFAxUopKGfCKJZUCQkCquIgUUcu8xNUQgTu3j2HY9uI1xmdHC7ca88G+Kan63yS47HM7z9BTwq72LTWCAYOhBiZuwbITWpoKoI9+C3yT++Pgqr6vXGIFZlSMU5x0VrW9nIya6QeGozyvcz1ZY3IKfIBqcr/XC+L6zTwzxxGa74tk/2zbdYzso7DIFMhvh8+rn6bUj85Gg2hbxELPhIjD6tG2tcHvQtby+PB6Nm/FBkvAlzdQuS8g/5/Rt1mtc/tEBSqhyjn96qgbWXb5hizFtOpeYTX7VvMDN1y+ii6pJ6W2lraQMIIxn26tuaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8Fjw+RuvsKwN1Lk+kT7VLLfY7fyuKPfG8qTanS8TrOM=;
 b=enZzrNUyyR8tChQ+HOGJ9Y0jsAlcPKSJ0/vly+cp6ZGJ2kGEVKRGlpG9cj/h89o4c//EhFnqT3pYDdDSV6pRgkv/XuR1WQRf+dfBlrEUIfMPCl9EAiiWZg3i8CW0578wzpsAKIreV7lZJrlUqtDYIF0E4wdsJitf3Oi+AKeI8nrLrQtQkJcDVa/XSFyyI5dI1ygiOunCSgVs3GLjiWPcOpwp6pfTju7bUQYzvv7Hk+zJX0906tUgETV1Mnl7ADMXNhvh+fkXvxO6tbKdRAyEQz1Lx3vOkwhKSLtotZFvIKCZOC64IQi8gLqPCwtYmFysjIThzi4/dWBm/Z4j98w82A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <54272d08-7ce1-b162-c8e9-1955b780ca11@suse.com>
Date: Mon, 4 Apr 2022 17:17:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
CC: xen-devel@lists.xenproject.org, scott.davis@starlab.io,
 jandryuk@gmail.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
 <25c10763-36fa-34d4-05b6-655c08fdfee7@apertussolutions.com>
 <YksK9hIbJbOXkIYd@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YksK9hIbJbOXkIYd@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0164.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf779b08-9af6-4aec-0188-08da164e4a77
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3332:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3332D2AB6DB0FD64D487D5A5B3E59@AM0PR0402MB3332.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SNSyFvUut8wGJjTx3ox9MoQFQC0Iapt/pUygTLJpxUjUNkoc81MTGCVkChRRmum3xPd6d88UgJ9hRGSMMTHFr4STtN7LmC2U17FbDMEwXOITRg2IiaXe3GF49IbmoxEaisRg/FaZJblEIp6YR62EaCU1x1osjbbmflc1BUAUz5THzP2Y7tW2XYf3F7O6gq8g7TLeQ23hX5NeUfZeNYKJJaUnSu5ah1ZbEoGMkRbkAwRK1BNwdQAFC6iuykvbuwjmOmjNVBiDZ+qD32oY1fsS089SSkEOL5NCsBRwq0KbQxxyTYVphPQk2rwzUqDn2/abtKUxxbzYVdJlkZXZnPcdfF1ufPFm/LOl+E5pg4zs0Z4qMOfmHkaXY3puZ/IBo3/sF14Rh6TaZ61mDd8RDIEI5fgL4JHAgCN9QizGKZ0l5AuqWkqc3nNT5887GpYL+D5BDxCeaDuxIcVMVUqxgxZu1HHcrQ6lUCvaQ7oSrYkDIhkrBy50iHvMIrRdGXXFgmygK+8SJ014ptuhdoLAn3EhGUV15PvglFxc9qRDJ54UQdhfF2U5FFL7EYKt4j6PAamBaxEmn0AsF07zxgAa3TJ66TaBcjdNMkik+CX9IhNx77s20Zp6GvnZoStvptO6CQqInMXWqY6RvBGuptCMlVadqK51iwjxhUYHeY2Q8dVoZ13sHrjH8kWy8CXIs6Ej7hitSIhXp1mXKDILIWVATPzRihYoTrLm2zd/BEOG8oOaRyAYPgdIAvB+Mni4SlMrJbQP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(54906003)(83380400001)(110136005)(5660300002)(86362001)(508600001)(66946007)(31696002)(66476007)(66556008)(6486002)(4326008)(8676002)(2616005)(38100700002)(6512007)(36756003)(31686004)(316002)(53546011)(186003)(26005)(6506007)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0JvxoLi+qomxG+iNHdX4WsJPAyzUTeAXSpKGazA26fAbT78uFagQpFNlwE8v?=
 =?us-ascii?Q?0QefssPPNo6l+9wVIaY99lwnPwGA32sU9FeSTnljBVjOWcZ2qWun5xE8ArWJ?=
 =?us-ascii?Q?ZNp73EBchdbIDELxnZb4VBJUDsrCmcntDNYnS3fqg6Si+M4vmkqLgcWZ5w04?=
 =?us-ascii?Q?/7EeRNNiIu11sEFeYjJvIl9ScEtCjRuGqVVtNrXliXavzU9QfJQ9OfXjULGz?=
 =?us-ascii?Q?ONyDIiQC/mxYszu+hzxoK7l7C+t4b2aEYfSaHfyYIiCLP4BB7zFCP9vbfO13?=
 =?us-ascii?Q?aiaafyZtn3C0dW9uXcMrBwhpTxQxMM3HlZ0ImM94qxj03g2GPDeEZuv5y1yh?=
 =?us-ascii?Q?2bxmMVf63I4bM8GDlKx3sXftNkfFVOXyM1WsDaY+6P6aWb0/QcejuXKm3O+k?=
 =?us-ascii?Q?oXxaRvGjLi6BObceIEnWDH+SvdHEiRPSjuUyXwfZeeQkXlcDNzhGEl/flSsx?=
 =?us-ascii?Q?r4Q7DGP91CaX7D1IvLvE9MKRAGaarZpmSJp+cMo6JchiDnBwZHHm6geljitp?=
 =?us-ascii?Q?uojm230ELenyp9sLg83V11AKK8jZADoPyALSWnGaD4mAqjKjDtx8ggLuaEF/?=
 =?us-ascii?Q?AM6xJoNsr49FhgIu4OOzoeG23Oxof0CSKqhBiraHsfGaPRTX+EaCj7+psXQc?=
 =?us-ascii?Q?7pS2V0tpxCVdHhZDEwJe4yimvEH/e8+VE5Dj0YFZuhr9Y6b7/d+pKOrK0JAQ?=
 =?us-ascii?Q?rj/KJIJwzQZVt1VZSeSB0q2Y/qMnkyiMxAY7f28+zn+dbysAjnzgoiW7HLAd?=
 =?us-ascii?Q?xxLhGiOrSriQu0+ua+Q/vG9oya5oLpEk5F2hGjjDq0CBce1OJxAECPHyxKzw?=
 =?us-ascii?Q?JTOovJwVX56zymSEtqnWo1k/bRVZuYdQ7LdehKXz6toracVfzcvjiOKY3ToW?=
 =?us-ascii?Q?f+qe7nO0w+RgJENWhjZMVMNYVdj28RRRyL+bFOnhdSlsLFizCjn+T3hZvw4s?=
 =?us-ascii?Q?opn9P4+YiSR+Aesc9jRGp8JNPprNuxZxyD0dQnt87eRZRNOIwAiVwGj41g9r?=
 =?us-ascii?Q?uw/ZAIKWNTXn5DlZ1Jf5qmijiSHvd39K8RhJjXctT3GtLiFiRkS1ou4utK4B?=
 =?us-ascii?Q?zAf2Qo94bNEQ1I9wy0iik11QfkATMFNrofy60yQsd3BtcgGugTpotNa/ItY0?=
 =?us-ascii?Q?ObQxZxv06Phc7gnLKRVWvs45NrULVa9G2h1wQ6Jx5IhDUGpJ/ihagqrc2zxx?=
 =?us-ascii?Q?GF+xGVkKu0NYywnFCcIimVcUgddQ6ZbpisoJZ1/QHfET4bohamV9k4wuuru+?=
 =?us-ascii?Q?37F0TgoKQxvxnXovgrWfb3E0qdtQ3xVr9u+ivKZxSGJ4ZteWi+MGQi7c+NY6?=
 =?us-ascii?Q?J9OrT3GgtmSaisnf1qsIybHMmlRyPgtrYiBQtxoL///p0n+kljY/1XHRYtSj?=
 =?us-ascii?Q?NYedehfyN1eaAvl2CQ9GaBCxoMHqVyMA3jK19+CYYbPlM1pOq3OOQc80WAwI?=
 =?us-ascii?Q?zKdl3FdJ/W/1+pDOUNFaelYJG2E30zmfcIZF8YD6fkl9A82FQ3m7zN1nD5xH?=
 =?us-ascii?Q?/MhPAioc3JeX4SheM+1NQA7vxEXojt25ZvLKK9WODMzAXAteufR+YvaNlI2k?=
 =?us-ascii?Q?P+ObliG+YTqTijTifOy/2RYV1LTXbdFFKnl8KQpBxtCgIKoS7i+44eqV9LWY?=
 =?us-ascii?Q?Az8wz2lU/JDDFSYnZ/NgZmz/G4jmhbFZ3WI6G/s0rpweH++Aeb8FhYpanCKW?=
 =?us-ascii?Q?Z90RSFjdO8DQCshY8phArSPqxngo/rlxyVc2HoCbZIcxjpBSOZKN1IA9Njt3?=
 =?us-ascii?Q?jzRQ3yJ/Hw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf779b08-9af6-4aec-0188-08da164e4a77
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 15:17:54.0012
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 96PHPqMJmJzPFwzHSBwX5x17FvBrljSAZ0pVdYrfjIe5HXy4wuv3C1bWNv8NWm7fc+unS6HhTFd3bYKJTrdklA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3332

On 04.04.2022 17:12, Roger Pau Monn=C3=A9 wrote:
> On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote:
>> On 3/31/22 08:36, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
>>>> There are now instances where internal hypervisor logic needs to make =
resource
>>>> allocation calls that are protected by XSM checks. The internal hyperv=
isor logic
>>>> is represented a number of system domains which by designed are repres=
ented by
>>>> non-privileged struct domain instances. To enable these logic blocks t=
o
>>>> function correctly but in a controlled manner, this commit introduces =
a pair
>>>> of privilege escalation and demotion functions that will make a system=
 domain
>>>> privileged and then remove that privilege.
>>>>
>>>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>>>> ---
>>>>  xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
>>>
>>> I'm not sure this needs to be in xsm code, AFAICT it could live in a
>>> more generic file.
>>
>> From my perspective this is access control logic, thus why I advocate
>> for it to be under XSM. A personal goal is to try to get all security,
>> i.e. access control, centralized to the extent that it doing so does not
>> make the code base unnecessarily complicated.
>=20
> Maybe others have a different opinion, but IMO setting is_privileged
> is not XSM specific. It happens to solve an XSM issue, but that's no
> reason to place it in the xsm code base.

To be honest I can see justification for either placement.

>>>>  1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>>>> index e22d6160b5..157e57151e 100644
>>>> --- a/xen/include/xsm/xsm.h
>>>> +++ b/xen/include/xsm/xsm.h
>>>> @@ -189,6 +189,28 @@ struct xsm_operations {
>>>>  #endif
>>>>  };
>>>> =20
>>>> +static always_inline int xsm_elevate_priv(struct domain *d)
>>>
>>> I don't think it needs to be always_inline, using just inline would be
>>> fine IMO.
>>>
>>> Also this needs to be __init.
>>
>> AIUI always_inline is likely the best way to preserve the speculation
>> safety brought in by the call to is_system_domain().
>=20
> There's nothing related to speculation safety in is_system_domain()
> AFAICT. It's just a plain check against d->domain_id. It's my
> understanding there's no need for any speculation barrier there
> because d->domain_id is not an external input.

Whether is_system_domain() wants hardening really depends on where
it's used. It doesn't matter as much what specific check an is_...()
function performs, but what code paths it sits on where taking the
wrong branch of a conditional could reveal data which shouldn't be
visible.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 15:28:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 15:28:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298411.508353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOco-0007xy-Ll; Mon, 04 Apr 2022 15:28:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298411.508353; Mon, 04 Apr 2022 15:28:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOco-0007xr-In; Mon, 04 Apr 2022 15:28:14 +0000
Received: by outflank-mailman (input) for mailman id 298411;
 Mon, 04 Apr 2022 15:28:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7PNb=UO=gmail.com=robherring2@srs-se1.protection.inumbo.net>)
 id 1nbOco-0007xl-6b
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 15:28:14 +0000
Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com
 [209.85.167.181]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d6c0539f-b42b-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 17:28:13 +0200 (CEST)
Received: by mail-oi1-f181.google.com with SMTP id q129so10429711oif.4
 for <xen-devel@lists.xenproject.org>; Mon, 04 Apr 2022 08:28:12 -0700 (PDT)
Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net.
 [66.90.144.107]) by smtp.gmail.com with ESMTPSA id
 a17-20020a4ae931000000b0032933be7230sm3078785ooe.4.2022.04.04.08.28.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Apr 2022 08:28:11 -0700 (PDT)
Received: (nullmailer pid 1366199 invoked by uid 1000);
 Mon, 04 Apr 2022 15:28:10 -0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6c0539f-b42b-11ec-a405-831a346695d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=CMAZDlHZgNwtz0roIoFrFkP5I0hM5Ka8PZuGrF8daIM=;
        b=X4TI70WCKzCJeRLkxDFkAn6phA7lTykwNd35meL2IxBjZj24BOWBo8/u/YUyFcvXli
         3cmSkRX7e7nlZqTKJvCEIHGxQzcfPgTeA9jF7aFdsbImHNAzdcLJQFAv6BBiwUiX5BdC
         pz+UoT2DR/xNMwQofrV94dpDCJ9U3VAsOGD+5BN7rUT41BVgc8vTDkEfq3mY/cvMB4+N
         +2FfaWEgFxlXBylznc+lDNJe++a5b0DHYFVl2UzMfskbZzlB3qvneM4ZnsqBv8wkVAHn
         kWDpx814XS50GaEheY3XzlmUM6rtuFMsDtAQUbRLr06EnptGNt3Y8ku3Xi9JV9+OY7MP
         lJtA==
X-Gm-Message-State: AOAM53325XzpLBin0MU11B5vn4ph05dL5aq2iSAZg9OqdVFF5UGHOIMR
	5kwQxnFc4AbxzrfPEr+VyA==
X-Google-Smtp-Source: ABdhPJzwy0WY7B/N5LU4Fdra5RjMT/BpunQ/E9y8mWRkIFdFoRh+aK0icUktrwTy8x8OLe22r5Us7Q==
X-Received: by 2002:aca:5941:0:b0:2f7:5c90:ad61 with SMTP id n62-20020aca5941000000b002f75c90ad61mr10111767oib.190.1649086091538;
        Mon, 04 Apr 2022 08:28:11 -0700 (PDT)
Date: Mon, 4 Apr 2022 10:28:10 -0500
From: Rob Herring <robh@kernel.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org, Julien Grall <julien@xen.org>, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] of: of_property_read_string return -ENODATA when !length
Message-ID: <YksOipbvQh8N1C+V@robh.at.kernel.org>
References: <alpine.DEB.2.22.394.2203311740450.2910984@ubuntu-linux-20-04-desktop>
 <CAL_Jsq+udUpUK3y7WOeLF2dtGs0=Jz59ed0mu_sgzstB-=TDzA@mail.gmail.com>
 <alpine.DEB.2.22.394.2204011338140.2910984@ubuntu-linux-20-04-desktop>
 <CAL_JsqJ6Yoc-gq=qUw+cS-34ZOsxtHAA01aa+FjaBySz1vwtuQ@mail.gmail.com>
 <alpine.DEB.2.22.394.2204011517450.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2204011517450.2910984@ubuntu-linux-20-04-desktop>

On Fri, Apr 01, 2022 at 03:43:42PM -0700, Stefano Stabellini wrote:
> On Fri, 1 Apr 2022, Rob Herring wrote:
> > On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini
> > <sstabellini@kernel.org> wrote:
> > >
> > > On Fri, 1 Apr 2022, Rob Herring wrote:
> > > > On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini
> > > > <sstabellini@kernel.org> wrote:
> > > > >
> > > > > From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > > > >
> > > > > When the length of the string is zero of_property_read_string should
> > > > > return -ENODATA according to the description of the function.
> > > >
> > > > Perhaps it is a difference of:
> > > >
> > > > prop;
> > > >
> > > > vs.
> > > >
> > > > prop = "";
> > > >
> > > > Both are 0 length by some definition. The description, '-ENODATA if
> > > > property does not have a value', matches the first case.
> > > >
> > > > >
> > > > > However, of_property_read_string doesn't check pp->length. If pp->length
> > > > > is zero, return -ENODATA.
> > > > >
> > > > > Without this patch the following command in u-boot:
> > > > >
> > > > > fdt set /chosen/node property-name
> > > > >
> > > > > results in of_property_read_string returning -EILSEQ when attempting to
> > > > > read property-name. With this patch, it returns -ENODATA as expected.
> > > >
> > > > Why do you care? Do you have a user? There could be an in tree user
> > > > that doesn't like this change.
> > >
> > > During review of a Xen patch series (we have libfdt is Xen too, synced
> > > with the kernel) Julien noticed a check for -EILSEQ. I added the check
> > > so that Xen would behave correctly in cases like the u-boot example in
> > > the patch description.
> > >
> > > Looking more into it, it seemed to be a mismatch between the description
> > > of of_property_read_string and the behavior (e.g. -ENODATA would seem to
> > > be the right return value, not -EILSEQ.)
> > >
> > > I added a printk to confirm what was going on when -EILSEQ was returned:
> > >
> > > printk("DEBUG %s %d value=%s value[0]=%d length=%u len=%lu\n",__func__,__LINE__,(char*)pp->value, *((char*)pp->value),pp->length,
> > > strlen(pp->value));
> > >
> > > This is the output:
> > > DEBUG of_property_read_string 205 value= value[0]=0 length=0 len=0
> > 
> > It turns out that we never set pp->value to NULL when unflattening
> > (and libfdt always returns a value). This function is assuming we do.
> > >
> > > As the description says:
> > >
> > >  *
> > >  * Return: 0 on success, -EINVAL if the property does not exist, -ENODATA if
> > >  * property does not have a value, and -EILSEQ if the string is not
> > >  * null-terminated within the length of the property data.
> > >  *
> > >
> > > It seems that this case matches "property does not have a value" which
> > > is expected to be -ENODATA instead of -EILSEQ. I guess one could also
> > > say that length is zero, so the string cannot be null-terminated,
> > > thus -EILSEQ?
> > >
> > > I am happy to go with your interpretation but -ENODATA seems to be the
> > > best match in my opinion.
> > 
> > I agree. I just think empty property should have a NULL value and 0
> > length, but we should only have to check one. I don't want check
> > length as that could be different for Sparc or non-FDT. So I think we
> > need this instead:
> > 
> > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> > index ec315b060cd5..d6b2b0d49d89 100644
> > --- a/drivers/of/fdt.c
> > +++ b/drivers/of/fdt.c
> > @@ -165,7 +165,7 @@ static void populate_properties(const void *blob,
> > 
> >                 pp->name   = (char *)pname;
> >                 pp->length = sz;
> > -               pp->value  = (__be32 *)val;
> > +               pp->value  = sz ? (__be32 *)val : NULL;
> >                 *pprev     = pp;
> >                 pprev      = &pp->next;
> >         }
> > 
> > 
> > It looks like setting 'value' has been like this at least since 2010.
> 
> Yep, fixing old bugs nobody cares about, that's me :-)

:)


> I made the corresponding change to Xen to check that it fixes the
> original issue (I am using Xen only for convenience because I already
> have a reproducer setup for it.)
> 
> Unfortunately it breaks the boot: the reason is that of_get_property is
> implemented as:
> 
>   return pp ? pp->value : NULL;
> 
> and at least in Xen (maybe in Linux too) there are instances of callers
> doing:
> 
>         if (!of_get_property(node, "interrupt-controller", NULL))
>             continue;
> 
> This would now take the wrong code path because value is returned as
> NULL.
> 
> So, although your patch is technically correct, it comes with higher
> risk of breaking existing code. How do you want to proceed?

We should just check 'length' is 0 and drop the !value part.

Rob


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 15:32:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 15:32:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298415.508364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOgY-0000tJ-5i; Mon, 04 Apr 2022 15:32:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298415.508364; Mon, 04 Apr 2022 15:32:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOgY-0000tC-2h; Mon, 04 Apr 2022 15:32:06 +0000
Received: by outflank-mailman (input) for mailman id 298415;
 Mon, 04 Apr 2022 15:32:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbOgX-0000t2-3b; Mon, 04 Apr 2022 15:32:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbOgW-0000qg-S5; Mon, 04 Apr 2022 15:32:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbOgW-0005md-D9; Mon, 04 Apr 2022 15:32:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbOgW-0002pZ-Ck; Mon, 04 Apr 2022 15:32:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PMpASUeSCBQ7rk9rocljkkVa7byb/jS4GBj8Z3najC0=; b=gb+ey4xNeXlYZrQFhOY36EKrBi
	KN4gHeYFiScyIvo9iKAuYuca1vtB4MK5kZgzL9iCcu+7GgDqUBIpXrTo3hdsuS3vGd3fn+g3pjDFv
	dwlNl/+JrlviN7zlvBPjogceLgFOqo95WU2PRIPhYMVhn2wTO+JbAvs64qyQx27o9ZsQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169152-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169152: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
X-Osstest-Versions-That:
    xen=cd751c09a5bab9f3529901fbe4d867ad7d52e89d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 15:32:04 +0000

flight 169152 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169152/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168502
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168502

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169143

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168502
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168502
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168502
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168502
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168502
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168502
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  bb43e0e1ca20dff14536b7c90ff870f3f50bff8f
baseline version:
 xen                  cd751c09a5bab9f3529901fbe4d867ad7d52e89d

Last test of basis   168502  2022-03-10 09:07:57 Z   25 days
Failing since        168863  2022-03-25 17:36:55 Z    9 days   12 attempts
Testing same since   168970  2022-03-29 04:19:26 Z    6 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 15:33:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 15:33:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298423.508376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOhb-0001WF-Kk; Mon, 04 Apr 2022 15:33:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298423.508376; Mon, 04 Apr 2022 15:33:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOhb-0001W6-Hl; Mon, 04 Apr 2022 15:33:11 +0000
Received: by outflank-mailman (input) for mailman id 298423;
 Mon, 04 Apr 2022 15:33:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbOha-0001Vy-A5
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 15:33:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 879ec1ab-b42c-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 17:33:09 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-EaJHUD68MfKw1oVC83dYlw-1; Mon, 04 Apr 2022 17:33:07 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB4620.eurprd04.prod.outlook.com (2603:10a6:5:39::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 15:33:06 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 15:33:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 879ec1ab-b42c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649086388;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mD8yHOJxc+rAijGZVnxj50SZVMAfGoQcNHRtZtFz4wA=;
	b=KEghT8bki4hlvlxB/kHqigurt60spPSR1pdX0Ir/KdZtzZGU2YQE4QnGwM5vAbEpuF6rkS
	8qQ+AQISm2z8Jqfkvr0LZvTTUK499lDCi/tcavbbGRTmKTBZ/IvXuZn2grRZagaw0/tB7Z
	xDgQmN0VDeTjhUcuPGQRGg5DpyaCf7A=
X-MC-Unique: EaJHUD68MfKw1oVC83dYlw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=US87PWg3Bu8ynHCK6APk+QYQET6nmnRuhxNRdhXsivVyccxRg0j8m3C84oCLXL4m9LMdEf4t/O6+LKmYV8XKE8zYj22HodQB9evPI3GNGsrHg1DYkvhEVpqvZ1aI3IImJmReRbLhgwXQLtR4dzLqfC9mNnwkbtcl3o8FjA5xaYB4wmo6YqX60XEUbvPxQV1gLCXEsIGA+UxloWZY/roUiPQUXS3nHb5c+tdhx5WJWq51wjd25xz0OOkJswN2hS0K49xKMek9YsafA/daXbek3Mruey+cACNGsJ1R572ZW552YAOdsIRDi6hx6ye8IrM70HMtP2D5cWIyMkQ3KHm5Fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YGwiCkItbxzwbnAFSPpg2Q2/IMgz71TMPlzmAfJYVrg=;
 b=U3G9z6PNF544djMQbsqK5tzf2J0GLdTuzuXTl88hF4bjPsOoGLJHAJQojFRCCs4GhZga4fyPtqgjO5lvbsyujQZjHkuu2yIJg/Inqfdp+9WjCTvR2ZRhMcbWNAHpUer4rg5a96hIHaA5eXY9nKvVk1gySqiLFgPDxuCCTZ5OaK2BuHB+PqZ8burVGCXhTrwGbt9ueRZbe0ewwOjw/x2+2QV0MRCbgmyTnYs97IzDF8t1g9MletzY9MC4uekY+zojzsrozJnRFL2zcpacFSfeCJodYNwld794ZiAd6ADoXi7T7wm3GwzYLK8KZ+dTH269cSDKZY29YAYaaZBWVQTlTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0dbc693e-dbff-a326-3d91-b97b7385636f@suse.com>
Date: Mon, 4 Apr 2022 17:33:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 4/4] x86/time: use fake read_tsc()
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <6e540bc9-c536-84ac-fb1c-8271e7731b3e@suse.com>
 <bddbec0e-acc2-03f9-fe4c-167fa5ac0ea1@suse.com>
 <YkrxAX7X1sxVf15r@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YkrxAX7X1sxVf15r@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0088.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::29) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 10310ef8-ec3d-49e1-3b99-08da16506a24
X-MS-TrafficTypeDiagnostic: DB7PR04MB4620:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB46200464BD4870FCE4221604B3E59@DB7PR04MB4620.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HYj7QjHcXhG7tpDBNN1I93XEjusFhbKR6uoYvkXHMvRbvylnLkrq/nZ+mtbjnA3yTXgLpCA4ght1lQcCfbhmttg/3s8SgPskPOp0JfSCfMCaZjaX+xQQoRgAPG0flRvPxn+qdtOw0cFk/DGBZDd5FfxbkzjFoEhNDvO8gpUPqWxYEqYzsrzWswQx++aXj3Rh1tI4qj1VxYwvp5mt0jXkfMrIj1VR4qpHsy67LGAyLZZgqY4NflDis8O94rMBtDgUFw/oSfXgJjKRKXIcgJI+z1STQ90CQUbrxFQZ+3y6y9+PdgF1Q+D/Sq7GNvZ+9sPRfQSu/qNiLoKRZcE50QDtQdo+CRzSW9gBBTf63A4KnBJqya8xIPeJBz03rRhPakPxFlYIQ445on+jvfshfW7lhc8R+Mwt+U9oyRKOwNg+znGLZpzLX9/HWqSFrrojp4Tyv1o1eGae3lo7lGD2XME8ARsklunC4+eV5NzBta3/urTCqxV8Tj0FK7IKTqSYpLtL7o8STob24vY0BFTvVGaGI/C4awBEYL+rfOSy0zjfdQx9YrwxLaM+ePGysj4ROrRICAyuPeCugo98LAGPNgEkCm2heDxUO6LReg2FyXoJ/scWOFS3thE+vIQs4H5lfg+AHElEDZ/+vDXyexMlQYdPXE2M6wRQAlJEUiMYBxltyIhom4Z7n6RgEkowP/Y2jVVLDZ4fim2KijaSPVG25gAY55lttObH5UHLKWyBYvMbo/s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(83380400001)(6506007)(316002)(6512007)(53546011)(2616005)(6486002)(8936002)(2906002)(508600001)(6916009)(54906003)(5660300002)(26005)(186003)(66476007)(66946007)(66556008)(31696002)(86362001)(8676002)(4326008)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0u/nqxY26nr3LXJu3SeHfA0pMV253X2URlRbuLBY4iGgYuH/b/UbGrCqOYbX?=
 =?us-ascii?Q?De/WOJGWqpVB95PoACdBp+2eQtFxh+87HRMDPqdwfv+7PhNskGnYN2H+bF+K?=
 =?us-ascii?Q?2caYNgPLd9hbZPiLhN/NZuqEewP/9MrXDDReVTvAqpsH3/xkuXSR3OT8I/VM?=
 =?us-ascii?Q?3iEZkYgtPUJnwWVgPytKBxQ0NXPOVpidcaIs97uKqcMQbsxD5u62ospMTmnv?=
 =?us-ascii?Q?ALvWlDPfUQUnG6sYJQiootyJjxk/uuMmKxGoLrXUwduXIT6WBmX/YfY1xCSs?=
 =?us-ascii?Q?L/6xcidmRoi2kPIf3Mm12ZHqEV1zztkgNDbK4y9cs4hzEQ7yR/lvi6b10jdy?=
 =?us-ascii?Q?F+EFr2nnqNIvh2+bXHCxqJ+m8pA7C3u22bNcZa8FiqSVYrPovGXyeDXaiege?=
 =?us-ascii?Q?3W/OMfZNTb9j4n2A29rSXe7B9dotMcli9ahiHCWaVd/uWl1HPmbvYJbA2KKK?=
 =?us-ascii?Q?Dsu1nepNbeo5VYgz9fEhk08IuXl7zn0WCt+2s3k2K3IIl8gHeDV44jd9dQBd?=
 =?us-ascii?Q?vOInoqnsJZOCSXSAkbRZ94zlIf8QWIuoAluDNxVQ4spKqUMrdSBaBZnaPspW?=
 =?us-ascii?Q?uAqW/qMS68FTkNQYdifg8qPsZWFASQVM7wcntJpUEqsdJGvhYk6QmPDxHzsi?=
 =?us-ascii?Q?zOWZlnae7LBxRrF2kdN4RYuDbrlHDNf2uuQ2fk6tJpXEuon6wYHMQNCHUSQO?=
 =?us-ascii?Q?VU2c/AvoEbUkI0mcVFiXZpn8tiSbRnAjwZcGs0B3Ka2IHsX6b5xT/cxLRziM?=
 =?us-ascii?Q?cnX3pxPOtWjPkg1H4B5m23X4GtjbDnWKtUM0OfSc9B+ewXCSSPCHShK6Fh39?=
 =?us-ascii?Q?FKfwkhh/Yc8DGDLoghAc2C/Hnr4UKyQeFdt21qC6XDVuWdHs53r1/+OeN5CQ?=
 =?us-ascii?Q?z2w1GvqKoYvtX0DEds1a92m6ks7Eik1GLglQ+JgagDIjlEt3Wps8t2090Bl2?=
 =?us-ascii?Q?ODU/uM63z8e4ecsuhKjxvk+b9PHOIdNhWmUnz/qRyp4UV7w9joTp14OVrrj6?=
 =?us-ascii?Q?bHpm3hwcfa3OHh43Q4qzpuOVcQXM4e46IFB0MZbf6C71+ZxCRoJFqugQIro0?=
 =?us-ascii?Q?wYMqgdkIaJWdvMkWZ269z+RnHbZFU1CchPMtuKSs1GPKnPcfO/4keZBMUMpK?=
 =?us-ascii?Q?52ywH0XHgPTuC3BaugXO/cA6CamzhtvZh0lDRcxAV8YgRffeYumGDL2i2fvK?=
 =?us-ascii?Q?7es84rvc+/qhosDycAYZhrzBakLXglKbCWlnqUWFJB6TM+2xCo3FYoAsBc76?=
 =?us-ascii?Q?dUqHqx70gMTrZdbaHD+OM8wikeELdbrIxTeiJtNIGv2gJ5Uh+6xbSnxroRV3?=
 =?us-ascii?Q?mgavf7XjxNH8auzJNo39FWRyA7cThqtLgFmLc7DRWJI27ii1KMMX/EkXwp96?=
 =?us-ascii?Q?LmjiHjWjOSpMqfcJuwB9hBZHMjeX9yyx6x4S8PA4SWKSCtaLWhq9QOPcXsF/?=
 =?us-ascii?Q?jNXWBsheod5R6kTvjsbHMRKwNpW6ppQgJMvHJHcH4cpljG89VIjF0BUJ+kUA?=
 =?us-ascii?Q?y8gbLTE8Dnqi7B2Hu/r1N4Q0Km9dmulaFWtrAyHZmJtzEqJPJaycSxtarVo2?=
 =?us-ascii?Q?PkNjYBJL2N9r6KfZrq8/LqBd2iOLzYuwof3vIpUHNdTI6+20IsYWEPR3I2Ov?=
 =?us-ascii?Q?BGzdIJqI1uTD3beGPseK7/ysfd5J9iZ0EqPztmIdeerIKgSdaGhgQyUYPKb7?=
 =?us-ascii?Q?S1lkCfwwwFhe5VPYutinUaZBHfsbek4mUCB7/MWn1Jk7qtoAvKJl4abJtx3u?=
 =?us-ascii?Q?6eV15V9TWg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10310ef8-ec3d-49e1-3b99-08da16506a24
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 15:33:06.2331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ab9kjEydoxzXl7Y53AC+UdmANTrtS0fH/ZG9bQfD0sP+hA55JcuJ+eGNgZKu01DVHUzC2aMpHv4J4+lo3O4f0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4620

On 04.04.2022 15:22, Roger Pau Monn=C3=A9 wrote:
> On Thu, Mar 31, 2022 at 11:31:38AM +0200, Jan Beulich wrote:
>> Go a step further than bed9ae54df44 ("x86/time: switch platform timer
>> hooks to altcall") did and eliminate the "real" read_tsc() altogether:
>> It's not used except in pointer comparisons, and hence it looks overall
>> more safe to simply poison plt_tsc's read_counter hook.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> I wasn't really sure whether it would be better to use simply void * for
>> the type of the expression, resulting in an undesirable data -> function
>> pointer conversion, but making it impossible to mistakenly try and call
>> the (fake) function directly.
>=20
> I think it's slightly better to avoid being able to call the function,
> hence using void * would be my preference. What's wrong with the data
> -> function pointer conversion for the comparisons?

There's no data -> function pointer conversion for the comparisons; the
situation there is even less pleasant. What I referred to was actually
the initializer, where there would be a data -> function pointer
conversion if I used void *.

>> ---
>> v2: Comment wording.
>>
>> --- a/xen/arch/x86/time.c
>> +++ b/xen/arch/x86/time.c
>> @@ -607,10 +607,12 @@ static s64 __init cf_check init_tsc(stru
>>      return ret;
>>  }
>> =20
>> -static uint64_t __init cf_check read_tsc(void)
>> -{
>> -    return rdtsc_ordered();
>> -}
>> +/*
>> + * plt_tsc's read_counter hook is not (and should not be) invoked via t=
he
>> + * struct field. To avoid carrying an unused, indirectly reachable func=
tion,
>> + * poison the field with an easily identifiable non-canonical pointer.
>> + */
>> +#define read_tsc ((uint64_t(*)(void))0x75C75C75C75C75C0ul)
>=20
> Instead of naming this like a suitable function, I would rather use
> READ_TSC_PTR_POISON or some such.

I'll be happy to name it something like this; the primary thing to
settle on is the type to use.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 15:34:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 15:34:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298427.508386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOiY-00026Q-Up; Mon, 04 Apr 2022 15:34:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298427.508386; Mon, 04 Apr 2022 15:34:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOiY-00026J-Rb; Mon, 04 Apr 2022 15:34:10 +0000
Received: by outflank-mailman (input) for mailman id 298427;
 Mon, 04 Apr 2022 15:34:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DIUK=UO=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nbOiX-000266-QS
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 15:34:09 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa43cf66-b42c-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 17:34:08 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1649086442843171.49328994365192;
 Mon, 4 Apr 2022 08:34:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa43cf66-b42c-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1649086445; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=kP4vKLZjJ5lI3hBIVQOcfUmZ3gwa1GhmaF3tsT9rZfYtf/lNiLAKyQudsYY3K5fnVsNYnz8T1xny8WaQNwyrE1cceiTUB9VVcM0QY0oQIdhvdqdxjeC6pH3qEp89rQCtfIu05i/2NtV/J0OiR6nrScsBxvi6y6UrETspdH0cr4k=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1649086445; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=z68Pz6YjM5Izd3TJBqligv4+KvIJtZL2RvBOHHjTufM=; 
	b=E9C6gZkTdv1UkaD5ysmnFUhyNfcFVYzBsnNXeDuG9kQNpnnBGFXrwuK5HMSWCk8Ov1imXe0RHuE+hzqZjdSrFk/nmGKAWO1tFV742Do16H9ofSPVxFEFow2T03XkW1ASKHMr7Nkk95+rrTfuoO9MWtyrP2UVsMKazUT/ak8o+aA=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649086445;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=z68Pz6YjM5Izd3TJBqligv4+KvIJtZL2RvBOHHjTufM=;
	b=ksoIyu9lYjQYyB9apHAa7YDk/BUtlTFIiV85XwYZIspsSa7wxvTDPmZdVQ1WKOjW
	q3Lipm8fhYJIdQI93USbXnOfGtjyA3MlE1Cqg6KvZNGDX6hn7eye1XpLCxJpWDXq7Ey
	JCPhPS8SsXXFdJuA9EjPSkPcI4OQdTvcfDFGnvQU=
Message-ID: <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
Date: Mon, 4 Apr 2022 11:33:39 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Scott Davis <scott.davis@starlab.io>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
In-Reply-To: <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 3/31/22 09:16, Jason Andryuk wrote:
> On Wed, Mar 30, 2022 at 3:05 PM Daniel P. Smith
> <dpsmith@apertussolutions.com> wrote:
>>
>> There are now instances where internal hypervisor logic needs to make resource
>> allocation calls that are protected by XSM checks. The internal hypervisor logic
>> is represented a number of system domains which by designed are represented by
>> non-privileged struct domain instances. To enable these logic blocks to
>> function correctly but in a controlled manner, this commit introduces a pair
>> of privilege escalation and demotion functions that will make a system domain
>> privileged and then remove that privilege.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
>>  xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>> index e22d6160b5..157e57151e 100644
>> --- a/xen/include/xsm/xsm.h
>> +++ b/xen/include/xsm/xsm.h
>> @@ -189,6 +189,28 @@ struct xsm_operations {
>>  #endif
>>  };
>>
>> +static always_inline int xsm_elevate_priv(struct domain *d)
>> +{
>> +    if ( is_system_domain(d) )
>> +    {
>> +        d->is_privileged = true;
>> +        return 0;
>> +    }
>> +
>> +    return -EPERM;
>> +}
> 
> These look sufficient for the default policy, but they don't seem
> sufficient for Flask.  I think you need to create a new XSM hook.  For
> Flask, you would want the demote hook to transition xen_boot_t ->
> xen_t.  That would start xen_boot_t with privileges that are dropped
> in a one-way transition.  Does that require all policies to then have
> xen_boot_t and xen_t?  I guess it does unless the hook code has some
> logic to skip the transition.

I am still thinking this through but my initial concern for Flask is
that I don't think we want dedicated domain transitions directly in
code. My current thinking would be to use a Kconfig to use xen_boot_t
type as the initial sid for the idle domain which would then require the
default policy to include an allowed transition from xen_boot_t to
xen_t. Then rely upon a boot domain to issue an xsm_op to do a relabel
transition for the idle domain with an assertion that the idle domain is
no longer labeled with its initial sid before Xen transitions its state
to SYS_STATE_active. The one wrinkle to this is whether I will be able
to schedule the boot domain before allowing Xen to transition into
SYS_STATE_active.

> For the default policy, you could start by creating the system domains
> as privileged and just have a single hook to drop privs.  Then you
> don't have to worry about the "elevate" hook existing.  The patch 2
> asserts could instead become the location of xsm_drop_privs calls to
> have a clear demarcation point.  That expands the window with
> privileges though.  It's a little simpler, but maybe you don't want
> that.  However, it seems like you can only depriv once for the Flask
> case since you want it to be one-way.

This does simplify the solution and since today we cannot differentiate
between hypervisor setup and hypervisor initiated domain construction
contexts, it does not run counter to what I have proposed. As for flask,
again I do not believe codifying a domain transition bound to a new XSM
op is the appropriate approach.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 15:51:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 15:51:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298432.508398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOyw-0004VC-BA; Mon, 04 Apr 2022 15:51:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298432.508398; Mon, 04 Apr 2022 15:51:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbOyw-0004V5-7X; Mon, 04 Apr 2022 15:51:06 +0000
Received: by outflank-mailman (input) for mailman id 298432;
 Mon, 04 Apr 2022 15:51:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XwhO=UO=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbOyv-0004Uz-0m
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 15:51:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 08475cda-b42f-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 17:51:03 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-MmQ10txMNsm0s9qfCCmRzg-1; Mon, 04 Apr 2022 17:51:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5520.eurprd04.prod.outlook.com (2603:10a6:803:cc::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr
 2022 15:50:59 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022
 15:50:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08475cda-b42f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649087463;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ARFGu0yX/v8BfWGK/f0iUvDFJYiKkJSpJA8ULoIMzD0=;
	b=ROeACkGPgtwSx1JUXupIR1r3nRnypHXZtEChys0xohWXB/E9gILZpTg4iknNo5xHfy2/ll
	9MCVSaWah3KmpbCf9j6+llsddeXVhJSUhoIXSqSOcpcjGPmxvETsHMqLN3Pe0OEakFhw4q
	ETydl7AoX4rlVVfjKTP+ZuWzO26ICEw=
X-MC-Unique: MmQ10txMNsm0s9qfCCmRzg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PNlUMV3II+s77LvRQ4WenznMHtay4HW7t9iqVjHq+/WxgEIxZhbmuhAYg06Y4wuODP7rJymJ3ZJEsIoYN7E5X5ZWDFZiFB+DmyjuKw/VIbRQsFSI5kaaS/g/1lfn/97fv0YQ2mvwkdD1jBlHW1M1DVPWVZCKA3uNxzYoyxWcQQqvVOq3Paj5JHOMId65ZJTwioM72/SLpfY9JFunpx54utbUyuer4E2+vT621WywLHrNHSEq4G3kaqR89js/442G6cSkBqkg7jlktNiay1Hv4YWwo5jjOFIuwOcQHlYvSAALvdw8iCkPOBbkLJDFU/O1PE0Z+b8n69cVEp74iQVdIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z/kRyZAouxKhyufkdxuZDL1nBfdiou+8O4FXFXLoL50=;
 b=Xg1w6xjSrjyI4b/v0LU8JssTKk7ZiHzYEO4JcpBx2UkdSBYp6/GDo+x4OBQJAqPfSD+4/1epbDRbGEIf69xuxjL4IxFmsiNotqeFvh1MtUK8tKLIILLcz2lXHoB7pTx8OpgNEgjNgy9W2pzmjkDX6MguZTxhmByiz1yXmkp9G5Ycg/SSmYxeL7ZBPEcDvvLHd9ttPktgQjEdMkxBz9/g/k9vU4ZnOHFfPUGCqlNEXoW+mNkG3xs2W45ePrlmIRjymTa/AXEnp9RzKJG4KdeID2/ek8mN6QVOEoFVrOvY8ksDksiQo4DzFZNSUQUNAq8fNLEG/x12HPb5tnb/j4LdKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <aca0954d-e235-4b25-458b-1183a7471b12@suse.com>
Date: Mon, 4 Apr 2022 17:50:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics
 modes
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
 <YksFeCB3bcXBGfDe@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YksFeCB3bcXBGfDe@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0301CA0013.eurprd03.prod.outlook.com
 (2603:10a6:206:14::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1e61c3fc-9717-41a4-65c8-08da1652e9c0
X-MS-TrafficTypeDiagnostic: VI1PR04MB5520:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5520BC85EF38C06A74B87A4EB3E59@VI1PR04MB5520.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7rpU/2gVKcAODX597FK/HOoclhJLIjOrzZbFISva1JdcsN2tmUODMz4ZGQPeHR+X5UQJA4dWpX0+FlP62CsfC/D0fWTcTkIkaGJz2tdXr69gNKfOqPaJo3DdSpCIkFilx4L3xUVklWWGXi/D5tKTKvJ4UMoqt00fGKbKhPsxxiCWmtl5xDbSXaV6pjAS7O1nkZnJjaxtEXD1eJv+MnUyRTcg6r/tCAxR6f3kHc0ogeiUlg5g/Yrf+CiOMRieR6ODay6kAl/iMd4qZRfDn2csb/n/o4PqQISw64bMzDYfTl+h5Mpo2JMwkpl6U7RHt3SVn7oR3cXSeJ2t620oy4e8EafuA/t81U91bllLH4GPKIuOURLi8YZYemupEq3WqvSNrR915az2EfaG3j708flzlbyTHIM52DRRHkzFr+emuUjajaezZRhYWObFT7PmaT3nhNUt52CA/ssawpoNIkvoiHZncV2RgEMmb7OBi9rHoexvtPDps0RU2ie+DDpWrSIRiwY+tttGo88vJOVy8+ds2ATJPvOgpiXZlSy5zLVBs5lpzivp95DucW9C9KudRmDLCXKQR05AN2OgyGGxCu33FNlTbOxdRFQ+ZRGOHTlygc1S2EBRVUbxYEsh3DVBC4RV1pal81vhuqw7VNqI08gWsjW+vsKXl86d6aTXxxt1mkOSqE1cuCb624KJWbhR3Fik+UoEIED5de+UnQDpi+BSWVuvH8MG+wtKk6QUx0Fc0BSryWXtz94sq+9RdHXiBWgi
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(2906002)(31696002)(8936002)(86362001)(36756003)(5660300002)(66556008)(66476007)(6916009)(2616005)(66946007)(54906003)(53546011)(6512007)(6506007)(316002)(38100700002)(4326008)(8676002)(508600001)(6486002)(26005)(83380400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?O88/iGxR+ZL0TxXkFiZR6DPzsrdEPqvUklaAG22Xle+a/r+NV5P/NAuTj+pV?=
 =?us-ascii?Q?y9znC5IwNpQOBwh9TxD/ISuQnAo0QCce4n+xCzRI7ZLd1d12r1duRS/093Dj?=
 =?us-ascii?Q?IGavhi+0R/sdVFtaV7Pg+pRHxUkHJ1CIukdM2RlRxD5PiVFsngz1Gq82e+Mq?=
 =?us-ascii?Q?wesw+ED5vOINhKTp2FhhfoEUgFtDRwzVaBcgHgK9piGAIQ/dXfT8EcwgzySU?=
 =?us-ascii?Q?V3ZyseN+X9cvIBNJtNKvNUNN+QwNKslVPDQknJeCD5vwQqo8Fywj2JMQrdFU?=
 =?us-ascii?Q?N3w5mbyCFLGR/r6H7MVjLwRU6MY6RhcXRXc3Aazsfaw8Fbyr/2plr7wWjSso?=
 =?us-ascii?Q?2GdsFGBKQii9pxlcAJSaVBrCN/o362l8L1X6qPOQUar0qgTbJ+4bzQ+XXVlD?=
 =?us-ascii?Q?OeKbmQwrQpHJY96ebUjJUwoH7A4YZBfoFhxKKAKRnWdbjfB0S3m99FMUbN/o?=
 =?us-ascii?Q?jQFS28dEu+JcHXz/erhg28HX0Fq5VeBccXEWU8YBRYLJcvhMm5/0CwPaLT4V?=
 =?us-ascii?Q?n/PA/8MC5aPh9lsk3WwfQfttC69olJ0r/W9K6egzX0TKpZwbxaaWMEyx9Lp8?=
 =?us-ascii?Q?qoOJtu4kFX7BjvFvVN2eGTt51sNmPLOQHsoPSnCO1qcEmP8KxupgdkTGiEqF?=
 =?us-ascii?Q?/ycoIN3TH8CGtrC9mZ7ISbvKyV7jAnl2aBzGkNYhA26tCHFkUDuot2ux2LTI?=
 =?us-ascii?Q?ZMfbUG9+DD8mTaWMwaOmnQXnlLMox8ibOATz5QmCWHrWRVdDoMetmFTWzjSY?=
 =?us-ascii?Q?dCC+cX07a6pkJ9nvsZQszDFW4HNdR9xy6/l37Gvg3XUGBWZUDhuqlYSKJE14?=
 =?us-ascii?Q?AroaKRyiLm26Udp5it3DLHR0guil9c1gwlSQQmPHSNDL06IK3PRjf7moldzE?=
 =?us-ascii?Q?qURQhEuY+NKozkyKp+domdHTuQBmVC4SWmqEziV6WEa3QRDbvXZp+VM8JoLj?=
 =?us-ascii?Q?Wba+VelcmUz/jyJmjNKozUch6yRoCm02kzCGptmvQlXFQWy1fAsWM2citIX4?=
 =?us-ascii?Q?W7Xqne+ZLZlYH6CTTw5ynCn2h84j2S4BwV6vzU0nDr21PsO2WptiPCRXHZtM?=
 =?us-ascii?Q?PM/buCHn1ahWq9pZcHUw5cG5Y0mP5suzlLa5x3fbqHj16IaA72lgofCqti1M?=
 =?us-ascii?Q?o+xKfeAOg5SLEuAyW8E2E4/4LBzJwQg5vy/Gke9SxZbIo3jwrNTMI9XA8XIY?=
 =?us-ascii?Q?FlUeWIZfdm8zI2p3jVZHRnGCQSThovssqk5cLi8qNI+3JAwlW6KaqlmkBxqn?=
 =?us-ascii?Q?LtVjlR2CwoWm6IZBJR8PEgR/p3iHriOgAixt+VaMEdGzivtoUWacMdxQqH6R?=
 =?us-ascii?Q?PtbAEzaCv8Zrxjcb1NOnf4voBewGsx69MEhK9l3hXn9WakyPRepZ4WJHyZTf?=
 =?us-ascii?Q?HQa5eCxf6EReEDRSkt7VUAq6rGqqFN0OO6iUGJbuP40EOlOKbaB/E5cn6WGD?=
 =?us-ascii?Q?GghRZO35HG64CBEuVXJfLCK22i7FJ1F0lbrEKUHslj5kFxTgaG4YIb+5SVe5?=
 =?us-ascii?Q?dnYxNiIamrKPBpVP+6hf0/4KMtyfYjO69uFq0pK/VRXYQCwnyQLRH8IR7xMd?=
 =?us-ascii?Q?F/IK9o1uV/rPypD1QgY9VMLJkCetVdO4ltWdpTY3juc82P8Xslka47jY3HUA?=
 =?us-ascii?Q?IYPDv4TNFwgtrhdz+EuV5DHNZivMII4n3/FM6IlZWUT+7icRAxgwEC+M/JUE?=
 =?us-ascii?Q?DST0PAhja+JE6jLNeRfwkdGkSdm65fUBs/Mq9vhdYYsl81xnUvE3d23NR1mG?=
 =?us-ascii?Q?MBcLR7bZAw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e61c3fc-9717-41a4-65c8-08da1652e9c0
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 15:50:59.1957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WJ4KcJMLylbImEH5VriIurdMYjMqFy85zTlPE410O93Q80JTM84MypJ4oSFp2nbyQYaQ76pURAi4cG/6cMs+FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5520

(reducing Cc list some)

On 04.04.2022 16:49, Roger Pau Monn=C3=A9 wrote:
> On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote:
>> GrUB2 can be told to leave the screen in the graphics mode it has been
>> using (or any other one), via "set gfxpayload=3Dkeep" (or suitable
>> variants thereof). In this case we can avoid doing another mode switch
>> ourselves. This in particular avoids possibly setting the screen to a
>> less desirable mode: On one of my test systems the set of modes
>> reported available by the VESA BIOS depends on whether the interposed
>> KVM switch has that machine set as the active one. If it's not active,
>> only modes up to 1024x768 get reported, while when active 1280x1024
>> modes are also included. For things to always work with an explicitly
>> specified mode (via the "vga=3D" option), that mode therefore needs be a
>> 1024x768 one.
>>
>> For some reason this only works for me with "multiboot2" (and
>> "module2"); "multiboot" (and "module") still forces the screen into text
>> mode, despite my reading of the sources suggesting otherwise.
>>
>> For starters I'm limiting this to graphics modes; I do think this ought
>> to also work for text modes, but
>> - I can't tell whether GrUB2 can set any text mode other than 80x25
>>   (I've only found plain "text" to be valid as a "gfxpayload" setting),
>> - I'm uncertain whether supporting that is worth it, since I'm uncertain
>>   how many people would be running their systems/screens in text mode,
>> - I'd like to limit the amount of code added to the realmode trampoline.
>>
>> For starters I'm also limiting mode information retrieval to raw BIOS
>> accesses. This will allow things to work (in principle) also with other
>> boot environments where a graphics mode can be left in place. The
>> downside is that this then still is dependent upon switching back to
>> real mode, so retrieving the needed information from multiboot info is
>> likely going to be desirable down the road.
>=20
> I'm unsure, what's the benefit from retrieving this information from
> the VESA blob rather than from multiboot(2) structures?

As said - it allows things to work even when that data isn't provided.
Note also how I say "for starters" - patch 2 adds logic to retrieve
the information from MB.

> Is it because we require a VESA mode to be set before we parse the
> multiboot information?

No, I don't think so.

>> --- a/xen/arch/x86/boot/video.S
>> +++ b/xen/arch/x86/boot/video.S
>> @@ -575,7 +575,6 @@ set14:  movw    $0x1111, %ax
>>          movb    $0x01, %ah              # Define cursor scan lines 11-1=
2
>>          movw    $0x0b0c, %cx
>>          int     $0x10
>> -set_current:
>>          stc
>>          ret
>> =20
>> @@ -693,6 +692,39 @@ vga_modes:
>>          .word   VIDEO_80x60, 0x50,0x3c,0        # 80x60
>>  vga_modes_end:
>> =20
>> +# If the current mode is a VESA graphics one, obtain its parameters.
>> +set_current:
>> +        leaw    vesa_glob_info, %di
>> +        movw    $0x4f00, %ax
>> +        int     $0x10
>> +        cmpw    $0x004f, %ax
>> +        jne     .Lsetc_done
>=20
> You don't seem to make use of the information fetched here? I guess
> this is somehow required to access the other functions?

See the similar logic at check_vesa. The information is used later, by
mode_params (half way into mopar_gr). Quite likely this could be done
just in a single place, but that would require some restructuring of
the code, which I'd like to avoid doing here.

>> +        movw    $0x4f03, %ax
>=20
> It would help readability to have defines for those values, ie:
> VESA_GET_CURRENT_MODE or some such (not that you need to do it here,
> just a comment).

Right - this applies to all of our BIOS interfacing code, I guess.

>> +        int     $0x10
>> +        cmpw    $0x004f, %ax
>> +        jne     .Lsetc_done
>> +
>> +        leaw    vesa_mode_info, %di     # Get mode information structur=
e
>> +        movw    %bx, %cx
>> +        movw    $0x4f01, %ax
>> +        int     $0x10
>> +        cmpw    $0x004f, %ax
>> +        jne     .Lsetc_done
>> +
>> +        movb    (%di), %al              # Check mode attributes
>> +        andb    $0x9b, %al
>> +        cmpb    $0x9b, %al
>=20
> So you also check that the reserved D1 bit is set to 1 as mandated by
> the spec. This is slightly different than what's done in check_vesa,
> would you mind adding a define for this an unifying with check_vesa?

Well, see the v2 changelog comment. I'm somewhat hesitant to do that
here; I'd prefer to consolidate this in a separate patch.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 16:09:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 16:09:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298437.508409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbPGE-0006g6-Vv; Mon, 04 Apr 2022 16:08:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298437.508409; Mon, 04 Apr 2022 16:08:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbPGE-0006fz-SP; Mon, 04 Apr 2022 16:08:58 +0000
Received: by outflank-mailman (input) for mailman id 298437;
 Mon, 04 Apr 2022 16:08:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DIUK=UO=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nbPGD-0006ft-PW
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 16:08:57 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 860d1298-b431-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 18:08:55 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 16490885294596.815381100868194;
 Mon, 4 Apr 2022 09:08:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 860d1298-b431-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1649088530; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=IqltzyDTMoMCJck8JCdciMNuUM4dWgxr3rD6CjjkbhSv5CLYSj9wjys86bBTfFEYJ/G7O9IrKUe6hzyfoLOk2wg7NQGZSj4VfqW3F6o3hjQWIUgfU8iM31bCRhcTi4UGlqhhC6zv9anh4AIKx2hvZdqjMJdVauJTH3kPkXAdCXA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1649088530; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=wEGmTbZbTeSywAGWzSGIGmVktXD6+SpKk0rLTi/T1DA=; 
	b=bbBb5ckY2JzxSlCpd/8c25Fa+/Dz2GHFEqmm5Tnx09tdrDdHt+fb7xWJPCE+CqXxpAQ3v5AN3GC6dV4NBP5uvtYKXuxZyT9TsU1b0p/+lwxTDXAoVA/mqWX4sgE+1ONx2MB1waJZMudJK6kMA4zqwX8rysgvfAjYtTy+wstP10k=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649088530;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=wEGmTbZbTeSywAGWzSGIGmVktXD6+SpKk0rLTi/T1DA=;
	b=twBZYUAuqM2hrzuiDXeAPNqVBu/jDrIX1qH2eX0E4BDnRWrTKAIBnIvBzBTcFHCD
	XlDjX0DBH92JcfqD/te8BMQSeDC0Ft5ixKCN3v3z532v/FeiL302UqFK/A42jjC8OiX
	O0TDA5gfyt/oq+CVK2vhVERVJYP9ILRvZ8lCsTPU=
Message-ID: <cd178295-4c8b-6710-3050-011fcee378b1@apertussolutions.com>
Date: Mon, 4 Apr 2022 12:08:25 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, scott.davis@starlab.io,
 jandryuk@gmail.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
 <25c10763-36fa-34d4-05b6-655c08fdfee7@apertussolutions.com>
 <YksK9hIbJbOXkIYd@Air-de-Roger>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
In-Reply-To: <YksK9hIbJbOXkIYd@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 4/4/22 11:12, Roger Pau Monné wrote:
> On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote:
>> On 3/31/22 08:36, Roger Pau Monné wrote:
>>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
>>>> There are now instances where internal hypervisor logic needs to make resource
>>>> allocation calls that are protected by XSM checks. The internal hypervisor logic
>>>> is represented a number of system domains which by designed are represented by
>>>> non-privileged struct domain instances. To enable these logic blocks to
>>>> function correctly but in a controlled manner, this commit introduces a pair
>>>> of privilege escalation and demotion functions that will make a system domain
>>>> privileged and then remove that privilege.
>>>>
>>>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>>>> ---
>>>>  xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
>>>
>>> I'm not sure this needs to be in xsm code, AFAICT it could live in a
>>> more generic file.
>>
>> From my perspective this is access control logic, thus why I advocate
>> for it to be under XSM. A personal goal is to try to get all security,
>> i.e. access control, centralized to the extent that it doing so does not
>> make the code base unnecessarily complicated.
> 
> Maybe others have a different opinion, but IMO setting is_privileged
> is not XSM specific. It happens to solve an XSM issue, but that's no
> reason to place it in the xsm code base.

I think this deserves a separate more dedicated thread as I would take
the position that Xen privilege model is at best fractured because
is_control_domain() (and underlying is_privileged),
is_hardware_domain,() and is_xenstore_domain() are used independent of
XSM. Perhaps the discussion can be had when I get back to the XSM Roles
patches to enable disaggregating Xen with hyperlaunch (or at a Xen
Summit design session).

>>>>  1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>>>> index e22d6160b5..157e57151e 100644
>>>> --- a/xen/include/xsm/xsm.h
>>>> +++ b/xen/include/xsm/xsm.h
>>>> @@ -189,6 +189,28 @@ struct xsm_operations {
>>>>  #endif
>>>>  };
>>>>  
>>>> +static always_inline int xsm_elevate_priv(struct domain *d)
>>>
>>> I don't think it needs to be always_inline, using just inline would be
>>> fine IMO.
>>>
>>> Also this needs to be __init.
>>
>> AIUI always_inline is likely the best way to preserve the speculation
>> safety brought in by the call to is_system_domain().
> 
> There's nothing related to speculation safety in is_system_domain()
> AFAICT. It's just a plain check against d->domain_id. It's my
> understanding there's no need for any speculation barrier there
> because d->domain_id is not an external input.

Hmmm, this actually raises a good question. Why is is_control_domain(),
is_hardware_domain, and others all have evaluate_nospec() wrapping the
check of a struct domain element while is_system_domain() does not?

> In any case this function should be __init only, at which point there
> are no untrusted inputs to Xen.

I thought it was agreed that __init on inline functions in headers had
no meaning?


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 17:00:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 17:00:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298441.508420 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbQ4I-00046t-UI; Mon, 04 Apr 2022 17:00:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298441.508420; Mon, 04 Apr 2022 17:00:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbQ4I-00046m-R2; Mon, 04 Apr 2022 17:00:42 +0000
Received: by outflank-mailman (input) for mailman id 298441;
 Mon, 04 Apr 2022 17:00:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HwVa=UO=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1nbQ4H-00046Z-CE
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 17:00:41 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-cusazlp170110003.outbound.protection.outlook.com
 [2a01:111:f403:c111::3])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c01df285-b438-11ec-a405-831a346695d4;
 Mon, 04 Apr 2022 19:00:39 +0200 (CEST)
Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21)
 by SA0PR21MB1881.namprd21.prod.outlook.com (2603:10b6:806:e6::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.2; Mon, 4 Apr
 2022 17:00:34 +0000
Received: from PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::e516:76e:5421:5b22]) by PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::e516:76e:5421:5b22%5]) with mapi id 15.20.5144.011; Mon, 4 Apr 2022
 17:00:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c01df285-b438-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TACXj0m5hlmQg63whxFwyL+531Il1rQSzay6Lg3zbQ793OSXDONDtIcP3yxKCeOLzNq+a9nKCfS9oGNhGHTdQOZFhLr0KmLkUNGu1Uv9G4mGtsChcsixeehYuPXpDPcN6geLHzVOd7PNYcVQHqYn5a1oDjOZdIs3/5uGOY/L//It7L+pBhSzgOHw/Uqu93QEDFMdQDTi7n63kE3QHv2FtOxH6qvcl7vDmpOC1fRWEPK0A5Itp/Jhic1b0LOXv+ekzPO4ny5Qm8fvwvQ1cc2WSUQpmUGYnfbw9Jz4xvUncA8cS/PVNCoA6HzlqD/hny61mT3WcKWWTBkvO3+mYshGWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LwWuMUnDqeO5LcJCMJgId+ohHq7d05qbPMrinxsEVd4=;
 b=g98GTQnZ0+iEKqpX4LwakFK0l6OOYr09Og7Zm7ASbL/gvuUrGd69foMk91LSmc1oNRllnfGUzcvPKBHachYxEyQrllIuJDwI25Bbzm6Pw2qdc+1VEw8oK+Y16ohuPVQKhflKlHeaDuOaukA1tkkrAiyZXIE153oQ1TnG3veDVNGzRcAaXprJdkYo/0u3cICDWfqoIkhoYORcnJ+a8vk/Dp02VU3mUOfk27bpwZnYYiLr7sBJmOIDoxX8UDAMCZxRcPuyCPPDXRHX5z5lIP91b9es/N82pcxWD3Xxux5eQALby9BCErhXg0DNrVdkSpm/YzWOmYLZGUE9ZRSqqCBRYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LwWuMUnDqeO5LcJCMJgId+ohHq7d05qbPMrinxsEVd4=;
 b=DW0RX7WdAbBMowT/ezuRthE5lySFbX1fxtjO+bW2AHly9LSwHQ+FR+JEX4AJuQO9qIbIjZp2v8nc+GT2pM1++nwECkOhYDNpoKMgcSXHaZvt1/K3OlXgiyExeHvg/HhQoRa2cbxt51yuwzTxd9A/cm0+3deTV7+J77fk20XcsEI=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: Christoph Hellwig <hch@lst.de>, "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
CC: "x86@kernel.org" <x86@kernel.org>, Anshuman Khandual
	<anshuman.khandual@arm.com>, Tom Lendacky <thomas.lendacky@amd.com>, Konrad
 Rzeszutek Wilk <konrad.wilk@oracle.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>, David
 Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>, Robin
 Murphy <robin.murphy@arm.com>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-ia64@vger.kernel.org"
	<linux-ia64@vger.kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "tboot-devel@lists.sourceforge.net"
	<tboot-devel@lists.sourceforge.net>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>
Subject: RE: [PATCH 09/15] swiotlb: make the swiotlb_init interface more
 useful
Thread-Topic: [PATCH 09/15] swiotlb: make the swiotlb_init interface more
 useful
Thread-Index: AQHYR+HYUbt0/GHOLkW0vuXDGPTqsKzf+nXQ
Date: Mon, 4 Apr 2022 17:00:34 +0000
Message-ID:
 <PH0PR21MB3025EED7E82FCD8595D82540D7E59@PH0PR21MB3025.namprd21.prod.outlook.com>
References: <20220404050559.132378-1-hch@lst.de>
 <20220404050559.132378-10-hch@lst.de>
In-Reply-To: <20220404050559.132378-10-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=e3951091-16ea-4d78-8883-633f622913fb;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-04-04T16:57:47Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f0587c4a-b78c-488f-e1c2-08da165ca264
x-ms-traffictypediagnostic: SA0PR21MB1881:EE_
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
 <SA0PR21MB1881564FA196CBC2EE6D4CB0D7E59@SA0PR21MB1881.namprd21.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 ZaeLbJqs81svlLk+SlzjXdK7N2xVa7rka5ocDDrJe7kYTlmEWQqOr77Y02NWVd6f4KSqvGEPZjh+AmKuA0l7K7ojZUO1ujvYu0k8Nwk9Wy065JNPaW/NzkP3Ngm+NQdZl/CjUL/PjbkZZZ+72dZU/vKVvHONW5BHUrl4Zhgzp2qjZt+hsmysFmAfUUWAvi7OONsRTHdUplzvrj+yH8KGZwKCvNYoj7WcA6TW2CTf4113p9U+O7G7ReFmEN+GATkvqLiwjNJV9Elpu4lVuuIh7FG7rqfbHilExATXSNIUChS4146eWKnVfjJLcNklN0BfSdIZ6hPZObDWNOAA/RpmiZUcq+R4artc4lpJmfBl9CTeY7VkJeWYpW4ogBSadjp54jWFa2P0WQ7XsqxbKAWczvO8J/r5nV6wXIrRQFrGluPshTMfkO1yNXiXF3WkM/K5HiRMIEvDuMzWmw+6brTkjEp5nqvRhSWusBpGMzFeoAQIEfIJUA3L7ocLltefNjErIUqCzyTkCUFoAY2UZiVHC2t3KLWKH9qkZENQRBsn3BCWhzXMWQfDu9ut+wKT4yY3n98yu56vkJLJ1roaR/3dwY9gju3iGLAESd7wBmC5r6oH2d6GMgdsrI+0WSddwtcv5SiGqKNFuwxDffVPPXNATfxQQ0aqtVsglftTipfX+zbel0uCBZXLuNGuqkuK13RpZVVsqbL7cw5Kh0XiTBuRMqBPe6MTOQFfzT9iIasd/vt+HoI3Dnywo2GFpT+dvKwr
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(54906003)(7696005)(10290500003)(38100700002)(2906002)(6506007)(83380400001)(8990500004)(110136005)(38070700005)(86362001)(55016003)(26005)(186003)(5660300002)(9686003)(66946007)(64756008)(66446008)(52536014)(82960400001)(82950400001)(7416002)(8936002)(71200400001)(4326008)(316002)(66556008)(66476007)(8676002)(30864003)(76116006)(122000001)(508600001)(33656002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?+wiONLzmu/b4DtrUgGfyKUS9rf6Ok+jmTeOrdw4Y9aWQ1QWdS8RDUXqgt2NO?=
 =?us-ascii?Q?6RChP/etz+tW4uco3CM4EdCb5Jh1F/VM/nW0IIm++P0jlcwlL4KBxdOeBTvG?=
 =?us-ascii?Q?hzK5FFbmUa6AjxN34Izya3qjZ9BKPBogUcVV8/u6RL+IDA7Ouvhalq6Yg4hF?=
 =?us-ascii?Q?s1VQ1DPbtjBP6WlRoeckQdR413O4x7c0FeOyYZwhNEWSGOb3Pt0SNLo1BYTj?=
 =?us-ascii?Q?hZHZIOx7LAGje+3gemGY9xpj6DhjsvAD4oq16NGQVS0In+rV3qpyC6J8jS/A?=
 =?us-ascii?Q?Sp5I2hL+SLbQsOTJ0KiXebpEA/RYusPfKj3VjlIRc5Hvb66OTqiX392rQBGL?=
 =?us-ascii?Q?pbRqSUGDegGez0JPiaUtkGwKLU8OdJTeiRVljzCBE4e363nc9oyh6RNYDI8z?=
 =?us-ascii?Q?22HxXyRM6yFGhBCTsxj3QQPWp0kSilO5VcwbSjnbtOkmb7teU2XTPxNCiz2G?=
 =?us-ascii?Q?bz9l7WHYjO9CgOZ119O/HHPlUCevrD/tZgG0W7WaAvS5QKUtSVdcPMcskIVX?=
 =?us-ascii?Q?TDXdaugh00DSLOQSSB1MwvLAJL4vR1bw3u/5Yj1MdLfC1h538Um7blHWh9C9?=
 =?us-ascii?Q?O0i9hhVoZwkfbd+JzA7RG3bTCpHlsXvI48YE5gtBvz98/h1Fsmx60yHRbvjg?=
 =?us-ascii?Q?j2CXWPgiEZOGHMjQ8v5Kmnr/yrtOftnZ5bUr71EdjEQzYW+gXW/ocL1rdQbY?=
 =?us-ascii?Q?Yq4u4Xd11ocY5OUVat1IUO02aKeKif77CUUEzssbmc8VISRg0QcnrcU2a6u3?=
 =?us-ascii?Q?BbMRbBegAmFt7umIB1EoMKtYbBtFwjKKvcHhtc3vDxFa+CD11nPQy4w/dVlQ?=
 =?us-ascii?Q?DgrOkmjafrm2Eavxby7gMTbaN0CH70G1zq7138FJIxg9rESmDA1rXQr27bvL?=
 =?us-ascii?Q?T7hxoChQij7HGGEnHqOdI8wU8ccYC4IYp5b5TV2ss/6UhBYCvMNUHz8N9C0I?=
 =?us-ascii?Q?JXsC08yWJ+ratznHhqIjFIJjUnHWyoWzcmRueJnx6vPIGUZjhqhGKLBl6kA6?=
 =?us-ascii?Q?jH7HECVOygO2pk8eP99metWf4cCeL/h7AfXePjtml++bOtpystg1+KbVy0H8?=
 =?us-ascii?Q?XxTFK81uOQrWnCED9EZDlk/ZGocqsIc04rZyN4z7KpBb8N76udfU+CTfmF4b?=
 =?us-ascii?Q?2kCaime8tRk/swF1jB53NJ6ez3b38uY4mWcvUwr/pKrElN5Y6a2i7g4RdgHd?=
 =?us-ascii?Q?DX+ii7nDbiea7eDutJaf1JkEc27D4+EnP7vfBUvhtrYiYgv2ipx/ZfsMmVG2?=
 =?us-ascii?Q?Rs7gYKc7dOI+NSKTA1E/3yR1kkMKaqlcSFMmVoGFnwU1wQb2vl25th8Lt14v?=
 =?us-ascii?Q?APnKMVQ2PTZiEATHkfdtL9ViMXqTdFRWOc8npwny94btoEBL836OUrLJYyMZ?=
 =?us-ascii?Q?zVupnUUaQj4zy3P9Mip7dbHFDWAmzQP12NUoy3mj1GTt9vlKjba9vPfMIzzl?=
 =?us-ascii?Q?ZgUWsWtsKkZi/UYm54ky3kGcKXZDNM0bV6w9MSyx/1U0GMF9juzTjlIlm2p0?=
 =?us-ascii?Q?aulKnI8VGHtCiHWQ7ceMlYAUN2F2VY5GHDTE8zkeQVGT3hkr0Xb2drM8o+53?=
 =?us-ascii?Q?AZLLXVDFeOimziMU++B018eU0i0+NYPYK4ODz0CO6PiS2L6TZJQ+OkxxzUTO?=
 =?us-ascii?Q?j5VGjXik4oqhh8Y8topFs2KSo8bAYUhcCxCESmb4cxAOMYXh0wUFM83k0QUa?=
 =?us-ascii?Q?niA7L0p8gL3ZKD2VceZHD9JlPB69PNigh/aUrKAZAPwz1PrROeUPr//KC+nY?=
 =?us-ascii?Q?PH+vuAetdEv3PjoCRv66yZXIjt/uDFk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0587c4a-b78c-488f-e1c2-08da165ca264
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2022 17:00:34.0892
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IZAEkQFQsq5F0lsmoSa6iO94AzGRANX+uCVWnkau3YyCHVWt/RxSfMF+G5QUjGXqlJ+zNi4C/JRH/ac02l43Z+Hf9OyTroP8i5QaFk/7fCY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1881

From: Christoph Hellwig <hch@lst.de> Sent: Sunday, April 3, 2022 10:06 PM
>=20
> Pass a bool to pass if swiotlb needs to be enabled based on the

Wording problems.  I'm not sure what you meant to say.

> addressing needs and replace the verbose argument with a set of
> flags, including one to force enable bounce buffering.
>=20
> Note that this patch removes the possibility to force xen-swiotlb
> use using swiotlb=3Dforce on the command line on x86 (arm and arm64
> never supported that), but this interface will be restored shortly.
>=20
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/arm/mm/init.c                     |  6 +----
>  arch/arm64/mm/init.c                   |  6 +----
>  arch/ia64/mm/init.c                    |  4 +--
>  arch/mips/cavium-octeon/dma-octeon.c   |  2 +-
>  arch/mips/loongson64/dma.c             |  2 +-
>  arch/mips/sibyte/common/dma.c          |  2 +-
>  arch/powerpc/mm/mem.c                  |  3 ++-
>  arch/powerpc/platforms/pseries/setup.c |  3 ---
>  arch/riscv/mm/init.c                   |  8 +-----
>  arch/s390/mm/init.c                    |  3 +--
>  arch/x86/kernel/pci-dma.c              | 15 ++++++-----
>  drivers/xen/swiotlb-xen.c              |  4 +--
>  include/linux/swiotlb.h                | 15 ++++++-----
>  include/trace/events/swiotlb.h         | 29 ++++++++-------------
>  kernel/dma/swiotlb.c                   | 35 ++++++++++++++------------
>  15 files changed, 55 insertions(+), 82 deletions(-)
>=20
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index fe249ea919083..ce64bdb55a16b 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -271,11 +271,7 @@ static void __init free_highpages(void)
>  void __init mem_init(void)
>  {
>  #ifdef CONFIG_ARM_LPAE
> -	if (swiotlb_force =3D=3D SWIOTLB_FORCE ||
> -	    max_pfn > arm_dma_pfn_limit)
> -		swiotlb_init(1);
> -	else
> -		swiotlb_force =3D SWIOTLB_NO_FORCE;
> +	swiotlb_init(max_pfn > arm_dma_pfn_limit, SWIOTLB_VERBOSE);
>  #endif
>=20
>  	set_max_mapnr(pfn_to_page(max_pfn) - mem_map);
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 8ac25f19084e8..7b6ea4d6733d6 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -398,11 +398,7 @@ void __init bootmem_init(void)
>   */
>  void __init mem_init(void)
>  {
> -	if (swiotlb_force =3D=3D SWIOTLB_FORCE ||
> -	    max_pfn > PFN_DOWN(arm64_dma_phys_limit))
> -		swiotlb_init(1);
> -	else if (!xen_swiotlb_detect())
> -		swiotlb_force =3D SWIOTLB_NO_FORCE;
> +	swiotlb_init(max_pfn > PFN_DOWN(arm64_dma_phys_limit),
> SWIOTLB_VERBOSE);
>=20
>  	/* this will put all unused low memory onto the freelists */
>  	memblock_free_all();
> diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c
> index 5d165607bf354..3c3e15b22608f 100644
> --- a/arch/ia64/mm/init.c
> +++ b/arch/ia64/mm/init.c
> @@ -437,9 +437,7 @@ mem_init (void)
>  		if (iommu_detected)
>  			break;
>  #endif
> -#ifdef CONFIG_SWIOTLB
> -		swiotlb_init(1);
> -#endif
> +		swiotlb_init(true, SWIOTLB_VERBOSE);
>  	} while (0);
>=20
>  #ifdef CONFIG_FLATMEM
> diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octe=
on/dma-
> octeon.c
> index fb7547e217263..9fbba6a8fa4c5 100644
> --- a/arch/mips/cavium-octeon/dma-octeon.c
> +++ b/arch/mips/cavium-octeon/dma-octeon.c
> @@ -235,5 +235,5 @@ void __init plat_swiotlb_setup(void)
>  #endif
>=20
>  	swiotlb_adjust_size(swiotlbsize);
> -	swiotlb_init(1);
> +	swiotlb_init(true, SWIOTLB_VERBOSE);
>  }
> diff --git a/arch/mips/loongson64/dma.c b/arch/mips/loongson64/dma.c
> index 364f2f27c8723..8220a1bc0db64 100644
> --- a/arch/mips/loongson64/dma.c
> +++ b/arch/mips/loongson64/dma.c
> @@ -24,5 +24,5 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t
> daddr)
>=20
>  void __init plat_swiotlb_setup(void)
>  {
> -	swiotlb_init(1);
> +	swiotlb_init(true, SWIOTLB_VERBOSE);
>  }
> diff --git a/arch/mips/sibyte/common/dma.c b/arch/mips/sibyte/common/dma.=
c
> index eb47a94f3583e..c5c2c782aff68 100644
> --- a/arch/mips/sibyte/common/dma.c
> +++ b/arch/mips/sibyte/common/dma.c
> @@ -10,5 +10,5 @@
>=20
>  void __init plat_swiotlb_setup(void)
>  {
> -	swiotlb_init(1);
> +	swiotlb_init(true, SWIOTLB_VERBOSE);
>  }
> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> index 8e301cd8925b2..e1519e2edc656 100644
> --- a/arch/powerpc/mm/mem.c
> +++ b/arch/powerpc/mm/mem.c
> @@ -17,6 +17,7 @@
>  #include <linux/suspend.h>
>  #include <linux/dma-direct.h>
>=20
> +#include <asm/swiotlb.h>
>  #include <asm/machdep.h>
>  #include <asm/rtas.h>
>  #include <asm/kasan.h>
> @@ -251,7 +252,7 @@ void __init mem_init(void)
>  	if (is_secure_guest())
>  		svm_swiotlb_init();
>  	else
> -		swiotlb_init(0);
> +		swiotlb_init(ppc_swiotlb_enable, 0);
>  #endif
>=20
>  	high_memory =3D (void *) __va(max_low_pfn * PAGE_SIZE);
> diff --git a/arch/powerpc/platforms/pseries/setup.c
> b/arch/powerpc/platforms/pseries/setup.c
> index 069d7b3bb142e..c6e06d91b6602 100644
> --- a/arch/powerpc/platforms/pseries/setup.c
> +++ b/arch/powerpc/platforms/pseries/setup.c
> @@ -838,9 +838,6 @@ static void __init pSeries_setup_arch(void)
>  	}
>=20
>  	ppc_md.pcibios_root_bridge_prepare =3D pseries_root_bridge_prepare;
> -
> -	if (swiotlb_force =3D=3D SWIOTLB_FORCE)
> -		ppc_swiotlb_enable =3D 1;
>  }
>=20
>  static void pseries_panic(char *str)
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 9535bea8688c0..181ffd322eafa 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -120,13 +120,7 @@ void __init mem_init(void)
>  	BUG_ON(!mem_map);
>  #endif /* CONFIG_FLATMEM */
>=20
> -#ifdef CONFIG_SWIOTLB
> -	if (swiotlb_force =3D=3D SWIOTLB_FORCE ||
> -	    max_pfn > PFN_DOWN(dma32_phys_limit))
> -		swiotlb_init(1);
> -	else
> -		swiotlb_force =3D SWIOTLB_NO_FORCE;
> -#endif
> +	swiotlb_init(max_pfn > PFN_DOWN(dma32_phys_limit), SWIOTLB_VERBOSE);
>  	memblock_free_all();
>=20
>  	print_vm_layout();
> diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
> index 86ffd0d51fd59..6fb6bf64326f9 100644
> --- a/arch/s390/mm/init.c
> +++ b/arch/s390/mm/init.c
> @@ -185,8 +185,7 @@ static void pv_init(void)
>  		return;
>=20
>  	/* make sure bounce buffers are shared */
> -	swiotlb_force =3D SWIOTLB_FORCE;
> -	swiotlb_init(1);
> +	swiotlb_init(true, SWIOTLB_FORCE | SWIOTLB_VERBOSE);
>  	swiotlb_update_mem_attributes();
>  }
>=20
> diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
> index 04140e20ef1a3..a705a199bf8a3 100644
> --- a/arch/x86/kernel/pci-dma.c
> +++ b/arch/x86/kernel/pci-dma.c
> @@ -39,6 +39,7 @@ int iommu_detected __read_mostly =3D 0;
>=20
>  #ifdef CONFIG_SWIOTLB
>  bool x86_swiotlb_enable;
> +static unsigned int x86_swiotlb_flags;
>=20
>  static void __init pci_swiotlb_detect(void)
>  {
> @@ -58,16 +59,16 @@ static void __init pci_swiotlb_detect(void)
>  	 * bounce buffers as the hypervisor can't access arbitrary VM memory
>  	 * that is not explicitly shared with it.
>  	 */
> -	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
> -		swiotlb_force =3D SWIOTLB_FORCE;
> -
> -	if (swiotlb_force =3D=3D SWIOTLB_FORCE)
> +	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) {
>  		x86_swiotlb_enable =3D true;
> +		x86_swiotlb_flags |=3D SWIOTLB_FORCE;
> +	}
>  }
>  #else
>  static inline void __init pci_swiotlb_detect(void)
>  {
>  }
> +#define x86_swiotlb_flags 0
>  #endif /* CONFIG_SWIOTLB */
>=20
>  #ifdef CONFIG_SWIOTLB_XEN
> @@ -75,8 +76,7 @@ static bool xen_swiotlb;
>=20
>  static void __init pci_xen_swiotlb_init(void)
>  {
> -	if (!xen_initial_domain() && !x86_swiotlb_enable &&
> -	    swiotlb_force !=3D SWIOTLB_FORCE)
> +	if (!xen_initial_domain() && !x86_swiotlb_enable)
>  		return;
>  	x86_swiotlb_enable =3D true;
>  	xen_swiotlb =3D true;
> @@ -120,8 +120,7 @@ void __init pci_iommu_alloc(void)
>  	gart_iommu_hole_init();
>  	amd_iommu_detect();
>  	detect_intel_iommu();
> -	if (x86_swiotlb_enable)
> -		swiotlb_init(0);
> +	swiotlb_init(x86_swiotlb_enable, x86_swiotlb_flags);
>  }
>=20
>  /*
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 485cd06ed39e7..c2da3eb4826e8 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -251,7 +251,7 @@ void __init xen_swiotlb_init_early(void)
>  		panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
>  	}
>=20
> -	if (swiotlb_init_with_tbl(start, nslabs, true))
> +	if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE))
>  		panic("Cannot allocate SWIOTLB buffer");
>  }
>  #endif /* CONFIG_X86 */
> @@ -376,7 +376,7 @@ static dma_addr_t xen_swiotlb_map_page(struct device =
*dev,
> struct page *page,
>  	/*
>  	 * Oh well, have to allocate and map a bounce buffer.
>  	 */
> -	trace_swiotlb_bounced(dev, dev_addr, size, swiotlb_force);
> +	trace_swiotlb_bounced(dev, dev_addr, size);
>=20
>  	map =3D swiotlb_tbl_map_single(dev, phys, size, size, 0, dir, attrs);
>  	if (map =3D=3D (phys_addr_t)DMA_MAPPING_ERROR)
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index b48b26bfa0edb..ae0407173e845 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -13,11 +13,8 @@ struct device;
>  struct page;
>  struct scatterlist;
>=20
> -enum swiotlb_force {
> -	SWIOTLB_NORMAL,		/* Default - depending on HW DMA mask etc.
> */
> -	SWIOTLB_FORCE,		/* swiotlb=3Dforce */
> -	SWIOTLB_NO_FORCE,	/* swiotlb=3Dnoforce */
> -};
> +#define SWIOTLB_VERBOSE	(1 << 0) /* verbose initialization */
> +#define SWIOTLB_FORCE	(1 << 1) /* force bounce buffering */
>=20
>  /*
>   * Maximum allowable number of contiguous slabs to map,
> @@ -36,8 +33,7 @@ enum swiotlb_force {
>  /* default to 64MB */
>  #define IO_TLB_DEFAULT_SIZE (64UL<<20)
>=20
> -extern void swiotlb_init(int verbose);
> -int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
> +int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int =
flags);
>  unsigned long swiotlb_size_or_default(void);
>  extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
>  int swiotlb_init_late(size_t size);
> @@ -126,13 +122,16 @@ static inline bool is_swiotlb_force_bounce(struct d=
evice
> *dev)
>  	return mem && mem->force_bounce;
>  }
>=20
> +void swiotlb_init(bool addressing_limited, unsigned int flags);
>  void __init swiotlb_exit(void);
>  unsigned int swiotlb_max_segment(void);
>  size_t swiotlb_max_mapping_size(struct device *dev);
>  bool is_swiotlb_active(struct device *dev);
>  void __init swiotlb_adjust_size(unsigned long size);
>  #else
> -#define swiotlb_force SWIOTLB_NO_FORCE
> +static inline void swiotlb_init(bool addressing_limited, unsigned int fl=
ags)
> +{
> +}
>  static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t pad=
dr)
>  {
>  	return false;
> diff --git a/include/trace/events/swiotlb.h b/include/trace/events/swiotl=
b.h
> index 705be43b71ab0..da05c9ebd224a 100644
> --- a/include/trace/events/swiotlb.h
> +++ b/include/trace/events/swiotlb.h
> @@ -8,20 +8,15 @@
>  #include <linux/tracepoint.h>
>=20
>  TRACE_EVENT(swiotlb_bounced,
> -
> -	TP_PROTO(struct device *dev,
> -		 dma_addr_t dev_addr,
> -		 size_t size,
> -		 enum swiotlb_force swiotlb_force),
> -
> -	TP_ARGS(dev, dev_addr, size, swiotlb_force),
> +	TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size),
> +	TP_ARGS(dev, dev_addr, size),
>=20
>  	TP_STRUCT__entry(
> -		__string(	dev_name,	dev_name(dev)		)
> -		__field(	u64,	dma_mask			)
> -		__field(	dma_addr_t,	dev_addr		)
> -		__field(	size_t,	size				)
> -		__field(	enum swiotlb_force,	swiotlb_force	)
> +		__string(dev_name, dev_name(dev))
> +		__field(u64, dma_mask)
> +		__field(dma_addr_t, dev_addr)
> +		__field(size_t, size)
> +		__field(bool, force)
>  	),
>=20
>  	TP_fast_assign(
> @@ -29,19 +24,15 @@ TRACE_EVENT(swiotlb_bounced,
>  		__entry->dma_mask =3D (dev->dma_mask ? *dev->dma_mask : 0);
>  		__entry->dev_addr =3D dev_addr;
>  		__entry->size =3D size;
> -		__entry->swiotlb_force =3D swiotlb_force;
> +		__entry->force =3D is_swiotlb_force_bounce(dev);
>  	),
>=20
> -	TP_printk("dev_name: %s dma_mask=3D%llx dev_addr=3D%llx "
> -		"size=3D%zu %s",
> +	TP_printk("dev_name: %s dma_mask=3D%llx dev_addr=3D%llx size=3D%zu %s",
>  		__get_str(dev_name),
>  		__entry->dma_mask,
>  		(unsigned long long)__entry->dev_addr,
>  		__entry->size,
> -		__print_symbolic(__entry->swiotlb_force,
> -			{ SWIOTLB_NORMAL,	"NORMAL" },
> -			{ SWIOTLB_FORCE,	"FORCE" },
> -			{ SWIOTLB_NO_FORCE,	"NO_FORCE" }))
> +		__entry->force ? "FORCE" : "NORMAL")
>  );
>=20
>  #endif /*  _TRACE_SWIOTLB_H */
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 9a4fe6e48a074..86e877a96b828 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -62,7 +62,8 @@
>=20
>  #define INVALID_PHYS_ADDR (~(phys_addr_t)0)
>=20
> -enum swiotlb_force swiotlb_force;
> +static bool swiotlb_force_bounce;
> +static bool swiotlb_force_disable;
>=20
>  struct io_tlb_mem io_tlb_default_mem;
>=20
> @@ -81,9 +82,9 @@ setup_io_tlb_npages(char *str)
>  	if (*str =3D=3D ',')
>  		++str;
>  	if (!strcmp(str, "force"))
> -		swiotlb_force =3D SWIOTLB_FORCE;
> +		swiotlb_force_bounce =3D true;
>  	else if (!strcmp(str, "noforce"))
> -		swiotlb_force =3D SWIOTLB_NO_FORCE;
> +		swiotlb_force_disable =3D true;
>=20
>  	return 0;
>  }
> @@ -202,7 +203,7 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem=
 *mem,
> phys_addr_t start,
>  	mem->index =3D 0;
>  	mem->late_alloc =3D late_alloc;
>=20
> -	if (swiotlb_force =3D=3D SWIOTLB_FORCE)
> +	if (swiotlb_force_bounce)
>  		mem->force_bounce =3D true;
>=20
>  	spin_lock_init(&mem->lock);
> @@ -224,12 +225,13 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_m=
em
> *mem, phys_addr_t start,
>  	return;
>  }
>=20
> -int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int ve=
rbose)
> +int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
> +		unsigned int flags)
>  {
>  	struct io_tlb_mem *mem =3D &io_tlb_default_mem;
>  	size_t alloc_size;
>=20
> -	if (swiotlb_force =3D=3D SWIOTLB_NO_FORCE)
> +	if (swiotlb_force_disable)
>  		return 0;
>=20
>  	/* protect against double initialization */
> @@ -243,8 +245,9 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned =
long nslabs,
> int verbose)
>  		      __func__, alloc_size, PAGE_SIZE);
>=20
>  	swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
> +	mem->force_bounce =3D flags & SWIOTLB_FORCE;
>=20
> -	if (verbose)
> +	if (flags & SWIOTLB_VERBOSE)
>  		swiotlb_print_info();
>  	return 0;
>  }
> @@ -253,20 +256,21 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigne=
d long
> nslabs, int verbose)
>   * Statically reserve bounce buffer space and initialize bounce buffer d=
ata
>   * structures for the software IO TLB used to implement the DMA API.
>   */
> -void  __init
> -swiotlb_init(int verbose)
> +void __init swiotlb_init(bool addressing_limit, unsigned int flags)
>  {
>  	size_t bytes =3D PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
>  	void *tlb;
>=20
> -	if (swiotlb_force =3D=3D SWIOTLB_NO_FORCE)
> +	if (!addressing_limit && !swiotlb_force_bounce)
> +		return;
> +	if (swiotlb_force_disable)
>  		return;
>=20
>  	/* Get IO TLB memory from the low pages */
>  	tlb =3D memblock_alloc_low(bytes, PAGE_SIZE);
>  	if (!tlb)
>  		goto fail;
> -	if (swiotlb_init_with_tbl(tlb, default_nslabs, verbose))
> +	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
>  		goto fail_free_mem;
>  	return;
>=20
> @@ -289,7 +293,7 @@ int swiotlb_init_late(size_t size)
>  	unsigned int order;
>  	int rc =3D 0;
>=20
> -	if (swiotlb_force =3D=3D SWIOTLB_NO_FORCE)
> +	if (swiotlb_force_disable)
>  		return 0;
>=20
>  	/*
> @@ -328,7 +332,7 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long n=
slabs)
>  	struct io_tlb_mem *mem =3D &io_tlb_default_mem;
>  	unsigned long bytes =3D nslabs << IO_TLB_SHIFT;
>=20
> -	if (swiotlb_force =3D=3D SWIOTLB_NO_FORCE)
> +	if (swiotlb_force_disable)
>  		return 0;
>=20
>  	/* protect against double initialization */
> @@ -353,7 +357,7 @@ void __init swiotlb_exit(void)
>  	unsigned long tbl_vaddr;
>  	size_t tbl_size, slots_size;
>=20
> -	if (swiotlb_force =3D=3D SWIOTLB_FORCE)
> +	if (swiotlb_force_bounce)
>  		return;
>=20
>  	if (!mem->nslabs)
> @@ -704,8 +708,7 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_=
t
> paddr, size_t size,
>  	phys_addr_t swiotlb_addr;
>  	dma_addr_t dma_addr;
>=20
> -	trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size,
> -			      swiotlb_force);
> +	trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size);
>=20
>  	swiotlb_addr =3D swiotlb_tbl_map_single(dev, paddr, size, size, 0, dir,
>  			attrs);
> --
> 2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 17:11:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 17:11:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298446.508431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbQEZ-0005en-0q; Mon, 04 Apr 2022 17:11:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298446.508431; Mon, 04 Apr 2022 17:11:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbQEY-0005eg-UD; Mon, 04 Apr 2022 17:11:18 +0000
Received: by outflank-mailman (input) for mailman id 298446;
 Mon, 04 Apr 2022 17:11:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbQEX-0005eW-1d; Mon, 04 Apr 2022 17:11:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbQEW-00033x-VR; Mon, 04 Apr 2022 17:11:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbQEW-0002ex-Gx; Mon, 04 Apr 2022 17:11:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbQEW-0006jR-GW; Mon, 04 Apr 2022 17:11:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=weVGttJx6ewc85ZTtp1JlXLWKfv7XzT9+rckAIx/YNc=; b=IU56If+DuwnlWUE4jNeImZaJUb
	wR34S7CPVGPvT33YHQwu88zxM3LVrytWMZvSiAWMPKhYy8OqbZmmiDQhr5gUQPBmEzR8cvsHo8WsU
	bM1ziGRhUCp7sFU2wqwfDeL7D840TwwuoLZusCAcwRVeFRP4hsDzZ6AxhBZHD6bsxVI0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169160-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169160: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
X-Osstest-Versions-That:
    xen=d62a34423a1a98aefd7c30e22d2d82d198f077c8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 17:11:16 +0000

flight 169160 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169160/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
baseline version:
 xen                  d62a34423a1a98aefd7c30e22d2d82d198f077c8

Last test of basis   169114  2022-04-01 17:01:54 Z    3 days
Testing same since   169160  2022-04-04 12:03:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d62a34423a..e270af9428  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 18:28:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 18:28:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298456.508441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbRQs-0004OS-PV; Mon, 04 Apr 2022 18:28:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298456.508441; Mon, 04 Apr 2022 18:28:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbRQs-0004OL-Me; Mon, 04 Apr 2022 18:28:06 +0000
Received: by outflank-mailman (input) for mailman id 298456;
 Mon, 04 Apr 2022 18:28:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbRQr-0004OB-FK; Mon, 04 Apr 2022 18:28:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbRQr-0004NP-Cc; Mon, 04 Apr 2022 18:28:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbRQr-0000fd-2K; Mon, 04 Apr 2022 18:28:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbRQr-0006Dw-13; Mon, 04 Apr 2022 18:28:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9JPSUvta9y5NLhtMagHLI95nNKO9GbvSfqKdSbnxA1A=; b=tMBW01gwT65x/eiRamYKXO1Tun
	HCr26U6bjEpPsntggQijHIjQySQaAqstRBprh+oRyhJR5rCvTNuLsI6Kg29H+CAWCAnUKPx9dkFBM
	5xyXbxs9+4jUWL+h91QXpwXbmwROq67JW/O0KgAFgdZMBmcHztfUMaMsEQZA6ZpxW5L4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169157-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169157: regressions - FAIL
X-Osstest-Failures:
    linux-linus:build-arm64-pvops:kernel-build:fail:regression
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3123109284176b1532874591f7c81f3837bbdc17
X-Osstest-Versions-That:
    linux=09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 18:28:05 +0000

flight 169157 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169157/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-pvops             6 kernel-build             fail REGR. vs. 169145

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 169145
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169145
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169145
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169145
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169145
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169145
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169145
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169145
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3123109284176b1532874591f7c81f3837bbdc17
baseline version:
 linux                09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04

Last test of basis   169145  2022-04-03 20:41:35 Z    0 days
Testing same since   169157  2022-04-04 06:23:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            fail    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 3123109284176b1532874591f7c81f3837bbdc17
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Apr 3 14:08:21 2022 -0700

    Linux 5.18-rc1


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 19:16:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 19:16:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298464.508453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbSBB-0000zZ-Et; Mon, 04 Apr 2022 19:15:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298464.508453; Mon, 04 Apr 2022 19:15:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbSBB-0000zS-Bt; Mon, 04 Apr 2022 19:15:57 +0000
Received: by outflank-mailman (input) for mailman id 298464;
 Mon, 04 Apr 2022 19:15:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbSBA-0000zI-BM; Mon, 04 Apr 2022 19:15:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbSBA-0005Aa-7H; Mon, 04 Apr 2022 19:15:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbSB9-0002d0-NY; Mon, 04 Apr 2022 19:15:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbSB9-0006RJ-N6; Mon, 04 Apr 2022 19:15:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QteDM4a8GMX27c1hEvRDZ3x8XUOgyYA9HnRxHLHlSMQ=; b=GqL6u+SuD1iA3ppA33D3TMNPLY
	bMVA62+4UYp6SeftiNee2Y8Uhp8FVLp33popCcrMzQnXKncxMmrY9bAFUfU5dB/imN+R36y8MxPTR
	Jec94miS8C+Wo6eHR8QpjkzkKY6GYfTw2ywiAxDx3dudsj3nagFHbbsg7/5TLjYJLfms=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169161-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169161: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=3e130e40fc55f06f7fe019e87ed9bae957870a12
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 19:15:55 +0000

flight 169161 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169161/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 3e130e40fc55f06f7fe019e87ed9bae957870a12
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   35 days
Failing since        168258  2022-03-01 01:55:31 Z   34 days  276 attempts
Testing same since   169141  2022-04-03 08:40:51 Z    1 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3211 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 20:57:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 20:57:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298473.508464 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbTkz-0002Cy-Rf; Mon, 04 Apr 2022 20:57:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298473.508464; Mon, 04 Apr 2022 20:57:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbTkz-0002Cr-NL; Mon, 04 Apr 2022 20:57:01 +0000
Received: by outflank-mailman (input) for mailman id 298473;
 Mon, 04 Apr 2022 20:57:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QszP=UO=gmail.com=frowand.list@srs-se1.protection.inumbo.net>)
 id 1nbTky-0002Ci-4u
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 20:57:00 +0000
Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com
 [2607:f8b0:4864:20::d2e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c36a9578-b459-11ec-8fbc-03012f2f19d4;
 Mon, 04 Apr 2022 22:56:57 +0200 (CEST)
Received: by mail-io1-xd2e.google.com with SMTP id 125so12841062iov.10
 for <xen-devel@lists.xenproject.org>; Mon, 04 Apr 2022 13:56:57 -0700 (PDT)
Received: from ?IPV6:2600:1700:2442:6db0:d520:1e7b:35fa:114b?
 ([2600:1700:2442:6db0:d520:1e7b:35fa:114b])
 by smtp.gmail.com with ESMTPSA id
 b12-20020a6be70c000000b00648f61d9652sm6860923ioh.52.2022.04.04.13.56.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 04 Apr 2022 13:56:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c36a9578-b459-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=/TjzTtoWiUEKM/0U+dl7E7XDCy4M9NHcDIrBVsIEEz4=;
        b=A0QW+6ey0QA4+SvWOuSnxmr9EczAz5/Z13Ki6Wxff0RHRr1Mk5QTlQQPDk5ynBAE+0
         L+GZeNiP4bo04s7secdIKMFRtozREJOiUZWeVE8J5PmRSgqskmpkfffhsa3Nx90XpYnX
         a01LM1MwErHVib++AtXM7RBHcdf+dw42XMcudrdpLzwC3ldplFGU4S3i7eU3vL2/HTYF
         +HBhhfUKwzNOPyHYbGa4070knhq6VyANCMXNz0n162EtGAMtnurCOFtVCdp9ECz5vDD5
         x8LyucANQsRkXFwhPqrei19bOWNfdrkETXabTETpfJS4UNj9235uxiWKSnP07n1pYP0U
         Trjg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=/TjzTtoWiUEKM/0U+dl7E7XDCy4M9NHcDIrBVsIEEz4=;
        b=2R9CIaUKjAjp+MUnqZh0xZOiwxfJ2BdO2IX9o7/bkWzQikVwOmQqB9md3xLSRdha//
         mx9NyIphKvHCni5VKsbrCqZ+HaiqdjB2iAglK5uDT0O5Xscyqm6ws8q04891L+9wltCB
         ooDxz1yFdqIoNE46K2KB/QRxO23cFt708qrh8k/F/I+pUiz52Qy1RmemJb3wrXiKMmxh
         wE/WGkI9ENVCVRcl8x2C0cI/8DfXiX9nGi0/D1GEZUL0OrUHuCPsM7suW3E1NVqFTxf+
         rGklBfOS4sXtDVem8ocQRt/PX8ePwVRr/1M0yPD2CiK8QoeaBUyvO6f7/eCTl/NluSCX
         CheA==
X-Gm-Message-State: AOAM530QgZVxVoPwCNd8m7NfitaI9WgiYHcDjRIlkE9M7p9KWlDuP4p/
	icHoT/rXj9L8CBK3c0+ZC6w=
X-Google-Smtp-Source: ABdhPJyVT9Y5eew1Xt15+plnA6RSzkcXqKNDGbiG4RDaA4DgN9UPHXIzX0P9jRjkCMDWCXw8GDL58A==
X-Received: by 2002:a05:6602:2a45:b0:648:b21c:6f49 with SMTP id k5-20020a0566022a4500b00648b21c6f49mr68306iov.206.1649105815993;
        Mon, 04 Apr 2022 13:56:55 -0700 (PDT)
Message-ID: <5ccfa749-3c1c-8d61-5923-6935dd48b0de@gmail.com>
Date: Mon, 4 Apr 2022 15:56:54 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] of: of_property_read_string return -ENODATA when !length
Content-Language: en-US
To: Rob Herring <robh@kernel.org>, Stefano Stabellini <sstabellini@kernel.org>
Cc: devicetree@vger.kernel.org, Julien Grall <julien@xen.org>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <alpine.DEB.2.22.394.2203311740450.2910984@ubuntu-linux-20-04-desktop>
 <CAL_Jsq+udUpUK3y7WOeLF2dtGs0=Jz59ed0mu_sgzstB-=TDzA@mail.gmail.com>
 <alpine.DEB.2.22.394.2204011338140.2910984@ubuntu-linux-20-04-desktop>
 <CAL_JsqJ6Yoc-gq=qUw+cS-34ZOsxtHAA01aa+FjaBySz1vwtuQ@mail.gmail.com>
 <alpine.DEB.2.22.394.2204011517450.2910984@ubuntu-linux-20-04-desktop>
 <YksOipbvQh8N1C+V@robh.at.kernel.org>
From: Frank Rowand <frowand.list@gmail.com>
In-Reply-To: <YksOipbvQh8N1C+V@robh.at.kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/4/22 10:28, Rob Herring wrote:
> On Fri, Apr 01, 2022 at 03:43:42PM -0700, Stefano Stabellini wrote:
>> On Fri, 1 Apr 2022, Rob Herring wrote:
>>> On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini
>>> <sstabellini@kernel.org> wrote:
>>>>
>>>> On Fri, 1 Apr 2022, Rob Herring wrote:
>>>>> On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini
>>>>> <sstabellini@kernel.org> wrote:
>>>>>>
>>>>>> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>>>>>>
>>>>>> When the length of the string is zero of_property_read_string should
>>>>>> return -ENODATA according to the description of the function.
>>>>>
>>>>> Perhaps it is a difference of:
>>>>>
>>>>> prop;
>>>>>
>>>>> vs.
>>>>>
>>>>> prop = "";
>>>>>
>>>>> Both are 0 length by some definition. The description, '-ENODATA if
>>>>> property does not have a value', matches the first case.
>>>>>
>>>>>>
>>>>>> However, of_property_read_string doesn't check pp->length. If pp->length
>>>>>> is zero, return -ENODATA.
>>>>>>
>>>>>> Without this patch the following command in u-boot:
>>>>>>
>>>>>> fdt set /chosen/node property-name
>>>>>>
>>>>>> results in of_property_read_string returning -EILSEQ when attempting to
>>>>>> read property-name. With this patch, it returns -ENODATA as expected.
>>>>>
>>>>> Why do you care? Do you have a user? There could be an in tree user
>>>>> that doesn't like this change.
>>>>
>>>> During review of a Xen patch series (we have libfdt is Xen too, synced
>>>> with the kernel) Julien noticed a check for -EILSEQ. I added the check
>>>> so that Xen would behave correctly in cases like the u-boot example in
>>>> the patch description.
>>>>
>>>> Looking more into it, it seemed to be a mismatch between the description
>>>> of of_property_read_string and the behavior (e.g. -ENODATA would seem to
>>>> be the right return value, not -EILSEQ.)
>>>>
>>>> I added a printk to confirm what was going on when -EILSEQ was returned:
>>>>
>>>> printk("DEBUG %s %d value=%s value[0]=%d length=%u len=%lu\n",__func__,__LINE__,(char*)pp->value, *((char*)pp->value),pp->length,
>>>> strlen(pp->value));
>>>>
>>>> This is the output:
>>>> DEBUG of_property_read_string 205 value= value[0]=0 length=0 len=0
>>>
>>> It turns out that we never set pp->value to NULL when unflattening
>>> (and libfdt always returns a value). This function is assuming we do.
>>>>
>>>> As the description says:
>>>>
>>>>  *
>>>>  * Return: 0 on success, -EINVAL if the property does not exist, -ENODATA if
>>>>  * property does not have a value, and -EILSEQ if the string is not
>>>>  * null-terminated within the length of the property data.
>>>>  *
>>>>
>>>> It seems that this case matches "property does not have a value" which
>>>> is expected to be -ENODATA instead of -EILSEQ. I guess one could also
>>>> say that length is zero, so the string cannot be null-terminated,
>>>> thus -EILSEQ?
>>>>
>>>> I am happy to go with your interpretation but -ENODATA seems to be the
>>>> best match in my opinion.
>>>
>>> I agree. I just think empty property should have a NULL value and 0
>>> length, but we should only have to check one. I don't want check
>>> length as that could be different for Sparc or non-FDT. So I think we
>>> need this instead:
>>>
>>> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
>>> index ec315b060cd5..d6b2b0d49d89 100644
>>> --- a/drivers/of/fdt.c
>>> +++ b/drivers/of/fdt.c
>>> @@ -165,7 +165,7 @@ static void populate_properties(const void *blob,
>>>
>>>                 pp->name   = (char *)pname;
>>>                 pp->length = sz;
>>> -               pp->value  = (__be32 *)val;
>>> +               pp->value  = sz ? (__be32 *)val : NULL;
>>>                 *pprev     = pp;
>>>                 pprev      = &pp->next;
>>>         }
>>>
>>>
>>> It looks like setting 'value' has been like this at least since 2010.
>>
>> Yep, fixing old bugs nobody cares about, that's me :-)
> 
> :)
> 
> 
>> I made the corresponding change to Xen to check that it fixes the
>> original issue (I am using Xen only for convenience because I already
>> have a reproducer setup for it.)
>>
>> Unfortunately it breaks the boot: the reason is that of_get_property is
>> implemented as:
>>
>>   return pp ? pp->value : NULL;
>>
>> and at least in Xen (maybe in Linux too) there are instances of callers
>> doing:
>>
>>         if (!of_get_property(node, "interrupt-controller", NULL))
>>             continue;
>>
>> This would now take the wrong code path because value is returned as
>> NULL.
>>
>> So, although your patch is technically correct, it comes with higher
>> risk of breaking existing code. How do you want to proceed?
> 
> We should just check 'length' is 0 and drop the !value part.

I agree with checking prop->length (not "pp->length" as in the original
patch because there is no "pp" in of_property_read_string()), and return
-ENODATA for that case.

I'm ok with dropping the prop->value check since we populate the field
with a non-zero value during unflattenning.

And update the function header documentation to mention that the empty
string "" has a length of 1.  Thus -ENODATA can not be interpreted as an
empty string.

-Frank

> 
> Rob



From xen-devel-bounces@lists.xenproject.org Mon Apr 04 22:13:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 22:13:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298478.508476 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbUxC-0001YN-K7; Mon, 04 Apr 2022 22:13:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298478.508476; Mon, 04 Apr 2022 22:13:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbUxC-0001YG-Es; Mon, 04 Apr 2022 22:13:42 +0000
Received: by outflank-mailman (input) for mailman id 298478;
 Mon, 04 Apr 2022 22:13:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbUxA-0001Y6-TZ; Mon, 04 Apr 2022 22:13:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbUxA-0008I9-SQ; Mon, 04 Apr 2022 22:13:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbUxA-0003Yi-9b; Mon, 04 Apr 2022 22:13:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbUxA-00058y-8o; Mon, 04 Apr 2022 22:13:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oTJtpyMlp6nPp2M83uYNeirTyYq2KJK/8VRJYFrQdqA=; b=CmNERLKNN06BGT+4G3iXsRQWqN
	CE+r56KW87KsgnDjiS+KO0i4CMJNtoyqHBQZxoWUzpKDe9FiPkDA0tzi6sBXmwZDrte6SbDGuB3sV
	m0qK5YFoZsffv0ndf7GqQB88M3L3iK3J2ZT/Ea+r6gABdJJ1mBKC+CJNBpNDyUbSEQFw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169165-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169165: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=ad6816c319cdbd927d81e071996a0dea33c86e4a
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 22:13:40 +0000

flight 169165 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169165/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 ad6816c319cdbd927d81e071996a0dea33c86e4a
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   35 days
Failing since        168258  2022-03-01 01:55:31 Z   34 days  277 attempts
Testing same since   169165  2022-04-04 19:43:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3336 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 23:03:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 23:03:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298487.508485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbVjf-0006dv-E5; Mon, 04 Apr 2022 23:03:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298487.508485; Mon, 04 Apr 2022 23:03:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbVjf-0006do-BB; Mon, 04 Apr 2022 23:03:47 +0000
Received: by outflank-mailman (input) for mailman id 298487;
 Mon, 04 Apr 2022 23:03:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbVje-0006de-2t; Mon, 04 Apr 2022 23:03:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbVjd-0000h5-Rp; Mon, 04 Apr 2022 23:03:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbVjd-00061n-7s; Mon, 04 Apr 2022 23:03:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbVjd-0001mq-6i; Mon, 04 Apr 2022 23:03:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yn8k+iyhwCTy4ovhECK8vtovnGGFZlU/X4myMmGqrLw=; b=IOr4KkJiBjHvKJmTAvYjoSX1rz
	uBIAbhBp3E8Fw9huggoqsAvpjwTluFI4OwVUQRv3rs8zRKGMXw2La3plpF0GNJrIkpPg2SOAvm+7U
	RWIFgJOsOkSt3AnqkMuQ28Ta4lR1Q9J/mW2x/YqSp0mwkv+OtQsEYp529zL996TdAqfw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169158-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169158: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-livepatch:livepatch-run:fail:regression
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
X-Osstest-Versions-That:
    xen=ca304edd3ba8c19211107fd2e898249987557ce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Apr 2022 23:03:45 +0000

flight 169158 xen-4.14-testing real [real]
flight 169168 xen-4.14-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169158/
http://logs.test-lab.xenproject.org/osstest/logs/169168/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-livepatch   13 livepatch-run            fail REGR. vs. 168506
 test-amd64-i386-livepatch    13 livepatch-run            fail REGR. vs. 168506

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168506
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  1e595d9c2b8608bcef48d6a69cc2f6135780bcc0
baseline version:
 xen                  ca304edd3ba8c19211107fd2e898249987557ce5

Last test of basis   168506  2022-03-10 14:16:31 Z   25 days
Failing since        168862  2022-03-25 17:36:39 Z   10 days   13 attempts
Testing same since   168957  2022-03-28 21:36:20 Z    7 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   fail    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 410 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 04 23:36:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Apr 2022 23:36:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298495.508497 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbWFR-0001YU-TS; Mon, 04 Apr 2022 23:36:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298495.508497; Mon, 04 Apr 2022 23:36:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbWFR-0001YN-QJ; Mon, 04 Apr 2022 23:36:37 +0000
Received: by outflank-mailman (input) for mailman id 298495;
 Mon, 04 Apr 2022 23:36:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9AlE=UO=protonmail.ch=mati7337@srs-se1.protection.inumbo.net>)
 id 1nbWFP-0001YG-Ay
 for xen-devel@lists.xenproject.org; Mon, 04 Apr 2022 23:36:36 +0000
Received: from mail-40130.protonmail.ch (mail-40130.protonmail.ch
 [185.70.40.130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f905cb2-b470-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 01:36:33 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f905cb2-b470-11ec-8fbc-03012f2f19d4
Date: Mon, 04 Apr 2022 23:36:24 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch;
	s=protonmail2; t=1649115392;
	bh=pr39D381McF2hU8HX7/6PLLu0BWZtU4VrF2jx1W4UDk=;
	h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To:
	 References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
	 Message-ID;
	b=Eug4mhSFoUAE6g8/KcddR8sHPrxXkuOVEHWDc4cbLZYyro5ATQNyUgUuv5OVlgQy5
	 d18vhOTVdmwH9YYjFWcU9TFa1w5gFXfvMtS9mkRn6GzUsyib5dow0Gq3A0PHmHf0Yp
	 7vHNwQp+uvFQ5PB2zY8KHJ7d5avMJV0eVZeq5LP/UWQk5KrO1mWdbymOPmKlXH9ABn
	 1oahCdiWexZqm6YlTRUjwPVcV0FtZ7Eh8zO08ZtKWpgP2FILuFH/ad/Y1bPFMsW2qJ
	 m3lHcEQElH+hN5N22lDfzi+d/F3oa4t4s20KwDhKgmZ4RTHox4Boc2+4x2nuw/t/6u
	 57Ny23RT+UsIQ==
To: "jbeulich@suse.com" <jbeulich@suse.com>
From: Mateusz <mati7337@protonmail.ch>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Reply-To: Mateusz <mati7337@protonmail.ch>
Subject: Re: PCI passthrough: possible bug in memory relocation
Message-ID: <VL9_sTXEiw8YngLJ-_sfNtIrw4Ofj1iVlw_jTKSCAwEW_DSJukiTpsl1GLCMKWY_9jhCZh3MwN8WF4v1dd_OgrDHoyFs27CrXLVMNckLzdQ=@protonmail.ch>
In-Reply-To: <6bd17005-b662-125b-76c9-ac971c8ac2e5@suse.com>
References: <l3LThLG8tkJBvD-3WTxzw6TRrj7GPAN9uWh-AWqzelw75qpdP1ZLXzBV7599MWrjrHH-lRKof3b0jm1DEGrUXLJszgh5hjW25oNtHoTI9Ts=@protonmail.ch> <6bd17005-b662-125b-76c9-ac971c8ac2e5@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

> I'm afraid answering this requires debugging the issue. Yet you don't
> share any technical details (as to how things don't work, logs, and
> alike), and the provided link also doesn't look to point to any such
> information (and as an aside I consider it somewhat unfriendly to
> point at such a bug as an information source, not just for reference).
> I'm pretty sure this code in hvmloader did work at some point, but
> since it may be used quite rarely I could see that it might have got
> broken.

Thanks for responding!
I only wanted to ask to see if maybe it's a known issue, but I guess not.
I'll try to debug and fix it myself so that's why I haven't posted more
technical details yet.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE0RoD3+S7b5zXZ6lW6IGQZRJEAKsFAmJLfqYACgkQ6IGQZRJE
AKuowA/+OOcS4CyBmG/NEF4Brc+oAsjdXsz3vZvMgqhc5oNU7hYOLnOg5KKZ0xvz
p2+Tm5saS05A+LIiFXC302tiwoQ9Gq+9hXw92c5nI+FZWyMNvA71Y27XKiHymWpe
ksORbIdc1B4st4J3bEls4R1PyjSuYyaEMcFMHH7aPGydXFjgon/8BtqenwKz2vrM
ncW+/VtQkAj2BcwMJbSq/M+JUOm115Jvb3LQDhCi/XvoGrduW+HB+lavN9opnJnT
jlSeS6H96L70EWYnV49+i5OBgQrcFfDQcZqZ4+dU9lFjEvWYn2d2wNzwD6PlXl1g
kHX+PBM95UYJDEwlCXGBX9Dc68LRIMAfpaOyzZsEYoNHbExGUPVpzKx9a7SnZBJZ
1X94MKuxDrbIULvpP1QezNaBMojtagI30DSODbuBpmcyu6Bl+QlKL/OFeP41+Ic5
EOWoFqjklNbvSVMyG08elRvmaR63JAHncCqDHBnxQ7eThMFQGNnY2qzniKqas/UR
2H0XgU5UqzZCsr+4Yk4Ab9gS06t+UdCTJAvoX9SyS0kjSHNkpF8fKZI8AgRg/RWL
mtMwouwZRaKlVmezYJKfuHvLQpb19dZFcFtkBOFN1PftXxNMPIEWq0w17rRzwWp0
QL6mzytmQXK5lfC2eeUDiggyk5gp25Gnw1bQyl6eSW/nN16cP/Q=3D
=3DpAFu
-----END PGP SIGNATURE-----


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 02:06:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 02:06:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298503.508508 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbYaN-0000qP-QK; Tue, 05 Apr 2022 02:06:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298503.508508; Tue, 05 Apr 2022 02:06:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbYaN-0000qH-KM; Tue, 05 Apr 2022 02:06:23 +0000
Received: by outflank-mailman (input) for mailman id 298503;
 Tue, 05 Apr 2022 02:06:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbYaM-0000q7-74; Tue, 05 Apr 2022 02:06:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbYaL-0005Nw-I1; Tue, 05 Apr 2022 02:06:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbYaL-00029F-1N; Tue, 05 Apr 2022 02:06:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbYaK-0007uy-Vr; Tue, 05 Apr 2022 02:06:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HK7d37hA42YvyOANTTGuP9XtNpQWto0tNwTI82hEjdA=; b=JGdvv6NtjwKsLKgagqQj5ffNaw
	aJB6l/7fOOk3ncbpz/DpccDhDHN7LJwyJAb2SdlgT+i9ZUEh4zH482fjA5xW0acdA5wqPb0JaqlQ0
	KGm2uBedOnS9Vp79IOJUCn+A9pJxcR7C3srF0b10JQveGnCBzFgDlSTQNb4q2YwAIM0k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169162-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169162: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e11d98d6fc433633f702db02256042862a48ddee
X-Osstest-Versions-That:
    xen=cd751c09a5bab9f3529901fbe4d867ad7d52e89d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 02:06:20 +0000

flight 169162 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169162/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 168502

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168502
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168502
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168502
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168502
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168502
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168502
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168502
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168502
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e11d98d6fc433633f702db02256042862a48ddee
baseline version:
 xen                  cd751c09a5bab9f3529901fbe4d867ad7d52e89d

Last test of basis   168502  2022-03-10 09:07:57 Z   25 days
Failing since        168863  2022-03-25 17:36:55 Z   10 days   13 attempts
Testing same since   169162  2022-04-04 15:39:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Olson <Alex.Olson@starlab.io>
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   cd751c09a5..e11d98d6fc  e11d98d6fc433633f702db02256042862a48ddee -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 04:40:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 04:40:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298534.508603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbazK-0008Ph-4X; Tue, 05 Apr 2022 04:40:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298534.508603; Tue, 05 Apr 2022 04:40:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbazK-0008Pa-0a; Tue, 05 Apr 2022 04:40:18 +0000
Received: by outflank-mailman (input) for mailman id 298534;
 Tue, 05 Apr 2022 04:40:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbazI-0008PQ-MM; Tue, 05 Apr 2022 04:40:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbazI-00086W-JV; Tue, 05 Apr 2022 04:40:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbazI-0003de-6E; Tue, 05 Apr 2022 04:40:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbazI-0005Y8-55; Tue, 05 Apr 2022 04:40:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eCVIWZbUryAk5BU12nqLcWIA+sMYsoOBY4JwxLf2bx8=; b=MYzQusesUa8Jf5WxbvdyKFuw18
	E+ZQhgT6plbfx40m6atcw3VodTSzg7TJCSp3mKNWRP/0dwLDioV197nGB1hyimFb4Qx3pljSG89BP
	qylQ5XlojR8qpKk2hESqNfygjdZwQG/mPrpcwV36kthFh5Igx1EXg4iGredUFHhreIj4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169163-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169163: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
X-Osstest-Versions-That:
    xen=d62a34423a1a98aefd7c30e22d2d82d198f077c8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 04:40:16 +0000

flight 169163 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169163/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169151
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169151
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169151
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169151
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169151
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169151
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169151
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169151
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169151
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169151
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169151
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169151
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
baseline version:
 xen                  d62a34423a1a98aefd7c30e22d2d82d198f077c8

Last test of basis   169151  2022-04-04 01:51:47 Z    1 days
Testing same since   169163  2022-04-04 17:38:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d62a34423a..e270af9428  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 -> master


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 05:11:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 05:11:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298545.508621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbbT9-0003ue-Mo; Tue, 05 Apr 2022 05:11:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298545.508621; Tue, 05 Apr 2022 05:11:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbbT9-0003uX-Jh; Tue, 05 Apr 2022 05:11:07 +0000
Received: by outflank-mailman (input) for mailman id 298545;
 Tue, 05 Apr 2022 05:11:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbbT8-0003uH-Br; Tue, 05 Apr 2022 05:11:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbbT8-0000UR-9S; Tue, 05 Apr 2022 05:11:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbbT7-0005pH-Pm; Tue, 05 Apr 2022 05:11:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbbT7-0002D0-PJ; Tue, 05 Apr 2022 05:11:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=93yHWgdSkZUlM9ZhIfPUPi7ciguGjmrivYxcz8TO6R8=; b=tm98zNc6++4RcRVJIWOvO3XHka
	P/KHxX7rymL35k0h51GOZhWIWNh2CA+VN/B5n90wGbhMyduiuFAxve6nCiMzjwqLRr+4VYLX3Rlkc
	tua5iAriIMvka8ofvq0QfxyhwEZmLG6Y4mnyVjoC5FjZ8/kx62KTDh2F6fmRwm+8oGRE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169169-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169169: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=ad6816c319cdbd927d81e071996a0dea33c86e4a
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 05:11:05 +0000

flight 169169 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169169/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 ad6816c319cdbd927d81e071996a0dea33c86e4a
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   35 days
Failing since        168258  2022-03-01 01:55:31 Z   35 days  278 attempts
Testing same since   169165  2022-04-04 19:43:09 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Li, Zhihao <zhihao.li@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3336 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 07:43:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 07:43:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298554.508632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbdpr-0001HC-GX; Tue, 05 Apr 2022 07:42:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298554.508632; Tue, 05 Apr 2022 07:42:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbdpr-0001H4-Da; Tue, 05 Apr 2022 07:42:43 +0000
Received: by outflank-mailman (input) for mailman id 298554;
 Tue, 05 Apr 2022 07:42:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbdpp-0001Gx-NA
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 07:42:42 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f5ecaa3e-b4b3-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 09:42:38 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5ecaa3e-b4b3-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649144557;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=kf23B/RcHX29r450+gyrgUunDuuGEt26SOtF9x9V21Q=;
  b=QCG7up+pOR3tdIeQZz2pym8p39HbCFKdY0mdau/+C1yYfcomfl8hIhOr
   fydLhdpRc4t7hm22HvXUaCJ+FPTyyJxHbzfa3ZcLwftrlan12txZadmbd
   sadnWhg3UGnWcq+o1DRf2Ct9uoDh7nnEVj2UhI9NOFVRkTY5qef8tdGyJ
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68017922
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KNnO762cheybMdU1s/bD5QJxkn2cJEfYwER7XKvMYLTBsI5bp2RVy
 2pOCj/Va6uINDT3Lt4jYIzk9x5XsceDmIA1SgNspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIw3IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0cmK2IdlwsHpbFxsoSQ0lUSi5uMbd/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u1pgXQqeEP
 aL1bxJTbTfkfg9jOW1JI6omsMGq3l7AKTRx/Qf9Sa0fvDGIkV0ZPKLWGNjcfNCQVNhWtkmdr
 2PCuW/+B3kyONOTxDWf+1qwl+TPmmX9Q4tUG7qmntZxi1qP2iofAQMXTnOgvfCjjke0HdNYQ
 2QY4jErrLQy3EWzQ8PhQgajp3qZoh8bXcEWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1
 FKCg5XuHzMHjVGOYSvDrPHO92r0YHVLaz9ZDcMZcecby4jOkbkM1Rfvdd89PqGl3tGsFiH82
 Qnf+UDSmI4vpcIM0qy6+3XOjDStuoXFQ2YJ2+nHYo62xlgnPdD4PuRE/XCetK8dd9jBEjFtq
 VBew6CjAPYy4YZhfcBnaMEEB/mX6vmMK1UwanY/TsB6p1xBF5NOFL28AQ2Sxm80aa7omhezO
 Sc/XD+9ArcJYRNGioctPuqM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/1uY
 c3DLZvwVipGYUiC8NZQb71AuVPM7npgrV4/uLihl0j3uVZgTCD9pUg53KumMblisfLsTPT9+
 NdDLcqaoyizo8WlChQ7BbU7dAhQRVBiXMieg5UOKoarf1o3cEl8WqS56e5wJORYc1F9y76gE
 oeVARQDljISRBTvdG23V5yUQOi2B8wi8itnY3dE0JTB8yFLXLtDJZw3LvMfVbIm6PZi3bhzS
 fwEcN+HGfNBVnLM/DF1UHU3hNcKmMiD7e5WAxeYXQ==
IronPort-HdrOrdr: A9a23:b94wOql2vUwe7StELRf8+/GLpQjpDfIo3DAbv31ZSRFFG/Fw8P
 re+8jztCWE7Ar5PUtKpTnuAsW9qB/nmqKdgrNwAV7BZmfbUQKTRekJgLcKqAeAJwTOssJbyK
 d8Y+xfJbTLfD1HZB/BkWqF+gAbsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68017922"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RIw9KEERhLj85XtWy+K+3qvURkaiAUGatRnQJm2rcPa/yd3a7tiSYyPxAhsBgnAZWBGu59X5rE1xPo1rgC3mEFEk4b59nR4d57RP32ITcaZz2yX0rjXc7dGjOu0mQeT2ocI02quFXWpvRkyrydATDNDBCXIsMQUaQAaUFWhm33TmhLdl1VREHE9f7aWin6I8j4dwqlMMDErUUGtPt9C5JakOvqbfKXxKPhHgav20Q2Je4GOhKCi9y/UU7nmsCBULNXNvACGPtZosy6eFB0Ie9MMItkI0836HQ3XsAKjY/YJI+byDkeUQBSysF+Vh0PRzns3vBgZG09muNmGTqO4DDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ujeaJow8xSy9r7cLaQRDnkOrgWUB0pRTW7ImUZPADDY=;
 b=ej21RTttHcJ2391VJYaI81j2RnnhuKhhJXhRaJMaWNkTh3MB0b12dCKmcR6EWdGQezEW8+FEkEr9tZUicZGFEp+OO1th0VYXMuwgOPN89BWF+AcZ+1Ks5M/XCqqb5WvNCRC8bao2OGTbme91f2Wg4jLhu9bN65+5kHubP2ZmjcnIIlAPw5R8K9mtjyZHnHUAO4TMjpEIa5dFnMTP/JNs6PpcwTTOxMnh1+cgzy9yGcNCPi3qX8NdKWqe/HfiPi3QLXL13Auey6DgWwulKW0xKGfl2y5V/QpaEAY6qS9wdsFgdZN99UOnnZVqpDoeG6cNGUitbQgBN3U6enMjv5yLzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ujeaJow8xSy9r7cLaQRDnkOrgWUB0pRTW7ImUZPADDY=;
 b=dsR9I0PTHy2J+XYf2ZBivaNZl2lkJowGVyWP19GevWoGY+OPqaiYjCm1Y43Rp9n14eTnEttePisCsm1PDi7PzEVuSSgSGrlTSAsNfwu5OPe1/30jpsYY0lilwa0mmw0R9O2yS/zXOVwbmUzqlB5LJhjcGMV/6zzFdnVEGjPEa9c=
Date: Tue, 5 Apr 2022 09:42:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
CC: <xen-devel@lists.xenproject.org>, <scott.davis@starlab.io>,
	<jandryuk@gmail.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Message-ID: <Ykvy4lWiwASHGXcF@Air-de-Roger>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
 <25c10763-36fa-34d4-05b6-655c08fdfee7@apertussolutions.com>
 <YksK9hIbJbOXkIYd@Air-de-Roger>
 <cd178295-4c8b-6710-3050-011fcee378b1@apertussolutions.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cd178295-4c8b-6710-3050-011fcee378b1@apertussolutions.com>
X-ClientProxiedBy: MR2P264CA0126.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:30::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a907c93a-84ed-4ff0-714c-08da16d7d788
X-MS-TrafficTypeDiagnostic: BN7PR03MB3921:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB3921296871F0A3ADCD597D098FE49@BN7PR03MB3921.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Ss+5CZkKjrm7Gh3+CNlbedmBHMjAkpLFYTtKfW89IrE/0DeEyxwH0U3+Ku+VRbKWyK9+nJbfw3G5XnwJJ6UvmPfuFaTO5hiqCPZBUEl8ykIT6oCTVZNl84e7Nd6+Cwb6x8iYr4qroQO9azGYLu4qKLBHQFBhf+mXiZU90r8useVbQW0HQSh69UZ/FBSCB5gAR1/IQNGBF0ItXFXKUf3gouacoQKu5fwHgz3HbU2GFkUsbhSbEHy4oxWL/Z/I3B3fx5EOgy77fKQywCUqfoy/fKDobR06za/OPY8Rk0zthmdVC2mmBiuJiJ6urAsyUG7923cvl0TRYkZCJACoEGfnSxeiANaDhNo3Nx3I6CaQUS572w/CG+ra6Fh50/eH78yrlOMwWvWJ3LLqUWWs+T94GJazJ7fn7eAbmp+cR4K5CvNtumAhqqUOv3t2s8c+xbi2wNgYHVt6EgPHboWgKJHMQENESpzJCsh1JsRt7V1i5p3A91rTt2zncJbL2crXYKgOhjaugVN5Kp/lzT4a/AGCvPgTcOW3YtglSNQST8SNOADogn0B76wVNlY3OlTKuNJZzuC4tUIeewwBLBbaA1uYunqaYcFovVdZwEELu6CtZhUfWDlWDo7VHzpfkIW591qFpw6X+UMgveFijVzQh1KQWOWcUunWzAz32BVLNuLA+RgQyo9FRPIwMue8DOZMomgu6WX7jCggJ1kn0j0ppDIxyz4FSrHthSG9UfJQGjZchlk=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(66946007)(6666004)(6506007)(53546011)(6512007)(107886003)(66556008)(66476007)(86362001)(4326008)(8676002)(8936002)(9686003)(26005)(54906003)(82960400001)(38100700002)(5660300002)(2906002)(186003)(85182001)(966005)(6486002)(33716001)(316002)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1JaUmtKdzJjblhpOXlONVBXSjZ4NTZXNXpHbTRlQWVFQXp5ZzlCdWtwaldP?=
 =?utf-8?B?N21jNERtRUdVYnJmd3REZlN6TVpON3NMSTZTWHZDU1k1emplRHUxdStzdmxW?=
 =?utf-8?B?cWsyUVhNb25yaUJGTE5mYmpRTVdaUFJ0bTNNTTd6ZCs3bG52RGZQS0hTRUE2?=
 =?utf-8?B?MXVqQkRoVVFQREQ2Tis5aVZoV2VPR3MvNjZGK1NWd3p0RGlKMWJ1eHFYR3Ex?=
 =?utf-8?B?eWhLdUVtcXNQT0NraEtMYzZiZVc0VTV6Vm1jVHJ5WWpnbW9naTE4ZlZXU01l?=
 =?utf-8?B?QTB4bVBrSy9sc1B4bysvQzRMRWZZbEJrUWY2SzQxMVY5c3RLMDIrVzN6K0wy?=
 =?utf-8?B?eHE0eVk3WXZHbkNyTkpNUkZpMHJEUkk2RFdpUUVVSGZ3TVc3bEo5TDZ5VGp6?=
 =?utf-8?B?ekMyKzI5U2ZUdFJLbXZqZ1lsdVFmeUtsRUdXNEUvV3k2QTJUMWVDNkpER0x1?=
 =?utf-8?B?cW5uVHdwcjRsNTFlOVJsVENQZWY4VTBjTStCOUM3Y1AwbTNTWTVlZDFLYmdB?=
 =?utf-8?B?Rjd6MWpyQmtRMXRNTGlrb3gxVTdPOUtuMW1uTy9qaGlIRWwzRktYK2hmbTFa?=
 =?utf-8?B?ZVlub01EVGdYRytEY0UyMG1BL0NWOUtDb1J3S3pnekpQME1ENlp5cTZxVyth?=
 =?utf-8?B?WnE1bmhRL29jellLUHoxbWRpbUJKUjBmMEtuWFYwYjFTYnVwYkNlQW9lYjZW?=
 =?utf-8?B?WUZ6elo0aEZlK2RHS2I1WmRxQjZQd2NOVkZHNkN4eVU1bndqR2VMeVB3N003?=
 =?utf-8?B?eDNIdlkvRGtQU0VaSElRd3ZYVC9pblkwU0w3NFc4RG9WQ2QvUTZWaDhNK084?=
 =?utf-8?B?d004Z0YwVW9kT3pyaUZMTDJSM1NuTXlWcnNzMzIxRjNLNmo1dnV1ajI1WnVs?=
 =?utf-8?B?V09DTklpaENCNlVLWDNMa2tua2JINjcxUmh3OTFGSnRYN2hLemFnakk1QXNh?=
 =?utf-8?B?L3BrYXA5TEVEKzBBRHlCdldqaXY5RmdRN2M0WktBNFRvZ29SKzhoMnVvMTFK?=
 =?utf-8?B?S3hKMWxYS0ZsNXh1SFkvd3BsN29kMmhBcXFaQ0NMVjVKeVpQU3lia3o2NGky?=
 =?utf-8?B?cWVOaDAvNnlWcFZ3TWxpMThqTlZXQnR3NjZibXpMOHh2a3RqekU1cWMycGd6?=
 =?utf-8?B?c2gwUm1CSnZtc2JnUWk5VTdXbTBiTWpZTjFZTjA4azJObFZwbEw3TEhzcVhp?=
 =?utf-8?B?TkMwOEQ2aFpJVzhLM29HZTFuNXdHNTJ6YS9tWGpYWHNyeHFHRVZrOW1Ib2dD?=
 =?utf-8?B?SXYyRFNqSFdtRzBBQXFzaVFuVVZLMEl0aG83RjltZWRaa2RDaVV4UU5hM3Fk?=
 =?utf-8?B?bXMxUWhxL1ZidkJETUx4bWVpU2ROaWh6RHc1bW5jWjNYUzIwTWQyQTVsdmdO?=
 =?utf-8?B?NXlJa0NXSHNXeHNlWUZLbFBaVjcwQnZaVzhNejdqM2xNWXVtTWIvV1FQR2Zq?=
 =?utf-8?B?bVppTkVxN1BPbEQ1cGQ3M21sR0ljZkkzeTE1OGI2ZTZVN3dUUWpycExHY0Rr?=
 =?utf-8?B?L0F3SmRLbkMrQ24veUpiSGh0VnY4cDVTQ0ZKdm9VQzJrczJmTmNQUUZBQlI0?=
 =?utf-8?B?aEZ1ckJLV25ob0FreTFpYlRzTmlIYmhWQ0cyeWJtT0VFcUdtRzlDRmZ5c09R?=
 =?utf-8?B?RitnNkJGV3k3ZmxtTmczSHRJM29QT2ZlK1NvcTZ1OWYxRm54WEZEbzFGbHNh?=
 =?utf-8?B?N0VVNmZ4WUhQUUU4eHdqa0VpY1FwSnhXeFBKNy9nZ3I3TU1VRkJxN1NpQ1kw?=
 =?utf-8?B?WWRUd1BweTFYSmdPcmNuODNLTWVzQzB3Zm8wT0cvUjh4K21QbUdBcTlPbE84?=
 =?utf-8?B?Y1Rjb2NNWFNSOU1TOEdNWlBBN1BJdG5zNkVxK1lEQW50RUZyUVp6MWJtYnNH?=
 =?utf-8?B?UUpxZTZHOHZiSFdwQTdQQlJ4Yzl5ZEVGU1k2NTFBM3JZUTBSL3luMC9sNkh1?=
 =?utf-8?B?Tk53aXcxRnNLUWpoeVpXUjNzcTZVZjNRemRiVHFFL2tVY1F6a0g5WmpNeEFw?=
 =?utf-8?B?MFF1eThsN0RsVXVUUUo1M3NYRW9TNGlKWjJtZW1RM0JvRXhWM2REcFJSaGFM?=
 =?utf-8?B?Y0kzbHlmbkV4ZWhDS0Jldi9FRGpUM1R4L201enkxSFFwTEY3QjlCRmFSKzda?=
 =?utf-8?B?cXRIa1lZaEUzZDlxK1RhSFVzajRSMStwaVNJamg2bzJvMzhESE5ZcGhoMWN4?=
 =?utf-8?B?Ukg2VkhXMk15L082cUw1WmM2MWo1WUFodG9mRUdZcGh0WFpZcjVUbUZ0U2ZV?=
 =?utf-8?B?YmV5eHRXdFRFdUExUUtoSHNHckF3U1BiYTI2OU5xQXY4b0xIM3YyU3ErNktK?=
 =?utf-8?B?Zy8rY0hXWWFiUjRIZmxLWVlSRVBRSGxHdUxxNXpzTHl3MDFyVDV0K2FleHNs?=
 =?utf-8?Q?mKws5pKpuZSiwWFI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a907c93a-84ed-4ff0-714c-08da16d7d788
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 07:42:31.8668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Byq/fYMIyRiFuHG4PNcQUDI4Ni6RrLvirhzzx32HefeMl6sMR8840OZndSyk5IeNPCwuCsCqYLR7mu0KBFYfPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3921
X-OriginatorOrg: citrix.com

On Mon, Apr 04, 2022 at 12:08:25PM -0400, Daniel P. Smith wrote:
> On 4/4/22 11:12, Roger Pau Monné wrote:
> > On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote:
> >> On 3/31/22 08:36, Roger Pau Monné wrote:
> >>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
> >>>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> >>>> index e22d6160b5..157e57151e 100644
> >>>> --- a/xen/include/xsm/xsm.h
> >>>> +++ b/xen/include/xsm/xsm.h
> >>>> @@ -189,6 +189,28 @@ struct xsm_operations {
> >>>>  #endif
> >>>>  };
> >>>>  
> >>>> +static always_inline int xsm_elevate_priv(struct domain *d)
> >>>
> >>> I don't think it needs to be always_inline, using just inline would be
> >>> fine IMO.
> >>>
> >>> Also this needs to be __init.
> >>
> >> AIUI always_inline is likely the best way to preserve the speculation
> >> safety brought in by the call to is_system_domain().
> > 
> > There's nothing related to speculation safety in is_system_domain()
> > AFAICT. It's just a plain check against d->domain_id. It's my
> > understanding there's no need for any speculation barrier there
> > because d->domain_id is not an external input.
> 
> Hmmm, this actually raises a good question. Why is is_control_domain(),
> is_hardware_domain, and others all have evaluate_nospec() wrapping the
> check of a struct domain element while is_system_domain() does not?

Jan replied to this regard, see:

https://lore.kernel.org/xen-devel/54272d08-7ce1-b162-c8e9-1955b780ca11@suse.com/

> > In any case this function should be __init only, at which point there
> > are no untrusted inputs to Xen.
> 
> I thought it was agreed that __init on inline functions in headers had
> no meaning?

In a different reply I already noted my preference would be for the
function to not reside in a header and not be inline, simply because
it would be gone after initialization and we won't have to worry about
any stray calls when the system is active.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 07:51:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 07:51:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298559.508644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbdyJ-0002jX-Ch; Tue, 05 Apr 2022 07:51:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298559.508644; Tue, 05 Apr 2022 07:51:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbdyJ-0002jQ-8y; Tue, 05 Apr 2022 07:51:27 +0000
Received: by outflank-mailman (input) for mailman id 298559;
 Tue, 05 Apr 2022 07:51:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbdyI-0002jK-5n
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 07:51:26 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2eff67fe-b4b5-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 09:51:24 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2eff67fe-b4b5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649145084;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=OqG7IHbP76DOKAaz6JaXpNJvt0jmGSJMkV3TDeWZPk0=;
  b=ihVVCvDeaDeZBlfdI5/Adm564kGuDM7EkWDh95vlOIfNoACtfEJd0FiD
   mvsoIkiwgCENepb9L3G85NscDPs0Q7kdZR5pn+CTss2oR1WIBbK+hwz2H
   VO5pajGr5Luqgy8wlpJSJG+wf97Z85Dyk0Y4oYZ4ScK+z7WPWMmD21tW+
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68424631
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Qoc+UKpOkjLFI6Il2HRzumT5aVFeBmIPZRIvgKrLsJaIsI4StFCzt
 garIBnXOqmMYmenKIpyPIy//RwB7ZKBzYI3Sgs4/nsyHngXopuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y6q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBZYTgpOIPdz9iCXt1EoBI++6YGH3grpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZpFM2YxN02ojxtnM2ZLWLEdrueTqmjScyJhummNioAJ2j2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcVhwS2xzLjwxTyDXGMrYzBCOYMfsZApEGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdQ2mY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtAOzARVodt/xory9U
 J4swZX2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1Y55eIWO0P
 BSP5Wu9AaO/2lPwMMebhKrrVawXIVXIT4y5Bpg4kPIQCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGMqNRJcA9TcSZgbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3QApy/QNsDhapCkE8=
IronPort-HdrOrdr: A9a23:PKZgnKkQ15QQnAI4kcQp5YOlRLLpDfPOimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5
 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1F9TrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJrJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUUHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2XackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPW9yV0qp/1WH/ebcHkjaRny9Mws/U42uonVrdUlCvgUlLJd1pAZDyHo/I6M0k9
 gsfJ4Y0Y2mdfVmHp6VNN1xMfdfNVa9My4kEFjiV2gPR5t3ck4klfbMkcAIDaeRCdg18Kc=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68424631"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fD1VfFDswT5xiN/lR4KE3LfAzn4o0vs2tHGRdkmjH/EpD6AdkwkTT4wb98fzD1x7X/fCWppEFcXa17TWvTfCrlBQ5nR6XPDBxsua9ff9qQ4ZQQIJWCnqpgxpgWwUHd/iuuxhiKq1ZVZeaEkxLQv9iBJmcA4uHKzZZ4RZ0UCyiC7Yl3N8NCQX2bw09/PZqMk59VA8+AofbQ/rIepJcaIVYI7sxJJ1chUwl6pM6DStHBH0JW8tYHwYlBye9m2Eir+kMlKFShD24z9+ACfTkzRodDpD9Ez0htvowaBaE+Uo/xFM2lvrsewonUfs9avlGDk+h5YKT1Ce8qzPBJF6FaaTlQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XItcJLea+9/iugA0x5KWXlb5ZZGxIDQXLt3Q3Qo4eJk=;
 b=VN/fumIXvK0FiW28tv/MtPdsZdEwb66mbY9iMKOlUCV6gM97buPSu5v/7xL6cbUzfSYNH9oXH+tbmAntnkR5B5SjJT6ZlY792NllTqSg4NZP1V1UTLv9WMTttk//Clyaiy5FHbqHEZgERjlGLr0RciK4DcVCRo9Bk/wHNfC373eyc1B2PkfqNkvw8OwUuPOgJ/D/zElJw2MaUNy0lYk3u1l/82mpuqXOuEVkPYGpkuPgY3VITGyw2aQvTUbgWNskXmfvY06dcM4KXZWNBHhiticLsWSF99J2HVhxj9qVzKis1TJiygAv3TzrB2za3ww2B16OsFyGG/8jhPOnWVq2yg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XItcJLea+9/iugA0x5KWXlb5ZZGxIDQXLt3Q3Qo4eJk=;
 b=dOwAE76eVV1HmDvFcmb/eWdEovs/ccjPse2KGgZ5dVo6MSRjRd6TozzYF7IjeIGBCw9ASWsy0gzXiEcgRzTqV9JT5evCj9JPUMxGj9gz4Y5Wp1ZwVdaeBNtjlaR1peAb+iaEoQ/XvAVBdfI4qU4uXnQTiEiU3wVG097lPucLUmw=
Date: Tue, 5 Apr 2022 09:51:10 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 4/4] x86/time: use fake read_tsc()
Message-ID: <Ykv07h2FQE/khpdK@Air-de-Roger>
References: <6e540bc9-c536-84ac-fb1c-8271e7731b3e@suse.com>
 <bddbec0e-acc2-03f9-fe4c-167fa5ac0ea1@suse.com>
 <YkrxAX7X1sxVf15r@Air-de-Roger>
 <0dbc693e-dbff-a326-3d91-b97b7385636f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0dbc693e-dbff-a326-3d91-b97b7385636f@suse.com>
X-ClientProxiedBy: MR2P264CA0080.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2378f925-e064-4678-f294-08da16d91006
X-MS-TrafficTypeDiagnostic: PH0PR03MB6940:EE_
X-Microsoft-Antispam-PRVS: <PH0PR03MB6940C3E162B712CD41BB83148FE49@PH0PR03MB6940.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YWf7koW1XsMmE1UOvoLxEGRdtjUwNvWlHNh7BYJvoJlxEMnAHjiIPIe+G4bGVd6NYYSp+VBkbuKUAC3Y4hc503wRUTrKLpuFnuPMxhRvNHRbUcFChQbOmYApDd1S5NKPtdOVe6Yh2rltF+i9f8ReEI6ayTOIr7qmY+eHn7w/PP2/3+gg3kjzvdoY/y0mox1fe1xzIjSZpYlqPfx9QB/bL4jr8yUTYe36Iyk/3wrR9mriEdK3T+X+zsJMxK/NYJHEi72mwFNaItXfa+ZMyKR9043ybbUGdIikemyHjXCtJx3nQcW2D/28sWTiFBBrMLQ9LvDN4hhwcnrEY+nvttklwWp+75c/SANzEeXgKk231HYT/u7Hib/1QzL7ceLkt8hJ2C/jcSSautATbP72L4vcpmDD6KNQvgMxyTOGY1d7GQBeQ9sKh7WU88cW5qhoTZLfP1OwFn9YaOxz1d3dXkL0Wds9KCCNxNee9or+182OmeImqCaE0czg3W6jeiHGpIjkJu/bnqC50/Hflazn6rT3oOsyhx7XDt4JL4ypwiNqRrbzIxs9j9y5kYD8VEze1aK41xiQYn1GnQ4d6MfaFtQnXtRaCyLlAI0gAuha+nrrSD86sCceWyA9VdXlyysH+EuzPnkBMeWsOnJPhWh+IwCY0A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(9686003)(6512007)(6666004)(8936002)(5660300002)(66946007)(66556008)(66476007)(53546011)(8676002)(508600001)(4326008)(6486002)(38100700002)(82960400001)(6916009)(316002)(54906003)(86362001)(26005)(33716001)(85182001)(83380400001)(186003)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODNOWXJQQWp4TTZvWkJaL0lzanE1a0F2NWRJczR1a3Q4ZVZ0cTY2RDlNaEFt?=
 =?utf-8?B?SVNQUzBEeVNSdWY4VlpXcDVGbmdmOG5ZbU5RSFNucHh1NVdLZW04WGJDUDNG?=
 =?utf-8?B?QlBmNU85cWdGdG9WT2kyLzlncDBCbE5zbkJodEZOdlR2dElTZDVGem00Q3dy?=
 =?utf-8?B?Tnl2M2phSnE3K2E1S2dDSzh1UUkrS2llNjFZNEY1bWZQbGJIWFhpOUNva0lU?=
 =?utf-8?B?STVQVVAvVUJmMys2VWNCRlNHVUpkMWRyMHZ6VUFQVW9TbnY5Um1iVFhYQzdp?=
 =?utf-8?B?MWovK0xlVnR5djFmL3lETFZtb25JUGkwNnQvYzR4M0MyRGhnL2c3RW1xMXNV?=
 =?utf-8?B?VnoyZmtWVWJxWmdxd1lYVDVvYTVRZTdiL0pHekpUSFJ3ZUg0ZzlPbXVmcEtm?=
 =?utf-8?B?bFdGb2RhVUVvQy9Xd24zdk9GNzhBNWptQnhqVE5hNHlNeW9IVE1Wc1k3eE14?=
 =?utf-8?B?d1N4bjF1VUhwbThBaDVhRGJpakVKODNoSDN5SjRyMGJtS2hIYUpPQUtQSkZL?=
 =?utf-8?B?Tm9mWW9kT0lGc3YxQlVqNDhHR1pnTytqQ0VHQ2pkK0FuSDFFSkg3NkJSQlEr?=
 =?utf-8?B?M2IwN25jT0NqTExwTlRMVEg5VFN5c1QyQ1FyMzNtVEtQd01HVzJOTWowbUNk?=
 =?utf-8?B?TVVYYSttSnByUVJIZEtSeGIxZjd2YytuTTBOVmRpdzZRQzFxZTRvcFJuRWpP?=
 =?utf-8?B?bkpyTUZ1eWJDelBKaTRLTktBemlnaEQ1Y01XT0RnaWNYWTNjZGtEWjZtbklp?=
 =?utf-8?B?clJHSWZUQ2RuOGpCOEpRKy95bDhuRlhWbUxMSVpDYUZmNUU4dXd2ek56N2JZ?=
 =?utf-8?B?Wmp2UjhLNWd5RFZQQnlMN2pCYTFJSGFvMlowYVRaMWNMYXljVUk3LzFvNlBO?=
 =?utf-8?B?OVpTN21oRk81U2dvWTdHbm94MVpiYWg0L00wdUNpQTZMOWQrNzdZT1FwdkRJ?=
 =?utf-8?B?dGpoU3JkUk9KUTNLYkFDSitiT2lPcWNoaTVldEdaWDdtUkNDbGVwRXZ2VFRr?=
 =?utf-8?B?ZW1iZzZicjZOY211bHBlc2tjOTVzNHFEZHRhMk1sQWtoNXF2YTNjNTAvaUdI?=
 =?utf-8?B?WkRNT3BhcHJVN0hPNmlsU0ZjYjY3aDhOaVlnZG5DYTc3S2pqMWhydE9rc1Zl?=
 =?utf-8?B?NVlOdG0xbGxvV3VZaHA4ZTZSUnkzVmp3RkgycjNXMzhlaHFESko5MVBMV1Vv?=
 =?utf-8?B?UjJsckRFYWd1d2JwN0JQZzVYa01rVGRJWlhTQW0vMFQvYVpMOHFrbHVUUlpq?=
 =?utf-8?B?NmlSYlRicjE0OSt6bk1Kc1dKalBhbjVGc25iRnNyQWtiRWVOd01DRTJuQVda?=
 =?utf-8?B?SGphc1Yvc1h1dXRJbFlwK3cvaEJTeTliMTd4dXY2UVJDOXhwdjB0UXZEZnJZ?=
 =?utf-8?B?eDNXSWRzbHN2YW9Cb0JEZzdDTUhvOW1uZjBHcHNSUEtoRTNPcTBHR3hxM24r?=
 =?utf-8?B?YlE3elE0VFlQZTI1UkdhQzhTRlFtOFUxNDMwcjJNdzAyb3E0Q1kwYlNCQXNJ?=
 =?utf-8?B?dEdlVlQ3RXhEa0tDTHZBbnRSSDlONk1CNEwvU2tPUTZzY1ZkT2xFemlvdytX?=
 =?utf-8?B?elFjZ3BUSjdUYVZQdWZvSmFYUFFBYkp6MFJPUVZaK3lseCttM1h3cXRISWcx?=
 =?utf-8?B?ZnRIVnVKcWkxTTBEK3JidnY2R0IvbEwxWW91eXRseXVTOGplZlptV3pyTTBo?=
 =?utf-8?B?ZmpZT3lkenBRT3VUcXVqS3RVVlQxR0NwZFRrY0pvWkk5UTBoa3EwRS9kOGVK?=
 =?utf-8?B?ZnRpL2Eyd25wWk9tTVJidzd4cHlkRUlLODVFME9HVzhrYlMwbDF0K3JqN2dG?=
 =?utf-8?B?ZVg3ejh2TGNTVWFxUmh4T0NORGdoS2JJeWthUzI4ZEZWbDlmNnluZ2ZWOGtY?=
 =?utf-8?B?VlQrR0dxMDlJK0FKMThYUzZHSXl4STNpZk11MDNlSVBoeXg2SG4wdVVST3p5?=
 =?utf-8?B?SWpyMWtHVitrL29TNGM5cVZmR3ZMbGtnMElZL0lmOWVadDVpc0xEMWs1bzRs?=
 =?utf-8?B?RjRUNmwyQS8ySGFHZGFmQTk0MTd0VHZkMzl4MWh6SnJadTNuQXc1dzZsUWow?=
 =?utf-8?B?dmdZNUZITG0vRHE2ZW5XMGdrNGM2QU5Mdi9YRkhacXBMWERodkRaOHQ0UXR2?=
 =?utf-8?B?d2M3REREajZHZEZFL2wrK3MveDRuWTY0UUxlbkZ4Z2RaT0JDblFjK3R2Y0Rt?=
 =?utf-8?B?UUFWU09oY3pheGVtaGdqaWlRenQxNnhMTWY3UXVwRDd5VG84ajdiQVlxWTBE?=
 =?utf-8?B?UW5NWXl4a2hCM1VUTXd0OVJSQkNvaGM5aUhucVBoS2xtWExYV3laZEpjMXhP?=
 =?utf-8?B?anBNWjNuSWR2eTJ6L0hDc1RDaCtDQVYxZk1CRVRnaTJKSnQyaS9CU0NXRVlU?=
 =?utf-8?Q?Cnu4xAGQgLPmqCeo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2378f925-e064-4678-f294-08da16d91006
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 07:51:16.0982
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gOYa3XHGUftJFBrFgII7S8e8hx0yJaWYfDxOPReiWmxqGy9HfrfS6adHEGkpl8XQNzd1KHJn2H/KjdPdQkFQOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6940
X-OriginatorOrg: citrix.com

On Mon, Apr 04, 2022 at 05:33:04PM +0200, Jan Beulich wrote:
> On 04.04.2022 15:22, Roger Pau Monné wrote:
> > On Thu, Mar 31, 2022 at 11:31:38AM +0200, Jan Beulich wrote:
> >> Go a step further than bed9ae54df44 ("x86/time: switch platform timer
> >> hooks to altcall") did and eliminate the "real" read_tsc() altogether:
> >> It's not used except in pointer comparisons, and hence it looks overall
> >> more safe to simply poison plt_tsc's read_counter hook.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> I wasn't really sure whether it would be better to use simply void * for
> >> the type of the expression, resulting in an undesirable data -> function
> >> pointer conversion, but making it impossible to mistakenly try and call
> >> the (fake) function directly.
> > 
> > I think it's slightly better to avoid being able to call the function,
> > hence using void * would be my preference. What's wrong with the data
> > -> function pointer conversion for the comparisons?
> 
> There's no data -> function pointer conversion for the comparisons; the
> situation there is even less pleasant. What I referred to was actually
> the initializer, where there would be a data -> function pointer
> conversion if I used void *.

I see, there are architectures with different sizes for function and
data pointers. It's also not clear all compilers will be happy with
the conversion.

> >> ---
> >> v2: Comment wording.
> >>
> >> --- a/xen/arch/x86/time.c
> >> +++ b/xen/arch/x86/time.c
> >> @@ -607,10 +607,12 @@ static s64 __init cf_check init_tsc(stru
> >>      return ret;
> >>  }
> >>  
> >> -static uint64_t __init cf_check read_tsc(void)
> >> -{
> >> -    return rdtsc_ordered();
> >> -}
> >> +/*
> >> + * plt_tsc's read_counter hook is not (and should not be) invoked via the
> >> + * struct field. To avoid carrying an unused, indirectly reachable function,
> >> + * poison the field with an easily identifiable non-canonical pointer.
> >> + */
> >> +#define read_tsc ((uint64_t(*)(void))0x75C75C75C75C75C0ul)
> > 
> > Instead of naming this like a suitable function, I would rather use
> > READ_TSC_PTR_POISON or some such.
> 
> I'll be happy to name it something like this; the primary thing to
> settle on is the type to use.

I think it's safer to use a function pointer type like you currently
have from a correctness PoV, but in order to prevent stray calls to
read_tsc() I would rename to READ_TSC_PTR_POISON. This was already
static, so I guess it's hard anyway for any of such direct calls to
appear without us realizing.

With that:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:18:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:18:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298579.508658 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeOP-0005uf-7a; Tue, 05 Apr 2022 08:18:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298579.508658; Tue, 05 Apr 2022 08:18:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeOP-0005uY-49; Tue, 05 Apr 2022 08:18:25 +0000
Received: by outflank-mailman (input) for mailman id 298579;
 Tue, 05 Apr 2022 08:18:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbeOM-0005uS-U7
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:18:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f444d125-b4b8-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 10:18:21 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-q8Y01zFPMS2JmzcYdRbU-A-1; Tue, 05 Apr 2022 10:18:16 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5501.eurprd04.prod.outlook.com (2603:10a6:803:d3::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 08:18:11 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 08:18:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f444d125-b4b8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649146701;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=k7qlTFmxRuPfZaRPWud7AGTUFLNRrBgyDK50q6nKywY=;
	b=Tw5RWIVyP7RKRm9g7M1VFEY5d8Go+NqlQJQW7ixJ1n9QCcg7muJCSxfbrtHjXLl7p4dW/6
	2JDvHTvPpr2dCfPo6NwUGKKJ0CmcQDbMiqJ8PMs5Psuiipi4xuuanrpIU6RGnRiHNOQ3UY
	UZ+ImJ6OncNqHlNeB3rZGyYTG2abZJA=
X-MC-Unique: q8Y01zFPMS2JmzcYdRbU-A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CR7RrGZZKQWrPp3REe8iHygHYbZM1f1AtyyAl+z1Qpxf1yAxH201aOhYXzyHtHm2ClwhdDcLl/JWwJ0gvC7vUI957lEl9WH5yg6w4LJGrKd8XGzSmTNxSsKmPhnx2KxGObFqN8kRR0jvY36xrgJoenrvGTJtUkowVJIJ75MO0rH3SjNACw5QKn8mYju5YT1pXP6JSiCqT/oCPxAB/yE20qw8idPTqKCMpd9AKxZnxmbKJR2Mjra4oF5yWoLMoVk2euPmsooNr+0tlsJXBYr9h/XrH/nXgAfwRmJSFSlqWowaKs3E5sPSJfMu1A8sDPOoBNYloYLZ50EZ9isBbJ+KGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k7qlTFmxRuPfZaRPWud7AGTUFLNRrBgyDK50q6nKywY=;
 b=Dvb6XD7yPruZ/2Zt5mbx8vSV3OyrBF1S2UukiUTIm7BDjcJehcZd7wxgvur/0dG5grRIFy72zMq4h7HHVxEnvZ5ojU1xmpg4ESnidcY00Fa53wt8FDmf6veZN5jwFoeDyTSF6TPHD7ofRtfBMxDr4Q0F6ILquHg3cA4FerdLuikAEznATCagyW332rZWIzCYW+Y/VMC8KgNsGQj3UDQJlxCrkEE2X8tG16mwGK2//61wjSK65xmv5GDvqkE/8/JM9qGAf13N01OMvck+2rGH1J04OHJb675s2UYeL+oEeoWqPShIJbJiQGwRrylhfYq+vrFUH+Y4DxWSE3zPJjV9uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f5225d49-fcc5-c02c-2e48-cd96cc2bd940@suse.com>
Date: Tue, 5 Apr 2022 10:18:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] x86/irq: Skip unmap_domain_pirq XSM during destruction
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220330181734.30319-1-jandryuk@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220330181734.30319-1-jandryuk@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0030.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::43) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e596e491-e7f1-4854-e777-08da16dcd2d1
X-MS-TrafficTypeDiagnostic: VI1PR04MB5501:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB55016723602BAC08E0D5FB9EB3E49@VI1PR04MB5501.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hnmb47+/srbwno3P0Uh1MWKDhpuBPjNl40v1dmjfEQJkE6ihF2ndWhdjoSWvn9oyUEHh+SO7ptKme/bsukFlUWGmnti0JgbEkd9N1OzC551FjKSNkrcptDEcJC35IftKRtbuaxIJm5/myEB+ZZ3It8EQP/3P8mkcy846UF0ZlNpMFPH/ze06Mym3CrQnswid+uLcBH/CLnJTYlx/62XFLlPeONuztUvqjpBaBt7gigjXeqhwrPh4GXR2QJzSDwgmYty0NvIW/eO6xkAPj3CvmoCn0kFnh86JZsJOss7OJ4SHwdhJW3CO0AW9r+5gRW659ktXFA59hjl1QJXkzlr80qtSIORlBoxIm7XfLaYPDsHqB4oxdgfwaxK+5AbPp9f3poPE68MaIGbzQutnrFIdw5Vn1mvR3NP8r7ezw1S25Cm+0W3X3R2VazReeWelT5/B9NfHZDmSteGt/9DdmuCHq5QVbhn9xh8RrUs8s9SRdP4c5sX23UuDPpfm4Gcfxufmc2KUEhMDKLbIIkW37LMMEdBFvAe/OzIs92njaPaQ1EiMUCFLrNodXdiYxP1tJIHBK95y/Zsyr1ZDrf3G7HamVrdjH4Gu7OCl2rTFAcM8sJrLRkxJlefcJJCY+bo4+ysPjeA/Orc+yItMKMOAMQpid7kyqLkCGlg1ERruiiQpO1pmXOlb6aD8dszBoPojjme/kOAW/e+vQ2EUHNB9OLEmvbNRjv7okW07dVlOflj+SMU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(508600001)(5660300002)(6512007)(2906002)(316002)(53546011)(26005)(186003)(83380400001)(36756003)(54906003)(66556008)(66476007)(31696002)(66946007)(38100700002)(4326008)(110136005)(8936002)(6486002)(86362001)(8676002)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a1h1b1NZZUdSSEZHZVFZaWdOQWtvbk1FZHUvdzdtY0I2cnJjcitBRXlVSUo2?=
 =?utf-8?B?TWsvdmFOanJ2c1BUZGJTTVNmZWVSU2xCREJMR3Q3OS92NGNNMy80ckV4a2dL?=
 =?utf-8?B?ejRKVVBYTjFYYWh0bWFiZ05ncVo5enF6ODVwdmxpZHp5cFVqZ3NxdlNncmVU?=
 =?utf-8?B?NklWU29KNEliTGF4ajVZTDFWaUVwVUZhUnBSczZaVUVsb2Q5T3hhTDdVbG1X?=
 =?utf-8?B?VERzenJ2VFNQbUpMc0UxUXIvTjJWQjM4YlV0L0F1ZXdCRFZyOHZiUmtuR3Rs?=
 =?utf-8?B?RTNsUHZhS1VwR1NtbmtTRjJrclpFQWdVb1NXSUUvQlBaN0xqTzN1RXE2Q3o2?=
 =?utf-8?B?bXNaa3VsVThzTzdrenNlZERyMnJOZWVQMkpYZmZHeUVhaGp1NzRLQzdPYzNF?=
 =?utf-8?B?OUtHVVlJN0NxRGJ3bk9nSFRUcFdaUlZ5L2pCSFRYZjFqRHZLOG5LekF2NWk1?=
 =?utf-8?B?amZpWU1ialc2aWNjbEVIbjAyeTI3SVZKWjRhVnlmM1dRTUpCOXhHMk5keDY3?=
 =?utf-8?B?UkFrSVRnUCtrYmxwNW1lbk5WQUNteCtpVDduSzRVYVFPTFlCeUR5OCs1Smo5?=
 =?utf-8?B?bThGTThFUHJHMHgwT1BqaEJwS0RhQ255ZnU1ZXQvOC8xYW1WUjErSlgxN3Zh?=
 =?utf-8?B?OTZ2Qk9LQURsNjZrM0J5aU5PalBBSXhyS1RVRHprQW0vbDVuNjJsQVorYmpC?=
 =?utf-8?B?WlhiUE1seWZES3BrNlg2ZjZSdlRtUjIwOWQ3UURkU2JwZ3A1dFZnRlhIaTk2?=
 =?utf-8?B?MWZ1TEhTVGhCYnQ1RUxGbFVIRzlXSXpBazhzMGhmK0FuWUlOeFpnRDg1QXl4?=
 =?utf-8?B?ZUpSN3JqeVhJbFAyRW1sZitPUWpBaTEzWUsxY2hhcXZYaEEyZDVGOGgrdXoy?=
 =?utf-8?B?Nkh3OGRWb1BSUWo1NXgzc0l6aGN1REtlY2pSbUF6eG1MZU5kZ1gzUUlYZ2Vy?=
 =?utf-8?B?WFR5VjBsQ2pkVWhkNE9XaDd1S2lGYmJ0UFIzUUFEd1o5TnFmYkMxZWRPZ21Y?=
 =?utf-8?B?T3ZTT2RVc25TdUFOREsyN0FUdXFRdStkTWxCWldkOWh3TDJ2aVNyWDg0bWZ2?=
 =?utf-8?B?elpudkhoamlXejUzS3dOUGh1eDJmeHlFbExYOU1rNUY2eWg2UFZJMThQaGsx?=
 =?utf-8?B?eHBDZWlvOE9nUDM0cXg5c211UFZVcVF5SmxkVzhvT3RGNVF3dVJ3RjIvNUht?=
 =?utf-8?B?ajJpNVJ3T0xEUmE1Zk9RdUZTaXpuTHNEeG53cXlNVjZHNDZ6ZC9KdzZCeDZP?=
 =?utf-8?B?dmlHVEVnY0p3Zk5SdW5mSm5kb1pLQ1NhUGhBTVdIQXhjbUh0OXFCVXM0Sm1s?=
 =?utf-8?B?TGNET3M5bjNhWlQ0RHpWbnZ6bEUrMXY3aWcvdEI2THQ5c2ZWS0l4Y2lMUkNX?=
 =?utf-8?B?ak9hOGdlWHlacE1rVnBIbWtGckVhVUc2cnE0NHpkZm55S0RUQnBOUG9SOFVE?=
 =?utf-8?B?aE8zQUloWjV5aUxXYTBzMlNkWFJ0b1ArVzlNcnhvem9vbWlDYWVqdXpIdkFq?=
 =?utf-8?B?NXhwb2Y4My9iSmt2MGEwcHdWK1J2WG8xcGlYU3lxTXZYZlZ1d2hHUjA4YkNl?=
 =?utf-8?B?TVZIclhWSFFTYmdJVkdCdjNiZmRFV1BOLzJyZ0Z0dUNtTkFhbmFIejRMT0tN?=
 =?utf-8?B?VGdXbENBZTBJOXZoODkva2U0WklMaHgrQnRXLzNGOHBmaHhJdk5rUkx0UW5D?=
 =?utf-8?B?c3EvODNRbFdJck9URDBkQTFYZW5hMHI0clBjcFBhd2lBSzk2U3dJZWJLMUpW?=
 =?utf-8?B?WU1hUWczUDZDQWFCL01xUXZDM3ZuS09LSmtvRWVFTjMrcFB6V0hVN1Ivb1F1?=
 =?utf-8?B?c0ppMUhnNVp3Y3kwQlpUNlVyWUZDZXJkV0NQMFFxOWl0b1Y4VEhFbVEyRmY0?=
 =?utf-8?B?aDIwSUVDbzArRkI0eUUwdHYyR0ErNmVJSUFCYXlOR3ZxK1lSY2pzWU5hNXgz?=
 =?utf-8?B?dnlxYnpTNDl1amRJanN6UzVlcTFIQ2NjYURmbmZLanV1VXNvVlFXMVZGTVl5?=
 =?utf-8?B?MDJjUm96NUxEUkJ4NWtFNEc4QjM3K3h1WEVEVjVtZ2xTMG51UjRMWmxMejlK?=
 =?utf-8?B?cEdLWVFjWkhWN1ByWXJaOFczOGZpcVRnbzBuUmEyWWtYQnpjWjNMeWNhci9B?=
 =?utf-8?B?UWxqZ1k0b3Azc2RjNHAzWkcxNXVwemxMU1F6M1BxUUdFdW9RSlhJYWxlSmNR?=
 =?utf-8?B?TnlrWUtaSE94UmlRMUgzRUtnd1VlOGZscjlWelZGbVR1VjZjSlIwUXB2R3c0?=
 =?utf-8?B?ZERQUEwwQ09mOGdVbzNLcndCb2VkeWNmZC9RaFRVa2QwbmQ1enpwS1lNNVhI?=
 =?utf-8?B?SFNHcFFjRmY3L1dncXZ0TDAvcitYeGhCZnlFdENxQzcwWDlCcFZZZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e596e491-e7f1-4854-e777-08da16dcd2d1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 08:18:11.3965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yuZ54pp3Qw+ldzrkIzPA7b8k7TjNf15wSi4Osu4zfB5G+yLztXIT4sZG1l4fEM3p5gKVT9cJ1c7WjkwvrCMhXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5501

On 30.03.2022 20:17, Jason Andryuk wrote:
> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
> complete_domain_destroy as an RCU callback.  The source context was an
> unexpected, random domain.  Since this is a xen-internal operation,
> we don't want the XSM hook denying the operation.
> 
> Check d->is_dying and skip the check when the domain is dead.  The RCU
> callback runs when a domain is in that state.

One question which has always been puzzling me (perhaps to Daniel): While
I can see why mapping of an IRQ needs to be subject to an XSM check, it's
not really clear to me why unmapping would need to be, at least as long
as it's the domain itself which requests the unmap (and which I would
view to extend to the domain being cleaned up). But maybe that's why it's
XSM_HOOK ...

> ---
> Dan wants to change current to point at DOMID_IDLE when the RCU callback
> runs.  I think Juergen's commit 53594c7bd197 "rcu: don't use
> stop_machine_run() for rcu_barrier()" may have changed this since it
> mentions stop_machine_run scheduled the idle vcpus to run the callbacks
> for the old code.
> 
> Would that be as easy as changing rcu_do_batch() to do:
> 
> +        /* Run as "Xen" not a random domain's vcpu. */
> +        vcpu = get_current();
> +        set_current(idle_vcpu[smp_processor_id()]);
>          list->func(list);
> +        set_current(vcpu);
> 
> or is using set_current() only acceptable as part of context_switch?

Indeed I would question any uses outside of context_switch() (and
system bringup).

> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -2340,10 +2340,14 @@ int unmap_domain_pirq(struct domain *d, int pirq)
>          nr = msi_desc->msi.nvec;
>      }
>  
> -    ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
> -                               msi_desc ? msi_desc->dev : NULL);
> -    if ( ret )
> -        goto done;
> +    /* When called by complete_domain_destroy via RCU, current is a random
> +     * domain.  Skip the XSM check since this is a Xen-initiated action. */

Comment style.

> +    if ( d->is_dying != DOMDYING_dead ) {

Please use !d->is_dying. Also please correct the placement of the brace.
Or you could avoid the need for a brace by leveraging that ret is zero
ahead of this if(), i.e. ...

> +        ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
> +                                   msi_desc ? msi_desc->dev : NULL);
> +        if ( ret )
> +            goto done;
> +    }


    if ( !d->is_dying )
        ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
                                   msi_desc ? msi_desc->dev : NULL);
    if ( ret )
        goto done;

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:22:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:22:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298583.508668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeSK-0007IY-Oz; Tue, 05 Apr 2022 08:22:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298583.508668; Tue, 05 Apr 2022 08:22:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeSK-0007IR-LM; Tue, 05 Apr 2022 08:22:28 +0000
Received: by outflank-mailman (input) for mailman id 298583;
 Tue, 05 Apr 2022 08:22:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbeSK-0007IH-7f; Tue, 05 Apr 2022 08:22:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbeSK-0004GS-3N; Tue, 05 Apr 2022 08:22:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbeSJ-00009J-G4; Tue, 05 Apr 2022 08:22:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbeSJ-0004EF-FX; Tue, 05 Apr 2022 08:22:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dZESIlReCOhcbyT9bHdAkJqSUiyodUS/HsxuBhQH1Ts=; b=B6xf1Zk2OB+OxqccfjF7SG7TEr
	OQf3Ts18JobbLetx0pWmNua0TXH7V9fBEOKwe5sXqho0dWj1VowG2aGvfdP6wbjxOgp3iB2cN/nh+
	Dex9OHr84VLWU1zG5FFKSpzpyPbbYCA/kS7AhGRNDWE1hdAaDIe7bH+xzvMyKVhOzeMw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169164-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169164: regressions - FAIL
X-Osstest-Failures:
    linux-linus:build-arm64-pvops:kernel-build:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:host-ping-check-xen:fail:heisenbug
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3123109284176b1532874591f7c81f3837bbdc17
X-Osstest-Versions-That:
    linux=09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 08:22:27 +0000

flight 169164 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169164/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-pvops             6 kernel-build   fail in 169157 REGR. vs. 169145

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw 10 host-ping-check-xen        fail pass in 169157

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl           1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-examine      1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)           blocked in 169157 n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)           blocked in 169157 n/a
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 169157 blocked in 169145
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 169157 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169145
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169145
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169145
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169145
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169145
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169145
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169145
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3123109284176b1532874591f7c81f3837bbdc17
baseline version:
 linux                09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04

Last test of basis   169145  2022-04-03 20:41:35 Z    1 days
Testing same since   169157  2022-04-04 06:23:01 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 3123109284176b1532874591f7c81f3837bbdc17
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Apr 3 14:08:21 2022 -0700

    Linux 5.18-rc1


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:25:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:25:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298592.508680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeUo-0007xO-CX; Tue, 05 Apr 2022 08:25:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298592.508680; Tue, 05 Apr 2022 08:25:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeUo-0007xH-96; Tue, 05 Apr 2022 08:25:02 +0000
Received: by outflank-mailman (input) for mailman id 298592;
 Tue, 05 Apr 2022 08:25:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbeUn-0007xB-8A
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:25:01 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e06a7468-b4b9-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 10:24:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e06a7468-b4b9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649147099;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=N/h3seUITsDLiOjX37aALlKnBwlXbSQIyPope24QLmk=;
  b=OCctpRAcLpR2qCA5Coqc5KbNcmBg9CkApAdNMJUu48MUOh+LPLvkxHG3
   93E62mv1fZ6SUanKxi5J2Cn7nqTYfMDNg9kj+y1+s0PPG/qrNjEakMzem
   cHPcPJFqQpODDtvKknzDl0OC5HfOWOYrGxb06GnCR+YpE85cAfdhxLBlL
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68020584
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:bSYuYKoL8+sOz7zjd7UTdoMM/aFeBmIPZRIvgKrLsJaIsI4StFCzt
 garIBnXaavZMzbwKosjb9i09R8CvcWGxt9lGgtsrC0wEC0X8puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y6q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBL4z33+JFdxNkVBpTNrR/5bD2CiDlmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZpBM2IyPEiojxtnPGsWVJZlsd+UlFrASCZTr3K4iPdt/D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUryTrKzPLw6TrePUUPVwdcZ+0N7JUfEGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdQ2mY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtAOzARVodt/xory9U
 J4swZX2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1Y55eIWO0P
 BSP5Wu9AaO/2lPwMMebhKrrVawXIVXIT4y5Bpg4kPIQCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGMqNRJcA9TcSZgbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3TApy/QNsDhapCkE8=
IronPort-HdrOrdr: A9a23:0T7lXakknsgvvqp8Lrh9jcdhMFnpDfJP3DAbv31ZSRFFG/Fw9v
 rPoB1/73TJYVkqNU3I9errBEDiexLhHOBOjrX5VI3KNDUO01HFEGgN1+Xf/wE=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68020584"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mM+/vituZEfmKatiNkPCbygLjIiYT+tgeHHpNHzsrOYIxdfciYe7zVf1a2SlcqFBD5ahIUoMALhVvGQi+41TcIOp6kWfn2AOQMz4Xl8b2n82qCKLoYfLqRa2tl+OVuDTc0EB/mAR4uoPsc2FkLx+57LHrDXDyOxlkAIoZSH7tltmVCVGAFeAfY166QNBTa4jNbYK+fv/mjXJv9vtTK6zBbXphCebp1eYTQZCeF1y6EUMJGjBghzLX9CUVNchMbad45wcJgEKc2lmFJ5jc4DOByNVH38i0jeTjYcXTWQX0JumQz9tKBIypAEZzu2Y8vOu2NCBdNyoLjL8Odr27AV8cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GMZQmSJH2ZVsEMbRbL5QK2unD0ejft3PjP6FCyAko0c=;
 b=AVsLvPrLLPtIgC5o894bOvuiN8ZvzqcZjp4gU1wXISC0/4JSVMCphvQrpq9iH2py6LYAPh7V/Rk69ZAWUe7XMOX1McYfZh0u4vBuufwF/dx0vMmlz5gBMyL1+oPlSTYb8y0oLq8IiflFwGgShRO/fdJkrL6loZjS8Oq302p1eXw1hvi6M+u0A+Zrd2c3Fce+7SHeUM8FcfjInj6DC6v0XdclYUlHfeR+PZUIfx7qJsJx64YMyNXXmGuY6a+GkrKvQHvSiRowOVSXHHxXiHybWwiwat1tv/5F49FiadeCaaQpKKOhtDOgwHdnOpCweN5w7T9d8FkTIJNX66SzszSWrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GMZQmSJH2ZVsEMbRbL5QK2unD0ejft3PjP6FCyAko0c=;
 b=VSrSwSC7cywjL6TWpuaGUWF+dohTFHe4husjpycm2/U3q2om1PwCy1EymJlyAnQN4pXQKuBX0KFJ2lCeHWhe3w3O2bQarZYqY7Tkng7lJkOXcBUp/EFg/beDPDgnc/lkHEpqhzTXaPeHjtq4e8qP3vkkxo95WkpbjVbzYNvFyIc=
Date: Tue, 5 Apr 2022 10:24:48 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics
 modes
Message-ID: <Ykv80Hgqp2oxwZ4S@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
 <YksFeCB3bcXBGfDe@Air-de-Roger>
 <aca0954d-e235-4b25-458b-1183a7471b12@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <aca0954d-e235-4b25-458b-1183a7471b12@suse.com>
X-ClientProxiedBy: PAZP264CA0121.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:102:1ef::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6f4c2b45-5a37-4b0b-3820-08da16ddc294
X-MS-TrafficTypeDiagnostic: CH2PR03MB5237:EE_
X-Microsoft-Antispam-PRVS: <CH2PR03MB52373B71E5C328F2CEBBADA68FE49@CH2PR03MB5237.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VQEE1Lqt5KKubup6z8f0OdeTOfyWmUEUw/Bt4U5dBdKQMvnfbDokxBv37TP5xhDH6frFrmU/Jkl77grct8O20xQIQL2tU1Y7D8tseLdVr9E7VHSQ56PdiTn9LluC18YFzPE00Q86Z3xkEoxGYdvtBVL23favXnr0w4GMyhXfvkQASZqCFzuDmWUDgrwovFcp8WCK3U6BjxVJpdSAAZ1DwPqy5TxSXh1iczMcaHO077YYSHx+NPE3kja22cG2ZmRCfITw3SQ7FE5VwgshsMDlQx4TZvrCX0WNwFbmCRrx5yShIognplTz+2tQHOs+UbX8z9dG+2qcDP4m68PI9cfpArYxuWZnec9Gg3FPBdoXBR/VRrSKCeX/YiJkvBLLbmJcCJ1OyIVNNm/Slaa3wn7dhqSf1jFcEdYR0FMtWgxYxnTMiQiSok2wg7Zh4cpJXmerTKF5jSU2TLKzyo5EglWVSvkZM9Mgw8LjR/f0dMz0W8EKgmQaTVfqoc0cgB2AWszGIlCI+8RRtrGL+rdp9w8Cwmf6c9uHZzarVMjJ6hdtrPrrlaPRiw7MPxiT+UA60cgkDTme5sEVHYSi9iT6UIJaI7vsNdW2iQN8aLRQNo1KKIDg5DnlqBZSQGlZoVC98mQUvc3kGGrGAg6e3yzPUaGsgw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(26005)(186003)(38100700002)(5660300002)(8936002)(82960400001)(2906002)(85182001)(66556008)(6486002)(6512007)(6506007)(6666004)(8676002)(66946007)(33716001)(508600001)(66476007)(4326008)(9686003)(83380400001)(86362001)(316002)(53546011)(54906003)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1VyL1NVYTFXc2NYdXVpc3lQTG9ZYmE4Q1hIQlhrMEdZbGpuYWZvYWY5Ukkz?=
 =?utf-8?B?Tjc0STBoVGFpeExzUG9Zem5zVmxFUTJQSmJVRCt0UE5jd2NYRHJjZ2RPRTZO?=
 =?utf-8?B?aFNQcHhoZkl6VVN6QkJDV1U3VVMzKzZSVm1nWHNiSjArSUcyVmtvMXJwL2dx?=
 =?utf-8?B?UUoyK0tYYVZJdTNtOFg5dzhPd0k3S0ZyUkJoUDZzcnp4UE9FRHpaVHd3UXRV?=
 =?utf-8?B?aWFFODJCVkw2WC9kZTRGck5DdFZSbG5qV1Qrdyt2dFordmRoYmxzdmJ3bC9h?=
 =?utf-8?B?UVJkOGQ0anlyQXpLaTRnZE1UQVFLVGxFU0NtaGM3STRqTnFCNnM4cnFCb2Nh?=
 =?utf-8?B?d25IMXVlT1R3dm11YmMyWlNrT281NC9NVUo4TTBvbVFQSU5GeXFuUE44OU52?=
 =?utf-8?B?SStuMDhReWVxVnpFaEJZTWdQUmpTRnZLaGt4dEtSaDhiODgrYTF5UkV3Z2N5?=
 =?utf-8?B?ZE1FMFJxMDRndTEyRGY2ME9OcGRaSmZlWXFlNEVKWkJ1R2U2eWpmMy9LS3lU?=
 =?utf-8?B?RmhidVlmeE1lR2xkMitPZmJPWmxQYWpQZmZCVnN5dllOYitIK0pQNHhaNG5u?=
 =?utf-8?B?UnZPYms5eVF5b2JEV2VNWk1SeVlvK0VIMlBzUnphd0N3SGlqSlBGN2UzeERU?=
 =?utf-8?B?cEVmVlgwTWhFdGJYNU4vWHpnNUdYekphT0pPbnBUZXMzdUZROGVpTTJNdnQ5?=
 =?utf-8?B?akRFZjNNVU0xN2hiQldWOHY4MndteTVWdXJYSlhXbnlYTk8rZ0VDSDVXa0dI?=
 =?utf-8?B?TWpwZUp1SDl3cFdVTzVsMG1lb1h4cWRYUDJDNHNseG9vZ01NM2VHZkRNWHFZ?=
 =?utf-8?B?YzF4bHBVMFdvZHFFdGNEektSVnNUUjh2bXJ5bU1NcjcwSUF6Yk5EZWU1TlY4?=
 =?utf-8?B?WnF2Z1MvVmdtVkVvQTJjRDhiM05TVUMwbDkvaEVWZTM4ekRURjNUV1Joa25B?=
 =?utf-8?B?bVU2dkN5ejFrc2tSRWxKRFgrTHp0ajlYSkdqZjNpbjhudksxUmZjcklYVDBE?=
 =?utf-8?B?WExkblFPc0JqVUdtc2ZTcHNVNi9OejJoSzdBVGpDa2ZsdStvaElCMlZlUmN5?=
 =?utf-8?B?c1dCZ2lZajJNRXNENkQ1SGk3R1MxRmJHV0drL0toRkl4MzdBdld2Q09adUxC?=
 =?utf-8?B?NjFGSnFDcDdXR2hFMjM4NnRPUDlqRGJ0cXdVU3V5dWJyZmE3b2lPaGtESjly?=
 =?utf-8?B?TGNqcVpjTEUzSFV4OFpZNEVobGtiTWovbzk5U09TSGlXaWpsQVEweWgvQzJv?=
 =?utf-8?B?dU9iQXFET0JtREhMdmlHQXFnS0JlWldWQW9vUnJGUFlHTHFCWTQ5bFdOM0Iv?=
 =?utf-8?B?TUhhanNpMVdyN1ppeHF4MWVQQ3VDaUtyelhmZm1YOXRkWnhHQ1RrUGNtUEpW?=
 =?utf-8?B?U1k1M1EwZmQ1TXV3R093NW5rbG1wSGlnUGRUZmdBMnFpM0dMZnYzem41cTdp?=
 =?utf-8?B?SkMvRzhyT3NQV1JxdlVOdGVPRG1aTjJJRnJmNURyN1NRYndlTUQvSG1BWG9F?=
 =?utf-8?B?Si93Z0RiUDhFaG5hVkFvU0c2SHI3ajVhaU9oMmh2THlJV2JDN0daWnV5aUtE?=
 =?utf-8?B?MEhyRHBRV1oxUjRHOVBGTk9qMzZlYmRaeTBCbkVUeTV3WGFmeUNzcnE2NS85?=
 =?utf-8?B?eVZzQTg0blJVOGVOOC9ocEhWeEt3TzN0MERiM3RYcTVsWVoxdW0xRk11UE14?=
 =?utf-8?B?LzBBL1hDRzRxTklEM3paOU52QURYZWUzVVFoVXZCQTJwS3RtUXoxL0tMbVZI?=
 =?utf-8?B?M2pycnUrdyszQXg4THpNRkgrd3RZOHBNZ1pJM0syM0xVKzk3S0NUMDNQeXRQ?=
 =?utf-8?B?Z1lhZi9oUndLb3lyWmVmNmJRcGQxaVh1YWNSVTV1Z2JNbllGSkJsR3RCK3ZQ?=
 =?utf-8?B?UnNVWFNlOE1TclpFb3g5RmdEQk8zMWg5L1VhcUdtaTdNRGtILzdWOFV2aitL?=
 =?utf-8?B?VmZUK1JOalVnQVBpZXFHQmxQT25WeDVTVHJUdFhPREhwamk2VmZpQTZ3OEs2?=
 =?utf-8?B?TlI0ZGRTUFBOMlpkTitiSVNoNXdtbzhwRHpFNWJIMFJPcTVlYW41SnY2Vlk2?=
 =?utf-8?B?TDJvKzZSUUJNSktBMmsrb21ZRkhCcGZDcVNOQnBpN1F2TU4wT0lNc28yTXdW?=
 =?utf-8?B?UWd3ZXQ1aG94T2wyaklEZXI0N1dHWTJRd3lIUFBQUnV5K01mdlpIUmxrelpV?=
 =?utf-8?B?QkV0eXNqVU5acHNDMTJPWm1QbGRBb0I5UkhFdUVubU11aHcySWxIa1JlODhr?=
 =?utf-8?B?dmdDRHJVaVRyWDJwaURZbzY2eVZwckVTOGFaalBJZW1JcTJGbXg1cUlPTmNG?=
 =?utf-8?B?dnROMHNTRzJKajlZU3I5RkNLQTJ0bXFGTTdwQzkvQnFlbWxoOEVMUlJDNnBT?=
 =?utf-8?Q?5/EONjHokjY0hYjU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f4c2b45-5a37-4b0b-3820-08da16ddc294
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 08:24:53.5673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lzu/XybQ+nkplx09Fn9ukuYzUCrgboR4U5EnCj5upFXIeDng5KMEZqeT4Dw+ttPW216MgadsifC7J9JXHJUi8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5237
X-OriginatorOrg: citrix.com

On Mon, Apr 04, 2022 at 05:50:57PM +0200, Jan Beulich wrote:
> (reducing Cc list some)
> 
> On 04.04.2022 16:49, Roger Pau Monné wrote:
> > On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote:
> >> GrUB2 can be told to leave the screen in the graphics mode it has been
> >> using (or any other one), via "set gfxpayload=keep" (or suitable
> >> variants thereof). In this case we can avoid doing another mode switch
> >> ourselves. This in particular avoids possibly setting the screen to a
> >> less desirable mode: On one of my test systems the set of modes
> >> reported available by the VESA BIOS depends on whether the interposed
> >> KVM switch has that machine set as the active one. If it's not active,
> >> only modes up to 1024x768 get reported, while when active 1280x1024
> >> modes are also included. For things to always work with an explicitly
> >> specified mode (via the "vga=" option), that mode therefore needs be a
> >> 1024x768 one.

So this patch helps you by not having to set a mode and just relying
on the mode set by GrUB?

> >>
> >> For some reason this only works for me with "multiboot2" (and
> >> "module2"); "multiboot" (and "module") still forces the screen into text
> >> mode, despite my reading of the sources suggesting otherwise.
> >>
> >> For starters I'm limiting this to graphics modes; I do think this ought
> >> to also work for text modes, but
> >> - I can't tell whether GrUB2 can set any text mode other than 80x25
> >>   (I've only found plain "text" to be valid as a "gfxpayload" setting),
> >> - I'm uncertain whether supporting that is worth it, since I'm uncertain
> >>   how many people would be running their systems/screens in text mode,
> >> - I'd like to limit the amount of code added to the realmode trampoline.
> >>
> >> For starters I'm also limiting mode information retrieval to raw BIOS
> >> accesses. This will allow things to work (in principle) also with other
> >> boot environments where a graphics mode can be left in place. The
> >> downside is that this then still is dependent upon switching back to
> >> real mode, so retrieving the needed information from multiboot info is
> >> likely going to be desirable down the road.
> > 
> > I'm unsure, what's the benefit from retrieving this information from
> > the VESA blob rather than from multiboot(2) structures?
> 
> As said - it allows things to work even when that data isn't provided.
> Note also how I say "for starters" - patch 2 adds logic to retrieve
> the information from MB.
> 
> > Is it because we require a VESA mode to be set before we parse the
> > multiboot information?
> 
> No, I don't think so.
> 
> >> --- a/xen/arch/x86/boot/video.S
> >> +++ b/xen/arch/x86/boot/video.S
> >> @@ -575,7 +575,6 @@ set14:  movw    $0x1111, %ax
> >>          movb    $0x01, %ah              # Define cursor scan lines 11-12
> >>          movw    $0x0b0c, %cx
> >>          int     $0x10
> >> -set_current:
> >>          stc
> >>          ret
> >>  
> >> @@ -693,6 +692,39 @@ vga_modes:
> >>          .word   VIDEO_80x60, 0x50,0x3c,0        # 80x60
> >>  vga_modes_end:
> >>  
> >> +# If the current mode is a VESA graphics one, obtain its parameters.
> >> +set_current:
> >> +        leaw    vesa_glob_info, %di
> >> +        movw    $0x4f00, %ax
> >> +        int     $0x10
> >> +        cmpw    $0x004f, %ax
> >> +        jne     .Lsetc_done
> > 
> > You don't seem to make use of the information fetched here? I guess
> > this is somehow required to access the other functions?
> 
> See the similar logic at check_vesa. The information is used later, by
> mode_params (half way into mopar_gr). Quite likely this could be done
> just in a single place, but that would require some restructuring of
> the code, which I'd like to avoid doing here.

I didn't realize check_vesa and set_current where mutually
exclusive.

> >> +        movw    $0x4f03, %ax
> > 
> > It would help readability to have defines for those values, ie:
> > VESA_GET_CURRENT_MODE or some such (not that you need to do it here,
> > just a comment).
> 
> Right - this applies to all of our BIOS interfacing code, I guess.
> 
> >> +        int     $0x10
> >> +        cmpw    $0x004f, %ax
> >> +        jne     .Lsetc_done
> >> +
> >> +        leaw    vesa_mode_info, %di     # Get mode information structure
> >> +        movw    %bx, %cx
> >> +        movw    $0x4f01, %ax
> >> +        int     $0x10
> >> +        cmpw    $0x004f, %ax
> >> +        jne     .Lsetc_done
> >> +
> >> +        movb    (%di), %al              # Check mode attributes
> >> +        andb    $0x9b, %al
> >> +        cmpb    $0x9b, %al
> > 
> > So you also check that the reserved D1 bit is set to 1 as mandated by
> > the spec. This is slightly different than what's done in check_vesa,
> > would you mind adding a define for this an unifying with check_vesa?
> 
> Well, see the v2 changelog comment. I'm somewhat hesitant to do that
> here; I'd prefer to consolidate this in a separate patch.

Sorry, didn't notice that v2 comment before.

It's my understanding that the main difference this patch introduces
is that set_current now fetches the currently set mode, so that we
avoid further mode changes if the mode set already matches the
selected one, or if Xen is to use the already set mode?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:27:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:27:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298596.508691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeWo-00007y-PL; Tue, 05 Apr 2022 08:27:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298596.508691; Tue, 05 Apr 2022 08:27:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeWo-00007r-LS; Tue, 05 Apr 2022 08:27:06 +0000
Received: by outflank-mailman (input) for mailman id 298596;
 Tue, 05 Apr 2022 08:27:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbeWm-00007l-VG
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:27:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28b1e1c7-b4ba-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 10:26:58 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-Q45Oclf1MmmJKJGjzggvIw-1; Tue, 05 Apr 2022 10:27:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM5PR04MB2996.eurprd04.prod.outlook.com (2603:10a6:206:6::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Tue, 5 Apr
 2022 08:26:59 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 08:26:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28b1e1c7-b4ba-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649147223;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=d27+30hA0jLtQPGYSSic12DifZW7BygFpuU8vKCLWx4=;
	b=HeBIfxetO8vHZ6kWiPIMXU5DoM7AaijzUhXnv9STi4gbq25GJnAP2zvnPyEjXFVSN/Wur0
	AEqf4aau6ZAQ98H2SaO8x7iC+TnBnivDT0PmuvmGyCg9Qqxlx2TJJ/3wYdf9oUlFM4Q96d
	l4VIIcDLs7asMTUIJvv4EnzkdOP0peo=
X-MC-Unique: Q45Oclf1MmmJKJGjzggvIw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BgDz6tu2L9QoeUPltQN/4QwM9XURQxjVhYV9gt3C903Sd3RvYAxhALhj7yE8JQU7XigVx3oFeWBQsp4u4Oz9U9KiP6qn4WKLCQzgVJgrSxh8z7GiXKwcshbsJbvo40/QEvnV/Wsxn+3PrJYoRTE+m1qoDXh7URZ7TTu4Y9JOCFcDVl4KxWcHNntghYK92IaGD3KWqeJhYItOlX2a4XCYAvevaixx35B59yb/Vbi69aROq5QETO3qpxagzDMuVggucOW/wMbshOJ4YXFwPFW03H/0QK48/53LV8nxy4GySIerO+xfMz5RBk5uusia3ENiW8pDi8jkmmegyp7p6ttuVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=d27+30hA0jLtQPGYSSic12DifZW7BygFpuU8vKCLWx4=;
 b=ePdQ1WyUzIvzBM8JcGi7wE+mK/VWBu4jG6T5iOifNohNrZnTOTqUStCeAwkpxzD2YJoV9FDkOsI9CD20ZmESd+l+2rvvnPGGGi1LW/Icq2sUiKoxD89+v/tPeh3ZwkzxtJpSI+jTIS9mj0ET2ygy0GeZOdPpalZRQEzDbzN4aFsdJCCzP1E476ChZM52iDmNELqUhOHL8PFbzTLQNpcj0ZNYBS3xPnvZhL+fsEPQMw7A1OaTnkA9anzsBZ8oXO2X1krj5KgSjX5xIpAUcWJhT+TfeDF1KlXWl7LL/9Qsj7pztl1k4z+HI37g8XKc5xfc3mDt5U/1lOlF+SKg+TyrBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f1c3923a-9201-c200-1b1e-9a258d47e64a@suse.com>
Date: Tue, 5 Apr 2022 10:26:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 2/2] arch: ensure idle domain is not left privileged
Content-Language: en-US
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-3-dpsmith@apertussolutions.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220330230549.26074-3-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0049.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: da1c355a-6172-435a-8160-08da16de0d5b
X-MS-TrafficTypeDiagnostic: AM5PR04MB2996:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB29963DA10700B9E642F34256B3E49@AM5PR04MB2996.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t28wN8jReFfC/lblkNNhqLz42+e2gw8i3eWqj14RcRPL6oGu9L5t+e7LIERY1pbAziMtSzamPssq/4XchVfq43GhuH7jHEsm/fEN+pkUDdJLxgARD0GZSeHHCKz/8rbWcF4nszAXnEhNSIPnBWig4Biq2t1V2woFWkKNGUab2RAPSiirVq24zvbTCO5/ZNTanAdNot4tfHyyFTQuw1Vnpid2695CFTKFjX9BQWR1JwB6SuEqeSqbjhZ09cGab3trdLU6hZC0/xoq8HrPH2Z71VNL+rMxHPJGCjG64NOPytbiak+d/am0eF99pv40NfI/nzdM2xHwpkmBQmlUbmFwuXsWWVbQ4MVTTZ+ahuouWOVhITd60Duxb+2P7wDWix+vwlPTgVD1bQUqpFFF2s0l7kZgz0c1xykyCbuI8LvpK6lJMyGdd5zpAFzNaVJlKvMlWqKJ7hJVy86t5zAT407O2dzpNEhmDyQLxcBFCW0J04WdtTXcR0oKqU0xXZQLfzVdlr5WwJYp7k9xlBdOW/gL4Smh7xmtAVT/FJJXEiN7N+DqSF3ntGpj7g4kO/u5sE2EiNw9tjkMJtSCNORcX56vjU+DT+nPO73nob9co4c7RPoWc4f82PtNHe7MtZvMhQBE5wNSWQBiToofIz6XVxU3oCmMeSG401hyePAOWqjSHcl6K9lOxK+Q14vcwUtUX2wUJoPzf6/910iPoHj6IjnxGFzCLjDilqolSPpmPHuMEdg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(36756003)(8936002)(31686004)(508600001)(7416002)(6506007)(2616005)(53546011)(186003)(6512007)(26005)(66556008)(8676002)(4744005)(38100700002)(6486002)(5660300002)(31696002)(4326008)(2906002)(66476007)(6916009)(66946007)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YWJ0S3lLczI1N1BQbVQrK0RsM0xLYkNEQmlPMHVHMVE0anZZZlVkYkxNcndG?=
 =?utf-8?B?NFNhSW1pYlNDNlkybnVnaDM0UXpBWlNUSWpLVG9WcjFxZUJaVmxnZzJXaU5C?=
 =?utf-8?B?dkc0ZDhJL0VySS9PeU9FN1dBRVl4a1NUM0dLMFlkQ1pWVCtjaHpiYlROWUVw?=
 =?utf-8?B?YUpSVk1TYnVWeEFIRGdVVUhDRnVxOHpQcDV4eXZ3Q0t6dWFSeERycDRjRHBh?=
 =?utf-8?B?UmxadHZQU0tHeEpZNy9oVlV1SmpkSEdRcktnOUc2TlpKZmhXOWI5enUwK09a?=
 =?utf-8?B?TzhrUGhkaEhZckNiVVhkeVpETGp3RWtxSnRYSUlPSmZtcTlKc1k4WFpvVjlm?=
 =?utf-8?B?V2tBRGc2MVJ5K0xNNDNXUnA5RGdSSjh6bElOMWtvbzhvM0E4dHRGL2ZHd1VH?=
 =?utf-8?B?NEoveUprL2oxOWd2S0IvMjJlTCtQbUY3T2hrZHczYTIwdHpNQ0lTdjV6a2Y2?=
 =?utf-8?B?bU1nUGg3UHpBZFFia2p6clFHaUNIU051WFVRdXpqZTlBMng1YlNXVFJWa0tW?=
 =?utf-8?B?S0pLQ28yK1dPM3prYlNkY2lJT0IxbGdTOXZyZVNLU2IwWlBtL09zZlpYanFR?=
 =?utf-8?B?MDZRUXBFd1NsTTU5Tlc3RzRQWWJvNy91dDVmYXg3TDROVTZ0TlVMZlJ2UXRp?=
 =?utf-8?B?V2tpV0FhQXltRjdwSFVubTBMTmVFRVpncWo4a1VhVzBxWHJJc2ErdHJCbldO?=
 =?utf-8?B?NjJjMDRNaWRmRTh0MWtXb0ZnWWJwa3FCUWRmTE44TjlxWXkzSURnUzB2eHd6?=
 =?utf-8?B?bEFnOW1wclJzeUJzdHpleWZUckxMNGovRzJta21CRTViOEFKL0pRSWxvOEpy?=
 =?utf-8?B?ZjBaR0pVblZKKzVpUHAzbVA2Rm82SFh5ZG0wYTJYcWNVOUpobDNEYktYYWlw?=
 =?utf-8?B?MC9tbHlaN01McDAya1VYTEZTYXl4cll6NkdwM1JOMFVsTzFobGpjL1orVjNM?=
 =?utf-8?B?MjFhY0c5OW8wa2FKSlhQaDBFZTlYaURVOS91a3NpQkx2TlhoUzQwamh4Zitw?=
 =?utf-8?B?cXh6MHNIYkxOYTdPY0NLYUI3Unc3a0FXckRmcjF1ZkZzbjJ6MDB4eEpmY21a?=
 =?utf-8?B?d3NPelhhdlRIa3U1aURZdEppeDhHZVByYktrT2JBaVBZNTVZMFV4OFkwRkd5?=
 =?utf-8?B?UmxWLzJrZStBb2xqdmtYRmhqcXpHY2tSaTJrTk91OVI2TlRwNjMwK1JnWkJ3?=
 =?utf-8?B?d3RVOE12RjFqMTlaQkQ5bEljU3JrS0lsN3lZT2h0eE1HWnl3TFExWCsxTUUw?=
 =?utf-8?B?UzJTc2dEbUxoYS9zb29vVmM1Nk5xS1RjbU9pRFhYSEthR2FiTmljMHduTWt3?=
 =?utf-8?B?bFZqd05taElML1NyK2hQbWdnUTZ6Sm12YUhtSlMxbm1zNFZEaS9kR1FoRS9H?=
 =?utf-8?B?MVdZbEUrRWczVEFZeVMyY2RTcFdMRmtDS0F5YW1QUSsxZnk5d1g3NHF5YmZD?=
 =?utf-8?B?V2NXL1RyOFdlZjNBWHpLcFdkU1NCWG9OMUVXcDVWV2ZCZGFhY1YrdTJ2UXgy?=
 =?utf-8?B?NWdQM2xLMG5HYVBKWTZNby9SZlg1OWRwSWF6Y245enROYitJb29OQ3Mwd2RV?=
 =?utf-8?B?ODBVaklUd3NKZ08wS29OcHFScFBUZDllMUg4amhmdzljVW9qOFhHRGhqTEkr?=
 =?utf-8?B?WlVZYW83TjRESFpSb1o2RUEybmdmUk1oY29STnYzRDlmdWI2UlJtMWFwWERE?=
 =?utf-8?B?UldQTE02WXl0SktIQ3k3V2srOTBGcVVmK2tqaEJ5VTQ0andjMWtRYmFwMmF1?=
 =?utf-8?B?YW5TVGpVOG5aL25LL3ZvblBNRmIrOGo4ZVJwR2pkL2ZsR21DMVZ5SW4xazRO?=
 =?utf-8?B?K0p4eHFrRDVDME16R3RvbnNGNUFTbFJXRzBud3JZZVhacWE0ajZ5QnJxNWJt?=
 =?utf-8?B?OXRMd2k5Z3NNdmhyeEhxUEtTSTl2TWNCbEhWY3BpbGphMmFScm5QWlpIZnJQ?=
 =?utf-8?B?TmNWZFA1REhpQVM1RXVtcVdMQ3VMYzB5dGEyUE93Z1V2Z0tYUmZHVEgrejFw?=
 =?utf-8?B?Mnk1V2I5OEtqa21ZOXBNVXFwL292V09FNmFSeUkvaWkyYkRGaDcrcHRZRjJT?=
 =?utf-8?B?eUpWYll3ZHVGQXFjNXd4NE0zd1dXYkRIOGZDTkxHTUlMNXIzUTd5VUY2RU53?=
 =?utf-8?B?TllPN0RVR2xJRFRpSW5UTkxMRGI2YjB6anZKZ3FJQ1hPZkpBQVFlSW5yQkpP?=
 =?utf-8?B?andhajFadlBpNE9rK29hckgxeXl5TkM0b3JndFFBYUtWYS9yb1QweXZSVStI?=
 =?utf-8?B?RDRKdGltUXhOQmdEdzhNaVBRUWxhWDJnVktONWJXZjJEVjBFa0lmZVpvT2ZI?=
 =?utf-8?B?NnVZMjZBbXJ3MFlVc3d2cmpYMmV5WHY2U2pZM3pwMjlzU21ZWGJXdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da1c355a-6172-435a-8160-08da16de0d5b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 08:26:59.0403
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sz8K+uMA4q+v68RVNqdCA1J0cWCPIp6uoCu6zMP1Ib3ynUfKAdRRYV1aghYzN+vhFsnm5b5zKEmPLtTWJRAj9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB2996

On 31.03.2022 01:05, Daniel P. Smith wrote:
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -589,6 +589,9 @@ static void noinline init_done(void)
>      void *va;
>      unsigned long start, end;
>  
> +    /* Ensure idle domain was not left privileged */
> +    ASSERT(current->domain->is_privileged == false) ;

I think this should be stronger than ASSERT(); I'd recommend calling
panic(). Also please don't compare against "true" or "false" - use
ordinary boolean operations instead (here it would be
"!current->domain->is_privileged").

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:36:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:36:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298601.508702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeg7-0001c4-NP; Tue, 05 Apr 2022 08:36:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298601.508702; Tue, 05 Apr 2022 08:36:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeg7-0001bx-K4; Tue, 05 Apr 2022 08:36:43 +0000
Received: by outflank-mailman (input) for mailman id 298601;
 Tue, 05 Apr 2022 08:36:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbeg5-0001br-T2
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:36:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8396687b-b4bb-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 10:36:40 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2058.outbound.protection.outlook.com [104.47.9.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-dbij_fAPMk-KUaycs_s-_g-1; Tue, 05 Apr 2022 10:36:38 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5656.eurprd04.prod.outlook.com (2603:10a6:20b:a8::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 08:36:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 08:36:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8396687b-b4bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649147800;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bmyRIpl/q4fWYDu76ZO+S4r6GStZphPjCKQCNFKzn7E=;
	b=aZn4drC5YWQm2hyBUhwr9fW4qAf+RgZCWttL0Kkn5ZzUC+gIukYN7psnKsc5ksF6FoTLJE
	yBMB/o+tzQvuFaLxRfbRcJzvXbL3kFM7FFoX7GjT6MWOFV7YkMCT/oRkXY7IadMo2r50gJ
	rYBwMjvFdrBsbLqPCAf68E3zzs30AuQ=
X-MC-Unique: dbij_fAPMk-KUaycs_s-_g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lmUZptHR1/R0/o5YIGwjZ+6fln/YMIa1ZdMwYkTgmVpmYO3rBIFr73aWPKy3fBDKiKyHw3r17obY75Dc95DRTobU5RwMjEmBSnNw6i6Ok9dXQ8FWinUHQ8YFbxQDoDxF4JqXf4p/cTm2Uh95ARde5VMBoypzel3ojGBxTF3SaAR+O0R3C5zsNim1zEnUkWkb0Cl1t3zR2KWRCbGxAJE513c/+EYFNLIODdgJoXKD/HPNQi3OiBzLdp15sTcrl6Rp0xaNcRBk4lkUOG1TpkKnX/G7YQ61nRNUZY+JALLxtNe7FT5cdji9BveWcC68TTl6zt82Xqye4l/g8odOmPhpbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Yk0fV4nj4m406HYCG/W4dHjIJKapYN2w3JVb2ycNGbQ=;
 b=Af9Ur295PC2uJ5CAJTsVRqdCeskByauSm5iu7ukATZm4jD3OsKYJyt+cAClXx7nZrZp9kLAODQo9zPK+2rO5NRW4jCZnZQB6fVgQnAWIs8qePtWhkC8euERmPiSQOVhMcQKMLVLNH82g7SDtK2uoF2eFNWO1QSmsO6/P2qg+E8mnke75l70NYNcGzH69ihNDGR81mSmaJDesX7RrD5zmht/Y2J9hk6VkqkzUTibh8PmKmr1BA0IHEdivshoDwv0VcND1pNblND6KocwLKbOGnoH8HisUmoy9v5d4H0lXqIkBwRF3Yx/MIcZBknKWwufGN48ZQUyhj5sAMNusYc1jqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dba31d91-5a5e-8ca3-5d10-e6425b0da9bd@suse.com>
Date: Tue, 5 Apr 2022 10:36:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics
 modes
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
 <YksFeCB3bcXBGfDe@Air-de-Roger>
 <aca0954d-e235-4b25-458b-1183a7471b12@suse.com>
 <Ykv80Hgqp2oxwZ4S@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ykv80Hgqp2oxwZ4S@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0201.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::19) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b497855f-c518-4c8d-845a-08da16df6588
X-MS-TrafficTypeDiagnostic: AM6PR04MB5656:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5656101907110D4952D829FCB3E49@AM6PR04MB5656.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PM14fVuH8t3yiysA8ZtYwNNJAw2qHz8Nv3/bWBys5GhvIFSPPkodsLRkGdemPD0syEYtgBJmvyf3tbTZWG98+8Q9CAVe2gOdJ6vyefwRPW8And38sxfMZf80Ys3iwlpVPdaPHzNh8GqmhRJq6okvR5LMYsM5keBeIzcsd61DPevM/vQGLt1FsiVDANJgZEHAapPUNY0gh0nZwd/GlJe+AUTiL+udDEblwxomrQCpjoX0BzxywtN1ACGC1HTZHCeGJ0SVZBQXrY0RZtxSuvtWqLhY+iFf9ijYlp/AQTPomgvjC3TVztiUkN4tOQl+dsBd2HDPJ5gVRhT2Lz8PpQbpinxlvEuLe5biTxQA8OgTkjBMsaZZ/VZGtj161XNvk7fl5v047lnz8yvI1LwloPuyghapmWgVlXA4pCXLvMYIb9itWJk+ISygh79/JXdRdcFAb4jV7XxraMV5T8YCOiI2/ebxULfMjdit8wz9Gdwx1c+JgFCF3PJeH79nMYn1bGYeJybwkwnURAT3LEt8t2SmWYWDW+8MR9/VlVE9BoCkzXC9nZYD8zACbSC3PLJ66rHX7E3AZLDwi71yPSRWgmYSHK4sNcRO6Ph1Ppy3gG6htU9dn2HfDVKeKnVGF9m4GcnPhKS4c5ScVX+0IG/+6iVVCSAjRFmBSng+roU9xoyBS6PTtWN31w2Lwp7ZhTNSFPStWtKnZXTP7szhaKkdWfOcT0ZLJLvcpc83prtbiCzNNA8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(66556008)(26005)(66946007)(83380400001)(36756003)(186003)(2906002)(8936002)(31696002)(38100700002)(2616005)(86362001)(4326008)(54906003)(66476007)(5660300002)(8676002)(508600001)(316002)(6916009)(6506007)(6486002)(6512007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7DLsbhW45jINZLn264D9P5Tou5lv8DO9i1pBfRRwJR8nsZ+3aHTiFbzSfROK?=
 =?us-ascii?Q?nBvV2FW6Lsi7CpUQE071jNCR2VrCyih5T2JxB9i7UhakB7jPcLQaidD0zLmX?=
 =?us-ascii?Q?5T0gZMekWQyuob5jIn1elv/s2Zh1lP0h0lonRIu4qTZeChyrYAdxgDl2f9nw?=
 =?us-ascii?Q?nHrQKRekcP83S30FhcdwR1Rx+t7poNOo454LqUyz2/ifR6p2KnH9OQ8bfEXZ?=
 =?us-ascii?Q?nMOIkS7u1c0oIotHxbFMslubRxOERC18BwCWiHTEkFUvSk2FfHDGnOvKM49d?=
 =?us-ascii?Q?1XXsz40mMn9NyWrL6cvdQeI1HjQAnztBsW2ONa4t/cwhi5WYHWtPoWLRVmSR?=
 =?us-ascii?Q?OVkAbsNLviEWWj8DbpCdEilFHiFTmTEA/AuT/Frug1WSUYxOkehJ3CbGleb3?=
 =?us-ascii?Q?z0alS+T0ExN2UgrHAaD9i2O4ytMX3jg7PjSR7o+9s9rVZpLeiOtF0uc31aau?=
 =?us-ascii?Q?gPjJXr96eV4kZKpLzk1goP6xeoj/ugH45u6Rn8aqzQZtI4C3kEKDP9sy+/9M?=
 =?us-ascii?Q?lvMB0H4DoVji6kjSa7IDgHU1fxxmjKr/k25jRm8Savkq2LHvie97ViHSGVdx?=
 =?us-ascii?Q?SwLStZjL0LRDFcIBqDFs0A9IAnPva9xWbPQbRrmOTe/CZoGC/5oAOlXrMnei?=
 =?us-ascii?Q?ggq/yOPJ+/X5diwOdUHXm9Tthsqkg1m0HkgWJmc76UzcpJZ+r+wdVc8r0aA8?=
 =?us-ascii?Q?m746D6KfvQaY0UBdtGEQwxmgeTbFzdiO9lne96XzF/cK1bLj0Y1R16cHSjfU?=
 =?us-ascii?Q?1eUk9BuxowLCOGwONe5nG7SsgU8mB1w3ggJRHzVkuadfOl8t4nzlB1ot/SpQ?=
 =?us-ascii?Q?o8rENAnRE7+p5l6lXtUImYBEvsYieAZsyf9cezisxom+Nc5IyhThOOuqGCnY?=
 =?us-ascii?Q?wjDapZY4RZLyCZo48xBoB/8K0pd5UvZ8lE0g+bKQAX2CBkBwhCq/YkZCohX8?=
 =?us-ascii?Q?mxa7WHf4qQ0pByyq+Lf24I9LsOSgMPaROtdY3keVC6QS6eoq/ZEafV986+AH?=
 =?us-ascii?Q?8P+trE77pNkZwUoSkHjADFW0yHs1XOh54t9lIjAUJUPkXg9rmUzpHVmElFv5?=
 =?us-ascii?Q?h7afHcYpKIx1i7mGUoEqUgHLpDmKWkMuMz4SXa7lhsgIB1CQnmM2BoCMuZA/?=
 =?us-ascii?Q?zw/4k0l0QdCTIObAozuZowlCv++8UmLWH7Mb2wPiyY1NN3t8ldZGoJmDLM//?=
 =?us-ascii?Q?NAhsE9xficpIxtz14dfmFrtq1Fv5CKnUi+9Zm7t5FBAkjdoV+EJFs/dMgEv9?=
 =?us-ascii?Q?FCfbwmrqiUaJEisXgN/1yFEaoPneDoDEbZ+wuhfcB64N650mQuN+lIZDZvnR?=
 =?us-ascii?Q?eJ6pQ2CRZ2U4BmEmeh4hkN/mDPZDVo4nUebaFQM9W8OBbYWN6yf3InmjvVZv?=
 =?us-ascii?Q?6R2Krz1L4MymVojYwirrJgN8B274p2HU3nrxBGIF7PNnO59007Yotbi0X0Yi?=
 =?us-ascii?Q?9F1sA393tsCI47LP3vYFjEfbm/JXBDT7PJM4ldp5jALd18ZY/EI2AK+TbEeP?=
 =?us-ascii?Q?b/JldL55yD6QSdHwqGD2JiL+iVod+MtY6Dx6gBPQWaX8gPbxa27ln4fATaO/?=
 =?us-ascii?Q?wXwNOoh57Spxa5NyoZ2mMvG+bvWV38RUddrcsOdg3EUXZMZKZ5y2qQ0r/iq+?=
 =?us-ascii?Q?EpKzdyQ6Jj+wj/ME/DSyiAZ5uRi+SGHsfu44A5Ecot74a4Ua5INEYKLrkTFP?=
 =?us-ascii?Q?4dRxrzFldMzuLSWJxESFjTM1Ma8j/zr3cfJOqyTpDdOno5m/K7l0dJL9NL5+?=
 =?us-ascii?Q?po3Dn7OyLA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b497855f-c518-4c8d-845a-08da16df6588
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 08:36:36.4559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LriHExCgSLfUg2PPfMpQPbnExVErCxyj8y1u0I9XN3wAQYKoGAXW63H3yh87sefNf/8IjtaqDEcmW4MfZvNauQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5656

On 05.04.2022 10:24, Roger Pau Monn=C3=A9 wrote:
> On Mon, Apr 04, 2022 at 05:50:57PM +0200, Jan Beulich wrote:
>> (reducing Cc list some)
>>
>> On 04.04.2022 16:49, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote:
>>>> GrUB2 can be told to leave the screen in the graphics mode it has been
>>>> using (or any other one), via "set gfxpayload=3Dkeep" (or suitable
>>>> variants thereof). In this case we can avoid doing another mode switch
>>>> ourselves. This in particular avoids possibly setting the screen to a
>>>> less desirable mode: On one of my test systems the set of modes
>>>> reported available by the VESA BIOS depends on whether the interposed
>>>> KVM switch has that machine set as the active one. If it's not active,
>>>> only modes up to 1024x768 get reported, while when active 1280x1024
>>>> modes are also included. For things to always work with an explicitly
>>>> specified mode (via the "vga=3D" option), that mode therefore needs be=
 a
>>>> 1024x768 one.
>=20
> So this patch helps you by not having to set a mode and just relying
> on the mode set by GrUB?

Yes, but it goes beyond that: The modes offered by VESA on the particular
system don't include the higher resolution one under certain circumstances,
so I cannot tell Xen to switch to that mode. By not having to tell Xen a
specific mode (but rather inherit that set / left active by the boot
loader), I can leverage the better mode in most cases, but things will
still work if I turn on (or reset) the system with another machine being
the presently selected one at the KVM switch.

But yes, beyond the particular quirk on this system the benefit is one
less mode switch and hence less screen flickering and slightly faster
boot.

>>>> --- a/xen/arch/x86/boot/video.S
>>>> +++ b/xen/arch/x86/boot/video.S
>>>> @@ -575,7 +575,6 @@ set14:  movw    $0x1111, %ax
>>>>          movb    $0x01, %ah              # Define cursor scan lines 11=
-12
>>>>          movw    $0x0b0c, %cx
>>>>          int     $0x10
>>>> -set_current:
>>>>          stc
>>>>          ret
>>>> =20
>>>> @@ -693,6 +692,39 @@ vga_modes:
>>>>          .word   VIDEO_80x60, 0x50,0x3c,0        # 80x60
>>>>  vga_modes_end:
>>>> =20
>>>> +# If the current mode is a VESA graphics one, obtain its parameters.
>>>> +set_current:
>>>> +        leaw    vesa_glob_info, %di
>>>> +        movw    $0x4f00, %ax
>>>> +        int     $0x10
>>>> +        cmpw    $0x004f, %ax
>>>> +        jne     .Lsetc_done
>>>
>>> You don't seem to make use of the information fetched here? I guess
>>> this is somehow required to access the other functions?
>>
>> See the similar logic at check_vesa. The information is used later, by
>> mode_params (half way into mopar_gr). Quite likely this could be done
>> just in a single place, but that would require some restructuring of
>> the code, which I'd like to avoid doing here.
>=20
> I didn't realize check_vesa and set_current where mutually
> exclusive.
>=20
>>>> +        movw    $0x4f03, %ax
>>>
>>> It would help readability to have defines for those values, ie:
>>> VESA_GET_CURRENT_MODE or some such (not that you need to do it here,
>>> just a comment).
>>
>> Right - this applies to all of our BIOS interfacing code, I guess.
>>
>>>> +        int     $0x10
>>>> +        cmpw    $0x004f, %ax
>>>> +        jne     .Lsetc_done
>>>> +
>>>> +        leaw    vesa_mode_info, %di     # Get mode information struct=
ure
>>>> +        movw    %bx, %cx
>>>> +        movw    $0x4f01, %ax
>>>> +        int     $0x10
>>>> +        cmpw    $0x004f, %ax
>>>> +        jne     .Lsetc_done
>>>> +
>>>> +        movb    (%di), %al              # Check mode attributes
>>>> +        andb    $0x9b, %al
>>>> +        cmpb    $0x9b, %al
>>>
>>> So you also check that the reserved D1 bit is set to 1 as mandated by
>>> the spec. This is slightly different than what's done in check_vesa,
>>> would you mind adding a define for this an unifying with check_vesa?
>>
>> Well, see the v2 changelog comment. I'm somewhat hesitant to do that
>> here; I'd prefer to consolidate this in a separate patch.
>=20
> Sorry, didn't notice that v2 comment before.
>=20
> It's my understanding that the main difference this patch introduces
> is that set_current now fetches the currently set mode, so that we
> avoid further mode changes if the mode set already matches the
> selected one, or if Xen is to use the already set mode?

Not exactly: You either tell Xen to use the current mode ("vga=3Dcurrent")
or you tell Xen to use a specific mode ("vga=3D<mode>"). Checking whether
the present mode is the (specific) one Xen was told to switch to would
require yet more work. But skipping a requested mode switch can also
have unintended consequences, so I wouldn't even be certain we would
want to go such a route.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:45:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:45:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298606.508713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeoh-00037K-LC; Tue, 05 Apr 2022 08:45:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298606.508713; Tue, 05 Apr 2022 08:45:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbeoh-00037D-H4; Tue, 05 Apr 2022 08:45:35 +0000
Received: by outflank-mailman (input) for mailman id 298606;
 Tue, 05 Apr 2022 08:45:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbeog-00036o-8c
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:45:34 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bfd9e359-b4bc-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 10:45:32 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bfd9e359-b4bc-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649148332;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=6wQSPh9seQupSNmo9ABmYBAqNSLEb+diize44Wecdk4=;
  b=BA759pPV9LPyi5fskUCgn7muPPmvUAQ5tCaT6J1mFuQfezHItMHuR86Y
   YkcHyHm/pg3rUjzUDihGbmUjeG7/koyhC+6ns8eXSji4gR7VodvV/MnZM
   Q1MGTINn0PHisU3acuBROCcVa7Y/ZpUgQ4X5/gc9+YM+iT706yPez1hqD
   E=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68428354
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4+amCK2RGj8wxBdF2PbD5R5xkn2cJEfYwER7XKvMYLTBsI5bp2NRy
 WQeX26PPqrbMTf1L49wPNu0oUsPvJeBnYNjSgpopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIw3IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1M6MSBUissYJaXu8pDdwl/KHtuPvZZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u1pwUTa2DO
 6L1bxJXUzCQYAcTBmwuL48wvsuKoT7iah9h/Qf9Sa0fvDGIkV0ZPKLWGNHSf9mXQ8RJjwCdr
 2TP8GnjKgEXMsSFzjiI+W7qgfXA9QvbVYQIBfuH//hlqFSJwyoYDxh+fUS/iem0jAi5Qd03A
 04e9zcqrKMy3Fe2VdS7VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/
 gbXxZWzX2Up6eDLDyLGnluJkd+sESlIdV4ZSSpadlAmzYfHsKYI1ALMFck2RcZZkebJMT33x
 jmLqg03iLMSkdMH2s2HwLzXv96/jsOXF1Bov207Skrgt1okP9D9O+RE/HCBtZ59wJClok5tV
 ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRzwoBZPnqgKuVmSwXuF1O5eJFcFh
 2eJ5GtsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon0/PRTIgz2xyxRw+U3aB
 Xt9WZzxZZr9If45pAdaus9HieN7rszA7T27qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Om
 +uzw/Cikk0FOMWnO3G/2ddKcTgicChqbbir+pc/XrPSfWJb9JQJVqa5LUUJINc+wcy4V47go
 xmAZ6Ov4AGm3yeadlzWNCsLhXGGdc8XkE/X9BcEZD6A83MifZyu/OEYcZ42dqMg7+tt0bh/S
 PxtRilKKq4npujvk9jFUaTAkQ==
IronPort-HdrOrdr: A9a23:tyg+waGoORHDDjJ+pLqEi8eALOsnbusQ8zAXPiFKKSC9F/byqy
 nAppkmPHPP4gr5O0tApTn/Asa9qBrnnPZICOIqUYtKMjOJhFeV
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68428354"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T+LDxcfYVuVFhRR7nNNLUcShHe6iNzvMBs9yb/8d/Du0LjBRpIGEZmzGJNTLM/lrO8jng8eAlTBbM2c//S0BVGrj8paMFTV1AHp/y73eBfsVhMLCkPruTDC0BCATWJNlEpRtQyeI9lVptur8OxsfrySy9TqdRij7KqT4iDR7QD2h/viQjeg6++qvosUWkP1p1TnqLmhFJMiQIBHEwhgkw7aqNaFaF/HpKXwKHt6hKTqeDB/Fzy6K7EED9ybnluPgaiQ1WLaUeD19Sw9mLA13TbB+VF8jaW7fpgI79Ga7EJY7rYmtDDqiDxLds3pBDs5Ahs5Goa9DnRM9XEP4Wchypg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jU0tNywfi2tR5O6evzJJi9J6tCUoHjY/kSrbZl6XiPA=;
 b=gn1/ZRYUd6ziJqpnNuz1I+4tDIlNdNrz3uBF3vWN4ogLP0iWVoW0KHDPNwNPL2l7n1TUJVOpmAnCJl1Ju9Fi4ti8QsVnZ+WFuk9jsQn1h/h8TCS6KxHSfyfYMlBh2+CNp3jlpWb5XRYfMnfsgJMZAs/MjQO+SAzi+WI9iTpF6szetDZ3cvvRXskr0tkORYgNMFuHYO6gsGFDn0YuO8Vgf1XwU02tn2fZkbPY5lROIJDsSIeet5Ilp/a4jQ8FLdu217h0P77LLrLZf3X7MlFepxAOB7pO1GLfdDL4bad3rc1uOh5GrU679mMmJlnuQP7leLXDYlbfO4V9CQFI1dOsjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jU0tNywfi2tR5O6evzJJi9J6tCUoHjY/kSrbZl6XiPA=;
 b=D0NZx2X8TudqclKD7ViVufrtErjjVqhXKfqWq902/fIA5ZUfdTBOATXEpmxvi+a31r3C7/0BWBO2m6EY4tSO1E7kU88+SjUYi/fOdw+iTyMdAopyAYOaIUhqglpnf0QBHp/hrQEk6kJJCqh5SUzc1TWphXbjN3ffh6Fdo7PvylA=
Date: Tue, 5 Apr 2022 10:45:24 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	"community.manager@xenproject.org" <community.manager@xenproject.org>, Henry
 Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics
 modes
Message-ID: <YkwBpKcyrnuXyNPa@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
X-ClientProxiedBy: LO2P265CA0220.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 65821b87-9778-4691-392a-08da16e0a21f
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5759:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB5759A2E351555D7031041AEA8FE49@SJ0PR03MB5759.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: pakkzPLwPvC2+Ui/khhDC5h5QQ7H7alBbPbP0VOYx+IwOYPcftRmSe91EGaufWrrWc2JVEr7l/mB13RP447xAMsP2ob3aFDCktEpMi4s/fkRnyzmUz1phy5+c91sQ1BG6mEYQEylOUnPax1+p8kTAQNNvls4jiTIBB1kd93jInEKKSbabtWYg8XZyK0DDGkg1FOB7JvTfasSxOaggfZSl3AfaAGn+yJztDJ2cDoqNCADuLsxzINsj9i8YmA6AkoFxgzBjTAlKWbgVFYrcHRvRmJ70Awnca4RZWc0s/gUsuRH3se+/VOa62E0oqwF/6yyXws8gZy92lvMsezz3Mai3BxLSMYsT2pKx43OArbV4mevaPoCls5PRKoaeK2GJGxLSMHEfMu4xbIVd1U2fGpGRcWCpqFp40grYaZUSYXUZjo1JUKxfHDiZw7mRflPTyzrMBnziKIDhAZO+ZIjKmDfk9MYN+gXIU+ZJzDvU9XRmxNzKlBiNpdwLzo5L7JXH+HuZsEQfkSEH/VXJVqrzn/tfbD5PnlM6Fnwtuw9gf0+yEauFAIde9vwV38EdKzP5MA5fFk8vn2O9UkT99cQ4tSpJdHvoujGBri9v65aUuVV99Qw16UJXsYutUniUgV3ktBrSNSbXlXAgwVVmlEi1lrOTQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(5660300002)(6486002)(85182001)(6916009)(83380400001)(54906003)(186003)(316002)(26005)(508600001)(8936002)(38100700002)(6512007)(86362001)(66946007)(33716001)(2906002)(6506007)(6666004)(66556008)(66476007)(9686003)(8676002)(4326008)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFdZUmhQU2l4a3ViT0NwSmNMa0RETEU3RmcyU1hzSXpYODN2SXpWSWpBRTIz?=
 =?utf-8?B?NlFEZ3RwL20vSmxMWFdYcDRhMDB3YmlQK1E1RURqZ1pvTFVkR2FMeGRxMWx1?=
 =?utf-8?B?S2diVG01Mkt5ZHVBNm54Q2p4U0JvMTNKL1ZlOW5rbS9rSXB2Q053bHV0Smxv?=
 =?utf-8?B?L0pNUUphNys2alZKRXphRVBZK0tCVlFmYkl3MG1XYUFXU2plcm0zcXJxd0ZR?=
 =?utf-8?B?a2V0NGxtbnNzUlhiQWptdWR1MlRSbjl4c3p4Tm5XbHVGNDNXa0pXbVlYWDNn?=
 =?utf-8?B?aHVxZGtVZ25kQjhScjhZMEtzaXBsTVY3YjlOZXhoM3lFUm8yNmlrV2NGTTQ2?=
 =?utf-8?B?aWcvTFdMRlpLUlZmNjZKQ2dMYXhpWis1RHIrcDk3YXhwc2dHZDgwazhnUW9U?=
 =?utf-8?B?eE5RS2RIL2VhQ0VKTHlvSzczenUzT2pqZnNvSnB5azVSUjVIc1lTb3NlUHhL?=
 =?utf-8?B?NWtNWWhPcXJUczA3RDdBT1EyRlYrRXJyMkxvUTFyMjNwZTlQNHFHTjJaNHZm?=
 =?utf-8?B?RlVwSFEvVE1xQVdXcUkzYTVTbHFoOEJqRDVTdlg1NStwL0UyVG5OVGtXUkNr?=
 =?utf-8?B?dWgwblJTRnA4cENMU0M1T2pCcWRhNkozdmdCSTBwakw1ZXJYUnNLdGl6Si9p?=
 =?utf-8?B?S01NWC8rRnovcVNxSlN0UHNVUTRwbVJYaFBYQkdKblhMMVgzaFhuamtlQW9x?=
 =?utf-8?B?TThyM21IODIzV2pIK1ZQQkMyeE1aVUNuRVJoUllXTTd3bkM4LzNYS2N2VDFR?=
 =?utf-8?B?TlBOWWRrTFBjSndWVmlnVjlOb2Zia1AzTjMyVUJFSnVKRE5EZzUvNEozc2py?=
 =?utf-8?B?dHI3NytkUGVCemcxZE9aSG9PbnpCRFJwMFY5bCtRc3UxRjV3S2JMeG9oMkUv?=
 =?utf-8?B?ckJhZ3lZZjkyVmErcmMvejBBQldrTXR0OXR0K2JBUi82YU5ZaHQ3NE1qV0Jk?=
 =?utf-8?B?UHI5WFB1S2VhbU1laUhMS0NtSHcrNVkrQnR3OFVmYUlrQTBXN01xWENoWVVn?=
 =?utf-8?B?NUNTMWdqMmdlK2RHMURhelNnU0hVMS9TWVE0YmM1bE9zVDMybWFvdXNubXRF?=
 =?utf-8?B?T01Obkd3Z3kyRm5NTU9FNlJVanJQNmNpYmxMRCt2ZUJid1J0bHppbFVDdmZY?=
 =?utf-8?B?cHVSTlZRWnByNWVnd2V1VEFvL3BvNTBlb2R6Um1tQjhHNHBJcFlJRjMxa1Iy?=
 =?utf-8?B?ZlVOL2RZREcrNmNXKzNoQUNzc0hZK3lTejgwYTlHbzdCMzV4bjU4S2N1OTRs?=
 =?utf-8?B?RThsM3FUMTRUQ3o3QTcyUXRxbmFReTU0SHFhSVBaN0cyb3NyVkxFVWR0MmN2?=
 =?utf-8?B?ZmZqemp0akRhVFN5bXRFRHp0anNwOEw4Nld5Z00wMDlBWG42cUU5b1VFM0py?=
 =?utf-8?B?QmozbFBwQUF0cE8wQlJvbFMvRzhRQXZwSTJJeTVLRi9RZG9GNFhrWUhHQ1c0?=
 =?utf-8?B?N0tRZ01uZFczVXE1VjBDaWNsK3FlOFZ4UWg5VDRqUkxwOFZrL0xoaU1jamtZ?=
 =?utf-8?B?eEtSY3M3YzZET1cxMUJkZjJKbnVDRU5temVLOGN4MXNFNlRZUEJoREoxUEZK?=
 =?utf-8?B?MW9LeDdRVEhJdTREMitENGxDUVhSNzZkcjZTZ3VTbkNLR1pyYjJ4QkNHK1Uz?=
 =?utf-8?B?bTdrUThJVHY1N1hac25veWQrZXJ5Tnc0UzMxZ3BWekV0TnQzK2RPdHorLzdN?=
 =?utf-8?B?YjZCVmJUczNORlBGQkpBOHZQbVpSYmZKTUtvVUx1OUVTTCtzR2VISWlEWlMx?=
 =?utf-8?B?TTdPZVFnTmFjcjBjaUlaanF5WDRIYlBlY2pCUXlWek5IVCtIMWwvZW1lTFBq?=
 =?utf-8?B?dHFTRDlTOUhWeWRoOExBOVYrUzNkd3lOaXVhbksyayt4dGxnYU02aWlIYlN4?=
 =?utf-8?B?TTlvOUUySHFLQXhVdzExLzZIOFhWeFpsUnk5VnA2N3hmQ2NJcmFmd3Ixdyt3?=
 =?utf-8?B?QVRiK0NTWVhscW56cXpjYVErZ1hsN3RQU0llN2ZJWis1UUluSkN2TFNCRVdH?=
 =?utf-8?B?cjJ5bDZ2ZGVLdUQxL0svZjhYMDBscS9ycFJ1OVd6Mnh4ZXpUQ0VVcnNwM21t?=
 =?utf-8?B?MFVPUFZHNjRzT1p4TUhTYUU2b0RUN2hVZ25UN2hCSlh6WFplQkZsOFJWTy9w?=
 =?utf-8?B?aGl4YXJzS3IzdEVvbUxRYXpvUTNjMVdDTUVPaWlkRGgyZk9MR1dsZXY3NFY3?=
 =?utf-8?B?cEh0MU0zOTBXWTNmdUlvcXF4QUZMY0NienR1aG9zMzdRbFc4aFFmL2Q4UUJY?=
 =?utf-8?B?YmdHMTZ4TTVxdXFGWnNQSVRBNWV5SXJtdUVVV290anB0Q2RHcUlFTm5lSmdT?=
 =?utf-8?B?RjJsaC9FTlVoQi83RFI3YjZzTHhsS2JVOC80OW50eStIMXUvcU14Yk53T3RE?=
 =?utf-8?Q?15EDW5xB3Na6iglA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 65821b87-9778-4691-392a-08da16e0a21f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 08:45:27.6614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5oN5cGIbHP0Ub8In81gTpPBymT4KaEogV+8ZG//7s27WztdTCikrHMKRmWSLlh/NC68hPazRp5ybva4kh+bWdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5759
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote:
> GrUB2 can be told to leave the screen in the graphics mode it has been
> using (or any other one), via "set gfxpayload=keep" (or suitable
> variants thereof). In this case we can avoid doing another mode switch
> ourselves. This in particular avoids possibly setting the screen to a
> less desirable mode: On one of my test systems the set of modes
> reported available by the VESA BIOS depends on whether the interposed
> KVM switch has that machine set as the active one. If it's not active,
> only modes up to 1024x768 get reported, while when active 1280x1024
> modes are also included. For things to always work with an explicitly
> specified mode (via the "vga=" option), that mode therefore needs be a
> 1024x768 one.
> 
> For some reason this only works for me with "multiboot2" (and
> "module2"); "multiboot" (and "module") still forces the screen into text
> mode, despite my reading of the sources suggesting otherwise.
> 
> For starters I'm limiting this to graphics modes; I do think this ought
> to also work for text modes, but
> - I can't tell whether GrUB2 can set any text mode other than 80x25
>   (I've only found plain "text" to be valid as a "gfxpayload" setting),
> - I'm uncertain whether supporting that is worth it, since I'm uncertain
>   how many people would be running their systems/screens in text mode,
> - I'd like to limit the amount of code added to the realmode trampoline.
> 
> For starters I'm also limiting mode information retrieval to raw BIOS
> accesses. This will allow things to work (in principle) also with other
> boot environments where a graphics mode can be left in place. The
> downside is that this then still is dependent upon switching back to
> real mode, so retrieving the needed information from multiboot info is
> likely going to be desirable down the road.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:49:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:49:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298612.508724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbesm-0003mE-5h; Tue, 05 Apr 2022 08:49:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298612.508724; Tue, 05 Apr 2022 08:49:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbesm-0003m7-2T; Tue, 05 Apr 2022 08:49:48 +0000
Received: by outflank-mailman (input) for mailman id 298612;
 Tue, 05 Apr 2022 08:49:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbesl-0003m1-1f
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:49:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5785619b-b4bd-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 10:49:45 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-OJ4OIt1HNtmbC6my4g0QGA-1; Tue, 05 Apr 2022 10:49:42 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR04MB3174.eurprd04.prod.outlook.com (2603:10a6:6:c::30) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.31; Tue, 5 Apr 2022 08:49:40 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 08:49:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5785619b-b4bd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649148585;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eSWdLqwj7MAzpmvgET2jb1II/XRMZrTXTBSSIZe1444=;
	b=D+GKNfoM8ay8upT0mOKY9nQKBflcQLuExUvCrX5xMB50BuFxoMnTFRsTdw1+5rPTDbrRWp
	aSozTmel9I4Ngrlyj+ziVjezvACSPPLsCWdq9qD9JFYQonFEgRs/yogZWTOLY+oy505Y6k
	L8sLPt4Et2MMcUynrcXh7qqZ0JQ83Os=
X-MC-Unique: OJ4OIt1HNtmbC6my4g0QGA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WFOHSkf4IV8cqtb2ZLBFXCSRa0l3pmpTk7MPuNYce3UuXpKjZplNQGk/XM7ByrAPhSn11YbCTIcK2CqZIbaF5/+++dm6lJAhsjEifab79yGlLBRY21jH3Smy8JZ6rSFrBRf4TAMZrCsPcoffzem5kazpgX1McO3QxMFqkXZBPCWD4D5P2n/6lv3jEja36TvcNkMMuHZ3H4Qzg2TT/mkg3C/cY4x16d+dzDtAhkM2NrrQBEccJhH/tU7vhJnGWBWXVnkzVxLzriqDuHc1uNolI/y1rUoETizCkhwUAJHOrFSvxeYcMbeRrIIt6LOmF44TKrp+huu7R4JVeVGknfg5Hw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eSWdLqwj7MAzpmvgET2jb1II/XRMZrTXTBSSIZe1444=;
 b=efFB6UCVrADYEMRedTaY2qop36jjKbGgU2MTr2bUCoXJGCXuwuzAlpNoldI5BCDuuOmf33sWWDLi6PHJntkvpmCp+2RYBGWVQNCwzpyik4Q6fwAXNtV930FtWUNbkdQDqhdFznvVsf9Dl88u2e5TpPNFfTQ0qHXtdRLJRcpHroSzEMDZX6ObqUKNtl/g/S4j69XV/9Ly75VAmdb2vhC6cMzDNk2tfADtOJQX8It7dCynb0RqIfjY0ndnHaO1wQv3eiO2KtsucV0mZXfQ92mpM3LGr5ctDAu7vrmBI637wcP6HGt7V1ssnnFvubNN7dSgbODw3fTuqFVnGXQK8sTzcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <eaf82b61-de3b-b2c2-b6f5-2b43b3348a09@suse.com>
Date: Tue, 5 Apr 2022 10:49:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v3 2/2] xen: Populate xen.lds.h and make use of its macros
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220331071425.49141-1-michal.orzel@arm.com>
 <20220331071425.49141-3-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220331071425.49141-3-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR04CA0001.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::11) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: edbcc742-b282-43d6-1661-08da16e13891
X-MS-TrafficTypeDiagnostic: DB6PR04MB3174:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB3174C3E24082EA028C75E632B3E49@DB6PR04MB3174.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UNRmb89WNGGMI7wApb7IE2ean/1UR56nrJYTrWNZaTfDUC8AQdfoddwFqwT/FlmaE7a3Cb+ZznOQ34KELutgjDSSPE3IXuZTqy8y738GFbxaqA2durC7Fr9eg5pfYqbUVHuNeA3WVGUihvkbwSq0ewbsISvAL9EA6db6vVzEy6xnRHQAkALeYXXIzDCeSfGP74/7JUR73mRVLGSjZPZjskztC8O/vi6jXYOdCRtliHJ+1mYDly3z3qfSkgMSxGjlOeYILXbRsOOIV78Gd1gRPxGOMvJ6mXjFOiLljc0B+3UySXPi0YhUtDnuO2rwXRiRfuLYIFI/KTvt3djFSPIxMjPyd8Ee6auK6as+mKZ+SMYw+BfNJZt+FLs5rj7/MAzTC8WDzTN7wu0sfQagqkJ6waXbYB+stHKqtyvy6wXnuiiWYjuGYXzNsYrtaTCru8mVldFxqcpDSTgvmNYW/zIDqEXlaPdeXyq0i0LToHtJbHYvCXwy1DGRMybj+w+FtmyoMJ4872Rk5fd4cGSmxDY9kslo0rJl7F3/vXjY7HZMs5yYwan8ateyOsFXp47/gSNYHx5xqJsQ9bZzUS8jVrIb37M0FIRBQVQUDQ9mFwnD3BxOG+jcdcvnX2n9ZP06OFW87+IfS0wbzcutFZEfsW0WlvZqySGBHhnyz/JUtpVtHhv5DPlJYwxQND+8/Mupb6P/hFSO4GNnNKutFzggBQateuGM3L3+XeE3LN0gH35BFhNGJbqyPbtKUwuwdVkGl4+N
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(36756003)(316002)(6512007)(54906003)(31686004)(53546011)(2616005)(6916009)(2906002)(4326008)(6486002)(7416002)(8676002)(6506007)(26005)(86362001)(66946007)(66556008)(66476007)(31696002)(186003)(508600001)(5660300002)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TnJVZ0YrOHk1SXpHdkFrbmxTeUlDTzJKcmNvTVJIUm9kWTQ3QmJ6TXN0RE1y?=
 =?utf-8?B?eXNLd1hzRUdPaUVGQW9XMFlVcWI3TUxIVzZNUXQzUW1mYzdGVXRncnRrVkJR?=
 =?utf-8?B?Z3YzbkxVZi9pekJONGQyUVJHcVJwSWVMV0lNZ0c2akY1eHRNZXZPWjJTTXRY?=
 =?utf-8?B?MFh1RTZWSXF6VlRvUyttL3hjZ2hIZFNlb1NjK1FiRmlDRVJyL093Qk9peHY1?=
 =?utf-8?B?Skc5bXZjSUJOMFZkZXFneWxPWVdGbVd2ZS91ejUxNlhQOWgzZ3RrOUZ3T0ph?=
 =?utf-8?B?YmVWK20yak9xbTNmaFRqd2tpYTN1eWprY29DZEdqb2dxOUs3MXAyRWplS255?=
 =?utf-8?B?N0ZOU3oxQlVNeXg0MzhwV1FtejFnL25Xa1lyb24wUFk3V2ZLRkJZWXh3bEJ0?=
 =?utf-8?B?bFluTDJ3MFdNbmtJU0c2NzZzZnRCdGVXMkcweE9hNnhOQSs1dXNGN3lHdDAv?=
 =?utf-8?B?dVZGd1RQNXFvclRydlZsWFgzTWZ4aXlmTXk1cjR3M3Y3bEFIRVE0ZHE1eVlt?=
 =?utf-8?B?VlBoTC90SzVUQlA4dlI3clM4QWdORitadGtFTlpUT1VVOFBWWDYzenlPTkdS?=
 =?utf-8?B?QTdzaUl2SEMyOXRmemZZQ2JyYWV5WFQyT2JZeTBWaG1BM28vR3dxKy90TWNU?=
 =?utf-8?B?bUdtMFpKek0xdUJwN1FrMHBkemVSQ1hFTm5RNG1maUNZbDNJcENBREIrdUZ3?=
 =?utf-8?B?M0tGU0J0SDJNYm1DY3pFREZ2WGRmSGNDRjhwdjJNWmQzWGY1dEQ0VlhERWR5?=
 =?utf-8?B?N1pPRElTOGZYT2RPVjVoV3VZcGI1M2IybHVlYjFDclovTXdrbWllSFhDWmJF?=
 =?utf-8?B?b0VqRGE0SW9KS1U5YW5tOUppcy9Hc3ZYUC9GZC9QTEJJQWYyNS91SVM3dW0z?=
 =?utf-8?B?cHdlVnpVb3U0TFdCTnlZMy9jTlNKb1A3cERPOUxRVVFoMytQMFRjMldCaC94?=
 =?utf-8?B?b2RWVkczbERKVklxS2VuYStGYmpIa0NhNHVGdU5uaENocVdBeWpXdzFZR0lQ?=
 =?utf-8?B?dERxUnhZa1Bsbm1YYWFGOHlhZWxOTFYyWERQbE5UM2k0bmJraGRYNWtCQ0xw?=
 =?utf-8?B?eXl4QWhXcnhiaEcvRE9kQ0V4cXNCbG9KY0pEQzZmYzFQcDB0Q294enVZSGUz?=
 =?utf-8?B?MHA0QXpyN2RCYlh5T3lVdEM4dlpKVTdtNE5CdlJQNEJnK3hXQmdDY0VXMHYx?=
 =?utf-8?B?dFNheU5LYnoycFhiQ2t2emV3YjVnbDM2Z3psbFg3R0x6MjFuUy9yUzBCTnQ2?=
 =?utf-8?B?RnVoUXF0bWsxYnFHNHQ4NXpySmpnOGo4TGZ3dmU1ZE4xY0lkZDNocTgraFk4?=
 =?utf-8?B?eEZuRXh0bHcxK0NPUVQ3N01Xd0QzOUE0LzdtT0NhUEdpNHJIdi9LZ3ZqSTFM?=
 =?utf-8?B?RGRPZDhyZytZZm15eGNKcnpKRSt4aXBZNmk0KytiTW9WY3NQMkJLOU8zWlJG?=
 =?utf-8?B?Uko4RjcvWlBaUlRVa3FHTWNoNVQxbzAvTktvODNiUUNXQ1lDanlET2wwZXFv?=
 =?utf-8?B?WUc0OWlqb2lPRUV2ZXh3QU1Ldm9VSDdwNjRTc3Q5RVlMa2dMMng4WmlOWlRB?=
 =?utf-8?B?MlhzTlNFcHJQTEIyS0lCbzJmSWtISUtEY1RwZHRqRUlSd2YvR1NGSnJKSHVE?=
 =?utf-8?B?aWEzN2loZWlsSHNlbWJIOTJha1U1bi9vQnBvK3VoK053RkdYUWxadkNjaFlk?=
 =?utf-8?B?ZUQ3OGhOSW1uc2NFRWdicklDdHZldzlPa3hqQlcrdnFNSDlvbHV6elVFUXRN?=
 =?utf-8?B?RWxoUVpnUWlEdkVpenFDN010ekw0MTFEdk1KeXJyNk1DT1pMT0hKQjFFMFBt?=
 =?utf-8?B?bmJycFBpM2FNSW96NldBZURtWCtMand5MmlzOWdYQ09hc25HSEpxS3hiVVNL?=
 =?utf-8?B?NlhDQlM1V3BwOEQ0WFh5dWZsZ3h3WGlPWHlCUkczUFNNZjFqMmxORUx1cDhw?=
 =?utf-8?B?NEtZK1ZNczUwcnhrNTlObzJTWDBxaTdsNjB4SkFheTkzOHBjNllpQ1poeGJi?=
 =?utf-8?B?SVdFemJQMUJpN2ZiaGlhZDJLcnhiaFZKM0RvWHJBcnNDemNOUllzVFJreVJa?=
 =?utf-8?B?eFdYc3RXUU44STc3QnpyNDFVdzZMOHIzS2hJTHV2eGtXcHI2S3hJRWNtOFY4?=
 =?utf-8?B?OFp1OFdmMjZsVVh4U3ZHcDd4TE5QZ0pCZ201cHc0aHBaRlVVdEsybkRFS2Ev?=
 =?utf-8?B?OVM4SjVQTmZCbnNKeG9NeTNXOWZZRDNOdmlpcmpGY1E1ODVtZ0kyYmh4WUd0?=
 =?utf-8?B?ZldOTGtyWHRERWJ5ZVVFbkFmWHJJTzRHK05RamVkclRZR0NRWHhkQnNiVW8r?=
 =?utf-8?B?djhhVGJZYlpKVTFuMXNuaGhhVXNHME1ORmoybUJNYlh2bDY3UzdRdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edbcc742-b282-43d6-1661-08da16e13891
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 08:49:40.0080
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HX62y6sxD9xqGyd5eDHQm5zJHvOFNHgRRk1qYjvUkqqdc6itcDiDkALx/qq+eQzZU51oXie1zbsGJWtP8CguEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3174

On 31.03.2022 09:14, Michal Orzel wrote:
> --- a/xen/include/xen/xen.lds.h
> +++ b/xen/include/xen/xen.lds.h
> @@ -5,4 +5,133 @@
>   * Common macros to be used in architecture specific linker scripts.
>   */
>  
> +/*
> + * To avoid any confusion, please note that the EFI macro does not correspond
> + * to EFI support and is used when linking a native EFI (i.e. PE/COFF) binary,
> + * hence its usage in this header.
> + */
> +
> +/* Macros to declare debug sections. */
> +#ifdef EFI
> +/*
> + * Use the NOLOAD directive, despite currently ignored by (at least) GNU ld
> + * for PE output, in order to record that we'd prefer these sections to not
> + * be loaded into memory.
> + */
> +#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) }
> +#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) }
> +#else
> +#define DECL_DEBUG(x, a) #x 0 : { *(x) }
> +#define DECL_DEBUG2(x, y, a) #x 0 : { *(x) *(y) }
> +#endif
> +
> +/*
> + * DWARF2+ debug sections.
> + * Explicitly list debug sections, first of all to avoid these sections being
> + * viewed as "orphan" by the linker.
> + *
> + * For the PE output this is further necessary so that they don't end up at
> + * VA 0, which is below image base and thus invalid. Note that this macro is
> + * to be used after _end, so if these sections get loaded they'll be discarded
> + * at runtime anyway.
> + */
> +#define DWARF2_DEBUG_SECTIONS                     \
> +  DECL_DEBUG(.debug_abbrev, 1)                    \
> +  DECL_DEBUG2(.debug_info, .gnu.linkonce.wi.*, 1) \
> +  DECL_DEBUG(.debug_types, 1)                     \
> +  DECL_DEBUG(.debug_str, 1)                       \
> +  DECL_DEBUG2(.debug_line, .debug_line.*, 1)      \
> +  DECL_DEBUG(.debug_line_str, 1)                  \
> +  DECL_DEBUG(.debug_names, 4)                     \
> +  DECL_DEBUG(.debug_frame, 4)                     \
> +  DECL_DEBUG(.debug_loc, 1)                       \
> +  DECL_DEBUG(.debug_loclists, 4)                  \
> +  DECL_DEBUG(.debug_macinfo, 1)                   \
> +  DECL_DEBUG(.debug_macro, 1)                     \
> +  DECL_DEBUG(.debug_ranges, 8)                    \

Here and ...

> +  DECL_DEBUG(.debug_rnglists, 4)                  \
> +  DECL_DEBUG(.debug_addr, 8)                      \

... here I think you also want to switch to POINTER_ALIGN.

> +  DECL_DEBUG(.debug_aranges, 1)                   \
> +  DECL_DEBUG(.debug_pubnames, 1)                  \
> +  DECL_DEBUG(.debug_pubtypes, 1)
> +
> +/* Stabs debug sections. */
> +#define STABS_DEBUG_SECTIONS                 \
> +  .stab 0 : { *(.stab) }                     \
> +  .stabstr 0 : { *(.stabstr) }               \
> +  .stab.excl 0 : { *(.stab.excl) }           \
> +  .stab.exclstr 0 : { *(.stab.exclstr) }     \
> +  .stab.index 0 : { *(.stab.index) }         \
> +  .stab.indexstr 0 : { *(.stab.indexstr) }
> +
> +/*
> + * Required sections not related to debugging.

Nit: Perhaps better "Required ELF sections ..."? Personally I'd also
drop the mentioning of debugging - that's not really relevant here.
I'm also unsure about "Required" - .comment isn't really required.
IOW ideally simply "ELF sections" or "Sections to be retained in ELF
binaries" or some such.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:57:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:57:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298618.508750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0f-0005Ye-P6; Tue, 05 Apr 2022 08:57:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298618.508750; Tue, 05 Apr 2022 08:57:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0f-0005XL-IL; Tue, 05 Apr 2022 08:57:57 +0000
Received: by outflank-mailman (input) for mailman id 298618;
 Tue, 05 Apr 2022 08:57:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eUJf=UP=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nbf0d-0005F8-Gv
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:57:55 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 79e71c97-b4be-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 10:57:53 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3BA641474;
 Tue,  5 Apr 2022 01:57:52 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5869F3F73B;
 Tue,  5 Apr 2022 01:57:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79e71c97-b4be-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v5 1/6] tools/cpupools: Give a name to unnamed cpupools
Date: Tue,  5 Apr 2022 09:57:36 +0100
Message-Id: <20220405085741.18336-2-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220405085741.18336-1-luca.fancellu@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>

With the introduction of boot time cpupools, Xen can create many
different cpupools at boot time other than cpupool with id 0.

Since these newly created cpupools can't have an
entry in Xenstore, create the entry using xen-init-dom0
helper with the usual convention: Pool-<cpupool id>.

Given the change, remove the check for poolid == 0 from
libxl_cpupoolid_to_name(...).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- no changes, add R-by
Changes in v2:
 - Remove unused variable, moved xc_cpupool_infofree
   ahead to simplify the code, use asprintf (Juergen)
---
 tools/helpers/xen-init-dom0.c  | 35 +++++++++++++++++++++++++++++++++-
 tools/libs/light/libxl_utils.c |  3 +--
 2 files changed, 35 insertions(+), 3 deletions(-)

diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
index c99224a4b607..84286617790f 100644
--- a/tools/helpers/xen-init-dom0.c
+++ b/tools/helpers/xen-init-dom0.c
@@ -43,7 +43,9 @@ int main(int argc, char **argv)
     int rc;
     struct xs_handle *xsh = NULL;
     xc_interface *xch = NULL;
-    char *domname_string = NULL, *domid_string = NULL;
+    char *domname_string = NULL, *domid_string = NULL, *pool_path, *pool_name;
+    xc_cpupoolinfo_t *xcinfo;
+    unsigned int pool_id = 0;
     libxl_uuid uuid;
 
     /* Accept 0 or 1 argument */
@@ -114,6 +116,37 @@ int main(int argc, char **argv)
         goto out;
     }
 
+    /* Create an entry in xenstore for each cpupool on the system */
+    do {
+        xcinfo = xc_cpupool_getinfo(xch, pool_id);
+        if (xcinfo != NULL) {
+            if (xcinfo->cpupool_id != pool_id)
+                pool_id = xcinfo->cpupool_id;
+            xc_cpupool_infofree(xch, xcinfo);
+            if (asprintf(&pool_path, "/local/pool/%d/name", pool_id) <= 0) {
+                fprintf(stderr, "cannot allocate memory for pool path\n");
+                rc = 1;
+                goto out;
+            }
+            if (asprintf(&pool_name, "Pool-%d", pool_id) <= 0) {
+                fprintf(stderr, "cannot allocate memory for pool name\n");
+                rc = 1;
+                goto out_err;
+            }
+            pool_id++;
+            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
+                          strlen(pool_name))) {
+                fprintf(stderr, "cannot set pool name\n");
+                rc = 1;
+            }
+            free(pool_name);
+out_err:
+            free(pool_path);
+            if ( rc )
+                goto out;
+        }
+    } while(xcinfo != NULL);
+
     printf("Done setting up Dom0\n");
 
 out:
diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c
index b91c2cafa223..81780da3ff40 100644
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -151,8 +151,7 @@ char *libxl_cpupoolid_to_name(libxl_ctx *ctx, uint32_t poolid)
 
     snprintf(path, sizeof(path), "/local/pool/%d/name", poolid);
     s = xs_read(ctx->xsh, XBT_NULL, path, &len);
-    if (!s && (poolid == 0))
-        return strdup("Pool-0");
+
     return s;
 }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:57:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:57:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298616.508734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0e-0005FQ-0P; Tue, 05 Apr 2022 08:57:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298616.508734; Tue, 05 Apr 2022 08:57:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0d-0005FJ-Ti; Tue, 05 Apr 2022 08:57:55 +0000
Received: by outflank-mailman (input) for mailman id 298616;
 Tue, 05 Apr 2022 08:57:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eUJf=UP=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nbf0c-0005F2-42
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:57:54 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 7627ecab-b4be-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 10:57:46 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24365D6E;
 Tue,  5 Apr 2022 01:57:51 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 72B973F73B;
 Tue,  5 Apr 2022 01:57:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7627ecab-b4be-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 0/6] Boot time cpupools
Date: Tue,  5 Apr 2022 09:57:35 +0100
Message-Id: <20220405085741.18336-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

This serie introduces a feature for Xen to create cpu pools at boot time, the
feature is enabled using a configurable that is disabled by default.
The boot time cpupool feature relies on the device tree to describe the cpu
pools.
Another feature is introduced by the serie, the possibility to assign a
dom0less guest to a cpupool at boot time.

Here follows an example, Xen is built with CONFIG_BOOT_TIME_CPUPOOLS=y.

>From the DT:

  [...]

  a72_0: cpu@0 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x0>;
    device_type = "cpu";
    [...]
  };

  a72_1: cpu@1 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x1>;
    device_type = "cpu";
    [...]
  };

  a53_0: cpu@100 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x100>;
    device_type = "cpu";
    [...]
  };

  a53_1: cpu@101 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x101>;
    device_type = "cpu";
    [...]
  };

  a53_2: cpu@102 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x102>;
    device_type = "cpu";
    [...]
  };

  a53_3: cpu@103 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x103>;
    device_type = "cpu";
    [...]
  };

  chosen {
    #size-cells = <0x1>;
    #address-cells = <0x1>;
    xen,dom0-bootargs = "...";
    xen,xen-bootargs = "...";

    cpupool0 {
      compatible = "xen,cpupool";
      cpupool-cpus = <&a72_0 &a72_1>;
      cpupool-sched = "credit2";
    };

    cp1: cpupool1 {
      compatible = "xen,cpupool";
      cpupool-cpus = <&a53_0 &a53_1 &a53_2 &a53_3>;
    };

    module@0 {
      reg = <0x80080000 0x1300000>;
      compatible = "multiboot,module";
    };

    domU1 {
      #size-cells = <0x1>;
      #address-cells = <0x1>;
      compatible = "xen,domain";
      cpus = <1>;
      memory = <0 0xC0000>;
      vpl011;
      domain-cpupool = <&cp1>;

      module@92000000 {
        compatible = "multiboot,kernel", "multiboot,module";
        reg = <0x92000000 0x1ffffff>;
        bootargs = "...";
      };
    };
  };

  [...]

The example DT is instructing Xen to have two cpu pools, the one with id 0
having two phisical cpus and the one with id 1 having 4 phisical cpu, the
second cpu pool uses the null scheduler and from the /chosen node we can see
that a dom0less guest will be started on that cpu pool.

In this particular case Xen must boot with different type of cpus, so the
boot argument hmp_unsafe must be enabled.

Luca Fancellu (6):
  tools/cpupools: Give a name to unnamed cpupools
  xen/sched: create public function for cpupools creation
  xen/sched: retrieve scheduler id by name
  xen/cpupool: Create different cpupools at boot time
  arm/dom0less: assign dom0less guests to cpupools
  xen/cpupool: Allow cpupool0 to use different scheduler

 docs/misc/arm/device-tree/booting.txt  |   5 +
 docs/misc/arm/device-tree/cpupools.txt | 136 +++++++++++++++
 tools/helpers/xen-init-dom0.c          |  35 +++-
 tools/libs/light/libxl_utils.c         |   3 +-
 xen/arch/arm/domain_build.c            |  14 +-
 xen/arch/arm/include/asm/smp.h         |   3 +
 xen/common/Kconfig                     |   7 +
 xen/common/Makefile                    |   1 +
 xen/common/boot_cpupools.c             | 230 +++++++++++++++++++++++++
 xen/common/domain.c                    |   2 +-
 xen/common/sched/core.c                |  40 +++--
 xen/common/sched/cpupool.c             |  35 +++-
 xen/include/public/domctl.h            |   4 +-
 xen/include/xen/sched.h                |  53 ++++++
 14 files changed, 540 insertions(+), 28 deletions(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/common/boot_cpupools.c

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:57:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:57:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298617.508746 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0f-0005V4-Cj; Tue, 05 Apr 2022 08:57:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298617.508746; Tue, 05 Apr 2022 08:57:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0f-0005Ux-8z; Tue, 05 Apr 2022 08:57:57 +0000
Received: by outflank-mailman (input) for mailman id 298617;
 Tue, 05 Apr 2022 08:57:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eUJf=UP=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nbf0d-0005F2-Cs
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:57:55 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 77c9c8bd-b4be-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 10:57:49 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DCA721515;
 Tue,  5 Apr 2022 01:57:53 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 743A53F73B;
 Tue,  5 Apr 2022 01:57:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77c9c8bd-b4be-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v5 2/6] xen/sched: create public function for cpupools creation
Date: Tue,  5 Apr 2022 09:57:37 +0100
Message-Id: <20220405085741.18336-3-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220405085741.18336-1-luca.fancellu@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>

Create new public function to create cpupools, can take as parameter
the scheduler id or a negative value that means the default Xen
scheduler will be used.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- Fixed comment (Andrew)
Changes in v2:
- cpupool_create_pool doesn't check anymore for pool id uniqueness
  before calling cpupool_create. Modified commit message accordingly
---
 xen/common/sched/cpupool.c | 15 +++++++++++++++
 xen/include/xen/sched.h    | 16 ++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index a6da4970506a..89a891af7076 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1219,6 +1219,21 @@ static void cpupool_hypfs_init(void)
 
 #endif /* CONFIG_HYPFS */
 
+struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id)
+{
+    struct cpupool *pool;
+
+    if ( sched_id < 0 )
+        sched_id = scheduler_get_default()->sched_id;
+
+    pool = cpupool_create(pool_id, sched_id);
+
+    BUG_ON(IS_ERR(pool));
+    cpupool_put(pool);
+
+    return pool;
+}
+
 static int __init cf_check cpupool_init(void)
 {
     unsigned int cpu;
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 406d9bc610a4..b07717987434 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1147,6 +1147,22 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c);
 int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op);
 unsigned int cpupool_get_id(const struct domain *d);
 const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool);
+
+/*
+ * cpupool_create_pool - Creates a cpupool
+ * @pool_id: id of the pool to be created
+ * @sched_id: id of the scheduler to be used for the pool
+ *
+ * Creates a cpupool with pool_id id.
+ * The sched_id parameter identifies the scheduler to be used, if it is
+ * negative, the default scheduler of Xen will be used.
+ *
+ * returns:
+ *     pointer to the struct cpupool just created, or Xen will panic in case of
+ *     error
+ */
+struct cpupool *cpupool_create_pool(unsigned int pool_id, int sched_id);
+
 extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:57:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:57:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298619.508756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0g-0005cf-3N; Tue, 05 Apr 2022 08:57:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298619.508756; Tue, 05 Apr 2022 08:57:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0f-0005Zu-SF; Tue, 05 Apr 2022 08:57:57 +0000
Received: by outflank-mailman (input) for mailman id 298619;
 Tue, 05 Apr 2022 08:57:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eUJf=UP=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nbf0f-0005F2-1s
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:57:57 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 78a930de-b4be-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 10:57:50 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F943D6E;
 Tue,  5 Apr 2022 01:57:55 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 21CFF3F73B;
 Tue,  5 Apr 2022 01:57:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78a930de-b4be-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v5 3/6] xen/sched: retrieve scheduler id by name
Date: Tue,  5 Apr 2022 09:57:38 +0100
Message-Id: <20220405085741.18336-4-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220405085741.18336-1-luca.fancellu@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>

Add a static function to retrieve the scheduler pointer using the
scheduler name.

Add a public function to retrieve the scheduler id by the scheduler
name that makes use of the new static function.

Take the occasion to replace open coded scheduler search with the
new static function in scheduler_init.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- add R-by
Changes in v2:
- replace open coded scheduler search in scheduler_init (Juergen)
---
 xen/common/sched/core.c | 40 ++++++++++++++++++++++++++--------------
 xen/include/xen/sched.h | 11 +++++++++++
 2 files changed, 37 insertions(+), 14 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab67818106..48ee01420fb8 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2947,10 +2947,30 @@ void scheduler_enable(void)
     scheduler_active = true;
 }
 
+static inline
+const struct scheduler *__init sched_get_by_name(const char *sched_name)
+{
+    unsigned int i;
+
+    for ( i = 0; i < NUM_SCHEDULERS; i++ )
+        if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) )
+            return schedulers[i];
+
+    return NULL;
+}
+
+int __init sched_get_id_by_name(const char *sched_name)
+{
+    const struct scheduler *scheduler = sched_get_by_name(sched_name);
+
+    return scheduler ? scheduler->sched_id : -1;
+}
+
 /* Initialise the data structures. */
 void __init scheduler_init(void)
 {
     struct domain *idle_domain;
+    const struct scheduler *scheduler;
     int i;
 
     scheduler_enable();
@@ -2981,25 +3001,17 @@ void __init scheduler_init(void)
                    schedulers[i]->opt_name);
             schedulers[i] = NULL;
         }
-
-        if ( schedulers[i] && !ops.name &&
-             !strcmp(schedulers[i]->opt_name, opt_sched) )
-            ops = *schedulers[i];
     }
 
-    if ( !ops.name )
+    scheduler = sched_get_by_name(opt_sched);
+    if ( !scheduler )
     {
         printk("Could not find scheduler: %s\n", opt_sched);
-        for ( i = 0; i < NUM_SCHEDULERS; i++ )
-            if ( schedulers[i] &&
-                 !strcmp(schedulers[i]->opt_name, CONFIG_SCHED_DEFAULT) )
-            {
-                ops = *schedulers[i];
-                break;
-            }
-        BUG_ON(!ops.name);
-        printk("Using '%s' (%s)\n", ops.name, ops.opt_name);
+        scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT);
+        BUG_ON(!scheduler);
+        printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name);
     }
+    ops = *scheduler;
 
     if ( cpu_schedule_up(0) )
         BUG();
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index b07717987434..b527f141a1d3 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -758,6 +758,17 @@ void sched_destroy_domain(struct domain *d);
 long sched_adjust(struct domain *, struct xen_domctl_scheduler_op *);
 long sched_adjust_global(struct xen_sysctl_scheduler_op *);
 int  sched_id(void);
+
+/*
+ * sched_get_id_by_name - retrieves a scheduler id given a scheduler name
+ * @sched_name: scheduler name as a string
+ *
+ * returns:
+ *     positive value being the scheduler id, on success
+ *     negative value if the scheduler name is not found.
+ */
+int sched_get_id_by_name(const char *sched_name);
+
 void vcpu_wake(struct vcpu *v);
 long vcpu_yield(void);
 void vcpu_sleep_nosync(struct vcpu *v);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:58:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:58:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298620.508779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0j-0006Ma-Dc; Tue, 05 Apr 2022 08:58:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298620.508779; Tue, 05 Apr 2022 08:58:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0j-0006M9-9h; Tue, 05 Apr 2022 08:58:01 +0000
Received: by outflank-mailman (input) for mailman id 298620;
 Tue, 05 Apr 2022 08:57:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eUJf=UP=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nbf0h-0005F2-IT
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:57:59 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 79cbbab0-b4be-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 10:57:52 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 547DD1474;
 Tue,  5 Apr 2022 01:57:57 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A877E3F73B;
 Tue,  5 Apr 2022 01:57:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79cbbab0-b4be-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot time
Date: Tue,  5 Apr 2022 09:57:39 +0100
Message-Id: <20220405085741.18336-5-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220405085741.18336-1-luca.fancellu@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>

Introduce a way to create different cpupools at boot time, this is
particularly useful on ARM big.LITTLE system where there might be the
need to have different cpupools for each type of core, but also
systems using NUMA can have different cpu pools for each node.

The feature on arm relies on a specification of the cpupools from the
device tree to build pools and assign cpus to them.

Documentation is created to explain the feature.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Changes in v5:
- Fixed wrong variable name, swapped schedulers, add scheduler info
  in the printk (Stefano)
- introduce assert in cpupool_init and btcpupools_get_cpupool_id to
  harden the code
Changes in v4:
- modify Makefile to put in *.init.o, fixed stubs and macro (Jan)
- fixed docs, fix brakets (Stefano)
- keep cpu0 in Pool-0 (Julien)
- moved printk from btcpupools_allocate_pools to
  btcpupools_get_cpupool_id
- Add to docs constraint about cpu0 and Pool-0
Changes in v3:
- Add newline to cpupools.txt and removed "default n" from Kconfig (Jan)
- Fixed comment, moved defines, used global cpu_online_map, use
  HAS_DEVICE_TREE instead of ARM and place arch specific code in header
  (Juergen)
- Fix brakets, x86 code only panic, get rid of scheduler dt node, don't
  save pool pointer and look for it from the pool list (Stefano)
- Changed data structures to allow modification to the code.
Changes in v2:
- Move feature to common code (Juergen)
- Try to decouple dtb parse and cpupool creation to allow
  more way to specify cpupools (for example command line)
- Created standalone dt node for the scheduler so it can
  be used in future work to set scheduler specific
  parameters
- Use only auto generated ids for cpupools
---
 docs/misc/arm/device-tree/cpupools.txt | 136 +++++++++++++++++
 xen/arch/arm/include/asm/smp.h         |   3 +
 xen/common/Kconfig                     |   7 +
 xen/common/Makefile                    |   1 +
 xen/common/boot_cpupools.c             | 203 +++++++++++++++++++++++++
 xen/common/sched/cpupool.c             |  12 +-
 xen/include/xen/sched.h                |  14 ++
 7 files changed, 375 insertions(+), 1 deletion(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/common/boot_cpupools.c

diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
new file mode 100644
index 000000000000..5dac2b1384e0
--- /dev/null
+++ b/docs/misc/arm/device-tree/cpupools.txt
@@ -0,0 +1,136 @@
+Boot time cpupools
+==================
+
+When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
+create cpupools during boot phase by specifying them in the device tree.
+
+Cpupools specification nodes shall be direct childs of /chosen node.
+Each cpupool node contains the following properties:
+
+- compatible (mandatory)
+
+    Must always include the compatiblity string: "xen,cpupool".
+
+- cpupool-cpus (mandatory)
+
+    Must be a list of device tree phandle to nodes describing cpus (e.g. having
+    device_type = "cpu"), it can't be empty.
+
+- cpupool-sched (optional)
+
+    Must be a string having the name of a Xen scheduler. Check the sched=<...>
+    boot argument for allowed values.
+
+
+Constraints
+===========
+
+If no cpupools are specified, all cpus will be assigned to one cpupool
+implicitly created (Pool-0).
+
+If cpupools node are specified, but not every cpu brought up by Xen is assigned,
+all the not assigned cpu will be assigned to an additional cpupool.
+
+If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
+stop.
+
+The boot cpu must be assigned to Pool-0, so the cpupool containing that core
+will become Pool-0 automatically.
+
+
+Examples
+========
+
+A system having two types of core, the following device tree specification will
+instruct Xen to have two cpupools:
+
+- The cpupool with id 0 will have 4 cpus assigned.
+- The cpupool with id 1 will have 2 cpus assigned.
+
+The following example can work only if hmp-unsafe=1 is passed to Xen boot
+arguments, otherwise not all cores will be brought up by Xen and the cpupool
+creation process will stop Xen.
+
+
+a72_1: cpu@0 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x0>;
+        device_type = "cpu";
+        [...]
+};
+
+a72_2: cpu@1 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x1>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_1: cpu@100 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x100>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_2: cpu@101 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x101>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_3: cpu@102 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x102>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_4: cpu@103 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x103>;
+        device_type = "cpu";
+        [...]
+};
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a53_1 &a53_2 &a53_3 &a53_4>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "credit2";
+    };
+
+    [...]
+
+};
+
+
+A system having the cpupools specification below will instruct Xen to have three
+cpupools:
+
+- The cpupool Pool-0 will have 2 cpus assigned.
+- The cpupool Pool-1 will have 2 cpus assigned.
+- The cpupool Pool-2 will have 2 cpus assigned (created by Xen with all the not
+  assigned cpus a53_3 and a53_4).
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a53_1 &a53_2>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "null";
+    };
+
+    [...]
+
+};
diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h
index af5a2fe65266..83c0cd69767b 100644
--- a/xen/arch/arm/include/asm/smp.h
+++ b/xen/arch/arm/include/asm/smp.h
@@ -34,6 +34,9 @@ extern void init_secondary(void);
 extern void smp_init_cpus(void);
 extern void smp_clear_cpu_maps (void);
 extern int smp_get_max_cpus (void);
+
+#define cpu_physical_id(cpu) cpu_logical_map(cpu)
+
 #endif
 
 /*
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index d921c74d615e..70aac5220e75 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -22,6 +22,13 @@ config GRANT_TABLE
 
 	  If unsure, say Y.
 
+config BOOT_TIME_CPUPOOLS
+	bool "Create cpupools at boot time"
+	depends on HAS_DEVICE_TREE
+	help
+	  Creates cpupools during boot time and assigns cpus to them. Cpupools
+	  options can be specified in the device tree.
+
 config ALTERNATIVE_CALL
 	bool
 
diff --git a/xen/common/Makefile b/xen/common/Makefile
index dc8d3a13f5b8..e30cd26eef70 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -1,5 +1,6 @@
 obj-$(CONFIG_ARGO) += argo.o
 obj-y += bitmap.o
+obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot_cpupools.init.o
 obj-$(CONFIG_HYPFS_CONFIG) += config_data.o
 obj-$(CONFIG_CORE_PARKING) += core_parking.o
 obj-y += cpu.o
diff --git a/xen/common/boot_cpupools.c b/xen/common/boot_cpupools.c
new file mode 100644
index 000000000000..97c321386879
--- /dev/null
+++ b/xen/common/boot_cpupools.c
@@ -0,0 +1,203 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * xen/common/boot_cpupools.c
+ *
+ * Code to create cpupools at boot time.
+ *
+ * Copyright (C) 2022 Arm Ltd.
+ */
+
+#include <xen/sched.h>
+
+/*
+ * pool_cpu_map:   Index is logical cpu number, content is cpupool id, (-1) for
+ *                 unassigned.
+ * pool_sched_map: Index is cpupool id, content is scheduler id, (-1) for
+ *                 unassigned.
+ */
+static int __initdata pool_cpu_map[NR_CPUS]   = { [0 ... NR_CPUS-1] = -1 };
+static int __initdata pool_sched_map[NR_CPUS] = { [0 ... NR_CPUS-1] = -1 };
+static unsigned int __initdata next_pool_id;
+
+#define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
+#define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
+
+static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
+{
+    unsigned int i;
+
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpu_physical_id(i) == hwid )
+            return i;
+    }
+
+    return -1;
+}
+
+static int __init
+get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
+{
+    int cpu_num;
+    const __be32 *prop;
+    unsigned int cpu_reg;
+
+    prop = dt_get_property(cpu_node, "reg", NULL);
+    if ( !prop )
+        return BTCPUPOOLS_DT_NODE_NO_REG;
+
+    cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node));
+
+    cpu_num = get_logical_cpu_from_hw_id(cpu_reg);
+    if ( cpu_num < 0 )
+        return BTCPUPOOLS_DT_NODE_NO_LOG_CPU;
+
+    return cpu_num;
+}
+
+static int __init check_and_get_sched_id(const char* scheduler_name)
+{
+    int sched_id = sched_get_id_by_name(scheduler_name);
+
+    if ( sched_id < 0 )
+        panic("Scheduler %s does not exists!\n", scheduler_name);
+
+    return sched_id;
+}
+
+void __init btcpupools_dtb_parse(void)
+{
+    const struct dt_device_node *chosen, *node;
+
+    chosen = dt_find_node_by_path("/chosen");
+    if ( !chosen )
+        return;
+
+    dt_for_each_child_node(chosen, node)
+    {
+        const struct dt_device_node *phandle_node;
+        int sched_id = -1;
+        const char* scheduler_name;
+        unsigned int i = 0;
+
+        if ( !dt_device_is_compatible(node, "xen,cpupool") )
+            continue;
+
+        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) )
+            sched_id = check_and_get_sched_id(scheduler_name);
+
+        phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
+        if ( !phandle_node )
+            panic("Missing or empty cpupool-cpus property!\n");
+
+        while ( phandle_node )
+        {
+            int cpu_num;
+
+            cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
+
+            if ( cpu_num < 0 )
+                panic("Error retrieving logical cpu from node %s (%d)\n",
+                      dt_node_name(node), cpu_num);
+
+            if ( pool_cpu_map[cpu_num] != -1 )
+                panic("Logical cpu %d already added to a cpupool!\n", cpu_num);
+
+            pool_cpu_map[cpu_num] = next_pool_id;
+
+            phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
+        }
+
+        /* Save scheduler choice for this cpupool id */
+        pool_sched_map[next_pool_id] = sched_id;
+
+        /* Let Xen generate pool ids */
+        next_pool_id++;
+    }
+}
+
+void __init btcpupools_allocate_pools(void)
+{
+    unsigned int i;
+    bool add_extra_cpupool = false;
+    int swap_id = -1;
+
+    /*
+     * If there are no cpupools, the value of next_pool_id is zero, so the code
+     * below will assign every cpu to cpupool0 as the default behavior.
+     * When there are cpupools, the code below is assigning all the not
+     * assigned cpu to a new pool (next_pool_id value is the last id + 1).
+     * In the same loop we check if there is any assigned cpu that is not
+     * online.
+     */
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpumask_test_cpu(i, &cpu_online_map) )
+        {
+            /* Unassigned cpu gets next_pool_id pool id value */
+            if ( pool_cpu_map[i] < 0 )
+            {
+                pool_cpu_map[i] = next_pool_id;
+                add_extra_cpupool = true;
+            }
+
+            /*
+             * Cpu0 must be in cpupool0, otherwise some operations like moving
+             * cpus between cpupools, cpu hotplug, destroying cpupools, shutdown
+             * of the host, might not work in a sane way.
+             */
+            if ( !i && (pool_cpu_map[0] != 0) )
+                swap_id = pool_cpu_map[0];
+
+            if ( swap_id != -1 )
+            {
+                if ( pool_cpu_map[i] == swap_id )
+                    pool_cpu_map[i] = 0;
+                else if ( pool_cpu_map[i] == 0 )
+                    pool_cpu_map[i] = swap_id;
+            }
+        }
+        else
+        {
+            if ( pool_cpu_map[i] >= 0 )
+                panic("Pool-%d contains cpu%u that is not online!\n",
+                      pool_cpu_map[i], i);
+        }
+    }
+
+    /* A swap happened, swap schedulers between cpupool id 0 and the other */
+    if ( swap_id != -1 )
+    {
+        int swap_sched = pool_sched_map[swap_id];
+
+        pool_sched_map[swap_id] = pool_sched_map[0];
+        pool_sched_map[0] = swap_sched;
+    }
+
+    if ( add_extra_cpupool )
+        next_pool_id++;
+
+    /* Create cpupools with selected schedulers */
+    for ( i = 0; i < next_pool_id; i++ )
+        cpupool_create_pool(i, pool_sched_map[i]);
+}
+
+unsigned int __init btcpupools_get_cpupool_id(unsigned int cpu)
+{
+    ASSERT((cpu < NR_CPUS) && (pool_cpu_map[cpu] >= 0));
+
+    printk(XENLOG_INFO "Logical CPU %u in Pool-%d (Scheduler id: %d).\n",
+           cpu, pool_cpu_map[cpu], pool_sched_map[pool_cpu_map[cpu]]);
+
+    return pool_cpu_map[cpu];
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 89a891af7076..86a175f99cd5 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1247,12 +1247,22 @@ static int __init cf_check cpupool_init(void)
     cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
+    btcpupools_dtb_parse();
+
+    btcpupools_allocate_pools();
+
     spin_lock(&cpupool_lock);
 
     cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
 
     for_each_cpu ( cpu, &cpupool_free_cpus )
-        cpupool_assign_cpu_locked(cpupool0, cpu);
+    {
+        unsigned int pool_id = btcpupools_get_cpupool_id(cpu);
+        struct cpupool *pool = cpupool_find_by_id(pool_id);
+
+        ASSERT(pool);
+        cpupool_assign_cpu_locked(pool, cpu);
+    }
 
     spin_unlock(&cpupool_lock);
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index b527f141a1d3..453e98f1cba8 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1178,6 +1178,20 @@ extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 
+#ifdef CONFIG_BOOT_TIME_CPUPOOLS
+void btcpupools_allocate_pools(void);
+unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
+void btcpupools_dtb_parse(void);
+
+#else /* !CONFIG_BOOT_TIME_CPUPOOLS */
+static inline void btcpupools_allocate_pools(void) {}
+static inline void btcpupools_dtb_parse(void) {}
+static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
+{
+    return 0;
+}
+#endif
+
 #endif /* __SCHED_H__ */
 
 /*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:58:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298621.508784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0k-0006Tw-1H; Tue, 05 Apr 2022 08:58:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298621.508784; Tue, 05 Apr 2022 08:58:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0j-0006S4-Rk; Tue, 05 Apr 2022 08:58:01 +0000
Received: by outflank-mailman (input) for mailman id 298621;
 Tue, 05 Apr 2022 08:58:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eUJf=UP=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nbf0i-0005F8-Vf
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:58:01 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 7debc598-b4be-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 10:57:59 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0A15D6E;
 Tue,  5 Apr 2022 01:57:58 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C8CD3F73B;
 Tue,  5 Apr 2022 01:57:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7debc598-b4be-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v5 5/6] arm/dom0less: assign dom0less guests to cpupools
Date: Tue,  5 Apr 2022 09:57:40 +0100
Message-Id: <20220405085741.18336-6-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220405085741.18336-1-luca.fancellu@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>

Introduce domain-cpupool property of a xen,domain device tree node,
that specifies the cpupool device tree handle of a xen,cpupool node
that identifies a cpupool created at boot time where the guest will
be assigned on creation.

Add member to the xen_domctl_createdomain public interface so the
XEN_DOMCTL_INTERFACE_VERSION version is bumped.

Add public function to retrieve a pool id from the device tree
cpupool node.

Update documentation about the property.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes in v5:
- no changes
Changes in v4:
- no changes
- add R-by
Changes in v3:
- Use explicitely sized integer for struct xen_domctl_createdomain
  cpupool_id member. (Stefano)
- Changed code due to previous commit code changes
Changes in v2:
- Moved cpupool_id from arch specific to common part (Juergen)
- Implemented functions to retrieve the cpupool id from the
  cpupool dtb node.
---
 docs/misc/arm/device-tree/booting.txt |  5 +++++
 xen/arch/arm/domain_build.c           | 14 +++++++++++++-
 xen/common/boot_cpupools.c            | 24 ++++++++++++++++++++++++
 xen/common/domain.c                   |  2 +-
 xen/include/public/domctl.h           |  4 +++-
 xen/include/xen/sched.h               |  9 +++++++++
 6 files changed, 55 insertions(+), 3 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index a94125394e35..7b4a29a2c293 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -188,6 +188,11 @@ with the following properties:
     An empty property to request the memory of the domain to be
     direct-map (guest physical address == physical address).
 
+- domain-cpupool
+
+    Optional. Handle to a xen,cpupool device tree node that identifies the
+    cpupool where the guest will be started at boot.
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8be01678de05..9c67a483d4a4 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3172,7 +3172,8 @@ static int __init construct_domU(struct domain *d,
 void __init create_domUs(void)
 {
     struct dt_device_node *node;
-    const struct dt_device_node *chosen = dt_find_node_by_path("/chosen");
+    const struct dt_device_node *cpupool_node,
+                                *chosen = dt_find_node_by_path("/chosen");
 
     BUG_ON(chosen == NULL);
     dt_for_each_child_node(chosen, node)
@@ -3241,6 +3242,17 @@ void __init create_domUs(void)
                                          vpl011_virq - 32 + 1);
         }
 
+        /* Get the optional property domain-cpupool */
+        cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0);
+        if ( cpupool_node )
+        {
+            int pool_id = btcpupools_get_domain_pool_id(cpupool_node);
+            if ( pool_id < 0 )
+                panic("Error getting cpupool id from domain-cpupool (%d)\n",
+                      pool_id);
+            d_cfg.cpupool_id = pool_id;
+        }
+
         /*
          * The variable max_init_domid is initialized with zero, so here it's
          * very important to use the pre-increment operator to call
diff --git a/xen/common/boot_cpupools.c b/xen/common/boot_cpupools.c
index 97c321386879..1f940330a62d 100644
--- a/xen/common/boot_cpupools.c
+++ b/xen/common/boot_cpupools.c
@@ -21,6 +21,8 @@ static unsigned int __initdata next_pool_id;
 
 #define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
 #define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
+#define BTCPUPOOLS_DT_WRONG_NODE      (-3)
+#define BTCPUPOOLS_DT_CORRUPTED_NODE  (-4)
 
 static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
 {
@@ -55,6 +57,28 @@ get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
     return cpu_num;
 }
 
+int __init btcpupools_get_domain_pool_id(const struct dt_device_node *node)
+{
+    const struct dt_device_node *phandle_node;
+    int cpu_num;
+
+    if ( !dt_device_is_compatible(node, "xen,cpupool") )
+        return BTCPUPOOLS_DT_WRONG_NODE;
+    /*
+     * Get first cpu listed in the cpupool, from its reg it's possible to
+     * retrieve the cpupool id.
+     */
+    phandle_node = dt_parse_phandle(node, "cpupool-cpus", 0);
+    if ( !phandle_node )
+        return BTCPUPOOLS_DT_CORRUPTED_NODE;
+
+    cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
+    if ( cpu_num < 0 )
+        return cpu_num;
+
+    return pool_cpu_map[cpu_num];
+}
+
 static int __init check_and_get_sched_id(const char* scheduler_name)
 {
     int sched_id = sched_get_id_by_name(scheduler_name);
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 351029f8b239..0827400f4f49 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -698,7 +698,7 @@ struct domain *domain_create(domid_t domid,
         if ( !d->pbuf )
             goto fail;
 
-        if ( (err = sched_init_domain(d, 0)) != 0 )
+        if ( (err = sched_init_domain(d, config->cpupool_id)) != 0 )
             goto fail;
 
         if ( (err = late_hwdom_init(d)) != 0 )
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0aa..2f4cf56f438d 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
@@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
     /* Per-vCPU buffer size in bytes.  0 to disable. */
     uint32_t vmtrace_size;
 
+    uint32_t cpupool_id;
+
     struct xen_arch_domainconfig arch;
 };
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 453e98f1cba8..b62315ad5e5d 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1182,6 +1182,7 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 void btcpupools_allocate_pools(void);
 unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
 void btcpupools_dtb_parse(void);
+int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
 
 #else /* !CONFIG_BOOT_TIME_CPUPOOLS */
 static inline void btcpupools_allocate_pools(void) {}
@@ -1190,6 +1191,14 @@ static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
 {
     return 0;
 }
+#ifdef CONFIG_HAS_DEVICE_TREE
+static inline int
+btcpupools_get_domain_pool_id(const struct dt_device_node *node)
+{
+    return 0;
+}
+#endif
+
 #endif
 
 #endif /* __SCHED_H__ */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 08:58:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 08:58:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298622.508798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0l-0006rZ-G2; Tue, 05 Apr 2022 08:58:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298622.508798; Tue, 05 Apr 2022 08:58:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf0l-0006py-80; Tue, 05 Apr 2022 08:58:03 +0000
Received: by outflank-mailman (input) for mailman id 298622;
 Tue, 05 Apr 2022 08:58:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eUJf=UP=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nbf0j-0005F8-Vw
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 08:58:02 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 7eb4b26c-b4be-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 10:58:00 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8DA0C1474;
 Tue,  5 Apr 2022 01:58:00 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 24DBE3F73B;
 Tue,  5 Apr 2022 01:57:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7eb4b26c-b4be-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH v5 6/6] xen/cpupool: Allow cpupool0 to use different scheduler
Date: Tue,  5 Apr 2022 09:57:41 +0100
Message-Id: <20220405085741.18336-7-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220405085741.18336-1-luca.fancellu@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>

Currently cpupool0 can use only the default scheduler, and
cpupool_create has an hardcoded behavior when creating the pool 0
that doesn't allocate new memory for the scheduler, but uses the
default scheduler structure in memory.

With this commit it is possible to allocate a different scheduler for
the cpupool0 when using the boot time cpupool.
To achieve this the hardcoded behavior in cpupool_create is removed
and the cpupool0 creation is moved.

When compiling without boot time cpupools enabled, the current
behavior is maintained (except that cpupool0 scheduler memory will be
allocated).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- fix typo in commit message (Juergen)
- rebase changes
Changes in v2:
- new patch
---
 xen/common/boot_cpupools.c | 5 ++++-
 xen/common/sched/cpupool.c | 8 +-------
 xen/include/xen/sched.h    | 5 ++++-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/xen/common/boot_cpupools.c b/xen/common/boot_cpupools.c
index 1f940330a62d..a56baf3329a9 100644
--- a/xen/common/boot_cpupools.c
+++ b/xen/common/boot_cpupools.c
@@ -201,8 +201,11 @@ void __init btcpupools_allocate_pools(void)
     if ( add_extra_cpupool )
         next_pool_id++;
 
+    /* Keep track of cpupool id 0 with the global cpupool0 */
+    cpupool0 = cpupool_create_pool(0, pool_sched_map[0]);
+
     /* Create cpupools with selected schedulers */
-    for ( i = 0; i < next_pool_id; i++ )
+    for ( i = 1; i < next_pool_id; i++ )
         cpupool_create_pool(i, pool_sched_map[i]);
 }
 
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 86a175f99cd5..83112f5f04d3 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -312,10 +312,7 @@ static struct cpupool *cpupool_create(unsigned int poolid,
         c->cpupool_id = q->cpupool_id + 1;
     }
 
-    if ( poolid == 0 )
-        c->sched = scheduler_get_default();
-    else
-        c->sched = scheduler_alloc(sched_id);
+    c->sched = scheduler_alloc(sched_id);
     if ( IS_ERR(c->sched) )
     {
         ret = PTR_ERR(c->sched);
@@ -1242,9 +1239,6 @@ static int __init cf_check cpupool_init(void)
 
     cpupool_hypfs_init();
 
-    cpupool0 = cpupool_create(0, 0);
-    BUG_ON(IS_ERR(cpupool0));
-    cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
     btcpupools_dtb_parse();
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index b62315ad5e5d..e8f31758c058 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1185,7 +1185,10 @@ void btcpupools_dtb_parse(void);
 int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
 
 #else /* !CONFIG_BOOT_TIME_CPUPOOLS */
-static inline void btcpupools_allocate_pools(void) {}
+static inline void btcpupools_allocate_pools(void)
+{
+    cpupool0 = cpupool_create_pool(0, -1);
+}
 static inline void btcpupools_dtb_parse(void) {}
 static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
 {
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 09:05:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 09:05:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298643.508812 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf7m-0001p9-95; Tue, 05 Apr 2022 09:05:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298643.508812; Tue, 05 Apr 2022 09:05:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbf7m-0001p2-5g; Tue, 05 Apr 2022 09:05:18 +0000
Received: by outflank-mailman (input) for mailman id 298643;
 Tue, 05 Apr 2022 09:05:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qA5z=UP=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nbf7k-0001ow-14
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 09:05:16 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 7dfeb9e1-b4bf-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 11:05:09 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B5016D6E;
 Tue,  5 Apr 2022 02:05:13 -0700 (PDT)
Received: from [10.57.6.204] (unknown [10.57.6.204])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 44CCF3F73B;
 Tue,  5 Apr 2022 02:05:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7dfeb9e1-b4bf-11ec-8fbc-03012f2f19d4
Message-ID: <75f01105-3885-2053-1d4e-1aaf8b75aced@arm.com>
Date: Tue, 5 Apr 2022 11:05:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v3 2/2] xen: Populate xen.lds.h and make use of its macros
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220331071425.49141-1-michal.orzel@arm.com>
 <20220331071425.49141-3-michal.orzel@arm.com>
 <eaf82b61-de3b-b2c2-b6f5-2b43b3348a09@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <eaf82b61-de3b-b2c2-b6f5-2b43b3348a09@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Jan,

On 05.04.2022 10:49, Jan Beulich wrote:
> On 31.03.2022 09:14, Michal Orzel wrote:
>> --- a/xen/include/xen/xen.lds.h
>> +++ b/xen/include/xen/xen.lds.h
>> @@ -5,4 +5,133 @@
>>   * Common macros to be used in architecture specific linker scripts.
>>   */
>>  
>> +/*
>> + * To avoid any confusion, please note that the EFI macro does not correspond
>> + * to EFI support and is used when linking a native EFI (i.e. PE/COFF) binary,
>> + * hence its usage in this header.
>> + */
>> +
>> +/* Macros to declare debug sections. */
>> +#ifdef EFI
>> +/*
>> + * Use the NOLOAD directive, despite currently ignored by (at least) GNU ld
>> + * for PE output, in order to record that we'd prefer these sections to not
>> + * be loaded into memory.
>> + */
>> +#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) }
>> +#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) }
>> +#else
>> +#define DECL_DEBUG(x, a) #x 0 : { *(x) }
>> +#define DECL_DEBUG2(x, y, a) #x 0 : { *(x) *(y) }
>> +#endif
>> +
>> +/*
>> + * DWARF2+ debug sections.
>> + * Explicitly list debug sections, first of all to avoid these sections being
>> + * viewed as "orphan" by the linker.
>> + *
>> + * For the PE output this is further necessary so that they don't end up at
>> + * VA 0, which is below image base and thus invalid. Note that this macro is
>> + * to be used after _end, so if these sections get loaded they'll be discarded
>> + * at runtime anyway.
>> + */
>> +#define DWARF2_DEBUG_SECTIONS                     \
>> +  DECL_DEBUG(.debug_abbrev, 1)                    \
>> +  DECL_DEBUG2(.debug_info, .gnu.linkonce.wi.*, 1) \
>> +  DECL_DEBUG(.debug_types, 1)                     \
>> +  DECL_DEBUG(.debug_str, 1)                       \
>> +  DECL_DEBUG2(.debug_line, .debug_line.*, 1)      \
>> +  DECL_DEBUG(.debug_line_str, 1)                  \
>> +  DECL_DEBUG(.debug_names, 4)                     \
>> +  DECL_DEBUG(.debug_frame, 4)                     \
>> +  DECL_DEBUG(.debug_loc, 1)                       \
>> +  DECL_DEBUG(.debug_loclists, 4)                  \
>> +  DECL_DEBUG(.debug_macinfo, 1)                   \
>> +  DECL_DEBUG(.debug_macro, 1)                     \
>> +  DECL_DEBUG(.debug_ranges, 8)                    \
> 
> Here and ...
> 
>> +  DECL_DEBUG(.debug_rnglists, 4)                  \
>> +  DECL_DEBUG(.debug_addr, 8)                      \
> 
> ... here I think you also want to switch to POINTER_ALIGN.
> 
Ok, you're right.

>> +  DECL_DEBUG(.debug_aranges, 1)                   \
>> +  DECL_DEBUG(.debug_pubnames, 1)                  \
>> +  DECL_DEBUG(.debug_pubtypes, 1)
>> +
>> +/* Stabs debug sections. */
>> +#define STABS_DEBUG_SECTIONS                 \
>> +  .stab 0 : { *(.stab) }                     \
>> +  .stabstr 0 : { *(.stabstr) }               \
>> +  .stab.excl 0 : { *(.stab.excl) }           \
>> +  .stab.exclstr 0 : { *(.stab.exclstr) }     \
>> +  .stab.index 0 : { *(.stab.index) }         \
>> +  .stab.indexstr 0 : { *(.stab.indexstr) }
>> +
>> +/*
>> + * Required sections not related to debugging.
> 
> Nit: Perhaps better "Required ELF sections ..."? Personally I'd also
> drop the mentioning of debugging - that's not really relevant here.
> I'm also unsure about "Required" - .comment isn't really required.
> IOW ideally simply "ELF sections" or "Sections to be retained in ELF
> binaries" or some such.
> 
ELF sections is ok for me.

> Jan
> 

I will push updated series soon.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 09:16:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 09:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298651.508834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfIe-0003e5-Is; Tue, 05 Apr 2022 09:16:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298651.508834; Tue, 05 Apr 2022 09:16:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfIe-0003dy-Fq; Tue, 05 Apr 2022 09:16:32 +0000
Received: by outflank-mailman (input) for mailman id 298651;
 Tue, 05 Apr 2022 09:16:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qA5z=UP=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nbfId-0003OJ-Pv
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 09:16:31 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 1455d9f3-b4c1-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 11:16:30 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 58BDBD6E;
 Tue,  5 Apr 2022 02:16:30 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.6.204])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4BCC13F73B;
 Tue,  5 Apr 2022 02:16:28 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1455d9f3-b4c1-11ec-a405-831a346695d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v4 1/2] xen: Introduce a header to store common linker scripts content
Date: Tue,  5 Apr 2022 11:16:15 +0200
Message-Id: <20220405091616.200270-2-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220405091616.200270-1-michal.orzel@arm.com>
References: <20220405091616.200270-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Both x86 and arm linker scripts share quite a lot of common content.
It is difficult to keep syncing them up, thus introduce a new header
in include/xen called xen.lds.h to store the internals mutual to all
the linker scripts.

Include this header in linker scripts for x86 and arm.
This patch serves as an intermediate step before populating xen.lds.h
and making use of its content in the linker scripts later on.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
Changes since v2,v3:
-none
Changes since v1:
-rename header to xen.lds.h to be coherent with Linux kernel
-include empty header in linker scripts
---
 xen/arch/arm/xen.lds.S    | 1 +
 xen/arch/x86/xen.lds.S    | 1 +
 xen/include/xen/xen.lds.h | 8 ++++++++
 3 files changed, 10 insertions(+)
 create mode 100644 xen/include/xen/xen.lds.h

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index 7921d8fa28..c666fc3e69 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -3,6 +3,7 @@
 /* Modified for ARM Xen by Ian Campbell */
 
 #include <xen/cache.h>
+#include <xen/xen.lds.h>
 #include <asm/page.h>
 #undef ENTRY
 #undef ALIGN
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 3f9f633f55..3e65c09bb3 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -2,6 +2,7 @@
 /* Modified for i386/x86-64 Xen by Keir Fraser */
 
 #include <xen/cache.h>
+#include <xen/xen.lds.h>
 #include <asm/page.h>
 #undef ENTRY
 #undef ALIGN
diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h
new file mode 100644
index 0000000000..dd292fa7dc
--- /dev/null
+++ b/xen/include/xen/xen.lds.h
@@ -0,0 +1,8 @@
+#ifndef __XEN_LDS_H__
+#define __XEN_LDS_H__
+
+/*
+ * Common macros to be used in architecture specific linker scripts.
+ */
+
+#endif /* __XEN_LDS_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 09:16:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 09:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298650.508823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfId-0003OW-Bx; Tue, 05 Apr 2022 09:16:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298650.508823; Tue, 05 Apr 2022 09:16:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfId-0003OP-7n; Tue, 05 Apr 2022 09:16:31 +0000
Received: by outflank-mailman (input) for mailman id 298650;
 Tue, 05 Apr 2022 09:16:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qA5z=UP=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nbfIc-0003OJ-95
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 09:16:30 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 12dbde89-b4c1-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 11:16:28 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD541D6E;
 Tue,  5 Apr 2022 02:16:27 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.6.204])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B77D3F73B;
 Tue,  5 Apr 2022 02:16:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12dbde89-b4c1-11ec-a405-831a346695d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v4 0/2] xen: Linker scripts synchronization
Date: Tue,  5 Apr 2022 11:16:14 +0200
Message-Id: <20220405091616.200270-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series aims to do the first step towards linker scripts
synchronization. Linker scripts for arm and x86 share a lot of common
sections and in order to make the process of changing/improving/syncing
them, these sections shall be defined in just one place.

The first patch creates an empty header file xen.lds.h to store the
constructs mutual to both x86 and arm linker scripts. It also includes
this header in the scripts.

The second patch populates xen.lds.h with the first portion of common
macros and replaces the original contructs with these helpers.

Michal Orzel (2):
  xen: Introduce a header to store common linker scripts content
  xen: Populate xen.lds.h and make use of its macros

 xen/arch/arm/xen.lds.S    |  45 +++----------
 xen/arch/x86/xen.lds.S    |  97 +++------------------------
 xen/include/xen/xen.lds.h | 137 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 157 insertions(+), 122 deletions(-)
 create mode 100644 xen/include/xen/xen.lds.h

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 09:16:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 09:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298652.508845 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfIi-0003xJ-RT; Tue, 05 Apr 2022 09:16:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298652.508845; Tue, 05 Apr 2022 09:16:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfIi-0003x4-OP; Tue, 05 Apr 2022 09:16:36 +0000
Received: by outflank-mailman (input) for mailman id 298652;
 Tue, 05 Apr 2022 09:16:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qA5z=UP=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nbfIh-0003uw-JH
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 09:16:35 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 12f6b601-b4c1-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 11:16:28 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3BC93D6E;
 Tue,  5 Apr 2022 02:16:33 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.6.204])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB6A03F73B;
 Tue,  5 Apr 2022 02:16:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12f6b601-b4c1-11ec-8fbc-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros
Date: Tue,  5 Apr 2022 11:16:16 +0200
Message-Id: <20220405091616.200270-3-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220405091616.200270-1-michal.orzel@arm.com>
References: <20220405091616.200270-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Populate header file xen.lds.h with the first portion of macros storing
constructs common to x86 and arm linker scripts. Replace the original
constructs with these helpers.

No functional improvements to x86 linker script.

Making use of common macros improves arm linker script with:
- explicit list of debug sections that otherwise are seen as "orphans"
  by the linker. This will allow to fix issues after enabling linker
  option --orphan-handling one day,
- extended list of discarded section to include: .discard, destructors
  related sections, .fini_array which can reference .text.exit,
- sections not related to debugging that are placed by ld.lld. Even
  though we do not support linking with LLD on Arm, these sections do
  not cause problem to GNU ld.

Please note that this patch does not aim to perform the full sync up
between the linker scripts. It creates a base for further work.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes since v3:
-use POINTER_ALIGN in debug sections when needed
-modify comment about ELF_DETAILS_SECTIONS
Changes since v2:
-refactor commit msg
-move constructs together with surrounding ifdefery
-list constructs other than *_SECTIONS in alphabetical order
-add comment about EFI vs EFI support
Changes since v1:
-merge x86 and arm changes into single patch
-do not propagate issues by generalizing CTORS
-extract sections not related to debugging into separate macro
-get rid of _SECTION suffix in favor of using more meaningful suffixes
---
 xen/arch/arm/xen.lds.S    |  44 +++----------
 xen/arch/x86/xen.lds.S    |  96 +++-------------------------
 xen/include/xen/xen.lds.h | 129 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 147 insertions(+), 122 deletions(-)

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index c666fc3e69..649aa04f7f 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -68,12 +68,7 @@ SECTIONS
        *(.proc.info)
        __proc_info_end = .;
 
-#ifdef CONFIG_HAS_VPCI
-       . = ALIGN(POINTER_ALIGN);
-       __start_vpci_array = .;
-       *(SORT(.data.vpci.*))
-       __end_vpci_array = .;
-#endif
+       VPCI_ARRAY
   } :text
 
 #if defined(BUILD_ID)
@@ -109,12 +104,7 @@ SECTIONS
        *(.data.schedulers)
        __end_schedulers_array = .;
 
-#ifdef CONFIG_HYPFS
-       . = ALIGN(8);
-       __paramhypfs_start = .;
-       *(.data.paramhypfs)
-       __paramhypfs_end = .;
-#endif
+       HYPFS_PARAM
 
        *(.data .data.*)
        CONSTRUCTORS
@@ -178,12 +168,7 @@ SECTIONS
        *(.altinstructions)
        __alt_instructions_end = .;
 
-#ifdef CONFIG_DEBUG_LOCK_PROFILE
-       . = ALIGN(POINTER_ALIGN);
-       __lock_profile_start = .;
-       *(.lockprofile.data)
-       __lock_profile_end = .;
-#endif
+       LOCK_PROFILE_DATA
 
        *(.init.data)
        *(.init.data.rel)
@@ -222,22 +207,13 @@ SECTIONS
   /* Section for the device tree blob (if any). */
   .dtb : { *(.dtb) } :text
 
-  /* Sections to be discarded */
-  /DISCARD/ : {
-       *(.exit.text)
-       *(.exit.data)
-       *(.exitcall.exit)
-       *(.eh_frame)
-  }
-
-  /* Stabs debugging sections.  */
-  .stab 0 : { *(.stab) }
-  .stabstr 0 : { *(.stabstr) }
-  .stab.excl 0 : { *(.stab.excl) }
-  .stab.exclstr 0 : { *(.stab.exclstr) }
-  .stab.index 0 : { *(.stab.index) }
-  .stab.indexstr 0 : { *(.stab.indexstr) }
-  .comment 0 : { *(.comment) }
+  DWARF2_DEBUG_SECTIONS
+
+  DISCARD_SECTIONS
+
+  STABS_DEBUG_SECTIONS
+
+  ELF_DETAILS_SECTIONS
 }
 
 /*
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 3e65c09bb3..65cc4c9231 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -13,13 +13,6 @@
 #undef __XEN_VIRT_START
 #define __XEN_VIRT_START __image_base__
 #define DECL_SECTION(x) x :
-/*
- * Use the NOLOAD directive, despite currently ignored by (at least) GNU ld
- * for PE output, in order to record that we'd prefer these sections to not
- * be loaded into memory.
- */
-#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) }
-#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) }
 
 ENTRY(efi_start)
 
@@ -27,8 +20,6 @@ ENTRY(efi_start)
 
 #define FORMAT "elf64-x86-64"
 #define DECL_SECTION(x) #x : AT(ADDR(#x) - __XEN_VIRT_START)
-#define DECL_DEBUG(x, a) #x 0 : { *(x) }
-#define DECL_DEBUG2(x, y, a) #x 0 : { *(x) *(y) }
 
 ENTRY(start_pa)
 
@@ -159,12 +150,7 @@ SECTIONS
        *(.note.gnu.build-id)
        __note_gnu_build_id_end = .;
 #endif
-#ifdef CONFIG_HAS_VPCI
-       . = ALIGN(POINTER_ALIGN);
-       __start_vpci_array = .;
-       *(SORT(.data.vpci.*))
-       __end_vpci_array = .;
-#endif
+       VPCI_ARRAY
   } PHDR(text)
 
 #if defined(CONFIG_PVH_GUEST) && !defined(EFI)
@@ -278,12 +264,7 @@ SECTIONS
         *(.altinstructions)
         __alt_instructions_end = .;
 
-#ifdef CONFIG_DEBUG_LOCK_PROFILE
-       . = ALIGN(POINTER_ALIGN);
-       __lock_profile_start = .;
-       *(.lockprofile.data)
-       __lock_profile_end = .;
-#endif
+       LOCK_PROFILE_DATA
 
        . = ALIGN(8);
        __ctors_start = .;
@@ -335,12 +316,7 @@ SECTIONS
        *(.data.schedulers)
        __end_schedulers_array = .;
 
-#ifdef CONFIG_HYPFS
-       . = ALIGN(8);
-       __paramhypfs_start = .;
-       *(.data.paramhypfs)
-       __paramhypfs_end = .;
-#endif
+       HYPFS_PARAM
   } PHDR(text)
 
   DECL_SECTION(.data) {
@@ -387,33 +363,7 @@ SECTIONS
   efi = .;
 #endif
 
-  /*
-   * Explicitly list debug sections, first of all to avoid these sections being
-   * viewed as "orphan" by the linker.
-   *
-   * For the PE output this is further necessary so that they don't end up at
-   * VA 0, which is below image base and thus invalid.  Note that we're past
-   * _end here, so if these sections get loaded they'll be discarded at runtime
-   * anyway.
-   */
-  DECL_DEBUG(.debug_abbrev, 1)
-  DECL_DEBUG2(.debug_info, .gnu.linkonce.wi.*, 1)
-  DECL_DEBUG(.debug_types, 1)
-  DECL_DEBUG(.debug_str, 1)
-  DECL_DEBUG2(.debug_line, .debug_line.*, 1)
-  DECL_DEBUG(.debug_line_str, 1)
-  DECL_DEBUG(.debug_names, 4)
-  DECL_DEBUG(.debug_frame, 4)
-  DECL_DEBUG(.debug_loc, 1)
-  DECL_DEBUG(.debug_loclists, 4)
-  DECL_DEBUG(.debug_macinfo, 1)
-  DECL_DEBUG(.debug_macro, 1)
-  DECL_DEBUG(.debug_ranges, 8)
-  DECL_DEBUG(.debug_rnglists, 4)
-  DECL_DEBUG(.debug_addr, 8)
-  DECL_DEBUG(.debug_aranges, 1)
-  DECL_DEBUG(.debug_pubnames, 1)
-  DECL_DEBUG(.debug_pubtypes, 1)
+  DWARF2_DEBUG_SECTIONS
 
 #ifdef EFI
   /* Trick the linker into setting the image size to no less than 16Mb. */
@@ -427,42 +377,12 @@ SECTIONS
   hv_hcall_page = ABSOLUTE(HV_HCALL_PAGE - XEN_VIRT_START + __XEN_VIRT_START);
 #endif
 
-  /* Sections to be discarded */
-  /DISCARD/ : {
-       *(.text.exit)
-       *(.exit.text)
-       *(.exit.data)
-       *(.exitcall.exit)
-       *(.discard)
-       *(.discard.*)
-       *(.eh_frame)
-       *(.dtors)
-       *(.dtors.*)
-       *(.fini_array)
-       *(.fini_array.*)
-#ifdef EFI
-       *(.comment)
-       *(.comment.*)
-       *(.note.*)
-#endif
-  }
+  DISCARD_SECTIONS
 
 #ifndef EFI
-  /* Stabs debugging sections.  */
-  .stab 0 : { *(.stab) }
-  .stabstr 0 : { *(.stabstr) }
-  .stab.excl 0 : { *(.stab.excl) }
-  .stab.exclstr 0 : { *(.stab.exclstr) }
-  .stab.index 0 : { *(.stab.index) }
-  .stab.indexstr 0 : { *(.stab.indexstr) }
-  .comment 0 : { *(.comment) *(.comment.*) }
-  /*
-   * LLVM ld also wants .symtab, .strtab, and .shstrtab placed. These look to
-   * be benign to GNU ld, so we can have them here unconditionally.
-   */
-  .symtab 0 : { *(.symtab) }
-  .strtab 0 : { *(.strtab) }
-  .shstrtab 0 : { *(.shstrtab) }
+  STABS_DEBUG_SECTIONS
+
+  ELF_DETAILS_SECTIONS
 #endif
 }
 
diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h
index dd292fa7dc..fc47bb1ccc 100644
--- a/xen/include/xen/xen.lds.h
+++ b/xen/include/xen/xen.lds.h
@@ -5,4 +5,133 @@
  * Common macros to be used in architecture specific linker scripts.
  */
 
+/*
+ * To avoid any confusion, please note that the EFI macro does not correspond
+ * to EFI support and is used when linking a native EFI (i.e. PE/COFF) binary,
+ * hence its usage in this header.
+ */
+
+/* Macros to declare debug sections. */
+#ifdef EFI
+/*
+ * Use the NOLOAD directive, despite currently ignored by (at least) GNU ld
+ * for PE output, in order to record that we'd prefer these sections to not
+ * be loaded into memory.
+ */
+#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) }
+#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) }
+#else
+#define DECL_DEBUG(x, a) #x 0 : { *(x) }
+#define DECL_DEBUG2(x, y, a) #x 0 : { *(x) *(y) }
+#endif
+
+/*
+ * DWARF2+ debug sections.
+ * Explicitly list debug sections, first of all to avoid these sections being
+ * viewed as "orphan" by the linker.
+ *
+ * For the PE output this is further necessary so that they don't end up at
+ * VA 0, which is below image base and thus invalid. Note that this macro is
+ * to be used after _end, so if these sections get loaded they'll be discarded
+ * at runtime anyway.
+ */
+#define DWARF2_DEBUG_SECTIONS                     \
+  DECL_DEBUG(.debug_abbrev, 1)                    \
+  DECL_DEBUG2(.debug_info, .gnu.linkonce.wi.*, 1) \
+  DECL_DEBUG(.debug_types, 1)                     \
+  DECL_DEBUG(.debug_str, 1)                       \
+  DECL_DEBUG2(.debug_line, .debug_line.*, 1)      \
+  DECL_DEBUG(.debug_line_str, 1)                  \
+  DECL_DEBUG(.debug_names, 4)                     \
+  DECL_DEBUG(.debug_frame, 4)                     \
+  DECL_DEBUG(.debug_loc, 1)                       \
+  DECL_DEBUG(.debug_loclists, 4)                  \
+  DECL_DEBUG(.debug_macinfo, 1)                   \
+  DECL_DEBUG(.debug_macro, 1)                     \
+  DECL_DEBUG(.debug_ranges, POINTER_ALIGN)        \
+  DECL_DEBUG(.debug_rnglists, 4)                  \
+  DECL_DEBUG(.debug_addr, POINTER_ALIGN)          \
+  DECL_DEBUG(.debug_aranges, 1)                   \
+  DECL_DEBUG(.debug_pubnames, 1)                  \
+  DECL_DEBUG(.debug_pubtypes, 1)
+
+/* Stabs debug sections. */
+#define STABS_DEBUG_SECTIONS                 \
+  .stab 0 : { *(.stab) }                     \
+  .stabstr 0 : { *(.stabstr) }               \
+  .stab.excl 0 : { *(.stab.excl) }           \
+  .stab.exclstr 0 : { *(.stab.exclstr) }     \
+  .stab.index 0 : { *(.stab.index) }         \
+  .stab.indexstr 0 : { *(.stab.indexstr) }
+
+/*
+ * ELF sections.
+ *
+ * LLVM ld also wants .symtab, .strtab, and .shstrtab placed. These look to
+ * be benign to GNU ld, so we can have them here unconditionally.
+ */
+#define ELF_DETAILS_SECTIONS                 \
+  .comment 0 : { *(.comment) *(.comment.*) } \
+  .symtab 0 : { *(.symtab) }                 \
+  .strtab 0 : { *(.strtab) }                 \
+  .shstrtab 0 : { *(.shstrtab) }
+
+#ifdef EFI
+#define DISCARD_EFI_SECTIONS \
+       *(.comment)   \
+       *(.comment.*) \
+       *(.note.*)
+#else
+#define DISCARD_EFI_SECTIONS
+#endif
+
+/* Sections to be discarded. */
+#define DISCARD_SECTIONS     \
+  /DISCARD/ : {              \
+       *(.text.exit)         \
+       *(.exit.text)         \
+       *(.exit.data)         \
+       *(.exitcall.exit)     \
+       *(.discard)           \
+       *(.discard.*)         \
+       *(.eh_frame)          \
+       *(.dtors)             \
+       *(.dtors.*)           \
+       *(.fini_array)        \
+       *(.fini_array.*)      \
+       DISCARD_EFI_SECTIONS  \
+  }
+
+/* List of constructs other than *_SECTIONS in alphabetical order. */
+
+#ifdef CONFIG_HYPFS
+#define HYPFS_PARAM              \
+       . = ALIGN(POINTER_ALIGN); \
+       __paramhypfs_start = .;   \
+       *(.data.paramhypfs)       \
+       __paramhypfs_end = .;
+#else
+#define HYPFS_PARAM
+#endif
+
+#ifdef CONFIG_DEBUG_LOCK_PROFILE
+#define LOCK_PROFILE_DATA        \
+       . = ALIGN(POINTER_ALIGN); \
+       __lock_profile_start = .; \
+       *(.lockprofile.data)      \
+       __lock_profile_end = .;
+#else
+#define LOCK_PROFILE_DATA
+#endif
+
+#ifdef CONFIG_HAS_VPCI
+#define VPCI_ARRAY               \
+       . = ALIGN(POINTER_ALIGN); \
+       __start_vpci_array = .;   \
+       *(SORT(.data.vpci.*))     \
+       __end_vpci_array = .;
+#else
+#define VPCI_ARRAY
+#endif
+
 #endif /* __XEN_LDS_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 09:29:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 09:29:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298663.508855 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfV7-000690-7Y; Tue, 05 Apr 2022 09:29:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298663.508855; Tue, 05 Apr 2022 09:29:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfV7-00068t-4R; Tue, 05 Apr 2022 09:29:25 +0000
Received: by outflank-mailman (input) for mailman id 298663;
 Tue, 05 Apr 2022 09:29:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbfV6-00068n-5v
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 09:29:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e08306cb-b4c2-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 11:29:22 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-nPthoNw4PNeSRxSyrWINcw-1; Tue, 05 Apr 2022 11:29:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4942.eurprd04.prod.outlook.com (2603:10a6:803:59::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 09:29:17 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 09:29:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e08306cb-b4c2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649150962;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IM0WjWhCvNW9c+LjtMIykjleIdq/y4xbeWXDJ6rNR5c=;
	b=c6rkTOo5/aFltPi8hp606OEgnsC+5BFyIkAMmvZk87pkkWCeWRwQtPv7/bqNS617GvUiKj
	FQQvbFHKKLgzRPemXQ6PoH6rp50qb9HOPQm089bx9YEBWQa+NHyP6l1DEJSl1DAEjkf7vF
	bV1pBLCDxyE2wvc6FwjsulqDb3oGD5I=
X-MC-Unique: nPthoNw4PNeSRxSyrWINcw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cUpUmcImDFsXBAkMa3xW8wvi/pLPebHzMyL83m/clx01sN1i0HM1XQZJJVmldckYdEXdy6V58hyHmsogQXjxcl/cSCDEMJ6m2ZZy6Ba3zr6xPbpAehBlypO5Z4qLdVA5ZEbzQW4DxAj+FBf8RMEVu3YUPmPQnc+0VZPVZUtm1v6RWrJkelP4Tje0kOj1KiFYa30CJC+DbbUPR/dY6Xvpdc/xTGWa37R+WVqxnZ5V28HZwoVTX+3vMEBnNsv22xK6z3kjT+evO3gr44ZDmCUC3p0A/RyJiKVRPEaHe7UC5D56Wl4pUcmYRoQUP5sbD0hH8eG4FDTdALP234W72APDeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IM0WjWhCvNW9c+LjtMIykjleIdq/y4xbeWXDJ6rNR5c=;
 b=Mh1XT48bRERjMz0Xk2CY0XvvuZnkru8cOHV4cPS4KUV+qhuSOHLpR9Acr6aByvbOA2cUsOhWsrxVCG4cKKNKhohVADvhSW2ysk/YperNb2YxTeLvGF7UyvI+Oq5RxBrNSIB151Yls1Nt/F7F2n9GJaDTJCeW82qmZGUEMc2XqR7o2+oltZAg/lVYIA5CoabVm1Zd3tGF48ay3xIyL+H96apbIVdYJrJ0f+GF/S7kh0qdhOWMXnsB9Q1sLWPkjOQHiEziOR10s6tJbwwqSn2wgG20vMoTUXo45fQTaHp9DVBqUkLLZojkZJEiXTahgJI2I1/mkBMxyUR846BzK3e7Vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8cdd0a02-5a8d-1c4c-9012-c4f1bb08201c@suse.com>
Date: Tue, 5 Apr 2022 11:29:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220405091616.200270-1-michal.orzel@arm.com>
 <20220405091616.200270-3-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220405091616.200270-3-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0010.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 10cb1cd4-a35b-41ea-8863-08da16e6c17b
X-MS-TrafficTypeDiagnostic: VI1PR04MB4942:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4942CA84E3F59C469507D2F4B3E49@VI1PR04MB4942.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VM1gaSpMvHxxErYgyb5EBJEfuI+HEeQMd1GFM5LcLRWgNQartED+axD0sD/0JD0sM4FW6NH3AgGn08KbT8ACo0TDoXd13KILgYU1GykFRHP7yHrEbKQiX0qLDa6u+WLBKcbuKlvb0+SWryymjbaIhH8cbA4YknXe7SQi3Uzt0h9ZK23jVo/l2syTG5UAgOM3MyiHJoPjRf3Vhz4JUmIra6d5knUOAav25pwv0f3Mmj50YCD3QpeMt+K3Q64PIFi5LOK2Na7XI0YQufFwzLSjNnNpTnud5QiT4oGhchW5jtBZ+7jU/crVsHecq6iUcw4Uz8oFCgjYXOvnccFG8ob5BnrBBFnGnaa9hBRrUQ7AAdkhJkmkuGQC4oik7qF9LfIy43YXZhIRh4XPII7x5BuPpxXNAvIQY5BSKFuZM2ZeVemrVqjQXgS/lyDA2I0GCPg4fi0E+IcFxuQiv1BWUDHxhOGy23u7zAJ6i4/ABsOO0sOIozNLCrgUBmTECJOMSRIAEr2RmQ2jJUfGPl+XZdW1KyPvKDydNcji33yoQ+MXKMeX+GdhWvBZ7OyFgG15CJpmX1g9jXF8vL0AhnOjeN46I+mTnojqmSLtXmuvpY+vrSEHQllDVdlCF97lTXAD6POGPyxPUO1ZUQzOL/gnF8RiUJirAlhDfKEIGFohPMEZhOZLLNEM1kzqWBI/D5vOxBuRFSgJGzulrCp88U9QkG3WW2g9cziPfkFTFG/U1EMIc5Q=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(8936002)(54906003)(66556008)(66476007)(316002)(6486002)(8676002)(186003)(7416002)(26005)(66946007)(86362001)(5660300002)(31696002)(6666004)(36756003)(31686004)(4326008)(508600001)(6506007)(6512007)(2906002)(2616005)(38100700002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dTNoNnpleXUycmI4Mms2N0djKy9UYWdFems5RG05bHRHMlJHTDBkSWkydkwx?=
 =?utf-8?B?REVEZUhmcmlWdlkveklZMWs4ak9QQzcrZEo1SVF3TEpsSWV1UGZxYlB4ME9t?=
 =?utf-8?B?cmdCeXhaUXFVZDFMejg4ejBTYm9RWTJGRTJ1Sk5BNlVMRzBsV3ZEOEhXTnMr?=
 =?utf-8?B?YkVrcDdnWitJQ1htNHM5Z2w4eUhIbXRuVXlqNFdvR1lGdllmRzVxOTlBbUgv?=
 =?utf-8?B?Umh1UVhLbHU1VzlwK1ZqQjNKMXM0M3hXdjMySTdPSEdoNC9peTVqTXE1NXFK?=
 =?utf-8?B?enFwalYxQW5DblkxQkNDNHI4dWlpa1gyOHgwdmo0WU9Bd1JoZ0VHaHFaQ0pv?=
 =?utf-8?B?YW1TZjg1SUJSNnpNU3JSNERKdStjYWh4d1ExdS8wN1NBNVh4U0pCQ3hBSWxm?=
 =?utf-8?B?WXdlekZGdThLck9FVlFEd081Q1pkL1NkRzlFUi9rYldqS0puWUxIbzNQWUU4?=
 =?utf-8?B?ckRkNUQxK1o3YURtOGowZURkY01obXp2TEZMa1VaVTUvRGtHK0krcE1Uemo5?=
 =?utf-8?B?Y25Uc01FUkwxV1cwWXhEcDNiRmhpTndaUEx0V01NL0xNMWgwdTVOM0ZBT2Rj?=
 =?utf-8?B?Zzd0MDkwUHl0cTh1WjgrM1pWVm1FNnVFMVdrRjF1dkRqMnMrWEs0NEhkTjBE?=
 =?utf-8?B?YURzUmlXOUdCb3pPcllJR2dvNERldXAvWVY2NjlIVkgvSklSU0FkcFpPeDI4?=
 =?utf-8?B?L2FhaG1SYVlCdEZJNjdjOWxuY29YZ0U4S1BxZXRVNmc1eERjVFdZT2lDTDIv?=
 =?utf-8?B?QXJwek1ERWtHTjRCbHBneFF6KzhNMVFVYXVsSDhZbUt4N2tOMVBKWW53b1Uy?=
 =?utf-8?B?NFhOUmFVczhVMm1iaFNGWVd0dTdPSGJzeElod3VhbjhNM0I4ejNoeFpjcnQ0?=
 =?utf-8?B?ZU1OWGhTbHNycjloQ1hISmdGbG1GQWJSN3V5VzE2MlZBamVYaFhTQU8zVjY3?=
 =?utf-8?B?N3BSNXcxcVZDSVp0aURzZnorWmdsR1RUd0d0N3ROanpYbnk3RnZaUnlPNUZW?=
 =?utf-8?B?d1hYekhvNTB6VGd5R09lemF3RjZZbUFiT3FRU2ZYSS9ieTc3NGhaaENRb2Vk?=
 =?utf-8?B?UTFDeUk5eWl0QTUySDJIWmhLNk4rNHJ3NUVISkdMdlNac2p5dlJuaEd6TlRS?=
 =?utf-8?B?akZTcHduYlJHQ3NnU0ZVbGRtTVIwUlVsWDFwc3p1Y05QNWhPNGsxL3lJUjRi?=
 =?utf-8?B?eDBYTE9ZdXY5a0hucmVZVGdNYmc0VHE0enRSczBGRmVEMkttcXdYdkVJV1Fh?=
 =?utf-8?B?U0ZBSnBRTml1cm1iZ3hrc2d5LzRmMmF5TFFXREZ0N2kwb2lOMWlIeFQvZGty?=
 =?utf-8?B?eVdqS1NpLy9jY2xkYTQ1UG1oWGNFeVJGZ3phMStrOHV5cFh6aUg3S1NYTENV?=
 =?utf-8?B?aHFudUVvQ1V2T3padW11VVN6bjVYaFZNSHZHc1FzcGE0bUdPSjROYWV5alpz?=
 =?utf-8?B?NEU5Y1RpTTF4UmtGZ0NWLzdRSjlOVDg1NFJCdTk3NXN3RUNvcXRoWVJ5TVd0?=
 =?utf-8?B?Ynk3eHBFS0lFbzcyVHd6L2RSbnlRaG4yRVZ3NW9VL3YveTNTQjhUcTRZbWRu?=
 =?utf-8?B?bit0NkNQeGd4b2trV2duMFN0SGRIQjFTeHptc002c2prZHJpZFBVbldBMkQ3?=
 =?utf-8?B?SmNpQitzRWNuNWxDSU41NjFLR0F1OHgwYW4vVUNMcGZOdHc1aGVpNW9NWnlR?=
 =?utf-8?B?VnpYWmUvTUJ0MjdGSjZWbEZxbEtLZVA4azhMeUNPc2QyWlJMcEZINnVxdnR2?=
 =?utf-8?B?Mms1cHgvRzVORlFGdjFTcVlkQ2E1SGxCT2p1QlMxa0Y3UDFyQTYzOUJuQUdO?=
 =?utf-8?B?S3c4Wi9qVUN3RHRGTDY5OWRQdXlYVVRyMkhBTmFrZzg3Zy8zc0swVGZsRU5T?=
 =?utf-8?B?NlNSUlVzck5GQ1c3ZCtBbFd5WFdiUXNRZ2VQbmxFZWRsY1U2enVzWEpNb25k?=
 =?utf-8?B?d1ZkNkc3ZjRWQ29ISlhXYlE3eUxSYTBaSVYxU3NvUTA2Q1diR2FiYUk0MDFP?=
 =?utf-8?B?TWNSU0o3YzJKeEtIM3RHMjdSWUVIMXZkalo4a2lvUVFoWUVGaE5FTnZOSkhP?=
 =?utf-8?B?YW5IMXArTlhGTWphUHFPWGpVL2l2YWpoOTJneDYwRnhZNE43Y0MyTnhhYmZq?=
 =?utf-8?B?RW5EQTloNlBYc05FM0pxQm15Y3lHaENQZStuMnZpYmVYTlZuUG9QNmV5K2R5?=
 =?utf-8?B?aVNTOG1DKzhSWEJiYmhCdytvKy9pYS8rRXFPYzdYVmRPL1YzK3Q3L0cwRFEr?=
 =?utf-8?B?emFjRkY0dnU1cnR5RURmN2ZNRTREQzJaVnBxRlJQNHNER0sybnFpR0NPNDQv?=
 =?utf-8?B?SEs5Y2tXdWluTzlwUmdRQmNMdnVxeHM2K1dMSFNoOEFtVE11STl3dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10cb1cd4-a35b-41ea-8863-08da16e6c17b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 09:29:17.2921
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ClztkR5fNPzPnS9QBA+VBhaGBzAJh1tXChVXarzu5SkVbIyKIee7185IO4HNrmwZtUjKdyj1gnJvwzbebqrKlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4942

On 05.04.2022 11:16, Michal Orzel wrote:
> Populate header file xen.lds.h with the first portion of macros storing
> constructs common to x86 and arm linker scripts. Replace the original
> constructs with these helpers.
> 
> No functional improvements to x86 linker script.
> 
> Making use of common macros improves arm linker script with:
> - explicit list of debug sections that otherwise are seen as "orphans"
>   by the linker. This will allow to fix issues after enabling linker
>   option --orphan-handling one day,
> - extended list of discarded section to include: .discard, destructors
>   related sections, .fini_array which can reference .text.exit,
> - sections not related to debugging that are placed by ld.lld. Even
>   though we do not support linking with LLD on Arm, these sections do
>   not cause problem to GNU ld.
> 
> Please note that this patch does not aim to perform the full sync up
> between the linker scripts. It creates a base for further work.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 09:36:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 09:36:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298667.508867 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfbV-0007Ze-VB; Tue, 05 Apr 2022 09:36:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298667.508867; Tue, 05 Apr 2022 09:36:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfbV-0007ZX-Rs; Tue, 05 Apr 2022 09:36:01 +0000
Received: by outflank-mailman (input) for mailman id 298667;
 Tue, 05 Apr 2022 09:36:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbfbV-0007ZR-2u
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 09:36:01 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cbb2bb46-b4c3-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 11:35:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cbb2bb46-b4c3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649151358;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=QYeXGIMqwk9MI+YJ690RQcK58EgjBMpoOw/bL5EjbuY=;
  b=QDf/6G1e/vVXApcTDwm13aCgV5aZyyLGfSJdNzNv/J2zYIWKFfsX3QRM
   wxEo1yOVJIaEHUrgdYamnpXRB41ryCzZfSSxo552PNdVwwxlo1OCzpdhV
   c13OFNgpTcSF4zvVolLWZznBroJgqpGhiBcfq78o3zA220lRw4y3/KyoW
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67452992
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JVXVNKPMVBpuzVHvrR2al8FynXyQoLVcMsEvi/4bfWQNrUomgmQHx
 jMeUDrUOamPYmGkKt1wO4i19xlUsMfUzd43Swto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5
 YwRjLipTF0VDJbdn9oCT0EBCSxwFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmhs25ofTKy2i
 8wxZAZoU1eHcyZ0YEZGB68/hb/whXzGSmgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSAzRKV/3TqgfXA9Qv5RYYTGbuQ5vNsxlqJyQQ7ChcbSF+6qvmRkVOlVpRUL
 El80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BKGUziZmMTCihxIyFqg2tJXBMN2IMTHpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzl+PNl9J+D+Vc2JMi2aAzVHApchNI4+CJrVql
 ChVwpPOhAzi4HzkqcBsfAnvNOzyjxpmGGeF6bKKI3XH327wk5JEVdoNiAyS3G8zbq45lcbBO
 Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+SYW9DKiIM4YVPsQZmOq7EMdGPxP4M4fFyhZErE3CE
 c3DLZbE4YgyV8yLMwZat89CiOR2l0jSNEvYRIzhzgTP7FZtTCX9dFvxC3PXNrpRxPrd+G39q
 o8DX+PXm0Q3eLCvOUH/rN9MRW3m2FBmXPgaXeQMLbXdSuencUl8Y8LsLUQJINU/xfkKz7uWp
 RlQmCZwkTLCuJEOEi3TAlhLY7LzR5dv63U9OC0nJ1Gz3HY/J42o6c8im1EfJ9HLKMQLISZIc
 sQ4
IronPort-HdrOrdr: A9a23:W/ZaZKDLZNbv6iTlHel155DYdb4zR+YMi2TDtnoBLSC9F/byqy
 nApoV46TbZsgs4ZV0Ftfe8fIG4eFPwnKQa3aA8B4qLYSXDlEyUaKVP1qHC6xrcIWnb2tRm/Y
 lNU4UWMrHN5DRB7foS7TPULz9C+ri6Gd6T79s2pk0FJT2CDZsO0+4TMHf/LqQZfngkOaYE
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="67452992"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lhr9EUe2eYsw5nVmmcKyGTnBrC++HBZaBzj6p8LrpfHqUnwWbOf9nNgi3pOXEbEUacs9TNwlfHm9o2pgBVzoRFx6YUoRgqZA6EyJKFdSi5Kq0E6iITBLq/XB0w8FLazNldVBlGmvw34vT62Vq6me0j05b0zHT0L9MRVHva7WltbjJiOpRmSjuPL1PKT3Oz0wVOtFDZfqE6pot9H1y3itFPjCa6f4ZRNMqzndDuQ765wUngaUb1dV2OU22GZc/8eIVIFzoRzdac+cm6SVw773NNr8GZaSgcja3h6I3HBscM6RSgnimAXrCjZVjdRrU5xz9b4NhGzxMpnpLOJV/rnOvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8HX/TJLCYLW9dTB+WjH29x1zFlAqewdfsUyrqLUdUHc=;
 b=hQ4yD4xcfKFZf2GkORB7WU4y2IY7obVlwixXYgbxpT7/asjnGSJSsUsGMyOkjrn8GoNBGHcmnQGj88EOnxkiFfPclWDwFV4rglAwwWLRuNF7WADXqiDFngyx4JeNHSWmdIudaLBd8AQMX2RfaiBJKzJ7KYd2fR8jt4pTzhwOLJWk0ZDM5g2pqz5Cc3UacSS4oWAdt3XBJHxwORRsu4TJd8I1eOpOBTJiVDMDNeawK7Aj0UQndoPF51M79TSiN0EWa76qrdNyUWcTquU7AHu37Gg20UhMkpuTX8H1npX5Ypqz+kEqACwuZRd576KOc8ujcJAhBw4OQof8L1cX4YVOiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8HX/TJLCYLW9dTB+WjH29x1zFlAqewdfsUyrqLUdUHc=;
 b=CfcKayFfSW4tLz8IfxAdoiM9syrCH/YDApG3ti/dUYAvBU9u9Vb0eoXG2/js5nwaaJz1r9+/PRGAA3n7wDDvKf1JKnkkbO1KC7M5zcNZhKxoZk9xb8d1rCUqGxAFUduqVthtPMUx4eca6Hz0P/rfaEgy1wqh8pAp+G6VVbXsJqo=
Date: Tue, 5 Apr 2022 11:35:42 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 2/8] x86/boot: obtain video info from boot loader
Message-ID: <YkwNbi3lTNJbWVNC@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <6fc25224-7985-73a6-8877-bc209f64bf8c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6fc25224-7985-73a6-8877-bc209f64bf8c@suse.com>
X-ClientProxiedBy: LO2P265CA0328.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a4::28) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 640fe846-6487-4d93-85e7-08da16e7a96b
X-MS-TrafficTypeDiagnostic: BN7PR03MB3651:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB365107B2504D94ECD47F9E448FE49@BN7PR03MB3651.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: If3pDtPp9ePOeJ47iokriyTC9zZDaqmpUmCWYZ4hYa0PCI3D1khsn8ffxarKbE1k+KJMqjcW9qdhhCR7XNtUUUiMY5L5XVlUk3LAW4IhRP+J1Jy4GgZKgi8HYEn6Nv5SkluqnxKy/T08SGdu1EGkKa0yLmWqkKrSmmr014PqQnQoQdKHCrWVs4+PDJxueMmHIReSvyapObwW4Ffqe2/p9qKXS3raQnh5G9ph5mwbSXhx8XuVM8lJs99CCUwexc+4ifjseIg7/kv+eMsmJq9xODv9TtadOX78cWIKz67UY1+aWjANPMUlkvaFQUBBqbun9SbinlAQivwRYknQ6ca0PRM5gywg3vsWfunBLggIMFnt7E+jjus+Ds854eBqV8c9CSsVzaiXth2vGgNi0ue5tUhhtFJSup/JBlCzbmPFWK+aCa9NDl08cKOjb5al6YXzeJ7U8jP5m7/F2FFjoK97noD4XlUDbMm3rV19Lxckh1DwZyrj78XX/DFEEWFeTYA0V8+8SfuwcYMR3i0RLFnSqWIBIqPOesYOnCFLCcEoJKKcj+25PXZFkJa8jGXN7WVGd3ht+vwYKdPt6+leGD3+Z2r/WGkPxc4ki47Cro1qFRIKoLt2ASmFFOCe1JETkh1NrkZM/+lPDQw2Wjm5WPapaw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(4326008)(66556008)(8676002)(66476007)(2906002)(66946007)(38100700002)(9686003)(6506007)(6512007)(6666004)(82960400001)(5660300002)(8936002)(316002)(186003)(26005)(6916009)(33716001)(54906003)(85182001)(86362001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3dPeWJtUTFjcmpiMzVtNC84L0w4amFWWUlkRGRqQ3VhWm93TkdSaS96UVl6?=
 =?utf-8?B?UDdESWgyNlVVNkNlMlRFNlR1NnpaclFIZmdGd1dHRGtOK3VvSktCRXVyYTZT?=
 =?utf-8?B?SWVzN1Y3UklJbjlxdk9kSFRVR2Zmc0tWRjN5eVhNSlVHOVBJY3MrNmpvTzli?=
 =?utf-8?B?QVhyVWZxcWU4QW1NN2tpamdhNDlIYWI4aTBLSlQrbWtseUQwUFI0ekR1NktX?=
 =?utf-8?B?d0RIZEhGbkZYbzRnSXlUN1lJMlhiVy9kdWNxemFYMXgrb05ZYkZ6THQveW40?=
 =?utf-8?B?enJ3VlZ2YkxZK1c5RHg1dEM5WHpMckRpZWpuRXhZclU4b2t2aFlsbXcxc0ZK?=
 =?utf-8?B?R1dsNnRuTW9ycGVXVWdFZFRRWUQxVmxpVEVJWGN4TFVsQ0FVcllaWE8zUkZa?=
 =?utf-8?B?Y3FlWFRsaWZHc0NwMTJaSDlublJOdnhUN0JDdzVhUW5rUENYb2p1MzhiYXJa?=
 =?utf-8?B?amJHR0d2SURxZnZ3Uk9oZ2VhTVprcnk2UU5OSXNpVzU1NHY2RjlFU2lGZURp?=
 =?utf-8?B?L2QrMGprVnREUGhXQlpGL2hxdTNtamRaQkQ2disxTTA3VkRCRnhOM3ZTbHZl?=
 =?utf-8?B?RkpqbFRxbnBSQWJvL2VCci9mdnJ3bWZ4MHRyRVc3bEM5RnhNTEI0eWZIYmF4?=
 =?utf-8?B?Q2RSMjRhZ2pJclBaUG95dE5TMklZaDRoSno2YnkwZ0hUQ1RyRGh2MzliZ3M3?=
 =?utf-8?B?eERTb1AxOVJLcFIrdzlBSzZJVmhiR3haMmNwVW9lTmFuWEZrZjc0VlI3MGk3?=
 =?utf-8?B?QVFVdUtWcEhmYWtoUnRubEd2Qy85UitwSEdrUUlJMUplMXVBT3p5VGkxU2NM?=
 =?utf-8?B?bGt5QXRZN0tsOTFhc0N1dnFRWkFSUUo1a29qRGVhZXpRVTRxeElldkYvVFdP?=
 =?utf-8?B?U05OaWQ5d2YrK3BxcFduSlR0ZGRCWGpJMk9HM2lVdGpQckVHWjdaaGc0ZmI2?=
 =?utf-8?B?aTVMaXNwUVJNejNJWW8rNUxuem5FekgzcUJPZzhBRGdVMG1QdW9rRWR0VzN6?=
 =?utf-8?B?QzhzV09waE1GTmkrM1NvVnc3R0RrMEY5VnFGUkE4WFg0SzNXMjc2eGoyUk1u?=
 =?utf-8?B?RHNHUVlnUUZaUUY4bzYvWk8yUGZETXphSzQxY1RyVFduUnZqMjQ2YVJuR3Vs?=
 =?utf-8?B?ck8yV3NhZ0V2dVpOdlBpbmJwZzlXa1dEbzNrUXBuemIvQXl6Wk1hdG83M1hT?=
 =?utf-8?B?cWZFOXNGRzRDREpmUEcrV0NvR2FRWVgzd01sOXE4TzVSN3lwOFFDb2N0U3BG?=
 =?utf-8?B?ZXpLWWVRbnl5VmFUZFR0dUhuYVpNOThQWkdXcFRxQng1NWppL1lJZmh5Y2lt?=
 =?utf-8?B?eCszcUVDa1ZpMWtLYzgrSHRabXROcTl6S3VEZ3lncWREbXl6RGZPRHB4cE04?=
 =?utf-8?B?c2Q4ZmZ6dG4ya292N214djhwQk80VW5jL2VnZnZkOGsyYitWSDZxdHppZ1hQ?=
 =?utf-8?B?ZWJidHMreFhCbC9wU0ZZMk5RN1o4UWEvWlpKQTZ4TWJlL05rN1EvUXpJUWZ2?=
 =?utf-8?B?N01GL3ZaWmlPSnFERmdXbFQwSnhZTnFBVi9VSlJObFlxMFNzeHdGOXh6b3Iy?=
 =?utf-8?B?dmJrZngzK0JUTnk5dlMxVUlGZTV6Rk03SVNjTWtXYnlEU3NwZ21zV21tMGlz?=
 =?utf-8?B?UllWNFlyT1VYY1hlU2RQd3NzVENWckgzV1UwSm0rY3ZNa2NkQmZnSlU0OUN0?=
 =?utf-8?B?c2lkT0NxZ3hCR1AvclpLTFJiRjVOMWNyTlpnRm9HMnl1Rm5YSW5aeld6U1Vn?=
 =?utf-8?B?RnRpOExkMFVGVVdPR0Z5VDhtTUhsd21VNUJHUTA0Qkg4Wm92bklFelQ0djh6?=
 =?utf-8?B?NTdzV0FKa1l3TURMR1RaYVBOYkVkM0FkWElmUE40cW4vdkxJQWZ6cWUrdG1J?=
 =?utf-8?B?RFJIdlUvK21qVENoeTlDaWdIeFg1aWZINy93OU5RVG1RNnZJQlk0dVd4OWlq?=
 =?utf-8?B?NG5oaHBqai9JaS9TWUJzN3JVK2h1amczRVdkY01nRVgvVTlZb2JrMi9RbjRX?=
 =?utf-8?B?bUFCNkFuSUNFZUpORGlUNzhzYWd0ZS95S1doNjF4ZzR4OGhJc29lZ2I0bCsv?=
 =?utf-8?B?bGp4Ukh5aUZVSkduay91R2IwQ2p1VlBKaU0vbjNUdHJGa3dSQ3c0aWRoaGRY?=
 =?utf-8?B?QnE2cDg2QmVpeVg4b0pBbWNlU1JpYVQzQnV5U1BqYVpYa0ZRMDlYOFJ2UXI0?=
 =?utf-8?B?cDJwU2Z2c0RSRXFmM1AzV0NGWUxudmE1eHFnVmVJSkd0TTRpZXVsSG13b2ph?=
 =?utf-8?B?ZXd0Vk5ua3NFTnJCbDdHUkZvaDZCWEl3QWZIczV2T1A4NnJTTTJDaVo1RGh5?=
 =?utf-8?B?YnFEYTZPZGdlT0JqdWlYNTdEK1hsOVJkd2dEUURINEw1Yy9MNnU2WEtyOEpu?=
 =?utf-8?Q?3ducvO8ZAq/KWiW4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 640fe846-6487-4d93-85e7-08da16e7a96b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 09:35:46.3405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0mFwD4yAFV5euqZ9ALxhvHCgTkv0GD3A5igHG6ATzyyAZ3OSEkjWwiE5SEt+Loy36nimqbLnIK/ueHy6xoOiOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3651
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:45:02AM +0200, Jan Beulich wrote:
> With MB2 the boot loader may provide this information, allowing us to
> obtain it without needing to enter real mode (assuming we don't need to
> set a new mode from "vga=", but can instead inherit the one the
> bootloader may have established).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v4: Re-base.
> v3: Re-base.
> v2: New.
> 
> --- a/xen/arch/x86/boot/defs.h
> +++ b/xen/arch/x86/boot/defs.h
> @@ -53,6 +53,7 @@ typedef unsigned int u32;
>  typedef unsigned long long u64;
>  typedef unsigned int size_t;
>  typedef u8 uint8_t;
> +typedef u16 uint16_t;
>  typedef u32 uint32_t;
>  typedef u64 uint64_t;
>  
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -562,12 +562,18 @@ trampoline_setup:
>          mov     %esi, sym_esi(xen_phys_start)
>          mov     %esi, sym_esi(trampoline_xen_phys_start)
>  
> -        mov     sym_esi(trampoline_phys), %ecx
> -
>          /* Get bottom-most low-memory stack address. */
> +        mov     sym_esi(trampoline_phys), %ecx
>          add     $TRAMPOLINE_SPACE,%ecx

Just for my understanding, since you are already touching the
instruction, why not switch it to a lea like you do below?

Is that because you would also like to take the opportunity to fold
the add into the lea and that would be too much of a change?

>  
> +#ifdef CONFIG_VIDEO
> +        lea     sym_esi(boot_vid_info), %edx
> +#else
> +        xor     %edx, %edx
> +#endif
> +
>          /* Save Multiboot / PVH info struct (after relocation) for later use. */
> +        push    %edx                /* Boot video info to be filled from MB2. */
>          push    %ecx                /* Bottom-most low-memory stack address. */
>          push    %ebx                /* Multiboot / PVH information address. */
>          push    %eax                /* Magic number. */
> --- a/xen/arch/x86/boot/reloc.c
> +++ b/xen/arch/x86/boot/reloc.c
> @@ -14,9 +14,10 @@
>  
>  /*
>   * This entry point is entered from xen/arch/x86/boot/head.S with:
> - *   - 0x4(%esp) = MAGIC,
> - *   - 0x8(%esp) = INFORMATION_ADDRESS,
> - *   - 0xc(%esp) = TOPMOST_LOW_MEMORY_STACK_ADDRESS.
> + *   - 0x04(%esp) = MAGIC,
> + *   - 0x08(%esp) = INFORMATION_ADDRESS,
> + *   - 0x0c(%esp) = TOPMOST_LOW_MEMORY_STACK_ADDRESS.
> + *   - 0x10(%esp) = BOOT_VIDEO_INFO_ADDRESS.
>   */
>  asm (
>      "    .text                         \n"
> @@ -32,6 +33,39 @@ asm (
>  #include "../../../include/xen/kconfig.h"
>  #include <public/arch-x86/hvm/start_info.h>
>  
> +#ifdef CONFIG_VIDEO
> +# include "video.h"
> +
> +/* VESA control information */
> +struct __packed vesa_ctrl_info {
> +    uint8_t signature[4];
> +    uint16_t version;
> +    uint32_t oem_name;
> +    uint32_t capabilities;
> +    uint32_t mode_list;
> +    uint16_t mem_size;
> +    /* We don't use any further fields. */
> +};
> +
> +/* VESA 2.0 mode information */
> +struct vesa_mode_info {

Should we add __packed here just in case further added fields are no
longer naturally aligned? (AFAICT all field right now are aligned to
it's size so there's no need for it).

> +    uint16_t attrib;
> +    uint8_t window[14]; /* We don't use the individual fields. */
> +    uint16_t bytes_per_line;
> +    uint16_t width;
> +    uint16_t height;
> +    uint8_t cell_width;
> +    uint8_t cell_height;
> +    uint8_t nr_planes;
> +    uint8_t depth;
> +    uint8_t memory[5]; /* We don't use the individual fields. */
> +    struct boot_video_colors colors;
> +    uint8_t direct_color;
> +    uint32_t base;
> +    /* We don't use any further fields. */
> +};

Would it make sense to put those struct definitions in boot/video.h
like you do for boot_video_info?

I also wonder whether you could then hide the #ifdef CONFIG_VIDEO
check inside of the header itself.

> +#endif /* CONFIG_VIDEO */
> +
>  #define get_mb2_data(tag, type, member)   (((multiboot2_tag_##type##_t *)(tag))->member)
>  #define get_mb2_string(tag, type, member) ((u32)get_mb2_data(tag, type, member))
>  
> @@ -146,7 +180,7 @@ static multiboot_info_t *mbi_reloc(u32 m
>      return mbi_out;
>  }
>  
> -static multiboot_info_t *mbi2_reloc(u32 mbi_in)
> +static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out)
>  {
>      const multiboot2_fixed_t *mbi_fix = _p(mbi_in);
>      const multiboot2_memory_map_t *mmap_src;
> @@ -154,6 +188,9 @@ static multiboot_info_t *mbi2_reloc(u32
>      module_t *mbi_out_mods = NULL;
>      memory_map_t *mmap_dst;
>      multiboot_info_t *mbi_out;
> +#ifdef CONFIG_VIDEO
> +    struct boot_video_info *video = NULL;
> +#endif
>      u32 ptr;
>      unsigned int i, mod_idx = 0;
>  
> @@ -254,17 +291,64 @@ static multiboot_info_t *mbi2_reloc(u32
>              ++mod_idx;
>              break;
>  
> +#ifdef CONFIG_VIDEO
> +        case MULTIBOOT2_TAG_TYPE_VBE:
> +            if ( video_out )
> +            {
> +                const struct vesa_ctrl_info *ci;
> +                const struct vesa_mode_info *mi;
> +
> +                video = _p(video_out);
> +                ci = (void *)get_mb2_data(tag, vbe, vbe_control_info);
> +                mi = (void *)get_mb2_data(tag, vbe, vbe_mode_info);
> +
> +                if ( ci->version >= 0x0200 && (mi->attrib & 0x9b) == 0x9b )
> +                {
> +                    video->capabilities = ci->capabilities;
> +                    video->lfb_linelength = mi->bytes_per_line;
> +                    video->lfb_width = mi->width;
> +                    video->lfb_height = mi->height;
> +                    video->lfb_depth = mi->depth;
> +                    video->lfb_base = mi->base;
> +                    video->lfb_size = ci->mem_size;
> +                    video->colors = mi->colors;
> +                    video->vesa_attrib = mi->attrib;
> +                }
> +
> +                video->vesapm.seg = get_mb2_data(tag, vbe, vbe_interface_seg);
> +                video->vesapm.off = get_mb2_data(tag, vbe, vbe_interface_off);
> +            }
> +            break;
> +
> +        case MULTIBOOT2_TAG_TYPE_FRAMEBUFFER:
> +            if ( (get_mb2_data(tag, framebuffer, framebuffer_type) !=
> +                  MULTIBOOT2_FRAMEBUFFER_TYPE_RGB) )
> +            {
> +                video_out = 0;
> +                video = NULL;
> +            }

I'm confused, don't you need to store the information in the
framebuffer tag for use after relocation?

> +            break;
> +#endif /* CONFIG_VIDEO */
> +
>          case MULTIBOOT2_TAG_TYPE_END:
> -            return mbi_out;
> +            goto end; /* Cannot "break;" here. */
>  
>          default:
>              break;
>          }
>  
> + end:
> +
> +#ifdef CONFIG_VIDEO
> +    if ( video )
> +        video->orig_video_isVGA = 0x23;

I see we use this elsewhere, what's the meaning of this (magic) 0x23?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 09:50:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 09:50:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298677.508898 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfpM-0001ek-Bs; Tue, 05 Apr 2022 09:50:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298677.508898; Tue, 05 Apr 2022 09:50:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbfpM-0001ed-7p; Tue, 05 Apr 2022 09:50:20 +0000
Received: by outflank-mailman (input) for mailman id 298677;
 Tue, 05 Apr 2022 09:50:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbfpK-0001eX-Sf
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 09:50:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c8515061-b4c5-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 11:50:10 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-vjBCIHNKM5K53e3DRSubcQ-1; Tue, 05 Apr 2022 11:50:12 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM7PR04MB6950.eurprd04.prod.outlook.com (2603:10a6:20b:105::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 09:50:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 09:50:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8515061-b4c5-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649152215;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/qp2ByoPAY/8DAZJpeNEOCm7civFrFP5567MBR9L+nA=;
	b=gzQBOjUMCb0mqRH3PxiEiJCyXvDHLsbRZ058fPrQ4OMNYfGhMLGXoXtraqS5FQumrpfZ6O
	l86oOKSi/DWb4NXYlwcxGHp5miIGyT6F3iY5se65nzfZJV2oiPkhpj4Xvq/BWUjexPMoyO
	jUoXJfmf/OKbBF1w3JtK3OohOhnjW18=
X-MC-Unique: vjBCIHNKM5K53e3DRSubcQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eJXHzDVCtQkWETSRyqVo6fskQV7PL9XSM7etYWxkYAu3jd/jlfP2d1nvwvSpJKhRuAYeh4sor3led8OuT2bPJw+mt47mGmNwt3ziIuS1cDEJBlKKNrPL692yog3vKW1fOPBheitbnyJemtElKxnVVWOGU65xl/hI6G2T858G5xRUwzLXYlgItYw+AvAhC4vyCNESwv4otmJIcKX3Xh7fiVoMKjt83wJYB6d9PcwKzOovWxd1SLJpFI8cU9Y9Ua788sids6mP6/kw2TZAJk3npPadKSgW5jNnaBX7hDGBkkaCt0lg6iALIF5i4iwqhv+PiR9of/ITdQvRibR4v1NKsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/qp2ByoPAY/8DAZJpeNEOCm7civFrFP5567MBR9L+nA=;
 b=e4a4vKMyS0YR0mTq36OUGYA2pPJwOb9LdstworxbSt3PF6J7pJ5n/w/PzPq+9hB7ss9WI6cbY4GkXinzP5ZO5Z4PT7FVSVdqH1vjhgXX48Du5d6tLKSyhwYkTXV1FPtRnulkN5GfRa6u5Ao34Ury8FB74RxWNxrtFRxTWRzjuSYV822Vc7Cbi92eJs2fdt+1QwynM0T5wBBLLRxBmZzzj0InlDDHsqSeOgzFRZ/YSoN8yLp7aitIX+nwk3HjnJLB0F2W1n/G8lIf5sJ4eNkGC+215qqBDDUy6GKiZEznfLT4ZElW3Aa2v6q056abmkVrh+puqZaiJqj/Ua/zv6Moog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b9e2ab93-f2df-9261-43fb-12784c13c821@suse.com>
Date: Tue, 5 Apr 2022 11:50:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 4/9] xen: export evtchn_alloc_unbound
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>,
 xen-devel@lists.xenproject.org
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-4-sstabellini@kernel.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220401003847.38393-4-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0058.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::35) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cb6189d6-adf6-4bef-2a6c-08da16e9ac0a
X-MS-TrafficTypeDiagnostic: AM7PR04MB6950:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB6950DFFC2795022225C3829EB3E49@AM7PR04MB6950.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Mxz7Ct3XL/jNXWVuEsUXBJSCbUd971A5bmI3KuX826JtaC/gRnE84IDSSAdFodXijV8Q21wFiQCC/XNha2wj5PzSH115+O7m8e1LV0Gv1pQMsbhqw9qdyvbvAv1h2RXe+IEfYmKz1J9OudfyG41ERy9Q2D+lGf0qLw+hpSrNJ4i12XXHVzTZCzRS31NhxgpUezKwy9x1N2vMD7MV41xtgukrOp/RDyodB2QFFsCFhjUR4EcNkrX03hp2xYK6uP94qeYIPU4sIcsGbnWqx1QjTXn3/i3uwAsOhvmgKb+HdUoBT6Y0I4VzISa8mXkDcOs9k2T4ze8WGrZStimLBm3ruSSvlnbVA3bM45g8M08JdLQ+xcfmVjZTrVGhG8xUOuE5rHO/CyMOTT3hqGqRLllZPbnxmfjL0DkIP+LjDkRJCLzEBuKfTLspcI9WM0VAqtKgDjls5K0r5bvgWLdbjwbHn+lNE6CeHDCTmfqcJhz7mpv4T0+nbjshHZGSxjwNDtkWFCpySYrnkZdg4jmXQacxiafVxItSLZlkQdqK52KCcA/beYo8WGxaDZO/TGlGqCp+UU1DcX3dBANUR7QNklSEw//NRrJ+yuLd4y8HV/XFgnPEYpkJSYg8PkfDZUZ36DDAf3XJIwdxsWwntQHG5BAfrNxS2XmKgYcUpgE/CoO4jMvvWJ6Rqt2PudYUB0oaja1YLvCaD/5bhhsTy6SWjsV3YWzTZO2GjMQGPtvHJGd5Ym0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6512007)(38100700002)(36756003)(53546011)(6486002)(4744005)(6506007)(31686004)(8936002)(6916009)(316002)(2616005)(5660300002)(66946007)(186003)(26005)(2906002)(86362001)(4326008)(66556008)(8676002)(31696002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MS9CR2NXVFVlREhQZnJIa01HZEpzUFp5NitmcW5FNldEaUh1SzByaE1lKzhY?=
 =?utf-8?B?N0hsRG5pUTcyZUQyNXYwVEY1RUhmWkthTFBDYmdTdUoyOGQ0UmhDcHRGd2x2?=
 =?utf-8?B?U0lHT0dhNnZZYTJXQ3EvRUQxV2FVdi9sTm5xcEtJc01uV21WRTBNNEpPQ2l3?=
 =?utf-8?B?SjJQKzV4aTdNV3NZQitva2RDZkVBbUhWeUR6VnB3WjljVVU5VjFnRGMvWFBK?=
 =?utf-8?B?OVdRbDN4TXA5TGtEMjBoN05ZN3hNRHJrMUhTSW5iWWZHRFkxUW9DZWkvZW8w?=
 =?utf-8?B?bkw4ZHRDUUFJYVBNZFNDVU5VcENyTVV3eHpEM1BrUGZTV09RNzRqVUZGSXo0?=
 =?utf-8?B?Z2FmYUd5bnl5eTR5VXJkNFVEc2pJcUdzclZrWjQ3blNPNGloTnpnQ0tWcTNy?=
 =?utf-8?B?MzNqbWVGaHREOXNacnQ4S09wRHByVGViN3RWa3RmbWMxNTh1NWlOTERMU1hi?=
 =?utf-8?B?ZWFiL1VpRTJEUDZpOFAwMlRVbnQyREx1Umh0SHN3TkNMRUFjUDFERXpJSGRu?=
 =?utf-8?B?K1B6b3hVbUxiQWxHTkZEd3puU2gxUHdxQTY1L3ZLNWhRNjJpdVRXRDBJUjhw?=
 =?utf-8?B?MjNLUGR3R3J6Z0c4eXFxL3p1WG1VdkhNeUpQbmJhL3ZFZ0llUXBpbC9zQnNq?=
 =?utf-8?B?alpaaExuZ0lHTHpGSWNlTEJXZW1YQ0JhZzB4TWxVTUlrS1JxQ2JVcFkzTUZo?=
 =?utf-8?B?dHIzeUF5K3hzRGlyTlNGcXRTZkw4d0ttUERlVGRqc1c5OGV4Z0lRcHJMZDMz?=
 =?utf-8?B?bDVHQkdSa0xZWjlKaTN0bW1NMlMrOVlTa0FleG5INVBQc2xCbG1pTTdUR1l1?=
 =?utf-8?B?VzNEQ1FhNXlBcFhHbEF6OW9rWnRlRUc1S3R3bUpocGZrbEtzTENOUjVuSWxh?=
 =?utf-8?B?Q3lPTnhlNTV3K1VUV0ZvTlZsemt1b0cxVWMyRUxseXlmL1VxbloxSnZSd3l3?=
 =?utf-8?B?TnNYTzdIQWxhR2htN3pSVFlpYklnYldQVzdzRTB4V3RyVjljQ3J6VDkrdlJM?=
 =?utf-8?B?MnZIZmVBcVFuVzd1TG43ZXU4dkxrTzVjM3RmckpuVmVuTzdIaGdlQ1phbXJG?=
 =?utf-8?B?bTd0dnJ3ZnE5cFpSVVZVTjBYSE1VWDVTcUFYNWg1d1ZQUUtybC84cDlhZUJY?=
 =?utf-8?B?Y05jRERxeVJFa0s1SkpEUUw2dmJKVkxTUXJpaVExZjVCVmNiN2xwNVBSa2pq?=
 =?utf-8?B?c3JEWmVaVHA3SHZJTHp0WFdBdDNxMkZHb2N2dXRlOXZ2R09tOFZXQXdLRE1t?=
 =?utf-8?B?TlkrM3o1L0YwTklnRHplWGhHdytRT3FFeWlPV0dIMWs5eTVvQ2p3M2ZYODd6?=
 =?utf-8?B?TjRVQk5XblFCbHhPUHFrbTdlSEpsU3BnL0hIV2tURmMrY0RyRnNzVzh1dnNT?=
 =?utf-8?B?UDlnV0JwZUlYS1VlU0lMR3hPeVA1VW45YnhkRHRkMVhsZW1CV0s4cWswYmUy?=
 =?utf-8?B?YXQ1c2h2Q0czNXpLUGl0aG90NXV0RDZFYWJpUVhRbHhUcENpNldQR3BDbG5q?=
 =?utf-8?B?RVQzR3lTMWV6VEg4MzMra1lQWUdxMHBEazExTUp2VFVLMUh1bDlHLzJZajUx?=
 =?utf-8?B?V2R1S3g5RHphUFZHVmYrOUJodUd4YWpZNkJaOVVvc3FPREwwN00ySmMrZmpa?=
 =?utf-8?B?WFNpZGVPT3JPSEtyNVZIUlUxSVZtZUFLV05IK2RTWlFMY0k0UzhwR1pPWWpn?=
 =?utf-8?B?N1hpbjI5SFUrT2NxaUthT1dTMytCOFh6YlBCZGhlVklsUnlSc1ZTV0RTZDlM?=
 =?utf-8?B?YW5RTUhIZkZhemhqbHJJNzF0QThDVC9vUUpXRnpIWWFPSGJNS1JwbTJ5ODJI?=
 =?utf-8?B?ZktqVk9WNE5HZ3NKNDJmNkdGUFhLazlWN0F2RE9ia1FpYU0yWUdMSzZhOVRo?=
 =?utf-8?B?VUtVbm9tcWY3aEJ4ZzUvNFVLbUF4eDJXUHBnZEMrbUM1akJLd2NzaHpsQ3ZK?=
 =?utf-8?B?ODNRSWlnWHFqTnJic3F3UmF1Y2dwSHorOHBIT3dtcU9EUXRiMDBUaDdGdU5r?=
 =?utf-8?B?VHNUbHlKTnhLenJEUy9EVGtTR1poRk9DRVFkVHhGZFdZbUtsRnVIbDVBcUY0?=
 =?utf-8?B?WWQxRW5TUlJ4SjVaSHRPMW5GZTRLN2FxMTMwYllmWFB6d21SaC9ENWh6U3g0?=
 =?utf-8?B?d2lrOXNvMWxLbUhBWGdMRXR0cWpZVG44aWhpelhadzZIcFJBb0xEMlhiTktv?=
 =?utf-8?B?ckg3dlhQb3lhMVRiR2VYSXk2RVNTQmxaZG4rUXJIbEhwQW1iaUtyQWY3VnQ5?=
 =?utf-8?B?T2ZaZ2NReGdYT2xFSG1NQ0tKdU43M21saUtGRTVnUGlMTjVaV2NzSFNubTNJ?=
 =?utf-8?B?VmVMNWxxb09wNDZ5TDFUSEs4VXFlZGg0eXZJb1crd3IrWVlVdGxXQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb6189d6-adf6-4bef-2a6c-08da16e9ac0a
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 09:50:09.7603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tamhE57lEhcKid31sx1R0HoS/+ygLhj5a+0iWPLL7LTYek6RNcDSPUXR+x4ICym0AMAsw0W77SvTWs/Cp9vonA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6950

On 01.04.2022 02:38, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> It will be used during dom0less domains construction.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

I think this better wouldn't be a patch of its own. Functions should
be non-static only when they have a user outside of their defining TU.

> --- a/xen/include/xen/event.h
> +++ b/xen/include/xen/event.h
> @@ -71,6 +71,9 @@ void evtchn_free(struct domain *d, struct evtchn *chn);
>  /* Allocate a specific event channel port. */
>  int evtchn_allocate_port(struct domain *d, unsigned int port);
>  
> +/* Allocate a new event channel */
> +int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc);

I wonder whether while exposing it the function should also become
__must_check.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 10:18:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 10:18:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298684.508909 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgGP-0004Ia-RJ; Tue, 05 Apr 2022 10:18:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298684.508909; Tue, 05 Apr 2022 10:18:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgGP-0004IT-Mx; Tue, 05 Apr 2022 10:18:17 +0000
Received: by outflank-mailman (input) for mailman id 298684;
 Tue, 05 Apr 2022 10:18:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbgGO-0004IN-Ey
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 10:18:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b453fe4c-b4c9-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 12:18:15 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-l2LjAjnSPgibys-DhlTWtA-1; Tue, 05 Apr 2022 12:18:11 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0402MB3596.eurprd04.prod.outlook.com (2603:10a6:7:84::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 10:18:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 10:18:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b453fe4c-b4c9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649153894;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GIuvHaYSSb3pg8QaG56joJLcG/IlkkOagWlfFua1ak0=;
	b=CAAFmY/0ZTwupCG8Muzmlq/mBTr6uRkb5FPgTqLLnqbcse+7GIQhxwCN3CF0lNJl737JLn
	3fVpIr/vk+AeLSJkP6o/m4uz/rvEgaLuBL1WW1uqqDv3yRp0ar9mhj4xlyyAGTDTh1WSYT
	l/8YsKKQdw8yF8Y1Pi+uChlKYA0bhjw=
X-MC-Unique: l2LjAjnSPgibys-DhlTWtA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mXB3iRtsZQUrVZDQE9pXaGR29eN8uCdYDtsfTpokxlZF+SYwgs3/xCDIQTYEpsGwBqLBcDhs4fbfNZSEMGSlpfJYFTHs8diQpjbcaw16WkLQVBSOFaTpse4LR8qgYD4QLWRMHkHBiwyltfSd3ffGHZkkQU9CfN7ArGz3+4JvTUQgARlCICTDiQzkHwEBIfJkJrpYsDqBIkJHsoR1S34XGv2y9UtuiTfhbeZww9BIGOnfDDLI/9X7ysOsNhwajcty35sIDtsSG5aK56iN837KiGzLrX2VDU85vGGlxfCExpGAMC4bdPpFkA6Xa3h3Le6nFZdCqgNzVVWh/LKbGpx7tw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2DkQ4pP+5ENn0PQkqkyQdg6DcMTLH1hPRYx0uNcp37o=;
 b=ggwgCztYQ97yXKVKtCOL3d/NyHoHSOK7MIjFUtSqMO4VoNbWgqMnHdToqW7vDKm1lCK9ExFA0g6MbcKSsON9KsWGgshmtjU9X8ZFfAMhKM6+3ayowULWBGBJuiDhJnJT6apVbJHEZYCYNvLoGYJvqJ+9y3/wail75yqdpDOj695DSfHBfhppzN0uedUNCIFVEYIQ02axa4EBeN5YO9rfNVMFqRaYB0EVpAO1Oyp9/RbSNjzU8qXXPJc6lotqj2QmMkIPr3LatSG+Kblqh6MXSA2U/j9EkH1p0w2XQO8AkOD2JWfTy8gSOhKmg0dQ7yG+Yb897C+b0EFZbkCzx10rGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <75bd55fa-d29b-d49e-c3db-1bb952e4578f@suse.com>
Date: Tue, 5 Apr 2022 12:18:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
 <e20b3d17-0c2a-b23f-d949-667072a54f58@citrix.com>
 <ed31e78b-087e-869b-8aa0-5d5d0f3183fd@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ed31e78b-087e-869b-8aa0-5d5d0f3183fd@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ebd2399a-c4eb-4ea4-a47b-08da16ed950c
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3596:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB3596B8765A4C18F078D6356EB3E49@HE1PR0402MB3596.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qFwR9ydjoIW6BywaxRj1jahKPw7nzURiv7ZIeT6tZefwXtrg02gWa697/AxeLdmKHpgNd67K6gxY4afPi6dZQ5sW+RP8XEUvrt7Ca0Shvk7EnfMCSRzJYh9/g+qW5w15efouIabQh+vFqfWKWFt1A+f3Yd8GWqsy53agk/XMyH5ByuJQuguG2TLeTtEdbTNWPpNI559jjW1r5A52yxoHzTiQ+QRlkaSe+EMOx+XYZkrzGCdbidtU0ve/gRPysoU0W7lp/6BFoZnoD90FBCQEnbFTvpZXYGCgo8iNUEPzeVl742sHyLA2ZecQ4sLRKOselmgLSFcwG9ogwTE7HyLxIi3lkSnw4tm6b79lrSo+fD2YKoBeVhzcNOsHpUAlKe1YHqLF0pAipK9nx6bVklvIiex1GJoc4vE5Yi4OjtmKG3ppAHpcSFnSqr3qXm/Pti4ep1iVYSKIkqqHH9VYQJTzFqYvbImr8C62t6iNC9N7rzuSpxYUCuZu2ZSCQeruz8zAhbRM2batFFCz2nZE4Yze8xz5lmdxzCcN55TVFaCI43J0yGUNhZ6H7wGAgDzfD8S4M5CJqggJrH0a75NdZe7d62vH6NSUisHXvRItWkvClkre9nNy1Q+qUaizM+alVLbVz3jJGDhQdRxio3KwM4Akv257eV5v29Vdw4bEDOjHg7rfDwgJMSXKsFZ5Fa6hHk6FiHNCOCKvQRVcSoZXYWm3X9wyhi55uUe4imYdd6TgLH8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(8936002)(26005)(508600001)(54906003)(6512007)(6916009)(4326008)(66476007)(66556008)(4744005)(66946007)(6486002)(8676002)(2906002)(186003)(31686004)(6506007)(38100700002)(2616005)(316002)(36756003)(86362001)(31696002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8BL08eaguECCk3grYTDI0ECYXjo8+zk7ne7OUU0kB4On70E6JKPrLB95JvHN?=
 =?us-ascii?Q?945Fjw6ipqTC64amWQK2lVUR62NsCTXVNMRSUkBs/RZisB1UgA09TSFJIxiH?=
 =?us-ascii?Q?Y2Mnpxjdrl7KmaaPKISrLh+UajtATr64lqpWRO+zZ6NWfuwvKtq9LRWgh/ma?=
 =?us-ascii?Q?utxWeal1ZWDt58KQ2jDNX0kUaIFmODNrH1Hs5GFaGudwbUv+p9112QtC2dmz?=
 =?us-ascii?Q?zeUb0j7JNFQLfphWFZXu6QjPLtrkAGxiEm7C+t/TZm00YJHALPcHutZu3cXS?=
 =?us-ascii?Q?9uEozs2aPl3JD55QavAGIbWSg7edf0NBr6CeCaQFbYM8IxOzCeKwbwpYzGdM?=
 =?us-ascii?Q?6Bj5DEUcdQqr4PIElDoAF9ClVlM7sfYIPlKRdus/xqWCU6CQtk8vHz/SZL5Z?=
 =?us-ascii?Q?tP3ImEkqGOW3jYcUI7OgkjBsNS6slGFRbUnbf1dPxLGFK2isD13LdQJlTPih?=
 =?us-ascii?Q?ZpfzaQpA4mvx7OWKMxx0XivtMRovenrMGSRnToJpldd0+kl+X39R8hEV5m+Y?=
 =?us-ascii?Q?q92JenA2e53d7/Q1+9OnqT3gk5vXmu5pWR4JFsl32IEyJww5FahsFxuRcZ+3?=
 =?us-ascii?Q?C3md4y2BV0UX5uP98+YfZg5wP44Arqps00PnDlUR1e47U6SoK+KNVNjQ42Qm?=
 =?us-ascii?Q?/FXm32fiYIhg+oqH2lgSislzheVlGyWC1JKc9rm2xZ3j7FrcbhqCWEA0xL91?=
 =?us-ascii?Q?WOJ4vPpppjgeIvM+rIIE5YBxaYBXcrUnnTxL5sbRi4jOIBs4gMc1mzuXNZdo?=
 =?us-ascii?Q?HWTSyL4WHgiiluViGkrmEOYfkGALcAOKr8bGX9/q7kdnpad3gdi9XYnZp6A3?=
 =?us-ascii?Q?gIfe41NqHbcuywa+xo54mba6yZI5YffI/bTpzWg+0SM9i2IzDR6frmd3O9A3?=
 =?us-ascii?Q?62ePwhhdrA7J1M1BrgkN5l5Vn94iNlxBzKv3+/pLzDtrCrgB29BgPXl2LXhi?=
 =?us-ascii?Q?VTFxMet8RwZ/O8wlpIrsF0kCtjUaojCK8TbNXGw5l0ep63L2e7CfoCzM1DB3?=
 =?us-ascii?Q?lz1GAeLv4NeQvWkYiN5NSrHwB92EWP7FI/VHP1GoRhQCjMMRgAETPyI6w6Fi?=
 =?us-ascii?Q?orx5sX6DuCnqyZhl/m8nNP3cn3WMTIrVxx2Rg1G50Hfh5VnFQT6zDIWUI0He?=
 =?us-ascii?Q?WCrbX+4ws5+JSzooo3exRZETQR7jzQF4HQKHXY9X3jRjr7g/EnnWotMAvSDa?=
 =?us-ascii?Q?E7VZvWRXDO/X3vraudfvu3GGo+Tq7w6kpgUgLAobi2uqWH1KgLauoizmXIQB?=
 =?us-ascii?Q?V23LiyDyFtmdMZrEcNrj97a09g6hOQPMcmCLLgsdZiOEgxxfhqeCTAJrjDay?=
 =?us-ascii?Q?NIbRKKaRCYAa0swS46UJmZf/a7mmpLMYpAwIy2+GwYPjyXytdFCzpaV2vY91?=
 =?us-ascii?Q?8Glf06R6DkBdq09hc00ZHUxZW1ZzkEJTqeqGBr+ObrweBD0aSqqJ8Qln2IMY?=
 =?us-ascii?Q?a4xM4qRnSzjl5LxxaKLUF4ln0KhPg/qTnnibKcLhAmMxwwJn4qjjYqYO5b/m?=
 =?us-ascii?Q?3YJVWvWN2JcCp5LXwATOnGeVTXXq1tH4DpCR6MxWQKA1r3wLBuZxFqiTFlZk?=
 =?us-ascii?Q?Jo+mesdystwaR7Z14oEu2choPCBAmkSZvxc7wr/6WtPF+CIInZTVBsPPCllW?=
 =?us-ascii?Q?y697T7MYJhI5iEK2DIEbiqqVBEkUONx/lDz3iDDMt+1vVIVUOT7W2k8jPHwy?=
 =?us-ascii?Q?cOWn9rlv0FztXcyNVgVhTJFkxoN6mLX6q9VSk2xg87ZgVpPp253rQhwl08at?=
 =?us-ascii?Q?8qOiQ8Xbgg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebd2399a-c4eb-4ea4-a47b-08da16ed950c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 10:18:09.1758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SglviyhQSWTVSLk8mSrjkGQHaeQmmxAkiFh0qTAqGAmpnwqKTAX4uZsxt7PTgdx8u29v0o2g76FHJ92sOjlvaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3596

On 01.04.2022 17:05, Andrew Cooper wrote:
> On 01/04/2022 15:48, Andrew Cooper wrote:
>> On 01/04/2022 15:37, Roger Pau Monne wrote:
>>> Setting the fcf-protection=3Dnone option in EMBEDDED_EXTRA_CFLAGS in th=
e
>>> Makefile doesn't get it propagated to the subdirectories, so instead
>>> set the flag in firmware/Rules.mk, like it's done for other compiler
>>> flags.
>>>
>>> Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT')
>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>=20
> This also needs backporting with the XSA-398 CET-IBT fixes.

I don't think so - the backports of the original commit didn't include
what this patch fixes. I have queued patch 2 of this series though.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 10:28:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 10:28:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298688.508920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgPk-0005mb-O4; Tue, 05 Apr 2022 10:27:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298688.508920; Tue, 05 Apr 2022 10:27:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgPk-0005mU-K4; Tue, 05 Apr 2022 10:27:56 +0000
Received: by outflank-mailman (input) for mailman id 298688;
 Tue, 05 Apr 2022 10:27:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbgPj-0005mO-Qx
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 10:27:56 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0bd192f2-b4cb-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 12:27:53 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bd192f2-b4cb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649154473;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=2PGknIrglFtUDln2TCqEDHxUo4FAZrdPAz6DGG5+jg0=;
  b=FlykEXhyHj26Bh25O5VGANMLqwJySXZ/1Y4BnUAs3HQj+oPeBWvgbKdQ
   wcBY9RZD8HweBZScPLzBghwcTlIBUbTlcgiD72+0zb/GveMfk3iUbI7yA
   gs3xIAPm6jrZA7K11DSMJB01ju6h/xqVgdvxyQJTmzc6kLms2uwda8bQR
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68029405
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mfjPnqC2HslliBVW/9zjw5YqxClBgxIJ4kV8jS/XYbTApDN2hjdTz
 jEYWD/TOPqPamagft8kYInjoEMPv8LSyINkQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jh39Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhQk
 dRtkpe8FzsXN/f+o9gYaBN3MHlhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGjG9q15wWQJ4yY
 eJJVWtDMAvQcSdxBWxGGaAumMPwij7gJmgwRFW9+vNsvjm7IBZK+KP2LNPfd9iORMNUtkWVv
 GTL+yL+GB5yHMKYzT2J43e9nNjFlCnwWJ8RPLCg//ssi1qWrkQZBQcKT1K9rb+8g1SnRtNEA
 0UO/2wlqq1a3E62StjwWTWorXjCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1ZpeNEg8cM7WzEu/
 luIhM/yQyxitqWPTnCQ/avSqim9UQAKKUcSaClCShEKi+QPu6lq0EiJFIw6Vvfo0JulQlkc3
 gxmsgAf3rQzqsUHiZmF9Ar1uA6pnZLmbVYqs1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr
 EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM
 B6K4lM5CHO+0RKXgU5Lj2CZVp9CIUvIT42NuhXogjxmOMUZmOivpnwGWKJo9zqx+HXAaIlmU
 XthTe6iDGwBFYNsxyesSuEW3NcDn35ilDuJHcymk0/7jdJygUJ5r59fbTNiichjssu5TPj9q
 Y4DZ6NmNT0BOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+zvlOQwkc5wvq6ep5IeRNxv0N/s+Rp
 y3VchIImTLX2CycQS3XOy8LVV8adcsmxZ7NFXd3ZgjANrlKSdvH0ZrzgLNsJON9qbM6kaAvJ
 xTHEu3Zaslypv380211RbH2rZB4dQTtggSLPiG/ZyM4cYImTAvMkuIItCO1nMXSJkJbbfcDn
 oA=
IronPort-HdrOrdr: A9a23:Oqt+MKwPrGPOTnpMQVGLKrPxwuskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9wYhEdcdDpAtjnfZr5z+8J3WBxB8bZYOCCggqVxe5ZnO7fKlHbaknDH6tmpN
 tdmstFeazN5DpB/L7HCWCDer5KqrT3k9HLuQ6d9QYXcegDUdAf0+4TMHfjLqQZfnggOXJvf6
 Dsmfav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QZiApIs+PvP+UpgNdtvpYfHHfFAlEii8eV57HzzcZdQ60jT22trK3Ik=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68029405"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N8D2iR9wkmNH8D1EF4aoibn68bqh13y3wWVUHIlMPgGWeYFNiAmcbc0PlJH5j3VyWs4OhcbEJHCC947+EkxYHIoHl/TqZy9MRVAQjsCQQXgPcc45irBpnQ5r74dXOOhak05ky1B1A/p3spqQAmEVQjOdnInhkdjlD5db2Yehz/4d+/ZUOwx0apeiXvZs3gzxcelF3oGroJu+I/iI8ReQ3D5IaosFDaEZoOSl7+yqIcsmg4vb2g1I4RA71VNIazhABJNDBZgAcQGUxc++VxD+f0t2RWMinkhCkxyo/2vlE8pdTrKEAtiy61L7JpL7OWwXQqAOuHR7SfXIjQU6w9L0mQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GYVut/VAL22ydjAROR+Mnb1G9/oiCc3JqVynNIb93J8=;
 b=cKatRWN7uFOyVbIT0q4rDOYgGhXvr4uM1LbEcOwpjdeR5XCEmGNxhPqWc5oAaChmCMUzcH2U3FnK9pdyF63ouedJSP+NSKN3e2m8Zt9zkrpR21lKchOBV2IzPBQKwU+s6REKP7j4Hs4rUtVhl3fr3l7Y3+geJL3o9pNuG6+XgH7Res2pIterAhOvRsVVdZNRDbw09gZEgsnL018nzRjene9muQ5ToiT6caCom0mA6Jzh0egGSs/jH4vSVKaId7pFhux+Wyva1A1lkVjF9gB1LBTYJuXhQ0FVXY/xLHMKJ8pSZwXeYdx8JRG3TVSe4+1yz4UMefzH02VN7u/pgEiWag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GYVut/VAL22ydjAROR+Mnb1G9/oiCc3JqVynNIb93J8=;
 b=XNE7BOY1jaE6HyjJ3vN8tmCGdDj+WUnYJ/+pbeSYmHvmBGvl5/ASzb4iAXHA/NXx8zxDaVinGcViROPqsgQv0474qaCngFGUdasaQSTEXwRsvNF8BrzMyd9CWz4TtgpDpBjzQVa/qsM4xNK+3PYfV8YqZ1MQGSgW7/G/d8yRs+g=
Date: Tue, 5 Apr 2022 12:27:40 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <volodymyr_babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Message-ID: <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
X-ClientProxiedBy: LO4P123CA0450.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5419886c-ca9f-4c71-0ebd-08da16eeed32
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6517:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB6517EF3384C5A8B8F9BF1DD78FE49@SJ0PR03MB6517.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EuG5uOaNh+4OtdQKMggfQK1zR37s8IQaYaMapYQIYAJaED+thkTfuVkzMpCEm02qVrdK8uEzLY8b8FZElmWdAvVVJSTzbwrue3H78PtR9OnQEkPrOBBMXwR5ILwqpMD6OD/XfyMRdGKi7IQSXe7DKmZEClrb8GZxt1+GN4+tdGgKRzU20Ndv5mZepYFHzPSgMRpLgEN81OZK2ia8hkXhDycafr7nv0pcqDn7Kj+6yh25sV4wnvWehRosXS0GvPtX7ZCCBzMmUsHgnHDgp1myIjIEIJsrTZx+gyWXHPO+ytAZMplBVawt/G8iIdvzJHgcJbmTapVH9jjRfeP2hmtoU6GuhjW+ZZFOMXKIRmwrImPv2yMyDfme/qhsF4kMdWcHgGhGq87arqA8XOvD1ecPnBO4Ea62PXXalGAjOkIhmu34wDFncBV2H7eMxdges5QZGLFiwXFjoXVe/JMpZoTE+4spt9cAAxHrbgA2EOzvkHFpIkFzS15qF6Dyta6W5vVPDWcw4/cLjCixS83nzl+cY7PuSotL2fvFJWTh3oYdhhjUiC+b4YnBO0JGYzc9zXbEE5xsGbUFtDufTvwuRafsWUTujwx0tt5XW7VBKZ4oMjSR5xSBaGfGBid7anrntiLzf1nS3CEQ7GJomIr8X46rIS+rNxZPezNF/h02EvsI1MvVsWs1Z53AMy1zjKyY5HHWs3vvLYodf8H5SwyZqxxRyQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(4326008)(508600001)(8676002)(86362001)(2906002)(8936002)(82960400001)(5660300002)(9686003)(38100700002)(6512007)(66556008)(54906003)(186003)(33716001)(26005)(6666004)(6506007)(66946007)(6486002)(66476007)(316002)(83380400001)(85182001)(6916009)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXhWaWlaQ01OZnF3UWtVenNrU2JVMGI3aTl0UGZYekp0WnNwWTFBRnQvS2pn?=
 =?utf-8?B?QVJqbmQvWkFEVE1uK3pFa2wzRjMwUzhaU0VMbG9KakJEN3VrcTlBZWtWZ0g2?=
 =?utf-8?B?L3J5bkxpcFh1SUpxTTJaSmc4cFZwYUhGZ2UxK2pyYm4zQ0E2T1ZYMWM1Qk1u?=
 =?utf-8?B?aGhhczhsSWRYamlraXZpYW9RNEdWeUUxemZJRS9aT1p0czVTQlZZb3hHelQ3?=
 =?utf-8?B?N1dvQ0NBN2YvdXdpUkgzck1MdUpQL0tkZE44cm5mREZ6eWFBYVZycVdweTNE?=
 =?utf-8?B?c3FTbU9xckdUS2s2SVNpRk9OV0ErVzgwOEZJZ3A4Tkw0by9BSW9mRkRzV1hH?=
 =?utf-8?B?dGQ4MXNrSHBOSnFDeUFUQTJnS0ZCbytEci81WDQwYWpqM29uZXplMkl2aTh2?=
 =?utf-8?B?QW1kRGkrUXF0WVA1QkpvZXgveFNLTjdrSXVBYUdhMUpLRWIvcVg2NUV5dERq?=
 =?utf-8?B?djNsTlNYQ010YjRNeEd0RGZia0YxQVdVSld1dFRHOG5WdjRJVk45MTQvNnMr?=
 =?utf-8?B?UDIyZlN4dmx3aEYrQmhsbVZieVJBeHZMWW95d1VUcEhvQnFNUHRhWEYrTnR3?=
 =?utf-8?B?cnVmL2dZOHJBZEwyT3pFVG5IK2UwaExQS0thWDF0NmZOM24xMlJQbUFpdUtK?=
 =?utf-8?B?Rmg2N055VVl0dWZIMER1K0NxK2wvMnZ5c1prNDlXK2ozdTdpU1NEbmtmODRh?=
 =?utf-8?B?ZXRzUVRsTkNsVlpwQTN2cmtNMXZ2T1VQZzZEV2V2TEpnNjMzOFFlSzVuTFYx?=
 =?utf-8?B?THEyTW9nNEYwZ293UU54RjI3aUFuQ2lKbFFBU1l2aUVZSmdKdVBDS3A2VG9G?=
 =?utf-8?B?NjFjN0VaN3pUU2pXczJMdzk2dktxMU95a3Btak5pTDBudjYzWlo4bVNxZkxq?=
 =?utf-8?B?V0NIVm1IeXpFcVpwTjk1MUxON1VVMFF3eWJNMnRVdFQxNGpWSGkxVkNHMXhU?=
 =?utf-8?B?THE0czR5eHhFT1ZXei9hdHBWWVJlQndjTHRkL0V1NUpuaWc5Qm1Ya2JWTUx4?=
 =?utf-8?B?L1UwMjJvOUMxc25ENlFjK0xsdDhJTWF6U3hEODZreTV4ZFFVMy95NW05VnZ0?=
 =?utf-8?B?VHF4dC9tMlhxMkNLOG9CYnJQK1p6c3hvZVYvL1dLUEJEVlFTRThJVHU0VlNZ?=
 =?utf-8?B?bXU3NjJERm01UDhEMkU5T3h3bWUzT2lYQU11TEpaUkZ6SENOZTMwRHF1TW9k?=
 =?utf-8?B?TzhVQ2FXaVRNSmtOdGZLbmM5WkdyQ2VvWWQ0UU51Q2JpOFVRd3FRMmh1dUQv?=
 =?utf-8?B?UGFQR1I0ZU13SzFHRUJHejhvVlRnRUhrcEJ1VHhQYll6YWpiUFFxM09FNTBt?=
 =?utf-8?B?RTVtSzJDNHVkM1hySUk2b3BMM3RGbWxOcWcxQWp5YUoyY0tSeTl5d0MveG5W?=
 =?utf-8?B?ZVB6UkpqMmRwOUlZZHByWW9VbmhGS1dXelJ5SVY5QWJWamNKNElITjJhanpr?=
 =?utf-8?B?MDYwR3RXVkdvcWRCMEE0NGo3VFMydUczSGhZcmk5ZXkxRUlzQ0FaS3czcUhK?=
 =?utf-8?B?RjFGdWpKbmJMRTd5MGtPWmwwWEg5OWU2blZnN1lCTW5xTVlWVndsL0VtRDVX?=
 =?utf-8?B?UDZiTXFycVVvdXZhMzIzQWRGVVNucGZzU3lQL0ZlMnc4VjBKSGFUVkk4WUtm?=
 =?utf-8?B?VlN0N3BYSG1zQUZvZnhVSytzTkxZQTUrSmpxVVBnSXkxbk8xdGkwNHY4a2Jr?=
 =?utf-8?B?dmd1NkRYckxueTJwY0JzSWRSbzQ3RFlMcG1jd1lzMFlkRHk0d2c4NUZoZnAy?=
 =?utf-8?B?ZVk3ZzJLcm9DOGprUTk3VndOUXZ5QitGQzZaQUFNYUpWOHc5TXRkTW45ZFMy?=
 =?utf-8?B?bHQ4bFE4RXJvRlRYOGZOVDRKSUMvcHdBSlhKQkJWQ0VlcDh4YUVLN1dWK05Y?=
 =?utf-8?B?VmlhWGtDRk5PVHpEbWdYWTdVcDRMdmpuKy9yUHorTUdSd21zN0RXSzA2R1Bl?=
 =?utf-8?B?ZmFNYXZZTjJ2WGtHK0xGa2FDM0pFYVM0L2R1V1RNdUsvRDJkOENSMVZ4RExB?=
 =?utf-8?B?NVdvS2xZUXRCNDBUU2ZsZlVzK2dIajZBSlRtV1UrL29LWGdtVmFzZHY2YW92?=
 =?utf-8?B?ckxmYldxTk5rb2daWGc1QmEyQzZxc3BaQXQydnBqNnFqT0YvdjU1WlNhWW1t?=
 =?utf-8?B?SFlDeUthclMvdHgyejM2M3dOaDJmN2ZwaVhXUlQ2N2YxVk55TGFTQktvZlgw?=
 =?utf-8?B?bnNIZ0FrU0NRY2R6d3pROG45Q25yWThYK0JNQXcyczduTXYzMHg2R3drNkVq?=
 =?utf-8?B?SnhMNEpKaUJzaTFPK2w3WkEycy9xNzd2SmJhV2hTWk5JS2RydTVPdVJvUGg2?=
 =?utf-8?B?SWI1YzhGVVhiN20xbUF6ODdPd05CWVA2dkdTQndjQlcrQ1BLakttY1dDR0gw?=
 =?utf-8?Q?wbYjKyz2gLz9lH/Y=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5419886c-ca9f-4c71-0ebd-08da16eeed32
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 10:27:46.5417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m5Y+C6kuqIvXEP4nFqbJG476eErxy/Sow+nhe4aVW49NDVz7P9p8caiOpgimAlIgBZalfsJZINT816vBZ7wF0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6517
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:45:36AM +0200, Jan Beulich wrote:
> When booting directly from EFI, obtaining this information from EFI is
> the only possible way. And even when booting with a boot loader
> interposed, it's more clean not to use legacy BIOS calls for this
> purpose. (The downside being that there are no "capabilities" that we
> can retrieve the EFI way.)
> 
> To achieve this we need to propagate the handle used to obtain the
> EFI_GRAPHICS_OUTPUT_PROTOCOL instance for further obtaining an
> EFI_EDID_*_PROTOCOL instance, which has been part of the spec since 2.5.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Setting boot_edid_caps to zero isn't desirable, but arbitrarily setting
> one or both of the two low bits also doesn't seem appropriate.
> 
> GrUB also checks an "agp-internal-edid" variable. As I haven't been able
> to find any related documentation, and as GrUB being happy about the
> variable being any size (rather than at least / precisely 128 bytes),
> I didn't follow that route.
> ---
> v3: Re-base.
> v2: New.
> 
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -464,6 +464,10 @@ static void __init efi_arch_edd(void)
>  {
>  }
>  
> +static void __init efi_arch_edid(EFI_HANDLE gop_handle)
> +{
> +}
> +
>  static void __init efi_arch_memory_setup(void)
>  {
>  }
> --- a/xen/arch/x86/boot/video.S
> +++ b/xen/arch/x86/boot/video.S
> @@ -922,7 +922,14 @@ store_edid:
>          pushw   %dx
>          pushw   %di
>  
> -        cmpb    $1, bootsym(opt_edid)   # EDID disabled on cmdline (edid=no)?
> +        movb    bootsym(opt_edid), %al
> +        cmpw    $0x1313, bootsym(boot_edid_caps) # Data already retrieved?
> +        je      .Lcheck_edid
> +        cmpb    $2, %al                 # EDID forced on cmdline (edid=force)?
> +        jne     .Lno_edid
> +
> +.Lcheck_edid:
> +        cmpb    $1, %al                 # EDID disabled on cmdline (edid=no)?
>          je      .Lno_edid
>  
>          leaw    vesa_glob_info, %di
> --- a/xen/arch/x86/efi/efi-boot.h
> +++ b/xen/arch/x86/efi/efi-boot.h
> @@ -568,6 +568,49 @@ static void __init efi_arch_video_init(E
>  #endif
>  }
>  
> +#ifdef CONFIG_VIDEO
> +static bool __init copy_edid(const void *buf, unsigned int size)
> +{
> +    /*
> +     * Be conservative - for both undersized and oversized blobs it is unclear
> +     * what to actually do with them. The more that unlike the VESA BIOS
> +     * interface we also have no associated "capabilities" value (which might
> +     * carry a hint as to possible interpretation).
> +     */
> +    if ( size != ARRAY_SIZE(boot_edid_info) )
> +        return false;
> +
> +    memcpy(boot_edid_info, buf, size);
> +    boot_edid_caps = 0;
> +
> +    return true;
> +}
> +#endif
> +
> +static void __init efi_arch_edid(EFI_HANDLE gop_handle)
> +{
> +#ifdef CONFIG_VIDEO
> +    static EFI_GUID __initdata active_guid = EFI_EDID_ACTIVE_PROTOCOL_GUID;
> +    static EFI_GUID __initdata discovered_guid = EFI_EDID_DISCOVERED_PROTOCOL_GUID;

Is there a need to make those static?

I think this function is either called from efi_start or
efi_multiboot, but there aren't multiple calls to it? (also both
parameters are IN only, so not to be changed by the EFI method?

I have the feeling setting them to static is done because they can't
be set to const?

> +    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
> +    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
> +    EFI_STATUS status;
> +
> +    status = efi_bs->OpenProtocol(gop_handle, &active_guid,
> +                                  (void **)&active_edid, efi_ih, NULL,
> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> +    if ( status == EFI_SUCCESS &&
> +         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
> +        return;

Isn't it enough to just call EFI_EDID_ACTIVE_PROTOCOL_GUID?

>From my reading of the UEFI spec this will either return
EFI_EDID_OVERRIDE_PROTOCOL_GUID or EFI_EDID_DISCOVERED_PROTOCOL_GUID.
If EFI_EDID_OVERRIDE_PROTOCOL is set it must be used, and hence
falling back to EFI_EDID_DISCOVERED_PROTOCOL_GUID if
EFI_EDID_ACTIVE_PROTOCOL_GUID cannot be parsed would likely mean
ignoring EFI_EDID_OVERRIDE_PROTOCOL?

> +    status = efi_bs->OpenProtocol(gop_handle, &discovered_guid,
> +                                  (void **)&discovered_edid, efi_ih, NULL,
> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> +    if ( status == EFI_SUCCESS )
> +        copy_edid(discovered_edid->Edid, discovered_edid->SizeOfEdid);
> +#endif
> +}
> +
>  static void __init efi_arch_memory_setup(void)
>  {
>      unsigned int i;
> @@ -729,6 +772,7 @@ static void __init efi_arch_flush_dcache
>  void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>  {
>      EFI_GRAPHICS_OUTPUT_PROTOCOL *gop;
> +    EFI_HANDLE gop_handle;
>      UINTN cols, gop_mode = ~0, rows;
>  
>      __set_bit(EFI_BOOT, &efi_flags);
> @@ -742,11 +786,15 @@ void __init efi_multiboot2(EFI_HANDLE Im
>                             &cols, &rows) == EFI_SUCCESS )
>          efi_arch_console_init(cols, rows);
>  
> -    gop = efi_get_gop();
> +    gop = efi_get_gop(&gop_handle);
>  
>      if ( gop )
> +    {
>          gop_mode = efi_find_gop_mode(gop, 0, 0, 0);
>  
> +        efi_arch_edid(gop_handle);
> +    }
> +
>      efi_arch_edd();
>      efi_arch_cpu();
>  
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -118,7 +118,7 @@ static bool read_section(const EFI_LOADE
>  
>  static void efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable);
>  static void efi_console_set_mode(void);
> -static EFI_GRAPHICS_OUTPUT_PROTOCOL *efi_get_gop(void);
> +static EFI_GRAPHICS_OUTPUT_PROTOCOL *efi_get_gop(EFI_HANDLE *gop_handle);
>  static UINTN efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
>                                 UINTN cols, UINTN rows, UINTN depth);
>  static void efi_tables(void);
> @@ -758,7 +758,7 @@ static void __init efi_console_set_mode(
>          StdOut->SetMode(StdOut, best);
>  }
>  
> -static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(void)
> +static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(EFI_HANDLE *gop_handle)
>  {
>      EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info;
>      EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL;
> @@ -783,7 +783,10 @@ static EFI_GRAPHICS_OUTPUT_PROTOCOL __in
>              continue;
>          status = gop->QueryMode(gop, gop->Mode->Mode, &info_size, &mode_info);
>          if ( !EFI_ERROR(status) )
> +        {
> +            *gop_handle = handles[i];
>              break;
> +        }
>      }
>      if ( handles )
>          efi_bs->FreePool(handles);
> @@ -1222,6 +1225,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY
>      if ( use_cfg_file )
>      {
>          EFI_FILE_HANDLE dir_handle;
> +        EFI_HANDLE gop_handle;
>          UINTN depth, cols, rows, size;
>  
>          size = cols = rows = depth = 0;
> @@ -1230,7 +1234,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY
>                                 &cols, &rows) == EFI_SUCCESS )
>              efi_arch_console_init(cols, rows);
>  
> -        gop = efi_get_gop();
> +        gop = efi_get_gop(&gop_handle);
>  
>          /* Get the file system interface. */
>          dir_handle = get_parent_handle(loaded_image, &file_name);
> @@ -1360,7 +1364,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY
>          dir_handle->Close(dir_handle);
>  
>          if ( gop && !base_video )
> +        {
>              gop_mode = efi_find_gop_mode(gop, cols, rows, depth);
> +
> +            efi_arch_edid(gop_handle);
> +        }
>      }
>  
>      /* Get the number of boot modules specified on the DT or an error (<0) */
> @@ -1387,7 +1395,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY
>  
>      efi_arch_edd();
>  
> -    /* XXX Collect EDID info. */
>      efi_arch_cpu();
>  
>      efi_tables();
> --- a/xen/include/efi/efiprot.h
> +++ b/xen/include/efi/efiprot.h
> @@ -724,5 +724,52 @@ struct _EFI_GRAPHICS_OUTPUT_PROTOCOL {
>    EFI_GRAPHICS_OUTPUT_PROTOCOL_BLT         Blt;
>    EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE        *Mode;
>  };
> +
> +/*
> + * EFI EDID Discovered Protocol
> + * UEFI Specification Version 2.5 Section 11.9
> + */
> +#define EFI_EDID_DISCOVERED_PROTOCOL_GUID \
> +    { 0x1C0C34F6, 0xD380, 0x41FA, { 0xA0, 0x49, 0x8a, 0xD0, 0x6C, 0x1A, 0x66, 0xAA} }
> +
> +typedef struct _EFI_EDID_DISCOVERED_PROTOCOL {
> +    UINT32   SizeOfEdid;
> +    UINT8   *Edid;
> +} EFI_EDID_DISCOVERED_PROTOCOL;
> +
> +/*
> + * EFI EDID Active Protocol
> + * UEFI Specification Version 2.5 Section 11.9
> + */
> +#define EFI_EDID_ACTIVE_PROTOCOL_GUID \
> +    { 0xBD8C1056, 0x9F36, 0x44EC, { 0x92, 0xA8, 0xA6, 0x33, 0x7F, 0x81, 0x79, 0x86} }
> +
> +typedef struct _EFI_EDID_ACTIVE_PROTOCOL {
> +    UINT32   SizeOfEdid;
> +    UINT8   *Edid;
> +} EFI_EDID_ACTIVE_PROTOCOL;
> +
> +/*
> + * EFI EDID Override Protocol
> + * UEFI Specification Version 2.5 Section 11.9
> + */
> +#define EFI_EDID_OVERRIDE_PROTOCOL_GUID \
> +    { 0x48ECB431, 0xFB72, 0x45C0, { 0xA9, 0x22, 0xF4, 0x58, 0xFE, 0x04, 0x0B, 0xD5} }
> +
> +INTERFACE_DECL(_EFI_EDID_OVERRIDE_PROTOCOL);
> +
> +typedef
> +EFI_STATUS
> +(EFIAPI *EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID) (
> +  IN      struct _EFI_EDID_OVERRIDE_PROTOCOL   *This,
> +  IN      EFI_HANDLE                           *ChildHandle,
> +  OUT     UINT32                               *Attributes,
> +  IN OUT  UINTN                                *EdidSize,
> +  IN OUT  UINT8                               **Edid);
> +
> +typedef struct _EFI_EDID_OVERRIDE_PROTOCOL {
> +    EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID  GetEdid;
> +} EFI_EDID_OVERRIDE_PROTOCOL;
> +
>  #endif

FWIW, EFI_EDID_OVERRIDE_PROTOCOL_GUID is not used by the patch, so I
guess it's introduced for completeness (or because it's used by
further patches).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 10:41:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 10:41:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298694.508931 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgcW-00087a-15; Tue, 05 Apr 2022 10:41:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298694.508931; Tue, 05 Apr 2022 10:41:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgcV-00087T-TL; Tue, 05 Apr 2022 10:41:07 +0000
Received: by outflank-mailman (input) for mailman id 298694;
 Tue, 05 Apr 2022 10:41:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbgcV-00087J-97; Tue, 05 Apr 2022 10:41:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbgcV-0006l1-3P; Tue, 05 Apr 2022 10:41:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbgcU-00083M-NZ; Tue, 05 Apr 2022 10:41:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbgcU-0003Ag-MW; Tue, 05 Apr 2022 10:41:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YQ+yBA8XECxMRxmLAHTifJ4M1fSHiIbJAOaRiHyjoqI=; b=sX87qvyNNJywpqzR9A4r0gsGmM
	iQtJZ2zYWKTwXyhm8ipW7bTi9qaOSUt0YbLExjr+78cOm5fshC4rNDlGL9C2ApGYB9aX/RWiedxht
	g5k3pjfhdhWUUGgAc/hc4IdwaElGAR+v6FYzmZjAcaj2jMy+2c31mOhahVcYl6VrkfpI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169167-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [seabios test] 169167: tolerable FAIL - PUSHED
X-Osstest-Failures:
    seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    seabios=01774004c7f7fdc9c1e8f1715f70d3b913f8d491
X-Osstest-Versions-That:
    seabios=d239552ce7220e448ae81f41515138f7b9e3c4db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 10:41:06 +0000

flight 169167 seabios real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169167/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168315
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168315
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168315
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168315
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168315
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 seabios              01774004c7f7fdc9c1e8f1715f70d3b913f8d491
baseline version:
 seabios              d239552ce7220e448ae81f41515138f7b9e3c4db

Last test of basis   168315  2022-03-02 02:40:13 Z   34 days
Testing same since   169167  2022-04-04 21:41:47 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Volker Rümelin <vr_qemu@t-online.de>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/seabios.git
   d239552..0177400  01774004c7f7fdc9c1e8f1715f70d3b913f8d491 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 10:44:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 10:44:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298702.508942 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgfp-0000IU-H1; Tue, 05 Apr 2022 10:44:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298702.508942; Tue, 05 Apr 2022 10:44:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgfp-0000IA-DZ; Tue, 05 Apr 2022 10:44:33 +0000
Received: by outflank-mailman (input) for mailman id 298702;
 Tue, 05 Apr 2022 10:44:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbgfo-0000I2-Fw
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 10:44:32 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e980f1e-b4cd-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 12:44:30 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e980f1e-b4cd-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649155470;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=N1XgIKLIOjf9VaZo6jeE8C1v+YIb124AEkLjeQX02hU=;
  b=fJ4NtinZCim9Br7NxErPelb+H/6HL1RAT+QbcBPFjoeH9rZEM7dE7hEB
   l0187vL6reLKVjC+V6M5C2VAbwJWIH/whRu+cWg12pMQkKSd00pzZWlO3
   5po1Aj7/0NOewG7w2yzK9tSYGUJrA6ysvRz54mXd4xBqLvftZGtbpXf2c
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68436947
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4xG9gaJH09UiduBJFE+RxpUlxSXFcZb7ZxGr2PjKsXjdYENSgzIDz
 TMXXmCEP/bZNGSnKN4jPY7jpkoFvJTWzNVnSgFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY12YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MhNkIbhSCAYAoH3ivkXb0BzCXF+E7ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glg2psQTKqBD
 yYfQQIxVxHuOAJkA3kwVbI5sNyX1yXhLQQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCsox45QYtRNNwGxDqf16Doui2DVmgqUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZow7eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4iDGJGT9bxgbQ+0RqmBNzEJrVml
 CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdEIumkieRsybppsldrVj
 Kn74145CHh7ZiXCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikEwFCrChO3WJqub+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwkjITWVWvxd22V01e
IronPort-HdrOrdr: A9a23:Bfd/56tf0AS7Vubsb+p/IK/c7skClIMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzE4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 LxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72PeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl5Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbprmGuhHjHkV1RUsZyRtixZJGbEfqFCgL3Z79FupgE286NCr/Zv3Evp9/oGOu15Dq
 r/Q+FVfYp1P7wrhJJGdZc8qPSMex7wqDL3QRSvyAfcZeg600ykke+D3Fxy3pDvRKA1
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68436947"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SBFrKqaVWZ7XKg1GF+gBOYdTSM+UBQAW4FRClbiAZCPycjngaruiN+wa/OH0AaOrdjOMSHaF9+IlxxWZqfXc9u+j4QYpjRN9lgCDh42C/dCEfYAkhr/SJO7GLD6GMbbfbCs1BfenaXDwm7Wdt+uqDX47CENOfggVu2RPBoaBB7FesD+n/66DNjPI9/OHFQfyfefcZWsnIub+mHePCf8dcmLk/+aDd1lmy4yzzR3HU0Bvp6C8Uh/GKOK+i/f0k/7fbAC+t3uEO/lXZ9AMAg7LXuUHmO6vzWDfM+rjWDbGOw7MoOMxIffxfvzym+EKksqd/u41Xt2B4LvPVMeZMvh1PQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IghFmqibVUyZz4YriJJws3MRllA3nyrXGsdyhvxCoxY=;
 b=McauyRi27WyXGEzP+6wVQx9QnJ8daXNsU743eljQXuEnSod7O6vSC6YlLs0k6G4x+ehGMrxBUCulEH14k0XVGd+l4QPlYBpSLxh3/raRa6Oe7iv8DQ5WbzJPSVnnmvFFA+NeLnqlAfrHxfpXVdpKOXxk4HOPUycI8Lxu62gb1t6j77Rgo9uFsVw3LLXWy+bQRFLwwiJxZEl4ry2UGmi9VRUeY6KnVukLgBBpbUfs6gC7TClvX0B3m6g5IQggtEPMaNCuuBnIBQL7NR83U1Ipw2lXfkZibrXxcW/YUkq7/Bp3Xk4Bzj4USHHwT9I3tt0yRad/5Pp8HzKtzOuUCpDhgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IghFmqibVUyZz4YriJJws3MRllA3nyrXGsdyhvxCoxY=;
 b=K7UnzMqIrn96iweT0gfk4BtxhY+zGE2zFgb7MpibH+loBcgR1LSE0U7p2Ytghc1AU4v8XdQGAwrzc09z82vcrQPfreAMR2Kkc/DawZNJoWhMd6Mwtxb3xC+whMh/XuHElYQ6+j5wOmLKAeEQ+S3ckdntgvmsEGOEticUQ2QUF5Y=
Date: Tue, 5 Apr 2022 12:44:18 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 4/8] x86/boot: simplify mode_table
Message-ID: <YkwdgpgWP6t7JwFA@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <b2ddf830-e507-9d1d-2638-cd34d3391596@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b2ddf830-e507-9d1d-2638-cd34d3391596@suse.com>
X-ClientProxiedBy: LO4P123CA0167.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0f6c1410-3122-45f2-2674-08da16f13f2f
X-MS-TrafficTypeDiagnostic: SN6PR03MB4253:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB425371471AB0B7688BC32A838FE49@SN6PR03MB4253.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1RIY2iZ+uyGQL5b+OrioI2Wvia2g4wf4QIpH1sVtLYItI00g7tssULs9dl2rnB1swbCsFa/gJM30Nj6BiLFI8cGOY5XewRwL8sI898oy4ckq1zvNvzzG7U/cU+3EkZOzwNw6PEkEbAnUBZ+RR83+yw1uqQdBWODD73IVW2GzYTbMkeEBw5Q0opmmZzakMhS24TzZ3q0zVHTY1FJ8rYH/syCOuBs//+/L0vD6V0GXtJdDBa7HH8cyohgfZKVQFFllXOve4JgSCnq/dL1REw96+8AqdrUqBiE3yDnqKJ4opwOII8wrWTmdSQxos38dGJLdyRGXvWklu88xhFLM1whD0cZtwD0GgryNzF41PxEIqmf5pCMG9I7F9GZw8NT8qvbzx9YlfV7Kp42PxcLkIzwCBq2R2ZL8cC4sazZxb4eaQfD9WBczqiF+7NnZ9zgVYdl4NoAlkzDv2sZZIVaDBu4+tS3jmEImOb54iY5oHRbbGMVadxtmFgJ+hlEZllVM/X5Rsz+FBsHNvZevVmFuvsAHoqaqcR6+ndAbRI4o2F6BRYxbR+cMCaq6q5zk+kFTxALLCVMS5lsKKkEJcYwbulxrCwaAwOkRbA1zXSiT46WIFJHv9QN1Hn4lCGr7f+KSq/E3SAIaRCzZHV3vDEz75QY+/Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(316002)(82960400001)(6486002)(86362001)(66556008)(66476007)(2906002)(66946007)(54906003)(8676002)(6916009)(4326008)(6506007)(6512007)(6666004)(85182001)(8936002)(26005)(33716001)(5660300002)(186003)(9686003)(508600001)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTRmQmd2Vy96SW1KbmJKUWpJK2ticDdqT0hTN2hGK3ZsTjlsaTY1TEVDNlp5?=
 =?utf-8?B?U3F1eHc2Nnk0LzBwOHBGQ2xxNFZPM2pwWWpNQmpqQ1pONlN4VENLTHYxZEVN?=
 =?utf-8?B?NFdGa08vMFYzdERvWW5EVk9lQWVqT1l1UTJCWFRlTXgxUEphS1BURmpoQm9j?=
 =?utf-8?B?RCt6UGhMMjU3TmU0aVFtbnpqbm1IT3E0alB0MitCemRFV21nTm1vUXBvSi9X?=
 =?utf-8?B?MWtCUUVONW9aTWE5WERnSDJlZUxaZEExODhNamxhNXFWTnlSUUozNEM3cXla?=
 =?utf-8?B?UG1LRjVqaFhxNFFLcGJQZTM2S2p0MlRHbklReEpkM282RFdGNGNjMjlESzRi?=
 =?utf-8?B?eDdkVmlZVngvbGhaMVFzME0weG81NVFNODBERlRwTlZBZ2k1Zzc2ZzFyaHdR?=
 =?utf-8?B?WkppaUZHL3Bnb3ZnWnplVkJyQzVtTFEydUlTendkdmRvdzhoeEhmQlFtLzhR?=
 =?utf-8?B?d3czVHNvNGdkYllmcCtURzNibXE2elFkd2FKOU1nU21sVHFKMVByQTdJYVZP?=
 =?utf-8?B?cjFpNUUxejlLWGVQRExTcDdsKzVxbGVSVEsrZGIrZW9lb1NCVHFMb0FqcmhW?=
 =?utf-8?B?dGlYTkE4SDhHRG1MdFFGWUVaUjV0OVlTckxFb0VlUXJvOFI0K1lqN0ZqNWU0?=
 =?utf-8?B?elVBYVoyREIxWjVSRmtyMXNISzFvY1lBYUZNZ0VsMGpvaXVFR0Y4TkplSDc0?=
 =?utf-8?B?NmI4UWdYZy9aa3M1dUhFdDJvOEFsMXJTYVZiajdjbCtJN1RDS0xkYWlYY1Bn?=
 =?utf-8?B?NG5SUTFXSXZVWGlUUXQ0R3J1NVJhNWl0Yi9RZEdISDRpb1hlZmhQVE9Ja3Mx?=
 =?utf-8?B?UFE1OHA3UkZ4dm1EcGN5Tkg0bXQ4WnRQY3BHSitzVmJwMGVYd1NvOVVoWFlV?=
 =?utf-8?B?NjVwNSs5cE5zSTE4b0l3b3Z6YWZCNnpEV0kwU1lUUnAwc1ZqZFNiSlBVdFRC?=
 =?utf-8?B?YjhkalEySDNoN0F6ZnVlZDR2NStCb2Irb2VNOVM4S3JId0tNYVFSMVA1ZmNT?=
 =?utf-8?B?a0RPSjV0c09CQlEvNXpyQU9CMHZTWGxWMlBUMitxY2ZIZ1hMUzBsSVg4NzJ1?=
 =?utf-8?B?VWc0QUIyV012eTVXZGtWOWNKWWNNdjA5SUZJdUNxWk85ZkNSMjRJOWpYaUhX?=
 =?utf-8?B?WWNLZXFvSDBMOEdnbUlSeCt6QUUvVkN6azFmeUJWRWJCTmtIU2pqcWR6d2hY?=
 =?utf-8?B?UzUyRkpSOHZMdS9jdkdZWVJPcjJpd1FWeEMxdkZ4SWlGTjdVcXdwSzFYekdR?=
 =?utf-8?B?Ry9INUtzYURwNlM0eU5uR1FycnVQeVY5OWJyN3IrdEtSUWY5TktZdW1IdUl3?=
 =?utf-8?B?RDBWbTIvbFhhemtxeGg3K1dSSFRQQyt0eHJ3RGpIQmdiVWYyV3M4ektqUlho?=
 =?utf-8?B?Uzl6Q3lJOHd2WnhIRVR4L3lUL0QxMlF0MzZQaW9hZlYvVDc5cDdBdWNyMjEz?=
 =?utf-8?B?ZXR0b0JQU2pQMUdYK3JtY1pva1pUVXFUcUFVMnZ5MlhxOGY1c3JXL296RElq?=
 =?utf-8?B?SjR2VGhKZktETVBtN3E3UVg4bWI3aWYwTjBONG4wVnNodTAvbEZiSXhwOStZ?=
 =?utf-8?B?Qk9teTFmcVMyOENwVm9jRDB6dkFKT28xTjFzRThlM2JlN3RMd212dmJEUndv?=
 =?utf-8?B?bkpDMkJlc1RpYVNjbElTeG5IY0dId3ZWbTl2am5uVVltQ2FGaDViaTIyTStx?=
 =?utf-8?B?eWFtZTllREpjVnMrOTFvaE9jLzM3WElZb1N5YkRGTk53S29BZEF4WWxQZW1I?=
 =?utf-8?B?VXpiWnBMRUZXRnkwS0dkbmZneEdudFJkTGhGaWRrRXZNMXlTS3hCa2NkSGc4?=
 =?utf-8?B?QVFrOWF6SmdETWFuMENMVW8ySTJXWlZlZytFSmVlWFZFWmpmSis2RGZmMkxU?=
 =?utf-8?B?N1NCYkU4QjFqNU50cDZuL0ZQVWFKTlo5QTE5QXVHRzdvakpwQzh6c3hoMzl3?=
 =?utf-8?B?dUdMK2gyemQzNjlONGZqRVBLNzY1d091Q052ZDhMZUhtdEpjUDVpcjlORW0w?=
 =?utf-8?B?b2dFQTR4bmxteVBORTA5Q0dhT3ZCdnhwOFRxWWlnUWxHbmtOWkN2dHpTa0Fl?=
 =?utf-8?B?aUNTQ01qNjlGeWdrTnA3YzJrbFJkRVpzalBDM0xuNkYrVUNQWUV3VnI5MjdW?=
 =?utf-8?B?cXJOM3cyT3VkVjNoRkdIeExyRXBPMlFlY0xFN09tT3l6Zk5XaFphN3czTmtT?=
 =?utf-8?B?aGZ4MHRVS2hKVWNka2hlOFNCdENEcUYzYXNQWmNtc0s4aTd2Y1NZd3hQVGUr?=
 =?utf-8?B?VktwL2NsR0M3T29lK05UUHJyUlFYeWxiSXJLUmZSVnFjZzJGVm03eXVOdjdy?=
 =?utf-8?B?a3BQc042K05iOFZFWlRFMGxoLzIrbDVVQTcrK3JjdnNZNWhJQ1k5TkNVdStq?=
 =?utf-8?Q?qmLMbV7dc7UarV1U=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f6c1410-3122-45f2-2674-08da16f13f2f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 10:44:23.0423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zX3d9YSj7v3AfXUj2HMY3AEjZLrLtJoss4ZIkqxWAMirfn/8HRJDDBC8fCHkZEMBd4n/NjeixeZbsz7lZ3H/EA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4253
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:48:51AM +0200, Jan Beulich wrote:
> There's no point in writing 80x25 text mode information via multiple
> insns all storing immediate values. The data can simply be included
> first thing in the vga_modes table, allowing the already present
> REP MOVSB to take care of everything in one go.
> 
> While touching this also correct a related but stale comment.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 10:56:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 10:56:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298708.508953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgqh-0001oI-JL; Tue, 05 Apr 2022 10:55:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298708.508953; Tue, 05 Apr 2022 10:55:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgqh-0001oB-GE; Tue, 05 Apr 2022 10:55:47 +0000
Received: by outflank-mailman (input) for mailman id 298708;
 Tue, 05 Apr 2022 10:55:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbgqg-0001o5-7e
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 10:55:46 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eff13833-b4ce-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 12:55:44 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eff13833-b4ce-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649156145;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=osuE/2UWk7uy4b4MZFYdCdsPhluXC8Hl2yKsgwWPmu4=;
  b=XvLpLiBDs96KixxOYqE8MBkrUwjEU/0wuma48pUk9TVkMs4SV80YgIZe
   Nug1m9p8enTu3yHsKqC7FxkX0cXcxiQQpcvxpQrk5a8RCkZg6EvALKuSj
   JhhH7e8mXEJ33MY3I6ux1ImWTST0AhW+4c/6f3Y4gcW0oIR86BJNU5LhA
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67927762
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:QkVS+qLmyY2o5KrIFE+RxpUlxSXFcZb7ZxGr2PjKsXjdYENS0TYHn
 TRODGvTOvnfYGujfI1/bIzj8BsFu5SGzNBmQVBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY12YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PJ8iKebTzkYB4fzt+cfcSJmMxxaM6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glv15oRQqiED
 yYfQR03NgTYJERdBnwWDJxngOb2oEjWaBQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCsmS8hYPFWLdwDwj6iyaj22Di5O0wKQWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZow7eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4iDGJGT9bxgbQ+0RqmBNzEJrVml
 CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdEIumkieRsybppsldrVj
 Kn74145CHh7ZiXCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikEwFCrChO3WJqub+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwkTITWVWvxd22V01e
IronPort-HdrOrdr: A9a23:GK/+8KtzxV/KfBlFDrmd8TU+7skClIMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzE4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 LxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72PeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl5Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbprmGuhHjHkV1RUsZyRtixZJGbEfqFCgL3Z79FupgE286NCr/Zv3Evp9/oGOu15Dq
 r/Q+FVfYp1P7wrhJJGdZc8qPSMex7wqDL3QRSvyAfcZeg600ykke+D3Fxy3pDvRKA1
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="67927762"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fC+mANj41rSIRUBbstUWvk00pS5Af0194yCJ5JFOlAByuPErmiEo73lIiKJp6RjVmz5Ho5ug+lvg2EjPMQ4p6szdC+/cH6UJmNIV01Bji0A1eHoupC5xF1hnSLohPbiE/dzD4y1fF69MDtQzfYeH9whNZul1iDrMc6cs6ivm6NrEMrEZboxokKoQZJ58eoj/SWlg8Q+iOJzQP8UY0Q0V+7GtQsoPOMoQn/AMBl+D6ak+m1L/bCC9zKah9BBCI83J2ObLthtq86ZYFGt/xS2dwjnG7U8Uz1in3Jowau4J4sipxBeC2Bc3F5qGj4DLbiCBOWprrhtbrXGLn0zop9szEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qpcMlgXt9uETUbTXiiy8yCcUIx2/8PJOAvU3PGaRG0w=;
 b=ApbqOqxFG0nlDFlu3CLQSiJIH6Ndi9ihzn3aIQ6OF9ZUq6LbYx0y6eYORqtCCynht50kQtVUy1Sey6mDNxX9HybfuV7JaWJwO+7AVLOdFHnRJYjqN21PG/dDp4OW7Z+04qFSdrTzUosrvn7C09PNpB1PkDE7IfhwudOZgdnhxE9bA0NomXPTCw2p8GjOnSvI/xkUO3WwGm2zekcsCPdLUgs8RGmVYaArtmexiqHtJR6829wUtmrjEZ6k39qX+42i5sCcr7uVJS9WK65m6fVnd3oT3CxAAvBIUtyph+cMRxzVxkF44JUeYzj56FHovLaLDkN1EECdT1POwUh3GJKt7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qpcMlgXt9uETUbTXiiy8yCcUIx2/8PJOAvU3PGaRG0w=;
 b=FkcH9dJ1o0uxAK9UOwDStHcuy0nWmhpjc5B09JnlxftfnlQ6Jw0A4B427GUoFKAKJUNF+Azx1oF7HOdnjoQiJIQkGI8REnBf4ONuJgU8NB5dP+UAwGNtQ9Q137d+ANU7i0DYCNJFqAbHu+yOY01plcXQ8uUsA4kjdf5nfsJUvUw=
Date: Tue, 5 Apr 2022 12:55:35 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 5/8] x86/boot: fold branches in video handling code
Message-ID: <YkwgJ4lsXPhfWZG5@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <5e4ee27b-4904-b2bc-1650-df148b47387f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5e4ee27b-4904-b2bc-1650-df148b47387f@suse.com>
X-ClientProxiedBy: LO4P265CA0066.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2af::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f4d82a4-6e6f-417d-9e43-08da16f2d286
X-MS-TrafficTypeDiagnostic: MN2PR03MB5149:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB5149234671D06869643FFA258FE49@MN2PR03MB5149.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Nkjx8cpRg7L+qKnaQloE/uMOv28ovre5KLOjk5P4kdyV+Iv/KU0aBPMUXuOWyJcNCYUYoadotLIrbpU0uTrlzk5tsUs30CYvfXl7T1NIDhOYOnjsB0fGnwhvA14zK6jbwhK3QSe15aYtCwEoJaf29vIGoJvaHnVvQ1l04usldizQVpwJziCR3EaBLXJ0lMae9VExeJS+hzioj1IwGZmRqoWgV0KXxx2ZCs22isu/myoAHlky1jif6UhHubZqPCR5GHYp4q0RH9ki5elvTM3q+Orml2UApga92VU2aj14+WDJEJWhRl11YpC3A9Xgkn5QAVMmnZVu24IQ1G507eIzfv4gKZvZcm9HtMbMdjzfzoSY9W7F0V5May+z1072eRgZyHlxWPS4JOHSwFVp2Eg9ZrKx7Vk1HANaYnXzovS46TJ62x2B5zVIyGqP28cv4BUoB3xw1X8UYFXnQkBGRRBL9XYiFvH1RwaYyYxEK8WR1PvwMwHBpsI8X6YNl9zBDddj755R51yrTfaUbhdM+Om5UufILF1K2igBcaiLJHgxpUEwloCQAx0zbjumbYwYUWmpY+w6FbT/68ixv3tu1DDgLAHuKnGPqDK21AIwE7Axkn6bk12X/0i6JTY8g0HWkSnSs0qbv8+HxrC6hgzkf8NwOg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(83380400001)(8936002)(85182001)(316002)(54906003)(86362001)(33716001)(6506007)(82960400001)(8676002)(4744005)(66556008)(66946007)(66476007)(6916009)(4326008)(38100700002)(2906002)(6486002)(508600001)(186003)(9686003)(6512007)(26005)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW8yejRlaGx5VThlemJuaGQ1WllVM3kzZ2U1V0tiWDFmL3ZMSzc4bHVEeXph?=
 =?utf-8?B?ak9ITzR5K2lSSTNHd0k3QXFOR3hjdlFwcW5XMTJHMXNJRXBwOWxQZVJIQkZx?=
 =?utf-8?B?L0lzblJGZmZwUG91L1QrUERXekI4djl5S1RqT25ZdmY2a0crcEt0NzNQTlBH?=
 =?utf-8?B?aDhGOGtEWTZrdlpiZGQrM1pBeTVxRC9idjV5b3hVL1FjWC9LZVhqVlJHalU0?=
 =?utf-8?B?eUErRlNlNFk5c0FGRFJmRUhxQ2s4R3pNRHBCdkFVUlpCNGhEQW15cmxDemFB?=
 =?utf-8?B?Wm5sVE5OYmdWT2dPUmlMOE9qMUZwemVGRHYyZkNjTzEvdTM2SjNtVE1ocWQ1?=
 =?utf-8?B?aHVHaTUrYnhWQmRRZS8wTTJMa3M0VW1LeXVybTZLdlR0OGVyZzR6RFFyV29W?=
 =?utf-8?B?SG83YjVzSzFKNHdBMkVGSC9Jd0NLZ0dESGlIWFZNeWJPbEVNME1qUEtsSDlJ?=
 =?utf-8?B?Y1RjQUlYYUMvNW9VU2lNN0tTTW5mWGsycnpBL3BrQXdHWEFGUzE5Q1ZhUnQx?=
 =?utf-8?B?a0hZcDVvUDVPeG5MUzFMbUxZWDRvSmZQWXA5djJwQmRLV0J5eWU2YTJ5TmlR?=
 =?utf-8?B?c3YyMzZ0ZHF2Ymg5eEsyY1Y2dXFoSFZRWUI1NHk2d2VoYm9pSVBlaWlxamJU?=
 =?utf-8?B?VFlUSDVSZ2pBUThXN1NocnVYeVVldlkvK3Z5NDRyRElVcXFaTnNFb0V5QnJE?=
 =?utf-8?B?aHo5cllRVnNJTmYvdkw3cWR6NHdGTWhXWElqazdVOVpWOEphSDhvUUlpWHRW?=
 =?utf-8?B?RnpFR201N1hCQ0gwNXJRdVMwZU1YMVdyNE5uMWVqUnJGbmdMd2RaR1hSRHlJ?=
 =?utf-8?B?ZUVJZUlvT0dPdTkxWVI5RDhOdjl1KzNxb085Y2FIUWtyUm5hVEFaNGxsb0N0?=
 =?utf-8?B?OEd5TGp6WGozeVk4Sy9SZDcvNzEvZG1yeXFEc3MrZ2gyOVRuVFpXVmR3QkNi?=
 =?utf-8?B?TXlacXFzeGhKeFRUQVdyS0hCTnBZQVh5aFVWNDFxeThIZnUyYnJYT0EyQjIv?=
 =?utf-8?B?UEc2azcvQ1hRUU90L0d0K25KMzNjQlpsdTlWY2Q3WVgyTDY4OENpYnhPWktp?=
 =?utf-8?B?VFNPYjBKS0tIeVpVK1FxVEMwRGloQXFVZ2tOZVJ0UDN6MkVCdzA3RWxKNE0y?=
 =?utf-8?B?d1ZRVUkwSThVWFI3YTdQcWVRc0l5bGlCeHlKNTdpVEFVdU4yYkdScXBwOTBB?=
 =?utf-8?B?QXhUZXBpakpTbVllODZKSFhwdTBLUnphVnhIRXVmbS8yei9EYTFYa2FDVGEy?=
 =?utf-8?B?Qk5aUEh4WWdtMmRYL1l6NTVHdUU5QXZ2VFp1YWpRcWRXSzVLUTVLdDhjOHlw?=
 =?utf-8?B?YmdjSElHbktRdERCL0lBcGFQMk5ESmpSbCtLeDdwRituUUVvd0pkWU1ZWVBP?=
 =?utf-8?B?RnliUElYWDg5NjY2cjM5OXA0b0ZNZjRhZHRpTGVySDhuWnAyaEdKTjhvRnRB?=
 =?utf-8?B?RXQwemNlNlpjVU0rOHlaNVp4bUFFS21Wb0R1dGdZS1VtTUtNLzVkUGYvUzc1?=
 =?utf-8?B?UjNjM2xqaXZmVWQrNDc5V0ZDRVg2U05kTVNPWjlJMFFDU2J2U1NEcGErd1Vn?=
 =?utf-8?B?R1JoSEZkUGlmcW4yT1BpV1JYMmxDN1Y4NzVFZDdGSnJyM1oyMElaeGZITFVY?=
 =?utf-8?B?RldFRGExT3NINTluYzlkb1hIV21MR243TVZSNktmanptdkNMOVBCMyt0dDVG?=
 =?utf-8?B?UWpwMEV1bzdSYldUN213WHNVU1pnR3FIZXhnR3l0M0g4LzRWZDR1M1hJZ0hG?=
 =?utf-8?B?UEVPMElzSmtFN0Fsb0ZaMmVkK1N2V0ovWXVDcXU5cFMybU9JaHRZdFRIK1dZ?=
 =?utf-8?B?VThDMUNYMjZmSWsxL1gzaGgwSjY3N3UrL0JoUDExa0xhVkhsbUt6Q2JacGZa?=
 =?utf-8?B?NTZlK0I0aDgyU0dmQ3dpdzZkM2dvU3h6SXlNSzVVUkJhS1Jodnl2MWJxVjY0?=
 =?utf-8?B?bHd5K1ZTZkJBaSthajFXZE1FSFFZWWhYa1I3Z1pMRUtjWjFIdVNIbmZWNVI0?=
 =?utf-8?B?Zi93L0pYMktUbTU3bzBDOVFWbXRZYk12ZjdTWCtvV3RlZnFTOUYybFlnZGlD?=
 =?utf-8?B?c2NEdDNQcFpndHNPNkQrenNvQ3lQRVVVWnl4WE1neU5zL1NhZ1NERHNSRS9j?=
 =?utf-8?B?dWVGL25hM0FPcFZZSHE0eHd5OWtNMnUwQ2l4c2MweVBJVVlYaFVUYURBZVdW?=
 =?utf-8?B?b1RSKzA0THNTVUd5QlFVWUU0ZDhXK1hnZGdFdjZHVXJkdVlzbWY0eUNYKzN1?=
 =?utf-8?B?L01NbVd1UkF3a0FhM29LblNac2ZsWld0dlExbUxkdjZwUmZUUStlT0ZZaXAw?=
 =?utf-8?B?dC9WOHV4Q29ITFRaTGVZV09ad3FKUUVTamVZc2pIMHlLbXNtMjc1cWhOdjhp?=
 =?utf-8?Q?fA9bWuy7K5iYHSLc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f4d82a4-6e6f-417d-9e43-08da16f2d286
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 10:55:39.7062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qq0bjamSJPzxp+kOBgZVsa6q8AzaYF413y84PHVnniH50nomBn1XLhkFPWjYW6j0bOp1ZwEI3Y8GR4EHAA6aHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5149
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:49:24AM +0200, Jan Beulich wrote:
> Using Jcc to branch around a JMP is necessary only in pre-386 code,
> where Jcc is limited to disp8. Use the opposite Jcc directly in two
> places. Since it's adjacent, also convert an ORB to TESTB.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 10:58:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 10:58:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298713.508964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgsp-0002UP-3S; Tue, 05 Apr 2022 10:57:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298713.508964; Tue, 05 Apr 2022 10:57:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgsp-0002UI-0P; Tue, 05 Apr 2022 10:57:59 +0000
Received: by outflank-mailman (input) for mailman id 298713;
 Tue, 05 Apr 2022 10:57:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbgsn-0002UC-Te
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 10:57:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3fc9c31f-b4cf-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 12:57:56 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-UZCcHXwSN6uM1k2WkuitdQ-1; Tue, 05 Apr 2022 12:57:55 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0401MB2380.eurprd04.prod.outlook.com (2603:10a6:3:25::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 10:57:53 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 10:57:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fc9c31f-b4cf-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649156276;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YvswwWuHyXJrpv3spz5jrC3uC1N7BqAlMc3IJ6AXjKs=;
	b=WuFEWFSKS/eH+f1v7NNFRIJPhubpPcteQl4VxRXwdR1zo0WN9M7Tf7e2SIsI/QkCrt1jzF
	02p/0/pDS4jNz+ER7h8ADUI/jRZMdThtZYipguAoOU1palvDkumEdtBJ11ntI4gjNwY7Jk
	Wu+QRj0juoxU+iLKL2tqE4pTOpJ7Jag=
X-MC-Unique: UZCcHXwSN6uM1k2WkuitdQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GO7+jCoIekpXkpo3rKcZPsFadz1k0w/0yVObTNcwNWrEslkKzk2Tjc/t5fv4EpuTPYz6//QaRE33qH/ekag1gmjMnmrhcy3I5M5xzre9nDWqlcmrUtn3X89Ah/UK+uH9WCd++gCBqeK6PhhbUwbMKEtCNFzDzNqRp/Zn3F6CDTtpf8V0NJwyWXFACyWrnSKB/9YWycNijIsHW1xi/SgIrhhERLk+2wCqpNBNpymWLA93IBeTnrzmnjhn9lUlZb+GEQZ21vkrPl8PZ68fdjL/NDw13XRSMgzc0nEttSRyQxi3Xj9S/tQ07lajpdYl2/C9YWTVhEZEQOumoRum7HkgJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S7Oy1Y8rMgs2geC9iHlAb2+fU6R4bw72Jn623Q1web4=;
 b=CtoYUcFs+w/+xsqYq4Wim9ufnLGFWtxgZULZmF3yv1jX4ZwpU4CnKV0WGXLLt8yMqWJyXXpcEjJ8NZOR271RPbi1yKMKv5Mpz3T7wvxm9jPnh6MLDQJGiwzMGW7THUOmPhnwgpsPYu01i46uNKJ/MkEtenW1JABgiFlazoWJNnflawieoDVanMqAfqsZ4niy41HNA4jCJnFtg0X0fkHpyJPEeBqoTwF5kr2B/e6zf/2e7fJsqmLofeO9ODXbI+s/9j/oRfHH3iX4akyO+yXNsuO49Lelff6dhbdS5QlospImOhSXEQFlBfodTMeVHkYi0B8o8niI7aDWYaaVUL9VuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <26b988cb-8b20-f78d-548e-1b1f16d10a63@suse.com>
Date: Tue, 5 Apr 2022 12:57:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 2/8] x86/boot: obtain video info from boot loader
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <6fc25224-7985-73a6-8877-bc209f64bf8c@suse.com>
 <YkwNbi3lTNJbWVNC@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YkwNbi3lTNJbWVNC@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0052.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09e8af9b-4cb9-4897-4281-08da16f32227
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2380:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB2380A7EE744D4CF1AA3F453AB3E49@HE1PR0401MB2380.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KV2iqP/cl3oNsO89Ehvb/8WAXxQQHYftTDIrBpk5sW6fYWRbZyV1HGv+6X0/gVmC5u1wguNqvQ1x7XhcimLbsNtxSOEK0hhU+CEKK2d3BAS4zt2TAvzwTVC33kmlPHgNyaP7MBfkNg8krHkAHWufVEWqZd9ul0Nw2NPLkh5Q/dmLbqtWMIaV/P7dnHjXHS/QKZcvwfKuOsphoUTft3gyHK2guNzgvi49P4xxiDdaWi2bji2aVxGyqSTLjyb76PnO70TPgrNhHzraNyQPlDbmbF2uF4H+bGbDnHft9C9G7fsWQ+6qQI71aX5NwaPl9mZgdsx70Mz7qauDKS1hFDnTi6YkaY8OTomNDoWDukshqZ7/tMGHuFo6r0nn/jE+5Czr9vlUtoU9iVDjMdkGGgad0B6jKKA5ANRb9yBKwLbdcEyeuY2N5VJSGbLxD+pOA0AhnYLc2vRhGosTyGQ0YacwN7degfI8hdkRON2tZRgkhCNzOr6t2m0YnATRAHf+pvyCcBOkecZbpWt7sSYgmZBY4OLVJ+j2NuVzMEdvsfGDwU/bV5pPpwUnpJnxcPZnUOKyHxgtnJhKAM1WBrut9pa14vH5hiPW+AblKHYXJqPd6Dpr5k9jFrmcvVUSH5rFiDnhhwyJvAfd9a37L1UNfaiJGlwkNrYbC6A6tAymOjl35qDOG060eoc5c5qmJITQlRXXxs+3tolXiyQV7XybeiTen2JzJQXSYptBE5jowlAbVP8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(508600001)(31696002)(6486002)(31686004)(2616005)(6506007)(5660300002)(86362001)(36756003)(186003)(8676002)(6512007)(6916009)(54906003)(26005)(38100700002)(83380400001)(2906002)(316002)(66476007)(66946007)(66556008)(4326008)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IkEIZWqWStjyKqyZQ3vy37z9+1mXYXcLSCv1XrLabgtyvCcVEJHKGjxKMTp+?=
 =?us-ascii?Q?noN5FbPqPI795oO9WmUiKXRrwQWBek3uJ+gP2ffGdjunTxfNq1tha5iOLPHR?=
 =?us-ascii?Q?ofBIIbThwqad+nfIxv24PPA/OU3AuVr+o0/Hzo4+1x4QnHhxb0NA/CVBMoRX?=
 =?us-ascii?Q?uCuQHWcZPTd6XOt+szMOA//rWYRzsBLZtLG6eFy4hljhbFd+GWgC/iuyfueZ?=
 =?us-ascii?Q?gk2FKiXPT1Quci0ZHW26QWr12fIKUdPBUIcT3Mk5+YlPy14aumsM4lDcjUFK?=
 =?us-ascii?Q?94KBj35qWR9zexZuUfXTnPlh9y+ZC0gqp6LeGLsjCTNGoOcLvOT1FzTWsUCv?=
 =?us-ascii?Q?tDdEkGT1Foo6qUk1oszmYdkEGsc+VXq9r7eJqcXOSjwbmz9vGnFdzf/lwQZm?=
 =?us-ascii?Q?q4cPrai+PzUXOih7+PX/Z527Gozz0nt3FTx4O3GGiIsmfSaMnJicSIDzs61W?=
 =?us-ascii?Q?64QVKaayHG8qyBlm+84Y9bjYZgejRbKfg+EBoLYNK6XlK7BqMs2xJeGsrK7A?=
 =?us-ascii?Q?XBBGk3pJ4QRoiwd2Xbf7TxT5hcEHf24DUcHgn9qhX6LmLr0TXmbouPeZO/fz?=
 =?us-ascii?Q?zERuLt17U7DG1KyX47oh8fOoBGnb9CAXBtu820hrTaHv8D2kq/nz7yPW6N+g?=
 =?us-ascii?Q?WierOsFtwPaAXWGWnK3gkihjT4B8hGQS/pkYGi5CRUSowd1el6Ze9W4dJSBS?=
 =?us-ascii?Q?6f1BwmW/gNh8627DiYiARNcazJ+XyVGZDJj8SZJKk0MAGiUBpQdHU16MiKxD?=
 =?us-ascii?Q?BaFZ7hnRDEzESkaU3SdzyVvvx9OLzOqSLlprcimxCJc80xsJx1Ira5rz3xV0?=
 =?us-ascii?Q?mUDFH8gTx+uFjJ3cNHHm+GrYNbUKN+CEosVMIZ0sCDASDStWhyqMdwtrA1L5?=
 =?us-ascii?Q?eqIiPCx05Uoqczaocsl1DDb3V4O9pGPx43SGV6d2RrAcxr9ohZbWI7+DPzt3?=
 =?us-ascii?Q?mQnVHFr1wJLeNkVK+jp0jso5/b9w4yWaWfHbEuBKRiaIFzytBawS3GiD/VFq?=
 =?us-ascii?Q?xoRv65Tb/SitPbGEWyVzht0ZCTwf08As6e7r1lOpqaLEc+6RL5FLK8m3z3yy?=
 =?us-ascii?Q?EFFRuF6zO57WXs1uULwUuJK2G7wp/wHfv1WxlDN7FtEU//mivjEhljBtC1DC?=
 =?us-ascii?Q?mHlYFVju3oIHxUp8KQEqkQHh1jQQts9zUArWUFsLCaxUcuojJVEx3ZcE6S5t?=
 =?us-ascii?Q?5+hvKt+0Yc9di3QpMcMEhscmvUoNA2hrr5xXES3XcsSCOGvNpDI+2T2wxhHI?=
 =?us-ascii?Q?OlGOozWWtu1KspINV/2lGpbvCR3rO4rADrH2Nu6p07dTAjImqqMbpjqVXXCn?=
 =?us-ascii?Q?X1FDWDucgsusrhpoGRcECTI3CuX0IwkOShKtsFSCkJk0gCBCCMeLCtvJlcHY?=
 =?us-ascii?Q?824RQKapfJvuIiKNWqjgnj/SToRUT66/W5JUcUTnF1VZ7+sHvZNVxU14HQyI?=
 =?us-ascii?Q?G9Od54xWk+CnhEUqrVIucwv2I+2wWb+lRBthesqeSQkP/7cju1QeEzoNrfMX?=
 =?us-ascii?Q?TEWFMRNxbOjLCLHmkuvEgOAh/gWXHe/QBq4jrT9DJ748q2NvWzeleRIGPNt8?=
 =?us-ascii?Q?U29hSLQXVe1p6QmXRgKky5aF7TTJLOUXaKMTuH0JvZQsMgdV8XrN8bRV4e7U?=
 =?us-ascii?Q?zTPTKGJo7m6LkWHLdxk8Iu2liSIn18MhzLCD9TEeeq1G57mLlUluAQp0Ttoi?=
 =?us-ascii?Q?/UKLK+ab1ZmJz89PQ09NSXdNhEBd/XCnsddxGn+u5svig1hRrysfrXumF0Jj?=
 =?us-ascii?Q?3klfx4W2yw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09e8af9b-4cb9-4897-4281-08da16f32227
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 10:57:53.3458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i0+mtvhCQqO4h+MF9lX36w+cyHcqyXsEDvYtTOH7RNSpa4qzosyuavZx6osVlhyCg/XsmkqPNxXYAMHQsTiBvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2380

On 05.04.2022 11:35, Roger Pau Monn=C3=A9 wrote:
> On Thu, Mar 31, 2022 at 11:45:02AM +0200, Jan Beulich wrote:
>> --- a/xen/arch/x86/boot/head.S
>> +++ b/xen/arch/x86/boot/head.S
>> @@ -562,12 +562,18 @@ trampoline_setup:
>>          mov     %esi, sym_esi(xen_phys_start)
>>          mov     %esi, sym_esi(trampoline_xen_phys_start)
>> =20
>> -        mov     sym_esi(trampoline_phys), %ecx
>> -
>>          /* Get bottom-most low-memory stack address. */
>> +        mov     sym_esi(trampoline_phys), %ecx
>>          add     $TRAMPOLINE_SPACE,%ecx
>=20
> Just for my understanding, since you are already touching the
> instruction, why not switch it to a lea like you do below?
>=20
> Is that because you would also like to take the opportunity to fold
> the add into the lea and that would be too much of a change?

No. This MOV cannot be converted, as its source operand isn't an
immediate (or register); such a conversion would also be undesirable,
for increasing insn size. See the later patch doing conversions in
the other direction, to reduce code size. Somewhat similarly ...

>> +#ifdef CONFIG_VIDEO
>> +        lea     sym_esi(boot_vid_info), %edx

... this LEA also cannot be expressed by a single MOV.

>> @@ -32,6 +33,39 @@ asm (
>>  #include "../../../include/xen/kconfig.h"
>>  #include <public/arch-x86/hvm/start_info.h>
>> =20
>> +#ifdef CONFIG_VIDEO
>> +# include "video.h"
>> +
>> +/* VESA control information */
>> +struct __packed vesa_ctrl_info {
>> +    uint8_t signature[4];
>> +    uint16_t version;
>> +    uint32_t oem_name;
>> +    uint32_t capabilities;
>> +    uint32_t mode_list;
>> +    uint16_t mem_size;
>> +    /* We don't use any further fields. */
>> +};
>> +
>> +/* VESA 2.0 mode information */
>> +struct vesa_mode_info {
>=20
> Should we add __packed here just in case further added fields are no
> longer naturally aligned? (AFAICT all field right now are aligned to
> it's size so there's no need for it).

I think we should avoid __packed whenever possible.

>> +    uint16_t attrib;
>> +    uint8_t window[14]; /* We don't use the individual fields. */
>> +    uint16_t bytes_per_line;
>> +    uint16_t width;
>> +    uint16_t height;
>> +    uint8_t cell_width;
>> +    uint8_t cell_height;
>> +    uint8_t nr_planes;
>> +    uint8_t depth;
>> +    uint8_t memory[5]; /* We don't use the individual fields. */
>> +    struct boot_video_colors colors;
>> +    uint8_t direct_color;
>> +    uint32_t base;
>> +    /* We don't use any further fields. */
>> +};
>=20
> Would it make sense to put those struct definitions in boot/video.h
> like you do for boot_video_info?

Personally I prefer to expose things in headers only when multiple
other files want to consume what is being declared/defined.

>> @@ -254,17 +291,64 @@ static multiboot_info_t *mbi2_reloc(u32
>>              ++mod_idx;
>>              break;
>> =20
>> +#ifdef CONFIG_VIDEO
>> +        case MULTIBOOT2_TAG_TYPE_VBE:
>> +            if ( video_out )
>> +            {
>> +                const struct vesa_ctrl_info *ci;
>> +                const struct vesa_mode_info *mi;
>> +
>> +                video =3D _p(video_out);
>> +                ci =3D (void *)get_mb2_data(tag, vbe, vbe_control_info)=
;
>> +                mi =3D (void *)get_mb2_data(tag, vbe, vbe_mode_info);
>> +
>> +                if ( ci->version >=3D 0x0200 && (mi->attrib & 0x9b) =3D=
=3D 0x9b )
>> +                {
>> +                    video->capabilities =3D ci->capabilities;
>> +                    video->lfb_linelength =3D mi->bytes_per_line;
>> +                    video->lfb_width =3D mi->width;
>> +                    video->lfb_height =3D mi->height;
>> +                    video->lfb_depth =3D mi->depth;
>> +                    video->lfb_base =3D mi->base;
>> +                    video->lfb_size =3D ci->mem_size;
>> +                    video->colors =3D mi->colors;
>> +                    video->vesa_attrib =3D mi->attrib;
>> +                }
>> +
>> +                video->vesapm.seg =3D get_mb2_data(tag, vbe, vbe_interf=
ace_seg);
>> +                video->vesapm.off =3D get_mb2_data(tag, vbe, vbe_interf=
ace_off);
>> +            }
>> +            break;
>> +
>> +        case MULTIBOOT2_TAG_TYPE_FRAMEBUFFER:
>> +            if ( (get_mb2_data(tag, framebuffer, framebuffer_type) !=3D
>> +                  MULTIBOOT2_FRAMEBUFFER_TYPE_RGB) )
>> +            {
>> +                video_out =3D 0;
>> +                video =3D NULL;
>> +            }
>=20
> I'm confused, don't you need to store the information in the
> framebuffer tag for use after relocation?

If there was a consumer - yes. Right now this tag is used only to
invalidate the information taken from the other tag (or to suppress
taking values from there if that other tag came later) in case the
framebuffer type doesn't match what we support.

>> +            break;
>> +#endif /* CONFIG_VIDEO */
>> +
>>          case MULTIBOOT2_TAG_TYPE_END:
>> -            return mbi_out;
>> +            goto end; /* Cannot "break;" here. */
>> =20
>>          default:
>>              break;
>>          }
>> =20
>> + end:
>> +
>> +#ifdef CONFIG_VIDEO
>> +    if ( video )
>> +        video->orig_video_isVGA =3D 0x23;
>=20
> I see we use this elsewhere, what's the meaning of this (magic) 0x23?

This is a value Linux uses (also as a plain number without any #define
iirc; at least it was that way when we first inherited that value).
Short of knowing where they took it from or what meaning they associate
with the value it would be hard for us to give this a (meaningful) name
and hence use a #define. And hence it's equally hard to properly answer
your question.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 10:58:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 10:58:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298716.508974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgtU-00031a-D7; Tue, 05 Apr 2022 10:58:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298716.508974; Tue, 05 Apr 2022 10:58:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgtU-00031T-9s; Tue, 05 Apr 2022 10:58:40 +0000
Received: by outflank-mailman (input) for mailman id 298716;
 Tue, 05 Apr 2022 10:58:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0KMS=UP=citrix.com=prvs=0874ecad3=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nbgtS-0002UC-Qc
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 10:58:38 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 577f734b-b4cf-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 12:58:37 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 577f734b-b4cf-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649156317;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=nQXkbqVvO9aFaBPbtP4E4+jIi/uqOgMO+4KOZd8P4E0=;
  b=DPEithr+g44ZQhtt7XNAklMlLcCcLZuOcm+7BLaGU7du7HXekzxqqrlS
   fDeJ9tMiC/ytZat2U0YV5OoEHnWWxMd64fFgNxc6FRwFsxXVqOHZg/RUj
   G0++7q30kojLyFGTlQC69EYVpkxg2mUB1RrTOfrfKsV2s9KF/wGfu8Vbt
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68031148
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VCxZq6IWSgKeRVHKFE+Rw5UlxSXFcZb7ZxGr2PjKsXjdYENS1mBVy
 zNJC2CHPvjcM2ekfN9waYzl9kpVsMfUm4A2SQtlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY12YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MsVtLDhWzoFAq3VxtoPciVjDhtdE4QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6aGP
 JNANWoHgBLoIA9vZHsxWK8HmvqvtGbndyF2h16fnP9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcJ0WPK218LhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJOS+wWuROw5pbU+linFEk4dSN7S/IP4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud1IWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtfABbvzt68owGOlor+p5
 iVsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8idR8zappZJWS1P
 Cc/XD+9ArcJYRNGioctPeqM5zkCl/C8RbwJqNiKBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WlO3ONrNFKcQ5RRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WdQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:D1P8CKMEdIH9gMBcTqKjsMiBIKoaSvp037BL7SBMoHluGfBw+P
 rCoB1273XJYVUqOU3I5+ruBEDoexq1yXcf2+Us1NmZMjXbhA==
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68031148"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P4cG2PbO6jf0Gq/XEA524mPFFhIkQBUcAoZ4+KVvTIGe7R1bjtces2tLvAbrUA2gua8kTuOCj6yuqeIpZn/lKyox7rpVwKLtSl03AjuiyEPovxBbc0su1C1zW56CscRuAX/Cq95sl45nFWP31+Q3H708YHqWumcb1kPPK/2ifqZC2GGg2A8BangJxzc8RCd/fUaxbo/d2XGakfj2pzH4w72jE3DTm+Hcg6+fa+UGs8Mb7DnUHEAhGeYuto3drN89xr6r+hrXvPL7MfkE/g/FUKaK9Vz8fFady4Sep45dVgu/Na+7XI7dNNtYQIpFgyyB0T9V5UrHZNlkuMQtT7T/8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nQXkbqVvO9aFaBPbtP4E4+jIi/uqOgMO+4KOZd8P4E0=;
 b=CQiygrMxM148RAtS5IAuNEk9JxZzJR4fZysUcqldcUnx5oHhDnzat+st7dDe1KLoN9JPKYiHKw2jc+wpdz7bUw366ao7Vb9AIpsqQP4xBcC/Xlosk5zQPGCWaQiDPcEGBPAMG8W1v4SwhVPj/leSCF1dPya1yY+wuTPOImHpH1bVH9jfvSIcWoPKkQGi/2J+2PzJr4TCw0oQ5Y0iedhZu/3vcM6DIjVbzGJ7IHNRj1QO0wqhojzjWJ74kRp/UOu+YCaqTuDalfyANB1QqcHIXinhdSueITxAQ/qg0l6lBlTVUDwU/hIXToB5i/yA1uGEZ1yRV9cYp1/v+YuaTjZ+ag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nQXkbqVvO9aFaBPbtP4E4+jIi/uqOgMO+4KOZd8P4E0=;
 b=lA3Stj6cufxGL4ighgSj4sJzpEGmy8uYxxYTEGA61oZWCHFifbSNRcFAC1uDumzO6euBD0lQTecFv4p2GCcxmKNUb85Ma98v+BvwvGyJO4QqLhkt9C3xd/aCrYQ7dXDewdooAsxvI3falfaXKtF3PxeiLJ/eDDHx7nZ4YSnRF6w=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Roger
 Pau Monne" <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Topic: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Index: AQHYRdaC1Ty1lDbR3E6vxjqdlx39GKzbI4SAgAAExYCABfjsgIAAC0sA
Date: Tue, 5 Apr 2022 10:58:32 +0000
Message-ID: <4a425427-275f-e116-66a9-78e0bfc1be36@citrix.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
 <e20b3d17-0c2a-b23f-d949-667072a54f58@citrix.com>
 <ed31e78b-087e-869b-8aa0-5d5d0f3183fd@citrix.com>
 <75bd55fa-d29b-d49e-c3db-1bb952e4578f@suse.com>
In-Reply-To: <75bd55fa-d29b-d49e-c3db-1bb952e4578f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 26a5ed29-7df3-4c88-e3bd-08da16f339e5
x-ms-traffictypediagnostic: DM5PR03MB2476:EE_
x-microsoft-antispam-prvs: <DM5PR03MB24767100EBF8AFEE9FDE2A35BAE49@DM5PR03MB2476.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: JUXWttSeH5T0wSVFj537W34f8SwGx8cW3a7pJ6DP57+CCjFEUF3yYFcDF5ihqUWpTRl1Qoa0wov66b2v9jrE5zq7yU2vJB/LkgljXLbbTAbB76R5dtmkujDSwJfYPSuEx9eHJyXJYdDu+zI+KGv97+OBc7cfOjjNrmcN3vZLRepeqoZaiyYgtu0micJng18e3bCJYXuJJmeatCDfloSWHs6rE2acP3mZ5xj4wFg7S0qr9hvl8xCYgqyvInD8kUhNtHEc0+dqEtdGsOt37pTWG9JF6EsHUVjptQb1ad91XCkgYOBO8TJd8ZvHegs/8Cl3aZ2kYUZ9npJzW5TyVDTFOfkjDc1sPvkvl7ZKpwvSXoEKRrevYRoBhjsdmHsCyime98jR7HHsJBk/F2LdfPRpMEzH3iMvrX474hrs/WQqvxySRLOqROEo5nRuFGfhsrbMtyw3IyObj5tNJQNX5wT3U3axAlLvmbWMNb5A5awtVT7wV3uMaKSAc3nqkHvcZ9X4T8VxJk7iw/nqufpHxwOxzBKOcdh77R7IFUTJ6quZpK/hCQrcggF+U/k7jn5yRi+4HucHscmoxqI3fDsh4fECTkzkHF22b/axLrrmiE/1yrgC5bI0yYefNWDBWCirbLqZoezMDoJNW48RtTlAcn9LSSm7h62Ed2IL3wYANmaPYKIV1thbyWj/lAoMQYp2l5fFJK1Aoglbi1HtQQ6frYjjIqfp5Tq1mQtER964ClctrtIdBA4Wf9keoLXbE2aDB2nVbulQFRdliJedDHBEIs7d+w==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(36756003)(186003)(64756008)(66476007)(5660300002)(54906003)(71200400001)(66556008)(38070700005)(316002)(8936002)(2616005)(38100700002)(4744005)(2906002)(66446008)(26005)(31686004)(122000001)(6916009)(86362001)(91956017)(4326008)(6506007)(6512007)(508600001)(76116006)(66946007)(8676002)(6486002)(31696002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OTJUczdHRzhGQXNEVzR1SXljMmR6WVhxd0FuMTZiTy9MTXZseHZNbWgyTUg2?=
 =?utf-8?B?eTUvQ24xOGRRbWo4TDZCRnBDa2VQZXQ4QnFPOHJ4M2dwdUpoS2ZvaTRqUUZ3?=
 =?utf-8?B?MERDZUMzVkl5alBUTVI4WmM3VitQekExQmc3RmMycldUdzBIeVpWTUZMZjFY?=
 =?utf-8?B?RmFXZzQ3Z1JSVGQrdGdCSXFCcUJjdHEzMUFnR003YXJZRXNMVmtSS21iU1U5?=
 =?utf-8?B?Y0NSN051L1ZST0JqRGxQMDUvRURNS3dndnRqWHlBWlNSUysvSFYwcEZXelo4?=
 =?utf-8?B?MUpIVDZEZ1JoM3cxL0pQUysrcURXVWxhNWVBOC9CbjdRYU1qL0tGc3hyS2hI?=
 =?utf-8?B?MncveW9KSHdmc05yR1owbXNtZEF1Qk9oVEk3VVRyZitHRm9obno0cC8wallo?=
 =?utf-8?B?MERxUEdxU1A0UUxzYXJVU1YxMEtoeHF3YnR5NnZPeW9yWmk2M3ZRWVlyZmFa?=
 =?utf-8?B?YjRPcldEbFBjWHNBaE56YVp6RFRkZVZFU1FPYWxwRWQrR04yY3lFSFJMckJO?=
 =?utf-8?B?WWVFYW9aZ1FoKzFpdWMwZkF3N082aThacXZHSUUzS2l1ak5Ocng1K3BvT1Nv?=
 =?utf-8?B?cFdhazlDcHZ5aFNDTWI0MXlPZTdTOTJaU2RBMmVRRkI1S1JpNDM2NjRzSmo3?=
 =?utf-8?B?eUVtczVGUm4zNVhxWGZNRWdtc3JTd0ZRRWNlb2t5UFlTMjQvZjlKTTk2cFVR?=
 =?utf-8?B?cFdUMkxZZHYzTmEzWGN3ZUFXdjZwaXpkYlBRZEpLOCtRa0diMHlyRTRkS201?=
 =?utf-8?B?WUlUMjR2NXViVlNrY1pvMHNKVkE0NHYrMUt0ODVhQUV4bzVXeGdkbmVkdU1u?=
 =?utf-8?B?S090ekRtYXUva2tyL3BKeFcvRDg0bUlZL3loMHMzM3lRaFhwTHNtNWhaYVVn?=
 =?utf-8?B?ZmpiVWpHb2I1UTRUUHBuZStMdE02Z3dSS2VZRGhPd0FSVjlqbm5JR2ZnZ21P?=
 =?utf-8?B?RFh1d2UwS2dxdWlFbUlyVVJnblhNbzh4TS82SUM3dDN6T1VLYVlaT1o5bGVx?=
 =?utf-8?B?cEhGVnlGYmIyYjJJc2hHbzdaZVlKQmczOXc4WHlsYVpjY2VQM21CdmRCKzFR?=
 =?utf-8?B?bXB5cm9SUmFuZGE4RWt4UVljRkNXOHljUVREYWZtVkZ3Y1h1Q1MzSDZtamRo?=
 =?utf-8?B?TlhaYmZ2bENhbnc3K3JYTUY0S3FwSUp2ci9mWmErL2IxeGZxblFWc0VNMGFS?=
 =?utf-8?B?S1c5aVQrMEsxVmRqc3RtbklaQVN6d3dMSmU0VHY0ZjI2ejNBMXFid3VML3My?=
 =?utf-8?B?Sm5zR250WHo5U1VqVEtzOW5nTUwzL0dqQmNpajZQazkrazV5Q1lRcncxSFBo?=
 =?utf-8?B?UFVYZXI5ZFJsMHlQSFlwRkxwTDlqQnpLelN4YmFEYlBlOUhqeXpza0NOMXVr?=
 =?utf-8?B?SVk2eTdrZzdRNzBJV0lYc0Q0VHpJZUZaNTNiOVNoQmhvREVHUktzSklPYXlm?=
 =?utf-8?B?ZWdLbDVMcGF2UC9kSUlmSHA0eTA1YVI2bFI4TXg3djhTUC96ekVyNFd5Ukph?=
 =?utf-8?B?d1NUWXZHS0twYWpwSmF3ekZMeUVUVzNIUlFLSHR5d2pIa2hYdVF0SGExNG8v?=
 =?utf-8?B?aElqQ2dRbXgrdGRZcEtrOUQwVlFaaDMwdmVOVXd1alRhbERZWmt5Z2IySHYz?=
 =?utf-8?B?cXNaTU4wU0xOTDFpLytEekpLYm81bUtvQ3pYOTdMeGRoVWFob2p1VGxCdTRZ?=
 =?utf-8?B?TkdlRDNxSlA4R1N5K0tybUJnL1JjYWhrcmxDSm5adjJFa0d2QzJkeGJqTk43?=
 =?utf-8?B?TFlNV0VPajhLOG1Yci9ZaC9GRmw1NktjSDVRdmZJbHdTaWhwR3RvdWFremNI?=
 =?utf-8?B?TFNhU0xlSm16WnlBQ21uT1FLUkZIL3RtSUM1UG92b2VFNm1WYzRhYysyNTlC?=
 =?utf-8?B?eDluMEV0MElFdllIR1l6M0FjSHNwVHR5NGdicU9zVHRhRFA2UXVYV0RRVmRD?=
 =?utf-8?B?VnAwNGhrQTNLbGRET1JWQ3JoY1ZkNDBlTUFGVWN4N1NCakJ4c0pZc2lZbDFW?=
 =?utf-8?B?dHRsbFZNNTdlMkhWUy85Wkd3S21UendlVUczZU1aYTM3QU5tT2M4QmZFNVNV?=
 =?utf-8?B?WDNiaTVKMDBTQndQcVdvVTZaaWx1WGs4RVJkM3lmSkxYSVlzM2pVenF2UWNM?=
 =?utf-8?B?ayt3c2V2RWlNOEp2eEpRdXFYaHlxNWsza3ZCUmFhOWh3Z0p1aFozNDYrQ2ZF?=
 =?utf-8?B?TVhlUjY3UXRWVHJRbmZoY0d5K3J6VHYxaEw1eVZFc0VTU2wyMEF5aUprNmZU?=
 =?utf-8?B?SG16a0xuT1FuT0ZBSzE3U2t1V1pYWXhuUFpOT1N4SjBNcE9qNTBBWkpPQ0VH?=
 =?utf-8?B?NnBOTnBSR0NJOUZrSXlWLzloV1h5bG9IMGZPYTl1QzBrakdxbzcxdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <73131A2CBF9D6147A1069A9FF8095DAB@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26a5ed29-7df3-4c88-e3bd-08da16f339e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2022 10:58:32.9484
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CkxInY9hGEyxj0ndx43Ca3KkNMzxYNwgAqvWMt9jY8N3dSqWOSDZ1oEyQJugHGNIcUF0K2G7Zi6sCoDQYNh/XG7DFMyO05KkU5On2zO+FHA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2476
X-OriginatorOrg: citrix.com

T24gMDUvMDQvMjAyMiAxMToxOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAxLjA0LjIwMjIg
MTc6MDUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwMS8wNC8yMDIyIDE1OjQ4LCBBbmRy
ZXcgQ29vcGVyIHdyb3RlOg0KPj4+IE9uIDAxLzA0LzIwMjIgMTU6MzcsIFJvZ2VyIFBhdSBNb25u
ZSB3cm90ZToNCj4+Pj4gU2V0dGluZyB0aGUgZmNmLXByb3RlY3Rpb249bm9uZSBvcHRpb24gaW4g
RU1CRURERURfRVhUUkFfQ0ZMQUdTIGluIHRoZQ0KPj4+PiBNYWtlZmlsZSBkb2Vzbid0IGdldCBp
dCBwcm9wYWdhdGVkIHRvIHRoZSBzdWJkaXJlY3Rvcmllcywgc28gaW5zdGVhZA0KPj4+PiBzZXQg
dGhlIGZsYWcgaW4gZmlybXdhcmUvUnVsZXMubWssIGxpa2UgaXQncyBkb25lIGZvciBvdGhlciBj
b21waWxlcg0KPj4+PiBmbGFncy4NCj4+Pj4NCj4+Pj4gRml4ZXM6IDM2NjdmN2Y4ZjcgKCd4ODY6
IEludHJvZHVjZSBzdXBwb3J0IGZvciBDRVQtSUJUJykNCj4+Pj4gU2lnbmVkLW9mZi1ieTogUm9n
ZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+Pj4gQWNrZWQtYnk6IEFuZHJl
dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+PiBUaGlzIGFsc28gbmVlZHMg
YmFja3BvcnRpbmcgd2l0aCB0aGUgWFNBLTM5OCBDRVQtSUJUIGZpeGVzLg0KPiBJIGRvbid0IHRo
aW5rIHNvIC0gdGhlIGJhY2twb3J0cyBvZiB0aGUgb3JpZ2luYWwgY29tbWl0IGRpZG4ndCBpbmNs
dWRlDQo+IHdoYXQgdGhpcyBwYXRjaCBmaXhlcy4gSSBoYXZlIHF1ZXVlZCBwYXRjaCAyIG9mIHRo
aXMgc2VyaWVzIHRob3VnaC4NCg0KSW4gd2hpY2ggY2FzZSBJIHNjcmV3ZWQgdXAgdGhlIGJhY2tw
b3J0LsKgIChJIHJlbWVtYmVyIHNwb3R0aW5nIHRoaXMgYnVnDQphbmQgdGhvdWdodCBJJ2QgY29y
cmVjdGVkIGl0LCBidXQgY2xlYXJseSBub3QuKcKgIHRvb2xzL2Zpcm13YXJlIHJlYWxseQ0KZG9l
cyBuZWVkIHRvIGJlIC1mY2YtcHJvdGVjdGlvbj1ub25lIHRvIGNvdW50ZXJhY3QgdGhlIGRlZmF1
bHRzIGluDQpVYnVudHUvZXRjLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:04:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:04:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298723.508986 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgyf-0004VU-1J; Tue, 05 Apr 2022 11:04:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298723.508986; Tue, 05 Apr 2022 11:04:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgye-0004VN-UQ; Tue, 05 Apr 2022 11:04:00 +0000
Received: by outflank-mailman (input) for mailman id 298723;
 Tue, 05 Apr 2022 11:04:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cqVg=UP=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nbgyd-0004VH-SP
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 11:04:00 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1786b9ba-b4d0-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 13:03:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D87681F390;
 Tue,  5 Apr 2022 11:03:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BC6E813522;
 Tue,  5 Apr 2022 11:03:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Rn6iLB0iTGLxZAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 05 Apr 2022 11:03:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1786b9ba-b4d0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649156637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=t/uOzPyXAW2P+HLgxlFI+aOMdzoZD9mdVxDzg53JeSs=;
	b=qMM0wXAs3l1tKmpjl4NIpRbpP8I5crgVIYkHbSMOMwsg+O0peA9HjltDYR3DM8ypH5GqlV
	SkgW73/fTQ4h4+HTLg50fE+BtyLOMGpn5zIPUyjbKGuuEkHtgg//UWkDVcQbWu/XQfZ43L
	rep85Am8CABFJ5717aUx7xHU75XCZxg=
Message-ID: <a9325c01-f6bd-46e8-d730-3f18b71b9969@suse.com>
Date: Tue, 5 Apr 2022 13:03:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <YkUlLvnEDdc5hwN4@mail-itl>
 <2684376b-3ae6-a2b7-581f-2bd38ab6056b@suse.com> <YkWYGFJ/Cl+B2C37@mail-itl>
 <362b6115-e296-e01e-520f-31a0826426eb@suse.com> <YkWgQNKK7SarjKDN@mail-itl>
From: Juergen Gross <jgross@suse.com>
Subject: Re: Increasing domain memory beyond initial maxmem
In-Reply-To: <YkWgQNKK7SarjKDN@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------zefoMAh7agHSYgHWqWVnpHry"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------zefoMAh7agHSYgHWqWVnpHry
Content-Type: multipart/mixed; boundary="------------fLjiUwBST15vdf7FqAOTRoO0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <a9325c01-f6bd-46e8-d730-3f18b71b9969@suse.com>
Subject: Re: Increasing domain memory beyond initial maxmem
References: <YkUlLvnEDdc5hwN4@mail-itl>
 <2684376b-3ae6-a2b7-581f-2bd38ab6056b@suse.com> <YkWYGFJ/Cl+B2C37@mail-itl>
 <362b6115-e296-e01e-520f-31a0826426eb@suse.com> <YkWgQNKK7SarjKDN@mail-itl>
In-Reply-To: <YkWgQNKK7SarjKDN@mail-itl>

--------------fLjiUwBST15vdf7FqAOTRoO0
Content-Type: multipart/mixed; boundary="------------ErIvpKe0RdzRl70blII8r2uw"

--------------ErIvpKe0RdzRl70blII8r2uw
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

SGkgTWFyZWssDQoNCk9uIDMxLjAzLjIyIDE0OjM2LCBNYXJlayBNYXJjenlrb3dza2ktR8Oz
cmVja2kgd3JvdGU6DQo+IE9uIFRodSwgTWFyIDMxLCAyMDIyIGF0IDAyOjIyOjAzUE0gKzAy
MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBNYXliZSBzb21lIGtlcm5lbCBjb25maWcg
ZGlmZmVyZW5jZXMsIG9yIG90aGVyIHVkZXYgcnVsZXMgKG1lbW9yeSBvbmxpbmluZw0KPj4g
aXMgZG9uZSB2aWEgdWRldiBpbiBteSBndWVzdCk/DQo+Pg0KPj4gSSdtIHNlZWluZzoNCj4+
DQo+PiAjIHpncmVwIE1FTU9SWV9IT1RQTFVHIC9wcm9jL2NvbmZpZy5neg0KPj4gQ09ORklH
X0FSQ0hfRU5BQkxFX01FTU9SWV9IT1RQTFVHPXkNCj4+IENPTkZJR19NRU1PUllfSE9UUExV
Rz15DQo+PiAjIENPTkZJR19NRU1PUllfSE9UUExVR19ERUZBVUxUX09OTElORSBpcyBub3Qg
c2V0DQo+PiBDT05GSUdfWEVOX0JBTExPT05fTUVNT1JZX0hPVFBMVUc9eQ0KPj4gQ09ORklH
X1hFTl9NRU1PUllfSE9UUExVR19MSU1JVD01MTINCj4gDQo+IEkgaGF2ZToNCj4gIyB6Z3Jl
cCBNRU1PUllfSE9UUExVRyAvcHJvYy9jb25maWcuZ3oNCj4gQ09ORklHX0FSQ0hfRU5BQkxF
X01FTU9SWV9IT1RQTFVHPXkNCj4gQ09ORklHX01FTU9SWV9IT1RQTFVHPXkNCj4gQ09ORklH
X01FTU9SWV9IT1RQTFVHX0RFRkFVTFRfT05MSU5FPXkNCj4gQ09ORklHX1hFTl9CQUxMT09O
X01FTU9SWV9IT1RQTFVHPXkNCj4gQ09ORklHX1hFTl9NRU1PUllfSE9UUExVR19MSU1JVD01
MTINCj4gDQo+IE5vdCBzdXJlIGlmIHJlbGV2YW50LCBidXQgSSBhbHNvIGhhdmU6DQo+IENP
TkZJR19YRU5fVU5QT1BVTEFURURfQUxMT0M9eQ0KPiANCj4gb24gdG9wIG9mIHRoYXQsIEkg
aGF2ZSBhIHNpbWlsYXIgdWRldiBydWxlIHRvbzoNCj4gDQo+IFNVQlNZU1RFTT09Im1lbW9y
eSIsIEFDVElPTj09ImFkZCIsIEFUVFJ7c3RhdGV9PT0ib2ZmbGluZSIsIEFUVFJ7c3RhdGV9
PSJvbmxpbmUiDQo+IA0KPiBCdXQgSSBkb24ndCB0aGluayB0aGV5IGFyZSBjb25mbGljdGlu
Zy4NCj4gDQo+PiBXaGF0IHR5cGUgb2YgZ3Vlc3QgYXJlIHlvdSB1c2luZz8gTWluZSB3YXMg
YSBQVkggZ3Vlc3QuDQo+IA0KPiBQVkggaGVyZSB0b28uDQoNCldvdWxkIHlvdSBsaWtlIHRv
IHRyeSB0aGUgYXR0YWNoZWQgcGF0Y2g/IEl0IHNlZW1lZCB0byB3b3JrIGZvciBtZS4NCg0K
DQpKdWVyZ2VuDQo=
--------------ErIvpKe0RdzRl70blII8r2uw
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-xen-balloon-fix-page-onlining-when-populating-new-zo.patch"
Content-Disposition: attachment;
 filename*0="0001-xen-balloon-fix-page-onlining-when-populating-new-zo.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBhNjA1MjMyMTE1YTljM2QzZjgxMDNkMDgzM2IxNDlmZjIyOTU2YzRiIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+
ClRvOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCkNjOiBCb3JpcyBPc3Ryb3Zza3kg
PGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29tPgpDYzogSnVlcmdlbiBHcm9zcyA8amdyb3Nz
QHN1c2UuY29tPgpDYzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu
b3JnPgpDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCkRhdGU6IFR1ZSwgNSBB
cHIgMjAyMiAxMjo0Mzo0MSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHhlbi9iYWxsb29uOiBm
aXggcGFnZSBvbmxpbmluZyB3aGVuIHBvcHVsYXRpbmcgbmV3IHpvbmUKTUlNRS1WZXJzaW9u
OiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQt
VHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCldoZW4gb25saW5pbmcgYSBuZXcgbWVtb3J5IHBh
Z2UgaW4gYSBndWVzdCB0aGUgWGVuIGJhbGxvb24gZHJpdmVyIGlzCmFkZGluZyBpdCB0byB0
aGUgYmFsbG9vbmVkIHBhZ2VzIGluc3RlYWQgbWFraW5nIGl0IGF2YWlsYWJsZSB0byBiZQp1
c2VkIGltbWVkaWF0ZWx5LiBUaGlzIGlzIG1lYW50IHRvIGVuYWJsZSB0byBhZGQgYSBuZXcg
dXBwZXIgbWVtb3J5CmxpbWl0IHRvIGEgZ3Vlc3QgdmlhIGhvdHBsdWdnaW5nIG1lbW9yeSwg
d2l0aG91dCBoYXZpbmcgdG8gYXNzaWduIHRoZQpuZXcgbWVtb3J5IGluIG9uZSBnby4KCklu
IGNhc2UgdGhlIHVwcGVyIG1lbW9yeSBsaW1pdCB3aWxsIGJlIHJhaXNlZCBhYm92ZSA0Rywg
dGhlIG5ldyBtZW1vcnkKd2lsbCBwb3B1bGF0ZSB0aGUgWk9ORV9OT1JNQUwgbWVtb3J5IHpv
bmUsIHdoaWNoIHdhc24ndCBwb3B1bGF0ZWQKYmVmb3JlLiBUaGUgbmV3bHkgcG9wdWxhdGVk
IHpvbmUgd29uJ3QgYmUgYWRkZWQgdG8gdGhlIGxpc3Qgb2Ygem9uZXMKbG9va2VkIGF0IGJ5
IHRoZSBwYWdlIGFsbG9jYXRvciB0aG91Z2gsIGFzIG9ubHkgem9uZXMgd2l0aCBhdmFpbGFi
bGUKbWVtb3J5IGFyZSBiZWluZyBhZGRlZCwgYW5kIHRoZSBtZW1vcnkgaXNuJ3QgeWV0IGF2
YWlsYWJsZSBhcyBpdCBpcwpiYWxsb29uZWQgb3V0LgoKVGhpcyB3aWxsIHJlc3VsdCBpbiB0
aGUgbmV3IG1lbW9yeSBiZWluZyBhc3NpZ25lZCB0byB0aGUgZ3Vlc3QsIGJ1dAp3aXRob3V0
IHRoZSBhbGxvY2F0b3IgYmVpbmcgYWJsZSB0byB1c2UgaXQuCgpXaGVuIHJ1bm5pbmcgYXMg
YSBQViBndWVzdCB0aGUgc2l0dWF0aW9uIGlzIGV2ZW4gd29yc2U6IHdoZW4gaGF2aW5nCmJl
ZW4gc3RhcnRlZCB3aXRoIGxlc3MgbWVtb3J5IHRoYW4gYWxsb3dlZCwgYW5kIHRoZSB1cHBl
ciBsaW1pdCBiZWluZwpsb3dlciB0aGFuIDRHLCBiYWxsb29uaW5nIHVwIHdpbGwgaGF2ZSB0
aGUgc2FtZSBlZmZlY3QgYXMgaG90cGx1Z2dpbmcKbmV3IG1lbW9yeS4gVGhpcyBpcyBkdWUg
dG8gdGhlIHVzYWdlIG9mIHRoZSB6b25lIGRldmljZSBmdW5jdGlvbmFsaXR5CnNpbmNlIGNv
bW1pdCA5ZTIzNjljMDZjOGEgKCJ4ZW46IGFkZCBoZWxwZXJzIHRvIGFsbG9jYXRlIHVucG9w
dWxhdGVkCm1lbW9yeSIpIGZvciBjcmVhdGluZyBtYXBwaW5ncyBvZiBvdGhlciBndWVzdCdz
IHBhZ2VzLCB3aGljaCBhcyBhIHNpZGUKZWZmZWN0IGlzIGJlaW5nIHVzZWQgZm9yIFBWIGd1
ZXN0IGJhbGxvb25pbmcsIHRvby4KCkZpeCB0aGlzIGJ5IGNoZWNraW5nIGluIHhlbl9vbmxp
bmVfcGFnZSgpIHdoZXRoZXIgdGhlIG5ldyBtZW1vcnkgcGFnZQp3aWxsIGJlIHRoZSBmaXJz
dCBpbiBhIG5ldyB6b25lLiBJZiB0aGlzIGlzIHRoZSBjYXNlLCBhZGQgYW5vdGhlciBwYWdl
CnRvIHRoZSBiYWxsb29uIGFuZCB1c2UgdGhlIGZpcnN0IG1lbW9yeSBwYWdlIG9mIHRoZSBu
ZXcgY2h1bmsgYXMgYQpyZXBsYWNlbWVudCBmb3IgdGhpcyBub3cgYmFsbG9vbmVkIG91dCBw
YWdlLiBUaGlzIHdpbGwgcmVzdWx0IGluIHRoZQpuZXdseSBwb3B1bGF0ZWQgem9uZSBjb250
YWluaW5nIG9uZSBwYWdlIGJlaW5nIGF2YWlsYWJsZSBmb3IgdGhlIHBhZ2UKYWxsb2NhdG9y
LCB3aGljaCBpbiB0dXJuIHdpbGwgbGVhZCB0byB0aGUgem9uZSBiZWluZyBhZGRlZCB0byB0
aGUKYWxsb2NhdG9yLgoKQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKRml4ZXM6IDllMjM2
OWMwNmM4YSAoInhlbjogYWRkIGhlbHBlcnMgdG8gYWxsb2NhdGUgdW5wb3B1bGF0ZWQgbWVt
b3J5IikKUmVwb3J0ZWQtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8bWFybWFy
ZWtAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9z
cyA8amdyb3NzQHN1c2UuY29tPgotLS0KIGRyaXZlcnMveGVuL2JhbGxvb24uYyB8IDcyICsr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFu
Z2VkLCA2NSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Ry
aXZlcnMveGVuL2JhbGxvb24uYyBiL2RyaXZlcnMveGVuL2JhbGxvb24uYwppbmRleCBkZmUy
NmZhMTdlOTUuLmY4OTVjNTRjNGM2NSAxMDA2NDQKLS0tIGEvZHJpdmVycy94ZW4vYmFsbG9v
bi5jCisrKyBiL2RyaXZlcnMveGVuL2JhbGxvb24uYwpAQCAtMzU1LDE0ICszNTUsNzcgQEAg
c3RhdGljIGVudW0gYnBfc3RhdGUgcmVzZXJ2ZV9hZGRpdGlvbmFsX21lbW9yeSh2b2lkKQog
CXJldHVybiBCUF9FQ0FOQ0VMRUQ7CiB9CiAKK3N0YXRpYyBzdHJ1Y3QgcGFnZSAqYWxsb2Nf
cGFnZV9mb3JfYmFsbG9vbihnZnBfdCBnZnApCit7CisJc3RydWN0IHBhZ2UgKnBhZ2U7CisK
KwlwYWdlID0gYWxsb2NfcGFnZShnZnApOworCWlmIChwYWdlID09IE5VTEwpCisJCXJldHVy
biBOVUxMOworCisJYWRqdXN0X21hbmFnZWRfcGFnZV9jb3VudChwYWdlLCAtMSk7CisJeGVu
bWVtX3Jlc2VydmF0aW9uX3NjcnViX3BhZ2UocGFnZSk7CisKKwlyZXR1cm4gcGFnZTsKK30K
Kworc3RhdGljIHZvaWQgYWRkX3BhZ2VfdG9fYmFsbG9vbihzdHJ1Y3QgcGFnZSAqcGFnZSkK
K3sKKwl4ZW5tZW1fcmVzZXJ2YXRpb25fdmFfbWFwcGluZ19yZXNldCgxLCAmcGFnZSk7CisJ
YmFsbG9vbl9hcHBlbmQocGFnZSk7Cit9CisKIHN0YXRpYyB2b2lkIHhlbl9vbmxpbmVfcGFn
ZShzdHJ1Y3QgcGFnZSAqcGFnZSwgdW5zaWduZWQgaW50IG9yZGVyKQogewogCXVuc2lnbmVk
IGxvbmcgaSwgc2l6ZSA9ICgxIDw8IG9yZGVyKTsKIAl1bnNpZ25lZCBsb25nIHN0YXJ0X3Bm
biA9IHBhZ2VfdG9fcGZuKHBhZ2UpOwogCXN0cnVjdCBwYWdlICpwOworCXN0cnVjdCB6b25l
ICp6b25lOwogCiAJcHJfZGVidWcoIk9ubGluZSAlbHUgcGFnZXMgc3RhcnRpbmcgYXQgcGZu
IDB4JWx4XG4iLCBzaXplLCBzdGFydF9wZm4pOwogCW11dGV4X2xvY2soJmJhbGxvb25fbXV0
ZXgpOworCXpvbmUgPSBwYWdlX3pvbmUocGZuX3RvX3BhZ2Uoc3RhcnRfcGZuKSk7CisKKwkv
KgorCSAqIEluIGNhc2UgYSBuZXcgbWVtb3J5IHpvbmUgaXMgZ29pbmcgdG8gYmUgcG9wdWxh
dGVkLCB3ZSBuZWVkIHRvCisJICogZW5zdXJlIGF0IGxlYXN0IG9uZSBwYWdlIGlzIG1hZGUg
YXZhaWxhYmxlIGZvciB0aGUgbWVtb3J5IGFsbG9jYXRvci4KKwkgKiBBcyB0aGUgbnVtYmVy
IG9mIHBhZ2VzIHBlciB6b25lIGlzIHVwZGF0ZWQgb25seSBhZnRlciBhIGJhdGNoIG9mCisJ
ICogcGFnZXMgaGF2aW5nIGJlZW4gYWRkZWQsIHVzZSB0aGUgbnVtYmVyIG9mIG1hbmFnZWQg
cGFnZXMgYXMgYW4KKwkgKiBhZGRpdGlvbmFsIGluZGljYXRvciBmb3IgYSBuZXcgem9uZS4K
KwkgKiBPdGhlcndpc2UgdGhpcyB6b25lIHdvbid0IGJlIGFkZGVkIHRvIHRoZSB6b25lbGlz
dCByZXN1bHRpbmcgaW4gdGhlCisJICogem9uZSdzIG1lbW9yeSBub3QgdXNhYmxlIGJ5IHRo
ZSBrZXJuZWwuCisJICogQWRkIGFuIGFscmVhZHkgdmFsaWQgcGFnZSB0byB0aGUgYmFsbG9v
biBhbmQgcmVwbGFjZSBpdCB3aXRoIHRoZQorCSAqIGZpcnN0IHBhZ2Ugb2YgdGhlIHRvIGJl
IGFkZGVkIG5ldyBtZW1vcnkgY2h1bmsuCisJICovCisJaWYgKCFwb3B1bGF0ZWRfem9uZSh6
b25lKSAmJiAhbWFuYWdlZF96b25lKHpvbmUpKSB7CisJCXhlbl9wZm5fdCBmcmFtZTsKKwor
CQlwcl9pbmZvKCJQb3B1bGF0aW5nIG5ldyB6b25lXG4iKTsKKworCQlwID0gYWxsb2NfcGFn
ZV9mb3JfYmFsbG9vbihHRlBfQVRPTUlDKTsKKwkJaWYgKCFwKSB7CisJCQlwcl9lcnIoIkZh
aWxlZCB0byBhbGxvY2F0ZSByZXBsYWNlbWVudCBiYWxsb29uIHBhZ2UhXG4iKTsKKwkJCXBy
X2VycigiTmV3IG9ubGluZWQgbWVtb3J5IG1pZ2h0IG5vdCBiZSB1c2FibGUuXG4iKTsKKwkJ
fSBlbHNlIHsKKwkJCWttYXBfZmx1c2hfdW51c2VkKCk7CisJCQlhZGRfcGFnZV90b19iYWxs
b29uKHApOworCQkJZmx1c2hfdGxiX2FsbCgpOworCQkJZnJhbWUgPSB4ZW5fcGFnZV90b19n
Zm4ocCk7CisJCQl4ZW5tZW1fcmVzZXJ2YXRpb25fZGVjcmVhc2UoMSwgJmZyYW1lKTsKKwkJ
CWJhbGxvb25fc3RhdHMuY3VycmVudF9wYWdlcy0tOworCQl9CisKKwkJcCA9IHBmbl90b19w
YWdlKHN0YXJ0X3Bmbik7CisJCWZyYW1lID0gcGFnZV90b194ZW5fcGZuKHApOworCQlpZiAo
eGVubWVtX3Jlc2VydmF0aW9uX2luY3JlYXNlKDEsICZmcmFtZSkgPiAwKSB7CisJCQl4ZW5t
ZW1fcmVzZXJ2YXRpb25fdmFfbWFwcGluZ191cGRhdGUoMSwgJnAsICZmcmFtZSk7CisJCQlm
cmVlX3Jlc2VydmVkX3BhZ2UocCk7CisJCQliYWxsb29uX3N0YXRzLmN1cnJlbnRfcGFnZXMr
KzsKKworCQkJc3RhcnRfcGZuKys7CisJCQlzaXplLS07CisJCX0KKwl9CiAJZm9yIChpID0g
MDsgaSA8IHNpemU7IGkrKykgewogCQlwID0gcGZuX3RvX3BhZ2Uoc3RhcnRfcGZuICsgaSk7
CiAJCWJhbGxvb25fYXBwZW5kKHApOwpAQCAtNDUyLDE0ICs1MTUsMTIgQEAgc3RhdGljIGVu
dW0gYnBfc3RhdGUgZGVjcmVhc2VfcmVzZXJ2YXRpb24odW5zaWduZWQgbG9uZyBucl9wYWdl
cywgZ2ZwX3QgZ2ZwKQogCQlucl9wYWdlcyA9IEFSUkFZX1NJWkUoZnJhbWVfbGlzdCk7CiAK
IAlmb3IgKGkgPSAwOyBpIDwgbnJfcGFnZXM7IGkrKykgewotCQlwYWdlID0gYWxsb2NfcGFn
ZShnZnApOworCQlwYWdlID0gYWxsb2NfcGFnZV9mb3JfYmFsbG9vbihnZnApOwogCQlpZiAo
cGFnZSA9PSBOVUxMKSB7CiAJCQlucl9wYWdlcyA9IGk7CiAJCQlzdGF0ZSA9IEJQX0VBR0FJ
TjsKIAkJCWJyZWFrOwogCQl9Ci0JCWFkanVzdF9tYW5hZ2VkX3BhZ2VfY291bnQocGFnZSwg
LTEpOwotCQl4ZW5tZW1fcmVzZXJ2YXRpb25fc2NydWJfcGFnZShwYWdlKTsKIAkJbGlzdF9h
ZGQoJnBhZ2UtPmxydSwgJnBhZ2VzKTsKIAl9CiAKQEAgLTQ4MCwxMSArNTQxLDggQEAgc3Rh
dGljIGVudW0gYnBfc3RhdGUgZGVjcmVhc2VfcmVzZXJ2YXRpb24odW5zaWduZWQgbG9uZyBu
cl9wYWdlcywgZ2ZwX3QgZ2ZwKQogCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShwYWdlLCB0
bXAsICZwYWdlcywgbHJ1KSB7CiAJCWZyYW1lX2xpc3RbaSsrXSA9IHhlbl9wYWdlX3RvX2dm
bihwYWdlKTsKIAotCQl4ZW5tZW1fcmVzZXJ2YXRpb25fdmFfbWFwcGluZ19yZXNldCgxLCAm
cGFnZSk7Ci0KIAkJbGlzdF9kZWwoJnBhZ2UtPmxydSk7Ci0KLQkJYmFsbG9vbl9hcHBlbmQo
cGFnZSk7CisJCWFkZF9wYWdlX3RvX2JhbGxvb24ocGFnZSk7CiAJfQogCiAJZmx1c2hfdGxi
X2FsbCgpOwotLSAKMi4zNC4xCgo=
--------------ErIvpKe0RdzRl70blII8r2uw
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------ErIvpKe0RdzRl70blII8r2uw--

--------------fLjiUwBST15vdf7FqAOTRoO0--

--------------zefoMAh7agHSYgHWqWVnpHry
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJMIh0FAwAAAAAACgkQsN6d1ii/Ey/v
qwf+NrLSKxZ6WD0wFx8JheJkolip4u1F1b82c1q/YXyyIuPmkTr2NvJYRfmUdPfgzY5KY5wyQWu5
9+K23GyjW3SaJDCO0JRZs/rQnqmAZgN7aK48cfRafRlHGy+WzFME7CTHVy/xr7c7QSHfhAEw2LBf
QN1Qd31aVT1TldycDBwtLg57kCMJNqI1DMJBhBTvN4xlht1Z1ulADb8pkE07m1mFjmDODnmFtbjc
jOKDwtqUpfn2JQVI08sdoNOpx7HD2jhGmTTbwNMCLG0rhSF+POEQA6VjlKvk+bExosaEI65oUwo6
n0v+Mrf4wofhD8Ey8oTKumMl5dBRQPDxjK4QSkeb+Q==
=pR6e
-----END PGP SIGNATURE-----

--------------zefoMAh7agHSYgHWqWVnpHry--


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:04:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:04:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298726.508997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgyu-0004si-Co; Tue, 05 Apr 2022 11:04:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298726.508997; Tue, 05 Apr 2022 11:04:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbgyu-0004sZ-9n; Tue, 05 Apr 2022 11:04:16 +0000
Received: by outflank-mailman (input) for mailman id 298726;
 Tue, 05 Apr 2022 11:04:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbgys-0004rB-Uo
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 11:04:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 20dac3af-b4d0-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 13:04:14 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-JC4I5QBYOIyCzGBSB1ATwA-1; Tue, 05 Apr 2022 13:04:11 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5520.eurprd04.prod.outlook.com (2603:10a6:803:cc::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 11:04:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 11:04:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20dac3af-b4d0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649156653;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IgWx14sa0Tbh0Df/oTMWJFoGWSZJGpY8vSNdv7/XMQ4=;
	b=YvT9cVL5hXw2UoJdUq79u7UGHExKkECYmo5pMgampJXoJSP6Tm/UjiIsB9J+fxF/mvTHQP
	ez7sFsvEswxcGFDqxsTdGzbp6Ce33Tfp3K/dWaGrMgQIT92N6ErSbU4JVZkz/v+fYNy5hq
	Y2PxlWF1U3K3anVyYQha9Aeu9k4XuP8=
X-MC-Unique: JC4I5QBYOIyCzGBSB1ATwA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y97SfqWICasbae7XruQzC5aizdoMtrWhI9EHGpunVmSO88fm+UvhJgFjdnSvhyn9tBTtxGooicx/4//8hOBUQ0VkT0wZDVVxbmor+ZJx1AVORSdDlG6P5PdNN5s0jRwgrQXfg0wT6w2jVxNnmz0yI2WBfTd1b5/lOBVvmrzXmhGJBmgXoPo52LMgUH2f68RTomd++0yvkU4ybUvbbjuwL6woNuKGVFQ14eVqMGtSV/FlVsJ/4YwTYyZG/JgLfYZhWv6Aa6p05YYReI7fb698x9LaT5ZdfQVQPH7DPr8AgVBoPozQpdMOavxITwlZ4o9muTOditrOoaDtAMaKTwtMLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iJvghX+akbrjmhlUKpqO8xXlIRC1cc3Qbff6qaDoSYg=;
 b=L0rhGGOs/IaOQT2H4or5wKMLXBbu0QHrfhJLQmm2CMOllAE9cbg8HCnd13yt9+1o024bbmAZVMiZShEH8R+uWfP9A1xPt6V3U+v4DOFXcum7XJXTB78P4bxSZqIxuozde/d4uOGITwv2iXFy+gSgwgeE6/+wT88tnTOm39DZnsAF34yvtiJ1fOjTPfiR6w/c1dwBgVQfVoYeChodp6plrhp9qOnoWyDF7Mr87Y6Fm85rh78vw3TwE7cGR2OWxzNToY6K0L2GyqBc7UfOE1292zV0vMgYOBFvZ5ZM92DP4KhAX2MTLYviswXyumNlDDajcjcviJdVGpzEw8xkn131Og==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7e2f17b2-8e54-ea9d-0a20-b49fb5ddf98c@suse.com>
Date: Tue, 5 Apr 2022 13:04:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
 <e20b3d17-0c2a-b23f-d949-667072a54f58@citrix.com>
 <ed31e78b-087e-869b-8aa0-5d5d0f3183fd@citrix.com>
 <75bd55fa-d29b-d49e-c3db-1bb952e4578f@suse.com>
 <4a425427-275f-e116-66a9-78e0bfc1be36@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4a425427-275f-e116-66a9-78e0bfc1be36@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0201CA0006.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c4633d91-6c30-4ac8-94ae-08da16f40286
X-MS-TrafficTypeDiagnostic: VI1PR04MB5520:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5520A3D36EA2CC3D4B8F2C6BB3E49@VI1PR04MB5520.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q/GPR5LnF+aaDiU4PuaAQkLy1T1zCiNalODidcP648GT+Jw0W6LaVHr3QHrfmempNIbjmZRIcbkkA//6xMdbaFQJxxyzGd10pSyXOj+8qM4NqxDWNaDpFsmUe9VVwQHO8VWu81UpYkes9O028UpsQwuBODkLrZWVIfU06Cr2WZEU02T6XPmT4gp7hLZ/+0ZXZgBM/dkcTp4N+AxKlSbh0zmG8pxkPOribeHVFyk3bFkP72emcpxMh8iredEy4bGkamd+mjNQDVan27xJw2XDbHJ5AF9PWvvQM7v+ToRN0raTyWYdUhOQoa3PxCZDJUwQXwgaj4kuapV2uKd/VFfNpTys2D/hXIFrotjqxu8civnVFIayHzK8eLVCKMd/HisFJcMD8syaknhlj+Nx374bz262eUX5hl2h1dRr/AgnaFoOLm9TECxZMcMb5KpPQzyymDyQ2mQBcZ6kg5jS3Sr0DZyuaa0l77ldtkhAKKpKE6IdJWKGDDHvACPvsQZaTFz+tGCKhnBB8NgquIav3F/5UlvUo9DLwv8nk6oHPNr0Hsn+JFp629qRoWdjPIyzYPiGpsY8L8QbG807x8wrK2EcherrJkrDenL/5LqZ6LiBbRyP+HKSDHUF8+fb4qUiA+1AQSOatXzzrlwJ2NAku5mu0/nI9IGWREdVUgRArQrphcBsrCXBWK13fcgCdgVgiGZ/wWUDxBrBdVd8xIzW1/41hd6nP0md7Kc55ZaUiag+ehIpkXGdG2yviTj6kvtLNPiw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(8936002)(31686004)(31696002)(36756003)(86362001)(5660300002)(66476007)(38100700002)(4326008)(2616005)(54906003)(53546011)(6506007)(6512007)(66556008)(316002)(6916009)(508600001)(26005)(186003)(6486002)(8676002)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KX2GNcDFVZ92XtsnPr9cW9XemTvV4lO9Bxf8Ewhh3uCXJ+0wmzWIIrJGi5PF?=
 =?us-ascii?Q?5+zosFXOu+akkpWn7viSGTdLTReKE3UPs1aMM3lGY24Hs0sgw5Dme/a8v4PW?=
 =?us-ascii?Q?UlqlxJiqbQ0JFVlPHbRMucAciJV8Aae34QStHxERUnU/geMmSWrJEDeTVfn9?=
 =?us-ascii?Q?9aPGLQ6aQD9DfTAJTGa5wXelRf+LcZvLuP8T0WQky6vFrBGHfjGbq+YEcYRm?=
 =?us-ascii?Q?qCh+uqmVxfvLPgfVU+zwNhOhSVSmbfI73cu6SwDtBtIQmaZLhndZkdEnvF0+?=
 =?us-ascii?Q?H9AzHd1w6zOT3glYZgC27niFn/gGcv9Q+O0hIpQm6LH9cTr3pFSLScU18ZvR?=
 =?us-ascii?Q?1oxzI8jaebAVwVz7See0TwQfxaWFsbjSVtQ/5YZOLZfVcoXmquU/2/jcaXXw?=
 =?us-ascii?Q?KwjK411W6pPzcSwevoe7G0PXm0USwjPr4p9tbtVVWsJXzzaSk7VE1En71yZj?=
 =?us-ascii?Q?myvX6jY5p0P5TSWYbuFqjMDPjIqfVlKen+12H8Sb4GKFoi9oJGOmqosWmmCw?=
 =?us-ascii?Q?vGSC1B2ITkoaMXQrX0SNGEj1Kj5UgpaPl76RMT7coRNLK5FhOdaQD9pfUmbF?=
 =?us-ascii?Q?hZJJYOGv9O3CRl/cJgV2Q4thLQ8hEaz9mngdHqxFCaPnN6OLN/Y6gxWLP3Ss?=
 =?us-ascii?Q?pLdlv9qfURJN74JyL6we/OXwsEM6MWRXSCNG7u1KGWE1Gp4urPCZaVQLyyPQ?=
 =?us-ascii?Q?2Nq2J3MOad2t1rnzGU6KdM/XchTvFMtpxiCzv1kJRv4stiNDf1JywzQ9rjSB?=
 =?us-ascii?Q?WagSLNYXavsS0/KZ2uQghqjV06LwLkg6SGOyvppB+8lOqCofQeRREVwBvpCX?=
 =?us-ascii?Q?+SSp276hOgHxBQiLE0oRoym6gnGo8EY8i+lXRLvL/CfYMaXInZP/ZKl4W2X1?=
 =?us-ascii?Q?oqT6bZfloqkKbmWdCmEXTarO8Ap10phO+N+aon02C+Z9Dmi6SUJvLm8GQwDe?=
 =?us-ascii?Q?Hzdn8yuYaYFkBXXRdI4EQVaMfoSGduMhw/ZWuIHffBywhDpOl12e1ntzIwFS?=
 =?us-ascii?Q?85qEJwcft3zM9Ibk9nbAA2kDRPK2HgEP/e+g1UpanTICmLCSTh3gT3pYI7FS?=
 =?us-ascii?Q?O6DKOmgG7YD5ZcXqCBw8nsITBaZ6DL0r06BOaYzwo4BbtAlkuOEPItE91GRG?=
 =?us-ascii?Q?Wqd8vkeGMdLvOzIeWmOS/1CMe7h+DvF7ufrNujzNSa5lknHto/sNIymBYy5Y?=
 =?us-ascii?Q?1U6W5k4Dw7veXLeBGVJTcd8XcNWEjMQWNC37A+U4bIDcb+hVrnFAiMFpLaiA?=
 =?us-ascii?Q?3JDpkG0ZpRDJsoWIa4Dsc/fFVMbzVcbdWqyPkkqcH0XlAHebbF7yVLzfZfR2?=
 =?us-ascii?Q?XVqv09ZBNVG+SXo9W9Xif1T+NIpEsNIhao9wndNEMkt79pxSSPb/RiJcUFIa?=
 =?us-ascii?Q?TGAtUxVCgi4Rv8nEdQOHeE9n09emYBREDNl+J4s2GO8Lz2f85ADGg3PfD5Lu?=
 =?us-ascii?Q?dbYEAC02Da83pOkx6ghS3EhnPbs1RZaipNXs9MfUO1aTAdDe1NqfgdzZdyfK?=
 =?us-ascii?Q?ut543umG1mHGLRFXBJgI5Hj0CF4Ni1C2BL6DJWtqD17QGypLjYoCpmiD7WLP?=
 =?us-ascii?Q?PLMqPevD6u6ei3XNl3Fwuv9RQosdhwuaaYGkbjOBrHJipF5cXpujWkNqmE76?=
 =?us-ascii?Q?L0fUIhis5nbMwItqhHUB7mEyVQo8b0YCUNc47CPX/NP3F4lp6dROpmLTUGf4?=
 =?us-ascii?Q?R2dwBPsmjW3/aMC5cjDg2vkHXoGAGxQutmmYhOh05fvgTSCaalL/d9I1sBOv?=
 =?us-ascii?Q?e4vxQBP4/w=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4633d91-6c30-4ac8-94ae-08da16f40286
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 11:04:09.7801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 449ks5Mlt9cWQIdeNVYl2euzpaJYEHhjh6IMuWbzsajhlM+/H7lB1BTcYQfmosU9XFtKow4JoBx/rtu3r8a7tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5520

On 05.04.2022 12:58, Andrew Cooper wrote:
> On 05/04/2022 11:18, Jan Beulich wrote:
>> On 01.04.2022 17:05, Andrew Cooper wrote:
>>> On 01/04/2022 15:48, Andrew Cooper wrote:
>>>> On 01/04/2022 15:37, Roger Pau Monne wrote:
>>>>> Setting the fcf-protection=3Dnone option in EMBEDDED_EXTRA_CFLAGS in =
the
>>>>> Makefile doesn't get it propagated to the subdirectories, so instead
>>>>> set the flag in firmware/Rules.mk, like it's done for other compiler
>>>>> flags.
>>>>>
>>>>> Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT')
>>>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>>> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> This also needs backporting with the XSA-398 CET-IBT fixes.
>> I don't think so - the backports of the original commit didn't include
>> what this patch fixes. I have queued patch 2 of this series though.
>=20
> In which case I screwed up the backport.=C2=A0 (I remember spotting this =
bug
> and thought I'd corrected it, but clearly not.)=C2=A0 tools/firmware real=
ly
> does need to be -fcf-protection=3Dnone to counteract the defaults in
> Ubuntu/etc.

Okay, I'll adjust title and description some then while doing the backport.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:10:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:10:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298733.509008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbh4Z-0006Zj-5a; Tue, 05 Apr 2022 11:10:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298733.509008; Tue, 05 Apr 2022 11:10:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbh4Z-0006Zc-0s; Tue, 05 Apr 2022 11:10:07 +0000
Received: by outflank-mailman (input) for mailman id 298733;
 Tue, 05 Apr 2022 11:10:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0KMS=UP=citrix.com=prvs=0874ecad3=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nbh4Y-0006ZW-I5
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 11:10:06 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f1606ae5-b4d0-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 13:10:05 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1606ae5-b4d0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649157004;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Ei8yoeKvYI0m9hANnQYNtTOzSR3ITuGRE/zEji92RoU=;
  b=EMWm6vuVD26b7LYcoUT2FdjhMeKWZibAE4AA9ACY9WZKOqdkSd3Clqus
   cw2aAc21//TWJpZSYiEkLJ3OccmsVzPrNcOjR0JEeS+tkqQI35/MzsdEQ
   A/FKkuzdAA7CtpghOaOg7B7K4RZm01EJb6rKDFHCO7wZLrN7MCxb1xPSx
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68031898
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OVDVUqPLIMsFwu7vrR23l8FynXyQoLVcMsEvi/4bfWQNrUpwgTEDz
 2EeD2vUO63eazb1Ktlxboiw8R5X6pPXndZnQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw
 ZZElMKyQxkTPPOQt+I0WSFKLxBCIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTa6FP
 ppIOVKDajzDUhl0ZAwuL6s4xuGLn3y4dz0flmqK8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTR4Y6BLC+sPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc9MTGsxk6guT8KiKvymfL2I8XAJwVMNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4PORECnCBtJ6sybp1qHHb4
 RDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vfB0xbptYImO1C
 KM2he+3zMUOVJdNRfUpC79d9uxwlfSwfTgbfq68giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLanOHOKrtdPcwtiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSevxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:NRgmeqENDFM52XcIpLqFSJHXdLJyesId70hD6qkvc3Jom52j+P
 xGws526fatskdsZJkh8erwXJVp2RvnhNBICPoqTMiftW7dySqVxeBZnMTfKljbehEWmdQtrZ
 uIH5IOauEYSGIK8PoSgzPIU+rIouP3i5xA7N22pxwGIGEaCJ2IrT0JcDpzencGHjWubqBJc6
 Z0k/A33gZIDk5nCPhTaEN1OtTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq
 iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNFNyMIv/MpTvKe0Tt8gDg06t
 M544rS3aAnfS/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvtn+9Pa1wVB4S0rpXW9
 WGzfusk8p+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wuK4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Fqd2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLH3QIwFllu5EU5HHNc/W2He4OSITeuOb0oEiPvE=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68031898"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W2I+W7m3FXK7o6eGHMPPuE5oHVPcdECw3mUBmf4e8535CS+TiofFqOtdh2PufE+hTWquDvUbiEQkjGcKOyahdSUY4YMZlYPhyM2WuoIpCFAH40n20lRyRqFoAppm5de7Wk1NiZRjsz1YXSF6YHGu2oLlcS3MJZYMMZRX7eVZOqizNKWDmRb/IKZIcr6G88qJUQbk+x5wMmta3Ic30ByvdmYkRFYN5lcGZmJE5vgsJsLIN4A/y4xKPOEamfRrZ2lqAi69VxCD/1stGbA6vv9F2m5QCCyGott8O5lOeaB5NU1DQ/y/pFy2K3IK7bPG/IAPT7qWTguWwz7UhXKidC7Xcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ei8yoeKvYI0m9hANnQYNtTOzSR3ITuGRE/zEji92RoU=;
 b=N2EvSqXAASNaGTd373cmBhYa5PMp6M4jCe+h2yApEAoXcuhmBH9Bn+KdlL1XyL6eMLKErUsSGp2AzhTiZf6t/s1+a5FZYNk9ffDqVHu32Up7OYdlxz3UVGcFAy/Fobxsebgha6m9kuIbADqKH+n0E8ldzwuqT1RRlHWGaER5l57f4UYiX/BQOGyj7ivc2VMbYtvITx5QRFTNk1X0xzPI2EiAssqH4EK+MfxF634EnzQCQ90cGKdIyl2CUZT5ElP1vEyDEgD++yPSwBmJjJEW4+95Va4LZbZKAow2iEd5xA0OMWUXGURkxQ1mxcKVrBA6r5PBKIwi601miEbolzNLtg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ei8yoeKvYI0m9hANnQYNtTOzSR3ITuGRE/zEji92RoU=;
 b=uLH6lIBMLMpj62F58oV2ezKF41oWNVL5U8jFndO9LpBIHfKSepifGuGfKsfzeO01VkT0w5sRKMRRzD8nipqIZTzx5E8DGSux5adZMT2aw8ZMvVewG75UsBe7zpQGYwG6DMVqQ1n+NRUDAfIPyetPJ7Ho5PIOoz8Ve90BFgzglog=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Roger
 Pau Monne" <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Topic: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
Thread-Index: AQHYRdaC1Ty1lDbR3E6vxjqdlx39GKzbI4SAgAAExYCABfjsgIAAC0sAgAABkQCAAAGdgA==
Date: Tue, 5 Apr 2022 11:09:55 +0000
Message-ID: <f14a8c34-7dfa-5ee4-57cd-7203fbec2d17@citrix.com>
References: <20220401143720.23160-1-roger.pau@citrix.com>
 <20220401143720.23160-2-roger.pau@citrix.com>
 <e20b3d17-0c2a-b23f-d949-667072a54f58@citrix.com>
 <ed31e78b-087e-869b-8aa0-5d5d0f3183fd@citrix.com>
 <75bd55fa-d29b-d49e-c3db-1bb952e4578f@suse.com>
 <4a425427-275f-e116-66a9-78e0bfc1be36@citrix.com>
 <7e2f17b2-8e54-ea9d-0a20-b49fb5ddf98c@suse.com>
In-Reply-To: <7e2f17b2-8e54-ea9d-0a20-b49fb5ddf98c@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 45fb3b3d-728f-42e0-4335-08da16f4d0fa
x-ms-traffictypediagnostic: BYAPR03MB4053:EE_
x-microsoft-antispam-prvs: <BYAPR03MB4053DD68B4CBE58062B6CE2FBAE49@BYAPR03MB4053.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: C6QKpJ9R3GQZlgDPCznGWXiWZFFaCxhNv475cqphTTK3PnM86oPrx/S+pHV+VlKC8tdWnq9ip8DDkSU3rgUcFoXgquS8qHKP0QSTe5jtp3lJZroawc9mNy5gNBfJr5XzMCK20joYWwHa96XJaUGmLZX+wgQQoB+78TIaZ6mt1MzL0dWPKvSTdKVpt7NPJOsXSYVV7+CijipS/ojgKbirea+jhZ6sC+M3ToPREOjZ1g2RgqIVKW+WmfA+UfOZcYckFgA/pbGWX5rVq97cnOS/xaz0hY4l8KnwwYxyBYijdScAgWq99oskY3/vUDkHU2PFUOenmvGqJxbWMZZiJPwCgEFc/H4jwNHLZaCaTDKjw4IDDJ7+7E3Ft3xccPV/iotWMp5GoaWzqPVz7WZI9Rdndak7gea1siYv5Ua7aSId/a06vlIKEk1ZAO8P5F4t9PzBB/7jdR8qPUOlwYWedm8eo1bKo9Xv+/29EBpOxc+3slBeeM7Wa5N+OyVA+bq2oYUys6Ibya0lhG7KeC1/gQ0xv3RqUiucw7NnIM/HyOqww0vzoZMVA+E/9SWErJes4mYySnOaT0Oky4KQtCEJcOeNV6xIzPeXVSZqdDaR7mOQ1FlipMp1TJqEGrQty3jYwFq8iXMuO6MaPCcmM/fQJctsf+42DX5YBnTkDl0lUv4mXJU6AAPetNoyQORWAVPMY+H1JavZwh1kV7e6EBMWbWcJMiDfbGlGQrNXQmOxssjifZxwE++0KXmDjqjs666gbYyca3PwxAIYiTvdfNzBeaEuFw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8936002)(71200400001)(5660300002)(36756003)(66446008)(66556008)(64756008)(76116006)(66946007)(66476007)(82960400001)(6506007)(508600001)(91956017)(53546011)(6486002)(6512007)(6916009)(2906002)(316002)(26005)(2616005)(38070700005)(8676002)(38100700002)(54906003)(31696002)(186003)(86362001)(122000001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UzI0Ujk0RVJDYXNIeFVyM2NuUzh4ajNtbmVvUjRIOXdBVHluYzFsUS8yYWsz?=
 =?utf-8?B?MjFSdkQ0RVp0cFdhQThSdkZibVpuOW9JdktIb2x6YThCZWRLZVQwanhmdDQ4?=
 =?utf-8?B?cS9IRU1nV0E2ZmRaZEIxNEtEcFVpRDdYQk5SZTczeHM0OWV1eDNPdTYveTR5?=
 =?utf-8?B?STJoYnVXU1R6bmJSendMLzZiaTdkOWtnVTdQbVlDUVlncENhcEdXL25xa3Nl?=
 =?utf-8?B?b0hIWC81a0dMellCTTUrLzNpTkdteFdqL0x5enlGcUVDUElzejNHZ2JoU25r?=
 =?utf-8?B?SVNPcjlRTTcxVzc0dmZMbFJNbGk3REMvVkNlbjV3ZCtGV2JBNlBEQzFVUFQ4?=
 =?utf-8?B?K1lUWGg3U2NFVnR3Z2hmRDF3UER6d000dDZxWkFjQWZOSzBnVmFtL1dmTUI4?=
 =?utf-8?B?Q0NXYWx6Y1loS2t5SmlRUldzdHNNL3FXTGQweXdkZ1hReC91dEp0OTJzU3Z2?=
 =?utf-8?B?dVpZTjBWYmRMeG1zY2xjNy92N1JwRDRUQWF3R0paaGU0eTVpZlVNK3UyU2dB?=
 =?utf-8?B?bHpkZ1V6R3FtVFpkWURVMndacjltV0QrcGJZU2U0UFcySkUrMFlKWEpubHps?=
 =?utf-8?B?NW9UOEVMaWZENTBGVkJzUzVpS2laNEdJeXZsQ3ROTER5NHlDV1VmSjFXQmJE?=
 =?utf-8?B?VnNYK0FINUFPdnI0M0FUeEFRRXpvVlIrWlVHUnZ1SThDc01KQVVjTW1UQVc4?=
 =?utf-8?B?WjdTSzBrMENyd3pHVjBLVVBWTnlRY2RQVkM4dzVwZ1piV014ZnZVdVpXektz?=
 =?utf-8?B?c0lmeU9lKzJ5QWIybWFsVVdpNGg3ekZsTCtpZWIwUW5ST1g1SGJma0ZvZUs0?=
 =?utf-8?B?SzZWcFdCV3F0Tzdpelg4djkrdWVzWUNuRk1DUG0vSTZ6aVZJWjV3bXpuTUEv?=
 =?utf-8?B?MjdNYjN2ampIVWpWT1hsM2RDTVZwaVFKT3hUWHBqMmFOU25FMzVIRW9VcWRO?=
 =?utf-8?B?dTMxaXVTUUM3QitzOXhpNm9CL3EvRFF5bzMxdnpPVnlNMEtSakNFeENpbklQ?=
 =?utf-8?B?dmtWZVBxcGxTem41L29uVDlLSnZkSnJRRENsOWEzc0tBc01EUCtHNGZpUHR0?=
 =?utf-8?B?Tlh1Ni9yQ2h5aFFQMTdKWXdDNFo4Y0hKa0ZQZDQ2STVCNHlCTktvVU9ISXp4?=
 =?utf-8?B?cU02QXZkSUVSNnZDc05VaERqTjBkbFRVRFhTdHpaMFUvelFhUHFKOFhoSUdF?=
 =?utf-8?B?WkRqWDltSmd4OTgrRStwNlJKYVNaenFVcWRSYW9JcVQybUdhN0ZpVXpTUkxa?=
 =?utf-8?B?SjQ0bENlZzVaRnFWQ3UwbzRzRmdIWG9ZbDV4QU5GYTM2eXJTSFBiK2hyZXhp?=
 =?utf-8?B?eDRldmV4akdsaktpOCtsU2JaU3dpclFGeVQ0RjRZdWhsVy9ScDFLSHFhWWx4?=
 =?utf-8?B?dTZ2ejF4aWhFZ0dmWm5rQVIzQmo3NEdPZFUvTEtPRFJyZlFQTzQwcnNsQ3k1?=
 =?utf-8?B?bFBjNWFDQmJVdTZTMFNwMk9tOGUwemxKV3lVQzJvcktRM0VWb3pIYjliNWJW?=
 =?utf-8?B?SnBYVGRQL3NsbSszZ2JBREovTzlVUDVKdXFSMGJxZjl1M0VXMDFCa2xDTTIz?=
 =?utf-8?B?dmg1b2h2QlYyTkcvOGJsL2UvUWRiVDA4L21jekk4WjN4eGt0M2w1dVkwNFlp?=
 =?utf-8?B?UHpQMHY1RVg2bGNOVGxKcVFZK2k1Znp4RGVVb3VEUE5XTTJWQzJqdklyRXQ3?=
 =?utf-8?B?OW11WTdTYzZYSGZEQ3I1TUF0Qm40ZStCT0tBdVo0dHBkdHpwL1FDYmFDdlNv?=
 =?utf-8?B?QS9XY1dyOERZVko4YWtIQjMzVUwxY01oMmppbzUyMTFha2FES1hocnpIZ1RI?=
 =?utf-8?B?dFlpbE45allQV0orS1VtSStZWG5XUDlQOCtZN1lYU3FmQTZQTTM2RjVNK2V6?=
 =?utf-8?B?MHY1WXRUbXFOUDBvWCtHMDVxbWdKcmszRHcvU3ZQYWdDVDg1amNsOHVIU3JO?=
 =?utf-8?B?TkFUd1ZyL2c3WkNJTHpkM21NZU13Qk1CU1hFVko0bWNkSTJlOUFWQitpc1Vi?=
 =?utf-8?B?dG1tVmxkNjBBcW8yV0RoMHdwZ2kyMlJDM094enRqVHBuWW5oNExML1JDRDk2?=
 =?utf-8?B?V0dKRjkya2hQcm1jdEJtbEVHNXdSaHZOS3J6azlFdEZIQkVWM1d2V2R6M3F5?=
 =?utf-8?B?Y2dRaW5nNkhPd2NUaFduUi9lR3lnTXc4dm5xbTFpdlJGWEY2cVF0NWRBUkZx?=
 =?utf-8?B?VTdKTE5lR3FOd0gxdmNFZjdnTlJ3WVBnaGxOdEJKaVJsSFJlaWRDdUJ6ekd4?=
 =?utf-8?B?ekp2NjFTKzhxTzZrZHo2NXQrREJFdXBDQzBhdXRxcGV4bDRMUjNWa0s1YkFO?=
 =?utf-8?B?RmlXWTlEZ1RxRFg4L016YXRTb1RzcTlnNUdadEdhWVJ0blNTYU9PZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <20DBD78B44D1FD42B5F0208E0BC3100C@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45fb3b3d-728f-42e0-4335-08da16f4d0fa
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2022 11:09:55.9146
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QHOJfAiLICxgpUufv4Ap3HeL4a9cQUE2DywmcoiNSZjDqSQddt7foJl4H4bMVEb962b6zLLWO7xeymkNuPGXd7MyfjiNGe6N4q4Eay1XO0Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4053
X-OriginatorOrg: citrix.com

T24gMDUvMDQvMjAyMiAxMjowNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA1LjA0LjIwMjIg
MTI6NTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwNS8wNC8yMDIyIDExOjE4LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAwMS4wNC4yMDIyIDE3OjA1LCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBPbiAwMS8wNC8yMDIyIDE1OjQ4LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4+
Pj4gT24gMDEvMDQvMjAyMiAxNTozNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPj4+Pj4+IFNl
dHRpbmcgdGhlIGZjZi1wcm90ZWN0aW9uPW5vbmUgb3B0aW9uIGluIEVNQkVEREVEX0VYVFJBX0NG
TEFHUyBpbiB0aGUNCj4+Pj4+PiBNYWtlZmlsZSBkb2Vzbid0IGdldCBpdCBwcm9wYWdhdGVkIHRv
IHRoZSBzdWJkaXJlY3Rvcmllcywgc28gaW5zdGVhZA0KPj4+Pj4+IHNldCB0aGUgZmxhZyBpbiBm
aXJtd2FyZS9SdWxlcy5taywgbGlrZSBpdCdzIGRvbmUgZm9yIG90aGVyIGNvbXBpbGVyDQo+Pj4+
Pj4gZmxhZ3MuDQo+Pj4+Pj4NCj4+Pj4+PiBGaXhlczogMzY2N2Y3ZjhmNyAoJ3g4NjogSW50cm9k
dWNlIHN1cHBvcnQgZm9yIENFVC1JQlQnKQ0KPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBh
dSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPj4+Pj4gQWNrZWQtYnk6IEFuZHJldyBD
b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+Pj4+IFRoaXMgYWxzbyBuZWVkcyBi
YWNrcG9ydGluZyB3aXRoIHRoZSBYU0EtMzk4IENFVC1JQlQgZml4ZXMuDQo+Pj4gSSBkb24ndCB0
aGluayBzbyAtIHRoZSBiYWNrcG9ydHMgb2YgdGhlIG9yaWdpbmFsIGNvbW1pdCBkaWRuJ3QgaW5j
bHVkZQ0KPj4+IHdoYXQgdGhpcyBwYXRjaCBmaXhlcy4gSSBoYXZlIHF1ZXVlZCBwYXRjaCAyIG9m
IHRoaXMgc2VyaWVzIHRob3VnaC4NCj4+IEluIHdoaWNoIGNhc2UgSSBzY3Jld2VkIHVwIHRoZSBi
YWNrcG9ydC7CoCAoSSByZW1lbWJlciBzcG90dGluZyB0aGlzIGJ1Zw0KPj4gYW5kIHRob3VnaHQg
SSdkIGNvcnJlY3RlZCBpdCwgYnV0IGNsZWFybHkgbm90LinCoCB0b29scy9maXJtd2FyZSByZWFs
bHkNCj4+IGRvZXMgbmVlZCB0byBiZSAtZmNmLXByb3RlY3Rpb249bm9uZSB0byBjb3VudGVyYWN0
IHRoZSBkZWZhdWx0cyBpbg0KPj4gVWJ1bnR1L2V0Yy4NCj4gT2theSwgSSdsbCBhZGp1c3QgdGl0
bGUgYW5kIGRlc2NyaXB0aW9uIHNvbWUgdGhlbiB3aGlsZSBkb2luZyB0aGUgYmFja3BvcnQuDQoN
ClRoYW5rcywgYW5kIHNvcnJ5IGZvciB0aGlzIG1lc3MuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:15:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:15:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298738.509018 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbh9y-0007Fc-Og; Tue, 05 Apr 2022 11:15:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298738.509018; Tue, 05 Apr 2022 11:15:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbh9y-0007FV-Ll; Tue, 05 Apr 2022 11:15:42 +0000
Received: by outflank-mailman (input) for mailman id 298738;
 Tue, 05 Apr 2022 11:15:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbh9x-0007FI-Nm
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 11:15:41 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b8e12469-b4d1-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 13:15:40 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8e12469-b4d1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649157340;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=HXpyLr73oolKs049QQ+QdEIBjDkYuRvvACRlzUVrxfA=;
  b=EaMJR7KZ78xFIk5yeIeyKo2+SbZGbW8QUVqI4hDf6FjOW4lDrsrnOx0a
   MYTchRIQHz+bjBgIQWlQurCp43k6oNrL7TYgsRnL2MESblA6bCvPPiEHC
   gXdkH+3CBUNFHmDqWONMRffzEYEB1kRs4gMy4ok00ynZeIyOkU3XqjMAR
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68439635
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8di9cK+RQxIGDwevr4sCDrUDkX6TJUtcMsCJ2f8bNWPcYEJGY0x3y
 TNMUGGGO/uLZDagLY93bd6zpB8OscXRxtRhTAFu/3g8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YDkW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZyraz0YZ/HupO4ydCteKB5QYIF896CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4eQa2PO
 ZFEAdZpRDHtPDxtCHNJNJkVu+up2VD7XjJcmE3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0W8FyKdxjtCOxwIXz0QCiOUZZYgROd4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPTt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP+D2BLwQKChRqlEGp/ZgPc1
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGAmfh81b5pfJWOBj
 KrvVeV5vsI70JyCN/EfXm5MI55ykfiI+SrNCJg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3C7SkOHSIqNJNdjjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu
 Hq6XydlJJDX2CWfQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:0gpGqagPb1a61aI7PxZHfsGgn3BQXzh13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKOzOWxVdATbsSlrcKpgePJ8SQzJ8+6U
 4NSdkaNDS0NykHsS+Y2njILz9D+qj/zEnAv463pB0MPGJXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhMY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iGnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMw4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAkqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocbTbqjVQGZgoBT+q3tYpxqdS32AXTq+/blngS+pUoJgXfxn6ck7zU9HJFUcegx2w
 2LCNUsqFh0dL5kUUtMPpZwfSKJMB2+ffvtChPlHb21LtBPB5ryw6SHlYndotvaPKA18A==
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68439635"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bpb4nAxeDq4x7jlq8eiStzxkBiEiV+5c2mcKIv9GdwSpNxbfvFplYd0VUgCwQaTqzxlbY5lK6xlmkFdua1Dh7Ywq/DPEryLoFJZvqvrbK2/d/sGuVYzZ3P1xQv0c9TfKyPWT1VHMhoXCVl4SAZVdxDgI66xG+NzPmiNohVmZ5Q5+pXlgyD8EMJakjYOhof26rCbqxRndinP1xfBE2Mj0aV22MNTnsOQyn9ltO6Ai0TqMbRGsVlxPPYZvvlF9B787iVNm2fCwAgqMCQ11+ZvQOcMhHfKyxNbQ8wK76qvHhLIj/wGSApsfgouv+Q/8CoIH2lOuOJZIip4vXMY3SrvJpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k6EJDPZugiWLi+Ep8msk1uJIUBhvfLF3g7PGp7yy3ps=;
 b=XcCumUpPXgng2p4HUTgoAF4oEwMqGC6/siJwX9HPN1ofjAxzANv2Sg+bH+JuXRJs4EJt/qoFZmy8DBLaaikvAPbvQjQDQiDnfIaNQJ7K+rHP1xk1KUy5iO2PJvGw1wgUfhmcfbisDs5jhQ7SpHVAJvmLpgTHAdBJul+apJiOYCBFKPQNi1e8+Qz1iep2RvnHSDXUAD2/lnOvRmtYRJQNObruBov525zhPxuXpwzLN9c1Sb11K2ZplLK9lwMkWZq5BQ8kpzIWHG4R/tcv6Yu5tf+CuhzFTAizN2uErqtszjKfPqxf+CLrDHoQguJ8Zhdj0zRQYF8mVkCS4DyjOjlytQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k6EJDPZugiWLi+Ep8msk1uJIUBhvfLF3g7PGp7yy3ps=;
 b=LAUvsiGPKnfNomVmBsgFkSzD3mhtT/23PJfBfs+W66PDPwQiV1eXwdIXjMyb7XmGduws4eT8tVlTAhS7WjTDYDN/irNEzaI1oSrCwxKKwx2x3BUAHuGrDftVEQ9KkGus1uSZQ8VFGvzyXYI1gFgwdBAI+7VoezZoBSByxZqRpNw=
Date: Tue, 5 Apr 2022 13:13:57 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 6/8] x86/boot: fold/replace moves in video handling
 code
Message-ID: <YkwkdZ8wRrmRfQvH@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <8b66f631-18be-7819-7982-c56c03220595@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8b66f631-18be-7819-7982-c56c03220595@suse.com>
X-ClientProxiedBy: LO2P265CA0456.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:e::36) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5e8f466a-f772-45e0-4a57-08da16f563c9
X-MS-TrafficTypeDiagnostic: MWHPR03MB3087:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB3087999F0A5A48E3843C12F98FE49@MWHPR03MB3087.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BjigY48Q6W0OIhDduuVV5YZEtnCuurhqHCPq0YqvVLCPundnzbfkUbRoax46F45QjWwtiWTgH7mmN51Kv9n/6VJIMlt+E62Gcpvg3q2lueI1z2Vcptmk/eypFwXEycD2rjio0zNWhMAk5FkfsNZXKnb8ZrG340e6kfoquZwM1TpRAX88Z99sW5uUrs3mndEN+ltCVdTR9E6FmyXSbD5f8xTkt8ilfaIzY9MrSH3+nh6I+VyA0A2/fBRpxT23zPsEEqskLtwqi6oYqSzVPWciXAIBP7DfIjFCS1VJD3MTO46AKuKy1T5jHfwx7sfFSRrxQ6mazqnTvhOcmsXR5yphYCA21RB5w+JerVnLaxLRMSyiwN/5xwRV+I0SxPcZrk/J+l0X2n+5V2w5EVJTmfzTggzIpcS5/Jq9n5Hd2WLvDfHvRhPlLybLkFuL7G4fYNY9gHyD1/LHhAkvW4aic4DoCbGZypDZZjBl9cDNHr73Ezrc5nfqk3LxKU5+VQCkcugqUR+HnB9aCX5s4smG+KJCq6PQzmlI4CsSI/JpEq4e1+T5BKBHhdOMqo4LeaBj8kRmj3c3bUylgAM/oCqM6MUqYHgkFZtEAomoFFkZnjAV6yuAKDQGMhrWbj9q7yCY4/BbOv4KC+IxMgrCVO0tE/MrQQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(66556008)(82960400001)(316002)(54906003)(66476007)(8936002)(6916009)(66946007)(8676002)(9686003)(86362001)(6506007)(4326008)(38100700002)(6666004)(6512007)(6486002)(508600001)(33716001)(85182001)(186003)(558084003)(26005)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTArWVRlL3ZVWVVneEd0U2NjM2JIdVBOVG81RTcxQlhIQnNoeGdWdEs5UnR0?=
 =?utf-8?B?S2s0WGpFYUFVOUhrNFExRDVTQVhZSCt4UjNGaHRqcWdybEJkb1l1Z3Z1aUMw?=
 =?utf-8?B?OFYrLzdmWTFYT1ppNHdaK1JCL1RaVzJmd2YyU09CVEtCVmxUb3hab2xIeWNx?=
 =?utf-8?B?TTVuc0h3V1JPM0ppWU95NGQzRm1sVGNLSW12TU00WVE5YjNKNDFPTjBwOWx1?=
 =?utf-8?B?NmNwbEE3MzRUcjl5bGgzUnhyUGd4WHpFZktYTDRTeE1QSUpiWTNpTFpIdWk1?=
 =?utf-8?B?RkRITFBYN0ZrcDRtTEpabjFuSjBqNWI5MnBJNDkrdWZnbUFLYjFOWW9uVzho?=
 =?utf-8?B?L3J5cURlV1kxV2lHVUtUWTFWd3JUMzVBa3N6T1hrbVJYYURSd3RRUTd4bm9L?=
 =?utf-8?B?SU1MS3hYanlQSDhMSThOb3E0bFkyckNIOUFndXB5dDBLZmYxL253S0Q2UTRp?=
 =?utf-8?B?OVJLQjJXMVliK2o1WlFhdEoweWxaeDlqL1hGU0V4azZwbW8zMERrdFBJRlc5?=
 =?utf-8?B?SkFlUEE0Z2hjaGQxZWdKSjNneXdDYW50c2VwZU5wM3lsVFI1MGdLQitzQ1BS?=
 =?utf-8?B?OGdaUHVrVFBwMTlVdHkxSGxPRDErdUNJVGxURk41Q05IN1BXdnFYNUlEQyt2?=
 =?utf-8?B?RndVUGZmRlJ2cVJVWlhvSmw4ZTVrbTRSSkVZeEQvRktTTzk5a1pMN0hyWHNn?=
 =?utf-8?B?anFVWDF0d2orWVVKRlVXNzNtb2JxY2NpbDlQNy8zL29qWld6blo3Sk10dkpq?=
 =?utf-8?B?ZS9MUW9rNHBtaWtnSWptc0JIUlBYd0d2QlFSTE5RTVpOVHduMjRWNWU0QWdZ?=
 =?utf-8?B?OHZodUxKZEJOcU05bndzMThzY1Y3Q0h3ME9LMkRNZ1U5TStqVzZ4YmdKdVp6?=
 =?utf-8?B?SHBVZHZUc1VkaUlZT1J5c1lWQ3VBNDlrUktVRGIza3l0dkZnVFo4bTFmeEdq?=
 =?utf-8?B?ZTJGcmkyalgwallqcnJOSXNudzlFT3F0TDBHV3draXVBMHFGRThtQWFDTjB6?=
 =?utf-8?B?c0VEUm9NeUZMdlBsb2ZPVUFId1FGNGkrallncFQ4T0ZKalRZYnBMM3VjQU1D?=
 =?utf-8?B?UXVKSzJiT042SGx4RW5qenpoNjRzY2Uzd09vZ3pwNC9iY2ZNelhUK0JLcTRm?=
 =?utf-8?B?WlEvU2M4MHhsUVJ1bXlXRDZTSWsyWGlONHVLVzVtdE1JSHY2cTMxZ1dIZ3dF?=
 =?utf-8?B?aGFNTjRxTzlxeVdLUm5DdUQxalFiYjY5eHU1eGY3d0l6emNtTVF5ZGxKK0ly?=
 =?utf-8?B?RG5Yd0FpT0V6dTlCcVRaQ3JNL0lNQ0tMMk1CWGJlNTR5Wk9qMnQyYVh0VFFJ?=
 =?utf-8?B?QU5IaC8xWmR0RHdtaXBGRUFKWlBNd2dFc1VrQ1J6dCtWRUtiaUY3TW9rYjFU?=
 =?utf-8?B?V3hIQ09hNGR2OXFPRE9rNXVDcXF2U2xMa0dPR1J0ZlRGUW1uT0VhK05LVFly?=
 =?utf-8?B?aVBNTGZKSkE2dkdjcnJ4TkdjVm5BUzVUb1BaYVlxOWxOV2U1cm1JR25STk9G?=
 =?utf-8?B?WDhLNnorcjAvckgyeWV5OTJQZDVXdERuaXlKa3V3RDVXQjRWVnBhdnhWeVRr?=
 =?utf-8?B?T0NnRmZsR3g5YlhBYVNFd2lrWVQxSzk1R2NKNFRGMnRlK2VNRXU2NU1OeTQz?=
 =?utf-8?B?QzRvT2FiVklLMUpnQVU3MFRtaVA2Z3hZOUVnQjlvZndxUk5jdzBIUk1IUnRF?=
 =?utf-8?B?YWlUenBZbUVOM2FWbGVuMEdVcWRVZExJOEZCNVRmYXJ0OS9ta2VkK21qK0o3?=
 =?utf-8?B?YmNnTG9rdEhXQ05tdTdMb2g2WUlDTm9zcUpjYTYwbHF0bDJyQWRWRnJCbEFO?=
 =?utf-8?B?d0dYS0FjNU0vbEN0M0MyQVJjcnFSUlNtUkZvUDB4emlPNCtzT240VVVKQkpF?=
 =?utf-8?B?RmsyTEVNNVF5eGNqNTlYNWYxYnlJRHB5ZnZvTzRRZXlRR3VhMzhVRXdUZnJo?=
 =?utf-8?B?Q0d1b0lid0d4cm5Bc21jdTY5QUxWY1c2czBnbkNMZkJCTFVCcmlzY1Fpc3FP?=
 =?utf-8?B?b0xUZUJ6N09wL0ZIOU9SQUUzQlpwM29ST2lLbnVFU2J3ZmQ2MzZtQ0wwSmxE?=
 =?utf-8?B?R3FjMXB0NjhXT1dWQzhLNTM0NC9HcCs3bkRVMWN4MkJ2YW5XUGhVK3VUbHUr?=
 =?utf-8?B?OXZNYU5sZDk4dUdNSXRWREdlUGxTR29zbFppVStxcUNFcTc1VDhsZnlJcjZN?=
 =?utf-8?B?QTVaSTZ4NTJna09EbzQzS3ZIZlk4NFA3a1IrdjRqck95Rnk0TnZxaXdxZzlN?=
 =?utf-8?B?N3diRi9WNzdUYlZGMmxwNkdMT3ozbmlZNTJlbFZZRXJFVThJNmZqNFpqMzZi?=
 =?utf-8?B?eVJFeCtDUk5jeHRhNlk4S09nQko4TnpwK1ZLVFp0Y3ZLcnFDMU1xUG8zcThB?=
 =?utf-8?Q?gJ8F3xZ6klThli5Y=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e8f466a-f772-45e0-4a57-08da16f563c9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 11:14:02.3906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y/r1oW/2/N0pp3ZQTgIxPauDwyfjziuXAA5SSW73Se8M1mM/OMBKOTfkHe6nmdpubRuPiJV+GNwp7hgixCZRzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3087
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:50:00AM +0200, Jan Beulich wrote:
> Replace (mainly) MOV forms with shorter insns (or sequences thereof).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:29:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:29:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298744.509030 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhMx-0000OW-4F; Tue, 05 Apr 2022 11:29:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298744.509030; Tue, 05 Apr 2022 11:29:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhMx-0000OP-0v; Tue, 05 Apr 2022 11:29:07 +0000
Received: by outflank-mailman (input) for mailman id 298744;
 Tue, 05 Apr 2022 11:29:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbhMv-0000OI-Si
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 11:29:06 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 981fbab8-b4d3-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 13:29:04 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 981fbab8-b4d3-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649158144;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=GmuU0Z5fI5ZUI08YEiKarVgFZxOXiN1qCT/YZ3XK3us=;
  b=Mher8mFHW/738Tgfj4CYSA4NU+Cnf5UNYpgwar322kb3FbMR3LPlznRJ
   FAN4RjuQ5p/dpxE4bKzE58riuDq3oGXoYGDaEnS9kz3f12kqeqQhB4cn5
   xncxVQ1TYK8kPfLyT3Fkyts/tJgnS0WhzFTPr6WoqsrfdDFqev3LTQRlj
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70429976
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rFkgV6OWrseNLK7vrR2zl8FynXyQoLVcMsEvi/4bfWQNrUolgzJTm
 mMdXTqOM/iKajCnc9F/a4mz8RsPscWAmIVjGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 fpS6pqLVQwQMKDvtus8YRJyDXF3IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwg29s3JEfQqi2i
 8wxciNKfE/GeCVzBng8Cpsjuva0pFzQSmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq
 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlaBkQFDXeFMGNQ05SKjxYvm6CyHVmEbG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnFI4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1gRiG2NPdXABb3nARBodtvxor6p5
 iVspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/LNgKuG0jeBw1bq7onAMFh
 meJ5Gu9A7cJYhOXgVJfOdrtW6zGM4C+fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPRkk8FDbKnPneMmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcBkTITWVWvxd22V01e
IronPort-HdrOrdr: A9a23:S8YFPKrnUPOCrgSUauCrAvcaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2+
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LvEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqMq+SWnqLkwxg1MfgOBFBh8Ib1S7qwk5y4GoOgFt7T5EJxBy/r1cop8CnKhNP6Wsqd
 60d5iAr4s+PfP+XZgNdNvpfvHHeFAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="70429976"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O1aJ04XmboW0LwDpMzfTTtznAegMaRyj68tfBPkxkl/jA/OLg8VA8gmyfdc75sttDW1UE0xZVoz/VHc3UT3veAyqdpDGyIrdct6K1KYXiJH4vpgK4TiXcjeZmYdwDlYPx4X7TsEuPYm74RT2huOLxibvmYBVpJTkxOF4585FgvJHPqRddGP299RWcLy7LC4CiT20nI7srHJgFDZO/6BRF5CtgLb28EPxC3SwJp+jyhKK53kqeLQDZ2UbatIb4CKF242EB8wHiUpQxuagZDhAnFAQzuqeZtM7VkhqhJzrKSAwf71lIcIz2x/lMXKd98V7kLV6/2m910icRfbYoB3ngQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RY6uMT8CuzNAMGleFkZNbPvtccNg9iX4aoZ2+tD5o4I=;
 b=Dw5jbQoX+Bh2psvHA03CPhUVpxoeSOgoEXAhydnNfGUuWlBZFU5ygVqXS4cnwArO3VeIynQcMm+I2Y1D7RxXLx+Sm9IniaHWbkEyxTamiFat1MSO7vlaHTY820bbnrjjA7RZb9BqyUAjgnd5k/Rd+vJG3IV77ljZZGstsI1WFZmZ6TiUak2gwDasASvgkYsi/Vz1j7ekkPHxkuy7VBOh7zwZ6oC3smdEFQ9W2Dqhr3Ex3QTUWbQkaNWb1w9D4RrJciwWd5dCWYSm5/842gwqz15BoSgGIuGo4sSAK4I4LQB4udiRPCNY4D8jhpS6tZwzzv01/hHgaJjMceoc2jLmmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RY6uMT8CuzNAMGleFkZNbPvtccNg9iX4aoZ2+tD5o4I=;
 b=fmsL8bYBXVDoabqs5VKWIwQ7Er5wAVE5OumXDoK15f1VP8UgVbu/EsId4GHwQn7KuZ0xxqv0oKIIiLazIj4iyzibmPPgcWl4Q18k820iRVW0IJFHR9vd5msd7XN2nZiCRXrIWcVTVSnWGn3tAc6LSrJ2C/KUx+/0484po+bzDOA=
Date: Tue, 5 Apr 2022 13:28:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 7/8] x86/boot: LEA -> MOV in video handling code
Message-ID: <Ykwn3dVVAtTkz6Zx@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <48666252-a448-9c17-cacf-2788fe1a3c17@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <48666252-a448-9c17-cacf-2788fe1a3c17@suse.com>
X-ClientProxiedBy: LO4P123CA0185.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6d7f044e-0e43-4563-c84a-08da16f76b88
X-MS-TrafficTypeDiagnostic: DM5PR03MB2475:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB247502C3FD907D89F6D0E9458FE49@DM5PR03MB2475.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: q+v6AjhJ2Mkjovc7CRKGMQ2zu4fvbFL8L1MrKaUNxd+Zr5Cpc54BNYz1h6J66FFGocGuMmLFN2ab0qHDX0pVvQenipRCT/lBRqgWIjRZQlsQsv0SAwAxSKy5gal/ohdm01uIPgZWQID1z902KPX2GAGlAEz78lxpPuWlKqMO3A8H7AhlpwnaimctGpTwu1uIbv+pIqlksf+YTzPjUe30gda7xkQmkq2oy0cDIS4T884hMCKc8aWbZdrMtiN6Yl3WBnZng8IaIR1gGdetOxxf0S3A2LLkYGSfz+5B2MGqWEojh6fLNZ9Y+8xug+xT/CaWJ2MNboVqQGmtgE42Jr2lq4JEOT+fqtv1XQI1/6cP383Ops01rkI2k47Kn8YizCCYbb/29teFuDkmXzRc2AOW445PgvKR7vclneec+HTUfN45wFOHD1bf5lOO+kiJOJXs582xRfp/M4cXgRENRGkQUT4wwvYHeszA/Y3Ep0051Qd/2b77Pgbpi64ZqAAvZwSNLm2UuwVlWGXnzXDtY3vbFrI7H1UwFkhOZvD9kA0ahWth11laobwIWQqNRej91wvmv3MWxsolgQE/4t923ei2pB/lRWr5KZ9xjzs83M/I5PrPIFCjbZWjA8Se5C751IarMMXmyO/RAgmUpcNikyjG4A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8676002)(4326008)(66946007)(66476007)(86362001)(2906002)(66556008)(5660300002)(82960400001)(38100700002)(8936002)(6666004)(9686003)(6916009)(186003)(33716001)(26005)(54906003)(6512007)(6486002)(316002)(6506007)(508600001)(558084003)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SElIdjlXaGZIVzhMNEhHbThnb29vRFFYNWhhMTVtWnV6cHNDTlh2Mi9zWWF3?=
 =?utf-8?B?ZHkrZnRBRGxiYVRkZVNEc0tBcTlHWmVJS2xjamxGUEJ6cklLY3VCbm80UnRO?=
 =?utf-8?B?blBHOHhRcm9zdVRadjJHR0QvblU0WDQ2d0h2VmVxUlg5bWRiZnNQUEJDajVo?=
 =?utf-8?B?OXVkVTJQQjVqTE9WQktVRzBCMDZSVXdTUUcvWXgxMkJPcU9qT0JzeXVTc09y?=
 =?utf-8?B?aVBIMDJ5TWx6OTVCNzljSXFSem5HNHVsR0c0YmtWdHByQlpGYWhET1lmRUtK?=
 =?utf-8?B?L05jUXU1cVBPanRrTTJTeVFkdFREdnVhOThRbHdhaWlUbFQwYVFYTXYwM01I?=
 =?utf-8?B?alRpK3BTSlBYaHF5RXp3SkFQd0tkY1hUZnh5V3laTFc4TitBeCtWZVVWWTMr?=
 =?utf-8?B?YTBWVis1OTVlbHQwaFo0ZVdZbmlhUXhDL1RqUXFGWHQ1VTVWbEtBMkFKVGZG?=
 =?utf-8?B?eC9NRUplQnkwWEh2NlM0UEdBWTVNR2xPeVZuMktpRTdjY2Z1bWkxSUhNK1E5?=
 =?utf-8?B?WHNiVmZFdEMzZDdwUmdTeUxFMmIxOEo1UDZ6WkR5dzhQcDBsY2pRL2xWcmty?=
 =?utf-8?B?VkxPRkZEMk5KOHB2V3lmVUY3VjdqUW8wWE1vSEFvODVCL0xrYno0ODdMUlgv?=
 =?utf-8?B?QlBnbkZKR3JnYzBkV3VDSWQ2ZFFNL3g2clZBYm9tbWtvTWFEOXExTm9lNW9q?=
 =?utf-8?B?Wmxqc1hoWkVFSW5QM0xZb1ZSUlk5UHNzeExOWFZ3Q1Y3a05ETyt1dWVlN0g4?=
 =?utf-8?B?N1hlRWRtKzlzMXFQa0poYVJybjZHcUZYdU1DaVZUYVVnOGRnWk9BM2dVQ3Fq?=
 =?utf-8?B?bWpIaXpSaFd2NGJoV29JaHpTb2dJMW9EajNJME5JMHJZK3ZBbHpIVHBySFA5?=
 =?utf-8?B?VjRCV3F4bEJnRXpJL1E1a1lRSTI5MkpFc3UwN2VtYlZkVFl6MnNJWW43QmVT?=
 =?utf-8?B?eUNlcW5hL29HU2VVdUNrQWNXQWx6cktpVVBSTzhmMFpCZm9OUlg5WHFDS21Z?=
 =?utf-8?B?RjdFT29UL0lyQjhGRFNJWFllNkNBUXRzeDd0NUF4QTRsanovYzFOeGVKSUhE?=
 =?utf-8?B?UmY0NXR4Rkt1NXJNck1ldFpyVjkxeWdLR0IwVncwNXpDVHh0c2pPRzJXaHRy?=
 =?utf-8?B?MWxMS29ZU01DVjNhSDJXdGNuNFN1RjJDZ1oxeVE2amdsOU5KMnh6ZGErRCtW?=
 =?utf-8?B?NGRyczAwTmtlRWZ5NXhZa002dkF2ZitQeXdtaUl0VkpadWVOblV2ZXRwb1kz?=
 =?utf-8?B?MjJHU2orTTZ2ZC9qVFBUOXZKVURCZUlTb2xnWkNaaWpyem5Bb2kySHFSU0JP?=
 =?utf-8?B?aWR4a0ZBdERSQ05hb0Y1ZStodEl5REFpZ2dibExMOVhJZGkwUGVWRW1RODBB?=
 =?utf-8?B?QUlpWWdtNjVDaTkyTXc3MzkxNStzWG1oWGQyTlFwMXdiWWRvMDZuYVh3VEtF?=
 =?utf-8?B?UVNnTjVHK1hCWHlXM2FMMnpNdnRodHJXSzVNdFNldmNBbUVJYlZYK21HVzQ4?=
 =?utf-8?B?RmFqNWdLQ2R5Q2ptTTRmdVp0ZmdoSUQrRk5xalRDOENRUnJqL29zUWRzODVW?=
 =?utf-8?B?cWZ4a1FjeXhlUW1JOFFwSTlkYUN2QVhrMDR3R1VNWE02Z2lJQzB0RDBYY1Qv?=
 =?utf-8?B?anFSTmVmL1R4c1Nrdk5TRmlmNmt4K1ZQbWh1QjdZVlBXRFBGQms0Z3QvOGxz?=
 =?utf-8?B?R2E0bGVFUmt4aEJERHh0SXV4S2tOUkk3a2Yzb2NGU3ptMGF3WTZ1Unh5M09R?=
 =?utf-8?B?bnE5ZjFvK2VSVnhaQnlacXhrdjdnNlprUEtxTXJiYVF5VXEwUDF2Qm0xdWE3?=
 =?utf-8?B?YjB3Vkl5VlpVVXVPNFE0VXpBY0pCa2ZTZWl2NThRdGJSc2xlZlp6bUpYdk03?=
 =?utf-8?B?dzF5VDVWenRTTDExSkxVempKS0Y3bDQ1ZnpYd0R6ekgwTVRtK3JKWGVuUXMy?=
 =?utf-8?B?eHg5ZmNHT2NKWVQ3VTNqZHM1eXFrK2RPaEkvbDBEQTVJN09qOEh3SE10emU0?=
 =?utf-8?B?eE1jRnNFV3ZOeFZ2eTVBem05VUJwbnlKSHdKSFl3bWt3ZDl1SDdyNFFlaFpO?=
 =?utf-8?B?VXZXUXYwTitIZlZoT2hFTlY2Z2hnYTh3ZjQxYVZ2RjFaS3dGQXFwN0FONGtu?=
 =?utf-8?B?RWV4bm5MUXV2dk55SnVNMUV2amZXdXhOcGc1OUZycHJyWTExMU1UK2g0NFFD?=
 =?utf-8?B?Sk9YMXJ4ZkV3QkNFa3p4VXpsZHJ5LytoWU5wTi9CNjljM0wxT2phU2NOUVdD?=
 =?utf-8?B?YzRNMkRmcVcwTXhtV05aVEszS1VZWm5QcjNndmJ0K2I1VnZITlp4aUxmK0h6?=
 =?utf-8?B?V3c2YWJEa2dJUURLT2RkOWUyRTh2OWV0MDN5cFhzN0daQ0M2cnB3dUkydGt0?=
 =?utf-8?Q?d/QQelIx6qYy6oFY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d7f044e-0e43-4563-c84a-08da16f76b88
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 11:28:34.4299
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NT9lQtH0L+EGCYPwrQ/IVhHIUpxIQCbYbMq5IjCMZpk/fONSVd9ILDzIPEYplB0EJFVOEeMrjZEiUZzBWdUyTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2475
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:50:20AM +0200, Jan Beulich wrote:
> Replace most LEA instances with (one byte shorter) MOV.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:29:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:29:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298746.509041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhNn-0000vI-Di; Tue, 05 Apr 2022 11:29:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298746.509041; Tue, 05 Apr 2022 11:29:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhNn-0000vB-AX; Tue, 05 Apr 2022 11:29:59 +0000
Received: by outflank-mailman (input) for mailman id 298746;
 Tue, 05 Apr 2022 11:29:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbhNm-0000v1-0w
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 11:29:58 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7a0f7de-b4d3-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 13:29:56 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7a0f7de-b4d3-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649158196;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=13ffDLdRIQPjUk4Paeucj1VNLaXygKHYOmd5iNzPpUY=;
  b=UfyPFxAvwlaqsBRi1fvgFZZj0Y1eru6WVRTdxPNoiy6wbOoIjqp8lcMm
   Ku9wv51gfIVXp7BmXq4v7RhgiCuiGUdXTDsL+VWgRsPSBFedWrUFlA0Od
   Z2PKBC2EFcxZpJ5BmNLhapFBxQFwYtZeYeTtgYRW9M4rVyk7ayXvr72wS
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67929964
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fzKSbKIImfFCMA3YFE+RxpUlxSXFcZb7ZxGr2PjKsXjdYENS3mcAn
 2FLWWDSbP/bZzD1KN5zPtu3/EoA7ZDWxtZmTwBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY12YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 M9nsYLoTCIYAqGSteoedz98P31zPbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glv15ofTKiCD
 yYfQQA/RhWbSA9xA1Q8DLYbjdmtgWvndQQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCspDQYRYJVNtwG5F+gxKnwxSK1WmUEUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZow7eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4iDGJGT9bxgbQ+0RqmBNzEJrVml
 CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdEIumkieRsybppsldrVj
 Kn74145CHh7ZiXCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikEwFCrChO3WJqub+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwkjITWVWvxd22V01e
IronPort-HdrOrdr: A9a23:Z8pABKBWMUuh5TPlHehIsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M
 323Ls4m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUbqFh/dL5kUUtDPpZ1fSKWMB2FffueChPbHbzYfJt3T04l7aSHp4kI2A==
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="67929964"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gFG1iAEccgeH/O8c5Iyu3XGvU2LdYZSxSiy1jSzROaE2lyJMH9k+5g3YcKCy7McWvJ1MT82+DsXoaLFrdVq7M4nLO99ASJeHdZ8Ggiu49lMFGqVHDlwtlMhaHYi24MSUpAzCnVAJlc7WP5u/iPdSkljH6ryI5OJixCRUcbUrNwX5dLUt73INlIJ1TLuJHn+vuZgXylDOhw7/aGrjquqsWXqxNSC5CmnZcpvMJiZR3Vyjt1HVwJ034zUgJxIPvKZBXcK98Hgcjo2gEiZRjF4TmrcBe0vM1kIZuTwSEOTH9qYDxYf9wCU5dd47DcSPUbd7DRq0lzR6Sn2FouHSVlS4dA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/8NPjNs+bB9pmvNSng1oR8opgYiRX0v/R6xvSdtCyPY=;
 b=WKeiB34IpBIbYNQYOjxxGlBY9PaMtJ65GaNzPNl++3M/VuJqd+RpmNpFWLrFpIxukKQxf/P3Nda111Gshvc6fYhIcNMy8WJJrZFftbJ4vZ1EzBFWK/NbGZGZiZIv11BCBitmUXOnzIzWpw2kwu+vQNr3J41HJnI5n9XfTKvDf33u+NS9L5Ufcr48duKUpvQ/gxTDML6OZY9Aw+5m4akGbcdSjXeMfwRr0AY0JgNca/yrl5H1sL++OoFsGZ9bbVz3UC+5+7GSxzw9Gbu18cexGbBqz4bIdq+RN4Es89o+7TW/NZAHVMzjpg3AiCIFacO51w9N/H3Be5z9y6bBfDL29Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/8NPjNs+bB9pmvNSng1oR8opgYiRX0v/R6xvSdtCyPY=;
 b=fFieFDhoD1u9cHfpxeDUzYkHc7KnMT9FwxOBdPMVvAV3X2VzYaH95LGKKwBOAZSeZVUSN+SgZcIyDw+Q5L07OXFjwCVmkq29BglYfZpTgQZfyhIAys1PaBmYNzSVjAOCmyPyYHs2f65SkW0DDZYbay3RwZchMRtsq+3CIoi3GGQ=
Date: Tue, 5 Apr 2022 13:29:47 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 8/8] x86/boot: fold two MOVs into an ADD
Message-ID: <YkwoKzbKSsyleoFA@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <294639f0-d959-59b4-b3db-78451d5acd9c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <294639f0-d959-59b4-b3db-78451d5acd9c@suse.com>
X-ClientProxiedBy: LO4P123CA0214.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a5::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 44f6f466-0e97-4e96-cf40-08da16f79a07
X-MS-TrafficTypeDiagnostic: DM5PR03MB2475:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB24750479CCD4C2DC167CF0558FE49@DM5PR03MB2475.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aVUjycOXBOt/fZAwmEu6LUL/RSN7aYzvTelIa44+xSt+6j/upGoCfb94ca2cFkJ2FGYzAC/2enZ1lNU+0KCZtI9CoHMNIOZMtsJSMaocvg2iZreE7F4aFbk2siij+hwh/dtuc2HsfiF1HgBDD/SnktoGhDndKGqLAZmtVx2E/xYEqgo284BIBZVLSlRP4O/yBEtOZxt+pfYdEzpLKcA3gNg84ow7AX7WGGXmDbBY8luEoW7zWJoCpo1cCxkukQeKeIWn+VVfET3R/e7fhCfpK+5/0AHkE37oxrNZhV65zjcG8gJyiyBh7YjFWUxeGHfgJMoR97GVpbtZwG3yzkS7bwitx9KS4XUj7XX47GUg9XoeXLZTUV3Fbfvgi8yakKHFrHREFeW+WYHvkAUPWKGKNSbwVRdbFQD26FuyAg+z51EqsHKrwgbU290nFeb8IFt0ZZIjeWC3OeSo8p24h/p54oWP8YSOnN0Ilwdq3ZCQfEZtESWYpc6oBbXROZiCC3uyj1cVYcvg3cl3TXVRid4vOBSq9r/9EJzAKzLJgEkrvrBxu6BxKraGs/Hsn8kKp/JXAoOgdUN57uDk2YEysh3JEB4i5mz8sNvRxbEpgmnhXPPoZzd03lac5MY4VT2DmsVnou3/UAl7ke6k3QyTVaGaYw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8676002)(4326008)(66946007)(66476007)(86362001)(2906002)(66556008)(5660300002)(82960400001)(38100700002)(8936002)(6666004)(9686003)(6916009)(186003)(33716001)(26005)(54906003)(6512007)(6486002)(316002)(6506007)(508600001)(558084003)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnM0THdlSEJzL1lKbGltQTBHRzZPdVNaWHRoZWpORFltdDFMN1JDblA4LzNK?=
 =?utf-8?B?Z3ZxWlR3TXhGVFU2R2RTL0tSdXVUUEZ1akVXN0FqL3cwZkZmdzFtaHBIZE5V?=
 =?utf-8?B?elFMbklDVEZMYXhxYy9MbThsUXVwZ0hhellMdlhCR0dhQWVnb0dkcUdGOWhE?=
 =?utf-8?B?WTdWNzBVeWdTZ0xOczExbXYvVWlyRUh5cmliL2xTUFlSVWR1REMrUWhpME5l?=
 =?utf-8?B?dVBDZVAraElQazQwcCtrK1FuQU41Vi9zUFA1UmRzYzdqRExKVHNaUFhCcTBh?=
 =?utf-8?B?bDV2NGorNjQ2dWhEeHptV2FxdEFxM2V1a1lLWUhOVit6VGtVZ0NlQm5PZUlt?=
 =?utf-8?B?dS8rK1pycVc3bTdIc0dQeURidHhTbm5pWld0K3FrdFVDWno2VWs3aVYyRmFO?=
 =?utf-8?B?K09wVkJ3T2dwTHhpMllnR05oWjVhSlN4U3AyWGowajNmV1FiT2phR3RORlRz?=
 =?utf-8?B?VGcxL2NHSThyaXdIenRvM2hBd0h5M05PbkFrcmdGcFZXSWhvTjVEQ1I0akJO?=
 =?utf-8?B?STFicDlDTWpXNytvdXFPeHJFQUw4MzE5d0lDbGZFRk1ReWRGMVlWUHM4Rks3?=
 =?utf-8?B?NWp1blJUYmptemxuQVZHa3FhRGg5ZGN2TGQ3eG9ZbXJ6eEsxdWR2TTkrUUFQ?=
 =?utf-8?B?SGk2a2kwMGJxaWhpaERIcXJjNUVZME1rV1dibXRVR3ZwV0VwVk1vRDM2U2Q5?=
 =?utf-8?B?cTlueUR5VEhvU0lLRExueGIwM1A3SWhoUnd0Z253Qkp6TlQzeVdybG9XUlV3?=
 =?utf-8?B?U05DZTdKL0kyMmlBRThRaEVZZDRGWjB4anN2eVpNZHdXZkFwZ0g2R0hBR3FO?=
 =?utf-8?B?RFBEczFqSnN6aEN0Mzgvb0Q1UXFIdy84SDZpbC9GZi9UZUFBS2crMzdrWnR2?=
 =?utf-8?B?cXFxSUQ4SDBzNFFYc2VuRmtxeWI5NTY3MmZzczYyUU9pZ2hIN08wblZSdVJG?=
 =?utf-8?B?YkxJUFFhTlZqTWw4TzFzL1FIV21taUQ2a0ZaczY2UUs3N1pTTUpqNGVYQURy?=
 =?utf-8?B?SVFrcHdBR01YM1IrNDZnU2svdXV2RTdvdGs0a0thYkg4NStYdXFuWXhoK2Mz?=
 =?utf-8?B?SDJMMWZKckZkZmtBOFNKVGRnNklVNkxWOThtTDV6ejJXTUcyM0xKbXRmSk5h?=
 =?utf-8?B?OVZSVFlxR0tMbFlaNy9iV2psR1lxdHNhcVR2TnNOb0hnRWlZUWRrWldPaDEw?=
 =?utf-8?B?eHRsUjZiK0NTOXJrUlRTMTdkVGZldjdiaHVDSkpuTFFrVVRYT1kyWDUwZ2Rn?=
 =?utf-8?B?TlphdC9MdHhXazRNRFpNM3VwcWZXbG9UM0pkV2pwWjZnR2h0YThSVnJ2WWNm?=
 =?utf-8?B?T0pscXVGMDJVVzBNNm84TVZia0xKdmhhNU9HUUtGc045S0oxbnN0TkEyZ2Iw?=
 =?utf-8?B?eEtEaEhJcDdESXpBZWZCYTBkWnk5S2kxVFV6UHFQYUhUd05zRkdIL21ReTNr?=
 =?utf-8?B?a29TblM3TWJuZHYydmo0bTFERFY0VEc2TUpmQmZ2Y2tLNE9zUDZGNklLRWhw?=
 =?utf-8?B?NjhOVGI5c2xMdC9yKzBIaHh0QktLdFFhWnVDR0dvRXhsbndBV2NEOTZKd2E2?=
 =?utf-8?B?TThiakdkM29WZ0FvTVZTNllVWEtpZUoyS3BmOFZmZ3NJR1Q2VmFBTCsrTHlU?=
 =?utf-8?B?MGpvK1JyMHFSTEppYlF5dkVVWjlWM3R0M1ZSdDZlSVA0RFVJRERpWVlmTytn?=
 =?utf-8?B?RnJ0WHlWSVFyZHhiMlR3MytrSmZaR2hBU3N1UGFxRXI2aTlta2I1bFFJdXZH?=
 =?utf-8?B?OEI0Sjd2TlZ2QlRXbGtCYVB1TmhGTmE4aDhud010QktFa0FkS1d1cENtT2xy?=
 =?utf-8?B?MkxOSktCMjZqdlF5Uzk5VEpPM1NwKzlGcVQwREd2NVB1VWZSMm9EU2h5NTBk?=
 =?utf-8?B?a0lwV0pmdkpqSjgvZkt0U2hTaVR1eUlWZEUva05uM2hTb0VhTnNtQzZEZE9S?=
 =?utf-8?B?eVZ0WjhaakQrWG1Cd3BFbDBpcHcrWGpQRHU0MGU5Ry9XOWp4NW9SMmM0YjJL?=
 =?utf-8?B?d0pMWXBZQ2ZVbXNrUkd3bjBQWE9GSDczK1ZGbjE2NXdqWnVLNHVtbWFXWXRY?=
 =?utf-8?B?L0VwYStDdWlVSUFUL2NMTlBTT2tkVFRRWnFjc1ByYk45RjAzaHNPdHVuRmdi?=
 =?utf-8?B?U3R0RHFGR1dPNkJQVmJKcVNBRWFNZ3YwQVF1MEJHaEpqTWFkN2xBdUhrREdn?=
 =?utf-8?B?K1JFdFlEMTA2UXoyWEhWNE5CVmJkQXZtUTBuTkx5SU1ra0FHWDIwY3dFNUIw?=
 =?utf-8?B?NzNiRnRhZ1RKTHVZZjBKZVpKRjNZK1dyNHE5TnZBcWNQT2xlQnpxRE5OTXNq?=
 =?utf-8?B?bzgzSjVsbzBRWW03L0l6VE9DVUNXUmxMdFhoVm85UVRiSW81YlNvQlgzeSsw?=
 =?utf-8?Q?OiWawyNups/ATmSE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 44f6f466-0e97-4e96-cf40-08da16f79a07
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 11:29:52.3907
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZI/bxgKeArkxZQ0u+Qq2ox6DwLgKlWgtdHAkJsdsASdsYAxVm0GlwiQiK/BEbLCOTl2FoNmFymbzzu6nXqoGSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2475
X-OriginatorOrg: citrix.com

On Thu, Mar 31, 2022 at 11:51:02AM +0200, Jan Beulich wrote:
> There's no point going through %ax; the addition can be done directly in
> %di.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:32:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:32:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298754.509052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhQg-0002M2-ST; Tue, 05 Apr 2022 11:32:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298754.509052; Tue, 05 Apr 2022 11:32:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhQg-0002Lv-PA; Tue, 05 Apr 2022 11:32:58 +0000
Received: by outflank-mailman (input) for mailman id 298754;
 Tue, 05 Apr 2022 11:32:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vDTv=UP=gmail.com=shentey@srs-se1.protection.inumbo.net>)
 id 1nbhQe-0002Lp-Dg
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 11:32:56 +0000
Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com
 [2a00:1450:4864:20::52f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2293f5f9-b4d4-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 13:32:54 +0200 (CEST)
Received: by mail-ed1-x52f.google.com with SMTP id b15so14532025edn.4
 for <xen-devel@lists.xenproject.org>; Tue, 05 Apr 2022 04:32:54 -0700 (PDT)
Received: from [127.0.0.1] (dynamic-077-013-166-174.77.13.pool.telefonica.de.
 [77.13.166.174]) by smtp.gmail.com with ESMTPSA id
 dt6-20020a170907728600b006dff778258csm5470681ejc.32.2022.04.05.04.32.53
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 05 Apr 2022 04:32:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2293f5f9-b4d4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:in-reply-to:references:message-id
         :mime-version:content-transfer-encoding;
        bh=EUib3M/mRp3Es9YmQL1qt7y8EoMA5K4JNXNvjXy8PWc=;
        b=M2vsVrXm36JrzO4AhR9hY5zwBs3A9+42zx0D87iHjhMLER/NuzIArWjlRMDYwa8gWC
         7XXe6E4PmD5dzJ7/RMEk6fcMubKPRJ8+kr1vs6fzmYo2lx8/8XVyQJ3RhSmFjQtNT/Sf
         zQT/Du/jQJfTQDl8pysY6Bbu5/NkEsylmJRbLsTtFp3cYfJgw6rSJIsPszKZ3H0ADaUh
         7OxKNaX4LyzJfqHjVYoJyiDKPhMAX4Zk8pxm2l44PKaurHUje7cptcj8iHxMfh4fct6g
         b0cjEuNBYy4o+TPS/VIF0mtRIQU5xgG1e58BiNM9zLffm0Km/7lOc63CH3G195ThaiKf
         5e2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:references
         :message-id:mime-version:content-transfer-encoding;
        bh=EUib3M/mRp3Es9YmQL1qt7y8EoMA5K4JNXNvjXy8PWc=;
        b=sXV6roZ7p4KGSt/0Bx5BPQ59x2vPcHXSaEI3HjMDhwcDBgrk6RYDXIJGebI7spqfAw
         EXqHE3Rt72CHHL+LFfRg3W6TfjlIrLTHkDTcB7C5n5Za4PSbYJuLY+8OfbKf69O+esxF
         zV7u1D5yNy/RT0zrX3MOU+nfPlM4NBXHsaDymdBRg2TTkP1CAu/HeqlCY0nZt5SglxzW
         dV+ll2FnZpOqp2b3nPy0QcgI7nhxTIrFMLIu/nMhuQpIPhIhbIheEguNkaqw1MjHoDZg
         wABjBGkNjDByu5Nrmk6Cjww4/+whHXaugkha0utfh2d3pCa1i22H8PLZYl9LIQmt8VqH
         HHkg==
X-Gm-Message-State: AOAM532n86rrEJKh6tOI/oQ/T2pdvV+lNNs5z2EVQ7fN9I9sQ/cAhIp7
	81KZkdySMvdQsNMy1jsnIoVVvJtlaQI=
X-Google-Smtp-Source: ABdhPJz8U6Yj/r+bbovO0fvvLscarAsCi7H1CfK1BVRHkXd7Vu82jFfShKphiF7CZxgMX0bxAnRGTg==
X-Received: by 2002:a05:6402:4391:b0:419:2f2d:a1da with SMTP id o17-20020a056402439100b004192f2da1damr3068857edc.298.1649158374328;
        Tue, 05 Apr 2022 04:32:54 -0700 (PDT)
Date: Tue, 05 Apr 2022 11:32:51 +0000
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
CC: qemu-trivial@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_1/2=5D_hw/xen/xen=5Fpt=3A_Confi?= =?US-ASCII?Q?ne_igd-passthrough-isa-bridge_to_XEN?=
In-Reply-To: <20220326165825.30794-2-shentey@gmail.com>
References: <20220326165825.30794-1-shentey@gmail.com> <20220326165825.30794-2-shentey@gmail.com>
Message-ID: <2E37BFBA-3EA7-4A3F-B58C-860088275DAA@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

Am 26=2E M=C3=A4rz 2022 16:58:23 UTC schrieb Bernhard Beschow <shentey@gmai=
l=2Ecom>:
>igd-passthrough-isa-bridge is only requested in xen_pt but was
>implemented in pc_piix=2Ec=2E This caused xen_pt to dependend on i386/pc
>which is hereby resolved=2E
>
>Signed-off-by: Bernhard Beschow <shentey@gmail=2Ecom>
>---
> hw/i386/pc_piix=2Ec        | 118 --------------------------------------
> hw/xen/xen_pt=2Ec          |   1 -
> hw/xen/xen_pt=2Eh          |   1 +
> hw/xen/xen_pt_graphics=2Ec | 119 +++++++++++++++++++++++++++++++++++++++
> include/hw/i386/pc=2Eh     |   1 -
> 5 files changed, 120 insertions(+), 120 deletions(-)
>
>diff --git a/hw/i386/pc_piix=2Ec b/hw/i386/pc_piix=2Ec
>index b72c03d0a6=2E=2E6ad5c02f07 100644
>--- a/hw/i386/pc_piix=2Ec
>+++ b/hw/i386/pc_piix=2Ec
>@@ -801,124 +801,6 @@ static void pc_i440fx_1_4_machine_options(MachineCl=
ass *m)
> DEFINE_I440FX_MACHINE(v1_4, "pc-i440fx-1=2E4", pc_compat_1_4_fn,
>                       pc_i440fx_1_4_machine_options);
>=20
>-typedef struct {
>-    uint16_t gpu_device_id;
>-    uint16_t pch_device_id;
>-    uint8_t pch_revision_id;
>-} IGDDeviceIDInfo;
>-
>-/* In real world different GPU should have different PCH=2E But actually
>- * the different PCH DIDs likely map to different PCH SKUs=2E We do the
>- * same thing for the GPU=2E For PCH, the different SKUs are going to be
>- * all the same silicon design and implementation, just different
>- * features turn on and off with fuses=2E The SW interfaces should be
>- * consistent across all SKUs in a given family (eg LPT)=2E But just sam=
e
>- * features may not be supported=2E
>- *
>- * Most of these different PCH features probably don't matter to the
>- * Gfx driver, but obviously any difference in display port connections
>- * will so it should be fine with any PCH in case of passthrough=2E
>- *
>- * So currently use one PCH version, 0x8c4e, to cover all HSW(Haswell)
>- * scenarios, 0x9cc3 for BDW(Broadwell)=2E
>- */
>-static const IGDDeviceIDInfo igd_combo_id_infos[] =3D {
>-    /* HSW Classic */
>-    {0x0402, 0x8c4e, 0x04}, /* HSWGT1D, HSWD_w7 */
>-    {0x0406, 0x8c4e, 0x04}, /* HSWGT1M, HSWM_w7 */
>-    {0x0412, 0x8c4e, 0x04}, /* HSWGT2D, HSWD_w7 */
>-    {0x0416, 0x8c4e, 0x04}, /* HSWGT2M, HSWM_w7 */
>-    {0x041E, 0x8c4e, 0x04}, /* HSWGT15D, HSWD_w7 */
>-    /* HSW ULT */
>-    {0x0A06, 0x8c4e, 0x04}, /* HSWGT1UT, HSWM_w7 */
>-    {0x0A16, 0x8c4e, 0x04}, /* HSWGT2UT, HSWM_w7 */
>-    {0x0A26, 0x8c4e, 0x06}, /* HSWGT3UT, HSWM_w7 */
>-    {0x0A2E, 0x8c4e, 0x04}, /* HSWGT3UT28W, HSWM_w7 */
>-    {0x0A1E, 0x8c4e, 0x04}, /* HSWGT2UX, HSWM_w7 */
>-    {0x0A0E, 0x8c4e, 0x04}, /* HSWGT1ULX, HSWM_w7 */
>-    /* HSW CRW */
>-    {0x0D26, 0x8c4e, 0x04}, /* HSWGT3CW, HSWM_w7 */
>-    {0x0D22, 0x8c4e, 0x04}, /* HSWGT3CWDT, HSWD_w7 */
>-    /* HSW Server */
>-    {0x041A, 0x8c4e, 0x04}, /* HSWSVGT2, HSWD_w7 */
>-    /* HSW SRVR */
>-    {0x040A, 0x8c4e, 0x04}, /* HSWSVGT1, HSWD_w7 */
>-    /* BSW */
>-    {0x1606, 0x9cc3, 0x03}, /* BDWULTGT1, BDWM_w7 */
>-    {0x1616, 0x9cc3, 0x03}, /* BDWULTGT2, BDWM_w7 */
>-    {0x1626, 0x9cc3, 0x03}, /* BDWULTGT3, BDWM_w7 */
>-    {0x160E, 0x9cc3, 0x03}, /* BDWULXGT1, BDWM_w7 */
>-    {0x161E, 0x9cc3, 0x03}, /* BDWULXGT2, BDWM_w7 */
>-    {0x1602, 0x9cc3, 0x03}, /* BDWHALOGT1, BDWM_w7 */
>-    {0x1612, 0x9cc3, 0x03}, /* BDWHALOGT2, BDWM_w7 */
>-    {0x1622, 0x9cc3, 0x03}, /* BDWHALOGT3, BDWM_w7 */
>-    {0x162B, 0x9cc3, 0x03}, /* BDWHALO28W, BDWM_w7 */
>-    {0x162A, 0x9cc3, 0x03}, /* BDWGT3WRKS, BDWM_w7 */
>-    {0x162D, 0x9cc3, 0x03}, /* BDWGT3SRVR, BDWM_w7 */
>-};
>-
>-static void isa_bridge_class_init(ObjectClass *klass, void *data)
>-{
>-    DeviceClass *dc =3D DEVICE_CLASS(klass);
>-    PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass);
>-
>-    dc->desc        =3D "ISA bridge faked to support IGD PT";
>-    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>-    k->vendor_id    =3D PCI_VENDOR_ID_INTEL;
>-    k->class_id     =3D PCI_CLASS_BRIDGE_ISA;
>-};
>-
>-static const TypeInfo isa_bridge_info =3D {
>-    =2Ename          =3D "igd-passthrough-isa-bridge",
>-    =2Eparent        =3D TYPE_PCI_DEVICE,
>-    =2Einstance_size =3D sizeof(PCIDevice),
>-    =2Eclass_init =3D isa_bridge_class_init,
>-    =2Einterfaces =3D (InterfaceInfo[]) {
>-        { INTERFACE_CONVENTIONAL_PCI_DEVICE },
>-        { },
>-    },
>-};
>-
>-static void pt_graphics_register_types(void)
>-{
>-    type_register_static(&isa_bridge_info);
>-}
>-type_init(pt_graphics_register_types)
>-
>-void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id)
>-{
>-    struct PCIDevice *bridge_dev;
>-    int i, num;
>-    uint16_t pch_dev_id =3D 0xffff;
>-    uint8_t pch_rev_id =3D 0;
>-
>-    num =3D ARRAY_SIZE(igd_combo_id_infos);
>-    for (i =3D 0; i < num; i++) {
>-        if (gpu_dev_id =3D=3D igd_combo_id_infos[i]=2Egpu_device_id) {
>-            pch_dev_id =3D igd_combo_id_infos[i]=2Epch_device_id;
>-            pch_rev_id =3D igd_combo_id_infos[i]=2Epch_revision_id;
>-        }
>-    }
>-
>-    if (pch_dev_id =3D=3D 0xffff) {
>-        return;
>-    }
>-
>-    /* Currently IGD drivers always need to access PCH by 1f=2E0=2E */
>-    bridge_dev =3D pci_create_simple(bus, PCI_DEVFN(0x1f, 0),
>-                                   "igd-passthrough-isa-bridge");
>-
>-    /*
>-     * Note that vendor id is always PCI_VENDOR_ID_INTEL=2E
>-     */
>-    if (!bridge_dev) {
>-        fprintf(stderr, "set igd-passthrough-isa-bridge failed!\n");
>-        return;
>-    }
>-    pci_config_set_device_id(bridge_dev->config, pch_dev_id);
>-    pci_config_set_revision(bridge_dev->config, pch_rev_id);
>-}
>-
> #ifdef CONFIG_ISAPC
> static void isapc_machine_options(MachineClass *m)
> {
>diff --git a/hw/xen/xen_pt=2Ec b/hw/xen/xen_pt=2Ec
>index 027190fa44=2E=2E829ea9985f 100644
>--- a/hw/xen/xen_pt=2Ec
>+++ b/hw/xen/xen_pt=2Ec
>@@ -60,7 +60,6 @@
> #include "hw/qdev-properties=2Eh"
> #include "hw/qdev-properties-system=2Eh"
> #include "hw/xen/xen=2Eh"
>-#include "hw/i386/pc=2Eh"
> #include "hw/xen/xen-legacy-backend=2Eh"
> #include "xen_pt=2Eh"
> #include "qemu/range=2Eh"
>diff --git a/hw/xen/xen_pt=2Eh b/hw/xen/xen_pt=2Eh
>index 6b8e13cdee=2E=2E806d832c94 100644
>--- a/hw/xen/xen_pt=2Eh
>+++ b/hw/xen/xen_pt=2Eh
>@@ -43,6 +43,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_=
PT_DEVICE)
>=20
> uint32_t igd_read_opregion(XenPCIPassthroughState *s);
> void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val);
>+void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id)=
;
>=20
> /* function type for config reg */
> typedef int (*xen_pt_conf_reg_init)
>diff --git a/hw/xen/xen_pt_graphics=2Ec b/hw/xen/xen_pt_graphics=2Ec
>index a3bc7e3921=2E=2Ef1fbb98912 100644
>--- a/hw/xen/xen_pt_graphics=2Ec
>+++ b/hw/xen/xen_pt_graphics=2Ec
>@@ -289,3 +289,122 @@ void igd_write_opregion(XenPCIPassthroughState *s, =
uint32_t val)
>                     (unsigned long)(igd_host_opregion >> XC_PAGE_SHIFT),
>                     (unsigned long)(igd_guest_opregion >> XC_PAGE_SHIFT)=
);
> }
>+
>+typedef struct {
>+    uint16_t gpu_device_id;
>+    uint16_t pch_device_id;
>+    uint8_t pch_revision_id;
>+} IGDDeviceIDInfo;
>+
>+/*
>+ * In real world different GPU should have different PCH=2E But actually
>+ * the different PCH DIDs likely map to different PCH SKUs=2E We do the
>+ * same thing for the GPU=2E For PCH, the different SKUs are going to be
>+ * all the same silicon design and implementation, just different
>+ * features turn on and off with fuses=2E The SW interfaces should be
>+ * consistent across all SKUs in a given family (eg LPT)=2E But just sam=
e
>+ * features may not be supported=2E
>+ *
>+ * Most of these different PCH features probably don't matter to the
>+ * Gfx driver, but obviously any difference in display port connections
>+ * will so it should be fine with any PCH in case of passthrough=2E
>+ *
>+ * So currently use one PCH version, 0x8c4e, to cover all HSW(Haswell)
>+ * scenarios, 0x9cc3 for BDW(Broadwell)=2E
>+ */
>+static const IGDDeviceIDInfo igd_combo_id_infos[] =3D {
>+    /* HSW Classic */
>+    {0x0402, 0x8c4e, 0x04}, /* HSWGT1D, HSWD_w7 */
>+    {0x0406, 0x8c4e, 0x04}, /* HSWGT1M, HSWM_w7 */
>+    {0x0412, 0x8c4e, 0x04}, /* HSWGT2D, HSWD_w7 */
>+    {0x0416, 0x8c4e, 0x04}, /* HSWGT2M, HSWM_w7 */
>+    {0x041E, 0x8c4e, 0x04}, /* HSWGT15D, HSWD_w7 */
>+    /* HSW ULT */
>+    {0x0A06, 0x8c4e, 0x04}, /* HSWGT1UT, HSWM_w7 */
>+    {0x0A16, 0x8c4e, 0x04}, /* HSWGT2UT, HSWM_w7 */
>+    {0x0A26, 0x8c4e, 0x06}, /* HSWGT3UT, HSWM_w7 */
>+    {0x0A2E, 0x8c4e, 0x04}, /* HSWGT3UT28W, HSWM_w7 */
>+    {0x0A1E, 0x8c4e, 0x04}, /* HSWGT2UX, HSWM_w7 */
>+    {0x0A0E, 0x8c4e, 0x04}, /* HSWGT1ULX, HSWM_w7 */
>+    /* HSW CRW */
>+    {0x0D26, 0x8c4e, 0x04}, /* HSWGT3CW, HSWM_w7 */
>+    {0x0D22, 0x8c4e, 0x04}, /* HSWGT3CWDT, HSWD_w7 */
>+    /* HSW Server */
>+    {0x041A, 0x8c4e, 0x04}, /* HSWSVGT2, HSWD_w7 */
>+    /* HSW SRVR */
>+    {0x040A, 0x8c4e, 0x04}, /* HSWSVGT1, HSWD_w7 */
>+    /* BSW */
>+    {0x1606, 0x9cc3, 0x03}, /* BDWULTGT1, BDWM_w7 */
>+    {0x1616, 0x9cc3, 0x03}, /* BDWULTGT2, BDWM_w7 */
>+    {0x1626, 0x9cc3, 0x03}, /* BDWULTGT3, BDWM_w7 */
>+    {0x160E, 0x9cc3, 0x03}, /* BDWULXGT1, BDWM_w7 */
>+    {0x161E, 0x9cc3, 0x03}, /* BDWULXGT2, BDWM_w7 */
>+    {0x1602, 0x9cc3, 0x03}, /* BDWHALOGT1, BDWM_w7 */
>+    {0x1612, 0x9cc3, 0x03}, /* BDWHALOGT2, BDWM_w7 */
>+    {0x1622, 0x9cc3, 0x03}, /* BDWHALOGT3, BDWM_w7 */
>+    {0x162B, 0x9cc3, 0x03}, /* BDWHALO28W, BDWM_w7 */
>+    {0x162A, 0x9cc3, 0x03}, /* BDWGT3WRKS, BDWM_w7 */
>+    {0x162D, 0x9cc3, 0x03}, /* BDWGT3SRVR, BDWM_w7 */
>+};
>+
>+static void isa_bridge_class_init(ObjectClass *klass, void *data)
>+{
>+    DeviceClass *dc =3D DEVICE_CLASS(klass);
>+    PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass);
>+
>+    dc->desc        =3D "ISA bridge faked to support IGD PT";
>+    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>+    k->vendor_id    =3D PCI_VENDOR_ID_INTEL;
>+    k->class_id     =3D PCI_CLASS_BRIDGE_ISA;
>+};
>+
>+static const TypeInfo isa_bridge_info =3D {
>+    =2Ename          =3D "igd-passthrough-isa-bridge",
>+    =2Eparent        =3D TYPE_PCI_DEVICE,
>+    =2Einstance_size =3D sizeof(PCIDevice),
>+    =2Eclass_init =3D isa_bridge_class_init,
>+    =2Einterfaces =3D (InterfaceInfo[]) {
>+        { INTERFACE_CONVENTIONAL_PCI_DEVICE },
>+        { },
>+    },
>+};
>+
>+static void pt_graphics_register_types(void)
>+{
>+    type_register_static(&isa_bridge_info);
>+}
>+type_init(pt_graphics_register_types)
>+
>+void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id)
>+{
>+    struct PCIDevice *bridge_dev;
>+    int i, num;
>+    uint16_t pch_dev_id =3D 0xffff;
>+    uint8_t pch_rev_id =3D 0;
>+
>+    num =3D ARRAY_SIZE(igd_combo_id_infos);
>+    for (i =3D 0; i < num; i++) {
>+        if (gpu_dev_id =3D=3D igd_combo_id_infos[i]=2Egpu_device_id) {
>+            pch_dev_id =3D igd_combo_id_infos[i]=2Epch_device_id;
>+            pch_rev_id =3D igd_combo_id_infos[i]=2Epch_revision_id;
>+        }
>+    }
>+
>+    if (pch_dev_id =3D=3D 0xffff) {
>+        return;
>+    }
>+
>+    /* Currently IGD drivers always need to access PCH by 1f=2E0=2E */
>+    bridge_dev =3D pci_create_simple(bus, PCI_DEVFN(0x1f, 0),
>+                                   "igd-passthrough-isa-bridge");
>+
>+    /*
>+     * Note that vendor id is always PCI_VENDOR_ID_INTEL=2E
>+     */
>+    if (!bridge_dev) {
>+        fprintf(stderr, "set igd-passthrough-isa-bridge failed!\n");
>+        return;
>+    }
>+    pci_config_set_device_id(bridge_dev->config, pch_dev_id);
>+    pci_config_set_revision(bridge_dev->config, pch_rev_id);
>+}
>diff --git a/include/hw/i386/pc=2Eh b/include/hw/i386/pc=2Eh
>index 1a27de9c8b=2E=2E926a507a0c 100644
>--- a/include/hw/i386/pc=2Eh
>+++ b/include/hw/i386/pc=2Eh
>@@ -312,5 +312,4 @@ extern const size_t pc_compat_1_4_len;
>     } \
>     type_init(pc_machine_init_##suffix)
>=20
>-extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_=
dev_id);
> #endif

Ping


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:34:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:34:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298758.509063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhS4-0002ys-AA; Tue, 05 Apr 2022 11:34:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298758.509063; Tue, 05 Apr 2022 11:34:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhS4-0002yl-6h; Tue, 05 Apr 2022 11:34:24 +0000
Received: by outflank-mailman (input) for mailman id 298758;
 Tue, 05 Apr 2022 11:34:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbhS2-0002yd-Mh
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 11:34:22 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 547692a2-b4d4-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 13:34:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 547692a2-b4d4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649158460;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=X9LtNCNMuvCfnzhL3xipXrl8mmnDDYL0OUnzwIYs2Bs=;
  b=TiGNnjcAEOkQM2NgHNHZywLKio1qDkrheNzZJHFqeOHjKFQp5e85Vcmo
   SZ1/y8CyKTGIpo/9ariKIOF6tjBtBJrbbSM/L1NG9MN2AVVnLLC1z0lX4
   fcRIMsErwW8+ABPqMPhfPjgcNX+/XXGtsbq8lRstmdfzqus1rjJtzJB2y
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70430352
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:S5GtRqOhF8xOTl/vrR2al8FynXyQoLVcMsEvi/4bfWQNrUpzgzQEy
 DdMXmyDOvfeZzGjL9kkYYvj8xgB7MWHzNVmHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zy
 Yxii6Kfb1gVMZLMivs2VwJnLjlnIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwg29s3ZgVQKy2i
 8wxbChUcznKWjp2A2gGU5hkoP2lqmXdbGgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSAzRKV/3TqgfXA9Qv5RYYTGbuQ5vNsxlqJyQQ7ChcbSF+6qvmRkVOlVpRUL
 El80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BBGVAjoO6by2h+YiUvyyZPTMqEHcbenpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzl+PNl9J+D+Vc2JMi2aAzVHApchNI4+CJrVql
 ChVwpPOhAzi4HzkqcBsfAnvNOzyjxpmGGeF6bKKI3XH327wk5JEVdoNiAyS3G8zbq45lcbBO
 Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+SYW9DKiIM4YVPsQZmOq7EMdGPxP4M4fFyhZErE3CE
 c3DLZbE4YgyV8yLMwZat89CiOR2l0jSNEvYRIzhzgTP7FZtTCX9dFvxC3PXNrpRxPrd+G39q
 o8DX+PXm0Q3eLCvOUH/rN9MRW3m2FBmXPgaXeQMLbXdSuencUl8Y8LsLUQJINU/xfkKz7uWp
 RlQmCZwkTLCuJEOEi3TAlhLY7LzR5dv63U9OC0nJ1Gz3HY/J42o6c8im1EfJtHLKMQLISZIc
 sQ4
IronPort-HdrOrdr: A9a23:f9+tvaC+V0GedvHlHehOsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QZiApIs+PvP+UpgNdtvpYfHHfFAlEii8eV57HzzcZdQ60jT22trK3Ik=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="70430352"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eu3oSBUR7W02lXBzAUjHcBYiQbFhRgx0arEUO2/YPi6te16CbBeELt+gnuDT218067TaiTIcuf4rsMJJXa60DP6hdm/kSpKTn+KAD1Cdv1HckDnA6ugbvsXuU4/jutEVDj7CH/DN/FYrlenKhCPKkg7+EMKr+UpsGOVLiKKfu80sFrtArh3QRFWvAbj5kCZpE1aMawv2o297tiJFnXfQxJe2W9ZNVyE9yBTmnshLCXFSkHK2icKBQq6aR4F/aGxad+thYJqyP2wLJNZURI15nv0EwSprigzcqrH2wpxUW7M/FIrypsXZxRo31lfW2fjOek221NYvnmG8hoqm6JkmIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6d2EMwQuMlZZemqHnYYwxySu6RfYTiI9NZx/51mPiqs=;
 b=Mm+rYtDr9GqeXWcopIG6AZx8PlAM52bNij5R53RBehkdAEyC5BRFiTs/AEeebZhw71G1vl9TjGfzxlSFM4zm7WWFQNlhF3fDE8aJ9C3eyPQcUU8qHiM7vYIFv3AJEWZCSLrErWs+VNPsLEUZ0+rowDIJGczbwYAbOtP7w1Z0+eCZIB1HHNfvmsIMfdY2aJYoVs0B7RFvGIJgwIlEpweeF9KOUkjPAgl/8Pp5f8OgGpAFJQ6I0qasET+Un5Nt7WbQSRXG4tZtFCSppIIFHvNZT7Rv0bR3seDt3M93ebigHgQ0RmzN/AMHNaSQLpnz6hGCCxu9SUl9baT8D5NU6JRVzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6d2EMwQuMlZZemqHnYYwxySu6RfYTiI9NZx/51mPiqs=;
 b=AEsBmkUr8tikGbLvzssPtHvNrvNiWMXwzMl1CRzaXyjyOEyL07nrrez2AK4lC/I5GJFmZqpgZEs51d1s/z5OkgkMmC8KQZVfT8f8e423hvqldxz39f9Wri5xp3AYz7hmlMRlKtGvmXCGn6W27eGu6fCNOilsdjWtPsDJAN/jbLo=
Date: Tue, 5 Apr 2022 13:34:05 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 2/8] x86/boot: obtain video info from boot loader
Message-ID: <YkwpLavk8bC3Ir0+@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <6fc25224-7985-73a6-8877-bc209f64bf8c@suse.com>
 <YkwNbi3lTNJbWVNC@Air-de-Roger>
 <26b988cb-8b20-f78d-548e-1b1f16d10a63@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <26b988cb-8b20-f78d-548e-1b1f16d10a63@suse.com>
X-ClientProxiedBy: LO3P265CA0006.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:bb::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a2cca11d-9b66-4950-3189-08da16f83402
X-MS-TrafficTypeDiagnostic: DM5PR03MB2475:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB24752E85677743C6B3573F2A8FE49@DM5PR03MB2475.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YUL1f0Lu7deCzp5cRlJ2aWHCcu6+/np6f+tE7f/l8rD5K7Eu9peUvVLO3IaEs9Ot6ZU8pk0EXjnGnkMu+8etkNeeLVlUpKw3I0Pe2brK4Sdl0tzJ3piVwMaFMAI38X5L9Y38h4/5ha70uuhSfg29ESGb/gJVgNav81YYdPwV2hM2kgnuZw/OfYuwFyel3/OKwwb9DObYUO+ouzm+Mr0isMSkJ0yxKHL3LLrDr21STOuqIkBUVVZvkLl6UXO/Kyb1+YA2WV6X2IAt2+EcYvwbtZmy8TLdi+OS+G7G9wZuJNVfZyTW9d9QzLVwVveb8D387M7vJyrIwPdT3C2cOsouYLDwhtq1Bsvv0g3yHCK61we/A/L6Q4JqmiegjfYunO2sBPlHHur5zzbBP5zLWUa4aMbV7/pI2RCmkdDQz6IJxynoWn81R0hOtHQ+nv/yx4dH3tUsoDyClD7rvtE3abitUEkHyhJvJIW6s4RNlkA40bS9m9NsdNLcTbjunXFmEdbHQrzRP4zMiW3pTWbTmGMXdHBWTB9FuJ2ekqX3ccPCUTrG3zCBjYeQhb2zMqMpXve5bwXzBGmCgSWGI5wk+6upc+e5FYBglW/Hr1AC3K7I/v/Bw6qAH+rNC4Ry7licIXpG1gcGuxz/CcsXNUmP2v1yag==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8676002)(4326008)(66946007)(66476007)(86362001)(2906002)(83380400001)(66556008)(5660300002)(82960400001)(38100700002)(8936002)(6666004)(9686003)(53546011)(6916009)(186003)(33716001)(26005)(54906003)(6512007)(6486002)(316002)(6506007)(508600001)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFBSRWMzNTN1V09jZnYzdzRHRTBoSDZIMmRUWjZXRUJuU0ZtNjY1QmdlNzZy?=
 =?utf-8?B?dk91c1V1QlZFbUVzYmJ2WnB5Yk8vTFJjT1NITkFmeEVSUGlWVE9vN0ZyTmRI?=
 =?utf-8?B?bXdieFduYmVFNmZscjhoTVFVUmNxKzBzL3gyOWRoS1hVY1ZhQ0x5VDJzSVJU?=
 =?utf-8?B?b3lkemZqUUdxREpYWkNMTk1KSUo2MTAzYjEvN0tRcE01c1RxZVVlZnRvR3hW?=
 =?utf-8?B?OUxXNDFUams5V25EVE1XWFVPZFIrQlBNekViNHV2RkRaNkNadHp0dWFleHgz?=
 =?utf-8?B?UFY4R0pFMGNlRTIyM2VHMjJJalc4YVA0OFVabUJFQkptWEdrZ0hJcW41QnMz?=
 =?utf-8?B?bzZ0TWlqYm1CNHBuK2oyMWVrbnNxWWRHeXVSQmlLay9pUGZTYnZYeWxKdy9I?=
 =?utf-8?B?cTRsQm45RElMbkJqdmtmckVlOGc4eHl4d1BvaTViYmxxbUFscndwaUllTG5x?=
 =?utf-8?B?UmNkdm43dUFYbWNIQlM3OFZmTm9udld4czgramphMFZMS3J6dm42Qm1INWNs?=
 =?utf-8?B?Vk5EVURsaG5obmFuSE00TDVBWU1MMFhWZWFkM1pmcFhybkdoZFpMS0NueXlw?=
 =?utf-8?B?dUEralhyZ0lYVThKTjFsck5aeVdabHpZY0RvNTA2c2pRT05UajBzZm14U2dR?=
 =?utf-8?B?eDh0UGNFSFZjNVpwT2U2MDdvZFdzVmwrNFU1WkZCQkFGaEVWa08rdndzR3RY?=
 =?utf-8?B?MUZOUkIwb2xrSzhCNXBnbjR3bUFLNHFJY1c0TXdxNnBxMUEwZ2d5T2dVaDlH?=
 =?utf-8?B?QUZYVmo4UG1vNDg3RUplNUdRdHh3L2VSUldzQlJZdUN4eU9NRXhMNFpycG16?=
 =?utf-8?B?SHR3c0Q1c0ZTL0Q5TmJqeVFYR2ZNVzF5ZHpTTzRVb1VOU0t4dTVGUzk4QStF?=
 =?utf-8?B?UmxQM0U3ZlV5OG51SlRSN3M5WUdBZHpRK1p5Y1Z4MVNqVC9kRkNsRFFuZ3l2?=
 =?utf-8?B?S09ndzFDN3o2b1NyWnZHY0gvSFAvc1h3NlhCN3I2VE9TY3F3MG90VkkvVVJH?=
 =?utf-8?B?VEVHZS84a2c4L1FiYUQ3WDMza053dWsweDRtbjk0U0FqOVkvOTRFVzVqY0dP?=
 =?utf-8?B?Q2FuWE9XcC9xaHMxcXp5QVd4UW9CbUEzbkhMUFpwbVkzdysxcGRiTGFNcEdI?=
 =?utf-8?B?WGNDWEtsSWlST2xwL00rYzNuejZCa3p4RUxGbERlUktPUEJRS09UL0IvOEtS?=
 =?utf-8?B?OTFIL282elJXaTdiWTM1Q3g3YzZBVDhRNC81czZJOWVuSTYxUUFEdnNidWFS?=
 =?utf-8?B?cVRlcS93R0QrMkwxUHNBRDhZSmFQSVFWWmxzQWFQdHMwSWlIeFlSMVQvT25m?=
 =?utf-8?B?V090Ujh6TnRNR2l2NUlHcUd2RHd3Y1RrcWhvcnBieFFCcW1OWlBtbDB4cGJN?=
 =?utf-8?B?Yk00THg1SzM3cXpKT0tscDhwaEhVZ2ZsOEd4VFRKLzZNRjdGM0k2VGdrSXF6?=
 =?utf-8?B?MFd6czB4MXR2eXBJNFlyY0MyODhZelpvdk9jbEx1SUpmcEhIayt3SHd1YlFs?=
 =?utf-8?B?MVBLU0RtN3VmaG01M3A5bnRPbytGaVl4dG9SdW1vMnA0N28xbWRaUTI1MjB6?=
 =?utf-8?B?emhxV2NnMzE0aGgyRUxRQm11RS9aZDFjenJ1STlMdmUvK21RaVNia1JuVVRk?=
 =?utf-8?B?Ym5laUQzSVNNWFJjN3Vpc0N1UGk0T0c5VittZ25WRUFLK0dHdGlKNXpZby9D?=
 =?utf-8?B?b2FxUUozNFB1eGdxaHpiY2M0aFhFRzYrRGNPRk1qV3l1UGE2VENMUEYvNS91?=
 =?utf-8?B?VWNidVBZTFZDZUhINS8vTHBJWW13bG11ZzRBMnpTTFJrdzhXTTc5Y3A2aytL?=
 =?utf-8?B?OE85eGNEbkFiYTlaNytxWjZoYis3bnBEUndzaXUxUFFJQktteHZFQ1BCMHkz?=
 =?utf-8?B?V3ZhNndtTDY5cTJSYUljVGNnTkJ3MERjL295NzhBWEZESlY5TndnTUZYcjhn?=
 =?utf-8?B?RWp6TUNreUpoWnBhaXRwQjNDSis1OTJwODcwNEo0MVRHeDJQRGRjdlJ0R2RD?=
 =?utf-8?B?OVl5Z2hSRktLL3p4cG1paDFwNFY1dGg2NG1oOVhFZjlkdEdrbUpBeTRvSXc0?=
 =?utf-8?B?RXM5QWt1dzZzRUxFdzQ3OW9vemNZMXpXYTFOaFR3WTVxR212QTNoWFlMQ0FY?=
 =?utf-8?B?elgzQUpkemdIQ1FrVWdaeVQyNWU1ZHZYNlhDbTZSSDRHc3FocGdac09UU0xh?=
 =?utf-8?B?M2Z1M2VWRVU2bTZlRm50SWJzTTNrTFhleEJ0bEFWTnpKanJxRUk1UEplNHVF?=
 =?utf-8?B?dHlHMzlJTVNFTEZiSlNBVjhoanVUVHkxZStQbDJCUld3Mi9wdVhIb0RXakY4?=
 =?utf-8?B?S3F5ZDEza3U4dGFqbUZxaUNDNXB5RlhXNlF2USs0K2JDWklpVjhFcmRXOUxs?=
 =?utf-8?Q?mjp7zFPYd11jnCnc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2cca11d-9b66-4950-3189-08da16f83402
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 11:34:10.7710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: foBUx5OVPqkBO0LrQYGdnMIYo59QvVhOFN0kCaFeieN4upX/znMVesLmXIk7T5ZGXHKs7MxB36fmM6pkJRLHFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2475
X-OriginatorOrg: citrix.com

On Tue, Apr 05, 2022 at 12:57:51PM +0200, Jan Beulich wrote:
> On 05.04.2022 11:35, Roger Pau Monné wrote:
> > On Thu, Mar 31, 2022 at 11:45:02AM +0200, Jan Beulich wrote:
> >> --- a/xen/arch/x86/boot/head.S
> >> +++ b/xen/arch/x86/boot/head.S
> >> @@ -562,12 +562,18 @@ trampoline_setup:
> >>          mov     %esi, sym_esi(xen_phys_start)
> >>          mov     %esi, sym_esi(trampoline_xen_phys_start)
> >>  
> >> -        mov     sym_esi(trampoline_phys), %ecx
> >> -
> >>          /* Get bottom-most low-memory stack address. */
> >> +        mov     sym_esi(trampoline_phys), %ecx
> >>          add     $TRAMPOLINE_SPACE,%ecx
> > 
> > Just for my understanding, since you are already touching the
> > instruction, why not switch it to a lea like you do below?
> > 
> > Is that because you would also like to take the opportunity to fold
> > the add into the lea and that would be too much of a change?
> 
> No. This MOV cannot be converted, as its source operand isn't an
> immediate (or register); such a conversion would also be undesirable,
> for increasing insn size. See the later patch doing conversions in
> the other direction, to reduce code size. Somewhat similarly ...
> 
> >> +#ifdef CONFIG_VIDEO
> >> +        lea     sym_esi(boot_vid_info), %edx
> 
> ... this LEA also cannot be expressed by a single MOV.
> 
> >> @@ -32,6 +33,39 @@ asm (
> >>  #include "../../../include/xen/kconfig.h"
> >>  #include <public/arch-x86/hvm/start_info.h>
> >>  
> >> +#ifdef CONFIG_VIDEO
> >> +# include "video.h"
> >> +
> >> +/* VESA control information */
> >> +struct __packed vesa_ctrl_info {
> >> +    uint8_t signature[4];
> >> +    uint16_t version;
> >> +    uint32_t oem_name;
> >> +    uint32_t capabilities;
> >> +    uint32_t mode_list;
> >> +    uint16_t mem_size;
> >> +    /* We don't use any further fields. */
> >> +};
> >> +
> >> +/* VESA 2.0 mode information */
> >> +struct vesa_mode_info {
> > 
> > Should we add __packed here just in case further added fields are no
> > longer naturally aligned? (AFAICT all field right now are aligned to
> > it's size so there's no need for it).
> 
> I think we should avoid __packed whenever possible.
> 
> >> +    uint16_t attrib;
> >> +    uint8_t window[14]; /* We don't use the individual fields. */
> >> +    uint16_t bytes_per_line;
> >> +    uint16_t width;
> >> +    uint16_t height;
> >> +    uint8_t cell_width;
> >> +    uint8_t cell_height;
> >> +    uint8_t nr_planes;
> >> +    uint8_t depth;
> >> +    uint8_t memory[5]; /* We don't use the individual fields. */
> >> +    struct boot_video_colors colors;
> >> +    uint8_t direct_color;
> >> +    uint32_t base;
> >> +    /* We don't use any further fields. */
> >> +};
> > 
> > Would it make sense to put those struct definitions in boot/video.h
> > like you do for boot_video_info?
> 
> Personally I prefer to expose things in headers only when multiple
> other files want to consume what is being declared/defined.
> 
> >> @@ -254,17 +291,64 @@ static multiboot_info_t *mbi2_reloc(u32
> >>              ++mod_idx;
> >>              break;
> >>  
> >> +#ifdef CONFIG_VIDEO
> >> +        case MULTIBOOT2_TAG_TYPE_VBE:
> >> +            if ( video_out )
> >> +            {
> >> +                const struct vesa_ctrl_info *ci;
> >> +                const struct vesa_mode_info *mi;
> >> +
> >> +                video = _p(video_out);
> >> +                ci = (void *)get_mb2_data(tag, vbe, vbe_control_info);
> >> +                mi = (void *)get_mb2_data(tag, vbe, vbe_mode_info);
> >> +
> >> +                if ( ci->version >= 0x0200 && (mi->attrib & 0x9b) == 0x9b )
> >> +                {
> >> +                    video->capabilities = ci->capabilities;
> >> +                    video->lfb_linelength = mi->bytes_per_line;
> >> +                    video->lfb_width = mi->width;
> >> +                    video->lfb_height = mi->height;
> >> +                    video->lfb_depth = mi->depth;
> >> +                    video->lfb_base = mi->base;
> >> +                    video->lfb_size = ci->mem_size;
> >> +                    video->colors = mi->colors;
> >> +                    video->vesa_attrib = mi->attrib;
> >> +                }
> >> +
> >> +                video->vesapm.seg = get_mb2_data(tag, vbe, vbe_interface_seg);
> >> +                video->vesapm.off = get_mb2_data(tag, vbe, vbe_interface_off);
> >> +            }
> >> +            break;
> >> +
> >> +        case MULTIBOOT2_TAG_TYPE_FRAMEBUFFER:
> >> +            if ( (get_mb2_data(tag, framebuffer, framebuffer_type) !=
> >> +                  MULTIBOOT2_FRAMEBUFFER_TYPE_RGB) )
> >> +            {
> >> +                video_out = 0;
> >> +                video = NULL;
> >> +            }
> > 
> > I'm confused, don't you need to store the information in the
> > framebuffer tag for use after relocation?
> 
> If there was a consumer - yes. Right now this tag is used only to
> invalidate the information taken from the other tag (or to suppress
> taking values from there if that other tag came later) in case the
> framebuffer type doesn't match what we support.
> 
> >> +            break;
> >> +#endif /* CONFIG_VIDEO */
> >> +
> >>          case MULTIBOOT2_TAG_TYPE_END:
> >> -            return mbi_out;
> >> +            goto end; /* Cannot "break;" here. */
> >>  
> >>          default:
> >>              break;
> >>          }
> >>  
> >> + end:
> >> +
> >> +#ifdef CONFIG_VIDEO
> >> +    if ( video )
> >> +        video->orig_video_isVGA = 0x23;
> > 
> > I see we use this elsewhere, what's the meaning of this (magic) 0x23?
> 
> This is a value Linux uses (also as a plain number without any #define
> iirc; at least it was that way when we first inherited that value).
> Short of knowing where they took it from or what meaning they associate
> with the value it would be hard for us to give this a (meaningful) name
> and hence use a #define. And hence it's equally hard to properly answer
> your question.

OK, so it's a magic value. I'm happy with the rest, so:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 11:37:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 11:37:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298764.509073 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhUr-0003cq-Pa; Tue, 05 Apr 2022 11:37:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298764.509073; Tue, 05 Apr 2022 11:37:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhUr-0003cj-MD; Tue, 05 Apr 2022 11:37:17 +0000
Received: by outflank-mailman (input) for mailman id 298764;
 Tue, 05 Apr 2022 11:37:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbhUq-0003cY-4Z; Tue, 05 Apr 2022 11:37:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbhUq-0007ic-1w; Tue, 05 Apr 2022 11:37:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbhUp-0003p8-GG; Tue, 05 Apr 2022 11:37:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbhUp-0003Gp-FI; Tue, 05 Apr 2022 11:37:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ie4RvdhIsDd99kwfwYApSCvWo73b3fbDM4gWMx64wIM=; b=UvFxYMFSD1sqI+3RTx2PrMHiil
	FKYAOjDuoUY6H8OOicBKVBjZDz7P/uNr8YFfrqrRl6atloWz7BJ0olxZeZPUcOf9HYQNN68Posd7A
	Wrd2M/vBEQX/o2TAM6CVAK7peSSctN2kBFoHS1TENAL48Hw+ZypAeRXYNt6JdRxgBuiU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169166-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169166: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-xl:debian-fixup:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=20661b75ea6093f5e59079d00a778a972d6732c5
X-Osstest-Versions-That:
    qemuu=bc6ec396d471d9e4aae7e2ff8b72e11da9a97665
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 11:37:15 +0000

flight 169166 qemu-mainline real [real]
flight 169176 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169166/
http://logs.test-lab.xenproject.org/osstest/logs/169176/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl          13 debian-fixup        fail pass in 169176-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 169176 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 169176 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169138
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169138
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169138
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169138
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169138
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169138
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169138
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169138
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                20661b75ea6093f5e59079d00a778a972d6732c5
baseline version:
 qemuu                bc6ec396d471d9e4aae7e2ff8b72e11da9a97665

Last test of basis   169138  2022-04-03 02:47:41 Z    2 days
Testing same since   169166  2022-04-04 20:07:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Frederic Barrat <fbarrat@linux.ibm.com>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   bc6ec396d4..20661b75ea  20661b75ea6093f5e59079d00a778a972d6732c5 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 12:01:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 12:01:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298778.509124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhrf-0007iI-4z; Tue, 05 Apr 2022 12:00:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298778.509124; Tue, 05 Apr 2022 12:00:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhre-0007hZ-UP; Tue, 05 Apr 2022 12:00:50 +0000
Received: by outflank-mailman (input) for mailman id 298778;
 Tue, 05 Apr 2022 12:00:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c4fh=UP=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1nbhrc-0006zD-SG
 for xen-devel@lists.xen.org; Tue, 05 Apr 2022 12:00:48 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 052222c9-b4d8-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 14:00:45 +0200 (CEST)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1nbhrJ-00089f-9D; Tue, 05 Apr 2022 12:00:29 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1nbhrJ-0003ND-7u; Tue, 05 Apr 2022 12:00:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 052222c9-b4d8-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=uAa4rt+WlrdIm7/s7V4hHRZWj/juwIshO15Nn5O7OWY=; b=1tM9nLL9+P4paAyk2PLIOjeHPv
	pcgVik8axwq3MfUtphe4MyFkd3vBGjkrAeZR/Gzrz729lXhJcQjo3Lk5wD8Atjt2sgNjlj0e2LbMW
	eIVv9XJ9PwPzcUYFxsh4YJ12HG+YnjCXvF3Pj8DkHU1qq+3eIRivrzSXhhCetaqix9c0=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 399 v2 (CVE-2022-26357) - race in VT-d
 domain ID cleanup
Message-Id: <E1nbhrJ-0003ND-7u@xenbits.xenproject.org>
Date: Tue, 05 Apr 2022 12:00:29 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

            Xen Security Advisory CVE-2022-26357 / XSA-399
                               version 2

                    race in VT-d domain ID cleanup

UPDATES IN VERSION 2
====================

Public release.

ISSUE DESCRIPTION
=================

Xen domain IDs are up to 15 bits wide.  VT-d hardware may allow for only
less than 15 bits to hold a domain ID associating a physical device with
a particular domain.  Therefore internally Xen domain IDs are mapped to
the smaller value range.  The cleaning up of the housekeeping structures
has a race, allowing for VT-d domain IDs to be leaked and flushes to be
bypassed.

IMPACT
======

The precise impact is system specific, but would typically be a Denial
of Service (DoS) affecting the entire host.  Privilege escalation and
information leaks cannot be ruled out.

VULNERABLE SYSTEMS
==================

Xen versions 4.11 through 4.16 are vulnerable.  Xen versions 4.10 and
earlier are not vulnerable.

Only x86 systems with VT-d IOMMU hardware are vulnerable.  Arm systems
as well as x86 systems without VT-d hardware or without any IOMMUs in
use are not vulnerable.

Only x86 guests which have physical devices passed through to them can
leverage the vulnerability.

MITIGATION
==========

Not passing through physical devices to untrusted guests will avoid
the vulnerability.

CREDITS
=======

This issue was discovered by Jan Beulich of SUSE.

RESOLUTION
==========

Applying the appropriate attached patch resolves this issue.

Note that patches for released versions are generally prepared to
apply to the stable branches, and may not apply cleanly to the most
recent release tarball.  Downstreams are encouraged to update to the
tip of the stable branch before applying these patches.

xsa399.patch           xen-unstable
xsa399-4.16.patch      Xen 4.16.x - Xen 4.13.x
xsa399-4.12.patch      Xen 4.12.x

$ sha256sum xsa399*
53b9745564eb21f70dbb7bd7194ff3518f29cd9715c68e9dd7eff25812968019  xsa399.patch
16c3327a60d8ab6c3524f10f57d63efaf2e3e54b807bc285a749cd1a94392a30  xsa399-4.12.patch
79d0f5a0442dec0a806d77a722a1d2c04793572fe0b564bf86dcd1c6d992a679  xsa399-4.16.patch
$

DEPLOYMENT DURING EMBARGO
=========================

Deployment of the patches described above (or others which are
substantially similar) is permitted during the embargo, even on
public-facing systems with untrusted guest users and administrators.

HOWEVER, deployment of the mitigation is NOT permitted (except where
all the affected systems and VMs are administered and used only by
organisations which are members of the Xen Project Security Issues
Predisclosure List).  Specifically, deployment on public cloud systems
is NOT permitted.

This is because removal of pass-through devices or their replacement by
emulated devices is a guest visible configuration change, which may lead
to re-discovery of the issue.

Deployment of this mitigation is permitted only AFTER the embargo ends.

AND: Distribution of updated software is prohibited (except to other
members of the predisclosure list).

Predisclosure list members who wish to deploy significantly different
patches and/or mitigations, please contact the Xen Project Security
Team.

(Note: this during-embargo deployment notice is retained in
post-embargo publicly released Xen Project advisories, even though it
is then no longer applicable.  This is to enable the community to have
oversight of the Xen Project Security Team's decisionmaking.)

For more information about permissible uses of embargoed information,
consult the Xen Project community's agreed Security Policy:
  http://www.xenproject.org/security-policy.html
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmJMJDcMHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZpo8H/AqiAS0l5WJWl00bTQ4Q69REzd83m9Y3+UnUqRaf
JUFWo4R1m4V2zJlq0E3TR/2ZS1RkXFJxlmXQyzueFmDEvMV2oKB0ids5ta1oUO2E
eiQxdSFbTLrLnhI+4IxbTHHy+ovSHT/SKPeo1Zd1tXHfZ35g1OgGTYHHqj7RKJHp
SyZT4iuAKjIr61M4NBKJcycpfRidlXEDvAotDX3jBQ06t3vgs/12nwe5LzzeV2V4
sIDjpeDGNKzgT2NgLP2b+XMEUg1259iWb19tS3PPNJaLKSvQqTBOFjK+sqh7ACXV
v6ph2Yy0Q/ZP+N9DvCeBCPEU9A9RhmPYzobU+Lc/T85SrQ4=
=sp/Q
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa399.patch"
Content-Disposition: attachment; filename="xsa399.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBjb3JyZWN0IG9yZGVyaW5nIG9mIG9wZXJhdGlvbnMgaW4gY2xl
YW51cF9kb21pZF9tYXAoKQoKVGhlIGZ1bmN0aW9uIG1heSBiZSBjYWxsZWQg
d2l0aG91dCBhbnkgbG9ja3MgaGVsZCAobGVhdmluZyBhc2lkZSB0aGUKZG9t
Y3RsIG9uZSwgd2hpY2ggd2Ugc3VyZWx5IGRvbid0IHdhbnQgdG8gZGVwZW5k
IG9uIGhlcmUpLCBzbyBuZWVkcyB0bwpwbGF5IHNhZmUgd3J0IG90aGVyIGFj
Y2Vzc2VzIHRvIGRvbWlkX21hcFtdIGFuZCBkb21pZF9iaXRtYXBbXS4gVGhp
cyBpcwp0byBhdm9pZCBjb250ZXh0X3NldF9kb21haW5faWQoKSdzIHdyaXRp
bmcgb2YgZG9taWRfbWFwW10gdG8gYmUgcmVzZXQgdG8KemVybyByaWdodCBh
d2F5IGluIHRoZSBjYXNlIG9mIGl0IHJhY2luZyB0aGUgZnJlZWluZyBvZiBh
IERJRC4KCkZvciB0aGUgaW50ZXJhY3Rpb24gd2l0aCBjb250ZXh0X3NldF9k
b21haW5faWQoKSBhbmQgZGlkX3RvX2RvbWFpbl9pZCgpCnNlZSB0aGUgY29k
ZSBjb21tZW50LgoKe2NoZWNrXyx9Y2xlYW51cF9kb21pZF9tYXAoKSBhcmUg
Y2FsbGVkIHdpdGggcGNpZGV2c19sb2NrIGhlbGQgb3IgZHVyaW5nCmRvbWFp
biBjbGVhbnVwIG9ubHkgKGFuZCBwY2lkZXZzX2xvY2sgaXMgYWxzbyBoZWxk
IGFyb3VuZApjb250ZXh0X3NldF9kb21haW5faWQoKSksIGkuZS4gcmFjaW5n
IGNhbGxzIHdpdGggdGhlIHNhbWUgKGRvbSwgaW9tbXUpCnR1cGxlIGNhbm5v
dCBvY2N1ci4KCmRvbWFpbl9pb21tdV9kb21pZCgpLCBiZXNpZGVzIGl0cyB1
c2UgYnkgY2xlYW51cF9kb21pZF9tYXAoKSwgaGFzIGl0cwpyZXN1bHQgdXNl
ZCBvbmx5IHRvIGNvbnRyb2wgZmx1c2hpbmcsIGFuZCBoZW5jZSBhIHN0YWxl
IHJlc3VsdCB3b3VsZApvbmx5IGxlYWQgdG8gYSBzdHJheSBleHRyYSBmbHVz
aC4KClRoaXMgaXMgQ1ZFLTIwMjItMjYzNTcgLyBYU0EtMzk5LgoKRml4ZXM6
IGI5YzIwYzc4Nzg5ZiAoIlZULWQ6IHBlci1pb21tdSBkb21haW4taWQiKQpT
aWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9p
b21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21t
dS5jCkBAIC0xNzUsOCArMTc1LDE0IEBAIHN0YXRpYyB2b2lkIGNsZWFudXBf
ZG9taWRfbWFwKHN0cnVjdCBkb20KIAogICAgIGlmICggaW9tbXVfZG9taWQg
Pj0gMCApCiAgICAgeworICAgICAgICAvKgorICAgICAgICAgKiBVcGRhdGUg
ZG9taWRfbWFwW10gL2JlZm9yZS8gZG9taWRfYml0bWFwW10gdG8gYXZvaWQg
YSByYWNlIHdpdGgKKyAgICAgICAgICogY29udGV4dF9zZXRfZG9tYWluX2lk
KCksIHNldHRpbmcgdGhlIHNsb3QgdG8gRE9NSURfSU5WQUxJRCBmb3IKKyAg
ICAgICAgICogZGlkX3RvX2RvbWFpbl9pZCgpIHRvIHJldHVybiBhIHN1aXRh
YmxlIHZhbHVlIHdoaWxlIHRoZSBiaXQgaXMKKyAgICAgICAgICogc3RpbGwg
c2V0LgorICAgICAgICAgKi8KKyAgICAgICAgaW9tbXUtPmRvbWlkX21hcFtp
b21tdV9kb21pZF0gPSBET01JRF9JTlZBTElEOwogICAgICAgICBjbGVhcl9i
aXQoaW9tbXVfZG9taWQsIGlvbW11LT5kb21pZF9iaXRtYXApOwotICAgICAg
ICBpb21tdS0+ZG9taWRfbWFwW2lvbW11X2RvbWlkXSA9IDA7CiAgICAgfQog
fQogCg==

--=separator
Content-Type: application/octet-stream; name="xsa399-4.12.patch"
Content-Disposition: attachment; filename="xsa399-4.12.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBjb3JyZWN0IG9yZGVyaW5nIG9mIG9wZXJhdGlvbnMgaW4gY2xl
YW51cF9kb21pZF9tYXAoKQoKVGhlIGZ1bmN0aW9uIG1heSBiZSBjYWxsZWQg
d2l0aG91dCBhbnkgbG9ja3MgaGVsZCAobGVhdmluZyBhc2lkZSB0aGUKZG9t
Y3RsIG9uZSwgd2hpY2ggd2Ugc3VyZWx5IGRvbid0IHdhbnQgdG8gZGVwZW5k
IG9uIGhlcmUpLCBzbyBuZWVkcyB0bwpwbGF5IHNhZmUgd3J0IG90aGVyIGFj
Y2Vzc2VzIHRvIGRvbWlkX21hcFtdIGFuZCBkb21pZF9iaXRtYXBbXS4gVGhp
cyBpcwp0byBhdm9pZCBjb250ZXh0X3NldF9kb21haW5faWQoKSdzIHdyaXRp
bmcgb2YgZG9taWRfbWFwW10gdG8gYmUgcmVzZXQgdG8KemVybyByaWdodCBh
d2F5IGluIHRoZSBjYXNlIG9mIGl0IHJhY2luZyB0aGUgZnJlZWluZyBvZiBh
IERJRC4KCkZvciB0aGUgaW50ZXJhY3Rpb24gd2l0aCBjb250ZXh0X3NldF9k
b21haW5faWQoKSBhbmQgLT5kb21pZF9tYXBbXSByZWFkcwpzZWUgdGhlIGNv
ZGUgY29tbWVudC4KCntjaGVja18sfWNsZWFudXBfZG9taWRfbWFwKCkgYXJl
IGNhbGxlZCB3aXRoIHBjaWRldnNfbG9jayBoZWxkIG9yIGR1cmluZwpkb21h
aW4gY2xlYW51cCBvbmx5IChhbmQgcGNpZGV2c19sb2NrIGlzIGFsc28gaGVs
ZCBhcm91bmQKY29udGV4dF9zZXRfZG9tYWluX2lkKCkpLCBpLmUuIHJhY2lu
ZyBjYWxscyB3aXRoIHRoZSBzYW1lIChkb20sIGlvbW11KQp0dXBsZSBjYW5u
b3Qgb2NjdXIuCgpkb21haW5faW9tbXVfZG9taWQoKSwgYmVzaWRlcyBpdHMg
dXNlIGJ5IGNsZWFudXBfZG9taWRfbWFwKCksIGhhcyBpdHMKcmVzdWx0IHVz
ZWQgb25seSB0byBjb250cm9sIGZsdXNoaW5nLCBhbmQgaGVuY2UgYSBzdGFs
ZSByZXN1bHQgd291bGQKb25seSBsZWFkIHRvIGEgc3RyYXkgZXh0cmEgZmx1
c2guCgpUaGlzIGlzIENWRS0yMDIyLTI2MzU3IC8gWFNBLTM5OS4KCkZpeGVz
OiBiOWMyMGM3ODc4OWYgKCJWVC1kOiBwZXItaW9tbXUgZG9tYWluLWlkIikK
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
PgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNp
dHJpeC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv
aW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t
bXUuYwpAQCAtMTc3MCw4ICsxNzcwLDE0IEBAIHN0YXRpYyBpbnQgZG9tYWlu
X2NvbnRleHRfdW5tYXAoc3RydWN0IGQKICAgICAgICAgICAgIGdvdG8gb3V0
OwogICAgICAgICB9CiAKKyAgICAgICAgLyoKKyAgICAgICAgICogVXBkYXRl
IGRvbWlkX21hcFtdIC9iZWZvcmUvIGRvbWlkX2JpdG1hcFtdIHRvIGF2b2lk
IGEgcmFjZSB3aXRoCisgICAgICAgICAqIGNvbnRleHRfc2V0X2RvbWFpbl9p
ZCgpLCBzZXR0aW5nIHRoZSBzbG90IHRvIERPTUlEX0lOVkFMSUQgZm9yCisg
ICAgICAgICAqIC0+ZG9taWRfbWFwW10gcmVhZHMgdG8gcHJvZHVjZSBhIHN1
aXRhYmxlIHZhbHVlIHdoaWxlIHRoZSBiaXQgaXMKKyAgICAgICAgICogc3Rp
bGwgc2V0LgorICAgICAgICAgKi8KKyAgICAgICAgaW9tbXUtPmRvbWlkX21h
cFtpb21tdV9kb21pZF0gPSBET01JRF9JTlZBTElEOwogICAgICAgICBjbGVh
cl9iaXQoaW9tbXVfZG9taWQsIGlvbW11LT5kb21pZF9iaXRtYXApOwotICAg
ICAgICBpb21tdS0+ZG9taWRfbWFwW2lvbW11X2RvbWlkXSA9IDA7CiAgICAg
fQogCiBvdXQ6Cg==

--=separator
Content-Type: application/octet-stream; name="xsa399-4.16.patch"
Content-Disposition: attachment; filename="xsa399-4.16.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBjb3JyZWN0IG9yZGVyaW5nIG9mIG9wZXJhdGlvbnMgaW4gY2xl
YW51cF9kb21pZF9tYXAoKQoKVGhlIGZ1bmN0aW9uIG1heSBiZSBjYWxsZWQg
d2l0aG91dCBhbnkgbG9ja3MgaGVsZCAobGVhdmluZyBhc2lkZSB0aGUKZG9t
Y3RsIG9uZSwgd2hpY2ggd2Ugc3VyZWx5IGRvbid0IHdhbnQgdG8gZGVwZW5k
IG9uIGhlcmUpLCBzbyBuZWVkcyB0bwpwbGF5IHNhZmUgd3J0IG90aGVyIGFj
Y2Vzc2VzIHRvIGRvbWlkX21hcFtdIGFuZCBkb21pZF9iaXRtYXBbXS4gVGhp
cyBpcwp0byBhdm9pZCBjb250ZXh0X3NldF9kb21haW5faWQoKSdzIHdyaXRp
bmcgb2YgZG9taWRfbWFwW10gdG8gYmUgcmVzZXQgdG8KemVybyByaWdodCBh
d2F5IGluIHRoZSBjYXNlIG9mIGl0IHJhY2luZyB0aGUgZnJlZWluZyBvZiBh
IERJRC4KCkZvciB0aGUgaW50ZXJhY3Rpb24gd2l0aCBjb250ZXh0X3NldF9k
b21haW5faWQoKSBhbmQgLT5kb21pZF9tYXBbXSByZWFkcwpzZWUgdGhlIGNv
ZGUgY29tbWVudC4KCntjaGVja18sfWNsZWFudXBfZG9taWRfbWFwKCkgYXJl
IGNhbGxlZCB3aXRoIHBjaWRldnNfbG9jayBoZWxkIG9yIGR1cmluZwpkb21h
aW4gY2xlYW51cCBvbmx5IChhbmQgcGNpZGV2c19sb2NrIGlzIGFsc28gaGVs
ZCBhcm91bmQKY29udGV4dF9zZXRfZG9tYWluX2lkKCkpLCBpLmUuIHJhY2lu
ZyBjYWxscyB3aXRoIHRoZSBzYW1lIChkb20sIGlvbW11KQp0dXBsZSBjYW5u
b3Qgb2NjdXIuCgpkb21haW5faW9tbXVfZG9taWQoKSwgYmVzaWRlcyBpdHMg
dXNlIGJ5IGNsZWFudXBfZG9taWRfbWFwKCksIGhhcyBpdHMKcmVzdWx0IHVz
ZWQgb25seSB0byBjb250cm9sIGZsdXNoaW5nLCBhbmQgaGVuY2UgYSBzdGFs
ZSByZXN1bHQgd291bGQKb25seSBsZWFkIHRvIGEgc3RyYXkgZXh0cmEgZmx1
c2guCgpUaGlzIGlzIENWRS0yMDIyLTI2MzU3IC8gWFNBLTM5OS4KCkZpeGVz
OiBiOWMyMGM3ODc4OWYgKCJWVC1kOiBwZXItaW9tbXUgZG9tYWluLWlkIikK
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
PgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNp
dHJpeC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv
aW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t
bXUuYwpAQCAtMTUyLDggKzE1MiwxNCBAQCBzdGF0aWMgdm9pZCBjbGVhbnVw
X2RvbWlkX21hcChzdHJ1Y3QgZG9tCiAKICAgICBpZiAoIGlvbW11X2RvbWlk
ID49IDAgKQogICAgIHsKKyAgICAgICAgLyoKKyAgICAgICAgICogVXBkYXRl
IGRvbWlkX21hcFtdIC9iZWZvcmUvIGRvbWlkX2JpdG1hcFtdIHRvIGF2b2lk
IGEgcmFjZSB3aXRoCisgICAgICAgICAqIGNvbnRleHRfc2V0X2RvbWFpbl9p
ZCgpLCBzZXR0aW5nIHRoZSBzbG90IHRvIERPTUlEX0lOVkFMSUQgZm9yCisg
ICAgICAgICAqIC0+ZG9taWRfbWFwW10gcmVhZHMgdG8gcHJvZHVjZSBhIHN1
aXRhYmxlIHZhbHVlIHdoaWxlIHRoZSBiaXQgaXMKKyAgICAgICAgICogc3Rp
bGwgc2V0LgorICAgICAgICAgKi8KKyAgICAgICAgaW9tbXUtPmRvbWlkX21h
cFtpb21tdV9kb21pZF0gPSBET01JRF9JTlZBTElEOwogICAgICAgICBjbGVh
cl9iaXQoaW9tbXVfZG9taWQsIGlvbW11LT5kb21pZF9iaXRtYXApOwotICAg
ICAgICBpb21tdS0+ZG9taWRfbWFwW2lvbW11X2RvbWlkXSA9IDA7CiAgICAg
fQogfQogCg==

--=separator--


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 12:01:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 12:01:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298777.509119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhre-0007fJ-RT; Tue, 05 Apr 2022 12:00:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298777.509119; Tue, 05 Apr 2022 12:00:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhre-0007eJ-N3; Tue, 05 Apr 2022 12:00:50 +0000
Received: by outflank-mailman (input) for mailman id 298777;
 Tue, 05 Apr 2022 12:00:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c4fh=UP=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1nbhrc-0006xb-Eh
 for xen-devel@lists.xen.org; Tue, 05 Apr 2022 12:00:48 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03ff18e3-b4d8-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 14:00:44 +0200 (CEST)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1nbhrE-00089F-Kf; Tue, 05 Apr 2022 12:00:24 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1nbhrE-0003M1-JC; Tue, 05 Apr 2022 12:00:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03ff18e3-b4d8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=DcM+cNwwuhmEECAxkkt/2fSZTOfORjsP7OIOvhD43Oc=; b=c818RN9FSjmzpoAbgDU62B/+Sg
	oY1xtmTrtAsDjuFdCoVf+htRPxYg0xPJPSeEkTWZI4RzbOzX+P4otcMF8clJCnEGpRkuzSPYuwTgL
	iyuMh/zxlQqDIZqC4IJ6rxwToKHWkKVbXWZZqPYt0JsXdAzeEr32BziXyitJoF7irl9M=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 397 v2 (CVE-2022-26356) - Racy interactions
 between dirty vram tracking and paging log dirty hypercalls
Message-Id: <E1nbhrE-0003M1-JC@xenbits.xenproject.org>
Date: Tue, 05 Apr 2022 12:00:24 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

            Xen Security Advisory CVE-2022-26356 / XSA-397
                               version 2

 Racy interactions between dirty vram tracking and paging log dirty hypercalls

UPDATES IN VERSION 2
====================

Public release.

ISSUE DESCRIPTION
=================

Activation of log dirty mode done by XEN_DMOP_track_dirty_vram (was named
HVMOP_track_dirty_vram before Xen 4.9) is racy with ongoing log dirty
hypercalls.  A suitably timed call to XEN_DMOP_track_dirty_vram can enable
log dirty while another CPU is still in the process of tearing down the
structures related to a previously enabled log dirty mode
(XEN_DOMCTL_SHADOW_OP_OFF).  This is due to lack of mutually exclusive locking
between both operations and can lead to entries being added in already freed
slots, resulting in a memory leak.

IMPACT
======

An attacker can cause Xen to leak memory, eventually leading to a Denial of
Service (DoS) affecting the entire host.

VULNERABLE SYSTEMS
==================

All Xen versions from at least 4.0 onwards are vulnerable.

Only x86 systems are vulnerable.  Arm systems are not vulnerable.

Only domains controlling an x86 HVM guest using Hardware Assisted Paging (HAP)
can leverage the vulnerability.  On common deployments this is limited to
domains that run device models on behalf of guests.

MITIGATION
==========

Using only PV or PVH guests and/or running HVM guests in shadow mode will avoid
the vulnerability.

CREDITS
=======

This issue was discovered by Roger Pau Monné of Citrix.

RESOLUTION
==========

Applying the appropriate attached patch resolves this issue.

Note that patches for released versions are generally prepared to
apply to the stable branches, and may not apply cleanly to the most
recent release tarball.  Downstreams are encouraged to update to the
tip of the stable branch before applying these patches.

xsa397.patch           xen-unstable
xsa397-4.16.patch      Xen 4.16.x - Xen 4.15.x
xsa397-4.14.patch      Xen 4.14.x - Xen 4.13.x
xsa397-4.12.patch      Xen 4.12.x

$ sha256sum xsa397*
49c663e2bb9131dbc2488e12487f79bdf0dafd51a32413cbf3964e39d8779cae  xsa397.patch
24f95f47b79739c9cb5b9110137c802989356c82d0aa27963b5ac7e33f667285  xsa397-4.12.patch
9af14f90ba10d074425eb6072a6c648082c92c1cf8b6f881f57ed2fc13d6e49d  xsa397-4.14.patch
ff5dd3b7a8dbf349c3b832b7916322c0296fa59c7f9cd2ba30858989add5f65c  xsa397-4.16.patch
$

DEPLOYMENT DURING EMBARGO
=========================

Deployment of the patches described above (or others which are substantially
similar) is permitted during the embargo, even on public-facing systems with
untrusted guest users and administrators.

But: Distribution of updated software (except to other members of the
predisclosure list) or deployment of mitigations is prohibited.

Predisclosure list members who wish to deploy significantly different
patches and/or mitigations, please contact the Xen Project Security
Team.


(Note: this during-embargo deployment notice is retained in
post-embargo publicly released Xen Project advisories, even though it
is then no longer applicable.  This is to enable the community to have
oversight of the Xen Project Security Team's decisionmaking.)

For more information about permissible uses of embargoed information,
consult the Xen Project community's agreed Security Policy:
  http://www.xenproject.org/security-policy.html
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmJMJDEMHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZOUMH/RRZ8aMaoywqTV38SeTFne2tFT5jnWPPXR1ZGCvh
825hmSqzcYUaILbWFruUfT2PdpGoU9Eprz3xWXBDwgsUEGvKt7ZhGoWvxzXASlDh
cPRh/XwQVEEYsB1cRSk/GoLxLCQEV8oGNpmAcjEM4K1dG0VbVaRD0W2thNCmyPcv
d7aTkAdD2IE8NU4hX8YGN6v+UCkjrgzL0AF/hff9CMj7Sn/wBRrdStLT0LDZU20c
G/5+9nsOAVM7EwrzImI5Lx9KELyHwl37XUPffbftyTLUofdHJ5PK40J1tNIRS/RW
YYvs2alF7ng7LlwB/Go8gtn4XRx6xZidceYrUk22oB4JBqo=
=Fje3
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa397.patch"
Content-Disposition: attachment; filename="xsa397.patch"
Content-Transfer-Encoding: base64

RnJvbSA1NWE5YWNlZjg1N2NjMGFiYmEyOTk2Y2FhNGZjYjRjOGQ1ZGNmNTgw
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u
bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBXZWQsIDIzIEZlYiAy
MDIyIDA5OjQwOjQwICswMTAwClN1YmplY3Q6IFtQQVRDSF0geDg2L2hhcDog
ZG8gbm90IHN3aXRjaCBvbiBsb2cgZGlydHkgZm9yIFZSQU0gdHJhY2tpbmcK
ClhFTl9ETU9QX3RyYWNrX2RpcnR5X3ZyYW0gcG9zc2libHkgY2FsbHMgaW50
byBwYWdpbmdfbG9nX2RpcnR5X2VuYWJsZQp3aGVuIHVzaW5nIEhBUCBtb2Rl
LCBhbmQgaXQgY2FuIGludGVyYWN0IGJhZGx5IHdpdGggb3RoZXIgb25nb2lu
ZwpwYWdpbmcgZG9tY3RscywgYXMgWEVOX0RNT1BfdHJhY2tfZGlydHlfdnJh
bSBpcyBub3QgaG9sZGluZyB0aGUgZG9tY3RsCmxvY2suCgpUaGlzIHdhcyBk
ZXRlY3RlZCBhcyBhIHJlc3VsdCBvZiB0aGUgZm9sbG93aW5nIGFzc2VydCB0
cmlnZ2VyaW5nIHdoZW4KZG9pbmcgcmVwZWF0ZWQgbWlncmF0aW9ucyBvZiBh
IEhBUCBIVk0gZG9tYWluIHdpdGggYSBzdHViZG9tOgoKQXNzZXJ0aW9uICdk
LT5hcmNoLnBhZ2luZy5sb2dfZGlydHkuYWxsb2NzID09IDAnIGZhaWxlZCBh
dCBwYWdpbmcuYzoxOTgKLS0tLVsgWGVuLTQuMTctdW5zdGFibGUgIHg4Nl82
NCAgZGVidWc9eSAgTm90IHRhaW50ZWQgXS0tLS0KQ1BVOiAgICAzNApSSVA6
ICAgIGUwMDg6WzxmZmZmODJkMDQwMzE0YjNiPl0gYXJjaC94ODYvbW0vcGFn
aW5nLmMjcGFnaW5nX2ZyZWVfbG9nX2RpcnR5X2JpdG1hcCsweDYwNi8weDYK
UkZMQUdTOiAwMDAwMDAwMDAwMDEwMjA2ICAgQ09OVEVYVDogaHlwZXJ2aXNv
ciAoZDB2MjMpClsuLi5dClhlbiBjYWxsIHRyYWNlOgogICBbPGZmZmY4MmQw
NDAzMTRiM2I+XSBSIGFyY2gveDg2L21tL3BhZ2luZy5jI3BhZ2luZ19mcmVl
X2xvZ19kaXJ0eV9iaXRtYXArMHg2MDYvMHg2M2EKICAgWzxmZmZmODJkMDQw
Mjc5Zjk2Pl0gUyB4c20vZmxhc2svaG9va3MuYyNkb21haW5faGFzX3Blcm0r
MHg1YS8weDY3CiAgIFs8ZmZmZjgyZDA0MDMxNTc3Zj5dIEYgcGFnaW5nX2Rv
bWN0bCsweDI1MS8weGQ0MQogICBbPGZmZmY4MmQwNDAzMTY0MGM+XSBGIHBh
Z2luZ19kb21jdGxfY29udGludWF0aW9uKzB4MTlkLzB4MjAyCiAgIFs8ZmZm
ZjgyZDA0MDMyMDJmYT5dIEYgcHZfaHlwZXJjYWxsKzB4MTUwLzB4MmE3CiAg
IFs8ZmZmZjgyZDA0MDNhNzI5ZD5dIEYgbHN0YXJfZW50ZXIrMHgxMmQvMHgx
NDAKClN1Y2ggYXNzZXJ0IHRyaWdnZXJlZCBiZWNhdXNlIHRoZSBzdHViZG9t
IHVzZWQKWEVOX0RNT1BfdHJhY2tfZGlydHlfdnJhbSB3aGlsZSBkb20wIHdh
cyBpbiB0aGUgbWlkZGxlIG9mIGV4ZWN1dGluZwpYRU5fRE9NQ1RMX1NIQURP
V19PUF9PRkYsIGFuZCBzbyBsb2cgZGlydHkgYmVjb21lIGVuYWJsZWQgd2hp
bGUKcmV0aXJpbmcgdGhlIG9sZCBzdHJ1Y3R1cmVzLCB0aHVzIGxlYWRpbmcg
dG8gbmV3IGVudHJpZXMgYmVpbmcKcG9wdWxhdGVkIGluIGFscmVhZHkgY2xl
YXIgc2xvdHMuCgpGaXggdGhpcyBieSBub3QgZW5hYmxpbmcgbG9nIGRpcnR5
IGZvciBWUkFNIHRyYWNraW5nLCBzaW1pbGFyIHRvIHdoYXQKaXMgZG9uZSB3
aGVuIHVzaW5nIHNoYWRvdyBpbnN0ZWFkIG9mIEhBUC4gQ2FsbApwMm1fZW5h
YmxlX2hhcmR3YXJlX2xvZ19kaXJ0eSB3aGVuIGVuYWJsaW5nIFZSQU0gdHJh
Y2tpbmcgaW4gb3JkZXIgdG8KZ2V0IHNvbWUgaGFyZHdhcmUgYXNzaXN0YW5j
ZSBpZiBhdmFpbGFibGUuIEFzIGEgc2lkZSBlZmZlY3QgdGhlIG1lbW9yeQpw
cmVzc3VyZSBvbiB0aGUgcDJtIHBvb2wgc2hvdWxkIGdvIGRvd24gaWYgb25s
eSBWUkFNIHRyYWNraW5nIGlzCmVuYWJsZWQsIGFzIHRoZSBkaXJ0eSBiaXRt
YXAgaXMgbm8gbG9uZ2VyIGFsbG9jYXRlZC4KCk5vdGUgdGhhdCBwYWdpbmdf
bG9nX2RpcnR5X3JhbmdlICh1c2VkIHRvIGdldCB0aGUgZGlydHkgYml0bWFw
IGZvcgpWUkFNIHRyYWNraW5nKSBkb2Vzbid0IHVzZSB0aGUgbG9nIGRpcnR5
IGJpdG1hcCwgYW5kIGluc3RlYWQgcmVsaWVzIG9uCmNoZWNraW5nIHdoZXRo
ZXIgZWFjaCBnZm4gb24gdGhlIHJhbmdlIGhhcyBiZWVuIHN3aXRjaGVkIGZy
b20KcDJtX3JhbV9sb2dkaXJ0eSB0byBwMm1fcmFtX3J3IGluIG9yZGVyIHRv
IGFjY291bnQgZm9yIGRpcnR5IHBhZ2VzLgoKVGhpcyBpcyBDVkUtMjAyMi0y
NjM1NiAvIFhTQS0zOTcuCgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9u
bsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KLS0tCiB4ZW4vYXJjaC94ODYv
aW5jbHVkZS9hc20vcGFnaW5nLmggfCAgMyAtLS0KIHhlbi9hcmNoL3g4Ni9t
bS9oYXAvaGFwLmMgICAgICAgICB8IDExICsrKystLS0tLS0tCiB4ZW4vYXJj
aC94ODYvbW0vcGFnaW5nLmMgICAgICAgICAgfCAgMiArLQogMyBmaWxlcyBj
aGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlm
ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9wYWdpbmcuaCBi
L3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9wYWdpbmcuaAppbmRleCAyZGRj
ZmIwMjJjLi5lMjBhNWY5MTY2IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv
aW5jbHVkZS9hc20vcGFnaW5nLmgKKysrIGIveGVuL2FyY2gveDg2L2luY2x1
ZGUvYXNtL3BhZ2luZy5oCkBAIC0xNjAsOSArMTYwLDYgQEAgdm9pZCBwYWdp
bmdfbG9nX2RpcnR5X3JhbmdlKHN0cnVjdCBkb21haW4gKmQsCiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBuciwKICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB1aW50OF90ICpkaXJ0eV9iaXRtYXAp
OwogCi0vKiBlbmFibGUgbG9nIGRpcnR5ICovCi1pbnQgcGFnaW5nX2xvZ19k
aXJ0eV9lbmFibGUoc3RydWN0IGRvbWFpbiAqZCwgYm9vbCBsb2dfZ2xvYmFs
KTsKLQogLyogbG9nIGRpcnR5IGluaXRpYWxpemF0aW9uICovCiB2b2lkIHBh
Z2luZ19sb2dfZGlydHlfaW5pdChzdHJ1Y3QgZG9tYWluICpkLCBjb25zdCBz
dHJ1Y3QgbG9nX2RpcnR5X29wcyAqb3BzKTsKIApkaWZmIC0tZ2l0IGEveGVu
L2FyY2gveDg2L21tL2hhcC9oYXAuYyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAv
aGFwLmMKaW5kZXggZGU0YjEzNTY1YS4uMDQzNDE4NWE4YSAxMDA2NDQKLS0t
IGEveGVuL2FyY2gveDg2L21tL2hhcC9oYXAuYworKysgYi94ZW4vYXJjaC94
ODYvbW0vaGFwL2hhcC5jCkBAIC02OSwxMyArNjksNiBAQCBpbnQgaGFwX3Ry
YWNrX2RpcnR5X3ZyYW0oc3RydWN0IGRvbWFpbiAqZCwKICAgICB7CiAgICAg
ICAgIHVuc2lnbmVkIGludCBzaXplID0gRElWX1JPVU5EX1VQKG5yX2ZyYW1l
cywgQklUU19QRVJfQllURSk7CiAKLSAgICAgICAgaWYgKCAhcGFnaW5nX21v
ZGVfbG9nX2RpcnR5KGQpICkKLSAgICAgICAgewotICAgICAgICAgICAgcmMg
PSBwYWdpbmdfbG9nX2RpcnR5X2VuYWJsZShkLCBmYWxzZSk7Ci0gICAgICAg
ICAgICBpZiAoIHJjICkKLSAgICAgICAgICAgICAgICBnb3RvIG91dDsKLSAg
ICAgICAgfQotCiAgICAgICAgIHJjID0gLUVOT01FTTsKICAgICAgICAgZGly
dHlfYml0bWFwID0gdnphbGxvYyhzaXplKTsKICAgICAgICAgaWYgKCAhZGly
dHlfYml0bWFwICkKQEAgLTEwNyw2ICsxMDAsMTAgQEAgaW50IGhhcF90cmFj
a19kaXJ0eV92cmFtKHN0cnVjdCBkb21haW4gKmQsCiAKICAgICAgICAgICAg
IHBhZ2luZ191bmxvY2soZCk7CiAKKyAgICAgICAgICAgIGRvbWFpbl9wYXVz
ZShkKTsKKyAgICAgICAgICAgIHAybV9lbmFibGVfaGFyZHdhcmVfbG9nX2Rp
cnR5KGQpOworICAgICAgICAgICAgZG9tYWluX3VucGF1c2UoZCk7CisKICAg
ICAgICAgICAgIGlmICggb2VuZCA+IG9zdGFydCApCiAgICAgICAgICAgICAg
ICAgcDJtX2NoYW5nZV90eXBlX3JhbmdlKGQsIG9zdGFydCwgb2VuZCwKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX3JhbV9s
b2dkaXJ0eSwgcDJtX3JhbV9ydyk7CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94
ODYvbW0vcGFnaW5nLmMgYi94ZW4vYXJjaC94ODYvbW0vcGFnaW5nLmMKaW5k
ZXggZGMzYTRhMGI0Yi4uODc2NGVhNjc1MCAxMDA2NDQKLS0tIGEveGVuL2Fy
Y2gveDg2L21tL3BhZ2luZy5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wYWdp
bmcuYwpAQCAtMjEyLDcgKzIxMiw3IEBAIHN0YXRpYyBpbnQgcGFnaW5nX2Zy
ZWVfbG9nX2RpcnR5X2JpdG1hcChzdHJ1Y3QgZG9tYWluICpkLCBpbnQgcmMp
CiAgICAgcmV0dXJuIHJjOwogfQogCi1pbnQgcGFnaW5nX2xvZ19kaXJ0eV9l
bmFibGUoc3RydWN0IGRvbWFpbiAqZCwgYm9vbCBsb2dfZ2xvYmFsKQorc3Rh
dGljIGludCBwYWdpbmdfbG9nX2RpcnR5X2VuYWJsZShzdHJ1Y3QgZG9tYWlu
ICpkLCBib29sIGxvZ19nbG9iYWwpCiB7CiAgICAgaW50IHJldDsKIAotLSAK
Mi4zNC4xCgo=

--=separator
Content-Type: application/octet-stream; name="xsa397-4.12.patch"
Content-Disposition: attachment; filename="xsa397-4.12.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
U3ViamVjdDogeDg2L2hhcDogZG8gbm90IHN3aXRjaCBvbiBsb2cgZGlydHkg
Zm9yIFZSQU0gdHJhY2tpbmcKClhFTl9ETU9QX3RyYWNrX2RpcnR5X3ZyYW0g
cG9zc2libHkgY2FsbHMgaW50byBwYWdpbmdfbG9nX2RpcnR5X2VuYWJsZQp3
aGVuIHVzaW5nIEhBUCBtb2RlLCBhbmQgaXQgY2FuIGludGVyYWN0IGJhZGx5
IHdpdGggb3RoZXIgb25nb2luZwpwYWdpbmcgZG9tY3RscywgYXMgWEVOX0RN
T1BfdHJhY2tfZGlydHlfdnJhbSBpcyBub3QgaG9sZGluZyB0aGUgZG9tY3Rs
CmxvY2suCgpUaGlzIHdhcyBkZXRlY3RlZCBhcyBhIHJlc3VsdCBvZiB0aGUg
Zm9sbG93aW5nIGFzc2VydCB0cmlnZ2VyaW5nIHdoZW4KZG9pbmcgcmVwZWF0
ZWQgbWlncmF0aW9ucyBvZiBhIEhBUCBIVk0gZG9tYWluIHdpdGggYSBzdHVi
ZG9tOgoKQXNzZXJ0aW9uICdkLT5hcmNoLnBhZ2luZy5sb2dfZGlydHkuYWxs
b2NzID09IDAnIGZhaWxlZCBhdCBwYWdpbmcuYzoxOTgKLS0tLVsgWGVuLTQu
MTctdW5zdGFibGUgIHg4Nl82NCAgZGVidWc9eSAgTm90IHRhaW50ZWQgXS0t
LS0KQ1BVOiAgICAzNApSSVA6ICAgIGUwMDg6WzxmZmZmODJkMDQwMzE0YjNi
Pl0gYXJjaC94ODYvbW0vcGFnaW5nLmMjcGFnaW5nX2ZyZWVfbG9nX2RpcnR5
X2JpdG1hcCsweDYwNi8weDYKUkZMQUdTOiAwMDAwMDAwMDAwMDEwMjA2ICAg
Q09OVEVYVDogaHlwZXJ2aXNvciAoZDB2MjMpClsuLi5dClhlbiBjYWxsIHRy
YWNlOgogICBbPGZmZmY4MmQwNDAzMTRiM2I+XSBSIGFyY2gveDg2L21tL3Bh
Z2luZy5jI3BhZ2luZ19mcmVlX2xvZ19kaXJ0eV9iaXRtYXArMHg2MDYvMHg2
M2EKICAgWzxmZmZmODJkMDQwMjc5Zjk2Pl0gUyB4c20vZmxhc2svaG9va3Mu
YyNkb21haW5faGFzX3Blcm0rMHg1YS8weDY3CiAgIFs8ZmZmZjgyZDA0MDMx
NTc3Zj5dIEYgcGFnaW5nX2RvbWN0bCsweDI1MS8weGQ0MQogICBbPGZmZmY4
MmQwNDAzMTY0MGM+XSBGIHBhZ2luZ19kb21jdGxfY29udGludWF0aW9uKzB4
MTlkLzB4MjAyCiAgIFs8ZmZmZjgyZDA0MDMyMDJmYT5dIEYgcHZfaHlwZXJj
YWxsKzB4MTUwLzB4MmE3CiAgIFs8ZmZmZjgyZDA0MDNhNzI5ZD5dIEYgbHN0
YXJfZW50ZXIrMHgxMmQvMHgxNDAKClN1Y2ggYXNzZXJ0IHRyaWdnZXJlZCBi
ZWNhdXNlIHRoZSBzdHViZG9tIHVzZWQKWEVOX0RNT1BfdHJhY2tfZGlydHlf
dnJhbSB3aGlsZSBkb20wIHdhcyBpbiB0aGUgbWlkZGxlIG9mIGV4ZWN1dGlu
ZwpYRU5fRE9NQ1RMX1NIQURPV19PUF9PRkYsIGFuZCBzbyBsb2cgZGlydHkg
YmVjb21lIGVuYWJsZWQgd2hpbGUKcmV0aXJpbmcgdGhlIG9sZCBzdHJ1Y3R1
cmVzLCB0aHVzIGxlYWRpbmcgdG8gbmV3IGVudHJpZXMgYmVpbmcKcG9wdWxh
dGVkIGluIGFscmVhZHkgY2xlYXIgc2xvdHMuCgpGaXggdGhpcyBieSBub3Qg
ZW5hYmxpbmcgbG9nIGRpcnR5IGZvciBWUkFNIHRyYWNraW5nLCBzaW1pbGFy
IHRvIHdoYXQKaXMgZG9uZSB3aGVuIHVzaW5nIHNoYWRvdyBpbnN0ZWFkIG9m
IEhBUC4gQ2FsbApwMm1fZW5hYmxlX2hhcmR3YXJlX2xvZ19kaXJ0eSB3aGVu
IGVuYWJsaW5nIFZSQU0gdHJhY2tpbmcgaW4gb3JkZXIgdG8KZ2V0IHNvbWUg
aGFyZHdhcmUgYXNzaXN0YW5jZSBpZiBhdmFpbGFibGUuIEFzIGEgc2lkZSBl
ZmZlY3QgdGhlIG1lbW9yeQpwcmVzc3VyZSBvbiB0aGUgcDJtIHBvb2wgc2hv
dWxkIGdvIGRvd24gaWYgb25seSBWUkFNIHRyYWNraW5nIGlzCmVuYWJsZWQs
IGFzIHRoZSBkaXJ0eSBiaXRtYXAgaXMgbm8gbG9uZ2VyIGFsbG9jYXRlZC4K
Ck5vdGUgdGhhdCBwYWdpbmdfbG9nX2RpcnR5X3JhbmdlICh1c2VkIHRvIGdl
dCB0aGUgZGlydHkgYml0bWFwIGZvcgpWUkFNIHRyYWNraW5nKSBkb2Vzbid0
IHVzZSB0aGUgbG9nIGRpcnR5IGJpdG1hcCwgYW5kIGluc3RlYWQgcmVsaWVz
IG9uCmNoZWNraW5nIHdoZXRoZXIgZWFjaCBnZm4gb24gdGhlIHJhbmdlIGhh
cyBiZWVuIHN3aXRjaGVkIGZyb20KcDJtX3JhbV9sb2dkaXJ0eSB0byBwMm1f
cmFtX3J3IGluIG9yZGVyIHRvIGFjY291bnQgZm9yIGRpcnR5IHBhZ2VzLgoK
VGhpcyBpcyBDVkUtMjAyMi0yNjM1NiAvIFhTQS0zOTcuCgpTaWduZWQtb2Zm
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
UmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4K
Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcGFnaW5nLmgKKysrIGIveGVu
L2luY2x1ZGUvYXNtLXg4Ni9wYWdpbmcuaApAQCAtMTQ0LDkgKzE0NCw2IEBA
IHZvaWQgcGFnaW5nX2xvZ19kaXJ0eV9yYW5nZShzdHJ1Y3QgZG9tYWkKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIG5yLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgKmRpcnR5X2Jp
dG1hcCk7CiAKLS8qIGVuYWJsZSBsb2cgZGlydHkgKi8KLWludCBwYWdpbmdf
bG9nX2RpcnR5X2VuYWJsZShzdHJ1Y3QgZG9tYWluICpkLCBib29sX3QgbG9n
X2dsb2JhbCk7Ci0KIC8qIGxvZyBkaXJ0eSBpbml0aWFsaXphdGlvbiAqLwog
dm9pZCBwYWdpbmdfbG9nX2RpcnR5X2luaXQoc3RydWN0IGRvbWFpbiAqZCwg
Y29uc3Qgc3RydWN0IGxvZ19kaXJ0eV9vcHMgKm9wcyk7CiAKLS0tIGEveGVu
L2FyY2gveDg2L21tL2hhcC9oYXAuYworKysgYi94ZW4vYXJjaC94ODYvbW0v
aGFwL2hhcC5jCkBAIC02OSwxMyArNjksNiBAQCBpbnQgaGFwX3RyYWNrX2Rp
cnR5X3ZyYW0oc3RydWN0IGRvbWFpbiAqCiAgICAgewogICAgICAgICBpbnQg
c2l6ZSA9IChuciArIEJJVFNfUEVSX0JZVEUgLSAxKSAvIEJJVFNfUEVSX0JZ
VEU7CiAKLSAgICAgICAgaWYgKCAhcGFnaW5nX21vZGVfbG9nX2RpcnR5KGQp
ICkKLSAgICAgICAgewotICAgICAgICAgICAgcmMgPSBwYWdpbmdfbG9nX2Rp
cnR5X2VuYWJsZShkLCAwKTsKLSAgICAgICAgICAgIGlmICggcmMgKQotICAg
ICAgICAgICAgICAgIGdvdG8gb3V0OwotICAgICAgICB9Ci0KICAgICAgICAg
cmMgPSAtRU5PTUVNOwogICAgICAgICBkaXJ0eV9iaXRtYXAgPSB2emFsbG9j
KHNpemUpOwogICAgICAgICBpZiAoICFkaXJ0eV9iaXRtYXAgKQpAQCAtMTA3
LDYgKzEwMCwxMCBAQCBpbnQgaGFwX3RyYWNrX2RpcnR5X3ZyYW0oc3RydWN0
IGRvbWFpbiAqCiAKICAgICAgICAgICAgIHBhZ2luZ191bmxvY2soZCk7CiAK
KyAgICAgICAgICAgIGRvbWFpbl9wYXVzZShkKTsKKyAgICAgICAgICAgIHAy
bV9lbmFibGVfaGFyZHdhcmVfbG9nX2RpcnR5KGQpOworICAgICAgICAgICAg
ZG9tYWluX3VucGF1c2UoZCk7CisKICAgICAgICAgICAgIGlmICggb2VuZCA+
IG9zdGFydCApCiAgICAgICAgICAgICAgICAgcDJtX2NoYW5nZV90eXBlX3Jh
bmdlKGQsIG9zdGFydCwgb2VuZCwKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgcDJtX3JhbV9sb2dkaXJ0eSwgcDJtX3JhbV9ydyk7
Ci0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wYWdpbmcuYworKysgYi94ZW4vYXJj
aC94ODYvbW0vcGFnaW5nLmMKQEAgLTIwOSw3ICsyMDksNyBAQCBzdGF0aWMg
aW50IHBhZ2luZ19mcmVlX2xvZ19kaXJ0eV9iaXRtYXAoCiAgICAgcmV0dXJu
IHJjOwogfQogCi1pbnQgcGFnaW5nX2xvZ19kaXJ0eV9lbmFibGUoc3RydWN0
IGRvbWFpbiAqZCwgYm9vbF90IGxvZ19nbG9iYWwpCitzdGF0aWMgaW50IHBh
Z2luZ19sb2dfZGlydHlfZW5hYmxlKHN0cnVjdCBkb21haW4gKmQsIGJvb2xf
dCBsb2dfZ2xvYmFsKQogewogICAgIGludCByZXQ7CiAK

--=separator
Content-Type: application/octet-stream; name="xsa397-4.14.patch"
Content-Disposition: attachment; filename="xsa397-4.14.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
U3ViamVjdDogeDg2L2hhcDogZG8gbm90IHN3aXRjaCBvbiBsb2cgZGlydHkg
Zm9yIFZSQU0gdHJhY2tpbmcKClhFTl9ETU9QX3RyYWNrX2RpcnR5X3ZyYW0g
cG9zc2libHkgY2FsbHMgaW50byBwYWdpbmdfbG9nX2RpcnR5X2VuYWJsZQp3
aGVuIHVzaW5nIEhBUCBtb2RlLCBhbmQgaXQgY2FuIGludGVyYWN0IGJhZGx5
IHdpdGggb3RoZXIgb25nb2luZwpwYWdpbmcgZG9tY3RscywgYXMgWEVOX0RN
T1BfdHJhY2tfZGlydHlfdnJhbSBpcyBub3QgaG9sZGluZyB0aGUgZG9tY3Rs
CmxvY2suCgpUaGlzIHdhcyBkZXRlY3RlZCBhcyBhIHJlc3VsdCBvZiB0aGUg
Zm9sbG93aW5nIGFzc2VydCB0cmlnZ2VyaW5nIHdoZW4KZG9pbmcgcmVwZWF0
ZWQgbWlncmF0aW9ucyBvZiBhIEhBUCBIVk0gZG9tYWluIHdpdGggYSBzdHVi
ZG9tOgoKQXNzZXJ0aW9uICdkLT5hcmNoLnBhZ2luZy5sb2dfZGlydHkuYWxs
b2NzID09IDAnIGZhaWxlZCBhdCBwYWdpbmcuYzoxOTgKLS0tLVsgWGVuLTQu
MTctdW5zdGFibGUgIHg4Nl82NCAgZGVidWc9eSAgTm90IHRhaW50ZWQgXS0t
LS0KQ1BVOiAgICAzNApSSVA6ICAgIGUwMDg6WzxmZmZmODJkMDQwMzE0YjNi
Pl0gYXJjaC94ODYvbW0vcGFnaW5nLmMjcGFnaW5nX2ZyZWVfbG9nX2RpcnR5
X2JpdG1hcCsweDYwNi8weDYKUkZMQUdTOiAwMDAwMDAwMDAwMDEwMjA2ICAg
Q09OVEVYVDogaHlwZXJ2aXNvciAoZDB2MjMpClsuLi5dClhlbiBjYWxsIHRy
YWNlOgogICBbPGZmZmY4MmQwNDAzMTRiM2I+XSBSIGFyY2gveDg2L21tL3Bh
Z2luZy5jI3BhZ2luZ19mcmVlX2xvZ19kaXJ0eV9iaXRtYXArMHg2MDYvMHg2
M2EKICAgWzxmZmZmODJkMDQwMjc5Zjk2Pl0gUyB4c20vZmxhc2svaG9va3Mu
YyNkb21haW5faGFzX3Blcm0rMHg1YS8weDY3CiAgIFs8ZmZmZjgyZDA0MDMx
NTc3Zj5dIEYgcGFnaW5nX2RvbWN0bCsweDI1MS8weGQ0MQogICBbPGZmZmY4
MmQwNDAzMTY0MGM+XSBGIHBhZ2luZ19kb21jdGxfY29udGludWF0aW9uKzB4
MTlkLzB4MjAyCiAgIFs8ZmZmZjgyZDA0MDMyMDJmYT5dIEYgcHZfaHlwZXJj
YWxsKzB4MTUwLzB4MmE3CiAgIFs8ZmZmZjgyZDA0MDNhNzI5ZD5dIEYgbHN0
YXJfZW50ZXIrMHgxMmQvMHgxNDAKClN1Y2ggYXNzZXJ0IHRyaWdnZXJlZCBi
ZWNhdXNlIHRoZSBzdHViZG9tIHVzZWQKWEVOX0RNT1BfdHJhY2tfZGlydHlf
dnJhbSB3aGlsZSBkb20wIHdhcyBpbiB0aGUgbWlkZGxlIG9mIGV4ZWN1dGlu
ZwpYRU5fRE9NQ1RMX1NIQURPV19PUF9PRkYsIGFuZCBzbyBsb2cgZGlydHkg
YmVjb21lIGVuYWJsZWQgd2hpbGUKcmV0aXJpbmcgdGhlIG9sZCBzdHJ1Y3R1
cmVzLCB0aHVzIGxlYWRpbmcgdG8gbmV3IGVudHJpZXMgYmVpbmcKcG9wdWxh
dGVkIGluIGFscmVhZHkgY2xlYXIgc2xvdHMuCgpGaXggdGhpcyBieSBub3Qg
ZW5hYmxpbmcgbG9nIGRpcnR5IGZvciBWUkFNIHRyYWNraW5nLCBzaW1pbGFy
IHRvIHdoYXQKaXMgZG9uZSB3aGVuIHVzaW5nIHNoYWRvdyBpbnN0ZWFkIG9m
IEhBUC4gQ2FsbApwMm1fZW5hYmxlX2hhcmR3YXJlX2xvZ19kaXJ0eSB3aGVu
IGVuYWJsaW5nIFZSQU0gdHJhY2tpbmcgaW4gb3JkZXIgdG8KZ2V0IHNvbWUg
aGFyZHdhcmUgYXNzaXN0YW5jZSBpZiBhdmFpbGFibGUuIEFzIGEgc2lkZSBl
ZmZlY3QgdGhlIG1lbW9yeQpwcmVzc3VyZSBvbiB0aGUgcDJtIHBvb2wgc2hv
dWxkIGdvIGRvd24gaWYgb25seSBWUkFNIHRyYWNraW5nIGlzCmVuYWJsZWQs
IGFzIHRoZSBkaXJ0eSBiaXRtYXAgaXMgbm8gbG9uZ2VyIGFsbG9jYXRlZC4K
Ck5vdGUgdGhhdCBwYWdpbmdfbG9nX2RpcnR5X3JhbmdlICh1c2VkIHRvIGdl
dCB0aGUgZGlydHkgYml0bWFwIGZvcgpWUkFNIHRyYWNraW5nKSBkb2Vzbid0
IHVzZSB0aGUgbG9nIGRpcnR5IGJpdG1hcCwgYW5kIGluc3RlYWQgcmVsaWVz
IG9uCmNoZWNraW5nIHdoZXRoZXIgZWFjaCBnZm4gb24gdGhlIHJhbmdlIGhh
cyBiZWVuIHN3aXRjaGVkIGZyb20KcDJtX3JhbV9sb2dkaXJ0eSB0byBwMm1f
cmFtX3J3IGluIG9yZGVyIHRvIGFjY291bnQgZm9yIGRpcnR5IHBhZ2VzLgoK
VGhpcyBpcyBDVkUtMjAyMi0yNjM1NiAvIFhTQS0zOTcuCgpTaWduZWQtb2Zm
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
UmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4K
Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcGFnaW5nLmgKKysrIGIveGVu
L2luY2x1ZGUvYXNtLXg4Ni9wYWdpbmcuaApAQCAtMTYwLDkgKzE2MCw2IEBA
IHZvaWQgcGFnaW5nX2xvZ19kaXJ0eV9yYW5nZShzdHJ1Y3QgZG9tYWkKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIG5yLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgKmRpcnR5X2Jp
dG1hcCk7CiAKLS8qIGVuYWJsZSBsb2cgZGlydHkgKi8KLWludCBwYWdpbmdf
bG9nX2RpcnR5X2VuYWJsZShzdHJ1Y3QgZG9tYWluICpkLCBib29sIGxvZ19n
bG9iYWwpOwotCiAvKiBsb2cgZGlydHkgaW5pdGlhbGl6YXRpb24gKi8KIHZv
aWQgcGFnaW5nX2xvZ19kaXJ0eV9pbml0KHN0cnVjdCBkb21haW4gKmQsIGNv
bnN0IHN0cnVjdCBsb2dfZGlydHlfb3BzICpvcHMpOwogCi0tLSBhL3hlbi9h
cmNoL3g4Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21tL2hh
cC9oYXAuYwpAQCAtNjksMTMgKzY5LDYgQEAgaW50IGhhcF90cmFja19kaXJ0
eV92cmFtKHN0cnVjdCBkb21haW4gKgogICAgIHsKICAgICAgICAgaW50IHNp
emUgPSAobnIgKyBCSVRTX1BFUl9CWVRFIC0gMSkgLyBCSVRTX1BFUl9CWVRF
OwogCi0gICAgICAgIGlmICggIXBhZ2luZ19tb2RlX2xvZ19kaXJ0eShkKSAp
Ci0gICAgICAgIHsKLSAgICAgICAgICAgIHJjID0gcGFnaW5nX2xvZ19kaXJ0
eV9lbmFibGUoZCwgZmFsc2UpOwotICAgICAgICAgICAgaWYgKCByYyApCi0g
ICAgICAgICAgICAgICAgZ290byBvdXQ7Ci0gICAgICAgIH0KLQogICAgICAg
ICByYyA9IC1FTk9NRU07CiAgICAgICAgIGRpcnR5X2JpdG1hcCA9IHZ6YWxs
b2Moc2l6ZSk7CiAgICAgICAgIGlmICggIWRpcnR5X2JpdG1hcCApCkBAIC0x
MDcsNiArMTAwLDEwIEBAIGludCBoYXBfdHJhY2tfZGlydHlfdnJhbShzdHJ1
Y3QgZG9tYWluICoKIAogICAgICAgICAgICAgcGFnaW5nX3VubG9jayhkKTsK
IAorICAgICAgICAgICAgZG9tYWluX3BhdXNlKGQpOworICAgICAgICAgICAg
cDJtX2VuYWJsZV9oYXJkd2FyZV9sb2dfZGlydHkoZCk7CisgICAgICAgICAg
ICBkb21haW5fdW5wYXVzZShkKTsKKwogICAgICAgICAgICAgaWYgKCBvZW5k
ID4gb3N0YXJ0ICkKICAgICAgICAgICAgICAgICBwMm1fY2hhbmdlX3R5cGVf
cmFuZ2UoZCwgb3N0YXJ0LCBvZW5kLAogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBwMm1fcmFtX2xvZ2RpcnR5LCBwMm1fcmFtX3J3
KTsKLS0tIGEveGVuL2FyY2gveDg2L21tL3BhZ2luZy5jCisrKyBiL3hlbi9h
cmNoL3g4Ni9tbS9wYWdpbmcuYwpAQCAtMjA5LDcgKzIwOSw3IEBAIHN0YXRp
YyBpbnQgcGFnaW5nX2ZyZWVfbG9nX2RpcnR5X2JpdG1hcCgKICAgICByZXR1
cm4gcmM7CiB9CiAKLWludCBwYWdpbmdfbG9nX2RpcnR5X2VuYWJsZShzdHJ1
Y3QgZG9tYWluICpkLCBib29sIGxvZ19nbG9iYWwpCitzdGF0aWMgaW50IHBh
Z2luZ19sb2dfZGlydHlfZW5hYmxlKHN0cnVjdCBkb21haW4gKmQsIGJvb2wg
bG9nX2dsb2JhbCkKIHsKICAgICBpbnQgcmV0OwogCg==

--=separator
Content-Type: application/octet-stream; name="xsa397-4.16.patch"
Content-Disposition: attachment; filename="xsa397-4.16.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
U3ViamVjdDogeDg2L2hhcDogZG8gbm90IHN3aXRjaCBvbiBsb2cgZGlydHkg
Zm9yIFZSQU0gdHJhY2tpbmcKClhFTl9ETU9QX3RyYWNrX2RpcnR5X3ZyYW0g
cG9zc2libHkgY2FsbHMgaW50byBwYWdpbmdfbG9nX2RpcnR5X2VuYWJsZQp3
aGVuIHVzaW5nIEhBUCBtb2RlLCBhbmQgaXQgY2FuIGludGVyYWN0IGJhZGx5
IHdpdGggb3RoZXIgb25nb2luZwpwYWdpbmcgZG9tY3RscywgYXMgWEVOX0RN
T1BfdHJhY2tfZGlydHlfdnJhbSBpcyBub3QgaG9sZGluZyB0aGUgZG9tY3Rs
CmxvY2suCgpUaGlzIHdhcyBkZXRlY3RlZCBhcyBhIHJlc3VsdCBvZiB0aGUg
Zm9sbG93aW5nIGFzc2VydCB0cmlnZ2VyaW5nIHdoZW4KZG9pbmcgcmVwZWF0
ZWQgbWlncmF0aW9ucyBvZiBhIEhBUCBIVk0gZG9tYWluIHdpdGggYSBzdHVi
ZG9tOgoKQXNzZXJ0aW9uICdkLT5hcmNoLnBhZ2luZy5sb2dfZGlydHkuYWxs
b2NzID09IDAnIGZhaWxlZCBhdCBwYWdpbmcuYzoxOTgKLS0tLVsgWGVuLTQu
MTctdW5zdGFibGUgIHg4Nl82NCAgZGVidWc9eSAgTm90IHRhaW50ZWQgXS0t
LS0KQ1BVOiAgICAzNApSSVA6ICAgIGUwMDg6WzxmZmZmODJkMDQwMzE0YjNi
Pl0gYXJjaC94ODYvbW0vcGFnaW5nLmMjcGFnaW5nX2ZyZWVfbG9nX2RpcnR5
X2JpdG1hcCsweDYwNi8weDYKUkZMQUdTOiAwMDAwMDAwMDAwMDEwMjA2ICAg
Q09OVEVYVDogaHlwZXJ2aXNvciAoZDB2MjMpClsuLi5dClhlbiBjYWxsIHRy
YWNlOgogICBbPGZmZmY4MmQwNDAzMTRiM2I+XSBSIGFyY2gveDg2L21tL3Bh
Z2luZy5jI3BhZ2luZ19mcmVlX2xvZ19kaXJ0eV9iaXRtYXArMHg2MDYvMHg2
M2EKICAgWzxmZmZmODJkMDQwMjc5Zjk2Pl0gUyB4c20vZmxhc2svaG9va3Mu
YyNkb21haW5faGFzX3Blcm0rMHg1YS8weDY3CiAgIFs8ZmZmZjgyZDA0MDMx
NTc3Zj5dIEYgcGFnaW5nX2RvbWN0bCsweDI1MS8weGQ0MQogICBbPGZmZmY4
MmQwNDAzMTY0MGM+XSBGIHBhZ2luZ19kb21jdGxfY29udGludWF0aW9uKzB4
MTlkLzB4MjAyCiAgIFs8ZmZmZjgyZDA0MDMyMDJmYT5dIEYgcHZfaHlwZXJj
YWxsKzB4MTUwLzB4MmE3CiAgIFs8ZmZmZjgyZDA0MDNhNzI5ZD5dIEYgbHN0
YXJfZW50ZXIrMHgxMmQvMHgxNDAKClN1Y2ggYXNzZXJ0IHRyaWdnZXJlZCBi
ZWNhdXNlIHRoZSBzdHViZG9tIHVzZWQKWEVOX0RNT1BfdHJhY2tfZGlydHlf
dnJhbSB3aGlsZSBkb20wIHdhcyBpbiB0aGUgbWlkZGxlIG9mIGV4ZWN1dGlu
ZwpYRU5fRE9NQ1RMX1NIQURPV19PUF9PRkYsIGFuZCBzbyBsb2cgZGlydHkg
YmVjb21lIGVuYWJsZWQgd2hpbGUKcmV0aXJpbmcgdGhlIG9sZCBzdHJ1Y3R1
cmVzLCB0aHVzIGxlYWRpbmcgdG8gbmV3IGVudHJpZXMgYmVpbmcKcG9wdWxh
dGVkIGluIGFscmVhZHkgY2xlYXIgc2xvdHMuCgpGaXggdGhpcyBieSBub3Qg
ZW5hYmxpbmcgbG9nIGRpcnR5IGZvciBWUkFNIHRyYWNraW5nLCBzaW1pbGFy
IHRvIHdoYXQKaXMgZG9uZSB3aGVuIHVzaW5nIHNoYWRvdyBpbnN0ZWFkIG9m
IEhBUC4gQ2FsbApwMm1fZW5hYmxlX2hhcmR3YXJlX2xvZ19kaXJ0eSB3aGVu
IGVuYWJsaW5nIFZSQU0gdHJhY2tpbmcgaW4gb3JkZXIgdG8KZ2V0IHNvbWUg
aGFyZHdhcmUgYXNzaXN0YW5jZSBpZiBhdmFpbGFibGUuIEFzIGEgc2lkZSBl
ZmZlY3QgdGhlIG1lbW9yeQpwcmVzc3VyZSBvbiB0aGUgcDJtIHBvb2wgc2hv
dWxkIGdvIGRvd24gaWYgb25seSBWUkFNIHRyYWNraW5nIGlzCmVuYWJsZWQs
IGFzIHRoZSBkaXJ0eSBiaXRtYXAgaXMgbm8gbG9uZ2VyIGFsbG9jYXRlZC4K
Ck5vdGUgdGhhdCBwYWdpbmdfbG9nX2RpcnR5X3JhbmdlICh1c2VkIHRvIGdl
dCB0aGUgZGlydHkgYml0bWFwIGZvcgpWUkFNIHRyYWNraW5nKSBkb2Vzbid0
IHVzZSB0aGUgbG9nIGRpcnR5IGJpdG1hcCwgYW5kIGluc3RlYWQgcmVsaWVz
IG9uCmNoZWNraW5nIHdoZXRoZXIgZWFjaCBnZm4gb24gdGhlIHJhbmdlIGhh
cyBiZWVuIHN3aXRjaGVkIGZyb20KcDJtX3JhbV9sb2dkaXJ0eSB0byBwMm1f
cmFtX3J3IGluIG9yZGVyIHRvIGFjY291bnQgZm9yIGRpcnR5IHBhZ2VzLgoK
VGhpcyBpcyBDVkUtMjAyMi0yNjM1NiAvIFhTQS0zOTcuCgpTaWduZWQtb2Zm
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
UmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4K
Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcGFnaW5nLmgKKysrIGIveGVu
L2luY2x1ZGUvYXNtLXg4Ni9wYWdpbmcuaApAQCAtMTYyLDkgKzE2Miw2IEBA
IHZvaWQgcGFnaW5nX2xvZ19kaXJ0eV9yYW5nZShzdHJ1Y3QgZG9tYWkKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIG5yLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgKmRpcnR5X2Jp
dG1hcCk7CiAKLS8qIGVuYWJsZSBsb2cgZGlydHkgKi8KLWludCBwYWdpbmdf
bG9nX2RpcnR5X2VuYWJsZShzdHJ1Y3QgZG9tYWluICpkLCBib29sIGxvZ19n
bG9iYWwpOwotCiAvKiBsb2cgZGlydHkgaW5pdGlhbGl6YXRpb24gKi8KIHZv
aWQgcGFnaW5nX2xvZ19kaXJ0eV9pbml0KHN0cnVjdCBkb21haW4gKmQsIGNv
bnN0IHN0cnVjdCBsb2dfZGlydHlfb3BzICpvcHMpOwogCi0tLSBhL3hlbi9h
cmNoL3g4Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21tL2hh
cC9oYXAuYwpAQCAtNjksMTMgKzY5LDYgQEAgaW50IGhhcF90cmFja19kaXJ0
eV92cmFtKHN0cnVjdCBkb21haW4gKgogICAgIHsKICAgICAgICAgdW5zaWdu
ZWQgaW50IHNpemUgPSBESVZfUk9VTkRfVVAobnJfZnJhbWVzLCBCSVRTX1BF
Ul9CWVRFKTsKIAotICAgICAgICBpZiAoICFwYWdpbmdfbW9kZV9sb2dfZGly
dHkoZCkgKQotICAgICAgICB7Ci0gICAgICAgICAgICByYyA9IHBhZ2luZ19s
b2dfZGlydHlfZW5hYmxlKGQsIGZhbHNlKTsKLSAgICAgICAgICAgIGlmICgg
cmMgKQotICAgICAgICAgICAgICAgIGdvdG8gb3V0OwotICAgICAgICB9Ci0K
ICAgICAgICAgcmMgPSAtRU5PTUVNOwogICAgICAgICBkaXJ0eV9iaXRtYXAg
PSB2emFsbG9jKHNpemUpOwogICAgICAgICBpZiAoICFkaXJ0eV9iaXRtYXAg
KQpAQCAtMTA3LDYgKzEwMCwxMCBAQCBpbnQgaGFwX3RyYWNrX2RpcnR5X3Zy
YW0oc3RydWN0IGRvbWFpbiAqCiAKICAgICAgICAgICAgIHBhZ2luZ191bmxv
Y2soZCk7CiAKKyAgICAgICAgICAgIGRvbWFpbl9wYXVzZShkKTsKKyAgICAg
ICAgICAgIHAybV9lbmFibGVfaGFyZHdhcmVfbG9nX2RpcnR5KGQpOworICAg
ICAgICAgICAgZG9tYWluX3VucGF1c2UoZCk7CisKICAgICAgICAgICAgIGlm
ICggb2VuZCA+IG9zdGFydCApCiAgICAgICAgICAgICAgICAgcDJtX2NoYW5n
ZV90eXBlX3JhbmdlKGQsIG9zdGFydCwgb2VuZCwKICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgcDJtX3JhbV9sb2dkaXJ0eSwgcDJt
X3JhbV9ydyk7Ci0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wYWdpbmcuYworKysg
Yi94ZW4vYXJjaC94ODYvbW0vcGFnaW5nLmMKQEAgLTIxMSw3ICsyMTEsNyBA
QCBzdGF0aWMgaW50IHBhZ2luZ19mcmVlX2xvZ19kaXJ0eV9iaXRtYXAoCiAg
ICAgcmV0dXJuIHJjOwogfQogCi1pbnQgcGFnaW5nX2xvZ19kaXJ0eV9lbmFi
bGUoc3RydWN0IGRvbWFpbiAqZCwgYm9vbCBsb2dfZ2xvYmFsKQorc3RhdGlj
IGludCBwYWdpbmdfbG9nX2RpcnR5X2VuYWJsZShzdHJ1Y3QgZG9tYWluICpk
LCBib29sIGxvZ19nbG9iYWwpCiB7CiAgICAgaW50IHJldDsKIAo=

--=separator--


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 12:07:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 12:07:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298844.509177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhxg-0003op-8x; Tue, 05 Apr 2022 12:07:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298844.509177; Tue, 05 Apr 2022 12:07:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbhxg-0003oi-5g; Tue, 05 Apr 2022 12:07:04 +0000
Received: by outflank-mailman (input) for mailman id 298844;
 Tue, 05 Apr 2022 12:07:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FxJD=UP=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nbhxe-0003oB-UI
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 12:07:03 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e56b0d9d-b4d8-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 14:07:01 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1649160416307201.74447491950446;
 Tue, 5 Apr 2022 05:06:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e56b0d9d-b4d8-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1649160417; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=c7Tlm1BibFHCgIIZ25boczd7nxwBD/71/ibtsOyBzZo9kr79K7Wgaq5HWWsyxOLpMNyOwmRy7aE27B5F6eQGbyt8SBRpVDgtbFkCk58TyKSrpHTtQeTUrWnzb6E+0X7NjxrZGUHAs8AXFEUxENA/O5/xlV8kLO38mRNtHsyLn18=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1649160417; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=W9uEMEEVdi9Ua83j3iyEoXl2G+KS1XiR5VYiEdS/0cA=; 
	b=O/hI+PxxLIYdP8mrE+C+z8EoT4oVm2+2nZJkvpBB8oA6Bes4rFOBPimTP0nf1hLMnha1aymAuZz9sm7JBBoKWbEuApi9Z80WwpuE7fkmdHi3Ogg0vWpUb3V8+97yHpcXNTEvPD2rDPkZl2taTCDSJPFpufWzI6kZDWWLhk/MtDY=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649160417;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=W9uEMEEVdi9Ua83j3iyEoXl2G+KS1XiR5VYiEdS/0cA=;
	b=oFvqLPiW/4C11McAGs9zuj9v0laHYfvDfVElYdEXI4iC8OD3D/9tU13M9tlhvBL2
	RFzziBIQOUZb6pxU1o0FFPYSck+epuos7JK89avrXluULI8M9ITjnqCqeKMPSRVl06m
	ieLW6kBypL6W9mIA/Rmm4/6lniYm6pvHNaZ3tGm0=
Message-ID: <959fce1f-31c4-3de8-c3f2-45c307502473@apertussolutions.com>
Date: Tue, 5 Apr 2022 08:06:31 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, scott.davis@starlab.io,
 jandryuk@gmail.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
 <25c10763-36fa-34d4-05b6-655c08fdfee7@apertussolutions.com>
 <YksK9hIbJbOXkIYd@Air-de-Roger>
 <cd178295-4c8b-6710-3050-011fcee378b1@apertussolutions.com>
 <Ykvy4lWiwASHGXcF@Air-de-Roger>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
In-Reply-To: <Ykvy4lWiwASHGXcF@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 4/5/22 03:42, Roger Pau Monné wrote:
> On Mon, Apr 04, 2022 at 12:08:25PM -0400, Daniel P. Smith wrote:
>> On 4/4/22 11:12, Roger Pau Monné wrote:
>>> On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote:
>>>> On 3/31/22 08:36, Roger Pau Monné wrote:
>>>>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
>>>>>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>>>>>> index e22d6160b5..157e57151e 100644
>>>>>> --- a/xen/include/xsm/xsm.h
>>>>>> +++ b/xen/include/xsm/xsm.h
>>>>>> @@ -189,6 +189,28 @@ struct xsm_operations {
>>>>>>  #endif
>>>>>>  };
>>>>>>  
>>>>>> +static always_inline int xsm_elevate_priv(struct domain *d)
>>>>>
>>>>> I don't think it needs to be always_inline, using just inline would be
>>>>> fine IMO.
>>>>>
>>>>> Also this needs to be __init.
>>>>
>>>> AIUI always_inline is likely the best way to preserve the speculation
>>>> safety brought in by the call to is_system_domain().
>>>
>>> There's nothing related to speculation safety in is_system_domain()
>>> AFAICT. It's just a plain check against d->domain_id. It's my
>>> understanding there's no need for any speculation barrier there
>>> because d->domain_id is not an external input.
>>
>> Hmmm, this actually raises a good question. Why is is_control_domain(),
>> is_hardware_domain, and others all have evaluate_nospec() wrapping the
>> check of a struct domain element while is_system_domain() does not?
> 
> Jan replied to this regard, see:
> 
> https://lore.kernel.org/xen-devel/54272d08-7ce1-b162-c8e9-1955b780ca11@suse.com/

Jan can correct me if I misunderstood, but his point is with respect to
where the inline function will be expanded into and I would think you
would want to ensure that if anyone were to use is_system_domain(), then
the inline expansion of this new location could create a potential
speculation-able branch. Basically my concern is not putting the guards
in place today just because there is not currently any location where
is_system_domain() is expanded to create a speculation opportunity does
not mean there is not an opening for the opportunity down the road for a
future unprotected use.

>>> In any case this function should be __init only, at which point there
>>> are no untrusted inputs to Xen.
>>
>> I thought it was agreed that __init on inline functions in headers had
>> no meaning?
> 
> In a different reply I already noted my preference would be for the
> function to not reside in a header and not be inline, simply because
> it would be gone after initialization and we won't have to worry about
> any stray calls when the system is active.

If an inline function is only used by __init code, how would be
available for stray calls when the system is active? I would concede
that it is possible for someone to explicitly use in not __init code but
I would like to believe any usage in a submitted code change would be
questioned by the reviewers.

With that said, if we consider Jason's suggestion would this remove your
concern since that would only introduce a de-privilege function and
there would be no piv escalation that could be erroneously called at
anytime?

v/r
dps


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 12:12:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 12:12:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298878.509187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbi2Z-0005I8-32; Tue, 05 Apr 2022 12:12:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298878.509187; Tue, 05 Apr 2022 12:12:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbi2Y-0005I1-WD; Tue, 05 Apr 2022 12:12:07 +0000
Received: by outflank-mailman (input) for mailman id 298878;
 Tue, 05 Apr 2022 12:12:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbi2X-0005Hp-IM; Tue, 05 Apr 2022 12:12:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbi2X-0008QB-Fh; Tue, 05 Apr 2022 12:12:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbi2X-0005kl-0v; Tue, 05 Apr 2022 12:12:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbi2X-0005qw-0P; Tue, 05 Apr 2022 12:12:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yfqcss5l4MLmHiJbF22DX1772iO4+QPa9dThBC58oMU=; b=hfv+tQf6ilcpfIEVcIvh2zBosW
	wkrrweaAj/z6dTWP0d38Dk2/2duUHtYhAxGnJjiYIbK+0MAwujZX5cAOMj+7aMmr8/jxkvd11CB38
	py6fpk0+c2JHSltzNo5SesbMQvDoPbsxnYiirTf3R7mRmv02a2u6a56el4lh58v+rqMo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169173-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169173: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=a298a84478053872ed9da660a75f182ce81b8ddc
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 12:12:05 +0000

flight 169173 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169173/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 a298a84478053872ed9da660a75f182ce81b8ddc
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   36 days
Failing since        168258  2022-03-01 01:55:31 Z   35 days  279 attempts
Testing same since   169173  2022-04-05 05:13:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4610 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 12:16:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 12:16:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298890.509202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbi7A-00068g-Oj; Tue, 05 Apr 2022 12:16:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298890.509202; Tue, 05 Apr 2022 12:16:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbi7A-00068Z-Ih; Tue, 05 Apr 2022 12:16:52 +0000
Received: by outflank-mailman (input) for mailman id 298890;
 Tue, 05 Apr 2022 12:12:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c4fh=UP=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1nbhuU-0006xb-Fc
 for xen-devel@lists.xen.org; Tue, 05 Apr 2022 12:03:46 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ec7e771-b4d8-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 14:03:41 +0200 (CEST)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1nbhu2-0008EH-C2; Tue, 05 Apr 2022 12:03:18 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1nbhu2-0005jJ-9A; Tue, 05 Apr 2022 12:03:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ec7e771-b4d8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=iUnWHaeaBZp6aTAy0V9EIUSiF4hl+ZXBR73MEyRTvSg=; b=HKSbbTsW9QpqRBC2guAk8uPhqK
	2Znrqb55SQawBvu7QyW9e+B4aRTW6mMN3mVqTrfsxn33b1xf29cenUGb/0fzc5fz4MTvHOQvYClFc
	6JaAe5KRjtLRpfY7+olhEfNxiMNjPRXNCbLenzSrBTD//77iwsw6ylK7rfMriRbUfC6g=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 400 v2 (CVE-2022-26358,CVE-2022-26359,CVE-2022-26360,CVE-2022-26361)
 - IOMMU: RMRR (VT-d) and unity map (AMD-Vi) handling issues
Message-Id: <E1nbhu2-0005jJ-9A@xenbits.xenproject.org>
Date: Tue, 05 Apr 2022 12:03:18 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

 Xen Security Advisory CVE-2022-26358,CVE-2022-26359,CVE-2022-26360,CVE-2022-26361 / XSA-400
                                          version 2

       IOMMU: RMRR (VT-d) and unity map (AMD-Vi) handling issues

UPDATES IN VERSION 2
====================

Public release.

ISSUE DESCRIPTION
=================

Certain PCI devices in a system might be assigned Reserved Memory
Regions (specified via Reserved Memory Region Reporting, "RMRR") for
Intel VT-d or Unity Mapping ranges for AMD-Vi.  These are typically used
for platform tasks such as legacy USB emulation.

Since the precise purpose of these regions is unknown, once a device
associated with such a region is active, the mappings of these regions
need to remain continuouly accessible by the device.  This requirement
has been violated.

Subsequent DMA or interrupts from the device may have unpredictable
behaviour, ranging from IOMMU faults to memory corruption.

IMPACT
======

The precise impact is system specific, but would likely be a Denial of
Service (DoS) affecting the entire host.  Privilege escalation and
information leaks cannot be ruled out.

VULNERABLE SYSTEMS
==================

All Xen versions supporting PCI passthrough are affected.

Only x86 systems with IOMMU hardware are vulnerable.  Arm systems
as well as x86 systems without IOMMU hardware or without any IOMMUs in
use are not vulnerable.

Only x86 guests which have physical devices passed through to them,
and only when any such device has an associated RMRR or unity map, can
leverage the vulnerability. (Whether a device is associated with an RMRR
or unity map is not easy to discern.)

MITIGATION
==========

Not passing through physical devices to untrusted guests when the
devices have assoicated RMRRs / unity maps will avoid the vulnerability.

CREDITS
=======

Aspects of this issue were discovered by Jan Beulich of SUSE and
Roger Pau Monné of Citrix.

RESOLUTION
==========

Applying the appropriate set of attached patches resolves this issue.

Note that patches for released versions are generally prepared to
apply to the stable branches, and may not apply cleanly to the most
recent release tarball.  Downstreams are encouraged to update to the
tip of the stable branch before applying these patches.

xsa400/xsa400-??.patch          xen-unstable
xsa400/xsa400-4.16-*.patch      Xen 4.16.x
xsa400/xsa400-4.15-*.patch      Xen 4.15.x
xsa400/xsa400-4.14-*.patch      Xen 4.14.x
xsa400/xsa400-4.13-*.patch      Xen 4.13.x
xsa400/xsa400-4.12-*.patch      Xen 4.12.x

$ sha256sum xsa400*/*
108544235a011e96e8717e9e744190fd8128e99cca8141f682667bd7b8533f45  xsa400/xsa400-01.patch
1648ef0213dd6beeaa782a18926416a00aa51ad89136aa1565debd5312bf58aa  xsa400/xsa400-02.patch
39e02738ce3d3a65c02355dd45cb844ecca8be9715b7887dedcdaada02c4bda1  xsa400/xsa400-03.patch
2d5e7f4090418d817df002b7cd7a9a40246ff9900faf53fc2b2f685ac77b2a0e  xsa400/xsa400-4.12-00.patch
a4291033d1960f8095a11e765072f60cf9e5be07d4cd0cbfed1896f9c66a4576  xsa400/xsa400-4.12-01.patch
2f5b2ce22ae6cba8a5380ccf63ae2dcf6e7ce8f29a33c87c0630abc6c1d24793  xsa400/xsa400-4.12-02.patch
86ee30d46957f63e4516ea47f14470579d0906fd536b39e31645e2cd471c1b49  xsa400/xsa400-4.12-03.patch
546430f61df3eb92a55e32047cce8557d85a8e860f67d558c35fea44e7c56b18  xsa400/xsa400-4.12-04.patch
178463bf81b138668c2f036b11a0b9406a6f5bb98c0643741787ccdf276495d9  xsa400/xsa400-4.12-05.patch
b19c599eb5eb17f8e0e17879174a4235fdc3f2172bc77bffdee60074ef2d7c90  xsa400/xsa400-4.12-06.patch
02eae481f2b06763dd913b46a65837791147b7916bbd0ed50e5d972784b310aa  xsa400/xsa400-4.12-07.patch
298339cc343d9803158abd0c36030f36e7dc8360ccfed320f34ff01813c47434  xsa400/xsa400-4.12-08.patch
9253d7120db39a1e3c14fc6b8735577f3d215837996eed057511146c0ba199d6  xsa400/xsa400-4.12-09.patch
762bbe418c028449812b4441c4e369230477eeea4d863c05a2efd9c7e5e19bc3  xsa400/xsa400-4.12-10.patch
7172957a27cdf02327c28b5cfedf35b12e76cb17237cbb9c318442961f503fe6  xsa400/xsa400-4.12-11.patch
c685d9ee2453728f509a78506930f756118ff443fbe6d5307873e90455b5e131  xsa400/xsa400-4.13-00.patch
0b0a80a249c9c58726f913df24163976cfaadabc685d3d274dd7b972fe4cbffc  xsa400/xsa400-4.13-01.patch
eabee7d9cabe00748e78fda0363818ca6085ac395804658a11f94394236d2734  xsa400/xsa400-4.13-02.patch
66cd2a0ee8a002668e04e2bb7192ac2f774012434765988bdea0a7e79621f58c  xsa400/xsa400-4.13-03.patch
4457c142c1fdc67e0dc77a57bc57159ee63dc1946e432ae1225937c7ed3a3e82  xsa400/xsa400-4.13-04.patch
2feabcbcf160d8c1130b2c86efd98dd9fee0332489520f3a10aa8bb37d6a5a20  xsa400/xsa400-4.13-05.patch
903099123d37806b7fe684d75ab0fb6a28b4609d7370cce65a9ba5ab4db43ddd  xsa400/xsa400-4.13-06.patch
e8a39d36f629b7f79634d09d22ace97f1c23ee10ee9fef6afd68ec2204c55d81  xsa400/xsa400-4.13-07.patch
d85c63917542d2d2b47dd6322b4c32364719be4707acf616290aacd536c57805  xsa400/xsa400-4.13-08.patch
5496ca04a2789603069ca8e8d3bf6d301c19c799ccff813bf17865b46f687757  xsa400/xsa400-4.13-09.patch
8b343f3616c0283caac334b4f0cc42b1523f2dc9de3463f2edadbf1a11c17a22  xsa400/xsa400-4.13-10.patch
577d20d2ed5da8a89f32eae717a140f9ec3900e31fc9e10ee23e37ae5dc19d4a  xsa400/xsa400-4.13-11.patch
bfa82c6beae9ec8ab88e042296442eed3ca162b42124c982785c7c0d95440480  xsa400/xsa400-4.14-01.patch
f8f7da8d0cc3d149874956e9aefe666a2e33275dba66ed0d55f0b559d078f01f  xsa400/xsa400-4.14-02.patch
49acd3d795aa091f8fa1c72b5064b5a71966e77c9785f5d0f8226d99daba3ead  xsa400/xsa400-4.14-03.patch
0ce4435a8c7fd6f4186ea31d29932094b1a902d9d0c5dafa3fcb1c15c5eca88c  xsa400/xsa400-4.14-04.patch
aeae4cef4bf31ecd854ad820239fe793f36ed81c0ad28ce3935ab3f83c3ee58c  xsa400/xsa400-4.14-05.patch
f8d93e2ab3f891f70abd17ddba9aae8237605f1f680754ff9df646e5ddb9d419  xsa400/xsa400-4.14-06.patch
afb9f731ba7a53930626e322ebb39db19f817b5c60710fc934c395fcdea4c7f4  xsa400/xsa400-4.14-07.patch
c236bb7b5c692cf30e7b84e6668f87b248bcf80c6df1dd74c655b91b955eb271  xsa400/xsa400-4.14-08.patch
6c4d44983eae92212be6bda7663198260bdeb0506c5b622c38ddbcedf9360d69  xsa400/xsa400-4.14-09.patch
5393c6681c675c666396f6725c2ac2e48293465e97bc228dcfc410ee84d8ba7c  xsa400/xsa400-4.14-10.patch
8d1dcdeb4d9420840a6753bb56f35bf199af63a6c477f2352e47222df5337c1a  xsa400/xsa400-4.14-11.patch
f52a70fd92c4819658630c9d478ae03a9801352b024240059877d0ee2002e31e  xsa400/xsa400-4.15-01.patch
243a0b20b20c78b41f833004c82ce26b1249285671f150bdfe4a2314860df316  xsa400/xsa400-4.15-02.patch
175f2472f80dacffcee578543f4fc4521f5533de46199ce86b072bfd0ede9ae3  xsa400/xsa400-4.15-03.patch
dee6fbe9e3c03d695bae1f81cebca80ca54ecf02a51db64ae5f3d313837eed8c  xsa400/xsa400-4.15-04.patch
55a35033b8ba45b1c9c556e0c2866733e518137299f2f3f4d41046766898aeb5  xsa400/xsa400-4.15-05.patch
94ec5289a3a632fed8d220478847ef3b780d7db345f30ee9d6b186905de61048  xsa400/xsa400-4.15-06.patch
50cbb08b931cd1cc8ec3e2aa17b537db80dcd03a6de0994331fc3818f53cbfe4  xsa400/xsa400-4.15-07.patch
e4c77fac42b8b0b50cdc9de30f406176c44de75d647e36b4bbd6360dd70c8aa6  xsa400/xsa400-4.15-08.patch
652cd8700b830b3520db325cfd90eab6c08bd423debb21c05caa7edfef9ee671  xsa400/xsa400-4.15-09.patch
50e58d663690475ce35a0a65eda88a2c2da319ddc02eb15b5a7d568a8f0a0366  xsa400/xsa400-4.15-10.patch
37a18da6ad1f529bfdc4156225f18c17c10a45302b7d6045ee38c934656589da  xsa400/xsa400-4.15-11.patch
ff069d123df2aba7a4f3185f21f7ca36b34fc026dcdd279224c86698f84c0975  xsa400/xsa400-4.15-12.patch
76497919563cdf2804f5071325c032acd04cf8df75c0dcb4b207a93b9ae80927  xsa400/xsa400-4.16-01.patch
150f2a7621ec17d6369a6ebbc2c08c502f3524acb89855a86a25d7b4fa3e3270  xsa400/xsa400-4.16-02.patch
cd59bca0fcab4bda1d0ea839501543a59b53aef61e96a0d949675bc5550a6fcb  xsa400/xsa400-4.16-03.patch
098edab3ed8915a3598badaa1d452f7c8ab2d8e72879dd9bf941b2093e6df9d1  xsa400/xsa400-4.16-04.patch
a85640291e1bc1cdb757172eb6d2036834ad2eb7b84252cc64d29db3feeff331  xsa400/xsa400-4.16-05.patch
99d43caf1ce60f421d940c2774e2a59d65d1f0dcccd941f13066117a19222b22  xsa400/xsa400-4.16-06.patch
fbe5ec58da594dffd3e63c18406280f27d976609350d7c7083acbf2f2e6538cd  xsa400/xsa400-4.16-07.patch
e6b0d400beda8ff0e9bdbfd033bc23935069b41dbd5dddf863dbd70de44d908f  xsa400/xsa400-4.16-08.patch
965f96bdb33a872942de42597c7cc32012020f37b25a84015ecc55387d6b07dd  xsa400/xsa400-4.16-09.patch
7996b1462374168ddc9cbc01c990d5cb40140d7a100096f284f6b74fb4ad7ec4  xsa400/xsa400-4.16-10.patch
23e325be799b299e9621e76eeff646b81518a4124474fb766d3bf6f0cc925083  xsa400/xsa400-4.16-11.patch
6fa43e1a8f53184724cd4a7b5c13f0fd699c998af968bafaefda570432b5a7d8  xsa400/xsa400-4.16-12.patch
82306d680ef445bee04969028184f65b5e106c89c308fbb876b858f77fea9506  xsa400/xsa400-04.patch
ccf3ff62b427d3d2ea46d4da96beeef2cb64674bc0d247352233c4b84a21f205  xsa400/xsa400-05.patch
8b3f767ca659e8bbf4983927999bdb92d9fa42e3a88973e22facda0e23f29a84  xsa400/xsa400-06.patch
bb570b89a2d4b535831d9211bf08cc0c62c060dc7808911afd8186082b884cf8  xsa400/xsa400-07.patch
8382fd5336b5b4b3388dee099da00b1e728dea77d96825c6088991d7e50f333b  xsa400/xsa400-08.patch
6909363863932ca77c9b7384516965bc1697fab9b4814294a1675fb6ce8e166e  xsa400/xsa400-09.patch
c37fee4dd9ab2bf64ebb8b9c553f793bfcef9a7cf1972b0000fe6ce28b9e8e60  xsa400/xsa400-10.patch
70f11f64457c9703f09c3121d08d5ff4676af20bd42eb1262c433a5e0f79ea41  xsa400/xsa400-11.patch
724e34d262939162ecab713c070cc07b8f7baeca50ee8b62bb59460ec4f7fbdb  xsa400/xsa400-12.patch
$

DEPLOYMENT DURING EMBARGO
=========================

Deployment of the patches described above (or others which are
substantially similar) is permitted during the embargo, even on
public-facing systems with untrusted guest users and administrators.

HOWEVER, deployment of the mitigation is NOT permitted (except where
all the affected systems and VMs are administered and used only by
organisations which are members of the Xen Project Security Issues
Predisclosure List).  Specifically, deployment on public cloud systems
is NOT permitted.

This is because removal of pass-through devices or their replacement by
emulated devices is a guest visible configuration change, which may lead
to re-discovery of the issue.

Deployment of this mitigation is permitted only AFTER the embargo ends.

AND: Distribution of updated software is prohibited (except to other
members of the predisclosure list).

(Note: this during-embargo deployment notice is retained in
post-embargo publicly released Xen Project advisories, even though it
is then no longer applicable.  This is to enable the community to have
oversight of the Xen Project Security Team's decisionmaking.)

For more information about permissible uses of embargoed information,
consult the Xen Project community's agreed Security Policy:
  http://www.xenproject.org/security-policy.html
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmJML+0MHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZQl8IALuh2RTTSiQBYeybKZPr3QEOfy+L3VFzNbRZeGBc
jpN12lXjzkFvVuTXDu6Cgw1g6yhRrcRnhGWhx3T8RpGeYhHq1GeKSw7+c4NTsiDL
21P9F3mEban6tOUa82V2PTkYfAMMpbn5apOcsMvdlPoEgXdgLPh5HoVIvXQQO6Ni
3MkCN7foV3M07jAiB4ehqrsPLhzGSCCRJfiD9PA1/RnnzCBrspyyWepF7mwzh2cx
1kENmG8mSwA3Eg0fNUMDBi6W+drNmIx4gooYo3LBnCyMgzUrv7+bzkvjpcU8+dAq
H5i2Morbx4j0F/TcQ8+23KjzNvJHbiqKVrIFCoa1z54dGC8=
=tz+l
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-01.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-01.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggKGRlKWFzc2lnbiBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSB1cGRhdGVkLgoKQWxzbyBhZGp1c3QgYSByZWxhdGVk
IGxvZyBtZXNzYWdlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM1OCAvIHBhcnQg
b2YgWFNBLTQwMC4KCkZpeGVzOiA4Yjk5ZjQ0MDBiNjkgKCJWVC1kOiBmaXgg
Uk1SUiByZWxhdGVkIGVycm9yIGhhbmRsaW5nIikKU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog
Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+ClJldmll
d2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KUmV2aWV3ZWQt
Ynk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgotLS0KdjI6
IERvbid0IHVubWFwIFJNUlJzIGZvciBEb20wLgoKLS0tIGEveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAgLTI0MTQsNiArMjQxNCwxMCBA
QCBzdGF0aWMgaW50IGNmX2NoZWNrIHJlYXNzaWduX2RldmljZV9vd25lCiB7
CiAgICAgaW50IHJldDsKIAorICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3Vu
bWFwKHNvdXJjZSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0ICkKKyAg
ICAgICAgcmV0dXJuIHJldDsKKwogICAgIC8qCiAgICAgICogSWYgdGhlIGRl
dmljZSBiZWxvbmdzIHRvIHRoZSBoYXJkd2FyZSBkb21haW4sIGFuZCBpdCBo
YXMgUk1SUiwgZG9uJ3QKICAgICAgKiByZW1vdmUgaXQgZnJvbSB0aGUgaGFy
ZHdhcmUgZG9tYWluLCBiZWNhdXNlIEJJT1MgbWF5IHVzZSBSTVJSIGF0CkBA
IC0yNDQyLDEwICsyNDQ2LDYgQEAgc3RhdGljIGludCBjZl9jaGVjayByZWFz
c2lnbl9kZXZpY2Vfb3duZQogICAgICAgICAgICAgfQogICAgIH0KIAotICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHNvdXJjZSwgZGV2Zm4sIHBk
ZXYpOwotICAgIGlmICggcmV0ICkKLSAgICAgICAgcmV0dXJuIHJldDsKLQog
ICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWlu
ICE9IGRvbV9pbyApCiAgICAgewogICAgICAgICBsaXN0X21vdmUoJnBkZXYt
PmRvbWFpbl9saXN0LCAmZG9tX2lvLT5wZGV2X2xpc3QpOwpAQCAtMjUzMCw5
ICsyNTMwLDggQEAgc3RhdGljIGludCBjZl9jaGVjayBpbnRlbF9pb21tdV9h
c3NpZ25fZAogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0ID0gcmVhc3Np
Z25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7Ci0gICAg
aWYgKCByZXQgfHwgZCA9PSBkb21faW8gKQotICAgICAgICByZXR1cm4gcmV0
OworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm4gcmVh
c3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7CiAK
ICAgICAvKiBTZXR1cCBybXJyIGlkZW50aXR5IG1hcHBpbmcgKi8KICAgICBm
b3JfZWFjaF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBpICkKQEAgLTI1NDUs
MjAgKzI1NDQsMzcgQEAgc3RhdGljIGludCBjZl9jaGVjayBpbnRlbF9pb21t
dV9hc3NpZ25fZAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgZmxhZyk7CiAgICAgICAgICAg
ICBpZiAoIHJldCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAg
aW50IHJjOwotCi0gICAgICAgICAgICAgICAgcmMgPSByZWFzc2lnbl9kZXZp
Y2Vfb3duZXJzaGlwKGQsIHMsIGRldmZuLCBwZGV2KTsKICAgICAgICAgICAg
ICAgICBwcmludGsoWEVOTE9HX0dfRVJSIFZURFBSRUZJWAotICAgICAgICAg
ICAgICAgICAgICAgICAiIGNhbm5vdCBtYXAgcmVzZXJ2ZWQgcmVnaW9uICgl
IlBSSXg2NCIsJSJQUkl4NjQiXSBmb3IgRG9tJWQgKCVkKVxuIiwKLSAgICAg
ICAgICAgICAgICAgICAgICAgcm1yci0+YmFzZV9hZGRyZXNzLCBybXJyLT5l
bmRfYWRkcmVzcywKLSAgICAgICAgICAgICAgICAgICAgICAgZC0+ZG9tYWlu
X2lkLCByZXQpOwotICAgICAgICAgICAgICAgIGlmICggcmMgKQotICAgICAg
ICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlIgVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAi
IGZhaWxlZCB0byByZWNsYWltICVwcCBmcm9tICVwZCAoJWQpXG4iLAotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGMyhzZWcsIGJ1cywg
ZGV2Zm4pLCBkLCByYyk7Ci0gICAgICAgICAgICAgICAgICAgIGRvbWFpbl9j
cmFzaChkKTsKLSAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAg
ICAgICAgICIlcGQ6IGNhbm5vdCBtYXAgcmVzZXJ2ZWQgcmVnaW9uIFslIlBS
SXg2NCIsJSJQUkl4NjQiXTogJWRcbiIsCisgICAgICAgICAgICAgICAgICAg
ICAgIGQsIHJtcnItPmJhc2VfYWRkcmVzcywgcm1yci0+ZW5kX2FkZHJlc3Ms
IHJldCk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9
CisgICAgICAgIH0KKyAgICB9CisKKyAgICBpZiAoICFyZXQgKQorICAgICAg
ICByZXQgPSByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlwKHMsIGQsIGRldmZu
LCBwZGV2KTsKKworICAgIC8qIFNlZSByZWFzc2lnbl9kZXZpY2Vfb3duZXJz
aGlwKCkgZm9yIHRoZSBod2RvbSBhc3BlY3QuICovCisgICAgaWYgKCAhcmV0
IHx8IGlzX2hhcmR3YXJlX2RvbWFpbihkKSApCisgICAgICAgIHJldHVybiBy
ZXQ7CisKKyAgICBmb3JfZWFjaF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBp
ICkKKyAgICB7CisgICAgICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBzZWcg
JiYKKyAgICAgICAgICAgICBQQ0lfQlVTKGJkZikgPT0gYnVzICYmCisgICAg
ICAgICAgICAgUENJX0RFVkZOMihiZGYpID09IGRldmZuICkKKyAgICAgICAg
eworICAgICAgICAgICAgaW50IHJjID0gaW9tbXVfaWRlbnRpdHlfbWFwcGlu
ZyhkLCBwMm1fYWNjZXNzX3gsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHJtcnItPmJhc2VfYWRkcmVzcywKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+
ZW5kX2FkZHJlc3MsIDApOworCisgICAgICAgICAgICBpZiAoIHJjICYmIHJj
ICE9IC1FTk9FTlQgKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg
IHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWAorICAgICAgICAgICAgICAg
ICAgICAgICAiJXBkOiBjYW5ub3QgdW5tYXAgcmVzZXJ2ZWQgcmVnaW9uIFsl
IlBSSXg2NCIsJSJQUkl4NjQiXTogJWRcbiIsCisgICAgICAgICAgICAgICAg
ICAgICAgIGQsIHJtcnItPmJhc2VfYWRkcmVzcywgcm1yci0+ZW5kX2FkZHJl
c3MsIHJjKTsKKyAgICAgICAgICAgICAgICBkb21haW5fY3Jhc2goZCk7CiAg
ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAg
IH0K

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-02.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-02.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggYWRkL3JlbW92ZSBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSBjbGVhcmVkLgoKQWxzbyBzd2l0Y2ggdG8gJXBkIGlu
IHJlbGF0ZWQgbG9nIG1lc3NhZ2VzLgoKRml4ZXM6IGZhODhjZmFkZjkxOCAo
InZ0LWQ6IE1hcCBSTVJSIGluIGludGVsX2lvbW11X2FkZF9kZXZpY2UoKSBp
ZiB0aGUgZGV2aWNlIGhhcyBSTVJSIikKRml4ZXM6IDhiOTlmNDQwMGI2OSAo
IlZULWQ6IGZpeCBSTVJSIHJlbGF0ZWQgZXJyb3IgaGFuZGxpbmciKQpTaWdu
ZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJl
dmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4
LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50
ZWwuY29tPgotLS0Kdjc6IFJlLWJhc2UuCnYyOiBOZXcuCgotLS0gYS94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYworKysgYi94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwpAQCAtMTk5MiwxNCArMTk5
Miw2IEBAIHN0YXRpYyBpbnQgY2ZfY2hlY2sgaW50ZWxfaW9tbXVfYWRkX2Rl
dmkKICAgICBpZiAoICFwZGV2LT5kb21haW4gKQogICAgICAgICByZXR1cm4g
LUVJTlZBTDsKIAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmco
cGRldi0+ZG9tYWluLCBkZXZmbiwgcGRldik7Ci0gICAgaWYgKCByZXQgKQot
ICAgIHsKLSAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWCwg
ImQlZDogY29udGV4dCBtYXBwaW5nIGZhaWxlZFxuIiwKLSAgICAgICAgICAg
ICAgICBwZGV2LT5kb21haW4tPmRvbWFpbl9pZCk7Ci0gICAgICAgIHJldHVy
biByZXQ7Ci0gICAgfQotCiAgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2UgKCBy
bXJyLCBiZGYsIGkgKQogICAgIHsKICAgICAgICAgaWYgKCBybXJyLT5zZWdt
ZW50ID09IHBkZXYtPnNlZyAmJgpAQCAtMjAxNiwxMiArMjAwOCwxNyBAQCBz
dGF0aWMgaW50IGNmX2NoZWNrIGludGVsX2lvbW11X2FkZF9kZXZpCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmJh
c2VfYWRkcmVzcywgcm1yci0+ZW5kX2FkZHJlc3MsCiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDApOwogICAgICAgICAgICAg
aWYgKCByZXQgKQotICAgICAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VS
UiBWVERQUkVGSVgsICJkJWQ6IFJNUlIgbWFwcGluZyBmYWlsZWRcbiIsCi0g
ICAgICAgICAgICAgICAgICAgICAgICBwZGV2LT5kb21haW4tPmRvbWFpbl9p
ZCk7CisgICAgICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSIFZURFBS
RUZJWCwgIiVwZDogUk1SUiBtYXBwaW5nIGZhaWxlZFxuIiwKKyAgICAgICAg
ICAgICAgICAgICAgICAgIHBkZXYtPmRvbWFpbik7CiAgICAgICAgIH0KICAg
ICB9CiAKLSAgICByZXR1cm4gMDsKKyAgICByZXQgPSBkb21haW5fY29udGV4
dF9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYpOworICAgIGlm
ICggcmV0ICkKKyAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJ
WCwgIiVwZDogY29udGV4dCBtYXBwaW5nIGZhaWxlZFxuIiwKKyAgICAgICAg
ICAgICAgICBwZGV2LT5kb21haW4pOworCisgICAgcmV0dXJuIHJldDsKIH0K
IAogc3RhdGljIGludCBjZl9jaGVjayBpbnRlbF9pb21tdV9lbmFibGVfZGV2
aWNlKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQpAQCAtMjA0MywxMSArMjA0MCwx
NSBAQCBzdGF0aWMgaW50IGNmX2NoZWNrIGludGVsX2lvbW11X3JlbW92ZV9k
CiB7CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwogICAgIHUx
NiBiZGY7Ci0gICAgaW50IGk7CisgICAgaW50IHJldCwgaTsKIAogICAgIGlm
ICggIXBkZXYtPmRvbWFpbiApCiAgICAgICAgIHJldHVybiAtRUlOVkFMOwog
CisgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAocGRldi0+ZG9tYWlu
LCBkZXZmbiwgcGRldik7CisgICAgaWYgKCByZXQgKQorICAgICAgICByZXR1
cm4gcmV0OworCiAgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2UgKCBybXJyLCBi
ZGYsIGkgKQogICAgIHsKICAgICAgICAgaWYgKCBybXJyLT5zZWdtZW50ICE9
IHBkZXYtPnNlZyB8fApAQCAtMjA2Myw3ICsyMDY0LDcgQEAgc3RhdGljIGlu
dCBjZl9jaGVjayBpbnRlbF9pb21tdV9yZW1vdmVfZAogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHJtcnItPmVuZF9hZGRyZXNzLCAwKTsKICAg
ICB9CiAKLSAgICByZXR1cm4gZG9tYWluX2NvbnRleHRfdW5tYXAocGRldi0+
ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgcmV0dXJuIDA7CiB9CiAKIHN0
YXRpYyBpbnQgX19od2RvbV9pbml0IGNmX2NoZWNrIHNldHVwX2h3ZG9tX2Rl
dmljZSgK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-03.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHRpZ2h0ZW4gaW9tbXVfYWxsb2NfcGd0YWJsZSgpJ3Mg
cGFyYW1ldGVyCgpUaGlzIGlzIHRvIG1ha2UgbW9yZSBvYnZpb3VzIHRoYXQg
bm90aGluZyBvdXRzaWRlIG9mIGRvbWFpbl9pb21tdShkKQphY3R1YWxseSBj
aGFuZ2VzIG9yIGlzIG90aGVyd2lzZSBuZWVkZWQgYnkgdGhlIGZ1bmN0aW9u
LgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UgaW50ZW5kZWQuCgpTaWduZWQtb2Zm
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
UmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZp
ZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+Ci0t
LQp2MzogUmUtYmFzZS4KdjI6IE5ldy4KCi0tLSBhL3hlbi9hcmNoL3g4Ni9p
bmNsdWRlL2FzbS9pb21tdS5oCisrKyBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRl
L2FzbS9pb21tdS5oCkBAIC0xNDIsNyArMTQyLDggQEAgc3RhdGljIGlubGlu
ZSB2b2lkIGlvbW11X3N5bmNfY2FjaGUoY29ucwogfQogCiBpbnQgX19tdXN0
X2NoZWNrIGlvbW11X2ZyZWVfcGd0YWJsZXMoc3RydWN0IGRvbWFpbiAqZCk7
Ci1zdHJ1Y3QgcGFnZV9pbmZvICpfX211c3RfY2hlY2sgaW9tbXVfYWxsb2Nf
cGd0YWJsZShzdHJ1Y3QgZG9tYWluICpkKTsKK3N0cnVjdCBkb21haW5faW9t
bXU7CitzdHJ1Y3QgcGFnZV9pbmZvICpfX211c3RfY2hlY2sgaW9tbXVfYWxs
b2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCk7CiAKICNlbmRp
ZiAvKiAhX19BUkNIX1g4Nl9JT01NVV9IX18gKi8KIC8qCi0tLSBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYworKysgYi94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMKQEAgLTE4NCw3
ICsxODQsNyBAQCBzdGF0aWMgaW50IGlvbW11X3BkZV9mcm9tX2RmbihzdHJ1
Y3QgZG9tCiAgICAgdW5zaWduZWQgbG9uZyAgbmV4dF90YWJsZV9tZm47CiAg
ICAgdW5zaWduZWQgaW50IGxldmVsOwogICAgIHN0cnVjdCBwYWdlX2luZm8g
KnRhYmxlOwotICAgIGNvbnN0IHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0g
ZG9tX2lvbW11KGQpOworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0g
ZG9tX2lvbW11KGQpOwogCiAgICAgdGFibGUgPSBoZC0+YXJjaC5hbWQucm9v
dF90YWJsZTsKICAgICBsZXZlbCA9IGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9k
ZTsKQEAgLTIxOSw3ICsyMTksNyBAQCBzdGF0aWMgaW50IGlvbW11X3BkZV9m
cm9tX2RmbihzdHJ1Y3QgZG9tCiAgICAgICAgICAgICBtZm4gPSBuZXh0X3Rh
YmxlX21mbjsKIAogICAgICAgICAgICAgLyogYWxsb2NhdGUgbG93ZXIgbGV2
ZWwgcGFnZSB0YWJsZSAqLwotICAgICAgICAgICAgdGFibGUgPSBpb21tdV9h
bGxvY19wZ3RhYmxlKGQpOworICAgICAgICAgICAgdGFibGUgPSBpb21tdV9h
bGxvY19wZ3RhYmxlKGhkKTsKICAgICAgICAgICAgIGlmICggdGFibGUgPT0g
TlVMTCApCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgQU1EX0lP
TU1VX0VSUk9SKCJjYW5ub3QgYWxsb2NhdGUgSS9PIHBhZ2UgdGFibGVcbiIp
OwpAQCAtMjQ5LDcgKzI0OSw3IEBAIHN0YXRpYyBpbnQgaW9tbXVfcGRlX2Zy
b21fZGZuKHN0cnVjdCBkb20KIAogICAgICAgICAgICAgaWYgKCBuZXh0X3Rh
YmxlX21mbiA9PSAwICkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAg
ICB0YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUoZCk7CisgICAgICAgICAg
ICAgICAgdGFibGUgPSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKICAgICAg
ICAgICAgICAgICBpZiAoIHRhYmxlID09IE5VTEwgKQogICAgICAgICAgICAg
ICAgIHsKICAgICAgICAgICAgICAgICAgICAgQU1EX0lPTU1VX0VSUk9SKCJj
YW5ub3QgYWxsb2NhdGUgSS9PIHBhZ2UgdGFibGVcbiIpOwpAQCAtNTU1LDcg
KzU1NSw3IEBAIGludCBfX2luaXQgY2ZfY2hlY2sgYW1kX2lvbW11X3F1YXJh
bnRpbmUKIAogICAgIHNwaW5fbG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2Nr
KTsKIAotICAgIGhkLT5hcmNoLmFtZC5yb290X3RhYmxlID0gaW9tbXVfYWxs
b2NfcGd0YWJsZShkKTsKKyAgICBoZC0+YXJjaC5hbWQucm9vdF90YWJsZSA9
IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOwogICAgIGlmICggIWhkLT5hcmNo
LmFtZC5yb290X3RhYmxlICkKICAgICAgICAgZ290byBvdXQ7CiAKQEAgLTU3
MCw3ICs1NzAsNyBAQCBpbnQgX19pbml0IGNmX2NoZWNrIGFtZF9pb21tdV9x
dWFyYW50aW5lCiAgICAgICAgICAqIHBhZ2UgdGFibGUgcGFnZXMsIGFuZCB0
aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMKICAgICAgICAg
ICogemVyb2VkLgogICAgICAgICAgKi8KLSAgICAgICAgcGcgPSBpb21tdV9h
bGxvY19wZ3RhYmxlKGQpOworICAgICAgICBwZyA9IGlvbW11X2FsbG9jX3Bn
dGFibGUoaGQpOwogICAgICAgICBpZiAoICFwZyApCiAgICAgICAgICAgICBi
cmVhazsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNp
X2FtZF9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft
ZC9wY2lfYW1kX2lvbW11LmMKQEAgLTI0Miw3ICsyNDIsNyBAQCBpbnQgYW1k
X2lvbW11X2FsbG9jX3Jvb3Qoc3RydWN0IGRvbWFpbiAqCiAKICAgICBpZiAo
IHVubGlrZWx5KCFoZC0+YXJjaC5hbWQucm9vdF90YWJsZSkgKQogICAgIHsK
LSAgICAgICAgaGQtPmFyY2guYW1kLnJvb3RfdGFibGUgPSBpb21tdV9hbGxv
Y19wZ3RhYmxlKGQpOworICAgICAgICBoZC0+YXJjaC5hbWQucm9vdF90YWJs
ZSA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOwogICAgICAgICBpZiAoICFo
ZC0+YXJjaC5hbWQucm9vdF90YWJsZSApCiAgICAgICAgICAgICByZXR1cm4g
LUVOT01FTTsKICAgICB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0
ZC9pb21tdS5jCkBAIC0zMTgsNyArMzE4LDcgQEAgc3RhdGljIHU2NCBhZGRy
X3RvX2RtYV9wYWdlX21hZGRyKHN0cnVjdAogICAgIHsKICAgICAgICAgc3Ry
dWN0IHBhZ2VfaW5mbyAqcGc7CiAKLSAgICAgICAgaWYgKCAhYWxsb2MgfHwg
IShwZyA9IGlvbW11X2FsbG9jX3BndGFibGUoZG9tYWluKSkgKQorICAgICAg
ICBpZiAoICFhbGxvYyB8fCAhKHBnID0gaW9tbXVfYWxsb2NfcGd0YWJsZSho
ZCkpICkKICAgICAgICAgICAgIGdvdG8gb3V0OwogCiAgICAgICAgIGhkLT5h
cmNoLnZ0ZC5wZ2RfbWFkZHIgPSBwYWdlX3RvX21hZGRyKHBnKTsKQEAgLTMz
OCw3ICszMzgsNyBAQCBzdGF0aWMgdTY0IGFkZHJfdG9fZG1hX3BhZ2VfbWFk
ZHIoc3RydWN0CiAgICAgICAgICAgICBpZiAoICFhbGxvYyApCiAgICAgICAg
ICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgICAgIHBnID0gaW9tbXVfYWxs
b2NfcGd0YWJsZShkb21haW4pOworICAgICAgICAgICAgcGcgPSBpb21tdV9h
bGxvY19wZ3RhYmxlKGhkKTsKICAgICAgICAgICAgIGlmICggIXBnICkKICAg
ICAgICAgICAgICAgICBicmVhazsKIApAQCAtMjc2Myw3ICsyNzYzLDcgQEAg
c3RhdGljIGludCBfX2luaXQgY2ZfY2hlY2sgaW50ZWxfaW9tbXVfcQogICAg
ICAgICBnb3RvIG91dDsKICAgICB9CiAKLSAgICBwZyA9IGlvbW11X2FsbG9j
X3BndGFibGUoZCk7CisgICAgcGcgPSBpb21tdV9hbGxvY19wZ3RhYmxlKGhk
KTsKIAogICAgIHJjID0gLUVOT01FTTsKICAgICBpZiAoICFwZyApCkBAIC0y
NzgyLDcgKzI3ODIsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBjZl9jaGVjayBp
bnRlbF9pb21tdV9xCiAgICAgICAgICAqIHBhZ2UgdGFibGUgcGFnZXMsIGFu
ZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMKICAgICAg
ICAgICogemVyb2VkLgogICAgICAgICAgKi8KLSAgICAgICAgcGcgPSBpb21t
dV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICBwZyA9IGlvbW11X2FsbG9j
X3BndGFibGUoaGQpOwogCiAgICAgICAgIGlmICggIXBnICkKICAgICAgICAg
ICAgIGdvdG8gb3V0OwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94
ODYvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYv
aW9tbXUuYwpAQCAtNDIwLDkgKzQyMCw4IEBAIGludCBpb21tdV9mcmVlX3Bn
dGFibGVzKHN0cnVjdCBkb21haW4gKmQKICAgICByZXR1cm4gMDsKIH0KIAot
c3RydWN0IHBhZ2VfaW5mbyAqaW9tbXVfYWxsb2NfcGd0YWJsZShzdHJ1Y3Qg
ZG9tYWluICpkKQorc3RydWN0IHBhZ2VfaW5mbyAqaW9tbXVfYWxsb2NfcGd0
YWJsZShzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCkKIHsKLSAgICBzdHJ1Y3Qg
ZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKICAgICB1bnNpZ25l
ZCBpbnQgbWVtZmxhZ3MgPSAwOwogICAgIHN0cnVjdCBwYWdlX2luZm8gKnBn
OwogICAgIHZvaWQgKnA7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-00.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-00.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBzcGxpdCBkb21pZCBtYXAgY2xlYW51cCBjaGVjayBpbnRvIGEg
ZnVuY3Rpb24KClRoaXMgbG9naWMgd2lsbCB3YW50IGludm9raW5nIGZyb20g
ZWxzZXdoZXJlLgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UgaW50ZW5kZWQuCgpT
aWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5A
aW50ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKQEAgLTE1Miw2ICsxNTIsNjggQEAgc3RhdGljIHZvaWQgX19pbml0
IGZyZWVfaW50ZWxfaW9tbXUoc3RydQogICAgIHhmcmVlKGludGVsKTsKIH0K
IAorc3RhdGljIHZvaWQgY2xlYW51cF9kb21pZF9tYXAoc3RydWN0IGRvbWFp
biAqZG9tYWluLCBzdHJ1Y3QgaW9tbXUgKmlvbW11KQoreworICAgIGludCBp
b21tdV9kb21pZCA9IGRvbWFpbl9pb21tdV9kb21pZChkb21haW4sIGlvbW11
KTsKKworICAgIGlmICggaW9tbXVfZG9taWQgPj0gMCApCisgICAgeworICAg
ICAgICAvKgorICAgICAgICAgKiBVcGRhdGUgZG9taWRfbWFwW10gL2JlZm9y
ZS8gZG9taWRfYml0bWFwW10gdG8gYXZvaWQgYSByYWNlIHdpdGgKKyAgICAg
ICAgICogY29udGV4dF9zZXRfZG9tYWluX2lkKCksIHNldHRpbmcgdGhlIHNs
b3QgdG8gRE9NSURfSU5WQUxJRCBmb3IKKyAgICAgICAgICogLT5kb21pZF9t
YXBbXSByZWFkcyB0byBwcm9kdWNlIGEgc3VpdGFibGUgdmFsdWUgd2hpbGUg
dGhlIGJpdCBpcworICAgICAgICAgKiBzdGlsbCBzZXQuCisgICAgICAgICAq
LworICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2lvbW11X2RvbWlkXSA9IERP
TUlEX0lOVkFMSUQ7CisgICAgICAgIGNsZWFyX2JpdChpb21tdV9kb21pZCwg
aW9tbXUtPmRvbWlkX2JpdG1hcCk7CisgICAgfQorfQorCitzdGF0aWMgYm9v
bCBhbnlfcGRldl9iZWhpbmRfaW9tbXUoY29uc3Qgc3RydWN0IGRvbWFpbiAq
ZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBz
dHJ1Y3QgcGNpX2RldiAqZXhjbHVkZSwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaW9tbXUgKmlvbW11KQorewor
ICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2OworCisgICAgZm9yX2Vh
Y2hfcGRldiAoIGQsIHBkZXYgKQorICAgIHsKKyAgICAgICAgY29uc3Qgc3Ry
dWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOworCisgICAgICAgIGlmICggcGRl
diA9PSBleGNsdWRlICkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAg
ICAgIGRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7
CisgICAgICAgIGlmICggZHJoZCAmJiBkcmhkLT5pb21tdSA9PSBpb21tdSAp
CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAgICByZXR1
cm4gZmFsc2U7Cit9CisKKy8qCisgKiBJZiBubyBvdGhlciBkZXZpY2VzIHVu
ZGVyIHRoZSBzYW1lIGlvbW11IG93bmVkIGJ5IHRoaXMgZG9tYWluLAorICog
Y2xlYXIgaW9tbXUgaW4gaW9tbXVfYml0bWFwIGFuZCBjbGVhciBkb21haW5f
aWQgaW4gZG9taWRfYml0bWFwLgorICovCitzdGF0aWMgdm9pZCBjaGVja19j
bGVhbnVwX2RvbWlkX21hcChzdHJ1Y3QgZG9tYWluICpkLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBjaV9k
ZXYgKmV4Y2x1ZGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBzdHJ1Y3QgaW9tbXUgKmlvbW11KQoreworICAgIGJvb2wgZm91bmQg
PSBhbnlfcGRldl9iZWhpbmRfaW9tbXUoZCwgZXhjbHVkZSwgaW9tbXUpOwor
CisgICAgLyoKKyAgICAgKiBIaWRkZW4gZGV2aWNlcyBhcmUgYXNzb2NpYXRl
ZCB3aXRoIERvbVhFTiBidXQgdXNhYmxlIGJ5IHRoZSBoYXJkd2FyZQorICAg
ICAqIGRvbWFpbi4gSGVuY2UgdGhleSBuZWVkIGNvbnNpZGVyaW5nIGhlcmUg
YXMgd2VsbC4KKyAgICAgKi8KKyAgICBpZiAoICFmb3VuZCAmJiBpc19oYXJk
d2FyZV9kb21haW4oZCkgKQorICAgICAgICBmb3VuZCA9IGFueV9wZGV2X2Jl
aGluZF9pb21tdShkb21feGVuLCBleGNsdWRlLCBpb21tdSk7CisKKyAgICBp
ZiAoICFmb3VuZCApCisgICAgeworICAgICAgICBjbGVhcl9iaXQoaW9tbXUt
PmluZGV4LCAmZG9tX2lvbW11KGQpLT5hcmNoLmlvbW11X2JpdG1hcCk7Cisg
ICAgICAgIGNsZWFudXBfZG9taWRfbWFwKGQsIGlvbW11KTsKKyAgICB9Cit9
CisKIHN0YXRpYyBpbnQgaW9tbXVzX2luY29oZXJlbnQ7CiAKIHN0YXRpYyB2
b2lkIHN5bmNfY2FjaGUoY29uc3Qgdm9pZCAqYWRkciwgdW5zaWduZWQgaW50
IHNpemUpCkBAIC0xNjcxLDcgKzE3MzMsNiBAQCBzdGF0aWMgaW50IGRvbWFp
bl9jb250ZXh0X3VubWFwKHN0cnVjdCBkCiAgICAgc3RydWN0IGlvbW11ICpp
b21tdTsKICAgICBpbnQgcmV0ID0gMDsKICAgICB1OCBzZWcgPSBwZGV2LT5z
ZWcsIGJ1cyA9IHBkZXYtPmJ1cywgdG1wX2J1cywgdG1wX2RldmZuLCBzZWNi
dXM7Ci0gICAgaW50IGZvdW5kID0gMDsKIAogICAgIGRyaGQgPSBhY3BpX2Zp
bmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CiAgICAgaWYgKCAhZHJoZCAp
CkBAIC0xNzQwLDQ1ICsxODAxLDggQEAgc3RhdGljIGludCBkb21haW5fY29u
dGV4dF91bm1hcChzdHJ1Y3QgZAogICAgICAgICBnb3RvIG91dDsKICAgICB9
CiAKLSAgICAvKgotICAgICAqIGlmIG5vIG90aGVyIGRldmljZXMgdW5kZXIg
dGhlIHNhbWUgaW9tbXUgb3duZWQgYnkgdGhpcyBkb21haW4sCi0gICAgICog
Y2xlYXIgaW9tbXUgaW4gaW9tbXVfYml0bWFwIGFuZCBjbGVhciBkb21haW5f
aWQgaW4gZG9taWRfYml0bXAKLSAgICAgKi8KLSAgICBmb3JfZWFjaF9wZGV2
ICggZG9tYWluLCBwZGV2ICkKLSAgICB7Ci0gICAgICAgIGlmICggcGRldi0+
c2VnID09IHNlZyAmJiBwZGV2LT5idXMgPT0gYnVzICYmIHBkZXYtPmRldmZu
ID09IGRldmZuICkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotCi0gICAgICAg
IGRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7Ci0g
ICAgICAgIGlmICggZHJoZCAmJiBkcmhkLT5pb21tdSA9PSBpb21tdSApCi0g
ICAgICAgIHsKLSAgICAgICAgICAgIGZvdW5kID0gMTsKLSAgICAgICAgICAg
IGJyZWFrOwotICAgICAgICB9Ci0gICAgfQotCi0gICAgaWYgKCBmb3VuZCA9
PSAwICkKLSAgICB7Ci0gICAgICAgIGludCBpb21tdV9kb21pZDsKLQotICAg
ICAgICBjbGVhcl9iaXQoaW9tbXUtPmluZGV4LCAmZG9tX2lvbW11KGRvbWFp
biktPmFyY2guaW9tbXVfYml0bWFwKTsKLQotICAgICAgICBpb21tdV9kb21p
ZCA9IGRvbWFpbl9pb21tdV9kb21pZChkb21haW4sIGlvbW11KTsKLSAgICAg
ICAgaWYgKCBpb21tdV9kb21pZCA9PSAtMSApCi0gICAgICAgIHsKLSAgICAg
ICAgICAgIHJldCA9IC1FSU5WQUw7Ci0gICAgICAgICAgICBnb3RvIG91dDsK
LSAgICAgICAgfQotCi0gICAgICAgIC8qCi0gICAgICAgICAqIFVwZGF0ZSBk
b21pZF9tYXBbXSAvYmVmb3JlLyBkb21pZF9iaXRtYXBbXSB0byBhdm9pZCBh
IHJhY2Ugd2l0aAotICAgICAgICAgKiBjb250ZXh0X3NldF9kb21haW5faWQo
KSwgc2V0dGluZyB0aGUgc2xvdCB0byBET01JRF9JTlZBTElEIGZvcgotICAg
ICAgICAgKiAtPmRvbWlkX21hcFtdIHJlYWRzIHRvIHByb2R1Y2UgYSBzdWl0
YWJsZSB2YWx1ZSB3aGlsZSB0aGUgYml0IGlzCi0gICAgICAgICAqIHN0aWxs
IHNldC4KLSAgICAgICAgICovCi0gICAgICAgIGlvbW11LT5kb21pZF9tYXBb
aW9tbXVfZG9taWRdID0gRE9NSURfSU5WQUxJRDsKLSAgICAgICAgY2xlYXJf
Yml0KGlvbW11X2RvbWlkLCBpb21tdS0+ZG9taWRfYml0bWFwKTsKLSAgICB9
CisgICAgaWYgKCAhcmV0ICkKKyAgICAgICAgY2hlY2tfY2xlYW51cF9kb21p
ZF9tYXAoZG9tYWluLCBwZGV2LCBpb21tdSk7CiAKIG91dDoKICAgICByZXR1
cm4gcmV0Owo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-01.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-01.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggKGRlKWFzc2lnbiBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSB1cGRhdGVkLgoKQWxzbyBhZGp1c3QgYSByZWxhdGVk
IGxvZyBtZXNzYWdlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM1OCAvIHBhcnQg
b2YgWFNBLTQwMC4KCkZpeGVzOiA4Yjk5ZjQ0MDBiNjkgKCJWVC1kOiBmaXgg
Uk1SUiByZWxhdGVkIGVycm9yIGhhbmRsaW5nIikKU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog
Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+ClJldmll
d2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KUmV2aWV3ZWQt
Ynk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgoKLS0tIGEv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAgLTIzNTIsNiAr
MjM1MiwxMCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNo
aXAoCiB7CiAgICAgaW50IHJldDsKIAorICAgIHJldCA9IGRvbWFpbl9jb250
ZXh0X3VubWFwKHNvdXJjZSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0
ICkKKyAgICAgICAgcmV0dXJuIHJldDsKKwogICAgIC8qCiAgICAgICogRGV2
aWNlcyBhc3NpZ25lZCB0byB1bnRydXN0ZWQgZG9tYWlucyAoaGVyZSBhc3N1
bWVkIHRvIGJlIGFueSBkb21VKQogICAgICAqIGNhbiBhdHRlbXB0IHRvIHNl
bmQgYXJiaXRyYXJ5IExBUElDL01TSSBtZXNzYWdlcy4gV2UgYXJlIHVucHJv
dGVjdGVkCkBAIC0yMzg4LDEwICsyMzkyLDYgQEAgc3RhdGljIGludCByZWFz
c2lnbl9kZXZpY2Vfb3duZXJzaGlwKAogICAgICAgICAgICAgfQogICAgIH0K
IAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHNvdXJjZSwgZGV2
Zm4sIHBkZXYpOwotICAgIGlmICggcmV0ICkKLSAgICAgICAgcmV0dXJuIHJl
dDsKLQogICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+
ZG9tYWluICE9IGRvbV9pbyApCiAgICAgewogICAgICAgICBsaXN0X21vdmUo
JnBkZXYtPmRvbWFpbl9saXN0LCAmZG9tX2lvLT5hcmNoLnBkZXZfbGlzdCk7
CkBAIC0yNDY4LDkgKzI0NjgsOCBAQCBzdGF0aWMgaW50IGludGVsX2lvbW11
X2Fzc2lnbl9kZXZpY2UoCiAgICAgICAgIH0KICAgICB9CiAKLSAgICByZXQg
PSByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlwKHMsIGQsIGRldmZuLCBwZGV2
KTsKLSAgICBpZiAoIHJldCB8fCBkID09IGRvbV9pbyApCi0gICAgICAgIHJl
dHVybiByZXQ7CisgICAgaWYgKCBkID09IGRvbV9pbyApCisgICAgICAgIHJl
dHVybiByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlwKHMsIGQsIGRldmZuLCBw
ZGV2KTsKIAogICAgIC8qIFNldHVwIHJtcnIgaWRlbnRpdHkgbWFwcGluZyAq
LwogICAgIGZvcl9lYWNoX3JtcnJfZGV2aWNlKCBybXJyLCBiZGYsIGkgKQpA
QCAtMjQ4MywyMCArMjQ4MiwzNyBAQCBzdGF0aWMgaW50IGludGVsX2lvbW11
X2Fzc2lnbl9kZXZpY2UoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHJtcnItPmVuZF9hZGRyZXNzLCBmbGFnKTsKICAgICAg
ICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAg
ICAgICBpbnQgcmM7Ci0KLSAgICAgICAgICAgICAgICByYyA9IHJlYXNzaWdu
X2RldmljZV9vd25lcnNoaXAoZCwgcywgZGV2Zm4sIHBkZXYpOwogICAgICAg
ICAgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlIgVlREUFJFRklYCi0gICAg
ICAgICAgICAgICAgICAgICAgICIgY2Fubm90IG1hcCByZXNlcnZlZCByZWdp
b24gKCUiUFJJeDY0IiwlIlBSSXg2NCJdIGZvciBEb20lZCAoJWQpXG4iLAot
ICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsIHJt
cnItPmVuZF9hZGRyZXNzLAotICAgICAgICAgICAgICAgICAgICAgICBkLT5k
b21haW5faWQsIHJldCk7Ci0gICAgICAgICAgICAgICAgaWYgKCByYyApCi0g
ICAgICAgICAgICAgICAgewotICAgICAgICAgICAgICAgICAgICBwcmludGso
WEVOTE9HX0VSUiBWVERQUkVGSVgKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICIgZmFpbGVkIHRvIHJlY2xhaW0gJTA0eDolMDJ4OiUwMnguJXUgZnJv
bSAlcGQgKCVkKVxuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIHNl
ZywgYnVzLCBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSwgZCwg
cmMpOwotICAgICAgICAgICAgICAgICAgICBkb21haW5fY3Jhc2goZCk7Ci0g
ICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgICAgICAgICAiJXBk
OiBjYW5ub3QgbWFwIHJlc2VydmVkIHJlZ2lvbiBbJSJQUkl4NjQiLCUiUFJJ
eDY0Il06ICVkXG4iLAorICAgICAgICAgICAgICAgICAgICAgICBkLCBybXJy
LT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRyZXNzLCByZXQpOworICAg
ICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQorICAgICAgICB9
CisgICAgfQorCisgICAgaWYgKCAhcmV0ICkKKyAgICAgICAgcmV0ID0gcmVh
c3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7CisK
KyAgICAvKiBTZWUgcmVhc3NpZ25fZGV2aWNlX293bmVyc2hpcCgpIGZvciB0
aGUgaHdkb20gYXNwZWN0LiAqLworICAgIGlmICggIXJldCB8fCBpc19oYXJk
d2FyZV9kb21haW4oZCkgKQorICAgICAgICByZXR1cm4gcmV0OworCisgICAg
Zm9yX2VhY2hfcm1ycl9kZXZpY2UoIHJtcnIsIGJkZiwgaSApCisgICAgewor
ICAgICAgICBpZiAoIHJtcnItPnNlZ21lbnQgPT0gc2VnICYmCisgICAgICAg
ICAgICAgUENJX0JVUyhiZGYpID09IGJ1cyAmJgorICAgICAgICAgICAgIFBD
SV9ERVZGTjIoYmRmKSA9PSBkZXZmbiApCisgICAgICAgIHsKKyAgICAgICAg
ICAgIGludCByYyA9IGlvbW11X2lkZW50aXR5X21hcHBpbmcoZCwgcDJtX2Fj
Y2Vzc194LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmVuZF9hZGRyZXNz
LCAwKTsKKworICAgICAgICAgICAgaWYgKCByYyAmJiByYyAhPSAtRU5PRU5U
ICkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgKKyAgICAgICAgICAgICAgICAgICAgICAgIiVw
ZDogY2Fubm90IHVubWFwIHJlc2VydmVkIHJlZ2lvbiBbJSJQUkl4NjQiLCUi
UFJJeDY0Il06ICVkXG4iLAorICAgICAgICAgICAgICAgICAgICAgICBkLCBy
bXJyLT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRyZXNzLCByYyk7Cisg
ICAgICAgICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwogICAgICAgICAgICAg
ICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICB9Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-02.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-02.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggYWRkL3JlbW92ZSBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSBjbGVhcmVkLgoKQWxzbyBzd2l0Y2ggdG8gJXBkIGlu
IHJlbGF0ZWQgbG9nIG1lc3NhZ2VzLgoKRml4ZXM6IGZhODhjZmFkZjkxOCAo
InZ0LWQ6IE1hcCBSTVJSIGluIGludGVsX2lvbW11X2FkZF9kZXZpY2UoKSBp
ZiB0aGUgZGV2aWNlIGhhcyBSTVJSIikKRml4ZXM6IDhiOTlmNDQwMGI2OSAo
IlZULWQ6IGZpeCBSTVJSIHJlbGF0ZWQgZXJyb3IgaGFuZGxpbmciKQpTaWdu
ZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJl
dmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4
LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50
ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmMKQEAgLTE5ODUsMTQgKzE5ODUsNiBAQCBzdGF0aWMgaW50IGludGVsX2lv
bW11X2FkZF9kZXZpY2UodTggZGV2CiAgICAgaWYgKCAhcGRldi0+ZG9tYWlu
ICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CiAKLSAgICByZXQgPSBkb21h
aW5fY29udGV4dF9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYp
OwotICAgIGlmICggcmV0ICkKLSAgICB7Ci0gICAgICAgIGRwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgsICJkJWQ6IGNvbnRleHQgbWFwcGluZyBmYWls
ZWRcbiIsCi0gICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluLT5kb21haW5f
aWQpOwotICAgICAgICByZXR1cm4gcmV0OwotICAgIH0KLQogICAgIGZvcl9l
YWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKICAgICB7CiAgICAg
ICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBwZGV2LT5zZWcgJiYKQEAgLTIw
MDksMTIgKzIwMDEsMTcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hZGRf
ZGV2aWNlKHU4IGRldgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRy
ZXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAwKTsKICAgICAgICAgICAgIGlmICggcmV0ICkKLSAgICAgICAgICAgICAg
ICBkcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiZCVkOiBSTVJSIG1h
cHBpbmcgZmFpbGVkXG4iLAotICAgICAgICAgICAgICAgICAgICAgICAgcGRl
di0+ZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAgICAgIGRwcmlu
dGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IFJNUlIgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LT5kb21h
aW4pOwogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuIDA7CisgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZyhwZGV2LT5kb21haW4sIGRl
dmZuLCBwZGV2KTsKKyAgICBpZiAoIHJldCApCisgICAgICAgIGRwcmludGso
WEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IGNvbnRleHQgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluKTsKKwor
ICAgIHJldHVybiByZXQ7CiB9CiAKIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVf
ZW5hYmxlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRldikKQEAgLTIwMzYs
MTEgKzIwMzMsMTUgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVf
ZGV2aWNlKHU4CiB7CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJy
OwogICAgIHUxNiBiZGY7Ci0gICAgaW50IGk7CisgICAgaW50IHJldCwgaTsK
IAogICAgIGlmICggIXBkZXYtPmRvbWFpbiApCiAgICAgICAgIHJldHVybiAt
RUlOVkFMOwogCisgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAocGRl
di0+ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgaWYgKCByZXQgKQorICAg
ICAgICByZXR1cm4gcmV0OworCiAgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2Ug
KCBybXJyLCBiZGYsIGkgKQogICAgIHsKICAgICAgICAgaWYgKCBybXJyLT5z
ZWdtZW50ICE9IHBkZXYtPnNlZyB8fApAQCAtMjA1Niw3ICsyMDU3LDcgQEAg
c3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4CiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3Ms
IDApOwogICAgIH0KIAotICAgIHJldHVybiBkb21haW5fY29udGV4dF91bm1h
cChwZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKKyAgICByZXR1cm4gMDsK
IH0KIAogc3RhdGljIGludCBfX2h3ZG9tX2luaXQgc2V0dXBfaHdkb21fZGV2
aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-03.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBkcm9wIG93bmVyc2hpcCBjaGVja2luZyBmcm9tIGRvbWFpbl9j
b250ZXh0X21hcHBpbmdfb25lKCkKCkRlc3BpdGUgcHV0dGluZyBpbiBxdWl0
ZSBhIGJpdCBvZiBlZmZvcnQgaXQgd2FzIG5vdCBwb3NzaWJsZSB0bwplc3Rh
Ymxpc2ggd2h5IGV4YWN0bHkgdGhpcyBjb2RlIGV4aXN0cyAoYmV5b25kIHBv
c3NpYmx5IHNhbml0eQpjaGVja2luZykuIEluc3RlYWQgb2YgYSBzdWJzZXF1
ZW50IGNoYW5nZSBmdXJ0aGVyIGNvbXBsaWNhdGluZyB0aGlzCmxvZ2ljLCBz
aW1wbHkgZ2V0IHJpZCBvZiBpdC4KClRha2UgdGhlIG9wcG9ydHVuaXR5IGFu
ZCBtb3ZlIHRoZSByZXNwZWN0aXZlIHVubWFwX3Z0ZF9kb21haW5fcGFnZSgp
IG91dApvZiB0aGUgbG9ja2VkIHJlZ2lvbi4KClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdl
ZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5
OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KCi0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCkBAIC0xMTIsMjggKzEx
Miw2IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVj
dAogICAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGNvbnRleHRfZ2V0
X2RvbWFpbl9pZChzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4dCwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpb21tdSAq
aW9tbXUpCi17Ci0gICAgdW5zaWduZWQgbG9uZyBkb21faW5kZXgsIG5yX2Rv
bTsKLSAgICBpbnQgZG9taWQgPSAtMTsKLQotICAgIGlmIChpb21tdSAmJiBj
b250ZXh0KQotICAgIHsKLSAgICAgICAgbnJfZG9tID0gY2FwX25kb21zKGlv
bW11LT5jYXApOwotCi0gICAgICAgIGRvbV9pbmRleCA9IGNvbnRleHRfZG9t
YWluX2lkKCpjb250ZXh0KTsKLQotICAgICAgICBpZiAoIGRvbV9pbmRleCA8
IG5yX2RvbSAmJiBpb21tdS0+ZG9taWRfbWFwICkKLSAgICAgICAgICAgIGRv
bWlkID0gaW9tbXUtPmRvbWlkX21hcFtkb21faW5kZXhdOwotICAgICAgICBl
bHNlCi0gICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19ERUJVRyBWVERQUkVG
SVgsCi0gICAgICAgICAgICAgICAgICAgICJkb21faW5kZXggJWx1IGV4Y2Vl
ZHMgbnJfZG9tICVsdSBvciBpb21tdSBoYXMgbm8gZG9taWRfbWFwXG4iLAot
ICAgICAgICAgICAgICAgICAgICBkb21faW5kZXgsIG5yX2RvbSk7Ci0gICAg
fQotICAgIHJldHVybiBkb21pZDsKLX0KLQogc3RhdGljIHN0cnVjdCBpbnRl
bF9pb21tdSAqX19pbml0IGFsbG9jX2ludGVsX2lvbW11KHZvaWQpCiB7CiAg
ICAgc3RydWN0IGludGVsX2lvbW11ICppbnRlbDsKQEAgLTE0MzMsNDkgKzE0
MTEsOSBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAKICAg
ICBpZiAoIGNvbnRleHRfcHJlc2VudCgqY29udGV4dCkgKQogICAgIHsKLSAg
ICAgICAgaW50IHJlcyA9IDA7Ci0KLSAgICAgICAgLyogVHJ5IHRvIGdldCBk
b21haW4gb3duZXJzaGlwIGZyb20gZGV2aWNlIHN0cnVjdHVyZS4gIElmIHRo
YXQncwotICAgICAgICAgKiBub3QgYXZhaWxhYmxlLCB0cnkgdG8gcmVhZCBp
dCBmcm9tIHRoZSBjb250ZXh0IGl0c2VsZi4gKi8KLSAgICAgICAgaWYgKCBw
ZGV2ICkKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKCBwZGV2LT5kb21h
aW4gIT0gZG9tYWluICkKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAg
ICBwcmludGsoWEVOTE9HX0dfSU5GTyBWVERQUkVGSVgKLSAgICAgICAgICAg
ICAgICAgICAgICAgImQlZDogJTA0eDolMDJ4OiUwMnguJXUgb3duZWQgYnkg
ZCVkISIsCi0gICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWlu
X2lkLAotICAgICAgICAgICAgICAgICAgICAgICBzZWcsIGJ1cywgUENJX1NM
T1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksCi0gICAgICAgICAgICAgICAg
ICAgICAgIHBkZXYtPmRvbWFpbiA/IHBkZXYtPmRvbWFpbi0+ZG9tYWluX2lk
IDogLTEpOwotICAgICAgICAgICAgICAgIHJlcyA9IC1FSU5WQUw7Ci0gICAg
ICAgICAgICB9Ci0gICAgICAgIH0KLSAgICAgICAgZWxzZQotICAgICAgICB7
Ci0gICAgICAgICAgICBpbnQgY2RvbWFpbjsKLSAgICAgICAgICAgIGNkb21h
aW4gPSBjb250ZXh0X2dldF9kb21haW5faWQoY29udGV4dCwgaW9tbXUpOwot
ICAgICAgICAgICAgCi0gICAgICAgICAgICBpZiAoIGNkb21haW4gPCAwICkK
LSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBwcmludGsoWEVOTE9H
X0dfV0FSTklORyBWVERQUkVGSVgKLSAgICAgICAgICAgICAgICAgICAgICAg
ImQlZDogJTA0eDolMDJ4OiUwMnguJXUgbWFwcGVkLCBidXQgY2FuJ3QgZmlu
ZCBvd25lciFcbiIsCi0gICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+
ZG9tYWluX2lkLAotICAgICAgICAgICAgICAgICAgICAgICBzZWcsIGJ1cywg
UENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikpOwotICAgICAgICAg
ICAgICAgIHJlcyA9IC1FSU5WQUw7Ci0gICAgICAgICAgICB9Ci0gICAgICAg
ICAgICBlbHNlIGlmICggY2RvbWFpbiAhPSBkb21haW4tPmRvbWFpbl9pZCAp
Ci0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19HX0lORk8gVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICJk
JWQ6ICUwNHg6JTAyeDolMDJ4LiV1IGFscmVhZHkgbWFwcGVkIHRvIGQlZCEi
LAotICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwK
LSAgICAgICAgICAgICAgICAgICAgICAgc2VnLCBidXMsIFBDSV9TTE9UKGRl
dmZuKSwgUENJX0ZVTkMoZGV2Zm4pLAotICAgICAgICAgICAgICAgICAgICAg
ICBjZG9tYWluKTsKLSAgICAgICAgICAgICAgICByZXMgPSAtRUlOVkFMOwot
ICAgICAgICAgICAgfQotICAgICAgICB9Ci0KLSAgICAgICAgdW5tYXBfdnRk
X2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7CiAgICAgICAgIHNwaW5f
dW5sb2NrKCZpb21tdS0+bG9jayk7Ci0gICAgICAgIHJldHVybiByZXM7Cisg
ICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShjb250ZXh0X2VudHJpZXMp
OworICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKICAgICBpZiAoIGlvbW11
X2h3ZG9tX3Bhc3N0aHJvdWdoICYmIGlzX2hhcmR3YXJlX2RvbWFpbihkb21h
aW4pICkK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-04.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiByZS1hc3NpZ24gZGV2aWNlcyBkaXJlY3RseQoKRGV2aWNlcyB3
aXRoIFJNUlJzLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQgaG93L3do
ZW4gdGhlIHNwZWNpZmllZAptZW1vcnkgcmVnaW9ucyBtYXkgZ2V0IGFjY2Vz
c2VkLCBtYXkgbm90IGJlIGxlZnQgZGlzY29ubmVjdGVkIGZyb20gdGhlaXIK
cmVzcGVjdGl2ZSBtYXBwaW5ncyAoYXMgbG9uZyBhcyBpdCdzIG5vdCBjZXJ0
YWluIHRoYXQgdGhlIGRldmljZSBoYXMKYmVlbiBmdWxseSBxdWllc2NlZCku
IEhlbmNlIHJhdGhlciB0aGFuIHVubWFwcGluZyB0aGUgb2xkIGNvbnRleHQg
YW5kCnRoZW4gbWFwcGluZyB0aGUgbmV3IG9uZSwgcmUtYXNzaWdubWVudCBu
ZWVkcyB0byBiZSBkb25lIGluIGEgc2luZ2xlCnN0ZXAuCgpUaGlzIGlzIENW
RS0yMDIyLTI2MzU5IC8gcGFydCBvZiBYU0EtNDAwLgoKUmVwb3J0ZWQtYnk6
IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKU2lt
aWxhcmx5IHF1YXJhbnRpbmluZyBzY3JhdGNoLXBhZ2UgbW9kZSByZWxpZXMg
b24gcGFnZSB0YWJsZXMgdG8gYmUKY29udGludW91c2x5IHdpcmVkIHVwLgoK
VG8gYXZvaWQgY29tcGxpY2F0aW5nIHRoaW5ncyBtb3JlIHRoYW4gbmVjZXNz
YXJ5LCB0cmVhdCBhbGwgZGV2aWNlcwptb3N0bHkgZXF1YWxseSwgaS5lLiBy
ZWdhcmRsZXNzIG9mIHRoZWlyIGFzc29jaWF0aW9uIHdpdGggYW55IFJNUlJz
LiBUaGUKbWFpbiBkaWZmZXJlbmNlIGlzIHdoZW4gaXQgY29tZXMgdG8gdXBk
YXRpbmcgY29udGV4dCBlbnRyaWVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21p
YyB3aGVuIHRoZXJlIGFyZSBSTVJScy4gWWV0IGF0b21pY2l0eSBjYW4gb25s
eSBiZSBhY2hpZXZlZAp3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBv
ZiB3aGljaCB3ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClRoZSBzZWVtaW5n
bHkgY29tcGxpY2F0ZWQgY2hvaWNlIG9mIG5vbi1uZWdhdGl2ZSByZXR1cm4g
dmFsdWVzIGZvcgpkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgpIGlzIHRv
IGxpbWl0IGNvZGUgY2h1cm46IFRoaXMgd2F5IGNhbGxlcnMKcGFzc2luZyBO
VUxMIGZvciBwZGV2IGRvbid0IG5lZWQgZmlkZGxpbmcgd2l0aC4KClNpZ25l
ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2
aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgpS
ZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp
eC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZXh0
ZXJuLmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2V4dGVy
bi5oCkBAIC03MSw3ICs3MSw4IEBAIHZvaWQgZnJlZV9wZ3RhYmxlX21hZGRy
KHU2NCBtYWRkcik7CiB2b2lkICptYXBfdnRkX2RvbWFpbl9wYWdlKHU2NCBt
YWRkcik7CiB2b2lkIHVubWFwX3Z0ZF9kb21haW5fcGFnZSh2b2lkICp2YSk7
CiBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoc3RydWN0IGRvbWFp
biAqZG9tYWluLCBzdHJ1Y3QgaW9tbXUgKmlvbW11LAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHU4IGJ1cywgdTggZGV2Zm4sIGNvbnN0IHN0
cnVjdCBwY2lfZGV2ICopOworICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHVpbnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLAorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2
LCB1bnNpZ25lZCBpbnQgbW9kZSk7CiBpbnQgZG9tYWluX2NvbnRleHRfdW5t
YXBfb25lKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IGlvbW11ICpp
b21tdSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdTggYnVzLCB1
OCBkZXZmbik7CiBpbnQgaW50ZWxfaW9tbXVfZ2V0X3Jlc2VydmVkX2Rldmlj
ZV9tZW1vcnkoaW9tbXVfZ3JkbV90ICpmdW5jLCB2b2lkICpjdHh0KTsKQEAg
LTkxLDggKzkyLDggQEAgaW50IGlzX2lnZF92dF9lbmFibGVkX3F1aXJrKHZv
aWQpOwogdm9pZCBwbGF0Zm9ybV9xdWlya3NfaW5pdCh2b2lkKTsKIHZvaWQg
dnRkX29wc19wcmVhbWJsZV9xdWlyayhzdHJ1Y3QgaW9tbXUqIGlvbW11KTsK
IHZvaWQgdnRkX29wc19wb3N0YW1ibGVfcXVpcmsoc3RydWN0IGlvbW11KiBp
b21tdSk7Ci1pbnQgX19tdXN0X2NoZWNrIG1lX3dpZmlfcXVpcmsoc3RydWN0
IGRvbWFpbiAqZG9tYWluLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHU4IGJ1cywgdTggZGV2Zm4sIGludCBtYXApOworaW50IF9fbXVzdF9j
aGVjayBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgdWlu
dDhfdCBidXMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWlu
dDhfdCBkZXZmbiwgdW5zaWduZWQgaW50IG1vZGUpOwogdm9pZCBwY2lfdnRk
X3F1aXJrKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICopOwogdm9pZCBxdWlya19p
b21tdV9jYXBzKHN0cnVjdCBpb21tdSAqaW9tbXUpOwogCi0tLSBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCkBAIC0xMDgsNiArMTA4LDcg
QEAgc3RhdGljIGludCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0CiAg
ICAgfQogCiAgICAgc2V0X2JpdChpLCBpb21tdS0+ZG9taWRfYml0bWFwKTsK
KyAgICBjb250ZXh0LT5oaSAmPSB+KCgoMSA8PCBESURfRklFTERfV0lEVEgp
IC0gMSkgPDwgRElEX0hJR0hfT0ZGU0VUKTsKICAgICBjb250ZXh0LT5oaSB8
PSAoaSAmICgoMSA8PCBESURfRklFTERfV0lEVEgpIC0gMSkpIDw8IERJRF9I
SUdIX09GRlNFVDsKICAgICByZXR1cm4gMDsKIH0KQEAgLTEzOTEsMTUgKzEz
OTIsMjcgQEAgc3RhdGljIHZvaWQgX19od2RvbV9pbml0IGludGVsX2lvbW11
X2h3ZAogICAgIH0KIH0KIAorLyoKKyAqIFRoaXMgZnVuY3Rpb24gcmV0dXJu
cworICogLSBhIG5lZ2F0aXZlIGVycm5vIHZhbHVlIHVwb24gZXJyb3IsCisg
KiAtIHplcm8gdXBvbiBzdWNjZXNzIHdoZW4gcHJldmlvdXNseSB0aGUgZW50
cnkgd2FzIG5vbi1wcmVzZW50LCBvciB0aGlzIGlzbid0CisgKiAgIHRoZSAi
bWFpbiIgcmVxdWVzdCBmb3IgYSBkZXZpY2UgKHBkZXYgPT0gTlVMTCksIG9y
IGZvciBuby1vcCBxdWFyYW50aW5pbmcKKyAqICAgYXNzaWdubWVudHMsCisg
KiAtIHBvc2l0aXZlIChvbmUpIHVwb24gc3VjY2VzcyB3aGVuIHByZXZpb3Vz
bHkgdGhlIGVudHJ5IHdhcyBwcmVzZW50IGFuZCB0aGlzCisgKiAgIGlzIHRo
ZSAibWFpbiIgcmVxdWVzdCBmb3IgYSBkZXZpY2UgKHBkZXYgIT0gTlVMTCku
CisgKi8KIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICBz
dHJ1Y3QgZG9tYWluICpkb21haW4sCiAgICAgc3RydWN0IGlvbW11ICppb21t
dSwKLSAgICB1OCBidXMsIHU4IGRldmZuLCBjb25zdCBzdHJ1Y3QgcGNpX2Rl
diAqcGRldikKKyAgICB1aW50OF90IGJ1cywgdWludDhfdCBkZXZmbiwgY29u
c3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsCisgICAgdW5zaWduZWQgaW50IG1v
ZGUpCiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9t
bXUoZG9tYWluKTsKLSAgICBzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4
dCwgKmNvbnRleHRfZW50cmllczsKKyAgICBzdHJ1Y3QgY29udGV4dF9lbnRy
eSAqY29udGV4dCwgKmNvbnRleHRfZW50cmllcywgbGN0eHQ7CisgICAgX191
aW50MTI4X3Qgb2xkOwogICAgIHU2NCBtYWRkciwgcGdkX21hZGRyOwotICAg
IHUxNiBzZWcgPSBpb21tdS0+aW50ZWwtPmRyaGQtPnNlZ21lbnQ7CisgICAg
dWludDE2X3Qgc2VnID0gaW9tbXUtPmludGVsLT5kcmhkLT5zZWdtZW50LCBw
cmV2X2RpZCA9IDA7CisgICAgc3RydWN0IGRvbWFpbiAqcHJldl9kb20gPSBO
VUxMOwogICAgIGludCBhZ2F3LCByYywgcmV0OwogICAgIGJvb2xfdCBmbHVz
aF9kZXZfaW90bGI7CiAKQEAgLTE0MDgsMTcgKzE0MjEsMzIgQEAgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIG1hZGRyID0gYnVzX3Rv
X2NvbnRleHRfbWFkZHIoaW9tbXUsIGJ1cyk7CiAgICAgY29udGV4dF9lbnRy
aWVzID0gKHN0cnVjdCBjb250ZXh0X2VudHJ5ICopbWFwX3Z0ZF9kb21haW5f
cGFnZShtYWRkcik7CiAgICAgY29udGV4dCA9ICZjb250ZXh0X2VudHJpZXNb
ZGV2Zm5dOworICAgIG9sZCA9IChsY3R4dCA9ICpjb250ZXh0KS5mdWxsOwog
Ci0gICAgaWYgKCBjb250ZXh0X3ByZXNlbnQoKmNvbnRleHQpICkKKyAgICBp
ZiAoIGNvbnRleHRfcHJlc2VudChsY3R4dCkgKQogICAgIHsKLSAgICAgICAg
c3Bpbl91bmxvY2soJmlvbW11LT5sb2NrKTsKLSAgICAgICAgdW5tYXBfdnRk
X2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7Ci0gICAgICAgIHJldHVy
biAwOworICAgICAgICBkb21pZF90IGRvbWlkOworCisgICAgICAgIHByZXZf
ZGlkID0gY29udGV4dF9kb21haW5faWQobGN0eHQpOworICAgICAgICBkb21p
ZCA9IGlvbW11LT5kb21pZF9tYXBbcHJldl9kaWRdOworICAgICAgICBpZiAo
IGRvbWlkIDwgRE9NSURfRklSU1RfUkVTRVJWRUQgKQorICAgICAgICAgICAg
cHJldl9kb20gPSByY3VfbG9ja19kb21haW5fYnlfaWQoZG9taWQpOworICAg
ICAgICBlbHNlIGlmICggZG9taWQgPT0gRE9NSURfSU8gKQorICAgICAgICAg
ICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW4oZG9tX2lvKTsKKyAgICAg
ICAgaWYgKCAhcHJldl9kb20gKQorICAgICAgICB7CisgICAgICAgICAgICBz
cGluX3VubG9jaygmaW9tbXUtPmxvY2spOworICAgICAgICAgICAgdW5tYXBf
dnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7CisgICAgICAgICAg
ICBkcHJpbnRrKFhFTkxPR19ERUJVRyBWVERQUkVGSVgsCisgICAgICAgICAg
ICAgICAgICAgICJubyBkb21haW4gZm9yIGRpZCAldSAobnJfZG9tICV1KVxu
IiwKKyAgICAgICAgICAgICAgICAgICAgcHJldl9kaWQsIGNhcF9uZG9tcyhp
b21tdS0+Y2FwKSk7CisgICAgICAgICAgICByZXR1cm4gLUVTUkNIOworICAg
ICAgICB9CiAgICAgfQogCiAgICAgaWYgKCBpb21tdV9od2RvbV9wYXNzdGhy
b3VnaCAmJiBpc19oYXJkd2FyZV9kb21haW4oZG9tYWluKSApCiAgICAgewot
ICAgICAgICBjb250ZXh0X3NldF90cmFuc2xhdGlvbl90eXBlKCpjb250ZXh0
LCBDT05URVhUX1RUX1BBU1NfVEhSVSk7CisgICAgICAgIGNvbnRleHRfc2V0
X3RyYW5zbGF0aW9uX3R5cGUobGN0eHQsIENPTlRFWFRfVFRfUEFTU19USFJV
KTsKICAgICAgICAgYWdhdyA9IGxldmVsX3RvX2FnYXcoaW9tbXUtPm5yX3B0
X2xldmVscyk7CiAgICAgfQogICAgIGVsc2UKQEAgLTE0MzUsNiArMTQ2Myw4
IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICAgICAg
ICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsK
ICAgICAgICAgICAgICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOwog
ICAgICAgICAgICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShjb250ZXh0
X2VudHJpZXMpOworICAgICAgICAgICAgICAgIGlmICggcHJldl9kb20gKQor
ICAgICAgICAgICAgICAgICAgICByY3VfdW5sb2NrX2RvbWFpbihwcmV2X2Rv
bSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07CiAgICAgICAg
ICAgICB9CiAgICAgICAgIH0KQEAgLTE0NTIsMzMgKzE0ODIsMTAyIEBAIGlu
dCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICAgICAgICAgICAg
ICBnb3RvIG5vbWVtOwogICAgICAgICB9CiAKLSAgICAgICAgY29udGV4dF9z
ZXRfYWRkcmVzc19yb290KCpjb250ZXh0LCBwZ2RfbWFkZHIpOworICAgICAg
ICBjb250ZXh0X3NldF9hZGRyZXNzX3Jvb3QobGN0eHQsIHBnZF9tYWRkcik7
CiAgICAgICAgIGlmICggYXRzX2VuYWJsZWQgJiYgZWNhcF9kZXZfaW90bGIo
aW9tbXUtPmVjYXApICkKLSAgICAgICAgICAgIGNvbnRleHRfc2V0X3RyYW5z
bGF0aW9uX3R5cGUoKmNvbnRleHQsIENPTlRFWFRfVFRfREVWX0lPVExCKTsK
KyAgICAgICAgICAgIGNvbnRleHRfc2V0X3RyYW5zbGF0aW9uX3R5cGUobGN0
eHQsIENPTlRFWFRfVFRfREVWX0lPVExCKTsKICAgICAgICAgZWxzZQotICAg
ICAgICAgICAgY29udGV4dF9zZXRfdHJhbnNsYXRpb25fdHlwZSgqY29udGV4
dCwgQ09OVEVYVF9UVF9NVUxUSV9MRVZFTCk7CisgICAgICAgICAgICBjb250
ZXh0X3NldF90cmFuc2xhdGlvbl90eXBlKGxjdHh0LCBDT05URVhUX1RUX01V
TFRJX0xFVkVMKTsKIAogICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gu
bWFwcGluZ19sb2NrKTsKICAgICB9CiAKLSAgICBpZiAoIGNvbnRleHRfc2V0
X2RvbWFpbl9pZChjb250ZXh0LCBkb21haW4sIGlvbW11KSApCisgICAgcmMg
PSBjb250ZXh0X3NldF9kb21haW5faWQoJmxjdHh0LCBkb21haW4sIGlvbW11
KTsKKyAgICBpZiAoIHJjICkKICAgICB7CisgICAgdW5sb2NrOgogICAgICAg
ICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOwogICAgICAgICB1bm1hcF92
dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVzKTsKLSAgICAgICAgcmV0
dXJuIC1FRkFVTFQ7CisgICAgICAgIGlmICggcHJldl9kb20gKQorICAgICAg
ICAgICAgcmN1X3VubG9ja19kb21haW4ocHJldl9kb20pOworICAgICAgICBy
ZXR1cm4gcmM7CisgICAgfQorCisgICAgaWYgKCAhcHJldl9kb20gKQorICAg
IHsKKyAgICAgICAgY29udGV4dF9zZXRfYWRkcmVzc193aWR0aChsY3R4dCwg
YWdhdyk7CisgICAgICAgIGNvbnRleHRfc2V0X2ZhdWx0X2VuYWJsZShsY3R4
dCk7CisgICAgICAgIGNvbnRleHRfc2V0X3ByZXNlbnQobGN0eHQpOworICAg
IH0KKyAgICBlbHNlIGlmICggcHJldl9kb20gPT0gZG9tYWluICkKKyAgICB7
CisgICAgICAgIEFTU0VSVChsY3R4dC5mdWxsID09IGNvbnRleHQtPmZ1bGwp
OworICAgICAgICByYyA9ICEhcGRldjsKKyAgICAgICAgZ290byB1bmxvY2s7
CisgICAgfQorICAgIGVsc2UKKyAgICB7CisgICAgICAgIEFTU0VSVChjb250
ZXh0X2FkZHJlc3Nfd2lkdGgobGN0eHQpID09IGFnYXcpOworICAgICAgICBB
U1NFUlQoIWNvbnRleHRfZmF1bHRfZGlzYWJsZShsY3R4dCkpOworICAgIH0K
KworICAgIGlmICggY3B1X2hhc19jeDE2ICkKKyAgICB7CisgICAgICAgIF9f
dWludDEyOF90IHJlcyA9IGNtcHhjaGcxNmIoY29udGV4dCwgJm9sZCwgJmxj
dHh0LmZ1bGwpOworCisgICAgICAgIC8qCisgICAgICAgICAqIEhhcmR3YXJl
IGRvZXMgbm90IHVwZGF0ZSB0aGUgY29udGV4dCBlbnRyeSBiZWhpbmQgb3Vy
IGJhY2tzLAorICAgICAgICAgKiBzbyB0aGUgcmV0dXJuIHZhbHVlIHNob3Vs
ZCBtYXRjaCAib2xkIi4KKyAgICAgICAgICovCisgICAgICAgIGlmICggcmVz
ICE9IG9sZCApCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICggcGRldiAp
CisgICAgICAgICAgICAgICAgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAoZG9t
YWluLCBwZGV2LCBpb21tdSk7CisgICAgICAgICAgICBwcmludGsoWEVOTE9H
X0VSUgorICAgICAgICAgICAgICAgICAgICIlMDR4OiUwMng6JTAyeC4ldTog
dW5leHBlY3RlZCBjb250ZXh0IGVudHJ5ICUwMTZseF8lMDE2bHggKGV4cGVj
dGVkICUwMTZseF8lMDE2bHgpXG4iLAorICAgICAgICAgICAgICAgICAgIHBk
ZXYtPnNlZywgcGRldi0+YnVzLCBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5D
KGRldmZuKSwKKyAgICAgICAgICAgICAgICAgICAodWludDY0X3QpKHJlcyA+
PiA2NCksICh1aW50NjRfdClyZXMsCisgICAgICAgICAgICAgICAgICAgKHVp
bnQ2NF90KShvbGQgPj4gNjQpLCAodWludDY0X3Qpb2xkKTsKKyAgICAgICAg
ICAgIHJjID0gLUVJTFNFUTsKKyAgICAgICAgICAgIGdvdG8gdW5sb2NrOwor
ICAgICAgICB9CisgICAgfQorICAgIGVsc2UgaWYgKCAhcHJldl9kb20gfHwg
IShtb2RlICYgTUFQX1dJVEhfUk1SUikgKQorICAgIHsKKyAgICAgICAgY29u
dGV4dF9jbGVhcl9wcmVzZW50KCpjb250ZXh0KTsKKyAgICAgICAgaW9tbXVf
c3luY19jYWNoZShjb250ZXh0LCBzaXplb2YoKmNvbnRleHQpKTsKKworICAg
ICAgICB3cml0ZV9hdG9taWMoJmNvbnRleHQtPmhpLCBsY3R4dC5oaSk7Cisg
ICAgICAgIC8qIE5vIGJhcnJpZXIgc2hvdWxkIGJlIG5lZWRlZCBiZXR3ZWVu
IHRoZXNlIHR3by4gKi8KKyAgICAgICAgd3JpdGVfYXRvbWljKCZjb250ZXh0
LT5sbywgbGN0eHQubG8pOworICAgIH0KKyAgICBlbHNlIC8qIEJlc3QgZWZm
b3J0LCB1cGRhdGluZyBESUQgbGFzdC4gKi8KKyAgICB7CisgICAgICAgICAv
KgorICAgICAgICAgICogQnkgbm9uLWF0b21pY2FsbHkgdXBkYXRpbmcgdGhl
IGNvbnRleHQgZW50cnkncyBESUQgZmllbGQgbGFzdCwKKyAgICAgICAgICAq
IGR1cmluZyBhIHNob3J0IHdpbmRvdyBpbiB0aW1lIFRMQiBlbnRyaWVzIHdp
dGggdGhlIG9sZCBkb21haW4gSUQKKyAgICAgICAgICAqIGJ1dCB0aGUgbmV3
IHBhZ2UgdGFibGVzIG1heSBiZSBpbnNlcnRlZC4gIFRoaXMgY291bGQgYWZm
ZWN0IEkvTworICAgICAgICAgICogb2Ygb3RoZXIgZGV2aWNlcyB1c2luZyB0
aGlzIHNhbWUgKG9sZCkgZG9tYWluIElELiAgU3VjaCB1cGRhdGluZworICAg
ICAgICAgICogdGhlcmVmb3JlIGlzIG5vdCBhIHByb2JsZW0gaWYgdGhpcyB3
YXMgdGhlIG9ubHkgZGV2aWNlIGFzc29jaWF0ZWQKKyAgICAgICAgICAqIHdp
dGggdGhlIG9sZCBkb21haW4gSUQuICBEaXZlcnRpbmcgSS9PIG9mIGFueSBv
ZiBhIGR5aW5nIGRvbWFpbidzCisgICAgICAgICAgKiBkZXZpY2VzIHRvIHRo
ZSBxdWFyYW50aW5lIHBhZ2UgdGFibGVzIGlzIGludGVuZGVkIGFueXdheS4K
KyAgICAgICAgICAqLworICAgICAgICBpZiAoICEobW9kZSAmIChNQVBfT1dO
RVJfRFlJTkcgfCBNQVBfU0lOR0xFX0RFVklDRSkpICkKKyAgICAgICAgICAg
IHByaW50ayhYRU5MT0dfV0FSTklORyBWVERQUkVGSVgKKyAgICAgICAgICAg
ICAgICAgICAiICUwNHg6JTAyeDolMDJ4LiV1OiByZWFzc2lnbm1lbnQgbWF5
IGNhdXNlICVwZCBkYXRhIGNvcnJ1cHRpb25cbiIsCisgICAgICAgICAgICAg
ICAgICAgc2VnLCBidXMsIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2
Zm4pLCBwcmV2X2RvbSk7CisKKyAgICAgICAgd3JpdGVfYXRvbWljKCZjb250
ZXh0LT5sbywgbGN0eHQubG8pOworICAgICAgICAvKiBObyBiYXJyaWVyIHNo
b3VsZCBiZSBuZWVkZWQgYmV0d2VlbiB0aGVzZSB0d28uICovCisgICAgICAg
IHdyaXRlX2F0b21pYygmY29udGV4dC0+aGksIGxjdHh0LmhpKTsKICAgICB9
CiAKLSAgICBjb250ZXh0X3NldF9hZGRyZXNzX3dpZHRoKCpjb250ZXh0LCBh
Z2F3KTsKLSAgICBjb250ZXh0X3NldF9mYXVsdF9lbmFibGUoKmNvbnRleHQp
OwotICAgIGNvbnRleHRfc2V0X3ByZXNlbnQoKmNvbnRleHQpOwogICAgIGlv
bW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6ZW9mKHN0cnVjdCBjb250ZXh0
X2VudHJ5KSk7CiAgICAgc3Bpbl91bmxvY2soJmlvbW11LT5sb2NrKTsKIAot
ICAgIC8qIENvbnRleHQgZW50cnkgd2FzIHByZXZpb3VzbHkgbm9uLXByZXNl
bnQgKHdpdGggZG9taWQgMCkuICovCi0gICAgcmMgPSBpb21tdV9mbHVzaF9j
b250ZXh0X2RldmljZShpb21tdSwgMCwgUENJX0JERjIoYnVzLCBkZXZmbiks
Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBETUFfQ0NN
RF9NQVNLX05PQklULCAxKTsKKyAgICByYyA9IGlvbW11X2ZsdXNoX2NvbnRl
eHRfZGV2aWNlKGlvbW11LCBwcmV2X2RpZCwgUENJX0JERjIoYnVzLCBkZXZm
biksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBETUFf
Q0NNRF9NQVNLX05PQklULCAhcHJldl9kb20pOwogICAgIGZsdXNoX2Rldl9p
b3RsYiA9ICEhZmluZF9hdHNfZGV2X2RyaGQoaW9tbXUpOwotICAgIHJldCA9
IGlvbW11X2ZsdXNoX2lvdGxiX2RzaShpb21tdSwgMCwgMSwgZmx1c2hfZGV2
X2lvdGxiKTsKKyAgICByZXQgPSBpb21tdV9mbHVzaF9pb3RsYl9kc2koaW9t
bXUsIHByZXZfZGlkLCAhcHJldl9kb20sIGZsdXNoX2Rldl9pb3RsYik7CiAK
ICAgICAvKgogICAgICAqIFRoZSBjdXJyZW50IGxvZ2ljIGZvciByZXR1cm5z
OgpAQCAtMTQ5OSwxNyArMTU5OCwzNSBAQCBpbnQgZG9tYWluX2NvbnRleHRf
bWFwcGluZ19vbmUoCiAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRl
eHRfZW50cmllcyk7CiAKICAgICBpZiAoICFzZWcgJiYgIXJjICkKLSAgICAg
ICAgcmMgPSBtZV93aWZpX3F1aXJrKGRvbWFpbiwgYnVzLCBkZXZmbiwgTUFQ
X01FX1BIQU5UT01fRlVOQyk7CisgICAgICAgIHJjID0gbWVfd2lmaV9xdWly
ayhkb21haW4sIGJ1cywgZGV2Zm4sIG1vZGUpOwogCi0gICAgcmV0dXJuIHJj
OworICAgIGlmICggcmMgKQorICAgIHsKKyAgICAgICAgaWYgKCAhcHJldl9k
b20gKQorICAgICAgICAgICAgZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRv
bWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOworICAgICAgICBlbHNlIGlmICgg
cHJldl9kb20gIT0gZG9tYWluICkgLyogQXZvaWQgaW5maW5pdGUgcmVjdXJz
aW9uLiAqLworICAgICAgICAgICAgZG9tYWluX2NvbnRleHRfbWFwcGluZ19v
bmUocHJldl9kb20sIGlvbW11LCBidXMsIGRldmZuLCBwZGV2LAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbW9kZSAmIE1BUF9X
SVRIX1JNUlIpOworICAgIH0KKworICAgIGlmICggcHJldl9kb20gKQorICAg
ICAgICByY3VfdW5sb2NrX2RvbWFpbihwcmV2X2RvbSk7CisKKyAgICByZXR1
cm4gcmMgPzogcGRldiAmJiBwcmV2X2RvbTsKIH0KIAorc3RhdGljIGludCBk
b21haW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZG9tYWluICpkLCB1aW50OF90
IGRldmZuLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1
Y3QgcGNpX2RldiAqcGRldik7CisKIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkb21haW4sIHU4IGRldmZuLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lf
ZGV2ICpwZGV2KQogewogICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJo
ZDsKKyAgICBjb25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CiAg
ICAgaW50IHJldCA9IDA7Ci0gICAgdTggc2VnID0gcGRldi0+c2VnLCBidXMg
PSBwZGV2LT5idXMsIHNlY2J1czsKKyAgICB1bnNpZ25lZCBpbnQgaSwgbW9k
ZSA9IDA7CisgICAgdWludDE2X3Qgc2VnID0gcGRldi0+c2VnLCBiZGY7Cisg
ICAgdWludDhfdCBidXMgPSBwZGV2LT5idXMsIHNlY2J1czsKIAogICAgIGRy
aGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CiAgICAg
aWYgKCAhZHJoZCApCkBAIC0xNTE3LDggKzE2MzQsMzAgQEAgc3RhdGljIGlu
dCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogCiAgICAgQVNTRVJU
KHBjaWRldnNfbG9ja2VkKCkpOwogCisgICAgZm9yX2VhY2hfcm1ycl9kZXZp
Y2UoIHJtcnIsIGJkZiwgaSApCisgICAgeworICAgICAgICBpZiAoIHJtcnIt
PnNlZ21lbnQgIT0gcGRldi0+c2VnIHx8CisgICAgICAgICAgICAgYmRmICE9
IFBDSV9CREYyKHBkZXYtPmJ1cywgcGRldi0+ZGV2Zm4pICkKKyAgICAgICAg
ICAgIGNvbnRpbnVlOworCisgICAgICAgIG1vZGUgfD0gTUFQX1dJVEhfUk1S
UjsKKyAgICAgICAgYnJlYWs7CisgICAgfQorCisgICAgaWYgKCBkb21haW4g
IT0gcGRldi0+ZG9tYWluICkKKyAgICB7CisgICAgICAgIGlmICggcGRldi0+
ZG9tYWluLT5pc19keWluZyApCisgICAgICAgICAgICBtb2RlIHw9IE1BUF9P
V05FUl9EWUlORzsKKyAgICAgICAgZWxzZSBpZiAoIGRyaGQgJiYKKyAgICAg
ICAgICAgICAgICAgICFhbnlfcGRldl9iZWhpbmRfaW9tbXUocGRldi0+ZG9t
YWluLCBwZGV2LCBkcmhkLT5pb21tdSkgJiYKKyAgICAgICAgICAgICAgICAg
ICFwZGV2LT5waGFudG9tX3N0cmlkZSApCisgICAgICAgICAgICBtb2RlIHw9
IE1BUF9TSU5HTEVfREVWSUNFOworICAgIH0KKwogICAgIHN3aXRjaCAoIHBk
ZXYtPnR5cGUgKQogICAgIHsKKyAgICAgICAgYm9vbCBwcmV2X3ByZXNlbnQ7
CisKICAgICBjYXNlIERFVl9UWVBFX1BDSV9IT1NUX0JSSURHRToKICAgICAg
ICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAgICAgICBwcmludGsoVlRE
UFJFRklYICJkJWQ6SG9zdGJyaWRnZTogc2tpcCAlMDR4OiUwMng6JTAyeC4l
dSBtYXBcbiIsCkBAIC0xNTM5LDcgKzE2NzgsOSBAQCBzdGF0aWMgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAgICAgICAg
ICAgZG9tYWluLT5kb21haW5faWQsIHNlZywgYnVzLAogICAgICAgICAgICAg
ICAgICAgIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pKTsKICAg
ICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWlu
LCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgcGRldik7CisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIG1vZGUpOworICAg
ICAgICBpZiAoIHJldCA+IDAgKQorICAgICAgICAgICAgcmV0ID0gMDsKICAg
ICAgICAgaWYgKCAhcmV0ICYmIGRldmZuID09IHBkZXYtPmRldmZuICYmIGF0
c19kZXZpY2UocGRldiwgZHJoZCkgPiAwICkKICAgICAgICAgICAgIGVuYWJs
ZV9hdHNfZGV2aWNlKHBkZXYsICZkcmhkLT5pb21tdS0+YXRzX2RldmljZXMp
OwogCkBAIC0xNTUyLDIwICsxNjkzLDMzIEBAIHN0YXRpYyBpbnQgZG9tYWlu
X2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgICAgICAgICBQ
Q0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7CiAKICAgICAgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhk
LT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgcGRldik7Ci0gICAgICAgIGlmICggcmV0ICkK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRl
diwgbW9kZSk7CisgICAgICAgIGlmICggcmV0IDwgMCApCiAgICAgICAgICAg
ICBicmVhazsKKyAgICAgICAgcHJldl9wcmVzZW50ID0gcmV0OworICAgICAg
ICByZXQgPSAwOwogCiAgICAgICAgIGlmICggZmluZF91cHN0cmVhbV9icmlk
Z2Uoc2VnLCAmYnVzLCAmZGV2Zm4sICZzZWNidXMpIDwgMSApCiAgICAgICAg
ICAgICBicmVhazsKIAogICAgICAgICAvKgorICAgICAgICAgKiBTdHJpY3Rs
eSBzcGVha2luZyBpZiB0aGUgZGV2aWNlIGlzIHRoZSBvbmx5IG9uZSBiZWhp
bmQgdGhpcyBicmlkZ2UKKyAgICAgICAgICogYW5kIHRoZSBvbmx5IG9uZSB3
aXRoIHRoaXMgKHNlY2J1cywwLDApIHR1cGxlLCBpdCBjb3VsZCBiZSBhbGxv
d2VkCisgICAgICAgICAqIHRvIGJlIHJlLWFzc2lnbmVkIHJlZ2FyZGxlc3Mg
b2YgUk1SUiBwcmVzZW5jZS4gIEJ1dCBsZXQncyBkZWFsIHdpdGgKKyAgICAg
ICAgICogdGhhdCBjYXNlIG9ubHkgaWYgaXQgaXMgYWN0dWFsbHkgZm91bmQg
aW4gdGhlIHdpbGQuCisgICAgICAgICAqLworICAgICAgICBpZiAoIHByZXZf
cHJlc2VudCAmJiAobW9kZSAmIE1BUF9XSVRIX1JNUlIpICYmCisgICAgICAg
ICAgICAgZG9tYWluICE9IHBkZXYtPmRvbWFpbiApCisgICAgICAgICAgICBy
ZXQgPSAtRU9QTk9UU1VQUDsKKworICAgICAgICAvKgogICAgICAgICAgKiBN
YXBwaW5nIGEgYnJpZGdlIHNob3VsZCwgaWYgYW55dGhpbmcsIHBhc3MgdGhl
IHN0cnVjdCBwY2lfZGV2IG9mCiAgICAgICAgICAqIHRoYXQgYnJpZGdlLiBT
aW5jZSBicmlkZ2VzIGRvbid0IG5vcm1hbGx5IGdldCBhc3NpZ25lZCB0byBn
dWVzdHMsCiAgICAgICAgICAqIHRoZWlyIG93bmVyIHdvdWxkIGJlIHRoZSB3
cm9uZyBvbmUuIFBhc3MgTlVMTCBpbnN0ZWFkLgogICAgICAgICAgKi8KLSAg
ICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWlu
LCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCk7CisgICAgICAgIGlmICgg
cmV0ID49IDAgKQorICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRf
bWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IE5VTEwsIG1vZGUpOwogCiAgICAgICAgIC8qCiAgICAgICAgICAqIERldmlj
ZXMgYmVoaW5kIFBDSWUtdG8tUENJL1BDSXggYnJpZGdlIG1heSBnZW5lcmF0
ZSBkaWZmZXJlbnQKQEAgLTE1ODAsNyArMTczNCwxNSBAQCBzdGF0aWMgaW50
IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgIGlmICgg
IXJldCAmJiBwZGV2X3R5cGUoc2VnLCBidXMsIGRldmZuKSA9PSBERVZfVFlQ
RV9QQ0llMlBDSV9CUklER0UgJiYKICAgICAgICAgICAgICAoc2VjYnVzICE9
IHBkZXYtPmJ1cyB8fCBwZGV2LT5kZXZmbiAhPSAwKSApCiAgICAgICAgICAg
ICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRy
aGQtPmlvbW11LCBzZWNidXMsIDAsCi0gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBOVUxMKTsKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIG1vZGUpOwor
CisgICAgICAgIGlmICggcmV0ICkKKyAgICAgICAgeworICAgICAgICAgICAg
aWYgKCAhcHJldl9wcmVzZW50ICkKKyAgICAgICAgICAgICAgICBkb21haW5f
Y29udGV4dF91bm1hcChkb21haW4sIGRldmZuLCBwZGV2KTsKKyAgICAgICAg
ICAgIGVsc2UgaWYgKCBwZGV2LT5kb21haW4gIT0gZG9tYWluICkgLyogQXZv
aWQgaW5maW5pdGUgcmVjdXJzaW9uLiAqLworICAgICAgICAgICAgICAgIGRv
bWFpbl9jb250ZXh0X21hcHBpbmcocGRldi0+ZG9tYWluLCBkZXZmbiwgcGRl
dik7CisgICAgICAgIH0KIAogICAgICAgICBicmVhazsKIApAQCAtMjI5MSw5
ICsyNDUzLDggQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Vfb3duZXJz
aGlwKAogewogICAgIGludCByZXQ7CiAKLSAgICByZXQgPSBkb21haW5fY29u
dGV4dF91bm1hcChzb3VyY2UsIGRldmZuLCBwZGV2KTsKLSAgICBpZiAoIHJl
dCApCi0gICAgICAgIHJldHVybiByZXQ7CisgICAgaWYgKCAhaGFzX2FyY2hf
cGRldnModGFyZ2V0KSApCisgICAgICAgIHZteF9waV9ob29rc19hc3NpZ24o
dGFyZ2V0KTsKIAogICAgIC8qCiAgICAgICogRGV2aWNlcyBhc3NpZ25lZCB0
byB1bnRydXN0ZWQgZG9tYWlucyAoaGVyZSBhc3N1bWVkIHRvIGJlIGFueSBk
b21VKQpAQCAtMjMwMyw2ICsyNDY0LDMxIEBAIHN0YXRpYyBpbnQgcmVhc3Np
Z25fZGV2aWNlX293bmVyc2hpcCgKICAgICBpZiAoICh0YXJnZXQgIT0gaGFy
ZHdhcmVfZG9tYWluKSAmJiAhaW9tbXVfaW50cmVtYXAgKQogICAgICAgICB1
bnRydXN0ZWRfbXNpID0gdHJ1ZTsKIAorICAgIHJldCA9IGRvbWFpbl9jb250
ZXh0X21hcHBpbmcodGFyZ2V0LCBkZXZmbiwgcGRldik7CisgICAgaWYgKCBy
ZXQgKQorICAgIHsKKyAgICAgICAgaWYgKCAhaGFzX2FyY2hfcGRldnModGFy
Z2V0KSApCisgICAgICAgICAgICB2bXhfcGlfaG9va3NfZGVhc3NpZ24odGFy
Z2V0KTsKKyAgICAgICAgcmV0dXJuIHJldDsKKyAgICB9CisKKyAgICBpZiAo
IHBkZXYtPmRldmZuID09IGRldmZuICkKKyAgICB7CisgICAgICAgIGNvbnN0
IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZCA9IGFjcGlfZmluZF9tYXRj
aGVkX2RyaGRfdW5pdChwZGV2KTsKKworICAgICAgICBpZiAoIGRyaGQgKQor
ICAgICAgICAgICAgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAoc291cmNlLCBw
ZGV2LCBkcmhkLT5pb21tdSk7CisgICAgfQorCisgICAgaWYgKCBkZXZmbiA9
PSBwZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21haW4gIT0gdGFyZ2V0ICkKKyAg
ICB7CisgICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZ0
YXJnZXQtPmFyY2gucGRldl9saXN0KTsKKyAgICAgICAgcGRldi0+ZG9tYWlu
ID0gdGFyZ2V0OworICAgIH0KKworICAgIGlmICggIWhhc19hcmNoX3BkZXZz
KHNvdXJjZSkgKQorICAgICAgICB2bXhfcGlfaG9va3NfZGVhc3NpZ24oc291
cmNlKTsKKwogICAgIC8qCiAgICAgICogSWYgdGhlIGRldmljZSBiZWxvbmdz
IHRvIHRoZSBoYXJkd2FyZSBkb21haW4sIGFuZCBpdCBoYXMgUk1SUiwgZG9u
J3QKICAgICAgKiByZW1vdmUgaXQgZnJvbSB0aGUgaGFyZHdhcmUgZG9tYWlu
LCBiZWNhdXNlIEJJT1MgbWF5IHVzZSBSTVJSIGF0CkBAIC0yMzMxLDM0ICsy
NTE3LDcgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlw
KAogICAgICAgICAgICAgfQogICAgIH0KIAotICAgIGlmICggZGV2Zm4gPT0g
cGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWluICE9IGRvbV9pbyApCi0gICAg
ewotICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmZG9t
X2lvLT5hcmNoLnBkZXZfbGlzdCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9
IGRvbV9pbzsKLSAgICB9Ci0KLSAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyhz
b3VyY2UpICkKLSAgICAgICAgdm14X3BpX2hvb2tzX2RlYXNzaWduKHNvdXJj
ZSk7Ci0KLSAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyh0YXJnZXQpICkKLSAg
ICAgICAgdm14X3BpX2hvb2tzX2Fzc2lnbih0YXJnZXQpOwotCi0gICAgcmV0
ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZyh0YXJnZXQsIGRldmZuLCBwZGV2
KTsKLSAgICBpZiAoIHJldCApCi0gICAgewotICAgICAgICBpZiAoICFoYXNf
YXJjaF9wZGV2cyh0YXJnZXQpICkKLSAgICAgICAgICAgIHZteF9waV9ob29r
c19kZWFzc2lnbih0YXJnZXQpOwotCi0gICAgICAgIHJldHVybiByZXQ7Ci0g
ICAgfQotCi0gICAgaWYgKCBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBwZGV2
LT5kb21haW4gIT0gdGFyZ2V0ICkKLSAgICB7Ci0gICAgICAgIGxpc3RfbW92
ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZ0YXJnZXQtPmFyY2gucGRldl9saXN0
KTsKLSAgICAgICAgcGRldi0+ZG9tYWluID0gdGFyZ2V0OwotICAgIH0KLQot
ICAgIHJldHVybiByZXQ7CisgICAgcmV0dXJuIDA7CiB9CiAKIHN0YXRpYyBp
bnQgaW50ZWxfaW9tbXVfYXNzaWduX2RldmljZSgKLS0tIGEveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgKKysrIGIveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvdnRkL2lvbW11LmgKQEAgLTIwMSw4ICsyMDEsMTIgQEAg
c3RydWN0IHJvb3RfZW50cnkgewogICAgIGRvIHsocm9vdCkudmFsIHw9ICgo
dmFsdWUpICYgUEFHRV9NQVNLXzRLKTt9IHdoaWxlKDApCiAKIHN0cnVjdCBj
b250ZXh0X2VudHJ5IHsKLSAgICB1NjQgbG87Ci0gICAgdTY0IGhpOworICAg
IHVuaW9uIHsKKyAgICAgICAgc3RydWN0IHsKKyAgICAgICAgICAgIHVpbnQ2
NF90IGxvLCBoaTsKKyAgICAgICAgfTsKKyAgICAgICAgX191aW50MTI4X3Qg
ZnVsbDsKKyAgICB9OwogfTsKICNkZWZpbmUgUk9PVF9FTlRSWV9OUiAoUEFH
RV9TSVpFXzRLL3NpemVvZihzdHJ1Y3Qgcm9vdF9lbnRyeSkpCiAjZGVmaW5l
IGNvbnRleHRfcHJlc2VudChjKSAoKGMpLmxvICYgMSkKLS0tIGEveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvdnRkL3F1aXJrcy5jCisrKyBiL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xdWlya3MuYwpAQCAtMzMwLDcgKzMzMCw4
IEBAIHZvaWQgX19pbml0IHBsYXRmb3JtX3F1aXJrc19pbml0KHZvaWQpCiAg
Ki8KIAogc3RhdGljIGludCBfX211c3RfY2hlY2sgbWFwX21lX3BoYW50b21f
ZnVuY3Rpb24oc3RydWN0IGRvbWFpbiAqZG9tYWluLAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdTMyIGRldiwg
aW50IG1hcCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBkZXYsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp
bnQgbW9kZSkKIHsKICAgICBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQ7
CiAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXY7CkBAIC0zNDEsOSArMzQyLDkg
QEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgbWFwX21lX3BoYW50b21fZgog
ICAgIGRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7
CiAKICAgICAvKiBtYXAgb3IgdW5tYXAgTUUgcGhhbnRvbSBmdW5jdGlvbiAq
LwotICAgIGlmICggbWFwICkKKyAgICBpZiAoICEobW9kZSAmIFVOTUFQX01F
X1BIQU5UT01fRlVOQykgKQogICAgICAgICByYyA9IGRvbWFpbl9jb250ZXh0
X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIDAsCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJX0RFVkZOKGRl
diwgNyksIE5VTEwpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpLCBOVUxMLCBtb2RlKTsKICAg
ICBlbHNlCiAgICAgICAgIHJjID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KGRvbWFpbiwgZHJoZC0+aW9tbXUsIDAsCiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpKTsKQEAgLTM1
MSw3ICszNTIsOCBAQCBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBtYXBfbWVf
cGhhbnRvbV9mCiAgICAgcmV0dXJuIHJjOwogfQogCi1pbnQgbWVfd2lmaV9x
dWlyayhzdHJ1Y3QgZG9tYWluICpkb21haW4sIHU4IGJ1cywgdTggZGV2Zm4s
IGludCBtYXApCitpbnQgbWVfd2lmaV9xdWlyayhzdHJ1Y3QgZG9tYWluICpk
b21haW4sIHVpbnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLAorICAgICAgICAg
ICAgICAgICAgdW5zaWduZWQgaW50IG1vZGUpCiB7CiAgICAgdTMyIGlkOwog
ICAgIGludCByYyA9IDA7CkBAIC0zNzUsNyArMzc3LDcgQEAgaW50IG1lX3dp
ZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLAogICAgICAgICAgICAg
Y2FzZSAweDQyM2I4MDg2OgogICAgICAgICAgICAgY2FzZSAweDQyM2M4MDg2
OgogICAgICAgICAgICAgY2FzZSAweDQyM2Q4MDg2OgotICAgICAgICAgICAg
ICAgIHJjID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAzLCBt
YXApOworICAgICAgICAgICAgICAgIHJjID0gbWFwX21lX3BoYW50b21fZnVu
Y3Rpb24oZG9tYWluLCAzLCBtb2RlKTsKICAgICAgICAgICAgICAgICBicmVh
azsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgYnJl
YWs7CkBAIC00MDEsNyArNDAzLDcgQEAgaW50IG1lX3dpZmlfcXVpcmsoc3Ry
dWN0IGRvbWFpbiAqZG9tYWluLAogICAgICAgICAgICAgY2FzZSAweDQyMzg4
MDg2OiAgICAgICAgLyogUHVtYSBQZWFrICovCiAgICAgICAgICAgICBjYXNl
IDB4NDIyYjgwODY6CiAgICAgICAgICAgICBjYXNlIDB4NDIyYzgwODY6Ci0g
ICAgICAgICAgICAgICAgcmMgPSBtYXBfbWVfcGhhbnRvbV9mdW5jdGlvbihk
b21haW4sIDIyLCBtYXApOworICAgICAgICAgICAgICAgIHJjID0gbWFwX21l
X3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAyMiwgbW9kZSk7CiAgICAgICAg
ICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAg
ICAgICAgICAgIGJyZWFrOwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC92dGQvdnRkLmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L3Z0ZC5oCkBAIC0yMiw4ICsyMiwxNCBAQAogCiAjaW5jbHVkZSA8eGVuL2lv
bW11Lmg+CiAKLSNkZWZpbmUgTUFQX01FX1BIQU5UT01fRlVOQyAgICAgIDEK
LSNkZWZpbmUgVU5NQVBfTUVfUEhBTlRPTV9GVU5DICAgIDAKKy8qCisgKiBW
YWx1ZXMgZm9yIGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKCkncyBhbmQg
bWVfd2lmaV9xdWlyaygpJ3MgIm1vZGUiCisgKiBwYXJhbWV0ZXJzLgorICov
CisjZGVmaW5lIE1BUF9XSVRIX1JNUlIgICAgICAgICAoMXUgPDwgMCkKKyNk
ZWZpbmUgTUFQX09XTkVSX0RZSU5HICAgICAgICgxdSA8PCAxKQorI2RlZmlu
ZSBNQVBfU0lOR0xFX0RFVklDRSAgICAgKDF1IDw8IDIpCisjZGVmaW5lIFVO
TUFQX01FX1BIQU5UT01fRlVOQyAoMXUgPDwgMykKIAogLyogQWxsb3cgZm9y
IGJvdGggSU9BUElDIGFuZCBJT1NBUElDLiAqLwogI2RlZmluZSBJT194QVBJ
Q19yb3V0ZV9lbnRyeSBJT19BUElDX3JvdXRlX2VudHJ5Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-05.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IHJlLWFzc2lnbiBkZXZpY2VzIGRpcmVjdGx5CgpEZXZp
Y2VzIHdpdGggdW5pdHkgbWFwIHJhbmdlcywgZHVlIHRvIGl0IGJlaW5nIHVu
c3BlY2lmaWVkIGhvdy93aGVuCnRoZXNlIG1lbW9yeSByYW5nZXMgbWF5IGdl
dCBhY2Nlc3NlZCwgbWF5IG5vdCBiZSBsZWZ0IGRpc2Nvbm5lY3RlZCBmcm9t
CnRoZWlyIHVuaXR5IG1hcHBpbmdzIChhcyBsb25nIGFzIGl0J3Mgbm90IGNl
cnRhaW4gdGhhdCB0aGUgZGV2aWNlIGhhcwpiZWVuIGZ1bGx5IHF1aWVzY2Vk
KS4gSGVuY2UgcmF0aGVyIHRoYW4gdGVhcmluZyBkb3duIHRoZSBvbGQgcm9v
dCBwYWdlCnRhYmxlIHBvaW50ZXIgYW5kIHRoZW4gZXN0YWJsaXNoaW5nIHRo
ZSBuZXcgb25lLCByZS1hc3NpZ25tZW50IG5lZWRzIHRvCmJlIGRvbmUgaW4g
YSBzaW5nbGUgc3RlcC4KClRoaXMgaXMgQ1ZFLTIwMjItMjYzNjAgLyBwYXJ0
IG9mIFhTQS00MDAuCgpSZXBvcnRlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8
cm9nZXIucGF1QGNpdHJpeC5jb20+CgpTaW1pbGFybHkgcXVhcmFudGluaW5n
IHNjcmF0Y2gtcGFnZSBtb2RlIHJlbGllcyBvbiBwYWdlIHRhYmxlcyB0byBi
ZQpjb250aW51b3VzbHkgd2lyZWQgdXAuCgpUbyBhdm9pZCBjb21wbGljYXRp
bmcgdGhpbmdzIG1vcmUgdGhhbiBuZWNlc3NhcnksIHRyZWF0IGFsbCBkZXZp
Y2VzCm1vc3RseSBlcXVhbGx5LCBpLmUuIHJlZ2FyZGxlc3Mgb2YgdGhlaXIg
YXNzb2NpYXRpb24gd2l0aCBhbnkgdW5pdHkgbWFwCnJhbmdlcy4gIFRoZSBt
YWluIGRpZmZlcmVuY2UgaXMgd2hlbiBpdCBjb21lcyB0byB1cGRhdGluZyBE
VEVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21pYyB3aGVuIHRoZXJlIGFyZSB1
bml0eSBtYXBwaW5ncy4gWWV0IGF0b21pY2l0eSBjYW4gb25seSBiZQphY2hp
ZXZlZCB3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBvZiB3aGljaCB3
ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwg
RHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+CgotLS0gYS94ZW4vaW5j
bHVkZS9hc20teDg2L2h2bS9zdm0vYW1kLWlvbW11LXByb3RvLmgKKysrIGIv
eGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL2FtZC1pb21tdS1wcm90by5o
CkBAIC03OCw4ICs3OCwxMiBAQCB2b2lkIGFtZF9pb21tdV9zaGFyZV9wMm0o
c3RydWN0IGRvbWFpbiAqCiBpbnQgZ2V0X2RtYV9yZXF1ZXN0b3JfaWQodTE2
IHNlZywgdTE2IGJkZik7CiB2b2lkIGFtZF9pb21tdV9zZXRfaW50cmVtYXBf
dGFibGUoCiAgICAgdTMyICpkdGUsIHU2NCBpbnRyZW1hcF9wdHIsIHU4IGlu
dF92YWxpZCk7Ci12b2lkIGFtZF9pb21tdV9zZXRfcm9vdF9wYWdlX3RhYmxl
KAotICAgIHUzMiAqZHRlLCB1NjQgcm9vdF9wdHIsIHUxNiBkb21haW5faWQs
IHU4IHBhZ2luZ19tb2RlLCB1OCB2YWxpZCk7CisjZGVmaW5lIFNFVF9ST09U
X1ZBTElEICAgICAgICAgICgxdSA8PCAwKQorI2RlZmluZSBTRVRfUk9PVF9X
SVRIX1VOSVRZX01BUCAoMXUgPDwgMSkKK2ludCBfX211c3RfY2hlY2sgYW1k
X2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoCisgICAgdWludDMyX3QgKmR0
ZSwgdWludDY0X3Qgcm9vdF9wdHIsIHVpbnQxNl90IGRvbWFpbl9pZCwgdWlu
dDhfdCBwYWdpbmdfbW9kZSwKKyAgICB1bnNpZ25lZCBpbnQgZmxhZ3MpOwor
cGFkZHJfdCBhbWRfaW9tbXVfZ2V0X3Jvb3RfcGFnZV90YWJsZShjb25zdCB1
aW50MzJfdCAqZHRlKTsKIHZvaWQgaW9tbXVfZHRlX3NldF9pb3RsYih1MzIg
KmR0ZSwgdTggaSk7CiB2b2lkIGlvbW11X2R0ZV9hZGRfZGV2aWNlX2VudHJ5
KHUzMiAqZHRlLCBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19kZXYpOwog
dm9pZCBpb21tdV9kdGVfc2V0X2d1ZXN0X2NyMyh1MzIgKmR0ZSwgdTE2IGRv
bV9pZCwgdTY0IGdjcjMsCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L2FtZC9pb21tdV9tYXAuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC9hbWQvaW9tbXVfbWFwLmMKQEAgLTE1OCwxMiArMTU4LDEwNSBAQCBzdGF0
aWMgdW5zaWduZWQgaW50IHNldF9pb21tdV9wdGVfcHJlc2VuCiAgICAgcmV0
dXJuIGZsdXNoX2ZsYWdzOwogfQogCi12b2lkIGFtZF9pb21tdV9zZXRfcm9v
dF9wYWdlX3RhYmxlKHVpbnQzMl90ICpkdGUsIHVpbnQ2NF90IHJvb3RfcHRy
LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MTZf
dCBkb21haW5faWQsIHVpbnQ4X3QgcGFnaW5nX21vZGUsCi0gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgdmFsaWQpCisvKgor
ICogVGhpcyBmdW5jdGlvbiByZXR1cm5zCisgKiAtIC1lcnJubyBmb3IgZXJy
b3JzLAorICogLSAwIGZvciBhIHN1Y2Nlc3NmdWwgdXBkYXRlLCBhdG9taWMg
d2hlbiBuZWNlc3NhcnkKKyAqIC0gMSBmb3IgYSBzdWNjZXNzZnVsIGJ1dCBu
b24tYXRvbWljIHVwZGF0ZSwgd2hpY2ggbWF5IG5lZWQgdG8gYmUgd2FybmVk
CisgKiAgIGFib3V0IGJ5IHRoZSBjYWxsZXIuCisgKi8KK2ludCBhbWRfaW9t
bXVfc2V0X3Jvb3RfcGFnZV90YWJsZSh1aW50MzJfdCAqZHRlLCB1aW50NjRf
dCByb290X3B0ciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICB1aW50MTZfdCBkb21haW5faWQsIHVpbnQ4X3QgcGFnaW5nX21vZGUsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50
IGZsYWdzKQogeworICAgIGJvb2wgdmFsaWQgPSBmbGFncyAmIFNFVF9ST09U
X1ZBTElEOwogICAgIHVpbnQzMl90IGFkZHJfaGksIGFkZHJfbG8sIGVudHJ5
LCBkdGUwID0gZHRlWzBdOwogCisgICAgYWRkcl9sbyA9IHJvb3RfcHRyICYg
RE1BXzMyQklUX01BU0s7CisgICAgYWRkcl9oaSA9IHJvb3RfcHRyID4+IDMy
OworCisgICAgaWYgKCBnZXRfZmllbGRfZnJvbV9yZWdfdTMyKGR0ZTAsIElP
TU1VX0RFVl9UQUJMRV9WQUxJRF9NQVNLLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBJT01NVV9ERVZfVEFCTEVfVkFMSURfU0hJRlQpICYm
CisgICAgICAgICBnZXRfZmllbGRfZnJvbV9yZWdfdTMyKGR0ZTAsIElPTU1V
X0RFVl9UQUJMRV9UUkFOU0xBVElPTl9WQUxJRF9NQVNLLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBJT01NVV9ERVZfVEFCTEVfVFJBTlNM
QVRJT05fVkFMSURfU0hJRlQpICYmCisgICAgICAgICAoY3B1X2hhc19jeDE2
IHx8IChmbGFncyAmIFNFVF9ST09UX1dJVEhfVU5JVFlfTUFQKSkgKQorICAg
IHsKKyAgICAgICAgdW5pb24geworICAgICAgICAgICAgdWludDMyX3QgZHRl
WzRdOworICAgICAgICAgICAgdWludDY0X3QgcmF3NjRbMl07CisgICAgICAg
ICAgICBfX3VpbnQxMjhfdCByYXcxMjg7CisgICAgICAgIH0gbGR0ZTsKKyAg
ICAgICAgX191aW50MTI4X3Qgb2xkOworICAgICAgICBpbnQgcmV0ID0gMDsK
KworICAgICAgICBtZW1jcHkobGR0ZS5kdGUsIGR0ZSwgc2l6ZW9mKGxkdGUp
KTsKKyAgICAgICAgb2xkID0gbGR0ZS5yYXcxMjg7CisKKyAgICAgICAgc2V0
X2ZpZWxkX2luX3JlZ191MzIoZG9tYWluX2lkLCBsZHRlLmR0ZVsyXSwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVfREVWX1RBQkxFX0RP
TUFJTl9JRF9NQVNLLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJ
T01NVV9ERVZfVEFCTEVfRE9NQUlOX0lEX1NISUZULCAmbGR0ZS5kdGVbMl0p
OworCisgICAgICAgIHNldF9maWVsZF9pbl9yZWdfdTMyKGFkZHJfaGksIGxk
dGUuZHRlWzFdLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJT01N
VV9ERVZfVEFCTEVfUEFHRV9UQUJMRV9QVFJfSElHSF9NQVNLLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBJT01NVV9ERVZfVEFCTEVfUEFHRV9U
QUJMRV9QVFJfSElHSF9TSElGVCwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgJmxkdGUuZHRlWzFdKTsKKyAgICAgICAgc2V0X2ZpZWxkX2luX3Jl
Z191MzIoSU9NTVVfQ09OVFJPTF9FTkFCTEVELCBsZHRlLmR0ZVsxXSwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVfREVWX1RBQkxFX0lP
X1dSSVRFX1BFUk1JU1NJT05fTUFTSywKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgSU9NTVVfREVWX1RBQkxFX0lPX1dSSVRFX1BFUk1JU1NJT05f
U0hJRlQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZsZHRlLmR0
ZVsxXSk7CisgICAgICAgIHNldF9maWVsZF9pbl9yZWdfdTMyKElPTU1VX0NP
TlRST0xfRU5BQkxFRCwgbGR0ZS5kdGVbMV0sCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIElPTU1VX0RFVl9UQUJMRV9JT19SRUFEX1BFUk1JU1NJ
T05fTUFTSywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVf
REVWX1RBQkxFX0lPX1JFQURfUEVSTUlTU0lPTl9TSElGVCwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgJmxkdGUuZHRlWzFdKTsKKworICAgICAg
ICBzZXRfZmllbGRfaW5fcmVnX3UzMihhZGRyX2xvID4+IFBBR0VfU0hJRlQs
IGxkdGUuZHRlWzBdLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJ
T01NVV9ERVZfVEFCTEVfUEFHRV9UQUJMRV9QVFJfTE9XX01BU0ssCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1VX0RFVl9UQUJMRV9QQUdF
X1RBQkxFX1BUUl9MT1dfU0hJRlQsCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICZsZHRlLmR0ZVswXSk7CisgICAgICAgIHNldF9maWVsZF9pbl9y
ZWdfdTMyKHBhZ2luZ19tb2RlLCBsZHRlLmR0ZVswXSwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgSU9NTVVfREVWX1RBQkxFX1BBR0lOR19NT0RF
X01BU0ssCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1VX0RF
Vl9UQUJMRV9QQUdJTkdfTU9ERV9TSElGVCwgJmxkdGUuZHRlWzBdKTsKKyAg
ICAgICAgc2V0X2ZpZWxkX2luX3JlZ191MzIoSU9NTVVfQ09OVFJPTF9FTkFC
TEVELCBsZHRlLmR0ZVswXSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgSU9NTVVfREVWX1RBQkxFX1RSQU5TTEFUSU9OX1ZBTElEX01BU0ssCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1VX0RFVl9UQUJMRV9U
UkFOU0xBVElPTl9WQUxJRF9TSElGVCwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgJmxkdGUuZHRlWzBdKTsKKyAgICAgICAgc2V0X2ZpZWxkX2lu
X3JlZ191MzIodmFsaWQgPyBJT01NVV9DT05UUk9MX0VOQUJMRUQKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiBJT01NVV9DT05UUk9M
X0RJU0FCTEVELAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZHRl
LmR0ZVswXSwgSU9NTVVfREVWX1RBQkxFX1ZBTElEX01BU0ssCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIElPTU1VX0RFVl9UQUJMRV9WQUxJRF9T
SElGVCwgJmxkdGUuZHRlWzBdKTsKKworICAgICAgICBpZiAoIGNwdV9oYXNf
Y3gxNiApCisgICAgICAgIHsKKyAgICAgICAgICAgIF9fdWludDEyOF90IHJl
cyA9IGNtcHhjaGcxNmIoZHRlLCAmb2xkLCAmbGR0ZS5yYXcxMjgpOworCisg
ICAgICAgICAgICAvKgorICAgICAgICAgICAgICogSGFyZHdhcmUgZG9lcyBu
b3QgdXBkYXRlIHRoZSBEVEUgYmVoaW5kIG91ciBiYWNrcywgc28gdGhlCisg
ICAgICAgICAgICAgKiByZXR1cm4gdmFsdWUgc2hvdWxkIG1hdGNoICJvbGQi
LgorICAgICAgICAgICAgICovCisgICAgICAgICAgICBpZiAoIHJlcyAhPSBv
bGQgKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHByaW50ayhY
RU5MT0dfRVJSCisgICAgICAgICAgICAgICAgICAgICAgICJEb20lZDogdW5l
eHBlY3RlZCBEVEUgJTAxNmx4XyUwMTZseCAoZXhwZWN0ZWQgJTAxNmx4XyUw
MTZseClcbiIsCisgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbl9pZCwK
KyAgICAgICAgICAgICAgICAgICAgICAgKHVpbnQ2NF90KShyZXMgPj4gNjQp
LCAodWludDY0X3QpcmVzLAorICAgICAgICAgICAgICAgICAgICAgICAodWlu
dDY0X3QpKG9sZCA+PiA2NCksICh1aW50NjRfdClvbGQpOworICAgICAgICAg
ICAgICAgIHJldCA9IC1FSUxTRVE7CisgICAgICAgICAgICB9CisgICAgICAg
IH0KKyAgICAgICAgZWxzZSAvKiBCZXN0IGVmZm9ydCwgdXBkYXRpbmcgZG9t
YWluX2lkIGxhc3QuICovCisgICAgICAgIHsKKyAgICAgICAgICAgIHVpbnQ2
NF90ICpwdHIgPSAodm9pZCAqKWR0ZTsKKworICAgICAgICAgICAgd3JpdGVf
YXRvbWljKHB0ciArIDAsIGxkdGUucmF3NjRbMF0pOworICAgICAgICAgICAg
LyogTm8gYmFycmllciBzaG91bGQgYmUgbmVlZGVkIGJldHdlZW4gdGhlc2Ug
dHdvLiAqLworICAgICAgICAgICAgd3JpdGVfYXRvbWljKHB0ciArIDEsIGxk
dGUucmF3NjRbMV0pOworCisgICAgICAgICAgICByZXQgPSAxOworICAgICAg
ICB9CisKKyAgICAgICAgcmV0dXJuIHJldDsKKyAgICB9CisKICAgICBpZiAo
IHZhbGlkIHx8CiAgICAgICAgICBnZXRfZmllbGRfZnJvbV9yZWdfdTMyKGR0
ZTAsIElPTU1VX0RFVl9UQUJMRV9WQUxJRF9NQVNLLAogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBJT01NVV9ERVZfVEFCTEVfVkFMSURfU0hJ
RlQpICkKQEAgLTE4Myw5ICsyNzYsNiBAQCB2b2lkIGFtZF9pb21tdV9zZXRf
cm9vdF9wYWdlX3RhYmxlKHVpbnQzCiAgICAgICAgICAgICAgICAgICAgICAg
ICAgSU9NTVVfREVWX1RBQkxFX0RPTUFJTl9JRF9TSElGVCwgJmVudHJ5KTsK
ICAgICBkdGVbMl0gPSBlbnRyeTsKIAotICAgIGFkZHJfbG8gPSByb290X3B0
ciAmIERNQV8zMkJJVF9NQVNLOwotICAgIGFkZHJfaGkgPSByb290X3B0ciA+
PiAzMjsKLQogICAgIHNldF9maWVsZF9pbl9yZWdfdTMyKGFkZHJfaGksIDAs
CiAgICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVfREVWX1RBQkxFX1BB
R0VfVEFCTEVfUFRSX0hJR0hfTUFTSywKICAgICAgICAgICAgICAgICAgICAg
ICAgICBJT01NVV9ERVZfVEFCTEVfUEFHRV9UQUJMRV9QVFJfSElHSF9TSElG
VCwgJmVudHJ5KTsKQEAgLTIxMiw2ICszMDIsMjAgQEAgdm9pZCBhbWRfaW9t
bXVfc2V0X3Jvb3RfcGFnZV90YWJsZSh1aW50MwogICAgICAgICAgICAgICAg
ICAgICAgICAgIElPTU1VX0RFVl9UQUJMRV9WQUxJRF9NQVNLLAogICAgICAg
ICAgICAgICAgICAgICAgICAgIElPTU1VX0RFVl9UQUJMRV9WQUxJRF9TSElG
VCwgJmVudHJ5KTsKICAgICB3cml0ZV9hdG9taWMoJmR0ZVswXSwgZW50cnkp
OworCisgICAgcmV0dXJuIDA7Cit9CisKK3BhZGRyX3QgYW1kX2lvbW11X2dl
dF9yb290X3BhZ2VfdGFibGUoY29uc3QgdWludDMyX3QgKmR0ZSkKK3sKKyAg
ICB1aW50MzJfdCBsbyA9IGdldF9maWVsZF9mcm9tX3JlZ191MzIoCisgICAg
ICAgICAgICAgICAgICAgICAgZHRlWzBdLCBJT01NVV9ERVZfVEFCTEVfUEFH
RV9UQUJMRV9QVFJfTE9XX01BU0ssCisgICAgICAgICAgICAgICAgICAgICAg
SU9NTVVfREVWX1RBQkxFX1BBR0VfVEFCTEVfUFRSX0xPV19TSElGVCk7Cisg
ICAgdWludDMyX3QgaGkgPSBnZXRfZmllbGRfZnJvbV9yZWdfdTMyKAorICAg
ICAgICAgICAgICAgICAgICAgIGR0ZVsxXSwgSU9NTVVfREVWX1RBQkxFX1BB
R0VfVEFCTEVfUFRSX0hJR0hfTUFTSywKKyAgICAgICAgICAgICAgICAgICAg
ICBJT01NVV9ERVZfVEFCTEVfUEFHRV9UQUJMRV9QVFJfSElHSF9TSElGVCk7
CisKKyAgICByZXR1cm4gKChwYWRkcl90KWhpIDw8IDMyKSB8IChsbyA8PCBQ
QUdFX1NISUZUKTsKIH0KIAogdm9pZCBpb21tdV9kdGVfc2V0X2lvdGxiKHVp
bnQzMl90ICpkdGUsIHVpbnQ4X3QgaSkKLS0tIGEveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0xMDksMjIg
KzEwOSw2MCBAQCBzdGF0aWMgdm9pZCBkaXNhYmxlX3RyYW5zbGF0aW9uKHUz
MiAqZHRlCiAgICAgZHRlWzBdID0gZW50cnk7CiB9CiAKLXN0YXRpYyB2b2lk
IGFtZF9pb21tdV9zZXR1cF9kb21haW5fZGV2aWNlKAorc3RhdGljIGludCBf
X211c3RfY2hlY2sgYWxsb2NhdGVfZG9tYWluX3Jlc291cmNlcyhzdHJ1Y3Qg
ZG9tYWluX2lvbW11ICpoZCkKK3sKKyAgICBpbnQgcmM7CisKKyAgICBzcGlu
X2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CisgICAgcmMgPSBhbWRf
aW9tbXVfYWxsb2Nfcm9vdChoZCk7CisgICAgc3Bpbl91bmxvY2soJmhkLT5h
cmNoLm1hcHBpbmdfbG9jayk7CisKKyAgICByZXR1cm4gcmM7Cit9CisKK3N0
YXRpYyBib29sIGFueV9wZGV2X2JlaGluZF9pb21tdShjb25zdCBzdHJ1Y3Qg
ZG9tYWluICpkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpleGNsdWRlLAorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBhbWRfaW9tbXUg
KmlvbW11KQoreworICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2Owor
CisgICAgZm9yX2VhY2hfcGRldiAoIGQsIHBkZXYgKQorICAgIHsKKyAgICAg
ICAgaWYgKCBwZGV2ID09IGV4Y2x1ZGUgKQorICAgICAgICAgICAgY29udGlu
dWU7CisKKyAgICAgICAgaWYgKCBmaW5kX2lvbW11X2Zvcl9kZXZpY2UocGRl
di0+c2VnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQ
Q0lfQkRGMihwZGV2LT5idXMsIHBkZXYtPmRldmZuKSkgPT0gaW9tbXUgKQor
ICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorCisgICAgcmV0dXJu
IGZhbHNlOworfQorCitzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBhbWRfaW9t
bXVfc2V0dXBfZG9tYWluX2RldmljZSgKICAgICBzdHJ1Y3QgZG9tYWluICpk
b21haW4sIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LAogICAgIHU4IGRldmZu
LCBzdHJ1Y3QgcGNpX2RldiAqcGRldikKIHsKLSAgICB2b2lkICpkdGU7Cisg
ICAgdWludDMyX3QgKmR0ZTsKICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwot
ICAgIGludCByZXFfaWQsIHZhbGlkID0gMTsKLSAgICBpbnQgZHRlX2kgPSAw
OworICAgIHVuc2lnbmVkIGludCByZXFfaWQsIHNyX2ZsYWdzOworICAgIGlu
dCBkdGVfaSA9IDAsIHJjOwogICAgIHU4IGJ1cyA9IHBkZXYtPmJ1czsKLSAg
ICBjb25zdCBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShk
b21haW4pOworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lv
bW11KGRvbWFpbik7CisgICAgY29uc3Qgc3RydWN0IGl2cnNfbWFwcGluZ3Mg
Kml2cnNfZGV2OworCisgICAgQlVHX09OKCFoZC0+YXJjaC5wYWdpbmdfbW9k
ZSB8fCAhaW9tbXUtPmRldl90YWJsZS5idWZmZXIpOwogCi0gICAgQlVHX09O
KCAhaGQtPmFyY2gucm9vdF90YWJsZSB8fCAhaGQtPmFyY2gucGFnaW5nX21v
ZGUgfHwKLSAgICAgICAgICAgICFpb21tdS0+ZGV2X3RhYmxlLmJ1ZmZlciAp
OworICAgIHJjID0gYWxsb2NhdGVfZG9tYWluX3Jlc291cmNlcyhoZCk7Cisg
ICAgaWYgKCByYyApCisgICAgICAgIHJldHVybiByYzsKIAotICAgIGlmICgg
aW9tbXVfaHdkb21fcGFzc3Rocm91Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWlu
KGRvbWFpbikgKQotICAgICAgICB2YWxpZCA9IDA7CisgICAgcmVxX2lkID0g
Z2V0X2RtYV9yZXF1ZXN0b3JfaWQoaW9tbXUtPnNlZywKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBQQ0lfQkRGMihwZGV2LT5idXMsIHBk
ZXYtPmRldmZuKSk7CisgICAgaXZyc19kZXYgPSAmZ2V0X2l2cnNfbWFwcGlu
Z3MoaW9tbXUtPnNlZylbcmVxX2lkXTsKKyAgICBzcl9mbGFncyA9IChpb21t
dV9od2RvbV9wYXNzdGhyb3VnaCAmJiBpc19oYXJkd2FyZV9kb21haW4oZG9t
YWluKQorICAgICAgICAgICAgICAgID8gMCA6IFNFVF9ST09UX1ZBTElEKQor
ICAgICAgICAgICAgICAgfCAoaXZyc19kZXYtPnVuaXR5X21hcCA/IFNFVF9S
T09UX1dJVEhfVU5JVFlfTUFQIDogMCk7CiAKICAgICBpZiAoIGF0c19lbmFi
bGVkICkKICAgICAgICAgZHRlX2kgPSAxOwpAQCAtMTMyLDMyICsxNzAsODcg
QEAgc3RhdGljIHZvaWQgYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpYwog
ICAgIC8qIGdldCBkZXZpY2UtdGFibGUgZW50cnkgKi8KICAgICByZXFfaWQg
PSBnZXRfZG1hX3JlcXVlc3Rvcl9pZChpb21tdS0+c2VnLCBQQ0lfQkRGMihi
dXMsIGRldmZuKSk7CiAgICAgZHRlID0gaW9tbXUtPmRldl90YWJsZS5idWZm
ZXIgKyAocmVxX2lkICogSU9NTVVfREVWX1RBQkxFX0VOVFJZX1NJWkUpOwor
ICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21hcHBpbmdzKGlvbW11LT5zZWcp
W3JlcV9pZF07CiAKICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmaW9tbXUtPmxv
Y2ssIGZsYWdzKTsKIAogICAgIGlmICggIWlzX3RyYW5zbGF0aW9uX3ZhbGlk
KCh1MzIgKilkdGUpICkKICAgICB7CiAgICAgICAgIC8qIGJpbmQgRFRFIHRv
IGRvbWFpbiBwYWdlLXRhYmxlcyAqLwotICAgICAgICBhbWRfaW9tbXVfc2V0
X3Jvb3RfcGFnZV90YWJsZSgKLSAgICAgICAgICAgICh1MzIgKilkdGUsIHBh
Z2VfdG9fbWFkZHIoaGQtPmFyY2gucm9vdF90YWJsZSksIGRvbWFpbi0+ZG9t
YWluX2lkLAotICAgICAgICAgICAgaGQtPmFyY2gucGFnaW5nX21vZGUsIHZh
bGlkKTsKKyAgICAgICAgcmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90
YWJsZSgKKyAgICAgICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRyKGhk
LT5hcmNoLnJvb3RfdGFibGUpLAorICAgICAgICAgICAgICAgICBkb21haW4t
PmRvbWFpbl9pZCwgaGQtPmFyY2gucGFnaW5nX21vZGUsIHNyX2ZsYWdzKTsK
KyAgICAgICAgaWYgKCByYyApCisgICAgICAgIHsKKyAgICAgICAgICAgIEFT
U0VSVChyYyA8IDApOworICAgICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVz
dG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKKyAgICAgICAgICAgIHJldHVy
biByYzsKKyAgICAgICAgfQogCiAgICAgICAgIGlmICggcGNpX2F0c19kZXZp
Y2UoaW9tbXUtPnNlZywgYnVzLCBwZGV2LT5kZXZmbikgJiYKICAgICAgICAg
ICAgICBpb21tdV9oYXNfY2FwKGlvbW11LCBQQ0lfQ0FQX0lPVExCX1NISUZU
KSApCiAgICAgICAgICAgICBpb21tdV9kdGVfc2V0X2lvdGxiKCh1MzIgKilk
dGUsIGR0ZV9pKTsKIAogICAgICAgICBhbWRfaW9tbXVfZmx1c2hfZGV2aWNl
KGlvbW11LCByZXFfaWQpOworICAgIH0KKyAgICBlbHNlIGlmICggYW1kX2lv
bW11X2dldF9yb290X3BhZ2VfdGFibGUoZHRlKSAhPQorICAgICAgICAgICAg
ICBwYWdlX3RvX21hZGRyKGhkLT5hcmNoLnJvb3RfdGFibGUpICkKKyAgICB7
CisgICAgICAgIC8qCisgICAgICAgICAqIFN0cmljdGx5IHNwZWFraW5nIGlm
IHRoZSBkZXZpY2UgaXMgdGhlIG9ubHkgb25lIHdpdGggdGhpcyByZXF1ZXN0
b3IKKyAgICAgICAgICogSUQsIGl0IGNvdWxkIGJlIGFsbG93ZWQgdG8gYmUg
cmUtYXNzaWduZWQgcmVnYXJkbGVzcyBvZiB1bml0eSBtYXAKKyAgICAgICAg
ICogcHJlc2VuY2UuICBCdXQgbGV0J3MgZGVhbCB3aXRoIHRoYXQgY2FzZSBv
bmx5IGlmIGl0IGlzIGFjdHVhbGx5CisgICAgICAgICAqIGZvdW5kIGluIHRo
ZSB3aWxkLgorICAgICAgICAgKi8KKyAgICAgICAgaWYgKCByZXFfaWQgIT0g
UENJX0JERjIoYnVzLCBkZXZmbikgJiYKKyAgICAgICAgICAgICAoc3JfZmxh
Z3MgJiBTRVRfUk9PVF9XSVRIX1VOSVRZX01BUCkgKQorICAgICAgICAgICAg
cmMgPSAtRU9QTk9UU1VQUDsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAg
cmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZSgKKyAgICAgICAg
ICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkcihoZC0+YXJjaC5yb290
X3RhYmxlKSwKKyAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWlu
X2lkLCBoZC0+YXJjaC5wYWdpbmdfbW9kZSwgc3JfZmxhZ3MpOworICAgICAg
ICBpZiAoIHJjIDwgMCApCisgICAgICAgIHsKKyAgICAgICAgICAgIHNwaW5f
dW5sb2NrX2lycXJlc3RvcmUoJmlvbW11LT5sb2NrLCBmbGFncyk7CisgICAg
ICAgICAgICByZXR1cm4gcmM7CisgICAgICAgIH0KKyAgICAgICAgaWYgKCBy
YyAmJgorICAgICAgICAgICAgIGRvbWFpbiAhPSBwZGV2LT5kb21haW4gJiYK
KyAgICAgICAgICAgICAvKgorICAgICAgICAgICAgICAqIEJ5IG5vbi1hdG9t
aWNhbGx5IHVwZGF0aW5nIHRoZSBEVEUncyBkb21haW4gSUQgZmllbGQgbGFz
dCwKKyAgICAgICAgICAgICAgKiBkdXJpbmcgYSBzaG9ydCB3aW5kb3cgaW4g
dGltZSBUTEIgZW50cmllcyB3aXRoIHRoZSBvbGQgZG9tYWluCisgICAgICAg
ICAgICAgICogSUQgYnV0IHRoZSBuZXcgcGFnZSB0YWJsZXMgbWF5IGhhdmUg
YmVlbiBpbnNlcnRlZC4gIFRoaXMgY291bGQKKyAgICAgICAgICAgICAgKiBh
ZmZlY3QgSS9PIG9mIG90aGVyIGRldmljZXMgdXNpbmcgdGhpcyBzYW1lIChv
bGQpIGRvbWFpbiBJRC4KKyAgICAgICAgICAgICAgKiBTdWNoIHVwZGF0aW5n
IHRoZXJlZm9yZSBpcyBub3QgYSBwcm9ibGVtIGlmIHRoaXMgd2FzIHRoZSBv
bmx5CisgICAgICAgICAgICAgICogZGV2aWNlIGFzc29jaWF0ZWQgd2l0aCB0
aGUgb2xkIGRvbWFpbiBJRC4gIERpdmVydGluZyBJL08gb2YgYW55CisgICAg
ICAgICAgICAgICogb2YgYSBkeWluZyBkb21haW4ncyBkZXZpY2VzIHRvIHRo
ZSBxdWFyYW50aW5lIHBhZ2UgdGFibGVzIGlzCisgICAgICAgICAgICAgICog
aW50ZW5kZWQgYW55d2F5LgorICAgICAgICAgICAgICAqLworICAgICAgICAg
ICAgICFwZGV2LT5kb21haW4tPmlzX2R5aW5nICYmCisgICAgICAgICAgICAg
KGFueV9wZGV2X2JlaGluZF9pb21tdShwZGV2LT5kb21haW4sIHBkZXYsIGlv
bW11KSB8fAorICAgICAgICAgICAgICBwZGV2LT5waGFudG9tX3N0cmlkZSkg
KQorICAgICAgICAgICAgcHJpbnRrKCIgJTA0eDolMDJ4OiUwMnguJXU6IHJl
YXNzaWdubWVudCBtYXkgY2F1c2UgJXBkIGRhdGEgY29ycnVwdGlvblxuIiwK
KyAgICAgICAgICAgICAgICAgICBwZGV2LT5zZWcsIGJ1cywgUENJX1NMT1Qo
ZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksCisgICAgICAgICAgICAgICAgICAg
cGRldi0+ZG9tYWluKTsKIAotICAgICAgICBBTURfSU9NTVVfREVCVUcoIlNl
dHVwIEkvTyBwYWdlIHRhYmxlOiBkZXZpY2UgaWQgPSAlI3gsIHR5cGUgPSAl
I3gsICIKLSAgICAgICAgICAgICAgICAgICAgICAgICJyb290IHRhYmxlID0g
JSMiUFJJeDY0IiwgIgotICAgICAgICAgICAgICAgICAgICAgICAgImRvbWFp
biA9ICVkLCBwYWdpbmcgbW9kZSA9ICVkXG4iLAotICAgICAgICAgICAgICAg
ICAgICAgICAgcmVxX2lkLCBwZGV2LT50eXBlLAotICAgICAgICAgICAgICAg
ICAgICAgICAgcGFnZV90b19tYWRkcihoZC0+YXJjaC5yb290X3RhYmxlKSwK
LSAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBo
ZC0+YXJjaC5wYWdpbmdfbW9kZSk7CisgICAgICAgIGlmICggcGNpX2F0c19k
ZXZpY2UoaW9tbXUtPnNlZywgYnVzLCBwZGV2LT5kZXZmbikgJiYKKyAgICAg
ICAgICAgICBpb21tdV9oYXNfY2FwKGlvbW11LCBQQ0lfQ0FQX0lPVExCX1NI
SUZUKSApCisgICAgICAgICAgICBBU1NFUlQoZ2V0X2ZpZWxkX2Zyb21fcmVn
X3UzMigKKyAgICAgICAgICAgICAgICAgICAgICAgZHRlWzNdLCBJT01NVV9E
RVZfVEFCTEVfSU9UTEJfU1VQUE9SVF9NQVNLLAorICAgICAgICAgICAgICAg
ICAgICAgICBJT01NVV9ERVZfVEFCTEVfSU9UTEJfU1VQUE9SVF9TSElGVCkg
PT0gZHRlX2kpOworCisgICAgICAgIGFtZF9pb21tdV9mbHVzaF9kZXZpY2Uo
aW9tbXUsIHJlcV9pZCk7CiAgICAgfQogCiAgICAgc3Bpbl91bmxvY2tfaXJx
cmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKIAorICAgIEFNRF9JT01N
VV9ERUJVRygiU2V0dXAgSS9PIHBhZ2UgdGFibGU6IGRldmljZSBpZCA9ICUj
eCwgdHlwZSA9ICUjeCwgIgorICAgICAgICAgICAgICAgICAgICAicm9vdCB0
YWJsZSA9ICUjIlBSSXg2NCIsICIKKyAgICAgICAgICAgICAgICAgICAgImRv
bWFpbiA9ICVkLCBwYWdpbmcgbW9kZSA9ICVkXG4iLAorICAgICAgICAgICAg
ICAgICAgICByZXFfaWQsIHBkZXYtPnR5cGUsCisgICAgICAgICAgICAgICAg
ICAgIHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2gucm9vdF90YWJsZSksCisgICAg
ICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBoZC0+YXJjaC5w
YWdpbmdfbW9kZSk7CisKICAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7
CiAKICAgICBpZiAoIHBjaV9hdHNfZGV2aWNlKGlvbW11LT5zZWcsIGJ1cywg
cGRldi0+ZGV2Zm4pICYmCkBAIC0xNjgsNiArMjYxLDggQEAgc3RhdGljIHZv
aWQgYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpYwogCiAgICAgICAgIGFt
ZF9pb21tdV9mbHVzaF9pb3RsYihkZXZmbiwgcGRldiwgSU5WX0lPTU1VX0FM
TF9QQUdFU19BRERSRVNTLCAwKTsKICAgICB9CisKKyAgICByZXR1cm4gMDsK
IH0KIAogaW50IF9faW5pdCBhbWRfaW92X2RldGVjdCh2b2lkKQpAQCAtMjEx
LDE3ICszMDYsNiBAQCBpbnQgYW1kX2lvbW11X2FsbG9jX3Jvb3Qoc3RydWN0
IGRvbWFpbl9pCiAgICAgcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgX19t
dXN0X2NoZWNrIGFsbG9jYXRlX2RvbWFpbl9yZXNvdXJjZXMoc3RydWN0IGRv
bWFpbl9pb21tdSAqaGQpCi17Ci0gICAgaW50IHJjOwotCi0gICAgc3Bpbl9s
b2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwotICAgIHJjID0gYW1kX2lv
bW11X2FsbG9jX3Jvb3QoaGQpOwotICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJj
aC5tYXBwaW5nX2xvY2spOwotCi0gICAgcmV0dXJuIHJjOwotfQotCiBpbnQg
X19yZWFkX21vc3RseSBhbWRfaW9tbXVfbWluX3BhZ2luZ19tb2RlID0gMTsK
IAogc3RhdGljIGludCBhbWRfaW9tbXVfZG9tYWluX2luaXQoc3RydWN0IGRv
bWFpbiAqZCkKQEAgLTMxMCw3ICszOTQsNiBAQCBzdGF0aWMgaW50IHJlYXNz
aWduX2RldmljZShzdHJ1Y3QgZG9tYWluCiB7CiAgICAgc3RydWN0IGFtZF9p
b21tdSAqaW9tbXU7CiAgICAgaW50IGJkZiwgcmM7Ci0gICAgc3RydWN0IGRv
bWFpbl9pb21tdSAqdCA9IGRvbV9pb21tdSh0YXJnZXQpOwogICAgIGNvbnN0
IHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX21hcHBpbmdzID0gZ2V0X2l2
cnNfbWFwcGluZ3MocGRldi0+c2VnKTsKIAogICAgIGJkZiA9IFBDSV9CREYy
KHBkZXYtPmJ1cywgcGRldi0+ZGV2Zm4pOwpAQCAtMzI0LDcgKzQwNywxNSBA
QCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluCiAg
ICAgICAgIHJldHVybiAtRU5PREVWOwogICAgIH0KIAotICAgIGFtZF9pb21t
dV9kaXNhYmxlX2RvbWFpbl9kZXZpY2Uoc291cmNlLCBpb21tdSwgZGV2Zm4s
IHBkZXYpOworICAgIHJjID0gYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZp
Y2UodGFyZ2V0LCBpb21tdSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmMg
KQorICAgICAgICByZXR1cm4gcmM7CisKKyAgICBpZiAoIGRldmZuID09IHBk
ZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSB0YXJnZXQgKQorICAgIHsK
KyAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlzdCwgJnRhcmdl
dC0+YXJjaC5wZGV2X2xpc3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSB0
YXJnZXQ7CisgICAgfQogCiAgICAgLyoKICAgICAgKiBJZiB0aGUgZGV2aWNl
IGJlbG9uZ3MgdG8gdGhlIGhhcmR3YXJlIGRvbWFpbiwgYW5kIGl0IGhhcyBh
IHVuaXR5IG1hcHBpbmcsCkBAIC0zNDAsMjcgKzQzMSwxMCBAQCBzdGF0aWMg
aW50IHJlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluCiAgICAgICAgICAg
ICByZXR1cm4gcmM7CiAgICAgfQogCi0gICAgaWYgKCBkZXZmbiA9PSBwZGV2
LT5kZXZmbiAmJiBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkKLSAgICB7Ci0g
ICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZkb21faW8t
PmFyY2gucGRldl9saXN0KTsKLSAgICAgICAgcGRldi0+ZG9tYWluID0gZG9t
X2lvOwotICAgIH0KLQotICAgIHJjID0gYWxsb2NhdGVfZG9tYWluX3Jlc291
cmNlcyh0KTsKLSAgICBpZiAoIHJjICkKLSAgICAgICAgcmV0dXJuIHJjOwot
Ci0gICAgYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2UodGFyZ2V0LCBp
b21tdSwgZGV2Zm4sIHBkZXYpOwogICAgIEFNRF9JT01NVV9ERUJVRygiUmUt
YXNzaWduICUwNHg6JTAyeDolMDJ4LiV1IGZyb20gZG9tJWQgdG8gZG9tJWRc
biIsCiAgICAgICAgICAgICAgICAgICAgIHBkZXYtPnNlZywgcGRldi0+YnVz
LCBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSwKICAgICAgICAg
ICAgICAgICAgICAgc291cmNlLT5kb21haW5faWQsIHRhcmdldC0+ZG9tYWlu
X2lkKTsKIAotICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRl
di0+ZG9tYWluICE9IHRhcmdldCApCi0gICAgewotICAgICAgICBsaXN0X21v
dmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFyZ2V0LT5hcmNoLnBkZXZfbGlz
dCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9IHRhcmdldDsKLSAgICB9Ci0K
ICAgICByZXR1cm4gMDsKIH0KIApAQCAtNDkxLDggKzU2NSw3IEBAIHN0YXRp
YyBpbnQgYW1kX2lvbW11X2FkZF9kZXZpY2UodTggZGV2Zm4KICAgICAgICAg
cmV0dXJuIC1FTk9ERVY7CiAgICAgfQogCi0gICAgYW1kX2lvbW11X3NldHVw
X2RvbWFpbl9kZXZpY2UocGRldi0+ZG9tYWluLCBpb21tdSwgZGV2Zm4sIHBk
ZXYpOwotICAgIHJldHVybiAwOworICAgIHJldHVybiBhbWRfaW9tbXVfc2V0
dXBfZG9tYWluX2RldmljZShwZGV2LT5kb21haW4sIGlvbW11LCBkZXZmbiwg
cGRldik7CiB9CiAKIHN0YXRpYyBpbnQgYW1kX2lvbW11X3JlbW92ZV9kZXZp
Y2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-06.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSSkKCkFycmFuZ2UgZm9yIGRvbWFpbiBJRCBhbmQg
cGFnZSB0YWJsZSByb290IHRvIGJlIHBhc3NlZCBhcm91bmQsIHRoZSBsYXR0
ZXIgaW4KcGFydGljdWxhciB0byBkb21haW5fcGdkX21hZGRyKCkgc3VjaCB0
aGF0IHRha2luZyBpdCBmcm9tIHRoZSBwZXItZG9tYWluCmZpZWxkcyBjYW4g
YmUgb3ZlcnJpZGRlbi4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVk
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5A
aW50ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2V4dGVybi5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9l
eHRlcm4uaApAQCAtNzIsOSArNzIsMTAgQEAgdm9pZCAqbWFwX3Z0ZF9kb21h
aW5fcGFnZSh1NjQgbWFkZHIpOwogdm9pZCB1bm1hcF92dGRfZG9tYWluX3Bh
Z2Uodm9pZCAqdmEpOwogaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25l
KHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IGlvbW11ICppb21tdSwK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50OF90IGJ1cywg
dWludDhfdCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IG1v
ZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0
cnVjdCBwY2lfZGV2ICpwZGV2LCBkb21pZF90IGRvbWlkLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHBhZGRyX3QgcGdkX21hZGRyLCB1bnNp
Z25lZCBpbnQgbW9kZSk7CiBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IGlvbW11ICppb21tdSwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdTggYnVzLCB1OCBkZXZm
bik7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgYnVz
LCB1aW50OF90IGRldmZuLCBkb21pZF90IGRvbWlkKTsKIGludCBpbnRlbF9p
b21tdV9nZXRfcmVzZXJ2ZWRfZGV2aWNlX21lbW9yeShpb21tdV9ncmRtX3Qg
KmZ1bmMsIHZvaWQgKmN0eHQpOwogCiB1bnNpZ25lZCBpbnQgaW9fYXBpY19y
ZWFkX3JlbWFwX3J0ZSh1bnNpZ25lZCBpbnQgYXBpYywgdW5zaWduZWQgaW50
IHJlZyk7CkBAIC05Myw3ICs5NCw4IEBAIHZvaWQgcGxhdGZvcm1fcXVpcmtz
X2luaXQodm9pZCk7CiB2b2lkIHZ0ZF9vcHNfcHJlYW1ibGVfcXVpcmsoc3Ry
dWN0IGlvbW11KiBpb21tdSk7CiB2b2lkIHZ0ZF9vcHNfcG9zdGFtYmxlX3F1
aXJrKHN0cnVjdCBpb21tdSogaW9tbXUpOwogaW50IF9fbXVzdF9jaGVjayBt
ZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgdWludDhfdCBi
dXMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBk
ZXZmbiwgdW5zaWduZWQgaW50IG1vZGUpOworICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQsIHBh
ZGRyX3QgcGdkX21hZGRyLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHVuc2lnbmVkIGludCBtb2RlKTsKIHZvaWQgcGNpX3Z0ZF9xdWlyayhj
b25zdCBzdHJ1Y3QgcGNpX2RldiAqKTsKIHZvaWQgcXVpcmtfaW9tbXVfY2Fw
cyhzdHJ1Y3QgaW9tbXUgKmlvbW11KTsKIAotLS0gYS94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC92dGQvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC92dGQvaW9tbXUuYwpAQCAtMTQwNSwxMiArMTQwNSwxMiBAQCBp
bnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgc3RydWN0IGRv
bWFpbiAqZG9tYWluLAogICAgIHN0cnVjdCBpb21tdSAqaW9tbXUsCiAgICAg
dWludDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sIGNvbnN0IHN0cnVjdCBwY2lf
ZGV2ICpwZGV2LAotICAgIHVuc2lnbmVkIGludCBtb2RlKQorICAgIGRvbWlk
X3QgZG9taWQsIHBhZGRyX3QgcGdkX21hZGRyLCB1bnNpZ25lZCBpbnQgbW9k
ZSkKIHsKICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21t
dShkb21haW4pOwogICAgIHN0cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0
LCAqY29udGV4dF9lbnRyaWVzLCBsY3R4dDsKICAgICBfX3VpbnQxMjhfdCBv
bGQ7Ci0gICAgdTY0IG1hZGRyLCBwZ2RfbWFkZHI7CisgICAgdWludDY0X3Qg
bWFkZHI7CiAgICAgdWludDE2X3Qgc2VnID0gaW9tbXUtPmludGVsLT5kcmhk
LT5zZWdtZW50LCBwcmV2X2RpZCA9IDA7CiAgICAgc3RydWN0IGRvbWFpbiAq
cHJldl9kb20gPSBOVUxMOwogICAgIGludCBhZ2F3LCByYywgcmV0OwpAQCAt
MTQ1MSwxMCArMTQ1MSwxMiBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGlu
Z19vbmUoCiAgICAgfQogICAgIGVsc2UKICAgICB7CisgICAgICAgIHBhZGRy
X3Qgcm9vdCA9IHBnZF9tYWRkcjsKKwogICAgICAgICBzcGluX2xvY2soJmhk
LT5hcmNoLm1hcHBpbmdfbG9jayk7CiAKICAgICAgICAgLyogRW5zdXJlIHdl
IGhhdmUgcGFnZXRhYmxlcyBhbGxvY2F0ZWQgZG93biB0byBsZWFmIFBURS4g
Ki8KLSAgICAgICAgaWYgKCBoZC0+YXJjaC5wZ2RfbWFkZHIgPT0gMCApCisg
ICAgICAgIGlmICggIXJvb3QgKQogICAgICAgICB7CiAgICAgICAgICAgICBh
ZGRyX3RvX2RtYV9wYWdlX21hZGRyKGRvbWFpbiwgMCwgMSk7CiAgICAgICAg
ICAgICBpZiAoIGhkLT5hcmNoLnBnZF9tYWRkciA9PSAwICkKQEAgLTE0Njcs
MjIgKzE0NjksMjQgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25l
KAogICAgICAgICAgICAgICAgICAgICByY3VfdW5sb2NrX2RvbWFpbihwcmV2
X2RvbSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07CiAgICAg
ICAgICAgICB9CisKKyAgICAgICAgICAgIHJvb3QgPSBoZC0+YXJjaC5wZ2Rf
bWFkZHI7CiAgICAgICAgIH0KIAogICAgICAgICAvKiBTa2lwIHRvcCBsZXZl
bHMgb2YgcGFnZSB0YWJsZXMgZm9yIDItIGFuZCAzLWxldmVsIERSSERzLiAq
LwotICAgICAgICBwZ2RfbWFkZHIgPSBoZC0+YXJjaC5wZ2RfbWFkZHI7CiAg
ICAgICAgIGZvciAoIGFnYXcgPSBsZXZlbF90b19hZ2F3KDQpOwogICAgICAg
ICAgICAgICBhZ2F3ICE9IGxldmVsX3RvX2FnYXcoaW9tbXUtPm5yX3B0X2xl
dmVscyk7CiAgICAgICAgICAgICAgIGFnYXctLSApCiAgICAgICAgIHsKLSAg
ICAgICAgICAgIHN0cnVjdCBkbWFfcHRlICpwID0gbWFwX3Z0ZF9kb21haW5f
cGFnZShwZ2RfbWFkZHIpOwotICAgICAgICAgICAgcGdkX21hZGRyID0gZG1h
X3B0ZV9hZGRyKCpwKTsKKyAgICAgICAgICAgIHN0cnVjdCBkbWFfcHRlICpw
ID0gbWFwX3Z0ZF9kb21haW5fcGFnZShyb290KTsKKworICAgICAgICAgICAg
cm9vdCA9IGRtYV9wdGVfYWRkcigqcCk7CiAgICAgICAgICAgICB1bm1hcF92
dGRfZG9tYWluX3BhZ2UocCk7Ci0gICAgICAgICAgICBpZiAoIHBnZF9tYWRk
ciA9PSAwICkKKyAgICAgICAgICAgIGlmICggIXJvb3QgKQogICAgICAgICAg
ICAgICAgIGdvdG8gbm9tZW07CiAgICAgICAgIH0KIAotICAgICAgICBjb250
ZXh0X3NldF9hZGRyZXNzX3Jvb3QobGN0eHQsIHBnZF9tYWRkcik7CisgICAg
ICAgIGNvbnRleHRfc2V0X2FkZHJlc3Nfcm9vdChsY3R4dCwgcm9vdCk7CiAg
ICAgICAgIGlmICggYXRzX2VuYWJsZWQgJiYgZWNhcF9kZXZfaW90bGIoaW9t
bXUtPmVjYXApICkKICAgICAgICAgICAgIGNvbnRleHRfc2V0X3RyYW5zbGF0
aW9uX3R5cGUobGN0eHQsIENPTlRFWFRfVFRfREVWX0lPVExCKTsKICAgICAg
ICAgZWxzZQpAQCAtMTU5OCwxNSArMTYwMiwyMSBAQCBpbnQgZG9tYWluX2Nv
bnRleHRfbWFwcGluZ19vbmUoCiAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdl
KGNvbnRleHRfZW50cmllcyk7CiAKICAgICBpZiAoICFzZWcgJiYgIXJjICkK
LSAgICAgICAgcmMgPSBtZV93aWZpX3F1aXJrKGRvbWFpbiwgYnVzLCBkZXZm
biwgbW9kZSk7CisgICAgICAgIHJjID0gbWVfd2lmaV9xdWlyayhkb21haW4s
IGJ1cywgZGV2Zm4sIGRvbWlkLCBwZ2RfbWFkZHIsIG1vZGUpOwogCiAgICAg
aWYgKCByYyApCiAgICAgewogICAgICAgICBpZiAoICFwcmV2X2RvbSApCi0g
ICAgICAgICAgICBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBp
b21tdSwgYnVzLCBkZXZmbik7CisgICAgICAgICAgICBkb21haW5fY29udGV4
dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgYnVzLCBkZXZmbiwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFp
bl9pZCk7CiAgICAgICAgIGVsc2UgaWYgKCBwcmV2X2RvbSAhPSBkb21haW4g
KSAvKiBBdm9pZCBpbmZpbml0ZSByZWN1cnNpb24uICovCisgICAgICAgIHsK
KyAgICAgICAgICAgIGhkID0gZG9tX2lvbW11KHByZXZfZG9tKTsKICAgICAg
ICAgICAgIGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKHByZXZfZG9tLCBp
b21tdSwgYnVzLCBkZXZmbiwgcGRldiwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaGQtPmFyY2gucGdk
X21hZGRyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgbW9kZSAmIE1BUF9XSVRIX1JNUlIpOworICAgICAgICB9CiAgICAgfQog
CiAgICAgaWYgKCBwcmV2X2RvbSApCkBAIC0xNjIzLDYgKzE2MzMsNyBAQCBz
dGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiB7CiAg
ICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwogICAgIGNvbnN0IHN0
cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKKyAgICBwYWRkcl90IHBnZF9t
YWRkciA9IGRvbV9pb21tdShkb21haW4pLT5hcmNoLnBnZF9tYWRkcjsKICAg
ICBpbnQgcmV0ID0gMDsKICAgICB1bnNpZ25lZCBpbnQgaSwgbW9kZSA9IDA7
CiAgICAgdWludDE2X3Qgc2VnID0gcGRldi0+c2VnLCBiZGY7CkBAIC0xNjc4
LDcgKzE2ODksOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBp
bmcoc3RydWN0CiAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5f
aWQsIHNlZywgYnVzLAogICAgICAgICAgICAgICAgICAgIFBDSV9TTE9UKGRl
dmZuKSwgUENJX0ZVTkMoZGV2Zm4pKTsKICAgICAgICAgcmV0ID0gZG9tYWlu
X2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVz
LCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgcGRldiwgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHBkZXYsIGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2Rf
bWFkZHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIG1vZGUpOwogICAgICAgICBpZiAoIHJldCA+IDAgKQogICAgICAgICAg
ICAgcmV0ID0gMDsKICAgICAgICAgaWYgKCAhcmV0ICYmIGRldmZuID09IHBk
ZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRldiwgZHJoZCkgPiAwICkKQEAg
LTE2OTMsNyArMTcwNSw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRf
bWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgICAgICAgICBQQ0lfU0xPVChk
ZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7CiAKICAgICAgICAgcmV0ID0gZG9t
YWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwg
YnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgcGRldiwgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHBkZXYsIGRvbWFpbi0+ZG9tYWluX2lkLCBw
Z2RfbWFkZHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIG1vZGUpOwogICAgICAgICBpZiAoIHJldCA8IDAgKQogICAgICAg
ICAgICAgYnJlYWs7CiAgICAgICAgIHByZXZfcHJlc2VudCA9IHJldDsKQEAg
LTE3MTksNyArMTczMiw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRf
bWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICovCiAgICAgICAgIGlmICggcmV0
ID49IDAgKQogICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFw
cGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5V
TEwsIG1vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgTlVMTCwgZG9tYWluLT5kb21haW5faWQsIHBnZF9tYWRk
ciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIG1vZGUpOwogCiAgICAgICAgIC8qCiAgICAgICAgICAqIERldmljZXMg
YmVoaW5kIFBDSWUtdG8tUENJL1BDSXggYnJpZGdlIG1heSBnZW5lcmF0ZSBk
aWZmZXJlbnQKQEAgLTE3MzQsNyArMTc0OCw4IEBAIHN0YXRpYyBpbnQgZG9t
YWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgaWYgKCAhcmV0
ICYmIHBkZXZfdHlwZShzZWcsIGJ1cywgZGV2Zm4pID09IERFVl9UWVBFX1BD
SWUyUENJX0JSSURHRSAmJgogICAgICAgICAgICAgIChzZWNidXMgIT0gcGRl
di0+YnVzIHx8IHBkZXYtPmRldmZuICE9IDApICkKICAgICAgICAgICAgIHJl
dCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+
aW9tbXUsIHNlY2J1cywgMCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIE5VTEwsIG1vZGUpOworICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgZG9tYWlu
LT5kb21haW5faWQsIHBnZF9tYWRkciwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGUpOwogCiAgICAgICAgIGlm
ICggcmV0ICkKICAgICAgICAgewpAQCAtMTc2Myw3ICsxNzc4LDcgQEAgc3Rh
dGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogaW50IGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZSgKICAgICBzdHJ1Y3QgZG9tYWluICpk
b21haW4sCiAgICAgc3RydWN0IGlvbW11ICppb21tdSwKLSAgICB1OCBidXMs
IHU4IGRldmZuKQorICAgIHVpbnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLCBk
b21pZF90IGRvbWlkKQogewogICAgIHN0cnVjdCBjb250ZXh0X2VudHJ5ICpj
b250ZXh0LCAqY29udGV4dF9lbnRyaWVzOwogICAgIHU2NCBtYWRkcjsKQEAg
LTE4MjEsNyArMTgzNiw3IEBAIGludCBkb21haW5fY29udGV4dF91bm1hcF9v
bmUoCiAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmll
cyk7CiAKICAgICBpZiAoICFpb21tdS0+aW50ZWwtPmRyaGQtPnNlZ21lbnQg
JiYgIXJjICkKLSAgICAgICAgcmMgPSBtZV93aWZpX3F1aXJrKGRvbWFpbiwg
YnVzLCBkZXZmbiwgVU5NQVBfTUVfUEhBTlRPTV9GVU5DKTsKKyAgICAgICAg
cmMgPSBtZV93aWZpX3F1aXJrKGRvbWFpbiwgYnVzLCBkZXZmbiwgZG9taWQs
IDAsIFVOTUFQX01FX1BIQU5UT01fRlVOQyk7CiAKICAgICByZXR1cm4gcmM7
CiB9CkBAIC0xODYwLDcgKzE4NzUsOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9j
b250ZXh0X3VubWFwKHN0cnVjdCBkCiAgICAgICAgICAgICBwcmludGsoVlRE
UFJFRklYICJkJWQ6UENJZTogdW5tYXAgJTA0eDolMDJ4OiUwMnguJXVcbiIs
CiAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQsIHNlZywg
YnVzLAogICAgICAgICAgICAgICAgICAgIFBDSV9TTE9UKGRldmZuKSwgUENJ
X0ZVTkMoZGV2Zm4pKTsKLSAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRf
dW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOworICAgICAg
ICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21t
dSwgYnVzLCBkZXZmbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgaWYgKCAh
cmV0ICYmIGRldmZuID09IHBkZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRl
diwgZHJoZCkgPiAwICkKICAgICAgICAgICAgIGRpc2FibGVfYXRzX2Rldmlj
ZShwZGV2KTsKIApAQCAtMTg3MCw3ICsxODg2LDggQEAgc3RhdGljIGludCBk
b21haW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZAogICAgICAgICBpZiAoIGlv
bW11X2RlYnVnICkKICAgICAgICAgICAgIHByaW50ayhWVERQUkVGSVggImQl
ZDpQQ0k6IHVubWFwICUwNHg6JTAyeDolMDJ4LiV1XG4iLAogICAgICAgICAg
ICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBzZWcsIGJ1cywgUENJX1NM
T1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikpOwotICAgICAgICByZXQgPSBk
b21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgYnVzLCBk
ZXZmbik7CisgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29u
ZShkb21haW4sIGlvbW11LCBidXMsIGRldmZuLAorICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOwog
ICAgICAgICBpZiAoIHJldCApCiAgICAgICAgICAgICBicmVhazsKIApAQCAt
MTg4MiwxNCArMTg5OSwxNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0
X3VubWFwKHN0cnVjdCBkCiAgICAgICAgIC8qIFBDSWUgdG8gUENJL1BDSXgg
YnJpZGdlICovCiAgICAgICAgIGlmICggcGRldl90eXBlKHNlZywgdG1wX2J1
cywgdG1wX2RldmZuKSA9PSBERVZfVFlQRV9QQ0llMlBDSV9CUklER0UgKQog
ICAgICAgICB7Ci0gICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91
bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgdG1wX2J1cywgdG1wX2RldmZuKTsK
KyAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShk
b21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4sCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21h
aW5faWQpOwogICAgICAgICAgICAgaWYgKCByZXQgKQogICAgICAgICAgICAg
ICAgIHJldHVybiByZXQ7CiAKLSAgICAgICAgICAgIHJldCA9IGRvbWFpbl9j
b250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBzZWNidXMsIDApOwor
ICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRv
bWFpbiwgaW9tbXUsIHNlY2J1cywgMCwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7CiAg
ICAgICAgIH0KICAgICAgICAgZWxzZSAvKiBMZWdhY3kgUENJIGJyaWRnZSAq
LwotICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KGRvbWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbik7CisgICAgICAg
ICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBp
b21tdSwgdG1wX2J1cywgdG1wX2RldmZuLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsK
IAogICAgICAgICBicmVhazsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC92dGQvcXVpcmtzLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvdnRkL3F1aXJrcy5jCkBAIC0zMzEsNiArMzMxLDggQEAgdm9pZCBfX2lu
aXQgcGxhdGZvcm1fcXVpcmtzX2luaXQodm9pZCkKIAogc3RhdGljIGludCBf
X211c3RfY2hlY2sgbWFwX21lX3BoYW50b21fZnVuY3Rpb24oc3RydWN0IGRv
bWFpbiAqZG9tYWluLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGRldiwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlk
X3QgZG9taWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBwYWRkcl90IHBnZF9tYWRkciwKICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVk
IGludCBtb2RlKQogewogICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJo
ZDsKQEAgLTM0NCwxNiArMzQ2LDE3IEBAIHN0YXRpYyBpbnQgX19tdXN0X2No
ZWNrIG1hcF9tZV9waGFudG9tX2YKICAgICAvKiBtYXAgb3IgdW5tYXAgTUUg
cGhhbnRvbSBmdW5jdGlvbiAqLwogICAgIGlmICggIShtb2RlICYgVU5NQVBf
TUVfUEhBTlRPTV9GVU5DKSApCiAgICAgICAgIHJjID0gZG9tYWluX2NvbnRl
eHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgMCwKLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfREVWRk4o
ZGV2LCA3KSwgTlVMTCwgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgUENJX0RFVkZOKGRldiwgNyksIE5VTEwsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9taWQs
IHBnZF9tYWRkciwgbW9kZSk7CiAgICAgZWxzZQogICAgICAgICByYyA9IGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGRyaGQtPmlvbW11LCAw
LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lf
REVWRk4oZGV2LCA3KSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpLCBkb21pZCk7CiAKICAgICBy
ZXR1cm4gcmM7CiB9CiAKIGludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21h
aW4gKmRvbWFpbiwgdWludDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgbW9kZSkKKyAgICAgICAgICAg
ICAgICAgIGRvbWlkX3QgZG9taWQsIHBhZGRyX3QgcGdkX21hZGRyLCB1bnNp
Z25lZCBpbnQgbW9kZSkKIHsKICAgICB1MzIgaWQ7CiAgICAgaW50IHJjID0g
MDsKQEAgLTM3Nyw3ICszODAsNyBAQCBpbnQgbWVfd2lmaV9xdWlyayhzdHJ1
Y3QgZG9tYWluICpkb21haW4sCiAgICAgICAgICAgICBjYXNlIDB4NDIzYjgw
ODY6CiAgICAgICAgICAgICBjYXNlIDB4NDIzYzgwODY6CiAgICAgICAgICAg
ICBjYXNlIDB4NDIzZDgwODY6Ci0gICAgICAgICAgICAgICAgcmMgPSBtYXBf
bWVfcGhhbnRvbV9mdW5jdGlvbihkb21haW4sIDMsIG1vZGUpOworICAgICAg
ICAgICAgICAgIHJjID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWlu
LCAzLCBkb21pZCwgcGdkX21hZGRyLCBtb2RlKTsKICAgICAgICAgICAgICAg
ICBicmVhazsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAg
ICAgYnJlYWs7CkBAIC00MDMsNyArNDA2LDcgQEAgaW50IG1lX3dpZmlfcXVp
cmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLAogICAgICAgICAgICAgY2FzZSAw
eDQyMzg4MDg2OiAgICAgICAgLyogUHVtYSBQZWFrICovCiAgICAgICAgICAg
ICBjYXNlIDB4NDIyYjgwODY6CiAgICAgICAgICAgICBjYXNlIDB4NDIyYzgw
ODY6Ci0gICAgICAgICAgICAgICAgcmMgPSBtYXBfbWVfcGhhbnRvbV9mdW5j
dGlvbihkb21haW4sIDIyLCBtb2RlKTsKKyAgICAgICAgICAgICAgICByYyA9
IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMjIsIGRvbWlkLCBw
Z2RfbWFkZHIsIG1vZGUpOwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAg
ICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICBicmVhazsK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-07.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSUkpCgpSZXBsYWNlIHRoZSBwYXNzaW5nIG9mIHN0
cnVjdCBkb21haW4gKiBieSBkb21pZF90IGluIHByZXBhcmF0aW9uIG9mCnBl
ci1kZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBhbHNvIHJlcXVpcmlu
ZyBwZXItZGV2aWNlIHBzZXVkbwpkb21haW4gSURzLCB3aGljaCBhcmVuJ3Qg
Z29pbmcgdG8gYmUgYXNzb2NpYXRlZCB3aXRoIGFueSBzdHJ1Y3QgZG9tYWlu
Cmluc3RhbmNlcy4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkIChl
eGNlcHQgZm9yIHNsaWdodGx5IGFkanVzdGVkIGxvZyBtZXNzYWdlCnRleHQp
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNv
bT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKQEAgLTUyLDggKzUyLDggQEAgc3RhdGljIHN0cnVjdCB0YXNrbGV0
IHZ0ZF9mYXVsdF90YXNrbGV0Owogc3RhdGljIGludCBzZXR1cF9od2RvbV9k
ZXZpY2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICopOwogc3RhdGljIHZv
aWQgc2V0dXBfaHdkb21fcm1ycihzdHJ1Y3QgZG9tYWluICpkKTsKIAotc3Rh
dGljIGludCBkb21haW5faW9tbXVfZG9taWQoc3RydWN0IGRvbWFpbiAqZCwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpb21tdSAq
aW9tbXUpCitzdGF0aWMgaW50IGdldF9pb21tdV9kaWQoZG9taWRfdCBkb21p
ZCwgY29uc3Qgc3RydWN0IGlvbW11ICppb21tdSwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICBib29sIHdhcm4pCiB7CiAgICAgdW5zaWduZWQgbG9uZyBu
cl9kb20sIGk7CiAKQEAgLTYxLDIzICs2MSwyNCBAQCBzdGF0aWMgaW50IGRv
bWFpbl9pb21tdV9kb21pZChzdHJ1Y3QgZG9tCiAgICAgaSA9IGZpbmRfZmly
c3RfYml0KGlvbW11LT5kb21pZF9iaXRtYXAsIG5yX2RvbSk7CiAgICAgd2hp
bGUgKCBpIDwgbnJfZG9tICkKICAgICB7Ci0gICAgICAgIGlmICggaW9tbXUt
PmRvbWlkX21hcFtpXSA9PSBkLT5kb21haW5faWQgKQorICAgICAgICBpZiAo
IGlvbW11LT5kb21pZF9tYXBbaV0gPT0gZG9taWQgKQogICAgICAgICAgICAg
cmV0dXJuIGk7CiAKICAgICAgICAgaSA9IGZpbmRfbmV4dF9iaXQoaW9tbXUt
PmRvbWlkX2JpdG1hcCwgbnJfZG9tLCBpKzEpOwogICAgIH0KIAotICAgIGRw
cmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsCi0gICAgICAgICAgICAiQ2Fu
bm90IGdldCB2YWxpZCBpb21tdSBkb21pZDogZG9taWQ9JWQgaW9tbXUtPmlu
ZGV4PSVkXG4iLAotICAgICAgICAgICAgZC0+ZG9tYWluX2lkLCBpb21tdS0+
aW5kZXgpOworICAgIGlmICggd2FybiApCisgICAgICAgIGRwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgsCisgICAgICAgICAgICAgICAgIk5vIHZhbGlk
IGlvbW11ICV1IGRvbWlkIGZvciBEb20lZFxuIiwKKyAgICAgICAgICAgICAg
ICBpb21tdS0+aW5kZXgsIGRvbWlkKTsKKwogICAgIHJldHVybiAtMTsKIH0K
IAogI2RlZmluZSBESURfRklFTERfV0lEVEggMTYKICNkZWZpbmUgRElEX0hJ
R0hfT0ZGU0VUIDgKIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lk
KHN0cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRvbWFpbiAqZCwKLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpb21tdSAqaW9t
bXUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21pZF90
IGRvbWlkLCBzdHJ1Y3QgaW9tbXUgKmlvbW11KQogewogICAgIHVuc2lnbmVk
IGxvbmcgbnJfZG9tLCBpOwogICAgIGludCBmb3VuZCA9IDA7CkBAIC04OCw3
ICs4OSw3IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0
cnVjdAogICAgIGkgPSBmaW5kX2ZpcnN0X2JpdChpb21tdS0+ZG9taWRfYml0
bWFwLCBucl9kb20pOwogICAgIHdoaWxlICggaSA8IG5yX2RvbSApCiAgICAg
ewotICAgICAgICBpZiAoIGlvbW11LT5kb21pZF9tYXBbaV0gPT0gZC0+ZG9t
YWluX2lkICkKKyAgICAgICAgaWYgKCBpb21tdS0+ZG9taWRfbWFwW2ldID09
IGRvbWlkICkKICAgICAgICAgewogICAgICAgICAgICAgZm91bmQgPSAxOwog
ICAgICAgICAgICAgYnJlYWs7CkBAIC0xMDQsNyArMTA1LDcgQEAgc3RhdGlj
IGludCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0CiAgICAgICAgICAg
ICBkcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiSU9NTVU6IG5vIGZy
ZWUgZG9tYWluIGlkc1xuIik7CiAgICAgICAgICAgICByZXR1cm4gLUVGQVVM
VDsKICAgICAgICAgfQotICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0g
ZC0+ZG9tYWluX2lkOworICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0g
ZG9taWQ7CiAgICAgfQogCiAgICAgc2V0X2JpdChpLCBpb21tdS0+ZG9taWRf
Yml0bWFwKTsKQEAgLTEzMSw5ICsxMzIsOSBAQCBzdGF0aWMgdm9pZCBfX2lu
aXQgZnJlZV9pbnRlbF9pb21tdShzdHJ1CiAgICAgeGZyZWUoaW50ZWwpOwog
fQogCi1zdGF0aWMgdm9pZCBjbGVhbnVwX2RvbWlkX21hcChzdHJ1Y3QgZG9t
YWluICpkb21haW4sIHN0cnVjdCBpb21tdSAqaW9tbXUpCitzdGF0aWMgdm9p
ZCBjbGVhbnVwX2RvbWlkX21hcChkb21pZF90IGRvbWlkLCBzdHJ1Y3QgaW9t
bXUgKmlvbW11KQogewotICAgIGludCBpb21tdV9kb21pZCA9IGRvbWFpbl9p
b21tdV9kb21pZChkb21haW4sIGlvbW11KTsKKyAgICBpbnQgaW9tbXVfZG9t
aWQgPSBnZXRfaW9tbXVfZGlkKGRvbWlkLCBpb21tdSwgZmFsc2UpOwogCiAg
ICAgaWYgKCBpb21tdV9kb21pZCA+PSAwICkKICAgICB7CkBAIC0xODksNyAr
MTkwLDcgQEAgc3RhdGljIHZvaWQgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAo
c3RydQogICAgIGlmICggIWZvdW5kICkKICAgICB7CiAgICAgICAgIGNsZWFy
X2JpdChpb21tdS0+aW5kZXgsICZkb21faW9tbXUoZCktPmFyY2guaW9tbXVf
Yml0bWFwKTsKLSAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZCwgaW9tbXUp
OworICAgICAgICBjbGVhbnVwX2RvbWlkX21hcChkLT5kb21haW5faWQsIGlv
bW11KTsKICAgICB9CiB9CiAKQEAgLTY3MCw3ICs2NzEsNyBAQCBzdGF0aWMg
aW50IF9fbXVzdF9jaGVjayBpb21tdV9mbHVzaF9pb3RsCiAgICAgICAgICAg
ICBjb250aW51ZTsKIAogICAgICAgICBmbHVzaF9kZXZfaW90bGIgPSAhIWZp
bmRfYXRzX2Rldl9kcmhkKGlvbW11KTsKLSAgICAgICAgaW9tbXVfZG9taWQ9
IGRvbWFpbl9pb21tdV9kb21pZChkLCBpb21tdSk7CisgICAgICAgIGlvbW11
X2RvbWlkID0gZ2V0X2lvbW11X2RpZChkLT5kb21haW5faWQsIGlvbW11LCAh
ZC0+aXNfZHlpbmcpOwogICAgICAgICBpZiAoIGlvbW11X2RvbWlkID09IC0x
ICkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCkBAIC0xNDk1LDcgKzE0OTYs
NyBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgICAg
IHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogICAgIH0K
IAotICAgIHJjID0gY29udGV4dF9zZXRfZG9tYWluX2lkKCZsY3R4dCwgZG9t
YWluLCBpb21tdSk7CisgICAgcmMgPSBjb250ZXh0X3NldF9kb21haW5faWQo
JmxjdHh0LCBkb21pZCwgaW9tbXUpOwogICAgIGlmICggcmMgKQogICAgIHsK
ICAgICB1bmxvY2s6CkBAIC0xODAzLDcgKzE4MDQsNyBAQCBpbnQgZG9tYWlu
X2NvbnRleHRfdW5tYXBfb25lKAogICAgIGNvbnRleHRfY2xlYXJfZW50cnko
KmNvbnRleHQpOwogICAgIGlvbW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6
ZW9mKHN0cnVjdCBjb250ZXh0X2VudHJ5KSk7CiAKLSAgICBpb21tdV9kb21p
ZD0gZG9tYWluX2lvbW11X2RvbWlkKGRvbWFpbiwgaW9tbXUpOworICAgIGlv
bW11X2RvbWlkID0gZ2V0X2lvbW11X2RpZChkb21pZCwgaW9tbXUsICFkb21h
aW4tPmlzX2R5aW5nKTsKICAgICBpZiAoIGlvbW11X2RvbWlkID09IC0xICkK
ICAgICB7CiAgICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-08.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IG1haW50YWluIGEgcGVyLWRldmljZSBwc2V1ZG8gZG9t
YWluIElECgpJbiBvcmRlciB0byBzdWJzZXF1ZW50bHkgZW5hYmxlIHBlci1k
ZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcywgd2UnbGwKbmVlZCBkb21h
aW4tSUQtbGlrZSBpZGVudGlmaWVycyB0byBiZSBpbnNlcnRlZCBpbiB0aGUg
cmVzcGVjdGl2ZSBkZXZpY2UKKEFNRCkgb3IgY29udGV4dCAoSW50ZWwpIHRh
YmxlIGVudHJpZXMgYWxvbmdzaWRlIHRoZSBwZXItZGV2aWNlIHBhZ2UKdGFi
bGUgcm9vdCBhZGRyZXNzZXMuCgpNYWtlIHVzZSBvZiAicmVhbCIgZG9tYWlu
IElEcyBvY2N1cHlpbmcgb25seSBoYWxmIG9mIHRoZSB2YWx1ZSByYW5nZQpj
b3ZlcmFibGUgYnkgZG9taWRfdC4KCk5vdGUgdGhhdCBpbiBWVC1kJ3MgaW9t
bXVfYWxsb2MoKSBJIGRpZG4ndCB3YW50IHRvIGludHJvZHVjZSBuZXcgbWVt
b3J5CmxlYWtzIGluIGNhc2Ugb2YgZXJyb3IsIGJ1dCBleGlzdGluZyBvbmVz
IGRvbid0IGdldCBwbHVnZ2VkIC0gdGhhdCdsbCBiZQp0aGUgc3ViamVjdCBv
ZiBhIGxhdGVyIGNoYW5nZS4KClRoZSBWVC1kIGNoYW5nZXMgYXJlIHNsaWdo
dGx5IGFzeW1tZXRyaWMsIGJ1dCB0aGlzIHdheSB3ZSBjYW4gYXZvaWQKYXNz
aWduaW5nIHBzZXVkbyBkb21haW4gSURzIHRvIGRldmljZXMgd2hpY2ggd291
bGQgbmV2ZXIgYmUgbWFwcGVkIHdoaWxlCnN0aWxsIGF2b2lkaW5nIHRvIGFk
ZCBhIG5ldyBwYXJhbWV0ZXIgdG8gZG9tYWluX2NvbnRleHRfdW5tYXAoKS4K
ClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpS
ZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaW9tbXUuaAor
KysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKQEAgLTExMiw2ICsx
MTIsMTAgQEAgaW50IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9k
ZXNjCiAgICAgICAgIG9wcy0+c3luY19jYWNoZShhZGRyLCBzaXplKTsgICAg
ICAgICAgICAgICAgICAgIFwKIH0pCiAKK3Vuc2lnbmVkIGxvbmcgKmlvbW11
X2luaXRfZG9taWQodm9pZCk7Citkb21pZF90IGlvbW11X2FsbG9jX2RvbWlk
KHVuc2lnbmVkIGxvbmcgKm1hcCk7Cit2b2lkIGlvbW11X2ZyZWVfZG9taWQo
ZG9taWRfdCBkb21pZCwgdW5zaWduZWQgbG9uZyAqbWFwKTsKKwogI2VuZGlm
IC8qICFfX0FSQ0hfWDg2X0lPTU1VX0hfXyAqLwogLyoKICAqIExvY2FsIHZh
cmlhYmxlczoKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaAorKysg
Yi94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oCkBAIC0xNSw2ICsxNSwxMiBA
QAogCiBzdHJ1Y3QgYXJjaF9wY2lfZGV2IHsKICAgICB2bWFza190IHVzZWRf
dmVjdG9yczsKKyAgICAvKgorICAgICAqIFRoZXNlIGZpZWxkcyBhcmUgKGRl
KWluaXRpYWxpemVkIHVuZGVyIHBjaWRldnMtbG9jay4gT3RoZXIgdXNlcyBv
ZgorICAgICAqIHRoZW0gZG9uJ3QgcmFjZSAoZGUpaW5pdGlhbGl6YXRpb24g
YW5kIGhlbmNlIGRvbid0IHN0cmljdGx5IG5lZWQgYW55CisgICAgICogbG9j
a2luZy4KKyAgICAgKi8KKyAgICBkb21pZF90IHBzZXVkb19kb21pZDsKIH07
CiAKIGludCBwY2lfY29uZl93cml0ZV9pbnRlcmNlcHQodW5zaWduZWQgaW50
IHNlZywgdW5zaWduZWQgaW50IGJkZiwKLS0tIGEveGVuL2luY2x1ZGUvYXNt
LXg4Ni9hbWQtaW9tbXUuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2Ft
ZC1pb21tdS5oCkBAIC05Nyw2ICs5Nyw3IEBAIHN0cnVjdCBhbWRfaW9tbXUg
ewogICAgIHN0cnVjdCByaW5nX2J1ZmZlciBjbWRfYnVmZmVyOwogICAgIHN0
cnVjdCByaW5nX2J1ZmZlciBldmVudF9sb2c7CiAgICAgc3RydWN0IHJpbmdf
YnVmZmVyIHBwcl9sb2c7CisgICAgdW5zaWduZWQgbG9uZyAqZG9taWRfbWFw
OwogCiAgICAgaW50IGV4Y2x1c2lvbl9lbmFibGU7CiAgICAgaW50IGV4Y2x1
c2lvbl9hbGxvd19hbGw7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L2FtZC9pb21tdV9kZXRlY3QuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9hbWQvaW9tbXVfZGV0ZWN0LmMKQEAgLTE1MCw2ICsxNTAsMTEgQEAg
aW50IF9faW5pdCBhbWRfaW9tbXVfZGV0ZWN0X29uZV9hY3BpKAogICAgIGlm
ICggcnQgKQogICAgICAgICBnb3RvIG91dDsKIAorICAgIGlvbW11LT5kb21p
ZF9tYXAgPSBpb21tdV9pbml0X2RvbWlkKCk7CisgICAgcnQgPSAtRU5PTUVN
OworICAgIGlmICggIWlvbW11LT5kb21pZF9tYXAgKQorICAgICAgICBnb3Rv
IG91dDsKKwogICAgIHJ0ID0gcGNpX3JvX2RldmljZShpb21tdS0+c2VnLCBi
dXMsIFBDSV9ERVZGTihkZXYsIGZ1bmMpKTsKICAgICBpZiAoIHJ0ICkKICAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlIKQEAgLTE2MSw3ICsxNjYsMTAgQEAg
aW50IF9faW5pdCBhbWRfaW9tbXVfZGV0ZWN0X29uZV9hY3BpKAogCiAgb3V0
OgogICAgIGlmICggcnQgKQorICAgIHsKKyAgICAgICAgeGZyZWUoaW9tbXUt
PmRvbWlkX21hcCk7CiAgICAgICAgIHhmcmVlKGlvbW11KTsKKyAgICB9CiAK
ICAgICByZXR1cm4gcnQ7CiB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL2FtZC9wY2lfYW1kX2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYwpAQCAtNTQxLDYgKzU0MSw4
IEBAIHN0YXRpYyBpbnQgYW1kX2lvbW11X2FkZF9kZXZpY2UodTggZGV2Zm4K
IHsKICAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdTsKICAgICB1MTYgYmRm
OworICAgIGJvb2wgZnJlc2hfZG9taWQgPSBmYWxzZTsKKyAgICBpbnQgcmV0
OwogCiAgICAgaWYgKCAhcGRldi0+ZG9tYWluICkKICAgICAgICAgcmV0dXJu
IC1FSU5WQUw7CkBAIC01NjUsNyArNTY3LDIyIEBAIHN0YXRpYyBpbnQgYW1k
X2lvbW11X2FkZF9kZXZpY2UodTggZGV2Zm4KICAgICAgICAgcmV0dXJuIC1F
Tk9ERVY7CiAgICAgfQogCi0gICAgcmV0dXJuIGFtZF9pb21tdV9zZXR1cF9k
b21haW5fZGV2aWNlKHBkZXYtPmRvbWFpbiwgaW9tbXUsIGRldmZuLCBwZGV2
KTsKKyAgICBpZiAoIGlvbW11X3F1YXJhbnRpbmUgJiYgcGRldi0+YXJjaC5w
c2V1ZG9fZG9taWQgPT0gRE9NSURfSU5WQUxJRCApCisgICAgeworICAgICAg
ICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IGlvbW11X2FsbG9jX2RvbWlk
KGlvbW11LT5kb21pZF9tYXApOworICAgICAgICBpZiAoIHBkZXYtPmFyY2gu
cHNldWRvX2RvbWlkID09IERPTUlEX0lOVkFMSUQgKQorICAgICAgICAgICAg
cmV0dXJuIC1FTk9TUEM7CisgICAgICAgIGZyZXNoX2RvbWlkID0gdHJ1ZTsK
KyAgICB9CisKKyAgICByZXQgPSBhbWRfaW9tbXVfc2V0dXBfZG9tYWluX2Rl
dmljZShwZGV2LT5kb21haW4sIGlvbW11LCBkZXZmbiwgcGRldik7CisgICAg
aWYgKCByZXQgJiYgZnJlc2hfZG9taWQgKQorICAgIHsKKyAgICAgICAgaW9t
bXVfZnJlZV9kb21pZChwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwgaW9tbXUt
PmRvbWlkX21hcCk7CisgICAgICAgIHBkZXYtPmFyY2gucHNldWRvX2RvbWlk
ID0gRE9NSURfSU5WQUxJRDsKKyAgICB9CisKKyAgICByZXR1cm4gcmV0Owog
fQogCiBzdGF0aWMgaW50IGFtZF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4IGRl
dmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikKQEAgLTU4Nyw2ICs2MDQsMTAg
QEAgc3RhdGljIGludCBhbWRfaW9tbXVfcmVtb3ZlX2RldmljZSh1OCBkZQog
ICAgIH0KIAogICAgIGFtZF9pb21tdV9kaXNhYmxlX2RvbWFpbl9kZXZpY2Uo
cGRldi0+ZG9tYWluLCBpb21tdSwgZGV2Zm4sIHBkZXYpOworCisgICAgaW9t
bXVfZnJlZV9kb21pZChwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwgaW9tbXUt
PmRvbWlkX21hcCk7CisgICAgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBE
T01JRF9JTlZBTElEOworCiAgICAgcmV0dXJuIDA7CiB9CiAKLS0tIGEveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMKKysrIGIveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvcGNpLmMKQEAgLTM0Myw2ICszNDMsNyBAQCBzdGF0aWMg
c3RydWN0IHBjaV9kZXYgKmFsbG9jX3BkZXYoc3RydWN0CiAgICAgKigodTgq
KSAmcGRldi0+YnVzKSA9IGJ1czsKICAgICAqKCh1OCopICZwZGV2LT5kZXZm
bikgPSBkZXZmbjsKICAgICBwZGV2LT5kb21haW4gPSBOVUxMOworICAgIHBk
ZXYtPmFyY2gucHNldWRvX2RvbWlkID0gRE9NSURfSU5WQUxJRDsKICAgICBJ
TklUX0xJU1RfSEVBRCgmcGRldi0+bXNpX2xpc3QpOwogCiAgICAgaWYgKCBw
Y2lfZmluZF9jYXBfb2Zmc2V0KHBzZWctPm5yLCBidXMsIFBDSV9TTE9UKGRl
dmZuKSwgUENJX0ZVTkMoZGV2Zm4pLApAQCAtMTMxMSwxMCArMTMxMiwxMyBA
QCBzdGF0aWMgaW50IF9kdW1wX3BjaV9kZXZpY2VzKHN0cnVjdCBwY2lfCiAK
ICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5ICggcGRldiwgJnBzZWctPmFsbGRl
dnNfbGlzdCwgYWxsZGV2c19saXN0ICkKICAgICB7Ci0gICAgICAgIHByaW50
aygiJTA0eDolMDJ4OiUwMnguJXUgLSBkb20gJS0zZCAtIG5vZGUgJS0zZCAt
IE1TSXMgPCAiLAotICAgICAgICAgICAgICAgcHNlZy0+bnIsIHBkZXYtPmJ1
cywKLSAgICAgICAgICAgICAgIFBDSV9TTE9UKHBkZXYtPmRldmZuKSwgUENJ
X0ZVTkMocGRldi0+ZGV2Zm4pLAotICAgICAgICAgICAgICAgcGRldi0+ZG9t
YWluID8gcGRldi0+ZG9tYWluLT5kb21haW5faWQgOiAtMSwKKyAgICAgICAg
cHJpbnRrKCIlMDR4OiUwMng6JTAyeC4ldSAtICIsIHBzZWctPm5yLCBwZGV2
LT5idXMsCisgICAgICAgICAgICAgICBQQ0lfU0xPVChwZGV2LT5kZXZmbiks
IFBDSV9GVU5DKHBkZXYtPmRldmZuKSk7CisgICAgICAgIGlmICggcGRldi0+
ZG9tYWluID09IGRvbV9pbyApCisgICAgICAgICAgICBwcmludGsoIkRvbUlP
OiV4IiwgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQpOworICAgICAgICBlbHNl
IGlmICggcGRldi0+ZG9tYWluICkKKyAgICAgICAgICAgIHByaW50aygiRG9t
JWQiLCBwZGV2LT5kb21haW4tPmRvbWFpbl9pZCk7CisgICAgICAgIHByaW50
aygiIC0gbm9kZSAlLTNkIC0gTVNJcyA8ICIsCiAgICAgICAgICAgICAgICAo
cGRldi0+bm9kZSAhPSBOVU1BX05PX05PREUpID8gcGRldi0+bm9kZSA6IC0x
KTsKICAgICAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIG1zaSwgJnBkZXYt
Pm1zaV9saXN0LCBsaXN0ICkKICAgICAgICAgICAgICAgIHByaW50aygiJWQg
IiwgbXNpLT5pcnEpOwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92
dGQvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv
aW9tbXUuYwpAQCAtMjIsNiArMjIsNyBAQAogI2luY2x1ZGUgPHhlbi9zY2hl
ZC5oPgogI2luY2x1ZGUgPHhlbi94bWFsbG9jLmg+CiAjaW5jbHVkZSA8eGVu
L2RvbWFpbl9wYWdlLmg+CisjaW5jbHVkZSA8eGVuL2Vyci5oPgogI2luY2x1
ZGUgPHhlbi9pb2NhcC5oPgogI2luY2x1ZGUgPHhlbi9pb21tdS5oPgogI2lu
Y2x1ZGUgPHhlbi9udW1hLmg+CkBAIC0xMjM0LDcgKzEyMzUsNyBAQCBpbnQg
X19pbml0IGlvbW11X2FsbG9jKHN0cnVjdCBhY3BpX2RyaGRfCiB7CiAgICAg
c3RydWN0IGlvbW11ICppb21tdTsKICAgICB1bnNpZ25lZCBsb25nIHNhZ2F3
LCBucl9kb207Ci0gICAgaW50IGFnYXc7CisgICAgaW50IGFnYXcsIHJjOwog
CiAgICAgaWYgKCBucl9pb21tdXMgPiBNQVhfSU9NTVVTICkKICAgICB7CkBA
IC0xMzI0LDEwICsxMzI1LDE5IEBAIGludCBfX2luaXQgaW9tbXVfYWxsb2Mo
c3RydWN0IGFjcGlfZHJoZF8KICAgICBpZiAoICFpb21tdS0+ZG9taWRfbWFw
ICkKICAgICAgICAgcmV0dXJuIC1FTk9NRU0gOwogCisgICAgaW9tbXUtPnBz
ZXVkb19kb21pZF9tYXAgPSBpb21tdV9pbml0X2RvbWlkKCk7CisgICAgcmMg
PSAtRU5PTUVNOworICAgIGlmICggIWlvbW11LT5wc2V1ZG9fZG9taWRfbWFw
ICkKKyAgICAgICAgZ290byBmcmVlOworCiAgICAgc3Bpbl9sb2NrX2luaXQo
JmlvbW11LT5sb2NrKTsKICAgICBzcGluX2xvY2tfaW5pdCgmaW9tbXUtPnJl
Z2lzdGVyX2xvY2spOwogCiAgICAgcmV0dXJuIDA7CisKKyBmcmVlOgorICAg
IGlvbW11X2ZyZWUoZHJoZCk7CisgICAgcmV0dXJuIHJjOwogfQogCiB2b2lk
IF9faW5pdCBpb21tdV9mcmVlKHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJo
ZCkKQEAgLTEzNTAsNiArMTM2MCw3IEBAIHZvaWQgX19pbml0IGlvbW11X2Zy
ZWUoc3RydWN0IGFjcGlfZHJoZF8KIAogICAgIHhmcmVlKGlvbW11LT5kb21p
ZF9iaXRtYXApOwogICAgIHhmcmVlKGlvbW11LT5kb21pZF9tYXApOworICAg
IHhmcmVlKGlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKIAogICAgIGZyZWVf
aW50ZWxfaW9tbXUoaW9tbXUtPmludGVsKTsKICAgICBpZiAoIGlvbW11LT5t
c2kuaXJxID49IDAgKQpAQCAtMTYyNiw4ICsxNjM3LDggQEAgaW50IGRvbWFp
bl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIHJldHVybiByYyA/OiBwZGV2
ICYmIHByZXZfZG9tOwogfQogCi1zdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0
X3VubWFwKHN0cnVjdCBkb21haW4gKmQsIHVpbnQ4X3QgZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lfZGV2ICpw
ZGV2KTsKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRv
bWFpbl9jb250ZXh0X3VubWFwKAorICAgIHN0cnVjdCBkb21haW4gKmQsIHVp
bnQ4X3QgZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICpwZGV2KTsKIAogc3RhdGlj
IGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdCBkb21haW4gKmRv
bWFpbiwgdTggZGV2Zm4sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYpCkBAIC0xNjM1LDYgKzE2NDYs
NyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0
CiAgICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwogICAgIGNvbnN0
IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKICAgICBwYWRkcl90IHBn
ZF9tYWRkciA9IGRvbV9pb21tdShkb21haW4pLT5hcmNoLnBnZF9tYWRkcjsK
KyAgICBkb21pZF90IG9yaWdfZG9taWQgPSBwZGV2LT5hcmNoLnBzZXVkb19k
b21pZDsKICAgICBpbnQgcmV0ID0gMDsKICAgICB1bnNpZ25lZCBpbnQgaSwg
bW9kZSA9IDA7CiAgICAgdWludDE2X3Qgc2VnID0gcGRldi0+c2VnLCBiZGY7
CkBAIC0xNjg1LDYgKzE2OTcsMTQgQEAgc3RhdGljIGludCBkb21haW5fY29u
dGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICBicmVhazsKIAogICAgIGNh
c2UgREVWX1RZUEVfUENJZV9FTkRQT0lOVDoKKyAgICAgICAgaWYgKCBpb21t
dV9xdWFyYW50aW5lICYmIG9yaWdfZG9taWQgPT0gRE9NSURfSU5WQUxJRCAp
CisgICAgICAgIHsKKyAgICAgICAgICAgIHBkZXYtPmFyY2gucHNldWRvX2Rv
bWlkID0KKyAgICAgICAgICAgICAgICBpb21tdV9hbGxvY19kb21pZChkcmhk
LT5pb21tdS0+cHNldWRvX2RvbWlkX21hcCk7CisgICAgICAgICAgICBpZiAo
IHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID09IERPTUlEX0lOVkFMSUQgKQor
ICAgICAgICAgICAgICAgIHJldHVybiAtRU5PU1BDOworICAgICAgICB9CisK
ICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAgICAgICBwcmlu
dGsoVlREUFJFRklYICJkJWQ6UENJZTogbWFwICUwNHg6JTAyeDolMDJ4LiV1
XG4iLAogICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBz
ZWcsIGJ1cywKQEAgLTE3MDAsNiArMTcyMCwxNCBAQCBzdGF0aWMgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgIGJyZWFrOwog
CiAgICAgY2FzZSBERVZfVFlQRV9QQ0k6CisgICAgICAgIGlmICggaW9tbXVf
cXVhcmFudGluZSAmJiBvcmlnX2RvbWlkID09IERPTUlEX0lOVkFMSUQgKQor
ICAgICAgICB7CisgICAgICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21p
ZCA9CisgICAgICAgICAgICAgICAgaW9tbXVfYWxsb2NfZG9taWQoZHJoZC0+
aW9tbXUtPnBzZXVkb19kb21pZF9tYXApOworICAgICAgICAgICAgaWYgKCBw
ZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9PSBET01JRF9JTlZBTElEICkKKyAg
ICAgICAgICAgICAgICByZXR1cm4gLUVOT1NQQzsKKyAgICAgICAgfQorCiAg
ICAgICAgIGlmICggaW9tbXVfZGVidWcgKQogICAgICAgICAgICAgcHJpbnRr
KFZURFBSRUZJWCAiZCVkOlBDSTogbWFwICUwNHg6JTAyeDolMDJ4LiV1XG4i
LAogICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBzZWcs
IGJ1cywKQEAgLTE3NzMsNiArMTgwMSwxMyBAQCBzdGF0aWMgaW50IGRvbWFp
bl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgaWYgKCAhcmV0ICYmIGRl
dmZuID09IHBkZXYtPmRldmZuICkKICAgICAgICAgcGNpX3Z0ZF9xdWlyayhw
ZGV2KTsKIAorICAgIGlmICggcmV0ICYmIGRyaGQgJiYgb3JpZ19kb21pZCA9
PSBET01JRF9JTlZBTElEICkKKyAgICB7CisgICAgICAgIGlvbW11X2ZyZWVf
ZG9taWQocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgZHJoZC0+aW9tbXUtPnBzZXVkb19kb21pZF9tYXApOwor
ICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlEX0lOVkFM
SUQ7CisgICAgfQorCiAgICAgcmV0dXJuIHJldDsKIH0KIApAQCAtMTg0Miw4
ICsxODc3LDEwIEBAIGludCBkb21haW5fY29udGV4dF91bm1hcF9vbmUoCiAg
ICAgcmV0dXJuIHJjOwogfQogCi1zdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0
X3VubWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgdTggZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lfZGV2ICpw
ZGV2KQorc3RhdGljIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZG9t
YWluX2NvbnRleHRfdW5tYXAoCisgICAgc3RydWN0IGRvbWFpbiAqZG9tYWlu
LAorICAgIHVpbnQ4X3QgZGV2Zm4sCisgICAgc3RydWN0IHBjaV9kZXYgKnBk
ZXYpCiB7CiAgICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwogICAg
IHN0cnVjdCBpb21tdSAqaW9tbXU7CkBAIC0xODUyLDcgKzE4ODksNyBAQCBz
dGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X3VubWFwKHN0cnVjdCBkCiAKICAg
ICBkcmhkID0gYWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYpOwog
ICAgIGlmICggIWRyaGQgKQotICAgICAgICByZXR1cm4gLUVOT0RFVjsKKyAg
ICAgICAgcmV0dXJuIEVSUl9QVFIoLUVOT0RFVik7CiAgICAgaW9tbXUgPSBk
cmhkLT5pb21tdTsKIAogICAgIHN3aXRjaCAoIHBkZXYtPnR5cGUgKQpAQCAt
MTg2Myw3ICsxOTAwLDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91
bm1hcChzdHJ1Y3QgZAogICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9t
YWluX2lkLCBzZWcsIGJ1cywKICAgICAgICAgICAgICAgICAgICBQQ0lfU0xP
VChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7CiAgICAgICAgIGlmICggIWlz
X2hhcmR3YXJlX2RvbWFpbihkb21haW4pICkKLSAgICAgICAgICAgIHJldHVy
biAtRVBFUk07CisgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRVBFUk0p
OwogICAgICAgICBnb3RvIG91dDsKIAogICAgIGNhc2UgREVWX1RZUEVfUENJ
ZV9CUklER0U6CkBAIC0xOTAyLDExICsxOTM5LDkgQEAgc3RhdGljIGludCBk
b21haW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZAogICAgICAgICB7CiAgICAg
ICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWlu
LCBpb21tdSwgdG1wX2J1cywgdG1wX2RldmZuLAogICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lk
KTsKLSAgICAgICAgICAgIGlmICggcmV0ICkKLSAgICAgICAgICAgICAgICBy
ZXR1cm4gcmV0OwotCi0gICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4
dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgc2VjYnVzLCAwLAotICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+
ZG9tYWluX2lkKTsKKyAgICAgICAgICAgIGlmICggIXJldCApCisgICAgICAg
ICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFp
biwgaW9tbXUsIHNlY2J1cywgMCwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOwog
ICAgICAgICB9CiAgICAgICAgIGVsc2UgLyogTGVnYWN5IFBDSSBicmlkZ2Ug
Ki8KICAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29u
ZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4sCkBAIC0xOTI2
LDcgKzE5NjEsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X3VubWFw
KHN0cnVjdCBkCiAgICAgICAgIGNoZWNrX2NsZWFudXBfZG9taWRfbWFwKGRv
bWFpbiwgcGRldiwgaW9tbXUpOwogCiBvdXQ6Ci0gICAgcmV0dXJuIHJldDsK
KyAgICByZXR1cm4gcmV0ID8gRVJSX1BUUihyZXQpIDogZHJoZDsKIH0KIAog
c3RhdGljIHZvaWQgaW9tbXVfZG9tYWluX3RlYXJkb3duKHN0cnVjdCBkb21h
aW4gKmQpCkBAIC0yMTUyLDE2ICsyMTg3LDE3IEBAIHN0YXRpYyBpbnQgaW50
ZWxfaW9tbXVfZW5hYmxlX2RldmljZShzdHIKIAogc3RhdGljIGludCBpbnRl
bF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2Rl
diAqcGRldikKIHsKKyAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQg
KmRyaGQ7CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwogICAg
IHUxNiBiZGY7Ci0gICAgaW50IHJldCwgaTsKKyAgICB1bnNpZ25lZCBpbnQg
aTsKIAogICAgIGlmICggIXBkZXYtPmRvbWFpbiApCiAgICAgICAgIHJldHVy
biAtRUlOVkFMOwogCi0gICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAo
cGRldi0+ZG9tYWluLCBkZXZmbiwgcGRldik7Ci0gICAgaWYgKCByZXQgKQot
ICAgICAgICByZXR1cm4gcmV0OworICAgIGRyaGQgPSBkb21haW5fY29udGV4
dF91bm1hcChwZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKKyAgICBpZiAo
IElTX0VSUihkcmhkKSApCisgICAgICAgIHJldHVybiBQVFJfRVJSKGRyaGQp
OwogCiAgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2UgKCBybXJyLCBiZGYsIGkg
KQogICAgIHsKQEAgLTIxNzgsNiArMjIxNCwxMyBAQCBzdGF0aWMgaW50IGlu
dGVsX2lvbW11X3JlbW92ZV9kZXZpY2UodTgKICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7CiAgICAgfQog
CisgICAgaWYgKCBkcmhkICkKKyAgICB7CisgICAgICAgIGlvbW11X2ZyZWVf
ZG9taWQocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgZHJoZC0+aW9tbXUtPnBzZXVkb19kb21pZF9tYXApOwor
ICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlEX0lOVkFM
SUQ7CisgICAgfQorCiAgICAgcmV0dXJuIDA7CiB9CiAKLS0tIGEveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgKKysrIGIveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgKQEAgLTU0MSw2ICs1NDEsNyBA
QCBzdHJ1Y3QgaW9tbXUgewogICAgIHN0cnVjdCBtc2lfZGVzYyBtc2k7CiAg
ICAgc3RydWN0IGludGVsX2lvbW11ICppbnRlbDsKICAgICBzdHJ1Y3QgbGlz
dF9oZWFkIGF0c19kZXZpY2VzOworICAgIHVuc2lnbmVkIGxvbmcgKnBzZXVk
b19kb21pZF9tYXA7IC8qICJwc2V1ZG8iIGRvbWFpbiBpZCBiaXRtYXAgKi8K
ICAgICB1bnNpZ25lZCBsb25nICpkb21pZF9iaXRtYXA7ICAvKiBkb21haW4g
aWQgYml0bWFwICovCiAgICAgdTE2ICpkb21pZF9tYXA7ICAgICAgICAgICAg
ICAgLyogZG9tYWluIGlkIG1hcHBpbmcgYXJyYXkgKi8KIH07Ci0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21tdS5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21tdS5jCkBAIC0zNzMsNiArMzcz
LDUzIEBAIHZvaWQgX19od2RvbV9pbml0IGFyY2hfaW9tbXVfaHdkb21faW5p
dCgKICAgICAgICAgcmV0dXJuOwogfQogCit1bnNpZ25lZCBsb25nICpfX2lu
aXQgaW9tbXVfaW5pdF9kb21pZCh2b2lkKQoreworICAgIGlmICggIWlvbW11
X3F1YXJhbnRpbmUgKQorICAgICAgICByZXR1cm4gWkVST19CTE9DS19QVFI7
CisKKyAgICBCVUlMRF9CVUdfT04oRE9NSURfTUFTSyAqIDJVID49IFVJTlQx
Nl9NQVgpOworCisgICAgcmV0dXJuIHh6YWxsb2NfYXJyYXkodW5zaWduZWQg
bG9uZywKKyAgICAgICAgICAgICAgICAgICAgICAgICBCSVRTX1RPX0xPTkdT
KFVJTlQxNl9NQVggLSBET01JRF9NQVNLKSk7Cit9CisKK2RvbWlkX3QgaW9t
bXVfYWxsb2NfZG9taWQodW5zaWduZWQgbG9uZyAqbWFwKQoreworICAgIC8q
CisgICAgICogVGhpcyBpcyB1c2VkIHVuaWZvcm1seSBhY3Jvc3MgYWxsIElP
TU1Vcywgc3VjaCB0aGF0IG9uIHR5cGljYWwKKyAgICAgKiBzeXN0ZW1zIHdl
IHdvdWxkbid0IHJlLXVzZSB0aGUgc2FtZSBJRCB2ZXJ5IHF1aWNrbHkgKHBl
cmhhcHMgbmV2ZXIpLgorICAgICAqLworICAgIHN0YXRpYyB1bnNpZ25lZCBp
bnQgc3RhcnQ7CisgICAgdW5zaWduZWQgaW50IGlkeCA9IGZpbmRfbmV4dF96
ZXJvX2JpdChtYXAsIFVJTlQxNl9NQVggLSBET01JRF9NQVNLLCBzdGFydCk7
CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CisKKyAgICBpZiAo
IGlkeCA+PSBVSU5UMTZfTUFYIC0gRE9NSURfTUFTSyApCisgICAgICAgIGlk
eCA9IGZpbmRfZmlyc3RfemVyb19iaXQobWFwLCBVSU5UMTZfTUFYIC0gRE9N
SURfTUFTSyk7CisgICAgaWYgKCBpZHggPj0gVUlOVDE2X01BWCAtIERPTUlE
X01BU0sgKQorICAgICAgICByZXR1cm4gRE9NSURfSU5WQUxJRDsKKworICAg
IF9fc2V0X2JpdChpZHgsIG1hcCk7CisKKyAgICBzdGFydCA9IGlkeCArIDE7
CisKKyAgICByZXR1cm4gaWR4IHwgKERPTUlEX01BU0sgKyAxKTsKK30KKwor
dm9pZCBpb21tdV9mcmVlX2RvbWlkKGRvbWlkX3QgZG9taWQsIHVuc2lnbmVk
IGxvbmcgKm1hcCkKK3sKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7
CisKKyAgICBpZiAoIGRvbWlkID09IERPTUlEX0lOVkFMSUQgKQorICAgICAg
ICByZXR1cm47CisKKyAgICBBU1NFUlQoZG9taWQgPiBET01JRF9NQVNLKTsK
KworICAgIGlmICggIV9fdGVzdF9hbmRfY2xlYXJfYml0KGRvbWlkICYgRE9N
SURfTUFTSywgbWFwKSApCisgICAgICAgIEJVRygpOworfQorCiAvKgogICog
TG9jYWwgdmFyaWFibGVzOgogICogbW9kZTogQwotLS0gYS94ZW4vaW5jbHVk
ZS9wdWJsaWMveGVuLmgKKysrIGIveGVuL2luY2x1ZGUvcHVibGljL3hlbi5o
CkBAIC01ODQsNiArNTg0LDkgQEAgREVGSU5FX1hFTl9HVUVTVF9IQU5ETEUo
bW11ZXh0X29wX3QpOwogLyogSWRsZSBkb21haW4uICovCiAjZGVmaW5lIERP
TUlEX0lETEUgICAgICAgICAgIHhlbl9ta191aW50KDB4N0ZGRikKIAorLyog
TWFzayBmb3IgdmFsaWQgZG9tYWluIGlkIHZhbHVlcyAqLworI2RlZmluZSBE
T01JRF9NQVNLICAgICAgICAgICB4ZW5fbWtfdWludCgweDdGRkYpCisKICNp
Zm5kZWYgX19BU1NFTUJMWV9fCiAKIHR5cGVkZWYgdWludDE2X3QgZG9taWRf
dDsK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-09.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IGRyb3AgVExCIGZsdXNoZXMgZnJvbSBxdWFyYW50aW5l
X2luaXQoKSBob29rcwoKVGhlIHBhZ2UgdGFibGVzIGp1c3QgY3JlYXRlZCBh
cmVuJ3QgaG9va2VkIHVwIHlldCBhbnl3aGVyZSwgc28gdGhlcmUncwpub3Ro
aW5nIHRoYXQgY291bGQgYmUgcHJlc2VudCBpbiBhbnkgVExCLCBhbmQgaGVu
Y2Ugbm90aGluZyB0byBmbHVzaC4KRHJvcHBpbmcgdGhpcyBmbHVzaCBpcywg
YXQgbGVhc3Qgb24gdGhlIFZULWQgc2lkZSwgYSBwcmVyZXEgdG8gcGVyLQpk
ZXZpY2UgZG9tYWluIElEIHVzZSB3aGVuIHF1YXJhbnRpbmluZyBkZXZpY2Vz
LCBhcyBkb21faW8gaXNuJ3QgZ29pbmcKdG8gYmUgYXNzaWduZWQgYSBESUQg
YW55bW9yZTogVGhlIHdhcm5pbmcgaW4gZ2V0X2lvbW11X2RpZCgpIHdvdWxk
CnRyaWdnZXIuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxA
eGVuLm9yZz4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy
LnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2
aW4udGlhbkBpbnRlbC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11X21hcC5jCkBAIC04NDAsOCArODQwLDYgQEAgaW50
IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cgogIG91dDoK
ICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKIAot
ICAgIGFtZF9pb21tdV9mbHVzaF9hbGxfcGFnZXMoZCk7Ci0KICAgICAvKiBQ
YWdlcyBsZWFrZWQgaW4gZmFpbHVyZSBjYXNlICovCiAgICAgcmV0dXJuIGxl
dmVsID8gLUVOT01FTSA6IDA7CiB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5jCkBAIC0yODU4LDcgKzI4NTgsNiBAQCBzdGF0aWMg
aW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFyYW50aW5lCiAgICAgc3RydWN0
IGRtYV9wdGUgKnBhcmVudDsKICAgICB1bnNpZ25lZCBpbnQgYWdhdyA9IHdp
ZHRoX3RvX2FnYXcoREVGQVVMVF9ET01BSU5fQUREUkVTU19XSURUSCk7CiAg
ICAgdW5zaWduZWQgaW50IGxldmVsID0gYWdhd190b19sZXZlbChhZ2F3KTsK
LSAgICBpbnQgcmM7CiAKICAgICBpZiAoIGhkLT5hcmNoLnBnZF9tYWRkciAp
CiAgICAgewpAQCAtMjkwNSwxMCArMjkwNCw4IEBAIHN0YXRpYyBpbnQgX19p
bml0IGludGVsX2lvbW11X3F1YXJhbnRpbmUKICBvdXQ6CiAgICAgc3Bpbl91
bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAKLSAgICByYyA9IGlv
bW11X2ZsdXNoX2lvdGxiX2FsbChkKTsKLQogICAgIC8qIFBhZ2VzIGxlYWtl
ZCBpbiBmYWlsdXJlIGNhc2UgKi8KLSAgICByZXR1cm4gbGV2ZWwgPyAtRU5P
TUVNIDogcmM7CisgICAgcmV0dXJuIGxldmVsID8gLUVOT01FTSA6IDA7CiB9
CiAKIGNvbnN0IHN0cnVjdCBpb21tdV9vcHMgX19pbml0Y29uc3RyZWwgaW50
ZWxfaW9tbXVfb3BzID0gewo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-10.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IGFic3RyYWN0IG1heGltdW0gbnVtYmVyIG9mIHBhZ2Ug
dGFibGUgbGV2ZWxzCgpXZSB3aWxsIHdhbnQgdG8gdXNlIHRoZSBjb25zdGFu
dCBlbHNld2hlcmUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBh
dWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3N2
bS9hbWQtaW9tbXUtcHJvdG8uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2
L2h2bS9zdm0vYW1kLWlvbW11LXByb3RvLmgKQEAgLTE4NSw3ICsxODUsNyBA
QCBzdGF0aWMgaW5saW5lIGludCBhbWRfaW9tbXVfZ2V0X3BhZ2luZ19tCiAg
ICAgd2hpbGUgKCBtYXhfZnJhbWVzID4gUFRFX1BFUl9UQUJMRV9TSVpFICkK
ICAgICB7CiAgICAgICAgIG1heF9mcmFtZXMgPSBQVEVfUEVSX1RBQkxFX0FM
SUdOKG1heF9mcmFtZXMpID4+IFBURV9QRVJfVEFCTEVfU0hJRlQ7Ci0gICAg
ICAgIGlmICggKytsZXZlbCA+IDYgKQorICAgICAgICBpZiAoICsrbGV2ZWwg
PiBJT01NVV9NQVhfUFRfTEVWRUxTICkKICAgICAgICAgICAgIHJldHVybiAt
RU5PTUVNOwogICAgIH0KIAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2h2
bS9zdm0vYW1kLWlvbW11LWRlZnMuaAorKysgYi94ZW4vaW5jbHVkZS9hc20t
eDg2L2h2bS9zdm0vYW1kLWlvbW11LWRlZnMuaApAQCAtMTE0LDYgKzExNCw4
IEBACiAjZGVmaW5lIElPTU1VX0RFVl9UQUJMRV9QQUdFX1RBQkxFX1BUUl9M
T1dfTUFTSwkJMHhGRkZGRjAwMAogI2RlZmluZSBJT01NVV9ERVZfVEFCTEVf
UEFHRV9UQUJMRV9QVFJfTE9XX1NISUZUCTEyCiAKKyNkZWZpbmUgSU9NTVVf
TUFYX1BUX0xFVkVMUyA2CisKIC8qIERldmljZVRhYmxlIEVudHJ5WzYzOjMy
XSAqLwogI2RlZmluZSBJT01NVV9ERVZfVEFCTEVfR1ZfU0hJRlQgICAgICAg
ICAgICAgICAgICAgIDIzCiAjZGVmaW5lIElPTU1VX0RFVl9UQUJMRV9HVl9N
QVNLICAgICAgICAgICAgICAgICAgICAgMHg4MDAwMDAKLS0tIGEveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYwpAQCAtNDc3LDcg
KzQ3Nyw3IEBAIHN0YXRpYyBpbnQgaW9tbXVfcGRlX2Zyb21fZGZuKHN0cnVj
dCBkb20KICAgICB0YWJsZSA9IGhkLT5hcmNoLnJvb3RfdGFibGU7CiAgICAg
bGV2ZWwgPSBoZC0+YXJjaC5wYWdpbmdfbW9kZTsKIAotICAgIEJVR19PTigg
dGFibGUgPT0gTlVMTCB8fCBsZXZlbCA8IDEgfHwgbGV2ZWwgPiA2ICk7Cisg
ICAgQlVHX09OKCB0YWJsZSA9PSBOVUxMIHx8IGxldmVsIDwgMSB8fCBsZXZl
bCA+IElPTU1VX01BWF9QVF9MRVZFTFMgKTsKIAogICAgIC8qCiAgICAgICog
QSBmcmFtZSBudW1iZXIgcGFzdCB3aGF0IHRoZSBjdXJyZW50IHBhZ2UgdGFi
bGVzIGNhbiByZXByZXNlbnQgY2FuJ3QK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.12-11.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.12-11.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHVzZSBwZXItZGV2aWNlIHBhZ2UgdGFibGVzIGZvciBx
dWFyYW50aW5pbmcKCkRldmljZXMgd2l0aCBSTVJScyAvIHVuaXR5IG1hcHBl
ZCByZWdpb25zLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQKaG93L3do
ZW4gdGhlc2UgbWVtb3J5IHJlZ2lvbnMgbWF5IGJlIGFjY2Vzc2VkLCBtYXkg
bm90IGJlIGxlZnQKZGlzY29ubmVjdGVkIGZyb20gdGhlIG1hcHBpbmdzIG9m
IHRoZXNlIHJlZ2lvbnMgKGFzIGxvbmcgYXMgaXQncyBub3QKY2VydGFpbiB0
aGF0IHRoZSBkZXZpY2UgaGFzIGJlZW4gZnVsbHkgcXVpZXNjZWQpLiBIZW5j
ZSBldmVuIHRoZSBwYWdlCnRhYmxlcyB1c2VkIHdoZW4gcXVhcmFudGluaW5n
IHN1Y2ggZGV2aWNlcyBuZWVkIHRvIGhhdmUgbWFwcGluZ3Mgb2YKdGhvc2Ug
cmVnaW9ucy4gVGhpcyBpbXBsaWVzIGluc3RhbGxpbmcgcGFnZSB0YWJsZXMg
aW4gdGhlIGZpcnN0IHBsYWNlCmV2ZW4gd2hlbiBub3QgaW4gc2NyYXRjaC1w
YWdlIHF1YXJhbnRpbmluZyBtb2RlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM2
MSAvIHBhcnQgb2YgWFNBLTQwMC4KCldoaWxlIGZvciB0aGUgcHVycG9zZSBo
ZXJlIGl0IHdvdWxkIGJlIHN1ZmZpY2llbnQgdG8gaGF2ZSBkZXZpY2VzIHdp
dGgKUk1SUnMgLyB1bml0eSBtYXBwZWQgcmVnaW9ucyB1c2UgcGVyLWRldmlj
ZSBwYWdlIHRhYmxlcywgZXh0ZW5kIHRoaXMgdG8KYWxsIGRldmljZXMgKGlu
IHNjcmF0Y2gtcGFnZSBxdWFyYW50aW5pbmcgbW9kZSkuIFRoaXMgYWxsb3dz
IHRoZSBsZWFmCnBhZ2VzIHRvIGJlIG1hcHBlZCByL3csIHRodXMgY292ZXJp
bmcgYWxzbyBtZW1vcnkgd3JpdGVzIChyYXRoZXIgdGhhbgpqdXN0IHJlYWRz
KSBpc3N1ZWQgYnkgbm9uLXF1aWVzY2VudCBkZXZpY2VzLgoKU2V0IHVwIHF1
YXJhbnRpbmUgcGFnZSB0YWJsZXMgYXMgbGF0ZSBhcyBwb3NzaWJsZSwgeWV0
IGVhcmx5IGVub3VnaCB0bwpub3QgZW5jb3VudGVyIGZhaWx1cmUgZHVyaW5n
IGRlLWFzc2lnbi4gVGhpcyBtZWFucyBzZXR1cCBnZW5lcmFsbHkKaGFwcGVu
cyBpbiBhc3NpZ25fZGV2aWNlKCksIHdoaWxlIChmb3Igbm93KSB0aGUgb25l
IGluIGRlYXNzaWduX2RldmljZSgpCmlzIHRoZXJlIG1haW5seSB0byBiZSBv
biB0aGUgc2FmZSBzaWRlLgoKSW4gVlQtZCdzIERJRCBhbGxvY2F0aW9uIGZ1
bmN0aW9uIGRvbid0IHJlcXVpcmUgdGhlIElPTU1VIGxvY2sgdG8gYmUKaGVs
ZCBhbnltb3JlOiBBbGwgaW52b2x2ZWQgY29kZSBwYXRocyBob2xkIHBjaWRl
dnNfbG9jaywgc28gdGhpcyB3YXkgd2UKYXZvaWQgdGhlIG5lZWQgdG8gYWNx
dWlyZSB0aGUgSU9NTVUgbG9jayBhcm91bmQgdGhlIG5ldyBjYWxsIHRvCmNv
bnRleHRfc2V0X2RvbWFpbl9pZCgpLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBE
dXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFu
IDxrZXZpbi50aWFuQGludGVsLmNvbT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBh
dSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKLS0tIGEveGVuL2Fy
Y2gveDg2L21tL3AybS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpA
QCAtMTQyNCw3ICsxNDI0LDcgQEAgaW50IHNldF9pZGVudGl0eV9wMm1fZW50
cnkoc3RydWN0IGRvbWFpbgogICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0g
PSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJldDsKIAotICAgIGlm
ICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShwMm0tPmRvbWFpbikgKQorICAg
IGlmICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShkKSApCiAgICAgewogICAg
ICAgICBpZiAoICFoYXNfaW9tbXVfcHQoZCkgKQogICAgICAgICAgICAgcmV0
dXJuIDA7Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgKKysrIGIv
eGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaApAQCAtMSw2ICsxLDggQEAKICNp
Zm5kZWYgX19YODZfUENJX0hfXwogI2RlZmluZSBfX1g4Nl9QQ0lfSF9fCiAK
KyNpbmNsdWRlIDx4ZW4vbW0uaD4KKwogI2RlZmluZSBDRjhfQkRGKGNmOCkg
ICAgICggICgoY2Y4KSAmIDB4MDBmZmZmMDApID4+IDgpCiAjZGVmaW5lIENG
OF9BRERSX0xPKGNmOCkgKCAgIChjZjgpICYgMHgwMDAwMDBmYykKICNkZWZp
bmUgQ0Y4X0FERFJfSEkoY2Y4KSAoICAoKGNmOCkgJiAweDBmMDAwMDAwKSA+
PiAxNikKQEAgLTIwLDcgKzIyLDE4IEBAIHN0cnVjdCBhcmNoX3BjaV9kZXYg
ewogICAgICAqIHRoZW0gZG9uJ3QgcmFjZSAoZGUpaW5pdGlhbGl6YXRpb24g
YW5kIGhlbmNlIGRvbid0IHN0cmljdGx5IG5lZWQgYW55CiAgICAgICogbG9j
a2luZy4KICAgICAgKi8KKyAgICB1bmlvbiB7CisgICAgICAgIC8qIFN1YnNl
dCBvZiBzdHJ1Y3QgYXJjaF9pb21tdSdzIGZpZWxkcywgdG8gYmUgdXNlZCBp
biBkb21faW8uICovCisgICAgICAgIHN0cnVjdCB7CisgICAgICAgICAgICB1
aW50NjRfdCBwZ2RfbWFkZHI7CisgICAgICAgIH0gdnRkOworICAgICAgICBz
dHJ1Y3QgeworICAgICAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcm9vdF90
YWJsZTsKKyAgICAgICAgfSBhbWQ7CisgICAgfTsKICAgICBkb21pZF90IHBz
ZXVkb19kb21pZDsKKyAgICBtZm5fdCBsZWFmX21mbjsKKyAgICBzdHJ1Y3Qg
cGFnZV9saXN0X2hlYWQgcGd0YWJsZXNfbGlzdDsKIH07CiAKIGludCBwY2lf
Y29uZl93cml0ZV9pbnRlcmNlcHQodW5zaWduZWQgaW50IHNlZywgdW5zaWdu
ZWQgaW50IGJkZiwKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3Zt
L2FtZC1pb21tdS1wcm90by5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYv
aHZtL3N2bS9hbWQtaW9tbXUtcHJvdG8uaApAQCAtNTEsNyArNTEsOCBAQCB2
b2lkIGdldF9pb21tdV9mZWF0dXJlcyhzdHJ1Y3QgYW1kX2lvbW11CiBpbnQg
YW1kX2lvbW11X2luaXQodm9pZCk7CiBpbnQgYW1kX2lvbW11X3VwZGF0ZV9p
dnJzX21hcHBpbmdfYWNwaSh2b2lkKTsKIAotaW50IGFtZF9pb21tdV9xdWFy
YW50aW5lX2luaXQoc3RydWN0IGRvbWFpbiAqZCk7CitpbnQgYW1kX2lvbW11
X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3QgcGNpX2RldiAqcGRldik7Cit2b2lk
IGFtZF9pb21tdV9xdWFyYW50aW5lX3RlYXJkb3duKHN0cnVjdCBwY2lfZGV2
ICpwZGV2KTsKIAogLyogbWFwcGluZyBmdW5jdGlvbnMgKi8KIGludCBfX211
c3RfY2hlY2sgYW1kX2lvbW11X21hcF9wYWdlKHN0cnVjdCBkb21haW4gKmQs
IGRmbl90IGRmbiwKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1k
L2lvbW11X21hcC5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft
ZC9pb21tdV9tYXAuYwpAQCAtNzg0LDY0ICs3ODQsMTUwIEBAIHZvaWQgYW1k
X2lvbW11X3NoYXJlX3AybShzdHJ1Y3QgZG9tYWluICoKICAgICB9CiB9CiAK
LWludCBfX2luaXQgYW1kX2lvbW11X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3Qg
ZG9tYWluICpkKQorc3RhdGljIGludCBmaWxsX3FwdCh1aW50NjRfdCAqdGhp
cywgdW5zaWduZWQgaW50IGxldmVsLAorICAgICAgICAgICAgICAgICAgICBz
dHJ1Y3QgcGFnZV9pbmZvICpwZ3NbSU9NTVVfTUFYX1BUX0xFVkVMU10sCisg
ICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQogewot
ICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwor
ICAgIHVuc2lnbmVkIGludCBpOworICAgIGludCByYyA9IDA7CisKKyAgICBm
b3IgKCBpID0gMDsgIXJjICYmIGkgPCBQVEVfUEVSX1RBQkxFX1NJWkU7ICsr
aSApCisgICAgeworICAgICAgICB1aW50MzJfdCAqcHRlID0gKHVpbnQzMl90
ICopJnRoaXNbaV07CisgICAgICAgIHVpbnQ2NF90ICpuZXh0OworCisgICAg
ICAgIGlmICggIWdldF9maWVsZF9mcm9tX3JlZ191MzIocHRlWzBdLCBJT01N
VV9QVEVfUFJFU0VOVF9NQVNLLAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIElPTU1VX1BURV9QUkVTRU5UX1NISUZUKSApCisgICAg
ICAgIHsKKyAgICAgICAgICAgIGlmICggIXBnc1tsZXZlbF0gKQorICAgICAg
ICAgICAgeworICAgICAgICAgICAgICAgIC8qCisgICAgICAgICAgICAgICAg
ICogVGhlIHBndGFibGUgYWxsb2NhdG9yIGlzIGZpbmUgZm9yIHRoZSBsZWFm
IHBhZ2UsIGFzIHdlbGwgYXMKKyAgICAgICAgICAgICAgICAgKiBwYWdlIHRh
YmxlIHBhZ2VzLCBhbmQgdGhlIHJlc3VsdGluZyBhbGxvY2F0aW9ucyBhcmUg
YWx3YXlzCisgICAgICAgICAgICAgICAgICogemVyb2VkLgorICAgICAgICAg
ICAgICAgICAqLworICAgICAgICAgICAgICAgIHBnc1tsZXZlbF0gPSBhbGxv
Y19hbWRfaW9tbXVfcGd0YWJsZSgpOworICAgICAgICAgICAgICAgIGlmICgg
IXBnc1tsZXZlbF0gKQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAg
ICAgICAgICAgcmMgPSAtRU5PTUVNOworICAgICAgICAgICAgICAgICAgICBi
cmVhazsKKyAgICAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICAgICBw
YWdlX2xpc3RfYWRkKHBnc1tsZXZlbF0sICZwZGV2LT5hcmNoLnBndGFibGVz
X2xpc3QpOworCisgICAgICAgICAgICAgICAgaWYgKCBsZXZlbCApCisgICAg
ICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAgICBuZXh0ID0gX19t
YXBfZG9tYWluX3BhZ2UocGdzW2xldmVsXSk7CisgICAgICAgICAgICAgICAg
ICAgIHJjID0gZmlsbF9xcHQobmV4dCwgbGV2ZWwgLSAxLCBwZ3MsIHBkZXYp
OworICAgICAgICAgICAgICAgICAgICB1bm1hcF9kb21haW5fcGFnZShuZXh0
KTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisKKyAgICAg
ICAgICAgIC8qCisgICAgICAgICAgICAgKiBQREVzIGFyZSBlc3NlbnRpYWxs
eSBhIHN1YnNldCBvZiBQVEVzLCBzbyB0aGlzIGZ1bmN0aW9uCisgICAgICAg
ICAgICAgKiBpcyBmaW5lIHRvIHVzZSBldmVuIGF0IHRoZSBsZWFmLgorICAg
ICAgICAgICAgICovCisgICAgICAgICAgICBzZXRfaW9tbXVfcGRlX3ByZXNl
bnQocHRlLCBtZm5feChwYWdlX3RvX21mbihwZ3NbbGV2ZWxdKSksIGxldmVs
LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUsIHRy
dWUpOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKCBsZXZlbCAmJgor
ICAgICAgICAgICAgICAgICAgZ2V0X2ZpZWxkX2Zyb21fcmVnX3UzMihwdGVb
MF0sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IElPTU1VX1BERV9ORVhUX0xFVkVMX01BU0ssCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1VX1BERV9ORVhUX0xFVkVM
X1NISUZUKSApCisgICAgICAgIHsKKyAgICAgICAgICAgIHBhZGRyX3QgYWRk
cl9oaSA9IGdldF9maWVsZF9mcm9tX3JlZ191MzIocHRlWzFdLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBJT01NVV9QVEVfQUREUl9ISUdIX01BU0ssCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1VX1BU
RV9BRERSX0hJR0hfU0hJRlQpOworICAgICAgICAgICAgcGFkZHJfdCBhZGRy
X2xvID0gZ2V0X2ZpZWxkX2Zyb21fcmVnX3UzMihwdGVbMF0sCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IElPTU1VX1BURV9BRERSX0xPV19NQVNLLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJT01NVV9QVEVf
QUREUl9MT1dfU0hJRlQpOworICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBt
Zm4gPSAoYWRkcl9oaSA8PCAoMzIgLSBQQUdFX1NISUZUKSkgfCBhZGRyX2xv
OworCisgICAgICAgICAgICBwYWdlX2xpc3RfYWRkKG1mbl90b19wYWdlKF9t
Zm4obWZuKSksICZwZGV2LT5hcmNoLnBndGFibGVzX2xpc3QpOworICAgICAg
ICAgICAgbmV4dCA9IG1hcF9kb21haW5fcGFnZShfbWZuKG1mbikpOworICAg
ICAgICAgICAgcmMgPSBmaWxsX3FwdChuZXh0LCBsZXZlbCAtIDEsIHBncywg
cGRldik7CisgICAgICAgICAgICB1bm1hcF9kb21haW5fcGFnZShuZXh0KTsK
KyAgICAgICAgfQorICAgIH0KKworICAgIHJldHVybiByYzsKK30KKworaW50
IGFtZF9pb21tdV9xdWFyYW50aW5lX2luaXQoc3RydWN0IHBjaV9kZXYgKnBk
ZXYpCit7CisgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9t
bXUoZG9tX2lvKTsKICAgICB1bnNpZ25lZCBsb25nIGVuZF9nZm4gPQogICAg
ICAgICAxdWwgPDwgKERFRkFVTFRfRE9NQUlOX0FERFJFU1NfV0lEVEggLSBQ
QUdFX1NISUZUKTsKICAgICB1bnNpZ25lZCBpbnQgbGV2ZWwgPSBhbWRfaW9t
bXVfZ2V0X3BhZ2luZ19tb2RlKGVuZF9nZm4pOwotICAgIHVpbnQ2NF90ICp0
YWJsZTsKKyAgICB1bnNpZ25lZCBpbnQgcmVxX2lkID0gZ2V0X2RtYV9yZXF1
ZXN0b3JfaWQocGRldi0+c2VnLAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBQQ0lfQkRGMihwZGV2LT5idXMsIHBk
ZXYtPmRldmZuKSk7CisgICAgY29uc3Qgc3RydWN0IGl2cnNfbWFwcGluZ3Mg
Kml2cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBwaW5ncyhwZGV2LT5zZWcp
OworICAgIGludCByYzsKIAotICAgIGlmICggaGQtPmFyY2gucm9vdF90YWJs
ZSApCisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOworICAgIEFTU0VS
VCghaGQtPmFyY2gucm9vdF90YWJsZSk7CisKKyAgICBBU1NFUlQocGRldi0+
YXJjaC5wc2V1ZG9fZG9taWQgIT0gRE9NSURfSU5WQUxJRCk7CisKKyAgICBp
ZiAoIHBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGUgKQogICAgIHsKLSAgICAg
ICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7CisgICAgICAgIGNsZWFyX2RvbWFp
bl9wYWdlKHBkZXYtPmFyY2gubGVhZl9tZm4pOwogICAgICAgICByZXR1cm4g
MDsKICAgICB9CiAKLSAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdf
bG9jayk7Ci0KLSAgICBoZC0+YXJjaC5yb290X3RhYmxlID0gYWxsb2NfYW1k
X2lvbW11X3BndGFibGUoKTsKLSAgICBpZiAoICFoZC0+YXJjaC5yb290X3Rh
YmxlICkKLSAgICAgICAgZ290byBvdXQ7Ci0KLSAgICB0YWJsZSA9IF9fbWFw
X2RvbWFpbl9wYWdlKGhkLT5hcmNoLnJvb3RfdGFibGUpOwotICAgIHdoaWxl
ICggbGV2ZWwgKQorICAgIHBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGUgPSBh
bGxvY19hbWRfaW9tbXVfcGd0YWJsZSgpOworICAgIGlmICggIXBkZXYtPmFy
Y2guYW1kLnJvb3RfdGFibGUgKQorICAgICAgICByZXR1cm4gLUVOT01FTTsK
KworICAgIC8qIFRyYW5zaWVudGx5IGluc3RhbGwgdGhlIHJvb3QgaW50byBE
b21JTywgZm9yIGlvbW11X2lkZW50aXR5X21hcHBpbmcoKS4gKi8KKyAgICBo
ZC0+YXJjaC5yb290X3RhYmxlID0gcGRldi0+YXJjaC5hbWQucm9vdF90YWJs
ZTsKKworICAgIHJjID0gYW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5
X21hcChkb21faW8sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbcmVxX2lkXS51bml0eV9tYXAs
CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IDApOworCisgICAgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKGRvbV9p
byk7CisgICAgaGQtPmFyY2gucm9vdF90YWJsZSA9IE5VTEw7CisKKyAgICBp
ZiAoIHJjICkKKyAgICAgICAgcHJpbnRrKCIlMDR4OiUwMng6JTAyeC4ldTog
cXVhcmFudGluZSB1bml0eSBtYXBwaW5nIGZhaWxlZFxuIiwKKyAgICAgICAg
ICAgICAgIHBkZXYtPnNlZywgcGRldi0+YnVzLAorICAgICAgICAgICAgICAg
UENJX1NMT1QocGRldi0+ZGV2Zm4pLCBQQ0lfRlVOQyhwZGV2LT5kZXZmbikp
OworICAgIGVsc2UKICAgICB7Ci0gICAgICAgIHN0cnVjdCBwYWdlX2luZm8g
KnBnOwotICAgICAgICB1bnNpZ25lZCBpbnQgaTsKKyAgICAgICAgdWludDY0
X3QgKnJvb3Q7CisgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnc1tJT01N
VV9NQVhfUFRfTEVWRUxTXSA9IHt9OwogCi0gICAgICAgIC8qCi0gICAgICAg
ICAqIFRoZSBwZ3RhYmxlIGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUgbGVh
ZiBwYWdlLCBhcyB3ZWxsIGFzCi0gICAgICAgICAqIHBhZ2UgdGFibGUgcGFn
ZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMK
LSAgICAgICAgICogemVyb2VkLgotICAgICAgICAgKi8KLSAgICAgICAgcGcg
PSBhbGxvY19hbWRfaW9tbXVfcGd0YWJsZSgpOwotICAgICAgICBpZiAoICFw
ZyApCi0gICAgICAgICAgICBicmVhazsKKyAgICAgICAgc3Bpbl9sb2NrKCZo
ZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogCi0gICAgICAgIGZvciAoIGkgPSAw
OyBpIDwgUFRFX1BFUl9UQUJMRV9TSVpFOyBpKysgKQotICAgICAgICB7Ci0g
ICAgICAgICAgICB1aW50MzJfdCAqcGRlID0gKHVpbnQzMl90ICopJnRhYmxl
W2ldOworICAgICAgICByb290ID0gX19tYXBfZG9tYWluX3BhZ2UocGRldi0+
YXJjaC5hbWQucm9vdF90YWJsZSk7CisgICAgICAgIHJjID0gZmlsbF9xcHQo
cm9vdCwgbGV2ZWwgLSAxLCBwZ3MsIHBkZXYpOworICAgICAgICB1bm1hcF9k
b21haW5fcGFnZShyb290KTsKIAotICAgICAgICAgICAgLyoKLSAgICAgICAg
ICAgICAqIFBERXMgYXJlIGVzc2VudGlhbGx5IGEgc3Vic2V0IG9mIFBURXMs
IHNvIHRoaXMgZnVuY3Rpb24KLSAgICAgICAgICAgICAqIGlzIGZpbmUgdG8g
dXNlIGV2ZW4gYXQgdGhlIGxlYWYuCi0gICAgICAgICAgICAgKi8KLSAgICAg
ICAgICAgIHNldF9pb21tdV9wZGVfcHJlc2VudChwZGUsIG1mbl94KHBhZ2Vf
dG9fbWZuKHBnKSksIGxldmVsIC0gMSwKLSAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBmYWxzZSwgdHJ1ZSk7Ci0gICAgICAgIH0KKyAgICAg
ICAgcGRldi0+YXJjaC5sZWFmX21mbiA9IHBhZ2VfdG9fbWZuKHBnc1swXSk7
CiAKLSAgICAgICAgdW5tYXBfZG9tYWluX3BhZ2UodGFibGUpOwotICAgICAg
ICB0YWJsZSA9IF9fbWFwX2RvbWFpbl9wYWdlKHBnKTsKLSAgICAgICAgbGV2
ZWwtLTsKKyAgICAgICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdf
bG9jayk7CiAgICAgfQotICAgIHVubWFwX2RvbWFpbl9wYWdlKHRhYmxlKTsK
IAotIG91dDoKLSAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19s
b2NrKTsKKyAgICBpZiAoIHJjICkKKyAgICAgICAgYW1kX2lvbW11X3F1YXJh
bnRpbmVfdGVhcmRvd24ocGRldik7CisKKyAgICByZXR1cm4gcmM7Cit9CisK
K3ZvaWQgYW1kX2lvbW11X3F1YXJhbnRpbmVfdGVhcmRvd24oc3RydWN0IHBj
aV9kZXYgKnBkZXYpCit7CisgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7CisK
KyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CisKKyAgICBpZiAoICFw
ZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlICkKKyAgICAgICAgcmV0dXJuOwor
CisgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hlYWQoJnBk
ZXYtPmFyY2gucGd0YWJsZXNfbGlzdCkpICkKKyAgICAgICAgZnJlZV9hbWRf
aW9tbXVfcGd0YWJsZShwZyk7CiAKLSAgICAvKiBQYWdlcyBsZWFrZWQgaW4g
ZmFpbHVyZSBjYXNlICovCi0gICAgcmV0dXJuIGxldmVsID8gLUVOT01FTSA6
IDA7CisgICAgcGRldi0+YXJjaC5hbWQucm9vdF90YWJsZSA9IE5VTEw7CiB9
CiAKIC8qCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lf
YW1kX2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1k
L3BjaV9hbWRfaW9tbXUuYwpAQCAtMTUwLDYgKzE1MCw4IEBAIHN0YXRpYyBp
bnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICB1OCBidXMg
PSBwZGV2LT5idXM7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBk
b21faW9tbXUoZG9tYWluKTsKICAgICBjb25zdCBzdHJ1Y3QgaXZyc19tYXBw
aW5ncyAqaXZyc19kZXY7CisgICAgY29uc3Qgc3RydWN0IHBhZ2VfaW5mbyAq
cm9vdF9wZzsKKyAgICBkb21pZF90IGRvbWlkOwogCiAgICAgQlVHX09OKCFo
ZC0+YXJjaC5wYWdpbmdfbW9kZSB8fCAhaW9tbXUtPmRldl90YWJsZS5idWZm
ZXIpOwogCkBAIC0xNzIsMTQgKzE3NCwyNSBAQCBzdGF0aWMgaW50IF9fbXVz
dF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfCiAgICAgZHRlID0gaW9tbXUtPmRl
dl90YWJsZS5idWZmZXIgKyAocmVxX2lkICogSU9NTVVfREVWX1RBQkxFX0VO
VFJZX1NJWkUpOwogICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21hcHBpbmdz
KGlvbW11LT5zZWcpW3JlcV9pZF07CiAKKyAgICBpZiAoIGRvbWFpbiAhPSBk
b21faW8gKQorICAgIHsKKyAgICAgICAgcm9vdF9wZyA9IGhkLT5hcmNoLnJv
b3RfdGFibGU7CisgICAgICAgIGRvbWlkID0gZG9tYWluLT5kb21haW5faWQ7
CisgICAgfQorICAgIGVsc2UKKyAgICB7CisgICAgICAgIHJvb3RfcGcgPSBw
ZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlOworICAgICAgICBkb21pZCA9IHBk
ZXYtPmFyY2gucHNldWRvX2RvbWlkOworICAgIH0KKwogICAgIHNwaW5fbG9j
a19pcnFzYXZlKCZpb21tdS0+bG9jaywgZmxhZ3MpOwogCiAgICAgaWYgKCAh
aXNfdHJhbnNsYXRpb25fdmFsaWQoKHUzMiAqKWR0ZSkgKQogICAgIHsKICAg
ICAgICAgLyogYmluZCBEVEUgdG8gZG9tYWluIHBhZ2UtdGFibGVzICovCiAg
ICAgICAgIHJjID0gYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoCi0g
ICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkcihoZC0+YXJjaC5y
b290X3RhYmxlKSwKLSAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5f
aWQsIGhkLT5hcmNoLnBhZ2luZ19tb2RlLCBzcl9mbGFncyk7CisgICAgICAg
ICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkcihyb290X3BnKSwgZG9taWQs
CisgICAgICAgICAgICAgICAgIGhkLT5hcmNoLnBhZ2luZ19tb2RlLCBzcl9m
bGFncyk7CiAgICAgICAgIGlmICggcmMgKQogICAgICAgICB7CiAgICAgICAg
ICAgICBBU1NFUlQocmMgPCAwKTsKQEAgLTE5Myw4ICsyMDYsNyBAQCBzdGF0
aWMgaW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfCiAKICAgICAg
ICAgYW1kX2lvbW11X2ZsdXNoX2RldmljZShpb21tdSwgcmVxX2lkKTsKICAg
ICB9Ci0gICAgZWxzZSBpZiAoIGFtZF9pb21tdV9nZXRfcm9vdF9wYWdlX3Rh
YmxlKGR0ZSkgIT0KLSAgICAgICAgICAgICAgcGFnZV90b19tYWRkcihoZC0+
YXJjaC5yb290X3RhYmxlKSApCisgICAgZWxzZSBpZiAoIGFtZF9pb21tdV9n
ZXRfcm9vdF9wYWdlX3RhYmxlKGR0ZSkgIT0gcGFnZV90b19tYWRkcihyb290
X3BnKSApCiAgICAgewogICAgICAgICAvKgogICAgICAgICAgKiBTdHJpY3Rs
eSBzcGVha2luZyBpZiB0aGUgZGV2aWNlIGlzIHRoZSBvbmx5IG9uZSB3aXRo
IHRoaXMgcmVxdWVzdG9yCkBAIC0yMDcsOCArMjE5LDggQEAgc3RhdGljIGlu
dCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwogICAgICAgICAgICAg
cmMgPSAtRU9QTk9UU1VQUDsKICAgICAgICAgZWxzZQogICAgICAgICAgICAg
cmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZSgKLSAgICAgICAg
ICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkcihoZC0+YXJjaC5yb290
X3RhYmxlKSwKLSAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWlu
X2lkLCBoZC0+YXJjaC5wYWdpbmdfbW9kZSwgc3JfZmxhZ3MpOworICAgICAg
ICAgICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRyKHJvb3RfcGcpLCBk
b21pZCwKKyAgICAgICAgICAgICAgICAgICAgIGhkLT5hcmNoLnBhZ2luZ19t
b2RlLCBzcl9mbGFncyk7CiAgICAgICAgIGlmICggcmMgPCAwICkKICAgICAg
ICAgewogICAgICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW9t
bXUtPmxvY2ssIGZsYWdzKTsKQEAgLTIyNyw2ICsyMzksNyBAQCBzdGF0aWMg
aW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfCiAgICAgICAgICAg
ICAgICogaW50ZW5kZWQgYW55d2F5LgogICAgICAgICAgICAgICAqLwogICAg
ICAgICAgICAgICFwZGV2LT5kb21haW4tPmlzX2R5aW5nICYmCisgICAgICAg
ICAgICAgcGRldi0+ZG9tYWluICE9IGRvbV9pbyAmJgogICAgICAgICAgICAg
IChhbnlfcGRldl9iZWhpbmRfaW9tbXUocGRldi0+ZG9tYWluLCBwZGV2LCBp
b21tdSkgfHwKICAgICAgICAgICAgICAgcGRldi0+cGhhbnRvbV9zdHJpZGUp
ICkKICAgICAgICAgICAgIHByaW50aygiICUwNHg6JTAyeDolMDJ4LiV1OiBy
ZWFzc2lnbm1lbnQgbWF5IGNhdXNlICVwZCBkYXRhIGNvcnJ1cHRpb25cbiIs
CkBAIC0yNDcsOSArMjYwLDggQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sg
YW1kX2lvbW11X3NldHVwXwogICAgIEFNRF9JT01NVV9ERUJVRygiU2V0dXAg
SS9PIHBhZ2UgdGFibGU6IGRldmljZSBpZCA9ICUjeCwgdHlwZSA9ICUjeCwg
IgogICAgICAgICAgICAgICAgICAgICAicm9vdCB0YWJsZSA9ICUjIlBSSXg2
NCIsICIKICAgICAgICAgICAgICAgICAgICAgImRvbWFpbiA9ICVkLCBwYWdp
bmcgbW9kZSA9ICVkXG4iLAotICAgICAgICAgICAgICAgICAgICByZXFfaWQs
IHBkZXYtPnR5cGUsCi0gICAgICAgICAgICAgICAgICAgIHBhZ2VfdG9fbWFk
ZHIoaGQtPmFyY2gucm9vdF90YWJsZSksCi0gICAgICAgICAgICAgICAgICAg
IGRvbWFpbi0+ZG9tYWluX2lkLCBoZC0+YXJjaC5wYWdpbmdfbW9kZSk7Cisg
ICAgICAgICAgICAgICAgICAgIHJlcV9pZCwgcGRldi0+dHlwZSwgcGFnZV90
b19tYWRkcihyb290X3BnKSwKKyAgICAgICAgICAgICAgICAgICAgZG9taWQs
IGhkLT5hcmNoLnBhZ2luZ19tb2RlKTsKIAogICAgIEFTU0VSVChwY2lkZXZz
X2xvY2tlZCgpKTsKIApAQCAtMjk2LDcgKzMwOCw3IEBAIGludCBfX2luaXQg
YW1kX2lvdl9kZXRlY3Qodm9pZCkKIAogaW50IGFtZF9pb21tdV9hbGxvY19y
b290KHN0cnVjdCBkb21haW5faW9tbXUgKmhkKQogewotICAgIGlmICggdW5s
aWtlbHkoIWhkLT5hcmNoLnJvb3RfdGFibGUpICkKKyAgICBpZiAoIHVubGlr
ZWx5KCFoZC0+YXJjaC5yb290X3RhYmxlKSAmJiBoZCAhPSBkb21faW9tbXUo
ZG9tX2lvKSApCiAgICAgewogICAgICAgICBoZC0+YXJjaC5yb290X3RhYmxl
ID0gYWxsb2NfYW1kX2lvbW11X3BndGFibGUoKTsKICAgICAgICAgaWYgKCAh
aGQtPmFyY2gucm9vdF90YWJsZSApCkBAIC0zNzYsNyArMzg4LDEwIEBAIHZv
aWQgYW1kX2lvbW11X2Rpc2FibGVfZG9tYWluX2RldmljZShzdHIKIAogICAg
ICAgICBBTURfSU9NTVVfREVCVUcoIkRpc2FibGU6IGRldmljZSBpZCA9ICUj
eCwgIgogICAgICAgICAgICAgICAgICAgICAgICAgImRvbWFpbiA9ICVkLCBw
YWdpbmcgbW9kZSA9ICVkXG4iLAotICAgICAgICAgICAgICAgICAgICAgICAg
cmVxX2lkLCAgZG9tYWluLT5kb21haW5faWQsCisgICAgICAgICAgICAgICAg
ICAgICAgICByZXFfaWQsCisgICAgICAgICAgICAgICAgICAgICAgICBnZXRf
ZmllbGRfZnJvbV9yZWdfdTMyKCgodWludDMyX3QgKilkdGUpWzJdLAorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJ
T01NVV9ERVZfVEFCTEVfRE9NQUlOX0lEX01BU0ssCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1VX0RFVl9U
QUJMRV9ET01BSU5fSURfU0hJRlQpLAogICAgICAgICAgICAgICAgICAgICAg
ICAgZG9tX2lvbW11KGRvbWFpbiktPmFyY2gucGFnaW5nX21vZGUpOwogICAg
IH0KICAgICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZpb21tdS0+bG9jaywg
ZmxhZ3MpOwpAQCAtNjA1LDYgKzYyMCw4IEBAIHN0YXRpYyBpbnQgYW1kX2lv
bW11X3JlbW92ZV9kZXZpY2UodTggZGUKIAogICAgIGFtZF9pb21tdV9kaXNh
YmxlX2RvbWFpbl9kZXZpY2UocGRldi0+ZG9tYWluLCBpb21tdSwgZGV2Zm4s
IHBkZXYpOwogCisgICAgYW1kX2lvbW11X3F1YXJhbnRpbmVfdGVhcmRvd24o
cGRldik7CisKICAgICBpb21tdV9mcmVlX2RvbWlkKHBkZXYtPmFyY2gucHNl
dWRvX2RvbWlkLCBpb21tdS0+ZG9taWRfbWFwKTsKICAgICBwZGV2LT5hcmNo
LnBzZXVkb19kb21pZCA9IERPTUlEX0lOVkFMSUQ7CiAKLS0tIGEveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC9pb21tdS5jCkBAIC00OTcsMTkgKzQ5NywxOSBAQCBpbnQg
aW9tbXVfaW90bGJfZmx1c2hfYWxsKHN0cnVjdCBkb21haW4KICAgICByZXR1
cm4gcmM7CiB9CiAKLXN0YXRpYyBpbnQgX19pbml0IGlvbW11X3F1YXJhbnRp
bmVfaW5pdCh2b2lkKQoraW50IGlvbW11X3F1YXJhbnRpbmVfZGV2X2luaXQo
ZGV2aWNlX3QgKmRldikKIHsKICAgICBjb25zdCBzdHJ1Y3QgZG9tYWluX2lv
bW11ICpoZCA9IGRvbV9pb21tdShkb21faW8pOwotICAgIGludCByYzsKLQot
ICAgIHJjID0gaW9tbXVfZG9tYWluX2luaXQoZG9tX2lvKTsKLSAgICBpZiAo
IHJjICkKLSAgICAgICAgcmV0dXJuIHJjOwogCi0gICAgaWYgKCAhaGQtPnBs
YXRmb3JtX29wcy0+cXVhcmFudGluZV9pbml0ICkKKyAgICBpZiAoICFpb21t
dV9xdWFyYW50aW5lIHx8ICFoZC0+cGxhdGZvcm1fb3BzLT5xdWFyYW50aW5l
X2luaXQgKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIHJldHVybiBoZC0+
cGxhdGZvcm1fb3BzLT5xdWFyYW50aW5lX2luaXQoZG9tX2lvKTsKKyAgICBy
ZXR1cm4gaGQtPnBsYXRmb3JtX29wcy0+cXVhcmFudGluZV9pbml0KGRldik7
Cit9CisKK3N0YXRpYyBpbnQgX19pbml0IGlvbW11X3F1YXJhbnRpbmVfaW5p
dCh2b2lkKQoreworICAgIHJldHVybiBpb21tdV9kb21haW5faW5pdChkb21f
aW8pOwogfQogCiBpbnQgX19pbml0IGlvbW11X3NldHVwKHZvaWQpCi0tLSBh
L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jCisrKyBiL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jCkBAIC0xNTEyLDYgKzE1MTIsMTMgQEAg
c3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKgogICAg
ICAgICBtc2l4dGJsX2luaXQoZCk7CiAgICAgfQogCisgICAgaWYgKCBwZGV2
LT5kb21haW4gIT0gZG9tX2lvICkKKyAgICB7CisgICAgICAgIHJjID0gaW9t
bXVfcXVhcmFudGluZV9kZXZfaW5pdChwY2lfdG9fZGV2KHBkZXYpKTsKKyAg
ICAgICAgaWYgKCByYyApCisgICAgICAgICAgICBnb3RvIGRvbmU7CisgICAg
fQorCiAgICAgcGRldi0+ZmF1bHQuY291bnQgPSAwOwogCiAgICAgaWYgKCAo
cmMgPSBoZC0+cGxhdGZvcm1fb3BzLT5hc3NpZ25fZGV2aWNlKGQsIGRldmZu
LCBwY2lfdG9fZGV2KHBkZXYpLCBmbGFnKSkgKQpAQCAtMTU1OCw5ICsxNTY1
LDE2IEBAIGludCBkZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwg
dTEKICAgICAgICAgcmV0dXJuIC1FTk9ERVY7CiAKICAgICAvKiBEZS1hc3Np
Z25tZW50IGZyb20gZG9tX2lvIHNob3VsZCBkZS1xdWFyYW50aW5lIHRoZSBk
ZXZpY2UgKi8KLSAgICB0YXJnZXQgPSAoKHBkZXYtPnF1YXJhbnRpbmUgfHwg
aW9tbXVfcXVhcmFudGluZSkgJiYKLSAgICAgICAgICAgICAgcGRldi0+ZG9t
YWluICE9IGRvbV9pbykgPwotICAgICAgICBkb21faW8gOiBoYXJkd2FyZV9k
b21haW47CisgICAgaWYgKCAocGRldi0+cXVhcmFudGluZSB8fCBpb21tdV9x
dWFyYW50aW5lKSAmJiBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkKKyAgICB7
CisgICAgICAgIHJldCA9IGlvbW11X3F1YXJhbnRpbmVfZGV2X2luaXQocGNp
X3RvX2RldihwZGV2KSk7CisgICAgICAgIGlmICggcmV0ICkKKyAgICAgICAg
ICAgcmV0dXJuIHJldDsKKworICAgICAgICB0YXJnZXQgPSBkb21faW87Cisg
ICAgfQorICAgIGVsc2UKKyAgICAgICAgdGFyZ2V0ID0gaGFyZHdhcmVfZG9t
YWluOwogCiAgICAgd2hpbGUgKCBwZGV2LT5waGFudG9tX3N0cmlkZSApCiAg
ICAgewotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUu
YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwpA
QCAtNDMsNiArNDMsMTIgQEAKICNpbmNsdWRlICJ2dGQuaCIKICNpbmNsdWRl
ICIuLi9hdHMuaCIKIAorI2RlZmluZSBERVZJQ0VfRE9NSUQoZCwgcGRldikg
KChkKSAhPSBkb21faW8gPyAoZCktPmRvbWFpbl9pZCBcCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IChwZGV2KS0+
YXJjaC5wc2V1ZG9fZG9taWQpCisjZGVmaW5lIERFVklDRV9QR1RBQkxFKGQs
IHBkZXYpICgoZCkgIT0gZG9tX2lvIFwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgID8gZG9tX2lvbW11KGQpLT5hcmNoLnBnZF9tYWRkciBc
CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IChwZGV2KS0+
YXJjaC52dGQucGdkX21hZGRyKQorCiAvKiBQb3NzaWJsZSB1bmZpbHRlcmVk
IExBUElDL01TSSBtZXNzYWdlcyBmcm9tIHVudHJ1c3RlZCBzb3VyY2VzPyAq
LwogYm9vbCBfX3JlYWRfbW9zdGx5IHVudHJ1c3RlZF9tc2k7CiAKQEAgLTc4
LDEzICs4NCwxOCBAQCBzdGF0aWMgaW50IGdldF9pb21tdV9kaWQoZG9taWRf
dCBkb21pZCwKIAogI2RlZmluZSBESURfRklFTERfV0lEVEggMTYKICNkZWZp
bmUgRElEX0hJR0hfT0ZGU0VUIDgKKworLyoKKyAqIFRoaXMgZnVuY3Rpb24g
bWF5IGhhdmUgImNvbnRleHQiIHBhc3NlZCBhcyBOVUxMLCB0byBtZXJlbHkg
b2J0YWluIGEgRElECisgKiBmb3IgImRvbWlkIi4KKyAqLwogc3RhdGljIGlu
dCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0IGNvbnRleHRfZW50cnkg
KmNvbnRleHQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBk
b21pZF90IGRvbWlkLCBzdHJ1Y3QgaW9tbXUgKmlvbW11KQogewogICAgIHVu
c2lnbmVkIGxvbmcgbnJfZG9tLCBpOwogICAgIGludCBmb3VuZCA9IDA7CiAK
LSAgICBBU1NFUlQoc3Bpbl9pc19sb2NrZWQoJmlvbW11LT5sb2NrKSk7Cisg
ICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOwogCiAgICAgbnJfZG9tID0g
Y2FwX25kb21zKGlvbW11LT5jYXApOwogICAgIGkgPSBmaW5kX2ZpcnN0X2Jp
dChpb21tdS0+ZG9taWRfYml0bWFwLCBucl9kb20pOwpAQCAtMTEwLDggKzEy
MSwxMyBAQCBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9pZChzdHJ1
Y3QKICAgICB9CiAKICAgICBzZXRfYml0KGksIGlvbW11LT5kb21pZF9iaXRt
YXApOwotICAgIGNvbnRleHQtPmhpICY9IH4oKCgxIDw8IERJRF9GSUVMRF9X
SURUSCkgLSAxKSA8PCBESURfSElHSF9PRkZTRVQpOwotICAgIGNvbnRleHQt
PmhpIHw9IChpICYgKCgxIDw8IERJRF9GSUVMRF9XSURUSCkgLSAxKSkgPDwg
RElEX0hJR0hfT0ZGU0VUOworCisgICAgaWYgKCBjb250ZXh0ICkKKyAgICB7
CisgICAgICAgIGNvbnRleHQtPmhpICY9IH4oKCgxIDw8IERJRF9GSUVMRF9X
SURUSCkgLSAxKSA8PCBESURfSElHSF9PRkZTRVQpOworICAgICAgICBjb250
ZXh0LT5oaSB8PSAoaSAmICgoMSA8PCBESURfRklFTERfV0lEVEgpIC0gMSkp
IDw8IERJRF9ISUdIX09GRlNFVDsKKyAgICB9CisKICAgICByZXR1cm4gMDsK
IH0KIApAQCAtMTc5LDggKzE5NSwxMiBAQCBzdGF0aWMgdm9pZCBjaGVja19j
bGVhbnVwX2RvbWlkX21hcChzdHJ1CiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqZXhjbHVkZSwK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBp
b21tdSAqaW9tbXUpCiB7Ci0gICAgYm9vbCBmb3VuZCA9IGFueV9wZGV2X2Jl
aGluZF9pb21tdShkLCBleGNsdWRlLCBpb21tdSk7CisgICAgYm9vbCBmb3Vu
ZDsKIAorICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm47
CisKKyAgICBmb3VuZCA9IGFueV9wZGV2X2JlaGluZF9pb21tdShkLCBleGNs
dWRlLCBpb21tdSk7CiAgICAgLyoKICAgICAgKiBIaWRkZW4gZGV2aWNlcyBh
cmUgYXNzb2NpYXRlZCB3aXRoIERvbVhFTiBidXQgdXNhYmxlIGJ5IHRoZSBo
YXJkd2FyZQogICAgICAqIGRvbWFpbi4gSGVuY2UgdGhleSBuZWVkIGNvbnNp
ZGVyaW5nIGhlcmUgYXMgd2VsbC4KQEAgLTE0NDMsNyArMTQ2Myw3IEBAIGlu
dCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICAgICAgZG9taWQg
PSBpb21tdS0+ZG9taWRfbWFwW3ByZXZfZGlkXTsKICAgICAgICAgaWYgKCBk
b21pZCA8IERPTUlEX0ZJUlNUX1JFU0VSVkVEICkKICAgICAgICAgICAgIHBy
ZXZfZG9tID0gcmN1X2xvY2tfZG9tYWluX2J5X2lkKGRvbWlkKTsKLSAgICAg
ICAgZWxzZSBpZiAoIGRvbWlkID09IERPTUlEX0lPICkKKyAgICAgICAgZWxz
ZSBpZiAoIHBkZXYgPyBkb21pZCA9PSBwZGV2LT5hcmNoLnBzZXVkb19kb21p
ZCA6IGRvbWlkID4gRE9NSURfTUFTSyApCiAgICAgICAgICAgICBwcmV2X2Rv
bSA9IHJjdV9sb2NrX2RvbWFpbihkb21faW8pOwogICAgICAgICBpZiAoICFw
cmV2X2RvbSApCiAgICAgICAgIHsKQEAgLTE2MjAsMTUgKzE2NDAsMTIgQEAg
aW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIHsKICAgICAg
ICAgaWYgKCAhcHJldl9kb20gKQogICAgICAgICAgICAgZG9tYWluX2NvbnRl
eHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21h
aW5faWQpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IERFVklDRV9ET01JRChkb21haW4sIHBkZXYpKTsKICAgICAgICAgZWxzZSBp
ZiAoIHByZXZfZG9tICE9IGRvbWFpbiApIC8qIEF2b2lkIGluZmluaXRlIHJl
Y3Vyc2lvbi4gKi8KLSAgICAgICAgewotICAgICAgICAgICAgaGQgPSBkb21f
aW9tbXUocHJldl9kb20pOwogICAgICAgICAgICAgZG9tYWluX2NvbnRleHRf
bWFwcGluZ19vbmUocHJldl9kb20sIGlvbW11LCBidXMsIGRldmZuLCBwZGV2
LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9t
YWluLT5kb21haW5faWQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBoZC0+YXJjaC5wZ2RfbWFkZHIsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQocHJldl9k
b20sIHBkZXYpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgREVWSUNFX1BHVEFCTEUocHJldl9kb20sIHBkZXYpLAogICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbW9kZSAmIE1BUF9X
SVRIX1JNUlIpOwotICAgICAgICB9CiAgICAgfQogCiAgICAgaWYgKCBwcmV2
X2RvbSApCkBAIC0xNjQ1LDcgKzE2NjIsNyBAQCBzdGF0aWMgaW50IGRvbWFp
bl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiB7CiAgICAgc3RydWN0IGFjcGlf
ZHJoZF91bml0ICpkcmhkOwogICAgIGNvbnN0IHN0cnVjdCBhY3BpX3JtcnJf
dW5pdCAqcm1ycjsKLSAgICBwYWRkcl90IHBnZF9tYWRkciA9IGRvbV9pb21t
dShkb21haW4pLT5hcmNoLnBnZF9tYWRkcjsKKyAgICBwYWRkcl90IHBnZF9t
YWRkciA9IERFVklDRV9QR1RBQkxFKGRvbWFpbiwgcGRldik7CiAgICAgZG9t
aWRfdCBvcmlnX2RvbWlkID0gcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQ7CiAg
ICAgaW50IHJldCA9IDA7CiAgICAgdW5zaWduZWQgaW50IGksIG1vZGUgPSAw
OwpAQCAtMTY2OCw3ICsxNjg1LDcgQEAgc3RhdGljIGludCBkb21haW5fY29u
dGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICBicmVhazsKICAgICB9CiAK
LSAgICBpZiAoIGRvbWFpbiAhPSBwZGV2LT5kb21haW4gKQorICAgIGlmICgg
ZG9tYWluICE9IHBkZXYtPmRvbWFpbiAmJiBwZGV2LT5kb21haW4gIT0gZG9t
X2lvICkKICAgICB7CiAgICAgICAgIGlmICggcGRldi0+ZG9tYWluLT5pc19k
eWluZyApCiAgICAgICAgICAgICBtb2RlIHw9IE1BUF9PV05FUl9EWUlORzsK
QEAgLTE3MDksOCArMTcyNiw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgIHByaW50ayhWVERQUkVG
SVggImQlZDpQQ0llOiBtYXAgJTA0eDolMDJ4OiUwMnguJXVcbiIsCiAgICAg
ICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQsIHNlZywgYnVzLAog
ICAgICAgICAgICAgICAgICAgIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMo
ZGV2Zm4pKTsKLSAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGlu
Z19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRldiwgZG9t
YWluLT5kb21haW5faWQsIHBnZF9tYWRkciwKKyAgICAgICAgcmV0ID0gZG9t
YWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwg
YnVzLCBkZXZmbiwgcGRldiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgREVWSUNFX0RPTUlEKGRvbWFpbiwgcGRldiksIHBn
ZF9tYWRkciwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgbW9kZSk7CiAgICAgICAgIGlmICggcmV0ID4gMCApCiAgICAgICAg
ICAgICByZXQgPSAwOwpAQCAtMTczNCw4ICsxNzUxLDggQEAgc3RhdGljIGlu
dCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICAgICAg
ICAgICAgIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pKTsKIAog
ICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21h
aW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBkb21haW4tPmRvbWFp
bl9pZCwgcGdkX21hZGRyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBtb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgcGRldiwgREVWSUNFX0RPTUlEKGRvbWFpbiwg
cGRldiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHBnZF9tYWRkciwgbW9kZSk7CiAgICAgICAgIGlmICggcmV0IDwgMCAp
CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgcHJldl9wcmVzZW50ID0g
cmV0OwpAQCAtMTc2MSw4ICsxNzc4LDggQEAgc3RhdGljIGludCBkb21haW5f
Y29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICAgKi8KICAgICAgICAg
aWYgKCByZXQgPj0gMCApCiAgICAgICAgICAgICByZXQgPSBkb21haW5fY29u
dGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCBidXMsIGRl
dmZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgTlVMTCwgZG9tYWluLT5kb21haW5faWQsIHBnZF9tYWRkciwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1v
ZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgTlVMTCwgREVWSUNFX0RPTUlEKGRvbWFpbiwgcGRldiksCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwZ2Rf
bWFkZHIsIG1vZGUpOwogCiAgICAgICAgIC8qCiAgICAgICAgICAqIERldmlj
ZXMgYmVoaW5kIFBDSWUtdG8tUENJL1BDSXggYnJpZGdlIG1heSBnZW5lcmF0
ZSBkaWZmZXJlbnQKQEAgLTE3NzcsOCArMTc5NCw4IEBAIHN0YXRpYyBpbnQg
ZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgaWYgKCAh
cmV0ICYmIHBkZXZfdHlwZShzZWcsIGJ1cywgZGV2Zm4pID09IERFVl9UWVBF
X1BDSWUyUENJX0JSSURHRSAmJgogICAgICAgICAgICAgIChzZWNidXMgIT0g
cGRldi0+YnVzIHx8IHBkZXYtPmRldmZuICE9IDApICkKICAgICAgICAgICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJo
ZC0+aW9tbXUsIHNlY2J1cywgMCwKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIGRvbWFpbi0+ZG9tYWluX2lk
LCBwZ2RfbWFkZHIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBtb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIERFVklDRV9ET01JRChkb21h
aW4sIHBkZXYpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgcGdkX21hZGRyLCBtb2RlKTsKIAogICAgICAgICBpZiAo
IHJldCApCiAgICAgICAgIHsKQEAgLTE5MTQsNyArMTkzMSw3IEBAIHN0YXRp
YyBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRvbWEKICAgICAgICAg
ICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgc2VnLCBidXMsCiAgICAg
ICAgICAgICAgICAgICAgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZm
bikpOwogICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUo
ZG9tYWluLCBpb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERFVklDRV9E
T01JRChkb21haW4sIHBkZXYpKTsKICAgICAgICAgaWYgKCAhcmV0ICYmIGRl
dmZuID09IHBkZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRldiwgZHJoZCkg
PiAwICkKICAgICAgICAgICAgIGRpc2FibGVfYXRzX2RldmljZShwZGV2KTsK
IApAQCAtMTkyNSw3ICsxOTQyLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBh
Y3BpX2RyaGRfdW5pdCAqZG9tYQogICAgICAgICAgICAgcHJpbnRrKFZURFBS
RUZJWCAiZCVkOlBDSTogdW5tYXAgJTA0eDolMDJ4OiUwMnguJXVcbiIsCiAg
ICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQsIHNlZywgYnVz
LCBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7CiAgICAgICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11
LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlEKGRvbWFpbiwg
cGRldikpOwogICAgICAgICBpZiAoIHJldCApCiAgICAgICAgICAgICBicmVh
azsKIApAQCAtMTkzNCwxOCArMTk1MSwxMiBAQCBzdGF0aWMgY29uc3Qgc3Ry
dWN0IGFjcGlfZHJoZF91bml0ICpkb21hCiAgICAgICAgIGlmICggZmluZF91
cHN0cmVhbV9icmlkZ2Uoc2VnLCAmdG1wX2J1cywgJnRtcF9kZXZmbiwgJnNl
Y2J1cykgPCAxICkKICAgICAgICAgICAgIGJyZWFrOwogCisgICAgICAgIHJl
dCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0
bXBfYnVzLCB0bXBfZGV2Zm4sCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7CiAg
ICAgICAgIC8qIFBDSWUgdG8gUENJL1BDSXggYnJpZGdlICovCi0gICAgICAg
IGlmICggcGRldl90eXBlKHNlZywgdG1wX2J1cywgdG1wX2RldmZuKSA9PSBE
RVZfVFlQRV9QQ0llMlBDSV9CUklER0UgKQotICAgICAgICB7Ci0gICAgICAg
ICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBp
b21tdSwgdG1wX2J1cywgdG1wX2RldmZuLAotICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsK
LSAgICAgICAgICAgIGlmICggIXJldCApCi0gICAgICAgICAgICAgICAgcmV0
ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIHNl
Y2J1cywgMCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOwotICAgICAgICB9Ci0g
ICAgICAgIGVsc2UgLyogTGVnYWN5IFBDSSBicmlkZ2UgKi8KLSAgICAgICAg
ICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlv
bW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOwor
ICAgICAgICBpZiAoICFyZXQgJiYgcGRldl90eXBlKHNlZywgdG1wX2J1cywg
dG1wX2RldmZuKSA9PSBERVZfVFlQRV9QQ0llMlBDSV9CUklER0UgKQorICAg
ICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFp
biwgaW9tbXUsIHNlY2J1cywgMCwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2
KSk7CiAKICAgICAgICAgYnJlYWs7CiAKQEAgLTE5OTIsNiArMjAwMywyNSBA
QCBzdGF0aWMgdm9pZCBpb21tdV9kb21haW5fdGVhcmRvd24oc3RydWN0CiAg
ICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiB9CiAK
K3N0YXRpYyB2b2lkIHF1YXJhbnRpbmVfdGVhcmRvd24oc3RydWN0IHBjaV9k
ZXYgKnBkZXYsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNv
bnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZCkKK3sKKyAgICBzdHJ1
Y3QgcGFnZV9pbmZvICpwZzsKKworICAgIEFTU0VSVChwY2lkZXZzX2xvY2tl
ZCgpKTsKKworICAgIGlmICggIXBkZXYtPmFyY2gudnRkLnBnZF9tYWRkciAp
CisgICAgICAgIHJldHVybjsKKworICAgIHdoaWxlICggKHBnID0gcGFnZV9s
aXN0X3JlbW92ZV9oZWFkKCZwZGV2LT5hcmNoLnBndGFibGVzX2xpc3QpKSAp
CisgICAgICAgIGZyZWVfZG9taGVhcF9wYWdlKHBnKTsKKworICAgIHBkZXYt
PmFyY2gudnRkLnBnZF9tYWRkciA9IDA7CisKKyAgICBpZiAoIGRyaGQgKQor
ICAgICAgICBjbGVhbnVwX2RvbWlkX21hcChwZGV2LT5hcmNoLnBzZXVkb19k
b21pZCwgZHJoZC0+aW9tbXUpOworfQorCiBzdGF0aWMgaW50IF9fbXVzdF9j
aGVjayBpbnRlbF9pb21tdV9tYXBfcGFnZShzdHJ1Y3QgZG9tYWluICpkLCBk
Zm5fdCBkZm4sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBtZm5fdCBtZm4sIHVuc2lnbmVkIGludCBmbGFncywKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVu
c2lnbmVkIGludCAqZmx1c2hfZmxhZ3MpCkBAIC0yMjE0LDYgKzIyNDQsOCBA
QCBzdGF0aWMgaW50IGludGVsX2lvbW11X3JlbW92ZV9kZXZpY2UodTgKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVz
cywgMCk7CiAgICAgfQogCisgICAgcXVhcmFudGluZV90ZWFyZG93bihwZGV2
LCBkcmhkKTsKKwogICAgIGlmICggZHJoZCApCiAgICAgewogICAgICAgICBp
b21tdV9mcmVlX2RvbWlkKHBkZXYtPmFyY2gucHNldWRvX2RvbWlkLApAQCAt
Mjg1Miw2MCArMjg4NCwxMzkgQEAgc3RhdGljIHZvaWQgdnRkX2R1bXBfcDJt
X3RhYmxlKHN0cnVjdCBkbwogICAgIHZ0ZF9kdW1wX3AybV90YWJsZV9sZXZl
bChoZC0+YXJjaC5wZ2RfbWFkZHIsIGFnYXdfdG9fbGV2ZWwoaGQtPmFyY2gu
YWdhdyksIDAsIDApOwogfQogCi1zdGF0aWMgaW50IF9faW5pdCBpbnRlbF9p
b21tdV9xdWFyYW50aW5lX2luaXQoc3RydWN0IGRvbWFpbiAqZCkKK3N0YXRp
YyBpbnQgZmlsbF9xcHQoc3RydWN0IGRtYV9wdGUgKnRoaXMsIHVuc2lnbmVk
IGludCBsZXZlbCwKKyAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBtYWRk
cnNbNl0sIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQogewotICAgIHN0cnVjdCBk
b21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwotICAgIHN0cnVjdCBk
bWFfcHRlICpwYXJlbnQ7CisgICAgdW5zaWduZWQgaW50IGk7CisgICAgaW50
IHJjID0gMDsKKworICAgIGZvciAoIGkgPSAwOyAhcmMgJiYgaSA8IFBURV9O
VU07ICsraSApCisgICAgeworICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAqcHRl
ID0gJnRoaXNbaV0sICpuZXh0OworCisgICAgICAgIGlmICggIWRtYV9wdGVf
cHJlc2VudCgqcHRlKSApCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICgg
IW1hZGRyc1tsZXZlbF0gKQorICAgICAgICAgICAgeworICAgICAgICAgICAg
ICAgIC8qCisgICAgICAgICAgICAgICAgICogVGhlIHBndGFibGUgYWxsb2Nh
dG9yIGlzIGZpbmUgZm9yIHRoZSBsZWFmIHBhZ2UsIGFzIHdlbGwgYXMKKyAg
ICAgICAgICAgICAgICAgKiBwYWdlIHRhYmxlIHBhZ2VzLCBhbmQgdGhlIHJl
c3VsdGluZyBhbGxvY2F0aW9ucyBhcmUgYWx3YXlzCisgICAgICAgICAgICAg
ICAgICogemVyb2VkLgorICAgICAgICAgICAgICAgICAqLworICAgICAgICAg
ICAgICAgIG1hZGRyc1tsZXZlbF0gPSBhbGxvY19wZ3RhYmxlX21hZGRyKE5V
TEwsIDEpOworICAgICAgICAgICAgICAgIGlmICggIW1hZGRyc1tsZXZlbF0g
KQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICAgICAgcmMg
PSAtRU5PTUVNOworICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAg
ICAgICAgICAgICB9CisKKyAgICAgICAgICAgICAgICBwYWdlX2xpc3RfYWRk
KG1hZGRyX3RvX3BhZ2UobWFkZHJzW2xldmVsXSksCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAmcGRldi0+YXJjaC5wZ3RhYmxlc19saXN0KTsK
KworICAgICAgICAgICAgICAgIGlmICggbGV2ZWwgKQorICAgICAgICAgICAg
ICAgIHsKKyAgICAgICAgICAgICAgICAgICAgbmV4dCA9IG1hcF92dGRfZG9t
YWluX3BhZ2UobWFkZHJzW2xldmVsXSk7CisgICAgICAgICAgICAgICAgICAg
IHJjID0gZmlsbF9xcHQobmV4dCwgbGV2ZWwgLSAxLCBtYWRkcnMsIHBkZXYp
OworICAgICAgICAgICAgICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2Uo
bmV4dCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorCisg
ICAgICAgICAgICBkbWFfc2V0X3B0ZV9hZGRyKCpwdGUsIG1hZGRyc1tsZXZl
bF0pOworICAgICAgICAgICAgZG1hX3NldF9wdGVfcmVhZGFibGUoKnB0ZSk7
CisgICAgICAgICAgICBkbWFfc2V0X3B0ZV93cml0YWJsZSgqcHRlKTsKKyAg
ICAgICAgfQorICAgICAgICBlbHNlIGlmICggbGV2ZWwgJiYgIWRtYV9wdGVf
c3VwZXJwYWdlKCpwdGUpICkKKyAgICAgICAgeworICAgICAgICAgICAgcGFn
ZV9saXN0X2FkZChtYWRkcl90b19wYWdlKGRtYV9wdGVfYWRkcigqcHRlKSks
CisgICAgICAgICAgICAgICAgICAgICAgICAgICZwZGV2LT5hcmNoLnBndGFi
bGVzX2xpc3QpOworICAgICAgICAgICAgbmV4dCA9IG1hcF92dGRfZG9tYWlu
X3BhZ2UoZG1hX3B0ZV9hZGRyKCpwdGUpKTsKKyAgICAgICAgICAgIHJjID0g
ZmlsbF9xcHQobmV4dCwgbGV2ZWwgLSAxLCBtYWRkcnMsIHBkZXYpOworICAg
ICAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKG5leHQpOworICAgICAg
ICB9CisgICAgfQorCisgICAgcmV0dXJuIHJjOworfQorCitzdGF0aWMgaW50
IGludGVsX2lvbW11X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3QgcGNpX2RldiAq
cGRldikKK3sKKyAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9p
b21tdShkb21faW8pOworICAgIHBhZGRyX3QgbWFkZHI7CiAgICAgdW5zaWdu
ZWQgaW50IGFnYXcgPSB3aWR0aF90b19hZ2F3KERFRkFVTFRfRE9NQUlOX0FE
RFJFU1NfV0lEVEgpOwogICAgIHVuc2lnbmVkIGludCBsZXZlbCA9IGFnYXdf
dG9fbGV2ZWwoYWdhdyk7CisgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91
bml0ICpkcmhkOworICAgIGNvbnN0IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAq
cm1ycjsKKyAgICB1bnNpZ25lZCBpbnQgaSwgYmRmOworICAgIGJvb2wgcm1y
cl9mb3VuZCA9IGZhbHNlOworICAgIGludCByYzsKIAotICAgIGlmICggaGQt
PmFyY2gucGdkX21hZGRyICkKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQo
KSk7CisgICAgQVNTRVJUKCFoZC0+YXJjaC5wZ2RfbWFkZHIpOworCisgICAg
aWYgKCBwZGV2LT5hcmNoLnZ0ZC5wZ2RfbWFkZHIgKQogICAgIHsKLSAgICAg
ICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7CisgICAgICAgIGNsZWFyX2RvbWFp
bl9wYWdlKHBkZXYtPmFyY2gubGVhZl9tZm4pOwogICAgICAgICByZXR1cm4g
MDsKICAgICB9CiAKLSAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdf
bG9jayk7CisgICAgZHJoZCA9IGFjcGlfZmluZF9tYXRjaGVkX2RyaGRfdW5p
dChwZGV2KTsKKyAgICBpZiAoICFkcmhkICkKKyAgICAgICAgcmV0dXJuIC1F
Tk9ERVY7CiAKLSAgICBoZC0+YXJjaC5wZ2RfbWFkZHIgPSBhbGxvY19wZ3Rh
YmxlX21hZGRyKE5VTEwsIDEpOwotICAgIGlmICggIWhkLT5hcmNoLnBnZF9t
YWRkciApCi0gICAgICAgIGdvdG8gb3V0OworICAgIG1hZGRyID0gYWxsb2Nf
cGd0YWJsZV9tYWRkcihOVUxMLCAxKTsKKyAgICBpZiAoICFtYWRkciApCisg
ICAgICAgIHJldHVybiAtRU5PTUVNOwogCi0gICAgcGFyZW50ID0gbWFwX3Z0
ZF9kb21haW5fcGFnZShoZC0+YXJjaC5wZ2RfbWFkZHIpOwotICAgIHdoaWxl
ICggbGV2ZWwgKQotICAgIHsKLSAgICAgICAgdWludDY0X3QgbWFkZHI7Ci0g
ICAgICAgIHVuc2lnbmVkIGludCBvZmZzZXQ7CisgICAgcmMgPSBjb250ZXh0
X3NldF9kb21haW5faWQoTlVMTCwgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQs
IGRyaGQtPmlvbW11KTsKIAotICAgICAgICAvKgotICAgICAgICAgKiBUaGUg
cGd0YWJsZSBhbGxvY2F0b3IgaXMgZmluZSBmb3IgdGhlIGxlYWYgcGFnZSwg
YXMgd2VsbCBhcwotICAgICAgICAgKiBwYWdlIHRhYmxlIHBhZ2VzLCBhbmQg
dGhlIHJlc3VsdGluZyBhbGxvY2F0aW9ucyBhcmUgYWx3YXlzCi0gICAgICAg
ICAqIHplcm9lZC4KLSAgICAgICAgICovCi0gICAgICAgIG1hZGRyID0gYWxs
b2NfcGd0YWJsZV9tYWRkcihOVUxMLCAxKTsKLSAgICAgICAgaWYgKCAhbWFk
ZHIgKQorICAgIC8qIFRyYW5zaWVudGx5IGluc3RhbGwgdGhlIHJvb3QgaW50
byBEb21JTywgZm9yIGlvbW11X2lkZW50aXR5X21hcHBpbmcoKS4gKi8KKyAg
ICBoZC0+YXJjaC5wZ2RfbWFkZHIgPSBtYWRkcjsKKworICAgIGZvcl9lYWNo
X3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKKyAgICB7CisgICAgICAg
IGlmICggcmMgKQogICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgZm9y
ICggb2Zmc2V0ID0gMDsgb2Zmc2V0IDwgUFRFX05VTTsgb2Zmc2V0KysgKQor
ICAgICAgICBpZiAoIHJtcnItPnNlZ21lbnQgPT0gcGRldi0+c2VnICYmCisg
ICAgICAgICAgICAgYmRmID09IFBDSV9CREYyKHBkZXYtPmJ1cywgcGRldi0+
ZGV2Zm4pICkKICAgICAgICAgewotICAgICAgICAgICAgc3RydWN0IGRtYV9w
dGUgKnB0ZSA9ICZwYXJlbnRbb2Zmc2V0XTsKKyAgICAgICAgICAgIHJtcnJf
Zm91bmQgPSB0cnVlOwogCi0gICAgICAgICAgICBkbWFfc2V0X3B0ZV9hZGRy
KCpwdGUsIG1hZGRyKTsKLSAgICAgICAgICAgIGRtYV9zZXRfcHRlX3JlYWRh
YmxlKCpwdGUpOworICAgICAgICAgICAgcmMgPSBpb21tdV9pZGVudGl0eV9t
YXBwaW5nKGRvbV9pbywgcDJtX2FjY2Vzc19ydywKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3Ms
IHJtcnItPmVuZF9hZGRyZXNzLAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIDApOworICAgICAgICAgICAgaWYgKCByYyApCisg
ICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYCisg
ICAgICAgICAgICAgICAgICAgICAgICIlMDR4OiUwMng6JTAyeC4ldTogUk1S
UiBxdWFyYW50aW5lIG1hcHBpbmcgZmFpbGVkXG4iLAorICAgICAgICAgICAg
ICAgICAgICAgICBwZGV2LT5zZWcsIHBkZXYtPmJ1cywKKyAgICAgICAgICAg
ICAgICAgICAgICAgUENJX1NMT1QocGRldi0+ZGV2Zm4pLCBQQ0lfRlVOQyhw
ZGV2LT5kZXZmbikpOwogICAgICAgICB9Ci0gICAgICAgIGlvbW11X3N5bmNf
Y2FjaGUocGFyZW50LCBQQUdFX1NJWkUpOworICAgIH0KIAotICAgICAgICB1
bm1hcF92dGRfZG9tYWluX3BhZ2UocGFyZW50KTsKLSAgICAgICAgcGFyZW50
ID0gbWFwX3Z0ZF9kb21haW5fcGFnZShtYWRkcik7Ci0gICAgICAgIGxldmVs
LS07CisgICAgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKGRvbV9pbyk7
CisgICAgaGQtPmFyY2gucGdkX21hZGRyID0gMDsKKyAgICBwZGV2LT5hcmNo
LnZ0ZC5wZ2RfbWFkZHIgPSBtYWRkcjsKKworICAgIGlmICggIXJjICkKKyAg
ICB7CisgICAgICAgIHN0cnVjdCBkbWFfcHRlICpyb290OworICAgICAgICBw
YWRkcl90IG1hZGRyc1s2XSA9IHt9OworCisgICAgICAgIHNwaW5fbG9jaygm
aGQtPmFyY2gubWFwcGluZ19sb2NrKTsKKworICAgICAgICByb290ID0gbWFw
X3Z0ZF9kb21haW5fcGFnZShtYWRkcik7CisgICAgICAgIHJjID0gZmlsbF9x
cHQocm9vdCwgbGV2ZWwgLSAxLCBtYWRkcnMsIHBkZXYpOworICAgICAgICB1
bm1hcF92dGRfZG9tYWluX3BhZ2Uocm9vdCk7CisKKyAgICAgICAgcGRldi0+
YXJjaC5sZWFmX21mbiA9IG1hZGRyX3RvX21mbihtYWRkcnNbMF0pOworCisg
ICAgICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwog
ICAgIH0KLSAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UocGFyZW50KTsKIAot
IG91dDoKLSAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2Nr
KTsKKyAgICBpZiAoIHJjICkKKyAgICAgICAgcXVhcmFudGluZV90ZWFyZG93
bihwZGV2LCBkcmhkKTsKIAotICAgIC8qIFBhZ2VzIGxlYWtlZCBpbiBmYWls
dXJlIGNhc2UgKi8KLSAgICByZXR1cm4gbGV2ZWwgPyAtRU5PTUVNIDogMDsK
KyAgICByZXR1cm4gcmM7CiB9CiAKIGNvbnN0IHN0cnVjdCBpb21tdV9vcHMg
X19pbml0Y29uc3RyZWwgaW50ZWxfaW9tbXVfb3BzID0gewotLS0gYS94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuaAorKysgYi94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuaApAQCAtNTM1LDcgKzUzNSw3
IEBAIHN0cnVjdCBpb21tdSB7CiAgICAgdTMyIG5yX3B0X2xldmVsczsKICAg
ICB1NjQJY2FwOwogICAgIHU2NAllY2FwOwotICAgIHNwaW5sb2NrX3QgbG9j
azsgLyogcHJvdGVjdCBjb250ZXh0LCBkb21haW4gaWRzICovCisgICAgc3Bp
bmxvY2tfdCBsb2NrOyAvKiBwcm90ZWN0IGNvbnRleHQgKi8KICAgICBzcGlu
bG9ja190IHJlZ2lzdGVyX2xvY2s7IC8qIHByb3RlY3QgaW9tbXUgcmVnaXN0
ZXIgaGFuZGxpbmcgKi8KICAgICB1NjQgcm9vdF9tYWRkcjsgLyogcm9vdCBl
bnRyeSBtYWNoaW5lIGFkZHJlc3MgKi8KICAgICBzdHJ1Y3QgbXNpX2Rlc2Mg
bXNpOwotLS0gYS94ZW4vaW5jbHVkZS94ZW4vaW9tbXUuaAorKysgYi94ZW4v
aW5jbHVkZS94ZW4vaW9tbXUuaApAQCAtMTg5LDcgKzE4OSw3IEBAIHR5cGVk
ZWYgaW50IGlvbW11X2dyZG1fdCh4ZW5fcGZuX3Qgc3RhcnQKIHN0cnVjdCBp
b21tdV9vcHMgewogICAgIGludCAoKmluaXQpKHN0cnVjdCBkb21haW4gKmQp
OwogICAgIHZvaWQgKCpod2RvbV9pbml0KShzdHJ1Y3QgZG9tYWluICpkKTsK
LSAgICBpbnQgKCpxdWFyYW50aW5lX2luaXQpKHN0cnVjdCBkb21haW4gKmQp
OworICAgIGludCAoKnF1YXJhbnRpbmVfaW5pdCkoZGV2aWNlX3QgKmRldik7
CiAgICAgaW50ICgqYWRkX2RldmljZSkodTggZGV2Zm4sIGRldmljZV90ICpk
ZXYpOwogICAgIGludCAoKmVuYWJsZV9kZXZpY2UpKGRldmljZV90ICpkZXYp
OwogICAgIGludCAoKnJlbW92ZV9kZXZpY2UpKHU4IGRldmZuLCBkZXZpY2Vf
dCAqZGV2KTsKQEAgLTI3Nyw2ICsyNzcsNyBAQCBpbnQgX19tdXN0X2NoZWNr
IGlvbW11X3N1c3BlbmQodm9pZCk7CiB2b2lkIGlvbW11X3Jlc3VtZSh2b2lk
KTsKIHZvaWQgaW9tbXVfY3Jhc2hfc2h1dGRvd24odm9pZCk7CiBpbnQgaW9t
bXVfZ2V0X3Jlc2VydmVkX2RldmljZV9tZW1vcnkoaW9tbXVfZ3JkbV90ICos
IHZvaWQgKik7CitpbnQgaW9tbXVfcXVhcmFudGluZV9kZXZfaW5pdChkZXZp
Y2VfdCAqZGV2KTsKIAogdm9pZCBpb21tdV9zaGFyZV9wMm1fdGFibGUoc3Ry
dWN0IGRvbWFpbiAqZCk7CiAK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-00.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-00.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBzcGxpdCBkb21pZCBtYXAgY2xlYW51cCBjaGVjayBpbnRvIGEg
ZnVuY3Rpb24KClRoaXMgbG9naWMgd2lsbCB3YW50IGludm9raW5nIGZyb20g
ZWxzZXdoZXJlLgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UgaW50ZW5kZWQuCgpT
aWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5A
aW50ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKQEAgLTE1Myw2ICsxNTMsNTEgQEAgc3RhdGljIHZvaWQgY2xlYW51
cF9kb21pZF9tYXAoc3RydWN0IGRvbQogICAgIH0KIH0KIAorc3RhdGljIGJv
b2wgYW55X3BkZXZfYmVoaW5kX2lvbW11KGNvbnN0IHN0cnVjdCBkb21haW4g
KmQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg
c3RydWN0IHBjaV9kZXYgKmV4Y2x1ZGUsCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUp
Cit7CisgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXY7CisKKyAgICBm
b3JfZWFjaF9wZGV2ICggZCwgcGRldiApCisgICAgeworICAgICAgICBjb25z
dCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQ7CisKKyAgICAgICAgaWYg
KCBwZGV2ID09IGV4Y2x1ZGUgKQorICAgICAgICAgICAgY29udGludWU7CisK
KyAgICAgICAgZHJoZCA9IGFjcGlfZmluZF9tYXRjaGVkX2RyaGRfdW5pdChw
ZGV2KTsKKyAgICAgICAgaWYgKCBkcmhkICYmIGRyaGQtPmlvbW11ID09IGlv
bW11ICkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKworICAg
IHJldHVybiBmYWxzZTsKK30KKworLyoKKyAqIElmIG5vIG90aGVyIGRldmlj
ZXMgdW5kZXIgdGhlIHNhbWUgaW9tbXUgb3duZWQgYnkgdGhpcyBkb21haW4s
CisgKiBjbGVhciBpb21tdSBpbiBpb21tdV9iaXRtYXAgYW5kIGNsZWFyIGRv
bWFpbl9pZCBpbiBkb21pZF9iaXRtYXAuCisgKi8KK3N0YXRpYyB2b2lkIGNo
ZWNrX2NsZWFudXBfZG9taWRfbWFwKHN0cnVjdCBkb21haW4gKmQsCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg
cGNpX2RldiAqZXhjbHVkZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQoreworICAgIGJv
b2wgZm91bmQgPSBhbnlfcGRldl9iZWhpbmRfaW9tbXUoZCwgZXhjbHVkZSwg
aW9tbXUpOworCisgICAgLyoKKyAgICAgKiBIaWRkZW4gZGV2aWNlcyBhcmUg
YXNzb2NpYXRlZCB3aXRoIERvbVhFTiBidXQgdXNhYmxlIGJ5IHRoZSBoYXJk
d2FyZQorICAgICAqIGRvbWFpbi4gSGVuY2UgdGhleSBuZWVkIGNvbnNpZGVy
aW5nIGhlcmUgYXMgd2VsbC4KKyAgICAgKi8KKyAgICBpZiAoICFmb3VuZCAm
JiBpc19oYXJkd2FyZV9kb21haW4oZCkgKQorICAgICAgICBmb3VuZCA9IGFu
eV9wZGV2X2JlaGluZF9pb21tdShkb21feGVuLCBleGNsdWRlLCBpb21tdSk7
CisKKyAgICBpZiAoICFmb3VuZCApCisgICAgeworICAgICAgICBjbGVhcl9i
aXQoaW9tbXUtPmluZGV4LCAmZG9tX2lvbW11KGQpLT5hcmNoLmlvbW11X2Jp
dG1hcCk7CisgICAgICAgIGNsZWFudXBfZG9taWRfbWFwKGQsIGlvbW11KTsK
KyAgICB9Cit9CisKIHN0YXRpYyBpbnQgaW9tbXVzX2luY29oZXJlbnQ7CiAK
IHN0YXRpYyB2b2lkIHN5bmNfY2FjaGUoY29uc3Qgdm9pZCAqYWRkciwgdW5z
aWduZWQgaW50IHNpemUpCkBAIC0xNjg1LDcgKzE3MzAsNiBAQCBzdGF0aWMg
aW50IGRvbWFpbl9jb250ZXh0X3VubWFwKHN0cnVjdCBkCiAgICAgc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXU7CiAgICAgaW50IHJldCA9IDA7CiAgICAgdTgg
c2VnID0gcGRldi0+c2VnLCBidXMgPSBwZGV2LT5idXMsIHRtcF9idXMsIHRt
cF9kZXZmbiwgc2VjYnVzOwotICAgIGludCBmb3VuZCA9IDA7CiAKICAgICBk
cmhkID0gYWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYpOwogICAg
IGlmICggIWRyaGQgKQpAQCAtMTc2OSwyOCArMTgxMyw4IEBAIHN0YXRpYyBp
bnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3RydWN0IGQKICAgICBpZiAoIHJl
dCApCiAgICAgICAgIGdvdG8gb3V0OwogCi0gICAgLyoKLSAgICAgKiBpZiBu
byBvdGhlciBkZXZpY2VzIHVuZGVyIHRoZSBzYW1lIGlvbW11IG93bmVkIGJ5
IHRoaXMgZG9tYWluLAotICAgICAqIGNsZWFyIGlvbW11IGluIGlvbW11X2Jp
dG1hcCBhbmQgY2xlYXIgZG9tYWluX2lkIGluIGRvbWlkX2JpdG1wCi0gICAg
ICovCi0gICAgZm9yX2VhY2hfcGRldiAoIGRvbWFpbiwgcGRldiApCi0gICAg
ewotICAgICAgICBpZiAoIHBkZXYtPnNlZyA9PSBzZWcgJiYgcGRldi0+YnVz
ID09IGJ1cyAmJiBwZGV2LT5kZXZmbiA9PSBkZXZmbiApCi0gICAgICAgICAg
ICBjb250aW51ZTsKLQotICAgICAgICBkcmhkID0gYWNwaV9maW5kX21hdGNo
ZWRfZHJoZF91bml0KHBkZXYpOwotICAgICAgICBpZiAoIGRyaGQgJiYgZHJo
ZC0+aW9tbXUgPT0gaW9tbXUgKQotICAgICAgICB7Ci0gICAgICAgICAgICBm
b3VuZCA9IDE7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQotICAg
IH0KLQotICAgIGlmICggZm91bmQgPT0gMCApCi0gICAgewotICAgICAgICBj
bGVhcl9iaXQoaW9tbXUtPmluZGV4LCAmZG9tX2lvbW11KGRvbWFpbiktPmFy
Y2guaW9tbXVfYml0bWFwKTsKLSAgICAgICAgY2xlYW51cF9kb21pZF9tYXAo
ZG9tYWluLCBpb21tdSk7Ci0gICAgfQorICAgIGlmICggIXJldCApCisgICAg
ICAgIGNoZWNrX2NsZWFudXBfZG9taWRfbWFwKGRvbWFpbiwgcGRldiwgaW9t
bXUpOwogCiBvdXQ6CiAgICAgcmV0dXJuIHJldDsK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-01.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-01.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggKGRlKWFzc2lnbiBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSB1cGRhdGVkLgoKQWxzbyBhZGp1c3QgYSByZWxhdGVk
IGxvZyBtZXNzYWdlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM1OCAvIHBhcnQg
b2YgWFNBLTQwMC4KCkZpeGVzOiA4Yjk5ZjQ0MDBiNjkgKCJWVC1kOiBmaXgg
Uk1SUiByZWxhdGVkIGVycm9yIGhhbmRsaW5nIikKU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog
Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+ClJldmll
d2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KUmV2aWV3ZWQt
Ynk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgoKLS0tIGEv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAgLTIzOTIsNiAr
MjM5MiwxMCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNo
aXAoCiB7CiAgICAgaW50IHJldDsKIAorICAgIHJldCA9IGRvbWFpbl9jb250
ZXh0X3VubWFwKHNvdXJjZSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0
ICkKKyAgICAgICAgcmV0dXJuIHJldDsKKwogICAgIC8qCiAgICAgICogRGV2
aWNlcyBhc3NpZ25lZCB0byB1bnRydXN0ZWQgZG9tYWlucyAoaGVyZSBhc3N1
bWVkIHRvIGJlIGFueSBkb21VKQogICAgICAqIGNhbiBhdHRlbXB0IHRvIHNl
bmQgYXJiaXRyYXJ5IExBUElDL01TSSBtZXNzYWdlcy4gV2UgYXJlIHVucHJv
dGVjdGVkCkBAIC0yNDI4LDEwICsyNDMyLDYgQEAgc3RhdGljIGludCByZWFz
c2lnbl9kZXZpY2Vfb3duZXJzaGlwKAogICAgICAgICAgICAgfQogICAgIH0K
IAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHNvdXJjZSwgZGV2
Zm4sIHBkZXYpOwotICAgIGlmICggcmV0ICkKLSAgICAgICAgcmV0dXJuIHJl
dDsKLQogICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+
ZG9tYWluICE9IGRvbV9pbyApCiAgICAgewogICAgICAgICBsaXN0X21vdmUo
JnBkZXYtPmRvbWFpbl9saXN0LCAmZG9tX2lvLT5wZGV2X2xpc3QpOwpAQCAt
MjUwOCw5ICsyNTA4LDggQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hc3Np
Z25fZGV2aWNlKAogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0ID0gcmVh
c3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7Ci0g
ICAgaWYgKCByZXQgfHwgZCA9PSBkb21faW8gKQotICAgICAgICByZXR1cm4g
cmV0OworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm4g
cmVhc3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7
CiAKICAgICAvKiBTZXR1cCBybXJyIGlkZW50aXR5IG1hcHBpbmcgKi8KICAg
ICBmb3JfZWFjaF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBpICkKQEAgLTI1
MjMsMjAgKzI1MjIsMzcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hc3Np
Z25fZGV2aWNlKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgZmxhZyk7CiAgICAgICAgICAg
ICBpZiAoIHJldCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAg
aW50IHJjOwotCi0gICAgICAgICAgICAgICAgcmMgPSByZWFzc2lnbl9kZXZp
Y2Vfb3duZXJzaGlwKGQsIHMsIGRldmZuLCBwZGV2KTsKICAgICAgICAgICAg
ICAgICBwcmludGsoWEVOTE9HX0dfRVJSIFZURFBSRUZJWAotICAgICAgICAg
ICAgICAgICAgICAgICAiIGNhbm5vdCBtYXAgcmVzZXJ2ZWQgcmVnaW9uICgl
IlBSSXg2NCIsJSJQUkl4NjQiXSBmb3IgRG9tJWQgKCVkKVxuIiwKLSAgICAg
ICAgICAgICAgICAgICAgICAgcm1yci0+YmFzZV9hZGRyZXNzLCBybXJyLT5l
bmRfYWRkcmVzcywKLSAgICAgICAgICAgICAgICAgICAgICAgZC0+ZG9tYWlu
X2lkLCByZXQpOwotICAgICAgICAgICAgICAgIGlmICggcmMgKQotICAgICAg
ICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlIgVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAi
IGZhaWxlZCB0byByZWNsYWltICUwNHg6JTAyeDolMDJ4LiV1IGZyb20gJXBk
ICglZClcbiIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBzZWcsIGJ1
cywgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksIGQsIHJjKTsK
LSAgICAgICAgICAgICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwotICAgICAg
ICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgICAgICAgIiVwZDogY2Fu
bm90IG1hcCByZXNlcnZlZCByZWdpb24gWyUiUFJJeDY0IiwlIlBSSXg2NCJd
OiAlZFxuIiwKKyAgICAgICAgICAgICAgICAgICAgICAgZCwgcm1yci0+YmFz
ZV9hZGRyZXNzLCBybXJyLT5lbmRfYWRkcmVzcywgcmV0KTsKKyAgICAgICAg
ICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAg
IH0KKworICAgIGlmICggIXJldCApCisgICAgICAgIHJldCA9IHJlYXNzaWdu
X2RldmljZV9vd25lcnNoaXAocywgZCwgZGV2Zm4sIHBkZXYpOworCisgICAg
LyogU2VlIHJlYXNzaWduX2RldmljZV9vd25lcnNoaXAoKSBmb3IgdGhlIGh3
ZG9tIGFzcGVjdC4gKi8KKyAgICBpZiAoICFyZXQgfHwgaXNfaGFyZHdhcmVf
ZG9tYWluKGQpICkKKyAgICAgICAgcmV0dXJuIHJldDsKKworICAgIGZvcl9l
YWNoX3JtcnJfZGV2aWNlKCBybXJyLCBiZGYsIGkgKQorICAgIHsKKyAgICAg
ICAgaWYgKCBybXJyLT5zZWdtZW50ID09IHNlZyAmJgorICAgICAgICAgICAg
IFBDSV9CVVMoYmRmKSA9PSBidXMgJiYKKyAgICAgICAgICAgICBQQ0lfREVW
Rk4yKGJkZikgPT0gZGV2Zm4gKQorICAgICAgICB7CisgICAgICAgICAgICBp
bnQgcmMgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGQsIHAybV9hY2Nlc3Nf
eCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgcm1yci0+YmFzZV9hZGRyZXNzLAorICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7
CisKKyAgICAgICAgICAgIGlmICggcmMgJiYgcmMgIT0gLUVOT0VOVCApCisg
ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19F
UlIgVlREUFJFRklYCisgICAgICAgICAgICAgICAgICAgICAgICIlcGQ6IGNh
bm5vdCB1bm1hcCByZXNlcnZlZCByZWdpb24gWyUiUFJJeDY0IiwlIlBSSXg2
NCJdOiAlZFxuIiwKKyAgICAgICAgICAgICAgICAgICAgICAgZCwgcm1yci0+
YmFzZV9hZGRyZXNzLCBybXJyLT5lbmRfYWRkcmVzcywgcmMpOworICAgICAg
ICAgICAgICAgIGRvbWFpbl9jcmFzaChkKTsKICAgICAgICAgICAgICAgICBi
cmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgfQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-02.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-02.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggYWRkL3JlbW92ZSBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSBjbGVhcmVkLgoKQWxzbyBzd2l0Y2ggdG8gJXBkIGlu
IHJlbGF0ZWQgbG9nIG1lc3NhZ2VzLgoKRml4ZXM6IGZhODhjZmFkZjkxOCAo
InZ0LWQ6IE1hcCBSTVJSIGluIGludGVsX2lvbW11X2FkZF9kZXZpY2UoKSBp
ZiB0aGUgZGV2aWNlIGhhcyBSTVJSIikKRml4ZXM6IDhiOTlmNDQwMGI2OSAo
IlZULWQ6IGZpeCBSTVJSIHJlbGF0ZWQgZXJyb3IgaGFuZGxpbmciKQpTaWdu
ZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJl
dmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4
LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50
ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmMKQEAgLTE5OTMsMTQgKzE5OTMsNiBAQCBzdGF0aWMgaW50IGludGVsX2lv
bW11X2FkZF9kZXZpY2UodTggZGV2CiAgICAgaWYgKCAhcGRldi0+ZG9tYWlu
ICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CiAKLSAgICByZXQgPSBkb21h
aW5fY29udGV4dF9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYp
OwotICAgIGlmICggcmV0ICkKLSAgICB7Ci0gICAgICAgIGRwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgsICJkJWQ6IGNvbnRleHQgbWFwcGluZyBmYWls
ZWRcbiIsCi0gICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluLT5kb21haW5f
aWQpOwotICAgICAgICByZXR1cm4gcmV0OwotICAgIH0KLQogICAgIGZvcl9l
YWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKICAgICB7CiAgICAg
ICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBwZGV2LT5zZWcgJiYKQEAgLTIw
MTcsMTIgKzIwMDksMTcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hZGRf
ZGV2aWNlKHU4IGRldgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRy
ZXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAwKTsKICAgICAgICAgICAgIGlmICggcmV0ICkKLSAgICAgICAgICAgICAg
ICBkcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiZCVkOiBSTVJSIG1h
cHBpbmcgZmFpbGVkXG4iLAotICAgICAgICAgICAgICAgICAgICAgICAgcGRl
di0+ZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAgICAgIGRwcmlu
dGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IFJNUlIgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LT5kb21h
aW4pOwogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuIDA7CisgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZyhwZGV2LT5kb21haW4sIGRl
dmZuLCBwZGV2KTsKKyAgICBpZiAoIHJldCApCisgICAgICAgIGRwcmludGso
WEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IGNvbnRleHQgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluKTsKKwor
ICAgIHJldHVybiByZXQ7CiB9CiAKIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVf
ZW5hYmxlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRldikKQEAgLTIwNDQs
MTEgKzIwNDEsMTUgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVf
ZGV2aWNlKHU4CiB7CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJy
OwogICAgIHUxNiBiZGY7Ci0gICAgaW50IGk7CisgICAgaW50IHJldCwgaTsK
IAogICAgIGlmICggIXBkZXYtPmRvbWFpbiApCiAgICAgICAgIHJldHVybiAt
RUlOVkFMOwogCisgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAocGRl
di0+ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgaWYgKCByZXQgKQorICAg
ICAgICByZXR1cm4gcmV0OworCiAgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2Ug
KCBybXJyLCBiZGYsIGkgKQogICAgIHsKICAgICAgICAgaWYgKCBybXJyLT5z
ZWdtZW50ICE9IHBkZXYtPnNlZyB8fApAQCAtMjA2NCw3ICsyMDY1LDcgQEAg
c3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4CiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3Ms
IDApOwogICAgIH0KIAotICAgIHJldHVybiBkb21haW5fY29udGV4dF91bm1h
cChwZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKKyAgICByZXR1cm4gMDsK
IH0KIAogc3RhdGljIGludCBfX2h3ZG9tX2luaXQgc2V0dXBfaHdkb21fZGV2
aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-03.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBkcm9wIG93bmVyc2hpcCBjaGVja2luZyBmcm9tIGRvbWFpbl9j
b250ZXh0X21hcHBpbmdfb25lKCkKCkRlc3BpdGUgcHV0dGluZyBpbiBxdWl0
ZSBhIGJpdCBvZiBlZmZvcnQgaXQgd2FzIG5vdCBwb3NzaWJsZSB0bwplc3Rh
Ymxpc2ggd2h5IGV4YWN0bHkgdGhpcyBjb2RlIGV4aXN0cyAoYmV5b25kIHBv
c3NpYmx5IHNhbml0eQpjaGVja2luZykuIEluc3RlYWQgb2YgYSBzdWJzZXF1
ZW50IGNoYW5nZSBmdXJ0aGVyIGNvbXBsaWNhdGluZyB0aGlzCmxvZ2ljLCBz
aW1wbHkgZ2V0IHJpZCBvZiBpdC4KClRha2UgdGhlIG9wcG9ydHVuaXR5IGFu
ZCBtb3ZlIHRoZSByZXNwZWN0aXZlIHVubWFwX3Z0ZF9kb21haW5fcGFnZSgp
IG91dApvZiB0aGUgbG9ja2VkIHJlZ2lvbi4KClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdl
ZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5
OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KCi0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCkBAIC0xMTQsMjggKzEx
NCw2IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVj
dAogICAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGNvbnRleHRfZ2V0
X2RvbWFpbl9pZChzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4dCwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQotewotICAgIHVuc2lnbmVkIGxvbmcgZG9tX2luZGV4LCBu
cl9kb207Ci0gICAgaW50IGRvbWlkID0gLTE7Ci0KLSAgICBpZiAoaW9tbXUg
JiYgY29udGV4dCkKLSAgICB7Ci0gICAgICAgIG5yX2RvbSA9IGNhcF9uZG9t
cyhpb21tdS0+Y2FwKTsKLQotICAgICAgICBkb21faW5kZXggPSBjb250ZXh0
X2RvbWFpbl9pZCgqY29udGV4dCk7Ci0KLSAgICAgICAgaWYgKCBkb21faW5k
ZXggPCBucl9kb20gJiYgaW9tbXUtPmRvbWlkX21hcCApCi0gICAgICAgICAg
ICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbZG9tX2luZGV4XTsKLSAgICAg
ICAgZWxzZQotICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfREVCVUcgVlRE
UFJFRklYLAotICAgICAgICAgICAgICAgICAgICAiZG9tX2luZGV4ICVsdSBl
eGNlZWRzIG5yX2RvbSAlbHUgb3IgaW9tbXUgaGFzIG5vIGRvbWlkX21hcFxu
IiwKLSAgICAgICAgICAgICAgICAgICAgZG9tX2luZGV4LCBucl9kb20pOwot
ICAgIH0KLSAgICByZXR1cm4gZG9taWQ7Ci19Ci0KIHN0YXRpYyB2b2lkIGNs
ZWFudXBfZG9taWRfbWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXUpCiB7CiAgICAgaW50IGlvbW11X2RvbWlkID0g
ZG9tYWluX2lvbW11X2RvbWlkKGRvbWFpbiwgaW9tbXUpOwpAQCAtMTM5Miw0
OSArMTM3MCw5IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgK
IAogICAgIGlmICggY29udGV4dF9wcmVzZW50KCpjb250ZXh0KSApCiAgICAg
ewotICAgICAgICBpbnQgcmVzID0gMDsKLQotICAgICAgICAvKiBUcnkgdG8g
Z2V0IGRvbWFpbiBvd25lcnNoaXAgZnJvbSBkZXZpY2Ugc3RydWN0dXJlLiAg
SWYgdGhhdCdzCi0gICAgICAgICAqIG5vdCBhdmFpbGFibGUsIHRyeSB0byBy
ZWFkIGl0IGZyb20gdGhlIGNvbnRleHQgaXRzZWxmLiAqLwotICAgICAgICBp
ZiAoIHBkZXYgKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIHBkZXYt
PmRvbWFpbiAhPSBkb21haW4gKQotICAgICAgICAgICAgewotICAgICAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfR19JTkZPIFZURFBSRUZJWAotICAgICAg
ICAgICAgICAgICAgICAgICAiZCVkOiAlMDR4OiUwMng6JTAyeC4ldSBvd25l
ZCBieSBkJWQhIiwKLSAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5k
b21haW5faWQsCi0gICAgICAgICAgICAgICAgICAgICAgIHNlZywgYnVzLCBQ
Q0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSwKLSAgICAgICAgICAg
ICAgICAgICAgICAgcGRldi0+ZG9tYWluID8gcGRldi0+ZG9tYWluLT5kb21h
aW5faWQgOiAtMSk7Ci0gICAgICAgICAgICAgICAgcmVzID0gLUVJTlZBTDsK
LSAgICAgICAgICAgIH0KLSAgICAgICAgfQotICAgICAgICBlbHNlCi0gICAg
ICAgIHsKLSAgICAgICAgICAgIGludCBjZG9tYWluOwotICAgICAgICAgICAg
Y2RvbWFpbiA9IGNvbnRleHRfZ2V0X2RvbWFpbl9pZChjb250ZXh0LCBpb21t
dSk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIGlmICggY2RvbWFpbiA8
IDAgKQotICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIHByaW50ayhY
RU5MT0dfR19XQVJOSU5HIFZURFBSRUZJWAotICAgICAgICAgICAgICAgICAg
ICAgICAiZCVkOiAlMDR4OiUwMng6JTAyeC4ldSBtYXBwZWQsIGJ1dCBjYW4n
dCBmaW5kIG93bmVyIVxuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgZG9t
YWluLT5kb21haW5faWQsCi0gICAgICAgICAgICAgICAgICAgICAgIHNlZywg
YnVzLCBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7Ci0gICAg
ICAgICAgICAgICAgcmVzID0gLUVJTlZBTDsKLSAgICAgICAgICAgIH0KLSAg
ICAgICAgICAgIGVsc2UgaWYgKCBjZG9tYWluICE9IGRvbWFpbi0+ZG9tYWlu
X2lkICkKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBwcmludGso
WEVOTE9HX0dfSU5GTyBWVERQUkVGSVgKLSAgICAgICAgICAgICAgICAgICAg
ICAgImQlZDogJTA0eDolMDJ4OiUwMnguJXUgYWxyZWFkeSBtYXBwZWQgdG8g
ZCVkISIsCi0gICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWlu
X2lkLAotICAgICAgICAgICAgICAgICAgICAgICBzZWcsIGJ1cywgUENJX1NM
T1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksCi0gICAgICAgICAgICAgICAg
ICAgICAgIGNkb21haW4pOwotICAgICAgICAgICAgICAgIHJlcyA9IC1FSU5W
QUw7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLQotICAgICAgICB1bm1h
cF92dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVzKTsKICAgICAgICAg
c3Bpbl91bmxvY2soJmlvbW11LT5sb2NrKTsKLSAgICAgICAgcmV0dXJuIHJl
czsKKyAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50
cmllcyk7CisgICAgICAgIHJldHVybiAwOwogICAgIH0KIAogICAgIGlmICgg
aW9tbXVfaHdkb21fcGFzc3Rocm91Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWlu
KGRvbWFpbikgKQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-04.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiByZS1hc3NpZ24gZGV2aWNlcyBkaXJlY3RseQoKRGV2aWNlcyB3
aXRoIFJNUlJzLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQgaG93L3do
ZW4gdGhlIHNwZWNpZmllZAptZW1vcnkgcmVnaW9ucyBtYXkgZ2V0IGFjY2Vz
c2VkLCBtYXkgbm90IGJlIGxlZnQgZGlzY29ubmVjdGVkIGZyb20gdGhlaXIK
cmVzcGVjdGl2ZSBtYXBwaW5ncyAoYXMgbG9uZyBhcyBpdCdzIG5vdCBjZXJ0
YWluIHRoYXQgdGhlIGRldmljZSBoYXMKYmVlbiBmdWxseSBxdWllc2NlZCku
IEhlbmNlIHJhdGhlciB0aGFuIHVubWFwcGluZyB0aGUgb2xkIGNvbnRleHQg
YW5kCnRoZW4gbWFwcGluZyB0aGUgbmV3IG9uZSwgcmUtYXNzaWdubWVudCBu
ZWVkcyB0byBiZSBkb25lIGluIGEgc2luZ2xlCnN0ZXAuCgpUaGlzIGlzIENW
RS0yMDIyLTI2MzU5IC8gcGFydCBvZiBYU0EtNDAwLgoKUmVwb3J0ZWQtYnk6
IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKU2lt
aWxhcmx5IHF1YXJhbnRpbmluZyBzY3JhdGNoLXBhZ2UgbW9kZSByZWxpZXMg
b24gcGFnZSB0YWJsZXMgdG8gYmUKY29udGludW91c2x5IHdpcmVkIHVwLgoK
VG8gYXZvaWQgY29tcGxpY2F0aW5nIHRoaW5ncyBtb3JlIHRoYW4gbmVjZXNz
YXJ5LCB0cmVhdCBhbGwgZGV2aWNlcwptb3N0bHkgZXF1YWxseSwgaS5lLiBy
ZWdhcmRsZXNzIG9mIHRoZWlyIGFzc29jaWF0aW9uIHdpdGggYW55IFJNUlJz
LiBUaGUKbWFpbiBkaWZmZXJlbmNlIGlzIHdoZW4gaXQgY29tZXMgdG8gdXBk
YXRpbmcgY29udGV4dCBlbnRyaWVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21p
YyB3aGVuIHRoZXJlIGFyZSBSTVJScy4gWWV0IGF0b21pY2l0eSBjYW4gb25s
eSBiZSBhY2hpZXZlZAp3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBv
ZiB3aGljaCB3ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClRoZSBzZWVtaW5n
bHkgY29tcGxpY2F0ZWQgY2hvaWNlIG9mIG5vbi1uZWdhdGl2ZSByZXR1cm4g
dmFsdWVzIGZvcgpkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgpIGlzIHRv
IGxpbWl0IGNvZGUgY2h1cm46IFRoaXMgd2F5IGNhbGxlcnMKcGFzc2luZyBO
VUxMIGZvciBwZGV2IGRvbid0IG5lZWQgZmlkZGxpbmcgd2l0aC4KClNpZ25l
ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2
aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgpS
ZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp
eC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZXh0
ZXJuLmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2V4dGVy
bi5oCkBAIC04NSw3ICs4NSw4IEBAIHZvaWQgZnJlZV9wZ3RhYmxlX21hZGRy
KHU2NCBtYWRkcik7CiB2b2lkICptYXBfdnRkX2RvbWFpbl9wYWdlKHU2NCBt
YWRkcik7CiB2b2lkIHVubWFwX3Z0ZF9kb21haW5fcGFnZSh2b2lkICp2YSk7
CiBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoc3RydWN0IGRvbWFp
biAqZG9tYWluLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSwKLSAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB1OCBidXMsIHU4IGRldmZuLCBjb25z
dCBzdHJ1Y3QgcGNpX2RldiAqKTsKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB1aW50OF90IGJ1cywgdWludDhfdCBkZXZmbiwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldiwgdW5zaWduZWQgaW50IG1vZGUpOwogaW50IGRvbWFpbl9jb250ZXh0
X3VubWFwX29uZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCB2dGRf
aW9tbXUgKmlvbW11LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
OCBidXMsIHU4IGRldmZuKTsKIGludCBpbnRlbF9pb21tdV9nZXRfcmVzZXJ2
ZWRfZGV2aWNlX21lbW9yeShpb21tdV9ncmRtX3QgKmZ1bmMsIHZvaWQgKmN0
eHQpOwpAQCAtMTA1LDggKzEwNiw4IEBAIGludCBpc19pZ2RfdnRfZW5hYmxl
ZF9xdWlyayh2b2lkKTsKIHZvaWQgcGxhdGZvcm1fcXVpcmtzX2luaXQodm9p
ZCk7CiB2b2lkIHZ0ZF9vcHNfcHJlYW1ibGVfcXVpcmsoc3RydWN0IHZ0ZF9p
b21tdSAqaW9tbXUpOwogdm9pZCB2dGRfb3BzX3Bvc3RhbWJsZV9xdWlyayhz
dHJ1Y3QgdnRkX2lvbW11ICppb21tdSk7Ci1pbnQgX19tdXN0X2NoZWNrIG1l
X3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLAotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHU4IGJ1cywgdTggZGV2Zm4sIGludCBt
YXApOworaW50IF9fbXVzdF9jaGVjayBtZV93aWZpX3F1aXJrKHN0cnVjdCBk
b21haW4gKmRvbWFpbiwgdWludDhfdCBidXMsCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdWludDhfdCBkZXZmbiwgdW5zaWduZWQgaW50IG1v
ZGUpOwogdm9pZCBwY2lfdnRkX3F1aXJrKGNvbnN0IHN0cnVjdCBwY2lfZGV2
ICopOwogdm9pZCBxdWlya19pb21tdV9jYXBzKHN0cnVjdCB2dGRfaW9tbXUg
KmlvbW11KTsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv
aW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t
bXUuYwpAQCAtMTEwLDYgKzExMCw3IEBAIHN0YXRpYyBpbnQgY29udGV4dF9z
ZXRfZG9tYWluX2lkKHN0cnVjdAogICAgIH0KIAogICAgIHNldF9iaXQoaSwg
aW9tbXUtPmRvbWlkX2JpdG1hcCk7CisgICAgY29udGV4dC0+aGkgJj0gfigo
KDEgPDwgRElEX0ZJRUxEX1dJRFRIKSAtIDEpIDw8IERJRF9ISUdIX09GRlNF
VCk7CiAgICAgY29udGV4dC0+aGkgfD0gKGkgJiAoKDEgPDwgRElEX0ZJRUxE
X1dJRFRIKSAtIDEpKSA8PCBESURfSElHSF9PRkZTRVQ7CiAgICAgcmV0dXJu
IDA7CiB9CkBAIC0xMzUwLDE1ICsxMzUxLDI3IEBAIHN0YXRpYyB2b2lkIF9f
aHdkb21faW5pdCBpbnRlbF9pb21tdV9od2QKICAgICB9CiB9CiAKKy8qCisg
KiBUaGlzIGZ1bmN0aW9uIHJldHVybnMKKyAqIC0gYSBuZWdhdGl2ZSBlcnJu
byB2YWx1ZSB1cG9uIGVycm9yLAorICogLSB6ZXJvIHVwb24gc3VjY2VzcyB3
aGVuIHByZXZpb3VzbHkgdGhlIGVudHJ5IHdhcyBub24tcHJlc2VudCwgb3Ig
dGhpcyBpc24ndAorICogICB0aGUgIm1haW4iIHJlcXVlc3QgZm9yIGEgZGV2
aWNlIChwZGV2ID09IE5VTEwpLCBvciBmb3Igbm8tb3AgcXVhcmFudGluaW5n
CisgKiAgIGFzc2lnbm1lbnRzLAorICogLSBwb3NpdGl2ZSAob25lKSB1cG9u
IHN1Y2Nlc3Mgd2hlbiBwcmV2aW91c2x5IHRoZSBlbnRyeSB3YXMgcHJlc2Vu
dCBhbmQgdGhpcworICogICBpcyB0aGUgIm1haW4iIHJlcXVlc3QgZm9yIGEg
ZGV2aWNlIChwZGV2ICE9IE5VTEwpLgorICovCiBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZ19vbmUoCiAgICAgc3RydWN0IGRvbWFpbiAqZG9tYWluLAog
ICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAotICAgIHU4IGJ1cywgdTgg
ZGV2Zm4sIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQorICAgIHVpbnQ4
X3QgYnVzLCB1aW50OF90IGRldmZuLCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldiwKKyAgICB1bnNpZ25lZCBpbnQgbW9kZSkKIHsKICAgICBzdHJ1Y3Qg
ZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21haW4pOwotICAgIHN0
cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LCAqY29udGV4dF9lbnRyaWVz
OworICAgIHN0cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LCAqY29udGV4
dF9lbnRyaWVzLCBsY3R4dDsKKyAgICBfX3VpbnQxMjhfdCBvbGQ7CiAgICAg
dTY0IG1hZGRyLCBwZ2RfbWFkZHI7Ci0gICAgdTE2IHNlZyA9IGlvbW11LT5k
cmhkLT5zZWdtZW50OworICAgIHVpbnQxNl90IHNlZyA9IGlvbW11LT5kcmhk
LT5zZWdtZW50LCBwcmV2X2RpZCA9IDA7CisgICAgc3RydWN0IGRvbWFpbiAq
cHJldl9kb20gPSBOVUxMOwogICAgIGludCBhZ2F3LCByYywgcmV0OwogICAg
IGJvb2xfdCBmbHVzaF9kZXZfaW90bGI7CiAKQEAgLTEzNjcsMTcgKzEzODAs
MzIgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIG1h
ZGRyID0gYnVzX3RvX2NvbnRleHRfbWFkZHIoaW9tbXUsIGJ1cyk7CiAgICAg
Y29udGV4dF9lbnRyaWVzID0gKHN0cnVjdCBjb250ZXh0X2VudHJ5ICopbWFw
X3Z0ZF9kb21haW5fcGFnZShtYWRkcik7CiAgICAgY29udGV4dCA9ICZjb250
ZXh0X2VudHJpZXNbZGV2Zm5dOworICAgIG9sZCA9IChsY3R4dCA9ICpjb250
ZXh0KS5mdWxsOwogCi0gICAgaWYgKCBjb250ZXh0X3ByZXNlbnQoKmNvbnRl
eHQpICkKKyAgICBpZiAoIGNvbnRleHRfcHJlc2VudChsY3R4dCkgKQogICAg
IHsKLSAgICAgICAgc3Bpbl91bmxvY2soJmlvbW11LT5sb2NrKTsKLSAgICAg
ICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7Ci0g
ICAgICAgIHJldHVybiAwOworICAgICAgICBkb21pZF90IGRvbWlkOworCisg
ICAgICAgIHByZXZfZGlkID0gY29udGV4dF9kb21haW5faWQobGN0eHQpOwor
ICAgICAgICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbcHJldl9kaWRdOwor
ICAgICAgICBpZiAoIGRvbWlkIDwgRE9NSURfRklSU1RfUkVTRVJWRUQgKQor
ICAgICAgICAgICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW5fYnlfaWQo
ZG9taWQpOworICAgICAgICBlbHNlIGlmICggZG9taWQgPT0gRE9NSURfSU8g
KQorICAgICAgICAgICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW4oZG9t
X2lvKTsKKyAgICAgICAgaWYgKCAhcHJldl9kb20gKQorICAgICAgICB7Cisg
ICAgICAgICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOworICAgICAg
ICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7
CisgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19ERUJVRyBWVERQUkVGSVgs
CisgICAgICAgICAgICAgICAgICAgICJubyBkb21haW4gZm9yIGRpZCAldSAo
bnJfZG9tICV1KVxuIiwKKyAgICAgICAgICAgICAgICAgICAgcHJldl9kaWQs
IGNhcF9uZG9tcyhpb21tdS0+Y2FwKSk7CisgICAgICAgICAgICByZXR1cm4g
LUVTUkNIOworICAgICAgICB9CiAgICAgfQogCiAgICAgaWYgKCBpb21tdV9o
d2RvbV9wYXNzdGhyb3VnaCAmJiBpc19oYXJkd2FyZV9kb21haW4oZG9tYWlu
KSApCiAgICAgewotICAgICAgICBjb250ZXh0X3NldF90cmFuc2xhdGlvbl90
eXBlKCpjb250ZXh0LCBDT05URVhUX1RUX1BBU1NfVEhSVSk7CisgICAgICAg
IGNvbnRleHRfc2V0X3RyYW5zbGF0aW9uX3R5cGUobGN0eHQsIENPTlRFWFRf
VFRfUEFTU19USFJVKTsKICAgICAgICAgYWdhdyA9IGxldmVsX3RvX2FnYXco
aW9tbXUtPm5yX3B0X2xldmVscyk7CiAgICAgfQogICAgIGVsc2UKQEAgLTEz
OTQsNiArMTQyMiw4IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29u
ZSgKICAgICAgICAgICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFw
cGluZ19sb2NrKTsKICAgICAgICAgICAgICAgICBzcGluX3VubG9jaygmaW9t
bXUtPmxvY2spOwogICAgICAgICAgICAgICAgIHVubWFwX3Z0ZF9kb21haW5f
cGFnZShjb250ZXh0X2VudHJpZXMpOworICAgICAgICAgICAgICAgIGlmICgg
cHJldl9kb20gKQorICAgICAgICAgICAgICAgICAgICByY3VfdW5sb2NrX2Rv
bWFpbihwcmV2X2RvbSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9N
RU07CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KQEAgLTE0MTEsMzMgKzE0
NDEsMTAyIEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAg
ICAgICAgICAgICAgICBnb3RvIG5vbWVtOwogICAgICAgICB9CiAKLSAgICAg
ICAgY29udGV4dF9zZXRfYWRkcmVzc19yb290KCpjb250ZXh0LCBwZ2RfbWFk
ZHIpOworICAgICAgICBjb250ZXh0X3NldF9hZGRyZXNzX3Jvb3QobGN0eHQs
IHBnZF9tYWRkcik7CiAgICAgICAgIGlmICggYXRzX2VuYWJsZWQgJiYgZWNh
cF9kZXZfaW90bGIoaW9tbXUtPmVjYXApICkKLSAgICAgICAgICAgIGNvbnRl
eHRfc2V0X3RyYW5zbGF0aW9uX3R5cGUoKmNvbnRleHQsIENPTlRFWFRfVFRf
REVWX0lPVExCKTsKKyAgICAgICAgICAgIGNvbnRleHRfc2V0X3RyYW5zbGF0
aW9uX3R5cGUobGN0eHQsIENPTlRFWFRfVFRfREVWX0lPVExCKTsKICAgICAg
ICAgZWxzZQotICAgICAgICAgICAgY29udGV4dF9zZXRfdHJhbnNsYXRpb25f
dHlwZSgqY29udGV4dCwgQ09OVEVYVF9UVF9NVUxUSV9MRVZFTCk7CisgICAg
ICAgICAgICBjb250ZXh0X3NldF90cmFuc2xhdGlvbl90eXBlKGxjdHh0LCBD
T05URVhUX1RUX01VTFRJX0xFVkVMKTsKIAogICAgICAgICBzcGluX3VubG9j
aygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKICAgICB9CiAKLSAgICBpZiAo
IGNvbnRleHRfc2V0X2RvbWFpbl9pZChjb250ZXh0LCBkb21haW4sIGlvbW11
KSApCisgICAgcmMgPSBjb250ZXh0X3NldF9kb21haW5faWQoJmxjdHh0LCBk
b21haW4sIGlvbW11KTsKKyAgICBpZiAoIHJjICkKICAgICB7CisgICAgdW5s
b2NrOgogICAgICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOwogICAg
ICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVzKTsK
LSAgICAgICAgcmV0dXJuIC1FRkFVTFQ7CisgICAgICAgIGlmICggcHJldl9k
b20gKQorICAgICAgICAgICAgcmN1X3VubG9ja19kb21haW4ocHJldl9kb20p
OworICAgICAgICByZXR1cm4gcmM7CisgICAgfQorCisgICAgaWYgKCAhcHJl
dl9kb20gKQorICAgIHsKKyAgICAgICAgY29udGV4dF9zZXRfYWRkcmVzc193
aWR0aChsY3R4dCwgYWdhdyk7CisgICAgICAgIGNvbnRleHRfc2V0X2ZhdWx0
X2VuYWJsZShsY3R4dCk7CisgICAgICAgIGNvbnRleHRfc2V0X3ByZXNlbnQo
bGN0eHQpOworICAgIH0KKyAgICBlbHNlIGlmICggcHJldl9kb20gPT0gZG9t
YWluICkKKyAgICB7CisgICAgICAgIEFTU0VSVChsY3R4dC5mdWxsID09IGNv
bnRleHQtPmZ1bGwpOworICAgICAgICByYyA9ICEhcGRldjsKKyAgICAgICAg
Z290byB1bmxvY2s7CisgICAgfQorICAgIGVsc2UKKyAgICB7CisgICAgICAg
IEFTU0VSVChjb250ZXh0X2FkZHJlc3Nfd2lkdGgobGN0eHQpID09IGFnYXcp
OworICAgICAgICBBU1NFUlQoIWNvbnRleHRfZmF1bHRfZGlzYWJsZShsY3R4
dCkpOworICAgIH0KKworICAgIGlmICggY3B1X2hhc19jeDE2ICkKKyAgICB7
CisgICAgICAgIF9fdWludDEyOF90IHJlcyA9IGNtcHhjaGcxNmIoY29udGV4
dCwgJm9sZCwgJmxjdHh0LmZ1bGwpOworCisgICAgICAgIC8qCisgICAgICAg
ICAqIEhhcmR3YXJlIGRvZXMgbm90IHVwZGF0ZSB0aGUgY29udGV4dCBlbnRy
eSBiZWhpbmQgb3VyIGJhY2tzLAorICAgICAgICAgKiBzbyB0aGUgcmV0dXJu
IHZhbHVlIHNob3VsZCBtYXRjaCAib2xkIi4KKyAgICAgICAgICovCisgICAg
ICAgIGlmICggcmVzICE9IG9sZCApCisgICAgICAgIHsKKyAgICAgICAgICAg
IGlmICggcGRldiApCisgICAgICAgICAgICAgICAgY2hlY2tfY2xlYW51cF9k
b21pZF9tYXAoZG9tYWluLCBwZGV2LCBpb21tdSk7CisgICAgICAgICAgICBw
cmludGsoWEVOTE9HX0VSUgorICAgICAgICAgICAgICAgICAgICIlMDR4OiUw
Mng6JTAyeC4ldTogdW5leHBlY3RlZCBjb250ZXh0IGVudHJ5ICUwMTZseF8l
MDE2bHggKGV4cGVjdGVkICUwMTZseF8lMDE2bHgpXG4iLAorICAgICAgICAg
ICAgICAgICAgIHBkZXYtPnNlZywgcGRldi0+YnVzLCBQQ0lfU0xPVChkZXZm
biksIFBDSV9GVU5DKGRldmZuKSwKKyAgICAgICAgICAgICAgICAgICAodWlu
dDY0X3QpKHJlcyA+PiA2NCksICh1aW50NjRfdClyZXMsCisgICAgICAgICAg
ICAgICAgICAgKHVpbnQ2NF90KShvbGQgPj4gNjQpLCAodWludDY0X3Qpb2xk
KTsKKyAgICAgICAgICAgIHJjID0gLUVJTFNFUTsKKyAgICAgICAgICAgIGdv
dG8gdW5sb2NrOworICAgICAgICB9CisgICAgfQorICAgIGVsc2UgaWYgKCAh
cHJldl9kb20gfHwgIShtb2RlICYgTUFQX1dJVEhfUk1SUikgKQorICAgIHsK
KyAgICAgICAgY29udGV4dF9jbGVhcl9wcmVzZW50KCpjb250ZXh0KTsKKyAg
ICAgICAgaW9tbXVfc3luY19jYWNoZShjb250ZXh0LCBzaXplb2YoKmNvbnRl
eHQpKTsKKworICAgICAgICB3cml0ZV9hdG9taWMoJmNvbnRleHQtPmhpLCBs
Y3R4dC5oaSk7CisgICAgICAgIC8qIE5vIGJhcnJpZXIgc2hvdWxkIGJlIG5l
ZWRlZCBiZXR3ZWVuIHRoZXNlIHR3by4gKi8KKyAgICAgICAgd3JpdGVfYXRv
bWljKCZjb250ZXh0LT5sbywgbGN0eHQubG8pOworICAgIH0KKyAgICBlbHNl
IC8qIEJlc3QgZWZmb3J0LCB1cGRhdGluZyBESUQgbGFzdC4gKi8KKyAgICB7
CisgICAgICAgICAvKgorICAgICAgICAgICogQnkgbm9uLWF0b21pY2FsbHkg
dXBkYXRpbmcgdGhlIGNvbnRleHQgZW50cnkncyBESUQgZmllbGQgbGFzdCwK
KyAgICAgICAgICAqIGR1cmluZyBhIHNob3J0IHdpbmRvdyBpbiB0aW1lIFRM
QiBlbnRyaWVzIHdpdGggdGhlIG9sZCBkb21haW4gSUQKKyAgICAgICAgICAq
IGJ1dCB0aGUgbmV3IHBhZ2UgdGFibGVzIG1heSBiZSBpbnNlcnRlZC4gIFRo
aXMgY291bGQgYWZmZWN0IEkvTworICAgICAgICAgICogb2Ygb3RoZXIgZGV2
aWNlcyB1c2luZyB0aGlzIHNhbWUgKG9sZCkgZG9tYWluIElELiAgU3VjaCB1
cGRhdGluZworICAgICAgICAgICogdGhlcmVmb3JlIGlzIG5vdCBhIHByb2Js
ZW0gaWYgdGhpcyB3YXMgdGhlIG9ubHkgZGV2aWNlIGFzc29jaWF0ZWQKKyAg
ICAgICAgICAqIHdpdGggdGhlIG9sZCBkb21haW4gSUQuICBEaXZlcnRpbmcg
SS9PIG9mIGFueSBvZiBhIGR5aW5nIGRvbWFpbidzCisgICAgICAgICAgKiBk
ZXZpY2VzIHRvIHRoZSBxdWFyYW50aW5lIHBhZ2UgdGFibGVzIGlzIGludGVu
ZGVkIGFueXdheS4KKyAgICAgICAgICAqLworICAgICAgICBpZiAoICEobW9k
ZSAmIChNQVBfT1dORVJfRFlJTkcgfCBNQVBfU0lOR0xFX0RFVklDRSkpICkK
KyAgICAgICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORyBWVERQUkVGSVgK
KyAgICAgICAgICAgICAgICAgICAiICUwNHg6JTAyeDolMDJ4LiV1OiByZWFz
c2lnbm1lbnQgbWF5IGNhdXNlICVwZCBkYXRhIGNvcnJ1cHRpb25cbiIsCisg
ICAgICAgICAgICAgICAgICAgc2VnLCBidXMsIFBDSV9TTE9UKGRldmZuKSwg
UENJX0ZVTkMoZGV2Zm4pLCBwcmV2X2RvbSk7CisKKyAgICAgICAgd3JpdGVf
YXRvbWljKCZjb250ZXh0LT5sbywgbGN0eHQubG8pOworICAgICAgICAvKiBO
byBiYXJyaWVyIHNob3VsZCBiZSBuZWVkZWQgYmV0d2VlbiB0aGVzZSB0d28u
ICovCisgICAgICAgIHdyaXRlX2F0b21pYygmY29udGV4dC0+aGksIGxjdHh0
LmhpKTsKICAgICB9CiAKLSAgICBjb250ZXh0X3NldF9hZGRyZXNzX3dpZHRo
KCpjb250ZXh0LCBhZ2F3KTsKLSAgICBjb250ZXh0X3NldF9mYXVsdF9lbmFi
bGUoKmNvbnRleHQpOwotICAgIGNvbnRleHRfc2V0X3ByZXNlbnQoKmNvbnRl
eHQpOwogICAgIGlvbW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6ZW9mKHN0
cnVjdCBjb250ZXh0X2VudHJ5KSk7CiAgICAgc3Bpbl91bmxvY2soJmlvbW11
LT5sb2NrKTsKIAotICAgIC8qIENvbnRleHQgZW50cnkgd2FzIHByZXZpb3Vz
bHkgbm9uLXByZXNlbnQgKHdpdGggZG9taWQgMCkuICovCi0gICAgcmMgPSBp
b21tdV9mbHVzaF9jb250ZXh0X2RldmljZShpb21tdSwgMCwgUENJX0JERjIo
YnVzLCBkZXZmbiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBETUFfQ0NNRF9NQVNLX05PQklULCAxKTsKKyAgICByYyA9IGlvbW11
X2ZsdXNoX2NvbnRleHRfZGV2aWNlKGlvbW11LCBwcmV2X2RpZCwgUENJX0JE
RjIoYnVzLCBkZXZmbiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBETUFfQ0NNRF9NQVNLX05PQklULCAhcHJldl9kb20pOwogICAg
IGZsdXNoX2Rldl9pb3RsYiA9ICEhZmluZF9hdHNfZGV2X2RyaGQoaW9tbXUp
OwotICAgIHJldCA9IGlvbW11X2ZsdXNoX2lvdGxiX2RzaShpb21tdSwgMCwg
MSwgZmx1c2hfZGV2X2lvdGxiKTsKKyAgICByZXQgPSBpb21tdV9mbHVzaF9p
b3RsYl9kc2koaW9tbXUsIHByZXZfZGlkLCAhcHJldl9kb20sIGZsdXNoX2Rl
dl9pb3RsYik7CiAKICAgICAvKgogICAgICAqIFRoZSBjdXJyZW50IGxvZ2lj
IGZvciByZXR1cm5zOgpAQCAtMTQ1OCwxMiArMTU1NywyMSBAQCBpbnQgZG9t
YWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgdW5tYXBfdnRkX2RvbWFp
bl9wYWdlKGNvbnRleHRfZW50cmllcyk7CiAKICAgICBpZiAoICFzZWcgJiYg
IXJjICkKLSAgICAgICAgcmMgPSBtZV93aWZpX3F1aXJrKGRvbWFpbiwgYnVz
LCBkZXZmbiwgTUFQX01FX1BIQU5UT01fRlVOQyk7CisgICAgICAgIHJjID0g
bWVfd2lmaV9xdWlyayhkb21haW4sIGJ1cywgZGV2Zm4sIG1vZGUpOwogCiAg
ICAgaWYgKCByYyApCi0gICAgICAgIGRvbWFpbl9jb250ZXh0X3VubWFwX29u
ZShkb21haW4sIGlvbW11LCBidXMsIGRldmZuKTsKKyAgICB7CisgICAgICAg
IGlmICggIXByZXZfZG9tICkKKyAgICAgICAgICAgIGRvbWFpbl9jb250ZXh0
X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMsIGRldmZuKTsKKyAgICAg
ICAgZWxzZSBpZiAoIHByZXZfZG9tICE9IGRvbWFpbiApIC8qIEF2b2lkIGlu
ZmluaXRlIHJlY3Vyc2lvbi4gKi8KKyAgICAgICAgICAgIGRvbWFpbl9jb250
ZXh0X21hcHBpbmdfb25lKHByZXZfZG9tLCBpb21tdSwgYnVzLCBkZXZmbiwg
cGRldiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IG1vZGUgJiBNQVBfV0lUSF9STVJSKTsKKyAgICB9CiAKLSAgICByZXR1cm4g
cmM7CisgICAgaWYgKCBwcmV2X2RvbSApCisgICAgICAgIHJjdV91bmxvY2tf
ZG9tYWluKHByZXZfZG9tKTsKKworICAgIHJldHVybiByYyA/OiBwZGV2ICYm
IHByZXZfZG9tOwogfQogCiBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X3Vu
bWFwKHN0cnVjdCBkb21haW4gKmQsIHVpbnQ4X3QgZGV2Zm4sCkBAIC0xNDcz
LDggKzE1ODEsMTEgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBw
aW5nKHN0cnVjdAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQogewogICAgIHN0cnVjdCBhY3BpX2Ry
aGRfdW5pdCAqZHJoZDsKKyAgICBjb25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3Vu
aXQgKnJtcnI7CiAgICAgaW50IHJldCA9IDA7Ci0gICAgdTggc2VnID0gcGRl
di0+c2VnLCBidXMgPSBwZGV2LT5idXMsIHNlY2J1czsKKyAgICB1bnNpZ25l
ZCBpbnQgaSwgbW9kZSA9IDA7CisgICAgdWludDE2X3Qgc2VnID0gcGRldi0+
c2VnLCBiZGY7CisgICAgdWludDhfdCBidXMgPSBwZGV2LT5idXMsIHNlY2J1
czsKIAogICAgIGRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQo
cGRldik7CiAgICAgaWYgKCAhZHJoZCApCkBAIC0xNDkzLDggKzE2MDQsMjkg
QEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAog
CiAgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOwogCisgICAgZm9yX2Vh
Y2hfcm1ycl9kZXZpY2UoIHJtcnIsIGJkZiwgaSApCisgICAgeworICAgICAg
ICBpZiAoIHJtcnItPnNlZ21lbnQgIT0gcGRldi0+c2VnIHx8IGJkZiAhPSBw
ZGV2LT5zYmRmLmJkZiApCisgICAgICAgICAgICBjb250aW51ZTsKKworICAg
ICAgICBtb2RlIHw9IE1BUF9XSVRIX1JNUlI7CisgICAgICAgIGJyZWFrOwor
ICAgIH0KKworICAgIGlmICggZG9tYWluICE9IHBkZXYtPmRvbWFpbiApCisg
ICAgeworICAgICAgICBpZiAoIHBkZXYtPmRvbWFpbi0+aXNfZHlpbmcgKQor
ICAgICAgICAgICAgbW9kZSB8PSBNQVBfT1dORVJfRFlJTkc7CisgICAgICAg
IGVsc2UgaWYgKCBkcmhkICYmCisgICAgICAgICAgICAgICAgICAhYW55X3Bk
ZXZfYmVoaW5kX2lvbW11KHBkZXYtPmRvbWFpbiwgcGRldiwgZHJoZC0+aW9t
bXUpICYmCisgICAgICAgICAgICAgICAgICAhcGRldi0+cGhhbnRvbV9zdHJp
ZGUgKQorICAgICAgICAgICAgbW9kZSB8PSBNQVBfU0lOR0xFX0RFVklDRTsK
KyAgICB9CisKICAgICBzd2l0Y2ggKCBwZGV2LT50eXBlICkKICAgICB7Cisg
ICAgICAgIGJvb2wgcHJldl9wcmVzZW50OworCiAgICAgY2FzZSBERVZfVFlQ
RV9QQ0lfSE9TVF9CUklER0U6CiAgICAgICAgIGlmICggaW9tbXVfZGVidWcg
KQogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiZCVkOkhvc3Ricmlk
Z2U6IHNraXAgJTA0eDolMDJ4OiUwMnguJXUgbWFwXG4iLApAQCAtMTUxNSw3
ICsxNjQ3LDkgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5n
KHN0cnVjdAogICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lk
LCBzZWcsIGJ1cywKICAgICAgICAgICAgICAgICAgICBQQ0lfU0xPVChkZXZm
biksIFBDSV9GVU5DKGRldmZuKSk7CiAgICAgICAgIHJldCA9IGRvbWFpbl9j
b250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywg
ZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHBkZXYpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBwZGV2LCBtb2RlKTsKKyAgICAgICAgaWYgKCByZXQgPiAwICkK
KyAgICAgICAgICAgIHJldCA9IDA7CiAgICAgICAgIGlmICggIXJldCAmJiBk
ZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBhdHNfZGV2aWNlKHBkZXYsIGRyaGQp
ID4gMCApCiAgICAgICAgICAgICBlbmFibGVfYXRzX2RldmljZShwZGV2LCAm
ZHJoZC0+aW9tbXUtPmF0c19kZXZpY2VzKTsKIApAQCAtMTUyOCw5ICsxNjYy
LDEwIEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1
Y3QKICAgICAgICAgICAgICAgICAgICBQQ0lfU0xPVChkZXZmbiksIFBDSV9G
VU5DKGRldmZuKSk7CiAKICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRf
bWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRl
dik7Ci0gICAgICAgIGlmICggcmV0ICkKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgcGRldiwgbW9kZSk7CisgICAgICAgIGlm
ICggcmV0IDwgMCApCiAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgcHJl
dl9wcmVzZW50ID0gcmV0OwogCiAgICAgICAgIGlmICggKHJldCA9IGZpbmRf
dXBzdHJlYW1fYnJpZGdlKHNlZywgJmJ1cywgJmRldmZuLCAmc2VjYnVzKSkg
PCAxICkKICAgICAgICAgewpAQCAtMTUzOCw2ICsxNjczLDE1IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAg
ICAgICAgICBicmVhazsKICAgICAgICAgICAgIHJldCA9IC1FTlhJTzsKICAg
ICAgICAgfQorICAgICAgICAvKgorICAgICAgICAgKiBTdHJpY3RseSBzcGVh
a2luZyBpZiB0aGUgZGV2aWNlIGlzIHRoZSBvbmx5IG9uZSBiZWhpbmQgdGhp
cyBicmlkZ2UKKyAgICAgICAgICogYW5kIHRoZSBvbmx5IG9uZSB3aXRoIHRo
aXMgKHNlY2J1cywwLDApIHR1cGxlLCBpdCBjb3VsZCBiZSBhbGxvd2VkCisg
ICAgICAgICAqIHRvIGJlIHJlLWFzc2lnbmVkIHJlZ2FyZGxlc3Mgb2YgUk1S
UiBwcmVzZW5jZS4gIEJ1dCBsZXQncyBkZWFsIHdpdGgKKyAgICAgICAgICog
dGhhdCBjYXNlIG9ubHkgaWYgaXQgaXMgYWN0dWFsbHkgZm91bmQgaW4gdGhl
IHdpbGQuCisgICAgICAgICAqLworICAgICAgICBlbHNlIGlmICggcHJldl9w
cmVzZW50ICYmIChtb2RlICYgTUFQX1dJVEhfUk1SUikgJiYKKyAgICAgICAg
ICAgICAgICAgIGRvbWFpbiAhPSBwZGV2LT5kb21haW4gKQorICAgICAgICAg
ICAgcmV0ID0gLUVPUE5PVFNVUFA7CiAKICAgICAgICAgLyoKICAgICAgICAg
ICogTWFwcGluZyBhIGJyaWRnZSBzaG91bGQsIGlmIGFueXRoaW5nLCBwYXNz
IHRoZSBzdHJ1Y3QgcGNpX2RldiBvZgpAQCAtMTU0Niw3ICsxNjkwLDcgQEAg
c3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAg
ICAgICAgKi8KICAgICAgICAgaWYgKCByZXQgPj0gMCApCiAgICAgICAgICAg
ICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRy
aGQtPmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCk7CisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBtb2RlKTsK
IAogICAgICAgICAvKgogICAgICAgICAgKiBEZXZpY2VzIGJlaGluZCBQQ0ll
LXRvLVBDSS9QQ0l4IGJyaWRnZSBtYXkgZ2VuZXJhdGUgZGlmZmVyZW50CkBA
IC0xNTYxLDEwICsxNzA1LDE1IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgaWYgKCAhcmV0ICYmIHBkZXZf
dHlwZShzZWcsIGJ1cywgZGV2Zm4pID09IERFVl9UWVBFX1BDSWUyUENJX0JS
SURHRSAmJgogICAgICAgICAgICAgIChzZWNidXMgIT0gcGRldi0+YnVzIHx8
IHBkZXYtPmRldmZuICE9IDApICkKICAgICAgICAgICAgIHJldCA9IGRvbWFp
bl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIHNl
Y2J1cywgMCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIE5VTEwpOworICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgTlVMTCwgbW9kZSk7CiAKICAgICAgICAgaWYg
KCByZXQgKQotICAgICAgICAgICAgZG9tYWluX2NvbnRleHRfdW5tYXAoZG9t
YWluLCBkZXZmbiwgcGRldik7CisgICAgICAgIHsKKyAgICAgICAgICAgIGlm
ICggIXByZXZfcHJlc2VudCApCisgICAgICAgICAgICAgICAgZG9tYWluX2Nv
bnRleHRfdW5tYXAoZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgICAgICAg
ICBlbHNlIGlmICggcGRldi0+ZG9tYWluICE9IGRvbWFpbiApIC8qIEF2b2lk
IGluZmluaXRlIHJlY3Vyc2lvbi4gKi8KKyAgICAgICAgICAgICAgICBkb21h
aW5fY29udGV4dF9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYp
OworICAgICAgICB9CiAKICAgICAgICAgYnJlYWs7CiAKQEAgLTIzMzEsOSAr
MjQ4MCw4IEBAIHN0YXRpYyBpbnQgcmVhc3NpZ25fZGV2aWNlX293bmVyc2hp
cCgKIHsKICAgICBpbnQgcmV0OwogCi0gICAgcmV0ID0gZG9tYWluX2NvbnRl
eHRfdW5tYXAoc291cmNlLCBkZXZmbiwgcGRldik7Ci0gICAgaWYgKCByZXQg
KQotICAgICAgICByZXR1cm4gcmV0OworICAgIGlmICggIWhhc19hcmNoX3Bk
ZXZzKHRhcmdldCkgKQorICAgICAgICB2bXhfcGlfaG9va3NfYXNzaWduKHRh
cmdldCk7CiAKICAgICAvKgogICAgICAqIERldmljZXMgYXNzaWduZWQgdG8g
dW50cnVzdGVkIGRvbWFpbnMgKGhlcmUgYXNzdW1lZCB0byBiZSBhbnkgZG9t
VSkKQEAgLTIzNDMsNiArMjQ5MSwzMSBAQCBzdGF0aWMgaW50IHJlYXNzaWdu
X2RldmljZV9vd25lcnNoaXAoCiAgICAgaWYgKCAodGFyZ2V0ICE9IGhhcmR3
YXJlX2RvbWFpbikgJiYgIWlvbW11X2ludHJlbWFwICkKICAgICAgICAgdW50
cnVzdGVkX21zaSA9IHRydWU7CiAKKyAgICByZXQgPSBkb21haW5fY29udGV4
dF9tYXBwaW5nKHRhcmdldCwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0
ICkKKyAgICB7CisgICAgICAgIGlmICggIWhhc19hcmNoX3BkZXZzKHRhcmdl
dCkgKQorICAgICAgICAgICAgdm14X3BpX2hvb2tzX2RlYXNzaWduKHRhcmdl
dCk7CisgICAgICAgIHJldHVybiByZXQ7CisgICAgfQorCisgICAgaWYgKCBw
ZGV2LT5kZXZmbiA9PSBkZXZmbiApCisgICAgeworICAgICAgICBjb25zdCBz
dHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hl
ZF9kcmhkX3VuaXQocGRldik7CisKKyAgICAgICAgaWYgKCBkcmhkICkKKyAg
ICAgICAgICAgIGNoZWNrX2NsZWFudXBfZG9taWRfbWFwKHNvdXJjZSwgcGRl
diwgZHJoZC0+aW9tbXUpOworICAgIH0KKworICAgIGlmICggZGV2Zm4gPT0g
cGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWluICE9IHRhcmdldCApCisgICAg
eworICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFy
Z2V0LT5wZGV2X2xpc3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJn
ZXQ7CisgICAgfQorCisgICAgaWYgKCAhaGFzX2FyY2hfcGRldnMoc291cmNl
KSApCisgICAgICAgIHZteF9waV9ob29rc19kZWFzc2lnbihzb3VyY2UpOwor
CiAgICAgLyoKICAgICAgKiBJZiB0aGUgZGV2aWNlIGJlbG9uZ3MgdG8gdGhl
IGhhcmR3YXJlIGRvbWFpbiwgYW5kIGl0IGhhcyBSTVJSLCBkb24ndAogICAg
ICAqIHJlbW92ZSBpdCBmcm9tIHRoZSBoYXJkd2FyZSBkb21haW4sIGJlY2F1
c2UgQklPUyBtYXkgdXNlIFJNUlIgYXQKQEAgLTIzNzEsMzQgKzI1NDQsNyBA
QCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNoaXAoCiAgICAg
ICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKCBkZXZmbiA9PSBwZGV2LT5k
ZXZmbiAmJiBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkKLSAgICB7Ci0gICAg
ICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZkb21faW8tPnBk
ZXZfbGlzdCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9IGRvbV9pbzsKLSAg
ICB9Ci0KLSAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyhzb3VyY2UpICkKLSAg
ICAgICAgdm14X3BpX2hvb2tzX2RlYXNzaWduKHNvdXJjZSk7Ci0KLSAgICBp
ZiAoICFoYXNfYXJjaF9wZGV2cyh0YXJnZXQpICkKLSAgICAgICAgdm14X3Bp
X2hvb2tzX2Fzc2lnbih0YXJnZXQpOwotCi0gICAgcmV0ID0gZG9tYWluX2Nv
bnRleHRfbWFwcGluZyh0YXJnZXQsIGRldmZuLCBwZGV2KTsKLSAgICBpZiAo
IHJldCApCi0gICAgewotICAgICAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyh0
YXJnZXQpICkKLSAgICAgICAgICAgIHZteF9waV9ob29rc19kZWFzc2lnbih0
YXJnZXQpOwotCi0gICAgICAgIHJldHVybiByZXQ7Ci0gICAgfQotCi0gICAg
aWYgKCBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21haW4gIT0g
dGFyZ2V0ICkKLSAgICB7Ci0gICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9t
YWluX2xpc3QsICZ0YXJnZXQtPnBkZXZfbGlzdCk7Ci0gICAgICAgIHBkZXYt
PmRvbWFpbiA9IHRhcmdldDsKLSAgICB9Ci0KLSAgICByZXR1cm4gcmV0Owor
ICAgIHJldHVybiAwOwogfQogCiBzdGF0aWMgaW50IGludGVsX2lvbW11X2Fz
c2lnbl9kZXZpY2UoCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0
ZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9p
b21tdS5oCkBAIC0yMDIsOCArMjAyLDEyIEBAIHN0cnVjdCByb290X2VudHJ5
IHsKICAgICBkbyB7KHJvb3QpLnZhbCB8PSAoKHZhbHVlKSAmIFBBR0VfTUFT
S180Syk7fSB3aGlsZSgwKQogCiBzdHJ1Y3QgY29udGV4dF9lbnRyeSB7Ci0g
ICAgdTY0IGxvOwotICAgIHU2NCBoaTsKKyAgICB1bmlvbiB7CisgICAgICAg
IHN0cnVjdCB7CisgICAgICAgICAgICB1aW50NjRfdCBsbywgaGk7CisgICAg
ICAgIH07CisgICAgICAgIF9fdWludDEyOF90IGZ1bGw7CisgICAgfTsKIH07
CiAjZGVmaW5lIFJPT1RfRU5UUllfTlIgKFBBR0VfU0laRV80Sy9zaXplb2Yo
c3RydWN0IHJvb3RfZW50cnkpKQogI2RlZmluZSBjb250ZXh0X3ByZXNlbnQo
YykgKChjKS5sbyAmIDEpCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3Z0ZC9xdWlya3MuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92
dGQvcXVpcmtzLmMKQEAgLTM0Myw3ICszNDMsOCBAQCB2b2lkIF9faW5pdCBw
bGF0Zm9ybV9xdWlya3NfaW5pdCh2b2lkKQogICovCiAKIHN0YXRpYyBpbnQg
X19tdXN0X2NoZWNrIG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKHN0cnVjdCBk
b21haW4gKmRvbWFpbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHUzMiBkZXYsIGludCBtYXApCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNp
Z25lZCBpbnQgZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG1vZGUpCiB7CiAgICAg
c3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwogICAgIHN0cnVjdCBwY2lf
ZGV2ICpwZGV2OwpAQCAtMzU0LDkgKzM1NSw5IEBAIHN0YXRpYyBpbnQgX19t
dXN0X2NoZWNrIG1hcF9tZV9waGFudG9tX2YKICAgICBkcmhkID0gYWNwaV9m
aW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYpOwogCiAgICAgLyogbWFwIG9y
IHVubWFwIE1FIHBoYW50b20gZnVuY3Rpb24gKi8KLSAgICBpZiAoIG1hcCAp
CisgICAgaWYgKCAhKG1vZGUgJiBVTk1BUF9NRV9QSEFOVE9NX0ZVTkMpICkK
ICAgICAgICAgcmMgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21h
aW4sIGRyaGQtPmlvbW11LCAwLAotICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpLCBOVUxMKTsKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfREVW
Rk4oZGV2LCA3KSwgTlVMTCwgbW9kZSk7CiAgICAgZWxzZQogICAgICAgICBy
YyA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGRyaGQtPmlv
bW11LCAwLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBQQ0lfREVWRk4oZGV2LCA3KSk7CkBAIC0zNjQsNyArMzY1LDggQEAgc3Rh
dGljIGludCBfX211c3RfY2hlY2sgbWFwX21lX3BoYW50b21fZgogICAgIHJl
dHVybiByYzsKIH0KIAotaW50IG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFp
biAqZG9tYWluLCB1OCBidXMsIHU4IGRldmZuLCBpbnQgbWFwKQoraW50IG1l
X3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLCB1aW50OF90IGJ1
cywgdWludDhfdCBkZXZmbiwKKyAgICAgICAgICAgICAgICAgIHVuc2lnbmVk
IGludCBtb2RlKQogewogICAgIHUzMiBpZDsKICAgICBpbnQgcmMgPSAwOwpA
QCAtMzg4LDcgKzM5MCw3IEBAIGludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBk
b21haW4gKmRvbWFpbiwKICAgICAgICAgICAgIGNhc2UgMHg0MjNiODA4NjoK
ICAgICAgICAgICAgIGNhc2UgMHg0MjNjODA4NjoKICAgICAgICAgICAgIGNh
c2UgMHg0MjNkODA4NjoKLSAgICAgICAgICAgICAgICByYyA9IG1hcF9tZV9w
aGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMywgbWFwKTsKKyAgICAgICAgICAg
ICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMywg
bW9kZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBk
ZWZhdWx0OgogICAgICAgICAgICAgICAgIGJyZWFrOwpAQCAtNDE0LDcgKzQx
Niw3IEBAIGludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFp
biwKICAgICAgICAgICAgIGNhc2UgMHg0MjM4ODA4NjogICAgICAgIC8qIFB1
bWEgUGVhayAqLwogICAgICAgICAgICAgY2FzZSAweDQyMmI4MDg2OgogICAg
ICAgICAgICAgY2FzZSAweDQyMmM4MDg2OgotICAgICAgICAgICAgICAgIHJj
ID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAyMiwgbWFwKTsK
KyAgICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9u
KGRvbWFpbiwgMjIsIG1vZGUpOwogICAgICAgICAgICAgICAgIGJyZWFrOwog
ICAgICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICBicmVhazsK
LS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL3Z0ZC5oCisrKyBi
L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC92dGQuaApAQCAtMjIsOCAr
MjIsMTQgQEAKIAogI2luY2x1ZGUgPHhlbi9pb21tdS5oPgogCi0jZGVmaW5l
IE1BUF9NRV9QSEFOVE9NX0ZVTkMgICAgICAxCi0jZGVmaW5lIFVOTUFQX01F
X1BIQU5UT01fRlVOQyAgICAwCisvKgorICogVmFsdWVzIGZvciBkb21haW5f
Y29udGV4dF9tYXBwaW5nX29uZSgpJ3MgYW5kIG1lX3dpZmlfcXVpcmsoKSdz
ICJtb2RlIgorICogcGFyYW1ldGVycy4KKyAqLworI2RlZmluZSBNQVBfV0lU
SF9STVJSICAgICAgICAgKDF1IDw8IDApCisjZGVmaW5lIE1BUF9PV05FUl9E
WUlORyAgICAgICAoMXUgPDwgMSkKKyNkZWZpbmUgTUFQX1NJTkdMRV9ERVZJ
Q0UgICAgICgxdSA8PCAyKQorI2RlZmluZSBVTk1BUF9NRV9QSEFOVE9NX0ZV
TkMgKDF1IDw8IDMpCiAKIC8qIEFsbG93IGZvciBib3RoIElPQVBJQyBhbmQg
SU9TQVBJQy4gKi8KICNkZWZpbmUgSU9feEFQSUNfcm91dGVfZW50cnkgSU9f
QVBJQ19yb3V0ZV9lbnRyeQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-05.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IHJlLWFzc2lnbiBkZXZpY2VzIGRpcmVjdGx5CgpEZXZp
Y2VzIHdpdGggdW5pdHkgbWFwIHJhbmdlcywgZHVlIHRvIGl0IGJlaW5nIHVu
c3BlY2lmaWVkIGhvdy93aGVuCnRoZXNlIG1lbW9yeSByYW5nZXMgbWF5IGdl
dCBhY2Nlc3NlZCwgbWF5IG5vdCBiZSBsZWZ0IGRpc2Nvbm5lY3RlZCBmcm9t
CnRoZWlyIHVuaXR5IG1hcHBpbmdzIChhcyBsb25nIGFzIGl0J3Mgbm90IGNl
cnRhaW4gdGhhdCB0aGUgZGV2aWNlIGhhcwpiZWVuIGZ1bGx5IHF1aWVzY2Vk
KS4gSGVuY2UgcmF0aGVyIHRoYW4gdGVhcmluZyBkb3duIHRoZSBvbGQgcm9v
dCBwYWdlCnRhYmxlIHBvaW50ZXIgYW5kIHRoZW4gZXN0YWJsaXNoaW5nIHRo
ZSBuZXcgb25lLCByZS1hc3NpZ25tZW50IG5lZWRzIHRvCmJlIGRvbmUgaW4g
YSBzaW5nbGUgc3RlcC4KClRoaXMgaXMgQ1ZFLTIwMjItMjYzNjAgLyBwYXJ0
IG9mIFhTQS00MDAuCgpSZXBvcnRlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8
cm9nZXIucGF1QGNpdHJpeC5jb20+CgpTaW1pbGFybHkgcXVhcmFudGluaW5n
IHNjcmF0Y2gtcGFnZSBtb2RlIHJlbGllcyBvbiBwYWdlIHRhYmxlcyB0byBi
ZQpjb250aW51b3VzbHkgd2lyZWQgdXAuCgpUbyBhdm9pZCBjb21wbGljYXRp
bmcgdGhpbmdzIG1vcmUgdGhhbiBuZWNlc3NhcnksIHRyZWF0IGFsbCBkZXZp
Y2VzCm1vc3RseSBlcXVhbGx5LCBpLmUuIHJlZ2FyZGxlc3Mgb2YgdGhlaXIg
YXNzb2NpYXRpb24gd2l0aCBhbnkgdW5pdHkgbWFwCnJhbmdlcy4gIFRoZSBt
YWluIGRpZmZlcmVuY2UgaXMgd2hlbiBpdCBjb21lcyB0byB1cGRhdGluZyBE
VEVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21pYyB3aGVuIHRoZXJlIGFyZSB1
bml0eSBtYXBwaW5ncy4gWWV0IGF0b21pY2l0eSBjYW4gb25seSBiZQphY2hp
ZXZlZCB3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBvZiB3aGljaCB3
ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwg
RHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+CgotLS0gYS94ZW4vaW5j
bHVkZS9hc20teDg2L2h2bS9zdm0vYW1kLWlvbW11LXByb3RvLmgKKysrIGIv
eGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL2FtZC1pb21tdS1wcm90by5o
CkBAIC03OSw5ICs3OSwxMyBAQCB2b2lkIGFtZF9pb21tdV9zZXRfaW50cmVt
YXBfdGFibGUoc3RydWN0CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgY29uc3Qgdm9pZCAqcHRyLAogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgdmFsaWQp
Owotdm9pZCBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZShzdHJ1Y3Qg
YW1kX2lvbW11X2R0ZSAqZHRlLAotCQkJCSAgIHVpbnQ2NF90IHJvb3RfcHRy
LCB1aW50MTZfdCBkb21haW5faWQsCi0JCQkJICAgdWludDhfdCBwYWdpbmdf
bW9kZSwgYm9vbCB2YWxpZCk7CisjZGVmaW5lIFNFVF9ST09UX1ZBTElEICAg
ICAgICAgICgxdSA8PCAwKQorI2RlZmluZSBTRVRfUk9PVF9XSVRIX1VOSVRZ
X01BUCAoMXUgPDwgMSkKK2ludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3Nl
dF9yb290X3BhZ2VfdGFibGUoc3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgdWludDY0X3Qgcm9vdF9wdHIsCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQxNl90IGRvbWFpbl9pZCwK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgdWludDhfdCBwYWdpbmdfbW9kZSwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGZsYWdz
KTsKIHZvaWQgaW9tbXVfZHRlX2FkZF9kZXZpY2VfZW50cnkoc3RydWN0IGFt
ZF9pb21tdV9kdGUgKmR0ZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgY29uc3Qgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfZGV2KTsK
IHZvaWQgaW9tbXVfZHRlX3NldF9ndWVzdF9jcjMoc3RydWN0IGFtZF9pb21t
dV9kdGUgKmR0ZSwgdWludDE2X3QgZG9tX2lkLAotLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jCkBAIC0xMDMsMTAgKzEw
Myw2OSBAQCBzdGF0aWMgdW5zaWduZWQgaW50IHNldF9pb21tdV9wdGVfcHJl
c2VuCiAgICAgcmV0dXJuIGZsdXNoX2ZsYWdzOwogfQogCi12b2lkIGFtZF9p
b21tdV9zZXRfcm9vdF9wYWdlX3RhYmxlKHN0cnVjdCBhbWRfaW9tbXVfZHRl
ICpkdGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVp
bnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBkb21haW5faWQsCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgcGFnaW5nX21v
ZGUsIGJvb2wgdmFsaWQpCisvKgorICogVGhpcyBmdW5jdGlvbiByZXR1cm5z
CisgKiAtIC1lcnJubyBmb3IgZXJyb3JzLAorICogLSAwIGZvciBhIHN1Y2Nl
c3NmdWwgdXBkYXRlLCBhdG9taWMgd2hlbiBuZWNlc3NhcnkKKyAqIC0gMSBm
b3IgYSBzdWNjZXNzZnVsIGJ1dCBub24tYXRvbWljIHVwZGF0ZSwgd2hpY2gg
bWF5IG5lZWQgdG8gYmUgd2FybmVkCisgKiAgIGFib3V0IGJ5IHRoZSBjYWxs
ZXIuCisgKi8KK2ludCBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZShz
dHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRlLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHVpbnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBk
b21haW5faWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
dWludDhfdCBwYWdpbmdfbW9kZSwgdW5zaWduZWQgaW50IGZsYWdzKQogewor
ICAgIGJvb2wgdmFsaWQgPSBmbGFncyAmIFNFVF9ST09UX1ZBTElEOworCisg
ICAgaWYgKCBkdGUtPnYgJiYgZHRlLT50diAmJgorICAgICAgICAgKGNwdV9o
YXNfY3gxNiB8fCAoZmxhZ3MgJiBTRVRfUk9PVF9XSVRIX1VOSVRZX01BUCkp
ICkKKyAgICB7CisgICAgICAgIHVuaW9uIHsKKyAgICAgICAgICAgIHN0cnVj
dCBhbWRfaW9tbXVfZHRlIGR0ZTsKKyAgICAgICAgICAgIHVpbnQ2NF90IHJh
dzY0WzRdOworICAgICAgICAgICAgX191aW50MTI4X3QgcmF3MTI4WzJdOwor
ICAgICAgICB9IGxkdGUgPSB7IC5kdGUgPSAqZHRlIH07CisgICAgICAgIF9f
dWludDEyOF90IG9sZCA9IGxkdGUucmF3MTI4WzBdOworICAgICAgICBpbnQg
cmV0ID0gMDsKKworICAgICAgICBsZHRlLmR0ZS5kb21haW5faWQgPSBkb21h
aW5faWQ7CisgICAgICAgIGxkdGUuZHRlLnB0X3Jvb3QgPSBwYWRkcl90b19w
Zm4ocm9vdF9wdHIpOworICAgICAgICBsZHRlLmR0ZS5pdyA9IHRydWU7Cisg
ICAgICAgIGxkdGUuZHRlLmlyID0gdHJ1ZTsKKyAgICAgICAgbGR0ZS5kdGUu
cGFnaW5nX21vZGUgPSBwYWdpbmdfbW9kZTsKKyAgICAgICAgbGR0ZS5kdGUu
diA9IHZhbGlkOworCisgICAgICAgIGlmICggY3B1X2hhc19jeDE2ICkKKyAg
ICAgICAgeworICAgICAgICAgICAgX191aW50MTI4X3QgcmVzID0gY21weGNo
ZzE2YihkdGUsICZvbGQsICZsZHRlLnJhdzEyOFswXSk7CisKKyAgICAgICAg
ICAgIC8qCisgICAgICAgICAgICAgKiBIYXJkd2FyZSBkb2VzIG5vdCB1cGRh
dGUgdGhlIERURSBiZWhpbmQgb3VyIGJhY2tzLCBzbyB0aGUKKyAgICAgICAg
ICAgICAqIHJldHVybiB2YWx1ZSBzaG91bGQgbWF0Y2ggIm9sZCIuCisgICAg
ICAgICAgICAgKi8KKyAgICAgICAgICAgIGlmICggcmVzICE9IG9sZCApCisg
ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19F
UlIKKyAgICAgICAgICAgICAgICAgICAgICAgIkRvbSVkOiB1bmV4cGVjdGVk
IERURSAlMDE2bHhfJTAxNmx4IChleHBlY3RlZCAlMDE2bHhfJTAxNmx4KVxu
IiwKKyAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluX2lkLAorICAgICAg
ICAgICAgICAgICAgICAgICAodWludDY0X3QpKHJlcyA+PiA2NCksICh1aW50
NjRfdClyZXMsCisgICAgICAgICAgICAgICAgICAgICAgICh1aW50NjRfdCko
b2xkID4+IDY0KSwgKHVpbnQ2NF90KW9sZCk7CisgICAgICAgICAgICAgICAg
cmV0ID0gLUVJTFNFUTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAg
ICAgICBlbHNlIC8qIEJlc3QgZWZmb3J0LCB1cGRhdGluZyBkb21haW5faWQg
bGFzdC4gKi8KKyAgICAgICAgeworICAgICAgICAgICAgdWludDY0X3QgKnB0
ciA9ICh2b2lkICopZHRlOworCisgICAgICAgICAgICB3cml0ZV9hdG9taWMo
cHRyICsgMCwgbGR0ZS5yYXc2NFswXSk7CisgICAgICAgICAgICAvKiBObyBi
YXJyaWVyIHNob3VsZCBiZSBuZWVkZWQgYmV0d2VlbiB0aGVzZSB0d28uICov
CisgICAgICAgICAgICB3cml0ZV9hdG9taWMocHRyICsgMSwgbGR0ZS5yYXc2
NFsxXSk7CisKKyAgICAgICAgICAgIHJldCA9IDE7CisgICAgICAgIH0KKwor
ICAgICAgICByZXR1cm4gcmV0OworICAgIH0KKwogICAgIGlmICggdmFsaWQg
fHwgZHRlLT52ICkKICAgICB7CiAgICAgICAgIGR0ZS0+dHYgPSBmYWxzZTsK
QEAgLTEyMSw2ICsxODAsOCBAQCB2b2lkIGFtZF9pb21tdV9zZXRfcm9vdF9w
YWdlX3RhYmxlKHN0cnVjCiAgICAgc21wX3dtYigpOwogICAgIGR0ZS0+dHYg
PSB0cnVlOwogICAgIGR0ZS0+diA9IHZhbGlkOworCisgICAgcmV0dXJuIDA7
CiB9CiAKIHZvaWQgYW1kX2lvbW11X3NldF9pbnRyZW1hcF90YWJsZSgKLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUu
YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9p
b21tdS5jCkBAIC04NSw0MCArODUsODEgQEAgaW50IGdldF9kbWFfcmVxdWVz
dG9yX2lkKHVpbnQxNl90IHNlZywgdQogICAgIHJldHVybiByZXFfaWQ7CiB9
CiAKLXN0YXRpYyB2b2lkIGFtZF9pb21tdV9zZXR1cF9kb21haW5fZGV2aWNl
KAorc3RhdGljIGludCBfX211c3RfY2hlY2sgYWxsb2NhdGVfZG9tYWluX3Jl
c291cmNlcyhzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCkKK3sKKyAgICBpbnQg
cmM7CisKKyAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7
CisgICAgcmMgPSBhbWRfaW9tbXVfYWxsb2Nfcm9vdChoZCk7CisgICAgc3Bp
bl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CisKKyAgICByZXR1
cm4gcmM7Cit9CisKK3N0YXRpYyBib29sIGFueV9wZGV2X2JlaGluZF9pb21t
dShjb25zdCBzdHJ1Y3QgZG9tYWluICpkLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpleGNsdWRl
LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0
cnVjdCBhbWRfaW9tbXUgKmlvbW11KQoreworICAgIGNvbnN0IHN0cnVjdCBw
Y2lfZGV2ICpwZGV2OworCisgICAgZm9yX2VhY2hfcGRldiAoIGQsIHBkZXYg
KQorICAgIHsKKyAgICAgICAgaWYgKCBwZGV2ID09IGV4Y2x1ZGUgKQorICAg
ICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgaWYgKCBmaW5kX2lvbW11
X2Zvcl9kZXZpY2UocGRldi0+c2VnLCBwZGV2LT5zYmRmLmJkZikgPT0gaW9t
bXUgKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorCisgICAg
cmV0dXJuIGZhbHNlOworfQorCitzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBh
bWRfaW9tbXVfc2V0dXBfZG9tYWluX2RldmljZSgKICAgICBzdHJ1Y3QgZG9t
YWluICpkb21haW4sIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LAogICAgIHVp
bnQ4X3QgZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQogewogICAgIHN0
cnVjdCBhbWRfaW9tbXVfZHRlICp0YWJsZSwgKmR0ZTsKICAgICB1bnNpZ25l
ZCBsb25nIGZsYWdzOwotICAgIGludCByZXFfaWQsIHZhbGlkID0gMTsKKyAg
ICB1bnNpZ25lZCBpbnQgcmVxX2lkLCBzcl9mbGFnczsKKyAgICBpbnQgcmM7
CiAgICAgdTggYnVzID0gcGRldi0+YnVzOwotICAgIGNvbnN0IHN0cnVjdCBk
b21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbWFpbik7CisgICAgc3Ry
dWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZG9tYWluKTsKKyAg
ICBjb25zdCBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19kZXY7CiAKLSAg
ICBCVUdfT04oICFoZC0+YXJjaC5yb290X3RhYmxlIHx8ICFoZC0+YXJjaC5w
YWdpbmdfbW9kZSB8fAotICAgICAgICAgICAgIWlvbW11LT5kZXZfdGFibGUu
YnVmZmVyICk7CisgICAgQlVHX09OKCFoZC0+YXJjaC5wYWdpbmdfbW9kZSB8
fCAhaW9tbXUtPmRldl90YWJsZS5idWZmZXIpOwogCi0gICAgaWYgKCBpb21t
dV9od2RvbV9wYXNzdGhyb3VnaCAmJiBpc19oYXJkd2FyZV9kb21haW4oZG9t
YWluKSApCi0gICAgICAgIHZhbGlkID0gMDsKKyAgICByYyA9IGFsbG9jYXRl
X2RvbWFpbl9yZXNvdXJjZXMoaGQpOworICAgIGlmICggcmMgKQorICAgICAg
ICByZXR1cm4gcmM7CisKKyAgICByZXFfaWQgPSBnZXRfZG1hX3JlcXVlc3Rv
cl9pZChpb21tdS0+c2VnLCBwZGV2LT5zYmRmLmJkZik7CisgICAgaXZyc19k
ZXYgPSAmZ2V0X2l2cnNfbWFwcGluZ3MoaW9tbXUtPnNlZylbcmVxX2lkXTsK
KyAgICBzcl9mbGFncyA9IChpb21tdV9od2RvbV9wYXNzdGhyb3VnaCAmJiBp
c19oYXJkd2FyZV9kb21haW4oZG9tYWluKQorICAgICAgICAgICAgICAgID8g
MCA6IFNFVF9ST09UX1ZBTElEKQorICAgICAgICAgICAgICAgfCAoaXZyc19k
ZXYtPnVuaXR5X21hcCA/IFNFVF9ST09UX1dJVEhfVU5JVFlfTUFQIDogMCk7
CiAKICAgICAvKiBnZXQgZGV2aWNlLXRhYmxlIGVudHJ5ICovCiAgICAgcmVx
X2lkID0gZ2V0X2RtYV9yZXF1ZXN0b3JfaWQoaW9tbXUtPnNlZywgUENJX0JE
RjIoYnVzLCBkZXZmbikpOwogICAgIHRhYmxlID0gaW9tbXUtPmRldl90YWJs
ZS5idWZmZXI7CiAgICAgZHRlID0gJnRhYmxlW3JlcV9pZF07CisgICAgaXZy
c19kZXYgPSAmZ2V0X2l2cnNfbWFwcGluZ3MoaW9tbXUtPnNlZylbcmVxX2lk
XTsKIAogICAgIHNwaW5fbG9ja19pcnFzYXZlKCZpb21tdS0+bG9jaywgZmxh
Z3MpOwogCiAgICAgaWYgKCAhZHRlLT52IHx8ICFkdGUtPnR2ICkKICAgICB7
Ci0gICAgICAgIGNvbnN0IHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX2Rl
djsKLQogICAgICAgICAvKiBiaW5kIERURSB0byBkb21haW4gcGFnZS10YWJs
ZXMgKi8KLSAgICAgICAgYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUo
Ci0gICAgICAgICAgICBkdGUsIHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2gucm9v
dF90YWJsZSksIGRvbWFpbi0+ZG9tYWluX2lkLAotICAgICAgICAgICAgaGQt
PmFyY2gucGFnaW5nX21vZGUsIHZhbGlkKTsKKyAgICAgICAgcmMgPSBhbWRf
aW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZSgKKyAgICAgICAgICAgICAgICAg
ZHRlLCBwYWdlX3RvX21hZGRyKGhkLT5hcmNoLnJvb3RfdGFibGUpLAorICAg
ICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2gucGFn
aW5nX21vZGUsIHNyX2ZsYWdzKTsKKyAgICAgICAgaWYgKCByYyApCisgICAg
ICAgIHsKKyAgICAgICAgICAgIEFTU0VSVChyYyA8IDApOworICAgICAgICAg
ICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdz
KTsKKyAgICAgICAgICAgIHJldHVybiByYzsKKyAgICAgICAgfQogCiAgICAg
ICAgIC8qIFVuZG8gd2hhdCBhbWRfaW9tbXVfZGlzYWJsZV9kb21haW5fZGV2
aWNlKCkgbWF5IGhhdmUgZG9uZS4gKi8KLSAgICAgICAgaXZyc19kZXYgPSAm
Z2V0X2l2cnNfbWFwcGluZ3MoaW9tbXUtPnNlZylbcmVxX2lkXTsKICAgICAg
ICAgaWYgKCBkdGUtPml0X3Jvb3QgKQogICAgICAgICB7CiAgICAgICAgICAg
ICBkdGUtPmludF9jdGwgPSBJT01NVV9ERVZfVEFCTEVfSU5UX0NPTlRST0xf
VFJBTlNMQVRFRDsKQEAgLTEzMywxNyArMTc0LDc0IEBAIHN0YXRpYyB2b2lk
IGFtZF9pb21tdV9zZXR1cF9kb21haW5fZGV2aWMKICAgICAgICAgICAgIGR0
ZS0+aSA9IGF0c19lbmFibGVkOwogCiAgICAgICAgIGFtZF9pb21tdV9mbHVz
aF9kZXZpY2UoaW9tbXUsIHJlcV9pZCk7CisgICAgfQorICAgIGVsc2UgaWYg
KCBkdGUtPnB0X3Jvb3QgIT0gbWZuX3gocGFnZV90b19tZm4oaGQtPmFyY2gu
cm9vdF90YWJsZSkpICkKKyAgICB7CisgICAgICAgIC8qCisgICAgICAgICAq
IFN0cmljdGx5IHNwZWFraW5nIGlmIHRoZSBkZXZpY2UgaXMgdGhlIG9ubHkg
b25lIHdpdGggdGhpcyByZXF1ZXN0b3IKKyAgICAgICAgICogSUQsIGl0IGNv
dWxkIGJlIGFsbG93ZWQgdG8gYmUgcmUtYXNzaWduZWQgcmVnYXJkbGVzcyBv
ZiB1bml0eSBtYXAKKyAgICAgICAgICogcHJlc2VuY2UuICBCdXQgbGV0J3Mg
ZGVhbCB3aXRoIHRoYXQgY2FzZSBvbmx5IGlmIGl0IGlzIGFjdHVhbGx5Cisg
ICAgICAgICAqIGZvdW5kIGluIHRoZSB3aWxkLgorICAgICAgICAgKi8KKyAg
ICAgICAgaWYgKCByZXFfaWQgIT0gUENJX0JERjIoYnVzLCBkZXZmbikgJiYK
KyAgICAgICAgICAgICAoc3JfZmxhZ3MgJiBTRVRfUk9PVF9XSVRIX1VOSVRZ
X01BUCkgKQorICAgICAgICAgICAgcmMgPSAtRU9QTk9UU1VQUDsKKyAgICAg
ICAgZWxzZQorICAgICAgICAgICAgcmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3Rf
cGFnZV90YWJsZSgKKyAgICAgICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90
b19tYWRkcihoZC0+YXJjaC5yb290X3RhYmxlKSwKKyAgICAgICAgICAgICAg
ICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBoZC0+YXJjaC5wYWdpbmdfbW9k
ZSwgc3JfZmxhZ3MpOworICAgICAgICBpZiAoIHJjIDwgMCApCisgICAgICAg
IHsKKyAgICAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmlvbW11
LT5sb2NrLCBmbGFncyk7CisgICAgICAgICAgICByZXR1cm4gcmM7CisgICAg
ICAgIH0KKyAgICAgICAgaWYgKCByYyAmJgorICAgICAgICAgICAgIGRvbWFp
biAhPSBwZGV2LT5kb21haW4gJiYKKyAgICAgICAgICAgICAvKgorICAgICAg
ICAgICAgICAqIEJ5IG5vbi1hdG9taWNhbGx5IHVwZGF0aW5nIHRoZSBEVEUn
cyBkb21haW4gSUQgZmllbGQgbGFzdCwKKyAgICAgICAgICAgICAgKiBkdXJp
bmcgYSBzaG9ydCB3aW5kb3cgaW4gdGltZSBUTEIgZW50cmllcyB3aXRoIHRo
ZSBvbGQgZG9tYWluCisgICAgICAgICAgICAgICogSUQgYnV0IHRoZSBuZXcg
cGFnZSB0YWJsZXMgbWF5IGhhdmUgYmVlbiBpbnNlcnRlZC4gIFRoaXMgY291
bGQKKyAgICAgICAgICAgICAgKiBhZmZlY3QgSS9PIG9mIG90aGVyIGRldmlj
ZXMgdXNpbmcgdGhpcyBzYW1lIChvbGQpIGRvbWFpbiBJRC4KKyAgICAgICAg
ICAgICAgKiBTdWNoIHVwZGF0aW5nIHRoZXJlZm9yZSBpcyBub3QgYSBwcm9i
bGVtIGlmIHRoaXMgd2FzIHRoZSBvbmx5CisgICAgICAgICAgICAgICogZGV2
aWNlIGFzc29jaWF0ZWQgd2l0aCB0aGUgb2xkIGRvbWFpbiBJRC4gIERpdmVy
dGluZyBJL08gb2YgYW55CisgICAgICAgICAgICAgICogb2YgYSBkeWluZyBk
b21haW4ncyBkZXZpY2VzIHRvIHRoZSBxdWFyYW50aW5lIHBhZ2UgdGFibGVz
IGlzCisgICAgICAgICAgICAgICogaW50ZW5kZWQgYW55d2F5LgorICAgICAg
ICAgICAgICAqLworICAgICAgICAgICAgICFwZGV2LT5kb21haW4tPmlzX2R5
aW5nICYmCisgICAgICAgICAgICAgKGFueV9wZGV2X2JlaGluZF9pb21tdShw
ZGV2LT5kb21haW4sIHBkZXYsIGlvbW11KSB8fAorICAgICAgICAgICAgICBw
ZGV2LT5waGFudG9tX3N0cmlkZSkgKQorICAgICAgICAgICAgcHJpbnRrKCIg
JTA0eDolMDJ4OiUwMnguJXU6IHJlYXNzaWdubWVudCBtYXkgY2F1c2UgJXBk
IGRhdGEgY29ycnVwdGlvblxuIiwKKyAgICAgICAgICAgICAgICAgICBwZGV2
LT5zZWcsIGJ1cywgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiks
CisgICAgICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluKTsKKworICAgICAg
ICAvKgorICAgICAgICAgKiBDaGVjayByZW1haW5pbmcgc2V0dGluZ3MgYXJl
IHN0aWxsIGluIHBsYWNlIGZyb20gYW4gZWFybGllciBjYWxsCisgICAgICAg
ICAqIGhlcmUuIFRoZXkncmUgYWxsIGluZGVwZW5kZW50IG9mIHRoZSBkb21h
aW4sIHNvIHNob3VsZCBub3QgaGF2ZQorICAgICAgICAgKiBjaGFuZ2VkLgor
ICAgICAgICAgKi8KKyAgICAgICAgaWYgKCBkdGUtPml0X3Jvb3QgKQorICAg
ICAgICAgICAgQVNTRVJUKGR0ZS0+aW50X2N0bCA9PSBJT01NVV9ERVZfVEFC
TEVfSU5UX0NPTlRST0xfVFJBTlNMQVRFRCk7CisgICAgICAgIEFTU0VSVChk
dGUtPml2ID09IGlvbW11X2ludHJlbWFwKTsKKyAgICAgICAgQVNTRVJUKGR0
ZS0+ZXggPT0gaXZyc19kZXYtPmR0ZV9hbGxvd19leGNsdXNpb24pOworICAg
ICAgICBBU1NFUlQoZHRlLT5zeXNfbWd0ID09IE1BU0tfRVhUUihpdnJzX2Rl
di0+ZGV2aWNlX2ZsYWdzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBBQ1BJX0lWSERfU1lTVEVNX01HTVQpKTsKIAotICAg
ICAgICBBTURfSU9NTVVfREVCVUcoIlNldHVwIEkvTyBwYWdlIHRhYmxlOiBk
ZXZpY2UgaWQgPSAlI3gsIHR5cGUgPSAlI3gsICIKLSAgICAgICAgICAgICAg
ICAgICAgICAgICJyb290IHRhYmxlID0gJSMiUFJJeDY0IiwgIgotICAgICAg
ICAgICAgICAgICAgICAgICAgImRvbWFpbiA9ICVkLCBwYWdpbmcgbW9kZSA9
ICVkXG4iLAotICAgICAgICAgICAgICAgICAgICAgICAgcmVxX2lkLCBwZGV2
LT50eXBlLAotICAgICAgICAgICAgICAgICAgICAgICAgcGFnZV90b19tYWRk
cihoZC0+YXJjaC5yb290X3RhYmxlKSwKLSAgICAgICAgICAgICAgICAgICAg
ICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBoZC0+YXJjaC5wYWdpbmdfbW9kZSk7
CisgICAgICAgIGlmICggcGNpX2F0c19kZXZpY2UoaW9tbXUtPnNlZywgYnVz
LCBwZGV2LT5kZXZmbikgJiYKKyAgICAgICAgICAgICBpb21tdV9oYXNfY2Fw
KGlvbW11LCBQQ0lfQ0FQX0lPVExCX1NISUZUKSApCisgICAgICAgICAgICBB
U1NFUlQoZHRlLT5pID09IGF0c19lbmFibGVkKTsKKworICAgICAgICBhbWRf
aW9tbXVfZmx1c2hfZGV2aWNlKGlvbW11LCByZXFfaWQpOwogICAgIH0KIAog
ICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmlvbW11LT5sb2NrLCBmbGFn
cyk7CiAKKyAgICBBTURfSU9NTVVfREVCVUcoIlNldHVwIEkvTyBwYWdlIHRh
YmxlOiBkZXZpY2UgaWQgPSAlI3gsIHR5cGUgPSAlI3gsICIKKyAgICAgICAg
ICAgICAgICAgICAgInJvb3QgdGFibGUgPSAlIyJQUkl4NjQiLCAiCisgICAg
ICAgICAgICAgICAgICAgICJkb21haW4gPSAlZCwgcGFnaW5nIG1vZGUgPSAl
ZFxuIiwKKyAgICAgICAgICAgICAgICAgICAgcmVxX2lkLCBwZGV2LT50eXBl
LAorICAgICAgICAgICAgICAgICAgICBwYWdlX3RvX21hZGRyKGhkLT5hcmNo
LnJvb3RfdGFibGUpLAorICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRv
bWFpbl9pZCwgaGQtPmFyY2gucGFnaW5nX21vZGUpOworCiAgICAgQVNTRVJU
KHBjaWRldnNfbG9ja2VkKCkpOwogCiAgICAgaWYgKCBwY2lfYXRzX2Rldmlj
ZShpb21tdS0+c2VnLCBidXMsIHBkZXYtPmRldmZuKSAmJgpAQCAtMTU0LDYg
KzI1Miw4IEBAIHN0YXRpYyB2b2lkIGFtZF9pb21tdV9zZXR1cF9kb21haW5f
ZGV2aWMKIAogICAgICAgICBhbWRfaW9tbXVfZmx1c2hfaW90bGIoZGV2Zm4s
IHBkZXYsIElOVl9JT01NVV9BTExfUEFHRVNfQUREUkVTUywgMCk7CiAgICAg
fQorCisgICAgcmV0dXJuIDA7CiB9CiAKIGludCBfX2luaXQgYWNwaV9pdnJz
X2luaXQodm9pZCkKQEAgLTIyMywxNyArMzIzLDYgQEAgaW50IGFtZF9pb21t
dV9hbGxvY19yb290KHN0cnVjdCBkb21haW5faQogICAgIHJldHVybiAwOwog
fQogCi1zdGF0aWMgaW50IF9fbXVzdF9jaGVjayBhbGxvY2F0ZV9kb21haW5f
cmVzb3VyY2VzKHN0cnVjdCBkb21haW5faW9tbXUgKmhkKQotewotICAgIGlu
dCByYzsKLQotICAgIHNwaW5fbG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2Nr
KTsKLSAgICByYyA9IGFtZF9pb21tdV9hbGxvY19yb290KGhkKTsKLSAgICBz
cGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKLQotICAgIHJl
dHVybiByYzsKLX0KLQogaW50IF9fcmVhZF9tb3N0bHkgYW1kX2lvbW11X21p
bl9wYWdpbmdfbW9kZSA9IDE7CiAKIHN0YXRpYyBpbnQgYW1kX2lvbW11X2Rv
bWFpbl9pbml0KHN0cnVjdCBkb21haW4gKmQpCkBAIC0zMzMsNyArNDIyLDYg
QEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbgog
ewogICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwogICAgIGludCBiZGYs
IHJjOwotICAgIHN0cnVjdCBkb21haW5faW9tbXUgKnQgPSBkb21faW9tbXUo
dGFyZ2V0KTsKICAgICBjb25zdCBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZy
c19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHBkZXYtPnNlZyk7CiAK
ICAgICBiZGYgPSBQQ0lfQkRGMihwZGV2LT5idXMsIHBkZXYtPmRldmZuKTsK
QEAgLTM0Nyw3ICs0MzUsMTUgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZp
Y2Uoc3RydWN0IGRvbWFpbgogICAgICAgICByZXR1cm4gLUVOT0RFVjsKICAg
ICB9CiAKLSAgICBhbWRfaW9tbXVfZGlzYWJsZV9kb21haW5fZGV2aWNlKHNv
dXJjZSwgaW9tbXUsIGRldmZuLCBwZGV2KTsKKyAgICByYyA9IGFtZF9pb21t
dV9zZXR1cF9kb21haW5fZGV2aWNlKHRhcmdldCwgaW9tbXUsIGRldmZuLCBw
ZGV2KTsKKyAgICBpZiAoIHJjICkKKyAgICAgICAgcmV0dXJuIHJjOworCisg
ICAgaWYgKCBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21haW4g
IT0gdGFyZ2V0ICkKKyAgICB7CisgICAgICAgIGxpc3RfbW92ZSgmcGRldi0+
ZG9tYWluX2xpc3QsICZ0YXJnZXQtPnBkZXZfbGlzdCk7CisgICAgICAgIHBk
ZXYtPmRvbWFpbiA9IHRhcmdldDsKKyAgICB9CiAKICAgICAvKgogICAgICAq
IElmIHRoZSBkZXZpY2UgYmVsb25ncyB0byB0aGUgaGFyZHdhcmUgZG9tYWlu
LCBhbmQgaXQgaGFzIGEgdW5pdHkgbWFwcGluZywKQEAgLTM2MywyNyArNDU5
LDEwIEBAIHN0YXRpYyBpbnQgcmVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21h
aW4KICAgICAgICAgICAgIHJldHVybiByYzsKICAgICB9CiAKLSAgICBpZiAo
IGRldmZuID09IHBkZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSBkb21f
aW8gKQotICAgIHsKLSAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5f
bGlzdCwgJmRvbV9pby0+cGRldl9saXN0KTsKLSAgICAgICAgcGRldi0+ZG9t
YWluID0gZG9tX2lvOwotICAgIH0KLQotICAgIHJjID0gYWxsb2NhdGVfZG9t
YWluX3Jlc291cmNlcyh0KTsKLSAgICBpZiAoIHJjICkKLSAgICAgICAgcmV0
dXJuIHJjOwotCi0gICAgYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2Uo
dGFyZ2V0LCBpb21tdSwgZGV2Zm4sIHBkZXYpOwogICAgIEFNRF9JT01NVV9E
RUJVRygiUmUtYXNzaWduICUwNHg6JTAyeDolMDJ4LiV1IGZyb20gZG9tJWQg
dG8gZG9tJWRcbiIsCiAgICAgICAgICAgICAgICAgICAgIHBkZXYtPnNlZywg
cGRldi0+YnVzLCBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSwK
ICAgICAgICAgICAgICAgICAgICAgc291cmNlLT5kb21haW5faWQsIHRhcmdl
dC0+ZG9tYWluX2lkKTsKIAotICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2
Zm4gJiYgcGRldi0+ZG9tYWluICE9IHRhcmdldCApCi0gICAgewotICAgICAg
ICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFyZ2V0LT5wZGV2
X2xpc3QpOwotICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7Ci0gICAg
fQotCiAgICAgcmV0dXJuIDA7CiB9CiAKQEAgLTU0Nyw4ICs2MjYsNyBAQCBz
dGF0aWMgaW50IGFtZF9pb21tdV9hZGRfZGV2aWNlKHU4IGRldmZuCiAgICAg
ICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmlvbW11LT5sb2NrLCBmbGFn
cyk7CiAgICAgfQogCi0gICAgYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZp
Y2UocGRldi0+ZG9tYWluLCBpb21tdSwgZGV2Zm4sIHBkZXYpOwotICAgIHJl
dHVybiAwOworICAgIHJldHVybiBhbWRfaW9tbXVfc2V0dXBfZG9tYWluX2Rl
dmljZShwZGV2LT5kb21haW4sIGlvbW11LCBkZXZmbiwgcGRldik7CiB9CiAK
IHN0YXRpYyBpbnQgYW1kX2lvbW11X3JlbW92ZV9kZXZpY2UodTggZGV2Zm4s
IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-06.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSSkKCkFycmFuZ2UgZm9yIGRvbWFpbiBJRCBhbmQg
cGFnZSB0YWJsZSByb290IHRvIGJlIHBhc3NlZCBhcm91bmQsIHRoZSBsYXR0
ZXIgaW4KcGFydGljdWxhciB0byBkb21haW5fcGdkX21hZGRyKCkgc3VjaCB0
aGF0IHRha2luZyBpdCBmcm9tIHRoZSBwZXItZG9tYWluCmZpZWxkcyBjYW4g
YmUgb3ZlcnJpZGRlbi4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVk
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5A
aW50ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2V4dGVybi5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9l
eHRlcm4uaApAQCAtODYsOSArODYsMTAgQEAgdm9pZCAqbWFwX3Z0ZF9kb21h
aW5fcGFnZSh1NjQgbWFkZHIpOwogdm9pZCB1bm1hcF92dGRfZG9tYWluX3Bh
Z2Uodm9pZCAqdmEpOwogaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25l
KHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IHZ0ZF9pb21tdSAqaW9t
bXUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBi
dXMsIHVpbnQ4X3QgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGlu
dCBtb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z
dCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgZG9taWRfdCBkb21pZCwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHBnZF9tYWRkciwg
dW5zaWduZWQgaW50IG1vZGUpOwogaW50IGRvbWFpbl9jb250ZXh0X3VubWFw
X29uZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCB2dGRfaW9tbXUg
KmlvbW11LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1OCBidXMs
IHU4IGRldmZuKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWlu
dDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQpOwogaW50
IGludGVsX2lvbW11X2dldF9yZXNlcnZlZF9kZXZpY2VfbWVtb3J5KGlvbW11
X2dyZG1fdCAqZnVuYywgdm9pZCAqY3R4dCk7CiAKIHVuc2lnbmVkIGludCBp
b19hcGljX3JlYWRfcmVtYXBfcnRlKHVuc2lnbmVkIGludCBhcGljLCB1bnNp
Z25lZCBpbnQgcmVnKTsKQEAgLTEwNyw3ICsxMDgsOCBAQCB2b2lkIHBsYXRm
b3JtX3F1aXJrc19pbml0KHZvaWQpOwogdm9pZCB2dGRfb3BzX3ByZWFtYmxl
X3F1aXJrKHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KTsKIHZvaWQgdnRkX29w
c19wb3N0YW1ibGVfcXVpcmsoc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUpOwog
aW50IF9fbXVzdF9jaGVjayBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4g
KmRvbWFpbiwgdWludDhfdCBidXMsCi0gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgdWludDhfdCBkZXZmbiwgdW5zaWduZWQgaW50IG1vZGUpOwor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgZGV2Zm4s
IGRvbWlkX3QgZG9taWQsIHBhZGRyX3QgcGdkX21hZGRyLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBtb2RlKTsKIHZv
aWQgcGNpX3Z0ZF9xdWlyayhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqKTsKIHZv
aWQgcXVpcmtfaW9tbXVfY2FwcyhzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSk7
CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMK
KysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAg
LTEzNjQsMTIgKzEzNjQsMTIgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKAogICAgIHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICBzdHJ1
Y3QgdnRkX2lvbW11ICppb21tdSwKICAgICB1aW50OF90IGJ1cywgdWludDhf
dCBkZXZmbiwgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsCi0gICAgdW5z
aWduZWQgaW50IG1vZGUpCisgICAgZG9taWRfdCBkb21pZCwgcGFkZHJfdCBw
Z2RfbWFkZHIsIHVuc2lnbmVkIGludCBtb2RlKQogewogICAgIHN0cnVjdCBk
b21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbWFpbik7CiAgICAgc3Ry
dWN0IGNvbnRleHRfZW50cnkgKmNvbnRleHQsICpjb250ZXh0X2VudHJpZXMs
IGxjdHh0OwogICAgIF9fdWludDEyOF90IG9sZDsKLSAgICB1NjQgbWFkZHIs
IHBnZF9tYWRkcjsKKyAgICB1aW50NjRfdCBtYWRkcjsKICAgICB1aW50MTZf
dCBzZWcgPSBpb21tdS0+ZHJoZC0+c2VnbWVudCwgcHJldl9kaWQgPSAwOwog
ICAgIHN0cnVjdCBkb21haW4gKnByZXZfZG9tID0gTlVMTDsKICAgICBpbnQg
YWdhdywgcmMsIHJldDsKQEAgLTE0MTAsMTAgKzE0MTAsMTIgQEAgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIH0KICAgICBlbHNlCiAg
ICAgeworICAgICAgICBwYWRkcl90IHJvb3QgPSBwZ2RfbWFkZHI7CisKICAg
ICAgICAgc3Bpbl9sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogCiAg
ICAgICAgIC8qIEVuc3VyZSB3ZSBoYXZlIHBhZ2V0YWJsZXMgYWxsb2NhdGVk
IGRvd24gdG8gbGVhZiBQVEUuICovCi0gICAgICAgIGlmICggaGQtPmFyY2gu
cGdkX21hZGRyID09IDAgKQorICAgICAgICBpZiAoICFyb290ICkKICAgICAg
ICAgewogICAgICAgICAgICAgYWRkcl90b19kbWFfcGFnZV9tYWRkcihkb21h
aW4sIDAsIDEpOwogICAgICAgICAgICAgaWYgKCBoZC0+YXJjaC5wZ2RfbWFk
ZHIgPT0gMCApCkBAIC0xNDI2LDIyICsxNDI4LDI0IEBAIGludCBkb21haW5f
Y29udGV4dF9tYXBwaW5nX29uZSgKICAgICAgICAgICAgICAgICAgICAgcmN1
X3VubG9ja19kb21haW4ocHJldl9kb20pOwogICAgICAgICAgICAgICAgIHJl
dHVybiAtRU5PTUVNOwogICAgICAgICAgICAgfQorCisgICAgICAgICAgICBy
b290ID0gaGQtPmFyY2gucGdkX21hZGRyOwogICAgICAgICB9CiAKICAgICAg
ICAgLyogU2tpcCB0b3AgbGV2ZWxzIG9mIHBhZ2UgdGFibGVzIGZvciAyLSBh
bmQgMy1sZXZlbCBEUkhEcy4gKi8KLSAgICAgICAgcGdkX21hZGRyID0gaGQt
PmFyY2gucGdkX21hZGRyOwogICAgICAgICBmb3IgKCBhZ2F3ID0gbGV2ZWxf
dG9fYWdhdyg0KTsKICAgICAgICAgICAgICAgYWdhdyAhPSBsZXZlbF90b19h
Z2F3KGlvbW11LT5ucl9wdF9sZXZlbHMpOwogICAgICAgICAgICAgICBhZ2F3
LS0gKQogICAgICAgICB7Ci0gICAgICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAq
cCA9IG1hcF92dGRfZG9tYWluX3BhZ2UocGdkX21hZGRyKTsKLSAgICAgICAg
ICAgIHBnZF9tYWRkciA9IGRtYV9wdGVfYWRkcigqcCk7CisgICAgICAgICAg
ICBzdHJ1Y3QgZG1hX3B0ZSAqcCA9IG1hcF92dGRfZG9tYWluX3BhZ2Uocm9v
dCk7CisKKyAgICAgICAgICAgIHJvb3QgPSBkbWFfcHRlX2FkZHIoKnApOwog
ICAgICAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKHApOwotICAgICAg
ICAgICAgaWYgKCBwZ2RfbWFkZHIgPT0gMCApCisgICAgICAgICAgICBpZiAo
ICFyb290ICkKICAgICAgICAgICAgICAgICBnb3RvIG5vbWVtOwogICAgICAg
ICB9CiAKLSAgICAgICAgY29udGV4dF9zZXRfYWRkcmVzc19yb290KGxjdHh0
LCBwZ2RfbWFkZHIpOworICAgICAgICBjb250ZXh0X3NldF9hZGRyZXNzX3Jv
b3QobGN0eHQsIHJvb3QpOwogICAgICAgICBpZiAoIGF0c19lbmFibGVkICYm
IGVjYXBfZGV2X2lvdGxiKGlvbW11LT5lY2FwKSApCiAgICAgICAgICAgICBj
b250ZXh0X3NldF90cmFuc2xhdGlvbl90eXBlKGxjdHh0LCBDT05URVhUX1RU
X0RFVl9JT1RMQik7CiAgICAgICAgIGVsc2UKQEAgLTE1NTcsMTUgKzE1NjEs
MjEgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIHVu
bWFwX3Z0ZF9kb21haW5fcGFnZShjb250ZXh0X2VudHJpZXMpOwogCiAgICAg
aWYgKCAhc2VnICYmICFyYyApCi0gICAgICAgIHJjID0gbWVfd2lmaV9xdWly
ayhkb21haW4sIGJ1cywgZGV2Zm4sIG1vZGUpOworICAgICAgICByYyA9IG1l
X3dpZmlfcXVpcmsoZG9tYWluLCBidXMsIGRldmZuLCBkb21pZCwgcGdkX21h
ZGRyLCBtb2RlKTsKIAogICAgIGlmICggcmMgKQogICAgIHsKICAgICAgICAg
aWYgKCAhcHJldl9kb20gKQotICAgICAgICAgICAgZG9tYWluX2NvbnRleHRf
dW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOworICAgICAg
ICAgICAgZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUs
IGJ1cywgZGV2Zm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgZG9tYWluLT5kb21haW5faWQpOwogICAgICAgICBlbHNlIGlmICgg
cHJldl9kb20gIT0gZG9tYWluICkgLyogQXZvaWQgaW5maW5pdGUgcmVjdXJz
aW9uLiAqLworICAgICAgICB7CisgICAgICAgICAgICBoZCA9IGRvbV9pb21t
dShwcmV2X2RvbSk7CiAgICAgICAgICAgICBkb21haW5fY29udGV4dF9tYXBw
aW5nX29uZShwcmV2X2RvbSwgaW9tbXUsIGJ1cywgZGV2Zm4sIHBkZXYsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4t
PmRvbWFpbl9pZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGhkLT5hcmNoLnBnZF9tYWRkciwKICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIG1vZGUgJiBNQVBfV0lUSF9STVJSKTsK
KyAgICAgICAgfQogICAgIH0KIAogICAgIGlmICggcHJldl9kb20gKQpAQCAt
MTU4Miw2ICsxNTkyLDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9t
YXBwaW5nKHN0cnVjdAogewogICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAq
ZHJoZDsKICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7
CisgICAgcGFkZHJfdCBwZ2RfbWFkZHIgPSBkb21faW9tbXUoZG9tYWluKS0+
YXJjaC5wZ2RfbWFkZHI7CiAgICAgaW50IHJldCA9IDA7CiAgICAgdW5zaWdu
ZWQgaW50IGksIG1vZGUgPSAwOwogICAgIHVpbnQxNl90IHNlZyA9IHBkZXYt
PnNlZywgYmRmOwpAQCAtMTY0Nyw3ICsxNjU4LDggQEAgc3RhdGljIGludCBk
b21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICAgICAgICAg
ICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBzZWcsIGJ1cywKICAgICAgICAgICAg
ICAgICAgICBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7CiAg
ICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFp
biwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIG1vZGUpOworICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBkb21h
aW4tPmRvbWFpbl9pZCwgcGdkX21hZGRyLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBtb2RlKTsKICAgICAgICAgaWYgKCBy
ZXQgPiAwICkKICAgICAgICAgICAgIHJldCA9IDA7CiAgICAgICAgIGlmICgg
IXJldCAmJiBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBhdHNfZGV2aWNlKHBk
ZXYsIGRyaGQpID4gMCApCkBAIC0xNjYyLDcgKzE2NzQsOCBAQCBzdGF0aWMg
aW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAg
ICAgICAgICAgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikpOwog
CiAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRv
bWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIG1vZGUpOworICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBk
b21haW4tPmRvbWFpbl9pZCwgcGdkX21hZGRyLAorICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBtb2RlKTsKICAgICAgICAgaWYg
KCByZXQgPCAwICkKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBwcmV2
X3ByZXNlbnQgPSByZXQ7CkBAIC0xNjkwLDcgKzE3MDMsOCBAQCBzdGF0aWMg
aW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAq
LwogICAgICAgICBpZiAoIHJldCA+PSAwICkKICAgICAgICAgICAgIHJldCA9
IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9t
bXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBOVUxMLCBtb2RlKTsKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIGRvbWFpbi0+
ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBtb2RlKTsKIAogICAgICAgICAvKgog
ICAgICAgICAgKiBEZXZpY2VzIGJlaGluZCBQQ0llLXRvLVBDSS9QQ0l4IGJy
aWRnZSBtYXkgZ2VuZXJhdGUgZGlmZmVyZW50CkBAIC0xNzA1LDcgKzE3MTks
OCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0
CiAgICAgICAgIGlmICggIXJldCAmJiBwZGV2X3R5cGUoc2VnLCBidXMsIGRl
dmZuKSA9PSBERVZfVFlQRV9QQ0llMlBDSV9CUklER0UgJiYKICAgICAgICAg
ICAgICAoc2VjYnVzICE9IHBkZXYtPmJ1cyB8fCBwZGV2LT5kZXZmbiAhPSAw
KSApCiAgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5n
X29uZShkb21haW4sIGRyaGQtPmlvbW11LCBzZWNidXMsIDAsCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBt
b2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIE5VTEwsIGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBt
b2RlKTsKIAogICAgICAgICBpZiAoIHJldCApCiAgICAgICAgIHsKQEAgLTE3
MzQsNyArMTc0OSw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFw
cGluZyhzdHJ1Y3QKIGludCBkb21haW5fY29udGV4dF91bm1hcF9vbmUoCiAg
ICAgc3RydWN0IGRvbWFpbiAqZG9tYWluLAogICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11LAotICAgIHU4IGJ1cywgdTggZGV2Zm4pCisgICAgdWludDhf
dCBidXMsIHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQpCiB7CiAgICAg
c3RydWN0IGNvbnRleHRfZW50cnkgKmNvbnRleHQsICpjb250ZXh0X2VudHJp
ZXM7CiAgICAgdTY0IG1hZGRyOwpAQCAtMTc5Miw3ICsxODA3LDcgQEAgaW50
IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZSgKICAgICB1bm1hcF92dGRfZG9t
YWluX3BhZ2UoY29udGV4dF9lbnRyaWVzKTsKIAogICAgIGlmICggIWlvbW11
LT5kcmhkLT5zZWdtZW50ICYmICFyYyApCi0gICAgICAgIHJjID0gbWVfd2lm
aV9xdWlyayhkb21haW4sIGJ1cywgZGV2Zm4sIFVOTUFQX01FX1BIQU5UT01f
RlVOQyk7CisgICAgICAgIHJjID0gbWVfd2lmaV9xdWlyayhkb21haW4sIGJ1
cywgZGV2Zm4sIGRvbWlkLCAwLCBVTk1BUF9NRV9QSEFOVE9NX0ZVTkMpOwog
CiAgICAgaWYgKCByYyAmJiAhaXNfaGFyZHdhcmVfZG9tYWluKGRvbWFpbikg
JiYgZG9tYWluICE9IGRvbV9pbyApCiAgICAgewpAQCAtMTg0NCw3ICsxODU5
LDggQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1hcChzdHJ1Y3Qg
ZAogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiZCVkOlBDSWU6IHVu
bWFwICUwNHg6JTAyeDolMDJ4LiV1XG4iLAogICAgICAgICAgICAgICAgICAg
IGRvbWFpbi0+ZG9tYWluX2lkLCBzZWcsIGJ1cywKICAgICAgICAgICAgICAg
ICAgICBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7Ci0gICAg
ICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlv
bW11LCBidXMsIGRldmZuKTsKKyAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRl
eHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4sCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRv
bWFpbl9pZCk7CiAgICAgICAgIGlmICggIXJldCAmJiBkZXZmbiA9PSBwZGV2
LT5kZXZmbiAmJiBhdHNfZGV2aWNlKHBkZXYsIGRyaGQpID4gMCApCiAgICAg
ICAgICAgICBkaXNhYmxlX2F0c19kZXZpY2UocGRldik7CiAKQEAgLTE4NTQs
NyArMTg3MCw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAo
c3RydWN0IGQKICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAg
ICAgICBwcmludGsoVlREUFJFRklYICJkJWQ6UENJOiB1bm1hcCAlMDR4OiUw
Mng6JTAyeC4ldVxuIiwKICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRv
bWFpbl9pZCwgc2VnLCBidXMsIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMo
ZGV2Zm4pKTsKLSAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBf
b25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOworICAgICAgICByZXQg
PSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgYnVz
LCBkZXZmbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgaWYgKCByZXQgKQog
ICAgICAgICAgICAgYnJlYWs7CiAKQEAgLTE4ODAsMTIgKzE4OTcsMTUgQEAg
c3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZAogICAg
ICAgICAvKiBQQ0llIHRvIFBDSS9QQ0l4IGJyaWRnZSAqLwogICAgICAgICBp
ZiAoIHBkZXZfdHlwZShzZWcsIHRtcF9idXMsIHRtcF9kZXZmbikgPT0gREVW
X1RZUEVfUENJZTJQQ0lfQlJJREdFICkKICAgICAgICAgewotICAgICAgICAg
ICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9t
bXUsIHRtcF9idXMsIHRtcF9kZXZmbik7CisgICAgICAgICAgICByZXQgPSBk
b21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgdG1wX2J1
cywgdG1wX2RldmZuLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgICAg
IGlmICggIXJldCApCi0gICAgICAgICAgICAgICAgcmV0ID0gZG9tYWluX2Nv
bnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIHNlY2J1cywgMCk7Cisg
ICAgICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KGRvbWFpbiwgaW9tbXUsIHNlY2J1cywgMCwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5f
aWQpOwogICAgICAgICB9CiAgICAgICAgIGVsc2UgLyogTGVnYWN5IFBDSSBi
cmlkZ2UgKi8KLSAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3Vu
bWFwX29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4pOwor
ICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRv
bWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFp
bl9pZCk7CiAKICAgICAgICAgYnJlYWs7CiAKLS0tIGEveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvdnRkL3F1aXJrcy5jCisrKyBiL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3Z0ZC9xdWlya3MuYwpAQCAtMzQ0LDYgKzM0NCw4IEBAIHZv
aWQgX19pbml0IHBsYXRmb3JtX3F1aXJrc19pbml0KHZvaWQpCiAKIHN0YXRp
YyBpbnQgX19tdXN0X2NoZWNrIG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKHN0
cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBkZXYsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBkb21pZF90IGRvbWlkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBwZ2RfbWFkZHIsCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
bnNpZ25lZCBpbnQgbW9kZSkKIHsKICAgICBzdHJ1Y3QgYWNwaV9kcmhkX3Vu
aXQgKmRyaGQ7CkBAIC0zNTcsMTYgKzM1OSwxNyBAQCBzdGF0aWMgaW50IF9f
bXVzdF9jaGVjayBtYXBfbWVfcGhhbnRvbV9mCiAgICAgLyogbWFwIG9yIHVu
bWFwIE1FIHBoYW50b20gZnVuY3Rpb24gKi8KICAgICBpZiAoICEobW9kZSAm
IFVOTUFQX01FX1BIQU5UT01fRlVOQykgKQogICAgICAgICByYyA9IGRvbWFp
bl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIDAs
Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJ
X0RFVkZOKGRldiwgNyksIE5VTEwsIG1vZGUpOworICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpLCBO
VUxMLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGRvbWlkLCBwZ2RfbWFkZHIsIG1vZGUpOwogICAgIGVsc2UKICAgICAgICAg
cmMgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBkcmhkLT5p
b21tdSwgMCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgUENJX0RFVkZOKGRldiwgNykpOworICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBQQ0lfREVWRk4oZGV2LCA3KSwgZG9taWQpOwog
CiAgICAgcmV0dXJuIHJjOwogfQogCiBpbnQgbWVfd2lmaV9xdWlyayhzdHJ1
Y3QgZG9tYWluICpkb21haW4sIHVpbnQ4X3QgYnVzLCB1aW50OF90IGRldmZu
LAotICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG1vZGUpCisgICAg
ICAgICAgICAgICAgICBkb21pZF90IGRvbWlkLCBwYWRkcl90IHBnZF9tYWRk
ciwgdW5zaWduZWQgaW50IG1vZGUpCiB7CiAgICAgdTMyIGlkOwogICAgIGlu
dCByYyA9IDA7CkBAIC0zOTAsNyArMzkzLDcgQEAgaW50IG1lX3dpZmlfcXVp
cmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLAogICAgICAgICAgICAgY2FzZSAw
eDQyM2I4MDg2OgogICAgICAgICAgICAgY2FzZSAweDQyM2M4MDg2OgogICAg
ICAgICAgICAgY2FzZSAweDQyM2Q4MDg2OgotICAgICAgICAgICAgICAgIHJj
ID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAzLCBtb2RlKTsK
KyAgICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9u
KGRvbWFpbiwgMywgZG9taWQsIHBnZF9tYWRkciwgbW9kZSk7CiAgICAgICAg
ICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAg
ICAgICAgICAgIGJyZWFrOwpAQCAtNDE2LDcgKzQxOSw3IEBAIGludCBtZV93
aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICAgICAgICAg
IGNhc2UgMHg0MjM4ODA4NjogICAgICAgIC8qIFB1bWEgUGVhayAqLwogICAg
ICAgICAgICAgY2FzZSAweDQyMmI4MDg2OgogICAgICAgICAgICAgY2FzZSAw
eDQyMmM4MDg2OgotICAgICAgICAgICAgICAgIHJjID0gbWFwX21lX3BoYW50
b21fZnVuY3Rpb24oZG9tYWluLCAyMiwgbW9kZSk7CisgICAgICAgICAgICAg
ICAgcmMgPSBtYXBfbWVfcGhhbnRvbV9mdW5jdGlvbihkb21haW4sIDIyLCBk
b21pZCwgcGdkX21hZGRyLCBtb2RlKTsKICAgICAgICAgICAgICAgICBicmVh
azsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgYnJl
YWs7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-07.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSUkpCgpSZXBsYWNlIHRoZSBwYXNzaW5nIG9mIHN0
cnVjdCBkb21haW4gKiBieSBkb21pZF90IGluIHByZXBhcmF0aW9uIG9mCnBl
ci1kZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBhbHNvIHJlcXVpcmlu
ZyBwZXItZGV2aWNlIHBzZXVkbwpkb21haW4gSURzLCB3aGljaCBhcmVuJ3Qg
Z29pbmcgdG8gYmUgYXNzb2NpYXRlZCB3aXRoIGFueSBzdHJ1Y3QgZG9tYWlu
Cmluc3RhbmNlcy4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkIChl
eGNlcHQgZm9yIHNsaWdodGx5IGFkanVzdGVkIGxvZyBtZXNzYWdlCnRleHQp
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNv
bT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKQEAgLTUyLDggKzUyLDggQEAgc3RhdGljIHN0cnVjdCB0YXNrbGV0
IHZ0ZF9mYXVsdF90YXNrbGV0Owogc3RhdGljIGludCBzZXR1cF9od2RvbV9k
ZXZpY2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICopOwogc3RhdGljIHZv
aWQgc2V0dXBfaHdkb21fcm1ycihzdHJ1Y3QgZG9tYWluICpkKTsKIAotc3Rh
dGljIGludCBkb21haW5faW9tbXVfZG9taWQoc3RydWN0IGRvbWFpbiAqZCwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQorc3RhdGljIGludCBnZXRfaW9tbXVfZGlkKGRvbWlkX3Qg
ZG9taWQsIGNvbnN0IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAorICAgICAg
ICAgICAgICAgICAgICAgICAgIGJvb2wgd2FybikKIHsKICAgICB1bnNpZ25l
ZCBsb25nIG5yX2RvbSwgaTsKIApAQCAtNjEsMTYgKzYxLDE2IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2lvbW11X2RvbWlkKHN0cnVjdCBkb20KICAgICBpID0g
ZmluZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsK
ICAgICB3aGlsZSAoIGkgPCBucl9kb20gKQogICAgIHsKLSAgICAgICAgaWYg
KCBpb21tdS0+ZG9taWRfbWFwW2ldID09IGQtPmRvbWFpbl9pZCApCisgICAg
ICAgIGlmICggaW9tbXUtPmRvbWlkX21hcFtpXSA9PSBkb21pZCApCiAgICAg
ICAgICAgICByZXR1cm4gaTsKIAogICAgICAgICBpID0gZmluZF9uZXh0X2Jp
dChpb21tdS0+ZG9taWRfYml0bWFwLCBucl9kb20sIGkrMSk7CiAgICAgfQog
Ci0gICAgaWYgKCAhZC0+aXNfZHlpbmcgKQorICAgIGlmICggd2FybiApCiAg
ICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsCi0gICAgICAg
ICAgICAgICAgIkNhbm5vdCBnZXQgdmFsaWQgaW9tbXUgJXUgZG9taWQ6ICVw
ZFxuIiwKLSAgICAgICAgICAgICAgICBpb21tdS0+aW5kZXgsIGQpOworICAg
ICAgICAgICAgICAgICJObyB2YWxpZCBpb21tdSAldSBkb21pZCBmb3IgRG9t
JWRcbiIsCisgICAgICAgICAgICAgICAgaW9tbXUtPmluZGV4LCBkb21pZCk7
CiAKICAgICByZXR1cm4gLTE7CiB9CkBAIC03OCw4ICs3OCw3IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2lvbW11X2RvbWlkKHN0cnVjdCBkb20KICNkZWZpbmUg
RElEX0ZJRUxEX1dJRFRIIDE2CiAjZGVmaW5lIERJRF9ISUdIX09GRlNFVCA4
CiBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9pZChzdHJ1Y3QgY29u
dGV4dF9lbnRyeSAqY29udGV4dCwKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHN0cnVjdCBkb21haW4gKmQsCi0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlkX3QgZG9taWQs
IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQogewogICAgIHVuc2lnbmVkIGxv
bmcgbnJfZG9tLCBpOwogICAgIGludCBmb3VuZCA9IDA7CkBAIC05MCw3ICs4
OSw3IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVj
dAogICAgIGkgPSBmaW5kX2ZpcnN0X2JpdChpb21tdS0+ZG9taWRfYml0bWFw
LCBucl9kb20pOwogICAgIHdoaWxlICggaSA8IG5yX2RvbSApCiAgICAgewot
ICAgICAgICBpZiAoIGlvbW11LT5kb21pZF9tYXBbaV0gPT0gZC0+ZG9tYWlu
X2lkICkKKyAgICAgICAgaWYgKCBpb21tdS0+ZG9taWRfbWFwW2ldID09IGRv
bWlkICkKICAgICAgICAgewogICAgICAgICAgICAgZm91bmQgPSAxOwogICAg
ICAgICAgICAgYnJlYWs7CkBAIC0xMDYsNyArMTA1LDcgQEAgc3RhdGljIGlu
dCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0CiAgICAgICAgICAgICBk
cHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiSU9NTVU6IG5vIGZyZWUg
ZG9tYWluIGlkc1xuIik7CiAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsK
ICAgICAgICAgfQotICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0gZC0+
ZG9tYWluX2lkOworICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0gZG9t
aWQ7CiAgICAgfQogCiAgICAgc2V0X2JpdChpLCBpb21tdS0+ZG9taWRfYml0
bWFwKTsKQEAgLTExNSw5ICsxMTQsOSBAQCBzdGF0aWMgaW50IGNvbnRleHRf
c2V0X2RvbWFpbl9pZChzdHJ1Y3QKICAgICByZXR1cm4gMDsKIH0KIAotc3Rh
dGljIHZvaWQgY2xlYW51cF9kb21pZF9tYXAoc3RydWN0IGRvbWFpbiAqZG9t
YWluLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKK3N0YXRpYyB2b2lkIGNs
ZWFudXBfZG9taWRfbWFwKGRvbWlkX3QgZG9taWQsIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQogewotICAgIGludCBpb21tdV9kb21pZCA9IGRvbWFpbl9p
b21tdV9kb21pZChkb21haW4sIGlvbW11KTsKKyAgICBpbnQgaW9tbXVfZG9t
aWQgPSBnZXRfaW9tbXVfZGlkKGRvbWlkLCBpb21tdSwgZmFsc2UpOwogCiAg
ICAgaWYgKCBpb21tdV9kb21pZCA+PSAwICkKICAgICB7CkBAIC0xNzMsNyAr
MTcyLDcgQEAgc3RhdGljIHZvaWQgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAo
c3RydQogICAgIGlmICggIWZvdW5kICkKICAgICB7CiAgICAgICAgIGNsZWFy
X2JpdChpb21tdS0+aW5kZXgsICZkb21faW9tbXUoZCktPmFyY2guaW9tbXVf
Yml0bWFwKTsKLSAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZCwgaW9tbXUp
OworICAgICAgICBjbGVhbnVwX2RvbWlkX21hcChkLT5kb21haW5faWQsIGlv
bW11KTsKICAgICB9CiB9CiAKQEAgLTYzMCw3ICs2MjksNyBAQCBzdGF0aWMg
aW50IF9fbXVzdF9jaGVjayBpb21tdV9mbHVzaF9pb3RsCiAgICAgICAgICAg
ICBjb250aW51ZTsKIAogICAgICAgICBmbHVzaF9kZXZfaW90bGIgPSAhIWZp
bmRfYXRzX2Rldl9kcmhkKGlvbW11KTsKLSAgICAgICAgaW9tbXVfZG9taWQ9
IGRvbWFpbl9pb21tdV9kb21pZChkLCBpb21tdSk7CisgICAgICAgIGlvbW11
X2RvbWlkID0gZ2V0X2lvbW11X2RpZChkLT5kb21haW5faWQsIGlvbW11LCAh
ZC0+aXNfZHlpbmcpOwogICAgICAgICBpZiAoIGlvbW11X2RvbWlkID09IC0x
ICkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCkBAIC0xNDU0LDcgKzE0NTMs
NyBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgICAg
IHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogICAgIH0K
IAotICAgIHJjID0gY29udGV4dF9zZXRfZG9tYWluX2lkKCZsY3R4dCwgZG9t
YWluLCBpb21tdSk7CisgICAgcmMgPSBjb250ZXh0X3NldF9kb21haW5faWQo
JmxjdHh0LCBkb21pZCwgaW9tbXUpOwogICAgIGlmICggcmMgKQogICAgIHsK
ICAgICB1bmxvY2s6CkBAIC0xNzc0LDcgKzE3NzMsNyBAQCBpbnQgZG9tYWlu
X2NvbnRleHRfdW5tYXBfb25lKAogICAgIGNvbnRleHRfY2xlYXJfZW50cnko
KmNvbnRleHQpOwogICAgIGlvbW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6
ZW9mKHN0cnVjdCBjb250ZXh0X2VudHJ5KSk7CiAKLSAgICBpb21tdV9kb21p
ZD0gZG9tYWluX2lvbW11X2RvbWlkKGRvbWFpbiwgaW9tbXUpOworICAgIGlv
bW11X2RvbWlkID0gZ2V0X2lvbW11X2RpZChkb21pZCwgaW9tbXUsICFkb21h
aW4tPmlzX2R5aW5nKTsKICAgICBpZiAoIGlvbW11X2RvbWlkID09IC0xICkK
ICAgICB7CiAgICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7CkBA
IC0xOTQ4LDcgKzE5NDcsNyBAQCBzdGF0aWMgdm9pZCBpb21tdV9kb21haW5f
dGVhcmRvd24oc3RydWN0CiAgICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1h
cHBpbmdfbG9jayk7CiAKICAgICBmb3JfZWFjaF9kcmhkX3VuaXQgKCBkcmhk
ICkKLSAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZCwgZHJoZC0+aW9tbXUp
OworICAgICAgICBjbGVhbnVwX2RvbWlkX21hcChkLT5kb21haW5faWQsIGRy
aGQtPmlvbW11KTsKIH0KIAogc3RhdGljIGludCBfX211c3RfY2hlY2sgaW50
ZWxfaW9tbXVfbWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3QgZGZu
LAo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-08.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IG1haW50YWluIGEgcGVyLWRldmljZSBwc2V1ZG8gZG9t
YWluIElECgpJbiBvcmRlciB0byBzdWJzZXF1ZW50bHkgZW5hYmxlIHBlci1k
ZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcywgd2UnbGwKbmVlZCBkb21h
aW4tSUQtbGlrZSBpZGVudGlmaWVycyB0byBiZSBpbnNlcnRlZCBpbiB0aGUg
cmVzcGVjdGl2ZSBkZXZpY2UKKEFNRCkgb3IgY29udGV4dCAoSW50ZWwpIHRh
YmxlIGVudHJpZXMgYWxvbmdzaWRlIHRoZSBwZXItZGV2aWNlIHBhZ2UKdGFi
bGUgcm9vdCBhZGRyZXNzZXMuCgpNYWtlIHVzZSBvZiAicmVhbCIgZG9tYWlu
IElEcyBvY2N1cHlpbmcgb25seSBoYWxmIG9mIHRoZSB2YWx1ZSByYW5nZQpj
b3ZlcmFibGUgYnkgZG9taWRfdC4KCk5vdGUgdGhhdCBpbiBWVC1kJ3MgaW9t
bXVfYWxsb2MoKSBJIGRpZG4ndCB3YW50IHRvIGludHJvZHVjZSBuZXcgbWVt
b3J5CmxlYWtzIGluIGNhc2Ugb2YgZXJyb3IsIGJ1dCBleGlzdGluZyBvbmVz
IGRvbid0IGdldCBwbHVnZ2VkIC0gdGhhdCdsbCBiZQp0aGUgc3ViamVjdCBv
ZiBhIGxhdGVyIGNoYW5nZS4KClRoZSBWVC1kIGNoYW5nZXMgYXJlIHNsaWdo
dGx5IGFzeW1tZXRyaWMsIGJ1dCB0aGlzIHdheSB3ZSBjYW4gYXZvaWQKYXNz
aWduaW5nIHBzZXVkbyBkb21haW4gSURzIHRvIGRldmljZXMgd2hpY2ggd291
bGQgbmV2ZXIgYmUgbWFwcGVkIHdoaWxlCnN0aWxsIGF2b2lkaW5nIHRvIGFk
ZCBhIG5ldyBwYXJhbWV0ZXIgdG8gZG9tYWluX2NvbnRleHRfdW5tYXAoKS4K
ClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpS
ZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaW9tbXUuaAor
KysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKQEAgLTEzMCw2ICsx
MzAsMTAgQEAgaW50IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9k
ZXNjCiAgICAgICAgIGlvbW11X3ZjYWxsKG9wcywgc3luY19jYWNoZSwgYWRk
ciwgc2l6ZSk7ICAgICAgIFwKIH0pCiAKK3Vuc2lnbmVkIGxvbmcgKmlvbW11
X2luaXRfZG9taWQodm9pZCk7Citkb21pZF90IGlvbW11X2FsbG9jX2RvbWlk
KHVuc2lnbmVkIGxvbmcgKm1hcCk7Cit2b2lkIGlvbW11X2ZyZWVfZG9taWQo
ZG9taWRfdCBkb21pZCwgdW5zaWduZWQgbG9uZyAqbWFwKTsKKwogI2VuZGlm
IC8qICFfX0FSQ0hfWDg2X0lPTU1VX0hfXyAqLwogLyoKICAqIExvY2FsIHZh
cmlhYmxlczoKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaAorKysg
Yi94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oCkBAIC0xNSw2ICsxNSwxMiBA
QAogCiBzdHJ1Y3QgYXJjaF9wY2lfZGV2IHsKICAgICB2bWFza190IHVzZWRf
dmVjdG9yczsKKyAgICAvKgorICAgICAqIFRoZXNlIGZpZWxkcyBhcmUgKGRl
KWluaXRpYWxpemVkIHVuZGVyIHBjaWRldnMtbG9jay4gT3RoZXIgdXNlcyBv
ZgorICAgICAqIHRoZW0gZG9uJ3QgcmFjZSAoZGUpaW5pdGlhbGl6YXRpb24g
YW5kIGhlbmNlIGRvbid0IHN0cmljdGx5IG5lZWQgYW55CisgICAgICogbG9j
a2luZy4KKyAgICAgKi8KKyAgICBkb21pZF90IHBzZXVkb19kb21pZDsKIH07
CiAKIGludCBwY2lfY29uZl93cml0ZV9pbnRlcmNlcHQodW5zaWduZWQgaW50
IHNlZywgdW5zaWduZWQgaW50IGJkZiwKLS0tIGEveGVuL2luY2x1ZGUvYXNt
LXg4Ni9hbWQtaW9tbXUuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2Ft
ZC1pb21tdS5oCkBAIC05NCw2ICs5NCw3IEBAIHN0cnVjdCBhbWRfaW9tbXUg
ewogICAgIHN0cnVjdCByaW5nX2J1ZmZlciBjbWRfYnVmZmVyOwogICAgIHN0
cnVjdCByaW5nX2J1ZmZlciBldmVudF9sb2c7CiAgICAgc3RydWN0IHJpbmdf
YnVmZmVyIHBwcl9sb2c7CisgICAgdW5zaWduZWQgbG9uZyAqZG9taWRfbWFw
OwogCiAgICAgaW50IGV4Y2x1c2lvbl9lbmFibGU7CiAgICAgaW50IGV4Y2x1
c2lvbl9hbGxvd19hbGw7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L2FtZC9pb21tdV9kZXRlY3QuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9hbWQvaW9tbXVfZGV0ZWN0LmMKQEAgLTE4Myw2ICsxODMsMTEgQEAg
aW50IF9faW5pdCBhbWRfaW9tbXVfZGV0ZWN0X29uZV9hY3BpKAogICAgIGlm
ICggcnQgKQogICAgICAgICBnb3RvIG91dDsKIAorICAgIGlvbW11LT5kb21p
ZF9tYXAgPSBpb21tdV9pbml0X2RvbWlkKCk7CisgICAgcnQgPSAtRU5PTUVN
OworICAgIGlmICggIWlvbW11LT5kb21pZF9tYXAgKQorICAgICAgICBnb3Rv
IG91dDsKKwogICAgIHJ0ID0gcGNpX3JvX2RldmljZShpb21tdS0+c2VnLCBi
dXMsIFBDSV9ERVZGTihkZXYsIGZ1bmMpKTsKICAgICBpZiAoIHJ0ICkKICAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlIKQEAgLTE5NCw3ICsxOTksMTAgQEAg
aW50IF9faW5pdCBhbWRfaW9tbXVfZGV0ZWN0X29uZV9hY3BpKAogCiAgb3V0
OgogICAgIGlmICggcnQgKQorICAgIHsKKyAgICAgICAgeGZyZWUoaW9tbXUt
PmRvbWlkX21hcCk7CiAgICAgICAgIHhmcmVlKGlvbW11KTsKKyAgICB9CiAK
ICAgICByZXR1cm4gcnQ7CiB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL2FtZC9wY2lfYW1kX2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYwpAQCAtNTYzLDYgKzU2Myw4
IEBAIHN0YXRpYyBpbnQgYW1kX2lvbW11X2FkZF9kZXZpY2UodTggZGV2Zm4K
ICAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdTsKICAgICB1MTYgYmRmOwog
ICAgIHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX21hcHBpbmdzOworICAg
IGJvb2wgZnJlc2hfZG9taWQgPSBmYWxzZTsKKyAgICBpbnQgcmV0OwogCiAg
ICAgaWYgKCAhcGRldi0+ZG9tYWluICkKICAgICAgICAgcmV0dXJuIC1FSU5W
QUw7CkBAIC02MjYsNyArNjI4LDIyIEBAIHN0YXRpYyBpbnQgYW1kX2lvbW11
X2FkZF9kZXZpY2UodTggZGV2Zm4KICAgICAgICAgc3Bpbl91bmxvY2tfaXJx
cmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKICAgICB9CiAKLSAgICBy
ZXR1cm4gYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2UocGRldi0+ZG9t
YWluLCBpb21tdSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggaW9tbXVfcXVh
cmFudGluZSAmJiBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9PSBET01JRF9J
TlZBTElEICkKKyAgICB7CisgICAgICAgIHBkZXYtPmFyY2gucHNldWRvX2Rv
bWlkID0gaW9tbXVfYWxsb2NfZG9taWQoaW9tbXUtPmRvbWlkX21hcCk7Cisg
ICAgICAgIGlmICggcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPT0gRE9NSURf
SU5WQUxJRCApCisgICAgICAgICAgICByZXR1cm4gLUVOT1NQQzsKKyAgICAg
ICAgZnJlc2hfZG9taWQgPSB0cnVlOworICAgIH0KKworICAgIHJldCA9IGFt
ZF9pb21tdV9zZXR1cF9kb21haW5fZGV2aWNlKHBkZXYtPmRvbWFpbiwgaW9t
bXUsIGRldmZuLCBwZGV2KTsKKyAgICBpZiAoIHJldCAmJiBmcmVzaF9kb21p
ZCApCisgICAgeworICAgICAgICBpb21tdV9mcmVlX2RvbWlkKHBkZXYtPmFy
Y2gucHNldWRvX2RvbWlkLCBpb21tdS0+ZG9taWRfbWFwKTsKKyAgICAgICAg
cGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBET01JRF9JTlZBTElEOworICAg
IH0KKworICAgIHJldHVybiByZXQ7CiB9CiAKIHN0YXRpYyBpbnQgYW1kX2lv
bW11X3JlbW92ZV9kZXZpY2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICpw
ZGV2KQpAQCAtNjUxLDYgKzY2OCw5IEBAIHN0YXRpYyBpbnQgYW1kX2lvbW11
X3JlbW92ZV9kZXZpY2UodTggZGUKIAogICAgIGFtZF9pb21tdV9kaXNhYmxl
X2RvbWFpbl9kZXZpY2UocGRldi0+ZG9tYWluLCBpb21tdSwgZGV2Zm4sIHBk
ZXYpOwogCisgICAgaW9tbXVfZnJlZV9kb21pZChwZGV2LT5hcmNoLnBzZXVk
b19kb21pZCwgaW9tbXUtPmRvbWlkX21hcCk7CisgICAgcGRldi0+YXJjaC5w
c2V1ZG9fZG9taWQgPSBET01JRF9JTlZBTElEOworCiAgICAgaXZyc19tYXBw
aW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHBkZXYtPnNlZyk7CiAgICAgYmRm
ID0gUENJX0JERjIocGRldi0+YnVzLCBkZXZmbik7CiAgICAgaWYgKCBhbWRf
aW9tbXVfcGVyZGV2X2ludHJlbWFwICYmCi0tLSBhL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3BjaS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3BjaS5jCkBAIC0zMzgsNiArMzM4LDcgQEAgc3RhdGljIHN0cnVjdCBwY2lf
ZGV2ICphbGxvY19wZGV2KHN0cnVjdAogICAgICooKHU4KikgJnBkZXYtPmJ1
cykgPSBidXM7CiAgICAgKigodTgqKSAmcGRldi0+ZGV2Zm4pID0gZGV2Zm47
CiAgICAgcGRldi0+ZG9tYWluID0gTlVMTDsKKyAgICBwZGV2LT5hcmNoLnBz
ZXVkb19kb21pZCA9IERPTUlEX0lOVkFMSUQ7CiAgICAgSU5JVF9MSVNUX0hF
QUQoJnBkZXYtPm1zaV9saXN0KTsKIAogICAgIHBvcyA9IHBjaV9maW5kX2Nh
cF9vZmZzZXQocHNlZy0+bnIsIGJ1cywgUENJX1NMT1QoZGV2Zm4pLCBQQ0lf
RlVOQyhkZXZmbiksCkBAIC0xMzUzLDkgKzEzNTQsMTMgQEAgc3RhdGljIGlu
dCBfZHVtcF9wY2lfZGV2aWNlcyhzdHJ1Y3QgcGNpXwogCiAgICAgbGlzdF9m
b3JfZWFjaF9lbnRyeSAoIHBkZXYsICZwc2VnLT5hbGxkZXZzX2xpc3QsIGFs
bGRldnNfbGlzdCApCiAgICAgewotICAgICAgICBwcmludGsoIiUwNHg6JTAy
eDolMDJ4LiV1IC0gJXBkIC0gbm9kZSAlLTNkIC0gTVNJcyA8ICIsCi0gICAg
ICAgICAgICAgICBwc2VnLT5uciwgcGRldi0+YnVzLAotICAgICAgICAgICAg
ICAgUENJX1NMT1QocGRldi0+ZGV2Zm4pLCBQQ0lfRlVOQyhwZGV2LT5kZXZm
biksIHBkZXYtPmRvbWFpbiwKKyAgICAgICAgcHJpbnRrKCIlMDR4OiUwMng6
JTAyeC4ldSAtICIsIHBzZWctPm5yLCBwZGV2LT5idXMsCisgICAgICAgICAg
ICAgICBQQ0lfU0xPVChwZGV2LT5kZXZmbiksIFBDSV9GVU5DKHBkZXYtPmRl
dmZuKSk7CisgICAgICAgIGlmICggcGRldi0+ZG9tYWluID09IGRvbV9pbyAp
CisgICAgICAgICAgICBwcmludGsoIkRvbUlPOiV4IiwgcGRldi0+YXJjaC5w
c2V1ZG9fZG9taWQpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBwcmlu
dGsoIiVwZCIsIHBkZXYtPmRvbWFpbik7CisgICAgICAgIHByaW50aygiIC0g
bm9kZSAlLTNkIC0gTVNJcyA8ICIsCiAgICAgICAgICAgICAgICAocGRldi0+
bm9kZSAhPSBOVU1BX05PX05PREUpID8gcGRldi0+bm9kZSA6IC0xKTsKICAg
ICAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIG1zaSwgJnBkZXYtPm1zaV9s
aXN0LCBsaXN0ICkKICAgICAgICAgICAgICAgIHByaW50aygiJWQgIiwgbXNp
LT5pcnEpOwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t
bXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUu
YwpAQCAtMjIsNiArMjIsNyBAQAogI2luY2x1ZGUgPHhlbi9zY2hlZC5oPgog
I2luY2x1ZGUgPHhlbi94bWFsbG9jLmg+CiAjaW5jbHVkZSA8eGVuL2RvbWFp
bl9wYWdlLmg+CisjaW5jbHVkZSA8eGVuL2Vyci5oPgogI2luY2x1ZGUgPHhl
bi9pb2NhcC5oPgogI2luY2x1ZGUgPHhlbi9pb21tdS5oPgogI2luY2x1ZGUg
PHhlbi9udW1hLmg+CkBAIC0xMTkyLDcgKzExOTMsNyBAQCBpbnQgX19pbml0
IGlvbW11X2FsbG9jKHN0cnVjdCBhY3BpX2RyaGRfCiB7CiAgICAgc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXU7CiAgICAgdW5zaWduZWQgbG9uZyBzYWdhdywg
bnJfZG9tOwotICAgIGludCBhZ2F3OworICAgIGludCBhZ2F3LCByYzsKIAog
ICAgIGlmICggbnJfaW9tbXVzID49IE1BWF9JT01NVVMgKQogICAgIHsKQEAg
LTEyODUsNyArMTI4NiwxNiBAQCBpbnQgX19pbml0IGlvbW11X2FsbG9jKHN0
cnVjdCBhY3BpX2RyaGRfCiAgICAgaWYgKCAhaW9tbXUtPmRvbWlkX21hcCAp
CiAgICAgICAgIHJldHVybiAtRU5PTUVNOwogCisgICAgaW9tbXUtPnBzZXVk
b19kb21pZF9tYXAgPSBpb21tdV9pbml0X2RvbWlkKCk7CisgICAgcmMgPSAt
RU5PTUVNOworICAgIGlmICggIWlvbW11LT5wc2V1ZG9fZG9taWRfbWFwICkK
KyAgICAgICAgZ290byBmcmVlOworCiAgICAgcmV0dXJuIDA7CisKKyBmcmVl
OgorICAgIGlvbW11X2ZyZWUoZHJoZCk7CisgICAgcmV0dXJuIHJjOwogfQog
CiB2b2lkIF9faW5pdCBpb21tdV9mcmVlKHN0cnVjdCBhY3BpX2RyaGRfdW5p
dCAqZHJoZCkKQEAgLTEzMDgsNiArMTMxOCw3IEBAIHZvaWQgX19pbml0IGlv
bW11X2ZyZWUoc3RydWN0IGFjcGlfZHJoZF8KIAogICAgIHhmcmVlKGlvbW11
LT5kb21pZF9iaXRtYXApOwogICAgIHhmcmVlKGlvbW11LT5kb21pZF9tYXAp
OworICAgIHhmcmVlKGlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKIAogICAg
IGlmICggaW9tbXUtPm1zaS5pcnEgPj0gMCApCiAgICAgICAgIGRlc3Ryb3lf
aXJxKGlvbW11LT5tc2kuaXJxKTsKQEAgLTE1ODMsOCArMTU5NCw4IEBAIGlu
dCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICByZXR1cm4gcmMg
PzogcGRldiAmJiBwcmV2X2RvbTsKIH0KIAotc3RhdGljIGludCBkb21haW5f
Y29udGV4dF91bm1hcChzdHJ1Y3QgZG9tYWluICpkLCB1aW50OF90IGRldmZu
LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcGNp
X2RldiAqcGRldik7CitzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91
bml0ICpkb21haW5fY29udGV4dF91bm1hcCgKKyAgICBzdHJ1Y3QgZG9tYWlu
ICpkLCB1aW50OF90IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldik7CiAK
IHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QgZG9t
YWluICpkb21haW4sIHU4IGRldmZuLAogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQpAQCAtMTU5Miw2
ICsxNjAzLDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5n
KHN0cnVjdAogICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZDsKICAg
ICBjb25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CiAgICAgcGFk
ZHJfdCBwZ2RfbWFkZHIgPSBkb21faW9tbXUoZG9tYWluKS0+YXJjaC5wZ2Rf
bWFkZHI7CisgICAgZG9taWRfdCBvcmlnX2RvbWlkID0gcGRldi0+YXJjaC5w
c2V1ZG9fZG9taWQ7CiAgICAgaW50IHJldCA9IDA7CiAgICAgdW5zaWduZWQg
aW50IGksIG1vZGUgPSAwOwogICAgIHVpbnQxNl90IHNlZyA9IHBkZXYtPnNl
ZywgYmRmOwpAQCAtMTY1Miw2ICsxNjY0LDE0IEBAIHN0YXRpYyBpbnQgZG9t
YWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgYnJlYWs7CiAK
ICAgICBjYXNlIERFVl9UWVBFX1BDSWVfRU5EUE9JTlQ6CisgICAgICAgIGlm
ICggaW9tbXVfcXVhcmFudGluZSAmJiBvcmlnX2RvbWlkID09IERPTUlEX0lO
VkFMSUQgKQorICAgICAgICB7CisgICAgICAgICAgICBwZGV2LT5hcmNoLnBz
ZXVkb19kb21pZCA9CisgICAgICAgICAgICAgICAgaW9tbXVfYWxsb2NfZG9t
aWQoZHJoZC0+aW9tbXUtPnBzZXVkb19kb21pZF9tYXApOworICAgICAgICAg
ICAgaWYgKCBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9PSBET01JRF9JTlZB
TElEICkKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT1NQQzsKKyAgICAg
ICAgfQorCiAgICAgICAgIGlmICggaW9tbXVfZGVidWcgKQogICAgICAgICAg
ICAgcHJpbnRrKFZURFBSRUZJWCAiZCVkOlBDSWU6IG1hcCAlMDR4OiUwMng6
JTAyeC4ldVxuIiwKICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFp
bl9pZCwgc2VnLCBidXMsCkBAIC0xNjY3LDYgKzE2ODcsMTQgQEAgc3RhdGlj
IGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICBi
cmVhazsKIAogICAgIGNhc2UgREVWX1RZUEVfUENJOgorICAgICAgICBpZiAo
IGlvbW11X3F1YXJhbnRpbmUgJiYgb3JpZ19kb21pZCA9PSBET01JRF9JTlZB
TElEICkKKyAgICAgICAgeworICAgICAgICAgICAgcGRldi0+YXJjaC5wc2V1
ZG9fZG9taWQgPQorICAgICAgICAgICAgICAgIGlvbW11X2FsbG9jX2RvbWlk
KGRyaGQtPmlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKKyAgICAgICAgICAg
IGlmICggcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPT0gRE9NSURfSU5WQUxJ
RCApCisgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9TUEM7CisgICAgICAg
IH0KKwogICAgICAgICBpZiAoIGlvbW11X2RlYnVnICkKICAgICAgICAgICAg
IHByaW50ayhWVERQUkVGSVggImQlZDpQQ0k6IG1hcCAlMDR4OiUwMng6JTAy
eC4ldVxuIiwKICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9p
ZCwgc2VnLCBidXMsCkBAIC0xNzQyLDYgKzE3NzAsMTMgQEAgc3RhdGljIGlu
dCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgIGlmICggIXJl
dCAmJiBkZXZmbiA9PSBwZGV2LT5kZXZmbiApCiAgICAgICAgIHBjaV92dGRf
cXVpcmsocGRldik7CiAKKyAgICBpZiAoIHJldCAmJiBkcmhkICYmIG9yaWdf
ZG9taWQgPT0gRE9NSURfSU5WQUxJRCApCisgICAgeworICAgICAgICBpb21t
dV9mcmVlX2RvbWlkKHBkZXYtPmFyY2gucHNldWRvX2RvbWlkLAorICAgICAg
ICAgICAgICAgICAgICAgICAgIGRyaGQtPmlvbW11LT5wc2V1ZG9fZG9taWRf
bWFwKTsKKyAgICAgICAgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBET01J
RF9JTlZBTElEOworICAgIH0KKwogICAgIHJldHVybiByZXQ7CiB9CiAKQEAg
LTE4MjQsOCArMTg1OSwxMCBAQCBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXBf
b25lKAogICAgIHJldHVybiByYzsKIH0KIAotc3RhdGljIGludCBkb21haW5f
Y29udGV4dF91bm1hcChzdHJ1Y3QgZG9tYWluICpkb21haW4sIHU4IGRldmZu
LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcGNp
X2RldiAqcGRldikKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3Vu
aXQgKmRvbWFpbl9jb250ZXh0X3VubWFwKAorICAgIHN0cnVjdCBkb21haW4g
KmRvbWFpbiwKKyAgICB1aW50OF90IGRldmZuLAorICAgIHN0cnVjdCBwY2lf
ZGV2ICpwZGV2KQogewogICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJo
ZDsKICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdTsKQEAgLTE4MzQsNyAr
MTg3MSw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3Ry
dWN0IGQKIAogICAgIGRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3Vu
aXQocGRldik7CiAgICAgaWYgKCAhZHJoZCApCi0gICAgICAgIHJldHVybiAt
RU5PREVWOworICAgICAgICByZXR1cm4gRVJSX1BUUigtRU5PREVWKTsKICAg
ICBpb21tdSA9IGRyaGQtPmlvbW11OwogCiAgICAgc3dpdGNoICggcGRldi0+
dHlwZSApCkBAIC0xODQ1LDcgKzE4ODIsNyBAQCBzdGF0aWMgaW50IGRvbWFp
bl9jb250ZXh0X3VubWFwKHN0cnVjdCBkCiAgICAgICAgICAgICAgICAgICAg
ZG9tYWluLT5kb21haW5faWQsIHNlZywgYnVzLAogICAgICAgICAgICAgICAg
ICAgIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pKTsKICAgICAg
ICAgaWYgKCAhaXNfaGFyZHdhcmVfZG9tYWluKGRvbWFpbikgKQotICAgICAg
ICAgICAgcmV0dXJuIC1FUEVSTTsKKyAgICAgICAgICAgIHJldHVybiBFUlJf
UFRSKC1FUEVSTSk7CiAgICAgICAgIGdvdG8gb3V0OwogCiAgICAgY2FzZSBE
RVZfVFlQRV9QQ0llX0JSSURHRToKQEAgLTE5MjMsNyArMTk2MCw3IEBAIHN0
YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3RydWN0IGQKICAgICAg
ICAgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAoZG9tYWluLCBwZGV2LCBpb21t
dSk7CiAKIG91dDoKLSAgICByZXR1cm4gcmV0OworICAgIHJldHVybiByZXQg
PyBFUlJfUFRSKHJldCkgOiBkcmhkOwogfQogCiBzdGF0aWMgdm9pZCBpb21t
dV9kb21haW5fdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKQEAgLTIxNDUs
MTYgKzIxODIsMTcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9lbmFibGVf
ZGV2aWNlKHN0cgogCiBzdGF0aWMgaW50IGludGVsX2lvbW11X3JlbW92ZV9k
ZXZpY2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQogeworICAg
IGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZDsKICAgICBzdHJ1
Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CiAgICAgdTE2IGJkZjsKLSAgICBp
bnQgcmV0LCBpOworICAgIHVuc2lnbmVkIGludCBpOwogCiAgICAgaWYgKCAh
cGRldi0+ZG9tYWluICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CiAKLSAg
ICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcChwZGV2LT5kb21haW4sIGRl
dmZuLCBwZGV2KTsKLSAgICBpZiAoIHJldCApCi0gICAgICAgIHJldHVybiBy
ZXQ7CisgICAgZHJoZCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHBkZXYtPmRv
bWFpbiwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggSVNfRVJSKGRyaGQpICkK
KyAgICAgICAgcmV0dXJuIFBUUl9FUlIoZHJoZCk7CiAKICAgICBmb3JfZWFj
aF9ybXJyX2RldmljZSAoIHJtcnIsIGJkZiwgaSApCiAgICAgewpAQCAtMjE3
MSw2ICsyMjA5LDEzIEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVfcmVtb3Zl
X2RldmljZSh1OAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJt
cnItPmVuZF9hZGRyZXNzLCAwKTsKICAgICB9CiAKKyAgICBpZiAoIGRyaGQg
KQorICAgIHsKKyAgICAgICAgaW9tbXVfZnJlZV9kb21pZChwZGV2LT5hcmNo
LnBzZXVkb19kb21pZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICBkcmhk
LT5pb21tdS0+cHNldWRvX2RvbWlkX21hcCk7CisgICAgICAgIHBkZXYtPmFy
Y2gucHNldWRvX2RvbWlkID0gRE9NSURfSU5WQUxJRDsKKyAgICB9CisKICAg
ICByZXR1cm4gMDsKIH0KIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC92dGQvaW9tbXUuaAorKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92
dGQvaW9tbXUuaApAQCAtNTM1LDYgKzUzNSw3IEBAIHN0cnVjdCB2dGRfaW9t
bXUgewogICAgIH0gZmx1c2g7CiAKICAgICBzdHJ1Y3QgbGlzdF9oZWFkIGF0
c19kZXZpY2VzOworICAgIHVuc2lnbmVkIGxvbmcgKnBzZXVkb19kb21pZF9t
YXA7IC8qICJwc2V1ZG8iIGRvbWFpbiBpZCBiaXRtYXAgKi8KICAgICB1bnNp
Z25lZCBsb25nICpkb21pZF9iaXRtYXA7ICAvKiBkb21haW4gaWQgYml0bWFw
ICovCiAgICAgdTE2ICpkb21pZF9tYXA7ICAgICAgICAgICAgICAgLyogZG9t
YWluIGlkIG1hcHBpbmcgYXJyYXkgKi8KICAgICB1aW50MzJfdCB2ZXJzaW9u
OwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9tbXUuYwor
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9tbXUuYwpAQCAt
MzQ2LDYgKzM0Niw1MyBAQCB2b2lkIF9faHdkb21faW5pdCBhcmNoX2lvbW11
X2h3ZG9tX2luaXQoCiAgICAgICAgIHJldHVybjsKIH0KIAordW5zaWduZWQg
bG9uZyAqX19pbml0IGlvbW11X2luaXRfZG9taWQodm9pZCkKK3sKKyAgICBp
ZiAoICFpb21tdV9xdWFyYW50aW5lICkKKyAgICAgICAgcmV0dXJuIFpFUk9f
QkxPQ0tfUFRSOworCisgICAgQlVJTERfQlVHX09OKERPTUlEX01BU0sgKiAy
VSA+PSBVSU5UMTZfTUFYKTsKKworICAgIHJldHVybiB4emFsbG9jX2FycmF5
KHVuc2lnbmVkIGxvbmcsCisgICAgICAgICAgICAgICAgICAgICAgICAgQklU
U19UT19MT05HUyhVSU5UMTZfTUFYIC0gRE9NSURfTUFTSykpOworfQorCitk
b21pZF90IGlvbW11X2FsbG9jX2RvbWlkKHVuc2lnbmVkIGxvbmcgKm1hcCkK
K3sKKyAgICAvKgorICAgICAqIFRoaXMgaXMgdXNlZCB1bmlmb3JtbHkgYWNy
b3NzIGFsbCBJT01NVXMsIHN1Y2ggdGhhdCBvbiB0eXBpY2FsCisgICAgICog
c3lzdGVtcyB3ZSB3b3VsZG4ndCByZS11c2UgdGhlIHNhbWUgSUQgdmVyeSBx
dWlja2x5IChwZXJoYXBzIG5ldmVyKS4KKyAgICAgKi8KKyAgICBzdGF0aWMg
dW5zaWduZWQgaW50IHN0YXJ0OworICAgIHVuc2lnbmVkIGludCBpZHggPSBm
aW5kX25leHRfemVyb19iaXQobWFwLCBVSU5UMTZfTUFYIC0gRE9NSURfTUFT
Sywgc3RhcnQpOworCisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOwor
CisgICAgaWYgKCBpZHggPj0gVUlOVDE2X01BWCAtIERPTUlEX01BU0sgKQor
ICAgICAgICBpZHggPSBmaW5kX2ZpcnN0X3plcm9fYml0KG1hcCwgVUlOVDE2
X01BWCAtIERPTUlEX01BU0spOworICAgIGlmICggaWR4ID49IFVJTlQxNl9N
QVggLSBET01JRF9NQVNLICkKKyAgICAgICAgcmV0dXJuIERPTUlEX0lOVkFM
SUQ7CisKKyAgICBfX3NldF9iaXQoaWR4LCBtYXApOworCisgICAgc3RhcnQg
PSBpZHggKyAxOworCisgICAgcmV0dXJuIGlkeCB8IChET01JRF9NQVNLICsg
MSk7Cit9CisKK3ZvaWQgaW9tbXVfZnJlZV9kb21pZChkb21pZF90IGRvbWlk
LCB1bnNpZ25lZCBsb25nICptYXApCit7CisgICAgQVNTRVJUKHBjaWRldnNf
bG9ja2VkKCkpOworCisgICAgaWYgKCBkb21pZCA9PSBET01JRF9JTlZBTElE
ICkKKyAgICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKGRvbWlkID4gRE9N
SURfTUFTSyk7CisKKyAgICBpZiAoICFfX3Rlc3RfYW5kX2NsZWFyX2JpdChk
b21pZCAmIERPTUlEX01BU0ssIG1hcCkgKQorICAgICAgICBCVUcoKTsKK30K
KwogLyoKICAqIExvY2FsIHZhcmlhYmxlczoKICAqIG1vZGU6IEMKLS0tIGEv
eGVuL2luY2x1ZGUvcHVibGljL3hlbi5oCisrKyBiL3hlbi9pbmNsdWRlL3B1
YmxpYy94ZW4uaApAQCAtNjE0LDYgKzYxNCw5IEBAIERFRklORV9YRU5fR1VF
U1RfSEFORExFKG1tdWV4dF9vcF90KTsKIC8qIElkbGUgZG9tYWluLiAqLwog
I2RlZmluZSBET01JRF9JRExFICAgICAgICAgICB4ZW5fbWtfdWludCgweDdG
RkYpCiAKKy8qIE1hc2sgZm9yIHZhbGlkIGRvbWFpbiBpZCB2YWx1ZXMgKi8K
KyNkZWZpbmUgRE9NSURfTUFTSyAgICAgICAgICAgeGVuX21rX3VpbnQoMHg3
RkZGKQorCiAjaWZuZGVmIF9fQVNTRU1CTFlfXwogCiB0eXBlZGVmIHVpbnQx
Nl90IGRvbWlkX3Q7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-09.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IGRyb3AgVExCIGZsdXNoZXMgZnJvbSBxdWFyYW50aW5l
X2luaXQoKSBob29rcwoKVGhlIHBhZ2UgdGFibGVzIGp1c3QgY3JlYXRlZCBh
cmVuJ3QgaG9va2VkIHVwIHlldCBhbnl3aGVyZSwgc28gdGhlcmUncwpub3Ro
aW5nIHRoYXQgY291bGQgYmUgcHJlc2VudCBpbiBhbnkgVExCLCBhbmQgaGVu
Y2Ugbm90aGluZyB0byBmbHVzaC4KRHJvcHBpbmcgdGhpcyBmbHVzaCBpcywg
YXQgbGVhc3Qgb24gdGhlIFZULWQgc2lkZSwgYSBwcmVyZXEgdG8gcGVyLQpk
ZXZpY2UgZG9tYWluIElEIHVzZSB3aGVuIHF1YXJhbnRpbmluZyBkZXZpY2Vz
LCBhcyBkb21faW8gaXNuJ3QgZ29pbmcKdG8gYmUgYXNzaWduZWQgYSBESUQg
YW55bW9yZTogVGhlIHdhcm5pbmcgaW4gZ2V0X2lvbW11X2RpZCgpIHdvdWxk
CnRyaWdnZXIuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxA
eGVuLm9yZz4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy
LnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2
aW4udGlhbkBpbnRlbC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11X21hcC5jCkBAIC01OTUsOCArNTk1LDYgQEAgaW50
IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cgogIG91dDoK
ICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKIAot
ICAgIGFtZF9pb21tdV9mbHVzaF9hbGxfcGFnZXMoZCk7Ci0KICAgICAvKiBQ
YWdlcyBsZWFrZWQgaW4gZmFpbHVyZSBjYXNlICovCiAgICAgcmV0dXJuIGxl
dmVsID8gLUVOT01FTSA6IDA7CiB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5jCkBAIC0yODk0LDcgKzI4OTQsNiBAQCBzdGF0aWMg
aW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFyYW50aW5lCiAgICAgc3RydWN0
IGRtYV9wdGUgKnBhcmVudDsKICAgICB1bnNpZ25lZCBpbnQgYWdhdyA9IHdp
ZHRoX3RvX2FnYXcoREVGQVVMVF9ET01BSU5fQUREUkVTU19XSURUSCk7CiAg
ICAgdW5zaWduZWQgaW50IGxldmVsID0gYWdhd190b19sZXZlbChhZ2F3KTsK
LSAgICBpbnQgcmM7CiAKICAgICBpZiAoIGhkLT5hcmNoLnBnZF9tYWRkciAp
CiAgICAgewpAQCAtMjk0MSwxMCArMjk0MCw4IEBAIHN0YXRpYyBpbnQgX19p
bml0IGludGVsX2lvbW11X3F1YXJhbnRpbmUKICBvdXQ6CiAgICAgc3Bpbl91
bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAKLSAgICByYyA9IGlv
bW11X2ZsdXNoX2lvdGxiX2FsbChkKTsKLQogICAgIC8qIFBhZ2VzIGxlYWtl
ZCBpbiBmYWlsdXJlIGNhc2UgKi8KLSAgICByZXR1cm4gbGV2ZWwgPyAtRU5P
TUVNIDogcmM7CisgICAgcmV0dXJuIGxldmVsID8gLUVOT01FTSA6IDA7CiB9
CiAKIGNvbnN0IHN0cnVjdCBpb21tdV9vcHMgX19pbml0Y29uc3RyZWwgaW50
ZWxfaW9tbXVfb3BzID0gewo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-10.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IGFic3RyYWN0IG1heGltdW0gbnVtYmVyIG9mIHBhZ2Ug
dGFibGUgbGV2ZWxzCgpXZSB3aWxsIHdhbnQgdG8gdXNlIHRoZSBjb25zdGFu
dCBlbHNld2hlcmUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBh
dWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3N2
bS9hbWQtaW9tbXUtcHJvdG8uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2
L2h2bS9zdm0vYW1kLWlvbW11LXByb3RvLmgKQEAgLTE5Myw3ICsxOTMsNyBA
QCBzdGF0aWMgaW5saW5lIGludCBhbWRfaW9tbXVfZ2V0X3BhZ2luZ19tCiAg
ICAgd2hpbGUgKCBtYXhfZnJhbWVzID4gUFRFX1BFUl9UQUJMRV9TSVpFICkK
ICAgICB7CiAgICAgICAgIG1heF9mcmFtZXMgPSBQVEVfUEVSX1RBQkxFX0FM
SUdOKG1heF9mcmFtZXMpID4+IFBURV9QRVJfVEFCTEVfU0hJRlQ7Ci0gICAg
ICAgIGlmICggKytsZXZlbCA+IDYgKQorICAgICAgICBpZiAoICsrbGV2ZWwg
PiBJT01NVV9NQVhfUFRfTEVWRUxTICkKICAgICAgICAgICAgIHJldHVybiAt
RU5PTUVNOwogICAgIH0KIAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2h2
bS9zdm0vYW1kLWlvbW11LWRlZnMuaAorKysgYi94ZW4vaW5jbHVkZS9hc20t
eDg2L2h2bS9zdm0vYW1kLWlvbW11LWRlZnMuaApAQCAtMTEwLDYgKzExMCw3
IEBAIHN0cnVjdCBhbWRfaW9tbXVfZHRlIHsKICAgICBib29sIHR2OjE7CiAg
ICAgdW5zaWduZWQgaW50IDo1OwogICAgIHVuc2lnbmVkIGludCBoYWQ6MjsK
KyNkZWZpbmUgSU9NTVVfTUFYX1BUX0xFVkVMUyA2CiAgICAgdW5zaWduZWQg
aW50IHBhZ2luZ19tb2RlOjM7CiAgICAgdWludDY0X3QgcHRfcm9vdDo0MDsK
ICAgICBib29sIHBwcjoxOwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvYW1kL2lvbW11X21hcC5jCkBAIC0yNjAsNyArMjYwLDcgQEAgc3RhdGlj
IGludCBpb21tdV9wZGVfZnJvbV9kZm4oc3RydWN0IGRvbQogICAgIHRhYmxl
ID0gaGQtPmFyY2gucm9vdF90YWJsZTsKICAgICBsZXZlbCA9IGhkLT5hcmNo
LnBhZ2luZ19tb2RlOwogCi0gICAgQlVHX09OKCB0YWJsZSA9PSBOVUxMIHx8
IGxldmVsIDwgMSB8fCBsZXZlbCA+IDYgKTsKKyAgICBCVUdfT04oIHRhYmxl
ID09IE5VTEwgfHwgbGV2ZWwgPCAxIHx8IGxldmVsID4gSU9NTVVfTUFYX1BU
X0xFVkVMUyApOwogCiAgICAgLyoKICAgICAgKiBBIGZyYW1lIG51bWJlciBw
YXN0IHdoYXQgdGhlIGN1cnJlbnQgcGFnZSB0YWJsZXMgY2FuIHJlcHJlc2Vu
dCBjYW4ndAo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.13-11.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.13-11.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHVzZSBwZXItZGV2aWNlIHBhZ2UgdGFibGVzIGZvciBx
dWFyYW50aW5pbmcKCkRldmljZXMgd2l0aCBSTVJScyAvIHVuaXR5IG1hcHBl
ZCByZWdpb25zLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQKaG93L3do
ZW4gdGhlc2UgbWVtb3J5IHJlZ2lvbnMgbWF5IGJlIGFjY2Vzc2VkLCBtYXkg
bm90IGJlIGxlZnQKZGlzY29ubmVjdGVkIGZyb20gdGhlIG1hcHBpbmdzIG9m
IHRoZXNlIHJlZ2lvbnMgKGFzIGxvbmcgYXMgaXQncyBub3QKY2VydGFpbiB0
aGF0IHRoZSBkZXZpY2UgaGFzIGJlZW4gZnVsbHkgcXVpZXNjZWQpLiBIZW5j
ZSBldmVuIHRoZSBwYWdlCnRhYmxlcyB1c2VkIHdoZW4gcXVhcmFudGluaW5n
IHN1Y2ggZGV2aWNlcyBuZWVkIHRvIGhhdmUgbWFwcGluZ3Mgb2YKdGhvc2Ug
cmVnaW9ucy4gVGhpcyBpbXBsaWVzIGluc3RhbGxpbmcgcGFnZSB0YWJsZXMg
aW4gdGhlIGZpcnN0IHBsYWNlCmV2ZW4gd2hlbiBub3QgaW4gc2NyYXRjaC1w
YWdlIHF1YXJhbnRpbmluZyBtb2RlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM2
MSAvIHBhcnQgb2YgWFNBLTQwMC4KCldoaWxlIGZvciB0aGUgcHVycG9zZSBo
ZXJlIGl0IHdvdWxkIGJlIHN1ZmZpY2llbnQgdG8gaGF2ZSBkZXZpY2VzIHdp
dGgKUk1SUnMgLyB1bml0eSBtYXBwZWQgcmVnaW9ucyB1c2UgcGVyLWRldmlj
ZSBwYWdlIHRhYmxlcywgZXh0ZW5kIHRoaXMgdG8KYWxsIGRldmljZXMgKGlu
IHNjcmF0Y2gtcGFnZSBxdWFyYW50aW5pbmcgbW9kZSkuIFRoaXMgYWxsb3dz
IHRoZSBsZWFmCnBhZ2VzIHRvIGJlIG1hcHBlZCByL3csIHRodXMgY292ZXJp
bmcgYWxzbyBtZW1vcnkgd3JpdGVzIChyYXRoZXIgdGhhbgpqdXN0IHJlYWRz
KSBpc3N1ZWQgYnkgbm9uLXF1aWVzY2VudCBkZXZpY2VzLgoKU2V0IHVwIHF1
YXJhbnRpbmUgcGFnZSB0YWJsZXMgYXMgbGF0ZSBhcyBwb3NzaWJsZSwgeWV0
IGVhcmx5IGVub3VnaCB0bwpub3QgZW5jb3VudGVyIGZhaWx1cmUgZHVyaW5n
IGRlLWFzc2lnbi4gVGhpcyBtZWFucyBzZXR1cCBnZW5lcmFsbHkKaGFwcGVu
cyBpbiBhc3NpZ25fZGV2aWNlKCksIHdoaWxlIChmb3Igbm93KSB0aGUgb25l
IGluIGRlYXNzaWduX2RldmljZSgpCmlzIHRoZXJlIG1haW5seSB0byBiZSBv
biB0aGUgc2FmZSBzaWRlLgoKSW4gVlQtZCdzIERJRCBhbGxvY2F0aW9uIGZ1
bmN0aW9uIGRvbid0IHJlcXVpcmUgdGhlIElPTU1VIGxvY2sgdG8gYmUKaGVs
ZCBhbnltb3JlOiBBbGwgaW52b2x2ZWQgY29kZSBwYXRocyBob2xkIHBjaWRl
dnNfbG9jaywgc28gdGhpcyB3YXkgd2UKYXZvaWQgdGhlIG5lZWQgdG8gYWNx
dWlyZSB0aGUgSU9NTVUgbG9jayBhcm91bmQgdGhlIG5ldyBjYWxsIHRvCmNv
bnRleHRfc2V0X2RvbWFpbl9pZCgpLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBE
dXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFu
IDxrZXZpbi50aWFuQGludGVsLmNvbT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBh
dSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKLS0tIGEveGVuL2Fy
Y2gveDg2L21tL3AybS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpA
QCAtMTQ1Myw3ICsxNDUzLDcgQEAgaW50IHNldF9pZGVudGl0eV9wMm1fZW50
cnkoc3RydWN0IGRvbWFpbgogICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0g
PSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJldDsKIAotICAgIGlm
ICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShwMm0tPmRvbWFpbikgKQorICAg
IGlmICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShkKSApCiAgICAgewogICAg
ICAgICBpZiAoICFpc19pb21tdV9lbmFibGVkKGQpICkKICAgICAgICAgICAg
IHJldHVybiAwOwotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oCisr
KyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgKQEAgLTEsNiArMSw4IEBA
CiAjaWZuZGVmIF9fWDg2X1BDSV9IX18KICNkZWZpbmUgX19YODZfUENJX0hf
XwogCisjaW5jbHVkZSA8eGVuL21tLmg+CisKICNkZWZpbmUgQ0Y4X0JERihj
ZjgpICAgICAoICAoKGNmOCkgJiAweDAwZmZmZjAwKSA+PiA4KQogI2RlZmlu
ZSBDRjhfQUREUl9MTyhjZjgpICggICAoY2Y4KSAmIDB4MDAwMDAwZmMpCiAj
ZGVmaW5lIENGOF9BRERSX0hJKGNmOCkgKCAgKChjZjgpICYgMHgwZjAwMDAw
MCkgPj4gMTYpCkBAIC0yMCw3ICsyMiwxOCBAQCBzdHJ1Y3QgYXJjaF9wY2lf
ZGV2IHsKICAgICAgKiB0aGVtIGRvbid0IHJhY2UgKGRlKWluaXRpYWxpemF0
aW9uIGFuZCBoZW5jZSBkb24ndCBzdHJpY3RseSBuZWVkIGFueQogICAgICAq
IGxvY2tpbmcuCiAgICAgICovCisgICAgdW5pb24geworICAgICAgICAvKiBT
dWJzZXQgb2Ygc3RydWN0IGFyY2hfaW9tbXUncyBmaWVsZHMsIHRvIGJlIHVz
ZWQgaW4gZG9tX2lvLiAqLworICAgICAgICBzdHJ1Y3QgeworICAgICAgICAg
ICAgdWludDY0X3QgcGdkX21hZGRyOworICAgICAgICB9IHZ0ZDsKKyAgICAg
ICAgc3RydWN0IHsKKyAgICAgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnJv
b3RfdGFibGU7CisgICAgICAgIH0gYW1kOworICAgIH07CiAgICAgZG9taWRf
dCBwc2V1ZG9fZG9taWQ7CisgICAgbWZuX3QgbGVhZl9tZm47CisgICAgc3Ry
dWN0IHBhZ2VfbGlzdF9oZWFkIHBndGFibGVzX2xpc3Q7CiB9OwogCiBpbnQg
cGNpX2NvbmZfd3JpdGVfaW50ZXJjZXB0KHVuc2lnbmVkIGludCBzZWcsIHVu
c2lnbmVkIGludCBiZGYsCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZt
L3N2bS9hbWQtaW9tbXUtcHJvdG8uaAorKysgYi94ZW4vaW5jbHVkZS9hc20t
eDg2L2h2bS9zdm0vYW1kLWlvbW11LXByb3RvLmgKQEAgLTU0LDcgKzU0LDgg
QEAgaW50IGFtZF9pb21tdV9pbml0X2xhdGUodm9pZCk7CiBpbnQgYW1kX2lv
bW11X3VwZGF0ZV9pdnJzX21hcHBpbmdfYWNwaSh2b2lkKTsKIGludCBpb3Zf
YWRqdXN0X2lycV9hZmZpbml0aWVzKHZvaWQpOwogCi1pbnQgYW1kX2lvbW11
X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3QgZG9tYWluICpkKTsKK2ludCBhbWRf
aW9tbXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBwY2lfZGV2ICpwZGV2KTsK
K3ZvaWQgYW1kX2lvbW11X3F1YXJhbnRpbmVfdGVhcmRvd24oc3RydWN0IHBj
aV9kZXYgKnBkZXYpOwogCiAvKiBtYXBwaW5nIGZ1bmN0aW9ucyAqLwogaW50
IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfbWFwX3BhZ2Uoc3RydWN0IGRvbWFp
biAqZCwgZGZuX3QgZGZuLAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvYW1kL2lvbW11X21hcC5jCkBAIC01MzksNjQgKzUzOSwxMzcgQEAgaW50
IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV91bm1hcAogICAgIHJl
dHVybiByYzsKIH0KIAotaW50IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGlu
ZV9pbml0KHN0cnVjdCBkb21haW4gKmQpCitzdGF0aWMgaW50IGZpbGxfcXB0
KHVuaW9uIGFtZF9pb21tdV9wdGUgKnRoaXMsIHVuc2lnbmVkIGludCBsZXZl
bCwKKyAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGdz
W0lPTU1VX01BWF9QVF9MRVZFTFNdLAorICAgICAgICAgICAgICAgICAgICBz
dHJ1Y3QgcGNpX2RldiAqcGRldikKIHsKLSAgICBzdHJ1Y3QgZG9tYWluX2lv
bW11ICpoZCA9IGRvbV9pb21tdShkKTsKKyAgICB1bnNpZ25lZCBpbnQgaTsK
KyAgICBpbnQgcmMgPSAwOworCisgICAgZm9yICggaSA9IDA7ICFyYyAmJiBp
IDwgUFRFX1BFUl9UQUJMRV9TSVpFOyArK2kgKQorICAgIHsKKyAgICAgICAg
dW5pb24gYW1kX2lvbW11X3B0ZSAqcHRlID0gJnRoaXNbaV0sICpuZXh0Owor
CisgICAgICAgIGlmICggIXB0ZS0+cHIgKQorICAgICAgICB7CisgICAgICAg
ICAgICBpZiAoICFwZ3NbbGV2ZWxdICkKKyAgICAgICAgICAgIHsKKyAgICAg
ICAgICAgICAgICAvKgorICAgICAgICAgICAgICAgICAqIFRoZSBwZ3RhYmxl
IGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUgbGVhZiBwYWdlLCBhcyB3ZWxs
IGFzCisgICAgICAgICAgICAgICAgICogcGFnZSB0YWJsZSBwYWdlcywgYW5k
IHRoZSByZXN1bHRpbmcgYWxsb2NhdGlvbnMgYXJlIGFsd2F5cworICAgICAg
ICAgICAgICAgICAqIHplcm9lZC4KKyAgICAgICAgICAgICAgICAgKi8KKyAg
ICAgICAgICAgICAgICBwZ3NbbGV2ZWxdID0gYWxsb2NfYW1kX2lvbW11X3Bn
dGFibGUoKTsKKyAgICAgICAgICAgICAgICBpZiAoICFwZ3NbbGV2ZWxdICkK
KyAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgIHJjID0g
LUVOT01FTTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAg
ICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgcGFnZV9saXN0X2FkZChw
Z3NbbGV2ZWxdLCAmcGRldi0+YXJjaC5wZ3RhYmxlc19saXN0KTsKKworICAg
ICAgICAgICAgICAgIGlmICggbGV2ZWwgKQorICAgICAgICAgICAgICAgIHsK
KyAgICAgICAgICAgICAgICAgICAgbmV4dCA9IF9fbWFwX2RvbWFpbl9wYWdl
KHBnc1tsZXZlbF0pOworICAgICAgICAgICAgICAgICAgICByYyA9IGZpbGxf
cXB0KG5leHQsIGxldmVsIC0gMSwgcGdzLCBwZGV2KTsKKyAgICAgICAgICAg
ICAgICAgICAgdW5tYXBfZG9tYWluX3BhZ2UobmV4dCk7CisgICAgICAgICAg
ICAgICAgfQorICAgICAgICAgICAgfQorCisgICAgICAgICAgICAvKgorICAg
ICAgICAgICAgICogUERFcyBhcmUgZXNzZW50aWFsbHkgYSBzdWJzZXQgb2Yg
UFRFcywgc28gdGhpcyBmdW5jdGlvbgorICAgICAgICAgICAgICogaXMgZmlu
ZSB0byB1c2UgZXZlbiBhdCB0aGUgbGVhZi4KKyAgICAgICAgICAgICAqLwor
ICAgICAgICAgICAgc2V0X2lvbW11X3BkZV9wcmVzZW50KHB0ZSwgbWZuX3go
cGFnZV90b19tZm4ocGdzW2xldmVsXSkpLCBsZXZlbCwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB0cnVlLCB0cnVlKTsKKyAgICAgICAg
fQorICAgICAgICBlbHNlIGlmICggbGV2ZWwgJiYgcHRlLT5uZXh0X2xldmVs
ICkKKyAgICAgICAgeworICAgICAgICAgICAgcGFnZV9saXN0X2FkZChtZm5f
dG9fcGFnZShfbWZuKHB0ZS0+bWZuKSksCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICZwZGV2LT5hcmNoLnBndGFibGVzX2xpc3QpOworICAgICAgICAg
ICAgbmV4dCA9IG1hcF9kb21haW5fcGFnZShfbWZuKHB0ZS0+bWZuKSk7Cisg
ICAgICAgICAgICByYyA9IGZpbGxfcXB0KG5leHQsIGxldmVsIC0gMSwgcGdz
LCBwZGV2KTsKKyAgICAgICAgICAgIHVubWFwX2RvbWFpbl9wYWdlKG5leHQp
OworICAgICAgICB9CisgICAgfQorCisgICAgcmV0dXJuIHJjOworfQorCitp
bnQgYW1kX2lvbW11X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3QgcGNpX2RldiAq
cGRldikKK3sKKyAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9p
b21tdShkb21faW8pOwogICAgIHVuc2lnbmVkIGxvbmcgZW5kX2dmbiA9CiAg
ICAgICAgIDF1bCA8PCAoREVGQVVMVF9ET01BSU5fQUREUkVTU19XSURUSCAt
IFBBR0VfU0hJRlQpOwogICAgIHVuc2lnbmVkIGludCBsZXZlbCA9IGFtZF9p
b21tdV9nZXRfcGFnaW5nX21vZGUoZW5kX2dmbik7Ci0gICAgdW5pb24gYW1k
X2lvbW11X3B0ZSAqdGFibGU7CisgICAgdW5zaWduZWQgaW50IHJlcV9pZCA9
IGdldF9kbWFfcmVxdWVzdG9yX2lkKHBkZXYtPnNlZywgcGRldi0+c2JkZi5i
ZGYpOworICAgIGNvbnN0IHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX21h
cHBpbmdzID0gZ2V0X2l2cnNfbWFwcGluZ3MocGRldi0+c2VnKTsKKyAgICBp
bnQgcmM7CiAKLSAgICBpZiAoIGhkLT5hcmNoLnJvb3RfdGFibGUgKQorICAg
IEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKKyAgICBBU1NFUlQoIWhkLT5h
cmNoLnJvb3RfdGFibGUpOworCisgICAgQVNTRVJUKHBkZXYtPmFyY2gucHNl
dWRvX2RvbWlkICE9IERPTUlEX0lOVkFMSUQpOworCisgICAgaWYgKCBwZGV2
LT5hcmNoLmFtZC5yb290X3RhYmxlICkKICAgICB7Ci0gICAgICAgIEFTU0VS
VF9VTlJFQUNIQUJMRSgpOworICAgICAgICBjbGVhcl9kb21haW5fcGFnZShw
ZGV2LT5hcmNoLmxlYWZfbWZuKTsKICAgICAgICAgcmV0dXJuIDA7CiAgICAg
fQogCi0gICAgc3Bpbl9sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwot
Ci0gICAgaGQtPmFyY2gucm9vdF90YWJsZSA9IGFsbG9jX2FtZF9pb21tdV9w
Z3RhYmxlKCk7Ci0gICAgaWYgKCAhaGQtPmFyY2gucm9vdF90YWJsZSApCi0g
ICAgICAgIGdvdG8gb3V0OwotCi0gICAgdGFibGUgPSBfX21hcF9kb21haW5f
cGFnZShoZC0+YXJjaC5yb290X3RhYmxlKTsKLSAgICB3aGlsZSAoIGxldmVs
ICkKKyAgICBwZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlID0gYWxsb2NfYW1k
X2lvbW11X3BndGFibGUoKTsKKyAgICBpZiAoICFwZGV2LT5hcmNoLmFtZC5y
b290X3RhYmxlICkKKyAgICAgICAgcmV0dXJuIC1FTk9NRU07CisKKyAgICAv
KiBUcmFuc2llbnRseSBpbnN0YWxsIHRoZSByb290IGludG8gRG9tSU8sIGZv
ciBpb21tdV9pZGVudGl0eV9tYXBwaW5nKCkuICovCisgICAgaGQtPmFyY2gu
cm9vdF90YWJsZSA9IHBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGU7CisKKyAg
ICByYyA9IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoZG9t
X2lvLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBpdnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwKTsKKwor
ICAgIGlvbW11X2lkZW50aXR5X21hcF90ZWFyZG93bihkb21faW8pOworICAg
IGhkLT5hcmNoLnJvb3RfdGFibGUgPSBOVUxMOworCisgICAgaWYgKCByYyAp
CisgICAgICAgIHByaW50aygiJTA0eDolMDJ4OiUwMnguJXU6IHF1YXJhbnRp
bmUgdW5pdHkgbWFwcGluZyBmYWlsZWRcbiIsCisgICAgICAgICAgICAgICBw
ZGV2LT5zZWcsIHBkZXYtPmJ1cywKKyAgICAgICAgICAgICAgIFBDSV9TTE9U
KHBkZXYtPmRldmZuKSwgUENJX0ZVTkMocGRldi0+ZGV2Zm4pKTsKKyAgICBl
bHNlCiAgICAgewotICAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKLSAg
ICAgICAgdW5zaWduZWQgaW50IGk7CisgICAgICAgIHVuaW9uIGFtZF9pb21t
dV9wdGUgKnJvb3Q7CisgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnc1tJ
T01NVV9NQVhfUFRfTEVWRUxTXSA9IHt9OwogCi0gICAgICAgIC8qCi0gICAg
ICAgICAqIFRoZSBwZ3RhYmxlIGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUg
bGVhZiBwYWdlLCBhcyB3ZWxsIGFzCi0gICAgICAgICAqIHBhZ2UgdGFibGUg
cGFnZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdh
eXMKLSAgICAgICAgICogemVyb2VkLgotICAgICAgICAgKi8KLSAgICAgICAg
cGcgPSBhbGxvY19hbWRfaW9tbXVfcGd0YWJsZSgpOwotICAgICAgICBpZiAo
ICFwZyApCi0gICAgICAgICAgICBicmVhazsKKyAgICAgICAgc3Bpbl9sb2Nr
KCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogCi0gICAgICAgIGZvciAoIGkg
PSAwOyBpIDwgUFRFX1BFUl9UQUJMRV9TSVpFOyBpKysgKQotICAgICAgICB7
Ci0gICAgICAgICAgICB1bmlvbiBhbWRfaW9tbXVfcHRlICpwZGUgPSAmdGFi
bGVbaV07CisgICAgICAgIHJvb3QgPSBfX21hcF9kb21haW5fcGFnZShwZGV2
LT5hcmNoLmFtZC5yb290X3RhYmxlKTsKKyAgICAgICAgcmMgPSBmaWxsX3Fw
dChyb290LCBsZXZlbCAtIDEsIHBncywgcGRldik7CisgICAgICAgIHVubWFw
X2RvbWFpbl9wYWdlKHJvb3QpOwogCi0gICAgICAgICAgICAvKgotICAgICAg
ICAgICAgICogUERFcyBhcmUgZXNzZW50aWFsbHkgYSBzdWJzZXQgb2YgUFRF
cywgc28gdGhpcyBmdW5jdGlvbgotICAgICAgICAgICAgICogaXMgZmluZSB0
byB1c2UgZXZlbiBhdCB0aGUgbGVhZi4KLSAgICAgICAgICAgICAqLwotICAg
ICAgICAgICAgc2V0X2lvbW11X3BkZV9wcmVzZW50KHBkZSwgbWZuX3gocGFn
ZV90b19tZm4ocGcpKSwgbGV2ZWwgLSAxLAotICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGZhbHNlLCB0cnVlKTsKLSAgICAgICAgfQorICAg
ICAgICBwZGV2LT5hcmNoLmxlYWZfbWZuID0gcGFnZV90b19tZm4ocGdzWzBd
KTsKIAotICAgICAgICB1bm1hcF9kb21haW5fcGFnZSh0YWJsZSk7Ci0gICAg
ICAgIHRhYmxlID0gX19tYXBfZG9tYWluX3BhZ2UocGcpOwotICAgICAgICBs
ZXZlbC0tOworICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGlu
Z19sb2NrKTsKICAgICB9Ci0gICAgdW5tYXBfZG9tYWluX3BhZ2UodGFibGUp
OwogCi0gb3V0OgotICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5n
X2xvY2spOworICAgIGlmICggcmMgKQorICAgICAgICBhbWRfaW9tbXVfcXVh
cmFudGluZV90ZWFyZG93bihwZGV2KTsKKworICAgIHJldHVybiByYzsKK30K
Kwordm9pZCBhbWRfaW9tbXVfcXVhcmFudGluZV90ZWFyZG93bihzdHJ1Y3Qg
cGNpX2RldiAqcGRldikKK3sKKyAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsK
KworICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKKworICAgIGlmICgg
IXBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGUgKQorICAgICAgICByZXR1cm47
CisKKyAgICB3aGlsZSAoIChwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgm
cGRldi0+YXJjaC5wZ3RhYmxlc19saXN0KSkgKQorICAgICAgICBmcmVlX2Ft
ZF9pb21tdV9wZ3RhYmxlKHBnKTsKIAotICAgIC8qIFBhZ2VzIGxlYWtlZCBp
biBmYWlsdXJlIGNhc2UgKi8KLSAgICByZXR1cm4gbGV2ZWwgPyAtRU5PTUVN
IDogMDsKKyAgICBwZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlID0gTlVMTDsK
IH0KIAogLyoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3Bj
aV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9h
bWQvcGNpX2FtZF9pb21tdS5jCkBAIC0xMjUsNiArMTI1LDggQEAgc3RhdGlj
IGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwogICAgIHU4IGJ1
cyA9IHBkZXYtPmJ1czsKICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9
IGRvbV9pb21tdShkb21haW4pOwogICAgIGNvbnN0IHN0cnVjdCBpdnJzX21h
cHBpbmdzICppdnJzX2RldjsKKyAgICBjb25zdCBzdHJ1Y3QgcGFnZV9pbmZv
ICpyb290X3BnOworICAgIGRvbWlkX3QgZG9taWQ7CiAKICAgICBCVUdfT04o
IWhkLT5hcmNoLnBhZ2luZ19tb2RlIHx8ICFpb21tdS0+ZGV2X3RhYmxlLmJ1
ZmZlcik7CiAKQEAgLTE0NCwxNCArMTQ2LDI1IEBAIHN0YXRpYyBpbnQgX19t
dXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICBkdGUgPSAmdGFibGVb
cmVxX2lkXTsKICAgICBpdnJzX2RldiA9ICZnZXRfaXZyc19tYXBwaW5ncyhp
b21tdS0+c2VnKVtyZXFfaWRdOwogCisgICAgaWYgKCBkb21haW4gIT0gZG9t
X2lvICkKKyAgICB7CisgICAgICAgIHJvb3RfcGcgPSBoZC0+YXJjaC5yb290
X3RhYmxlOworICAgICAgICBkb21pZCA9IGRvbWFpbi0+ZG9tYWluX2lkOwor
ICAgIH0KKyAgICBlbHNlCisgICAgeworICAgICAgICByb290X3BnID0gcGRl
di0+YXJjaC5hbWQucm9vdF90YWJsZTsKKyAgICAgICAgZG9taWQgPSBwZGV2
LT5hcmNoLnBzZXVkb19kb21pZDsKKyAgICB9CisKICAgICBzcGluX2xvY2tf
aXJxc2F2ZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKIAogICAgIGlmICggIWR0
ZS0+diB8fCAhZHRlLT50diApCiAgICAgewogICAgICAgICAvKiBiaW5kIERU
RSB0byBkb21haW4gcGFnZS10YWJsZXMgKi8KICAgICAgICAgcmMgPSBhbWRf
aW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZSgKLSAgICAgICAgICAgICAgICAg
ZHRlLCBwYWdlX3RvX21hZGRyKGhkLT5hcmNoLnJvb3RfdGFibGUpLAotICAg
ICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2gucGFn
aW5nX21vZGUsIHNyX2ZsYWdzKTsKKyAgICAgICAgICAgICAgICAgZHRlLCBw
YWdlX3RvX21hZGRyKHJvb3RfcGcpLCBkb21pZCwKKyAgICAgICAgICAgICAg
ICAgaGQtPmFyY2gucGFnaW5nX21vZGUsIHNyX2ZsYWdzKTsKICAgICAgICAg
aWYgKCByYyApCiAgICAgICAgIHsKICAgICAgICAgICAgIEFTU0VSVChyYyA8
IDApOwpAQCAtMTc1LDcgKzE4OCw3IEBAIHN0YXRpYyBpbnQgX19tdXN0X2No
ZWNrIGFtZF9pb21tdV9zZXR1cF8KIAogICAgICAgICBhbWRfaW9tbXVfZmx1
c2hfZGV2aWNlKGlvbW11LCByZXFfaWQpOwogICAgIH0KLSAgICBlbHNlIGlm
ICggZHRlLT5wdF9yb290ICE9IG1mbl94KHBhZ2VfdG9fbWZuKGhkLT5hcmNo
LnJvb3RfdGFibGUpKSApCisgICAgZWxzZSBpZiAoIGR0ZS0+cHRfcm9vdCAh
PSBtZm5feChwYWdlX3RvX21mbihyb290X3BnKSkgKQogICAgIHsKICAgICAg
ICAgLyoKICAgICAgICAgICogU3RyaWN0bHkgc3BlYWtpbmcgaWYgdGhlIGRl
dmljZSBpcyB0aGUgb25seSBvbmUgd2l0aCB0aGlzIHJlcXVlc3RvcgpAQCAt
MTg4LDggKzIwMSw4IEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFtZF9p
b21tdV9zZXR1cF8KICAgICAgICAgICAgIHJjID0gLUVPUE5PVFNVUFA7CiAg
ICAgICAgIGVsc2UKICAgICAgICAgICAgIHJjID0gYW1kX2lvbW11X3NldF9y
b290X3BhZ2VfdGFibGUoCi0gICAgICAgICAgICAgICAgICAgICBkdGUsIHBh
Z2VfdG9fbWFkZHIoaGQtPmFyY2gucm9vdF90YWJsZSksCi0gICAgICAgICAg
ICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2gucGFnaW5n
X21vZGUsIHNyX2ZsYWdzKTsKKyAgICAgICAgICAgICAgICAgICAgIGR0ZSwg
cGFnZV90b19tYWRkcihyb290X3BnKSwgZG9taWQsCisgICAgICAgICAgICAg
ICAgICAgICBoZC0+YXJjaC5wYWdpbmdfbW9kZSwgc3JfZmxhZ3MpOwogICAg
ICAgICBpZiAoIHJjIDwgMCApCiAgICAgICAgIHsKICAgICAgICAgICAgIHNw
aW5fdW5sb2NrX2lycXJlc3RvcmUoJmlvbW11LT5sb2NrLCBmbGFncyk7CkBA
IC0yMDgsNiArMjIxLDcgQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgYW1k
X2lvbW11X3NldHVwXwogICAgICAgICAgICAgICAqIGludGVuZGVkIGFueXdh
eS4KICAgICAgICAgICAgICAgKi8KICAgICAgICAgICAgICAhcGRldi0+ZG9t
YWluLT5pc19keWluZyAmJgorICAgICAgICAgICAgIHBkZXYtPmRvbWFpbiAh
PSBkb21faW8gJiYKICAgICAgICAgICAgICAoYW55X3BkZXZfYmVoaW5kX2lv
bW11KHBkZXYtPmRvbWFpbiwgcGRldiwgaW9tbXUpIHx8CiAgICAgICAgICAg
ICAgIHBkZXYtPnBoYW50b21fc3RyaWRlKSApCiAgICAgICAgICAgICBwcmlu
dGsoIiAlMDR4OiUwMng6JTAyeC4ldTogcmVhc3NpZ25tZW50IG1heSBjYXVz
ZSAlcGQgZGF0YSBjb3JydXB0aW9uXG4iLApAQCAtMjM4LDkgKzI1Miw4IEBA
IHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAg
ICBBTURfSU9NTVVfREVCVUcoIlNldHVwIEkvTyBwYWdlIHRhYmxlOiBkZXZp
Y2UgaWQgPSAlI3gsIHR5cGUgPSAlI3gsICIKICAgICAgICAgICAgICAgICAg
ICAgInJvb3QgdGFibGUgPSAlIyJQUkl4NjQiLCAiCiAgICAgICAgICAgICAg
ICAgICAgICJkb21haW4gPSAlZCwgcGFnaW5nIG1vZGUgPSAlZFxuIiwKLSAg
ICAgICAgICAgICAgICAgICAgcmVxX2lkLCBwZGV2LT50eXBlLAotICAgICAg
ICAgICAgICAgICAgICBwYWdlX3RvX21hZGRyKGhkLT5hcmNoLnJvb3RfdGFi
bGUpLAotICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwg
aGQtPmFyY2gucGFnaW5nX21vZGUpOworICAgICAgICAgICAgICAgICAgICBy
ZXFfaWQsIHBkZXYtPnR5cGUsIHBhZ2VfdG9fbWFkZHIocm9vdF9wZyksCisg
ICAgICAgICAgICAgICAgICAgIGRvbWlkLCBoZC0+YXJjaC5wYWdpbmdfbW9k
ZSk7CiAKICAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CiAKQEAgLTMx
Myw3ICszMjYsNyBAQCBzdGF0aWMgaW50IGlvdl9lbmFibGVfeHQodm9pZCkK
IAogaW50IGFtZF9pb21tdV9hbGxvY19yb290KHN0cnVjdCBkb21haW5faW9t
bXUgKmhkKQogewotICAgIGlmICggdW5saWtlbHkoIWhkLT5hcmNoLnJvb3Rf
dGFibGUpICkKKyAgICBpZiAoIHVubGlrZWx5KCFoZC0+YXJjaC5yb290X3Rh
YmxlKSAmJiBoZCAhPSBkb21faW9tbXUoZG9tX2lvKSApCiAgICAgewogICAg
ICAgICBoZC0+YXJjaC5yb290X3RhYmxlID0gYWxsb2NfYW1kX2lvbW11X3Bn
dGFibGUoKTsKICAgICAgICAgaWYgKCAhaGQtPmFyY2gucm9vdF90YWJsZSAp
CkBAIC00MDQsNyArNDE3LDcgQEAgc3RhdGljIHZvaWQgYW1kX2lvbW11X2Rp
c2FibGVfZG9tYWluX2RldgogCiAgICAgICAgIEFNRF9JT01NVV9ERUJVRygi
RGlzYWJsZTogZGV2aWNlIGlkID0gJSN4LCAiCiAgICAgICAgICAgICAgICAg
ICAgICAgICAiZG9tYWluID0gJWQsIHBhZ2luZyBtb2RlID0gJWRcbiIsCi0g
ICAgICAgICAgICAgICAgICAgICAgICByZXFfaWQsICBkb21haW4tPmRvbWFp
bl9pZCwKKyAgICAgICAgICAgICAgICAgICAgICAgIHJlcV9pZCwgZHRlLT5k
b21haW5faWQsCiAgICAgICAgICAgICAgICAgICAgICAgICBkb21faW9tbXUo
ZG9tYWluKS0+YXJjaC5wYWdpbmdfbW9kZSk7CiAgICAgfQogICAgIHNwaW5f
dW5sb2NrX2lycXJlc3RvcmUoJmlvbW11LT5sb2NrLCBmbGFncyk7CkBAIC02
NjgsNiArNjgxLDggQEAgc3RhdGljIGludCBhbWRfaW9tbXVfcmVtb3ZlX2Rl
dmljZSh1OCBkZQogCiAgICAgYW1kX2lvbW11X2Rpc2FibGVfZG9tYWluX2Rl
dmljZShwZGV2LT5kb21haW4sIGlvbW11LCBkZXZmbiwgcGRldik7CiAKKyAg
ICBhbWRfaW9tbXVfcXVhcmFudGluZV90ZWFyZG93bihwZGV2KTsKKwogICAg
IGlvbW11X2ZyZWVfZG9taWQocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsIGlv
bW11LT5kb21pZF9tYXApOwogICAgIHBkZXYtPmFyY2gucHNldWRvX2RvbWlk
ID0gRE9NSURfSU5WQUxJRDsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lv
bW11LmMKQEAgLTQ1MCwyMSArNDUwLDIxIEBAIGludCBpb21tdV9pb3RsYl9m
bHVzaF9hbGwoc3RydWN0IGRvbWFpbgogICAgIHJldHVybiByYzsKIH0KIAot
c3RhdGljIGludCBfX2luaXQgaW9tbXVfcXVhcmFudGluZV9pbml0KHZvaWQp
CitpbnQgaW9tbXVfcXVhcmFudGluZV9kZXZfaW5pdChkZXZpY2VfdCAqZGV2
KQogewogICAgIGNvbnN0IHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9t
X2lvbW11KGRvbV9pbyk7Ci0gICAgaW50IHJjOwogCi0gICAgZG9tX2lvLT5v
cHRpb25zIHw9IFhFTl9ET01DVExfQ0RGX2lvbW11OworICAgIGlmICggIWlv
bW11X3F1YXJhbnRpbmUgfHwgIWhkLT5wbGF0Zm9ybV9vcHMtPnF1YXJhbnRp
bmVfaW5pdCApCisgICAgICAgIHJldHVybiAwOwogCi0gICAgcmMgPSBpb21t
dV9kb21haW5faW5pdChkb21faW8sIDApOwotICAgIGlmICggcmMgKQotICAg
ICAgICByZXR1cm4gcmM7CisgICAgcmV0dXJuIGlvbW11X2NhbGwoaGQtPnBs
YXRmb3JtX29wcywgcXVhcmFudGluZV9pbml0LCBkZXYpOworfQogCi0gICAg
aWYgKCAhaGQtPnBsYXRmb3JtX29wcy0+cXVhcmFudGluZV9pbml0ICkKLSAg
ICAgICAgcmV0dXJuIDA7CitzdGF0aWMgaW50IF9faW5pdCBpb21tdV9xdWFy
YW50aW5lX2luaXQodm9pZCkKK3sKKyAgICBkb21faW8tPm9wdGlvbnMgfD0g
WEVOX0RPTUNUTF9DREZfaW9tbXU7CiAKLSAgICByZXR1cm4gaGQtPnBsYXRm
b3JtX29wcy0+cXVhcmFudGluZV9pbml0KGRvbV9pbyk7CisgICAgcmV0dXJu
IGlvbW11X2RvbWFpbl9pbml0KGRvbV9pbywgMCk7CiB9CiAKIGludCBfX2lu
aXQgaW9tbXVfc2V0dXAodm9pZCkKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvcGNpLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNp
LmMKQEAgLTkyOSw5ICs5MjksMTYgQEAgc3RhdGljIGludCBkZWFzc2lnbl9k
ZXZpY2Uoc3RydWN0IGRvbWFpbgogICAgICAgICByZXR1cm4gLUVOT0RFVjsK
IAogICAgIC8qIERlLWFzc2lnbm1lbnQgZnJvbSBkb21faW8gc2hvdWxkIGRl
LXF1YXJhbnRpbmUgdGhlIGRldmljZSAqLwotICAgIHRhcmdldCA9ICgocGRl
di0+cXVhcmFudGluZSB8fCBpb21tdV9xdWFyYW50aW5lKSAmJgotICAgICAg
ICAgICAgICBwZGV2LT5kb21haW4gIT0gZG9tX2lvKSA/Ci0gICAgICAgIGRv
bV9pbyA6IGhhcmR3YXJlX2RvbWFpbjsKKyAgICBpZiAoIChwZGV2LT5xdWFy
YW50aW5lIHx8IGlvbW11X3F1YXJhbnRpbmUpICYmIHBkZXYtPmRvbWFpbiAh
PSBkb21faW8gKQorICAgIHsKKyAgICAgICAgcmV0ID0gaW9tbXVfcXVhcmFu
dGluZV9kZXZfaW5pdChwY2lfdG9fZGV2KHBkZXYpKTsKKyAgICAgICAgaWYg
KCByZXQgKQorICAgICAgICAgICByZXR1cm4gcmV0OworCisgICAgICAgIHRh
cmdldCA9IGRvbV9pbzsKKyAgICB9CisgICAgZWxzZQorICAgICAgICB0YXJn
ZXQgPSBoYXJkd2FyZV9kb21haW47CiAKICAgICB3aGlsZSAoIHBkZXYtPnBo
YW50b21fc3RyaWRlICkKICAgICB7CkBAIC0xNTQ3LDYgKzE1NTQsMTMgQEAg
c3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKgogICAg
ICAgICBtc2l4dGJsX2luaXQoZCk7CiAgICAgfQogCisgICAgaWYgKCBwZGV2
LT5kb21haW4gIT0gZG9tX2lvICkKKyAgICB7CisgICAgICAgIHJjID0gaW9t
bXVfcXVhcmFudGluZV9kZXZfaW5pdChwY2lfdG9fZGV2KHBkZXYpKTsKKyAg
ICAgICAgaWYgKCByYyApCisgICAgICAgICAgICBnb3RvIGRvbmU7CisgICAg
fQorCiAgICAgcGRldi0+ZmF1bHQuY291bnQgPSAwOwogCiAgICAgaWYgKCAo
cmMgPSBoZC0+cGxhdGZvcm1fb3BzLT5hc3NpZ25fZGV2aWNlKGQsIGRldmZu
LCBwY2lfdG9fZGV2KHBkZXYpLCBmbGFnKSkgKQotLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC92dGQvaW9tbXUuYwpAQCAtNDMsNiArNDMsMTIgQEAKICNp
bmNsdWRlICJ2dGQuaCIKICNpbmNsdWRlICIuLi9hdHMuaCIKIAorI2RlZmlu
ZSBERVZJQ0VfRE9NSUQoZCwgcGRldikgKChkKSAhPSBkb21faW8gPyAoZCkt
PmRvbWFpbl9pZCBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICA6IChwZGV2KS0+YXJjaC5wc2V1ZG9fZG9taWQpCisj
ZGVmaW5lIERFVklDRV9QR1RBQkxFKGQsIHBkZXYpICgoZCkgIT0gZG9tX2lv
IFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgID8gZG9tX2lv
bW11KGQpLT5hcmNoLnBnZF9tYWRkciBcCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICA6IChwZGV2KS0+YXJjaC52dGQucGdkX21hZGRyKQor
CiAvKiBQb3NzaWJsZSB1bmZpbHRlcmVkIExBUElDL01TSSBtZXNzYWdlcyBm
cm9tIHVudHJ1c3RlZCBzb3VyY2VzPyAqLwogYm9vbCBfX3JlYWRfbW9zdGx5
IHVudHJ1c3RlZF9tc2k7CiAKQEAgLTc4LDEzICs4NCwxOCBAQCBzdGF0aWMg
aW50IGdldF9pb21tdV9kaWQoZG9taWRfdCBkb21pZCwKIAogI2RlZmluZSBE
SURfRklFTERfV0lEVEggMTYKICNkZWZpbmUgRElEX0hJR0hfT0ZGU0VUIDgK
KworLyoKKyAqIFRoaXMgZnVuY3Rpb24gbWF5IGhhdmUgImNvbnRleHQiIHBh
c3NlZCBhcyBOVUxMLCB0byBtZXJlbHkgb2J0YWluIGEgRElECisgKiBmb3Ig
ImRvbWlkIi4KKyAqLwogc3RhdGljIGludCBjb250ZXh0X3NldF9kb21haW5f
aWQoc3RydWN0IGNvbnRleHRfZW50cnkgKmNvbnRleHQsCiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBkb21pZF90IGRvbWlkLCBzdHJ1Y3Qg
dnRkX2lvbW11ICppb21tdSkKIHsKICAgICB1bnNpZ25lZCBsb25nIG5yX2Rv
bSwgaTsKICAgICBpbnQgZm91bmQgPSAwOwogCi0gICAgQVNTRVJUKHNwaW5f
aXNfbG9ja2VkKCZpb21tdS0+bG9jaykpOworICAgIEFTU0VSVChwY2lkZXZz
X2xvY2tlZCgpKTsKIAogICAgIG5yX2RvbSA9IGNhcF9uZG9tcyhpb21tdS0+
Y2FwKTsKICAgICBpID0gZmluZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2Jp
dG1hcCwgbnJfZG9tKTsKQEAgLTExMCw4ICsxMjEsMTMgQEAgc3RhdGljIGlu
dCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0CiAgICAgfQogCiAgICAg
c2V0X2JpdChpLCBpb21tdS0+ZG9taWRfYml0bWFwKTsKLSAgICBjb250ZXh0
LT5oaSAmPSB+KCgoMSA8PCBESURfRklFTERfV0lEVEgpIC0gMSkgPDwgRElE
X0hJR0hfT0ZGU0VUKTsKLSAgICBjb250ZXh0LT5oaSB8PSAoaSAmICgoMSA8
PCBESURfRklFTERfV0lEVEgpIC0gMSkpIDw8IERJRF9ISUdIX09GRlNFVDsK
KworICAgIGlmICggY29udGV4dCApCisgICAgeworICAgICAgICBjb250ZXh0
LT5oaSAmPSB+KCgoMSA8PCBESURfRklFTERfV0lEVEgpIC0gMSkgPDwgRElE
X0hJR0hfT0ZGU0VUKTsKKyAgICAgICAgY29udGV4dC0+aGkgfD0gKGkgJiAo
KDEgPDwgRElEX0ZJRUxEX1dJRFRIKSAtIDEpKSA8PCBESURfSElHSF9PRkZT
RVQ7CisgICAgfQorCiAgICAgcmV0dXJuIDA7CiB9CiAKQEAgLTE2MSw4ICsx
NzcsMTIgQEAgc3RhdGljIHZvaWQgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAo
c3RydQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u
c3Qgc3RydWN0IHBjaV9kZXYgKmV4Y2x1ZGUsCiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkK
IHsKLSAgICBib29sIGZvdW5kID0gYW55X3BkZXZfYmVoaW5kX2lvbW11KGQs
IGV4Y2x1ZGUsIGlvbW11KTsKKyAgICBib29sIGZvdW5kOworCisgICAgaWYg
KCBkID09IGRvbV9pbyApCisgICAgICAgIHJldHVybjsKIAorICAgIGZvdW5k
ID0gYW55X3BkZXZfYmVoaW5kX2lvbW11KGQsIGV4Y2x1ZGUsIGlvbW11KTsK
ICAgICAvKgogICAgICAqIEhpZGRlbiBkZXZpY2VzIGFyZSBhc3NvY2lhdGVk
IHdpdGggRG9tWEVOIGJ1dCB1c2FibGUgYnkgdGhlIGhhcmR3YXJlCiAgICAg
ICogZG9tYWluLiBIZW5jZSB0aGV5IG5lZWQgY29uc2lkZXJpbmcgaGVyZSBh
cyB3ZWxsLgpAQCAtMTQwMCw3ICsxNDIwLDcgQEAgaW50IGRvbWFpbl9jb250
ZXh0X21hcHBpbmdfb25lKAogICAgICAgICBkb21pZCA9IGlvbW11LT5kb21p
ZF9tYXBbcHJldl9kaWRdOwogICAgICAgICBpZiAoIGRvbWlkIDwgRE9NSURf
RklSU1RfUkVTRVJWRUQgKQogICAgICAgICAgICAgcHJldl9kb20gPSByY3Vf
bG9ja19kb21haW5fYnlfaWQoZG9taWQpOwotICAgICAgICBlbHNlIGlmICgg
ZG9taWQgPT0gRE9NSURfSU8gKQorICAgICAgICBlbHNlIGlmICggcGRldiA/
IGRvbWlkID09IHBkZXYtPmFyY2gucHNldWRvX2RvbWlkIDogZG9taWQgPiBE
T01JRF9NQVNLICkKICAgICAgICAgICAgIHByZXZfZG9tID0gcmN1X2xvY2tf
ZG9tYWluKGRvbV9pbyk7CiAgICAgICAgIGlmICggIXByZXZfZG9tICkKICAg
ICAgICAgewpAQCAtMTU3NywxNSArMTU5NywxMiBAQCBpbnQgZG9tYWluX2Nv
bnRleHRfbWFwcGluZ19vbmUoCiAgICAgewogICAgICAgICBpZiAoICFwcmV2
X2RvbSApCiAgICAgICAgICAgICBkb21haW5fY29udGV4dF91bm1hcF9vbmUo
ZG9tYWluLCBpb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7CisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlE
KGRvbWFpbiwgcGRldikpOwogICAgICAgICBlbHNlIGlmICggcHJldl9kb20g
IT0gZG9tYWluICkgLyogQXZvaWQgaW5maW5pdGUgcmVjdXJzaW9uLiAqLwot
ICAgICAgICB7Ci0gICAgICAgICAgICBoZCA9IGRvbV9pb21tdShwcmV2X2Rv
bSk7CiAgICAgICAgICAgICBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShw
cmV2X2RvbSwgaW9tbXUsIGJ1cywgZGV2Zm4sIHBkZXYsCi0gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9p
ZCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhk
LT5hcmNoLnBnZF9tYWRkciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIERFVklDRV9ET01JRChwcmV2X2RvbSwgcGRldiksCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBERVZJQ0Vf
UEdUQUJMRShwcmV2X2RvbSwgcGRldiksCiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBtb2RlICYgTUFQX1dJVEhfUk1SUik7Ci0g
ICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoIHByZXZfZG9tICkKQEAgLTE2
MDIsNyArMTYxOSw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFw
cGluZyhzdHJ1Y3QKIHsKICAgICBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRy
aGQ7CiAgICAgY29uc3Qgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwot
ICAgIHBhZGRyX3QgcGdkX21hZGRyID0gZG9tX2lvbW11KGRvbWFpbiktPmFy
Y2gucGdkX21hZGRyOworICAgIHBhZGRyX3QgcGdkX21hZGRyID0gREVWSUNF
X1BHVEFCTEUoZG9tYWluLCBwZGV2KTsKICAgICBkb21pZF90IG9yaWdfZG9t
aWQgPSBwZGV2LT5hcmNoLnBzZXVkb19kb21pZDsKICAgICBpbnQgcmV0ID0g
MDsKICAgICB1bnNpZ25lZCBpbnQgaSwgbW9kZSA9IDA7CkBAIC0xNjM1LDcg
KzE2NTIsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmco
c3RydWN0CiAgICAgICAgIGJyZWFrOwogICAgIH0KIAotICAgIGlmICggZG9t
YWluICE9IHBkZXYtPmRvbWFpbiApCisgICAgaWYgKCBkb21haW4gIT0gcGRl
di0+ZG9tYWluICYmIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gKQogICAgIHsK
ICAgICAgICAgaWYgKCBwZGV2LT5kb21haW4tPmlzX2R5aW5nICkKICAgICAg
ICAgICAgIG1vZGUgfD0gTUFQX09XTkVSX0RZSU5HOwpAQCAtMTY3Niw4ICsx
NjkzLDggQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0
cnVjdAogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiZCVkOlBDSWU6
IG1hcCAlMDR4OiUwMng6JTAyeC4ldVxuIiwKICAgICAgICAgICAgICAgICAg
ICBkb21haW4tPmRvbWFpbl9pZCwgc2VnLCBidXMsCiAgICAgICAgICAgICAg
ICAgICAgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikpOwotICAg
ICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4s
IGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBkb21haW4tPmRvbWFpbl9p
ZCwgcGdkX21hZGRyLAorICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9t
YXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZuLCBw
ZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSwgcGdkX21hZGRyLAogICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtb2RlKTsK
ICAgICAgICAgaWYgKCByZXQgPiAwICkKICAgICAgICAgICAgIHJldCA9IDA7
CkBAIC0xNzAxLDggKzE3MTgsOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250
ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAgICAgICAgICAgUENJX1NM
T1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikpOwogCiAgICAgICAgIHJldCA9
IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9t
bXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHBkZXYsIGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2RfbWFk
ZHIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IG1vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBwZGV2LCBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGdkX21hZGRy
LCBtb2RlKTsKICAgICAgICAgaWYgKCByZXQgPCAwICkKICAgICAgICAgICAg
IGJyZWFrOwogICAgICAgICBwcmV2X3ByZXNlbnQgPSByZXQ7CkBAIC0xNzMw
LDggKzE3NDcsOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBp
bmcoc3RydWN0CiAgICAgICAgICAqLwogICAgICAgICBpZiAoIHJldCA+PSAw
ICkKICAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdf
b25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBk
b21haW4tPmRvbWFpbl9pZCwgcGdkX21hZGRyLAotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbW9kZSk7CisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBE
RVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBnZF9tYWRkciwgbW9kZSk7
CiAKICAgICAgICAgLyoKICAgICAgICAgICogRGV2aWNlcyBiZWhpbmQgUENJ
ZS10by1QQ0kvUENJeCBicmlkZ2UgbWF5IGdlbmVyYXRlIGRpZmZlcmVudApA
QCAtMTc0Niw4ICsxNzYzLDggQEAgc3RhdGljIGludCBkb21haW5fY29udGV4
dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICBpZiAoICFyZXQgJiYgcGRldl90
eXBlKHNlZywgYnVzLCBkZXZmbikgPT0gREVWX1RZUEVfUENJZTJQQ0lfQlJJ
REdFICYmCiAgICAgICAgICAgICAgKHNlY2J1cyAhPSBwZGV2LT5idXMgfHwg
cGRldi0+ZGV2Zm4gIT0gMCkgKQogICAgICAgICAgICAgcmV0ID0gZG9tYWlu
X2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgc2Vj
YnVzLCAwLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgTlVMTCwgZG9tYWluLT5kb21haW5faWQsIHBnZF9tYWRkciwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IG1vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgTlVMTCwgREVWSUNFX0RPTUlEKGRvbWFpbiwgcGRldiksCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw
Z2RfbWFkZHIsIG1vZGUpOwogCiAgICAgICAgIGlmICggcmV0ICkKICAgICAg
ICAgewpAQCAtMTg5Niw3ICsxOTEzLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVj
dCBhY3BpX2RyaGRfdW5pdCAqZG9tYQogICAgICAgICAgICAgICAgICAgIGRv
bWFpbi0+ZG9tYWluX2lkLCBzZWcsIGJ1cywKICAgICAgICAgICAgICAgICAg
ICBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7CiAgICAgICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11
LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlEKGRvbWFpbiwg
cGRldikpOwogICAgICAgICBpZiAoICFyZXQgJiYgZGV2Zm4gPT0gcGRldi0+
ZGV2Zm4gJiYgYXRzX2RldmljZShwZGV2LCBkcmhkKSA+IDAgKQogICAgICAg
ICAgICAgZGlzYWJsZV9hdHNfZGV2aWNlKHBkZXYpOwogCkBAIC0xOTA3LDcg
KzE5MjQsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0
ICpkb21hCiAgICAgICAgICAgICBwcmludGsoVlREUFJFRklYICJkJWQ6UENJ
OiB1bm1hcCAlMDR4OiUwMng6JTAyeC4ldVxuIiwKICAgICAgICAgICAgICAg
ICAgICBkb21haW4tPmRvbWFpbl9pZCwgc2VnLCBidXMsIFBDSV9TTE9UKGRl
dmZuKSwgUENJX0ZVTkMoZGV2Zm4pKTsKICAgICAgICAgcmV0ID0gZG9tYWlu
X2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4s
Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21h
aW4tPmRvbWFpbl9pZCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7CiAgICAg
ICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIGJyZWFrOwogCkBAIC0xOTMw
LDE4ICsxOTQ3LDEyIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhk
X3VuaXQgKmRvbWEKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAK
KyAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFp
biwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIERFVklDRV9ET01JRChkb21haW4s
IHBkZXYpKTsKICAgICAgICAgLyogUENJZSB0byBQQ0kvUENJeCBicmlkZ2Ug
Ki8KLSAgICAgICAgaWYgKCBwZGV2X3R5cGUoc2VnLCB0bXBfYnVzLCB0bXBf
ZGV2Zm4pID09IERFVl9UWVBFX1BDSWUyUENJX0JSSURHRSApCi0gICAgICAg
IHsKLSAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29u
ZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4sCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5k
b21haW5faWQpOwotICAgICAgICAgICAgaWYgKCAhcmV0ICkKLSAgICAgICAg
ICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWlu
LCBpb21tdSwgc2VjYnVzLCAwLAotICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7Ci0g
ICAgICAgIH0KLSAgICAgICAgZWxzZSAvKiBMZWdhY3kgUENJIGJyaWRnZSAq
LwotICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KGRvbWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKLSAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRv
bWFpbl9pZCk7CisgICAgICAgIGlmICggIXJldCAmJiBwZGV2X3R5cGUoc2Vn
LCB0bXBfYnVzLCB0bXBfZGV2Zm4pID09IERFVl9UWVBFX1BDSWUyUENJX0JS
SURHRSApCisgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1h
cF9vbmUoZG9tYWluLCBpb21tdSwgc2VjYnVzLCAwLAorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERFVklDRV9ET01JRChk
b21haW4sIHBkZXYpKTsKIAogICAgICAgICBicmVhazsKIApAQCAtMTk4Nyw2
ICsxOTk4LDI1IEBAIHN0YXRpYyB2b2lkIGlvbW11X2RvbWFpbl90ZWFyZG93
bihzdHJ1Y3QKICAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZC0+ZG9tYWlu
X2lkLCBkcmhkLT5pb21tdSk7CiB9CiAKK3N0YXRpYyB2b2lkIHF1YXJhbnRp
bmVfdGVhcmRvd24oc3RydWN0IHBjaV9kZXYgKnBkZXYsCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRf
dW5pdCAqZHJoZCkKK3sKKyAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKKwor
ICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKKworICAgIGlmICggIXBk
ZXYtPmFyY2gudnRkLnBnZF9tYWRkciApCisgICAgICAgIHJldHVybjsKKwor
ICAgIHdoaWxlICggKHBnID0gcGFnZV9saXN0X3JlbW92ZV9oZWFkKCZwZGV2
LT5hcmNoLnBndGFibGVzX2xpc3QpKSApCisgICAgICAgIGZyZWVfZG9taGVh
cF9wYWdlKHBnKTsKKworICAgIHBkZXYtPmFyY2gudnRkLnBnZF9tYWRkciA9
IDA7CisKKyAgICBpZiAoIGRyaGQgKQorICAgICAgICBjbGVhbnVwX2RvbWlk
X21hcChwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwgZHJoZC0+aW9tbXUpOwor
fQorCiBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBpbnRlbF9pb21tdV9tYXBf
cGFnZShzdHJ1Y3QgZG9tYWluICpkLCBkZm5fdCBkZm4sCiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZm5fdCBtZm4s
IHVuc2lnbmVkIGludCBmbGFncywKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCAqZmx1c2hfZmxh
Z3MpCkBAIC0yMjA5LDYgKzIyMzksOCBAQCBzdGF0aWMgaW50IGludGVsX2lv
bW11X3JlbW92ZV9kZXZpY2UodTgKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7CiAgICAgfQogCisgICAg
cXVhcmFudGluZV90ZWFyZG93bihwZGV2LCBkcmhkKTsKKwogICAgIGlmICgg
ZHJoZCApCiAgICAgewogICAgICAgICBpb21tdV9mcmVlX2RvbWlkKHBkZXYt
PmFyY2gucHNldWRvX2RvbWlkLApAQCAtMjg4OCw2MCArMjkyMCwxMzkgQEAg
c3RhdGljIHZvaWQgdnRkX2R1bXBfcDJtX3RhYmxlKHN0cnVjdCBkbwogICAg
IHZ0ZF9kdW1wX3AybV90YWJsZV9sZXZlbChoZC0+YXJjaC5wZ2RfbWFkZHIs
IGFnYXdfdG9fbGV2ZWwoaGQtPmFyY2guYWdhdyksIDAsIDApOwogfQogCi1z
dGF0aWMgaW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFyYW50aW5lX2luaXQo
c3RydWN0IGRvbWFpbiAqZCkKK3N0YXRpYyBpbnQgZmlsbF9xcHQoc3RydWN0
IGRtYV9wdGUgKnRoaXMsIHVuc2lnbmVkIGludCBsZXZlbCwKKyAgICAgICAg
ICAgICAgICAgICAgcGFkZHJfdCBtYWRkcnNbNl0sIHN0cnVjdCBwY2lfZGV2
ICpwZGV2KQogewotICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9t
X2lvbW11KGQpOwotICAgIHN0cnVjdCBkbWFfcHRlICpwYXJlbnQ7CisgICAg
c3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZG9tX2lvKTsK
KyAgICB1bnNpZ25lZCBpbnQgaTsKKyAgICBpbnQgcmMgPSAwOworCisgICAg
Zm9yICggaSA9IDA7ICFyYyAmJiBpIDwgUFRFX05VTTsgKytpICkKKyAgICB7
CisgICAgICAgIHN0cnVjdCBkbWFfcHRlICpwdGUgPSAmdGhpc1tpXSwgKm5l
eHQ7CisKKyAgICAgICAgaWYgKCAhZG1hX3B0ZV9wcmVzZW50KCpwdGUpICkK
KyAgICAgICAgeworICAgICAgICAgICAgaWYgKCAhbWFkZHJzW2xldmVsXSAp
CisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgLyoKKyAgICAgICAg
ICAgICAgICAgKiBUaGUgcGd0YWJsZSBhbGxvY2F0b3IgaXMgZmluZSBmb3Ig
dGhlIGxlYWYgcGFnZSwgYXMgd2VsbCBhcworICAgICAgICAgICAgICAgICAq
IHBhZ2UgdGFibGUgcGFnZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRp
b25zIGFyZSBhbHdheXMKKyAgICAgICAgICAgICAgICAgKiB6ZXJvZWQuCisg
ICAgICAgICAgICAgICAgICovCisgICAgICAgICAgICAgICAgbWFkZHJzW2xl
dmVsXSA9IGFsbG9jX3BndGFibGVfbWFkZHIoMSwgaGQtPm5vZGUpOworICAg
ICAgICAgICAgICAgIGlmICggIW1hZGRyc1tsZXZlbF0gKQorICAgICAgICAg
ICAgICAgIHsKKyAgICAgICAgICAgICAgICAgICAgcmMgPSAtRU5PTUVNOwor
ICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICB9
CisKKyAgICAgICAgICAgICAgICBwYWdlX2xpc3RfYWRkKG1hZGRyX3RvX3Bh
Z2UobWFkZHJzW2xldmVsXSksCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAmcGRldi0+YXJjaC5wZ3RhYmxlc19saXN0KTsKKworICAgICAgICAg
ICAgICAgIGlmICggbGV2ZWwgKQorICAgICAgICAgICAgICAgIHsKKyAgICAg
ICAgICAgICAgICAgICAgbmV4dCA9IG1hcF92dGRfZG9tYWluX3BhZ2UobWFk
ZHJzW2xldmVsXSk7CisgICAgICAgICAgICAgICAgICAgIHJjID0gZmlsbF9x
cHQobmV4dCwgbGV2ZWwgLSAxLCBtYWRkcnMsIHBkZXYpOworICAgICAgICAg
ICAgICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UobmV4dCk7CisgICAg
ICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorCisgICAgICAgICAgICBk
bWFfc2V0X3B0ZV9hZGRyKCpwdGUsIG1hZGRyc1tsZXZlbF0pOworICAgICAg
ICAgICAgZG1hX3NldF9wdGVfcmVhZGFibGUoKnB0ZSk7CisgICAgICAgICAg
ICBkbWFfc2V0X3B0ZV93cml0YWJsZSgqcHRlKTsKKyAgICAgICAgfQorICAg
ICAgICBlbHNlIGlmICggbGV2ZWwgJiYgIWRtYV9wdGVfc3VwZXJwYWdlKCpw
dGUpICkKKyAgICAgICAgeworICAgICAgICAgICAgcGFnZV9saXN0X2FkZCht
YWRkcl90b19wYWdlKGRtYV9wdGVfYWRkcigqcHRlKSksCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICZwZGV2LT5hcmNoLnBndGFibGVzX2xpc3QpOwor
ICAgICAgICAgICAgbmV4dCA9IG1hcF92dGRfZG9tYWluX3BhZ2UoZG1hX3B0
ZV9hZGRyKCpwdGUpKTsKKyAgICAgICAgICAgIHJjID0gZmlsbF9xcHQobmV4
dCwgbGV2ZWwgLSAxLCBtYWRkcnMsIHBkZXYpOworICAgICAgICAgICAgdW5t
YXBfdnRkX2RvbWFpbl9wYWdlKG5leHQpOworICAgICAgICB9CisgICAgfQor
CisgICAgcmV0dXJuIHJjOworfQorCitzdGF0aWMgaW50IGludGVsX2lvbW11
X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3QgcGNpX2RldiAqcGRldikKK3sKKyAg
ICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21faW8p
OworICAgIHBhZGRyX3QgbWFkZHI7CiAgICAgdW5zaWduZWQgaW50IGFnYXcg
PSB3aWR0aF90b19hZ2F3KERFRkFVTFRfRE9NQUlOX0FERFJFU1NfV0lEVEgp
OwogICAgIHVuc2lnbmVkIGludCBsZXZlbCA9IGFnYXdfdG9fbGV2ZWwoYWdh
dyk7CisgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwor
ICAgIGNvbnN0IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKKyAgICB1
bnNpZ25lZCBpbnQgaSwgYmRmOworICAgIGJvb2wgcm1ycl9mb3VuZCA9IGZh
bHNlOworICAgIGludCByYzsKIAotICAgIGlmICggaGQtPmFyY2gucGdkX21h
ZGRyICkKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CisgICAgQVNT
RVJUKCFoZC0+YXJjaC5wZ2RfbWFkZHIpOworCisgICAgaWYgKCBwZGV2LT5h
cmNoLnZ0ZC5wZ2RfbWFkZHIgKQogICAgIHsKLSAgICAgICAgQVNTRVJUX1VO
UkVBQ0hBQkxFKCk7CisgICAgICAgIGNsZWFyX2RvbWFpbl9wYWdlKHBkZXYt
PmFyY2gubGVhZl9tZm4pOwogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAK
LSAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CisgICAg
ZHJoZCA9IGFjcGlfZmluZF9tYXRjaGVkX2RyaGRfdW5pdChwZGV2KTsKKyAg
ICBpZiAoICFkcmhkICkKKyAgICAgICAgcmV0dXJuIC1FTk9ERVY7CiAKLSAg
ICBoZC0+YXJjaC5wZ2RfbWFkZHIgPSBhbGxvY19wZ3RhYmxlX21hZGRyKDEs
IGhkLT5ub2RlKTsKLSAgICBpZiAoICFoZC0+YXJjaC5wZ2RfbWFkZHIgKQot
ICAgICAgICBnb3RvIG91dDsKKyAgICBtYWRkciA9IGFsbG9jX3BndGFibGVf
bWFkZHIoMSwgaGQtPm5vZGUpOworICAgIGlmICggIW1hZGRyICkKKyAgICAg
ICAgcmV0dXJuIC1FTk9NRU07CiAKLSAgICBwYXJlbnQgPSBtYXBfdnRkX2Rv
bWFpbl9wYWdlKGhkLT5hcmNoLnBnZF9tYWRkcik7Ci0gICAgd2hpbGUgKCBs
ZXZlbCApCi0gICAgewotICAgICAgICB1aW50NjRfdCBtYWRkcjsKLSAgICAg
ICAgdW5zaWduZWQgaW50IG9mZnNldDsKKyAgICByYyA9IGNvbnRleHRfc2V0
X2RvbWFpbl9pZChOVUxMLCBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwgZHJo
ZC0+aW9tbXUpOwogCi0gICAgICAgIC8qCi0gICAgICAgICAqIFRoZSBwZ3Rh
YmxlIGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUgbGVhZiBwYWdlLCBhcyB3
ZWxsIGFzCi0gICAgICAgICAqIHBhZ2UgdGFibGUgcGFnZXMsIGFuZCB0aGUg
cmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMKLSAgICAgICAgICog
emVyb2VkLgotICAgICAgICAgKi8KLSAgICAgICAgbWFkZHIgPSBhbGxvY19w
Z3RhYmxlX21hZGRyKDEsIGhkLT5ub2RlKTsKLSAgICAgICAgaWYgKCAhbWFk
ZHIgKQorICAgIC8qIFRyYW5zaWVudGx5IGluc3RhbGwgdGhlIHJvb3QgaW50
byBEb21JTywgZm9yIGlvbW11X2lkZW50aXR5X21hcHBpbmcoKS4gKi8KKyAg
ICBoZC0+YXJjaC5wZ2RfbWFkZHIgPSBtYWRkcjsKKworICAgIGZvcl9lYWNo
X3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKKyAgICB7CisgICAgICAg
IGlmICggcmMgKQogICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgZm9y
ICggb2Zmc2V0ID0gMDsgb2Zmc2V0IDwgUFRFX05VTTsgb2Zmc2V0KysgKQor
ICAgICAgICBpZiAoIHJtcnItPnNlZ21lbnQgPT0gcGRldi0+c2VnICYmIGJk
ZiA9PSBwZGV2LT5zYmRmLmJkZiApCiAgICAgICAgIHsKLSAgICAgICAgICAg
IHN0cnVjdCBkbWFfcHRlICpwdGUgPSAmcGFyZW50W29mZnNldF07CisgICAg
ICAgICAgICBybXJyX2ZvdW5kID0gdHJ1ZTsKIAotICAgICAgICAgICAgZG1h
X3NldF9wdGVfYWRkcigqcHRlLCBtYWRkcik7Ci0gICAgICAgICAgICBkbWFf
c2V0X3B0ZV9yZWFkYWJsZSgqcHRlKTsKKyAgICAgICAgICAgIHJjID0gaW9t
bXVfaWRlbnRpdHlfbWFwcGluZyhkb21faW8sIHAybV9hY2Nlc3NfcncsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+
YmFzZV9hZGRyZXNzLCBybXJyLT5lbmRfYWRkcmVzcywKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwKTsKKyAgICAgICAgICAg
IGlmICggcmMgKQorICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJS
IFZURFBSRUZJWAorICAgICAgICAgICAgICAgICAgICAgICAiJTA0eDolMDJ4
OiUwMnguJXU6IFJNUlIgcXVhcmFudGluZSBtYXBwaW5nIGZhaWxlZFxuIiwK
KyAgICAgICAgICAgICAgICAgICAgICAgcGRldi0+c2VnLCBwZGV2LT5idXMs
CisgICAgICAgICAgICAgICAgICAgICAgIFBDSV9TTE9UKHBkZXYtPmRldmZu
KSwgUENJX0ZVTkMocGRldi0+ZGV2Zm4pKTsKICAgICAgICAgfQotICAgICAg
ICBpb21tdV9zeW5jX2NhY2hlKHBhcmVudCwgUEFHRV9TSVpFKTsKKyAgICB9
CiAKLSAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKHBhcmVudCk7Ci0g
ICAgICAgIHBhcmVudCA9IG1hcF92dGRfZG9tYWluX3BhZ2UobWFkZHIpOwot
ICAgICAgICBsZXZlbC0tOworICAgIGlvbW11X2lkZW50aXR5X21hcF90ZWFy
ZG93bihkb21faW8pOworICAgIGhkLT5hcmNoLnBnZF9tYWRkciA9IDA7Cisg
ICAgcGRldi0+YXJjaC52dGQucGdkX21hZGRyID0gbWFkZHI7CisKKyAgICBp
ZiAoICFyYyApCisgICAgeworICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAqcm9v
dDsKKyAgICAgICAgcGFkZHJfdCBtYWRkcnNbNl0gPSB7fTsKKworICAgICAg
ICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CisKKyAgICAg
ICAgcm9vdCA9IG1hcF92dGRfZG9tYWluX3BhZ2UobWFkZHIpOworICAgICAg
ICByYyA9IGZpbGxfcXB0KHJvb3QsIGxldmVsIC0gMSwgbWFkZHJzLCBwZGV2
KTsKKyAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKHJvb3QpOworCisg
ICAgICAgIHBkZXYtPmFyY2gubGVhZl9tZm4gPSBtYWRkcl90b19tZm4obWFk
ZHJzWzBdKTsKKworICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFw
cGluZ19sb2NrKTsKICAgICB9Ci0gICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdl
KHBhcmVudCk7CiAKLSBvdXQ6Ci0gICAgc3Bpbl91bmxvY2soJmhkLT5hcmNo
Lm1hcHBpbmdfbG9jayk7CisgICAgaWYgKCByYyApCisgICAgICAgIHF1YXJh
bnRpbmVfdGVhcmRvd24ocGRldiwgZHJoZCk7CiAKLSAgICAvKiBQYWdlcyBs
ZWFrZWQgaW4gZmFpbHVyZSBjYXNlICovCi0gICAgcmV0dXJuIGxldmVsID8g
LUVOT01FTSA6IDA7CisgICAgcmV0dXJuIHJjOwogfQogCiBjb25zdCBzdHJ1
Y3QgaW9tbXVfb3BzIF9faW5pdGNvbnN0cmVsIGludGVsX2lvbW11X29wcyA9
IHsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgK
KysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgKQEAg
LTUwOSw3ICs1MDksNyBAQCBzdHJ1Y3QgdnRkX2lvbW11IHsKICAgICB1MzIg
bnJfcHRfbGV2ZWxzOwogICAgIHU2NAljYXA7CiAgICAgdTY0CWVjYXA7Ci0g
ICAgc3BpbmxvY2tfdCBsb2NrOyAvKiBwcm90ZWN0IGNvbnRleHQsIGRvbWFp
biBpZHMgKi8KKyAgICBzcGlubG9ja190IGxvY2s7IC8qIHByb3RlY3QgY29u
dGV4dCAqLwogICAgIHNwaW5sb2NrX3QgcmVnaXN0ZXJfbG9jazsgLyogcHJv
dGVjdCBpb21tdSByZWdpc3RlciBoYW5kbGluZyAqLwogICAgIHU2NCByb290
X21hZGRyOyAvKiByb290IGVudHJ5IG1hY2hpbmUgYWRkcmVzcyAqLwogICAg
IG5vZGVpZF90IG5vZGU7Ci0tLSBhL3hlbi9pbmNsdWRlL3hlbi9pb21tdS5o
CisrKyBiL3hlbi9pbmNsdWRlL3hlbi9pb21tdS5oCkBAIC0yMTEsNyArMjEx
LDcgQEAgdHlwZWRlZiBpbnQgaW9tbXVfZ3JkbV90KHhlbl9wZm5fdCBzdGFy
dAogc3RydWN0IGlvbW11X29wcyB7CiAgICAgaW50ICgqaW5pdCkoc3RydWN0
IGRvbWFpbiAqZCk7CiAgICAgdm9pZCAoKmh3ZG9tX2luaXQpKHN0cnVjdCBk
b21haW4gKmQpOwotICAgIGludCAoKnF1YXJhbnRpbmVfaW5pdCkoc3RydWN0
IGRvbWFpbiAqZCk7CisgICAgaW50ICgqcXVhcmFudGluZV9pbml0KShkZXZp
Y2VfdCAqZGV2KTsKICAgICBpbnQgKCphZGRfZGV2aWNlKSh1OCBkZXZmbiwg
ZGV2aWNlX3QgKmRldik7CiAgICAgaW50ICgqZW5hYmxlX2RldmljZSkoZGV2
aWNlX3QgKmRldik7CiAgICAgaW50ICgqcmVtb3ZlX2RldmljZSkodTggZGV2
Zm4sIGRldmljZV90ICpkZXYpOwpAQCAtMzMxLDYgKzMzMSw3IEBAIGludCBf
X211c3RfY2hlY2sgaW9tbXVfc3VzcGVuZCh2b2lkKTsKIHZvaWQgaW9tbXVf
cmVzdW1lKHZvaWQpOwogdm9pZCBpb21tdV9jcmFzaF9zaHV0ZG93bih2b2lk
KTsKIGludCBpb21tdV9nZXRfcmVzZXJ2ZWRfZGV2aWNlX21lbW9yeShpb21t
dV9ncmRtX3QgKiwgdm9pZCAqKTsKK2ludCBpb21tdV9xdWFyYW50aW5lX2Rl
dl9pbml0KGRldmljZV90ICpkZXYpOwogCiB2b2lkIGlvbW11X3NoYXJlX3Ay
bV90YWJsZShzdHJ1Y3QgZG9tYWluICpkKTsKIAo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-01.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-01.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggKGRlKWFzc2lnbiBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSB1cGRhdGVkLgoKQWxzbyBhZGp1c3QgYSByZWxhdGVk
IGxvZyBtZXNzYWdlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM1OCAvIHBhcnQg
b2YgWFNBLTQwMC4KCkZpeGVzOiA4Yjk5ZjQ0MDBiNjkgKCJWVC1kOiBmaXgg
Uk1SUiByZWxhdGVkIGVycm9yIGhhbmRsaW5nIikKU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog
Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+ClJldmll
d2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KUmV2aWV3ZWQt
Ynk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgoKLS0tIGEv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAgLTI0MTEsNiAr
MjQxMSwxMCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNo
aXAoCiB7CiAgICAgaW50IHJldDsKIAorICAgIHJldCA9IGRvbWFpbl9jb250
ZXh0X3VubWFwKHNvdXJjZSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0
ICkKKyAgICAgICAgcmV0dXJuIHJldDsKKwogICAgIC8qCiAgICAgICogRGV2
aWNlcyBhc3NpZ25lZCB0byB1bnRydXN0ZWQgZG9tYWlucyAoaGVyZSBhc3N1
bWVkIHRvIGJlIGFueSBkb21VKQogICAgICAqIGNhbiBhdHRlbXB0IHRvIHNl
bmQgYXJiaXRyYXJ5IExBUElDL01TSSBtZXNzYWdlcy4gV2UgYXJlIHVucHJv
dGVjdGVkCkBAIC0yNDQ3LDEwICsyNDUxLDYgQEAgc3RhdGljIGludCByZWFz
c2lnbl9kZXZpY2Vfb3duZXJzaGlwKAogICAgICAgICAgICAgfQogICAgIH0K
IAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHNvdXJjZSwgZGV2
Zm4sIHBkZXYpOwotICAgIGlmICggcmV0ICkKLSAgICAgICAgcmV0dXJuIHJl
dDsKLQogICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+
ZG9tYWluICE9IGRvbV9pbyApCiAgICAgewogICAgICAgICBsaXN0X21vdmUo
JnBkZXYtPmRvbWFpbl9saXN0LCAmZG9tX2lvLT5wZGV2X2xpc3QpOwpAQCAt
MjUyNyw5ICsyNTI3LDggQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hc3Np
Z25fZGV2aWNlKAogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0ID0gcmVh
c3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7Ci0g
ICAgaWYgKCByZXQgfHwgZCA9PSBkb21faW8gKQotICAgICAgICByZXR1cm4g
cmV0OworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm4g
cmVhc3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7
CiAKICAgICAvKiBTZXR1cCBybXJyIGlkZW50aXR5IG1hcHBpbmcgKi8KICAg
ICBmb3JfZWFjaF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBpICkKQEAgLTI1
NDIsMjAgKzI1NDEsMzcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hc3Np
Z25fZGV2aWNlKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgZmxhZyk7CiAgICAgICAgICAg
ICBpZiAoIHJldCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAg
aW50IHJjOwotCi0gICAgICAgICAgICAgICAgcmMgPSByZWFzc2lnbl9kZXZp
Y2Vfb3duZXJzaGlwKGQsIHMsIGRldmZuLCBwZGV2KTsKICAgICAgICAgICAg
ICAgICBwcmludGsoWEVOTE9HX0dfRVJSIFZURFBSRUZJWAotICAgICAgICAg
ICAgICAgICAgICAgICAiIGNhbm5vdCBtYXAgcmVzZXJ2ZWQgcmVnaW9uICgl
IlBSSXg2NCIsJSJQUkl4NjQiXSBmb3IgRG9tJWQgKCVkKVxuIiwKLSAgICAg
ICAgICAgICAgICAgICAgICAgcm1yci0+YmFzZV9hZGRyZXNzLCBybXJyLT5l
bmRfYWRkcmVzcywKLSAgICAgICAgICAgICAgICAgICAgICAgZC0+ZG9tYWlu
X2lkLCByZXQpOwotICAgICAgICAgICAgICAgIGlmICggcmMgKQotICAgICAg
ICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlIgVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAi
IGZhaWxlZCB0byByZWNsYWltICUwNHg6JTAyeDolMDJ4LiV1IGZyb20gJXBk
ICglZClcbiIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBzZWcsIGJ1
cywgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksIGQsIHJjKTsK
LSAgICAgICAgICAgICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwotICAgICAg
ICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgICAgICAgIiVwZDogY2Fu
bm90IG1hcCByZXNlcnZlZCByZWdpb24gWyUiUFJJeDY0IiwlIlBSSXg2NCJd
OiAlZFxuIiwKKyAgICAgICAgICAgICAgICAgICAgICAgZCwgcm1yci0+YmFz
ZV9hZGRyZXNzLCBybXJyLT5lbmRfYWRkcmVzcywgcmV0KTsKKyAgICAgICAg
ICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAg
IH0KKworICAgIGlmICggIXJldCApCisgICAgICAgIHJldCA9IHJlYXNzaWdu
X2RldmljZV9vd25lcnNoaXAocywgZCwgZGV2Zm4sIHBkZXYpOworCisgICAg
LyogU2VlIHJlYXNzaWduX2RldmljZV9vd25lcnNoaXAoKSBmb3IgdGhlIGh3
ZG9tIGFzcGVjdC4gKi8KKyAgICBpZiAoICFyZXQgfHwgaXNfaGFyZHdhcmVf
ZG9tYWluKGQpICkKKyAgICAgICAgcmV0dXJuIHJldDsKKworICAgIGZvcl9l
YWNoX3JtcnJfZGV2aWNlKCBybXJyLCBiZGYsIGkgKQorICAgIHsKKyAgICAg
ICAgaWYgKCBybXJyLT5zZWdtZW50ID09IHNlZyAmJgorICAgICAgICAgICAg
IFBDSV9CVVMoYmRmKSA9PSBidXMgJiYKKyAgICAgICAgICAgICBQQ0lfREVW
Rk4yKGJkZikgPT0gZGV2Zm4gKQorICAgICAgICB7CisgICAgICAgICAgICBp
bnQgcmMgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGQsIHAybV9hY2Nlc3Nf
eCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgcm1yci0+YmFzZV9hZGRyZXNzLAorICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7
CisKKyAgICAgICAgICAgIGlmICggcmMgJiYgcmMgIT0gLUVOT0VOVCApCisg
ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19F
UlIgVlREUFJFRklYCisgICAgICAgICAgICAgICAgICAgICAgICIlcGQ6IGNh
bm5vdCB1bm1hcCByZXNlcnZlZCByZWdpb24gWyUiUFJJeDY0IiwlIlBSSXg2
NCJdOiAlZFxuIiwKKyAgICAgICAgICAgICAgICAgICAgICAgZCwgcm1yci0+
YmFzZV9hZGRyZXNzLCBybXJyLT5lbmRfYWRkcmVzcywgcmMpOworICAgICAg
ICAgICAgICAgIGRvbWFpbl9jcmFzaChkKTsKICAgICAgICAgICAgICAgICBi
cmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgfQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-02.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-02.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggYWRkL3JlbW92ZSBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSBjbGVhcmVkLgoKQWxzbyBzd2l0Y2ggdG8gJXBkIGlu
IHJlbGF0ZWQgbG9nIG1lc3NhZ2VzLgoKRml4ZXM6IGZhODhjZmFkZjkxOCAo
InZ0LWQ6IE1hcCBSTVJSIGluIGludGVsX2lvbW11X2FkZF9kZXZpY2UoKSBp
ZiB0aGUgZGV2aWNlIGhhcyBSTVJSIikKRml4ZXM6IDhiOTlmNDQwMGI2OSAo
IlZULWQ6IGZpeCBSTVJSIHJlbGF0ZWQgZXJyb3IgaGFuZGxpbmciKQpTaWdu
ZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJl
dmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4
LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50
ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmMKQEAgLTIwMDAsMTQgKzIwMDAsNiBAQCBzdGF0aWMgaW50IGludGVsX2lv
bW11X2FkZF9kZXZpY2UodTggZGV2CiAgICAgaWYgKCAhcGRldi0+ZG9tYWlu
ICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CiAKLSAgICByZXQgPSBkb21h
aW5fY29udGV4dF9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYp
OwotICAgIGlmICggcmV0ICkKLSAgICB7Ci0gICAgICAgIGRwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgsICJkJWQ6IGNvbnRleHQgbWFwcGluZyBmYWls
ZWRcbiIsCi0gICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluLT5kb21haW5f
aWQpOwotICAgICAgICByZXR1cm4gcmV0OwotICAgIH0KLQogICAgIGZvcl9l
YWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKICAgICB7CiAgICAg
ICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBwZGV2LT5zZWcgJiYKQEAgLTIw
MjQsMTIgKzIwMTYsMTcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hZGRf
ZGV2aWNlKHU4IGRldgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRy
ZXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAwKTsKICAgICAgICAgICAgIGlmICggcmV0ICkKLSAgICAgICAgICAgICAg
ICBkcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiZCVkOiBSTVJSIG1h
cHBpbmcgZmFpbGVkXG4iLAotICAgICAgICAgICAgICAgICAgICAgICAgcGRl
di0+ZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAgICAgIGRwcmlu
dGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IFJNUlIgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LT5kb21h
aW4pOwogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuIDA7CisgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZyhwZGV2LT5kb21haW4sIGRl
dmZuLCBwZGV2KTsKKyAgICBpZiAoIHJldCApCisgICAgICAgIGRwcmludGso
WEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IGNvbnRleHQgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluKTsKKwor
ICAgIHJldHVybiByZXQ7CiB9CiAKIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVf
ZW5hYmxlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRldikKQEAgLTIwNTEs
MTEgKzIwNDgsMTUgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVf
ZGV2aWNlKHU4CiB7CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJy
OwogICAgIHUxNiBiZGY7Ci0gICAgaW50IGk7CisgICAgaW50IHJldCwgaTsK
IAogICAgIGlmICggIXBkZXYtPmRvbWFpbiApCiAgICAgICAgIHJldHVybiAt
RUlOVkFMOwogCisgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAocGRl
di0+ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgaWYgKCByZXQgKQorICAg
ICAgICByZXR1cm4gcmV0OworCiAgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2Ug
KCBybXJyLCBiZGYsIGkgKQogICAgIHsKICAgICAgICAgaWYgKCBybXJyLT5z
ZWdtZW50ICE9IHBkZXYtPnNlZyB8fApAQCAtMjA3MSw3ICsyMDcyLDcgQEAg
c3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4CiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3Ms
IDApOwogICAgIH0KIAotICAgIHJldHVybiBkb21haW5fY29udGV4dF91bm1h
cChwZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKKyAgICByZXR1cm4gMDsK
IH0KIAogc3RhdGljIGludCBfX2h3ZG9tX2luaXQgc2V0dXBfaHdkb21fZGV2
aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-03.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBkcm9wIG93bmVyc2hpcCBjaGVja2luZyBmcm9tIGRvbWFpbl9j
b250ZXh0X21hcHBpbmdfb25lKCkKCkRlc3BpdGUgcHV0dGluZyBpbiBxdWl0
ZSBhIGJpdCBvZiBlZmZvcnQgaXQgd2FzIG5vdCBwb3NzaWJsZSB0bwplc3Rh
Ymxpc2ggd2h5IGV4YWN0bHkgdGhpcyBjb2RlIGV4aXN0cyAoYmV5b25kIHBv
c3NpYmx5IHNhbml0eQpjaGVja2luZykuIEluc3RlYWQgb2YgYSBzdWJzZXF1
ZW50IGNoYW5nZSBmdXJ0aGVyIGNvbXBsaWNhdGluZyB0aGlzCmxvZ2ljLCBz
aW1wbHkgZ2V0IHJpZCBvZiBpdC4KClRha2UgdGhlIG9wcG9ydHVuaXR5IGFu
ZCBtb3ZlIHRoZSByZXNwZWN0aXZlIHVubWFwX3Z0ZF9kb21haW5fcGFnZSgp
IG91dApvZiB0aGUgbG9ja2VkIHJlZ2lvbi4KClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdl
ZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5
OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KCi0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCkBAIC0xMjAsMjggKzEy
MCw2IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVj
dAogICAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGNvbnRleHRfZ2V0
X2RvbWFpbl9pZChzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4dCwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQotewotICAgIHVuc2lnbmVkIGxvbmcgZG9tX2luZGV4LCBu
cl9kb207Ci0gICAgaW50IGRvbWlkID0gLTE7Ci0KLSAgICBpZiAoaW9tbXUg
JiYgY29udGV4dCkKLSAgICB7Ci0gICAgICAgIG5yX2RvbSA9IGNhcF9uZG9t
cyhpb21tdS0+Y2FwKTsKLQotICAgICAgICBkb21faW5kZXggPSBjb250ZXh0
X2RvbWFpbl9pZCgqY29udGV4dCk7Ci0KLSAgICAgICAgaWYgKCBkb21faW5k
ZXggPCBucl9kb20gJiYgaW9tbXUtPmRvbWlkX21hcCApCi0gICAgICAgICAg
ICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbZG9tX2luZGV4XTsKLSAgICAg
ICAgZWxzZQotICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfREVCVUcgVlRE
UFJFRklYLAotICAgICAgICAgICAgICAgICAgICAiZG9tX2luZGV4ICVsdSBl
eGNlZWRzIG5yX2RvbSAlbHUgb3IgaW9tbXUgaGFzIG5vIGRvbWlkX21hcFxu
IiwKLSAgICAgICAgICAgICAgICAgICAgZG9tX2luZGV4LCBucl9kb20pOwot
ICAgIH0KLSAgICByZXR1cm4gZG9taWQ7Ci19Ci0KIHN0YXRpYyB2b2lkIGNs
ZWFudXBfZG9taWRfbWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXUpCiB7CiAgICAgaW50IGlvbW11X2RvbWlkID0g
ZG9tYWluX2lvbW11X2RvbWlkKGRvbWFpbiwgaW9tbXUpOwpAQCAtMTM5NSw0
NyArMTM3Myw5IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgK
IAogICAgIGlmICggY29udGV4dF9wcmVzZW50KCpjb250ZXh0KSApCiAgICAg
ewotICAgICAgICBpbnQgcmVzID0gMDsKLQotICAgICAgICAvKiBUcnkgdG8g
Z2V0IGRvbWFpbiBvd25lcnNoaXAgZnJvbSBkZXZpY2Ugc3RydWN0dXJlLiAg
SWYgdGhhdCdzCi0gICAgICAgICAqIG5vdCBhdmFpbGFibGUsIHRyeSB0byBy
ZWFkIGl0IGZyb20gdGhlIGNvbnRleHQgaXRzZWxmLiAqLwotICAgICAgICBp
ZiAoIHBkZXYgKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIHBkZXYt
PmRvbWFpbiAhPSBkb21haW4gKQotICAgICAgICAgICAgewotICAgICAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfR19JTkZPIFZURFBSRUZJWAotICAgICAg
ICAgICAgICAgICAgICAgICAiJXBkOiAlMDR4OiUwMng6JTAyeC4ldSBvd25l
ZCBieSAlcGRcbiIsCi0gICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbiwg
c2VnLCBidXMsIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pLAot
ICAgICAgICAgICAgICAgICAgICAgICBwZGV2LT5kb21haW4pOwotICAgICAg
ICAgICAgICAgIHJlcyA9IC1FSU5WQUw7Ci0gICAgICAgICAgICB9Ci0gICAg
ICAgIH0KLSAgICAgICAgZWxzZQotICAgICAgICB7Ci0gICAgICAgICAgICBp
bnQgY2RvbWFpbjsKLSAgICAgICAgICAgIGNkb21haW4gPSBjb250ZXh0X2dl
dF9kb21haW5faWQoY29udGV4dCwgaW9tbXUpOwotICAgICAgICAgICAgCi0g
ICAgICAgICAgICBpZiAoIGNkb21haW4gPCAwICkKLSAgICAgICAgICAgIHsK
LSAgICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfV0FSTklORyBWVERQ
UkVGSVgKLSAgICAgICAgICAgICAgICAgICAgICAgIiVwZDogJTA0eDolMDJ4
OiUwMnguJXUgbWFwcGVkLCBidXQgY2FuJ3QgZmluZCBvd25lclxuIiwKLSAg
ICAgICAgICAgICAgICAgICAgICAgZG9tYWluLCBzZWcsIGJ1cywgUENJX1NM
T1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikpOwotICAgICAgICAgICAgICAg
IHJlcyA9IC1FSU5WQUw7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBl
bHNlIGlmICggY2RvbWFpbiAhPSBkb21haW4tPmRvbWFpbl9pZCApCi0gICAg
ICAgICAgICB7Ci0gICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19HX0lO
Rk8gVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICIlcGQ6ICUw
NHg6JTAyeDolMDJ4LiV1IGFscmVhZHkgbWFwcGVkIHRvIGQlZFxuIiwKLSAg
ICAgICAgICAgICAgICAgICAgICAgZG9tYWluLAotICAgICAgICAgICAgICAg
ICAgICAgICBzZWcsIGJ1cywgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhk
ZXZmbiksCi0gICAgICAgICAgICAgICAgICAgICAgIGNkb21haW4pOwotICAg
ICAgICAgICAgICAgIHJlcyA9IC1FSU5WQUw7Ci0gICAgICAgICAgICB9Ci0g
ICAgICAgIH0KLQotICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29u
dGV4dF9lbnRyaWVzKTsKICAgICAgICAgc3Bpbl91bmxvY2soJmlvbW11LT5s
b2NrKTsKLSAgICAgICAgcmV0dXJuIHJlczsKKyAgICAgICAgdW5tYXBfdnRk
X2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7CisgICAgICAgIHJldHVy
biAwOwogICAgIH0KIAogICAgIGlmICggaW9tbXVfaHdkb21fcGFzc3Rocm91
Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWluKGRvbWFpbikgKQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-04.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiByZS1hc3NpZ24gZGV2aWNlcyBkaXJlY3RseQoKRGV2aWNlcyB3
aXRoIFJNUlJzLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQgaG93L3do
ZW4gdGhlIHNwZWNpZmllZAptZW1vcnkgcmVnaW9ucyBtYXkgZ2V0IGFjY2Vz
c2VkLCBtYXkgbm90IGJlIGxlZnQgZGlzY29ubmVjdGVkIGZyb20gdGhlaXIK
cmVzcGVjdGl2ZSBtYXBwaW5ncyAoYXMgbG9uZyBhcyBpdCdzIG5vdCBjZXJ0
YWluIHRoYXQgdGhlIGRldmljZSBoYXMKYmVlbiBmdWxseSBxdWllc2NlZCku
IEhlbmNlIHJhdGhlciB0aGFuIHVubWFwcGluZyB0aGUgb2xkIGNvbnRleHQg
YW5kCnRoZW4gbWFwcGluZyB0aGUgbmV3IG9uZSwgcmUtYXNzaWdubWVudCBu
ZWVkcyB0byBiZSBkb25lIGluIGEgc2luZ2xlCnN0ZXAuCgpUaGlzIGlzIENW
RS0yMDIyLTI2MzU5IC8gcGFydCBvZiBYU0EtNDAwLgoKUmVwb3J0ZWQtYnk6
IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKU2lt
aWxhcmx5IHF1YXJhbnRpbmluZyBzY3JhdGNoLXBhZ2UgbW9kZSByZWxpZXMg
b24gcGFnZSB0YWJsZXMgdG8gYmUKY29udGludW91c2x5IHdpcmVkIHVwLgoK
VG8gYXZvaWQgY29tcGxpY2F0aW5nIHRoaW5ncyBtb3JlIHRoYW4gbmVjZXNz
YXJ5LCB0cmVhdCBhbGwgZGV2aWNlcwptb3N0bHkgZXF1YWxseSwgaS5lLiBy
ZWdhcmRsZXNzIG9mIHRoZWlyIGFzc29jaWF0aW9uIHdpdGggYW55IFJNUlJz
LiBUaGUKbWFpbiBkaWZmZXJlbmNlIGlzIHdoZW4gaXQgY29tZXMgdG8gdXBk
YXRpbmcgY29udGV4dCBlbnRyaWVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21p
YyB3aGVuIHRoZXJlIGFyZSBSTVJScy4gWWV0IGF0b21pY2l0eSBjYW4gb25s
eSBiZSBhY2hpZXZlZAp3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBv
ZiB3aGljaCB3ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClRoZSBzZWVtaW5n
bHkgY29tcGxpY2F0ZWQgY2hvaWNlIG9mIG5vbi1uZWdhdGl2ZSByZXR1cm4g
dmFsdWVzIGZvcgpkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgpIGlzIHRv
IGxpbWl0IGNvZGUgY2h1cm46IFRoaXMgd2F5IGNhbGxlcnMKcGFzc2luZyBO
VUxMIGZvciBwZGV2IGRvbid0IG5lZWQgZmlkZGxpbmcgd2l0aC4KClNpZ25l
ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2
aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgpS
ZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp
eC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZXh0
ZXJuLmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2V4dGVy
bi5oCkBAIC04NSw3ICs4NSw4IEBAIHZvaWQgZnJlZV9wZ3RhYmxlX21hZGRy
KHU2NCBtYWRkcik7CiB2b2lkICptYXBfdnRkX2RvbWFpbl9wYWdlKHU2NCBt
YWRkcik7CiB2b2lkIHVubWFwX3Z0ZF9kb21haW5fcGFnZSh2b2lkICp2YSk7
CiBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoc3RydWN0IGRvbWFp
biAqZG9tYWluLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSwKLSAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB1OCBidXMsIHU4IGRldmZuLCBjb25z
dCBzdHJ1Y3QgcGNpX2RldiAqKTsKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB1aW50OF90IGJ1cywgdWludDhfdCBkZXZmbiwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldiwgdW5zaWduZWQgaW50IG1vZGUpOwogaW50IGRvbWFpbl9jb250ZXh0
X3VubWFwX29uZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCB2dGRf
aW9tbXUgKmlvbW11LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
OCBidXMsIHU4IGRldmZuKTsKIGludCBpbnRlbF9pb21tdV9nZXRfcmVzZXJ2
ZWRfZGV2aWNlX21lbW9yeShpb21tdV9ncmRtX3QgKmZ1bmMsIHZvaWQgKmN0
eHQpOwpAQCAtMTA1LDggKzEwNiw4IEBAIGludCBpc19pZ2RfdnRfZW5hYmxl
ZF9xdWlyayh2b2lkKTsKIHZvaWQgcGxhdGZvcm1fcXVpcmtzX2luaXQodm9p
ZCk7CiB2b2lkIHZ0ZF9vcHNfcHJlYW1ibGVfcXVpcmsoc3RydWN0IHZ0ZF9p
b21tdSAqaW9tbXUpOwogdm9pZCB2dGRfb3BzX3Bvc3RhbWJsZV9xdWlyayhz
dHJ1Y3QgdnRkX2lvbW11ICppb21tdSk7Ci1pbnQgX19tdXN0X2NoZWNrIG1l
X3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLAotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHU4IGJ1cywgdTggZGV2Zm4sIGludCBt
YXApOworaW50IF9fbXVzdF9jaGVjayBtZV93aWZpX3F1aXJrKHN0cnVjdCBk
b21haW4gKmRvbWFpbiwgdWludDhfdCBidXMsCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdWludDhfdCBkZXZmbiwgdW5zaWduZWQgaW50IG1v
ZGUpOwogdm9pZCBwY2lfdnRkX3F1aXJrKGNvbnN0IHN0cnVjdCBwY2lfZGV2
ICopOwogdm9pZCBxdWlya19pb21tdV9jYXBzKHN0cnVjdCB2dGRfaW9tbXUg
KmlvbW11KTsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv
aW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t
bXUuYwpAQCAtMTE2LDYgKzExNiw3IEBAIHN0YXRpYyBpbnQgY29udGV4dF9z
ZXRfZG9tYWluX2lkKHN0cnVjdAogICAgIH0KIAogICAgIHNldF9iaXQoaSwg
aW9tbXUtPmRvbWlkX2JpdG1hcCk7CisgICAgY29udGV4dC0+aGkgJj0gfigo
KDEgPDwgRElEX0ZJRUxEX1dJRFRIKSAtIDEpIDw8IERJRF9ISUdIX09GRlNF
VCk7CiAgICAgY29udGV4dC0+aGkgfD0gKGkgJiAoKDEgPDwgRElEX0ZJRUxE
X1dJRFRIKSAtIDEpKSA8PCBESURfSElHSF9PRkZTRVQ7CiAgICAgcmV0dXJu
IDA7CiB9CkBAIC0xMzUzLDE1ICsxMzU0LDI3IEBAIHN0YXRpYyB2b2lkIF9f
aHdkb21faW5pdCBpbnRlbF9pb21tdV9od2QKICAgICB9CiB9CiAKKy8qCisg
KiBUaGlzIGZ1bmN0aW9uIHJldHVybnMKKyAqIC0gYSBuZWdhdGl2ZSBlcnJu
byB2YWx1ZSB1cG9uIGVycm9yLAorICogLSB6ZXJvIHVwb24gc3VjY2VzcyB3
aGVuIHByZXZpb3VzbHkgdGhlIGVudHJ5IHdhcyBub24tcHJlc2VudCwgb3Ig
dGhpcyBpc24ndAorICogICB0aGUgIm1haW4iIHJlcXVlc3QgZm9yIGEgZGV2
aWNlIChwZGV2ID09IE5VTEwpLCBvciBmb3Igbm8tb3AgcXVhcmFudGluaW5n
CisgKiAgIGFzc2lnbm1lbnRzLAorICogLSBwb3NpdGl2ZSAob25lKSB1cG9u
IHN1Y2Nlc3Mgd2hlbiBwcmV2aW91c2x5IHRoZSBlbnRyeSB3YXMgcHJlc2Vu
dCBhbmQgdGhpcworICogICBpcyB0aGUgIm1haW4iIHJlcXVlc3QgZm9yIGEg
ZGV2aWNlIChwZGV2ICE9IE5VTEwpLgorICovCiBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZ19vbmUoCiAgICAgc3RydWN0IGRvbWFpbiAqZG9tYWluLAog
ICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAotICAgIHU4IGJ1cywgdTgg
ZGV2Zm4sIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQorICAgIHVpbnQ4
X3QgYnVzLCB1aW50OF90IGRldmZuLCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldiwKKyAgICB1bnNpZ25lZCBpbnQgbW9kZSkKIHsKICAgICBzdHJ1Y3Qg
ZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21haW4pOwotICAgIHN0
cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LCAqY29udGV4dF9lbnRyaWVz
OworICAgIHN0cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LCAqY29udGV4
dF9lbnRyaWVzLCBsY3R4dDsKKyAgICBfX3VpbnQxMjhfdCBvbGQ7CiAgICAg
dTY0IG1hZGRyLCBwZ2RfbWFkZHI7Ci0gICAgdTE2IHNlZyA9IGlvbW11LT5k
cmhkLT5zZWdtZW50OworICAgIHVpbnQxNl90IHNlZyA9IGlvbW11LT5kcmhk
LT5zZWdtZW50LCBwcmV2X2RpZCA9IDA7CisgICAgc3RydWN0IGRvbWFpbiAq
cHJldl9kb20gPSBOVUxMOwogICAgIGludCBhZ2F3LCByYywgcmV0OwogICAg
IGJvb2xfdCBmbHVzaF9kZXZfaW90bGI7CiAKQEAgLTEzNzAsMTcgKzEzODMs
MzIgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIG1h
ZGRyID0gYnVzX3RvX2NvbnRleHRfbWFkZHIoaW9tbXUsIGJ1cyk7CiAgICAg
Y29udGV4dF9lbnRyaWVzID0gKHN0cnVjdCBjb250ZXh0X2VudHJ5ICopbWFw
X3Z0ZF9kb21haW5fcGFnZShtYWRkcik7CiAgICAgY29udGV4dCA9ICZjb250
ZXh0X2VudHJpZXNbZGV2Zm5dOworICAgIG9sZCA9IChsY3R4dCA9ICpjb250
ZXh0KS5mdWxsOwogCi0gICAgaWYgKCBjb250ZXh0X3ByZXNlbnQoKmNvbnRl
eHQpICkKKyAgICBpZiAoIGNvbnRleHRfcHJlc2VudChsY3R4dCkgKQogICAg
IHsKLSAgICAgICAgc3Bpbl91bmxvY2soJmlvbW11LT5sb2NrKTsKLSAgICAg
ICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7Ci0g
ICAgICAgIHJldHVybiAwOworICAgICAgICBkb21pZF90IGRvbWlkOworCisg
ICAgICAgIHByZXZfZGlkID0gY29udGV4dF9kb21haW5faWQobGN0eHQpOwor
ICAgICAgICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbcHJldl9kaWRdOwor
ICAgICAgICBpZiAoIGRvbWlkIDwgRE9NSURfRklSU1RfUkVTRVJWRUQgKQor
ICAgICAgICAgICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW5fYnlfaWQo
ZG9taWQpOworICAgICAgICBlbHNlIGlmICggZG9taWQgPT0gRE9NSURfSU8g
KQorICAgICAgICAgICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW4oZG9t
X2lvKTsKKyAgICAgICAgaWYgKCAhcHJldl9kb20gKQorICAgICAgICB7Cisg
ICAgICAgICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOworICAgICAg
ICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7
CisgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19ERUJVRyBWVERQUkVGSVgs
CisgICAgICAgICAgICAgICAgICAgICJubyBkb21haW4gZm9yIGRpZCAldSAo
bnJfZG9tICV1KVxuIiwKKyAgICAgICAgICAgICAgICAgICAgcHJldl9kaWQs
IGNhcF9uZG9tcyhpb21tdS0+Y2FwKSk7CisgICAgICAgICAgICByZXR1cm4g
LUVTUkNIOworICAgICAgICB9CiAgICAgfQogCiAgICAgaWYgKCBpb21tdV9o
d2RvbV9wYXNzdGhyb3VnaCAmJiBpc19oYXJkd2FyZV9kb21haW4oZG9tYWlu
KSApCiAgICAgewotICAgICAgICBjb250ZXh0X3NldF90cmFuc2xhdGlvbl90
eXBlKCpjb250ZXh0LCBDT05URVhUX1RUX1BBU1NfVEhSVSk7CisgICAgICAg
IGNvbnRleHRfc2V0X3RyYW5zbGF0aW9uX3R5cGUobGN0eHQsIENPTlRFWFRf
VFRfUEFTU19USFJVKTsKICAgICAgICAgYWdhdyA9IGxldmVsX3RvX2FnYXco
aW9tbXUtPm5yX3B0X2xldmVscyk7CiAgICAgfQogICAgIGVsc2UKQEAgLTEz
OTcsNiArMTQyNSw4IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29u
ZSgKICAgICAgICAgICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFw
cGluZ19sb2NrKTsKICAgICAgICAgICAgICAgICBzcGluX3VubG9jaygmaW9t
bXUtPmxvY2spOwogICAgICAgICAgICAgICAgIHVubWFwX3Z0ZF9kb21haW5f
cGFnZShjb250ZXh0X2VudHJpZXMpOworICAgICAgICAgICAgICAgIGlmICgg
cHJldl9kb20gKQorICAgICAgICAgICAgICAgICAgICByY3VfdW5sb2NrX2Rv
bWFpbihwcmV2X2RvbSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9N
RU07CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KQEAgLTE0MTQsMzMgKzE0
NDQsMTAyIEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAg
ICAgICAgICAgICAgICBnb3RvIG5vbWVtOwogICAgICAgICB9CiAKLSAgICAg
ICAgY29udGV4dF9zZXRfYWRkcmVzc19yb290KCpjb250ZXh0LCBwZ2RfbWFk
ZHIpOworICAgICAgICBjb250ZXh0X3NldF9hZGRyZXNzX3Jvb3QobGN0eHQs
IHBnZF9tYWRkcik7CiAgICAgICAgIGlmICggYXRzX2VuYWJsZWQgJiYgZWNh
cF9kZXZfaW90bGIoaW9tbXUtPmVjYXApICkKLSAgICAgICAgICAgIGNvbnRl
eHRfc2V0X3RyYW5zbGF0aW9uX3R5cGUoKmNvbnRleHQsIENPTlRFWFRfVFRf
REVWX0lPVExCKTsKKyAgICAgICAgICAgIGNvbnRleHRfc2V0X3RyYW5zbGF0
aW9uX3R5cGUobGN0eHQsIENPTlRFWFRfVFRfREVWX0lPVExCKTsKICAgICAg
ICAgZWxzZQotICAgICAgICAgICAgY29udGV4dF9zZXRfdHJhbnNsYXRpb25f
dHlwZSgqY29udGV4dCwgQ09OVEVYVF9UVF9NVUxUSV9MRVZFTCk7CisgICAg
ICAgICAgICBjb250ZXh0X3NldF90cmFuc2xhdGlvbl90eXBlKGxjdHh0LCBD
T05URVhUX1RUX01VTFRJX0xFVkVMKTsKIAogICAgICAgICBzcGluX3VubG9j
aygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKICAgICB9CiAKLSAgICBpZiAo
IGNvbnRleHRfc2V0X2RvbWFpbl9pZChjb250ZXh0LCBkb21haW4sIGlvbW11
KSApCisgICAgcmMgPSBjb250ZXh0X3NldF9kb21haW5faWQoJmxjdHh0LCBk
b21haW4sIGlvbW11KTsKKyAgICBpZiAoIHJjICkKICAgICB7CisgICAgdW5s
b2NrOgogICAgICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOwogICAg
ICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVzKTsK
LSAgICAgICAgcmV0dXJuIC1FRkFVTFQ7CisgICAgICAgIGlmICggcHJldl9k
b20gKQorICAgICAgICAgICAgcmN1X3VubG9ja19kb21haW4ocHJldl9kb20p
OworICAgICAgICByZXR1cm4gcmM7CisgICAgfQorCisgICAgaWYgKCAhcHJl
dl9kb20gKQorICAgIHsKKyAgICAgICAgY29udGV4dF9zZXRfYWRkcmVzc193
aWR0aChsY3R4dCwgYWdhdyk7CisgICAgICAgIGNvbnRleHRfc2V0X2ZhdWx0
X2VuYWJsZShsY3R4dCk7CisgICAgICAgIGNvbnRleHRfc2V0X3ByZXNlbnQo
bGN0eHQpOworICAgIH0KKyAgICBlbHNlIGlmICggcHJldl9kb20gPT0gZG9t
YWluICkKKyAgICB7CisgICAgICAgIEFTU0VSVChsY3R4dC5mdWxsID09IGNv
bnRleHQtPmZ1bGwpOworICAgICAgICByYyA9ICEhcGRldjsKKyAgICAgICAg
Z290byB1bmxvY2s7CisgICAgfQorICAgIGVsc2UKKyAgICB7CisgICAgICAg
IEFTU0VSVChjb250ZXh0X2FkZHJlc3Nfd2lkdGgobGN0eHQpID09IGFnYXcp
OworICAgICAgICBBU1NFUlQoIWNvbnRleHRfZmF1bHRfZGlzYWJsZShsY3R4
dCkpOworICAgIH0KKworICAgIGlmICggY3B1X2hhc19jeDE2ICkKKyAgICB7
CisgICAgICAgIF9fdWludDEyOF90IHJlcyA9IGNtcHhjaGcxNmIoY29udGV4
dCwgJm9sZCwgJmxjdHh0LmZ1bGwpOworCisgICAgICAgIC8qCisgICAgICAg
ICAqIEhhcmR3YXJlIGRvZXMgbm90IHVwZGF0ZSB0aGUgY29udGV4dCBlbnRy
eSBiZWhpbmQgb3VyIGJhY2tzLAorICAgICAgICAgKiBzbyB0aGUgcmV0dXJu
IHZhbHVlIHNob3VsZCBtYXRjaCAib2xkIi4KKyAgICAgICAgICovCisgICAg
ICAgIGlmICggcmVzICE9IG9sZCApCisgICAgICAgIHsKKyAgICAgICAgICAg
IGlmICggcGRldiApCisgICAgICAgICAgICAgICAgY2hlY2tfY2xlYW51cF9k
b21pZF9tYXAoZG9tYWluLCBwZGV2LCBpb21tdSk7CisgICAgICAgICAgICBw
cmludGsoWEVOTE9HX0VSUgorICAgICAgICAgICAgICAgICAgICIlMDR4OiUw
Mng6JTAyeC4ldTogdW5leHBlY3RlZCBjb250ZXh0IGVudHJ5ICUwMTZseF8l
MDE2bHggKGV4cGVjdGVkICUwMTZseF8lMDE2bHgpXG4iLAorICAgICAgICAg
ICAgICAgICAgIHBkZXYtPnNlZywgcGRldi0+YnVzLCBQQ0lfU0xPVChkZXZm
biksIFBDSV9GVU5DKGRldmZuKSwKKyAgICAgICAgICAgICAgICAgICAodWlu
dDY0X3QpKHJlcyA+PiA2NCksICh1aW50NjRfdClyZXMsCisgICAgICAgICAg
ICAgICAgICAgKHVpbnQ2NF90KShvbGQgPj4gNjQpLCAodWludDY0X3Qpb2xk
KTsKKyAgICAgICAgICAgIHJjID0gLUVJTFNFUTsKKyAgICAgICAgICAgIGdv
dG8gdW5sb2NrOworICAgICAgICB9CisgICAgfQorICAgIGVsc2UgaWYgKCAh
cHJldl9kb20gfHwgIShtb2RlICYgTUFQX1dJVEhfUk1SUikgKQorICAgIHsK
KyAgICAgICAgY29udGV4dF9jbGVhcl9wcmVzZW50KCpjb250ZXh0KTsKKyAg
ICAgICAgaW9tbXVfc3luY19jYWNoZShjb250ZXh0LCBzaXplb2YoKmNvbnRl
eHQpKTsKKworICAgICAgICB3cml0ZV9hdG9taWMoJmNvbnRleHQtPmhpLCBs
Y3R4dC5oaSk7CisgICAgICAgIC8qIE5vIGJhcnJpZXIgc2hvdWxkIGJlIG5l
ZWRlZCBiZXR3ZWVuIHRoZXNlIHR3by4gKi8KKyAgICAgICAgd3JpdGVfYXRv
bWljKCZjb250ZXh0LT5sbywgbGN0eHQubG8pOworICAgIH0KKyAgICBlbHNl
IC8qIEJlc3QgZWZmb3J0LCB1cGRhdGluZyBESUQgbGFzdC4gKi8KKyAgICB7
CisgICAgICAgICAvKgorICAgICAgICAgICogQnkgbm9uLWF0b21pY2FsbHkg
dXBkYXRpbmcgdGhlIGNvbnRleHQgZW50cnkncyBESUQgZmllbGQgbGFzdCwK
KyAgICAgICAgICAqIGR1cmluZyBhIHNob3J0IHdpbmRvdyBpbiB0aW1lIFRM
QiBlbnRyaWVzIHdpdGggdGhlIG9sZCBkb21haW4gSUQKKyAgICAgICAgICAq
IGJ1dCB0aGUgbmV3IHBhZ2UgdGFibGVzIG1heSBiZSBpbnNlcnRlZC4gIFRo
aXMgY291bGQgYWZmZWN0IEkvTworICAgICAgICAgICogb2Ygb3RoZXIgZGV2
aWNlcyB1c2luZyB0aGlzIHNhbWUgKG9sZCkgZG9tYWluIElELiAgU3VjaCB1
cGRhdGluZworICAgICAgICAgICogdGhlcmVmb3JlIGlzIG5vdCBhIHByb2Js
ZW0gaWYgdGhpcyB3YXMgdGhlIG9ubHkgZGV2aWNlIGFzc29jaWF0ZWQKKyAg
ICAgICAgICAqIHdpdGggdGhlIG9sZCBkb21haW4gSUQuICBEaXZlcnRpbmcg
SS9PIG9mIGFueSBvZiBhIGR5aW5nIGRvbWFpbidzCisgICAgICAgICAgKiBk
ZXZpY2VzIHRvIHRoZSBxdWFyYW50aW5lIHBhZ2UgdGFibGVzIGlzIGludGVu
ZGVkIGFueXdheS4KKyAgICAgICAgICAqLworICAgICAgICBpZiAoICEobW9k
ZSAmIChNQVBfT1dORVJfRFlJTkcgfCBNQVBfU0lOR0xFX0RFVklDRSkpICkK
KyAgICAgICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORyBWVERQUkVGSVgK
KyAgICAgICAgICAgICAgICAgICAiICUwNHg6JTAyeDolMDJ4LiV1OiByZWFz
c2lnbm1lbnQgbWF5IGNhdXNlICVwZCBkYXRhIGNvcnJ1cHRpb25cbiIsCisg
ICAgICAgICAgICAgICAgICAgc2VnLCBidXMsIFBDSV9TTE9UKGRldmZuKSwg
UENJX0ZVTkMoZGV2Zm4pLCBwcmV2X2RvbSk7CisKKyAgICAgICAgd3JpdGVf
YXRvbWljKCZjb250ZXh0LT5sbywgbGN0eHQubG8pOworICAgICAgICAvKiBO
byBiYXJyaWVyIHNob3VsZCBiZSBuZWVkZWQgYmV0d2VlbiB0aGVzZSB0d28u
ICovCisgICAgICAgIHdyaXRlX2F0b21pYygmY29udGV4dC0+aGksIGxjdHh0
LmhpKTsKICAgICB9CiAKLSAgICBjb250ZXh0X3NldF9hZGRyZXNzX3dpZHRo
KCpjb250ZXh0LCBhZ2F3KTsKLSAgICBjb250ZXh0X3NldF9mYXVsdF9lbmFi
bGUoKmNvbnRleHQpOwotICAgIGNvbnRleHRfc2V0X3ByZXNlbnQoKmNvbnRl
eHQpOwogICAgIGlvbW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6ZW9mKHN0
cnVjdCBjb250ZXh0X2VudHJ5KSk7CiAgICAgc3Bpbl91bmxvY2soJmlvbW11
LT5sb2NrKTsKIAotICAgIC8qIENvbnRleHQgZW50cnkgd2FzIHByZXZpb3Vz
bHkgbm9uLXByZXNlbnQgKHdpdGggZG9taWQgMCkuICovCi0gICAgcmMgPSBp
b21tdV9mbHVzaF9jb250ZXh0X2RldmljZShpb21tdSwgMCwgUENJX0JERjIo
YnVzLCBkZXZmbiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBETUFfQ0NNRF9NQVNLX05PQklULCAxKTsKKyAgICByYyA9IGlvbW11
X2ZsdXNoX2NvbnRleHRfZGV2aWNlKGlvbW11LCBwcmV2X2RpZCwgUENJX0JE
RjIoYnVzLCBkZXZmbiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBETUFfQ0NNRF9NQVNLX05PQklULCAhcHJldl9kb20pOwogICAg
IGZsdXNoX2Rldl9pb3RsYiA9ICEhZmluZF9hdHNfZGV2X2RyaGQoaW9tbXUp
OwotICAgIHJldCA9IGlvbW11X2ZsdXNoX2lvdGxiX2RzaShpb21tdSwgMCwg
MSwgZmx1c2hfZGV2X2lvdGxiKTsKKyAgICByZXQgPSBpb21tdV9mbHVzaF9p
b3RsYl9kc2koaW9tbXUsIHByZXZfZGlkLCAhcHJldl9kb20sIGZsdXNoX2Rl
dl9pb3RsYik7CiAKICAgICAvKgogICAgICAqIFRoZSBjdXJyZW50IGxvZ2lj
IGZvciByZXR1cm5zOgpAQCAtMTQ2MSwxNyArMTU2MCwyNiBAQCBpbnQgZG9t
YWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgdW5tYXBfdnRkX2RvbWFp
bl9wYWdlKGNvbnRleHRfZW50cmllcyk7CiAKICAgICBpZiAoICFzZWcgJiYg
IXJjICkKLSAgICAgICAgcmMgPSBtZV93aWZpX3F1aXJrKGRvbWFpbiwgYnVz
LCBkZXZmbiwgTUFQX01FX1BIQU5UT01fRlVOQyk7CisgICAgICAgIHJjID0g
bWVfd2lmaV9xdWlyayhkb21haW4sIGJ1cywgZGV2Zm4sIG1vZGUpOwogCiAg
ICAgaWYgKCByYyApCiAgICAgewotICAgICAgICByZXQgPSBkb21haW5fY29u
dGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgYnVzLCBkZXZmbik7Cisg
ICAgICAgIGlmICggIXByZXZfZG9tICkKKyAgICAgICAgICAgIHJldCA9IGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMsIGRl
dmZuKTsKKyAgICAgICAgZWxzZSBpZiAoIHByZXZfZG9tICE9IGRvbWFpbiAp
IC8qIEF2b2lkIGluZmluaXRlIHJlY3Vyc2lvbi4gKi8KKyAgICAgICAgICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKHByZXZfZG9tLCBp
b21tdSwgYnVzLCBkZXZmbiwgcGRldiwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGUgJiBNQVBfV0lUSF9STVJS
KSA8IDA7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJldCA9IDE7CiAK
ICAgICAgICAgaWYgKCAhcmV0ICYmIHBkZXYgJiYgcGRldi0+ZGV2Zm4gPT0g
ZGV2Zm4gKQogICAgICAgICAgICAgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAo
ZG9tYWluLCBwZGV2LCBpb21tdSk7CiAgICAgfQogCi0gICAgcmV0dXJuIHJj
OworICAgIGlmICggcHJldl9kb20gKQorICAgICAgICByY3VfdW5sb2NrX2Rv
bWFpbihwcmV2X2RvbSk7CisKKyAgICByZXR1cm4gcmMgPzogcGRldiAmJiBw
cmV2X2RvbTsKIH0KIAogc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1h
cChzdHJ1Y3QgZG9tYWluICpkLCB1aW50OF90IGRldmZuLApAQCAtMTQ4MSw4
ICsxNTg5LDEwIEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGlu
ZyhzdHJ1Y3QKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz
dHJ1Y3QgcGNpX2RldiAqcGRldikKIHsKICAgICBzdHJ1Y3QgYWNwaV9kcmhk
X3VuaXQgKmRyaGQ7CisgICAgY29uc3Qgc3RydWN0IGFjcGlfcm1ycl91bml0
ICpybXJyOwogICAgIGludCByZXQgPSAwOwotICAgIHVpbnQxNl90IHNlZyA9
IHBkZXYtPnNlZzsKKyAgICB1bnNpZ25lZCBpbnQgaSwgbW9kZSA9IDA7Cisg
ICAgdWludDE2X3Qgc2VnID0gcGRldi0+c2VnLCBiZGY7CiAgICAgdWludDhf
dCBidXMgPSBwZGV2LT5idXMsIHNlY2J1czsKIAogICAgIGRyaGQgPSBhY3Bp
X2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CkBAIC0xNTAyLDggKzE2
MTIsMjkgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0
cnVjdAogCiAgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOwogCisgICAg
Zm9yX2VhY2hfcm1ycl9kZXZpY2UoIHJtcnIsIGJkZiwgaSApCisgICAgewor
ICAgICAgICBpZiAoIHJtcnItPnNlZ21lbnQgIT0gcGRldi0+c2VnIHx8IGJk
ZiAhPSBwZGV2LT5zYmRmLmJkZiApCisgICAgICAgICAgICBjb250aW51ZTsK
KworICAgICAgICBtb2RlIHw9IE1BUF9XSVRIX1JNUlI7CisgICAgICAgIGJy
ZWFrOworICAgIH0KKworICAgIGlmICggZG9tYWluICE9IHBkZXYtPmRvbWFp
biApCisgICAgeworICAgICAgICBpZiAoIHBkZXYtPmRvbWFpbi0+aXNfZHlp
bmcgKQorICAgICAgICAgICAgbW9kZSB8PSBNQVBfT1dORVJfRFlJTkc7Cisg
ICAgICAgIGVsc2UgaWYgKCBkcmhkICYmCisgICAgICAgICAgICAgICAgICAh
YW55X3BkZXZfYmVoaW5kX2lvbW11KHBkZXYtPmRvbWFpbiwgcGRldiwgZHJo
ZC0+aW9tbXUpICYmCisgICAgICAgICAgICAgICAgICAhcGRldi0+cGhhbnRv
bV9zdHJpZGUgKQorICAgICAgICAgICAgbW9kZSB8PSBNQVBfU0lOR0xFX0RF
VklDRTsKKyAgICB9CisKICAgICBzd2l0Y2ggKCBwZGV2LT50eXBlICkKICAg
ICB7CisgICAgICAgIGJvb2wgcHJldl9wcmVzZW50OworCiAgICAgY2FzZSBE
RVZfVFlQRV9QQ0lfSE9TVF9CUklER0U6CiAgICAgICAgIGlmICggaW9tbXVf
ZGVidWcgKQogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiZCVkOkhv
c3RicmlkZ2U6IHNraXAgJTA0eDolMDJ4OiUwMnguJXUgbWFwXG4iLApAQCAt
MTUyNCw3ICsxNjU1LDkgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9t
YXBwaW5nKHN0cnVjdAogICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9t
YWluX2lkLCBzZWcsIGJ1cywKICAgICAgICAgICAgICAgICAgICBQQ0lfU0xP
VChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7CiAgICAgICAgIHJldCA9IGRv
bWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUs
IGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHBkZXYpOworICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBwZGV2LCBtb2RlKTsKKyAgICAgICAgaWYgKCByZXQg
PiAwICkKKyAgICAgICAgICAgIHJldCA9IDA7CiAgICAgICAgIGlmICggIXJl
dCAmJiBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBhdHNfZGV2aWNlKHBkZXYs
IGRyaGQpID4gMCApCiAgICAgICAgICAgICBlbmFibGVfYXRzX2RldmljZShw
ZGV2LCAmZHJoZC0+aW9tbXUtPmF0c19kZXZpY2VzKTsKIApAQCAtMTUzNyw5
ICsxNjcwLDEwIEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGlu
ZyhzdHJ1Y3QKICAgICAgICAgICAgICAgICAgICBQQ0lfU0xPVChkZXZmbiks
IFBDSV9GVU5DKGRldmZuKSk7CiAKICAgICAgICAgcmV0ID0gZG9tYWluX2Nv
bnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBk
ZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgcGRldik7Ci0gICAgICAgIGlmICggcmV0ICkKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRldiwgbW9kZSk7CisgICAg
ICAgIGlmICggcmV0IDwgMCApCiAgICAgICAgICAgICBicmVhazsKKyAgICAg
ICAgcHJldl9wcmVzZW50ID0gcmV0OwogCiAgICAgICAgIGlmICggKHJldCA9
IGZpbmRfdXBzdHJlYW1fYnJpZGdlKHNlZywgJmJ1cywgJmRldmZuLCAmc2Vj
YnVzKSkgPCAxICkKICAgICAgICAgewpAQCAtMTU0Nyw2ICsxNjgxLDE1IEBA
IHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAg
ICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIHJldCA9IC1FTlhJ
TzsKICAgICAgICAgfQorICAgICAgICAvKgorICAgICAgICAgKiBTdHJpY3Rs
eSBzcGVha2luZyBpZiB0aGUgZGV2aWNlIGlzIHRoZSBvbmx5IG9uZSBiZWhp
bmQgdGhpcyBicmlkZ2UKKyAgICAgICAgICogYW5kIHRoZSBvbmx5IG9uZSB3
aXRoIHRoaXMgKHNlY2J1cywwLDApIHR1cGxlLCBpdCBjb3VsZCBiZSBhbGxv
d2VkCisgICAgICAgICAqIHRvIGJlIHJlLWFzc2lnbmVkIHJlZ2FyZGxlc3Mg
b2YgUk1SUiBwcmVzZW5jZS4gIEJ1dCBsZXQncyBkZWFsIHdpdGgKKyAgICAg
ICAgICogdGhhdCBjYXNlIG9ubHkgaWYgaXQgaXMgYWN0dWFsbHkgZm91bmQg
aW4gdGhlIHdpbGQuCisgICAgICAgICAqLworICAgICAgICBlbHNlIGlmICgg
cHJldl9wcmVzZW50ICYmIChtb2RlICYgTUFQX1dJVEhfUk1SUikgJiYKKyAg
ICAgICAgICAgICAgICAgIGRvbWFpbiAhPSBwZGV2LT5kb21haW4gKQorICAg
ICAgICAgICAgcmV0ID0gLUVPUE5PVFNVUFA7CiAKICAgICAgICAgLyoKICAg
ICAgICAgICogTWFwcGluZyBhIGJyaWRnZSBzaG91bGQsIGlmIGFueXRoaW5n
LCBwYXNzIHRoZSBzdHJ1Y3QgcGNpX2RldiBvZgpAQCAtMTU1NSw3ICsxNjk4
LDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVj
dAogICAgICAgICAgKi8KICAgICAgICAgaWYgKCByZXQgPj0gMCApCiAgICAg
ICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21h
aW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCk7CisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBt
b2RlKTsKIAogICAgICAgICAvKgogICAgICAgICAgKiBEZXZpY2VzIGJlaGlu
ZCBQQ0llLXRvLVBDSS9QQ0l4IGJyaWRnZSBtYXkgZ2VuZXJhdGUgZGlmZmVy
ZW50CkBAIC0xNTcwLDEwICsxNzEzLDE1IEBAIHN0YXRpYyBpbnQgZG9tYWlu
X2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgaWYgKCAhcmV0ICYm
IHBkZXZfdHlwZShzZWcsIGJ1cywgZGV2Zm4pID09IERFVl9UWVBFX1BDSWUy
UENJX0JSSURHRSAmJgogICAgICAgICAgICAgIChzZWNidXMgIT0gcGRldi0+
YnVzIHx8IHBkZXYtPmRldmZuICE9IDApICkKICAgICAgICAgICAgIHJldCA9
IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9t
bXUsIHNlY2J1cywgMCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIE5VTEwpOworICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgbW9kZSk7CiAKICAgICAg
ICAgaWYgKCByZXQgKQotICAgICAgICAgICAgZG9tYWluX2NvbnRleHRfdW5t
YXAoZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgICAgIHsKKyAgICAgICAg
ICAgIGlmICggIXByZXZfcHJlc2VudCApCisgICAgICAgICAgICAgICAgZG9t
YWluX2NvbnRleHRfdW5tYXAoZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAg
ICAgICAgICBlbHNlIGlmICggcGRldi0+ZG9tYWluICE9IGRvbWFpbiApIC8q
IEF2b2lkIGluZmluaXRlIHJlY3Vyc2lvbi4gKi8KKyAgICAgICAgICAgICAg
ICBkb21haW5fY29udGV4dF9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgZGV2Zm4s
IHBkZXYpOworICAgICAgICB9CiAKICAgICAgICAgYnJlYWs7CiAKQEAgLTIz
NTIsOSArMjUwMCw4IEBAIHN0YXRpYyBpbnQgcmVhc3NpZ25fZGV2aWNlX293
bmVyc2hpcCgKIHsKICAgICBpbnQgcmV0OwogCi0gICAgcmV0ID0gZG9tYWlu
X2NvbnRleHRfdW5tYXAoc291cmNlLCBkZXZmbiwgcGRldik7Ci0gICAgaWYg
KCByZXQgKQotICAgICAgICByZXR1cm4gcmV0OworICAgIGlmICggIWhhc19h
cmNoX3BkZXZzKHRhcmdldCkgKQorICAgICAgICB2bXhfcGlfaG9va3NfYXNz
aWduKHRhcmdldCk7CiAKICAgICAvKgogICAgICAqIERldmljZXMgYXNzaWdu
ZWQgdG8gdW50cnVzdGVkIGRvbWFpbnMgKGhlcmUgYXNzdW1lZCB0byBiZSBh
bnkgZG9tVSkKQEAgLTIzNjQsNiArMjUxMSwzMSBAQCBzdGF0aWMgaW50IHJl
YXNzaWduX2RldmljZV9vd25lcnNoaXAoCiAgICAgaWYgKCAodGFyZ2V0ICE9
IGhhcmR3YXJlX2RvbWFpbikgJiYgIWlvbW11X2ludHJlbWFwICkKICAgICAg
ICAgdW50cnVzdGVkX21zaSA9IHRydWU7CiAKKyAgICByZXQgPSBkb21haW5f
Y29udGV4dF9tYXBwaW5nKHRhcmdldCwgZGV2Zm4sIHBkZXYpOworICAgIGlm
ICggcmV0ICkKKyAgICB7CisgICAgICAgIGlmICggIWhhc19hcmNoX3BkZXZz
KHRhcmdldCkgKQorICAgICAgICAgICAgdm14X3BpX2hvb2tzX2RlYXNzaWdu
KHRhcmdldCk7CisgICAgICAgIHJldHVybiByZXQ7CisgICAgfQorCisgICAg
aWYgKCBwZGV2LT5kZXZmbiA9PSBkZXZmbiApCisgICAgeworICAgICAgICBj
b25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQgPSBhY3BpX2ZpbmRf
bWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CisKKyAgICAgICAgaWYgKCBkcmhk
ICkKKyAgICAgICAgICAgIGNoZWNrX2NsZWFudXBfZG9taWRfbWFwKHNvdXJj
ZSwgcGRldiwgZHJoZC0+aW9tbXUpOworICAgIH0KKworICAgIGlmICggZGV2
Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWluICE9IHRhcmdldCAp
CisgICAgeworICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0
LCAmdGFyZ2V0LT5wZGV2X2xpc3QpOworICAgICAgICBwZGV2LT5kb21haW4g
PSB0YXJnZXQ7CisgICAgfQorCisgICAgaWYgKCAhaGFzX2FyY2hfcGRldnMo
c291cmNlKSApCisgICAgICAgIHZteF9waV9ob29rc19kZWFzc2lnbihzb3Vy
Y2UpOworCiAgICAgLyoKICAgICAgKiBJZiB0aGUgZGV2aWNlIGJlbG9uZ3Mg
dG8gdGhlIGhhcmR3YXJlIGRvbWFpbiwgYW5kIGl0IGhhcyBSTVJSLCBkb24n
dAogICAgICAqIHJlbW92ZSBpdCBmcm9tIHRoZSBoYXJkd2FyZSBkb21haW4s
IGJlY2F1c2UgQklPUyBtYXkgdXNlIFJNUlIgYXQKQEAgLTIzOTIsMzQgKzI1
NjQsNyBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNoaXAo
CiAgICAgICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKCBkZXZmbiA9PSBw
ZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkKLSAgICB7
Ci0gICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZkb21f
aW8tPnBkZXZfbGlzdCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9IGRvbV9p
bzsKLSAgICB9Ci0KLSAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyhzb3VyY2Up
ICkKLSAgICAgICAgdm14X3BpX2hvb2tzX2RlYXNzaWduKHNvdXJjZSk7Ci0K
LSAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyh0YXJnZXQpICkKLSAgICAgICAg
dm14X3BpX2hvb2tzX2Fzc2lnbih0YXJnZXQpOwotCi0gICAgcmV0ID0gZG9t
YWluX2NvbnRleHRfbWFwcGluZyh0YXJnZXQsIGRldmZuLCBwZGV2KTsKLSAg
ICBpZiAoIHJldCApCi0gICAgewotICAgICAgICBpZiAoICFoYXNfYXJjaF9w
ZGV2cyh0YXJnZXQpICkKLSAgICAgICAgICAgIHZteF9waV9ob29rc19kZWFz
c2lnbih0YXJnZXQpOwotCi0gICAgICAgIHJldHVybiByZXQ7Ci0gICAgfQot
Ci0gICAgaWYgKCBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21h
aW4gIT0gdGFyZ2V0ICkKLSAgICB7Ci0gICAgICAgIGxpc3RfbW92ZSgmcGRl
di0+ZG9tYWluX2xpc3QsICZ0YXJnZXQtPnBkZXZfbGlzdCk7Ci0gICAgICAg
IHBkZXYtPmRvbWFpbiA9IHRhcmdldDsKLSAgICB9Ci0KLSAgICByZXR1cm4g
cmV0OworICAgIHJldHVybiAwOwogfQogCiBzdGF0aWMgaW50IGludGVsX2lv
bW11X2Fzc2lnbl9kZXZpY2UoCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3Z0ZC9pb21tdS5oCkBAIC0yMDIsOCArMjAyLDEyIEBAIHN0cnVjdCByb290
X2VudHJ5IHsKICAgICBkbyB7KHJvb3QpLnZhbCB8PSAoKHZhbHVlKSAmIFBB
R0VfTUFTS180Syk7fSB3aGlsZSgwKQogCiBzdHJ1Y3QgY29udGV4dF9lbnRy
eSB7Ci0gICAgdTY0IGxvOwotICAgIHU2NCBoaTsKKyAgICB1bmlvbiB7Cisg
ICAgICAgIHN0cnVjdCB7CisgICAgICAgICAgICB1aW50NjRfdCBsbywgaGk7
CisgICAgICAgIH07CisgICAgICAgIF9fdWludDEyOF90IGZ1bGw7CisgICAg
fTsKIH07CiAjZGVmaW5lIFJPT1RfRU5UUllfTlIgKFBBR0VfU0laRV80Sy9z
aXplb2Yoc3RydWN0IHJvb3RfZW50cnkpKQogI2RlZmluZSBjb250ZXh0X3By
ZXNlbnQoYykgKChjKS5sbyAmIDEpCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9xdWlya3MuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC92dGQvcXVpcmtzLmMKQEAgLTM0NCw3ICszNDQsOCBAQCB2b2lkIF9f
aW5pdCBwbGF0Zm9ybV9xdWlya3NfaW5pdCh2b2lkKQogICovCiAKIHN0YXRp
YyBpbnQgX19tdXN0X2NoZWNrIG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKHN0
cnVjdCBkb21haW4gKmRvbWFpbiwKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHUzMiBkZXYsIGludCBtYXApCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICB1bnNpZ25lZCBpbnQgZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG1vZGUpCiB7
CiAgICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwogICAgIHN0cnVj
dCBwY2lfZGV2ICpwZGV2OwpAQCAtMzU1LDkgKzM1Niw5IEBAIHN0YXRpYyBp
bnQgX19tdXN0X2NoZWNrIG1hcF9tZV9waGFudG9tX2YKICAgICBkcmhkID0g
YWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYpOwogCiAgICAgLyog
bWFwIG9yIHVubWFwIE1FIHBoYW50b20gZnVuY3Rpb24gKi8KLSAgICBpZiAo
IG1hcCApCisgICAgaWYgKCAhKG1vZGUgJiBVTk1BUF9NRV9QSEFOVE9NX0ZV
TkMpICkKICAgICAgICAgcmMgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29u
ZShkb21haW4sIGRyaGQtPmlvbW11LCAwLAotICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpLCBOVUxM
KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQ
Q0lfREVWRk4oZGV2LCA3KSwgTlVMTCwgbW9kZSk7CiAgICAgZWxzZQogICAg
ICAgICByYyA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGRy
aGQtPmlvbW11LCAwLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBQQ0lfREVWRk4oZGV2LCA3KSk7CkBAIC0zNjUsNyArMzY2LDgg
QEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgbWFwX21lX3BoYW50b21fZgog
ICAgIHJldHVybiByYzsKIH0KIAotaW50IG1lX3dpZmlfcXVpcmsoc3RydWN0
IGRvbWFpbiAqZG9tYWluLCB1OCBidXMsIHU4IGRldmZuLCBpbnQgbWFwKQor
aW50IG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLCB1aW50
OF90IGJ1cywgdWludDhfdCBkZXZmbiwKKyAgICAgICAgICAgICAgICAgIHVu
c2lnbmVkIGludCBtb2RlKQogewogICAgIHUzMiBpZDsKICAgICBpbnQgcmMg
PSAwOwpAQCAtMzg5LDcgKzM5MSw3IEBAIGludCBtZV93aWZpX3F1aXJrKHN0
cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICAgICAgICAgIGNhc2UgMHg0MjNi
ODA4NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjNjODA4NjoKICAgICAgICAg
ICAgIGNhc2UgMHg0MjNkODA4NjoKLSAgICAgICAgICAgICAgICByYyA9IG1h
cF9tZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMywgbWFwKTsKKyAgICAg
ICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFp
biwgMywgbW9kZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg
ICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIGJyZWFrOwpAQCAtNDE1
LDcgKzQxNyw3IEBAIGludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4g
KmRvbWFpbiwKICAgICAgICAgICAgIGNhc2UgMHg0MjM4ODA4NjogICAgICAg
IC8qIFB1bWEgUGVhayAqLwogICAgICAgICAgICAgY2FzZSAweDQyMmI4MDg2
OgogICAgICAgICAgICAgY2FzZSAweDQyMmM4MDg2OgotICAgICAgICAgICAg
ICAgIHJjID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAyMiwg
bWFwKTsKKyAgICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1
bmN0aW9uKGRvbWFpbiwgMjIsIG1vZGUpOwogICAgICAgICAgICAgICAgIGJy
ZWFrOwogICAgICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICBi
cmVhazsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL3Z0ZC5o
CisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC92dGQuaApAQCAt
MjIsOCArMjIsMTQgQEAKIAogI2luY2x1ZGUgPHhlbi9pb21tdS5oPgogCi0j
ZGVmaW5lIE1BUF9NRV9QSEFOVE9NX0ZVTkMgICAgICAxCi0jZGVmaW5lIFVO
TUFQX01FX1BIQU5UT01fRlVOQyAgICAwCisvKgorICogVmFsdWVzIGZvciBk
b21haW5fY29udGV4dF9tYXBwaW5nX29uZSgpJ3MgYW5kIG1lX3dpZmlfcXVp
cmsoKSdzICJtb2RlIgorICogcGFyYW1ldGVycy4KKyAqLworI2RlZmluZSBN
QVBfV0lUSF9STVJSICAgICAgICAgKDF1IDw8IDApCisjZGVmaW5lIE1BUF9P
V05FUl9EWUlORyAgICAgICAoMXUgPDwgMSkKKyNkZWZpbmUgTUFQX1NJTkdM
RV9ERVZJQ0UgICAgICgxdSA8PCAyKQorI2RlZmluZSBVTk1BUF9NRV9QSEFO
VE9NX0ZVTkMgKDF1IDw8IDMpCiAKIC8qIEFsbG93IGZvciBib3RoIElPQVBJ
QyBhbmQgSU9TQVBJQy4gKi8KICNkZWZpbmUgSU9feEFQSUNfcm91dGVfZW50
cnkgSU9fQVBJQ19yb3V0ZV9lbnRyeQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-05.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IHJlLWFzc2lnbiBkZXZpY2VzIGRpcmVjdGx5CgpEZXZp
Y2VzIHdpdGggdW5pdHkgbWFwIHJhbmdlcywgZHVlIHRvIGl0IGJlaW5nIHVu
c3BlY2lmaWVkIGhvdy93aGVuCnRoZXNlIG1lbW9yeSByYW5nZXMgbWF5IGdl
dCBhY2Nlc3NlZCwgbWF5IG5vdCBiZSBsZWZ0IGRpc2Nvbm5lY3RlZCBmcm9t
CnRoZWlyIHVuaXR5IG1hcHBpbmdzIChhcyBsb25nIGFzIGl0J3Mgbm90IGNl
cnRhaW4gdGhhdCB0aGUgZGV2aWNlIGhhcwpiZWVuIGZ1bGx5IHF1aWVzY2Vk
KS4gSGVuY2UgcmF0aGVyIHRoYW4gdGVhcmluZyBkb3duIHRoZSBvbGQgcm9v
dCBwYWdlCnRhYmxlIHBvaW50ZXIgYW5kIHRoZW4gZXN0YWJsaXNoaW5nIHRo
ZSBuZXcgb25lLCByZS1hc3NpZ25tZW50IG5lZWRzIHRvCmJlIGRvbmUgaW4g
YSBzaW5nbGUgc3RlcC4KClRoaXMgaXMgQ1ZFLTIwMjItMjYzNjAgLyBwYXJ0
IG9mIFhTQS00MDAuCgpSZXBvcnRlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8
cm9nZXIucGF1QGNpdHJpeC5jb20+CgpTaW1pbGFybHkgcXVhcmFudGluaW5n
IHNjcmF0Y2gtcGFnZSBtb2RlIHJlbGllcyBvbiBwYWdlIHRhYmxlcyB0byBi
ZQpjb250aW51b3VzbHkgd2lyZWQgdXAuCgpUbyBhdm9pZCBjb21wbGljYXRp
bmcgdGhpbmdzIG1vcmUgdGhhbiBuZWNlc3NhcnksIHRyZWF0IGFsbCBkZXZp
Y2VzCm1vc3RseSBlcXVhbGx5LCBpLmUuIHJlZ2FyZGxlc3Mgb2YgdGhlaXIg
YXNzb2NpYXRpb24gd2l0aCBhbnkgdW5pdHkgbWFwCnJhbmdlcy4gIFRoZSBt
YWluIGRpZmZlcmVuY2UgaXMgd2hlbiBpdCBjb21lcyB0byB1cGRhdGluZyBE
VEVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21pYyB3aGVuIHRoZXJlIGFyZSB1
bml0eSBtYXBwaW5ncy4gWWV0IGF0b21pY2l0eSBjYW4gb25seSBiZQphY2hp
ZXZlZCB3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBvZiB3aGljaCB3
ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwg
RHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+CgotLS0gYS94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUuaAorKysgYi94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUuaApAQCAtMjQ3LDkgKzI0NywxMyBA
QCB2b2lkIGFtZF9pb21tdV9zZXRfaW50cmVtYXBfdGFibGUoc3RydWN0CiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgdm9pZCAq
cHRyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0
IHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LAogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGJvb2wgdmFsaWQpOwotdm9pZCBhbWRfaW9tbXVf
c2V0X3Jvb3RfcGFnZV90YWJsZShzdHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRl
LAotCQkJCSAgIHVpbnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBkb21haW5f
aWQsCi0JCQkJICAgdWludDhfdCBwYWdpbmdfbW9kZSwgYm9vbCB2YWxpZCk7
CisjZGVmaW5lIFNFVF9ST09UX1ZBTElEICAgICAgICAgICgxdSA8PCAwKQor
I2RlZmluZSBTRVRfUk9PVF9XSVRIX1VOSVRZX01BUCAoMXUgPDwgMSkKK2lu
dCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUo
c3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3Qgcm9vdF9w
dHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHVpbnQxNl90IGRvbWFpbl9pZCwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBwYWdpbmdf
bW9kZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgdW5zaWduZWQgaW50IGZsYWdzKTsKIHZvaWQgaW9tbXVfZHRl
X2FkZF9kZXZpY2VfZW50cnkoc3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0
IGl2cnNfbWFwcGluZ3MgKml2cnNfZGV2KTsKIHZvaWQgaW9tbXVfZHRlX3Nl
dF9ndWVzdF9jcjMoc3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwgdWludDE2
X3QgZG9tX2lkLAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQv
aW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1k
L2lvbW11X21hcC5jCkBAIC05OSwxMCArOTksNjkgQEAgc3RhdGljIHVuc2ln
bmVkIGludCBzZXRfaW9tbXVfcHRlX3ByZXNlbgogICAgIHJldHVybiBmbHVz
aF9mbGFnczsKIH0KIAotdm9pZCBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90
YWJsZShzdHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRlLAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCByb290X3B0ciwgdWlu
dDE2X3QgZG9tYWluX2lkLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB1aW50OF90IHBhZ2luZ19tb2RlLCBib29sIHZhbGlkKQorLyoK
KyAqIFRoaXMgZnVuY3Rpb24gcmV0dXJucworICogLSAtZXJybm8gZm9yIGVy
cm9ycywKKyAqIC0gMCBmb3IgYSBzdWNjZXNzZnVsIHVwZGF0ZSwgYXRvbWlj
IHdoZW4gbmVjZXNzYXJ5CisgKiAtIDEgZm9yIGEgc3VjY2Vzc2Z1bCBidXQg
bm9uLWF0b21pYyB1cGRhdGUsIHdoaWNoIG1heSBuZWVkIHRvIGJlIHdhcm5l
ZAorICogICBhYm91dCBieSB0aGUgY2FsbGVyLgorICovCitpbnQgYW1kX2lv
bW11X3NldF9yb290X3BhZ2VfdGFibGUoc3RydWN0IGFtZF9pb21tdV9kdGUg
KmR0ZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50
NjRfdCByb290X3B0ciwgdWludDE2X3QgZG9tYWluX2lkLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgcGFnaW5nX21vZGUs
IHVuc2lnbmVkIGludCBmbGFncykKIHsKKyAgICBib29sIHZhbGlkID0gZmxh
Z3MgJiBTRVRfUk9PVF9WQUxJRDsKKworICAgIGlmICggZHRlLT52ICYmIGR0
ZS0+dHYgJiYKKyAgICAgICAgIChjcHVfaGFzX2N4MTYgfHwgKGZsYWdzICYg
U0VUX1JPT1RfV0lUSF9VTklUWV9NQVApKSApCisgICAgeworICAgICAgICB1
bmlvbiB7CisgICAgICAgICAgICBzdHJ1Y3QgYW1kX2lvbW11X2R0ZSBkdGU7
CisgICAgICAgICAgICB1aW50NjRfdCByYXc2NFs0XTsKKyAgICAgICAgICAg
IF9fdWludDEyOF90IHJhdzEyOFsyXTsKKyAgICAgICAgfSBsZHRlID0geyAu
ZHRlID0gKmR0ZSB9OworICAgICAgICBfX3VpbnQxMjhfdCBvbGQgPSBsZHRl
LnJhdzEyOFswXTsKKyAgICAgICAgaW50IHJldCA9IDA7CisKKyAgICAgICAg
bGR0ZS5kdGUuZG9tYWluX2lkID0gZG9tYWluX2lkOworICAgICAgICBsZHRl
LmR0ZS5wdF9yb290ID0gcGFkZHJfdG9fcGZuKHJvb3RfcHRyKTsKKyAgICAg
ICAgbGR0ZS5kdGUuaXcgPSB0cnVlOworICAgICAgICBsZHRlLmR0ZS5pciA9
IHRydWU7CisgICAgICAgIGxkdGUuZHRlLnBhZ2luZ19tb2RlID0gcGFnaW5n
X21vZGU7CisgICAgICAgIGxkdGUuZHRlLnYgPSB2YWxpZDsKKworICAgICAg
ICBpZiAoIGNwdV9oYXNfY3gxNiApCisgICAgICAgIHsKKyAgICAgICAgICAg
IF9fdWludDEyOF90IHJlcyA9IGNtcHhjaGcxNmIoZHRlLCAmb2xkLCAmbGR0
ZS5yYXcxMjhbMF0pOworCisgICAgICAgICAgICAvKgorICAgICAgICAgICAg
ICogSGFyZHdhcmUgZG9lcyBub3QgdXBkYXRlIHRoZSBEVEUgYmVoaW5kIG91
ciBiYWNrcywgc28gdGhlCisgICAgICAgICAgICAgKiByZXR1cm4gdmFsdWUg
c2hvdWxkIG1hdGNoICJvbGQiLgorICAgICAgICAgICAgICovCisgICAgICAg
ICAgICBpZiAoIHJlcyAhPSBvbGQgKQorICAgICAgICAgICAgeworICAgICAg
ICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSCisgICAgICAgICAgICAgICAg
ICAgICAgICJEb20lZDogdW5leHBlY3RlZCBEVEUgJTAxNmx4XyUwMTZseCAo
ZXhwZWN0ZWQgJTAxNmx4XyUwMTZseClcbiIsCisgICAgICAgICAgICAgICAg
ICAgICAgIGRvbWFpbl9pZCwKKyAgICAgICAgICAgICAgICAgICAgICAgKHVp
bnQ2NF90KShyZXMgPj4gNjQpLCAodWludDY0X3QpcmVzLAorICAgICAgICAg
ICAgICAgICAgICAgICAodWludDY0X3QpKG9sZCA+PiA2NCksICh1aW50NjRf
dClvbGQpOworICAgICAgICAgICAgICAgIHJldCA9IC1FSUxTRVE7CisgICAg
ICAgICAgICB9CisgICAgICAgIH0KKyAgICAgICAgZWxzZSAvKiBCZXN0IGVm
Zm9ydCwgdXBkYXRpbmcgZG9tYWluX2lkIGxhc3QuICovCisgICAgICAgIHsK
KyAgICAgICAgICAgIHVpbnQ2NF90ICpwdHIgPSAodm9pZCAqKWR0ZTsKKwor
ICAgICAgICAgICAgd3JpdGVfYXRvbWljKHB0ciArIDAsIGxkdGUucmF3NjRb
MF0pOworICAgICAgICAgICAgLyogTm8gYmFycmllciBzaG91bGQgYmUgbmVl
ZGVkIGJldHdlZW4gdGhlc2UgdHdvLiAqLworICAgICAgICAgICAgd3JpdGVf
YXRvbWljKHB0ciArIDEsIGxkdGUucmF3NjRbMV0pOworCisgICAgICAgICAg
ICByZXQgPSAxOworICAgICAgICB9CisKKyAgICAgICAgcmV0dXJuIHJldDsK
KyAgICB9CisKICAgICBpZiAoIHZhbGlkIHx8IGR0ZS0+diApCiAgICAgewog
ICAgICAgICBkdGUtPnR2ID0gZmFsc2U7CkBAIC0xMTcsNiArMTc2LDggQEAg
dm9pZCBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZShzdHJ1YwogICAg
IHNtcF93bWIoKTsKICAgICBkdGUtPnR2ID0gdHJ1ZTsKICAgICBkdGUtPnYg
PSB2YWxpZDsKKworICAgIHJldHVybiAwOwogfQogCiB2b2lkIGFtZF9pb21t
dV9zZXRfaW50cmVtYXBfdGFibGUoCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYwpAQCAtODIsNDAgKzgy
LDgxIEBAIGludCBnZXRfZG1hX3JlcXVlc3Rvcl9pZCh1aW50MTZfdCBzZWcs
IHUKICAgICByZXR1cm4gcmVxX2lkOwogfQogCi1zdGF0aWMgdm9pZCBhbWRf
aW9tbXVfc2V0dXBfZG9tYWluX2RldmljZSgKK3N0YXRpYyBpbnQgX19tdXN0
X2NoZWNrIGFsbG9jYXRlX2RvbWFpbl9yZXNvdXJjZXMoc3RydWN0IGRvbWFp
bl9pb21tdSAqaGQpCit7CisgICAgaW50IHJjOworCisgICAgc3Bpbl9sb2Nr
KCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOworICAgIHJjID0gYW1kX2lvbW11
X2FsbG9jX3Jvb3QoaGQpOworICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5t
YXBwaW5nX2xvY2spOworCisgICAgcmV0dXJuIHJjOworfQorCitzdGF0aWMg
Ym9vbCBhbnlfcGRldl9iZWhpbmRfaW9tbXUoY29uc3Qgc3RydWN0IGRvbWFp
biAqZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z
dCBzdHJ1Y3QgcGNpX2RldiAqZXhjbHVkZSwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgYW1kX2lvbW11ICppb21t
dSkKK3sKKyAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldjsKKworICAg
IGZvcl9lYWNoX3BkZXYgKCBkLCBwZGV2ICkKKyAgICB7CisgICAgICAgIGlm
ICggcGRldiA9PSBleGNsdWRlICkKKyAgICAgICAgICAgIGNvbnRpbnVlOwor
CisgICAgICAgIGlmICggZmluZF9pb21tdV9mb3JfZGV2aWNlKHBkZXYtPnNl
ZywgcGRldi0+c2JkZi5iZGYpID09IGlvbW11ICkKKyAgICAgICAgICAgIHJl
dHVybiB0cnVlOworICAgIH0KKworICAgIHJldHVybiBmYWxzZTsKK30KKwor
c3RhdGljIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwX2RvbWFp
bl9kZXZpY2UoCiAgICAgc3RydWN0IGRvbWFpbiAqZG9tYWluLCBzdHJ1Y3Qg
YW1kX2lvbW11ICppb21tdSwKICAgICB1aW50OF90IGRldmZuLCBzdHJ1Y3Qg
cGNpX2RldiAqcGRldikKIHsKICAgICBzdHJ1Y3QgYW1kX2lvbW11X2R0ZSAq
dGFibGUsICpkdGU7CiAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKLSAgICBp
bnQgcmVxX2lkLCB2YWxpZCA9IDE7CisgICAgdW5zaWduZWQgaW50IHJlcV9p
ZCwgc3JfZmxhZ3M7CisgICAgaW50IHJjOwogICAgIHU4IGJ1cyA9IHBkZXYt
PmJ1czsKLSAgICBjb25zdCBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRv
bV9pb21tdShkb21haW4pOworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhk
ID0gZG9tX2lvbW11KGRvbWFpbik7CisgICAgY29uc3Qgc3RydWN0IGl2cnNf
bWFwcGluZ3MgKml2cnNfZGV2OwogCi0gICAgQlVHX09OKCAhaGQtPmFyY2gu
cm9vdF90YWJsZSB8fCAhaGQtPmFyY2gucGFnaW5nX21vZGUgfHwKLSAgICAg
ICAgICAgICFpb21tdS0+ZGV2X3RhYmxlLmJ1ZmZlciApOworICAgIEJVR19P
TighaGQtPmFyY2gucGFnaW5nX21vZGUgfHwgIWlvbW11LT5kZXZfdGFibGUu
YnVmZmVyKTsKIAotICAgIGlmICggaW9tbXVfaHdkb21fcGFzc3Rocm91Z2gg
JiYgaXNfaGFyZHdhcmVfZG9tYWluKGRvbWFpbikgKQotICAgICAgICB2YWxp
ZCA9IDA7CisgICAgcmMgPSBhbGxvY2F0ZV9kb21haW5fcmVzb3VyY2VzKGhk
KTsKKyAgICBpZiAoIHJjICkKKyAgICAgICAgcmV0dXJuIHJjOworCisgICAg
cmVxX2lkID0gZ2V0X2RtYV9yZXF1ZXN0b3JfaWQoaW9tbXUtPnNlZywgcGRl
di0+c2JkZi5iZGYpOworICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21hcHBp
bmdzKGlvbW11LT5zZWcpW3JlcV9pZF07CisgICAgc3JfZmxhZ3MgPSAoaW9t
bXVfaHdkb21fcGFzc3Rocm91Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWluKGRv
bWFpbikKKyAgICAgICAgICAgICAgICA/IDAgOiBTRVRfUk9PVF9WQUxJRCkK
KyAgICAgICAgICAgICAgIHwgKGl2cnNfZGV2LT51bml0eV9tYXAgPyBTRVRf
Uk9PVF9XSVRIX1VOSVRZX01BUCA6IDApOwogCiAgICAgLyogZ2V0IGRldmlj
ZS10YWJsZSBlbnRyeSAqLwogICAgIHJlcV9pZCA9IGdldF9kbWFfcmVxdWVz
dG9yX2lkKGlvbW11LT5zZWcsIFBDSV9CREYyKGJ1cywgZGV2Zm4pKTsKICAg
ICB0YWJsZSA9IGlvbW11LT5kZXZfdGFibGUuYnVmZmVyOwogICAgIGR0ZSA9
ICZ0YWJsZVtyZXFfaWRdOworICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21h
cHBpbmdzKGlvbW11LT5zZWcpW3JlcV9pZF07CiAKICAgICBzcGluX2xvY2tf
aXJxc2F2ZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKIAogICAgIGlmICggIWR0
ZS0+diB8fCAhZHRlLT50diApCiAgICAgewotICAgICAgICBjb25zdCBzdHJ1
Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19kZXY7Ci0KICAgICAgICAgLyogYmlu
ZCBEVEUgdG8gZG9tYWluIHBhZ2UtdGFibGVzICovCi0gICAgICAgIGFtZF9p
b21tdV9zZXRfcm9vdF9wYWdlX3RhYmxlKAotICAgICAgICAgICAgZHRlLCBw
YWdlX3RvX21hZGRyKGhkLT5hcmNoLnJvb3RfdGFibGUpLCBkb21haW4tPmRv
bWFpbl9pZCwKLSAgICAgICAgICAgIGhkLT5hcmNoLnBhZ2luZ19tb2RlLCB2
YWxpZCk7CisgICAgICAgIHJjID0gYW1kX2lvbW11X3NldF9yb290X3BhZ2Vf
dGFibGUoCisgICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkciho
ZC0+YXJjaC5yb290X3RhYmxlKSwKKyAgICAgICAgICAgICAgICAgZG9tYWlu
LT5kb21haW5faWQsIGhkLT5hcmNoLnBhZ2luZ19tb2RlLCBzcl9mbGFncyk7
CisgICAgICAgIGlmICggcmMgKQorICAgICAgICB7CisgICAgICAgICAgICBB
U1NFUlQocmMgPCAwKTsKKyAgICAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJl
c3RvcmUoJmlvbW11LT5sb2NrLCBmbGFncyk7CisgICAgICAgICAgICByZXR1
cm4gcmM7CisgICAgICAgIH0KIAogICAgICAgICAvKiBVbmRvIHdoYXQgYW1k
X2lvbW11X2Rpc2FibGVfZG9tYWluX2RldmljZSgpIG1heSBoYXZlIGRvbmUu
ICovCi0gICAgICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21hcHBpbmdzKGlv
bW11LT5zZWcpW3JlcV9pZF07CiAgICAgICAgIGlmICggZHRlLT5pdF9yb290
ICkKICAgICAgICAgewogICAgICAgICAgICAgZHRlLT5pbnRfY3RsID0gSU9N
TVVfREVWX1RBQkxFX0lOVF9DT05UUk9MX1RSQU5TTEFURUQ7CkBAIC0xMzAs
MTcgKzE3MSw3NCBAQCBzdGF0aWMgdm9pZCBhbWRfaW9tbXVfc2V0dXBfZG9t
YWluX2RldmljCiAgICAgICAgICAgICBkdGUtPmkgPSBhdHNfZW5hYmxlZDsK
IAogICAgICAgICBhbWRfaW9tbXVfZmx1c2hfZGV2aWNlKGlvbW11LCByZXFf
aWQpOworICAgIH0KKyAgICBlbHNlIGlmICggZHRlLT5wdF9yb290ICE9IG1m
bl94KHBhZ2VfdG9fbWZuKGhkLT5hcmNoLnJvb3RfdGFibGUpKSApCisgICAg
eworICAgICAgICAvKgorICAgICAgICAgKiBTdHJpY3RseSBzcGVha2luZyBp
ZiB0aGUgZGV2aWNlIGlzIHRoZSBvbmx5IG9uZSB3aXRoIHRoaXMgcmVxdWVz
dG9yCisgICAgICAgICAqIElELCBpdCBjb3VsZCBiZSBhbGxvd2VkIHRvIGJl
IHJlLWFzc2lnbmVkIHJlZ2FyZGxlc3Mgb2YgdW5pdHkgbWFwCisgICAgICAg
ICAqIHByZXNlbmNlLiAgQnV0IGxldCdzIGRlYWwgd2l0aCB0aGF0IGNhc2Ug
b25seSBpZiBpdCBpcyBhY3R1YWxseQorICAgICAgICAgKiBmb3VuZCBpbiB0
aGUgd2lsZC4KKyAgICAgICAgICovCisgICAgICAgIGlmICggcmVxX2lkICE9
IFBDSV9CREYyKGJ1cywgZGV2Zm4pICYmCisgICAgICAgICAgICAgKHNyX2Zs
YWdzICYgU0VUX1JPT1RfV0lUSF9VTklUWV9NQVApICkKKyAgICAgICAgICAg
IHJjID0gLUVPUE5PVFNVUFA7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAg
IHJjID0gYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoCisgICAgICAg
ICAgICAgICAgICAgICBkdGUsIHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2gucm9v
dF90YWJsZSksCisgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFp
bl9pZCwgaGQtPmFyY2gucGFnaW5nX21vZGUsIHNyX2ZsYWdzKTsKKyAgICAg
ICAgaWYgKCByYyA8IDAgKQorICAgICAgICB7CisgICAgICAgICAgICBzcGlu
X3VubG9ja19pcnFyZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3MpOworICAg
ICAgICAgICAgcmV0dXJuIHJjOworICAgICAgICB9CisgICAgICAgIGlmICgg
cmMgJiYKKyAgICAgICAgICAgICBkb21haW4gIT0gcGRldi0+ZG9tYWluICYm
CisgICAgICAgICAgICAgLyoKKyAgICAgICAgICAgICAgKiBCeSBub24tYXRv
bWljYWxseSB1cGRhdGluZyB0aGUgRFRFJ3MgZG9tYWluIElEIGZpZWxkIGxh
c3QsCisgICAgICAgICAgICAgICogZHVyaW5nIGEgc2hvcnQgd2luZG93IGlu
IHRpbWUgVExCIGVudHJpZXMgd2l0aCB0aGUgb2xkIGRvbWFpbgorICAgICAg
ICAgICAgICAqIElEIGJ1dCB0aGUgbmV3IHBhZ2UgdGFibGVzIG1heSBoYXZl
IGJlZW4gaW5zZXJ0ZWQuICBUaGlzIGNvdWxkCisgICAgICAgICAgICAgICog
YWZmZWN0IEkvTyBvZiBvdGhlciBkZXZpY2VzIHVzaW5nIHRoaXMgc2FtZSAo
b2xkKSBkb21haW4gSUQuCisgICAgICAgICAgICAgICogU3VjaCB1cGRhdGlu
ZyB0aGVyZWZvcmUgaXMgbm90IGEgcHJvYmxlbSBpZiB0aGlzIHdhcyB0aGUg
b25seQorICAgICAgICAgICAgICAqIGRldmljZSBhc3NvY2lhdGVkIHdpdGgg
dGhlIG9sZCBkb21haW4gSUQuICBEaXZlcnRpbmcgSS9PIG9mIGFueQorICAg
ICAgICAgICAgICAqIG9mIGEgZHlpbmcgZG9tYWluJ3MgZGV2aWNlcyB0byB0
aGUgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBpcworICAgICAgICAgICAgICAq
IGludGVuZGVkIGFueXdheS4KKyAgICAgICAgICAgICAgKi8KKyAgICAgICAg
ICAgICAhcGRldi0+ZG9tYWluLT5pc19keWluZyAmJgorICAgICAgICAgICAg
IChhbnlfcGRldl9iZWhpbmRfaW9tbXUocGRldi0+ZG9tYWluLCBwZGV2LCBp
b21tdSkgfHwKKyAgICAgICAgICAgICAgcGRldi0+cGhhbnRvbV9zdHJpZGUp
ICkKKyAgICAgICAgICAgIHByaW50aygiICUwNHg6JTAyeDolMDJ4LiV1OiBy
ZWFzc2lnbm1lbnQgbWF5IGNhdXNlICVwZCBkYXRhIGNvcnJ1cHRpb25cbiIs
CisgICAgICAgICAgICAgICAgICAgcGRldi0+c2VnLCBidXMsIFBDSV9TTE9U
KGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pLAorICAgICAgICAgICAgICAgICAg
IHBkZXYtPmRvbWFpbik7CisKKyAgICAgICAgLyoKKyAgICAgICAgICogQ2hl
Y2sgcmVtYWluaW5nIHNldHRpbmdzIGFyZSBzdGlsbCBpbiBwbGFjZSBmcm9t
IGFuIGVhcmxpZXIgY2FsbAorICAgICAgICAgKiBoZXJlLiBUaGV5J3JlIGFs
bCBpbmRlcGVuZGVudCBvZiB0aGUgZG9tYWluLCBzbyBzaG91bGQgbm90IGhh
dmUKKyAgICAgICAgICogY2hhbmdlZC4KKyAgICAgICAgICovCisgICAgICAg
IGlmICggZHRlLT5pdF9yb290ICkKKyAgICAgICAgICAgIEFTU0VSVChkdGUt
PmludF9jdGwgPT0gSU9NTVVfREVWX1RBQkxFX0lOVF9DT05UUk9MX1RSQU5T
TEFURUQpOworICAgICAgICBBU1NFUlQoZHRlLT5pdiA9PSBpb21tdV9pbnRy
ZW1hcCk7CisgICAgICAgIEFTU0VSVChkdGUtPmV4ID09IGl2cnNfZGV2LT5k
dGVfYWxsb3dfZXhjbHVzaW9uKTsKKyAgICAgICAgQVNTRVJUKGR0ZS0+c3lz
X21ndCA9PSBNQVNLX0VYVFIoaXZyc19kZXYtPmRldmljZV9mbGFncywKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQUNQSV9J
VkhEX1NZU1RFTV9NR01UKSk7CiAKLSAgICAgICAgQU1EX0lPTU1VX0RFQlVH
KCJTZXR1cCBJL08gcGFnZSB0YWJsZTogZGV2aWNlIGlkID0gJSN4LCB0eXBl
ID0gJSN4LCAiCi0gICAgICAgICAgICAgICAgICAgICAgICAicm9vdCB0YWJs
ZSA9ICUjIlBSSXg2NCIsICIKLSAgICAgICAgICAgICAgICAgICAgICAgICJk
b21haW4gPSAlZCwgcGFnaW5nIG1vZGUgPSAlZFxuIiwKLSAgICAgICAgICAg
ICAgICAgICAgICAgIHJlcV9pZCwgcGRldi0+dHlwZSwKLSAgICAgICAgICAg
ICAgICAgICAgICAgIHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2gucm9vdF90YWJs
ZSksCi0gICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9p
ZCwgaGQtPmFyY2gucGFnaW5nX21vZGUpOworICAgICAgICBpZiAoIHBjaV9h
dHNfZGV2aWNlKGlvbW11LT5zZWcsIGJ1cywgcGRldi0+ZGV2Zm4pICYmCisg
ICAgICAgICAgICAgaW9tbXVfaGFzX2NhcChpb21tdSwgUENJX0NBUF9JT1RM
Ql9TSElGVCkgKQorICAgICAgICAgICAgQVNTRVJUKGR0ZS0+aSA9PSBhdHNf
ZW5hYmxlZCk7CisKKyAgICAgICAgYW1kX2lvbW11X2ZsdXNoX2RldmljZShp
b21tdSwgcmVxX2lkKTsKICAgICB9CiAKICAgICBzcGluX3VubG9ja19pcnFy
ZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3MpOwogCisgICAgQU1EX0lPTU1V
X0RFQlVHKCJTZXR1cCBJL08gcGFnZSB0YWJsZTogZGV2aWNlIGlkID0gJSN4
LCB0eXBlID0gJSN4LCAiCisgICAgICAgICAgICAgICAgICAgICJyb290IHRh
YmxlID0gJSMiUFJJeDY0IiwgIgorICAgICAgICAgICAgICAgICAgICAiZG9t
YWluID0gJWQsIHBhZ2luZyBtb2RlID0gJWRcbiIsCisgICAgICAgICAgICAg
ICAgICAgIHJlcV9pZCwgcGRldi0+dHlwZSwKKyAgICAgICAgICAgICAgICAg
ICAgcGFnZV90b19tYWRkcihoZC0+YXJjaC5yb290X3RhYmxlKSwKKyAgICAg
ICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQsIGhkLT5hcmNoLnBh
Z2luZ19tb2RlKTsKKwogICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsK
IAogICAgIGlmICggcGNpX2F0c19kZXZpY2UoaW9tbXUtPnNlZywgYnVzLCBw
ZGV2LT5kZXZmbikgJiYKQEAgLTE1MSw2ICsyNDksOCBAQCBzdGF0aWMgdm9p
ZCBhbWRfaW9tbXVfc2V0dXBfZG9tYWluX2RldmljCiAKICAgICAgICAgYW1k
X2lvbW11X2ZsdXNoX2lvdGxiKGRldmZuLCBwZGV2LCBJTlZfSU9NTVVfQUxM
X1BBR0VTX0FERFJFU1MsIDApOwogICAgIH0KKworICAgIHJldHVybiAwOwog
fQogCiBpbnQgX19pbml0IGFjcGlfaXZyc19pbml0KHZvaWQpCkBAIC0yMTQs
MTcgKzMxNCw2IEBAIGludCBhbWRfaW9tbXVfYWxsb2Nfcm9vdChzdHJ1Y3Qg
ZG9tYWluX2kKICAgICByZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBfX211
c3RfY2hlY2sgYWxsb2NhdGVfZG9tYWluX3Jlc291cmNlcyhzdHJ1Y3QgZG9t
YWluX2lvbW11ICpoZCkKLXsKLSAgICBpbnQgcmM7Ci0KLSAgICBzcGluX2xv
Y2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7Ci0gICAgcmMgPSBhbWRfaW9t
bXVfYWxsb2Nfcm9vdChoZCk7Ci0gICAgc3Bpbl91bmxvY2soJmhkLT5hcmNo
Lm1hcHBpbmdfbG9jayk7Ci0KLSAgICByZXR1cm4gcmM7Ci19Ci0KIGludCBf
X3JlYWRfbW9zdGx5IGFtZF9pb21tdV9taW5fcGFnaW5nX21vZGUgPSAxOwog
CiBzdGF0aWMgaW50IGFtZF9pb21tdV9kb21haW5faW5pdChzdHJ1Y3QgZG9t
YWluICpkKQpAQCAtMzI0LDcgKzQxMyw2IEBAIHN0YXRpYyBpbnQgcmVhc3Np
Z25fZGV2aWNlKHN0cnVjdCBkb21haW4KIHsKICAgICBzdHJ1Y3QgYW1kX2lv
bW11ICppb21tdTsKICAgICBpbnQgYmRmLCByYzsKLSAgICBzdHJ1Y3QgZG9t
YWluX2lvbW11ICp0ID0gZG9tX2lvbW11KHRhcmdldCk7CiAgICAgY29uc3Qg
c3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBnZXRfaXZy
c19tYXBwaW5ncyhwZGV2LT5zZWcpOwogCiAgICAgYmRmID0gUENJX0JERjIo
cGRldi0+YnVzLCBwZGV2LT5kZXZmbik7CkBAIC0zMzgsNyArNDI2LDE1IEBA
IHN0YXRpYyBpbnQgcmVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4KICAg
ICAgICAgcmV0dXJuIC1FTk9ERVY7CiAgICAgfQogCi0gICAgYW1kX2lvbW11
X2Rpc2FibGVfZG9tYWluX2RldmljZShzb3VyY2UsIGlvbW11LCBkZXZmbiwg
cGRldik7CisgICAgcmMgPSBhbWRfaW9tbXVfc2V0dXBfZG9tYWluX2Rldmlj
ZSh0YXJnZXQsIGlvbW11LCBkZXZmbiwgcGRldik7CisgICAgaWYgKCByYyAp
CisgICAgICAgIHJldHVybiByYzsKKworICAgIGlmICggZGV2Zm4gPT0gcGRl
di0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWluICE9IHRhcmdldCApCisgICAgewor
ICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFyZ2V0
LT5wZGV2X2xpc3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7
CisgICAgfQogCiAgICAgLyoKICAgICAgKiBJZiB0aGUgZGV2aWNlIGJlbG9u
Z3MgdG8gdGhlIGhhcmR3YXJlIGRvbWFpbiwgYW5kIGl0IGhhcyBhIHVuaXR5
IG1hcHBpbmcsCkBAIC0zNTQsMjcgKzQ1MCwxMCBAQCBzdGF0aWMgaW50IHJl
YXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluCiAgICAgICAgICAgICByZXR1
cm4gcmM7CiAgICAgfQogCi0gICAgaWYgKCBkZXZmbiA9PSBwZGV2LT5kZXZm
biAmJiBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkKLSAgICB7Ci0gICAgICAg
IGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZkb21faW8tPnBkZXZf
bGlzdCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9IGRvbV9pbzsKLSAgICB9
Ci0KLSAgICByYyA9IGFsbG9jYXRlX2RvbWFpbl9yZXNvdXJjZXModCk7Ci0g
ICAgaWYgKCByYyApCi0gICAgICAgIHJldHVybiByYzsKLQotICAgIGFtZF9p
b21tdV9zZXR1cF9kb21haW5fZGV2aWNlKHRhcmdldCwgaW9tbXUsIGRldmZu
LCBwZGV2KTsKICAgICBBTURfSU9NTVVfREVCVUcoIlJlLWFzc2lnbiAlMDR4
OiUwMng6JTAyeC4ldSBmcm9tIGRvbSVkIHRvIGRvbSVkXG4iLAogICAgICAg
ICAgICAgICAgICAgICBwZGV2LT5zZWcsIHBkZXYtPmJ1cywgUENJX1NMT1Qo
ZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksCiAgICAgICAgICAgICAgICAgICAg
IHNvdXJjZS0+ZG9tYWluX2lkLCB0YXJnZXQtPmRvbWFpbl9pZCk7CiAKLSAg
ICBpZiAoIGRldmZuID09IHBkZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAh
PSB0YXJnZXQgKQotICAgIHsKLSAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5k
b21haW5fbGlzdCwgJnRhcmdldC0+cGRldl9saXN0KTsKLSAgICAgICAgcGRl
di0+ZG9tYWluID0gdGFyZ2V0OwotICAgIH0KLQogICAgIHJldHVybiAwOwog
fQogCkBAIC01MzgsOCArNjE3LDcgQEAgc3RhdGljIGludCBhbWRfaW9tbXVf
YWRkX2RldmljZSh1OCBkZXZmbgogICAgICAgICBzcGluX3VubG9ja19pcnFy
ZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3MpOwogICAgIH0KIAotICAgIGFt
ZF9pb21tdV9zZXR1cF9kb21haW5fZGV2aWNlKHBkZXYtPmRvbWFpbiwgaW9t
bXUsIGRldmZuLCBwZGV2KTsKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4g
YW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2UocGRldi0+ZG9tYWluLCBp
b21tdSwgZGV2Zm4sIHBkZXYpOwogfQogCiBzdGF0aWMgaW50IGFtZF9pb21t
dV9yZW1vdmVfZGV2aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRl
dikK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-06.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSSkKCkFycmFuZ2UgZm9yIGRvbWFpbiBJRCBhbmQg
cGFnZSB0YWJsZSByb290IHRvIGJlIHBhc3NlZCBhcm91bmQsIHRoZSBsYXR0
ZXIgaW4KcGFydGljdWxhciB0byBkb21haW5fcGdkX21hZGRyKCkgc3VjaCB0
aGF0IHRha2luZyBpdCBmcm9tIHRoZSBwZXItZG9tYWluCmZpZWxkcyBjYW4g
YmUgb3ZlcnJpZGRlbi4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVk
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5A
aW50ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2V4dGVybi5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9l
eHRlcm4uaApAQCAtODYsOSArODYsMTAgQEAgdm9pZCAqbWFwX3Z0ZF9kb21h
aW5fcGFnZSh1NjQgbWFkZHIpOwogdm9pZCB1bm1hcF92dGRfZG9tYWluX3Bh
Z2Uodm9pZCAqdmEpOwogaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25l
KHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IHZ0ZF9pb21tdSAqaW9t
bXUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBi
dXMsIHVpbnQ4X3QgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGlu
dCBtb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z
dCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgZG9taWRfdCBkb21pZCwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHBnZF9tYWRkciwg
dW5zaWduZWQgaW50IG1vZGUpOwogaW50IGRvbWFpbl9jb250ZXh0X3VubWFw
X29uZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCB2dGRfaW9tbXUg
KmlvbW11LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1OCBidXMs
IHU4IGRldmZuKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWlu
dDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQpOwogaW50
IGludGVsX2lvbW11X2dldF9yZXNlcnZlZF9kZXZpY2VfbWVtb3J5KGlvbW11
X2dyZG1fdCAqZnVuYywgdm9pZCAqY3R4dCk7CiAKIHVuc2lnbmVkIGludCBp
b19hcGljX3JlYWRfcmVtYXBfcnRlKHVuc2lnbmVkIGludCBhcGljLCB1bnNp
Z25lZCBpbnQgcmVnKTsKQEAgLTEwNyw3ICsxMDgsOCBAQCB2b2lkIHBsYXRm
b3JtX3F1aXJrc19pbml0KHZvaWQpOwogdm9pZCB2dGRfb3BzX3ByZWFtYmxl
X3F1aXJrKHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KTsKIHZvaWQgdnRkX29w
c19wb3N0YW1ibGVfcXVpcmsoc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUpOwog
aW50IF9fbXVzdF9jaGVjayBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4g
KmRvbWFpbiwgdWludDhfdCBidXMsCi0gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgdWludDhfdCBkZXZmbiwgdW5zaWduZWQgaW50IG1vZGUpOwor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgZGV2Zm4s
IGRvbWlkX3QgZG9taWQsIHBhZGRyX3QgcGdkX21hZGRyLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBtb2RlKTsKIHZv
aWQgcGNpX3Z0ZF9xdWlyayhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqKTsKIHZv
aWQgcXVpcmtfaW9tbXVfY2FwcyhzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSk7
CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMK
KysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAg
LTEzNjcsMTIgKzEzNjcsMTIgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKAogICAgIHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICBzdHJ1
Y3QgdnRkX2lvbW11ICppb21tdSwKICAgICB1aW50OF90IGJ1cywgdWludDhf
dCBkZXZmbiwgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsCi0gICAgdW5z
aWduZWQgaW50IG1vZGUpCisgICAgZG9taWRfdCBkb21pZCwgcGFkZHJfdCBw
Z2RfbWFkZHIsIHVuc2lnbmVkIGludCBtb2RlKQogewogICAgIHN0cnVjdCBk
b21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbWFpbik7CiAgICAgc3Ry
dWN0IGNvbnRleHRfZW50cnkgKmNvbnRleHQsICpjb250ZXh0X2VudHJpZXMs
IGxjdHh0OwogICAgIF9fdWludDEyOF90IG9sZDsKLSAgICB1NjQgbWFkZHIs
IHBnZF9tYWRkcjsKKyAgICB1aW50NjRfdCBtYWRkcjsKICAgICB1aW50MTZf
dCBzZWcgPSBpb21tdS0+ZHJoZC0+c2VnbWVudCwgcHJldl9kaWQgPSAwOwog
ICAgIHN0cnVjdCBkb21haW4gKnByZXZfZG9tID0gTlVMTDsKICAgICBpbnQg
YWdhdywgcmMsIHJldDsKQEAgLTE0MTMsMTAgKzE0MTMsMTIgQEAgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIH0KICAgICBlbHNlCiAg
ICAgeworICAgICAgICBwYWRkcl90IHJvb3QgPSBwZ2RfbWFkZHI7CisKICAg
ICAgICAgc3Bpbl9sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogCiAg
ICAgICAgIC8qIEVuc3VyZSB3ZSBoYXZlIHBhZ2V0YWJsZXMgYWxsb2NhdGVk
IGRvd24gdG8gbGVhZiBQVEUuICovCi0gICAgICAgIGlmICggaGQtPmFyY2gu
cGdkX21hZGRyID09IDAgKQorICAgICAgICBpZiAoICFyb290ICkKICAgICAg
ICAgewogICAgICAgICAgICAgYWRkcl90b19kbWFfcGFnZV9tYWRkcihkb21h
aW4sIDAsIDEpOwogICAgICAgICAgICAgaWYgKCBoZC0+YXJjaC5wZ2RfbWFk
ZHIgPT0gMCApCkBAIC0xNDI5LDIyICsxNDMxLDI0IEBAIGludCBkb21haW5f
Y29udGV4dF9tYXBwaW5nX29uZSgKICAgICAgICAgICAgICAgICAgICAgcmN1
X3VubG9ja19kb21haW4ocHJldl9kb20pOwogICAgICAgICAgICAgICAgIHJl
dHVybiAtRU5PTUVNOwogICAgICAgICAgICAgfQorCisgICAgICAgICAgICBy
b290ID0gaGQtPmFyY2gucGdkX21hZGRyOwogICAgICAgICB9CiAKICAgICAg
ICAgLyogU2tpcCB0b3AgbGV2ZWxzIG9mIHBhZ2UgdGFibGVzIGZvciAyLSBh
bmQgMy1sZXZlbCBEUkhEcy4gKi8KLSAgICAgICAgcGdkX21hZGRyID0gaGQt
PmFyY2gucGdkX21hZGRyOwogICAgICAgICBmb3IgKCBhZ2F3ID0gbGV2ZWxf
dG9fYWdhdyg0KTsKICAgICAgICAgICAgICAgYWdhdyAhPSBsZXZlbF90b19h
Z2F3KGlvbW11LT5ucl9wdF9sZXZlbHMpOwogICAgICAgICAgICAgICBhZ2F3
LS0gKQogICAgICAgICB7Ci0gICAgICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAq
cCA9IG1hcF92dGRfZG9tYWluX3BhZ2UocGdkX21hZGRyKTsKLSAgICAgICAg
ICAgIHBnZF9tYWRkciA9IGRtYV9wdGVfYWRkcigqcCk7CisgICAgICAgICAg
ICBzdHJ1Y3QgZG1hX3B0ZSAqcCA9IG1hcF92dGRfZG9tYWluX3BhZ2Uocm9v
dCk7CisKKyAgICAgICAgICAgIHJvb3QgPSBkbWFfcHRlX2FkZHIoKnApOwog
ICAgICAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKHApOwotICAgICAg
ICAgICAgaWYgKCBwZ2RfbWFkZHIgPT0gMCApCisgICAgICAgICAgICBpZiAo
ICFyb290ICkKICAgICAgICAgICAgICAgICBnb3RvIG5vbWVtOwogICAgICAg
ICB9CiAKLSAgICAgICAgY29udGV4dF9zZXRfYWRkcmVzc19yb290KGxjdHh0
LCBwZ2RfbWFkZHIpOworICAgICAgICBjb250ZXh0X3NldF9hZGRyZXNzX3Jv
b3QobGN0eHQsIHJvb3QpOwogICAgICAgICBpZiAoIGF0c19lbmFibGVkICYm
IGVjYXBfZGV2X2lvdGxiKGlvbW11LT5lY2FwKSApCiAgICAgICAgICAgICBj
b250ZXh0X3NldF90cmFuc2xhdGlvbl90eXBlKGxjdHh0LCBDT05URVhUX1RU
X0RFVl9JT1RMQik7CiAgICAgICAgIGVsc2UKQEAgLTE1NjAsMTUgKzE1NjQs
MjEgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIHVu
bWFwX3Z0ZF9kb21haW5fcGFnZShjb250ZXh0X2VudHJpZXMpOwogCiAgICAg
aWYgKCAhc2VnICYmICFyYyApCi0gICAgICAgIHJjID0gbWVfd2lmaV9xdWly
ayhkb21haW4sIGJ1cywgZGV2Zm4sIG1vZGUpOworICAgICAgICByYyA9IG1l
X3dpZmlfcXVpcmsoZG9tYWluLCBidXMsIGRldmZuLCBkb21pZCwgcGdkX21h
ZGRyLCBtb2RlKTsKIAogICAgIGlmICggcmMgKQogICAgIHsKICAgICAgICAg
aWYgKCAhcHJldl9kb20gKQotICAgICAgICAgICAgcmV0ID0gZG9tYWluX2Nv
bnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOwor
ICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRv
bWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4sCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOwog
ICAgICAgICBlbHNlIGlmICggcHJldl9kb20gIT0gZG9tYWluICkgLyogQXZv
aWQgaW5maW5pdGUgcmVjdXJzaW9uLiAqLworICAgICAgICB7CisgICAgICAg
ICAgICBoZCA9IGRvbV9pb21tdShwcmV2X2RvbSk7CiAgICAgICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShwcmV2X2RvbSwgaW9t
bXUsIGJ1cywgZGV2Zm4sIHBkZXYsCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhk
LT5hcmNoLnBnZF9tYWRkciwKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIG1vZGUgJiBNQVBfV0lUSF9STVJSKSA8IDA7
CisgICAgICAgIH0KICAgICAgICAgZWxzZQogICAgICAgICAgICAgcmV0ID0g
MTsKIApAQCAtMTU5MCw2ICsxNjAwLDcgQEAgc3RhdGljIGludCBkb21haW5f
Y29udGV4dF9tYXBwaW5nKHN0cnVjdAogewogICAgIHN0cnVjdCBhY3BpX2Ry
aGRfdW5pdCAqZHJoZDsKICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3Vu
aXQgKnJtcnI7CisgICAgcGFkZHJfdCBwZ2RfbWFkZHIgPSBkb21faW9tbXUo
ZG9tYWluKS0+YXJjaC5wZ2RfbWFkZHI7CiAgICAgaW50IHJldCA9IDA7CiAg
ICAgdW5zaWduZWQgaW50IGksIG1vZGUgPSAwOwogICAgIHVpbnQxNl90IHNl
ZyA9IHBkZXYtPnNlZywgYmRmOwpAQCAtMTY1NSw3ICsxNjY2LDggQEAgc3Rh
dGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAg
ICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBzZWcsIGJ1cywKICAg
ICAgICAgICAgICAgICAgICBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRl
dmZuKSk7CiAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdf
b25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIG1vZGUp
OworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw
ZGV2LCBkb21haW4tPmRvbWFpbl9pZCwgcGdkX21hZGRyLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtb2RlKTsKICAgICAg
ICAgaWYgKCByZXQgPiAwICkKICAgICAgICAgICAgIHJldCA9IDA7CiAgICAg
ICAgIGlmICggIXJldCAmJiBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBhdHNf
ZGV2aWNlKHBkZXYsIGRyaGQpID4gMCApCkBAIC0xNjcwLDcgKzE2ODIsOCBA
QCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAg
ICAgICAgICAgICAgICAgICAgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhk
ZXZmbikpOwogCiAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIG1v
ZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBwZGV2LCBkb21haW4tPmRvbWFpbl9pZCwgcGdkX21hZGRyLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtb2RlKTsKICAg
ICAgICAgaWYgKCByZXQgPCAwICkKICAgICAgICAgICAgIGJyZWFrOwogICAg
ICAgICBwcmV2X3ByZXNlbnQgPSByZXQ7CkBAIC0xNjk4LDcgKzE3MTEsOCBA
QCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAg
ICAgICAgICAqLwogICAgICAgICBpZiAoIHJldCA+PSAwICkKICAgICAgICAg
ICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwg
ZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBtb2RlKTsKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEws
IGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtb2RlKTsKIAogICAg
ICAgICAvKgogICAgICAgICAgKiBEZXZpY2VzIGJlaGluZCBQQ0llLXRvLVBD
SS9QQ0l4IGJyaWRnZSBtYXkgZ2VuZXJhdGUgZGlmZmVyZW50CkBAIC0xNzEz
LDcgKzE3MjcsOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBp
bmcoc3RydWN0CiAgICAgICAgIGlmICggIXJldCAmJiBwZGV2X3R5cGUoc2Vn
LCBidXMsIGRldmZuKSA9PSBERVZfVFlQRV9QQ0llMlBDSV9CUklER0UgJiYK
ICAgICAgICAgICAgICAoc2VjYnVzICE9IHBkZXYtPmJ1cyB8fCBwZGV2LT5k
ZXZmbiAhPSAwKSApCiAgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4
dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCBzZWNidXMsIDAs
Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBOVUxMLCBtb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIE5VTEwsIGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2Rf
bWFkZHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBtb2RlKTsKIAogICAgICAgICBpZiAoIHJldCApCiAgICAgICAg
IHsKQEAgLTE3NDIsNyArMTc1Nyw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2Nv
bnRleHRfbWFwcGluZyhzdHJ1Y3QKIGludCBkb21haW5fY29udGV4dF91bm1h
cF9vbmUoCiAgICAgc3RydWN0IGRvbWFpbiAqZG9tYWluLAogICAgIHN0cnVj
dCB2dGRfaW9tbXUgKmlvbW11LAotICAgIHU4IGJ1cywgdTggZGV2Zm4pCisg
ICAgdWludDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQp
CiB7CiAgICAgc3RydWN0IGNvbnRleHRfZW50cnkgKmNvbnRleHQsICpjb250
ZXh0X2VudHJpZXM7CiAgICAgdTY0IG1hZGRyOwpAQCAtMTgwMCw3ICsxODE1
LDcgQEAgaW50IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZSgKICAgICB1bm1h
cF92dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVzKTsKIAogICAgIGlm
ICggIWlvbW11LT5kcmhkLT5zZWdtZW50ICYmICFyYyApCi0gICAgICAgIHJj
ID0gbWVfd2lmaV9xdWlyayhkb21haW4sIGJ1cywgZGV2Zm4sIFVOTUFQX01F
X1BIQU5UT01fRlVOQyk7CisgICAgICAgIHJjID0gbWVfd2lmaV9xdWlyayhk
b21haW4sIGJ1cywgZGV2Zm4sIGRvbWlkLCAwLCBVTk1BUF9NRV9QSEFOVE9N
X0ZVTkMpOwogCiAgICAgaWYgKCByYyAmJiAhaXNfaGFyZHdhcmVfZG9tYWlu
KGRvbWFpbikgJiYgZG9tYWluICE9IGRvbV9pbyApCiAgICAgewpAQCAtMTg1
Myw3ICsxODY4LDggQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1h
cChzdHJ1Y3QgZAogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiZCVk
OlBDSWU6IHVubWFwICUwNHg6JTAyeDolMDJ4LiV1XG4iLAogICAgICAgICAg
ICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBzZWcsIGJ1cywKICAgICAg
ICAgICAgICAgICAgICBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZu
KSk7Ci0gICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShk
b21haW4sIGlvbW11LCBidXMsIGRldmZuKTsKKyAgICAgICAgcmV0ID0gZG9t
YWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2
Zm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBk
b21haW4tPmRvbWFpbl9pZCk7CiAgICAgICAgIGlmICggIXJldCAmJiBkZXZm
biA9PSBwZGV2LT5kZXZmbiAmJiBhdHNfZGV2aWNlKHBkZXYsIGRyaGQpID4g
MCApCiAgICAgICAgICAgICBkaXNhYmxlX2F0c19kZXZpY2UocGRldik7CiAK
QEAgLTE4NjMsNyArMTg3OSw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfdW5tYXAoc3RydWN0IGQKICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyAp
CiAgICAgICAgICAgICBwcmludGsoVlREUFJFRklYICJkJWQ6UENJOiB1bm1h
cCAlMDR4OiUwMng6JTAyeC4ldVxuIiwKICAgICAgICAgICAgICAgICAgICBk
b21haW4tPmRvbWFpbl9pZCwgc2VnLCBidXMsIFBDSV9TTE9UKGRldmZuKSwg
UENJX0ZVTkMoZGV2Zm4pKTsKLSAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRl
eHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOworICAg
ICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBp
b21tdSwgYnVzLCBkZXZmbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgaWYg
KCByZXQgKQogICAgICAgICAgICAgYnJlYWs7CiAKQEAgLTE4ODksMTIgKzE5
MDYsMTUgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1hcChzdHJ1
Y3QgZAogICAgICAgICAvKiBQQ0llIHRvIFBDSS9QQ0l4IGJyaWRnZSAqLwog
ICAgICAgICBpZiAoIHBkZXZfdHlwZShzZWcsIHRtcF9idXMsIHRtcF9kZXZm
bikgPT0gREVWX1RZUEVfUENJZTJQQ0lfQlJJREdFICkKICAgICAgICAgewot
ICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRv
bWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbik7CisgICAgICAgICAg
ICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21t
dSwgdG1wX2J1cywgdG1wX2RldmZuLAorICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAg
ICAgICAgICAgIGlmICggIXJldCApCi0gICAgICAgICAgICAgICAgcmV0ID0g
ZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIHNlY2J1
cywgMCk7CisgICAgICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRf
dW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIHNlY2J1cywgMCwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWlu
LT5kb21haW5faWQpOwogICAgICAgICB9CiAgICAgICAgIGVsc2UgLyogTGVn
YWN5IFBDSSBicmlkZ2UgKi8KLSAgICAgICAgICAgIHJldCA9IGRvbWFpbl9j
b250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBf
ZGV2Zm4pOworICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5t
YXBfb25lKGRvbWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21h
aW4tPmRvbWFpbl9pZCk7CiAKICAgICAgICAgYnJlYWs7CiAKLS0tIGEveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL3F1aXJrcy5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xdWlya3MuYwpAQCAtMzQ1LDYgKzM0
NSw4IEBAIHZvaWQgX19pbml0IHBsYXRmb3JtX3F1aXJrc19pbml0KHZvaWQp
CiAKIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIG1hcF9tZV9waGFudG9tX2Z1
bmN0aW9uKHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu
dCBkZXYsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBkb21pZF90IGRvbWlkLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBwZ2RfbWFk
ZHIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB1bnNpZ25lZCBpbnQgbW9kZSkKIHsKICAgICBzdHJ1Y3QgYWNw
aV9kcmhkX3VuaXQgKmRyaGQ7CkBAIC0zNTgsMTYgKzM2MCwxNyBAQCBzdGF0
aWMgaW50IF9fbXVzdF9jaGVjayBtYXBfbWVfcGhhbnRvbV9mCiAgICAgLyog
bWFwIG9yIHVubWFwIE1FIHBoYW50b20gZnVuY3Rpb24gKi8KICAgICBpZiAo
ICEobW9kZSAmIFVOTUFQX01FX1BIQU5UT01fRlVOQykgKQogICAgICAgICBy
YyA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+
aW9tbXUsIDAsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgUENJX0RFVkZOKGRldiwgNyksIE5VTEwsIG1vZGUpOworICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihk
ZXYsIDcpLCBOVUxMLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIGRvbWlkLCBwZ2RfbWFkZHIsIG1vZGUpOwogICAgIGVsc2UK
ICAgICAgICAgcmMgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWlu
LCBkcmhkLT5pb21tdSwgMCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgUENJX0RFVkZOKGRldiwgNykpOworICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfREVWRk4oZGV2LCA3KSwg
ZG9taWQpOwogCiAgICAgcmV0dXJuIHJjOwogfQogCiBpbnQgbWVfd2lmaV9x
dWlyayhzdHJ1Y3QgZG9tYWluICpkb21haW4sIHVpbnQ4X3QgYnVzLCB1aW50
OF90IGRldmZuLAotICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG1v
ZGUpCisgICAgICAgICAgICAgICAgICBkb21pZF90IGRvbWlkLCBwYWRkcl90
IHBnZF9tYWRkciwgdW5zaWduZWQgaW50IG1vZGUpCiB7CiAgICAgdTMyIGlk
OwogICAgIGludCByYyA9IDA7CkBAIC0zOTEsNyArMzk0LDcgQEAgaW50IG1l
X3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLAogICAgICAgICAg
ICAgY2FzZSAweDQyM2I4MDg2OgogICAgICAgICAgICAgY2FzZSAweDQyM2M4
MDg2OgogICAgICAgICAgICAgY2FzZSAweDQyM2Q4MDg2OgotICAgICAgICAg
ICAgICAgIHJjID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAz
LCBtb2RlKTsKKyAgICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9t
X2Z1bmN0aW9uKGRvbWFpbiwgMywgZG9taWQsIHBnZF9tYWRkciwgbW9kZSk7
CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0
OgogICAgICAgICAgICAgICAgIGJyZWFrOwpAQCAtNDE3LDcgKzQyMCw3IEBA
IGludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAg
ICAgICAgICAgIGNhc2UgMHg0MjM4ODA4NjogICAgICAgIC8qIFB1bWEgUGVh
ayAqLwogICAgICAgICAgICAgY2FzZSAweDQyMmI4MDg2OgogICAgICAgICAg
ICAgY2FzZSAweDQyMmM4MDg2OgotICAgICAgICAgICAgICAgIHJjID0gbWFw
X21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAyMiwgbW9kZSk7CisgICAg
ICAgICAgICAgICAgcmMgPSBtYXBfbWVfcGhhbnRvbV9mdW5jdGlvbihkb21h
aW4sIDIyLCBkb21pZCwgcGdkX21hZGRyLCBtb2RlKTsKICAgICAgICAgICAg
ICAgICBicmVhazsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAg
ICAgICAgYnJlYWs7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-07.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSUkpCgpSZXBsYWNlIHRoZSBwYXNzaW5nIG9mIHN0
cnVjdCBkb21haW4gKiBieSBkb21pZF90IGluIHByZXBhcmF0aW9uIG9mCnBl
ci1kZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBhbHNvIHJlcXVpcmlu
ZyBwZXItZGV2aWNlIHBzZXVkbwpkb21haW4gSURzLCB3aGljaCBhcmVuJ3Qg
Z29pbmcgdG8gYmUgYXNzb2NpYXRlZCB3aXRoIGFueSBzdHJ1Y3QgZG9tYWlu
Cmluc3RhbmNlcy4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkIChl
eGNlcHQgZm9yIHNsaWdodGx5IGFkanVzdGVkIGxvZyBtZXNzYWdlCnRleHQp
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNv
bT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKQEAgLTU4LDggKzU4LDggQEAgc3RhdGljIHN0cnVjdCB0YXNrbGV0
IHZ0ZF9mYXVsdF90YXNrbGV0Owogc3RhdGljIGludCBzZXR1cF9od2RvbV9k
ZXZpY2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICopOwogc3RhdGljIHZv
aWQgc2V0dXBfaHdkb21fcm1ycihzdHJ1Y3QgZG9tYWluICpkKTsKIAotc3Rh
dGljIGludCBkb21haW5faW9tbXVfZG9taWQoc3RydWN0IGRvbWFpbiAqZCwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQorc3RhdGljIGludCBnZXRfaW9tbXVfZGlkKGRvbWlkX3Qg
ZG9taWQsIGNvbnN0IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAorICAgICAg
ICAgICAgICAgICAgICAgICAgIGJvb2wgd2FybikKIHsKICAgICB1bnNpZ25l
ZCBsb25nIG5yX2RvbSwgaTsKIApAQCAtNjcsMTYgKzY3LDE2IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2lvbW11X2RvbWlkKHN0cnVjdCBkb20KICAgICBpID0g
ZmluZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsK
ICAgICB3aGlsZSAoIGkgPCBucl9kb20gKQogICAgIHsKLSAgICAgICAgaWYg
KCBpb21tdS0+ZG9taWRfbWFwW2ldID09IGQtPmRvbWFpbl9pZCApCisgICAg
ICAgIGlmICggaW9tbXUtPmRvbWlkX21hcFtpXSA9PSBkb21pZCApCiAgICAg
ICAgICAgICByZXR1cm4gaTsKIAogICAgICAgICBpID0gZmluZF9uZXh0X2Jp
dChpb21tdS0+ZG9taWRfYml0bWFwLCBucl9kb20sIGkrMSk7CiAgICAgfQog
Ci0gICAgaWYgKCAhZC0+aXNfZHlpbmcgKQorICAgIGlmICggd2FybiApCiAg
ICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsCi0gICAgICAg
ICAgICAgICAgIkNhbm5vdCBnZXQgdmFsaWQgaW9tbXUgJXUgZG9taWQ6ICVw
ZFxuIiwKLSAgICAgICAgICAgICAgICBpb21tdS0+aW5kZXgsIGQpOworICAg
ICAgICAgICAgICAgICJObyB2YWxpZCBpb21tdSAldSBkb21pZCBmb3IgRG9t
JWRcbiIsCisgICAgICAgICAgICAgICAgaW9tbXUtPmluZGV4LCBkb21pZCk7
CiAKICAgICByZXR1cm4gLTE7CiB9CkBAIC04NCw4ICs4NCw3IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2lvbW11X2RvbWlkKHN0cnVjdCBkb20KICNkZWZpbmUg
RElEX0ZJRUxEX1dJRFRIIDE2CiAjZGVmaW5lIERJRF9ISUdIX09GRlNFVCA4
CiBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9pZChzdHJ1Y3QgY29u
dGV4dF9lbnRyeSAqY29udGV4dCwKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHN0cnVjdCBkb21haW4gKmQsCi0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlkX3QgZG9taWQs
IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQogewogICAgIHVuc2lnbmVkIGxv
bmcgbnJfZG9tLCBpOwogICAgIGludCBmb3VuZCA9IDA7CkBAIC05Niw3ICs5
NSw3IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVj
dAogICAgIGkgPSBmaW5kX2ZpcnN0X2JpdChpb21tdS0+ZG9taWRfYml0bWFw
LCBucl9kb20pOwogICAgIHdoaWxlICggaSA8IG5yX2RvbSApCiAgICAgewot
ICAgICAgICBpZiAoIGlvbW11LT5kb21pZF9tYXBbaV0gPT0gZC0+ZG9tYWlu
X2lkICkKKyAgICAgICAgaWYgKCBpb21tdS0+ZG9taWRfbWFwW2ldID09IGRv
bWlkICkKICAgICAgICAgewogICAgICAgICAgICAgZm91bmQgPSAxOwogICAg
ICAgICAgICAgYnJlYWs7CkBAIC0xMTIsNyArMTExLDcgQEAgc3RhdGljIGlu
dCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0CiAgICAgICAgICAgICBk
cHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiSU9NTVU6IG5vIGZyZWUg
ZG9tYWluIGlkc1xuIik7CiAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsK
ICAgICAgICAgfQotICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0gZC0+
ZG9tYWluX2lkOworICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0gZG9t
aWQ7CiAgICAgfQogCiAgICAgc2V0X2JpdChpLCBpb21tdS0+ZG9taWRfYml0
bWFwKTsKQEAgLTEyMSw5ICsxMjAsOSBAQCBzdGF0aWMgaW50IGNvbnRleHRf
c2V0X2RvbWFpbl9pZChzdHJ1Y3QKICAgICByZXR1cm4gMDsKIH0KIAotc3Rh
dGljIHZvaWQgY2xlYW51cF9kb21pZF9tYXAoc3RydWN0IGRvbWFpbiAqZG9t
YWluLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKK3N0YXRpYyB2b2lkIGNs
ZWFudXBfZG9taWRfbWFwKGRvbWlkX3QgZG9taWQsIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQogewotICAgIGludCBpb21tdV9kb21pZCA9IGRvbWFpbl9p
b21tdV9kb21pZChkb21haW4sIGlvbW11KTsKKyAgICBpbnQgaW9tbXVfZG9t
aWQgPSBnZXRfaW9tbXVfZGlkKGRvbWlkLCBpb21tdSwgZmFsc2UpOwogCiAg
ICAgaWYgKCBpb21tdV9kb21pZCA+PSAwICkKICAgICB7CkBAIC0xNzksNyAr
MTc4LDcgQEAgc3RhdGljIHZvaWQgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAo
c3RydQogICAgIGlmICggIWZvdW5kICkKICAgICB7CiAgICAgICAgIGNsZWFy
X2JpdChpb21tdS0+aW5kZXgsICZkb21faW9tbXUoZCktPmFyY2guaW9tbXVf
Yml0bWFwKTsKLSAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZCwgaW9tbXUp
OworICAgICAgICBjbGVhbnVwX2RvbWlkX21hcChkLT5kb21haW5faWQsIGlv
bW11KTsKICAgICB9CiB9CiAKQEAgLTYzNiw3ICs2MzUsNyBAQCBzdGF0aWMg
aW50IF9fbXVzdF9jaGVjayBpb21tdV9mbHVzaF9pb3RsCiAgICAgICAgICAg
ICBjb250aW51ZTsKIAogICAgICAgICBmbHVzaF9kZXZfaW90bGIgPSAhIWZp
bmRfYXRzX2Rldl9kcmhkKGlvbW11KTsKLSAgICAgICAgaW9tbXVfZG9taWQ9
IGRvbWFpbl9pb21tdV9kb21pZChkLCBpb21tdSk7CisgICAgICAgIGlvbW11
X2RvbWlkID0gZ2V0X2lvbW11X2RpZChkLT5kb21haW5faWQsIGlvbW11LCAh
ZC0+aXNfZHlpbmcpOwogICAgICAgICBpZiAoIGlvbW11X2RvbWlkID09IC0x
ICkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCkBAIC0xNDU3LDcgKzE0NTYs
NyBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgICAg
IHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogICAgIH0K
IAotICAgIHJjID0gY29udGV4dF9zZXRfZG9tYWluX2lkKCZsY3R4dCwgZG9t
YWluLCBpb21tdSk7CisgICAgcmMgPSBjb250ZXh0X3NldF9kb21haW5faWQo
JmxjdHh0LCBkb21pZCwgaW9tbXUpOwogICAgIGlmICggcmMgKQogICAgIHsK
ICAgICB1bmxvY2s6CkBAIC0xNzgyLDcgKzE3ODEsNyBAQCBpbnQgZG9tYWlu
X2NvbnRleHRfdW5tYXBfb25lKAogICAgIGNvbnRleHRfY2xlYXJfZW50cnko
KmNvbnRleHQpOwogICAgIGlvbW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6
ZW9mKHN0cnVjdCBjb250ZXh0X2VudHJ5KSk7CiAKLSAgICBpb21tdV9kb21p
ZD0gZG9tYWluX2lvbW11X2RvbWlkKGRvbWFpbiwgaW9tbXUpOworICAgIGlv
bW11X2RvbWlkID0gZ2V0X2lvbW11X2RpZChkb21pZCwgaW9tbXUsICFkb21h
aW4tPmlzX2R5aW5nKTsKICAgICBpZiAoIGlvbW11X2RvbWlkID09IC0xICkK
ICAgICB7CiAgICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7CkBA
IC0xOTU0LDcgKzE5NTMsNyBAQCBzdGF0aWMgdm9pZCBpb21tdV9kb21haW5f
dGVhcmRvd24oc3RydWN0CiAgICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1h
cHBpbmdfbG9jayk7CiAKICAgICBmb3JfZWFjaF9kcmhkX3VuaXQgKCBkcmhk
ICkKLSAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZCwgZHJoZC0+aW9tbXUp
OworICAgICAgICBjbGVhbnVwX2RvbWlkX21hcChkLT5kb21haW5faWQsIGRy
aGQtPmlvbW11KTsKIH0KIAogc3RhdGljIGludCBfX211c3RfY2hlY2sgaW50
ZWxfaW9tbXVfbWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3QgZGZu
LAo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-08.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IG1haW50YWluIGEgcGVyLWRldmljZSBwc2V1ZG8gZG9t
YWluIElECgpJbiBvcmRlciB0byBzdWJzZXF1ZW50bHkgZW5hYmxlIHBlci1k
ZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcywgd2UnbGwKbmVlZCBkb21h
aW4tSUQtbGlrZSBpZGVudGlmaWVycyB0byBiZSBpbnNlcnRlZCBpbiB0aGUg
cmVzcGVjdGl2ZSBkZXZpY2UKKEFNRCkgb3IgY29udGV4dCAoSW50ZWwpIHRh
YmxlIGVudHJpZXMgYWxvbmdzaWRlIHRoZSBwZXItZGV2aWNlIHBhZ2UKdGFi
bGUgcm9vdCBhZGRyZXNzZXMuCgpNYWtlIHVzZSBvZiAicmVhbCIgZG9tYWlu
IElEcyBvY2N1cHlpbmcgb25seSBoYWxmIG9mIHRoZSB2YWx1ZSByYW5nZQpj
b3ZlcmFibGUgYnkgZG9taWRfdC4KCk5vdGUgdGhhdCBpbiBWVC1kJ3MgaW9t
bXVfYWxsb2MoKSBJIGRpZG4ndCB3YW50IHRvIGludHJvZHVjZSBuZXcgbWVt
b3J5CmxlYWtzIGluIGNhc2Ugb2YgZXJyb3IsIGJ1dCBleGlzdGluZyBvbmVz
IGRvbid0IGdldCBwbHVnZ2VkIC0gdGhhdCdsbCBiZQp0aGUgc3ViamVjdCBv
ZiBhIGxhdGVyIGNoYW5nZS4KClRoZSBWVC1kIGNoYW5nZXMgYXJlIHNsaWdo
dGx5IGFzeW1tZXRyaWMsIGJ1dCB0aGlzIHdheSB3ZSBjYW4gYXZvaWQKYXNz
aWduaW5nIHBzZXVkbyBkb21haW4gSURzIHRvIGRldmljZXMgd2hpY2ggd291
bGQgbmV2ZXIgYmUgbWFwcGVkIHdoaWxlCnN0aWxsIGF2b2lkaW5nIHRvIGFk
ZCBhIG5ldyBwYXJhbWV0ZXIgdG8gZG9tYWluX2NvbnRleHRfdW5tYXAoKS4K
ClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpS
ZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaW9tbXUuaAor
KysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKQEAgLTEzMCw2ICsx
MzAsMTAgQEAgaW50IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9k
ZXNjCiAgICAgICAgIGlvbW11X3ZjYWxsKG9wcywgc3luY19jYWNoZSwgYWRk
ciwgc2l6ZSk7ICAgICAgIFwKIH0pCiAKK3Vuc2lnbmVkIGxvbmcgKmlvbW11
X2luaXRfZG9taWQodm9pZCk7Citkb21pZF90IGlvbW11X2FsbG9jX2RvbWlk
KHVuc2lnbmVkIGxvbmcgKm1hcCk7Cit2b2lkIGlvbW11X2ZyZWVfZG9taWQo
ZG9taWRfdCBkb21pZCwgdW5zaWduZWQgbG9uZyAqbWFwKTsKKwogI2VuZGlm
IC8qICFfX0FSQ0hfWDg2X0lPTU1VX0hfXyAqLwogLyoKICAqIExvY2FsIHZh
cmlhYmxlczoKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaAorKysg
Yi94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oCkBAIC0xNSw2ICsxNSwxMiBA
QAogCiBzdHJ1Y3QgYXJjaF9wY2lfZGV2IHsKICAgICB2bWFza190IHVzZWRf
dmVjdG9yczsKKyAgICAvKgorICAgICAqIFRoZXNlIGZpZWxkcyBhcmUgKGRl
KWluaXRpYWxpemVkIHVuZGVyIHBjaWRldnMtbG9jay4gT3RoZXIgdXNlcyBv
ZgorICAgICAqIHRoZW0gZG9uJ3QgcmFjZSAoZGUpaW5pdGlhbGl6YXRpb24g
YW5kIGhlbmNlIGRvbid0IHN0cmljdGx5IG5lZWQgYW55CisgICAgICogbG9j
a2luZy4KKyAgICAgKi8KKyAgICBkb21pZF90IHBzZXVkb19kb21pZDsKIH07
CiAKIGludCBwY2lfY29uZl93cml0ZV9pbnRlcmNlcHQodW5zaWduZWQgaW50
IHNlZywgdW5zaWduZWQgaW50IGJkZiwKLS0tIGEveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvYW1kL2lvbW11LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11LmgKQEAgLTk2LDYgKzk2LDcgQEAgc3RydWN0IGFt
ZF9pb21tdSB7CiAgICAgc3RydWN0IHJpbmdfYnVmZmVyIGNtZF9idWZmZXI7
CiAgICAgc3RydWN0IHJpbmdfYnVmZmVyIGV2ZW50X2xvZzsKICAgICBzdHJ1
Y3QgcmluZ19idWZmZXIgcHByX2xvZzsKKyAgICB1bnNpZ25lZCBsb25nICpk
b21pZF9tYXA7CiAKICAgICBpbnQgZXhjbHVzaW9uX2VuYWJsZTsKICAgICBp
bnQgZXhjbHVzaW9uX2FsbG93X2FsbDsKLS0tIGEveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvYW1kL2lvbW11X2RldGVjdC5jCisrKyBiL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9kZXRlY3QuYwpAQCAtMTgwLDYgKzE4
MCwxMSBAQCBpbnQgX19pbml0IGFtZF9pb21tdV9kZXRlY3Rfb25lX2FjcGko
CiAgICAgaWYgKCBydCApCiAgICAgICAgIGdvdG8gb3V0OwogCisgICAgaW9t
bXUtPmRvbWlkX21hcCA9IGlvbW11X2luaXRfZG9taWQoKTsKKyAgICBydCA9
IC1FTk9NRU07CisgICAgaWYgKCAhaW9tbXUtPmRvbWlkX21hcCApCisgICAg
ICAgIGdvdG8gb3V0OworCiAgICAgcnQgPSBwY2lfcm9fZGV2aWNlKGlvbW11
LT5zZWcsIGJ1cywgUENJX0RFVkZOKGRldiwgZnVuYykpOwogICAgIGlmICgg
cnQgKQogICAgICAgICBwcmludGsoWEVOTE9HX0VSUgpAQCAtMTkxLDcgKzE5
NiwxMCBAQCBpbnQgX19pbml0IGFtZF9pb21tdV9kZXRlY3Rfb25lX2FjcGko
CiAKICBvdXQ6CiAgICAgaWYgKCBydCApCisgICAgeworICAgICAgICB4ZnJl
ZShpb21tdS0+ZG9taWRfbWFwKTsKICAgICAgICAgeGZyZWUoaW9tbXUpOwor
ICAgIH0KIAogICAgIHJldHVybiBydDsKIH0KLS0tIGEveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC01NTQs
NiArNTU0LDggQEAgc3RhdGljIGludCBhbWRfaW9tbXVfYWRkX2RldmljZSh1
OCBkZXZmbgogICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwogICAgIHUx
NiBiZGY7CiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGlu
Z3M7CisgICAgYm9vbCBmcmVzaF9kb21pZCA9IGZhbHNlOworICAgIGludCBy
ZXQ7CiAKICAgICBpZiAoICFwZGV2LT5kb21haW4gKQogICAgICAgICByZXR1
cm4gLUVJTlZBTDsKQEAgLTYxNyw3ICs2MTksMjIgQEAgc3RhdGljIGludCBh
bWRfaW9tbXVfYWRkX2RldmljZSh1OCBkZXZmbgogICAgICAgICBzcGluX3Vu
bG9ja19pcnFyZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3MpOwogICAgIH0K
IAotICAgIHJldHVybiBhbWRfaW9tbXVfc2V0dXBfZG9tYWluX2RldmljZShw
ZGV2LT5kb21haW4sIGlvbW11LCBkZXZmbiwgcGRldik7CisgICAgaWYgKCBp
b21tdV9xdWFyYW50aW5lICYmIHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID09
IERPTUlEX0lOVkFMSUQgKQorICAgIHsKKyAgICAgICAgcGRldi0+YXJjaC5w
c2V1ZG9fZG9taWQgPSBpb21tdV9hbGxvY19kb21pZChpb21tdS0+ZG9taWRf
bWFwKTsKKyAgICAgICAgaWYgKCBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9
PSBET01JRF9JTlZBTElEICkKKyAgICAgICAgICAgIHJldHVybiAtRU5PU1BD
OworICAgICAgICBmcmVzaF9kb21pZCA9IHRydWU7CisgICAgfQorCisgICAg
cmV0ID0gYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2UocGRldi0+ZG9t
YWluLCBpb21tdSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0ICYmIGZy
ZXNoX2RvbWlkICkKKyAgICB7CisgICAgICAgIGlvbW11X2ZyZWVfZG9taWQo
cGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsIGlvbW11LT5kb21pZF9tYXApOwor
ICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlEX0lOVkFM
SUQ7CisgICAgfQorCisgICAgcmV0dXJuIHJldDsKIH0KIAogc3RhdGljIGlu
dCBhbWRfaW9tbXVfcmVtb3ZlX2RldmljZSh1OCBkZXZmbiwgc3RydWN0IHBj
aV9kZXYgKnBkZXYpCkBAIC02NDIsNiArNjU5LDkgQEAgc3RhdGljIGludCBh
bWRfaW9tbXVfcmVtb3ZlX2RldmljZSh1OCBkZQogCiAgICAgYW1kX2lvbW11
X2Rpc2FibGVfZG9tYWluX2RldmljZShwZGV2LT5kb21haW4sIGlvbW11LCBk
ZXZmbiwgcGRldik7CiAKKyAgICBpb21tdV9mcmVlX2RvbWlkKHBkZXYtPmFy
Y2gucHNldWRvX2RvbWlkLCBpb21tdS0+ZG9taWRfbWFwKTsKKyAgICBwZGV2
LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlEX0lOVkFMSUQ7CisKICAgICBp
dnJzX21hcHBpbmdzID0gZ2V0X2l2cnNfbWFwcGluZ3MocGRldi0+c2VnKTsK
ICAgICBiZGYgPSBQQ0lfQkRGMihwZGV2LT5idXMsIGRldmZuKTsKICAgICBp
ZiAoIGFtZF9pb21tdV9wZXJkZXZfaW50cmVtYXAgJiYKLS0tIGEveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMKKysrIGIveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvcGNpLmMKQEAgLTMzOSw2ICszMzksNyBAQCBzdGF0aWMgc3Ry
dWN0IHBjaV9kZXYgKmFsbG9jX3BkZXYoc3RydWN0CiAgICAgKigodTgqKSAm
cGRldi0+YnVzKSA9IGJ1czsKICAgICAqKCh1OCopICZwZGV2LT5kZXZmbikg
PSBkZXZmbjsKICAgICBwZGV2LT5kb21haW4gPSBOVUxMOworICAgIHBkZXYt
PmFyY2gucHNldWRvX2RvbWlkID0gRE9NSURfSU5WQUxJRDsKICAgICBJTklU
X0xJU1RfSEVBRCgmcGRldi0+bXNpX2xpc3QpOwogCiAgICAgcG9zID0gcGNp
X2ZpbmRfY2FwX29mZnNldChwc2VnLT5uciwgYnVzLCBQQ0lfU0xPVChkZXZm
biksIFBDSV9GVU5DKGRldmZuKSwKQEAgLTEzNDksOSArMTM1MCwxMyBAQCBz
dGF0aWMgaW50IF9kdW1wX3BjaV9kZXZpY2VzKHN0cnVjdCBwY2lfCiAKICAg
ICBsaXN0X2Zvcl9lYWNoX2VudHJ5ICggcGRldiwgJnBzZWctPmFsbGRldnNf
bGlzdCwgYWxsZGV2c19saXN0ICkKICAgICB7Ci0gICAgICAgIHByaW50aygi
JTA0eDolMDJ4OiUwMnguJXUgLSAlcGQgLSBub2RlICUtM2QgLSBNU0lzIDwg
IiwKLSAgICAgICAgICAgICAgIHBzZWctPm5yLCBwZGV2LT5idXMsCi0gICAg
ICAgICAgICAgICBQQ0lfU0xPVChwZGV2LT5kZXZmbiksIFBDSV9GVU5DKHBk
ZXYtPmRldmZuKSwgcGRldi0+ZG9tYWluLAorICAgICAgICBwcmludGsoIiUw
NHg6JTAyeDolMDJ4LiV1IC0gIiwgcHNlZy0+bnIsIHBkZXYtPmJ1cywKKyAg
ICAgICAgICAgICAgIFBDSV9TTE9UKHBkZXYtPmRldmZuKSwgUENJX0ZVTkMo
cGRldi0+ZGV2Zm4pKTsKKyAgICAgICAgaWYgKCBwZGV2LT5kb21haW4gPT0g
ZG9tX2lvICkKKyAgICAgICAgICAgIHByaW50aygiRG9tSU86JXgiLCBwZGV2
LT5hcmNoLnBzZXVkb19kb21pZCk7CisgICAgICAgIGVsc2UKKyAgICAgICAg
ICAgIHByaW50aygiJXBkIiwgcGRldi0+ZG9tYWluKTsKKyAgICAgICAgcHJp
bnRrKCIgLSBub2RlICUtM2QgLSBNU0lzIDwgIiwKICAgICAgICAgICAgICAg
IChwZGV2LT5ub2RlICE9IE5VTUFfTk9fTk9ERSkgPyBwZGV2LT5ub2RlIDog
LTEpOwogICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5ICggbXNpLCAmcGRl
di0+bXNpX2xpc3QsIGxpc3QgKQogICAgICAgICAgICAgICAgcHJpbnRrKCIl
ZCAiLCBtc2ktPmlycSk7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0
ZC9pb21tdS5jCkBAIC0yMiw2ICsyMiw3IEBACiAjaW5jbHVkZSA8eGVuL3Nj
aGVkLmg+CiAjaW5jbHVkZSA8eGVuL3htYWxsb2MuaD4KICNpbmNsdWRlIDx4
ZW4vZG9tYWluX3BhZ2UuaD4KKyNpbmNsdWRlIDx4ZW4vZXJyLmg+CiAjaW5j
bHVkZSA8eGVuL2lvY2FwLmg+CiAjaW5jbHVkZSA8eGVuL2lvbW11Lmg+CiAj
aW5jbHVkZSA8eGVuL251bWEuaD4KQEAgLTExOTUsNyArMTE5Niw3IEBAIGlu
dCBfX2luaXQgaW9tbXVfYWxsb2Moc3RydWN0IGFjcGlfZHJoZF8KIHsKICAg
ICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdTsKICAgICB1bnNpZ25lZCBsb25n
IHNhZ2F3LCBucl9kb207Ci0gICAgaW50IGFnYXc7CisgICAgaW50IGFnYXcs
IHJjOwogCiAgICAgaWYgKCBucl9pb21tdXMgPj0gTUFYX0lPTU1VUyApCiAg
ICAgewpAQCAtMTI4OCw3ICsxMjg5LDE2IEBAIGludCBfX2luaXQgaW9tbXVf
YWxsb2Moc3RydWN0IGFjcGlfZHJoZF8KICAgICBpZiAoICFpb21tdS0+ZG9t
aWRfbWFwICkKICAgICAgICAgcmV0dXJuIC1FTk9NRU07CiAKKyAgICBpb21t
dS0+cHNldWRvX2RvbWlkX21hcCA9IGlvbW11X2luaXRfZG9taWQoKTsKKyAg
ICByYyA9IC1FTk9NRU07CisgICAgaWYgKCAhaW9tbXUtPnBzZXVkb19kb21p
ZF9tYXAgKQorICAgICAgICBnb3RvIGZyZWU7CisKICAgICByZXR1cm4gMDsK
KworIGZyZWU6CisgICAgaW9tbXVfZnJlZShkcmhkKTsKKyAgICByZXR1cm4g
cmM7CiB9CiAKIHZvaWQgX19pbml0IGlvbW11X2ZyZWUoc3RydWN0IGFjcGlf
ZHJoZF91bml0ICpkcmhkKQpAQCAtMTMxMSw2ICsxMzIxLDcgQEAgdm9pZCBf
X2luaXQgaW9tbXVfZnJlZShzdHJ1Y3QgYWNwaV9kcmhkXwogCiAgICAgeGZy
ZWUoaW9tbXUtPmRvbWlkX2JpdG1hcCk7CiAgICAgeGZyZWUoaW9tbXUtPmRv
bWlkX21hcCk7CisgICAgeGZyZWUoaW9tbXUtPnBzZXVkb19kb21pZF9tYXAp
OwogCiAgICAgaWYgKCBpb21tdS0+bXNpLmlycSA+PSAwICkKICAgICAgICAg
ZGVzdHJveV9pcnEoaW9tbXUtPm1zaS5pcnEpOwpAQCAtMTU5MSw4ICsxNjAy
LDggQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIHJl
dHVybiByYyA/OiBwZGV2ICYmIHByZXZfZG9tOwogfQogCi1zdGF0aWMgaW50
IGRvbWFpbl9jb250ZXh0X3VubWFwKHN0cnVjdCBkb21haW4gKmQsIHVpbnQ4
X3QgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0
cnVjdCBwY2lfZGV2ICpwZGV2KTsKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYWNw
aV9kcmhkX3VuaXQgKmRvbWFpbl9jb250ZXh0X3VubWFwKAorICAgIHN0cnVj
dCBkb21haW4gKmQsIHVpbnQ4X3QgZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICpw
ZGV2KTsKIAogc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0
cnVjdCBkb21haW4gKmRvbWFpbiwgdTggZGV2Zm4sCiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYpCkBA
IC0xNjAwLDYgKzE2MTEsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0
X21hcHBpbmcoc3RydWN0CiAgICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpk
cmhkOwogICAgIGNvbnN0IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsK
ICAgICBwYWRkcl90IHBnZF9tYWRkciA9IGRvbV9pb21tdShkb21haW4pLT5h
cmNoLnBnZF9tYWRkcjsKKyAgICBkb21pZF90IG9yaWdfZG9taWQgPSBwZGV2
LT5hcmNoLnBzZXVkb19kb21pZDsKICAgICBpbnQgcmV0ID0gMDsKICAgICB1
bnNpZ25lZCBpbnQgaSwgbW9kZSA9IDA7CiAgICAgdWludDE2X3Qgc2VnID0g
cGRldi0+c2VnLCBiZGY7CkBAIC0xNjYwLDYgKzE2NzIsMTQgQEAgc3RhdGlj
IGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICBi
cmVhazsKIAogICAgIGNhc2UgREVWX1RZUEVfUENJZV9FTkRQT0lOVDoKKyAg
ICAgICAgaWYgKCBpb21tdV9xdWFyYW50aW5lICYmIG9yaWdfZG9taWQgPT0g
RE9NSURfSU5WQUxJRCApCisgICAgICAgIHsKKyAgICAgICAgICAgIHBkZXYt
PmFyY2gucHNldWRvX2RvbWlkID0KKyAgICAgICAgICAgICAgICBpb21tdV9h
bGxvY19kb21pZChkcmhkLT5pb21tdS0+cHNldWRvX2RvbWlkX21hcCk7Cisg
ICAgICAgICAgICBpZiAoIHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID09IERP
TUlEX0lOVkFMSUQgKQorICAgICAgICAgICAgICAgIHJldHVybiAtRU5PU1BD
OworICAgICAgICB9CisKICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAg
ICAgICAgICAgICBwcmludGsoVlREUFJFRklYICJkJWQ6UENJZTogbWFwICUw
NHg6JTAyeDolMDJ4LiV1XG4iLAogICAgICAgICAgICAgICAgICAgIGRvbWFp
bi0+ZG9tYWluX2lkLCBzZWcsIGJ1cywKQEAgLTE2NzUsNiArMTY5NSwxNCBA
QCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAg
ICAgICAgIGJyZWFrOwogCiAgICAgY2FzZSBERVZfVFlQRV9QQ0k6CisgICAg
ICAgIGlmICggaW9tbXVfcXVhcmFudGluZSAmJiBvcmlnX2RvbWlkID09IERP
TUlEX0lOVkFMSUQgKQorICAgICAgICB7CisgICAgICAgICAgICBwZGV2LT5h
cmNoLnBzZXVkb19kb21pZCA9CisgICAgICAgICAgICAgICAgaW9tbXVfYWxs
b2NfZG9taWQoZHJoZC0+aW9tbXUtPnBzZXVkb19kb21pZF9tYXApOworICAg
ICAgICAgICAgaWYgKCBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9PSBET01J
RF9JTlZBTElEICkKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT1NQQzsK
KyAgICAgICAgfQorCiAgICAgICAgIGlmICggaW9tbXVfZGVidWcgKQogICAg
ICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiZCVkOlBDSTogbWFwICUwNHg6
JTAyeDolMDJ4LiV1XG4iLAogICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+
ZG9tYWluX2lkLCBzZWcsIGJ1cywKQEAgLTE3NTAsNiArMTc3OCwxMyBAQCBz
dGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAg
aWYgKCAhcmV0ICYmIGRldmZuID09IHBkZXYtPmRldmZuICkKICAgICAgICAg
cGNpX3Z0ZF9xdWlyayhwZGV2KTsKIAorICAgIGlmICggcmV0ICYmIGRyaGQg
JiYgb3JpZ19kb21pZCA9PSBET01JRF9JTlZBTElEICkKKyAgICB7CisgICAg
ICAgIGlvbW11X2ZyZWVfZG9taWQocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQs
CisgICAgICAgICAgICAgICAgICAgICAgICAgZHJoZC0+aW9tbXUtPnBzZXVk
b19kb21pZF9tYXApOworICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21p
ZCA9IERPTUlEX0lOVkFMSUQ7CisgICAgfQorCiAgICAgcmV0dXJuIHJldDsK
IH0KIApAQCAtMTgzMiw4ICsxODY3LDEwIEBAIGludCBkb21haW5fY29udGV4
dF91bm1hcF9vbmUoCiAgICAgcmV0dXJuIHJjOwogfQogCi1zdGF0aWMgaW50
IGRvbWFpbl9jb250ZXh0X3VubWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwg
dTggZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0
cnVjdCBwY2lfZGV2ICpwZGV2KQorc3RhdGljIGNvbnN0IHN0cnVjdCBhY3Bp
X2RyaGRfdW5pdCAqZG9tYWluX2NvbnRleHRfdW5tYXAoCisgICAgc3RydWN0
IGRvbWFpbiAqZG9tYWluLAorICAgIHVpbnQ4X3QgZGV2Zm4sCisgICAgc3Ry
dWN0IHBjaV9kZXYgKnBkZXYpCiB7CiAgICAgc3RydWN0IGFjcGlfZHJoZF91
bml0ICpkcmhkOwogICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11OwpAQCAt
MTg0Myw3ICsxODgwLDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91
bm1hcChzdHJ1Y3QgZAogCiAgICAgZHJoZCA9IGFjcGlfZmluZF9tYXRjaGVk
X2RyaGRfdW5pdChwZGV2KTsKICAgICBpZiAoICFkcmhkICkKLSAgICAgICAg
cmV0dXJuIC1FTk9ERVY7CisgICAgICAgIHJldHVybiBFUlJfUFRSKC1FTk9E
RVYpOwogICAgIGlvbW11ID0gZHJoZC0+aW9tbXU7CiAKICAgICBzd2l0Y2gg
KCBwZGV2LT50eXBlICkKQEAgLTE4NTQsNyArMTg5MSw3IEBAIHN0YXRpYyBp
bnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3RydWN0IGQKICAgICAgICAgICAg
ICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgc2VnLCBidXMsCiAgICAgICAg
ICAgICAgICAgICAgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikp
OwogICAgICAgICBpZiAoICFpc19oYXJkd2FyZV9kb21haW4oZG9tYWluKSAp
Ci0gICAgICAgICAgICByZXR1cm4gLUVQRVJNOworICAgICAgICAgICAgcmV0
dXJuIEVSUl9QVFIoLUVQRVJNKTsKICAgICAgICAgZ290byBvdXQ7CiAKICAg
ICBjYXNlIERFVl9UWVBFX1BDSWVfQlJJREdFOgpAQCAtMTkyOSw3ICsxOTY2
LDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1hcChzdHJ1Y3Qg
ZAogICAgICAgICBjaGVja19jbGVhbnVwX2RvbWlkX21hcChkb21haW4sIHBk
ZXYsIGlvbW11KTsKIAogb3V0OgotICAgIHJldHVybiByZXQ7CisgICAgcmV0
dXJuIHJldCA/IEVSUl9QVFIocmV0KSA6IGRyaGQ7CiB9CiAKIHN0YXRpYyB2
b2lkIGlvbW11X2RvbWFpbl90ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkKQpA
QCAtMjE1MywxNiArMjE5MCwxNyBAQCBzdGF0aWMgaW50IGludGVsX2lvbW11
X2VuYWJsZV9kZXZpY2Uoc3RyCiAKIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVf
cmVtb3ZlX2RldmljZSh1OCBkZXZmbiwgc3RydWN0IHBjaV9kZXYgKnBkZXYp
CiB7CisgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwog
ICAgIHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKICAgICB1MTYgYmRm
OwotICAgIGludCByZXQsIGk7CisgICAgdW5zaWduZWQgaW50IGk7CiAKICAg
ICBpZiAoICFwZGV2LT5kb21haW4gKQogICAgICAgICByZXR1cm4gLUVJTlZB
TDsKIAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHBkZXYtPmRv
bWFpbiwgZGV2Zm4sIHBkZXYpOwotICAgIGlmICggcmV0ICkKLSAgICAgICAg
cmV0dXJuIHJldDsKKyAgICBkcmhkID0gZG9tYWluX2NvbnRleHRfdW5tYXAo
cGRldi0+ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgaWYgKCBJU19FUlIo
ZHJoZCkgKQorICAgICAgICByZXR1cm4gUFRSX0VSUihkcmhkKTsKIAogICAg
IGZvcl9lYWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKICAgICB7
CkBAIC0yMTc5LDYgKzIyMTcsMTMgQEAgc3RhdGljIGludCBpbnRlbF9pb21t
dV9yZW1vdmVfZGV2aWNlKHU4CiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgcm1yci0+ZW5kX2FkZHJlc3MsIDApOwogICAgIH0KIAorICAgIGlm
ICggZHJoZCApCisgICAgeworICAgICAgICBpb21tdV9mcmVlX2RvbWlkKHBk
ZXYtPmFyY2gucHNldWRvX2RvbWlkLAorICAgICAgICAgICAgICAgICAgICAg
ICAgIGRyaGQtPmlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKKyAgICAgICAg
cGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBET01JRF9JTlZBTElEOworICAg
IH0KKwogICAgIHJldHVybiAwOwogfQogCi0tLSBhL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3Z0ZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5oCkBAIC01MzUsNiArNTM1LDcgQEAgc3RydWN0
IHZ0ZF9pb21tdSB7CiAgICAgfSBmbHVzaDsKIAogICAgIHN0cnVjdCBsaXN0
X2hlYWQgYXRzX2RldmljZXM7CisgICAgdW5zaWduZWQgbG9uZyAqcHNldWRv
X2RvbWlkX21hcDsgLyogInBzZXVkbyIgZG9tYWluIGlkIGJpdG1hcCAqLwog
ICAgIHVuc2lnbmVkIGxvbmcgKmRvbWlkX2JpdG1hcDsgIC8qIGRvbWFpbiBp
ZCBiaXRtYXAgKi8KICAgICB1MTYgKmRvbWlkX21hcDsgICAgICAgICAgICAg
ICAvKiBkb21haW4gaWQgbWFwcGluZyBhcnJheSAqLwogICAgIHVpbnQzMl90
IHZlcnNpb247Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9p
b21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21t
dS5jCkBAIC0zNzUsNiArMzc1LDUzIEBAIHZvaWQgX19od2RvbV9pbml0IGFy
Y2hfaW9tbXVfaHdkb21faW5pdCgKICAgICAgICAgcmV0dXJuOwogfQogCit1
bnNpZ25lZCBsb25nICpfX2luaXQgaW9tbXVfaW5pdF9kb21pZCh2b2lkKQor
eworICAgIGlmICggIWlvbW11X3F1YXJhbnRpbmUgKQorICAgICAgICByZXR1
cm4gWkVST19CTE9DS19QVFI7CisKKyAgICBCVUlMRF9CVUdfT04oRE9NSURf
TUFTSyAqIDJVID49IFVJTlQxNl9NQVgpOworCisgICAgcmV0dXJuIHh6YWxs
b2NfYXJyYXkodW5zaWduZWQgbG9uZywKKyAgICAgICAgICAgICAgICAgICAg
ICAgICBCSVRTX1RPX0xPTkdTKFVJTlQxNl9NQVggLSBET01JRF9NQVNLKSk7
Cit9CisKK2RvbWlkX3QgaW9tbXVfYWxsb2NfZG9taWQodW5zaWduZWQgbG9u
ZyAqbWFwKQoreworICAgIC8qCisgICAgICogVGhpcyBpcyB1c2VkIHVuaWZv
cm1seSBhY3Jvc3MgYWxsIElPTU1Vcywgc3VjaCB0aGF0IG9uIHR5cGljYWwK
KyAgICAgKiBzeXN0ZW1zIHdlIHdvdWxkbid0IHJlLXVzZSB0aGUgc2FtZSBJ
RCB2ZXJ5IHF1aWNrbHkgKHBlcmhhcHMgbmV2ZXIpLgorICAgICAqLworICAg
IHN0YXRpYyB1bnNpZ25lZCBpbnQgc3RhcnQ7CisgICAgdW5zaWduZWQgaW50
IGlkeCA9IGZpbmRfbmV4dF96ZXJvX2JpdChtYXAsIFVJTlQxNl9NQVggLSBE
T01JRF9NQVNLLCBzdGFydCk7CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2Nr
ZWQoKSk7CisKKyAgICBpZiAoIGlkeCA+PSBVSU5UMTZfTUFYIC0gRE9NSURf
TUFTSyApCisgICAgICAgIGlkeCA9IGZpbmRfZmlyc3RfemVyb19iaXQobWFw
LCBVSU5UMTZfTUFYIC0gRE9NSURfTUFTSyk7CisgICAgaWYgKCBpZHggPj0g
VUlOVDE2X01BWCAtIERPTUlEX01BU0sgKQorICAgICAgICByZXR1cm4gRE9N
SURfSU5WQUxJRDsKKworICAgIF9fc2V0X2JpdChpZHgsIG1hcCk7CisKKyAg
ICBzdGFydCA9IGlkeCArIDE7CisKKyAgICByZXR1cm4gaWR4IHwgKERPTUlE
X01BU0sgKyAxKTsKK30KKwordm9pZCBpb21tdV9mcmVlX2RvbWlkKGRvbWlk
X3QgZG9taWQsIHVuc2lnbmVkIGxvbmcgKm1hcCkKK3sKKyAgICBBU1NFUlQo
cGNpZGV2c19sb2NrZWQoKSk7CisKKyAgICBpZiAoIGRvbWlkID09IERPTUlE
X0lOVkFMSUQgKQorICAgICAgICByZXR1cm47CisKKyAgICBBU1NFUlQoZG9t
aWQgPiBET01JRF9NQVNLKTsKKworICAgIGlmICggIV9fdGVzdF9hbmRfY2xl
YXJfYml0KGRvbWlkICYgRE9NSURfTUFTSywgbWFwKSApCisgICAgICAgIEJV
RygpOworfQorCiAvKgogICogTG9jYWwgdmFyaWFibGVzOgogICogbW9kZTog
Qwo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-09.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IGRyb3AgVExCIGZsdXNoZXMgZnJvbSBxdWFyYW50aW5l
X2luaXQoKSBob29rcwoKVGhlIHBhZ2UgdGFibGVzIGp1c3QgY3JlYXRlZCBh
cmVuJ3QgaG9va2VkIHVwIHlldCBhbnl3aGVyZSwgc28gdGhlcmUncwpub3Ro
aW5nIHRoYXQgY291bGQgYmUgcHJlc2VudCBpbiBhbnkgVExCLCBhbmQgaGVu
Y2Ugbm90aGluZyB0byBmbHVzaC4KRHJvcHBpbmcgdGhpcyBmbHVzaCBpcywg
YXQgbGVhc3Qgb24gdGhlIFZULWQgc2lkZSwgYSBwcmVyZXEgdG8gcGVyLQpk
ZXZpY2UgZG9tYWluIElEIHVzZSB3aGVuIHF1YXJhbnRpbmluZyBkZXZpY2Vz
LCBhcyBkb21faW8gaXNuJ3QgZ29pbmcKdG8gYmUgYXNzaWduZWQgYSBESUQg
YW55bW9yZTogVGhlIHdhcm5pbmcgaW4gZ2V0X2lvbW11X2RpZCgpIHdvdWxk
CnRyaWdnZXIuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxA
eGVuLm9yZz4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy
LnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2
aW4udGlhbkBpbnRlbC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11X21hcC5jCkBAIC01ODUsOCArNTg1LDYgQEAgaW50
IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cgogIG91dDoK
ICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKIAot
ICAgIGFtZF9pb21tdV9mbHVzaF9hbGxfcGFnZXMoZCk7Ci0KICAgICAvKiBQ
YWdlcyBsZWFrZWQgaW4gZmFpbHVyZSBjYXNlICovCiAgICAgcmV0dXJuIGxl
dmVsID8gLUVOT01FTSA6IDA7CiB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5jCkBAIC0yOTE0LDcgKzI5MTQsNiBAQCBzdGF0aWMg
aW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFyYW50aW5lCiAgICAgc3RydWN0
IGRtYV9wdGUgKnBhcmVudDsKICAgICB1bnNpZ25lZCBpbnQgYWdhdyA9IHdp
ZHRoX3RvX2FnYXcoREVGQVVMVF9ET01BSU5fQUREUkVTU19XSURUSCk7CiAg
ICAgdW5zaWduZWQgaW50IGxldmVsID0gYWdhd190b19sZXZlbChhZ2F3KTsK
LSAgICBpbnQgcmM7CiAKICAgICBpZiAoIGhkLT5hcmNoLnBnZF9tYWRkciAp
CiAgICAgewpAQCAtMjk2MSwxMCArMjk2MCw4IEBAIHN0YXRpYyBpbnQgX19p
bml0IGludGVsX2lvbW11X3F1YXJhbnRpbmUKICBvdXQ6CiAgICAgc3Bpbl91
bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAKLSAgICByYyA9IGlv
bW11X2ZsdXNoX2lvdGxiX2FsbChkKTsKLQogICAgIC8qIFBhZ2VzIGxlYWtl
ZCBpbiBmYWlsdXJlIGNhc2UgKi8KLSAgICByZXR1cm4gbGV2ZWwgPyAtRU5P
TUVNIDogcmM7CisgICAgcmV0dXJuIGxldmVsID8gLUVOT01FTSA6IDA7CiB9
CiAKIGNvbnN0IHN0cnVjdCBpb21tdV9vcHMgX19pbml0Y29uc3RyZWwgaW50
ZWxfaW9tbXVfb3BzID0gewo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-10.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IGFic3RyYWN0IG1heGltdW0gbnVtYmVyIG9mIHBhZ2Ug
dGFibGUgbGV2ZWxzCgpXZSB3aWxsIHdhbnQgdG8gdXNlIHRoZSBjb25zdGFu
dCBlbHNld2hlcmUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBh
dWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft
ZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9p
b21tdS5oCkBAIC0zNjIsNyArMzYyLDcgQEAgc3RhdGljIGlubGluZSBpbnQg
YW1kX2lvbW11X2dldF9wYWdpbmdfbQogICAgIHdoaWxlICggbWF4X2ZyYW1l
cyA+IFBURV9QRVJfVEFCTEVfU0laRSApCiAgICAgewogICAgICAgICBtYXhf
ZnJhbWVzID0gUFRFX1BFUl9UQUJMRV9BTElHTihtYXhfZnJhbWVzKSA+PiBQ
VEVfUEVSX1RBQkxFX1NISUZUOwotICAgICAgICBpZiAoICsrbGV2ZWwgPiA2
ICkKKyAgICAgICAgaWYgKCArK2xldmVsID4gSU9NTVVfTUFYX1BUX0xFVkVM
UyApCiAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKICAgICB9CiAKLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11LWRlZnMuaAor
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUtZGVmcy5o
CkBAIC0xMDYsNiArMTA2LDcgQEAgc3RydWN0IGFtZF9pb21tdV9kdGUgewog
ICAgIGJvb2wgdHY6MTsKICAgICB1bnNpZ25lZCBpbnQgOjU7CiAgICAgdW5z
aWduZWQgaW50IGhhZDoyOworI2RlZmluZSBJT01NVV9NQVhfUFRfTEVWRUxT
IDYKICAgICB1bnNpZ25lZCBpbnQgcGFnaW5nX21vZGU6MzsKICAgICB1aW50
NjRfdCBwdF9yb290OjQwOwogICAgIGJvb2wgcHByOjE7Ci0tLSBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYworKysgYi94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMKQEAgLTI1Niw3
ICsyNTYsNyBAQCBzdGF0aWMgaW50IGlvbW11X3BkZV9mcm9tX2RmbihzdHJ1
Y3QgZG9tCiAgICAgdGFibGUgPSBoZC0+YXJjaC5yb290X3RhYmxlOwogICAg
IGxldmVsID0gaGQtPmFyY2gucGFnaW5nX21vZGU7CiAKLSAgICBCVUdfT04o
IHRhYmxlID09IE5VTEwgfHwgbGV2ZWwgPCAxIHx8IGxldmVsID4gNiApOwor
ICAgIEJVR19PTiggdGFibGUgPT0gTlVMTCB8fCBsZXZlbCA8IDEgfHwgbGV2
ZWwgPiBJT01NVV9NQVhfUFRfTEVWRUxTICk7CiAKICAgICAvKgogICAgICAq
IEEgZnJhbWUgbnVtYmVyIHBhc3Qgd2hhdCB0aGUgY3VycmVudCBwYWdlIHRh
YmxlcyBjYW4gcmVwcmVzZW50IGNhbid0Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.14-11.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.14-11.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHVzZSBwZXItZGV2aWNlIHBhZ2UgdGFibGVzIGZvciBx
dWFyYW50aW5pbmcKCkRldmljZXMgd2l0aCBSTVJScyAvIHVuaXR5IG1hcHBl
ZCByZWdpb25zLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQKaG93L3do
ZW4gdGhlc2UgbWVtb3J5IHJlZ2lvbnMgbWF5IGJlIGFjY2Vzc2VkLCBtYXkg
bm90IGJlIGxlZnQKZGlzY29ubmVjdGVkIGZyb20gdGhlIG1hcHBpbmdzIG9m
IHRoZXNlIHJlZ2lvbnMgKGFzIGxvbmcgYXMgaXQncyBub3QKY2VydGFpbiB0
aGF0IHRoZSBkZXZpY2UgaGFzIGJlZW4gZnVsbHkgcXVpZXNjZWQpLiBIZW5j
ZSBldmVuIHRoZSBwYWdlCnRhYmxlcyB1c2VkIHdoZW4gcXVhcmFudGluaW5n
IHN1Y2ggZGV2aWNlcyBuZWVkIHRvIGhhdmUgbWFwcGluZ3Mgb2YKdGhvc2Ug
cmVnaW9ucy4gVGhpcyBpbXBsaWVzIGluc3RhbGxpbmcgcGFnZSB0YWJsZXMg
aW4gdGhlIGZpcnN0IHBsYWNlCmV2ZW4gd2hlbiBub3QgaW4gc2NyYXRjaC1w
YWdlIHF1YXJhbnRpbmluZyBtb2RlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM2
MSAvIHBhcnQgb2YgWFNBLTQwMC4KCldoaWxlIGZvciB0aGUgcHVycG9zZSBo
ZXJlIGl0IHdvdWxkIGJlIHN1ZmZpY2llbnQgdG8gaGF2ZSBkZXZpY2VzIHdp
dGgKUk1SUnMgLyB1bml0eSBtYXBwZWQgcmVnaW9ucyB1c2UgcGVyLWRldmlj
ZSBwYWdlIHRhYmxlcywgZXh0ZW5kIHRoaXMgdG8KYWxsIGRldmljZXMgKGlu
IHNjcmF0Y2gtcGFnZSBxdWFyYW50aW5pbmcgbW9kZSkuIFRoaXMgYWxsb3dz
IHRoZSBsZWFmCnBhZ2VzIHRvIGJlIG1hcHBlZCByL3csIHRodXMgY292ZXJp
bmcgYWxzbyBtZW1vcnkgd3JpdGVzIChyYXRoZXIgdGhhbgpqdXN0IHJlYWRz
KSBpc3N1ZWQgYnkgbm9uLXF1aWVzY2VudCBkZXZpY2VzLgoKU2V0IHVwIHF1
YXJhbnRpbmUgcGFnZSB0YWJsZXMgYXMgbGF0ZSBhcyBwb3NzaWJsZSwgeWV0
IGVhcmx5IGVub3VnaCB0bwpub3QgZW5jb3VudGVyIGZhaWx1cmUgZHVyaW5n
IGRlLWFzc2lnbi4gVGhpcyBtZWFucyBzZXR1cCBnZW5lcmFsbHkKaGFwcGVu
cyBpbiBhc3NpZ25fZGV2aWNlKCksIHdoaWxlIChmb3Igbm93KSB0aGUgb25l
IGluIGRlYXNzaWduX2RldmljZSgpCmlzIHRoZXJlIG1haW5seSB0byBiZSBv
biB0aGUgc2FmZSBzaWRlLgoKSW4gVlQtZCdzIERJRCBhbGxvY2F0aW9uIGZ1
bmN0aW9uIGRvbid0IHJlcXVpcmUgdGhlIElPTU1VIGxvY2sgdG8gYmUKaGVs
ZCBhbnltb3JlOiBBbGwgaW52b2x2ZWQgY29kZSBwYXRocyBob2xkIHBjaWRl
dnNfbG9jaywgc28gdGhpcyB3YXkgd2UKYXZvaWQgdGhlIG5lZWQgdG8gYWNx
dWlyZSB0aGUgSU9NTVUgbG9jayBhcm91bmQgdGhlIG5ldyBjYWxsIHRvCmNv
bnRleHRfc2V0X2RvbWFpbl9pZCgpLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBE
dXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFu
IDxrZXZpbi50aWFuQGludGVsLmNvbT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBh
dSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKLS0tIGEveGVuL2Fy
Y2gveDg2L21tL3AybS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpA
QCAtMTQ1NSw3ICsxNDU1LDcgQEAgaW50IHNldF9pZGVudGl0eV9wMm1fZW50
cnkoc3RydWN0IGRvbWFpbgogICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0g
PSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJldDsKIAotICAgIGlm
ICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShwMm0tPmRvbWFpbikgKQorICAg
IGlmICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShkKSApCiAgICAgewogICAg
ICAgICBpZiAoICFpc19pb21tdV9lbmFibGVkKGQpICkKICAgICAgICAgICAg
IHJldHVybiAwOwotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oCisr
KyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgKQEAgLTEsNiArMSw4IEBA
CiAjaWZuZGVmIF9fWDg2X1BDSV9IX18KICNkZWZpbmUgX19YODZfUENJX0hf
XwogCisjaW5jbHVkZSA8eGVuL21tLmg+CisKICNkZWZpbmUgQ0Y4X0JERihj
ZjgpICAgICAoICAoKGNmOCkgJiAweDAwZmZmZjAwKSA+PiA4KQogI2RlZmlu
ZSBDRjhfQUREUl9MTyhjZjgpICggICAoY2Y4KSAmIDB4MDAwMDAwZmMpCiAj
ZGVmaW5lIENGOF9BRERSX0hJKGNmOCkgKCAgKChjZjgpICYgMHgwZjAwMDAw
MCkgPj4gMTYpCkBAIC0yMCw3ICsyMiwxOCBAQCBzdHJ1Y3QgYXJjaF9wY2lf
ZGV2IHsKICAgICAgKiB0aGVtIGRvbid0IHJhY2UgKGRlKWluaXRpYWxpemF0
aW9uIGFuZCBoZW5jZSBkb24ndCBzdHJpY3RseSBuZWVkIGFueQogICAgICAq
IGxvY2tpbmcuCiAgICAgICovCisgICAgdW5pb24geworICAgICAgICAvKiBT
dWJzZXQgb2Ygc3RydWN0IGFyY2hfaW9tbXUncyBmaWVsZHMsIHRvIGJlIHVz
ZWQgaW4gZG9tX2lvLiAqLworICAgICAgICBzdHJ1Y3QgeworICAgICAgICAg
ICAgdWludDY0X3QgcGdkX21hZGRyOworICAgICAgICB9IHZ0ZDsKKyAgICAg
ICAgc3RydWN0IHsKKyAgICAgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnJv
b3RfdGFibGU7CisgICAgICAgIH0gYW1kOworICAgIH07CiAgICAgZG9taWRf
dCBwc2V1ZG9fZG9taWQ7CisgICAgbWZuX3QgbGVhZl9tZm47CisgICAgc3Ry
dWN0IHBhZ2VfbGlzdF9oZWFkIHBndGFibGVzX2xpc3Q7CiB9OwogCiBpbnQg
cGNpX2NvbmZfd3JpdGVfaW50ZXJjZXB0KHVuc2lnbmVkIGludCBzZWcsIHVu
c2lnbmVkIGludCBiZGYsCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L2FtZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft
ZC9pb21tdS5oCkBAIC0yMjMsNyArMjIzLDggQEAgaW50IGFtZF9pb21tdV9p
bml0X2xhdGUodm9pZCk7CiBpbnQgYW1kX2lvbW11X3VwZGF0ZV9pdnJzX21h
cHBpbmdfYWNwaSh2b2lkKTsKIGludCBpb3ZfYWRqdXN0X2lycV9hZmZpbml0
aWVzKHZvaWQpOwogCi1pbnQgYW1kX2lvbW11X3F1YXJhbnRpbmVfaW5pdChz
dHJ1Y3QgZG9tYWluICpkKTsKK2ludCBhbWRfaW9tbXVfcXVhcmFudGluZV9p
bml0KHN0cnVjdCBwY2lfZGV2ICpwZGV2KTsKK3ZvaWQgYW1kX2lvbW11X3F1
YXJhbnRpbmVfdGVhcmRvd24oc3RydWN0IHBjaV9kZXYgKnBkZXYpOwogCiAv
KiBtYXBwaW5nIGZ1bmN0aW9ucyAqLwogaW50IF9fbXVzdF9jaGVjayBhbWRf
aW9tbXVfbWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3QgZGZuLAot
LS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMK
KysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5j
CkBAIC01MjksNjQgKzUyOSwxMzcgQEAgaW50IGFtZF9pb21tdV9yZXNlcnZl
X2RvbWFpbl91bml0eV91bm1hcAogICAgIHJldHVybiByYzsKIH0KIAotaW50
IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBkb21h
aW4gKmQpCitzdGF0aWMgaW50IGZpbGxfcXB0KHVuaW9uIGFtZF9pb21tdV9w
dGUgKnRoaXMsIHVuc2lnbmVkIGludCBsZXZlbCwKKyAgICAgICAgICAgICAg
ICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGdzW0lPTU1VX01BWF9QVF9MRVZF
TFNdLAorICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcGNpX2RldiAqcGRl
dikKIHsKLSAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21t
dShkKTsKKyAgICB1bnNpZ25lZCBpbnQgaTsKKyAgICBpbnQgcmMgPSAwOwor
CisgICAgZm9yICggaSA9IDA7ICFyYyAmJiBpIDwgUFRFX1BFUl9UQUJMRV9T
SVpFOyArK2kgKQorICAgIHsKKyAgICAgICAgdW5pb24gYW1kX2lvbW11X3B0
ZSAqcHRlID0gJnRoaXNbaV0sICpuZXh0OworCisgICAgICAgIGlmICggIXB0
ZS0+cHIgKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAoICFwZ3NbbGV2
ZWxdICkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICAvKgorICAg
ICAgICAgICAgICAgICAqIFRoZSBwZ3RhYmxlIGFsbG9jYXRvciBpcyBmaW5l
IGZvciB0aGUgbGVhZiBwYWdlLCBhcyB3ZWxsIGFzCisgICAgICAgICAgICAg
ICAgICogcGFnZSB0YWJsZSBwYWdlcywgYW5kIHRoZSByZXN1bHRpbmcgYWxs
b2NhdGlvbnMgYXJlIGFsd2F5cworICAgICAgICAgICAgICAgICAqIHplcm9l
ZC4KKyAgICAgICAgICAgICAgICAgKi8KKyAgICAgICAgICAgICAgICBwZ3Nb
bGV2ZWxdID0gYWxsb2NfYW1kX2lvbW11X3BndGFibGUoKTsKKyAgICAgICAg
ICAgICAgICBpZiAoICFwZ3NbbGV2ZWxdICkKKyAgICAgICAgICAgICAgICB7
CisgICAgICAgICAgICAgICAgICAgIHJjID0gLUVOT01FTTsKKyAgICAgICAg
ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQorCisgICAg
ICAgICAgICAgICAgcGFnZV9saXN0X2FkZChwZ3NbbGV2ZWxdLCAmcGRldi0+
YXJjaC5wZ3RhYmxlc19saXN0KTsKKworICAgICAgICAgICAgICAgIGlmICgg
bGV2ZWwgKQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICAg
ICAgbmV4dCA9IF9fbWFwX2RvbWFpbl9wYWdlKHBnc1tsZXZlbF0pOworICAg
ICAgICAgICAgICAgICAgICByYyA9IGZpbGxfcXB0KG5leHQsIGxldmVsIC0g
MSwgcGdzLCBwZGV2KTsKKyAgICAgICAgICAgICAgICAgICAgdW5tYXBfZG9t
YWluX3BhZ2UobmV4dCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAg
ICAgfQorCisgICAgICAgICAgICAvKgorICAgICAgICAgICAgICogUERFcyBh
cmUgZXNzZW50aWFsbHkgYSBzdWJzZXQgb2YgUFRFcywgc28gdGhpcyBmdW5j
dGlvbgorICAgICAgICAgICAgICogaXMgZmluZSB0byB1c2UgZXZlbiBhdCB0
aGUgbGVhZi4KKyAgICAgICAgICAgICAqLworICAgICAgICAgICAgc2V0X2lv
bW11X3BkZV9wcmVzZW50KHB0ZSwgbWZuX3gocGFnZV90b19tZm4ocGdzW2xl
dmVsXSkpLCBsZXZlbCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB0cnVlLCB0cnVlKTsKKyAgICAgICAgfQorICAgICAgICBlbHNlIGlm
ICggbGV2ZWwgJiYgcHRlLT5uZXh0X2xldmVsICkKKyAgICAgICAgeworICAg
ICAgICAgICAgcGFnZV9saXN0X2FkZChtZm5fdG9fcGFnZShfbWZuKHB0ZS0+
bWZuKSksCisgICAgICAgICAgICAgICAgICAgICAgICAgICZwZGV2LT5hcmNo
LnBndGFibGVzX2xpc3QpOworICAgICAgICAgICAgbmV4dCA9IG1hcF9kb21h
aW5fcGFnZShfbWZuKHB0ZS0+bWZuKSk7CisgICAgICAgICAgICByYyA9IGZp
bGxfcXB0KG5leHQsIGxldmVsIC0gMSwgcGdzLCBwZGV2KTsKKyAgICAgICAg
ICAgIHVubWFwX2RvbWFpbl9wYWdlKG5leHQpOworICAgICAgICB9CisgICAg
fQorCisgICAgcmV0dXJuIHJjOworfQorCitpbnQgYW1kX2lvbW11X3F1YXJh
bnRpbmVfaW5pdChzdHJ1Y3QgcGNpX2RldiAqcGRldikKK3sKKyAgICBzdHJ1
Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21faW8pOwogICAg
IHVuc2lnbmVkIGxvbmcgZW5kX2dmbiA9CiAgICAgICAgIDF1bCA8PCAoREVG
QVVMVF9ET01BSU5fQUREUkVTU19XSURUSCAtIFBBR0VfU0hJRlQpOwogICAg
IHVuc2lnbmVkIGludCBsZXZlbCA9IGFtZF9pb21tdV9nZXRfcGFnaW5nX21v
ZGUoZW5kX2dmbik7Ci0gICAgdW5pb24gYW1kX2lvbW11X3B0ZSAqdGFibGU7
CisgICAgdW5zaWduZWQgaW50IHJlcV9pZCA9IGdldF9kbWFfcmVxdWVzdG9y
X2lkKHBkZXYtPnNlZywgcGRldi0+c2JkZi5iZGYpOworICAgIGNvbnN0IHN0
cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX21hcHBpbmdzID0gZ2V0X2l2cnNf
bWFwcGluZ3MocGRldi0+c2VnKTsKKyAgICBpbnQgcmM7CiAKLSAgICBpZiAo
IGhkLT5hcmNoLnJvb3RfdGFibGUgKQorICAgIEFTU0VSVChwY2lkZXZzX2xv
Y2tlZCgpKTsKKyAgICBBU1NFUlQoIWhkLT5hcmNoLnJvb3RfdGFibGUpOwor
CisgICAgQVNTRVJUKHBkZXYtPmFyY2gucHNldWRvX2RvbWlkICE9IERPTUlE
X0lOVkFMSUQpOworCisgICAgaWYgKCBwZGV2LT5hcmNoLmFtZC5yb290X3Rh
YmxlICkKICAgICB7Ci0gICAgICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOwor
ICAgICAgICBjbGVhcl9kb21haW5fcGFnZShwZGV2LT5hcmNoLmxlYWZfbWZu
KTsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCi0gICAgc3Bpbl9sb2Nr
KCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwotCi0gICAgaGQtPmFyY2gucm9v
dF90YWJsZSA9IGFsbG9jX2FtZF9pb21tdV9wZ3RhYmxlKCk7Ci0gICAgaWYg
KCAhaGQtPmFyY2gucm9vdF90YWJsZSApCi0gICAgICAgIGdvdG8gb3V0Owot
Ci0gICAgdGFibGUgPSBfX21hcF9kb21haW5fcGFnZShoZC0+YXJjaC5yb290
X3RhYmxlKTsKLSAgICB3aGlsZSAoIGxldmVsICkKKyAgICBwZGV2LT5hcmNo
LmFtZC5yb290X3RhYmxlID0gYWxsb2NfYW1kX2lvbW11X3BndGFibGUoKTsK
KyAgICBpZiAoICFwZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlICkKKyAgICAg
ICAgcmV0dXJuIC1FTk9NRU07CisKKyAgICAvKiBUcmFuc2llbnRseSBpbnN0
YWxsIHRoZSByb290IGludG8gRG9tSU8sIGZvciBpb21tdV9pZGVudGl0eV9t
YXBwaW5nKCkuICovCisgICAgaGQtPmFyY2gucm9vdF90YWJsZSA9IHBkZXYt
PmFyY2guYW1kLnJvb3RfdGFibGU7CisKKyAgICByYyA9IGFtZF9pb21tdV9y
ZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoZG9tX2lvLAorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdnJzX21hcHBpbmdz
W3JlcV9pZF0udW5pdHlfbWFwLAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAwKTsKKworICAgIGlvbW11X2lkZW50aXR5
X21hcF90ZWFyZG93bihkb21faW8pOworICAgIGhkLT5hcmNoLnJvb3RfdGFi
bGUgPSBOVUxMOworCisgICAgaWYgKCByYyApCisgICAgICAgIHByaW50aygi
JTA0eDolMDJ4OiUwMnguJXU6IHF1YXJhbnRpbmUgdW5pdHkgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICBwZGV2LT5zZWcsIHBkZXYtPmJ1
cywKKyAgICAgICAgICAgICAgIFBDSV9TTE9UKHBkZXYtPmRldmZuKSwgUENJ
X0ZVTkMocGRldi0+ZGV2Zm4pKTsKKyAgICBlbHNlCiAgICAgewotICAgICAg
ICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKLSAgICAgICAgdW5zaWduZWQgaW50
IGk7CisgICAgICAgIHVuaW9uIGFtZF9pb21tdV9wdGUgKnJvb3Q7CisgICAg
ICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnc1tJT01NVV9NQVhfUFRfTEVWRUxT
XSA9IHt9OwogCi0gICAgICAgIC8qCi0gICAgICAgICAqIFRoZSBwZ3RhYmxl
IGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUgbGVhZiBwYWdlLCBhcyB3ZWxs
IGFzCi0gICAgICAgICAqIHBhZ2UgdGFibGUgcGFnZXMsIGFuZCB0aGUgcmVz
dWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMKLSAgICAgICAgICogemVy
b2VkLgotICAgICAgICAgKi8KLSAgICAgICAgcGcgPSBhbGxvY19hbWRfaW9t
bXVfcGd0YWJsZSgpOwotICAgICAgICBpZiAoICFwZyApCi0gICAgICAgICAg
ICBicmVhazsKKyAgICAgICAgc3Bpbl9sb2NrKCZoZC0+YXJjaC5tYXBwaW5n
X2xvY2spOwogCi0gICAgICAgIGZvciAoIGkgPSAwOyBpIDwgUFRFX1BFUl9U
QUJMRV9TSVpFOyBpKysgKQotICAgICAgICB7Ci0gICAgICAgICAgICB1bmlv
biBhbWRfaW9tbXVfcHRlICpwZGUgPSAmdGFibGVbaV07CisgICAgICAgIHJv
b3QgPSBfX21hcF9kb21haW5fcGFnZShwZGV2LT5hcmNoLmFtZC5yb290X3Rh
YmxlKTsKKyAgICAgICAgcmMgPSBmaWxsX3FwdChyb290LCBsZXZlbCAtIDEs
IHBncywgcGRldik7CisgICAgICAgIHVubWFwX2RvbWFpbl9wYWdlKHJvb3Qp
OwogCi0gICAgICAgICAgICAvKgotICAgICAgICAgICAgICogUERFcyBhcmUg
ZXNzZW50aWFsbHkgYSBzdWJzZXQgb2YgUFRFcywgc28gdGhpcyBmdW5jdGlv
bgotICAgICAgICAgICAgICogaXMgZmluZSB0byB1c2UgZXZlbiBhdCB0aGUg
bGVhZi4KLSAgICAgICAgICAgICAqLwotICAgICAgICAgICAgc2V0X2lvbW11
X3BkZV9wcmVzZW50KHBkZSwgbWZuX3gocGFnZV90b19tZm4ocGcpKSwgbGV2
ZWwgLSAxLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZh
bHNlLCB0cnVlKTsKLSAgICAgICAgfQorICAgICAgICBwZGV2LT5hcmNoLmxl
YWZfbWZuID0gcGFnZV90b19tZm4ocGdzWzBdKTsKIAotICAgICAgICB1bm1h
cF9kb21haW5fcGFnZSh0YWJsZSk7Ci0gICAgICAgIHRhYmxlID0gX19tYXBf
ZG9tYWluX3BhZ2UocGcpOwotICAgICAgICBsZXZlbC0tOworICAgICAgICBz
cGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKICAgICB9Ci0g
ICAgdW5tYXBfZG9tYWluX3BhZ2UodGFibGUpOwogCi0gb3V0OgotICAgIHNw
aW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOworICAgIGlmICgg
cmMgKQorICAgICAgICBhbWRfaW9tbXVfcXVhcmFudGluZV90ZWFyZG93bihw
ZGV2KTsKKworICAgIHJldHVybiByYzsKK30KKwordm9pZCBhbWRfaW9tbXVf
cXVhcmFudGluZV90ZWFyZG93bihzdHJ1Y3QgcGNpX2RldiAqcGRldikKK3sK
KyAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKKworICAgIEFTU0VSVChwY2lk
ZXZzX2xvY2tlZCgpKTsKKworICAgIGlmICggIXBkZXYtPmFyY2guYW1kLnJv
b3RfdGFibGUgKQorICAgICAgICByZXR1cm47CisKKyAgICB3aGlsZSAoIChw
ZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgmcGRldi0+YXJjaC5wZ3RhYmxl
c19saXN0KSkgKQorICAgICAgICBmcmVlX2FtZF9pb21tdV9wZ3RhYmxlKHBn
KTsKIAotICAgIC8qIFBhZ2VzIGxlYWtlZCBpbiBmYWlsdXJlIGNhc2UgKi8K
LSAgICByZXR1cm4gbGV2ZWwgPyAtRU5PTUVNIDogMDsKKyAgICBwZGV2LT5h
cmNoLmFtZC5yb290X3RhYmxlID0gTlVMTDsKIH0KIAogLyoKLS0tIGEveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysg
Yi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5j
CkBAIC0xMjIsNiArMTIyLDggQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sg
YW1kX2lvbW11X3NldHVwXwogICAgIHU4IGJ1cyA9IHBkZXYtPmJ1czsKICAg
ICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21haW4p
OwogICAgIGNvbnN0IHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX2RldjsK
KyAgICBjb25zdCBzdHJ1Y3QgcGFnZV9pbmZvICpyb290X3BnOworICAgIGRv
bWlkX3QgZG9taWQ7CiAKICAgICBCVUdfT04oIWhkLT5hcmNoLnBhZ2luZ19t
b2RlIHx8ICFpb21tdS0+ZGV2X3RhYmxlLmJ1ZmZlcik7CiAKQEAgLTE0MSwx
NCArMTQzLDI1IEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21t
dV9zZXR1cF8KICAgICBkdGUgPSAmdGFibGVbcmVxX2lkXTsKICAgICBpdnJz
X2RldiA9ICZnZXRfaXZyc19tYXBwaW5ncyhpb21tdS0+c2VnKVtyZXFfaWRd
OwogCisgICAgaWYgKCBkb21haW4gIT0gZG9tX2lvICkKKyAgICB7CisgICAg
ICAgIHJvb3RfcGcgPSBoZC0+YXJjaC5yb290X3RhYmxlOworICAgICAgICBk
b21pZCA9IGRvbWFpbi0+ZG9tYWluX2lkOworICAgIH0KKyAgICBlbHNlCisg
ICAgeworICAgICAgICByb290X3BnID0gcGRldi0+YXJjaC5hbWQucm9vdF90
YWJsZTsKKyAgICAgICAgZG9taWQgPSBwZGV2LT5hcmNoLnBzZXVkb19kb21p
ZDsKKyAgICB9CisKICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmaW9tbXUtPmxv
Y2ssIGZsYWdzKTsKIAogICAgIGlmICggIWR0ZS0+diB8fCAhZHRlLT50diAp
CiAgICAgewogICAgICAgICAvKiBiaW5kIERURSB0byBkb21haW4gcGFnZS10
YWJsZXMgKi8KICAgICAgICAgcmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFn
ZV90YWJsZSgKLSAgICAgICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRy
KGhkLT5hcmNoLnJvb3RfdGFibGUpLAotICAgICAgICAgICAgICAgICBkb21h
aW4tPmRvbWFpbl9pZCwgaGQtPmFyY2gucGFnaW5nX21vZGUsIHNyX2ZsYWdz
KTsKKyAgICAgICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRyKHJvb3Rf
cGcpLCBkb21pZCwKKyAgICAgICAgICAgICAgICAgaGQtPmFyY2gucGFnaW5n
X21vZGUsIHNyX2ZsYWdzKTsKICAgICAgICAgaWYgKCByYyApCiAgICAgICAg
IHsKICAgICAgICAgICAgIEFTU0VSVChyYyA8IDApOwpAQCAtMTcyLDcgKzE4
NSw3IEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1
cF8KIAogICAgICAgICBhbWRfaW9tbXVfZmx1c2hfZGV2aWNlKGlvbW11LCBy
ZXFfaWQpOwogICAgIH0KLSAgICBlbHNlIGlmICggZHRlLT5wdF9yb290ICE9
IG1mbl94KHBhZ2VfdG9fbWZuKGhkLT5hcmNoLnJvb3RfdGFibGUpKSApCisg
ICAgZWxzZSBpZiAoIGR0ZS0+cHRfcm9vdCAhPSBtZm5feChwYWdlX3RvX21m
bihyb290X3BnKSkgKQogICAgIHsKICAgICAgICAgLyoKICAgICAgICAgICog
U3RyaWN0bHkgc3BlYWtpbmcgaWYgdGhlIGRldmljZSBpcyB0aGUgb25seSBv
bmUgd2l0aCB0aGlzIHJlcXVlc3RvcgpAQCAtMTg1LDggKzE5OCw4IEBAIHN0
YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICAg
ICAgICAgIHJjID0gLUVPUE5PVFNVUFA7CiAgICAgICAgIGVsc2UKICAgICAg
ICAgICAgIHJjID0gYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoCi0g
ICAgICAgICAgICAgICAgICAgICBkdGUsIHBhZ2VfdG9fbWFkZHIoaGQtPmFy
Y2gucm9vdF90YWJsZSksCi0gICAgICAgICAgICAgICAgICAgICBkb21haW4t
PmRvbWFpbl9pZCwgaGQtPmFyY2gucGFnaW5nX21vZGUsIHNyX2ZsYWdzKTsK
KyAgICAgICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkcihyb290
X3BnKSwgZG9taWQsCisgICAgICAgICAgICAgICAgICAgICBoZC0+YXJjaC5w
YWdpbmdfbW9kZSwgc3JfZmxhZ3MpOwogICAgICAgICBpZiAoIHJjIDwgMCAp
CiAgICAgICAgIHsKICAgICAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3Rv
cmUoJmlvbW11LT5sb2NrLCBmbGFncyk7CkBAIC0yMDUsNiArMjE4LDcgQEAg
c3RhdGljIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwogICAg
ICAgICAgICAgICAqIGludGVuZGVkIGFueXdheS4KICAgICAgICAgICAgICAg
Ki8KICAgICAgICAgICAgICAhcGRldi0+ZG9tYWluLT5pc19keWluZyAmJgor
ICAgICAgICAgICAgIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gJiYKICAgICAg
ICAgICAgICAoYW55X3BkZXZfYmVoaW5kX2lvbW11KHBkZXYtPmRvbWFpbiwg
cGRldiwgaW9tbXUpIHx8CiAgICAgICAgICAgICAgIHBkZXYtPnBoYW50b21f
c3RyaWRlKSApCiAgICAgICAgICAgICBwcmludGsoIiAlMDR4OiUwMng6JTAy
eC4ldTogcmVhc3NpZ25tZW50IG1heSBjYXVzZSAlcGQgZGF0YSBjb3JydXB0
aW9uXG4iLApAQCAtMjM1LDkgKzI0OSw4IEBAIHN0YXRpYyBpbnQgX19tdXN0
X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICBBTURfSU9NTVVfREVCVUco
IlNldHVwIEkvTyBwYWdlIHRhYmxlOiBkZXZpY2UgaWQgPSAlI3gsIHR5cGUg
PSAlI3gsICIKICAgICAgICAgICAgICAgICAgICAgInJvb3QgdGFibGUgPSAl
IyJQUkl4NjQiLCAiCiAgICAgICAgICAgICAgICAgICAgICJkb21haW4gPSAl
ZCwgcGFnaW5nIG1vZGUgPSAlZFxuIiwKLSAgICAgICAgICAgICAgICAgICAg
cmVxX2lkLCBwZGV2LT50eXBlLAotICAgICAgICAgICAgICAgICAgICBwYWdl
X3RvX21hZGRyKGhkLT5hcmNoLnJvb3RfdGFibGUpLAotICAgICAgICAgICAg
ICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2gucGFnaW5nX21v
ZGUpOworICAgICAgICAgICAgICAgICAgICByZXFfaWQsIHBkZXYtPnR5cGUs
IHBhZ2VfdG9fbWFkZHIocm9vdF9wZyksCisgICAgICAgICAgICAgICAgICAg
IGRvbWlkLCBoZC0+YXJjaC5wYWdpbmdfbW9kZSk7CiAKICAgICBBU1NFUlQo
cGNpZGV2c19sb2NrZWQoKSk7CiAKQEAgLTMwNCw3ICszMTcsNyBAQCBzdGF0
aWMgaW50IGlvdl9lbmFibGVfeHQodm9pZCkKIAogaW50IGFtZF9pb21tdV9h
bGxvY19yb290KHN0cnVjdCBkb21haW5faW9tbXUgKmhkKQogewotICAgIGlm
ICggdW5saWtlbHkoIWhkLT5hcmNoLnJvb3RfdGFibGUpICkKKyAgICBpZiAo
IHVubGlrZWx5KCFoZC0+YXJjaC5yb290X3RhYmxlKSAmJiBoZCAhPSBkb21f
aW9tbXUoZG9tX2lvKSApCiAgICAgewogICAgICAgICBoZC0+YXJjaC5yb290
X3RhYmxlID0gYWxsb2NfYW1kX2lvbW11X3BndGFibGUoKTsKICAgICAgICAg
aWYgKCAhaGQtPmFyY2gucm9vdF90YWJsZSApCkBAIC0zOTUsNyArNDA4LDcg
QEAgc3RhdGljIHZvaWQgYW1kX2lvbW11X2Rpc2FibGVfZG9tYWluX2Rldgog
CiAgICAgICAgIEFNRF9JT01NVV9ERUJVRygiRGlzYWJsZTogZGV2aWNlIGlk
ID0gJSN4LCAiCiAgICAgICAgICAgICAgICAgICAgICAgICAiZG9tYWluID0g
JWQsIHBhZ2luZyBtb2RlID0gJWRcbiIsCi0gICAgICAgICAgICAgICAgICAg
ICAgICByZXFfaWQsICBkb21haW4tPmRvbWFpbl9pZCwKKyAgICAgICAgICAg
ICAgICAgICAgICAgIHJlcV9pZCwgZHRlLT5kb21haW5faWQsCiAgICAgICAg
ICAgICAgICAgICAgICAgICBkb21faW9tbXUoZG9tYWluKS0+YXJjaC5wYWdp
bmdfbW9kZSk7CiAgICAgfQogICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUo
JmlvbW11LT5sb2NrLCBmbGFncyk7CkBAIC02NTksNiArNjcyLDggQEAgc3Rh
dGljIGludCBhbWRfaW9tbXVfcmVtb3ZlX2RldmljZSh1OCBkZQogCiAgICAg
YW1kX2lvbW11X2Rpc2FibGVfZG9tYWluX2RldmljZShwZGV2LT5kb21haW4s
IGlvbW11LCBkZXZmbiwgcGRldik7CiAKKyAgICBhbWRfaW9tbXVfcXVhcmFu
dGluZV90ZWFyZG93bihwZGV2KTsKKwogICAgIGlvbW11X2ZyZWVfZG9taWQo
cGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsIGlvbW11LT5kb21pZF9tYXApOwog
ICAgIHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID0gRE9NSURfSU5WQUxJRDsK
IAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9pb21tdS5jCisrKyBi
L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMKQEAgLTQ0NywyMSAr
NDQ3LDIxIEBAIGludCBpb21tdV9pb3RsYl9mbHVzaF9hbGwoc3RydWN0IGRv
bWFpbgogICAgIHJldHVybiByYzsKIH0KIAotc3RhdGljIGludCBfX2luaXQg
aW9tbXVfcXVhcmFudGluZV9pbml0KHZvaWQpCitpbnQgaW9tbXVfcXVhcmFu
dGluZV9kZXZfaW5pdChkZXZpY2VfdCAqZGV2KQogewogICAgIGNvbnN0IHN0
cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbV9pbyk7Ci0g
ICAgaW50IHJjOwogCi0gICAgZG9tX2lvLT5vcHRpb25zIHw9IFhFTl9ET01D
VExfQ0RGX2lvbW11OworICAgIGlmICggIWlvbW11X3F1YXJhbnRpbmUgfHwg
IWhkLT5wbGF0Zm9ybV9vcHMtPnF1YXJhbnRpbmVfaW5pdCApCisgICAgICAg
IHJldHVybiAwOwogCi0gICAgcmMgPSBpb21tdV9kb21haW5faW5pdChkb21f
aW8sIDApOwotICAgIGlmICggcmMgKQotICAgICAgICByZXR1cm4gcmM7Cisg
ICAgcmV0dXJuIGlvbW11X2NhbGwoaGQtPnBsYXRmb3JtX29wcywgcXVhcmFu
dGluZV9pbml0LCBkZXYpOworfQogCi0gICAgaWYgKCAhaGQtPnBsYXRmb3Jt
X29wcy0+cXVhcmFudGluZV9pbml0ICkKLSAgICAgICAgcmV0dXJuIDA7Citz
dGF0aWMgaW50IF9faW5pdCBpb21tdV9xdWFyYW50aW5lX2luaXQodm9pZCkK
K3sKKyAgICBkb21faW8tPm9wdGlvbnMgfD0gWEVOX0RPTUNUTF9DREZfaW9t
bXU7CiAKLSAgICByZXR1cm4gaGQtPnBsYXRmb3JtX29wcy0+cXVhcmFudGlu
ZV9pbml0KGRvbV9pbyk7CisgICAgcmV0dXJuIGlvbW11X2RvbWFpbl9pbml0
KGRvbV9pbywgMCk7CiB9CiAKIGludCBfX2luaXQgaW9tbXVfc2V0dXAodm9p
ZCkKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMKKysrIGIv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMKQEAgLTkyOSw5ICs5Mjks
MTYgQEAgc3RhdGljIGludCBkZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFp
bgogICAgICAgICByZXR1cm4gLUVOT0RFVjsKIAogICAgIC8qIERlLWFzc2ln
bm1lbnQgZnJvbSBkb21faW8gc2hvdWxkIGRlLXF1YXJhbnRpbmUgdGhlIGRl
dmljZSAqLwotICAgIHRhcmdldCA9ICgocGRldi0+cXVhcmFudGluZSB8fCBp
b21tdV9xdWFyYW50aW5lKSAmJgotICAgICAgICAgICAgICBwZGV2LT5kb21h
aW4gIT0gZG9tX2lvKSA/Ci0gICAgICAgIGRvbV9pbyA6IGhhcmR3YXJlX2Rv
bWFpbjsKKyAgICBpZiAoIChwZGV2LT5xdWFyYW50aW5lIHx8IGlvbW11X3F1
YXJhbnRpbmUpICYmIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gKQorICAgIHsK
KyAgICAgICAgcmV0ID0gaW9tbXVfcXVhcmFudGluZV9kZXZfaW5pdChwY2lf
dG9fZGV2KHBkZXYpKTsKKyAgICAgICAgaWYgKCByZXQgKQorICAgICAgICAg
ICByZXR1cm4gcmV0OworCisgICAgICAgIHRhcmdldCA9IGRvbV9pbzsKKyAg
ICB9CisgICAgZWxzZQorICAgICAgICB0YXJnZXQgPSBoYXJkd2FyZV9kb21h
aW47CiAKICAgICB3aGlsZSAoIHBkZXYtPnBoYW50b21fc3RyaWRlICkKICAg
ICB7CkBAIC0xNTI4LDYgKzE1MzUsMTMgQEAgc3RhdGljIGludCBhc3NpZ25f
ZGV2aWNlKHN0cnVjdCBkb21haW4gKgogICAgICAgICBtc2l4dGJsX2luaXQo
ZCk7CiAgICAgfQogCisgICAgaWYgKCBwZGV2LT5kb21haW4gIT0gZG9tX2lv
ICkKKyAgICB7CisgICAgICAgIHJjID0gaW9tbXVfcXVhcmFudGluZV9kZXZf
aW5pdChwY2lfdG9fZGV2KHBkZXYpKTsKKyAgICAgICAgaWYgKCByYyApCisg
ICAgICAgICAgICBnb3RvIGRvbmU7CisgICAgfQorCiAgICAgcGRldi0+ZmF1
bHQuY291bnQgPSAwOwogCiAgICAgaWYgKCAocmMgPSBoZC0+cGxhdGZvcm1f
b3BzLT5hc3NpZ25fZGV2aWNlKGQsIGRldmZuLCBwY2lfdG9fZGV2KHBkZXYp
LCBmbGFnKSkgKQotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv
aW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t
bXUuYwpAQCAtNDMsNiArNDMsMTIgQEAKICNpbmNsdWRlICJ2dGQuaCIKICNp
bmNsdWRlICIuLi9hdHMuaCIKIAorI2RlZmluZSBERVZJQ0VfRE9NSUQoZCwg
cGRldikgKChkKSAhPSBkb21faW8gPyAoZCktPmRvbWFpbl9pZCBcCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IChw
ZGV2KS0+YXJjaC5wc2V1ZG9fZG9taWQpCisjZGVmaW5lIERFVklDRV9QR1RB
QkxFKGQsIHBkZXYpICgoZCkgIT0gZG9tX2lvIFwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgID8gZG9tX2lvbW11KGQpLT5hcmNoLnBnZF9t
YWRkciBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IChw
ZGV2KS0+YXJjaC52dGQucGdkX21hZGRyKQorCiAvKiBQb3NzaWJsZSB1bmZp
bHRlcmVkIExBUElDL01TSSBtZXNzYWdlcyBmcm9tIHVudHJ1c3RlZCBzb3Vy
Y2VzPyAqLwogYm9vbCBfX3JlYWRfbW9zdGx5IHVudHJ1c3RlZF9tc2k7CiAK
QEAgLTg0LDEzICs5MCwxOCBAQCBzdGF0aWMgaW50IGdldF9pb21tdV9kaWQo
ZG9taWRfdCBkb21pZCwKIAogI2RlZmluZSBESURfRklFTERfV0lEVEggMTYK
ICNkZWZpbmUgRElEX0hJR0hfT0ZGU0VUIDgKKworLyoKKyAqIFRoaXMgZnVu
Y3Rpb24gbWF5IGhhdmUgImNvbnRleHQiIHBhc3NlZCBhcyBOVUxMLCB0byBt
ZXJlbHkgb2J0YWluIGEgRElECisgKiBmb3IgImRvbWlkIi4KKyAqLwogc3Rh
dGljIGludCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0IGNvbnRleHRf
ZW50cnkgKmNvbnRleHQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBkb21pZF90IGRvbWlkLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkK
IHsKICAgICB1bnNpZ25lZCBsb25nIG5yX2RvbSwgaTsKICAgICBpbnQgZm91
bmQgPSAwOwogCi0gICAgQVNTRVJUKHNwaW5faXNfbG9ja2VkKCZpb21tdS0+
bG9jaykpOworICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKIAogICAg
IG5yX2RvbSA9IGNhcF9uZG9tcyhpb21tdS0+Y2FwKTsKICAgICBpID0gZmlu
ZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsKQEAg
LTExNiw4ICsxMjcsMTMgQEAgc3RhdGljIGludCBjb250ZXh0X3NldF9kb21h
aW5faWQoc3RydWN0CiAgICAgfQogCiAgICAgc2V0X2JpdChpLCBpb21tdS0+
ZG9taWRfYml0bWFwKTsKLSAgICBjb250ZXh0LT5oaSAmPSB+KCgoMSA8PCBE
SURfRklFTERfV0lEVEgpIC0gMSkgPDwgRElEX0hJR0hfT0ZGU0VUKTsKLSAg
ICBjb250ZXh0LT5oaSB8PSAoaSAmICgoMSA8PCBESURfRklFTERfV0lEVEgp
IC0gMSkpIDw8IERJRF9ISUdIX09GRlNFVDsKKworICAgIGlmICggY29udGV4
dCApCisgICAgeworICAgICAgICBjb250ZXh0LT5oaSAmPSB+KCgoMSA8PCBE
SURfRklFTERfV0lEVEgpIC0gMSkgPDwgRElEX0hJR0hfT0ZGU0VUKTsKKyAg
ICAgICAgY29udGV4dC0+aGkgfD0gKGkgJiAoKDEgPDwgRElEX0ZJRUxEX1dJ
RFRIKSAtIDEpKSA8PCBESURfSElHSF9PRkZTRVQ7CisgICAgfQorCiAgICAg
cmV0dXJuIDA7CiB9CiAKQEAgLTE2Nyw4ICsxODMsMTIgQEAgc3RhdGljIHZv
aWQgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAoc3RydQogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYg
KmV4Y2x1ZGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKIHsKLSAgICBib29sIGZvdW5k
ID0gYW55X3BkZXZfYmVoaW5kX2lvbW11KGQsIGV4Y2x1ZGUsIGlvbW11KTsK
KyAgICBib29sIGZvdW5kOworCisgICAgaWYgKCBkID09IGRvbV9pbyApCisg
ICAgICAgIHJldHVybjsKIAorICAgIGZvdW5kID0gYW55X3BkZXZfYmVoaW5k
X2lvbW11KGQsIGV4Y2x1ZGUsIGlvbW11KTsKICAgICAvKgogICAgICAqIEhp
ZGRlbiBkZXZpY2VzIGFyZSBhc3NvY2lhdGVkIHdpdGggRG9tWEVOIGJ1dCB1
c2FibGUgYnkgdGhlIGhhcmR3YXJlCiAgICAgICogZG9tYWluLiBIZW5jZSB0
aGV5IG5lZWQgY29uc2lkZXJpbmcgaGVyZSBhcyB3ZWxsLgpAQCAtMTQwMyw3
ICsxNDIzLDcgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAog
ICAgICAgICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbcHJldl9kaWRdOwog
ICAgICAgICBpZiAoIGRvbWlkIDwgRE9NSURfRklSU1RfUkVTRVJWRUQgKQog
ICAgICAgICAgICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW5fYnlfaWQo
ZG9taWQpOwotICAgICAgICBlbHNlIGlmICggZG9taWQgPT0gRE9NSURfSU8g
KQorICAgICAgICBlbHNlIGlmICggcGRldiA/IGRvbWlkID09IHBkZXYtPmFy
Y2gucHNldWRvX2RvbWlkIDogZG9taWQgPiBET01JRF9NQVNLICkKICAgICAg
ICAgICAgIHByZXZfZG9tID0gcmN1X2xvY2tfZG9tYWluKGRvbV9pbyk7CiAg
ICAgICAgIGlmICggIXByZXZfZG9tICkKICAgICAgICAgewpAQCAtMTU4MCwx
NSArMTYwMCwxMiBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUo
CiAgICAgewogICAgICAgICBpZiAoICFwcmV2X2RvbSApCiAgICAgICAgICAg
ICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21t
dSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7CisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlE
KGRvbWFpbiwgcGRldikpOwogICAgICAgICBlbHNlIGlmICggcHJldl9kb20g
IT0gZG9tYWluICkgLyogQXZvaWQgaW5maW5pdGUgcmVjdXJzaW9uLiAqLwot
ICAgICAgICB7Ci0gICAgICAgICAgICBoZCA9IGRvbV9pb21tdShwcmV2X2Rv
bSk7CiAgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5n
X29uZShwcmV2X2RvbSwgaW9tbXUsIGJ1cywgZGV2Zm4sIHBkZXYsCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21h
aW4tPmRvbWFpbl9pZCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGhkLT5hcmNoLnBnZF9tYWRkciwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERFVklDRV9E
T01JRChwcmV2X2RvbSwgcGRldiksCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBERVZJQ0VfUEdUQUJMRShwcmV2X2Rv
bSwgcGRldiksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBtb2RlICYgTUFQX1dJVEhfUk1SUikgPCAwOwotICAgICAg
ICB9CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHJldCA9IDE7CiAKQEAg
LTE2MTAsNyArMTYyNyw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRf
bWFwcGluZyhzdHJ1Y3QKIHsKICAgICBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQg
KmRyaGQ7CiAgICAgY29uc3Qgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJy
OwotICAgIHBhZGRyX3QgcGdkX21hZGRyID0gZG9tX2lvbW11KGRvbWFpbikt
PmFyY2gucGdkX21hZGRyOworICAgIHBhZGRyX3QgcGdkX21hZGRyID0gREVW
SUNFX1BHVEFCTEUoZG9tYWluLCBwZGV2KTsKICAgICBkb21pZF90IG9yaWdf
ZG9taWQgPSBwZGV2LT5hcmNoLnBzZXVkb19kb21pZDsKICAgICBpbnQgcmV0
ID0gMDsKICAgICB1bnNpZ25lZCBpbnQgaSwgbW9kZSA9IDA7CkBAIC0xNjQz
LDcgKzE2NjAsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBp
bmcoc3RydWN0CiAgICAgICAgIGJyZWFrOwogICAgIH0KIAotICAgIGlmICgg
ZG9tYWluICE9IHBkZXYtPmRvbWFpbiApCisgICAgaWYgKCBkb21haW4gIT0g
cGRldi0+ZG9tYWluICYmIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gKQogICAg
IHsKICAgICAgICAgaWYgKCBwZGV2LT5kb21haW4tPmlzX2R5aW5nICkKICAg
ICAgICAgICAgIG1vZGUgfD0gTUFQX09XTkVSX0RZSU5HOwpAQCAtMTY4NCw4
ICsxNzAxLDggQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5n
KHN0cnVjdAogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiZCVkOlBD
SWU6IG1hcCAlMDR4OiUwMng6JTAyeC4ldVxuIiwKICAgICAgICAgICAgICAg
ICAgICBkb21haW4tPmRvbWFpbl9pZCwgc2VnLCBidXMsCiAgICAgICAgICAg
ICAgICAgICAgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikpOwot
ICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21h
aW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBkb21haW4tPmRvbWFp
bl9pZCwgcGdkX21hZGRyLAorICAgICAgICByZXQgPSBkb21haW5fY29udGV4
dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZu
LCBwZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSwgcGdkX21hZGRyLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtb2Rl
KTsKICAgICAgICAgaWYgKCByZXQgPiAwICkKICAgICAgICAgICAgIHJldCA9
IDA7CkBAIC0xNzA5LDggKzE3MjYsOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9j
b250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAgICAgICAgICAgUENJ
X1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbikpOwogCiAgICAgICAgIHJl
dCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+
aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHBkZXYsIGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2Rf
bWFkZHIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIG1vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBwZGV2LCBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGdkX21h
ZGRyLCBtb2RlKTsKICAgICAgICAgaWYgKCByZXQgPCAwICkKICAgICAgICAg
ICAgIGJyZWFrOwogICAgICAgICBwcmV2X3ByZXNlbnQgPSByZXQ7CkBAIC0x
NzM4LDggKzE3NTUsOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21h
cHBpbmcoc3RydWN0CiAgICAgICAgICAqLwogICAgICAgICBpZiAoIHJldCA+
PSAwICkKICAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxM
LCBkb21haW4tPmRvbWFpbl9pZCwgcGdkX21hZGRyLAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbW9kZSk7CisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxM
LCBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBnZF9tYWRkciwgbW9k
ZSk7CiAKICAgICAgICAgLyoKICAgICAgICAgICogRGV2aWNlcyBiZWhpbmQg
UENJZS10by1QQ0kvUENJeCBicmlkZ2UgbWF5IGdlbmVyYXRlIGRpZmZlcmVu
dApAQCAtMTc1NCw4ICsxNzcxLDggQEAgc3RhdGljIGludCBkb21haW5fY29u
dGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICBpZiAoICFyZXQgJiYgcGRl
dl90eXBlKHNlZywgYnVzLCBkZXZmbikgPT0gREVWX1RZUEVfUENJZTJQQ0lf
QlJJREdFICYmCiAgICAgICAgICAgICAgKHNlY2J1cyAhPSBwZGV2LT5idXMg
fHwgcGRldi0+ZGV2Zm4gIT0gMCkgKQogICAgICAgICAgICAgcmV0ID0gZG9t
YWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwg
c2VjYnVzLCAwLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgTlVMTCwgZG9tYWluLT5kb21haW5faWQsIHBnZF9tYWRk
ciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIG1vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgTlVMTCwgREVWSUNFX0RPTUlEKGRvbWFpbiwgcGRldiks
CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBwZ2RfbWFkZHIsIG1vZGUpOwogCiAgICAgICAgIGlmICggcmV0ICkKICAg
ICAgICAgewpAQCAtMTkwNSw3ICsxOTIyLDcgQEAgc3RhdGljIGNvbnN0IHN0
cnVjdCBhY3BpX2RyaGRfdW5pdCAqZG9tYQogICAgICAgICAgICAgICAgICAg
IGRvbWFpbi0+ZG9tYWluX2lkLCBzZWcsIGJ1cywKICAgICAgICAgICAgICAg
ICAgICBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSk7CiAgICAg
ICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlv
bW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlEKGRvbWFp
biwgcGRldikpOwogICAgICAgICBpZiAoICFyZXQgJiYgZGV2Zm4gPT0gcGRl
di0+ZGV2Zm4gJiYgYXRzX2RldmljZShwZGV2LCBkcmhkKSA+IDAgKQogICAg
ICAgICAgICAgZGlzYWJsZV9hdHNfZGV2aWNlKHBkZXYpOwogCkBAIC0xOTE2
LDcgKzE5MzMsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91
bml0ICpkb21hCiAgICAgICAgICAgICBwcmludGsoVlREUFJFRklYICJkJWQ6
UENJOiB1bm1hcCAlMDR4OiUwMng6JTAyeC4ldVxuIiwKICAgICAgICAgICAg
ICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgc2VnLCBidXMsIFBDSV9TTE9U
KGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pKTsKICAgICAgICAgcmV0ID0gZG9t
YWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2
Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBk
b21haW4tPmRvbWFpbl9pZCk7CisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7CiAg
ICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIGJyZWFrOwogCkBAIC0x
OTM5LDE4ICsxOTU2LDEyIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYWNwaV9k
cmhkX3VuaXQgKmRvbWEKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9
CiAKKyAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRv
bWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIERFVklDRV9ET01JRChkb21h
aW4sIHBkZXYpKTsKICAgICAgICAgLyogUENJZSB0byBQQ0kvUENJeCBicmlk
Z2UgKi8KLSAgICAgICAgaWYgKCBwZGV2X3R5cGUoc2VnLCB0bXBfYnVzLCB0
bXBfZGV2Zm4pID09IERFVl9UWVBFX1BDSWUyUENJX0JSSURHRSApCi0gICAg
ICAgIHsKLSAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFw
X29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWlu
LT5kb21haW5faWQpOwotICAgICAgICAgICAgaWYgKCAhcmV0ICkKLSAgICAg
ICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9t
YWluLCBpb21tdSwgc2VjYnVzLCAwLAotICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7
Ci0gICAgICAgIH0KLSAgICAgICAgZWxzZSAvKiBMZWdhY3kgUENJIGJyaWRn
ZSAqLwotICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBf
b25lKGRvbWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4t
PmRvbWFpbl9pZCk7CisgICAgICAgIGlmICggIXJldCAmJiBwZGV2X3R5cGUo
c2VnLCB0bXBfYnVzLCB0bXBfZGV2Zm4pID09IERFVl9UWVBFX1BDSWUyUENJ
X0JSSURHRSApCisgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91
bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgc2VjYnVzLCAwLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERFVklDRV9ET01J
RChkb21haW4sIHBkZXYpKTsKIAogICAgICAgICBicmVhazsKIApAQCAtMTk5
Myw2ICsyMDA0LDI1IEBAIHN0YXRpYyB2b2lkIGlvbW11X2RvbWFpbl90ZWFy
ZG93bihzdHJ1Y3QKICAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZC0+ZG9t
YWluX2lkLCBkcmhkLT5pb21tdSk7CiB9CiAKK3N0YXRpYyB2b2lkIHF1YXJh
bnRpbmVfdGVhcmRvd24oc3RydWN0IHBjaV9kZXYgKnBkZXYsCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBhY3BpX2Ry
aGRfdW5pdCAqZHJoZCkKK3sKKyAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsK
KworICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKKworICAgIGlmICgg
IXBkZXYtPmFyY2gudnRkLnBnZF9tYWRkciApCisgICAgICAgIHJldHVybjsK
KworICAgIHdoaWxlICggKHBnID0gcGFnZV9saXN0X3JlbW92ZV9oZWFkKCZw
ZGV2LT5hcmNoLnBndGFibGVzX2xpc3QpKSApCisgICAgICAgIGZyZWVfZG9t
aGVhcF9wYWdlKHBnKTsKKworICAgIHBkZXYtPmFyY2gudnRkLnBnZF9tYWRk
ciA9IDA7CisKKyAgICBpZiAoIGRyaGQgKQorICAgICAgICBjbGVhbnVwX2Rv
bWlkX21hcChwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwgZHJoZC0+aW9tbXUp
OworfQorCiBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBpbnRlbF9pb21tdV9t
YXBfcGFnZShzdHJ1Y3QgZG9tYWluICpkLCBkZm5fdCBkZm4sCiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZm5fdCBt
Zm4sIHVuc2lnbmVkIGludCBmbGFncywKICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCAqZmx1c2hf
ZmxhZ3MpCkBAIC0yMjE3LDYgKzIyNDcsOCBAQCBzdGF0aWMgaW50IGludGVs
X2lvbW11X3JlbW92ZV9kZXZpY2UodTgKICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7CiAgICAgfQogCisg
ICAgcXVhcmFudGluZV90ZWFyZG93bihwZGV2LCBkcmhkKTsKKwogICAgIGlm
ICggZHJoZCApCiAgICAgewogICAgICAgICBpb21tdV9mcmVlX2RvbWlkKHBk
ZXYtPmFyY2gucHNldWRvX2RvbWlkLApAQCAtMjkwOCw2MCArMjk0MCwxMzkg
QEAgc3RhdGljIHZvaWQgdnRkX2R1bXBfcDJtX3RhYmxlKHN0cnVjdCBkbwog
ICAgIHZ0ZF9kdW1wX3AybV90YWJsZV9sZXZlbChoZC0+YXJjaC5wZ2RfbWFk
ZHIsIGFnYXdfdG9fbGV2ZWwoaGQtPmFyY2guYWdhdyksIDAsIDApOwogfQog
Ci1zdGF0aWMgaW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFyYW50aW5lX2lu
aXQoc3RydWN0IGRvbWFpbiAqZCkKK3N0YXRpYyBpbnQgZmlsbF9xcHQoc3Ry
dWN0IGRtYV9wdGUgKnRoaXMsIHVuc2lnbmVkIGludCBsZXZlbCwKKyAgICAg
ICAgICAgICAgICAgICAgcGFkZHJfdCBtYWRkcnNbNl0sIHN0cnVjdCBwY2lf
ZGV2ICpwZGV2KQogewotICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0g
ZG9tX2lvbW11KGQpOwotICAgIHN0cnVjdCBkbWFfcHRlICpwYXJlbnQ7Cisg
ICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZG9tX2lv
KTsKKyAgICB1bnNpZ25lZCBpbnQgaTsKKyAgICBpbnQgcmMgPSAwOworCisg
ICAgZm9yICggaSA9IDA7ICFyYyAmJiBpIDwgUFRFX05VTTsgKytpICkKKyAg
ICB7CisgICAgICAgIHN0cnVjdCBkbWFfcHRlICpwdGUgPSAmdGhpc1tpXSwg
Km5leHQ7CisKKyAgICAgICAgaWYgKCAhZG1hX3B0ZV9wcmVzZW50KCpwdGUp
ICkKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKCAhbWFkZHJzW2xldmVs
XSApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgLyoKKyAgICAg
ICAgICAgICAgICAgKiBUaGUgcGd0YWJsZSBhbGxvY2F0b3IgaXMgZmluZSBm
b3IgdGhlIGxlYWYgcGFnZSwgYXMgd2VsbCBhcworICAgICAgICAgICAgICAg
ICAqIHBhZ2UgdGFibGUgcGFnZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9j
YXRpb25zIGFyZSBhbHdheXMKKyAgICAgICAgICAgICAgICAgKiB6ZXJvZWQu
CisgICAgICAgICAgICAgICAgICovCisgICAgICAgICAgICAgICAgbWFkZHJz
W2xldmVsXSA9IGFsbG9jX3BndGFibGVfbWFkZHIoMSwgaGQtPm5vZGUpOwor
ICAgICAgICAgICAgICAgIGlmICggIW1hZGRyc1tsZXZlbF0gKQorICAgICAg
ICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICAgICAgcmMgPSAtRU5PTUVN
OworICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAg
ICB9CisKKyAgICAgICAgICAgICAgICBwYWdlX2xpc3RfYWRkKG1hZGRyX3Rv
X3BhZ2UobWFkZHJzW2xldmVsXSksCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAmcGRldi0+YXJjaC5wZ3RhYmxlc19saXN0KTsKKworICAgICAg
ICAgICAgICAgIGlmICggbGV2ZWwgKQorICAgICAgICAgICAgICAgIHsKKyAg
ICAgICAgICAgICAgICAgICAgbmV4dCA9IG1hcF92dGRfZG9tYWluX3BhZ2Uo
bWFkZHJzW2xldmVsXSk7CisgICAgICAgICAgICAgICAgICAgIHJjID0gZmls
bF9xcHQobmV4dCwgbGV2ZWwgLSAxLCBtYWRkcnMsIHBkZXYpOworICAgICAg
ICAgICAgICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UobmV4dCk7Cisg
ICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorCisgICAgICAgICAg
ICBkbWFfc2V0X3B0ZV9hZGRyKCpwdGUsIG1hZGRyc1tsZXZlbF0pOworICAg
ICAgICAgICAgZG1hX3NldF9wdGVfcmVhZGFibGUoKnB0ZSk7CisgICAgICAg
ICAgICBkbWFfc2V0X3B0ZV93cml0YWJsZSgqcHRlKTsKKyAgICAgICAgfQor
ICAgICAgICBlbHNlIGlmICggbGV2ZWwgJiYgIWRtYV9wdGVfc3VwZXJwYWdl
KCpwdGUpICkKKyAgICAgICAgeworICAgICAgICAgICAgcGFnZV9saXN0X2Fk
ZChtYWRkcl90b19wYWdlKGRtYV9wdGVfYWRkcigqcHRlKSksCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICZwZGV2LT5hcmNoLnBndGFibGVzX2xpc3Qp
OworICAgICAgICAgICAgbmV4dCA9IG1hcF92dGRfZG9tYWluX3BhZ2UoZG1h
X3B0ZV9hZGRyKCpwdGUpKTsKKyAgICAgICAgICAgIHJjID0gZmlsbF9xcHQo
bmV4dCwgbGV2ZWwgLSAxLCBtYWRkcnMsIHBkZXYpOworICAgICAgICAgICAg
dW5tYXBfdnRkX2RvbWFpbl9wYWdlKG5leHQpOworICAgICAgICB9CisgICAg
fQorCisgICAgcmV0dXJuIHJjOworfQorCitzdGF0aWMgaW50IGludGVsX2lv
bW11X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3QgcGNpX2RldiAqcGRldikKK3sK
KyAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21f
aW8pOworICAgIHBhZGRyX3QgbWFkZHI7CiAgICAgdW5zaWduZWQgaW50IGFn
YXcgPSB3aWR0aF90b19hZ2F3KERFRkFVTFRfRE9NQUlOX0FERFJFU1NfV0lE
VEgpOwogICAgIHVuc2lnbmVkIGludCBsZXZlbCA9IGFnYXdfdG9fbGV2ZWwo
YWdhdyk7CisgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhk
OworICAgIGNvbnN0IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKKyAg
ICB1bnNpZ25lZCBpbnQgaSwgYmRmOworICAgIGJvb2wgcm1ycl9mb3VuZCA9
IGZhbHNlOworICAgIGludCByYzsKIAotICAgIGlmICggaGQtPmFyY2gucGdk
X21hZGRyICkKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CisgICAg
QVNTRVJUKCFoZC0+YXJjaC5wZ2RfbWFkZHIpOworCisgICAgaWYgKCBwZGV2
LT5hcmNoLnZ0ZC5wZ2RfbWFkZHIgKQogICAgIHsKLSAgICAgICAgQVNTRVJU
X1VOUkVBQ0hBQkxFKCk7CisgICAgICAgIGNsZWFyX2RvbWFpbl9wYWdlKHBk
ZXYtPmFyY2gubGVhZl9tZm4pOwogICAgICAgICByZXR1cm4gMDsKICAgICB9
CiAKLSAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7Cisg
ICAgZHJoZCA9IGFjcGlfZmluZF9tYXRjaGVkX2RyaGRfdW5pdChwZGV2KTsK
KyAgICBpZiAoICFkcmhkICkKKyAgICAgICAgcmV0dXJuIC1FTk9ERVY7CiAK
LSAgICBoZC0+YXJjaC5wZ2RfbWFkZHIgPSBhbGxvY19wZ3RhYmxlX21hZGRy
KDEsIGhkLT5ub2RlKTsKLSAgICBpZiAoICFoZC0+YXJjaC5wZ2RfbWFkZHIg
KQotICAgICAgICBnb3RvIG91dDsKKyAgICBtYWRkciA9IGFsbG9jX3BndGFi
bGVfbWFkZHIoMSwgaGQtPm5vZGUpOworICAgIGlmICggIW1hZGRyICkKKyAg
ICAgICAgcmV0dXJuIC1FTk9NRU07CiAKLSAgICBwYXJlbnQgPSBtYXBfdnRk
X2RvbWFpbl9wYWdlKGhkLT5hcmNoLnBnZF9tYWRkcik7Ci0gICAgd2hpbGUg
KCBsZXZlbCApCi0gICAgewotICAgICAgICB1aW50NjRfdCBtYWRkcjsKLSAg
ICAgICAgdW5zaWduZWQgaW50IG9mZnNldDsKKyAgICByYyA9IGNvbnRleHRf
c2V0X2RvbWFpbl9pZChOVUxMLCBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwg
ZHJoZC0+aW9tbXUpOwogCi0gICAgICAgIC8qCi0gICAgICAgICAqIFRoZSBw
Z3RhYmxlIGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUgbGVhZiBwYWdlLCBh
cyB3ZWxsIGFzCi0gICAgICAgICAqIHBhZ2UgdGFibGUgcGFnZXMsIGFuZCB0
aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMKLSAgICAgICAg
ICogemVyb2VkLgotICAgICAgICAgKi8KLSAgICAgICAgbWFkZHIgPSBhbGxv
Y19wZ3RhYmxlX21hZGRyKDEsIGhkLT5ub2RlKTsKLSAgICAgICAgaWYgKCAh
bWFkZHIgKQorICAgIC8qIFRyYW5zaWVudGx5IGluc3RhbGwgdGhlIHJvb3Qg
aW50byBEb21JTywgZm9yIGlvbW11X2lkZW50aXR5X21hcHBpbmcoKS4gKi8K
KyAgICBoZC0+YXJjaC5wZ2RfbWFkZHIgPSBtYWRkcjsKKworICAgIGZvcl9l
YWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKKyAgICB7CisgICAg
ICAgIGlmICggcmMgKQogICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAg
Zm9yICggb2Zmc2V0ID0gMDsgb2Zmc2V0IDwgUFRFX05VTTsgb2Zmc2V0Kysg
KQorICAgICAgICBpZiAoIHJtcnItPnNlZ21lbnQgPT0gcGRldi0+c2VnICYm
IGJkZiA9PSBwZGV2LT5zYmRmLmJkZiApCiAgICAgICAgIHsKLSAgICAgICAg
ICAgIHN0cnVjdCBkbWFfcHRlICpwdGUgPSAmcGFyZW50W29mZnNldF07Cisg
ICAgICAgICAgICBybXJyX2ZvdW5kID0gdHJ1ZTsKIAotICAgICAgICAgICAg
ZG1hX3NldF9wdGVfYWRkcigqcHRlLCBtYWRkcik7Ci0gICAgICAgICAgICBk
bWFfc2V0X3B0ZV9yZWFkYWJsZSgqcHRlKTsKKyAgICAgICAgICAgIHJjID0g
aW9tbXVfaWRlbnRpdHlfbWFwcGluZyhkb21faW8sIHAybV9hY2Nlc3Nfcncs
CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1y
ci0+YmFzZV9hZGRyZXNzLCBybXJyLT5lbmRfYWRkcmVzcywKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwKTsKKyAgICAgICAg
ICAgIGlmICggcmMgKQorICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0df
RVJSIFZURFBSRUZJWAorICAgICAgICAgICAgICAgICAgICAgICAiJTA0eDol
MDJ4OiUwMnguJXU6IFJNUlIgcXVhcmFudGluZSBtYXBwaW5nIGZhaWxlZFxu
IiwKKyAgICAgICAgICAgICAgICAgICAgICAgcGRldi0+c2VnLCBwZGV2LT5i
dXMsCisgICAgICAgICAgICAgICAgICAgICAgIFBDSV9TTE9UKHBkZXYtPmRl
dmZuKSwgUENJX0ZVTkMocGRldi0+ZGV2Zm4pKTsKICAgICAgICAgfQotICAg
ICAgICBpb21tdV9zeW5jX2NhY2hlKHBhcmVudCwgUEFHRV9TSVpFKTsKKyAg
ICB9CiAKLSAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKHBhcmVudCk7
Ci0gICAgICAgIHBhcmVudCA9IG1hcF92dGRfZG9tYWluX3BhZ2UobWFkZHIp
OwotICAgICAgICBsZXZlbC0tOworICAgIGlvbW11X2lkZW50aXR5X21hcF90
ZWFyZG93bihkb21faW8pOworICAgIGhkLT5hcmNoLnBnZF9tYWRkciA9IDA7
CisgICAgcGRldi0+YXJjaC52dGQucGdkX21hZGRyID0gbWFkZHI7CisKKyAg
ICBpZiAoICFyYyApCisgICAgeworICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAq
cm9vdDsKKyAgICAgICAgcGFkZHJfdCBtYWRkcnNbNl0gPSB7fTsKKworICAg
ICAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CisKKyAg
ICAgICAgcm9vdCA9IG1hcF92dGRfZG9tYWluX3BhZ2UobWFkZHIpOworICAg
ICAgICByYyA9IGZpbGxfcXB0KHJvb3QsIGxldmVsIC0gMSwgbWFkZHJzLCBw
ZGV2KTsKKyAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKHJvb3QpOwor
CisgICAgICAgIHBkZXYtPmFyY2gubGVhZl9tZm4gPSBtYWRkcl90b19tZm4o
bWFkZHJzWzBdKTsKKworICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gu
bWFwcGluZ19sb2NrKTsKICAgICB9Ci0gICAgdW5tYXBfdnRkX2RvbWFpbl9w
YWdlKHBhcmVudCk7CiAKLSBvdXQ6Ci0gICAgc3Bpbl91bmxvY2soJmhkLT5h
cmNoLm1hcHBpbmdfbG9jayk7CisgICAgaWYgKCByYyApCisgICAgICAgIHF1
YXJhbnRpbmVfdGVhcmRvd24ocGRldiwgZHJoZCk7CiAKLSAgICAvKiBQYWdl
cyBsZWFrZWQgaW4gZmFpbHVyZSBjYXNlICovCi0gICAgcmV0dXJuIGxldmVs
ID8gLUVOT01FTSA6IDA7CisgICAgcmV0dXJuIHJjOwogfQogCiBjb25zdCBz
dHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGNvbnN0cmVsIGludGVsX2lvbW11X29w
cyA9IHsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgK
QEAgLTUwOSw3ICs1MDksNyBAQCBzdHJ1Y3QgdnRkX2lvbW11IHsKICAgICB1
MzIgbnJfcHRfbGV2ZWxzOwogICAgIHU2NAljYXA7CiAgICAgdTY0CWVjYXA7
Ci0gICAgc3BpbmxvY2tfdCBsb2NrOyAvKiBwcm90ZWN0IGNvbnRleHQsIGRv
bWFpbiBpZHMgKi8KKyAgICBzcGlubG9ja190IGxvY2s7IC8qIHByb3RlY3Qg
Y29udGV4dCAqLwogICAgIHNwaW5sb2NrX3QgcmVnaXN0ZXJfbG9jazsgLyog
cHJvdGVjdCBpb21tdSByZWdpc3RlciBoYW5kbGluZyAqLwogICAgIHU2NCBy
b290X21hZGRyOyAvKiByb290IGVudHJ5IG1hY2hpbmUgYWRkcmVzcyAqLwog
ICAgIG5vZGVpZF90IG5vZGU7Ci0tLSBhL3hlbi9pbmNsdWRlL3hlbi9pb21t
dS5oCisrKyBiL3hlbi9pbmNsdWRlL3hlbi9pb21tdS5oCkBAIC0yMzYsNyAr
MjM2LDcgQEAgdHlwZWRlZiBpbnQgaW9tbXVfZ3JkbV90KHhlbl9wZm5fdCBz
dGFydAogc3RydWN0IGlvbW11X29wcyB7CiAgICAgaW50ICgqaW5pdCkoc3Ry
dWN0IGRvbWFpbiAqZCk7CiAgICAgdm9pZCAoKmh3ZG9tX2luaXQpKHN0cnVj
dCBkb21haW4gKmQpOwotICAgIGludCAoKnF1YXJhbnRpbmVfaW5pdCkoc3Ry
dWN0IGRvbWFpbiAqZCk7CisgICAgaW50ICgqcXVhcmFudGluZV9pbml0KShk
ZXZpY2VfdCAqZGV2KTsKICAgICBpbnQgKCphZGRfZGV2aWNlKSh1OCBkZXZm
biwgZGV2aWNlX3QgKmRldik7CiAgICAgaW50ICgqZW5hYmxlX2RldmljZSko
ZGV2aWNlX3QgKmRldik7CiAgICAgaW50ICgqcmVtb3ZlX2RldmljZSkodTgg
ZGV2Zm4sIGRldmljZV90ICpkZXYpOwpAQCAtMzU2LDYgKzM1Niw3IEBAIGlu
dCBfX211c3RfY2hlY2sgaW9tbXVfc3VzcGVuZCh2b2lkKTsKIHZvaWQgaW9t
bXVfcmVzdW1lKHZvaWQpOwogdm9pZCBpb21tdV9jcmFzaF9zaHV0ZG93bih2
b2lkKTsKIGludCBpb21tdV9nZXRfcmVzZXJ2ZWRfZGV2aWNlX21lbW9yeShp
b21tdV9ncmRtX3QgKiwgdm9pZCAqKTsKK2ludCBpb21tdV9xdWFyYW50aW5l
X2Rldl9pbml0KGRldmljZV90ICpkZXYpOwogCiB2b2lkIGlvbW11X3NoYXJl
X3AybV90YWJsZShzdHJ1Y3QgZG9tYWluICpkKTsKIAo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-01.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-01.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggKGRlKWFzc2lnbiBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSB1cGRhdGVkLgoKQWxzbyBhZGp1c3QgYSByZWxhdGVk
IGxvZyBtZXNzYWdlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM1OCAvIHBhcnQg
b2YgWFNBLTQwMC4KCkZpeGVzOiA4Yjk5ZjQ0MDBiNjkgKCJWVC1kOiBmaXgg
Uk1SUiByZWxhdGVkIGVycm9yIGhhbmRsaW5nIikKU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog
Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+ClJldmll
d2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KUmV2aWV3ZWQt
Ynk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgoKLS0tIGEv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAgLTIzOTIsNiAr
MjM5MiwxMCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNo
aXAoCiB7CiAgICAgaW50IHJldDsKIAorICAgIHJldCA9IGRvbWFpbl9jb250
ZXh0X3VubWFwKHNvdXJjZSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0
ICkKKyAgICAgICAgcmV0dXJuIHJldDsKKwogICAgIC8qCiAgICAgICogRGV2
aWNlcyBhc3NpZ25lZCB0byB1bnRydXN0ZWQgZG9tYWlucyAoaGVyZSBhc3N1
bWVkIHRvIGJlIGFueSBkb21VKQogICAgICAqIGNhbiBhdHRlbXB0IHRvIHNl
bmQgYXJiaXRyYXJ5IExBUElDL01TSSBtZXNzYWdlcy4gV2UgYXJlIHVucHJv
dGVjdGVkCkBAIC0yNDI4LDEwICsyNDMyLDYgQEAgc3RhdGljIGludCByZWFz
c2lnbl9kZXZpY2Vfb3duZXJzaGlwKAogICAgICAgICAgICAgfQogICAgIH0K
IAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHNvdXJjZSwgZGV2
Zm4sIHBkZXYpOwotICAgIGlmICggcmV0ICkKLSAgICAgICAgcmV0dXJuIHJl
dDsKLQogICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+
ZG9tYWluICE9IGRvbV9pbyApCiAgICAgewogICAgICAgICBsaXN0X21vdmUo
JnBkZXYtPmRvbWFpbl9saXN0LCAmZG9tX2lvLT5wZGV2X2xpc3QpOwpAQCAt
MjUwNyw5ICsyNTA3LDggQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hc3Np
Z25fZGV2aWNlKAogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0ID0gcmVh
c3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7Ci0g
ICAgaWYgKCByZXQgfHwgZCA9PSBkb21faW8gKQotICAgICAgICByZXR1cm4g
cmV0OworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm4g
cmVhc3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7
CiAKICAgICAvKiBTZXR1cCBybXJyIGlkZW50aXR5IG1hcHBpbmcgKi8KICAg
ICBmb3JfZWFjaF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBpICkKQEAgLTI1
MjIsMjAgKzI1MjEsMzcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hc3Np
Z25fZGV2aWNlKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgZmxhZyk7CiAgICAgICAgICAg
ICBpZiAoIHJldCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAg
aW50IHJjOwotCi0gICAgICAgICAgICAgICAgcmMgPSByZWFzc2lnbl9kZXZp
Y2Vfb3duZXJzaGlwKGQsIHMsIGRldmZuLCBwZGV2KTsKICAgICAgICAgICAg
ICAgICBwcmludGsoWEVOTE9HX0dfRVJSIFZURFBSRUZJWAotICAgICAgICAg
ICAgICAgICAgICAgICAiIGNhbm5vdCBtYXAgcmVzZXJ2ZWQgcmVnaW9uICgl
IlBSSXg2NCIsJSJQUkl4NjQiXSBmb3IgRG9tJWQgKCVkKVxuIiwKLSAgICAg
ICAgICAgICAgICAgICAgICAgcm1yci0+YmFzZV9hZGRyZXNzLCBybXJyLT5l
bmRfYWRkcmVzcywKLSAgICAgICAgICAgICAgICAgICAgICAgZC0+ZG9tYWlu
X2lkLCByZXQpOwotICAgICAgICAgICAgICAgIGlmICggcmMgKQotICAgICAg
ICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlIgVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAi
IGZhaWxlZCB0byByZWNsYWltICVwcCBmcm9tICVwZCAoJWQpXG4iLAotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGMyhzZWcsIGJ1cywg
ZGV2Zm4pLCBkLCByYyk7Ci0gICAgICAgICAgICAgICAgICAgIGRvbWFpbl9j
cmFzaChkKTsKLSAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAg
ICAgICAgICIlcGQ6IGNhbm5vdCBtYXAgcmVzZXJ2ZWQgcmVnaW9uIFslIlBS
SXg2NCIsJSJQUkl4NjQiXTogJWRcbiIsCisgICAgICAgICAgICAgICAgICAg
ICAgIGQsIHJtcnItPmJhc2VfYWRkcmVzcywgcm1yci0+ZW5kX2FkZHJlc3Ms
IHJldCk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9
CisgICAgICAgIH0KKyAgICB9CisKKyAgICBpZiAoICFyZXQgKQorICAgICAg
ICByZXQgPSByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlwKHMsIGQsIGRldmZu
LCBwZGV2KTsKKworICAgIC8qIFNlZSByZWFzc2lnbl9kZXZpY2Vfb3duZXJz
aGlwKCkgZm9yIHRoZSBod2RvbSBhc3BlY3QuICovCisgICAgaWYgKCAhcmV0
IHx8IGlzX2hhcmR3YXJlX2RvbWFpbihkKSApCisgICAgICAgIHJldHVybiBy
ZXQ7CisKKyAgICBmb3JfZWFjaF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBp
ICkKKyAgICB7CisgICAgICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBzZWcg
JiYKKyAgICAgICAgICAgICBQQ0lfQlVTKGJkZikgPT0gYnVzICYmCisgICAg
ICAgICAgICAgUENJX0RFVkZOMihiZGYpID09IGRldmZuICkKKyAgICAgICAg
eworICAgICAgICAgICAgaW50IHJjID0gaW9tbXVfaWRlbnRpdHlfbWFwcGlu
ZyhkLCBwMm1fYWNjZXNzX3gsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHJtcnItPmJhc2VfYWRkcmVzcywKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+
ZW5kX2FkZHJlc3MsIDApOworCisgICAgICAgICAgICBpZiAoIHJjICYmIHJj
ICE9IC1FTk9FTlQgKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg
IHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWAorICAgICAgICAgICAgICAg
ICAgICAgICAiJXBkOiBjYW5ub3QgdW5tYXAgcmVzZXJ2ZWQgcmVnaW9uIFsl
IlBSSXg2NCIsJSJQUkl4NjQiXTogJWRcbiIsCisgICAgICAgICAgICAgICAg
ICAgICAgIGQsIHJtcnItPmJhc2VfYWRkcmVzcywgcm1yci0+ZW5kX2FkZHJl
c3MsIHJjKTsKKyAgICAgICAgICAgICAgICBkb21haW5fY3Jhc2goZCk7CiAg
ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAg
IH0K

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-02.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-02.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggYWRkL3JlbW92ZSBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSBjbGVhcmVkLgoKQWxzbyBzd2l0Y2ggdG8gJXBkIGlu
IHJlbGF0ZWQgbG9nIG1lc3NhZ2VzLgoKRml4ZXM6IGZhODhjZmFkZjkxOCAo
InZ0LWQ6IE1hcCBSTVJSIGluIGludGVsX2lvbW11X2FkZF9kZXZpY2UoKSBp
ZiB0aGUgZGV2aWNlIGhhcyBSTVJSIikKRml4ZXM6IDhiOTlmNDQwMGI2OSAo
IlZULWQ6IGZpeCBSTVJSIHJlbGF0ZWQgZXJyb3IgaGFuZGxpbmciKQpTaWdu
ZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJl
dmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4
LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50
ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmMKQEAgLTE5ODEsMTQgKzE5ODEsNiBAQCBzdGF0aWMgaW50IGludGVsX2lv
bW11X2FkZF9kZXZpY2UodTggZGV2CiAgICAgaWYgKCAhcGRldi0+ZG9tYWlu
ICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CiAKLSAgICByZXQgPSBkb21h
aW5fY29udGV4dF9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYp
OwotICAgIGlmICggcmV0ICkKLSAgICB7Ci0gICAgICAgIGRwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgsICJkJWQ6IGNvbnRleHQgbWFwcGluZyBmYWls
ZWRcbiIsCi0gICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluLT5kb21haW5f
aWQpOwotICAgICAgICByZXR1cm4gcmV0OwotICAgIH0KLQogICAgIGZvcl9l
YWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKICAgICB7CiAgICAg
ICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBwZGV2LT5zZWcgJiYKQEAgLTIw
MDUsMTIgKzE5OTcsMTcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hZGRf
ZGV2aWNlKHU4IGRldgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRy
ZXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAwKTsKICAgICAgICAgICAgIGlmICggcmV0ICkKLSAgICAgICAgICAgICAg
ICBkcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiZCVkOiBSTVJSIG1h
cHBpbmcgZmFpbGVkXG4iLAotICAgICAgICAgICAgICAgICAgICAgICAgcGRl
di0+ZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAgICAgIGRwcmlu
dGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IFJNUlIgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LT5kb21h
aW4pOwogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuIDA7CisgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZyhwZGV2LT5kb21haW4sIGRl
dmZuLCBwZGV2KTsKKyAgICBpZiAoIHJldCApCisgICAgICAgIGRwcmludGso
WEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IGNvbnRleHQgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluKTsKKwor
ICAgIHJldHVybiByZXQ7CiB9CiAKIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVf
ZW5hYmxlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRldikKQEAgLTIwMzIs
MTEgKzIwMjksMTUgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVf
ZGV2aWNlKHU4CiB7CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJy
OwogICAgIHUxNiBiZGY7Ci0gICAgaW50IGk7CisgICAgaW50IHJldCwgaTsK
IAogICAgIGlmICggIXBkZXYtPmRvbWFpbiApCiAgICAgICAgIHJldHVybiAt
RUlOVkFMOwogCisgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAocGRl
di0+ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgaWYgKCByZXQgKQorICAg
ICAgICByZXR1cm4gcmV0OworCiAgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2Ug
KCBybXJyLCBiZGYsIGkgKQogICAgIHsKICAgICAgICAgaWYgKCBybXJyLT5z
ZWdtZW50ICE9IHBkZXYtPnNlZyB8fApAQCAtMjA1Miw3ICsyMDUzLDcgQEAg
c3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4CiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3Ms
IDApOwogICAgIH0KIAotICAgIHJldHVybiBkb21haW5fY29udGV4dF91bm1h
cChwZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKKyAgICByZXR1cm4gMDsK
IH0KIAogc3RhdGljIGludCBfX2h3ZG9tX2luaXQgc2V0dXBfaHdkb21fZGV2
aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-03.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHRpZ2h0ZW4gaW9tbXVfYWxsb2NfcGd0YWJsZSgpJ3Mg
cGFyYW1ldGVyCgpUaGlzIGlzIHRvIG1ha2UgbW9yZSBvYnZpb3VzIHRoYXQg
bm90aGluZyBvdXRzaWRlIG9mIGRvbWFpbl9pb21tdShkKQphY3R1YWxseSBj
aGFuZ2VzIG9yIGlzIG90aGVyd2lzZSBuZWVkZWQgYnkgdGhlIGZ1bmN0aW9u
LgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UgaW50ZW5kZWQuCgpTaWduZWQtb2Zm
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
UmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZp
ZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+Cgot
LS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKKysrIGIveGVuL2lu
Y2x1ZGUvYXNtLXg4Ni9pb21tdS5oCkBAIC0xNDMsNyArMTQzLDggQEAgaW50
IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9kZXNjCiB9KQogCiBp
bnQgX19tdXN0X2NoZWNrIGlvbW11X2ZyZWVfcGd0YWJsZXMoc3RydWN0IGRv
bWFpbiAqZCk7Ci1zdHJ1Y3QgcGFnZV9pbmZvICpfX211c3RfY2hlY2sgaW9t
bXVfYWxsb2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluICpkKTsKK3N0cnVjdCBk
b21haW5faW9tbXU7CitzdHJ1Y3QgcGFnZV9pbmZvICpfX211c3RfY2hlY2sg
aW9tbXVfYWxsb2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCk7
CiAKICNlbmRpZiAvKiAhX19BUkNIX1g4Nl9JT01NVV9IX18gKi8KIC8qCi0t
LSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYwor
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMK
QEAgLTE4NCw3ICsxODQsNyBAQCBzdGF0aWMgaW50IGlvbW11X3BkZV9mcm9t
X2RmbihzdHJ1Y3QgZG9tCiAgICAgdW5zaWduZWQgbG9uZyAgbmV4dF90YWJs
ZV9tZm47CiAgICAgdW5zaWduZWQgaW50IGxldmVsOwogICAgIHN0cnVjdCBw
YWdlX2luZm8gKnRhYmxlOwotICAgIGNvbnN0IHN0cnVjdCBkb21haW5faW9t
bXUgKmhkID0gZG9tX2lvbW11KGQpOworICAgIHN0cnVjdCBkb21haW5faW9t
bXUgKmhkID0gZG9tX2lvbW11KGQpOwogCiAgICAgdGFibGUgPSBoZC0+YXJj
aC5hbWQucm9vdF90YWJsZTsKICAgICBsZXZlbCA9IGhkLT5hcmNoLmFtZC5w
YWdpbmdfbW9kZTsKQEAgLTIyMCw3ICsyMjAsNyBAQCBzdGF0aWMgaW50IGlv
bW11X3BkZV9mcm9tX2RmbihzdHJ1Y3QgZG9tCiAgICAgICAgICAgICBtZm4g
PSBuZXh0X3RhYmxlX21mbjsKIAogICAgICAgICAgICAgLyogYWxsb2NhdGUg
bG93ZXIgbGV2ZWwgcGFnZSB0YWJsZSAqLwotICAgICAgICAgICAgdGFibGUg
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICAgICAgdGFibGUg
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKICAgICAgICAgICAgIGlmICgg
dGFibGUgPT0gTlVMTCApCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAg
ICAgQU1EX0lPTU1VX0RFQlVHKCJDYW5ub3QgYWxsb2NhdGUgSS9PIHBhZ2Ug
dGFibGVcbiIpOwpAQCAtMjUwLDcgKzI1MCw3IEBAIHN0YXRpYyBpbnQgaW9t
bXVfcGRlX2Zyb21fZGZuKHN0cnVjdCBkb20KIAogICAgICAgICAgICAgaWYg
KCBuZXh0X3RhYmxlX21mbiA9PSAwICkKICAgICAgICAgICAgIHsKLSAgICAg
ICAgICAgICAgICB0YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUoZCk7Cisg
ICAgICAgICAgICAgICAgdGFibGUgPSBpb21tdV9hbGxvY19wZ3RhYmxlKGhk
KTsKICAgICAgICAgICAgICAgICBpZiAoIHRhYmxlID09IE5VTEwgKQogICAg
ICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAgICAgQU1EX0lPTU1V
X0RFQlVHKCJDYW5ub3QgYWxsb2NhdGUgSS9PIHBhZ2UgdGFibGVcbiIpOwpA
QCAtNDgzLDcgKzQ4Myw3IEBAIGludCBfX2luaXQgYW1kX2lvbW11X3F1YXJh
bnRpbmVfaW5pdChzdHIKIAogICAgIHNwaW5fbG9jaygmaGQtPmFyY2gubWFw
cGluZ19sb2NrKTsKIAotICAgIGhkLT5hcmNoLmFtZC5yb290X3RhYmxlID0g
aW9tbXVfYWxsb2NfcGd0YWJsZShkKTsKKyAgICBoZC0+YXJjaC5hbWQucm9v
dF90YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOwogICAgIGlmICgg
IWhkLT5hcmNoLmFtZC5yb290X3RhYmxlICkKICAgICAgICAgZ290byBvdXQ7
CiAKQEAgLTQ5OCw3ICs0OTgsNyBAQCBpbnQgX19pbml0IGFtZF9pb21tdV9x
dWFyYW50aW5lX2luaXQoc3RyCiAgICAgICAgICAqIHBhZ2UgdGFibGUgcGFn
ZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMK
ICAgICAgICAgICogemVyb2VkLgogICAgICAgICAgKi8KLSAgICAgICAgcGcg
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICBwZyA9IGlvbW11
X2FsbG9jX3BndGFibGUoaGQpOwogICAgICAgICBpZiAoICFwZyApCiAgICAg
ICAgICAgICBicmVhazsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC9hbWQvcGNpX2FtZF9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11LmMKQEAgLTIwOCw3ICsyMDgsNyBA
QCBpbnQgYW1kX2lvbW11X2FsbG9jX3Jvb3Qoc3RydWN0IGRvbWFpbiAqCiAK
ICAgICBpZiAoIHVubGlrZWx5KCFoZC0+YXJjaC5hbWQucm9vdF90YWJsZSkg
KQogICAgIHsKLSAgICAgICAgaGQtPmFyY2guYW1kLnJvb3RfdGFibGUgPSBp
b21tdV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICBoZC0+YXJjaC5hbWQu
cm9vdF90YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOwogICAgICAg
ICBpZiAoICFoZC0+YXJjaC5hbWQucm9vdF90YWJsZSApCiAgICAgICAgICAg
ICByZXR1cm4gLUVOT01FTTsKICAgICB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCkBAIC0zMjcsNyArMzI3LDcgQEAgc3RhdGlj
IHU2NCBhZGRyX3RvX2RtYV9wYWdlX21hZGRyKHN0cnVjdAogICAgIHsKICAg
ICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7CiAKLSAgICAgICAgaWYgKCAh
YWxsb2MgfHwgIShwZyA9IGlvbW11X2FsbG9jX3BndGFibGUoZG9tYWluKSkg
KQorICAgICAgICBpZiAoICFhbGxvYyB8fCAhKHBnID0gaW9tbXVfYWxsb2Nf
cGd0YWJsZShoZCkpICkKICAgICAgICAgICAgIGdvdG8gb3V0OwogCiAgICAg
ICAgIGhkLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIgPSBwYWdlX3RvX21hZGRyKHBn
KTsKQEAgLTM0Nyw3ICszNDcsNyBAQCBzdGF0aWMgdTY0IGFkZHJfdG9fZG1h
X3BhZ2VfbWFkZHIoc3RydWN0CiAgICAgICAgICAgICBpZiAoICFhbGxvYyAp
CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgICAgIHBnID0g
aW9tbXVfYWxsb2NfcGd0YWJsZShkb21haW4pOworICAgICAgICAgICAgcGcg
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKICAgICAgICAgICAgIGlmICgg
IXBnICkKICAgICAgICAgICAgICAgICBicmVhazsKIApAQCAtMjc2MSw3ICsy
NzYxLDcgQEAgc3RhdGljIGludCBfX2luaXQgaW50ZWxfaW9tbXVfcXVhcmFu
dGluZQogICAgICAgICBnb3RvIG91dDsKICAgICB9CiAKLSAgICBwZyA9IGlv
bW11X2FsbG9jX3BndGFibGUoZCk7CisgICAgcGcgPSBpb21tdV9hbGxvY19w
Z3RhYmxlKGhkKTsKIAogICAgIHJjID0gLUVOT01FTTsKICAgICBpZiAoICFw
ZyApCkBAIC0yNzgwLDcgKzI3ODAsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBp
bnRlbF9pb21tdV9xdWFyYW50aW5lCiAgICAgICAgICAqIHBhZ2UgdGFibGUg
cGFnZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdh
eXMKICAgICAgICAgICogemVyb2VkLgogICAgICAgICAgKi8KLSAgICAgICAg
cGcgPSBpb21tdV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICBwZyA9IGlv
bW11X2FsbG9jX3BndGFibGUoaGQpOwogCiAgICAgICAgIGlmICggIXBnICkK
ICAgICAgICAgICAgIGdvdG8gb3V0OwotLS0gYS94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC94ODYvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC94ODYvaW9tbXUuYwpAQCAtNDE1LDkgKzQxNSw4IEBAIGludCBpb21t
dV9mcmVlX3BndGFibGVzKHN0cnVjdCBkb21haW4gKmQKICAgICByZXR1cm4g
MDsKIH0KIAotc3RydWN0IHBhZ2VfaW5mbyAqaW9tbXVfYWxsb2NfcGd0YWJs
ZShzdHJ1Y3QgZG9tYWluICpkKQorc3RydWN0IHBhZ2VfaW5mbyAqaW9tbXVf
YWxsb2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCkKIHsKLSAg
ICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKICAg
ICB1bnNpZ25lZCBpbnQgbWVtZmxhZ3MgPSAwOwogICAgIHN0cnVjdCBwYWdl
X2luZm8gKnBnOwogICAgIHZvaWQgKnA7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-04.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBkcm9wIG93bmVyc2hpcCBjaGVja2luZyBmcm9tIGRvbWFpbl9j
b250ZXh0X21hcHBpbmdfb25lKCkKCkRlc3BpdGUgcHV0dGluZyBpbiBxdWl0
ZSBhIGJpdCBvZiBlZmZvcnQgaXQgd2FzIG5vdCBwb3NzaWJsZSB0bwplc3Rh
Ymxpc2ggd2h5IGV4YWN0bHkgdGhpcyBjb2RlIGV4aXN0cyAoYmV5b25kIHBv
c3NpYmx5IHNhbml0eQpjaGVja2luZykuIEluc3RlYWQgb2YgYSBzdWJzZXF1
ZW50IGNoYW5nZSBmdXJ0aGVyIGNvbXBsaWNhdGluZyB0aGlzCmxvZ2ljLCBz
aW1wbHkgZ2V0IHJpZCBvZiBpdC4KClRha2UgdGhlIG9wcG9ydHVuaXR5IGFu
ZCBtb3ZlIHRoZSByZXNwZWN0aXZlIHVubWFwX3Z0ZF9kb21haW5fcGFnZSgp
IG91dApvZiB0aGUgbG9ja2VkIHJlZ2lvbi4KClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdl
ZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5
OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KCi0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCkBAIC0xMjEsMjggKzEy
MSw2IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVj
dAogICAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGNvbnRleHRfZ2V0
X2RvbWFpbl9pZChzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4dCwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQotewotICAgIHVuc2lnbmVkIGxvbmcgZG9tX2luZGV4LCBu
cl9kb207Ci0gICAgaW50IGRvbWlkID0gLTE7Ci0KLSAgICBpZiAoaW9tbXUg
JiYgY29udGV4dCkKLSAgICB7Ci0gICAgICAgIG5yX2RvbSA9IGNhcF9uZG9t
cyhpb21tdS0+Y2FwKTsKLQotICAgICAgICBkb21faW5kZXggPSBjb250ZXh0
X2RvbWFpbl9pZCgqY29udGV4dCk7Ci0KLSAgICAgICAgaWYgKCBkb21faW5k
ZXggPCBucl9kb20gJiYgaW9tbXUtPmRvbWlkX21hcCApCi0gICAgICAgICAg
ICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbZG9tX2luZGV4XTsKLSAgICAg
ICAgZWxzZQotICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfREVCVUcgVlRE
UFJFRklYLAotICAgICAgICAgICAgICAgICAgICAiZG9tX2luZGV4ICVsdSBl
eGNlZWRzIG5yX2RvbSAlbHUgb3IgaW9tbXUgaGFzIG5vIGRvbWlkX21hcFxu
IiwKLSAgICAgICAgICAgICAgICAgICAgZG9tX2luZGV4LCBucl9kb20pOwot
ICAgIH0KLSAgICByZXR1cm4gZG9taWQ7Ci19Ci0KIHN0YXRpYyB2b2lkIGNs
ZWFudXBfZG9taWRfbWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXUpCiB7CiAgICAgaW50IGlvbW11X2RvbWlkID0g
ZG9tYWluX2lvbW11X2RvbWlkKGRvbWFpbiwgaW9tbXUpOwpAQCAtMTQwNCw0
NCArMTM4Miw5IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgK
IAogICAgIGlmICggY29udGV4dF9wcmVzZW50KCpjb250ZXh0KSApCiAgICAg
ewotICAgICAgICBpbnQgcmVzID0gMDsKLQotICAgICAgICAvKiBUcnkgdG8g
Z2V0IGRvbWFpbiBvd25lcnNoaXAgZnJvbSBkZXZpY2Ugc3RydWN0dXJlLiAg
SWYgdGhhdCdzCi0gICAgICAgICAqIG5vdCBhdmFpbGFibGUsIHRyeSB0byBy
ZWFkIGl0IGZyb20gdGhlIGNvbnRleHQgaXRzZWxmLiAqLwotICAgICAgICBp
ZiAoIHBkZXYgKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIHBkZXYt
PmRvbWFpbiAhPSBkb21haW4gKQotICAgICAgICAgICAgewotICAgICAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfR19JTkZPIFZURFBSRUZJWCAiJXBkOiAl
cHAgb3duZWQgYnkgJXBkIiwKLSAgICAgICAgICAgICAgICAgICAgICAgZG9t
YWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbiksCi0gICAgICAgICAg
ICAgICAgICAgICAgIHBkZXYtPmRvbWFpbik7Ci0gICAgICAgICAgICAgICAg
cmVzID0gLUVJTlZBTDsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfQotICAg
ICAgICBlbHNlCi0gICAgICAgIHsKLSAgICAgICAgICAgIGludCBjZG9tYWlu
OwotICAgICAgICAgICAgY2RvbWFpbiA9IGNvbnRleHRfZ2V0X2RvbWFpbl9p
ZChjb250ZXh0LCBpb21tdSk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAg
IGlmICggY2RvbWFpbiA8IDAgKQotICAgICAgICAgICAgewotICAgICAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HIFZURFBSRUZJWAotICAg
ICAgICAgICAgICAgICAgICAgICAiJXBkOiAlcHAgbWFwcGVkLCBidXQgY2Fu
J3QgZmluZCBvd25lclxuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgZG9t
YWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbikpOwotICAgICAgICAg
ICAgICAgIHJlcyA9IC1FSU5WQUw7Ci0gICAgICAgICAgICB9Ci0gICAgICAg
ICAgICBlbHNlIGlmICggY2RvbWFpbiAhPSBkb21haW4tPmRvbWFpbl9pZCAp
Ci0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19HX0lORk8gVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICIl
cGQ6ICVwcCBhbHJlYWR5IG1hcHBlZCB0byBkJWQiLAotICAgICAgICAgICAg
ICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZu
KSwgY2RvbWFpbik7Ci0gICAgICAgICAgICAgICAgcmVzID0gLUVJTlZBTDsK
LSAgICAgICAgICAgIH0KLSAgICAgICAgfQotCi0gICAgICAgIHVubWFwX3Z0
ZF9kb21haW5fcGFnZShjb250ZXh0X2VudHJpZXMpOwogICAgICAgICBzcGlu
X3VubG9jaygmaW9tbXUtPmxvY2spOwotICAgICAgICByZXR1cm4gcmVzOwor
ICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVz
KTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCiAgICAgaWYgKCBpb21t
dV9od2RvbV9wYXNzdGhyb3VnaCAmJiBpc19oYXJkd2FyZV9kb21haW4oZG9t
YWluKSApCg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-05.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiByZS1hc3NpZ24gZGV2aWNlcyBkaXJlY3RseQoKRGV2aWNlcyB3
aXRoIFJNUlJzLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQgaG93L3do
ZW4gdGhlIHNwZWNpZmllZAptZW1vcnkgcmVnaW9ucyBtYXkgZ2V0IGFjY2Vz
c2VkLCBtYXkgbm90IGJlIGxlZnQgZGlzY29ubmVjdGVkIGZyb20gdGhlaXIK
cmVzcGVjdGl2ZSBtYXBwaW5ncyAoYXMgbG9uZyBhcyBpdCdzIG5vdCBjZXJ0
YWluIHRoYXQgdGhlIGRldmljZSBoYXMKYmVlbiBmdWxseSBxdWllc2NlZCku
IEhlbmNlIHJhdGhlciB0aGFuIHVubWFwcGluZyB0aGUgb2xkIGNvbnRleHQg
YW5kCnRoZW4gbWFwcGluZyB0aGUgbmV3IG9uZSwgcmUtYXNzaWdubWVudCBu
ZWVkcyB0byBiZSBkb25lIGluIGEgc2luZ2xlCnN0ZXAuCgpUaGlzIGlzIENW
RS0yMDIyLTI2MzU5IC8gcGFydCBvZiBYU0EtNDAwLgoKUmVwb3J0ZWQtYnk6
IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKU2lt
aWxhcmx5IHF1YXJhbnRpbmluZyBzY3JhdGNoLXBhZ2UgbW9kZSByZWxpZXMg
b24gcGFnZSB0YWJsZXMgdG8gYmUKY29udGludW91c2x5IHdpcmVkIHVwLgoK
VG8gYXZvaWQgY29tcGxpY2F0aW5nIHRoaW5ncyBtb3JlIHRoYW4gbmVjZXNz
YXJ5LCB0cmVhdCBhbGwgZGV2aWNlcwptb3N0bHkgZXF1YWxseSwgaS5lLiBy
ZWdhcmRsZXNzIG9mIHRoZWlyIGFzc29jaWF0aW9uIHdpdGggYW55IFJNUlJz
LiBUaGUKbWFpbiBkaWZmZXJlbmNlIGlzIHdoZW4gaXQgY29tZXMgdG8gdXBk
YXRpbmcgY29udGV4dCBlbnRyaWVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21p
YyB3aGVuIHRoZXJlIGFyZSBSTVJScy4gWWV0IGF0b21pY2l0eSBjYW4gb25s
eSBiZSBhY2hpZXZlZAp3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBv
ZiB3aGljaCB3ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClRoZSBzZWVtaW5n
bHkgY29tcGxpY2F0ZWQgY2hvaWNlIG9mIG5vbi1uZWdhdGl2ZSByZXR1cm4g
dmFsdWVzIGZvcgpkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgpIGlzIHRv
IGxpbWl0IGNvZGUgY2h1cm46IFRoaXMgd2F5IGNhbGxlcnMKcGFzc2luZyBO
VUxMIGZvciBwZGV2IGRvbid0IG5lZWQgZmlkZGxpbmcgd2l0aC4KClNpZ25l
ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2
aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgpS
ZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp
eC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZXh0
ZXJuLmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2V4dGVy
bi5oCkBAIC04NCw3ICs4NCw4IEBAIHZvaWQgZnJlZV9wZ3RhYmxlX21hZGRy
KHU2NCBtYWRkcik7CiB2b2lkICptYXBfdnRkX2RvbWFpbl9wYWdlKHU2NCBt
YWRkcik7CiB2b2lkIHVubWFwX3Z0ZF9kb21haW5fcGFnZShjb25zdCB2b2lk
ICp2YSk7CiBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoc3RydWN0
IGRvbWFpbiAqZG9tYWluLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1OCBidXMsIHU4IGRldmZu
LCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqKTsKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB1aW50OF90IGJ1cywgdWludDhfdCBkZXZmbiwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNp
X2RldiAqcGRldiwgdW5zaWduZWQgaW50IG1vZGUpOwogaW50IGRvbWFpbl9j
b250ZXh0X3VubWFwX29uZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVj
dCB2dGRfaW9tbXUgKmlvbW11LAogICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB1OCBidXMsIHU4IGRldmZuKTsKIGludCBpbnRlbF9pb21tdV9nZXRf
cmVzZXJ2ZWRfZGV2aWNlX21lbW9yeShpb21tdV9ncmRtX3QgKmZ1bmMsIHZv
aWQgKmN0eHQpOwpAQCAtMTAzLDggKzEwNCw4IEBAIGludCBpc19pZ2RfdnRf
ZW5hYmxlZF9xdWlyayh2b2lkKTsKIHZvaWQgcGxhdGZvcm1fcXVpcmtzX2lu
aXQodm9pZCk7CiB2b2lkIHZ0ZF9vcHNfcHJlYW1ibGVfcXVpcmsoc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXUpOwogdm9pZCB2dGRfb3BzX3Bvc3RhbWJsZV9x
dWlyayhzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSk7Ci1pbnQgX19tdXN0X2No
ZWNrIG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLAotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHU4IGJ1cywgdTggZGV2Zm4s
IGludCBtYXApOworaW50IF9fbXVzdF9jaGVjayBtZV93aWZpX3F1aXJrKHN0
cnVjdCBkb21haW4gKmRvbWFpbiwgdWludDhfdCBidXMsCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBkZXZmbiwgdW5zaWduZWQg
aW50IG1vZGUpOwogdm9pZCBwY2lfdnRkX3F1aXJrKGNvbnN0IHN0cnVjdCBw
Y2lfZGV2ICopOwogdm9pZCBxdWlya19pb21tdV9jYXBzKHN0cnVjdCB2dGRf
aW9tbXUgKmlvbW11KTsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC92dGQvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92
dGQvaW9tbXUuYwpAQCAtMTE3LDYgKzExNyw3IEBAIHN0YXRpYyBpbnQgY29u
dGV4dF9zZXRfZG9tYWluX2lkKHN0cnVjdAogICAgIH0KIAogICAgIHNldF9i
aXQoaSwgaW9tbXUtPmRvbWlkX2JpdG1hcCk7CisgICAgY29udGV4dC0+aGkg
Jj0gfigoKDEgPDwgRElEX0ZJRUxEX1dJRFRIKSAtIDEpIDw8IERJRF9ISUdI
X09GRlNFVCk7CiAgICAgY29udGV4dC0+aGkgfD0gKGkgJiAoKDEgPDwgRElE
X0ZJRUxEX1dJRFRIKSAtIDEpKSA8PCBESURfSElHSF9PRkZTRVQ7CiAgICAg
cmV0dXJuIDA7CiB9CkBAIC0xMzYyLDE1ICsxMzYzLDI3IEBAIHN0YXRpYyB2
b2lkIF9faHdkb21faW5pdCBpbnRlbF9pb21tdV9od2QKICAgICB9CiB9CiAK
Ky8qCisgKiBUaGlzIGZ1bmN0aW9uIHJldHVybnMKKyAqIC0gYSBuZWdhdGl2
ZSBlcnJubyB2YWx1ZSB1cG9uIGVycm9yLAorICogLSB6ZXJvIHVwb24gc3Vj
Y2VzcyB3aGVuIHByZXZpb3VzbHkgdGhlIGVudHJ5IHdhcyBub24tcHJlc2Vu
dCwgb3IgdGhpcyBpc24ndAorICogICB0aGUgIm1haW4iIHJlcXVlc3QgZm9y
IGEgZGV2aWNlIChwZGV2ID09IE5VTEwpLCBvciBmb3Igbm8tb3AgcXVhcmFu
dGluaW5nCisgKiAgIGFzc2lnbm1lbnRzLAorICogLSBwb3NpdGl2ZSAob25l
KSB1cG9uIHN1Y2Nlc3Mgd2hlbiBwcmV2aW91c2x5IHRoZSBlbnRyeSB3YXMg
cHJlc2VudCBhbmQgdGhpcworICogICBpcyB0aGUgIm1haW4iIHJlcXVlc3Qg
Zm9yIGEgZGV2aWNlIChwZGV2ICE9IE5VTEwpLgorICovCiBpbnQgZG9tYWlu
X2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgc3RydWN0IGRvbWFpbiAqZG9t
YWluLAogICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAotICAgIHU4IGJ1
cywgdTggZGV2Zm4sIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQorICAg
IHVpbnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLCBjb25zdCBzdHJ1Y3QgcGNp
X2RldiAqcGRldiwKKyAgICB1bnNpZ25lZCBpbnQgbW9kZSkKIHsKICAgICBz
dHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21haW4pOwot
ICAgIHN0cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LCAqY29udGV4dF9l
bnRyaWVzOworICAgIHN0cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LCAq
Y29udGV4dF9lbnRyaWVzLCBsY3R4dDsKKyAgICBfX3VpbnQxMjhfdCBvbGQ7
CiAgICAgdTY0IG1hZGRyLCBwZ2RfbWFkZHI7Ci0gICAgdTE2IHNlZyA9IGlv
bW11LT5kcmhkLT5zZWdtZW50OworICAgIHVpbnQxNl90IHNlZyA9IGlvbW11
LT5kcmhkLT5zZWdtZW50LCBwcmV2X2RpZCA9IDA7CisgICAgc3RydWN0IGRv
bWFpbiAqcHJldl9kb20gPSBOVUxMOwogICAgIGludCByYywgcmV0OwogICAg
IGJvb2xfdCBmbHVzaF9kZXZfaW90bGI7CiAKQEAgLTEzNzksMTcgKzEzOTIs
MzIgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIG1h
ZGRyID0gYnVzX3RvX2NvbnRleHRfbWFkZHIoaW9tbXUsIGJ1cyk7CiAgICAg
Y29udGV4dF9lbnRyaWVzID0gKHN0cnVjdCBjb250ZXh0X2VudHJ5ICopbWFw
X3Z0ZF9kb21haW5fcGFnZShtYWRkcik7CiAgICAgY29udGV4dCA9ICZjb250
ZXh0X2VudHJpZXNbZGV2Zm5dOworICAgIG9sZCA9IChsY3R4dCA9ICpjb250
ZXh0KS5mdWxsOwogCi0gICAgaWYgKCBjb250ZXh0X3ByZXNlbnQoKmNvbnRl
eHQpICkKKyAgICBpZiAoIGNvbnRleHRfcHJlc2VudChsY3R4dCkgKQogICAg
IHsKLSAgICAgICAgc3Bpbl91bmxvY2soJmlvbW11LT5sb2NrKTsKLSAgICAg
ICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7Ci0g
ICAgICAgIHJldHVybiAwOworICAgICAgICBkb21pZF90IGRvbWlkOworCisg
ICAgICAgIHByZXZfZGlkID0gY29udGV4dF9kb21haW5faWQobGN0eHQpOwor
ICAgICAgICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbcHJldl9kaWRdOwor
ICAgICAgICBpZiAoIGRvbWlkIDwgRE9NSURfRklSU1RfUkVTRVJWRUQgKQor
ICAgICAgICAgICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW5fYnlfaWQo
ZG9taWQpOworICAgICAgICBlbHNlIGlmICggZG9taWQgPT0gRE9NSURfSU8g
KQorICAgICAgICAgICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW4oZG9t
X2lvKTsKKyAgICAgICAgaWYgKCAhcHJldl9kb20gKQorICAgICAgICB7Cisg
ICAgICAgICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOworICAgICAg
ICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7
CisgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19ERUJVRyBWVERQUkVGSVgs
CisgICAgICAgICAgICAgICAgICAgICJubyBkb21haW4gZm9yIGRpZCAldSAo
bnJfZG9tICV1KVxuIiwKKyAgICAgICAgICAgICAgICAgICAgcHJldl9kaWQs
IGNhcF9uZG9tcyhpb21tdS0+Y2FwKSk7CisgICAgICAgICAgICByZXR1cm4g
LUVTUkNIOworICAgICAgICB9CiAgICAgfQogCiAgICAgaWYgKCBpb21tdV9o
d2RvbV9wYXNzdGhyb3VnaCAmJiBpc19oYXJkd2FyZV9kb21haW4oZG9tYWlu
KSApCiAgICAgewotICAgICAgICBjb250ZXh0X3NldF90cmFuc2xhdGlvbl90
eXBlKCpjb250ZXh0LCBDT05URVhUX1RUX1BBU1NfVEhSVSk7CisgICAgICAg
IGNvbnRleHRfc2V0X3RyYW5zbGF0aW9uX3R5cGUobGN0eHQsIENPTlRFWFRf
VFRfUEFTU19USFJVKTsKICAgICB9CiAgICAgZWxzZQogICAgIHsKQEAgLTE0
MDEsMzYgKzE0MjksMTA3IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5n
X29uZSgKICAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBw
aW5nX2xvY2spOwogICAgICAgICAgICAgc3Bpbl91bmxvY2soJmlvbW11LT5s
b2NrKTsKICAgICAgICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShjb250
ZXh0X2VudHJpZXMpOworICAgICAgICAgICAgaWYgKCBwcmV2X2RvbSApCisg
ICAgICAgICAgICAgICAgcmN1X3VubG9ja19kb21haW4ocHJldl9kb20pOwog
ICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07CiAgICAgICAgIH0KIAotICAg
ICAgICBjb250ZXh0X3NldF9hZGRyZXNzX3Jvb3QoKmNvbnRleHQsIHBnZF9t
YWRkcik7CisgICAgICAgIGNvbnRleHRfc2V0X2FkZHJlc3Nfcm9vdChsY3R4
dCwgcGdkX21hZGRyKTsKICAgICAgICAgaWYgKCBhdHNfZW5hYmxlZCAmJiBl
Y2FwX2Rldl9pb3RsYihpb21tdS0+ZWNhcCkgKQotICAgICAgICAgICAgY29u
dGV4dF9zZXRfdHJhbnNsYXRpb25fdHlwZSgqY29udGV4dCwgQ09OVEVYVF9U
VF9ERVZfSU9UTEIpOworICAgICAgICAgICAgY29udGV4dF9zZXRfdHJhbnNs
YXRpb25fdHlwZShsY3R4dCwgQ09OVEVYVF9UVF9ERVZfSU9UTEIpOwogICAg
ICAgICBlbHNlCi0gICAgICAgICAgICBjb250ZXh0X3NldF90cmFuc2xhdGlv
bl90eXBlKCpjb250ZXh0LCBDT05URVhUX1RUX01VTFRJX0xFVkVMKTsKKyAg
ICAgICAgICAgIGNvbnRleHRfc2V0X3RyYW5zbGF0aW9uX3R5cGUobGN0eHQs
IENPTlRFWFRfVFRfTVVMVElfTEVWRUwpOwogCiAgICAgICAgIHNwaW5fdW5s
b2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogICAgIH0KIAotICAgIGlm
ICggY29udGV4dF9zZXRfZG9tYWluX2lkKGNvbnRleHQsIGRvbWFpbiwgaW9t
bXUpICkKKyAgICBpZiAoIGNvbnRleHRfc2V0X2RvbWFpbl9pZCgmbGN0eHQs
IGRvbWFpbiwgaW9tbXUpICkKICAgICB7CisgICAgdW5sb2NrOgogICAgICAg
ICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOwogICAgICAgICB1bm1hcF92
dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVzKTsKKyAgICAgICAgaWYg
KCBwcmV2X2RvbSApCisgICAgICAgICAgICByY3VfdW5sb2NrX2RvbWFpbihw
cmV2X2RvbSk7CiAgICAgICAgIHJldHVybiAtRUZBVUxUOwogICAgIH0KIAot
ICAgIGNvbnRleHRfc2V0X2FkZHJlc3Nfd2lkdGgoKmNvbnRleHQsIGxldmVs
X3RvX2FnYXcoaW9tbXUtPm5yX3B0X2xldmVscykpOwotICAgIGNvbnRleHRf
c2V0X2ZhdWx0X2VuYWJsZSgqY29udGV4dCk7Ci0gICAgY29udGV4dF9zZXRf
cHJlc2VudCgqY29udGV4dCk7CisgICAgaWYgKCAhcHJldl9kb20gKQorICAg
IHsKKyAgICAgICAgY29udGV4dF9zZXRfYWRkcmVzc193aWR0aChsY3R4dCwg
bGV2ZWxfdG9fYWdhdyhpb21tdS0+bnJfcHRfbGV2ZWxzKSk7CisgICAgICAg
IGNvbnRleHRfc2V0X2ZhdWx0X2VuYWJsZShsY3R4dCk7CisgICAgICAgIGNv
bnRleHRfc2V0X3ByZXNlbnQobGN0eHQpOworICAgIH0KKyAgICBlbHNlIGlm
ICggcHJldl9kb20gPT0gZG9tYWluICkKKyAgICB7CisgICAgICAgIEFTU0VS
VChsY3R4dC5mdWxsID09IGNvbnRleHQtPmZ1bGwpOworICAgICAgICByYyA9
ICEhcGRldjsKKyAgICAgICAgZ290byB1bmxvY2s7CisgICAgfQorICAgIGVs
c2UKKyAgICB7CisgICAgICAgIEFTU0VSVChjb250ZXh0X2FkZHJlc3Nfd2lk
dGgobGN0eHQpID09CisgICAgICAgICAgICAgICBsZXZlbF90b19hZ2F3KGlv
bW11LT5ucl9wdF9sZXZlbHMpKTsKKyAgICAgICAgQVNTRVJUKCFjb250ZXh0
X2ZhdWx0X2Rpc2FibGUobGN0eHQpKTsKKyAgICB9CisKKyAgICBpZiAoIGNw
dV9oYXNfY3gxNiApCisgICAgeworICAgICAgICBfX3VpbnQxMjhfdCByZXMg
PSBjbXB4Y2hnMTZiKGNvbnRleHQsICZvbGQsICZsY3R4dC5mdWxsKTsKKwor
ICAgICAgICAvKgorICAgICAgICAgKiBIYXJkd2FyZSBkb2VzIG5vdCB1cGRh
dGUgdGhlIGNvbnRleHQgZW50cnkgYmVoaW5kIG91ciBiYWNrcywKKyAgICAg
ICAgICogc28gdGhlIHJldHVybiB2YWx1ZSBzaG91bGQgbWF0Y2ggIm9sZCIu
CisgICAgICAgICAqLworICAgICAgICBpZiAoIHJlcyAhPSBvbGQgKQorICAg
ICAgICB7CisgICAgICAgICAgICBpZiAoIHBkZXYgKQorICAgICAgICAgICAg
ICAgIGNoZWNrX2NsZWFudXBfZG9taWRfbWFwKGRvbWFpbiwgcGRldiwgaW9t
bXUpOworICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIKKyAgICAgICAg
ICAgICAgICAgICAiJXBwOiB1bmV4cGVjdGVkIGNvbnRleHQgZW50cnkgJTAx
Nmx4XyUwMTZseCAoZXhwZWN0ZWQgJTAxNmx4XyUwMTZseClcbiIsCisgICAg
ICAgICAgICAgICAgICAgJlBDSV9TQkRGMyhwZGV2LT5zZWcsIHBkZXYtPmJ1
cywgZGV2Zm4pLAorICAgICAgICAgICAgICAgICAgICh1aW50NjRfdCkocmVz
ID4+IDY0KSwgKHVpbnQ2NF90KXJlcywKKyAgICAgICAgICAgICAgICAgICAo
dWludDY0X3QpKG9sZCA+PiA2NCksICh1aW50NjRfdClvbGQpOworICAgICAg
ICAgICAgcmMgPSAtRUlMU0VROworICAgICAgICAgICAgZ290byB1bmxvY2s7
CisgICAgICAgIH0KKyAgICB9CisgICAgZWxzZSBpZiAoICFwcmV2X2RvbSB8
fCAhKG1vZGUgJiBNQVBfV0lUSF9STVJSKSApCisgICAgeworICAgICAgICBj
b250ZXh0X2NsZWFyX3ByZXNlbnQoKmNvbnRleHQpOworICAgICAgICBpb21t
dV9zeW5jX2NhY2hlKGNvbnRleHQsIHNpemVvZigqY29udGV4dCkpOworCisg
ICAgICAgIHdyaXRlX2F0b21pYygmY29udGV4dC0+aGksIGxjdHh0LmhpKTsK
KyAgICAgICAgLyogTm8gYmFycmllciBzaG91bGQgYmUgbmVlZGVkIGJldHdl
ZW4gdGhlc2UgdHdvLiAqLworICAgICAgICB3cml0ZV9hdG9taWMoJmNvbnRl
eHQtPmxvLCBsY3R4dC5sbyk7CisgICAgfQorICAgIGVsc2UgLyogQmVzdCBl
ZmZvcnQsIHVwZGF0aW5nIERJRCBsYXN0LiAqLworICAgIHsKKyAgICAgICAg
IC8qCisgICAgICAgICAgKiBCeSBub24tYXRvbWljYWxseSB1cGRhdGluZyB0
aGUgY29udGV4dCBlbnRyeSdzIERJRCBmaWVsZCBsYXN0LAorICAgICAgICAg
ICogZHVyaW5nIGEgc2hvcnQgd2luZG93IGluIHRpbWUgVExCIGVudHJpZXMg
d2l0aCB0aGUgb2xkIGRvbWFpbiBJRAorICAgICAgICAgICogYnV0IHRoZSBu
ZXcgcGFnZSB0YWJsZXMgbWF5IGJlIGluc2VydGVkLiAgVGhpcyBjb3VsZCBh
ZmZlY3QgSS9PCisgICAgICAgICAgKiBvZiBvdGhlciBkZXZpY2VzIHVzaW5n
IHRoaXMgc2FtZSAob2xkKSBkb21haW4gSUQuICBTdWNoIHVwZGF0aW5nCisg
ICAgICAgICAgKiB0aGVyZWZvcmUgaXMgbm90IGEgcHJvYmxlbSBpZiB0aGlz
IHdhcyB0aGUgb25seSBkZXZpY2UgYXNzb2NpYXRlZAorICAgICAgICAgICog
d2l0aCB0aGUgb2xkIGRvbWFpbiBJRC4gIERpdmVydGluZyBJL08gb2YgYW55
IG9mIGEgZHlpbmcgZG9tYWluJ3MKKyAgICAgICAgICAqIGRldmljZXMgdG8g
dGhlIHF1YXJhbnRpbmUgcGFnZSB0YWJsZXMgaXMgaW50ZW5kZWQgYW55d2F5
LgorICAgICAgICAgICovCisgICAgICAgIGlmICggIShtb2RlICYgKE1BUF9P
V05FUl9EWUlORyB8IE1BUF9TSU5HTEVfREVWSUNFKSkgKQorICAgICAgICAg
ICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HIFZURFBSRUZJWAorICAgICAgICAg
ICAgICAgICAgICIgJXBwOiByZWFzc2lnbm1lbnQgbWF5IGNhdXNlICVwZCBk
YXRhIGNvcnJ1cHRpb25cbiIsCisgICAgICAgICAgICAgICAgICAgJlBDSV9T
QkRGMyhzZWcsIGJ1cywgZGV2Zm4pLCBwcmV2X2RvbSk7CisKKyAgICAgICAg
d3JpdGVfYXRvbWljKCZjb250ZXh0LT5sbywgbGN0eHQubG8pOworICAgICAg
ICAvKiBObyBiYXJyaWVyIHNob3VsZCBiZSBuZWVkZWQgYmV0d2VlbiB0aGVz
ZSB0d28uICovCisgICAgICAgIHdyaXRlX2F0b21pYygmY29udGV4dC0+aGks
IGxjdHh0LmhpKTsKKyAgICB9CisKICAgICBpb21tdV9zeW5jX2NhY2hlKGNv
bnRleHQsIHNpemVvZihzdHJ1Y3QgY29udGV4dF9lbnRyeSkpOwogICAgIHNw
aW5fdW5sb2NrKCZpb21tdS0+bG9jayk7CiAKLSAgICAvKiBDb250ZXh0IGVu
dHJ5IHdhcyBwcmV2aW91c2x5IG5vbi1wcmVzZW50ICh3aXRoIGRvbWlkIDAp
LiAqLwotICAgIHJjID0gaW9tbXVfZmx1c2hfY29udGV4dF9kZXZpY2UoaW9t
bXUsIDAsIFBDSV9CREYyKGJ1cywgZGV2Zm4pLAotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgRE1BX0NDTURfTUFTS19OT0JJVCwgMSk7
CisgICAgcmMgPSBpb21tdV9mbHVzaF9jb250ZXh0X2RldmljZShpb21tdSwg
cHJldl9kaWQsIFBDSV9CREYyKGJ1cywgZGV2Zm4pLAorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgRE1BX0NDTURfTUFTS19OT0JJVCwg
IXByZXZfZG9tKTsKICAgICBmbHVzaF9kZXZfaW90bGIgPSAhIWZpbmRfYXRz
X2Rldl9kcmhkKGlvbW11KTsKLSAgICByZXQgPSBpb21tdV9mbHVzaF9pb3Rs
Yl9kc2koaW9tbXUsIDAsIDEsIGZsdXNoX2Rldl9pb3RsYik7CisgICAgcmV0
ID0gaW9tbXVfZmx1c2hfaW90bGJfZHNpKGlvbW11LCBwcmV2X2RpZCwgIXBy
ZXZfZG9tLCBmbHVzaF9kZXZfaW90bGIpOwogCiAgICAgLyoKICAgICAgKiBU
aGUgY3VycmVudCBsb2dpYyBmb3IgcmV0dXJuczoKQEAgLTE0NTEsMTcgKzE1
NTAsMjYgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAg
IHVubWFwX3Z0ZF9kb21haW5fcGFnZShjb250ZXh0X2VudHJpZXMpOwogCiAg
ICAgaWYgKCAhc2VnICYmICFyYyApCi0gICAgICAgIHJjID0gbWVfd2lmaV9x
dWlyayhkb21haW4sIGJ1cywgZGV2Zm4sIE1BUF9NRV9QSEFOVE9NX0ZVTkMp
OworICAgICAgICByYyA9IG1lX3dpZmlfcXVpcmsoZG9tYWluLCBidXMsIGRl
dmZuLCBtb2RlKTsKIAogICAgIGlmICggcmMgKQogICAgIHsKLSAgICAgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUs
IGJ1cywgZGV2Zm4pOworICAgICAgICBpZiAoICFwcmV2X2RvbSApCisgICAg
ICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWlu
LCBpb21tdSwgYnVzLCBkZXZmbik7CisgICAgICAgIGVsc2UgaWYgKCBwcmV2
X2RvbSAhPSBkb21haW4gKSAvKiBBdm9pZCBpbmZpbml0ZSByZWN1cnNpb24u
ICovCisgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5n
X29uZShwcmV2X2RvbSwgaW9tbXUsIGJ1cywgZGV2Zm4sIHBkZXYsCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtb2Rl
ICYgTUFQX1dJVEhfUk1SUikgPCAwOworICAgICAgICBlbHNlCisgICAgICAg
ICAgICByZXQgPSAxOwogCiAgICAgICAgIGlmICggIXJldCAmJiBwZGV2ICYm
IHBkZXYtPmRldmZuID09IGRldmZuICkKICAgICAgICAgICAgIGNoZWNrX2Ns
ZWFudXBfZG9taWRfbWFwKGRvbWFpbiwgcGRldiwgaW9tbXUpOwogICAgIH0K
IAotICAgIHJldHVybiByYzsKKyAgICBpZiAoIHByZXZfZG9tICkKKyAgICAg
ICAgcmN1X3VubG9ja19kb21haW4ocHJldl9kb20pOworCisgICAgcmV0dXJu
IHJjID86IHBkZXYgJiYgcHJldl9kb207CiB9CiAKIHN0YXRpYyBpbnQgZG9t
YWluX2NvbnRleHRfdW5tYXAoc3RydWN0IGRvbWFpbiAqZCwgdWludDhfdCBk
ZXZmbiwKQEAgLTE0NzEsOCArMTU3OSwxMCBAQCBzdGF0aWMgaW50IGRvbWFp
bl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYpCiB7CiAgICAg
c3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOworICAgIGNvbnN0IHN0cnVj
dCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKICAgICBpbnQgcmV0ID0gMDsKLSAg
ICB1aW50MTZfdCBzZWcgPSBwZGV2LT5zZWc7CisgICAgdW5zaWduZWQgaW50
IGksIG1vZGUgPSAwOworICAgIHVpbnQxNl90IHNlZyA9IHBkZXYtPnNlZywg
YmRmOwogICAgIHVpbnQ4X3QgYnVzID0gcGRldi0+YnVzLCBzZWNidXM7CiAK
ICAgICBkcmhkID0gYWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYp
OwpAQCAtMTQ5Miw4ICsxNjAyLDI5IEBAIHN0YXRpYyBpbnQgZG9tYWluX2Nv
bnRleHRfbWFwcGluZyhzdHJ1Y3QKIAogICAgIEFTU0VSVChwY2lkZXZzX2xv
Y2tlZCgpKTsKIAorICAgIGZvcl9lYWNoX3JtcnJfZGV2aWNlKCBybXJyLCBi
ZGYsIGkgKQorICAgIHsKKyAgICAgICAgaWYgKCBybXJyLT5zZWdtZW50ICE9
IHBkZXYtPnNlZyB8fCBiZGYgIT0gcGRldi0+c2JkZi5iZGYgKQorICAgICAg
ICAgICAgY29udGludWU7CisKKyAgICAgICAgbW9kZSB8PSBNQVBfV0lUSF9S
TVJSOworICAgICAgICBicmVhazsKKyAgICB9CisKKyAgICBpZiAoIGRvbWFp
biAhPSBwZGV2LT5kb21haW4gKQorICAgIHsKKyAgICAgICAgaWYgKCBwZGV2
LT5kb21haW4tPmlzX2R5aW5nICkKKyAgICAgICAgICAgIG1vZGUgfD0gTUFQ
X09XTkVSX0RZSU5HOworICAgICAgICBlbHNlIGlmICggZHJoZCAmJgorICAg
ICAgICAgICAgICAgICAgIWFueV9wZGV2X2JlaGluZF9pb21tdShwZGV2LT5k
b21haW4sIHBkZXYsIGRyaGQtPmlvbW11KSAmJgorICAgICAgICAgICAgICAg
ICAgIXBkZXYtPnBoYW50b21fc3RyaWRlICkKKyAgICAgICAgICAgIG1vZGUg
fD0gTUFQX1NJTkdMRV9ERVZJQ0U7CisgICAgfQorCiAgICAgc3dpdGNoICgg
cGRldi0+dHlwZSApCiAgICAgeworICAgICAgICBib29sIHByZXZfcHJlc2Vu
dDsKKwogICAgIGNhc2UgREVWX1RZUEVfUENJX0hPU1RfQlJJREdFOgogICAg
ICAgICBpZiAoIGlvbW11X2RlYnVnICkKICAgICAgICAgICAgIHByaW50ayhW
VERQUkVGSVggIiVwZDpIb3N0YnJpZGdlOiBza2lwICVwcCBtYXBcbiIsCkBA
IC0xNTEyLDcgKzE2NDMsOSBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0
X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAgICBwcmludGsoVlREUFJFRklY
ICIlcGQ6UENJZTogbWFwICVwcFxuIiwKICAgICAgICAgICAgICAgICAgICBk
b21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7CiAgICAgICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJo
ZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHBkZXYpOworICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBtb2RlKTsKKyAgICAgICAg
aWYgKCByZXQgPiAwICkKKyAgICAgICAgICAgIHJldCA9IDA7CiAgICAgICAg
IGlmICggIXJldCAmJiBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBhdHNfZGV2
aWNlKHBkZXYsIGRyaGQpID4gMCApCiAgICAgICAgICAgICBlbmFibGVfYXRz
X2RldmljZShwZGV2LCAmZHJoZC0+aW9tbXUtPmF0c19kZXZpY2VzKTsKIApA
QCAtMTUyNCw5ICsxNjU3LDEwIEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgICAgICAgICBkb21haW4s
ICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7CiAKICAgICAgICAgcmV0
ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5p
b21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgcGRldik7Ci0gICAgICAgIGlmICggcmV0ICkKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRldiwg
bW9kZSk7CisgICAgICAgIGlmICggcmV0IDwgMCApCiAgICAgICAgICAgICBi
cmVhazsKKyAgICAgICAgcHJldl9wcmVzZW50ID0gcmV0OwogCiAgICAgICAg
IGlmICggKHJldCA9IGZpbmRfdXBzdHJlYW1fYnJpZGdlKHNlZywgJmJ1cywg
JmRldmZuLCAmc2VjYnVzKSkgPCAxICkKICAgICAgICAgewpAQCAtMTUzNCw2
ICsxNjY4LDE1IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGlu
ZyhzdHJ1Y3QKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAg
IHJldCA9IC1FTlhJTzsKICAgICAgICAgfQorICAgICAgICAvKgorICAgICAg
ICAgKiBTdHJpY3RseSBzcGVha2luZyBpZiB0aGUgZGV2aWNlIGlzIHRoZSBv
bmx5IG9uZSBiZWhpbmQgdGhpcyBicmlkZ2UKKyAgICAgICAgICogYW5kIHRo
ZSBvbmx5IG9uZSB3aXRoIHRoaXMgKHNlY2J1cywwLDApIHR1cGxlLCBpdCBj
b3VsZCBiZSBhbGxvd2VkCisgICAgICAgICAqIHRvIGJlIHJlLWFzc2lnbmVk
IHJlZ2FyZGxlc3Mgb2YgUk1SUiBwcmVzZW5jZS4gIEJ1dCBsZXQncyBkZWFs
IHdpdGgKKyAgICAgICAgICogdGhhdCBjYXNlIG9ubHkgaWYgaXQgaXMgYWN0
dWFsbHkgZm91bmQgaW4gdGhlIHdpbGQuCisgICAgICAgICAqLworICAgICAg
ICBlbHNlIGlmICggcHJldl9wcmVzZW50ICYmIChtb2RlICYgTUFQX1dJVEhf
Uk1SUikgJiYKKyAgICAgICAgICAgICAgICAgIGRvbWFpbiAhPSBwZGV2LT5k
b21haW4gKQorICAgICAgICAgICAgcmV0ID0gLUVPUE5PVFNVUFA7CiAKICAg
ICAgICAgLyoKICAgICAgICAgICogTWFwcGluZyBhIGJyaWRnZSBzaG91bGQs
IGlmIGFueXRoaW5nLCBwYXNzIHRoZSBzdHJ1Y3QgcGNpX2RldiBvZgpAQCAt
MTU0Miw3ICsxNjg1LDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9t
YXBwaW5nKHN0cnVjdAogICAgICAgICAgKi8KICAgICAgICAgaWYgKCByZXQg
Pj0gMCApCiAgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBw
aW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVM
TCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBOVUxMLCBtb2RlKTsKIAogICAgICAgICAvKgogICAgICAgICAgKiBE
ZXZpY2VzIGJlaGluZCBQQ0llLXRvLVBDSS9QQ0l4IGJyaWRnZSBtYXkgZ2Vu
ZXJhdGUgZGlmZmVyZW50CkBAIC0xNTU3LDEwICsxNzAwLDE1IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAg
aWYgKCAhcmV0ICYmIHBkZXZfdHlwZShzZWcsIGJ1cywgZGV2Zm4pID09IERF
Vl9UWVBFX1BDSWUyUENJX0JSSURHRSAmJgogICAgICAgICAgICAgIChzZWNi
dXMgIT0gcGRldi0+YnVzIHx8IHBkZXYtPmRldmZuICE9IDApICkKICAgICAg
ICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFp
biwgZHJoZC0+aW9tbXUsIHNlY2J1cywgMCwKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwpOworICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgbW9k
ZSk7CiAKICAgICAgICAgaWYgKCByZXQgKQotICAgICAgICAgICAgZG9tYWlu
X2NvbnRleHRfdW5tYXAoZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgICAg
IHsKKyAgICAgICAgICAgIGlmICggIXByZXZfcHJlc2VudCApCisgICAgICAg
ICAgICAgICAgZG9tYWluX2NvbnRleHRfdW5tYXAoZG9tYWluLCBkZXZmbiwg
cGRldik7CisgICAgICAgICAgICBlbHNlIGlmICggcGRldi0+ZG9tYWluICE9
IGRvbWFpbiApIC8qIEF2b2lkIGluZmluaXRlIHJlY3Vyc2lvbi4gKi8KKyAg
ICAgICAgICAgICAgICBkb21haW5fY29udGV4dF9tYXBwaW5nKHBkZXYtPmRv
bWFpbiwgZGV2Zm4sIHBkZXYpOworICAgICAgICB9CiAKICAgICAgICAgYnJl
YWs7CiAKQEAgLTIzMzYsOSArMjQ4NCw4IEBAIHN0YXRpYyBpbnQgcmVhc3Np
Z25fZGV2aWNlX293bmVyc2hpcCgKIHsKICAgICBpbnQgcmV0OwogCi0gICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAoc291cmNlLCBkZXZmbiwgcGRl
dik7Ci0gICAgaWYgKCByZXQgKQotICAgICAgICByZXR1cm4gcmV0OworICAg
IGlmICggIWhhc19hcmNoX3BkZXZzKHRhcmdldCkgKQorICAgICAgICB2bXhf
cGlfaG9va3NfYXNzaWduKHRhcmdldCk7CiAKICAgICAvKgogICAgICAqIERl
dmljZXMgYXNzaWduZWQgdG8gdW50cnVzdGVkIGRvbWFpbnMgKGhlcmUgYXNz
dW1lZCB0byBiZSBhbnkgZG9tVSkKQEAgLTIzNDgsNiArMjQ5NSwzMSBAQCBz
dGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNoaXAoCiAgICAgaWYg
KCAodGFyZ2V0ICE9IGhhcmR3YXJlX2RvbWFpbikgJiYgIWlvbW11X2ludHJl
bWFwICkKICAgICAgICAgdW50cnVzdGVkX21zaSA9IHRydWU7CiAKKyAgICBy
ZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nKHRhcmdldCwgZGV2Zm4sIHBk
ZXYpOworICAgIGlmICggcmV0ICkKKyAgICB7CisgICAgICAgIGlmICggIWhh
c19hcmNoX3BkZXZzKHRhcmdldCkgKQorICAgICAgICAgICAgdm14X3BpX2hv
b2tzX2RlYXNzaWduKHRhcmdldCk7CisgICAgICAgIHJldHVybiByZXQ7Cisg
ICAgfQorCisgICAgaWYgKCBwZGV2LT5kZXZmbiA9PSBkZXZmbiApCisgICAg
eworICAgICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQg
PSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CisKKyAgICAg
ICAgaWYgKCBkcmhkICkKKyAgICAgICAgICAgIGNoZWNrX2NsZWFudXBfZG9t
aWRfbWFwKHNvdXJjZSwgcGRldiwgZHJoZC0+aW9tbXUpOworICAgIH0KKwor
ICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWlu
ICE9IHRhcmdldCApCisgICAgeworICAgICAgICBsaXN0X21vdmUoJnBkZXYt
PmRvbWFpbl9saXN0LCAmdGFyZ2V0LT5wZGV2X2xpc3QpOworICAgICAgICBw
ZGV2LT5kb21haW4gPSB0YXJnZXQ7CisgICAgfQorCisgICAgaWYgKCAhaGFz
X2FyY2hfcGRldnMoc291cmNlKSApCisgICAgICAgIHZteF9waV9ob29rc19k
ZWFzc2lnbihzb3VyY2UpOworCiAgICAgLyoKICAgICAgKiBJZiB0aGUgZGV2
aWNlIGJlbG9uZ3MgdG8gdGhlIGhhcmR3YXJlIGRvbWFpbiwgYW5kIGl0IGhh
cyBSTVJSLCBkb24ndAogICAgICAqIHJlbW92ZSBpdCBmcm9tIHRoZSBoYXJk
d2FyZSBkb21haW4sIGJlY2F1c2UgQklPUyBtYXkgdXNlIFJNUlIgYXQKQEAg
LTIzNzYsMzQgKzI1NDgsNyBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2Rldmlj
ZV9vd25lcnNoaXAoCiAgICAgICAgICAgICB9CiAgICAgfQogCi0gICAgaWYg
KCBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21haW4gIT0gZG9t
X2lvICkKLSAgICB7Ci0gICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9tYWlu
X2xpc3QsICZkb21faW8tPnBkZXZfbGlzdCk7Ci0gICAgICAgIHBkZXYtPmRv
bWFpbiA9IGRvbV9pbzsKLSAgICB9Ci0KLSAgICBpZiAoICFoYXNfYXJjaF9w
ZGV2cyhzb3VyY2UpICkKLSAgICAgICAgdm14X3BpX2hvb2tzX2RlYXNzaWdu
KHNvdXJjZSk7Ci0KLSAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyh0YXJnZXQp
ICkKLSAgICAgICAgdm14X3BpX2hvb2tzX2Fzc2lnbih0YXJnZXQpOwotCi0g
ICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZyh0YXJnZXQsIGRldmZu
LCBwZGV2KTsKLSAgICBpZiAoIHJldCApCi0gICAgewotICAgICAgICBpZiAo
ICFoYXNfYXJjaF9wZGV2cyh0YXJnZXQpICkKLSAgICAgICAgICAgIHZteF9w
aV9ob29rc19kZWFzc2lnbih0YXJnZXQpOwotCi0gICAgICAgIHJldHVybiBy
ZXQ7Ci0gICAgfQotCi0gICAgaWYgKCBkZXZmbiA9PSBwZGV2LT5kZXZmbiAm
JiBwZGV2LT5kb21haW4gIT0gdGFyZ2V0ICkKLSAgICB7Ci0gICAgICAgIGxp
c3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZ0YXJnZXQtPnBkZXZfbGlz
dCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9IHRhcmdldDsKLSAgICB9Ci0K
LSAgICByZXR1cm4gcmV0OworICAgIHJldHVybiAwOwogfQogCiBzdGF0aWMg
aW50IGludGVsX2lvbW11X2Fzc2lnbl9kZXZpY2UoCi0tLSBhL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5oCkBAIC0yMDIsOCArMjAyLDEyIEBA
IHN0cnVjdCByb290X2VudHJ5IHsKICAgICBkbyB7KHJvb3QpLnZhbCB8PSAo
KHZhbHVlKSAmIFBBR0VfTUFTS180Syk7fSB3aGlsZSgwKQogCiBzdHJ1Y3Qg
Y29udGV4dF9lbnRyeSB7Ci0gICAgdTY0IGxvOwotICAgIHU2NCBoaTsKKyAg
ICB1bmlvbiB7CisgICAgICAgIHN0cnVjdCB7CisgICAgICAgICAgICB1aW50
NjRfdCBsbywgaGk7CisgICAgICAgIH07CisgICAgICAgIF9fdWludDEyOF90
IGZ1bGw7CisgICAgfTsKIH07CiAjZGVmaW5lIFJPT1RfRU5UUllfTlIgKFBB
R0VfU0laRV80Sy9zaXplb2Yoc3RydWN0IHJvb3RfZW50cnkpKQogI2RlZmlu
ZSBjb250ZXh0X3ByZXNlbnQoYykgKChjKS5sbyAmIDEpCi0tLSBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xdWlya3MuYworKysgYi94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC92dGQvcXVpcmtzLmMKQEAgLTM0NCw3ICszNDQs
OCBAQCB2b2lkIF9faW5pdCBwbGF0Zm9ybV9xdWlya3NfaW5pdCh2b2lkKQog
ICovCiAKIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIG1hcF9tZV9waGFudG9t
X2Z1bmN0aW9uKHN0cnVjdCBkb21haW4gKmRvbWFpbiwKLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHUzMiBkZXYs
IGludCBtYXApCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZGV2LAorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQg
aW50IG1vZGUpCiB7CiAgICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhk
OwogICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2OwpAQCAtMzU1LDkgKzM1Niw5
IEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIG1hcF9tZV9waGFudG9tX2YK
ICAgICBkcmhkID0gYWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYp
OwogCiAgICAgLyogbWFwIG9yIHVubWFwIE1FIHBoYW50b20gZnVuY3Rpb24g
Ki8KLSAgICBpZiAoIG1hcCApCisgICAgaWYgKCAhKG1vZGUgJiBVTk1BUF9N
RV9QSEFOVE9NX0ZVTkMpICkKICAgICAgICAgcmMgPSBkb21haW5fY29udGV4
dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCAwLAotICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihk
ZXYsIDcpLCBOVUxMKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBQQ0lfREVWRk4oZGV2LCA3KSwgTlVMTCwgbW9kZSk7CiAg
ICAgZWxzZQogICAgICAgICByYyA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29u
ZShkb21haW4sIGRyaGQtPmlvbW11LCAwLAogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBQQ0lfREVWRk4oZGV2LCA3KSk7CkBAIC0z
NjUsNyArMzY2LDggQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgbWFwX21l
X3BoYW50b21fZgogICAgIHJldHVybiByYzsKIH0KIAotaW50IG1lX3dpZmlf
cXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLCB1OCBidXMsIHU4IGRldmZu
LCBpbnQgbWFwKQoraW50IG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAq
ZG9tYWluLCB1aW50OF90IGJ1cywgdWludDhfdCBkZXZmbiwKKyAgICAgICAg
ICAgICAgICAgIHVuc2lnbmVkIGludCBtb2RlKQogewogICAgIHUzMiBpZDsK
ICAgICBpbnQgcmMgPSAwOwpAQCAtMzg5LDcgKzM5MSw3IEBAIGludCBtZV93
aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICAgICAgICAg
IGNhc2UgMHg0MjNiODA4NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjNjODA4
NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjNkODA4NjoKLSAgICAgICAgICAg
ICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMywg
bWFwKTsKKyAgICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1
bmN0aW9uKGRvbWFpbiwgMywgbW9kZSk7CiAgICAgICAgICAgICAgICAgYnJl
YWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIGJy
ZWFrOwpAQCAtNDE1LDcgKzQxNyw3IEBAIGludCBtZV93aWZpX3F1aXJrKHN0
cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICAgICAgICAgIGNhc2UgMHg0MjM4
ODA4NjogICAgICAgIC8qIFB1bWEgUGVhayAqLwogICAgICAgICAgICAgY2Fz
ZSAweDQyMmI4MDg2OgogICAgICAgICAgICAgY2FzZSAweDQyMmM4MDg2Ogot
ICAgICAgICAgICAgICAgIHJjID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24o
ZG9tYWluLCAyMiwgbWFwKTsKKyAgICAgICAgICAgICAgICByYyA9IG1hcF9t
ZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMjIsIG1vZGUpOwogICAgICAg
ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgZGVmYXVsdDoKICAgICAg
ICAgICAgICAgICBicmVhazsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvdnRkL3Z0ZC5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0
ZC92dGQuaApAQCAtMjIsOCArMjIsMTQgQEAKIAogI2luY2x1ZGUgPHhlbi9p
b21tdS5oPgogCi0jZGVmaW5lIE1BUF9NRV9QSEFOVE9NX0ZVTkMgICAgICAx
Ci0jZGVmaW5lIFVOTUFQX01FX1BIQU5UT01fRlVOQyAgICAwCisvKgorICog
VmFsdWVzIGZvciBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgpJ3MgYW5k
IG1lX3dpZmlfcXVpcmsoKSdzICJtb2RlIgorICogcGFyYW1ldGVycy4KKyAq
LworI2RlZmluZSBNQVBfV0lUSF9STVJSICAgICAgICAgKDF1IDw8IDApCisj
ZGVmaW5lIE1BUF9PV05FUl9EWUlORyAgICAgICAoMXUgPDwgMSkKKyNkZWZp
bmUgTUFQX1NJTkdMRV9ERVZJQ0UgICAgICgxdSA8PCAyKQorI2RlZmluZSBV
Tk1BUF9NRV9QSEFOVE9NX0ZVTkMgKDF1IDw8IDMpCiAKIC8qIEFsbG93IGZv
ciBib3RoIElPQVBJQyBhbmQgSU9TQVBJQy4gKi8KICNkZWZpbmUgSU9feEFQ
SUNfcm91dGVfZW50cnkgSU9fQVBJQ19yb3V0ZV9lbnRyeQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-06.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IHJlLWFzc2lnbiBkZXZpY2VzIGRpcmVjdGx5CgpEZXZp
Y2VzIHdpdGggdW5pdHkgbWFwIHJhbmdlcywgZHVlIHRvIGl0IGJlaW5nIHVu
c3BlY2lmaWVkIGhvdy93aGVuCnRoZXNlIG1lbW9yeSByYW5nZXMgbWF5IGdl
dCBhY2Nlc3NlZCwgbWF5IG5vdCBiZSBsZWZ0IGRpc2Nvbm5lY3RlZCBmcm9t
CnRoZWlyIHVuaXR5IG1hcHBpbmdzIChhcyBsb25nIGFzIGl0J3Mgbm90IGNl
cnRhaW4gdGhhdCB0aGUgZGV2aWNlIGhhcwpiZWVuIGZ1bGx5IHF1aWVzY2Vk
KS4gSGVuY2UgcmF0aGVyIHRoYW4gdGVhcmluZyBkb3duIHRoZSBvbGQgcm9v
dCBwYWdlCnRhYmxlIHBvaW50ZXIgYW5kIHRoZW4gZXN0YWJsaXNoaW5nIHRo
ZSBuZXcgb25lLCByZS1hc3NpZ25tZW50IG5lZWRzIHRvCmJlIGRvbmUgaW4g
YSBzaW5nbGUgc3RlcC4KClRoaXMgaXMgQ1ZFLTIwMjItMjYzNjAgLyBwYXJ0
IG9mIFhTQS00MDAuCgpSZXBvcnRlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8
cm9nZXIucGF1QGNpdHJpeC5jb20+CgpTaW1pbGFybHkgcXVhcmFudGluaW5n
IHNjcmF0Y2gtcGFnZSBtb2RlIHJlbGllcyBvbiBwYWdlIHRhYmxlcyB0byBi
ZQpjb250aW51b3VzbHkgd2lyZWQgdXAuCgpUbyBhdm9pZCBjb21wbGljYXRp
bmcgdGhpbmdzIG1vcmUgdGhhbiBuZWNlc3NhcnksIHRyZWF0IGFsbCBkZXZp
Y2VzCm1vc3RseSBlcXVhbGx5LCBpLmUuIHJlZ2FyZGxlc3Mgb2YgdGhlaXIg
YXNzb2NpYXRpb24gd2l0aCBhbnkgdW5pdHkgbWFwCnJhbmdlcy4gIFRoZSBt
YWluIGRpZmZlcmVuY2UgaXMgd2hlbiBpdCBjb21lcyB0byB1cGRhdGluZyBE
VEVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21pYyB3aGVuIHRoZXJlIGFyZSB1
bml0eSBtYXBwaW5ncy4gWWV0IGF0b21pY2l0eSBjYW4gb25seSBiZQphY2hp
ZXZlZCB3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBvZiB3aGljaCB3
ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwg
RHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+CgotLS0gYS94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUuaAorKysgYi94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUuaApAQCAtMjQ3LDkgKzI0NywxMyBA
QCB2b2lkIGFtZF9pb21tdV9zZXRfaW50cmVtYXBfdGFibGUoc3RydWN0CiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgdm9pZCAq
cHRyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0
IHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LAogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGJvb2wgdmFsaWQpOwotdm9pZCBhbWRfaW9tbXVf
c2V0X3Jvb3RfcGFnZV90YWJsZShzdHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRl
LAotCQkJCSAgIHVpbnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBkb21haW5f
aWQsCi0JCQkJICAgdWludDhfdCBwYWdpbmdfbW9kZSwgYm9vbCB2YWxpZCk7
CisjZGVmaW5lIFNFVF9ST09UX1ZBTElEICAgICAgICAgICgxdSA8PCAwKQor
I2RlZmluZSBTRVRfUk9PVF9XSVRIX1VOSVRZX01BUCAoMXUgPDwgMSkKK2lu
dCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUo
c3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3Qgcm9vdF9w
dHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHVpbnQxNl90IGRvbWFpbl9pZCwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBwYWdpbmdf
bW9kZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgdW5zaWduZWQgaW50IGZsYWdzKTsKIHZvaWQgaW9tbXVfZHRl
X2FkZF9kZXZpY2VfZW50cnkoc3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0
IGl2cnNfbWFwcGluZ3MgKml2cnNfZGV2KTsKIAotLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jCkBAIC0xMTQsMTAgKzEx
NCw2OSBAQCBzdGF0aWMgdW5zaWduZWQgaW50IHNldF9pb21tdV9wdGVzX3By
ZXNlCiAgICAgcmV0dXJuIGZsdXNoX2ZsYWdzOwogfQogCi12b2lkIGFtZF9p
b21tdV9zZXRfcm9vdF9wYWdlX3RhYmxlKHN0cnVjdCBhbWRfaW9tbXVfZHRl
ICpkdGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVp
bnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBkb21haW5faWQsCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgcGFnaW5nX21v
ZGUsIGJvb2wgdmFsaWQpCisvKgorICogVGhpcyBmdW5jdGlvbiByZXR1cm5z
CisgKiAtIC1lcnJubyBmb3IgZXJyb3JzLAorICogLSAwIGZvciBhIHN1Y2Nl
c3NmdWwgdXBkYXRlLCBhdG9taWMgd2hlbiBuZWNlc3NhcnkKKyAqIC0gMSBm
b3IgYSBzdWNjZXNzZnVsIGJ1dCBub24tYXRvbWljIHVwZGF0ZSwgd2hpY2gg
bWF5IG5lZWQgdG8gYmUgd2FybmVkCisgKiAgIGFib3V0IGJ5IHRoZSBjYWxs
ZXIuCisgKi8KK2ludCBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZShz
dHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRlLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHVpbnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBk
b21haW5faWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
dWludDhfdCBwYWdpbmdfbW9kZSwgdW5zaWduZWQgaW50IGZsYWdzKQogewor
ICAgIGJvb2wgdmFsaWQgPSBmbGFncyAmIFNFVF9ST09UX1ZBTElEOworCisg
ICAgaWYgKCBkdGUtPnYgJiYgZHRlLT50diAmJgorICAgICAgICAgKGNwdV9o
YXNfY3gxNiB8fCAoZmxhZ3MgJiBTRVRfUk9PVF9XSVRIX1VOSVRZX01BUCkp
ICkKKyAgICB7CisgICAgICAgIHVuaW9uIHsKKyAgICAgICAgICAgIHN0cnVj
dCBhbWRfaW9tbXVfZHRlIGR0ZTsKKyAgICAgICAgICAgIHVpbnQ2NF90IHJh
dzY0WzRdOworICAgICAgICAgICAgX191aW50MTI4X3QgcmF3MTI4WzJdOwor
ICAgICAgICB9IGxkdGUgPSB7IC5kdGUgPSAqZHRlIH07CisgICAgICAgIF9f
dWludDEyOF90IG9sZCA9IGxkdGUucmF3MTI4WzBdOworICAgICAgICBpbnQg
cmV0ID0gMDsKKworICAgICAgICBsZHRlLmR0ZS5kb21haW5faWQgPSBkb21h
aW5faWQ7CisgICAgICAgIGxkdGUuZHRlLnB0X3Jvb3QgPSBwYWRkcl90b19w
Zm4ocm9vdF9wdHIpOworICAgICAgICBsZHRlLmR0ZS5pdyA9IHRydWU7Cisg
ICAgICAgIGxkdGUuZHRlLmlyID0gdHJ1ZTsKKyAgICAgICAgbGR0ZS5kdGUu
cGFnaW5nX21vZGUgPSBwYWdpbmdfbW9kZTsKKyAgICAgICAgbGR0ZS5kdGUu
diA9IHZhbGlkOworCisgICAgICAgIGlmICggY3B1X2hhc19jeDE2ICkKKyAg
ICAgICAgeworICAgICAgICAgICAgX191aW50MTI4X3QgcmVzID0gY21weGNo
ZzE2YihkdGUsICZvbGQsICZsZHRlLnJhdzEyOFswXSk7CisKKyAgICAgICAg
ICAgIC8qCisgICAgICAgICAgICAgKiBIYXJkd2FyZSBkb2VzIG5vdCB1cGRh
dGUgdGhlIERURSBiZWhpbmQgb3VyIGJhY2tzLCBzbyB0aGUKKyAgICAgICAg
ICAgICAqIHJldHVybiB2YWx1ZSBzaG91bGQgbWF0Y2ggIm9sZCIuCisgICAg
ICAgICAgICAgKi8KKyAgICAgICAgICAgIGlmICggcmVzICE9IG9sZCApCisg
ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19F
UlIKKyAgICAgICAgICAgICAgICAgICAgICAgIkRvbSVkOiB1bmV4cGVjdGVk
IERURSAlMDE2bHhfJTAxNmx4IChleHBlY3RlZCAlMDE2bHhfJTAxNmx4KVxu
IiwKKyAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluX2lkLAorICAgICAg
ICAgICAgICAgICAgICAgICAodWludDY0X3QpKHJlcyA+PiA2NCksICh1aW50
NjRfdClyZXMsCisgICAgICAgICAgICAgICAgICAgICAgICh1aW50NjRfdCko
b2xkID4+IDY0KSwgKHVpbnQ2NF90KW9sZCk7CisgICAgICAgICAgICAgICAg
cmV0ID0gLUVJTFNFUTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAg
ICAgICBlbHNlIC8qIEJlc3QgZWZmb3J0LCB1cGRhdGluZyBkb21haW5faWQg
bGFzdC4gKi8KKyAgICAgICAgeworICAgICAgICAgICAgdWludDY0X3QgKnB0
ciA9ICh2b2lkICopZHRlOworCisgICAgICAgICAgICB3cml0ZV9hdG9taWMo
cHRyICsgMCwgbGR0ZS5yYXc2NFswXSk7CisgICAgICAgICAgICAvKiBObyBi
YXJyaWVyIHNob3VsZCBiZSBuZWVkZWQgYmV0d2VlbiB0aGVzZSB0d28uICov
CisgICAgICAgICAgICB3cml0ZV9hdG9taWMocHRyICsgMSwgbGR0ZS5yYXc2
NFsxXSk7CisKKyAgICAgICAgICAgIHJldCA9IDE7CisgICAgICAgIH0KKwor
ICAgICAgICByZXR1cm4gcmV0OworICAgIH0KKwogICAgIGlmICggdmFsaWQg
fHwgZHRlLT52ICkKICAgICB7CiAgICAgICAgIGR0ZS0+dHYgPSBmYWxzZTsK
QEAgLTEzMiw2ICsxOTEsOCBAQCB2b2lkIGFtZF9pb21tdV9zZXRfcm9vdF9w
YWdlX3RhYmxlKHN0cnVjCiAgICAgc21wX3dtYigpOwogICAgIGR0ZS0+dHYg
PSB0cnVlOwogICAgIGR0ZS0+diA9IHZhbGlkOworCisgICAgcmV0dXJuIDA7
CiB9CiAKIHZvaWQgYW1kX2lvbW11X3NldF9pbnRyZW1hcF90YWJsZSgKLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUu
YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9p
b21tdS5jCkBAIC04MSw0MSArODEsODIgQEAgaW50IGdldF9kbWFfcmVxdWVz
dG9yX2lkKHVpbnQxNl90IHNlZywgdQogICAgIHJldHVybiByZXFfaWQ7CiB9
CiAKLXN0YXRpYyB2b2lkIGFtZF9pb21tdV9zZXR1cF9kb21haW5fZGV2aWNl
KAorc3RhdGljIGludCBfX211c3RfY2hlY2sgYWxsb2NhdGVfZG9tYWluX3Jl
c291cmNlcyhzdHJ1Y3QgZG9tYWluICpkKQoreworICAgIHN0cnVjdCBkb21h
aW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOworICAgIGludCByYzsKKwor
ICAgIHNwaW5fbG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKKyAgICBy
YyA9IGFtZF9pb21tdV9hbGxvY19yb290KGQpOworICAgIHNwaW5fdW5sb2Nr
KCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOworCisgICAgcmV0dXJuIHJjOwor
fQorCitzdGF0aWMgYm9vbCBhbnlfcGRldl9iZWhpbmRfaW9tbXUoY29uc3Qg
c3RydWN0IGRvbWFpbiAqZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqZXhjbHVkZSwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgYW1k
X2lvbW11ICppb21tdSkKK3sKKyAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldjsKKworICAgIGZvcl9lYWNoX3BkZXYgKCBkLCBwZGV2ICkKKyAgICB7
CisgICAgICAgIGlmICggcGRldiA9PSBleGNsdWRlICkKKyAgICAgICAgICAg
IGNvbnRpbnVlOworCisgICAgICAgIGlmICggZmluZF9pb21tdV9mb3JfZGV2
aWNlKHBkZXYtPnNlZywgcGRldi0+c2JkZi5iZGYpID09IGlvbW11ICkKKyAg
ICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKworICAgIHJldHVybiBm
YWxzZTsKK30KKworc3RhdGljIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11
X3NldHVwX2RvbWFpbl9kZXZpY2UoCiAgICAgc3RydWN0IGRvbWFpbiAqZG9t
YWluLCBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwKICAgICB1aW50OF90IGRl
dmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikKIHsKICAgICBzdHJ1Y3QgYW1k
X2lvbW11X2R0ZSAqdGFibGUsICpkdGU7CiAgICAgdW5zaWduZWQgbG9uZyBm
bGFnczsKLSAgICBpbnQgcmVxX2lkLCB2YWxpZCA9IDE7CisgICAgdW5zaWdu
ZWQgaW50IHJlcV9pZCwgc3JfZmxhZ3M7CisgICAgaW50IHJjOwogICAgIHU4
IGJ1cyA9IHBkZXYtPmJ1czsKICAgICBjb25zdCBzdHJ1Y3QgZG9tYWluX2lv
bW11ICpoZCA9IGRvbV9pb21tdShkb21haW4pOworICAgIGNvbnN0IHN0cnVj
dCBpdnJzX21hcHBpbmdzICppdnJzX2RldjsKKworICAgIEJVR19PTighaGQt
PmFyY2guYW1kLnBhZ2luZ19tb2RlIHx8ICFpb21tdS0+ZGV2X3RhYmxlLmJ1
ZmZlcik7CiAKLSAgICBCVUdfT04oICFoZC0+YXJjaC5hbWQucm9vdF90YWJs
ZSB8fAotICAgICAgICAgICAgIWhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSB8
fAotICAgICAgICAgICAgIWlvbW11LT5kZXZfdGFibGUuYnVmZmVyICk7Cisg
ICAgcmMgPSBhbGxvY2F0ZV9kb21haW5fcmVzb3VyY2VzKGRvbWFpbik7Cisg
ICAgaWYgKCByYyApCisgICAgICAgIHJldHVybiByYzsKIAotICAgIGlmICgg
aW9tbXVfaHdkb21fcGFzc3Rocm91Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWlu
KGRvbWFpbikgKQotICAgICAgICB2YWxpZCA9IDA7CisgICAgcmVxX2lkID0g
Z2V0X2RtYV9yZXF1ZXN0b3JfaWQoaW9tbXUtPnNlZywgcGRldi0+c2JkZi5i
ZGYpOworICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21hcHBpbmdzKGlvbW11
LT5zZWcpW3JlcV9pZF07CisgICAgc3JfZmxhZ3MgPSAoaW9tbXVfaHdkb21f
cGFzc3Rocm91Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWluKGRvbWFpbikKKyAg
ICAgICAgICAgICAgICA/IDAgOiBTRVRfUk9PVF9WQUxJRCkKKyAgICAgICAg
ICAgICAgIHwgKGl2cnNfZGV2LT51bml0eV9tYXAgPyBTRVRfUk9PVF9XSVRI
X1VOSVRZX01BUCA6IDApOwogCiAgICAgLyogZ2V0IGRldmljZS10YWJsZSBl
bnRyeSAqLwogICAgIHJlcV9pZCA9IGdldF9kbWFfcmVxdWVzdG9yX2lkKGlv
bW11LT5zZWcsIFBDSV9CREYyKGJ1cywgZGV2Zm4pKTsKICAgICB0YWJsZSA9
IGlvbW11LT5kZXZfdGFibGUuYnVmZmVyOwogICAgIGR0ZSA9ICZ0YWJsZVty
ZXFfaWRdOworICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21hcHBpbmdzKGlv
bW11LT5zZWcpW3JlcV9pZF07CiAKICAgICBzcGluX2xvY2tfaXJxc2F2ZSgm
aW9tbXUtPmxvY2ssIGZsYWdzKTsKIAogICAgIGlmICggIWR0ZS0+diB8fCAh
ZHRlLT50diApCiAgICAgewotICAgICAgICBjb25zdCBzdHJ1Y3QgaXZyc19t
YXBwaW5ncyAqaXZyc19kZXY7Ci0KICAgICAgICAgLyogYmluZCBEVEUgdG8g
ZG9tYWluIHBhZ2UtdGFibGVzICovCi0gICAgICAgIGFtZF9pb21tdV9zZXRf
cm9vdF9wYWdlX3RhYmxlKAotICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21h
ZGRyKGhkLT5hcmNoLmFtZC5yb290X3RhYmxlKSwKLSAgICAgICAgICAgIGRv
bWFpbi0+ZG9tYWluX2lkLCBoZC0+YXJjaC5hbWQucGFnaW5nX21vZGUsIHZh
bGlkKTsKKyAgICAgICAgcmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90
YWJsZSgKKyAgICAgICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRyKGhk
LT5hcmNoLmFtZC5yb290X3RhYmxlKSwKKyAgICAgICAgICAgICAgICAgZG9t
YWluLT5kb21haW5faWQsIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSwgc3Jf
ZmxhZ3MpOworICAgICAgICBpZiAoIHJjICkKKyAgICAgICAgeworICAgICAg
ICAgICAgQVNTRVJUKHJjIDwgMCk7CisgICAgICAgICAgICBzcGluX3VubG9j
a19pcnFyZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3MpOworICAgICAgICAg
ICAgcmV0dXJuIHJjOworICAgICAgICB9CiAKICAgICAgICAgLyogVW5kbyB3
aGF0IGFtZF9pb21tdV9kaXNhYmxlX2RvbWFpbl9kZXZpY2UoKSBtYXkgaGF2
ZSBkb25lLiAqLwotICAgICAgICBpdnJzX2RldiA9ICZnZXRfaXZyc19tYXBw
aW5ncyhpb21tdS0+c2VnKVtyZXFfaWRdOwogICAgICAgICBpZiAoIGR0ZS0+
aXRfcm9vdCApCiAgICAgICAgIHsKICAgICAgICAgICAgIGR0ZS0+aW50X2N0
bCA9IElPTU1VX0RFVl9UQUJMRV9JTlRfQ09OVFJPTF9UUkFOU0xBVEVEOwpA
QCAtMTMwLDE3ICsxNzEsNzMgQEAgc3RhdGljIHZvaWQgYW1kX2lvbW11X3Nl
dHVwX2RvbWFpbl9kZXZpYwogICAgICAgICAgICAgZHRlLT5pID0gYXRzX2Vu
YWJsZWQ7CiAKICAgICAgICAgYW1kX2lvbW11X2ZsdXNoX2RldmljZShpb21t
dSwgcmVxX2lkKTsKKyAgICB9CisgICAgZWxzZSBpZiAoIGR0ZS0+cHRfcm9v
dCAhPSBtZm5feChwYWdlX3RvX21mbihoZC0+YXJjaC5hbWQucm9vdF90YWJs
ZSkpICkKKyAgICB7CisgICAgICAgIC8qCisgICAgICAgICAqIFN0cmljdGx5
IHNwZWFraW5nIGlmIHRoZSBkZXZpY2UgaXMgdGhlIG9ubHkgb25lIHdpdGgg
dGhpcyByZXF1ZXN0b3IKKyAgICAgICAgICogSUQsIGl0IGNvdWxkIGJlIGFs
bG93ZWQgdG8gYmUgcmUtYXNzaWduZWQgcmVnYXJkbGVzcyBvZiB1bml0eSBt
YXAKKyAgICAgICAgICogcHJlc2VuY2UuICBCdXQgbGV0J3MgZGVhbCB3aXRo
IHRoYXQgY2FzZSBvbmx5IGlmIGl0IGlzIGFjdHVhbGx5CisgICAgICAgICAq
IGZvdW5kIGluIHRoZSB3aWxkLgorICAgICAgICAgKi8KKyAgICAgICAgaWYg
KCByZXFfaWQgIT0gUENJX0JERjIoYnVzLCBkZXZmbikgJiYKKyAgICAgICAg
ICAgICAoc3JfZmxhZ3MgJiBTRVRfUk9PVF9XSVRIX1VOSVRZX01BUCkgKQor
ICAgICAgICAgICAgcmMgPSAtRU9QTk9UU1VQUDsKKyAgICAgICAgZWxzZQor
ICAgICAgICAgICAgcmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJs
ZSgKKyAgICAgICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkciho
ZC0+YXJjaC5hbWQucm9vdF90YWJsZSksCisgICAgICAgICAgICAgICAgICAg
ICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2guYW1kLnBhZ2luZ19tb2Rl
LCBzcl9mbGFncyk7CisgICAgICAgIGlmICggcmMgPCAwICkKKyAgICAgICAg
eworICAgICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUt
PmxvY2ssIGZsYWdzKTsKKyAgICAgICAgICAgIHJldHVybiByYzsKKyAgICAg
ICAgfQorICAgICAgICBpZiAoIHJjICYmCisgICAgICAgICAgICAgZG9tYWlu
ICE9IHBkZXYtPmRvbWFpbiAmJgorICAgICAgICAgICAgIC8qCisgICAgICAg
ICAgICAgICogQnkgbm9uLWF0b21pY2FsbHkgdXBkYXRpbmcgdGhlIERURSdz
IGRvbWFpbiBJRCBmaWVsZCBsYXN0LAorICAgICAgICAgICAgICAqIGR1cmlu
ZyBhIHNob3J0IHdpbmRvdyBpbiB0aW1lIFRMQiBlbnRyaWVzIHdpdGggdGhl
IG9sZCBkb21haW4KKyAgICAgICAgICAgICAgKiBJRCBidXQgdGhlIG5ldyBw
YWdlIHRhYmxlcyBtYXkgaGF2ZSBiZWVuIGluc2VydGVkLiAgVGhpcyBjb3Vs
ZAorICAgICAgICAgICAgICAqIGFmZmVjdCBJL08gb2Ygb3RoZXIgZGV2aWNl
cyB1c2luZyB0aGlzIHNhbWUgKG9sZCkgZG9tYWluIElELgorICAgICAgICAg
ICAgICAqIFN1Y2ggdXBkYXRpbmcgdGhlcmVmb3JlIGlzIG5vdCBhIHByb2Js
ZW0gaWYgdGhpcyB3YXMgdGhlIG9ubHkKKyAgICAgICAgICAgICAgKiBkZXZp
Y2UgYXNzb2NpYXRlZCB3aXRoIHRoZSBvbGQgZG9tYWluIElELiAgRGl2ZXJ0
aW5nIEkvTyBvZiBhbnkKKyAgICAgICAgICAgICAgKiBvZiBhIGR5aW5nIGRv
bWFpbidzIGRldmljZXMgdG8gdGhlIHF1YXJhbnRpbmUgcGFnZSB0YWJsZXMg
aXMKKyAgICAgICAgICAgICAgKiBpbnRlbmRlZCBhbnl3YXkuCisgICAgICAg
ICAgICAgICovCisgICAgICAgICAgICAgIXBkZXYtPmRvbWFpbi0+aXNfZHlp
bmcgJiYKKyAgICAgICAgICAgICAoYW55X3BkZXZfYmVoaW5kX2lvbW11KHBk
ZXYtPmRvbWFpbiwgcGRldiwgaW9tbXUpIHx8CisgICAgICAgICAgICAgIHBk
ZXYtPnBoYW50b21fc3RyaWRlKSApCisgICAgICAgICAgICBwcmludGsoIiAl
cHA6IHJlYXNzaWdubWVudCBtYXkgY2F1c2UgJXBkIGRhdGEgY29ycnVwdGlv
blxuIiwKKyAgICAgICAgICAgICAgICAgICAmUENJX1NCREYzKHBkZXYtPnNl
ZywgYnVzLCBkZXZmbiksIHBkZXYtPmRvbWFpbik7CisKKyAgICAgICAgLyoK
KyAgICAgICAgICogQ2hlY2sgcmVtYWluaW5nIHNldHRpbmdzIGFyZSBzdGls
bCBpbiBwbGFjZSBmcm9tIGFuIGVhcmxpZXIgY2FsbAorICAgICAgICAgKiBo
ZXJlLiBUaGV5J3JlIGFsbCBpbmRlcGVuZGVudCBvZiB0aGUgZG9tYWluLCBz
byBzaG91bGQgbm90IGhhdmUKKyAgICAgICAgICogY2hhbmdlZC4KKyAgICAg
ICAgICovCisgICAgICAgIGlmICggZHRlLT5pdF9yb290ICkKKyAgICAgICAg
ICAgIEFTU0VSVChkdGUtPmludF9jdGwgPT0gSU9NTVVfREVWX1RBQkxFX0lO
VF9DT05UUk9MX1RSQU5TTEFURUQpOworICAgICAgICBBU1NFUlQoZHRlLT5p
diA9PSBpb21tdV9pbnRyZW1hcCk7CisgICAgICAgIEFTU0VSVChkdGUtPmV4
ID09IGl2cnNfZGV2LT5kdGVfYWxsb3dfZXhjbHVzaW9uKTsKKyAgICAgICAg
QVNTRVJUKGR0ZS0+c3lzX21ndCA9PSBNQVNLX0VYVFIoaXZyc19kZXYtPmRl
dmljZV9mbGFncywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgQUNQSV9JVkhEX1NZU1RFTV9NR01UKSk7CiAKLSAgICAgICAg
QU1EX0lPTU1VX0RFQlVHKCJTZXR1cCBJL08gcGFnZSB0YWJsZTogZGV2aWNl
IGlkID0gJSN4LCB0eXBlID0gJSN4LCAiCi0gICAgICAgICAgICAgICAgICAg
ICAgICAicm9vdCB0YWJsZSA9ICUjIlBSSXg2NCIsICIKLSAgICAgICAgICAg
ICAgICAgICAgICAgICJkb21haW4gPSAlZCwgcGFnaW5nIG1vZGUgPSAlZFxu
IiwKLSAgICAgICAgICAgICAgICAgICAgICAgIHJlcV9pZCwgcGRldi0+dHlw
ZSwKLSAgICAgICAgICAgICAgICAgICAgICAgIHBhZ2VfdG9fbWFkZHIoaGQt
PmFyY2guYW1kLnJvb3RfdGFibGUpLAotICAgICAgICAgICAgICAgICAgICAg
ICAgZG9tYWluLT5kb21haW5faWQsIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9k
ZSk7CisgICAgICAgIGlmICggcGNpX2F0c19kZXZpY2UoaW9tbXUtPnNlZywg
YnVzLCBwZGV2LT5kZXZmbikgJiYKKyAgICAgICAgICAgICBpb21tdV9oYXNf
Y2FwKGlvbW11LCBQQ0lfQ0FQX0lPVExCX1NISUZUKSApCisgICAgICAgICAg
ICBBU1NFUlQoZHRlLT5pID09IGF0c19lbmFibGVkKTsKKworICAgICAgICBh
bWRfaW9tbXVfZmx1c2hfZGV2aWNlKGlvbW11LCByZXFfaWQpOwogICAgIH0K
IAogICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmlvbW11LT5sb2NrLCBm
bGFncyk7CiAKKyAgICBBTURfSU9NTVVfREVCVUcoIlNldHVwIEkvTyBwYWdl
IHRhYmxlOiBkZXZpY2UgaWQgPSAlI3gsIHR5cGUgPSAlI3gsICIKKyAgICAg
ICAgICAgICAgICAgICAgInJvb3QgdGFibGUgPSAlIyJQUkl4NjQiLCAiCisg
ICAgICAgICAgICAgICAgICAgICJkb21haW4gPSAlZCwgcGFnaW5nIG1vZGUg
PSAlZFxuIiwKKyAgICAgICAgICAgICAgICAgICAgcmVxX2lkLCBwZGV2LT50
eXBlLAorICAgICAgICAgICAgICAgICAgICBwYWdlX3RvX21hZGRyKGhkLT5h
cmNoLmFtZC5yb290X3RhYmxlKSwKKyAgICAgICAgICAgICAgICAgICAgZG9t
YWluLT5kb21haW5faWQsIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSk7CisK
ICAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CiAKICAgICBpZiAoIHBj
aV9hdHNfZGV2aWNlKGlvbW11LT5zZWcsIGJ1cywgcGRldi0+ZGV2Zm4pICYm
CkBAIC0xNTEsNiArMjQ4LDggQEAgc3RhdGljIHZvaWQgYW1kX2lvbW11X3Nl
dHVwX2RvbWFpbl9kZXZpYwogCiAgICAgICAgIGFtZF9pb21tdV9mbHVzaF9p
b3RsYihkZXZmbiwgcGRldiwgSU5WX0lPTU1VX0FMTF9QQUdFU19BRERSRVNT
LCAwKTsKICAgICB9CisKKyAgICByZXR1cm4gMDsKIH0KIAogaW50IF9faW5p
dCBhY3BpX2l2cnNfaW5pdCh2b2lkKQpAQCAtMjE2LDE4ICszMTUsNiBAQCBp
bnQgYW1kX2lvbW11X2FsbG9jX3Jvb3Qoc3RydWN0IGRvbWFpbiAqCiAgICAg
cmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFsbG9j
YXRlX2RvbWFpbl9yZXNvdXJjZXMoc3RydWN0IGRvbWFpbiAqZCkKLXsKLSAg
ICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKLSAg
ICBpbnQgcmM7Ci0KLSAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdf
bG9jayk7Ci0gICAgcmMgPSBhbWRfaW9tbXVfYWxsb2Nfcm9vdChkKTsKLSAg
ICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKLQotICAg
IHJldHVybiByYzsKLX0KLQogaW50IF9fcmVhZF9tb3N0bHkgYW1kX2lvbW11
X21pbl9wYWdpbmdfbW9kZSA9IDE7CiAKIHN0YXRpYyBpbnQgYW1kX2lvbW11
X2RvbWFpbl9pbml0KHN0cnVjdCBkb21haW4gKmQpCkBAIC0zNDAsNyArNDI3
LDE1IEBAIHN0YXRpYyBpbnQgcmVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21h
aW4KICAgICAgICAgcmV0dXJuIC1FTk9ERVY7CiAgICAgfQogCi0gICAgYW1k
X2lvbW11X2Rpc2FibGVfZG9tYWluX2RldmljZShzb3VyY2UsIGlvbW11LCBk
ZXZmbiwgcGRldik7CisgICAgcmMgPSBhbWRfaW9tbXVfc2V0dXBfZG9tYWlu
X2RldmljZSh0YXJnZXQsIGlvbW11LCBkZXZmbiwgcGRldik7CisgICAgaWYg
KCByYyApCisgICAgICAgIHJldHVybiByYzsKKworICAgIGlmICggZGV2Zm4g
PT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWluICE9IHRhcmdldCApCisg
ICAgeworICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAm
dGFyZ2V0LT5wZGV2X2xpc3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSB0
YXJnZXQ7CisgICAgfQogCiAgICAgLyoKICAgICAgKiBJZiB0aGUgZGV2aWNl
IGJlbG9uZ3MgdG8gdGhlIGhhcmR3YXJlIGRvbWFpbiwgYW5kIGl0IGhhcyBh
IHVuaXR5IG1hcHBpbmcsCkBAIC0zNTYsMjYgKzQ1MSw5IEBAIHN0YXRpYyBp
bnQgcmVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4KICAgICAgICAgICAg
IHJldHVybiByYzsKICAgICB9CiAKLSAgICBpZiAoIGRldmZuID09IHBkZXYt
PmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gKQotICAgIHsKLSAg
ICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlzdCwgJmRvbV9pby0+
cGRldl9saXN0KTsKLSAgICAgICAgcGRldi0+ZG9tYWluID0gZG9tX2lvOwot
ICAgIH0KLQotICAgIHJjID0gYWxsb2NhdGVfZG9tYWluX3Jlc291cmNlcyh0
YXJnZXQpOwotICAgIGlmICggcmMgKQotICAgICAgICByZXR1cm4gcmM7Ci0K
LSAgICBhbWRfaW9tbXVfc2V0dXBfZG9tYWluX2RldmljZSh0YXJnZXQsIGlv
bW11LCBkZXZmbiwgcGRldik7CiAgICAgQU1EX0lPTU1VX0RFQlVHKCJSZS1h
c3NpZ24gJXBwIGZyb20gZG9tJWQgdG8gZG9tJWRcbiIsCiAgICAgICAgICAg
ICAgICAgICAgICZwZGV2LT5zYmRmLCBzb3VyY2UtPmRvbWFpbl9pZCwgdGFy
Z2V0LT5kb21haW5faWQpOwogCi0gICAgaWYgKCBkZXZmbiA9PSBwZGV2LT5k
ZXZmbiAmJiBwZGV2LT5kb21haW4gIT0gdGFyZ2V0ICkKLSAgICB7Ci0gICAg
ICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZ0YXJnZXQtPnBk
ZXZfbGlzdCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9IHRhcmdldDsKLSAg
ICB9Ci0KICAgICByZXR1cm4gMDsKIH0KIApAQCAtNDkwLDggKzU2OCw3IEBA
IHN0YXRpYyBpbnQgYW1kX2lvbW11X2FkZF9kZXZpY2UodTggZGV2Zm4KICAg
ICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZs
YWdzKTsKICAgICB9CiAKLSAgICBhbWRfaW9tbXVfc2V0dXBfZG9tYWluX2Rl
dmljZShwZGV2LT5kb21haW4sIGlvbW11LCBkZXZmbiwgcGRldik7Ci0gICAg
cmV0dXJuIDA7CisgICAgcmV0dXJuIGFtZF9pb21tdV9zZXR1cF9kb21haW5f
ZGV2aWNlKHBkZXYtPmRvbWFpbiwgaW9tbXUsIGRldmZuLCBwZGV2KTsKIH0K
IAogc3RhdGljIGludCBhbWRfaW9tbXVfcmVtb3ZlX2RldmljZSh1OCBkZXZm
biwgc3RydWN0IHBjaV9kZXYgKnBkZXYpCg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-07.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSSkKCkFycmFuZ2UgZm9yIGRvbWFpbiBJRCBhbmQg
cGFnZSB0YWJsZSByb290IHRvIGJlIHBhc3NlZCBhcm91bmQsIHRoZSBsYXR0
ZXIgaW4KcGFydGljdWxhciB0byBkb21haW5fcGdkX21hZGRyKCkgc3VjaCB0
aGF0IHRha2luZyBpdCBmcm9tIHRoZSBwZXItZG9tYWluCmZpZWxkcyBjYW4g
YmUgb3ZlcnJpZGRlbi4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVk
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5A
aW50ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2V4dGVybi5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9l
eHRlcm4uaApAQCAtODUsOSArODUsMTAgQEAgdm9pZCAqbWFwX3Z0ZF9kb21h
aW5fcGFnZSh1NjQgbWFkZHIpOwogdm9pZCB1bm1hcF92dGRfZG9tYWluX3Bh
Z2UoY29uc3Qgdm9pZCAqdmEpOwogaW50IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IHZ0ZF9pb21t
dSAqaW9tbXUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWlu
dDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2ln
bmVkIGludCBtb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgZG9taWRfdCBkb21pZCwK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHBnZF9t
YWRkciwgdW5zaWduZWQgaW50IG1vZGUpOwogaW50IGRvbWFpbl9jb250ZXh0
X3VubWFwX29uZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCB2dGRf
aW9tbXUgKmlvbW11LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
OCBidXMsIHU4IGRldmZuKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgdWludDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQp
OwogaW50IGludGVsX2lvbW11X2dldF9yZXNlcnZlZF9kZXZpY2VfbWVtb3J5
KGlvbW11X2dyZG1fdCAqZnVuYywgdm9pZCAqY3R4dCk7CiAKIHVuc2lnbmVk
IGludCBpb19hcGljX3JlYWRfcmVtYXBfcnRlKHVuc2lnbmVkIGludCBhcGlj
LCB1bnNpZ25lZCBpbnQgcmVnKTsKQEAgLTEwNSw3ICsxMDYsOCBAQCB2b2lk
IHBsYXRmb3JtX3F1aXJrc19pbml0KHZvaWQpOwogdm9pZCB2dGRfb3BzX3By
ZWFtYmxlX3F1aXJrKHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KTsKIHZvaWQg
dnRkX29wc19wb3N0YW1ibGVfcXVpcmsoc3RydWN0IHZ0ZF9pb21tdSAqaW9t
bXUpOwogaW50IF9fbXVzdF9jaGVjayBtZV93aWZpX3F1aXJrKHN0cnVjdCBk
b21haW4gKmRvbWFpbiwgdWludDhfdCBidXMsCi0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdWludDhfdCBkZXZmbiwgdW5zaWduZWQgaW50IG1v
ZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3Qg
ZGV2Zm4sIGRvbWlkX3QgZG9taWQsIHBhZGRyX3QgcGdkX21hZGRyLAorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBtb2Rl
KTsKIHZvaWQgcGNpX3Z0ZF9xdWlyayhjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
KTsKIHZvaWQgcXVpcmtfaW9tbXVfY2FwcyhzdHJ1Y3QgdnRkX2lvbW11ICpp
b21tdSk7CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmMKQEAgLTM1NSwxNSArMzU1LDE3IEBAIHN0YXRpYyB1NjQgYWRkcl90b19k
bWFfcGFnZV9tYWRkcihzdHJ1Y3QKICAgICByZXR1cm4gcHRlX21hZGRyOwog
fQogCi1zdGF0aWMgdWludDY0X3QgZG9tYWluX3BnZF9tYWRkcihzdHJ1Y3Qg
ZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgbnJfcHRfbGV2ZWxzKQorc3RhdGlj
IHBhZGRyX3QgZG9tYWluX3BnZF9tYWRkcihzdHJ1Y3QgZG9tYWluICpkLCBw
YWRkcl90IHBnZF9tYWRkciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdW5zaWduZWQgaW50IG5yX3B0X2xldmVscykKIHsKICAgICBzdHJ1
Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKLSAgICB1aW50
NjRfdCBwZ2RfbWFkZHI7CiAgICAgdW5zaWduZWQgaW50IGFnYXc7CiAKICAg
ICBBU1NFUlQoc3Bpbl9pc19sb2NrZWQoJmhkLT5hcmNoLm1hcHBpbmdfbG9j
aykpOwogCi0gICAgaWYgKCBpb21tdV91c2VfaGFwX3B0KGQpICkKKyAgICBp
ZiAoIHBnZF9tYWRkciApCisgICAgICAgIC8qIG5vdGhpbmcgKi87CisgICAg
ZWxzZSBpZiAoIGlvbW11X3VzZV9oYXBfcHQoZCkgKQogICAgIHsKICAgICAg
ICAgcGFnZXRhYmxlX3QgcGd0ID0gcDJtX2dldF9wYWdldGFibGUocDJtX2dl
dF9ob3N0cDJtKGQpKTsKIApAQCAtMTM3NiwxMiArMTM3OCwxMiBAQCBpbnQg
ZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgc3RydWN0IGRvbWFp
biAqZG9tYWluLAogICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAogICAg
IHVpbnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLCBjb25zdCBzdHJ1Y3QgcGNp
X2RldiAqcGRldiwKLSAgICB1bnNpZ25lZCBpbnQgbW9kZSkKKyAgICBkb21p
ZF90IGRvbWlkLCBwYWRkcl90IHBnZF9tYWRkciwgdW5zaWduZWQgaW50IG1v
ZGUpCiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9t
bXUoZG9tYWluKTsKICAgICBzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4
dCwgKmNvbnRleHRfZW50cmllcywgbGN0eHQ7CiAgICAgX191aW50MTI4X3Qg
b2xkOwotICAgIHU2NCBtYWRkciwgcGdkX21hZGRyOworICAgIHVpbnQ2NF90
IG1hZGRyOwogICAgIHVpbnQxNl90IHNlZyA9IGlvbW11LT5kcmhkLT5zZWdt
ZW50LCBwcmV2X2RpZCA9IDA7CiAgICAgc3RydWN0IGRvbWFpbiAqcHJldl9k
b20gPSBOVUxMOwogICAgIGludCByYywgcmV0OwpAQCAtMTQyMSwxMCArMTQy
MywxMiBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAg
fQogICAgIGVsc2UKICAgICB7CisgICAgICAgIHBhZGRyX3Qgcm9vdDsKKwog
ICAgICAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAK
LSAgICAgICAgcGdkX21hZGRyID0gZG9tYWluX3BnZF9tYWRkcihkb21haW4s
IGlvbW11LT5ucl9wdF9sZXZlbHMpOwotICAgICAgICBpZiAoICFwZ2RfbWFk
ZHIgKQorICAgICAgICByb290ID0gZG9tYWluX3BnZF9tYWRkcihkb21haW4s
IHBnZF9tYWRkciwgaW9tbXUtPm5yX3B0X2xldmVscyk7CisgICAgICAgIGlm
ICggIXJvb3QgKQogICAgICAgICB7CiAgICAgICAgICAgICBzcGluX3VubG9j
aygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKICAgICAgICAgICAgIHNwaW5f
dW5sb2NrKCZpb21tdS0+bG9jayk7CkBAIC0xNDM0LDcgKzE0MzgsNyBAQCBp
bnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgICAgICAgICBy
ZXR1cm4gLUVOT01FTTsKICAgICAgICAgfQogCi0gICAgICAgIGNvbnRleHRf
c2V0X2FkZHJlc3Nfcm9vdChsY3R4dCwgcGdkX21hZGRyKTsKKyAgICAgICAg
Y29udGV4dF9zZXRfYWRkcmVzc19yb290KGxjdHh0LCByb290KTsKICAgICAg
ICAgaWYgKCBhdHNfZW5hYmxlZCAmJiBlY2FwX2Rldl9pb3RsYihpb21tdS0+
ZWNhcCkgKQogICAgICAgICAgICAgY29udGV4dF9zZXRfdHJhbnNsYXRpb25f
dHlwZShsY3R4dCwgQ09OVEVYVF9UVF9ERVZfSU9UTEIpOwogICAgICAgICBl
bHNlCkBAIC0xNTUwLDE1ICsxNTU0LDIxIEBAIGludCBkb21haW5fY29udGV4
dF9tYXBwaW5nX29uZSgKICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29u
dGV4dF9lbnRyaWVzKTsKIAogICAgIGlmICggIXNlZyAmJiAhcmMgKQotICAg
ICAgICByYyA9IG1lX3dpZmlfcXVpcmsoZG9tYWluLCBidXMsIGRldmZuLCBt
b2RlKTsKKyAgICAgICAgcmMgPSBtZV93aWZpX3F1aXJrKGRvbWFpbiwgYnVz
LCBkZXZmbiwgZG9taWQsIHBnZF9tYWRkciwgbW9kZSk7CiAKICAgICBpZiAo
IHJjICkKICAgICB7CiAgICAgICAgIGlmICggIXByZXZfZG9tICkKLSAgICAg
ICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4s
IGlvbW11LCBidXMsIGRldmZuKTsKKyAgICAgICAgICAgIHJldCA9IGRvbWFp
bl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMsIGRldmZu
LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgZWxzZSBpZiAoIHByZXZf
ZG9tICE9IGRvbWFpbiApIC8qIEF2b2lkIGluZmluaXRlIHJlY3Vyc2lvbi4g
Ki8KKyAgICAgICAgeworICAgICAgICAgICAgaGQgPSBkb21faW9tbXUocHJl
dl9kb20pOwogICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFw
cGluZ19vbmUocHJldl9kb20sIGlvbW11LCBidXMsIGRldmZuLCBwZGV2LAor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ZG9tYWluLT5kb21haW5faWQsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBoZC0+YXJjaC52dGQucGdkX21hZGRyLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
bW9kZSAmIE1BUF9XSVRIX1JNUlIpIDwgMDsKKyAgICAgICAgfQogICAgICAg
ICBlbHNlCiAgICAgICAgICAgICByZXQgPSAxOwogCkBAIC0xNTgwLDYgKzE1
OTAsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3Ry
dWN0CiB7CiAgICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwogICAg
IGNvbnN0IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKKyAgICBwYWRk
cl90IHBnZF9tYWRkciA9IGRvbV9pb21tdShkb21haW4pLT5hcmNoLnZ0ZC5w
Z2RfbWFkZHI7CiAgICAgaW50IHJldCA9IDA7CiAgICAgdW5zaWduZWQgaW50
IGksIG1vZGUgPSAwOwogICAgIHVpbnQxNl90IHNlZyA9IHBkZXYtPnNlZywg
YmRmOwpAQCAtMTY0Myw3ICsxNjU0LDggQEAgc3RhdGljIGludCBkb21haW5f
Y29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICAgICAgcHJpbnRrKFZU
RFBSRUZJWCAiJXBkOlBDSWU6IG1hcCAlcHBcbiIsCiAgICAgICAgICAgICAg
ICAgICAgZG9tYWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbikpOwog
ICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21h
aW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBtb2RlKTsKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRldiwgZG9t
YWluLT5kb21haW5faWQsIHBnZF9tYWRkciwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgbW9kZSk7CiAgICAgICAgIGlmICgg
cmV0ID4gMCApCiAgICAgICAgICAgICByZXQgPSAwOwogICAgICAgICBpZiAo
ICFyZXQgJiYgZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgYXRzX2RldmljZShw
ZGV2LCBkcmhkKSA+IDAgKQpAQCAtMTY1Nyw3ICsxNjY5LDggQEAgc3RhdGlj
IGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICAg
ICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4p
KTsKIAogICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29u
ZShkb21haW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBtb2RlKTsK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRl
diwgZG9tYWluLT5kb21haW5faWQsIHBnZF9tYWRkciwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbW9kZSk7CiAgICAgICAg
IGlmICggcmV0IDwgMCApCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg
cHJldl9wcmVzZW50ID0gcmV0OwpAQCAtMTY4NSw3ICsxNjk4LDggQEAgc3Rh
dGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAg
ICAgKi8KICAgICAgICAgaWYgKCByZXQgPj0gMCApCiAgICAgICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQt
PmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgTlVMTCwgbW9kZSk7CisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBkb21h
aW4tPmRvbWFpbl9pZCwgcGdkX21hZGRyLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgbW9kZSk7CiAKICAgICAgICAg
LyoKICAgICAgICAgICogRGV2aWNlcyBiZWhpbmQgUENJZS10by1QQ0kvUENJ
eCBicmlkZ2UgbWF5IGdlbmVyYXRlIGRpZmZlcmVudApAQCAtMTcwMCw3ICsx
NzE0LDggQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0
cnVjdAogICAgICAgICBpZiAoICFyZXQgJiYgcGRldl90eXBlKHNlZywgYnVz
LCBkZXZmbikgPT0gREVWX1RZUEVfUENJZTJQQ0lfQlJJREdFICYmCiAgICAg
ICAgICAgICAgKHNlY2J1cyAhPSBwZGV2LT5idXMgfHwgcGRldi0+ZGV2Zm4g
IT0gMCkgKQogICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFw
cGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgc2VjYnVzLCAwLAotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVM
TCwgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBOVUxMLCBkb21haW4tPmRvbWFpbl9pZCwgcGdkX21hZGRy
LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgbW9kZSk7CiAKICAgICAgICAgaWYgKCByZXQgKQogICAgICAgICB7CkBA
IC0xNzI4LDcgKzE3NDMsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0
X21hcHBpbmcoc3RydWN0CiBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KAogICAgIHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICBzdHJ1Y3QgdnRk
X2lvbW11ICppb21tdSwKLSAgICB1OCBidXMsIHU4IGRldmZuKQorICAgIHVp
bnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLCBkb21pZF90IGRvbWlkKQogewog
ICAgIHN0cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LCAqY29udGV4dF9l
bnRyaWVzOwogICAgIHU2NCBtYWRkcjsKQEAgLTE3ODYsNyArMTgwMSw3IEBA
IGludCBkb21haW5fY29udGV4dF91bm1hcF9vbmUoCiAgICAgdW5tYXBfdnRk
X2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7CiAKICAgICBpZiAoICFp
b21tdS0+ZHJoZC0+c2VnbWVudCAmJiAhcmMgKQotICAgICAgICByYyA9IG1l
X3dpZmlfcXVpcmsoZG9tYWluLCBidXMsIGRldmZuLCBVTk1BUF9NRV9QSEFO
VE9NX0ZVTkMpOworICAgICAgICByYyA9IG1lX3dpZmlfcXVpcmsoZG9tYWlu
LCBidXMsIGRldmZuLCBkb21pZCwgMCwgVU5NQVBfTUVfUEhBTlRPTV9GVU5D
KTsKIAogICAgIGlmICggcmMgJiYgIWlzX2hhcmR3YXJlX2RvbWFpbihkb21h
aW4pICYmIGRvbWFpbiAhPSBkb21faW8gKQogICAgIHsKQEAgLTE4MzcsNyAr
MTg1Miw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3Ry
dWN0IGQKICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAgICAg
ICBwcmludGsoVlREUFJFRklYICIlcGQ6UENJZTogdW5tYXAgJXBwXG4iLAog
ICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1
cywgZGV2Zm4pKTsKLSAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5t
YXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOworICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwg
YnVzLCBkZXZmbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgaWYgKCAhcmV0
ICYmIGRldmZuID09IHBkZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRldiwg
ZHJoZCkgPiAwICkKICAgICAgICAgICAgIGRpc2FibGVfYXRzX2RldmljZShw
ZGV2KTsKIApAQCAtMTg0Nyw3ICsxODYzLDggQEAgc3RhdGljIGludCBkb21h
aW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZAogICAgICAgICBpZiAoIGlvbW11
X2RlYnVnICkKICAgICAgICAgICAgIHByaW50ayhWVERQUkVGSVggIiVwZDpQ
Q0k6IHVubWFwICVwcFxuIiwKICAgICAgICAgICAgICAgICAgICBkb21haW4s
ICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7Ci0gICAgICAgIHJldCA9
IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMs
IGRldmZuKTsKKyAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBf
b25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4sCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7
CiAgICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIGJyZWFrOwogCkBA
IC0xODczLDEyICsxODkwLDE1IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfdW5tYXAoc3RydWN0IGQKICAgICAgICAgLyogUENJZSB0byBQQ0kvUENJ
eCBicmlkZ2UgKi8KICAgICAgICAgaWYgKCBwZGV2X3R5cGUoc2VnLCB0bXBf
YnVzLCB0bXBfZGV2Zm4pID09IERFVl9UWVBFX1BDSWUyUENJX0JSSURHRSAp
CiAgICAgICAgIHsKLSAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0
X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4p
OworICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KGRvbWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRv
bWFpbl9pZCk7CiAgICAgICAgICAgICBpZiAoICFyZXQgKQotICAgICAgICAg
ICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4s
IGlvbW11LCBzZWNidXMsIDApOworICAgICAgICAgICAgICAgIHJldCA9IGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBzZWNidXMs
IDAsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgfQogICAgICAg
ICBlbHNlIC8qIExlZ2FjeSBQQ0kgYnJpZGdlICovCi0gICAgICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwg
dG1wX2J1cywgdG1wX2RldmZuKTsKKyAgICAgICAgICAgIHJldCA9IGRvbWFp
bl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0
bXBfZGV2Zm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOwogCiAgICAgICAgIGJyZWFr
OwogCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xdWlya3Mu
YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvcXVpcmtzLmMK
QEAgLTM0NSw2ICszNDUsOCBAQCB2b2lkIF9faW5pdCBwbGF0Zm9ybV9xdWly
a3NfaW5pdCh2b2lkKQogCiBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBtYXBf
bWVfcGhhbnRvbV9mdW5jdGlvbihzdHJ1Y3QgZG9tYWluICpkb21haW4sCiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICB1bnNpZ25lZCBpbnQgZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZG9taWRfdCBkb21pZCwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBh
ZGRyX3QgcGdkX21hZGRyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG1vZGUpCiB7CiAg
ICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwpAQCAtMzU4LDE2ICsz
NjAsMTcgQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgbWFwX21lX3BoYW50
b21fZgogICAgIC8qIG1hcCBvciB1bm1hcCBNRSBwaGFudG9tIGZ1bmN0aW9u
ICovCiAgICAgaWYgKCAhKG1vZGUgJiBVTk1BUF9NRV9QSEFOVE9NX0ZVTkMp
ICkKICAgICAgICAgcmMgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShk
b21haW4sIGRyaGQtPmlvbW11LCAwLAotICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpLCBOVUxMLCBt
b2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBQQ0lfREVWRk4oZGV2LCA3KSwgTlVMTCwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBkb21pZCwgcGdkX21hZGRyLCBtb2Rl
KTsKICAgICBlbHNlCiAgICAgICAgIHJjID0gZG9tYWluX2NvbnRleHRfdW5t
YXBfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIDAsCi0gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpKTsK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJX0RF
VkZOKGRldiwgNyksIGRvbWlkKTsKIAogICAgIHJldHVybiByYzsKIH0KIAog
aW50IG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLCB1aW50
OF90IGJ1cywgdWludDhfdCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgIHVu
c2lnbmVkIGludCBtb2RlKQorICAgICAgICAgICAgICAgICAgZG9taWRfdCBk
b21pZCwgcGFkZHJfdCBwZ2RfbWFkZHIsIHVuc2lnbmVkIGludCBtb2RlKQog
ewogICAgIHUzMiBpZDsKICAgICBpbnQgcmMgPSAwOwpAQCAtMzkxLDcgKzM5
NCw3IEBAIGludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFp
biwKICAgICAgICAgICAgIGNhc2UgMHg0MjNiODA4NjoKICAgICAgICAgICAg
IGNhc2UgMHg0MjNjODA4NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjNkODA4
NjoKLSAgICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0
aW9uKGRvbWFpbiwgMywgbW9kZSk7CisgICAgICAgICAgICAgICAgcmMgPSBt
YXBfbWVfcGhhbnRvbV9mdW5jdGlvbihkb21haW4sIDMsIGRvbWlkLCBwZ2Rf
bWFkZHIsIG1vZGUpOwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAg
ICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICBicmVhazsKQEAgLTQx
Nyw3ICs0MjAsNyBAQCBpbnQgbWVfd2lmaV9xdWlyayhzdHJ1Y3QgZG9tYWlu
ICpkb21haW4sCiAgICAgICAgICAgICBjYXNlIDB4NDIzODgwODY6ICAgICAg
ICAvKiBQdW1hIFBlYWsgKi8KICAgICAgICAgICAgIGNhc2UgMHg0MjJiODA4
NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjJjODA4NjoKLSAgICAgICAgICAg
ICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMjIs
IG1vZGUpOworICAgICAgICAgICAgICAgIHJjID0gbWFwX21lX3BoYW50b21f
ZnVuY3Rpb24oZG9tYWluLCAyMiwgZG9taWQsIHBnZF9tYWRkciwgbW9kZSk7
CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0
OgogICAgICAgICAgICAgICAgIGJyZWFrOwo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-08.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSUkpCgpSZXBsYWNlIHRoZSBwYXNzaW5nIG9mIHN0
cnVjdCBkb21haW4gKiBieSBkb21pZF90IGluIHByZXBhcmF0aW9uIG9mCnBl
ci1kZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBhbHNvIHJlcXVpcmlu
ZyBwZXItZGV2aWNlIHBzZXVkbwpkb21haW4gSURzLCB3aGljaCBhcmVuJ3Qg
Z29pbmcgdG8gYmUgYXNzb2NpYXRlZCB3aXRoIGFueSBzdHJ1Y3QgZG9tYWlu
Cmluc3RhbmNlcy4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkIChl
eGNlcHQgZm9yIHNsaWdodGx5IGFkanVzdGVkIGxvZyBtZXNzYWdlCnRleHQp
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNv
bT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKQEAgLTU5LDggKzU5LDggQEAgc3RhdGljIHN0cnVjdCB0YXNrbGV0
IHZ0ZF9mYXVsdF90YXNrbGV0Owogc3RhdGljIGludCBzZXR1cF9od2RvbV9k
ZXZpY2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICopOwogc3RhdGljIHZv
aWQgc2V0dXBfaHdkb21fcm1ycihzdHJ1Y3QgZG9tYWluICpkKTsKIAotc3Rh
dGljIGludCBkb21haW5faW9tbXVfZG9taWQoc3RydWN0IGRvbWFpbiAqZCwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQorc3RhdGljIGludCBnZXRfaW9tbXVfZGlkKGRvbWlkX3Qg
ZG9taWQsIGNvbnN0IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAorICAgICAg
ICAgICAgICAgICAgICAgICAgIGJvb2wgd2FybikKIHsKICAgICB1bnNpZ25l
ZCBsb25nIG5yX2RvbSwgaTsKIApAQCAtNjgsMTYgKzY4LDE2IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2lvbW11X2RvbWlkKHN0cnVjdCBkb20KICAgICBpID0g
ZmluZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsK
ICAgICB3aGlsZSAoIGkgPCBucl9kb20gKQogICAgIHsKLSAgICAgICAgaWYg
KCBpb21tdS0+ZG9taWRfbWFwW2ldID09IGQtPmRvbWFpbl9pZCApCisgICAg
ICAgIGlmICggaW9tbXUtPmRvbWlkX21hcFtpXSA9PSBkb21pZCApCiAgICAg
ICAgICAgICByZXR1cm4gaTsKIAogICAgICAgICBpID0gZmluZF9uZXh0X2Jp
dChpb21tdS0+ZG9taWRfYml0bWFwLCBucl9kb20sIGkrMSk7CiAgICAgfQog
Ci0gICAgaWYgKCAhZC0+aXNfZHlpbmcgKQorICAgIGlmICggd2FybiApCiAg
ICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsCi0gICAgICAg
ICAgICAgICAgIkNhbm5vdCBnZXQgdmFsaWQgaW9tbXUgJXUgZG9taWQ6ICVw
ZFxuIiwKLSAgICAgICAgICAgICAgICBpb21tdS0+aW5kZXgsIGQpOworICAg
ICAgICAgICAgICAgICJObyB2YWxpZCBpb21tdSAldSBkb21pZCBmb3IgRG9t
JWRcbiIsCisgICAgICAgICAgICAgICAgaW9tbXUtPmluZGV4LCBkb21pZCk7
CiAKICAgICByZXR1cm4gLTE7CiB9CkBAIC04NSw4ICs4NSw3IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2lvbW11X2RvbWlkKHN0cnVjdCBkb20KICNkZWZpbmUg
RElEX0ZJRUxEX1dJRFRIIDE2CiAjZGVmaW5lIERJRF9ISUdIX09GRlNFVCA4
CiBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9pZChzdHJ1Y3QgY29u
dGV4dF9lbnRyeSAqY29udGV4dCwKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHN0cnVjdCBkb21haW4gKmQsCi0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlkX3QgZG9taWQs
IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQogewogICAgIHVuc2lnbmVkIGxv
bmcgbnJfZG9tLCBpOwogICAgIGludCBmb3VuZCA9IDA7CkBAIC05Nyw3ICs5
Niw3IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVj
dAogICAgIGkgPSBmaW5kX2ZpcnN0X2JpdChpb21tdS0+ZG9taWRfYml0bWFw
LCBucl9kb20pOwogICAgIHdoaWxlICggaSA8IG5yX2RvbSApCiAgICAgewot
ICAgICAgICBpZiAoIGlvbW11LT5kb21pZF9tYXBbaV0gPT0gZC0+ZG9tYWlu
X2lkICkKKyAgICAgICAgaWYgKCBpb21tdS0+ZG9taWRfbWFwW2ldID09IGRv
bWlkICkKICAgICAgICAgewogICAgICAgICAgICAgZm91bmQgPSAxOwogICAg
ICAgICAgICAgYnJlYWs7CkBAIC0xMTMsNyArMTEyLDcgQEAgc3RhdGljIGlu
dCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0CiAgICAgICAgICAgICBk
cHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiSU9NTVU6IG5vIGZyZWUg
ZG9tYWluIGlkc1xuIik7CiAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsK
ICAgICAgICAgfQotICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0gZC0+
ZG9tYWluX2lkOworICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0gZG9t
aWQ7CiAgICAgfQogCiAgICAgc2V0X2JpdChpLCBpb21tdS0+ZG9taWRfYml0
bWFwKTsKQEAgLTEyMiw5ICsxMjEsOSBAQCBzdGF0aWMgaW50IGNvbnRleHRf
c2V0X2RvbWFpbl9pZChzdHJ1Y3QKICAgICByZXR1cm4gMDsKIH0KIAotc3Rh
dGljIHZvaWQgY2xlYW51cF9kb21pZF9tYXAoc3RydWN0IGRvbWFpbiAqZG9t
YWluLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKK3N0YXRpYyB2b2lkIGNs
ZWFudXBfZG9taWRfbWFwKGRvbWlkX3QgZG9taWQsIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQogewotICAgIGludCBpb21tdV9kb21pZCA9IGRvbWFpbl9p
b21tdV9kb21pZChkb21haW4sIGlvbW11KTsKKyAgICBpbnQgaW9tbXVfZG9t
aWQgPSBnZXRfaW9tbXVfZGlkKGRvbWlkLCBpb21tdSwgZmFsc2UpOwogCiAg
ICAgaWYgKCBpb21tdV9kb21pZCA+PSAwICkKICAgICB7CkBAIC0xODAsNyAr
MTc5LDcgQEAgc3RhdGljIHZvaWQgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAo
c3RydQogICAgIGlmICggIWZvdW5kICkKICAgICB7CiAgICAgICAgIGNsZWFy
X2JpdChpb21tdS0+aW5kZXgsICZkb21faW9tbXUoZCktPmFyY2gudnRkLmlv
bW11X2JpdG1hcCk7Ci0gICAgICAgIGNsZWFudXBfZG9taWRfbWFwKGQsIGlv
bW11KTsKKyAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZC0+ZG9tYWluX2lk
LCBpb21tdSk7CiAgICAgfQogfQogCkBAIC02ODcsNyArNjg2LDcgQEAgc3Rh
dGljIGludCBfX211c3RfY2hlY2sgaW9tbXVfZmx1c2hfaW90bAogICAgICAg
ICAgICAgY29udGludWU7CiAKICAgICAgICAgZmx1c2hfZGV2X2lvdGxiID0g
ISFmaW5kX2F0c19kZXZfZHJoZChpb21tdSk7Ci0gICAgICAgIGlvbW11X2Rv
bWlkPSBkb21haW5faW9tbXVfZG9taWQoZCwgaW9tbXUpOworICAgICAgICBp
b21tdV9kb21pZCA9IGdldF9pb21tdV9kaWQoZC0+ZG9tYWluX2lkLCBpb21t
dSwgIWQtPmlzX2R5aW5nKTsKICAgICAgICAgaWYgKCBpb21tdV9kb21pZCA9
PSAtMSApCiAgICAgICAgICAgICBjb250aW51ZTsKIApAQCAtMTQ0Nyw3ICsx
NDQ2LDcgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAg
ICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKICAg
ICB9CiAKLSAgICBpZiAoIGNvbnRleHRfc2V0X2RvbWFpbl9pZCgmbGN0eHQs
IGRvbWFpbiwgaW9tbXUpICkKKyAgICBpZiAoIGNvbnRleHRfc2V0X2RvbWFp
bl9pZCgmbGN0eHQsIGRvbWlkLCBpb21tdSkgKQogICAgIHsKICAgICB1bmxv
Y2s6CiAgICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7CkBAIC0x
NzY4LDcgKzE3NjcsNyBAQCBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KAogICAgIGNvbnRleHRfY2xlYXJfZW50cnkoKmNvbnRleHQpOwogICAgIGlv
bW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6ZW9mKHN0cnVjdCBjb250ZXh0
X2VudHJ5KSk7CiAKLSAgICBpb21tdV9kb21pZD0gZG9tYWluX2lvbW11X2Rv
bWlkKGRvbWFpbiwgaW9tbXUpOworICAgIGlvbW11X2RvbWlkID0gZ2V0X2lv
bW11X2RpZChkb21pZCwgaW9tbXUsICFkb21haW4tPmlzX2R5aW5nKTsKICAg
ICBpZiAoIGlvbW11X2RvbWlkID09IC0xICkKICAgICB7CiAgICAgICAgIHNw
aW5fdW5sb2NrKCZpb21tdS0+bG9jayk7CkBAIC0xOTM4LDcgKzE5MzcsNyBA
QCBzdGF0aWMgdm9pZCBpb21tdV9kb21haW5fdGVhcmRvd24oc3RydWN0CiAg
ICAgQVNTRVJUKCFoZC0+YXJjaC52dGQucGdkX21hZGRyKTsKIAogICAgIGZv
cl9lYWNoX2RyaGRfdW5pdCAoIGRyaGQgKQotICAgICAgICBjbGVhbnVwX2Rv
bWlkX21hcChkLCBkcmhkLT5pb21tdSk7CisgICAgICAgIGNsZWFudXBfZG9t
aWRfbWFwKGQtPmRvbWFpbl9pZCwgZHJoZC0+aW9tbXUpOwogfQogCiBzdGF0
aWMgaW50IF9fbXVzdF9jaGVjayBpbnRlbF9pb21tdV9tYXBfcGFnZShzdHJ1
Y3QgZG9tYWluICpkLCBkZm5fdCBkZm4sCg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-09.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IG1haW50YWluIGEgcGVyLWRldmljZSBwc2V1ZG8gZG9t
YWluIElECgpJbiBvcmRlciB0byBzdWJzZXF1ZW50bHkgZW5hYmxlIHBlci1k
ZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcywgd2UnbGwKbmVlZCBkb21h
aW4tSUQtbGlrZSBpZGVudGlmaWVycyB0byBiZSBpbnNlcnRlZCBpbiB0aGUg
cmVzcGVjdGl2ZSBkZXZpY2UKKEFNRCkgb3IgY29udGV4dCAoSW50ZWwpIHRh
YmxlIGVudHJpZXMgYWxvbmdzaWRlIHRoZSBwZXItZGV2aWNlIHBhZ2UKdGFi
bGUgcm9vdCBhZGRyZXNzZXMuCgpNYWtlIHVzZSBvZiAicmVhbCIgZG9tYWlu
IElEcyBvY2N1cHlpbmcgb25seSBoYWxmIG9mIHRoZSB2YWx1ZSByYW5nZQpj
b3ZlcmFibGUgYnkgZG9taWRfdC4KCk5vdGUgdGhhdCBpbiBWVC1kJ3MgaW9t
bXVfYWxsb2MoKSBJIGRpZG4ndCB3YW50IHRvIGludHJvZHVjZSBuZXcgbWVt
b3J5CmxlYWtzIGluIGNhc2Ugb2YgZXJyb3IsIGJ1dCBleGlzdGluZyBvbmVz
IGRvbid0IGdldCBwbHVnZ2VkIC0gdGhhdCdsbCBiZQp0aGUgc3ViamVjdCBv
ZiBhIGxhdGVyIGNoYW5nZS4KClRoZSBWVC1kIGNoYW5nZXMgYXJlIHNsaWdo
dGx5IGFzeW1tZXRyaWMsIGJ1dCB0aGlzIHdheSB3ZSBjYW4gYXZvaWQKYXNz
aWduaW5nIHBzZXVkbyBkb21haW4gSURzIHRvIGRldmljZXMgd2hpY2ggd291
bGQgbmV2ZXIgYmUgbWFwcGVkIHdoaWxlCnN0aWxsIGF2b2lkaW5nIHRvIGFk
ZCBhIG5ldyBwYXJhbWV0ZXIgdG8gZG9tYWluX2NvbnRleHRfdW5tYXAoKS4K
ClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpS
ZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaW9tbXUuaAor
KysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKQEAgLTE0Miw2ICsx
NDIsMTAgQEAgaW50IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9k
ZXNjCiAgICAgICAgIGlvbW11X3ZjYWxsKG9wcywgc3luY19jYWNoZSwgYWRk
ciwgc2l6ZSk7ICAgICAgIFwKIH0pCiAKK3Vuc2lnbmVkIGxvbmcgKmlvbW11
X2luaXRfZG9taWQodm9pZCk7Citkb21pZF90IGlvbW11X2FsbG9jX2RvbWlk
KHVuc2lnbmVkIGxvbmcgKm1hcCk7Cit2b2lkIGlvbW11X2ZyZWVfZG9taWQo
ZG9taWRfdCBkb21pZCwgdW5zaWduZWQgbG9uZyAqbWFwKTsKKwogaW50IF9f
bXVzdF9jaGVjayBpb21tdV9mcmVlX3BndGFibGVzKHN0cnVjdCBkb21haW4g
KmQpOwogc3RydWN0IGRvbWFpbl9pb21tdTsKIHN0cnVjdCBwYWdlX2luZm8g
Kl9fbXVzdF9jaGVjayBpb21tdV9hbGxvY19wZ3RhYmxlKHN0cnVjdCBkb21h
aW5faW9tbXUgKmhkKTsKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2ku
aAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oCkBAIC0xNSw2ICsx
NSwxMiBAQAogCiBzdHJ1Y3QgYXJjaF9wY2lfZGV2IHsKICAgICB2bWFza190
IHVzZWRfdmVjdG9yczsKKyAgICAvKgorICAgICAqIFRoZXNlIGZpZWxkcyBh
cmUgKGRlKWluaXRpYWxpemVkIHVuZGVyIHBjaWRldnMtbG9jay4gT3RoZXIg
dXNlcyBvZgorICAgICAqIHRoZW0gZG9uJ3QgcmFjZSAoZGUpaW5pdGlhbGl6
YXRpb24gYW5kIGhlbmNlIGRvbid0IHN0cmljdGx5IG5lZWQgYW55CisgICAg
ICogbG9ja2luZy4KKyAgICAgKi8KKyAgICBkb21pZF90IHBzZXVkb19kb21p
ZDsKIH07CiAKIGludCBwY2lfY29uZl93cml0ZV9pbnRlcmNlcHQodW5zaWdu
ZWQgaW50IHNlZywgdW5zaWduZWQgaW50IGJkZiwKLS0tIGEveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11LmgKKysrIGIveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvYW1kL2lvbW11LmgKQEAgLTk2LDYgKzk2LDcgQEAgc3Ry
dWN0IGFtZF9pb21tdSB7CiAgICAgc3RydWN0IHJpbmdfYnVmZmVyIGNtZF9i
dWZmZXI7CiAgICAgc3RydWN0IHJpbmdfYnVmZmVyIGV2ZW50X2xvZzsKICAg
ICBzdHJ1Y3QgcmluZ19idWZmZXIgcHByX2xvZzsKKyAgICB1bnNpZ25lZCBs
b25nICpkb21pZF9tYXA7CiAKICAgICBpbnQgZXhjbHVzaW9uX2VuYWJsZTsK
ICAgICBpbnQgZXhjbHVzaW9uX2FsbG93X2FsbDsKLS0tIGEveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2RldGVjdC5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9kZXRlY3QuYwpAQCAtMTgw
LDYgKzE4MCwxMSBAQCBpbnQgX19pbml0IGFtZF9pb21tdV9kZXRlY3Rfb25l
X2FjcGkoCiAgICAgaWYgKCBydCApCiAgICAgICAgIGdvdG8gb3V0OwogCisg
ICAgaW9tbXUtPmRvbWlkX21hcCA9IGlvbW11X2luaXRfZG9taWQoKTsKKyAg
ICBydCA9IC1FTk9NRU07CisgICAgaWYgKCAhaW9tbXUtPmRvbWlkX21hcCAp
CisgICAgICAgIGdvdG8gb3V0OworCiAgICAgcnQgPSBwY2lfcm9fZGV2aWNl
KGlvbW11LT5zZWcsIGJ1cywgUENJX0RFVkZOKGRldiwgZnVuYykpOwogICAg
IGlmICggcnQgKQogICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAiQ291bGQg
bm90IG1hcmsgY29uZmlnIHNwYWNlIG9mICVwcCByZWFkLW9ubHkgKCVkKVxu
IiwKQEAgLTE5MCw3ICsxOTUsMTAgQEAgaW50IF9faW5pdCBhbWRfaW9tbXVf
ZGV0ZWN0X29uZV9hY3BpKAogCiAgb3V0OgogICAgIGlmICggcnQgKQorICAg
IHsKKyAgICAgICAgeGZyZWUoaW9tbXUtPmRvbWlkX21hcCk7CiAgICAgICAg
IHhmcmVlKGlvbW11KTsKKyAgICB9CiAKICAgICByZXR1cm4gcnQ7CiB9Ci0t
LSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11
LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRf
aW9tbXUuYwpAQCAtNTA4LDYgKzUwOCw4IEBAIHN0YXRpYyBpbnQgYW1kX2lv
bW11X2FkZF9kZXZpY2UodTggZGV2Zm4KICAgICBzdHJ1Y3QgYW1kX2lvbW11
ICppb21tdTsKICAgICB1MTYgYmRmOwogICAgIHN0cnVjdCBpdnJzX21hcHBp
bmdzICppdnJzX21hcHBpbmdzOworICAgIGJvb2wgZnJlc2hfZG9taWQgPSBm
YWxzZTsKKyAgICBpbnQgcmV0OwogCiAgICAgaWYgKCAhcGRldi0+ZG9tYWlu
ICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CkBAIC01NjgsNyArNTcwLDIy
IEBAIHN0YXRpYyBpbnQgYW1kX2lvbW11X2FkZF9kZXZpY2UodTggZGV2Zm4K
ICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUtPmxvY2ss
IGZsYWdzKTsKICAgICB9CiAKLSAgICByZXR1cm4gYW1kX2lvbW11X3NldHVw
X2RvbWFpbl9kZXZpY2UocGRldi0+ZG9tYWluLCBpb21tdSwgZGV2Zm4sIHBk
ZXYpOworICAgIGlmICggaW9tbXVfcXVhcmFudGluZSAmJiBwZGV2LT5hcmNo
LnBzZXVkb19kb21pZCA9PSBET01JRF9JTlZBTElEICkKKyAgICB7CisgICAg
ICAgIHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID0gaW9tbXVfYWxsb2NfZG9t
aWQoaW9tbXUtPmRvbWlkX21hcCk7CisgICAgICAgIGlmICggcGRldi0+YXJj
aC5wc2V1ZG9fZG9taWQgPT0gRE9NSURfSU5WQUxJRCApCisgICAgICAgICAg
ICByZXR1cm4gLUVOT1NQQzsKKyAgICAgICAgZnJlc2hfZG9taWQgPSB0cnVl
OworICAgIH0KKworICAgIHJldCA9IGFtZF9pb21tdV9zZXR1cF9kb21haW5f
ZGV2aWNlKHBkZXYtPmRvbWFpbiwgaW9tbXUsIGRldmZuLCBwZGV2KTsKKyAg
ICBpZiAoIHJldCAmJiBmcmVzaF9kb21pZCApCisgICAgeworICAgICAgICBp
b21tdV9mcmVlX2RvbWlkKHBkZXYtPmFyY2gucHNldWRvX2RvbWlkLCBpb21t
dS0+ZG9taWRfbWFwKTsKKyAgICAgICAgcGRldi0+YXJjaC5wc2V1ZG9fZG9t
aWQgPSBET01JRF9JTlZBTElEOworICAgIH0KKworICAgIHJldHVybiByZXQ7
CiB9CiAKIHN0YXRpYyBpbnQgYW1kX2lvbW11X3JlbW92ZV9kZXZpY2UodTgg
ZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQpAQCAtNTkxLDYgKzYwOCw5
IEBAIHN0YXRpYyBpbnQgYW1kX2lvbW11X3JlbW92ZV9kZXZpY2UodTggZGUK
IAogICAgIGFtZF9pb21tdV9kaXNhYmxlX2RvbWFpbl9kZXZpY2UocGRldi0+
ZG9tYWluLCBpb21tdSwgZGV2Zm4sIHBkZXYpOwogCisgICAgaW9tbXVfZnJl
ZV9kb21pZChwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwgaW9tbXUtPmRvbWlk
X21hcCk7CisgICAgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBET01JRF9J
TlZBTElEOworCiAgICAgaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBp
bmdzKHBkZXYtPnNlZyk7CiAgICAgYmRmID0gUENJX0JERjIocGRldi0+YnVz
LCBkZXZmbik7CiAgICAgaWYgKCBhbWRfaW9tbXVfcGVyZGV2X2ludHJlbWFw
ICYmCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jCisrKyBi
L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jCkBAIC0zMjcsNiArMzI3
LDcgQEAgc3RhdGljIHN0cnVjdCBwY2lfZGV2ICphbGxvY19wZGV2KHN0cnVj
dAogICAgICooKHU4KikgJnBkZXYtPmJ1cykgPSBidXM7CiAgICAgKigodTgq
KSAmcGRldi0+ZGV2Zm4pID0gZGV2Zm47CiAgICAgcGRldi0+ZG9tYWluID0g
TlVMTDsKKyAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlEX0lO
VkFMSUQ7CiAgICAgSU5JVF9MSVNUX0hFQUQoJnBkZXYtPm1zaV9saXN0KTsK
IAogICAgIHBvcyA9IHBjaV9maW5kX2NhcF9vZmZzZXQocHNlZy0+bnIsIGJ1
cywgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksCkBAIC0xMjc2
LDggKzEyNzcsMTIgQEAgc3RhdGljIGludCBfZHVtcF9wY2lfZGV2aWNlcyhz
dHJ1Y3QgcGNpXwogCiAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIHBkZXYs
ICZwc2VnLT5hbGxkZXZzX2xpc3QsIGFsbGRldnNfbGlzdCApCiAgICAgewot
ICAgICAgICBwcmludGsoIiVwcCAtICVwZCAtIG5vZGUgJS0zZCAtIE1TSXMg
PCAiLAotICAgICAgICAgICAgICAgJnBkZXYtPnNiZGYsIHBkZXYtPmRvbWFp
biwKKyAgICAgICAgcHJpbnRrKCIlcHAgLSAiLCAmcGRldi0+c2JkZik7Cisg
ICAgICAgIGlmICggcGRldi0+ZG9tYWluID09IGRvbV9pbyApCisgICAgICAg
ICAgICBwcmludGsoIkRvbUlPOiV4IiwgcGRldi0+YXJjaC5wc2V1ZG9fZG9t
aWQpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBwcmludGsoIiVwZCIs
IHBkZXYtPmRvbWFpbik7CisgICAgICAgIHByaW50aygiIC0gbm9kZSAlLTNk
IC0gTVNJcyA8ICIsCiAgICAgICAgICAgICAgICAocGRldi0+bm9kZSAhPSBO
VU1BX05PX05PREUpID8gcGRldi0+bm9kZSA6IC0xKTsKICAgICAgICAgbGlz
dF9mb3JfZWFjaF9lbnRyeSAoIG1zaSwgJnBkZXYtPm1zaV9saXN0LCBsaXN0
ICkKICAgICAgICAgICAgICAgIHByaW50aygiJWQgIiwgbXNpLT5pcnEpOwot
LS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYworKysg
Yi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwpAQCAtMjIs
NiArMjIsNyBAQAogI2luY2x1ZGUgPHhlbi9zY2hlZC5oPgogI2luY2x1ZGUg
PHhlbi94bWFsbG9jLmg+CiAjaW5jbHVkZSA8eGVuL2RvbWFpbl9wYWdlLmg+
CisjaW5jbHVkZSA8eGVuL2Vyci5oPgogI2luY2x1ZGUgPHhlbi9pb2NhcC5o
PgogI2luY2x1ZGUgPHhlbi9pb21tdS5oPgogI2luY2x1ZGUgPHhlbi9udW1h
Lmg+CkBAIC0xMjA0LDcgKzEyMDUsNyBAQCBpbnQgX19pbml0IGlvbW11X2Fs
bG9jKHN0cnVjdCBhY3BpX2RyaGRfCiB7CiAgICAgc3RydWN0IHZ0ZF9pb21t
dSAqaW9tbXU7CiAgICAgdW5zaWduZWQgbG9uZyBzYWdhdywgbnJfZG9tOwot
ICAgIGludCBhZ2F3OworICAgIGludCBhZ2F3LCByYzsKIAogICAgIGlmICgg
bnJfaW9tbXVzID49IE1BWF9JT01NVVMgKQogICAgIHsKQEAgLTEyOTcsNyAr
MTI5OCwxNiBAQCBpbnQgX19pbml0IGlvbW11X2FsbG9jKHN0cnVjdCBhY3Bp
X2RyaGRfCiAgICAgaWYgKCAhaW9tbXUtPmRvbWlkX21hcCApCiAgICAgICAg
IHJldHVybiAtRU5PTUVNOwogCisgICAgaW9tbXUtPnBzZXVkb19kb21pZF9t
YXAgPSBpb21tdV9pbml0X2RvbWlkKCk7CisgICAgcmMgPSAtRU5PTUVNOwor
ICAgIGlmICggIWlvbW11LT5wc2V1ZG9fZG9taWRfbWFwICkKKyAgICAgICAg
Z290byBmcmVlOworCiAgICAgcmV0dXJuIDA7CisKKyBmcmVlOgorICAgIGlv
bW11X2ZyZWUoZHJoZCk7CisgICAgcmV0dXJuIHJjOwogfQogCiB2b2lkIF9f
aW5pdCBpb21tdV9mcmVlKHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZCkK
QEAgLTEzMjAsNiArMTMzMCw3IEBAIHZvaWQgX19pbml0IGlvbW11X2ZyZWUo
c3RydWN0IGFjcGlfZHJoZF8KIAogICAgIHhmcmVlKGlvbW11LT5kb21pZF9i
aXRtYXApOwogICAgIHhmcmVlKGlvbW11LT5kb21pZF9tYXApOworICAgIHhm
cmVlKGlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKIAogICAgIGlmICggaW9t
bXUtPm1zaS5pcnEgPj0gMCApCiAgICAgICAgIGRlc3Ryb3lfaXJxKGlvbW11
LT5tc2kuaXJxKTsKQEAgLTE1ODEsOCArMTU5Miw4IEBAIGludCBkb21haW5f
Y29udGV4dF9tYXBwaW5nX29uZSgKICAgICByZXR1cm4gcmMgPzogcGRldiAm
JiBwcmV2X2RvbTsKIH0KIAotc3RhdGljIGludCBkb21haW5fY29udGV4dF91
bm1hcChzdHJ1Y3QgZG9tYWluICpkLCB1aW50OF90IGRldmZuLAotICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcGNpX2RldiAqcGRl
dik7CitzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkb21h
aW5fY29udGV4dF91bm1hcCgKKyAgICBzdHJ1Y3QgZG9tYWluICpkLCB1aW50
OF90IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldik7CiAKIHN0YXRpYyBp
bnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkb21h
aW4sIHU4IGRldmZuLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQpAQCAtMTU5MCw2ICsxNjAxLDcg
QEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAog
ICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZDsKICAgICBjb25zdCBz
dHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CiAgICAgcGFkZHJfdCBwZ2Rf
bWFkZHIgPSBkb21faW9tbXUoZG9tYWluKS0+YXJjaC52dGQucGdkX21hZGRy
OworICAgIGRvbWlkX3Qgb3JpZ19kb21pZCA9IHBkZXYtPmFyY2gucHNldWRv
X2RvbWlkOwogICAgIGludCByZXQgPSAwOwogICAgIHVuc2lnbmVkIGludCBp
LCBtb2RlID0gMDsKICAgICB1aW50MTZfdCBzZWcgPSBwZGV2LT5zZWcsIGJk
ZjsKQEAgLTE2NDksNiArMTY2MSwxNCBAQCBzdGF0aWMgaW50IGRvbWFpbl9j
b250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgIGJyZWFrOwogCiAgICAg
Y2FzZSBERVZfVFlQRV9QQ0llX0VORFBPSU5UOgorICAgICAgICBpZiAoIGlv
bW11X3F1YXJhbnRpbmUgJiYgb3JpZ19kb21pZCA9PSBET01JRF9JTlZBTElE
ICkKKyAgICAgICAgeworICAgICAgICAgICAgcGRldi0+YXJjaC5wc2V1ZG9f
ZG9taWQgPQorICAgICAgICAgICAgICAgIGlvbW11X2FsbG9jX2RvbWlkKGRy
aGQtPmlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKKyAgICAgICAgICAgIGlm
ICggcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPT0gRE9NSURfSU5WQUxJRCAp
CisgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9TUEM7CisgICAgICAgIH0K
KwogICAgICAgICBpZiAoIGlvbW11X2RlYnVnICkKICAgICAgICAgICAgIHBy
aW50ayhWVERQUkVGSVggIiVwZDpQQ0llOiBtYXAgJXBwXG4iLAogICAgICAg
ICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2
Zm4pKTsKQEAgLTE2NjMsNiArMTY4MywxNCBAQCBzdGF0aWMgaW50IGRvbWFp
bl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgIGJyZWFrOwogCiAg
ICAgY2FzZSBERVZfVFlQRV9QQ0k6CisgICAgICAgIGlmICggaW9tbXVfcXVh
cmFudGluZSAmJiBvcmlnX2RvbWlkID09IERPTUlEX0lOVkFMSUQgKQorICAg
ICAgICB7CisgICAgICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9
CisgICAgICAgICAgICAgICAgaW9tbXVfYWxsb2NfZG9taWQoZHJoZC0+aW9t
bXUtPnBzZXVkb19kb21pZF9tYXApOworICAgICAgICAgICAgaWYgKCBwZGV2
LT5hcmNoLnBzZXVkb19kb21pZCA9PSBET01JRF9JTlZBTElEICkKKyAgICAg
ICAgICAgICAgICByZXR1cm4gLUVOT1NQQzsKKyAgICAgICAgfQorCiAgICAg
ICAgIGlmICggaW9tbXVfZGVidWcgKQogICAgICAgICAgICAgcHJpbnRrKFZU
RFBSRUZJWCAiJXBkOlBDSTogbWFwICVwcFxuIiwKICAgICAgICAgICAgICAg
ICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7CkBA
IC0xNzM2LDYgKzE3NjQsMTMgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4
dF9tYXBwaW5nKHN0cnVjdAogICAgIGlmICggIXJldCAmJiBkZXZmbiA9PSBw
ZGV2LT5kZXZmbiApCiAgICAgICAgIHBjaV92dGRfcXVpcmsocGRldik7CiAK
KyAgICBpZiAoIHJldCAmJiBkcmhkICYmIG9yaWdfZG9taWQgPT0gRE9NSURf
SU5WQUxJRCApCisgICAgeworICAgICAgICBpb21tdV9mcmVlX2RvbWlkKHBk
ZXYtPmFyY2gucHNldWRvX2RvbWlkLAorICAgICAgICAgICAgICAgICAgICAg
ICAgIGRyaGQtPmlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKKyAgICAgICAg
cGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBET01JRF9JTlZBTElEOworICAg
IH0KKwogICAgIHJldHVybiByZXQ7CiB9CiAKQEAgLTE4MTgsOCArMTg1Mywx
MCBAQCBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKAogICAgIHJldHVy
biByYzsKIH0KIAotc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1hcChz
dHJ1Y3QgZG9tYWluICpkb21haW4sIHU4IGRldmZuLAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldikKK3N0
YXRpYyBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRvbWFpbl9jb250
ZXh0X3VubWFwKAorICAgIHN0cnVjdCBkb21haW4gKmRvbWFpbiwKKyAgICB1
aW50OF90IGRldmZuLAorICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQogewog
ICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZDsKICAgICBzdHJ1Y3Qg
dnRkX2lvbW11ICppb21tdTsKQEAgLTE4MjksNyArMTg2Niw3IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3RydWN0IGQKIAogICAgIGRy
aGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CiAgICAg
aWYgKCAhZHJoZCApCi0gICAgICAgIHJldHVybiAtRU5PREVWOworICAgICAg
ICByZXR1cm4gRVJSX1BUUigtRU5PREVWKTsKICAgICBpb21tdSA9IGRyaGQt
PmlvbW11OwogCiAgICAgc3dpdGNoICggcGRldi0+dHlwZSApCkBAIC0xODM5
LDcgKzE4NzYsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X3VubWFw
KHN0cnVjdCBkCiAgICAgICAgICAgICBwcmludGsoVlREUFJFRklYICIlcGQ6
SG9zdGJyaWRnZTogc2tpcCAlcHAgdW5tYXBcbiIsCiAgICAgICAgICAgICAg
ICAgICAgZG9tYWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbikpOwog
ICAgICAgICBpZiAoICFpc19oYXJkd2FyZV9kb21haW4oZG9tYWluKSApCi0g
ICAgICAgICAgICByZXR1cm4gLUVQRVJNOworICAgICAgICAgICAgcmV0dXJu
IEVSUl9QVFIoLUVQRVJNKTsKICAgICAgICAgZ290byBvdXQ7CiAKICAgICBj
YXNlIERFVl9UWVBFX1BDSWVfQlJJREdFOgpAQCAtMTkxMiw3ICsxOTQ5LDcg
QEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZAog
ICAgICAgICBjaGVja19jbGVhbnVwX2RvbWlkX21hcChkb21haW4sIHBkZXYs
IGlvbW11KTsKIAogb3V0OgotICAgIHJldHVybiByZXQ7CisgICAgcmV0dXJu
IHJldCA/IEVSUl9QVFIocmV0KSA6IGRyaGQ7CiB9CiAKIHN0YXRpYyB2b2lk
IGlvbW11X2NsZWFyX3Jvb3RfcGd0YWJsZShzdHJ1Y3QgZG9tYWluICpkKQpA
QCAtMjEzNywxNiArMjE3NCwxNyBAQCBzdGF0aWMgaW50IGludGVsX2lvbW11
X2VuYWJsZV9kZXZpY2Uoc3RyCiAKIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVf
cmVtb3ZlX2RldmljZSh1OCBkZXZmbiwgc3RydWN0IHBjaV9kZXYgKnBkZXYp
CiB7CisgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwog
ICAgIHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKICAgICB1MTYgYmRm
OwotICAgIGludCByZXQsIGk7CisgICAgdW5zaWduZWQgaW50IGk7CiAKICAg
ICBpZiAoICFwZGV2LT5kb21haW4gKQogICAgICAgICByZXR1cm4gLUVJTlZB
TDsKIAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHBkZXYtPmRv
bWFpbiwgZGV2Zm4sIHBkZXYpOwotICAgIGlmICggcmV0ICkKLSAgICAgICAg
cmV0dXJuIHJldDsKKyAgICBkcmhkID0gZG9tYWluX2NvbnRleHRfdW5tYXAo
cGRldi0+ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgaWYgKCBJU19FUlIo
ZHJoZCkgKQorICAgICAgICByZXR1cm4gUFRSX0VSUihkcmhkKTsKIAogICAg
IGZvcl9lYWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKICAgICB7
CkBAIC0yMTYzLDYgKzIyMDEsMTMgQEAgc3RhdGljIGludCBpbnRlbF9pb21t
dV9yZW1vdmVfZGV2aWNlKHU4CiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgcm1yci0+ZW5kX2FkZHJlc3MsIDApOwogICAgIH0KIAorICAgIGlm
ICggZHJoZCApCisgICAgeworICAgICAgICBpb21tdV9mcmVlX2RvbWlkKHBk
ZXYtPmFyY2gucHNldWRvX2RvbWlkLAorICAgICAgICAgICAgICAgICAgICAg
ICAgIGRyaGQtPmlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKKyAgICAgICAg
cGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBET01JRF9JTlZBTElEOworICAg
IH0KKwogICAgIHJldHVybiAwOwogfQogCi0tLSBhL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3Z0ZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5oCkBAIC01MzUsNiArNTM1LDcgQEAgc3RydWN0
IHZ0ZF9pb21tdSB7CiAgICAgfSBmbHVzaDsKIAogICAgIHN0cnVjdCBsaXN0
X2hlYWQgYXRzX2RldmljZXM7CisgICAgdW5zaWduZWQgbG9uZyAqcHNldWRv
X2RvbWlkX21hcDsgLyogInBzZXVkbyIgZG9tYWluIGlkIGJpdG1hcCAqLwog
ICAgIHVuc2lnbmVkIGxvbmcgKmRvbWlkX2JpdG1hcDsgIC8qIGRvbWFpbiBp
ZCBiaXRtYXAgKi8KICAgICB1MTYgKmRvbWlkX21hcDsgICAgICAgICAgICAg
ICAvKiBkb21haW4gaWQgbWFwcGluZyBhcnJheSAqLwogICAgIHVpbnQzMl90
IHZlcnNpb247Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9p
b21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21t
dS5jCkBAIC0zODYsNiArMzg2LDUzIEBAIHZvaWQgX19od2RvbV9pbml0IGFy
Y2hfaW9tbXVfaHdkb21faW5pdCgKICAgICAgICAgcmV0dXJuOwogfQogCit1
bnNpZ25lZCBsb25nICpfX2luaXQgaW9tbXVfaW5pdF9kb21pZCh2b2lkKQor
eworICAgIGlmICggIWlvbW11X3F1YXJhbnRpbmUgKQorICAgICAgICByZXR1
cm4gWkVST19CTE9DS19QVFI7CisKKyAgICBCVUlMRF9CVUdfT04oRE9NSURf
TUFTSyAqIDJVID49IFVJTlQxNl9NQVgpOworCisgICAgcmV0dXJuIHh6YWxs
b2NfYXJyYXkodW5zaWduZWQgbG9uZywKKyAgICAgICAgICAgICAgICAgICAg
ICAgICBCSVRTX1RPX0xPTkdTKFVJTlQxNl9NQVggLSBET01JRF9NQVNLKSk7
Cit9CisKK2RvbWlkX3QgaW9tbXVfYWxsb2NfZG9taWQodW5zaWduZWQgbG9u
ZyAqbWFwKQoreworICAgIC8qCisgICAgICogVGhpcyBpcyB1c2VkIHVuaWZv
cm1seSBhY3Jvc3MgYWxsIElPTU1Vcywgc3VjaCB0aGF0IG9uIHR5cGljYWwK
KyAgICAgKiBzeXN0ZW1zIHdlIHdvdWxkbid0IHJlLXVzZSB0aGUgc2FtZSBJ
RCB2ZXJ5IHF1aWNrbHkgKHBlcmhhcHMgbmV2ZXIpLgorICAgICAqLworICAg
IHN0YXRpYyB1bnNpZ25lZCBpbnQgc3RhcnQ7CisgICAgdW5zaWduZWQgaW50
IGlkeCA9IGZpbmRfbmV4dF96ZXJvX2JpdChtYXAsIFVJTlQxNl9NQVggLSBE
T01JRF9NQVNLLCBzdGFydCk7CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2Nr
ZWQoKSk7CisKKyAgICBpZiAoIGlkeCA+PSBVSU5UMTZfTUFYIC0gRE9NSURf
TUFTSyApCisgICAgICAgIGlkeCA9IGZpbmRfZmlyc3RfemVyb19iaXQobWFw
LCBVSU5UMTZfTUFYIC0gRE9NSURfTUFTSyk7CisgICAgaWYgKCBpZHggPj0g
VUlOVDE2X01BWCAtIERPTUlEX01BU0sgKQorICAgICAgICByZXR1cm4gRE9N
SURfSU5WQUxJRDsKKworICAgIF9fc2V0X2JpdChpZHgsIG1hcCk7CisKKyAg
ICBzdGFydCA9IGlkeCArIDE7CisKKyAgICByZXR1cm4gaWR4IHwgKERPTUlE
X01BU0sgKyAxKTsKK30KKwordm9pZCBpb21tdV9mcmVlX2RvbWlkKGRvbWlk
X3QgZG9taWQsIHVuc2lnbmVkIGxvbmcgKm1hcCkKK3sKKyAgICBBU1NFUlQo
cGNpZGV2c19sb2NrZWQoKSk7CisKKyAgICBpZiAoIGRvbWlkID09IERPTUlE
X0lOVkFMSUQgKQorICAgICAgICByZXR1cm47CisKKyAgICBBU1NFUlQoZG9t
aWQgPiBET01JRF9NQVNLKTsKKworICAgIGlmICggIV9fdGVzdF9hbmRfY2xl
YXJfYml0KGRvbWlkICYgRE9NSURfTUFTSywgbWFwKSApCisgICAgICAgIEJV
RygpOworfQorCiBpbnQgaW9tbXVfZnJlZV9wZ3RhYmxlcyhzdHJ1Y3QgZG9t
YWluICpkKQogewogICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9t
X2lvbW11KGQpOwo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-10.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IGRyb3AgVExCIGZsdXNoZXMgZnJvbSBxdWFyYW50aW5l
X2luaXQoKSBob29rcwoKVGhlIHBhZ2UgdGFibGVzIGp1c3QgY3JlYXRlZCBh
cmVuJ3QgaG9va2VkIHVwIHlldCBhbnl3aGVyZSwgc28gdGhlcmUncwpub3Ro
aW5nIHRoYXQgY291bGQgYmUgcHJlc2VudCBpbiBhbnkgVExCLCBhbmQgaGVu
Y2Ugbm90aGluZyB0byBmbHVzaC4KRHJvcHBpbmcgdGhpcyBmbHVzaCBpcywg
YXQgbGVhc3Qgb24gdGhlIFZULWQgc2lkZSwgYSBwcmVyZXEgdG8gcGVyLQpk
ZXZpY2UgZG9tYWluIElEIHVzZSB3aGVuIHF1YXJhbnRpbmluZyBkZXZpY2Vz
LCBhcyBkb21faW8gaXNuJ3QgZ29pbmcKdG8gYmUgYXNzaWduZWQgYSBESUQg
YW55bW9yZTogVGhlIHdhcm5pbmcgaW4gZ2V0X2lvbW11X2RpZCgpIHdvdWxk
CnRyaWdnZXIuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxA
eGVuLm9yZz4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy
LnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2
aW4udGlhbkBpbnRlbC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11X21hcC5jCkBAIC01ODQsOCArNTg0LDYgQEAgaW50
IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cgogIG91dDoK
ICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKIAot
ICAgIGFtZF9pb21tdV9mbHVzaF9hbGxfcGFnZXMoZCk7Ci0KICAgICAvKiBQ
YWdlcyBsZWFrZWQgaW4gZmFpbHVyZSBjYXNlICovCiAgICAgcmV0dXJuIGxl
dmVsID8gLUVOT01FTSA6IDA7CiB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5jCkBAIC0yOTU4LDkgKzI5NTgsNiBAQCBzdGF0aWMg
aW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFyYW50aW5lCiAgb3V0OgogICAg
IHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogCi0gICAg
aWYgKCAhcmMgKQotICAgICAgICByYyA9IGlvbW11X2ZsdXNoX2lvdGxiX2Fs
bChkKTsKLQogICAgIC8qIFBhZ2VzIG1heSBiZSBsZWFrZWQgaW4gZmFpbHVy
ZSBjYXNlICovCiAgICAgcmV0dXJuIHJjOwogfQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-11.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-11.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IGFic3RyYWN0IG1heGltdW0gbnVtYmVyIG9mIHBhZ2Ug
dGFibGUgbGV2ZWxzCgpXZSB3aWxsIHdhbnQgdG8gdXNlIHRoZSBjb25zdGFu
dCBlbHNld2hlcmUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBh
dWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft
ZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9p
b21tdS5oCkBAIC0zNTgsNyArMzU4LDcgQEAgc3RhdGljIGlubGluZSBpbnQg
YW1kX2lvbW11X2dldF9wYWdpbmdfbQogICAgIHdoaWxlICggbWF4X2ZyYW1l
cyA+IFBURV9QRVJfVEFCTEVfU0laRSApCiAgICAgewogICAgICAgICBtYXhf
ZnJhbWVzID0gUFRFX1BFUl9UQUJMRV9BTElHTihtYXhfZnJhbWVzKSA+PiBQ
VEVfUEVSX1RBQkxFX1NISUZUOwotICAgICAgICBpZiAoICsrbGV2ZWwgPiA2
ICkKKyAgICAgICAgaWYgKCArK2xldmVsID4gSU9NTVVfTUFYX1BUX0xFVkVM
UyApCiAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKICAgICB9CiAKLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11LWRlZnMuaAor
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUtZGVmcy5o
CkBAIC0xMDYsNiArMTA2LDcgQEAgc3RydWN0IGFtZF9pb21tdV9kdGUgewog
ICAgIGJvb2wgdHY6MTsKICAgICB1bnNpZ25lZCBpbnQgOjU7CiAgICAgdW5z
aWduZWQgaW50IGhhZDoyOworI2RlZmluZSBJT01NVV9NQVhfUFRfTEVWRUxT
IDYKICAgICB1bnNpZ25lZCBpbnQgcGFnaW5nX21vZGU6MzsKICAgICB1aW50
NjRfdCBwdF9yb290OjQwOwogICAgIGJvb2wgcHByOjE7Ci0tLSBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYworKysgYi94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMKQEAgLTI1MCw3
ICsyNTAsNyBAQCBzdGF0aWMgaW50IGlvbW11X3BkZV9mcm9tX2RmbihzdHJ1
Y3QgZG9tCiAgICAgdGFibGUgPSBoZC0+YXJjaC5hbWQucm9vdF90YWJsZTsK
ICAgICBsZXZlbCA9IGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZTsKIAotICAg
IEJVR19PTiggdGFibGUgPT0gTlVMTCB8fCBsZXZlbCA8IDEgfHwgbGV2ZWwg
PiA2ICk7CisgICAgQlVHX09OKCB0YWJsZSA9PSBOVUxMIHx8IGxldmVsIDwg
MSB8fCBsZXZlbCA+IElPTU1VX01BWF9QVF9MRVZFTFMgKTsKIAogICAgIC8q
CiAgICAgICogQSBmcmFtZSBudW1iZXIgcGFzdCB3aGF0IHRoZSBjdXJyZW50
IHBhZ2UgdGFibGVzIGNhbiByZXByZXNlbnQgY2FuJ3QK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.15-12.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.15-12.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHVzZSBwZXItZGV2aWNlIHBhZ2UgdGFibGVzIGZvciBx
dWFyYW50aW5pbmcKCkRldmljZXMgd2l0aCBSTVJScyAvIHVuaXR5IG1hcHBl
ZCByZWdpb25zLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQKaG93L3do
ZW4gdGhlc2UgbWVtb3J5IHJlZ2lvbnMgbWF5IGJlIGFjY2Vzc2VkLCBtYXkg
bm90IGJlIGxlZnQKZGlzY29ubmVjdGVkIGZyb20gdGhlIG1hcHBpbmdzIG9m
IHRoZXNlIHJlZ2lvbnMgKGFzIGxvbmcgYXMgaXQncyBub3QKY2VydGFpbiB0
aGF0IHRoZSBkZXZpY2UgaGFzIGJlZW4gZnVsbHkgcXVpZXNjZWQpLiBIZW5j
ZSBldmVuIHRoZSBwYWdlCnRhYmxlcyB1c2VkIHdoZW4gcXVhcmFudGluaW5n
IHN1Y2ggZGV2aWNlcyBuZWVkIHRvIGhhdmUgbWFwcGluZ3Mgb2YKdGhvc2Ug
cmVnaW9ucy4gVGhpcyBpbXBsaWVzIGluc3RhbGxpbmcgcGFnZSB0YWJsZXMg
aW4gdGhlIGZpcnN0IHBsYWNlCmV2ZW4gd2hlbiBub3QgaW4gc2NyYXRjaC1w
YWdlIHF1YXJhbnRpbmluZyBtb2RlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM2
MSAvIHBhcnQgb2YgWFNBLTQwMC4KCldoaWxlIGZvciB0aGUgcHVycG9zZSBo
ZXJlIGl0IHdvdWxkIGJlIHN1ZmZpY2llbnQgdG8gaGF2ZSBkZXZpY2VzIHdp
dGgKUk1SUnMgLyB1bml0eSBtYXBwZWQgcmVnaW9ucyB1c2UgcGVyLWRldmlj
ZSBwYWdlIHRhYmxlcywgZXh0ZW5kIHRoaXMgdG8KYWxsIGRldmljZXMgKGlu
IHNjcmF0Y2gtcGFnZSBxdWFyYW50aW5pbmcgbW9kZSkuIFRoaXMgYWxsb3dz
IHRoZSBsZWFmCnBhZ2VzIHRvIGJlIG1hcHBlZCByL3csIHRodXMgY292ZXJp
bmcgYWxzbyBtZW1vcnkgd3JpdGVzIChyYXRoZXIgdGhhbgpqdXN0IHJlYWRz
KSBpc3N1ZWQgYnkgbm9uLXF1aWVzY2VudCBkZXZpY2VzLgoKU2V0IHVwIHF1
YXJhbnRpbmUgcGFnZSB0YWJsZXMgYXMgbGF0ZSBhcyBwb3NzaWJsZSwgeWV0
IGVhcmx5IGVub3VnaCB0bwpub3QgZW5jb3VudGVyIGZhaWx1cmUgZHVyaW5n
IGRlLWFzc2lnbi4gVGhpcyBtZWFucyBzZXR1cCBnZW5lcmFsbHkKaGFwcGVu
cyBpbiBhc3NpZ25fZGV2aWNlKCksIHdoaWxlIChmb3Igbm93KSB0aGUgb25l
IGluIGRlYXNzaWduX2RldmljZSgpCmlzIHRoZXJlIG1haW5seSB0byBiZSBv
biB0aGUgc2FmZSBzaWRlLgoKSW4gVlQtZCdzIERJRCBhbGxvY2F0aW9uIGZ1
bmN0aW9uIGRvbid0IHJlcXVpcmUgdGhlIElPTU1VIGxvY2sgdG8gYmUKaGVs
ZCBhbnltb3JlOiBBbGwgaW52b2x2ZWQgY29kZSBwYXRocyBob2xkIHBjaWRl
dnNfbG9jaywgc28gdGhpcyB3YXkgd2UKYXZvaWQgdGhlIG5lZWQgdG8gYWNx
dWlyZSB0aGUgSU9NTVUgbG9jayBhcm91bmQgdGhlIG5ldyBjYWxsIHRvCmNv
bnRleHRfc2V0X2RvbWFpbl9pZCgpLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBE
dXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFu
IDxrZXZpbi50aWFuQGludGVsLmNvbT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBh
dSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKLS0tIGEveGVuL2Fy
Y2gveDg2L21tL3AybS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpA
QCAtMTQ2OCw3ICsxNDY4LDcgQEAgaW50IHNldF9pZGVudGl0eV9wMm1fZW50
cnkoc3RydWN0IGRvbWFpbgogICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0g
PSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJldDsKIAotICAgIGlm
ICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShwMm0tPmRvbWFpbikgKQorICAg
IGlmICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShkKSApCiAgICAgewogICAg
ICAgICBpZiAoICFpc19pb21tdV9lbmFibGVkKGQpICkKICAgICAgICAgICAg
IHJldHVybiAwOwotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oCisr
KyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgKQEAgLTEsNiArMSw4IEBA
CiAjaWZuZGVmIF9fWDg2X1BDSV9IX18KICNkZWZpbmUgX19YODZfUENJX0hf
XwogCisjaW5jbHVkZSA8eGVuL21tLmg+CisKICNkZWZpbmUgQ0Y4X0JERihj
ZjgpICAgICAoICAoKGNmOCkgJiAweDAwZmZmZjAwKSA+PiA4KQogI2RlZmlu
ZSBDRjhfQUREUl9MTyhjZjgpICggICAoY2Y4KSAmIDB4MDAwMDAwZmMpCiAj
ZGVmaW5lIENGOF9BRERSX0hJKGNmOCkgKCAgKChjZjgpICYgMHgwZjAwMDAw
MCkgPj4gMTYpCkBAIC0yMCw3ICsyMiwxOCBAQCBzdHJ1Y3QgYXJjaF9wY2lf
ZGV2IHsKICAgICAgKiB0aGVtIGRvbid0IHJhY2UgKGRlKWluaXRpYWxpemF0
aW9uIGFuZCBoZW5jZSBkb24ndCBzdHJpY3RseSBuZWVkIGFueQogICAgICAq
IGxvY2tpbmcuCiAgICAgICovCisgICAgdW5pb24geworICAgICAgICAvKiBT
dWJzZXQgb2Ygc3RydWN0IGFyY2hfaW9tbXUncyBmaWVsZHMsIHRvIGJlIHVz
ZWQgaW4gZG9tX2lvLiAqLworICAgICAgICBzdHJ1Y3QgeworICAgICAgICAg
ICAgdWludDY0X3QgcGdkX21hZGRyOworICAgICAgICB9IHZ0ZDsKKyAgICAg
ICAgc3RydWN0IHsKKyAgICAgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnJv
b3RfdGFibGU7CisgICAgICAgIH0gYW1kOworICAgIH07CiAgICAgZG9taWRf
dCBwc2V1ZG9fZG9taWQ7CisgICAgbWZuX3QgbGVhZl9tZm47CisgICAgc3Ry
dWN0IHBhZ2VfbGlzdF9oZWFkIHBndGFibGVzX2xpc3Q7CiB9OwogCiBpbnQg
cGNpX2NvbmZfd3JpdGVfaW50ZXJjZXB0KHVuc2lnbmVkIGludCBzZWcsIHVu
c2lnbmVkIGludCBiZGYsCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L2FtZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft
ZC9pb21tdS5oCkBAIC0yMjMsNyArMjIzLDggQEAgaW50IGFtZF9pb21tdV9p
bml0X2xhdGUodm9pZCk7CiBpbnQgYW1kX2lvbW11X3VwZGF0ZV9pdnJzX21h
cHBpbmdfYWNwaSh2b2lkKTsKIGludCBpb3ZfYWRqdXN0X2lycV9hZmZpbml0
aWVzKHZvaWQpOwogCi1pbnQgYW1kX2lvbW11X3F1YXJhbnRpbmVfaW5pdChz
dHJ1Y3QgZG9tYWluICpkKTsKK2ludCBhbWRfaW9tbXVfcXVhcmFudGluZV9p
bml0KHN0cnVjdCBwY2lfZGV2ICpwZGV2KTsKK3ZvaWQgYW1kX2lvbW11X3F1
YXJhbnRpbmVfdGVhcmRvd24oc3RydWN0IHBjaV9kZXYgKnBkZXYpOwogCiAv
KiBtYXBwaW5nIGZ1bmN0aW9ucyAqLwogaW50IF9fbXVzdF9jaGVjayBhbWRf
aW9tbXVfbWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3QgZGZuLAot
LS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMK
KysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5j
CkBAIC01MjgsNjQgKzUyOCwxMzUgQEAgaW50IGFtZF9pb21tdV9yZXNlcnZl
X2RvbWFpbl91bml0eV91bm1hcAogICAgIHJldHVybiByYzsKIH0KIAotaW50
IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBkb21h
aW4gKmQpCitzdGF0aWMgaW50IGZpbGxfcXB0KHVuaW9uIGFtZF9pb21tdV9w
dGUgKnRoaXMsIHVuc2lnbmVkIGludCBsZXZlbCwKKyAgICAgICAgICAgICAg
ICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGdzW0lPTU1VX01BWF9QVF9MRVZF
TFNdKQogewotICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lv
bW11KGQpOworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lv
bW11KGRvbV9pbyk7CisgICAgdW5zaWduZWQgaW50IGk7CisgICAgaW50IHJj
ID0gMDsKKworICAgIGZvciAoIGkgPSAwOyAhcmMgJiYgaSA8IFBURV9QRVJf
VEFCTEVfU0laRTsgKytpICkKKyAgICB7CisgICAgICAgIHVuaW9uIGFtZF9p
b21tdV9wdGUgKnB0ZSA9ICZ0aGlzW2ldLCAqbmV4dDsKKworICAgICAgICBp
ZiAoICFwdGUtPnByICkKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKCAh
cGdzW2xldmVsXSApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAg
LyoKKyAgICAgICAgICAgICAgICAgKiBUaGUgcGd0YWJsZSBhbGxvY2F0b3Ig
aXMgZmluZSBmb3IgdGhlIGxlYWYgcGFnZSwgYXMgd2VsbCBhcworICAgICAg
ICAgICAgICAgICAqIHBhZ2UgdGFibGUgcGFnZXMsIGFuZCB0aGUgcmVzdWx0
aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMKKyAgICAgICAgICAgICAgICAg
KiB6ZXJvZWQuCisgICAgICAgICAgICAgICAgICovCisgICAgICAgICAgICAg
ICAgcGdzW2xldmVsXSA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOworICAg
ICAgICAgICAgICAgIGlmICggIXBnc1tsZXZlbF0gKQorICAgICAgICAgICAg
ICAgIHsKKyAgICAgICAgICAgICAgICAgICAgcmMgPSAtRU5PTUVNOworICAg
ICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICB9CisK
KyAgICAgICAgICAgICAgICBpZiAoIGxldmVsICkKKyAgICAgICAgICAgICAg
ICB7CisgICAgICAgICAgICAgICAgICAgIG5leHQgPSBfX21hcF9kb21haW5f
cGFnZShwZ3NbbGV2ZWxdKTsKKyAgICAgICAgICAgICAgICAgICAgcmMgPSBm
aWxsX3FwdChuZXh0LCBsZXZlbCAtIDEsIHBncyk7CisgICAgICAgICAgICAg
ICAgICAgIHVubWFwX2RvbWFpbl9wYWdlKG5leHQpOworICAgICAgICAgICAg
ICAgIH0KKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgLyoKKyAgICAg
ICAgICAgICAqIFBERXMgYXJlIGVzc2VudGlhbGx5IGEgc3Vic2V0IG9mIFBU
RXMsIHNvIHRoaXMgZnVuY3Rpb24KKyAgICAgICAgICAgICAqIGlzIGZpbmUg
dG8gdXNlIGV2ZW4gYXQgdGhlIGxlYWYuCisgICAgICAgICAgICAgKi8KKyAg
ICAgICAgICAgIHNldF9pb21tdV9wZGVfcHJlc2VudChwdGUsIG1mbl94KHBh
Z2VfdG9fbWZuKHBnc1tsZXZlbF0pKSwgbGV2ZWwsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgdHJ1ZSwgdHJ1ZSk7CisgICAgICAgIH0K
KyAgICAgICAgZWxzZSBpZiAoIGxldmVsICYmIHB0ZS0+bmV4dF9sZXZlbCAp
CisgICAgICAgIHsKKyAgICAgICAgICAgIG5leHQgPSBtYXBfZG9tYWluX3Bh
Z2UoX21mbihwdGUtPm1mbikpOworICAgICAgICAgICAgcmMgPSBmaWxsX3Fw
dChuZXh0LCBsZXZlbCAtIDEsIHBncyk7CisgICAgICAgICAgICB1bm1hcF9k
b21haW5fcGFnZShuZXh0KTsKKyAgICAgICAgfQorICAgIH0KKworICAgIHJl
dHVybiByYzsKK30KKworaW50IGFtZF9pb21tdV9xdWFyYW50aW5lX2luaXQo
c3RydWN0IHBjaV9kZXYgKnBkZXYpCit7CisgICAgc3RydWN0IGRvbWFpbl9p
b21tdSAqaGQgPSBkb21faW9tbXUoZG9tX2lvKTsKICAgICB1bnNpZ25lZCBs
b25nIGVuZF9nZm4gPQogICAgICAgICAxdWwgPDwgKERFRkFVTFRfRE9NQUlO
X0FERFJFU1NfV0lEVEggLSBQQUdFX1NISUZUKTsKICAgICB1bnNpZ25lZCBp
bnQgbGV2ZWwgPSBhbWRfaW9tbXVfZ2V0X3BhZ2luZ19tb2RlKGVuZF9nZm4p
OwotICAgIHVuaW9uIGFtZF9pb21tdV9wdGUgKnRhYmxlOworICAgIHVuc2ln
bmVkIGludCByZXFfaWQgPSBnZXRfZG1hX3JlcXVlc3Rvcl9pZChwZGV2LT5z
ZWcsIHBkZXYtPnNiZGYuYmRmKTsKKyAgICBjb25zdCBzdHJ1Y3QgaXZyc19t
YXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHBk
ZXYtPnNlZyk7CisgICAgaW50IHJjOwogCi0gICAgaWYgKCBoZC0+YXJjaC5h
bWQucm9vdF90YWJsZSApCisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkp
OworICAgIEFTU0VSVCghaGQtPmFyY2guYW1kLnJvb3RfdGFibGUpOworICAg
IEFTU0VSVChwYWdlX2xpc3RfZW1wdHkoJmhkLT5hcmNoLnBndGFibGVzLmxp
c3QpKTsKKworICAgIEFTU0VSVChwZGV2LT5hcmNoLnBzZXVkb19kb21pZCAh
PSBET01JRF9JTlZBTElEKTsKKworICAgIGlmICggcGRldi0+YXJjaC5hbWQu
cm9vdF90YWJsZSApCiAgICAgewotICAgICAgICBBU1NFUlRfVU5SRUFDSEFC
TEUoKTsKKyAgICAgICAgY2xlYXJfZG9tYWluX3BhZ2UocGRldi0+YXJjaC5s
ZWFmX21mbik7CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAotICAgIHNw
aW5fbG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKLQotICAgIGhkLT5h
cmNoLmFtZC5yb290X3RhYmxlID0gaW9tbXVfYWxsb2NfcGd0YWJsZShoZCk7
Ci0gICAgaWYgKCAhaGQtPmFyY2guYW1kLnJvb3RfdGFibGUgKQotICAgICAg
ICBnb3RvIG91dDsKLQotICAgIHRhYmxlID0gX19tYXBfZG9tYWluX3BhZ2Uo
aGQtPmFyY2guYW1kLnJvb3RfdGFibGUpOwotICAgIHdoaWxlICggbGV2ZWwg
KQorICAgIHBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGUgPSBpb21tdV9hbGxv
Y19wZ3RhYmxlKGhkKTsKKyAgICBpZiAoICFwZGV2LT5hcmNoLmFtZC5yb290
X3RhYmxlICkKKyAgICAgICAgcmV0dXJuIC1FTk9NRU07CisKKyAgICAvKiBU
cmFuc2llbnRseSBpbnN0YWxsIHRoZSByb290IGludG8gRG9tSU8sIGZvciBp
b21tdV9pZGVudGl0eV9tYXBwaW5nKCkuICovCisgICAgaGQtPmFyY2guYW1k
LnJvb3RfdGFibGUgPSBwZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlOworCisg
ICAgcmMgPSBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKGRv
bV9pbywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcCwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMCk7CisK
KyAgICBpb21tdV9pZGVudGl0eV9tYXBfdGVhcmRvd24oZG9tX2lvKTsKKyAg
ICBoZC0+YXJjaC5hbWQucm9vdF90YWJsZSA9IE5VTEw7CisKKyAgICBpZiAo
IHJjICkKKyAgICAgICAgcHJpbnRrKCIlcHA6IHF1YXJhbnRpbmUgdW5pdHkg
bWFwcGluZyBmYWlsZWRcbiIsICZwZGV2LT5zYmRmKTsKKyAgICBlbHNlCiAg
ICAgewotICAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKLSAgICAgICAg
dW5zaWduZWQgaW50IGk7CisgICAgICAgIHVuaW9uIGFtZF9pb21tdV9wdGUg
KnJvb3Q7CisgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnc1tJT01NVV9N
QVhfUFRfTEVWRUxTXSA9IHt9OwogCi0gICAgICAgIC8qCi0gICAgICAgICAq
IFRoZSBwZ3RhYmxlIGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUgbGVhZiBw
YWdlLCBhcyB3ZWxsIGFzCi0gICAgICAgICAqIHBhZ2UgdGFibGUgcGFnZXMs
IGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMKLSAg
ICAgICAgICogemVyb2VkLgotICAgICAgICAgKi8KLSAgICAgICAgcGcgPSBp
b21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKLSAgICAgICAgaWYgKCAhcGcgKQot
ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIHNwaW5fbG9jaygmaGQtPmFy
Y2gubWFwcGluZ19sb2NrKTsKIAotICAgICAgICBmb3IgKCBpID0gMDsgaSA8
IFBURV9QRVJfVEFCTEVfU0laRTsgaSsrICkKLSAgICAgICAgewotICAgICAg
ICAgICAgdW5pb24gYW1kX2lvbW11X3B0ZSAqcGRlID0gJnRhYmxlW2ldOwor
ICAgICAgICByb290ID0gX19tYXBfZG9tYWluX3BhZ2UocGRldi0+YXJjaC5h
bWQucm9vdF90YWJsZSk7CisgICAgICAgIHJjID0gZmlsbF9xcHQocm9vdCwg
bGV2ZWwgLSAxLCBwZ3MpOworICAgICAgICB1bm1hcF9kb21haW5fcGFnZShy
b290KTsKIAotICAgICAgICAgICAgLyoKLSAgICAgICAgICAgICAqIFBERXMg
YXJlIGVzc2VudGlhbGx5IGEgc3Vic2V0IG9mIFBURXMsIHNvIHRoaXMgZnVu
Y3Rpb24KLSAgICAgICAgICAgICAqIGlzIGZpbmUgdG8gdXNlIGV2ZW4gYXQg
dGhlIGxlYWYuCi0gICAgICAgICAgICAgKi8KLSAgICAgICAgICAgIHNldF9p
b21tdV9wZGVfcHJlc2VudChwZGUsIG1mbl94KHBhZ2VfdG9fbWZuKHBnKSks
IGxldmVsIC0gMSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBmYWxzZSwgdHJ1ZSk7Ci0gICAgICAgIH0KKyAgICAgICAgcGRldi0+YXJj
aC5sZWFmX21mbiA9IHBhZ2VfdG9fbWZuKHBnc1swXSk7CiAKLSAgICAgICAg
dW5tYXBfZG9tYWluX3BhZ2UodGFibGUpOwotICAgICAgICB0YWJsZSA9IF9f
bWFwX2RvbWFpbl9wYWdlKHBnKTsKLSAgICAgICAgbGV2ZWwtLTsKKyAgICAg
ICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAgICAg
fQotICAgIHVubWFwX2RvbWFpbl9wYWdlKHRhYmxlKTsKIAotIG91dDoKLSAg
ICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKKyAgICBw
YWdlX2xpc3RfbW92ZSgmcGRldi0+YXJjaC5wZ3RhYmxlc19saXN0LCAmaGQt
PmFyY2gucGd0YWJsZXMubGlzdCk7CisKKyAgICBpZiAoIHJjICkKKyAgICAg
ICAgYW1kX2lvbW11X3F1YXJhbnRpbmVfdGVhcmRvd24ocGRldik7CisKKyAg
ICByZXR1cm4gcmM7Cit9CisKK3ZvaWQgYW1kX2lvbW11X3F1YXJhbnRpbmVf
dGVhcmRvd24oc3RydWN0IHBjaV9kZXYgKnBkZXYpCit7CisgICAgc3RydWN0
IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZG9tX2lvKTsKKworICAg
IEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKKworICAgIGlmICggIXBkZXYt
PmFyY2guYW1kLnJvb3RfdGFibGUgKQorICAgICAgICByZXR1cm47CiAKLSAg
ICAvKiBQYWdlcyBsZWFrZWQgaW4gZmFpbHVyZSBjYXNlICovCi0gICAgcmV0
dXJuIGxldmVsID8gLUVOT01FTSA6IDA7CisgICAgQVNTRVJUKHBhZ2VfbGlz
dF9lbXB0eSgmaGQtPmFyY2gucGd0YWJsZXMubGlzdCkpOworICAgIHBhZ2Vf
bGlzdF9tb3ZlKCZoZC0+YXJjaC5wZ3RhYmxlcy5saXN0LCAmcGRldi0+YXJj
aC5wZ3RhYmxlc19saXN0KTsKKyAgICB3aGlsZSAoIGlvbW11X2ZyZWVfcGd0
YWJsZXMoZG9tX2lvKSA9PSAtRVJFU1RBUlQgKQorICAgICAgICAvKiBub3Ro
aW5nICovOworICAgIHBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGUgPSBOVUxM
OwogfQogCiAvKgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQv
cGNpX2FtZF9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L2FtZC9wY2lfYW1kX2lvbW11LmMKQEAgLTEyMiw2ICsxMjIsOCBAQCBzdGF0
aWMgaW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfCiAgICAgdTgg
YnVzID0gcGRldi0+YnVzOwogICAgIGNvbnN0IHN0cnVjdCBkb21haW5faW9t
bXUgKmhkID0gZG9tX2lvbW11KGRvbWFpbik7CiAgICAgY29uc3Qgc3RydWN0
IGl2cnNfbWFwcGluZ3MgKml2cnNfZGV2OworICAgIGNvbnN0IHN0cnVjdCBw
YWdlX2luZm8gKnJvb3RfcGc7CisgICAgZG9taWRfdCBkb21pZDsKIAogICAg
IEJVR19PTighaGQtPmFyY2guYW1kLnBhZ2luZ19tb2RlIHx8ICFpb21tdS0+
ZGV2X3RhYmxlLmJ1ZmZlcik7CiAKQEAgLTE0MSwxNCArMTQzLDI1IEBAIHN0
YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICBk
dGUgPSAmdGFibGVbcmVxX2lkXTsKICAgICBpdnJzX2RldiA9ICZnZXRfaXZy
c19tYXBwaW5ncyhpb21tdS0+c2VnKVtyZXFfaWRdOwogCisgICAgaWYgKCBk
b21haW4gIT0gZG9tX2lvICkKKyAgICB7CisgICAgICAgIHJvb3RfcGcgPSBo
ZC0+YXJjaC5hbWQucm9vdF90YWJsZTsKKyAgICAgICAgZG9taWQgPSBkb21h
aW4tPmRvbWFpbl9pZDsKKyAgICB9CisgICAgZWxzZQorICAgIHsKKyAgICAg
ICAgcm9vdF9wZyA9IHBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGU7CisgICAg
ICAgIGRvbWlkID0gcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQ7CisgICAgfQor
CiAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmlvbW11LT5sb2NrLCBmbGFncyk7
CiAKICAgICBpZiAoICFkdGUtPnYgfHwgIWR0ZS0+dHYgKQogICAgIHsKICAg
ICAgICAgLyogYmluZCBEVEUgdG8gZG9tYWluIHBhZ2UtdGFibGVzICovCiAg
ICAgICAgIHJjID0gYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoCi0g
ICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkcihoZC0+YXJjaC5h
bWQucm9vdF90YWJsZSksCi0gICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9t
YWluX2lkLCBoZC0+YXJjaC5hbWQucGFnaW5nX21vZGUsIHNyX2ZsYWdzKTsK
KyAgICAgICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRyKHJvb3RfcGcp
LCBkb21pZCwKKyAgICAgICAgICAgICAgICAgaGQtPmFyY2guYW1kLnBhZ2lu
Z19tb2RlLCBzcl9mbGFncyk7CiAgICAgICAgIGlmICggcmMgKQogICAgICAg
ICB7CiAgICAgICAgICAgICBBU1NFUlQocmMgPCAwKTsKQEAgLTE3Miw3ICsx
ODUsNyBAQCBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0
dXBfCiAKICAgICAgICAgYW1kX2lvbW11X2ZsdXNoX2RldmljZShpb21tdSwg
cmVxX2lkKTsKICAgICB9Ci0gICAgZWxzZSBpZiAoIGR0ZS0+cHRfcm9vdCAh
PSBtZm5feChwYWdlX3RvX21mbihoZC0+YXJjaC5hbWQucm9vdF90YWJsZSkp
ICkKKyAgICBlbHNlIGlmICggZHRlLT5wdF9yb290ICE9IG1mbl94KHBhZ2Vf
dG9fbWZuKHJvb3RfcGcpKSApCiAgICAgewogICAgICAgICAvKgogICAgICAg
ICAgKiBTdHJpY3RseSBzcGVha2luZyBpZiB0aGUgZGV2aWNlIGlzIHRoZSBv
bmx5IG9uZSB3aXRoIHRoaXMgcmVxdWVzdG9yCkBAIC0xODUsOCArMTk4LDgg
QEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwog
ICAgICAgICAgICAgcmMgPSAtRU9QTk9UU1VQUDsKICAgICAgICAgZWxzZQog
ICAgICAgICAgICAgcmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJs
ZSgKLSAgICAgICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkciho
ZC0+YXJjaC5hbWQucm9vdF90YWJsZSksCi0gICAgICAgICAgICAgICAgICAg
ICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2guYW1kLnBhZ2luZ19tb2Rl
LCBzcl9mbGFncyk7CisgICAgICAgICAgICAgICAgICAgICBkdGUsIHBhZ2Vf
dG9fbWFkZHIocm9vdF9wZyksIGRvbWlkLAorICAgICAgICAgICAgICAgICAg
ICAgaGQtPmFyY2guYW1kLnBhZ2luZ19tb2RlLCBzcl9mbGFncyk7CiAgICAg
ICAgIGlmICggcmMgPCAwICkKICAgICAgICAgewogICAgICAgICAgICAgc3Bp
bl91bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKQEAg
LTIwNSw2ICsyMTgsNyBAQCBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBhbWRf
aW9tbXVfc2V0dXBfCiAgICAgICAgICAgICAgICogaW50ZW5kZWQgYW55d2F5
LgogICAgICAgICAgICAgICAqLwogICAgICAgICAgICAgICFwZGV2LT5kb21h
aW4tPmlzX2R5aW5nICYmCisgICAgICAgICAgICAgcGRldi0+ZG9tYWluICE9
IGRvbV9pbyAmJgogICAgICAgICAgICAgIChhbnlfcGRldl9iZWhpbmRfaW9t
bXUocGRldi0+ZG9tYWluLCBwZGV2LCBpb21tdSkgfHwKICAgICAgICAgICAg
ICAgcGRldi0+cGhhbnRvbV9zdHJpZGUpICkKICAgICAgICAgICAgIHByaW50
aygiICVwcDogcmVhc3NpZ25tZW50IG1heSBjYXVzZSAlcGQgZGF0YSBjb3Jy
dXB0aW9uXG4iLApAQCAtMjM0LDkgKzI0OCw4IEBAIHN0YXRpYyBpbnQgX19t
dXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICBBTURfSU9NTVVfREVC
VUcoIlNldHVwIEkvTyBwYWdlIHRhYmxlOiBkZXZpY2UgaWQgPSAlI3gsIHR5
cGUgPSAlI3gsICIKICAgICAgICAgICAgICAgICAgICAgInJvb3QgdGFibGUg
PSAlIyJQUkl4NjQiLCAiCiAgICAgICAgICAgICAgICAgICAgICJkb21haW4g
PSAlZCwgcGFnaW5nIG1vZGUgPSAlZFxuIiwKLSAgICAgICAgICAgICAgICAg
ICAgcmVxX2lkLCBwZGV2LT50eXBlLAotICAgICAgICAgICAgICAgICAgICBw
YWdlX3RvX21hZGRyKGhkLT5hcmNoLmFtZC5yb290X3RhYmxlKSwKLSAgICAg
ICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQsIGhkLT5hcmNoLmFt
ZC5wYWdpbmdfbW9kZSk7CisgICAgICAgICAgICAgICAgICAgIHJlcV9pZCwg
cGRldi0+dHlwZSwgcGFnZV90b19tYWRkcihyb290X3BnKSwKKyAgICAgICAg
ICAgICAgICAgICAgZG9taWQsIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSk7
CiAKICAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CiAKQEAgLTMwNSw3
ICszMTgsNyBAQCBpbnQgYW1kX2lvbW11X2FsbG9jX3Jvb3Qoc3RydWN0IGRv
bWFpbiAqCiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21f
aW9tbXUoZCk7CiAKLSAgICBpZiAoIHVubGlrZWx5KCFoZC0+YXJjaC5hbWQu
cm9vdF90YWJsZSkgKQorICAgIGlmICggdW5saWtlbHkoIWhkLT5hcmNoLmFt
ZC5yb290X3RhYmxlKSAmJiBkICE9IGRvbV9pbyApCiAgICAgewogICAgICAg
ICBoZC0+YXJjaC5hbWQucm9vdF90YWJsZSA9IGlvbW11X2FsbG9jX3BndGFi
bGUoaGQpOwogICAgICAgICBpZiAoICFoZC0+YXJjaC5hbWQucm9vdF90YWJs
ZSApCkBAIC0zOTYsNyArNDA5LDcgQEAgc3RhdGljIHZvaWQgYW1kX2lvbW11
X2Rpc2FibGVfZG9tYWluX2RldgogCiAgICAgICAgIEFNRF9JT01NVV9ERUJV
RygiRGlzYWJsZTogZGV2aWNlIGlkID0gJSN4LCAiCiAgICAgICAgICAgICAg
ICAgICAgICAgICAiZG9tYWluID0gJWQsIHBhZ2luZyBtb2RlID0gJWRcbiIs
Ci0gICAgICAgICAgICAgICAgICAgICAgICByZXFfaWQsICBkb21haW4tPmRv
bWFpbl9pZCwKKyAgICAgICAgICAgICAgICAgICAgICAgIHJlcV9pZCwgZHRl
LT5kb21haW5faWQsCiAgICAgICAgICAgICAgICAgICAgICAgICBkb21faW9t
bXUoZG9tYWluKS0+YXJjaC5hbWQucGFnaW5nX21vZGUpOwogICAgIH0KICAg
ICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3Mp
OwpAQCAtNjA4LDYgKzYyMSw4IEBAIHN0YXRpYyBpbnQgYW1kX2lvbW11X3Jl
bW92ZV9kZXZpY2UodTggZGUKIAogICAgIGFtZF9pb21tdV9kaXNhYmxlX2Rv
bWFpbl9kZXZpY2UocGRldi0+ZG9tYWluLCBpb21tdSwgZGV2Zm4sIHBkZXYp
OwogCisgICAgYW1kX2lvbW11X3F1YXJhbnRpbmVfdGVhcmRvd24ocGRldik7
CisKICAgICBpb21tdV9mcmVlX2RvbWlkKHBkZXYtPmFyY2gucHNldWRvX2Rv
bWlkLCBpb21tdS0+ZG9taWRfbWFwKTsKICAgICBwZGV2LT5hcmNoLnBzZXVk
b19kb21pZCA9IERPTUlEX0lOVkFMSUQ7CiAKLS0tIGEveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9pb21tdS5jCkBAIC00MjQsMjEgKzQyNCwyMSBAQCBpbnQgaW9tbXVf
aW90bGJfZmx1c2hfYWxsKHN0cnVjdCBkb21haW4KICAgICByZXR1cm4gcmM7
CiB9CiAKLXN0YXRpYyBpbnQgX19pbml0IGlvbW11X3F1YXJhbnRpbmVfaW5p
dCh2b2lkKQoraW50IGlvbW11X3F1YXJhbnRpbmVfZGV2X2luaXQoZGV2aWNl
X3QgKmRldikKIHsKICAgICBjb25zdCBzdHJ1Y3QgZG9tYWluX2lvbW11ICpo
ZCA9IGRvbV9pb21tdShkb21faW8pOwotICAgIGludCByYzsKIAotICAgIGRv
bV9pby0+b3B0aW9ucyB8PSBYRU5fRE9NQ1RMX0NERl9pb21tdTsKKyAgICBp
ZiAoICFpb21tdV9xdWFyYW50aW5lIHx8ICFoZC0+cGxhdGZvcm1fb3BzLT5x
dWFyYW50aW5lX2luaXQgKQorICAgICAgICByZXR1cm4gMDsKIAotICAgIHJj
ID0gaW9tbXVfZG9tYWluX2luaXQoZG9tX2lvLCAwKTsKLSAgICBpZiAoIHJj
ICkKLSAgICAgICAgcmV0dXJuIHJjOworICAgIHJldHVybiBpb21tdV9jYWxs
KGhkLT5wbGF0Zm9ybV9vcHMsIHF1YXJhbnRpbmVfaW5pdCwgZGV2KTsKK30K
IAotICAgIGlmICggIWhkLT5wbGF0Zm9ybV9vcHMtPnF1YXJhbnRpbmVfaW5p
dCApCi0gICAgICAgIHJldHVybiAwOworc3RhdGljIGludCBfX2luaXQgaW9t
bXVfcXVhcmFudGluZV9pbml0KHZvaWQpCit7CisgICAgZG9tX2lvLT5vcHRp
b25zIHw9IFhFTl9ET01DVExfQ0RGX2lvbW11OwogCi0gICAgcmV0dXJuIGhk
LT5wbGF0Zm9ybV9vcHMtPnF1YXJhbnRpbmVfaW5pdChkb21faW8pOworICAg
IHJldHVybiBpb21tdV9kb21haW5faW5pdChkb21faW8sIDApOwogfQogCiBp
bnQgX19pbml0IGlvbW11X3NldHVwKHZvaWQpCi0tLSBhL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL3BjaS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3BjaS5jCkBAIC04NTgsOSArODU4LDE2IEBAIHN0YXRpYyBpbnQgZGVh
c3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4KICAgICAgICAgcmV0dXJuIC1F
Tk9ERVY7CiAKICAgICAvKiBEZS1hc3NpZ25tZW50IGZyb20gZG9tX2lvIHNo
b3VsZCBkZS1xdWFyYW50aW5lIHRoZSBkZXZpY2UgKi8KLSAgICB0YXJnZXQg
PSAoKHBkZXYtPnF1YXJhbnRpbmUgfHwgaW9tbXVfcXVhcmFudGluZSkgJiYK
LSAgICAgICAgICAgICAgcGRldi0+ZG9tYWluICE9IGRvbV9pbykgPwotICAg
ICAgICBkb21faW8gOiBoYXJkd2FyZV9kb21haW47CisgICAgaWYgKCAocGRl
di0+cXVhcmFudGluZSB8fCBpb21tdV9xdWFyYW50aW5lKSAmJiBwZGV2LT5k
b21haW4gIT0gZG9tX2lvICkKKyAgICB7CisgICAgICAgIHJldCA9IGlvbW11
X3F1YXJhbnRpbmVfZGV2X2luaXQocGNpX3RvX2RldihwZGV2KSk7CisgICAg
ICAgIGlmICggcmV0ICkKKyAgICAgICAgICAgcmV0dXJuIHJldDsKKworICAg
ICAgICB0YXJnZXQgPSBkb21faW87CisgICAgfQorICAgIGVsc2UKKyAgICAg
ICAgdGFyZ2V0ID0gaGFyZHdhcmVfZG9tYWluOwogCiAgICAgd2hpbGUgKCBw
ZGV2LT5waGFudG9tX3N0cmlkZSApCiAgICAgewpAQCAtMTQ0MSw2ICsxNDQ4
LDEzIEBAIHN0YXRpYyBpbnQgYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWlu
ICoKICAgICAgICAgbXNpeHRibF9pbml0KGQpOwogICAgIH0KIAorICAgIGlm
ICggcGRldi0+ZG9tYWluICE9IGRvbV9pbyApCisgICAgeworICAgICAgICBy
YyA9IGlvbW11X3F1YXJhbnRpbmVfZGV2X2luaXQocGNpX3RvX2RldihwZGV2
KSk7CisgICAgICAgIGlmICggcmMgKQorICAgICAgICAgICAgZ290byBkb25l
OworICAgIH0KKwogICAgIHBkZXYtPmZhdWx0LmNvdW50ID0gMDsKIAogICAg
IGlmICggKHJjID0gaGQtPnBsYXRmb3JtX29wcy0+YXNzaWduX2RldmljZShk
LCBkZXZmbiwgcGNpX3RvX2RldihwZGV2KSwgZmxhZykpICkKLS0tIGEveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAgLTQzLDYgKzQzLDEy
IEBACiAjaW5jbHVkZSAidnRkLmgiCiAjaW5jbHVkZSAiLi4vYXRzLmgiCiAK
KyNkZWZpbmUgREVWSUNFX0RPTUlEKGQsIHBkZXYpICgoZCkgIT0gZG9tX2lv
ID8gKGQpLT5kb21haW5faWQgXAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgOiAocGRldiktPmFyY2gucHNldWRvX2Rv
bWlkKQorI2RlZmluZSBERVZJQ0VfUEdUQUJMRShkLCBwZGV2KSAoKGQpICE9
IGRvbV9pbyBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/
IGRvbV9pb21tdShkKS0+YXJjaC52dGQucGdkX21hZGRyIFwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIDogKHBkZXYpLT5hcmNoLnZ0ZC5w
Z2RfbWFkZHIpCisKIC8qIFBvc3NpYmxlIHVuZmlsdGVyZWQgTEFQSUMvTVNJ
IG1lc3NhZ2VzIGZyb20gdW50cnVzdGVkIHNvdXJjZXM/ICovCiBib29sIF9f
cmVhZF9tb3N0bHkgdW50cnVzdGVkX21zaTsKIApAQCAtODUsMTMgKzkxLDE4
IEBAIHN0YXRpYyBpbnQgZ2V0X2lvbW11X2RpZChkb21pZF90IGRvbWlkLAog
CiAjZGVmaW5lIERJRF9GSUVMRF9XSURUSCAxNgogI2RlZmluZSBESURfSElH
SF9PRkZTRVQgOAorCisvKgorICogVGhpcyBmdW5jdGlvbiBtYXkgaGF2ZSAi
Y29udGV4dCIgcGFzc2VkIGFzIE5VTEwsIHRvIG1lcmVseSBvYnRhaW4gYSBE
SUQKKyAqIGZvciAiZG9taWQiLgorICovCiBzdGF0aWMgaW50IGNvbnRleHRf
c2V0X2RvbWFpbl9pZChzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4dCwK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlkX3QgZG9t
aWQsIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQogewogICAgIHVuc2lnbmVk
IGxvbmcgbnJfZG9tLCBpOwogICAgIGludCBmb3VuZCA9IDA7CiAKLSAgICBB
U1NFUlQoc3Bpbl9pc19sb2NrZWQoJmlvbW11LT5sb2NrKSk7CisgICAgQVNT
RVJUKHBjaWRldnNfbG9ja2VkKCkpOwogCiAgICAgbnJfZG9tID0gY2FwX25k
b21zKGlvbW11LT5jYXApOwogICAgIGkgPSBmaW5kX2ZpcnN0X2JpdChpb21t
dS0+ZG9taWRfYml0bWFwLCBucl9kb20pOwpAQCAtMTE3LDggKzEyOCwxMyBA
QCBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9pZChzdHJ1Y3QKICAg
ICB9CiAKICAgICBzZXRfYml0KGksIGlvbW11LT5kb21pZF9iaXRtYXApOwot
ICAgIGNvbnRleHQtPmhpICY9IH4oKCgxIDw8IERJRF9GSUVMRF9XSURUSCkg
LSAxKSA8PCBESURfSElHSF9PRkZTRVQpOwotICAgIGNvbnRleHQtPmhpIHw9
IChpICYgKCgxIDw8IERJRF9GSUVMRF9XSURUSCkgLSAxKSkgPDwgRElEX0hJ
R0hfT0ZGU0VUOworCisgICAgaWYgKCBjb250ZXh0ICkKKyAgICB7CisgICAg
ICAgIGNvbnRleHQtPmhpICY9IH4oKCgxIDw8IERJRF9GSUVMRF9XSURUSCkg
LSAxKSA8PCBESURfSElHSF9PRkZTRVQpOworICAgICAgICBjb250ZXh0LT5o
aSB8PSAoaSAmICgoMSA8PCBESURfRklFTERfV0lEVEgpIC0gMSkpIDw8IERJ
RF9ISUdIX09GRlNFVDsKKyAgICB9CisKICAgICByZXR1cm4gMDsKIH0KIApA
QCAtMTY4LDggKzE4NCwxMiBAQCBzdGF0aWMgdm9pZCBjaGVja19jbGVhbnVw
X2RvbWlkX21hcChzdHJ1CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqZXhjbHVkZSwKICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQogewotICAgIGJvb2wgZm91bmQgPSBhbnlfcGRldl9iZWhp
bmRfaW9tbXUoZCwgZXhjbHVkZSwgaW9tbXUpOworICAgIGJvb2wgZm91bmQ7
CisKKyAgICBpZiAoIGQgPT0gZG9tX2lvICkKKyAgICAgICAgcmV0dXJuOwog
CisgICAgZm91bmQgPSBhbnlfcGRldl9iZWhpbmRfaW9tbXUoZCwgZXhjbHVk
ZSwgaW9tbXUpOwogICAgIC8qCiAgICAgICogSGlkZGVuIGRldmljZXMgYXJl
IGFzc29jaWF0ZWQgd2l0aCBEb21YRU4gYnV0IHVzYWJsZSBieSB0aGUgaGFy
ZHdhcmUKICAgICAgKiBkb21haW4uIEhlbmNlIHRoZXkgbmVlZCBjb25zaWRl
cmluZyBoZXJlIGFzIHdlbGwuCkBAIC0xNDE0LDcgKzE0MzQsNyBAQCBpbnQg
ZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgICAgIGRvbWlkID0g
aW9tbXUtPmRvbWlkX21hcFtwcmV2X2RpZF07CiAgICAgICAgIGlmICggZG9t
aWQgPCBET01JRF9GSVJTVF9SRVNFUlZFRCApCiAgICAgICAgICAgICBwcmV2
X2RvbSA9IHJjdV9sb2NrX2RvbWFpbl9ieV9pZChkb21pZCk7Ci0gICAgICAg
IGVsc2UgaWYgKCBkb21pZCA9PSBET01JRF9JTyApCisgICAgICAgIGVsc2Ug
aWYgKCBwZGV2ID8gZG9taWQgPT0gcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQg
OiBkb21pZCA+IERPTUlEX01BU0sgKQogICAgICAgICAgICAgcHJldl9kb20g
PSByY3VfbG9ja19kb21haW4oZG9tX2lvKTsKICAgICAgICAgaWYgKCAhcHJl
dl9kb20gKQogICAgICAgICB7CkBAIC0xNTcwLDE1ICsxNTkwLDEyIEBAIGlu
dCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICB7CiAgICAgICAg
IGlmICggIXByZXZfZG9tICkKICAgICAgICAgICAgIHJldCA9IGRvbWFpbl9j
b250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMsIGRldmZuLAot
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRv
bWFpbi0+ZG9tYWluX2lkKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7
CiAgICAgICAgIGVsc2UgaWYgKCBwcmV2X2RvbSAhPSBkb21haW4gKSAvKiBB
dm9pZCBpbmZpbml0ZSByZWN1cnNpb24uICovCi0gICAgICAgIHsKLSAgICAg
ICAgICAgIGhkID0gZG9tX2lvbW11KHByZXZfZG9tKTsKICAgICAgICAgICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKHByZXZfZG9tLCBp
b21tdSwgYnVzLCBkZXZmbiwgcGRldiwKLSAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLAot
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
aGQtPmFyY2gudnRkLnBnZF9tYWRkciwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIERFVklDRV9ET01JRChwcmV2X2Rv
bSwgcGRldiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBERVZJQ0VfUEdUQUJMRShwcmV2X2RvbSwgcGRldiksCiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBt
b2RlICYgTUFQX1dJVEhfUk1SUikgPCAwOwotICAgICAgICB9CiAgICAgICAg
IGVsc2UKICAgICAgICAgICAgIHJldCA9IDE7CiAKQEAgLTE2MDAsNyArMTYx
Nyw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1
Y3QKIHsKICAgICBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQ7CiAgICAg
Y29uc3Qgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwotICAgIHBhZGRy
X3QgcGdkX21hZGRyID0gZG9tX2lvbW11KGRvbWFpbiktPmFyY2gudnRkLnBn
ZF9tYWRkcjsKKyAgICBwYWRkcl90IHBnZF9tYWRkciA9IERFVklDRV9QR1RB
QkxFKGRvbWFpbiwgcGRldik7CiAgICAgZG9taWRfdCBvcmlnX2RvbWlkID0g
cGRldi0+YXJjaC5wc2V1ZG9fZG9taWQ7CiAgICAgaW50IHJldCA9IDA7CiAg
ICAgdW5zaWduZWQgaW50IGksIG1vZGUgPSAwOwpAQCAtMTYzMyw3ICsxNjUw
LDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVj
dAogICAgICAgICBicmVhazsKICAgICB9CiAKLSAgICBpZiAoIGRvbWFpbiAh
PSBwZGV2LT5kb21haW4gKQorICAgIGlmICggZG9tYWluICE9IHBkZXYtPmRv
bWFpbiAmJiBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkKICAgICB7CiAgICAg
ICAgIGlmICggcGRldi0+ZG9tYWluLT5pc19keWluZyApCiAgICAgICAgICAg
ICBtb2RlIHw9IE1BUF9PV05FUl9EWUlORzsKQEAgLTE2NzIsOCArMTY4OSw4
IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QK
ICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAgICAgICBwcmlu
dGsoVlREUFJFRklYICIlcGQ6UENJZTogbWFwICVwcFxuIiwKICAgICAgICAg
ICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZu
KSk7Ci0gICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25l
KGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIGRvbWFpbi0+
ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCisgICAgICAgIHJldCA9IGRvbWFpbl9j
b250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywg
ZGV2Zm4sIHBkZXYsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIERFVklDRV9ET01JRChkb21haW4sIHBkZXYpLCBwZ2RfbWFk
ZHIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IG1vZGUpOwogICAgICAgICBpZiAoIHJldCA+IDAgKQogICAgICAgICAgICAg
cmV0ID0gMDsKQEAgLTE2OTYsOCArMTcxMyw4IEBAIHN0YXRpYyBpbnQgZG9t
YWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgICAgICAg
ICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7CiAKICAg
ICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWlu
LCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgcGRldiwgZG9tYWluLT5kb21haW5f
aWQsIHBnZF9tYWRkciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHBkZXYsIERFVklDRV9ET01JRChkb21haW4sIHBk
ZXYpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBwZ2RfbWFkZHIsIG1vZGUpOwogICAgICAgICBpZiAoIHJldCA8IDAgKQog
ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIHByZXZfcHJlc2VudCA9IHJl
dDsKQEAgLTE3MjUsOCArMTc0Miw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2Nv
bnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICovCiAgICAgICAgIGlm
ICggcmV0ID49IDAgKQogICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRl
eHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZm
biwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIE5VTEwsIGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtb2Rl
KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIE5VTEwsIERFVklDRV9ET01JRChkb21haW4sIHBkZXYpLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGdkX21h
ZGRyLCBtb2RlKTsKIAogICAgICAgICAvKgogICAgICAgICAgKiBEZXZpY2Vz
IGJlaGluZCBQQ0llLXRvLVBDSS9QQ0l4IGJyaWRnZSBtYXkgZ2VuZXJhdGUg
ZGlmZmVyZW50CkBAIC0xNzQxLDggKzE3NTgsOCBAQCBzdGF0aWMgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgIGlmICggIXJl
dCAmJiBwZGV2X3R5cGUoc2VnLCBidXMsIGRldmZuKSA9PSBERVZfVFlQRV9Q
Q0llMlBDSV9CUklER0UgJiYKICAgICAgICAgICAgICAoc2VjYnVzICE9IHBk
ZXYtPmJ1cyB8fCBwZGV2LT5kZXZmbiAhPSAwKSApCiAgICAgICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQt
PmlvbW11LCBzZWNidXMsIDAsCi0gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBOVUxMLCBkb21haW4tPmRvbWFpbl9pZCwg
cGdkX21hZGRyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBOVUxMLCBERVZJQ0VfRE9NSUQoZG9tYWlu
LCBwZGV2KSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHBnZF9tYWRkciwgbW9kZSk7CiAKICAgICAgICAgaWYgKCBy
ZXQgKQogICAgICAgICB7CkBAIC0xODg5LDcgKzE5MDYsNyBAQCBzdGF0aWMg
Y29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkb21hCiAgICAgICAgICAg
ICBwcmludGsoVlREUFJFRklYICIlcGQ6UENJZTogdW5tYXAgJXBwXG4iLAog
ICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1
cywgZGV2Zm4pKTsKICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5t
YXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9p
ZCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBE
RVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7CiAgICAgICAgIGlmICggIXJl
dCAmJiBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBhdHNfZGV2aWNlKHBkZXYs
IGRyaGQpID4gMCApCiAgICAgICAgICAgICBkaXNhYmxlX2F0c19kZXZpY2Uo
cGRldik7CiAKQEAgLTE5MDAsNyArMTkxNyw3IEBAIHN0YXRpYyBjb25zdCBz
dHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRvbWEKICAgICAgICAgICAgIHByaW50
ayhWVERQUkVGSVggIiVwZDpQQ0k6IHVubWFwICVwcFxuIiwKICAgICAgICAg
ICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZu
KSk7CiAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShk
b21haW4sIGlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOworICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RP
TUlEKGRvbWFpbiwgcGRldikpOwogICAgICAgICBpZiAoIHJldCApCiAgICAg
ICAgICAgICBicmVhazsKIApAQCAtMTkyMywxOCArMTk0MCwxMiBAQCBzdGF0
aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkb21hCiAgICAgICAg
ICAgICBicmVhazsKICAgICAgICAgfQogCisgICAgICAgIHJldCA9IGRvbWFp
bl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0
bXBfZGV2Zm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7CiAgICAgICAgIC8q
IFBDSWUgdG8gUENJL1BDSXggYnJpZGdlICovCi0gICAgICAgIGlmICggcGRl
dl90eXBlKHNlZywgdG1wX2J1cywgdG1wX2RldmZuKSA9PSBERVZfVFlQRV9Q
Q0llMlBDSV9CUklER0UgKQotICAgICAgICB7Ci0gICAgICAgICAgICByZXQg
PSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgdG1w
X2J1cywgdG1wX2RldmZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKLSAgICAgICAg
ICAgIGlmICggIXJldCApCi0gICAgICAgICAgICAgICAgcmV0ID0gZG9tYWlu
X2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIHNlY2J1cywgMCwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgZG9tYWluLT5kb21haW5faWQpOwotICAgICAgICB9Ci0gICAgICAgIGVs
c2UgLyogTGVnYWN5IFBDSSBicmlkZ2UgKi8KLSAgICAgICAgICAgIHJldCA9
IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0bXBf
YnVzLCB0bXBfZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOworICAgICAgICBp
ZiAoICFyZXQgJiYgcGRldl90eXBlKHNlZywgdG1wX2J1cywgdG1wX2RldmZu
KSA9PSBERVZfVFlQRV9QQ0llMlBDSV9CUklER0UgKQorICAgICAgICAgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUs
IHNlY2J1cywgMCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7CiAKICAg
ICAgICAgYnJlYWs7CiAKQEAgLTE5NzcsNiArMTk4OCwyNiBAQCBzdGF0aWMg
dm9pZCBpb21tdV9kb21haW5fdGVhcmRvd24oc3RydWN0CiAgICAgICAgIGNs
ZWFudXBfZG9taWRfbWFwKGQtPmRvbWFpbl9pZCwgZHJoZC0+aW9tbXUpOwog
fQogCitzdGF0aWMgdm9pZCBxdWFyYW50aW5lX3RlYXJkb3duKHN0cnVjdCBw
Y2lfZGV2ICpwZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQpCit7CisgICAg
c3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZG9tX2lvKTsK
KworICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKKworICAgIGlmICgg
IXBkZXYtPmFyY2gudnRkLnBnZF9tYWRkciApCisgICAgICAgIHJldHVybjsK
KworICAgIEFTU0VSVChwYWdlX2xpc3RfZW1wdHkoJmhkLT5hcmNoLnBndGFi
bGVzLmxpc3QpKTsKKyAgICBwYWdlX2xpc3RfbW92ZSgmaGQtPmFyY2gucGd0
YWJsZXMubGlzdCwgJnBkZXYtPmFyY2gucGd0YWJsZXNfbGlzdCk7CisgICAg
d2hpbGUgKCBpb21tdV9mcmVlX3BndGFibGVzKGRvbV9pbykgPT0gLUVSRVNU
QVJUICkKKyAgICAgICAgLyogbm90aGluZyAqLzsKKyAgICBwZGV2LT5hcmNo
LnZ0ZC5wZ2RfbWFkZHIgPSAwOworCisgICAgaWYgKCBkcmhkICkKKyAgICAg
ICAgY2xlYW51cF9kb21pZF9tYXAocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQs
IGRyaGQtPmlvbW11KTsKK30KKwogc3RhdGljIGludCBfX211c3RfY2hlY2sg
aW50ZWxfaW9tbXVfbWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3Qg
ZGZuLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgbWZuX3QgbWZuLCB1bnNpZ25lZCBpbnQgZmxhZ3MsCiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25l
ZCBpbnQgKmZsdXNoX2ZsYWdzKQpAQCAtMjIwMSw2ICsyMjMyLDggQEAgc3Rh
dGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4CiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3MsIDAp
OwogICAgIH0KIAorICAgIHF1YXJhbnRpbmVfdGVhcmRvd24ocGRldiwgZHJo
ZCk7CisKICAgICBpZiAoIGRyaGQgKQogICAgIHsKICAgICAgICAgaW9tbXVf
ZnJlZV9kb21pZChwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwKQEAgLTI4OTYs
NjkgKzI5MjksMTM1IEBAIHN0YXRpYyB2b2lkIHZ0ZF9kdW1wX3BhZ2VfdGFi
bGVzKHN0cnVjdAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWdh
d190b19sZXZlbChoZC0+YXJjaC52dGQuYWdhdyksIDAsIDApOwogfQogCi1z
dGF0aWMgaW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFyYW50aW5lX2luaXQo
c3RydWN0IGRvbWFpbiAqZCkKK3N0YXRpYyBpbnQgZmlsbF9xcHQoc3RydWN0
IGRtYV9wdGUgKnRoaXMsIHVuc2lnbmVkIGludCBsZXZlbCwKKyAgICAgICAg
ICAgICAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGdzWzZdKQogewotICAg
IHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOworICAg
IHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbV9pbyk7
CisgICAgdW5zaWduZWQgaW50IGk7CisgICAgaW50IHJjID0gMDsKKworICAg
IGZvciAoIGkgPSAwOyAhcmMgJiYgaSA8IFBURV9OVU07ICsraSApCisgICAg
eworICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAqcHRlID0gJnRoaXNbaV0sICpu
ZXh0OworCisgICAgICAgIGlmICggIWRtYV9wdGVfcHJlc2VudCgqcHRlKSAp
CisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICggIXBnc1tsZXZlbF0gKQor
ICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIC8qCisgICAgICAgICAg
ICAgICAgICogVGhlIHBndGFibGUgYWxsb2NhdG9yIGlzIGZpbmUgZm9yIHRo
ZSBsZWFmIHBhZ2UsIGFzIHdlbGwgYXMKKyAgICAgICAgICAgICAgICAgKiBw
YWdlIHRhYmxlIHBhZ2VzLCBhbmQgdGhlIHJlc3VsdGluZyBhbGxvY2F0aW9u
cyBhcmUgYWx3YXlzCisgICAgICAgICAgICAgICAgICogemVyb2VkLgorICAg
ICAgICAgICAgICAgICAqLworICAgICAgICAgICAgICAgIHBnc1tsZXZlbF0g
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKKyAgICAgICAgICAgICAgICBp
ZiAoICFwZ3NbbGV2ZWxdICkKKyAgICAgICAgICAgICAgICB7CisgICAgICAg
ICAgICAgICAgICAgIHJjID0gLUVOT01FTTsKKyAgICAgICAgICAgICAgICAg
ICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAg
ICAgaWYgKCBsZXZlbCApCisgICAgICAgICAgICAgICAgeworICAgICAgICAg
ICAgICAgICAgICBuZXh0ID0gbWFwX3Z0ZF9kb21haW5fcGFnZShwYWdlX3Rv
X21hZGRyKHBnc1tsZXZlbF0pKTsKKyAgICAgICAgICAgICAgICAgICAgcmMg
PSBmaWxsX3FwdChuZXh0LCBsZXZlbCAtIDEsIHBncyk7CisgICAgICAgICAg
ICAgICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShuZXh0KTsKKyAgICAg
ICAgICAgICAgICB9CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGRt
YV9zZXRfcHRlX2FkZHIoKnB0ZSwgcGFnZV90b19tYWRkcihwZ3NbbGV2ZWxd
KSk7CisgICAgICAgICAgICBkbWFfc2V0X3B0ZV9yZWFkYWJsZSgqcHRlKTsK
KyAgICAgICAgICAgIGRtYV9zZXRfcHRlX3dyaXRhYmxlKCpwdGUpOworICAg
ICAgICB9CisgICAgICAgIGVsc2UgaWYgKCBsZXZlbCAmJiAhZG1hX3B0ZV9z
dXBlcnBhZ2UoKnB0ZSkgKQorICAgICAgICB7CisgICAgICAgICAgICBuZXh0
ID0gbWFwX3Z0ZF9kb21haW5fcGFnZShkbWFfcHRlX2FkZHIoKnB0ZSkpOwor
ICAgICAgICAgICAgcmMgPSBmaWxsX3FwdChuZXh0LCBsZXZlbCAtIDEsIHBn
cyk7CisgICAgICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UobmV4dCk7
CisgICAgICAgIH0KKyAgICB9CisKKyAgICByZXR1cm4gcmM7Cit9CisKK3N0
YXRpYyBpbnQgaW50ZWxfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBw
Y2lfZGV2ICpwZGV2KQoreworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhk
ID0gZG9tX2lvbW11KGRvbV9pbyk7CiAgICAgc3RydWN0IHBhZ2VfaW5mbyAq
cGc7Ci0gICAgc3RydWN0IGRtYV9wdGUgKnBhcmVudDsKICAgICB1bnNpZ25l
ZCBpbnQgYWdhdyA9IHdpZHRoX3RvX2FnYXcoREVGQVVMVF9ET01BSU5fQURE
UkVTU19XSURUSCk7CiAgICAgdW5zaWduZWQgaW50IGxldmVsID0gYWdhd190
b19sZXZlbChhZ2F3KTsKLSAgICBpbnQgcmMgPSAwOworICAgIGNvbnN0IHN0
cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZDsKKyAgICBjb25zdCBzdHJ1Y3Qg
YWNwaV9ybXJyX3VuaXQgKnJtcnI7CisgICAgdW5zaWduZWQgaW50IGksIGJk
ZjsKKyAgICBib29sIHJtcnJfZm91bmQgPSBmYWxzZTsKKyAgICBpbnQgcmM7
CiAKLSAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7Cisg
ICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOworICAgIEFTU0VSVCghaGQt
PmFyY2gudnRkLnBnZF9tYWRkcik7CisgICAgQVNTRVJUKHBhZ2VfbGlzdF9l
bXB0eSgmaGQtPmFyY2gucGd0YWJsZXMubGlzdCkpOwogCi0gICAgaWYgKCBo
ZC0+YXJjaC52dGQucGdkX21hZGRyICkKKyAgICBpZiAoIHBkZXYtPmFyY2gu
dnRkLnBnZF9tYWRkciApCiAgICAgewotICAgICAgICBBU1NFUlRfVU5SRUFD
SEFCTEUoKTsKLSAgICAgICAgZ290byBvdXQ7CisgICAgICAgIGNsZWFyX2Rv
bWFpbl9wYWdlKHBkZXYtPmFyY2gubGVhZl9tZm4pOworICAgICAgICByZXR1
cm4gMDsKICAgICB9CiAKLSAgICBwZyA9IGlvbW11X2FsbG9jX3BndGFibGUo
aGQpOworICAgIGRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQo
cGRldik7CisgICAgaWYgKCAhZHJoZCApCisgICAgICAgIHJldHVybiAtRU5P
REVWOwogCi0gICAgcmMgPSAtRU5PTUVNOworICAgIHBnID0gaW9tbXVfYWxs
b2NfcGd0YWJsZShoZCk7CiAgICAgaWYgKCAhcGcgKQotICAgICAgICBnb3Rv
IG91dDsKKyAgICAgICAgcmV0dXJuIC1FTk9NRU07CiAKKyAgICByYyA9IGNv
bnRleHRfc2V0X2RvbWFpbl9pZChOVUxMLCBwZGV2LT5hcmNoLnBzZXVkb19k
b21pZCwgZHJoZC0+aW9tbXUpOworCisgICAgLyogVHJhbnNpZW50bHkgaW5z
dGFsbCB0aGUgcm9vdCBpbnRvIERvbUlPLCBmb3IgaW9tbXVfaWRlbnRpdHlf
bWFwcGluZygpLiAqLwogICAgIGhkLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIgPSBw
YWdlX3RvX21hZGRyKHBnKTsKIAotICAgIHBhcmVudCA9IG1hcF92dGRfZG9t
YWluX3BhZ2UoaGQtPmFyY2gudnRkLnBnZF9tYWRkcik7Ci0gICAgd2hpbGUg
KCBsZXZlbCApCisgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2UgKCBybXJyLCBi
ZGYsIGkgKQogICAgIHsKLSAgICAgICAgdWludDY0X3QgbWFkZHI7Ci0gICAg
ICAgIHVuc2lnbmVkIGludCBvZmZzZXQ7Ci0KLSAgICAgICAgLyoKLSAgICAg
ICAgICogVGhlIHBndGFibGUgYWxsb2NhdG9yIGlzIGZpbmUgZm9yIHRoZSBs
ZWFmIHBhZ2UsIGFzIHdlbGwgYXMKLSAgICAgICAgICogcGFnZSB0YWJsZSBw
YWdlcywgYW5kIHRoZSByZXN1bHRpbmcgYWxsb2NhdGlvbnMgYXJlIGFsd2F5
cwotICAgICAgICAgKiB6ZXJvZWQuCi0gICAgICAgICAqLwotICAgICAgICBw
ZyA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOwotCi0gICAgICAgIGlmICgg
IXBnICkKLSAgICAgICAgICAgIGdvdG8gb3V0OworICAgICAgICBpZiAoIHJj
ICkKKyAgICAgICAgICAgIGJyZWFrOwogCi0gICAgICAgIG1hZGRyID0gcGFn
ZV90b19tYWRkcihwZyk7Ci0gICAgICAgIGZvciAoIG9mZnNldCA9IDA7IG9m
ZnNldCA8IFBURV9OVU07IG9mZnNldCsrICkKKyAgICAgICAgaWYgKCBybXJy
LT5zZWdtZW50ID09IHBkZXYtPnNlZyAmJiBiZGYgPT0gcGRldi0+c2JkZi5i
ZGYgKQogICAgICAgICB7Ci0gICAgICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAq
cHRlID0gJnBhcmVudFtvZmZzZXRdOworICAgICAgICAgICAgcm1ycl9mb3Vu
ZCA9IHRydWU7CiAKLSAgICAgICAgICAgIGRtYV9zZXRfcHRlX2FkZHIoKnB0
ZSwgbWFkZHIpOwotICAgICAgICAgICAgZG1hX3NldF9wdGVfcmVhZGFibGUo
KnB0ZSk7CisgICAgICAgICAgICByYyA9IGlvbW11X2lkZW50aXR5X21hcHBp
bmcoZG9tX2lvLCBwMm1fYWNjZXNzX3J3LAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmJhc2VfYWRkcmVzcywgcm1y
ci0+ZW5kX2FkZHJlc3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgMCk7CisgICAgICAgICAgICBpZiAoIHJjICkKKyAgICAg
ICAgICAgICAgICBwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgKKyAgICAg
ICAgICAgICAgICAgICAgICAgIiVwcDogUk1SUiBxdWFyYW50aW5lIG1hcHBp
bmcgZmFpbGVkXG4iLAorICAgICAgICAgICAgICAgICAgICAgICAmcGRldi0+
c2JkZik7CiAgICAgICAgIH0KLSAgICAgICAgaW9tbXVfc3luY19jYWNoZShw
YXJlbnQsIFBBR0VfU0laRSk7CisgICAgfQogCi0gICAgICAgIHVubWFwX3Z0
ZF9kb21haW5fcGFnZShwYXJlbnQpOwotICAgICAgICBwYXJlbnQgPSBtYXBf
dnRkX2RvbWFpbl9wYWdlKG1hZGRyKTsKLSAgICAgICAgbGV2ZWwtLTsKKyAg
ICBpb21tdV9pZGVudGl0eV9tYXBfdGVhcmRvd24oZG9tX2lvKTsKKyAgICBo
ZC0+YXJjaC52dGQucGdkX21hZGRyID0gMDsKKyAgICBwZGV2LT5hcmNoLnZ0
ZC5wZ2RfbWFkZHIgPSBwYWdlX3RvX21hZGRyKHBnKTsKKworICAgIGlmICgg
IXJjICkKKyAgICB7CisgICAgICAgIHN0cnVjdCBkbWFfcHRlICpyb290Owor
ICAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZ3NbNl0gPSB7fTsKKworICAg
ICAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CisKKyAg
ICAgICAgcm9vdCA9IG1hcF92dGRfZG9tYWluX3BhZ2UocGRldi0+YXJjaC52
dGQucGdkX21hZGRyKTsKKyAgICAgICAgcmMgPSBmaWxsX3FwdChyb290LCBs
ZXZlbCAtIDEsIHBncyk7CisgICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFn
ZShyb290KTsKKworICAgICAgICBwZGV2LT5hcmNoLmxlYWZfbWZuID0gcGFn
ZV90b19tZm4ocGdzWzBdKTsKKworICAgICAgICBzcGluX3VubG9jaygmaGQt
PmFyY2gubWFwcGluZ19sb2NrKTsKICAgICB9Ci0gICAgdW5tYXBfdnRkX2Rv
bWFpbl9wYWdlKHBhcmVudCk7CiAKLSAgICByYyA9IDA7CisgICAgcGFnZV9s
aXN0X21vdmUoJnBkZXYtPmFyY2gucGd0YWJsZXNfbGlzdCwgJmhkLT5hcmNo
LnBndGFibGVzLmxpc3QpOwogCi0gb3V0OgotICAgIHNwaW5fdW5sb2NrKCZo
ZC0+YXJjaC5tYXBwaW5nX2xvY2spOworICAgIGlmICggcmMgKQorICAgICAg
ICBxdWFyYW50aW5lX3RlYXJkb3duKHBkZXYsIGRyaGQpOwogCi0gICAgLyog
UGFnZXMgbWF5IGJlIGxlYWtlZCBpbiBmYWlsdXJlIGNhc2UgKi8KICAgICBy
ZXR1cm4gcmM7CiB9CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
dnRkL2lvbW11LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmgKQEAgLTUwOSw3ICs1MDksNyBAQCBzdHJ1Y3QgdnRkX2lvbW11
IHsKICAgICB1MzIgbnJfcHRfbGV2ZWxzOwogICAgIHU2NAljYXA7CiAgICAg
dTY0CWVjYXA7Ci0gICAgc3BpbmxvY2tfdCBsb2NrOyAvKiBwcm90ZWN0IGNv
bnRleHQsIGRvbWFpbiBpZHMgKi8KKyAgICBzcGlubG9ja190IGxvY2s7IC8q
IHByb3RlY3QgY29udGV4dCAqLwogICAgIHNwaW5sb2NrX3QgcmVnaXN0ZXJf
bG9jazsgLyogcHJvdGVjdCBpb21tdSByZWdpc3RlciBoYW5kbGluZyAqLwog
ICAgIHU2NCByb290X21hZGRyOyAvKiByb290IGVudHJ5IG1hY2hpbmUgYWRk
cmVzcyAqLwogICAgIG5vZGVpZF90IG5vZGU7Ci0tLSBhL3hlbi9pbmNsdWRl
L3hlbi9pb21tdS5oCisrKyBiL3hlbi9pbmNsdWRlL3hlbi9pb21tdS5oCkBA
IC0yMzQsNyArMjM0LDcgQEAgdHlwZWRlZiBpbnQgaW9tbXVfZ3JkbV90KHhl
bl9wZm5fdCBzdGFydAogc3RydWN0IGlvbW11X29wcyB7CiAgICAgaW50ICgq
aW5pdCkoc3RydWN0IGRvbWFpbiAqZCk7CiAgICAgdm9pZCAoKmh3ZG9tX2lu
aXQpKHN0cnVjdCBkb21haW4gKmQpOwotICAgIGludCAoKnF1YXJhbnRpbmVf
aW5pdCkoc3RydWN0IGRvbWFpbiAqZCk7CisgICAgaW50ICgqcXVhcmFudGlu
ZV9pbml0KShkZXZpY2VfdCAqZGV2KTsKICAgICBpbnQgKCphZGRfZGV2aWNl
KSh1OCBkZXZmbiwgZGV2aWNlX3QgKmRldik7CiAgICAgaW50ICgqZW5hYmxl
X2RldmljZSkoZGV2aWNlX3QgKmRldik7CiAgICAgaW50ICgqcmVtb3ZlX2Rl
dmljZSkodTggZGV2Zm4sIGRldmljZV90ICpkZXYpOwpAQCAtMzUyLDYgKzM1
Miw3IEBAIGludCBfX211c3RfY2hlY2sgaW9tbXVfc3VzcGVuZCh2b2lkKTsK
IHZvaWQgaW9tbXVfcmVzdW1lKHZvaWQpOwogdm9pZCBpb21tdV9jcmFzaF9z
aHV0ZG93bih2b2lkKTsKIGludCBpb21tdV9nZXRfcmVzZXJ2ZWRfZGV2aWNl
X21lbW9yeShpb21tdV9ncmRtX3QgKiwgdm9pZCAqKTsKK2ludCBpb21tdV9x
dWFyYW50aW5lX2Rldl9pbml0KGRldmljZV90ICpkZXYpOwogCiAjaWZkZWYg
Q09ORklHX0hBU19QQ0kKIGludCBpb21tdV9kb19wY2lfZG9tY3RsKHN0cnVj
dCB4ZW5fZG9tY3RsICosIHN0cnVjdCBkb21haW4gKmQsCg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-01.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-01.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggKGRlKWFzc2lnbiBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSB1cGRhdGVkLgoKQWxzbyBhZGp1c3QgYSByZWxhdGVk
IGxvZyBtZXNzYWdlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM1OCAvIHBhcnQg
b2YgWFNBLTQwMC4KCkZpeGVzOiA4Yjk5ZjQ0MDBiNjkgKCJWVC1kOiBmaXgg
Uk1SUiByZWxhdGVkIGVycm9yIGhhbmRsaW5nIikKU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog
Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+ClJldmll
d2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KUmV2aWV3ZWQt
Ynk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgoKLS0tIGEv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAgLTI0MTksNiAr
MjQxOSwxMCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNo
aXAoCiB7CiAgICAgaW50IHJldDsKIAorICAgIHJldCA9IGRvbWFpbl9jb250
ZXh0X3VubWFwKHNvdXJjZSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0
ICkKKyAgICAgICAgcmV0dXJuIHJldDsKKwogICAgIC8qCiAgICAgICogRGV2
aWNlcyBhc3NpZ25lZCB0byB1bnRydXN0ZWQgZG9tYWlucyAoaGVyZSBhc3N1
bWVkIHRvIGJlIGFueSBkb21VKQogICAgICAqIGNhbiBhdHRlbXB0IHRvIHNl
bmQgYXJiaXRyYXJ5IExBUElDL01TSSBtZXNzYWdlcy4gV2UgYXJlIHVucHJv
dGVjdGVkCkBAIC0yNDU1LDEwICsyNDU5LDYgQEAgc3RhdGljIGludCByZWFz
c2lnbl9kZXZpY2Vfb3duZXJzaGlwKAogICAgICAgICAgICAgfQogICAgIH0K
IAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHNvdXJjZSwgZGV2
Zm4sIHBkZXYpOwotICAgIGlmICggcmV0ICkKLSAgICAgICAgcmV0dXJuIHJl
dDsKLQogICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+
ZG9tYWluICE9IGRvbV9pbyApCiAgICAgewogICAgICAgICBsaXN0X21vdmUo
JnBkZXYtPmRvbWFpbl9saXN0LCAmZG9tX2lvLT5wZGV2X2xpc3QpOwpAQCAt
MjUzNCw5ICsyNTM0LDggQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hc3Np
Z25fZGV2aWNlKAogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0ID0gcmVh
c3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7Ci0g
ICAgaWYgKCByZXQgfHwgZCA9PSBkb21faW8gKQotICAgICAgICByZXR1cm4g
cmV0OworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm4g
cmVhc3NpZ25fZGV2aWNlX293bmVyc2hpcChzLCBkLCBkZXZmbiwgcGRldik7
CiAKICAgICAvKiBTZXR1cCBybXJyIGlkZW50aXR5IG1hcHBpbmcgKi8KICAg
ICBmb3JfZWFjaF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBpICkKQEAgLTI1
NDksMjAgKzI1NDgsMzcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hc3Np
Z25fZGV2aWNlKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgZmxhZyk7CiAgICAgICAgICAg
ICBpZiAoIHJldCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAg
aW50IHJjOwotCi0gICAgICAgICAgICAgICAgcmMgPSByZWFzc2lnbl9kZXZp
Y2Vfb3duZXJzaGlwKGQsIHMsIGRldmZuLCBwZGV2KTsKICAgICAgICAgICAg
ICAgICBwcmludGsoWEVOTE9HX0dfRVJSIFZURFBSRUZJWAotICAgICAgICAg
ICAgICAgICAgICAgICAiIGNhbm5vdCBtYXAgcmVzZXJ2ZWQgcmVnaW9uICgl
IlBSSXg2NCIsJSJQUkl4NjQiXSBmb3IgRG9tJWQgKCVkKVxuIiwKLSAgICAg
ICAgICAgICAgICAgICAgICAgcm1yci0+YmFzZV9hZGRyZXNzLCBybXJyLT5l
bmRfYWRkcmVzcywKLSAgICAgICAgICAgICAgICAgICAgICAgZC0+ZG9tYWlu
X2lkLCByZXQpOwotICAgICAgICAgICAgICAgIGlmICggcmMgKQotICAgICAg
ICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlIgVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAi
IGZhaWxlZCB0byByZWNsYWltICVwcCBmcm9tICVwZCAoJWQpXG4iLAotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGMyhzZWcsIGJ1cywg
ZGV2Zm4pLCBkLCByYyk7Ci0gICAgICAgICAgICAgICAgICAgIGRvbWFpbl9j
cmFzaChkKTsKLSAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAg
ICAgICAgICIlcGQ6IGNhbm5vdCBtYXAgcmVzZXJ2ZWQgcmVnaW9uIFslIlBS
SXg2NCIsJSJQUkl4NjQiXTogJWRcbiIsCisgICAgICAgICAgICAgICAgICAg
ICAgIGQsIHJtcnItPmJhc2VfYWRkcmVzcywgcm1yci0+ZW5kX2FkZHJlc3Ms
IHJldCk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9
CisgICAgICAgIH0KKyAgICB9CisKKyAgICBpZiAoICFyZXQgKQorICAgICAg
ICByZXQgPSByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlwKHMsIGQsIGRldmZu
LCBwZGV2KTsKKworICAgIC8qIFNlZSByZWFzc2lnbl9kZXZpY2Vfb3duZXJz
aGlwKCkgZm9yIHRoZSBod2RvbSBhc3BlY3QuICovCisgICAgaWYgKCAhcmV0
IHx8IGlzX2hhcmR3YXJlX2RvbWFpbihkKSApCisgICAgICAgIHJldHVybiBy
ZXQ7CisKKyAgICBmb3JfZWFjaF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBp
ICkKKyAgICB7CisgICAgICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBzZWcg
JiYKKyAgICAgICAgICAgICBQQ0lfQlVTKGJkZikgPT0gYnVzICYmCisgICAg
ICAgICAgICAgUENJX0RFVkZOMihiZGYpID09IGRldmZuICkKKyAgICAgICAg
eworICAgICAgICAgICAgaW50IHJjID0gaW9tbXVfaWRlbnRpdHlfbWFwcGlu
ZyhkLCBwMm1fYWNjZXNzX3gsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHJtcnItPmJhc2VfYWRkcmVzcywKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+
ZW5kX2FkZHJlc3MsIDApOworCisgICAgICAgICAgICBpZiAoIHJjICYmIHJj
ICE9IC1FTk9FTlQgKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg
IHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWAorICAgICAgICAgICAgICAg
ICAgICAgICAiJXBkOiBjYW5ub3QgdW5tYXAgcmVzZXJ2ZWQgcmVnaW9uIFsl
IlBSSXg2NCIsJSJQUkl4NjQiXTogJWRcbiIsCisgICAgICAgICAgICAgICAg
ICAgICAgIGQsIHJtcnItPmJhc2VfYWRkcmVzcywgcm1yci0+ZW5kX2FkZHJl
c3MsIHJjKTsKKyAgICAgICAgICAgICAgICBkb21haW5fY3Jhc2goZCk7CiAg
ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAg
IH0K

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-02.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-02.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggYWRkL3JlbW92ZSBvcmRlcmluZyB3aGVuIFJNUlJzIGFy
ZSBpbiB1c2UKCkluIHRoZSBldmVudCB0aGF0IHRoZSBSTVJSIG1hcHBpbmdz
IGFyZSBlc3NlbnRpYWwgZm9yIGRldmljZSBvcGVyYXRpb24sCnRoZXkgc2hv
dWxkIGJlIGVzdGFibGlzaGVkIGJlZm9yZSB1cGRhdGluZyB0aGUgZGV2aWNl
J3MgY29udGV4dCBlbnRyeSwKd2hpbGUgdGhleSBzaG91bGQgYmUgdG9ybiBk
b3duIG9ubHkgYWZ0ZXIgdGhlIGRldmljZSdzIGNvbnRleHQgZW50cnkgd2Fz
CnN1Y2Nlc3NmdWxseSBjbGVhcmVkLgoKQWxzbyBzd2l0Y2ggdG8gJXBkIGlu
IHJlbGF0ZWQgbG9nIG1lc3NhZ2VzLgoKRml4ZXM6IGZhODhjZmFkZjkxOCAo
InZ0LWQ6IE1hcCBSTVJSIGluIGludGVsX2lvbW11X2FkZF9kZXZpY2UoKSBp
ZiB0aGUgZGV2aWNlIGhhcyBSTVJSIikKRml4ZXM6IDhiOTlmNDQwMGI2OSAo
IlZULWQ6IGZpeCBSTVJSIHJlbGF0ZWQgZXJyb3IgaGFuZGxpbmciKQpTaWdu
ZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJl
dmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4
LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50
ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmMKQEAgLTE5OTcsMTQgKzE5OTcsNiBAQCBzdGF0aWMgaW50IGludGVsX2lv
bW11X2FkZF9kZXZpY2UodTggZGV2CiAgICAgaWYgKCAhcGRldi0+ZG9tYWlu
ICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CiAKLSAgICByZXQgPSBkb21h
aW5fY29udGV4dF9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYp
OwotICAgIGlmICggcmV0ICkKLSAgICB7Ci0gICAgICAgIGRwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgsICJkJWQ6IGNvbnRleHQgbWFwcGluZyBmYWls
ZWRcbiIsCi0gICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluLT5kb21haW5f
aWQpOwotICAgICAgICByZXR1cm4gcmV0OwotICAgIH0KLQogICAgIGZvcl9l
YWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKICAgICB7CiAgICAg
ICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBwZGV2LT5zZWcgJiYKQEAgLTIw
MjEsMTIgKzIwMTMsMTcgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hZGRf
ZGV2aWNlKHU4IGRldgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRy
ZXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAwKTsKICAgICAgICAgICAgIGlmICggcmV0ICkKLSAgICAgICAgICAgICAg
ICBkcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiZCVkOiBSTVJSIG1h
cHBpbmcgZmFpbGVkXG4iLAotICAgICAgICAgICAgICAgICAgICAgICAgcGRl
di0+ZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAgICAgIGRwcmlu
dGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IFJNUlIgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LT5kb21h
aW4pOwogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuIDA7CisgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZyhwZGV2LT5kb21haW4sIGRl
dmZuLCBwZGV2KTsKKyAgICBpZiAoIHJldCApCisgICAgICAgIGRwcmludGso
WEVOTE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6IGNvbnRleHQgbWFwcGluZyBm
YWlsZWRcbiIsCisgICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluKTsKKwor
ICAgIHJldHVybiByZXQ7CiB9CiAKIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVf
ZW5hYmxlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRldikKQEAgLTIwNDgs
MTEgKzIwNDUsMTUgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVf
ZGV2aWNlKHU4CiB7CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJy
OwogICAgIHUxNiBiZGY7Ci0gICAgaW50IGk7CisgICAgaW50IHJldCwgaTsK
IAogICAgIGlmICggIXBkZXYtPmRvbWFpbiApCiAgICAgICAgIHJldHVybiAt
RUlOVkFMOwogCisgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAocGRl
di0+ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgaWYgKCByZXQgKQorICAg
ICAgICByZXR1cm4gcmV0OworCiAgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2Ug
KCBybXJyLCBiZGYsIGkgKQogICAgIHsKICAgICAgICAgaWYgKCBybXJyLT5z
ZWdtZW50ICE9IHBkZXYtPnNlZyB8fApAQCAtMjA2OCw3ICsyMDY5LDcgQEAg
c3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4CiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3Ms
IDApOwogICAgIH0KIAotICAgIHJldHVybiBkb21haW5fY29udGV4dF91bm1h
cChwZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKKyAgICByZXR1cm4gMDsK
IH0KIAogc3RhdGljIGludCBfX2h3ZG9tX2luaXQgc2V0dXBfaHdkb21fZGV2
aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-03.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHRpZ2h0ZW4gaW9tbXVfYWxsb2NfcGd0YWJsZSgpJ3Mg
cGFyYW1ldGVyCgpUaGlzIGlzIHRvIG1ha2UgbW9yZSBvYnZpb3VzIHRoYXQg
bm90aGluZyBvdXRzaWRlIG9mIGRvbWFpbl9pb21tdShkKQphY3R1YWxseSBj
aGFuZ2VzIG9yIGlzIG90aGVyd2lzZSBuZWVkZWQgYnkgdGhlIGZ1bmN0aW9u
LgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UgaW50ZW5kZWQuCgpTaWduZWQtb2Zm
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
UmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZp
ZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+Cgot
LS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKKysrIGIveGVuL2lu
Y2x1ZGUvYXNtLXg4Ni9pb21tdS5oCkBAIC0xNDIsNyArMTQyLDggQEAgaW50
IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9kZXNjCiB9KQogCiBp
bnQgX19tdXN0X2NoZWNrIGlvbW11X2ZyZWVfcGd0YWJsZXMoc3RydWN0IGRv
bWFpbiAqZCk7Ci1zdHJ1Y3QgcGFnZV9pbmZvICpfX211c3RfY2hlY2sgaW9t
bXVfYWxsb2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluICpkKTsKK3N0cnVjdCBk
b21haW5faW9tbXU7CitzdHJ1Y3QgcGFnZV9pbmZvICpfX211c3RfY2hlY2sg
aW9tbXVfYWxsb2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCk7
CiAKICNlbmRpZiAvKiAhX19BUkNIX1g4Nl9JT01NVV9IX18gKi8KIC8qCi0t
LSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYwor
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMK
QEAgLTE4NCw3ICsxODQsNyBAQCBzdGF0aWMgaW50IGlvbW11X3BkZV9mcm9t
X2RmbihzdHJ1Y3QgZG9tCiAgICAgdW5zaWduZWQgbG9uZyAgbmV4dF90YWJs
ZV9tZm47CiAgICAgdW5zaWduZWQgaW50IGxldmVsOwogICAgIHN0cnVjdCBw
YWdlX2luZm8gKnRhYmxlOwotICAgIGNvbnN0IHN0cnVjdCBkb21haW5faW9t
bXUgKmhkID0gZG9tX2lvbW11KGQpOworICAgIHN0cnVjdCBkb21haW5faW9t
bXUgKmhkID0gZG9tX2lvbW11KGQpOwogCiAgICAgdGFibGUgPSBoZC0+YXJj
aC5hbWQucm9vdF90YWJsZTsKICAgICBsZXZlbCA9IGhkLT5hcmNoLmFtZC5w
YWdpbmdfbW9kZTsKQEAgLTIxOSw3ICsyMTksNyBAQCBzdGF0aWMgaW50IGlv
bW11X3BkZV9mcm9tX2RmbihzdHJ1Y3QgZG9tCiAgICAgICAgICAgICBtZm4g
PSBuZXh0X3RhYmxlX21mbjsKIAogICAgICAgICAgICAgLyogYWxsb2NhdGUg
bG93ZXIgbGV2ZWwgcGFnZSB0YWJsZSAqLwotICAgICAgICAgICAgdGFibGUg
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICAgICAgdGFibGUg
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKICAgICAgICAgICAgIGlmICgg
dGFibGUgPT0gTlVMTCApCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAg
ICAgQU1EX0lPTU1VX0VSUk9SKCJjYW5ub3QgYWxsb2NhdGUgSS9PIHBhZ2Ug
dGFibGVcbiIpOwpAQCAtMjQ5LDcgKzI0OSw3IEBAIHN0YXRpYyBpbnQgaW9t
bXVfcGRlX2Zyb21fZGZuKHN0cnVjdCBkb20KIAogICAgICAgICAgICAgaWYg
KCBuZXh0X3RhYmxlX21mbiA9PSAwICkKICAgICAgICAgICAgIHsKLSAgICAg
ICAgICAgICAgICB0YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUoZCk7Cisg
ICAgICAgICAgICAgICAgdGFibGUgPSBpb21tdV9hbGxvY19wZ3RhYmxlKGhk
KTsKICAgICAgICAgICAgICAgICBpZiAoIHRhYmxlID09IE5VTEwgKQogICAg
ICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAgICAgQU1EX0lPTU1V
X0VSUk9SKCJjYW5ub3QgYWxsb2NhdGUgSS9PIHBhZ2UgdGFibGVcbiIpOwpA
QCAtNTUzLDcgKzU1Myw3IEBAIGludCBfX2luaXQgYW1kX2lvbW11X3F1YXJh
bnRpbmVfaW5pdChzdHIKIAogICAgIHNwaW5fbG9jaygmaGQtPmFyY2gubWFw
cGluZ19sb2NrKTsKIAotICAgIGhkLT5hcmNoLmFtZC5yb290X3RhYmxlID0g
aW9tbXVfYWxsb2NfcGd0YWJsZShkKTsKKyAgICBoZC0+YXJjaC5hbWQucm9v
dF90YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOwogICAgIGlmICgg
IWhkLT5hcmNoLmFtZC5yb290X3RhYmxlICkKICAgICAgICAgZ290byBvdXQ7
CiAKQEAgLTU2OCw3ICs1NjgsNyBAQCBpbnQgX19pbml0IGFtZF9pb21tdV9x
dWFyYW50aW5lX2luaXQoc3RyCiAgICAgICAgICAqIHBhZ2UgdGFibGUgcGFn
ZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMK
ICAgICAgICAgICogemVyb2VkLgogICAgICAgICAgKi8KLSAgICAgICAgcGcg
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICBwZyA9IGlvbW11
X2FsbG9jX3BndGFibGUoaGQpOwogICAgICAgICBpZiAoICFwZyApCiAgICAg
ICAgICAgICBicmVhazsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC9hbWQvcGNpX2FtZF9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11LmMKQEAgLTI0Miw3ICsyNDIsNyBA
QCBpbnQgYW1kX2lvbW11X2FsbG9jX3Jvb3Qoc3RydWN0IGRvbWFpbiAqCiAK
ICAgICBpZiAoIHVubGlrZWx5KCFoZC0+YXJjaC5hbWQucm9vdF90YWJsZSkg
KQogICAgIHsKLSAgICAgICAgaGQtPmFyY2guYW1kLnJvb3RfdGFibGUgPSBp
b21tdV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICBoZC0+YXJjaC5hbWQu
cm9vdF90YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOwogICAgICAg
ICBpZiAoICFoZC0+YXJjaC5hbWQucm9vdF90YWJsZSApCiAgICAgICAgICAg
ICByZXR1cm4gLUVOT01FTTsKICAgICB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCkBAIC0zMzAsNyArMzMwLDcgQEAgc3RhdGlj
IHU2NCBhZGRyX3RvX2RtYV9wYWdlX21hZGRyKHN0cnVjdAogICAgIHsKICAg
ICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7CiAKLSAgICAgICAgaWYgKCAh
YWxsb2MgfHwgIShwZyA9IGlvbW11X2FsbG9jX3BndGFibGUoZG9tYWluKSkg
KQorICAgICAgICBpZiAoICFhbGxvYyB8fCAhKHBnID0gaW9tbXVfYWxsb2Nf
cGd0YWJsZShoZCkpICkKICAgICAgICAgICAgIGdvdG8gb3V0OwogCiAgICAg
ICAgIGhkLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIgPSBwYWdlX3RvX21hZGRyKHBn
KTsKQEAgLTM1MCw3ICszNTAsNyBAQCBzdGF0aWMgdTY0IGFkZHJfdG9fZG1h
X3BhZ2VfbWFkZHIoc3RydWN0CiAgICAgICAgICAgICBpZiAoICFhbGxvYyAp
CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgICAgIHBnID0g
aW9tbXVfYWxsb2NfcGd0YWJsZShkb21haW4pOworICAgICAgICAgICAgcGcg
PSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKICAgICAgICAgICAgIGlmICgg
IXBnICkKICAgICAgICAgICAgICAgICBicmVhazsKIApAQCAtMjc2Niw3ICsy
NzY2LDcgQEAgc3RhdGljIGludCBfX2luaXQgaW50ZWxfaW9tbXVfcXVhcmFu
dGluZQogICAgICAgICBnb3RvIG91dDsKICAgICB9CiAKLSAgICBwZyA9IGlv
bW11X2FsbG9jX3BndGFibGUoZCk7CisgICAgcGcgPSBpb21tdV9hbGxvY19w
Z3RhYmxlKGhkKTsKIAogICAgIHJjID0gLUVOT01FTTsKICAgICBpZiAoICFw
ZyApCkBAIC0yNzg1LDcgKzI3ODUsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBp
bnRlbF9pb21tdV9xdWFyYW50aW5lCiAgICAgICAgICAqIHBhZ2UgdGFibGUg
cGFnZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdh
eXMKICAgICAgICAgICogemVyb2VkLgogICAgICAgICAgKi8KLSAgICAgICAg
cGcgPSBpb21tdV9hbGxvY19wZ3RhYmxlKGQpOworICAgICAgICBwZyA9IGlv
bW11X2FsbG9jX3BndGFibGUoaGQpOwogCiAgICAgICAgIGlmICggIXBnICkK
ICAgICAgICAgICAgIGdvdG8gb3V0OwotLS0gYS94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC94ODYvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC94ODYvaW9tbXUuYwpAQCAtNDE2LDkgKzQxNiw4IEBAIGludCBpb21t
dV9mcmVlX3BndGFibGVzKHN0cnVjdCBkb21haW4gKmQKICAgICByZXR1cm4g
MDsKIH0KIAotc3RydWN0IHBhZ2VfaW5mbyAqaW9tbXVfYWxsb2NfcGd0YWJs
ZShzdHJ1Y3QgZG9tYWluICpkKQorc3RydWN0IHBhZ2VfaW5mbyAqaW9tbXVf
YWxsb2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCkKIHsKLSAg
ICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKICAg
ICB1bnNpZ25lZCBpbnQgbWVtZmxhZ3MgPSAwOwogICAgIHN0cnVjdCBwYWdl
X2luZm8gKnBnOwogICAgIHZvaWQgKnA7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-04.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBkcm9wIG93bmVyc2hpcCBjaGVja2luZyBmcm9tIGRvbWFpbl9j
b250ZXh0X21hcHBpbmdfb25lKCkKCkRlc3BpdGUgcHV0dGluZyBpbiBxdWl0
ZSBhIGJpdCBvZiBlZmZvcnQgaXQgd2FzIG5vdCBwb3NzaWJsZSB0bwplc3Rh
Ymxpc2ggd2h5IGV4YWN0bHkgdGhpcyBjb2RlIGV4aXN0cyAoYmV5b25kIHBv
c3NpYmx5IHNhbml0eQpjaGVja2luZykuIEluc3RlYWQgb2YgYSBzdWJzZXF1
ZW50IGNoYW5nZSBmdXJ0aGVyIGNvbXBsaWNhdGluZyB0aGlzCmxvZ2ljLCBz
aW1wbHkgZ2V0IHJpZCBvZiBpdC4KClRha2UgdGhlIG9wcG9ydHVuaXR5IGFu
ZCBtb3ZlIHRoZSByZXNwZWN0aXZlIHVubWFwX3Z0ZF9kb21haW5fcGFnZSgp
IG91dApvZiB0aGUgbG9ja2VkIHJlZ2lvbi4KClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdl
ZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5
OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KCi0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCkBAIC0xMjQsMjggKzEy
NCw2IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVj
dAogICAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGNvbnRleHRfZ2V0
X2RvbWFpbl9pZChzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4dCwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQotewotICAgIHVuc2lnbmVkIGxvbmcgZG9tX2luZGV4LCBu
cl9kb207Ci0gICAgaW50IGRvbWlkID0gLTE7Ci0KLSAgICBpZiAoaW9tbXUg
JiYgY29udGV4dCkKLSAgICB7Ci0gICAgICAgIG5yX2RvbSA9IGNhcF9uZG9t
cyhpb21tdS0+Y2FwKTsKLQotICAgICAgICBkb21faW5kZXggPSBjb250ZXh0
X2RvbWFpbl9pZCgqY29udGV4dCk7Ci0KLSAgICAgICAgaWYgKCBkb21faW5k
ZXggPCBucl9kb20gJiYgaW9tbXUtPmRvbWlkX21hcCApCi0gICAgICAgICAg
ICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbZG9tX2luZGV4XTsKLSAgICAg
ICAgZWxzZQotICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfREVCVUcgVlRE
UFJFRklYLAotICAgICAgICAgICAgICAgICAgICAiZG9tX2luZGV4ICVsdSBl
eGNlZWRzIG5yX2RvbSAlbHUgb3IgaW9tbXUgaGFzIG5vIGRvbWlkX21hcFxu
IiwKLSAgICAgICAgICAgICAgICAgICAgZG9tX2luZGV4LCBucl9kb20pOwot
ICAgIH0KLSAgICByZXR1cm4gZG9taWQ7Ci19Ci0KIHN0YXRpYyB2b2lkIGNs
ZWFudXBfZG9taWRfbWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXUpCiB7CiAgICAgaW50IGlvbW11X2RvbWlkID0g
ZG9tYWluX2lvbW11X2RvbWlkKGRvbWFpbiwgaW9tbXUpOwpAQCAtMTQxNiw0
NCArMTM5NCw5IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgK
IAogICAgIGlmICggY29udGV4dF9wcmVzZW50KCpjb250ZXh0KSApCiAgICAg
ewotICAgICAgICBpbnQgcmVzID0gMDsKLQotICAgICAgICAvKiBUcnkgdG8g
Z2V0IGRvbWFpbiBvd25lcnNoaXAgZnJvbSBkZXZpY2Ugc3RydWN0dXJlLiAg
SWYgdGhhdCdzCi0gICAgICAgICAqIG5vdCBhdmFpbGFibGUsIHRyeSB0byBy
ZWFkIGl0IGZyb20gdGhlIGNvbnRleHQgaXRzZWxmLiAqLwotICAgICAgICBp
ZiAoIHBkZXYgKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIHBkZXYt
PmRvbWFpbiAhPSBkb21haW4gKQotICAgICAgICAgICAgewotICAgICAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfR19JTkZPIFZURFBSRUZJWCAiJXBkOiAl
cHAgb3duZWQgYnkgJXBkIiwKLSAgICAgICAgICAgICAgICAgICAgICAgZG9t
YWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbiksCi0gICAgICAgICAg
ICAgICAgICAgICAgIHBkZXYtPmRvbWFpbik7Ci0gICAgICAgICAgICAgICAg
cmVzID0gLUVJTlZBTDsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfQotICAg
ICAgICBlbHNlCi0gICAgICAgIHsKLSAgICAgICAgICAgIGludCBjZG9tYWlu
OwotICAgICAgICAgICAgY2RvbWFpbiA9IGNvbnRleHRfZ2V0X2RvbWFpbl9p
ZChjb250ZXh0LCBpb21tdSk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAg
IGlmICggY2RvbWFpbiA8IDAgKQotICAgICAgICAgICAgewotICAgICAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HIFZURFBSRUZJWAotICAg
ICAgICAgICAgICAgICAgICAgICAiJXBkOiAlcHAgbWFwcGVkLCBidXQgY2Fu
J3QgZmluZCBvd25lclxuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgZG9t
YWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbikpOwotICAgICAgICAg
ICAgICAgIHJlcyA9IC1FSU5WQUw7Ci0gICAgICAgICAgICB9Ci0gICAgICAg
ICAgICBlbHNlIGlmICggY2RvbWFpbiAhPSBkb21haW4tPmRvbWFpbl9pZCAp
Ci0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19HX0lORk8gVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICIl
cGQ6ICVwcCBhbHJlYWR5IG1hcHBlZCB0byBkJWQiLAotICAgICAgICAgICAg
ICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZu
KSwgY2RvbWFpbik7Ci0gICAgICAgICAgICAgICAgcmVzID0gLUVJTlZBTDsK
LSAgICAgICAgICAgIH0KLSAgICAgICAgfQotCi0gICAgICAgIHVubWFwX3Z0
ZF9kb21haW5fcGFnZShjb250ZXh0X2VudHJpZXMpOwogICAgICAgICBzcGlu
X3VubG9jaygmaW9tbXUtPmxvY2spOwotICAgICAgICByZXR1cm4gcmVzOwor
ICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVz
KTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCiAgICAgaWYgKCBpb21t
dV9od2RvbV9wYXNzdGhyb3VnaCAmJiBpc19oYXJkd2FyZV9kb21haW4oZG9t
YWluKSApCg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-05.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiByZS1hc3NpZ24gZGV2aWNlcyBkaXJlY3RseQoKRGV2aWNlcyB3
aXRoIFJNUlJzLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQgaG93L3do
ZW4gdGhlIHNwZWNpZmllZAptZW1vcnkgcmVnaW9ucyBtYXkgZ2V0IGFjY2Vz
c2VkLCBtYXkgbm90IGJlIGxlZnQgZGlzY29ubmVjdGVkIGZyb20gdGhlaXIK
cmVzcGVjdGl2ZSBtYXBwaW5ncyAoYXMgbG9uZyBhcyBpdCdzIG5vdCBjZXJ0
YWluIHRoYXQgdGhlIGRldmljZSBoYXMKYmVlbiBmdWxseSBxdWllc2NlZCku
IEhlbmNlIHJhdGhlciB0aGFuIHVubWFwcGluZyB0aGUgb2xkIGNvbnRleHQg
YW5kCnRoZW4gbWFwcGluZyB0aGUgbmV3IG9uZSwgcmUtYXNzaWdubWVudCBu
ZWVkcyB0byBiZSBkb25lIGluIGEgc2luZ2xlCnN0ZXAuCgpUaGlzIGlzIENW
RS0yMDIyLTI2MzU5IC8gcGFydCBvZiBYU0EtNDAwLgoKUmVwb3J0ZWQtYnk6
IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKU2lt
aWxhcmx5IHF1YXJhbnRpbmluZyBzY3JhdGNoLXBhZ2UgbW9kZSByZWxpZXMg
b24gcGFnZSB0YWJsZXMgdG8gYmUKY29udGludW91c2x5IHdpcmVkIHVwLgoK
VG8gYXZvaWQgY29tcGxpY2F0aW5nIHRoaW5ncyBtb3JlIHRoYW4gbmVjZXNz
YXJ5LCB0cmVhdCBhbGwgZGV2aWNlcwptb3N0bHkgZXF1YWxseSwgaS5lLiBy
ZWdhcmRsZXNzIG9mIHRoZWlyIGFzc29jaWF0aW9uIHdpdGggYW55IFJNUlJz
LiBUaGUKbWFpbiBkaWZmZXJlbmNlIGlzIHdoZW4gaXQgY29tZXMgdG8gdXBk
YXRpbmcgY29udGV4dCBlbnRyaWVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21p
YyB3aGVuIHRoZXJlIGFyZSBSTVJScy4gWWV0IGF0b21pY2l0eSBjYW4gb25s
eSBiZSBhY2hpZXZlZAp3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBv
ZiB3aGljaCB3ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClRoZSBzZWVtaW5n
bHkgY29tcGxpY2F0ZWQgY2hvaWNlIG9mIG5vbi1uZWdhdGl2ZSByZXR1cm4g
dmFsdWVzIGZvcgpkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgpIGlzIHRv
IGxpbWl0IGNvZGUgY2h1cm46IFRoaXMgd2F5IGNhbGxlcnMKcGFzc2luZyBO
VUxMIGZvciBwZGV2IGRvbid0IG5lZWQgZmlkZGxpbmcgd2l0aC4KClNpZ25l
ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2
aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgpS
ZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp
eC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZXh0
ZXJuLmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2V4dGVy
bi5oCkBAIC04NCw3ICs4NCw4IEBAIHZvaWQgZnJlZV9wZ3RhYmxlX21hZGRy
KHU2NCBtYWRkcik7CiB2b2lkICptYXBfdnRkX2RvbWFpbl9wYWdlKHU2NCBt
YWRkcik7CiB2b2lkIHVubWFwX3Z0ZF9kb21haW5fcGFnZShjb25zdCB2b2lk
ICp2YSk7CiBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoc3RydWN0
IGRvbWFpbiAqZG9tYWluLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1OCBidXMsIHU4IGRldmZu
LCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqKTsKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB1aW50OF90IGJ1cywgdWludDhfdCBkZXZmbiwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNp
X2RldiAqcGRldiwgdW5zaWduZWQgaW50IG1vZGUpOwogaW50IGRvbWFpbl9j
b250ZXh0X3VubWFwX29uZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVj
dCB2dGRfaW9tbXUgKmlvbW11LAogICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB1OCBidXMsIHU4IGRldmZuKTsKIGludCBpbnRlbF9pb21tdV9nZXRf
cmVzZXJ2ZWRfZGV2aWNlX21lbW9yeShpb21tdV9ncmRtX3QgKmZ1bmMsIHZv
aWQgKmN0eHQpOwpAQCAtMTA0LDggKzEwNSw4IEBAIGJvb2wgaXNfYXphbGlh
X3RsYl9lbmFibGVkKGNvbnN0IHN0cnVjdAogdm9pZCBwbGF0Zm9ybV9xdWly
a3NfaW5pdCh2b2lkKTsKIHZvaWQgdnRkX29wc19wcmVhbWJsZV9xdWlyayhz
dHJ1Y3QgdnRkX2lvbW11ICppb21tdSk7CiB2b2lkIHZ0ZF9vcHNfcG9zdGFt
YmxlX3F1aXJrKHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KTsKLWludCBfX211
c3RfY2hlY2sgbWVfd2lmaV9xdWlyayhzdHJ1Y3QgZG9tYWluICpkb21haW4s
Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdTggYnVzLCB1OCBk
ZXZmbiwgaW50IG1hcCk7CitpbnQgX19tdXN0X2NoZWNrIG1lX3dpZmlfcXVp
cmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLCB1aW50OF90IGJ1cywKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50OF90IGRldmZuLCB1bnNp
Z25lZCBpbnQgbW9kZSk7CiB2b2lkIHBjaV92dGRfcXVpcmsoY29uc3Qgc3Ry
dWN0IHBjaV9kZXYgKik7CiB2b2lkIHF1aXJrX2lvbW11X2NhcHMoc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXUpOwogCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5jCkBAIC0xMjAsNiArMTIwLDcgQEAgc3RhdGljIGlu
dCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0CiAgICAgfQogCiAgICAg
c2V0X2JpdChpLCBpb21tdS0+ZG9taWRfYml0bWFwKTsKKyAgICBjb250ZXh0
LT5oaSAmPSB+KCgoMSA8PCBESURfRklFTERfV0lEVEgpIC0gMSkgPDwgRElE
X0hJR0hfT0ZGU0VUKTsKICAgICBjb250ZXh0LT5oaSB8PSAoaSAmICgoMSA8
PCBESURfRklFTERfV0lEVEgpIC0gMSkpIDw8IERJRF9ISUdIX09GRlNFVDsK
ICAgICByZXR1cm4gMDsKIH0KQEAgLTEzNzEsMTUgKzEzNzIsMjcgQEAgc3Rh
dGljIHZvaWQgX19od2RvbV9pbml0IGludGVsX2lvbW11X2h3ZAogICAgIH0K
IH0KIAorLyoKKyAqIFRoaXMgZnVuY3Rpb24gcmV0dXJucworICogLSBhIG5l
Z2F0aXZlIGVycm5vIHZhbHVlIHVwb24gZXJyb3IsCisgKiAtIHplcm8gdXBv
biBzdWNjZXNzIHdoZW4gcHJldmlvdXNseSB0aGUgZW50cnkgd2FzIG5vbi1w
cmVzZW50LCBvciB0aGlzIGlzbid0CisgKiAgIHRoZSAibWFpbiIgcmVxdWVz
dCBmb3IgYSBkZXZpY2UgKHBkZXYgPT0gTlVMTCksIG9yIGZvciBuby1vcCBx
dWFyYW50aW5pbmcKKyAqICAgYXNzaWdubWVudHMsCisgKiAtIHBvc2l0aXZl
IChvbmUpIHVwb24gc3VjY2VzcyB3aGVuIHByZXZpb3VzbHkgdGhlIGVudHJ5
IHdhcyBwcmVzZW50IGFuZCB0aGlzCisgKiAgIGlzIHRoZSAibWFpbiIgcmVx
dWVzdCBmb3IgYSBkZXZpY2UgKHBkZXYgIT0gTlVMTCkuCisgKi8KIGludCBk
b21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICBzdHJ1Y3QgZG9tYWlu
ICpkb21haW4sCiAgICAgc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUsCi0gICAg
dTggYnVzLCB1OCBkZXZmbiwgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYp
CisgICAgdWludDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sIGNvbnN0IHN0cnVj
dCBwY2lfZGV2ICpwZGV2LAorICAgIHVuc2lnbmVkIGludCBtb2RlKQogewog
ICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbWFp
bik7Ci0gICAgc3RydWN0IGNvbnRleHRfZW50cnkgKmNvbnRleHQsICpjb250
ZXh0X2VudHJpZXM7CisgICAgc3RydWN0IGNvbnRleHRfZW50cnkgKmNvbnRl
eHQsICpjb250ZXh0X2VudHJpZXMsIGxjdHh0OworICAgIF9fdWludDEyOF90
IG9sZDsKICAgICB1NjQgbWFkZHIsIHBnZF9tYWRkcjsKLSAgICB1MTYgc2Vn
ID0gaW9tbXUtPmRyaGQtPnNlZ21lbnQ7CisgICAgdWludDE2X3Qgc2VnID0g
aW9tbXUtPmRyaGQtPnNlZ21lbnQsIHByZXZfZGlkID0gMDsKKyAgICBzdHJ1
Y3QgZG9tYWluICpwcmV2X2RvbSA9IE5VTEw7CiAgICAgaW50IHJjLCByZXQ7
CiAgICAgYm9vbF90IGZsdXNoX2Rldl9pb3RsYjsKIApAQCAtMTM5MSwxNyAr
MTQwNCwzMiBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAg
ICAgbWFkZHIgPSBidXNfdG9fY29udGV4dF9tYWRkcihpb21tdSwgYnVzKTsK
ICAgICBjb250ZXh0X2VudHJpZXMgPSAoc3RydWN0IGNvbnRleHRfZW50cnkg
KiltYXBfdnRkX2RvbWFpbl9wYWdlKG1hZGRyKTsKICAgICBjb250ZXh0ID0g
JmNvbnRleHRfZW50cmllc1tkZXZmbl07CisgICAgb2xkID0gKGxjdHh0ID0g
KmNvbnRleHQpLmZ1bGw7CiAKLSAgICBpZiAoIGNvbnRleHRfcHJlc2VudCgq
Y29udGV4dCkgKQorICAgIGlmICggY29udGV4dF9wcmVzZW50KGxjdHh0KSAp
CiAgICAgewotICAgICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOwot
ICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRyaWVz
KTsKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIGRvbWlkX3QgZG9taWQ7
CisKKyAgICAgICAgcHJldl9kaWQgPSBjb250ZXh0X2RvbWFpbl9pZChsY3R4
dCk7CisgICAgICAgIGRvbWlkID0gaW9tbXUtPmRvbWlkX21hcFtwcmV2X2Rp
ZF07CisgICAgICAgIGlmICggZG9taWQgPCBET01JRF9GSVJTVF9SRVNFUlZF
RCApCisgICAgICAgICAgICBwcmV2X2RvbSA9IHJjdV9sb2NrX2RvbWFpbl9i
eV9pZChkb21pZCk7CisgICAgICAgIGVsc2UgaWYgKCBkb21pZCA9PSBET01J
RF9JTyApCisgICAgICAgICAgICBwcmV2X2RvbSA9IHJjdV9sb2NrX2RvbWFp
bihkb21faW8pOworICAgICAgICBpZiAoICFwcmV2X2RvbSApCisgICAgICAg
IHsKKyAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7Cisg
ICAgICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29udGV4dF9lbnRy
aWVzKTsKKyAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0RFQlVHIFZURFBS
RUZJWCwKKyAgICAgICAgICAgICAgICAgICAgIm5vIGRvbWFpbiBmb3IgZGlk
ICV1IChucl9kb20gJXUpXG4iLAorICAgICAgICAgICAgICAgICAgICBwcmV2
X2RpZCwgY2FwX25kb21zKGlvbW11LT5jYXApKTsKKyAgICAgICAgICAgIHJl
dHVybiAtRVNSQ0g7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoIGlv
bW11X2h3ZG9tX3Bhc3N0aHJvdWdoICYmIGlzX2hhcmR3YXJlX2RvbWFpbihk
b21haW4pICkKICAgICB7Ci0gICAgICAgIGNvbnRleHRfc2V0X3RyYW5zbGF0
aW9uX3R5cGUoKmNvbnRleHQsIENPTlRFWFRfVFRfUEFTU19USFJVKTsKKyAg
ICAgICAgY29udGV4dF9zZXRfdHJhbnNsYXRpb25fdHlwZShsY3R4dCwgQ09O
VEVYVF9UVF9QQVNTX1RIUlUpOwogICAgIH0KICAgICBlbHNlCiAgICAgewpA
QCAtMTQxMywzNiArMTQ0MSwxMDcgQEAgaW50IGRvbWFpbl9jb250ZXh0X21h
cHBpbmdfb25lKAogICAgICAgICAgICAgc3Bpbl91bmxvY2soJmhkLT5hcmNo
Lm1hcHBpbmdfbG9jayk7CiAgICAgICAgICAgICBzcGluX3VubG9jaygmaW9t
bXUtPmxvY2spOwogICAgICAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdl
KGNvbnRleHRfZW50cmllcyk7CisgICAgICAgICAgICBpZiAoIHByZXZfZG9t
ICkKKyAgICAgICAgICAgICAgICByY3VfdW5sb2NrX2RvbWFpbihwcmV2X2Rv
bSk7CiAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKICAgICAgICAgfQog
Ci0gICAgICAgIGNvbnRleHRfc2V0X2FkZHJlc3Nfcm9vdCgqY29udGV4dCwg
cGdkX21hZGRyKTsKKyAgICAgICAgY29udGV4dF9zZXRfYWRkcmVzc19yb290
KGxjdHh0LCBwZ2RfbWFkZHIpOwogICAgICAgICBpZiAoIGF0c19lbmFibGVk
ICYmIGVjYXBfZGV2X2lvdGxiKGlvbW11LT5lY2FwKSApCi0gICAgICAgICAg
ICBjb250ZXh0X3NldF90cmFuc2xhdGlvbl90eXBlKCpjb250ZXh0LCBDT05U
RVhUX1RUX0RFVl9JT1RMQik7CisgICAgICAgICAgICBjb250ZXh0X3NldF90
cmFuc2xhdGlvbl90eXBlKGxjdHh0LCBDT05URVhUX1RUX0RFVl9JT1RMQik7
CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIGNvbnRleHRfc2V0X3RyYW5z
bGF0aW9uX3R5cGUoKmNvbnRleHQsIENPTlRFWFRfVFRfTVVMVElfTEVWRUwp
OworICAgICAgICAgICAgY29udGV4dF9zZXRfdHJhbnNsYXRpb25fdHlwZShs
Y3R4dCwgQ09OVEVYVF9UVF9NVUxUSV9MRVZFTCk7CiAKICAgICAgICAgc3Bp
bl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAgICAgfQogCi0g
ICAgaWYgKCBjb250ZXh0X3NldF9kb21haW5faWQoY29udGV4dCwgZG9tYWlu
LCBpb21tdSkgKQorICAgIGlmICggY29udGV4dF9zZXRfZG9tYWluX2lkKCZs
Y3R4dCwgZG9tYWluLCBpb21tdSkgKQogICAgIHsKKyAgICB1bmxvY2s6CiAg
ICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7CiAgICAgICAgIHVu
bWFwX3Z0ZF9kb21haW5fcGFnZShjb250ZXh0X2VudHJpZXMpOworICAgICAg
ICBpZiAoIHByZXZfZG9tICkKKyAgICAgICAgICAgIHJjdV91bmxvY2tfZG9t
YWluKHByZXZfZG9tKTsKICAgICAgICAgcmV0dXJuIC1FRkFVTFQ7CiAgICAg
fQogCi0gICAgY29udGV4dF9zZXRfYWRkcmVzc193aWR0aCgqY29udGV4dCwg
bGV2ZWxfdG9fYWdhdyhpb21tdS0+bnJfcHRfbGV2ZWxzKSk7Ci0gICAgY29u
dGV4dF9zZXRfZmF1bHRfZW5hYmxlKCpjb250ZXh0KTsKLSAgICBjb250ZXh0
X3NldF9wcmVzZW50KCpjb250ZXh0KTsKKyAgICBpZiAoICFwcmV2X2RvbSAp
CisgICAgeworICAgICAgICBjb250ZXh0X3NldF9hZGRyZXNzX3dpZHRoKGxj
dHh0LCBsZXZlbF90b19hZ2F3KGlvbW11LT5ucl9wdF9sZXZlbHMpKTsKKyAg
ICAgICAgY29udGV4dF9zZXRfZmF1bHRfZW5hYmxlKGxjdHh0KTsKKyAgICAg
ICAgY29udGV4dF9zZXRfcHJlc2VudChsY3R4dCk7CisgICAgfQorICAgIGVs
c2UgaWYgKCBwcmV2X2RvbSA9PSBkb21haW4gKQorICAgIHsKKyAgICAgICAg
QVNTRVJUKGxjdHh0LmZ1bGwgPT0gY29udGV4dC0+ZnVsbCk7CisgICAgICAg
IHJjID0gISFwZGV2OworICAgICAgICBnb3RvIHVubG9jazsKKyAgICB9Cisg
ICAgZWxzZQorICAgIHsKKyAgICAgICAgQVNTRVJUKGNvbnRleHRfYWRkcmVz
c193aWR0aChsY3R4dCkgPT0KKyAgICAgICAgICAgICAgIGxldmVsX3RvX2Fn
YXcoaW9tbXUtPm5yX3B0X2xldmVscykpOworICAgICAgICBBU1NFUlQoIWNv
bnRleHRfZmF1bHRfZGlzYWJsZShsY3R4dCkpOworICAgIH0KKworICAgIGlm
ICggY3B1X2hhc19jeDE2ICkKKyAgICB7CisgICAgICAgIF9fdWludDEyOF90
IHJlcyA9IGNtcHhjaGcxNmIoY29udGV4dCwgJm9sZCwgJmxjdHh0LmZ1bGwp
OworCisgICAgICAgIC8qCisgICAgICAgICAqIEhhcmR3YXJlIGRvZXMgbm90
IHVwZGF0ZSB0aGUgY29udGV4dCBlbnRyeSBiZWhpbmQgb3VyIGJhY2tzLAor
ICAgICAgICAgKiBzbyB0aGUgcmV0dXJuIHZhbHVlIHNob3VsZCBtYXRjaCAi
b2xkIi4KKyAgICAgICAgICovCisgICAgICAgIGlmICggcmVzICE9IG9sZCAp
CisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICggcGRldiApCisgICAgICAg
ICAgICAgICAgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAoZG9tYWluLCBwZGV2
LCBpb21tdSk7CisgICAgICAgICAgICBwcmludGsoWEVOTE9HX0VSUgorICAg
ICAgICAgICAgICAgICAgICIlcHA6IHVuZXhwZWN0ZWQgY29udGV4dCBlbnRy
eSAlMDE2bHhfJTAxNmx4IChleHBlY3RlZCAlMDE2bHhfJTAxNmx4KVxuIiwK
KyAgICAgICAgICAgICAgICAgICAmUENJX1NCREYzKHBkZXYtPnNlZywgcGRl
di0+YnVzLCBkZXZmbiksCisgICAgICAgICAgICAgICAgICAgKHVpbnQ2NF90
KShyZXMgPj4gNjQpLCAodWludDY0X3QpcmVzLAorICAgICAgICAgICAgICAg
ICAgICh1aW50NjRfdCkob2xkID4+IDY0KSwgKHVpbnQ2NF90KW9sZCk7Cisg
ICAgICAgICAgICByYyA9IC1FSUxTRVE7CisgICAgICAgICAgICBnb3RvIHVu
bG9jazsKKyAgICAgICAgfQorICAgIH0KKyAgICBlbHNlIGlmICggIXByZXZf
ZG9tIHx8ICEobW9kZSAmIE1BUF9XSVRIX1JNUlIpICkKKyAgICB7CisgICAg
ICAgIGNvbnRleHRfY2xlYXJfcHJlc2VudCgqY29udGV4dCk7CisgICAgICAg
IGlvbW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6ZW9mKCpjb250ZXh0KSk7
CisKKyAgICAgICAgd3JpdGVfYXRvbWljKCZjb250ZXh0LT5oaSwgbGN0eHQu
aGkpOworICAgICAgICAvKiBObyBiYXJyaWVyIHNob3VsZCBiZSBuZWVkZWQg
YmV0d2VlbiB0aGVzZSB0d28uICovCisgICAgICAgIHdyaXRlX2F0b21pYygm
Y29udGV4dC0+bG8sIGxjdHh0LmxvKTsKKyAgICB9CisgICAgZWxzZSAvKiBC
ZXN0IGVmZm9ydCwgdXBkYXRpbmcgRElEIGxhc3QuICovCisgICAgeworICAg
ICAgICAgLyoKKyAgICAgICAgICAqIEJ5IG5vbi1hdG9taWNhbGx5IHVwZGF0
aW5nIHRoZSBjb250ZXh0IGVudHJ5J3MgRElEIGZpZWxkIGxhc3QsCisgICAg
ICAgICAgKiBkdXJpbmcgYSBzaG9ydCB3aW5kb3cgaW4gdGltZSBUTEIgZW50
cmllcyB3aXRoIHRoZSBvbGQgZG9tYWluIElECisgICAgICAgICAgKiBidXQg
dGhlIG5ldyBwYWdlIHRhYmxlcyBtYXkgYmUgaW5zZXJ0ZWQuICBUaGlzIGNv
dWxkIGFmZmVjdCBJL08KKyAgICAgICAgICAqIG9mIG90aGVyIGRldmljZXMg
dXNpbmcgdGhpcyBzYW1lIChvbGQpIGRvbWFpbiBJRC4gIFN1Y2ggdXBkYXRp
bmcKKyAgICAgICAgICAqIHRoZXJlZm9yZSBpcyBub3QgYSBwcm9ibGVtIGlm
IHRoaXMgd2FzIHRoZSBvbmx5IGRldmljZSBhc3NvY2lhdGVkCisgICAgICAg
ICAgKiB3aXRoIHRoZSBvbGQgZG9tYWluIElELiAgRGl2ZXJ0aW5nIEkvTyBv
ZiBhbnkgb2YgYSBkeWluZyBkb21haW4ncworICAgICAgICAgICogZGV2aWNl
cyB0byB0aGUgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBpcyBpbnRlbmRlZCBh
bnl3YXkuCisgICAgICAgICAgKi8KKyAgICAgICAgaWYgKCAhKG1vZGUgJiAo
TUFQX09XTkVSX0RZSU5HIHwgTUFQX1NJTkdMRV9ERVZJQ0UpKSApCisgICAg
ICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcgVlREUFJFRklYCisgICAg
ICAgICAgICAgICAgICAgIiAlcHA6IHJlYXNzaWdubWVudCBtYXkgY2F1c2Ug
JXBkIGRhdGEgY29ycnVwdGlvblxuIiwKKyAgICAgICAgICAgICAgICAgICAm
UENJX1NCREYzKHNlZywgYnVzLCBkZXZmbiksIHByZXZfZG9tKTsKKworICAg
ICAgICB3cml0ZV9hdG9taWMoJmNvbnRleHQtPmxvLCBsY3R4dC5sbyk7Cisg
ICAgICAgIC8qIE5vIGJhcnJpZXIgc2hvdWxkIGJlIG5lZWRlZCBiZXR3ZWVu
IHRoZXNlIHR3by4gKi8KKyAgICAgICAgd3JpdGVfYXRvbWljKCZjb250ZXh0
LT5oaSwgbGN0eHQuaGkpOworICAgIH0KKwogICAgIGlvbW11X3N5bmNfY2Fj
aGUoY29udGV4dCwgc2l6ZW9mKHN0cnVjdCBjb250ZXh0X2VudHJ5KSk7CiAg
ICAgc3Bpbl91bmxvY2soJmlvbW11LT5sb2NrKTsKIAotICAgIC8qIENvbnRl
eHQgZW50cnkgd2FzIHByZXZpb3VzbHkgbm9uLXByZXNlbnQgKHdpdGggZG9t
aWQgMCkuICovCi0gICAgcmMgPSBpb21tdV9mbHVzaF9jb250ZXh0X2Rldmlj
ZShpb21tdSwgMCwgUENJX0JERjIoYnVzLCBkZXZmbiksCi0gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBETUFfQ0NNRF9NQVNLX05PQklU
LCAxKTsKKyAgICByYyA9IGlvbW11X2ZsdXNoX2NvbnRleHRfZGV2aWNlKGlv
bW11LCBwcmV2X2RpZCwgUENJX0JERjIoYnVzLCBkZXZmbiksCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBETUFfQ0NNRF9NQVNLX05P
QklULCAhcHJldl9kb20pOwogICAgIGZsdXNoX2Rldl9pb3RsYiA9ICEhZmlu
ZF9hdHNfZGV2X2RyaGQoaW9tbXUpOwotICAgIHJldCA9IGlvbW11X2ZsdXNo
X2lvdGxiX2RzaShpb21tdSwgMCwgMSwgZmx1c2hfZGV2X2lvdGxiKTsKKyAg
ICByZXQgPSBpb21tdV9mbHVzaF9pb3RsYl9kc2koaW9tbXUsIHByZXZfZGlk
LCAhcHJldl9kb20sIGZsdXNoX2Rldl9pb3RsYik7CiAKICAgICAvKgogICAg
ICAqIFRoZSBjdXJyZW50IGxvZ2ljIGZvciByZXR1cm5zOgpAQCAtMTQ2Mywx
NyArMTU2MiwyNiBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUo
CiAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7
CiAKICAgICBpZiAoICFzZWcgJiYgIXJjICkKLSAgICAgICAgcmMgPSBtZV93
aWZpX3F1aXJrKGRvbWFpbiwgYnVzLCBkZXZmbiwgTUFQX01FX1BIQU5UT01f
RlVOQyk7CisgICAgICAgIHJjID0gbWVfd2lmaV9xdWlyayhkb21haW4sIGJ1
cywgZGV2Zm4sIG1vZGUpOwogCiAgICAgaWYgKCByYyApCiAgICAgewotICAg
ICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBp
b21tdSwgYnVzLCBkZXZmbik7CisgICAgICAgIGlmICggIXByZXZfZG9tICkK
KyAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShk
b21haW4sIGlvbW11LCBidXMsIGRldmZuKTsKKyAgICAgICAgZWxzZSBpZiAo
IHByZXZfZG9tICE9IGRvbWFpbiApIC8qIEF2b2lkIGluZmluaXRlIHJlY3Vy
c2lvbi4gKi8KKyAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21h
cHBpbmdfb25lKHByZXZfZG9tLCBpb21tdSwgYnVzLCBkZXZmbiwgcGRldiwK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IG1vZGUgJiBNQVBfV0lUSF9STVJSKSA8IDA7CisgICAgICAgIGVsc2UKKyAg
ICAgICAgICAgIHJldCA9IDE7CiAKICAgICAgICAgaWYgKCAhcmV0ICYmIHBk
ZXYgJiYgcGRldi0+ZGV2Zm4gPT0gZGV2Zm4gKQogICAgICAgICAgICAgY2hl
Y2tfY2xlYW51cF9kb21pZF9tYXAoZG9tYWluLCBwZGV2LCBpb21tdSk7CiAg
ICAgfQogCi0gICAgcmV0dXJuIHJjOworICAgIGlmICggcHJldl9kb20gKQor
ICAgICAgICByY3VfdW5sb2NrX2RvbWFpbihwcmV2X2RvbSk7CisKKyAgICBy
ZXR1cm4gcmMgPzogcGRldiAmJiBwcmV2X2RvbTsKIH0KIAogc3RhdGljIGlu
dCBkb21haW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZG9tYWluICpkLCB1aW50
OF90IGRldmZuLApAQCAtMTQ4Myw4ICsxNTkxLDEwIEBAIHN0YXRpYyBpbnQg
ZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldikKIHsK
ICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQgPSBhY3Bp
X2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CisgICAgY29uc3Qgc3Ry
dWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwogICAgIGludCByZXQgPSAwOwot
ICAgIHVpbnQxNl90IHNlZyA9IHBkZXYtPnNlZzsKKyAgICB1bnNpZ25lZCBp
bnQgaSwgbW9kZSA9IDA7CisgICAgdWludDE2X3Qgc2VnID0gcGRldi0+c2Vn
LCBiZGY7CiAgICAgdWludDhfdCBidXMgPSBwZGV2LT5idXMsIHNlY2J1czsK
IAogICAgIC8qCkBAIC0xNTAwLDggKzE2MTAsMjkgQEAgc3RhdGljIGludCBk
b21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogCiAgICAgQVNTRVJUKHBj
aWRldnNfbG9ja2VkKCkpOwogCisgICAgZm9yX2VhY2hfcm1ycl9kZXZpY2Uo
IHJtcnIsIGJkZiwgaSApCisgICAgeworICAgICAgICBpZiAoIHJtcnItPnNl
Z21lbnQgIT0gcGRldi0+c2VnIHx8IGJkZiAhPSBwZGV2LT5zYmRmLmJkZiAp
CisgICAgICAgICAgICBjb250aW51ZTsKKworICAgICAgICBtb2RlIHw9IE1B
UF9XSVRIX1JNUlI7CisgICAgICAgIGJyZWFrOworICAgIH0KKworICAgIGlm
ICggZG9tYWluICE9IHBkZXYtPmRvbWFpbiApCisgICAgeworICAgICAgICBp
ZiAoIHBkZXYtPmRvbWFpbi0+aXNfZHlpbmcgKQorICAgICAgICAgICAgbW9k
ZSB8PSBNQVBfT1dORVJfRFlJTkc7CisgICAgICAgIGVsc2UgaWYgKCBkcmhk
ICYmCisgICAgICAgICAgICAgICAgICAhYW55X3BkZXZfYmVoaW5kX2lvbW11
KHBkZXYtPmRvbWFpbiwgcGRldiwgZHJoZC0+aW9tbXUpICYmCisgICAgICAg
ICAgICAgICAgICAhcGRldi0+cGhhbnRvbV9zdHJpZGUgKQorICAgICAgICAg
ICAgbW9kZSB8PSBNQVBfU0lOR0xFX0RFVklDRTsKKyAgICB9CisKICAgICBz
d2l0Y2ggKCBwZGV2LT50eXBlICkKICAgICB7CisgICAgICAgIGJvb2wgcHJl
dl9wcmVzZW50OworCiAgICAgY2FzZSBERVZfVFlQRV9QQ0lfSE9TVF9CUklE
R0U6CiAgICAgICAgIGlmICggaW9tbXVfZGVidWcgKQogICAgICAgICAgICAg
cHJpbnRrKFZURFBSRUZJWCAiJXBkOkhvc3RicmlkZ2U6IHNraXAgJXBwIG1h
cFxuIiwKQEAgLTE1MjMsNyArMTY1NCw5IEBAIHN0YXRpYyBpbnQgZG9tYWlu
X2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgIHByaW50ayhW
VERQUkVGSVggIiVwZDpQQ0llOiBtYXAgJXBwXG4iLAogICAgICAgICAgICAg
ICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pKTsK
ICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9t
YWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRldik7CisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIG1vZGUpOwor
ICAgICAgICBpZiAoIHJldCA+IDAgKQorICAgICAgICAgICAgcmV0ID0gMDsK
ICAgICAgICAgaWYgKCAhcmV0ICYmIGRldmZuID09IHBkZXYtPmRldmZuICYm
IGF0c19kZXZpY2UocGRldiwgZHJoZCkgPiAwICkKICAgICAgICAgICAgIGVu
YWJsZV9hdHNfZGV2aWNlKHBkZXYsICZkcmhkLT5pb21tdS0+YXRzX2Rldmlj
ZXMpOwogCkBAIC0xNTM4LDkgKzE2NzEsMTAgQEAgc3RhdGljIGludCBkb21h
aW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICAgICAgICAgICAg
IGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pKTsKIAogICAg
ICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4s
IGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBwZGV2KTsKLSAgICAgICAgaWYgKCBy
ZXQgKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBwZGV2LCBtb2RlKTsKKyAgICAgICAgaWYgKCByZXQgPCAwICkKICAgICAg
ICAgICAgIGJyZWFrOworICAgICAgICBwcmV2X3ByZXNlbnQgPSByZXQ7CiAK
ICAgICAgICAgaWYgKCAocmV0ID0gZmluZF91cHN0cmVhbV9icmlkZ2Uoc2Vn
LCAmYnVzLCAmZGV2Zm4sICZzZWNidXMpKSA8IDEgKQogICAgICAgICB7CkBA
IC0xNTQ4LDYgKzE2ODIsMTUgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4
dF9tYXBwaW5nKHN0cnVjdAogICAgICAgICAgICAgICAgIGJyZWFrOwogICAg
ICAgICAgICAgcmV0ID0gLUVOWElPOwogICAgICAgICB9CisgICAgICAgIC8q
CisgICAgICAgICAqIFN0cmljdGx5IHNwZWFraW5nIGlmIHRoZSBkZXZpY2Ug
aXMgdGhlIG9ubHkgb25lIGJlaGluZCB0aGlzIGJyaWRnZQorICAgICAgICAg
KiBhbmQgdGhlIG9ubHkgb25lIHdpdGggdGhpcyAoc2VjYnVzLDAsMCkgdHVw
bGUsIGl0IGNvdWxkIGJlIGFsbG93ZWQKKyAgICAgICAgICogdG8gYmUgcmUt
YXNzaWduZWQgcmVnYXJkbGVzcyBvZiBSTVJSIHByZXNlbmNlLiAgQnV0IGxl
dCdzIGRlYWwgd2l0aAorICAgICAgICAgKiB0aGF0IGNhc2Ugb25seSBpZiBp
dCBpcyBhY3R1YWxseSBmb3VuZCBpbiB0aGUgd2lsZC4KKyAgICAgICAgICov
CisgICAgICAgIGVsc2UgaWYgKCBwcmV2X3ByZXNlbnQgJiYgKG1vZGUgJiBN
QVBfV0lUSF9STVJSKSAmJgorICAgICAgICAgICAgICAgICAgZG9tYWluICE9
IHBkZXYtPmRvbWFpbiApCisgICAgICAgICAgICByZXQgPSAtRU9QTk9UU1VQ
UDsKIAogICAgICAgICAvKgogICAgICAgICAgKiBNYXBwaW5nIGEgYnJpZGdl
IHNob3VsZCwgaWYgYW55dGhpbmcsIHBhc3MgdGhlIHN0cnVjdCBwY2lfZGV2
IG9mCkBAIC0xNTU2LDcgKzE2OTksNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9j
b250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAqLwogICAgICAgICBp
ZiAoIHJldCA+PSAwICkKICAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250
ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2
Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBOVUxMKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIE5VTEwsIG1vZGUpOwogCiAgICAgICAgIC8qCiAgICAg
ICAgICAqIERldmljZXMgYmVoaW5kIFBDSWUtdG8tUENJL1BDSXggYnJpZGdl
IG1heSBnZW5lcmF0ZSBkaWZmZXJlbnQKQEAgLTE1NzEsMTAgKzE3MTQsMTUg
QEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAog
ICAgICAgICBpZiAoICFyZXQgJiYgcGRldl90eXBlKHNlZywgYnVzLCBkZXZm
bikgPT0gREVWX1RZUEVfUENJZTJQQ0lfQlJJREdFICYmCiAgICAgICAgICAg
ICAgKHNlY2J1cyAhPSBwZGV2LT5idXMgfHwgcGRldi0+ZGV2Zm4gIT0gMCkg
KQogICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19v
bmUoZG9tYWluLCBkcmhkLT5pb21tdSwgc2VjYnVzLCAwLAotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCk7Cisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBO
VUxMLCBtb2RlKTsKIAogICAgICAgICBpZiAoIHJldCApCi0gICAgICAgICAg
ICBkb21haW5fY29udGV4dF91bm1hcChkb21haW4sIGRldmZuLCBwZGV2KTsK
KyAgICAgICAgeworICAgICAgICAgICAgaWYgKCAhcHJldl9wcmVzZW50ICkK
KyAgICAgICAgICAgICAgICBkb21haW5fY29udGV4dF91bm1hcChkb21haW4s
IGRldmZuLCBwZGV2KTsKKyAgICAgICAgICAgIGVsc2UgaWYgKCBwZGV2LT5k
b21haW4gIT0gZG9tYWluICkgLyogQXZvaWQgaW5maW5pdGUgcmVjdXJzaW9u
LiAqLworICAgICAgICAgICAgICAgIGRvbWFpbl9jb250ZXh0X21hcHBpbmco
cGRldi0+ZG9tYWluLCBkZXZmbiwgcGRldik7CisgICAgICAgIH0KIAogICAg
ICAgICBicmVhazsKIApAQCAtMjM2MywxNyArMjUxMSw0NiBAQCBzdGF0aWMg
aW50IHJlYXNzaWduX2RldmljZV9vd25lcnNoaXAoCiB7CiAgICAgaW50IHJl
dDsKIAotICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHNvdXJjZSwg
ZGV2Zm4sIHBkZXYpOworICAgIGlmICggIVFVQVJBTlRJTkVfU0tJUCh0YXJn
ZXQpICkKKyAgICB7CisgICAgICAgIGlmICggIWhhc19hcmNoX3BkZXZzKHRh
cmdldCkgKQorICAgICAgICAgICAgdm14X3BpX2hvb2tzX2Fzc2lnbih0YXJn
ZXQpOworCisgICAgICAgIC8qCisgICAgICAgICAqIERldmljZXMgYXNzaWdu
ZWQgdG8gdW50cnVzdGVkIGRvbWFpbnMgKGhlcmUgYXNzdW1lZCB0byBiZSBh
bnkgZG9tVSkKKyAgICAgICAgICogY2FuIGF0dGVtcHQgdG8gc2VuZCBhcmJp
dHJhcnkgTEFQSUMvTVNJIG1lc3NhZ2VzLiBXZSBhcmUgdW5wcm90ZWN0ZWQK
KyAgICAgICAgICogYnkgdGhlIHJvb3QgY29tcGxleCB1bmxlc3MgaW50ZXJy
dXB0IHJlbWFwcGluZyBpcyBlbmFibGVkLgorICAgICAgICAgKi8KKyAgICAg
ICAgaWYgKCAodGFyZ2V0ICE9IGhhcmR3YXJlX2RvbWFpbikgJiYgIWlvbW11
X2ludHJlbWFwICkKKyAgICAgICAgICAgIHVudHJ1c3RlZF9tc2kgPSB0cnVl
OworCisgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmcodGFy
Z2V0LCBkZXZmbiwgcGRldik7CisKKyAgICAgICAgaWYgKCAhcmV0ICYmICFR
VUFSQU5USU5FX1NLSVAoc291cmNlKSAmJiBwZGV2LT5kZXZmbiA9PSBkZXZm
biApCisgICAgICAgIHsKKyAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBhY3Bp
X2RyaGRfdW5pdCAqZHJoZCA9IGFjcGlfZmluZF9tYXRjaGVkX2RyaGRfdW5p
dChwZGV2KTsKKworICAgICAgICAgICAgaWYgKCBkcmhkICkKKyAgICAgICAg
ICAgICAgICBjaGVja19jbGVhbnVwX2RvbWlkX21hcChzb3VyY2UsIHBkZXYs
IGRyaGQtPmlvbW11KTsKKyAgICAgICAgfQorICAgIH0KKyAgICBlbHNlCisg
ICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwKHNvdXJjZSwgZGV2
Zm4sIHBkZXYpOwogICAgIGlmICggcmV0ICkKKyAgICB7CisgICAgICAgIGlm
ICggIWhhc19hcmNoX3BkZXZzKHRhcmdldCkgKQorICAgICAgICAgICAgdm14
X3BpX2hvb2tzX2RlYXNzaWduKHRhcmdldCk7CiAgICAgICAgIHJldHVybiBy
ZXQ7CisgICAgfQogCi0gICAgLyoKLSAgICAgKiBEZXZpY2VzIGFzc2lnbmVk
IHRvIHVudHJ1c3RlZCBkb21haW5zIChoZXJlIGFzc3VtZWQgdG8gYmUgYW55
IGRvbVUpCi0gICAgICogY2FuIGF0dGVtcHQgdG8gc2VuZCBhcmJpdHJhcnkg
TEFQSUMvTVNJIG1lc3NhZ2VzLiBXZSBhcmUgdW5wcm90ZWN0ZWQKLSAgICAg
KiBieSB0aGUgcm9vdCBjb21wbGV4IHVubGVzcyBpbnRlcnJ1cHQgcmVtYXBw
aW5nIGlzIGVuYWJsZWQuCi0gICAgICovCi0gICAgaWYgKCAodGFyZ2V0ICE9
IGhhcmR3YXJlX2RvbWFpbikgJiYgIWlvbW11X2ludHJlbWFwICkKLSAgICAg
ICAgdW50cnVzdGVkX21zaSA9IHRydWU7CisgICAgaWYgKCBkZXZmbiA9PSBw
ZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21haW4gIT0gdGFyZ2V0ICkKKyAgICB7
CisgICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZ0YXJn
ZXQtPnBkZXZfbGlzdCk7CisgICAgICAgIHBkZXYtPmRvbWFpbiA9IHRhcmdl
dDsKKyAgICB9CisKKyAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyhzb3VyY2Up
ICkKKyAgICAgICAgdm14X3BpX2hvb2tzX2RlYXNzaWduKHNvdXJjZSk7CiAK
ICAgICAvKgogICAgICAqIElmIHRoZSBkZXZpY2UgYmVsb25ncyB0byB0aGUg
aGFyZHdhcmUgZG9tYWluLCBhbmQgaXQgaGFzIFJNUlIsIGRvbid0CkBAIC0y
NDAzLDM0ICsyNTgwLDcgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Vf
b3duZXJzaGlwKAogICAgICAgICAgICAgfQogICAgIH0KIAotICAgIGlmICgg
ZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWluICE9IGRvbV9p
byApCi0gICAgewotICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9s
aXN0LCAmZG9tX2lvLT5wZGV2X2xpc3QpOwotICAgICAgICBwZGV2LT5kb21h
aW4gPSBkb21faW87Ci0gICAgfQotCi0gICAgaWYgKCAhaGFzX2FyY2hfcGRl
dnMoc291cmNlKSApCi0gICAgICAgIHZteF9waV9ob29rc19kZWFzc2lnbihz
b3VyY2UpOwotCi0gICAgaWYgKCAhaGFzX2FyY2hfcGRldnModGFyZ2V0KSAp
Ci0gICAgICAgIHZteF9waV9ob29rc19hc3NpZ24odGFyZ2V0KTsKLQotICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmcodGFyZ2V0LCBkZXZmbiwg
cGRldik7Ci0gICAgaWYgKCByZXQgKQotICAgIHsKLSAgICAgICAgaWYgKCAh
aGFzX2FyY2hfcGRldnModGFyZ2V0KSApCi0gICAgICAgICAgICB2bXhfcGlf
aG9va3NfZGVhc3NpZ24odGFyZ2V0KTsKLQotICAgICAgICByZXR1cm4gcmV0
OwotICAgIH0KLQotICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYg
cGRldi0+ZG9tYWluICE9IHRhcmdldCApCi0gICAgewotICAgICAgICBsaXN0
X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFyZ2V0LT5wZGV2X2xpc3Qp
OwotICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7Ci0gICAgfQotCi0g
ICAgcmV0dXJuIHJldDsKKyAgICByZXR1cm4gMDsKIH0KIAogc3RhdGljIGlu
dCBpbnRlbF9pb21tdV9hc3NpZ25fZGV2aWNlKAotLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuaAorKysgYi94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC92dGQvaW9tbXUuaApAQCAtMjAyLDggKzIwMiwxMiBAQCBz
dHJ1Y3Qgcm9vdF9lbnRyeSB7CiAgICAgZG8geyhyb290KS52YWwgfD0gKCh2
YWx1ZSkgJiBQQUdFX01BU0tfNEspO30gd2hpbGUoMCkKIAogc3RydWN0IGNv
bnRleHRfZW50cnkgewotICAgIHU2NCBsbzsKLSAgICB1NjQgaGk7CisgICAg
dW5pb24geworICAgICAgICBzdHJ1Y3QgeworICAgICAgICAgICAgdWludDY0
X3QgbG8sIGhpOworICAgICAgICB9OworICAgICAgICBfX3VpbnQxMjhfdCBm
dWxsOworICAgIH07CiB9OwogI2RlZmluZSBST09UX0VOVFJZX05SIChQQUdF
X1NJWkVfNEsvc2l6ZW9mKHN0cnVjdCByb290X2VudHJ5KSkKICNkZWZpbmUg
Y29udGV4dF9wcmVzZW50KGMpICgoYykubG8gJiAxKQotLS0gYS94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC92dGQvcXVpcmtzLmMKKysrIGIveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvdnRkL3F1aXJrcy5jCkBAIC00MDcsNyArNDA3LDgg
QEAgdm9pZCBfX2luaXQgcGxhdGZvcm1fcXVpcmtzX2luaXQodm9pZCkKICAq
LwogCiBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBtYXBfbWVfcGhhbnRvbV9m
dW5jdGlvbihzdHJ1Y3QgZG9tYWluICpkb21haW4sCi0gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1MzIgZGV2LCBp
bnQgbWFwKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgdW5zaWduZWQgaW50IGRldiwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu
dCBtb2RlKQogewogICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZDsK
ICAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldjsKQEAgLTQxOCw5ICs0MTksOSBA
QCBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBtYXBfbWVfcGhhbnRvbV9mCiAg
ICAgZHJoZCA9IGFjcGlfZmluZF9tYXRjaGVkX2RyaGRfdW5pdChwZGV2KTsK
IAogICAgIC8qIG1hcCBvciB1bm1hcCBNRSBwaGFudG9tIGZ1bmN0aW9uICov
Ci0gICAgaWYgKCBtYXAgKQorICAgIGlmICggIShtb2RlICYgVU5NQVBfTUVf
UEhBTlRPTV9GVU5DKSApCiAgICAgICAgIHJjID0gZG9tYWluX2NvbnRleHRf
bWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgMCwKLSAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfREVWRk4oZGV2
LCA3KSwgTlVMTCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgUENJX0RFVkZOKGRldiwgNyksIE5VTEwsIG1vZGUpOwogICAg
IGVsc2UKICAgICAgICAgcmMgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUo
ZG9tYWluLCBkcmhkLT5pb21tdSwgMCwKICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgUENJX0RFVkZOKGRldiwgNykpOwpAQCAtNDI4
LDcgKzQyOSw4IEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIG1hcF9tZV9w
aGFudG9tX2YKICAgICByZXR1cm4gcmM7CiB9CiAKLWludCBtZV93aWZpX3F1
aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgdTggYnVzLCB1OCBkZXZmbiwg
aW50IG1hcCkKK2ludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRv
bWFpbiwgdWludDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sCisgICAgICAgICAg
ICAgICAgICB1bnNpZ25lZCBpbnQgbW9kZSkKIHsKICAgICB1MzIgaWQ7CiAg
ICAgaW50IHJjID0gMDsKQEAgLTQ1Miw3ICs0NTQsNyBAQCBpbnQgbWVfd2lm
aV9xdWlyayhzdHJ1Y3QgZG9tYWluICpkb21haW4sCiAgICAgICAgICAgICBj
YXNlIDB4NDIzYjgwODY6CiAgICAgICAgICAgICBjYXNlIDB4NDIzYzgwODY6
CiAgICAgICAgICAgICBjYXNlIDB4NDIzZDgwODY6Ci0gICAgICAgICAgICAg
ICAgcmMgPSBtYXBfbWVfcGhhbnRvbV9mdW5jdGlvbihkb21haW4sIDMsIG1h
cCk7CisgICAgICAgICAgICAgICAgcmMgPSBtYXBfbWVfcGhhbnRvbV9mdW5j
dGlvbihkb21haW4sIDMsIG1vZGUpOwogICAgICAgICAgICAgICAgIGJyZWFr
OwogICAgICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICBicmVh
azsKQEAgLTQ3OCw3ICs0ODAsNyBAQCBpbnQgbWVfd2lmaV9xdWlyayhzdHJ1
Y3QgZG9tYWluICpkb21haW4sCiAgICAgICAgICAgICBjYXNlIDB4NDIzODgw
ODY6ICAgICAgICAvKiBQdW1hIFBlYWsgKi8KICAgICAgICAgICAgIGNhc2Ug
MHg0MjJiODA4NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjJjODA4NjoKLSAg
ICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKGRv
bWFpbiwgMjIsIG1hcCk7CisgICAgICAgICAgICAgICAgcmMgPSBtYXBfbWVf
cGhhbnRvbV9mdW5jdGlvbihkb21haW4sIDIyLCBtb2RlKTsKICAgICAgICAg
ICAgICAgICBicmVhazsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAg
ICAgICAgICAgYnJlYWs7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3Z0ZC92dGQuaAorKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv
dnRkLmgKQEAgLTIyLDggKzIyLDE0IEBACiAKICNpbmNsdWRlIDx4ZW4vaW9t
bXUuaD4KIAotI2RlZmluZSBNQVBfTUVfUEhBTlRPTV9GVU5DICAgICAgMQot
I2RlZmluZSBVTk1BUF9NRV9QSEFOVE9NX0ZVTkMgICAgMAorLyoKKyAqIFZh
bHVlcyBmb3IgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoKSdzIGFuZCBt
ZV93aWZpX3F1aXJrKCkncyAibW9kZSIKKyAqIHBhcmFtZXRlcnMuCisgKi8K
KyNkZWZpbmUgTUFQX1dJVEhfUk1SUiAgICAgICAgICgxdSA8PCAwKQorI2Rl
ZmluZSBNQVBfT1dORVJfRFlJTkcgICAgICAgKDF1IDw8IDEpCisjZGVmaW5l
IE1BUF9TSU5HTEVfREVWSUNFICAgICAoMXUgPDwgMikKKyNkZWZpbmUgVU5N
QVBfTUVfUEhBTlRPTV9GVU5DICgxdSA8PCAzKQogCiAvKiBBbGxvdyBmb3Ig
Ym90aCBJT0FQSUMgYW5kIElPU0FQSUMuICovCiAjZGVmaW5lIElPX3hBUElD
X3JvdXRlX2VudHJ5IElPX0FQSUNfcm91dGVfZW50cnkK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-06.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IHJlLWFzc2lnbiBkZXZpY2VzIGRpcmVjdGx5CgpEZXZp
Y2VzIHdpdGggdW5pdHkgbWFwIHJhbmdlcywgZHVlIHRvIGl0IGJlaW5nIHVu
c3BlY2lmaWVkIGhvdy93aGVuCnRoZXNlIG1lbW9yeSByYW5nZXMgbWF5IGdl
dCBhY2Nlc3NlZCwgbWF5IG5vdCBiZSBsZWZ0IGRpc2Nvbm5lY3RlZCBmcm9t
CnRoZWlyIHVuaXR5IG1hcHBpbmdzIChhcyBsb25nIGFzIGl0J3Mgbm90IGNl
cnRhaW4gdGhhdCB0aGUgZGV2aWNlIGhhcwpiZWVuIGZ1bGx5IHF1aWVzY2Vk
KS4gSGVuY2UgcmF0aGVyIHRoYW4gdGVhcmluZyBkb3duIHRoZSBvbGQgcm9v
dCBwYWdlCnRhYmxlIHBvaW50ZXIgYW5kIHRoZW4gZXN0YWJsaXNoaW5nIHRo
ZSBuZXcgb25lLCByZS1hc3NpZ25tZW50IG5lZWRzIHRvCmJlIGRvbmUgaW4g
YSBzaW5nbGUgc3RlcC4KClRoaXMgaXMgQ1ZFLTIwMjItMjYzNjAgLyBwYXJ0
IG9mIFhTQS00MDAuCgpSZXBvcnRlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8
cm9nZXIucGF1QGNpdHJpeC5jb20+CgpTaW1pbGFybHkgcXVhcmFudGluaW5n
IHNjcmF0Y2gtcGFnZSBtb2RlIHJlbGllcyBvbiBwYWdlIHRhYmxlcyB0byBi
ZQpjb250aW51b3VzbHkgd2lyZWQgdXAuCgpUbyBhdm9pZCBjb21wbGljYXRp
bmcgdGhpbmdzIG1vcmUgdGhhbiBuZWNlc3NhcnksIHRyZWF0IGFsbCBkZXZp
Y2VzCm1vc3RseSBlcXVhbGx5LCBpLmUuIHJlZ2FyZGxlc3Mgb2YgdGhlaXIg
YXNzb2NpYXRpb24gd2l0aCBhbnkgdW5pdHkgbWFwCnJhbmdlcy4gIFRoZSBt
YWluIGRpZmZlcmVuY2UgaXMgd2hlbiBpdCBjb21lcyB0byB1cGRhdGluZyBE
VEVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21pYyB3aGVuIHRoZXJlIGFyZSB1
bml0eSBtYXBwaW5ncy4gWWV0IGF0b21pY2l0eSBjYW4gb25seSBiZQphY2hp
ZXZlZCB3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBvZiB3aGljaCB3
ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwg
RHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+CgotLS0gYS94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUuaAorKysgYi94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUuaApAQCAtMjYyLDkgKzI2MiwxMyBA
QCB2b2lkIGFtZF9pb21tdV9zZXRfaW50cmVtYXBfdGFibGUoc3RydWN0CiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgdm9pZCAq
cHRyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0
IHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LAogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGJvb2wgdmFsaWQpOwotdm9pZCBhbWRfaW9tbXVf
c2V0X3Jvb3RfcGFnZV90YWJsZShzdHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRl
LAotCQkJCSAgIHVpbnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBkb21haW5f
aWQsCi0JCQkJICAgdWludDhfdCBwYWdpbmdfbW9kZSwgYm9vbCB2YWxpZCk7
CisjZGVmaW5lIFNFVF9ST09UX1ZBTElEICAgICAgICAgICgxdSA8PCAwKQor
I2RlZmluZSBTRVRfUk9PVF9XSVRIX1VOSVRZX01BUCAoMXUgPDwgMSkKK2lu
dCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUo
c3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3Qgcm9vdF9w
dHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHVpbnQxNl90IGRvbWFpbl9pZCwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBwYWdpbmdf
bW9kZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgdW5zaWduZWQgaW50IGZsYWdzKTsKIHZvaWQgaW9tbXVfZHRl
X2FkZF9kZXZpY2VfZW50cnkoc3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0
IGl2cnNfbWFwcGluZ3MgKml2cnNfZGV2KTsKIAotLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jCkBAIC0xMTQsMTAgKzEx
NCw2OSBAQCBzdGF0aWMgdW5zaWduZWQgaW50IHNldF9pb21tdV9wdGVzX3By
ZXNlCiAgICAgcmV0dXJuIGZsdXNoX2ZsYWdzOwogfQogCi12b2lkIGFtZF9p
b21tdV9zZXRfcm9vdF9wYWdlX3RhYmxlKHN0cnVjdCBhbWRfaW9tbXVfZHRl
ICpkdGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVp
bnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBkb21haW5faWQsCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgcGFnaW5nX21v
ZGUsIGJvb2wgdmFsaWQpCisvKgorICogVGhpcyBmdW5jdGlvbiByZXR1cm5z
CisgKiAtIC1lcnJubyBmb3IgZXJyb3JzLAorICogLSAwIGZvciBhIHN1Y2Nl
c3NmdWwgdXBkYXRlLCBhdG9taWMgd2hlbiBuZWNlc3NhcnkKKyAqIC0gMSBm
b3IgYSBzdWNjZXNzZnVsIGJ1dCBub24tYXRvbWljIHVwZGF0ZSwgd2hpY2gg
bWF5IG5lZWQgdG8gYmUgd2FybmVkCisgKiAgIGFib3V0IGJ5IHRoZSBjYWxs
ZXIuCisgKi8KK2ludCBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZShz
dHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRlLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHVpbnQ2NF90IHJvb3RfcHRyLCB1aW50MTZfdCBk
b21haW5faWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
dWludDhfdCBwYWdpbmdfbW9kZSwgdW5zaWduZWQgaW50IGZsYWdzKQogewor
ICAgIGJvb2wgdmFsaWQgPSBmbGFncyAmIFNFVF9ST09UX1ZBTElEOworCisg
ICAgaWYgKCBkdGUtPnYgJiYgZHRlLT50diAmJgorICAgICAgICAgKGNwdV9o
YXNfY3gxNiB8fCAoZmxhZ3MgJiBTRVRfUk9PVF9XSVRIX1VOSVRZX01BUCkp
ICkKKyAgICB7CisgICAgICAgIHVuaW9uIHsKKyAgICAgICAgICAgIHN0cnVj
dCBhbWRfaW9tbXVfZHRlIGR0ZTsKKyAgICAgICAgICAgIHVpbnQ2NF90IHJh
dzY0WzRdOworICAgICAgICAgICAgX191aW50MTI4X3QgcmF3MTI4WzJdOwor
ICAgICAgICB9IGxkdGUgPSB7IC5kdGUgPSAqZHRlIH07CisgICAgICAgIF9f
dWludDEyOF90IG9sZCA9IGxkdGUucmF3MTI4WzBdOworICAgICAgICBpbnQg
cmV0ID0gMDsKKworICAgICAgICBsZHRlLmR0ZS5kb21haW5faWQgPSBkb21h
aW5faWQ7CisgICAgICAgIGxkdGUuZHRlLnB0X3Jvb3QgPSBwYWRkcl90b19w
Zm4ocm9vdF9wdHIpOworICAgICAgICBsZHRlLmR0ZS5pdyA9IHRydWU7Cisg
ICAgICAgIGxkdGUuZHRlLmlyID0gdHJ1ZTsKKyAgICAgICAgbGR0ZS5kdGUu
cGFnaW5nX21vZGUgPSBwYWdpbmdfbW9kZTsKKyAgICAgICAgbGR0ZS5kdGUu
diA9IHZhbGlkOworCisgICAgICAgIGlmICggY3B1X2hhc19jeDE2ICkKKyAg
ICAgICAgeworICAgICAgICAgICAgX191aW50MTI4X3QgcmVzID0gY21weGNo
ZzE2YihkdGUsICZvbGQsICZsZHRlLnJhdzEyOFswXSk7CisKKyAgICAgICAg
ICAgIC8qCisgICAgICAgICAgICAgKiBIYXJkd2FyZSBkb2VzIG5vdCB1cGRh
dGUgdGhlIERURSBiZWhpbmQgb3VyIGJhY2tzLCBzbyB0aGUKKyAgICAgICAg
ICAgICAqIHJldHVybiB2YWx1ZSBzaG91bGQgbWF0Y2ggIm9sZCIuCisgICAg
ICAgICAgICAgKi8KKyAgICAgICAgICAgIGlmICggcmVzICE9IG9sZCApCisg
ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19F
UlIKKyAgICAgICAgICAgICAgICAgICAgICAgIkRvbSVkOiB1bmV4cGVjdGVk
IERURSAlMDE2bHhfJTAxNmx4IChleHBlY3RlZCAlMDE2bHhfJTAxNmx4KVxu
IiwKKyAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluX2lkLAorICAgICAg
ICAgICAgICAgICAgICAgICAodWludDY0X3QpKHJlcyA+PiA2NCksICh1aW50
NjRfdClyZXMsCisgICAgICAgICAgICAgICAgICAgICAgICh1aW50NjRfdCko
b2xkID4+IDY0KSwgKHVpbnQ2NF90KW9sZCk7CisgICAgICAgICAgICAgICAg
cmV0ID0gLUVJTFNFUTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAg
ICAgICBlbHNlIC8qIEJlc3QgZWZmb3J0LCB1cGRhdGluZyBkb21haW5faWQg
bGFzdC4gKi8KKyAgICAgICAgeworICAgICAgICAgICAgdWludDY0X3QgKnB0
ciA9ICh2b2lkICopZHRlOworCisgICAgICAgICAgICB3cml0ZV9hdG9taWMo
cHRyICsgMCwgbGR0ZS5yYXc2NFswXSk7CisgICAgICAgICAgICAvKiBObyBi
YXJyaWVyIHNob3VsZCBiZSBuZWVkZWQgYmV0d2VlbiB0aGVzZSB0d28uICov
CisgICAgICAgICAgICB3cml0ZV9hdG9taWMocHRyICsgMSwgbGR0ZS5yYXc2
NFsxXSk7CisKKyAgICAgICAgICAgIHJldCA9IDE7CisgICAgICAgIH0KKwor
ICAgICAgICByZXR1cm4gcmV0OworICAgIH0KKwogICAgIGlmICggdmFsaWQg
fHwgZHRlLT52ICkKICAgICB7CiAgICAgICAgIGR0ZS0+dHYgPSBmYWxzZTsK
QEAgLTEzMiw2ICsxOTEsOCBAQCB2b2lkIGFtZF9pb21tdV9zZXRfcm9vdF9w
YWdlX3RhYmxlKHN0cnVjCiAgICAgc21wX3dtYigpOwogICAgIGR0ZS0+dHYg
PSB0cnVlOwogICAgIGR0ZS0+diA9IHZhbGlkOworCisgICAgcmV0dXJuIDA7
CiB9CiAKIHZvaWQgYW1kX2lvbW11X3NldF9pbnRyZW1hcF90YWJsZSgKLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUu
YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9p
b21tdS5jCkBAIC05NiwxMyArOTYsMzIgQEAgc3RhdGljIGludCBfX211c3Rf
Y2hlY2sgYWxsb2NhdGVfZG9tYWluXwogICAgIHJldHVybiByYzsKIH0KIAor
c3RhdGljIGJvb2wgYW55X3BkZXZfYmVoaW5kX2lvbW11KGNvbnN0IHN0cnVj
dCBkb21haW4gKmQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKmV4Y2x1ZGUsCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGFtZF9pb21t
dSAqaW9tbXUpCit7CisgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXY7
CisKKyAgICBmb3JfZWFjaF9wZGV2ICggZCwgcGRldiApCisgICAgeworICAg
ICAgICBpZiAoIHBkZXYgPT0gZXhjbHVkZSApCisgICAgICAgICAgICBjb250
aW51ZTsKKworICAgICAgICBpZiAoIGZpbmRfaW9tbXVfZm9yX2RldmljZShw
ZGV2LT5zZWcsIHBkZXYtPnNiZGYuYmRmKSA9PSBpb21tdSApCisgICAgICAg
ICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAgICByZXR1cm4gZmFsc2U7
Cit9CisKIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1
cF9kb21haW5fZGV2aWNlKAogICAgIHN0cnVjdCBkb21haW4gKmRvbWFpbiwg
c3RydWN0IGFtZF9pb21tdSAqaW9tbXUsCiAgICAgdWludDhfdCBkZXZmbiwg
c3RydWN0IHBjaV9kZXYgKnBkZXYpCiB7CiAgICAgc3RydWN0IGFtZF9pb21t
dV9kdGUgKnRhYmxlLCAqZHRlOwogICAgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7
Ci0gICAgaW50IHJlcV9pZCwgdmFsaWQgPSAxLCByYzsKKyAgICB1bnNpZ25l
ZCBpbnQgcmVxX2lkLCBzcl9mbGFnczsKKyAgICBpbnQgcmM7CiAgICAgdTgg
YnVzID0gcGRldi0+YnVzOwogICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhk
ID0gZG9tX2lvbW11KGRvbWFpbik7CiAgICAgY29uc3Qgc3RydWN0IGl2cnNf
bWFwcGluZ3MgKml2cnNfZGV2OwpAQCAtMTE2LDggKzEzNSwxMSBAQCBzdGF0
aWMgaW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfCiAgICAgaWYg
KCByYyApCiAgICAgICAgIHJldHVybiByYzsKIAotICAgIGlmICggaW9tbXVf
aHdkb21fcGFzc3Rocm91Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWluKGRvbWFp
bikgKQotICAgICAgICB2YWxpZCA9IDA7CisgICAgcmVxX2lkID0gZ2V0X2Rt
YV9yZXF1ZXN0b3JfaWQoaW9tbXUtPnNlZywgcGRldi0+c2JkZi5iZGYpOwor
ICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21hcHBpbmdzKGlvbW11LT5zZWcp
W3JlcV9pZF07CisgICAgc3JfZmxhZ3MgPSAoaW9tbXVfaHdkb21fcGFzc3Ro
cm91Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWluKGRvbWFpbikKKyAgICAgICAg
ICAgICAgICA/IDAgOiBTRVRfUk9PVF9WQUxJRCkKKyAgICAgICAgICAgICAg
IHwgKGl2cnNfZGV2LT51bml0eV9tYXAgPyBTRVRfUk9PVF9XSVRIX1VOSVRZ
X01BUCA6IDApOwogCiAgICAgLyogZ2V0IGRldmljZS10YWJsZSBlbnRyeSAq
LwogICAgIHJlcV9pZCA9IGdldF9kbWFfcmVxdWVzdG9yX2lkKGlvbW11LT5z
ZWcsIFBDSV9CREYyKGJ1cywgZGV2Zm4pKTsKQEAgLTEzMCw5ICsxNTIsMTUg
QEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwog
ICAgIGlmICggIWR0ZS0+diB8fCAhZHRlLT50diApCiAgICAgewogICAgICAg
ICAvKiBiaW5kIERURSB0byBkb21haW4gcGFnZS10YWJsZXMgKi8KLSAgICAg
ICAgYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoCi0gICAgICAgICAg
ICBkdGUsIHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2guYW1kLnJvb3RfdGFibGUp
LAotICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQsIGhkLT5hcmNoLmFt
ZC5wYWdpbmdfbW9kZSwgdmFsaWQpOworICAgICAgICByYyA9IGFtZF9pb21t
dV9zZXRfcm9vdF9wYWdlX3RhYmxlKAorICAgICAgICAgICAgICAgICBkdGUs
IHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2guYW1kLnJvb3RfdGFibGUpLAorICAg
ICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2guYW1k
LnBhZ2luZ19tb2RlLCBzcl9mbGFncyk7CisgICAgICAgIGlmICggcmMgKQor
ICAgICAgICB7CisgICAgICAgICAgICBBU1NFUlQocmMgPCAwKTsKKyAgICAg
ICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmlvbW11LT5sb2NrLCBm
bGFncyk7CisgICAgICAgICAgICByZXR1cm4gcmM7CisgICAgICAgIH0KIAog
ICAgICAgICAvKiBVbmRvIHdoYXQgYW1kX2lvbW11X2Rpc2FibGVfZG9tYWlu
X2RldmljZSgpIG1heSBoYXZlIGRvbmUuICovCiAgICAgICAgIGlmICggZHRl
LT5pdF9yb290ICkKQEAgLTE1MiwxNyArMTgwLDc2IEBAIHN0YXRpYyBpbnQg
X19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICAgICAgc3Bpbl91
bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKIAogICAg
ICAgICBhbWRfaW9tbXVfZmx1c2hfZGV2aWNlKGlvbW11LCByZXFfaWQpOwor
ICAgIH0KKyAgICBlbHNlIGlmICggZHRlLT5wdF9yb290ICE9IG1mbl94KHBh
Z2VfdG9fbWZuKGhkLT5hcmNoLmFtZC5yb290X3RhYmxlKSkgKQorICAgIHsK
KyAgICAgICAgLyoKKyAgICAgICAgICogU3RyaWN0bHkgc3BlYWtpbmcgaWYg
dGhlIGRldmljZSBpcyB0aGUgb25seSBvbmUgd2l0aCB0aGlzIHJlcXVlc3Rv
cgorICAgICAgICAgKiBJRCwgaXQgY291bGQgYmUgYWxsb3dlZCB0byBiZSBy
ZS1hc3NpZ25lZCByZWdhcmRsZXNzIG9mIHVuaXR5IG1hcAorICAgICAgICAg
KiBwcmVzZW5jZS4gIEJ1dCBsZXQncyBkZWFsIHdpdGggdGhhdCBjYXNlIG9u
bHkgaWYgaXQgaXMgYWN0dWFsbHkKKyAgICAgICAgICogZm91bmQgaW4gdGhl
IHdpbGQuCisgICAgICAgICAqLworICAgICAgICBpZiAoIHJlcV9pZCAhPSBQ
Q0lfQkRGMihidXMsIGRldmZuKSAmJgorICAgICAgICAgICAgIChzcl9mbGFn
cyAmIFNFVF9ST09UX1dJVEhfVU5JVFlfTUFQKSApCisgICAgICAgICAgICBy
YyA9IC1FT1BOT1RTVVBQOworICAgICAgICBlbHNlCisgICAgICAgICAgICBy
YyA9IGFtZF9pb21tdV9zZXRfcm9vdF9wYWdlX3RhYmxlKAorICAgICAgICAg
ICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRyKGhkLT5hcmNoLmFtZC5y
b290X3RhYmxlKSwKKyAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9t
YWluX2lkLCBoZC0+YXJjaC5hbWQucGFnaW5nX21vZGUsIHNyX2ZsYWdzKTsK
KyAgICAgICAgaWYgKCByYyA8IDAgKQorICAgICAgICB7CisgICAgICAgICAg
ICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3Mp
OworICAgICAgICAgICAgcmV0dXJuIHJjOworICAgICAgICB9CisgICAgICAg
IGlmICggcmMgJiYKKyAgICAgICAgICAgICBkb21haW4gIT0gcGRldi0+ZG9t
YWluICYmCisgICAgICAgICAgICAgLyoKKyAgICAgICAgICAgICAgKiBCeSBu
b24tYXRvbWljYWxseSB1cGRhdGluZyB0aGUgRFRFJ3MgZG9tYWluIElEIGZp
ZWxkIGxhc3QsCisgICAgICAgICAgICAgICogZHVyaW5nIGEgc2hvcnQgd2lu
ZG93IGluIHRpbWUgVExCIGVudHJpZXMgd2l0aCB0aGUgb2xkIGRvbWFpbgor
ICAgICAgICAgICAgICAqIElEIGJ1dCB0aGUgbmV3IHBhZ2UgdGFibGVzIG1h
eSBoYXZlIGJlZW4gaW5zZXJ0ZWQuICBUaGlzIGNvdWxkCisgICAgICAgICAg
ICAgICogYWZmZWN0IEkvTyBvZiBvdGhlciBkZXZpY2VzIHVzaW5nIHRoaXMg
c2FtZSAob2xkKSBkb21haW4gSUQuCisgICAgICAgICAgICAgICogU3VjaCB1
cGRhdGluZyB0aGVyZWZvcmUgaXMgbm90IGEgcHJvYmxlbSBpZiB0aGlzIHdh
cyB0aGUgb25seQorICAgICAgICAgICAgICAqIGRldmljZSBhc3NvY2lhdGVk
IHdpdGggdGhlIG9sZCBkb21haW4gSUQuICBEaXZlcnRpbmcgSS9PIG9mIGFu
eQorICAgICAgICAgICAgICAqIG9mIGEgZHlpbmcgZG9tYWluJ3MgZGV2aWNl
cyB0byB0aGUgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBpcworICAgICAgICAg
ICAgICAqIGludGVuZGVkIGFueXdheS4KKyAgICAgICAgICAgICAgKi8KKyAg
ICAgICAgICAgICAhcGRldi0+ZG9tYWluLT5pc19keWluZyAmJgorICAgICAg
ICAgICAgIChhbnlfcGRldl9iZWhpbmRfaW9tbXUocGRldi0+ZG9tYWluLCBw
ZGV2LCBpb21tdSkgfHwKKyAgICAgICAgICAgICAgcGRldi0+cGhhbnRvbV9z
dHJpZGUpICkKKyAgICAgICAgICAgIEFNRF9JT01NVV9XQVJOKCIgJXBwOiBy
ZWFzc2lnbm1lbnQgbWF5IGNhdXNlICVwZCBkYXRhIGNvcnJ1cHRpb25cbiIs
CisgICAgICAgICAgICAgICAgICAgICAgICAgICAmUENJX1NCREYzKHBkZXYt
PnNlZywgYnVzLCBkZXZmbiksIHBkZXYtPmRvbWFpbik7CisKKyAgICAgICAg
LyoKKyAgICAgICAgICogQ2hlY2sgcmVtYWluaW5nIHNldHRpbmdzIGFyZSBz
dGlsbCBpbiBwbGFjZSBmcm9tIGFuIGVhcmxpZXIgY2FsbAorICAgICAgICAg
KiBoZXJlLiBUaGV5J3JlIGFsbCBpbmRlcGVuZGVudCBvZiB0aGUgZG9tYWlu
LCBzbyBzaG91bGQgbm90IGhhdmUKKyAgICAgICAgICogY2hhbmdlZC4KKyAg
ICAgICAgICovCisgICAgICAgIGlmICggZHRlLT5pdF9yb290ICkKKyAgICAg
ICAgICAgIEFTU0VSVChkdGUtPmludF9jdGwgPT0gSU9NTVVfREVWX1RBQkxF
X0lOVF9DT05UUk9MX1RSQU5TTEFURUQpOworICAgICAgICBBU1NFUlQoZHRl
LT5pdiA9PSBpb21tdV9pbnRyZW1hcCk7CisgICAgICAgIEFTU0VSVChkdGUt
PmV4ID09IGl2cnNfZGV2LT5kdGVfYWxsb3dfZXhjbHVzaW9uKTsKKyAgICAg
ICAgQVNTRVJUKGR0ZS0+c3lzX21ndCA9PSBNQVNLX0VYVFIoaXZyc19kZXYt
PmRldmljZV9mbGFncywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgQUNQSV9JVkhEX1NZU1RFTV9NR01UKSk7CiAKLSAgICAg
ICAgQU1EX0lPTU1VX0RFQlVHKCJTZXR1cCBJL08gcGFnZSB0YWJsZTogZGV2
aWNlIGlkID0gJSN4LCB0eXBlID0gJSN4LCAiCi0gICAgICAgICAgICAgICAg
ICAgICAgICAicm9vdCB0YWJsZSA9ICUjIlBSSXg2NCIsICIKLSAgICAgICAg
ICAgICAgICAgICAgICAgICJkb21haW4gPSAlZCwgcGFnaW5nIG1vZGUgPSAl
ZFxuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgIHJlcV9pZCwgcGRldi0+
dHlwZSwKLSAgICAgICAgICAgICAgICAgICAgICAgIHBhZ2VfdG9fbWFkZHIo
aGQtPmFyY2guYW1kLnJvb3RfdGFibGUpLAotICAgICAgICAgICAgICAgICAg
ICAgICAgZG9tYWluLT5kb21haW5faWQsIGhkLT5hcmNoLmFtZC5wYWdpbmdf
bW9kZSk7CisgICAgICAgIGlmICggcGNpX2F0c19kZXZpY2UoaW9tbXUtPnNl
ZywgYnVzLCBwZGV2LT5kZXZmbikgJiYKKyAgICAgICAgICAgICAhaXZyc19k
ZXYtPmJsb2NrX2F0cyAmJgorICAgICAgICAgICAgIGlvbW11X2hhc19jYXAo
aW9tbXUsIFBDSV9DQVBfSU9UTEJfU0hJRlQpICkKKyAgICAgICAgICAgIEFT
U0VSVChkdGUtPmkgPT0gYXRzX2VuYWJsZWQpOworCisgICAgICAgIHNwaW5f
dW5sb2NrX2lycXJlc3RvcmUoJmlvbW11LT5sb2NrLCBmbGFncyk7CisKKyAg
ICAgICAgYW1kX2lvbW11X2ZsdXNoX2RldmljZShpb21tdSwgcmVxX2lkKTsK
ICAgICB9CiAgICAgZWxzZQogICAgICAgICBzcGluX3VubG9ja19pcnFyZXN0
b3JlKCZpb21tdS0+bG9jaywgZmxhZ3MpOwogCisgICAgQU1EX0lPTU1VX0RF
QlVHKCJTZXR1cCBJL08gcGFnZSB0YWJsZTogZGV2aWNlIGlkID0gJSN4LCB0
eXBlID0gJSN4LCAiCisgICAgICAgICAgICAgICAgICAgICJyb290IHRhYmxl
ID0gJSMiUFJJeDY0IiwgIgorICAgICAgICAgICAgICAgICAgICAiZG9tYWlu
ID0gJWQsIHBhZ2luZyBtb2RlID0gJWRcbiIsCisgICAgICAgICAgICAgICAg
ICAgIHJlcV9pZCwgcGRldi0+dHlwZSwKKyAgICAgICAgICAgICAgICAgICAg
cGFnZV90b19tYWRkcihoZC0+YXJjaC5hbWQucm9vdF90YWJsZSksCisgICAg
ICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBoZC0+YXJjaC5h
bWQucGFnaW5nX21vZGUpOworCiAgICAgQVNTRVJUKHBjaWRldnNfbG9ja2Vk
KCkpOwogCiAgICAgaWYgKCBwY2lfYXRzX2RldmljZShpb21tdS0+c2VnLCBi
dXMsIHBkZXYtPmRldmZuKSAmJgpAQCAtMzY2LDcgKzQ1MywyMCBAQCBzdGF0
aWMgaW50IHJlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluCiAgICAgICAg
IHJldHVybiAtRU5PREVWOwogICAgIH0KIAotICAgIGFtZF9pb21tdV9kaXNh
YmxlX2RvbWFpbl9kZXZpY2Uoc291cmNlLCBpb21tdSwgZGV2Zm4sIHBkZXYp
OworICAgIGlmICggIVFVQVJBTlRJTkVfU0tJUCh0YXJnZXQpICkKKyAgICB7
CisgICAgICAgIHJjID0gYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2Uo
dGFyZ2V0LCBpb21tdSwgZGV2Zm4sIHBkZXYpOworICAgICAgICBpZiAoIHJj
ICkKKyAgICAgICAgICAgIHJldHVybiByYzsKKyAgICB9CisgICAgZWxzZQor
ICAgICAgICBhbWRfaW9tbXVfZGlzYWJsZV9kb21haW5fZGV2aWNlKHNvdXJj
ZSwgaW9tbXUsIGRldmZuLCBwZGV2KTsKKworICAgIGlmICggZGV2Zm4gPT0g
cGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWluICE9IHRhcmdldCApCisgICAg
eworICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFy
Z2V0LT5wZGV2X2xpc3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJn
ZXQ7CisgICAgfQogCiAgICAgLyoKICAgICAgKiBJZiB0aGUgZGV2aWNlIGJl
bG9uZ3MgdG8gdGhlIGhhcmR3YXJlIGRvbWFpbiwgYW5kIGl0IGhhcyBhIHVu
aXR5IG1hcHBpbmcsCkBAIC0zODIsMjUgKzQ4Miw5IEBAIHN0YXRpYyBpbnQg
cmVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4KICAgICAgICAgICAgIHJl
dHVybiByYzsKICAgICB9CiAKLSAgICBpZiAoIGRldmZuID09IHBkZXYtPmRl
dmZuICYmIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gKQotICAgIHsKLSAgICAg
ICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlzdCwgJmRvbV9pby0+cGRl
dl9saXN0KTsKLSAgICAgICAgcGRldi0+ZG9tYWluID0gZG9tX2lvOwotICAg
IH0KLQotICAgIHJjID0gYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2Uo
dGFyZ2V0LCBpb21tdSwgZGV2Zm4sIHBkZXYpOwotICAgIGlmICggcmMgKQot
ICAgICAgICByZXR1cm4gcmM7Ci0KICAgICBBTURfSU9NTVVfREVCVUcoIlJl
LWFzc2lnbiAlcHAgZnJvbSBkb20lZCB0byBkb20lZFxuIiwKICAgICAgICAg
ICAgICAgICAgICAgJnBkZXYtPnNiZGYsIHNvdXJjZS0+ZG9tYWluX2lkLCB0
YXJnZXQtPmRvbWFpbl9pZCk7CiAKLSAgICBpZiAoIGRldmZuID09IHBkZXYt
PmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSB0YXJnZXQgKQotICAgIHsKLSAg
ICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlzdCwgJnRhcmdldC0+
cGRldl9saXN0KTsKLSAgICAgICAgcGRldi0+ZG9tYWluID0gdGFyZ2V0Owot
ICAgIH0KLQogICAgIHJldHVybiAwOwogfQogCg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-07.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSSkKCkFycmFuZ2UgZm9yIGRvbWFpbiBJRCBhbmQg
cGFnZSB0YWJsZSByb290IHRvIGJlIHBhc3NlZCBhcm91bmQsIHRoZSBsYXR0
ZXIgaW4KcGFydGljdWxhciB0byBkb21haW5fcGdkX21hZGRyKCkgc3VjaCB0
aGF0IHRha2luZyBpdCBmcm9tIHRoZSBwZXItZG9tYWluCmZpZWxkcyBjYW4g
YmUgb3ZlcnJpZGRlbi4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVk
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5A
aW50ZWwuY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2V4dGVybi5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9l
eHRlcm4uaApAQCAtODUsOSArODUsMTAgQEAgdm9pZCAqbWFwX3Z0ZF9kb21h
aW5fcGFnZSh1NjQgbWFkZHIpOwogdm9pZCB1bm1hcF92dGRfZG9tYWluX3Bh
Z2UoY29uc3Qgdm9pZCAqdmEpOwogaW50IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IHZ0ZF9pb21t
dSAqaW9tbXUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWlu
dDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2ln
bmVkIGludCBtb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgZG9taWRfdCBkb21pZCwK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHBnZF9t
YWRkciwgdW5zaWduZWQgaW50IG1vZGUpOwogaW50IGRvbWFpbl9jb250ZXh0
X3VubWFwX29uZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCB2dGRf
aW9tbXUgKmlvbW11LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
OCBidXMsIHU4IGRldmZuKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgdWludDhfdCBidXMsIHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQp
OwogaW50IGludGVsX2lvbW11X2dldF9yZXNlcnZlZF9kZXZpY2VfbWVtb3J5
KGlvbW11X2dyZG1fdCAqZnVuYywgdm9pZCAqY3R4dCk7CiAKIHVuc2lnbmVk
IGludCBpb19hcGljX3JlYWRfcmVtYXBfcnRlKHVuc2lnbmVkIGludCBhcGlj
LCB1bnNpZ25lZCBpbnQgcmVnKTsKQEAgLTEwNiw3ICsxMDcsOCBAQCB2b2lk
IHBsYXRmb3JtX3F1aXJrc19pbml0KHZvaWQpOwogdm9pZCB2dGRfb3BzX3By
ZWFtYmxlX3F1aXJrKHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KTsKIHZvaWQg
dnRkX29wc19wb3N0YW1ibGVfcXVpcmsoc3RydWN0IHZ0ZF9pb21tdSAqaW9t
bXUpOwogaW50IF9fbXVzdF9jaGVjayBtZV93aWZpX3F1aXJrKHN0cnVjdCBk
b21haW4gKmRvbWFpbiwgdWludDhfdCBidXMsCi0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdWludDhfdCBkZXZmbiwgdW5zaWduZWQgaW50IG1v
ZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3Qg
ZGV2Zm4sIGRvbWlkX3QgZG9taWQsIHBhZGRyX3QgcGdkX21hZGRyLAorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBtb2Rl
KTsKIHZvaWQgcGNpX3Z0ZF9xdWlyayhjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
KTsKIHZvaWQgcXVpcmtfaW9tbXVfY2FwcyhzdHJ1Y3QgdnRkX2lvbW11ICpp
b21tdSk7CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmMKQEAgLTQzLDcgKzQzLDcgQEAKICNpbmNsdWRlICIuLi9hdHMuaCIKIAog
LyogZG9tX2lvIGlzIHVzZWQgYXMgYSBzZW50aW5lbCBmb3IgcXVhcmFudGlu
ZWQgZGV2aWNlcyAqLwotI2RlZmluZSBRVUFSQU5USU5FX1NLSVAoZCkgKChk
KSA9PSBkb21faW8gJiYgIWRvbV9pb21tdShkKS0+YXJjaC52dGQucGdkX21h
ZGRyKQorI2RlZmluZSBRVUFSQU5USU5FX1NLSVAoZCwgcGdkX21hZGRyKSAo
KGQpID09IGRvbV9pbyAmJiAhKHBnZF9tYWRkcikpCiAKIC8qIFBvc3NpYmxl
IHVuZmlsdGVyZWQgTEFQSUMvTVNJIG1lc3NhZ2VzIGZyb20gdW50cnVzdGVk
IHNvdXJjZXM/ICovCiBib29sIF9fcmVhZF9tb3N0bHkgdW50cnVzdGVkX21z
aTsKQEAgLTM1OCwxNSArMzU4LDE3IEBAIHN0YXRpYyB1NjQgYWRkcl90b19k
bWFfcGFnZV9tYWRkcihzdHJ1Y3QKICAgICByZXR1cm4gcHRlX21hZGRyOwog
fQogCi1zdGF0aWMgdWludDY0X3QgZG9tYWluX3BnZF9tYWRkcihzdHJ1Y3Qg
ZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgbnJfcHRfbGV2ZWxzKQorc3RhdGlj
IHBhZGRyX3QgZG9tYWluX3BnZF9tYWRkcihzdHJ1Y3QgZG9tYWluICpkLCBw
YWRkcl90IHBnZF9tYWRkciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdW5zaWduZWQgaW50IG5yX3B0X2xldmVscykKIHsKICAgICBzdHJ1
Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKLSAgICB1aW50
NjRfdCBwZ2RfbWFkZHI7CiAgICAgdW5zaWduZWQgaW50IGFnYXc7CiAKICAg
ICBBU1NFUlQoc3Bpbl9pc19sb2NrZWQoJmhkLT5hcmNoLm1hcHBpbmdfbG9j
aykpOwogCi0gICAgaWYgKCBpb21tdV91c2VfaGFwX3B0KGQpICkKKyAgICBp
ZiAoIHBnZF9tYWRkciApCisgICAgICAgIC8qIG5vdGhpbmcgKi87CisgICAg
ZWxzZSBpZiAoIGlvbW11X3VzZV9oYXBfcHQoZCkgKQogICAgIHsKICAgICAg
ICAgcGFnZXRhYmxlX3QgcGd0ID0gcDJtX2dldF9wYWdldGFibGUocDJtX2dl
dF9ob3N0cDJtKGQpKTsKIApAQCAtMTM4NSwxOCArMTM4NywxOCBAQCBpbnQg
ZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAgICAgc3RydWN0IGRvbWFp
biAqZG9tYWluLAogICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAogICAg
IHVpbnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLCBjb25zdCBzdHJ1Y3QgcGNp
X2RldiAqcGRldiwKLSAgICB1bnNpZ25lZCBpbnQgbW9kZSkKKyAgICBkb21p
ZF90IGRvbWlkLCBwYWRkcl90IHBnZF9tYWRkciwgdW5zaWduZWQgaW50IG1v
ZGUpCiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9t
bXUoZG9tYWluKTsKICAgICBzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4
dCwgKmNvbnRleHRfZW50cmllcywgbGN0eHQ7CiAgICAgX191aW50MTI4X3Qg
b2xkOwotICAgIHU2NCBtYWRkciwgcGdkX21hZGRyOworICAgIHVpbnQ2NF90
IG1hZGRyOwogICAgIHVpbnQxNl90IHNlZyA9IGlvbW11LT5kcmhkLT5zZWdt
ZW50LCBwcmV2X2RpZCA9IDA7CiAgICAgc3RydWN0IGRvbWFpbiAqcHJldl9k
b20gPSBOVUxMOwogICAgIGludCByYywgcmV0OwogICAgIGJvb2xfdCBmbHVz
aF9kZXZfaW90bGI7CiAKLSAgICBpZiAoIFFVQVJBTlRJTkVfU0tJUChkb21h
aW4pICkKKyAgICBpZiAoIFFVQVJBTlRJTkVfU0tJUChkb21haW4sIHBnZF9t
YWRkcikgKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIEFTU0VSVChwY2lk
ZXZzX2xvY2tlZCgpKTsKQEAgLTE0MzMsMTAgKzE0MzUsMTIgQEAgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIH0KICAgICBlbHNlCiAg
ICAgeworICAgICAgICBwYWRkcl90IHJvb3Q7CisKICAgICAgICAgc3Bpbl9s
b2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogCi0gICAgICAgIHBnZF9t
YWRkciA9IGRvbWFpbl9wZ2RfbWFkZHIoZG9tYWluLCBpb21tdS0+bnJfcHRf
bGV2ZWxzKTsKLSAgICAgICAgaWYgKCAhcGdkX21hZGRyICkKKyAgICAgICAg
cm9vdCA9IGRvbWFpbl9wZ2RfbWFkZHIoZG9tYWluLCBwZ2RfbWFkZHIsIGlv
bW11LT5ucl9wdF9sZXZlbHMpOworICAgICAgICBpZiAoICFyb290ICkKICAg
ICAgICAgewogICAgICAgICAgICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1h
cHBpbmdfbG9jayk7CiAgICAgICAgICAgICBzcGluX3VubG9jaygmaW9tbXUt
PmxvY2spOwpAQCAtMTQ0Niw3ICsxNDUwLDcgQEAgaW50IGRvbWFpbl9jb250
ZXh0X21hcHBpbmdfb25lKAogICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07
CiAgICAgICAgIH0KIAotICAgICAgICBjb250ZXh0X3NldF9hZGRyZXNzX3Jv
b3QobGN0eHQsIHBnZF9tYWRkcik7CisgICAgICAgIGNvbnRleHRfc2V0X2Fk
ZHJlc3Nfcm9vdChsY3R4dCwgcm9vdCk7CiAgICAgICAgIGlmICggYXRzX2Vu
YWJsZWQgJiYgZWNhcF9kZXZfaW90bGIoaW9tbXUtPmVjYXApICkKICAgICAg
ICAgICAgIGNvbnRleHRfc2V0X3RyYW5zbGF0aW9uX3R5cGUobGN0eHQsIENP
TlRFWFRfVFRfREVWX0lPVExCKTsKICAgICAgICAgZWxzZQpAQCAtMTU2Miwx
NSArMTU2NiwyMSBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUo
CiAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7
CiAKICAgICBpZiAoICFzZWcgJiYgIXJjICkKLSAgICAgICAgcmMgPSBtZV93
aWZpX3F1aXJrKGRvbWFpbiwgYnVzLCBkZXZmbiwgbW9kZSk7CisgICAgICAg
IHJjID0gbWVfd2lmaV9xdWlyayhkb21haW4sIGJ1cywgZGV2Zm4sIGRvbWlk
LCBwZ2RfbWFkZHIsIG1vZGUpOwogCiAgICAgaWYgKCByYyApCiAgICAgewog
ICAgICAgICBpZiAoICFwcmV2X2RvbSApCi0gICAgICAgICAgICByZXQgPSBk
b21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgYnVzLCBk
ZXZmbik7CisgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1h
cF9vbmUoZG9tYWluLCBpb21tdSwgYnVzLCBkZXZmbiwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFp
bl9pZCk7CiAgICAgICAgIGVsc2UgaWYgKCBwcmV2X2RvbSAhPSBkb21haW4g
KSAvKiBBdm9pZCBpbmZpbml0ZSByZWN1cnNpb24uICovCisgICAgICAgIHsK
KyAgICAgICAgICAgIGhkID0gZG9tX2lvbW11KHByZXZfZG9tKTsKICAgICAg
ICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKHByZXZf
ZG9tLCBpb21tdSwgYnVzLCBkZXZmbiwgcGRldiwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWlu
X2lkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgaGQtPmFyY2gudnRkLnBnZF9tYWRkciwKICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGUgJiBNQVBfV0lU
SF9STVJSKSA8IDA7CisgICAgICAgIH0KICAgICAgICAgZWxzZQogICAgICAg
ICAgICAgcmV0ID0gMTsKIApAQCAtMTU5Miw2ICsxNjAyLDcgQEAgc3RhdGlj
IGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogewogICAgIGNv
bnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZCA9IGFjcGlfZmluZF9t
YXRjaGVkX2RyaGRfdW5pdChwZGV2KTsKICAgICBjb25zdCBzdHJ1Y3QgYWNw
aV9ybXJyX3VuaXQgKnJtcnI7CisgICAgcGFkZHJfdCBwZ2RfbWFkZHIgPSBk
b21faW9tbXUoZG9tYWluKS0+YXJjaC52dGQucGdkX21hZGRyOwogICAgIGlu
dCByZXQgPSAwOwogICAgIHVuc2lnbmVkIGludCBpLCBtb2RlID0gMDsKICAg
ICB1aW50MTZfdCBzZWcgPSBwZGV2LT5zZWcsIGJkZjsKQEAgLTE2NTQsNyAr
MTY2NSw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhz
dHJ1Y3QKICAgICAgICAgICAgIHByaW50ayhWVERQUkVGSVggIiVwZDpQQ0ll
OiBtYXAgJXBwXG4iLAogICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBD
SV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pKTsKICAgICAgICAgcmV0ID0gZG9t
YWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwg
YnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgcGRldiwgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHBkZXYsIGRvbWFpbi0+ZG9tYWluX2lkLCBw
Z2RfbWFkZHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIG1vZGUpOwogICAgICAgICBpZiAoIHJldCA+IDAgKQogICAgICAg
ICAgICAgcmV0ID0gMDsKICAgICAgICAgaWYgKCAhcmV0ICYmIGRldmZuID09
IHBkZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRldiwgZHJoZCkgPiAwICkK
QEAgLTE2NzEsNyArMTY4Myw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgICAgICAgICBkb21haW4s
ICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7CiAKICAgICAgICAgcmV0
ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5p
b21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgcGRldiwgbW9kZSk7CisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIGRvbWFpbi0+ZG9tYWlu
X2lkLCBwZ2RfbWFkZHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIG1vZGUpOwogICAgICAgICBpZiAoIHJldCA8IDAgKQog
ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIHByZXZfcHJlc2VudCA9IHJl
dDsKQEAgLTE2OTksNyArMTcxMiw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2Nv
bnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICovCiAgICAgICAgIGlm
ICggcmV0ID49IDAgKQogICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRl
eHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZm
biwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIE5VTEwsIG1vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgTlVMTCwgZG9tYWluLT5kb21haW5faWQsIHBn
ZF9tYWRkciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIG1vZGUpOwogCiAgICAgICAgIC8qCiAgICAgICAgICAqIERl
dmljZXMgYmVoaW5kIFBDSWUtdG8tUENJL1BDSXggYnJpZGdlIG1heSBnZW5l
cmF0ZSBkaWZmZXJlbnQKQEAgLTE3MTQsNyArMTcyOCw4IEBAIHN0YXRpYyBp
bnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgaWYg
KCAhcmV0ICYmIHBkZXZfdHlwZShzZWcsIGJ1cywgZGV2Zm4pID09IERFVl9U
WVBFX1BDSWUyUENJX0JSSURHRSAmJgogICAgICAgICAgICAgIChzZWNidXMg
IT0gcGRldi0+YnVzIHx8IHBkZXYtPmRldmZuICE9IDApICkKICAgICAgICAg
ICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwg
ZHJoZC0+aW9tbXUsIHNlY2J1cywgMCwKLSAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIG1vZGUpOworICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwg
ZG9tYWluLT5kb21haW5faWQsIHBnZF9tYWRkciwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGUpOwogCiAgICAg
ICAgIGlmICggcmV0ICkKICAgICAgICAgewpAQCAtMTc0MiwxNCArMTc1Nywx
NCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0
CiBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKAogICAgIHN0cnVjdCBk
b21haW4gKmRvbWFpbiwKICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSwK
LSAgICB1OCBidXMsIHU4IGRldmZuKQorICAgIHVpbnQ4X3QgYnVzLCB1aW50
OF90IGRldmZuLCBkb21pZF90IGRvbWlkKQogewogICAgIHN0cnVjdCBjb250
ZXh0X2VudHJ5ICpjb250ZXh0LCAqY29udGV4dF9lbnRyaWVzOwogICAgIHU2
NCBtYWRkcjsKICAgICBpbnQgaW9tbXVfZG9taWQsIHJjLCByZXQ7CiAgICAg
Ym9vbF90IGZsdXNoX2Rldl9pb3RsYjsKIAotICAgIGlmICggUVVBUkFOVElO
RV9TS0lQKGRvbWFpbikgKQorICAgIGlmICggUVVBUkFOVElORV9TS0lQKGRv
bWFpbiwgZG9tX2lvbW11KGRvbWFpbiktPmFyY2gudnRkLnBnZF9tYWRkcikg
KQogICAgICAgICByZXR1cm4gMDsKIAogICAgIEFTU0VSVChwY2lkZXZzX2xv
Y2tlZCgpKTsKQEAgLTE4MDMsNyArMTgxOCw3IEBAIGludCBkb21haW5fY29u
dGV4dF91bm1hcF9vbmUoCiAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNv
bnRleHRfZW50cmllcyk7CiAKICAgICBpZiAoICFpb21tdS0+ZHJoZC0+c2Vn
bWVudCAmJiAhcmMgKQotICAgICAgICByYyA9IG1lX3dpZmlfcXVpcmsoZG9t
YWluLCBidXMsIGRldmZuLCBVTk1BUF9NRV9QSEFOVE9NX0ZVTkMpOworICAg
ICAgICByYyA9IG1lX3dpZmlfcXVpcmsoZG9tYWluLCBidXMsIGRldmZuLCBk
b21pZCwgMCwgVU5NQVBfTUVfUEhBTlRPTV9GVU5DKTsKIAogICAgIGlmICgg
cmMgJiYgIWlzX2hhcmR3YXJlX2RvbWFpbihkb21haW4pICYmIGRvbWFpbiAh
PSBkb21faW8gKQogICAgIHsKQEAgLTE4NTAsNyArMTg2NSw4IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3RydWN0IGQKICAgICAgICAg
aWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAgICAgICBwcmludGsoVlREUFJF
RklYICIlcGQ6UENJZTogdW5tYXAgJXBwXG4iLAogICAgICAgICAgICAgICAg
ICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pKTsKLSAg
ICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwg
aW9tbXUsIGJ1cywgZGV2Zm4pOworICAgICAgICByZXQgPSBkb21haW5fY29u
dGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgYnVzLCBkZXZmbiwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+
ZG9tYWluX2lkKTsKICAgICAgICAgaWYgKCAhcmV0ICYmIGRldmZuID09IHBk
ZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRldiwgZHJoZCkgPiAwICkKICAg
ICAgICAgICAgIGRpc2FibGVfYXRzX2RldmljZShwZGV2KTsKIApAQCAtMTg2
Myw3ICsxODc5LDggQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1h
cChzdHJ1Y3QgZAogICAgICAgICBpZiAoIGlvbW11X2RlYnVnICkKICAgICAg
ICAgICAgIHByaW50ayhWVERQUkVGSVggIiVwZDpQQ0k6IHVubWFwICVwcFxu
IiwKICAgICAgICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2Vn
LCBidXMsIGRldmZuKSk7Ci0gICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0
X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMsIGRldmZuKTsKKyAgICAg
ICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9t
bXUsIGJ1cywgZGV2Zm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7CiAgICAgICAgIGlmICgg
cmV0ICkKICAgICAgICAgICAgIGJyZWFrOwogCkBAIC0xODg5LDEyICsxOTA2
LDE1IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3RydWN0
IGQKICAgICAgICAgLyogUENJZSB0byBQQ0kvUENJeCBicmlkZ2UgKi8KICAg
ICAgICAgaWYgKCBwZGV2X3R5cGUoc2VnLCB0bXBfYnVzLCB0bXBfZGV2Zm4p
ID09IERFVl9UWVBFX1BDSWUyUENJX0JSSURHRSApCiAgICAgICAgIHsKLSAg
ICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21h
aW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4pOworICAgICAgICAgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUs
IHRtcF9idXMsIHRtcF9kZXZmbiwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7CiAgICAg
ICAgICAgICBpZiAoICFyZXQgKQotICAgICAgICAgICAgICAgIHJldCA9IGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBzZWNidXMs
IDApOworICAgICAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3Vu
bWFwX29uZShkb21haW4sIGlvbW11LCBzZWNidXMsIDAsCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+
ZG9tYWluX2lkKTsKICAgICAgICAgfQogICAgICAgICBlbHNlIC8qIExlZ2Fj
eSBQQ0kgYnJpZGdlICovCi0gICAgICAgICAgICByZXQgPSBkb21haW5fY29u
dGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgdG1wX2J1cywgdG1wX2Rl
dmZuKTsKKyAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFw
X29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4sCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWlu
LT5kb21haW5faWQpOwogCiAgICAgICAgIGJyZWFrOwogCkBAIC0xOTA0LDcg
KzE5MjQsOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X3VubWFwKHN0
cnVjdCBkCiAgICAgICAgIHJldHVybiAtRUlOVkFMOwogICAgIH0KIAotICAg
IGlmICggIXJldCAmJiAhUVVBUkFOVElORV9TS0lQKGRvbWFpbikgJiYgcGRl
di0+ZGV2Zm4gPT0gZGV2Zm4gKQorICAgIGlmICggIXJldCAmJiBwZGV2LT5k
ZXZmbiA9PSBkZXZmbiAmJgorICAgICAgICAgIVFVQVJBTlRJTkVfU0tJUChk
b21haW4sIGRvbV9pb21tdShkb21haW4pLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIp
ICkKICAgICAgICAgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAoZG9tYWluLCBw
ZGV2LCBpb21tdSk7CiAKICAgICByZXR1cm4gcmV0OwpAQCAtMjUxMSw3ICsy
NTMyLDcgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlw
KAogewogICAgIGludCByZXQ7CiAKLSAgICBpZiAoICFRVUFSQU5USU5FX1NL
SVAodGFyZ2V0KSApCisgICAgaWYgKCAhUVVBUkFOVElORV9TS0lQKHRhcmdl
dCwgZG9tX2lvbW11KHRhcmdldCktPmFyY2gudnRkLnBnZF9tYWRkcikgKQog
ICAgIHsKICAgICAgICAgaWYgKCAhaGFzX2FyY2hfcGRldnModGFyZ2V0KSAp
CiAgICAgICAgICAgICB2bXhfcGlfaG9va3NfYXNzaWduKHRhcmdldCk7CkBA
IC0yNTI2LDcgKzI1NDcsOCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2Rldmlj
ZV9vd25lcnNoaXAoCiAKICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRf
bWFwcGluZyh0YXJnZXQsIGRldmZuLCBwZGV2KTsKIAotICAgICAgICBpZiAo
ICFyZXQgJiYgIVFVQVJBTlRJTkVfU0tJUChzb3VyY2UpICYmIHBkZXYtPmRl
dmZuID09IGRldmZuICkKKyAgICAgICAgaWYgKCAhcmV0ICYmIHBkZXYtPmRl
dmZuID09IGRldmZuICYmCisgICAgICAgICAgICAgIVFVQVJBTlRJTkVfU0tJ
UChzb3VyY2UsIGRvbV9pb21tdShzb3VyY2UpLT5hcmNoLnZ0ZC5wZ2RfbWFk
ZHIpICkKICAgICAgICAgewogICAgICAgICAgICAgY29uc3Qgc3RydWN0IGFj
cGlfZHJoZF91bml0ICpkcmhkID0gYWNwaV9maW5kX21hdGNoZWRfZHJoZF91
bml0KHBkZXYpOwogCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0
ZC9xdWlya3MuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv
cXVpcmtzLmMKQEAgLTQwOCw2ICs0MDgsOCBAQCB2b2lkIF9faW5pdCBwbGF0
Zm9ybV9xdWlya3NfaW5pdCh2b2lkKQogCiBzdGF0aWMgaW50IF9fbXVzdF9j
aGVjayBtYXBfbWVfcGhhbnRvbV9mdW5jdGlvbihzdHJ1Y3QgZG9tYWluICpk
b21haW4sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB1bnNpZ25lZCBpbnQgZGV2LAorICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9taWRfdCBkb21p
ZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHBhZGRyX3QgcGdkX21hZGRyLAogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG1v
ZGUpCiB7CiAgICAgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkOwpAQCAt
NDIxLDE2ICs0MjMsMTcgQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgbWFw
X21lX3BoYW50b21fZgogICAgIC8qIG1hcCBvciB1bm1hcCBNRSBwaGFudG9t
IGZ1bmN0aW9uICovCiAgICAgaWYgKCAhKG1vZGUgJiBVTk1BUF9NRV9QSEFO
VE9NX0ZVTkMpICkKICAgICAgICAgcmMgPSBkb21haW5fY29udGV4dF9tYXBw
aW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCAwLAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcp
LCBOVUxMLCBtb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBQQ0lfREVWRk4oZGV2LCA3KSwgTlVMTCwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21pZCwgcGdkX21h
ZGRyLCBtb2RlKTsKICAgICBlbHNlCiAgICAgICAgIHJjID0gZG9tYWluX2Nv
bnRleHRfdW5tYXBfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIDAsCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihk
ZXYsIDcpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgUENJX0RFVkZOKGRldiwgNyksIGRvbWlkKTsKIAogICAgIHJldHVybiBy
YzsKIH0KIAogaW50IG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9t
YWluLCB1aW50OF90IGJ1cywgdWludDhfdCBkZXZmbiwKLSAgICAgICAgICAg
ICAgICAgIHVuc2lnbmVkIGludCBtb2RlKQorICAgICAgICAgICAgICAgICAg
ZG9taWRfdCBkb21pZCwgcGFkZHJfdCBwZ2RfbWFkZHIsIHVuc2lnbmVkIGlu
dCBtb2RlKQogewogICAgIHUzMiBpZDsKICAgICBpbnQgcmMgPSAwOwpAQCAt
NDU0LDcgKzQ1Nyw3IEBAIGludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21h
aW4gKmRvbWFpbiwKICAgICAgICAgICAgIGNhc2UgMHg0MjNiODA4NjoKICAg
ICAgICAgICAgIGNhc2UgMHg0MjNjODA4NjoKICAgICAgICAgICAgIGNhc2Ug
MHg0MjNkODA4NjoKLSAgICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFu
dG9tX2Z1bmN0aW9uKGRvbWFpbiwgMywgbW9kZSk7CisgICAgICAgICAgICAg
ICAgcmMgPSBtYXBfbWVfcGhhbnRvbV9mdW5jdGlvbihkb21haW4sIDMsIGRv
bWlkLCBwZ2RfbWFkZHIsIG1vZGUpOwogICAgICAgICAgICAgICAgIGJyZWFr
OwogICAgICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICBicmVh
azsKQEAgLTQ4MCw3ICs0ODMsNyBAQCBpbnQgbWVfd2lmaV9xdWlyayhzdHJ1
Y3QgZG9tYWluICpkb21haW4sCiAgICAgICAgICAgICBjYXNlIDB4NDIzODgw
ODY6ICAgICAgICAvKiBQdW1hIFBlYWsgKi8KICAgICAgICAgICAgIGNhc2Ug
MHg0MjJiODA4NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjJjODA4NjoKLSAg
ICAgICAgICAgICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKGRv
bWFpbiwgMjIsIG1vZGUpOworICAgICAgICAgICAgICAgIHJjID0gbWFwX21l
X3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAyMiwgZG9taWQsIHBnZF9tYWRk
ciwgbW9kZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg
ICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIGJyZWFrOwo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-08.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSUkpCgpSZXBsYWNlIHRoZSBwYXNzaW5nIG9mIHN0
cnVjdCBkb21haW4gKiBieSBkb21pZF90IGluIHByZXBhcmF0aW9uIG9mCnBl
ci1kZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBhbHNvIHJlcXVpcmlu
ZyBwZXItZGV2aWNlIHBzZXVkbwpkb21haW4gSURzLCB3aGljaCBhcmVuJ3Qg
Z29pbmcgdG8gYmUgYXNzb2NpYXRlZCB3aXRoIGFueSBzdHJ1Y3QgZG9tYWlu
Cmluc3RhbmNlcy4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkIChl
eGNlcHQgZm9yIHNsaWdodGx5IGFkanVzdGVkIGxvZyBtZXNzYWdlCnRleHQp
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNv
bT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMKQEAgLTYyLDggKzYyLDggQEAgc3RhdGljIHN0cnVjdCB0YXNrbGV0
IHZ0ZF9mYXVsdF90YXNrbGV0Owogc3RhdGljIGludCBzZXR1cF9od2RvbV9k
ZXZpY2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICopOwogc3RhdGljIHZv
aWQgc2V0dXBfaHdkb21fcm1ycihzdHJ1Y3QgZG9tYWluICpkKTsKIAotc3Rh
dGljIGludCBkb21haW5faW9tbXVfZG9taWQoc3RydWN0IGRvbWFpbiAqZCwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11KQorc3RhdGljIGludCBnZXRfaW9tbXVfZGlkKGRvbWlkX3Qg
ZG9taWQsIGNvbnN0IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAorICAgICAg
ICAgICAgICAgICAgICAgICAgIGJvb2wgd2FybikKIHsKICAgICB1bnNpZ25l
ZCBsb25nIG5yX2RvbSwgaTsKIApAQCAtNzEsMTYgKzcxLDE2IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2lvbW11X2RvbWlkKHN0cnVjdCBkb20KICAgICBpID0g
ZmluZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsK
ICAgICB3aGlsZSAoIGkgPCBucl9kb20gKQogICAgIHsKLSAgICAgICAgaWYg
KCBpb21tdS0+ZG9taWRfbWFwW2ldID09IGQtPmRvbWFpbl9pZCApCisgICAg
ICAgIGlmICggaW9tbXUtPmRvbWlkX21hcFtpXSA9PSBkb21pZCApCiAgICAg
ICAgICAgICByZXR1cm4gaTsKIAogICAgICAgICBpID0gZmluZF9uZXh0X2Jp
dChpb21tdS0+ZG9taWRfYml0bWFwLCBucl9kb20sIGkrMSk7CiAgICAgfQog
Ci0gICAgaWYgKCAhZC0+aXNfZHlpbmcgKQorICAgIGlmICggd2FybiApCiAg
ICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsCi0gICAgICAg
ICAgICAgICAgIkNhbm5vdCBnZXQgdmFsaWQgaW9tbXUgJXUgZG9taWQ6ICVw
ZFxuIiwKLSAgICAgICAgICAgICAgICBpb21tdS0+aW5kZXgsIGQpOworICAg
ICAgICAgICAgICAgICJObyB2YWxpZCBpb21tdSAldSBkb21pZCBmb3IgRG9t
JWRcbiIsCisgICAgICAgICAgICAgICAgaW9tbXUtPmluZGV4LCBkb21pZCk7
CiAKICAgICByZXR1cm4gLTE7CiB9CkBAIC04OCw4ICs4OCw3IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2lvbW11X2RvbWlkKHN0cnVjdCBkb20KICNkZWZpbmUg
RElEX0ZJRUxEX1dJRFRIIDE2CiAjZGVmaW5lIERJRF9ISUdIX09GRlNFVCA4
CiBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9pZChzdHJ1Y3QgY29u
dGV4dF9lbnRyeSAqY29udGV4dCwKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHN0cnVjdCBkb21haW4gKmQsCi0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlkX3QgZG9taWQs
IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQogewogICAgIHVuc2lnbmVkIGxv
bmcgbnJfZG9tLCBpOwogICAgIGludCBmb3VuZCA9IDA7CkBAIC0xMDAsNyAr
OTksNyBAQCBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9pZChzdHJ1
Y3QKICAgICBpID0gZmluZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1h
cCwgbnJfZG9tKTsKICAgICB3aGlsZSAoIGkgPCBucl9kb20gKQogICAgIHsK
LSAgICAgICAgaWYgKCBpb21tdS0+ZG9taWRfbWFwW2ldID09IGQtPmRvbWFp
bl9pZCApCisgICAgICAgIGlmICggaW9tbXUtPmRvbWlkX21hcFtpXSA9PSBk
b21pZCApCiAgICAgICAgIHsKICAgICAgICAgICAgIGZvdW5kID0gMTsKICAg
ICAgICAgICAgIGJyZWFrOwpAQCAtMTE2LDcgKzExNSw3IEBAIHN0YXRpYyBp
bnQgY29udGV4dF9zZXRfZG9tYWluX2lkKHN0cnVjdAogICAgICAgICAgICAg
ZHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWCwgIklPTU1VOiBubyBmcmVl
IGRvbWFpbiBpZHNcbiIpOwogICAgICAgICAgICAgcmV0dXJuIC1FRkFVTFQ7
CiAgICAgICAgIH0KLSAgICAgICAgaW9tbXUtPmRvbWlkX21hcFtpXSA9IGQt
PmRvbWFpbl9pZDsKKyAgICAgICAgaW9tbXUtPmRvbWlkX21hcFtpXSA9IGRv
bWlkOwogICAgIH0KIAogICAgIHNldF9iaXQoaSwgaW9tbXUtPmRvbWlkX2Jp
dG1hcCk7CkBAIC0xMjUsOSArMTI0LDkgQEAgc3RhdGljIGludCBjb250ZXh0
X3NldF9kb21haW5faWQoc3RydWN0CiAgICAgcmV0dXJuIDA7CiB9CiAKLXN0
YXRpYyB2b2lkIGNsZWFudXBfZG9taWRfbWFwKHN0cnVjdCBkb21haW4gKmRv
bWFpbiwgc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUpCitzdGF0aWMgdm9pZCBj
bGVhbnVwX2RvbWlkX21hcChkb21pZF90IGRvbWlkLCBzdHJ1Y3QgdnRkX2lv
bW11ICppb21tdSkKIHsKLSAgICBpbnQgaW9tbXVfZG9taWQgPSBkb21haW5f
aW9tbXVfZG9taWQoZG9tYWluLCBpb21tdSk7CisgICAgaW50IGlvbW11X2Rv
bWlkID0gZ2V0X2lvbW11X2RpZChkb21pZCwgaW9tbXUsIGZhbHNlKTsKIAog
ICAgIGlmICggaW9tbXVfZG9taWQgPj0gMCApCiAgICAgewpAQCAtMTY3LDcg
KzE2Niw3IEBAIHN0YXRpYyBib29sIGFueV9wZGV2X2JlaGluZF9pb21tdShj
b25zdAogICogSWYgbm8gb3RoZXIgZGV2aWNlcyB1bmRlciB0aGUgc2FtZSBp
b21tdSBvd25lZCBieSB0aGlzIGRvbWFpbiwKICAqIGNsZWFyIGlvbW11IGlu
IGlvbW11X2JpdG1hcCBhbmQgY2xlYXIgZG9tYWluX2lkIGluIGRvbWlkX2Jp
dG1hcC4KICAqLwotc3RhdGljIHZvaWQgY2hlY2tfY2xlYW51cF9kb21pZF9t
YXAoc3RydWN0IGRvbWFpbiAqZCwKK3N0YXRpYyB2b2lkIGNoZWNrX2NsZWFu
dXBfZG9taWRfbWFwKGNvbnN0IHN0cnVjdCBkb21haW4gKmQsCiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNp
X2RldiAqZXhjbHVkZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQogewpAQCAtMTgzLDcg
KzE4Miw3IEBAIHN0YXRpYyB2b2lkIGNoZWNrX2NsZWFudXBfZG9taWRfbWFw
KHN0cnUKICAgICBpZiAoICFmb3VuZCApCiAgICAgewogICAgICAgICBjbGVh
cl9iaXQoaW9tbXUtPmluZGV4LCBkb21faW9tbXUoZCktPmFyY2gudnRkLmlv
bW11X2JpdG1hcCk7Ci0gICAgICAgIGNsZWFudXBfZG9taWRfbWFwKGQsIGlv
bW11KTsKKyAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZC0+ZG9tYWluX2lk
LCBpb21tdSk7CiAgICAgfQogfQogCkBAIC02ODMsNyArNjgyLDcgQEAgc3Rh
dGljIGludCBfX211c3RfY2hlY2sgaW9tbXVfZmx1c2hfaW90bAogICAgICAg
ICAgICAgY29udGludWU7CiAKICAgICAgICAgZmx1c2hfZGV2X2lvdGxiID0g
ISFmaW5kX2F0c19kZXZfZHJoZChpb21tdSk7Ci0gICAgICAgIGlvbW11X2Rv
bWlkPSBkb21haW5faW9tbXVfZG9taWQoZCwgaW9tbXUpOworICAgICAgICBp
b21tdV9kb21pZCA9IGdldF9pb21tdV9kaWQoZC0+ZG9tYWluX2lkLCBpb21t
dSwgIWQtPmlzX2R5aW5nKTsKICAgICAgICAgaWYgKCBpb21tdV9kb21pZCA9
PSAtMSApCiAgICAgICAgICAgICBjb250aW51ZTsKIApAQCAtMTQ1OSw3ICsx
NDU4LDcgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAg
ICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKICAg
ICB9CiAKLSAgICBpZiAoIGNvbnRleHRfc2V0X2RvbWFpbl9pZCgmbGN0eHQs
IGRvbWFpbiwgaW9tbXUpICkKKyAgICBpZiAoIGNvbnRleHRfc2V0X2RvbWFp
bl9pZCgmbGN0eHQsIGRvbWlkLCBpb21tdSkgKQogICAgIHsKICAgICB1bmxv
Y2s6CiAgICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7CkBAIC0x
Nzg1LDcgKzE3ODQsNyBAQCBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KAogICAgIGNvbnRleHRfY2xlYXJfZW50cnkoKmNvbnRleHQpOwogICAgIGlv
bW11X3N5bmNfY2FjaGUoY29udGV4dCwgc2l6ZW9mKHN0cnVjdCBjb250ZXh0
X2VudHJ5KSk7CiAKLSAgICBpb21tdV9kb21pZD0gZG9tYWluX2lvbW11X2Rv
bWlkKGRvbWFpbiwgaW9tbXUpOworICAgIGlvbW11X2RvbWlkID0gZ2V0X2lv
bW11X2RpZChkb21pZCwgaW9tbXUsICFkb21haW4tPmlzX2R5aW5nKTsKICAg
ICBpZiAoIGlvbW11X2RvbWlkID09IC0xICkKICAgICB7CiAgICAgICAgIHNw
aW5fdW5sb2NrKCZpb21tdS0+bG9jayk7CkBAIC0xOTUzLDcgKzE5NTIsNyBA
QCBzdGF0aWMgdm9pZCBpb21tdV9kb21haW5fdGVhcmRvd24oc3RydWN0CiAg
ICAgQVNTRVJUKCFoZC0+YXJjaC52dGQucGdkX21hZGRyKTsKIAogICAgIGZv
cl9lYWNoX2RyaGRfdW5pdCAoIGRyaGQgKQotICAgICAgICBjbGVhbnVwX2Rv
bWlkX21hcChkLCBkcmhkLT5pb21tdSk7CisgICAgICAgIGNsZWFudXBfZG9t
aWRfbWFwKGQtPmRvbWFpbl9pZCwgZHJoZC0+aW9tbXUpOwogCiAgICAgWEZS
RUUoaGQtPmFyY2gudnRkLmlvbW11X2JpdG1hcCk7CiB9Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-09.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IG1haW50YWluIGEgcGVyLWRldmljZSBwc2V1ZG8gZG9t
YWluIElECgpJbiBvcmRlciB0byBzdWJzZXF1ZW50bHkgZW5hYmxlIHBlci1k
ZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcywgd2UnbGwKbmVlZCBkb21h
aW4tSUQtbGlrZSBpZGVudGlmaWVycyB0byBiZSBpbnNlcnRlZCBpbiB0aGUg
cmVzcGVjdGl2ZSBkZXZpY2UKKEFNRCkgb3IgY29udGV4dCAoSW50ZWwpIHRh
YmxlIGVudHJpZXMgYWxvbmdzaWRlIHRoZSBwZXItZGV2aWNlIHBhZ2UKdGFi
bGUgcm9vdCBhZGRyZXNzZXMuCgpNYWtlIHVzZSBvZiAicmVhbCIgZG9tYWlu
IElEcyBvY2N1cHlpbmcgb25seSBoYWxmIG9mIHRoZSB2YWx1ZSByYW5nZQpj
b3ZlcmFibGUgYnkgZG9taWRfdC4KCk5vdGUgdGhhdCBpbiBWVC1kJ3MgaW9t
bXVfYWxsb2MoKSBJIGRpZG4ndCB3YW50IHRvIGludHJvZHVjZSBuZXcgbWVt
b3J5CmxlYWtzIGluIGNhc2Ugb2YgZXJyb3IsIGJ1dCBleGlzdGluZyBvbmVz
IGRvbid0IGdldCBwbHVnZ2VkIC0gdGhhdCdsbCBiZQp0aGUgc3ViamVjdCBv
ZiBhIGxhdGVyIGNoYW5nZS4KClRoZSBWVC1kIGNoYW5nZXMgYXJlIHNsaWdo
dGx5IGFzeW1tZXRyaWMsIGJ1dCB0aGlzIHdheSB3ZSBjYW4gYXZvaWQKYXNz
aWduaW5nIHBzZXVkbyBkb21haW4gSURzIHRvIGRldmljZXMgd2hpY2ggd291
bGQgbmV2ZXIgYmUgbWFwcGVkIHdoaWxlCnN0aWxsIGF2b2lkaW5nIHRvIGFk
ZCBhIG5ldyBwYXJhbWV0ZXIgdG8gZG9tYWluX2NvbnRleHRfdW5tYXAoKS4K
ClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpS
ZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaW9tbXUuaAor
KysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKQEAgLTE0MSw2ICsx
NDEsMTAgQEAgaW50IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9k
ZXNjCiAgICAgICAgIGlvbW11X3ZjYWxsKG9wcywgc3luY19jYWNoZSwgYWRk
ciwgc2l6ZSk7ICAgICAgIFwKIH0pCiAKK3Vuc2lnbmVkIGxvbmcgKmlvbW11
X2luaXRfZG9taWQodm9pZCk7Citkb21pZF90IGlvbW11X2FsbG9jX2RvbWlk
KHVuc2lnbmVkIGxvbmcgKm1hcCk7Cit2b2lkIGlvbW11X2ZyZWVfZG9taWQo
ZG9taWRfdCBkb21pZCwgdW5zaWduZWQgbG9uZyAqbWFwKTsKKwogaW50IF9f
bXVzdF9jaGVjayBpb21tdV9mcmVlX3BndGFibGVzKHN0cnVjdCBkb21haW4g
KmQpOwogc3RydWN0IGRvbWFpbl9pb21tdTsKIHN0cnVjdCBwYWdlX2luZm8g
Kl9fbXVzdF9jaGVjayBpb21tdV9hbGxvY19wZ3RhYmxlKHN0cnVjdCBkb21h
aW5faW9tbXUgKmhkKTsKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2ku
aAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oCkBAIC0xMyw2ICsx
MywxMiBAQAogCiBzdHJ1Y3QgYXJjaF9wY2lfZGV2IHsKICAgICB2bWFza190
IHVzZWRfdmVjdG9yczsKKyAgICAvKgorICAgICAqIFRoZXNlIGZpZWxkcyBh
cmUgKGRlKWluaXRpYWxpemVkIHVuZGVyIHBjaWRldnMtbG9jay4gT3RoZXIg
dXNlcyBvZgorICAgICAqIHRoZW0gZG9uJ3QgcmFjZSAoZGUpaW5pdGlhbGl6
YXRpb24gYW5kIGhlbmNlIGRvbid0IHN0cmljdGx5IG5lZWQgYW55CisgICAg
ICogbG9ja2luZy4KKyAgICAgKi8KKyAgICBkb21pZF90IHBzZXVkb19kb21p
ZDsKIH07CiAKIGludCBwY2lfY29uZl93cml0ZV9pbnRlcmNlcHQodW5zaWdu
ZWQgaW50IHNlZywgdW5zaWduZWQgaW50IGJkZiwKQEAgLTM2LDYgKzQyLDYg
QEAgc3RhdGljIGFsd2F5c19pbmxpbmUgYm9vbCBpc19wY2lfcGFzc3Rocgog
ICAgIHJldHVybiB0cnVlOwogfQogCi1zdGF0aWMgaW5saW5lIHZvaWQgYXJj
aF9wY2lfaW5pdF9wZGV2KHN0cnVjdCBwY2lfZGV2ICpwZGV2KSB7fQordm9p
ZCBhcmNoX3BjaV9pbml0X3BkZXYoc3RydWN0IHBjaV9kZXYgKnBkZXYpOwog
CiAjZW5kaWYgLyogX19YODZfUENJX0hfXyAqLwotLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUuaAorKysgYi94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC9hbWQvaW9tbXUuaApAQCAtOTYsNiArOTYsNyBAQCBzdHJ1
Y3QgYW1kX2lvbW11IHsKICAgICBzdHJ1Y3QgcmluZ19idWZmZXIgY21kX2J1
ZmZlcjsKICAgICBzdHJ1Y3QgcmluZ19idWZmZXIgZXZlbnRfbG9nOwogICAg
IHN0cnVjdCByaW5nX2J1ZmZlciBwcHJfbG9nOworICAgIHVuc2lnbmVkIGxv
bmcgKmRvbWlkX21hcDsKIAogICAgIGludCBleGNsdXNpb25fZW5hYmxlOwog
ICAgIGludCBleGNsdXNpb25fYWxsb3dfYWxsOwotLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfZGV0ZWN0LmMKKysrIGIveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2RldGVjdC5jCkBAIC0yMjMs
NiArMjIzLDExIEBAIGludCBfX2luaXQgYW1kX2lvbW11X2RldGVjdF9vbmVf
YWNwaSgKICAgICBpZiAoIHJ0ICkKICAgICAgICAgZ290byBvdXQ7CiAKKyAg
ICBpb21tdS0+ZG9taWRfbWFwID0gaW9tbXVfaW5pdF9kb21pZCgpOworICAg
IHJ0ID0gLUVOT01FTTsKKyAgICBpZiAoICFpb21tdS0+ZG9taWRfbWFwICkK
KyAgICAgICAgZ290byBvdXQ7CisKICAgICBydCA9IHBjaV9yb19kZXZpY2Uo
aW9tbXUtPnNlZywgYnVzLCBQQ0lfREVWRk4oZGV2LCBmdW5jKSk7CiAgICAg
aWYgKCBydCApCiAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJDb3VsZCBu
b3QgbWFyayBjb25maWcgc3BhY2Ugb2YgJXBwIHJlYWQtb25seSAoJWQpXG4i
LApAQCAtMjMzLDcgKzIzOCwxMCBAQCBpbnQgX19pbml0IGFtZF9pb21tdV9k
ZXRlY3Rfb25lX2FjcGkoCiAKICBvdXQ6CiAgICAgaWYgKCBydCApCisgICAg
eworICAgICAgICB4ZnJlZShpb21tdS0+ZG9taWRfbWFwKTsKICAgICAgICAg
eGZyZWUoaW9tbXUpOworICAgIH0KIAogICAgIHJldHVybiBydDsKIH0KLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUu
YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9p
b21tdS5jCkBAIC01MzksNiArNTM5LDggQEAgc3RhdGljIGludCBhbWRfaW9t
bXVfYWRkX2RldmljZSh1OCBkZXZmbgogICAgIHN0cnVjdCBhbWRfaW9tbXUg
KmlvbW11OwogICAgIHUxNiBiZGY7CiAgICAgc3RydWN0IGl2cnNfbWFwcGlu
Z3MgKml2cnNfbWFwcGluZ3M7CisgICAgYm9vbCBmcmVzaF9kb21pZCA9IGZh
bHNlOworICAgIGludCByZXQ7CiAKICAgICBpZiAoICFwZGV2LT5kb21haW4g
KQogICAgICAgICByZXR1cm4gLUVJTlZBTDsKQEAgLTYwNiw3ICs2MDgsMjIg
QEAgc3RhdGljIGludCBhbWRfaW9tbXVfYWRkX2RldmljZSh1OCBkZXZmbgog
ICAgICAgICBBTURfSU9NTVVfV0FSTigiJXBkOiB1bml0eSBtYXBwaW5nIGZh
aWxlZCBmb3IgJXBwXG4iLAogICAgICAgICAgICAgICAgICAgICAgICBwZGV2
LT5kb21haW4sICZwZGV2LT5zYmRmKTsKIAotICAgIHJldHVybiBhbWRfaW9t
bXVfc2V0dXBfZG9tYWluX2RldmljZShwZGV2LT5kb21haW4sIGlvbW11LCBk
ZXZmbiwgcGRldik7CisgICAgaWYgKCBpb21tdV9xdWFyYW50aW5lICYmIHBk
ZXYtPmFyY2gucHNldWRvX2RvbWlkID09IERPTUlEX0lOVkFMSUQgKQorICAg
IHsKKyAgICAgICAgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBpb21tdV9h
bGxvY19kb21pZChpb21tdS0+ZG9taWRfbWFwKTsKKyAgICAgICAgaWYgKCBw
ZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9PSBET01JRF9JTlZBTElEICkKKyAg
ICAgICAgICAgIHJldHVybiAtRU5PU1BDOworICAgICAgICBmcmVzaF9kb21p
ZCA9IHRydWU7CisgICAgfQorCisgICAgcmV0ID0gYW1kX2lvbW11X3NldHVw
X2RvbWFpbl9kZXZpY2UocGRldi0+ZG9tYWluLCBpb21tdSwgZGV2Zm4sIHBk
ZXYpOworICAgIGlmICggcmV0ICYmIGZyZXNoX2RvbWlkICkKKyAgICB7Cisg
ICAgICAgIGlvbW11X2ZyZWVfZG9taWQocGRldi0+YXJjaC5wc2V1ZG9fZG9t
aWQsIGlvbW11LT5kb21pZF9tYXApOworICAgICAgICBwZGV2LT5hcmNoLnBz
ZXVkb19kb21pZCA9IERPTUlEX0lOVkFMSUQ7CisgICAgfQorCisgICAgcmV0
dXJuIHJldDsKIH0KIAogc3RhdGljIGludCBhbWRfaW9tbXVfcmVtb3ZlX2Rl
dmljZSh1OCBkZXZmbiwgc3RydWN0IHBjaV9kZXYgKnBkZXYpCkBAIC02Mzgs
NiArNjU1LDkgQEAgc3RhdGljIGludCBhbWRfaW9tbXVfcmVtb3ZlX2Rldmlj
ZSh1OCBkZQogICAgICAgICBBTURfSU9NTVVfV0FSTigiJXBkOiB1bml0eSB1
bm1hcHBpbmcgZmFpbGVkIGZvciAlcHBcbiIsCiAgICAgICAgICAgICAgICAg
ICAgICAgIHBkZXYtPmRvbWFpbiwgJnBkZXYtPnNiZGYpOwogCisgICAgaW9t
bXVfZnJlZV9kb21pZChwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwgaW9tbXUt
PmRvbWlkX21hcCk7CisgICAgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPSBE
T01JRF9JTlZBTElEOworCiAgICAgaWYgKCBhbWRfaW9tbXVfcGVyZGV2X2lu
dHJlbWFwICYmCiAgICAgICAgICBpdnJzX21hcHBpbmdzW2JkZl0uZHRlX3Jl
cXVlc3Rvcl9pZCA9PSBiZGYgJiYKICAgICAgICAgIGl2cnNfbWFwcGluZ3Nb
YmRmXS5pbnRyZW1hcF90YWJsZSApCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3BjaS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj
aS5jCkBAIC0xMjcxLDkgKzEyNzEsMTQgQEAgc3RhdGljIGludCBfZHVtcF9w
Y2lfZGV2aWNlcyhzdHJ1Y3QgcGNpXwogCiAgICAgbGlzdF9mb3JfZWFjaF9l
bnRyeSAoIHBkZXYsICZwc2VnLT5hbGxkZXZzX2xpc3QsIGFsbGRldnNfbGlz
dCApCiAgICAgewotICAgICAgICBwcmludGsoIiVwcCAtICVwZCAtIG5vZGUg
JS0zZCIsCi0gICAgICAgICAgICAgICAmcGRldi0+c2JkZiwgcGRldi0+ZG9t
YWluLAotICAgICAgICAgICAgICAgKHBkZXYtPm5vZGUgIT0gTlVNQV9OT19O
T0RFKSA/IHBkZXYtPm5vZGUgOiAtMSk7CisgICAgICAgIHByaW50aygiJXBw
IC0gIiwgJnBkZXYtPnNiZGYpOworI2lmZGVmIENPTkZJR19YODYKKyAgICAg
ICAgaWYgKCBwZGV2LT5kb21haW4gPT0gZG9tX2lvICkKKyAgICAgICAgICAg
IHByaW50aygiRG9tSU86JXgiLCBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCk7
CisgICAgICAgIGVsc2UKKyNlbmRpZgorICAgICAgICAgICAgcHJpbnRrKCIl
cGQiLCBwZGV2LT5kb21haW4pOworICAgICAgICBwcmludGsoIiAtIG5vZGUg
JS0zZCIsIChwZGV2LT5ub2RlICE9IE5VTUFfTk9fTk9ERSkgPyBwZGV2LT5u
b2RlIDogLTEpOwogICAgICAgICBwZGV2X2R1bXBfbXNpKHBkZXYpOwogICAg
ICAgICBwcmludGsoIlxuIik7CiAgICAgfQotLS0gYS94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC92dGQvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC92dGQvaW9tbXUuYwpAQCAtMjIsNiArMjIsNyBAQAogI2luY2x1
ZGUgPHhlbi9zY2hlZC5oPgogI2luY2x1ZGUgPHhlbi94bWFsbG9jLmg+CiAj
aW5jbHVkZSA8eGVuL2RvbWFpbl9wYWdlLmg+CisjaW5jbHVkZSA8eGVuL2Vy
ci5oPgogI2luY2x1ZGUgPHhlbi9pb2NhcC5oPgogI2luY2x1ZGUgPHhlbi9p
b21tdS5oPgogI2luY2x1ZGUgPHhlbi9udW1hLmg+CkBAIC0xMjE1LDcgKzEy
MTYsNyBAQCBpbnQgX19pbml0IGlvbW11X2FsbG9jKHN0cnVjdCBhY3BpX2Ry
aGRfCiB7CiAgICAgc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXU7CiAgICAgdW5z
aWduZWQgbG9uZyBzYWdhdywgbnJfZG9tOwotICAgIGludCBhZ2F3OworICAg
IGludCBhZ2F3LCByYzsKIAogICAgIGlvbW11ID0geHphbGxvYyhzdHJ1Y3Qg
dnRkX2lvbW11KTsKICAgICBpZiAoIGlvbW11ID09IE5VTEwgKQpAQCAtMTMw
MSw3ICsxMzAyLDE2IEBAIGludCBfX2luaXQgaW9tbXVfYWxsb2Moc3RydWN0
IGFjcGlfZHJoZF8KICAgICBpZiAoICFpb21tdS0+ZG9taWRfbWFwICkKICAg
ICAgICAgcmV0dXJuIC1FTk9NRU07CiAKKyAgICBpb21tdS0+cHNldWRvX2Rv
bWlkX21hcCA9IGlvbW11X2luaXRfZG9taWQoKTsKKyAgICByYyA9IC1FTk9N
RU07CisgICAgaWYgKCAhaW9tbXUtPnBzZXVkb19kb21pZF9tYXAgKQorICAg
ICAgICBnb3RvIGZyZWU7CisKICAgICByZXR1cm4gMDsKKworIGZyZWU6Cisg
ICAgaW9tbXVfZnJlZShkcmhkKTsKKyAgICByZXR1cm4gcmM7CiB9CiAKIHZv
aWQgX19pbml0IGlvbW11X2ZyZWUoc3RydWN0IGFjcGlfZHJoZF91bml0ICpk
cmhkKQpAQCAtMTMyNCw2ICsxMzM0LDcgQEAgdm9pZCBfX2luaXQgaW9tbXVf
ZnJlZShzdHJ1Y3QgYWNwaV9kcmhkXwogCiAgICAgeGZyZWUoaW9tbXUtPmRv
bWlkX2JpdG1hcCk7CiAgICAgeGZyZWUoaW9tbXUtPmRvbWlkX21hcCk7Cisg
ICAgeGZyZWUoaW9tbXUtPnBzZXVkb19kb21pZF9tYXApOwogCiAgICAgaWYg
KCBpb21tdS0+bXNpLmlycSA+PSAwICkKICAgICAgICAgZGVzdHJveV9pcnEo
aW9tbXUtPm1zaS5pcnEpOwpAQCAtMTU5Myw4ICsxNjA0LDggQEAgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIHJldHVybiByYyA/OiBw
ZGV2ICYmIHByZXZfZG9tOwogfQogCi1zdGF0aWMgaW50IGRvbWFpbl9jb250
ZXh0X3VubWFwKHN0cnVjdCBkb21haW4gKmQsIHVpbnQ4X3QgZGV2Zm4sCi0g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lfZGV2
ICpwZGV2KTsKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQg
KmRvbWFpbl9jb250ZXh0X3VubWFwKAorICAgIHN0cnVjdCBkb21haW4gKmQs
IHVpbnQ4X3QgZGV2Zm4sIHN0cnVjdCBwY2lfZGV2ICpwZGV2KTsKIAogc3Rh
dGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdCBkb21haW4g
KmRvbWFpbiwgdTggZGV2Zm4sCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYpCkBAIC0xNjAyLDYgKzE2
MTMsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3Ry
dWN0CiAgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkID0g
YWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYpOwogICAgIGNvbnN0
IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1ycjsKICAgICBwYWRkcl90IHBn
ZF9tYWRkciA9IGRvbV9pb21tdShkb21haW4pLT5hcmNoLnZ0ZC5wZ2RfbWFk
ZHI7CisgICAgZG9taWRfdCBvcmlnX2RvbWlkID0gcGRldi0+YXJjaC5wc2V1
ZG9fZG9taWQ7CiAgICAgaW50IHJldCA9IDA7CiAgICAgdW5zaWduZWQgaW50
IGksIG1vZGUgPSAwOwogICAgIHVpbnQxNl90IHNlZyA9IHBkZXYtPnNlZywg
YmRmOwpAQCAtMTY2MCw2ICsxNjcyLDE0IEBAIHN0YXRpYyBpbnQgZG9tYWlu
X2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgaWYgKCAhZHJoZCAp
CiAgICAgICAgICAgICByZXR1cm4gLUVOT0RFVjsKIAorICAgICAgICBpZiAo
IGlvbW11X3F1YXJhbnRpbmUgJiYgb3JpZ19kb21pZCA9PSBET01JRF9JTlZB
TElEICkKKyAgICAgICAgeworICAgICAgICAgICAgcGRldi0+YXJjaC5wc2V1
ZG9fZG9taWQgPQorICAgICAgICAgICAgICAgIGlvbW11X2FsbG9jX2RvbWlk
KGRyaGQtPmlvbW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKKyAgICAgICAgICAg
IGlmICggcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQgPT0gRE9NSURfSU5WQUxJ
RCApCisgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9TUEM7CisgICAgICAg
IH0KKwogICAgICAgICBpZiAoIGlvbW11X2RlYnVnICkKICAgICAgICAgICAg
IHByaW50ayhWVERQUkVGSVggIiVwZDpQQ0llOiBtYXAgJXBwXG4iLAogICAg
ICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywg
ZGV2Zm4pKTsKQEAgLTE2NzcsNiArMTY5NywxNCBAQCBzdGF0aWMgaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgIGlmICggIWRy
aGQgKQogICAgICAgICAgICAgcmV0dXJuIC1FTk9ERVY7CiAKKyAgICAgICAg
aWYgKCBpb21tdV9xdWFyYW50aW5lICYmIG9yaWdfZG9taWQgPT0gRE9NSURf
SU5WQUxJRCApCisgICAgICAgIHsKKyAgICAgICAgICAgIHBkZXYtPmFyY2gu
cHNldWRvX2RvbWlkID0KKyAgICAgICAgICAgICAgICBpb21tdV9hbGxvY19k
b21pZChkcmhkLT5pb21tdS0+cHNldWRvX2RvbWlkX21hcCk7CisgICAgICAg
ICAgICBpZiAoIHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID09IERPTUlEX0lO
VkFMSUQgKQorICAgICAgICAgICAgICAgIHJldHVybiAtRU5PU1BDOworICAg
ICAgICB9CisKICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAg
ICAgICBwcmludGsoVlREUFJFRklYICIlcGQ6UENJOiBtYXAgJXBwXG4iLAog
ICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1
cywgZGV2Zm4pKTsKQEAgLTE3NTAsNiArMTc3OCwxMyBAQCBzdGF0aWMgaW50
IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgaWYgKCAhcmV0
ICYmIGRldmZuID09IHBkZXYtPmRldmZuICkKICAgICAgICAgcGNpX3Z0ZF9x
dWlyayhwZGV2KTsKIAorICAgIGlmICggcmV0ICYmIGRyaGQgJiYgb3JpZ19k
b21pZCA9PSBET01JRF9JTlZBTElEICkKKyAgICB7CisgICAgICAgIGlvbW11
X2ZyZWVfZG9taWQocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsCisgICAgICAg
ICAgICAgICAgICAgICAgICAgZHJoZC0+aW9tbXUtPnBzZXVkb19kb21pZF9t
YXApOworICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlE
X0lOVkFMSUQ7CisgICAgfQorCiAgICAgcmV0dXJuIHJldDsKIH0KIApAQCAt
MTgzNSw4ICsxODcwLDEwIEBAIGludCBkb21haW5fY29udGV4dF91bm1hcF9v
bmUoCiAgICAgcmV0dXJuIHJjOwogfQogCi1zdGF0aWMgaW50IGRvbWFpbl9j
b250ZXh0X3VubWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgdTggZGV2Zm4s
Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lf
ZGV2ICpwZGV2KQorc3RhdGljIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5p
dCAqZG9tYWluX2NvbnRleHRfdW5tYXAoCisgICAgc3RydWN0IGRvbWFpbiAq
ZG9tYWluLAorICAgIHVpbnQ4X3QgZGV2Zm4sCisgICAgc3RydWN0IHBjaV9k
ZXYgKnBkZXYpCiB7CiAgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0
ICpkcmhkID0gYWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYpOwog
ICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11ID0gZHJoZCA/IGRyaGQtPmlv
bW11IDogTlVMTDsKQEAgLTE4NTAsMTYgKzE4ODcsMTYgQEAgc3RhdGljIGlu
dCBkb21haW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZAogICAgICAgICBpZiAo
IGlvbW11X2RlYnVnICkKICAgICAgICAgICAgIHByaW50ayhWVERQUkVGSVgg
IiVwZDpIb3N0YnJpZGdlOiBza2lwICVwcCB1bm1hcFxuIiwKICAgICAgICAg
ICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZu
KSk7Ci0gICAgICAgIHJldHVybiBpc19oYXJkd2FyZV9kb21haW4oZG9tYWlu
KSA/IDAgOiAtRVBFUk07CisgICAgICAgIHJldHVybiBFUlJfUFRSKGlzX2hh
cmR3YXJlX2RvbWFpbihkb21haW4pID8gMCA6IC1FUEVSTSk7CiAKICAgICBj
YXNlIERFVl9UWVBFX1BDSWVfQlJJREdFOgogICAgIGNhc2UgREVWX1RZUEVf
UENJZTJQQ0lfQlJJREdFOgogICAgIGNhc2UgREVWX1RZUEVfTEVHQUNZX1BD
SV9CUklER0U6Ci0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4g
RVJSX1BUUigwKTsKIAogICAgIGNhc2UgREVWX1RZUEVfUENJZV9FTkRQT0lO
VDoKICAgICAgICAgaWYgKCAhaW9tbXUgKQotICAgICAgICAgICAgcmV0dXJu
IC1FTk9ERVY7CisgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRU5PREVW
KTsKIAogICAgICAgICBpZiAoIGlvbW11X2RlYnVnICkKICAgICAgICAgICAg
IHByaW50ayhWVERQUkVGSVggIiVwZDpQQ0llOiB1bm1hcCAlcHBcbiIsCkBA
IC0xODczLDcgKzE5MTAsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0
X3VubWFwKHN0cnVjdCBkCiAKICAgICBjYXNlIERFVl9UWVBFX1BDSToKICAg
ICAgICAgaWYgKCAhaW9tbXUgKQotICAgICAgICAgICAgcmV0dXJuIC1FTk9E
RVY7CisgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRU5PREVWKTsKIAog
ICAgICAgICBpZiAoIGlvbW11X2RlYnVnICkKICAgICAgICAgICAgIHByaW50
ayhWVERQUkVGSVggIiVwZDpQQ0k6IHVubWFwICVwcFxuIiwKQEAgLTE5MjAs
MTQgKzE5NTcsMTQgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF91bm1h
cChzdHJ1Y3QgZAogICAgIGRlZmF1bHQ6CiAgICAgICAgIGRwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgsICIlcGQ6dW5rbm93bigldSk6ICVwcFxuIiwK
ICAgICAgICAgICAgICAgICBkb21haW4sIHBkZXYtPnR5cGUsICZQQ0lfU0JE
RjMoc2VnLCBidXMsIGRldmZuKSk7Ci0gICAgICAgIHJldHVybiAtRUlOVkFM
OworICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKICAgICB9CiAK
ICAgICBpZiAoICFyZXQgJiYgcGRldi0+ZGV2Zm4gPT0gZGV2Zm4gJiYKICAg
ICAgICAgICFRVUFSQU5USU5FX1NLSVAoZG9tYWluLCBkb21faW9tbXUoZG9t
YWluKS0+YXJjaC52dGQucGdkX21hZGRyKSApCiAgICAgICAgIGNoZWNrX2Ns
ZWFudXBfZG9taWRfbWFwKGRvbWFpbiwgcGRldiwgaW9tbXUpOwogCi0gICAg
cmV0dXJuIHJldDsKKyAgICByZXR1cm4gZHJoZDsKIH0KIAogc3RhdGljIHZv
aWQgaW9tbXVfY2xlYXJfcm9vdF9wZ3RhYmxlKHN0cnVjdCBkb21haW4gKmQp
CkBAIC0yMTU0LDE2ICsyMTkxLDE3IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9t
bXVfZW5hYmxlX2RldmljZShzdHIKIAogc3RhdGljIGludCBpbnRlbF9pb21t
dV9yZW1vdmVfZGV2aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRl
dikKIHsKKyAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQ7
CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwogICAgIHUxNiBi
ZGY7Ci0gICAgaW50IHJldCwgaTsKKyAgICB1bnNpZ25lZCBpbnQgaTsKIAog
ICAgIGlmICggIXBkZXYtPmRvbWFpbiApCiAgICAgICAgIHJldHVybiAtRUlO
VkFMOwogCi0gICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXAocGRldi0+
ZG9tYWluLCBkZXZmbiwgcGRldik7Ci0gICAgaWYgKCByZXQgKQotICAgICAg
ICByZXR1cm4gcmV0OworICAgIGRyaGQgPSBkb21haW5fY29udGV4dF91bm1h
cChwZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKKyAgICBpZiAoIElTX0VS
UihkcmhkKSApCisgICAgICAgIHJldHVybiBQVFJfRVJSKGRyaGQpOwogCiAg
ICAgZm9yX2VhY2hfcm1ycl9kZXZpY2UgKCBybXJyLCBiZGYsIGkgKQogICAg
IHsKQEAgLTIxODAsNiArMjIxOCwxMyBAQCBzdGF0aWMgaW50IGludGVsX2lv
bW11X3JlbW92ZV9kZXZpY2UodTgKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7CiAgICAgfQogCisgICAg
aWYgKCBkcmhkICkKKyAgICB7CisgICAgICAgIGlvbW11X2ZyZWVfZG9taWQo
cGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsCisgICAgICAgICAgICAgICAgICAg
ICAgICAgZHJoZC0+aW9tbXUtPnBzZXVkb19kb21pZF9tYXApOworICAgICAg
ICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlEX0lOVkFMSUQ7Cisg
ICAgfQorCiAgICAgcmV0dXJuIDA7CiB9CiAKQEAgLTI1NTYsNyArMjYwMSwx
MiBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNoaXAoCiAg
ICAgICAgIH0KICAgICB9CiAgICAgZWxzZQotICAgICAgICByZXQgPSBkb21h
aW5fY29udGV4dF91bm1hcChzb3VyY2UsIGRldmZuLCBwZGV2KTsKKyAgICB7
CisgICAgICAgIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZDsK
KworICAgICAgICBkcmhkID0gZG9tYWluX2NvbnRleHRfdW5tYXAoc291cmNl
LCBkZXZmbiwgcGRldik7CisgICAgICAgIHJldCA9IElTX0VSUihkcmhkKSA/
IFBUUl9FUlIoZHJoZCkgOiAwOworICAgIH0KICAgICBpZiAoIHJldCApCiAg
ICAgewogICAgICAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyh0YXJnZXQpICkK
LS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgKKysr
IGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgKQEAgLTUw
OCw2ICs1MDgsNyBAQCBzdHJ1Y3QgdnRkX2lvbW11IHsKICAgICB9IGZsdXNo
OwogCiAgICAgc3RydWN0IGxpc3RfaGVhZCBhdHNfZGV2aWNlczsKKyAgICB1
bnNpZ25lZCBsb25nICpwc2V1ZG9fZG9taWRfbWFwOyAvKiAicHNldWRvIiBk
b21haW4gaWQgYml0bWFwICovCiAgICAgdW5zaWduZWQgbG9uZyAqZG9taWRf
Yml0bWFwOyAgLyogZG9tYWluIGlkIGJpdG1hcCAqLwogICAgIHUxNiAqZG9t
aWRfbWFwOyAgICAgICAgICAgICAgIC8qIGRvbWFpbiBpZCBtYXBwaW5nIGFy
cmF5ICovCiAgICAgdWludDMyX3QgdmVyc2lvbjsKLS0tIGEveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gveDg2L2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gveDg2L2lvbW11LmMKQEAgLTM4Nyw2ICszODcsNTggQEAg
dm9pZCBfX2h3ZG9tX2luaXQgYXJjaF9pb21tdV9od2RvbV9pbml0KAogICAg
ICAgICByZXR1cm47CiB9CiAKK3ZvaWQgYXJjaF9wY2lfaW5pdF9wZGV2KHN0
cnVjdCBwY2lfZGV2ICpwZGV2KQoreworICAgIHBkZXYtPmFyY2gucHNldWRv
X2RvbWlkID0gRE9NSURfSU5WQUxJRDsKK30KKwordW5zaWduZWQgbG9uZyAq
X19pbml0IGlvbW11X2luaXRfZG9taWQodm9pZCkKK3sKKyAgICBpZiAoICFp
b21tdV9xdWFyYW50aW5lICkKKyAgICAgICAgcmV0dXJuIFpFUk9fQkxPQ0tf
UFRSOworCisgICAgQlVJTERfQlVHX09OKERPTUlEX01BU0sgKiAyVSA+PSBV
SU5UMTZfTUFYKTsKKworICAgIHJldHVybiB4emFsbG9jX2FycmF5KHVuc2ln
bmVkIGxvbmcsCisgICAgICAgICAgICAgICAgICAgICAgICAgQklUU19UT19M
T05HUyhVSU5UMTZfTUFYIC0gRE9NSURfTUFTSykpOworfQorCitkb21pZF90
IGlvbW11X2FsbG9jX2RvbWlkKHVuc2lnbmVkIGxvbmcgKm1hcCkKK3sKKyAg
ICAvKgorICAgICAqIFRoaXMgaXMgdXNlZCB1bmlmb3JtbHkgYWNyb3NzIGFs
bCBJT01NVXMsIHN1Y2ggdGhhdCBvbiB0eXBpY2FsCisgICAgICogc3lzdGVt
cyB3ZSB3b3VsZG4ndCByZS11c2UgdGhlIHNhbWUgSUQgdmVyeSBxdWlja2x5
IChwZXJoYXBzIG5ldmVyKS4KKyAgICAgKi8KKyAgICBzdGF0aWMgdW5zaWdu
ZWQgaW50IHN0YXJ0OworICAgIHVuc2lnbmVkIGludCBpZHggPSBmaW5kX25l
eHRfemVyb19iaXQobWFwLCBVSU5UMTZfTUFYIC0gRE9NSURfTUFTSywgc3Rh
cnQpOworCisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOworCisgICAg
aWYgKCBpZHggPj0gVUlOVDE2X01BWCAtIERPTUlEX01BU0sgKQorICAgICAg
ICBpZHggPSBmaW5kX2ZpcnN0X3plcm9fYml0KG1hcCwgVUlOVDE2X01BWCAt
IERPTUlEX01BU0spOworICAgIGlmICggaWR4ID49IFVJTlQxNl9NQVggLSBE
T01JRF9NQVNLICkKKyAgICAgICAgcmV0dXJuIERPTUlEX0lOVkFMSUQ7CisK
KyAgICBfX3NldF9iaXQoaWR4LCBtYXApOworCisgICAgc3RhcnQgPSBpZHgg
KyAxOworCisgICAgcmV0dXJuIGlkeCB8IChET01JRF9NQVNLICsgMSk7Cit9
CisKK3ZvaWQgaW9tbXVfZnJlZV9kb21pZChkb21pZF90IGRvbWlkLCB1bnNp
Z25lZCBsb25nICptYXApCit7CisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2Vk
KCkpOworCisgICAgaWYgKCBkb21pZCA9PSBET01JRF9JTlZBTElEICkKKyAg
ICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKGRvbWlkID4gRE9NSURfTUFT
Syk7CisKKyAgICBpZiAoICFfX3Rlc3RfYW5kX2NsZWFyX2JpdChkb21pZCAm
IERPTUlEX01BU0ssIG1hcCkgKQorICAgICAgICBCVUcoKTsKK30KKwogaW50
IGlvbW11X2ZyZWVfcGd0YWJsZXMoc3RydWN0IGRvbWFpbiAqZCkKIHsKICAg
ICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-10.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IGRyb3AgVExCIGZsdXNoZXMgZnJvbSBxdWFyYW50aW5l
X2luaXQoKSBob29rcwoKVGhlIHBhZ2UgdGFibGVzIGp1c3QgY3JlYXRlZCBh
cmVuJ3QgaG9va2VkIHVwIHlldCBhbnl3aGVyZSwgc28gdGhlcmUncwpub3Ro
aW5nIHRoYXQgY291bGQgYmUgcHJlc2VudCBpbiBhbnkgVExCLCBhbmQgaGVu
Y2Ugbm90aGluZyB0byBmbHVzaC4KRHJvcHBpbmcgdGhpcyBmbHVzaCBpcywg
YXQgbGVhc3Qgb24gdGhlIFZULWQgc2lkZSwgYSBwcmVyZXEgdG8gcGVyLQpk
ZXZpY2UgZG9tYWluIElEIHVzZSB3aGVuIHF1YXJhbnRpbmluZyBkZXZpY2Vz
LCBhcyBkb21faW8gaXNuJ3QgZ29pbmcKdG8gYmUgYXNzaWduZWQgYSBESUQg
YW55bW9yZTogVGhlIHdhcm5pbmcgaW4gZ2V0X2lvbW11X2RpZCgpIHdvdWxk
CnRyaWdnZXIuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxA
eGVuLm9yZz4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy
LnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2
aW4udGlhbkBpbnRlbC5jb20+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9hbWQvaW9tbXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11X21hcC5jCkBAIC02NTQsOCArNjU0LDYgQEAgaW50
IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cgogIG91dDoK
ICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKIAot
ICAgIGFtZF9pb21tdV9mbHVzaF9hbGxfcGFnZXMoZCk7Ci0KICAgICAvKiBQ
YWdlcyBsZWFrZWQgaW4gZmFpbHVyZSBjYXNlICovCiAgICAgcmV0dXJuIGxl
dmVsID8gLUVOT01FTSA6IDA7CiB9Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5jCkBAIC0yOTc1LDkgKzI5NzUsNiBAQCBzdGF0aWMg
aW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFyYW50aW5lCiAgb3V0OgogICAg
IHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogCi0gICAg
aWYgKCAhcmMgKQotICAgICAgICByYyA9IGlvbW11X2ZsdXNoX2lvdGxiX2Fs
bChkKTsKLQogICAgIC8qIFBhZ2VzIG1heSBiZSBsZWFrZWQgaW4gZmFpbHVy
ZSBjYXNlICovCiAgICAgcmV0dXJuIHJjOwogfQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-11.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-11.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IGFic3RyYWN0IG1heGltdW0gbnVtYmVyIG9mIHBhZ2Ug
dGFibGUgbGV2ZWxzCgpXZSB3aWxsIHdhbnQgdG8gdXNlIHRoZSBjb25zdGFu
dCBlbHNld2hlcmUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBh
dWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft
ZC9pb21tdS1kZWZzLmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
YW1kL2lvbW11LWRlZnMuaApAQCAtMTA2LDYgKzEwNiw3IEBAIHN0cnVjdCBh
bWRfaW9tbXVfZHRlIHsKICAgICBib29sIHR2OjE7CiAgICAgdW5zaWduZWQg
aW50IDo1OwogICAgIHVuc2lnbmVkIGludCBoYWQ6MjsKKyNkZWZpbmUgSU9N
TVVfTUFYX1BUX0xFVkVMUyA2CiAgICAgdW5zaWduZWQgaW50IHBhZ2luZ19t
b2RlOjM7CiAgICAgdWludDY0X3QgcHRfcm9vdDo0MDsKICAgICBib29sIHBw
cjoxOwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2Ft
ZF9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9w
Y2lfYW1kX2lvbW11LmMKQEAgLTMzNyw3ICszMzcsNyBAQCBpbnQgYW1kX2lv
bW11X2FsbG9jX3Jvb3Qoc3RydWN0IGRvbWFpbiAqCiAgICAgcmV0dXJuIDA7
CiB9CiAKLXVuc2lnbmVkIGludCBfX3JlYWRfbW9zdGx5IGFtZF9pb21tdV9t
YXhfcGFnaW5nX21vZGUgPSA2OwordW5zaWduZWQgaW50IF9fcmVhZF9tb3N0
bHkgYW1kX2lvbW11X21heF9wYWdpbmdfbW9kZSA9IElPTU1VX01BWF9QVF9M
RVZFTFM7CiBpbnQgX19yZWFkX21vc3RseSBhbWRfaW9tbXVfbWluX3BhZ2lu
Z19tb2RlID0gMTsKIAogc3RhdGljIGludCBhbWRfaW9tbXVfZG9tYWluX2lu
aXQoc3RydWN0IGRvbWFpbiAqZCkK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-4.16-12.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-4.16-12.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHVzZSBwZXItZGV2aWNlIHBhZ2UgdGFibGVzIGZvciBx
dWFyYW50aW5pbmcKCkRldmljZXMgd2l0aCBSTVJScyAvIHVuaXR5IG1hcHBl
ZCByZWdpb25zLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQKaG93L3do
ZW4gdGhlc2UgbWVtb3J5IHJlZ2lvbnMgbWF5IGJlIGFjY2Vzc2VkLCBtYXkg
bm90IGJlIGxlZnQKZGlzY29ubmVjdGVkIGZyb20gdGhlIG1hcHBpbmdzIG9m
IHRoZXNlIHJlZ2lvbnMgKGFzIGxvbmcgYXMgaXQncyBub3QKY2VydGFpbiB0
aGF0IHRoZSBkZXZpY2UgaGFzIGJlZW4gZnVsbHkgcXVpZXNjZWQpLiBIZW5j
ZSBldmVuIHRoZSBwYWdlCnRhYmxlcyB1c2VkIHdoZW4gcXVhcmFudGluaW5n
IHN1Y2ggZGV2aWNlcyBuZWVkIHRvIGhhdmUgbWFwcGluZ3Mgb2YKdGhvc2Ug
cmVnaW9ucy4gVGhpcyBpbXBsaWVzIGluc3RhbGxpbmcgcGFnZSB0YWJsZXMg
aW4gdGhlIGZpcnN0IHBsYWNlCmV2ZW4gd2hlbiBub3QgaW4gc2NyYXRjaC1w
YWdlIHF1YXJhbnRpbmluZyBtb2RlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM2
MSAvIHBhcnQgb2YgWFNBLTQwMC4KCldoaWxlIGZvciB0aGUgcHVycG9zZSBo
ZXJlIGl0IHdvdWxkIGJlIHN1ZmZpY2llbnQgdG8gaGF2ZSBkZXZpY2VzIHdp
dGgKUk1SUnMgLyB1bml0eSBtYXBwZWQgcmVnaW9ucyB1c2UgcGVyLWRldmlj
ZSBwYWdlIHRhYmxlcywgZXh0ZW5kIHRoaXMgdG8KYWxsIGRldmljZXMgKGlu
IHNjcmF0Y2gtcGFnZSBxdWFyYW50aW5pbmcgbW9kZSkuIFRoaXMgYWxsb3dz
IHRoZSBsZWFmCnBhZ2VzIHRvIGJlIG1hcHBlZCByL3csIHRodXMgY292ZXJp
bmcgYWxzbyBtZW1vcnkgd3JpdGVzIChyYXRoZXIgdGhhbgpqdXN0IHJlYWRz
KSBpc3N1ZWQgYnkgbm9uLXF1aWVzY2VudCBkZXZpY2VzLgoKU2V0IHVwIHF1
YXJhbnRpbmUgcGFnZSB0YWJsZXMgYXMgbGF0ZSBhcyBwb3NzaWJsZSwgeWV0
IGVhcmx5IGVub3VnaCB0bwpub3QgZW5jb3VudGVyIGZhaWx1cmUgZHVyaW5n
IGRlLWFzc2lnbi4gVGhpcyBtZWFucyBzZXR1cCBnZW5lcmFsbHkKaGFwcGVu
cyBpbiBhc3NpZ25fZGV2aWNlKCksIHdoaWxlIChmb3Igbm93KSB0aGUgb25l
IGluIGRlYXNzaWduX2RldmljZSgpCmlzIHRoZXJlIG1haW5seSB0byBiZSBv
biB0aGUgc2FmZSBzaWRlLgoKQXMgdG8gdGhlIHJlbW92YWwgb2YgUVVBUkFO
VElORV9TS0lQKCkgZnJvbSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoKToK
SSB0aGluayB0aGlzIHdhcyBuZXZlciByZWFsbHkgbmVlZGVkIHRoZXJlLCBh
cyB0aGUgZnVuY3Rpb24gZXhwbGljaXRseQpkZWFscyB3aXRoIGZpbmRpbmcg
YSBub24tcHJlc2VudCBjb250ZXh0IGVudHJ5LiBMZWF2aW5nIGl0IHRoZXJl
IHdvdWxkCnJlcXVpcmUgcHJvcGFnYXRpbmcgcGdkX21hZGRyIGludG8gdGhl
IGZ1bmN0aW9uIChsaWtlIHdhcyBkb25lIGJ5ICJWVC1kOgpwcmVwYXJlIGZv
ciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFnZSB0YWJsZXMiIGZvcgpkb21h
aW5fY29udGV4dF9tYXBwaW5nX29uZSgpKS4KCkluIFZULWQncyBESUQgYWxs
b2NhdGlvbiBmdW5jdGlvbiBkb24ndCByZXF1aXJlIHRoZSBJT01NVSBsb2Nr
IHRvIGJlCmhlbGQgYW55bW9yZTogQWxsIGludm9sdmVkIGNvZGUgcGF0aHMg
aG9sZCBwY2lkZXZzX2xvY2ssIHNvIHRoaXMgd2F5IHdlCmF2b2lkIHRoZSBu
ZWVkIHRvIGFjcXVpcmUgdGhlIElPTU1VIGxvY2sgYXJvdW5kIHRoZSBuZXcg
Y2FsbCB0bwpjb250ZXh0X3NldF9kb21haW5faWQoKS4KClNpZ25lZC1vZmYt
Ynk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQt
Ynk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZpZXdlZC1ieTog
S2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+ClJldmlld2VkLWJ5
OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KCi0t
LSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgKKysrIGIveGVuL2luY2x1
ZGUvYXNtLXg4Ni9wY2kuaApAQCAtMSw2ICsxLDggQEAKICNpZm5kZWYgX19Y
ODZfUENJX0hfXwogI2RlZmluZSBfX1g4Nl9QQ0lfSF9fCiAKKyNpbmNsdWRl
IDx4ZW4vbW0uaD4KKwogI2RlZmluZSBDRjhfQkRGKGNmOCkgICAgICggICgo
Y2Y4KSAmIDB4MDBmZmZmMDApID4+IDgpCiAjZGVmaW5lIENGOF9BRERSX0xP
KGNmOCkgKCAgIChjZjgpICYgMHgwMDAwMDBmYykKICNkZWZpbmUgQ0Y4X0FE
RFJfSEkoY2Y4KSAoICAoKGNmOCkgJiAweDBmMDAwMDAwKSA+PiAxNikKQEAg
LTE4LDcgKzIwLDE4IEBAIHN0cnVjdCBhcmNoX3BjaV9kZXYgewogICAgICAq
IHRoZW0gZG9uJ3QgcmFjZSAoZGUpaW5pdGlhbGl6YXRpb24gYW5kIGhlbmNl
IGRvbid0IHN0cmljdGx5IG5lZWQgYW55CiAgICAgICogbG9ja2luZy4KICAg
ICAgKi8KKyAgICB1bmlvbiB7CisgICAgICAgIC8qIFN1YnNldCBvZiBzdHJ1
Y3QgYXJjaF9pb21tdSdzIGZpZWxkcywgdG8gYmUgdXNlZCBpbiBkb21faW8u
ICovCisgICAgICAgIHN0cnVjdCB7CisgICAgICAgICAgICB1aW50NjRfdCBw
Z2RfbWFkZHI7CisgICAgICAgIH0gdnRkOworICAgICAgICBzdHJ1Y3Qgewor
ICAgICAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcm9vdF90YWJsZTsKKyAg
ICAgICAgfSBhbWQ7CisgICAgfTsKICAgICBkb21pZF90IHBzZXVkb19kb21p
ZDsKKyAgICBtZm5fdCBsZWFmX21mbjsKKyAgICBzdHJ1Y3QgcGFnZV9saXN0
X2hlYWQgcGd0YWJsZXNfbGlzdDsKIH07CiAKIGludCBwY2lfY29uZl93cml0
ZV9pbnRlcmNlcHQodW5zaWduZWQgaW50IHNlZywgdW5zaWduZWQgaW50IGJk
ZiwKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11LmgK
KysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11LmgKQEAg
LTIzNyw3ICsyMzcsOCBAQCBpbnQgYW1kX2lvbW11X2luaXRfbGF0ZSh2b2lk
KTsKIGludCBhbWRfaW9tbXVfdXBkYXRlX2l2cnNfbWFwcGluZ19hY3BpKHZv
aWQpOwogaW50IGlvdl9hZGp1c3RfaXJxX2FmZmluaXRpZXModm9pZCk7CiAK
LWludCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBkb21haW4g
KmQpOworaW50IGFtZF9pb21tdV9xdWFyYW50aW5lX2luaXQoc3RydWN0IHBj
aV9kZXYgKnBkZXYsIGJvb2wgc2NyYXRjaF9wYWdlKTsKK3ZvaWQgYW1kX2lv
bW11X3F1YXJhbnRpbmVfdGVhcmRvd24oc3RydWN0IHBjaV9kZXYgKnBkZXYp
OwogCiAvKiBtYXBwaW5nIGZ1bmN0aW9ucyAqLwogaW50IF9fbXVzdF9jaGVj
ayBhbWRfaW9tbXVfbWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3Qg
ZGZuLAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVf
bWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11
X21hcC5jCkBAIC01OTgsNjQgKzU5OCwxMzggQEAgaW50IGFtZF9pb21tdV9n
ZXRfcmVzZXJ2ZWRfZGV2aWNlX21lbW9yeQogICAgIHJldHVybiAwOwogfQog
Ci1pbnQgX19pbml0IGFtZF9pb21tdV9xdWFyYW50aW5lX2luaXQoc3RydWN0
IGRvbWFpbiAqZCkKK3N0YXRpYyBpbnQgZmlsbF9xcHQodW5pb24gYW1kX2lv
bW11X3B0ZSAqdGhpcywgdW5zaWduZWQgaW50IGxldmVsLAorICAgICAgICAg
ICAgICAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZ3NbSU9NTVVfTUFYX1BU
X0xFVkVMU10pCiB7Ci0gICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBk
b21faW9tbXUoZCk7CisgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBk
b21faW9tbXUoZG9tX2lvKTsKKyAgICB1bnNpZ25lZCBpbnQgaTsKKyAgICBp
bnQgcmMgPSAwOworCisgICAgZm9yICggaSA9IDA7ICFyYyAmJiBpIDwgUFRF
X1BFUl9UQUJMRV9TSVpFOyArK2kgKQorICAgIHsKKyAgICAgICAgdW5pb24g
YW1kX2lvbW11X3B0ZSAqcHRlID0gJnRoaXNbaV0sICpuZXh0OworCisgICAg
ICAgIGlmICggIXB0ZS0+cHIgKQorICAgICAgICB7CisgICAgICAgICAgICBp
ZiAoICFwZ3NbbGV2ZWxdICkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAg
ICAgICAvKgorICAgICAgICAgICAgICAgICAqIFRoZSBwZ3RhYmxlIGFsbG9j
YXRvciBpcyBmaW5lIGZvciB0aGUgbGVhZiBwYWdlLCBhcyB3ZWxsIGFzCisg
ICAgICAgICAgICAgICAgICogcGFnZSB0YWJsZSBwYWdlcywgYW5kIHRoZSBy
ZXN1bHRpbmcgYWxsb2NhdGlvbnMgYXJlIGFsd2F5cworICAgICAgICAgICAg
ICAgICAqIHplcm9lZC4KKyAgICAgICAgICAgICAgICAgKi8KKyAgICAgICAg
ICAgICAgICBwZ3NbbGV2ZWxdID0gaW9tbXVfYWxsb2NfcGd0YWJsZShoZCk7
CisgICAgICAgICAgICAgICAgaWYgKCAhcGdzW2xldmVsXSApCisgICAgICAg
ICAgICAgICAgeworICAgICAgICAgICAgICAgICAgICByYyA9IC1FTk9NRU07
CisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAg
IH0KKworICAgICAgICAgICAgICAgIGlmICggbGV2ZWwgKQorICAgICAgICAg
ICAgICAgIHsKKyAgICAgICAgICAgICAgICAgICAgbmV4dCA9IF9fbWFwX2Rv
bWFpbl9wYWdlKHBnc1tsZXZlbF0pOworICAgICAgICAgICAgICAgICAgICBy
YyA9IGZpbGxfcXB0KG5leHQsIGxldmVsIC0gMSwgcGdzKTsKKyAgICAgICAg
ICAgICAgICAgICAgdW5tYXBfZG9tYWluX3BhZ2UobmV4dCk7CisgICAgICAg
ICAgICAgICAgfQorICAgICAgICAgICAgfQorCisgICAgICAgICAgICAvKgor
ICAgICAgICAgICAgICogUERFcyBhcmUgZXNzZW50aWFsbHkgYSBzdWJzZXQg
b2YgUFRFcywgc28gdGhpcyBmdW5jdGlvbgorICAgICAgICAgICAgICogaXMg
ZmluZSB0byB1c2UgZXZlbiBhdCB0aGUgbGVhZi4KKyAgICAgICAgICAgICAq
LworICAgICAgICAgICAgc2V0X2lvbW11X3BkZV9wcmVzZW50KHB0ZSwgbWZu
X3gocGFnZV90b19tZm4ocGdzW2xldmVsXSkpLCBsZXZlbCwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB0cnVlLCB0cnVlKTsKKyAgICAg
ICAgfQorICAgICAgICBlbHNlIGlmICggbGV2ZWwgJiYgcHRlLT5uZXh0X2xl
dmVsICkKKyAgICAgICAgeworICAgICAgICAgICAgbmV4dCA9IG1hcF9kb21h
aW5fcGFnZShfbWZuKHB0ZS0+bWZuKSk7CisgICAgICAgICAgICByYyA9IGZp
bGxfcXB0KG5leHQsIGxldmVsIC0gMSwgcGdzKTsKKyAgICAgICAgICAgIHVu
bWFwX2RvbWFpbl9wYWdlKG5leHQpOworICAgICAgICB9CisgICAgfQorCisg
ICAgcmV0dXJuIHJjOworfQorCitpbnQgYW1kX2lvbW11X3F1YXJhbnRpbmVf
aW5pdChzdHJ1Y3QgcGNpX2RldiAqcGRldiwgYm9vbCBzY3JhdGNoX3BhZ2Up
Cit7CisgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUo
ZG9tX2lvKTsKICAgICB1bnNpZ25lZCBsb25nIGVuZF9nZm4gPQogICAgICAg
ICAxdWwgPDwgKERFRkFVTFRfRE9NQUlOX0FERFJFU1NfV0lEVEggLSBQQUdF
X1NISUZUKTsKICAgICB1bnNpZ25lZCBpbnQgbGV2ZWwgPSBhbWRfaW9tbXVf
Z2V0X3BhZ2luZ19tb2RlKGVuZF9nZm4pOwotICAgIHVuaW9uIGFtZF9pb21t
dV9wdGUgKnRhYmxlOworICAgIHVuc2lnbmVkIGludCByZXFfaWQgPSBnZXRf
ZG1hX3JlcXVlc3Rvcl9pZChwZGV2LT5zZWcsIHBkZXYtPnNiZGYuYmRmKTsK
KyAgICBjb25zdCBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5n
cyA9IGdldF9pdnJzX21hcHBpbmdzKHBkZXYtPnNlZyk7CisgICAgaW50IHJj
OworCisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOworICAgIEFTU0VS
VCghaGQtPmFyY2guYW1kLnJvb3RfdGFibGUpOworICAgIEFTU0VSVChwYWdl
X2xpc3RfZW1wdHkoJmhkLT5hcmNoLnBndGFibGVzLmxpc3QpKTsKIAotICAg
IGlmICggaGQtPmFyY2guYW1kLnJvb3RfdGFibGUgKQotICAgIHsKLSAgICAg
ICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7CisgICAgaWYgKCAhc2NyYXRjaF9w
YWdlICYmICFpdnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwICkKICAg
ICAgICAgcmV0dXJuIDA7Ci0gICAgfQogCi0gICAgc3Bpbl9sb2NrKCZoZC0+
YXJjaC5tYXBwaW5nX2xvY2spOworICAgIEFTU0VSVChwZGV2LT5hcmNoLnBz
ZXVkb19kb21pZCAhPSBET01JRF9JTlZBTElEKTsKIAotICAgIGhkLT5hcmNo
LmFtZC5yb290X3RhYmxlID0gaW9tbXVfYWxsb2NfcGd0YWJsZShoZCk7Ci0g
ICAgaWYgKCAhaGQtPmFyY2guYW1kLnJvb3RfdGFibGUgKQotICAgICAgICBn
b3RvIG91dDsKKyAgICBpZiAoIHBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGUg
KQorICAgIHsKKyAgICAgICAgY2xlYXJfZG9tYWluX3BhZ2UocGRldi0+YXJj
aC5sZWFmX21mbik7CisgICAgICAgIHJldHVybiAwOworICAgIH0KIAotICAg
IHRhYmxlID0gX19tYXBfZG9tYWluX3BhZ2UoaGQtPmFyY2guYW1kLnJvb3Rf
dGFibGUpOwotICAgIHdoaWxlICggbGV2ZWwgKQorICAgIHBkZXYtPmFyY2gu
YW1kLnJvb3RfdGFibGUgPSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKKyAg
ICBpZiAoICFwZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlICkKKyAgICAgICAg
cmV0dXJuIC1FTk9NRU07CisKKyAgICAvKiBUcmFuc2llbnRseSBpbnN0YWxs
IHRoZSByb290IGludG8gRG9tSU8sIGZvciBpb21tdV9pZGVudGl0eV9tYXBw
aW5nKCkuICovCisgICAgaGQtPmFyY2guYW1kLnJvb3RfdGFibGUgPSBwZGV2
LT5hcmNoLmFtZC5yb290X3RhYmxlOworCisgICAgcmMgPSBhbWRfaW9tbXVf
cmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKGRvbV9pbywKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXZyc19tYXBwaW5n
c1tyZXFfaWRdLnVuaXR5X21hcCwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgMCk7CisKKyAgICBpb21tdV9pZGVudGl0
eV9tYXBfdGVhcmRvd24oZG9tX2lvKTsKKyAgICBoZC0+YXJjaC5hbWQucm9v
dF90YWJsZSA9IE5VTEw7CisKKyAgICBpZiAoIHJjICkKKyAgICAgICAgQU1E
X0lPTU1VX1dBUk4oIiVwcDogcXVhcmFudGluZSB1bml0eSBtYXBwaW5nIGZh
aWxlZFxuIiwgJnBkZXYtPnNiZGYpOworICAgIGVsc2UgaWYgKCBzY3JhdGNo
X3BhZ2UgKQogICAgIHsKLSAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7
Ci0gICAgICAgIHVuc2lnbmVkIGludCBpOworICAgICAgICB1bmlvbiBhbWRf
aW9tbXVfcHRlICpyb290OworICAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpw
Z3NbSU9NTVVfTUFYX1BUX0xFVkVMU10gPSB7fTsKIAotICAgICAgICAvKgot
ICAgICAgICAgKiBUaGUgcGd0YWJsZSBhbGxvY2F0b3IgaXMgZmluZSBmb3Ig
dGhlIGxlYWYgcGFnZSwgYXMgd2VsbCBhcwotICAgICAgICAgKiBwYWdlIHRh
YmxlIHBhZ2VzLCBhbmQgdGhlIHJlc3VsdGluZyBhbGxvY2F0aW9ucyBhcmUg
YWx3YXlzCi0gICAgICAgICAqIHplcm9lZC4KLSAgICAgICAgICovCi0gICAg
ICAgIHBnID0gaW9tbXVfYWxsb2NfcGd0YWJsZShoZCk7Ci0gICAgICAgIGlm
ICggIXBnICkKLSAgICAgICAgICAgIGJyZWFrOworICAgICAgICBzcGluX2xv
Y2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAKLSAgICAgICAgZm9yICgg
aSA9IDA7IGkgPCBQVEVfUEVSX1RBQkxFX1NJWkU7IGkrKyApCi0gICAgICAg
IHsKLSAgICAgICAgICAgIHVuaW9uIGFtZF9pb21tdV9wdGUgKnBkZSA9ICZ0
YWJsZVtpXTsKKyAgICAgICAgcm9vdCA9IF9fbWFwX2RvbWFpbl9wYWdlKHBk
ZXYtPmFyY2guYW1kLnJvb3RfdGFibGUpOworICAgICAgICByYyA9IGZpbGxf
cXB0KHJvb3QsIGxldmVsIC0gMSwgcGdzKTsKKyAgICAgICAgdW5tYXBfZG9t
YWluX3BhZ2Uocm9vdCk7CiAKLSAgICAgICAgICAgIC8qCi0gICAgICAgICAg
ICAgKiBQREVzIGFyZSBlc3NlbnRpYWxseSBhIHN1YnNldCBvZiBQVEVzLCBz
byB0aGlzIGZ1bmN0aW9uCi0gICAgICAgICAgICAgKiBpcyBmaW5lIHRvIHVz
ZSBldmVuIGF0IHRoZSBsZWFmLgotICAgICAgICAgICAgICovCi0gICAgICAg
ICAgICBzZXRfaW9tbXVfcGRlX3ByZXNlbnQocGRlLCBtZm5feChwYWdlX3Rv
X21mbihwZykpLCBsZXZlbCAtIDEsCi0gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgZmFsc2UsIHRydWUpOwotICAgICAgICB9CisgICAgICAg
IHBkZXYtPmFyY2gubGVhZl9tZm4gPSBwYWdlX3RvX21mbihwZ3NbMF0pOwog
Ci0gICAgICAgIHVubWFwX2RvbWFpbl9wYWdlKHRhYmxlKTsKLSAgICAgICAg
dGFibGUgPSBfX21hcF9kb21haW5fcGFnZShwZyk7Ci0gICAgICAgIGxldmVs
LS07CisgICAgICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xv
Y2spOwogICAgIH0KLSAgICB1bm1hcF9kb21haW5fcGFnZSh0YWJsZSk7CiAK
LSBvdXQ6Ci0gICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9j
ayk7CisgICAgcGFnZV9saXN0X21vdmUoJnBkZXYtPmFyY2gucGd0YWJsZXNf
bGlzdCwgJmhkLT5hcmNoLnBndGFibGVzLmxpc3QpOworCisgICAgaWYgKCBy
YyApCisgICAgICAgIGFtZF9pb21tdV9xdWFyYW50aW5lX3RlYXJkb3duKHBk
ZXYpOworCisgICAgcmV0dXJuIHJjOworfQorCit2b2lkIGFtZF9pb21tdV9x
dWFyYW50aW5lX3RlYXJkb3duKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQorewor
ICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbV9p
byk7CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CisKKyAgICBp
ZiAoICFwZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlICkKKyAgICAgICAgcmV0
dXJuOwogCi0gICAgLyogUGFnZXMgbGVha2VkIGluIGZhaWx1cmUgY2FzZSAq
LwotICAgIHJldHVybiBsZXZlbCA/IC1FTk9NRU0gOiAwOworICAgIEFTU0VS
VChwYWdlX2xpc3RfZW1wdHkoJmhkLT5hcmNoLnBndGFibGVzLmxpc3QpKTsK
KyAgICBwYWdlX2xpc3RfbW92ZSgmaGQtPmFyY2gucGd0YWJsZXMubGlzdCwg
JnBkZXYtPmFyY2gucGd0YWJsZXNfbGlzdCk7CisgICAgd2hpbGUgKCBpb21t
dV9mcmVlX3BndGFibGVzKGRvbV9pbykgPT0gLUVSRVNUQVJUICkKKyAgICAg
ICAgLyogbm90aGluZyAqLzsKKyAgICBwZGV2LT5hcmNoLmFtZC5yb290X3Rh
YmxlID0gTlVMTDsKIH0KIAogLyoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0yNiw3ICsyNiw3
IEBACiAjaW5jbHVkZSAiLi4vYXRzLmgiCiAKIC8qIGRvbV9pbyBpcyB1c2Vk
IGFzIGEgc2VudGluZWwgZm9yIHF1YXJhbnRpbmVkIGRldmljZXMgKi8KLSNk
ZWZpbmUgUVVBUkFOVElORV9TS0lQKGQpICgoZCkgPT0gZG9tX2lvICYmICFk
b21faW9tbXUoZCktPmFyY2guYW1kLnJvb3RfdGFibGUpCisjZGVmaW5lIFFV
QVJBTlRJTkVfU0tJUChkLCBwKSAoKGQpID09IGRvbV9pbyAmJiAhKHApLT5h
cmNoLmFtZC5yb290X3RhYmxlKQogCiBzdGF0aWMgYm9vbF90IF9fcmVhZF9t
b3N0bHkgaW5pdF9kb25lOwogCkBAIC0xMjUsOCArMTI1LDEwIEBAIHN0YXRp
YyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICB1OCBi
dXMgPSBwZGV2LT5idXM7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQg
PSBkb21faW9tbXUoZG9tYWluKTsKICAgICBjb25zdCBzdHJ1Y3QgaXZyc19t
YXBwaW5ncyAqaXZyc19kZXY7CisgICAgY29uc3Qgc3RydWN0IHBhZ2VfaW5m
byAqcm9vdF9wZzsKKyAgICBkb21pZF90IGRvbWlkOwogCi0gICAgaWYgKCBR
VUFSQU5USU5FX1NLSVAoZG9tYWluKSApCisgICAgaWYgKCBRVUFSQU5USU5F
X1NLSVAoZG9tYWluLCBwZGV2KSApCiAgICAgICAgIHJldHVybiAwOwogCiAg
ICAgQlVHX09OKCFoZC0+YXJjaC5hbWQucGFnaW5nX21vZGUgfHwgIWlvbW11
LT5kZXZfdGFibGUuYnVmZmVyKTsKQEAgLTE0NywxNCArMTQ5LDI1IEBAIHN0
YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICBk
dGUgPSAmdGFibGVbcmVxX2lkXTsKICAgICBpdnJzX2RldiA9ICZnZXRfaXZy
c19tYXBwaW5ncyhpb21tdS0+c2VnKVtyZXFfaWRdOwogCisgICAgaWYgKCBk
b21haW4gIT0gZG9tX2lvICkKKyAgICB7CisgICAgICAgIHJvb3RfcGcgPSBo
ZC0+YXJjaC5hbWQucm9vdF90YWJsZTsKKyAgICAgICAgZG9taWQgPSBkb21h
aW4tPmRvbWFpbl9pZDsKKyAgICB9CisgICAgZWxzZQorICAgIHsKKyAgICAg
ICAgcm9vdF9wZyA9IHBkZXYtPmFyY2guYW1kLnJvb3RfdGFibGU7CisgICAg
ICAgIGRvbWlkID0gcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQ7CisgICAgfQor
CiAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmlvbW11LT5sb2NrLCBmbGFncyk7
CiAKICAgICBpZiAoICFkdGUtPnYgfHwgIWR0ZS0+dHYgKQogICAgIHsKICAg
ICAgICAgLyogYmluZCBEVEUgdG8gZG9tYWluIHBhZ2UtdGFibGVzICovCiAg
ICAgICAgIHJjID0gYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoCi0g
ICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkcihoZC0+YXJjaC5h
bWQucm9vdF90YWJsZSksCi0gICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9t
YWluX2lkLCBoZC0+YXJjaC5hbWQucGFnaW5nX21vZGUsIHNyX2ZsYWdzKTsK
KyAgICAgICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRyKHJvb3RfcGcp
LCBkb21pZCwKKyAgICAgICAgICAgICAgICAgaGQtPmFyY2guYW1kLnBhZ2lu
Z19tb2RlLCBzcl9mbGFncyk7CiAgICAgICAgIGlmICggcmMgKQogICAgICAg
ICB7CiAgICAgICAgICAgICBBU1NFUlQocmMgPCAwKTsKQEAgLTE4MSw3ICsx
OTQsNyBAQCBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0
dXBfCiAKICAgICAgICAgYW1kX2lvbW11X2ZsdXNoX2RldmljZShpb21tdSwg
cmVxX2lkKTsKICAgICB9Ci0gICAgZWxzZSBpZiAoIGR0ZS0+cHRfcm9vdCAh
PSBtZm5feChwYWdlX3RvX21mbihoZC0+YXJjaC5hbWQucm9vdF90YWJsZSkp
ICkKKyAgICBlbHNlIGlmICggZHRlLT5wdF9yb290ICE9IG1mbl94KHBhZ2Vf
dG9fbWZuKHJvb3RfcGcpKSApCiAgICAgewogICAgICAgICAvKgogICAgICAg
ICAgKiBTdHJpY3RseSBzcGVha2luZyBpZiB0aGUgZGV2aWNlIGlzIHRoZSBv
bmx5IG9uZSB3aXRoIHRoaXMgcmVxdWVzdG9yCkBAIC0xOTQsOCArMjA3LDgg
QEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwog
ICAgICAgICAgICAgcmMgPSAtRU9QTk9UU1VQUDsKICAgICAgICAgZWxzZQog
ICAgICAgICAgICAgcmMgPSBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJs
ZSgKLSAgICAgICAgICAgICAgICAgICAgIGR0ZSwgcGFnZV90b19tYWRkciho
ZC0+YXJjaC5hbWQucm9vdF90YWJsZSksCi0gICAgICAgICAgICAgICAgICAg
ICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2guYW1kLnBhZ2luZ19tb2Rl
LCBzcl9mbGFncyk7CisgICAgICAgICAgICAgICAgICAgICBkdGUsIHBhZ2Vf
dG9fbWFkZHIocm9vdF9wZyksIGRvbWlkLAorICAgICAgICAgICAgICAgICAg
ICAgaGQtPmFyY2guYW1kLnBhZ2luZ19tb2RlLCBzcl9mbGFncyk7CiAgICAg
ICAgIGlmICggcmMgPCAwICkKICAgICAgICAgewogICAgICAgICAgICAgc3Bp
bl91bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKQEAg
LTIxNCw2ICsyMjcsNyBAQCBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBhbWRf
aW9tbXVfc2V0dXBfCiAgICAgICAgICAgICAgICogaW50ZW5kZWQgYW55d2F5
LgogICAgICAgICAgICAgICAqLwogICAgICAgICAgICAgICFwZGV2LT5kb21h
aW4tPmlzX2R5aW5nICYmCisgICAgICAgICAgICAgcGRldi0+ZG9tYWluICE9
IGRvbV9pbyAmJgogICAgICAgICAgICAgIChhbnlfcGRldl9iZWhpbmRfaW9t
bXUocGRldi0+ZG9tYWluLCBwZGV2LCBpb21tdSkgfHwKICAgICAgICAgICAg
ICAgcGRldi0+cGhhbnRvbV9zdHJpZGUpICkKICAgICAgICAgICAgIEFNRF9J
T01NVV9XQVJOKCIgJXBwOiByZWFzc2lnbm1lbnQgbWF5IGNhdXNlICVwZCBk
YXRhIGNvcnJ1cHRpb25cbiIsCkBAIC0yNDYsOSArMjYwLDggQEAgc3RhdGlj
IGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwogICAgIEFNRF9J
T01NVV9ERUJVRygiU2V0dXAgSS9PIHBhZ2UgdGFibGU6IGRldmljZSBpZCA9
ICUjeCwgdHlwZSA9ICUjeCwgIgogICAgICAgICAgICAgICAgICAgICAicm9v
dCB0YWJsZSA9ICUjIlBSSXg2NCIsICIKICAgICAgICAgICAgICAgICAgICAg
ImRvbWFpbiA9ICVkLCBwYWdpbmcgbW9kZSA9ICVkXG4iLAotICAgICAgICAg
ICAgICAgICAgICByZXFfaWQsIHBkZXYtPnR5cGUsCi0gICAgICAgICAgICAg
ICAgICAgIHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2guYW1kLnJvb3RfdGFibGUp
LAotICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgaGQt
PmFyY2guYW1kLnBhZ2luZ19tb2RlKTsKKyAgICAgICAgICAgICAgICAgICAg
cmVxX2lkLCBwZGV2LT50eXBlLCBwYWdlX3RvX21hZGRyKHJvb3RfcGcpLAor
ICAgICAgICAgICAgICAgICAgICBkb21pZCwgaGQtPmFyY2guYW1kLnBhZ2lu
Z19tb2RlKTsKIAogICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKIApA
QCAtMzI3LDcgKzM0MCw3IEBAIGludCBhbWRfaW9tbXVfYWxsb2Nfcm9vdChz
dHJ1Y3QgZG9tYWluICoKIHsKICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpo
ZCA9IGRvbV9pb21tdShkKTsKIAotICAgIGlmICggdW5saWtlbHkoIWhkLT5h
cmNoLmFtZC5yb290X3RhYmxlKSApCisgICAgaWYgKCB1bmxpa2VseSghaGQt
PmFyY2guYW1kLnJvb3RfdGFibGUpICYmIGQgIT0gZG9tX2lvICkKICAgICB7
CiAgICAgICAgIGhkLT5hcmNoLmFtZC5yb290X3RhYmxlID0gaW9tbXVfYWxs
b2NfcGd0YWJsZShoZCk7CiAgICAgICAgIGlmICggIWhkLT5hcmNoLmFtZC5y
b290X3RhYmxlICkKQEAgLTM5MSw3ICs0MDQsNyBAQCBzdGF0aWMgdm9pZCBh
bWRfaW9tbXVfZGlzYWJsZV9kb21haW5fZGV2CiAgICAgaW50IHJlcV9pZDsK
ICAgICB1OCBidXMgPSBwZGV2LT5idXM7CiAKLSAgICBpZiAoIFFVQVJBTlRJ
TkVfU0tJUChkb21haW4pICkKKyAgICBpZiAoIFFVQVJBTlRJTkVfU0tJUChk
b21haW4sIHBkZXYpICkKICAgICAgICAgcmV0dXJuOwogCiAgICAgQVNTRVJU
KHBjaWRldnNfbG9ja2VkKCkpOwpAQCAtNDMwLDcgKzQ0Myw3IEBAIHN0YXRp
YyB2b2lkIGFtZF9pb21tdV9kaXNhYmxlX2RvbWFpbl9kZXYKIAogICAgICAg
ICBBTURfSU9NTVVfREVCVUcoIkRpc2FibGU6IGRldmljZSBpZCA9ICUjeCwg
IgogICAgICAgICAgICAgICAgICAgICAgICAgImRvbWFpbiA9ICVkLCBwYWdp
bmcgbW9kZSA9ICVkXG4iLAotICAgICAgICAgICAgICAgICAgICAgICAgcmVx
X2lkLCAgZG9tYWluLT5kb21haW5faWQsCisgICAgICAgICAgICAgICAgICAg
ICAgICByZXFfaWQsIGR0ZS0+ZG9tYWluX2lkLAogICAgICAgICAgICAgICAg
ICAgICAgICAgZG9tX2lvbW11KGRvbWFpbiktPmFyY2guYW1kLnBhZ2luZ19t
b2RlKTsKICAgICB9CiAgICAgZWxzZQpAQCAtNDUzLDcgKzQ2Niw3IEBAIHN0
YXRpYyBpbnQgcmVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4KICAgICAg
ICAgcmV0dXJuIC1FTk9ERVY7CiAgICAgfQogCi0gICAgaWYgKCAhUVVBUkFO
VElORV9TS0lQKHRhcmdldCkgKQorICAgIGlmICggIVFVQVJBTlRJTkVfU0tJ
UCh0YXJnZXQsIHBkZXYpICkKICAgICB7CiAgICAgICAgIHJjID0gYW1kX2lv
bW11X3NldHVwX2RvbWFpbl9kZXZpY2UodGFyZ2V0LCBpb21tdSwgZGV2Zm4s
IHBkZXYpOwogICAgICAgICBpZiAoIHJjICkKQEAgLTY1NSw2ICs2NjgsOCBA
QCBzdGF0aWMgaW50IGFtZF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4IGRlCiAg
ICAgICAgIEFNRF9JT01NVV9XQVJOKCIlcGQ6IHVuaXR5IHVubWFwcGluZyBm
YWlsZWQgZm9yICVwcFxuIiwKICAgICAgICAgICAgICAgICAgICAgICAgcGRl
di0+ZG9tYWluLCAmcGRldi0+c2JkZik7CiAKKyAgICBhbWRfaW9tbXVfcXVh
cmFudGluZV90ZWFyZG93bihwZGV2KTsKKwogICAgIGlvbW11X2ZyZWVfZG9t
aWQocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsIGlvbW11LT5kb21pZF9tYXAp
OwogICAgIHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID0gRE9NSURfSU5WQUxJ
RDsKIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9pb21tdS5jCisr
KyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMKQEAgLTQ0Mywy
MSArNDQzLDIyIEBAIGludCBpb21tdV9pb3RsYl9mbHVzaF9hbGwoc3RydWN0
IGRvbWFpbgogICAgIHJldHVybiByYzsKIH0KIAotc3RhdGljIGludCBfX2lu
aXQgaW9tbXVfcXVhcmFudGluZV9pbml0KHZvaWQpCitpbnQgaW9tbXVfcXVh
cmFudGluZV9kZXZfaW5pdChkZXZpY2VfdCAqZGV2KQogewogICAgIGNvbnN0
IHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbV9pbyk7
Ci0gICAgaW50IHJjOwogCi0gICAgZG9tX2lvLT5vcHRpb25zIHw9IFhFTl9E
T01DVExfQ0RGX2lvbW11OworICAgIGlmICggIWlvbW11X3F1YXJhbnRpbmUg
fHwgIWhkLT5wbGF0Zm9ybV9vcHMtPnF1YXJhbnRpbmVfaW5pdCApCisgICAg
ICAgIHJldHVybiAwOwogCi0gICAgcmMgPSBpb21tdV9kb21haW5faW5pdChk
b21faW8sIDApOwotICAgIGlmICggcmMgfHwgaW9tbXVfcXVhcmFudGluZSA8
IElPTU1VX3F1YXJhbnRpbmVfc2NyYXRjaF9wYWdlICkKLSAgICAgICAgcmV0
dXJuIHJjOworICAgIHJldHVybiBpb21tdV9jYWxsKGhkLT5wbGF0Zm9ybV9v
cHMsIHF1YXJhbnRpbmVfaW5pdCwKKyAgICAgICAgICAgICAgICAgICAgICBk
ZXYsIGlvbW11X3F1YXJhbnRpbmUgPT0gSU9NTVVfcXVhcmFudGluZV9zY3Jh
dGNoX3BhZ2UpOworfQogCi0gICAgaWYgKCAhaGQtPnBsYXRmb3JtX29wcy0+
cXVhcmFudGluZV9pbml0ICkKLSAgICAgICAgcmV0dXJuIDA7CitzdGF0aWMg
aW50IF9faW5pdCBpb21tdV9xdWFyYW50aW5lX2luaXQodm9pZCkKK3sKKyAg
ICBkb21faW8tPm9wdGlvbnMgfD0gWEVOX0RPTUNUTF9DREZfaW9tbXU7CiAK
LSAgICByZXR1cm4gaGQtPnBsYXRmb3JtX29wcy0+cXVhcmFudGluZV9pbml0
KGRvbV9pbyk7CisgICAgcmV0dXJuIGlvbW11X2RvbWFpbl9pbml0KGRvbV9p
bywgMCk7CiB9CiAKIGludCBfX2luaXQgaW9tbXVfc2V0dXAodm9pZCkKLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMKKysrIGIveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMKQEAgLTg1Miw5ICs4NTIsMTYgQEAg
c3RhdGljIGludCBkZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbgogICAg
ICAgICByZXR1cm4gLUVOT0RFVjsKIAogICAgIC8qIERlLWFzc2lnbm1lbnQg
ZnJvbSBkb21faW8gc2hvdWxkIGRlLXF1YXJhbnRpbmUgdGhlIGRldmljZSAq
LwotICAgIHRhcmdldCA9ICgocGRldi0+cXVhcmFudGluZSB8fCBpb21tdV9x
dWFyYW50aW5lKSAmJgotICAgICAgICAgICAgICBwZGV2LT5kb21haW4gIT0g
ZG9tX2lvKSA/Ci0gICAgICAgIGRvbV9pbyA6IGhhcmR3YXJlX2RvbWFpbjsK
KyAgICBpZiAoIChwZGV2LT5xdWFyYW50aW5lIHx8IGlvbW11X3F1YXJhbnRp
bmUpICYmIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gKQorICAgIHsKKyAgICAg
ICAgcmV0ID0gaW9tbXVfcXVhcmFudGluZV9kZXZfaW5pdChwY2lfdG9fZGV2
KHBkZXYpKTsKKyAgICAgICAgaWYgKCByZXQgKQorICAgICAgICAgICByZXR1
cm4gcmV0OworCisgICAgICAgIHRhcmdldCA9IGRvbV9pbzsKKyAgICB9Cisg
ICAgZWxzZQorICAgICAgICB0YXJnZXQgPSBoYXJkd2FyZV9kb21haW47CiAK
ICAgICB3aGlsZSAoIHBkZXYtPnBoYW50b21fc3RyaWRlICkKICAgICB7CkBA
IC0xNDI0LDYgKzE0MzEsMTMgQEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNl
KHN0cnVjdCBkb21haW4gKgogICAgIGlmICggcmMgKQogICAgICAgICBnb3Rv
IGRvbmU7CiAKKyAgICBpZiAoIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gKQor
ICAgIHsKKyAgICAgICAgcmMgPSBpb21tdV9xdWFyYW50aW5lX2Rldl9pbml0
KHBjaV90b19kZXYocGRldikpOworICAgICAgICBpZiAoIHJjICkKKyAgICAg
ICAgICAgIGdvdG8gZG9uZTsKKyAgICB9CisKICAgICBwZGV2LT5mYXVsdC5j
b3VudCA9IDA7CiAKICAgICBpZiAoIChyYyA9IGhkLT5wbGF0Zm9ybV9vcHMt
PmFzc2lnbl9kZXZpY2UoZCwgZGV2Zm4sIHBjaV90b19kZXYocGRldiksIGZs
YWcpKSApCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21t
dS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5j
CkBAIC00NSw2ICs0NSwxMSBAQAogCiAvKiBkb21faW8gaXMgdXNlZCBhcyBh
IHNlbnRpbmVsIGZvciBxdWFyYW50aW5lZCBkZXZpY2VzICovCiAjZGVmaW5l
IFFVQVJBTlRJTkVfU0tJUChkLCBwZ2RfbWFkZHIpICgoZCkgPT0gZG9tX2lv
ICYmICEocGdkX21hZGRyKSkKKyNkZWZpbmUgREVWSUNFX0RPTUlEKGQsIHBk
ZXYpICgoZCkgIT0gZG9tX2lvID8gKGQpLT5kb21haW5faWQgXAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAocGRl
diktPmFyY2gucHNldWRvX2RvbWlkKQorI2RlZmluZSBERVZJQ0VfUEdUQUJM
RShkLCBwZGV2KSAoKGQpICE9IGRvbV9pbyBcCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICA/IGRvbV9pb21tdShkKS0+YXJjaC52dGQucGdk
X21hZGRyIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDog
KHBkZXYpLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIpCiAKIC8qIFBvc3NpYmxlIHVu
ZmlsdGVyZWQgTEFQSUMvTVNJIG1lc3NhZ2VzIGZyb20gdW50cnVzdGVkIHNv
dXJjZXM/ICovCiBib29sIF9fcmVhZF9tb3N0bHkgdW50cnVzdGVkX21zaTsK
QEAgLTg4LDEzICs5MywxOCBAQCBzdGF0aWMgaW50IGdldF9pb21tdV9kaWQo
ZG9taWRfdCBkb21pZCwKIAogI2RlZmluZSBESURfRklFTERfV0lEVEggMTYK
ICNkZWZpbmUgRElEX0hJR0hfT0ZGU0VUIDgKKworLyoKKyAqIFRoaXMgZnVu
Y3Rpb24gbWF5IGhhdmUgImNvbnRleHQiIHBhc3NlZCBhcyBOVUxMLCB0byBt
ZXJlbHkgb2J0YWluIGEgRElECisgKiBmb3IgImRvbWlkIi4KKyAqLwogc3Rh
dGljIGludCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0IGNvbnRleHRf
ZW50cnkgKmNvbnRleHQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBkb21pZF90IGRvbWlkLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkK
IHsKICAgICB1bnNpZ25lZCBsb25nIG5yX2RvbSwgaTsKICAgICBpbnQgZm91
bmQgPSAwOwogCi0gICAgQVNTRVJUKHNwaW5faXNfbG9ja2VkKCZpb21tdS0+
bG9jaykpOworICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKIAogICAg
IG5yX2RvbSA9IGNhcF9uZG9tcyhpb21tdS0+Y2FwKTsKICAgICBpID0gZmlu
ZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsKQEAg
LTEyMCw4ICsxMzAsMTMgQEAgc3RhdGljIGludCBjb250ZXh0X3NldF9kb21h
aW5faWQoc3RydWN0CiAgICAgfQogCiAgICAgc2V0X2JpdChpLCBpb21tdS0+
ZG9taWRfYml0bWFwKTsKLSAgICBjb250ZXh0LT5oaSAmPSB+KCgoMSA8PCBE
SURfRklFTERfV0lEVEgpIC0gMSkgPDwgRElEX0hJR0hfT0ZGU0VUKTsKLSAg
ICBjb250ZXh0LT5oaSB8PSAoaSAmICgoMSA8PCBESURfRklFTERfV0lEVEgp
IC0gMSkpIDw8IERJRF9ISUdIX09GRlNFVDsKKworICAgIGlmICggY29udGV4
dCApCisgICAgeworICAgICAgICBjb250ZXh0LT5oaSAmPSB+KCgoMSA8PCBE
SURfRklFTERfV0lEVEgpIC0gMSkgPDwgRElEX0hJR0hfT0ZGU0VUKTsKKyAg
ICAgICAgY29udGV4dC0+aGkgfD0gKGkgJiAoKDEgPDwgRElEX0ZJRUxEX1dJ
RFRIKSAtIDEpKSA8PCBESURfSElHSF9PRkZTRVQ7CisgICAgfQorCiAgICAg
cmV0dXJuIDA7CiB9CiAKQEAgLTE3MSw4ICsxODYsMTIgQEAgc3RhdGljIHZv
aWQgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAoY29ucwogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYg
KmV4Y2x1ZGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKIHsKLSAgICBib29sIGZvdW5k
ID0gYW55X3BkZXZfYmVoaW5kX2lvbW11KGQsIGV4Y2x1ZGUsIGlvbW11KTsK
KyAgICBib29sIGZvdW5kOworCisgICAgaWYgKCBkID09IGRvbV9pbyApCisg
ICAgICAgIHJldHVybjsKIAorICAgIGZvdW5kID0gYW55X3BkZXZfYmVoaW5k
X2lvbW11KGQsIGV4Y2x1ZGUsIGlvbW11KTsKICAgICAvKgogICAgICAqIEhp
ZGRlbiBkZXZpY2VzIGFyZSBhc3NvY2lhdGVkIHdpdGggRG9tWEVOIGJ1dCB1
c2FibGUgYnkgdGhlIGhhcmR3YXJlCiAgICAgICogZG9tYWluLiBIZW5jZSB0
aGV5IG5lZWQgY29uc2lkZXJpbmcgaGVyZSBhcyB3ZWxsLgpAQCAtMTQyNiw3
ICsxNDQ1LDcgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAog
ICAgICAgICBkb21pZCA9IGlvbW11LT5kb21pZF9tYXBbcHJldl9kaWRdOwog
ICAgICAgICBpZiAoIGRvbWlkIDwgRE9NSURfRklSU1RfUkVTRVJWRUQgKQog
ICAgICAgICAgICAgcHJldl9kb20gPSByY3VfbG9ja19kb21haW5fYnlfaWQo
ZG9taWQpOwotICAgICAgICBlbHNlIGlmICggZG9taWQgPT0gRE9NSURfSU8g
KQorICAgICAgICBlbHNlIGlmICggcGRldiA/IGRvbWlkID09IHBkZXYtPmFy
Y2gucHNldWRvX2RvbWlkIDogZG9taWQgPiBET01JRF9NQVNLICkKICAgICAg
ICAgICAgIHByZXZfZG9tID0gcmN1X2xvY2tfZG9tYWluKGRvbV9pbyk7CiAg
ICAgICAgIGlmICggIXByZXZfZG9tICkKICAgICAgICAgewpAQCAtMTU4Miwx
NSArMTYwMSwxMiBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUo
CiAgICAgewogICAgICAgICBpZiAoICFwcmV2X2RvbSApCiAgICAgICAgICAg
ICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21t
dSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7CisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlE
KGRvbWFpbiwgcGRldikpOwogICAgICAgICBlbHNlIGlmICggcHJldl9kb20g
IT0gZG9tYWluICkgLyogQXZvaWQgaW5maW5pdGUgcmVjdXJzaW9uLiAqLwot
ICAgICAgICB7Ci0gICAgICAgICAgICBoZCA9IGRvbV9pb21tdShwcmV2X2Rv
bSk7CiAgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5n
X29uZShwcmV2X2RvbSwgaW9tbXUsIGJ1cywgZGV2Zm4sIHBkZXYsCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21h
aW4tPmRvbWFpbl9pZCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGhkLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIsCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBERVZJ
Q0VfRE9NSUQocHJldl9kb20sIHBkZXYpLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX1BHVEFCTEUocHJl
dl9kb20sIHBkZXYpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgbW9kZSAmIE1BUF9XSVRIX1JNUlIpIDwgMDsKLSAg
ICAgICAgfQogICAgICAgICBlbHNlCiAgICAgICAgICAgICByZXQgPSAxOwog
CkBAIC0xNjEyLDcgKzE2MjgsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250
ZXh0X21hcHBpbmcoc3RydWN0CiB7CiAgICAgY29uc3Qgc3RydWN0IGFjcGlf
ZHJoZF91bml0ICpkcmhkID0gYWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0
KHBkZXYpOwogICAgIGNvbnN0IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1y
cjsKLSAgICBwYWRkcl90IHBnZF9tYWRkciA9IGRvbV9pb21tdShkb21haW4p
LT5hcmNoLnZ0ZC5wZ2RfbWFkZHI7CisgICAgcGFkZHJfdCBwZ2RfbWFkZHIg
PSBERVZJQ0VfUEdUQUJMRShkb21haW4sIHBkZXYpOwogICAgIGRvbWlkX3Qg
b3JpZ19kb21pZCA9IHBkZXYtPmFyY2gucHNldWRvX2RvbWlkOwogICAgIGlu
dCByZXQgPSAwOwogICAgIHVuc2lnbmVkIGludCBpLCBtb2RlID0gMDsKQEAg
LTE2NDEsNyArMTY1Nyw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRf
bWFwcGluZyhzdHJ1Y3QKICAgICAgICAgYnJlYWs7CiAgICAgfQogCi0gICAg
aWYgKCBkb21haW4gIT0gcGRldi0+ZG9tYWluICkKKyAgICBpZiAoIGRvbWFp
biAhPSBwZGV2LT5kb21haW4gJiYgcGRldi0+ZG9tYWluICE9IGRvbV9pbyAp
CiAgICAgewogICAgICAgICBpZiAoIHBkZXYtPmRvbWFpbi0+aXNfZHlpbmcg
KQogICAgICAgICAgICAgbW9kZSB8PSBNQVBfT1dORVJfRFlJTkc7CkBAIC0x
NjgzLDggKzE2OTksOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21h
cHBpbmcoc3RydWN0CiAgICAgICAgIGlmICggaW9tbXVfZGVidWcgKQogICAg
ICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiJXBkOlBDSWU6IG1hcCAlcHBc
biIsCiAgICAgICAgICAgICAgICAgICAgZG9tYWluLCAmUENJX1NCREYzKHNl
ZywgYnVzLCBkZXZmbikpOwotICAgICAgICByZXQgPSBkb21haW5fY29udGV4
dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZu
LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw
ZGV2LCBkb21haW4tPmRvbWFpbl9pZCwgcGdkX21hZGRyLAorICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQt
PmlvbW11LCBidXMsIGRldmZuLCBwZGV2LAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBw
ZGV2KSwgcGdkX21hZGRyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBtb2RlKTsKICAgICAgICAgaWYgKCByZXQgPiAwICkK
ICAgICAgICAgICAgIHJldCA9IDA7CkBAIC0xNzEwLDggKzE3MjYsOCBAQCBz
dGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAg
ICAgICAgICAgICAgICAgZG9tYWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBk
ZXZmbikpOwogCiAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIGRv
bWFpbi0+ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCi0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGUpOworICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LCBERVZJQ0VfRE9N
SUQoZG9tYWluLCBwZGV2KSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgcGdkX21hZGRyLCBtb2RlKTsKICAgICAgICAgaWYg
KCByZXQgPCAwICkKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBwcmV2
X3ByZXNlbnQgPSByZXQ7CkBAIC0xNzM5LDggKzE3NTUsOCBAQCBzdGF0aWMg
aW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAq
LwogICAgICAgICBpZiAoIHJldCA+PSAwICkKICAgICAgICAgICAgIHJldCA9
IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9t
bXUsIGJ1cywgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBOVUxMLCBkb21haW4tPmRvbWFpbl9pZCwgcGdk
X21hZGRyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBOVUxMLCBERVZJQ0VfRE9NSUQoZG9tYWluLCBw
ZGV2KSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHBnZF9tYWRkciwgbW9kZSk7CiAKICAgICAgICAgLyoKICAgICAg
ICAgICogRGV2aWNlcyBiZWhpbmQgUENJZS10by1QQ0kvUENJeCBicmlkZ2Ug
bWF5IGdlbmVyYXRlIGRpZmZlcmVudApAQCAtMTc1NSw4ICsxNzcxLDggQEAg
c3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAg
ICAgICBpZiAoICFyZXQgJiYgcGRldl90eXBlKHNlZywgYnVzLCBkZXZmbikg
PT0gREVWX1RZUEVfUENJZTJQQ0lfQlJJREdFICYmCiAgICAgICAgICAgICAg
KHNlY2J1cyAhPSBwZGV2LT5idXMgfHwgcGRldi0+ZGV2Zm4gIT0gMCkgKQog
ICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUo
ZG9tYWluLCBkcmhkLT5pb21tdSwgc2VjYnVzLCAwLAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgZG9tYWlu
LT5kb21haW5faWQsIHBnZF9tYWRkciwKLSAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGUpOworICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgREVWSUNF
X0RPTUlEKGRvbWFpbiwgcGRldiksCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBwZ2RfbWFkZHIsIG1vZGUpOwogCiAg
ICAgICAgIGlmICggcmV0ICkKICAgICAgICAgewpAQCAtMTc5OCw5ICsxODE0
LDYgQEAgaW50IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZSgKICAgICBpbnQg
aW9tbXVfZG9taWQsIHJjLCByZXQ7CiAgICAgYm9vbF90IGZsdXNoX2Rldl9p
b3RsYjsKIAotICAgIGlmICggUVVBUkFOVElORV9TS0lQKGRvbWFpbiwgZG9t
X2lvbW11KGRvbWFpbiktPmFyY2gudnRkLnBnZF9tYWRkcikgKQotICAgICAg
ICByZXR1cm4gMDsKLQogICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsK
ICAgICBzcGluX2xvY2soJmlvbW11LT5sb2NrKTsKIApAQCAtMTkwMiw3ICsx
OTE1LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAq
ZG9tYQogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiJXBkOlBDSWU6
IHVubWFwICVwcFxuIiwKICAgICAgICAgICAgICAgICAgICBkb21haW4sICZQ
Q0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7CiAgICAgICAgIHJldCA9IGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMsIGRl
dmZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ZG9tYWluLT5kb21haW5faWQpOworICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgREVWSUNFX0RPTUlEKGRvbWFpbiwgcGRldikpOwog
ICAgICAgICBpZiAoICFyZXQgJiYgZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYg
YXRzX2RldmljZShwZGV2LCBkcmhkKSA+IDAgKQogICAgICAgICAgICAgZGlz
YWJsZV9hdHNfZGV2aWNlKHBkZXYpOwogCkBAIC0xOTE2LDcgKzE5MjksNyBA
QCBzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkb21hCiAg
ICAgICAgICAgICBwcmludGsoVlREUFJFRklYICIlcGQ6UENJOiB1bm1hcCAl
cHBcbiIsCiAgICAgICAgICAgICAgICAgICAgZG9tYWluLCAmUENJX1NCREYz
KHNlZywgYnVzLCBkZXZmbikpOwogICAgICAgICByZXQgPSBkb21haW5fY29u
dGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgYnVzLCBkZXZmbiwKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+
ZG9tYWluX2lkKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIERFVklDRV9ET01JRChkb21haW4sIHBkZXYpKTsKICAgICAgICAg
aWYgKCByZXQgKQogICAgICAgICAgICAgYnJlYWs7CiAKQEAgLTE5MzksMTgg
KzE5NTIsMTIgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5p
dCAqZG9tYQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAorICAg
ICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBp
b21tdSwgdG1wX2J1cywgdG1wX2RldmZuLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlEKGRvbWFpbiwgcGRl
dikpOwogICAgICAgICAvKiBQQ0llIHRvIFBDSS9QQ0l4IGJyaWRnZSAqLwot
ICAgICAgICBpZiAoIHBkZXZfdHlwZShzZWcsIHRtcF9idXMsIHRtcF9kZXZm
bikgPT0gREVWX1RZUEVfUENJZTJQQ0lfQlJJREdFICkKLSAgICAgICAgewot
ICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRv
bWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFp
bl9pZCk7Ci0gICAgICAgICAgICBpZiAoICFyZXQgKQotICAgICAgICAgICAg
ICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlv
bW11LCBzZWNidXMsIDAsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKLSAgICAg
ICAgfQotICAgICAgICBlbHNlIC8qIExlZ2FjeSBQQ0kgYnJpZGdlICovCi0g
ICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9t
YWluLCBpb21tdSwgdG1wX2J1cywgdG1wX2RldmZuLAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWlu
X2lkKTsKKyAgICAgICAgaWYgKCAhcmV0ICYmIHBkZXZfdHlwZShzZWcsIHRt
cF9idXMsIHRtcF9kZXZmbikgPT0gREVWX1RZUEVfUENJZTJQQ0lfQlJJREdF
ICkKKyAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29u
ZShkb21haW4sIGlvbW11LCBzZWNidXMsIDAsCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlEKGRvbWFp
biwgcGRldikpOwogCiAgICAgICAgIGJyZWFrOwogCkBAIC0xOTYxLDcgKzE5
NjgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpk
b21hCiAgICAgfQogCiAgICAgaWYgKCAhcmV0ICYmIHBkZXYtPmRldmZuID09
IGRldmZuICYmCi0gICAgICAgICAhUVVBUkFOVElORV9TS0lQKGRvbWFpbiwg
ZG9tX2lvbW11KGRvbWFpbiktPmFyY2gudnRkLnBnZF9tYWRkcikgKQorICAg
ICAgICAgIVFVQVJBTlRJTkVfU0tJUChkb21haW4sIHBkZXYtPmFyY2gudnRk
LnBnZF9tYWRkcikgKQogICAgICAgICBjaGVja19jbGVhbnVwX2RvbWlkX21h
cChkb21haW4sIHBkZXYsIGlvbW11KTsKIAogICAgIHJldHVybiBkcmhkOwpA
QCAtMTk5NCw2ICsyMDAxLDI2IEBAIHN0YXRpYyB2b2lkIGlvbW11X2RvbWFp
bl90ZWFyZG93bihzdHJ1Y3QKICAgICBYRlJFRShoZC0+YXJjaC52dGQuaW9t
bXVfYml0bWFwKTsKIH0KIAorc3RhdGljIHZvaWQgcXVhcmFudGluZV90ZWFy
ZG93bihzdHJ1Y3QgcGNpX2RldiAqcGRldiwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpk
cmhkKQoreworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lv
bW11KGRvbV9pbyk7CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7
CisKKyAgICBpZiAoICFwZGV2LT5hcmNoLnZ0ZC5wZ2RfbWFkZHIgKQorICAg
ICAgICByZXR1cm47CisKKyAgICBBU1NFUlQocGFnZV9saXN0X2VtcHR5KCZo
ZC0+YXJjaC5wZ3RhYmxlcy5saXN0KSk7CisgICAgcGFnZV9saXN0X21vdmUo
JmhkLT5hcmNoLnBndGFibGVzLmxpc3QsICZwZGV2LT5hcmNoLnBndGFibGVz
X2xpc3QpOworICAgIHdoaWxlICggaW9tbXVfZnJlZV9wZ3RhYmxlcyhkb21f
aW8pID09IC1FUkVTVEFSVCApCisgICAgICAgIC8qIG5vdGhpbmcgKi87Cisg
ICAgcGRldi0+YXJjaC52dGQucGdkX21hZGRyID0gMDsKKworICAgIGlmICgg
ZHJoZCApCisgICAgICAgIGNsZWFudXBfZG9taWRfbWFwKHBkZXYtPmFyY2gu
cHNldWRvX2RvbWlkLCBkcmhkLT5pb21tdSk7Cit9CisKIHN0YXRpYyBpbnQg
X19tdXN0X2NoZWNrIGludGVsX2lvbW11X21hcF9wYWdlKHN0cnVjdCBkb21h
aW4gKmQsIGRmbl90IGRmbiwKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIG1mbl90IG1mbiwgdW5zaWduZWQgaW50IGZs
YWdzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdW5zaWduZWQgaW50ICpmbHVzaF9mbGFncykKQEAgLTIyMTgsNiAr
MjI0NSw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVfcmVtb3ZlX2Rldmlj
ZSh1OAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmVu
ZF9hZGRyZXNzLCAwKTsKICAgICB9CiAKKyAgICBxdWFyYW50aW5lX3RlYXJk
b3duKHBkZXYsIGRyaGQpOworCiAgICAgaWYgKCBkcmhkICkKICAgICB7CiAg
ICAgICAgIGlvbW11X2ZyZWVfZG9taWQocGRldi0+YXJjaC5wc2V1ZG9fZG9t
aWQsCkBAIC0yNTc2LDcgKzI2MDUsNyBAQCBzdGF0aWMgaW50IHJlYXNzaWdu
X2RldmljZV9vd25lcnNoaXAoCiB7CiAgICAgaW50IHJldDsKIAotICAgIGlm
ICggIVFVQVJBTlRJTkVfU0tJUCh0YXJnZXQsIGRvbV9pb21tdSh0YXJnZXQp
LT5hcmNoLnZ0ZC5wZ2RfbWFkZHIpICkKKyAgICBpZiAoICFRVUFSQU5USU5F
X1NLSVAodGFyZ2V0LCBwZGV2LT5hcmNoLnZ0ZC5wZ2RfbWFkZHIpICkKICAg
ICB7CiAgICAgICAgIGlmICggIWhhc19hcmNoX3BkZXZzKHRhcmdldCkgKQog
ICAgICAgICAgICAgdm14X3BpX2hvb2tzX2Fzc2lnbih0YXJnZXQpOwpAQCAt
MjU5Miw3ICsyNjIxLDcgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Vf
b3duZXJzaGlwKAogICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBw
aW5nKHRhcmdldCwgZGV2Zm4sIHBkZXYpOwogCiAgICAgICAgIGlmICggIXJl
dCAmJiBwZGV2LT5kZXZmbiA9PSBkZXZmbiAmJgotICAgICAgICAgICAgICFR
VUFSQU5USU5FX1NLSVAoc291cmNlLCBkb21faW9tbXUoc291cmNlKS0+YXJj
aC52dGQucGdkX21hZGRyKSApCisgICAgICAgICAgICAgIVFVQVJBTlRJTkVf
U0tJUChzb3VyY2UsIHBkZXYtPmFyY2gudnRkLnBnZF9tYWRkcikgKQogICAg
ICAgICB7CiAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3Vu
aXQgKmRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7
CiAKQEAgLTI5MTMsNjkgKzI5NDIsMTM1IEBAIHN0YXRpYyB2b2lkIHZ0ZF9k
dW1wX3BhZ2VfdGFibGVzKHN0cnVjdAogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgYWdhd190b19sZXZlbChoZC0+YXJjaC52dGQuYWdhdyksIDAs
IDApOwogfQogCi1zdGF0aWMgaW50IF9faW5pdCBpbnRlbF9pb21tdV9xdWFy
YW50aW5lX2luaXQoc3RydWN0IGRvbWFpbiAqZCkKK3N0YXRpYyBpbnQgZmls
bF9xcHQoc3RydWN0IGRtYV9wdGUgKnRoaXMsIHVuc2lnbmVkIGludCBsZXZl
bCwKKyAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGdz
WzZdKQogewotICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lv
bW11KGQpOworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lv
bW11KGRvbV9pbyk7CisgICAgdW5zaWduZWQgaW50IGk7CisgICAgaW50IHJj
ID0gMDsKKworICAgIGZvciAoIGkgPSAwOyAhcmMgJiYgaSA8IFBURV9OVU07
ICsraSApCisgICAgeworICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAqcHRlID0g
JnRoaXNbaV0sICpuZXh0OworCisgICAgICAgIGlmICggIWRtYV9wdGVfcHJl
c2VudCgqcHRlKSApCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICggIXBn
c1tsZXZlbF0gKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIC8q
CisgICAgICAgICAgICAgICAgICogVGhlIHBndGFibGUgYWxsb2NhdG9yIGlz
IGZpbmUgZm9yIHRoZSBsZWFmIHBhZ2UsIGFzIHdlbGwgYXMKKyAgICAgICAg
ICAgICAgICAgKiBwYWdlIHRhYmxlIHBhZ2VzLCBhbmQgdGhlIHJlc3VsdGlu
ZyBhbGxvY2F0aW9ucyBhcmUgYWx3YXlzCisgICAgICAgICAgICAgICAgICog
emVyb2VkLgorICAgICAgICAgICAgICAgICAqLworICAgICAgICAgICAgICAg
IHBnc1tsZXZlbF0gPSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKKyAgICAg
ICAgICAgICAgICBpZiAoICFwZ3NbbGV2ZWxdICkKKyAgICAgICAgICAgICAg
ICB7CisgICAgICAgICAgICAgICAgICAgIHJjID0gLUVOT01FTTsKKyAgICAg
ICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQorCisg
ICAgICAgICAgICAgICAgaWYgKCBsZXZlbCApCisgICAgICAgICAgICAgICAg
eworICAgICAgICAgICAgICAgICAgICBuZXh0ID0gbWFwX3Z0ZF9kb21haW5f
cGFnZShwYWdlX3RvX21hZGRyKHBnc1tsZXZlbF0pKTsKKyAgICAgICAgICAg
ICAgICAgICAgcmMgPSBmaWxsX3FwdChuZXh0LCBsZXZlbCAtIDEsIHBncyk7
CisgICAgICAgICAgICAgICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShu
ZXh0KTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisKKyAg
ICAgICAgICAgIGRtYV9zZXRfcHRlX2FkZHIoKnB0ZSwgcGFnZV90b19tYWRk
cihwZ3NbbGV2ZWxdKSk7CisgICAgICAgICAgICBkbWFfc2V0X3B0ZV9yZWFk
YWJsZSgqcHRlKTsKKyAgICAgICAgICAgIGRtYV9zZXRfcHRlX3dyaXRhYmxl
KCpwdGUpOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKCBsZXZlbCAm
JiAhZG1hX3B0ZV9zdXBlcnBhZ2UoKnB0ZSkgKQorICAgICAgICB7CisgICAg
ICAgICAgICBuZXh0ID0gbWFwX3Z0ZF9kb21haW5fcGFnZShkbWFfcHRlX2Fk
ZHIoKnB0ZSkpOworICAgICAgICAgICAgcmMgPSBmaWxsX3FwdChuZXh0LCBs
ZXZlbCAtIDEsIHBncyk7CisgICAgICAgICAgICB1bm1hcF92dGRfZG9tYWlu
X3BhZ2UobmV4dCk7CisgICAgICAgIH0KKyAgICB9CisKKyAgICByZXR1cm4g
cmM7Cit9CisKK3N0YXRpYyBpbnQgaW50ZWxfaW9tbXVfcXVhcmFudGluZV9p
bml0KHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBib29sIHNjcmF0Y2hfcGFnZSkK
K3sKKyAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShk
b21faW8pOwogICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOwotICAgIHN0cnVj
dCBkbWFfcHRlICpwYXJlbnQ7CiAgICAgdW5zaWduZWQgaW50IGFnYXcgPSB3
aWR0aF90b19hZ2F3KERFRkFVTFRfRE9NQUlOX0FERFJFU1NfV0lEVEgpOwog
ICAgIHVuc2lnbmVkIGludCBsZXZlbCA9IGFnYXdfdG9fbGV2ZWwoYWdhdyk7
Ci0gICAgaW50IHJjID0gMDsKKyAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhk
X3VuaXQgKmRyaGQ7CisgICAgY29uc3Qgc3RydWN0IGFjcGlfcm1ycl91bml0
ICpybXJyOworICAgIHVuc2lnbmVkIGludCBpLCBiZGY7CisgICAgYm9vbCBy
bXJyX2ZvdW5kID0gZmFsc2U7CisgICAgaW50IHJjOwogCi0gICAgc3Bpbl9s
b2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOworICAgIEFTU0VSVChwY2lk
ZXZzX2xvY2tlZCgpKTsKKyAgICBBU1NFUlQoIWhkLT5hcmNoLnZ0ZC5wZ2Rf
bWFkZHIpOworICAgIEFTU0VSVChwYWdlX2xpc3RfZW1wdHkoJmhkLT5hcmNo
LnBndGFibGVzLmxpc3QpKTsKIAotICAgIGlmICggaGQtPmFyY2gudnRkLnBn
ZF9tYWRkciApCisgICAgaWYgKCBwZGV2LT5hcmNoLnZ0ZC5wZ2RfbWFkZHIg
KQogICAgIHsKLSAgICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7Ci0gICAg
ICAgIGdvdG8gb3V0OworICAgICAgICBjbGVhcl9kb21haW5fcGFnZShwZGV2
LT5hcmNoLmxlYWZfbWZuKTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgfQog
Ci0gICAgcGcgPSBpb21tdV9hbGxvY19wZ3RhYmxlKGhkKTsKKyAgICBkcmhk
ID0gYWNwaV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYpOworICAgIGlm
ICggIWRyaGQgKQorICAgICAgICByZXR1cm4gLUVOT0RFVjsKIAotICAgIHJj
ID0gLUVOT01FTTsKKyAgICBwZyA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQp
OwogICAgIGlmICggIXBnICkKLSAgICAgICAgZ290byBvdXQ7CisgICAgICAg
IHJldHVybiAtRU5PTUVNOwogCisgICAgcmMgPSBjb250ZXh0X3NldF9kb21h
aW5faWQoTlVMTCwgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsIGRyaGQtPmlv
bW11KTsKKworICAgIC8qIFRyYW5zaWVudGx5IGluc3RhbGwgdGhlIHJvb3Qg
aW50byBEb21JTywgZm9yIGlvbW11X2lkZW50aXR5X21hcHBpbmcoKS4gKi8K
ICAgICBoZC0+YXJjaC52dGQucGdkX21hZGRyID0gcGFnZV90b19tYWRkcihw
Zyk7CiAKLSAgICBwYXJlbnQgPSBtYXBfdnRkX2RvbWFpbl9wYWdlKGhkLT5h
cmNoLnZ0ZC5wZ2RfbWFkZHIpOwotICAgIHdoaWxlICggbGV2ZWwgKQorICAg
IGZvcl9lYWNoX3JtcnJfZGV2aWNlICggcm1yciwgYmRmLCBpICkKICAgICB7
Ci0gICAgICAgIHVpbnQ2NF90IG1hZGRyOwotICAgICAgICB1bnNpZ25lZCBp
bnQgb2Zmc2V0OwotCi0gICAgICAgIC8qCi0gICAgICAgICAqIFRoZSBwZ3Rh
YmxlIGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUgbGVhZiBwYWdlLCBhcyB3
ZWxsIGFzCi0gICAgICAgICAqIHBhZ2UgdGFibGUgcGFnZXMsIGFuZCB0aGUg
cmVzdWx0aW5nIGFsbG9jYXRpb25zIGFyZSBhbHdheXMKLSAgICAgICAgICog
emVyb2VkLgotICAgICAgICAgKi8KLSAgICAgICAgcGcgPSBpb21tdV9hbGxv
Y19wZ3RhYmxlKGhkKTsKLQotICAgICAgICBpZiAoICFwZyApCi0gICAgICAg
ICAgICBnb3RvIG91dDsKKyAgICAgICAgaWYgKCByYyApCisgICAgICAgICAg
ICBicmVhazsKIAotICAgICAgICBtYWRkciA9IHBhZ2VfdG9fbWFkZHIocGcp
OwotICAgICAgICBmb3IgKCBvZmZzZXQgPSAwOyBvZmZzZXQgPCBQVEVfTlVN
OyBvZmZzZXQrKyApCisgICAgICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBw
ZGV2LT5zZWcgJiYgYmRmID09IHBkZXYtPnNiZGYuYmRmICkKICAgICAgICAg
ewotICAgICAgICAgICAgc3RydWN0IGRtYV9wdGUgKnB0ZSA9ICZwYXJlbnRb
b2Zmc2V0XTsKKyAgICAgICAgICAgIHJtcnJfZm91bmQgPSB0cnVlOwogCi0g
ICAgICAgICAgICBkbWFfc2V0X3B0ZV9hZGRyKCpwdGUsIG1hZGRyKTsKLSAg
ICAgICAgICAgIGRtYV9zZXRfcHRlX3JlYWRhYmxlKCpwdGUpOworICAgICAg
ICAgICAgcmMgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGRvbV9pbywgcDJt
X2FjY2Vzc19ydywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRyZXNz
LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDAp
OworICAgICAgICAgICAgaWYgKCByYyApCisgICAgICAgICAgICAgICAgcHJp
bnRrKFhFTkxPR19FUlIgVlREUFJFRklYCisgICAgICAgICAgICAgICAgICAg
ICAgICIlcHA6IFJNUlIgcXVhcmFudGluZSBtYXBwaW5nIGZhaWxlZFxuIiwK
KyAgICAgICAgICAgICAgICAgICAgICAgJnBkZXYtPnNiZGYpOwogICAgICAg
ICB9Ci0gICAgICAgIGlvbW11X3N5bmNfY2FjaGUocGFyZW50LCBQQUdFX1NJ
WkUpOworICAgIH0KIAotICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2Uo
cGFyZW50KTsKLSAgICAgICAgcGFyZW50ID0gbWFwX3Z0ZF9kb21haW5fcGFn
ZShtYWRkcik7Ci0gICAgICAgIGxldmVsLS07CisgICAgaW9tbXVfaWRlbnRp
dHlfbWFwX3RlYXJkb3duKGRvbV9pbyk7CisgICAgaGQtPmFyY2gudnRkLnBn
ZF9tYWRkciA9IDA7CisgICAgcGRldi0+YXJjaC52dGQucGdkX21hZGRyID0g
cGFnZV90b19tYWRkcihwZyk7CisKKyAgICBpZiAoICFyYyAmJiBzY3JhdGNo
X3BhZ2UgKQorICAgIHsKKyAgICAgICAgc3RydWN0IGRtYV9wdGUgKnJvb3Q7
CisgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnc1s2XSA9IHt9OworCisg
ICAgICAgIHNwaW5fbG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKKwor
ICAgICAgICByb290ID0gbWFwX3Z0ZF9kb21haW5fcGFnZShwZGV2LT5hcmNo
LnZ0ZC5wZ2RfbWFkZHIpOworICAgICAgICByYyA9IGZpbGxfcXB0KHJvb3Qs
IGxldmVsIC0gMSwgcGdzKTsKKyAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9w
YWdlKHJvb3QpOworCisgICAgICAgIHBkZXYtPmFyY2gubGVhZl9tZm4gPSBw
YWdlX3RvX21mbihwZ3NbMF0pOworCisgICAgICAgIHNwaW5fdW5sb2NrKCZo
ZC0+YXJjaC5tYXBwaW5nX2xvY2spOwogICAgIH0KLSAgICB1bm1hcF92dGRf
ZG9tYWluX3BhZ2UocGFyZW50KTsKIAotICAgIHJjID0gMDsKKyAgICBwYWdl
X2xpc3RfbW92ZSgmcGRldi0+YXJjaC5wZ3RhYmxlc19saXN0LCAmaGQtPmFy
Y2gucGd0YWJsZXMubGlzdCk7CiAKLSBvdXQ6Ci0gICAgc3Bpbl91bmxvY2so
JmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CisgICAgaWYgKCByYyB8fCAoIXNj
cmF0Y2hfcGFnZSAmJiAhcm1ycl9mb3VuZCkgKQorICAgICAgICBxdWFyYW50
aW5lX3RlYXJkb3duKHBkZXYsIGRyaGQpOwogCi0gICAgLyogUGFnZXMgbWF5
IGJlIGxlYWtlZCBpbiBmYWlsdXJlIGNhc2UgKi8KICAgICByZXR1cm4gcmM7
CiB9CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgK
QEAgLTQ4Miw3ICs0ODIsNyBAQCBzdHJ1Y3QgdnRkX2lvbW11IHsKICAgICB1
MzIgbnJfcHRfbGV2ZWxzOwogICAgIHU2NAljYXA7CiAgICAgdTY0CWVjYXA7
Ci0gICAgc3BpbmxvY2tfdCBsb2NrOyAvKiBwcm90ZWN0IGNvbnRleHQsIGRv
bWFpbiBpZHMgKi8KKyAgICBzcGlubG9ja190IGxvY2s7IC8qIHByb3RlY3Qg
Y29udGV4dCAqLwogICAgIHNwaW5sb2NrX3QgcmVnaXN0ZXJfbG9jazsgLyog
cHJvdGVjdCBpb21tdSByZWdpc3RlciBoYW5kbGluZyAqLwogICAgIHU2NCBy
b290X21hZGRyOyAvKiByb290IGVudHJ5IG1hY2hpbmUgYWRkcmVzcyAqLwog
ICAgIG5vZGVpZF90IG5vZGU7Ci0tLSBhL3hlbi9pbmNsdWRlL3hlbi9pb21t
dS5oCisrKyBiL3hlbi9pbmNsdWRlL3hlbi9pb21tdS5oCkBAIC0yMzMsNyAr
MjMzLDcgQEAgdHlwZWRlZiBpbnQgaW9tbXVfZ3JkbV90KHhlbl9wZm5fdCBz
dGFydAogc3RydWN0IGlvbW11X29wcyB7CiAgICAgaW50ICgqaW5pdCkoc3Ry
dWN0IGRvbWFpbiAqZCk7CiAgICAgdm9pZCAoKmh3ZG9tX2luaXQpKHN0cnVj
dCBkb21haW4gKmQpOwotICAgIGludCAoKnF1YXJhbnRpbmVfaW5pdCkoc3Ry
dWN0IGRvbWFpbiAqZCk7CisgICAgaW50ICgqcXVhcmFudGluZV9pbml0KShk
ZXZpY2VfdCAqZGV2LCBib29sIHNjcmF0Y2hfcGFnZSk7CiAgICAgaW50ICgq
YWRkX2RldmljZSkodTggZGV2Zm4sIGRldmljZV90ICpkZXYpOwogICAgIGlu
dCAoKmVuYWJsZV9kZXZpY2UpKGRldmljZV90ICpkZXYpOwogICAgIGludCAo
KnJlbW92ZV9kZXZpY2UpKHU4IGRldmZuLCBkZXZpY2VfdCAqZGV2KTsKQEAg
LTM1MCw2ICszNTAsNyBAQCBpbnQgX19tdXN0X2NoZWNrIGlvbW11X3N1c3Bl
bmQodm9pZCk7CiB2b2lkIGlvbW11X3Jlc3VtZSh2b2lkKTsKIHZvaWQgaW9t
bXVfY3Jhc2hfc2h1dGRvd24odm9pZCk7CiBpbnQgaW9tbXVfZ2V0X3Jlc2Vy
dmVkX2RldmljZV9tZW1vcnkoaW9tbXVfZ3JkbV90ICosIHZvaWQgKik7Citp
bnQgaW9tbXVfcXVhcmFudGluZV9kZXZfaW5pdChkZXZpY2VfdCAqZGV2KTsK
IAogI2lmZGVmIENPTkZJR19IQVNfUENJCiBpbnQgaW9tbXVfZG9fcGNpX2Rv
bWN0bChzdHJ1Y3QgeGVuX2RvbWN0bCAqLCBzdHJ1Y3QgZG9tYWluICpkLAo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-04.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBkcm9wIG93bmVyc2hpcCBjaGVja2luZyBmcm9tIGRvbWFpbl9j
b250ZXh0X21hcHBpbmdfb25lKCkKCkRlc3BpdGUgcHV0dGluZyBpbiBxdWl0
ZSBhIGJpdCBvZiBlZmZvcnQgaXQgd2FzIG5vdCBwb3NzaWJsZSB0bwplc3Rh
Ymxpc2ggd2h5IGV4YWN0bHkgdGhpcyBjb2RlIGV4aXN0cyAoYmV5b25kIHBv
c3NpYmx5IHNhbml0eQpjaGVja2luZykuIEluc3RlYWQgb2YgYSBzdWJzZXF1
ZW50IGNoYW5nZSBmdXJ0aGVyIGNvbXBsaWNhdGluZyB0aGlzCmxvZ2ljLCBz
aW1wbHkgZ2V0IHJpZCBvZiBpdC4KClRha2UgdGhlIG9wcG9ydHVuaXR5IGFu
ZCBtb3ZlIHRoZSByZXNwZWN0aXZlIHVubWFwX3Z0ZF9kb21haW5fcGFnZSgp
IG91dApvZiB0aGUgbG9ja2VkIHJlZ2lvbi4KClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdl
ZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+ClJldmlld2VkLWJ5
OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KLS0tCnY0OiBO
ZXcuCgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUu
YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwpA
QCAtMTQyLDI4ICsxNDIsNiBAQCBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2Rv
bWFpbl9pZChzdHJ1Y3QKICAgICByZXR1cm4gMDsKIH0KIAotc3RhdGljIGlu
dCBjb250ZXh0X2dldF9kb21haW5faWQoY29uc3Qgc3RydWN0IGNvbnRleHRf
ZW50cnkgKmNvbnRleHQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBjb25zdCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKLXsKLSAgICBp
bnQgZG9taWQgPSAtMTsKLQotICAgIGlmICggaW9tbXUgJiYgY29udGV4dCAp
Ci0gICAgewotICAgICAgICB1bnNpZ25lZCBpbnQgZG9tX2luZGV4ID0gY29u
dGV4dF9kb21haW5faWQoKmNvbnRleHQpOwotCi0gICAgICAgIGRvbWlkID0g
ZGlkX3RvX2RvbWFpbl9pZChpb21tdSwgZG9tX2luZGV4KTsKLSAgICAgICAg
aWYgKCBkb21pZCA9PSBET01JRF9JTlZBTElEICkKLSAgICAgICAgewotICAg
ICAgICAgICAgZHByaW50ayhYRU5MT0dfREVCVUcgVlREUFJFRklYLAotICAg
ICAgICAgICAgICAgICAgICAibm8gZG9taWQgZm9yIGRpZCAldSAobnJfZG9t
ICV1KVxuIiwKLSAgICAgICAgICAgICAgICAgICAgZG9tX2luZGV4LCBjYXBf
bmRvbXMoaW9tbXUtPmNhcCkpOwotICAgICAgICAgICAgZG9taWQgPSAtMTsK
LSAgICAgICAgfQotICAgIH0KLQotICAgIHJldHVybiBkb21pZDsKLX0KLQog
c3RhdGljIHZvaWQgY2xlYW51cF9kb21pZF9tYXAoc3RydWN0IGRvbWFpbiAq
ZG9tYWluLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKIHsKICAgICBpbnQg
aW9tbXVfZG9taWQ7CkBAIC0xNDEwLDQ0ICsxMzg4LDkgQEAgaW50IGRvbWFp
bl9jb250ZXh0X21hcHBpbmdfb25lKAogCiAgICAgaWYgKCBjb250ZXh0X3By
ZXNlbnQoKmNvbnRleHQpICkKICAgICB7Ci0gICAgICAgIGludCByZXMgPSAw
OwotCi0gICAgICAgIC8qIFRyeSB0byBnZXQgZG9tYWluIG93bmVyc2hpcCBm
cm9tIGRldmljZSBzdHJ1Y3R1cmUuICBJZiB0aGF0J3MKLSAgICAgICAgICog
bm90IGF2YWlsYWJsZSwgdHJ5IHRvIHJlYWQgaXQgZnJvbSB0aGUgY29udGV4
dCBpdHNlbGYuICovCi0gICAgICAgIGlmICggcGRldiApCi0gICAgICAgIHsK
LSAgICAgICAgICAgIGlmICggcGRldi0+ZG9tYWluICE9IGRvbWFpbiApCi0g
ICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19H
X0lORk8gVlREUFJFRklYICIlcGQ6ICVwcCBvd25lZCBieSAlcGQiLAotICAg
ICAgICAgICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBi
dXMsIGRldmZuKSwKLSAgICAgICAgICAgICAgICAgICAgICAgcGRldi0+ZG9t
YWluKTsKLSAgICAgICAgICAgICAgICByZXMgPSAtRUlOVkFMOwotICAgICAg
ICAgICAgfQotICAgICAgICB9Ci0gICAgICAgIGVsc2UKLSAgICAgICAgewot
ICAgICAgICAgICAgaW50IGNkb21haW47Ci0gICAgICAgICAgICBjZG9tYWlu
ID0gY29udGV4dF9nZXRfZG9tYWluX2lkKGNvbnRleHQsIGlvbW11KTsKLSAg
ICAgICAgICAgIAotICAgICAgICAgICAgaWYgKCBjZG9tYWluIDwgMCApCi0g
ICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19H
X1dBUk5JTkcgVlREUFJFRklYCi0gICAgICAgICAgICAgICAgICAgICAgICIl
cGQ6ICVwcCBtYXBwZWQsIGJ1dCBjYW4ndCBmaW5kIG93bmVyXG4iLAotICAg
ICAgICAgICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBi
dXMsIGRldmZuKSk7Ci0gICAgICAgICAgICAgICAgcmVzID0gLUVJTlZBTDsK
LSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGVsc2UgaWYgKCBjZG9tYWlu
ICE9IGRvbWFpbi0+ZG9tYWluX2lkICkKLSAgICAgICAgICAgIHsKLSAgICAg
ICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfSU5GTyBWVERQUkVGSVgKLSAg
ICAgICAgICAgICAgICAgICAgICAgIiVwZDogJXBwIGFscmVhZHkgbWFwcGVk
IHRvIGQlZCIsCi0gICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBD
SV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pLCBjZG9tYWluKTsKLSAgICAgICAg
ICAgICAgICByZXMgPSAtRUlOVkFMOwotICAgICAgICAgICAgfQotICAgICAg
ICB9Ci0KLSAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNvbnRleHRf
ZW50cmllcyk7CiAgICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7
Ci0gICAgICAgIHJldHVybiByZXM7CisgICAgICAgIHVubWFwX3Z0ZF9kb21h
aW5fcGFnZShjb250ZXh0X2VudHJpZXMpOworICAgICAgICByZXR1cm4gMDsK
ICAgICB9CiAKICAgICBpZiAoIGlvbW11X2h3ZG9tX3Bhc3N0aHJvdWdoICYm
IGlzX2hhcmR3YXJlX2RvbWFpbihkb21haW4pICkK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-05.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiByZS1hc3NpZ24gZGV2aWNlcyBkaXJlY3RseQoKRGV2aWNlcyB3
aXRoIFJNUlJzLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQgaG93L3do
ZW4gdGhlIHNwZWNpZmllZAptZW1vcnkgcmVnaW9ucyBtYXkgZ2V0IGFjY2Vz
c2VkLCBtYXkgbm90IGJlIGxlZnQgZGlzY29ubmVjdGVkIGZyb20gdGhlaXIK
cmVzcGVjdGl2ZSBtYXBwaW5ncyAoYXMgbG9uZyBhcyBpdCdzIG5vdCBjZXJ0
YWluIHRoYXQgdGhlIGRldmljZSBoYXMKYmVlbiBmdWxseSBxdWllc2NlZCku
IEhlbmNlIHJhdGhlciB0aGFuIHVubWFwcGluZyB0aGUgb2xkIGNvbnRleHQg
YW5kCnRoZW4gbWFwcGluZyB0aGUgbmV3IG9uZSwgcmUtYXNzaWdubWVudCBu
ZWVkcyB0byBiZSBkb25lIGluIGEgc2luZ2xlCnN0ZXAuCgpUaGlzIGlzIENW
RS0yMDIyLTI2MzU5IC8gcGFydCBvZiBYU0EtNDAwLgoKUmVwb3J0ZWQtYnk6
IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoKU2lt
aWxhcmx5IHF1YXJhbnRpbmluZyBzY3JhdGNoLXBhZ2UgbW9kZSByZWxpZXMg
b24gcGFnZSB0YWJsZXMgdG8gYmUKY29udGludW91c2x5IHdpcmVkIHVwLgoK
VG8gYXZvaWQgY29tcGxpY2F0aW5nIHRoaW5ncyBtb3JlIHRoYW4gbmVjZXNz
YXJ5LCB0cmVhdCBhbGwgZGV2aWNlcwptb3N0bHkgZXF1YWxseSwgaS5lLiBy
ZWdhcmRsZXNzIG9mIHRoZWlyIGFzc29jaWF0aW9uIHdpdGggYW55IFJNUlJz
LiBUaGUKbWFpbiBkaWZmZXJlbmNlIGlzIHdoZW4gaXQgY29tZXMgdG8gdXBk
YXRpbmcgY29udGV4dCBlbnRyaWVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21p
YyB3aGVuIHRoZXJlIGFyZSBSTVJScy4gWWV0IGF0b21pY2l0eSBjYW4gb25s
eSBiZSBhY2hpZXZlZAp3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBv
ZiB3aGljaCB3ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClRoZSBzZWVtaW5n
bHkgY29tcGxpY2F0ZWQgY2hvaWNlIG9mIG5vbi1uZWdhdGl2ZSByZXR1cm4g
dmFsdWVzIGZvcgpkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgpIGlzIHRv
IGxpbWl0IGNvZGUgY2h1cm46IFRoaXMgd2F5IGNhbGxlcnMKcGFzc2luZyBO
VUxMIGZvciBwZGV2IGRvbid0IG5lZWQgZmlkZGxpbmcgd2l0aC4KClNpZ25l
ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2
aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPgpS
ZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp
eC5jb20+Ci0tLQp2NzogUmUtYmFzZS4KdjY6IEFsc28gaW5jbHVkZSBkZXZp
Y2VzIHdpdGggcGhhbnRvbSBmdW5jdGlvbnMgaW4gdGhlIG5vdC1zaW5nbGUt
ZGV2aWNlCiAgICBjaGVjay4gU2hvcnRlbiBCREYgY29tcGFyaXNvbiBpbiBk
b21haW5fY29udGV4dF9tYXBwaW5nKCkuCnY1OiBSZWZ1c2UgcmUtYXNzaWdu
bWVudCBvZiBQQ0kgZGV2aWNlcyBiZWhpbmQgYSBicmlkZ2UgYW5kIHdpdGgg
Uk1SUi4KICAgIFNocmluayBhZGp1c3RtZW50IHRvIGNvbnRleHRfc2V0X2Rv
bWFpbl9pZCgpLiBTa2lwIGFjdHVhbCB3cml0ZSBpbgogICAgZG9tYWluX2Nv
bnRleHRfbWFwcGluZ19vbmUoKSBmb3IgInNhbWUgZG9tYWluIiBjYXNlLiBD
b252ZXJ0CiAgICBhc3NlcnRpbmcgb2YgQ1gxNiBzdWNjZXNzIHRvIGVycm9y
IHJldHVybi4gUHJlZmVyCiAgICBhbnlfcGRldl9iZWhpbmRfaW9tbXUoKSBv
dmVyIGxpc3Rfe2ZpcnN0LGxhc3R9X2VudHJ5X29yX251bGwoKS4KICAgIFJl
ZmluZSB3YXJuaW5nIG1lc3NhZ2UgdGV4dCBhbmQgdXNlIFBDSV9TQkRGMygp
IHRoZXJlLiBVc2UgY29ycmVjdAogICAgZG9tYWluIHRvIGRlY2lkZSB3aGV0
aGVyIHRvIHdhcm4uIE1vdmUgI2RlZmluZS1zIHRvIHZ0ZC5oLgp2NDogVXNl
IGF0b21pYyBjb250ZXh0IGVudHJ5IHVwZGF0ZXMgd2hlbiBwb3NzaWJsZS4g
UmUtYmFzZSBvdmVyIG5ldwogICAgZWFybGllciBwYXRjaC4KdjM6IFVubWFw
IG9uIGVycm9yIHdoZW4gdGhlIGRldmljZSB3YXMgcHJldmlvdXNseSB1bm1h
cHBlZC4KdjI6IE5ldy4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3Z0ZC9leHRlcm4uaAorKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92
dGQvZXh0ZXJuLmgKQEAgLTgxLDcgKzgxLDggQEAgdm9pZCBmcmVlX3BndGFi
bGVfbWFkZHIodTY0IG1hZGRyKTsKIHZvaWQgKm1hcF92dGRfZG9tYWluX3Bh
Z2UodTY0IG1hZGRyKTsKIHZvaWQgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNv
bnN0IHZvaWQgKnZhKTsKIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29u
ZShzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCB2dGRfaW9tbXUgKmlv
bW11LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHU4IGJ1cywg
dTggZGV2Zm4sIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICopOworICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgYnVzLCB1aW50OF90IGRl
dmZuLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0
cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgbW9kZSk7CiBpbnQg
ZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKHN0cnVjdCBkb21haW4gKmRvbWFp
biwgc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUsCiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHU4IGJ1cywgdTggZGV2Zm4pOwogaW50IGNmX2NoZWNr
IGludGVsX2lvbW11X2dldF9yZXNlcnZlZF9kZXZpY2VfbWVtb3J5KApAQCAt
MTAzLDggKzEwNCw4IEBAIGJvb2wgaXNfYXphbGlhX3RsYl9lbmFibGVkKGNv
bnN0IHN0cnVjdAogdm9pZCBwbGF0Zm9ybV9xdWlya3NfaW5pdCh2b2lkKTsK
IHZvaWQgdnRkX29wc19wcmVhbWJsZV9xdWlyayhzdHJ1Y3QgdnRkX2lvbW11
ICppb21tdSk7CiB2b2lkIHZ0ZF9vcHNfcG9zdGFtYmxlX3F1aXJrKHN0cnVj
dCB2dGRfaW9tbXUgKmlvbW11KTsKLWludCBfX211c3RfY2hlY2sgbWVfd2lm
aV9xdWlyayhzdHJ1Y3QgZG9tYWluICpkb21haW4sCi0gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgdTggYnVzLCB1OCBkZXZmbiwgaW50IG1hcCk7
CitpbnQgX19tdXN0X2NoZWNrIG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFp
biAqZG9tYWluLCB1aW50OF90IGJ1cywKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB1aW50OF90IGRldmZuLCB1bnNpZ25lZCBpbnQgbW9kZSk7
CiB2b2lkIHBjaV92dGRfcXVpcmsoY29uc3Qgc3RydWN0IHBjaV9kZXYgKik7
CiB2b2lkIHF1aXJrX2lvbW11X2NhcHMoc3RydWN0IHZ0ZF9pb21tdSAqaW9t
bXUpOwogCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21t
dS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5j
CkBAIC0xMzgsNiArMTM4LDcgQEAgc3RhdGljIGludCBjb250ZXh0X3NldF9k
b21haW5faWQoc3RydWN0CiAgICAgZWxzZQogICAgICAgICBpID0gY29udmVy
dF9kb21pZChpb21tdSwgZC0+ZG9tYWluX2lkKTsKIAorICAgIGNvbnRleHQt
PmhpICY9IH4oKCgxIDw8IERJRF9GSUVMRF9XSURUSCkgLSAxKSA8PCBESURf
SElHSF9PRkZTRVQpOwogICAgIGNvbnRleHQtPmhpIHw9IChpICYgKCgxIDw8
IERJRF9GSUVMRF9XSURUSCkgLSAxKSkgPDwgRElEX0hJR0hfT0ZGU0VUOwog
ICAgIHJldHVybiAwOwogfQpAQCAtMTM2NSwxNSArMTM2NiwyNyBAQCBzdGF0
aWMgdm9pZCBfX2h3ZG9tX2luaXQgY2ZfY2hlY2sgaW50ZWxfCiAgICAgfQog
fQogCisvKgorICogVGhpcyBmdW5jdGlvbiByZXR1cm5zCisgKiAtIGEgbmVn
YXRpdmUgZXJybm8gdmFsdWUgdXBvbiBlcnJvciwKKyAqIC0gemVybyB1cG9u
IHN1Y2Nlc3Mgd2hlbiBwcmV2aW91c2x5IHRoZSBlbnRyeSB3YXMgbm9uLXBy
ZXNlbnQsIG9yIHRoaXMgaXNuJ3QKKyAqICAgdGhlICJtYWluIiByZXF1ZXN0
IGZvciBhIGRldmljZSAocGRldiA9PSBOVUxMKSwgb3IgZm9yIG5vLW9wIHF1
YXJhbnRpbmluZworICogICBhc3NpZ25tZW50cywKKyAqIC0gcG9zaXRpdmUg
KG9uZSkgdXBvbiBzdWNjZXNzIHdoZW4gcHJldmlvdXNseSB0aGUgZW50cnkg
d2FzIHByZXNlbnQgYW5kIHRoaXMKKyAqICAgaXMgdGhlICJtYWluIiByZXF1
ZXN0IGZvciBhIGRldmljZSAocGRldiAhPSBOVUxMKS4KKyAqLwogaW50IGRv
bWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgIHN0cnVjdCBkb21haW4g
KmRvbWFpbiwKICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSwKLSAgICB1
OCBidXMsIHU4IGRldmZuLCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldikK
KyAgICB1aW50OF90IGJ1cywgdWludDhfdCBkZXZmbiwgY29uc3Qgc3RydWN0
IHBjaV9kZXYgKnBkZXYsCisgICAgdW5zaWduZWQgaW50IG1vZGUpCiB7CiAg
ICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZG9tYWlu
KTsKLSAgICBzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4dCwgKmNvbnRl
eHRfZW50cmllczsKKyAgICBzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4
dCwgKmNvbnRleHRfZW50cmllcywgbGN0eHQ7CisgICAgX191aW50MTI4X3Qg
b2xkOwogICAgIHU2NCBtYWRkciwgcGdkX21hZGRyOwotICAgIHUxNiBzZWcg
PSBpb21tdS0+ZHJoZC0+c2VnbWVudDsKKyAgICB1aW50MTZfdCBzZWcgPSBp
b21tdS0+ZHJoZC0+c2VnbWVudCwgcHJldl9kaWQgPSAwOworICAgIHN0cnVj
dCBkb21haW4gKnByZXZfZG9tID0gTlVMTDsKICAgICBpbnQgcmMsIHJldDsK
ICAgICBib29sX3QgZmx1c2hfZGV2X2lvdGxiOwogCkBAIC0xMzg1LDE3ICsx
Mzk4LDMyIEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAg
ICBtYWRkciA9IGJ1c190b19jb250ZXh0X21hZGRyKGlvbW11LCBidXMpOwog
ICAgIGNvbnRleHRfZW50cmllcyA9IChzdHJ1Y3QgY29udGV4dF9lbnRyeSAq
KW1hcF92dGRfZG9tYWluX3BhZ2UobWFkZHIpOwogICAgIGNvbnRleHQgPSAm
Y29udGV4dF9lbnRyaWVzW2RldmZuXTsKKyAgICBvbGQgPSAobGN0eHQgPSAq
Y29udGV4dCkuZnVsbDsKIAotICAgIGlmICggY29udGV4dF9wcmVzZW50KCpj
b250ZXh0KSApCisgICAgaWYgKCBjb250ZXh0X3ByZXNlbnQobGN0eHQpICkK
ICAgICB7Ci0gICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9jayk7Ci0g
ICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShjb250ZXh0X2VudHJpZXMp
OwotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgZG9taWRfdCBkb21pZDsK
KworICAgICAgICBwcmV2X2RpZCA9IGNvbnRleHRfZG9tYWluX2lkKGxjdHh0
KTsKKyAgICAgICAgZG9taWQgPSBkaWRfdG9fZG9tYWluX2lkKGlvbW11LCBw
cmV2X2RpZCk7CisgICAgICAgIGlmICggZG9taWQgPCBET01JRF9GSVJTVF9S
RVNFUlZFRCApCisgICAgICAgICAgICBwcmV2X2RvbSA9IHJjdV9sb2NrX2Rv
bWFpbl9ieV9pZChkb21pZCk7CisgICAgICAgIGVsc2UgaWYgKCBkb21pZCA9
PSBET01JRF9JTyApCisgICAgICAgICAgICBwcmV2X2RvbSA9IHJjdV9sb2Nr
X2RvbWFpbihkb21faW8pOworICAgICAgICBpZiAoICFwcmV2X2RvbSApCisg
ICAgICAgIHsKKyAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZpb21tdS0+bG9j
ayk7CisgICAgICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29udGV4
dF9lbnRyaWVzKTsKKyAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0RFQlVH
IFZURFBSRUZJWCwKKyAgICAgICAgICAgICAgICAgICAgIm5vIGRvbWFpbiBm
b3IgZGlkICV1IChucl9kb20gJXUpXG4iLAorICAgICAgICAgICAgICAgICAg
ICBwcmV2X2RpZCwgY2FwX25kb21zKGlvbW11LT5jYXApKTsKKyAgICAgICAg
ICAgIHJldHVybiAtRVNSQ0g7CisgICAgICAgIH0KICAgICB9CiAKICAgICBp
ZiAoIGlvbW11X2h3ZG9tX3Bhc3N0aHJvdWdoICYmIGlzX2hhcmR3YXJlX2Rv
bWFpbihkb21haW4pICkKICAgICB7Ci0gICAgICAgIGNvbnRleHRfc2V0X3Ry
YW5zbGF0aW9uX3R5cGUoKmNvbnRleHQsIENPTlRFWFRfVFRfUEFTU19USFJV
KTsKKyAgICAgICAgY29udGV4dF9zZXRfdHJhbnNsYXRpb25fdHlwZShsY3R4
dCwgQ09OVEVYVF9UVF9QQVNTX1RIUlUpOwogICAgIH0KICAgICBlbHNlCiAg
ICAgewpAQCAtMTQwNywzNyArMTQzNSwxMDggQEAgaW50IGRvbWFpbl9jb250
ZXh0X21hcHBpbmdfb25lKAogICAgICAgICAgICAgc3Bpbl91bmxvY2soJmhk
LT5hcmNoLm1hcHBpbmdfbG9jayk7CiAgICAgICAgICAgICBzcGluX3VubG9j
aygmaW9tbXUtPmxvY2spOwogICAgICAgICAgICAgdW5tYXBfdnRkX2RvbWFp
bl9wYWdlKGNvbnRleHRfZW50cmllcyk7CisgICAgICAgICAgICBpZiAoIHBy
ZXZfZG9tICkKKyAgICAgICAgICAgICAgICByY3VfdW5sb2NrX2RvbWFpbihw
cmV2X2RvbSk7CiAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKICAgICAg
ICAgfQogCi0gICAgICAgIGNvbnRleHRfc2V0X2FkZHJlc3Nfcm9vdCgqY29u
dGV4dCwgcGdkX21hZGRyKTsKKyAgICAgICAgY29udGV4dF9zZXRfYWRkcmVz
c19yb290KGxjdHh0LCBwZ2RfbWFkZHIpOwogICAgICAgICBpZiAoIGF0c19l
bmFibGVkICYmIGVjYXBfZGV2X2lvdGxiKGlvbW11LT5lY2FwKSApCi0gICAg
ICAgICAgICBjb250ZXh0X3NldF90cmFuc2xhdGlvbl90eXBlKCpjb250ZXh0
LCBDT05URVhUX1RUX0RFVl9JT1RMQik7CisgICAgICAgICAgICBjb250ZXh0
X3NldF90cmFuc2xhdGlvbl90eXBlKGxjdHh0LCBDT05URVhUX1RUX0RFVl9J
T1RMQik7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIGNvbnRleHRfc2V0
X3RyYW5zbGF0aW9uX3R5cGUoKmNvbnRleHQsIENPTlRFWFRfVFRfTVVMVElf
TEVWRUwpOworICAgICAgICAgICAgY29udGV4dF9zZXRfdHJhbnNsYXRpb25f
dHlwZShsY3R4dCwgQ09OVEVYVF9UVF9NVUxUSV9MRVZFTCk7CiAKICAgICAg
ICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAgICAg
fQogCi0gICAgcmMgPSBjb250ZXh0X3NldF9kb21haW5faWQoY29udGV4dCwg
ZG9tYWluLCBpb21tdSk7CisgICAgcmMgPSBjb250ZXh0X3NldF9kb21haW5f
aWQoJmxjdHh0LCBkb21haW4sIGlvbW11KTsKICAgICBpZiAoIHJjICkKICAg
ICB7CisgICAgdW5sb2NrOgogICAgICAgICBzcGluX3VubG9jaygmaW9tbXUt
PmxvY2spOwogICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29udGV4
dF9lbnRyaWVzKTsKKyAgICAgICAgaWYgKCBwcmV2X2RvbSApCisgICAgICAg
ICAgICByY3VfdW5sb2NrX2RvbWFpbihwcmV2X2RvbSk7CiAgICAgICAgIHJl
dHVybiByYzsKICAgICB9CiAKLSAgICBjb250ZXh0X3NldF9hZGRyZXNzX3dp
ZHRoKCpjb250ZXh0LCBsZXZlbF90b19hZ2F3KGlvbW11LT5ucl9wdF9sZXZl
bHMpKTsKLSAgICBjb250ZXh0X3NldF9mYXVsdF9lbmFibGUoKmNvbnRleHQp
OwotICAgIGNvbnRleHRfc2V0X3ByZXNlbnQoKmNvbnRleHQpOworICAgIGlm
ICggIXByZXZfZG9tICkKKyAgICB7CisgICAgICAgIGNvbnRleHRfc2V0X2Fk
ZHJlc3Nfd2lkdGgobGN0eHQsIGxldmVsX3RvX2FnYXcoaW9tbXUtPm5yX3B0
X2xldmVscykpOworICAgICAgICBjb250ZXh0X3NldF9mYXVsdF9lbmFibGUo
bGN0eHQpOworICAgICAgICBjb250ZXh0X3NldF9wcmVzZW50KGxjdHh0KTsK
KyAgICB9CisgICAgZWxzZSBpZiAoIHByZXZfZG9tID09IGRvbWFpbiApCisg
ICAgeworICAgICAgICBBU1NFUlQobGN0eHQuZnVsbCA9PSBjb250ZXh0LT5m
dWxsKTsKKyAgICAgICAgcmMgPSAhIXBkZXY7CisgICAgICAgIGdvdG8gdW5s
b2NrOworICAgIH0KKyAgICBlbHNlCisgICAgeworICAgICAgICBBU1NFUlQo
Y29udGV4dF9hZGRyZXNzX3dpZHRoKGxjdHh0KSA9PQorICAgICAgICAgICAg
ICAgbGV2ZWxfdG9fYWdhdyhpb21tdS0+bnJfcHRfbGV2ZWxzKSk7CisgICAg
ICAgIEFTU0VSVCghY29udGV4dF9mYXVsdF9kaXNhYmxlKGxjdHh0KSk7Cisg
ICAgfQorCisgICAgaWYgKCBjcHVfaGFzX2N4MTYgKQorICAgIHsKKyAgICAg
ICAgX191aW50MTI4X3QgcmVzID0gY21weGNoZzE2Yihjb250ZXh0LCAmb2xk
LCAmbGN0eHQuZnVsbCk7CisKKyAgICAgICAgLyoKKyAgICAgICAgICogSGFy
ZHdhcmUgZG9lcyBub3QgdXBkYXRlIHRoZSBjb250ZXh0IGVudHJ5IGJlaGlu
ZCBvdXIgYmFja3MsCisgICAgICAgICAqIHNvIHRoZSByZXR1cm4gdmFsdWUg
c2hvdWxkIG1hdGNoICJvbGQiLgorICAgICAgICAgKi8KKyAgICAgICAgaWYg
KCByZXMgIT0gb2xkICkKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKCBw
ZGV2ICkKKyAgICAgICAgICAgICAgICBjaGVja19jbGVhbnVwX2RvbWlkX21h
cChkb21haW4sIHBkZXYsIGlvbW11KTsKKyAgICAgICAgICAgIHByaW50ayhY
RU5MT0dfRVJSCisgICAgICAgICAgICAgICAgICAgIiVwcDogdW5leHBlY3Rl
ZCBjb250ZXh0IGVudHJ5ICUwMTZseF8lMDE2bHggKGV4cGVjdGVkICUwMTZs
eF8lMDE2bHgpXG4iLAorICAgICAgICAgICAgICAgICAgICZQQ0lfU0JERjMo
cGRldi0+c2VnLCBwZGV2LT5idXMsIGRldmZuKSwKKyAgICAgICAgICAgICAg
ICAgICAodWludDY0X3QpKHJlcyA+PiA2NCksICh1aW50NjRfdClyZXMsCisg
ICAgICAgICAgICAgICAgICAgKHVpbnQ2NF90KShvbGQgPj4gNjQpLCAodWlu
dDY0X3Qpb2xkKTsKKyAgICAgICAgICAgIHJjID0gLUVJTFNFUTsKKyAgICAg
ICAgICAgIGdvdG8gdW5sb2NrOworICAgICAgICB9CisgICAgfQorICAgIGVs
c2UgaWYgKCAhcHJldl9kb20gfHwgIShtb2RlICYgTUFQX1dJVEhfUk1SUikg
KQorICAgIHsKKyAgICAgICAgY29udGV4dF9jbGVhcl9wcmVzZW50KCpjb250
ZXh0KTsKKyAgICAgICAgaW9tbXVfc3luY19jYWNoZShjb250ZXh0LCBzaXpl
b2YoKmNvbnRleHQpKTsKKworICAgICAgICB3cml0ZV9hdG9taWMoJmNvbnRl
eHQtPmhpLCBsY3R4dC5oaSk7CisgICAgICAgIC8qIE5vIGJhcnJpZXIgc2hv
dWxkIGJlIG5lZWRlZCBiZXR3ZWVuIHRoZXNlIHR3by4gKi8KKyAgICAgICAg
d3JpdGVfYXRvbWljKCZjb250ZXh0LT5sbywgbGN0eHQubG8pOworICAgIH0K
KyAgICBlbHNlIC8qIEJlc3QgZWZmb3J0LCB1cGRhdGluZyBESUQgbGFzdC4g
Ki8KKyAgICB7CisgICAgICAgICAvKgorICAgICAgICAgICogQnkgbm9uLWF0
b21pY2FsbHkgdXBkYXRpbmcgdGhlIGNvbnRleHQgZW50cnkncyBESUQgZmll
bGQgbGFzdCwKKyAgICAgICAgICAqIGR1cmluZyBhIHNob3J0IHdpbmRvdyBp
biB0aW1lIFRMQiBlbnRyaWVzIHdpdGggdGhlIG9sZCBkb21haW4gSUQKKyAg
ICAgICAgICAqIGJ1dCB0aGUgbmV3IHBhZ2UgdGFibGVzIG1heSBiZSBpbnNl
cnRlZC4gIFRoaXMgY291bGQgYWZmZWN0IEkvTworICAgICAgICAgICogb2Yg
b3RoZXIgZGV2aWNlcyB1c2luZyB0aGlzIHNhbWUgKG9sZCkgZG9tYWluIElE
LiAgU3VjaCB1cGRhdGluZworICAgICAgICAgICogdGhlcmVmb3JlIGlzIG5v
dCBhIHByb2JsZW0gaWYgdGhpcyB3YXMgdGhlIG9ubHkgZGV2aWNlIGFzc29j
aWF0ZWQKKyAgICAgICAgICAqIHdpdGggdGhlIG9sZCBkb21haW4gSUQuICBE
aXZlcnRpbmcgSS9PIG9mIGFueSBvZiBhIGR5aW5nIGRvbWFpbidzCisgICAg
ICAgICAgKiBkZXZpY2VzIHRvIHRoZSBxdWFyYW50aW5lIHBhZ2UgdGFibGVz
IGlzIGludGVuZGVkIGFueXdheS4KKyAgICAgICAgICAqLworICAgICAgICBp
ZiAoICEobW9kZSAmIChNQVBfT1dORVJfRFlJTkcgfCBNQVBfU0lOR0xFX0RF
VklDRSkpICkKKyAgICAgICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORyBW
VERQUkVGSVgKKyAgICAgICAgICAgICAgICAgICAiICVwcDogcmVhc3NpZ25t
ZW50IG1heSBjYXVzZSAlcGQgZGF0YSBjb3JydXB0aW9uXG4iLAorICAgICAg
ICAgICAgICAgICAgICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSwgcHJl
dl9kb20pOworCisgICAgICAgIHdyaXRlX2F0b21pYygmY29udGV4dC0+bG8s
IGxjdHh0LmxvKTsKKyAgICAgICAgLyogTm8gYmFycmllciBzaG91bGQgYmUg
bmVlZGVkIGJldHdlZW4gdGhlc2UgdHdvLiAqLworICAgICAgICB3cml0ZV9h
dG9taWMoJmNvbnRleHQtPmhpLCBsY3R4dC5oaSk7CisgICAgfQorCiAgICAg
aW9tbXVfc3luY19jYWNoZShjb250ZXh0LCBzaXplb2Yoc3RydWN0IGNvbnRl
eHRfZW50cnkpKTsKICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxvY2spOwog
Ci0gICAgLyogQ29udGV4dCBlbnRyeSB3YXMgcHJldmlvdXNseSBub24tcHJl
c2VudCAod2l0aCBkb21pZCAwKS4gKi8KLSAgICByYyA9IGlvbW11X2ZsdXNo
X2NvbnRleHRfZGV2aWNlKGlvbW11LCAwLCBQQ0lfQkRGMihidXMsIGRldmZu
KSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERNQV9D
Q01EX01BU0tfTk9CSVQsIDEpOworICAgIHJjID0gaW9tbXVfZmx1c2hfY29u
dGV4dF9kZXZpY2UoaW9tbXUsIHByZXZfZGlkLCBQQ0lfQkRGMihidXMsIGRl
dmZuKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERN
QV9DQ01EX01BU0tfTk9CSVQsICFwcmV2X2RvbSk7CiAgICAgZmx1c2hfZGV2
X2lvdGxiID0gISFmaW5kX2F0c19kZXZfZHJoZChpb21tdSk7Ci0gICAgcmV0
ID0gaW9tbXVfZmx1c2hfaW90bGJfZHNpKGlvbW11LCAwLCAxLCBmbHVzaF9k
ZXZfaW90bGIpOworICAgIHJldCA9IGlvbW11X2ZsdXNoX2lvdGxiX2RzaShp
b21tdSwgcHJldl9kaWQsICFwcmV2X2RvbSwgZmx1c2hfZGV2X2lvdGxiKTsK
IAogICAgIC8qCiAgICAgICogVGhlIGN1cnJlbnQgbG9naWMgZm9yIHJldHVy
bnM6CkBAIC0xNDU4LDE3ICsxNTU3LDI2IEBAIGludCBkb21haW5fY29udGV4
dF9tYXBwaW5nX29uZSgKICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29u
dGV4dF9lbnRyaWVzKTsKIAogICAgIGlmICggIXNlZyAmJiAhcmMgKQotICAg
ICAgICByYyA9IG1lX3dpZmlfcXVpcmsoZG9tYWluLCBidXMsIGRldmZuLCBN
QVBfTUVfUEhBTlRPTV9GVU5DKTsKKyAgICAgICAgcmMgPSBtZV93aWZpX3F1
aXJrKGRvbWFpbiwgYnVzLCBkZXZmbiwgbW9kZSk7CiAKICAgICBpZiAoIHJj
ICkKICAgICB7Ci0gICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFw
X29uZShkb21haW4sIGlvbW11LCBidXMsIGRldmZuKTsKKyAgICAgICAgaWYg
KCAhcHJldl9kb20gKQorICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRl
eHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOworICAg
ICAgICBlbHNlIGlmICggcHJldl9kb20gIT0gZG9tYWluICkgLyogQXZvaWQg
aW5maW5pdGUgcmVjdXJzaW9uLiAqLworICAgICAgICAgICAgcmV0ID0gZG9t
YWluX2NvbnRleHRfbWFwcGluZ19vbmUocHJldl9kb20sIGlvbW11LCBidXMs
IGRldmZuLCBwZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgbW9kZSAmIE1BUF9XSVRIX1JNUlIpIDwgMDsKKyAg
ICAgICAgZWxzZQorICAgICAgICAgICAgcmV0ID0gMTsKIAogICAgICAgICBp
ZiAoICFyZXQgJiYgcGRldiAmJiBwZGV2LT5kZXZmbiA9PSBkZXZmbiApCiAg
ICAgICAgICAgICBjaGVja19jbGVhbnVwX2RvbWlkX21hcChkb21haW4sIHBk
ZXYsIGlvbW11KTsKICAgICB9CiAKLSAgICByZXR1cm4gcmM7CisgICAgaWYg
KCBwcmV2X2RvbSApCisgICAgICAgIHJjdV91bmxvY2tfZG9tYWluKHByZXZf
ZG9tKTsKKworICAgIHJldHVybiByYyA/OiBwZGV2ICYmIHByZXZfZG9tOwog
fQogCiBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X3VubWFwKHN0cnVjdCBk
b21haW4gKmQsIHVpbnQ4X3QgZGV2Zm4sCkBAIC0xNDc4LDggKzE1ODYsMTAg
QEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lf
ZGV2ICpwZGV2KQogewogICAgIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5p
dCAqZHJoZCA9IGFjcGlfZmluZF9tYXRjaGVkX2RyaGRfdW5pdChwZGV2KTsK
KyAgICBjb25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CiAgICAg
aW50IHJldCA9IDA7Ci0gICAgdWludDE2X3Qgc2VnID0gcGRldi0+c2VnOwor
ICAgIHVuc2lnbmVkIGludCBpLCBtb2RlID0gMDsKKyAgICB1aW50MTZfdCBz
ZWcgPSBwZGV2LT5zZWcsIGJkZjsKICAgICB1aW50OF90IGJ1cyA9IHBkZXYt
PmJ1cywgc2VjYnVzOwogCiAgICAgLyoKQEAgLTE0OTUsOCArMTYwNSwyOSBA
QCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAK
ICAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CiAKKyAgICBmb3JfZWFj
aF9ybXJyX2RldmljZSggcm1yciwgYmRmLCBpICkKKyAgICB7CisgICAgICAg
IGlmICggcm1yci0+c2VnbWVudCAhPSBwZGV2LT5zZWcgfHwgYmRmICE9IHBk
ZXYtPnNiZGYuYmRmICkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAg
ICAgIG1vZGUgfD0gTUFQX1dJVEhfUk1SUjsKKyAgICAgICAgYnJlYWs7Cisg
ICAgfQorCisgICAgaWYgKCBkb21haW4gIT0gcGRldi0+ZG9tYWluICkKKyAg
ICB7CisgICAgICAgIGlmICggcGRldi0+ZG9tYWluLT5pc19keWluZyApCisg
ICAgICAgICAgICBtb2RlIHw9IE1BUF9PV05FUl9EWUlORzsKKyAgICAgICAg
ZWxzZSBpZiAoIGRyaGQgJiYKKyAgICAgICAgICAgICAgICAgICFhbnlfcGRl
dl9iZWhpbmRfaW9tbXUocGRldi0+ZG9tYWluLCBwZGV2LCBkcmhkLT5pb21t
dSkgJiYKKyAgICAgICAgICAgICAgICAgICFwZGV2LT5waGFudG9tX3N0cmlk
ZSApCisgICAgICAgICAgICBtb2RlIHw9IE1BUF9TSU5HTEVfREVWSUNFOwor
ICAgIH0KKwogICAgIHN3aXRjaCAoIHBkZXYtPnR5cGUgKQogICAgIHsKKyAg
ICAgICAgYm9vbCBwcmV2X3ByZXNlbnQ7CisKICAgICBjYXNlIERFVl9UWVBF
X1BDSV9IT1NUX0JSSURHRToKICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyAp
CiAgICAgICAgICAgICBwcmludGsoVlREUFJFRklYICIlcGQ6SG9zdGJyaWRn
ZTogc2tpcCAlcHAgbWFwXG4iLApAQCAtMTUxOCw3ICsxNjQ5LDkgQEAgc3Rh
dGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0cnVjdAogICAgICAg
ICAgICAgcHJpbnRrKFZURFBSRUZJWCAiJXBkOlBDSWU6IG1hcCAlcHBcbiIs
CiAgICAgICAgICAgICAgICAgICAgZG9tYWluLCAmUENJX1NCREYzKHNlZywg
YnVzLCBkZXZmbikpOwogICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9t
YXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCBidXMsIGRldmZuLAot
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2
KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
cGRldiwgbW9kZSk7CisgICAgICAgIGlmICggcmV0ID4gMCApCisgICAgICAg
ICAgICByZXQgPSAwOwogICAgICAgICBpZiAoICFyZXQgJiYgZGV2Zm4gPT0g
cGRldi0+ZGV2Zm4gJiYgYXRzX2RldmljZShwZGV2LCBkcmhkKSA+IDAgKQog
ICAgICAgICAgICAgZW5hYmxlX2F0c19kZXZpY2UocGRldiwgJmRyaGQtPmlv
bW11LT5hdHNfZGV2aWNlcyk7CiAKQEAgLTE1MzMsOSArMTY2NiwxMCBAQCBz
dGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAg
ICAgICAgICAgICAgICAgZG9tYWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBk
ZXZmbikpOwogCiAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYpOwot
ICAgICAgICBpZiAoIHJldCApCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHBkZXYsIG1vZGUpOworICAgICAgICBpZiAoIHJl
dCA8IDAgKQogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIHByZXZfcHJl
c2VudCA9IHJldDsKIAogICAgICAgICBpZiAoIChyZXQgPSBmaW5kX3Vwc3Ry
ZWFtX2JyaWRnZShzZWcsICZidXMsICZkZXZmbiwgJnNlY2J1cykpIDwgMSAp
CiAgICAgICAgIHsKQEAgLTE1NDMsNiArMTY3NywxNSBAQCBzdGF0aWMgaW50
IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgICAgICAg
ICAgYnJlYWs7CiAgICAgICAgICAgICByZXQgPSAtRU5YSU87CiAgICAgICAg
IH0KKyAgICAgICAgLyoKKyAgICAgICAgICogU3RyaWN0bHkgc3BlYWtpbmcg
aWYgdGhlIGRldmljZSBpcyB0aGUgb25seSBvbmUgYmVoaW5kIHRoaXMgYnJp
ZGdlCisgICAgICAgICAqIGFuZCB0aGUgb25seSBvbmUgd2l0aCB0aGlzIChz
ZWNidXMsMCwwKSB0dXBsZSwgaXQgY291bGQgYmUgYWxsb3dlZAorICAgICAg
ICAgKiB0byBiZSByZS1hc3NpZ25lZCByZWdhcmRsZXNzIG9mIFJNUlIgcHJl
c2VuY2UuICBCdXQgbGV0J3MgZGVhbCB3aXRoCisgICAgICAgICAqIHRoYXQg
Y2FzZSBvbmx5IGlmIGl0IGlzIGFjdHVhbGx5IGZvdW5kIGluIHRoZSB3aWxk
LgorICAgICAgICAgKi8KKyAgICAgICAgZWxzZSBpZiAoIHByZXZfcHJlc2Vu
dCAmJiAobW9kZSAmIE1BUF9XSVRIX1JNUlIpICYmCisgICAgICAgICAgICAg
ICAgICBkb21haW4gIT0gcGRldi0+ZG9tYWluICkKKyAgICAgICAgICAgIHJl
dCA9IC1FT1BOT1RTVVBQOwogCiAgICAgICAgIC8qCiAgICAgICAgICAqIE1h
cHBpbmcgYSBicmlkZ2Ugc2hvdWxkLCBpZiBhbnl0aGluZywgcGFzcyB0aGUg
c3RydWN0IHBjaV9kZXYgb2YKQEAgLTE1NTEsNyArMTY5NCw3IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAg
ICovCiAgICAgICAgIGlmICggcmV0ID49IDAgKQogICAgICAgICAgICAgcmV0
ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5p
b21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIE5VTEwpOworICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgbW9kZSk7CiAKICAg
ICAgICAgLyoKICAgICAgICAgICogRGV2aWNlcyBiZWhpbmQgUENJZS10by1Q
Q0kvUENJeCBicmlkZ2UgbWF5IGdlbmVyYXRlIGRpZmZlcmVudApAQCAtMTU2
NiwxMCArMTcwOSwxNSBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21h
cHBpbmcoc3RydWN0CiAgICAgICAgIGlmICggIXJldCAmJiBwZGV2X3R5cGUo
c2VnLCBidXMsIGRldmZuKSA9PSBERVZfVFlQRV9QQ0llMlBDSV9CUklER0Ug
JiYKICAgICAgICAgICAgICAoc2VjYnVzICE9IHBkZXYtPmJ1cyB8fCBwZGV2
LT5kZXZmbiAhPSAwKSApCiAgICAgICAgICAgICByZXQgPSBkb21haW5fY29u
dGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlvbW11LCBzZWNidXMs
IDAsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBOVUxMKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIE5VTEwsIG1vZGUpOwogCiAgICAgICAgIGlmICggcmV0
ICkKLSAgICAgICAgICAgIGRvbWFpbl9jb250ZXh0X3VubWFwKGRvbWFpbiwg
ZGV2Zm4sIHBkZXYpOworICAgICAgICB7CisgICAgICAgICAgICBpZiAoICFw
cmV2X3ByZXNlbnQgKQorICAgICAgICAgICAgICAgIGRvbWFpbl9jb250ZXh0
X3VubWFwKGRvbWFpbiwgZGV2Zm4sIHBkZXYpOworICAgICAgICAgICAgZWxz
ZSBpZiAoIHBkZXYtPmRvbWFpbiAhPSBkb21haW4gKSAvKiBBdm9pZCBpbmZp
bml0ZSByZWN1cnNpb24uICovCisgICAgICAgICAgICAgICAgZG9tYWluX2Nv
bnRleHRfbWFwcGluZyhwZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKKyAg
ICAgICAgfQogCiAgICAgICAgIGJyZWFrOwogCkBAIC0yMzU4LDkgKzI1MDYs
NDcgQEAgc3RhdGljIGludCBjZl9jaGVjayByZWFzc2lnbl9kZXZpY2Vfb3du
ZQogewogICAgIGludCByZXQ7CiAKLSAgICByZXQgPSBkb21haW5fY29udGV4
dF91bm1hcChzb3VyY2UsIGRldmZuLCBwZGV2KTsKKyAgICBpZiAoICFRVUFS
QU5USU5FX1NLSVAodGFyZ2V0KSApCisgICAgeworICAgICAgICBpZiAoICFo
YXNfYXJjaF9wZGV2cyh0YXJnZXQpICkKKyAgICAgICAgICAgIHZteF9waV9o
b29rc19hc3NpZ24odGFyZ2V0KTsKKworICAgICAgICAvKgorICAgICAgICAg
KiBEZXZpY2VzIGFzc2lnbmVkIHRvIHVudHJ1c3RlZCBkb21haW5zIChoZXJl
IGFzc3VtZWQgdG8gYmUgYW55IGRvbVUpCisgICAgICAgICAqIGNhbiBhdHRl
bXB0IHRvIHNlbmQgYXJiaXRyYXJ5IExBUElDL01TSSBtZXNzYWdlcy4gV2Ug
YXJlIHVucHJvdGVjdGVkCisgICAgICAgICAqIGJ5IHRoZSByb290IGNvbXBs
ZXggdW5sZXNzIGludGVycnVwdCByZW1hcHBpbmcgaXMgZW5hYmxlZC4KKyAg
ICAgICAgICovCisgICAgICAgIGlmICggIWlvbW11X2ludHJlbWFwICYmICFp
c19oYXJkd2FyZV9kb21haW4odGFyZ2V0KSAmJgorICAgICAgICAgICAgICFp
c19zeXN0ZW1fZG9tYWluKHRhcmdldCkgKQorICAgICAgICAgICAgdW50cnVz
dGVkX21zaSA9IHRydWU7CisKKyAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRl
eHRfbWFwcGluZyh0YXJnZXQsIGRldmZuLCBwZGV2KTsKKworICAgICAgICBp
ZiAoICFyZXQgJiYgIVFVQVJBTlRJTkVfU0tJUChzb3VyY2UpICYmIHBkZXYt
PmRldmZuID09IGRldmZuICkKKyAgICAgICAgeworICAgICAgICAgICAgY29u
c3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkID0gYWNwaV9maW5kX21h
dGNoZWRfZHJoZF91bml0KHBkZXYpOworCisgICAgICAgICAgICBpZiAoIGRy
aGQgKQorICAgICAgICAgICAgICAgIGNoZWNrX2NsZWFudXBfZG9taWRfbWFw
KHNvdXJjZSwgcGRldiwgZHJoZC0+aW9tbXUpOworICAgICAgICB9CisgICAg
fQorICAgIGVsc2UKKyAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5t
YXAoc291cmNlLCBkZXZmbiwgcGRldik7CiAgICAgaWYgKCByZXQgKQorICAg
IHsKKyAgICAgICAgaWYgKCAhaGFzX2FyY2hfcGRldnModGFyZ2V0KSApCisg
ICAgICAgICAgICB2bXhfcGlfaG9va3NfZGVhc3NpZ24odGFyZ2V0KTsKICAg
ICAgICAgcmV0dXJuIHJldDsKKyAgICB9CisKKyAgICBpZiAoIGRldmZuID09
IHBkZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSB0YXJnZXQgKQorICAg
IHsKKyAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlzdCwgJnRh
cmdldC0+cGRldl9saXN0KTsKKyAgICAgICAgcGRldi0+ZG9tYWluID0gdGFy
Z2V0OworICAgIH0KKworICAgIGlmICggIWhhc19hcmNoX3BkZXZzKHNvdXJj
ZSkgKQorICAgICAgICB2bXhfcGlfaG9va3NfZGVhc3NpZ24oc291cmNlKTsK
IAogICAgIC8qCiAgICAgICogSWYgdGhlIGRldmljZSBiZWxvbmdzIHRvIHRo
ZSBoYXJkd2FyZSBkb21haW4sIGFuZCBpdCBoYXMgUk1SUiwgZG9uJ3QKQEAg
LTIzOTAsNDMgKzI1NzYsNyBAQCBzdGF0aWMgaW50IGNmX2NoZWNrIHJlYXNz
aWduX2RldmljZV9vd25lCiAgICAgICAgICAgICB9CiAgICAgfQogCi0gICAg
aWYgKCBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21haW4gIT0g
ZG9tX2lvICkKLSAgICB7Ci0gICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9t
YWluX2xpc3QsICZkb21faW8tPnBkZXZfbGlzdCk7Ci0gICAgICAgIHBkZXYt
PmRvbWFpbiA9IGRvbV9pbzsKLSAgICB9Ci0KLSAgICBpZiAoICFoYXNfYXJj
aF9wZGV2cyhzb3VyY2UpICkKLSAgICAgICAgdm14X3BpX2hvb2tzX2RlYXNz
aWduKHNvdXJjZSk7Ci0KLSAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyh0YXJn
ZXQpICkKLSAgICAgICAgdm14X3BpX2hvb2tzX2Fzc2lnbih0YXJnZXQpOwot
Ci0gICAgLyoKLSAgICAgKiBEZXZpY2VzIGFzc2lnbmVkIHRvIHVudHJ1c3Rl
ZCBkb21haW5zIChoZXJlIGFzc3VtZWQgdG8gYmUgYW55IGRvbVUpCi0gICAg
ICogY2FuIGF0dGVtcHQgdG8gc2VuZCBhcmJpdHJhcnkgTEFQSUMvTVNJIG1l
c3NhZ2VzLiBXZSBhcmUgdW5wcm90ZWN0ZWQKLSAgICAgKiBieSB0aGUgcm9v
dCBjb21wbGV4IHVubGVzcyBpbnRlcnJ1cHQgcmVtYXBwaW5nIGlzIGVuYWJs
ZWQuCi0gICAgICovCi0gICAgaWYgKCAhaW9tbXVfaW50cmVtYXAgJiYgIWlz
X2hhcmR3YXJlX2RvbWFpbih0YXJnZXQpICYmCi0gICAgICAgICAhaXNfc3lz
dGVtX2RvbWFpbih0YXJnZXQpICkKLSAgICAgICAgdW50cnVzdGVkX21zaSA9
IHRydWU7Ci0KLSAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nKHRh
cmdldCwgZGV2Zm4sIHBkZXYpOwotICAgIGlmICggcmV0ICkKLSAgICB7Ci0g
ICAgICAgIGlmICggIWhhc19hcmNoX3BkZXZzKHRhcmdldCkgKQotICAgICAg
ICAgICAgdm14X3BpX2hvb2tzX2RlYXNzaWduKHRhcmdldCk7Ci0KLSAgICAg
ICAgcmV0dXJuIHJldDsKLSAgICB9Ci0KLSAgICBpZiAoIGRldmZuID09IHBk
ZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSB0YXJnZXQgKQotICAgIHsK
LSAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlzdCwgJnRhcmdl
dC0+cGRldl9saXN0KTsKLSAgICAgICAgcGRldi0+ZG9tYWluID0gdGFyZ2V0
OwotICAgIH0KLQotICAgIHJldHVybiByZXQ7CisgICAgcmV0dXJuIDA7CiB9
CiAKIHN0YXRpYyBpbnQgY2ZfY2hlY2sgaW50ZWxfaW9tbXVfYXNzaWduX2Rl
dmljZSgKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgK
QEAgLTE5Nyw4ICsxOTcsMTIgQEAgc3RydWN0IHJvb3RfZW50cnkgewogICAg
IGRvIHsocm9vdCkudmFsIHw9ICgodmFsdWUpICYgUEFHRV9NQVNLXzRLKTt9
IHdoaWxlKDApCiAKIHN0cnVjdCBjb250ZXh0X2VudHJ5IHsKLSAgICB1NjQg
bG87Ci0gICAgdTY0IGhpOworICAgIHVuaW9uIHsKKyAgICAgICAgc3RydWN0
IHsKKyAgICAgICAgICAgIHVpbnQ2NF90IGxvLCBoaTsKKyAgICAgICAgfTsK
KyAgICAgICAgX191aW50MTI4X3QgZnVsbDsKKyAgICB9OwogfTsKICNkZWZp
bmUgUk9PVF9FTlRSWV9OUiAoUEFHRV9TSVpFXzRLL3NpemVvZihzdHJ1Y3Qg
cm9vdF9lbnRyeSkpCiAjZGVmaW5lIGNvbnRleHRfcHJlc2VudChjKSAoKGMp
LmxvICYgMSkKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL3F1
aXJrcy5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xdWly
a3MuYwpAQCAtNDA3LDcgKzQwNyw4IEBAIHZvaWQgX19pbml0IHBsYXRmb3Jt
X3F1aXJrc19pbml0KHZvaWQpCiAgKi8KIAogc3RhdGljIGludCBfX211c3Rf
Y2hlY2sgbWFwX21lX3BoYW50b21fZnVuY3Rpb24oc3RydWN0IGRvbWFpbiAq
ZG9tYWluLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgdTMyIGRldiwgaW50IG1hcCkKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu
dCBkZXYsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB1bnNpZ25lZCBpbnQgbW9kZSkKIHsKICAgICBzdHJ1Y3Qg
YWNwaV9kcmhkX3VuaXQgKmRyaGQ7CiAgICAgc3RydWN0IHBjaV9kZXYgKnBk
ZXY7CkBAIC00MTgsOSArNDE5LDkgQEAgc3RhdGljIGludCBfX211c3RfY2hl
Y2sgbWFwX21lX3BoYW50b21fZgogICAgIGRyaGQgPSBhY3BpX2ZpbmRfbWF0
Y2hlZF9kcmhkX3VuaXQocGRldik7CiAKICAgICAvKiBtYXAgb3IgdW5tYXAg
TUUgcGhhbnRvbSBmdW5jdGlvbiAqLwotICAgIGlmICggbWFwICkKKyAgICBp
ZiAoICEobW9kZSAmIFVOTUFQX01FX1BIQU5UT01fRlVOQykgKQogICAgICAg
ICByYyA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJo
ZC0+aW9tbXUsIDAsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgUENJX0RFVkZOKGRldiwgNyksIE5VTEwpOworICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihkZXYs
IDcpLCBOVUxMLCBtb2RlKTsKICAgICBlbHNlCiAgICAgICAgIHJjID0gZG9t
YWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIDAs
CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9E
RVZGTihkZXYsIDcpKTsKQEAgLTQyOCw3ICs0MjksOCBAQCBzdGF0aWMgaW50
IF9fbXVzdF9jaGVjayBtYXBfbWVfcGhhbnRvbV9mCiAgICAgcmV0dXJuIHJj
OwogfQogCi1pbnQgbWVfd2lmaV9xdWlyayhzdHJ1Y3QgZG9tYWluICpkb21h
aW4sIHU4IGJ1cywgdTggZGV2Zm4sIGludCBtYXApCitpbnQgbWVfd2lmaV9x
dWlyayhzdHJ1Y3QgZG9tYWluICpkb21haW4sIHVpbnQ4X3QgYnVzLCB1aW50
OF90IGRldmZuLAorICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG1v
ZGUpCiB7CiAgICAgdTMyIGlkOwogICAgIGludCByYyA9IDA7CkBAIC00NTIs
NyArNDU0LDcgQEAgaW50IG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAq
ZG9tYWluLAogICAgICAgICAgICAgY2FzZSAweDQyM2I4MDg2OgogICAgICAg
ICAgICAgY2FzZSAweDQyM2M4MDg2OgogICAgICAgICAgICAgY2FzZSAweDQy
M2Q4MDg2OgotICAgICAgICAgICAgICAgIHJjID0gbWFwX21lX3BoYW50b21f
ZnVuY3Rpb24oZG9tYWluLCAzLCBtYXApOworICAgICAgICAgICAgICAgIHJj
ID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWluLCAzLCBtb2RlKTsK
ICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGRlZmF1bHQ6
CiAgICAgICAgICAgICAgICAgYnJlYWs7CkBAIC00NzgsNyArNDgwLDcgQEAg
aW50IG1lX3dpZmlfcXVpcmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLAogICAg
ICAgICAgICAgY2FzZSAweDQyMzg4MDg2OiAgICAgICAgLyogUHVtYSBQZWFr
ICovCiAgICAgICAgICAgICBjYXNlIDB4NDIyYjgwODY6CiAgICAgICAgICAg
ICBjYXNlIDB4NDIyYzgwODY6Ci0gICAgICAgICAgICAgICAgcmMgPSBtYXBf
bWVfcGhhbnRvbV9mdW5jdGlvbihkb21haW4sIDIyLCBtYXApOworICAgICAg
ICAgICAgICAgIHJjID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWlu
LCAyMiwgbW9kZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg
ICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIGJyZWFrOwotLS0gYS94
ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvdnRkLmgKKysrIGIveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvdnRkL3Z0ZC5oCkBAIC0yMiw4ICsyMiwxNCBA
QAogCiAjaW5jbHVkZSA8eGVuL2lvbW11Lmg+CiAKLSNkZWZpbmUgTUFQX01F
X1BIQU5UT01fRlVOQyAgICAgIDEKLSNkZWZpbmUgVU5NQVBfTUVfUEhBTlRP
TV9GVU5DICAgIDAKKy8qCisgKiBWYWx1ZXMgZm9yIGRvbWFpbl9jb250ZXh0
X21hcHBpbmdfb25lKCkncyBhbmQgbWVfd2lmaV9xdWlyaygpJ3MgIm1vZGUi
CisgKiBwYXJhbWV0ZXJzLgorICovCisjZGVmaW5lIE1BUF9XSVRIX1JNUlIg
ICAgICAgICAoMXUgPDwgMCkKKyNkZWZpbmUgTUFQX09XTkVSX0RZSU5HICAg
ICAgICgxdSA8PCAxKQorI2RlZmluZSBNQVBfU0lOR0xFX0RFVklDRSAgICAg
KDF1IDw8IDIpCisjZGVmaW5lIFVOTUFQX01FX1BIQU5UT01fRlVOQyAoMXUg
PDwgMykKIAogLyogQWxsb3cgZm9yIGJvdGggSU9BUElDIGFuZCBJT1NBUElD
LiAqLwogI2RlZmluZSBJT194QVBJQ19yb3V0ZV9lbnRyeSBJT19BUElDX3Jv
dXRlX2VudHJ5Cg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-06.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IHJlLWFzc2lnbiBkZXZpY2VzIGRpcmVjdGx5CgpEZXZp
Y2VzIHdpdGggdW5pdHkgbWFwIHJhbmdlcywgZHVlIHRvIGl0IGJlaW5nIHVu
c3BlY2lmaWVkIGhvdy93aGVuCnRoZXNlIG1lbW9yeSByYW5nZXMgbWF5IGdl
dCBhY2Nlc3NlZCwgbWF5IG5vdCBiZSBsZWZ0IGRpc2Nvbm5lY3RlZCBmcm9t
CnRoZWlyIHVuaXR5IG1hcHBpbmdzIChhcyBsb25nIGFzIGl0J3Mgbm90IGNl
cnRhaW4gdGhhdCB0aGUgZGV2aWNlIGhhcwpiZWVuIGZ1bGx5IHF1aWVzY2Vk
KS4gSGVuY2UgcmF0aGVyIHRoYW4gdGVhcmluZyBkb3duIHRoZSBvbGQgcm9v
dCBwYWdlCnRhYmxlIHBvaW50ZXIgYW5kIHRoZW4gZXN0YWJsaXNoaW5nIHRo
ZSBuZXcgb25lLCByZS1hc3NpZ25tZW50IG5lZWRzIHRvCmJlIGRvbmUgaW4g
YSBzaW5nbGUgc3RlcC4KClRoaXMgaXMgQ1ZFLTIwMjItMjYzNjAgLyBwYXJ0
IG9mIFhTQS00MDAuCgpSZXBvcnRlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8
cm9nZXIucGF1QGNpdHJpeC5jb20+CgpTaW1pbGFybHkgcXVhcmFudGluaW5n
IHNjcmF0Y2gtcGFnZSBtb2RlIHJlbGllcyBvbiBwYWdlIHRhYmxlcyB0byBi
ZQpjb250aW51b3VzbHkgd2lyZWQgdXAuCgpUbyBhdm9pZCBjb21wbGljYXRp
bmcgdGhpbmdzIG1vcmUgdGhhbiBuZWNlc3NhcnksIHRyZWF0IGFsbCBkZXZp
Y2VzCm1vc3RseSBlcXVhbGx5LCBpLmUuIHJlZ2FyZGxlc3Mgb2YgdGhlaXIg
YXNzb2NpYXRpb24gd2l0aCBhbnkgdW5pdHkgbWFwCnJhbmdlcy4gIFRoZSBt
YWluIGRpZmZlcmVuY2UgaXMgd2hlbiBpdCBjb21lcyB0byB1cGRhdGluZyBE
VEVzLCB3aGljaCBuZWVkCnRvIGJlIGF0b21pYyB3aGVuIHRoZXJlIGFyZSB1
bml0eSBtYXBwaW5ncy4gWWV0IGF0b21pY2l0eSBjYW4gb25seSBiZQphY2hp
ZXZlZCB3aXRoIENNUFhDSEcxNkIsIGF2YWlsYWJpbGl0eSBvZiB3aGljaCB3
ZSBjYW4ndCB0YWtlIGZvciBnaXZlbi4KClNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwg
RHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Ci0tLQp2NjogQWxzbyBp
bmNsdWRlIGRldmljZXMgd2l0aCBwaGFudG9tIGZ1bmN0aW9ucyBpbiB0aGUg
bm90LXNpbmdsZS1kZXZpY2UKICAgIGNoZWNrLiBBZGQgY29tbWVudCBhaGVh
ZCBvZiBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZSgpLgp2NTogUmVm
dXNlIHJlLWFzc2lnbm1lbnQgb2YgZGV2aWNlcyB3aXRoIHJlcXVlc3RvciBJ
RCBkaWZmZXJlbnQgZnJvbSBCREYKICAgIGFuZCB3aXRoIHVuaXR5IG1hcC4g
Q29udmVydCBhc3NlcnRpbmcgb2YgQ1gxNiBzdWNjZXNzIHRvIGVycm9yCiAg
ICByZXR1cm4uIEludHJvZHVjZSBhbmQgdXNlIGFueV9wZGV2X2JlaGluZF9p
b21tdSgpLiBSZWZpbmUgd2FybmluZwogICAgbWVzc2FnZSB0ZXh0IGFuZCB1
c2UgUENJX1NCREYzKCkgdGhlcmUuIFVzZSBjb3JyZWN0IGRvbWFpbiB0byBk
ZWNpZGUKICAgIHdoZXRoZXIgdG8gd2Fybi4KdjQ6IFJlZmluZSB3aGVuIHRv
IGF0dGVtcHQgYXRvbWljIERURSB1cGRhdGUuIEFkZCB3YXJuaW5nLgp2Mzog
UmVwbGFjZSBzbXBfd21iKCkgYnkgY29tbWVudC4gRHJvcCBhIHJlZHVuZGFu
dCBhc3NpZ25tZW50Lgp2MjogTmV3LgoKLS0tIGEveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvYW1kL2lvbW11LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11LmgKQEAgLTI2Myw5ICsyNjMsMTMgQEAgdm9pZCBh
bWRfaW9tbXVfc2V0X2ludHJlbWFwX3RhYmxlKHN0cnVjdAogICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHZvaWQgKnB0ciwKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg
YW1kX2lvbW11ICppb21tdSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBib29sIHZhbGlkKTsKLXZvaWQgYW1kX2lvbW11X3NldF9yb290
X3BhZ2VfdGFibGUoc3RydWN0IGFtZF9pb21tdV9kdGUgKmR0ZSwKLQkJCQkg
ICB1aW50NjRfdCByb290X3B0ciwgdWludDE2X3QgZG9tYWluX2lkLAotCQkJ
CSAgIHVpbnQ4X3QgcGFnaW5nX21vZGUsIGJvb2wgdmFsaWQpOworI2RlZmlu
ZSBTRVRfUk9PVF9WQUxJRCAgICAgICAgICAoMXUgPDwgMCkKKyNkZWZpbmUg
U0VUX1JPT1RfV0lUSF9VTklUWV9NQVAgKDF1IDw8IDEpCitpbnQgX19tdXN0
X2NoZWNrIGFtZF9pb21tdV9zZXRfcm9vdF9wYWdlX3RhYmxlKHN0cnVjdCBh
bWRfaW9tbXVfZHRlICpkdGUsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHVpbnQ2NF90IHJvb3RfcHRyLAorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
aW50MTZfdCBkb21haW5faWQsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgcGFnaW5nX21vZGUsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHVuc2lnbmVkIGludCBmbGFncyk7CiB2b2lkIGlvbW11X2R0ZV9hZGRfZGV2
aWNlX2VudHJ5KHN0cnVjdCBhbWRfaW9tbXVfZHRlICpkdGUsCiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBpdnJzX21h
cHBpbmdzICppdnJzX2Rldik7CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11X21hcC5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL2FtZC9pb21tdV9tYXAuYwpAQCAtMTE0LDEwICsxMTQsNjkgQEAg
c3RhdGljIHVuc2lnbmVkIGludCBzZXRfaW9tbXVfcHRlc19wcmVzZQogICAg
IHJldHVybiBmbHVzaF9mbGFnczsKIH0KIAotdm9pZCBhbWRfaW9tbXVfc2V0
X3Jvb3RfcGFnZV90YWJsZShzdHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRlLAot
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCBy
b290X3B0ciwgdWludDE2X3QgZG9tYWluX2lkLAotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICB1aW50OF90IHBhZ2luZ19tb2RlLCBib29s
IHZhbGlkKQorLyoKKyAqIFRoaXMgZnVuY3Rpb24gcmV0dXJucworICogLSAt
ZXJybm8gZm9yIGVycm9ycywKKyAqIC0gMCBmb3IgYSBzdWNjZXNzZnVsIHVw
ZGF0ZSwgYXRvbWljIHdoZW4gbmVjZXNzYXJ5CisgKiAtIDEgZm9yIGEgc3Vj
Y2Vzc2Z1bCBidXQgbm9uLWF0b21pYyB1cGRhdGUsIHdoaWNoIG1heSBuZWVk
IHRvIGJlIHdhcm5lZAorICogICBhYm91dCBieSB0aGUgY2FsbGVyLgorICov
CitpbnQgYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoc3RydWN0IGFt
ZF9pb21tdV9kdGUgKmR0ZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB1aW50NjRfdCByb290X3B0ciwgdWludDE2X3QgZG9tYWluX2lk
LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3Qg
cGFnaW5nX21vZGUsIHVuc2lnbmVkIGludCBmbGFncykKIHsKKyAgICBib29s
IHZhbGlkID0gZmxhZ3MgJiBTRVRfUk9PVF9WQUxJRDsKKworICAgIGlmICgg
ZHRlLT52ICYmIGR0ZS0+dHYgJiYKKyAgICAgICAgIChjcHVfaGFzX2N4MTYg
fHwgKGZsYWdzICYgU0VUX1JPT1RfV0lUSF9VTklUWV9NQVApKSApCisgICAg
eworICAgICAgICB1bmlvbiB7CisgICAgICAgICAgICBzdHJ1Y3QgYW1kX2lv
bW11X2R0ZSBkdGU7CisgICAgICAgICAgICB1aW50NjRfdCByYXc2NFs0XTsK
KyAgICAgICAgICAgIF9fdWludDEyOF90IHJhdzEyOFsyXTsKKyAgICAgICAg
fSBsZHRlID0geyAuZHRlID0gKmR0ZSB9OworICAgICAgICBfX3VpbnQxMjhf
dCBvbGQgPSBsZHRlLnJhdzEyOFswXTsKKyAgICAgICAgaW50IHJldCA9IDA7
CisKKyAgICAgICAgbGR0ZS5kdGUuZG9tYWluX2lkID0gZG9tYWluX2lkOwor
ICAgICAgICBsZHRlLmR0ZS5wdF9yb290ID0gcGFkZHJfdG9fcGZuKHJvb3Rf
cHRyKTsKKyAgICAgICAgbGR0ZS5kdGUuaXcgPSB0cnVlOworICAgICAgICBs
ZHRlLmR0ZS5pciA9IHRydWU7CisgICAgICAgIGxkdGUuZHRlLnBhZ2luZ19t
b2RlID0gcGFnaW5nX21vZGU7CisgICAgICAgIGxkdGUuZHRlLnYgPSB2YWxp
ZDsKKworICAgICAgICBpZiAoIGNwdV9oYXNfY3gxNiApCisgICAgICAgIHsK
KyAgICAgICAgICAgIF9fdWludDEyOF90IHJlcyA9IGNtcHhjaGcxNmIoZHRl
LCAmb2xkLCAmbGR0ZS5yYXcxMjhbMF0pOworCisgICAgICAgICAgICAvKgor
ICAgICAgICAgICAgICogSGFyZHdhcmUgZG9lcyBub3QgdXBkYXRlIHRoZSBE
VEUgYmVoaW5kIG91ciBiYWNrcywgc28gdGhlCisgICAgICAgICAgICAgKiBy
ZXR1cm4gdmFsdWUgc2hvdWxkIG1hdGNoICJvbGQiLgorICAgICAgICAgICAg
ICovCisgICAgICAgICAgICBpZiAoIHJlcyAhPSBvbGQgKQorICAgICAgICAg
ICAgeworICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSCisgICAg
ICAgICAgICAgICAgICAgICAgICJEb20lZDogdW5leHBlY3RlZCBEVEUgJTAx
Nmx4XyUwMTZseCAoZXhwZWN0ZWQgJTAxNmx4XyUwMTZseClcbiIsCisgICAg
ICAgICAgICAgICAgICAgICAgIGRvbWFpbl9pZCwKKyAgICAgICAgICAgICAg
ICAgICAgICAgKHVpbnQ2NF90KShyZXMgPj4gNjQpLCAodWludDY0X3QpcmVz
LAorICAgICAgICAgICAgICAgICAgICAgICAodWludDY0X3QpKG9sZCA+PiA2
NCksICh1aW50NjRfdClvbGQpOworICAgICAgICAgICAgICAgIHJldCA9IC1F
SUxTRVE7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICAgICAgZWxz
ZSAvKiBCZXN0IGVmZm9ydCwgdXBkYXRpbmcgZG9tYWluX2lkIGxhc3QuICov
CisgICAgICAgIHsKKyAgICAgICAgICAgIHVpbnQ2NF90ICpwdHIgPSAodm9p
ZCAqKWR0ZTsKKworICAgICAgICAgICAgd3JpdGVfYXRvbWljKHB0ciArIDAs
IGxkdGUucmF3NjRbMF0pOworICAgICAgICAgICAgLyogTm8gYmFycmllciBz
aG91bGQgYmUgbmVlZGVkIGJldHdlZW4gdGhlc2UgdHdvLiAqLworICAgICAg
ICAgICAgd3JpdGVfYXRvbWljKHB0ciArIDEsIGxkdGUucmF3NjRbMV0pOwor
CisgICAgICAgICAgICByZXQgPSAxOworICAgICAgICB9CisKKyAgICAgICAg
cmV0dXJuIHJldDsKKyAgICB9CisKICAgICBpZiAoIHZhbGlkIHx8IGR0ZS0+
diApCiAgICAgewogICAgICAgICBkdGUtPnR2ID0gZmFsc2U7CkBAIC0xMzIs
NiArMTkxLDggQEAgdm9pZCBhbWRfaW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJs
ZShzdHJ1YwogICAgIHNtcF93bWIoKTsKICAgICBkdGUtPnR2ID0gdHJ1ZTsK
ICAgICBkdGUtPnYgPSB2YWxpZDsKKworICAgIHJldHVybiAwOwogfQogCiB2
b2lkIGFtZF9pb21tdV9zZXRfaW50cmVtYXBfdGFibGUoCi0tLSBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11LmMKKysrIGIv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYwpA
QCAtOTYsMTMgKzk2LDMyIEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFs
bG9jYXRlX2RvbWFpbl8KICAgICByZXR1cm4gcmM7CiB9CiAKK3N0YXRpYyBi
b29sIGFueV9wZGV2X2JlaGluZF9pb21tdShjb25zdCBzdHJ1Y3QgZG9tYWlu
ICpkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0
IHN0cnVjdCBwY2lfZGV2ICpleGNsdWRlLAorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11
KQoreworICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2OworCisgICAg
Zm9yX2VhY2hfcGRldiAoIGQsIHBkZXYgKQorICAgIHsKKyAgICAgICAgaWYg
KCBwZGV2ID09IGV4Y2x1ZGUgKQorICAgICAgICAgICAgY29udGludWU7CisK
KyAgICAgICAgaWYgKCBmaW5kX2lvbW11X2Zvcl9kZXZpY2UocGRldi0+c2Vn
LCBwZGV2LT5zYmRmLmJkZikgPT0gaW9tbXUgKQorICAgICAgICAgICAgcmV0
dXJuIHRydWU7CisgICAgfQorCisgICAgcmV0dXJuIGZhbHNlOworfQorCiBz
dGF0aWMgaW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfZG9tYWlu
X2RldmljZSgKICAgICBzdHJ1Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCBh
bWRfaW9tbXUgKmlvbW11LAogICAgIHVpbnQ4X3QgZGV2Zm4sIHN0cnVjdCBw
Y2lfZGV2ICpwZGV2KQogewogICAgIHN0cnVjdCBhbWRfaW9tbXVfZHRlICp0
YWJsZSwgKmR0ZTsKICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwotICAgIGlu
dCByZXFfaWQsIHZhbGlkID0gMSwgcmM7CisgICAgdW5zaWduZWQgaW50IHJl
cV9pZCwgc3JfZmxhZ3M7CisgICAgaW50IHJjOwogICAgIHU4IGJ1cyA9IHBk
ZXYtPmJ1czsKICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9p
b21tdShkb21haW4pOwogICAgIGNvbnN0IHN0cnVjdCBpdnJzX21hcHBpbmdz
ICppdnJzX2RldjsKQEAgLTExNiw4ICsxMzUsMTEgQEAgc3RhdGljIGludCBf
X211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwogICAgIGlmICggcmMgKQog
ICAgICAgICByZXR1cm4gcmM7CiAKLSAgICBpZiAoIGlvbW11X2h3ZG9tX3Bh
c3N0aHJvdWdoICYmIGlzX2hhcmR3YXJlX2RvbWFpbihkb21haW4pICkKLSAg
ICAgICAgdmFsaWQgPSAwOworICAgIHJlcV9pZCA9IGdldF9kbWFfcmVxdWVz
dG9yX2lkKGlvbW11LT5zZWcsIHBkZXYtPnNiZGYuYmRmKTsKKyAgICBpdnJz
X2RldiA9ICZnZXRfaXZyc19tYXBwaW5ncyhpb21tdS0+c2VnKVtyZXFfaWRd
OworICAgIHNyX2ZsYWdzID0gKGlvbW11X2h3ZG9tX3Bhc3N0aHJvdWdoICYm
IGlzX2hhcmR3YXJlX2RvbWFpbihkb21haW4pCisgICAgICAgICAgICAgICAg
PyAwIDogU0VUX1JPT1RfVkFMSUQpCisgICAgICAgICAgICAgICB8IChpdnJz
X2Rldi0+dW5pdHlfbWFwID8gU0VUX1JPT1RfV0lUSF9VTklUWV9NQVAgOiAw
KTsKIAogICAgIC8qIGdldCBkZXZpY2UtdGFibGUgZW50cnkgKi8KICAgICBy
ZXFfaWQgPSBnZXRfZG1hX3JlcXVlc3Rvcl9pZChpb21tdS0+c2VnLCBQQ0lf
QkRGMihidXMsIGRldmZuKSk7CkBAIC0xMzAsOSArMTUyLDE1IEBAIHN0YXRp
YyBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICBpZiAo
ICFkdGUtPnYgfHwgIWR0ZS0+dHYgKQogICAgIHsKICAgICAgICAgLyogYmlu
ZCBEVEUgdG8gZG9tYWluIHBhZ2UtdGFibGVzICovCi0gICAgICAgIGFtZF9p
b21tdV9zZXRfcm9vdF9wYWdlX3RhYmxlKAotICAgICAgICAgICAgZHRlLCBw
YWdlX3RvX21hZGRyKGhkLT5hcmNoLmFtZC5yb290X3RhYmxlKSwKLSAgICAg
ICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkLCBoZC0+YXJjaC5hbWQucGFnaW5n
X21vZGUsIHZhbGlkKTsKKyAgICAgICAgcmMgPSBhbWRfaW9tbXVfc2V0X3Jv
b3RfcGFnZV90YWJsZSgKKyAgICAgICAgICAgICAgICAgZHRlLCBwYWdlX3Rv
X21hZGRyKGhkLT5hcmNoLmFtZC5yb290X3RhYmxlKSwKKyAgICAgICAgICAg
ICAgICAgZG9tYWluLT5kb21haW5faWQsIGhkLT5hcmNoLmFtZC5wYWdpbmdf
bW9kZSwgc3JfZmxhZ3MpOworICAgICAgICBpZiAoIHJjICkKKyAgICAgICAg
eworICAgICAgICAgICAgQVNTRVJUKHJjIDwgMCk7CisgICAgICAgICAgICBz
cGluX3VubG9ja19pcnFyZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3MpOwor
ICAgICAgICAgICAgcmV0dXJuIHJjOworICAgICAgICB9CiAKICAgICAgICAg
LyogVW5kbyB3aGF0IGFtZF9pb21tdV9kaXNhYmxlX2RvbWFpbl9kZXZpY2Uo
KSBtYXkgaGF2ZSBkb25lLiAqLwogICAgICAgICBpZiAoIGR0ZS0+aXRfcm9v
dCApCkBAIC0xNTIsMTcgKzE4MCw3NiBAQCBzdGF0aWMgaW50IF9fbXVzdF9j
aGVjayBhbWRfaW9tbXVfc2V0dXBfCiAgICAgICAgIHNwaW5fdW5sb2NrX2ly
cXJlc3RvcmUoJmlvbW11LT5sb2NrLCBmbGFncyk7CiAKICAgICAgICAgYW1k
X2lvbW11X2ZsdXNoX2RldmljZShpb21tdSwgcmVxX2lkKTsKKyAgICB9Cisg
ICAgZWxzZSBpZiAoIGR0ZS0+cHRfcm9vdCAhPSBtZm5feChwYWdlX3RvX21m
bihoZC0+YXJjaC5hbWQucm9vdF90YWJsZSkpICkKKyAgICB7CisgICAgICAg
IC8qCisgICAgICAgICAqIFN0cmljdGx5IHNwZWFraW5nIGlmIHRoZSBkZXZp
Y2UgaXMgdGhlIG9ubHkgb25lIHdpdGggdGhpcyByZXF1ZXN0b3IKKyAgICAg
ICAgICogSUQsIGl0IGNvdWxkIGJlIGFsbG93ZWQgdG8gYmUgcmUtYXNzaWdu
ZWQgcmVnYXJkbGVzcyBvZiB1bml0eSBtYXAKKyAgICAgICAgICogcHJlc2Vu
Y2UuICBCdXQgbGV0J3MgZGVhbCB3aXRoIHRoYXQgY2FzZSBvbmx5IGlmIGl0
IGlzIGFjdHVhbGx5CisgICAgICAgICAqIGZvdW5kIGluIHRoZSB3aWxkLgor
ICAgICAgICAgKi8KKyAgICAgICAgaWYgKCByZXFfaWQgIT0gUENJX0JERjIo
YnVzLCBkZXZmbikgJiYKKyAgICAgICAgICAgICAoc3JfZmxhZ3MgJiBTRVRf
Uk9PVF9XSVRIX1VOSVRZX01BUCkgKQorICAgICAgICAgICAgcmMgPSAtRU9Q
Tk9UU1VQUDsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgcmMgPSBhbWRf
aW9tbXVfc2V0X3Jvb3RfcGFnZV90YWJsZSgKKyAgICAgICAgICAgICAgICAg
ICAgIGR0ZSwgcGFnZV90b19tYWRkcihoZC0+YXJjaC5hbWQucm9vdF90YWJs
ZSksCisgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwg
aGQtPmFyY2guYW1kLnBhZ2luZ19tb2RlLCBzcl9mbGFncyk7CisgICAgICAg
IGlmICggcmMgPCAwICkKKyAgICAgICAgeworICAgICAgICAgICAgc3Bpbl91
bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKKyAgICAg
ICAgICAgIHJldHVybiByYzsKKyAgICAgICAgfQorICAgICAgICBpZiAoIHJj
ICYmCisgICAgICAgICAgICAgZG9tYWluICE9IHBkZXYtPmRvbWFpbiAmJgor
ICAgICAgICAgICAgIC8qCisgICAgICAgICAgICAgICogQnkgbm9uLWF0b21p
Y2FsbHkgdXBkYXRpbmcgdGhlIERURSdzIGRvbWFpbiBJRCBmaWVsZCBsYXN0
LAorICAgICAgICAgICAgICAqIGR1cmluZyBhIHNob3J0IHdpbmRvdyBpbiB0
aW1lIFRMQiBlbnRyaWVzIHdpdGggdGhlIG9sZCBkb21haW4KKyAgICAgICAg
ICAgICAgKiBJRCBidXQgdGhlIG5ldyBwYWdlIHRhYmxlcyBtYXkgaGF2ZSBi
ZWVuIGluc2VydGVkLiAgVGhpcyBjb3VsZAorICAgICAgICAgICAgICAqIGFm
ZmVjdCBJL08gb2Ygb3RoZXIgZGV2aWNlcyB1c2luZyB0aGlzIHNhbWUgKG9s
ZCkgZG9tYWluIElELgorICAgICAgICAgICAgICAqIFN1Y2ggdXBkYXRpbmcg
dGhlcmVmb3JlIGlzIG5vdCBhIHByb2JsZW0gaWYgdGhpcyB3YXMgdGhlIG9u
bHkKKyAgICAgICAgICAgICAgKiBkZXZpY2UgYXNzb2NpYXRlZCB3aXRoIHRo
ZSBvbGQgZG9tYWluIElELiAgRGl2ZXJ0aW5nIEkvTyBvZiBhbnkKKyAgICAg
ICAgICAgICAgKiBvZiBhIGR5aW5nIGRvbWFpbidzIGRldmljZXMgdG8gdGhl
IHF1YXJhbnRpbmUgcGFnZSB0YWJsZXMgaXMKKyAgICAgICAgICAgICAgKiBp
bnRlbmRlZCBhbnl3YXkuCisgICAgICAgICAgICAgICovCisgICAgICAgICAg
ICAgIXBkZXYtPmRvbWFpbi0+aXNfZHlpbmcgJiYKKyAgICAgICAgICAgICAo
YW55X3BkZXZfYmVoaW5kX2lvbW11KHBkZXYtPmRvbWFpbiwgcGRldiwgaW9t
bXUpIHx8CisgICAgICAgICAgICAgIHBkZXYtPnBoYW50b21fc3RyaWRlKSAp
CisgICAgICAgICAgICBBTURfSU9NTVVfV0FSTigiICVwcDogcmVhc3NpZ25t
ZW50IG1heSBjYXVzZSAlcGQgZGF0YSBjb3JydXB0aW9uXG4iLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGMyhwZGV2LT5zZWcsIGJ1
cywgZGV2Zm4pLCBwZGV2LT5kb21haW4pOworCisgICAgICAgIC8qCisgICAg
ICAgICAqIENoZWNrIHJlbWFpbmluZyBzZXR0aW5ncyBhcmUgc3RpbGwgaW4g
cGxhY2UgZnJvbSBhbiBlYXJsaWVyIGNhbGwKKyAgICAgICAgICogaGVyZS4g
VGhleSdyZSBhbGwgaW5kZXBlbmRlbnQgb2YgdGhlIGRvbWFpbiwgc28gc2hv
dWxkIG5vdCBoYXZlCisgICAgICAgICAqIGNoYW5nZWQuCisgICAgICAgICAq
LworICAgICAgICBpZiAoIGR0ZS0+aXRfcm9vdCApCisgICAgICAgICAgICBB
U1NFUlQoZHRlLT5pbnRfY3RsID09IElPTU1VX0RFVl9UQUJMRV9JTlRfQ09O
VFJPTF9UUkFOU0xBVEVEKTsKKyAgICAgICAgQVNTRVJUKGR0ZS0+aXYgPT0g
aW9tbXVfaW50cmVtYXApOworICAgICAgICBBU1NFUlQoZHRlLT5leCA9PSBp
dnJzX2Rldi0+ZHRlX2FsbG93X2V4Y2x1c2lvbik7CisgICAgICAgIEFTU0VS
VChkdGUtPnN5c19tZ3QgPT0gTUFTS19FWFRSKGl2cnNfZGV2LT5kZXZpY2Vf
ZmxhZ3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIEFDUElfSVZIRF9TWVNURU1fTUdNVCkpOwogCi0gICAgICAgIEFNRF9J
T01NVV9ERUJVRygiU2V0dXAgSS9PIHBhZ2UgdGFibGU6IGRldmljZSBpZCA9
ICUjeCwgdHlwZSA9ICUjeCwgIgotICAgICAgICAgICAgICAgICAgICAgICAg
InJvb3QgdGFibGUgPSAlIyJQUkl4NjQiLCAiCi0gICAgICAgICAgICAgICAg
ICAgICAgICAiZG9tYWluID0gJWQsIHBhZ2luZyBtb2RlID0gJWRcbiIsCi0g
ICAgICAgICAgICAgICAgICAgICAgICByZXFfaWQsIHBkZXYtPnR5cGUsCi0g
ICAgICAgICAgICAgICAgICAgICAgICBwYWdlX3RvX21hZGRyKGhkLT5hcmNo
LmFtZC5yb290X3RhYmxlKSwKLSAgICAgICAgICAgICAgICAgICAgICAgIGRv
bWFpbi0+ZG9tYWluX2lkLCBoZC0+YXJjaC5hbWQucGFnaW5nX21vZGUpOwor
ICAgICAgICBpZiAoIHBjaV9hdHNfZGV2aWNlKGlvbW11LT5zZWcsIGJ1cywg
cGRldi0+ZGV2Zm4pICYmCisgICAgICAgICAgICAgIWl2cnNfZGV2LT5ibG9j
a19hdHMgJiYKKyAgICAgICAgICAgICBpb21tdV9oYXNfY2FwKGlvbW11LCBQ
Q0lfQ0FQX0lPVExCX1NISUZUKSApCisgICAgICAgICAgICBBU1NFUlQoZHRl
LT5pID09IGF0c19lbmFibGVkKTsKKworICAgICAgICBzcGluX3VubG9ja19p
cnFyZXN0b3JlKCZpb21tdS0+bG9jaywgZmxhZ3MpOworCisgICAgICAgIGFt
ZF9pb21tdV9mbHVzaF9kZXZpY2UoaW9tbXUsIHJlcV9pZCk7CiAgICAgfQog
ICAgIGVsc2UKICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW9t
bXUtPmxvY2ssIGZsYWdzKTsKIAorICAgIEFNRF9JT01NVV9ERUJVRygiU2V0
dXAgSS9PIHBhZ2UgdGFibGU6IGRldmljZSBpZCA9ICUjeCwgdHlwZSA9ICUj
eCwgIgorICAgICAgICAgICAgICAgICAgICAicm9vdCB0YWJsZSA9ICUjIlBS
SXg2NCIsICIKKyAgICAgICAgICAgICAgICAgICAgImRvbWFpbiA9ICVkLCBw
YWdpbmcgbW9kZSA9ICVkXG4iLAorICAgICAgICAgICAgICAgICAgICByZXFf
aWQsIHBkZXYtPnR5cGUsCisgICAgICAgICAgICAgICAgICAgIHBhZ2VfdG9f
bWFkZHIoaGQtPmFyY2guYW1kLnJvb3RfdGFibGUpLAorICAgICAgICAgICAg
ICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgaGQtPmFyY2guYW1kLnBhZ2lu
Z19tb2RlKTsKKwogICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKIAog
ICAgIGlmICggcGNpX2F0c19kZXZpY2UoaW9tbXUtPnNlZywgYnVzLCBwZGV2
LT5kZXZmbikgJiYKQEAgLTM2Nyw3ICs0NTQsMjAgQEAgc3RhdGljIGludCBj
Zl9jaGVjayByZWFzc2lnbl9kZXZpY2UoCiAgICAgICAgIHJldHVybiAtRU5P
REVWOwogICAgIH0KIAotICAgIGFtZF9pb21tdV9kaXNhYmxlX2RvbWFpbl9k
ZXZpY2Uoc291cmNlLCBpb21tdSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICgg
IVFVQVJBTlRJTkVfU0tJUCh0YXJnZXQpICkKKyAgICB7CisgICAgICAgIHJj
ID0gYW1kX2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2UodGFyZ2V0LCBpb21t
dSwgZGV2Zm4sIHBkZXYpOworICAgICAgICBpZiAoIHJjICkKKyAgICAgICAg
ICAgIHJldHVybiByYzsKKyAgICB9CisgICAgZWxzZQorICAgICAgICBhbWRf
aW9tbXVfZGlzYWJsZV9kb21haW5fZGV2aWNlKHNvdXJjZSwgaW9tbXUsIGRl
dmZuLCBwZGV2KTsKKworICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4g
JiYgcGRldi0+ZG9tYWluICE9IHRhcmdldCApCisgICAgeworICAgICAgICBs
aXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFyZ2V0LT5wZGV2X2xp
c3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7CisgICAgfQog
CiAgICAgLyoKICAgICAgKiBJZiB0aGUgZGV2aWNlIGJlbG9uZ3MgdG8gdGhl
IGhhcmR3YXJlIGRvbWFpbiwgYW5kIGl0IGhhcyBhIHVuaXR5IG1hcHBpbmcs
CkBAIC0zODMsMjUgKzQ4Myw5IEBAIHN0YXRpYyBpbnQgY2ZfY2hlY2sgcmVh
c3NpZ25fZGV2aWNlKAogICAgICAgICAgICAgcmV0dXJuIHJjOwogICAgIH0K
IAotICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9t
YWluICE9IGRvbV9pbyApCi0gICAgewotICAgICAgICBsaXN0X21vdmUoJnBk
ZXYtPmRvbWFpbl9saXN0LCAmZG9tX2lvLT5wZGV2X2xpc3QpOwotICAgICAg
ICBwZGV2LT5kb21haW4gPSBkb21faW87Ci0gICAgfQotCi0gICAgcmMgPSBh
bWRfaW9tbXVfc2V0dXBfZG9tYWluX2RldmljZSh0YXJnZXQsIGlvbW11LCBk
ZXZmbiwgcGRldik7Ci0gICAgaWYgKCByYyApCi0gICAgICAgIHJldHVybiBy
YzsKLQogICAgIEFNRF9JT01NVV9ERUJVRygiUmUtYXNzaWduICVwcCBmcm9t
IGRvbSVkIHRvIGRvbSVkXG4iLAogICAgICAgICAgICAgICAgICAgICAmcGRl
di0+c2JkZiwgc291cmNlLT5kb21haW5faWQsIHRhcmdldC0+ZG9tYWluX2lk
KTsKIAotICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gJiYgcGRldi0+
ZG9tYWluICE9IHRhcmdldCApCi0gICAgewotICAgICAgICBsaXN0X21vdmUo
JnBkZXYtPmRvbWFpbl9saXN0LCAmdGFyZ2V0LT5wZGV2X2xpc3QpOwotICAg
ICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7Ci0gICAgfQotCiAgICAgcmV0
dXJuIDA7CiB9CiAK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-07.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSSkKCkFycmFuZ2UgZm9yIGRvbWFpbiBJRCBhbmQg
cGFnZSB0YWJsZSByb290IHRvIGJlIHBhc3NlZCBhcm91bmQsIHRoZSBsYXR0
ZXIgaW4KcGFydGljdWxhciB0byBkb21haW5fcGdkX21hZGRyKCkgc3VjaCB0
aGF0IHRha2luZyBpdCBmcm9tIHRoZSBwZXItZG9tYWluCmZpZWxkcyBjYW4g
YmUgb3ZlcnJpZGRlbi4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVk
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5A
aW50ZWwuY29tPgotLS0Kdjc6IFJlLWJhc2UuCnY1OiBBbHNvIHBhc3MgYXJv
dW5kIGRvbWFpbiBJRC4KdjQ6IERyb3Agc3RyYXkgaW5zZXJ0aW9uIG9mIGEg
YmxhbmsgbGluZSBpbiB0aGUgbWlkZGxlIG9mIGEgY29tbWVudC4KICAgIFJl
LWJhc2Ugb3ZlciBuZXcgZWFybGllciBwYXRjaCBhbmQgb3RoZXIgY2hhbmdl
cyBlYXJsaWVyIGluIHRoZQogICAgc2VyaWVzLgp2MzogUmUtYmFzZSBvdmVy
IGNoYW5nZXMgZWFybGllciBpbiB0aGUgc2VyaWVzLgp2MjogTmV3LgoKLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2V4dGVybi5oCisrKyBi
L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9leHRlcm4uaApAQCAtODIs
OSArODIsMTAgQEAgdm9pZCAqbWFwX3Z0ZF9kb21haW5fcGFnZSh1NjQgbWFk
ZHIpOwogdm9pZCB1bm1hcF92dGRfZG9tYWluX3BhZ2UoY29uc3Qgdm9pZCAq
dmEpOwogaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKHN0cnVjdCBk
b21haW4gKmRvbWFpbiwgc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUsCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBidXMsIHVpbnQ4
X3QgZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u
c3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCBtb2RlKTsK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg
cGNpX2RldiAqcGRldiwgZG9taWRfdCBkb21pZCwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBwYWRkcl90IHBnZF9tYWRkciwgdW5zaWduZWQg
aW50IG1vZGUpOwogaW50IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShzdHJ1
Y3QgZG9tYWluICpkb21haW4sIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAot
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1OCBidXMsIHU4IGRldmZu
KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBidXMs
IHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQpOwogaW50IGNmX2NoZWNr
IGludGVsX2lvbW11X2dldF9yZXNlcnZlZF9kZXZpY2VfbWVtb3J5KAogICAg
IGlvbW11X2dyZG1fdCAqZnVuYywgdm9pZCAqY3R4dCk7CiAKQEAgLTEwNSw3
ICsxMDYsOCBAQCB2b2lkIHBsYXRmb3JtX3F1aXJrc19pbml0KHZvaWQpOwog
dm9pZCB2dGRfb3BzX3ByZWFtYmxlX3F1aXJrKHN0cnVjdCB2dGRfaW9tbXUg
KmlvbW11KTsKIHZvaWQgdnRkX29wc19wb3N0YW1ibGVfcXVpcmsoc3RydWN0
IHZ0ZF9pb21tdSAqaW9tbXUpOwogaW50IF9fbXVzdF9jaGVjayBtZV93aWZp
X3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgdWludDhfdCBidXMsCi0g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBkZXZmbiwg
dW5zaWduZWQgaW50IG1vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHVpbnQ4X3QgZGV2Zm4sIGRvbWlkX3QgZG9taWQsIHBhZGRyX3Qg
cGdkX21hZGRyLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVu
c2lnbmVkIGludCBtb2RlKTsKIHZvaWQgcGNpX3Z0ZF9xdWlyayhjb25zdCBz
dHJ1Y3QgcGNpX2RldiAqKTsKIHZvaWQgcXVpcmtfaW9tbXVfY2FwcyhzdHJ1
Y3QgdnRkX2lvbW11ICppb21tdSk7CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvdnRkL2lvbW11LmMKQEAgLTQzLDcgKzQzLDcgQEAKICNpbmNsdWRl
ICIuLi9hdHMuaCIKIAogLyogZG9tX2lvIGlzIHVzZWQgYXMgYSBzZW50aW5l
bCBmb3IgcXVhcmFudGluZWQgZGV2aWNlcyAqLwotI2RlZmluZSBRVUFSQU5U
SU5FX1NLSVAoZCkgKChkKSA9PSBkb21faW8gJiYgIWRvbV9pb21tdShkKS0+
YXJjaC52dGQucGdkX21hZGRyKQorI2RlZmluZSBRVUFSQU5USU5FX1NLSVAo
ZCwgcGdkX21hZGRyKSAoKGQpID09IGRvbV9pbyAmJiAhKHBnZF9tYWRkcikp
CiAKIC8qIFBvc3NpYmxlIHVuZmlsdGVyZWQgTEFQSUMvTVNJIG1lc3NhZ2Vz
IGZyb20gdW50cnVzdGVkIHNvdXJjZXM/ICovCiBib29sIF9fcmVhZF9tb3N0
bHkgdW50cnVzdGVkX21zaTsKQEAgLTM0NiwxNSArMzQ2LDE3IEBAIHN0YXRp
YyB1NjQgYWRkcl90b19kbWFfcGFnZV9tYWRkcihzdHJ1Y3QKICAgICByZXR1
cm4gcHRlX21hZGRyOwogfQogCi1zdGF0aWMgdWludDY0X3QgZG9tYWluX3Bn
ZF9tYWRkcihzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgbnJfcHRf
bGV2ZWxzKQorc3RhdGljIHBhZGRyX3QgZG9tYWluX3BnZF9tYWRkcihzdHJ1
Y3QgZG9tYWluICpkLCBwYWRkcl90IHBnZF9tYWRkciwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5yX3B0X2xldmVs
cykKIHsKICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21t
dShkKTsKLSAgICB1aW50NjRfdCBwZ2RfbWFkZHI7CiAgICAgdW5zaWduZWQg
aW50IGFnYXc7CiAKICAgICBBU1NFUlQoc3Bpbl9pc19sb2NrZWQoJmhkLT5h
cmNoLm1hcHBpbmdfbG9jaykpOwogCi0gICAgaWYgKCBpb21tdV91c2VfaGFw
X3B0KGQpICkKKyAgICBpZiAoIHBnZF9tYWRkciApCisgICAgICAgIC8qIG5v
dGhpbmcgKi87CisgICAgZWxzZSBpZiAoIGlvbW11X3VzZV9oYXBfcHQoZCkg
KQogICAgIHsKICAgICAgICAgcGFnZXRhYmxlX3QgcGd0ID0gcDJtX2dldF9w
YWdldGFibGUocDJtX2dldF9ob3N0cDJtKGQpKTsKIApAQCAtMTM3OSwxOCAr
MTM4MSwxOCBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoCiAg
ICAgc3RydWN0IGRvbWFpbiAqZG9tYWluLAogICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11LAogICAgIHVpbnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLCBj
b25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwKLSAgICB1bnNpZ25lZCBpbnQg
bW9kZSkKKyAgICBkb21pZF90IGRvbWlkLCBwYWRkcl90IHBnZF9tYWRkciwg
dW5zaWduZWQgaW50IG1vZGUpCiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21t
dSAqaGQgPSBkb21faW9tbXUoZG9tYWluKTsKICAgICBzdHJ1Y3QgY29udGV4
dF9lbnRyeSAqY29udGV4dCwgKmNvbnRleHRfZW50cmllcywgbGN0eHQ7CiAg
ICAgX191aW50MTI4X3Qgb2xkOwotICAgIHU2NCBtYWRkciwgcGdkX21hZGRy
OworICAgIHVpbnQ2NF90IG1hZGRyOwogICAgIHVpbnQxNl90IHNlZyA9IGlv
bW11LT5kcmhkLT5zZWdtZW50LCBwcmV2X2RpZCA9IDA7CiAgICAgc3RydWN0
IGRvbWFpbiAqcHJldl9kb20gPSBOVUxMOwogICAgIGludCByYywgcmV0Owog
ICAgIGJvb2xfdCBmbHVzaF9kZXZfaW90bGI7CiAKLSAgICBpZiAoIFFVQVJB
TlRJTkVfU0tJUChkb21haW4pICkKKyAgICBpZiAoIFFVQVJBTlRJTkVfU0tJ
UChkb21haW4sIHBnZF9tYWRkcikgKQogICAgICAgICByZXR1cm4gMDsKIAog
ICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKQEAgLTE0MjcsMTAgKzE0
MjksMTIgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAg
IH0KICAgICBlbHNlCiAgICAgeworICAgICAgICBwYWRkcl90IHJvb3Q7CisK
ICAgICAgICAgc3Bpbl9sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwog
Ci0gICAgICAgIHBnZF9tYWRkciA9IGRvbWFpbl9wZ2RfbWFkZHIoZG9tYWlu
LCBpb21tdS0+bnJfcHRfbGV2ZWxzKTsKLSAgICAgICAgaWYgKCAhcGdkX21h
ZGRyICkKKyAgICAgICAgcm9vdCA9IGRvbWFpbl9wZ2RfbWFkZHIoZG9tYWlu
LCBwZ2RfbWFkZHIsIGlvbW11LT5ucl9wdF9sZXZlbHMpOworICAgICAgICBp
ZiAoICFyb290ICkKICAgICAgICAgewogICAgICAgICAgICAgc3Bpbl91bmxv
Y2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7CiAgICAgICAgICAgICBzcGlu
X3VubG9jaygmaW9tbXUtPmxvY2spOwpAQCAtMTQ0MCw3ICsxNDQ0LDcgQEAg
aW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAogICAgICAgICAgICAg
cmV0dXJuIC1FTk9NRU07CiAgICAgICAgIH0KIAotICAgICAgICBjb250ZXh0
X3NldF9hZGRyZXNzX3Jvb3QobGN0eHQsIHBnZF9tYWRkcik7CisgICAgICAg
IGNvbnRleHRfc2V0X2FkZHJlc3Nfcm9vdChsY3R4dCwgcm9vdCk7CiAgICAg
ICAgIGlmICggYXRzX2VuYWJsZWQgJiYgZWNhcF9kZXZfaW90bGIoaW9tbXUt
PmVjYXApICkKICAgICAgICAgICAgIGNvbnRleHRfc2V0X3RyYW5zbGF0aW9u
X3R5cGUobGN0eHQsIENPTlRFWFRfVFRfREVWX0lPVExCKTsKICAgICAgICAg
ZWxzZQpAQCAtMTU1NywxNSArMTU2MSwyMSBAQCBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZ19vbmUoCiAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKGNv
bnRleHRfZW50cmllcyk7CiAKICAgICBpZiAoICFzZWcgJiYgIXJjICkKLSAg
ICAgICAgcmMgPSBtZV93aWZpX3F1aXJrKGRvbWFpbiwgYnVzLCBkZXZmbiwg
bW9kZSk7CisgICAgICAgIHJjID0gbWVfd2lmaV9xdWlyayhkb21haW4sIGJ1
cywgZGV2Zm4sIGRvbWlkLCBwZ2RfbWFkZHIsIG1vZGUpOwogCiAgICAgaWYg
KCByYyApCiAgICAgewogICAgICAgICBpZiAoICFwcmV2X2RvbSApCi0gICAg
ICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWlu
LCBpb21tdSwgYnVzLCBkZXZmbik7CisgICAgICAgICAgICByZXQgPSBkb21h
aW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwgYnVzLCBkZXZm
biwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBkb21haW4tPmRvbWFpbl9pZCk7CiAgICAgICAgIGVsc2UgaWYgKCBwcmV2
X2RvbSAhPSBkb21haW4gKSAvKiBBdm9pZCBpbmZpbml0ZSByZWN1cnNpb24u
ICovCisgICAgICAgIHsKKyAgICAgICAgICAgIGhkID0gZG9tX2lvbW11KHBy
ZXZfZG9tKTsKICAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21h
cHBpbmdfb25lKHByZXZfZG9tLCBpb21tdSwgYnVzLCBkZXZmbiwgcGRldiwK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGRvbWFpbi0+ZG9tYWluX2lkLAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgaGQtPmFyY2gudnRkLnBnZF9tYWRkciwK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IG1vZGUgJiBNQVBfV0lUSF9STVJSKSA8IDA7CisgICAgICAgIH0KICAgICAg
ICAgZWxzZQogICAgICAgICAgICAgcmV0ID0gMTsKIApAQCAtMTU4Nyw2ICsx
NTk3LDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0
cnVjdAogewogICAgIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJo
ZCA9IGFjcGlfZmluZF9tYXRjaGVkX2RyaGRfdW5pdChwZGV2KTsKICAgICBj
b25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CisgICAgcGFkZHJf
dCBwZ2RfbWFkZHIgPSBkb21faW9tbXUoZG9tYWluKS0+YXJjaC52dGQucGdk
X21hZGRyOwogICAgIGludCByZXQgPSAwOwogICAgIHVuc2lnbmVkIGludCBp
LCBtb2RlID0gMDsKICAgICB1aW50MTZfdCBzZWcgPSBwZGV2LT5zZWcsIGJk
ZjsKQEAgLTE2NDksNyArMTY2MCw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2Nv
bnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgIHByaW50ayhWVERQ
UkVGSVggIiVwZDpQQ0llOiBtYXAgJXBwXG4iLAogICAgICAgICAgICAgICAg
ICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pKTsKICAg
ICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWlu
LCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgcGRldiwgbW9kZSk7CisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIGRvbWFp
bi0+ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIG1vZGUpOwogICAgICAgICBpZiAoIHJl
dCA+IDAgKQogICAgICAgICAgICAgcmV0ID0gMDsKICAgICAgICAgaWYgKCAh
cmV0ICYmIGRldmZuID09IHBkZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRl
diwgZHJoZCkgPiAwICkKQEAgLTE2NjYsNyArMTY3OCw4IEBAIHN0YXRpYyBp
bnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAg
ICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7
CiAKICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUo
ZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRldiwgbW9kZSk7Cisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYs
IGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGUpOwogICAgICAgICBp
ZiAoIHJldCA8IDAgKQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIHBy
ZXZfcHJlc2VudCA9IHJldDsKQEAgLTE2OTQsNyArMTcwNyw4IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAg
ICovCiAgICAgICAgIGlmICggcmV0ID49IDAgKQogICAgICAgICAgICAgcmV0
ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5p
b21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIE5VTEwsIG1vZGUpOworICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgZG9tYWlu
LT5kb21haW5faWQsIHBnZF9tYWRkciwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGUpOwogCiAgICAgICAgIC8q
CiAgICAgICAgICAqIERldmljZXMgYmVoaW5kIFBDSWUtdG8tUENJL1BDSXgg
YnJpZGdlIG1heSBnZW5lcmF0ZSBkaWZmZXJlbnQKQEAgLTE3MDksNyArMTcy
Myw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1
Y3QKICAgICAgICAgaWYgKCAhcmV0ICYmIHBkZXZfdHlwZShzZWcsIGJ1cywg
ZGV2Zm4pID09IERFVl9UWVBFX1BDSWUyUENJX0JSSURHRSAmJgogICAgICAg
ICAgICAgIChzZWNidXMgIT0gcGRldi0+YnVzIHx8IHBkZXYtPmRldmZuICE9
IDApICkKICAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBp
bmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIHNlY2J1cywgMCwKLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEws
IG1vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgTlVMTCwgZG9tYWluLT5kb21haW5faWQsIHBnZF9tYWRkciwK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IG1vZGUpOwogCiAgICAgICAgIGlmICggcmV0ICkKICAgICAgICAgewpAQCAt
MTczNywxNCArMTc1MiwxNCBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0
X21hcHBpbmcoc3RydWN0CiBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KAogICAgIHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICBzdHJ1Y3QgdnRk
X2lvbW11ICppb21tdSwKLSAgICB1OCBidXMsIHU4IGRldmZuKQorICAgIHVp
bnQ4X3QgYnVzLCB1aW50OF90IGRldmZuLCBkb21pZF90IGRvbWlkKQogewog
ICAgIHN0cnVjdCBjb250ZXh0X2VudHJ5ICpjb250ZXh0LCAqY29udGV4dF9l
bnRyaWVzOwogICAgIHU2NCBtYWRkcjsKICAgICBpbnQgaW9tbXVfZG9taWQs
IHJjLCByZXQ7CiAgICAgYm9vbF90IGZsdXNoX2Rldl9pb3RsYjsKIAotICAg
IGlmICggUVVBUkFOVElORV9TS0lQKGRvbWFpbikgKQorICAgIGlmICggUVVB
UkFOVElORV9TS0lQKGRvbWFpbiwgZG9tX2lvbW11KGRvbWFpbiktPmFyY2gu
dnRkLnBnZF9tYWRkcikgKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIEFT
U0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKQEAgLTE3OTgsNyArMTgxMyw3IEBA
IGludCBkb21haW5fY29udGV4dF91bm1hcF9vbmUoCiAgICAgdW5tYXBfdnRk
X2RvbWFpbl9wYWdlKGNvbnRleHRfZW50cmllcyk7CiAKICAgICBpZiAoICFp
b21tdS0+ZHJoZC0+c2VnbWVudCAmJiAhcmMgKQotICAgICAgICByYyA9IG1l
X3dpZmlfcXVpcmsoZG9tYWluLCBidXMsIGRldmZuLCBVTk1BUF9NRV9QSEFO
VE9NX0ZVTkMpOworICAgICAgICByYyA9IG1lX3dpZmlfcXVpcmsoZG9tYWlu
LCBidXMsIGRldmZuLCBkb21pZCwgMCwgVU5NQVBfTUVfUEhBTlRPTV9GVU5D
KTsKIAogICAgIGlmICggcmMgJiYgIWlzX2hhcmR3YXJlX2RvbWFpbihkb21h
aW4pICYmIGRvbWFpbiAhPSBkb21faW8gKQogICAgIHsKQEAgLTE4NDUsNyAr
MTg2MCw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3Ry
dWN0IGQKICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAgICAg
ICBwcmludGsoVlREUFJFRklYICIlcGQ6UENJZTogdW5tYXAgJXBwXG4iLAog
ICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1
cywgZGV2Zm4pKTsKLSAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5t
YXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOworICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwg
YnVzLCBkZXZmbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgaWYgKCAhcmV0
ICYmIGRldmZuID09IHBkZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRldiwg
ZHJoZCkgPiAwICkKICAgICAgICAgICAgIGRpc2FibGVfYXRzX2RldmljZShw
ZGV2KTsKIApAQCAtMTg1OCw3ICsxODc0LDggQEAgc3RhdGljIGludCBkb21h
aW5fY29udGV4dF91bm1hcChzdHJ1Y3QgZAogICAgICAgICBpZiAoIGlvbW11
X2RlYnVnICkKICAgICAgICAgICAgIHByaW50ayhWVERQUkVGSVggIiVwZDpQ
Q0k6IHVubWFwICVwcFxuIiwKICAgICAgICAgICAgICAgICAgICBkb21haW4s
ICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7Ci0gICAgICAgIHJldCA9
IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMs
IGRldmZuKTsKKyAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBf
b25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4sCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCk7
CiAgICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIGJyZWFrOwogCkBA
IC0xODg0LDEyICsxOTAxLDE1IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfdW5tYXAoc3RydWN0IGQKICAgICAgICAgLyogUENJZSB0byBQQ0kvUENJ
eCBicmlkZ2UgKi8KICAgICAgICAgaWYgKCBwZGV2X3R5cGUoc2VnLCB0bXBf
YnVzLCB0bXBfZGV2Zm4pID09IERFVl9UWVBFX1BDSWUyUENJX0JSSURHRSAp
CiAgICAgICAgIHsKLSAgICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0
X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0bXBfZGV2Zm4p
OworICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25l
KGRvbWFpbiwgaW9tbXUsIHRtcF9idXMsIHRtcF9kZXZmbiwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRv
bWFpbl9pZCk7CiAgICAgICAgICAgICBpZiAoICFyZXQgKQotICAgICAgICAg
ICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4s
IGlvbW11LCBzZWNidXMsIDApOworICAgICAgICAgICAgICAgIHJldCA9IGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBzZWNidXMs
IDAsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKICAgICAgICAgfQogICAgICAg
ICBlbHNlIC8qIExlZ2FjeSBQQ0kgYnJpZGdlICovCi0gICAgICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21tdSwg
dG1wX2J1cywgdG1wX2RldmZuKTsKKyAgICAgICAgICAgIHJldCA9IGRvbWFp
bl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0bXBfYnVzLCB0
bXBfZGV2Zm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOwogCiAgICAgICAgIGJyZWFr
OwogCkBAIC0xODk5LDcgKzE5MTksOCBAQCBzdGF0aWMgaW50IGRvbWFpbl9j
b250ZXh0X3VubWFwKHN0cnVjdCBkCiAgICAgICAgIHJldHVybiAtRUlOVkFM
OwogICAgIH0KIAotICAgIGlmICggIXJldCAmJiAhUVVBUkFOVElORV9TS0lQ
KGRvbWFpbikgJiYgcGRldi0+ZGV2Zm4gPT0gZGV2Zm4gKQorICAgIGlmICgg
IXJldCAmJiBwZGV2LT5kZXZmbiA9PSBkZXZmbiAmJgorICAgICAgICAgIVFV
QVJBTlRJTkVfU0tJUChkb21haW4sIGRvbV9pb21tdShkb21haW4pLT5hcmNo
LnZ0ZC5wZ2RfbWFkZHIpICkKICAgICAgICAgY2hlY2tfY2xlYW51cF9kb21p
ZF9tYXAoZG9tYWluLCBwZGV2LCBpb21tdSk7CiAKICAgICByZXR1cm4gcmV0
OwpAQCAtMjUwNiw3ICsyNTI3LDcgQEAgc3RhdGljIGludCBjZl9jaGVjayBy
ZWFzc2lnbl9kZXZpY2Vfb3duZQogewogICAgIGludCByZXQ7CiAKLSAgICBp
ZiAoICFRVUFSQU5USU5FX1NLSVAodGFyZ2V0KSApCisgICAgaWYgKCAhUVVB
UkFOVElORV9TS0lQKHRhcmdldCwgZG9tX2lvbW11KHRhcmdldCktPmFyY2gu
dnRkLnBnZF9tYWRkcikgKQogICAgIHsKICAgICAgICAgaWYgKCAhaGFzX2Fy
Y2hfcGRldnModGFyZ2V0KSApCiAgICAgICAgICAgICB2bXhfcGlfaG9va3Nf
YXNzaWduKHRhcmdldCk7CkBAIC0yNTIyLDcgKzI1NDMsOCBAQCBzdGF0aWMg
aW50IGNmX2NoZWNrIHJlYXNzaWduX2RldmljZV9vd25lCiAKICAgICAgICAg
cmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZyh0YXJnZXQsIGRldmZuLCBw
ZGV2KTsKIAotICAgICAgICBpZiAoICFyZXQgJiYgIVFVQVJBTlRJTkVfU0tJ
UChzb3VyY2UpICYmIHBkZXYtPmRldmZuID09IGRldmZuICkKKyAgICAgICAg
aWYgKCAhcmV0ICYmIHBkZXYtPmRldmZuID09IGRldmZuICYmCisgICAgICAg
ICAgICAgIVFVQVJBTlRJTkVfU0tJUChzb3VyY2UsIGRvbV9pb21tdShzb3Vy
Y2UpLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIpICkKICAgICAgICAgewogICAgICAg
ICAgICAgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkcmhkID0gYWNw
aV9maW5kX21hdGNoZWRfZHJoZF91bml0KHBkZXYpOwogCi0tLSBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xdWlya3MuYworKysgYi94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC92dGQvcXVpcmtzLmMKQEAgLTQwOCw2ICs0MDgs
OCBAQCB2b2lkIF9faW5pdCBwbGF0Zm9ybV9xdWlya3NfaW5pdCh2b2lkKQog
CiBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBtYXBfbWVfcGhhbnRvbV9mdW5j
dGlvbihzdHJ1Y3QgZG9tYWluICpkb21haW4sCiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQg
ZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZG9taWRfdCBkb21pZCwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhZGRyX3QgcGdkX21hZGRy
LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdW5zaWduZWQgaW50IG1vZGUpCiB7CiAgICAgc3RydWN0IGFjcGlf
ZHJoZF91bml0ICpkcmhkOwpAQCAtNDIxLDE2ICs0MjMsMTcgQEAgc3RhdGlj
IGludCBfX211c3RfY2hlY2sgbWFwX21lX3BoYW50b21fZgogICAgIC8qIG1h
cCBvciB1bm1hcCBNRSBwaGFudG9tIGZ1bmN0aW9uICovCiAgICAgaWYgKCAh
KG1vZGUgJiBVTk1BUF9NRV9QSEFOVE9NX0ZVTkMpICkKICAgICAgICAgcmMg
PSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRyaGQtPmlv
bW11LCAwLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIFBDSV9ERVZGTihkZXYsIDcpLCBOVUxMLCBtb2RlKTsKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfREVWRk4oZGV2
LCA3KSwgTlVMTCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBkb21pZCwgcGdkX21hZGRyLCBtb2RlKTsKICAgICBlbHNlCiAg
ICAgICAgIHJjID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwg
ZHJoZC0+aW9tbXUsIDAsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIFBDSV9ERVZGTihkZXYsIDcpKTsKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgUENJX0RFVkZOKGRldiwgNyksIGRv
bWlkKTsKIAogICAgIHJldHVybiByYzsKIH0KIAogaW50IG1lX3dpZmlfcXVp
cmsoc3RydWN0IGRvbWFpbiAqZG9tYWluLCB1aW50OF90IGJ1cywgdWludDhf
dCBkZXZmbiwKLSAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBtb2Rl
KQorICAgICAgICAgICAgICAgICAgZG9taWRfdCBkb21pZCwgcGFkZHJfdCBw
Z2RfbWFkZHIsIHVuc2lnbmVkIGludCBtb2RlKQogewogICAgIHUzMiBpZDsK
ICAgICBpbnQgcmMgPSAwOwpAQCAtNDU0LDcgKzQ1Nyw3IEBAIGludCBtZV93
aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwKICAgICAgICAgICAg
IGNhc2UgMHg0MjNiODA4NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjNjODA4
NjoKICAgICAgICAgICAgIGNhc2UgMHg0MjNkODA4NjoKLSAgICAgICAgICAg
ICAgICByYyA9IG1hcF9tZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMywg
bW9kZSk7CisgICAgICAgICAgICAgICAgcmMgPSBtYXBfbWVfcGhhbnRvbV9m
dW5jdGlvbihkb21haW4sIDMsIGRvbWlkLCBwZ2RfbWFkZHIsIG1vZGUpOwog
ICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgZGVmYXVsdDoK
ICAgICAgICAgICAgICAgICBicmVhazsKQEAgLTQ4MCw3ICs0ODMsNyBAQCBp
bnQgbWVfd2lmaV9xdWlyayhzdHJ1Y3QgZG9tYWluICpkb21haW4sCiAgICAg
ICAgICAgICBjYXNlIDB4NDIzODgwODY6ICAgICAgICAvKiBQdW1hIFBlYWsg
Ki8KICAgICAgICAgICAgIGNhc2UgMHg0MjJiODA4NjoKICAgICAgICAgICAg
IGNhc2UgMHg0MjJjODA4NjoKLSAgICAgICAgICAgICAgICByYyA9IG1hcF9t
ZV9waGFudG9tX2Z1bmN0aW9uKGRvbWFpbiwgMjIsIG1vZGUpOworICAgICAg
ICAgICAgICAgIHJjID0gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oZG9tYWlu
LCAyMiwgZG9taWQsIHBnZF9tYWRkciwgbW9kZSk7CiAgICAgICAgICAgICAg
ICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAg
ICAgIGJyZWFrOwo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-08.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBwcmVwYXJlIGZvciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFn
ZSB0YWJsZXMgKHBhcnQgSUkpCgpSZXBsYWNlIHRoZSBwYXNzaW5nIG9mIHN0
cnVjdCBkb21haW4gKiBieSBkb21pZF90IGluIHByZXBhcmF0aW9uIG9mCnBl
ci1kZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcyBhbHNvIHJlcXVpcmlu
ZyBwZXItZGV2aWNlIHBzZXVkbwpkb21haW4gSURzLCB3aGljaCBhcmVuJ3Qg
Z29pbmcgdG8gYmUgYXNzb2NpYXRlZCB3aXRoIGFueSBzdHJ1Y3QgZG9tYWlu
Cmluc3RhbmNlcy4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkIChl
eGNlcHQgZm9yIHNsaWdodGx5IGFkanVzdGVkIGxvZyBtZXNzYWdlCnRleHQp
LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+
ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNv
bT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPgotLS0KdjY6IGNvbnRleHRfc2V0X2RvbWFpbl9pZCgpJ3Mg
QVNTRVJUKCkgY2hhbmdlIG1vdmVkIHRvIGEgbGF0ZXIgcGF0Y2guCnY1OiBO
ZXcuCgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUu
YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwpA
QCAtNzksMjggKzc5LDI4IEBAIHN0YXRpYyBkb21pZF90IGNvbnZlcnRfZG9t
aWQoY29uc3Qgc3RydWMKICAgICByZXR1cm4gIWNhcF9jYWNoaW5nX21vZGUo
aW9tbXUtPmNhcCkgPyBkb21pZCA6IH5kb21pZDsKIH0KIAotc3RhdGljIGlu
dCBkb21haW5faW9tbXVfZG9taWQoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB2
dGRfaW9tbXUgKmlvbW11KQorc3RhdGljIGludCBnZXRfaW9tbXVfZGlkKGRv
bWlkX3QgZG9taWQsIGNvbnN0IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LAor
ICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgd2FybikKIHsKICAgICB1
bnNpZ25lZCBpbnQgbnJfZG9tLCBpOwogCiAgICAgaWYgKCAhZG9taWRfbWFw
cGluZyhpb21tdSkgKQotICAgICAgICByZXR1cm4gY29udmVydF9kb21pZChp
b21tdSwgZC0+ZG9tYWluX2lkKTsKKyAgICAgICAgcmV0dXJuIGNvbnZlcnRf
ZG9taWQoaW9tbXUsIGRvbWlkKTsKIAogICAgIG5yX2RvbSA9IGNhcF9uZG9t
cyhpb21tdS0+Y2FwKTsKICAgICBpID0gZmluZF9maXJzdF9iaXQoaW9tbXUt
PmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsKICAgICB3aGlsZSAoIGkgPCBucl9k
b20gKQogICAgIHsKLSAgICAgICAgaWYgKCBpb21tdS0+ZG9taWRfbWFwW2ld
ID09IGQtPmRvbWFpbl9pZCApCisgICAgICAgIGlmICggaW9tbXUtPmRvbWlk
X21hcFtpXSA9PSBkb21pZCApCiAgICAgICAgICAgICByZXR1cm4gaTsKIAog
ICAgICAgICBpID0gZmluZF9uZXh0X2JpdChpb21tdS0+ZG9taWRfYml0bWFw
LCBucl9kb20sIGkgKyAxKTsKICAgICB9CiAKLSAgICBpZiAoICFkLT5pc19k
eWluZyApCisgICAgaWYgKCB3YXJuICkKICAgICAgICAgZHByaW50ayhYRU5M
T0dfRVJSIFZURFBSRUZJWCwKLSAgICAgICAgICAgICAgICAiQ2Fubm90IGdl
dCB2YWxpZCBpb21tdSAldSBkb21pZDogJXBkXG4iLAotICAgICAgICAgICAg
ICAgIGlvbW11LT5pbmRleCwgZCk7CisgICAgICAgICAgICAgICAgIk5vIHZh
bGlkIGlvbW11ICV1IGRvbWlkIGZvciBEb20lZFxuIiwKKyAgICAgICAgICAg
ICAgICBpb21tdS0+aW5kZXgsIGRvbWlkKTsKIAogICAgIHJldHVybiAtMTsK
IH0KQEAgLTEwOCw4ICsxMDgsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9pb21t
dV9kb21pZChjb25zdCBzdHJ1CiAjZGVmaW5lIERJRF9GSUVMRF9XSURUSCAx
NgogI2RlZmluZSBESURfSElHSF9PRkZTRVQgOAogc3RhdGljIGludCBjb250
ZXh0X3NldF9kb21haW5faWQoc3RydWN0IGNvbnRleHRfZW50cnkgKmNvbnRl
eHQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBz
dHJ1Y3QgZG9tYWluICpkLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUpCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBkb21pZF90IGRvbWlkLCBzdHJ1Y3QgdnRk
X2lvbW11ICppb21tdSkKIHsKICAgICB1bnNpZ25lZCBpbnQgaTsKIApAQCAt
MTIwLDcgKzExOSw3IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWlu
X2lkKHN0cnVjdAogICAgICAgICB1bnNpZ25lZCBpbnQgbnJfZG9tID0gY2Fw
X25kb21zKGlvbW11LT5jYXApOwogCiAgICAgICAgIGkgPSBmaW5kX2ZpcnN0
X2JpdChpb21tdS0+ZG9taWRfYml0bWFwLCBucl9kb20pOwotICAgICAgICB3
aGlsZSAoIGkgPCBucl9kb20gJiYgaW9tbXUtPmRvbWlkX21hcFtpXSAhPSBk
LT5kb21haW5faWQgKQorICAgICAgICB3aGlsZSAoIGkgPCBucl9kb20gJiYg
aW9tbXUtPmRvbWlkX21hcFtpXSAhPSBkb21pZCApCiAgICAgICAgICAgICBp
ID0gZmluZF9uZXh0X2JpdChpb21tdS0+ZG9taWRfYml0bWFwLCBucl9kb20s
IGkgKyAxKTsKIAogICAgICAgICBpZiAoIGkgPj0gbnJfZG9tICkKQEAgLTEz
MSwyNiArMTMwLDI2IEBAIHN0YXRpYyBpbnQgY29udGV4dF9zZXRfZG9tYWlu
X2lkKHN0cnVjdAogICAgICAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VS
UiBWVERQUkVGSVgsICJJT01NVTogbm8gZnJlZSBkb21haW4gaWRcbiIpOwog
ICAgICAgICAgICAgICAgIHJldHVybiAtRUJVU1k7CiAgICAgICAgICAgICB9
Ci0gICAgICAgICAgICBpb21tdS0+ZG9taWRfbWFwW2ldID0gZC0+ZG9tYWlu
X2lkOworICAgICAgICAgICAgaW9tbXUtPmRvbWlkX21hcFtpXSA9IGRvbWlk
OwogICAgICAgICAgICAgc2V0X2JpdChpLCBpb21tdS0+ZG9taWRfYml0bWFw
KTsKICAgICAgICAgfQogICAgIH0KICAgICBlbHNlCi0gICAgICAgIGkgPSBj
b252ZXJ0X2RvbWlkKGlvbW11LCBkLT5kb21haW5faWQpOworICAgICAgICBp
ID0gY29udmVydF9kb21pZChpb21tdSwgZG9taWQpOwogCiAgICAgY29udGV4
dC0+aGkgJj0gfigoKDEgPDwgRElEX0ZJRUxEX1dJRFRIKSAtIDEpIDw8IERJ
RF9ISUdIX09GRlNFVCk7CiAgICAgY29udGV4dC0+aGkgfD0gKGkgJiAoKDEg
PDwgRElEX0ZJRUxEX1dJRFRIKSAtIDEpKSA8PCBESURfSElHSF9PRkZTRVQ7
CiAgICAgcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyB2b2lkIGNsZWFudXBfZG9t
aWRfbWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IHZ0ZF9pb21t
dSAqaW9tbXUpCitzdGF0aWMgdm9pZCBjbGVhbnVwX2RvbWlkX21hcChkb21p
ZF90IGRvbWlkLCBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkKIHsKICAgICBp
bnQgaW9tbXVfZG9taWQ7CiAKICAgICBpZiAoICFkb21pZF9tYXBwaW5nKGlv
bW11KSApCiAgICAgICAgIHJldHVybjsKIAotICAgIGlvbW11X2RvbWlkID0g
ZG9tYWluX2lvbW11X2RvbWlkKGRvbWFpbiwgaW9tbXUpOworICAgIGlvbW11
X2RvbWlkID0gZ2V0X2lvbW11X2RpZChkb21pZCwgaW9tbXUsIGZhbHNlKTsK
IAogICAgIGlmICggaW9tbXVfZG9taWQgPj0gMCApCiAgICAgewpAQCAtMTkw
LDcgKzE4OSw3IEBAIHN0YXRpYyBib29sIGFueV9wZGV2X2JlaGluZF9pb21t
dShjb25zdAogICogSWYgbm8gb3RoZXIgZGV2aWNlcyB1bmRlciB0aGUgc2Ft
ZSBpb21tdSBvd25lZCBieSB0aGlzIGRvbWFpbiwKICAqIGNsZWFyIGlvbW11
IGluIGlvbW11X2JpdG1hcCBhbmQgY2xlYXIgZG9tYWluX2lkIGluIGRvbWlk
X2JpdG1hcC4KICAqLwotc3RhdGljIHZvaWQgY2hlY2tfY2xlYW51cF9kb21p
ZF9tYXAoc3RydWN0IGRvbWFpbiAqZCwKK3N0YXRpYyB2b2lkIGNoZWNrX2Ns
ZWFudXBfZG9taWRfbWFwKGNvbnN0IHN0cnVjdCBkb21haW4gKmQsCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg
cGNpX2RldiAqZXhjbHVkZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQogewpAQCAtMjA2
LDcgKzIwNSw3IEBAIHN0YXRpYyB2b2lkIGNoZWNrX2NsZWFudXBfZG9taWRf
bWFwKHN0cnUKICAgICBpZiAoICFmb3VuZCApCiAgICAgewogICAgICAgICBj
bGVhcl9iaXQoaW9tbXUtPmluZGV4LCBkb21faW9tbXUoZCktPmFyY2gudnRk
LmlvbW11X2JpdG1hcCk7Ci0gICAgICAgIGNsZWFudXBfZG9taWRfbWFwKGQs
IGlvbW11KTsKKyAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZC0+ZG9tYWlu
X2lkLCBpb21tdSk7CiAgICAgfQogfQogCkBAIC02NjcsNyArNjY2LDcgQEAg
c3RhdGljIGludCBfX211c3RfY2hlY2sgaW9tbXVfZmx1c2hfaW90bAogICAg
ICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgZmx1c2hfZGV2X2lvdGxi
ID0gISFmaW5kX2F0c19kZXZfZHJoZChpb21tdSk7Ci0gICAgICAgIGlvbW11
X2RvbWlkPSBkb21haW5faW9tbXVfZG9taWQoZCwgaW9tbXUpOworICAgICAg
ICBpb21tdV9kb21pZCA9IGdldF9pb21tdV9kaWQoZC0+ZG9tYWluX2lkLCBp
b21tdSwgIWQtPmlzX2R5aW5nKTsKICAgICAgICAgaWYgKCBpb21tdV9kb21p
ZCA9PSAtMSApCiAgICAgICAgICAgICBjb250aW51ZTsKIApAQCAtMTQ1Myw3
ICsxNDUyLDcgQEAgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKAog
ICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsK
ICAgICB9CiAKLSAgICByYyA9IGNvbnRleHRfc2V0X2RvbWFpbl9pZCgmbGN0
eHQsIGRvbWFpbiwgaW9tbXUpOworICAgIHJjID0gY29udGV4dF9zZXRfZG9t
YWluX2lkKCZsY3R4dCwgZG9taWQsIGlvbW11KTsKICAgICBpZiAoIHJjICkK
ICAgICB7CiAgICAgdW5sb2NrOgpAQCAtMTc4MCw3ICsxNzc5LDcgQEAgaW50
IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZSgKICAgICBjb250ZXh0X2NsZWFy
X2VudHJ5KCpjb250ZXh0KTsKICAgICBpb21tdV9zeW5jX2NhY2hlKGNvbnRl
eHQsIHNpemVvZihzdHJ1Y3QgY29udGV4dF9lbnRyeSkpOwogCi0gICAgaW9t
bXVfZG9taWQ9IGRvbWFpbl9pb21tdV9kb21pZChkb21haW4sIGlvbW11KTsK
KyAgICBpb21tdV9kb21pZCA9IGdldF9pb21tdV9kaWQoZG9taWQsIGlvbW11
LCAhZG9tYWluLT5pc19keWluZyk7CiAgICAgaWYgKCBpb21tdV9kb21pZCA9
PSAtMSApCiAgICAgewogICAgICAgICBzcGluX3VubG9jaygmaW9tbXUtPmxv
Y2spOwpAQCAtMTk0OCw3ICsxOTQ3LDcgQEAgc3RhdGljIHZvaWQgY2ZfY2hl
Y2sgaW9tbXVfZG9tYWluX3RlYXJkbwogICAgIEFTU0VSVCghaGQtPmFyY2gu
dnRkLnBnZF9tYWRkcik7CiAKICAgICBmb3JfZWFjaF9kcmhkX3VuaXQgKCBk
cmhkICkKLSAgICAgICAgY2xlYW51cF9kb21pZF9tYXAoZCwgZHJoZC0+aW9t
bXUpOworICAgICAgICBjbGVhbnVwX2RvbWlkX21hcChkLT5kb21haW5faWQs
IGRyaGQtPmlvbW11KTsKIAogICAgIFhGUkVFKGhkLT5hcmNoLnZ0ZC5pb21t
dV9iaXRtYXApOwogfQo=

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-09.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IG1haW50YWluIGEgcGVyLWRldmljZSBwc2V1ZG8gZG9t
YWluIElECgpJbiBvcmRlciB0byBzdWJzZXF1ZW50bHkgZW5hYmxlIHBlci1k
ZXZpY2UgcXVhcmFudGluZSBwYWdlIHRhYmxlcywgd2UnbGwKbmVlZCBkb21h
aW4tSUQtbGlrZSBpZGVudGlmaWVycyB0byBiZSBpbnNlcnRlZCBpbiB0aGUg
cmVzcGVjdGl2ZSBkZXZpY2UKKEFNRCkgb3IgY29udGV4dCAoSW50ZWwpIHRh
YmxlIGVudHJpZXMgYWxvbmdzaWRlIHRoZSBwZXItZGV2aWNlIHBhZ2UKdGFi
bGUgcm9vdCBhZGRyZXNzZXMuCgpNYWtlIHVzZSBvZiAicmVhbCIgZG9tYWlu
IElEcyBvY2N1cHlpbmcgb25seSBoYWxmIG9mIHRoZSB2YWx1ZSByYW5nZQpj
b3ZlcmFibGUgYnkgZG9taWRfdC4KCk5vdGUgdGhhdCBpbiBWVC1kJ3MgaW9t
bXVfYWxsb2MoKSBJIGRpZG4ndCB3YW50IHRvIGludHJvZHVjZSBuZXcgbWVt
b3J5CmxlYWtzIGluIGNhc2Ugb2YgZXJyb3IsIGJ1dCBleGlzdGluZyBvbmVz
IGRvbid0IGdldCBwbHVnZ2VkIC0gdGhhdCdsbCBiZQp0aGUgc3ViamVjdCBv
ZiBhIGxhdGVyIGNoYW5nZS4KClRoZSBWVC1kIGNoYW5nZXMgYXJlIHNsaWdo
dGx5IGFzeW1tZXRyaWMsIGJ1dCB0aGlzIHdheSB3ZSBjYW4gYXZvaWQKYXNz
aWduaW5nIHBzZXVkbyBkb21haW4gSURzIHRvIGRldmljZXMgd2hpY2ggd291
bGQgbmV2ZXIgYmUgbWFwcGVkIHdoaWxlCnN0aWxsIGF2b2lkaW5nIHRvIGFk
ZCBhIG5ldyBwYXJhbWV0ZXIgdG8gZG9tYWluX2NvbnRleHRfdW5tYXAoKS4K
ClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpS
ZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+
ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4KLS0tCnY3OiBSZS1iYXNlLgp2NjogQWxzbyBhZGp1c3QgbnJf
ZG9tIHJhbmdlIGNoZWNrIGluIGlvbW11X2FsbG9jKCkuCnY1OiBOZXcuCgot
LS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vaW9tbXUuaAorKysgYi94
ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vaW9tbXUuaApAQCAtMTQxLDYgKzE0
MSwxMCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW9tbXVfc3luY19jYWNoZShj
b25zCiAgICAgICAgIGNhY2hlX3dyaXRlYmFjayhhZGRyLCBzaXplKTsKIH0K
IAordW5zaWduZWQgbG9uZyAqaW9tbXVfaW5pdF9kb21pZChkb21pZF90IHJl
c2VydmUpOworZG9taWRfdCBpb21tdV9hbGxvY19kb21pZCh1bnNpZ25lZCBs
b25nICptYXApOwordm9pZCBpb21tdV9mcmVlX2RvbWlkKGRvbWlkX3QgZG9t
aWQsIHVuc2lnbmVkIGxvbmcgKm1hcCk7CisKIGludCBfX211c3RfY2hlY2sg
aW9tbXVfZnJlZV9wZ3RhYmxlcyhzdHJ1Y3QgZG9tYWluICpkKTsKIHN0cnVj
dCBkb21haW5faW9tbXU7CiBzdHJ1Y3QgcGFnZV9pbmZvICpfX211c3RfY2hl
Y2sgaW9tbXVfYWxsb2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluX2lvbW11ICpo
ZCk7Ci0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9wY2kuaAorKysg
Yi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vcGNpLmgKQEAgLTEzLDYgKzEz
LDEyIEBACiAKIHN0cnVjdCBhcmNoX3BjaV9kZXYgewogICAgIHZtYXNrX3Qg
dXNlZF92ZWN0b3JzOworICAgIC8qCisgICAgICogVGhlc2UgZmllbGRzIGFy
ZSAoZGUpaW5pdGlhbGl6ZWQgdW5kZXIgcGNpZGV2cy1sb2NrLiBPdGhlciB1
c2VzIG9mCisgICAgICogdGhlbSBkb24ndCByYWNlIChkZSlpbml0aWFsaXph
dGlvbiBhbmQgaGVuY2UgZG9uJ3Qgc3RyaWN0bHkgbmVlZCBhbnkKKyAgICAg
KiBsb2NraW5nLgorICAgICAqLworICAgIGRvbWlkX3QgcHNldWRvX2RvbWlk
OwogfTsKIAogaW50IHBjaV9jb25mX3dyaXRlX2ludGVyY2VwdCh1bnNpZ25l
ZCBpbnQgc2VnLCB1bnNpZ25lZCBpbnQgYmRmLApAQCAtMzYsNiArNDIsNiBA
QCBzdGF0aWMgYWx3YXlzX2lubGluZSBib29sIGlzX3BjaV9wYXNzdGhyCiAg
ICAgcmV0dXJuIHRydWU7CiB9CiAKLXN0YXRpYyBpbmxpbmUgdm9pZCBhcmNo
X3BjaV9pbml0X3BkZXYoc3RydWN0IHBjaV9kZXYgKnBkZXYpIHt9Cit2b2lk
IGFyY2hfcGNpX2luaXRfcGRldihzdHJ1Y3QgcGNpX2RldiAqcGRldik7CiAK
ICNlbmRpZiAvKiBfX1g4Nl9QQ0lfSF9fICovCi0tLSBhL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL2FtZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL2FtZC9pb21tdS5oCkBAIC05Niw2ICs5Niw3IEBAIHN0cnVj
dCBhbWRfaW9tbXUgewogICAgIHN0cnVjdCByaW5nX2J1ZmZlciBjbWRfYnVm
ZmVyOwogICAgIHN0cnVjdCByaW5nX2J1ZmZlciBldmVudF9sb2c7CiAgICAg
c3RydWN0IHJpbmdfYnVmZmVyIHBwcl9sb2c7CisgICAgdW5zaWduZWQgbG9u
ZyAqZG9taWRfbWFwOwogCiAgICAgaW50IGV4Y2x1c2lvbl9lbmFibGU7CiAg
ICAgaW50IGV4Y2x1c2lvbl9hbGxvd19hbGw7Ci0tLSBhL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9kZXRlY3QuYworKysgYi94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfZGV0ZWN0LmMKQEAgLTIyMyw2
ICsyMjMsMTEgQEAgaW50IF9faW5pdCBhbWRfaW9tbXVfZGV0ZWN0X29uZV9h
Y3BpKAogICAgIGlmICggcnQgKQogICAgICAgICBnb3RvIG91dDsKIAorICAg
IGlvbW11LT5kb21pZF9tYXAgPSBpb21tdV9pbml0X2RvbWlkKERPTUlEX0lO
VkFMSUQpOworICAgIHJ0ID0gLUVOT01FTTsKKyAgICBpZiAoICFpb21tdS0+
ZG9taWRfbWFwICkKKyAgICAgICAgZ290byBvdXQ7CisKICAgICBydCA9IHBj
aV9yb19kZXZpY2UoaW9tbXUtPnNlZywgYnVzLCBQQ0lfREVWRk4oZGV2LCBm
dW5jKSk7CiAgICAgaWYgKCBydCApCiAgICAgICAgIHByaW50ayhYRU5MT0df
RVJSICJDb3VsZCBub3QgbWFyayBjb25maWcgc3BhY2Ugb2YgJXBwIHJlYWQt
b25seSAoJWQpXG4iLApAQCAtMjMzLDcgKzIzOCwxMCBAQCBpbnQgX19pbml0
IGFtZF9pb21tdV9kZXRlY3Rfb25lX2FjcGkoCiAKICBvdXQ6CiAgICAgaWYg
KCBydCApCisgICAgeworICAgICAgICB4ZnJlZShpb21tdS0+ZG9taWRfbWFw
KTsKICAgICAgICAgeGZyZWUoaW9tbXUpOworICAgIH0KIAogICAgIHJldHVy
biBydDsKIH0KLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3Bj
aV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9h
bWQvcGNpX2FtZF9pb21tdS5jCkBAIC01MzksNiArNTM5LDggQEAgc3RhdGlj
IGludCBjZl9jaGVjayBhbWRfaW9tbXVfYWRkX2RldmljZQogICAgIHN0cnVj
dCBhbWRfaW9tbXUgKmlvbW11OwogICAgIHUxNiBiZGY7CiAgICAgc3RydWN0
IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3M7CisgICAgYm9vbCBmcmVz
aF9kb21pZCA9IGZhbHNlOworICAgIGludCByZXQ7CiAKICAgICBpZiAoICFw
ZGV2LT5kb21haW4gKQogICAgICAgICByZXR1cm4gLUVJTlZBTDsKQEAgLTYw
Niw3ICs2MDgsMjIgQEAgc3RhdGljIGludCBjZl9jaGVjayBhbWRfaW9tbXVf
YWRkX2RldmljZQogICAgICAgICBBTURfSU9NTVVfV0FSTigiJXBkOiB1bml0
eSBtYXBwaW5nIGZhaWxlZCBmb3IgJXBwXG4iLAogICAgICAgICAgICAgICAg
ICAgICAgICBwZGV2LT5kb21haW4sICZwZGV2LT5zYmRmKTsKIAotICAgIHJl
dHVybiBhbWRfaW9tbXVfc2V0dXBfZG9tYWluX2RldmljZShwZGV2LT5kb21h
aW4sIGlvbW11LCBkZXZmbiwgcGRldik7CisgICAgaWYgKCBpb21tdV9xdWFy
YW50aW5lICYmIHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID09IERPTUlEX0lO
VkFMSUQgKQorICAgIHsKKyAgICAgICAgcGRldi0+YXJjaC5wc2V1ZG9fZG9t
aWQgPSBpb21tdV9hbGxvY19kb21pZChpb21tdS0+ZG9taWRfbWFwKTsKKyAg
ICAgICAgaWYgKCBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9PSBET01JRF9J
TlZBTElEICkKKyAgICAgICAgICAgIHJldHVybiAtRU5PU1BDOworICAgICAg
ICBmcmVzaF9kb21pZCA9IHRydWU7CisgICAgfQorCisgICAgcmV0ID0gYW1k
X2lvbW11X3NldHVwX2RvbWFpbl9kZXZpY2UocGRldi0+ZG9tYWluLCBpb21t
dSwgZGV2Zm4sIHBkZXYpOworICAgIGlmICggcmV0ICYmIGZyZXNoX2RvbWlk
ICkKKyAgICB7CisgICAgICAgIGlvbW11X2ZyZWVfZG9taWQocGRldi0+YXJj
aC5wc2V1ZG9fZG9taWQsIGlvbW11LT5kb21pZF9tYXApOworICAgICAgICBw
ZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlEX0lOVkFMSUQ7CisgICAg
fQorCisgICAgcmV0dXJuIHJldDsKIH0KIAogc3RhdGljIGludCBjZl9jaGVj
ayBhbWRfaW9tbXVfcmVtb3ZlX2RldmljZSh1OCBkZXZmbiwgc3RydWN0IHBj
aV9kZXYgKnBkZXYpCkBAIC02MzgsNiArNjU1LDkgQEAgc3RhdGljIGludCBj
Zl9jaGVjayBhbWRfaW9tbXVfcmVtb3ZlX2RldgogICAgICAgICBBTURfSU9N
TVVfV0FSTigiJXBkOiB1bml0eSB1bm1hcHBpbmcgZmFpbGVkIGZvciAlcHBc
biIsCiAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYtPmRvbWFpbiwgJnBk
ZXYtPnNiZGYpOwogCisgICAgaW9tbXVfZnJlZV9kb21pZChwZGV2LT5hcmNo
LnBzZXVkb19kb21pZCwgaW9tbXUtPmRvbWlkX21hcCk7CisgICAgcGRldi0+
YXJjaC5wc2V1ZG9fZG9taWQgPSBET01JRF9JTlZBTElEOworCiAgICAgaWYg
KCBhbWRfaW9tbXVfcGVyZGV2X2ludHJlbWFwICYmCiAgICAgICAgICBpdnJz
X21hcHBpbmdzW2JkZl0uZHRlX3JlcXVlc3Rvcl9pZCA9PSBiZGYgJiYKICAg
ICAgICAgIGl2cnNfbWFwcGluZ3NbYmRmXS5pbnRyZW1hcF90YWJsZSApCi0t
LSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jCisrKyBiL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jCkBAIC0xMzQyLDkgKzEzNDIsMTQg
QEAgc3RhdGljIGludCBjZl9jaGVjayBfZHVtcF9wY2lfZGV2aWNlcyhzdAog
CiAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIHBkZXYsICZwc2VnLT5hbGxk
ZXZzX2xpc3QsIGFsbGRldnNfbGlzdCApCiAgICAgewotICAgICAgICBwcmlu
dGsoIiVwcCAtICVwZCAtIG5vZGUgJS0zZCIsCi0gICAgICAgICAgICAgICAm
cGRldi0+c2JkZiwgcGRldi0+ZG9tYWluLAotICAgICAgICAgICAgICAgKHBk
ZXYtPm5vZGUgIT0gTlVNQV9OT19OT0RFKSA/IHBkZXYtPm5vZGUgOiAtMSk7
CisgICAgICAgIHByaW50aygiJXBwIC0gIiwgJnBkZXYtPnNiZGYpOworI2lm
ZGVmIENPTkZJR19YODYKKyAgICAgICAgaWYgKCBwZGV2LT5kb21haW4gPT0g
ZG9tX2lvICkKKyAgICAgICAgICAgIHByaW50aygiRG9tSU86JXgiLCBwZGV2
LT5hcmNoLnBzZXVkb19kb21pZCk7CisgICAgICAgIGVsc2UKKyNlbmRpZgor
ICAgICAgICAgICAgcHJpbnRrKCIlcGQiLCBwZGV2LT5kb21haW4pOworICAg
ICAgICBwcmludGsoIiAtIG5vZGUgJS0zZCIsIChwZGV2LT5ub2RlICE9IE5V
TUFfTk9fTk9ERSkgPyBwZGV2LT5ub2RlIDogLTEpOwogICAgICAgICBwZGV2
X2R1bXBfbXNpKHBkZXYpOwogICAgICAgICBwcmludGsoIlxuIik7CiAgICAg
fQotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwor
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwpAQCAt
MjIsNiArMjIsNyBAQAogI2luY2x1ZGUgPHhlbi9zY2hlZC5oPgogI2luY2x1
ZGUgPHhlbi94bWFsbG9jLmg+CiAjaW5jbHVkZSA8eGVuL2RvbWFpbl9wYWdl
Lmg+CisjaW5jbHVkZSA8eGVuL2Vyci5oPgogI2luY2x1ZGUgPHhlbi9pb2Nh
cC5oPgogI2luY2x1ZGUgPHhlbi9pb21tdS5oPgogI2luY2x1ZGUgPHhlbi9u
dW1hLmg+CkBAIC0xMTk5LDYgKzEyMDAsOCBAQCBpbnQgX19pbml0IGlvbW11
X2FsbG9jKHN0cnVjdCBhY3BpX2RyaGRfCiB7CiAgICAgc3RydWN0IHZ0ZF9p
b21tdSAqaW9tbXU7CiAgICAgdW5zaWduZWQgaW50IHNhZ2F3LCBhZ2F3ID0g
MCwgbnJfZG9tOworICAgIGRvbWlkX3QgcmVzZXJ2ZWRfZG9taWQgPSBET01J
RF9JTlZBTElEOworICAgIGludCByYzsKIAogICAgIGlvbW11ID0geHphbGxv
YyhzdHJ1Y3QgdnRkX2lvbW11KTsKICAgICBpZiAoIGlvbW11ID09IE5VTEwg
KQpAQCAtMTI2OSw3ICsxMjcyLDcgQEAgaW50IF9faW5pdCBpb21tdV9hbGxv
YyhzdHJ1Y3QgYWNwaV9kcmhkXwogCiAgICAgbnJfZG9tID0gY2FwX25kb21z
KGlvbW11LT5jYXApOwogCi0gICAgaWYgKCBucl9kb20gPD0gRE9NSURfTUFT
SyArIGNhcF9jYWNoaW5nX21vZGUoaW9tbXUtPmNhcCkgKQorICAgIGlmICgg
bnJfZG9tIDw9IERPTUlEX01BU0sgKiAyICsgY2FwX2NhY2hpbmdfbW9kZShp
b21tdS0+Y2FwKSApCiAgICAgewogICAgICAgICAvKiBBbGxvY2F0ZSBkb21h
aW4gaWQgKGJpdCkgbWFwcy4gKi8KICAgICAgICAgaW9tbXUtPmRvbWlkX2Jp
dG1hcCA9IHh6YWxsb2NfYXJyYXkodW5zaWduZWQgbG9uZywKQEAgLTEyOTMs
OSArMTI5NiwyNCBAQCBpbnQgX19pbml0IGlvbW11X2FsbG9jKHN0cnVjdCBh
Y3BpX2RyaGRfCiAgICAgICAgIC8qIERvbid0IGxlYXZlIGRhbmdsaW5nIE5V
TEwgcG9pbnRlcnMuICovCiAgICAgICAgIGlvbW11LT5kb21pZF9iaXRtYXAg
PSBaRVJPX0JMT0NLX1BUUjsKICAgICAgICAgaW9tbXUtPmRvbWlkX21hcCA9
IFpFUk9fQkxPQ0tfUFRSOworCisgICAgICAgIC8qCisgICAgICAgICAqIElm
IENhY2hpbmcgbW9kZSBpcyBzZXQsIHRoZW4gaW52YWxpZCB0cmFuc2xhdGlv
bnMgYXJlIHRhZ2dlZAorICAgICAgICAgKiB3aXRoIGRvbWFpbiBpZCAwLiBI
ZW5jZSByZXNlcnZlIHRoZSBJRCB0YWtpbmcgdXAgYml0L3Nsb3QgMC4KKyAg
ICAgICAgICovCisgICAgICAgIHJlc2VydmVkX2RvbWlkID0gY29udmVydF9k
b21pZChpb21tdSwgMCkgPzogRE9NSURfSU5WQUxJRDsKICAgICB9CiAKKyAg
ICBpb21tdS0+cHNldWRvX2RvbWlkX21hcCA9IGlvbW11X2luaXRfZG9taWQo
cmVzZXJ2ZWRfZG9taWQpOworICAgIHJjID0gLUVOT01FTTsKKyAgICBpZiAo
ICFpb21tdS0+cHNldWRvX2RvbWlkX21hcCApCisgICAgICAgIGdvdG8gZnJl
ZTsKKwogICAgIHJldHVybiAwOworCisgZnJlZToKKyAgICBpb21tdV9mcmVl
KGRyaGQpOworICAgIHJldHVybiByYzsKIH0KIAogdm9pZCBfX2luaXQgaW9t
bXVfZnJlZShzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQpCkBAIC0xMzE4
LDYgKzEzMzYsNyBAQCB2b2lkIF9faW5pdCBpb21tdV9mcmVlKHN0cnVjdCBh
Y3BpX2RyaGRfCiAKICAgICB4ZnJlZShpb21tdS0+ZG9taWRfYml0bWFwKTsK
ICAgICB4ZnJlZShpb21tdS0+ZG9taWRfbWFwKTsKKyAgICB4ZnJlZShpb21t
dS0+cHNldWRvX2RvbWlkX21hcCk7CiAKICAgICBpZiAoIGlvbW11LT5tc2ku
aXJxID49IDAgKQogICAgICAgICBkZXN0cm95X2lycShpb21tdS0+bXNpLmly
cSk7CkBAIC0xNTg4LDggKzE2MDcsOCBAQCBpbnQgZG9tYWluX2NvbnRleHRf
bWFwcGluZ19vbmUoCiAgICAgcmV0dXJuIHJjID86IHBkZXYgJiYgcHJldl9k
b207CiB9CiAKLXN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3Ry
dWN0IGRvbWFpbiAqZCwgdWludDhfdCBkZXZmbiwKLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYpOworc3Rh
dGljIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZG9tYWluX2NvbnRl
eHRfdW5tYXAoCisgICAgc3RydWN0IGRvbWFpbiAqZCwgdWludDhfdCBkZXZm
biwgc3RydWN0IHBjaV9kZXYgKnBkZXYpOwogCiBzdGF0aWMgaW50IGRvbWFp
bl9jb250ZXh0X21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZG9tYWluLCB1OCBk
ZXZmbiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1
Y3QgcGNpX2RldiAqcGRldikKQEAgLTE1OTcsNiArMTYxNiw3IEBAIHN0YXRp
YyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICBjb25z
dCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQgPSBhY3BpX2ZpbmRfbWF0
Y2hlZF9kcmhkX3VuaXQocGRldik7CiAgICAgY29uc3Qgc3RydWN0IGFjcGlf
cm1ycl91bml0ICpybXJyOwogICAgIHBhZGRyX3QgcGdkX21hZGRyID0gZG9t
X2lvbW11KGRvbWFpbiktPmFyY2gudnRkLnBnZF9tYWRkcjsKKyAgICBkb21p
ZF90IG9yaWdfZG9taWQgPSBwZGV2LT5hcmNoLnBzZXVkb19kb21pZDsKICAg
ICBpbnQgcmV0ID0gMDsKICAgICB1bnNpZ25lZCBpbnQgaSwgbW9kZSA9IDA7
CiAgICAgdWludDE2X3Qgc2VnID0gcGRldi0+c2VnLCBiZGY7CkBAIC0xNjU1
LDYgKzE2NzUsMTQgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBw
aW5nKHN0cnVjdAogICAgICAgICBpZiAoICFkcmhkICkKICAgICAgICAgICAg
IHJldHVybiAtRU5PREVWOwogCisgICAgICAgIGlmICggaW9tbXVfcXVhcmFu
dGluZSAmJiBvcmlnX2RvbWlkID09IERPTUlEX0lOVkFMSUQgKQorICAgICAg
ICB7CisgICAgICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9Cisg
ICAgICAgICAgICAgICAgaW9tbXVfYWxsb2NfZG9taWQoZHJoZC0+aW9tbXUt
PnBzZXVkb19kb21pZF9tYXApOworICAgICAgICAgICAgaWYgKCBwZGV2LT5h
cmNoLnBzZXVkb19kb21pZCA9PSBET01JRF9JTlZBTElEICkKKyAgICAgICAg
ICAgICAgICByZXR1cm4gLUVOT1NQQzsKKyAgICAgICAgfQorCiAgICAgICAg
IGlmICggaW9tbXVfZGVidWcgKQogICAgICAgICAgICAgcHJpbnRrKFZURFBS
RUZJWCAiJXBkOlBDSWU6IG1hcCAlcHBcbiIsCiAgICAgICAgICAgICAgICAg
ICAgZG9tYWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbikpOwpAQCAt
MTY3Miw2ICsxNzAwLDE0IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRf
bWFwcGluZyhzdHJ1Y3QKICAgICAgICAgaWYgKCAhZHJoZCApCiAgICAgICAg
ICAgICByZXR1cm4gLUVOT0RFVjsKIAorICAgICAgICBpZiAoIGlvbW11X3F1
YXJhbnRpbmUgJiYgb3JpZ19kb21pZCA9PSBET01JRF9JTlZBTElEICkKKyAg
ICAgICAgeworICAgICAgICAgICAgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQg
PQorICAgICAgICAgICAgICAgIGlvbW11X2FsbG9jX2RvbWlkKGRyaGQtPmlv
bW11LT5wc2V1ZG9fZG9taWRfbWFwKTsKKyAgICAgICAgICAgIGlmICggcGRl
di0+YXJjaC5wc2V1ZG9fZG9taWQgPT0gRE9NSURfSU5WQUxJRCApCisgICAg
ICAgICAgICAgICAgcmV0dXJuIC1FTk9TUEM7CisgICAgICAgIH0KKwogICAg
ICAgICBpZiAoIGlvbW11X2RlYnVnICkKICAgICAgICAgICAgIHByaW50ayhW
VERQUkVGSVggIiVwZDpQQ0k6IG1hcCAlcHBcbiIsCiAgICAgICAgICAgICAg
ICAgICAgZG9tYWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbikpOwpA
QCAtMTc0NSw2ICsxNzgxLDEzIEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRl
eHRfbWFwcGluZyhzdHJ1Y3QKICAgICBpZiAoICFyZXQgJiYgZGV2Zm4gPT0g
cGRldi0+ZGV2Zm4gKQogICAgICAgICBwY2lfdnRkX3F1aXJrKHBkZXYpOwog
CisgICAgaWYgKCByZXQgJiYgZHJoZCAmJiBvcmlnX2RvbWlkID09IERPTUlE
X0lOVkFMSUQgKQorICAgIHsKKyAgICAgICAgaW9tbXVfZnJlZV9kb21pZChw
ZGV2LT5hcmNoLnBzZXVkb19kb21pZCwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICBkcmhkLT5pb21tdS0+cHNldWRvX2RvbWlkX21hcCk7CisgICAgICAg
IHBkZXYtPmFyY2gucHNldWRvX2RvbWlkID0gRE9NSURfSU5WQUxJRDsKKyAg
ICB9CisKICAgICByZXR1cm4gcmV0OwogfQogCkBAIC0xODMwLDggKzE4NzMs
MTAgQEAgaW50IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZSgKICAgICByZXR1
cm4gcmM7CiB9CiAKLXN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAo
c3RydWN0IGRvbWFpbiAqZG9tYWluLCB1OCBkZXZmbiwKLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYpCitz
dGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkb21haW5fY29u
dGV4dF91bm1hcCgKKyAgICBzdHJ1Y3QgZG9tYWluICpkb21haW4sCisgICAg
dWludDhfdCBkZXZmbiwKKyAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldikKIHsK
ICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQgPSBhY3Bp
X2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CiAgICAgc3RydWN0IHZ0
ZF9pb21tdSAqaW9tbXUgPSBkcmhkID8gZHJoZC0+aW9tbXUgOiBOVUxMOwpA
QCAtMTg0NSwxNiArMTg5MCwxNiBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250
ZXh0X3VubWFwKHN0cnVjdCBkCiAgICAgICAgIGlmICggaW9tbXVfZGVidWcg
KQogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiJXBkOkhvc3Ricmlk
Z2U6IHNraXAgJXBwIHVubWFwXG4iLAogICAgICAgICAgICAgICAgICAgIGRv
bWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pKTsKLSAgICAgICAg
cmV0dXJuIGlzX2hhcmR3YXJlX2RvbWFpbihkb21haW4pID8gMCA6IC1FUEVS
TTsKKyAgICAgICAgcmV0dXJuIEVSUl9QVFIoaXNfaGFyZHdhcmVfZG9tYWlu
KGRvbWFpbikgPyAwIDogLUVQRVJNKTsKIAogICAgIGNhc2UgREVWX1RZUEVf
UENJZV9CUklER0U6CiAgICAgY2FzZSBERVZfVFlQRV9QQ0llMlBDSV9CUklE
R0U6CiAgICAgY2FzZSBERVZfVFlQRV9MRUdBQ1lfUENJX0JSSURHRToKLSAg
ICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiBFUlJfUFRSKDApOwog
CiAgICAgY2FzZSBERVZfVFlQRV9QQ0llX0VORFBPSU5UOgogICAgICAgICBp
ZiAoICFpb21tdSApCi0gICAgICAgICAgICByZXR1cm4gLUVOT0RFVjsKKyAg
ICAgICAgICAgIHJldHVybiBFUlJfUFRSKC1FTk9ERVYpOwogCiAgICAgICAg
IGlmICggaW9tbXVfZGVidWcgKQogICAgICAgICAgICAgcHJpbnRrKFZURFBS
RUZJWCAiJXBkOlBDSWU6IHVubWFwICVwcFxuIiwKQEAgLTE4NjgsNyArMTkx
Myw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfdW5tYXAoc3RydWN0
IGQKIAogICAgIGNhc2UgREVWX1RZUEVfUENJOgogICAgICAgICBpZiAoICFp
b21tdSApCi0gICAgICAgICAgICByZXR1cm4gLUVOT0RFVjsKKyAgICAgICAg
ICAgIHJldHVybiBFUlJfUFRSKC1FTk9ERVYpOwogCiAgICAgICAgIGlmICgg
aW9tbXVfZGVidWcgKQogICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAi
JXBkOlBDSTogdW5tYXAgJXBwXG4iLApAQCAtMTkxNSwxNCArMTk2MCwxNCBA
QCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X3VubWFwKHN0cnVjdCBkCiAg
ICAgZGVmYXVsdDoKICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSIFZURFBS
RUZJWCwgIiVwZDp1bmtub3duKCV1KTogJXBwXG4iLAogICAgICAgICAgICAg
ICAgIGRvbWFpbiwgcGRldi0+dHlwZSwgJlBDSV9TQkRGMyhzZWcsIGJ1cywg
ZGV2Zm4pKTsKLSAgICAgICAgcmV0dXJuIC1FSU5WQUw7CisgICAgICAgIHJl
dHVybiBFUlJfUFRSKC1FSU5WQUwpOwogICAgIH0KIAogICAgIGlmICggIXJl
dCAmJiBwZGV2LT5kZXZmbiA9PSBkZXZmbiAmJgogICAgICAgICAgIVFVQVJB
TlRJTkVfU0tJUChkb21haW4sIGRvbV9pb21tdShkb21haW4pLT5hcmNoLnZ0
ZC5wZ2RfbWFkZHIpICkKICAgICAgICAgY2hlY2tfY2xlYW51cF9kb21pZF9t
YXAoZG9tYWluLCBwZGV2LCBpb21tdSk7CiAKLSAgICByZXR1cm4gcmV0Owor
ICAgIHJldHVybiBkcmhkOwogfQogCiBzdGF0aWMgdm9pZCBjZl9jaGVjayBp
b21tdV9jbGVhcl9yb290X3BndGFibGUoc3RydWN0IGRvbWFpbiAqZCkKQEAg
LTIxNDksMTYgKzIxOTQsMTcgQEAgc3RhdGljIGludCBjZl9jaGVjayBpbnRl
bF9pb21tdV9lbmFibGVfZAogCiBzdGF0aWMgaW50IGNmX2NoZWNrIGludGVs
X2lvbW11X3JlbW92ZV9kZXZpY2UodTggZGV2Zm4sIHN0cnVjdCBwY2lfZGV2
ICpwZGV2KQogeworICAgIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAq
ZHJoZDsKICAgICBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CiAgICAg
dTE2IGJkZjsKLSAgICBpbnQgcmV0LCBpOworICAgIHVuc2lnbmVkIGludCBp
OwogCiAgICAgaWYgKCAhcGRldi0+ZG9tYWluICkKICAgICAgICAgcmV0dXJu
IC1FSU5WQUw7CiAKLSAgICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcChw
ZGV2LT5kb21haW4sIGRldmZuLCBwZGV2KTsKLSAgICBpZiAoIHJldCApCi0g
ICAgICAgIHJldHVybiByZXQ7CisgICAgZHJoZCA9IGRvbWFpbl9jb250ZXh0
X3VubWFwKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYpOworICAgIGlmICgg
SVNfRVJSKGRyaGQpICkKKyAgICAgICAgcmV0dXJuIFBUUl9FUlIoZHJoZCk7
CiAKICAgICBmb3JfZWFjaF9ybXJyX2RldmljZSAoIHJtcnIsIGJkZiwgaSAp
CiAgICAgewpAQCAtMjE3NSw2ICsyMjIxLDEzIEBAIHN0YXRpYyBpbnQgY2Zf
Y2hlY2sgaW50ZWxfaW9tbXVfcmVtb3ZlX2QKICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7CiAgICAgfQog
CisgICAgaWYgKCBkcmhkICkKKyAgICB7CisgICAgICAgIGlvbW11X2ZyZWVf
ZG9taWQocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgZHJoZC0+aW9tbXUtPnBzZXVkb19kb21pZF9tYXApOwor
ICAgICAgICBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCA9IERPTUlEX0lOVkFM
SUQ7CisgICAgfQorCiAgICAgcmV0dXJuIDA7CiB9CiAKQEAgLTI1NTIsNyAr
MjYwNSwxMiBAQCBzdGF0aWMgaW50IGNmX2NoZWNrIHJlYXNzaWduX2Rldmlj
ZV9vd25lCiAgICAgICAgIH0KICAgICB9CiAgICAgZWxzZQotICAgICAgICBy
ZXQgPSBkb21haW5fY29udGV4dF91bm1hcChzb3VyY2UsIGRldmZuLCBwZGV2
KTsKKyAgICB7CisgICAgICAgIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5p
dCAqZHJoZDsKKworICAgICAgICBkcmhkID0gZG9tYWluX2NvbnRleHRfdW5t
YXAoc291cmNlLCBkZXZmbiwgcGRldik7CisgICAgICAgIHJldCA9IElTX0VS
UihkcmhkKSA/IFBUUl9FUlIoZHJoZCkgOiAwOworICAgIH0KICAgICBpZiAo
IHJldCApCiAgICAgewogICAgICAgICBpZiAoICFoYXNfYXJjaF9wZGV2cyh0
YXJnZXQpICkKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmgKQEAgLTUwMyw2ICs1MDMsNyBAQCBzdHJ1Y3QgdnRkX2lvbW11IHsKICAg
ICB9IGZsdXNoOwogCiAgICAgc3RydWN0IGxpc3RfaGVhZCBhdHNfZGV2aWNl
czsKKyAgICB1bnNpZ25lZCBsb25nICpwc2V1ZG9fZG9taWRfbWFwOyAvKiAi
cHNldWRvIiBkb21haW4gaWQgYml0bWFwICovCiAgICAgdW5zaWduZWQgbG9u
ZyAqZG9taWRfYml0bWFwOyAgLyogZG9tYWluIGlkIGJpdG1hcCAqLwogICAg
IGRvbWlkX3QgKmRvbWlkX21hcDsgICAgICAgICAgIC8qIGRvbWFpbiBpZCBt
YXBwaW5nIGFycmF5ICovCiAgICAgdWludDMyX3QgdmVyc2lvbjsKLS0tIGEv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gveDg2L2lvbW11LmMKKysrIGIveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gveDg2L2lvbW11LmMKQEAgLTM5MSw2ICsz
OTEsNjYgQEAgdm9pZCBfX2h3ZG9tX2luaXQgYXJjaF9pb21tdV9od2RvbV9p
bml0KAogICAgICAgICByZXR1cm47CiB9CiAKK3ZvaWQgYXJjaF9wY2lfaW5p
dF9wZGV2KHN0cnVjdCBwY2lfZGV2ICpwZGV2KQoreworICAgIHBkZXYtPmFy
Y2gucHNldWRvX2RvbWlkID0gRE9NSURfSU5WQUxJRDsKK30KKwordW5zaWdu
ZWQgbG9uZyAqX19pbml0IGlvbW11X2luaXRfZG9taWQoZG9taWRfdCByZXNl
cnZlKQoreworICAgIHVuc2lnbmVkIGxvbmcgKm1hcDsKKworICAgIGlmICgg
IWlvbW11X3F1YXJhbnRpbmUgKQorICAgICAgICByZXR1cm4gWkVST19CTE9D
S19QVFI7CisKKyAgICBCVUlMRF9CVUdfT04oRE9NSURfTUFTSyAqIDJVID49
IFVJTlQxNl9NQVgpOworCisgICAgbWFwID0geHphbGxvY19hcnJheSh1bnNp
Z25lZCBsb25nLCBCSVRTX1RPX0xPTkdTKFVJTlQxNl9NQVggLSBET01JRF9N
QVNLKSk7CisgICAgaWYgKCBtYXAgJiYgcmVzZXJ2ZSAhPSBET01JRF9JTlZB
TElEICkKKyAgICB7CisgICAgICAgIEFTU0VSVChyZXNlcnZlID4gRE9NSURf
TUFTSyk7CisgICAgICAgIF9fc2V0X2JpdChyZXNlcnZlICYgRE9NSURfTUFT
SywgbWFwKTsKKyAgICB9CisKKyAgICByZXR1cm4gbWFwOworfQorCitkb21p
ZF90IGlvbW11X2FsbG9jX2RvbWlkKHVuc2lnbmVkIGxvbmcgKm1hcCkKK3sK
KyAgICAvKgorICAgICAqIFRoaXMgaXMgdXNlZCB1bmlmb3JtbHkgYWNyb3Nz
IGFsbCBJT01NVXMsIHN1Y2ggdGhhdCBvbiB0eXBpY2FsCisgICAgICogc3lz
dGVtcyB3ZSB3b3VsZG4ndCByZS11c2UgdGhlIHNhbWUgSUQgdmVyeSBxdWlj
a2x5IChwZXJoYXBzIG5ldmVyKS4KKyAgICAgKi8KKyAgICBzdGF0aWMgdW5z
aWduZWQgaW50IHN0YXJ0OworICAgIHVuc2lnbmVkIGludCBpZHggPSBmaW5k
X25leHRfemVyb19iaXQobWFwLCBVSU5UMTZfTUFYIC0gRE9NSURfTUFTSywg
c3RhcnQpOworCisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOworCisg
ICAgaWYgKCBpZHggPj0gVUlOVDE2X01BWCAtIERPTUlEX01BU0sgKQorICAg
ICAgICBpZHggPSBmaW5kX2ZpcnN0X3plcm9fYml0KG1hcCwgVUlOVDE2X01B
WCAtIERPTUlEX01BU0spOworICAgIGlmICggaWR4ID49IFVJTlQxNl9NQVgg
LSBET01JRF9NQVNLICkKKyAgICAgICAgcmV0dXJuIERPTUlEX0lOVkFMSUQ7
CisKKyAgICBfX3NldF9iaXQoaWR4LCBtYXApOworCisgICAgc3RhcnQgPSBp
ZHggKyAxOworCisgICAgcmV0dXJuIGlkeCB8IChET01JRF9NQVNLICsgMSk7
Cit9CisKK3ZvaWQgaW9tbXVfZnJlZV9kb21pZChkb21pZF90IGRvbWlkLCB1
bnNpZ25lZCBsb25nICptYXApCit7CisgICAgQVNTRVJUKHBjaWRldnNfbG9j
a2VkKCkpOworCisgICAgaWYgKCBkb21pZCA9PSBET01JRF9JTlZBTElEICkK
KyAgICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKGRvbWlkID4gRE9NSURf
TUFTSyk7CisKKyAgICBpZiAoICFfX3Rlc3RfYW5kX2NsZWFyX2JpdChkb21p
ZCAmIERPTUlEX01BU0ssIG1hcCkgKQorICAgICAgICBCVUcoKTsKK30KKwog
aW50IGlvbW11X2ZyZWVfcGd0YWJsZXMoc3RydWN0IGRvbWFpbiAqZCkKIHsK
ICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsK

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-10.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IGRyb3AgVExCIGZsdXNoZXMgZnJvbSBxdWFyYW50aW5l
X2luaXQoKSBob29rcwoKVGhlIHBhZ2UgdGFibGVzIGp1c3QgY3JlYXRlZCBh
cmVuJ3QgaG9va2VkIHVwIHlldCBhbnl3aGVyZSwgc28gdGhlcmUncwpub3Ro
aW5nIHRoYXQgY291bGQgYmUgcHJlc2VudCBpbiBhbnkgVExCLCBhbmQgaGVu
Y2Ugbm90aGluZyB0byBmbHVzaC4KRHJvcHBpbmcgdGhpcyBmbHVzaCBpcywg
YXQgbGVhc3Qgb24gdGhlIFZULWQgc2lkZSwgYSBwcmVyZXEgdG8gcGVyLQpk
ZXZpY2UgZG9tYWluIElEIHVzZSB3aGVuIHF1YXJhbnRpbmluZyBkZXZpY2Vz
LCBhcyBkb21faW8gaXNuJ3QgZ29pbmcKdG8gYmUgYXNzaWduZWQgYSBESUQg
YW55bW9yZTogVGhlIHdhcm5pbmcgaW4gZ2V0X2lvbW11X2RpZCgpIHdvdWxk
CnRyaWdnZXIuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxA
eGVuLm9yZz4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy
LnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2
aW4udGlhbkBpbnRlbC5jb20+Ci0tLQp2NTogVGhpcyAocHJldmlvdXNseSBm
b2xsb3ctb24pIHBhdGNoIGlzIG5vdyBwYXJ0IG9mIHRoaXMgc2VyaWVzLgoK
LS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5j
CisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAu
YwpAQCAtNjU2LDggKzY1Niw2IEBAIGludCBfX2luaXQgY2ZfY2hlY2sgYW1k
X2lvbW11X3F1YXJhbnRpbmUKICBvdXQ6CiAgICAgc3Bpbl91bmxvY2soJmhk
LT5hcmNoLm1hcHBpbmdfbG9jayk7CiAKLSAgICBhbWRfaW9tbXVfZmx1c2hf
YWxsX3BhZ2VzKGQpOwotCiAgICAgLyogUGFnZXMgbGVha2VkIGluIGZhaWx1
cmUgY2FzZSAqLwogICAgIHJldHVybiBsZXZlbCA/IC1FTk9NRU0gOiAwOwog
fQotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwor
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYwpAQCAt
Mjk4MCw5ICsyOTgwLDYgQEAgc3RhdGljIGludCBfX2luaXQgY2ZfY2hlY2sg
aW50ZWxfaW9tbXVfcQogIG91dDoKICAgICBzcGluX3VubG9jaygmaGQtPmFy
Y2gubWFwcGluZ19sb2NrKTsKIAotICAgIGlmICggIXJjICkKLSAgICAgICAg
cmMgPSBpb21tdV9mbHVzaF9pb3RsYl9hbGwoZCk7Ci0KICAgICAvKiBQYWdl
cyBtYXkgYmUgbGVha2VkIGluIGZhaWx1cmUgY2FzZSAqLwogICAgIHJldHVy
biByYzsKIH0K

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-11.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-11.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBBTUQvSU9NTVU6IGFic3RyYWN0IG1heGltdW0gbnVtYmVyIG9mIHBhZ2Ug
dGFibGUgbGV2ZWxzCgpXZSB3aWxsIHdhbnQgdG8gdXNlIHRoZSBjb25zdGFu
dCBlbHNld2hlcmUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBh
dWxAeGVuLm9yZz4KLS0tCnY3OiBOZXcuCgotLS0gYS94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC9hbWQvaW9tbXUtZGVmcy5oCisrKyBiL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL2FtZC9pb21tdS1kZWZzLmgKQEAgLTEwNiw2ICsxMDYs
NyBAQCBzdHJ1Y3QgYW1kX2lvbW11X2R0ZSB7CiAgICAgYm9vbCB0djoxOwog
ICAgIHVuc2lnbmVkIGludCA6NTsKICAgICB1bnNpZ25lZCBpbnQgaGFkOjI7
CisjZGVmaW5lIElPTU1VX01BWF9QVF9MRVZFTFMgNgogICAgIHVuc2lnbmVk
IGludCBwYWdpbmdfbW9kZTozOwogICAgIHVpbnQ2NF90IHB0X3Jvb3Q6NDA7
CiAgICAgYm9vbCBwcHI6MTsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0zMzcsNyArMzM3LDcg
QEAgaW50IGFtZF9pb21tdV9hbGxvY19yb290KHN0cnVjdCBkb21haW4gKgog
ICAgIHJldHVybiAwOwogfQogCi11bnNpZ25lZCBpbnQgX19yZWFkX21vc3Rs
eSBhbWRfaW9tbXVfbWF4X3BhZ2luZ19tb2RlID0gNjsKK3Vuc2lnbmVkIGlu
dCBfX3JlYWRfbW9zdGx5IGFtZF9pb21tdV9tYXhfcGFnaW5nX21vZGUgPSBJ
T01NVV9NQVhfUFRfTEVWRUxTOwogaW50IF9fcmVhZF9tb3N0bHkgYW1kX2lv
bW11X21pbl9wYWdpbmdfbW9kZSA9IDE7CiAKIHN0YXRpYyBpbnQgY2ZfY2hl
Y2sgYW1kX2lvbW11X2RvbWFpbl9pbml0KHN0cnVjdCBkb21haW4gKmQpCg==

--=separator
Content-Type: application/octet-stream; name="xsa400/xsa400-12.patch"
Content-Disposition: attachment; filename="xsa400/xsa400-12.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBJT01NVS94ODY6IHVzZSBwZXItZGV2aWNlIHBhZ2UgdGFibGVzIGZvciBx
dWFyYW50aW5pbmcKCkRldmljZXMgd2l0aCBSTVJScyAvIHVuaXR5IG1hcHBl
ZCByZWdpb25zLCBkdWUgdG8gaXQgYmVpbmcgdW5zcGVjaWZpZWQKaG93L3do
ZW4gdGhlc2UgbWVtb3J5IHJlZ2lvbnMgbWF5IGJlIGFjY2Vzc2VkLCBtYXkg
bm90IGJlIGxlZnQKZGlzY29ubmVjdGVkIGZyb20gdGhlIG1hcHBpbmdzIG9m
IHRoZXNlIHJlZ2lvbnMgKGFzIGxvbmcgYXMgaXQncyBub3QKY2VydGFpbiB0
aGF0IHRoZSBkZXZpY2UgaGFzIGJlZW4gZnVsbHkgcXVpZXNjZWQpLiBIZW5j
ZSBldmVuIHRoZSBwYWdlCnRhYmxlcyB1c2VkIHdoZW4gcXVhcmFudGluaW5n
IHN1Y2ggZGV2aWNlcyBuZWVkIHRvIGhhdmUgbWFwcGluZ3Mgb2YKdGhvc2Ug
cmVnaW9ucy4gVGhpcyBpbXBsaWVzIGluc3RhbGxpbmcgcGFnZSB0YWJsZXMg
aW4gdGhlIGZpcnN0IHBsYWNlCmV2ZW4gd2hlbiBub3QgaW4gc2NyYXRjaC1w
YWdlIHF1YXJhbnRpbmluZyBtb2RlLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM2
MSAvIHBhcnQgb2YgWFNBLTQwMC4KCldoaWxlIGZvciB0aGUgcHVycG9zZSBo
ZXJlIGl0IHdvdWxkIGJlIHN1ZmZpY2llbnQgdG8gaGF2ZSBkZXZpY2VzIHdp
dGgKUk1SUnMgLyB1bml0eSBtYXBwZWQgcmVnaW9ucyB1c2UgcGVyLWRldmlj
ZSBwYWdlIHRhYmxlcywgZXh0ZW5kIHRoaXMgdG8KYWxsIGRldmljZXMgKGlu
IHNjcmF0Y2gtcGFnZSBxdWFyYW50aW5pbmcgbW9kZSkuIFRoaXMgYWxsb3dz
IHRoZSBsZWFmCnBhZ2VzIHRvIGJlIG1hcHBlZCByL3csIHRodXMgY292ZXJp
bmcgYWxzbyBtZW1vcnkgd3JpdGVzIChyYXRoZXIgdGhhbgpqdXN0IHJlYWRz
KSBpc3N1ZWQgYnkgbm9uLXF1aWVzY2VudCBkZXZpY2VzLgoKU2V0IHVwIHF1
YXJhbnRpbmUgcGFnZSB0YWJsZXMgYXMgbGF0ZSBhcyBwb3NzaWJsZSwgeWV0
IGVhcmx5IGVub3VnaCB0bwpub3QgZW5jb3VudGVyIGZhaWx1cmUgZHVyaW5n
IGRlLWFzc2lnbi4gVGhpcyBtZWFucyBzZXR1cCBnZW5lcmFsbHkKaGFwcGVu
cyBpbiBhc3NpZ25fZGV2aWNlKCksIHdoaWxlIChmb3Igbm93KSB0aGUgb25l
IGluIGRlYXNzaWduX2RldmljZSgpCmlzIHRoZXJlIG1haW5seSB0byBiZSBv
biB0aGUgc2FmZSBzaWRlLgoKQXMgdG8gdGhlIHJlbW92YWwgb2YgUVVBUkFO
VElORV9TS0lQKCkgZnJvbSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoKToK
SSB0aGluayB0aGlzIHdhcyBuZXZlciByZWFsbHkgbmVlZGVkIHRoZXJlLCBh
cyB0aGUgZnVuY3Rpb24gZXhwbGljaXRseQpkZWFscyB3aXRoIGZpbmRpbmcg
YSBub24tcHJlc2VudCBjb250ZXh0IGVudHJ5LiBMZWF2aW5nIGl0IHRoZXJl
IHdvdWxkCnJlcXVpcmUgcHJvcGFnYXRpbmcgcGdkX21hZGRyIGludG8gdGhl
IGZ1bmN0aW9uIChsaWtlIHdhcyBkb25lIGJ5ICJWVC1kOgpwcmVwYXJlIGZv
ciBwZXItZGV2aWNlIHF1YXJhbnRpbmUgcGFnZSB0YWJsZXMiIGZvcgpkb21h
aW5fY29udGV4dF9tYXBwaW5nX29uZSgpKS4KCkluIFZULWQncyBESUQgYWxs
b2NhdGlvbiBmdW5jdGlvbiBkb24ndCByZXF1aXJlIHRoZSBJT01NVSBsb2Nr
IHRvIGJlCmhlbGQgYW55bW9yZTogQWxsIGludm9sdmVkIGNvZGUgcGF0aHMg
aG9sZCBwY2lkZXZzX2xvY2ssIHNvIHRoaXMgd2F5IHdlCmF2b2lkIHRoZSBu
ZWVkIHRvIGFjcXVpcmUgdGhlIElPTU1VIGxvY2sgYXJvdW5kIHRoZSBuZXcg
Y2FsbCB0bwpjb250ZXh0X3NldF9kb21haW5faWQoKS4KClNpZ25lZC1vZmYt
Ynk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQt
Ynk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgpSZXZpZXdlZC1ieTog
S2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+ClJldmlld2VkLWJ5
OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KLS0t
CnY3OiBBZGQgY29tbWVudCBhaGVhZCBvZiBjb250ZXh0X3NldF9kb21haW5f
aWQoKS4gVXNlCiAgICBJT01NVV9NQVhfUFRfTEVWRUxTLiBSZS1iYXNlLgp2
NjogY29udGV4dF9zZXRfZG9tYWluX2lkKCkncyBBU1NFUlQoKSBjaGFuZ2Ug
bW92ZWQgaGVyZSAoZnJvbSBlYXJsaWVyCiAgICBwYXRjaCkuIFNob3J0ZW4g
QkRGIGNvbXBhcmlzb24gaW4gaW50ZWxfaW9tbXVfcXVhcmFudGluZV9pbml0
KCkuIFJlLQogICAgYmFzZSBvdmVyIGNoYW5nZXMgZWFybGllciBpbiB0aGUg
c2VyaWVzLgp2NTogQWxzbyB1c2UgcGVyLWRldmljZSAocHNldWRvKSBkb21h
aW4gSUQuIFN1cHByZXNzIGNvcnJ1cHRpb24gd2FybmluZwogICAgZm9yIERv
bUlPLiBSZS1iYXNlIG92ZXIgY2hhbmdlcyB0byBlYXJsaWVyIHBhdGNoZXMu
CnY0OiBSZS1iYXNlIG92ZXIgbmV3IGVhcmxpZXIgcGF0Y2guCnYzOiBObyBz
cGlubmluZyBpbiBxdWFyYW50aW5lX2luaXQoKSBob29rcyB3aGVuIHRyYW5z
aWVudGx5IHBvcHVsYXRpbmcKICAgIGRvbV9pbydzIHBhZ2UgdGFibGUgcm9v
dC4gcXVhcmFudGluZV90ZWFyZG93bigpIGFuZCBhcnJhbmdlbWVudHMgZm9y
CiAgICB0aGVtIHJlZG9uZS4gUmUtYmFzZSBvdmVyIGNoYW5nZXMgZWFybGll
ciBpbiB0aGUgc2VyaWVzLiBFeHRlbmQgYQogICAgY29tbWVudC4gSW50cm9k
dWNlIERFVklDRV9QR1RBQkxFKCkuIFJlLWJhc2UuCnYyOiBOZXcuCgotLS0g
YS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vcGNpLmgKKysrIGIveGVuL2Fy
Y2gveDg2L2luY2x1ZGUvYXNtL3BjaS5oCkBAIC0xLDYgKzEsOCBAQAogI2lm
bmRlZiBfX1g4Nl9QQ0lfSF9fCiAjZGVmaW5lIF9fWDg2X1BDSV9IX18KIAor
I2luY2x1ZGUgPHhlbi9tbS5oPgorCiAjZGVmaW5lIENGOF9CREYoY2Y4KSAg
ICAgKCAgKChjZjgpICYgMHgwMGZmZmYwMCkgPj4gOCkKICNkZWZpbmUgQ0Y4
X0FERFJfTE8oY2Y4KSAoICAgKGNmOCkgJiAweDAwMDAwMGZjKQogI2RlZmlu
ZSBDRjhfQUREUl9ISShjZjgpICggICgoY2Y4KSAmIDB4MGYwMDAwMDApID4+
IDE2KQpAQCAtMTgsNyArMjAsMTggQEAgc3RydWN0IGFyY2hfcGNpX2RldiB7
CiAgICAgICogdGhlbSBkb24ndCByYWNlIChkZSlpbml0aWFsaXphdGlvbiBh
bmQgaGVuY2UgZG9uJ3Qgc3RyaWN0bHkgbmVlZCBhbnkKICAgICAgKiBsb2Nr
aW5nLgogICAgICAqLworICAgIHVuaW9uIHsKKyAgICAgICAgLyogU3Vic2V0
IG9mIHN0cnVjdCBhcmNoX2lvbW11J3MgZmllbGRzLCB0byBiZSB1c2VkIGlu
IGRvbV9pby4gKi8KKyAgICAgICAgc3RydWN0IHsKKyAgICAgICAgICAgIHVp
bnQ2NF90IHBnZF9tYWRkcjsKKyAgICAgICAgfSB2dGQ7CisgICAgICAgIHN0
cnVjdCB7CisgICAgICAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpyb290X3Rh
YmxlOworICAgICAgICB9IGFtZDsKKyAgICB9OwogICAgIGRvbWlkX3QgcHNl
dWRvX2RvbWlkOworICAgIG1mbl90IGxlYWZfbWZuOworICAgIHN0cnVjdCBw
YWdlX2xpc3RfaGVhZCBwZ3RhYmxlc19saXN0OwogfTsKIAogaW50IHBjaV9j
b25mX3dyaXRlX2ludGVyY2VwdCh1bnNpZ25lZCBpbnQgc2VnLCB1bnNpZ25l
ZCBpbnQgYmRmLAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQv
aW9tbXUuaAorKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t
bXUuaApAQCAtMjM3LDcgKzIzNyw4IEBAIGludCBhbWRfaW9tbXVfaW5pdF9s
YXRlKHZvaWQpOwogaW50IGFtZF9pb21tdV91cGRhdGVfaXZyc19tYXBwaW5n
X2FjcGkodm9pZCk7CiBpbnQgY2ZfY2hlY2sgaW92X2FkanVzdF9pcnFfYWZm
aW5pdGllcyh2b2lkKTsKIAotaW50IGNmX2NoZWNrIGFtZF9pb21tdV9xdWFy
YW50aW5lX2luaXQoc3RydWN0IGRvbWFpbiAqZCk7CitpbnQgY2ZfY2hlY2sg
YW1kX2lvbW11X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3QgcGNpX2RldiAqcGRl
diwgYm9vbCBzY3JhdGNoX3BhZ2UpOwordm9pZCBhbWRfaW9tbXVfcXVhcmFu
dGluZV90ZWFyZG93bihzdHJ1Y3QgcGNpX2RldiAqcGRldik7CiAKIC8qIG1h
cHBpbmcgZnVuY3Rpb25zICovCiBpbnQgX19tdXN0X2NoZWNrIGNmX2NoZWNr
IGFtZF9pb21tdV9tYXBfcGFnZSgKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvYW1kL2lvbW11X21hcC5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL2FtZC9pb21tdV9tYXAuYwpAQCAtNjAwLDY0ICs2MDAsMTM4IEBA
IGludCBjZl9jaGVjayBhbWRfaW9tbXVfZ2V0X3Jlc2VydmVkX2RldmkKICAg
ICByZXR1cm4gMDsKIH0KIAotaW50IF9faW5pdCBjZl9jaGVjayBhbWRfaW9t
bXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBkb21haW4gKmQpCitzdGF0aWMg
aW50IGZpbGxfcXB0KHVuaW9uIGFtZF9pb21tdV9wdGUgKnRoaXMsIHVuc2ln
bmVkIGludCBsZXZlbCwKKyAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBh
Z2VfaW5mbyAqcGdzW0lPTU1VX01BWF9QVF9MRVZFTFNdKQogewotICAgIHN0
cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOworICAgIHN0
cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbV9pbyk7Cisg
ICAgdW5zaWduZWQgaW50IGk7CisgICAgaW50IHJjID0gMDsKKworICAgIGZv
ciAoIGkgPSAwOyAhcmMgJiYgaSA8IFBURV9QRVJfVEFCTEVfU0laRTsgKytp
ICkKKyAgICB7CisgICAgICAgIHVuaW9uIGFtZF9pb21tdV9wdGUgKnB0ZSA9
ICZ0aGlzW2ldLCAqbmV4dDsKKworICAgICAgICBpZiAoICFwdGUtPnByICkK
KyAgICAgICAgeworICAgICAgICAgICAgaWYgKCAhcGdzW2xldmVsXSApCisg
ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgLyoKKyAgICAgICAgICAg
ICAgICAgKiBUaGUgcGd0YWJsZSBhbGxvY2F0b3IgaXMgZmluZSBmb3IgdGhl
IGxlYWYgcGFnZSwgYXMgd2VsbCBhcworICAgICAgICAgICAgICAgICAqIHBh
Z2UgdGFibGUgcGFnZXMsIGFuZCB0aGUgcmVzdWx0aW5nIGFsbG9jYXRpb25z
IGFyZSBhbHdheXMKKyAgICAgICAgICAgICAgICAgKiB6ZXJvZWQuCisgICAg
ICAgICAgICAgICAgICovCisgICAgICAgICAgICAgICAgcGdzW2xldmVsXSA9
IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOworICAgICAgICAgICAgICAgIGlm
ICggIXBnc1tsZXZlbF0gKQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAg
ICAgICAgICAgICAgcmMgPSAtRU5PTUVNOworICAgICAgICAgICAgICAgICAg
ICBicmVhazsKKyAgICAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICAg
ICBpZiAoIGxldmVsICkKKyAgICAgICAgICAgICAgICB7CisgICAgICAgICAg
ICAgICAgICAgIG5leHQgPSBfX21hcF9kb21haW5fcGFnZShwZ3NbbGV2ZWxd
KTsKKyAgICAgICAgICAgICAgICAgICAgcmMgPSBmaWxsX3FwdChuZXh0LCBs
ZXZlbCAtIDEsIHBncyk7CisgICAgICAgICAgICAgICAgICAgIHVubWFwX2Rv
bWFpbl9wYWdlKG5leHQpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAg
ICAgIH0KKworICAgICAgICAgICAgLyoKKyAgICAgICAgICAgICAqIFBERXMg
YXJlIGVzc2VudGlhbGx5IGEgc3Vic2V0IG9mIFBURXMsIHNvIHRoaXMgZnVu
Y3Rpb24KKyAgICAgICAgICAgICAqIGlzIGZpbmUgdG8gdXNlIGV2ZW4gYXQg
dGhlIGxlYWYuCisgICAgICAgICAgICAgKi8KKyAgICAgICAgICAgIHNldF9p
b21tdV9wZGVfcHJlc2VudChwdGUsIG1mbl94KHBhZ2VfdG9fbWZuKHBnc1ts
ZXZlbF0pKSwgbGV2ZWwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdHJ1ZSwgdHJ1ZSk7CisgICAgICAgIH0KKyAgICAgICAgZWxzZSBp
ZiAoIGxldmVsICYmIHB0ZS0+bmV4dF9sZXZlbCApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIG5leHQgPSBtYXBfZG9tYWluX3BhZ2UoX21mbihwdGUtPm1m
bikpOworICAgICAgICAgICAgcmMgPSBmaWxsX3FwdChuZXh0LCBsZXZlbCAt
IDEsIHBncyk7CisgICAgICAgICAgICB1bm1hcF9kb21haW5fcGFnZShuZXh0
KTsKKyAgICAgICAgfQorICAgIH0KKworICAgIHJldHVybiByYzsKK30KKwor
aW50IGNmX2NoZWNrIGFtZF9pb21tdV9xdWFyYW50aW5lX2luaXQoc3RydWN0
IHBjaV9kZXYgKnBkZXYsIGJvb2wgc2NyYXRjaF9wYWdlKQoreworICAgIHN0
cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbV9pbyk7CiAg
ICAgdW5zaWduZWQgbG9uZyBlbmRfZ2ZuID0KICAgICAgICAgMXVsIDw8IChE
RUZBVUxUX0RPTUFJTl9BRERSRVNTX1dJRFRIIC0gUEFHRV9TSElGVCk7CiAg
ICAgdW5zaWduZWQgaW50IGxldmVsID0gYW1kX2lvbW11X2dldF9wYWdpbmdf
bW9kZShlbmRfZ2ZuKTsKLSAgICB1bmlvbiBhbWRfaW9tbXVfcHRlICp0YWJs
ZTsKKyAgICB1bnNpZ25lZCBpbnQgcmVxX2lkID0gZ2V0X2RtYV9yZXF1ZXN0
b3JfaWQocGRldi0+c2VnLCBwZGV2LT5zYmRmLmJkZik7CisgICAgY29uc3Qg
c3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBnZXRfaXZy
c19tYXBwaW5ncyhwZGV2LT5zZWcpOworICAgIGludCByYzsKKworICAgIEFT
U0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKKyAgICBBU1NFUlQoIWhkLT5hcmNo
LmFtZC5yb290X3RhYmxlKTsKKyAgICBBU1NFUlQocGFnZV9saXN0X2VtcHR5
KCZoZC0+YXJjaC5wZ3RhYmxlcy5saXN0KSk7CiAKLSAgICBpZiAoIGhkLT5h
cmNoLmFtZC5yb290X3RhYmxlICkKLSAgICB7Ci0gICAgICAgIEFTU0VSVF9V
TlJFQUNIQUJMRSgpOworICAgIGlmICggIXNjcmF0Y2hfcGFnZSAmJiAhaXZy
c19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcCApCiAgICAgICAgIHJldHVy
biAwOwotICAgIH0KIAotICAgIHNwaW5fbG9jaygmaGQtPmFyY2gubWFwcGlu
Z19sb2NrKTsKKyAgICBBU1NFUlQocGRldi0+YXJjaC5wc2V1ZG9fZG9taWQg
IT0gRE9NSURfSU5WQUxJRCk7CiAKLSAgICBoZC0+YXJjaC5hbWQucm9vdF90
YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOwotICAgIGlmICggIWhk
LT5hcmNoLmFtZC5yb290X3RhYmxlICkKLSAgICAgICAgZ290byBvdXQ7Cisg
ICAgaWYgKCBwZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlICkKKyAgICB7Cisg
ICAgICAgIGNsZWFyX2RvbWFpbl9wYWdlKHBkZXYtPmFyY2gubGVhZl9tZm4p
OworICAgICAgICByZXR1cm4gMDsKKyAgICB9CiAKLSAgICB0YWJsZSA9IF9f
bWFwX2RvbWFpbl9wYWdlKGhkLT5hcmNoLmFtZC5yb290X3RhYmxlKTsKLSAg
ICB3aGlsZSAoIGxldmVsICkKKyAgICBwZGV2LT5hcmNoLmFtZC5yb290X3Rh
YmxlID0gaW9tbXVfYWxsb2NfcGd0YWJsZShoZCk7CisgICAgaWYgKCAhcGRl
di0+YXJjaC5hbWQucm9vdF90YWJsZSApCisgICAgICAgIHJldHVybiAtRU5P
TUVNOworCisgICAgLyogVHJhbnNpZW50bHkgaW5zdGFsbCB0aGUgcm9vdCBp
bnRvIERvbUlPLCBmb3IgaW9tbXVfaWRlbnRpdHlfbWFwcGluZygpLiAqLwor
ICAgIGhkLT5hcmNoLmFtZC5yb290X3RhYmxlID0gcGRldi0+YXJjaC5hbWQu
cm9vdF90YWJsZTsKKworICAgIHJjID0gYW1kX2lvbW11X3Jlc2VydmVfZG9t
YWluX3VuaXR5X21hcChkb21faW8sCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbcmVxX2lkXS51
bml0eV9tYXAsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIDApOworCisgICAgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJk
b3duKGRvbV9pbyk7CisgICAgaGQtPmFyY2guYW1kLnJvb3RfdGFibGUgPSBO
VUxMOworCisgICAgaWYgKCByYyApCisgICAgICAgIEFNRF9JT01NVV9XQVJO
KCIlcHA6IHF1YXJhbnRpbmUgdW5pdHkgbWFwcGluZyBmYWlsZWRcbiIsICZw
ZGV2LT5zYmRmKTsKKyAgICBlbHNlIGlmICggc2NyYXRjaF9wYWdlICkKICAg
ICB7Ci0gICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOwotICAgICAgICB1
bnNpZ25lZCBpbnQgaTsKKyAgICAgICAgdW5pb24gYW1kX2lvbW11X3B0ZSAq
cm9vdDsKKyAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGdzW0lPTU1VX01B
WF9QVF9MRVZFTFNdID0ge307CiAKLSAgICAgICAgLyoKLSAgICAgICAgICog
VGhlIHBndGFibGUgYWxsb2NhdG9yIGlzIGZpbmUgZm9yIHRoZSBsZWFmIHBh
Z2UsIGFzIHdlbGwgYXMKLSAgICAgICAgICogcGFnZSB0YWJsZSBwYWdlcywg
YW5kIHRoZSByZXN1bHRpbmcgYWxsb2NhdGlvbnMgYXJlIGFsd2F5cwotICAg
ICAgICAgKiB6ZXJvZWQuCi0gICAgICAgICAqLwotICAgICAgICBwZyA9IGlv
bW11X2FsbG9jX3BndGFibGUoaGQpOwotICAgICAgICBpZiAoICFwZyApCi0g
ICAgICAgICAgICBicmVhazsKKyAgICAgICAgc3Bpbl9sb2NrKCZoZC0+YXJj
aC5tYXBwaW5nX2xvY2spOwogCi0gICAgICAgIGZvciAoIGkgPSAwOyBpIDwg
UFRFX1BFUl9UQUJMRV9TSVpFOyBpKysgKQotICAgICAgICB7Ci0gICAgICAg
ICAgICB1bmlvbiBhbWRfaW9tbXVfcHRlICpwZGUgPSAmdGFibGVbaV07Cisg
ICAgICAgIHJvb3QgPSBfX21hcF9kb21haW5fcGFnZShwZGV2LT5hcmNoLmFt
ZC5yb290X3RhYmxlKTsKKyAgICAgICAgcmMgPSBmaWxsX3FwdChyb290LCBs
ZXZlbCAtIDEsIHBncyk7CisgICAgICAgIHVubWFwX2RvbWFpbl9wYWdlKHJv
b3QpOwogCi0gICAgICAgICAgICAvKgotICAgICAgICAgICAgICogUERFcyBh
cmUgZXNzZW50aWFsbHkgYSBzdWJzZXQgb2YgUFRFcywgc28gdGhpcyBmdW5j
dGlvbgotICAgICAgICAgICAgICogaXMgZmluZSB0byB1c2UgZXZlbiBhdCB0
aGUgbGVhZi4KLSAgICAgICAgICAgICAqLwotICAgICAgICAgICAgc2V0X2lv
bW11X3BkZV9wcmVzZW50KHBkZSwgbWZuX3gocGFnZV90b19tZm4ocGcpKSwg
bGV2ZWwgLSAxLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGZhbHNlLCB0cnVlKTsKLSAgICAgICAgfQorICAgICAgICBwZGV2LT5hcmNo
LmxlYWZfbWZuID0gcGFnZV90b19tZm4ocGdzWzBdKTsKIAotICAgICAgICB1
bm1hcF9kb21haW5fcGFnZSh0YWJsZSk7Ci0gICAgICAgIHRhYmxlID0gX19t
YXBfZG9tYWluX3BhZ2UocGcpOwotICAgICAgICBsZXZlbC0tOworICAgICAg
ICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKICAgICB9
Ci0gICAgdW5tYXBfZG9tYWluX3BhZ2UodGFibGUpOwogCi0gb3V0OgotICAg
IHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOworICAgIHBh
Z2VfbGlzdF9tb3ZlKCZwZGV2LT5hcmNoLnBndGFibGVzX2xpc3QsICZoZC0+
YXJjaC5wZ3RhYmxlcy5saXN0KTsKKworICAgIGlmICggcmMgKQorICAgICAg
ICBhbWRfaW9tbXVfcXVhcmFudGluZV90ZWFyZG93bihwZGV2KTsKKworICAg
IHJldHVybiByYzsKK30KKwordm9pZCBhbWRfaW9tbXVfcXVhcmFudGluZV90
ZWFyZG93bihzdHJ1Y3QgcGNpX2RldiAqcGRldikKK3sKKyAgICBzdHJ1Y3Qg
ZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21faW8pOworCisgICAg
QVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOworCisgICAgaWYgKCAhcGRldi0+
YXJjaC5hbWQucm9vdF90YWJsZSApCisgICAgICAgIHJldHVybjsKIAotICAg
IC8qIFBhZ2VzIGxlYWtlZCBpbiBmYWlsdXJlIGNhc2UgKi8KLSAgICByZXR1
cm4gbGV2ZWwgPyAtRU5PTUVNIDogMDsKKyAgICBBU1NFUlQocGFnZV9saXN0
X2VtcHR5KCZoZC0+YXJjaC5wZ3RhYmxlcy5saXN0KSk7CisgICAgcGFnZV9s
aXN0X21vdmUoJmhkLT5hcmNoLnBndGFibGVzLmxpc3QsICZwZGV2LT5hcmNo
LnBndGFibGVzX2xpc3QpOworICAgIHdoaWxlICggaW9tbXVfZnJlZV9wZ3Rh
Ymxlcyhkb21faW8pID09IC1FUkVTVEFSVCApCisgICAgICAgIC8qIG5vdGhp
bmcgKi87CisgICAgcGRldi0+YXJjaC5hbWQucm9vdF90YWJsZSA9IE5VTEw7
CiB9CiAKIC8qCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9w
Y2lfYW1kX2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
YW1kL3BjaV9hbWRfaW9tbXUuYwpAQCAtMjYsNyArMjYsNyBAQAogI2luY2x1
ZGUgIi4uL2F0cy5oIgogCiAvKiBkb21faW8gaXMgdXNlZCBhcyBhIHNlbnRp
bmVsIGZvciBxdWFyYW50aW5lZCBkZXZpY2VzICovCi0jZGVmaW5lIFFVQVJB
TlRJTkVfU0tJUChkKSAoKGQpID09IGRvbV9pbyAmJiAhZG9tX2lvbW11KGQp
LT5hcmNoLmFtZC5yb290X3RhYmxlKQorI2RlZmluZSBRVUFSQU5USU5FX1NL
SVAoZCwgcCkgKChkKSA9PSBkb21faW8gJiYgIShwKS0+YXJjaC5hbWQucm9v
dF90YWJsZSkKIAogc3RhdGljIGJvb2xfdCBfX3JlYWRfbW9zdGx5IGluaXRf
ZG9uZTsKIApAQCAtMTI1LDggKzEyNSwxMCBAQCBzdGF0aWMgaW50IF9fbXVz
dF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfCiAgICAgdTggYnVzID0gcGRldi0+
YnVzOwogICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11
KGRvbWFpbik7CiAgICAgY29uc3Qgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2
cnNfZGV2OworICAgIGNvbnN0IHN0cnVjdCBwYWdlX2luZm8gKnJvb3RfcGc7
CisgICAgZG9taWRfdCBkb21pZDsKIAotICAgIGlmICggUVVBUkFOVElORV9T
S0lQKGRvbWFpbikgKQorICAgIGlmICggUVVBUkFOVElORV9TS0lQKGRvbWFp
biwgcGRldikgKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIEJVR19PTigh
aGQtPmFyY2guYW1kLnBhZ2luZ19tb2RlIHx8ICFpb21tdS0+ZGV2X3RhYmxl
LmJ1ZmZlcik7CkBAIC0xNDcsMTQgKzE0OSwyNSBAQCBzdGF0aWMgaW50IF9f
bXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfCiAgICAgZHRlID0gJnRhYmxl
W3JlcV9pZF07CiAgICAgaXZyc19kZXYgPSAmZ2V0X2l2cnNfbWFwcGluZ3Mo
aW9tbXUtPnNlZylbcmVxX2lkXTsKIAorICAgIGlmICggZG9tYWluICE9IGRv
bV9pbyApCisgICAgeworICAgICAgICByb290X3BnID0gaGQtPmFyY2guYW1k
LnJvb3RfdGFibGU7CisgICAgICAgIGRvbWlkID0gZG9tYWluLT5kb21haW5f
aWQ7CisgICAgfQorICAgIGVsc2UKKyAgICB7CisgICAgICAgIHJvb3RfcGcg
PSBwZGV2LT5hcmNoLmFtZC5yb290X3RhYmxlOworICAgICAgICBkb21pZCA9
IHBkZXYtPmFyY2gucHNldWRvX2RvbWlkOworICAgIH0KKwogICAgIHNwaW5f
bG9ja19pcnFzYXZlKCZpb21tdS0+bG9jaywgZmxhZ3MpOwogCiAgICAgaWYg
KCAhZHRlLT52IHx8ICFkdGUtPnR2ICkKICAgICB7CiAgICAgICAgIC8qIGJp
bmQgRFRFIHRvIGRvbWFpbiBwYWdlLXRhYmxlcyAqLwogICAgICAgICByYyA9
IGFtZF9pb21tdV9zZXRfcm9vdF9wYWdlX3RhYmxlKAotICAgICAgICAgICAg
ICAgICBkdGUsIHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2guYW1kLnJvb3RfdGFi
bGUpLAotICAgICAgICAgICAgICAgICBkb21haW4tPmRvbWFpbl9pZCwgaGQt
PmFyY2guYW1kLnBhZ2luZ19tb2RlLCBzcl9mbGFncyk7CisgICAgICAgICAg
ICAgICAgIGR0ZSwgcGFnZV90b19tYWRkcihyb290X3BnKSwgZG9taWQsCisg
ICAgICAgICAgICAgICAgIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSwgc3Jf
ZmxhZ3MpOwogICAgICAgICBpZiAoIHJjICkKICAgICAgICAgewogICAgICAg
ICAgICAgQVNTRVJUKHJjIDwgMCk7CkBAIC0xODEsNyArMTk0LDcgQEAgc3Rh
dGljIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXwogCiAgICAg
ICAgIGFtZF9pb21tdV9mbHVzaF9kZXZpY2UoaW9tbXUsIHJlcV9pZCk7CiAg
ICAgfQotICAgIGVsc2UgaWYgKCBkdGUtPnB0X3Jvb3QgIT0gbWZuX3gocGFn
ZV90b19tZm4oaGQtPmFyY2guYW1kLnJvb3RfdGFibGUpKSApCisgICAgZWxz
ZSBpZiAoIGR0ZS0+cHRfcm9vdCAhPSBtZm5feChwYWdlX3RvX21mbihyb290
X3BnKSkgKQogICAgIHsKICAgICAgICAgLyoKICAgICAgICAgICogU3RyaWN0
bHkgc3BlYWtpbmcgaWYgdGhlIGRldmljZSBpcyB0aGUgb25seSBvbmUgd2l0
aCB0aGlzIHJlcXVlc3RvcgpAQCAtMTk0LDggKzIwNyw4IEBAIHN0YXRpYyBp
bnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICAgICAgICAg
IHJjID0gLUVPUE5PVFNVUFA7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAg
IHJjID0gYW1kX2lvbW11X3NldF9yb290X3BhZ2VfdGFibGUoCi0gICAgICAg
ICAgICAgICAgICAgICBkdGUsIHBhZ2VfdG9fbWFkZHIoaGQtPmFyY2guYW1k
LnJvb3RfdGFibGUpLAotICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5k
b21haW5faWQsIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSwgc3JfZmxhZ3Mp
OworICAgICAgICAgICAgICAgICAgICAgZHRlLCBwYWdlX3RvX21hZGRyKHJv
b3RfcGcpLCBkb21pZCwKKyAgICAgICAgICAgICAgICAgICAgIGhkLT5hcmNo
LmFtZC5wYWdpbmdfbW9kZSwgc3JfZmxhZ3MpOwogICAgICAgICBpZiAoIHJj
IDwgMCApCiAgICAgICAgIHsKICAgICAgICAgICAgIHNwaW5fdW5sb2NrX2ly
cXJlc3RvcmUoJmlvbW11LT5sb2NrLCBmbGFncyk7CkBAIC0yMTQsNiArMjI3
LDcgQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVw
XwogICAgICAgICAgICAgICAqIGludGVuZGVkIGFueXdheS4KICAgICAgICAg
ICAgICAgKi8KICAgICAgICAgICAgICAhcGRldi0+ZG9tYWluLT5pc19keWlu
ZyAmJgorICAgICAgICAgICAgIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gJiYK
ICAgICAgICAgICAgICAoYW55X3BkZXZfYmVoaW5kX2lvbW11KHBkZXYtPmRv
bWFpbiwgcGRldiwgaW9tbXUpIHx8CiAgICAgICAgICAgICAgIHBkZXYtPnBo
YW50b21fc3RyaWRlKSApCiAgICAgICAgICAgICBBTURfSU9NTVVfV0FSTigi
ICVwcDogcmVhc3NpZ25tZW50IG1heSBjYXVzZSAlcGQgZGF0YSBjb3JydXB0
aW9uXG4iLApAQCAtMjQ2LDkgKzI2MCw4IEBAIHN0YXRpYyBpbnQgX19tdXN0
X2NoZWNrIGFtZF9pb21tdV9zZXR1cF8KICAgICBBTURfSU9NTVVfREVCVUco
IlNldHVwIEkvTyBwYWdlIHRhYmxlOiBkZXZpY2UgaWQgPSAlI3gsIHR5cGUg
PSAlI3gsICIKICAgICAgICAgICAgICAgICAgICAgInJvb3QgdGFibGUgPSAl
IyJQUkl4NjQiLCAiCiAgICAgICAgICAgICAgICAgICAgICJkb21haW4gPSAl
ZCwgcGFnaW5nIG1vZGUgPSAlZFxuIiwKLSAgICAgICAgICAgICAgICAgICAg
cmVxX2lkLCBwZGV2LT50eXBlLAotICAgICAgICAgICAgICAgICAgICBwYWdl
X3RvX21hZGRyKGhkLT5hcmNoLmFtZC5yb290X3RhYmxlKSwKLSAgICAgICAg
ICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQsIGhkLT5hcmNoLmFtZC5w
YWdpbmdfbW9kZSk7CisgICAgICAgICAgICAgICAgICAgIHJlcV9pZCwgcGRl
di0+dHlwZSwgcGFnZV90b19tYWRkcihyb290X3BnKSwKKyAgICAgICAgICAg
ICAgICAgICAgZG9taWQsIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSk7CiAK
ICAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CiAKQEAgLTMyNyw3ICsz
NDAsNyBAQCBpbnQgYW1kX2lvbW11X2FsbG9jX3Jvb3Qoc3RydWN0IGRvbWFp
biAqCiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9t
bXUoZCk7CiAKLSAgICBpZiAoIHVubGlrZWx5KCFoZC0+YXJjaC5hbWQucm9v
dF90YWJsZSkgKQorICAgIGlmICggdW5saWtlbHkoIWhkLT5hcmNoLmFtZC5y
b290X3RhYmxlKSAmJiBkICE9IGRvbV9pbyApCiAgICAgewogICAgICAgICBo
ZC0+YXJjaC5hbWQucm9vdF90YWJsZSA9IGlvbW11X2FsbG9jX3BndGFibGUo
aGQpOwogICAgICAgICBpZiAoICFoZC0+YXJjaC5hbWQucm9vdF90YWJsZSAp
CkBAIC0zOTEsNyArNDA0LDcgQEAgc3RhdGljIHZvaWQgYW1kX2lvbW11X2Rp
c2FibGVfZG9tYWluX2RldgogICAgIGludCByZXFfaWQ7CiAgICAgdTggYnVz
ID0gcGRldi0+YnVzOwogCi0gICAgaWYgKCBRVUFSQU5USU5FX1NLSVAoZG9t
YWluKSApCisgICAgaWYgKCBRVUFSQU5USU5FX1NLSVAoZG9tYWluLCBwZGV2
KSApCiAgICAgICAgIHJldHVybjsKIAogICAgIEFTU0VSVChwY2lkZXZzX2xv
Y2tlZCgpKTsKQEAgLTQzMCw3ICs0NDMsNyBAQCBzdGF0aWMgdm9pZCBhbWRf
aW9tbXVfZGlzYWJsZV9kb21haW5fZGV2CiAKICAgICAgICAgQU1EX0lPTU1V
X0RFQlVHKCJEaXNhYmxlOiBkZXZpY2UgaWQgPSAlI3gsICIKICAgICAgICAg
ICAgICAgICAgICAgICAgICJkb21haW4gPSAlZCwgcGFnaW5nIG1vZGUgPSAl
ZFxuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgIHJlcV9pZCwgIGRvbWFp
bi0+ZG9tYWluX2lkLAorICAgICAgICAgICAgICAgICAgICAgICAgcmVxX2lk
LCBkdGUtPmRvbWFpbl9pZCwKICAgICAgICAgICAgICAgICAgICAgICAgIGRv
bV9pb21tdShkb21haW4pLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSk7CiAgICAg
fQogICAgIGVsc2UKQEAgLTQ1NCw3ICs0NjcsNyBAQCBzdGF0aWMgaW50IGNm
X2NoZWNrIHJlYXNzaWduX2RldmljZSgKICAgICAgICAgcmV0dXJuIC1FTk9E
RVY7CiAgICAgfQogCi0gICAgaWYgKCAhUVVBUkFOVElORV9TS0lQKHRhcmdl
dCkgKQorICAgIGlmICggIVFVQVJBTlRJTkVfU0tJUCh0YXJnZXQsIHBkZXYp
ICkKICAgICB7CiAgICAgICAgIHJjID0gYW1kX2lvbW11X3NldHVwX2RvbWFp
bl9kZXZpY2UodGFyZ2V0LCBpb21tdSwgZGV2Zm4sIHBkZXYpOwogICAgICAg
ICBpZiAoIHJjICkKQEAgLTY1NSw2ICs2NjgsOCBAQCBzdGF0aWMgaW50IGNm
X2NoZWNrIGFtZF9pb21tdV9yZW1vdmVfZGV2CiAgICAgICAgIEFNRF9JT01N
VV9XQVJOKCIlcGQ6IHVuaXR5IHVubWFwcGluZyBmYWlsZWQgZm9yICVwcFxu
IiwKICAgICAgICAgICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluLCAmcGRl
di0+c2JkZik7CiAKKyAgICBhbWRfaW9tbXVfcXVhcmFudGluZV90ZWFyZG93
bihwZGV2KTsKKwogICAgIGlvbW11X2ZyZWVfZG9taWQocGRldi0+YXJjaC5w
c2V1ZG9fZG9taWQsIGlvbW11LT5kb21pZF9tYXApOwogICAgIHBkZXYtPmFy
Y2gucHNldWRvX2RvbWlkID0gRE9NSURfSU5WQUxJRDsKIAotLS0gYS94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL2lvbW11LmMKQEAgLTQ2NiwyMSArNDY2LDIyIEBAIGlu
dCBpb21tdV9pb3RsYl9mbHVzaF9hbGwoc3RydWN0IGRvbWFpbgogICAgIHJl
dHVybiByYzsKIH0KIAotc3RhdGljIGludCBfX2luaXQgaW9tbXVfcXVhcmFu
dGluZV9pbml0KHZvaWQpCitpbnQgaW9tbXVfcXVhcmFudGluZV9kZXZfaW5p
dChkZXZpY2VfdCAqZGV2KQogewogICAgIGNvbnN0IHN0cnVjdCBkb21haW5f
aW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbV9pbyk7Ci0gICAgaW50IHJjOwog
Ci0gICAgZG9tX2lvLT5vcHRpb25zIHw9IFhFTl9ET01DVExfQ0RGX2lvbW11
OworICAgIGlmICggIWlvbW11X3F1YXJhbnRpbmUgfHwgIWhkLT5wbGF0Zm9y
bV9vcHMtPnF1YXJhbnRpbmVfaW5pdCApCisgICAgICAgIHJldHVybiAwOwog
Ci0gICAgcmMgPSBpb21tdV9kb21haW5faW5pdChkb21faW8sIDApOwotICAg
IGlmICggcmMgfHwgaW9tbXVfcXVhcmFudGluZSA8IElPTU1VX3F1YXJhbnRp
bmVfc2NyYXRjaF9wYWdlICkKLSAgICAgICAgcmV0dXJuIHJjOworICAgIHJl
dHVybiBpb21tdV9jYWxsKGhkLT5wbGF0Zm9ybV9vcHMsIHF1YXJhbnRpbmVf
aW5pdCwKKyAgICAgICAgICAgICAgICAgICAgICBkZXYsIGlvbW11X3F1YXJh
bnRpbmUgPT0gSU9NTVVfcXVhcmFudGluZV9zY3JhdGNoX3BhZ2UpOworfQog
Ci0gICAgaWYgKCAhaGQtPnBsYXRmb3JtX29wcy0+cXVhcmFudGluZV9pbml0
ICkKLSAgICAgICAgcmV0dXJuIDA7CitzdGF0aWMgaW50IF9faW5pdCBpb21t
dV9xdWFyYW50aW5lX2luaXQodm9pZCkKK3sKKyAgICBkb21faW8tPm9wdGlv
bnMgfD0gWEVOX0RPTUNUTF9DREZfaW9tbXU7CiAKLSAgICByZXR1cm4gaGQt
PnBsYXRmb3JtX29wcy0+cXVhcmFudGluZV9pbml0KGRvbV9pbyk7CisgICAg
cmV0dXJuIGlvbW11X2RvbWFpbl9pbml0KGRvbV9pbywgMCk7CiB9CiAKIGlu
dCBfX2luaXQgaW9tbXVfc2V0dXAodm9pZCkKLS0tIGEveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvcGNpLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvcGNpLmMKQEAgLTkyMSw5ICs5MjEsMTYgQEAgc3RhdGljIGludCBkZWFz
c2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbgogICAgICAgICByZXR1cm4gLUVO
T0RFVjsKIAogICAgIC8qIERlLWFzc2lnbm1lbnQgZnJvbSBkb21faW8gc2hv
dWxkIGRlLXF1YXJhbnRpbmUgdGhlIGRldmljZSAqLwotICAgIHRhcmdldCA9
ICgocGRldi0+cXVhcmFudGluZSB8fCBpb21tdV9xdWFyYW50aW5lKSAmJgot
ICAgICAgICAgICAgICBwZGV2LT5kb21haW4gIT0gZG9tX2lvKSA/Ci0gICAg
ICAgIGRvbV9pbyA6IGhhcmR3YXJlX2RvbWFpbjsKKyAgICBpZiAoIChwZGV2
LT5xdWFyYW50aW5lIHx8IGlvbW11X3F1YXJhbnRpbmUpICYmIHBkZXYtPmRv
bWFpbiAhPSBkb21faW8gKQorICAgIHsKKyAgICAgICAgcmV0ID0gaW9tbXVf
cXVhcmFudGluZV9kZXZfaW5pdChwY2lfdG9fZGV2KHBkZXYpKTsKKyAgICAg
ICAgaWYgKCByZXQgKQorICAgICAgICAgICByZXR1cm4gcmV0OworCisgICAg
ICAgIHRhcmdldCA9IGRvbV9pbzsKKyAgICB9CisgICAgZWxzZQorICAgICAg
ICB0YXJnZXQgPSBoYXJkd2FyZV9kb21haW47CiAKICAgICB3aGlsZSAoIHBk
ZXYtPnBoYW50b21fc3RyaWRlICkKICAgICB7CkBAIC0xNDk4LDYgKzE1MDUs
MTMgQEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4g
KgogICAgIGlmICggcmMgKQogICAgICAgICBnb3RvIGRvbmU7CiAKKyAgICBp
ZiAoIHBkZXYtPmRvbWFpbiAhPSBkb21faW8gKQorICAgIHsKKyAgICAgICAg
cmMgPSBpb21tdV9xdWFyYW50aW5lX2Rldl9pbml0KHBjaV90b19kZXYocGRl
dikpOworICAgICAgICBpZiAoIHJjICkKKyAgICAgICAgICAgIGdvdG8gZG9u
ZTsKKyAgICB9CisKICAgICBwZGV2LT5mYXVsdC5jb3VudCA9IDA7CiAKICAg
ICBpZiAoIChyYyA9IGlvbW11X2NhbGwoaGQtPnBsYXRmb3JtX29wcywgYXNz
aWduX2RldmljZSwgZCwgZGV2Zm4sCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5jCkBAIC00NSw2ICs0NSwxMSBAQAogCiAvKiBkb21f
aW8gaXMgdXNlZCBhcyBhIHNlbnRpbmVsIGZvciBxdWFyYW50aW5lZCBkZXZp
Y2VzICovCiAjZGVmaW5lIFFVQVJBTlRJTkVfU0tJUChkLCBwZ2RfbWFkZHIp
ICgoZCkgPT0gZG9tX2lvICYmICEocGdkX21hZGRyKSkKKyNkZWZpbmUgREVW
SUNFX0RPTUlEKGQsIHBkZXYpICgoZCkgIT0gZG9tX2lvID8gKGQpLT5kb21h
aW5faWQgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgOiAocGRldiktPmFyY2gucHNldWRvX2RvbWlkKQorI2RlZmlu
ZSBERVZJQ0VfUEdUQUJMRShkLCBwZGV2KSAoKGQpICE9IGRvbV9pbyBcCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/IGRvbV9pb21tdShk
KS0+YXJjaC52dGQucGdkX21hZGRyIFwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIDogKHBkZXYpLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIpCiAK
IC8qIFBvc3NpYmxlIHVuZmlsdGVyZWQgTEFQSUMvTVNJIG1lc3NhZ2VzIGZy
b20gdW50cnVzdGVkIHNvdXJjZXM/ICovCiBib29sIF9fcmVhZF9tb3N0bHkg
dW50cnVzdGVkX21zaTsKQEAgLTEwOCwxMiArMTEzLDE3IEBAIHN0YXRpYyBp
bnQgZ2V0X2lvbW11X2RpZChkb21pZF90IGRvbWlkLAogCiAjZGVmaW5lIERJ
RF9GSUVMRF9XSURUSCAxNgogI2RlZmluZSBESURfSElHSF9PRkZTRVQgOAor
CisvKgorICogVGhpcyBmdW5jdGlvbiBtYXkgaGF2ZSAiY29udGV4dCIgcGFz
c2VkIGFzIE5VTEwsIHRvIG1lcmVseSBvYnRhaW4gYSBESUQKKyAqIGZvciAi
ZG9taWQiLgorICovCiBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9p
ZChzdHJ1Y3QgY29udGV4dF9lbnRyeSAqY29udGV4dCwKICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGRvbWlkX3QgZG9taWQsIHN0cnVjdCB2
dGRfaW9tbXUgKmlvbW11KQogewogICAgIHVuc2lnbmVkIGludCBpOwogCi0g
ICAgQVNTRVJUKHNwaW5faXNfbG9ja2VkKCZpb21tdS0+bG9jaykpOworICAg
IEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKIAogICAgIGlmICggZG9taWRf
bWFwcGluZyhpb21tdSkgKQogICAgIHsKQEAgLTEzOCw4ICsxNDgsMTIgQEAg
c3RhdGljIGludCBjb250ZXh0X3NldF9kb21haW5faWQoc3RydWN0CiAgICAg
ZWxzZQogICAgICAgICBpID0gY29udmVydF9kb21pZChpb21tdSwgZG9taWQp
OwogCi0gICAgY29udGV4dC0+aGkgJj0gfigoKDEgPDwgRElEX0ZJRUxEX1dJ
RFRIKSAtIDEpIDw8IERJRF9ISUdIX09GRlNFVCk7Ci0gICAgY29udGV4dC0+
aGkgfD0gKGkgJiAoKDEgPDwgRElEX0ZJRUxEX1dJRFRIKSAtIDEpKSA8PCBE
SURfSElHSF9PRkZTRVQ7CisgICAgaWYgKCBjb250ZXh0ICkKKyAgICB7Cisg
ICAgICAgIGNvbnRleHQtPmhpICY9IH4oKCgxIDw8IERJRF9GSUVMRF9XSURU
SCkgLSAxKSA8PCBESURfSElHSF9PRkZTRVQpOworICAgICAgICBjb250ZXh0
LT5oaSB8PSAoaSAmICgoMSA8PCBESURfRklFTERfV0lEVEgpIC0gMSkpIDw8
IERJRF9ISUdIX09GRlNFVDsKKyAgICB9CisKICAgICByZXR1cm4gMDsKIH0K
IApAQCAtMTk0LDggKzIwOCwxMiBAQCBzdGF0aWMgdm9pZCBjaGVja19jbGVh
bnVwX2RvbWlkX21hcChjb25zCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqZXhjbHVkZSwKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2dGRf
aW9tbXUgKmlvbW11KQogewotICAgIGJvb2wgZm91bmQgPSBhbnlfcGRldl9i
ZWhpbmRfaW9tbXUoZCwgZXhjbHVkZSwgaW9tbXUpOworICAgIGJvb2wgZm91
bmQ7CisKKyAgICBpZiAoIGQgPT0gZG9tX2lvICkKKyAgICAgICAgcmV0dXJu
OwogCisgICAgZm91bmQgPSBhbnlfcGRldl9iZWhpbmRfaW9tbXUoZCwgZXhj
bHVkZSwgaW9tbXUpOwogICAgIC8qCiAgICAgICogSGlkZGVuIGRldmljZXMg
YXJlIGFzc29jaWF0ZWQgd2l0aCBEb21YRU4gYnV0IHVzYWJsZSBieSB0aGUg
aGFyZHdhcmUKICAgICAgKiBkb21haW4uIEhlbmNlIHRoZXkgbmVlZCBjb25z
aWRlcmluZyBoZXJlIGFzIHdlbGwuCkBAIC0yMTIsNyArMjMwLDcgQEAgc3Rh
dGljIHZvaWQgY2hlY2tfY2xlYW51cF9kb21pZF9tYXAoY29ucwogCiBkb21p
ZF90IGRpZF90b19kb21haW5faWQoY29uc3Qgc3RydWN0IHZ0ZF9pb21tdSAq
aW9tbXUsIHVuc2lnbmVkIGludCBkaWQpCiB7Ci0gICAgaWYgKCBkaWQgPj0g
bWluKGNhcF9uZG9tcyhpb21tdS0+Y2FwKSwgRE9NSURfTUFTSyArIDEpICkK
KyAgICBpZiAoIGRpZCA+PSBjYXBfbmRvbXMoaW9tbXUtPmNhcCkgKQogICAg
ICAgICByZXR1cm4gRE9NSURfSU5WQUxJRDsKIAogICAgIGlmICggIWRvbWlk
X21hcHBpbmcoaW9tbXUpICkKQEAgLTE0MjgsNyArMTQ0Niw3IEBAIGludCBk
b21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICAgICAgZG9taWQgPSBk
aWRfdG9fZG9tYWluX2lkKGlvbW11LCBwcmV2X2RpZCk7CiAgICAgICAgIGlm
ICggZG9taWQgPCBET01JRF9GSVJTVF9SRVNFUlZFRCApCiAgICAgICAgICAg
ICBwcmV2X2RvbSA9IHJjdV9sb2NrX2RvbWFpbl9ieV9pZChkb21pZCk7Ci0g
ICAgICAgIGVsc2UgaWYgKCBkb21pZCA9PSBET01JRF9JTyApCisgICAgICAg
IGVsc2UgaWYgKCBwZGV2ID8gZG9taWQgPT0gcGRldi0+YXJjaC5wc2V1ZG9f
ZG9taWQgOiBkb21pZCA+IERPTUlEX01BU0sgKQogICAgICAgICAgICAgcHJl
dl9kb20gPSByY3VfbG9ja19kb21haW4oZG9tX2lvKTsKICAgICAgICAgaWYg
KCAhcHJldl9kb20gKQogICAgICAgICB7CkBAIC0xNTg1LDE1ICsxNjAzLDEy
IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZSgKICAgICB7CiAg
ICAgICAgIGlmICggIXByZXZfZG9tICkKICAgICAgICAgICAgIHJldCA9IGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCBidXMsIGRl
dmZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBw
ZGV2KSk7CiAgICAgICAgIGVsc2UgaWYgKCBwcmV2X2RvbSAhPSBkb21haW4g
KSAvKiBBdm9pZCBpbmZpbml0ZSByZWN1cnNpb24uICovCi0gICAgICAgIHsK
LSAgICAgICAgICAgIGhkID0gZG9tX2lvbW11KHByZXZfZG9tKTsKICAgICAg
ICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdfb25lKHByZXZf
ZG9tLCBpb21tdSwgYnVzLCBkZXZmbiwgcGRldiwKLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWlu
X2lkLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgaGQtPmFyY2gudnRkLnBnZF9tYWRkciwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERFVklDRV9ET01JRChw
cmV2X2RvbSwgcGRldiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBERVZJQ0VfUEdUQUJMRShwcmV2X2RvbSwgcGRl
diksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBtb2RlICYgTUFQX1dJVEhfUk1SUikgPCAwOwotICAgICAgICB9CiAg
ICAgICAgIGVsc2UKICAgICAgICAgICAgIHJldCA9IDE7CiAKQEAgLTE2MTUs
NyArMTYzMCw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGlu
ZyhzdHJ1Y3QKIHsKICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQg
KmRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CiAg
ICAgY29uc3Qgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwotICAgIHBh
ZGRyX3QgcGdkX21hZGRyID0gZG9tX2lvbW11KGRvbWFpbiktPmFyY2gudnRk
LnBnZF9tYWRkcjsKKyAgICBwYWRkcl90IHBnZF9tYWRkciA9IERFVklDRV9Q
R1RBQkxFKGRvbWFpbiwgcGRldik7CiAgICAgZG9taWRfdCBvcmlnX2RvbWlk
ID0gcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQ7CiAgICAgaW50IHJldCA9IDA7
CiAgICAgdW5zaWduZWQgaW50IGksIG1vZGUgPSAwOwpAQCAtMTY0NCw3ICsx
NjU5LDcgQEAgc3RhdGljIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nKHN0
cnVjdAogICAgICAgICBicmVhazsKICAgICB9CiAKLSAgICBpZiAoIGRvbWFp
biAhPSBwZGV2LT5kb21haW4gKQorICAgIGlmICggZG9tYWluICE9IHBkZXYt
PmRvbWFpbiAmJiBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkKICAgICB7CiAg
ICAgICAgIGlmICggcGRldi0+ZG9tYWluLT5pc19keWluZyApCiAgICAgICAg
ICAgICBtb2RlIHw9IE1BUF9PV05FUl9EWUlORzsKQEAgLTE2ODYsOCArMTcw
MSw4IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1
Y3QKICAgICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApCiAgICAgICAgICAgICBw
cmludGsoVlREUFJFRklYICIlcGQ6UENJZTogbWFwICVwcFxuIiwKICAgICAg
ICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRl
dmZuKSk7Ci0gICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X21hcHBpbmdf
b25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYsIGRvbWFp
bi0+ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCisgICAgICAgIHJldCA9IGRvbWFp
bl9jb250ZXh0X21hcHBpbmdfb25lKGRvbWFpbiwgZHJoZC0+aW9tbXUsIGJ1
cywgZGV2Zm4sIHBkZXYsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIERFVklDRV9ET01JRChkb21haW4sIHBkZXYpLCBwZ2Rf
bWFkZHIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIG1vZGUpOwogICAgICAgICBpZiAoIHJldCA+IDAgKQogICAgICAgICAg
ICAgcmV0ID0gMDsKQEAgLTE3MTMsOCArMTcyOCw4IEBAIHN0YXRpYyBpbnQg
ZG9tYWluX2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICAgICAg
ICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7CiAK
ICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9t
YWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwKLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcGRldiwgZG9tYWluLT5kb21h
aW5faWQsIHBnZF9tYWRkciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHBkZXYsIERFVklDRV9ET01JRChkb21haW4s
IHBkZXYpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBwZ2RfbWFkZHIsIG1vZGUpOwogICAgICAgICBpZiAoIHJldCA8IDAg
KQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIHByZXZfcHJlc2VudCA9
IHJldDsKQEAgLTE3NDIsOCArMTc1Nyw4IEBAIHN0YXRpYyBpbnQgZG9tYWlu
X2NvbnRleHRfbWFwcGluZyhzdHJ1Y3QKICAgICAgICAgICovCiAgICAgICAg
IGlmICggcmV0ID49IDAgKQogICAgICAgICAgICAgcmV0ID0gZG9tYWluX2Nv
bnRleHRfbWFwcGluZ19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBk
ZXZmbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIE5VTEwsIGRvbWFpbi0+ZG9tYWluX2lkLCBwZ2RfbWFkZHIsCi0g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBt
b2RlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIE5VTEwsIERFVklDRV9ET01JRChkb21haW4sIHBkZXYpLAorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGdk
X21hZGRyLCBtb2RlKTsKIAogICAgICAgICAvKgogICAgICAgICAgKiBEZXZp
Y2VzIGJlaGluZCBQQ0llLXRvLVBDSS9QQ0l4IGJyaWRnZSBtYXkgZ2VuZXJh
dGUgZGlmZmVyZW50CkBAIC0xNzU4LDggKzE3NzMsOCBAQCBzdGF0aWMgaW50
IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0CiAgICAgICAgIGlmICgg
IXJldCAmJiBwZGV2X3R5cGUoc2VnLCBidXMsIGRldmZuKSA9PSBERVZfVFlQ
RV9QQ0llMlBDSV9CUklER0UgJiYKICAgICAgICAgICAgICAoc2VjYnVzICE9
IHBkZXYtPmJ1cyB8fCBwZGV2LT5kZXZmbiAhPSAwKSApCiAgICAgICAgICAg
ICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShkb21haW4sIGRy
aGQtPmlvbW11LCBzZWNidXMsIDAsCi0gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBkb21haW4tPmRvbWFpbl9p
ZCwgcGdkX21hZGRyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgbW9kZSk7CisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBERVZJQ0VfRE9NSUQoZG9t
YWluLCBwZGV2KSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHBnZF9tYWRkciwgbW9kZSk7CiAKICAgICAgICAgaWYg
KCByZXQgKQogICAgICAgICB7CkBAIC0xODAxLDkgKzE4MTYsNiBAQCBpbnQg
ZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKAogICAgIGludCBpb21tdV9kb21p
ZCwgcmMsIHJldDsKICAgICBib29sX3QgZmx1c2hfZGV2X2lvdGxiOwogCi0g
ICAgaWYgKCBRVUFSQU5USU5FX1NLSVAoZG9tYWluLCBkb21faW9tbXUoZG9t
YWluKS0+YXJjaC52dGQucGdkX21hZGRyKSApCi0gICAgICAgIHJldHVybiAw
OwotCiAgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOwogICAgIHNwaW5f
bG9jaygmaW9tbXUtPmxvY2spOwogCkBAIC0xOTA1LDcgKzE5MTcsNyBAQCBz
dGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkb21hCiAgICAg
ICAgICAgICBwcmludGsoVlREUFJFRklYICIlcGQ6UENJZTogdW5tYXAgJXBw
XG4iLAogICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhz
ZWcsIGJ1cywgZGV2Zm4pKTsKICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRl
eHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4sCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW4tPmRv
bWFpbl9pZCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7CiAgICAgICAgIGlm
ICggIXJldCAmJiBkZXZmbiA9PSBwZGV2LT5kZXZmbiAmJiBhdHNfZGV2aWNl
KHBkZXYsIGRyaGQpID4gMCApCiAgICAgICAgICAgICBkaXNhYmxlX2F0c19k
ZXZpY2UocGRldik7CiAKQEAgLTE5MTksNyArMTkzMSw3IEBAIHN0YXRpYyBj
b25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRvbWEKICAgICAgICAgICAg
IHByaW50ayhWVERQUkVGSVggIiVwZDpQQ0k6IHVubWFwICVwcFxuIiwKICAg
ICAgICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMs
IGRldmZuKSk7CiAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFw
X29uZShkb21haW4sIGlvbW11LCBidXMsIGRldmZuLAotICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQp
OworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgREVW
SUNFX0RPTUlEKGRvbWFpbiwgcGRldikpOwogICAgICAgICBpZiAoIHJldCAp
CiAgICAgICAgICAgICBicmVhazsKIApAQCAtMTk0MiwxOCArMTk1NCwxMiBA
QCBzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkb21hCiAg
ICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCisgICAgICAgIHJldCA9
IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11LCB0bXBf
YnVzLCB0bXBfZGV2Zm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7CiAgICAg
ICAgIC8qIFBDSWUgdG8gUENJL1BDSXggYnJpZGdlICovCi0gICAgICAgIGlm
ICggcGRldl90eXBlKHNlZywgdG1wX2J1cywgdG1wX2RldmZuKSA9PSBERVZf
VFlQRV9QQ0llMlBDSV9CUklER0UgKQotICAgICAgICB7Ci0gICAgICAgICAg
ICByZXQgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBpb21t
dSwgdG1wX2J1cywgdG1wX2RldmZuLAotICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGRvbWFpbi0+ZG9tYWluX2lkKTsKLSAg
ICAgICAgICAgIGlmICggIXJldCApCi0gICAgICAgICAgICAgICAgcmV0ID0g
ZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwgaW9tbXUsIHNlY2J1
cywgMCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOwotICAgICAgICB9Ci0gICAg
ICAgIGVsc2UgLyogTGVnYWN5IFBDSSBicmlkZ2UgKi8KLSAgICAgICAgICAg
IHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4sIGlvbW11
LCB0bXBfYnVzLCB0bXBfZGV2Zm4sCi0gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5kb21haW5faWQpOworICAg
ICAgICBpZiAoICFyZXQgJiYgcGRldl90eXBlKHNlZywgdG1wX2J1cywgdG1w
X2RldmZuKSA9PSBERVZfVFlQRV9QQ0llMlBDSV9CUklER0UgKQorICAgICAg
ICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwg
aW9tbXUsIHNlY2J1cywgMCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQoZG9tYWluLCBwZGV2KSk7
CiAKICAgICAgICAgYnJlYWs7CiAKQEAgLTE5NjQsNyArMTk3MCw3IEBAIHN0
YXRpYyBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRvbWEKICAgICB9
CiAKICAgICBpZiAoICFyZXQgJiYgcGRldi0+ZGV2Zm4gPT0gZGV2Zm4gJiYK
LSAgICAgICAgICFRVUFSQU5USU5FX1NLSVAoZG9tYWluLCBkb21faW9tbXUo
ZG9tYWluKS0+YXJjaC52dGQucGdkX21hZGRyKSApCisgICAgICAgICAhUVVB
UkFOVElORV9TS0lQKGRvbWFpbiwgcGRldi0+YXJjaC52dGQucGdkX21hZGRy
KSApCiAgICAgICAgIGNoZWNrX2NsZWFudXBfZG9taWRfbWFwKGRvbWFpbiwg
cGRldiwgaW9tbXUpOwogCiAgICAgcmV0dXJuIGRyaGQ7CkBAIC0xOTk3LDYg
KzIwMDMsMjYgQEAgc3RhdGljIHZvaWQgY2ZfY2hlY2sgaW9tbXVfZG9tYWlu
X3RlYXJkbwogICAgIFhGUkVFKGhkLT5hcmNoLnZ0ZC5pb21tdV9iaXRtYXAp
OwogfQogCitzdGF0aWMgdm9pZCBxdWFyYW50aW5lX3RlYXJkb3duKHN0cnVj
dCBwY2lfZGV2ICpwZGV2LAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQpCit7Cisg
ICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZG9tX2lv
KTsKKworICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKKworICAgIGlm
ICggIXBkZXYtPmFyY2gudnRkLnBnZF9tYWRkciApCisgICAgICAgIHJldHVy
bjsKKworICAgIEFTU0VSVChwYWdlX2xpc3RfZW1wdHkoJmhkLT5hcmNoLnBn
dGFibGVzLmxpc3QpKTsKKyAgICBwYWdlX2xpc3RfbW92ZSgmaGQtPmFyY2gu
cGd0YWJsZXMubGlzdCwgJnBkZXYtPmFyY2gucGd0YWJsZXNfbGlzdCk7Cisg
ICAgd2hpbGUgKCBpb21tdV9mcmVlX3BndGFibGVzKGRvbV9pbykgPT0gLUVS
RVNUQVJUICkKKyAgICAgICAgLyogbm90aGluZyAqLzsKKyAgICBwZGV2LT5h
cmNoLnZ0ZC5wZ2RfbWFkZHIgPSAwOworCisgICAgaWYgKCBkcmhkICkKKyAg
ICAgICAgY2xlYW51cF9kb21pZF9tYXAocGRldi0+YXJjaC5wc2V1ZG9fZG9t
aWQsIGRyaGQtPmlvbW11KTsKK30KKwogc3RhdGljIGludCBfX211c3RfY2hl
Y2sgY2ZfY2hlY2sgaW50ZWxfaW9tbXVfbWFwX3BhZ2UoCiAgICAgc3RydWN0
IGRvbWFpbiAqZCwgZGZuX3QgZGZuLCBtZm5fdCBtZm4sIHVuc2lnbmVkIGlu
dCBmbGFncywKICAgICB1bnNpZ25lZCBpbnQgKmZsdXNoX2ZsYWdzKQpAQCAt
MjIyMSw2ICsyMjQ3LDggQEAgc3RhdGljIGludCBjZl9jaGVjayBpbnRlbF9p
b21tdV9yZW1vdmVfZAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHJtcnItPmVuZF9hZGRyZXNzLCAwKTsKICAgICB9CiAKKyAgICBxdWFyYW50
aW5lX3RlYXJkb3duKHBkZXYsIGRyaGQpOworCiAgICAgaWYgKCBkcmhkICkK
ICAgICB7CiAgICAgICAgIGlvbW11X2ZyZWVfZG9taWQocGRldi0+YXJjaC5w
c2V1ZG9fZG9taWQsCkBAIC0yNTc5LDcgKzI2MDcsNyBAQCBzdGF0aWMgaW50
IGNmX2NoZWNrIHJlYXNzaWduX2RldmljZV9vd25lCiB7CiAgICAgaW50IHJl
dDsKIAotICAgIGlmICggIVFVQVJBTlRJTkVfU0tJUCh0YXJnZXQsIGRvbV9p
b21tdSh0YXJnZXQpLT5hcmNoLnZ0ZC5wZ2RfbWFkZHIpICkKKyAgICBpZiAo
ICFRVUFSQU5USU5FX1NLSVAodGFyZ2V0LCBwZGV2LT5hcmNoLnZ0ZC5wZ2Rf
bWFkZHIpICkKICAgICB7CiAgICAgICAgIGlmICggIWhhc19hcmNoX3BkZXZz
KHRhcmdldCkgKQogICAgICAgICAgICAgdm14X3BpX2hvb2tzX2Fzc2lnbih0
YXJnZXQpOwpAQCAtMjU5Niw3ICsyNjI0LDcgQEAgc3RhdGljIGludCBjZl9j
aGVjayByZWFzc2lnbl9kZXZpY2Vfb3duZQogICAgICAgICByZXQgPSBkb21h
aW5fY29udGV4dF9tYXBwaW5nKHRhcmdldCwgZGV2Zm4sIHBkZXYpOwogCiAg
ICAgICAgIGlmICggIXJldCAmJiBwZGV2LT5kZXZmbiA9PSBkZXZmbiAmJgot
ICAgICAgICAgICAgICFRVUFSQU5USU5FX1NLSVAoc291cmNlLCBkb21faW9t
bXUoc291cmNlKS0+YXJjaC52dGQucGdkX21hZGRyKSApCisgICAgICAgICAg
ICAgIVFVQVJBTlRJTkVfU0tJUChzb3VyY2UsIHBkZXYtPmFyY2gudnRkLnBn
ZF9tYWRkcikgKQogICAgICAgICB7CiAgICAgICAgICAgICBjb25zdCBzdHJ1
Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQgPSBhY3BpX2ZpbmRfbWF0Y2hlZF9k
cmhkX3VuaXQocGRldik7CiAKQEAgLTI5MTgsNjkgKzI5NDYsMTM2IEBAIHN0
YXRpYyB2b2lkIGNmX2NoZWNrIHZ0ZF9kdW1wX3BhZ2VfdGFibGUKICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGFnYXdfdG9fbGV2ZWwoaGQtPmFy
Y2gudnRkLmFnYXcpLCAwLCAwKTsKIH0KIAotc3RhdGljIGludCBfX2luaXQg
Y2ZfY2hlY2sgaW50ZWxfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBk
b21haW4gKmQpCitzdGF0aWMgaW50IGZpbGxfcXB0KHN0cnVjdCBkbWFfcHRl
ICp0aGlzLCB1bnNpZ25lZCBpbnQgbGV2ZWwsCisgICAgICAgICAgICAgICAg
ICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnc1s2XSkKIHsKLSAgICBzdHJ1Y3Qg
ZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKKyAgICBzdHJ1Y3Qg
ZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkb21faW8pOworICAgIHVu
c2lnbmVkIGludCBpOworICAgIGludCByYyA9IDA7CisKKyAgICBmb3IgKCBp
ID0gMDsgIXJjICYmIGkgPCBQVEVfTlVNOyArK2kgKQorICAgIHsKKyAgICAg
ICAgc3RydWN0IGRtYV9wdGUgKnB0ZSA9ICZ0aGlzW2ldLCAqbmV4dDsKKwor
ICAgICAgICBpZiAoICFkbWFfcHRlX3ByZXNlbnQoKnB0ZSkgKQorICAgICAg
ICB7CisgICAgICAgICAgICBpZiAoICFwZ3NbbGV2ZWxdICkKKyAgICAgICAg
ICAgIHsKKyAgICAgICAgICAgICAgICAvKgorICAgICAgICAgICAgICAgICAq
IFRoZSBwZ3RhYmxlIGFsbG9jYXRvciBpcyBmaW5lIGZvciB0aGUgbGVhZiBw
YWdlLCBhcyB3ZWxsIGFzCisgICAgICAgICAgICAgICAgICogcGFnZSB0YWJs
ZSBwYWdlcywgYW5kIHRoZSByZXN1bHRpbmcgYWxsb2NhdGlvbnMgYXJlIGFs
d2F5cworICAgICAgICAgICAgICAgICAqIHplcm9lZC4KKyAgICAgICAgICAg
ICAgICAgKi8KKyAgICAgICAgICAgICAgICBwZ3NbbGV2ZWxdID0gaW9tbXVf
YWxsb2NfcGd0YWJsZShoZCk7CisgICAgICAgICAgICAgICAgaWYgKCAhcGdz
W2xldmVsXSApCisgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAg
ICAgICByYyA9IC1FTk9NRU07CisgICAgICAgICAgICAgICAgICAgIGJyZWFr
OworICAgICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgIGlmICgg
bGV2ZWwgKQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICAg
ICAgbmV4dCA9IG1hcF92dGRfZG9tYWluX3BhZ2UocGFnZV90b19tYWRkcihw
Z3NbbGV2ZWxdKSk7CisgICAgICAgICAgICAgICAgICAgIHJjID0gZmlsbF9x
cHQobmV4dCwgbGV2ZWwgLSAxLCBwZ3MpOworICAgICAgICAgICAgICAgICAg
ICB1bm1hcF92dGRfZG9tYWluX3BhZ2UobmV4dCk7CisgICAgICAgICAgICAg
ICAgfQorICAgICAgICAgICAgfQorCisgICAgICAgICAgICBkbWFfc2V0X3B0
ZV9hZGRyKCpwdGUsIHBhZ2VfdG9fbWFkZHIocGdzW2xldmVsXSkpOworICAg
ICAgICAgICAgZG1hX3NldF9wdGVfcmVhZGFibGUoKnB0ZSk7CisgICAgICAg
ICAgICBkbWFfc2V0X3B0ZV93cml0YWJsZSgqcHRlKTsKKyAgICAgICAgfQor
ICAgICAgICBlbHNlIGlmICggbGV2ZWwgJiYgIWRtYV9wdGVfc3VwZXJwYWdl
KCpwdGUpICkKKyAgICAgICAgeworICAgICAgICAgICAgbmV4dCA9IG1hcF92
dGRfZG9tYWluX3BhZ2UoZG1hX3B0ZV9hZGRyKCpwdGUpKTsKKyAgICAgICAg
ICAgIHJjID0gZmlsbF9xcHQobmV4dCwgbGV2ZWwgLSAxLCBwZ3MpOworICAg
ICAgICAgICAgdW5tYXBfdnRkX2RvbWFpbl9wYWdlKG5leHQpOworICAgICAg
ICB9CisgICAgfQorCisgICAgcmV0dXJuIHJjOworfQorCitzdGF0aWMgaW50
IGNmX2NoZWNrIGludGVsX2lvbW11X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3Qg
cGNpX2RldiAqcGRldiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGJvb2wgc2NyYXRjaF9wYWdlKQoreworICAg
IHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGRvbV9pbyk7
CiAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7Ci0gICAgc3RydWN0IGRtYV9w
dGUgKnBhcmVudDsKICAgICB1bnNpZ25lZCBpbnQgYWdhdyA9IHdpZHRoX3Rv
X2FnYXcoREVGQVVMVF9ET01BSU5fQUREUkVTU19XSURUSCk7CiAgICAgdW5z
aWduZWQgaW50IGxldmVsID0gYWdhd190b19sZXZlbChhZ2F3KTsKLSAgICBp
bnQgcmMgPSAwOworICAgIGNvbnN0IHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAq
ZHJoZDsKKyAgICBjb25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7
CisgICAgdW5zaWduZWQgaW50IGksIGJkZjsKKyAgICBib29sIHJtcnJfZm91
bmQgPSBmYWxzZTsKKyAgICBpbnQgcmM7CiAKLSAgICBzcGluX2xvY2soJmhk
LT5hcmNoLm1hcHBpbmdfbG9jayk7CisgICAgQVNTRVJUKHBjaWRldnNfbG9j
a2VkKCkpOworICAgIEFTU0VSVCghaGQtPmFyY2gudnRkLnBnZF9tYWRkcik7
CisgICAgQVNTRVJUKHBhZ2VfbGlzdF9lbXB0eSgmaGQtPmFyY2gucGd0YWJs
ZXMubGlzdCkpOwogCi0gICAgaWYgKCBoZC0+YXJjaC52dGQucGdkX21hZGRy
ICkKKyAgICBpZiAoIHBkZXYtPmFyY2gudnRkLnBnZF9tYWRkciApCiAgICAg
ewotICAgICAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsKLSAgICAgICAgZ290
byBvdXQ7CisgICAgICAgIGNsZWFyX2RvbWFpbl9wYWdlKHBkZXYtPmFyY2gu
bGVhZl9tZm4pOworICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgICBw
ZyA9IGlvbW11X2FsbG9jX3BndGFibGUoaGQpOworICAgIGRyaGQgPSBhY3Bp
X2ZpbmRfbWF0Y2hlZF9kcmhkX3VuaXQocGRldik7CisgICAgaWYgKCAhZHJo
ZCApCisgICAgICAgIHJldHVybiAtRU5PREVWOwogCi0gICAgcmMgPSAtRU5P
TUVNOworICAgIHBnID0gaW9tbXVfYWxsb2NfcGd0YWJsZShoZCk7CiAgICAg
aWYgKCAhcGcgKQotICAgICAgICBnb3RvIG91dDsKKyAgICAgICAgcmV0dXJu
IC1FTk9NRU07CisKKyAgICByYyA9IGNvbnRleHRfc2V0X2RvbWFpbl9pZChO
VUxMLCBwZGV2LT5hcmNoLnBzZXVkb19kb21pZCwgZHJoZC0+aW9tbXUpOwog
CisgICAgLyogVHJhbnNpZW50bHkgaW5zdGFsbCB0aGUgcm9vdCBpbnRvIERv
bUlPLCBmb3IgaW9tbXVfaWRlbnRpdHlfbWFwcGluZygpLiAqLwogICAgIGhk
LT5hcmNoLnZ0ZC5wZ2RfbWFkZHIgPSBwYWdlX3RvX21hZGRyKHBnKTsKIAot
ICAgIHBhcmVudCA9IG1hcF92dGRfZG9tYWluX3BhZ2UoaGQtPmFyY2gudnRk
LnBnZF9tYWRkcik7Ci0gICAgd2hpbGUgKCBsZXZlbCApCisgICAgZm9yX2Vh
Y2hfcm1ycl9kZXZpY2UgKCBybXJyLCBiZGYsIGkgKQogICAgIHsKLSAgICAg
ICAgdWludDY0X3QgbWFkZHI7Ci0gICAgICAgIHVuc2lnbmVkIGludCBvZmZz
ZXQ7Ci0KLSAgICAgICAgLyoKLSAgICAgICAgICogVGhlIHBndGFibGUgYWxs
b2NhdG9yIGlzIGZpbmUgZm9yIHRoZSBsZWFmIHBhZ2UsIGFzIHdlbGwgYXMK
LSAgICAgICAgICogcGFnZSB0YWJsZSBwYWdlcywgYW5kIHRoZSByZXN1bHRp
bmcgYWxsb2NhdGlvbnMgYXJlIGFsd2F5cwotICAgICAgICAgKiB6ZXJvZWQu
Ci0gICAgICAgICAqLwotICAgICAgICBwZyA9IGlvbW11X2FsbG9jX3BndGFi
bGUoaGQpOwotCi0gICAgICAgIGlmICggIXBnICkKLSAgICAgICAgICAgIGdv
dG8gb3V0OworICAgICAgICBpZiAoIHJjICkKKyAgICAgICAgICAgIGJyZWFr
OwogCi0gICAgICAgIG1hZGRyID0gcGFnZV90b19tYWRkcihwZyk7Ci0gICAg
ICAgIGZvciAoIG9mZnNldCA9IDA7IG9mZnNldCA8IFBURV9OVU07IG9mZnNl
dCsrICkKKyAgICAgICAgaWYgKCBybXJyLT5zZWdtZW50ID09IHBkZXYtPnNl
ZyAmJiBiZGYgPT0gcGRldi0+c2JkZi5iZGYgKQogICAgICAgICB7Ci0gICAg
ICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAqcHRlID0gJnBhcmVudFtvZmZzZXRd
OworICAgICAgICAgICAgcm1ycl9mb3VuZCA9IHRydWU7CiAKLSAgICAgICAg
ICAgIGRtYV9zZXRfcHRlX2FkZHIoKnB0ZSwgbWFkZHIpOwotICAgICAgICAg
ICAgZG1hX3NldF9wdGVfcmVhZGFibGUoKnB0ZSk7CisgICAgICAgICAgICBy
YyA9IGlvbW11X2lkZW50aXR5X21hcHBpbmcoZG9tX2lvLCBwMm1fYWNjZXNz
X3J3LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHJtcnItPmJhc2VfYWRkcmVzcywgcm1yci0+ZW5kX2FkZHJlc3MsCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMCk7CisgICAg
ICAgICAgICBpZiAoIHJjICkKKyAgICAgICAgICAgICAgICBwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgKKyAgICAgICAgICAgICAgICAgICAgICAgIiVw
cDogUk1SUiBxdWFyYW50aW5lIG1hcHBpbmcgZmFpbGVkXG4iLAorICAgICAg
ICAgICAgICAgICAgICAgICAmcGRldi0+c2JkZik7CiAgICAgICAgIH0KLSAg
ICAgICAgaW9tbXVfc3luY19jYWNoZShwYXJlbnQsIFBBR0VfU0laRSk7Cisg
ICAgfQogCi0gICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShwYXJlbnQp
OwotICAgICAgICBwYXJlbnQgPSBtYXBfdnRkX2RvbWFpbl9wYWdlKG1hZGRy
KTsKLSAgICAgICAgbGV2ZWwtLTsKKyAgICBpb21tdV9pZGVudGl0eV9tYXBf
dGVhcmRvd24oZG9tX2lvKTsKKyAgICBoZC0+YXJjaC52dGQucGdkX21hZGRy
ID0gMDsKKyAgICBwZGV2LT5hcmNoLnZ0ZC5wZ2RfbWFkZHIgPSBwYWdlX3Rv
X21hZGRyKHBnKTsKKworICAgIGlmICggIXJjICYmIHNjcmF0Y2hfcGFnZSAp
CisgICAgeworICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAqcm9vdDsKKyAgICAg
ICAgc3RydWN0IHBhZ2VfaW5mbyAqcGdzWzZdID0ge307CisKKyAgICAgICAg
c3Bpbl9sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOworCisgICAgICAg
IHJvb3QgPSBtYXBfdnRkX2RvbWFpbl9wYWdlKHBkZXYtPmFyY2gudnRkLnBn
ZF9tYWRkcik7CisgICAgICAgIHJjID0gZmlsbF9xcHQocm9vdCwgbGV2ZWwg
LSAxLCBwZ3MpOworICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2Uocm9v
dCk7CisKKyAgICAgICAgcGRldi0+YXJjaC5sZWFmX21mbiA9IHBhZ2VfdG9f
bWZuKHBnc1swXSk7CisKKyAgICAgICAgc3Bpbl91bmxvY2soJmhkLT5hcmNo
Lm1hcHBpbmdfbG9jayk7CiAgICAgfQotICAgIHVubWFwX3Z0ZF9kb21haW5f
cGFnZShwYXJlbnQpOwogCi0gICAgcmMgPSAwOworICAgIHBhZ2VfbGlzdF9t
b3ZlKCZwZGV2LT5hcmNoLnBndGFibGVzX2xpc3QsICZoZC0+YXJjaC5wZ3Rh
Ymxlcy5saXN0KTsKIAotIG91dDoKLSAgICBzcGluX3VubG9jaygmaGQtPmFy
Y2gubWFwcGluZ19sb2NrKTsKKyAgICBpZiAoIHJjIHx8ICghc2NyYXRjaF9w
YWdlICYmICFybXJyX2ZvdW5kKSApCisgICAgICAgIHF1YXJhbnRpbmVfdGVh
cmRvd24ocGRldiwgZHJoZCk7CiAKLSAgICAvKiBQYWdlcyBtYXkgYmUgbGVh
a2VkIGluIGZhaWx1cmUgY2FzZSAqLwogICAgIHJldHVybiByYzsKIH0KIAot
LS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuaAorKysg
Yi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuaApAQCAtNDc3
LDcgKzQ3Nyw3IEBAIHN0cnVjdCB2dGRfaW9tbXUgewogICAgIHUzMiBucl9w
dF9sZXZlbHM7CiAgICAgdTY0CWNhcDsKICAgICB1NjQJZWNhcDsKLSAgICBz
cGlubG9ja190IGxvY2s7IC8qIHByb3RlY3QgY29udGV4dCwgZG9tYWluIGlk
cyAqLworICAgIHNwaW5sb2NrX3QgbG9jazsgLyogcHJvdGVjdCBjb250ZXh0
ICovCiAgICAgc3BpbmxvY2tfdCByZWdpc3Rlcl9sb2NrOyAvKiBwcm90ZWN0
IGlvbW11IHJlZ2lzdGVyIGhhbmRsaW5nICovCiAgICAgdTY0IHJvb3RfbWFk
ZHI7IC8qIHJvb3QgZW50cnkgbWFjaGluZSBhZGRyZXNzICovCiAgICAgbm9k
ZWlkX3Qgbm9kZTsKLS0tIGEveGVuL2luY2x1ZGUveGVuL2lvbW11LmgKKysr
IGIveGVuL2luY2x1ZGUveGVuL2lvbW11LmgKQEAgLTIzMyw3ICsyMzMsNyBA
QCB0eXBlZGVmIGludCBpb21tdV9ncmRtX3QoeGVuX3Bmbl90IHN0YXJ0CiBz
dHJ1Y3QgaW9tbXVfb3BzIHsKICAgICBpbnQgKCppbml0KShzdHJ1Y3QgZG9t
YWluICpkKTsKICAgICB2b2lkICgqaHdkb21faW5pdCkoc3RydWN0IGRvbWFp
biAqZCk7Ci0gICAgaW50ICgqcXVhcmFudGluZV9pbml0KShzdHJ1Y3QgZG9t
YWluICpkKTsKKyAgICBpbnQgKCpxdWFyYW50aW5lX2luaXQpKGRldmljZV90
ICpkZXYsIGJvb2wgc2NyYXRjaF9wYWdlKTsKICAgICBpbnQgKCphZGRfZGV2
aWNlKSh1OCBkZXZmbiwgZGV2aWNlX3QgKmRldik7CiAgICAgaW50ICgqZW5h
YmxlX2RldmljZSkoZGV2aWNlX3QgKmRldik7CiAgICAgaW50ICgqcmVtb3Zl
X2RldmljZSkodTggZGV2Zm4sIGRldmljZV90ICpkZXYpOwpAQCAtMzQ5LDYg
KzM0OSw3IEBAIGludCBfX211c3RfY2hlY2sgaW9tbXVfc3VzcGVuZCh2b2lk
KTsKIHZvaWQgaW9tbXVfcmVzdW1lKHZvaWQpOwogdm9pZCBpb21tdV9jcmFz
aF9zaHV0ZG93bih2b2lkKTsKIGludCBpb21tdV9nZXRfcmVzZXJ2ZWRfZGV2
aWNlX21lbW9yeShpb21tdV9ncmRtX3QgKiwgdm9pZCAqKTsKK2ludCBpb21t
dV9xdWFyYW50aW5lX2Rldl9pbml0KGRldmljZV90ICpkZXYpOwogCiAjaWZk
ZWYgQ09ORklHX0hBU19QQ0kKIGludCBpb21tdV9kb19wY2lfZG9tY3RsKHN0
cnVjdCB4ZW5fZG9tY3RsICosIHN0cnVjdCBkb21haW4gKmQsCg==

--=separator--


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 12:25:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 12:25:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.298954.509213 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbiFR-0007ee-0G; Tue, 05 Apr 2022 12:25:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 298954.509213; Tue, 05 Apr 2022 12:25:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbiFQ-0007eX-TV; Tue, 05 Apr 2022 12:25:24 +0000
Received: by outflank-mailman (input) for mailman id 298954;
 Tue, 05 Apr 2022 12:25:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FxJD=UP=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nbiFP-0007eR-3E
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 12:25:23 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 757d0d43-b4db-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 14:25:21 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1649161515434997.570147188992;
 Tue, 5 Apr 2022 05:25:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 757d0d43-b4db-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1649161517; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=X7kZ0oR51UZopkxbvr3/rdqmyTBa5QiM/mN6bE9vW4TCB4qvJDMmg4Qnsw1DwxBH4RgHL1QFDuq94bd7uJGEmk9Tm/HTL7xNuDuoota8y5N/v9pQBtOws/bvc0yvDBG0DOwArNTVelOUXP3KEMufi2EqG23so8w1D9A+f4kmRjw=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1649161517; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=fR/2PJkBquhZn9cqmyUgmmbvio8ZT+SIOP6kXLDgiwI=; 
	b=H/z2c9V5sMCQNYHlfLw0a/MGNSe0+O/oActtBKt9ELP/Vjt06j8CnrDNfiOoAYqcZMVSXFu6PjpECqsmOxu6eRsCfbJH12G6zFb9C4jaD6BR/vM0JWWH4+SLR0t1XibzFrrmwKBcyFNH0B7zPRZBQzDu4CwhIKBlNKncnJ2nf3s=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649161517;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=fR/2PJkBquhZn9cqmyUgmmbvio8ZT+SIOP6kXLDgiwI=;
	b=e3lv574t4H2otQVEcnWQnLN30+e+kFA32FFRPrxAmvlxqMJ0Xa4KwGX4trPXL6RU
	+gdUGhvOVSpL7VOcFVD82XPc+REh0FtldC5jbo8lS2WJUGTMbzIsbeyKJ1LHj5H9X5U
	2UjM+26bfC4gjg22RI5Wd4xGSB+4rpFgqR/n0bBY=
Message-ID: <74f71b63-d8da-d920-a679-e53340152b80@apertussolutions.com>
Date: Tue, 5 Apr 2022 08:24:50 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 2/2] arch: ensure idle domain is not left privileged
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-3-dpsmith@apertussolutions.com>
 <f1c3923a-9201-c200-1b1e-9a258d47e64a@suse.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
In-Reply-To: <f1c3923a-9201-c200-1b1e-9a258d47e64a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/5/22 04:26, Jan Beulich wrote:
> On 31.03.2022 01:05, Daniel P. Smith wrote:
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -589,6 +589,9 @@ static void noinline init_done(void)
>>      void *va;
>>      unsigned long start, end;
>>  
>> +    /* Ensure idle domain was not left privileged */
>> +    ASSERT(current->domain->is_privileged == false) ;
> 
> I think this should be stronger than ASSERT(); I'd recommend calling
> panic(). Also please don't compare against "true" or "false" - use
> ordinary boolean operations instead (here it would be
> "!current->domain->is_privileged").

Ack.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 13:14:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 13:14:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299044.509405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbj0d-0007S3-OO; Tue, 05 Apr 2022 13:14:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299044.509405; Tue, 05 Apr 2022 13:14:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbj0d-0007Rw-LO; Tue, 05 Apr 2022 13:14:11 +0000
Received: by outflank-mailman (input) for mailman id 299044;
 Tue, 05 Apr 2022 13:14:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FxJD=UP=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nbj0c-0007Rq-GJ
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 13:14:10 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 45d020dd-b4e2-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 15:14:08 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1649164442540753.2553172609371;
 Tue, 5 Apr 2022 06:14:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45d020dd-b4e2-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1649164443; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=mg5267UnM7WXh/N70WrNDHnpd4W+YjTEY1qM92V7y2Nkpzx9ewR+UU2vdVqVibCrPte3K1Ara6OFOiCI1dLLn9/rjCeI1+hkfHICv3TzxWsuVcsnFgHI2wgcyl8BGD+XE0shzANGTZ0easqOU4JyU1tUB0hiyCD4ZptxoFYB/Pg=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1649164443; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=rrO5+QU9QPNy/h5i5VmmGW/q+AsY/3yLxFeX1M9sdHY=; 
	b=lZ60eJL91SkAescWg8PYFneb+YpL9CUGtf6HNnSzl07AfSUFf8bAKcP5CSq1/d2kYhT1dROiJFcF64ZxCp7nYE4Tc/iXTby4lFahrlokEjEqrze/YnXFaiNn81ln3J6Er0hMcsJ6V4jQ8SA357pdiTtM4qpg0Ho5ha7hnAj7TQg=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649164443;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=rrO5+QU9QPNy/h5i5VmmGW/q+AsY/3yLxFeX1M9sdHY=;
	b=LIwX/lwmM5SoL4ZMC9Uaagb91nPKJZcJ3kSafWSC0kqBdGbriiA40yeSE7h73pk5
	U/Ayu1moQTIiRz3LS6Vh781XtMp0hURet6CYyBf5/sgKK6YDmbgkNeAxLjvijMMnyZ9
	BIOxmJCt8nwNm8BB3blZZNWvaJr7inl8gtIVb1Wk=
Message-ID: <903c1c73-c310-d7c0-a95e-0f84c77b02f1@apertussolutions.com>
Date: Tue, 5 Apr 2022 09:13:37 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Jason Andryuk <jandryuk@gmail.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220330181734.30319-1-jandryuk@gmail.com>
 <f5225d49-fcc5-c02c-2e48-cd96cc2bd940@suse.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH] x86/irq: Skip unmap_domain_pirq XSM during destruction
In-Reply-To: <f5225d49-fcc5-c02c-2e48-cd96cc2bd940@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/5/22 04:18, Jan Beulich wrote:
> On 30.03.2022 20:17, Jason Andryuk wrote:
>> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
>> complete_domain_destroy as an RCU callback.  The source context was an
>> unexpected, random domain.  Since this is a xen-internal operation,
>> we don't want the XSM hook denying the operation.
>>
>> Check d->is_dying and skip the check when the domain is dead.  The RCU
>> callback runs when a domain is in that state.
> 
> One question which has always been puzzling me (perhaps to Daniel): While
> I can see why mapping of an IRQ needs to be subject to an XSM check, it's
> not really clear to me why unmapping would need to be, at least as long
> as it's the domain itself which requests the unmap (and which I would
> view to extend to the domain being cleaned up). But maybe that's why it's
> XSM_HOOK ...

There are situations for instance where there is a flask-based system
with one or more domains (v-platform-mgr) that are each responsible for
the management of a subset of domains and are responsible for
hotplugging in and out a device, i.e. granting the privilege to a
v-platform-mgr to call PHYSDEVOP_map_pirq/PHYSDEVOP_unmap_pirq, for the
domains each one is managing.

>> ---
>> Dan wants to change current to point at DOMID_IDLE when the RCU callback
>> runs.  I think Juergen's commit 53594c7bd197 "rcu: don't use
>> stop_machine_run() for rcu_barrier()" may have changed this since it
>> mentions stop_machine_run scheduled the idle vcpus to run the callbacks
>> for the old code.
>>
>> Would that be as easy as changing rcu_do_batch() to do:
>>
>> +        /* Run as "Xen" not a random domain's vcpu. */
>> +        vcpu = get_current();
>> +        set_current(idle_vcpu[smp_processor_id()]);
>>          list->func(list);
>> +        set_current(vcpu);
>>
>> or is using set_current() only acceptable as part of context_switch?
> 
> Indeed I would question any uses outside of context_switch() (and
> system bringup).

I am not familiar with the details of the scheduler, but from a higher
level, conceptual perspective, I do not understand why an idle domain
task is being executed without an explicit context switch to the idle
domain to ensure the current world view is consistent with the task
execution scope. Just seems to me like this is creating a situation
where things have the potential to go sideways/wrong.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 13:16:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 13:16:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299048.509417 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbj2c-00082i-4I; Tue, 05 Apr 2022 13:16:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299048.509417; Tue, 05 Apr 2022 13:16:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbj2c-00082b-1I; Tue, 05 Apr 2022 13:16:14 +0000
Received: by outflank-mailman (input) for mailman id 299048;
 Tue, 05 Apr 2022 13:16:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bLbn=UP=citrix.com=prvs=0878235d2=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nbj2a-00082T-Ft
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 13:16:12 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8bae7ad8-b4e2-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 15:16:06 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bae7ad8-b4e2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649164566;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=vx3U8Q3CZ1RcdfmGM4PEMUIzgrN1MwKaOT7np1Fz3O8=;
  b=DKOYI0bwWfjp7AdCOPKsZfUOmOD/dUT/uTUl9dob7/UKr9FZmghPjW3b
   vQIZMgDG/eTV1TQGfApAwPrc7NFZt6ceo3b8ENHEXgyx2zwboTLdP4DDp
   WwmZIHR1C3xt8FpUNeMiofbRaWTsT01SNXWK9pPxPloXhOraIFQ/m9plO
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67940878
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:S/DKnKOTsFOF/3vvrR1pl8FynXyQoLVcMsEvi/4bfWQNrUoj3zRWn
 2RNDGmFbviCajb2L4h+bYWxo09QupLSm9BnSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 uoT5aepE14QYbz8qfs8bwlqUB5yIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQqeCP
 5pGOVKDajzOPxtDBXIOKK4GxsqmiWblbGZjj3us8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u12bkBhAXMvSPxDzD9Wij7sfKlDn+UZgfF5W58OBrm1yZwmEPCBwQWkC/qPP/gUm7M/pdI
 UEJ/islrYAp6VemCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OctXiAj3
 FKNm9LvBBRsvaeTRHbb8a2bxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP5RL/DltcSvQAiv0
 gC7swkCl4dQssIUgvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+
 SFdxpPAtLxm4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj
 K375Fg5CHx7ZiLCgUpLj2SZUZlCIU/IT4mNaxwsRoASCqWdjSfelM2UWWae3nr2jG8nmrwlN
 JGQfK6EVChGWPw9lGbrG7xBjdfHIxzSI0uJGPgXKDz9j9KjiIO9E+9ZYDNikMhnhE97nOkl2
 4kGbJbbo/mueOb/fjPW4eYuwaMidhAG6WTNg5UPLIare1M+cEl4UqO56e5xKuRNwvUO/s+Vr
 y7VZ6Ot4Aem7ZExAV7RMS4LhXKGdcsXkE/XygR3ZAzyhid6Pdj0hErdHrNuFYQaGCVY5aYcZ
 5E4lw+oX5yjlhyvF+whUKTA
IronPort-HdrOrdr: A9a23:Viu2x6Eu2k+/YZwOpLqE7seALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZMgpHjJYVcqKRQdcL+7VZVoLUmxyXcx2/h2AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp
 uIG5IOceEYZmIasS+V2maFL+o=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="67940878"
Date: Tue, 5 Apr 2022 14:16:00 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "George
 Dunlap" <george.dunlap@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?=
	<marmarek@invisiblethingslab.com>
Subject: Re: preparations for 4.14.5 ?
Message-ID: <YkxBEMlXaVrqRdrg@perard.uk.xensource.com>
References: <466e1d4b-a4b6-0797-ca1b-1ea59a3993ba@suse.com>
 <YkcCMg8+dDjxBvJW@mail-itl>
 <d2bf04d9-53e1-6658-a1d7-ca61bae01141@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d2bf04d9-53e1-6658-a1d7-ca61bae01141@suse.com>

On Mon, Apr 04, 2022 at 03:42:09PM +0200, Jan Beulich wrote:
> On 01.04.2022 15:46, Marek Marczykowski-G�recki wrote:
> > On Wed, Mar 30, 2022 at 12:16:00PM +0200, Jan Beulich wrote:
> > I'm not sure if "just" bugfix qualify for 4.14 at this point, but if so,
> > I'd propose:
> > 0a20a53df158 tools/libs/light: set video_mem for PVH guests
> > 
> > In any case, the above should be backported to 4.15 and 4.16.
> 
> Hmm, Anthony, I'd like to ask for your view here: This looks more
> like a cosmetic change to me at the first glance. Plus it's a
> little odd to see it being proposed for backporting now, when it's
> already almost 4 months old and hence could have gone into 4.15.2
> and 4.14.4 if it was important.

The patch might be good to backport. I guess that could mess up memory
hotplug a little with PVH guests without the patch.

I've got a few others commits which would be good to backport I think:

e45ad0b1b0 ("xl: Fix global pci options")
d2ecf97f91 ("libxl: Don't segfault on soft-reset failure")
d62a34423a ("libxl: Re-scope qmp_proxy_spawn.ao usage")

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 13:25:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 13:25:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299066.509480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbjBE-0001iX-JF; Tue, 05 Apr 2022 13:25:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299066.509480; Tue, 05 Apr 2022 13:25:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbjBE-0001iQ-FB; Tue, 05 Apr 2022 13:25:08 +0000
Received: by outflank-mailman (input) for mailman id 299066;
 Tue, 05 Apr 2022 13:25:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbjBD-0001iG-AL; Tue, 05 Apr 2022 13:25:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbjBD-0001RG-9U; Tue, 05 Apr 2022 13:25:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbjBC-0001p7-UM; Tue, 05 Apr 2022 13:25:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbjBC-0007eD-Tv; Tue, 05 Apr 2022 13:25:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NrPr3oLBN9X2C09bOMChKxqgzwTmIKLtv7zMjqIcrKA=; b=d1VMbE5kGV/FECVrwKYoa84O1n
	OVIk5qQWfkAd0gN9SUrIfly/j/FTvXhlk0+6LYr2KARlZaf5m+HLUvpc/WsDSgDYgH5ABhYx6R1iV
	JiJ5H8L1o41tMbPqhTTwdqllBNcWqA/4tbNB42zaT0tSJblynVB2IZ1+2P0Sklmnzmyc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169175-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169175: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=120e26c2bb0097a589d718b1b58d7052ccce4458
X-Osstest-Versions-That:
    xen=e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 13:25:06 +0000

flight 169175 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169175/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  120e26c2bb0097a589d718b1b58d7052ccce4458
baseline version:
 xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98

Last test of basis   169160  2022-04-04 12:03:06 Z    1 days
Testing same since   169175  2022-04-05 10:01:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e270af9428..120e26c2bb  120e26c2bb0097a589d718b1b58d7052ccce4458 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 14:19:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 14:19:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299105.509602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbk1B-0000EX-0O; Tue, 05 Apr 2022 14:18:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299105.509602; Tue, 05 Apr 2022 14:18:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbk1A-0000EQ-Tc; Tue, 05 Apr 2022 14:18:48 +0000
Received: by outflank-mailman (input) for mailman id 299105;
 Tue, 05 Apr 2022 14:18:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbk19-0000EI-U1
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 14:18:48 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4c01b9f8-b4eb-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 16:18:45 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c01b9f8-b4eb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649168325;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=h/HMRmGehioRNhex2ZIC/MLGlu5JrWGWbp6UKmtYWDg=;
  b=VBPQiqgii0bgOUWkcFKHEeI33RlMJ5p3JS/AP7NxC38zgv9hJlvm2P0u
   KS2sY+CSiSuJ+8AVnd9uZMF0rhwQMZb4TGDZZgaAjvy07og8TxDssWmvA
   xg1b/xrVHVCQ1OlBL9JN03L50ainIzMGzYEFSJrKVcq3Y46uWVgS3KEF8
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68051216
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:r/c7/KyWYHv0AbeCC0N6t+c1xirEfRIJ4+MujC+fZmUNrF6WrkUOx
 2sXXmzSPP2DNzeneoxwa43k/RsAuMTUnNdlG1E5qiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YXhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplq5CIclcFL/Xwwt9Mc15yIi85OIsdweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JAWQK+EP
 pRxhTxHTCzARENIJwYsEr0Ptt2RhynFdGVgtwfAzUYwyzeKl1EguFT3C/LUZd6iVchThlyfp
 G/N4yL+GB5yHMySz3+J/2yhgsfLnDjnQ8QCGbug7PlojVaPgGsJB3UruUCT+KfjzBTkApQGd
 hJSqnFGQbUOGFKDUNXFZE2UsSa45CVNe516IuN97SfW8/+Bi+qGPVQsQjlEYd0gkcY5Qz02y
 1OE9+/U6SxTXK69EizEqOrNxd+mEW1MdDJZO3dYJecQy4O7yLzfmC4jWTqK/ESdqtTuUQ/9z
 DmRxMTVr+VC1JVbv0lXEL2uvt5NmnQrZlNujuk0djj8hu+cWGJDT9b1gbQ8xawdRLt1tnHb4
 BA5dzG2tYji962lmi2XW/kqF7q0/fuDOzC0qQcxQ8h5rWzxpiL4Idw4DNRCyKFBaJtsldjBO
 hG7hO+szMULYCvCgVFfPepd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs+1yPq
 YsAbpfUkH2ykoTWO0HqzGLaFnhTRVATDpHqsc1HMOmFJwttAmY6DPHNh7gmfuRYc259z48kI
 lnVtpdk9WfC
IronPort-HdrOrdr: A9a23:QD+iHKEuTIS3fojkpLqFAJHXdLJyesId70hD6qkvc3Jom52j+P
 xGws526faVslYssHFJo6HmBEDmewKgyXcV2/hqAV7GZmjbUQSTXfhfBOfZsljd8k7Fh5BgPM
 VbAtBD4bTLZDAQ56uKg3jbLz9J+qj5zEnCv5a5854Cd3APV0k2hD0JdjpzX3cGDTVuNN4cLt
 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xg+A2frfKVy1zx0eWzRAzfML9n
 XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlYgnEu0KNXsBMSreCtDc6rKWG70srqs
 DFp1MaM8F6+xrqDxWIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8O1U4e
 Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh4LD3xHklXqvoIRiKqbzOSI
 JVfYHhDbdtABmnhknizyZSKIfGZAVxIv+EKnJyz/B9nQIm3kyR9HFotPD3rk1wha7VdKM0lN
 gsSp4Y742mbvVmGp6VV91xN/deNAT2MGDx2SSpUBHaKJ0=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68051216"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W22MflDArLbeX+Jyyfn2pVTQgFq5XibnbQtrtx8P9rUvexa3koyruXlpeDb3H/nmMl2nSvKT33flO/3DPS3GiMcqbz8+0QcZbIWaQJnBvavHx1SuzQUJ9QmRjDdO0/kouYZq87DfAto7lz5N8oZhjaXvlbxlq35XhXgD8YToNRVI62kfxvhi88O1Fw+6J8Dw0TDvRX5NGKsllFWMUiFJ6jJbbVZlg9jaXidXJHB9wqH+7SKZSpYkGLocq/DuY+claw4KzBQee+nIoOOI2hP1imibdGPhF+yfaT+1qdZXAAj5V2MflcMmq3Ov+iS391RH7+BGtmoaMtWr5eCy+JKaSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mVMkoMk91yFrrJtOSVoTMkVMqr0s1tTnW4QpC202swo=;
 b=kzBUlmSWil6PWP/me/N76+4vUWowFQIk5aZcc5Xi6AiX64NwAHTRGwLZpL9xQfZ30V+YgQATAOH/GKfnnwokc3dUB40uzDgFYOffHKV8+NA1VOIoM0EyyPYStDltAizEcwtTplAlnh/fUhI5aJE/AginiJWwMThIhzonysjHBLKoiIKsromOMj7LmcvF47drUMw4SQBhA5jU91zo4QmE14+pib5tSGAXuvma/n2St/db88XqnYMGmPbDOlxyc6vbZeW94yFPRBums1Z4ZImRn3T/TtOj2YGQKJS/0p+O4ROq40Dx6mX03Cl3Ds4NGbb2EMXiDPQBURBVb4RhYPKT/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mVMkoMk91yFrrJtOSVoTMkVMqr0s1tTnW4QpC202swo=;
 b=ZO2qLSX1xYBOCaT9uEzbJSfyKlcOWaFuS+H2sRyJrmPC1Co8iWYsO5h8VKRphPNZWY8qOBRntO/JycejQQR8XyETz8+pbgc9qKQTD2fIeAz+ikorC7op1ix9Ia5R3hXtPQytR4eaWF60iKlPQM2yop1GZ/ek9BbLrw2qPkzuJPY=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH] osstest: stop anacron service
Date: Tue,  5 Apr 2022 16:18:27 +0200
Message-ID: <20220405141827.27151-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0049.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ac::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ebd556f0-e4a1-4228-fa39-08da170f2dfb
X-MS-TrafficTypeDiagnostic: SA1PR03MB6625:EE_
X-Microsoft-Antispam-PRVS: <SA1PR03MB6625AEA0D4E9C8F2DFDB568A8FE49@SA1PR03MB6625.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ab0vxU9uDZWt7uWNpQP+0i61ArYb+Gt3zwu+5p+rNuJP7epi1qadquNVcACDs2FPW9wx4PaIXygTPpizd2z1klkkGfZKIccty1cEtsJRKIzqu+kU5RU3YoPmLbDtBQP5rhdN7ttQFVS1fA6ivXyruxT3RirDxk0TVKXgAnwiYP7F2v9kSgVfSuw/cs6Aw/kqj/Qmo7VXL0UKcVQkZcCzkC0my5fk+E4rwxsf15z6qeQUqR8kRY6gBvUi0nq6mpBjPaDrByru0TyMn2p9nP6UiJ47JA6oy+MEPqsp9T0P8b8HvmlWGJQHX6929IcNFT9XqZwgeb6OWKqltzwxAncsrFkkd9aRiKBmexaDHavAE+t9U8cRKiRF8JtUh5q9reTBCXN0xb4V2a+NFmZH/tvXmEHqR/zhjRsveKphNoSoa+RRsAenxeWbvqPN1Q05eMBrbkRHlx16soSQ/yjLV2004tVH9JD/5V+bn12nxhm5zrTIg9fUpoxEwja8Bkkzw8fR32sVFL65NsFipgFX43cnBvi9KwBHJzKFjrUrr7YxdF+3kVomjzZZLmM1edMuigRpoudIhW/xcawITn+lPVV5Vul7lfFyGwd7Z1tz4sW/Ao5fHx4tQshLNjNCV/0X9X/vgF8IpYlnaa5oNlmCUS12EnD1hh2Q0adBglFMditTcWozqz8MvbhQa7V8tHNekmUjQtXIOPHiQOuUzA3W+kYDcqXCzRAG24ypXFH19X51u2I=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(82960400001)(26005)(316002)(86362001)(6506007)(38100700002)(5660300002)(2906002)(83380400001)(8936002)(107886003)(1076003)(2616005)(186003)(8676002)(66556008)(66946007)(6512007)(66476007)(966005)(4326008)(6486002)(36756003)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUdZcEF0SzkvWmo4OWwrTXdUM0FtUkRlUmNlMnBKVkF6MHBrZGRWclZkci9I?=
 =?utf-8?B?K3IvemxNZkVWZTNsdGYzWFRzUW81N0w0TVg3cEphMmMrSm92WkVuM0FlK0pw?=
 =?utf-8?B?OTJxK3I2R2djYnkxVlJ1MGQ5dU5YTUJyZ3BnRWl1ZENIZkwrNzdvTVJQNFov?=
 =?utf-8?B?Lzl3MVNyYm9QTTYxdThHTXVpdFFlSmdUUTRTdllQS3JCanl3N0JYVEVaTVBZ?=
 =?utf-8?B?dkVIU21ZbHdpcUJtLytTTzZMMVVkT0xFL2ZCUWxiaFdLbVlCL2NuSVZwOW1y?=
 =?utf-8?B?YlVRTXhqK3J3TExJMVJOUmpxdXd2SWZ2Z1p3NVNNLzRhaTNvZ1VBSCs0d1B2?=
 =?utf-8?B?OVlpT2tyTURkbkxndGZKbW13RXFIMVRabnNWZy9RUERoT0xzNVRsQzlKcjkr?=
 =?utf-8?B?NFhxakNRd2k3MmJmbk9NSDR5MlNDN1Zkdk54WmxtamZSQ2F2OFpSV2FwTlVw?=
 =?utf-8?B?Z285ZEkvWDRnSVB1R2x5aTNiOHV0ZGdJT0M3RFppdTdoOWgwQ3dTMnA5blFv?=
 =?utf-8?B?VVN4ODVLVU9lNUs5OFEvY0NvWFFVemNhcEhvMTc0RDVHa3lSVWhwMFVwdWN3?=
 =?utf-8?B?WGhzak51bEY2NjM4Z2duS0RVZm4yeGpXbkRIOXc5UTA2aC9RRDZpUVhuTzZO?=
 =?utf-8?B?UFVCUTBTM3FFaGQzL3JPaTMzN3o1N0J3NjJsUmRxMFpWd3RWOVNNbHBCMGt1?=
 =?utf-8?B?cDBNNnVPdnNYcjM3cDlOOXJhWjVrTnpxS1RXb0pac0dMN0NqaTRnWU9pZTNC?=
 =?utf-8?B?bkg0aTlKMjBTWmpFTjRXcXJBZFJYUTNlT3VQN1pFamp5YVdKV0hZRGtYYkZ2?=
 =?utf-8?B?MEhZY3lmUmh1aHp5OXIzNHlUSmdFanM1cHcvbHUwbjl2R3dBZ3V6TVB2L1l4?=
 =?utf-8?B?eHVCelRVZjZIQUtNOVF1S0gyYm5qRlRseGtPS0w3SHYzWkpaNk95cFJaOFVs?=
 =?utf-8?B?NkN2R2tWS0VoaS92UGdXV0xCN2R4TUN0cFFxTVBMbklDNUlNVzg3eXlWSk5I?=
 =?utf-8?B?WDV5S0xFSnpGSWRjYkdSUVVJQzZlYktLQXdaeThhUWc4Sk9CTlAwdUNyemtE?=
 =?utf-8?B?dkxTWFdtbEdVcjlyK0JBa0tNNEhMRmlFQWp2VUppS2NoK2FwbFY2MFJITkVx?=
 =?utf-8?B?SGZ3c2dMTzBQeExQTm1MWWxuVHZiQXVWdmN0VkhTaWhwMGh1QVJ0SzlOVEFF?=
 =?utf-8?B?Z3FjUjN6UTVjOU5hMGdhWlZ5QWRpOE9seTRvTkdQV25EMVJ2UVkvWEhqakxU?=
 =?utf-8?B?d29WTHRuL3JGNFMvSHZGSk1PYjNmYk1OSVlPQXBZc2xqQWJZSTlFTytZeDJX?=
 =?utf-8?B?cE1rQnJQWU9tbHF3SXduV08xUFdqZGVVazdlY2ZId3g2aUVTUVZuUUM4QnhU?=
 =?utf-8?B?SWFkcUY1L2M3Q3lOcTVjbk1NY1dka2RpZnRMc0E1OW12Y29tTjV4UklHQkQ2?=
 =?utf-8?B?TVJ4Mkkrc1NueFUrZUtJeE1DTDd0Vmpnc21LVTZnZmhiUS9nbXpJODZpZXFp?=
 =?utf-8?B?N1BtMGllWXgzcjVSUmNlK0JVTGpwZXRLWllxSmx2aTFkZXo2cGxHM2xSVzFE?=
 =?utf-8?B?NTd6VnkvcUJBblFpeENpditYVkFKNjdVSFZEQkdRN0hCdEU5elFLNmN1M2Vu?=
 =?utf-8?B?andkdFcrbXRoT21TSy83b21yYlpxYXR1UnVNNFhVR3B3YmlpbGlVSHdRRm4z?=
 =?utf-8?B?ZkYvMDAzMGhnb2tuVDc3dWF0cHBsS3hiRkJLMndPbWVFOUlMaFlzUFJxVlM3?=
 =?utf-8?B?NXFDUFNDMm5EVkg5cUlKSWlPYjE4NHU2RjUxMDJVbmgwYnJpOFBMNVo1bWJW?=
 =?utf-8?B?N2VkOWRBaEhzOVNUREhpY253ZE4yL09jZndzMlhaTG1YRUVFM0dMa0RYWU1p?=
 =?utf-8?B?ZDZoZExNR1hsNFJoeGZ4SFhWek5IOWtGeXVPRWVoRHBkeXQ2c3Uyb3V6a3Vm?=
 =?utf-8?B?NlFqRlVieit6M0VKUVgxYWU0dHd6enNEUUl0Z1NLMEh2cXAxbHE2L1ZRZk1u?=
 =?utf-8?B?ekgzS2NNdERUdEVhaVdLUmFBY2dBMC9sQnBjYXJVMlMzdUxzZElUZUlEL0pD?=
 =?utf-8?B?MElIOS9rMkR0MmZ3NjRsKzFwSEtsMXFsVS90WkdxR0xTMTAvK0Q0VmZmRWV6?=
 =?utf-8?B?ZnFPa1AzR2hjK2lVcVVMNDRYbVNPOFkrQUxOMlNoSEFQc2J6RitFMnE3UjZ5?=
 =?utf-8?B?NmZ0Y3IzNElVV0txQVlFS2Nub0JMSEhQbU03TkNmTTRQVjB1anloL21sU28x?=
 =?utf-8?B?Vm1WQnR1K3U1Y3NHSEFLVld0R1NvQnl3cCtrQkNhZVkxUTU2S2JSNDNJUmVa?=
 =?utf-8?B?bUxibnNLVmt6YnlwenFCL0hOUkNLaG5xSEU2SERlUENsaGZ2NzNKd3JzYWZu?=
 =?utf-8?Q?7KNAH2MXTbZiQYPw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ebd556f0-e4a1-4228-fa39-08da170f2dfb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 14:18:39.1813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Xk76jDlDZLxQhfcuGmRDGiKkscaITahieo5v/YsHxjgjvODD7uW1hKpjFz/NNftiy7EeZfydkW1ywdRucnePg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6625
X-OriginatorOrg: citrix.com

Just disabling cron in rc.d is not enough. There's also anacron which
will get invoked during startup, and since apt-compat has a delay of
up to 30min it can be picked up by the leak detector if the test
finishes fast enough:

LEAKED [process 14563 sleep] process: root     14563 14556  0 07:49 ?        00:00:00 sleep 1163
LEAKED [process 14550 /bin/sh] process: root     14550  2264  0 07:49 ?        00:00:00 /bin/sh -c run-parts --report /etc/cron.daily
LEAKED [process 14551 run-parts] process: root     14551 14550  0 07:49 ?        00:00:00 run-parts --report /etc/cron.daily
LEAKED [process 14556 /bin/sh] process: root     14556 14551  0 07:49 ?        00:00:00 /bin/sh /etc/cron.daily/apt-compat

From:

http://logs.test-lab.xenproject.org/osstest/logs/169015

To prevent this disable anacron like it's done for cron.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 Osstest/TestSupport.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 8103ea1d..8e3e5f68 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -3151,6 +3151,8 @@ sub host_install_postboot_complete ($) {
     target_core_dump_setup($ho);
     target_cmd_root($ho, "update-rc.d cron disable");
     target_cmd_root($ho, "service cron stop");
+    target_cmd_root($ho, "update-rc.d anacron disable");
+    target_cmd_root($ho, "service anacron stop");
     target_cmd_root($ho, "update-rc.d osstest-confirm-booted start 99 2 .");
     target_https_mitm_proxy_setup($ho);
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 14:24:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 14:24:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299111.509614 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbk6J-0001hz-NN; Tue, 05 Apr 2022 14:24:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299111.509614; Tue, 05 Apr 2022 14:24:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbk6J-0001hs-Jf; Tue, 05 Apr 2022 14:24:07 +0000
Received: by outflank-mailman (input) for mailman id 299111;
 Tue, 05 Apr 2022 14:24:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bLbn=UP=citrix.com=prvs=0878235d2=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nbk6H-0001hm-VC
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 14:24:05 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0ab8a811-b4ec-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 16:24:04 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ab8a811-b4ec-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649168644;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=jujJyxLjaVGhBGCD3FuCmkLh3dgzDZvsxlACmDmXXAA=;
  b=QGHZF9//VYcMztc5jmp+vG7cSxy9U1cpUIeKxlD2YbMJNQxX7QFjqLXd
   TOKygnYKmmYNU2C/ltcIoFbQUE+nU1mZbpyrVfg2LsYuLVUjGIoWyyzWx
   vEvgfQB+H/RQBTREyIOda/jchUGu+Fy0VHtjOVNczeCIy3829q8KF6OAi
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67949315
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qp4xU6k6fJfsZAtUvuwNRjvo5gw7JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaCziEMq3fNGX0fNl/bY62/U4PvpHQn9IySlBkrXs3HiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW17V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYcVg2fY3livsheRhRKhNhE5Zf4pHeGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNmszPU+ZPnWjPH8xFrscx+fxokXecmZJ82uxgZMO8kLMmVkZPL/Fb4OOJ43iqd9utkuUu
 2vc82PRAhgQN9uE1XyD/27ErvXOliPyQo5UFLC++vNwm1qV7mgSDhQMUh28u/bRolWlR9tVJ
 kgQ+ywvhas/7kqmSp/6RRLQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceXTU30
 neZktWvAiZg2JWNQ3Wb5LaSrBuoNCQVJHNEbigBJSMc7tz+5Y0+kB/LZtBkFqGzk5vyAz6Y6
 yuKoS4iiqQ7gssC1qH99lfC6xq1q53UCxIv5xvWV2aN6AR/a4i4IYuy5jDz6P9aJ4udCFCZs
 nUAkcGD6cgBCJiMkGqGR+BlNLSy+96fPTHciEIpFJ4knwlB4Fb6I9oWumsnYh40bIBUIlcFf
 XM/pytpu4AQHFK4cpNdYouIOdsE9rH6O83cA6W8gsV1XrB9cwqO/SdLbEGW3nzwnEVErZzTK
 at3Yu73Uy9EVP0PIC6eAr5EjOR1nnxWKXb7H8iT8vix7VaJiJd5o58hOUDGUO025bjsTO79o
 4cGbJviJ/myvYTDjsjrHWw7cAtiwZsTX8meRylrmgireFcO9IYJUaK5/F/ZU9Y595m5b8+Rl
 p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgj/CphZXBxYQ30hxDPhLpDCo9FKvPbmpF9qoReIQNcF
 aFZK61s/NwRItg4x9jtRcak99EzHPharQmPIzCkcFACk21IHGT0FivfVlK3rkEmV3Pv3eNn+
 uHI/l6LEPIrGlU5ZO6LOa3H8r9ElSVE8A6EdxCTeYc7lYSF2NUCFhEdeddseptWdEqammXBv
 +tUaD9BzdTwT0YO2IGhrci5Q02BSbYW8pZyd4UD0YuLCA==
IronPort-HdrOrdr: A9a23:RaePKq5e5/CZBpTRLQPXwMrXdLJyesId70hD6qhwISY1TiW9rb
 HIoB17726RtN9/Yh0dcLy7V5VoBEmsk6KdgrNhWItKPjOW21dARbsKheCJrgEIWReOlNK1vZ
 0QCpSWY+eRMbEVt6jH3DU=
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="67949315"
Date: Tue, 5 Apr 2022 15:23:48 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Bernhard Beschow <shentey@gmail.com>
CC: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>, "Michael S. Tsirkin"
	<mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Paolo
 Bonzini" <pbonzini@redhat.com>, Richard Henderson
	<richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>,
	Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
	"open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] hw/xen/xen_pt: Confine igd-passthrough-isa-bridge to
 XEN
Message-ID: <YkxQ9JUtfn5t8oSR@perard.uk.xensource.com>
References: <20220326165825.30794-1-shentey@gmail.com>
 <20220326165825.30794-2-shentey@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220326165825.30794-2-shentey@gmail.com>

On Sat, Mar 26, 2022 at 05:58:23PM +0100, Bernhard Beschow wrote:
> igd-passthrough-isa-bridge is only requested in xen_pt but was
> implemented in pc_piix.c. This caused xen_pt to dependend on i386/pc
> which is hereby resolved.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 14:24:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 14:24:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299113.509625 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbk6Z-000259-VD; Tue, 05 Apr 2022 14:24:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299113.509625; Tue, 05 Apr 2022 14:24:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbk6Z-000252-S4; Tue, 05 Apr 2022 14:24:23 +0000
Received: by outflank-mailman (input) for mailman id 299113;
 Tue, 05 Apr 2022 14:24:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bLbn=UP=citrix.com=prvs=0878235d2=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nbk6X-00021u-PD
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 14:24:21 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 13c41992-b4ec-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 16:24:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13c41992-b4ec-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649168660;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=ZZI+unHahHiJhTMT+graTuIHpLZ2cRUWGttaIkS9G8g=;
  b=cohQS7MHcjSVS+v2axs/ZC08+7nNQODAK5co3PF8JO2W0ZNiV/Sa5M6J
   nOkCsjWL5ZtOLbBxuJOre6G7SqKWIJhxjILLd1rL7vD9eAex6KEnDUxKn
   N2fASpuCH/o0HvcHrQmtiMNUGjkrpIgzCoXXlDKtLz6aLrjbladwiwLVl
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: None
X-MesageID: 68068257
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kGda9KreGPa4VtqjvROAuIgSFJVeBmJiZBIvgKrLsJaIsI4StFCzt
 garIBmPPayCazCjc9BwPY3j8EgAvcWHyoM2GwZpqi9jQylH9puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y6q+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBPInts8cWWUdjDjx3GrxtyYb9Oki1mJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY
 qL1bBIxPEyeM0cSZT/7DrowoMKSp1fkWQderU+7goYp4TLK9ixYhe2F3N39P4biqd9utl2Du
 mvM8mD9AxcbHN+S0zyI9jSrnOCntTvyRYY6BLC+sPlwjzW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvHmXxC+vHOVlhEZUttUVeY97Wml06fR/kOVC3YJShZHb9opstJwQiYlv
 neQktb0QCB1saOUQHa18LCSojWvfy8PIgc/iTQsFFVfpYO5+cdq00yJHo0L/LOJs+AZ0ArYm
 1iixBXSTZ1J0qbnC43TEYj7vg+R
IronPort-HdrOrdr: A9a23:PcYl2638jRxgM4wUCzfa/AqjBLIkLtp133Aq2lEZdPRUGvb3qy
 mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM
 9bAs5D4bbLbGSS4/yU3DWF
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68068257"
Date: Tue, 5 Apr 2022 15:24:09 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Bernhard Beschow <shentey@gmail.com>
CC: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Paul Durrant <paul@xen.org>, "open list:X86 Xen
 CPUs" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] hw/xen/xen_pt: Resolve
 igd_passthrough_isa_bridge_create() indirection
Message-ID: <YkxRCYmMYYmU3lsW@perard.uk.xensource.com>
References: <20220326165825.30794-1-shentey@gmail.com>
 <20220326165825.30794-3-shentey@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220326165825.30794-3-shentey@gmail.com>

On Sat, Mar 26, 2022 at 05:58:24PM +0100, Bernhard Beschow wrote:
> Now that igd_passthrough_isa_bridge_create() is implemented within the
> xen context it may use Xen* data types directly and become
> xen_igd_passthrough_isa_bridge_create(). This resolves an indirection.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 14:37:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 14:37:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299172.509672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbkIv-000659-Pj; Tue, 05 Apr 2022 14:37:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299172.509672; Tue, 05 Apr 2022 14:37:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbkIv-000652-LP; Tue, 05 Apr 2022 14:37:09 +0000
Received: by outflank-mailman (input) for mailman id 299172;
 Tue, 05 Apr 2022 14:37:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nhpA=UP=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbkIu-00064u-60
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 14:37:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id de29a5e7-b4ed-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 16:37:07 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-OLyY-__DMm-gUM6jHa0NvA-1; Tue, 05 Apr 2022 16:37:04 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5184.eurprd04.prod.outlook.com (2603:10a6:803:5d::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 14:36:55 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 14:36:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de29a5e7-b4ed-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649169426;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RejAs+ltWnotOnxYk2L0jXevPiCOOTFWoxIUJBpfot8=;
	b=YSHR34gYS3azQR6KaG/gdD0KNRcikZltSmQY+1GtO0Dw59vieaoNDSWWKjYmsPS5yF0FBk
	BFjDRfdHrYHpr7e77Gwm1sV7IXNyRplSyqynIWn/fiebLphFtLbdQ7NzpTVU8mg8LBHC8t
	4ewf+m+1+FIzV4kAntdy8lFs2wyeJZ4=
X-MC-Unique: OLyY-__DMm-gUM6jHa0NvA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W/2K8xYU3YXs80EmHR6SohJ25DOcqCcmiVYplT/KTCw9TfIVNp6k9ifIF/0uDWIEcsPKSv5K7VLAzERUlN/sZLbqgPcuurgAnczmZWa2luKC8nBkI9LE8S56RstPC74EcJgL8z6YT23z4i/xY2iuyofO9BNaSaq8gKg9I0wv9J7yiQLlh3pnzk6/C7XlF1AxulM0PT6P0NJgIdXXU7KdIqXHpqvRKMeN7j0sp9cJNYAIlePhw9C/7cEHC59r/aG8UMQVrcTYqDPU1a8nczZxacd/kuDtur0/CRVWd69v5S62tUdzeJty4UQCgr6U7d3gxhuHs5dUdDWCFBaxuNhghw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BYMc+9vF5aGxOqyjc+t2RiOpGTJIvPRufxcCj9qCDVQ=;
 b=eLCtM9pDMtMqEr9WuNRY29HxLh968BK+uEAIyQT+pJOnfyWjJ/6QJGceGXzmJdABhlO371ZIBvCMh8oTiXrQVU18p/rfgO5EZIl1Hf+KbWfSNmqOcji0YK8Z2dYK89fJFytjf6QjwgoojJhRlItJBDbp/X4UeG3F1YeNZ2cLqcZfH1qdLHjLmDw5MEDgoPfUMseJHgtseL4OpL3/osNPkE36/L01dNS8kqOTL2ZoQVubaE3bVKrfoC34cEr8OMZ/6lJ9h2JTQAoBmtGcIbfQfxyd1HsanuolkLKZ1K3QBPTY49n7Q2Xgg/24RBlDyjhOYv7kmkERo3rHokppt+SPJQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <39640fec-de8d-0c5a-c9aa-daf83fb785b0@suse.com>
Date: Tue, 5 Apr 2022 16:36:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
 <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0093.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::34) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1e01333f-2936-4c14-53d1-08da1711bb00
X-MS-TrafficTypeDiagnostic: VI1PR04MB5184:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5184C5950397C42DD9D86AD7B3E49@VI1PR04MB5184.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RzSo2VGEHpFic0GBjXuZe7BfzUW2mQM3z33pJt8p4ej+T5nz5pQv0OBuD3nxKvoKV7pp18mXz6Igr8N9MUKEows2UTy87XF2XhcYOdZoHw9hH6bshH9VZ9o9EyWo+nXiUK9nhV6f6m1tODVNgwo5CSpLjJMEiIuWVzOitq0dTkfGrBjZa5N92/PJfd3z/E7saAVM1o0GPDvKlvUqfYtds48rQggaU2Jw4nQ18ltVg4wXX2gnB6WeF6DXGzPuttift3fcOBVKGNgnqnALNyoYf/a7AQmotV8t8wJrig/c0kT40lc+expmTXH53ihJtx8I4SZNDaHfc4HgscPMtPKA0cS5O10jw5WsliexFdjH6JXfGXO2GoyUdI8UJbH4MeRQvwR4z3UrHUDoaIx3djJRukdLKDwZw5Zn2SwVn6GEOl+8QpB+E8QuNTKW3tuISzDOZuK8vdJ004WhVD2V7mckM7sc3ZSyqK7a/ZAGjbn//jaZSdYLElVFa5Bv8TAu09ERR7CzBGhCQt4dvAyAiRYn6tYZzteJy+Pie64b2D+Siak0/ZnNarpkxcdGqoe0hPRmy7TurDrwQ2gtVRRsC8WWZdwEa9vHBhLGCMnNNnn5m+HYzNMcCsL0PhbbZurypHcrlE9Jd69qiL5gpYZtZ4+ipJscpFA5v2QAOcYdEyj5D2YMuYxZjkoL8yV2j4asSuDO7UMNsA7KsswbaETz73b4ewOb5eKigKn+Wo4JKUBNdyU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(83380400001)(36756003)(26005)(2906002)(31686004)(2616005)(4326008)(8676002)(66556008)(5660300002)(316002)(6916009)(66476007)(8936002)(54906003)(6486002)(508600001)(6512007)(53546011)(66946007)(31696002)(86362001)(6506007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pkfNcw3Y0Urm/iLiMnFHAGpbmLSxtTfMoVfX82/3uYDQBecf6YID2QyyR/wy?=
 =?us-ascii?Q?jMKUx4Yd8T365tIEtl4ee49WIItVWnjEOkudUzYq6+TUgbGNEgKGT38FwQgC?=
 =?us-ascii?Q?Fa+DiOhSkzCz8MkGwJapCw+R2jk1sZMSNDSDryj1Nhs2gN9VlgGtFBpBidJe?=
 =?us-ascii?Q?Om9ZHNoFD+Wd8h2crS47SPIu5Tragl+z5fCMbc2ibE29HmDkPe6XrmbajK/H?=
 =?us-ascii?Q?QYOQUJ5PkiywT2LPfMOFT3CKUOS4p1bkISzGbfZWhbutKRyg389gMdI/Kk98?=
 =?us-ascii?Q?JChbPa1qGtR5qTKqZTR/+tHpNV/DdJs1I/33PmYwLXmrGLtGIQKdVKmdSNzU?=
 =?us-ascii?Q?IAz+HyH9jsJCxOYMlAqCmc5BqDOAaqdhm8gVXYGN7pj2y4kHGU+WLiFw8vUX?=
 =?us-ascii?Q?2lL3V+NfD0U709+GJbg7/US8+P3i+TuK0asFMYkHWFWyp9S+Uo636PsrU9K5?=
 =?us-ascii?Q?9YsYiG8VS6mzS7Is1sLhDE39WOURmUZ0FGUILv345mG/C5p9UGkFIuhv0lio?=
 =?us-ascii?Q?EhrBrlr+fCRAdPnlAk3F0EPinquJ6+vXHfDIOOv2D5BsOsYDCYbKxQ3opXtK?=
 =?us-ascii?Q?QklEIDYzItiIb/ii9qHbaTiRxWbI8+OeNCBdhXFnN/r8H1da3Ca4BQiL34hE?=
 =?us-ascii?Q?LlREtq7G3MXLEe2JgfN0RH1lQYBjE4UZjmTDa67XRA++LaCarMD3y6CouR85?=
 =?us-ascii?Q?UN7vcAqBBr02hNtu6isiLSGBsyh7tAkuiIdCxy+L+2a4Bsv7Y2x/W3s+ejhY?=
 =?us-ascii?Q?QHhz/R1FUWADKbfDysOqj3l4zx/GJUg2iZk9jYUif98Hvd8QBLgIKKTANClt?=
 =?us-ascii?Q?ckFU89jBO14VdALUe1IztHFkH4cy/UrDQXRlUzPSl3ghe9ErrEqhlJGY6azA?=
 =?us-ascii?Q?HJlzwfeHhI6NAzAbvlUnhjFQHoIEwICMYWolqp/8YtIaT3jCuLOkCSrwvXAa?=
 =?us-ascii?Q?N/157390EW95+Pv0zzu83FyVJijup/xWVWEXm02mT1MAL1Be95SIS7qVnjh+?=
 =?us-ascii?Q?ku1btV7Kekz6t1zl0W/uSxljfuag3rE/xV00kJXCYmLbDkszLPX3JuSENO8H?=
 =?us-ascii?Q?Z1Efxugkrs74//tMoBDBTYmmlnTcrGLTuAAZSuogujOchPCcmMGjQO3BPQ84?=
 =?us-ascii?Q?z2ttoqVBAPJZuH0/lf5K3onQ2ZxVG+7iABZv/osQq3XSch8YG+S1ao4vthO3?=
 =?us-ascii?Q?DyCgA82zgV0z0vTYt5dJz8+VwEi2cU2vY7qhcPPIxJuKXLIGLNYVxID8Pu3t?=
 =?us-ascii?Q?2JqH8cY78OZe7ADhsbWJ1hB1KsEsQJhYaiVz9uQTTZf0Pfc3A45hdCFgXiMm?=
 =?us-ascii?Q?Sn6N6loJIBgT55NUrhlQr/TwELrz60AXmi/1pvjIjDLo2xK44GToVxdBuZTi?=
 =?us-ascii?Q?P0KucxALg5icumvxMq6xa386l7NWeshgHbpAp1Rsjy4w85iu/l09Yx7K6evM?=
 =?us-ascii?Q?FWzXJBK+s2ynUkHaeyQ3qTKKqEMtzVKaXEtGVbAUIYaAXnjpH/D3i3QYc0qj?=
 =?us-ascii?Q?oYkktqDfmNNsK0OAFZWs+l+MSH04e7ESaCzP2sexva1XYu0KmkDx9Cx47xK6?=
 =?us-ascii?Q?jI3RL1lJVtxLBFd4dmpxE9egXB2eGtwRWUbdr+mTLKsKfF48hkaxZhQgR18n?=
 =?us-ascii?Q?p1tQWAdOz+sE31Sij2YmjibYozmSMdKrn5vp2dCqBZj2xjB5ZlKrdsURvLWs?=
 =?us-ascii?Q?y/z1gezBAQjBrIrwUOF18aKQPzy4kpqm9zVp2KtzLOt5BdLYkyN8Xcl1UqxK?=
 =?us-ascii?Q?6YN3k+z5Bw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e01333f-2936-4c14-53d1-08da1711bb00
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 14:36:54.7464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XfOxvfv0wyG6XWtCsUoP15LBNbEKjoSnn4cxuOsOLFudRDrnxbdLcL6yJHB9G2dsIHl+/KyvzRpXTuiegN13RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5184

On 05.04.2022 12:27, Roger Pau Monn=C3=A9 wrote:
> On Thu, Mar 31, 2022 at 11:45:36AM +0200, Jan Beulich wrote:
>> --- a/xen/arch/x86/efi/efi-boot.h
>> +++ b/xen/arch/x86/efi/efi-boot.h
>> @@ -568,6 +568,49 @@ static void __init efi_arch_video_init(E
>>  #endif
>>  }
>> =20
>> +#ifdef CONFIG_VIDEO
>> +static bool __init copy_edid(const void *buf, unsigned int size)
>> +{
>> +    /*
>> +     * Be conservative - for both undersized and oversized blobs it is =
unclear
>> +     * what to actually do with them. The more that unlike the VESA BIO=
S
>> +     * interface we also have no associated "capabilities" value (which=
 might
>> +     * carry a hint as to possible interpretation).
>> +     */
>> +    if ( size !=3D ARRAY_SIZE(boot_edid_info) )
>> +        return false;
>> +
>> +    memcpy(boot_edid_info, buf, size);
>> +    boot_edid_caps =3D 0;
>> +
>> +    return true;
>> +}
>> +#endif
>> +
>> +static void __init efi_arch_edid(EFI_HANDLE gop_handle)
>> +{
>> +#ifdef CONFIG_VIDEO
>> +    static EFI_GUID __initdata active_guid =3D EFI_EDID_ACTIVE_PROTOCOL=
_GUID;
>> +    static EFI_GUID __initdata discovered_guid =3D EFI_EDID_DISCOVERED_=
PROTOCOL_GUID;
>=20
> Is there a need to make those static?
>=20
> I think this function is either called from efi_start or
> efi_multiboot, but there aren't multiple calls to it? (also both
> parameters are IN only, so not to be changed by the EFI method?
>=20
> I have the feeling setting them to static is done because they can't
> be set to const?

Even if they could be const, they ought to also be static. They don't
strictly need to be, but without "static" code will be generated to
populate the on-stack variables; quite possibly the compiler would
even allocate an unnamed static variable and memcpy() from there onto
the stack.

>> +    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
>> +    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
>> +    EFI_STATUS status;
>> +
>> +    status =3D efi_bs->OpenProtocol(gop_handle, &active_guid,
>> +                                  (void **)&active_edid, efi_ih, NULL,
>> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
>> +    if ( status =3D=3D EFI_SUCCESS &&
>> +         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
>> +        return;
>=20
> Isn't it enough to just call EFI_EDID_ACTIVE_PROTOCOL_GUID?
>=20
> From my reading of the UEFI spec this will either return
> EFI_EDID_OVERRIDE_PROTOCOL_GUID or EFI_EDID_DISCOVERED_PROTOCOL_GUID.
> If EFI_EDID_OVERRIDE_PROTOCOL is set it must be used, and hence
> falling back to EFI_EDID_DISCOVERED_PROTOCOL_GUID if
> EFI_EDID_ACTIVE_PROTOCOL_GUID cannot be parsed would likely mean
> ignoring EFI_EDID_OVERRIDE_PROTOCOL?

That's the theory. As per one of the post-commit-message remarks I had
looked at what GrUB does, and I decided to follow its behavior in this
regard, assuming they do what they do to work around quirks. As said
in the remark, I didn't want to go as far as also cloning their use of
the undocumented (afaik) "agp-internal-edid" variable.

>> --- a/xen/include/efi/efiprot.h
>> +++ b/xen/include/efi/efiprot.h
>> @@ -724,5 +724,52 @@ struct _EFI_GRAPHICS_OUTPUT_PROTOCOL {
>>    EFI_GRAPHICS_OUTPUT_PROTOCOL_BLT         Blt;
>>    EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE        *Mode;
>>  };
>> +
>> +/*
>> + * EFI EDID Discovered Protocol
>> + * UEFI Specification Version 2.5 Section 11.9
>> + */
>> +#define EFI_EDID_DISCOVERED_PROTOCOL_GUID \
>> +    { 0x1C0C34F6, 0xD380, 0x41FA, { 0xA0, 0x49, 0x8a, 0xD0, 0x6C, 0x1A,=
 0x66, 0xAA} }
>> +
>> +typedef struct _EFI_EDID_DISCOVERED_PROTOCOL {
>> +    UINT32   SizeOfEdid;
>> +    UINT8   *Edid;
>> +} EFI_EDID_DISCOVERED_PROTOCOL;
>> +
>> +/*
>> + * EFI EDID Active Protocol
>> + * UEFI Specification Version 2.5 Section 11.9
>> + */
>> +#define EFI_EDID_ACTIVE_PROTOCOL_GUID \
>> +    { 0xBD8C1056, 0x9F36, 0x44EC, { 0x92, 0xA8, 0xA6, 0x33, 0x7F, 0x81,=
 0x79, 0x86} }
>> +
>> +typedef struct _EFI_EDID_ACTIVE_PROTOCOL {
>> +    UINT32   SizeOfEdid;
>> +    UINT8   *Edid;
>> +} EFI_EDID_ACTIVE_PROTOCOL;
>> +
>> +/*
>> + * EFI EDID Override Protocol
>> + * UEFI Specification Version 2.5 Section 11.9
>> + */
>> +#define EFI_EDID_OVERRIDE_PROTOCOL_GUID \
>> +    { 0x48ECB431, 0xFB72, 0x45C0, { 0xA9, 0x22, 0xF4, 0x58, 0xFE, 0x04,=
 0x0B, 0xD5} }
>> +
>> +INTERFACE_DECL(_EFI_EDID_OVERRIDE_PROTOCOL);
>> +
>> +typedef
>> +EFI_STATUS
>> +(EFIAPI *EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID) (
>> +  IN      struct _EFI_EDID_OVERRIDE_PROTOCOL   *This,
>> +  IN      EFI_HANDLE                           *ChildHandle,
>> +  OUT     UINT32                               *Attributes,
>> +  IN OUT  UINTN                                *EdidSize,
>> +  IN OUT  UINT8                               **Edid);
>> +
>> +typedef struct _EFI_EDID_OVERRIDE_PROTOCOL {
>> +    EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID  GetEdid;
>> +} EFI_EDID_OVERRIDE_PROTOCOL;
>> +
>>  #endif
>=20
> FWIW, EFI_EDID_OVERRIDE_PROTOCOL_GUID is not used by the patch, so I
> guess it's introduced for completeness (or because it's used by
> further patches).

Indeed (the former; there's no use in later patches).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 14:53:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 14:53:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299186.509683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbkZ1-0008TV-61; Tue, 05 Apr 2022 14:53:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299186.509683; Tue, 05 Apr 2022 14:53:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbkZ1-0008TO-1o; Tue, 05 Apr 2022 14:53:47 +0000
Received: by outflank-mailman (input) for mailman id 299186;
 Tue, 05 Apr 2022 14:53:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbkYz-0008TE-L4; Tue, 05 Apr 2022 14:53:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbkYz-00037u-H8; Tue, 05 Apr 2022 14:53:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbkYy-0005vC-TO; Tue, 05 Apr 2022 14:53:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbkYy-00081d-Su; Tue, 05 Apr 2022 14:53:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Cm3tC0bsdvxsjvgGa1ORVQ0sroVGijf2UAiH5PmJoas=; b=VihdGmNvaz9lgZ/rxlci6N1p9+
	3rGhLHD0GGVK/5tDeeTwIv8x9z4anv5QfmJ653//yu2Hl8gNbneeXYjxxRL6QRfnLytTkzbOf1TtS
	lAozwcmCBcsrKDUjSN53FOwhb7zqst/GnLYHVwO1f3WzO73d23JxkW2EXXAL0IuXH0tA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169170-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169170: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl:guest-localmigrate:fail:regression
    xen-4.14-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=57cd4b1c52881e49901b344ca3da00209c4689f7
X-Osstest-Versions-That:
    xen=ca304edd3ba8c19211107fd2e898249987557ce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 14:53:44 +0000

flight 169170 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169170/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl          18 guest-localmigrate       fail REGR. vs. 168506
 build-arm64-xsm               6 xen-build                fail REGR. vs. 168506

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168506
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168506
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  57cd4b1c52881e49901b344ca3da00209c4689f7
baseline version:
 xen                  ca304edd3ba8c19211107fd2e898249987557ce5

Last test of basis   168506  2022-03-10 14:16:31 Z   26 days
Failing since        168862  2022-03-25 17:36:39 Z   10 days   14 attempts
Testing same since   169170  2022-04-04 23:09:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 430 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 14:56:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 14:56:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299195.509694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbkbw-0000jF-Qt; Tue, 05 Apr 2022 14:56:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299195.509694; Tue, 05 Apr 2022 14:56:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbkbw-0000j8-Nn; Tue, 05 Apr 2022 14:56:48 +0000
Received: by outflank-mailman (input) for mailman id 299195;
 Tue, 05 Apr 2022 14:56:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HhHa=UP=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nbkbv-0000j2-Lx
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 14:56:47 +0000
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com
 [2a00:1450:4864:20::232])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d285d60-b4f0-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 16:56:46 +0200 (CEST)
Received: by mail-lj1-x232.google.com with SMTP id b43so17412282ljr.10
 for <xen-devel@lists.xenproject.org>; Tue, 05 Apr 2022 07:56:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d285d60-b4f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=X/Bq21aIGH20txJFUtqEmma1uM4faSauTpjrY1bPxs0=;
        b=oc0xzbn6ucHu0D0cwGPwINsSD6km+B+lbONMkvQ0H+zUNYL3x0klg3URjOllipTpba
         psPWm9UKl+pGj/boPtv2NcFjEeW0UvndILkQIOFSJ6KtHn2fWYZFHBgMTBRUjborwe3N
         dxtRnqAYAbzepYtkGEtc17sAEmOhIG/Ko2l8S8UIw8gyJFmXHJc8vdGLpNw/tO7Y1kYS
         0BnIAh9sibsJwrhqCeQ8jzgi1BxcfdMemEJ8uD2+KFdnOg76rGSUYpGQemSt2EtUnDAf
         6A8A1KbO35WSWb5z8+FOXHdgagxgydUK4nhGnEkX0mBnXBSEdG/T84m9aW9oo7Y3INCG
         /PWg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=X/Bq21aIGH20txJFUtqEmma1uM4faSauTpjrY1bPxs0=;
        b=GQzdIZpNKfEphkKZC4G0u7TrVNFwwWSAVnSLQYzD5AdX1KrSzxjpVAW0jW9wYtlsRD
         hISBreDwplQNMIqkFhKTittEsWIYeYCaik5DKA46teoS9rUA7rCYPg1d9URppD1vKp9O
         ChMBZgKj7E4jTp1p13l2BotHjGVnqW2FuPWChg2KTMTUoATHivqFVKxOJVip3c5bs2eJ
         ikxEBYS/+MRpSr7OpYlQCHN0/2z8vpnLCwH2n6BKB1kOMLXgDaesggSRfr1P3VmPpsAm
         ML9N6LoPZDB8JkZu/X2WWZPXXPg0XZd8TIiXxMdkHQIfoY7C3j0mVe/G+JFAKcyzv/yi
         WV1w==
X-Gm-Message-State: AOAM530wbtzhSs0zmge6yG22LjIrT+o1IsmsuYfl7XK5k4u/3FOWW+rn
	PyXI+NPSo/YMDqgeGi+ICNls/okbDnswSLomLC2ZYGLz
X-Google-Smtp-Source: ABdhPJwbaYFzjKt84/kVDmmk/xncbnKw7liqak5f3qtm92+pYZi+I2CAeaYHVPQaptA1ACgPg/RWRLNQobRuW8PgU7Y=
X-Received: by 2002:a2e:a372:0:b0:249:7108:6778 with SMTP id
 i18-20020a2ea372000000b0024971086778mr2464963ljn.403.1649170605921; Tue, 05
 Apr 2022 07:56:45 -0700 (PDT)
MIME-Version: 1.0
References: <20220330181734.30319-1-jandryuk@gmail.com> <f5225d49-fcc5-c02c-2e48-cd96cc2bd940@suse.com>
In-Reply-To: <f5225d49-fcc5-c02c-2e48-cd96cc2bd940@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Tue, 5 Apr 2022 10:56:34 -0400
Message-ID: <CAKf6xpuVJTBvKCK6FtKP7STEAQ-A0GXX=918DRPmYAt3P_byKA@mail.gmail.com>
Subject: Re: [PATCH] x86/irq: Skip unmap_domain_pirq XSM during destruction
To: Jan Beulich <jbeulich@suse.com>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, 
	xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, Apr 5, 2022 at 4:18 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 30.03.2022 20:17, Jason Andryuk wrote:
> > xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
> > complete_domain_destroy as an RCU callback.  The source context was an
> > unexpected, random domain.  Since this is a xen-internal operation,
> > we don't want the XSM hook denying the operation.
> >
> > Check d->is_dying and skip the check when the domain is dead.  The RCU
> > callback runs when a domain is in that state.
>
> One question which has always been puzzling me (perhaps to Daniel): While
> I can see why mapping of an IRQ needs to be subject to an XSM check, it's
> not really clear to me why unmapping would need to be, at least as long
> as it's the domain itself which requests the unmap (and which I would
> view to extend to the domain being cleaned up). But maybe that's why it's
> XSM_HOOK ...
>
> > ---
> > Dan wants to change current to point at DOMID_IDLE when the RCU callback
> > runs.  I think Juergen's commit 53594c7bd197 "rcu: don't use
> > stop_machine_run() for rcu_barrier()" may have changed this since it
> > mentions stop_machine_run scheduled the idle vcpus to run the callbacks
> > for the old code.
> >
> > Would that be as easy as changing rcu_do_batch() to do:
> >
> > +        /* Run as "Xen" not a random domain's vcpu. */
> > +        vcpu = get_current();
> > +        set_current(idle_vcpu[smp_processor_id()]);
> >          list->func(list);
> > +        set_current(vcpu);
> >
> > or is using set_current() only acceptable as part of context_switch?
>
> Indeed I would question any uses outside of context_switch() (and
> system bringup).
>
> > --- a/xen/arch/x86/irq.c
> > +++ b/xen/arch/x86/irq.c
> > @@ -2340,10 +2340,14 @@ int unmap_domain_pirq(struct domain *d, int pirq)
> >          nr = msi_desc->msi.nvec;
> >      }
> >
> > -    ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
> > -                               msi_desc ? msi_desc->dev : NULL);
> > -    if ( ret )
> > -        goto done;
> > +    /* When called by complete_domain_destroy via RCU, current is a random
> > +     * domain.  Skip the XSM check since this is a Xen-initiated action. */
>
> Comment style.

Yes.  Sorry about that.

> > +    if ( d->is_dying != DOMDYING_dead ) {
>
> Please use !d->is_dying. Also please correct the placement of the brace.
> Or you could avoid the need for a brace by leveraging that ret is zero
> ahead of this if(), i.e. ...

Here I was patting myself on the back for remembering the spaces
inside the parens, and I screwed up the brace...  Sorry.

I intentionally chose DOMDYING_dead because, from my reading of the
code, complete_domain_destroy should only reach here when dead (and
not dying).  If this function is reached when DOMDYING_dying, then
that is unexpected.  That would be a guest-initiated action and
therefore the XSM check should apply.

Just checking is_dying is fine, but I want to explain and highlight this aspect.

> > +        ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
> > +                                   msi_desc ? msi_desc->dev : NULL);
> > +        if ( ret )
> > +            goto done;
> > +    }
>
>
>     if ( !d->is_dying )
>         ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
>                                    msi_desc ? msi_desc->dev : NULL);
>     if ( ret )
>         goto done;

I'm planning to just do it this way.

Thank you for reviewing.

-Jason


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 15:02:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 15:02:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299200.509708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbkhM-0002Dg-HF; Tue, 05 Apr 2022 15:02:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299200.509708; Tue, 05 Apr 2022 15:02:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbkhM-0002DZ-Ck; Tue, 05 Apr 2022 15:02:24 +0000
Received: by outflank-mailman (input) for mailman id 299200;
 Tue, 05 Apr 2022 15:02:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nbkhL-0002DT-C1
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 15:02:23 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6429d03b-b4f1-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 17:02:21 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6429d03b-b4f1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649170941;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Oyke/ISGAUnVCI3YpQEIb6qkaB8YyRN/rhpUROCP6sI=;
  b=ERwbt5t5mGjLKjJfcc4UNP15PJLdwZOspAUFQrtyYscKSs2lO7Ibjgnj
   gHa2qoGROF94ftTcO3cWzjYfnYCD/G0VtrqzgHb6FRHBwOPhcV5sp9TnB
   ms0IQX3bwg+XuvrnZjaD2U3p/0FopmYxMrb226lz2xWHF7xjN6mplOYpB
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68056717
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VGv/OK6C5x80v9bBqRQ7cQxRtOjHchMFZxGqfqrLsTDasY5as4F+v
 jQbCmjTP/6CYGbyKY1yOd+y/UpU6J7WyIBqTgdq/y49Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThXlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSxdD8VboTmsdg0Vjh0FxgvGaFp/rjudC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQTa6DO
 ZVANlKDajzJWg8fI2kTFa5lgb26wXqnSmxpiQqs8P9fD2/7k1UqjemF3MDuUt6DQ8lPj1ubj
 m3D9mX9RBodMbS3xTWJ/322j8fTjCj7X8QUD7T++fl06HWIzWsPFFsaXEW6utGilkekX9tVb
 U0TkgIitbM39VCrZtDlUgekvWWfuRoBR9tXFfZ84waIooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iIAOti6fZ/xKLIewr/HxIGDUz
 x+MqwFr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4
 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5ZIlcFg
 2eJ4Gu9AaO/2lPwMMebhKrrVqwXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ
 8vKKZz0UStGUvg7pNZTewv7+eV2rszZ7TmNLa0XMjz9iebODJJrYelt3KSyghARs/rf/VS9H
 yd3PMqW0RRPONASkQGMmbP/2WsidCBhbbiv8pQ/XrfafmJORTFwY9eMkOhJU9E0wMxoehLgo
 yjVtrlwkwGk2xUq6GyiNxheVV8Ydc0m9yhmYnVwYw3ANrpKSd/H0ZrzvqAfJNEP3Odi0eR1X
 78CfcCBCe5IUTPJ53IWapyVkWCoXE327e5SF0JJuAQCQqM=
IronPort-HdrOrdr: A9a23:dWfIV6yIeVZH2T/QLSeoKrPw9b1zdoMgy1knxilNoEpuA7elfq
 eV7ZAmPH7P+VMssBNJo7q90cy7LE80mqQY3WB8B9iftWrdyQmVxeNZjbcKmAeQYhEWn9Q1vc
 xdms5FZuEYZmIK7voSjjPYLz6OquP3ipxBKY3lvhBQpaABUdAH0y54Dh+cCVB/QwNLbKBJbK
 ah2g==
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68056717"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c49vcgNnfFzzQT8zeHOT0hGPrJ3GxNXRIgFGs5fBR8cLk6IdWzxPoJ8i1BXdMkDjPn1tRayycuRZt0ID8Pm/EYQtRcVCz0LwH4meztOtcwzkokOV0fOty4yAkx0KO3lhKfP7t3ty48CYcUEN90REZFQUMBU7LJ8rVPnGkVEHN33FqekEzjfygnSr1wbSIabQ4jAiTJbhbWsiPXu6EROWxDv0GCpwJgPTjuAqBhWzkFacdtiD4AfqdE20IKiLT9VH+IvWqWXvwgI2f9Iay12vZrRkKoYUfQyHuAyaH0nONhCPLo5T9hwA8dP2mKuWQcWvybqCiyyebfyjBkOing8Dzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=khxftXRJ5VV5NNPI913hPMepB9iJZcjrmSRTl13EHsU=;
 b=P/BR/IT2yWC+5ONnyCfdZ/dH4cV0cv1ROi/7jPF7ibgcAWug7RcCInYE+QLFODMalyXlC0U0UuawkUXI1IHgnmMhAhSTom8yh/lkd6XB/I3rTKiO18HPt13L0cisVgdXj2gd5xaImCxHA+Ru8Ti50eH2BFKLNzXgBKsge0aPRlh0SHbGXcqbCTGuxitAqcvP0FETMB/VWgruf6ahDL/Nc7yN/KpRPuHmDORDSU+6A6fvlkaExMYFaZTcodFdQJkc4fKV1kfJr2sgUjZz7e1GV+5auOIZVcx24WzkYsNUCMn3x1eTziWPANfZjUT1xLotQbL8qenHKpAkaUiDaJ8jJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=khxftXRJ5VV5NNPI913hPMepB9iJZcjrmSRTl13EHsU=;
 b=D2YoYpervj+WX8jgaP4CgTu7/+6c0gP3rjWgV1LL8dp+LxJfnVrzPPpFoYOPzRpJX6cymjDkfS2Et6mh1uJ+Vo8pFwxbosTndjnn5NHpA80KxuLg63ZjATOKqAlfOI1vPJ/5mR2lJZmcoCcR4OiD0Xw+HrjlACGmj66bCSmKjEw=
Date: Tue, 5 Apr 2022 17:01:53 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
CC: <xen-devel@lists.xenproject.org>, <scott.davis@starlab.io>,
	<jandryuk@gmail.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Message-ID: <YkxZ4RWAEKRSdUWL@Air-de-Roger>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <YkWgXhFVq/fD72CB@Air-de-Roger>
 <25c10763-36fa-34d4-05b6-655c08fdfee7@apertussolutions.com>
 <YksK9hIbJbOXkIYd@Air-de-Roger>
 <cd178295-4c8b-6710-3050-011fcee378b1@apertussolutions.com>
 <Ykvy4lWiwASHGXcF@Air-de-Roger>
 <959fce1f-31c4-3de8-c3f2-45c307502473@apertussolutions.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <959fce1f-31c4-3de8-c3f2-45c307502473@apertussolutions.com>
X-ClientProxiedBy: LO4P123CA0027.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:151::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f430cee-7c00-469b-f30a-08da17153b6b
X-MS-TrafficTypeDiagnostic: PH0PR03MB6384:EE_
X-Microsoft-Antispam-PRVS: <PH0PR03MB63844F24AAFF4C7A441B177A8FE49@PH0PR03MB6384.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Ai3whgIoTTmN0G4EqekGy7QEwP5btYIIsNrN3Kj2hdQqwFZaHmht9geO0RsRErP/SisuPBwyOHI6aHwRUQzvVel1QJYBOmtWuBHnmjwTOWISWfbct/8IZJPpUhcIWzk9aak2XCCRNEhbO5QfDOZiougqHZnII+T50Xj2yftnAhNTEes+qRF4j4lhUFxjtLELtiFM2aKKiyo2yUzlQdQxzddLV2flasPtpEctjhf0x8+9hlI4DST4Fq0ynSLZIkcW2XmxGIKjQYYLYmNJ8KjKm0JcZNR5L/S9mhIoLZW1TSfki0pNOF2YOeSVSnN38otI6x0IR+KGEYcJ1sqpWZ4cpDP5ix/R7is6N7ItckA9fDtI54c0RqpWCykDH3SBqtTGjFabt7hX+0JAMESKuiV2nWh6fA9yPbUBkAiTt5TUy8qMLcBb3ChslNEcjh73s0Q/Mo/CLUSe0vmbHbXRCIsbnzaS+MOI5XIOnOnWDPK8DgPqRnxKY9mHC0zKfc2pL4Hl+PQmNAXI7GTzUEJFf/8hS8uP1Atx4niW7jrMzhKr+u2KWuZpyL0Mrb9asNtyUkBToTPiBQh223EkvPr0a6FlPQkKhGvpWVlg6xSfTvb7viE/jK86hqx3rF5UeWS71lZMH4kmWZH132cTZrAWUnudffVG/fiwMFVUwaQAobN/fUFPEhwHZ5mai+ODtM+zFkXT3+X+vi2dcTYRH7swn2PryiMTuY5QiVC/PwOhXL1ICR4=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(6916009)(38100700002)(2906002)(26005)(186003)(54906003)(86362001)(107886003)(316002)(8676002)(8936002)(9686003)(66556008)(66946007)(82960400001)(4326008)(85182001)(33716001)(966005)(5660300002)(6486002)(66476007)(6512007)(508600001)(6506007)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkVZWld4MGZCZEh3WXhBM0hSOCtncit6MnUwU0dGNjNwQ2pOcjB2MldPSkxQ?=
 =?utf-8?B?UGVEWS9kUXBaWC9odythSnRHL0tsVDBCQlBoOVJjUUwzV0hyNExYNXk5ZGpU?=
 =?utf-8?B?RWxaUDgvTmN2NmN2OEw0L0ZEY3pHVnN4Zm9rdkxlVDZWL2pMWjFmblJMSnc4?=
 =?utf-8?B?eVBWanN6dGl4R3pwSXFMblNDYjZuUnpNaGlvVzNoV1RoVmZOMzlJNUE0N0Ja?=
 =?utf-8?B?Nm1saStVZ00xcFpiMXFJQlVoK3VaUlp0Y0k0ZDUxSnZLODdIREIrNTZnQ3Vs?=
 =?utf-8?B?c0hMZkR5TGhiWmFMOWdJOVE2RDhSL1BIVGVmOEJvbmhRcnBha2szYWwyOC9w?=
 =?utf-8?B?K2NaakZkdjZGR05GRERhRHJsRTA4amFiVmdNWWZoZldsckExUVFaZ3hwNTVC?=
 =?utf-8?B?SUQ3WnVIQVdzTXMzWFZwUDEzTURncWE0MzMxUFY0Z0cyWnJXTHl1ODJ3NlNq?=
 =?utf-8?B?VDBjYURwYnNaaHcvenZaNnBkNVl6Y2FWVFJnbTM1azVmSHRlWk1MMHdKSHk5?=
 =?utf-8?B?aHEvbGJKd0lHS0FaWHNXbU9UWFcvU0pYd2MrQksrTnc5WnhVMGlTbE05a1Nq?=
 =?utf-8?B?dXRydlNrTVN2bGVlT1VCbU5oQmptYkpDQVY2WWprTDFVN0QwcGNxdm15Sndk?=
 =?utf-8?B?RzNaWllBQk9MTUxRdlg1WWd5Y2ZmUUVrZXZTRnR3TnFqNWtQUnYrMTdnVnZl?=
 =?utf-8?B?MktYdGN1R21GTGdZQUhoZVFUd3RiWmM2YXFZQzRWTnpCTEFsekp5NFg5VHZN?=
 =?utf-8?B?alI5aE85YWlvQzJTRVlVR2FVYmZzdWVOTWxpLzVOTVVabzZNY2N0ZkFRbGcr?=
 =?utf-8?B?TFpxY0V3ZnZ4aEhMYzhQd3Y3d055akJaTVBKK1ppQWJ1dk9nTHFtakVlUWtR?=
 =?utf-8?B?cldxRzhWWGt0QXVHRng2a2RrWndXcVpRK3FGYk1qTks2K3h6aWlRUDJqVWRG?=
 =?utf-8?B?ejlXVG4xcHlKOE9QQnptNnNpeU1wd0JTV1UwWTZKM0M5Y2p2RzlBb0JvUEVn?=
 =?utf-8?B?Wm44OUIva3g5UEN0WDRVYXhMejEwdDBqTTAxK05UNmlnd1lnWlJRMVBSUjFY?=
 =?utf-8?B?dFpVOG45NXgweUUwVVoyajdhSU9Ca3pINFZBcGNid2ViYkpRekdJUGRhQzh5?=
 =?utf-8?B?RStxWjNEUmdZQWZDRy9hWFJ3MVUxT01qUGEzQ3Z0TlJJSXBrdkkvZzlpdGxR?=
 =?utf-8?B?TjVWQVJHaWFLWUdBOTVGdENEWFZrYXNQb1ZxMG94M0dDRmFKcWtTUnVlNnUr?=
 =?utf-8?B?T2V4djQ1R2dONnlsRWdoYXY5c1d2NVMzUGlRNm9OOVJBYUZLN0JWUmFwdk1L?=
 =?utf-8?B?V21aeTU4TVNQRmIzTEVrTG96L2RKb0wzbnJPSzRkZVJTNnR5cStKSHBHTGdJ?=
 =?utf-8?B?bWN5UWpHN3ZBTjIxd3ZjcXZRNE9COFpLY1JLMWZRa3pnU0JPU2RISG5SeWl3?=
 =?utf-8?B?TnJkUTdPaFRKN1pwS1ExQU1ackdvY0ZVSStSaHdGZll4YW93UW5vaXpJenRa?=
 =?utf-8?B?Ynl0Qzg4ekJPYi9Ca3dOdC9pUjMxYWJ2b3dBdnpSMXdWNm1PR2V2cUZ0dXgw?=
 =?utf-8?B?YkNlMDhvT2RpbHZFZDM4WGczNzRTVTZOdjdwYVV2SnBOU1krS0hSL0grWWxO?=
 =?utf-8?B?MGYrR2FpY3VkS1poR2FSc1ZGQXp2MnVEWE5SQ2xNWE1KZ2V4ODFJU1hjV3Vz?=
 =?utf-8?B?YW9DYnlCMmdpWk9RZ2VvcXROdzhQZjI0T2VqWXpMbzdKT2Q0RXc5cWtwRWdV?=
 =?utf-8?B?V0hSWDBMalpia3hvSGhkb2l1cGFuMVl3Z0ZrbUdhNFZVWmQxSGF3QTVudmUv?=
 =?utf-8?B?RDNJV1pjMGx1allqeXUyRzkveXZocTQyWStwWUkzKy9BVXFCUkJ1bEVkWGhv?=
 =?utf-8?B?VThaSTdObUc1RENuVHcwbEFEOTJuTTZuUlBwWUpRdk9jQmxjNm1pZ3NEQ3ZC?=
 =?utf-8?B?cFg3OGdsRnRldU01Wk1aS0s2OGtBdmN5OXJTQW43bVp6alJHMWtwVFd5L2Ex?=
 =?utf-8?B?R2lOR0NYNDFRSm9EdHhpMHVOQWtWaUlHZCtlTkVkd2M0N2FGc2xKZjRJSEJ3?=
 =?utf-8?B?Vnk1U05SeDkvbTNjS2ZrZ0RRQWR2N3BMTGpvWFUwVm8wMGREVzRHUmp6eGV6?=
 =?utf-8?B?OXNLcGVTZ1RGS1ptY2dmSW13Y3Bwekp3bUZ1V0lzL2dpRURRNm8vYWlod202?=
 =?utf-8?B?R2hRVWp3NWlRL1dPTGFYekNaTWk3RGhWSVJmUUpLdllmKzRwdzBUcjk3SDRX?=
 =?utf-8?B?R1FNekpNeW1HSHdFL014L2YydUUzbVFQN1VlZDk0R0x6T0tkT1Nxc3VzNmxK?=
 =?utf-8?B?TWo5UVRYSG9DY3JORlp2dk80dTh4Y3duNUJqdEhuSUZ4TTdUNmFvVmlpc1Zi?=
 =?utf-8?Q?zsHX0M0ewtPj4foQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f430cee-7c00-469b-f30a-08da17153b6b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 15:01:58.9871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: miOkKJKSZ+SXhpZVZOp5kdhg9JGhR7OzMmOGboDM4KDgZSXkxA6/IL58m6AkorxRcWjGm3cdP27JqiyptDv4nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6384
X-OriginatorOrg: citrix.com

On Tue, Apr 05, 2022 at 08:06:31AM -0400, Daniel P. Smith wrote:
> On 4/5/22 03:42, Roger Pau Monné wrote:
> > On Mon, Apr 04, 2022 at 12:08:25PM -0400, Daniel P. Smith wrote:
> >> On 4/4/22 11:12, Roger Pau Monné wrote:
> >>> On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote:
> >>>> On 3/31/22 08:36, Roger Pau Monné wrote:
> >>>>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote:
> >>>>>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> >>>>>> index e22d6160b5..157e57151e 100644
> >>>>>> --- a/xen/include/xsm/xsm.h
> >>>>>> +++ b/xen/include/xsm/xsm.h
> >>>>>> @@ -189,6 +189,28 @@ struct xsm_operations {
> >>>>>>  #endif
> >>>>>>  };
> >>>>>>  
> >>>>>> +static always_inline int xsm_elevate_priv(struct domain *d)
> >>>>>
> >>>>> I don't think it needs to be always_inline, using just inline would be
> >>>>> fine IMO.
> >>>>>
> >>>>> Also this needs to be __init.
> >>>>
> >>>> AIUI always_inline is likely the best way to preserve the speculation
> >>>> safety brought in by the call to is_system_domain().
> >>>
> >>> There's nothing related to speculation safety in is_system_domain()
> >>> AFAICT. It's just a plain check against d->domain_id. It's my
> >>> understanding there's no need for any speculation barrier there
> >>> because d->domain_id is not an external input.
> >>
> >> Hmmm, this actually raises a good question. Why is is_control_domain(),
> >> is_hardware_domain, and others all have evaluate_nospec() wrapping the
> >> check of a struct domain element while is_system_domain() does not?
> > 
> > Jan replied to this regard, see:
> > 
> > https://lore.kernel.org/xen-devel/54272d08-7ce1-b162-c8e9-1955b780ca11@suse.com/
> 
> Jan can correct me if I misunderstood, but his point is with respect to
> where the inline function will be expanded into and I would think you
> would want to ensure that if anyone were to use is_system_domain(), then
> the inline expansion of this new location could create a potential
> speculation-able branch. Basically my concern is not putting the guards
> in place today just because there is not currently any location where
> is_system_domain() is expanded to create a speculation opportunity does
> not mean there is not an opening for the opportunity down the road for a
> future unprotected use.
> 
> >>> In any case this function should be __init only, at which point there
> >>> are no untrusted inputs to Xen.
> >>
> >> I thought it was agreed that __init on inline functions in headers had
> >> no meaning?
> > 
> > In a different reply I already noted my preference would be for the
> > function to not reside in a header and not be inline, simply because
> > it would be gone after initialization and we won't have to worry about
> > any stray calls when the system is active.
> 
> If an inline function is only used by __init code, how would be
> available for stray calls when the system is active? I would concede
> that it is possible for someone to explicitly use in not __init code but
> I would like to believe any usage in a submitted code change would be
> questioned by the reviewers.

Right, it's IMO easier when things just explode when not used
correctly, hence my suggestion to make it __init.

> With that said, if we consider Jason's suggestion would this remove your
> concern since that would only introduce a de-privilege function and
> there would be no piv escalation that could be erroneously called at
> anytime?

Indeed.  IMO everything that happens before the system switches to the
active state should be considered to be running in a privileged
context anyway.  Maybe others have different opinions.  Or maybe there
are use-cases I'm not aware of where this is not true.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 15:47:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 15:47:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299205.509719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nblOw-0006hH-0L; Tue, 05 Apr 2022 15:47:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299205.509719; Tue, 05 Apr 2022 15:47:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nblOv-0006hA-TU; Tue, 05 Apr 2022 15:47:25 +0000
Received: by outflank-mailman (input) for mailman id 299205;
 Tue, 05 Apr 2022 15:47:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPnP=UP=citrix.com=prvs=087021108=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nblOu-0006h4-9v
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 15:47:24 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id acd9eff6-b4f7-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 17:47:21 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: acd9eff6-b4f7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649173641;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=6dYe4LGFao6hQkBaHwhd4Pw8zZgzFFK9PCR9WLyouig=;
  b=FrbttgBkAi+HJZD1UEKYLh4OsU6qvSPlDARLdi9mQSfUruHJ322fAwoW
   YPyS94Z1NKf0ity+YigAlQGBg3zu28mdzKRBYZrciV7m6zOc9BkJHo9PX
   lCyBe+3v2eQbErqacltoB18Zv+E2hsC9rcVwC0xgmoGjfqjlc3f3IUJNZ
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68062711
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UGGsf62YaAwupiv5gPbD5SZxkn2cJEfYwER7XKvMYLTBsI5bp2dWm
 zAYCjvSM/uNM2ugftknadjn90sE657Syt4yQAdqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIw3IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1ksMSbSlwCb5b9o88CXgljLQ50bb1ZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u1pgQR6mHP
 qL1bxIzSgjESQZABmxMN8Mbo7yTnXXEYgNx/Qf9Sa0fvDGIkV0ZPKLWGMHOZtWASMFRn0CZj
 mHL5WL0BlcdLtP34SSC9nWgl+rehxTxUYgZFKC73vNyiVjVzWsWYDUcWEGnu/C/hgi7UshGN
 k0P0iM0qO4580nDZtvgWxy1plaUsxhaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQOpMIwADAny
 FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcdYQcUQA1D5MPsyLzflTqWEIwlSvTsyISoR3egm
 FhmsRTSmZ06iJYg1P6QrGv2uBmzq4jycCE/thXICzfNAhxCWKapYImh6F7+5PlGLZqEQlTpg
 EXoi/Ry/8hVU8jTyXXlrPElWejwuq3baGG0bUtHRcFJyti7x5K0kWm8ChlaLVwhDMsLcCSBj
 KT76VIIv8870JdHgMZKj2ON5yYCkPOI+TfNDKm8gj9yjn5ZLlLvEMZGPxP44owVuBJw+ZzTw
 L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2PFMihl0j6jeHCOBZ5rIvp1nPUM4jVC4ve/m3oH
 yt3bZPWm32zrsWgCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJb9JIJUJfsLUcaU9U9xcx9z76Ql
 lnkAxMw4Aev1BXvdFTRAlg+OeyHYHqKhS9iVcDaFQ3zgCZLjEfGxPp3SqbbipF8rbY5kKEtE
 6deEyhCa9wWIgn6F/0mRcCVhKRpdQixhBLIOCygYTMleIVnSRCP8djhFjYDPgFXZsZrnaPSe
 4Gd6z4=
IronPort-HdrOrdr: A9a23:pgfQNK61dqkxZz/IVQPXwSyBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc6AxwZJkh8erwXpVoZUmsiKKdhrNhQYtKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkANDSSNykLsS+Z2njBLz9I+rDum8rE9ISurUuFDzsaEJ2Ihz0JezpzeXcGPTWua6BJc6
 Z1saF81kSdkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq
 D5259T5cNzp/8tHNFA7dg6ML6K40z2MFvx2TGpUBza/J9uAQO4l3ew2sRz2N2X
X-IronPort-AV: E=Sophos;i="5.90,236,1643691600"; 
   d="scan'208";a="68062711"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VEy66GG0HwI+CtsMCHYj4leiYq9Lna02bdgxV6UlVMnq9TfGol0dYkrFPCxmwggOlO/Kv/o+Objo+knLidXnYKUHpjL9wSeUX3gJRGoNXXj7NFgfmQbT2cAIT2cJMluOQ/k8lp5oY6ln8UZFkvVTu5Rkn7nNNc+A9umbl6ibpcGuY67zyqgYTj8B0mrcPxUrEW1Nu42qN2BUAfsIHsFbGNJ2i+LaGjEwSzMCur7FZxk28n/n71Bb/LFgEDAYT5/hkjPNBACdHVfbfP0D+YVhhSwrKUMdDIj1PbESLII92sisgA12OUxkuiO8SOPXAAOYmCXS/LBvjKpOw5SQqfpgTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gv2ptfdss89fam2VXR3H+NHqs3Y+kN17iHb2puE2X1g=;
 b=KzkwZt2UT01zcOfuxB6QWwjFMiv/oPM6G8+ewJfyWg7l0Re3b1Co+MR5OiVOhUx/5a84XVygL46Op22IdnrlM3N/T5n1Mh0zpm4ILwpUVuP2SJNSOJ0WFWKOKCC9x0kUAfT5rJIW/152mF4J7JicPQdHIhNU5gvAXACpiKqLNM3GAZeYprXLh1gH4BR7H0cfJLLxPFe0Ka6nV7BO+EdwSd0nUwIz5gFkQtzp/zwBVajM3j+k68ZYZ1ChMldlaYpuAGQJbNIdW4Ie1wYSKq+hoLW7UG3h3ExqAGl2q6hlW/goiOWlZBIJznSHma+Rb1/1ZEUXQCUOBqzqHoXxSetCzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gv2ptfdss89fam2VXR3H+NHqs3Y+kN17iHb2puE2X1g=;
 b=f4YZPYPX6OBQprmEIzKmpouqjRSftWt0CW4p8JpcGn3F261rSEJZtQHBTmwEU5SuNnzkTLlkwjxw60sp4SVOENc9EkDPSH6YoP/Lr8DD/XbAtk9t/KErXEINRFHbV+RJx8FDWUzgUg1Jv02f9p8b4uCs0w9QS0pDRDSr5zgJQcE=
Date: Tue, 5 Apr 2022 17:47:09 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <volodymyr_babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Message-ID: <YkxkfbNpR7yfLP7W@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
 <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
 <39640fec-de8d-0c5a-c9aa-daf83fb785b0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <39640fec-de8d-0c5a-c9aa-daf83fb785b0@suse.com>
X-ClientProxiedBy: LNXP265CA0065.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5d::29) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8a132c1e-9f1c-4960-d216-08da171b8d78
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6582:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB6582183BCF7DB770648441488FE49@SJ0PR03MB6582.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: d+QzjLeZPESUWUy6OMw6FxwOnxw4uLXMqFtv7+U6fd+eGtM+wstKuvz9aU6sX7LXpYjuOGPQZ5/WDEtc5OF9gqP0e2oeOXr/cQ/LYfxllpV5pED8zGCv+lOHMQLPmkcgIXNIR1t91UaENQ/XB2b7Fj93VyMSiySDhiIzTDA/2A8gTokrm+ZgYMOPjQMmeSotTKw+QDlvyzT4O0ThbCq+jj6TcA3FK0KF/RfyltS4tBfCWhj6P1cRjPdkRAxPsf2QvilS+Br6Yxtj57D83HrLRhZ1TVwjAqOEx+GaF18J5yYk8hsD3b1rIyP5kWCtnL0kWT9x2qP5xr8TYLIwxVBaMq9ApikBsPmEn9KOo4qsAHdaJA5t/KSIiWhD5Lq48mYeuWoujMPwA8M8HDoReYpR8UXtDr3zDnxirje3yVNBUmV3yPhAwNdCNmAiweFonNm7aV9ADUzJ9uwiNPrIK5FWoXY16MHQQnccycxl7O34tgb4GlMe9Lr26Rt1vMlQOU3mMn3F/to29TGEUIo2w2F0/MlIpA4wZs7HzPZge1VO3fMYnf/UjdGERsW303uUbkhX0t2WH4cum5hE2cP6EdJJfA7VriiAM/pYM0IJDTSBcEeO0Ir70lu2lQ3lsjws6uGyZwVyVFLrXnGwWXr+DR+O7Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(6512007)(85182001)(6666004)(9686003)(38100700002)(82960400001)(6486002)(53546011)(8936002)(6506007)(4326008)(5660300002)(54906003)(186003)(26005)(2906002)(6916009)(83380400001)(316002)(86362001)(66556008)(66946007)(8676002)(66476007)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlBjeDlkTVVCSE03YnUyMmEyeFFUUGV3NUxFWUY5L091djgreVBvZEtZOURZ?=
 =?utf-8?B?Mk9NNUlyQTZnRlY1YnN0aGVoR0RwYXVzbG51VWF3citmN1c2SWxhcVVrd1A0?=
 =?utf-8?B?ZHBCeEwreGpHaE5VSWpBcXV2U0gyYjdiTkdmc2JFVTZNUlpyYjBxM1lxUkhJ?=
 =?utf-8?B?WXNsZ2FVK092NVFkenczVzRpazNHUnIzVWp1Wkx6QW5VSXdTK09nbDlMemNl?=
 =?utf-8?B?all6eE5LaWRiYk94NDdmRTJnSWZZeUxJU3NTeUxqdVc3YjB4bWVON3dtWS82?=
 =?utf-8?B?TmY4YzBqcUYrWWY0RGFDaGFiQWtEZy9GOU92UG5DT0ZRNml4OTlUd3NzSEZ2?=
 =?utf-8?B?eW00dGJuaHhKNXBaS1FDaTkzdHlwWkhIOEViaFBrR281MUhHaVNMOWNDTW5w?=
 =?utf-8?B?cmptMXpYSnpRTjRvcm1TcFdBc2k0QU1zZ1Rrd1I1bndTQk5GT0tleEhBYXJv?=
 =?utf-8?B?c1IxTFVyemJLWU8zdVlQaUx4SnlTcjEvR1NHeEF3Z0t1V1hyYzUyaU5JbjNP?=
 =?utf-8?B?eFp3cTFQSkJ5YUxZd094VlNoczI0MUt2U1F3dXVXR210RkszWWlVNWJJZ3hM?=
 =?utf-8?B?U2ZFaGI0TldLb0NYamMwSGpncmFZWWkyeVF0MWpOWWVHeEQxV1RSS1A3MXBi?=
 =?utf-8?B?TWFZa2VZWDNnbUFwTUF2b2Z2c3MzR0UxR3E5WGRUR2p4QkZKU1VmeGNGa3hL?=
 =?utf-8?B?VWJpNlRmUng5cS9MZ1FaeU56dHJhS0R1RkIyMFUvVjNMYkxXL1VxakZBZmta?=
 =?utf-8?B?RDZibzFrZmN1MXRpQUpMUCthc3p0VnlTeVErK2ZRdnF3bGcxajJnQ3JWbTZH?=
 =?utf-8?B?UEgrSnIyeVp0SUZmdGtwNWppNTB5VVJmQlE3TVZtZGZEQUdJVjEvYzE3dnFD?=
 =?utf-8?B?QXFJeUJvMnNFbUNkcE5kMG1WZ2MweDkxdllBT1J3YVFrR1orRUtPWEwxa1ph?=
 =?utf-8?B?bHF4N3BGdmYrQkVzRDhFY01TaFZyTVVIaThmUDB4Q0xaa2YvdFJ0Y0FpdWxy?=
 =?utf-8?B?bXZWMGt3TExib0crK3NmRHRuSy8yakVmYURCMThjUGFzM3l4MjhlbGJKdlND?=
 =?utf-8?B?SjkvWHJOTWdER3pRTU9xY3NkOWpaNDN1OUdFUWZ4K0VLZDFub3FTdjBCUWhz?=
 =?utf-8?B?QmNjNy94WVJSSnIweVBmOTBmamJMamVXUGYzNy8zOUxGd08wNHgxNGJGbUky?=
 =?utf-8?B?eGorc3NGRGtPMVdER0kyRlJOVm8rQ0VLVUdJeUhiODFJaWhoWFQrTWx2cGcw?=
 =?utf-8?B?bkNtZCtJQ0VQVng2NmxzVFRLd2ZtS2IzZGpSdXNkVVdRR09ueG5Wck5lZ0h2?=
 =?utf-8?B?WEg4aFJoQVBUUW93M1RMMmxZaEhqeWpFWWRNS0NvbElXdFUrLzBnOTNwR3lQ?=
 =?utf-8?B?a0cxcFBLaTdNTGljSnRTSzUzc2E3NkVPVjVqTDFucStWN3UxbisvNGJpQ0o3?=
 =?utf-8?B?aGswVkNqWGdWdHl1R2ZnRmtYZ3hrMlEvTTNaK2hLSlh0SFVMZmRGRi9kZG9m?=
 =?utf-8?B?MmlFamVjS21oQXhGUVJQa3JjSnpab05tNllXVHNCK050TEFyOVhBeHJ5RnZr?=
 =?utf-8?B?d0ZudGZ3cUhDcGNoRDI0eHRCVGN5a3FSajZJeHl0bk56eXcvVE1IeVRLZmZm?=
 =?utf-8?B?amw2WHZsNC8rczI4bkY0WklWa2FVSXFNV0NuNDdVL1VKWVE1RUwvd2FjdE1K?=
 =?utf-8?B?ajZmd0YyZjRoM2t0bHBkMlJnT29QL3NzeXRkNzlEc0c3UC9LcGFFaUtVcUZK?=
 =?utf-8?B?L3RDeDVhdnMyOUFOaVlmNE4zUmVPUnk4aEdSeks2MmhKdXBNbzZIeTlsRm52?=
 =?utf-8?B?QTVHSDdUdlJpSGlqdHc1K2FXbVRKdkV2eWJidU1pV0tyWEQzZWpmbUpBc2lD?=
 =?utf-8?B?SDFZS1FUSFYyZWJsR1BCa3JtaTN3a1Q1dlhXY0p2U3Y4R0p3L3M1MmRxcDVW?=
 =?utf-8?B?SmE1K01PblVEV3R3K0hzM2haZ2NOYTBYS1A2b0tmbXBqVUtuaDVTZlN4cmIx?=
 =?utf-8?B?N0Zabml2SlZ6Y3hwUUVPRmlTaVpIbTBkT2ptbHNITHZvTEpoWnVHKzNvVmQx?=
 =?utf-8?B?QnRIUmtvUVR2S1grbjU0S3MvQ2FhaDZOTE5FaFlJd3J1ZEY0cERKa3NtR3Nm?=
 =?utf-8?B?WEt3cFZCWHJabXpDTlpZZ0tsT04yb3owckdRVTlmbENJNzdCNVViVFR6S2VM?=
 =?utf-8?B?TEN1OG53OTZnUDdTRXlBVjFTVmhGam5oUm5aRkZOS3FWbGNxbjg2MjF2Nndo?=
 =?utf-8?B?UFlQajR1RjZtMlhtYmFraTUwdDlkc21LSWg0M0pVVWRaaC80cnRNVk5wT3I1?=
 =?utf-8?B?Mjh4WG44V0NIK0toRTZMNVlIYXZVZ01NWGFXWEZmSm1VSisvTlg2UGtIZlA5?=
 =?utf-8?Q?86hHbxxmbrrccBzA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a132c1e-9f1c-4960-d216-08da171b8d78
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 15:47:13.2657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FI5uzYNZsCc0hfoY0mYyzoIOlzAkBxcIdOFRnDcT8TMYQEM2qKOK5pUIxJZN9WPG+rP0rjShcHw/K3WKvt/Wrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6582
X-OriginatorOrg: citrix.com

On Tue, Apr 05, 2022 at 04:36:53PM +0200, Jan Beulich wrote:
> On 05.04.2022 12:27, Roger Pau Monné wrote:
> > On Thu, Mar 31, 2022 at 11:45:36AM +0200, Jan Beulich wrote:
> >> --- a/xen/arch/x86/efi/efi-boot.h
> >> +++ b/xen/arch/x86/efi/efi-boot.h
> >> @@ -568,6 +568,49 @@ static void __init efi_arch_video_init(E
> >>  #endif
> >>  }
> >>  
> >> +#ifdef CONFIG_VIDEO
> >> +static bool __init copy_edid(const void *buf, unsigned int size)
> >> +{
> >> +    /*
> >> +     * Be conservative - for both undersized and oversized blobs it is unclear
> >> +     * what to actually do with them. The more that unlike the VESA BIOS
> >> +     * interface we also have no associated "capabilities" value (which might
> >> +     * carry a hint as to possible interpretation).
> >> +     */
> >> +    if ( size != ARRAY_SIZE(boot_edid_info) )
> >> +        return false;
> >> +
> >> +    memcpy(boot_edid_info, buf, size);
> >> +    boot_edid_caps = 0;
> >> +
> >> +    return true;
> >> +}
> >> +#endif
> >> +
> >> +static void __init efi_arch_edid(EFI_HANDLE gop_handle)
> >> +{
> >> +#ifdef CONFIG_VIDEO
> >> +    static EFI_GUID __initdata active_guid = EFI_EDID_ACTIVE_PROTOCOL_GUID;
> >> +    static EFI_GUID __initdata discovered_guid = EFI_EDID_DISCOVERED_PROTOCOL_GUID;
> > 
> > Is there a need to make those static?
> > 
> > I think this function is either called from efi_start or
> > efi_multiboot, but there aren't multiple calls to it? (also both
> > parameters are IN only, so not to be changed by the EFI method?
> > 
> > I have the feeling setting them to static is done because they can't
> > be set to const?
> 
> Even if they could be const, they ought to also be static. They don't
> strictly need to be, but without "static" code will be generated to
> populate the on-stack variables; quite possibly the compiler would
> even allocate an unnamed static variable and memcpy() from there onto
> the stack.

I thought that making those const (and then annotate with __initconst)
would already have the same effect as having it static, as there will
be no memcpy in that case either.

> >> +    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
> >> +    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
> >> +    EFI_STATUS status;
> >> +
> >> +    status = efi_bs->OpenProtocol(gop_handle, &active_guid,
> >> +                                  (void **)&active_edid, efi_ih, NULL,
> >> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> >> +    if ( status == EFI_SUCCESS &&
> >> +         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
> >> +        return;
> > 
> > Isn't it enough to just call EFI_EDID_ACTIVE_PROTOCOL_GUID?
> > 
> > From my reading of the UEFI spec this will either return
> > EFI_EDID_OVERRIDE_PROTOCOL_GUID or EFI_EDID_DISCOVERED_PROTOCOL_GUID.
> > If EFI_EDID_OVERRIDE_PROTOCOL is set it must be used, and hence
> > falling back to EFI_EDID_DISCOVERED_PROTOCOL_GUID if
> > EFI_EDID_ACTIVE_PROTOCOL_GUID cannot be parsed would likely mean
> > ignoring EFI_EDID_OVERRIDE_PROTOCOL?
> 
> That's the theory. As per one of the post-commit-message remarks I had
> looked at what GrUB does, and I decided to follow its behavior in this
> regard, assuming they do what they do to work around quirks. As said
> in the remark, I didn't want to go as far as also cloning their use of
> the undocumented (afaik) "agp-internal-edid" variable.

Could you add this as a comment here? So it's not lost on commit as
being just a post-commit log remark. With that:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 16:24:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 16:24:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299212.509730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nblyt-00039L-SC; Tue, 05 Apr 2022 16:24:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299212.509730; Tue, 05 Apr 2022 16:24:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nblyt-00039E-Nz; Tue, 05 Apr 2022 16:24:35 +0000
Received: by outflank-mailman (input) for mailman id 299212;
 Tue, 05 Apr 2022 16:24:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AE9i=UP=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nblyr-000398-OH
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 16:24:33 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df8cbe73-b4fc-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 18:24:32 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 5A95A5C012B;
 Tue,  5 Apr 2022 12:24:31 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Tue, 05 Apr 2022 12:24:31 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 5 Apr 2022 12:24:30 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df8cbe73-b4fc-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=yAcmsz2yWk9FuhEPI
	uoEqnL5whJEgeRmlp0ZgN3Xy94=; b=aGgpcVvJKsUizAhL57akxTzQSAyg/yfsK
	wKhbfPzbtGuKiVMKutmDi+yoAWDo73Ut3cb0Q9yIKaybRy5WYG+bnm3MuDIIm8J7
	usgxAAJF3hoorjwjv+0cFGnMl6DHVsX3Qk3zQKK3tU4JZRW1Lj3e/CdXHMl3mkau
	24rRNF4d3ZAlGarEoW7RYNNSP7L4+fbcGRrgjlCcIFlgfX8axtdH1g3OUJ6UuFfq
	7gpkfnFYif1wYWJSwvTnTdQrVZ98Hs40R8kZtG6CLw2spY3xhzkXTx3nMD/7s/Xf
	HoLKErr2aD/wWssHvhvJbh2/l4dO1kpAfH8y/jvrVF6gNN6mz9uxg==
X-ME-Sender: <xms:P21MYuTkDgVIK-EURPa7XfzD4zw8R_ezI0cTC1GQOU2BeRs_UkAzAw>
    <xme:P21MYjxpIotcqhpkq34l_FHFzEwPSUbs2EXODjT7GDTrCUI5odQZb8tiOf3OCmNQJ
    Wj5AzaWh8dfXA>
X-ME-Received: <xmr:P21MYr0O4yrhtgDsK6iXA45GYZyUYjgY6C1c9OraAhH2WCNPFMMVvvGdfFWK_PYDABn8KWZye5sw1JNHaO52ThehfxIgS06cPQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejgedgleejucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:P21MYqCACgOLMwYK-rrStXDMI_50t-lMogVrOPKRQ-3BgV84x0R4iw>
    <xmx:P21MYnhIzEpT-BFagczzlemtSnTHUCYyxre5CBv9fTuOpQeIVnHKCg>
    <xmx:P21MYmpHncHQxhfGJQFQ3hoYEIBD8TVadNt0l386WxwiODBbtGqaSw>
    <xmx:P21MYpcHPDj8ArB7UaUHQbmhWQAMdb-sfU3Crp7keRxpyB6m4QikKA>
Date: Tue, 5 Apr 2022 18:24:27 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Increasing domain memory beyond initial maxmem
Message-ID: <YkxtOxOCY8nxy0Gt@mail-itl>
References: <YkUlLvnEDdc5hwN4@mail-itl>
 <2684376b-3ae6-a2b7-581f-2bd38ab6056b@suse.com>
 <YkWYGFJ/Cl+B2C37@mail-itl>
 <362b6115-e296-e01e-520f-31a0826426eb@suse.com>
 <YkWgQNKK7SarjKDN@mail-itl>
 <a9325c01-f6bd-46e8-d730-3f18b71b9969@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="BsNsRvDM3yT93dYZ"
Content-Disposition: inline
In-Reply-To: <a9325c01-f6bd-46e8-d730-3f18b71b9969@suse.com>


--BsNsRvDM3yT93dYZ
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 5 Apr 2022 18:24:27 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Increasing domain memory beyond initial maxmem

On Tue, Apr 05, 2022 at 01:03:57PM +0200, Juergen Gross wrote:
> Hi Marek,
>=20
> On 31.03.22 14:36, Marek Marczykowski-G=C3=B3recki wrote:
> > On Thu, Mar 31, 2022 at 02:22:03PM +0200, Juergen Gross wrote:
> > > Maybe some kernel config differences, or other udev rules (memory onl=
ining
> > > is done via udev in my guest)?
> > >=20
> > > I'm seeing:
> > >=20
> > > # zgrep MEMORY_HOTPLUG /proc/config.gz
> > > CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=3Dy
> > > CONFIG_MEMORY_HOTPLUG=3Dy
> > > # CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE is not set
> > > CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=3Dy
> > > CONFIG_XEN_MEMORY_HOTPLUG_LIMIT=3D512
> >=20
> > I have:
> > # zgrep MEMORY_HOTPLUG /proc/config.gz
> > CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=3Dy
> > CONFIG_MEMORY_HOTPLUG=3Dy
> > CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=3Dy
> > CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=3Dy
> > CONFIG_XEN_MEMORY_HOTPLUG_LIMIT=3D512
> >=20
> > Not sure if relevant, but I also have:
> > CONFIG_XEN_UNPOPULATED_ALLOC=3Dy
> >=20
> > on top of that, I have a similar udev rule too:
> >=20
> > SUBSYSTEM=3D=3D"memory", ACTION=3D=3D"add", ATTR{state}=3D=3D"offline",=
 ATTR{state}=3D"online"
> >=20
> > But I don't think they are conflicting.
> >=20
> > > What type of guest are you using? Mine was a PVH guest.
> >=20
> > PVH here too.
>=20
> Would you like to try the attached patch? It seemed to work for me.

Unfortunately it doesn't help, now the behavior is different:

Initially guest started with 800M:

    [root@personal ~]# free -m
                  total        used        free      shared  buff/cache   a=
vailable
    Mem:            740         223         272           2         243    =
     401
    Swap:          1023           0        1023

Then increased:

    [root@dom0 ~]$ xl mem-max personal 2048
    [root@dom0 ~]$ xenstore-write /local/domain/$(xl domid personal)/memory=
/static-max $((2048*1024))
    [root@dom0 ~]$ xl mem-set personal 2000

And guest shows now only a little more memory, but not full 2000M:

    [root@personal ~]# [   37.657046] xen:balloon: Populating new zone
    [   37.658206] Fallback order for Node 0: 0=20
    [   37.658219] Built 1 zonelists, mobility grouping on.  Total pages: 1=
75889
    [   37.658233] Policy zone: Normal

    [root@personal ~]#=20
    [root@personal ~]# free -m
                  total        used        free      shared  buff/cache   a=
vailable
    Mem:            826         245         337           2         244    =
     462
    Swap:          1023           0        1023


I've applied the patch on top of 5.16.18. If you think 5.17 would make a
difference, I can try that too.


--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--BsNsRvDM3yT93dYZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmJMbTsACgkQ24/THMrX
1yxiHQf9FmmIf90+d5o+tImIdROhgp1rah+u3l/dgD4YZMT0qU+mzBSgcm2Wkqou
rM6FwhhoaPN7kBbNBlwrYRS50OO7lEE//S9uinQZw6Fqp5hWOyMNGjbN3hFqd1qe
FiN8accuLlAoKzAGlkoiFD4WMuQfVwxDAH08F7NDXMEeoO0Fm/5T2gaCVT81DAbv
JaLGeBZ09TAyZAPLrxdCmLUZXDh4xsXREi8cQ32U0ZBSM/r1PMEZ5SNz3tYaswK+
DOMHEEbfSpZUEnqLqah+bLBOp3KM38CIoGNPRZ+IT+oYKb01dnSgHHXLfUnTYi8t
AdmI2t8bSKhzokOKhD1htdA+b3fqPQ==
=jmLo
-----END PGP SIGNATURE-----

--BsNsRvDM3yT93dYZ--


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 16:31:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 16:31:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299216.509741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbm5u-0004dt-KY; Tue, 05 Apr 2022 16:31:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299216.509741; Tue, 05 Apr 2022 16:31:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbm5u-0004dm-Gx; Tue, 05 Apr 2022 16:31:50 +0000
Received: by outflank-mailman (input) for mailman id 299216;
 Tue, 05 Apr 2022 16:31:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbm5t-0004dc-Ut; Tue, 05 Apr 2022 16:31:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbm5t-0005Jx-Qe; Tue, 05 Apr 2022 16:31:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbm5t-0004ed-KR; Tue, 05 Apr 2022 16:31:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbm5t-0004pL-IU; Tue, 05 Apr 2022 16:31:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=C3tr1uX2NqTb34iK57yJXSdb4Bt5ElBPMYEHSpreslY=; b=uJw/eaN+/+Gt/VPrQ3mNZ9zDWy
	XTqGowiEW48aE1z/nAvMsY6LsALhM36j+iDlQTmPi2Yx26Q/6spcp/QChOzFKCdK5wq/uRKRl+5us
	D9yVav/YDVQwYGjTVlkCIp+sfAaCXnZwzDIwYN+E3J09P08kH3nrqh/NUhTl2xNKsxPo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169171-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169171: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=5d0eeb8cd7088e575c0a2b1d5759ccfb72c525c9
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 16:31:49 +0000

flight 169171 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169171/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              5d0eeb8cd7088e575c0a2b1d5759ccfb72c525c9
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  634 days
Failing since        151818  2020-07-11 04:18:52 Z  633 days  615 attempts
Testing same since   169171  2022-04-05 04:21:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 103410 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 17:18:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 17:18:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299226.509752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbmof-0000gP-Tj; Tue, 05 Apr 2022 17:18:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299226.509752; Tue, 05 Apr 2022 17:18:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbmof-0000gI-Qk; Tue, 05 Apr 2022 17:18:05 +0000
Received: by outflank-mailman (input) for mailman id 299226;
 Tue, 05 Apr 2022 17:18:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HhHa=UP=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nbmof-0000gC-Bx
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 17:18:05 +0000
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com
 [2a00:1450:4864:20::22b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59fdb57a-b504-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 19:18:04 +0200 (CEST)
Received: by mail-lj1-x22b.google.com with SMTP id s13so17995711ljd.5
 for <xen-devel@lists.xenproject.org>; Tue, 05 Apr 2022 10:18:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59fdb57a-b504-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=AXL8laU3wEEAbI++BDjPXXUxx4StltF6wiWvXLxExwU=;
        b=Us8z6T1S49RNit1Uf/8+cmNXlYlk4Sjx/3u7AXKSTefSqkpGg6FQOVzOW/YhL2PfDy
         CdVc5/nG4uzZ1lxw0LX073xVrwiyVEtOPWWvgIXrf/NPuLW0kK4TmvhAjuIig87O6T9O
         4ZV4SYRPLbO6m0nXu9G9hki5jTXymXuEIxpTGnWvyR+z9xVMNn2Tg+VVykVd/YiRnQoz
         EhY3ooyNqN2Ou36/SDgrzdJ1rcy5U1yGXzdcGMR/5uBuMW/gRsqDBQHeRD4GaGGbW4C4
         2bxpr+lhdUJTChDQZDRomR99M+Y5SBShybArQPnODIo2aSQZcqdb5h1iLJ23YMiDF5wk
         n+bg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=AXL8laU3wEEAbI++BDjPXXUxx4StltF6wiWvXLxExwU=;
        b=tCRubkMVhnnmPNutLXizXBeZViRRnhY0rkSAYg7dQcEtJ7wrQOjXhkiZroxSHol7Dc
         NMj3K0EVphL5PqXopPP1lvHIDr0K3pgzqo6yjOeV+KgwyEFFeKM3gDJ8LTJ8q72qs8Dx
         c6AqkhoPZnY2bESJXSpeU19Nxk6IytfvjyReOVciFcMEAUD2hMtDIyYoOsfBZxBQDHSV
         ghxSAJal35Z0AyfEaGbgPlRiMqLb2EPO7PbDTxYdtWsc1PcF6ES8yJXihf6zYY67VlGY
         BoZo4o4U0Ncah6zRGmdi85jXDZYPyWh+9rtD9YhOWayaubz95Q4p3zxYPAHQFqRx20Y9
         JzDg==
X-Gm-Message-State: AOAM530fXEWeHkR8iLd53OqLraKiAp5XTxTa1Cm+vwGejx4pLfW9nUD7
	kNTtAR/8zSpnvS5OLg68ymfpwQGdNgZRNsoaqNQ=
X-Google-Smtp-Source: ABdhPJwRS0J2esXlO91msD8EhKYTRHPYZN4xW/DpMI/by6eVWW6ILYsUcGLR0BYJG6UQE/U53jqSt066QCFSu5WS18w=
X-Received: by 2002:a2e:b0c9:0:b0:24a:fb55:8661 with SMTP id
 g9-20020a2eb0c9000000b0024afb558661mr2878467ljl.168.1649179083076; Tue, 05
 Apr 2022 10:18:03 -0700 (PDT)
MIME-Version: 1.0
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com> <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
In-Reply-To: <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Tue, 5 Apr 2022 13:17:51 -0400
Message-ID: <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Scott Davis <scott.davis@starlab.io>, 
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Content-Type: text/plain; charset="UTF-8"

On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith
<dpsmith@apertussolutions.com> wrote:
>
> On 3/31/22 09:16, Jason Andryuk wrote:
> > On Wed, Mar 30, 2022 at 3:05 PM Daniel P. Smith
> > <dpsmith@apertussolutions.com> wrote:
> >>
> >> There are now instances where internal hypervisor logic needs to make resource
> >> allocation calls that are protected by XSM checks. The internal hypervisor logic
> >> is represented a number of system domains which by designed are represented by
> >> non-privileged struct domain instances. To enable these logic blocks to
> >> function correctly but in a controlled manner, this commit introduces a pair
> >> of privilege escalation and demotion functions that will make a system domain
> >> privileged and then remove that privilege.
> >>
> >> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> >> ---
> >>  xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
> >>  1 file changed, 22 insertions(+)
> >>
> >> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> >> index e22d6160b5..157e57151e 100644
> >> --- a/xen/include/xsm/xsm.h
> >> +++ b/xen/include/xsm/xsm.h
> >> @@ -189,6 +189,28 @@ struct xsm_operations {
> >>  #endif
> >>  };
> >>
> >> +static always_inline int xsm_elevate_priv(struct domain *d)
> >> +{
> >> +    if ( is_system_domain(d) )
> >> +    {
> >> +        d->is_privileged = true;
> >> +        return 0;
> >> +    }
> >> +
> >> +    return -EPERM;
> >> +}
> >
> > These look sufficient for the default policy, but they don't seem
> > sufficient for Flask.  I think you need to create a new XSM hook.  For
> > Flask, you would want the demote hook to transition xen_boot_t ->
> > xen_t.  That would start xen_boot_t with privileges that are dropped
> > in a one-way transition.  Does that require all policies to then have
> > xen_boot_t and xen_t?  I guess it does unless the hook code has some
> > logic to skip the transition.
>
> I am still thinking this through but my initial concern for Flask is
> that I don't think we want dedicated domain transitions directly in
> code. My current thinking would be to use a Kconfig to use xen_boot_t
> type as the initial sid for the idle domain which would then require the
> default policy to include an allowed transition from xen_boot_t to
> xen_t. Then rely upon a boot domain to issue an xsm_op to do a relabel
> transition for the idle domain with an assertion that the idle domain is
> no longer labeled with its initial sid before Xen transitions its state
> to SYS_STATE_active. The one wrinkle to this is whether I will be able
> to schedule the boot domain before allowing Xen to transition into
> SYS_STATE_active.

That is an interesting approach.  While it would work, I find it
unusual that a domain would relabel Xen.  I think Xen should be
responsible for itself and not rely on a domain for this operation.

> > For the default policy, you could start by creating the system domains
> > as privileged and just have a single hook to drop privs.  Then you
> > don't have to worry about the "elevate" hook existing.  The patch 2
> > asserts could instead become the location of xsm_drop_privs calls to
> > have a clear demarcation point.  That expands the window with
> > privileges though.  It's a little simpler, but maybe you don't want
> > that.  However, it seems like you can only depriv once for the Flask
> > case since you want it to be one-way.
>
> This does simplify the solution and since today we cannot differentiate
> between hypervisor setup and hypervisor initiated domain construction
> contexts, it does not run counter to what I have proposed. As for flask,
> again I do not believe codifying a domain transition bound to a new XSM
> op is the appropriate approach.

This hard coded domain transition does feel a little weird.  But it
seems like a natural consequence of trying to use Flask to
deprivilege.  I guess the transition could be behind a
dom0less/hyperlaunch Kconfig option.  I just don't see a way around it
in some fashion with Flask enforcing.

Another idea: Flask could start in permissive and only transition to
enforcing at the deprivilege point.  Kinda gross, but it works without
needing a transition.

To reiterate, XSM isn't really appropriate to enforce anything
internal to Xen.  We are working around the need to go through hook
points during correct operation.  Code exec in Xen means all bets are
off.  Memory writes to Xen data mean the XSM checks can be disabled
(flip Flask to permissive) or bypassed (set d->is_privileged or change
d->ssid).  We shouldn't lose sight of this when we talk about
deprivileging the idle domain.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 17:26:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 17:26:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299231.509762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbmww-0002FB-UQ; Tue, 05 Apr 2022 17:26:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299231.509762; Tue, 05 Apr 2022 17:26:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbmww-0002F4-Qd; Tue, 05 Apr 2022 17:26:38 +0000
Received: by outflank-mailman (input) for mailman id 299231;
 Tue, 05 Apr 2022 17:26:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbmwv-0002Eu-Kq; Tue, 05 Apr 2022 17:26:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbmwv-0006Ee-EY; Tue, 05 Apr 2022 17:26:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbmwv-00071N-3a; Tue, 05 Apr 2022 17:26:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbmwv-0004Xo-2j; Tue, 05 Apr 2022 17:26:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RTcou0VuEEAez4Cwyi5GqG7pKQth0Cvszh66GXslaCQ=; b=mh7E/zzhwBZVoyg6Hqnq24j3h/
	CzUFVkVtoaFHRuTTxGV6Ow79mUeF5CqV8Ny1Hx6c7lQKE6rn0ZWQ5zwVSS1L/B6MmNjl+Ns1bdjZy
	NKatMUfIbo80M+Le3u4uOnxd28lBVCzpP3LmytQ9POoksX3+U5Q25Ey6wA4hklpshaLQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169177-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169177: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=a298a84478053872ed9da660a75f182ce81b8ddc
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 17:26:37 +0000

flight 169177 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169177/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 a298a84478053872ed9da660a75f182ce81b8ddc
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   36 days
Failing since        168258  2022-03-01 01:55:31 Z   35 days  280 attempts
Testing same since   169173  2022-04-05 05:13:00 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4610 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 18:01:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 18:01:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299239.509774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbnUo-0006Y4-Kp; Tue, 05 Apr 2022 18:01:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299239.509774; Tue, 05 Apr 2022 18:01:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbnUo-0006Xx-Ho; Tue, 05 Apr 2022 18:01:38 +0000
Received: by outflank-mailman (input) for mailman id 299239;
 Tue, 05 Apr 2022 18:01:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbnUm-0006Xn-Sb; Tue, 05 Apr 2022 18:01:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbnUm-0006to-RO; Tue, 05 Apr 2022 18:01:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbnUm-0000jC-Dp; Tue, 05 Apr 2022 18:01:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbnUm-0007lL-B9; Tue, 05 Apr 2022 18:01:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DkwEdD3k4uQKRg3YQmh4LlCHOrARRlcBALnGJ1V+pLQ=; b=faagLn116x3tkUTh4r9ihEuIcw
	AjlQTR1u7OmEjj+C8JfbUCzBdFu434LrhwTsIgmM7gF3nHLrTbfschYINf+TQRp1IC7BdQEzFp10z
	wjluVpFvXbiMTXv9ACtimY+IjYKom83YY4czC7gFYlqwkZY543hRuj7A0w9qyrJZpMPw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169183-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169183: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=14dd241aad8af447680ac73e8579990e2c09c1e7
X-Osstest-Versions-That:
    xen=120e26c2bb0097a589d718b1b58d7052ccce4458
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 18:01:36 +0000

flight 169183 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169183/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  14dd241aad8af447680ac73e8579990e2c09c1e7
baseline version:
 xen                  120e26c2bb0097a589d718b1b58d7052ccce4458

Last test of basis   169175  2022-04-05 10:01:52 Z    0 days
Testing same since   169183  2022-04-05 14:01:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   120e26c2bb..14dd241aad  14dd241aad8af447680ac73e8579990e2c09c1e7 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 19:06:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 19:06:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299248.509785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nboUs-0004It-Jy; Tue, 05 Apr 2022 19:05:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299248.509785; Tue, 05 Apr 2022 19:05:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nboUs-0004Im-Ee; Tue, 05 Apr 2022 19:05:46 +0000
Received: by outflank-mailman (input) for mailman id 299248;
 Tue, 05 Apr 2022 19:05:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FxJD=UP=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nboUq-0004Ig-13
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 19:05:44 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 622dda24-b513-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 21:05:41 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1649185534824477.55970434746814;
 Tue, 5 Apr 2022 12:05:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 622dda24-b513-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1649185537; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=GS7QuAwmBjT/oam7Say+Itw4rL08uaWEi7WJpBdfPsBFF698RsDaLg+YS6pDwQ/LIuz+NL71gxqLdz7y5Hxpz1CKPZErDqjEsJ/PnHo7nVr76RUtLVefYa7W6WgnNWDohit4TWqR4uDaTsz5oQu6KAE9GL8dpP20Vyb/sVB1DjY=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1649185537; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=h0Bu3q2il3h4w2l6bVulQEvszTw4APO06U4gQ4mjIYQ=; 
	b=O3RMWfoLQQPB+KxNdbo8Se97SXgHP3H8KkCG0AI+qrYBje9zG58yCVDwN+iifjiRBYHt7xZCbVxL6eRXQXF5NC1D4CZgI54f2xfBpWg4FPHkvEwaxMe5xBN7yIFXma68w6TlZ3xvKZwFbQfa0XeogrjHi+zWIOEM6A0bxy0vWTU=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649185537;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=h0Bu3q2il3h4w2l6bVulQEvszTw4APO06U4gQ4mjIYQ=;
	b=curDslOLouPb9RkMICDiZBA8PmKh2RCrY9UypM4F4dlHMMgj0umck+4v3wu02rza
	jFl1IdSXEpatMNvsio32+ubJK8EWmjJAtLOZbUHpU3elwkcOOkCG1ygus0yMFr6a41l
	xTm+nGHeypW09LEfjJqEYEhfNZ4h+qZ7rh28+lRs=
Message-ID: <9ba16d0b-6b31-0ca1-08b2-abe35f608a20@apertussolutions.com>
Date: Tue, 5 Apr 2022 15:05:09 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Scott Davis <scott.davis@starlab.io>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
 <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
In-Reply-To: <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/5/22 13:17, Jason Andryuk wrote:
> On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith
> <dpsmith@apertussolutions.com> wrote:
>>
>> On 3/31/22 09:16, Jason Andryuk wrote:
>>> On Wed, Mar 30, 2022 at 3:05 PM Daniel P. Smith
>>> <dpsmith@apertussolutions.com> wrote:
>>>>
>>>> There are now instances where internal hypervisor logic needs to make resource
>>>> allocation calls that are protected by XSM checks. The internal hypervisor logic
>>>> is represented a number of system domains which by designed are represented by
>>>> non-privileged struct domain instances. To enable these logic blocks to
>>>> function correctly but in a controlled manner, this commit introduces a pair
>>>> of privilege escalation and demotion functions that will make a system domain
>>>> privileged and then remove that privilege.
>>>>
>>>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>>>> ---
>>>>  xen/include/xsm/xsm.h | 22 ++++++++++++++++++++++
>>>>  1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>>>> index e22d6160b5..157e57151e 100644
>>>> --- a/xen/include/xsm/xsm.h
>>>> +++ b/xen/include/xsm/xsm.h
>>>> @@ -189,6 +189,28 @@ struct xsm_operations {
>>>>  #endif
>>>>  };
>>>>
>>>> +static always_inline int xsm_elevate_priv(struct domain *d)
>>>> +{
>>>> +    if ( is_system_domain(d) )
>>>> +    {
>>>> +        d->is_privileged = true;
>>>> +        return 0;
>>>> +    }
>>>> +
>>>> +    return -EPERM;
>>>> +}
>>>
>>> These look sufficient for the default policy, but they don't seem
>>> sufficient for Flask.  I think you need to create a new XSM hook.  For
>>> Flask, you would want the demote hook to transition xen_boot_t ->
>>> xen_t.  That would start xen_boot_t with privileges that are dropped
>>> in a one-way transition.  Does that require all policies to then have
>>> xen_boot_t and xen_t?  I guess it does unless the hook code has some
>>> logic to skip the transition.
>>
>> I am still thinking this through but my initial concern for Flask is
>> that I don't think we want dedicated domain transitions directly in
>> code. My current thinking would be to use a Kconfig to use xen_boot_t
>> type as the initial sid for the idle domain which would then require the
>> default policy to include an allowed transition from xen_boot_t to
>> xen_t. Then rely upon a boot domain to issue an xsm_op to do a relabel
>> transition for the idle domain with an assertion that the idle domain is
>> no longer labeled with its initial sid before Xen transitions its state
>> to SYS_STATE_active. The one wrinkle to this is whether I will be able
>> to schedule the boot domain before allowing Xen to transition into
>> SYS_STATE_active.
> 
> That is an interesting approach.  While it would work, I find it
> unusual that a domain would relabel Xen.  I think Xen should be
> responsible for itself and not rely on a domain for this operation.

The boot domain is not a general domain as no domain can/should be
created with its domid or flask label post transition to
SYS_STATE_active. Its purpose was specifically meant to be a natural way
to push out complicated pre-execution domain configuration from having
to be in they hypervisor code. Therefore in a way it can be considered a
user provided de-privileged part of the hypervisor.

With that said, I just realized a flaw in the basis of my position. What
is the difference between codifying a check that the idle domain is not
the boot label versus codifying a transition from the boot label to the
running label? None really, both will require some knowledge that there
is a boot label and some running label. Combine with the fact that the
idle domain really shouldn't have any other label than xen_t. I will
work out how to incorporate the domain transition.

>>> For the default policy, you could start by creating the system domains
>>> as privileged and just have a single hook to drop privs.  Then you
>>> don't have to worry about the "elevate" hook existing.  The patch 2
>>> asserts could instead become the location of xsm_drop_privs calls to
>>> have a clear demarcation point.  That expands the window with
>>> privileges though.  It's a little simpler, but maybe you don't want
>>> that.  However, it seems like you can only depriv once for the Flask
>>> case since you want it to be one-way.
>>
>> This does simplify the solution and since today we cannot differentiate
>> between hypervisor setup and hypervisor initiated domain construction
>> contexts, it does not run counter to what I have proposed. As for flask,
>> again I do not believe codifying a domain transition bound to a new XSM
>> op is the appropriate approach.
> 
> This hard coded domain transition does feel a little weird.  But it
> seems like a natural consequence of trying to use Flask to
> deprivilege.  I guess the transition could be behind a
> dom0less/hyperlaunch Kconfig option.  I just don't see a way around it
> in some fashion with Flask enforcing.
> 
> Another idea: Flask could start in permissive and only transition to
> enforcing at the deprivilege point.  Kinda gross, but it works without
> needing a transition.
> 
> To reiterate, XSM isn't really appropriate to enforce anything
> internal to Xen.  We are working around the need to go through hook
> points during correct operation.  Code exec in Xen means all bets are
> off.  Memory writes to Xen data mean the XSM checks can be disabled
> (flip Flask to permissive) or bypassed (set d->is_privileged or change
> d->ssid).  We shouldn't lose sight of this when we talk about
> deprivileging the idle domain.

I would far prefer a transition than trying to reason about whether
flask should be in permissive or enforcing based on this state change in
combination of command line setting.

v/r
dps


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 19:21:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 19:21:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299252.509796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbokJ-0006h6-WC; Tue, 05 Apr 2022 19:21:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299252.509796; Tue, 05 Apr 2022 19:21:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbokJ-0006gz-SM; Tue, 05 Apr 2022 19:21:43 +0000
Received: by outflank-mailman (input) for mailman id 299252;
 Tue, 05 Apr 2022 19:21:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbokI-0006gt-QB
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 19:21:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f436e27-b515-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 21:21:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id AC768B81FA4;
 Tue,  5 Apr 2022 19:21:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D378EC385A0;
 Tue,  5 Apr 2022 19:21:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f436e27-b515-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649186499;
	bh=+BQlMhmNIxB5jfqt9yCYdR6Te72Gk+tVq/m/oJL0ALc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=KNDiTQNQQPGltZvPjliz0BE/K7r6fUiTjV/RsltQPNpQkEw+bZ2WTtGcU7eDodaIy
	 T17Aq9EPBnjl8PSmRIs0HNMBPkJO7Sim5CkrjjcziQFZKfaRm0/iDWlBFD82U0pLZm
	 ef+G6PKvh7q1wsaryDzRHeXLJFkxMS+mLCtjInQ/SutWG+zxxi/GbRDdJKeSo5d64h
	 fRLCSKUAzo2DyqlK2iHR/hGiOCem6lN+yAyrCdZUEiIlJHsKCG9Suqmof7MV2O8DKN
	 imKqzn8CpUUgjE3CK1AieDEPdT2lN6XL7BKTmwKzgKci6Me+r+H1H/hlzzcEM6omXb
	 Y3euxe6en5egg==
Date: Tue, 5 Apr 2022 12:21:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <Luca.Fancellu@arm.com>
cc: Demi Marie Obenour <demi@invisiblethingslab.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Wei Liu <wl@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] Grab the EFI System Resource Table and check it
In-Reply-To: <989D1F80-2CAA-4432-8780-E0104B28A634@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204051220520.2910984@ubuntu-linux-20-04-desktop>
References: <YkeHXFvgB3MwXnuR@itl-email> <989D1F80-2CAA-4432-8780-E0104B28A634@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-2059889231-1649186499=:2910984"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-2059889231-1649186499=:2910984
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 4 Apr 2022, Luca Fancellu wrote:
> > On 2 Apr 2022, at 00:14, Demi Marie Obenour <demi@invisiblethingslab.com> wrote:
> > 
> > The EFI System Resource Table (ESRT) is necessary for fwupd to identify
> > firmware updates to install.  According to the UEFI specification §23.4,
> > the table shall be stored in memory of type EfiBootServicesData.
> > Therefore, Xen must avoid reusing that memory for other purposes, so
> > that Linux can access the ESRT.  Additionally, Xen must mark the memory
> > as reserved, so that Linux knows accessing it is safe.
> > 
> > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/
> > for details.
> > 
> > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> 
> Hi,
> 
> I’ve tested the patch on an arm machine booting Xen+Dom0 through EFI, unfortunately
> I could not test the functionality.

I understand you couldn't test ESRT but did the basic Xen+Dom0 boot via
EFI on ARM work?
--8323329-2059889231-1649186499=:2910984--


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 19:42:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 19:42:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299256.509807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbp4g-0000mC-Lg; Tue, 05 Apr 2022 19:42:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299256.509807; Tue, 05 Apr 2022 19:42:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbp4g-0000m5-Ia; Tue, 05 Apr 2022 19:42:46 +0000
Received: by outflank-mailman (input) for mailman id 299256;
 Tue, 05 Apr 2022 19:42:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eUJf=UP=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nbp4f-0000lz-H3
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 19:42:45 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20612.outbound.protection.outlook.com
 [2a01:111:f400:7d00::612])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f1d395d-b518-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 21:42:43 +0200 (CEST)
Received: from AM5PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:206:1::28)
 by PR2PR08MB4825.eurprd08.prod.outlook.com (2603:10a6:101:27::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 19:42:33 +0000
Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:1:cafe::8b) by AM5PR04CA0015.outlook.office365.com
 (2603:10a6:206:1::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31 via Frontend
 Transport; Tue, 5 Apr 2022 19:42:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Tue, 5 Apr 2022 19:42:32 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Tue, 05 Apr 2022 19:42:31 +0000
Received: from 4f127f0ff89c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DF6DA651-7D15-4782-94A1-002F48C99F82.1; 
 Tue, 05 Apr 2022 19:42:25 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4f127f0ff89c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 05 Apr 2022 19:42:25 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by PAXPR08MB7106.eurprd08.prod.outlook.com (2603:10a6:102:204::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 19:42:17 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::a4a1:ded3:2013:b310%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 19:42:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f1d395d-b518-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ebm6VtDbjwvYZQXog6NpVotRSsTpdSEoA7ajvOxoidk=;
 b=7aLqH7trEgCCRYT9ub9yK4yQ9Mss3/+PP3xYgIpJADg0aAAv1cQfgb5jFrhg4fsO1wOibTBJCsEdxiFZsQzL7Jsn3gmnkHrJ/EvhKCS4Fs2aUvYnbH6KvqyqQGAe1FWq2aWvJ33kARBQ8RjiG5IY1Cu6gJNgaiLYdjZ6+kHMP9U=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 838c0a2e266dd0cd
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lp6Ny1qfewWNy37nSjifpLbLLToBOA03rEcXXVDBsqNFMckQA6WzY3DJE1oOJ4LoSEcZsjqCuTtNoCVa2/t8cQ0vCnPMFTZr2UCN5M0jmBe84VjutcHUlgoAn6Kk1XdlfCVLy8LCV4qJQAXt2f5SzGKUdj9ACGQRr1tl7bI5UhUD25RBJoqHhdafe0E3vYJsfKwoX6WCE7LUntvG2jHVWAlb/HtKOmqAgfQKLjpffqMIqXXbo/M9c6rZrVNMAEzFVa5SLZ+uM7JXhNgXDpjFFOCezQO0+Z9sTsOvuuh39osl9SC4iQ8rmFibgCNPgSyJ3CNCIz0ufUJgzwbRtjHuJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ebm6VtDbjwvYZQXog6NpVotRSsTpdSEoA7ajvOxoidk=;
 b=azz9E7O7pa+EQN+z44YhNxvYu9Qu/x1HBYf0dKub53gSCWw879uuE8esdcc4wMUb9GH/mfmhIHYAqoiXyaeO0jsb9wfdFVM1CDz4v9r55U3i5IbhqWRtoelpr/RpnMmslh+eBZMkcD26Kfpu25O5MIu3audv/QTsQNWVoyp+pEYkYFAx4TNeJ8qu06rmIwxluANoDOnDdEvRw//uDgw/6eloAhK+TxRtcKVVkeQHcNSFKk09r8F0yUcYa/Q5qHoYbACqwqYUuZCn+JZ69GmNwV4S4RMyCYPLJK+QR5ctIODMs8xieheln8/UGV6FXjUKBNAoB3rqCcpvv6HVRWNqxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ebm6VtDbjwvYZQXog6NpVotRSsTpdSEoA7ajvOxoidk=;
 b=7aLqH7trEgCCRYT9ub9yK4yQ9Mss3/+PP3xYgIpJADg0aAAv1cQfgb5jFrhg4fsO1wOibTBJCsEdxiFZsQzL7Jsn3gmnkHrJ/EvhKCS4Fs2aUvYnbH6KvqyqQGAe1FWq2aWvJ33kARBQ8RjiG5IY1Cu6gJNgaiLYdjZ6+kHMP9U=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Demi Marie Obenour <demi@invisiblethingslab.com>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] Grab the EFI System Resource Table and check it
Thread-Topic: [PATCH v2] Grab the EFI System Resource Table and check it
Thread-Index: AQHYRh5pIZEBfe5HzkWcQzrtRd3oyazfnIKAgAIb/wCAAAXCgA==
Date: Tue, 5 Apr 2022 19:42:16 +0000
Message-ID: <ADA1764C-C67F-41A8-9CD3-8C421188A5FE@arm.com>
References: <YkeHXFvgB3MwXnuR@itl-email>
 <989D1F80-2CAA-4432-8780-E0104B28A634@arm.com>
 <alpine.DEB.2.22.394.2204051220520.2910984@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204051220520.2910984@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: a56e6d4f-1479-4447-40ae-08da173c6d36
x-ms-traffictypediagnostic:
	PAXPR08MB7106:EE_|VE1EUR03FT046:EE_|PR2PR08MB4825:EE_
X-Microsoft-Antispam-PRVS:
	<PR2PR08MB48250C2659FE07B1AE0E0439E4E49@PR2PR08MB4825.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 iRTBHiIRHHzj7kcYM4L/eRWa0SykxoAbfLkLP7+qDqBsrDa3/om7qVr7mEqfkWnF/o1Qaz6rlosjtKZc1PN0hn5Mxixd7ZaJzL8vFJHcubdViqo/UkvlFks2hweIsqhF3eBvDvZXxZPrB1mWdO9RCrjTUI67roMtnS2YfethcM5tx0DxZ2FUIDlKyDx+N+MP3zJeRHW1IZo3My4uT0Z62jpvwdvfWfFfnCC1Uch+Rme5KwWpNZtE4XfM11WE9z5JCi5Dds3Hjd8+C2/bItehphSEIC2kdvmRKjWXnlV1fPNd6PpENC9BIY0yVriTG4vKwVBPIBtECbtvBLjOO/nZpHjjNgXEKFCS4S1TNgyNpzVTq+zC1MpviyKgwOgoOUVX3FYNZ/U61pBFBnbcpuXZU53XurOLhVKADG19Z/C6LAyhtV8/ffD+GhK9g2tOq6o6kVo0fX+OOFyXcBPhC/zjhyU9sUkaqzp705UcMfQZYkfoa/hCscxuuq1RZtjpkA2LOHZm0PYbAFi9pIaSsc+WHPkEFZYy+dp8oQuxI1Ew/ZmoG2XLm4s4qwDj517sNe8wAVmrRpwsw45AvaPWhLUKlWnzo//b3V3dreF6x11XyZ7AAzpOA4RcQZ62/pWnOibBJPDGV13MbcUjANyIk5Vnb3lR/UbxnkYdyUNjjNGqq9MQRX5+R8JfPPU6FUfaLNoPzYBfEHQjDAkhDJqaO1JVF01MeQ445wRw9U3h69MyMLW1ftUq0UjvD+q2pVxEqSlyESKa6bt2pzcgUzlyrTzcQzXtFP4Ql5Y8gEVA5Ac/ECup1aC8IciLWEt0CiygGKN3uSux87tHUH+DZkw9/F01cA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(71200400001)(8936002)(33656002)(36756003)(86362001)(5660300002)(38100700002)(64756008)(4326008)(66476007)(66446008)(66946007)(122000001)(38070700005)(2616005)(54906003)(91956017)(53546011)(6512007)(6506007)(76116006)(6916009)(508600001)(6486002)(966005)(83380400001)(26005)(186003)(66556008)(8676002)(316002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <9B68014681F6254198709803C10DAC95@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7106
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1902330b-f475-46e7-c8f6-08da173c6415
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ld/2khqUtg4oU3WkZrqPINE2YIsLrwcMW796WI27VUWYyC82GM360jGAmjwpVw8ADe24TRz+utFoyLrf+N0gCKzwOYuA6hXduJhfCI5SP2xE7YtMAr3yKOKMVrdlikRULc4eoBxGbbX4MHLf85tZrPyAe7Ywdub2U4ZX9GMH7cYIM6zESfCTIzRRou4/N7pxAij+QfNHDppmJ+Igajj6dgUCVfeQ+Q6Un4riQ/S+7M0poPCLYvmr+vtbC38lW6pt8d0PCdUrwSIiBzo5Ogovs4yHF1WsP0QdP+jH6rujz0D+4MVrHY+ZccZAQYXYn8C8iSzCgxC+Kg+WK/JUUoaO2Kwg8m3f80azQRtoV12sPZ6q0Z9bi/6tNB0QYf0MWoNMIYj6M0WErk1tvgzfsFA3wpGg4DYXjKYvT/4OL0Ofk/hmAkxtgzJpE1grN4htRx+pSHtV45BRA2en9fpGtnz9ak05p7CWB7hGUYt8jG2Pwhrzqoc1rP5NRrOHv9s+ZfZAEOcun7sHwaVbNwfWyYg3FPM0/HyozSQ3Q7OSIM2aAZlRa+G+xBZEX59YEi07L8DZyXCjKuJpMBZl5OyrUHgi0HJJeh9+ck70bj+86PnFkZc0wBRAD7HI6gJF/p1hffTGmE1aBzyUqPhd72SS+OdsHUkgN88mnS37wYuXeyc/O5b1XLaFcoA8hb2c38CVgUSQo+H1SVsBD2DaE/nxI6NjQM9Tva7N0oCD8jgNrUCZQnbLAlGlSomr+acKWtcD3MiXW0q8t384Nw56zDs9NeDnUQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(33656002)(53546011)(5660300002)(6512007)(83380400001)(36756003)(6506007)(356005)(81166007)(54906003)(2906002)(316002)(6862004)(508600001)(36860700001)(70586007)(70206006)(82310400005)(6486002)(966005)(8936002)(26005)(186003)(2616005)(47076005)(4326008)(40460700003)(86362001)(8676002)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 19:42:32.3001
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a56e6d4f-1479-4447-40ae-08da173c6d36
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4825

DQoNCj4gT24gNSBBcHIgMjAyMiwgYXQgMjA6MjEsIFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl
bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBPbiBNb24sIDQgQXByIDIwMjIsIEx1Y2Eg
RmFuY2VsbHUgd3JvdGU6DQo+Pj4gT24gMiBBcHIgMjAyMiwgYXQgMDA6MTQsIERlbWkgTWFyaWUg
T2Jlbm91ciA8ZGVtaUBpbnZpc2libGV0aGluZ3NsYWIuY29tPiB3cm90ZToNCj4+PiANCj4+PiBU
aGUgRUZJIFN5c3RlbSBSZXNvdXJjZSBUYWJsZSAoRVNSVCkgaXMgbmVjZXNzYXJ5IGZvciBmd3Vw
ZCB0byBpZGVudGlmeQ0KPj4+IGZpcm13YXJlIHVwZGF0ZXMgdG8gaW5zdGFsbC4gIEFjY29yZGlu
ZyB0byB0aGUgVUVGSSBzcGVjaWZpY2F0aW9uIMKnMjMuNCwNCj4+PiB0aGUgdGFibGUgc2hhbGwg
YmUgc3RvcmVkIGluIG1lbW9yeSBvZiB0eXBlIEVmaUJvb3RTZXJ2aWNlc0RhdGEuDQo+Pj4gVGhl
cmVmb3JlLCBYZW4gbXVzdCBhdm9pZCByZXVzaW5nIHRoYXQgbWVtb3J5IGZvciBvdGhlciBwdXJw
b3Nlcywgc28NCj4+PiB0aGF0IExpbnV4IGNhbiBhY2Nlc3MgdGhlIEVTUlQuICBBZGRpdGlvbmFs
bHksIFhlbiBtdXN0IG1hcmsgdGhlIG1lbW9yeQ0KPj4+IGFzIHJlc2VydmVkLCBzbyB0aGF0IExp
bnV4IGtub3dzIGFjY2Vzc2luZyBpdCBpcyBzYWZlLg0KPj4+IA0KPj4+IFNlZSBodHRwczovL2xv
cmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMDA4MTgxODQwMTguR04xNjc5QG1haWwtaXRsL1Qv
DQo+Pj4gZm9yIGRldGFpbHMuDQo+Pj4gDQo+Pj4gU2lnbmVkLW9mZi1ieTogRGVtaSBNYXJpZSBP
YmVub3VyIDxkZW1pQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQo+PiANCj4+IEhpLA0KPj4gDQo+
PiBJ4oCZdmUgdGVzdGVkIHRoZSBwYXRjaCBvbiBhbiBhcm0gbWFjaGluZSBib290aW5nIFhlbitE
b20wIHRocm91Z2ggRUZJLCB1bmZvcnR1bmF0ZWx5DQo+PiBJIGNvdWxkIG5vdCB0ZXN0IHRoZSBm
dW5jdGlvbmFsaXR5Lg0KPiANCj4gSSB1bmRlcnN0YW5kIHlvdSBjb3VsZG4ndCB0ZXN0IEVTUlQg
YnV0IGRpZCB0aGUgYmFzaWMgWGVuK0RvbTAgYm9vdCB2aWENCj4gRUZJIG9uIEFSTSB3b3JrPw0K
DQpZZXMsIEkgcmVhbGlzZSBub3cgSSBzaG91bGQgaGF2ZSBhZGRlZCAqYW5kIGl0IHdvcmtzKiBi
ZWZvcmUgdGhlIGNvbW1hLCB3aXRob3V0IGl0IHRoZSBzZW50ZW5jZSBpcw0KbWlzbGVhZGluZy4N
Cg0KQ2hlZXJzLA0KTHVjYQ==


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 19:55:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 19:55:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299261.509817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbpGr-0002N9-U1; Tue, 05 Apr 2022 19:55:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299261.509817; Tue, 05 Apr 2022 19:55:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbpGr-0002N2-Qn; Tue, 05 Apr 2022 19:55:21 +0000
Received: by outflank-mailman (input) for mailman id 299261;
 Tue, 05 Apr 2022 19:55:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MpfF=UP=bounce.vates.fr=bounce-md_30504962.624c9ea3.v1-a654de74875a4e838674855e9ef37c73@srs-se1.protection.inumbo.net>)
 id 1nbpGp-0002Mw-HR
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 19:55:20 +0000
Received: from mail145-18.atl61.mandrillapp.com
 (mail145-18.atl61.mandrillapp.com [198.2.145.18])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5052c54b-b51a-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 21:55:18 +0200 (CEST)
Received: from pmta06.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1])
 by mail145-18.atl61.mandrillapp.com (Mailchimp) with ESMTP id
 4KXyzl6bbFzB5p7P1
 for <xen-devel@lists.xenproject.org>; Tue,  5 Apr 2022 19:55:15 +0000 (GMT)
Received: from [37.26.189.201] by mandrillapp.com id
 a654de74875a4e838674855e9ef37c73; Tue, 05 Apr 2022 19:55:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5052c54b-b51a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr;
	s=mandrill; t=1649188515; x=1649490915; i=olivier.lambert@vates.fr;
	bh=PVk7/qyTDXCnO94lIpGO5So9zVjwkewrLJ1SlKhlLRM=;
	h=From:Subject:Message-Id:To:Cc:Feedback-ID:Date:MIME-Version:
	 Content-Type:CC:Date:Subject;
	b=gFkernG84f3iDo3K6/ojq1GpowzAnzvjFhNvFRIUe/etyQDO7Ve3fvi7lApjHHlDK
	 wOVbY//EP58mf0/U+zJrDpDmk6W0a98O3ef/CGvKewehsGjQX45vUhgzws0+IPnBkL
	 C0191zq/oCljXBB/o2hz4gTJz9r/wYGenXgxevEM=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; 
 i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1649188515; h=From : 
 Subject : Message-Id : To : Cc : Date : MIME-Version : Content-Type : 
 From : Subject : Date : X-Mandrill-User : List-Unsubscribe; 
 bh=PVk7/qyTDXCnO94lIpGO5So9zVjwkewrLJ1SlKhlLRM=; 
 b=Rs3a0HbWXLCS8CFvv+lREKyI/EkOuXmiBF3hUYGAgPK3EL7C7oscLYrc674ePIpXAFyLrf
 XJKT+q4/3JD7DLILPHvpxbZ9YkTImVp2l8CSxeftluKCNZU74ewnZfn9/xNakQCmlSAB1/+h
 iu/7oAhCZwOdSXveJ6iZN1fz+mMsw=
From: Olivier Lambert <olivier.lambert@vates.fr>
Subject: Design meeting for AMD SEV-SNP project
X-Bm-Draft-Refresh-Date: 1649188509743
X-Bm-Internal-Id: 51E2DD5C-2A80-4022-B0C6-3DE883716B7A#bluemind-4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2:705940
X-Bm-Previous-Body: 831722ad879006744612485dcf56e4740847ba50
X-Bm-Disclaimer: Yes
X-Bm-Milter-Handled: ccd00a1f-1643-428b-8802-f28a7c8bc680
X-Bm-Transport-Timestamp: 1649188510558
Message-Id: <l1miow10.1tgmtwcqqwtmo@vates.fr>
To: xen-devel@lists.xenproject.org
Cc: Andrei Semenov <andrei.semenov@vates.fr>, roger.pau@citrix.com, george.dunlap@citrix.com, dpsmith@apertussolutions.com, julien@xen.org, bertrand.marquis@arm.com, Marc Ungeschikts <marc.ungeschikts@vates.fr>
X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com
X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.a654de74875a4e838674855e9ef37c73
X-Mandrill-User: md_30504962
Feedback-ID: 30504962:30504962.20220405:md
Date: Tue, 05 Apr 2022 19:55:15 +0000
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="_av-XBRa86VBVCbaC2T3ZhM4kQ"

--_av-XBRa86VBVCbaC2T3ZhM4kQ
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hello everyone,


As announced during earlier community call, I'm posting here to announce our intention to bootstrap Xen support of AMD SEV-SNP technology. In very short, this hardware extension on AMD CPUs will allow to run encrypted memory in guests, except for explicitly permitted areas. The obvious example use case is running this technology in the Cloud, introducing an increased level of trust since even Xen or Dom0 couldn't read encrypted guests memory.


For reference, here is our current "base" document to discuss further: https://cryptpad.fr/pad/#/2/pad/view/ApLTDJLGLG0mzKGIwrL9M0UVft5nTBnVre7eVAbIk00/ [https://cryptpad.fr/pad/#/2/pad/view/ApLTDJLGLG0mzKGIwrL9M0UVft5nTBnVre7eVAbIk00/]


The first action that should be organized is a "design/discussion session" to clarify some choices and put things in motion with clear initial and achievable targets. It would be nice to meet relatively soon (ie: next week).


Here is a Doodle link we'll use to choose the best day to meet:

https://doodle.com/meeting/participate/id/dBBoPjkd


I selected on purpose an hour to get a suitable schedule for both US and EU based people: the same hour than the Xen community call, which is 3:00 PM UTC, 4:00 PM London time, 5:00 PM Paris time and finally 11:00 AM New-York time.


I will let the Doodle opened until the end of the week to let you know quickly here which day was selected.

Regarding the meeting location: https://meet.vates.fr/sev (Jitsi powered)


Let me know if you need any other information or if you have any question :)



Regards,







Olivier Lambert | Vates CEO
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com

--_av-XBRa86VBVCbaC2T3ZhM4kQ
Content-Type: multipart/related; boundary="_av-wq1_XHWQ9NprsO3qMKMJgg"

--_av-wq1_XHWQ9NprsO3qMKMJgg
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
 <head></head>
 <body>
  <div id="bm-composer-content-wrapper">
   <p style="margin-bottom: 0; margin-top: 0;">Hello everyone,</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">As announced during earlier community call, I'm posting here to announce our intention to bootstrap Xen support of AMD SEV-SNP technology. In very short, this hardware extension on AMD CPUs will allow to run encrypted memory in guests, except for explicitly permitted areas. The obvious example use case is running this technology in the Cloud, introducing an increased level of trust since even Xen or Dom0 couldn't read encrypted guests memory.</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">For reference, here is our current "base" document to discuss further: <a href="https://cryptpad.fr/pad/#/2/pad/view/ApLTDJLGLG0mzKGIwrL9M0UVft5nTBnVre7eVAbIk00/">https://cryptpad.fr/pad/#/2/pad/view/ApLTDJLGLG0mzKGIwrL9M0UVft5nTBnVre7eVAbIk00/</a></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">The first action that should be organized is a "design/discussion session" to clarify some choices and put things in motion with clear initial and achievable targets. It would be nice to meet relatively soon (ie: next week).</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Here is a Doodle link we'll use to choose the best day to meet:</p>
   <p style="margin-bottom: 0; margin-top: 0;"><a href="https://doodle.com/meeting/participate/id/dBBoPjkd">https://doodle.com/meeting/participate/id/dBBoPjkd</a></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">I selected on purpose an hour to get a suitable schedule for both US and EU based people: the same hour than the Xen community call, which is 3:00 PM UTC, 4:00 PM London time, 5:00 PM Paris time and finally 11:00 AM New-York time.</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">I will let the Doodle opened until the end of the week to let you know quickly here which day was selected.</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br>Regarding the meeting location: https://meet.vates.fr/sev (Jitsi powered)</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Let me know if you need any other information or if you have any question :)</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Regards,</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <style></style>
  </div>
  <div class="x-disclaimer995950824">
   <div>
     &nbsp;
   </div>
   <div>
     &nbsp;
   </div>
   <div>
    <div>
     <br>
     <table>
      <tbody>
       <tr>
        <td style="font-size: 10pt;">&nbsp;</td>
        <td style="font-size: 10pt; padding-left: 20px; border-left-color: #b42626; border-left-style: solid; border-left-width: 1px;">
         <div> <strong> <span>Olivier Lambert</span> | Vates CEO</strong>
          <br><strong>XCP-ng &amp; Xen Orchestra - </strong>Vates solutions
         </div>
         <div> <strong>w:</strong>&nbsp;vates.fr&nbsp;| xcp-ng.org | xen-orchestra.com
         </div>
         <div>
          <img style="width: 187px;" src="cid:x-disclaimer995950824-1649188510558.png@bm-disclaimer">
         </div> </td>
       </tr>
      </tbody>
     </table>
    </div>
   </div>
  </div>
 <img src="https://mandrillapp.com/track/open.php?u=30504962&id=a654de74875a4e838674855e9ef37c73" height="1" width="1"></body>
</html>

--_av-wq1_XHWQ9NprsO3qMKMJgg
Content-Type: image/png
Content-Transfer-Encoding: base64
Content-Id: <x-disclaimer995950824-1649188510558.png@bm-disclaimer>
Content-Disposition: inline

/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB
AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/
2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB
AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA
HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF
BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK
FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1
dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG
x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB
AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC
AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom
JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE
hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU
1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA
CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo
AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR
8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0
nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7
9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq
rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8
F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+
Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5
+GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS
b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL
iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m
J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/
4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B
axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8
Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W
0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+
7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4
S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM
fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN
iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+
JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL
QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3
aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8
M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm
sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e
Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/
j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/
hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f
Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL
hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8
HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI
/wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt
y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r
7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3
hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia
2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT
jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW
KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x
D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9
/p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP
DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx
XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT
6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A
BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F
tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt
X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI
re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb
9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv
F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ
pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88
KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf
izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM
77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8
e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7
i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4
ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4
P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD
4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4
ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01
8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet
R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq
/wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n
dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M
vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8
SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y
+NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67
SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW
krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI
Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n
/Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP
A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX
uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d
yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa
fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm
8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt
Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D
fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN
PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD
vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc
oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf
EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg
uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS
0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K
U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if
xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60
qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A
wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj
BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z
B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z
3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5
Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz
AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx
7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8
vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44
+IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v
+/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb
AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3
uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq
XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx
fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0
Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr
W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340
fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4
Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn
/BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G
o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38
KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/
jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2
mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr
HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm
3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh
h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U
YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD
adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun
RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF
43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt
4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7
G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH
ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP
2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju
FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94
uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr
IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+
J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21
OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3
/g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0
r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ
D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox
8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w
dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T
vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A
g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe
0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v
14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S
8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+
BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/
AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/
sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X
WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G
n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T
wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4
M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW
iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy
/wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr
S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd
+wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv
CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E
T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i
Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e
aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR
8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg
v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp
YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/
BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT
NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b
jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk
0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf
oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua
VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ
88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS
tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr
5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6
Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6
RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx
mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC
EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/
Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F
PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT
w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc
PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7
sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU
qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD
GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU
AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF
0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF
Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+
GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo
0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv
tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740
xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a
eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT
zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n
XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h
ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl
Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4
YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k
P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK
HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez
wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl
0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH
x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd
oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u
0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc
pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i
C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm
qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV
v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u
WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2
fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x
A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT
i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5
rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD
xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP
X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l
/q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6
WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL
EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw
fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB
p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin
JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU
62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF
AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7
694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY
vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k
Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv
jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH
XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el
OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/
BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L
+E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt
L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW
8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw
2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+
HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G
0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad
pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD
e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If
GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP
4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh
qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4
NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2
/wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0
1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI
8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+
Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy
3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy
2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8
RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW
SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp
ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv
FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv
ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz
B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe
NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74
meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r
Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR
oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl
kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0
nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ
JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO
nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI
pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT
lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K
Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un
jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q
jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J
wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV
cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1
W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs
8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY
PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx
mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay
NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i
gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N
ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX
rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0
H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p
1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj
MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy
OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx
/tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM
n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/
2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn
LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH
/wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd
5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun
XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ
uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9
6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf
C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c
yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A
qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM
SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr
8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV
lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL
/wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W
G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz
ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b
+GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w
9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B
ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k
mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS
qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf
XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815
60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr
xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl
nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft
RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3
s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE
jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690
H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM
NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj
7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs
ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1
ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4
nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG
4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD
3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A
HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd
anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ
hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj
TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm
IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS
P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh
6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q
Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8
T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj
G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw
mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr
xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v
VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC
61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+
ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR
OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5
TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf
8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v
wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh
Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM
2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44
YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3
KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e
PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx
Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf
gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg
AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu
PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+
WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G
/CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr
CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y
RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze
Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+
TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt
Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+
WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP
ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If
iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng
sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/
B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1
JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV
8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P
4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9
u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ
8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u
eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1
K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO
eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB
ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK
FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL
8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj
5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg
oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0
FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7
f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX
PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km
22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/
sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL
L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND
COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ
qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+
wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp
6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm
ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy
n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj
Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB
Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/
AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7
fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u
1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu
XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR
1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0
n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd
8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS
lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV
ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU
j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O
I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw
0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN
3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k
z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1
tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY
B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj
KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s
XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN
bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7
rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w
R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr
9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl
UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG
NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm
FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc
/tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy
zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+
ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U
3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl
gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE
ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt
WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi
Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9
bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl
ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR
pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh
2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z
NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo
3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp
utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj
Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB
ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST
gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N
PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0
7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0
cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa
jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA
CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV
5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV
xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq
5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx
A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl
B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/
FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I
7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC
m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/
4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli
x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP
tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8
PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K
3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6
nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs
1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA
FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej
7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm
eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+
D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi
lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf
Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs
6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z
1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP
2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r
T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp
q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M
XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3
HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7
u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT
ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP
rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf
i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh
a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O
pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp
08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj
XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG
MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q
ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2
R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+
P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i
xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax
vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF
Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk
Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP
82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb
LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA
CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo
AKACgD//2Q==

--_av-wq1_XHWQ9NprsO3qMKMJgg--

--_av-XBRa86VBVCbaC2T3ZhM4kQ--



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 20:08:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 20:08:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299266.509829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbpSz-000471-4v; Tue, 05 Apr 2022 20:07:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299266.509829; Tue, 05 Apr 2022 20:07:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbpSz-00046u-1m; Tue, 05 Apr 2022 20:07:53 +0000
Received: by outflank-mailman (input) for mailman id 299266;
 Tue, 05 Apr 2022 20:07:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q1sd=UP=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nbpSw-00046o-BP
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 20:07:51 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f5a376a-b51c-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 22:07:47 +0200 (CEST)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 235J403T000752; 
 Tue, 5 Apr 2022 20:06:58 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6e3sq1q3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 05 Apr 2022 20:06:58 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 235K6n1g024375; Tue, 5 Apr 2022 20:06:57 GMT
Received: from nam02-dm3-obe.outbound.protection.outlook.com
 (mail-dm3nam07lp2043.outbound.protection.outlook.com [104.47.56.43])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f6cx3wnmt-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 05 Apr 2022 20:06:57 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by CY4PR10MB1944.namprd10.prod.outlook.com (2603:10b6:903:124::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr
 2022 20:06:53 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%9]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022
 20:06:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f5a376a-b51c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=tpyGPUaQuiPurYeYs3+V7jjavwWbv5TwRE7ClxjB0Ic=;
 b=iRbvgUVVCKoA47KcSmFzqbMjBt0jgctio9aCZaWNRqj3MbmCjumA6oJsNlbn+8WGNBPq
 u1E7eEbzu6NEbg+ZnHtRCsCiDY1sVHD1OrCDyl0N220iZLPiwpn2mIQeibs1IjXdrzRm
 H8XdWxCk6NcTE7ku3FdVu6fyYlU1Cp3gNIEqa8Ckj7VxjQHzicobz1AZl/DuS/XqxvVh
 dfTlHj6nsp8zjWHj3PnfhX8WVq6pix0/hEU6BskaOEZmM2AkvbDMOOiTM0RE9qu7Qjrj
 TciysJOUYRJvsglnO0bOyVzUDjuSABxT8JRnqsj3V2XzOk/X4yVDDD6xPmdgBTzFHhwC Pg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EOKcn2DSgTC3axuoc+TpJfL6SESnqYVZ6yvwucBeIEwBDB9axAIOowFbrquNE95zsSxCNF2rEakEfgPe0VvueHifW8L+N2wgGvxkZHUik1LPQTgQdHRqRHaEmhsDHkqySVEp0/1YFyudrbAqHQOQOL+SagE8EejdzSwkRq/+fxxdVtHtA16n20C0Dcze0TlunSMMhzKUm6d3Yl/3WP9IMMgaIqmiadBj9mz2jbMcsM/j2mQJ9T6B7Wzb2k1CtbxcSYv1aBz5WFd9qoTetQp5UrlBFSt3j8NcFbv7F/Ll0j5ryKB61vcy7+g99CRivzruXOEIWZw/KnxD+YiTx95tXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tpyGPUaQuiPurYeYs3+V7jjavwWbv5TwRE7ClxjB0Ic=;
 b=jAQjplybF0o1/1+o+tI2OxakyvTgrkNh64/hC7MVv9LK62nkbsFWKad8kxSwHECXWtEhGgrqJlM11Ai2qjsrOpfSTEGDeS9aB0CPj+cFIVaRI8vXka1LMX+Bbl3Wojaxk2vEkiPZfY+BfmlnIVEdfoybzTTtepq6VpAn9jpncyJKkZ+r/PvuNY5AUbl4nBg28p4fGrtUgv1X2N6jcIBkHzuy8iw9GG44h8HBrdNZbb31/QDtLl1dYeqTQlg4dgmloMTOlgvoSeVn6puHv9AVmYB7wWqEQ+TWhmjts/3AlXWf4cS1qxkS1rb6WqqqJeyz2UvdGKVQs4zBARTaG4YQ6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tpyGPUaQuiPurYeYs3+V7jjavwWbv5TwRE7ClxjB0Ic=;
 b=m2Ae0RZwdw09NXr4y61452WcWEz6z9VXX45yPvQ/fBrjRBZnGaGBMBMjqX8E6WTj7Ose/Hk98No5Y4cI3BZTZWYGW1QvJxBe8CyxazKbqwAfh/Vy0MFTLEd6ygriKt3lYRqfuwbTmtBAmDiEokpZF3t4dvghWLS5JYK7dRUShyQ=
Message-ID: <48526600-081d-7be1-88cc-cf47cdb0253b@oracle.com>
Date: Tue, 5 Apr 2022 16:06:47 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: cleanup swiotlb initialization v8
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Anshuman Khandual <anshuman.khandual@arm.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
References: <20220404050559.132378-1-hch@lst.de>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN4PR0501CA0075.namprd05.prod.outlook.com
 (2603:10b6:803:22::13) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cfb65ae6-d4eb-4655-1deb-08da173fd3bc
X-MS-TrafficTypeDiagnostic: CY4PR10MB1944:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR10MB194415E6E4B957CD648A672B8AE49@CY4PR10MB1944.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	7+cpxbKZpHbCxNRNzdJZae/a2lC3ai+FqpOulMGFxU1EzjvUzyvmqerEFUbIRLzu/ARdOf7KnROHcTQtoSquZoxrF3pQ/Vykrk3R9gtZIqQXS/FwrmmbSl/Tsh0ZrxT4Gv+YqO/3XGpKOT9tZk4v6xAdINo0/e6EFnDv1JQYnZp8ESTEFG+8vtsGP8tDxp7y5LowKbBtDFojW0VWx6EgII82Uc0EXJfaY8bE/iwOFzOcLnX3YDHPj7er1vAGMz3cO7wHKL0t4jzuA+t392Fr9oFQSnjAkuj2fRkImXIXPQN5MPAFTk1/PDYfxFGK596VvnjYDaubPcjOjBI/DkCjx+8jPXXmrp0ZhtR5EXfhgNLG7jWZ5ZqBoEv45nC8qqsPkw0hbssk9Qz1X4KJHqmhZpiYQn5HtYQkQuhw1FL16ah0rgfakc1BNxkK0uCapTNlPGR5t+ffEkvEkVAShjFjx2zdKPiCAmDwjlu91Z3F99q/9zWDgsfTNYGPlzOjCJ+iuHUcbCKLwZX2RUpQ4hkBgz7moEvBAslzE5IMabuYd67me/jAq8lz5KHRuDMkNeiOwaoAfajkJ7jWrS96K45HZpByyNYBaz6F/oh1rPYvyJc/1vSiTzbPUUrfq/DHId9R+Lqfbhz91Oz6nJi7ZJ89MPT2LjPwbXbmfpUK16n/n8DJm0jMXyl9kKOuCCk2Qz33rodEKN//4kZ3OQmrV9XFHDeQXQE1GoOtVFfLhsaLCj80DyjRRaL3MSnbcL3+nmIlvhFvQWeZTROZdcO3C6R+682s4xsFhCv54BIPay55iw4Fex/Al1KLdcZBeYYOYgPADG6savMQAla1Gi687kB9Zg==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(38100700002)(54906003)(6486002)(31686004)(966005)(8676002)(5660300002)(6512007)(6506007)(44832011)(31696002)(316002)(4744005)(7416002)(8936002)(86362001)(4326008)(66476007)(66946007)(66556008)(36756003)(508600001)(6666004)(186003)(26005)(2616005)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Yncrb3FyUWVnNU4xdDJFU1YyU1hJT1VzZ2xwUWhVRjhETG4rUU1CMnpXaVpm?=
 =?utf-8?B?QkQzOWthYnFyVUtIb3BmRVM0UnFhSmQyTUxyMGkvYXhyTFBwSVZKaTIvSkZD?=
 =?utf-8?B?VjNsenE3WVBhVHZuSGdGV3VlcGdjUjdFYkRTb1dnQkFOR2kzTjVaKzVmc2hs?=
 =?utf-8?B?TjFHdGUyZkVKMkVXVTZKN2VkRWJia0wrK0hwUFNpaFVydGt4eHJLcHg5Q3h3?=
 =?utf-8?B?OXZqaE1wMUExZXN1NEdzTElWZFNNM2lsL1RIODdtaWNHSGhQKzAxdjR2Umpw?=
 =?utf-8?B?UVVRbzQ3dlpEWVExSjRTTjE0LzZ5eUJqU3daMThUT1ZiK2JQcEVLODlkVUxv?=
 =?utf-8?B?em13Mmd1TXVBYzdsWG1pN2lUU05CcldBWm5oUS9PaFRrNXVBckJBWTNIV093?=
 =?utf-8?B?M205eDhxMm90ZUpUV2tsRmxERitVcnRoS2dUN1hEYU1ZZ2o1bUNhSWgvbGoz?=
 =?utf-8?B?c1JhaWtwZFlIaE5UbjNQQmxZZUZSNDRYZ0xOVG9LWjkwVHBxT2lEOXRENDJJ?=
 =?utf-8?B?aTdxNDBKNWgxQzVkYmhTMTVEYU40VlNUQU4rd1V1ckRldWFjQnhMcENVVk42?=
 =?utf-8?B?d2lsaG1SUlFnQmNRTjEwMFZsMmovQTBFKy9zdFFFNmN4amJjcGIzR2NLc2tv?=
 =?utf-8?B?V3lHbEppL0Z0eGZ1d1Q5bmtIcTVieE5oQWZ5Nm5vUUZjTElXYStwMlBSbCtZ?=
 =?utf-8?B?QkFqYTM4bzJjd1VqWjEwclhQdXEzRytwZmRBcnNPUUJMdy9IZmtlMEU2Y1RB?=
 =?utf-8?B?NmRZSHlPUlRTaXh1WXA2S0l0ay8raHVVNjBDb1dPZjh3NGVpSXVvRmQ1elZM?=
 =?utf-8?B?ZmY4WDJIQ0lyS3I1TFNkT3BpcWo4MmZKUFZPMWJOV01Gd0Q1TEJySUJXSmsy?=
 =?utf-8?B?aTZIVXBvZ2hDbkc3bmtzUUhBM2hZbXhOcm5DOHUvTWkwaUo1WmRjVWJ0UkJI?=
 =?utf-8?B?ZFZnak8weGNXcFhvVG0vS2hFQmFRM2VQRDAxcXc1Ym51Y3hmTUJyaG1ReHF5?=
 =?utf-8?B?SGhhcHBDdHF4VERacDVjdSt0NEZwN1F1S0VBNGk2VmpIc0JDMFBMd3o5Vm4r?=
 =?utf-8?B?dnBKK1U4K0pEQ280QnRrM084dDZ0NDFLMWFQTTY3M0Zpd2QyR285dnZ2NUpC?=
 =?utf-8?B?RFVIa2RNMmgzcjBteFYxY25qREtGbDd2NXZ0OFRBWlpyUm1sOTJjYWQ3d0tH?=
 =?utf-8?B?WHJmVTB2SG1oS1B3c3p5L0tKVnZqVFJjL1B0N1VnbFlDcEhlb2NJMmx5dHdD?=
 =?utf-8?B?QkNmQjNrRm15cWh5azV1VXhvN0ZPWC8rZlpQSUttclArN0FMcUFXVWQvZTVx?=
 =?utf-8?B?NmtSUmM4Q2RrMFo4SEdkZWhTbGp0N1Q3WFdmS0pLMTNXTVdsMWNsUUg2YmVH?=
 =?utf-8?B?UHVTZWFzYnZBTVgrS1BFd0wzenhqVG9TSVpFUXc4ZUwyK2Z4eHdDemZwaXZB?=
 =?utf-8?B?RXkyN1F3QXV6bjVPZUZqNkMra1JrK2cxaTZ3OEhNTks2dWhleVJTSTBnMkw3?=
 =?utf-8?B?K0laVEFvVVZ1VjhJQWtUcC9iRWcxUWhMR0YzR3dRYjNnVzMvam9tRzk5RGIz?=
 =?utf-8?B?NS9IVldSWjRBUUp1ZGtrN3ZneDduV1VkVEJ1aVFLMkNNOE5qNTJqNHhjbDlW?=
 =?utf-8?B?ZmVKWUxObE8vNzdseGM3a1QyOVB6bDYrUkcvSjRRaTcwVFdacGxzRDNWalZM?=
 =?utf-8?B?b3M5Q2RWQ2FJU2xuaDE1R1FIK05idGx0RXNiMUtvYkpiQy80RVRQWTY0c1Fo?=
 =?utf-8?B?RnJlbURFRWU5M081aGt3VGZrcWJ5cHRiOUgvMlhockN3eWhZaEZ6ZlZvMnJK?=
 =?utf-8?B?L0ttaW5IUnhjc0JWbXZqc1BPbTZQRHY3cWg1V2ZUakxJcWl5dW80R0FuMWtK?=
 =?utf-8?B?UUx5MEJSMnhuTjlQVEdUejh3Ukx2NEtud0o4QkZsNDRJMTN4R3gxMDZlNWpZ?=
 =?utf-8?B?dnczWGZ1SDlJK0xJUWxLVURQeVRTeDlkSW1yRzRkUlRmZDZxbGJ0bnhPRHN1?=
 =?utf-8?B?VTJMdTVWUjVkNStYdzBwMU82ZzVTc29TK0V6MitDVnZhdDBrOHZNSURwM0ZD?=
 =?utf-8?B?dFg3cVNHUWtVTmhwek1zb05aSmZKb0htczlvanFwanozRk93b2hGaHNWOSs4?=
 =?utf-8?B?NXBpOGw2SzZZdE02RFN0dW5GdDBrTzQ1REtZL2JpMEQvcTlvem9jbEtSU3l1?=
 =?utf-8?B?RUhTRjc5WnZZcmdnVFRuK1ppQUFuN3hLTnd2em00Sm0ydjVRQklqSkFmTWlF?=
 =?utf-8?B?T2pNeExvRHhJUEhrc2tVbUNhWjJISGYyTTVCbTlMUXZjdWVoN2MxNFZwcVRj?=
 =?utf-8?B?eWZZZksySEgzeXdLRDNyZTNxazlWQjdwZHp6b3FZZ2FNajQ0U24xM2tGbzBm?=
 =?utf-8?Q?F5vfS0BXsu13G3CI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cfb65ae6-d4eb-4655-1deb-08da173fd3bc
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 20:06:53.1401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 26PS2iFudTEwClAtcgKRg5KleMgRBZRcEFhH7JvxTxGfOrIXMFGLIhWKpq6YDwAbTDAeX00qe5O1YrWF9VGHWpvJK8W2USnVBlTcNmvQORQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1944
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-05_06:2022-04-04,2022-04-05 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204050113
X-Proofpoint-ORIG-GUID: GaJrNkL8mc8evtqJEYSbwuP_D3hzpQ0B
X-Proofpoint-GUID: GaJrNkL8mc8evtqJEYSbwuP_D3hzpQ0B


On 4/4/22 1:05 AM, Christoph Hellwig wrote:
> Hi all,
>
> this series tries to clean up the swiotlb initialization, including
> that of swiotlb-xen.  To get there is also removes the x86 iommu table
> infrastructure that massively obsfucates the initialization path.
>
> Git tree:
>
>      git://git.infradead.org/users/hch/misc.git swiotlb-init-cleanup
>
> Gitweb:
>
>      http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/swiotlb-init-cleanup




Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>




From xen-devel-bounces@lists.xenproject.org Tue Apr 05 20:47:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 20:47:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299270.509840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbq4n-0008LY-Vb; Tue, 05 Apr 2022 20:46:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299270.509840; Tue, 05 Apr 2022 20:46:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbq4n-0008LR-S3; Tue, 05 Apr 2022 20:46:57 +0000
Received: by outflank-mailman (input) for mailman id 299270;
 Tue, 05 Apr 2022 20:46:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbq4n-0008LF-3S
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 20:46:57 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org
 [2604:1380:40e1:4800::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86d87867-b521-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 22:46:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 03236CE1FEA;
 Tue,  5 Apr 2022 20:46:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1740BC385A3;
 Tue,  5 Apr 2022 20:46:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86d87867-b521-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649191608;
	bh=Pu3rHnIsFQfC8fDr7MNt41ExeAmGP9LpggprWLdUJ6o=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=bxA5r438nkJ2VBad/dFwJEo0L3RDB+1zvbdPtbpO9gUbapc8l85CMOdcAQF70EF/S
	 Kt0mmfAHzUiBSLmtq5fC/dVzbFt5VLDZ6FBHw9cmN6HA99lSf17JG55gLKqAii3atv
	 yqQ0kp0WM330LCwofVvNDctOei2xkvN18IW60c1QZmlELYf1KVLr1qK0iLKrQNSKIU
	 LJ7cvcleKrrgO9RsWVU3qJgCIDPwDOpwsSR/eWP2BpNzpNCngnEmdxX24El5IvxULg
	 C1zOSAYYcc7y/G8JJZewacQ49Brmhae+qarpZkdwNuNNytPhqR1TvIiQaXfCRwSKyY
	 CnQK5ppwJjnjw==
Date: Tue, 5 Apr 2022 13:46:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 04/19] xen/arm: mm: Allow other mapping size in
 xen_pt_update_entry()
In-Reply-To: <a2dafd9a-a0a9-b99d-9592-4f8e5fbb3f20@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051345500.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-5-julien@xen.org> <alpine.DEB.2.22.394.2204011605580.2910984@ubuntu-linux-20-04-desktop> <a2dafd9a-a0a9-b99d-9592-4f8e5fbb3f20@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 2 Apr 2022, Julien Grall wrote:
> On 02/04/2022 00:35, Stefano Stabellini wrote:
> > > +/* Return the level where mapping should be done */
> > > +static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned
> > > long nr,
> > > +                                unsigned int flags)
> > > +{
> > > +    unsigned int level;
> > > +    unsigned long mask;
> > 
> > Shouldn't mask be 64-bit on aarch32?
> 
> The 3 variables we will use (mfn, vfn, nr) are unsigned long. So it is fine to
> define the mask as unsigned long.

Good point


> > > +}
> > > +
> > >   static DEFINE_SPINLOCK(xen_pt_lock);
> > >     static int xen_pt_update(unsigned long virt,
> > >                            mfn_t mfn,
> > > -                         unsigned long nr_mfns,
> > > +                         const unsigned long nr_mfns,
> > 
> > Why const? nr_mfns is an unsigned long so it is passed as value: it
> > couldn't change the caller's parameter anyway. Just curious.
> 
> Because nr_mfns is used to flush the TLBs. In the original I made the mistake
> to decrement the variable and only discovered later on when the TLB contained
> the wrong entry.
> 
> Such bug tends to be very subtle and it is hard to find the root cause. So
> better mark the variable const to avoid any surprise.
> 
> The short version of what I wrote is in the commit message. I can write a
> small comment in the code if you want.

No, that's fine. Thanks for the explanation.


> > >                            unsigned int flags)
> > >   {
> > >       int rc = 0;
> > > -    unsigned long addr = virt, addr_end = addr + nr_mfns * PAGE_SIZE;
> > > +    unsigned long vfn = virt >> PAGE_SHIFT;
> > > +    unsigned long left = nr_mfns;
> > >         /*
> > >        * For arm32, page-tables are different on each CPUs. Yet, they
> > > share
> > > @@ -1268,14 +1330,24 @@ static int xen_pt_update(unsigned long virt,
> > >         spin_lock(&xen_pt_lock);
> > >   -    for ( ; addr < addr_end; addr += PAGE_SIZE )
> > > +    while ( left )
> > >       {
> > > -        rc = xen_pt_update_entry(root, addr, mfn, flags);
> > > +        unsigned int order, level;
> > > +
> > > +        level = xen_pt_mapping_level(vfn, mfn, left, flags);
> > > +        order = XEN_PT_LEVEL_ORDER(level);
> > > +
> > > +        ASSERT(left >= BIT(order, UL));
> > > +
> > > +        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level,
> > > flags);
> > 
> > NIT: I know we don't have vfn_to_vaddr at the moment and there is no
> > widespread usage of vfn in Xen anyway, but it looks off to use
> > pfn_to_paddr on a vfn parameter. Maybe open-code pfn_to_paddr instead?
> > Or introduce vfn_to_vaddr locally in this file?
> 
> To avoid inconsistency with mfn_to_maddr() and gfn_to_gaddr(), I don't want ot
> introduce vfn_to_vaddr() withtout the typesafe part. I think this is a bit
> over the top for now.
> 
> So I will open-code pfn_to_paddr().

Sounds good


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 20:47:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 20:47:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299273.509851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbq5b-0000RV-8o; Tue, 05 Apr 2022 20:47:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299273.509851; Tue, 05 Apr 2022 20:47:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbq5b-0000RO-5N; Tue, 05 Apr 2022 20:47:47 +0000
Received: by outflank-mailman (input) for mailman id 299273;
 Tue, 05 Apr 2022 20:47:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbq5a-0000R7-BE
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 20:47:46 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a478f8ba-b521-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 22:47:44 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 63BFF61A5A;
 Tue,  5 Apr 2022 20:47:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DA82C385A1;
 Tue,  5 Apr 2022 20:47:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a478f8ba-b521-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649191662;
	bh=jThJHvveHPmh9n3msvqSSDJayKeD4lI9Qar2n78Bs4I=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=kQK8Kg/dhzICHW0mC05ogn1UgUxaNzAPvNQZVX90LV0M1dkSAx1tZuEWbXjDrXNJu
	 GNrFYBP4/4Dtiz1FLGaHWdNEMk07egCSMJEtuBK9a+55BPQjWIhAHQrGpvbGPqLE0e
	 23S5t/ETqVVsDAq+7Lit0GpwYef8/ikKYdmQgi5gFR90rwqfTK0DRXcExGg8MR0JWT
	 uojG5C7o3GfReK61T1Rtqqn6CSgA711Axb84dK6An2OqlXB9n/7/2Cv+maZdlCf0ts
	 vgDl7H2tgJZfvvcNINaa9Gy2tCLAYjyqRxwcm6lxGQVt1pO/UcbOz79T4ZiHxgxp23
	 xeJ+EoANDMaZg==
Date: Tue, 5 Apr 2022 13:47:41 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 05/19] xen/arm: mm: Add support for the contiguous
 bit
In-Reply-To: <3a164544-7760-1f57-1af6-c80020b604f0@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051347100.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-6-julien@xen.org> <alpine.DEB.2.22.394.2204011639430.2910984@ubuntu-linux-20-04-desktop> <3a164544-7760-1f57-1af6-c80020b604f0@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 2 Apr 2022, Julien Grall wrote:
> On 02/04/2022 00:53, Stefano Stabellini wrote:
> > On Mon, 21 Feb 2022, Julien Grall wrote:
> > > @@ -1333,21 +1386,34 @@ static int xen_pt_update(unsigned long virt,
> > >       while ( left )
> > >       {
> > >           unsigned int order, level;
> > > +        unsigned int nr_contig;
> > > +        unsigned int new_flags;
> > >             level = xen_pt_mapping_level(vfn, mfn, left, flags);
> > >           order = XEN_PT_LEVEL_ORDER(level);
> > >             ASSERT(left >= BIT(order, UL));
> > >   -        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level,
> > > flags);
> > > -        if ( rc )
> > > -            break;
> > > +        /*
> > > +         * Check if we can set the contiguous mapping and update the
> > > +         * flags accordingly.
> > > +         */
> > > +        nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags);
> > > +        new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0);
> > 
> > Here is an optional idea to make the code simpler. We could move the
> > flags changes (adding/removing _PAGE_CONTIG) to xen_pt_check_contig.
> > That way, we could remove the inner loop.
> > 
> > xen_pt_check_contig could check if _PAGE_CONTIG is already set and based
> > on alignment, it should be able to figure out when it needs to be
> > disabled.
> 
> My initial attempt was to do everything in a loop. But this didn't pan out as
> I wanted (I felt the code was complex) and there are extra work to be done for
> the next 31 entries (assuming 4KB granularity).
> 
> Hence the two loops. Unfortunately, I didn't keep my first attempt. So I can't
> realy show what I wrote.

I trusted you that the resulting code with a single loop was worse.

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 20:50:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 20:50:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299278.509861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbq7n-0001RC-M6; Tue, 05 Apr 2022 20:50:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299278.509861; Tue, 05 Apr 2022 20:50:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbq7n-0001Qh-IQ; Tue, 05 Apr 2022 20:50:03 +0000
Received: by outflank-mailman (input) for mailman id 299278;
 Tue, 05 Apr 2022 20:50:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbq7m-0001Cp-Jj
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 20:50:02 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f5d71cbb-b521-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 22:50:01 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 3DFC361A33;
 Tue,  5 Apr 2022 20:50:00 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5509BC385A0;
 Tue,  5 Apr 2022 20:49:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5d71cbb-b521-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649191799;
	bh=0YaxkY0Fk1Ka/2d7/myeTwLJd9zXxqB/S4aWnOgA38s=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=jz+prIySMsPDF5I4FLICNLnBvOdtjewr8/Ka+vPpmxBzXn6zOfGvFuZVsP/ITkACD
	 DvKvcdgrkxPa5sesjt8pqF/1E8aqbauYbjxXXMtdxKdk7c+atKZsLiPM8khjUC5E+L
	 gqfX31L8VqDaoRtH2DyJSCb5whh4yP4QiBg3HeRhGTU+7q8+nNxyLo3ryr6S4pHc53
	 +duTzXSVXW07G/j0ESUw5aHS1crWBpZY9wWe73EIb/4ba1U/ctsF/HRn0bPSQBkaJx
	 4AfNpfGstxi8LHIEfUIjr/JhVi24QTmCCQjGAjl3FTPKXBD/7lxjJC0bSOQ3B4yIOi
	 YDAZUinwoQ9zQ==
Date: Tue, 5 Apr 2022 13:49:58 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 06/19] xen/arm: mm: Avoid flushing the TLBs when
 mapping are inserted
In-Reply-To: <f0d3ed02-450f-9bd1-e8ab-5594234a835d@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051348200.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-7-julien@xen.org> <alpine.DEB.2.22.394.2204011657080.2910984@ubuntu-linux-20-04-desktop> <f0d3ed02-450f-9bd1-e8ab-5594234a835d@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 2 Apr 2022, Julien Grall wrote:
> Hi Stefano,
> 
> On 02/04/2022 01:00, Stefano Stabellini wrote:
> > On Mon, 21 Feb 2022, Julien Grall wrote:
> > > From: Julien Grall <jgrall@amazon.com>
> > > 
> > > Currently, the function xen_pt_update() will flush the TLBs even when
> > > the mappings are inserted. This is a bit wasteful because we don't
> > > allow mapping replacement. Even if we were, the flush would need to
> > > happen earlier because mapping replacement should use Break-Before-Make
> > > when updating the entry.
> > > 
> > > A single call to xen_pt_update() can perform a single action. IOW, it
> > > is not possible to, for instance, mix inserting and removing mappings.
> > > Therefore, we can use `flags` to determine what action is performed.
> > > 
> > > This change will be particularly help to limit the impact of switching
> > > boot time mapping to use xen_pt_update().
> > > 
> > > Signed-off-by: Julien Grall <jgrall@amazon.com>
> > > 
> > > ---
> > >      Changes in v2:
> > >          - New patch
> > > ---
> > >   xen/arch/arm/mm.c | 17 ++++++++++++++---
> > >   1 file changed, 14 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> > > index fd16c1541ce2..7b4b9de8693e 100644
> > > --- a/xen/arch/arm/mm.c
> > > +++ b/xen/arch/arm/mm.c
> > > @@ -1104,7 +1104,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t
> > > mfn, unsigned int level,
> > >           /* We should be here with a valid MFN. */
> > >           ASSERT(!mfn_eq(mfn, INVALID_MFN));
> > >   -        /* We don't allow replacing any valid entry. */
> > > +        /*
> > > +         * We don't allow replacing any valid entry.
> > > +         *
> > > +         * Note that the function xen_pt_update() relies on this
> > > +         * assumption and will skip the TLB flush. The function will need
> > > +         * to be updated if the check is relaxed.
> > > +         */
> > >           if ( lpae_is_valid(entry) )
> > >           {
> > >               if ( lpae_is_mapping(entry, level) )
> > > @@ -1417,11 +1423,16 @@ static int xen_pt_update(unsigned long virt,
> > >       }
> > >         /*
> > > -     * Flush the TLBs even in case of failure because we may have
> > > +     * The TLBs flush can be safely skipped when a mapping is inserted
> > > +     * as we don't allow mapping replacement (see xen_pt_check_entry()).
> > > +     *
> > > +     * For all the other cases, the TLBs will be flushed unconditionally
> > > +     * even if the mapping has failed. This is because we may have
> > >        * partially modified the PT. This will prevent any unexpected
> > >        * behavior afterwards.
> > >        */
> > > -    flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);
> > > +    if ( !(flags & _PAGE_PRESENT) || mfn_eq(mfn, INVALID_MFN) )
> > > +        flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);
> > 
> > I am trying to think of a care where the following wouldn't be enough
> > but I cannot come up with one:
> > 
> >     if ( mfn_eq(mfn, INVALID_MFN) )
> >         flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);
> 
> _PAGE_PRESENT is not set for two cases: when removing a page or populating
> page-tables for a region. Both of them will expect an INVALID_MFN (see the two
> asserts in xen_pt_check_entry()).
> 
> Therefore your solution should work. However, technically the 'mfn' is ignored
> in both situation (hence why this is an ASSERT() rather than a prod check).
> 
> Also, I feel it is better to flush more than less (missing a flush could have
> catastrophic result). So I chose to be explicit in which case the flush can be
> skipped.
> 
> Maybe it would be clearer if I write:
> 
>  !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN))

It is not much a matter of clarity -- I just wanted to check with you
the reasons for the if condition because, as you wrote, wrong tlb
flushes can have catastrophic effects.

That said, actually I prefer your second version:

  !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN))


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 20:51:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 20:51:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299283.509873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbq9W-0002ZJ-5r; Tue, 05 Apr 2022 20:51:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299283.509873; Tue, 05 Apr 2022 20:51:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbq9W-0002ZC-1j; Tue, 05 Apr 2022 20:51:50 +0000
Received: by outflank-mailman (input) for mailman id 299283;
 Tue, 05 Apr 2022 20:51:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbq9T-0002Yz-Va
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 20:51:47 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 34940f5d-b522-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 22:51:46 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6AA0561A27;
 Tue,  5 Apr 2022 20:51:45 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79D35C385A1;
 Tue,  5 Apr 2022 20:51:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34940f5d-b522-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649191904;
	bh=gwoZZkEoIL8R/gdTJMJIG8CvIsCJ56P/SL+aQ/q+E2M=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=PxLlt36j4Jcm5CM2ygweXh84PVJF+iRp2ot0BxJGZh95s2i0r2UM0j5XCYs9QrJIS
	 0SmRYsYhLMC33Qx1RSDRUwzLK8UIbKywqkiaCN2Simc1ZwRiVgeJScv99RKWwRPIq8
	 tX/Kd/DX3SYqO2XGFnpAXAkEKzEXZCDqFLnWxOwf6zY4FOVFp/ZQq60wzv21n2uO1/
	 /Gq1eYoKciqkVX5kwJoQnMKuw1lJj+xmPE2ZbJIQBhRiowlWIKXTvZL6/K1itmLrXa
	 Eo2xgzA+29RzyAmFUfm4Gq1OQJHEtHYYl+KqlbffTWwSVrtJR/btv6RXPIMeIyg9ig
	 md+ous3NHsomA==
Date: Tue, 5 Apr 2022 13:51:43 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 07/19] xen/arm: mm: Don't open-code Xen PT update in
 remove_early_mappings()
In-Reply-To: <b62e61bd-ea54-e41e-17de-a07dbfe477b7@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051350410.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-8-julien@xen.org> <alpine.DEB.2.22.394.2204011700520.2910984@ubuntu-linux-20-04-desktop> <b62e61bd-ea54-e41e-17de-a07dbfe477b7@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 2 Apr 2022, Julien Grall wrote:
> On 02/04/2022 01:04, Stefano Stabellini wrote:
> > On Mon, 21 Feb 2022, Julien Grall wrote:
> > > From: Julien Grall <julien.grall@arm.com>
> > > 
> > > Now that xen_pt_update_entry() is able to deal with different mapping
> > > size, we can replace the open-coding of the page-tables update by a call
> > > to modify_xen_mappings().
> > > 
> > > As the function is not meant to fail, a BUG_ON() is added to check the
> > > return.
> > > 
> > > Signed-off-by: Julien Grall <julien.grall@arm.com>
> > > Signed-off-by: Julien Grall <jgrall@amazon.com>
> > 
> > Nice!
> > 
> > 
> > > ---
> > >      Changes in v2:
> > >          - Stay consistent with how function name are used in the commit
> > >          message
> > >          - Add my AWS signed-off-by
> > > ---
> > >   xen/arch/arm/mm.c | 10 +++++-----
> > >   1 file changed, 5 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> > > index 7b4b9de8693e..f088a4b2de96 100644
> > > --- a/xen/arch/arm/mm.c
> > > +++ b/xen/arch/arm/mm.c
> > > @@ -599,11 +599,11 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
> > >     void __init remove_early_mappings(void)
> > >   {
> > > -    lpae_t pte = {0};
> > > -    write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START),
> > > pte);
> > > -    write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START +
> > > SZ_2M),
> > > -              pte);
> > > -    flush_xen_tlb_range_va(BOOT_FDT_VIRT_START, BOOT_FDT_SLOT_SIZE);
> > > +    int rc;
> > > +
> > > +    rc = modify_xen_mappings(BOOT_FDT_VIRT_START, BOOT_FDT_VIRT_END,
> > > +                             _PAGE_BLOCK);
> > > +    BUG_ON(rc);
> > 
> > Am I right that we are actually destroying the mapping, which usually is
> > done by calling destroy_xen_mappings, but we cannot call
> > destroy_xen_mappings in this case because it doesn't take a flags
> > parameter?
> 
> You are right.
> 
> > 
> > If so, then I would add a flags parameter to destroy_xen_mappings
> > instead of calling modify_xen_mappings just to pass _PAGE_BLOCK.
> > But I don't feel strongly about it so if you don't feel like making the
> > change to destroy_xen_mappings, you can add my acked-by here anyway.
> 
> destroy_xen_mappings() is a function used by common code. This is the only
> place so far where I need to pass _PAGE_BLOCK and I don't expect it to be used
> by the common code any time soon.
> 
> So I am not in favor to add an extra parameter for destroy_xen_mappings().
> 
> Would you prefer if I open-code the call to xen_pt_update?

No need, just add a one-line in-code comment like:

    /* destroy the _PAGE_BLOCK mapping */


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 20:58:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 20:58:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299287.509884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqGE-0003HP-Te; Tue, 05 Apr 2022 20:58:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299287.509884; Tue, 05 Apr 2022 20:58:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqGE-0003HI-QE; Tue, 05 Apr 2022 20:58:46 +0000
Received: by outflank-mailman (input) for mailman id 299287;
 Tue, 05 Apr 2022 20:58:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbqGD-0003HC-Uy
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 20:58:45 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2de7ee99-b523-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 22:58:44 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 9257060AD1;
 Tue,  5 Apr 2022 20:58:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A48DBC385A1;
 Tue,  5 Apr 2022 20:58:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2de7ee99-b523-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649192323;
	bh=I2zxw/R3wS1Dp+h5spkxYQftOjNOge307lmdkxwI4kw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=kjUB4IppbrZYKQTbFga1tr7U6h24JCQFctJ/yG2Djqu8Cd6DyJpQGndezYZU4sGFm
	 maxQbF2RUoGCSHxar2H2/NPAXOz4Ny3uXznvXya4MBSDMU5Rn5i00jYBqh8FyzZ/SN
	 U9dNetyTT3RiZ5AgcFPAbJ5V3IUUZfFamWaOZwrr8An4CzhlUQdHAwLWAJDGVA8Ig/
	 59Pzq8dsNgGgxE8nDYUzEu/qOkXk1EzcR3it0/TsrhmvDckwbypHjMBl/URKd+w4RE
	 b44bwPmeVC27xzJoPuJMlET3YfoVPiUsuGCHBeG0LmyuwUBhONO1PqW775WohXYBtX
	 G1267UQiUBDbQ==
Date: Tue, 5 Apr 2022 13:58:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 12/19] xen/arm: mm: Allow page-table allocation from
 the boot allocator
In-Reply-To: <20220221102218.33785-13-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051354010.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-13-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
> 
> At the moment, page-table can only be allocated from domheap. This means
> it is not possible to create mapping in the page-tables via
> map_pages_to_xen() if page-table needs to be allocated.
> 
> In order to avoid open-coding page-tables update in early boot, we need
> to be able to allocate page-tables much earlier. Thankfully, we have the
> boot allocator for those cases.
> 
> create_xen_table() is updated to cater early boot allocation by using
> alloc_boot_pages().
> 
> Note, this is not sufficient to bootstrap the page-tables (i.e mapping
> before any memory is actually mapped). This will be addressed
> separately.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>     Changes in v2:
>         - New patch
> ---
>  xen/arch/arm/mm.c | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 58364bb6c820..f70b8cc7ce87 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1014,19 +1014,27 @@ static void xen_unmap_table(const lpae_t *table)
>  
>  static int create_xen_table(lpae_t *entry)
>  {
> -    struct page_info *pg;
> +    mfn_t mfn;
>      void *p;
>      lpae_t pte;
>  
> -    pg = alloc_domheap_page(NULL, 0);
> -    if ( pg == NULL )
> -        return -ENOMEM;
> +    if ( system_state != SYS_STATE_early_boot )
> +    {
> +        struct page_info *pg = alloc_domheap_page(NULL, 0);
> +
> +        if ( pg == NULL )
> +            return -ENOMEM;
> +
> +        mfn = page_to_mfn(pg);
> +    }
> +    else
> +        mfn = alloc_boot_pages(1, 1);
>  
> -    p = xen_map_table(page_to_mfn(pg));
> +    p = xen_map_table(mfn);
>      clear_page(p);
>      xen_unmap_table(p);
>  
> -    pte = mfn_to_xen_entry(page_to_mfn(pg), MT_NORMAL);
> +    pte = mfn_to_xen_entry(mfn, MT_NORMAL);
>      pte.pt.table = 1;
>      write_pte(entry, pte);


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 21:13:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 21:13:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299291.509895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqU3-0005cj-3A; Tue, 05 Apr 2022 21:13:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299291.509895; Tue, 05 Apr 2022 21:13:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqU2-0005cc-WD; Tue, 05 Apr 2022 21:13:03 +0000
Received: by outflank-mailman (input) for mailman id 299291;
 Tue, 05 Apr 2022 21:13:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbqU1-0005cW-NW
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 21:13:01 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2b2d5fc9-b525-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 23:12:59 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1650C60B5E;
 Tue,  5 Apr 2022 21:12:58 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0736C385A1;
 Tue,  5 Apr 2022 21:12:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b2d5fc9-b525-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649193177;
	bh=+JnNFKGo5X4hDVNR7BQcrPDAjrsJgobr8EFpq5B5bEY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=iDiTjOLXHUuibc2vuFJ5cTuCXI0el+EbpZF8ECExKEWM/FpjdiTPuKKfg5TaUTwUG
	 8nC2sKmfjVIqdKjrXUZnr+TV5zqmamZKWl/yizzn6P+oDP27IPAIvy9hW4Lkms2xsr
	 8U6RFHJapEqfPEYRbrv7fg2NMQ4NspNUlfLhofjmUBL3dTNCrPkBbUPQ2vM6ypFPOr
	 I8r5vu6pwqCu/n43i1VT6Er+Exj0EzF4v5E61ntLSGEP/mp6qg9x0CkMmkM5NfB7Q+
	 UW5p3b4tJ5RpRcWObM21GJCry5bXtPJsPg7dhwxeeOG4JxL5/rSA8FfA8/jRss9+NO
	 HpNvCSZ+C1pBw==
Date: Tue, 5 Apr 2022 14:12:56 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 13/19] xen/arm: Move fixmap definitions in a separate
 header
In-Reply-To: <20220221102218.33785-14-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051411510.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-14-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> To use properly the fixmap definitions, their user would need
> also new to include <xen/acpi.h>. This is not very great when
> the user itself is not meant to directly use ACPI definitions.
> 
> Including <xen/acpi.h> in <asm/config.h> is not option because
> the latter header is included by everyone. So move out the fixmap
> entries definition in a new header.
> 
> Take the opportunity to also move {set, clear}_fixmap() prototypes
> in the new header.
> 
> Note that most of the definitions in <xen/acpi.h> now need to be
> surrounded with #ifndef __ASSEMBLY__ because <asm/fixmap.h> will
> be used in assembly (see EARLY_UART_VIRTUAL_ADDRESS).
> 
> The split will become more helpful in a follow-up patch where new
> fixmap entries will be defined.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v3:
>         - Patch added
> ---
>  xen/arch/arm/acpi/lib.c                 |  2 ++
>  xen/arch/arm/include/asm/config.h       |  6 ------
>  xen/arch/arm/include/asm/early_printk.h |  1 +
>  xen/arch/arm/include/asm/fixmap.h       | 24 ++++++++++++++++++++++++
>  xen/arch/arm/include/asm/mm.h           |  4 ----
>  xen/arch/arm/kernel.c                   |  1 +
>  xen/arch/arm/mm.c                       |  1 +
>  xen/include/xen/acpi.h                  | 18 +++++++++++-------
>  8 files changed, 40 insertions(+), 17 deletions(-)
>  create mode 100644 xen/arch/arm/include/asm/fixmap.h
> 
> diff --git a/xen/arch/arm/acpi/lib.c b/xen/arch/arm/acpi/lib.c
> index a59cc4074cfb..41d521f720ac 100644
> --- a/xen/arch/arm/acpi/lib.c
> +++ b/xen/arch/arm/acpi/lib.c
> @@ -25,6 +25,8 @@
>  #include <xen/init.h>
>  #include <xen/mm.h>
>  
> +#include <asm/fixmap.h>
> +
>  static bool fixmap_inuse;
>  
>  char *__acpi_map_table(paddr_t phys, unsigned long size)
> diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
> index 85d4a510ce8a..51908bf9422c 100644
> --- a/xen/arch/arm/include/asm/config.h
> +++ b/xen/arch/arm/include/asm/config.h
> @@ -175,12 +175,6 @@
>  
>  #endif
>  
> -/* Fixmap slots */
> -#define FIXMAP_CONSOLE  0  /* The primary UART */
> -#define FIXMAP_MISC     1  /* Ephemeral mappings of hardware */
> -#define FIXMAP_ACPI_BEGIN  2  /* Start mappings of ACPI tables */
> -#define FIXMAP_ACPI_END    (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1)  /* End mappings of ACPI tables */
> -
>  #define NR_hypercalls 64
>  
>  #define STACK_ORDER 3
> diff --git a/xen/arch/arm/include/asm/early_printk.h b/xen/arch/arm/include/asm/early_printk.h
> index 8dc911cf48a3..c5149b2976da 100644
> --- a/xen/arch/arm/include/asm/early_printk.h
> +++ b/xen/arch/arm/include/asm/early_printk.h
> @@ -11,6 +11,7 @@
>  #define __ARM_EARLY_PRINTK_H__
>  
>  #include <xen/page-size.h>
> +#include <asm/fixmap.h>
>  
>  #ifdef CONFIG_EARLY_PRINTK
>  
> diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h
> new file mode 100644
> index 000000000000..1cee51e52ab9
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/fixmap.h
> @@ -0,0 +1,24 @@
> +/*
> + * fixmap.h: compile-time virtual memory allocation
> + */
> +#ifndef __ASM_FIXMAP_H
> +#define __ASM_FIXMAP_H
> +
> +#include <xen/acpi.h>
> +
> +/* Fixmap slots */
> +#define FIXMAP_CONSOLE  0  /* The primary UART */
> +#define FIXMAP_MISC     1  /* Ephemeral mappings of hardware */
> +#define FIXMAP_ACPI_BEGIN  2  /* Start mappings of ACPI tables */
> +#define FIXMAP_ACPI_END    (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1)  /* End mappings of ACPI tables */
> +
> +#ifndef __ASSEMBLY__
> +
> +/* Map a page in a fixmap entry */
> +extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
> +/* Remove a mapping from a fixmap entry */
> +extern void clear_fixmap(unsigned map);
> +
> +#endif /* __ASSEMBLY__ */
> +
> +#endif /* __ASM_FIXMAP_H */


It is a good idea to create fixmap.h, but I think it should be acpi.h to
include fixmap.h, not the other way around.

The appended changes build correctly on top of this patch.


diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h
index 1cee51e52a..8cf9dbb618 100644
--- a/xen/arch/arm/include/asm/fixmap.h
+++ b/xen/arch/arm/include/asm/fixmap.h
@@ -4,8 +4,6 @@
 #ifndef __ASM_FIXMAP_H
 #define __ASM_FIXMAP_H
 
-#include <xen/acpi.h>
-
 /* Fixmap slots */
 #define FIXMAP_CONSOLE  0  /* The primary UART */
 #define FIXMAP_MISC     1  /* Ephemeral mappings of hardware */
@@ -14,6 +12,8 @@
 
 #ifndef __ASSEMBLY__
 
+#include <xen/mm-frame.h>
+
 /* Map a page in a fixmap entry */
 extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
 /* Remove a mapping from a fixmap entry */
diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h
index 1b9c75e68f..148673e77c 100644
--- a/xen/include/xen/acpi.h
+++ b/xen/include/xen/acpi.h
@@ -28,6 +28,8 @@
 #define _LINUX
 #endif
 
+#include <asm/fixmap.h>
+
 /*
  * Fixmap pages to reserve for ACPI boot-time tables (see
  * arch/x86/include/asm/fixmap.h or arch/arm/include/asm/fixmap.h),


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 21:27:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 21:27:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299295.509905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqhk-0007BK-BV; Tue, 05 Apr 2022 21:27:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299295.509905; Tue, 05 Apr 2022 21:27:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqhk-0007BD-8H; Tue, 05 Apr 2022 21:27:12 +0000
Received: by outflank-mailman (input) for mailman id 299295;
 Tue, 05 Apr 2022 21:27:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbqhj-0007B7-43
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 21:27:11 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 265d85ea-b527-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 23:27:09 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id EB169B81FCC;
 Tue,  5 Apr 2022 21:27:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EFA5C385A0;
 Tue,  5 Apr 2022 21:27:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 265d85ea-b527-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649194027;
	bh=ngvpwmI93N1gEc4OkREiMZqxJruyrnJnmYo76hyTizc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=M/hUAy39E3uVgpYf8Z0UjhHCzx7B2uKzO4jKeTevEgbYVPQqLPLyTdGOgznzA5LlL
	 5+BTAfQwp1rDkn8n89q7hC1HJQpUCuP8J7RJeRXzve3uY8E3mLU2sHcJov75RAV5sS
	 3VRAz6cRaQ5L5DFuwpVpVmwdjKm6+ZUZ+FVaI0ECtVLW9Zz13hu1y9/BNyt8xCQkTs
	 KykREcb8O+ig6dcd1xgGPMEZxuG1SZTuh8VdocSjhMZyOhpxzaop9yndNZ1gguv5+L
	 iaEf9RNtfYmpQyOpQ6TM/QjdCCjWdwNu2PXxOsvjJQrntJZPxHXypaotMweZab2gbI
	 kBWWKzxCLpHzQ==
Date: Tue, 5 Apr 2022 14:27:06 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    George Dunlap <george.dunlap@citrix.com>, 
    Hongyan Xia <hongyxia@amazon.com>, Julien Grall <jgrall@amazon.com>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP)
 infrastructure
In-Reply-To: <20220221102218.33785-15-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051423490.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-15-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-878656267-1649194027=:2910984"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-878656267-1649194027=:2910984
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Wei Liu <wei.liu2@citrix.com>
> 
> The basic idea is like Persistent Kernel Map (PKMAP) in Linux. We
> pre-populate all the relevant page tables before the system is fully
> set up.
> 
> We will need it on Arm in order to rework the arm64 version of
> xenheap_setup_mappings() as we may need to use pages allocated from
> the boot allocator before they are effectively mapped.
> 
> This infrastructure is not lock-protected therefore can only be used
> before smpboot. After smpboot, map_domain_page() has to be used.
> 
> This is based on the x86 version [1] that was originally implemented
> by Wei Liu.
> 
> The PMAP infrastructure is implemented in common code with some
> arch helpers to set/clear the page-table entries and convertion
> between a fixmap slot to a virtual address...
> 
> As mfn_to_xen_entry() now needs to be exported, take the opportunity
> to swich the parameter attr from unsigned to unsigned int.
> 
> [1] <e92da4ad6015b6089737fcccba3ec1d6424649a5.1588278317.git.hongyxia@amazon.com>
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Hongyan Xia <hongyxia@amazon.com>
> [julien: Adapted for Arm]
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v3:
>         - s/BITS_PER_LONG/BITS_PER_BYTE/
>         - Move pmap to common code
> 
>     Changes in v2:
>         - New patch
> 
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Wei Liu <wl@xen.org>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Roger Pau Monné <roger.pau@citrix.com>
> ---
>  xen/arch/arm/Kconfig              |  1 +
>  xen/arch/arm/include/asm/fixmap.h | 17 +++++++
>  xen/arch/arm/include/asm/lpae.h   |  8 ++++
>  xen/arch/arm/include/asm/pmap.h   | 33 +++++++++++++
>  xen/arch/arm/mm.c                 |  7 +--
>  xen/common/Kconfig                |  3 ++
>  xen/common/Makefile               |  1 +
>  xen/common/pmap.c                 | 79 +++++++++++++++++++++++++++++++
>  xen/include/xen/pmap.h            | 16 +++++++
>  9 files changed, 159 insertions(+), 6 deletions(-)
>  create mode 100644 xen/arch/arm/include/asm/pmap.h
>  create mode 100644 xen/common/pmap.c
>  create mode 100644 xen/include/xen/pmap.h
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4d3..a89a67802aa9 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -14,6 +14,7 @@ config ARM
>  	select HAS_DEVICE_TREE
>  	select HAS_PASSTHROUGH
>  	select HAS_PDX
> +	select HAS_PMAP
>  	select IOMMU_FORCE_PT_SHARE
>  
>  config ARCH_DEFCONFIG
> diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h
> index 1cee51e52ab9..c46a15e59de4 100644
> --- a/xen/arch/arm/include/asm/fixmap.h
> +++ b/xen/arch/arm/include/asm/fixmap.h
> @@ -5,12 +5,20 @@
>  #define __ASM_FIXMAP_H
>  
>  #include <xen/acpi.h>
> +#include <xen/pmap.h>
>  
>  /* Fixmap slots */
>  #define FIXMAP_CONSOLE  0  /* The primary UART */
>  #define FIXMAP_MISC     1  /* Ephemeral mappings of hardware */
>  #define FIXMAP_ACPI_BEGIN  2  /* Start mappings of ACPI tables */
>  #define FIXMAP_ACPI_END    (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1)  /* End mappings of ACPI tables */
> +#define FIXMAP_PMAP_BEGIN (FIXMAP_ACPI_END + 1) /* Start of PMAP */
> +#define FIXMAP_PMAP_END (FIXMAP_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of PMAP */
> +
> +#define FIXMAP_LAST FIXMAP_PMAP_END
> +
> +#define FIXADDR_START FIXMAP_ADDR(0)
> +#define FIXADDR_TOP FIXMAP_ADDR(FIXMAP_LAST)
>  
>  #ifndef __ASSEMBLY__
>  
> @@ -19,6 +27,15 @@ extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
>  /* Remove a mapping from a fixmap entry */
>  extern void clear_fixmap(unsigned map);
>  
> +#define fix_to_virt(slot) ((void *)FIXMAP_ADDR(slot))
> +
> +static inline unsigned int virt_to_fix(vaddr_t vaddr)
> +{
> +    BUG_ON(vaddr >= FIXADDR_TOP || vaddr < FIXADDR_START);
> +
> +    return ((vaddr - FIXADDR_START) >> PAGE_SHIFT);
> +}
> +
>  #endif /* __ASSEMBLY__ */
>  
>  #endif /* __ASM_FIXMAP_H */
> diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h
> index 8cf932b5c947..6099037da1c0 100644
> --- a/xen/arch/arm/include/asm/lpae.h
> +++ b/xen/arch/arm/include/asm/lpae.h
> @@ -4,6 +4,7 @@
>  #ifndef __ASSEMBLY__
>  
>  #include <xen/page-defs.h>
> +#include <xen/mm-frame.h>
>  
>  /*
>   * WARNING!  Unlike the x86 pagetable code, where l1 is the lowest level and
> @@ -168,6 +169,13 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
>          third_table_offset(addr)            \
>      }
>  
> +/*
> + * Standard entry type that we'll use to build Xen's own pagetables.
> + * We put the same permissions at every level, because they're ignored
> + * by the walker in non-leaf entries.
> + */
> +lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr);
> +
>  #endif /* __ASSEMBLY__ */
>  
>  /*
> diff --git a/xen/arch/arm/include/asm/pmap.h b/xen/arch/arm/include/asm/pmap.h
> new file mode 100644
> index 000000000000..70eafe2891d7
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/pmap.h
> @@ -0,0 +1,33 @@
> +#ifndef __ASM_PMAP_H__
> +#define __ASM_PMAP_H__
> +
> +#include <xen/mm.h>
> +
> +/* XXX: Find an header to declare it */
> +extern lpae_t xen_fixmap[XEN_PT_LPAE_ENTRIES];

Why not fixmap.h?

The rest of the ARM stuff looks fine.


> +static inline void arch_pmap_map(unsigned int slot, mfn_t mfn)
> +{
> +    lpae_t *entry = &xen_fixmap[slot];
> +    lpae_t pte;
> +
> +    ASSERT(!lpae_is_valid(*entry));
> +
> +    pte = mfn_to_xen_entry(mfn, PAGE_HYPERVISOR_RW);
> +    pte.pt.table = 1;
> +    write_pte(entry, pte);
> +}
> +
> +static inline void arch_pmap_unmap(unsigned int slot)
> +{
> +    lpae_t pte = {};
> +
> +    write_pte(&xen_fixmap[slot], pte);
> +
> +    flush_xen_tlb_range_va_local(FIXMAP_ADDR(slot), PAGE_SIZE);
> +}
> +
> +void arch_pmap_map_slot(unsigned int slot, mfn_t mfn);
> +void arch_pmap_clear_slot(void *ptr);
> +
> +#endif /* __ASM_PMAP_H__ */
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index d6a4b9407c43..b7942464d4de 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -290,12 +290,7 @@ void dump_hyp_walk(vaddr_t addr)
>      dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1);
>  }
>  
> -/*
> - * Standard entry type that we'll use to build Xen's own pagetables.
> - * We put the same permissions at every level, because they're ignored
> - * by the walker in non-leaf entries.
> - */
> -static inline lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned attr)
> +lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr)
>  {
>      lpae_t e = (lpae_t) {
>          .pt = {
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index db687b1785e7..b6c55af2eb03 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -49,6 +49,9 @@ config HAS_KEXEC
>  config HAS_PDX
>  	bool
>  
> +config HAS_PMAP
> +	bool
> +
>  config HAS_SCHED_GRANULARITY
>  	bool
>  
> diff --git a/xen/common/Makefile b/xen/common/Makefile
> index ca839118e4d1..8b42b0828134 100644
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -28,6 +28,7 @@ obj-y += multicall.o
>  obj-y += notifier.o
>  obj-y += page_alloc.o
>  obj-$(CONFIG_HAS_PDX) += pdx.o
> +obj-bin-$(CONFIG_HAS_PMAP) += pmap.init.o
>  obj-$(CONFIG_PERF_COUNTERS) += perfc.o
>  obj-y += preempt.o
>  obj-y += random.o
> diff --git a/xen/common/pmap.c b/xen/common/pmap.c
> new file mode 100644
> index 000000000000..cea730ead545
> --- /dev/null
> +++ b/xen/common/pmap.c
> @@ -0,0 +1,79 @@
> +#include <xen/bitops.h>
> +#include <xen/init.h>
> +#include <xen/pmap.h>
> +
> +#include <asm/pmap.h>
> +#include <asm/fixmap.h>
> +
> +/*
> + * Simple mapping infrastructure to map / unmap pages in fixed map.
> + * This is used to set up the page table for mapcache, which is used
> + * by map domain page infrastructure.
> + *
> + * This structure is not protected by any locks, so it must not be used after
> + * smp bring-up.
> + */
> +
> +/* Bitmap to track which slot is used */
> +static unsigned long __initdata inuse;
> +
> +void *__init pmap_map(mfn_t mfn)
> +{
> +    unsigned long flags;
> +    unsigned int idx;
> +    unsigned int slot;
> +
> +    BUILD_BUG_ON(sizeof(inuse) * BITS_PER_BYTE < NUM_FIX_PMAP);
> +
> +    ASSERT(system_state < SYS_STATE_smp_boot);
> +
> +    local_irq_save(flags);
> +
> +    idx = find_first_zero_bit(&inuse, NUM_FIX_PMAP);
> +    if ( idx == NUM_FIX_PMAP )
> +        panic("Out of PMAP slots\n");
> +
> +    __set_bit(idx, &inuse);
> +
> +    slot = idx + FIXMAP_PMAP_BEGIN;
> +    ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END);
> +
> +    /*
> +     * We cannot use set_fixmap() here. We use PMAP when there is no direct map,
> +     * so map_pages_to_xen() called by set_fixmap() needs to map pages on
> +     * demand, which then calls pmap() again, resulting in a loop. Modify the
> +     * PTEs directly instead. The same is true for pmap_unmap().
> +     */
> +    arch_pmap_map(slot, mfn);
> +
> +    local_irq_restore(flags);
> +
> +    return fix_to_virt(slot);
> +}
> +
> +void __init pmap_unmap(const void *p)
> +{
> +    unsigned long flags;
> +    unsigned int idx;
> +    unsigned int slot = virt_to_fix((unsigned long)p);
> +
> +    ASSERT(system_state < SYS_STATE_smp_boot);
> +    ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END);
> +
> +    idx = slot - FIXMAP_PMAP_BEGIN;
> +    local_irq_save(flags);
> +
> +    __clear_bit(idx, &inuse);
> +    arch_pmap_unmap(slot);
> +
> +    local_irq_restore(flags);
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/xen/pmap.h b/xen/include/xen/pmap.h
> new file mode 100644
> index 000000000000..93e61b10870e
> --- /dev/null
> +++ b/xen/include/xen/pmap.h
> @@ -0,0 +1,16 @@
> +#ifndef __XEN_PMAP_H__
> +#define __XEN_PMAP_H__
> +
> +/* Large enough for mapping 5 levels of page tables with some headroom */
> +#define NUM_FIX_PMAP 8
> +
> +#ifndef __ASSEMBLY__
> +
> +#include <xen/mm-frame.h>
> +
> +void *pmap_map(mfn_t mfn);
> +void pmap_unmap(const void *p);
> +
> +#endif /* __ASSEMBLY__ */
> +
> +#endif /* __XEN_PMAP_H__ */
> -- 
> 2.32.0
> 
--8323329-878656267-1649194027=:2910984--


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 21:29:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 21:29:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299300.509917 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqkG-0007tF-Tw; Tue, 05 Apr 2022 21:29:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299300.509917; Tue, 05 Apr 2022 21:29:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqkG-0007t8-QE; Tue, 05 Apr 2022 21:29:48 +0000
Received: by outflank-mailman (input) for mailman id 299300;
 Tue, 05 Apr 2022 21:29:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbqkF-0007t2-Jy
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 21:29:47 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 836d19ad-b527-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 23:29:46 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1A08F60B27;
 Tue,  5 Apr 2022 21:29:45 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E57E7C385A0;
 Tue,  5 Apr 2022 21:29:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 836d19ad-b527-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649194184;
	bh=c51LbxwDI/FcwYFKGIeVEXxJA62Vsl9SruHiV2DaCcg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZOclNNf79KKqisU5KkDbtOfxUAXYJhHyw1NynRQtprV53R+NbkxTyn9WPOUy+Wy+J
	 HQCTZ4y+6Uk05GY8x2cojuC8vj3wccR2Gswt0/y4ymRBQ//KtQstFq0ZbSm1aH8qLg
	 PK1r2NWMLHPp9bkgkbh0ZaFoyjtFv78pjw4r8/Gz77bN/TIpGcyCRUWfPtDHS5NcC6
	 W26Rzlp3GSsQ2X9D5vHn+pmOHUgivWKmHxOhgq0tgAr+ecv2nOjq938VR5VvkhFxCD
	 BaRUaSi5bCsaqdTPEx4El2bJWCAhs4UWzfU2sVEDFtEjQ1d6aTqNLnkXSapL34CZAE
	 JTrNVpCy01jQA==
Date: Tue, 5 Apr 2022 14:29:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 15/19] xen/arm: mm: Clean-up the includes and order
 them
In-Reply-To: <20220221102218.33785-16-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051428150.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-16-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> The numbers of includes in mm.c has been growing quite a lot. However
> some of them (e.g. xen/device_tree.h, xen/softirq.h) doesn't look
> to be directly used by the file or other will be included by
> larger headers (e.g asm/flushtlb.h will be included by xen/mm.h).
> 
> So trim down the number of includes. Take the opportunity to order
> them with the xen headers first, then asm headers and last public
> headers.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

I'll trust you on this one :-)

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>     Changes in v3:
>         - Patch added
> ---
>  xen/arch/arm/mm.c | 27 ++++++++++-----------------
>  1 file changed, 10 insertions(+), 17 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index b7942464d4de..659bdf25e0ff 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -17,33 +17,26 @@
>   * GNU General Public License for more details.
>   */
>  
> -#include <xen/compile.h>
> -#include <xen/types.h>
> -#include <xen/device_tree.h>
> -#include <xen/init.h>
> -#include <xen/mm.h>
> -#include <xen/preempt.h>
> +#include <xen/domain_page.h>
>  #include <xen/errno.h>
>  #include <xen/grant_table.h>
> -#include <xen/softirq.h>
> -#include <xen/event.h>
>  #include <xen/guest_access.h>
> -#include <xen/domain_page.h>
> -#include <xen/err.h>
> -#include <asm/page.h>
> -#include <asm/current.h>
> -#include <asm/flushtlb.h>
> -#include <public/memory.h>
> +#include <xen/init.h>
> +#include <xen/libfdt/libfdt.h>
> +#include <xen/mm.h>
> +#include <xen/pfn.h>
>  #include <xen/sched.h>
> +#include <xen/sizes.h>
> +#include <xen/types.h>
>  #include <xen/vmap.h>
> +
>  #include <xsm/xsm.h>
> -#include <xen/pfn.h>
> -#include <xen/sizes.h>
> -#include <xen/libfdt/libfdt.h>
>  
>  #include <asm/fixmap.h>
>  #include <asm/setup.h>
>  
> +#include <public/memory.h>
> +
>  /* Override macros from asm/page.h to make them work with mfn_t */
>  #undef virt_to_mfn
>  #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 21:32:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 21:32:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299304.509928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqn8-0000q8-BW; Tue, 05 Apr 2022 21:32:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299304.509928; Tue, 05 Apr 2022 21:32:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqn8-0000q1-89; Tue, 05 Apr 2022 21:32:46 +0000
Received: by outflank-mailman (input) for mailman id 299304;
 Tue, 05 Apr 2022 21:32:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbqn6-0000pr-Ve; Tue, 05 Apr 2022 21:32:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbqn6-00029J-Sv; Tue, 05 Apr 2022 21:32:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbqn6-0003wF-B0; Tue, 05 Apr 2022 21:32:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbqn6-00024r-8N; Tue, 05 Apr 2022 21:32:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pQ4jRq8/ddAJCYplC19A4/tatTYT7eIXZaz5hVOPt3U=; b=xTkmNQ7FdLbiXw6kDoGbUHHWLS
	RSJ+9wt3G6LP0MRr71k9im0usC6khNpKPxJTRY5eCf2JT2gq0/vQvusOBQBbmWub5KtirxeWjJpK5
	i03qvYff1FAXHkSQb3t3TIaiYwgGtJAsKTG77cqaTX2r+h55yizVLEzj0gsrTOcDmOZE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169174-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169174: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3123109284176b1532874591f7c81f3837bbdc17
X-Osstest-Versions-That:
    linux=09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 21:32:44 +0000

flight 169174 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169174/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 169145
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169145
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169145
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169145
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169145
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169145
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169145
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169145
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3123109284176b1532874591f7c81f3837bbdc17
baseline version:
 linux                09bb8856d4a7cf3128dedd79cd07d75bbf4a9f04

Last test of basis   169145  2022-04-03 20:41:35 Z    2 days
Testing same since   169157  2022-04-04 06:23:01 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   09bb8856d4a7..312310928417  3123109284176b1532874591f7c81f3837bbdc17 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 21:36:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 21:36:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299312.509939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqqP-0001TM-Sm; Tue, 05 Apr 2022 21:36:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299312.509939; Tue, 05 Apr 2022 21:36:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbqqP-0001TF-PU; Tue, 05 Apr 2022 21:36:09 +0000
Received: by outflank-mailman (input) for mailman id 299312;
 Tue, 05 Apr 2022 21:36:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbqqO-0001T9-9x
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 21:36:08 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6659cb40-b528-11ec-a405-831a346695d4;
 Tue, 05 Apr 2022 23:36:07 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id AF579615E4;
 Tue,  5 Apr 2022 21:36:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C03B0C385A0;
 Tue,  5 Apr 2022 21:36:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6659cb40-b528-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649194565;
	bh=A1Svenx4PsK0pc30u81MC9+wbZyh2+W/pfbmLBwA5T8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=C1YnO4Nbztc7CakuTaTEBcF0qQy9cWpy7mptOPOyoA6NtzXph0pBhLmNtMGEjEdL0
	 +d+80GBqegFJ5FonDJ+75wEo5jw2UJtAw7S0aN7j5OlfFSyQpD984/gp0utVgkY4oR
	 8oc493te3piGcHq6MoZ4WHe1RLiYlBqLyE3zt7/NzR2sQh/wZSP51CF17daO98XhE3
	 5O1Fg/6n3avGSHUHDOmmrqBYUkB8phwj+LOALH9xeJ188B7RjFBbqAd/3Jy/TzZqFP
	 f6EBtrvw9h/YftcDa44fZYkLsIHXNtySCh19dgQMEuIePbx6stMPIzGc5RwwEJUkOS
	 5SI4m3mJlOpoA==
Date: Tue, 5 Apr 2022 14:36:04 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 16/19] xen/arm: mm: Use the PMAP helpers in
 xen_{,un}map_table()
In-Reply-To: <20220221102218.33785-17-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051435370.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-17-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> During early boot, it is not possible to use xen_{,un}map_table()
> if the page tables are not residing the Xen binary.
> 
> This is a blocker to switch some of the helpers to use xen_pt_update()
> as we may need to allocate extra page tables and access them before
> the domheap has been initialized (see setup_xenheap_mappings()).
> 
> xen_{,un}map_table() are now updated to use the PMAP helpers for early
> boot map/unmap. Note that the special case for page-tables residing
> in Xen binary has been dropped because it is "complex" and was
> only added as a workaround in 8d4f1b8878e0 ("xen/arm: mm: Allow
> generic xen page-tables helpers to be called early").
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>


Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>     Changes in v2:
>         - New patch
> ---
>  xen/arch/arm/mm.c | 33 +++++++++------------------------
>  1 file changed, 9 insertions(+), 24 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 659bdf25e0ff..11b6b60a2bc1 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -25,6 +25,7 @@
>  #include <xen/libfdt/libfdt.h>
>  #include <xen/mm.h>
>  #include <xen/pfn.h>
> +#include <xen/pmap.h>
>  #include <xen/sched.h>
>  #include <xen/sizes.h>
>  #include <xen/types.h>
> @@ -964,27 +965,11 @@ void *ioremap(paddr_t pa, size_t len)
>  static lpae_t *xen_map_table(mfn_t mfn)
>  {
>      /*
> -     * We may require to map the page table before map_domain_page() is
> -     * useable. The requirements here is it must be useable as soon as
> -     * page-tables are allocated dynamically via alloc_boot_pages().
> -     *
> -     * We need to do the check on physical address rather than virtual
> -     * address to avoid truncation on Arm32. Therefore is_kernel() cannot
> -     * be used.
> +     * During early boot, map_domain_page() may be unusable. Use the
> +     * PMAP to map temporarily a page-table.
>       */
>      if ( system_state == SYS_STATE_early_boot )
> -    {
> -        if ( is_xen_fixed_mfn(mfn) )
> -        {
> -            /*
> -             * It is fine to demote the type because the size of Xen
> -             * will always fit in vaddr_t.
> -             */
> -            vaddr_t offset = mfn_to_maddr(mfn) - virt_to_maddr(&_start);
> -
> -            return (lpae_t *)(XEN_VIRT_START + offset);
> -        }
> -    }
> +        return pmap_map(mfn);
>  
>      return map_domain_page(mfn);
>  }
> @@ -993,12 +978,12 @@ static void xen_unmap_table(const lpae_t *table)
>  {
>      /*
>       * During early boot, xen_map_table() will not use map_domain_page()
> -     * for page-tables residing in Xen binary. So skip the unmap part.
> +     * but the PMAP.
>       */
> -    if ( system_state == SYS_STATE_early_boot && is_kernel(table) )
> -        return;
> -
> -    unmap_domain_page(table);
> +    if ( system_state == SYS_STATE_early_boot )
> +        pmap_unmap(table);
> +    else
> +        unmap_domain_page(table);
>  }
>  
>  static int create_xen_table(lpae_t *entry)
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 21:47:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 21:47:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299316.509950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbr17-0002z9-Vl; Tue, 05 Apr 2022 21:47:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299316.509950; Tue, 05 Apr 2022 21:47:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbr17-0002z2-Qy; Tue, 05 Apr 2022 21:47:13 +0000
Received: by outflank-mailman (input) for mailman id 299316;
 Tue, 05 Apr 2022 21:47:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nbr16-0002yw-4e
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 21:47:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nbr14-0002QE-K7; Tue, 05 Apr 2022 21:47:10 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nbr14-0002ug-DZ; Tue, 05 Apr 2022 21:47:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=WkCMBdUkRg0ng2tZBdBpDn0ZoEa3DBuyOHtbCvIM7fM=; b=wJrsPCaV+yxIuCZsNBxrmT7qgK
	FLTy/9o4BZ0ALuWG8tQBga+VVYdrgHGBhWWgqVsfn4lEk8GHMov00RaG+CR0dyQpSJOOH1wZqEw4h
	hboHQKDyips2bFpqtaD5+VWPo0cxU2EEez6pIOIea3SvnA4B+9aDAaEmuSqsVh6nBnrw=;
Message-ID: <ddfdefed-21e6-06ee-182b-731fd130794a@xen.org>
Date: Tue, 5 Apr 2022 22:47:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-14-julien@xen.org>
 <alpine.DEB.2.22.394.2204051411510.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 13/19] xen/arm: Move fixmap definitions in a separate
 header
In-Reply-To: <alpine.DEB.2.22.394.2204051411510.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 05/04/2022 22:12, Stefano Stabellini wrote:
>> +/* Map a page in a fixmap entry */
>> +extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
>> +/* Remove a mapping from a fixmap entry */
>> +extern void clear_fixmap(unsigned map);
>> +
>> +#endif /* __ASSEMBLY__ */
>> +
>> +#endif /* __ASM_FIXMAP_H */
> 
> 
> It is a good idea to create fixmap.h, but I think it should be acpi.h to
> include fixmap.h, not the other way around.

As I wrote in the commit message, one definition in fixmap.h rely on 
define from acpi.h (i.e NUM_FIXMAP_ACPI_PAGES). So if we don't include 
it, then user of FIXMAP_PMAP_BEGIN (see next patch) will requires to 
include acpi.h in order to build.

Re-ordering the values would not help because the problem would exactly 
be the same but this time the acpi users would have to include pmap.h to 
define NUM_FIX_PMAP.

> 
> The appended changes build correctly on top of this patch.

That's expected because all the users of FIXMAP_ACPI_END will be 
including acpi.h. But after the next patch, we would need pmap.c to 
include acpi.h.

I don't think this would be right (and quite likely you would ask why
this is done). Hence this approach.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 21:50:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 21:50:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299321.509960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbr41-0004SI-Ek; Tue, 05 Apr 2022 21:50:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299321.509960; Tue, 05 Apr 2022 21:50:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbr41-0004SB-Bk; Tue, 05 Apr 2022 21:50:13 +0000
Received: by outflank-mailman (input) for mailman id 299321;
 Tue, 05 Apr 2022 21:50:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbr3z-0004S1-C5
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 21:50:11 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5cd20014-b52a-11ec-8fbc-03012f2f19d4;
 Tue, 05 Apr 2022 23:50:10 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A7603B81F72;
 Tue,  5 Apr 2022 21:50:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E531AC385A1;
 Tue,  5 Apr 2022 21:50:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cd20014-b52a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649195407;
	bh=98Oczl+Cemt9on2evQm3vjoUysUyGYL/MpUuzYtn7TE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=WSO4lAuLxwdCGJIiiJAvImUjNB2WSVx4SPRTLEBx84BsZlcWvSTcnXmkWZSWMomPG
	 3RCamX13js0bl3Q0pSmaQtEInwmSgFmby/heWWYcIQdDJ461f88NCr6bfOpzvqyREM
	 4wmybBwxAzXjnPJTjAZeldlXFmAVfOEMXx0DINWzJ4d/f5zs2tZOc4jBgChvXsv50H
	 rXUUyWXTRoHdcYTnHroYj0veMad5Lmc2yOgy08FvMJjXFNgkqKndM0Dsaj3gM+45w4
	 aaGPkYpq2Uy/3QwLwTpRTggl95ee8d6ap4xxHzYg3ibrQm0SWY7j40lVZVYVtM+ptU
	 DqvuNBLUHnUsw==
Date: Tue, 5 Apr 2022 14:50:06 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 17/19] xen/arm64: mm: Add memory to the boot allocator
 first
In-Reply-To: <20220221102218.33785-18-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051444220.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-18-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Currently, memory is added to the boot allocator after the xenheap
> mappings are done. This will break if the first mapping is more than
> 512GB of RAM.
> 
> In addition to that, a follow-up patch will rework setup_xenheap_mappings()
> to use smaller mappings (e.g. 2MB, 4KB). So it will be necessary to have
> memory in the boot allocator earlier.
> 
> Only free memory (e.g. not reserved or modules) can be added to the boot
> allocator. It might be possible that some regions (including the first
> one) will have no free memory.
> 
> So we need to add all the free memory to the boot allocator first
> and then add do the mappings.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v3:
>         - Patch added
> ---
>  xen/arch/arm/setup.c | 63 +++++++++++++++++++++++++++++---------------
>  1 file changed, 42 insertions(+), 21 deletions(-)
> 
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index d5d0792ed48a..777cf96639f5 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -767,30 +767,18 @@ static void __init setup_mm(void)
>      init_staticmem_pages();
>  }
>  #else /* CONFIG_ARM_64 */
> -static void __init setup_mm(void)
> +static void __init populate_boot_allocator(void)
>  {
> -    paddr_t ram_start = ~0;
> -    paddr_t ram_end = 0;
> -    paddr_t ram_size = 0;
> -    int bank;
> -
> -    init_pdx();
> +    unsigned int i;
> +    const struct meminfo *banks = &bootinfo.mem;
>  
> -    total_pages = 0;
> -    for ( bank = 0 ; bank < bootinfo.mem.nr_banks; bank++ )
> +    for ( i = 0; i < banks->nr_banks; i++ )
>      {
> -        paddr_t bank_start = bootinfo.mem.bank[bank].start;
> -        paddr_t bank_size = bootinfo.mem.bank[bank].size;
> -        paddr_t bank_end = bank_start + bank_size;
> +        const struct membank *bank = &banks->bank[i];
> +        paddr_t bank_end = bank->start + bank->size;
>          paddr_t s, e;
>  
> -        ram_size = ram_size + bank_size;
> -        ram_start = min(ram_start,bank_start);
> -        ram_end = max(ram_end,bank_end);
> -
> -        setup_xenheap_mappings(bank_start>>PAGE_SHIFT, bank_size>>PAGE_SHIFT);
> -
> -        s = bank_start;
> +        s = bank->start;
>          while ( s < bank_end )
>          {
>              paddr_t n = bank_end;
> @@ -798,9 +786,7 @@ static void __init setup_mm(void)
>              e = next_module(s, &n);
>  
>              if ( e == ~(paddr_t)0 )
> -            {
>                  e = n = bank_end;
> -            }
>  
>              if ( e > bank_end )
>                  e = bank_end;
> @@ -809,6 +795,41 @@ static void __init setup_mm(void)
>              s = n;
>          }
>      }
> +}
> +
> +static void __init setup_mm(void)
> +{
> +    const struct meminfo *banks = &bootinfo.mem;
> +    paddr_t ram_start = ~0;
> +    paddr_t ram_end = 0;
> +    paddr_t ram_size = 0;
> +    unsigned int i;
> +
> +    init_pdx();
> +
> +    /*
> +     * We need some memory to allocate the page-tables used for the xenheap
> +     * mappings. But some regions may contain memory already allocated
> +     * for other uses (e.g. modules, reserved-memory...).
> +     *
> +     * For simplify add all the free regions in the boot allocator.
> +     */

We currently have:

BUG_ON(nr_bootmem_regions == (PAGE_SIZE / sizeof(struct bootmem_region)));

Do you think we should check for the limit in populate_boot_allocator?
Or there is no need because it is unrealistic to reach it?


> +    populate_boot_allocator();
> +
> +    total_pages = 0;
> +
> +    for ( i = 0; i < banks->nr_banks; i++ )
> +    {
> +        const struct membank *bank = &banks->bank[i];
> +        paddr_t bank_end = bank->start + bank->size;
> +
> +        ram_size = ram_size + bank->size;
> +        ram_start = min(ram_start, bank->start);
> +        ram_end = max(ram_end, bank_end);
> +
> +        setup_xenheap_mappings(PFN_DOWN(bank->start),
> +                               PFN_DOWN(bank->size));
> +    }
>  
>      total_pages += ram_size >> PAGE_SHIFT;
>  
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 22:12:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 22:12:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299327.509971 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbrPk-0006z3-6s; Tue, 05 Apr 2022 22:12:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299327.509971; Tue, 05 Apr 2022 22:12:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbrPk-0006yw-42; Tue, 05 Apr 2022 22:12:40 +0000
Received: by outflank-mailman (input) for mailman id 299327;
 Tue, 05 Apr 2022 22:12:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nbrPi-0006yq-Q3
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 22:12:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nbrPi-0002rL-IW; Tue, 05 Apr 2022 22:12:38 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nbrPi-0004fY-Cy; Tue, 05 Apr 2022 22:12:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=wnQ7IEvcuWj81NnD2cWgD+0hq/h0LgXbUwyYhZR+aDw=; b=ZJGKdTOg7KoEhs/IoWWEcbmG0H
	C/RNNDPM3enk/rHVEhpxVrwmZbmCIjaHYy+Iy/dUunp2Cc5YQo/31OhfbVtK64eixPIkUMSNS8VM1
	jUP8+CduCR6N/+Q5wxWe9AnxZm4I1E+SyzyaQzzV+bdmbaYCU0cb+p4Ts7wTQcQurq4s=;
Message-ID: <bc1930c6-9264-a6b1-9956-629546cab169@xen.org>
Date: Tue, 5 Apr 2022 23:12:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-18-julien@xen.org>
 <alpine.DEB.2.22.394.2204051444220.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 17/19] xen/arm64: mm: Add memory to the boot allocator
 first
In-Reply-To: <alpine.DEB.2.22.394.2204051444220.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 05/04/2022 22:50, Stefano Stabellini wrote:
>> +static void __init setup_mm(void)
>> +{
>> +    const struct meminfo *banks = &bootinfo.mem;
>> +    paddr_t ram_start = ~0;
>> +    paddr_t ram_end = 0;
>> +    paddr_t ram_size = 0;
>> +    unsigned int i;
>> +
>> +    init_pdx();
>> +
>> +    /*
>> +     * We need some memory to allocate the page-tables used for the xenheap
>> +     * mappings. But some regions may contain memory already allocated
>> +     * for other uses (e.g. modules, reserved-memory...).
>> +     *
>> +     * For simplify add all the free regions in the boot allocator.
>> +     */
> 
> We currently have:
> 
> BUG_ON(nr_bootmem_regions == (PAGE_SIZE / sizeof(struct bootmem_region)));

This has enough space for 256 distinct regions on arm64 (512 regions on 
arm32).

> 
> Do you think we should check for the limit in populate_boot_allocator?

This patch doesn't change the number of regions added to the boot 
allocator. So if we need to check the limit then I would rather deal 
separately (see more below).

> Or there is no need because it is unrealistic to reach it?
I can't say never because history told us on some UEFI systems, there 
will be a large number of regions exposed. I haven't heard anyone that 
would hit the BUG_ON().

The problem is what do we do if we hit the limit? We could ignore all 
the regions after. However, there are potentially a risk there would not 
be enough memory to cover the boot memory allocation (regions may be 
really small).

So if we ever hit the limit, then I think we should update the boot 
allocator.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 05 22:31:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 22:31:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299331.509983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbrhR-0001Mv-Oo; Tue, 05 Apr 2022 22:30:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299331.509983; Tue, 05 Apr 2022 22:30:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbrhR-0001Mo-L7; Tue, 05 Apr 2022 22:30:57 +0000
Received: by outflank-mailman (input) for mailman id 299331;
 Tue, 05 Apr 2022 22:30:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbrhR-0001Me-0t; Tue, 05 Apr 2022 22:30:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbrhQ-0003Am-Qn; Tue, 05 Apr 2022 22:30:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbrhQ-00089W-BO; Tue, 05 Apr 2022 22:30:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbrhQ-0006Zm-6e; Tue, 05 Apr 2022 22:30:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EMIxKsQrdsJfukigmZbe4IQU9d+mx/F4U8XIR2YOjzw=; b=PckrNouDPSCMHtj8aDveBJAx5Y
	dbUm1IhyOIAsBlfgXmoiIcYchxqgfxDoTYDK4rWR8x3ur92ey2/9fB+aisd1b+KwCC4eTz9f73KfQ
	BMo+TeGFY0qC1UIv7q/C+wg6W9wqSQr6mYqKKRF8I1UPJYGUD/EBGgBetbf3wCtQ3usM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169172-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169172: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-freebsd10-amd64:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
X-Osstest-Versions-That:
    xen=e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Apr 2022 22:30:56 +0000

flight 169172 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169172/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-amd64 19 guest-localmigrate/x10  fail pass in 169163
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169163

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169163
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169163
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169163
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169163
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169163
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169163
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169163
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169163
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169163
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169163
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169163
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169163
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
baseline version:
 xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98

Last test of basis   169172  2022-04-05 04:42:27 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              fail    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Apr 05 23:57:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Apr 2022 23:57:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299370.510011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbt3H-0002Eq-HF; Tue, 05 Apr 2022 23:57:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299370.510011; Tue, 05 Apr 2022 23:57:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbt3H-0002Ej-EI; Tue, 05 Apr 2022 23:57:35 +0000
Received: by outflank-mailman (input) for mailman id 299370;
 Tue, 05 Apr 2022 23:57:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MzGd=UP=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbt3F-0002Ed-Ug
 for xen-devel@lists.xenproject.org; Tue, 05 Apr 2022 23:57:33 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28044850-b53c-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 01:57:32 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 3579A6148A;
 Tue,  5 Apr 2022 23:57:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D100C385A0;
 Tue,  5 Apr 2022 23:57:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28044850-b53c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649203050;
	bh=QNUBxYyvwNaDkLTjXx1stmeVd3v4PkZnb2Xl/dQO6zg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=mpY87VhDPcxGNEsp5KpyY+jdK2Bvb0M+bMbCgQQRJVDLx2oJtrRlET+Wm3s3nDs5X
	 PQPiqn+nzo3QP7XtoLARm/gBcQ6U/injA44tSVLskeGKsTzt9ymuFu/4+R9+LpShZh
	 mgyc6uFrv2Cvf7J3D8HRjWtTUpfNVrpu6iOOpxwwTNlk/SB0ZXQX8+e19+qXf1xi3B
	 qaoHRnWhzEcBvIvRHLH2Bkp0h+J2hBYq4YFDo7cp9WaalSywzDSpOYqhLC/bEBQ1d9
	 oifTmTNcKWprE9iv8hHcTntd2yFDB1WoMHVI3vjI7lbQs3WBAMH+QPOawq+cZPltOe
	 3lA65iDqviW5g==
Date: Tue, 5 Apr 2022 16:57:29 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 18/19] xen/arm: mm: Rework setup_xenheap_mappings()
In-Reply-To: <20220221102218.33785-19-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051657180.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-19-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
> 
> The current implementation of setup_xenheap_mappings() is using 1GB
> mappings. This can lead to unexpected result because the mapping
> may alias a non-cachable region (such as device or reserved regions).
> For more details see B2.8 in ARM DDI 0487H.a.
> 
> map_pages_to_xen() was recently reworked to allow superpage mappings,
> support contiguous mapping and deal with the use of pagge-tables before

pagetables


> they are mapped.
> 
> Most of the code in setup_xenheap_mappings() is now replaced with a
> single call to map_pages_to_xen().
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v3:
>         - Don't use 1GB mapping
>         - Re-order code in setup_mm() in a separate patch
> 
>     Changes in v2:
>         - New patch
> ---
>  xen/arch/arm/mm.c | 87 ++++++++++-------------------------------------
>  1 file changed, 18 insertions(+), 69 deletions(-)

Very good!



> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 11b6b60a2bc1..4af59375d998 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -138,17 +138,6 @@ static DEFINE_PAGE_TABLE(cpu0_pgtable);
>  static DEFINE_PAGE_TABLES(cpu0_dommap, DOMHEAP_SECOND_PAGES);
>  #endif
>  
> -#ifdef CONFIG_ARM_64
> -/* The first page of the first level mapping of the xenheap. The
> - * subsequent xenheap first level pages are dynamically allocated, but
> - * we need this one to bootstrap ourselves. */
> -static DEFINE_PAGE_TABLE(xenheap_first_first);
> -/* The zeroeth level slot which uses xenheap_first_first. Used because
> - * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't
> - * valid for a non-xenheap mapping. */
> -static __initdata int xenheap_first_first_slot = -1;
> -#endif
> -
>  /* Common pagetable leaves */
>  /* Second level page tables.
>   *
> @@ -815,77 +804,37 @@ void __init setup_xenheap_mappings(unsigned long base_mfn,
>  void __init setup_xenheap_mappings(unsigned long base_mfn,
>                                     unsigned long nr_mfns)
>  {
> -    lpae_t *first, pte;
> -    unsigned long mfn, end_mfn;
> -    vaddr_t vaddr;
> -
> -    /* Align to previous 1GB boundary */
> -    mfn = base_mfn & ~((FIRST_SIZE>>PAGE_SHIFT)-1);
> +    int rc;
>  
>      /* First call sets the xenheap physical and virtual offset. */
>      if ( mfn_eq(xenheap_mfn_start, INVALID_MFN) )
>      {
> +        unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1);
> +
>          xenheap_mfn_start = _mfn(base_mfn);
>          xenheap_base_pdx = mfn_to_pdx(_mfn(base_mfn));
> +        /*
> +         * The base address may not be aligned to the first level
> +         * size (e.g. 1GB when using 4KB pages). This would prevent
> +         * superpage mappings for all the regions because the virtual
> +         * address and machine address should both be suitably aligned.
> +         *
> +         * Prevent that by offsetting the start of the xenheap virtual
> +         * address.
> +         */
>          xenheap_virt_start = DIRECTMAP_VIRT_START +
> -            (base_mfn - mfn) * PAGE_SIZE;
> +            (base_mfn - mfn_gb) * PAGE_SIZE;
>      }

[...]

> +    rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn),
> +                          _mfn(base_mfn), nr_mfns,
> +                          PAGE_HYPERVISOR_RW | _PAGE_BLOCK);
> +    if ( rc )
> +        panic("Unable to setup the xenheap mappings.\n");


I understand the intent of the code and I like it. maddr_to_virt is
implemented as:

    return (void *)(XENHEAP_VIRT_START -
                    (xenheap_base_pdx << PAGE_SHIFT) +
                    ((ma & ma_va_bottom_mask) |
                     ((ma & ma_top_mask) >> pfn_pdx_hole_shift)));

The PDX stuff is always difficult to follow and I cannot claim that I
traced through exactly what the resulting virtual address in the mapping
would be for a given base_mfn, but the patch looks correct compared to
the previous code.


Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 00:01:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 00:01:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299374.510023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbt6k-0004J7-FI; Wed, 06 Apr 2022 00:01:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299374.510023; Wed, 06 Apr 2022 00:01:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbt6k-0004J0-Bc; Wed, 06 Apr 2022 00:01:10 +0000
Received: by outflank-mailman (input) for mailman id 299374;
 Wed, 06 Apr 2022 00:01:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbt6j-0004Iu-0d
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 00:01:09 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8606ff6-b53c-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 02:01:07 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 77A806153E;
 Wed,  6 Apr 2022 00:01:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EE0BC385A1;
 Wed,  6 Apr 2022 00:01:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8606ff6-b53c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649203265;
	bh=YRsiOAvXv96T0kIQydCrTypcdxO7NHJzaFpa8Nsqo4I=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=s+pjooaH9hX3Fty5QsVExL1BSjWbq8IUZrTmiDqVI5wVKqunRotH3uTsgjlwMgNV7
	 wjLLiIqgTZ/+S1BUvjG7REvAQun7M5AAuTspEaS+jXLccq5k4M/GP5yUSZ1Y2NaLdz
	 JW6O7W/WpISuT092jQaDsT4tKZrXJzB7NdPR++VmveAlVVvEZN6ewrZv6qIruVOOIN
	 IEM1c+BH/ThrubKwyb8dlFjKgPxHHUtWBsyHXL8STlwRtM8unwTXVC9yevxSnandUE
	 RqHg7ldyKVOJoLB2uARM7Kc7JNqXaDI1oav9bbk012MCfsbNcy5QqUWwKg1A+7jINf
	 famr058dZrXvw==
Date: Tue, 5 Apr 2022 17:01:05 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 19/19] xen/arm: mm: Re-implement setup_frame_table_mappings()
 with map_pages_to_xen()
In-Reply-To: <20220221102218.33785-20-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051700040.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-20-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 21 Feb 2022, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
> 
> Now that map_pages_to_xen() has been extended to support 2MB mappings,
> we can replace the create_mappings() call by map_pages_to_xen() call.
> 
> This has the advantage to remove the differences between 32-bit and
> 64-bit code.
> 
> Lastly remove create_mappings() as there is no more callers.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v3:
>         - Fix typo in the commit message
>         - Remove the TODO regarding contiguous bit
> 
>     Changes in v2:
>         - New patch
> ---
>  xen/arch/arm/mm.c | 63 ++++-------------------------------------------
>  1 file changed, 5 insertions(+), 58 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 4af59375d998..d73f49d5b6fc 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -354,40 +354,6 @@ void clear_fixmap(unsigned map)
>      BUG_ON(res != 0);
>  }
>  
> -/* Create Xen's mappings of memory.
> - * Mapping_size must be either 2MB or 32MB.
> - * Base and virt must be mapping_size aligned.
> - * Size must be a multiple of mapping_size.
> - * second must be a contiguous set of second level page tables
> - * covering the region starting at virt_offset. */
> -static void __init create_mappings(lpae_t *second,
> -                                   unsigned long virt_offset,
> -                                   unsigned long base_mfn,
> -                                   unsigned long nr_mfns,
> -                                   unsigned int mapping_size)
> -{
> -    unsigned long i, count;
> -    const unsigned long granularity = mapping_size >> PAGE_SHIFT;
> -    lpae_t pte, *p;
> -
> -    ASSERT((mapping_size == MB(2)) || (mapping_size == MB(32)));
> -    ASSERT(!((virt_offset >> PAGE_SHIFT) % granularity));
> -    ASSERT(!(base_mfn % granularity));
> -    ASSERT(!(nr_mfns % granularity));
> -
> -    count = nr_mfns / XEN_PT_LPAE_ENTRIES;
> -    p = second + second_linear_offset(virt_offset);
> -    pte = mfn_to_xen_entry(_mfn(base_mfn), MT_NORMAL);
> -    if ( granularity == 16 * XEN_PT_LPAE_ENTRIES )
> -        pte.pt.contig = 1;  /* These maps are in 16-entry contiguous chunks. */
> -    for ( i = 0; i < count; i++ )
> -    {
> -        write_pte(p + i, pte);
> -        pte.pt.base += 1 << XEN_PT_LPAE_SHIFT;
> -    }
> -    flush_xen_tlb_local();
> -}
> -
>  #ifdef CONFIG_DOMAIN_PAGE
>  void *map_domain_page_global(mfn_t mfn)
>  {
> @@ -846,36 +812,17 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe)
>      unsigned long frametable_size = nr_pdxs * sizeof(struct page_info);
>      mfn_t base_mfn;
>      const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32);
> -#ifdef CONFIG_ARM_64
> -    lpae_t *second, pte;
> -    unsigned long nr_second;
> -    mfn_t second_base;
> -    int i;
> -#endif
> +    int rc;
>  
>      frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps));
>      /* Round up to 2M or 32M boundary, as appropriate. */
>      frametable_size = ROUNDUP(frametable_size, mapping_size);
>      base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12));
>  
> -#ifdef CONFIG_ARM_64
> -    /* Compute the number of second level pages. */
> -    nr_second = ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT;
> -    second_base = alloc_boot_pages(nr_second, 1);
> -    second = mfn_to_virt(second_base);
> -    for ( i = 0; i < nr_second; i++ )
> -    {
> -        clear_page(mfn_to_virt(mfn_add(second_base, i)));
> -        pte = mfn_to_xen_entry(mfn_add(second_base, i), MT_NORMAL);
> -        pte.pt.table = 1;
> -        write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte);
> -    }
> -    create_mappings(second, 0, mfn_x(base_mfn), frametable_size >> PAGE_SHIFT,
> -                    mapping_size);
> -#else
> -    create_mappings(xen_second, FRAMETABLE_VIRT_START, mfn_x(base_mfn),
> -                    frametable_size >> PAGE_SHIFT, mapping_size);
> -#endif
> +    rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn,
> +                          frametable_size >> PAGE_SHIFT, PAGE_HYPERVISOR_RW);

Doesn't it need to be PAGE_HYPERVISOR_RW | _PAGE_BLOCK ?


> +    if ( rc )
> +        panic("Unable to setup the frametable mappings.\n");
>  
>      memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info));
>      memset(&frame_table[nr_pdxs], -1,
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 00:02:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 00:02:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299377.510034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbt7n-0004rS-Oi; Wed, 06 Apr 2022 00:02:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299377.510034; Wed, 06 Apr 2022 00:02:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbt7n-0004rL-LY; Wed, 06 Apr 2022 00:02:15 +0000
Received: by outflank-mailman (input) for mailman id 299377;
 Wed, 06 Apr 2022 00:02:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbt7m-0004r9-OE
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 00:02:14 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cfec1a38-b53c-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 02:02:13 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 7AA3CB81FF7;
 Wed,  6 Apr 2022 00:02:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDCA0C385A1;
 Wed,  6 Apr 2022 00:02:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfec1a38-b53c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649203331;
	bh=CAEqWD1UdDVobH0tB9NunoFeyZhUrfVGG8skkoduack=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=gzxj9Mr7xCYccx1vi+28W62PCBiye4RTX4eqJXjO6iseVD7+UM9TJH77PG6tGdVDZ
	 bMDa4EKVozTaziXw5hwVbeCtNGO80MSWhYUJp4Vebml2JH1z6NbQDhZ4L1bVKyW0iW
	 bUkqx6/6RtTZ138bsDHDpXEBdnCwuA/o3OOFNHW2NyVuUzZDMVSLF6ofGtyhhPgBvB
	 36bZTFCkki0X4IAKAnvRjAkuJKVolMSybn9+1sTEFcrPIR1A+gXJeG22+C5OgM/uWk
	 pf0RU9Hph0nAg2oxQA+rbYEs1QHVS3e9CgryXEcycaJ9n85u9lKgshCwPIm+AcsA3F
	 n6NzCd3JMTNlA==
Date: Tue, 5 Apr 2022 17:02:10 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 17/19] xen/arm64: mm: Add memory to the boot allocator
 first
In-Reply-To: <bc1930c6-9264-a6b1-9956-629546cab169@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051701550.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-18-julien@xen.org> <alpine.DEB.2.22.394.2204051444220.2910984@ubuntu-linux-20-04-desktop> <bc1930c6-9264-a6b1-9956-629546cab169@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 5 Apr 2022, Julien Grall wrote:
> On 05/04/2022 22:50, Stefano Stabellini wrote:
> > > +static void __init setup_mm(void)
> > > +{
> > > +    const struct meminfo *banks = &bootinfo.mem;
> > > +    paddr_t ram_start = ~0;
> > > +    paddr_t ram_end = 0;
> > > +    paddr_t ram_size = 0;
> > > +    unsigned int i;
> > > +
> > > +    init_pdx();
> > > +
> > > +    /*
> > > +     * We need some memory to allocate the page-tables used for the
> > > xenheap
> > > +     * mappings. But some regions may contain memory already allocated
> > > +     * for other uses (e.g. modules, reserved-memory...).
> > > +     *
> > > +     * For simplify add all the free regions in the boot allocator.
> > > +     */
> > 
> > We currently have:
> > 
> > BUG_ON(nr_bootmem_regions == (PAGE_SIZE / sizeof(struct bootmem_region)));
> 
> This has enough space for 256 distinct regions on arm64 (512 regions on
> arm32).
> 
> > 
> > Do you think we should check for the limit in populate_boot_allocator?
> 
> This patch doesn't change the number of regions added to the boot allocator.
> So if we need to check the limit then I would rather deal separately (see more
> below).
> 
> > Or there is no need because it is unrealistic to reach it?
> I can't say never because history told us on some UEFI systems, there will be
> a large number of regions exposed. I haven't heard anyone that would hit the
> BUG_ON().
> 
> The problem is what do we do if we hit the limit? We could ignore all the
> regions after. However, there are potentially a risk there would not be enough
> memory to cover the boot memory allocation (regions may be really small).
> 
> So if we ever hit the limit, then I think we should update the boot allocator.

OK, thanks for the explanation.

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 00:10:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 00:10:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299382.510044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbtFs-0006Mk-K4; Wed, 06 Apr 2022 00:10:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299382.510044; Wed, 06 Apr 2022 00:10:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbtFs-0006Md-HF; Wed, 06 Apr 2022 00:10:36 +0000
Received: by outflank-mailman (input) for mailman id 299382;
 Wed, 06 Apr 2022 00:10:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbtFr-0006MX-LQ
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 00:10:35 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fa8c27f3-b53d-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 02:10:34 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0A305B81B94;
 Wed,  6 Apr 2022 00:10:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D73BC385A1;
 Wed,  6 Apr 2022 00:10:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa8c27f3-b53d-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649203831;
	bh=pT1Nd0zZFpwy7cAKIscpZuiWMms8Pax4/HWEeLWBiKo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=VV/ZY8+RZx0SOTEMmqLGr+BPnMkI1WDdwriMJBOo8llNv6ld5Sy0z72AMVRGdwUNp
	 XmxNcHxfcLMND/WmUrO+P0ieit3WdPfcvIqfY3Dgbv1LIbmZWsjP/FDAisva8he4BD
	 IjBeIU66PTZZK70zak38sAxJs1XIIpuhYRsOFj/GqncG5OAjyjLZl2LP6l4ihqQtfQ
	 O817tgM8UaKNSmSNaApE0heDTDrznNYYbyM3IdDodcxheoyVPv3Hxa5awLTNTvjAg9
	 pH1fkht0Xeolb+L3QBjGpwXI10QXzdD8Nh1K/htRk0+7ghktnL0oZgaMERmRp5DK3O
	 9gyJ971RiQQdw==
Date: Tue, 5 Apr 2022 17:10:30 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 13/19] xen/arm: Move fixmap definitions in a separate
 header
In-Reply-To: <ddfdefed-21e6-06ee-182b-731fd130794a@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051705010.2910984@ubuntu-linux-20-04-desktop>
References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-14-julien@xen.org> <alpine.DEB.2.22.394.2204051411510.2910984@ubuntu-linux-20-04-desktop> <ddfdefed-21e6-06ee-182b-731fd130794a@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 5 Apr 2022, Julien Grall wrote:
> On 05/04/2022 22:12, Stefano Stabellini wrote:
> > > +/* Map a page in a fixmap entry */
> > > +extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
> > > +/* Remove a mapping from a fixmap entry */
> > > +extern void clear_fixmap(unsigned map);
> > > +
> > > +#endif /* __ASSEMBLY__ */
> > > +
> > > +#endif /* __ASM_FIXMAP_H */
> > 
> > 
> > It is a good idea to create fixmap.h, but I think it should be acpi.h to
> > include fixmap.h, not the other way around.
> 
> As I wrote in the commit message, one definition in fixmap.h rely on define
> from acpi.h (i.e NUM_FIXMAP_ACPI_PAGES). So if we don't include it, then user
> of FIXMAP_PMAP_BEGIN (see next patch) will requires to include acpi.h in order
> to build.
> 
> Re-ordering the values would not help because the problem would exactly be the
> same but this time the acpi users would have to include pmap.h to define
> NUM_FIX_PMAP.
> 
> > 
> > The appended changes build correctly on top of this patch.
> 
> That's expected because all the users of FIXMAP_ACPI_END will be including
> acpi.h. But after the next patch, we would need pmap.c to include acpi.h.
> 
> I don't think this would be right (and quite likely you would ask why
> this is done). Hence this approach.


I premise that I see your point and I don't feel very strongly either
way. In my opinion the fixmap is the low level "library" that others
make use of, so it should be acpi.h and pmap.h (the clients of the
library) that include fixmap.h and not the other way around.

So I would rather define NUM_FIXMAP_ACPI_PAGES and NUM_FIX_PMAP in
fixmap.h, then have both pmap.h and acpi.h include fixmap.h. It makes
more sense to me. However, I won't insist if you don't like it. Rough
patch below for reference.



diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h
index c46a15e59d..a231ebfe25 100644
--- a/xen/arch/arm/include/asm/fixmap.h
+++ b/xen/arch/arm/include/asm/fixmap.h
@@ -4,8 +4,13 @@
 #ifndef __ASM_FIXMAP_H
 #define __ASM_FIXMAP_H
 
-#include <xen/acpi.h>
-#include <xen/pmap.h>
+#include <xen/lib.h>
+#include <asm/lpae.h>
+
+#define NUM_FIXMAP_ACPI_PAGES  64
+
+/* Large enough for mapping 5 levels of page tables with some headroom */
+#define NUM_FIX_PMAP 8
 
 /* Fixmap slots */
 #define FIXMAP_CONSOLE  0  /* The primary UART */
@@ -22,6 +27,10 @@
 
 #ifndef __ASSEMBLY__
 
+#include <xen/mm-frame.h>
+
+extern lpae_t xen_fixmap[XEN_PT_LPAE_ENTRIES];
+
 /* Map a page in a fixmap entry */
 extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
 /* Remove a mapping from a fixmap entry */
diff --git a/xen/arch/arm/include/asm/pmap.h b/xen/arch/arm/include/asm/pmap.h
index 70eafe2891..31d29e021d 100644
--- a/xen/arch/arm/include/asm/pmap.h
+++ b/xen/arch/arm/include/asm/pmap.h
@@ -2,9 +2,8 @@
 #define __ASM_PMAP_H__
 
 #include <xen/mm.h>
+#include <asm/fixmap.h>
 
-/* XXX: Find an header to declare it */
-extern lpae_t xen_fixmap[XEN_PT_LPAE_ENTRIES];
 
 static inline void arch_pmap_map(unsigned int slot, mfn_t mfn)
 {
diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h
index 1b9c75e68f..afcc9d5b4f 100644
--- a/xen/include/xen/acpi.h
+++ b/xen/include/xen/acpi.h
@@ -28,12 +28,7 @@
 #define _LINUX
 #endif
 
-/*
- * Fixmap pages to reserve for ACPI boot-time tables (see
- * arch/x86/include/asm/fixmap.h or arch/arm/include/asm/fixmap.h),
- * 64 pages(256KB) is large enough for most cases.)
- */
-#define NUM_FIXMAP_ACPI_PAGES  64
+#include <asm/fixmap.h>
 
 #ifndef __ASSEMBLY__
 
diff --git a/xen/include/xen/pmap.h b/xen/include/xen/pmap.h
index 93e61b1087..aa892154c0 100644
--- a/xen/include/xen/pmap.h
+++ b/xen/include/xen/pmap.h
@@ -1,9 +1,6 @@
 #ifndef __XEN_PMAP_H__
 #define __XEN_PMAP_H__
 
-/* Large enough for mapping 5 levels of page tables with some headroom */
-#define NUM_FIX_PMAP 8
-
 #ifndef __ASSEMBLY__
 
 #include <xen/mm-frame.h>


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 00:26:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 00:26:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299386.510055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbtUe-0007zK-Va; Wed, 06 Apr 2022 00:25:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299386.510055; Wed, 06 Apr 2022 00:25:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbtUe-0007zD-Sb; Wed, 06 Apr 2022 00:25:52 +0000
Received: by outflank-mailman (input) for mailman id 299386;
 Wed, 06 Apr 2022 00:25:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbtUd-0007z7-JU
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 00:25:51 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b921ba8-b540-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 02:25:50 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 42AF66159A;
 Wed,  6 Apr 2022 00:25:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30424C385A1;
 Wed,  6 Apr 2022 00:25:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b921ba8-b540-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649204747;
	bh=O5nKSkNd807uEogC31BTplHLnny6bv478jRkQaBJIog=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=oHBHdrTvwtJiRpPIt9D+PlSOG2ABnLK+s5HUw7mNYYzXP8i3L4xR4UtQVM6iMjQOu
	 BqfY8hjWq0FnKaH3ZnqHxBy0fE1V1diLv623ul1zyDDy/+qxj5lN87mJ7+oZau9gXv
	 FEv7U3CQu046JMEPpLYCMjFTY5X8Ac+vBNZit2b+lGSjvANkJBAy+rVhfDIZA7ircr
	 xcJVKg68cvFXHJNPWNLwciHG+Ha8hHT+clZqLIfuc0oBFF3om9c5VdvmHASzLP1dOr
	 ykF8bKnqG16wXEx2kcQPumaYcqKJ8bVkOeg2sZ6MQ0CfJBjBrrpM6Mz9GCOsL1VpLW
	 j+ebmvd+kFBMA==
Date: Tue, 5 Apr 2022 17:25:46 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, 
    Volodymyr_Babchuk@epam.com, Luca Miccio <lucmiccio@gmail.com>, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v3 5/5] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204051723250.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop> <20220128213307.2822078-5-sstabellini@kernel.org> <395710eb-ba51-eb67-1519-2a949326f699@xen.org> <alpine.DEB.2.22.394.2203221821520.2910984@ubuntu-linux-20-04-desktop>
 <07fa2884-e497-250b-53ab-dd452b501920@xen.org> <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop> <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 1 Apr 2022, Julien Grall wrote:
> On 01/04/2022 01:35, Stefano Stabellini wrote:
> > > > > > +
> > > > > > +    /* Alloc magic pages */
> > > > > > +    if (alloc_magic_pages(info, &dom) != 0) {
> > > > > > +        printf("Error on alloc magic pages\n");
> > > > > > +        return 1;
> > > > > > +    }
> > > > > > +
> > > > > > +    xc_dom_gnttab_init(&dom);
> > > > > 
> > > > > This call as the risk to break the guest if the dom0 Linux doesn't
> > > > > support
> > > > > the
> > > > > acquire interface. This is because it will punch a hole in the domain
> > > > > memory
> > > > > where the grant-table may have already been mapped.
> > > > > 
> > > > > Also, this function could fails.
> > > > 
> > > > I'll check for return errors. Dom0less is for fully static
> > > > configurations so I think it is OK to return error and abort if
> > > > something unexpected happens: dom0less' main reason for being is that
> > > > there is nothing unexpected :-)
> > > Does this mean the caller will have to reboot the system if there is an
> > > error?
> > > IOW, we don't expect them to call ./init-dom0less twice.
> > 
> > Yes, exactly. I think init-dom0less could even panic. My mental model is
> > that this is an "extension" of construct_domU. Over there we just panic
> > if something is wrong and here it would be similar. The user provided a
> > wrong config and should fix it.
> 
> Ok. I think we should make explicit how it can be used.
> 
> > > > > > +
> > > > > > +    libxl_uuid_generate(&uuid);
> > > > > > +    xc_domain_sethandle(dom.xch, info->domid,
> > > > > > libxl_uuid_bytearray(&uuid));
> > > > > > +
> > > > > > +    rc = gen_stub_json_config(info->domid, &uuid);
> > > > > > +    if (rc)
> > > > > > +        err(1, "gen_stub_json_config");
> > > > > > +
> > > > > > +    rc = restore_xenstore(xsh, info, uuid, dom.xenstore_evtchn);
> > > > > > +    if (rc)
> > > > > > +        err(1, "writing to xenstore");
> > > > > > +
> > > > > > +    xs_introduce_domain(xsh, info->domid,
> > > > > > +            (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) +
> > > > > > XENSTORE_PFN_OFFSET,
> > > > > > +            dom.xenstore_evtchn);
> > > > > 
> > > > > xs_introduce_domain() can technically fails.
> > > > 
> > > > OK
> > > > 
> > > > 
> > > > > > +    return 0;
> > > > > > +}
> > > > > > +
> > > > > > +/* Check if domain has been configured in XS */
> > > > > > +static bool domain_exists(struct xs_handle *xsh, int domid)
> > > > > > +{
> > > > > > +    return xs_is_domain_introduced(xsh, domid);
> > > > > > +}
> > > > > 
> > > > > Would not this lead to initialize a domain with PV driver disabled?
> > > > 
> > > > I am not sure I understood your question, but I'll try to answer anyway.
> > > > This check is purely to distinguish dom0less guests, which needs further
> > > > initializations, from regular guests (e.g. xl guests) that don't need
> > > > any actions taken here.
> > > 
> > > Dom0less domUs can be divided in two categories based on whether they are
> > > xen
> > > aware (e.g. xen,enhanced is set).
> > > 
> > > Looking at this script, it seems to assume that all dom0less domUs are Xen
> > > aware. So it will end up to allocate Xenstore ring and call
> > > xs_introduce_domain(). I suspect the call will end up to fail because the
> > > event channel would be 0.
> > > 
> > > So did you try to use this script on a platform where there only xen aware
> > > domU and/or a mix?
> > 
> > Good idea of asking for this test. I thought I already ran that test,
> > but I did it again to be sure. Everything works OK (although the
> > xenstore page allocation is unneeded). xs_introduce_domain does not
> > fail:
> 
> Are you sure? If I pass 0 as the 4th argument (event channel), the command
> will return EINVAL. However, looking at the code you are not checking the
> return for the call. So you will continue as if it were successful.

We are not passing 0 as the 4th argument, we are passing the event
channel previously set as HVM_PARAM_STORE_EVTCHN by Xen:

    rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN,
                          &xenstore_evtchn);

Also in my working version of the series I have a check for the return
value of xs_introduce_domain (as you requested in one of your previous
reviews). So xs_introduce_domain is actually working correctly and
returning success.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 00:28:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 00:28:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299391.510067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbtXH-0000DY-GY; Wed, 06 Apr 2022 00:28:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299391.510067; Wed, 06 Apr 2022 00:28:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbtXH-0000DR-Dc; Wed, 06 Apr 2022 00:28:35 +0000
Received: by outflank-mailman (input) for mailman id 299391;
 Wed, 06 Apr 2022 00:28:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbtXG-0000DL-Nv
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 00:28:34 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7daf8555-b540-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 02:28:33 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 09D91B81C86;
 Wed,  6 Apr 2022 00:28:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34359C385A0;
 Wed,  6 Apr 2022 00:28:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7daf8555-b540-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649204911;
	bh=NxEI9ahtAvw5lxkicNuUVV3EoYSVUirGs4xAH+5ZBl4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=FVOYkFoKTZ7L0Vac4Stqx50IeoCIfXTD2YqD0HiKDVlTETq9nYmN7i3wKG2158IqJ
	 +PaB8PNNV/CZI6VtaA/p/YtH0IBjn8GJDVPaSuXLqRnJeakETo9/Nra7/41XhH3ERe
	 G0r5IEaoZn/fRh07geAY9DHjKWkZB/AMtxivYeWR+wHxeyexeXTYnTuZLh8a4AFdbM
	 f+MrXU7sFvu96WrwUFz1B12jpbqO2hJD77lx5HhnyNU8DQ/wOGbgPAm9p3+aULmGXb
	 kWm/vJ4rk3KhzQrpFuENZ+XHygv/+lXOXWa9eGKjc5xqYkelTsx/XmiQ4q6VyufLb2
	 397SChXkVX5dA==
Date: Tue, 5 Apr 2022 17:28:30 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, 
    Volodymyr_Babchuk@epam.com, Luca Miccio <lucmiccio@gmail.com>, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v3 5/5] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <2b5ef30a-5164-c685-e3bb-24dd29ad4236@suse.com>
Message-ID: <alpine.DEB.2.22.394.2204051726310.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop> <20220128213307.2822078-5-sstabellini@kernel.org> <395710eb-ba51-eb67-1519-2a949326f699@xen.org> <alpine.DEB.2.22.394.2203221821520.2910984@ubuntu-linux-20-04-desktop>
 <07fa2884-e497-250b-53ab-dd452b501920@xen.org> <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop> <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org> <2b5ef30a-5164-c685-e3bb-24dd29ad4236@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-878572871-1649204911=:2910984"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-878572871-1649204911=:2910984
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Fri, 1 Apr 2022, Juergen Gross wrote:
> On 01.04.22 12:02, Julien Grall wrote:
> > Hi Stefano,
> > 
> > On 01/04/2022 01:35, Stefano Stabellini wrote:
> > > > > > > +
> > > > > > > +    /* Alloc magic pages */
> > > > > > > +    if (alloc_magic_pages(info, &dom) != 0) {
> > > > > > > +        printf("Error on alloc magic pages\n");
> > > > > > > +        return 1;
> > > > > > > +    }
> > > > > > > +
> > > > > > > +    xc_dom_gnttab_init(&dom);
> > > > > > 
> > > > > > This call as the risk to break the guest if the dom0 Linux doesn't
> > > > > > support
> > > > > > the
> > > > > > acquire interface. This is because it will punch a hole in the
> > > > > > domain
> > > > > > memory
> > > > > > where the grant-table may have already been mapped.
> > > > > > 
> > > > > > Also, this function could fails.
> > > > > 
> > > > > I'll check for return errors. Dom0less is for fully static
> > > > > configurations so I think it is OK to return error and abort if
> > > > > something unexpected happens: dom0less' main reason for being is that
> > > > > there is nothing unexpected :-)
> > > > Does this mean the caller will have to reboot the system if there is an
> > > > error?
> > > > IOW, we don't expect them to call ./init-dom0less twice.
> > > 
> > > Yes, exactly. I think init-dom0less could even panic. My mental model is
> > > that this is an "extension" of construct_domU. Over there we just panic
> > > if something is wrong and here it would be similar. The user provided a
> > > wrong config and should fix it.
> > 
> > Ok. I think we should make explicit how it can be used.
> > 
> > > > > > > +
> > > > > > > +    libxl_uuid_generate(&uuid);
> > > > > > > +    xc_domain_sethandle(dom.xch, info->domid,
> > > > > > > libxl_uuid_bytearray(&uuid));
> > > > > > > +
> > > > > > > +    rc = gen_stub_json_config(info->domid, &uuid);
> > > > > > > +    if (rc)
> > > > > > > +        err(1, "gen_stub_json_config");
> > > > > > > +
> > > > > > > +    rc = restore_xenstore(xsh, info, uuid, dom.xenstore_evtchn);
> > > > > > > +    if (rc)
> > > > > > > +        err(1, "writing to xenstore");
> > > > > > > +
> > > > > > > +    xs_introduce_domain(xsh, info->domid,
> > > > > > > +            (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) +
> > > > > > > XENSTORE_PFN_OFFSET,
> > > > > > > +            dom.xenstore_evtchn);
> > > > > > 
> > > > > > xs_introduce_domain() can technically fails.
> > > > > 
> > > > > OK
> > > > > 
> > > > > 
> > > > > > > +    return 0;
> > > > > > > +}
> > > > > > > +
> > > > > > > +/* Check if domain has been configured in XS */
> > > > > > > +static bool domain_exists(struct xs_handle *xsh, int domid)
> > > > > > > +{
> > > > > > > +    return xs_is_domain_introduced(xsh, domid);
> > > > > > > +}
> > > > > > 
> > > > > > Would not this lead to initialize a domain with PV driver disabled?
> > > > > 
> > > > > I am not sure I understood your question, but I'll try to answer
> > > > > anyway.
> > > > > This check is purely to distinguish dom0less guests, which needs
> > > > > further
> > > > > initializations, from regular guests (e.g. xl guests) that don't need
> > > > > any actions taken here.
> > > > 
> > > > Dom0less domUs can be divided in two categories based on whether they
> > > > are xen
> > > > aware (e.g. xen,enhanced is set).
> > > > 
> > > > Looking at this script, it seems to assume that all dom0less domUs are
> > > > Xen
> > > > aware. So it will end up to allocate Xenstore ring and call
> > > > xs_introduce_domain(). I suspect the call will end up to fail because
> > > > the
> > > > event channel would be 0.
> > > > 
> > > > So did you try to use this script on a platform where there only xen
> > > > aware
> > > > domU and/or a mix?
> > > 
> > > Good idea of asking for this test. I thought I already ran that test,
> > > but I did it again to be sure. Everything works OK (although the
> > > xenstore page allocation is unneeded). xs_introduce_domain does not
> >  > fail:
> > 
> > Are you sure? If I pass 0 as the 4th argument (event channel), the command
> > will return EINVAL. However, looking at the code you are not checking the
> > return for the call. So you will continue as if it were successful.
> > 
> > So you will end up to write nodes for a domain Xenstored is not aware and
> > also set HVM_PARAM_STORE_PFN which may further confuse the guest as it may
> > try to initialize Xenstored it discovers the page.
> > 
> > > I think that's because it is usually called on all domains by the
> > > toolstack, even the ones without xenstore support in the kernel.
> > 
> > The toolstack will always allocate the event channel irrespective to whether
> > the guest will use Xenstore. So both the shared page and the event channel
> > are always valid today.
> > 
> > With your series, this will change as the event channel will not be
> > allocated when "xen,enhanced" is not set.
> > 
> > In your case, I think we may want to register the domain to xenstore but say
> > there are no connection available for the domain. Juergen, what do you
> > think?
> 
> In my opinion such a domain should not be registered with Xenstore.
> 
> At least C-xenstored should work mostly correctly. I think the
> "introduced" status is tested everywhere it should be tested.
> 
> Basically this is similar to today's status of xenstore-stubdom: it
> is never introduced, but Xenstore itself is happy with it existing. :-)
> 
> And even today the first nodes for a new domain are being created
> before the domain is officially introduced.

We could skip introducing dom0less domains that don't have
"xen,enhanced" without issues. It is easy to distinguish dom0less
domains that have "xen,enhanced" from the ones that don't have it
because only the one with "xen,enhanced" have a valid event channel set
as HVM_PARAM_STORE_EVTCHN.

So if the event channel is not valid, we can simply skip the
xs_introduce_domain call (which would probably fail anyway as Julien
pointed out).
--8323329-878572871-1649204911=:2910984--


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 00:53:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 00:53:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299396.510081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbtv3-0003aE-HC; Wed, 06 Apr 2022 00:53:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299396.510081; Wed, 06 Apr 2022 00:53:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbtv3-0003a7-ED; Wed, 06 Apr 2022 00:53:09 +0000
Received: by outflank-mailman (input) for mailman id 299396;
 Wed, 06 Apr 2022 00:53:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbtv2-0003a0-0L
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 00:53:08 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eabdfb1d-b543-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 02:53:05 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2094A6167B;
 Wed,  6 Apr 2022 00:53:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18A14C385A0;
 Wed,  6 Apr 2022 00:53:02 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eabdfb1d-b543-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649206383;
	bh=MhUB3RDJ3ag5iNWdyMPAWqcKYCZvXZsj/HUeDSlFJ6s=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=eoHXnt0uQpSsNjBhxyrCBREZUtijwp9z9NZtaU3ViPcUd+2IPvCB3bIwqlrgZviAD
	 CiEkJNk7tBwMa0iCpgXDKeMp/6K/8eKa6W/t6O6/XGcffyW+adNUocnS+t98VdvUQ1
	 GJqTd8McEZo76iJVK8bWyvfDOdlfc8O1a3BAa3YZwxcjmWlkmHAPikVzIrM82GlZbY
	 ogbWz4SlPZ4V8syQ02V1eg7hrKKkwcvW0mcfWD0FWht88gcnz4Ymeul/oYSx4r2QJV
	 DSNRq5JwpKnV2/gIUmMk4xJguwfyX5UxUTi3b0oIXscQm46uVCGouEqncvOnxEI65Y
	 xdjMZL9TRIP1g==
Date: Tue, 5 Apr 2022 17:53:02 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org, 
    jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, 
    Luca Miccio <lucmiccio@gmail.com>, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v3 5/5] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <alpine.DEB.2.22.394.2204051723250.2910984@ubuntu-linux-20-04-desktop>
Message-ID: <alpine.DEB.2.22.394.2204051729510.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2201281330520.27308@ubuntu-linux-20-04-desktop> <20220128213307.2822078-5-sstabellini@kernel.org> <395710eb-ba51-eb67-1519-2a949326f699@xen.org> <alpine.DEB.2.22.394.2203221821520.2910984@ubuntu-linux-20-04-desktop>
 <07fa2884-e497-250b-53ab-dd452b501920@xen.org> <alpine.DEB.2.22.394.2203311412490.2910984@ubuntu-linux-20-04-desktop> <94f37cdc-cce3-cd37-62bc-4310ca1b05ba@xen.org> <alpine.DEB.2.22.394.2204051723250.2910984@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 5 Apr 2022, Stefano Stabellini wrote:
> On Fri, 1 Apr 2022, Julien Grall wrote:
> > On 01/04/2022 01:35, Stefano Stabellini wrote:
> > > > > > > +
> > > > > > > +    /* Alloc magic pages */
> > > > > > > +    if (alloc_magic_pages(info, &dom) != 0) {
> > > > > > > +        printf("Error on alloc magic pages\n");
> > > > > > > +        return 1;
> > > > > > > +    }
> > > > > > > +
> > > > > > > +    xc_dom_gnttab_init(&dom);
> > > > > > 
> > > > > > This call as the risk to break the guest if the dom0 Linux doesn't
> > > > > > support
> > > > > > the
> > > > > > acquire interface. This is because it will punch a hole in the domain
> > > > > > memory
> > > > > > where the grant-table may have already been mapped.
> > > > > > 
> > > > > > Also, this function could fails.
> > > > > 
> > > > > I'll check for return errors. Dom0less is for fully static
> > > > > configurations so I think it is OK to return error and abort if
> > > > > something unexpected happens: dom0less' main reason for being is that
> > > > > there is nothing unexpected :-)
> > > > Does this mean the caller will have to reboot the system if there is an
> > > > error?
> > > > IOW, we don't expect them to call ./init-dom0less twice.
> > > 
> > > Yes, exactly. I think init-dom0less could even panic. My mental model is
> > > that this is an "extension" of construct_domU. Over there we just panic
> > > if something is wrong and here it would be similar. The user provided a
> > > wrong config and should fix it.
> > 
> > Ok. I think we should make explicit how it can be used.
> > 
> > > > > > > +
> > > > > > > +    libxl_uuid_generate(&uuid);
> > > > > > > +    xc_domain_sethandle(dom.xch, info->domid,
> > > > > > > libxl_uuid_bytearray(&uuid));
> > > > > > > +
> > > > > > > +    rc = gen_stub_json_config(info->domid, &uuid);
> > > > > > > +    if (rc)
> > > > > > > +        err(1, "gen_stub_json_config");
> > > > > > > +
> > > > > > > +    rc = restore_xenstore(xsh, info, uuid, dom.xenstore_evtchn);
> > > > > > > +    if (rc)
> > > > > > > +        err(1, "writing to xenstore");
> > > > > > > +
> > > > > > > +    xs_introduce_domain(xsh, info->domid,
> > > > > > > +            (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) +
> > > > > > > XENSTORE_PFN_OFFSET,
> > > > > > > +            dom.xenstore_evtchn);
> > > > > > 
> > > > > > xs_introduce_domain() can technically fails.
> > > > > 
> > > > > OK
> > > > > 
> > > > > 
> > > > > > > +    return 0;
> > > > > > > +}
> > > > > > > +
> > > > > > > +/* Check if domain has been configured in XS */
> > > > > > > +static bool domain_exists(struct xs_handle *xsh, int domid)
> > > > > > > +{
> > > > > > > +    return xs_is_domain_introduced(xsh, domid);
> > > > > > > +}
> > > > > > 
> > > > > > Would not this lead to initialize a domain with PV driver disabled?
> > > > > 
> > > > > I am not sure I understood your question, but I'll try to answer anyway.
> > > > > This check is purely to distinguish dom0less guests, which needs further
> > > > > initializations, from regular guests (e.g. xl guests) that don't need
> > > > > any actions taken here.
> > > > 
> > > > Dom0less domUs can be divided in two categories based on whether they are
> > > > xen
> > > > aware (e.g. xen,enhanced is set).
> > > > 
> > > > Looking at this script, it seems to assume that all dom0less domUs are Xen
> > > > aware. So it will end up to allocate Xenstore ring and call
> > > > xs_introduce_domain(). I suspect the call will end up to fail because the
> > > > event channel would be 0.
> > > > 
> > > > So did you try to use this script on a platform where there only xen aware
> > > > domU and/or a mix?
> > > 
> > > Good idea of asking for this test. I thought I already ran that test,
> > > but I did it again to be sure. Everything works OK (although the
> > > xenstore page allocation is unneeded). xs_introduce_domain does not
> > > fail:
> > 
> > Are you sure? If I pass 0 as the 4th argument (event channel), the command
> > will return EINVAL. However, looking at the code you are not checking the
> > return for the call. So you will continue as if it were successful.
> 
> We are not passing 0 as the 4th argument, we are passing the event
> channel previously set as HVM_PARAM_STORE_EVTCHN by Xen:
> 
>     rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN,
>                           &xenstore_evtchn);
> 
> Also in my working version of the series I have a check for the return
> value of xs_introduce_domain (as you requested in one of your previous
> reviews). So xs_introduce_domain is actually working correctly and
> returning success.

Sorry I didn't read carefully enough the older messages. I re-run the
tests again and I can see the issue you were describing (I am puzzled on
why I didn't see it before as I did have a check on the return value as
I wrote -- probably a mistake in my setup.)

The problem goes away if we only call xs_introduce_domain for
xen,enhanced domains (when xenstore_evtchn is valid.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 01:31:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 01:31:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299402.510095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbuWE-0000ZF-Hy; Wed, 06 Apr 2022 01:31:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299402.510095; Wed, 06 Apr 2022 01:31:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbuWE-0000Z8-Dj; Wed, 06 Apr 2022 01:31:34 +0000
Received: by outflank-mailman (input) for mailman id 299402;
 Wed, 06 Apr 2022 01:31:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vAr8=UQ=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1nbuWC-0000Z2-CI
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 01:31:32 +0000
Received: from sonic304-25.consmr.mail.gq1.yahoo.com
 (sonic304-25.consmr.mail.gq1.yahoo.com [98.137.68.206])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 476b3c3d-b549-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 03:31:30 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic304.consmr.mail.gq1.yahoo.com with HTTP; Wed, 6 Apr 2022 01:31:27 +0000
Received: by kubenode529.mail-prod1.omega.ne1.yahoo.com (VZM Hermes SMTP
 Server) with ESMTPA ID 149fb5b1fc5630c388f8b6f306422338; 
 Wed, 06 Apr 2022 01:31:23 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 476b3c3d-b549-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1649208687; bh=M50utAv4SKw76Dadh1ktNQdCUssot3FLhk4FTRVN5vc=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=KGcm7iM6aRt2rdg4dWJ1tVwHXc0crimG7FT76tDwYxoJtFY1KoyGxQUy044UP+cgxAYKDi8yqSj0ldqbgOiqC32+kasPigJbhYp+P5ZLKiW/HQl8CswUbHaZtByhPUBURTMIZiW72HCgKbS3MpoyK4aUjKwxwUQQr2Xc8Gdb+SAeyzpps4IFyZIr0P0NwgKZVC6zXpuUiXFjkisiyKJXpA5xA3Oq3Go5Bx+HNZICslgiKdD7i70wRiiwwbByVxrlFlBGyidx+AiI+scyj92zNSi/PdEEAsKOq7S3f0CkXVb34gfVKCvNuEu35muA2eVnrQe3A4NKwEK6FCDF7EsMVw==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649208687; bh=im/TSAB8tGI4Y39psC0Z8KOTPpzONjUnVLFaOuDY9xN=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=b7iOuUw7qciP0Dq3/r7S1I05S2Wz2WeCzAFiwjUXhzOdTUZnHecLQ3tEsWAaNmQNZzGp8aUktNfNKhK1AqYsv9f9cOVU5xFITmZfoLzM95XFQYFhVsoHaQHpbXQX1b8K6fEk1mWnOZ7G4mgswpAwcyJFXknx/eu4p4xUsT78tXCdg2YhpDe08dFi0IXU+6Xv3DBPd59tPv+ax7BouFzHExfLnC8UGFmetscVRvB7WR5DcDoJxRpnUShdySdx4idM6PMwfJ/4/22EtJPeT9bK2i/BHRxIgJyZPIQM4QKD7RKARGNugKXqqaopaD8LjlikWFYs9urJuDaaAQ0xBBWXDA==
X-YMail-OSG: KPLtfN8VM1nwvOUJNg84GSjLHH01pOEDqIvL_gOjLtoaHKHRqiMmi4s1dPo2PEU
 cQ70qEtB85B4lKawEsgAIU.BhKeEqUIPx2g0IYCAGD07CIfC1pEN6ThuX8ta3rrLHe0IkyJN5uxY
 Dy6Pt.fiDZnDO2mAvMIrkZ2n4B1BlQ7tI61t8dpvJzgcYXw1I1h_ul.lKkUfjiQq5cTK2iPKW533
 04gaAmJGs7nil2QkWJEPD.ghFxIyNq5pgjp6tZmcYyMdRzz3fVCv4Yyk9QMnW4GNB7ifu2_YMuUO
 k5UQr6DtNIiuMEAtK9EUEATtmxo8ca0Og9U0rFJHzaf1WhqWHxwbqf496l8yE.KuVhJzPGMTbDbj
 GfmEcOY_luujbk7dquTxsDdLbOtYeT2P9lolZ190QDFDIKwmokOjGQOriUIZzj6Vx2ge0LbsxT.v
 CEUaeqh03E.F2HEvJzVXMdQiAIy2LBoKhXD63lHxpXvdO16rHrDKCHBn1m.xF84oEUYixk_3WaPP
 VHQObIo96w6ugr5Q7r4mHvo9Lu9KSBt4Xd2TS2Zmrdvv3YeK4ylEwL__xmlLefQuxkEWcjNUai8h
 Wkgj71mXsNBDt1KJZBxzTPLUkIpFo21utpNoO9g3c2THod9J.2eRV.DHVftoMTpPH_HKJ3RzEWEu
 gVQ93LdqXC5hkiKAusrIXD4pWGE.M46w8X.lQ2xyfYKE8PxR33upd7toY992Py4fXp83CUIlNbSZ
 fVP4eehsDwM7a3B0YOP5Ae8ytOUJLJJhSCXRY.RZdb3YgFv0NdFb_GVau9NfEJNW43.Ng89eWHaS
 OM.pgtD8bxUZnW70Foi4oF7y2p7glnmH_z5pZ2c9m_Jtp219UO1PWCygVygQRC5I32R2OS5SjNVO
 duftGI8eDxmFkYRiiQhUMsgQqF8F92WxMfirR_XuQLloOvLY8FuUDZoq8PTLqi_FbAzM3hae1RMa
 oTmWapveuYKjDYdE8esWAtHysZ4LEfHB3E2.lreOYSJ.m95wPX688vNe0Yupmma2J3OMB7fpPfAK
 pDq2kGEQevuqz3EjFLi3_6ndmIylFkJ4t5jQ_MbkeeDY7LKT0B7.UHrfeDDcR.mqfff5PCbLL12b
 0VBZZnqYtUE3.fFTMdFliSbI4B3UplA0BBogIw6lOc8O0sC7wtwQ3anJ.y8O6._fbERZUHsr0pRf
 P6Lh.Yi.3YC16dt.6iBuytJ_qFlgZlWjEDEtOeMO4cCg.cmQPv7BPqEMRQpW7EcG3PLr4KKiHXZ1
 Gxu4pVus7aZXnfWe1hHS8Pm5Z2sbTYEir9feTqlfEiMGLgVWRpXDoWB90kgVmTpy462mBgqhMYBv
 rdSsbVWFQpK_wxyH04NGsuJyzQ9vKOYlUK.qv6Q0hDrVYTiFTFsuz7Tps4M3PNLllcFaRVADFeSm
 UHibMfpjsKwR9vnLhLJuA7zH1au5Cw4gjgdkXFmxlG6RI2fAwU6ne4jQJ4e2igyMFm_h6mT_bvwp
 WKQ8MBfQxyrLAZKh0nnqvu_X7l_RkHEkycPRa1AYhFKLfKHVd1HKTKgOoydffrEVO3B9lUAfwvsL
 lscwaWgmydmtYftOBAIBF9T7VckQXmhYGEkvKXQuY5g6nKnlCmUpDsYtzF9yH._Kjlck3iTWjzU.
 3XYOlCFkb3J2GeJnIZlnIwI5KlAW7GR3XhfBTk9cHNUzKv7XX8.rQxiTkaeJw1oXsAQE3HJznOwJ
 nDvAiK5cgJ75HxovXWWobBiZWcI3.eGlokgWFArMepKuJ.ZZ_ydJLPrnRU97f.HNXf6g6Wbxsw6A
 UHp0FmVi6QCye99Px1jTiGrDcnlSCidKxQ95VsgZbwcgmQSfbTEmN5cFBTCicdRAZ2mARyF_lK89
 2cMqAR3gyuV22klKQeni3i7ThTLgIgRVcHAI1fAFsooUq8ZGPyGmV._dBc7sueXMCIunWc3EoiHJ
 sKGuImZ.IIcl49QgSLTapmNJsPRlCClX14pO8Q2Q_T1B64RrTeRqNb58MSfxJ90O0wOADfTXlQUW
 h3_EtAbachwWkFTIbaJqsvHZklyNL_g5WVzUGPGQrZonZso8l_UI4vz0QXAWVN9JtyKAlvTb2alO
 S1G_T3cNddla_vMzE1fRb17c4PIwLWhX5_GLfZp4B_9xwuXGK1GDFuzaOyr65GcEmu4hEMO87DZQ
 2mJWhMEKV.R8CThUY8SlQOiNG46srC2xsKQPTe_3MKq6J4MIf5Xt976w76.CjbGlNjIz1kqt9e5l
 NuctmNasIhw--
X-Sonic-MF: <brchuckz@aim.com>
Message-ID: <5d14eeb8-038f-e99a-31b8-f6b3b562c2c4@netscape.net>
Date: Tue, 5 Apr 2022 21:31:21 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access
 to Intel IGD opregion
Content-Language: en-US
From: Chuck Zmudzinski <brchuckz@netscape.net>
To: Jason Andryuk <jandryuk@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz.ref@netscape.net>
 <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz@netscape.net>
 <78ce5809-8df4-c94e-4313-fffb1b86b771@suse.com>
 <CAKf6xpsN+uJ=AyxtrnOrQrynFL=dwC=DdT7DHnK=wx9UFtdUDQ@mail.gmail.com>
 <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net>
In-Reply-To: <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Mailer: WebService/1.1.20050 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 6184



On 4/1/22 9:21 AM, Chuck Zmudzinski wrote:
> On 3/30/22 2:45 PM, Jason Andryuk wrote:
>> On Fri, Mar 18, 2022 at 4:13 AM Jan Beulich <jbeulich@suse.com> wrote:
>>> On 14.03.2022 04:41, Chuck Zmudzinski wrote:
>>>> When gfx_passthru is enabled for the Intel IGD, hvmloader maps the IGD
>>>> opregion to the guest but libxl does not grant the guest permission to
>>>> access the mapped memory region. This results in a crash of the 
>>>> i915.ko
>>>> kernel module in a Linux HVM guest when it needs to access the IGD
>>>> opregion:
>>>>
>>>> Oct 23 11:36:33 domU kernel: Call Trace:
>>>> Oct 23 11:36:33 domU kernel:  ? idr_alloc+0x39/0x70
>>>> Oct 23 11:36:33 domU kernel: drm_get_last_vbltimestamp+0xaa/0xc0 [drm]
>>>> Oct 23 11:36:33 domU kernel: drm_reset_vblank_timestamp+0x5b/0xd0 
>>>> [drm]
>>>> Oct 23 11:36:33 domU kernel:  drm_crtc_vblank_on+0x7b/0x130 [drm]
>>>> Oct 23 11:36:33 domU kernel: 
>>>> intel_modeset_setup_hw_state+0xbd4/0x1900 [i915]
>>>> Oct 23 11:36:33 domU kernel:  ? _cond_resched+0x16/0x40
>>>> Oct 23 11:36:33 domU kernel:  ? ww_mutex_lock+0x15/0x80
>>>> Oct 23 11:36:33 domU kernel: intel_modeset_init_nogem+0x867/0x1d30 
>>>> [i915]
>>>> Oct 23 11:36:33 domU kernel:  ? gen6_write32+0x4b/0x1c0 [i915]
>>>> Oct 23 11:36:33 domU kernel:  ? intel_irq_postinstall+0xb9/0x670 
>>>> [i915]
>>>> Oct 23 11:36:33 domU kernel:  i915_driver_probe+0x5c2/0xc90 [i915]
>>>> Oct 23 11:36:33 domU kernel:  ? 
>>>> vga_switcheroo_client_probe_defer+0x1f/0x40
>>>> Oct 23 11:36:33 domU kernel:  ? i915_pci_probe+0x3f/0x150 [i915]
>>>> Oct 23 11:36:33 domU kernel:  local_pci_probe+0x42/0x80
>>>> Oct 23 11:36:33 domU kernel:  ? _cond_resched+0x16/0x40
>>>> Oct 23 11:36:33 domU kernel:  pci_device_probe+0xfd/0x1b0
>>>> Oct 23 11:36:33 domU kernel:  really_probe+0x222/0x480
>>>> Oct 23 11:36:33 domU kernel:  driver_probe_device+0xe1/0x150
>>>> Oct 23 11:36:33 domU kernel:  device_driver_attach+0xa1/0xb0
>>>> Oct 23 11:36:33 domU kernel:  __driver_attach+0x8a/0x150
>>>> Oct 23 11:36:33 domU kernel:  ? device_driver_attach+0xb0/0xb0
>>>> Oct 23 11:36:33 domU kernel:  ? device_driver_attach+0xb0/0xb0
>>>> Oct 23 11:36:33 domU kernel:  bus_for_each_dev+0x78/0xc0
>>>> Oct 23 11:36:33 domU kernel:  bus_add_driver+0x12b/0x1e0
>>>> Oct 23 11:36:33 domU kernel:  driver_register+0x8b/0xe0
>>>> Oct 23 11:36:33 domU kernel:  ? 0xffffffffc06b8000
>>>> Oct 23 11:36:33 domU kernel:  i915_init+0x5d/0x70 [i915]
>>>> Oct 23 11:36:33 domU kernel:  do_one_initcall+0x44/0x1d0
>>>> Oct 23 11:36:33 domU kernel:  ? do_init_module+0x23/0x260
>>>> Oct 23 11:36:33 domU kernel:  ? kmem_cache_alloc_trace+0xf5/0x200
>>>> Oct 23 11:36:33 domU kernel:  do_init_module+0x5c/0x260
>>>> Oct 23 11:36:33 domU kernel: __do_sys_finit_module+0xb1/0x110
>>>> Oct 23 11:36:33 domU kernel:  do_syscall_64+0x33/0x80
>>>> Oct 23 11:36:33 domU kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9
>>> The call trace alone leaves open where exactly the crash occurred.
>>> Looking at 5.17 I notice that the first thing the driver does
>>> after mapping the range it to check the signature (both in
>>> intel_opregion_setup()). As the signature can't possibly match
>>> with no access granted to the underlying mappings, there shouldn't
>>> be any further attempts to use the region in the driver; if there
>>> are, I'd view this as a driver bug.
>> Yes.  i915_driver_hw_probe does not check the return value of
>> intel_opregion_setup(dev_priv) and just continues on.
>>
>> Chuck, the attached patch may help if you want to test it.
>>
>> Regards,
>> Jason
>
> I tested the patch - it made no noticeable difference.

Correction (sorry for the confusion):

I didn't know I needed to replace more than just a
re-built i915.ko module to enable the patch
for testing. When I updated the entire Debian kernel
package including all the modules and the kernel
image with the patched kernel package, it made
quite a difference.

With Jason's patch, the three call traces just became a
much shorter error message:

Apr 05 20:46:18 debian kernel: xen: --> pirq=16 -> irq=24 (gsi=24)
Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: [drm] VT-d active for 
gfx access
Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: vgaarb: deactivate vga 
console
Apr 05 20:46:18 debian kernel: Console: switching to colour dummy device 
80x25
Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: [drm] DMAR active, 
disabling use of stolen memory
Apr 05 20:46:18 debian kernel: resource sanity check: requesting [mem 
0xffffffff-0x100001ffe], which spans more than Reserved [mem 
0xfdfff000-0xffffffff]
Apr 05 20:46:18 debian kernel: caller memremap+0xeb/0x1c0 mapping 
multiple BARs
Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: Device initialization 
failed (-22)
Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: Please file a bug on 
drm/i915; see 
https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs 
for details.
Apr 05 20:46:18 debian kernel: i915: probe of 0000:00:02.0 failed with 
error -22
--------------------- End of Kernel Error Log ----------------------

So I think the patch does propagate the error up the
stack and bails out before producing the Call traces,

and...

I even had output after booting - the gdm3 Gnome display
manager login page displayed, but when I tried to login to
the Gnome desktop, the screen went dark and I could
not even login to the headless Xen Dom0 control domain
via ssh after that and I just used the reset button on the
machine to reboot it, so the patch causes some trouble
with the Dom0 when the guest cannot access the
opregion. The patch works fine when the guest can
access the opregion and in that case I was able to
login to the Gnome session, but it caused quite a bit of
trouble and apparently crashed the Dom0 or at
least caused networking in the Dom0 to stop working
when I tried to login to the Gnome session in the
guest for the case when the guest cannot access
the opregion. So I would not recommend Jason's
patch as is for the Linux kernel. The main reason
is that it looks like it is working at first with a
login screen displayed, but when a user tries to login,
the whole system crashes.

Regards,

Chuck


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 02:19:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 02:19:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299435.510124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbvGM-0006Wv-O1; Wed, 06 Apr 2022 02:19:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299435.510124; Wed, 06 Apr 2022 02:19:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbvGM-0006Wo-Kv; Wed, 06 Apr 2022 02:19:14 +0000
Received: by outflank-mailman (input) for mailman id 299435;
 Wed, 06 Apr 2022 02:19:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSLC=UQ=gmail.com=linmq006@srs-se1.protection.inumbo.net>)
 id 1nbvGL-0006Wi-6i
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 02:19:13 +0000
Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com
 [2607:f8b0:4864:20::52f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f2198a43-b54f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 04:19:12 +0200 (CEST)
Received: by mail-pg1-x52f.google.com with SMTP id 66so965949pga.12
 for <xen-devel@lists.xenproject.org>; Tue, 05 Apr 2022 19:19:12 -0700 (PDT)
Received: from 8345e2a12d0c ([159.226.95.43]) by smtp.gmail.com with ESMTPSA id
 f16-20020a056a00229000b004fabe756ba6sm18627715pfe.54.2022.04.05.19.19.07
 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 05 Apr 2022 19:19:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2198a43-b54f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=XgjMEhLjRT4MPAMhsdcS0Ym9ucVGsbeQUnv8qRyOX2I=;
        b=GG33N9hgu+eD/ebEhy3Uqtw42T1KOy4AZNx8zMiQ8RNnMqDR3MrKJ0yJbDK9/zahZX
         XtmX82g9WyruU473qtdYCzzuJtiRU5bvSltOqdS8XpnjIMfFtqtndkOjetDeT6d5nICG
         ArTrqu2AeWHeYKaQse/8jm14/6N+2jzKs9HxS/F2IvH4VALeAE+SZsPvFjFWefv/ScOF
         ayWSL1CW+OxpZgkOU3exCbNpR1e+35NzKgm/gbzNwD10kDdU8yuS+TO6hIXiw7MLqE54
         kPh636J/zKiCfcJsVnKkcLXxcasLEiRxsOcCxgZ7jiYVfAOpTmBtoCYkwg2cNjdc/9fT
         mN1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=XgjMEhLjRT4MPAMhsdcS0Ym9ucVGsbeQUnv8qRyOX2I=;
        b=3ONFY0mpXZQ/s27JJSaw+895q0oFsU8qS1VBoL6HmEh3lIDj9mpZbS+O2cExK+X6qY
         LahwSxOcQEviBirsU5MNcRbY0b8uY8P0PSVBbJhOjT0JJJqSbftvUqD6b9FDJuGQ2V2T
         0TFZuuZenWk0Pcp3zO+lXW4GYDzT1qZEYO6cWGi77bwUAn8zn9DkNGe8ggwMtk4BRR64
         l6L9FVA6+uFscvPnK7PDG0IFOZdPwD+beJVlcjaK/oYC+42b2ErCexI9R6UE5hU90G+I
         PZVK/kEn6oXyAhQXYDxVteFNMRCCUCGFnPM395JkrW8SctiKgEkSp8GwD1qCPS3hwDzO
         FqkA==
X-Gm-Message-State: AOAM532RKkXLbCDlWwBvrv7OwxFi2YBn1RBfIODhuyr73uXU7j3lXgIf
	rK7194kHlp2lbSO0MMml74Y=
X-Google-Smtp-Source: ABdhPJy0fFKiZnX55XY/d/G2Ja2u/Qng8hE6zvoqwunWU73cDOoodFxoYjkYZp4ZogLD3xT/xr2xew==
X-Received: by 2002:a63:d454:0:b0:386:86:6aaa with SMTP id i20-20020a63d454000000b0038600866aaamr5248075pgj.60.1649211550460;
        Tue, 05 Apr 2022 19:19:10 -0700 (PDT)
Date: Wed, 6 Apr 2022 02:19:05 +0000
From: Miaoqian Lin <linmq006@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Shannon Zhao <shannon.zhao@linaro.org>,
	Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/xen: Fix refcount leak in xen_dt_guest_init
Message-ID: <20220406021905.GA30436@8345e2a12d0c>
References: <20220309102442.14726-1-linmq006@gmail.com>
 <alpine.DEB.2.22.394.2203111756000.3497@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2203111756000.3497@ubuntu-linux-20-04-desktop>
User-Agent: Mutt/1.9.4 (2018-02-28)

Hi,

On Fri, Mar 11, 2022 at 06:01:11PM -0800, Stefano Stabellini wrote:
> On Wed, 9 Mar 2022, Miaoqian Lin wrote:
> > The of_find_compatible_node() function returns a node pointer with
> > refcount incremented, We should use of_node_put() on it when done
> > Add the missing of_node_put() to release the refcount.
> > 
> > Fixes: 9b08aaa3199a ("ARM: XEN: Move xen_early_init() before efi_init()")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> 
> Thanks for the patch!
> 
> 
> > ---
> >  arch/arm/xen/enlighten.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> > index ec5b082f3de6..262f45f686b6 100644
> > --- a/arch/arm/xen/enlighten.c
> > +++ b/arch/arm/xen/enlighten.c
> > @@ -424,6 +424,7 @@ static void __init xen_dt_guest_init(void)
> >  
> >  	if (of_address_to_resource(xen_node, GRANT_TABLE_INDEX, &res)) {
> >  		pr_err("Xen grant table region is not found\n");
> > +		of_node_put(xen_node);
> >  		return;
> >  	}
> 
> This is adding a call to of_node_put on the error path. Shouldn't it
> be called also in the non-error path?

You're right. It should be called also in the non-error path.
I made a mistake.

> Also, there is another instance of of_address_to_resource being called
> in this file (in arch_xen_unpopulated_init), does it make sense to call
> of_node_put there too?

I think so, becase device node pointer np is a local variable.
So the reference it taken should be released in the scope.

I look into the whole codebase for this kind of usage pattern
($ret=of_find_compatible_node();of_address_to_resource($ret,_,_), 
$ret is a local variable), Most of them call of_node_put() when done. 
And document of of_find_compatible_node() also mentions
> Return: A node pointer with refcount incremented, use
> of_node_put() on it when done.

But I am not sure, Since I am unfamiliar with other code logic.
It better if the developers could double check. I found some 
similar cases in arch/arm. 


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 02:21:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 02:21:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299439.510135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbvIx-0007tH-5R; Wed, 06 Apr 2022 02:21:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299439.510135; Wed, 06 Apr 2022 02:21:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbvIx-0007tA-29; Wed, 06 Apr 2022 02:21:55 +0000
Received: by outflank-mailman (input) for mailman id 299439;
 Wed, 06 Apr 2022 02:21:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nbvIu-0007t4-S3
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 02:21:53 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f8ec5ce-b550-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 04:21:48 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 7E800B81FB5;
 Wed,  6 Apr 2022 02:21:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0CDEC385A1;
 Wed,  6 Apr 2022 02:21:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f8ec5ce-b550-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649211705;
	bh=XT4LCodSquSiT8Nb1uAr9T4Gh2L8Wl5+SXM7kZaAuNQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=vRp2DZTnocPfxbZEiP3caN0Q4fWrhzHFbsC4kkNsVPO3wv1b/gzlckFXGQ2v2mFLf
	 8ni0qMMVivWL2KBruCkN5mL++HeKpUIjbyiTV4Elt7Ca+S3L6BG2b9y3P/513C4kHk
	 v9VdI4lOWCjcZpLAVPNjmzFXKnOkmtsc7SVDfjPQOUDtWdc5MJTgiKu2GWTU8b4pa4
	 VyMPAjerh/mM6+JSL+K98iKhDPVR9CGVtRajKuFOjOQrcc6FV8OhP5lt0J7vpA9Qp4
	 JonyRFep6V3blea38x6Bp0rwk4ZyPITCp17ZpJ6jlt6fD4OMa5SL8f+y6SLRK5/NjB
	 5asYhACkiWcLg==
Date: Tue, 5 Apr 2022 19:21:44 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, 
    Volodymyr_Babchuk@epam.com, Luca Miccio <lucmiccio@gmail.com>, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
Message-ID: <alpine.DEB.2.22.394.2204051758250.2910984@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop> <20220401003847.38393-8-sstabellini@kernel.org> <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org> <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1812572471-1649206970=:2910984"
Content-ID: <alpine.DEB.2.22.394.2204051802590.2910984@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1812572471-1649206970=:2910984
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204051802591.2910984@ubuntu-linux-20-04-desktop>

On Fri, 1 Apr 2022, Juergen Gross wrote:
> On 01.04.22 12:21, Julien Grall wrote:
> > Hi,
> > 
> > I have posted some comments in v3 after you sent this version. Please have a
> > look.
> > 
> > On 01/04/2022 01:38, Stefano Stabellini wrote:
> > > +static int init_domain(struct xs_handle *xsh, libxl_dominfo *info)
> > > +{
> > > +    struct xc_interface_core *xch;
> > > +    libxl_uuid uuid;
> > > +    uint64_t xenstore_evtchn, xenstore_pfn;
> > > +    int rc;
> > > +
> > > +    printf("Init dom0less domain: %u\n", info->domid);
> > > +    xch = xc_interface_open(0, 0, 0);
> > > +
> > > +    rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN,
> > > +                          &xenstore_evtchn);
> > > +    if (rc != 0) {
> > > +        printf("Failed to get HVM_PARAM_STORE_EVTCHN\n");
> > > +        return 1;
> > > +    }
> > > +
> > > +    /* Alloc xenstore page */
> > > +    if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) {
> > > +        printf("Error on alloc magic pages\n");
> > > +        return 1;
> > > +    }
> > > +
> > > +    rc = xc_dom_gnttab_seed(xch, info->domid, true,
> > > +                            (xen_pfn_t)-1, xenstore_pfn, 0, 0);
> > > +    if (rc)
> > > +        err(1, "xc_dom_gnttab_seed");
> > > +
> > > +    libxl_uuid_generate(&uuid);
> > > +    xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid));
> > > +
> > > +    rc = gen_stub_json_config(info->domid, &uuid);
> > > +    if (rc)
> > > +        err(1, "gen_stub_json_config");
> > > +
> > > +    /* Now everything is ready: set HVM_PARAM_STORE_PFN */
> > > +    rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN,
> > > +                          xenstore_pfn);
> > 
> > On patch #1, you told me you didn't want to allocate the page in Xen because
> > it wouldn't be initialized by Xenstored. But this is what we are doing here.
> 
> Xenstore (at least the C variant) is only using the fixed grant ref
> GNTTAB_RESERVED_XENSTORE, so it doesn't need the page to be advertised
> to the guest. And the mapping is done only when the domain is being
> introduced to Xenstore.
> 
> > 
> > This would be a problem if Linux is still booting and hasn't yet call
> > xenbus_probe_initcall().
> > 
> > I understand we need to have the page setup before raising the event
> > channel. I don't think we can allow Xenstored to set the HVM_PARAM (it may
> > run in a domain with less privilege). So I think we may need to create a
> > separate command to kick the client (not great).
> > 
> > Juergen, any thoughts?
> 
> I think it should work like that:
> 
> - setup the grant via xc_dom_gnttab_seed()
> - introduce the domain to Xenstore
> - call xc_hvm_param_set()
> 
> When the guest is receiving the event, it should wait for the xenstore
> page to appear.


I am OK with what you wrote above, and I understand Julien's concerns
about "waiting". Before discussing that, I would like to make sure I
understood why setting HVM_PARAM_STORE_PFN first (before
xs_introduce_domain) is not possible.

In a previous reply to Julien I wrote that it is not a good idea to
set HVM_PARAM_STORE_PFN in Xen before creating the domains because it
would cause Linux to hang at boot. That is true, Linux hangs on
drivers/xen/xenbus/xenbus_comms.c:xb_init_comms waiting on xb_waitq.
It could wait a very long time as domUs are typically a lot faster than
dom0 to boot.

However, if we set HVM_PARAM_STORE_PFN before calling
xs_introduce_domain in init-dom0less, for Linux to see it before
xs_introduce_domain is done, Linux would need to be racing against
init-dom0less. In that case, the wait in xb_init_comms would be minimal
anyway. It shouldn't be a problem. There would be no "hang", just a wait
a bit longer than usual.

Is that right?

--8323329-1812572471-1649206970=:2910984--


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 02:35:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 02:35:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299457.510202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbvW8-0001fB-30; Wed, 06 Apr 2022 02:35:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299457.510202; Wed, 06 Apr 2022 02:35:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbvW7-0001f2-Vc; Wed, 06 Apr 2022 02:35:31 +0000
Received: by outflank-mailman (input) for mailman id 299457;
 Wed, 06 Apr 2022 02:35:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbvW6-0001es-SF; Wed, 06 Apr 2022 02:35:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbvW6-0000ad-QS; Wed, 06 Apr 2022 02:35:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbvW6-0008Sb-6g; Wed, 06 Apr 2022 02:35:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbvW6-0001Uj-58; Wed, 06 Apr 2022 02:35:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ipb1T6jJsc214xmvHaxRubJhhSkRuOw1w9Yzex3p120=; b=UO2jOOznL6T7MQ0RUB8zRFoaEt
	VaDAcn8t0PujWCvFPBsYD8FpyrKO/y19vy1yzCT5wZoyn+9Ipcu0n6wJpIkEUdq0olCaBcZa+OmjG
	1zc7Ttw7q/7gJl47wW/PN5/Lh1OG2b4G5Lclh8KmAtFHEXEUJm/drIt6eybWnQzKGt0Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169178-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169178: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=aaa61028803a64e72f1026f9608dfa34d0c255ec
X-Osstest-Versions-That:
    xen=e11d98d6fc433633f702db02256042862a48ddee
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 02:35:30 +0000

flight 169178 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169178/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169162
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169162
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169162
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169162
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169162
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169162
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169162
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169162
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169162
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169162
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169162
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169162
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  aaa61028803a64e72f1026f9608dfa34d0c255ec
baseline version:
 xen                  e11d98d6fc433633f702db02256042862a48ddee

Last test of basis   169162  2022-04-04 15:39:25 Z    1 days
Testing same since   169178  2022-04-05 13:07:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e11d98d6fc..aaa6102880  aaa61028803a64e72f1026f9608dfa34d0c255ec -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 05:13:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 05:13:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299471.510219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbxyt-0001Bj-BJ; Wed, 06 Apr 2022 05:13:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299471.510219; Wed, 06 Apr 2022 05:13:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbxyt-0001Bc-82; Wed, 06 Apr 2022 05:13:23 +0000
Received: by outflank-mailman (input) for mailman id 299471;
 Wed, 06 Apr 2022 05:13:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wVRv=UQ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nbxyr-0001BW-FA
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 05:13:21 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 45129589-b568-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 07:13:18 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 49D321F390;
 Wed,  6 Apr 2022 05:13:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 30A42139F5;
 Wed,  6 Apr 2022 05:13:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8r5/Cm8hTWJIHAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 06 Apr 2022 05:13:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45129589-b568-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649221999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=4XQ/OJbAkFJxR+5TIYrC9qA43cU+f3dfj/TAAc5f8mU=;
	b=MPlbjhLfCuqNeiYnM35P1WLkwVzCC7mfH83OmtLpBY5llo2xgDxGsc6zVGADimEBO6yHGA
	K3uJYEltuP+mCh75K4BuGjZol5RFAedXNkkQylv9T3Ks66Hd35qJojE5bzq9V8CQxPRX0F
	P2bbTZpnPxAkOEW3f6FisBshqdAMylM=
Message-ID: <8e392b3c-8808-509e-adb7-f4a3c1a5c86c@suse.com>
Date: Wed, 6 Apr 2022 07:13:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: Increasing domain memory beyond initial maxmem
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <YkUlLvnEDdc5hwN4@mail-itl>
 <2684376b-3ae6-a2b7-581f-2bd38ab6056b@suse.com> <YkWYGFJ/Cl+B2C37@mail-itl>
 <362b6115-e296-e01e-520f-31a0826426eb@suse.com> <YkWgQNKK7SarjKDN@mail-itl>
 <a9325c01-f6bd-46e8-d730-3f18b71b9969@suse.com> <YkxtOxOCY8nxy0Gt@mail-itl>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <YkxtOxOCY8nxy0Gt@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------YAT1iKFDedeCClQ3ME0jlk8y"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------YAT1iKFDedeCClQ3ME0jlk8y
Content-Type: multipart/mixed; boundary="------------xIYZpBotMLjgQb45zuRGf9XE";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <8e392b3c-8808-509e-adb7-f4a3c1a5c86c@suse.com>
Subject: Re: Increasing domain memory beyond initial maxmem
References: <YkUlLvnEDdc5hwN4@mail-itl>
 <2684376b-3ae6-a2b7-581f-2bd38ab6056b@suse.com> <YkWYGFJ/Cl+B2C37@mail-itl>
 <362b6115-e296-e01e-520f-31a0826426eb@suse.com> <YkWgQNKK7SarjKDN@mail-itl>
 <a9325c01-f6bd-46e8-d730-3f18b71b9969@suse.com> <YkxtOxOCY8nxy0Gt@mail-itl>
In-Reply-To: <YkxtOxOCY8nxy0Gt@mail-itl>

--------------xIYZpBotMLjgQb45zuRGf9XE
Content-Type: multipart/mixed; boundary="------------0XOQvze0parJHpzZQla96R02"

--------------0XOQvze0parJHpzZQla96R02
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMDQuMjIgMTg6MjQsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gVHVlLCBBcHIgMDUsIDIwMjIgYXQgMDE6MDM6NTdQTSArMDIwMCwgSnVlcmdlbiBH
cm9zcyB3cm90ZToNCj4+IEhpIE1hcmVrLA0KPj4NCj4+IE9uIDMxLjAzLjIyIDE0OjM2LCBN
YXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgd3JvdGU6DQo+Pj4gT24gVGh1LCBNYXIgMzEs
IDIwMjIgYXQgMDI6MjI6MDNQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4g
TWF5YmUgc29tZSBrZXJuZWwgY29uZmlnIGRpZmZlcmVuY2VzLCBvciBvdGhlciB1ZGV2IHJ1
bGVzIChtZW1vcnkgb25saW5pbmcNCj4+Pj4gaXMgZG9uZSB2aWEgdWRldiBpbiBteSBndWVz
dCk/DQo+Pj4+DQo+Pj4+IEknbSBzZWVpbmc6DQo+Pj4+DQo+Pj4+ICMgemdyZXAgTUVNT1JZ
X0hPVFBMVUcgL3Byb2MvY29uZmlnLmd6DQo+Pj4+IENPTkZJR19BUkNIX0VOQUJMRV9NRU1P
UllfSE9UUExVRz15DQo+Pj4+IENPTkZJR19NRU1PUllfSE9UUExVRz15DQo+Pj4+ICMgQ09O
RklHX01FTU9SWV9IT1RQTFVHX0RFRkFVTFRfT05MSU5FIGlzIG5vdCBzZXQNCj4+Pj4gQ09O
RklHX1hFTl9CQUxMT09OX01FTU9SWV9IT1RQTFVHPXkNCj4+Pj4gQ09ORklHX1hFTl9NRU1P
UllfSE9UUExVR19MSU1JVD01MTINCj4+Pg0KPj4+IEkgaGF2ZToNCj4+PiAjIHpncmVwIE1F
TU9SWV9IT1RQTFVHIC9wcm9jL2NvbmZpZy5neg0KPj4+IENPTkZJR19BUkNIX0VOQUJMRV9N
RU1PUllfSE9UUExVRz15DQo+Pj4gQ09ORklHX01FTU9SWV9IT1RQTFVHPXkNCj4+PiBDT05G
SUdfTUVNT1JZX0hPVFBMVUdfREVGQVVMVF9PTkxJTkU9eQ0KPj4+IENPTkZJR19YRU5fQkFM
TE9PTl9NRU1PUllfSE9UUExVRz15DQo+Pj4gQ09ORklHX1hFTl9NRU1PUllfSE9UUExVR19M
SU1JVD01MTINCj4+Pg0KPj4+IE5vdCBzdXJlIGlmIHJlbGV2YW50LCBidXQgSSBhbHNvIGhh
dmU6DQo+Pj4gQ09ORklHX1hFTl9VTlBPUFVMQVRFRF9BTExPQz15DQo+Pj4NCj4+PiBvbiB0
b3Agb2YgdGhhdCwgSSBoYXZlIGEgc2ltaWxhciB1ZGV2IHJ1bGUgdG9vOg0KPj4+DQo+Pj4g
U1VCU1lTVEVNPT0ibWVtb3J5IiwgQUNUSU9OPT0iYWRkIiwgQVRUUntzdGF0ZX09PSJvZmZs
aW5lIiwgQVRUUntzdGF0ZX09Im9ubGluZSINCj4+Pg0KPj4+IEJ1dCBJIGRvbid0IHRoaW5r
IHRoZXkgYXJlIGNvbmZsaWN0aW5nLg0KPj4+DQo+Pj4+IFdoYXQgdHlwZSBvZiBndWVzdCBh
cmUgeW91IHVzaW5nPyBNaW5lIHdhcyBhIFBWSCBndWVzdC4NCj4+Pg0KPj4+IFBWSCBoZXJl
IHRvby4NCj4+DQo+PiBXb3VsZCB5b3UgbGlrZSB0byB0cnkgdGhlIGF0dGFjaGVkIHBhdGNo
PyBJdCBzZWVtZWQgdG8gd29yayBmb3IgbWUuDQo+IA0KPiBVbmZvcnR1bmF0ZWx5IGl0IGRv
ZXNuJ3QgaGVscCwgbm93IHRoZSBiZWhhdmlvciBpcyBkaWZmZXJlbnQ6DQo+IA0KPiBJbml0
aWFsbHkgZ3Vlc3Qgc3RhcnRlZCB3aXRoIDgwME06DQo+IA0KPiAgICAgIFtyb290QHBlcnNv
bmFsIH5dIyBmcmVlIC1tDQo+ICAgICAgICAgICAgICAgICAgICB0b3RhbCAgICAgICAgdXNl
ZCAgICAgICAgZnJlZSAgICAgIHNoYXJlZCAgYnVmZi9jYWNoZSAgIGF2YWlsYWJsZQ0KPiAg
ICAgIE1lbTogICAgICAgICAgICA3NDAgICAgICAgICAyMjMgICAgICAgICAyNzIgICAgICAg
ICAgIDIgICAgICAgICAyNDMgICAgICAgICA0MDENCj4gICAgICBTd2FwOiAgICAgICAgICAx
MDIzICAgICAgICAgICAwICAgICAgICAxMDIzDQo+IA0KPiBUaGVuIGluY3JlYXNlZDoNCj4g
DQo+ICAgICAgW3Jvb3RAZG9tMCB+XSQgeGwgbWVtLW1heCBwZXJzb25hbCAyMDQ4DQo+ICAg
ICAgW3Jvb3RAZG9tMCB+XSQgeGVuc3RvcmUtd3JpdGUgL2xvY2FsL2RvbWFpbi8kKHhsIGRv
bWlkIHBlcnNvbmFsKS9tZW1vcnkvc3RhdGljLW1heCAkKCgyMDQ4KjEwMjQpKQ0KPiAgICAg
IFtyb290QGRvbTAgfl0kIHhsIG1lbS1zZXQgcGVyc29uYWwgMjAwMA0KPiANCj4gQW5kIGd1
ZXN0IHNob3dzIG5vdyBvbmx5IGEgbGl0dGxlIG1vcmUgbWVtb3J5LCBidXQgbm90IGZ1bGwg
MjAwME06DQo+IA0KPiAgICAgIFtyb290QHBlcnNvbmFsIH5dIyBbICAgMzcuNjU3MDQ2XSB4
ZW46YmFsbG9vbjogUG9wdWxhdGluZyBuZXcgem9uZQ0KPiAgICAgIFsgICAzNy42NTgyMDZd
IEZhbGxiYWNrIG9yZGVyIGZvciBOb2RlIDA6IDANCj4gICAgICBbICAgMzcuNjU4MjE5XSBC
dWlsdCAxIHpvbmVsaXN0cywgbW9iaWxpdHkgZ3JvdXBpbmcgb24uICBUb3RhbCBwYWdlczog
MTc1ODg5DQo+ICAgICAgWyAgIDM3LjY1ODIzM10gUG9saWN5IHpvbmU6IE5vcm1hbA0KPiAN
Cj4gICAgICBbcm9vdEBwZXJzb25hbCB+XSMNCj4gICAgICBbcm9vdEBwZXJzb25hbCB+XSMg
ZnJlZSAtbQ0KPiAgICAgICAgICAgICAgICAgICAgdG90YWwgICAgICAgIHVzZWQgICAgICAg
IGZyZWUgICAgICBzaGFyZWQgIGJ1ZmYvY2FjaGUgICBhdmFpbGFibGUNCj4gICAgICBNZW06
ICAgICAgICAgICAgODI2ICAgICAgICAgMjQ1ICAgICAgICAgMzM3ICAgICAgICAgICAyICAg
ICAgICAgMjQ0ICAgICAgICAgNDYyDQo+ICAgICAgU3dhcDogICAgICAgICAgMTAyMyAgICAg
ICAgICAgMCAgICAgICAgMTAyMw0KPiANCj4gDQo+IEkndmUgYXBwbGllZCB0aGUgcGF0Y2gg
b24gdG9wIG9mIDUuMTYuMTguIElmIHlvdSB0aGluayA1LjE3IHdvdWxkIG1ha2UgYQ0KPiBk
aWZmZXJlbmNlLCBJIGNhbiB0cnkgdGhhdCB0b28uDQoNCkhtbSwgd2VpcmQuDQoNCkNhbiB5
b3UgcGxlYXNlIHBvc3QgdGhlIG91dHB1dCBvZg0KDQpjYXQgL3Byb2MvYnVkZHlpbmZvDQpj
YXQgL3Byb2MvaW9tZW0NCg0KaW4gdGhlIGd1ZXN0IGJlZm9yZSBhbmQgYWZ0ZXIgdGhlIG9w
ZXJhdGlvbnM/DQoNCg0KSnVlcmdlbg0K
--------------0XOQvze0parJHpzZQla96R02
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0XOQvze0parJHpzZQla96R02--

--------------xIYZpBotMLjgQb45zuRGf9XE--

--------------YAT1iKFDedeCClQ3ME0jlk8y
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJNIW4FAwAAAAAACgkQsN6d1ii/Ey+c
uAf/Xj536plMZB5Fz3tbFRpedzvk3wOazOMsJ8J/3Zuo+9cxh+g0l5CkkVO0fNYlpxY92ghOjEWo
uGxgqUFBuM7NSViacvZs0a0fBZ6WCsBIMK+p0PIFnAd8fKW+FFNlxr37A7HnRDyvkbDKevy4GNjH
hQNVXiy9gw9uKhYfhyovUraHgMrsL2LTvAnHXe0tatW8lyJK1K9hv+1czfDz1F5zcrAhxNx5Yn+q
Y3zTtAQvRQEQCJWmQezppnnN7KQr3kUn16bhp+xrdhGmKTgGZgKUpdmYWuUXfKpshE+FS35QtNQj
fzY+yys5OGkxV2myq/Y+8k5gVK9t+3nB6p03rWlmjg==
=pLAq
-----END PGP SIGNATURE-----

--------------YAT1iKFDedeCClQ3ME0jlk8y--


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 05:37:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 05:37:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299489.510286 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyM8-0004MY-Us; Wed, 06 Apr 2022 05:37:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299489.510286; Wed, 06 Apr 2022 05:37:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyM8-0004MR-Ql; Wed, 06 Apr 2022 05:37:24 +0000
Received: by outflank-mailman (input) for mailman id 299489;
 Wed, 06 Apr 2022 05:37:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbyM8-0004MH-1k; Wed, 06 Apr 2022 05:37:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbyM7-0004D8-VS; Wed, 06 Apr 2022 05:37:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbyM7-0003fm-F2; Wed, 06 Apr 2022 05:37:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbyM7-0007VB-D8; Wed, 06 Apr 2022 05:37:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cefgfTfS54sPdwoW1IzR8PyOitwj8aYZ9YyoMEtpH+M=; b=S9vCQU+8qGfgbuK4k3V+yHKoVs
	rybHU3ONL3iAjJC8kKM9LKFfmtmrUOKXWzNw++2AOLLubmWqvT67jjLES+zIT5l7+Rh2FFLkCj+68
	lmkaphAyw1Wpl3iBqq6/38Dyk1OPYjX/2c2JqLYIMP638IeR//W5xwnj2TwVXS0DlU04=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169180-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 169180: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=169a2834ef5d723091f187a5d6493ae77825757a
X-Osstest-Versions-That:
    xen=7b9814b250a5a28277bd0866d341a5cfc0f4c1ac
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 05:37:23 +0000

flight 169180 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169180/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168481
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168481
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168481
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168481
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168481
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168481
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168481
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168481
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168481
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168481
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168481
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168481
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  169a2834ef5d723091f187a5d6493ae77825757a
baseline version:
 xen                  7b9814b250a5a28277bd0866d341a5cfc0f4c1ac

Last test of basis   168481  2022-03-08 18:07:22 Z   28 days
Testing same since   169180  2022-04-05 13:37:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   7b9814b250..169a2834ef  169a2834ef5d723091f187a5d6493ae77825757a -> stable-4.13


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:01:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:01:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299507.510329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyjH-0008EE-Dm; Wed, 06 Apr 2022 06:01:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299507.510329; Wed, 06 Apr 2022 06:01:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyjH-0008E5-AY; Wed, 06 Apr 2022 06:01:19 +0000
Received: by outflank-mailman (input) for mailman id 299507;
 Wed, 06 Apr 2022 06:01:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbyjG-0008Dp-FC; Wed, 06 Apr 2022 06:01:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbyjG-0004lR-Db; Wed, 06 Apr 2022 06:01:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nbyjF-0005XL-Rq; Wed, 06 Apr 2022 06:01:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nbyjF-0006qX-RQ; Wed, 06 Apr 2022 06:01:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3C3m46cj0cM9e4VWlDxenfJLyD31zZxmMBViWQSqVpE=; b=lH5h5B6LTPXe56qrsypZaMPqTL
	sygYEEb8LC6S8MaKXFXRrsmTvfgYF2os3OxCLWXBYxCt4uzAWMgRT136J68n7Y7nMJElev8jr2VD8
	+XqMBoUmQpTlwq+VuAMQOKYiZYghq9swph1WTRfbh84kthgWjLfeVahTE5vJphgET/L8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169179-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 169179: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=54e37f44a219a987189c566e15ccad7af0bcc4ed
X-Osstest-Versions-That:
    xen=e34c16cc6ee029fa75c35bd21f75103d5502ea30
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 06:01:17 +0000

flight 169179 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169179/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169119
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169119
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169119
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169119
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169119
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169119
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169119
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169119
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169119
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169119
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169119
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169119
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  54e37f44a219a987189c566e15ccad7af0bcc4ed
baseline version:
 xen                  e34c16cc6ee029fa75c35bd21f75103d5502ea30

Last test of basis   169119  2022-04-01 21:11:48 Z    4 days
Testing same since   169179  2022-04-05 13:07:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e34c16cc6e..54e37f44a2  54e37f44a219a987189c566e15ccad7af0bcc4ed -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:05:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:05:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299523.510386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynU-0001Gw-6h; Wed, 06 Apr 2022 06:05:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299523.510386; Wed, 06 Apr 2022 06:05:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynU-0001Gm-0f; Wed, 06 Apr 2022 06:05:40 +0000
Received: by outflank-mailman (input) for mailman id 299523;
 Wed, 06 Apr 2022 06:05:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynT-0000i6-Aw
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:39 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9221db41-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:05:34 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynH-003umG-Rn; Wed, 06 Apr 2022 06:05:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9221db41-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=qk698qFB+7DuJ4AJ2sY5VQ7AD5pdtTim73QQqZ92loQ=; b=vV1BbnA55cPPAZB3254BK506im
	Old6T+yuUYVQppmY4OvzxURFILotMc/oCVviEkRv2abUE0J0i0GHlFCQmQE6zN4zzMN0LyyGdxCxm
	a3zAC2ibzPxxmh2esPJ31vQhU4t1hgSd4oolbLVJ30XUyZxO92DdwG6hQFMXNMNhWN7rcep7w4tlS
	VBiExL3j/1rs3vSKxNFaeesN2dWuawOYgyTbMBu//+gVZzz/ekohyJi6Ui5YQzYrI1BTFh69BMJ40
	8U0V0qb3pKlFpPgDI+reF/WlPNRxgS+0CgrkGxB17h8Jk2cVEx0UzjeLM8HRoV8yqMFF4OEOqQS3q
	gljNqowQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 02/27] target: pass a block_device to target_configure_unmap_from_queue
Date: Wed,  6 Apr 2022 08:04:51 +0200
Message-Id: <20220406060516.409838-3-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The target code is a consumer of the block layer and should generally
work on struct block_device.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/target/target_core_device.c  | 5 +++--
 drivers/target/target_core_file.c    | 7 ++++---
 drivers/target/target_core_iblock.c  | 2 +-
 include/target/target_core_backend.h | 4 ++--
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index fa866acef5bb2..3a1ec705cd80b 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -834,9 +834,10 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
  * in ATA and we need to set TPE=1
  */
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
-				       struct request_queue *q)
+				       struct block_device *bdev)
 {
-	int block_size = queue_logical_block_size(q);
+	struct request_queue *q = bdev_get_queue(bdev);
+	int block_size = bdev_logical_block_size(bdev);
 
 	if (!blk_queue_discard(q))
 		return false;
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index 8190b840065f3..8d191fdc33217 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -134,10 +134,11 @@ static int fd_configure_device(struct se_device *dev)
 	 */
 	inode = file->f_mapping->host;
 	if (S_ISBLK(inode->i_mode)) {
-		struct request_queue *q = bdev_get_queue(I_BDEV(inode));
+		struct block_device *bdev = I_BDEV(inode);
+		struct request_queue *q = bdev_get_queue(bdev);
 		unsigned long long dev_size;
 
-		fd_dev->fd_block_size = bdev_logical_block_size(I_BDEV(inode));
+		fd_dev->fd_block_size = bdev_logical_block_size(bdev);
 		/*
 		 * Determine the number of bytes from i_size_read() minus
 		 * one (1) logical sector from underlying struct block_device
@@ -150,7 +151,7 @@ static int fd_configure_device(struct se_device *dev)
 			dev_size, div_u64(dev_size, fd_dev->fd_block_size),
 			fd_dev->fd_block_size);
 
-		if (target_configure_unmap_from_queue(&dev->dev_attrib, q))
+		if (target_configure_unmap_from_queue(&dev->dev_attrib, bdev))
 			pr_debug("IFILE: BLOCK Discard support available,"
 				 " disabled by default\n");
 		/*
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 87ede165ddba4..b886ce1770bfd 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -119,7 +119,7 @@ static int iblock_configure_device(struct se_device *dev)
 	dev->dev_attrib.hw_max_sectors = queue_max_hw_sectors(q);
 	dev->dev_attrib.hw_queue_depth = q->nr_requests;
 
-	if (target_configure_unmap_from_queue(&dev->dev_attrib, q))
+	if (target_configure_unmap_from_queue(&dev->dev_attrib, bd))
 		pr_debug("IBLOCK: BLOCK Discard support available,"
 			 " disabled by default\n");
 
diff --git a/include/target/target_core_backend.h b/include/target/target_core_backend.h
index 675f3a1fe6139..773963a1e0b53 100644
--- a/include/target/target_core_backend.h
+++ b/include/target/target_core_backend.h
@@ -14,7 +14,7 @@
 #define TRANSPORT_FLAG_PASSTHROUGH_ALUA		0x2
 #define TRANSPORT_FLAG_PASSTHROUGH_PGR          0x4
 
-struct request_queue;
+struct block_device;
 struct scatterlist;
 
 struct target_backend_ops {
@@ -117,7 +117,7 @@ sense_reason_t passthrough_parse_cdb(struct se_cmd *cmd,
 bool target_sense_desc_format(struct se_device *dev);
 sector_t target_to_linux_sector(struct se_device *dev, sector_t lb);
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
-				       struct request_queue *q);
+				       struct block_device *bdev);
 
 static inline bool target_dev_configured(struct se_device *se_dev)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:05:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:05:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299521.510364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynP-0000i9-DW; Wed, 06 Apr 2022 06:05:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299521.510364; Wed, 06 Apr 2022 06:05:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynP-0000i1-AZ; Wed, 06 Apr 2022 06:05:35 +0000
Received: by outflank-mailman (input) for mailman id 299521;
 Wed, 06 Apr 2022 06:05:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynN-0000hu-IN
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:34 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f38d9e2-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:05:31 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynA-003ukl-9g; Wed, 06 Apr 2022 06:05:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f38d9e2-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=eIMQeXXWWkWx5FDwNbE0TlkL2lmBU9S9LJMrY9Onkc8=; b=VZ+7ypRmFaBJu2hWoqIAVoWmYj
	4xuOKPhldWs90pyh7ymg8zDgtPiY3fUX65YZt7O8odlZK2biQektgi2RBU0M6b67r5qzYVAWooKMG
	RUcSTyL9JbVdK+NxQGE8XxOqcy/ecJseZVyWJSGGYU9geNZke8bWZ+0hwzP7GapHHPs8RfgfuSXJe
	Y6P+Puu3Utc5OgunETt6hMAarqS36XMC4GrXZMgHCqwyaBIKi8AV3Se7oh/6MaZCw/a19Dt2QCcAQ
	3dQhNCC9soJ3UjvoF59FChYkHOkYI2VJYBUrVQVE7FpoCLMPp5lZq0dB9zF2n/zhNS+Ksy6vRUvVU
	mD8TTxXw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: use block_device based APIs in block layer consumers
Date: Wed,  6 Apr 2022 08:04:49 +0200
Message-Id: <20220406060516.409838-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Hi Jens,

this series cleanups up the block layer API so that APIs consumed
by file systems are (almost) only struct block_devic based, so that
file systems don't have to poke into block layer internals like the
request_queue.

I also found a bunch of existing bugs related to partition offsets
and discard so these are fixed while going along.

Diffstat:
 arch/um/drivers/ubd_kern.c           |    2 
 block/blk-core.c                     |    4 -
 block/blk-lib.c                      |  124 ++++++++++++++++++++---------------
 block/blk-mq-debugfs.c               |    2 
 block/blk-settings.c                 |   74 ++++++++++++++++++++
 block/blk.h                          |   14 ---
 block/fops.c                         |    2 
 block/genhd.c                        |    4 -
 block/ioctl.c                        |   48 ++++++++++---
 block/partitions/core.c              |   12 ---
 drivers/block/drbd/drbd_main.c       |   53 +++++++-------
 drivers/block/drbd/drbd_nl.c         |   94 +++++++++++---------------
 drivers/block/drbd/drbd_receiver.c   |   13 +--
 drivers/block/loop.c                 |   15 +---
 drivers/block/nbd.c                  |    3 
 drivers/block/null_blk/main.c        |    1 
 drivers/block/rbd.c                  |    1 
 drivers/block/rnbd/rnbd-clt.c        |    6 -
 drivers/block/rnbd/rnbd-srv-dev.h    |    8 --
 drivers/block/rnbd/rnbd-srv.c        |    5 -
 drivers/block/virtio_blk.c           |    2 
 drivers/block/xen-blkback/blkback.c  |   15 ++--
 drivers/block/xen-blkback/xenbus.c   |    9 --
 drivers/block/xen-blkfront.c         |    7 -
 drivers/block/zram/zram_drv.c        |    1 
 drivers/md/bcache/alloc.c            |    2 
 drivers/md/bcache/request.c          |    4 -
 drivers/md/bcache/super.c            |    3 
 drivers/md/bcache/sysfs.c            |    2 
 drivers/md/dm-cache-target.c         |    9 --
 drivers/md/dm-clone-target.c         |    9 --
 drivers/md/dm-io.c                   |    2 
 drivers/md/dm-log-writes.c           |    3 
 drivers/md/dm-raid.c                 |    9 --
 drivers/md/dm-table.c                |   25 +------
 drivers/md/dm-thin.c                 |   15 ----
 drivers/md/dm.c                      |    3 
 drivers/md/md-linear.c               |   11 ---
 drivers/md/md.c                      |    5 -
 drivers/md/raid0.c                   |    7 -
 drivers/md/raid1.c                   |   18 -----
 drivers/md/raid10.c                  |   20 -----
 drivers/md/raid5-cache.c             |    8 +-
 drivers/md/raid5.c                   |   14 +--
 drivers/mmc/core/queue.c             |    3 
 drivers/mtd/mtd_blkdevs.c            |    1 
 drivers/nvme/host/core.c             |    6 -
 drivers/nvme/target/io-cmd-bdev.c    |    2 
 drivers/nvme/target/zns.c            |    3 
 drivers/s390/block/dasd_fba.c        |    1 
 drivers/scsi/sd.c                    |    2 
 drivers/target/target_core_device.c  |   19 ++---
 drivers/target/target_core_file.c    |   10 +-
 drivers/target/target_core_iblock.c  |   17 +---
 fs/btrfs/disk-io.c                   |    3 
 fs/btrfs/extent-tree.c               |    8 +-
 fs/btrfs/ioctl.c                     |   12 +--
 fs/btrfs/volumes.c                   |    4 -
 fs/btrfs/zoned.c                     |    3 
 fs/direct-io.c                       |   32 +--------
 fs/exfat/file.c                      |    5 -
 fs/exfat/super.c                     |   10 --
 fs/ext4/ioctl.c                      |   10 --
 fs/ext4/mballoc.c                    |   10 +-
 fs/ext4/super.c                      |   10 --
 fs/f2fs/f2fs.h                       |    3 
 fs/f2fs/file.c                       |   19 ++---
 fs/f2fs/segment.c                    |    8 --
 fs/fat/file.c                        |    5 -
 fs/fat/inode.c                       |   10 --
 fs/gfs2/rgrp.c                       |    7 -
 fs/iomap/direct-io.c                 |    3 
 fs/jbd2/journal.c                    |    9 --
 fs/jfs/ioctl.c                       |    5 -
 fs/jfs/super.c                       |    8 --
 fs/nilfs2/ioctl.c                    |    6 -
 fs/nilfs2/sufile.c                   |    4 -
 fs/nilfs2/the_nilfs.c                |    4 -
 fs/ntfs3/file.c                      |    6 -
 fs/ntfs3/super.c                     |   10 +-
 fs/ocfs2/ioctl.c                     |    5 -
 fs/super.c                           |    2 
 fs/xfs/xfs_discard.c                 |    8 +-
 fs/xfs/xfs_log_cil.c                 |    2 
 fs/xfs/xfs_super.c                   |   12 +--
 fs/zonefs/super.c                    |    3 
 include/linux/blkdev.h               |  112 +++++++++++--------------------
 include/target/target_core_backend.h |    4 -
 mm/swapfile.c                        |   31 ++------
 89 files changed, 493 insertions(+), 652 deletions(-)


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:05:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:05:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299522.510375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynR-0000yI-Ma; Wed, 06 Apr 2022 06:05:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299522.510375; Wed, 06 Apr 2022 06:05:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynR-0000y7-Ij; Wed, 06 Apr 2022 06:05:37 +0000
Received: by outflank-mailman (input) for mailman id 299522;
 Wed, 06 Apr 2022 06:05:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynP-0000i6-Nq
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:35 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e43d733-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:05:28 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynD-003ul3-Rn; Wed, 06 Apr 2022 06:05:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e43d733-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=sINtR+pRAAWqBCMZRslKVJyakyubEJXVW4tI3wGLsb0=; b=gBrZsvegbTHoIEG5qdijcHzNWW
	PfzclL3zzl2tB5xhm8Sj7w6skVV8SvvJytC4EH0RoMlbB62c3vMVvjooDHTIWQ3smYKaAuMQ4cOli
	spZhkrdfcyNNrOGeIUuTpGtX63bYCgqfiIr52xJMA9AGK42nQUGH/2eHVQ3foGEH/zFa8lWfGs7Pp
	Ay5KyAHLP9DhsOCOpCtbHRVbRjzyQdYUTq4TkVLaYR9+Sga+ljLLLtQo5Hukpu2Q5UAw6RMQTfLQg
	vt8zwwfekDfQOHpKLK7/INfKF40CQ8temfgKOOdrhB506dWycfStoRSbi1wi6owABwmVkNNzYqcsL
	kVwVOMFA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction
Date: Wed,  6 Apr 2022 08:04:50 +0200
Message-Id: <20220406060516.409838-2-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

For block devices the target code implements UNMAP as calls to
blkdev_issue_discard, which does not guarantee zeroing just because
Write Zeroes is supported.

Note that this does not affect the file backed path which uses
fallocate to punch holes.

Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/target/target_core_device.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 44bb380e7390c..fa866acef5bb2 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -850,7 +850,6 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
 	attrib->unmap_granularity_alignment = q->limits.discard_alignment /
 								block_size;
-	attrib->unmap_zeroes_data = !!(q->limits.max_write_zeroes_sectors);
 	return true;
 }
 EXPORT_SYMBOL(target_configure_unmap_from_queue);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:05:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:05:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299524.510397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynZ-0001f4-CT; Wed, 06 Apr 2022 06:05:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299524.510397; Wed, 06 Apr 2022 06:05:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynZ-0001ev-9H; Wed, 06 Apr 2022 06:05:45 +0000
Received: by outflank-mailman (input) for mailman id 299524;
 Wed, 06 Apr 2022 06:05:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynX-0000i6-JY
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:43 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94b3c49b-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:05:39 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynP-003upZ-Oq; Wed, 06 Apr 2022 06:05:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94b3c49b-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=/VNrmVLKJsV7GQx7u+KW8uxbxcNBucKPfMuXZQkRDHQ=; b=jUohBlSW5WCTj76GUqjnlp1cx5
	z/8reyGnmSuZxtLQhg0+jPM694lAAGAWkh+U5eA0mLRb/AgwoytsU4FvpOxPiaD65mDm8lb2j+qF+
	t2HhJ4QddOVy3JK4d1MJddTe+d8VeGKgECeUXlf8UuGagztCqguNxvWacMCYDX5JxNW2p2RbmkW3q
	t71K7/u0ylDWs298FO9Gv20PpcvMYBl6xYylCqBoDNwcq28w+01w7woZnggq/4L3O2hqvwkL98w78
	x+x48h7Ao9LR48caKh9KX0fOy8aRUWWr0Tn3zUQaZ8j0meUpDZjDCysoSXFvl3p+a0P+BJJFXzCv6
	7D21c1Rw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 04/27] drbd: remove assign_p_sizes_qlim
Date: Wed,  6 Apr 2022 08:04:53 +0200
Message-Id: <20220406060516.409838-5-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Fold each branch into its only caller.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_main.c | 50 ++++++++++++++++------------------
 1 file changed, 23 insertions(+), 27 deletions(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 9676a1d214bc5..74b1b2424efff 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -903,31 +903,6 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device)
 	}
 }
 
-/* communicated if (agreed_features & DRBD_FF_WSAME) */
-static void
-assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p,
-					struct request_queue *q)
-{
-	if (q) {
-		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));
-		p->qlim->logical_block_size = cpu_to_be32(queue_logical_block_size(q));
-		p->qlim->alignment_offset = cpu_to_be32(queue_alignment_offset(q));
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
-		p->qlim->discard_enabled = blk_queue_discard(q);
-		p->qlim->write_same_capable = 0;
-	} else {
-		q = device->rq_queue;
-		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));
-		p->qlim->logical_block_size = cpu_to_be32(queue_logical_block_size(q));
-		p->qlim->alignment_offset = 0;
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
-		p->qlim->discard_enabled = 0;
-		p->qlim->write_same_capable = 0;
-	}
-}
-
 int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enum dds_flags flags)
 {
 	struct drbd_device *device = peer_device->device;
@@ -957,14 +932,35 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		q_order_type = drbd_queue_order_type(device);
 		max_bio_size = queue_max_hw_sectors(q) << 9;
 		max_bio_size = min(max_bio_size, DRBD_MAX_BIO_SIZE);
-		assign_p_sizes_qlim(device, p, q);
+		p->qlim->physical_block_size =
+			cpu_to_be32(queue_physical_block_size(q));
+		p->qlim->logical_block_size =
+			cpu_to_be32(queue_logical_block_size(q));
+		p->qlim->alignment_offset =
+			cpu_to_be32(queue_alignment_offset(q));
+		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
+		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->discard_enabled = blk_queue_discard(q);
+		p->qlim->write_same_capable =
+			!!q->limits.max_write_same_sectors;
 		put_ldev(device);
 	} else {
+		struct request_queue *q = device->rq_queue;
+
+		p->qlim->physical_block_size =
+			cpu_to_be32(queue_physical_block_size(q));
+		p->qlim->logical_block_size =
+			cpu_to_be32(queue_logical_block_size(q));
+		p->qlim->alignment_offset = 0;
+		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
+		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->discard_enabled = 0;
+		p->qlim->write_same_capable = 0;
+
 		d_size = 0;
 		u_size = 0;
 		q_order_type = QUEUE_ORDERED_NONE;
 		max_bio_size = DRBD_MAX_BIO_SIZE; /* ... multiple BIOs per peer_request */
-		assign_p_sizes_qlim(device, p, NULL);
 	}
 
 	if (peer_device->connection->agreed_pro_version <= 94)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:05:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:05:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299525.510408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyna-0001ws-OA; Wed, 06 Apr 2022 06:05:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299525.510408; Wed, 06 Apr 2022 06:05:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyna-0001vV-Hz; Wed, 06 Apr 2022 06:05:46 +0000
Received: by outflank-mailman (input) for mailman id 299525;
 Wed, 06 Apr 2022 06:05:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynY-0000i6-K0
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:44 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9512d214-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:05:39 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynL-003uoA-Rk; Wed, 06 Apr 2022 06:05:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9512d214-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=L9ybHoqkMQFtFgAKSKAUEOlBEraEcHfvZKxNTrnAqQ8=; b=txJ9J4YPrbulci+oxX/K1jvzXj
	8gms4zn8OqR/RStS8wT9jgDaq6tCr0xQ50GF2QciDZSPopEVcnXqcG9w2/K5XJ1BTwpW2RGCMVDA3
	jmixF0VaBheGVq3jZaojwfuYLAQ4/4Mglf66TIU/khX83gOPm4zJJDJ3ou8TXUFMlSJvyOL8I9hxL
	hx9nNbqp2gLScWmRlyHDlcj4q4nSOat130S2f7AGVfoaMNZ1nXqC2ZbfhhUNn3oLONf4dJ00se0wZ
	/QPbSgFP9I0m9WnIywznAmgQ/IfAzP4kiOxdsv2B4GrBWPwAkOiqBswZsWccIWUz5jFEPpf/f4t6x
	GlFV09uw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 03/27] target: fix discard alignment on partitions
Date: Wed,  6 Apr 2022 08:04:52 +0200
Message-Id: <20220406060516.409838-4-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the proper bdev_discard_alignment helper that accounts for partition
offsets.

Fіxes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/target/target_core_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 3a1ec705cd80b..16e775bcf4a7c 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -849,8 +849,8 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	 */
 	attrib->max_unmap_block_desc_count = 1;
 	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
-	attrib->unmap_granularity_alignment = q->limits.discard_alignment /
-								block_size;
+	attrib->unmap_granularity_alignment =
+		bdev_discard_alignment(bdev) / block_size;
 	return true;
 }
 EXPORT_SYMBOL(target_configure_unmap_from_queue);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:05:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:05:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299528.510420 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyni-0002ec-22; Wed, 06 Apr 2022 06:05:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299528.510420; Wed, 06 Apr 2022 06:05:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynh-0002eT-SC; Wed, 06 Apr 2022 06:05:53 +0000
Received: by outflank-mailman (input) for mailman id 299528;
 Wed, 06 Apr 2022 06:05:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynf-0000i6-Ri
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:51 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 98c9c264-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:05:46 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynT-003usA-Kd; Wed, 06 Apr 2022 06:05:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98c9c264-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=cTLTfYr7duFMbl13zCRXcRUBgEmH7Snqn+WlWdpEWNo=; b=ZV/CVrUb4qbpXBUImFAvqmY7OC
	YR/KmNB2+lAjq+EqA8oBYfyehyx3Nq+YwtV4TxCIA5A8L2WVXtNlev4guWoUuadGmFOwtgMiNwq9i
	yqX5G6E2+zNceTQVJtjM3l08MHhteYnLHXffM4/jtc5yfz/GeuE8HPUJ4reOje5U615tM7p768ryF
	Y/h9+5h+K+8NlHUqGExK7MtGefB5aNgyMmSmLlNaZTgeiyQAt5+xaIpSgQ/+zSSJmDjA+IoRmYh1L
	IwncIh14NoCZ6DbOmIaikx8OL30Ru/YZRUBoYvofpcHUxFXkbbQXdd7v+XeVl55WVE6NwYrNNaEln
	SKW/g4CA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 05/27] drbd: use bdev based limit helpers in drbd_send_sizes
Date: Wed,  6 Apr 2022 08:04:54 +0200
Message-Id: <20220406060516.409838-6-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based limits helpers where they exist.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_main.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 74b1b2424efff..d20d84ee7a88e 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -924,7 +924,9 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 
 	memset(p, 0, packet_size);
 	if (get_ldev_if_state(device, D_NEGOTIATING)) {
-		struct request_queue *q = bdev_get_queue(device->ldev->backing_bdev);
+		struct block_device *bdev = device->ldev->backing_bdev;
+		struct request_queue *q = bdev_get_queue(bdev);
+
 		d_size = drbd_get_max_capacity(device->ldev);
 		rcu_read_lock();
 		u_size = rcu_dereference(device->ldev->disk_conf)->disk_size;
@@ -933,16 +935,15 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		max_bio_size = queue_max_hw_sectors(q) << 9;
 		max_bio_size = min(max_bio_size, DRBD_MAX_BIO_SIZE);
 		p->qlim->physical_block_size =
-			cpu_to_be32(queue_physical_block_size(q));
+			cpu_to_be32(bdev_physical_block_size(bdev));
 		p->qlim->logical_block_size =
-			cpu_to_be32(queue_logical_block_size(q));
+			cpu_to_be32(bdev_logical_block_size(bdev));
 		p->qlim->alignment_offset =
 			cpu_to_be32(queue_alignment_offset(q));
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
+		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
 		p->qlim->discard_enabled = blk_queue_discard(q);
-		p->qlim->write_same_capable =
-			!!q->limits.max_write_same_sectors;
+		p->qlim->write_same_capable = 0;
 		put_ldev(device);
 	} else {
 		struct request_queue *q = device->rq_queue;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:05:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:05:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299533.510452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynn-0003jB-FR; Wed, 06 Apr 2022 06:05:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299533.510452; Wed, 06 Apr 2022 06:05:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynn-0003ip-9b; Wed, 06 Apr 2022 06:05:59 +0000
Received: by outflank-mailman (input) for mailman id 299533;
 Wed, 06 Apr 2022 06:05:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynm-0000hu-Pt
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:58 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9fce730e-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:05:58 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyne-003v04-Nu; Wed, 06 Apr 2022 06:05:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9fce730e-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=tRabeefOvFWuX0UGmN5W80/SEitu80or+ujXPxbBifU=; b=AOm4sjiAlP6tD5BDPG+nlvSOnr
	a+eqmQqJ44Gu3hNVff0rp/i9EstWS6YUe61HZmqK+NgAP9RCVrUroq8zVL8cKV3zpQ5XL0vyJlmRK
	NzewYB+71v3WGLpgxvDoCFkqDQNPtIyV060z8fdSvtAa8bXvOhTJAGc1uVeds1Z8SanWEw05KGQ3W
	UFB/Fg7NmKib5Uv9tykTUx2ZTObJAhnLIWQguQ08ldvRIaVpq8BqAf/QlCjLYPeugVNgGqcQ31x4x
	JN/Z3K777fE2OazN7ZPpQSN18xdxSBZinMwtnPgc6nyTQwlijNE+ESpNHGBXjEkXAjangL33mjfc5
	dZArx7ow==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 08/27] ntfs3: use bdev_logical_block_size instead of open coding it
Date: Wed,  6 Apr 2022 08:04:57 +0200
Message-Id: <20220406060516.409838-9-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/ntfs3/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 278dcf5024102..cd30e81abbce0 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -920,7 +920,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	}
 
 	/* Parse boot. */
-	err = ntfs_init_from_boot(sb, rq ? queue_logical_block_size(rq) : 512,
+	err = ntfs_init_from_boot(sb, bdev_logical_block_size(bdev),
 				  bdev_nr_bytes(bdev));
 	if (err)
 		goto out;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:05:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:05:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299531.510430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynk-0002zD-8N; Wed, 06 Apr 2022 06:05:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299531.510430; Wed, 06 Apr 2022 06:05:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynk-0002z4-4y; Wed, 06 Apr 2022 06:05:56 +0000
Received: by outflank-mailman (input) for mailman id 299531;
 Wed, 06 Apr 2022 06:05:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyni-0000i6-SL
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:54 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9a8014d8-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:05:48 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynX-003uuj-EB; Wed, 06 Apr 2022 06:05:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a8014d8-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=8b7He7jKWHmQh3KokdF/PRePZ9Zk3nvKntDAn0vRB+A=; b=0omtD+HQtA616dFivyqA97DclF
	5MCkQ36VFGZAUVgFUJvq7ULB9RxmAnnJK9Ru4GgkOHXwFqXqRHMXQ9LCogkUlyoM9wN6+7J7DekaY
	q43/dVC7g/6yyYP+I8eJgSyycd7IVsGmMYkR1Clskvv1tDsGCaTWuQ8Rrf8sU79R1v0lw2bQt/AWB
	OsOPsydboiChznz0eGpngaPA8w2OVY6Jf3YdqyKDFL16zctVHp5+n0d+GDis8Omgb+WFkLhPwAzdn
	EsF+yQBNP9+37ibHq8jy0MV7lNP50mXC+UwgCTvOjOUrw+1nocIz3QcImLpc9EsYaF5HR/HZej/jt
	LdNiWxFQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 06/27] drbd: cleanup decide_on_discard_support
Date: Wed,  6 Apr 2022 08:04:55 +0200
Message-Id: <20220406060516.409838-7-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Sanitize the calling conventions and use a goto label to cleanup the
code flow.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_nl.c | 68 +++++++++++++++++++-----------------
 1 file changed, 35 insertions(+), 33 deletions(-)

diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 02030c9c4d3b1..40bb0b356a6d6 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1204,38 +1204,42 @@ static unsigned int drbd_max_discard_sectors(struct drbd_connection *connection)
 }
 
 static void decide_on_discard_support(struct drbd_device *device,
-			struct request_queue *q,
-			struct request_queue *b,
-			bool discard_zeroes_if_aligned)
+		struct drbd_backing_dev *bdev)
 {
-	/* q = drbd device queue (device->rq_queue)
-	 * b = backing device queue (device->ldev->backing_bdev->bd_disk->queue),
-	 *     or NULL if diskless
-	 */
-	struct drbd_connection *connection = first_peer_device(device)->connection;
-	bool can_do = b ? blk_queue_discard(b) : true;
-
-	if (can_do && connection->cstate >= C_CONNECTED && !(connection->agreed_features & DRBD_FF_TRIM)) {
-		can_do = false;
-		drbd_info(connection, "peer DRBD too old, does not support TRIM: disabling discards\n");
-	}
-	if (can_do) {
-		/* We don't care for the granularity, really.
-		 * Stacking limits below should fix it for the local
-		 * device.  Whether or not it is a suitable granularity
-		 * on the remote device is not our problem, really. If
-		 * you care, you need to use devices with similar
-		 * topology on all peers. */
-		blk_queue_discard_granularity(q, 512);
-		q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
-		q->limits.max_write_zeroes_sectors = drbd_max_discard_sectors(connection);
-	} else {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
-		blk_queue_discard_granularity(q, 0);
-		q->limits.max_discard_sectors = 0;
-		q->limits.max_write_zeroes_sectors = 0;
+	struct drbd_connection *connection =
+		first_peer_device(device)->connection;
+	struct request_queue *q = device->rq_queue;
+
+	if (bdev && !blk_queue_discard(bdev->backing_bdev->bd_disk->queue))
+		goto not_supported;
+
+	if (connection->cstate >= C_CONNECTED &&
+	    !(connection->agreed_features & DRBD_FF_TRIM)) {
+		drbd_info(connection,
+			"peer DRBD too old, does not support TRIM: disabling discards\n");
+		goto not_supported;
 	}
+
+	/*
+	 * We don't care for the granularity, really.
+	 *
+	 * Stacking limits below should fix it for the local device.  Whether or
+	 * not it is a suitable granularity on the remote device is not our
+	 * problem, really. If you care, you need to use devices with similar
+	 * topology on all peers.
+	 */
+	blk_queue_discard_granularity(q, 512);
+	q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
+	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
+	q->limits.max_write_zeroes_sectors =
+		drbd_max_discard_sectors(connection);
+	return;
+
+not_supported:
+	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
+	blk_queue_discard_granularity(q, 0);
+	q->limits.max_discard_sectors = 0;
+	q->limits.max_write_zeroes_sectors = 0;
 }
 
 static void fixup_discard_if_not_supported(struct request_queue *q)
@@ -1273,7 +1277,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 	unsigned int max_segments = 0;
 	struct request_queue *b = NULL;
 	struct disk_conf *dc;
-	bool discard_zeroes_if_aligned = true;
 
 	if (bdev) {
 		b = bdev->backing_bdev->bd_disk->queue;
@@ -1282,7 +1285,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 		rcu_read_lock();
 		dc = rcu_dereference(device->ldev->disk_conf);
 		max_segments = dc->max_bio_bvecs;
-		discard_zeroes_if_aligned = dc->discard_zeroes_if_aligned;
 		rcu_read_unlock();
 
 		blk_set_stacking_limits(&q->limits);
@@ -1292,7 +1294,7 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 	/* This is the workaround for "bio would need to, but cannot, be split" */
 	blk_queue_max_segments(q, max_segments ? max_segments : BLK_MAX_SEGMENTS);
 	blk_queue_segment_boundary(q, PAGE_SIZE-1);
-	decide_on_discard_support(device, q, b, discard_zeroes_if_aligned);
+	decide_on_discard_support(device, bdev);
 
 	if (b) {
 		blk_stack_limits(&q->limits, &b->limits, 0);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:06:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:06:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299532.510435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynk-00033l-PH; Wed, 06 Apr 2022 06:05:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299532.510435; Wed, 06 Apr 2022 06:05:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbynk-00032H-HV; Wed, 06 Apr 2022 06:05:56 +0000
Received: by outflank-mailman (input) for mailman id 299532;
 Wed, 06 Apr 2022 06:05:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynj-0000hu-CH
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:05:55 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9de280a1-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:05:54 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynb-003uwx-AJ; Wed, 06 Apr 2022 06:05:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9de280a1-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=WTqESTvtfO4RX0qAqhs2oFd2Ik59q54vLqp/V/y7bnI=; b=FyJUmCuIohn+Rc7Inqu3BniYMO
	qIbi7WgRq0N7qblPyTDtikeMFm5V1dbLiaJQYES35HwVVDM5F002rNedhKojSjZSangf3g4TTB5H8
	ose/VQW92oLsoNNnrgmuQ76bdKKE4T6Y3dmmZVsUWsnsPjVGMnUiPjquePmKO+IeMAi+ZQQvMCCYS
	5PMGec+vFR133rAMQYM0lD1ltqCTBtpWog3Ko4h+ioJJRDUI+WLYZoytyDGy8Ig1GoZQ2cZVQBaiq
	VeAMRPUX1EVBht4ncdSOvQy0zHk56lci0PZ4ia4LUpztUXudJZTNfnXGvXSxvvSo+c89mmlg6GRYS
	FB4ItY+g==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open coding it
Date: Wed,  6 Apr 2022 08:04:56 +0200
Message-Id: <20220406060516.409838-8-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/btrfs/zoned.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index b7b5fac1c7790..5b85004d85d6c 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -350,7 +350,6 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
 	struct btrfs_fs_info *fs_info = device->fs_info;
 	struct btrfs_zoned_device_info *zone_info = NULL;
 	struct block_device *bdev = device->bdev;
-	struct request_queue *queue = bdev_get_queue(bdev);
 	unsigned int max_active_zones;
 	unsigned int nactive;
 	sector_t nr_sectors;
@@ -410,7 +409,7 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
 	if (!IS_ALIGNED(nr_sectors, zone_sectors))
 		zone_info->nr_zones++;
 
-	max_active_zones = queue_max_active_zones(queue);
+	max_active_zones = bdev_max_active_zones(bdev);
 	if (max_active_zones && max_active_zones < BTRFS_MIN_ACTIVE_ZONES) {
 		btrfs_err_in_rcu(fs_info,
 "zoned: %s: max active zones %u is too small, need at least %u active zones",
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:06:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:06:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299538.510463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyo7-0004e6-QG; Wed, 06 Apr 2022 06:06:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299538.510463; Wed, 06 Apr 2022 06:06:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyo7-0004dv-MP; Wed, 06 Apr 2022 06:06:19 +0000
Received: by outflank-mailman (input) for mailman id 299538;
 Wed, 06 Apr 2022 06:06:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyo5-0000hu-Rn
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:17 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ab40242b-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:06:17 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynq-003v9s-8N; Wed, 06 Apr 2022 06:06:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab40242b-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=6QVq+WRTbBiZAGVnN7IJPNcrDbkE5gjblRwCavAMwLY=; b=iYaG9VkUCm4D5TSOODWzio+3DR
	ytZ5+1QAyty9m+UBWG1IlrNmfBUfcieyEgGbnGvY+TeziydmDWxyUyplf08DqEXPrSA6ogGWlWBdc
	eN+NdSm2eI+GluAazic6ThRfk6EDWhUlwAFB1sgAiTcA0zTyVy4xoxDN7lNirp1PXWPDjCYKA8P/e
	a8Slx22YjqPgPpaGfnOLHtBTxMkfAK1Qngg3xOt/ieRRfzMYcYXFMoAX7pejVqOX04vm+E3B6daNl
	No56Cgl46IA8J2O0CAKFddZqGLAK02p4IZLzzaiPdfWcvculhrlYOGpmXilPV0+0lJWjaiLUMp8xe
	qYLNQzvg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 11/27] block: add a bdev_write_cache helper
Date: Wed,  6 Apr 2022 08:05:00 +0200
Message-Id: <20220406060516.409838-12-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the write cache flag based on the block_device
instead of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/rnbd/rnbd-srv.c       | 2 +-
 drivers/block/xen-blkback/xenbus.c  | 2 +-
 drivers/target/target_core_iblock.c | 8 ++------
 fs/btrfs/disk-io.c                  | 3 +--
 include/linux/blkdev.h              | 5 +++++
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index f04df6294650b..f8cc3c5fecb4b 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -558,7 +558,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 	rsp->secure_discard =
 		cpu_to_le16(rnbd_dev_get_secure_discard(rnbd_dev));
 	rsp->cache_policy = 0;
-	if (test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (bdev_write_cache(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_WRITEBACK;
 	if (blk_queue_fua(q))
 		rsp->cache_policy |= RNBD_FUA;
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index f09040435e2e5..8b691fe50475f 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -517,7 +517,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 		vbd->type |= VDISK_REMOVABLE;
 
 	q = bdev_get_queue(bdev);
-	if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (bdev_write_cache(bdev))
 		vbd->flush_support = true;
 
 	if (q && blk_queue_secure_erase(q))
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index b41ee5c3b5b82..03013e85ffc03 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -737,7 +737,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
 		if (test_bit(QUEUE_FLAG_FUA, &q->queue_flags)) {
 			if (cmd->se_cmd_flags & SCF_FUA)
 				opf |= REQ_FUA;
-			else if (!test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+			else if (!bdev_write_cache(ib_dev->ibd_bd))
 				opf |= REQ_FUA;
 		}
 	} else {
@@ -886,11 +886,7 @@ iblock_parse_cdb(struct se_cmd *cmd)
 
 static bool iblock_get_write_cache(struct se_device *dev)
 {
-	struct iblock_dev *ib_dev = IBLOCK_DEV(dev);
-	struct block_device *bd = ib_dev->ibd_bd;
-	struct request_queue *q = bdev_get_queue(bd);
-
-	return test_bit(QUEUE_FLAG_WC, &q->queue_flags);
+	return bdev_write_cache(IBLOCK_DEV(dev)->ibd_bd);
 }
 
 static const struct target_backend_ops iblock_ops = {
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index b30309f187cf0..d80adee32128d 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -4247,8 +4247,7 @@ static void write_dev_flush(struct btrfs_device *device)
 	 * of simplicity, since this is a debug tool and not meant for use in
 	 * non-debug builds.
 	 */
-	struct request_queue *q = bdev_get_queue(device->bdev);
-	if (!test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (bdev_write_cache(device->bdev))
 		return;
 #endif
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 3a9578e14a6b0..807a49aa5a27a 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1331,6 +1331,11 @@ static inline bool bdev_nonrot(struct block_device *bdev)
 	return blk_queue_nonrot(bdev_get_queue(bdev));
 }
 
+static inline bool bdev_write_cache(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:07:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:07:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299555.510493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypa-0006u6-Bt; Wed, 06 Apr 2022 06:07:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299555.510493; Wed, 06 Apr 2022 06:07:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypa-0006s7-15; Wed, 06 Apr 2022 06:07:50 +0000
Received: by outflank-mailman (input) for mailman id 299555;
 Wed, 06 Apr 2022 06:07:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoW-0000i6-3R
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:44 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b8b4106b-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:06:39 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyoK-003vcM-Lw; Wed, 06 Apr 2022 06:06:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8b4106b-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=d3sJ7l3Ux9SIWrKAiUmyBkG0qOnuM50cLv7WOo5iKv8=; b=U2k/JlDotMbinK7/JDeqSo6/XP
	Bs6ySJFC9su858GHk30OJaJoPB8rDR3fvqdgMURXO1OQquTgsv4KE+byWZoWhPXIJrPHFRYb57htY
	5kZ+Tj1EaeX24yHzNVPsnH8vK+56pifogbah/qUjzUOJyGboKhFS3X1qob8eCfNE75hF6DRia35U9
	qUd69uVjtYbl+AqrDw3m1Y45lEPmXYcMS6cMXqiqEpwL10Cir9JTLmDF/dQj22I6ypwBu1ciZGVg0
	rsksxrk+RgNjFNzHV8WMNg8RMAo9CfrbuDS6Y2JIjcM3aNVVcHFf8/GoINpy91AK7PBW/D671mulY
	8/TSMjOw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 19/27] block: remove queue_discard_alignment
Date: Wed,  6 Apr 2022 08:05:08 +0200
Message-Id: <20220406060516.409838-20-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Just use bdev_alignment_offset in disk_discard_alignment_show instead.
That helpers is the same except for an always false branch that doesn't
matter in this slow path.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/genhd.c          | 2 +-
 include/linux/blkdev.h | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index 712031ce19070..36532b9318419 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1019,7 +1019,7 @@ static ssize_t disk_discard_alignment_show(struct device *dev,
 {
 	struct gendisk *disk = dev_to_disk(dev);
 
-	return sprintf(buf, "%d\n", queue_discard_alignment(disk->queue));
+	return sprintf(buf, "%d\n", bdev_alignment_offset(disk->part0));
 }
 
 static ssize_t diskseq_show(struct device *dev,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 0a1795ac26275..5a9b7aeda010b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1253,14 +1253,6 @@ bdev_zone_write_granularity(struct block_device *bdev)
 
 int bdev_alignment_offset(struct block_device *bdev);
 
-static inline int queue_discard_alignment(const struct request_queue *q)
-{
-	if (q->limits.discard_misaligned)
-		return -1;
-
-	return q->limits.discard_alignment;
-}
-
 static inline int queue_limit_discard_alignment(struct queue_limits *lim, sector_t sector)
 {
 	unsigned int alignment, granularity, offset;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:07:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:07:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299550.510474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypZ-0006bh-71; Wed, 06 Apr 2022 06:07:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299550.510474; Wed, 06 Apr 2022 06:07:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypZ-0006ba-3v; Wed, 06 Apr 2022 06:07:49 +0000
Received: by outflank-mailman (input) for mailman id 299550;
 Wed, 06 Apr 2022 06:07:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyon-0000i6-3u
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:07:01 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2b8a2ea-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:06:56 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyoX-003vn4-0d; Wed, 06 Apr 2022 06:06:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2b8a2ea-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=QrovNweyJZRj1GFp6iCnhs45fbus+PzPDKXpCmbtDwo=; b=z5LFDFUbPWb3WO37mO8MwjoQU9
	uS3ZTdwAnf66Lx+zcAQQUC3qALjNiBk8vq/QdAnBrT+kiIx7+bGfq0K3/JsrX94g6GOI1PxnGLDP0
	TpbSMnVMCM12vlH2ieULysyOQ8eqGhAM7WSZgubyaijH46PkBLtZHwMl/DJ+SL/fL62RhXRHRBZ07
	gPidH4d0GBhOycIbS6/qs679s/JDzVaH5pxN2YMNY1qvOfu3TMWQ9LeQbRMDybW1HFyANyEbyeoY8
	bjiiLGRwO/33fN9Ma7LaMPzza6Yu9DF6RQqn94ZGs2knBiL0yIxk5iak06Qk6gWjflRAaNPj9+l6R
	kccMsInA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 22/27] block: refactor discard bio size limiting
Date: Wed,  6 Apr 2022 08:05:11 +0200
Message-Id: <20220406060516.409838-23-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 8ccbc6e076369..1fdc1d28e6d60 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:07:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:07:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299551.510480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypZ-0006fU-Id; Wed, 06 Apr 2022 06:07:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299551.510480; Wed, 06 Apr 2022 06:07:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypZ-0006es-D2; Wed, 06 Apr 2022 06:07:49 +0000
Received: by outflank-mailman (input) for mailman id 299551;
 Wed, 06 Apr 2022 06:07:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoj-0000i6-Ap
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:57 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c06b3a90-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:06:52 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyoS-003vjO-9L; Wed, 06 Apr 2022 06:06:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c06b3a90-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=M87611C6i/ov1/eZb42tZHfhB+4TDGyoM3tVyFqdBW8=; b=K8zhFyJNpfgn61EWvQNSpZGhoz
	IsW4d6jPg/o8RKdUEsY2I/0tp3DUigRRARrtQZS25XHPg6Ev8uZ5v/1QUVxcxn0UGRSq3QsUvtq8v
	m/wMNTUuZ0otna4wKyCKR9KuxhJuJrTxMCeQTsVHCLUaBLTq/yY7C/2YjXGPofV9QR6/pigrTQvyL
	+7FqGR+5akCXPC49M0KmVYykqYBaCN6qbVITFsaW/p3jcsFmAJQrrYOqAHtx2ogkbDQplnGNGSG9t
	hp4bnoEMlp1dxurHyPf38IfpaJHQv16bHjbw1cMsHDW5/ZArceH5PRjetepYbBzoAtUPy5j6Xetj9
	Onlv8nZg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 21/27] block: move {bdev,queue_limit}_discard_alignment out of line
Date: Wed,  6 Apr 2022 08:05:10 +0200
Message-Id: <20220406060516.409838-22-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

No need to inline these fairly larger helpers.  Also fix the return value
to be unsigned, just like the field in struct queue_limits.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-settings.c   | 35 +++++++++++++++++++++++++++++++++++
 include/linux/blkdev.h | 34 +---------------------------------
 2 files changed, 36 insertions(+), 33 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index 94410a13c0dee..fd83d674afd0a 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -478,6 +478,30 @@ static int queue_limit_alignment_offset(struct queue_limits *lim,
 	return (granularity + lim->alignment_offset - alignment) % granularity;
 }
 
+static unsigned int queue_limit_discard_alignment(struct queue_limits *lim,
+		sector_t sector)
+{
+	unsigned int alignment, granularity, offset;
+
+	if (!lim->max_discard_sectors)
+		return 0;
+
+	/* Why are these in bytes, not sectors? */
+	alignment = lim->discard_alignment >> SECTOR_SHIFT;
+	granularity = lim->discard_granularity >> SECTOR_SHIFT;
+	if (!granularity)
+		return 0;
+
+	/* Offset of the partition start in 'granularity' sectors */
+	offset = sector_div(sector, granularity);
+
+	/* And why do we do this modulus *again* in blkdev_issue_discard()? */
+	offset = (granularity + alignment - offset) % granularity;
+
+	/* Turn it back into bytes, gaah */
+	return offset << SECTOR_SHIFT;
+}
+
 static unsigned int blk_round_down_sectors(unsigned int sectors, unsigned int lbs)
 {
 	sectors = round_down(sectors, lbs >> SECTOR_SHIFT);
@@ -924,3 +948,14 @@ int bdev_alignment_offset(struct block_device *bdev)
 	return q->limits.alignment_offset;
 }
 EXPORT_SYMBOL_GPL(bdev_alignment_offset);
+
+unsigned int bdev_discard_alignment(struct block_device *bdev)
+{
+	struct request_queue *q = bdev_get_queue(bdev);
+
+	if (bdev_is_partition(bdev))
+		return queue_limit_discard_alignment(&q->limits,
+				bdev->bd_start_sect);
+	return q->limits.discard_alignment;
+}
+EXPORT_SYMBOL_GPL(bdev_discard_alignment);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 5a9b7aeda010b..34b1cfd067421 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1252,39 +1252,7 @@ bdev_zone_write_granularity(struct block_device *bdev)
 }
 
 int bdev_alignment_offset(struct block_device *bdev);
-
-static inline int queue_limit_discard_alignment(struct queue_limits *lim, sector_t sector)
-{
-	unsigned int alignment, granularity, offset;
-
-	if (!lim->max_discard_sectors)
-		return 0;
-
-	/* Why are these in bytes, not sectors? */
-	alignment = lim->discard_alignment >> SECTOR_SHIFT;
-	granularity = lim->discard_granularity >> SECTOR_SHIFT;
-	if (!granularity)
-		return 0;
-
-	/* Offset of the partition start in 'granularity' sectors */
-	offset = sector_div(sector, granularity);
-
-	/* And why do we do this modulus *again* in blkdev_issue_discard()? */
-	offset = (granularity + alignment - offset) % granularity;
-
-	/* Turn it back into bytes, gaah */
-	return offset << SECTOR_SHIFT;
-}
-
-static inline int bdev_discard_alignment(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	if (bdev_is_partition(bdev))
-		return queue_limit_discard_alignment(&q->limits,
-				bdev->bd_start_sect);
-	return q->limits.discard_alignment;
-}
+unsigned int bdev_discard_alignment(struct block_device *bdev);
 
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:07:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:07:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299552.510485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypZ-0006ku-Ti; Wed, 06 Apr 2022 06:07:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299552.510485; Wed, 06 Apr 2022 06:07:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypZ-0006jU-LG; Wed, 06 Apr 2022 06:07:49 +0000
Received: by outflank-mailman (input) for mailman id 299552;
 Wed, 06 Apr 2022 06:07:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyou-0000hu-K3
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:07:08 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c9112f89-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:07:07 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyof-003vuU-Et; Wed, 06 Apr 2022 06:06:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9112f89-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=8jSK8C/5ZUWGyg6hINYTsDIF1yeJGnFfAVVm7oGFGxU=; b=T/sY9fCgXhfmGZBEJLPCm1oMXz
	42vIbExPonBY8A2PxyvZvo+9LPj1W8f6uTfL1SNYRA7AHmqs/6e219bjnu0ZPesd6sC7dWswQbx/V
	q7IkMCCGg3Ze574iLqq8xs+ZETJUQqNHbalvhjKqNr0WBWNva4LVeQbx/++5vLZaqH+8q09l03F9V
	8cZ4jrfFJ6k5rFFuwk2EvMgT04gwGtK1wRmbCLSYg/DAnI4aW2XPIQpf/DFMLPl8kfYL2eFCsDyuC
	XPYaJiuvjAn5vzrt0fALEz7Eziuc+7w0Edqii+dr6LmhynkOxTPJnS/sxRGMv8MoM+aqCRkZPmPkN
	fOI4XODQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 24/27] block: add a bdev_discard_granularity helper
Date: Wed,  6 Apr 2022 08:05:13 +0200
Message-Id: <20220406060516.409838-25-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Abstract away implementation details from file systems by providing a
block_device based helper to retreive the discard granularity.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-lib.c                     |  5 ++---
 drivers/block/drbd/drbd_nl.c        |  9 +++++----
 drivers/block/drbd/drbd_receiver.c  |  3 +--
 drivers/block/loop.c                |  2 +-
 drivers/target/target_core_device.c |  3 +--
 fs/btrfs/ioctl.c                    | 12 ++++--------
 fs/exfat/file.c                     |  3 +--
 fs/ext4/mballoc.c                   |  6 +++---
 fs/f2fs/file.c                      |  3 +--
 fs/fat/file.c                       |  3 +--
 fs/gfs2/rgrp.c                      |  7 +++----
 fs/jfs/ioctl.c                      |  3 +--
 fs/nilfs2/ioctl.c                   |  4 ++--
 fs/ntfs3/file.c                     |  4 ++--
 fs/ntfs3/super.c                    |  6 ++----
 fs/ocfs2/ioctl.c                    |  3 +--
 fs/xfs/xfs_discard.c                |  4 ++--
 include/linux/blkdev.h              |  5 +++++
 18 files changed, 38 insertions(+), 47 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 8b4b66d3a9bfc..43aa4d7fe859f 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -12,8 +12,7 @@
 
 static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
 {
-	unsigned int discard_granularity =
-		bdev_get_queue(bdev)->limits.discard_granularity;
+	unsigned int discard_granularity = bdev_discard_granularity(bdev);
 	sector_t granularity_aligned_sector;
 
 	if (bdev_is_partition(bdev))
@@ -59,7 +58,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	}
 
 	/* In case the discard granularity isn't set by buggy device driver */
-	if (WARN_ON_ONCE(!q->limits.discard_granularity)) {
+	if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
 		char dev_name[BDEVNAME_SIZE];
 
 		bdevname(bdev, dev_name);
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 8e28e0a8e5e41..94ac3737723a8 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1440,7 +1440,6 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 			       struct drbd_backing_dev *nbc)
 {
 	struct block_device *bdev = nbc->backing_bdev;
-	struct request_queue *q = bdev->bd_disk->queue;
 
 	if (disk_conf->al_extents < DRBD_AL_EXTENTS_MIN)
 		disk_conf->al_extents = DRBD_AL_EXTENTS_MIN;
@@ -1457,12 +1456,14 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 	if (disk_conf->rs_discard_granularity) {
 		int orig_value = disk_conf->rs_discard_granularity;
 		sector_t discard_size = bdev_max_discard_sectors(bdev) << 9;
+		unsigned int discard_granularity = bdev_discard_granularity(bdev);
 		int remainder;
 
-		if (q->limits.discard_granularity > disk_conf->rs_discard_granularity)
-			disk_conf->rs_discard_granularity = q->limits.discard_granularity;
+		if (discard_granularity > disk_conf->rs_discard_granularity)
+			disk_conf->rs_discard_granularity = discard_granularity;
 
-		remainder = disk_conf->rs_discard_granularity % q->limits.discard_granularity;
+		remainder = disk_conf->rs_discard_granularity %
+				discard_granularity;
 		disk_conf->rs_discard_granularity += remainder;
 
 		if (disk_conf->rs_discard_granularity > discard_size)
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 8a4a47da56fe9..275c53c7b629e 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1511,7 +1511,6 @@ void drbd_bump_write_ordering(struct drbd_resource *resource, struct drbd_backin
 int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, unsigned int nr_sectors, int flags)
 {
 	struct block_device *bdev = device->ldev->backing_bdev;
-	struct request_queue *q = bdev_get_queue(bdev);
 	sector_t tmp, nr;
 	unsigned int max_discard_sectors, granularity;
 	int alignment;
@@ -1521,7 +1520,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		goto zero_out;
 
 	/* Zero-sector (unknown) and one-sector granularities are the same.  */
-	granularity = max(q->limits.discard_granularity >> 9, 1U);
+	granularity = max(bdev_discard_granularity(bdev) >> 9, 1U);
 	alignment = (bdev_discard_alignment(bdev) >> 9) % granularity;
 
 	max_discard_sectors = min(bdev_max_discard_sectors(bdev), (1U << 22));
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 4b919b75205a7..d5499795a1fec 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -759,7 +759,7 @@ static void loop_config_discard(struct loop_device *lo)
 		struct request_queue *backingq = bdev_get_queue(I_BDEV(inode));
 
 		max_discard_sectors = backingq->limits.max_write_zeroes_sectors;
-		granularity = backingq->limits.discard_granularity ?:
+		granularity = bdev_discard_granularity(I_BDEV(inode)) ?:
 			queue_physical_block_size(backingq);
 
 	/*
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 7d510e4231713..ee93f0cca4228 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -834,7 +834,6 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 				       struct block_device *bdev)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	int block_size = bdev_logical_block_size(bdev);
 
 	if (!bdev_max_discard_sectors(bdev))
@@ -846,7 +845,7 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	 * Currently hardcoded to 1 in Linux/SCSI code..
 	 */
 	attrib->max_unmap_block_desc_count = 1;
-	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
+	attrib->unmap_granularity = bdev_discard_granularity(bdev) / block_size;
 	attrib->unmap_granularity_alignment =
 		bdev_discard_alignment(bdev) / block_size;
 	return true;
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index fc7953755fd8b..f1a1e9519808e 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -468,7 +468,6 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 					void __user *arg)
 {
 	struct btrfs_device *device;
-	struct request_queue *q;
 	struct fstrim_range range;
 	u64 minlen = ULLONG_MAX;
 	u64 num_devices = 0;
@@ -498,14 +497,11 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 	rcu_read_lock();
 	list_for_each_entry_rcu(device, &fs_info->fs_devices->devices,
 				dev_list) {
-		if (!device->bdev)
+		if (!device->bdev || !bdev_max_discard_sectors(device->bdev))
 			continue;
-		q = bdev_get_queue(device->bdev);
-		if (bdev_max_discard_sectors(device->bdev)) {
-			num_devices++;
-			minlen = min_t(u64, q->limits.discard_granularity,
-				     minlen);
-		}
+		num_devices++;
+		minlen = min_t(u64, bdev_discard_granularity(device->bdev),
+				    minlen);
 	}
 	rcu_read_unlock();
 
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 765e4f63dd18d..20d4e47f57ab2 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -351,7 +351,6 @@ int exfat_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
 
 static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 {
-	struct request_queue *q = bdev_get_queue(inode->i_sb->s_bdev);
 	struct fstrim_range range;
 	int ret = 0;
 
@@ -365,7 +364,7 @@ static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 		return -EFAULT;
 
 	range.minlen = max_t(unsigned int, range.minlen,
-				q->limits.discard_granularity);
+				bdev_discard_granularity(inode->i_sb->s_bdev));
 
 	ret = exfat_trim_fs(inode, &range);
 	if (ret < 0)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index c3668c977cd99..6d1820536d88d 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -6455,7 +6455,7 @@ ext4_trim_all_free(struct super_block *sb, ext4_group_t group,
  */
 int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
 {
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
+	unsigned int discard_granularity = bdev_discard_granularity(sb->s_bdev);
 	struct ext4_group_info *grp;
 	ext4_group_t group, first_group, last_group;
 	ext4_grpblk_t cnt = 0, first_cluster, last_cluster;
@@ -6475,9 +6475,9 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
 	    range->len < sb->s_blocksize)
 		return -EINVAL;
 	/* No point to try to trim less than discard granularity */
-	if (range->minlen < q->limits.discard_granularity) {
+	if (range->minlen < discard_granularity) {
 		minlen = EXT4_NUM_B2C(EXT4_SB(sb),
-			q->limits.discard_granularity >> sb->s_blocksize_bits);
+				discard_granularity >> sb->s_blocksize_bits);
 		if (minlen > EXT4_CLUSTERS_PER_GROUP(sb))
 			goto out;
 	}
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 5b89af0f27f05..8053d99f3920b 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2285,7 +2285,6 @@ static int f2fs_ioc_fitrim(struct file *filp, unsigned long arg)
 {
 	struct inode *inode = file_inode(filp);
 	struct super_block *sb = inode->i_sb;
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
 	struct fstrim_range range;
 	int ret;
 
@@ -2304,7 +2303,7 @@ static int f2fs_ioc_fitrim(struct file *filp, unsigned long arg)
 		return ret;
 
 	range.minlen = max((unsigned int)range.minlen,
-				q->limits.discard_granularity);
+			   bdev_discard_granularity(sb->s_bdev));
 	ret = f2fs_trim_fs(F2FS_SB(sb), &range);
 	mnt_drop_write_file(filp);
 	if (ret < 0)
diff --git a/fs/fat/file.c b/fs/fat/file.c
index e4c7d10e80129..bf91f977debea 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -127,7 +127,6 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	struct super_block *sb = inode->i_sb;
 	struct fstrim_range __user *user_range;
 	struct fstrim_range range;
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
 	int err;
 
 	if (!capable(CAP_SYS_ADMIN))
@@ -141,7 +140,7 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 		return -EFAULT;
 
 	range.minlen = max_t(unsigned int, range.minlen,
-			     q->limits.discard_granularity);
+			     bdev_discard_granularity(sb->s_bdev));
 
 	err = fat_trim_fs(inode, &range);
 	if (err < 0)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 7f20ac9133bc6..6d26bb5254844 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1386,7 +1386,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 {
 	struct inode *inode = file_inode(filp);
 	struct gfs2_sbd *sdp = GFS2_SB(inode);
-	struct request_queue *q = bdev_get_queue(sdp->sd_vfs->s_bdev);
+	struct block_device *bdev = sdp->sd_vfs->s_bdev;
 	struct buffer_head *bh;
 	struct gfs2_rgrpd *rgd;
 	struct gfs2_rgrpd *rgd_end;
@@ -1405,7 +1405,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
 		return -EROFS;
 
-	if (!bdev_max_discard_sectors(sdp->sd_vfs->s_bdev))
+	if (!bdev_max_discard_sectors(bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&r, argp, sizeof(r)))
@@ -1418,8 +1418,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	start = r.start >> bs_shift;
 	end = start + (r.len >> bs_shift);
 	minlen = max_t(u64, r.minlen, sdp->sd_sb.sb_bsize);
-	minlen = max_t(u64, minlen,
-		       q->limits.discard_granularity) >> bs_shift;
+	minlen = max_t(u64, minlen, bdev_discard_granularity(bdev)) >> bs_shift;
 
 	if (end <= start || minlen > sdp->sd_max_rg_data)
 		return -EINVAL;
diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
index 357ae6e5c36ec..1e7b177ece605 100644
--- a/fs/jfs/ioctl.c
+++ b/fs/jfs/ioctl.c
@@ -110,7 +110,6 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	case FITRIM:
 	{
 		struct super_block *sb = inode->i_sb;
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		s64 ret = 0;
 
@@ -127,7 +126,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 			return -EFAULT;
 
 		range.minlen = max_t(unsigned int, range.minlen,
-			q->limits.discard_granularity);
+				     bdev_discard_granularity(sb->s_bdev));
 
 		ret = jfs_ioc_trim(inode, &range);
 		if (ret < 0)
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
index 52b73f558fcb1..87e1004b606d2 100644
--- a/fs/nilfs2/ioctl.c
+++ b/fs/nilfs2/ioctl.c
@@ -1052,7 +1052,6 @@ static int nilfs_ioctl_resize(struct inode *inode, struct file *filp,
 static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 {
 	struct the_nilfs *nilfs = inode->i_sb->s_fs_info;
-	struct request_queue *q = bdev_get_queue(nilfs->ns_bdev);
 	struct fstrim_range range;
 	int ret;
 
@@ -1065,7 +1064,8 @@ static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 	if (copy_from_user(&range, argp, sizeof(range)))
 		return -EFAULT;
 
-	range.minlen = max_t(u64, range.minlen, q->limits.discard_granularity);
+	range.minlen = max_t(u64, range.minlen,
+			     bdev_discard_granularity(nilfs->ns_bdev));
 
 	down_read(&nilfs->ns_segctor_sem);
 	ret = nilfs_sufile_trim_fs(nilfs->ns_sufile, &range);
diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index e763236169331..15806eeae217a 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -22,7 +22,6 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 {
 	struct fstrim_range __user *user_range;
 	struct fstrim_range range;
-	struct request_queue *q = bdev_get_queue(sbi->sb->s_bdev);
 	int err;
 
 	if (!capable(CAP_SYS_ADMIN))
@@ -35,7 +34,8 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 	if (copy_from_user(&range, user_range, sizeof(range)))
 		return -EFAULT;
 
-	range.minlen = max_t(u32, range.minlen, q->limits.discard_granularity);
+	range.minlen = max_t(u32, range.minlen,
+			     bdev_discard_granularity(sbi->sb->s_bdev));
 
 	err = ntfs_trim_fs(sbi, &range);
 	if (err < 0)
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index c734085bcce4a..5f2e414cfa79b 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -882,7 +882,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	int err;
 	struct ntfs_sb_info *sbi = sb->s_fs_info;
 	struct block_device *bdev = sb->s_bdev;
-	struct request_queue *rq;
 	struct inode *inode;
 	struct ntfs_inode *ni;
 	size_t i, tt;
@@ -912,9 +911,8 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 		goto out;
 	}
 
-	rq = bdev_get_queue(bdev);
-	if (bdev_max_discard_sectors(bdev) && rq->limits.discard_granularity) {
-		sbi->discard_granularity = rq->limits.discard_granularity;
+	if (bdev_max_discard_sectors(bdev) && bdev_discard_granularity(bdev)) {
+		sbi->discard_granularity = bdev_discard_granularity(bdev);
 		sbi->discard_granularity_mask_inv =
 			~(u64)(sbi->discard_granularity - 1);
 	}
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index 9b78ef103ada6..afd54ec661030 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -903,7 +903,6 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	case FITRIM:
 	{
 		struct super_block *sb = inode->i_sb;
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		int ret = 0;
 
@@ -916,7 +915,7 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (copy_from_user(&range, argp, sizeof(range)))
 			return -EFAULT;
 
-		range.minlen = max_t(u64, q->limits.discard_granularity,
+		range.minlen = max_t(u64, bdev_discard_granularity(sb->s_bdev),
 				     range.minlen);
 		ret = ocfs2_trim_fs(sb, &range);
 		if (ret < 0)
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index a4e6609d616b7..e2ada115c23f9 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -152,8 +152,8 @@ xfs_ioc_trim(
 	struct xfs_mount		*mp,
 	struct fstrim_range __user	*urange)
 {
-	struct request_queue	*q = bdev_get_queue(mp->m_ddev_targp->bt_bdev);
-	unsigned int		granularity = q->limits.discard_granularity;
+	unsigned int		granularity =
+		bdev_discard_granularity(mp->m_ddev_targp->bt_bdev);
 	struct fstrim_range	range;
 	xfs_daddr_t		start, end, minlen;
 	xfs_agnumber_t		start_agno, end_agno, agno;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index ce16247d3afab..7b9c0cf95d2d5 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1259,6 +1259,11 @@ static inline unsigned int bdev_max_discard_sectors(struct block_device *bdev)
 	return bdev_get_queue(bdev)->limits.max_discard_sectors;
 }
 
+static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.discard_granularity;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:07:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:07:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299556.510518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypf-0007q3-QL; Wed, 06 Apr 2022 06:07:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299556.510518; Wed, 06 Apr 2022 06:07:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypf-0007pl-In; Wed, 06 Apr 2022 06:07:55 +0000
Received: by outflank-mailman (input) for mailman id 299556;
 Wed, 06 Apr 2022 06:07:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbynt-0000i6-0V
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:05 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a04ee278-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:05:58 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyni-003v3I-Ik; Wed, 06 Apr 2022 06:05:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a04ee278-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=OGJvHxXgCvw9/l2/0Y6T0ivupEa5/VICLVgDi4pj6zk=; b=SGjGHiHxXhTBb30pFVsmtYoofW
	AXRkPwj9L+IToaoBSWN/RSxSSuBK+pJDBU/ojpwlgCD+rUR4zw9pN8EFDE29pkKOW63auHTvvxwCA
	PC6e0Da7Eiu1hFS/uIysLLSexy3aaIErbCMYeQH3HFSJ8bABmb6owDVYICpwPc9JKy6Ef8YTyDd/h
	SpNQxuUWxQhBUfv6Iv5iH1SH6hdeTIk5hPArvSrbVe9a1T+UDbpIkKauh2JPDG7p1MdAcg6ES2qNP
	pANlA2vT9XhPzqH+DYD3Rh3z9Pdg8L6xQ3HlNdFcmLcX+EpDCJ45aTaIIck6oVGd/w30i6T7ad6VR
	N9+UdC5Q==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 09/27] mm: use bdev_is_zoned in claim_swapfile
Date: Wed,  6 Apr 2022 08:04:58 +0200
Message-Id: <20220406060516.409838-10-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based helper instead of poking into the queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 mm/swapfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/swapfile.c b/mm/swapfile.c
index 63c61f8b26118..4c7537162af5e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2761,7 +2761,7 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
 		 * write only restriction.  Hence zoned block devices are not
 		 * suitable for swapping.  Disallow them here.
 		 */
-		if (blk_queue_is_zoned(p->bdev->bd_disk->queue))
+		if (bdev_is_zoned(p->bdev))
 			return -EINVAL;
 		p->flags |= SWP_BLKDEV;
 	} else if (S_ISREG(inode->i_mode)) {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:07:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:07:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299557.510529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyph-000876-4p; Wed, 06 Apr 2022 06:07:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299557.510529; Wed, 06 Apr 2022 06:07:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypg-00086P-U5; Wed, 06 Apr 2022 06:07:56 +0000
Received: by outflank-mailman (input) for mailman id 299557;
 Wed, 06 Apr 2022 06:07:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyp8-0000hu-0v
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:07:22 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d19a3fd3-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:07:21 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyow-003w6T-7D; Wed, 06 Apr 2022 06:07:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d19a3fd3-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=eypoqjBCbHteIGJMjEE77faduCfiNIsAQ0ydQeu7OQ0=; b=VptJyLJo1YdsSUby4Fd8E+r4Wf
	u75rPubQZZ/yn7kcXtNA66cq//o6wORmNO306ozoa8JQt9/98VP+qYdEokdi0gKerj4PE3OuPTu8Q
	h26M8bnuUyy+YQCYjo1RqpA3/aCzFHGcLsWag2ZHixgBhRcZoEIlcW3opNjmON+bZ+OgC/YI0u6sz
	aGLKxbaAYtZUWCf6s02YkSBuNI+7SEUA0M0G1MZlz1sCKQq4Roo8U5n9rz4bFVVcw6Xtsem6nRg0D
	kLp1HHY2R8qfLsl/g0pBVddgXjUpubdbXmsxIgH4DU7KvKflDKEXJplNCCWhXhcgX+rKhGC3+ptTE
	sV6rOXrg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 27/27] direct-io: remove random prefetches
Date: Wed,  6 Apr 2022 08:05:16 +0200
Message-Id: <20220406060516.409838-28-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Randomly poking into block device internals for manual prefetches isn't
exactly a very maintainable thing to do.  And none of the performance
criticil direct I/O implementations still use this library function
anyway, so just drop it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/direct-io.c | 32 ++++----------------------------
 1 file changed, 4 insertions(+), 28 deletions(-)

diff --git a/fs/direct-io.c b/fs/direct-io.c
index aef06e607b405..840752006f601 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -1115,11 +1115,10 @@ static inline int drop_refcount(struct dio *dio)
  * individual fields and will generate much worse code. This is important
  * for the whole file.
  */
-static inline ssize_t
-do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
-		      struct block_device *bdev, struct iov_iter *iter,
-		      get_block_t get_block, dio_iodone_t end_io,
-		      dio_submit_t submit_io, int flags)
+ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
+		struct block_device *bdev, struct iov_iter *iter,
+		get_block_t get_block, dio_iodone_t end_io,
+		dio_submit_t submit_io, int flags)
 {
 	unsigned i_blkbits = READ_ONCE(inode->i_blkbits);
 	unsigned blkbits = i_blkbits;
@@ -1334,29 +1333,6 @@ do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
 	kmem_cache_free(dio_cache, dio);
 	return retval;
 }
-
-ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
-			     struct block_device *bdev, struct iov_iter *iter,
-			     get_block_t get_block,
-			     dio_iodone_t end_io, dio_submit_t submit_io,
-			     int flags)
-{
-	/*
-	 * The block device state is needed in the end to finally
-	 * submit everything.  Since it's likely to be cache cold
-	 * prefetch it here as first thing to hide some of the
-	 * latency.
-	 *
-	 * Attempt to prefetch the pieces we likely need later.
-	 */
-	prefetch(&bdev->bd_disk->part_tbl);
-	prefetch(bdev->bd_disk->queue);
-	prefetch((char *)bdev->bd_disk->queue + SMP_CACHE_BYTES);
-
-	return do_blockdev_direct_IO(iocb, inode, bdev, iter, get_block,
-				     end_io, submit_io, flags);
-}
-
 EXPORT_SYMBOL(__blockdev_direct_IO);
 
 static __init int dio_init(void)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:07:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:07:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299559.510533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyph-0008CX-Nb; Wed, 06 Apr 2022 06:07:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299559.510533; Wed, 06 Apr 2022 06:07:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyph-0008B4-CM; Wed, 06 Apr 2022 06:07:57 +0000
Received: by outflank-mailman (input) for mailman id 299559;
 Wed, 06 Apr 2022 06:07:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyow-0000i6-6Q
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:07:10 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7970e70-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:07:04 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyoj-003vxb-Ew; Wed, 06 Apr 2022 06:06:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7970e70-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=NOp84q6++z+7Q8uHeg5Eo+6RpSy907DQLMlmJxz0jNA=; b=x0wNRTcLaeYftxiAQHKnjFl7Vn
	/hNIgg5ccry8wDU5TCE6WgYOjTiZp9YqujuI++whmFTqsw0fREkq1tH7klAVk3pmLAa/vHev3jFYr
	5Uo3rvvo1MWb8QwRAP1dZFxhI0Bfnu3BhYUA18htho7Gml6Q9eqPi5Sf4OizAOcOpoH+YZW1H8RhC
	099eZsjue0ogmbtNemjif1xsWLrKF+3Ham/efjGVY9mH4VelWmsVaGjlStwrG8r8LKRw52oTWsFAM
	Fx2izGgUXVgVMYfVg1h9A89tjacutX9KXFnHjFje4IpvhhHqLIBqpqsszQ64x2qdAggtSvuRGQNGP
	5ZrfWKSw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
Date: Wed,  6 Apr 2022 08:05:14 +0200
Message-Id: <20220406060516.409838-26-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Just use a non-zero max_discard_sectors as an indicator for discard
support, similar to what is done for write zeroes.

The only places where needs special attention is the RAID5 driver,
which must clear discard support for security reasons by default,
even if the default stacking rules would allow for it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/um/drivers/ubd_kern.c    |  2 --
 block/blk-mq-debugfs.c        |  1 -
 drivers/block/drbd/drbd_nl.c  | 15 ---------------
 drivers/block/loop.c          |  2 --
 drivers/block/nbd.c           |  3 ---
 drivers/block/null_blk/main.c |  1 -
 drivers/block/rbd.c           |  1 -
 drivers/block/rnbd/rnbd-clt.c |  2 --
 drivers/block/virtio_blk.c    |  2 --
 drivers/block/xen-blkfront.c  |  2 --
 drivers/block/zram/zram_drv.c |  1 -
 drivers/md/bcache/super.c     |  1 -
 drivers/md/dm-table.c         |  5 +----
 drivers/md/dm-thin.c          |  2 --
 drivers/md/dm.c               |  1 -
 drivers/md/md-linear.c        |  9 ---------
 drivers/md/raid0.c            |  7 -------
 drivers/md/raid1.c            | 14 --------------
 drivers/md/raid10.c           | 14 --------------
 drivers/md/raid5.c            | 12 ++++--------
 drivers/mmc/core/queue.c      |  1 -
 drivers/mtd/mtd_blkdevs.c     |  1 -
 drivers/nvme/host/core.c      |  6 ++----
 drivers/s390/block/dasd_fba.c |  1 -
 drivers/scsi/sd.c             |  2 --
 include/linux/blkdev.h        |  2 --
 26 files changed, 7 insertions(+), 103 deletions(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index b03269faef714..085ffdf98e57e 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -483,7 +483,6 @@ static void ubd_handler(void)
 			if ((io_req->error == BLK_STS_NOTSUPP) && (req_op(io_req->req) == REQ_OP_DISCARD)) {
 				blk_queue_max_discard_sectors(io_req->req->q, 0);
 				blk_queue_max_write_zeroes_sectors(io_req->req->q, 0);
-				blk_queue_flag_clear(QUEUE_FLAG_DISCARD, io_req->req->q);
 			}
 			blk_mq_end_request(io_req->req, io_req->error);
 			kfree(io_req);
@@ -803,7 +802,6 @@ static int ubd_open_dev(struct ubd *ubd_dev)
 		ubd_dev->queue->limits.discard_alignment = SECTOR_SIZE;
 		blk_queue_max_discard_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
 		blk_queue_max_write_zeroes_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, ubd_dev->queue);
 	}
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, ubd_dev->queue);
 	return 0;
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index aa0349e9f083b..fd111c5001256 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -113,7 +113,6 @@ static const char *const blk_queue_flag_name[] = {
 	QUEUE_FLAG_NAME(FAIL_IO),
 	QUEUE_FLAG_NAME(NONROT),
 	QUEUE_FLAG_NAME(IO_STAT),
-	QUEUE_FLAG_NAME(DISCARD),
 	QUEUE_FLAG_NAME(NOXMERGES),
 	QUEUE_FLAG_NAME(ADD_RANDOM),
 	QUEUE_FLAG_NAME(SECERASE),
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 94ac3737723a8..0b3e43be6414d 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1230,30 +1230,16 @@ static void decide_on_discard_support(struct drbd_device *device,
 	 */
 	blk_queue_discard_granularity(q, 512);
 	q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	q->limits.max_write_zeroes_sectors =
 		drbd_max_discard_sectors(connection);
 	return;
 
 not_supported:
-	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 	blk_queue_discard_granularity(q, 0);
 	q->limits.max_discard_sectors = 0;
 	q->limits.max_write_zeroes_sectors = 0;
 }
 
-static void fixup_discard_if_not_supported(struct request_queue *q)
-{
-	/* To avoid confusion, if this queue does not support discard, clear
-	 * max_discard_sectors, which is what lsblk -D reports to the user.
-	 * Older kernels got this wrong in "stack limits".
-	 * */
-	if (!blk_queue_discard(q)) {
-		blk_queue_max_discard_sectors(q, 0);
-		blk_queue_discard_granularity(q, 0);
-	}
-}
-
 static void fixup_write_zeroes(struct drbd_device *device, struct request_queue *q)
 {
 	/* Fixup max_write_zeroes_sectors after blk_stack_limits():
@@ -1300,7 +1286,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 		blk_stack_limits(&q->limits, &b->limits, 0);
 		disk_update_readahead(device->vdisk);
 	}
-	fixup_discard_if_not_supported(q);
 	fixup_write_zeroes(device, q);
 }
 
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index d5499795a1fec..976cf987b3920 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -784,12 +784,10 @@ static void loop_config_discard(struct loop_device *lo)
 		q->limits.discard_granularity = granularity;
 		blk_queue_max_discard_sectors(q, max_discard_sectors);
 		blk_queue_max_write_zeroes_sectors(q, max_discard_sectors);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	} else {
 		q->limits.discard_granularity = 0;
 		blk_queue_max_discard_sectors(q, 0);
 		blk_queue_max_write_zeroes_sectors(q, 0);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 	}
 	q->limits.discard_alignment = 0;
 }
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 5a1f98494dddf..c7e03eabd205f 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1231,8 +1231,6 @@ static void nbd_parse_flags(struct nbd_device *nbd)
 		set_disk_ro(nbd->disk, true);
 	else
 		set_disk_ro(nbd->disk, false);
-	if (config->flags & NBD_FLAG_SEND_TRIM)
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, nbd->disk->queue);
 	if (config->flags & NBD_FLAG_SEND_FLUSH) {
 		if (config->flags & NBD_FLAG_SEND_FUA)
 			blk_queue_write_cache(nbd->disk->queue, true, true);
@@ -1320,7 +1318,6 @@ static void nbd_config_put(struct nbd_device *nbd)
 		nbd->disk->queue->limits.discard_granularity = 0;
 		nbd->disk->queue->limits.discard_alignment = 0;
 		blk_queue_max_discard_sectors(nbd->disk->queue, UINT_MAX);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, nbd->disk->queue);
 
 		mutex_unlock(&nbd->config_lock);
 		nbd_put(nbd);
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 05b1120e66234..f6493a9e85ed3 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1767,7 +1767,6 @@ static void null_config_discard(struct nullb *nullb)
 	nullb->q->limits.discard_granularity = nullb->dev->blocksize;
 	nullb->q->limits.discard_alignment = nullb->dev->blocksize;
 	blk_queue_max_discard_sectors(nullb->q, UINT_MAX >> 9);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, nullb->q);
 }
 
 static const struct block_device_operations null_bio_ops = {
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index b844432bad20b..2b21f717cce1a 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -4942,7 +4942,6 @@ static int rbd_init_disk(struct rbd_device *rbd_dev)
 	blk_queue_io_opt(q, rbd_dev->opts->alloc_size);
 
 	if (rbd_dev->opts->trim) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 		q->limits.discard_granularity = rbd_dev->opts->alloc_size;
 		blk_queue_max_discard_sectors(q, objset_bytes >> SECTOR_SHIFT);
 		blk_queue_max_write_zeroes_sectors(q, objset_bytes >> SECTOR_SHIFT);
diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index b66e8840b94b8..efa99a3884507 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1364,8 +1364,6 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
 	blk_queue_max_discard_sectors(dev->queue, dev->max_discard_sectors);
 	dev->queue->limits.discard_granularity	= dev->discard_granularity;
 	dev->queue->limits.discard_alignment	= dev->discard_alignment;
-	if (dev->max_discard_sectors)
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, dev->queue);
 	if (dev->secure_discard)
 		blk_queue_flag_set(QUEUE_FLAG_SECERASE, dev->queue);
 
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index a8bcf3f664af1..6ccf15253dee1 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -888,8 +888,6 @@ static int virtblk_probe(struct virtio_device *vdev)
 			v = sg_elems;
 		blk_queue_max_discard_segments(q,
 					       min(v, MAX_DISCARD_SEGMENTS));
-
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	}
 
 	if (virtio_has_feature(vdev, VIRTIO_BLK_F_WRITE_ZEROES)) {
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 003056d4f7f5f..253bf835aca1f 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -944,7 +944,6 @@ static void blkif_set_queue_limits(struct blkfront_info *info)
 	blk_queue_flag_set(QUEUE_FLAG_VIRT, rq);
 
 	if (info->feature_discard) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, rq);
 		blk_queue_max_discard_sectors(rq, get_capacity(gd));
 		rq->limits.discard_granularity = info->discard_granularity ?:
 						 info->physical_sector_size;
@@ -1606,7 +1605,6 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
 				blkif_req(req)->error = BLK_STS_NOTSUPP;
 				info->feature_discard = 0;
 				info->feature_secdiscard = 0;
-				blk_queue_flag_clear(QUEUE_FLAG_DISCARD, rq);
 				blk_queue_flag_clear(QUEUE_FLAG_SECERASE, rq);
 			}
 			break;
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index e9474b02012de..59ff444bf6c76 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1952,7 +1952,6 @@ static int zram_add(void)
 	blk_queue_io_opt(zram->disk->queue, PAGE_SIZE);
 	zram->disk->queue->limits.discard_granularity = PAGE_SIZE;
 	blk_queue_max_discard_sectors(zram->disk->queue, UINT_MAX);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, zram->disk->queue);
 
 	/*
 	 * zram_bio_discard() will clear all logical blocks if logical block
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 296f200b2e208..2f49e31142f62 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -973,7 +973,6 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
 
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, d->disk->queue);
 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, d->disk->queue);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, d->disk->queue);
 
 	blk_queue_write_cache(q, true, true);
 
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 4297c38328a9b..0dff6907fd00d 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1968,15 +1968,12 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
 		blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);
 
 	if (!dm_table_supports_discards(t)) {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
-		/* Must also clear discard limits... */
 		q->limits.max_discard_sectors = 0;
 		q->limits.max_hw_discard_sectors = 0;
 		q->limits.discard_granularity = 0;
 		q->limits.discard_alignment = 0;
 		q->limits.discard_misaligned = 0;
-	} else
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
+	}
 
 	if (dm_table_supports_secure_erase(t))
 		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index cd333a3e4c33b..eded4bcc4545f 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -4050,8 +4050,6 @@ static void pool_io_hints(struct dm_target *ti, struct queue_limits *limits)
 		/*
 		 * Must explicitly disallow stacking discard limits otherwise the
 		 * block layer will stack them if pool's data device has support.
-		 * QUEUE_FLAG_DISCARD wouldn't be set but there is no way for the
-		 * user to see that, so make sure to set all discard limits to 0.
 		 */
 		limits->discard_granularity = 0;
 		return;
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index ba75933cc22ca..dbbf64ce7e927 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -955,7 +955,6 @@ void disable_discard(struct mapped_device *md)
 
 	/* device doesn't really support DISCARD, disable it */
 	limits->max_discard_sectors = 0;
-	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, md->queue);
 }
 
 void disable_write_zeroes(struct mapped_device *md)
diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
index 4dd5afff72844..138a3b25c5c82 100644
--- a/drivers/md/md-linear.c
+++ b/drivers/md/md-linear.c
@@ -64,7 +64,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 	struct linear_conf *conf;
 	struct md_rdev *rdev;
 	int i, cnt;
-	bool discard_supported = false;
 
 	conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL);
 	if (!conf)
@@ -96,9 +95,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 
 		conf->array_sectors += rdev->sectors;
 		cnt++;
-
-		if (bdev_max_discard_sectors(rdev->bdev))
-			discard_supported = true;
 	}
 	if (cnt != raid_disks) {
 		pr_warn("md/linear:%s: not enough drives present. Aborting!\n",
@@ -106,11 +102,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 		goto out;
 	}
 
-	if (!discard_supported)
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, mddev->queue);
-	else
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
-
 	/*
 	 * Here we calculate the device offsets.
 	 */
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index 02ac3ab213c72..7231f5e1eaa73 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -399,7 +399,6 @@ static int raid0_run(struct mddev *mddev)
 	conf = mddev->private;
 	if (mddev->queue) {
 		struct md_rdev *rdev;
-		bool discard_supported = false;
 
 		blk_queue_max_hw_sectors(mddev->queue, mddev->chunk_sectors);
 		blk_queue_max_write_zeroes_sectors(mddev->queue, mddev->chunk_sectors);
@@ -412,13 +411,7 @@ static int raid0_run(struct mddev *mddev)
 		rdev_for_each(rdev, mddev) {
 			disk_stack_limits(mddev->gendisk, rdev->bdev,
 					  rdev->data_offset << 9);
-			if (bdev_max_discard_sectors(rdev->bdev))
-				discard_supported = true;
 		}
-		if (!discard_supported)
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD, mddev->queue);
-		else
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 	}
 
 	/* calculate array device size */
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 39b9cb4d54ee0..3da749d150a17 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1826,8 +1826,6 @@ static int raid1_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 			break;
 		}
 	}
-	if (mddev->queue && bdev_max_discard_sectors(rdev->bdev))
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 	print_conf(conf);
 	return err;
 }
@@ -3106,7 +3104,6 @@ static int raid1_run(struct mddev *mddev)
 	int i;
 	struct md_rdev *rdev;
 	int ret;
-	bool discard_supported = false;
 
 	if (mddev->level != 1) {
 		pr_warn("md/raid1:%s: raid level not set to mirroring (%d)\n",
@@ -3141,8 +3138,6 @@ static int raid1_run(struct mddev *mddev)
 			continue;
 		disk_stack_limits(mddev->gendisk, rdev->bdev,
 				  rdev->data_offset << 9);
-		if (bdev_max_discard_sectors(rdev->bdev))
-			discard_supported = true;
 	}
 
 	mddev->degraded = 0;
@@ -3179,15 +3174,6 @@ static int raid1_run(struct mddev *mddev)
 
 	md_set_array_sectors(mddev, raid1_size(mddev, 0, 0));
 
-	if (mddev->queue) {
-		if (discard_supported)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						  mddev->queue);
-	}
-
 	ret = md_integrity_register(mddev);
 	if (ret) {
 		md_unregister_thread(&mddev->thread);
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index eaa86c6a35a55..36a460015cf58 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2144,8 +2144,6 @@ static int raid10_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 		rcu_assign_pointer(p->rdev, rdev);
 		break;
 	}
-	if (mddev->queue && bdev_max_discard_sectors(rdev->bdev))
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 
 	print_conf(conf);
 	return err;
@@ -4069,7 +4067,6 @@ static int raid10_run(struct mddev *mddev)
 	sector_t size;
 	sector_t min_offset_diff = 0;
 	int first = 1;
-	bool discard_supported = false;
 
 	if (mddev_init_writes_pending(mddev) < 0)
 		return -ENOMEM;
@@ -4140,20 +4137,9 @@ static int raid10_run(struct mddev *mddev)
 					  rdev->data_offset << 9);
 
 		disk->head_position = 0;
-
-		if (bdev_max_discard_sectors(rdev->bdev))
-			discard_supported = true;
 		first = 0;
 	}
 
-	if (mddev->queue) {
-		if (discard_supported)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						  mddev->queue);
-	}
 	/* need to check that every block has at least one working mirror */
 	if (!enough(conf, -1)) {
 		pr_err("md/raid10:%s: not enough operational mirrors.\n",
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 0bbae0e638666..59f91e392a2ae 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7776,14 +7776,10 @@ static int raid5_run(struct mddev *mddev)
 		 * A better idea might be to turn DISCARD into WRITE_ZEROES
 		 * requests, as that is required to be safe.
 		 */
-		if (devices_handle_discard_safely &&
-		    mddev->queue->limits.max_discard_sectors >= (stripe >> 9) &&
-		    mddev->queue->limits.discard_granularity >= stripe)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						mddev->queue);
+		if (!devices_handle_discard_safely ||
+		    mddev->queue->limits.max_discard_sectors < (stripe >> 9) ||
+		    mddev->queue->limits.discard_granularity < stripe)
+			blk_queue_max_discard_sectors(mddev->queue, 0);
 
 		blk_queue_max_hw_sectors(mddev->queue, UINT_MAX);
 	}
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index c69b2d9df6f16..cac6315010a3d 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -183,7 +183,6 @@ static void mmc_queue_setup_discard(struct request_queue *q,
 	if (!max_discard)
 		return;
 
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	blk_queue_max_discard_sectors(q, max_discard);
 	q->limits.discard_granularity = card->pref_erase << 9;
 	/* granularity must not be greater than max. discard */
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 64d2b093f114b..f731721114655 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -377,7 +377,6 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, new->rq);
 
 	if (tr->discard) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, new->rq);
 		blk_queue_max_discard_sectors(new->rq, UINT_MAX);
 		new->rq->limits.discard_granularity = tr->blksize;
 	}
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index efb85c6d8e2d5..7e07dd69262a7 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1607,10 +1607,8 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
 	struct request_queue *queue = disk->queue;
 	u32 size = queue_logical_block_size(queue);
 
-	if (ctrl->max_discard_sectors == 0) {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, queue);
+	if (ctrl->max_discard_sectors == 0)
 		return;
-	}
 
 	BUILD_BUG_ON(PAGE_SIZE / sizeof(struct nvme_dsm_range) <
 			NVME_DSM_MAX_RANGES);
@@ -1619,7 +1617,7 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
 	queue->limits.discard_granularity = size;
 
 	/* If discard is already enabled, don't reset queue limits */
-	if (blk_queue_flag_test_and_set(QUEUE_FLAG_DISCARD, queue))
+	if (queue->limits.max_discard_sectors)
 		return;
 
 	blk_queue_max_discard_sectors(queue, ctrl->max_discard_sectors);
diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c
index e084f4deddddd..8bd5665db9198 100644
--- a/drivers/s390/block/dasd_fba.c
+++ b/drivers/s390/block/dasd_fba.c
@@ -791,7 +791,6 @@ static void dasd_fba_setup_blk_queue(struct dasd_block *block)
 
 	blk_queue_max_discard_sectors(q, max_discard_sectors);
 	blk_queue_max_write_zeroes_sectors(q, max_discard_sectors);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 }
 
 static int dasd_fba_pe_handler(struct dasd_device *device,
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index a390679cf4584..444479657b7fd 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -797,7 +797,6 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
 	case SD_LBP_FULL:
 	case SD_LBP_DISABLE:
 		blk_queue_max_discard_sectors(q, 0);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 		return;
 
 	case SD_LBP_UNMAP:
@@ -830,7 +829,6 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
 	}
 
 	blk_queue_max_discard_sectors(q, max_blocks * (logical_block_size >> 9));
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 }
 
 static blk_status_t sd_setup_unmap_cmnd(struct scsi_cmnd *cmd)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 7b9c0cf95d2d5..f1cf557ea20ef 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -540,7 +540,6 @@ struct request_queue {
 #define QUEUE_FLAG_NONROT	6	/* non-rotational device (SSD) */
 #define QUEUE_FLAG_VIRT		QUEUE_FLAG_NONROT /* paravirt device */
 #define QUEUE_FLAG_IO_STAT	7	/* do disk/partitions IO accounting */
-#define QUEUE_FLAG_DISCARD	8	/* supports DISCARD */
 #define QUEUE_FLAG_NOXMERGES	9	/* No extended merges */
 #define QUEUE_FLAG_ADD_RANDOM	10	/* Contributes to random pool */
 #define QUEUE_FLAG_SECERASE	11	/* supports secure erase */
@@ -582,7 +581,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 	test_bit(QUEUE_FLAG_STABLE_WRITES, &(q)->queue_flags)
 #define blk_queue_io_stat(q)	test_bit(QUEUE_FLAG_IO_STAT, &(q)->queue_flags)
 #define blk_queue_add_random(q)	test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
-#define blk_queue_discard(q)	test_bit(QUEUE_FLAG_DISCARD, &(q)->queue_flags)
 #define blk_queue_zone_resetall(q)	\
 	test_bit(QUEUE_FLAG_ZONE_RESETALL, &(q)->queue_flags)
 #define blk_queue_secure_erase(q) \
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:07:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:07:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299560.510539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypi-0008Kp-Bn; Wed, 06 Apr 2022 06:07:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299560.510539; Wed, 06 Apr 2022 06:07:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyph-0008H2-Vm; Wed, 06 Apr 2022 06:07:57 +0000
Received: by outflank-mailman (input) for mailman id 299560;
 Wed, 06 Apr 2022 06:07:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoR-0000hu-Fs
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:39 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b8263d11-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:06:38 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyoG-003vYE-MZ; Wed, 06 Apr 2022 06:06:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8263d11-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=rlsVeHMg1hHe1r1+YuPgwXRF4/8zJamKMsqI05vg2XQ=; b=dEa4kNFmwX0SYcUFcc8Xi9cZiL
	0YHBnhtVe3qzqowCIKMRB3fv14qh0IEapvyOiw9f3P2TSmik6xnIn650HHnwvUXy84tiN3zbnssTg
	bDH/a8s5U5AtH87Q46R+MdZn/5zNmDyW2XAGsRKbf666enqb4maEJBeBUKRiT5IBnUoONGC/RElhk
	R2OL8L7AkB7Ubnk5lUhjB16LEYlI2jSitkdlJ7GTrHY/8Pee2MpDAWz1qn3WxE7V0lFGXbe3hSOHh
	45Avy2PKid7ei173qk3MzQTEY8YnmjD/8olfy3eNuGejl5sdeK7uQvol+EUTRrVgtV4C0kFycxISR
	GBDMxuEg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line
Date: Wed,  6 Apr 2022 08:05:07 +0200
Message-Id: <20220406060516.409838-19-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

No need to inline these fairly larger helpers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-settings.c   | 23 +++++++++++++++++++++++
 include/linux/blkdev.h | 21 +--------------------
 2 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index b83df3d2eebca..94410a13c0dee 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -468,6 +468,16 @@ void blk_queue_io_opt(struct request_queue *q, unsigned int opt)
 }
 EXPORT_SYMBOL(blk_queue_io_opt);
 
+static int queue_limit_alignment_offset(struct queue_limits *lim,
+		sector_t sector)
+{
+	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
+	unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
+		<< SECTOR_SHIFT;
+
+	return (granularity + lim->alignment_offset - alignment) % granularity;
+}
+
 static unsigned int blk_round_down_sectors(unsigned int sectors, unsigned int lbs)
 {
 	sectors = round_down(sectors, lbs >> SECTOR_SHIFT);
@@ -901,3 +911,16 @@ void blk_queue_set_zoned(struct gendisk *disk, enum blk_zoned_model model)
 	}
 }
 EXPORT_SYMBOL_GPL(blk_queue_set_zoned);
+
+int bdev_alignment_offset(struct block_device *bdev)
+{
+	struct request_queue *q = bdev_get_queue(bdev);
+
+	if (q->limits.misaligned)
+		return -1;
+	if (bdev_is_partition(bdev))
+		return queue_limit_alignment_offset(&q->limits,
+				bdev->bd_start_sect);
+	return q->limits.alignment_offset;
+}
+EXPORT_SYMBOL_GPL(bdev_alignment_offset);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index d5346e72e3645..0a1795ac26275 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1251,26 +1251,7 @@ bdev_zone_write_granularity(struct block_device *bdev)
 	return queue_zone_write_granularity(bdev_get_queue(bdev));
 }
 
-static inline int queue_limit_alignment_offset(struct queue_limits *lim, sector_t sector)
-{
-	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
-	unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
-		<< SECTOR_SHIFT;
-
-	return (granularity + lim->alignment_offset - alignment) % granularity;
-}
-
-static inline int bdev_alignment_offset(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	if (q->limits.misaligned)
-		return -1;
-	if (bdev_is_partition(bdev))
-		return queue_limit_alignment_offset(&q->limits,
-				bdev->bd_start_sect);
-	return q->limits.alignment_offset;
-}
+int bdev_alignment_offset(struct block_device *bdev);
 
 static inline int queue_discard_alignment(const struct request_queue *q)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299566.510561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypq-0001Fj-MJ; Wed, 06 Apr 2022 06:08:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299566.510561; Wed, 06 Apr 2022 06:08:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypq-0001Bl-G0; Wed, 06 Apr 2022 06:08:06 +0000
Received: by outflank-mailman (input) for mailman id 299566;
 Wed, 06 Apr 2022 06:08:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyp5-0000i6-H2
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:07:19 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ccd82b0b-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:07:13 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyos-003w0e-Bj; Wed, 06 Apr 2022 06:07:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ccd82b0b-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=/YZKTwOyQzztfyqzf/8qSaxDPsSv13HN63ynybvB8C0=; b=04hbTk2PqQjIM4G7Y0k8niUwgg
	5k+nbNiwzVRtRERo1pq9Js3hI5qAO2X/vnSLbP9TAD6ACjVYTM4ZplP+flp3q1PUzTHQ/XM4V+Auf
	wEr2+UuwPnprKzyV5utTYfmaJx4hQ5DcvruKJJGWIehulvFzU3USNBjqxUvYWPWz8pdztUNESX9zn
	wIAMJozwBT4XMyF9ZLKV5tEghZ62A8X8bz6RcGH/u2Yz5tkkvavlt3z1um5KE1JKgvNdSg0WQyLnq
	pghEbLwhoLYdlgEMaQN+Z0BD0os5Rud8VlnKhpv0EgfQ38AQxvj0r32RBUxzJgDLWADqaAY01aHnS
	sTHsEEuA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD
Date: Wed,  6 Apr 2022 08:05:15 +0200
Message-Id: <20220406060516.409838-27-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Secure erase is a very different operation from discard in that it is
a data integrity operation vs hint.  Fully split the limits and helper
infrastructure to make the separation more clear.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-core.c                    |  2 +-
 block/blk-lib.c                     | 64 ++++++++++++++++++++---------
 block/blk-mq-debugfs.c              |  1 -
 block/blk-settings.c                | 16 +++++++-
 block/fops.c                        |  2 +-
 block/ioctl.c                       | 43 +++++++++++++++----
 drivers/block/drbd/drbd_receiver.c  |  5 ++-
 drivers/block/rnbd/rnbd-clt.c       |  4 +-
 drivers/block/rnbd/rnbd-srv-dev.h   |  2 +-
 drivers/block/xen-blkback/blkback.c | 15 +++----
 drivers/block/xen-blkback/xenbus.c  |  5 +--
 drivers/block/xen-blkfront.c        |  5 ++-
 drivers/md/bcache/alloc.c           |  2 +-
 drivers/md/dm-table.c               |  8 ++--
 drivers/md/dm-thin.c                |  4 +-
 drivers/md/md.c                     |  2 +-
 drivers/md/raid5-cache.c            |  6 +--
 drivers/mmc/core/queue.c            |  2 +-
 drivers/nvme/target/io-cmd-bdev.c   |  2 +-
 drivers/target/target_core_file.c   |  2 +-
 drivers/target/target_core_iblock.c |  2 +-
 fs/btrfs/extent-tree.c              |  4 +-
 fs/ext4/mballoc.c                   |  2 +-
 fs/f2fs/file.c                      | 16 ++++----
 fs/f2fs/segment.c                   |  2 +-
 fs/jbd2/journal.c                   |  2 +-
 fs/nilfs2/sufile.c                  |  4 +-
 fs/nilfs2/the_nilfs.c               |  4 +-
 fs/ntfs3/super.c                    |  2 +-
 fs/xfs/xfs_discard.c                |  2 +-
 fs/xfs/xfs_log_cil.c                |  2 +-
 include/linux/blkdev.h              | 27 +++++++-----
 mm/swapfile.c                       |  6 +--
 33 files changed, 168 insertions(+), 99 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index b5c3a8049134c..ee18b6a699bdf 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -824,7 +824,7 @@ void submit_bio_noacct(struct bio *bio)
 			goto not_supported;
 		break;
 	case REQ_OP_SECURE_ERASE:
-		if (!blk_queue_secure_erase(q))
+		if (!bdev_max_secure_erase_sectors(bdev))
 			goto not_supported;
 		break;
 	case REQ_OP_ZONE_APPEND:
diff --git a/block/blk-lib.c b/block/blk-lib.c
index 43aa4d7fe859f..09b7e1200c0f4 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -36,26 +36,15 @@ static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
 }
 
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, int flags,
-		struct bio **biop)
+		sector_t nr_sects, gfp_t gfp_mask, struct bio **biop)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
-	unsigned int op;
 	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
-
-	if (flags & BLKDEV_DISCARD_SECURE) {
-		if (!blk_queue_secure_erase(q))
-			return -EOPNOTSUPP;
-		op = REQ_OP_SECURE_ERASE;
-	} else {
-		if (!bdev_max_discard_sectors(bdev))
-			return -EOPNOTSUPP;
-		op = REQ_OP_DISCARD;
-	}
+	if (!bdev_max_discard_sectors(bdev))
+		return -EOPNOTSUPP;
 
 	/* In case the discard granularity isn't set by buggy device driver */
 	if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
@@ -77,7 +66,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t req_sects =
 			min(nr_sects, bio_discard_limit(bdev, sector));
 
-		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
+		bio = blk_next_bio(bio, bdev, 0, REQ_OP_DISCARD, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
 		bio->bi_iter.bi_size = req_sects << 9;
 		sector += req_sects;
@@ -103,21 +92,19 @@ EXPORT_SYMBOL(__blkdev_issue_discard);
  * @sector:	start sector
  * @nr_sects:	number of sectors to discard
  * @gfp_mask:	memory allocation flags (for bio_alloc)
- * @flags:	BLKDEV_DISCARD_* flags to control behaviour
  *
  * Description:
  *    Issue a discard request for the sectors in question.
  */
 int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags)
+		sector_t nr_sects, gfp_t gfp_mask)
 {
 	struct bio *bio = NULL;
 	struct blk_plug plug;
 	int ret;
 
 	blk_start_plug(&plug);
-	ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, flags,
-			&bio);
+	ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, &bio);
 	if (!ret && bio) {
 		ret = submit_bio_wait(bio);
 		if (ret == -EOPNOTSUPP)
@@ -314,3 +301,42 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
 	return ret;
 }
 EXPORT_SYMBOL(blkdev_issue_zeroout);
+
+int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp)
+{
+	sector_t bs_mask = (bdev_logical_block_size(bdev) >> 9) - 1;
+	unsigned int max_sectors = bdev_max_secure_erase_sectors(bdev);
+	struct bio *bio = NULL;
+	struct blk_plug plug;
+	int ret = 0;
+
+	if (max_sectors == 0)
+		return -EOPNOTSUPP;
+	if ((sector | nr_sects) & bs_mask)
+		return -EINVAL;
+	if (bdev_read_only(bdev))
+		return -EPERM;
+
+	blk_start_plug(&plug);
+	for (;;) {
+		unsigned int len = min_t(sector_t, nr_sects, max_sectors);
+
+		bio = blk_next_bio(bio, bdev, 0, REQ_OP_SECURE_ERASE, gfp);
+		bio->bi_iter.bi_sector = sector;
+		bio->bi_iter.bi_size = len;
+
+		sector += len << SECTOR_SHIFT;
+		nr_sects -= len << SECTOR_SHIFT;
+		if (!nr_sects) {
+			ret = submit_bio_wait(bio);
+			bio_put(bio);
+			break;
+		}
+		cond_resched();
+	}
+	blk_finish_plug(&plug);
+
+	return ret;
+}
+EXPORT_SYMBOL(blkdev_issue_secure_erase);
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index fd111c5001256..7e4136a60e1cc 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -115,7 +115,6 @@ static const char *const blk_queue_flag_name[] = {
 	QUEUE_FLAG_NAME(IO_STAT),
 	QUEUE_FLAG_NAME(NOXMERGES),
 	QUEUE_FLAG_NAME(ADD_RANDOM),
-	QUEUE_FLAG_NAME(SECERASE),
 	QUEUE_FLAG_NAME(SAME_FORCE),
 	QUEUE_FLAG_NAME(DEAD),
 	QUEUE_FLAG_NAME(INIT_DONE),
diff --git a/block/blk-settings.c b/block/blk-settings.c
index fd83d674afd0a..6ccceb421ed2f 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -46,6 +46,7 @@ void blk_set_default_limits(struct queue_limits *lim)
 	lim->max_zone_append_sectors = 0;
 	lim->max_discard_sectors = 0;
 	lim->max_hw_discard_sectors = 0;
+	lim->max_secure_erase_sectors = 0;
 	lim->discard_granularity = 0;
 	lim->discard_alignment = 0;
 	lim->discard_misaligned = 0;
@@ -176,6 +177,18 @@ void blk_queue_max_discard_sectors(struct request_queue *q,
 }
 EXPORT_SYMBOL(blk_queue_max_discard_sectors);
 
+/**
+ * blk_queue_max_secure_erase_sectors - set max sectors for a secure erase
+ * @q:  the request queue for the device
+ * @max_sectors: maximum number of sectors to secure_erase
+ **/
+void blk_queue_max_secure_erase_sectors(struct request_queue *q,
+		unsigned int max_sectors)
+{
+	q->limits.max_secure_erase_sectors = max_sectors;
+}
+EXPORT_SYMBOL(blk_queue_max_secure_erase_sectors);
+
 /**
  * blk_queue_max_write_zeroes_sectors - set max sectors for a single
  *                                      write zeroes
@@ -661,7 +674,8 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
 		t->discard_alignment = lcm_not_zero(t->discard_alignment, alignment) %
 			t->discard_granularity;
 	}
-
+	t->max_secure_erase_sectors = min_not_zero(t->max_secure_erase_sectors,
+						   b->max_secure_erase_sectors);
 	t->zone_write_granularity = max(t->zone_write_granularity,
 					b->zone_write_granularity);
 	t->zoned = max(t->zoned, b->zoned);
diff --git a/block/fops.c b/block/fops.c
index 9f2ecec406b04..c0ca3254d38cf 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -672,7 +672,7 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
 		break;
 	case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE:
 		error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT,
-					     len >> SECTOR_SHIFT, GFP_KERNEL, 0);
+					     len >> SECTOR_SHIFT, GFP_KERNEL);
 		break;
 	default:
 		error = -EOPNOTSUPP;
diff --git a/block/ioctl.c b/block/ioctl.c
index c2cd3ba5290ce..5b5027fa78f7e 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -83,7 +83,7 @@ static int compat_blkpg_ioctl(struct block_device *bdev,
 #endif
 
 static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
-		unsigned long arg, unsigned long flags)
+		unsigned long arg)
 {
 	uint64_t range[2];
 	uint64_t start, len;
@@ -114,15 +114,43 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
 	err = truncate_bdev_range(bdev, mode, start, start + len - 1);
 	if (err)
 		goto fail;
-
-	err = blkdev_issue_discard(bdev, start >> 9, len >> 9,
-				   GFP_KERNEL, flags);
-
+	err = blkdev_issue_discard(bdev, start >> 9, len >> 9, GFP_KERNEL);
 fail:
 	filemap_invalidate_unlock(inode->i_mapping);
 	return err;
 }
 
+static int blk_ioctl_secure_erase(struct block_device *bdev, fmode_t mode,
+		void __user *argp)
+{
+	uint64_t start, len;
+	uint64_t range[2];
+	int err;
+
+	if (!(mode & FMODE_WRITE))
+		return -EBADF;
+	if (!bdev_max_secure_erase_sectors(bdev))
+		return -EOPNOTSUPP;
+	if (copy_from_user(range, argp, sizeof(range)))
+		return -EFAULT;
+
+	start = range[0];
+	len = range[1];
+	if ((start & 511) || (len & 511))
+		return -EINVAL;
+	if (start + len > bdev_nr_bytes(bdev))
+		return -EINVAL;
+
+	filemap_invalidate_lock(bdev->bd_inode->i_mapping);
+	err = truncate_bdev_range(bdev, mode, start, start + len - 1);
+	if (!err)
+		err = blkdev_issue_secure_erase(bdev, start >> 9, len >> 9,
+						GFP_KERNEL);
+	filemap_invalidate_unlock(bdev->bd_inode->i_mapping);
+	return err;
+}
+
+
 static int blk_ioctl_zeroout(struct block_device *bdev, fmode_t mode,
 		unsigned long arg)
 {
@@ -450,10 +478,9 @@ static int blkdev_common_ioctl(struct block_device *bdev, fmode_t mode,
 	case BLKROSET:
 		return blkdev_roset(bdev, mode, cmd, arg);
 	case BLKDISCARD:
-		return blk_ioctl_discard(bdev, mode, arg, 0);
+		return blk_ioctl_discard(bdev, mode, arg);
 	case BLKSECDISCARD:
-		return blk_ioctl_discard(bdev, mode, arg,
-				BLKDEV_DISCARD_SECURE);
+		return blk_ioctl_secure_erase(bdev, mode, argp);
 	case BLKZEROOUT:
 		return blk_ioctl_zeroout(bdev, mode, arg);
 	case BLKGETDISKSEQ:
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 275c53c7b629e..2957b0b68d600 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1547,7 +1547,8 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		start = tmp;
 	}
 	while (nr_sectors >= max_discard_sectors) {
-		err |= blkdev_issue_discard(bdev, start, max_discard_sectors, GFP_NOIO, 0);
+		err |= blkdev_issue_discard(bdev, start, max_discard_sectors,
+					    GFP_NOIO);
 		nr_sectors -= max_discard_sectors;
 		start += max_discard_sectors;
 	}
@@ -1559,7 +1560,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		nr = nr_sectors;
 		nr -= (unsigned int)nr % granularity;
 		if (nr) {
-			err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO, 0);
+			err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO);
 			nr_sectors -= nr;
 			start += nr;
 		}
diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index efa99a3884507..d178be175ad99 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1365,8 +1365,8 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
 	dev->queue->limits.discard_granularity	= dev->discard_granularity;
 	dev->queue->limits.discard_alignment	= dev->discard_alignment;
 	if (dev->secure_discard)
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, dev->queue);
-
+		blk_queue_max_secure_erase_sectors(dev->queue,
+				dev->max_discard_sectors);
 	blk_queue_flag_set(QUEUE_FLAG_SAME_COMP, dev->queue);
 	blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue);
 	blk_queue_max_segments(dev->queue, dev->max_segments);
diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index 1f7e1c8fd4d9b..d080a0de59225 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -44,7 +44,7 @@ static inline int rnbd_dev_get_max_hw_sects(const struct rnbd_dev *dev)
 
 static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
 {
-	return blk_queue_secure_erase(bdev_get_queue(dev->bdev));
+	return bdev_max_secure_erase_sectors(dev->bdev);
 }
 
 static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index de42458195bc1..a97f2bf5b01b9 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -970,7 +970,6 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
 	int status = BLKIF_RSP_OKAY;
 	struct xen_blkif *blkif = ring->blkif;
 	struct block_device *bdev = blkif->vbd.bdev;
-	unsigned long secure;
 	struct phys_req preq;
 
 	xen_blkif_get(blkif);
@@ -987,13 +986,15 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
 	}
 	ring->st_ds_req++;
 
-	secure = (blkif->vbd.discard_secure &&
-		 (req->u.discard.flag & BLKIF_DISCARD_SECURE)) ?
-		 BLKDEV_DISCARD_SECURE : 0;
+	if (blkif->vbd.discard_secure &&
+	    (req->u.discard.flag & BLKIF_DISCARD_SECURE))
+		err = blkdev_issue_secure_erase(bdev,
+				req->u.discard.sector_number,
+				req->u.discard.nr_sectors, GFP_KERNEL);
+	else
+		err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
+				req->u.discard.nr_sectors, GFP_KERNEL);
 
-	err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
-				   req->u.discard.nr_sectors,
-				   GFP_KERNEL, secure);
 fail_response:
 	if (err == -EOPNOTSUPP) {
 		pr_debug("discard op failed, not supported\n");
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 83cd08041e6b3..b21bffc9c50bc 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -484,7 +484,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 {
 	struct xen_vbd *vbd;
 	struct block_device *bdev;
-	struct request_queue *q;
 
 	vbd = &blkif->vbd;
 	vbd->handle   = handle;
@@ -516,11 +515,9 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 	if (vbd->bdev->bd_disk->flags & GENHD_FL_REMOVABLE)
 		vbd->type |= VDISK_REMOVABLE;
 
-	q = bdev_get_queue(bdev);
 	if (bdev_write_cache(bdev))
 		vbd->flush_support = true;
-
-	if (q && blk_queue_secure_erase(q))
+	if (bdev_max_secure_erase_sectors(bdev))
 		vbd->discard_secure = true;
 
 	vbd->feature_gnt_persistent = feature_persistent;
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 253bf835aca1f..9fb7c69f72b2d 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -949,7 +949,8 @@ static void blkif_set_queue_limits(struct blkfront_info *info)
 						 info->physical_sector_size;
 		rq->limits.discard_alignment = info->discard_alignment;
 		if (info->feature_secdiscard)
-			blk_queue_flag_set(QUEUE_FLAG_SECERASE, rq);
+			blk_queue_max_secure_erase_sectors(rq,
+							   get_capacity(gd));
 	}
 
 	/* Hard sector size and max sectors impersonate the equiv. hardware. */
@@ -1605,7 +1606,7 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
 				blkif_req(req)->error = BLK_STS_NOTSUPP;
 				info->feature_discard = 0;
 				info->feature_secdiscard = 0;
-				blk_queue_flag_clear(QUEUE_FLAG_SECERASE, rq);
+				blk_queue_max_secure_erase_sectors(rq, 0);
 			}
 			break;
 		case BLKIF_OP_FLUSH_DISKCACHE:
diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
index 097577ae3c471..ce13c272c3872 100644
--- a/drivers/md/bcache/alloc.c
+++ b/drivers/md/bcache/alloc.c
@@ -336,7 +336,7 @@ static int bch_allocator_thread(void *arg)
 				mutex_unlock(&ca->set->bucket_lock);
 				blkdev_issue_discard(ca->bdev,
 					bucket_to_sector(ca->set, bucket),
-					ca->sb.bucket_size, GFP_KERNEL, 0);
+					ca->sb.bucket_size, GFP_KERNEL);
 				mutex_lock(&ca->set->bucket_lock);
 			}
 
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 0dff6907fd00d..e7d42f6335a2a 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1920,9 +1920,7 @@ static int device_not_secure_erase_capable(struct dm_target *ti,
 					   struct dm_dev *dev, sector_t start,
 					   sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_secure_erase(q);
+	return !bdev_max_secure_erase_sectors(dev->bdev);
 }
 
 static bool dm_table_supports_secure_erase(struct dm_table *t)
@@ -1975,8 +1973,8 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
 		q->limits.discard_misaligned = 0;
 	}
 
-	if (dm_table_supports_secure_erase(t))
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
+	if (!dm_table_supports_secure_erase(t))
+		q->limits.max_secure_erase_sectors = 0;
 
 	if (dm_table_supports_flush(t, (1UL << QUEUE_FLAG_WC))) {
 		wc = true;
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index eded4bcc4545f..84c083f766736 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -398,8 +398,8 @@ static int issue_discard(struct discard_op *op, dm_block_t data_b, dm_block_t da
 	sector_t s = block_to_sectors(tc->pool, data_b);
 	sector_t len = block_to_sectors(tc->pool, data_e - data_b);
 
-	return __blkdev_issue_discard(tc->pool_dev->bdev, s, len,
-				      GFP_NOWAIT, 0, &op->bio);
+	return __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOWAIT,
+				      &op->bio);
 }
 
 static void end_discard(struct discard_op *op, int r)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 19636c2f2cda4..2587f872c0884 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8584,7 +8584,7 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
 {
 	struct bio *discard_bio = NULL;
 
-	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, 0,
+	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,
 			&discard_bio) || !discard_bio)
 		return;
 
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index c3cbf9a574a39..094a4042589eb 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1344,14 +1344,14 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
 	if (log->last_checkpoint < end) {
 		blkdev_issue_discard(bdev,
 				log->last_checkpoint + log->rdev->data_offset,
-				end - log->last_checkpoint, GFP_NOIO, 0);
+				end - log->last_checkpoint, GFP_NOIO);
 	} else {
 		blkdev_issue_discard(bdev,
 				log->last_checkpoint + log->rdev->data_offset,
 				log->device_size - log->last_checkpoint,
-				GFP_NOIO, 0);
+				GFP_NOIO);
 		blkdev_issue_discard(bdev, log->rdev->data_offset, end,
-				GFP_NOIO, 0);
+				GFP_NOIO);
 	}
 }
 
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index cac6315010a3d..a3d4460055716 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -189,7 +189,7 @@ static void mmc_queue_setup_discard(struct request_queue *q,
 	if (card->pref_erase > max_discard)
 		q->limits.discard_granularity = SECTOR_SIZE;
 	if (mmc_can_secure_erase_trim(card))
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
+		blk_queue_max_secure_erase_sectors(q, max_discard);
 }
 
 static unsigned short mmc_get_max_segments(struct mmc_host *host)
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
index d886c2c59554f..27a72504d31ce 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
+++ b/drivers/nvme/target/io-cmd-bdev.c
@@ -360,7 +360,7 @@ static u16 nvmet_bdev_discard_range(struct nvmet_req *req,
 	ret = __blkdev_issue_discard(ns->bdev,
 			nvmet_lba_to_sect(ns, range->slba),
 			le32_to_cpu(range->nlb) << (ns->blksize_shift - 9),
-			GFP_KERNEL, 0, bio);
+			GFP_KERNEL, bio);
 	if (ret && ret != -EOPNOTSUPP) {
 		req->error_slba = le64_to_cpu(range->slba);
 		return errno_to_nvme_status(req, ret);
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index b6ba582b06775..e68f1cc8ef98b 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -558,7 +558,7 @@ fd_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
 		ret = blkdev_issue_discard(bdev,
 					   target_to_linux_sector(dev, lba),
 					   target_to_linux_sector(dev,  nolb),
-					   GFP_KERNEL, 0);
+					   GFP_KERNEL);
 		if (ret < 0) {
 			pr_warn("FILEIO: blkdev_issue_discard() failed: %d\n",
 				ret);
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index c4a903b8a47fc..378c80313a0f2 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -434,7 +434,7 @@ iblock_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
 	ret = blkdev_issue_discard(bdev,
 				   target_to_linux_sector(dev, lba),
 				   target_to_linux_sector(dev,  nolb),
-				   GFP_KERNEL, 0);
+				   GFP_KERNEL);
 	if (ret < 0) {
 		pr_err("blkdev_issue_discard() failed: %d\n", ret);
 		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index efd8deb3ab7e8..5c1d3a564da5a 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1239,7 +1239,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
 
 		if (size) {
 			ret = blkdev_issue_discard(bdev, start >> 9, size >> 9,
-						   GFP_NOFS, 0);
+						   GFP_NOFS);
 			if (!ret)
 				*discarded_bytes += size;
 			else if (ret != -EOPNOTSUPP)
@@ -1256,7 +1256,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
 
 	if (bytes_left) {
 		ret = blkdev_issue_discard(bdev, start >> 9, bytes_left >> 9,
-					   GFP_NOFS, 0);
+					   GFP_NOFS);
 		if (!ret)
 			*discarded_bytes += bytes_left;
 	}
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 6d1820536d88d..ea653d19f9ec7 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3629,7 +3629,7 @@ static inline int ext4_issue_discard(struct super_block *sb,
 		return __blkdev_issue_discard(sb->s_bdev,
 			(sector_t)discard_block << (sb->s_blocksize_bits - 9),
 			(sector_t)count << (sb->s_blocksize_bits - 9),
-			GFP_NOFS, 0, biop);
+			GFP_NOFS, biop);
 	} else
 		return sb_issue_discard(sb, discard_block, count, GFP_NOFS, 0);
 }
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 8053d99f3920b..35b6c720c2bc1 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3685,18 +3685,18 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg)
 static int f2fs_secure_erase(struct block_device *bdev, struct inode *inode,
 		pgoff_t off, block_t block, block_t len, u32 flags)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	sector_t sector = SECTOR_FROM_BLOCK(block);
 	sector_t nr_sects = SECTOR_FROM_BLOCK(len);
 	int ret = 0;
 
-	if (!q)
-		return -ENXIO;
-
-	if (flags & F2FS_TRIM_FILE_DISCARD)
-		ret = blkdev_issue_discard(bdev, sector, nr_sects, GFP_NOFS,
-						blk_queue_secure_erase(q) ?
-						BLKDEV_DISCARD_SECURE : 0);
+	if (flags & F2FS_TRIM_FILE_DISCARD) {
+		if (bdev_max_secure_erase_sectors(bdev))
+			ret = blkdev_issue_secure_erase(bdev, sector, nr_sects,
+					GFP_NOFS);
+		else
+			ret = blkdev_issue_discard(bdev, sector, nr_sects,
+					GFP_NOFS);
+	}
 
 	if (!ret && (flags & F2FS_TRIM_FILE_ZEROOUT)) {
 		if (IS_ENCRYPTED(inode))
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 71f09adbcba86..e433c61e64b93 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1244,7 +1244,7 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
 		err = __blkdev_issue_discard(bdev,
 					SECTOR_FROM_BLOCK(start),
 					SECTOR_FROM_BLOCK(len),
-					GFP_NOFS, 0, &bio);
+					GFP_NOFS, &bio);
 submit:
 		if (err) {
 			spin_lock_irqsave(&dc->lock, flags);
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 19d226cd4ff4d..c0cbeeaec2d1a 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1825,7 +1825,7 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 			err = blkdev_issue_discard(journal->j_dev,
 					byte_start >> SECTOR_SHIFT,
 					byte_count >> SECTOR_SHIFT,
-					GFP_NOFS, 0);
+					GFP_NOFS);
 		} else if (flags & JBD2_JOURNAL_FLUSH_ZEROOUT) {
 			err = blkdev_issue_zeroout(journal->j_dev,
 					byte_start >> SECTOR_SHIFT,
diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c
index e385cca2004a7..77ff8e95421fa 100644
--- a/fs/nilfs2/sufile.c
+++ b/fs/nilfs2/sufile.c
@@ -1100,7 +1100,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
 				ret = blkdev_issue_discard(nilfs->ns_bdev,
 						start * sects_per_block,
 						nblocks * sects_per_block,
-						GFP_NOFS, 0);
+						GFP_NOFS);
 				if (ret < 0) {
 					put_bh(su_bh);
 					goto out_sem;
@@ -1134,7 +1134,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
 			ret = blkdev_issue_discard(nilfs->ns_bdev,
 					start * sects_per_block,
 					nblocks * sects_per_block,
-					GFP_NOFS, 0);
+					GFP_NOFS);
 			if (!ret)
 				ndiscarded += nblocks;
 		}
diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c
index dd48a8f74d577..3b4a079c9617c 100644
--- a/fs/nilfs2/the_nilfs.c
+++ b/fs/nilfs2/the_nilfs.c
@@ -672,7 +672,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
 			ret = blkdev_issue_discard(nilfs->ns_bdev,
 						   start * sects_per_block,
 						   nblocks * sects_per_block,
-						   GFP_NOFS, 0);
+						   GFP_NOFS);
 			if (ret < 0)
 				return ret;
 			nblocks = 0;
@@ -682,7 +682,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
 		ret = blkdev_issue_discard(nilfs->ns_bdev,
 					   start * sects_per_block,
 					   nblocks * sects_per_block,
-					   GFP_NOFS, 0);
+					   GFP_NOFS);
 	return ret;
 }
 
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 5f2e414cfa79b..5781b9e8e3d85 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1333,7 +1333,7 @@ int ntfs_discard(struct ntfs_sb_info *sbi, CLST lcn, CLST len)
 		return 0;
 
 	err = blkdev_issue_discard(sb->s_bdev, start >> 9, (end - start) >> 9,
-				   GFP_NOFS, 0);
+				   GFP_NOFS);
 
 	if (err == -EOPNOTSUPP)
 		sbi->flags |= NTFS_FLAGS_NODISCARD;
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index e2ada115c23f9..c6fe3f6ebb6b0 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -114,7 +114,7 @@ xfs_trim_extents(
 		}
 
 		trace_xfs_discard_extent(mp, agno, fbno, flen);
-		error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS, 0);
+		error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS);
 		if (error)
 			goto out_del_cursor;
 		*blocks_trimmed += flen;
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
index ba57323bfdcea..c9f55e4f09571 100644
--- a/fs/xfs/xfs_log_cil.c
+++ b/fs/xfs/xfs_log_cil.c
@@ -605,7 +605,7 @@ xlog_discard_busy_extents(
 		error = __blkdev_issue_discard(mp->m_ddev_targp->bt_bdev,
 				XFS_AGB_TO_DADDR(mp, busyp->agno, busyp->bno),
 				XFS_FSB_TO_BB(mp, busyp->length),
-				GFP_NOFS, 0, &bio);
+				GFP_NOFS, &bio);
 		if (error && error != -EOPNOTSUPP) {
 			xfs_info(mp,
 	 "discard failed for extent [0x%llx,%u], error %d",
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f1cf557ea20ef..c9b5925af5a3b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -248,6 +248,7 @@ struct queue_limits {
 	unsigned int		io_opt;
 	unsigned int		max_discard_sectors;
 	unsigned int		max_hw_discard_sectors;
+	unsigned int		max_secure_erase_sectors;
 	unsigned int		max_write_zeroes_sectors;
 	unsigned int		max_zone_append_sectors;
 	unsigned int		discard_granularity;
@@ -542,7 +543,6 @@ struct request_queue {
 #define QUEUE_FLAG_IO_STAT	7	/* do disk/partitions IO accounting */
 #define QUEUE_FLAG_NOXMERGES	9	/* No extended merges */
 #define QUEUE_FLAG_ADD_RANDOM	10	/* Contributes to random pool */
-#define QUEUE_FLAG_SECERASE	11	/* supports secure erase */
 #define QUEUE_FLAG_SAME_FORCE	12	/* force complete on same CPU */
 #define QUEUE_FLAG_DEAD		13	/* queue tear-down finished */
 #define QUEUE_FLAG_INIT_DONE	14	/* queue is initialized */
@@ -583,8 +583,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 #define blk_queue_add_random(q)	test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
 #define blk_queue_zone_resetall(q)	\
 	test_bit(QUEUE_FLAG_ZONE_RESETALL, &(q)->queue_flags)
-#define blk_queue_secure_erase(q) \
-	(test_bit(QUEUE_FLAG_SECERASE, &(q)->queue_flags))
 #define blk_queue_dax(q)	test_bit(QUEUE_FLAG_DAX, &(q)->queue_flags)
 #define blk_queue_pci_p2pdma(q)	\
 	test_bit(QUEUE_FLAG_PCI_P2PDMA, &(q)->queue_flags)
@@ -947,6 +945,8 @@ extern void blk_queue_chunk_sectors(struct request_queue *, unsigned int);
 extern void blk_queue_max_segments(struct request_queue *, unsigned short);
 extern void blk_queue_max_discard_segments(struct request_queue *,
 		unsigned short);
+void blk_queue_max_secure_erase_sectors(struct request_queue *q,
+		unsigned int max_sectors);
 extern void blk_queue_max_segment_size(struct request_queue *, unsigned int);
 extern void blk_queue_max_discard_sectors(struct request_queue *q,
 		unsigned int max_discard_sectors);
@@ -1087,13 +1087,12 @@ static inline long nr_blockdev_pages(void)
 
 extern void blk_io_schedule(void);
 
-#define BLKDEV_DISCARD_SECURE	(1 << 0)	/* issue a secure erase */
-
-extern int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags);
-extern int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, int flags,
-		struct bio **biop);
+int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp_mask);
+int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp_mask, struct bio **biop);
+int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp);
 
 #define BLKDEV_ZERO_NOUNMAP	(1 << 0)  /* do not free blocks */
 #define BLKDEV_ZERO_NOFALLBACK	(1 << 1)  /* don't write explicit zeroes */
@@ -1112,7 +1111,7 @@ static inline int sb_issue_discard(struct super_block *sb, sector_t block,
 					      SECTOR_SHIFT),
 				    nr_blocks << (sb->s_blocksize_bits -
 						  SECTOR_SHIFT),
-				    gfp_mask, flags);
+				    gfp_mask);
 }
 static inline int sb_issue_zeroout(struct super_block *sb, sector_t block,
 		sector_t nr_blocks, gfp_t gfp_mask)
@@ -1262,6 +1261,12 @@ static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
 	return bdev_get_queue(bdev)->limits.discard_granularity;
 }
 
+static inline unsigned int
+bdev_max_secure_erase_sectors(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.max_secure_erase_sectors;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 5d9cedf9e7b84..a2b31fea0c42e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -179,7 +179,7 @@ static int discard_swap(struct swap_info_struct *si)
 	nr_blocks = ((sector_t)se->nr_pages - 1) << (PAGE_SHIFT - 9);
 	if (nr_blocks) {
 		err = blkdev_issue_discard(si->bdev, start_block,
-				nr_blocks, GFP_KERNEL, 0);
+				nr_blocks, GFP_KERNEL);
 		if (err)
 			return err;
 		cond_resched();
@@ -190,7 +190,7 @@ static int discard_swap(struct swap_info_struct *si)
 		nr_blocks = (sector_t)se->nr_pages << (PAGE_SHIFT - 9);
 
 		err = blkdev_issue_discard(si->bdev, start_block,
-				nr_blocks, GFP_KERNEL, 0);
+				nr_blocks, GFP_KERNEL);
 		if (err)
 			break;
 
@@ -254,7 +254,7 @@ static void discard_swap_cluster(struct swap_info_struct *si,
 		start_block <<= PAGE_SHIFT - 9;
 		nr_blocks <<= PAGE_SHIFT - 9;
 		if (blkdev_issue_discard(si->bdev, start_block,
-					nr_blocks, GFP_NOIO, 0))
+					nr_blocks, GFP_NOIO))
 			break;
 
 		se = next_se(se);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299568.510568 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypr-0001Sm-TZ; Wed, 06 Apr 2022 06:08:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299568.510568; Wed, 06 Apr 2022 06:08:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypr-0001QF-DW; Wed, 06 Apr 2022 06:08:07 +0000
Received: by outflank-mailman (input) for mailman id 299568;
 Wed, 06 Apr 2022 06:08:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyot-0000i6-RT
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:07:08 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c5bed67b-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:07:01 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyoa-003vqQ-VR; Wed, 06 Apr 2022 06:06:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5bed67b-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=fOA6HhdQwYdtrtL1hoRuoW0heQWJKyz1xlizKSU+7HM=; b=DKlDOl7yeZLO0+KANvmBPSKMim
	lZC2ch/q/B09fZgvbS9dEdo0uQmrUfq8oj5Z6skQkr0RTSVAnpWu5iewXxr0qjCP+6UBov2XMXrhS
	T6XVQ+GIPj4fU8e+QVTVNJ+Mo0CVQ1VCs4VqwPpIonaQp2MIZE1RL4KmVwVpN0tN+xjH853V0prGs
	wCkHNCCq5KBsqZGL0xnKqB1Sv8r3ykCXcE8NW0mCaArwldoKX+A30EADx+wDqrS3IuQzTmtmUSKIm
	2GAVE5kjyX3+kr1Yzaz6qIznd8GwtYCoIWTNv7EoAyOdONV6YIa7J+6oXn9t+SmWFEJQQS3LWYWkl
	3y/vVgzg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 23/27] block: add a bdev_max_discard_sectors helper
Date: Wed,  6 Apr 2022 08:05:12 +0200
Message-Id: <20220406060516.409838-24-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to query the number of sectors support per each discard bio
based on the block device and use this helper to stop various places from
poking into the request_queue to see if discard is supported and if so how
much.  This mirrors what is done e.g. for write zeroes as well.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-core.c                    |  2 +-
 block/blk-lib.c                     |  2 +-
 block/ioctl.c                       |  3 +--
 drivers/block/drbd/drbd_main.c      |  2 +-
 drivers/block/drbd/drbd_nl.c        | 12 +++++++-----
 drivers/block/drbd/drbd_receiver.c  |  5 ++---
 drivers/block/loop.c                |  9 +++------
 drivers/block/rnbd/rnbd-srv-dev.h   |  6 +-----
 drivers/block/xen-blkback/xenbus.c  |  2 +-
 drivers/md/bcache/request.c         |  4 ++--
 drivers/md/bcache/super.c           |  2 +-
 drivers/md/bcache/sysfs.c           |  2 +-
 drivers/md/dm-cache-target.c        |  9 +--------
 drivers/md/dm-clone-target.c        |  9 +--------
 drivers/md/dm-io.c                  |  2 +-
 drivers/md/dm-log-writes.c          |  3 +--
 drivers/md/dm-raid.c                |  9 ++-------
 drivers/md/dm-table.c               |  4 +---
 drivers/md/dm-thin.c                |  9 +--------
 drivers/md/dm.c                     |  2 +-
 drivers/md/md-linear.c              |  4 ++--
 drivers/md/raid0.c                  |  2 +-
 drivers/md/raid1.c                  |  6 +++---
 drivers/md/raid10.c                 |  8 ++++----
 drivers/md/raid5-cache.c            |  2 +-
 drivers/target/target_core_device.c |  8 +++-----
 fs/btrfs/extent-tree.c              |  4 ++--
 fs/btrfs/ioctl.c                    |  2 +-
 fs/exfat/file.c                     |  2 +-
 fs/exfat/super.c                    | 10 +++-------
 fs/ext4/ioctl.c                     | 10 +++-------
 fs/ext4/super.c                     | 10 +++-------
 fs/f2fs/f2fs.h                      |  3 +--
 fs/f2fs/segment.c                   |  6 ++----
 fs/fat/file.c                       |  2 +-
 fs/fat/inode.c                      | 10 +++-------
 fs/gfs2/rgrp.c                      |  2 +-
 fs/jbd2/journal.c                   |  7 ++-----
 fs/jfs/ioctl.c                      |  2 +-
 fs/jfs/super.c                      |  8 ++------
 fs/nilfs2/ioctl.c                   |  2 +-
 fs/ntfs3/file.c                     |  2 +-
 fs/ntfs3/super.c                    |  2 +-
 fs/ocfs2/ioctl.c                    |  2 +-
 fs/xfs/xfs_discard.c                |  2 +-
 fs/xfs/xfs_super.c                  | 12 ++++--------
 include/linux/blkdev.h              |  5 +++++
 mm/swapfile.c                       | 17 ++---------------
 48 files changed, 87 insertions(+), 163 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 937bb6b863317..b5c3a8049134c 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -820,7 +820,7 @@ void submit_bio_noacct(struct bio *bio)
 
 	switch (bio_op(bio)) {
 	case REQ_OP_DISCARD:
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(bdev))
 			goto not_supported;
 		break;
 	case REQ_OP_SECURE_ERASE:
diff --git a/block/blk-lib.c b/block/blk-lib.c
index 2ae32a722851c..8b4b66d3a9bfc 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -53,7 +53,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 			return -EOPNOTSUPP;
 		op = REQ_OP_SECURE_ERASE;
 	} else {
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(bdev))
 			return -EOPNOTSUPP;
 		op = REQ_OP_DISCARD;
 	}
diff --git a/block/ioctl.c b/block/ioctl.c
index ad3771b268b81..c2cd3ba5290ce 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -87,14 +87,13 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
 {
 	uint64_t range[2];
 	uint64_t start, len;
-	struct request_queue *q = bdev_get_queue(bdev);
 	struct inode *inode = bdev->bd_inode;
 	int err;
 
 	if (!(mode & FMODE_WRITE))
 		return -EBADF;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(range, (void __user *)arg, sizeof(range)))
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 9d43aadde19ad..8fd89a1b0b7b3 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -942,7 +942,7 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 			cpu_to_be32(bdev_alignment_offset(bdev));
 		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
 		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
-		p->qlim->discard_enabled = blk_queue_discard(q);
+		p->qlim->discard_enabled = !!bdev_max_discard_sectors(bdev);
 		p->qlim->write_same_capable = 0;
 		put_ldev(device);
 	} else {
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 40bb0b356a6d6..8e28e0a8e5e41 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1210,7 +1210,7 @@ static void decide_on_discard_support(struct drbd_device *device,
 		first_peer_device(device)->connection;
 	struct request_queue *q = device->rq_queue;
 
-	if (bdev && !blk_queue_discard(bdev->backing_bdev->bd_disk->queue))
+	if (bdev && !bdev_max_discard_sectors(bdev->backing_bdev))
 		goto not_supported;
 
 	if (connection->cstate >= C_CONNECTED &&
@@ -1439,14 +1439,15 @@ static bool write_ordering_changed(struct disk_conf *a, struct disk_conf *b)
 static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *disk_conf,
 			       struct drbd_backing_dev *nbc)
 {
-	struct request_queue * const q = nbc->backing_bdev->bd_disk->queue;
+	struct block_device *bdev = nbc->backing_bdev;
+	struct request_queue *q = bdev->bd_disk->queue;
 
 	if (disk_conf->al_extents < DRBD_AL_EXTENTS_MIN)
 		disk_conf->al_extents = DRBD_AL_EXTENTS_MIN;
 	if (disk_conf->al_extents > drbd_al_extents_max(nbc))
 		disk_conf->al_extents = drbd_al_extents_max(nbc);
 
-	if (!blk_queue_discard(q)) {
+	if (!bdev_max_discard_sectors(bdev)) {
 		if (disk_conf->rs_discard_granularity) {
 			disk_conf->rs_discard_granularity = 0; /* disable feature */
 			drbd_info(device, "rs_discard_granularity feature disabled\n");
@@ -1455,6 +1456,7 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 
 	if (disk_conf->rs_discard_granularity) {
 		int orig_value = disk_conf->rs_discard_granularity;
+		sector_t discard_size = bdev_max_discard_sectors(bdev) << 9;
 		int remainder;
 
 		if (q->limits.discard_granularity > disk_conf->rs_discard_granularity)
@@ -1463,8 +1465,8 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 		remainder = disk_conf->rs_discard_granularity % q->limits.discard_granularity;
 		disk_conf->rs_discard_granularity += remainder;
 
-		if (disk_conf->rs_discard_granularity > q->limits.max_discard_sectors << 9)
-			disk_conf->rs_discard_granularity = q->limits.max_discard_sectors << 9;
+		if (disk_conf->rs_discard_granularity > discard_size)
+			disk_conf->rs_discard_granularity = discard_size;
 
 		if (disk_conf->rs_discard_granularity != orig_value)
 			drbd_info(device, "rs_discard_granularity changed to %d\n",
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 08da922f81d1d..8a4a47da56fe9 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1524,7 +1524,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 	granularity = max(q->limits.discard_granularity >> 9, 1U);
 	alignment = (bdev_discard_alignment(bdev) >> 9) % granularity;
 
-	max_discard_sectors = min(q->limits.max_discard_sectors, (1U << 22));
+	max_discard_sectors = min(bdev_max_discard_sectors(bdev), (1U << 22));
 	max_discard_sectors -= max_discard_sectors % granularity;
 	if (unlikely(!max_discard_sectors))
 		goto zero_out;
@@ -1575,11 +1575,10 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 
 static bool can_do_reliable_discards(struct drbd_device *device)
 {
-	struct request_queue *q = bdev_get_queue(device->ldev->backing_bdev);
 	struct disk_conf *dc;
 	bool can_do;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(device->ldev->backing_bdev))
 		return false;
 
 	rcu_read_lock();
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 8d800d46e4985..4b919b75205a7 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -314,15 +314,12 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
 
 	mode |= FALLOC_FL_KEEP_SIZE;
 
-	if (!blk_queue_discard(lo->lo_queue)) {
-		ret = -EOPNOTSUPP;
-		goto out;
-	}
+	if (!bdev_max_discard_sectors(lo->lo_device))
+		return -EOPNOTSUPP;
 
 	ret = file->f_op->fallocate(file, mode, pos, blk_rq_bytes(rq));
 	if (unlikely(ret && ret != -EINVAL && ret != -EOPNOTSUPP))
-		ret = -EIO;
- out:
+		return -EIO;
 	return ret;
 }
 
diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index 2c3df02b5e8ec..1f7e1c8fd4d9b 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -49,11 +49,7 @@ static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
 
 static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
 {
-	if (!blk_queue_discard(bdev_get_queue(dev->bdev)))
-		return 0;
-
-	return blk_queue_get_max_sectors(bdev_get_queue(dev->bdev),
-					 REQ_OP_DISCARD);
+	return bdev_max_discard_sectors(dev->bdev);
 }
 
 static inline int rnbd_dev_get_discard_granularity(const struct rnbd_dev *dev)
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 8b691fe50475f..83cd08041e6b3 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -583,7 +583,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
 	if (!xenbus_read_unsigned(dev->nodename, "discard-enable", 1))
 		return;
 
-	if (blk_queue_discard(q)) {
+	if (bdev_max_discard_sectors(bdev)) {
 		err = xenbus_printf(xbt, dev->nodename,
 			"discard-granularity", "%u",
 			q->limits.discard_granularity);
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index fdd0194f84dd0..e27f67f06a428 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1005,7 +1005,7 @@ static void cached_dev_write(struct cached_dev *dc, struct search *s)
 		bio_get(s->iop.bio);
 
 		if (bio_op(bio) == REQ_OP_DISCARD &&
-		    !blk_queue_discard(bdev_get_queue(dc->bdev)))
+		    !bdev_max_discard_sectors(dc->bdev))
 			goto insert_data;
 
 		/* I/O request sent to backing device */
@@ -1115,7 +1115,7 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
 	bio->bi_private = ddip;
 
 	if ((bio_op(bio) == REQ_OP_DISCARD) &&
-	    !blk_queue_discard(bdev_get_queue(dc->bdev)))
+	    !bdev_max_discard_sectors(dc->bdev))
 		bio->bi_end_io(bio);
 	else
 		submit_bio_noacct(bio);
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index bf3de149d3c9f..296f200b2e208 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -2350,7 +2350,7 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
 	ca->bdev->bd_holder = ca;
 	ca->sb_disk = sb_disk;
 
-	if (blk_queue_discard(bdev_get_queue(bdev)))
+	if (bdev_max_discard_sectors((bdev)))
 		ca->discard = CACHE_DISCARD(&ca->sb);
 
 	ret = cache_alloc(ca);
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index d1029d71ff3bc..c6f677059214d 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -1151,7 +1151,7 @@ STORE(__bch_cache)
 	if (attr == &sysfs_discard) {
 		bool v = strtoul_or_return(buf);
 
-		if (blk_queue_discard(bdev_get_queue(ca->bdev)))
+		if (bdev_max_discard_sectors(ca->bdev))
 			ca->discard = v;
 
 		if (v != CACHE_DISCARD(&ca->sb)) {
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 780a61bc6cc03..28c5de8eca4a0 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -3329,13 +3329,6 @@ static int cache_iterate_devices(struct dm_target *ti,
 	return r;
 }
 
-static bool origin_dev_supports_discard(struct block_device *origin_bdev)
-{
-	struct request_queue *q = bdev_get_queue(origin_bdev);
-
-	return blk_queue_discard(q);
-}
-
 /*
  * If discard_passdown was enabled verify that the origin device
  * supports discards.  Disable discard_passdown if not.
@@ -3349,7 +3342,7 @@ static void disable_passdown_if_not_supported(struct cache *cache)
 	if (!cache->features.discard_passdown)
 		return;
 
-	if (!origin_dev_supports_discard(origin_bdev))
+	if (!bdev_max_discard_sectors(origin_bdev))
 		reason = "discard unsupported";
 
 	else if (origin_limits->max_discard_sectors < cache->sectors_per_block)
diff --git a/drivers/md/dm-clone-target.c b/drivers/md/dm-clone-target.c
index 128316a73d016..811b0a5379d03 100644
--- a/drivers/md/dm-clone-target.c
+++ b/drivers/md/dm-clone-target.c
@@ -2016,13 +2016,6 @@ static void clone_resume(struct dm_target *ti)
 	do_waker(&clone->waker.work);
 }
 
-static bool bdev_supports_discards(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	return (q && blk_queue_discard(q));
-}
-
 /*
  * If discard_passdown was enabled verify that the destination device supports
  * discards. Disable discard_passdown if not.
@@ -2036,7 +2029,7 @@ static void disable_passdown_if_not_supported(struct clone *clone)
 	if (!test_bit(DM_CLONE_DISCARD_PASSDOWN, &clone->flags))
 		return;
 
-	if (!bdev_supports_discards(dest_dev))
+	if (!bdev_max_discard_sectors(dest_dev))
 		reason = "discard unsupported";
 	else if (dest_limits->max_discard_sectors < clone->region_size)
 		reason = "max discard sectors smaller than a region";
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
index 5762366333a27..e4b95eaeec8c7 100644
--- a/drivers/md/dm-io.c
+++ b/drivers/md/dm-io.c
@@ -311,7 +311,7 @@ static void do_region(int op, int op_flags, unsigned region,
 	 * Reject unsupported discard and write same requests.
 	 */
 	if (op == REQ_OP_DISCARD)
-		special_cmd_max_sectors = q->limits.max_discard_sectors;
+		special_cmd_max_sectors = bdev_max_discard_sectors(where->bdev);
 	else if (op == REQ_OP_WRITE_ZEROES)
 		special_cmd_max_sectors = q->limits.max_write_zeroes_sectors;
 	if ((op == REQ_OP_DISCARD || op == REQ_OP_WRITE_ZEROES) &&
diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
index c9d036d6bb2ee..e194226c89e54 100644
--- a/drivers/md/dm-log-writes.c
+++ b/drivers/md/dm-log-writes.c
@@ -866,9 +866,8 @@ static int log_writes_message(struct dm_target *ti, unsigned argc, char **argv,
 static void log_writes_io_hints(struct dm_target *ti, struct queue_limits *limits)
 {
 	struct log_writes_c *lc = ti->private;
-	struct request_queue *q = bdev_get_queue(lc->dev->bdev);
 
-	if (!q || !blk_queue_discard(q)) {
+	if (!bdev_max_discard_sectors(lc->dev->bdev)) {
 		lc->device_supports_discard = false;
 		limits->discard_granularity = lc->sectorsize;
 		limits->max_discard_sectors = (UINT_MAX >> SECTOR_SHIFT);
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 2b26435a6946e..9526ccbedafba 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2963,13 +2963,8 @@ static void configure_discard_support(struct raid_set *rs)
 	raid456 = rs_is_raid456(rs);
 
 	for (i = 0; i < rs->raid_disks; i++) {
-		struct request_queue *q;
-
-		if (!rs->dev[i].rdev.bdev)
-			continue;
-
-		q = bdev_get_queue(rs->dev[i].rdev.bdev);
-		if (!q || !blk_queue_discard(q))
+		if (!rs->dev[i].rdev.bdev ||
+		    !bdev_max_discard_sectors(rs->dev[i].rdev.bdev))
 			return;
 
 		if (raid456) {
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index d46839faa0ca5..4297c38328a9b 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1888,9 +1888,7 @@ static bool dm_table_supports_nowait(struct dm_table *t)
 static int device_not_discard_capable(struct dm_target *ti, struct dm_dev *dev,
 				      sector_t start, sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_discard(q);
+	return !bdev_max_discard_sectors(dev->bdev);
 }
 
 static bool dm_table_supports_discards(struct dm_table *t)
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index 4d25d0e270313..cd333a3e4c33b 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -2802,13 +2802,6 @@ static void requeue_bios(struct pool *pool)
 /*----------------------------------------------------------------
  * Binding of control targets to a pool object
  *--------------------------------------------------------------*/
-static bool data_dev_supports_discard(struct pool_c *pt)
-{
-	struct request_queue *q = bdev_get_queue(pt->data_dev->bdev);
-
-	return blk_queue_discard(q);
-}
-
 static bool is_factor(sector_t block_size, uint32_t n)
 {
 	return !sector_div(block_size, n);
@@ -2828,7 +2821,7 @@ static void disable_passdown_if_not_supported(struct pool_c *pt)
 	if (!pt->adjusted_pf.discard_passdown)
 		return;
 
-	if (!data_dev_supports_discard(pt))
+	if (!bdev_max_discard_sectors(pt->data_dev->bdev))
 		reason = "discard unsupported";
 
 	else if (data_limits->max_discard_sectors < pool->sectors_per_block)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 3c5fad7c4ee68..ba75933cc22ca 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -982,7 +982,7 @@ static void clone_endio(struct bio *bio)
 
 	if (unlikely(error == BLK_STS_TARGET)) {
 		if (bio_op(bio) == REQ_OP_DISCARD &&
-		    !q->limits.max_discard_sectors)
+		    !bdev_max_discard_sectors(bio->bi_bdev))
 			disable_discard(md);
 		else if (bio_op(bio) == REQ_OP_WRITE_ZEROES &&
 			 !q->limits.max_write_zeroes_sectors)
diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
index 0f55b079371b1..4dd5afff72844 100644
--- a/drivers/md/md-linear.c
+++ b/drivers/md/md-linear.c
@@ -97,7 +97,7 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 		conf->array_sectors += rdev->sectors;
 		cnt++;
 
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
+		if (bdev_max_discard_sectors(rdev->bdev))
 			discard_supported = true;
 	}
 	if (cnt != raid_disks) {
@@ -252,7 +252,7 @@ static bool linear_make_request(struct mddev *mddev, struct bio *bio)
 		start_sector + data_offset;
 
 	if (unlikely((bio_op(bio) == REQ_OP_DISCARD) &&
-		     !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) {
+		     !bdev_max_discard_sectors(bio->bi_bdev))) {
 		/* Just ignore it */
 		bio_endio(bio);
 	} else {
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index b21e101183f44..02ac3ab213c72 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -412,7 +412,7 @@ static int raid0_run(struct mddev *mddev)
 		rdev_for_each(rdev, mddev) {
 			disk_stack_limits(mddev->gendisk, rdev->bdev,
 					  rdev->data_offset << 9);
-			if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
+			if (bdev_max_discard_sectors(rdev->bdev))
 				discard_supported = true;
 		}
 		if (!discard_supported)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index d81b896855f9f..39b9cb4d54ee0 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -802,7 +802,7 @@ static void flush_bio_list(struct r1conf *conf, struct bio *bio)
 		if (test_bit(Faulty, &rdev->flags)) {
 			bio_io_error(bio);
 		} else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) &&
-				    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+				    !bdev_max_discard_sectors(bio->bi_bdev)))
 			/* Just ignore it */
 			bio_endio(bio);
 		else
@@ -1826,7 +1826,7 @@ static int raid1_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 			break;
 		}
 	}
-	if (mddev->queue && blk_queue_discard(bdev_get_queue(rdev->bdev)))
+	if (mddev->queue && bdev_max_discard_sectors(rdev->bdev))
 		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 	print_conf(conf);
 	return err;
@@ -3141,7 +3141,7 @@ static int raid1_run(struct mddev *mddev)
 			continue;
 		disk_stack_limits(mddev->gendisk, rdev->bdev,
 				  rdev->data_offset << 9);
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
+		if (bdev_max_discard_sectors(rdev->bdev))
 			discard_supported = true;
 	}
 
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 7816c8b2e8087..eaa86c6a35a55 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -888,7 +888,7 @@ static void flush_pending_writes(struct r10conf *conf)
 			if (test_bit(Faulty, &rdev->flags)) {
 				bio_io_error(bio);
 			} else if (unlikely((bio_op(bio) ==  REQ_OP_DISCARD) &&
-					    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+					    !bdev_max_discard_sectors(bio->bi_bdev)))
 				/* Just ignore it */
 				bio_endio(bio);
 			else
@@ -1083,7 +1083,7 @@ static void raid10_unplug(struct blk_plug_cb *cb, bool from_schedule)
 		if (test_bit(Faulty, &rdev->flags)) {
 			bio_io_error(bio);
 		} else if (unlikely((bio_op(bio) ==  REQ_OP_DISCARD) &&
-				    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+				    !bdev_max_discard_sectors(bio->bi_bdev)))
 			/* Just ignore it */
 			bio_endio(bio);
 		else
@@ -2144,7 +2144,7 @@ static int raid10_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 		rcu_assign_pointer(p->rdev, rdev);
 		break;
 	}
-	if (mddev->queue && blk_queue_discard(bdev_get_queue(rdev->bdev)))
+	if (mddev->queue && bdev_max_discard_sectors(rdev->bdev))
 		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 
 	print_conf(conf);
@@ -4141,7 +4141,7 @@ static int raid10_run(struct mddev *mddev)
 
 		disk->head_position = 0;
 
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
+		if (bdev_max_discard_sectors(rdev->bdev))
 			discard_supported = true;
 		first = 0;
 	}
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index a7d50ff9020a8..c3cbf9a574a39 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1318,7 +1318,7 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
 
 	r5l_write_super(log, end);
 
-	if (!blk_queue_discard(bdev_get_queue(bdev)))
+	if (!bdev_max_discard_sectors(bdev))
 		return;
 
 	mddev = log->rdev->mddev;
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 16e775bcf4a7c..7d510e4231713 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -829,9 +829,7 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
 }
 
 /*
- * Check if the underlying struct block_device request_queue supports
- * the QUEUE_FLAG_DISCARD bit for UNMAP/WRITE_SAME in SCSI + TRIM
- * in ATA and we need to set TPE=1
+ * Check if the underlying struct block_device request_queue supports disard.
  */
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 				       struct block_device *bdev)
@@ -839,11 +837,11 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	struct request_queue *q = bdev_get_queue(bdev);
 	int block_size = bdev_logical_block_size(bdev);
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(bdev))
 		return false;
 
 	attrib->max_unmap_lba_count =
-		q->limits.max_discard_sectors >> (ilog2(block_size) - 9);
+		bdev_max_discard_sectors(bdev) >> (ilog2(block_size) - 9);
 	/*
 	 * Currently hardcoded to 1 in Linux/SCSI code..
 	 */
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index f477035a2ac23..efd8deb3ab7e8 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1291,7 +1291,7 @@ static int do_discard_extent(struct btrfs_io_stripe *stripe, u64 *bytes)
 		ret = btrfs_reset_device_zone(dev_replace->tgtdev, phys, len,
 					      &discarded);
 		discarded += src_disc;
-	} else if (blk_queue_discard(bdev_get_queue(stripe->dev->bdev))) {
+	} else if (bdev_max_discard_sectors(stripe->dev->bdev)) {
 		ret = btrfs_issue_discard(dev->bdev, phys, len, &discarded);
 	} else {
 		ret = 0;
@@ -5987,7 +5987,7 @@ static int btrfs_trim_free_extents(struct btrfs_device *device, u64 *trimmed)
 	*trimmed = 0;
 
 	/* Discard not supported = nothing to do. */
-	if (!blk_queue_discard(bdev_get_queue(device->bdev)))
+	if (!bdev_max_discard_sectors(device->bdev))
 		return 0;
 
 	/* Not writable = nothing to do. */
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 238cee5b5254d..fc7953755fd8b 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -501,7 +501,7 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 		if (!device->bdev)
 			continue;
 		q = bdev_get_queue(device->bdev);
-		if (blk_queue_discard(q)) {
+		if (bdev_max_discard_sectors(device->bdev)) {
 			num_devices++;
 			minlen = min_t(u64, q->limits.discard_granularity,
 				     minlen);
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 2f51300592366..765e4f63dd18d 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -358,7 +358,7 @@ static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(inode->i_sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&range, (struct fstrim_range __user *)arg, sizeof(range)))
diff --git a/fs/exfat/super.c b/fs/exfat/super.c
index 8ca21e7917d16..be0788ecaf20e 100644
--- a/fs/exfat/super.c
+++ b/fs/exfat/super.c
@@ -627,13 +627,9 @@ static int exfat_fill_super(struct super_block *sb, struct fs_context *fc)
 	if (opts->allow_utime == (unsigned short)-1)
 		opts->allow_utime = ~opts->fs_dmask & 0022;
 
-	if (opts->discard) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-
-		if (!blk_queue_discard(q)) {
-			exfat_warn(sb, "mounting with \"discard\" option, but the device does not support discard");
-			opts->discard = 0;
-		}
+	if (opts->discard && !bdev_max_discard_sectors(sb->s_bdev)) {
+		exfat_warn(sb, "mounting with \"discard\" option, but the device does not support discard");
+		opts->discard = 0;
 	}
 
 	sb->s_flags |= SB_NODIRATIME;
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 992229ca2d830..6e3b9eea126f4 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -1044,7 +1044,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
 	__u32 flags = 0;
 	unsigned int flush_flags = 0;
 	struct super_block *sb = file_inode(filp)->i_sb;
-	struct request_queue *q;
 
 	if (copy_from_user(&flags, (__u32 __user *)arg,
 				sizeof(__u32)))
@@ -1065,10 +1064,8 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
 	if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
 		return -EINVAL;
 
-	q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);
-	if (!q)
-		return -ENXIO;
-	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !blk_queue_discard(q))
+	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
+	    !bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev))
 		return -EOPNOTSUPP;
 
 	if (flags & EXT4_IOC_CHECKPOINT_FLAG_DRY_RUN)
@@ -1393,14 +1390,13 @@ static long __ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 
 	case FITRIM:
 	{
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		int ret = 0;
 
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(sb->s_bdev))
 			return -EOPNOTSUPP;
 
 		/*
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 81749eaddf4c1..93f4e4e9e2631 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5458,13 +5458,9 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
 			goto failed_mount9;
 	}
 
-	if (test_opt(sb, DISCARD)) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-		if (!blk_queue_discard(q))
-			ext4_msg(sb, KERN_WARNING,
-				 "mounting with \"discard\" option, but "
-				 "the device does not support discard");
-	}
+	if (test_opt(sb, DISCARD) && !bdev_max_discard_sectors(sb->s_bdev))
+		ext4_msg(sb, KERN_WARNING,
+			 "mounting with \"discard\" option, but the device does not support discard");
 
 	if (es->s_error_count)
 		mod_timer(&sbi->s_err_report, jiffies + 300*HZ); /* 5 minutes */
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index cd1e65bcf0b04..0ea9a5fa7c1dd 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4381,8 +4381,7 @@ static inline bool f2fs_hw_should_discard(struct f2fs_sb_info *sbi)
 
 static inline bool f2fs_bdev_support_discard(struct block_device *bdev)
 {
-	return blk_queue_discard(bdev_get_queue(bdev)) ||
-	       bdev_is_zoned(bdev);
+	return bdev_max_discard_sectors(bdev) || bdev_is_zoned(bdev);
 }
 
 static inline bool f2fs_hw_support_discard(struct f2fs_sb_info *sbi)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 22dfeb9915290..71f09adbcba86 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1196,9 +1196,8 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
 						unsigned int *issued)
 {
 	struct block_device *bdev = dc->bdev;
-	struct request_queue *q = bdev_get_queue(bdev);
 	unsigned int max_discard_blocks =
-			SECTOR_TO_BLOCK(q->limits.max_discard_sectors);
+			SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
 	struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
 	struct list_head *wait_list = (dpolicy->type == DPOLICY_FSTRIM) ?
 					&(dcc->fstrim_list) : &(dcc->wait_list);
@@ -1375,9 +1374,8 @@ static void __update_discard_tree_range(struct f2fs_sb_info *sbi,
 	struct discard_cmd *dc;
 	struct discard_info di = {0};
 	struct rb_node **insert_p = NULL, *insert_parent = NULL;
-	struct request_queue *q = bdev_get_queue(bdev);
 	unsigned int max_discard_blocks =
-			SECTOR_TO_BLOCK(q->limits.max_discard_sectors);
+			SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
 	block_t end = lstart + len;
 
 	dc = (struct discard_cmd *)f2fs_lookup_rb_tree_ret(&dcc->root,
diff --git a/fs/fat/file.c b/fs/fat/file.c
index a5a309fcc7faf..e4c7d10e80129 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -133,7 +133,7 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	user_range = (struct fstrim_range __user *)arg;
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index bf6051bdf1d1d..3d1afb95a925a 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1872,13 +1872,9 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
 		goto out_fail;
 	}
 
-	if (sbi->options.discard) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-		if (!blk_queue_discard(q))
-			fat_msg(sb, KERN_WARNING,
-					"mounting with \"discard\" option, but "
-					"the device does not support discard");
-	}
+	if (sbi->options.discard && !bdev_max_discard_sectors(sb->s_bdev))
+		fat_msg(sb, KERN_WARNING,
+			"mounting with \"discard\" option, but the device does not support discard");
 
 	fat_set_state(sb, 1, 0);
 	return 0;
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 801ad9f4f2bef..7f20ac9133bc6 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1405,7 +1405,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
 		return -EROFS;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sdp->sd_vfs->s_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&r, argp, sizeof(r)))
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index fcacafa4510d1..19d226cd4ff4d 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1762,7 +1762,6 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 	unsigned long block, log_offset; /* logical */
 	unsigned long long phys_block, block_start, block_stop; /* physical */
 	loff_t byte_start, byte_stop, byte_count;
-	struct request_queue *q = bdev_get_queue(journal->j_dev);
 
 	/* flags must be set to either discard or zeroout */
 	if ((flags & ~JBD2_JOURNAL_FLUSH_VALID) || !flags ||
@@ -1770,10 +1769,8 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 			(flags & JBD2_JOURNAL_FLUSH_ZEROOUT)))
 		return -EINVAL;
 
-	if (!q)
-		return -ENXIO;
-
-	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !blk_queue_discard(q))
+	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
+	    !bdev_max_discard_sectors(journal->j_dev))
 		return -EOPNOTSUPP;
 
 	/*
diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
index 03a845ab4f009..357ae6e5c36ec 100644
--- a/fs/jfs/ioctl.c
+++ b/fs/jfs/ioctl.c
@@ -117,7 +117,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q)) {
+		if (!bdev_max_discard_sectors(sb->s_bdev)) {
 			jfs_warn("FITRIM not supported on device");
 			return -EOPNOTSUPP;
 		}
diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index f1a13a74cddf3..85d4f44f2ac4d 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -372,19 +372,16 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
 		}
 
 		case Opt_discard:
-		{
-			struct request_queue *q = bdev_get_queue(sb->s_bdev);
 			/* if set to 1, even copying files will cause
 			 * trimming :O
 			 * -> user has more control over the online trimming
 			 */
 			sbi->minblks_trim = 64;
-			if (blk_queue_discard(q))
+			if (bdev_max_discard_sectors(sb->s_bdev))
 				*flag |= JFS_DISCARD;
 			else
 				pr_err("JFS: discard option not supported on device\n");
 			break;
-		}
 
 		case Opt_nodiscard:
 			*flag &= ~JFS_DISCARD;
@@ -392,10 +389,9 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
 
 		case Opt_discard_minblk:
 		{
-			struct request_queue *q = bdev_get_queue(sb->s_bdev);
 			char *minblks_trim = args[0].from;
 			int rc;
-			if (blk_queue_discard(q)) {
+			if (bdev_max_discard_sectors(sb->s_bdev)) {
 				*flag |= JFS_DISCARD;
 				rc = kstrtouint(minblks_trim, 0,
 						&sbi->minblks_trim);
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
index fec194a666f4b..52b73f558fcb1 100644
--- a/fs/nilfs2/ioctl.c
+++ b/fs/nilfs2/ioctl.c
@@ -1059,7 +1059,7 @@ static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(nilfs->ns_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&range, argp, sizeof(range)))
diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index 787b53b984ee1..e763236169331 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -28,7 +28,7 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sbi->sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	user_range = (struct fstrim_range __user *)arg;
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index cd30e81abbce0..c734085bcce4a 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -913,7 +913,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	}
 
 	rq = bdev_get_queue(bdev);
-	if (blk_queue_discard(rq) && rq->limits.discard_granularity) {
+	if (bdev_max_discard_sectors(bdev) && rq->limits.discard_granularity) {
 		sbi->discard_granularity = rq->limits.discard_granularity;
 		sbi->discard_granularity_mask_inv =
 			~(u64)(sbi->discard_granularity - 1);
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index f59461d85da45..9b78ef103ada6 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -910,7 +910,7 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(sb->s_bdev))
 			return -EOPNOTSUPP;
 
 		if (copy_from_user(&range, argp, sizeof(range)))
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index 0191de8ce9ced..a4e6609d616b7 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -162,7 +162,7 @@ xfs_ioc_trim(
 
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(mp->m_ddev_targp->bt_bdev))
 		return -EOPNOTSUPP;
 
 	/*
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 54be9d64093ed..a276b8111f636 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1608,14 +1608,10 @@ xfs_fs_fill_super(
 			goto out_filestream_unmount;
 	}
 
-	if (xfs_has_discard(mp)) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-
-		if (!blk_queue_discard(q)) {
-			xfs_warn(mp, "mounting with \"discard\" option, but "
-					"the device does not support discard");
-			mp->m_features &= ~XFS_FEAT_DISCARD;
-		}
+	if (xfs_has_discard(mp) && !bdev_max_discard_sectors(sb->s_bdev)) {
+		xfs_warn(mp,
+	"mounting with \"discard\" option, but the device does not support discard");
+		mp->m_features &= ~XFS_FEAT_DISCARD;
 	}
 
 	if (xfs_has_reflink(mp)) {
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 34b1cfd067421..ce16247d3afab 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1254,6 +1254,11 @@ bdev_zone_write_granularity(struct block_device *bdev)
 int bdev_alignment_offset(struct block_device *bdev);
 unsigned int bdev_discard_alignment(struct block_device *bdev);
 
+static inline unsigned int bdev_max_discard_sectors(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.max_discard_sectors;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 4069f17a82c8e..5d9cedf9e7b84 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2957,20 +2957,6 @@ static int setup_swap_map_and_extents(struct swap_info_struct *p,
 	return nr_extents;
 }
 
-/*
- * Helper to sys_swapon determining if a given swap
- * backing device queue supports DISCARD operations.
- */
-static bool swap_discardable(struct swap_info_struct *si)
-{
-	struct request_queue *q = bdev_get_queue(si->bdev);
-
-	if (!blk_queue_discard(q))
-		return false;
-
-	return true;
-}
-
 SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 {
 	struct swap_info_struct *p;
@@ -3132,7 +3118,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 					 sizeof(long),
 					 GFP_KERNEL);
 
-	if (p->bdev && (swap_flags & SWAP_FLAG_DISCARD) && swap_discardable(p)) {
+	if ((swap_flags & SWAP_FLAG_DISCARD) &&
+	    p->bdev && bdev_max_discard_sectors(p->bdev)) {
 		/*
 		 * When discard is enabled for swap with no particular
 		 * policy flagged, we set all swap discard flags here in
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299571.510576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyps-0001hS-Qc; Wed, 06 Apr 2022 06:08:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299571.510576; Wed, 06 Apr 2022 06:08:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyps-0001cU-7Q; Wed, 06 Apr 2022 06:08:08 +0000
Received: by outflank-mailman (input) for mailman id 299571;
 Wed, 06 Apr 2022 06:08:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoY-0000hu-Th
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:46 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bc66e89c-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:06:46 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyoO-003vfZ-P9; Wed, 06 Apr 2022 06:06:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc66e89c-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=CCltYPwX8bAZQe3AOk2m+rVDM7liIR3xNyzg1pXv0K0=; b=4TnTrIex1AKKiPJXvaroOl5NsO
	OzcWSzfXydGQ7sMSzqVfjOmk1ov20W68jFz/hoIp8KbrlPpu8lOR0RmwZOsnPUBGCBW4nbEfepwlx
	ixJCSn8kR9jF/OB/YqPXuT/Tf2/M2YFkGZURh32PQbKaAFcnpj0qHFwtp/IhfWUpj2AYdMqL9Ifl+
	fDz79wz6V7QzwBw5LdMYuYetJWMtaHY/wl6mSxp52+xJQuaG7/Bxjmh7/uJ27qQAc+7vRgBb+R4FM
	D+LA3q8ztCpOto8AlmQwIjNAmnOYhlBfzF+75JNxW+D6qQTHDF7hKZpFPjkT6eoCIq5LWTogd+SSJ
	IWO/dQrQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 20/27] block: use bdev_discard_alignment in part_discard_alignment_show
Date: Wed,  6 Apr 2022 08:05:09 +0200
Message-Id: <20220406060516.409838-21-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based alignment helper instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/partitions/core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 240b3fff521e4..70dec1c78521d 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -206,11 +206,7 @@ static ssize_t part_alignment_offset_show(struct device *dev,
 static ssize_t part_discard_alignment_show(struct device *dev,
 					   struct device_attribute *attr, char *buf)
 {
-	struct block_device *bdev = dev_to_bdev(dev);
-
-	return sprintf(buf, "%u\n",
-		queue_limit_discard_alignment(&bdev_get_queue(bdev)->limits,
-				bdev->bd_start_sect));
+	return sprintf(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev)));
 }
 
 static DEVICE_ATTR(partition, 0444, part_partition_show, NULL);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299580.510595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypw-0002gO-Fu; Wed, 06 Apr 2022 06:08:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299580.510595; Wed, 06 Apr 2022 06:08:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypw-0002fv-88; Wed, 06 Apr 2022 06:08:12 +0000
Received: by outflank-mailman (input) for mailman id 299580;
 Wed, 06 Apr 2022 06:08:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoL-0000i6-FP
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:33 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b258d5fc-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:06:29 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyoD-003vVW-6V; Wed, 06 Apr 2022 06:06:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b258d5fc-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=65vdZDv/Oyhj9d7BIFQpxpieHFePRtIOo5rSsdbnvJY=; b=fnclFxf748Yk+HJEP8iaRVW3WB
	aWWIhphvzxhVY6FZKXEjV9bmsgZxn1Kj0ojlUoEizIay0h/EV1KlYq6LYsLwUZoiL+Fz08VFbrmWJ
	BYNbJJT671L+8hPCaASzQ9hicWQta9jTVuyI55rgNvXk3KOf4lbIG1gDSvXVJwm3aMnDnl4JurT3R
	S8cYXnLnqA9S0vlUcqmBeds07qoRbn35ezQfJ8pyS1RE387ITcgzq6PHUXXwRZqcO/Sk1L5arJMLy
	E+9ofKyWiYPnidQ8zD5I0ZyEozinv4MmGtOr/LudVUr7xp27guzf7u4zI6ERWqMoK3aOeUdBrl0mu
	xcCu0PRw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 17/27] block: use bdev_alignment_offset in disk_alignment_offset_show
Date: Wed,  6 Apr 2022 08:05:06 +0200
Message-Id: <20220406060516.409838-18-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

This does the same as the open coded variant except for an extra branch,
and allows to remove queue_alignment_offset entirely.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/genhd.c          | 2 +-
 include/linux/blkdev.h | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index b8b6759d670f0..712031ce19070 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1010,7 +1010,7 @@ static ssize_t disk_alignment_offset_show(struct device *dev,
 {
 	struct gendisk *disk = dev_to_disk(dev);
 
-	return sprintf(buf, "%d\n", queue_alignment_offset(disk->queue));
+	return sprintf(buf, "%d\n", bdev_alignment_offset(disk->part0));
 }
 
 static ssize_t disk_discard_alignment_show(struct device *dev,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f8c50b77543eb..d5346e72e3645 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1251,14 +1251,6 @@ bdev_zone_write_granularity(struct block_device *bdev)
 	return queue_zone_write_granularity(bdev_get_queue(bdev));
 }
 
-static inline int queue_alignment_offset(const struct request_queue *q)
-{
-	if (q->limits.misaligned)
-		return -1;
-
-	return q->limits.alignment_offset;
-}
-
 static inline int queue_limit_alignment_offset(struct queue_limits *lim, sector_t sector)
 {
 	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299581.510598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypx-0002m7-0a; Wed, 06 Apr 2022 06:08:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299581.510598; Wed, 06 Apr 2022 06:08:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbypw-0002kt-OM; Wed, 06 Apr 2022 06:08:12 +0000
Received: by outflank-mailman (input) for mailman id 299581;
 Wed, 06 Apr 2022 06:08:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoE-0000i6-Qf
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:26 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ae67a96c-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:06:22 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyo2-003vK1-1x; Wed, 06 Apr 2022 06:06:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae67a96c-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=P8BTzfbZzMhTwk+O/5Q9S2IjdA/Er5Nl5Yd1FdZzPNs=; b=jmLLAFsmpP/kGZ+yrDJsbaGT90
	3PwfbbG3wYKmDjHmMy+UJOFVGL4TGDhECV3MOyV3UV8eSqcB0oTUed5n8oqNZktxd33ScowUP7QGh
	zbHFLMbrLKGeYKPMV8S63E/RRGEzhJrhrEAo36bmKxr9IL3fiqhq4h4HV/PV2BMnFoSisR8vXTGSe
	pm93ugKsrwSXqQ5J/PUF18cWu1plS4ueu1I2pDS3596vDa7E3hJWQLYJIHPBT5CXRTFQ5Q3FfKMQJ
	gbNfl56sQdKYZDUFA7Rmbrh+TTmjlhI2tnHxRO3P8MOrLI7+hAjFr/PXAnmPHqK5dQh0zlvNaSpaR
	rj8Pm/Qw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 14/27] block: add a bdev_max_zone_append_sectors helper
Date: Wed,  6 Apr 2022 08:05:03 +0200
Message-Id: <20220406060516.409838-15-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the max supported sectors for zone append based on
the block_device instead of having to poke into the block layer internal
request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/nvme/target/zns.c | 3 +--
 fs/zonefs/super.c         | 3 +--
 include/linux/blkdev.h    | 6 ++++++
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
index e34718b095504..82b61acf7a72b 100644
--- a/drivers/nvme/target/zns.c
+++ b/drivers/nvme/target/zns.c
@@ -34,8 +34,7 @@ static int validate_conv_zones_cb(struct blk_zone *z,
 
 bool nvmet_bdev_zns_enable(struct nvmet_ns *ns)
 {
-	struct request_queue *q = ns->bdev->bd_disk->queue;
-	u8 zasl = nvmet_zasl(queue_max_zone_append_sectors(q));
+	u8 zasl = nvmet_zasl(bdev_max_zone_append_sectors(ns->bdev));
 	struct gendisk *bd_disk = ns->bdev->bd_disk;
 	int ret;
 
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index 3614c7834007d..7a63807b736c4 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -678,13 +678,12 @@ static ssize_t zonefs_file_dio_append(struct kiocb *iocb, struct iov_iter *from)
 	struct inode *inode = file_inode(iocb->ki_filp);
 	struct zonefs_inode_info *zi = ZONEFS_I(inode);
 	struct block_device *bdev = inode->i_sb->s_bdev;
-	unsigned int max;
+	unsigned int max = bdev_max_zone_append_sectors(bdev);
 	struct bio *bio;
 	ssize_t size;
 	int nr_pages;
 	ssize_t ret;
 
-	max = queue_max_zone_append_sectors(bdev_get_queue(bdev));
 	max = ALIGN_DOWN(max << SECTOR_SHIFT, inode->i_sb->s_blocksize);
 	iov_iter_truncate(from, max);
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index a433798c3343e..f8c50b77543eb 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1188,6 +1188,12 @@ static inline unsigned int queue_max_zone_append_sectors(const struct request_qu
 	return min(l->max_zone_append_sectors, l->max_sectors);
 }
 
+static inline unsigned int
+bdev_max_zone_append_sectors(struct block_device *bdev)
+{
+	return queue_max_zone_append_sectors(bdev_get_queue(bdev));
+}
+
 static inline unsigned queue_logical_block_size(const struct request_queue *q)
 {
 	int retval = 512;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299587.510616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyq0-0003gs-Pq; Wed, 06 Apr 2022 06:08:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299587.510616; Wed, 06 Apr 2022 06:08:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyq0-0003ep-IK; Wed, 06 Apr 2022 06:08:16 +0000
Received: by outflank-mailman (input) for mailman id 299587;
 Wed, 06 Apr 2022 06:08:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoI-0000hu-9V
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:30 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b23d9686-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:06:29 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyo5-003vNP-I4; Wed, 06 Apr 2022 06:06:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b23d9686-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=Z466ZFUUKBaH6hbYD0HK+8FHR1O7bsGB8sNIWBFJhOk=; b=nZyFe69pq6eqf1/kF5nMPTOAne
	TDtMwcoIcF1YVH8vK4pZn8SWXmvAy4dj0YLO+u7/f/B2HIjYkBtn4UJ8NiskaBRp3fwS47roOcVRe
	vLIrpgEvmwBi0TgLuCY4ho1EAziykjm9zmNebUkK6neSzMI32Ao85X2VP0v0J3+9ko5w3milUn2Og
	nHnr9afoa38HHNP14nGQNi1dlupB12CTU0omTrFBjKA0bBmskFyATPVPaofHC89rc0iWDgo4hGjmw
	mUDsTYktHm80+vK4Z5OqBaEmEbibKoSEKtnP9u44j73GVKdSFe+O7hLNHxfOqHQlf6RzKBjJvj/fx
	be/fnxdQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show
Date: Wed,  6 Apr 2022 08:05:04 +0200
Message-Id: <20220406060516.409838-16-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Replace the open coded offset calculation with the proper helper.
This is an ABI change in that the -1 for a misaligned partition is
properly propagated, which can be considered a bug fix and maches
what is done on the whole device.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/partitions/core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 2ef8dfa1e5c85..240b3fff521e4 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -200,11 +200,7 @@ static ssize_t part_ro_show(struct device *dev,
 static ssize_t part_alignment_offset_show(struct device *dev,
 					  struct device_attribute *attr, char *buf)
 {
-	struct block_device *bdev = dev_to_bdev(dev);
-
-	return sprintf(buf, "%u\n",
-		queue_limit_alignment_offset(&bdev_get_queue(bdev)->limits,
-				bdev->bd_start_sect));
+	return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));
 }
 
 static ssize_t part_discard_alignment_show(struct device *dev,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299592.510628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyq8-0004md-Ar; Wed, 06 Apr 2022 06:08:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299592.510628; Wed, 06 Apr 2022 06:08:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyq8-0004lJ-5t; Wed, 06 Apr 2022 06:08:24 +0000
Received: by outflank-mailman (input) for mailman id 299592;
 Wed, 06 Apr 2022 06:08:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoA-0000i6-4Q
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:22 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab68cd27-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:06:17 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyny-003vFI-1v; Wed, 06 Apr 2022 06:06:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab68cd27-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=h9nRIyL4wrpJ3ypc009/z3A2dTvKLKo4vnaU7ryfwvk=; b=a9oCdCdHg2UWHjdBX3bxPs2eKR
	5hve9tuJweiHtNscXmQk+Ivzu2Q7V3Mhv54LpOAbMMyQCJFe1pzLSFTspFhvQH5RSd3zutfvDVBle
	gc7aQWZ1G4DVpBQSlfEnNf2ldCbJPt3gAAT/HH2ojp1/M3c6g9Su6hdyodjAivFbD+KIhySRZQL+J
	uMGgYqy0Bvib+9naGiIp1U//m5d564u8ZAFKPpmnTrgGDKoliPoyKaR90tTLnVja4b5oVEZAers0q
	p77NmZVl/ZfqKctngEgkCmQ/GGwXLM4DulJii5cEYj/W60uypGBwfA+RHY+qWe7ISyRLJtvjwNf2V
	jwMR1eTA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 13/27] block: add a bdev_stable_writes helper
Date: Wed,  6 Apr 2022 08:05:02 +0200
Message-Id: <20220406060516.409838-14-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the stable writes flag based on the block_device
instead of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm-table.c  | 4 +---
 fs/super.c             | 2 +-
 include/linux/blkdev.h | 6 ++++++
 mm/swapfile.c          | 2 +-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 5e38d0dd009d5..d46839faa0ca5 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1950,9 +1950,7 @@ static int device_requires_stable_pages(struct dm_target *ti,
 					struct dm_dev *dev, sector_t start,
 					sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return blk_queue_stable_writes(q);
+	return bdev_stable_writes(dev->bdev);
 }
 
 int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
diff --git a/fs/super.c b/fs/super.c
index f1d4a193602d6..60f57c7bc0a69 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1204,7 +1204,7 @@ static int set_bdev_super(struct super_block *s, void *data)
 	s->s_dev = s->s_bdev->bd_dev;
 	s->s_bdi = bdi_get(s->s_bdev->bd_disk->bdi);
 
-	if (blk_queue_stable_writes(s->s_bdev->bd_disk->queue))
+	if (bdev_stable_writes(s->s_bdev))
 		s->s_iflags |= SB_I_STABLE_WRITES;
 	return 0;
 }
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 075b16d4560e7..a433798c3343e 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1330,6 +1330,12 @@ static inline bool bdev_nonrot(struct block_device *bdev)
 	return blk_queue_nonrot(bdev_get_queue(bdev));
 }
 
+static inline bool bdev_stable_writes(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_STABLE_WRITES,
+			&bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline bool bdev_write_cache(struct block_device *bdev)
 {
 	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index d5ab7ec4d92ca..4069f17a82c8e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -3065,7 +3065,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 		goto bad_swap_unlock_inode;
 	}
 
-	if (p->bdev && blk_queue_stable_writes(p->bdev->bd_disk->queue))
+	if (p->bdev && bdev_stable_writes(p->bdev))
 		p->flags |= SWP_STABLE_WRITES;
 
 	if (p->bdev && p->bdev->bd_disk->fops->rw_page)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299596.510639 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyqE-0005o6-Jt; Wed, 06 Apr 2022 06:08:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299596.510639; Wed, 06 Apr 2022 06:08:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyqE-0005nM-GT; Wed, 06 Apr 2022 06:08:30 +0000
Received: by outflank-mailman (input) for mailman id 299596;
 Wed, 06 Apr 2022 06:08:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyo4-0000i6-Hi
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:16 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a759df9f-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:06:10 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynm-003v6R-De; Wed, 06 Apr 2022 06:05:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a759df9f-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=fS7/GWADeMq24JkrHR7r65A2kLOtCr2spfkGah3kNA8=; b=g32cCmyoUy2MRlX0jWgIKinv+J
	6HwpKjKiI/eRm+arkMK8TDswHRb73J8oTKSPnBofpTn14CEPyZoL01LqRjOtvyeXKFbsLDY3Nu7L4
	anEeb5+Aggr57EqWzZhxUaoJl9+gXGyNXHJMgbvEjwHLJg1kWbsYeqVpTbUmO0PiRUa8HmB2BNopv
	E3SfKbkMcTFFucBFZBhqgBji8PB09nLkBt9kHo7dRWBJH6O6HDJqa04XAMJtLW1qyTBz/MlzTUMIT
	UHal0RTYppwHeRMujtLS1mBLPZW+YY1ixxf0vQcYig56Z67v/avCgsL3+TyKFAe55JAIlZttPrHVS
	y4heheIQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 10/27] block: add a bdev_nonrot helper
Date: Wed,  6 Apr 2022 08:04:59 +0200
Message-Id: <20220406060516.409838-11-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the nonrot flag based on the block_device instead
of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/ioctl.c                       | 2 +-
 drivers/block/loop.c                | 2 +-
 drivers/md/dm-table.c               | 4 +---
 drivers/md/md.c                     | 3 +--
 drivers/md/raid1.c                  | 2 +-
 drivers/md/raid10.c                 | 2 +-
 drivers/md/raid5.c                  | 2 +-
 drivers/target/target_core_file.c   | 3 +--
 drivers/target/target_core_iblock.c | 2 +-
 fs/btrfs/volumes.c                  | 4 ++--
 fs/ext4/mballoc.c                   | 2 +-
 include/linux/blkdev.h              | 5 +++++
 mm/swapfile.c                       | 4 ++--
 13 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/block/ioctl.c b/block/ioctl.c
index 4a86340133e46..ad3771b268b81 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -489,7 +489,7 @@ static int blkdev_common_ioctl(struct block_device *bdev, fmode_t mode,
 				    queue_max_sectors(bdev_get_queue(bdev)));
 		return put_ushort(argp, max_sectors);
 	case BLKROTATIONAL:
-		return put_ushort(argp, !blk_queue_nonrot(bdev_get_queue(bdev)));
+		return put_ushort(argp, !bdev_nonrot(bdev));
 	case BLKRASET:
 	case BLKFRASET:
 		if(!capable(CAP_SYS_ADMIN))
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index a58595f5ee2c8..8d800d46e4985 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -903,7 +903,7 @@ static void loop_update_rotational(struct loop_device *lo)
 
 	/* not all filesystems (e.g. tmpfs) have a sb->s_bdev */
 	if (file_bdev)
-		nonrot = blk_queue_nonrot(bdev_get_queue(file_bdev));
+		nonrot = bdev_nonrot(file_bdev);
 
 	if (nonrot)
 		blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 03541cfc2317c..5e38d0dd009d5 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1820,9 +1820,7 @@ static int device_dax_write_cache_enabled(struct dm_target *ti,
 static int device_is_rotational(struct dm_target *ti, struct dm_dev *dev,
 				sector_t start, sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_nonrot(q);
+	return !bdev_nonrot(dev->bdev);
 }
 
 static int device_is_not_random(struct dm_target *ti, struct dm_dev *dev,
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 309b3af906ad3..19636c2f2cda4 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5991,8 +5991,7 @@ int md_run(struct mddev *mddev)
 		bool nonrot = true;
 
 		rdev_for_each(rdev, mddev) {
-			if (rdev->raid_disk >= 0 &&
-			    !blk_queue_nonrot(bdev_get_queue(rdev->bdev))) {
+			if (rdev->raid_disk >= 0 && !bdev_nonrot(rdev->bdev)) {
 				nonrot = false;
 				break;
 			}
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 99d5464a51f81..d81b896855f9f 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -704,7 +704,7 @@ static int read_balance(struct r1conf *conf, struct r1bio *r1_bio, int *max_sect
 			/* At least two disks to choose from so failfast is OK */
 			set_bit(R1BIO_FailFast, &r1_bio->state);
 
-		nonrot = blk_queue_nonrot(bdev_get_queue(rdev->bdev));
+		nonrot = bdev_nonrot(rdev->bdev);
 		has_nonrot_disk |= nonrot;
 		pending = atomic_read(&rdev->nr_pending);
 		dist = abs(this_sector - conf->mirrors[disk].head_position);
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index dfe7d62d3fbdd..7816c8b2e8087 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -796,7 +796,7 @@ static struct md_rdev *read_balance(struct r10conf *conf,
 		if (!do_balance)
 			break;
 
-		nonrot = blk_queue_nonrot(bdev_get_queue(rdev->bdev));
+		nonrot = bdev_nonrot(rdev->bdev);
 		has_nonrot_disk |= nonrot;
 		pending = atomic_read(&rdev->nr_pending);
 		if (min_pending > pending && nonrot) {
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 351d341a1ffa4..0bbae0e638666 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7242,7 +7242,7 @@ static struct r5conf *setup_conf(struct mddev *mddev)
 	rdev_for_each(rdev, mddev) {
 		if (test_bit(Journal, &rdev->flags))
 			continue;
-		if (blk_queue_nonrot(bdev_get_queue(rdev->bdev))) {
+		if (bdev_nonrot(rdev->bdev)) {
 			conf->batch_bio_dispatch = false;
 			break;
 		}
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index 8d191fdc33217..b6ba582b06775 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -135,7 +135,6 @@ static int fd_configure_device(struct se_device *dev)
 	inode = file->f_mapping->host;
 	if (S_ISBLK(inode->i_mode)) {
 		struct block_device *bdev = I_BDEV(inode);
-		struct request_queue *q = bdev_get_queue(bdev);
 		unsigned long long dev_size;
 
 		fd_dev->fd_block_size = bdev_logical_block_size(bdev);
@@ -160,7 +159,7 @@ static int fd_configure_device(struct se_device *dev)
 		 */
 		dev->dev_attrib.max_write_same_len = 0xFFFF;
 
-		if (blk_queue_nonrot(q))
+		if (bdev_nonrot(bdev))
 			dev->dev_attrib.is_nonrot = 1;
 	} else {
 		if (!(fd_dev->fbd_flags & FBDF_HAS_SIZE)) {
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index b886ce1770bfd..b41ee5c3b5b82 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -133,7 +133,7 @@ static int iblock_configure_device(struct se_device *dev)
 	else
 		dev->dev_attrib.max_write_same_len = 0xFFFF;
 
-	if (blk_queue_nonrot(q))
+	if (bdev_nonrot(bd))
 		dev->dev_attrib.is_nonrot = 1;
 
 	bi = bdev_get_integrity(bd);
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 1be7cb2f955fc..1e68674e2cd82 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -643,7 +643,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
 			set_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state);
 	}
 
-	if (!blk_queue_nonrot(bdev_get_queue(bdev)))
+	if (!bdev_nonrot(bdev))
 		fs_devices->rotating = true;
 
 	device->bdev = bdev;
@@ -2715,7 +2715,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
 
 	atomic64_add(device->total_bytes, &fs_info->free_chunk_space);
 
-	if (!blk_queue_nonrot(bdev_get_queue(bdev)))
+	if (!bdev_nonrot(bdev))
 		fs_devices->rotating = true;
 
 	orig_super_total_bytes = btrfs_super_total_bytes(fs_info->super_copy);
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 252c168454c7f..c3668c977cd99 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3498,7 +3498,7 @@ int ext4_mb_init(struct super_block *sb)
 		spin_lock_init(&lg->lg_prealloc_lock);
 	}
 
-	if (blk_queue_nonrot(bdev_get_queue(sb->s_bdev)))
+	if (bdev_nonrot(sb->s_bdev))
 		sbi->s_mb_max_linear_groups = 0;
 	else
 		sbi->s_mb_max_linear_groups = MB_DEFAULT_LINEAR_LIMIT;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 60d0161389971..3a9578e14a6b0 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1326,6 +1326,11 @@ static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 	return 0;
 }
 
+static inline bool bdev_nonrot(struct block_device *bdev)
+{
+	return blk_queue_nonrot(bdev_get_queue(bdev));
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 4c7537162af5e..d5ab7ec4d92ca 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2466,7 +2466,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile)
 	if (p->flags & SWP_CONTINUED)
 		free_swap_count_continuations(p);
 
-	if (!p->bdev || !blk_queue_nonrot(bdev_get_queue(p->bdev)))
+	if (!p->bdev || !bdev_nonrot(p->bdev))
 		atomic_dec(&nr_rotate_swap);
 
 	mutex_lock(&swapon_mutex);
@@ -3071,7 +3071,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 	if (p->bdev && p->bdev->bd_disk->fops->rw_page)
 		p->flags |= SWP_SYNCHRONOUS_IO;
 
-	if (p->bdev && blk_queue_nonrot(bdev_get_queue(p->bdev))) {
+	if (p->bdev && bdev_nonrot(p->bdev)) {
 		int cpu;
 		unsigned long ci, nr_cluster;
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299597.510645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyqF-0005ty-72; Wed, 06 Apr 2022 06:08:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299597.510645; Wed, 06 Apr 2022 06:08:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyqE-0005tJ-UD; Wed, 06 Apr 2022 06:08:30 +0000
Received: by outflank-mailman (input) for mailman id 299597;
 Wed, 06 Apr 2022 06:08:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyoJ-0000hu-9X
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:31 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b2d0154a-b56f-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 08:06:30 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbyo9-003vQV-AV; Wed, 06 Apr 2022 06:06:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2d0154a-b56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=TxXl3MdplxU9MCO/Q7D4FJYRsok6DDTDVaSg962eOWw=; b=rucC9iJZF0nT1xLRSKT9tqQoP5
	nL0SBYR/iPNSHB6wdcFxgaOg4ge9C2M4FP2p1JxUqmGG9zNBcpvn8l2ImaqSWUruwic5SBL+1Ka0A
	N9OC/cngiat+LW2SmmgQgik6umVCvLvTWe7LVYau+JKoIVcB5LAd/jZAV15/t6fN+UTCCe2AFXibt
	E1V1T10hMp3lTxlmDK2XsJoN/x/84A5CsbNWzJR1vr4eEH4n9FywvazpXPuwcYDJ3oSJzJmHtYcSR
	fBAUwkO6DmJcsI89V/f7f2YpyrUwGe49T4osq7oE4lAOjncY7dpUANpsFS6qbMzskbxkKi/9ab/Dz
	RphmF5Bw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 16/27] drbd: use bdev_alignment_offset instead of queue_alignment_offset
Date: Wed,  6 Apr 2022 08:05:05 +0200
Message-Id: <20220406060516.409838-17-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The bdev version does the right thing for partitions, so use that.

Fixes: 9104d31a759f ("drbd: introduce WRITE_SAME support")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index d20d84ee7a88e..9d43aadde19ad 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -939,7 +939,7 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		p->qlim->logical_block_size =
 			cpu_to_be32(bdev_logical_block_size(bdev));
 		p->qlim->alignment_offset =
-			cpu_to_be32(queue_alignment_offset(q));
+			cpu_to_be32(bdev_alignment_offset(bdev));
 		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
 		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
 		p->qlim->discard_enabled = blk_queue_discard(q);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 06:08:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 06:08:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299599.510660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyqH-0006P0-1l; Wed, 06 Apr 2022 06:08:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299599.510660; Wed, 06 Apr 2022 06:08:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbyqG-0006N8-OC; Wed, 06 Apr 2022 06:08:32 +0000
Received: by outflank-mailman (input) for mailman id 299599;
 Wed, 06 Apr 2022 06:08:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=huFP=UQ=bombadil.srs.infradead.org=BATV+4210fbe0094d03a681f9+6800+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nbyo5-0000i6-Ou
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 06:06:17 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8fa5b3c-b56f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 08:06:13 +0200 (CEST)
Received: from 213-225-3-188.nat.highway.a1.net ([213.225.3.188]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nbynu-003vCw-1w; Wed, 06 Apr 2022 06:06:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8fa5b3c-b56f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=UWJPN++goBB2S+aW9/6zkPpXCdwY+K+VcYv7Ktvkfgc=; b=r7vqzyPF8OAIKrfwdstfJOZ0E+
	NrSwiWyP+OCKGERhggpZl3eLSIp1ezZV3owY2YgUbT2MqBLPKKPqazNwF/WySNneFOMtrMiJKqIwS
	YOpivmF2MJLLAxiyxiCcSe3YGzEFIwalQib8kRZ3Rs8iwVOk55mFMFbKBpJ3635zdXzm/D+JSfu8z
	hkoyTHinNvYKAcGn2VvZY81Wn2BHVklFMsZnSpmixTRzyE4iqX9oX5R7uWiHg/kwQKj2h3DzO+BJa
	cvvlsj0uxa6VAs8LGSXjpg79IAGE4kwOzHPkaLOZ7SUHbyY8IU8wdGJULO/yvYRkNePSgYT1lbVfU
	WoV7XmvA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 12/27] block: add a bdev_fua helper
Date: Wed,  6 Apr 2022 08:05:01 +0200
Message-Id: <20220406060516.409838-13-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220406060516.409838-1-hch@lst.de>
References: <20220406060516.409838-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the FUA flag based on the block_device instead of
having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/rnbd/rnbd-srv.c       | 3 +--
 drivers/target/target_core_iblock.c | 3 +--
 fs/iomap/direct-io.c                | 3 +--
 include/linux/blkdev.h              | 6 +++++-
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index f8cc3c5fecb4b..beaef43a67b9d 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -533,7 +533,6 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 					struct rnbd_srv_sess_dev *sess_dev)
 {
 	struct rnbd_dev *rnbd_dev = sess_dev->rnbd_dev;
-	struct request_queue *q = bdev_get_queue(rnbd_dev->bdev);
 
 	rsp->hdr.type = cpu_to_le16(RNBD_MSG_OPEN_RSP);
 	rsp->device_id =
@@ -560,7 +559,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 	rsp->cache_policy = 0;
 	if (bdev_write_cache(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_WRITEBACK;
-	if (blk_queue_fua(q))
+	if (bdev_fua(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_FUA;
 }
 
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 03013e85ffc03..c4a903b8a47fc 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -727,14 +727,13 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
 
 	if (data_direction == DMA_TO_DEVICE) {
 		struct iblock_dev *ib_dev = IBLOCK_DEV(dev);
-		struct request_queue *q = bdev_get_queue(ib_dev->ibd_bd);
 		/*
 		 * Force writethrough using REQ_FUA if a volatile write cache
 		 * is not enabled, or if initiator set the Force Unit Access bit.
 		 */
 		opf = REQ_OP_WRITE;
 		miter_dir = SG_MITER_TO_SG;
-		if (test_bit(QUEUE_FLAG_FUA, &q->queue_flags)) {
+		if (bdev_fua(ib_dev->ibd_bd)) {
 			if (cmd->se_cmd_flags & SCF_FUA)
 				opf |= REQ_FUA;
 			else if (!bdev_write_cache(ib_dev->ibd_bd))
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index b08f5dc31780d..62da020d02a11 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -265,8 +265,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
 		 * cache flushes on IO completion.
 		 */
 		if (!(iomap->flags & (IOMAP_F_SHARED|IOMAP_F_DIRTY)) &&
-		    (dio->flags & IOMAP_DIO_WRITE_FUA) &&
-		    blk_queue_fua(bdev_get_queue(iomap->bdev)))
+		    (dio->flags & IOMAP_DIO_WRITE_FUA) && bdev_fua(iomap->bdev))
 			use_fua = true;
 	}
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 807a49aa5a27a..075b16d4560e7 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -602,7 +602,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 			     REQ_FAILFAST_DRIVER))
 #define blk_queue_quiesced(q)	test_bit(QUEUE_FLAG_QUIESCED, &(q)->queue_flags)
 #define blk_queue_pm_only(q)	atomic_read(&(q)->pm_only)
-#define blk_queue_fua(q)	test_bit(QUEUE_FLAG_FUA, &(q)->queue_flags)
 #define blk_queue_registered(q)	test_bit(QUEUE_FLAG_REGISTERED, &(q)->queue_flags)
 #define blk_queue_nowait(q)	test_bit(QUEUE_FLAG_NOWAIT, &(q)->queue_flags)
 
@@ -1336,6 +1335,11 @@ static inline bool bdev_write_cache(struct block_device *bdev)
 	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
 }
 
+static inline bool bdev_fua(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_FUA, &bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 07:00:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 07:00:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299643.510672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbzeD-0006Mq-2s; Wed, 06 Apr 2022 07:00:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299643.510672; Wed, 06 Apr 2022 07:00:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbzeC-0006Mj-VT; Wed, 06 Apr 2022 07:00:08 +0000
Received: by outflank-mailman (input) for mailman id 299643;
 Wed, 06 Apr 2022 07:00:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbzeB-0006Mb-CF
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 07:00:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2e414bc9-b577-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 09:00:02 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-hiNFXm5gNKWnG42ZC8Nqwg-1; Wed, 06 Apr 2022 09:00:04 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBAPR04MB7206.eurprd04.prod.outlook.com (2603:10a6:10:1a4::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 07:00:03 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 07:00:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e414bc9-b577-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649228405;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5qgFRr6p/bIDfH/aDYF7/Evg0uH974PLIv0Pv/T87AY=;
	b=YAbRZTz9xIypuD9PQtKKht9cEys7FzawOnSJX06/pCV71ZyhVP4jcdCqKQYGmAe1IJIzUi
	yTTlszd+6UVoQySJv7QmRmgVb8szqitVRRjKcEZ/52rnT7J9p2IxJyEGZq+d+ZGOqhFWfj
	7sraRerAUqtS0MITEuDLxVjv7vrzIQw=
X-MC-Unique: hiNFXm5gNKWnG42ZC8Nqwg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QMVKaDXKxHDGQqOsb6c9aJfhJXrxzvkt8TzCNd+oQmaUwbleo14B9TIhSICzUyVuqvXVQUc5ZYJ2tjXrwnKSl6Vhm822gQLUu9rVBUz3pltMTivXKTSrFKKaniUVmsXFJDBAtG3hYiJQpGpSDbx66HoftSPv8Lf2Sh44yjYE2tkC3giX3/+cWgshwOOYC1orDXSk/MMvtaN0zfFLzJSkpGo6cS6yQvuBQgXiITsPRu21llTD9cFmOgK89VpebcDWsENKV9/Ur9tr3pl4s3VHfzJtkQuLqsBOSgqGeREIkKsQfNuAx4vK5c/V/0PTt7b9gMBoGTCtOKWxgQupSCyEnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5qgFRr6p/bIDfH/aDYF7/Evg0uH974PLIv0Pv/T87AY=;
 b=GwjJRJZ4QVJakw3uyKYDSFRSDWgBq8Xfh8Cj6xveuczUBU316hXzv1PyL7rSz6u5mWYJjo6ZjStfuHqoycw5xPhO61/x71n3YuY/YwjV99LZNfA8HVLs/0n08S3THLGHTG+YtqzWSHs0XF4ZuCnDb6M8IvlxdEpna5y8WG/ZT5PVcGx6C0OggsBdMBz0us+AELoLxYjP3j+fFnK97ygUvLMxrrahCiIwqM9v896TPQKGJh2ZxUvyXTFl6k7g5hwFTTBTzvWkHhKXdbnyn+XdjYNHz90Dh9A/8Ak4IC6UBw3aHk2GiD6kFW/vl4m4Du2QaA4h2eR3Gfv6xxoewRimMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c01eacd1-cf2e-9258-f06b-5a0278fa0ce9@suse.com>
Date: Wed, 6 Apr 2022 09:00:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [xen-unstable test] 169172: tolerable FAIL
Content-Language: en-US
To: osstest service owner <osstest-admin@xenproject.org>
References: <osstest-169172-mainreport@xen.org>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <osstest-169172-mainreport@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0196.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54252f3e-f5a4-40c3-4657-08da179b129f
X-MS-TrafficTypeDiagnostic: DBAPR04MB7206:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB7206F9373636035E0B439801B3E79@DBAPR04MB7206.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dUWGQ7AxCvDxs6dnnGhPtfT1Z4H4rw9M6+WlyofeqiutnGraFZHkAxMYqi6yBRHjOD8Y90ieIFyngd+XzHMxU13K4l6xiN6XVLVeOXBDcu54aJtE6PU0/5Z4T7nqshOST4tnShqgPgB5nskTd0B7KNHTJ+4e9WN3EiY2PNTuiq5RXH4CsMwg7IcYFCAxyaxB9Q8TSID4yxT2yCoQCV+4J4Lvqsbz/hz4scNcWkxw0QHZ6K0zfLoUw0LzDMIIy1AOYZNKuxcrMIFUeuRlAmE14kBNbbYrlPbg0hiEuH01dH9iuycSkwHPM2tu3tnOM5bn0Q7nrj/StltLbXDI6HQYas4j8RWAFcMo4UfWLwVqgqzI8iTa3DG2TUgxoWuwLYw0qDkZSU/B0WvZ3d3DqDdc3w5ED5dPuEUNVEf8Ixa/q0HfLTROwqQJ4Hpki0dLLThcnZMSeSDcosr1KK6K2byRUP+aQzgxYVx+qlN5C2YenUG+nOhXk7n6Rc8Bqblg/LB2PvFHhlJXm1I+lEHwtRCDdesgIp3PD1PIEAw9oMksB4hvw0l8JKvQTctBqV+XaYQ4gdR12+OJcBGIQXVO9aQ+UwzpnZFbA7RPgRo8Tclt8guB4Ca5Jf9BsdNwpGSCN5Cv4ErT/jEOFPsZCXnuZ0EeL0RdYrxf6JNCFjF7sr0EcieVvxkjMd0Acpge/7VC/ozrRXQT4dRh7Nst9a5b7ALECn3UXFoDSR9/JW0mY1F91jpS1n2b0gnlH/Y52ZpIWwvCqZm5sKOlRSAagdTef7iwIPn3IXEqtVZ8AccUE9N2rXoTxFekhFfF2gZ09odsNHYO
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(2616005)(66476007)(66556008)(6916009)(6512007)(53546011)(186003)(508600001)(83380400001)(38100700002)(8676002)(26005)(4326008)(66946007)(6486002)(966005)(6506007)(4744005)(2906002)(31686004)(36756003)(5660300002)(86362001)(31696002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VHNxWUZocHJqeHpWQ2pLR2VXQ2VIdEsvQW0xdnlJS3ZhSWtDRy8ybjdxSzVE?=
 =?utf-8?B?dG5YSUx0NGhGQmVOQmtkczlRcXg1b2xxQXF3NVd1a0RyaFYvcDZwUmZqUEdI?=
 =?utf-8?B?Z1FWUGFsOElFMXNNMGxTWTBWRWR0ZkUxRFVIZ3NpSEYweDE1cktUT05YRXZk?=
 =?utf-8?B?MDBqMTg1SmdWaGxWOGdoRWcxUkRHRkxoUWROVnlDTmtVczJmYkp6TVpMNzFu?=
 =?utf-8?B?Nml2WVZlVFFlVDhXR1BITGd0Mm9VRGhuVEVWbmt5bzZYMjJ1UDhCdjJ3NURa?=
 =?utf-8?B?OUw3WFNOakhucFJHQjVGbUZCS05lWTFmaHl6dC8zczVncGd0SWF0MGlaY25N?=
 =?utf-8?B?cGQ5bnRMUHlQTjNzQytQSmZCMmxYM3FxTzZpTkJzOHhlVlJUeTZmWU15em1a?=
 =?utf-8?B?QWFXTDV4WExTSWlibm94TDBLNG5WZHg2Z3ZEU1YwVENCa2V3UVREUk1ad01n?=
 =?utf-8?B?L3ZRRjc4NytpUEZjWUpBRDNoZ2R3RjM0NnRZbUQ3ZE5lbGtvT0wvbkliZlZB?=
 =?utf-8?B?WCtqN05MVUV3NlBMUm9nWEg4V0tibmlDcnM5b1hCTzdieXNVOHZhZ2JtZzBR?=
 =?utf-8?B?N1djdXR4U3g1c2pmc09aazlNMmZXS0crRldGSDhrMW9za3VnTmY5ZTlXaVBP?=
 =?utf-8?B?d2dWeFlhK0lZQUVyT29KTE1ZQXJranViZ2RXZW1lRHpiR0NEY0FGdWE4ZUZu?=
 =?utf-8?B?TGhOTXRRVGFpSHl5VUVNOFRmN3BsWTRMVnZWU09qOVViMDhKKytVZC92MTZn?=
 =?utf-8?B?bmRUN3BJWUFicXhLTVN3ZDAvV2lLdHVrYlhqbUdCUFRMWDBlemMyT2F1YndP?=
 =?utf-8?B?VElZaUhKL2JWeS9XcVRMcDI2SnBoZWJHZ3JZVi9XN2UyNk9GU1dKS0R3QVg5?=
 =?utf-8?B?MjBmajI1NWpGOUFnL1dPMUNSTzFnMkhVZ3NxWnVib3NhTHQ0NUhhZ01BL0dE?=
 =?utf-8?B?WGhVMURQVWtVMEdJejZsZTVJOWowS3cyNmJka3ByRkpxaWJKNnBMZEFlQVhL?=
 =?utf-8?B?Q3lTWnNFdmZQc1NpQWlzQnRlaXlVc0E2VFFnMTVsQWxmblYyYXpDREhWMGoz?=
 =?utf-8?B?c1NJS3FubDJxOVBXNWNMS3JvSmlOdmpwN3ZQZHhuMThodTA0UEMrQkhLcWtK?=
 =?utf-8?B?YXB4a1FTaWl6UVpWb3MwYjBGMzBBRitqQldVbUlqUE1XR21ERmYrL0RhVkt5?=
 =?utf-8?B?L3hDcjFmeVF4Wk51RHZJcWRldWtzTWhkRHo0dTFlZ3NGZlJjU0hCTE54OXNI?=
 =?utf-8?B?ZUtERTgyeWVFTzV6VVZ4empQL0ZZUGk5clNHTllVelhZRnllNGZxNUxnQkNM?=
 =?utf-8?B?UEkzOEhxc1gzdkhYRFlVaHhtV1dXbitTeWRMWVhGMGJJTjJNTFV3OFZ4MWlo?=
 =?utf-8?B?eWdMR2t3bjI3Z29zclRWd3dIeDRrZk5wc01JWTZDSUZBcGlkcXFIZ21LRGdk?=
 =?utf-8?B?WWpTTEJib0dkL2hNQWRta25sUWtmbFp4K0ViSVRyYzl5dWVacjRiZmtJOWE0?=
 =?utf-8?B?clJQZUhxUXdVSXlrOS9YZlVZMlRyMkQzQ2ZPZklRMlpwYmpqRG1QeWtzV01D?=
 =?utf-8?B?QWM0ZXhUM0NlUXdPMDBFdEhQMzJoNHpRcXBZeW9OZWViTEtrSDlHbzZOWkpL?=
 =?utf-8?B?aWQwalQxelg0SVVVZlVWRlhBOFB0bkc1Mm9xU21uTnMxYUhLWmpVMU02eVlk?=
 =?utf-8?B?RmdZenloVUZoS2xESjRnaEdBNTJERzdqQ2RiRys3MFN5MmV6alVxNU1ITm1R?=
 =?utf-8?B?ZCtwNEp1K0RUTjJWaUE1Tjk1NVhkRTIvcS9iaklBMyt2b0RLT1JIMXRCQnZa?=
 =?utf-8?B?YmNQdzRUTVRYTjJsTUJqbWc4akRtRUV3VHZSQk9RWmFqRVMwR1lRU09qcHRT?=
 =?utf-8?B?UFBObUJKN0FmeWhJT0JraG1HcFB5d2dxSVNYeUlqNVpZclhsL1hudjYyRXR0?=
 =?utf-8?B?c08wK2xoN01ETW90c2RqMEVPb1l0SEN5aEJseG15UCtDZCt1Uzg2MHg4anhL?=
 =?utf-8?B?V1QwTjc1TkdjVkFSdDZkT01YUTRqWGN0YU5RUWJHeUhJSFEyS0xjeUtHeElS?=
 =?utf-8?B?Vk5KT0J3d1hmMGtGaElMTEtqejhnUzZpSGt3L0x2ZkVLVGhYemRBWXVMeis4?=
 =?utf-8?B?am9jWFlkM1RxYjBhN1p4K0tzaHhWK2NWcUhaZzY5TURoQVh2MWhzWVYwb2Rk?=
 =?utf-8?B?YUFqUEFlSEVneXF1TjFEUHdFbS8vOCtjMEg4OW5PVVh6K2pKeVBXWFN0U3dL?=
 =?utf-8?B?TlVKNTRsN1FLNlNXbmNYNzcrMUYrdG5nbUVJRHdDb0hhM2h0MHdodU5xRkZU?=
 =?utf-8?B?ZEQ3TXMwaEVZN2pQdXpkVmM1WmFVWG5hODlQSzFLT0k4VFpiZ0hBZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54252f3e-f5a4-40c3-4657-08da179b129f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 07:00:02.9112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R6fmH+P+JtKsCYN9rsNKbjzLmhYmXJyGNdjBNWwpZC1Xs+BSF5PZxxQk64zvQyZ0VzYinXyhMg5cxD3LaXIAqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7206

On 06.04.2022 00:30, osstest service owner wrote:
> flight 169172 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/169172/
> 
> Failures :-/ but no regressions.
> [...]
> version targeted for testing:
>  xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
> baseline version:
>  xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
> 
> Last test of basis   169172  2022-04-05 04:42:27 Z    0 days
> Testing same since                          (not found)         0 attempts

I just happened to spot this. Perhaps not a big problem, but somewhat
odd and present in earlier flight reports as well when those were
simply re-testing an already tested (and pushed) revision.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 07:05:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 07:05:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299647.510683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbzjB-00071v-Lp; Wed, 06 Apr 2022 07:05:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299647.510683; Wed, 06 Apr 2022 07:05:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbzjB-00071o-Ii; Wed, 06 Apr 2022 07:05:17 +0000
Received: by outflank-mailman (input) for mailman id 299647;
 Wed, 06 Apr 2022 07:05:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HxtK=UQ=fujitsu.com=Alan.Robinson@srs-se1.protection.inumbo.net>)
 id 1nbzjA-00071i-NN
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 07:05:16 +0000
Received: from mail1.bemta34.messagelabs.com (mail1.bemta34.messagelabs.com
 [195.245.231.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e64974ab-b577-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 09:05:11 +0200 (CEST)
Received: (qmail 31866 invoked from network); 6 Apr 2022 07:05:12 -0000
Received: from unknown (HELO n03ukasimr01.n03.fujitsu.local) (62.60.8.97)
 by server-8.tower-548.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384
 encrypted SMTP; 6 Apr 2022 07:05:12 -0000
Received: from n03ukasimr01.n03.fujitsu.local (localhost [127.0.0.1])
 by n03ukasimr01.n03.fujitsu.local (Postfix) with ESMTP id 3681F100190;
 Wed,  6 Apr 2022 08:05:12 +0100 (BST)
Received: from nera.osd.abg.fsc.net (unknown [172.17.20.8])
 by n03ukasimr01.n03.fujitsu.local (Postfix) with SMTP id 07836100181;
 Wed,  6 Apr 2022 08:05:10 +0100 (BST)
Received: by nera.osd.abg.fsc.net (Postfix, from userid 5004)
 id B86E417478B; Wed,  6 Apr 2022 09:04:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e64974ab-b577-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.com;
	s=170520fj; t=1649228714; i=@fujitsu.com;
	bh=05cGtA6yxrBEXr8TsKfNblRw+Bdby9YhP92PsT290U4=;
	h=Date:To:Cc:Subject:Message-ID:Reply-To:References:MIME-Version:
	 Content-Type:In-Reply-To:From;
	b=BJDFFQHg7gw8WYACPIsS5IO7QZ2Et0/snRy0O1P7sPcx3klPBjnAcFB0x5vQmkc7B
	 wdj7sgZsarcq07EkkN9Uk7cWaXRM4BHIkDNaIuDnoDW/xdWPN+yfeRQ0VLd0GPd0XX
	 YqbordNSTrdttI2gAjHO+G0BfdXM58RE64W8BbUe7mviFWROX5XjUVwj2GTsNCRtCK
	 2WJ4V8hKwe8nmUuYA+n39zIapfnu0J3NGApl7UCEEBLyvU7tS2BrmjwMlFpa9b2hDX
	 gUaY7GvBudukN14SBUkBadO1YF+sMHYk2wGdlkRTCLILZZ+pMjV2no6kK1JlP7i/NG
	 hrGSl+X1ARJQg==
X-Brightmail-Tracker: H4sIAAAAAAAAA1WSf1CTdRzH+T4bzx5hDz38iq9L8ljCH3ibDDW
  +ilh6lk8nFJfJJVfZgyy2GsjteThnXAdKKIcRKiTHVFDHrwFhB6OIOQ60BDwhGM6BFxWyGU4R
  kwqMX+1p54/+e3/u9fq8P/98CEFAPS4hlDpOqc1gNFLcR7h5E8HI6mITUqJcB19GDaPFOHowc
  gJDvQ3jOLLcP+WNxmx1QmRs+BFDg3/kY+jKtzcwZLm5GlnH60SovOJnHFnPb0cXLb1C9Evjkj
  f6YakYIPOhGhGaL1uHKmucInSksh2gY+fyBOiovQ1HRfXxqH2+TYTmnF9jyDjeiqH2e/0ilF8
  9iaHavgoczZhKsFdD6aG+LLr54QkR3VKVQ3/+22GcLhmuBfRESzmgzWenMfryg+tC2jySi9MD
  Nfdw2vZ3noCe6rDh9HTzi4lksrc6I2Wf7kNv1dRoF5Y56KNrt1zGc8E8UQiWEQGUCcBbV94sB
  D7ubASwqMMkKASEe8iChp/EvCOkVkFLpRnwOYiSQqerD/C+gGoiYZfTIeL9QCoZLt6O5x2Sio
  Z/3jJgnv6X4BnbAs77JDVLwuq2CW8PyIZHf50Uehb8YW+5478soCLh8OIdjO8UUC/A2kWCj8u
  oJJh/XMobkFoB54wzOJ+D3fVNhl7AKzi1BrqKGI8SAW39zYJjIFD/TL/+mX790/6zQFAPNqZo
  1WkqLp1Ra2SKqCiZQrFetjZGptggZz6VMXJllmy/kuVk0XJmPytXsqycPZC+V5Mqz1ByzcD9Q
  qlseGAbKDA+kl8CywlMGkz6KhJSAvxS9qUeUDGsao82S6NkL4EVBCGFZBxyM3+tMk2p+0itcT
  /iYwwJsTSIrNroxiSbyaSz6jQPugrCJCHkyAY3oHigysp4svb4ha0gVBJIAi8vrwBxplKbrub
  +z10ghADSQHIHXy9WZ3BP2l3uw5j78P1rb/CHOeYpkuRiOVWl7x8SfveXV2mR5OTzV3PqoheN
  8ht3LNyuk9zUZwMLSQn2nG7ZBY2j9fXj4/Xh6J+Y0PeSaktax4Y6d4cFOZ7z//LgrtqvDm/2t
  W9dWnvb3L/tiNrwdkfbzTDCd94gjg5/95FjbO+gZtI+y5ozcZk43XrBOln9+2vFBZvW567Z9r
  1f6qzuA8KkHzrTOXG3xfXJW3si49dl55zK18VVrPzm9FJB8kxZ07XEPMeA3frKF82dFysL5hq
  Dd6++a1ie0POwZ2DnaGwMN709Qp+4yh63My4WdkU4sod7ulc6TeLr3X51WxpLqKCwyK0maam1
  qj6pbOGdEGdhiVl3Pu3jc0Nb9JxUyKoYRaRAyzL/Akr/LJA9BAAA
X-Env-Sender: Alan.Robinson@fujitsu.com
X-Msg-Ref: server-8.tower-548.messagelabs.com!1649228712!85085!1
X-Originating-IP: [62.60.8.97]
X-SYMC-ESS-Client-Auth: outbound-route-from=pass
X-StarScan-Received:
X-StarScan-Version: 9.85.5; banners=-,-,-
X-VirusChecked: Checked
Date: Wed, 6 Apr 2022 09:04:46 +0200
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	"jfs-discussion@lists.sourceforge.net" <jfs-discussion@lists.sourceforge.net>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"linux-nilfs@vger.kernel.org" <linux-nilfs@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"cluster-devel@redhat.com" <cluster-devel@redhat.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
	"nbd@other.debian.org" <nbd@other.debian.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"ntfs3@lists.linux.dev" <ntfs3@lists.linux.dev>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 15/27] block: use bdev_alignment_offset in
 part_alignment_offset_show
Message-ID: <20220406070446.GA1722@ts.fujitsu.com>
Reply-To: Alan.Robinson@fujitsu.com
Mail-Followup-To: Alan.Robinson@fujitsu.com, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>,
	"jfs-discussion@lists.sourceforge.net" <jfs-discussion@lists.sourceforge.net>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"linux-nilfs@vger.kernel.org" <linux-nilfs@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"cluster-devel@redhat.com" <cluster-devel@redhat.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
	"nbd@other.debian.org" <nbd@other.debian.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"ntfs3@lists.linux.dev" <ntfs3@lists.linux.dev>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
References: <20220406060516.409838-1-hch@lst.de>
 <0b7ae3df301c4fdd8d37f773d8d1eb93@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0b7ae3df301c4fdd8d37f773d8d1eb93@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM>
X-sent-by-me: robin@sanpedro
User-Agent: Mutt/1.9.3 (2018-01-21)
From: Alan.Robinson@fujitsu.com (Alan Robinson)
X-Virus-Scanned: ClamAV using ClamSMTP

Hi Christoph,

On Wed, Apr 06, 2022 at 06:05:04AM +0000, Christoph Hellwig wrote:
> From: Christoph Hellwig <hch@lst.de>
> Subject: [PATCH 15/27] block: use bdev_alignment_offset in
>  part_alignment_offset_show
> 
> Replace the open coded offset calculation with the proper helper.
> This is an ABI change in that the -1 for a misaligned partition is
> properly propagated, which can be considered a bug fix and maches

s/maches/matches/

> what is done on the whole device.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/partitions/core.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index 2ef8dfa1e5c85..240b3fff521e4 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -200,11 +200,7 @@ static ssize_t part_ro_show(struct device *dev,
>  static ssize_t part_alignment_offset_show(struct device *dev,
>  					  struct device_attribute *attr, char *buf)
>  {
> -	struct block_device *bdev = dev_to_bdev(dev);
> -
> -	return sprintf(buf, "%u\n",
> -		queue_limit_alignment_offset(&bdev_get_queue(bdev)->limits,
> -				bdev->bd_start_sect));
> +	return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));

Should this now be %d instead of %u, there are one or two examples of
both in the rest of the patch series.

Alan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 07:07:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 07:07:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299652.510694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbzky-0007hM-4w; Wed, 06 Apr 2022 07:07:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299652.510694; Wed, 06 Apr 2022 07:07:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nbzky-0007hF-1n; Wed, 06 Apr 2022 07:07:08 +0000
Received: by outflank-mailman (input) for mailman id 299652;
 Wed, 06 Apr 2022 07:07:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nbzkw-0007h7-HM
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 07:07:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2a372751-b578-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 09:07:05 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-XuDH7ArcMBq9TY8JVt08jw-1; Wed, 06 Apr 2022 09:07:02 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5877.eurprd04.prod.outlook.com (2603:10a6:20b:a7::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 07:07:01 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 07:07:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a372751-b578-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649228825;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dCc5MjGVuClMclOm/PARP1lH4sH4o1x+CK2Q9ashh1w=;
	b=NuNkAe9I5TaaE6ifWURwRwuRL3/ihl/Q6V6mI24Og/FsDun7FXjgG8rAlzl9CClcMnY5k2
	qYg/fRN0crE0ZgM9yoDWdieWNNAvH2r528Nm48VjwMGZYyXGNrLuh7Yz+J/fLq6GZVjY0o
	5w9+FCFEnEaoc9r1pU5aRFVtRlNJmpU=
X-MC-Unique: XuDH7ArcMBq9TY8JVt08jw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A900OXtgcGkG0FOs9hXsAz/yppGaYb7mm5vcXB7pdcdDtSgGLvkJwddMoZ/UW7JVyCKKLa4n5alhqK9SHl3Fe8xyV34rF8M+iqVGLlbwtTCkWFDpb1y13lTCPHcaqvpDjdRCFGpp++Z5o882bwjhwDzZ94T/NyOPiEBXzQ2YBwhXOPVnGNSkr2UKlFXQFUN+8jombXLS6QI8OM1z2FYazGGl7uGm2T9Qc2DjSvGrmRC0k62Uk2AIGZ+cPGBTScAxt8oEP82FrnNyo6HLggwpySzSm6AcZ3augJD3cvZAr2wKumPJeks3Nu8WYDhMtMn2e1XWaY22oPCczEIprl91kA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dCc5MjGVuClMclOm/PARP1lH4sH4o1x+CK2Q9ashh1w=;
 b=hUop2NrZz4W0ZG9s9QicSFfGmn/1D7rJLaCcFSFRQh+klIr4L3etAQP5pgC9Lc3M9ZSyF0NZ+ses3EQsFln5jvkfblMrRzFXdM1TujQS4TS/Y+gNSE6LbIdqvQnj4fIAgRVRnA6NaT+Ab1DkrlubN2PS1uC++XnwkgeqMGvJyTLrkbMaoMWhvxU2FOcdCu9oCHmJ2ematmYPkGToo70a0Kucw3xBfy1MXu25GJNYUAXrbeJZa0XD7UNLJZJanMb/wSe9sqdU1haC9eeFZCV4RP7JTpuopAWDtQSxbjoQHBerECzM0LZFqCveY4PqqNbvkKke29F72lQegEdz3Pm7xw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
Date: Wed, 6 Apr 2022 09:06:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Scott Davis <scott.davis@starlab.io>, Daniel De Graaf
 <dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
 <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0045.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::30) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2113e863-69ce-4f05-bee8-08da179c0c04
X-MS-TrafficTypeDiagnostic: AM6PR04MB5877:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5877FDAD0992B3B44013CD23B3E79@AM6PR04MB5877.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jmiegvLgtLfzPz8SQya9oANtN0hSdlI31SLYMyORwy/4RSvKDBp5h7ervfnX6kwyWkG2s/bQ1mjEXbv+CelIUAp4/Pwh8QgsSUntXEvxZR2ri0AJbUZ77AbpWSoB7WwJBnTUqqHijuxcEGenn2edaoTTV5qBkitMmIiM+DoRP5v5mYWsVYS4umt7igq+npNVxVye5AO5MD9oPPRKK2B7Wj3/MFOOF2VNNjpgHSav5CYZrUKqvts2xje2bF1zQEgQzn0RN67EHyBbCOO6twdaqJXXp1ni8vGlWaTF4ZURSZH+ntAEloMvSYfaCVb1gDZhdKxW+mRGTK60szOUXFJ9dYHJl02PWI1CbPq8NotmTjjY5Qc4Tss7VVXEpjdVOeqmM7Lz3D1r7X4p2efDK/5cnXshuJLfY/6rbcwpo5p1i7Oz0+4zRTUGCbuWbxm5/YKAdXBXR08QWTcoZKWxoFfEM67Dj1uaxwQTPWF7iwoYBudP+J/BGhKp3nc9X6E0yPkY2iBsDvnyXZmalIOwI0g22JgUhqx0XNCNLDP2uCvohWK/L/eoNFujZjqJLKX3RC24KWR5bbSpsaSAAdAQf6ExFujfF2WTqBaCJqz61WWtnS91WyhKbncXoOrrYaZDARoBn8Yk6C7n7e1mVVgZ20BI98LCSZFiQqMadUKDg3rnuRYiEmFqhYG0XlT1oxjtP7mBTFPZQ0OWS7S/ZIqXQuw2Ke8yxQhDYl94tSl49KAgH+nf+lPkA7w8Zr6lHDBvF8zt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(53546011)(66556008)(2906002)(66476007)(6506007)(26005)(66946007)(4326008)(2616005)(31696002)(86362001)(8676002)(8936002)(186003)(6486002)(5660300002)(508600001)(54906003)(36756003)(316002)(38100700002)(83380400001)(31686004)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cTM4cDZxQ2ZPWWc0MC9wUVg1aDg3WlpIZFpobytpTW8rYmVxWmdTdUJacTBp?=
 =?utf-8?B?WlYvN3p5RDd3SWE1VVFwVEU3MkppMHpka3YzVWlCVGJWMVpaRDMzcmh3ZThO?=
 =?utf-8?B?S0FjVWFBdDg3allFbmZ1c2c2Vml3VFk5bWc4OFdWcUlaOW9tdERhSWwxMG1E?=
 =?utf-8?B?Zm5ZaFptRjZJWGx3QU5zZ21jWk9lbnlSbEpnT3p6aEhmb2dOTlFFK0dPbzFL?=
 =?utf-8?B?ZG1jWGh3OXJST3FCQ1ZLbSt6a1o2OUhvT09XWWx3K1lReTFjenNTckNXNG5p?=
 =?utf-8?B?Y3YyVDV3enZIVGRYSUoxTzBuUHpWUHVLQnhDdjBRaWhncXJBQVgxTlhKQmMr?=
 =?utf-8?B?M0NKU1Rwa3MxMkJGQjBvZ2p1MXZrMDFyMkNUQjJrRUtBQ2RZSHorZWhoZUdQ?=
 =?utf-8?B?a290Mm12OEs0S2lURnRFWEF4akhZbUlRbWpYdGlEYlZSdUw3Q3N0WUVLSG9R?=
 =?utf-8?B?RmNTTWpoTExnTHFYQU05UmU1anlhdE0ySno0dG1GamtkTVdaUnFzbTBKajdv?=
 =?utf-8?B?Wk5iMHAwZnJQLzRoWkU2Q2tFM0t1UCt3T2N1WDc3S2Q4L1E4eDB1OGRXYmIv?=
 =?utf-8?B?d25VQ05sSzlwU3djbG5TcHBYbXNnLzAyWkdSYTZFQkFhWjdtVEZ0WU5NdjZB?=
 =?utf-8?B?V2RYZzJoVlNRanBmTWx4ZVhCVDdjR3AvUzJZNVZmMUV5TnhSQmVjWU51U1hL?=
 =?utf-8?B?UU96Rm9VOTFmT05zelVPc2tvTFIvNkMweEdVeVF4c3BrRHhiZk5GdDY4RjlX?=
 =?utf-8?B?aHk1SCtERHljWFUrZGNhTmRCTHZHS1BCanl4eWcxb2lsVk5jV3ZsWGJqK1pi?=
 =?utf-8?B?QjVBT3BqYVk3S0JMbEtaZy9lU0k4QWh6UkxEdFlNWnhKSS9pd3R6Y1ZSNlpw?=
 =?utf-8?B?dkJtQVpZaGFtSnlhaXNKU1FhMFh6eE1rSUxTblBvb2p3Z0Y5aWxnTzBmaHVu?=
 =?utf-8?B?WVZ5RzZsRndrYXF6NlJ3K05jaDRWRER2NUlPZUZIUTZ4c0l3alM1VVlqQ0VG?=
 =?utf-8?B?S2VVUjI2azVJcDY1SFF0dVRKYjVqNnlMamFDc2FGdm5KOWQ5NVJWN21oZnpY?=
 =?utf-8?B?UEVWVHE1NlE0Z2VKT1Z5a3diUFJzK3J1ZnJTdVFpRitrUGpnaG5DdlZUWWJT?=
 =?utf-8?B?WUp2ekNFSmlpaWNWQ3hwSzBjUlcxRXNFOHNPL2lXMWFkbHY1YXpNbjdvdVVl?=
 =?utf-8?B?bDh6bkhwSldoQmZWZm5ra1NDWUkwNndPdng1djFuQmxKTmJlMVRuZ21FRGtP?=
 =?utf-8?B?RXRHdlhKbytuVzdzbml3TzZjeGMrd3l1N0hSTFJpOHErQ0huTE5vNitGT2NG?=
 =?utf-8?B?WDJLU05PWTBidWk3ZFo2VWZCTDRXK2xQdVhhREFOeDA5VEJ3MlJFWHRrcFNP?=
 =?utf-8?B?Y3lDQmVTNUUybldET2Vzb04rVHVKOXl0MnZCOUxHK2lsVThtY2I5VHdaY0Rx?=
 =?utf-8?B?Rm91Z3dJWGhsRk5mb2FlSGlZSUlWaC84R2dzWkIwaDBSMlNEenYzUnB5SnlO?=
 =?utf-8?B?dSttcFlXUzVLYUxJZjBobi9udXdMT0V3T0tZdWdOck5WaFRKeCtGeE5yVFVj?=
 =?utf-8?B?eWlzYWNrNTFpbzhocG1ML2pGYTNLVEYxK3UxbGoybFhWaWxoV01BZzhtRzBK?=
 =?utf-8?B?cGVFYlpEYm1WZ3o2QjFzSFJhd1VVcWxpbDZrTGp3ayttaXczQzdEd2hDaXpo?=
 =?utf-8?B?aE5SY0p6N2FaSjJpWHR0TkhFaHY0S1pwL2Z6OFhlWlplMTF0ZTBWdkVvY0pB?=
 =?utf-8?B?UXF5RkpJM2JIYXhhQUlNNmhxRHhmM0VqOE1wY2NvRXA2ME91RlFUckYwQUx6?=
 =?utf-8?B?aU51MGlxanFCY01NZlU4eXJVUU9zTTQ2WG9WMEI3bXZyTTYzTVQxOVhoTXBa?=
 =?utf-8?B?TmJTQUFWRVd2S3FwY05VZXN0R0NqaXR3WEVZZitaQytCdStVdWw1am5ZODA1?=
 =?utf-8?B?bUdYeit5NUJSTG9LeEVIdzFMR2dKdVo4NE54a3lNM01ydHc0Y3p3eDJBWHZT?=
 =?utf-8?B?T0ltU2NzakorUzMwK0t1d250d2o4VVlMRGdFcE03aFhTcFlDYjVzSlNtVmdp?=
 =?utf-8?B?SWFQUjBGYmFzTFFOK2l2WkxwQ1hOSGhFeVRVV2RIcnpqTmhGVWlIV1VGS0tQ?=
 =?utf-8?B?eFRLZmd5cDc1dWFCRFAxOTJYSEFNZHJNR2poY2RkT1hHYXRBMDdZS1B6R21h?=
 =?utf-8?B?WmdLR1dvYlk2alo3bGdzKzNiZ2VCWmU4NFlNUm4xYUY0OHFRMkZzclFvckFS?=
 =?utf-8?B?R3NHWFl4akRLZEZrSkNUODE0aWRhOWRvWVpIZHBwa2dQK1pOVC9uOWZDVzZ2?=
 =?utf-8?B?cXN4cU1KdkhjMEZjVFIzWnhjQ0FINXhlYitmS25XVFBUcDJGaDhLdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2113e863-69ce-4f05-bee8-08da179c0c04
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 07:07:01.1414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6A/MbjI7NXcqRM2amuHjHY4a+HbRtpOnshFOCkWCgrXGmAzqnUl7xC5HcsOMjDXxoNb919ZNjwP15A9jRGfibg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5877

On 05.04.2022 19:17, Jason Andryuk wrote:
> On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith <dpsmith@apertussolutions.com> wrote:
>> On 3/31/22 09:16, Jason Andryuk wrote:
>>> For the default policy, you could start by creating the system domains
>>> as privileged and just have a single hook to drop privs.  Then you
>>> don't have to worry about the "elevate" hook existing.  The patch 2
>>> asserts could instead become the location of xsm_drop_privs calls to
>>> have a clear demarcation point.  That expands the window with
>>> privileges though.  It's a little simpler, but maybe you don't want
>>> that.  However, it seems like you can only depriv once for the Flask
>>> case since you want it to be one-way.
>>
>> This does simplify the solution and since today we cannot differentiate
>> between hypervisor setup and hypervisor initiated domain construction
>> contexts, it does not run counter to what I have proposed. As for flask,
>> again I do not believe codifying a domain transition bound to a new XSM
>> op is the appropriate approach.
> 
> This hard coded domain transition does feel a little weird.  But it
> seems like a natural consequence of trying to use Flask to
> deprivilege.  I guess the transition could be behind a
> dom0less/hyperlaunch Kconfig option.  I just don't see a way around it
> in some fashion with Flask enforcing.
> 
> Another idea: Flask could start in permissive and only transition to
> enforcing at the deprivilege point.  Kinda gross, but it works without
> needing a transition.

I don't think that would be right. Logically such behavior ought to be
mirrored to SILO, and I'll take that for the example for being the
simpler model: Suppose an admin wants to disallow communication
between DomU-s created by Xen. Such would want enforcing when creating
those DomU-s, despite the creator (Xen) being all powerful. If the
device tree information said something different (e.g. directing for
an event channel to be established between two such DomU-s), this
should be flagged as an error, not be silently permitted.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 07:22:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 07:22:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299658.510705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc002-0001hg-Gw; Wed, 06 Apr 2022 07:22:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299658.510705; Wed, 06 Apr 2022 07:22:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc002-0001hZ-Dg; Wed, 06 Apr 2022 07:22:42 +0000
Received: by outflank-mailman (input) for mailman id 299658;
 Wed, 06 Apr 2022 07:22:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc000-0001hT-Gy
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 07:22:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 56e25e99-b57a-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 09:22:39 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-p8ZHjdxeMEepCpRfaPrv7A-1; Wed, 06 Apr 2022 09:22:37 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR04MB3223.eurprd04.prod.outlook.com (2603:10a6:6:e::20) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.31; Wed, 6 Apr 2022 07:22:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 07:22:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56e25e99-b57a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649229758;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=p/X8fWXnw3uZdperyAkoMOelm4vr1TgeVyBGLOeETng=;
	b=HKlF2oiiENameQuoPxRs4LmviuRTCOkL75hsbv7blK0TeO+N4kMHKrfbGOXZ2OZIy8oG6K
	5CtB1L9Y3/+YyhYsp0N2elnT4FsshemneSI2EoITy3qaLEjDObwLzPZVW9WVu6kicUZeVp
	5E3xVX38LXcfH/VvOBUwEe59+Eul644=
X-MC-Unique: p8ZHjdxeMEepCpRfaPrv7A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kQqYOV1qTtlf7aco+YWOGxVHkk6blqlTDooBgRTJZw2t5mebmfabS0/pnnKgDQXkLuzfvNMbr/tEULyqA0U+17ZmpVhNUbhA9iCLy5NJ41uYu9tJj+5xVuRTp7a/6xlQG63hlqVFebXowa++k5qsUyjlV6F1viBHp36ZfK5QBQixiRHjYvsNFt2LGp1kiNvPTeeggLteQUiAVv0M0HYtBmMuVORWCRHYUQOVRPYCZc36x8l0ulnxMVcYAnE/e3wyxndsioKv0pkpISOJgmArVeNp1KBmB1cCvB0UJW6FT+rHpaKr7JzcB6g9sz/tZGDNw91zg7LJ1iVwzrjTIJtgxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p/X8fWXnw3uZdperyAkoMOelm4vr1TgeVyBGLOeETng=;
 b=It89gz3X1dISvHH1Efcvw8+i8jW/pRzcflhbgCpn1ToO5zU/pLR4BGnXYwTKl1HR9paulmZl/UyP6hTvuMSPi4jMaUz+xpdkxw1IExj0TMR6jVZF++dowTlIJbkHNJ0lYNEFhhzX88J4+79uWjQ/RVtwV1PZYn4td7wCr4Ucr/kHCy36ksKcd6PUA6oRXdxuQOJxXPJNyDkpg00ZlwLFNZdHq3jRrsdcl+jIFN/TZpRLIhZoiLJmPHikrnUHiCA1aHij6D3Zzl/hCbSXuOqxh4IK/kSosrS9Zywb+8RKU5kvOVBRaU7vRIiQ/N9MmNv02pw2EYjSR/I00g3gzBUqwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d0e84ac8-308e-1784-982e-271705c13b7d@suse.com>
Date: Wed, 6 Apr 2022 09:22:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [xen-4.14-testing test] 169170: regressions - FAIL
Content-Language: en-US
To: osstest service owner <osstest-admin@xenproject.org>,
 xen-devel@lists.xenproject.org
References: <osstest-169170-mainreport@xen.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <osstest-169170-mainreport@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0205.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d286a27e-818f-4739-2612-08da179e3963
X-MS-TrafficTypeDiagnostic: DB6PR04MB3223:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB3223C586D0E01994AC0478B8B3E79@DB6PR04MB3223.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	i8ck/dT1Q+w4DLD4xq0qpPtkcNTEUul86dk0ImscleVY0j/dAzpHidpXRarp7SWR6U7lX6/mqJ00JNf85iaLU6ClrBBNcMhWcl61asiOrXZR2xcRzj/ymTaoOTJU98IGWJ9ZI29z+gOkCcDBb19FWG1KyX3m0F0mR9KbKD47EFUqXtwJUJd66aXBabl2lt0/YeB433mp4vgORiN95vzB6e5u0cUNpblZZsKOlgJ/c36WqOTxmm7t69rhiC6lDJm5zu3R9UvYVuwOT54lSAcVeQZvexRZPvtFOBmDRgRT7Zz3pcQO1FlrJgXhntRvKdt0iEZze3V/rvdLJHRnewiCBqPLMEzOZXC22YZpbgUQ17TFvG6WnIPhYRmYfBE8+6tUVa8/2m4wG62zEwb074aVtH1nw5VYvn5IpIeSCplwfya+HJKKsH2bi9+O38ox8FZ0HNjhkssXclByMVGdZZywMxIIGqiW9N34h6HY0+Z2FiAQCOSTjkkxhMqWLRK4a29yWu4NTwERYzeqCDHnZdWdPyXshqhLIbW6FOb5+l4spPXVD1ZjWoEJ1330ijBUfONEsu6jyTFp/dkPm+z2vme1A6R4+qiOON6lR2+o1goseNkK4yW6al4Eeo9IsGbu+Uoco2mN960mm6Rbs97fxKNxn6aeiHDbFpLqF/7VE1Unp1U6FR8qiXm2DVBfcQnVVzJgzO/VJ7kzoyHHL6xYFycdZRXHDeYguj7P9T+dCgxdDTu0CO7/6rxb449v2fPmThtYYrJNQ71VfBVrjY3Vh4cPNInfxhsMDFstiY8A+HWWvcN3X4DKrtUWpiujZ2bRwOwr
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(66946007)(26005)(4326008)(186003)(6486002)(966005)(508600001)(36756003)(66556008)(66476007)(83380400001)(8676002)(31686004)(2616005)(2906002)(6506007)(38100700002)(5660300002)(6512007)(8936002)(53546011)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OHo4ejQzdGo5d3o4RnJ1VTRXZHFpbllTSlVmbGxtK0xxK2d6NWVGWFFuakF6?=
 =?utf-8?B?NkJQdS9WVkwwelN3Vk13UFphamp2NXE1Nm1iZHZFMlVMMzZsNkpnNTBsU2Jv?=
 =?utf-8?B?LzV4Rk5xYWVDN1VvKzRaSkx3RU5TbHZDT1VRZW0rRE0wUlJIenU1NXhBQVFG?=
 =?utf-8?B?Qy92a0VDRTh2WnozRlFOeFpRWldSYVY1REdnZG9JM05iSnM5cFJKeW5QZlht?=
 =?utf-8?B?eGoyaDRDNGlJcEw3Uk5DSGlMZy93SG9mVGxWVW1yVFhwRDJ0VmpCNVVWRkdp?=
 =?utf-8?B?KzE2cU1Xd3g0cVJNMDV0VHg5ZWFuTEc4cVc4K0hHVnRRMUZ3bWJTVHVSazZN?=
 =?utf-8?B?TzZZdFhBNUsrVlJuUHIvZ2xLTjJTSHZ5cnpQWmg0ekFHWnlYekFrR1J6OHQy?=
 =?utf-8?B?NW9DNEJ3MTNKbmJ5SXZQeG03RTRTT1JjTm85VVpHSWZNbnl2SjlZZ3h4Nmtt?=
 =?utf-8?B?NkpDcWN2R1BxcEpQZFFFRkdmV3B2MlJrYXRaSkZkYmlha3psenlxNEREVEgw?=
 =?utf-8?B?UVpka3U4M00vQk44MWZodlp0YkMxMlVwbTcwN09Gc2hhRTNVdTFVWEdpc3dT?=
 =?utf-8?B?b1JqUmNZR2twSFFrSjBqR0dsUHFOSi9oeWpiRjlDWmw1VzZjaHN2K3lvSDZR?=
 =?utf-8?B?dDh6OHZLaSt2UXE2R21BeVRIYUhEUlpPeHJ2MHRtZFVnNWRIYmhWR3hKZkFa?=
 =?utf-8?B?M1NzQk5EZnR6aUVTQzBZalRONDhtcnVXT1EvR0VaaWY5ZTl0aVNheXlGRHZR?=
 =?utf-8?B?UVozMTNiUnlyeUNNM3VDQ0RLSEU4UG8ydzIvZld1T0tTRjh6R0NYc3RKQ25a?=
 =?utf-8?B?RHJ4empjRGNRc2pNdVQwQUlRRXBjWjB1ZW1wK0Z2TFdMZ0NLa2VpZFdKcWRX?=
 =?utf-8?B?Szk5ZmxuenN1TEVmblBpSkdoVTNHUWhzWDJsWUVieHVpNHJIV0hWaUdYRGdE?=
 =?utf-8?B?Y0hNdFA3UEE5SU0zdm9ZVjJvcFd0cjZlb2tMVDBsWVc5TWw4RTRBZi8yZlRq?=
 =?utf-8?B?TTZ4Z1lGQ01idFZ5T3hTT2QwUCtXOFBkdXV0M0NkYWVMM09LZFE3WjErZDZn?=
 =?utf-8?B?di9Qam5EMlJ4SkpRYnUwOHJzWm13VVNqcnBPUVlmTjRkUkFyK2RqeTcvbndS?=
 =?utf-8?B?eUR2VnBJeEMvc1E2QVJSVHdJYmFpUlhKUVdVK3VYSXBOK0tPV2xWY3FJVnZr?=
 =?utf-8?B?MkFhM091Vi85Q1ZvRW91RlJHdFo5UjNXQ0pPZkozL2pvRHc2ckk0b3RudWFD?=
 =?utf-8?B?VUdhcTRLYWN1dFA1VjNUSVBFeTltR0QvNUROZll1Q0FOM2xFdlVCelQ4SWRk?=
 =?utf-8?B?TlgwZWJZQ3dqY2NxSDMxNm5nMjMvb3hJQjBsV1o3bFVvMGNyQ3g5UzA3Szlh?=
 =?utf-8?B?a1dPSHYzZ0lSV3ZyQlZKaHYxaUxVWGQ0bis1WUhrZ0RDb1hlTWZHMmlkNW9D?=
 =?utf-8?B?eVB5cXJrSzMvZHNialFZNVd6M3VpbmZ4QjdmbFVLc2I4am4xYlJ6NzVLbkFK?=
 =?utf-8?B?Ly94RjFRL1BCbmlrRjRkYzRDSERiL1VBdHkwNUxzNmQ0bDY4aW04K2pYRlNJ?=
 =?utf-8?B?NWlxWGNGMDR1VjBUNnd0Y21XRGhPN3EreDJlQWhsVUR3QU5ScEtranhabTd6?=
 =?utf-8?B?MXF6Y0Zud051eU90Tk1vVVNOZE1EUTRCdVFnK015S3RVVkQwMkVObENqZmUz?=
 =?utf-8?B?SjdDNWRYdWNSdXQ4bm8vd09xU2FUN2RJTjdRM0x5S29tRW5NVUxycDQzeCt4?=
 =?utf-8?B?dC9teUVMdVo5VVEwMmN0aGtpVjJJN1pOMngwMmFJaXhuZExHUFdIN0E4YWVy?=
 =?utf-8?B?K3BrcjQrN1FLdXVJYTg3bU5nN1JMYzVDbm5heEFDbWxFZmxxL1UxSWtTUERJ?=
 =?utf-8?B?OHFtU0lNYTRwdlU0Wmc0MDF5ZnB0MFFLRTBoWDVRUU12dWcyREREclY1ZUJa?=
 =?utf-8?B?dHZHZkhJSm5naGtNS2R6ZTVjU2xmM0tVdEd4d3RSTUw3d1IzZS8weU5jNm12?=
 =?utf-8?B?OFBPU0dKQXNBZGJkWUdFRGc2SWJYVVFLM1daNjZZSTFrYWpncldWYVhNRUcw?=
 =?utf-8?B?VkxMNVJYa1d6am9QS0xtekJOSGhCVGJaKzJOMzVQUU5ZRTUyVWJEeU5QdU9r?=
 =?utf-8?B?Y0ZOR21HK3NVdmJwQXhPSzAwd1pha3dwQmwrY0x5Smo1bEJRYzJzbCtBTThk?=
 =?utf-8?B?ZENHQWdKUXlKamUvV25GRkE5OWZBQzJNTXFhU1prOGEza2pEakppQjVIY2E2?=
 =?utf-8?B?ZDJtQVJ0QWRJVUc0RHZKT2RwWWNiUldxMTVvYkJ2Z05kRGhnWDBoRVlmcWUz?=
 =?utf-8?B?S2FQQXFvUmhFYkhXWWVuaXFVTW1vN2xJMzVPdXpnbkRXVTNqZVFSUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d286a27e-818f-4739-2612-08da179e3963
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 07:22:36.5791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jLYynUtOxqBEEK3iezkSv7CqO3p0sYpLDgmUZCr06HKjB0p/KH4hKbpCbO8HNi9DMd5iWpi8tcddRGMarNd84A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3223

On 05.04.2022 16:53, osstest service owner wrote:
> flight 169170 xen-4.14-testing real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/169170/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-amd64-xl          18 guest-localmigrate       fail REGR. vs. 168506
>  build-arm64-xsm               6 xen-build                fail REGR. vs. 168506

Urgh:

  CC      hw/virtio/virtio-bus.o
  CC      hw/virtio/virtio-rng.o
  CC      hw/virtio/virtio-pci.o
  CC      hw/virtio/virtio-mmio.o
  CC      hw/virtio/virtio-pmem-pci.o
  CC      hw/virtio/vhost-stub.o
cc: internal compiler error: Segmentation fault signal terminated program cc1
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-8/README.Bugs> for instructions.
make: *** [/home/osstest/build.169170.build-arm64-xsm/xen/tools/qemu-xen-dir/rules.mak:69: hw/virtio/vhost-stub.o] Error 4

If this is going to recur, I don't see what we ought to do about this.
This doesn't look to have any relation to the recently added two
commits on the respective qemu stable tree.

However, if this wouldn't recur it would be similarly alarming: That
would suggest the build environment to not be stable.

Thoughts anyone?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 07:24:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 07:24:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299661.510716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc01X-0002Gp-UC; Wed, 06 Apr 2022 07:24:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299661.510716; Wed, 06 Apr 2022 07:24:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc01X-0002Gi-Pc; Wed, 06 Apr 2022 07:24:15 +0000
Received: by outflank-mailman (input) for mailman id 299661;
 Wed, 06 Apr 2022 07:24:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bUIs=UQ=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nc01W-0002Ga-NN
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 07:24:14 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 8bfef870-b57a-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 09:24:08 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61C1623A;
 Wed,  6 Apr 2022 00:24:11 -0700 (PDT)
Received: from [10.57.6.245] (unknown [10.57.6.245])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7FB553F73B;
 Wed,  6 Apr 2022 00:24:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bfef870-b57a-11ec-8fbc-03012f2f19d4
Message-ID: <fd4b0cc7-3cb9-3f56-5db7-31d41b24611c@arm.com>
Date: Wed, 6 Apr 2022 09:24:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220402054223.10304-1-peng.fan@oss.nxp.com>
 <20220402054223.10304-2-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220402054223.10304-2-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Peng,

On 02.04.2022 07:42, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The i.MX LPUART Documentation:
> https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
> Chatper 13.6 Low Power Universal Asynchronous Receiver/
> Transmitter (LPUART)
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  xen/drivers/char/Kconfig      |   8 +
>  xen/drivers/char/Makefile     |   1 +
>  xen/drivers/char/imx-lpuart.c | 275 ++++++++++++++++++++++++++++++++++
>  xen/include/xen/imx-lpuart.h  |  64 ++++++++
>  4 files changed, 348 insertions(+)
>  create mode 100644 xen/drivers/char/imx-lpuart.c
>  create mode 100644 xen/include/xen/imx-lpuart.h
> 
> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> index 2ff5b288e2..0efdb2128f 100644
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -13,6 +13,14 @@ config HAS_CADENCE_UART
>  	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
>  	  based board, say Y.
>  
> +config HAS_IMX_LPUART
> +	bool "i.MX LPUART driver"
> +	default y
> +	depends on ARM_64
> +	help
> +	  This selects the i.MX LPUART. If you have a i.MX8QM based board,
> +	  say Y.
Why did you move "say Y" to the next line?

> +
>  config HAS_MVEBU
>  	bool "Marvell MVEBU UART driver"
>  	default y
> diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
> index 7c646d771c..14e67cf072 100644
> --- a/xen/drivers/char/Makefile
> +++ b/xen/drivers/char/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o
>  obj-$(CONFIG_HAS_OMAP) += omap-uart.o
>  obj-$(CONFIG_HAS_SCIF) += scif-uart.o
>  obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o
> +obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o
>  obj-$(CONFIG_ARM) += arm-uart.o
>  obj-y += serial.o
>  obj-$(CONFIG_XEN_GUEST) += xen_pv_console.o
> diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
> new file mode 100644
> index 0000000000..49330fd2f8
> --- /dev/null
> +++ b/xen/drivers/char/imx-lpuart.c
> @@ -0,0 +1,275 @@
> +/*
> + * xen/drivers/char/imx-lpuart.c
> + *
> + * Driver for i.MX LPUART.
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <xen/errno.h>
> +#include <xen/imx-lpuart.h>
> +#include <xen/init.h>
> +#include <xen/irq.h>
> +#include <xen/mm.h>
> +#include <xen/serial.h>
> +#include <asm/device.h>
> +#include <asm/io.h>
> +
> +#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
> +#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
> +
> +static struct imx_lpuart {
> +    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
> +    uint32_t irq;
> +    char __iomem *regs;
> +    struct irqaction irqaction;
> +    struct vuart_info vuart;
> +} imx8_com;
> +
> +static void imx_lpuart_interrupt(int irq, void *data,
> +                                 struct cpu_user_regs *regs)
> +{
> +    struct serial_port *port = data;
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t sts, rxcnt;
> +
> +    sts = imx_lpuart_read(uart, UARTSTAT);
> +    rxcnt = imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
> +
> +    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
> +	    serial_rx_interrupt(port, regs);
> +
> +    if ( sts & UARTSTAT_TDRE )
> +	    serial_tx_interrupt(port, regs);
> +
> +    imx_lpuart_write(uart, UARTSTAT, sts);
> +}
> +
> +static void __init imx_lpuart_init_preirq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t ctrl, old_ctrl, bd;
> +
> +    ctrl = old_ctrl = imx_lpuart_read(uart, UARTCTRL);
Please remove ctrl assignment here as you are overriding it in the next line.

> +    ctrl = (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
> +    bd = imx_lpuart_read(uart, UARTBAUD);
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
> +	    cpu_relax();
> +
> +    /* Disable transmit and receive */
> +    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL_RE));
> +
> +    /* Reuse firmware baudrate settings, only disable DMA here */
> +    bd &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
> +
> +    imx_lpuart_write(uart, UARTMODIR, 0);
> +    imx_lpuart_write(uart, UARTBAUD, bd);
> +    imx_lpuart_write(uart, UARTCTRL, ctrl);
> +}
> +
> +static void __init imx_lpuart_init_postirq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t temp;
> +
> +    uart->irqaction.handler = imx_lpuart_interrupt;
> +    uart->irqaction.name = "imx_lpuart";
> +    uart->irqaction.dev_id = port;
> +
> +    if ( setup_irq(uart->irq, 0, &uart->irqaction) != 0 )
> +    {
> +        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
> +                uart->irq);
> +        return;
> +    }
> +
> +    /* Enable interrupts */
> +    temp = imx_lpuart_read(uart, UARTCTRL);
> +    temp |= (UARTCTRL_RIE | UARTCTRL_TIE);
> +    temp |= UARTCTRL_ILIE;
> +    imx_lpuart_write(uart, UARTCTRL, temp);
> +}
> +
> +static void imx_lpuart_suspend(struct serial_port *port)
> +{
> +    BUG();
> +}
> +
> +static void imx_lpuart_resume(struct serial_port *port)
> +{
> +    BUG();
> +}
> +
> +static int imx_lpuart_tx_ready(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +
> +    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
> +}
> +
> +static void imx_lpuart_putc(struct serial_port *port, char c)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
> +        cpu_relax();
> +
> +    imx_lpuart_write(uart, UARTDATA, c);
> +}
> +
> +static int imx_lpuart_getc(struct serial_port *port, char *pc)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    int ch;
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
> +	    return 0;
> +
> +    ch = imx_lpuart_read(uart, UARTDATA);
> +    *pc = ch & 0xff;
> +
> +    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
> +        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
> +
> +    return 1;
> +}
> +
> +static int __init imx_lpuart_irq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +
> +    return ((uart->irq > 0) ? uart->irq : -1);
> +}
> +
> +static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +
> +    return &uart->vuart;
> +}
> +
> +static void imx_lpuart_start_tx(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t temp;
> +
> +    temp = imx_lpuart_read(uart, UARTSTAT);
> +    /* Wait until empty */
> +    while ( !(temp & UARTSTAT_TDRE) )
> +	    cpu_relax();
> +
> +    temp = imx_lpuart_read(uart, UARTCTRL);
> +    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
> +}
> +
> +static void imx_lpuart_stop_tx(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t temp;
> +
> +    temp = imx_lpuart_read(uart, UARTCTRL);
> +    temp &= ~(UARTCTRL_TIE | UARTCTRL_TCIE);
> +    imx_lpuart_write(uart, UARTCTRL, temp);
> +}
> +
> +static struct uart_driver __read_mostly imx_lpuart_driver = {
> +    .init_preirq = imx_lpuart_init_preirq,
> +    .init_postirq = imx_lpuart_init_postirq,
> +    .endboot = NULL,
> +    .suspend = imx_lpuart_suspend,
> +    .resume = imx_lpuart_resume,
> +    .tx_ready = imx_lpuart_tx_ready,
> +    .putc = imx_lpuart_putc,
> +    .getc = imx_lpuart_getc,
> +    .irq = imx_lpuart_irq,
> +    .start_tx = imx_lpuart_start_tx,
> +    .stop_tx = imx_lpuart_stop_tx,
> +    .vuart_info = imx_lpuart_vuart_info,
> +};
> +
> +static int __init imx_lpuart_init(struct dt_device_node *dev,
> +                                  const void *data)
> +{
> +    const char *config = data;
> +    struct imx_lpuart *uart;
> +    int res;
> +    u64 addr, size;
> +
> +    if ( strcmp(config, "") )
> +        printk("WARNING: UART configuration is not supported\n");
> +
> +    uart = &imx8_com;
> +
> +    uart->baud = 115200;
> +    uart->data_bits = 8;
> +    uart->parity = 0;
> +    uart->stop_bits = 1;
> +
> +    res = dt_device_get_address(dev, 0, &addr, &size);
> +    if ( res )
> +    {
> +        printk("imx8-lpuart: Unable to retrieve the base"
> +               " address of the UART\n");
> +        return res;
> +    }
> +
> +    res = platform_get_irq(dev, 0);
> +    if ( res < 0 )
> +    {
> +        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
> +        return -EINVAL;
> +    }
> +    uart->irq = res;
> +
> +    uart->regs = ioremap_nocache(addr, size);
> +    if ( !uart->regs )
> +    {
> +        printk("imx8-lpuart: Unable to map the UART memory\n");
> +        return -ENOMEM;
> +    }
> +
> +    uart->vuart.base_addr = addr;
> +    uart->vuart.size = size;
> +    uart->vuart.data_off = UARTDATA;
> +    /* tmp from uboot */
> +    uart->vuart.status_off = UARTSTAT;
> +    uart->vuart.status = UARTSTAT_TDRE;
> +
> +    /* Register with generic serial driver */
> +    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
> +
> +    dt_device_set_used_by(dev, DOMID_XEN);
> +
> +    return 0;
> +}
> +
> +static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
> +{
> +    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
> +    {},
To be coherent with the rest of Xen code, please use { /* sentinel */ }

> +};
> +
> +DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
> +    .dt_match = imx_lpuart_dt_compat,
> +    .init = imx_lpuart_init,
> +DT_DEVICE_END
Please add a newline here.

> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/xen/imx-lpuart.h b/xen/include/xen/imx-lpuart.h
> new file mode 100644
> index 0000000000..945ab1c4fa
> --- /dev/null
> +++ b/xen/include/xen/imx-lpuart.h
> @@ -0,0 +1,64 @@
> +/*
> + * xen/include/asm-arm/imx-lpuart.h
Wrong path as you put this header in xen/include/xen.

> + *
> + * Common constant definition between early printk and the LPUART driver
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ASM_ARM_IMX_LPUART_H
Wrong macro as you are not in arm/include/asm.

> +#define __ASM_ARM_IMX_LPUART_H
> +
> +/* 32-bit register definition */
> +#define UARTBAUD          (0x10)
> +#define UARTSTAT          (0x14)
> +#define UARTCTRL          (0x18)
> +#define UARTDATA          (0x1C)
> +#define UARTMATCH         (0x20)
> +#define UARTMODIR         (0x24)
> +#define UARTFIFO          (0x28)
> +#define UARTWATER         (0x2c)
> +
> +#define UARTSTAT_TDRE     (1 << 23)
> +#define UARTSTAT_TC       (1 << 22)
> +#define UARTSTAT_RDRF     (1 << 21)
> +#define UARTSTAT_OR       (1 << 19)
> +
> +#define UARTBAUD_OSR_SHIFT (24)
> +#define UARTBAUD_OSR_MASK (0x1f)
> +#define UARTBAUD_SBR_MASK (0x1fff)
> +#define UARTBAUD_BOTHEDGE (0x00020000)
> +#define UARTBAUD_TDMAE    (0x00800000)
> +#define UARTBAUD_RDMAE    (0x00200000)
> +
> +#define UARTCTRL_TIE      (1 << 23)
> +#define UARTCTRL_TCIE     (1 << 22)
> +#define UARTCTRL_RIE      (1 << 21)
> +#define UARTCTRL_ILIE     (1 << 20)
> +#define UARTCTRL_TE       (1 << 19)
> +#define UARTCTRL_RE       (1 << 18)
> +#define UARTCTRL_M        (1 << 4)
> +
> +#define UARTWATER_RXCNT_OFF     24
> +
> +#endif /* __ASM_ARM_IMX_LPUART_H */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */

I think you should put this header in xen/arch/arm/include/asm/ as it is arm related header.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 07:42:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 07:42:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299671.510727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0J5-0004qZ-Ic; Wed, 06 Apr 2022 07:42:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299671.510727; Wed, 06 Apr 2022 07:42:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0J5-0004qS-Ej; Wed, 06 Apr 2022 07:42:23 +0000
Received: by outflank-mailman (input) for mailman id 299671;
 Wed, 06 Apr 2022 07:42:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6Pbn=UQ=nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1nc0J4-0004qM-1c
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 07:42:22 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on060f.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::60f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c0729272-b57c-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 09:42:07 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by PA4PR04MB7728.eurprd04.prod.outlook.com (2603:10a6:102:e8::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 07:39:49 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 07:39:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0729272-b57c-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D6yeq0beyr2DV2hkI/w8SghPFm1VV2MBomt1YDiMjZuhC58PvrUabHtLwBaZwBGKPwsYeuDfwnkbD81ucOsygWARgJECVine6RbH8FCC1pUwQwqzhBfORo5Vvm1bfvormaaId+SaNnjmw0FeEnB/dTe4uxAfhGHLAg1b5u6ndNF8wk26qcJsp3LlINDKOsbGAb5I0J1xO9vXAbFVoL1/b5JeK6D9WjdZ2ELQJgVMExZlycIrKLFtnoO3wJAHy3doVl+cMoCsU409yyHuB98P3lIhxdxCR1SOlaNiztwxfADzK8lcuEDCEy5BL98ECorHOhTiD3gbJjGesBbgZM+xBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Mp8y2JjWcRMtpciVcOwkpJEfGxfxY04Hzr5uyJp7zl8=;
 b=WcdtHrdjyZr8fwk1g3yH7gsrDTIbBgFSmyITLeNw3oKR8DxhJpPuc+zyXnqlqvHbekv4In57KQbNfvzJRXSEzpoK/R7iDAQNCjXXif4K8v5gkJ7ZWafiEhP6FbV78leKy/SYsUK7WnuzbslOolQZXj5kLbdzTJWnu2xOqTbCEpIu3uDm8x6LfOxyM3UMKSZI2PlRbix2TflMrMuYozUKHNhy15LgOOvvpjJjV78RTtuaBm8eGinv4Xqtw0nS3vmKsdSRlEVdJjrlwaj7zMnT3LESlgy62Bhl56mqE2C6R+lEz5rDQ2wVe/vGNN0mKoVNY9as4/+pSywre/+cLTdFig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass
 header.d=nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Mp8y2JjWcRMtpciVcOwkpJEfGxfxY04Hzr5uyJp7zl8=;
 b=Nf3o0Sxt5Cb80uQOCeS4dC5ng5xjP9vOs6sBsDrS76Wx6gdx22+i/cHs6Y3meRWdzgy1LKOPmXCVF+OC8EXcO4h76JKMz2eeHsPfAGus6c5EjSQL3IES/v42BXFcny46/3hHjUE7i60pC56Ck/fuvkFzpzoky9a5gWLDwPyPbaA=
From: Peng Fan <peng.fan@nxp.com>
To: Michal Orzel <michal.orzel@arm.com>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, "bertrand.marquis@arm.com"
	<bertrand.marquis@arm.com>
CC: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"van.freenix@gmail.com" <van.freenix@gmail.com>
Subject: RE: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
Thread-Topic: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
Thread-Index: AQHYRk65ZgQ/2kC1/US0MsPOiCii5KzigfsAgAADlfA=
Date: Wed, 6 Apr 2022 07:39:49 +0000
Message-ID:
 <DU0PR04MB9417FBA3876918C0FD7F187188E79@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220402054223.10304-1-peng.fan@oss.nxp.com>
 <20220402054223.10304-2-peng.fan@oss.nxp.com>
 <fd4b0cc7-3cb9-3f56-5db7-31d41b24611c@arm.com>
In-Reply-To: <fd4b0cc7-3cb9-3f56-5db7-31d41b24611c@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nxp.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dfdef3f4-9cb8-42f2-b38b-08da17a0a189
x-ms-traffictypediagnostic: PA4PR04MB7728:EE_
x-microsoft-antispam-prvs:
 <PA4PR04MB77289F0A08FDD08A95D4056A88E79@PA4PR04MB7728.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 eRFYebFR4YgnPijRmWkoMQX3+ZsQOP9S6KqAF3PQ2U4iS3k0btZ8LkcQfV2WUBYSxaaN19PyVHtGwU4FMoXMHWUJq38XSU7dEOVdiEBa/PBV5GtJf6xYLY9K6Gph92IC98uHkq/Xp1f8oZTDDZG3/zjoVyaGajIkXZRQ+kjxEh89u1PesZH/strtOZPnHGDUxf6ojwfjwJKkwniys9qauFxp7kYgu+9SMst5bjIdQIOYrzPlo1SVKM5Ajyc7BRI2EQMEtzx9pmqr02cxmiX4o6YBs8wFh6N1s3gqxcvHGtOvRWvX035UQ24nRBbrWt6q8epxlRoCdT/1uuTY2E2mXSDzGB+w6+9boUNsYa4Lbw2jzD09BmdmK2RaMos2cdMiYxZhWDK9J0gtm4xeb1i8RYGzHrDKgxXqtoI1VgdUV64RsLfO8IAVhGtchT3cQnFqy0bLKSxmKnc38EQUxLRJs+XpKxdtP52h6H7vedoR7IHHq2DWhImWbWdi/JHc+IJPHaRLFzbV+dbUe5jbGeczk+0sZgBYl3TN1IyiushJUrsDfrAquiVn9UKznJQwRWuJRl4ItLjkP0fnLfaIQE8AlZbHqYdNn0/2MZf/VODbidAmpfV9EruXt7zWWR437MObAZpPFvK67E1McnL6HWlCEI9Iv4W+75XffoRa2m15+gAh3JSqDiOVefoEXN78vO5b/Fu/wN4e6sfOLc60+wbxoALheSVWWp2v7if9fBQbfohUVUTA9ZETd6fH5O4Gthjj18FMF89vaQVD4odXIhS7I6PByNWS9YZwizO0jTK8OxwPzo+JHeQ+kOI8Od01fZcN
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(8676002)(966005)(9686003)(66556008)(30864003)(52536014)(66446008)(44832011)(76116006)(4326008)(122000001)(6506007)(55016003)(53546011)(7696005)(66476007)(45080400002)(64756008)(8936002)(66946007)(38100700002)(7416002)(5660300002)(71200400001)(38070700005)(83380400001)(316002)(26005)(54906003)(186003)(2906002)(110136005)(33656002)(508600001)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?WTKzj8AJyQto1Zukp7t2G3cv3mTcDPzkvhUYdTJ8S4dvFPCZWKnxbviIQz3p?=
 =?us-ascii?Q?bDt9biDOQhPhHtJOJ9E5lFAFzJYGwZn4e0q7NQu9NxQ3hrF3M9XZR0r1WYLr?=
 =?us-ascii?Q?FexaEYYTA425MtpALtBASaYwzW9gyDipXUGnft4ek5dWEUEasIS0GjaokjYi?=
 =?us-ascii?Q?q1mUFLX4ydM99scjIIhAihmR2GE2fYG4luqNmV63M2HETxhIxfq02n8HmUPc?=
 =?us-ascii?Q?GPL+yMWQfiQt0sPI9x69k+lmXiDfCaUFTUfD0/uZjo7Vpq3uzrxjM5w8YGq3?=
 =?us-ascii?Q?BjHqwR0eDKaHt0J5P9u3eiaJmqT03iTUX/oBHnqQtuO3AmZokqJXI7ZJLrrX?=
 =?us-ascii?Q?DLOIzW+KEeAHls6F5h2cHEYbWHRd/CueeMVHfGEvDT17KUNg8Qc7vZbkeE1j?=
 =?us-ascii?Q?HAra2e5JHmkBLy082D8yz/8JM+yH49SvTFWF7T6YccDuDlJ0IpmkNNxHShQu?=
 =?us-ascii?Q?nviFA+4+26B3/UplUg5wf8NFx8iBjt3YsABypQ7razrW4GF2Md8MbNbRdGx2?=
 =?us-ascii?Q?shqnq8x4FN15TVdelKYkXyX6w6WrkkePjp0MpzduxPTFDOYPOSnNgHHyUcj5?=
 =?us-ascii?Q?9o1dAzWGEyeWy//H1lUgQQVgFmvfg3Rs5AUgFuN7S1wzrUIZTegFswG5Bcsv?=
 =?us-ascii?Q?RUkgXWeyWe+rjxfpoVuDjfrooHiJ9H3GI+RkPaM1dcjCtkzPiDOdsd9kYJCm?=
 =?us-ascii?Q?o9f9I7b4Y+6GYYCK0A+px24jSfTvylhklIrDbUvklOPUILWfzWYFEFsKvRAA?=
 =?us-ascii?Q?/YNaHf9CzsfUSjdTHSgaKTeRdLfw6GW3o1zkmywmUEllD8Ny2sZD1GenmPPK?=
 =?us-ascii?Q?aoSYpiIpGikvn2Un1xUOfQg307DmyM5j5uNxk5yYAL5wwtUZEuxas3h+kQOA?=
 =?us-ascii?Q?r7lTroYYsA4bJmqLntsMJPcuCpXYkwXBNsd2O/pU4cXUjCcjMsGSSttKeAG2?=
 =?us-ascii?Q?eu9t1ldYQoTuBublxod3YNlGLCmwwvvoM39PVHotaaMoWuFcsO3Xs/KIh3tB?=
 =?us-ascii?Q?A9yYy9HptVe802WKu4NKYmF41wsr4T91USZArGXbOJCK7rZwnyio1sn99SZQ?=
 =?us-ascii?Q?BxhHoLIlyjznSV7KdDIlcfeg4uX5zc4NqRRwAXFWy+5ac1n6sjKFitpwQfxH?=
 =?us-ascii?Q?Kf08YuryX5rZxzveC4vWOuHc6jxOVWdGcQi6aP4GnLMlCPW+wJ/AFQKWBBFL?=
 =?us-ascii?Q?nQLsq+MazNlSTczy03gaC7Z1cEnR4gPjy9fjmg3tL6i0sDnQILwPcf5t9S+u?=
 =?us-ascii?Q?cJJy3rGQpmExRUf5dM2UGdaquTCfSdeaD+oxedfRgZyZ28dOiuD8BhWFdJiz?=
 =?us-ascii?Q?ojpG5xgQ2A7yI5Lpy+9a23gBZFsRI9RqACyfyonyuUfXeGT/+rRUxuV271I1?=
 =?us-ascii?Q?91f7wJSZ6pFJU4PU8esoJWlIyU+IT9B+M1Whl2E/cSNxxLVC4foJSh+MlG5J?=
 =?us-ascii?Q?cH7wETfRcW78xalnAfF5sN3LEeVn5iyEoVAgd5IEsUeps8Rn87v1CITEHXMK?=
 =?us-ascii?Q?rXbwyKlNBdp+00p684S3PcgsF7CLCLv5L/JmvRatsJ/qajhCRc9ho2Jp2dBP?=
 =?us-ascii?Q?XQEE3wHmvFlqVHpM1tGKFmYEmXDAsZfsWrf9O1tmX5xDemj1A6Ra8MqUl8G4?=
 =?us-ascii?Q?w7xw4SrFvW8aq29TnsDVo8+JU+UFB9cDtRFhIGEiZkgCJ+4RGpYidnQL3bMz?=
 =?us-ascii?Q?UqksP4nfz/2hg+LcXPS8YQGO1qxs044bPJUpa6F9NwcM9B98/Pe43qsCRilm?=
 =?us-ascii?Q?1c9s/FGP/A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfdef3f4-9cb8-42f2-b38b-08da17a0a189
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2022 07:39:49.7615
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qkOY+BrgGSgqFDYPYaAaFQCG9Mwxuzz3Oo55uj2Jy5vpg1ZTHvQewNKfjHGKjVJZGvouymvuWk9Hd2OlnPwB2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7728

> Subject: Re: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
>=20
> Hi Peng,
>=20
> On 02.04.2022 07:42, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The i.MX LPUART Documentation:
> >
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww.
> >
> nxp.com%2Fwebapp%2FDownload%3FcolCode%3DIMX8QMIEC&amp;data=3D0
> 4%7C01%7Cp
> >
> eng.fan%40nxp.com%7Cc7d221ce800342bbd7c108da179e72ca%7C686ea1d
> 3bc2b4c6
> >
> fa92cd99c5c301635%7C0%7C1%7C637848266543058498%7CUnknown%7C
> TWFpbGZsb3d
> >
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
> 3D%7C
> >
> 3000&amp;sdata=3D3CV%2FoJViSFzqRby0h577SiusHRQnC8KiXscntQW%2BZOs
> %3D&amp;
> > reserved=3D0 Chatper 13.6 Low Power Universal Asynchronous Receiver/
> > Transmitter (LPUART)
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  xen/drivers/char/Kconfig      |   8 +
> >  xen/drivers/char/Makefile     |   1 +
> >  xen/drivers/char/imx-lpuart.c | 275
> > ++++++++++++++++++++++++++++++++++
> >  xen/include/xen/imx-lpuart.h  |  64 ++++++++
> >  4 files changed, 348 insertions(+)
> >  create mode 100644 xen/drivers/char/imx-lpuart.c  create mode
> 100644
> > xen/include/xen/imx-lpuart.h
> >
> > diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index
> > 2ff5b288e2..0efdb2128f 100644
> > --- a/xen/drivers/char/Kconfig
> > +++ b/xen/drivers/char/Kconfig
> > @@ -13,6 +13,14 @@ config HAS_CADENCE_UART
> >  	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zyn=
q
> >  	  based board, say Y.
> >
> > +config HAS_IMX_LPUART
> > +	bool "i.MX LPUART driver"
> > +	default y
> > +	depends on ARM_64
> > +	help
> > +	  This selects the i.MX LPUART. If you have a i.MX8QM based board,
> > +	  say Y.
> Why did you move "say Y" to the next line?

I configured vimrc with " set cc=3D75,100 ", the "." will be at 80, so I
move "say Y." to next line.

>=20
> > +
> >  config HAS_MVEBU
> >  	bool "Marvell MVEBU UART driver"
> >  	default y
> > diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
> > index 7c646d771c..14e67cf072 100644
> > --- a/xen/drivers/char/Makefile
> > +++ b/xen/drivers/char/Makefile
> > @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) +=3D mvebu-uart.o
> >  obj-$(CONFIG_HAS_OMAP) +=3D omap-uart.o
> >  obj-$(CONFIG_HAS_SCIF) +=3D scif-uart.o
> >  obj-$(CONFIG_HAS_EHCI) +=3D ehci-dbgp.o
> > +obj-$(CONFIG_HAS_IMX_LPUART) +=3D imx-lpuart.o
> >  obj-$(CONFIG_ARM) +=3D arm-uart.o
> >  obj-y +=3D serial.o
> >  obj-$(CONFIG_XEN_GUEST) +=3D xen_pv_console.o diff --git
> > a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c new
> > file mode 100644 index 0000000000..49330fd2f8
> > --- /dev/null
> > +++ b/xen/drivers/char/imx-lpuart.c
> > @@ -0,0 +1,275 @@
> > +/*
> > + * xen/drivers/char/imx-lpuart.c
> > + *
> > + * Driver for i.MX LPUART.
> > + *
> > + * Peng Fan <peng.fan@nxp.com>
> > + * Copyright 2022 NXP
> > + *
> > + * This program is free software; you can redistribute it and/or
> > +modify
> > + * it under the terms of the GNU General Public License as published
> > +by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <xen/errno.h>
> > +#include <xen/imx-lpuart.h>
> > +#include <xen/init.h>
> > +#include <xen/irq.h>
> > +#include <xen/mm.h>
> > +#include <xen/serial.h>
> > +#include <asm/device.h>
> > +#include <asm/io.h>
> > +
> > +#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
> > +#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs +
> > +off)
> > +
> > +static struct imx_lpuart {
> > +    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
> > +    uint32_t irq;
> > +    char __iomem *regs;
> > +    struct irqaction irqaction;
> > +    struct vuart_info vuart;
> > +} imx8_com;
> > +
> > +static void imx_lpuart_interrupt(int irq, void *data,
> > +                                 struct cpu_user_regs *regs) {
> > +    struct serial_port *port =3D data;
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t sts, rxcnt;
> > +
> > +    sts =3D imx_lpuart_read(uart, UARTSTAT);
> > +    rxcnt =3D imx_lpuart_read(uart, UARTWATER) >>
> UARTWATER_RXCNT_OFF;
> > +
> > +    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
> > +	    serial_rx_interrupt(port, regs);
> > +
> > +    if ( sts & UARTSTAT_TDRE )
> > +	    serial_tx_interrupt(port, regs);
> > +
> > +    imx_lpuart_write(uart, UARTSTAT, sts); }
> > +
> > +static void __init imx_lpuart_init_preirq(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t ctrl, old_ctrl, bd;
> > +
> > +    ctrl =3D old_ctrl =3D imx_lpuart_read(uart, UARTCTRL);
> Please remove ctrl assignment here as you are overriding it in the next l=
ine.
>=20
> > +    ctrl =3D (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
> > +    bd =3D imx_lpuart_read(uart, UARTBAUD);
> > +
> > +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
> > +	    cpu_relax();
> > +
> > +    /* Disable transmit and receive */
> > +    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE |
> > + UARTCTRL_RE));
> > +
> > +    /* Reuse firmware baudrate settings, only disable DMA here */
> > +    bd &=3D ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
> > +
> > +    imx_lpuart_write(uart, UARTMODIR, 0);
> > +    imx_lpuart_write(uart, UARTBAUD, bd);
> > +    imx_lpuart_write(uart, UARTCTRL, ctrl); }
> > +
> > +static void __init imx_lpuart_init_postirq(struct serial_port *port)
> > +{
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t temp;
> > +
> > +    uart->irqaction.handler =3D imx_lpuart_interrupt;
> > +    uart->irqaction.name =3D "imx_lpuart";
> > +    uart->irqaction.dev_id =3D port;
> > +
> > +    if ( setup_irq(uart->irq, 0, &uart->irqaction) !=3D 0 )
> > +    {
> > +        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
> > +                uart->irq);
> > +        return;
> > +    }
> > +
> > +    /* Enable interrupts */
> > +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> > +    temp |=3D (UARTCTRL_RIE | UARTCTRL_TIE);
> > +    temp |=3D UARTCTRL_ILIE;
> > +    imx_lpuart_write(uart, UARTCTRL, temp); }
> > +
> > +static void imx_lpuart_suspend(struct serial_port *port) {
> > +    BUG();
> > +}
> > +
> > +static void imx_lpuart_resume(struct serial_port *port) {
> > +    BUG();
> > +}
> > +
> > +static int imx_lpuart_tx_ready(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +
> > +    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC; }
> > +
> > +static void imx_lpuart_putc(struct serial_port *port, char c) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +
> > +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
> > +        cpu_relax();
> > +
> > +    imx_lpuart_write(uart, UARTDATA, c); }
> > +
> > +static int imx_lpuart_getc(struct serial_port *port, char *pc) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    int ch;
> > +
> > +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
> > +	    return 0;
> > +
> > +    ch =3D imx_lpuart_read(uart, UARTDATA);
> > +    *pc =3D ch & 0xff;
> > +
> > +    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
> > +        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
> > +
> > +    return 1;
> > +}
> > +
> > +static int __init imx_lpuart_irq(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +
> > +    return ((uart->irq > 0) ? uart->irq : -1); }
> > +
> > +static const struct vuart_info *imx_lpuart_vuart_info(struct
> > +serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +
> > +    return &uart->vuart;
> > +}
> > +
> > +static void imx_lpuart_start_tx(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t temp;
> > +
> > +    temp =3D imx_lpuart_read(uart, UARTSTAT);
> > +    /* Wait until empty */
> > +    while ( !(temp & UARTSTAT_TDRE) )
> > +	    cpu_relax();
> > +
> > +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> > +    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE)); }
> > +
> > +static void imx_lpuart_stop_tx(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t temp;
> > +
> > +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> > +    temp &=3D ~(UARTCTRL_TIE | UARTCTRL_TCIE);
> > +    imx_lpuart_write(uart, UARTCTRL, temp); }
> > +
> > +static struct uart_driver __read_mostly imx_lpuart_driver =3D {
> > +    .init_preirq =3D imx_lpuart_init_preirq,
> > +    .init_postirq =3D imx_lpuart_init_postirq,
> > +    .endboot =3D NULL,
> > +    .suspend =3D imx_lpuart_suspend,
> > +    .resume =3D imx_lpuart_resume,
> > +    .tx_ready =3D imx_lpuart_tx_ready,
> > +    .putc =3D imx_lpuart_putc,
> > +    .getc =3D imx_lpuart_getc,
> > +    .irq =3D imx_lpuart_irq,
> > +    .start_tx =3D imx_lpuart_start_tx,
> > +    .stop_tx =3D imx_lpuart_stop_tx,
> > +    .vuart_info =3D imx_lpuart_vuart_info, };
> > +
> > +static int __init imx_lpuart_init(struct dt_device_node *dev,
> > +                                  const void *data) {
> > +    const char *config =3D data;
> > +    struct imx_lpuart *uart;
> > +    int res;
> > +    u64 addr, size;
> > +
> > +    if ( strcmp(config, "") )
> > +        printk("WARNING: UART configuration is not supported\n");
> > +
> > +    uart =3D &imx8_com;
> > +
> > +    uart->baud =3D 115200;
> > +    uart->data_bits =3D 8;
> > +    uart->parity =3D 0;
> > +    uart->stop_bits =3D 1;
> > +
> > +    res =3D dt_device_get_address(dev, 0, &addr, &size);
> > +    if ( res )
> > +    {
> > +        printk("imx8-lpuart: Unable to retrieve the base"
> > +               " address of the UART\n");
> > +        return res;
> > +    }
> > +
> > +    res =3D platform_get_irq(dev, 0);
> > +    if ( res < 0 )
> > +    {
> > +        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
> > +        return -EINVAL;
> > +    }
> > +    uart->irq =3D res;
> > +
> > +    uart->regs =3D ioremap_nocache(addr, size);
> > +    if ( !uart->regs )
> > +    {
> > +        printk("imx8-lpuart: Unable to map the UART memory\n");
> > +        return -ENOMEM;
> > +    }
> > +
> > +    uart->vuart.base_addr =3D addr;
> > +    uart->vuart.size =3D size;
> > +    uart->vuart.data_off =3D UARTDATA;
> > +    /* tmp from uboot */
> > +    uart->vuart.status_off =3D UARTSTAT;
> > +    uart->vuart.status =3D UARTSTAT_TDRE;
> > +
> > +    /* Register with generic serial driver */
> > +    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
> > +
> > +    dt_device_set_used_by(dev, DOMID_XEN);
> > +
> > +    return 0;
> > +}
> > +
> > +static const struct dt_device_match imx_lpuart_dt_compat[]
> > +__initconst =3D {
> > +    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
> > +    {},
> To be coherent with the rest of Xen code, please use { /* sentinel */ }

Fix in V3.

>=20
> > +};
> > +
> > +DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
> > +    .dt_match =3D imx_lpuart_dt_compat,
> > +    .init =3D imx_lpuart_init,
> > +DT_DEVICE_END
> Please add a newline here.

Fix in V3.

>=20
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > diff --git a/xen/include/xen/imx-lpuart.h
> > b/xen/include/xen/imx-lpuart.h new file mode 100644 index
> > 0000000000..945ab1c4fa
> > --- /dev/null
> > +++ b/xen/include/xen/imx-lpuart.h
> > @@ -0,0 +1,64 @@
> > +/*
> > + * xen/include/asm-arm/imx-lpuart.h
> Wrong path as you put this header in xen/include/xen.

As you suggested below, I need put this header under
xen/arch/arm/include/asm/

>=20
> > + *
> > + * Common constant definition between early printk and the LPUART
> > + driver
> > + *
> > + * Peng Fan <peng.fan@nxp.com>
> > + * Copyright 2022 NXP
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + modify
> > + * it under the terms of the GNU General Public License as published
> > + by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#ifndef __ASM_ARM_IMX_LPUART_H
> Wrong macro as you are not in arm/include/asm.
>=20
> > +#define __ASM_ARM_IMX_LPUART_H
> > +
> > +/* 32-bit register definition */
> > +#define UARTBAUD          (0x10)
> > +#define UARTSTAT          (0x14)
> > +#define UARTCTRL          (0x18)
> > +#define UARTDATA          (0x1C)
> > +#define UARTMATCH         (0x20)
> > +#define UARTMODIR         (0x24)
> > +#define UARTFIFO          (0x28)
> > +#define UARTWATER         (0x2c)
> > +
> > +#define UARTSTAT_TDRE     (1 << 23)
> > +#define UARTSTAT_TC       (1 << 22)
> > +#define UARTSTAT_RDRF     (1 << 21)
> > +#define UARTSTAT_OR       (1 << 19)
> > +
> > +#define UARTBAUD_OSR_SHIFT (24)
> > +#define UARTBAUD_OSR_MASK (0x1f)
> > +#define UARTBAUD_SBR_MASK (0x1fff)
> > +#define UARTBAUD_BOTHEDGE (0x00020000)
> > +#define UARTBAUD_TDMAE    (0x00800000)
> > +#define UARTBAUD_RDMAE    (0x00200000)
> > +
> > +#define UARTCTRL_TIE      (1 << 23)
> > +#define UARTCTRL_TCIE     (1 << 22)
> > +#define UARTCTRL_RIE      (1 << 21)
> > +#define UARTCTRL_ILIE     (1 << 20)
> > +#define UARTCTRL_TE       (1 << 19)
> > +#define UARTCTRL_RE       (1 << 18)
> > +#define UARTCTRL_M        (1 << 4)
> > +
> > +#define UARTWATER_RXCNT_OFF     24
> > +
> > +#endif /* __ASM_ARM_IMX_LPUART_H */
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
>=20
> I think you should put this header in xen/arch/arm/include/asm/ as it is =
arm
> related header.

Yes.

Thanks,
Peng.

>=20
> Cheers,
> Michal


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 07:54:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 07:54:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299675.510738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0UE-0006O8-LV; Wed, 06 Apr 2022 07:53:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299675.510738; Wed, 06 Apr 2022 07:53:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0UE-0006O1-Gv; Wed, 06 Apr 2022 07:53:54 +0000
Received: by outflank-mailman (input) for mailman id 299675;
 Wed, 06 Apr 2022 07:53:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bUIs=UQ=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nc0UD-0006Nu-I3
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 07:53:53 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id b26c940f-b57e-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 09:53:50 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 137D323A;
 Wed,  6 Apr 2022 00:53:51 -0700 (PDT)
Received: from [10.57.6.245] (unknown [10.57.6.245])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6443A3F718;
 Wed,  6 Apr 2022 00:53:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b26c940f-b57e-11ec-8fbc-03012f2f19d4
Message-ID: <44d035c4-f2ff-b726-ed67-5c09d472ccde@arm.com>
Date: Wed, 6 Apr 2022 09:53:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
Content-Language: en-US
To: Peng Fan <peng.fan@nxp.com>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "julien@xen.org" <julien@xen.org>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "bertrand.marquis@arm.com" <bertrand.marquis@arm.com>
Cc: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "van.freenix@gmail.com" <van.freenix@gmail.com>
References: <20220402054223.10304-1-peng.fan@oss.nxp.com>
 <20220402054223.10304-2-peng.fan@oss.nxp.com>
 <fd4b0cc7-3cb9-3f56-5db7-31d41b24611c@arm.com>
 <DU0PR04MB9417FBA3876918C0FD7F187188E79@DU0PR04MB9417.eurprd04.prod.outlook.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <DU0PR04MB9417FBA3876918C0FD7F187188E79@DU0PR04MB9417.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit



On 06.04.2022 09:39, Peng Fan wrote:
>> Subject: Re: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
>>
>> Hi Peng,
>>
>> On 02.04.2022 07:42, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> The i.MX LPUART Documentation:
>>>
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
>>>
>> nxp.com%2Fwebapp%2FDownload%3FcolCode%3DIMX8QMIEC&amp;data=0
>> 4%7C01%7Cp
>>>
>> eng.fan%40nxp.com%7Cc7d221ce800342bbd7c108da179e72ca%7C686ea1d
>> 3bc2b4c6
>>>
>> fa92cd99c5c301635%7C0%7C1%7C637848266543058498%7CUnknown%7C
>> TWFpbGZsb3d
>>>
>> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
>> 3D%7C
>>>
>> 3000&amp;sdata=3CV%2FoJViSFzqRby0h577SiusHRQnC8KiXscntQW%2BZOs
>> %3D&amp;
>>> reserved=0 Chatper 13.6 Low Power Universal Asynchronous Receiver/
>>> Transmitter (LPUART)
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>>  xen/drivers/char/Kconfig      |   8 +
>>>  xen/drivers/char/Makefile     |   1 +
>>>  xen/drivers/char/imx-lpuart.c | 275
>>> ++++++++++++++++++++++++++++++++++
>>>  xen/include/xen/imx-lpuart.h  |  64 ++++++++
>>>  4 files changed, 348 insertions(+)
>>>  create mode 100644 xen/drivers/char/imx-lpuart.c  create mode
>> 100644
>>> xen/include/xen/imx-lpuart.h
>>>
>>> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index
>>> 2ff5b288e2..0efdb2128f 100644
>>> --- a/xen/drivers/char/Kconfig
>>> +++ b/xen/drivers/char/Kconfig
>>> @@ -13,6 +13,14 @@ config HAS_CADENCE_UART
>>>  	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
>>>  	  based board, say Y.
>>>
>>> +config HAS_IMX_LPUART
>>> +	bool "i.MX LPUART driver"
>>> +	default y
>>> +	depends on ARM_64
>>> +	help
>>> +	  This selects the i.MX LPUART. If you have a i.MX8QM based board,
>>> +	  say Y.
>> Why did you move "say Y" to the next line?
> 
> I configured vimrc with " set cc=75,100 ", the "." will be at 80, so I
> move "say Y." to next line.
> 
It won't be at 80 but at 77 which is less than 80 (required by CODING_STYLE)
unless you found a requirement to split lines in Kconfig files at 75.

Cheers,


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:13:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:13:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299691.510749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0nG-000111-IC; Wed, 06 Apr 2022 08:13:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299691.510749; Wed, 06 Apr 2022 08:13:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0nG-00010u-Ep; Wed, 06 Apr 2022 08:13:34 +0000
Received: by outflank-mailman (input) for mailman id 299691;
 Wed, 06 Apr 2022 08:13:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dnga=UQ=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nc0nE-00010o-Rx
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:13:33 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0617.outbound.protection.outlook.com
 [2a01:111:f400:fe02::617])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 717da74a-b581-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 10:13:31 +0200 (CEST)
Received: from AM6P194CA0064.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::41)
 by DB7PR08MB3753.eurprd08.prod.outlook.com (2603:10a6:10:7e::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 08:13:24 +0000
Received: from VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:84:cafe::78) by AM6P194CA0064.outlook.office365.com
 (2603:10a6:209:84::41) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19 via Frontend
 Transport; Wed, 6 Apr 2022 08:13:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT032.mail.protection.outlook.com (10.152.18.121) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Wed, 6 Apr 2022 08:13:23 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Wed, 06 Apr 2022 08:13:23 +0000
Received: from 18f0d132bd5a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E259025B-B669-449A-BEF1-340DB0470B48.1; 
 Wed, 06 Apr 2022 08:13:13 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 18f0d132bd5a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Apr 2022 08:13:13 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB2997.eurprd08.prod.outlook.com (2603:10a6:209:49::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 08:13:08 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6%4]) with mapi id 15.20.5144.019; Wed, 6 Apr 2022
 08:13:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 717da74a-b581-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uPYwU8cH8r6gT8YpCHbvCmd5IJBCDFFpJlQDqyaGYJs=;
 b=Ef4qBAbbYfySl5+EnhTQdXzzjhiY/qcW6Y6fw1Ge/Wz39XsL8OGXrlDhYaqrlJI0+Sew9QDwOg2HcPSjpyvp14SYF5lelNp5mBCV+nygjZR8sR2FScnq882GofCl7G/fuXPSzMnlZ+un0wWcCMRvhcDBObTsuRPBPOpne6uHAfU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: d15e869c505921c8
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m9uStl15FnP9AEaQ2dvC065qxxkkSZLKAwyP+Cij1xXK6VQnF/hnXdbB0M39oTZACtIF12dAwEOpn8JhA1HBCj9VGJ/z1HYYy249YEj+1KH+y5h3j6HDUYjP+WFFcFgd3hz4iGodpGBzg27L3xIy2ro5/aWxqn2ybhiG9s5FGL4Ll9BkkgQo5qgG8Ytg4wKX/6l7Wgb+n//bDRjazHFyi0sQ+OlldsYwDcFo3diD4rYNhGJxpf1XhpLIE6031YNod5K5wA2RRxmk5E7b7p8pchtVwBsMArToCk+3t1dF4LUAnY4OWeTE1ko7mnIt2N54xAoQoTZRfzNw+x0oc7gsqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uPYwU8cH8r6gT8YpCHbvCmd5IJBCDFFpJlQDqyaGYJs=;
 b=RLr2JCBX1+4/1bZ7agdv9kQH/p00i47OvDctyWBZZp+WrC+rnWvfpmKxzN5IR4Wo296Qwo6hIT3n5S7okwdxrBUyfT+oSzuiyFI5Yve2UDx8BGGf3xsWNEu5EVYS5+BzwEPaduD02y3tSqJyMXYA/qnK6O8ZEgfJp+eEyeTNBrgP6+GUEaP6dAkwTyzX6KMBbiXc121B1FCgKvyd6uuQE0BnwC0TXnda+RYNLi1UMBYwSkRPRe3UjtUhvZ+yG6AVL1I3h5a4vDcev9nsEWyD9An5cWmZqn+I5Fg7NroWyerT4pOl4L8rEZhSotdj5cS+BSCdqoDWue/qg+9gsK0/3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uPYwU8cH8r6gT8YpCHbvCmd5IJBCDFFpJlQDqyaGYJs=;
 b=Ef4qBAbbYfySl5+EnhTQdXzzjhiY/qcW6Y6fw1Ge/Wz39XsL8OGXrlDhYaqrlJI0+Sew9QDwOg2HcPSjpyvp14SYF5lelNp5mBCV+nygjZR8sR2FScnq882GofCl7G/fuXPSzMnlZ+un0wWcCMRvhcDBObTsuRPBPOpne6uHAfU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Michal Orzel <Michal.Orzel@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC PATCH] xen/build: Add cppcheck and cppcheck-html make rules
Thread-Topic: [RFC PATCH] xen/build: Add cppcheck and cppcheck-html make rules
Thread-Index: AQHYP279DnP7J8Edsk+NG7Po4Qnn9azPUYQAgABlXgCAAM91gIASFxQA
Date: Wed, 6 Apr 2022 08:13:07 +0000
Message-ID: <E2B73FDA-55ED-40A3-B7CE-3362B8B21A78@arm.com>
References:
 <77c79e86050eef2b706ee11e64183d57a0f5bcee.1648119732.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2203241829510.2910984@ubuntu-linux-20-04-desktop>
 <98a6df25-8a95-3e3d-e8a9-11e948da7b5b@arm.com>
 <alpine.DEB.2.22.394.2203251257020.2910984@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2203251257020.2910984@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 89c3ebd8-bd27-40dd-efff-08da17a551d8
x-ms-traffictypediagnostic:
	AM6PR08MB2997:EE_|VE1EUR03FT032:EE_|DB7PR08MB3753:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3753DB97987A2A6C458AF6CA9DE79@DB7PR08MB3753.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 mew0qsplbe2bpy6XfL+zYBKkJ4u4GOiecWr0YPVOLQMXW8i5Jz9DjWck6IJSoqKEoOxdJVcMa2r9c82pRgWG8KUuaKiNjFE5zau5bnfpNEH3XEToElb+h2LRzbXHQBMz4XpYF/fkmDzruayyhL/ogZiCmGqbRuJJPaq7trZX1dDkVZj6OfF7MgzrnEJTj6rtIRYxB8FouFLvmyJ34igvb8uYI8fr7krKS5WFRuLcbsqS4GMbEXgueJYYRzN3gLH3SiGDuBSJTZ/TvuMyiRMpFO3ktDLvK977Zfv2zKCNi74n1Ls7+SloltuYaK06qWSpEdaM8mGBTToh1d//BOLwrQTeM/E33UaY8a5hMQ6FrdygBBfES2jveg56fU88tW7B1RElZ/amdqgKnxW/uWYxKsoaB7dEB/sQHNgZHpSBIclplrMrVW0KgBqYCHAPsLCZz2nzOKmggqCXvvZpk/kQsYEIr1m8qfpZygfSNxXsenMlHifIZxRpv19UyNnU7LUhS2H5UFOEEIXPoiMTJgesadnQcvc+32CiqWtFSBFv3VFUSUCvo2IrFFss5qyE/7RUC7umR/w27kUFjFcrTdgeIApeJ83UfAUQldEjfaXQG2qVZtHtEaWe1qZZNtYO83uv6VquKG3wE/vZQz0Hs04oXIkTolRePu1FrWJwazxWbLTiJ8K9rRlGxRy2AQD3Dbvk9iY11MGXQsJ64O9kDbJ6mwj+DY6p7dCa2Q3dcHfsL0Sehsr01Jm4iStNk6ybCyu6DI7kDWGhy+JbeXfehjY+XSuwuiIlrq+LKih4k8yRzRSxdlfau/JA1juliPchzdOlWAdFt5gBVdVtdlJyCJrvqqyTXbIU8KqDGOUMHm8M0n8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(91956017)(6506007)(26005)(2616005)(186003)(53546011)(54906003)(316002)(83380400001)(6486002)(66574015)(966005)(76116006)(66946007)(6916009)(33656002)(66476007)(64756008)(4326008)(508600001)(38070700005)(36756003)(8676002)(5660300002)(6512007)(66556008)(38100700002)(66446008)(2906002)(8936002)(86362001)(122000001)(21314003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0667C1CF2D7DDC4FB7FFD4AB7A3529F0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2997
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5d212618-9eac-402c-d287-08da17a54875
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EjozkMvqyLEoLVOER8gVLKjEz4cBqnO8bdky6vUekBD5715DReez8Y7hSFMdZtT0qRB6EByvk+KmHW+iiGd8OrBT0MAfoBFGc3tdOjiauz0uv5W2j5n59sEHGpfCyQ/0eTRUW5XVBHQ3xWWL5E7y9nQU6iPjkxaUAkFR3brutdemLuQny5YaJmG3FoRY+sBU75nmUwaYJFyhMi9SgpnsbQnw9cWFx1SGsWq6eWIRgNoD3mhjWngo+ICYlU5G11AC6Ym9cORnRRSaEYz8GNlQTLR0p7yUCLf4KNJn8HEKg2P2ZQBCdMEY4lRYWIV9ykUWnkYwAP6Rzp8BpqK2nP9GWXhGBqGC0SmbWRKjQMiwufXLu1X6nZQo5wNvJeHyxMue9F8iyp8V56hGzpGCN2kDd35BwZ6r8NUFhb/SpdEQlOQb0HUAhVjzGq8W5RzJZLxgh6uuzD4c+bY1mMnbDZ+p4W7wDA97wr+JCJkNR2NXT/XSsZ64pZAFesdogTpsi4JcL7XHkXAbDMxrezEtt3dCaoob9jWUQFTI6SMZp/1s9AK7j2milOwZVo8VFUTneDKq6v9SJ3Bjxi5XYwMJ9KJs4pGHod1u6eLAopf7uH10cAfxOqhVtCW0JuYbOdoUNP/a68v3iPeJmdE9ZnYr/cwfz/cIBBWiJCIthOp+iL9winxIzzNHJwBGI/BCqkScfVvMHqdpMaAofDNfr/qG1QsjPUj5hWuZbrD9EgeUHenpIGyp/adKcCmxQ25UjWrFC8PsD9Vur9kpQFnZAkwkubDZ6xQWmz2n4lxfx/VzymjAzSE=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6512007)(81166007)(47076005)(6506007)(508600001)(33656002)(336012)(6862004)(8936002)(53546011)(8676002)(70586007)(70206006)(66574015)(4326008)(356005)(40460700003)(83380400001)(2906002)(82310400005)(86362001)(5660300002)(186003)(107886003)(316002)(966005)(2616005)(26005)(6486002)(36756003)(54906003)(36860700001)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 08:13:23.4998
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 89c3ebd8-bd27-40dd-efff-08da17a551d8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3753

Hi Stefano,

> On 25 Mar 2022, at 19:57, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Fri, 25 Mar 2022, Michal Orzel wrote:
>> On 25.03.2022 02:32, Stefano Stabellini wrote:
>>> On Thu, 24 Mar 2022, Bertrand Marquis wrote:
>>>> cppcheck can be used to check Xen code quality.
>>>>=20
>>>> To create a report do "make cppcheck" on a built tree adding any optio=
ns
>>>> you added during the process you used to build xen (like CROSS_COMPILE
>>>> or XEN_TARGET_ARCH). This will generate an xml report xen-cppcheck.xml=
.
>>>>=20
>>>> To create a html report do "make cppcheck-html" in the same way and a
>>>> full report to be seen in a browser will be generated in
>>>> cppcheck-htmlreport/index.html.
>>>>=20
>>>> For better results it is recommended to build your own cppcheck from t=
he
>>>> latest sources that you can find at [1].
>>>> Development and result analysis has been done with cppcheck 2.7.
>>>>=20
>>>> The Makefile rule is searching for all C files which have been compile=
d
>>>> (ie which have a generated .o file) and is running cppcheck on all of
>>>> them using the current configuration of xen so only the code actually
>>>> compiled is checked.
>>>>=20
>>>> A new tool is introduced to merge all cppcheck reports into one global
>>>> report including all findings and removing duplicates.
>>>>=20
>>>> Some extra variables can be used to customize the report:
>>>> - CPPCHECK can be used to give the full path to the cppcheck binary to
>>>> use (default is to use the one from the standard path).
>>>> - CPPCHECK_HTMLREPORT can be used to give the full path to
>>>> cppcheck-htmlreport (default is to use the one from the standard path)=
.
>>>>=20
>>>> This has been tested on several arm configurations (x86 should work bu=
t
>>>> has not been tested).
>>>>=20
>>>> [1] https://cppcheck.sourceforge.io/
>>>>=20
>>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>>=20
>>> Very cool, I was looking forward to this :-)
>>>=20
>>>=20
>>>> diff --git a/xen/tools/merge_cppcheck_reports.py b/xen/tools/merge_cpp=
check_reports.py
>>>> new file mode 100755
>>>> index 0000000000..ef055f6925
>>>> --- /dev/null
>>>> +++ b/xen/tools/merge_cppcheck_reports.py
>>>> @@ -0,0 +1,73 @@
>>>> +#!/usr/bin/env python
>>>> +
>>>> +"""
>>>> +This script acts as a tool to merge XML files created by cppcheck.
>>>> +Usage:
>>>> +    merge_cppcheck_reports.py [FILES] [OUTPUT]
>>>> +
>>>> +    FILES  - list of XML files with extension .cppcheck
>>>> +    OUTPUT - file to store results (with .xml extension).
>>>> +             If not specified, the script will print results to stdou=
t.
>>>> +"""
>>>> +
>>>> +import sys
>>>> +from xml.etree import ElementTree
>>>> +
>>>> +def elements_equal(el1, el2):
>>>> +    if type(el1) !=3D type(el2): return False
>>>> +
>>>> +    el1_location =3D str(el1.find('location').attrib)
>>>> +    el2_location =3D str(el2.find('location').attrib)
>>>> +
>>>> +    if el1_location !=3D el2_location: return False
>>>> +
>>>> +    return True
>>>> +
>>>> +def remove_duplicates(xml_root_element):
>>>> +    elems_to_remove =3D []
>>>> +    index =3D 0
>>>> +    elems_list =3D list(xml_root_element.findall("errors")[0])
>>>> +    for elem1 in elems_list:
>>>> +        index +=3D 1
>>>> +        for elem2 in elems_list[index:]:
>>>> +            if elements_equal(elem1, elem2) and elem2 not in elems_to=
_remove:
>>>> +                elems_to_remove.append(elem2)
>>>> +                continue
>>>> +
>>>> +    for elem in elems_to_remove:
>>>> +        xml_root_element.findall("errors")[0].remove(elem)
>>>> +
>>>> +def merge(files):
>>>> +    result_xml_root =3D None
>>>> +    for xml_file in files:
>>>> +        xml_root =3D ElementTree.parse(xml_file).getroot()
>>>=20
>>>=20
>>> Traceback (most recent call last):
>>>  File "/local/repos/xen-upstream/xen/tools/merge_cppcheck_reports.py", =
line 73, in <module>
>>>    run()
>>>  File "/local/repos/xen-upstream/xen/tools/merge_cppcheck_reports.py", =
line 60, in run
>>>    result =3D merge(files)
>>>  File "/local/repos/xen-upstream/xen/tools/merge_cppcheck_reports.py", =
line 43, in merge
>>>    xml_root =3D ElementTree.parse(xml_file).getroot()
>>>  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1182, in pars=
e
>>>    tree.parse(source, parser)
>>>  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 657, in parse
>>>    self._root =3D parser.close()
>>>  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1671, in clos=
e
>>>    self._raiseerror(v)
>>>  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1523, in _rai=
seerror
>>>    raise err
>>> xml.etree.ElementTree.ParseError: no element found: line 11, column 0
>>> make: *** [Makefile:576: xen-cppcheck.xml] Error 1
>>>=20
>>> I think we should catch the xml.etree.ElementTree.ParseError exception =
and continue?
>>=20
>> Well, this is of course something that we might do but this error clearl=
y warns us that
>> some XML files is not well formatted and therefore is not parsable. This=
 could mean that
>> you are using some old cppcheck version. Is it correct assumption?
>=20
> I confirm it was an issue with the cppcheck version. I updated to the
> latest main branch and it worked fine, thanks!
>=20
> Then, I suggest we catch the exception and print an informative error
> like "please upgrade your cppcheck to version xxx or greater"

I will investigate that before pushing the next version.

Cheers
Bertrand



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299693.510760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0nb-0001QZ-1s; Wed, 06 Apr 2022 08:13:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299693.510760; Wed, 06 Apr 2022 08:13:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0na-0001QS-Tt; Wed, 06 Apr 2022 08:13:54 +0000
Received: by outflank-mailman (input) for mailman id 299693;
 Wed, 06 Apr 2022 08:13:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc0nZ-0001OM-OO
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:13:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7de66eaf-b581-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 10:13:51 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-maN39rXVMdOxdrWlHTsDEw-1; Wed, 06 Apr 2022 10:13:47 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4422.eurprd04.prod.outlook.com (2603:10a6:20b:24::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 08:13:43 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 08:13:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7de66eaf-b581-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649232831;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KAhFm75o+2XeZcJJ8JHN79AVdCTWjfnwFRiW3z7xoYg=;
	b=DLYZXCI7VkBUKb1jcWA0wyVumaUDPaL2JB9nT/AlWbLJt14XbJ5u4A50kjgzi/2XuRlE0N
	ngsBkz4pe8dt50/aMzcHt9vMuGsUuM+6rsyEi7Zv3G587tSpRyGqSjUX7RH/HfzqBhN/ni
	zaGbZP11pN1A9EgTqbeeqTRkLP0xWmo=
X-MC-Unique: maN39rXVMdOxdrWlHTsDEw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZpIUyCqQvl3pM+4XfgPRrtnLGP5gl7NxoDVqEc8qWM2FKEPzH8YxdhIt2m+4hVBSZqiU80N1Atfi9WMiqN6LLEVSoJm7OJxII/q8QzJOq0YKjlZR5cuxv/06alSOCYpncX3bc2Ums1wEOIYm29ndCI6GCwePQXMJAnBDxURjIkvgMUlX1ZZyjj6XGBf+1G/LRy3gbYT1lRXjD4/Db9XZimJtuarWWIYnfjni/Mt55OVfCAmmZY/GbMu6hlGCRkgR8hXSsD6pKFYlK/Qs2jrZ41l4OtZlKNaCACtuXY/IRdmpQuyJO+xGO1xsKHcaHY2EpeJLfrzgpOmmS6tDZOWZtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kHFRo10nxxd34oAFCmJsIBFTSpieO2iP9Czga7oiTmo=;
 b=StI6Q9ZxxgzvR4N/6seGAO2RdBgz1Ap8gAxsvbMlT2hGfhu5OUZUGP4ytTKju185K4Zc4CUBgRu9JWuc6vidh1ryLtIIWowkcWwtMtQTVzQofBT357NAP1PIWMntxM7gd4fJ1hOR1YdDnxE76WxjwRG5hOtsOVLa5rTpR5t6U5kMjgTk11DiifYdu5bnR7ckIWr1pXO20F92XgcNyFeaEZyCJ8BKQOtBVKWGGiIjCuMXRFXDDtDd0vEfrYmkkB3cfnQ3gL3JXMkdzVFDCS5SGwcJKm1thIbvc/xRWz17dse+9lTWpmjbpx9QxmnvF4Vix4JbiMO4LyCu/5fozKAqrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6a029529-fcbe-3923-26a6-58a58926762f@suse.com>
Date: Wed, 6 Apr 2022 10:13:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: Questions about Cx and Px state uploading from dom0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <YjrgQOYbsaYOV08H@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YjrgQOYbsaYOV08H@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0059.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::34) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8ecb373c-c4c4-46cb-b4d9-08da17a55d59
X-MS-TrafficTypeDiagnostic: AM6PR04MB4422:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB442227BBEBC885DE0B115939B3E79@AM6PR04MB4422.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HRnB1HnBqrHo+dmCt7d5MxOfDlCueC7kqGuzO7RiSS9PojP7QfFkY3qv3PTxGrgWtXTfDkO6gvUwtCW71aly2kN/Qc8y7U3UMJf5o2BO+ZErEA9HLbAq78gByCFJsNiHev3nZLVgFsdVnZ4NivZ8briOHef4M3o0UhS6cfOgRsJQt03jT0q9Jrwln2MQ3uZdZVXni/jXgABzGB113PkP+EuJZLgDT10cYZo+JsPv9H5IvCjaagfFX1+t3SOuH+bhjujy0qe/t/iue1zayX0iKjf3GgeWRNOcZzOmVGb6UND+wHpUTm2f97iysIYVhWDT5Kx5vrbwg58U2wyzkVzA26GlQPtyvpBn9IMS5yXM/pU3cX+z0bZHvttyeRogP2nP+a+rEabbrqt/ffOCaRqSvMoiPuynj02ZiBB/xnID6zGHJIpJZ0eKFuXWnf0Wy+TPFD7fQkOI8270xNExeE6BvlRdUPSlW6QURlwNMyofP3E04N2w4DnxW8sfs48FchPxPpCYHU6whLeN+UsY53WbUfzp2naI4HuHAvn3m9OhYuOLtJdJoVOHJ+jtG3c7dDcoU63P04uNgeGtV8c35hqYNJ91tPs5K+uzNYM8gHpz3PQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(8936002)(6486002)(31686004)(36756003)(31696002)(2906002)(508600001)(38100700002)(66946007)(83380400001)(4326008)(186003)(26005)(6506007)(66556008)(8676002)(6512007)(54906003)(6916009)(316002)(66476007)(53546011)(2616005)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?v9bghd4tt81oZieN8DsF5n2fyfckj8r//KA2vxCE9b4F6H/5O78oRrzpkLje?=
 =?us-ascii?Q?NvmiO7JTryYPf/XKmsCMLGMeAEO3BnGvwtPhqkbB1HCBJYSChzFTpCoYG8+f?=
 =?us-ascii?Q?HpouGC7JmS8QSnolaX7BrqKiGYec4FY9aBFjO0+m2bQhy1hTwbllWI7SaN7S?=
 =?us-ascii?Q?ifWdzxYUA17wEAMObSPk+wowm4VveD56Iknj4hLIE+iSSGqQWBxuQxde/B0r?=
 =?us-ascii?Q?HYx422AIHLMVcfygxpA27mqbmDxOVXpHo+uKfmMBHPvPQbKkZwnqaPD4BKpA?=
 =?us-ascii?Q?CI50u/tM8m6P5K08drv6IkhnM9vlwBjqggwYASbnR8TY7kZsRXR1uZupof6D?=
 =?us-ascii?Q?5omsvVf4cNrD2zrQP4P4Zt68n4WObucrs3miOmioMqK+2wJw5Q/KmJVeKsOj?=
 =?us-ascii?Q?72BpC3S9tSliooRuGN+zJVyG28uIRI820jjB1pPHnkwHEkDh/AV8pzDAx/mo?=
 =?us-ascii?Q?oenMZHsM1HN5SsYaPe/p08xmhz3ftn5h4dUFsYlAKCt2T2YXZQR5wTpIOqHj?=
 =?us-ascii?Q?yFsugnAUZVAKsuUgTYj6TeIUj7p+5+hQzS4B/BbNQUqSoN7c0/+H/u+j3AxQ?=
 =?us-ascii?Q?WbCEwmz4ACpt9UIyEmb0Bfarup1ZhnzxE73sRnZJ9C3meMvFYdMPnEnAAojt?=
 =?us-ascii?Q?S3Bhn+yXRwN2rfSxDqu1f+eeqzq300nNkUZWNdQRsymtgQi+Ks7lVfDeRpif?=
 =?us-ascii?Q?owimzrXeuDbjhevz0V2Fjrpb8etGQoLwjevw/g0hooREuAM4ySWOw5dF19J0?=
 =?us-ascii?Q?hpund+zib1EYcwTWQ2rgg2SvLZ9AAKocy9GJi2A7WY+9lkMCwaKC0kGZpL7m?=
 =?us-ascii?Q?oJtT7DiWp2ext4H8bPe3ZHEBi9LRHrg2cA9wOzJYibAvhIK/N95GxTWQmy4A?=
 =?us-ascii?Q?zUyWts79//4VVjRlad5frpME5+3pJwqBtSG1LhxDnQ5v01HXDcR0dpnBcYB0?=
 =?us-ascii?Q?DLWCaII/IQ4/YhBAAbEG7nV91TSIO+8pt8/BY8+3aFyppzL+fgYYZHBYFhxK?=
 =?us-ascii?Q?8Nh9z6g4z3AoxGKLSM0pLZcU3Lm+aa/lNx1T6GK7P/CzgLGKW+XH0iP3AaAz?=
 =?us-ascii?Q?il68oUWjxTvtXUWoD0mmDPWPoIfmTPPYQ32+++xznF7mmjt6VTVOGomPEtnk?=
 =?us-ascii?Q?2NhMJ3rc4Wcvd+bHxPq/eFPb02GFF4cLgLtg7ByckaTWYUchjoCFzsPARNPA?=
 =?us-ascii?Q?7LMueEN6iZgrakL2fG9n4KS+Nf195YeyFOqaNewLdzffMljQfl5EKY3KIuUR?=
 =?us-ascii?Q?GegdHGUTna2sWYnjKvyiaV+BI42GoQhiPiSJF0lXaSmS5JYujmuY3ApIbLTS?=
 =?us-ascii?Q?sskknOE6buH9UuFsDlkRZeeb/a/E/UZUAKzB6MhdNG5a8qkc2ooqVAKJ83k0?=
 =?us-ascii?Q?lXxjTutmhf/oEmhmqs+3img/FSl8/6zj2hed267i3tOCuSP38EciY409SRgr?=
 =?us-ascii?Q?usyh7WLuMznQCzzOVMJWal7HkK/nxNSnwENTz1ghYg/8I2urclJNpJA9VYGd?=
 =?us-ascii?Q?xC4SH08Gx44Dqq4gQPPktKHIlPP905j2RYAJurrjOiTeRZYQ/secTYUo7obr?=
 =?us-ascii?Q?20MnK0imtoim1CS7b4hSmppWiE6s/FAJHQmA0Nwuo/1B/EOEhDcSwS/CgVBI?=
 =?us-ascii?Q?ahTZ0GPeO2U8i4rwOMaMIDpdJn4nlLLG29wYghZtXS8HVzaS9Fe0WLPZYYBn?=
 =?us-ascii?Q?l7ltbEqnD37rmWfR3OHoVRgI0PAenH8HABh2rRx5ZTm/hcvV9isJchK17hzL?=
 =?us-ascii?Q?/05bnzhVTg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ecb373c-c4c4-46cb-b4d9-08da17a55d59
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 08:13:43.0799
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TnAdCQM2vLkdoV5KP9LCjD8UBMK6rXOjvmDepdMl68onM9XyAqVt8zd30EWq/fC6Cl+E9KZshWVNnMA2fyH9QA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4422

On 23.03.2022 09:54, Roger Pau Monn=C3=A9 wrote:
> Hello,
>=20
> I was looking at implementing ACPI Cx and Px state uploading from
> FreeBSD dom0, as my main test box is considerably slower without Xen
> knowing about the Px states.  That has raised a couple of questions.
>=20
> 1. How to figure out what features to report available by OSPM when
> calling the _PDC (or _OSC) ACPI method.  I'm confused by the usage of
> this from Linux: it seems to be used to detect mwait support in
> xen_check_mwait but not when calling _PDC (ie: in
> acpi_processor_set_pdc).  I'm also not sure what the hypercall expects
> the caller to provide.  Should buf[2] be set to all the possible
> features supported by the OS and Xen will trim those as required?

I'm afraid upstream Linux doesn't quite use this as originally
intended. Consulting my most recent (but meanwhile quite old) forward
port tree of XenoLinux that I still have readily available, I find in
drivers/acpi/processor_pdc.c:

static acpi_status
acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in=
)
{
	acpi_status status =3D AE_OK;

#ifndef CONFIG_XEN
	if (boot_option_idle_override =3D=3D IDLE_NOMWAIT) {
		/*
		 * If mwait is disabled for CPU C-states, the C2C3_FFH access
		 * mode will be disabled in the parameter of _PDC object.
		 * Of course C1_FFH access mode will also be disabled.
		 */
#else
	{
		struct xen_platform_op op;
#endif
		union acpi_object *obj;
		u32 *buffer =3D NULL;

		obj =3D pdc_in->pointer;
		buffer =3D (u32 *)(obj->buffer.pointer);
#ifndef CONFIG_XEN
		buffer[2] &=3D ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
#else
		op.cmd =3D XENPF_set_processor_pminfo;
		op.u.set_pminfo.id =3D -1;
		op.u.set_pminfo.type =3D XEN_PM_PDC;
		set_xen_guest_handle(op.u.set_pminfo.u.pdc, buffer);
		VOID(HYPERVISOR_platform_op(&op));
#endif
	}
	status =3D acpi_evaluate_object(handle, "_PDC", pdc_in, NULL);

	if (ACPI_FAILURE(status))
		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
		    "Could not evaluate _PDC, using legacy perf. control.\n"));

	return status;
}

(This is a 4.4-based tree, for reference.)

IOW the buffer is passed to Xen for massaging before invoking _PDC.

> 2. When uploading Px states, what's the meaning of the shared_type
> field in xen_processor_performance?  I've looked at the usage of the
> field by Xen, and first of all it seems to be a layering violation
> because the values set in the field (CPUFREQ_SHARED_TYPE_*) are not
> exposed as part of the public interface.  This all works for Linux
> because the same values are used by Xen and the Linux kernel.

Well, yes - that's the way code was written back at the time when
cpufreq support was introduced. It should rather have been
DOMAIN_COORD_TYPE_* to be used in the interface, which Linux
translates to CPUFREQ_SHARED_TYPE_*.

> Secondly, this is not part of the data fetched from ACPI AFAICT, so
> I'm unsure how the value should be calculated.  I also wonder whether
> this couldn't be done by Xen itself from the uploaded Px data (but
> without knowing exactly how the value should be calculated it's hard
> to tell).

As per above - while it's not fetched from ACPI directly, there
looks to be a direct translation from what ACPI provides (see
acpi_processor_preregister_performance()).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:25:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:25:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299706.510795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0yC-0003TK-9L; Wed, 06 Apr 2022 08:24:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299706.510795; Wed, 06 Apr 2022 08:24:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc0yC-0003TD-6B; Wed, 06 Apr 2022 08:24:52 +0000
Received: by outflank-mailman (input) for mailman id 299706;
 Wed, 06 Apr 2022 08:24:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nc0yB-0003T7-RN
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:24:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc0yA-0007rg-PP; Wed, 06 Apr 2022 08:24:50 +0000
Received: from [54.239.6.190] (helo=[192.168.16.200])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc0yA-00088y-JE; Wed, 06 Apr 2022 08:24:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=iDwHrl3G4uo/L2wdiMF0moB8OtYhdjYTRGlg7QX8MEU=; b=lWDXnR+i/9i19dmHgI6a8Xiqw7
	y1MZk514nrClHSO7VjHgAK8GayiLsc0bIZWMJCu063r9bWuACOsq9wldH+4d4kG/2289ZiWt2n+W9
	x2VEI7OgFdcnmJkPXwq3DiMGAxCfTFtvTLI3FCVoBvMd7gg/8qwgnWg7DUlE/oe580T4=;
Message-ID: <e16b4652-a740-3d2e-5e54-0c2d3250e9f7@xen.org>
Date: Wed, 6 Apr 2022 09:24:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v3 13/19] xen/arm: Move fixmap definitions in a separate
 header
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-14-julien@xen.org>
 <alpine.DEB.2.22.394.2204051411510.2910984@ubuntu-linux-20-04-desktop>
 <ddfdefed-21e6-06ee-182b-731fd130794a@xen.org>
 <alpine.DEB.2.22.394.2204051705010.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204051705010.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 06/04/2022 01:10, Stefano Stabellini wrote:
> On Tue, 5 Apr 2022, Julien Grall wrote:
>> On 05/04/2022 22:12, Stefano Stabellini wrote:
>>>> +/* Map a page in a fixmap entry */
>>>> +extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
>>>> +/* Remove a mapping from a fixmap entry */
>>>> +extern void clear_fixmap(unsigned map);
>>>> +
>>>> +#endif /* __ASSEMBLY__ */
>>>> +
>>>> +#endif /* __ASM_FIXMAP_H */
>>>
>>>
>>> It is a good idea to create fixmap.h, but I think it should be acpi.h to
>>> include fixmap.h, not the other way around.
>>
>> As I wrote in the commit message, one definition in fixmap.h rely on define
>> from acpi.h (i.e NUM_FIXMAP_ACPI_PAGES). So if we don't include it, then user
>> of FIXMAP_PMAP_BEGIN (see next patch) will requires to include acpi.h in order
>> to build.
>>
>> Re-ordering the values would not help because the problem would exactly be the
>> same but this time the acpi users would have to include pmap.h to define
>> NUM_FIX_PMAP.
>>
>>>
>>> The appended changes build correctly on top of this patch.
>>
>> That's expected because all the users of FIXMAP_ACPI_END will be including
>> acpi.h. But after the next patch, we would need pmap.c to include acpi.h.
>>
>> I don't think this would be right (and quite likely you would ask why
>> this is done). Hence this approach.
> 
> 
> I premise that I see your point and I don't feel very strongly either
> way. In my opinion the fixmap is the low level "library" that others
> make use of, so it should be acpi.h and pmap.h (the clients of the
> library) that include fixmap.h and not the other way around.

That's one way to see it. The way I see it is each component decide how 
much entries they need. So I think it is better to move the definition 
to each components as they are best suited to decide the value.

> However, I won't insist if you don't like it. Rough
> patch below for reference.

I want to stay close to what x86 is doing to avoid any headers mess. 
This is what my patch is doing. Now, if x86 folks are happy to move the 
definition per-arch or in a xen/fixmap.h. Then I can look at it.

Andrew, Jan, Roger, Wei, what do you think?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:44:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:44:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299717.510829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1HN-0006GK-4o; Wed, 06 Apr 2022 08:44:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299717.510829; Wed, 06 Apr 2022 08:44:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1HN-0006GD-1n; Wed, 06 Apr 2022 08:44:41 +0000
Received: by outflank-mailman (input) for mailman id 299717;
 Wed, 06 Apr 2022 08:44:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc1HM-0006G7-0M
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:44:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf91211e-b585-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 10:44:38 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-eD1DKtLiPzaQGRbNPmqt2w-1; Wed, 06 Apr 2022 10:44:16 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB5505.eurprd04.prod.outlook.com (2603:10a6:208:111::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Wed, 6 Apr
 2022 08:44:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 08:44:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf91211e-b585-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649234659;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Dxfr3LMtYTRwl09k+dhYZQ5kG6EZwAPE+Hmdov+RE3g=;
	b=Vo5sXI0mSvehxoqGogcXQ1q5QVWGhYDpv1jrcHBxe7Ya+BUadNzkeru2wRs4wCi7f7aTT4
	jqokVfMYIQ6cRTZ1NtU4K4s9RdkdFBrxwRAufYMYNkr6ojsV7YpLfA6hL+fY4SQx2M+7AV
	WQthzxG/BCkMPw0wHHDASn5NQeq7VQ0=
X-MC-Unique: eD1DKtLiPzaQGRbNPmqt2w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aGrbqwBsrYPiFymcV+vGyT64RsrfPfpS2xC4q65CuTi0F0jFcWi7ayoV8PjQXSoxU7z/TzC9HIrx+wS8pA8i6qkCPSPpd1tGMy4xWcwx+mNCCwmwgz+J9f1UDxqvKo8g/lN3zV6MV1kL740LHbMSefFfjTeGRWe38c8lxILA5Avjy3Tzdp9JLNMSLGPT/kWGv+chkheFNnc1dUH1nIRDlbn5oK0/YHadylPSZ/4TY1SLnQ4PBRe9cPJ7XxTRgxDl+12jIleOZIMqrADpHu/db1YFv38Mgo3EXY2rER/6ft3ICc5VL5LU+9ewYysZn4ZMg0FVAU8e2Gm/GTypUnvQag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xWmlH7K5oMVHAVbbonVfpBJtic6qwjgRbrZCHQB0ptY=;
 b=dqbrSHrSHCezkqImfS5KXTAEYikQP9PBHzi80gdJyglDUy+yJD4dc4/X26/Ke4qhUhYFBV99vVm5AJzALwRhVqx2FWOSRtzCtvSHmI/MEYy0NZCuPMQLF1jJPOIxzUg80UfhP5t8qhWQT4nhl4maHQa92REB72zWm6uQc7pHSDqgy4QwOwwOa/6waDlro7+alocXzBQ61WMI8vPGlApQR0F4LTpvVE/N8bwg5zNSv/tI2SV6V1594IdW6kMTNdkZnRumJKv6QApqjxwOxtzGMbpSF/Cf5cAqJ2PdWPjY30qqpq4bY30foFHrGG+0Pv3XlSIv6fgpta++aa6wRvLMng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <17163e1a-6598-5949-47cc-eb9734bc69ac@suse.com>
Date: Wed, 6 Apr 2022 10:44:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
 <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
 <39640fec-de8d-0c5a-c9aa-daf83fb785b0@suse.com>
 <YkxkfbNpR7yfLP7W@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YkxkfbNpR7yfLP7W@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0049.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::34) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 366eefcd-eb83-41d3-ecbb-08da17a9a141
X-MS-TrafficTypeDiagnostic: AM0PR04MB5505:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5505ED2763361794F1F19572B3E79@AM0PR04MB5505.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AmrNXb/QXmijfsW+NyGMfIDreOKV6tWLJjetkIBInzOtAS5HFZKstp8f60XnKwTIKnhcLSGWHpqQ/9hO2oIY+ItuNohMDRoJkppQjlrGWW75NeZT5hDXy8SC/mRqC8kYAMHJKCMlPJ/CQQVDTikTNQgxLDVrwKTuWAwXdNQKCDLEW9+RWckvT18x7fS6KZjAvX/+sueA4NKAZ8kycUpcbEPYIcmYxwlDvakOYxaHANxBYNRwgrPh11Md0Hpj/y7Lynvv1v5/wAnp3zHTt+X7s6lX1spg0PjRDgu+eahFqsXo+heRmMtX0tUEj1kKHv8W4qJYx8gEOyIZcBGPvJSvdF4ITPnZYoILgjjXjmLp6ss7VZjXjwzPmil8zvqOqRAt4v7lYcFpHHD5zw9uytMwqswyTZWetH6wcNREyZSyk2iklySumF8d2Jdxlr59f50DRxqps09NW9q5O985JSMrGw4kTs/lWm6FfNKagSgkvCPp9YOakhAizoorgdMt3hL4yHf/TVeAjQEtOcgT0A4lA1IRcYnfL+tM97D40c1QslNvNTH45Ti/vQ4FRWnkNccDAvTezxOODqmh7No65WW7nzAOjSQ+8CaZj3cCHn2RkmW72W6S10OdyRCV52e8RSWWqKFWDh4BwJP4lp0sxeEavF49RWcsv99W61m6diJbH4K2G1gJNsib5Rloj6XNne4yLagSf6K/yOjcYtQHCXY6RCgRvNfeWWr3F9xF/xbYbEs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(6512007)(6666004)(2616005)(186003)(26005)(4326008)(8936002)(83380400001)(36756003)(38100700002)(8676002)(5660300002)(31696002)(2906002)(31686004)(6916009)(316002)(508600001)(54906003)(6486002)(86362001)(66476007)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?40CtyKLSvCIhMDTB6XyEMf6rjLOZONWrTXQCpGGBuKCXd6K+3QiAQb+DBIBS?=
 =?us-ascii?Q?blrJrYofbPWdkDdt67zbhyjApvGCxAORiasSD2tfOQHpnfZ8kNXYbcibdinJ?=
 =?us-ascii?Q?ZjlqTR8UNsoOuPJv3quvuyKBg7xo1dELPHw0i1WW2fh/NjBopg1ggB2zrf9j?=
 =?us-ascii?Q?ZnZ8KpyOqfP/G3qlelhH5sYH4tIAtMWxPisGu+lf6FkL0gRkO27WLbYv3Cbc?=
 =?us-ascii?Q?Ph4qeGJFlTZb0Lj3nM5Hpbk8SlMUiis6ARiX4wT0lNWJy/QHaM202EcXsdd8?=
 =?us-ascii?Q?tBFTwsQtfET3tUbg6Y8hERDQA0BegrYuNnD9fmXiX2UbG6iZbIhrkK2ptDat?=
 =?us-ascii?Q?lH63+3tdxR3v/87MoK1XYxAsFimCwAG12wfuOW7Pz08qnJ5k5Eot1yGbfc3h?=
 =?us-ascii?Q?4tbVIyOdNnexvEHKZjKtrcosiTy5AtWBVvHhPxQzVBUXXPKDZpJLEcNld+UT?=
 =?us-ascii?Q?ebcwahMV3RgK8uvaGwwAd0jjDVgSnKhSHPwCzaIO4RlgpF7/TwcthCaNKH4L?=
 =?us-ascii?Q?8az4tmKbm0zrDdlt6ZkUBUVx6sOEegcAw6MjkDBlrHUIB5+61ttUg/38Rxiv?=
 =?us-ascii?Q?H0ceJ/X+AbdcKJ/0UXUc37vyHh6S0Ii2tQQ88zj3wwg/fHiZ3oA9i+1J5rII?=
 =?us-ascii?Q?iTlBvMz3s/jDLD20XuLaKgI0IADOpRgL28E7f+GkBTiOb6mzY0Vfh/fKjDnB?=
 =?us-ascii?Q?UxjSWqgql8hk7rBLvQhpopFSCYSySPOambUipnH7eucUHmNGEbfVL/iQR3dy?=
 =?us-ascii?Q?u/vOjEN9LSnAXDQf08b0eV4tCC88/y5+fbMESleaJkSC5uzLasrdbZUlT54+?=
 =?us-ascii?Q?ezkpeefXlcSc7OWZtBjnsJUnsjkoxR7i5Ea0kn6juCFiitXLND8jvtvNYPbs?=
 =?us-ascii?Q?LpKAEdnj2ZtW/lRk8D3p5wdnmrlsly5QMla9/DtQrDapKd7lFxTwkVPDIEdV?=
 =?us-ascii?Q?EJGZrxR7NJUH1gihxMjV9t0At4jWaX30kZ7ZLI2v3jY6hAfMpbzFmzGeyqv5?=
 =?us-ascii?Q?3qI4hKsYafaJ632S/IUJyZsS1FYUkKTCNhQEE9mDXzf/OtlVtW5AGQlLYiql?=
 =?us-ascii?Q?CmOYCronO5hT80fekrlZKeDc/hvgsbDWjkVNhRVEb+NpVgsq/DloGWXroJNB?=
 =?us-ascii?Q?cPF27G8Cs0DMXVk4WLrGYlR3/zAaFviwzX6RLBqwJj5Bs0qo0M02a0c39XUT?=
 =?us-ascii?Q?knX44cBr15CJs8uSTz6FLyaE1VfaO/NrLM7YJfM+UaauWJ7qTwZBzruG+ZYL?=
 =?us-ascii?Q?CcJNwBLTwgB60ihiwMqDIWQdmMFkZg+JioGnF6sIlLJ9KPG8TSB1zfUZqyLW?=
 =?us-ascii?Q?Fgwu4OGci9S5ikWRErrBlgF+nwllh7zNamRSLQN0ntPy4NSAlG3ZCB3oKhMd?=
 =?us-ascii?Q?/Uc70bePNwE3CQAm7EFUd3aj4Y+QaleboGEPRbyiPVqE2px5d/W+8QLCB2og?=
 =?us-ascii?Q?ZV8PRAlHGemFZIKx17ZrE7vxl5xqV9ECZhdMTVpDBhrq/PFw0T4tayKGCzBx?=
 =?us-ascii?Q?jLt1gwDbNG+onUAZ3xb9104TmGCjKHUr4PHb33VNLyXK9GjT0DUtwBpEcKAm?=
 =?us-ascii?Q?6wpd3zxhY//Tlyy3Ytatde42cYYgDl7pthvvCqKAhFFAhsKSH/I6YS8/XlL/?=
 =?us-ascii?Q?Jp6zSYqAvyHKlaLLoHbAHTy++KmXb8Gc8XdG9XTYfQ9HnTYIhGLabh5/fD/u?=
 =?us-ascii?Q?8Jd16MoIMZOwkN5hvBwNudF8QDIoduYvHiA7hm/X/VoL/aVAfTBRRtBeu5+C?=
 =?us-ascii?Q?eCrZEYF0RQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 366eefcd-eb83-41d3-ecbb-08da17a9a141
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 08:44:14.9960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MfBDxRKbG9Vpgh/Vxt9vx4NaWGHPj5RAqXVG0MIhZXaQ3sPFFfxqweRXZA7k+G3v9sDCNnKzKrMWheDFZtxy4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5505

On 05.04.2022 17:47, Roger Pau Monn=C3=A9 wrote:
> On Tue, Apr 05, 2022 at 04:36:53PM +0200, Jan Beulich wrote:
>> On 05.04.2022 12:27, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Mar 31, 2022 at 11:45:36AM +0200, Jan Beulich wrote:
>>>> --- a/xen/arch/x86/efi/efi-boot.h
>>>> +++ b/xen/arch/x86/efi/efi-boot.h
>>>> @@ -568,6 +568,49 @@ static void __init efi_arch_video_init(E
>>>>  #endif
>>>>  }
>>>> =20
>>>> +#ifdef CONFIG_VIDEO
>>>> +static bool __init copy_edid(const void *buf, unsigned int size)
>>>> +{
>>>> +    /*
>>>> +     * Be conservative - for both undersized and oversized blobs it i=
s unclear
>>>> +     * what to actually do with them. The more that unlike the VESA B=
IOS
>>>> +     * interface we also have no associated "capabilities" value (whi=
ch might
>>>> +     * carry a hint as to possible interpretation).
>>>> +     */
>>>> +    if ( size !=3D ARRAY_SIZE(boot_edid_info) )
>>>> +        return false;
>>>> +
>>>> +    memcpy(boot_edid_info, buf, size);
>>>> +    boot_edid_caps =3D 0;
>>>> +
>>>> +    return true;
>>>> +}
>>>> +#endif
>>>> +
>>>> +static void __init efi_arch_edid(EFI_HANDLE gop_handle)
>>>> +{
>>>> +#ifdef CONFIG_VIDEO
>>>> +    static EFI_GUID __initdata active_guid =3D EFI_EDID_ACTIVE_PROTOC=
OL_GUID;
>>>> +    static EFI_GUID __initdata discovered_guid =3D EFI_EDID_DISCOVERE=
D_PROTOCOL_GUID;
>>>
>>> Is there a need to make those static?
>>>
>>> I think this function is either called from efi_start or
>>> efi_multiboot, but there aren't multiple calls to it? (also both
>>> parameters are IN only, so not to be changed by the EFI method?
>>>
>>> I have the feeling setting them to static is done because they can't
>>> be set to const?
>>
>> Even if they could be const, they ought to also be static. They don't
>> strictly need to be, but without "static" code will be generated to
>> populate the on-stack variables; quite possibly the compiler would
>> even allocate an unnamed static variable and memcpy() from there onto
>> the stack.
>=20
> I thought that making those const (and then annotate with __initconst)
> would already have the same effect as having it static, as there will
> be no memcpy in that case either.

You cannot annotate non-static variables with __initconst.

>>>> +    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
>>>> +    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
>>>> +    EFI_STATUS status;
>>>> +
>>>> +    status =3D efi_bs->OpenProtocol(gop_handle, &active_guid,
>>>> +                                  (void **)&active_edid, efi_ih, NULL=
,
>>>> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
>>>> +    if ( status =3D=3D EFI_SUCCESS &&
>>>> +         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
>>>> +        return;
>>>
>>> Isn't it enough to just call EFI_EDID_ACTIVE_PROTOCOL_GUID?
>>>
>>> From my reading of the UEFI spec this will either return
>>> EFI_EDID_OVERRIDE_PROTOCOL_GUID or EFI_EDID_DISCOVERED_PROTOCOL_GUID.
>>> If EFI_EDID_OVERRIDE_PROTOCOL is set it must be used, and hence
>>> falling back to EFI_EDID_DISCOVERED_PROTOCOL_GUID if
>>> EFI_EDID_ACTIVE_PROTOCOL_GUID cannot be parsed would likely mean
>>> ignoring EFI_EDID_OVERRIDE_PROTOCOL?
>>
>> That's the theory. As per one of the post-commit-message remarks I had
>> looked at what GrUB does, and I decided to follow its behavior in this
>> regard, assuming they do what they do to work around quirks. As said
>> in the remark, I didn't want to go as far as also cloning their use of
>> the undocumented (afaik) "agp-internal-edid" variable.

Actually it's a little different, as I realized while re-checking in
order to reply to your request below. While GrUB looks to use this
only "just in case", our use is actually to also cope with failure
in copy_edid(): In case the overridden EDID doesn't match the size
constraint (which is more strict than GrUB's), we would retry with
the "discovered" one in the hope that its size is okay.

> Could you add this as a comment here? So it's not lost on commit as
> being just a post-commit log remark.

As a result I'm unsure of the value of a comment here going beyond
what the comment in copy_edid() already says. For now I've added

    /*
     * In case an override is in place which doesn't fit copy_edid(), also =
try
     * obtaining the discovered EDID in the hope that it's better than noth=
ing.
     */

In turn ...

> With that:
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

... I'll wait with applying this (thanks) until we've reached
agreement.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:45:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:45:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299720.510840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1I4-0006qZ-HQ; Wed, 06 Apr 2022 08:45:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299720.510840; Wed, 06 Apr 2022 08:45:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1I4-0006qS-E9; Wed, 06 Apr 2022 08:45:24 +0000
Received: by outflank-mailman (input) for mailman id 299720;
 Wed, 06 Apr 2022 08:45:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tpXD=UQ=citrix.com=prvs=0888b7d66=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nc1Hx-0006ps-LU
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:45:22 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de10731b-b585-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 10:45:14 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de10731b-b585-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649234714;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=UCaKtdb3bWKL+Y6xd/f9UbSA4XV89mUjMrfV9Tqx5Ho=;
  b=FYQJ60HuKB3fvN15eHMBZqxJV/ZM3Ct7TWo/f+ND1c8Ln7KHJeq4AgGh
   VEJjmiFXdUg57VoFjnPwtKQadfI8qkouepGTslqKuK2vc1kCRP6c/7vBU
   hcyrh6nK8XpPtJ7zSz92J43YEsDcXSGL7KjA0wRl+64YpP/GARlOsrJZi
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68031880
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9bw4YKNDvKbcvNDvrR2Jl8FynXyQoLVcMsEvi/4bfWQNrUpz12cOy
 GcYUDjVPKuDZDH3Kth2bIq+o0MOvcLSmtBqGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tAw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 /oWp8GLRykSIKCdxvUZah9qSDpbIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTa6FP
 ppJMVKDajyHfg1RZUs2CKggkf65r3zzcT1b626a8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTX5kJCLCj6rtjjFiSwEQDBRsOT1y5rPKlzEmkVLp3K
 UYZ5y4vpqga71GwQ5/2WBjQnZKflkdCAZwKSbR8sVzTjPqPi+qEOoQaZhluM857j8EYfiInh
 wGYm+rvN2d0laLAHBpx6YyohT+1PCEUK0oLaikFURYJ7rHfnW0jsv7cZo09SfDo17UZDRm1m
 mnX93Zm293/mOZRj82GEUb7byVAT3QjZio8/U3pU22s9WuVj6b1NtXzuTA3ARutRbt1r2VtX
 lBZw6ByD8hUVPlhcRBhps1XQtlFAN7fbVXhbaZHRcVJythU0yfLkXpsyD9/Plx1Fc0PZCXkZ
 kTe0SsIusMCZSv2Pf8nM93qYyjP8UQGPY67PhwzRoAQCqWdiSfdpH0+DaJu9z6FfLcQfVEXZ
 s7ALJfE4YcyAqV71jumL9rxIpdwrh3SMVj7HMihpzz+iOL2TCfMFd8tbQvfBshkvfjsiFiEr
 L5i2z6ilkw3vBvWOXKMr+b+7DkicBAGOHwBg5cOLLTefVM6RjpJ5j246epJRrGJVp99z4/g1
 nq8RlVZ2Bz4g3jGIh+NcXdtdPXkWpMXkJ7xFXdE0YqAs5T7XbuS0Q==
IronPort-HdrOrdr: A9a23:McVy3K/zoSiRgnXC3j1uk+F2db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFrrX5To3SIDUO31HYYr2KjLGSjwEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadg/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHzWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mEryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczAgNl1mpDs1L8Zqq
 iJn/4SBbU115oXRBDynfLZ4Xik7N/p0Q669bbXuwq6nSWzfkNENyMIv/MmTvKe0Tt7gDg06t
 M644rS3aAnfC/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvt3+9Pa1wVR4S0rpXWN
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wua4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Frt2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLELQIwFllu9EU5HHNcjW2He4OSMTeuOb0oAiPvE=
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="68031880"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KU2i0LOe+ne5hqYnDpxJgOu5pMaYhzHWPoOaJV55v0sHUNRGLsLJ9xarDLV4YiBsFFDpCLujjpD0Xl51EoblHD2Sm8WN/wIJVXQRXoBfl7pYmS8TbDZidioVb6lXkiecTOnvnkkflcAU4MyBIcNbcykNuZ0akPHhKJTtsA3sWaSBuwoe8fvBLGonaDYhdHU80LyilU2EyL20l5WiJuABsUY3pSUEbMNcRtPUCGlp5BhMEwcMsWLMqfYqFinEyFO8/iNIo7AOK5eut5TwLA6h1bZXpCt/1u5pZIaePdM+Ua17V3OsWhZxtuxJPBXtvVIwqWXoUtIhca/G+99JDJhQCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UCaKtdb3bWKL+Y6xd/f9UbSA4XV89mUjMrfV9Tqx5Ho=;
 b=f7IaDprgvgalCqhkfNqz+Rq4Mmhu2vMKNLdGNf7ko6eZC9eCmwebL6b+V/aYieH8eBP36sgDhxW7lIj0LL6Ai8Xf7qHbijRjDVzSH3wBRt72bsgYUZfSP4+dYZve5Cd5azRGOHCRs2/LJENBAmTrQTwVpC5MdhiKCebyW13QvQsJLO/MRBIaeSBbZdQis1HInPcLG1DrelSAP/xV5Rl6zxyiJ+Mq0yIgPV3MVPzJFbOilW6x+OO5KOiqD0NxfnlkRQNFvte/5QYNZP5PQKrtpyUtUcJvgMH7f+VlZADIhFKC1pY80GB209JpG7C/DS0jYsCpNue4EKefjPv2VotZPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UCaKtdb3bWKL+Y6xd/f9UbSA4XV89mUjMrfV9Tqx5Ho=;
 b=T/kv8R20mWNKPebMuHkSQZGMPxTW+fVAFbnIV+SvjDjF7y/QjH/ao+I9oMY9ExPsXZ2963XCA2qDyibdnNtkQ/YOwPd2WmdTz2pHp75+UrT/OXcTUHSouXA91djFYBP8fGrMMndjR5OJ8lm6CtOnq6G8gfrUIvt6e4vNb94IeYQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, osstest service owner
	<osstest-admin@xenproject.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Roger Pau Monne <roger.pau@citrix.com>
CC: Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [xen-4.14-testing test] 169170: regressions - FAIL
Thread-Topic: [xen-4.14-testing test] 169170: regressions - FAIL
Thread-Index: AQHYSPz9Yui6molSPEi3RG1EVTOj+qzifDEAgAAXDQA=
Date: Wed, 6 Apr 2022 08:45:04 +0000
Message-ID: <afaaf270-27d4-39af-8125-6d622801073d@citrix.com>
References: <osstest-169170-mainreport@xen.org>
 <d0e84ac8-308e-1784-982e-271705c13b7d@suse.com>
In-Reply-To: <d0e84ac8-308e-1784-982e-271705c13b7d@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1a1735cd-6ef0-4c2d-fbdb-08da17a9bed0
x-ms-traffictypediagnostic: MWHPR03MB2639:EE_
x-microsoft-antispam-prvs: <MWHPR03MB263909DCF25505CAF7D19303BAE79@MWHPR03MB2639.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ImYpmFdXzUr/F8lMyVi3+Jf4T4Xvowjjk0P+sr0KoTjvpLLjgZ5P2OZuozxSLxDT0/S/Jp+ZDvdgxq7liiyYVH4zHUHVcX9VNnYdbNdEew63EEi3tjNFdI/TS6N/xmeTt00/sJQIW7iV2GQvRayssSk1d4IiA1lnqdXsG4gjZfVlT1nwikSvz+VjDVgFuwjoGnf5xPnFTP8q7k8ZpfWUTptwWRib1r5BE8xvEqmR7g/4XzfaiFmUj1KasREqMWP+BCRas3wBZ6Gjh3Qj+jsWhqjnSdc6JBhehqzMhCAx+gUNXZ7qNgpZTqEfiF6CsetVpnt7J1O8bmeWq0+jWnUHDgGmKtzZaO41wevTXscgHcBPUbeubDogzAYQsZu1zYWZHBUo9Pyr/4oIyKbFO092C7AMc4/r0OD3kCtWr/9Xy87Nm7dv0jVsX/KCprRhDqklLwDRD4XdGAnkvLhv73GnYP4G4mV6O42PFpmiRKxFQY/yCkaXULxhweBtJ0SDZOK/pvM18ssA/LeR93kfL29LKbyIA1I+k5U4EgwD15k8fnjIMq8mqn3cF+xw3aO1J0AUnh4IHhhcrZQOVqH2iQc64yWR3Rk0x6LBgcVnYPIYWqZ4FYZNTSygT57Nbw2ru0H/7b817EpgVY5wBbldTmYCl59fT0n4jyyyMlQS257bS7L3UlKCy0qm6YmOaMVuBviOiU4/t3o6BNRnCt86rrmOGiCXLVy1m57lP6Eu6i1DfW4V6AqPodMZl/1v1zxEtrjy3u0sJ8i3CCPMp1KKIjKtOqW8R9ybkxz0DUrwcVn8vRu1dyI6q0l5hpRiJiqQ1lYf4VkzDPedV26JFkuisxvxU0p8kUBY7weBwk3ph0A9ZDI=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6636002)(110136005)(4326008)(71200400001)(64756008)(31686004)(91956017)(5660300002)(82960400001)(66946007)(8676002)(66446008)(66556008)(316002)(66476007)(76116006)(36756003)(122000001)(38100700002)(6486002)(966005)(86362001)(508600001)(83380400001)(38070700005)(26005)(186003)(6506007)(107886003)(2906002)(53546011)(2616005)(8936002)(6512007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SHFEUkx6VU1yRkdreGZrOFEyQ281WUNYdjNOME9kT253eEc1b1BIV3FlZ1Rz?=
 =?utf-8?B?ZUFvK0VGUHR2ZStiNUpUM1RteTNZR0E2czNQSmJCbm0rRnlwWHpJdG9PNHhN?=
 =?utf-8?B?c2pWVEJYUTErWFJ4cFhJalFwTEtSSTE3L1lCaWxUVlZhVjhmSzRHekFFOWw5?=
 =?utf-8?B?eTM0SWdSMzBwTFpoWFk3OTh5aUgwTzU1ZGxMK3NYOWlGRjcvbnlpQURiTlBR?=
 =?utf-8?B?bjl1azAxUEs5ekxSK2o0ZHM1b1JiRTFhVEpPeFZuQ2xKeXhZeXFBL3lHZFN1?=
 =?utf-8?B?RkloQ2VQdE91cDhxUUhDMGtCdUZSaHU1V1ZVd1E4RjZPYTR2emY2UzNOOU9C?=
 =?utf-8?B?YlF6K3J2UlVHUWJDS1AvNElabk9qcGtyRC9MMmZJZEpLbzMyU1ljdFBSR1BJ?=
 =?utf-8?B?ZTJsREwvNFZleFMycmVIellSZHJMWkE2WlB0cCtYa1BFZ2orclN3VDNvclp4?=
 =?utf-8?B?MjZRd256eXBncDVmc1R6NnlVUXlxZ05Jc2k2a2xtZmpyQU1SSXdKZ09IL1ll?=
 =?utf-8?B?OHFveGM0L0dRZ2RjM0J6VmpvSmV2S20yNElybmRmOFlWMkJFeUg2aXNldUhO?=
 =?utf-8?B?bVZ6N0MrVjhOSW9ZMUU5cm5jbnZteXgxZWFiM0JkMk1tVmJwUjlVWVhVa1BE?=
 =?utf-8?B?VHRueW94UlNOZFBmL21GR1hTNHRFbTJ5Y2pBLzUrMXp2bGU0RkFkYkx6cDgy?=
 =?utf-8?B?VFhROTl0Wjhqb1h2RExBV0xSNzUwUXpidDBSWm9pU2h0NXdEdm9UZHp0RkZJ?=
 =?utf-8?B?enNOb0JqVmpXMEx2cEVVckE4SWdMdVBvQjZhdGVZSmVNV0tWbERqRXpCTWY2?=
 =?utf-8?B?QzV6OC8rNnBDN1A1MTZ4OE1tZkdOY0F0YkthczhMUnZncHYyZlBWT25ha2tG?=
 =?utf-8?B?WjE2bUcyeG9qdjJyVUVJOVNOd0tnWk8xYzJmRFc5SXFBWWtIKzdsZnNSeG9r?=
 =?utf-8?B?QnByWVh2ZkdwSHNwQWpNMHgwZFVkWHJaeFMxbVAxeGtHTk1XM1FVR2EzaHpu?=
 =?utf-8?B?cVZpM2NYakE2SUp4TEQvSTE3ODFCT3hIU0h5NVpNYUNhck1KWEpHalJVRFZy?=
 =?utf-8?B?dEYvaXNpaVUyYTB0blFmRzZ2Q1FVTStRUXNGQ2IxekdNQ1hlZkpMUmFic0VZ?=
 =?utf-8?B?UUpBclpFUUQ0Q2pseWw3aURvTEkxcGJ4dHBkQkZ6SC9xQVZUWXFmZFY1WThr?=
 =?utf-8?B?L2NkOWlhN0Y1L0lkOUlBcEJDejIveTJMMHpWMEQ4WUNOZGk5ZUZyRXd4UnRx?=
 =?utf-8?B?YU5ZbEZzVjFIVVVmTVVKclZ3cjFvLzIrTW5HQVVKZlp6ZThRZHNyb1lDTDV4?=
 =?utf-8?B?alpRbWExcmR2bDFqdkM3NTl0WUt3SUthU05YRFpWbFpqL1FxTkRUTmsyWFZB?=
 =?utf-8?B?UnVlQ1drU3dhWmZRZC9TWXgzeXJxK0ZTNWlMN05jVGUvSks2MjMzcHp5TzFQ?=
 =?utf-8?B?V2NRMzdINnRwNlFNMUF0ckVTQmlzT2ZJSWtLb0FLRXlHbmVRL0FpNUlBNzJy?=
 =?utf-8?B?TkRjRW81K0plTjBpZFV6VXJ5Z2ZmMWZZamxJNklvZjdvMnRJd1Zxdk1TOFpO?=
 =?utf-8?B?dndYV0oxOVBRL1pPWHVrWjhsT3pvZTJjaXhSUWd2c3JUcGljcnk1MEt1Z3p2?=
 =?utf-8?B?MGJOYUZrS0VZMVR2UlNGL1hKVW5wV1Z6QWNKTnpCbklJa1BYS3VnWWcwTGlV?=
 =?utf-8?B?aGVLRVpRSVVMdE9zQzVrZ3hLeHNKUlczOWNVY2RrRHBLZ2hzVXBFVWhId3NV?=
 =?utf-8?B?WVY5MXhoajM1cXVXZms2Qm5iUitLZVB4U0NyVFZWaWNSaVZYRjhyRjFhTEhv?=
 =?utf-8?B?MmdHMGlRd1N3TEFzS2U1RWxwWkZTb1NDSzJRZG1uWUllazlGYVhqdHdaN1dM?=
 =?utf-8?B?cVc2Syt6WDdoOWRpek5tR21wZDdDbzZITlRqQW1VclJabitacExmVzJmN2Y3?=
 =?utf-8?B?em92bW5OTFNYM0Z0emd4empwakpSb0IwVjZvU3pwQUpwQ1B6VmROR09pVDZ6?=
 =?utf-8?B?UmNwck11Ty9BVGRZOEVFalhzSytUeXNhZ3hUVEc1K2NVRElHZjlRdEtkeHIr?=
 =?utf-8?B?MzRvUmpVZmtweG9URlBaY2VtbWdzbmNYc25abndGS3dnOEMvYThiZ2s2clQz?=
 =?utf-8?B?aVJYNkd6SzI1SlZYNjhlM3I4MkxIaCtpSEhrdDFTU2EvTXBUQThmK2t2WFFU?=
 =?utf-8?B?UUUya1J1akxvbkdiMVRGTFkyaHV2NzVkaFJ2ajMreW5VU2tDL0xCcm5Ec0Ez?=
 =?utf-8?B?cTVINi9lczc5M25ZR2pNelplZ0l4aVdMQVJxQUh6YUVmdTVObG5aVmp5dWNT?=
 =?utf-8?B?V3JwQTdIckYyVWVUSEhaVHJ0ZUU1KzRBRGtCM2xvOE1oZXMrck00QT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F33AD89354E8654BAF725CB867589BB0@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a1735cd-6ef0-4c2d-fbdb-08da17a9bed0
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2022 08:45:04.4000
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2NXbI/0V5useZXUdgHUARZsA+IHCoWN7HqVfJkLv0ltjYLSV468iKtOrveVWJggaTzdTU4QXBlsA8a729IS4vWR6KtDZGm1BYVJYEjHxfCk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2639
X-OriginatorOrg: citrix.com

T24gMDYvMDQvMjAyMiAwODoyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA1LjA0LjIwMjIg
MTY6NTMsIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4+IGZsaWdodCAxNjkxNzAgeGVu
LTQuMTQtdGVzdGluZyByZWFsIFtyZWFsXQ0KPj4gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJv
amVjdC5vcmcvb3NzdGVzdC9sb2dzLzE2OTE3MC8NCj4+DQo+PiBSZWdyZXNzaW9ucyA6LSgNCj4+
DQo+PiBUZXN0cyB3aGljaCBkaWQgbm90IHN1Y2NlZWQgYW5kIGFyZSBibG9ja2luZywNCj4+IGlu
Y2x1ZGluZyB0ZXN0cyB3aGljaCBjb3VsZCBub3QgYmUgcnVuOg0KPj4gIHRlc3QtYW1kNjQtYW1k
NjQteGwgICAgICAgICAgMTggZ3Vlc3QtbG9jYWxtaWdyYXRlICAgICAgIGZhaWwgUkVHUi4gdnMu
IDE2ODUwNg0KPj4gIGJ1aWxkLWFybTY0LXhzbSAgICAgICAgICAgICAgIDYgeGVuLWJ1aWxkICAg
ICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE2ODUwNg0KPiBVcmdoOg0KPg0KPiAgIENDICAg
ICAgaHcvdmlydGlvL3ZpcnRpby1idXMubw0KPiAgIENDICAgICAgaHcvdmlydGlvL3ZpcnRpby1y
bmcubw0KPiAgIENDICAgICAgaHcvdmlydGlvL3ZpcnRpby1wY2kubw0KPiAgIENDICAgICAgaHcv
dmlydGlvL3ZpcnRpby1tbWlvLm8NCj4gICBDQyAgICAgIGh3L3ZpcnRpby92aXJ0aW8tcG1lbS1w
Y2kubw0KPiAgIENDICAgICAgaHcvdmlydGlvL3Zob3N0LXN0dWIubw0KPiBjYzogaW50ZXJuYWwg
Y29tcGlsZXIgZXJyb3I6IFNlZ21lbnRhdGlvbiBmYXVsdCBzaWduYWwgdGVybWluYXRlZCBwcm9n
cmFtIGNjMQ0KPiBQbGVhc2Ugc3VibWl0IGEgZnVsbCBidWcgcmVwb3J0LA0KPiB3aXRoIHByZXBy
b2Nlc3NlZCBzb3VyY2UgaWYgYXBwcm9wcmlhdGUuDQo+IFNlZSA8ZmlsZTovLy91c3Ivc2hhcmUv
ZG9jL2djYy04L1JFQURNRS5CdWdzPiBmb3IgaW5zdHJ1Y3Rpb25zLg0KPiBtYWtlOiAqKiogWy9o
b21lL29zc3Rlc3QvYnVpbGQuMTY5MTcwLmJ1aWxkLWFybTY0LXhzbS94ZW4vdG9vbHMvcWVtdS14
ZW4tZGlyL3J1bGVzLm1hazo2OTogaHcvdmlydGlvL3Zob3N0LXN0dWIub10gRXJyb3IgNA0KPg0K
PiBJZiB0aGlzIGlzIGdvaW5nIHRvIHJlY3VyLCBJIGRvbid0IHNlZSB3aGF0IHdlIG91Z2h0IHRv
IGRvIGFib3V0IHRoaXMuDQo+IFRoaXMgZG9lc24ndCBsb29rIHRvIGhhdmUgYW55IHJlbGF0aW9u
IHRvIHRoZSByZWNlbnRseSBhZGRlZCB0d28NCj4gY29tbWl0cyBvbiB0aGUgcmVzcGVjdGl2ZSBx
ZW11IHN0YWJsZSB0cmVlLg0KPg0KPiBIb3dldmVyLCBpZiB0aGlzIHdvdWxkbid0IHJlY3VyIGl0
IHdvdWxkIGJlIHNpbWlsYXJseSBhbGFybWluZzogVGhhdA0KPiB3b3VsZCBzdWdnZXN0IHRoZSBi
dWlsZCBlbnZpcm9ubWVudCB0byBub3QgYmUgc3RhYmxlLg0KPg0KPiBUaG91Z2h0cyBhbnlvbmU/
DQoNClRoZSB2ZXJzaW9uIG9mIGRlYmlhbiB3YXMgcmVjZW50bHkgYnVtcGVkIHRvIHdvcmsgYXJv
dW5kIHRoZSB1c3VhbA0KT1NTVGVzdCBpc3N1ZXMgd2hlbiBpdCBnZXRzIHRvbyBvdXQgb2YgZGF0
ZS7CoCBHdWVzcyB3ZSBwaWNrZWQgdXAgYSBuZXcsDQpicm9rZW4sIGNvbXBpbGVyLg0KDQp+QW5k
cmV3DQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:47:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:47:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299725.510852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1JY-0007UH-Sx; Wed, 06 Apr 2022 08:46:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299725.510852; Wed, 06 Apr 2022 08:46:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1JY-0007UA-PZ; Wed, 06 Apr 2022 08:46:56 +0000
Received: by outflank-mailman (input) for mailman id 299725;
 Wed, 06 Apr 2022 08:46:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc1JW-0007Tz-O8
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:46:54 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1a676cf5-b586-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 10:46:53 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a676cf5-b586-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649234812;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=APg1bhKeCj6ByMGr9w1gdc9cq2gqOYu1WoMxhN8arjw=;
  b=GfiBxQXKIwmqFeOZzuPcChNL7RQ3bdiV9JW3PnESKuUROWrkMhSx/xis
   vlu+nsrWObBKOX7OvgX+JSIlIbB4Jmb+S5gMTpPvBZjpLAhxCibFHy1w9
   I5TpV1YFxrOXDaYkwltpG/2Oqaxce5IxPaLWd3d8AWgYvAoa1BRTE8X/f
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68542660
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:a2Jp/KMsVZG1jV/vrR1Hl8FynXyQoLVcMsEvi/4bfWQNrUog1WYPy
 mUZWDyHbqmDZjP1fdhxbo3ioxhQvZeDm9FlQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tAw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z8
 9ERp4y+QD8VJIL8msEQAzlCNHhsFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmdt2poQQ662i
 8wxMmQwcDfMeCd0IwkmNpNho8ONwSf9bGgNwL6SjfVuuDWCpOBr65D2O93JZpqGTNtUhW6Du
 mvc+23zRBAdXPSTxjaI/WilrvPeliP8HoQJHfu38eACqFGL3WkSFB0+XEO2u+WkkVW5X89DK
 ksS4Wwlqq1a3E6hQ8T5Xha4iGWZpRNaUN1Ve8U44QeB0LvJ4C6WA2EFSnhKb9lOnN87Q3km2
 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgc/iTQsFFVfpYO5+cdq00yJHo0L/LOJYsPdIjWs0
 SCEpRACnZojj+sGh4Wh2gnVqmf5znTWdTId6gLSV2Ojywp2Yo+5eoClgWTmAeZ8wJWxFQfY4
 iVd8ySKxKVXVMzWynTRKAkYNOvxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj
 aK6hO+w2HOxFCbyBUOUS9joYyjP8UQGPY67PhwzRoATCqWdjCfdoElTibe4hggBanQEn6AlI
 ou8es2xF3scAqkP5GPoG7ZEgeN7lnBumji7qXXHI/KPi+T2iJm9E+ltDbdzRrphsPPsTPv9r
 b6zyPdmOz0ACbajM0E7AKYYLEwQLGhTOHwFg5c/SwJ3GSI/QDtJI6aImdsJItU594wIxrag1
 izsASdwlQug7UAr3C3XMxiPnpu0Bs0hxZ/6VARxVWuVN48LOt/1tvpALsdpJtHKNoVLlJZJc
 hXMQO3ZatxnQTXb4TUNK577qY1pbhOwggySeSGiZVACk1RIHmQlJveMktPTyRQz
IronPort-HdrOrdr: A9a23:bBHw8aNLzmu4n8BcTy/155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80lKQFm7X5WI3CYOCIghrMEGgP1/qH/9SkIVyDygc/79
 YQT0EdMqyJMbESt6+Ti2PUYrVQouVvsprY/ts2p00dMz2CAJsQljuRZDzrdXGfE2J9dOUE/d
 enl4J6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr10jegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKva/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdY11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa
 hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj8lLYIk7zI9HakGOup5Dt
 T/Q9RVfY51P70rhIJGdZE8qJiMeyXwqSylChPmHb2gLtBCB07w
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="68542660"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kBtA8yQjZpcduh9FDP289GA49nBvEIYKdNdI45/K+JgM02a42d9vx/fKP20pq6soC2dIg1/i1awCFY+ZIRMyHuIhhZeIzh9+ZM1e0oxLt+FBlJteJYR6UY3hgassmuP0lH2PlA7/bJfGkAPyuVdWeHm8KzgEsjGxq7Ndj3W00iMj3rlqi+EFObG0xFdvpwEQ6s87/bbzh5Y3+FLfg0CDZwN3vbTmQtYBDISR2kOuylHgArjOltZ6Sd38G3Y0BZSWmVXFuo5CxstfLqX7cmRwmuwsYbxsI5BsM3nPvgz5Zz6y8AtQLnLVfRkJ0dHj0uv1l22fT23om0BcrPd5Qi7mMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o0muEHvo0OwrGv5vA1iAbBVjF4EhQfRHpE8xOPgmp3Y=;
 b=HP4I12Vfo241nQRbIh6Lygyu/J75o12vz7/NNlTNMoHYbBGGZBiZaGS/L7FAZLH4y03J3I6dAycFbqluKI4tq2xnZAnLdn2ctUjQEIvS1K9I4Ey3PZdtwXdzGDeACgGkXnJCjxa4Xgn7wyoOW0/cLDGbmy7hFWAXydqleeqEHlJOIH7qHlIW3hUHo5b81NFE2Uyklkau552zyBVC/As1/8pQ8sCIEhVQeNtyCRJB31HVs0Sv387M4+YT9jpaXU5GBdOjUx90c4pMxEYfULbzl69S6REZmIivP+Bbdqs6lF6f+W1fbFMAdGds51dmUh09w/oa3ZcW6I5qszH5OkNaug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=o0muEHvo0OwrGv5vA1iAbBVjF4EhQfRHpE8xOPgmp3Y=;
 b=VUQ2DAvshoXUXkb1KBAvfycRXtaAzqlsd1GrQX9ZEeGZV0NZOTjkkmk6CoPF7ULLTz8ntp15AomtX/SJ643d/i1vIAIDCnLGdq2sGcVR11Cw4/PVY1H2ua1rkyGStTxL8VuHWLisjjskpBMW/Xl3jnrIsUdz3eAtrNoJpJm6i6U=
Date: Wed, 6 Apr 2022 10:46:35 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Jason Andryuk <jandryuk@gmail.com>, xen-devel
	<xen-devel@lists.xenproject.org>, Scott Davis <scott.davis@starlab.io>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Message-ID: <Yk1Ta9ujHBuj+svN@Air-de-Roger>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
 <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
 <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
X-ClientProxiedBy: LO2P123CA0083.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:138::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c51ae77-2d88-4677-7207-08da17a9f7ff
X-MS-TrafficTypeDiagnostic: BLAPR03MB5634:EE_
X-Microsoft-Antispam-PRVS: <BLAPR03MB563435E9D0C668D43B213E238FE79@BLAPR03MB5634.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 0BW8fUjah0YESTFrh8TUDz7Bwf4fsh1c59gwB7MogAAIoQ6No+0fzyGcnEc4w3Xy6l0RW7I/ot8IFjkbr/xJ8CxWCHTEWLFOx0ImrXGJCjsXE9tcPdUtM4G0KqwXNNek2lDp2/KjsnhR7S5JUFjt2rujdW65YI6CPZYsNip8wtqW1q8fkkp1KOI4It3IRqcQJMtlDiZI3YeRWlsXWdQAmhWT1lXQ4kDeCDKM5MqY65GBUqpG3rJwcJHiXfO9hrJt1KebQo0P4tgAKp7sNGC7ZmSaPtpr97JIZii2/dse4jM9RoFJ32+rRhxKtq9gld1hcc/nYMUp7o9oLu+ML9vJ84/eT26IZzOJ4UEdn2ClhUTrYOvmMyyjxUfXH+/fNbqdruWAJUYMpyoKWQ9CG6BgwAWk+8oxAnceqoS5Y1JPUKXCcPXAWvEKBEkYkCxqRCHiZTnAOzPP76U2kmiYHkkuU0YNIWTef2awHBbPlwsb/h3so7ToM57zYGb4l81Tob8LigD+BYCDO4BKOUyyXxjTTaQGjl6mT/jUdQRFgwq3N9h+eWGbE2QCWP0lFz1wPJcx/cNVbeqYacDSfS7RQitCqujOKII9rx8PEV8iq/l99XccaOIGsen/+Rz0Z48CJDe9miM2abo/Go6hwfFdtYXuRmYU2JajajQ+kA6H/ye6p4ccgUeE8QOSjpu1T3jq+dzxye2nEc64ebtWAr9to8kVlg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(86362001)(8936002)(5660300002)(2906002)(38100700002)(6512007)(82960400001)(9686003)(26005)(85182001)(186003)(508600001)(6506007)(53546011)(6666004)(8676002)(4326008)(66556008)(66476007)(6486002)(83380400001)(316002)(54906003)(6916009)(33716001)(66946007)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXVPcmx3ME95YTN2TTlUbFhjMWt2WitlZnkwZmVjOGhpQW9FQ1lSaUo1UzB1?=
 =?utf-8?B?VFRDNUFCNzJrSURtNVBZdUU4ekE0MURFWDBiNGgzcXBvV0hmQkRXVXlDTU9Y?=
 =?utf-8?B?eFFwcTJqdE5PRGpyYzNCMXVMZmZFL2FrdE1nMTlRWnIvZ0Ftek03U1Z4cTVE?=
 =?utf-8?B?c253a0VVdUdHb0FKUWFjOWtUYWM2eXhRTzY4WXNYWUNsT1B0VExIVEhwQmdV?=
 =?utf-8?B?bk9VY3d0UDF4VXpYT0ZtbXovUVJwZWtuMTBTaVVPU3cyTk5XQ2htRno3bUNY?=
 =?utf-8?B?STBoaXNJS3hVRmtBelNLZ3RTRCtHUms4ekVpd0VaVHFJcGtDRC81ekFNb2Mv?=
 =?utf-8?B?YkRGUTd4YS9ZOENRd241OVU3b2V6SlgvRk54QXhKb091Q0JIUmxTODBrTjF2?=
 =?utf-8?B?VG5QV0UzRXo2b2VjT2Z2VVdwV0VmZEgyK3ZQVjgxWTNlYTk0TG14VzNuMEtp?=
 =?utf-8?B?d2hoYVpXOUMybXRvMENEMEFkTkV3THJVb2tIdWoxUXkrVWtjSThiM2pPdFhT?=
 =?utf-8?B?dm5xU3poajdLMnlxZGs2bnhrRmhJUEs3K1RXaVFmdnBDNjV5LzJoQkoxbm9Q?=
 =?utf-8?B?c2ZLZmFYcjcrOWxIZk9XWGFpN2RTc0xCZEg1MTZJNkk3aUZtZy9KS0VwSFBO?=
 =?utf-8?B?TjlNQXQ4OFB5T3VrWDFVYkdUUjU5MExhbzZjdVZKTlNscXpnSENCSnlzaHk5?=
 =?utf-8?B?cFRiVEI5V3BHMXgzd1hidTladi82Vll6STBDSkQ2OXF3NEIzWll0QmZRbkdG?=
 =?utf-8?B?WXYwQ2c4ZVNSSy9EVFFJWStDT0UzRFBYbkpkVFlSWDZNaVhacTdkQW9JN0Fw?=
 =?utf-8?B?dzJKaGxBSTRIWlVJUC9va0FrcElNSmFnSWRKbjI5VFZUNnBhRFQvRy82VzJq?=
 =?utf-8?B?UitEK2doMDBvVkdYRS9nZm0zS1hjOGc3UFFCWXloSm9GQkFjUWtPbjRudC9K?=
 =?utf-8?B?Q0JIdGI0OHBPVFZCamdsMDN6dGV6d1JtVWZmMFlpUnRzQUtzOTdLZEJJamhB?=
 =?utf-8?B?T01XMm1CaUd0cEdBWjdYcWhYNHV6cVUvdTNlWDI2RlRlazhQTlNhVWVQa1li?=
 =?utf-8?B?aGpURkJSZFd0UWhCNjF4dXBEODZ5MlhrdnRRK2hWN05XTEM4SnB6UWZ2RVRP?=
 =?utf-8?B?YjdkbDRkeWZtMVcwejY3WEppVkgyZHllZkVvdFhIZ1ZyL0JCaEsyZkxEWEp0?=
 =?utf-8?B?bUhMZEhaVjdzQ29ISzlveENnQnRnSURnR1ZzNHZoRDNRcXdlWFR4Q1hTOE9v?=
 =?utf-8?B?TWtZZXpzSUVlblU4SHpEb1E5VGE2N1NSRG9rb25ZaDhNSEVyODRHNmhIS3BE?=
 =?utf-8?B?NWt3QW00eFNiWVR6cDF3NmFXaUJBYXdnR2xPZy9HSHF4VnZJek9GUGsrQ04v?=
 =?utf-8?B?TVRHaUVZYmF1MHdjVGltTll5dHhWK1ZPbE10MUpOSHBHc0JjWjZvUkJjRlE4?=
 =?utf-8?B?QS9YQXphOWpxeVlpZEpzdTBvSDF2QmR5RjJIbjdjbEZ3UmVsU21qeU1zR3dr?=
 =?utf-8?B?NnpnMlI0akpqS25EZGdYY3BQakY3TWZGNGtTUGIxV3I2QlhMQ3RWdGJSL0hZ?=
 =?utf-8?B?b2lFVFNCQzRERzA3V1I0TnZDUjJEOFNkVEV0Q2pTL2JUVG1lTWg5YmR5QXJF?=
 =?utf-8?B?d1VTQkNxVWR5ZXkybFVRc1pwS2U2R1BvSEp1YWFPeldZYW1YYWY0VG5ZSHE4?=
 =?utf-8?B?aURDV1RCUTd6amxBbFNwSTRvbVNLRTkxQm5kdk8xTUNzK3JRRld0UkRIUmRL?=
 =?utf-8?B?emRCT1FqeXB4amt3WXFQTHJrTG5hQTFldmQvV2lpYnNBRkdpaUdIdVRacUJM?=
 =?utf-8?B?eW1ndU5ES1poVExrN25vMmxrRzRNRHp4TDNXYlBqbnN4K1ZGR3NkdXpaNkpC?=
 =?utf-8?B?QW8wT2RORU5TemFwOU5HaTUrc3hnbUJOTUdlU0tGMC9zdU85Z0NLYjAyRFlZ?=
 =?utf-8?B?L1BzMWttMkJaNUllVlVGQnA3bnZreDBFbVdwOUdqbExjRFpGUnNhMm5JMFNR?=
 =?utf-8?B?dUJRMWR1QS9JalpGY1pBS2Rkc2RwRSszRGVsNk80blBicnRCa250eXVFU1p4?=
 =?utf-8?B?UlAyZGhTSjBUaEo1ZzhjYjZwY1VoV3VzWTNBWG9tSjJ0aW9oYmxPRlkxTmNI?=
 =?utf-8?B?S3oxVFJXeGJQbytwTjBUYVZVRDlPdllRZHNPc2RnWEREMFBjTnhidXdxRnh6?=
 =?utf-8?B?WlV4MjVwdDFRa1NoN2tTelRZaWJxU1pXRU1vWjc1emZacnBZWUdoSHhreUZy?=
 =?utf-8?B?QzVmOWVSTXc3Z2M4Z045OHg2Y1pNemc5NHBUUGU5YmVuYzdKRC9lQ2tFVnJG?=
 =?utf-8?B?RGltcllTcm1rMXhiVjl2RDlIc1QwWGxXY1hWSFdTcDRqZW9XMGFpcWVRVTVk?=
 =?utf-8?Q?SFQa3rJzK1qBYFK4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c51ae77-2d88-4677-7207-08da17a9f7ff
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 08:46:40.5690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: maMAm7wIXHvKGvNv30DwF4PwxWktvHCJK8o1WLzBbBhXhR/VgPr/W/HlkR/gi1UfcJm83jysjI/GRPRfofSdwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5634
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 09:06:59AM +0200, Jan Beulich wrote:
> On 05.04.2022 19:17, Jason Andryuk wrote:
> > On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith <dpsmith@apertussolutions.com> wrote:
> >> On 3/31/22 09:16, Jason Andryuk wrote:
> >>> For the default policy, you could start by creating the system domains
> >>> as privileged and just have a single hook to drop privs.  Then you
> >>> don't have to worry about the "elevate" hook existing.  The patch 2
> >>> asserts could instead become the location of xsm_drop_privs calls to
> >>> have a clear demarcation point.  That expands the window with
> >>> privileges though.  It's a little simpler, but maybe you don't want
> >>> that.  However, it seems like you can only depriv once for the Flask
> >>> case since you want it to be one-way.
> >>
> >> This does simplify the solution and since today we cannot differentiate
> >> between hypervisor setup and hypervisor initiated domain construction
> >> contexts, it does not run counter to what I have proposed. As for flask,
> >> again I do not believe codifying a domain transition bound to a new XSM
> >> op is the appropriate approach.
> > 
> > This hard coded domain transition does feel a little weird.  But it
> > seems like a natural consequence of trying to use Flask to
> > deprivilege.  I guess the transition could be behind a
> > dom0less/hyperlaunch Kconfig option.  I just don't see a way around it
> > in some fashion with Flask enforcing.
> > 
> > Another idea: Flask could start in permissive and only transition to
> > enforcing at the deprivilege point.  Kinda gross, but it works without
> > needing a transition.
> 
> I don't think that would be right. Logically such behavior ought to be
> mirrored to SILO, and I'll take that for the example for being the
> simpler model: Suppose an admin wants to disallow communication
> between DomU-s created by Xen. Such would want enforcing when creating
> those DomU-s, despite the creator (Xen) being all powerful. If the
> device tree information said something different (e.g. directing for
> an event channel to be established between two such DomU-s), this
> should be flagged as an error, not be silently permitted.

I could also see this argument the other way around: what if an admin
wants to disallow domUs freely communicating between them, but would
still like some controlled domU communication to be possible by
setting up those channels at domain creation?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:48:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:48:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299730.510863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1L7-0008Bw-8y; Wed, 06 Apr 2022 08:48:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299730.510863; Wed, 06 Apr 2022 08:48:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1L7-0008Bp-4y; Wed, 06 Apr 2022 08:48:33 +0000
Received: by outflank-mailman (input) for mailman id 299730;
 Wed, 06 Apr 2022 08:48:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc1L6-0008Bj-Qa
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:48:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5587f8d4-b586-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 10:48:31 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-cNl-F7O-OSGkop4H5o5EhQ-1; Wed, 06 Apr 2022 10:48:28 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4237.eurprd04.prod.outlook.com (2603:10a6:803:3e::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 08:48:25 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 08:48:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5587f8d4-b586-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649234911;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RVgAYc4pdH+DMQfBDziawv+0uiaE43o3Nnqr8kHEcz4=;
	b=k6GMmrB7CEtW3K3cAj3lGWntl/3Brs+5mO0Wm8f4jQWFkZL0XDZkhjdye9MZljcJBxRa/x
	qlffj2w7Pw6SJ+I3Y5VR42oNeGicVOci5J7SR07XR2jGwrlpe9n0NadNm7I3msQaI1gld4
	YvlnGb/SqzwUY9WR2L1cW1zBDQ9uhew=
X-MC-Unique: cNl-F7O-OSGkop4H5o5EhQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b46uv4LxBU6YsmgCsUcEoTw5hDnBAx0ywopOmJ31BiR00BM5E/ru827D5C0soZ3aHmYGROiIt4qmLD6DPifTY17PdIKv3V3ora39fARihnyOHrTQZC86Z1xC5WFVtv2WR5PEZYfi1VCLYH1fkNvGZPkT2KTIlyokY9o+rgtAHKxitFl9ZbByuaNGkv/6/eeArpkftZ2//bnUcwEMZ4aSEyzqAjJY6bVR/zwJzm7V3ujA7sIHVbyJ50POD83e1P3hftA8IpTmOOAlez4jZFx8lZ/OWUIC/i4ST6BT3HxAhfUV7rKsvf0kDERytQoMAmVeq/XYygUHyC6vF+q7QgBpQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bx4c/RgVuBr61y1OKVYyGwfuME8UXQZZHvxdJge+Vxc=;
 b=dJPgzwac3tWGrH0+Rbg8UBPQbSk8kR1z4h0R1XR2zNS2+WasQXr5ptdE7cJ6OdAUb+P/k1+qQGe6+HvkTXT+tf315MOPIRQZ3Boz3AxQP7zxTtXGquX8yt8AtAwKON6z1eCD6I4AeOleaVoXAncsFmbnzmSBAT/eIeZJVEpoQClBRpmxEI5EUZyIhSq8Oc8I+BxWzZ8yStlSqZIZ9j3/cYOxnqerkDaTQm0DI7GDJeDFD1v537KLM7jqilATi/er6zEm/K0FkbWZUZ8mPwfetuLT6G1v1o0s8S8E7f6mtJutoIAgI12F+HMUT0RjfZNLcoKfI/4HniNFdlo4841nag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dd4fce17-2625-603b-25d5-3a586a682210@suse.com>
Date: Wed, 6 Apr 2022 10:48:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Jason Andryuk <jandryuk@gmail.com>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Scott Davis <scott.davis@starlab.io>, Daniel De Graaf
 <dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
 <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
 <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
 <Yk1Ta9ujHBuj+svN@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk1Ta9ujHBuj+svN@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0046.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfa555ec-a665-4264-5b7a-08da17aa36be
X-MS-TrafficTypeDiagnostic: VI1PR04MB4237:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB423756494F8AD3434F2725D4B3E79@VI1PR04MB4237.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	esb9k3fDK9ChmDfYmI+7/p44n1cmztXSZ4Be5vHvwKcWqY6rc+guaeKrnUIaT1ESxXkZiUYEMS8HPpKsINexnKJL7UY2cqxbKxutXaZaDF7JW/CMr7Y29VhiwpZykCdOhNGKNY4qeY05y9+loM04okUSqdQSBl2FEuSFVJSh48TLwp2Sukv5Dk6pDbsTW0hfpgf9o/EWy1jYkmNrjvaf87lZVZhc7YpA+gu0UOh6pYMHid2fTkuOoMZOUi5xf/PChdLfGVzIpdpF7W16cKA8LWk7PaLBJSnt1p714TKjnVxmHdhjHaHPpmxGrsodoxZsk8eASfJ1FuWMzsh8ql3vIS0LMSWpYSQGj6xANVPfkXKM+nx9ONWTlTNdyk8d9xjell7cf2mbk8ZKqDtTQIivn3PRDjJUbiS16MEsqSiUw6ZOnLcEPQ2GBLL1/xhJ9HAghQXGyBVrZKz1oYx8mUupC4nbmzkRyGTDcbP90zRUoLoYyak8rYmwXmH+Dn5bn676LKu1gYKDCiEGzeDAtRkv0LJIMEp0cg6mjJNlsel/qlxNiDDOUj5NP5xJfn/3lG2myO5bnpDRof4n6jjdsneZDEmZyW2yyHshf1mX+SZxuOcpdTdeA04tNOZCfjhcDux3YH/LwsTyws/+nQFbtqZJBdOakCeytpB01+K5pi22fnyw3K2bCB2FnIUEoNTa2wzOtCuyySuWdOu3tHF3W/AzKv1wbis6x849FGTsyS2enejvPssY5IJZfWJrM5qy/L/e
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(86362001)(8676002)(66556008)(8936002)(6512007)(66476007)(66946007)(6506007)(53546011)(4326008)(38100700002)(31696002)(83380400001)(36756003)(6486002)(316002)(6916009)(54906003)(508600001)(31686004)(186003)(2616005)(26005)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hiMDMjJ4Ft/K3yA7VBrvbflw/JEq+gE/7SMMkZfdJiIFZWdnafm/9fdS/KWU?=
 =?us-ascii?Q?kYoGT4/FIWRpZ0yLhE5UOIoUmgX+6rOU4exezZhHw0K3Q3NrqcBDBvOiEVh8?=
 =?us-ascii?Q?t1D+YYtaLUZdPNHZXJjaT8604Wj/456gdxiKf+WJJc+8YhyLWMlK+FcxbL3H?=
 =?us-ascii?Q?JlMFkZzd3A0h7DpzEHYhkCrreqmTOW/gpWo94aG6bcTvXZkjxiGNhApAYkeM?=
 =?us-ascii?Q?DvO6mKD8YnINHagugz2MEmy6o+lLxNx7ulrY2+X73VV/dk3ukF/+sF5gVMDQ?=
 =?us-ascii?Q?eQTt41GAjiRKgyhX8xOZyansh4aWtleWuKiKky5HLR87Oe7dsYYANj/8w+1e?=
 =?us-ascii?Q?6v/dCjs7pIHE62Edj0FEuKdZZYN1t3XpkLDQ9C6NwYGnqF29DcCEPYf31oPJ?=
 =?us-ascii?Q?XoY0zL/+C0KGoQKFXX8x0t37z2znJQr952vbjhOFNn2r8EueglwkW2Q5j0Uc?=
 =?us-ascii?Q?ydwfmiXzayvB+rv0KyvFmeKDsvD+RUQLZKCPvA1J5dDJMdYGdg0Q0pMk3pEk?=
 =?us-ascii?Q?V3Yz4UcTsQUw5s1doOB0fwzVa40RpT1k6uxNLTo6fUtFaHJNpWPSnRWmkGPs?=
 =?us-ascii?Q?JZaC8ZtIvwfBVPCCjs618Gt9XQPORsXtHZ8xX9pBP+nJHoc5H6JjIAmH93c/?=
 =?us-ascii?Q?MMxKjnpoUwEIl28euv/y2eDrgXSk8VoItMN558XS1k+eY2OIFb2JtvnLunbg?=
 =?us-ascii?Q?hOiKONH1aY12vOPKEgu78LPuXu/Ltic/X9SZe6kgG9C9fUYlrtmYqfl6VKcV?=
 =?us-ascii?Q?Y/PPqQfWNL4wUDFyA9ZwxsaS0jsFk+sjGnF3mUvbWKG4XuANShYQuRXld7wx?=
 =?us-ascii?Q?h3c1sU/gdZe8lFA9L9fa1vKSUFz0mQ368HDG8nmP2FsitbjI66lb22QVh9Lg?=
 =?us-ascii?Q?APLdWt+YpYfZAeV/xxCinSVDscI8ZpvXTfKZmgkx0AbibIwL88bpb05VTLXm?=
 =?us-ascii?Q?hYSRUITjvN4AoMY+YGihJhOGqj7MAT/JZSYgzyqqYsKTkhNjWuEh5eL2jrSi?=
 =?us-ascii?Q?sJR0VP8vh6U3TcgN0956IkHFOvJDzdl4139M0YEQT+PaIN2WsdqkLJMtL0je?=
 =?us-ascii?Q?3xE6yyeqqcMXxYwcPyrBhOK1Fp1yhzUZmxJjB9Dmau3awW4FBu2cvFvjuTxt?=
 =?us-ascii?Q?v/Nk86r/AbY0n7qC9zQQ8QuX5UvPUT9jx3Z5tCwaanxP4X51yu1S3ZuB2+5R?=
 =?us-ascii?Q?efPAf/nQPFv0F+wd1yt9HoSj9z0aZ8Bit1Bi/NEhB4E8P0xpjHAeTfnU20Pk?=
 =?us-ascii?Q?Y7XPyzNjgz+atZS7lJShsvfJ6rFa6F5Dy8lrmh05tEM68XjB+nZG1XVYzKVS?=
 =?us-ascii?Q?1O8MuKJp93u8c5k58KpyYHiwUPvnFy+Y2D0nANyzBGBfQCADo0/3eAhrlxH4?=
 =?us-ascii?Q?1KTiHeu/yDVjHz1rfwCcLsGPx709VrKhiViNsJDQk984+1W0g9mEDqE6knz2?=
 =?us-ascii?Q?SOfoaB6JdZmOQiK2M2rsmV48WrVAhQgmPL63osfkgnWmvf9K78Cc0d/FbRkn?=
 =?us-ascii?Q?ZL+Emym0e6aQVAafnWk4uRZbUzy7KsbIYanjNlJn8x6W6uZQBrDNP4Pkbj/i?=
 =?us-ascii?Q?JhgQXS6MI/TV5tRGap1BH84Eu7zIFmYeFOPxbfeJVbGHKVvsVpWpiLUaqtYM?=
 =?us-ascii?Q?iZAn/fUBJ5oqOUuP+fgXXaSTFU9vO4bRWNJqMUl6wCqT4Pe0w502HLCweq5o?=
 =?us-ascii?Q?udP3Kf4IwEgjIXiJsQWDgSNsBWi2ttBkKwGzMUzlrjYaDRWK3xY9xeYVdRqC?=
 =?us-ascii?Q?OFQ2AGIJEQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfa555ec-a665-4264-5b7a-08da17aa36be
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 08:48:25.8232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: asP7MgncAMIt+EjC7ItmYfZ+VxIz2Qzmi17Cpxbzag4F+rX/ihFIAJo2a6pUAnbrrVwl/JOm/6uy0aDbdehJ8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4237

On 06.04.2022 10:46, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 09:06:59AM +0200, Jan Beulich wrote:
>> On 05.04.2022 19:17, Jason Andryuk wrote:
>>> On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith <dpsmith@apertussolutio=
ns.com> wrote:
>>>> On 3/31/22 09:16, Jason Andryuk wrote:
>>>>> For the default policy, you could start by creating the system domain=
s
>>>>> as privileged and just have a single hook to drop privs.  Then you
>>>>> don't have to worry about the "elevate" hook existing.  The patch 2
>>>>> asserts could instead become the location of xsm_drop_privs calls to
>>>>> have a clear demarcation point.  That expands the window with
>>>>> privileges though.  It's a little simpler, but maybe you don't want
>>>>> that.  However, it seems like you can only depriv once for the Flask
>>>>> case since you want it to be one-way.
>>>>
>>>> This does simplify the solution and since today we cannot differentiat=
e
>>>> between hypervisor setup and hypervisor initiated domain construction
>>>> contexts, it does not run counter to what I have proposed. As for flas=
k,
>>>> again I do not believe codifying a domain transition bound to a new XS=
M
>>>> op is the appropriate approach.
>>>
>>> This hard coded domain transition does feel a little weird.  But it
>>> seems like a natural consequence of trying to use Flask to
>>> deprivilege.  I guess the transition could be behind a
>>> dom0less/hyperlaunch Kconfig option.  I just don't see a way around it
>>> in some fashion with Flask enforcing.
>>>
>>> Another idea: Flask could start in permissive and only transition to
>>> enforcing at the deprivilege point.  Kinda gross, but it works without
>>> needing a transition.
>>
>> I don't think that would be right. Logically such behavior ought to be
>> mirrored to SILO, and I'll take that for the example for being the
>> simpler model: Suppose an admin wants to disallow communication
>> between DomU-s created by Xen. Such would want enforcing when creating
>> those DomU-s, despite the creator (Xen) being all powerful. If the
>> device tree information said something different (e.g. directing for
>> an event channel to be established between two such DomU-s), this
>> should be flagged as an error, not be silently permitted.
>=20
> I could also see this argument the other way around: what if an admin
> wants to disallow domUs freely communicating between them, but would
> still like some controlled domU communication to be possible by
> setting up those channels at domain creation?

Well, imo that would require a proper (Flask) policy then, not SILO mode.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:55:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:55:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299739.510874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1S4-0001HD-7j; Wed, 06 Apr 2022 08:55:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299739.510874; Wed, 06 Apr 2022 08:55:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1S4-0001H6-4R; Wed, 06 Apr 2022 08:55:44 +0000
Received: by outflank-mailman (input) for mailman id 299739;
 Wed, 06 Apr 2022 08:55:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc1S3-0001H0-6R
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:55:43 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5498995f-b587-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 10:55:40 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5498995f-b587-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649235341;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=gcZAu2rAypNKzN8D6xyqucJoqCvgO9wQZQKjYQBqA9g=;
  b=Dhjqh+rVfMP1V9Z7o27cZQWxxxnKOn12a9NPUD8/V5Ki9AsGsUuQ3SxO
   34XReBIn0uXylBp4ZK8Ay1nCRT9sBYcQiZgBYa0EytH112EUkL4GTFdwt
   nJ1/YFyPFP7k+maNsV4mml0pD4vSN/uRxdmsCnr+zx1WY6Q1Hc/1nDRcn
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68032473
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EBmAA6hf8dwxIK3wXuz3A401X161QRAKZh0ujC45NGQN5FlHY01je
 htvDGHUMv+CZWGhedAlbIqz8RtU6MSEyNJhSAs/riBjF3wb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vT4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQ0lH/T1yPpBaAIGQjB9P/NDp/ycOWfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiOP
 5FDNWU0BPjGSzdhJ1lHJ9Fup+OXr3/VLA1z8liuibVitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoVD6ak++V2xVSfw20VIA0bU0Ohpvu0gVL4XMhQQ
 2QW8Cczqak59GSwU8LwGRa/pRa5UgU0AoQKVbdgsUfUl/SSs13x6nU4oiBpYtAH7fZmW2ARz
 QHYjtDrWzkw8+aNVifInluLlg+aNS8QJG4EQCYLSwoZ/tXuyL0OYgLzosVLS/Ds0ICscd3k6
 3XT9XVl2e1P5SIe///jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5XGhAztJcvU/MBofAnrNOv3jxpiGGeB6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNYCrzPfMnM9LhVJ9CIU3c+TLNDK68gj1mOMYZSeN61Hs2OR74M57FziDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r
 ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/LbfZeFc5QT1/UJc8A9oJIuRYokicrc+Rl
 lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEZj5EB1BLjV6T0Zoi
IronPort-HdrOrdr: A9a23:c9sGp6Bus8yLUB7lHehIsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M
 323Ls4m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUbqFh/dL5kUUtDPpZ1fSKWMB2FffueChPbHbzYfJt3T04l7aSHp4kI2A==
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="68032473"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l3HmbBaIMiLQN1DhDuGxdDH2Fa2dbVx0seG+nNeoYA6/ZE5af3qguAXKBfWHM9H8RqP4eFaxpWRHFtFLd+UzQfSHA/G5IZaJVanbIFsCfqm+CHBd3m3Q7ZPrcWeaqSXXKJXqQg1mOGT/RYVm+wACAZAXPlTI7cCeJbrV3dWFnkpzzU/WbLW1CgmvpRk3w9YOafiyPK998Ge2OAKccrbmhsytT88PaNVW9Dj/bUByxVHCel7SrIl/S3z0wpEIOd8NYKfYtlUtE+oFn2/bYVLdkVlAqBo/OwwR4xTh/hlSUx0d5mgzAcGXCkGd4MIL35o/uJ1DX0zj2zj8t9w50b7wog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=y2+pUYa1hWd7qpDkOptdaNRGqT+vbJP5b2ZfZTlomuA=;
 b=MV90zGmQBNoYIox6a0rsryof1RXf7kiE4IqkNzit6auePzxcfyWY2UXli6BXL5fwHPnNV+EDgs0CSHbeK9dMKBeQ76KNInQXimxPHSnX20UmOBMIuqXTne5nlTWTom1XU/rAhzu8vdh/hGZAj1gBSnyXwPjs0KlXAIuuisSdEzK1g7RG3Bac+2d7aY1MV4ZXi9nLSrtD+wDIG2o0/unbfx7cKnynd/Xhdo09EG8gn49naiTr9PJN5kx8qthH+nfxVM4UoV/KSgJXCD03v555Oq3S8aKb5JKo+av7hOTBg/V/Lz/v2bTVhY5qrMnaRWD7c9lNIsHoH/RFBhDVY5ExJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=y2+pUYa1hWd7qpDkOptdaNRGqT+vbJP5b2ZfZTlomuA=;
 b=kapDe1K85H/dbv46h/tWNm+vzma1jwU2p33uh3LHDx2de39sIXwB3tvJXCjZBNjRZkP5+jjvzQFKZIu3W334S3Q/vlZj7RmYjfWKXNerUruIKmTuKCuQThamGCT357QWaOF0qK/gKVEkvDsvTDl3Hn3qj3PsZiLw06ykRPVJ560=
Date: Wed, 6 Apr 2022 10:55:31 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, osstest service owner
	<osstest-admin@xenproject.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [xen-4.14-testing test] 169170: regressions - FAIL
Message-ID: <Yk1Vg4ckxKzJbXwL@Air-de-Roger>
References: <osstest-169170-mainreport@xen.org>
 <d0e84ac8-308e-1784-982e-271705c13b7d@suse.com>
 <afaaf270-27d4-39af-8125-6d622801073d@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <afaaf270-27d4-39af-8125-6d622801073d@citrix.com>
X-ClientProxiedBy: LO2P265CA0124.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9f::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 493db85f-9e0f-426c-58c2-08da17ab3701
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6779:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB6779766B37B01217477CB0C38FE79@SJ0PR03MB6779.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1fcwT20phIL2EQr26CWsDdmZsIxl++39GcVUroe73rXG4V+ojbQDkDaod+NNLnLPzb+Td8JiUoepCaBBr7dxFMf2XJ2qxHjoLnFYFN/nepQLhn97nuNrEPHXayiholTtJ5UuVhEFkc/iaP3YkXKRYcB2PshnkW6L16HSUnjG9lHbD49uGJifiYb0kUWrFwiotwV8sY1iLG5eOlpGdY9iC5gxgQJgI+qDpedeM9MYbQ0TimTQaujbenl8zOF6YZRt2Tvp3s25H4z+Fhyl2keXZHd+IXqEHEIPyObIQNTiNTPXVm8Jq9Mr9xm0BV/OyVIXgDUO3sPuR6UYMUcK8eXn4MlZDQVpnQX+eHsJWin8KOC6exmVb2dXuTcQfyxAO+sgLMAjpoUfk7Gq2JkIG78RYA4Bpm146+ZW9oqc3MhS3j886S/Cv6q4q6+PY1B1/DGAUdEoS4iGbdMQnbLQ02xGyT5h9jgvTfltlOXah0+on5SX+Akmio9Cs9BlvC4g708PXkDbLwMuCTsqraMJ2ZUmQtys/pOH0HLMiUr4ag5JJ8GRvmu4swQ0rnlfJ2pz1XwJc1SpmxlyHqTpbeZnCTmLEOy0vFs+nFbW7KadTnCMyyp6+RibjLHkiLQHyH0R+PNJulGYHm0yjH/quB+4gzOOBwanz+pfJgd4TnGm+FlaEqzhA46Fkq68u4AKgfpyZnXdQH26BINlbuQybC84arLUScwe+w4CuwAh46H/dtXCwsw=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(107886003)(966005)(33716001)(316002)(66476007)(66556008)(66946007)(26005)(85182001)(186003)(6636002)(83380400001)(4326008)(6862004)(6486002)(82960400001)(8936002)(6506007)(5660300002)(508600001)(6666004)(54906003)(2906002)(9686003)(86362001)(6512007)(53546011)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkNtZWZGSCsxL3pZeWdyTGxyekVEeHNhZUVzMzM1a2VodlpxL09CeUc4OTBw?=
 =?utf-8?B?a1ZaeVg3ZEsyWGkrVEZydW1FQWZidzN2L3ZjWXNJUTZnSzRpVGxVTHVqMlVw?=
 =?utf-8?B?YnZhdTN2TWtKM3VMWGUzMW5KK2FWY2EwOHkweXgwYzlTN282TEdHSzkzNWtB?=
 =?utf-8?B?dFFGdmFHdmwwbjhJeGJvMjZKMlJXTm5XdlFXemoyUnpWOWhaSzU0d0VUU2ty?=
 =?utf-8?B?U0NDNzVBYkdTbTZWM2Z3bTU1cXloUzFqSG9LRVF5VU15cC9raVlCMm15bjI4?=
 =?utf-8?B?VllBdHNtZWF5RzdtWGlYOGt6bWZvWnphRHpveVdJTE41Y2xXWnVhMmJyY29Z?=
 =?utf-8?B?TkxQNks3cGx2R29RMkI4dncrTk5xVEJibHV0MTA1QzdxWmdDeTBsYll3VGlB?=
 =?utf-8?B?cWpQNzF2NVNIaXdSUGRvelVaRGovMjFPMG9SSjEwaDJFQk5ybHJoQWZEVWpQ?=
 =?utf-8?B?aGNqazQ3VkVyVUZGNUswSDI3SllIOEhkaUZtUVRpRXIyWm9qY094RlZGNXNv?=
 =?utf-8?B?NDRJMHZBbm92TU1nQkNHL0MralNHeUpPVGJoQm45d2dTbHBTTnU0OVp0Tklu?=
 =?utf-8?B?RkdZTGpYZkFCc0EvUFBJY3Q5KzA1Z3hnMm5GOEVDUm5wWnRyMjY1Z2QwRGc1?=
 =?utf-8?B?VmNEclVZVDZkU3Z0RWRhUCtvYjU0Qkc4VitINmRRbjFSZHE0ZUdqRnNLNE9J?=
 =?utf-8?B?UjAzZDBBNHp1YmFYQ01uL21RNzJGTnhkcVFzTTZsSU5NM2h6MlZZZmFkOWRq?=
 =?utf-8?B?WGJSVyt4bGxUazBicElVQ2Z5aGhFdEd5OTZ4VzFML0lEcmM0d0RtV21nRUNp?=
 =?utf-8?B?WWtCZWJ6bHc3dVVGZFZMU2s4WkZSYkJCakRPem9TTHhZTkpKTFhIOHh4SVA2?=
 =?utf-8?B?NHVoSGczVm9iUVJUbU1HTTNjVTJWVkZ6M3dVU2xKZkt3V0k3Z2twOGdFZDJX?=
 =?utf-8?B?eitLVDdvUWg4VTZwcWhpN0tpZE82ZXduK0hYMVNJL1ZLSWJpbEcxN0dqeUhF?=
 =?utf-8?B?WlQ4cC9pdjQrREFFanZYalRNSlNRUlFOaHdPQ200dnpxUlUrUGo3cmpTVmxQ?=
 =?utf-8?B?ZnRYbzNGbS95cmJtQ1VDSEVSbHNLSUloU2NMd01UL0NoZUJSYW1INmpOUXY4?=
 =?utf-8?B?SjVUOThsWGQ4N25sUFVnMTBGL2ZIb1VuSjRibjJKVENaajhlaUhSRGVvNkw4?=
 =?utf-8?B?WkdPZmdXek9zS0ZtVjJnVm9LeW1PR2NWS1psRDkyYmgvbDMveUNzOHF3U0ZK?=
 =?utf-8?B?REhLaXVydWtKNndnbUErbXp2N1IzY0R6aFhxdnRBR1VKaUowbGhpbWFaMHQx?=
 =?utf-8?B?OTRnNGRsS2xTZE5vWVJTNWNFME16cXZFOS82TWhCVzBodkk4VTFYNDVmaTVn?=
 =?utf-8?B?MUt5cnF1ZThVbGgyYTBqQ2FFMVhHKzV1TmVTZm1CWVpOWlJoZnM0elJpcldq?=
 =?utf-8?B?UXlXdHpqNENRNnZiR2hvamE5elcvQnpUU0JVM0lUMERNTmpSM1Q4WnpheDNU?=
 =?utf-8?B?cTcrYjZVc25Pam8zd2hSait1bzFKOHBtcHVNUkRzYVgwdzVtZXlOMzRSRVhr?=
 =?utf-8?B?MGhURXJSbXVmY2tZVzYreTVEc0FuQUprNkhYUkpXWmpBZTQ4ZUNQNG0yakhW?=
 =?utf-8?B?TW1FY2RqdnJPNlo0MmJvbFFUQ2tBVUJFbXhXb3MvbXB6bVNKMy9XOWV4c3RX?=
 =?utf-8?B?ak1IZ0pIdFl5dnVVNlhOMnRKNHJ4UVFQOFVqM2p6QmNvK2psaWl4SXM5SzlY?=
 =?utf-8?B?cnhlVWpHUmtQMHpxVUI5c1ZJZFUrMDJJeWdZRkZubHdEVzdFREtiK1E3Nnln?=
 =?utf-8?B?NmJ5U2JHVTVMN05JcTN1bTJ0bStIN2JLZGxkVHE0VXNPRXpxTSsxMG1IRmdL?=
 =?utf-8?B?SDlxN0h0Y1JHYWtHTm54SlZTcU9tcmZCeUZSenUzY1lmWlFnK0MvcVVKZHND?=
 =?utf-8?B?cUI0SUhUZUo4M0l0Nk9OVGZaWVhSSHUyVEcvSWgvL1lCbzNCRktHQnVxKzMy?=
 =?utf-8?B?OU9hc0xINEpyUEkvTWNkMmVndjh2U3RFT29WYi92R2hkbDBiVTFpN0NPNDVx?=
 =?utf-8?B?S1dNSVoyTndRbVkveVV2cHMzL2JFT1ZpRDI1SDhrTlJ0bVdudXBZL3ZKc2U3?=
 =?utf-8?B?OUVTNjc1QU80aERKNGZFMUl4a1JvK0ZTNXZ5cUowaENFQ3loRlhrelQ2dm9q?=
 =?utf-8?B?SDQrem5wa1QyZkd1aUMvYjZXSDdVL3ArSnRtcTQvYnVZVW4ya3dPVXFaM3cx?=
 =?utf-8?B?UDdtNE1pdWd1R0FVTHB5c0llK203RTc5bGQ1QnVJZnBDenJzYVMzaHlrTThq?=
 =?utf-8?B?OFk5MTkwWDdZTk1naTdpOXA3S3hIRVNVTzBPSytLYlBaSkVFOTRQMWZJNzJi?=
 =?utf-8?Q?/zDPMD81+Yrm+1ac=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 493db85f-9e0f-426c-58c2-08da17ab3701
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 08:55:35.7746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mjhL785+WwOr5oBDrhsfT0TFS4XY8HmTFwAiz/i8jfnapg4fxfDGMrKe/OaxjVTWlIpjP3onIexPrYa2tnHcYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6779
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 08:45:04AM +0000, Andrew Cooper wrote:
> On 06/04/2022 08:22, Jan Beulich wrote:
> > On 05.04.2022 16:53, osstest service owner wrote:
> >> flight 169170 xen-4.14-testing real [real]
> >> http://logs.test-lab.xenproject.org/osstest/logs/169170/
> >>
> >> Regressions :-(
> >>
> >> Tests which did not succeed and are blocking,
> >> including tests which could not be run:
> >>  test-amd64-amd64-xl          18 guest-localmigrate       fail REGR. vs. 168506
> >>  build-arm64-xsm               6 xen-build                fail REGR. vs. 168506
> > Urgh:
> >
> >   CC      hw/virtio/virtio-bus.o
> >   CC      hw/virtio/virtio-rng.o
> >   CC      hw/virtio/virtio-pci.o
> >   CC      hw/virtio/virtio-mmio.o
> >   CC      hw/virtio/virtio-pmem-pci.o
> >   CC      hw/virtio/vhost-stub.o
> > cc: internal compiler error: Segmentation fault signal terminated program cc1
> > Please submit a full bug report,
> > with preprocessed source if appropriate.
> > See <file:///usr/share/doc/gcc-8/README.Bugs> for instructions.
> > make: *** [/home/osstest/build.169170.build-arm64-xsm/xen/tools/qemu-xen-dir/rules.mak:69: hw/virtio/vhost-stub.o] Error 4
> >
> > If this is going to recur, I don't see what we ought to do about this.
> > This doesn't look to have any relation to the recently added two
> > commits on the respective qemu stable tree.
> >
> > However, if this wouldn't recur it would be similarly alarming: That
> > would suggest the build environment to not be stable.
> >
> > Thoughts anyone?
> 
> The version of debian was recently bumped to work around the usual
> OSSTest issues when it gets too out of date.  Guess we picked up a new,
> broken, compiler.

I think the compiler is not tied to the update.  The update I did last
week just rebuilds the network install media to use a new kernel,
because our installer kernel got out of date with the modules on the
Debian repos, and thus loading those would fail.

However the install media doesn't contain any build tools, so we just
pick those directly from the Debian repo (using a cache, but that's
not tracking a fixed version of the package repository).

I guess we will need to see how recurring this is, and whether we
should take action.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 08:58:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 08:58:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299743.510885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1Ux-0001y4-Lb; Wed, 06 Apr 2022 08:58:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299743.510885; Wed, 06 Apr 2022 08:58:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1Ux-0001xx-IY; Wed, 06 Apr 2022 08:58:43 +0000
Received: by outflank-mailman (input) for mailman id 299743;
 Wed, 06 Apr 2022 08:58:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nc1Uw-0001xr-4w
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:58:42 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc1Ut-0008S3-Q6; Wed, 06 Apr 2022 08:58:39 +0000
Received: from [54.239.6.190] (helo=[192.168.16.200])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc1Ut-0001om-Fq; Wed, 06 Apr 2022 08:58:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=zw9sDgP/hpxqMhcvM5+bBVpXCVWiSSyurTkeJv1dseI=; b=v2dzbec3pkrX/SMHf1Juy50re6
	n7c0vJs/y6wdvemgT2ydI5ZLWoEEHpJ/kO5shq66w9u3bChdwKfOO6g65KILWMTiY0xA1rL1ofZlY
	x2wR6TcDi9c4OUAEWFFiplOkN4G054CAj+9lcAyaqxs6sdQTWObwsK85brqsno8f/0Xg=;
Message-ID: <7dc5887a-461d-506d-ce4e-fbcb7e5cb43e@xen.org>
Date: Wed, 6 Apr 2022 09:58:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
To: Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com,
 Volodymyr_Babchuk@epam.com, Luca Miccio <lucmiccio@gmail.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop>
 <20220401003847.38393-8-sstabellini@kernel.org>
 <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org>
 <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
 <alpine.DEB.2.22.394.2204051758250.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204051758250.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 06/04/2022 03:21, Stefano Stabellini wrote:
> On Fri, 1 Apr 2022, Juergen Gross wrote:
>> On 01.04.22 12:21, Julien Grall wrote:
>>> This would be a problem if Linux is still booting and hasn't yet call
>>> xenbus_probe_initcall().
>>>
>>> I understand we need to have the page setup before raising the event
>>> channel. I don't think we can allow Xenstored to set the HVM_PARAM (it may
>>> run in a domain with less privilege). So I think we may need to create a
>>> separate command to kick the client (not great).
>>>
>>> Juergen, any thoughts?
>>
>> I think it should work like that:
>>
>> - setup the grant via xc_dom_gnttab_seed()
>> - introduce the domain to Xenstore
>> - call xc_hvm_param_set()
>>
>> When the guest is receiving the event, it should wait for the xenstore
>> page to appear.
> 
> 
> I am OK with what you wrote above, and I understand Julien's concerns
> about "waiting". Before discussing that, I would like to make sure I
> understood why setting HVM_PARAM_STORE_PFN first (before
> xs_introduce_domain) is not possible.
> 
> In a previous reply to Julien I wrote that it is not a good idea to
> set HVM_PARAM_STORE_PFN in Xen before creating the domains because it
> would cause Linux to hang at boot. That is true, Linux hangs on
> drivers/xen/xenbus/xenbus_comms.c:xb_init_comms waiting on xb_waitq.
I looked at the implementation of xb_init_comms in 5.17 and I couldn't 
find out how it would block here. Can you clarify?

> It could wait a very long time as domUs are typically a lot faster than
> dom0 to boot.
> 
> However, if we set HVM_PARAM_STORE_PFN before calling
> xs_introduce_domain in init-dom0less, for Linux to see it before
> xs_introduce_domain is done, Linux would need to be racing against
> init-dom0less. In that case, the wait in xb_init_comms would be minimal
> anyway. It shouldn't be a problem. There would be no "hang", just a wait
> a bit longer than usual.

 From my understanding, Linux may send commands as soon as it sees 
HVM_PARAM_STORE_PFN. With your proposal, this may happen before 
xs_introduce_domain() has updated the features supported by Xenstored.

With the recent proposal from Juergen [1], an OS will need to read the 
features field to understand whether Xenstored support the extended 
version of a command.

This means, any commands sent before xs_introduce_domain() would not be 
able to take advantage of the new features. Therefore, we would need to 
wait until Xenstored has advertised the features.

With your approach, the wait would be a busy loop. Although, I am not 
entirely sure what you would be waiting on?

But if we use the 'connection status' field, then you could just delay 
the initialization until you receive an event and the connection status 
is connected.

Cheers,

[1] https://lore.kernel.org/xen-devel/20220316161017.3579-1-jgross@suse.com/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:00:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:00:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299748.510896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1Wa-0003Ks-14; Wed, 06 Apr 2022 09:00:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299748.510896; Wed, 06 Apr 2022 09:00:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1WZ-0003Kl-Td; Wed, 06 Apr 2022 09:00:23 +0000
Received: by outflank-mailman (input) for mailman id 299748;
 Wed, 06 Apr 2022 09:00:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ITwm=UQ=gmail.com=trigger.huang@srs-se1.protection.inumbo.net>)
 id 1nc1WY-0003Kd-Fd
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 09:00:22 +0000
Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com
 [2607:f8b0:4864:20::534])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fcaae1d6-b587-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 11:00:21 +0200 (CEST)
Received: by mail-pg1-x534.google.com with SMTP id k14so1721165pga.0
 for <xen-devel@lists.xenproject.org>; Wed, 06 Apr 2022 02:00:21 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fcaae1d6-b587-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:from:date:message-id:subject:to;
        bh=4ai1600hTFj5xUYHJYsI1cDmlSJc0jGDB27PJST9lyM=;
        b=Sf7ygPQ1D3qLCwUml+T79i2dDew+Xiz82oPiL/5d8eeevaYUZzvDQDXhSQ65eqeAc4
         oUgbyWRKdIUqSHmsRpxm+g0sLGJf5ERMzeER7RusATjSGxIhwydjfp5wIsK6ZRg438Ou
         AdRgDJShdP8t58+s2jZYgUqKpMNkraWwohOZ80ZBpM+pzS58ckWvCmF0wVRwECocpNs7
         C3ED1PikWn7jvS0t2zjVX3gF7LJBEKmuEkR+0gKUErMGkGk8GROzCz8wrYuplvxbTMjz
         2+vwhUagZzC74aAG4z7nPbMF8+Q5OAvPjl7yFvGeqAShA8Lhkz1Uj5hZEu8pYaMV5Oim
         0KnQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=4ai1600hTFj5xUYHJYsI1cDmlSJc0jGDB27PJST9lyM=;
        b=AYuV9LwxXNs65x+mSqEL6IgGZ07XhBNFmqTJ3QntT+4mY+qkYe02pR17GqyQn5J9nZ
         UBbAtucSr+oLazRh10QJvwDhj8Xi/cqod79R/SOptuQxO82JnBy/u+eBhk38W2mLR5SQ
         5KQsp3PBsDXiaF+KGzdJzv1EemWh2TXHl5zfgMfP88Iq64jiuDEUlZoexkLHb/OxLEHJ
         QIqO9Tz/6snyNJB5GSPSZvmadjA9VOuR2eT+NCFRfLFaXVjCeeDTuDAyuJRXN6P/i1zt
         8mlHtdsJb6tGs2xo37QgL+Wua+IXI65kbhEPJJV10GPWLkggl0w38KdKhN/QoHXXH91U
         rrkQ==
X-Gm-Message-State: AOAM533VcZaxi+OiCdkrsc+qZTfdFCQeGou3VZaAHbkAPrFIImLymvXg
	iafizHXoNtJ5N5Al3Y7UawFyAeUt05oJ5XVBxBB7ImLnMWE=
X-Google-Smtp-Source: ABdhPJzstcNLwZUV3HSgjQatn8l2ZaB1ToeZspbdOC45ca3mBPRWEtVWcEea/32jd3dh3zerB3fjfpEjJFBt+h+IBm4=
X-Received: by 2002:a63:8c5a:0:b0:387:6367:c08a with SMTP id
 q26-20020a638c5a000000b003876367c08amr6281876pgn.155.1649235619821; Wed, 06
 Apr 2022 02:00:19 -0700 (PDT)
MIME-Version: 1.0
From: Trigger Huang <trigger.huang@gmail.com>
Date: Wed, 6 Apr 2022 17:00:08 +0800
Message-ID: <CANH0Q9k=csOJktNmr29XhQRC0niBTBU0Z_J=qKoAAV9u2v2oWA@mail.gmail.com>
Subject: qemu-system-i386: -mem-path not supported with Xen when try to use
 memory-backend-memfd to share the memory with external processes on qemu-xen stable-4.16
To: xen-devel <xen-devel@lists.xenproject.org>
Content-Type: multipart/alternative; boundary="000000000000453a6105dbf8974d"

--000000000000453a6105dbf8974d
Content-Type: text/plain; charset="UTF-8"

Hello,

The QEMU Documentation suggests to use memory-backend-memfd to share the
memory with external processes, so I  add the following patch to
libxl__build_device_model_args_new() @ tools/libs/light/libxl_dm.c

*+               flexarray_append_pair(dm_args, "-object",
"memory-backend-memfd,id=mem1,size=4G");+
flexarray_append_pair(dm_args, "-machine", "memory-backend=mem1");*

However, I always got error '*qemu-system-i386: -mem-path not supported
with Xen*'
After check the qemu-xen source, the error is from
'qemu_ram_alloc_from_fd() @ softmmu/physmem.c



* if (xen_enabled()) {        error_setg(errp, "-mem-path not supported
with Xen");        return NULL;    }*

So, any suggestions on how to enable  *-mem-path* on Xen?

Thanks,
Trigger

--000000000000453a6105dbf8974d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hello, <br></div><div><br></div><div>The QEMU Documen=
tation suggests to use memory-backend-memfd to share the memory with extern=
al processes, so I=C2=A0 add the following patch to libxl__build_device_mod=
el_args_new() @ tools/libs/light/libxl_dm.c</div><div><i>+ =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 flexarray_append_pair(dm_args, <span sty=
le=3D"color:rgb(0,0,255)"><b>&quot;-object&quot;, &quot;memory-backend-memf=
d,id=3Dmem1,size=3D4G&quot;</b></span>);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 flexarray_append_pair(dm_args, &quot;<span style=3D"co=
lor:rgb(0,0,255)"><b>-machine&quot;, &quot;memory-backend=3Dmem1</b></span>=
&quot;);</i><br></div><div><br></div><div>However, I always got error &#39;=
<b><span style=3D"color:rgb(255,0,0)">qemu-system-i386: -mem-path not suppo=
rted with Xen</span></b>&#39;</div><div>After check the qemu-xen source, th=
e error is from &#39;qemu_ram_alloc_from_fd() @ softmmu/physmem.c</div><div=
>=C2=A0=C2=A0=C2=A0<i> if (xen_enabled()) {<br>=C2=A0=C2=A0 =C2=A0 =C2=A0=
=C2=A0 error_setg(errp, &quot;-mem-path not supported with Xen&quot;);<br>=
=C2=A0=C2=A0 =C2=A0 =C2=A0=C2=A0 return NULL;<br>=C2=A0=C2=A0=C2=A0 }</i></=
div><div><br></div><div>So, any suggestions on how to enable=C2=A0 <span st=
yle=3D"color:rgb(0,0,255)"><b>-mem-path</b></span> on Xen?<br></div><div><b=
r></div><div>Thanks,</div><div>Trigger<br></div></div>

--000000000000453a6105dbf8974d--


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:09:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:09:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299752.510907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1fI-00048n-TA; Wed, 06 Apr 2022 09:09:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299752.510907; Wed, 06 Apr 2022 09:09:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1fI-00048g-PQ; Wed, 06 Apr 2022 09:09:24 +0000
Received: by outflank-mailman (input) for mailman id 299752;
 Wed, 06 Apr 2022 09:09:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc1fG-00048Y-Kq
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 09:09:22 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3d08103d-b589-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 11:09:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d08103d-b589-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649236160;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=+/q8LMKWQBwo7vUKafDQSgSd5VockUhKFgX9yElxyuY=;
  b=Z2aQgEbPZPSpvEeIBn1o8bCGSB+3Nlz1Dcjdvr750dG7Kd0YA5zywlUu
   HBPQ1MG0PVTjLGw04x9OSon9l1hXzrTjEHG9KMoRVU34G0RIpC34RvKGb
   naJrYOj43ZrdH7OyAPgUd4BjecYoI/UVwxSo8ANIhV6woUyw8C00s7ZUo
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68150733
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aDzzTavCmvGYf9ESg0eskg1/TOfnVLReMUV32f8akzHdYApBsoF/q
 tZmKWCBa/+OZGXwfIwlad7lpEtXv57Rn9QwS1Rqry1jQioS+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/V5
 4uryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8MHPTKl9UCVyVUOHxjGbBF0bP/GmGw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AN
 5NEMWU0N3wsZTVLa3MIBbMfwtuaxUj8KH5cqXmo/bcetj27IAtZj+G2bYu9lsaxbd5emVqE4
 G7P4WXiKgoGPcabwDDD83XEruPAkS70Qos6CKyz9vkshkaagGMUFnU+WUOgpPilima3Q99FN
 1EP4S0qsLQz80qwCNL6WnWQonSJoxodUNp4CPAh5UeGza+8ywSQAGQeXyNCQNMjvc4yAzct0
 zehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi+QPu6lq0EiJFIw6Vvfo0JulQlkc3
 gxmsgAbpewVgv8U05m31g3apy+vj5TxdRc6s1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr
 EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM
 B6K4lM5CHO+0RKXgU5Lj2CZVpxCIUvIT42NuhXogjxmOMYZmOivpnwGWKJo9zqx+HXAaIlmU
 XthTe6iDGwBFYNsxyesSuEW3NcDn35ilDqDGcCrn0T4itJygUJ5r59fbjNiichjssu5TPj9q
 Y4DZ6NmNT0BOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+zvlOQwkc5wvq6ep5IeRNxv0N/s+Rp
 y3VchIImTLX2CycQS3XOy8LVV8adcsmxZ7NFXd3ZgjANrlKSdvH0ZrzgLNsJON9qbM6kaAvJ
 xTHEu3Zaslypv380211RbH2rZB4dQTtggSLPiG/ZyM4cYImTAvMkuIItCO0nMXSJkJbbfcDn
 oA=
IronPort-HdrOrdr: A9a23:HhOSsaDffCNW02HlHehIsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M
 323Ls4m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUbqFh/dL5kUUtDPpZ1fSKWMB2FffueChPbHbzYfJt3T04l7aSHp4kI2A==
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="68150733"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=icm14drdwQEcEvfuaLoW4SEGAaijJ32oYzwCSeljtAUY+VO53y/+4Tgebhpaji7Juw6p1sr7hXm7f9BMjXgQhOsi3/4R8pLq1pLon5JpaGddQ5xjInh3aKQJ99XeSqpotgEv1+AlcS8iN1dl6RWcKZX7QBCIyorScO3L9C6BcKGLjw2EoQoH63VBJ9V3XGIwIZCxXiBjhvCF5f906a/tuduy9pA8dTSL6uf37GcIlDQ8wRhCWDiJl6OkAQ6FKeH804SNKxOYoO0/P/+0Nxrjt66dIhnwURcOIQT45m49hqzU6BmQv9uVi42qAYlocg8OBMXW8iduCmk3azCSDKktSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9Ki0E0TtXjHFVIPiYj6hRHXoysLy/KKSHYe9avwDFzQ=;
 b=bf9oWn2kw4FjLm9bmFQCyWOcYRlbyGLfEPHorgX4Ytx20IXvJof1Ys80P85+otTfuCZull5FlIcNijddh8nj7xEINV2LiWzt9/kJS3ytZwvUlcVbuLqKsMrIywOlMhaKeTLc9rTmvl/B1YlpeaMDNGYyPT1O1lrTi6vs4X2963bHGcHxrmRrKrTmvzqmaYu/B5gdLYNnicVNHhIBL5ICzVljGH1YTNMXBs+ndos7ozkcH18B4Fyr/0bJQdrhCJPJdaD7fmXOWVruViJbm1P9qYC5WaZBhdrR9uDZW0XKQ6hDgILqWyRvCBbO77W4MiumooK2IM6tPMxdHURI/dklew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9Ki0E0TtXjHFVIPiYj6hRHXoysLy/KKSHYe9avwDFzQ=;
 b=BdczxX5wmdJw8VNkQaz7G0V/9k9er+/sQoDGr2JAVNWGKPAVpUf8QcYSHzIjF1nc3Izbp2Y6ZW440JQrebDlP2NtHI6lrTFKzNZ48WaqG/9uCnLtwLccHqJTNIBc3s9F6OCrHgT+hRTi8H7yCIwdTTQwixFceiuE9j20q72nCrI=
Date: Wed, 6 Apr 2022 11:09:08 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Jason Andryuk <jandryuk@gmail.com>, xen-devel
	<xen-devel@lists.xenproject.org>, Scott Davis <scott.davis@starlab.io>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Message-ID: <Yk1YtHYzS3aAbQlr@Air-de-Roger>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
 <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
 <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
 <Yk1Ta9ujHBuj+svN@Air-de-Roger>
 <dd4fce17-2625-603b-25d5-3a586a682210@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <dd4fce17-2625-603b-25d5-3a586a682210@suse.com>
X-ClientProxiedBy: LO2P123CA0106.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:139::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 83f3cbda-d9fd-49b8-3da9-08da17ad1e60
X-MS-TrafficTypeDiagnostic: MWHPR03MB2847:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB28470DBDC5F1C12FEDE27BE48FE79@MWHPR03MB2847.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZbSo8Z/5fLtwWDhGqB+ws7NiwrFrWLDwkKzMhyfpENcDg3OA6FT/gSXO32yuxTIZsnHVxd/nX6G3Xejkp/YCpB+ynaVgV6TAPjFoBB1vBXQXCYpHy7MtvOkx+bgOTMT0zb2S4CTTUN599w2eo2zatRThbau6Krn9aBxXlm2Zf26ioU2Rqo0BsjbbdN6xAL4wgZQh4HV/1G0CRWC8/eYjST7zfcQzhyI6Ppq0yEV7CN3bBon3bE4jrsnRX7V4P+C6F8SiLrS7gpjANWbWhk8/yO/ClrD4/BRh4/HnD8t/Jne5bkj79BDsXInOWj1mAisc4B0WGM82WUOjwxhu2bxaet+8ywES1QNTs9fOJfAcd/qycN5QCe9pJxiHeFU9taSj6XODcBnqohB4hA5SCgRXaMeYjP3ng0jpmsLFbErS7uxOQs6hBtIf1LtnNTZBlLuOjkBdnbb6ztAeHyLoWflKQ+SJb1hElMWTiB5n/EvVgHUEauyw/lI6GuTfayDcFgXoFZlPZwRjzxonSj4v5wVkpEb/LCIpORLMU6x66RJq33XG45WOr/4kwEYxryax3QmaNCw8AEBLyswtzSOjn1XrlCm+HqUcDjChV5SkU2Po4I0FR7HcK+Kt4wzgB55Lh/P7elIM6jhFCVnjm9+PxpsTLg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4326008)(66946007)(8676002)(66556008)(66476007)(6486002)(38100700002)(85182001)(86362001)(83380400001)(53546011)(6506007)(9686003)(508600001)(8936002)(82960400001)(6512007)(54906003)(186003)(6916009)(26005)(2906002)(5660300002)(316002)(33716001)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjNnL0V4WVFJRmNMbHhiNnJMVG0reVIxdndGdG9JbmRLdFhjZzFJb1A2TzJo?=
 =?utf-8?B?RVpSQVBqMXZiU1FaZ1RPdksyWWFCTlp5dFVJNmREeVViRHhNRituWlhEVC9S?=
 =?utf-8?B?NHpvbXBmQVU4Z1cyOVVMeWhGVjYrN0xET2dQdWFYcytiaEErVGlWYktBcjUz?=
 =?utf-8?B?cXg2M0N6ekRMSE1sZXhnem5KdFdPUVdWdkZzakRpSG9xcVRDYU05T3l3TUN3?=
 =?utf-8?B?NFMwbTd0ZVkwTXU4RzZMN05lbjh6d0pRWDhWT1NpNkhoL1d2dTlzdU9la3Zw?=
 =?utf-8?B?MGI4Ry9EcGhuVEV2VWQxL016NFYzbm84QkpkNVB1NGdXL0ZkUEdPeW1wZDFP?=
 =?utf-8?B?UHBVRDdrWTdBZVRPRlplMzhIQjdyYmZ5V3ZZTGtMc1liZzBhYlNScWpRV3FG?=
 =?utf-8?B?ZVlrcjhkZld3QmkzNUJGUmFGaGVZVW4yU1B6aDdLUUlaYkZuRC84WEJqanlV?=
 =?utf-8?B?TVpYTWhwN2hVMU5sTHE0VnhyUmVoTTdqbmhVaVM3WVVKclJCckZWaVB3Z1J3?=
 =?utf-8?B?eG92RmJTRFRSVzlDa2hZMnlRN1ZHTG5PMzNSVElDMSt4bnF2M250T2Jub2V0?=
 =?utf-8?B?cGZ0cG5TVk8rR0xub0JFMk5Wa0VJTFhIemg4TVVKL2FndlFicVdRTjI1aURs?=
 =?utf-8?B?Q1lmRldkYWF5UTQvd3E4Mm5aNkhwUVhWczR0cGJOSThuTUtBelk4YmJaT21U?=
 =?utf-8?B?R1pDUzBtcm4vYlF5L0V0eWM0M0MxeHhKVGRQSHdRK0hkcUdRL1hXdzEwM1lH?=
 =?utf-8?B?Y09HNVlJdGw1YTFMK08yWDcwSG80eWVMSEw4bW1JS0psT2lnWTFyOG8rM0V4?=
 =?utf-8?B?YmJQeTQ4VTdOYm1uSmJCT0R2ZWJjRjRMZHY3QSt2M3JzS3dPTm5Fbzh3c2NC?=
 =?utf-8?B?ZC9ZYlZkQ2xvOThjMENaTTlxOHdDcHYzakN4UnM1cjRkdTRjRDh1NEV0Q3d5?=
 =?utf-8?B?NlNOSEM2QjlDb2xqWjhEa1VTSndaRTVjRHc5WkVwZFdBWnpDcjZSTnB4Um9q?=
 =?utf-8?B?WVFoc2FZUHFlNnNuUGU2dzZDT3JId2UyTDhZS1pMd09PenJ4M0VuUFNXRDAw?=
 =?utf-8?B?T2xJeTg3WFFXMGdrV3VBN084cThCTTg0L1IyZFpvamJCakFQSWdvL3F1M2lV?=
 =?utf-8?B?eTRTKzdMRVd2RFArb3VqYkpwSXlMS3hINDFuNHFlUWhQSVA3SUZ3QVNqaUlm?=
 =?utf-8?B?RjUwNk4zVENSWlJpdDd2VWRoak00Mi9KRi9SUFd2a1h5UytpeUxmL2FjdGV5?=
 =?utf-8?B?NWlheG0zSGlXb2drN29QN3k1SGxra3ZVT3FKei8yMHVHQ0hsRWdQUVB5V0c2?=
 =?utf-8?B?OUFtTjJOWVEyNFJNL3hmazAvMHFqaFBKZGNjSHA0cFlXc1cwbzI3NnBXQkYz?=
 =?utf-8?B?SjdRblNWdmVGanNCc3hMNG0zazRkV2p0cE9xb1pLOWF4TGJ1TlRSdkUyTktW?=
 =?utf-8?B?VnNaK05EV1RYWkxkdUZIUzFnQTZtalA3UHN5d1N2WmVta0J2Skl4djVyWTRR?=
 =?utf-8?B?dmV2T25sMklPWnVTZ08wR2IzeGZUR2Fqb1V5eEJkUkNDYnlOMFgwcmhWM04z?=
 =?utf-8?B?SFRTdHZxdUJCdzcrTVFiRUJ2dHVkVnZnK1VUb0NVTTJtWE1veE5yMTdHN0l6?=
 =?utf-8?B?RUUwaEw2V0pKdHNvbkFpY1R2QXdHQWVqSXkxVm5KOHVZYWh0d3NGV1g1R0RZ?=
 =?utf-8?B?ZnhIREwyVk80SXJjMDFpSDhMUWJYQ25OQ3hGdDVwanQ2VDk2NjVJUjlRY1RT?=
 =?utf-8?B?MWdaLytOMXlJSzdEVXZuVGgvMm4zYkF0TUdkWk93UG5Cb1M0RmVXbTYwMFZM?=
 =?utf-8?B?YWM3aURuYXFuTDdZaVJ3QzdBcnBLbjRMOEZKZFVGc3plU2l5NG9yQi9zOVRv?=
 =?utf-8?B?cU9XZ0g1aTl1N3hHd0huUlNtRzJLT2lRK0JkYWtiYWlBRmFHUHpONkdHcXBZ?=
 =?utf-8?B?bGl5d3Vjay95SEtaVnREZmxFVGxHTVNQZTNXRGdzTW81Qld4aTYvVURQeEhO?=
 =?utf-8?B?YUtxRU1QT29YYjNJNzBScUxRT0VPWnAvdUEvUWNFQy9RNnk1TEsxOFBHdC93?=
 =?utf-8?B?NFlQc2tEcVdrNnN4K1RGR3BVZDBUYU05blVaaUZKbjYyUFdJT0t2aXdpc0Z0?=
 =?utf-8?B?ZGVLdFdNQzVteHEveFlhSlRBNGtzN1MzWXZzQ2VLcmxpZCtJdDFvKysxckg4?=
 =?utf-8?B?RUZMc2lZNDlBbVNxVWJQcWh4K3orU1dpYitmS1BVV29rZ0wzZzN3NkJHTnpV?=
 =?utf-8?B?KzMwdkQyWW1XQTlaZVpYRUdwOGFMVUhjSDQwbC83OFUyY0tIbEl0WmdkMEZl?=
 =?utf-8?B?aUZoK3hHNllmY1FWR3lhSjdmaDVzTFU1RUhwTzR3NXFPRUJENUNJY0tMWmlO?=
 =?utf-8?Q?aoHkI0pWR+Qi5COI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 83f3cbda-d9fd-49b8-3da9-08da17ad1e60
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 09:09:13.3844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zJ69nceEAxFo8JOr2UUjmMqnGpTrx1pt8PQWJZzDY+EqkX0z+h7uXUXidV91pf8DeYpJzTAJhRAjOMBD7I6aBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2847
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 10:48:23AM +0200, Jan Beulich wrote:
> On 06.04.2022 10:46, Roger Pau Monné wrote:
> > On Wed, Apr 06, 2022 at 09:06:59AM +0200, Jan Beulich wrote:
> >> On 05.04.2022 19:17, Jason Andryuk wrote:
> >>> On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith <dpsmith@apertussolutions.com> wrote:
> >>>> On 3/31/22 09:16, Jason Andryuk wrote:
> >>>>> For the default policy, you could start by creating the system domains
> >>>>> as privileged and just have a single hook to drop privs.  Then you
> >>>>> don't have to worry about the "elevate" hook existing.  The patch 2
> >>>>> asserts could instead become the location of xsm_drop_privs calls to
> >>>>> have a clear demarcation point.  That expands the window with
> >>>>> privileges though.  It's a little simpler, but maybe you don't want
> >>>>> that.  However, it seems like you can only depriv once for the Flask
> >>>>> case since you want it to be one-way.
> >>>>
> >>>> This does simplify the solution and since today we cannot differentiate
> >>>> between hypervisor setup and hypervisor initiated domain construction
> >>>> contexts, it does not run counter to what I have proposed. As for flask,
> >>>> again I do not believe codifying a domain transition bound to a new XSM
> >>>> op is the appropriate approach.
> >>>
> >>> This hard coded domain transition does feel a little weird.  But it
> >>> seems like a natural consequence of trying to use Flask to
> >>> deprivilege.  I guess the transition could be behind a
> >>> dom0less/hyperlaunch Kconfig option.  I just don't see a way around it
> >>> in some fashion with Flask enforcing.
> >>>
> >>> Another idea: Flask could start in permissive and only transition to
> >>> enforcing at the deprivilege point.  Kinda gross, but it works without
> >>> needing a transition.
> >>
> >> I don't think that would be right. Logically such behavior ought to be
> >> mirrored to SILO, and I'll take that for the example for being the
> >> simpler model: Suppose an admin wants to disallow communication
> >> between DomU-s created by Xen. Such would want enforcing when creating
> >> those DomU-s, despite the creator (Xen) being all powerful. If the
> >> device tree information said something different (e.g. directing for
> >> an event channel to be established between two such DomU-s), this
> >> should be flagged as an error, not be silently permitted.
> > 
> > I could also see this argument the other way around: what if an admin
> > wants to disallow domUs freely communicating between them, but would
> > still like some controlled domU communication to be possible by
> > setting up those channels at domain creation?
> 
> Well, imo that would require a proper (Flask) policy then, not SILO mode.

But when creating such domains in SILO mode from dom0, dom0 would be
allowed to create and bind event channels to the created domains, even
if the domain themselves are not allowed the operation.

That's because the check in evtchn_bind_interdomain() is done against
'current' and not the domain where the event channel will be bound.
Maybe such check should instead take 3 parameters: current context
domain, domain to bind the event channel to and remote domain on the
other end of the event channel.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:16:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:16:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299758.510918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1m0-0005cu-O2; Wed, 06 Apr 2022 09:16:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299758.510918; Wed, 06 Apr 2022 09:16:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1m0-0005cn-Kj; Wed, 06 Apr 2022 09:16:20 +0000
Received: by outflank-mailman (input) for mailman id 299758;
 Wed, 06 Apr 2022 09:16:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc1lz-0005ch-8L
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 09:16:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 36d50705-b58a-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 11:16:17 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-ULWxf4xKOtCsv5TO4rrkZA-1; Wed, 06 Apr 2022 11:16:15 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 09:16:12 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 09:16:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36d50705-b58a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649236577;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=h9yAEP5k7efnIZnWqwKNIuoZpKMaIHJzs91t79TTAI4=;
	b=hCn4FM92nKSVXO2xQ2ulJMmkJoNPfjEqgRaZPE6l3hugJkC2Ob8AjEcW/8qoWoKNWeQm9s
	i6kUUzmChTMWL4bYPq3k1SXShtr6kzaKrlCk3YAx8W3+0068op6Cf8lGKZSQ7+qEmpdmJ/
	HmMJlEv3wAmjPT68EYVh58CFHEWIW8w=
X-MC-Unique: ULWxf4xKOtCsv5TO4rrkZA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DLIz3NnOgm8aZZBIlNKtJyhw0F4K2WKdAvvJT7etg2au6ACGsWbU9r7v/3TKVSwSZi4Fz22BECNt6euah7Sr06SuuRA7dI2yaaCSwF36QLGvP1+9mY5ti1FDaVdLh1LSDzT3szwDDvkDG7M6W7fpe7ijnc1osPNc1Ryn2wKmbWLswb8PWa4KoYaB0gkl3n8idj17Wkw4KkaaKlxJfavZUlkcBm3Qfn3SWzZr8tra6+aHO/NuoA2WEiXCmjU0ab2K4FQSudlVyoqnwXvbo4bbv5IvWGj0P87CxZB4nwyX6CYtS8vOtC32zsOVOpgivjqRc5a1adhoDq1IywD2v49Sew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h0+jSX1zBmlTyBdzekTCZUFKTSINT9foCCv5+IWzDho=;
 b=cyD9cdbbC7NUij64vzwf3dR/Va0p8eLgkzbBWQjbM2Mppmczy5QjjiaIgZhktlKAVhfVRyHPcSdMwuAL8wK752+tPuuoHIc02ORJfRxZRu6v81azAZ7KHbmVF389uikLNI3v8+DXAMk9vosqQ2ZD4wgkrayPWuzb5eSuj7ZcDrPLD+NAyJSF+QejGOzsoBO8FWOtmQqk7zD03j7ukmL72ZXPlrV8p8c12Po5V6VsWMMLpiwgmwYYQulMrQ7fIa353xHsfUf0zKUEOsJm0GNI/WRi/oLP+aX4FeARQpBqbLxfF50KMHdwsOFj8wm9RyDN0KH2z1KS2eN0TMk+WUN12w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <48e44681-822d-8e00-a2c8-808984a0cd50@suse.com>
Date: Wed, 6 Apr 2022 11:16:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Jason Andryuk <jandryuk@gmail.com>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Scott Davis <scott.davis@starlab.io>, Daniel De Graaf
 <dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
 <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
 <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
 <Yk1Ta9ujHBuj+svN@Air-de-Roger>
 <dd4fce17-2625-603b-25d5-3a586a682210@suse.com>
 <Yk1YtHYzS3aAbQlr@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk1YtHYzS3aAbQlr@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0197.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bc0b4f74-0406-4fb9-e5f3-08da17ae183e
X-MS-TrafficTypeDiagnostic: PA4PR04MB9366:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB936601C1E605A5045B05B2F2B3E79@PA4PR04MB9366.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SbctrIB2o6mXJy3E8fLSzRlZweUngCLI7JO0Fofl6ZNpG19QrICE6Mxvfu4mzDpATHafVhteSDHGftZ0n8sdfmfynMXKWCyFUgiF9QeOywrxPa+p/je09LI72JE/1PEf6u10jUEh654id9gI2M2b+FDe1DlmTAujVInfpRJTcg21TNBNHPkqqAhNLWNM9u30EC1zND6dRd1gAiPwVvBTVJyl2IQQ5rmLzjkjggHdpxR4XwmuRz41Ajje+/qKwcPqCaBdHuso3D4PErUpWKw+EpyPUhln12MQdzyIYD6R5HlNkv/SwDsBJp8N7QBf5Ab9+yZmZo+/qeph8MIkjNn4ZrIq5j+nZEWwAt0LWQaByo8l5ZAhRBn3pPZWflqYeSiHIOXKloFWfbSp3HW2KzpzvPQg39HgFE7Bt2mYe504jC+HnLCE1e01T9yTEFsnjTHAMRG6TAz2KlyWulWiNikk9H/SLPUe1FDNeleVwqgpkjann5Q/SJvbnlW/tcU7Gdwl6BgSb0ONKraim8VdwE/SKjPJnke27YgrOeNR/0ouOy42H0eEBANApris4j/O10FTLskaYtL843gnwbeXjAZ/Vse9DZkeX3XkiYeZCPs16i9B1g6DM16y7XON2z6BMEbxMZHu87TTZMvJZ25rxBwUX9BOu9NOm3YohyXIjAQGzXmxqmWBfOlPnnJGfsa/PEvnVi7Jt8Ik64vAk/kJWan281XvesQd60wlTM7GAxX439Q=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(2906002)(5660300002)(8676002)(38100700002)(31686004)(66946007)(4326008)(31696002)(36756003)(83380400001)(186003)(86362001)(6512007)(6486002)(54906003)(508600001)(26005)(6506007)(6916009)(2616005)(316002)(53546011)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KMOvL2327M1Fvqs97j6yDMd4hU2lotT2vclJ4fRfPbDuH4vJivUbUA3Snqi2?=
 =?us-ascii?Q?VMQi7e4PVhpF5iDeD+d8PGzbT7GgylvzNMKS9YJmU+usy4208BCt3cXU7fNC?=
 =?us-ascii?Q?yGZx5UBsH36ZmgJqaVuxREEGHf9LeCAJXjBygsOf03uANfWV14dPqJ97laKn?=
 =?us-ascii?Q?bm8wU4F8w8gmvuRv/OXsCoAKP9Gwzvx1HhPRSaXYC6sm/WGKAGclzp/zQXNz?=
 =?us-ascii?Q?HjMnN7w6AiMzGQERQN738BHI35qrnSfeugjMEG+/iEg754u78wjI0pa6Dd5Z?=
 =?us-ascii?Q?welSsEKQt8SSg6Y0Y7NM6ibr7IlfxOEfJlPN4496D83bRKAubqlAvAMlyfYZ?=
 =?us-ascii?Q?LmJCqx8Qp49BFzd3Muj33l4wRc8R9XGXnr6fk7kBbDq8LOz7P6QyVi/KMtz2?=
 =?us-ascii?Q?CXpF7Z4Jf2CuADVc53A1vInRMJNMQfihir8bGDVQJoTSnrvMGidcK0/1kYF8?=
 =?us-ascii?Q?7q8AWGnpwnsJlS0MUJLsnIOXiwkNtVUsvSm5PECa3HpDxwv/uHszUKNBUorB?=
 =?us-ascii?Q?4ji7yEIV516LPkUCIImzAncCLcLUq6NNwm1pyuR82hd4drQyyw0uF5HpVBAj?=
 =?us-ascii?Q?1MRKN3WpgUcPYS9Cd8OPs8bSqvwK1GbZ/nVgs428i3crIVSgJyPKFNaV4b0N?=
 =?us-ascii?Q?dQY5GyAx6GCb0T3q0BRDIv2dp7rPqLjVRss/7asX2P02GBkyh0MpuTj46Tgc?=
 =?us-ascii?Q?C4sBtiFwkBYJxTNwv4JfF7nPQ0RzWSZzfrVd1tZ4xmqIkvfqhkx99jU/feXv?=
 =?us-ascii?Q?iDlPyFuq0CLbMhsu3Bw9C/lPE8JITOcEVIv/L23ZIzINTGhWYznzH6k8DGyP?=
 =?us-ascii?Q?HYIr5i2rVCqY9N8BRArT6LZRDYPnrIybEIyFRWn29+3bJ72vdo8Q+jS7nEQB?=
 =?us-ascii?Q?WfGO7yvkVqR5BsvHrIEOgKqIGFtcr/qyC7ufcyikBsZisCAIgMKK+ZpxFwy+?=
 =?us-ascii?Q?CokGjVmUyGYwwep9Vyg78BewYGk3SKU0qzXG2PGzjpDThNDbd4O/FRXhoDs8?=
 =?us-ascii?Q?yZrDY4D8mx6a6BkimEUCB+wFUBBWW4YexPMyLfXDU57FujyoCvxzt+anf6xS?=
 =?us-ascii?Q?vIY+UGwrt0YIUqAmSC6a3KA5oHZ+BD3r7Kx29x2W9YEuGD0pKnvbl9/S6xrh?=
 =?us-ascii?Q?+jD3+0m6xuGLmdhHxGLY8IBSCfDDcaYFBgGF2M8IYhU8r7kj6aMT6+dRtTkS?=
 =?us-ascii?Q?xI9lsW0RxujndjozbAjp7eEl2OlDRj0fb7YsHRTXtNRN+535w9MMV7JWT+nZ?=
 =?us-ascii?Q?K8XA4OqHqQe4huYQrXov1lUoZdo6YHuKreCBnPOt5OJOhFQkkKRN2tr+ciFM?=
 =?us-ascii?Q?WnR2tjS/lvINBMttIoHZwrf++gBS9x4ISvsLaQ9LNZUipf5r4Ns8SpQaGRZZ?=
 =?us-ascii?Q?JondUIcq4ZgR6rFUNA1guvn0JSJyx12Mtl5yhOftiQy1AvzeAt13Ast8T4B9?=
 =?us-ascii?Q?2UY+2bBB/9UFMB53wh0u2teMRXHEiP1eiW4O7OqrQ66ODfkBU/NOvMTH7mR5?=
 =?us-ascii?Q?6HcAqIAK/4G0q75qNYN9UCOsnaM8TJKbCUvY7sL6il/DwqtALSLBUPh7JLz/?=
 =?us-ascii?Q?isyYlAqvxyf+havdjnlXSMv2ieSBhK1H4spZiKFb7C8AnDA+0IhdhMtwl2vz?=
 =?us-ascii?Q?y5X0im/kengkURfw1h3Y6/7eDzXksgnVq1Mg+s1n9Jy6cND6FtnQqQ33SZ2o?=
 =?us-ascii?Q?6GXncigX36nLgHw6SHv9UWuhnLCI0Et9Sgk3mhLWo6PMMiY4QDEnz3XodAJR?=
 =?us-ascii?Q?AtLk/D8/xg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc0b4f74-0406-4fb9-e5f3-08da17ae183e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 09:16:12.7056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CcxQI1VelM1H0S6qONJrzagyi7zwp5P1kllGhSDcXNGizqkswRjACenLeaVUh5oEyjW0dF73oC9KR9NRKuffVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9366

On 06.04.2022 11:09, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 10:48:23AM +0200, Jan Beulich wrote:
>> On 06.04.2022 10:46, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Apr 06, 2022 at 09:06:59AM +0200, Jan Beulich wrote:
>>>> On 05.04.2022 19:17, Jason Andryuk wrote:
>>>>> On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith <dpsmith@apertussolut=
ions.com> wrote:
>>>>>> On 3/31/22 09:16, Jason Andryuk wrote:
>>>>>>> For the default policy, you could start by creating the system doma=
ins
>>>>>>> as privileged and just have a single hook to drop privs.  Then you
>>>>>>> don't have to worry about the "elevate" hook existing.  The patch 2
>>>>>>> asserts could instead become the location of xsm_drop_privs calls t=
o
>>>>>>> have a clear demarcation point.  That expands the window with
>>>>>>> privileges though.  It's a little simpler, but maybe you don't want
>>>>>>> that.  However, it seems like you can only depriv once for the Flas=
k
>>>>>>> case since you want it to be one-way.
>>>>>>
>>>>>> This does simplify the solution and since today we cannot differenti=
ate
>>>>>> between hypervisor setup and hypervisor initiated domain constructio=
n
>>>>>> contexts, it does not run counter to what I have proposed. As for fl=
ask,
>>>>>> again I do not believe codifying a domain transition bound to a new =
XSM
>>>>>> op is the appropriate approach.
>>>>>
>>>>> This hard coded domain transition does feel a little weird.  But it
>>>>> seems like a natural consequence of trying to use Flask to
>>>>> deprivilege.  I guess the transition could be behind a
>>>>> dom0less/hyperlaunch Kconfig option.  I just don't see a way around i=
t
>>>>> in some fashion with Flask enforcing.
>>>>>
>>>>> Another idea: Flask could start in permissive and only transition to
>>>>> enforcing at the deprivilege point.  Kinda gross, but it works withou=
t
>>>>> needing a transition.
>>>>
>>>> I don't think that would be right. Logically such behavior ought to be
>>>> mirrored to SILO, and I'll take that for the example for being the
>>>> simpler model: Suppose an admin wants to disallow communication
>>>> between DomU-s created by Xen. Such would want enforcing when creating
>>>> those DomU-s, despite the creator (Xen) being all powerful. If the
>>>> device tree information said something different (e.g. directing for
>>>> an event channel to be established between two such DomU-s), this
>>>> should be flagged as an error, not be silently permitted.
>>>
>>> I could also see this argument the other way around: what if an admin
>>> wants to disallow domUs freely communicating between them, but would
>>> still like some controlled domU communication to be possible by
>>> setting up those channels at domain creation?
>>
>> Well, imo that would require a proper (Flask) policy then, not SILO mode=
.
>=20
> But when creating such domains in SILO mode from dom0, dom0 would be
> allowed to create and bind event channels to the created domains, even
> if the domain themselves are not allowed the operation.
>=20
> That's because the check in evtchn_bind_interdomain() is done against
> 'current' and not the domain where the event channel will be bound.

Yes and no - the check is against current, but that's because
communication is established between current ( =3D=3D ld) and rd. The
function in its present shape simply can't establish a channel
between two arbitrary domains.

Jan

> Maybe such check should instead take 3 parameters: current context
> domain, domain to bind the event channel to and remote domain on the
> other end of the event channel.
>=20
> Thanks, Roger.
>=20



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:17:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:17:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299737.510929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1nE-0006A6-4C; Wed, 06 Apr 2022 09:17:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299737.510929; Wed, 06 Apr 2022 09:17:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1nE-00069z-0W; Wed, 06 Apr 2022 09:17:36 +0000
Received: by outflank-mailman (input) for mailman id 299737;
 Wed, 06 Apr 2022 08:52:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bahK=UQ=opensource.wdc.com=prvs=0880ca2a2=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1nc1PE-0001DU-Nx
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 08:52:49 +0000
Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ec36459d-b586-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 10:52:45 +0200 (CEST)
Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com)
 ([199.255.45.14])
 by ob1.hgst.iphmx.com with ESMTP; 06 Apr 2022 16:52:42 +0800
Received: from uls-op-cesaip01.wdc.com ([10.248.3.36])
 by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 06 Apr 2022 01:24:14 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 06 Apr 2022 01:52:43 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KYJDp38s7z1SVp4
 for <xen-devel@lists.xenproject.org>; Wed,  6 Apr 2022 01:52:42 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id afeRwg43Rmk2 for <xen-devel@lists.xenproject.org>;
 Wed,  6 Apr 2022 01:52:41 -0700 (PDT)
Received: from [10.149.53.254] (washi.fujisawa.hgst.com [10.149.53.254])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KYJDg4WyPz1Rvlx;
 Wed,  6 Apr 2022 01:52:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec36459d-b586-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1649235165; x=1680771165;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=LFM3dJ4XtmmQmpjm/ADKwYliPf/iPacGMSt9/3x5IFU=;
  b=To2eUsYgSjtDKL6zkmIlY7240wBKe0iYsCwy244hJP+Nx48QdTRKAG5L
   m9yi8n9Vtge2WwIRlF/EU/tVZd04noO4D87Lz7PjmZJdBzX7X0JvhNEOE
   EgMzfx4Sw9VO3KZpeqy4Mqk1eBOUzoNBuErJPzJ2sSTAwOlYOl8Angwmd
   3JiQjnOHmH9hdGlZxdTXVk4BkWLM20hVu8+Cijwme1w5MgSf4edBcfJ0a
   x9z3kcfDHm+mn2TxvqQmXkbr3DWYYheTvYAsSZzXsXduw+zmoeSJWR5da
   xMbuMfvnay8NapXqswklXe70Y/p2tMhg9j7z2INfHsErVfM4dWcGlIoPH
   g==;
X-IronPort-AV: E=Sophos;i="5.90,239,1643644800"; 
   d="scan'208";a="309182688"
IronPort-SDR: lGT9/VEI4pUcLf5qk9m6R7vaS3dsKaEeOhk0aElos1OnfZ4eCV2Mewoh5mWVOxiabUCxlkpIrJ
 i5Hg6059tt4xBV5hn0EQCfq9EwzcjBUD2bHQrfw/ZCBJ4WklJEX3o5bQELyarhFj88IB6cLHfp
 RqlIwS0IoGYWOZh5SvzvywConV2n0380LD7FEY1wmLYWYn+XFMpbdJsXFKOFrQ2OmIALopXPK4
 ureIrTKERbeHqJEPLclsXMlClgWXPGAyIZQ8PdaUKp+uoBpWObgqkBMiUzSbNrpjKjwa3gP0fa
 NBtDoxzIR8lhMIeQkUqYSEst
IronPort-SDR: /dFAJZKbp71So4RxLkGMSmVi+hD6lLeKyv2tOnheSp+mXDVkTeeyg/Ghik+iD15anKtFuxH9GG
 0XVlrNL4QmX3jWbS1yyjOVRRye8u6kwbKjY8pNd/q7vZ6Bhvcmh/xGvmKy40Et9KcI9sHmK8qF
 sqABY2VkYJw9VISXgdMYnD3Q8+EUb4axtY6g9s0ec64kVPICbyFMkUVe3cVlC0nKvv+TcHNyN2
 jMA6MYLJgKs54mqXgiYwyoEw9ASNazIjYgyaTtoveznL5ipeumi8eSnjob/s2d3Q/ksXukd9oB
 EO4=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1649235161; x=1651827162; bh=LFM3dJ4XtmmQmpjm/ADKwYliPf/iPacGMSt
	9/3x5IFU=; b=qvkCgjbtXOykeK3hzZNeB4nFZLJBLeVyzVQiFxPBd+c54HMRQrR
	r3mHxfVWNdkNw5DIJA4fgfkXPh93epK0mDoQ3kgu2fpFkbSa8brjeKFgTDNdjUXK
	QEdaChXXlXS0VTxT7h9gL19ju3gtHs6R6Mypq0Cc5OI+h1pEURz6XYf1UQ1mcqds
	uMy2QNMB1cQhY28LO46skbuCxOrF4i88P2mQlM7t3vtuiUBfVFmxO2ZMvku2/0fT
	GRED3B4iBwE6imVQ9DU7YD88eHs1K7YN6+E1hQRftlmDiNgCGpghEuxtQnop4vN/
	eOwwsoVyhIxEYaxD0ZFdcLlRFvL5b8ALceg==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <ea3d14cb-00ea-8d7b-4615-9347fdd7aa27@opensource.wdc.com>
Date: Wed, 6 Apr 2022 17:52:34 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 14/27] block: add a bdev_max_zone_append_sectors helper
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 nbd@other.debian.org, ceph-devel@vger.kernel.org,
 virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
 linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
 linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
 linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
 jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org,
 ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-15-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220406060516.409838-15-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/6/22 15:05, Christoph Hellwig wrote:
> Add a helper to check the max supported sectors for zone append based on
> the block_device instead of having to poke into the block layer internal
> request_queue.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   drivers/nvme/target/zns.c | 3 +--
>   fs/zonefs/super.c         | 3 +--
>   include/linux/blkdev.h    | 6 ++++++
>   3 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
> index e34718b095504..82b61acf7a72b 100644
> --- a/drivers/nvme/target/zns.c
> +++ b/drivers/nvme/target/zns.c
> @@ -34,8 +34,7 @@ static int validate_conv_zones_cb(struct blk_zone *z,
>   
>   bool nvmet_bdev_zns_enable(struct nvmet_ns *ns)
>   {
> -	struct request_queue *q = ns->bdev->bd_disk->queue;
> -	u8 zasl = nvmet_zasl(queue_max_zone_append_sectors(q));
> +	u8 zasl = nvmet_zasl(bdev_max_zone_append_sectors(ns->bdev));
>   	struct gendisk *bd_disk = ns->bdev->bd_disk;
>   	int ret;
>   
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index 3614c7834007d..7a63807b736c4 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -678,13 +678,12 @@ static ssize_t zonefs_file_dio_append(struct kiocb *iocb, struct iov_iter *from)
>   	struct inode *inode = file_inode(iocb->ki_filp);
>   	struct zonefs_inode_info *zi = ZONEFS_I(inode);
>   	struct block_device *bdev = inode->i_sb->s_bdev;
> -	unsigned int max;
> +	unsigned int max = bdev_max_zone_append_sectors(bdev);
>   	struct bio *bio;
>   	ssize_t size;
>   	int nr_pages;
>   	ssize_t ret;
>   
> -	max = queue_max_zone_append_sectors(bdev_get_queue(bdev));
>   	max = ALIGN_DOWN(max << SECTOR_SHIFT, inode->i_sb->s_blocksize);
>   	iov_iter_truncate(from, max);
>   
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index a433798c3343e..f8c50b77543eb 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1188,6 +1188,12 @@ static inline unsigned int queue_max_zone_append_sectors(const struct request_qu
>   	return min(l->max_zone_append_sectors, l->max_sectors);
>   }
>   
> +static inline unsigned int
> +bdev_max_zone_append_sectors(struct block_device *bdev)
> +{
> +	return queue_max_zone_append_sectors(bdev_get_queue(bdev));
> +}
> +
>   static inline unsigned queue_logical_block_size(const struct request_queue *q)
>   {
>   	int retval = 512;

Looks good.

Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:25:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:25:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299765.510940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1uF-0007i3-SI; Wed, 06 Apr 2022 09:24:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299765.510940; Wed, 06 Apr 2022 09:24:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc1uF-0007hw-P0; Wed, 06 Apr 2022 09:24:51 +0000
Received: by outflank-mailman (input) for mailman id 299765;
 Wed, 06 Apr 2022 09:24:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc1uD-0007hm-Sr; Wed, 06 Apr 2022 09:24:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc1uD-0000UK-QD; Wed, 06 Apr 2022 09:24:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc1uD-0003Vo-Gy; Wed, 06 Apr 2022 09:24:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nc1uD-00032A-E9; Wed, 06 Apr 2022 09:24:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mVNTzgI3KpF+5nNmQAwIEFYnTfME6JRjHgmLZ6fmK1Y=; b=tZfbx/mD10hl7SBiG46RPKZ8IQ
	UeDrZIWG7a4Vzhi7w+L2FEBgDFhEvc71r9YyydD952e9ZLg3UOQIg+xYExZgqU2zJ2J7gwn+QDpMo
	db6DeI/xjsyhigY+ISfxbJp3RkA7XJsDxLTVaKVEEFAS7OVZ/Z17FlxjIAfMUwfhWK74=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169181-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169181: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=223a8671cac29f64591a8e01c00d8db45a343d52
X-Osstest-Versions-That:
    qemuu=20661b75ea6093f5e59079d00a778a972d6732c5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 09:24:49 +0000

flight 169181 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169181/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169166
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169166
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169166
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169166
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169166
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169166
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169166
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169166
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                223a8671cac29f64591a8e01c00d8db45a343d52
baseline version:
 qemuu                20661b75ea6093f5e59079d00a778a972d6732c5

Last test of basis   169166  2022-04-04 20:07:03 Z    1 days
Testing same since   169181  2022-04-05 13:38:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Pavel Pisa <pisa@cmp.felk.cvut.cz>
  Peter Maydell <peter.maydell@linaro.org>
  Tong Ho <tong.ho@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   20661b75ea..223a8671ca  223a8671cac29f64591a8e01c00d8db45a343d52 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:35:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:35:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299774.510951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc23w-0000w1-0r; Wed, 06 Apr 2022 09:34:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299774.510951; Wed, 06 Apr 2022 09:34:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc23v-0000vs-Sg; Wed, 06 Apr 2022 09:34:51 +0000
Received: by outflank-mailman (input) for mailman id 299774;
 Wed, 06 Apr 2022 09:34:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc23t-0000vH-Kw
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 09:34:49 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb61019d-b58c-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 11:34:47 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb61019d-b58c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649237687;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=JhYqmcdLRVf1JaEF9woWJEc7IB0o/2EuT9pc2Y2RXRY=;
  b=O87z2idczSshbEM/NMxVynsvzUHfF7W7YdTdpBIcVkvEFI2xvZnhflOn
   DCMsUR2Z5c226As/raTio6CYS44MiYnSLYmXQEp4mUw5C7w62YM63nTwe
   24dZas/IdC3wfyM9B3UmFaWccQTbvcr61Aq28neDwXNskHWA5NpLl/bek
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68545964
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3/mUQqq4fqZvnklqQr4lMlic2QteBmLtZRIvgKrLsJaIsI4StFCzt
 garIBnSaf6LM2T1Kd52YI3k8UgHuJeDn4JlTgtv/yAzFn4QopuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y2q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBNJLQvslEaxJiEgZmEbFX2JvDO1ihrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZpENWc+MkiojxtnG3cXMLQ8jP2TmCfmVA9FoXvNr5Aryj2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sfRmif8VJMXBaeP/Pdgi12OxUQeEBQTE1C8pJGRgEOkR8hWL
 UBS/yM0tLUz72SiVNy7VBq9yFaGoxodVtx4A+A8rgaXxcL84QyUG2wFRT5pc8E9uYk9QjlC/
 k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt/N3LsIw1yBXVQb5e/LWd14OvX2uqm
 nbT8XZ41+57YdM3O7uT92/bpR/1npPzTyktyhnGfkah9CNne9vwD2C30mTz4fFFJYefa1COu
 nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yT7Fb289g2SM6uA3iwsXTbyK
 HHetgpKjHO4FCv7NPQnC25d5ilD8EQBKTgHfq2MBjatSsIoHONiwM2ITRTOt4wKuBJx+ZzTw
 b/BLa6R4Y8yUMyLNgaeSeYHyqMMzSsj327VTp2T5035jevHNCLFGedVbwDmggUFAEWs+lu9H
 zF3bZXi9vmieLemPnm/HXA7czjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/F/SU9cNokihrc+Rp
 ivVchYBkDLX3CSbQS3XOiELQO6+Bv5X8CNkVRHAyH71ghDPl670t/xBH3b2FJF6nNFeIQlcF
 KBfIZjfW6gREVwqOV01NPHAkWCrTzzy7SqmNCu5ejkvOZlmQg3C4Nj/eQXzsiIJC0KKWQEW+
 tVMCiuzrUI/ejlf
IronPort-HdrOrdr: A9a23:zlA3hqzJwkSfgqLdM32ZKrPxzuskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4yGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87heYAotd/lq
 H5259T5cJzp/8tHNJA7dg6MLmK40z2MGTx2TGpUB3a/J9uAQO5l3ew2sRw2N2X
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="68545964"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QILOshNIfOD+UT0biytmXWrQSnOM1OPTGluC3ANWQ/UiMYFuBXlJiIMzvkpXH3CjP0dQn88CTXxDCQ6rZztZ4E3GFybhM8Q+LLE1p1vGx6/01GdX15gmCwPXx/f2ELZ3ZvQOBf04IXqX6KcAopV7vFSBrEkcX9HfufMbgbGHNLPxRUPjAmSdeDaiR7n+Dnzl/Z1xc5XgAyWgCfv15zpTbvkhQH6LrlAkfbb7sWMJp1dGYzlzcTWx2oYZ2kFtPoR7pyZYv2Q6KTIkUQtS/FfFc20k9NpgK7cwA2ivJZLGUz6LyOu2Cg0qfKL/fzoi4gP+tp7APMDSUIaKrbMs2uPDFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IMq2Ql/ldUUb0OMR3A5GjnGWymWVJx5C7R/0sNdQFIw=;
 b=C8CMOHhUsUvB3uoMykplvypKJC6kiIr4C9JYq+3sVu4yYkJ8Det+K+GzN4HrXfAj2ovIif/wt4SiX/CuUZ0O2pMYoP0IbeEo2khdWxjpahMxtXS48rNTf7rJnYSnn08o00INXRmX4XlBrcR9aLa0V3+B3OOPeoORnvYqr3+WzXy5HVW6zum9vPA7wH4uE5y5QoryUZKxMOJJVnjP/8LhA4neW7ug8p4g/WjS/CYwE1xayha28Lt1LDcE+0zxHX10NgvX/bIeYpNdIFwG6KUS2HZ0fSjhaQ/8YZdRJgSc5Lixvt7KYfHA3nJGRvFObcgtibPmzwa1biiajeKKJpbR0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IMq2Ql/ldUUb0OMR3A5GjnGWymWVJx5C7R/0sNdQFIw=;
 b=wIQiGaF7Cj5W3kpZw12kNFOFhgtlghI2FtFWbUkJW6VuEppLJFgAuHZnaD4LWf7Vhs/6ynWenWQot1CdTTn7EYi2PKkFME8VtJl+v4HcalnKXfUAtN2m1zQC9+wtH0rrJxkpRBxqiVd4Er9RiIpFdZDwBq4CGoqH6q62KGU421w=
Date: Wed, 6 Apr 2022 11:34:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <volodymyr_babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Message-ID: <Yk1erGso3rC68m/e@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
 <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
 <39640fec-de8d-0c5a-c9aa-daf83fb785b0@suse.com>
 <YkxkfbNpR7yfLP7W@Air-de-Roger>
 <17163e1a-6598-5949-47cc-eb9734bc69ac@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <17163e1a-6598-5949-47cc-eb9734bc69ac@suse.com>
X-ClientProxiedBy: LO4P123CA0494.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 63b03ad6-d008-49ca-4522-08da17b0acdf
X-MS-TrafficTypeDiagnostic: BN7PR03MB3604:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB3604B072AC15D1C8DC3432C58FE79@BN7PR03MB3604.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: f1sOJqzOZmqsfa8TXclRrdaEA7Es8l3qDnyy5GwQ8cnEUCpeh1e4w0xZUSeUvxMfP79KRd0cHRgrT5HqhlXZJkvdoAu3S4vkUkBG2qbKGpBAWtIQo0dEgm+D1izmEQkqHXUwEAJIQxiOOrkq3AM9VdTjeCghNJ2pU46N55gC2DZOt48DMmpZh6teTFJmm4VIXaO9XUrD4+RFgtHyYRgGarDqQT99cmmVeHCWPHaBfVwNFjbkiEHMIwKMno4BK9qF5XFrn8Zj0wca9MIyDv97K9xdsWAGF18Avto27u/7yTSpmfqOrmO0uEjoxJFJwYj7RtEBHVmJQVREDs/rIA9H+TLqxiHYERl4ADFOIdBv48YdFqyOjyl8sU30FXHvwblXr/eYBjrSGr44EpD1w8c46RqTsMyGQA0ZEWn8/t2elnE3hMeLVTh1NU1zevshVrlSpUdQMwT3sPOtBaayxTvIpVjFTsagmZVuSiVZ6dwZ3qaqPj9Pb2xsb1PQlh2UT/m9tRSNUlfYdQvg3ulZW3uFsUzPLE/GG6TtXw+6wPalmF+dOfF/rKZ63VR+oSaWsqfk+A5x8O3e6K0wqFPS8CbbjD0mcc91YRF8kv/FGdC3iKkWF3eugQduU5OCpJE7T2KsHK7GzASGzRYBZvutxqFfUA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66556008)(4326008)(8676002)(66946007)(66476007)(316002)(54906003)(6916009)(6486002)(85182001)(86362001)(38100700002)(82960400001)(83380400001)(26005)(186003)(9686003)(6512007)(508600001)(6506007)(6666004)(53546011)(33716001)(8936002)(5660300002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFY3S0N2RDZNV1MzY0NTSTVxTUsrditsWU9RYkRhSmM4bkJTc1dzUnlYOFVN?=
 =?utf-8?B?Q01FUHNWVUpKT2dHV0RicE9YNXRUV1AyVjJQQlRqN2F5cGd5SGJvWXgxU1pO?=
 =?utf-8?B?anZucVFJWGoxeE5PQWQ4M09ycFo2M2ZIU1VwMTJPRDNIK28wNXpNeGdNdFVT?=
 =?utf-8?B?dEkxWmhMUERWc21lRnh6Vi90Q2xlQWdZL0plVmZDcC80eVlmRGZVVzFQU3ZS?=
 =?utf-8?B?RHJLb0dBUXN6Ty9pUVNGYlhEV1lDelo5bzhOcFUwbUpWVjl1VlFJb1pGUVRX?=
 =?utf-8?B?bnh1T3hiSW5hQXZLZXpRcXVGaUVJcnhwWUZYb3AxeFRiY0FGK1BURlQ5ZHcz?=
 =?utf-8?B?eE9zTnQvN1BockhCU0Zxcm1XNE9PWjcrZklpWithd2FyMUw0dCttTE5zNHhX?=
 =?utf-8?B?eFF6YXF2c1JjNXBoMXh3dmFJb1BIc2xXV2tCdWQyZUpzenUreWhLb2FEcEl3?=
 =?utf-8?B?THhpei91c1FtTlFDcnJpY1Awc2hsV0ozSFF4TWNkOVA1bG15NTVrNk9tMEZJ?=
 =?utf-8?B?QmJJNlEyTjN2VHd5bGw4cGdTYTJmNkpLVkF5K2lINFR2R0hpT1o3OTVlaS9k?=
 =?utf-8?B?YU84MnJMa2pLcDFpTmdHUkJ5MC9SM3VoRVp1RTlxVTlBSHZURWdwcnlKRGY0?=
 =?utf-8?B?bWxLWkU4WTE3bHo5ays2L2VoWEkyeDNOczFzblU4NzkrWklpVmVYODYvZjY3?=
 =?utf-8?B?WFlwWEx0T1RPN1hOZkN3SWVGdVdjT0FiTGIwZkt4RTBhY1puYWNtNm9HdXdP?=
 =?utf-8?B?ckJSTFgwbVFEVkIwbFVqSWJ3b0l4eFBUWCtHcGVvZ3JYL1RQYkU1TkxkOHd4?=
 =?utf-8?B?U2RQQnlscnZ3VXZ1UDErNnJYVC9LSm1Pb0pBalJSbTRxQzdVdFM2YjNpb3or?=
 =?utf-8?B?WVh4QmJJZUlLUTh3OFpReThnMFlRWTBIN3dFTmtyVEJvenFlc3hmeVFpUjNp?=
 =?utf-8?B?OUd0Z2JFRkw3YWpiYkNFeXpBZUtwYzRheGRCY0tFK21KQzBLREhObnRidjFt?=
 =?utf-8?B?b0I2VFdxcHlrVytGYmdZSURNcUVMZ1NQbkwrTWswV3ZYMmlBbytIdUd1QUxZ?=
 =?utf-8?B?U2hyMmY3MS8wVkpXcU9QTGR4U3JhVnFMc1BKeEk0VWh1NmxaUjR1eldjT1BL?=
 =?utf-8?B?YTYwbm05MkZqd1lrRzJIdnVPU05sL2czRWI1MDFWTWtneTBvaUFRRmZoNzNT?=
 =?utf-8?B?ZmFEdTJqSitQZVduK1ppU2kwYlJuRFpHSm9YUDRDVGNJUXE5YkV4cHQxSnp0?=
 =?utf-8?B?SWpVdHFPMzBEQXZ5UG8rbmFPMjQzUUROY3NSWjVxMEthT3N5SGZZWGdsYjVH?=
 =?utf-8?B?Tzdsbk9VeWhEcnhEaStkUmVLelo3aTFIZmsybUo0MEErQUprKzJ6elYySXg3?=
 =?utf-8?B?b3lDbWYySHg0Rjd5UGZVZjJOUTQ4S1hEa3ovRTZmTWtXRzEvTHlTQ3BUZ3Jt?=
 =?utf-8?B?OTV5TU90UkZXclEzenZIOGloZVVoQVVLM2JqZjQwb1RjR3I4cXRRVmd4TmI0?=
 =?utf-8?B?azBFbHdRRW8rNFdlYVVIS3BlbkVsS3o3cHBvSzQxczJWT05OU3ZBemFSdjky?=
 =?utf-8?B?ZE5NSVV5YmdoZWd3TlQ1RG5uTG5VdTdjL0RYdlFsSm1tMzR5dHZJeFNMMjFV?=
 =?utf-8?B?M3lJdGt6OEpmWkcrT040b0M4bVBEeEFMcFBuVUdOeDZGK1RITWV0RlJLOU5n?=
 =?utf-8?B?WGxadDA3VDEwSVd0ZGpqTFpDZ3BaZWNpdWprUUdLTFJtQys5UmVENjFhb3Qx?=
 =?utf-8?B?Ti9FVXpNVllPTFIzaHRoODlrcU1BWGM4ZC9NL08veW5vZERlQ1I4Zkp1MER5?=
 =?utf-8?B?dkhidWhjc2FxVW9BcE9OSmFsdjFIRWdCcFB2QU55U3ZmRTN5eC9adTV5N1c3?=
 =?utf-8?B?VXJRcythZFBBbjNJZStURk9YcnFEY1FYYm1uY0hka2ZjOXhTdTI5aFpTWmt1?=
 =?utf-8?B?a2lDRk5xWUYrNVNlcU5RazltajF0N1U2eFpBQXFFY2gvMmowdTc5andlYTVm?=
 =?utf-8?B?a0EzWndvVmNHL25Jb2NsV05YaTQ1ZHBsMjhoSisrODBSZUkvZ1E2WkMrWENz?=
 =?utf-8?B?bHlyNWxYVEg1ZE9HZXBXcmdtNCtmcCtqNlJiUmJhYk5IUFc2cTNGQ3VDNlJX?=
 =?utf-8?B?MWFmeWJuM2p1NlJSa0ZxVlJqQ0FYL0ZJUUp5dEMvYmZseDltYlAzSzY3eTlx?=
 =?utf-8?B?TEpDVFBpQmxTb1FCNmNMZkIxa1R3Q3hkVWN0d1gwK0EycTNIVVRFc3dwc0Q3?=
 =?utf-8?B?R2ZvMlBRazJKNWViRzFObTlnQStkUzFUZDk2VDZKVjhoZjd0SVBZOWdyaW1v?=
 =?utf-8?B?MXdQcEs0TXoreWg4UDh6Y0tDeHVSd2t2N2xPMWxMYlZ2MVNub2VoL09wSGdZ?=
 =?utf-8?Q?FU7lb+nrR2zHBI9k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 63b03ad6-d008-49ca-4522-08da17b0acdf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 09:34:40.9905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ymsg5yFZW2o6gpIVSo1gob/0CdBlJyhbe7yb6UbOyzCpwbWOX+Zuee2j71r4WvD79oi2/jiFUrvDXIZfMtu4Jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3604
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 10:44:12AM +0200, Jan Beulich wrote:
> On 05.04.2022 17:47, Roger Pau Monné wrote:
> > On Tue, Apr 05, 2022 at 04:36:53PM +0200, Jan Beulich wrote:
> >> On 05.04.2022 12:27, Roger Pau Monné wrote:
> >>> On Thu, Mar 31, 2022 at 11:45:36AM +0200, Jan Beulich wrote:
> >>>> --- a/xen/arch/x86/efi/efi-boot.h
> >>>> +++ b/xen/arch/x86/efi/efi-boot.h
> >>>> @@ -568,6 +568,49 @@ static void __init efi_arch_video_init(E
> >>>>  #endif
> >>>>  }
> >>>>  
> >>>> +#ifdef CONFIG_VIDEO
> >>>> +static bool __init copy_edid(const void *buf, unsigned int size)
> >>>> +{
> >>>> +    /*
> >>>> +     * Be conservative - for both undersized and oversized blobs it is unclear
> >>>> +     * what to actually do with them. The more that unlike the VESA BIOS
> >>>> +     * interface we also have no associated "capabilities" value (which might
> >>>> +     * carry a hint as to possible interpretation).
> >>>> +     */
> >>>> +    if ( size != ARRAY_SIZE(boot_edid_info) )
> >>>> +        return false;
> >>>> +
> >>>> +    memcpy(boot_edid_info, buf, size);
> >>>> +    boot_edid_caps = 0;
> >>>> +
> >>>> +    return true;
> >>>> +}
> >>>> +#endif
> >>>> +
> >>>> +static void __init efi_arch_edid(EFI_HANDLE gop_handle)
> >>>> +{
> >>>> +#ifdef CONFIG_VIDEO
> >>>> +    static EFI_GUID __initdata active_guid = EFI_EDID_ACTIVE_PROTOCOL_GUID;
> >>>> +    static EFI_GUID __initdata discovered_guid = EFI_EDID_DISCOVERED_PROTOCOL_GUID;
> >>>
> >>> Is there a need to make those static?
> >>>
> >>> I think this function is either called from efi_start or
> >>> efi_multiboot, but there aren't multiple calls to it? (also both
> >>> parameters are IN only, so not to be changed by the EFI method?
> >>>
> >>> I have the feeling setting them to static is done because they can't
> >>> be set to const?
> >>
> >> Even if they could be const, they ought to also be static. They don't
> >> strictly need to be, but without "static" code will be generated to
> >> populate the on-stack variables; quite possibly the compiler would
> >> even allocate an unnamed static variable and memcpy() from there onto
> >> the stack.
> > 
> > I thought that making those const (and then annotate with __initconst)
> > would already have the same effect as having it static, as there will
> > be no memcpy in that case either.
> 
> You cannot annotate non-static variables with __initconst.

Oh, I guess I've never realized.

> >>>> +    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
> >>>> +    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
> >>>> +    EFI_STATUS status;
> >>>> +
> >>>> +    status = efi_bs->OpenProtocol(gop_handle, &active_guid,
> >>>> +                                  (void **)&active_edid, efi_ih, NULL,
> >>>> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> >>>> +    if ( status == EFI_SUCCESS &&
> >>>> +         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
> >>>> +        return;
> >>>
> >>> Isn't it enough to just call EFI_EDID_ACTIVE_PROTOCOL_GUID?
> >>>
> >>> From my reading of the UEFI spec this will either return
> >>> EFI_EDID_OVERRIDE_PROTOCOL_GUID or EFI_EDID_DISCOVERED_PROTOCOL_GUID.
> >>> If EFI_EDID_OVERRIDE_PROTOCOL is set it must be used, and hence
> >>> falling back to EFI_EDID_DISCOVERED_PROTOCOL_GUID if
> >>> EFI_EDID_ACTIVE_PROTOCOL_GUID cannot be parsed would likely mean
> >>> ignoring EFI_EDID_OVERRIDE_PROTOCOL?
> >>
> >> That's the theory. As per one of the post-commit-message remarks I had
> >> looked at what GrUB does, and I decided to follow its behavior in this
> >> regard, assuming they do what they do to work around quirks. As said
> >> in the remark, I didn't want to go as far as also cloning their use of
> >> the undocumented (afaik) "agp-internal-edid" variable.
> 
> Actually it's a little different, as I realized while re-checking in
> order to reply to your request below. While GrUB looks to use this
> only "just in case", our use is actually to also cope with failure
> in copy_edid(): In case the overridden EDID doesn't match the size
> constraint (which is more strict than GrUB's), we would retry with
> the "discovered" one in the hope that its size is okay.

Hm, the specification states in EFI_EDID_OVERRIDE_PROTOCOL.GetEdid that:

"Returns EDID values and attributes that the Video BIOS must use"

And since EFI_EDID_ACTIVE_PROTOCOL will return
EFI_EDID_OVERRIDE_PROTOCOL if present it makes me wonder whether it's
fine to resort to EFI_EDID_DISCOVERED_PROTOCOL if the problem is not
the call itself failing, but Xen failing to parse the result (because
of the usage of must in the sentence).

I think it's fine to resort to EFI_EDID_DISCOVERED_PROTOCOL if
EFI_EDID_ACTIVE_PROTOCOL fails, but it's likely not if the call
succeeds but it's Xen the one failing to parse the result.

> > Could you add this as a comment here? So it's not lost on commit as
> > being just a post-commit log remark.
> 
> As a result I'm unsure of the value of a comment here going beyond
> what the comment in copy_edid() already says. For now I've added
> 
>     /*
>      * In case an override is in place which doesn't fit copy_edid(), also try
>      * obtaining the discovered EDID in the hope that it's better than nothing.
>      */

I think the comment is fine, but as mentioned above I wonder whether
by failing to parse the EDID from EFI_EDID_ACTIVE_PROTOCOL and
resorting to EFI_EDID_DISCOVERED_PROTOCOL we could be screwing the
system more than by simply failing to get video output, hence I
think a more conservative approach might be to just use
EFI_EDID_DISCOVERED_PROTOCOL if EFI_EDID_ACTIVE_PROTOCOL fails.

As with firmware, this should mostly mimic what others do in order to
be on the safe side, so if GrUB does so we should likely follow suit.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:41:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:41:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299779.510961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc29v-0002dn-MF; Wed, 06 Apr 2022 09:41:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299779.510961; Wed, 06 Apr 2022 09:41:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc29v-0002dg-J7; Wed, 06 Apr 2022 09:41:03 +0000
Received: by outflank-mailman (input) for mailman id 299779;
 Wed, 06 Apr 2022 09:41:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc29u-0002da-A5
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 09:41:02 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a9b4c8f5-b58d-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 11:40:59 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9b4c8f5-b58d-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649238060;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=/kGwXS8dZVc3ZZR3yfVSfNArjoX/I0Ua+HY0llXNokQ=;
  b=NZt2zalxb4NVP1C69AW5IXjd9wrzJFkgkDb31q1bzaPqaIPCwECCvEEA
   /Gi7IpfSUP8cD9DnounSv3Epo7uWVLh+aNWNfOQvIIeAAabZOWi2ThYbJ
   XrZThEB8QF3NsRChcIoKWxotNkr/MgdN/FY5WoYgtlRk+/MS41KfCEOWe
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70536502
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wD1vU6NJ0A0aF9DvrR1Hl8FynXyQoLVcMsEvi/4bfWQNrUp202NVz
 zdNXj2CaP6JMWegKot+YNuxoxkGuZHUy9AySwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tAw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9
 44V6aazbiQSGZbMx+g+UUFELyxAFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwg29t3Z4TRay2i
 8wxZTQyaknsSgZzNxRKGps1uM2r1mv8fGgNwL6SjfVuuDWCpOBr65D2O93JZpqGTNtUhW6Du
 mvc+23zRBAdXPSTxjaI/WilrvPeliP8HoQJHfu38eACqFGL3WkSFB0+XEO2u+WkkVW5X89DK
 ksS4Wwlqq1a3E6hQ8T5Xha4iGWZpRNaUN1Ve8U44QeB0LvJ4C6WA2EFSnhKb9lOnN87Q3km2
 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgc/iTQsFFVfpYO5+cdq00yJHo0L/LOJYsPdJmqon
 wqJiwsFoI4T0sIo1f2nwV35qmf5znTWdTId6gLSV2Ojywp2Yo+5eoClgWTmAeZ8wJWxFQfY4
 iVd8ySKxKVXVMzWynTRKAkYNOvxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj
 aK6hO+w2HOxFCbyBUOUS9joYyjP8UQGPY67PhwzRoATCqWdjCfdoElTibe4hggBanQEn6AlI
 ou8es2xF3scAqkP5GPoG7ZEgeN7lnBumji7qXXHI/KPi+T2iJm9E+ltDbdzRrphsPPsTPv9r
 b6zyPdmOz0ACbajM0E7AKYYLEwQLGhTOHwFg5c/SwJ3GSI/QDtJI6aImdsJItU594wIxrag1
 izsASdwlQug7UAr3C3XMxiPnpu0Bs0hxZ/6VARxVWuVN48LOt/1tvpALsdpJtHKNoVLlJZJc
 hXMQO3ZatxnQTXb4TUNK577qY1pbhOwggySeSGiZVACk1RIG2QlJveMktPTyRQz
IronPort-HdrOrdr: A9a23:CLYciqu65Pd0JfJ6fxPcCixu7skCkoMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN
 gsfJ4Y0I2mdfVmH56VNN1xMvdfNVa9NC4kEFjiaGgPR5t3c04klfbMkcEIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="70536502"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jHmHrT+Yu8TvHOFXkcshNtlu/8Tmd14v/ptabn9ZSTIEx7b973gLmyut1FqFYR3BKFO5u87OBFfTy8wUdOqRK4oQ+xE3L37KX71FYIHnHTSYJoRAekNAXTyb0kfUz5QuyJaNDxZKDQVlllNIZ5rdAtbIsffxLPnEaqTaon0GcBFlli+GoMwnNtOSTynNYd3JFFkr6bA8aoj7udKpgwY7i23+OMaC4ZDOz9r9/3n0MdGXglrPDZCZ/Pa7Z9nHC7JEk0+93iEh7GicQe2hil6zCRLeXMzKOcvk6twwzJlccB86zrsY6AAakQJQXjClKVVCw4F+gprT5gjEx8KKx6KObA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5cMQRrqpmPufUJ5VEl4g2u+SX0Y2ZZKjjMHF5qRiPp0=;
 b=YrL8Eu22ONylrotARX89Hqzi0DxRWovQROC9nhag2SEDAsoxNZuOWbt9KhnMamQoRUP0tuIEunHcyKfFQ858xl6wU3FUzOu5iO1oGrhdq8vQMuzHnrTaH3CW4GQcHjbHvTMpeTx16G8e0lke4HfNj5EwpAIsGacu6/TcCiFCA1tLSZxJxSPcdRrA/Z6PRaTyk8of6Lyopl/Bcizle3KUTbl9tQ1Uj6+mZ49ZoXZJzZvVK9HhCeVi5pGOGtNSK8aVxcT2MVvsyCA6HQmFBbOUo2gygrMk8Rm2WkowIo2KVpQcqZLxzlDGbJWnE9zhzJm+x48zvFGxv0bKdU7apVtrYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5cMQRrqpmPufUJ5VEl4g2u+SX0Y2ZZKjjMHF5qRiPp0=;
 b=L5bOd3UAnPQ7Kkee7Hyotl1J2Cb1CRdXfqeW1e1gqRtv6zr9DmXnHhsLzCnhsbzhYQb99qTmK/e6IKOYOiAW6PEWDgMT1XVcgdKTQuOtHYpJH0Bs9q29vpCTx6vEUMpy76z6yT80d6CIGM/oVdORTCb9l8hXZ1DKY7VFybkpISA=
Date: Wed, 6 Apr 2022 11:40:50 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Jason Andryuk <jandryuk@gmail.com>, xen-devel
	<xen-devel@lists.xenproject.org>, Scott Davis <scott.davis@starlab.io>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
Message-ID: <Yk1gIhr37mK3Exc3@Air-de-Roger>
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com>
 <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
 <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com>
 <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
 <Yk1Ta9ujHBuj+svN@Air-de-Roger>
 <dd4fce17-2625-603b-25d5-3a586a682210@suse.com>
 <Yk1YtHYzS3aAbQlr@Air-de-Roger>
 <48e44681-822d-8e00-a2c8-808984a0cd50@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <48e44681-822d-8e00-a2c8-808984a0cd50@suse.com>
X-ClientProxiedBy: LO4P123CA0001.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:150::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f9194247-3d72-4e4b-5656-08da17b18b94
X-MS-TrafficTypeDiagnostic: BN6PR03MB2739:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB2739C6E2DBB076FDBDBECE258FE79@BN6PR03MB2739.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5ndVtym9R7jgH3IR5JQAmf1fNPN12iACfykx5NPXSonc0BFY1Tkm5hJgVujys/qJ1PBgbfwpd+UQAwFWdmX5JhCe0fvzil39ovyWRlO+/ILLiYK4FrxiscCE97dv8aH6iB3i7O6C868zNDFOmbWL8mPlezaZ6K1Hjlj/phCwTZgQyuevJyNQggYqRqamSH6ALwXLKZGLWIIQKizoEFsoIUXBZVFiCUnh0K16PAaB041Pztoem6Eh877wZt3GQmUZJaP68kbkn/kDsU3m+yMtc/k9y5sS5lcV3O4wcVVH7EhdsU3fXeS9Duov7/lekEgIWz3DVyKV1YvIxvisLDFtj2GoIZUlFcjv4pxGAK0ZtOKa1Ene8NbgRRgE+KjIrmyWewSe7XejauWKz6EnkkiKj1ssgElrQG35INJt/kbIJJMc+mOYQLxdNPJu65xMgCTw1GKiWAWjaw9MbA8jbRXNLt3LfTJ1sjOuyyaACmfae+PGcCmB6usB0v2tjgEe+xGpzTZLgy+NMAulcL/76OcBEvjPLeoOcp2C+TS3WTTJrIJYhSnX7bwDBeF/PTKLVLK74sUt525QZprHQPHUC7quN+K66sUJF651Q82R+SpCPb0kwfMS28MZIfKlViUwucvNDNgOp2/Nm9LcJH+pdU21Ig==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(83380400001)(8936002)(2906002)(82960400001)(66946007)(85182001)(5660300002)(66476007)(4326008)(66556008)(8676002)(508600001)(6506007)(9686003)(6512007)(316002)(33716001)(6486002)(86362001)(26005)(186003)(6916009)(54906003)(53546011)(6666004)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlZ2aUlPZWhRVk9ydXFuaGMxNTFtSGdCR20vaGFIc3VyWWpTUnczR0tYdnAv?=
 =?utf-8?B?em1Pb2RDcE9KVWVzSy9KQkR5aDVLRjhQRGVBemwwZ2V1K1Z6Sjc3eG9FOWo3?=
 =?utf-8?B?eHJOQjNiQ2JKYkUvbzVBZWEvRXFVVUwrRDArZVAvUklKcUd3ZlFZeThHWHQ5?=
 =?utf-8?B?OVNyK3JSU0dmQ3JCWlBHNktvbUJMaGFNcllZaE5QdytFam41V1dMRi80M1Vx?=
 =?utf-8?B?elJNbXVkUHhtUUxzcC95Rk9Za3dKdGhSMVQvU09rd1JZQ1NjejdBTVpvODht?=
 =?utf-8?B?N2paMEZFMDdUN0lIVmpKTGhGWnFrMUkyYjlOR2FqMVhQWEFaMUhUYVFXdmQ5?=
 =?utf-8?B?YWhkT0xaL1ZmbFU5VmxQbjJza1JpZElSenFSQ3pZQlNHakdiZ2xpc2k2aHZO?=
 =?utf-8?B?WDNncHFUb3hDVHlaTithaldqTitGdlNiMkpwUjlOWHJ3ZGl3Y05jdjBpREl2?=
 =?utf-8?B?Zmt2ZTkrUGdzbnlUUGttLzlzQmx0b3BOaThiS2I4OUFxL1dCS3FzSHpyVWk0?=
 =?utf-8?B?M3ZLVUF4cVhyM0JzWGJScEZ1WmF3SlFMeW15OXpUK3RiZGRxb1NiVUdUU0E2?=
 =?utf-8?B?bHk1ZU4zUzNHNHFXR0dOVTA1bmY2MXZoVGlmcGVVSjd0YU1sTEVnT2k2d2FZ?=
 =?utf-8?B?ZnMzZUpCSXhsUTZhWjBLcXdTRjBRdDlISDBDOE14Q2NVaVBXTmZ3SXFpc0Zl?=
 =?utf-8?B?OHJIK0ZDbEpnbU1DSVZ2dzF3YzY0YXhzcGMzWnMwcDVWcnNYQXVxTHF0dUpV?=
 =?utf-8?B?dFc4eTZyWXJYVUNYWnVxMGFTZHg3R2dsRm1pQmFNemdhdEJLZ3U1cWZTNzZ6?=
 =?utf-8?B?dWoyYWpvbCthVlIxdFNzSVk5NmppV3JpbTBvUHZuV3dkMDRadi9iMEwyWFJv?=
 =?utf-8?B?ZzRNRVFpSTkxZ2NSS3hGNldycnVWR3RIL0lxa0xzenM1L3B1UlZ4WmZzM20w?=
 =?utf-8?B?U21XT05mZUNNaUxaeE5kOUhwZThDYzV5dFpnaCtFTXZUbEV2M1NaOHZ3RGRX?=
 =?utf-8?B?Wmd2bGRxMlBLZGdadlFyZnVDajdSd0FpWkdxcFBOZGhQRlpSL3Jka0lFU21Z?=
 =?utf-8?B?MHR2S3EzdTViT1VwcGNqeSthcnh5L3dEZE5QRXFaa3VuSWJaZ241OU92MW1J?=
 =?utf-8?B?Wm54eWNPbmdiV0Urc3BhZjNCQ3lPNTFmOUdqeWpuMFRhQVd6STR3YWRYV3ZL?=
 =?utf-8?B?MXFjWE52S0NBZDFrcnFXQytvTDhSZmVmeEZTYmMvMi9iUFhLSTZnVXdCc3Rt?=
 =?utf-8?B?b1VvbkJMQzJIUUVsRSthQXAxbTg5WEgvSm1zVHFOZGwraHU2RFpvaXNISnJx?=
 =?utf-8?B?bnBBR1I5NzNUclBtaE9oWStvQjBpSEhkZWlYK1luNnFuWHdrMnRFNkdkMDc3?=
 =?utf-8?B?WE0rSUpxcXdjcVluQTk0SFpYa0I4eSs2ZDNnODRBNDZyRnpUckcxWi93ZGZP?=
 =?utf-8?B?eGJnRXgyaDlFMlg3blpnZ2ZmYmRkL1pEeG8vVEdWOFM2OW9hS0xpYy80K2FT?=
 =?utf-8?B?eENENUVMMU9CVldudk5JMXBTUnA1RG9PanFEaU1SazdwVjZGUVBVSjRPY1po?=
 =?utf-8?B?dVd4aGJsdDBGUlhTLzl2MnhhZklYeE1VL2lDU0h6ZTFvREZjdW9qMm1FQ0s4?=
 =?utf-8?B?dTUzaDFLMVVYU2VPN3lEeWxTRlFQZnpkWXhVY0R4aStmcDhpb1FSWnhqYWtE?=
 =?utf-8?B?d1A2MmhkQzZ0VFR6UUtaRnNoaWtrczJtWWhQMUo5cDFFSVZKY29iWXk2RkZR?=
 =?utf-8?B?TWZqZVRWN25ISWZycWNIOHlQbDRsWFNRVUhrQ21ONEE1djIvS0FaVUxFa2xS?=
 =?utf-8?B?bGt1UHdqVEpKcVpNcGJ6TG4zaTlVT2RPSTZ2WllUZGJTelBQVnUxWWc3cGVG?=
 =?utf-8?B?dldVYnl4eE5OeGdIeXFRNFoxZi9ya0VwSmFKR3ppbXRqN2U1d3oxeUdDVzRL?=
 =?utf-8?B?RGVReTZrRWZDdjZqOUZmOUZpMXcrbnd4WkVrWWpobnIxL3MyaWxvZ0poNXNF?=
 =?utf-8?B?M3F1Z0xhUUpMY3haQ2pnMU53L1pRQ2xaWG02K0t3ejJuOG1CMTBVRjh6WS9p?=
 =?utf-8?B?YVRLRkRjMjRLVDVvL2lHT0hiYlR0Q1c5NjlKMlhUWGRza0hsYlFqeFJDTE5t?=
 =?utf-8?B?WUVQUVNOMmlwT0JpN21jZmc4SWRsMjJaZExtRVEyQjAyb1p2NDJOVWdONGM2?=
 =?utf-8?B?NGhGdmczQmFRK3dBZXBTUEtjQTV3ZEFLZHh1a2ZEcUFsRHZ0YWluTU51cEVV?=
 =?utf-8?B?eUUwQUxCbnVtM3pQdmVPVjZXVjhkYzN5bXA5YjZ4SmNQWkVXZEZxU0dQd1ls?=
 =?utf-8?B?TlVOOVkrZXJIR0QwaXllR2ZmSnFqclBCSXVoNEcvSEhYNngrWVpCMEtleUxB?=
 =?utf-8?Q?gDPa6LbuYkEgeOik=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f9194247-3d72-4e4b-5656-08da17b18b94
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 09:40:54.6157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mQtyYqntGmE9Gyxnb73ywmwHKxJI07TJomiDk9jZejFbMfm9kPQSpQXoHkEvylzl10U1RCZ7IHF4LKDTwe8yrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2739
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 11:16:10AM +0200, Jan Beulich wrote:
> On 06.04.2022 11:09, Roger Pau Monné wrote:
> > On Wed, Apr 06, 2022 at 10:48:23AM +0200, Jan Beulich wrote:
> >> On 06.04.2022 10:46, Roger Pau Monné wrote:
> >>> On Wed, Apr 06, 2022 at 09:06:59AM +0200, Jan Beulich wrote:
> >>>> On 05.04.2022 19:17, Jason Andryuk wrote:
> >>>>> On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith <dpsmith@apertussolutions.com> wrote:
> >>>>>> On 3/31/22 09:16, Jason Andryuk wrote:
> >>>>>>> For the default policy, you could start by creating the system domains
> >>>>>>> as privileged and just have a single hook to drop privs.  Then you
> >>>>>>> don't have to worry about the "elevate" hook existing.  The patch 2
> >>>>>>> asserts could instead become the location of xsm_drop_privs calls to
> >>>>>>> have a clear demarcation point.  That expands the window with
> >>>>>>> privileges though.  It's a little simpler, but maybe you don't want
> >>>>>>> that.  However, it seems like you can only depriv once for the Flask
> >>>>>>> case since you want it to be one-way.
> >>>>>>
> >>>>>> This does simplify the solution and since today we cannot differentiate
> >>>>>> between hypervisor setup and hypervisor initiated domain construction
> >>>>>> contexts, it does not run counter to what I have proposed. As for flask,
> >>>>>> again I do not believe codifying a domain transition bound to a new XSM
> >>>>>> op is the appropriate approach.
> >>>>>
> >>>>> This hard coded domain transition does feel a little weird.  But it
> >>>>> seems like a natural consequence of trying to use Flask to
> >>>>> deprivilege.  I guess the transition could be behind a
> >>>>> dom0less/hyperlaunch Kconfig option.  I just don't see a way around it
> >>>>> in some fashion with Flask enforcing.
> >>>>>
> >>>>> Another idea: Flask could start in permissive and only transition to
> >>>>> enforcing at the deprivilege point.  Kinda gross, but it works without
> >>>>> needing a transition.
> >>>>
> >>>> I don't think that would be right. Logically such behavior ought to be
> >>>> mirrored to SILO, and I'll take that for the example for being the
> >>>> simpler model: Suppose an admin wants to disallow communication
> >>>> between DomU-s created by Xen. Such would want enforcing when creating
> >>>> those DomU-s, despite the creator (Xen) being all powerful. If the
> >>>> device tree information said something different (e.g. directing for
> >>>> an event channel to be established between two such DomU-s), this
> >>>> should be flagged as an error, not be silently permitted.
> >>>
> >>> I could also see this argument the other way around: what if an admin
> >>> wants to disallow domUs freely communicating between them, but would
> >>> still like some controlled domU communication to be possible by
> >>> setting up those channels at domain creation?
> >>
> >> Well, imo that would require a proper (Flask) policy then, not SILO mode.
> > 
> > But when creating such domains in SILO mode from dom0, dom0 would be
> > allowed to create and bind event channels to the created domains, even
> > if the domain themselves are not allowed the operation.
> > 
> > That's because the check in evtchn_bind_interdomain() is done against
> > 'current' and not the domain where the event channel will be bound.
> 
> Yes and no - the check is against current, but that's because
> communication is established between current ( == ld) and rd. The
> function in its present shape simply can't establish a channel
> between two arbitrary domains.

I've got confused with evtchn_alloc_unbound() that does take a local
and remote domains as parameters, but in that case the xsm check is
done against ld (which might not be current) and rd.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:54:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:54:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299787.510973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2N1-0004IA-3a; Wed, 06 Apr 2022 09:54:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299787.510973; Wed, 06 Apr 2022 09:54:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2N0-0004I3-WE; Wed, 06 Apr 2022 09:54:35 +0000
Received: by outflank-mailman (input) for mailman id 299787;
 Wed, 06 Apr 2022 09:54:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc2Mz-0004Ht-IY; Wed, 06 Apr 2022 09:54:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc2Mz-0000zH-Fs; Wed, 06 Apr 2022 09:54:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc2Mz-0005Ap-0s; Wed, 06 Apr 2022 09:54:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nc2Mz-0001QP-0Q; Wed, 06 Apr 2022 09:54:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8EvLfV9v1GBsa+Lq5zEkOnCqCFa48izqnMoJIW3QyFM=; b=2S7RuCxey/NbyLFrm34oNYxqAZ
	RKaKGIiN1/0YC6AJKkvzcsabgo7wP3bctyaGvStMheuLaPGClGx4S1edBJhM2XtuvzqkC92fdl3LO
	fpye29phIfgYn3fKwvDlwD3UcyDiREpEZ56M5PFnxAuanMHgFYhHeWGnuLJ+ai4FJYqk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169187-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169187: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=a298a84478053872ed9da660a75f182ce81b8ddc
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 09:54:33 +0000

flight 169187 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169187/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 a298a84478053872ed9da660a75f182ce81b8ddc
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   36 days
Failing since        168258  2022-03-01 01:55:31 Z   36 days  281 attempts
Testing same since   169173  2022-04-05 05:13:00 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4610 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:56:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:56:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299795.510984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2Ot-0004tr-GN; Wed, 06 Apr 2022 09:56:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299795.510984; Wed, 06 Apr 2022 09:56:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2Ot-0004tk-D8; Wed, 06 Apr 2022 09:56:31 +0000
Received: by outflank-mailman (input) for mailman id 299795;
 Wed, 06 Apr 2022 09:56:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZBRP=UQ=wdc.com=prvs=08844476d=Johannes.Thumshirn@srs-se1.protection.inumbo.net>)
 id 1nc2Or-0004tV-1L
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 09:56:29 +0000
Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cf8dcab0-b58f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 11:56:22 +0200 (CEST)
Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47])
 by ob1.hgst.iphmx.com with ESMTP; 06 Apr 2022 17:56:16 +0800
Received: from PH0PR04MB7416.namprd04.prod.outlook.com (2603:10b6:510:12::17)
 by DM6PR04MB6607.namprd04.prod.outlook.com (2603:10b6:5:209::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Wed, 6 Apr
 2022 09:56:17 +0000
Received: from PH0PR04MB7416.namprd04.prod.outlook.com
 ([fe80::a898:5c75:3097:52c2]) by PH0PR04MB7416.namprd04.prod.outlook.com
 ([fe80::a898:5c75:3097:52c2%3]) with mapi id 15.20.5144.022; Wed, 6 Apr 2022
 09:56:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf8dcab0-b58f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1649238982; x=1680774982;
  h=from:to:cc:subject:date:message-id:references:
   content-transfer-encoding:mime-version;
  bh=G8FZ0D3PP/OudJ5uuxCAz/C/vBHo8wESZoPwxTWqVEI=;
  b=JIKHihNGnbEQ3W7dNONvT0Zo0ig8aB4rhGiUnglEBT2abQ5Pww5HRzwr
   NK3cZbEOwYe0EsJGM14rQRLxhHQ5K/x5NnZfESKClC8s2/ldZIxuOcQS3
   kuY3wsVSIBxSanDOb8On07AyWGe+ZuOgdyae39XQe3MPZdRW6qfxlpniH
   1fRgeb3UtGQLIy6wHdA4eDw34KwrUxgwAWkCx97swHWTddelxFfc+u8PF
   a3oTcAo8VpjIAuJC9K/ANFV9q5HQsupkk5XEaLX54Lnfyth3QHItDy48a
   EHvuAlCqkueYNIkBNKoxHJO5UfK283hOPDuXfgDWbd442wvsLC739oAij
   A==;
X-IronPort-AV: E=Sophos;i="5.90,239,1643644800"; 
   d="scan'208";a="202070883"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V05NAY6D5JNITXI7Uynm69uEjjVcBnSlpyCo87ZK+7VNb/vNpbU/FGi3Zm4n+QsXvV1R2M1mgUcaKgqXWKOBs2MmOnPHYOx0mf5YYQxnoM0AvkShgu1SyoboY68Dx2zKl8Uf4iJOhncIA6vDQqIJDIdaFpGoex90SHXJLbRjto2Ef1HuPvBnk7DYH2DSgjpEIal8qfyhxm7iPcopbTERi4WlXQFT79jCEr4w8lN9FM/RSSqMKtf8VRPLa2YJcz1sapScY8eXJVZIAqJjsQ2RMIgmspOZD6lvtMEO9wHdsTMzcimJpOVt4KtmbfYaKSPV+mrO6yGHsR3rAIS7Kia8WA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G8FZ0D3PP/OudJ5uuxCAz/C/vBHo8wESZoPwxTWqVEI=;
 b=GjJh9NCq/Gzn6rw2u6uDpjQ6iYwYWd9FZiQMYL+8Y7mbz+iUBERKxG8T6yP66B0dOfFFO3vwnwjHhL5cJ7a14/ttIVmBAsA2+Jf88E3WxyK/Iwt+gdPSl1hZzqGnhyTvPOGPa3cms9QugMUwvUl3E+fV7y9d3Vf8fvQQLly8o1BfZeop4ARAM6/koy+tRR4xEkvdn3W9PV2LAN97amtjDqfLzQJdk6A4uClpSTUQwWSKzDOf+30fisQzsnMASBz0qLgsVwakbzxZ33qMj0NcGRFCbSH5XkhyUqip/aXo9Vx4B9O6QU5tp244DdVW0Dp4N3sLx3xdz9wP97RhrVKPlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass
 header.d=wdc.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=G8FZ0D3PP/OudJ5uuxCAz/C/vBHo8wESZoPwxTWqVEI=;
 b=h54PSavZiCLPvRz23Tg4lVZ4eo4TKNMgHAWOAetI02cemxA+lChC4jRXXc8PjhI9PpOfpk4p+MbkbZh9C5rjse+BNktIEqyQrd9A+SZwSDKo/qziD0BGPaKZXMgxzonamG8DYo93OQ1hSVvzQSjS+8JMtRvaZ5G9kcajf+Hcwbk=
From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open
 coding it
Thread-Topic: [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open
 coding it
Thread-Index: AQHYSZhFjrFhkOtPTU+vji2wK2+0AA==
Date: Wed, 6 Apr 2022 09:56:17 +0000
Message-ID:
 <PH0PR04MB74169FBB31E68E76E34DDAC59BE79@PH0PR04MB7416.namprd04.prod.outlook.com>
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-8-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=wdc.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bcb98ed4-cc62-4a3f-8a01-08da17b3b1bf
x-ms-traffictypediagnostic: DM6PR04MB6607:EE_
x-microsoft-antispam-prvs:
 <DM6PR04MB6607721F18B062BF57BF16C19BE79@DM6PR04MB6607.namprd04.prod.outlook.com>
wdcipoutbound: EOP-TRUE
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Nk2MJlm/r7uGtMIckrZ8/20DB84cHxXsyMPbPfGUVCbeLXDLxGaUBQM+iMbI0TIDMo8ybZcbg05B1l9oYxnCRDXiZkCfwL3sn98KZz49BhXqro2r1QD7cS1mUSAk52FIyznZ4v0Klb7TdN7t9KQcVo5GmjUcoyVro/T9NgdLhj55YUmzdMDKplWtvSR6br8YGC4S6tSCcTufSCuVvWT4UQ8n1zjpHCFVe4BHJ9HrIIcshXSnzVylfjU4RVUlTcWWznKi6E4q39IhnKk5tf0BjqmepnIOk3fA/n3MYk5dt47VBb3YFRTpkcX4/AFxtQC6VeUbKz9kKrwIxEi0zkZzLqmByyavkn9KDz7K1VUmM/IBgoJr+SdhhFpqcVBbjI34GNuS4i+tZ7mVmk3cHDbtKp8ZKZQB9EbL4QTCET7woB2SFLYFet5MlheD4eympyeAVgxzOTRGC0mQ7sBtQju+XlfkXIn0knIcLEYqswn28rGiCm+seMTcuTaukFfRvCjLv0fCsdkgIkp1enerhTohsdwWdDbZ+yq1L0ErZ2hSg1TGMszTXRTYRgoHxgKx6q6lnVf/EjZaac5fApQ86UVZVvJk2ZmXDrDAHY9W8X5FhQ65nRgId2WPz7Iaafh/jz8PnSfbw8pn8JGOOzrL06MADBo07mPq7omMiRg4rfqsamruR3NxRnLLR0oUXZQi/Ur9Rb8aQlEHzL6upjizBkGf+w==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR04MB7416.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4270600006)(9686003)(508600001)(186003)(6506007)(7696005)(2906002)(7416002)(5660300002)(55016003)(8936002)(54906003)(19618925003)(316002)(71200400001)(110136005)(66946007)(52536014)(91956017)(66476007)(66556008)(4326008)(8676002)(64756008)(66446008)(76116006)(122000001)(86362001)(558084003)(38100700002)(82960400001)(33656002)(38070700005);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?OcznZgIADteDPeFOUq+CN6sBYP+/kmW3D5j7xx/K5X/J7+64nNzLXNZa+5ah?=
 =?us-ascii?Q?0ZgohPpwD570vI6niIUBqcq2mCCC4bPs3HF9If0pDTXYMHbI5tpo+6uU1ajy?=
 =?us-ascii?Q?GGFzW70IH51vjuIirLPrIWVPk5C5eXCcUNZzJcSEIE6PNPIKJh8vD3O1Gvk4?=
 =?us-ascii?Q?1JMEcCgnGyp8YHCCJNHAPDicTDwIRgbtUTLad92MTeu9qzZjwWCkwywcvQwt?=
 =?us-ascii?Q?MQCZ8nki7Ux40zqnfiHYW+AhE2QGn4PDo5ixzVfwJ5/CUh3lM+9R2CPt1KPy?=
 =?us-ascii?Q?xMEWdeuD60BMfglDOIbAaCEfUj65VFnSDiAftlXQ+XaObFIxp/QPxtBkAMAk?=
 =?us-ascii?Q?rjtGO6aBO8v/hwlPRrlzKYyRMFzUupk4CNGmWt3Z2IlK23bdO/HzsNLxTdvx?=
 =?us-ascii?Q?F/ab1WHMG/SfMEs+/cPEMU62hGIc40jgnlkSc4dGNIFAdBiguKYZaGG40axo?=
 =?us-ascii?Q?QLghxYfv64zM0N2OzXk9KtGnE5SAQwTZzdmHpSj/wkFPfGDPZSJcP/D8E5q6?=
 =?us-ascii?Q?e4ZjHnyW0TJ/kaldqrqvKSXkAYfCuDulEO9Ab8xhUwNp4Z6iVdFGrfFukliC?=
 =?us-ascii?Q?l+OkRH0ECfZcpim6uUsWVelANXXl0CYIxLtvhYnbWq7F9uER2Gkwgy7QJsaF?=
 =?us-ascii?Q?a628Srj0r2WumyRX4DssaZU2WCZdNF3VVjs8bZD1nIlEGU9begPUu+HJu5+k?=
 =?us-ascii?Q?x1i/41euwTUu5uPNfIvdcGf9IExlDD8h5yt9mzd1KFjeMoll1jNgV6rNH27u?=
 =?us-ascii?Q?n5RoeaGlsbgmvdc7mJ/LXpfVAwT4SqZjDcAintezx/IwTSs1nMq0ijtjMwj5?=
 =?us-ascii?Q?ktv0vvU+Seq3y6wA12FQwXNEnpCfZv6o3c9BSVhlkXduwFn0p9Qt/8y9VCoL?=
 =?us-ascii?Q?XSPsZoCBzzT2ubGt9sHwVpS1BkHCBUBhQoQewbrEeCa29DVl3ed+DkaZ8ob+?=
 =?us-ascii?Q?Nc5IThF/mXr1dysBDqiFaJyPY8uUJxrJOYRV7lKrRp4UsCFiyI+7/o2Rgpmr?=
 =?us-ascii?Q?fTzaqvAujVgknGtvFcFfmCIjItgOkWsyLomudA7hPeq4uzzkCKSK0pOdMohG?=
 =?us-ascii?Q?X0UwxPRIaa0N4ZT+pMwBlMt5dzNpoaPZWDDf4JU4m6hNClFZ/x+wQyKM7e2y?=
 =?us-ascii?Q?UJsUD6GGV4bwKlrdEdWAOgCxyxpiC2djuoWWy4g85tnBZ+XqkQfUw0RZXcbQ?=
 =?us-ascii?Q?fK9KiSv+3KpPfWsDnOvBYOPszdjmONcj+hhzHBnSIYEbG21zO8z5mklY9mQg?=
 =?us-ascii?Q?7oYXPYninSoU/jB0VOwqNhE0A0vfGE6us35k0t6QTwwy7q5O+N4/zEl0qjI/?=
 =?us-ascii?Q?1I+wpUkDObvtm8TDU0hWXPgNkTPh8rsoO8KSJKQNVkU+ZozXt2Tscv8yBG1R?=
 =?us-ascii?Q?W6JpbZs64SuI3PGS7YENHXSzLCdWvwvbrl1brK2kEsB9pZAdOVRNpYXpfZk4?=
 =?us-ascii?Q?jkdiLxCmn8+Pcw+yl9h2w1w7W/ZHIyg9ueLehxJUo/iNEEGOuZzyejQK+rxe?=
 =?us-ascii?Q?crCPwopA2pduPyJjACdthNl8guUPhrkN6l9z3DswDYdOLK8XUOmi1J6cRYPp?=
 =?us-ascii?Q?YQE71i+MmFCGHlMV5PsmiLWXzSqROnXLPiyWMThDmeKTHGbO4cWOsQUXdgcw?=
 =?us-ascii?Q?ThDnH0E0c6RYiqUF0XGnbh/5zrSNZ67EW1UzQM2DDgrbheYQZNPfPnwzrsX7?=
 =?us-ascii?Q?wGWLt6hh6RYPBUxbuI06xXGPdpEjZtYHTk9G2Z1PbKhVxooLrjGgvlZepxHD?=
 =?us-ascii?Q?ESS+vxrYZAlXP1aqBsNdF0KHRkGfUwam9adbrdHQogei2n0gj35+KZLyAQRJ?=
x-ms-exchange-antispam-messagedata-1: srMZBCvbXKwnVy/kz7Xcntl/ozUqZq/HpIw=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7416.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bcb98ed4-cc62-4a3f-8a01-08da17b3b1bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2022 09:56:17.3333
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lPW8HtDsBeFYCtcSfoUiCOuBbQaewM1lFtcu2MbVcViHTWVnuqNjO14Ik1QVllpEu4CmuoDpR6lIPDCOe3F2OgQTSlM/31m3s23SGbVrgRY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6607

Looks good,=0A=
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>=0A=


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 09:59:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 09:59:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299799.510995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2RD-0005bZ-V4; Wed, 06 Apr 2022 09:58:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299799.510995; Wed, 06 Apr 2022 09:58:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2RD-0005bS-QL; Wed, 06 Apr 2022 09:58:55 +0000
Received: by outflank-mailman (input) for mailman id 299799;
 Wed, 06 Apr 2022 09:58:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZBRP=UQ=wdc.com=prvs=08844476d=Johannes.Thumshirn@srs-se1.protection.inumbo.net>)
 id 1nc2RC-0005bL-3T
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 09:58:54 +0000
Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 278293a9-b590-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 11:58:50 +0200 (CEST)
Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42])
 by ob1.hgst.iphmx.com with ESMTP; 06 Apr 2022 17:58:45 +0800
Received: from PH0PR04MB7416.namprd04.prod.outlook.com (2603:10b6:510:12::17)
 by DM6PR04MB6607.namprd04.prod.outlook.com (2603:10b6:5:209::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Wed, 6 Apr
 2022 09:58:44 +0000
Received: from PH0PR04MB7416.namprd04.prod.outlook.com
 ([fe80::a898:5c75:3097:52c2]) by PH0PR04MB7416.namprd04.prod.outlook.com
 ([fe80::a898:5c75:3097:52c2%3]) with mapi id 15.20.5144.022; Wed, 6 Apr 2022
 09:58:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 278293a9-b590-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1649239129; x=1680775129;
  h=from:to:cc:subject:date:message-id:references:
   content-transfer-encoding:mime-version;
  bh=G8FZ0D3PP/OudJ5uuxCAz/C/vBHo8wESZoPwxTWqVEI=;
  b=gO5sYhwoOEpuM+VbqiaYk9RHZQUyPEIgUVvoYz8FCKuGYFaYcTt2lDsf
   7kJzRGaTjr8FyrsrTqdlRc1J8v+/1iqk84hTwZUn4tWaclI5qeJUxa3R1
   GjgHu3Mq7cpWcpJ5XeYLqDjLXObWwsw6RdQKtmlR6T4zVju5nnLlNsoHW
   OXnmReXbph9J4mZBJPs179r5z+N3/me8jOQYhUD5Dp1ln/65sOZXY7u4K
   txeImetNsVX9U19NegJLjcIk8RsYJte83Dr4cNmIrP3DHxvVe1ONS9gTw
   Qvpzlhz9Z8e4CiaJ72XGpgy6djn2vm5G4nf281cB+HZr1lOFimG7/bN52
   A==;
X-IronPort-AV: E=Sophos;i="5.90,239,1643644800"; 
   d="scan'208";a="197229644"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZywV7ltuw9siQImxgkQoPP6wfeZPfN+DIbYHoqvFqg8PspHMPPVbjOGu34Y1VCFutPfcbN7w1CG9uIcpq7NyPeQGhoZepeW1TOBP2zlcPqBmDXXzU/6c4WbvphC7Vg116kMB0hFPBg7c0Q8rkL+JUb9EXS6dJaeFy2qxfVUyz6z5nIddZ1wFqqzpUGT5JOGzqrfslikOn+wgvc+mUxHDocSWTysyYNK8wrMgO8wpoMwwUIy+nw0WFak2qxflo6GZSub70OFUZwWc0j4ME1BjgYxeSUHxKV4AKu7Di064nEfOqWFlcU+DqH/AlhZbI61biQSOcOMiOF9lEL7ZElf4dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G8FZ0D3PP/OudJ5uuxCAz/C/vBHo8wESZoPwxTWqVEI=;
 b=AbViV6LyHbwBkCkSSzHf7MhBfjPBdr54WKxpT8TH/IU79sCSAQffxHuxJ9RNY2EzqxKBO+p/CtlU2dIfFhcVyLKexjvE2GMJkTgUnVGgE8ZOGiAjsWqGZCz+S4s0fi2KF7ovt1G+WQXRH9g/XDe2khg/oNuFANUcA0NsqpLGuhYCzvHSwii3EIBQFNHKMIid6CPBxGtrz4Mt5DenDBgz5WpbjSMua2zobVu8OimqR7cgihpvHcnC6bLPpJAgTQfi0XWpFkQ8aMP4PqpPSOJMwa8Rj/g7k4SszozuP84H/nQt/5puzDMJImjRpwNl+TA3FTVQjs1S5PLAZKzjLAUHxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass
 header.d=wdc.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=G8FZ0D3PP/OudJ5uuxCAz/C/vBHo8wESZoPwxTWqVEI=;
 b=vanbsnJo4FhAc05B4EMLdoIDZnZc6CnMGAlQXIgKOZVYA6DbT80UxMUlZ/wZQXpK2g5bXanvTRVKrwfWuZkUTgFBF43n8wxbCegEebQVh5Yb5s9fBVE6XXBs8KIPE7Ai+IRlVXIjfihcLTETxl4No0fuwffum1oyx+1efB7QykE=
From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 14/27] block: add a bdev_max_zone_append_sectors helper
Thread-Topic: [PATCH 14/27] block: add a bdev_max_zone_append_sectors helper
Thread-Index: AQHYSZgY1jr1xIM/YUq07NGHawfBLw==
Date: Wed, 6 Apr 2022 09:58:44 +0000
Message-ID:
 <PH0PR04MB74161D2CCC5AD43AF09264799BE79@PH0PR04MB7416.namprd04.prod.outlook.com>
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-15-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=wdc.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2f6a7f3a-4bbd-4cc2-85a2-08da17b40972
x-ms-traffictypediagnostic: DM6PR04MB6607:EE_
x-microsoft-antispam-prvs:
 <DM6PR04MB660754EAC2F7575A81C46B4A9BE79@DM6PR04MB6607.namprd04.prod.outlook.com>
wdcipoutbound: EOP-TRUE
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Pf+KzgmagSIS5atE7qUNGRr1myBVVGSwEKyeGnwHdGjwF8GKBkvoIHDqMGnWFjO7XVa7Cmit9VnU9OIYztUkoZ6Oaqq+m+DiWH3/Dcl/UxK+P88E3f1isC2vpAnDpZpqgSoxQyKuSo19P3TzE/8glOLI6z0BLxqJa3LBIp+eJLbka+iU9uRCJGcYyq2EzzvF+GSwaV6/rfbL34RfHGjSRx0zwHlAe3Kbe4uou4XPkMqQqujVK+FspM3sA99WzgIx4Zcg+5oQR1jIyR4eA4XENp/K0m69Xx8aQEVd4C4NwBIAYB3DJbFAzY/xwFTEh8jZCLaKfZtso51HpFNskLoQWcTVyjcyZmpcj72RYBDj8bY8b+y0gW5f99u30BEwD03iXMk539DztkZxuC2HzN3BPR9e7KwNaRwwncQjXFedlJ7i/0TsMz5nf+dZ1/3hTsc6CrDt4p9WXnzuh263wo3xd8b6MW4eTv1TtLR3IzWdMRJG6cBeGO9RPQAMiItBrNypFxmRFeU4T1cp36pirzbw2w/ywCTEUkYc9uazSWAmIkbs2ELSVlHFGtwIR9gzIB7PlEGWJvLVp2CUKQFt3mcwlEIarIZ+6NjuqDOsMS6YGKX7bI/K6LKHavdoNguno7hvxdITrai2aC+YdO67pyr3n4smmpegwjXfnaI0Pmp9jFcUJll/tJASQJQReuEZSzAgzPzXDpY2hiiRf4a5gE9HNg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR04MB7416.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4270600006)(9686003)(508600001)(186003)(6506007)(7696005)(2906002)(7416002)(5660300002)(55016003)(8936002)(54906003)(19618925003)(316002)(71200400001)(110136005)(66946007)(52536014)(91956017)(66476007)(66556008)(4326008)(8676002)(64756008)(66446008)(76116006)(122000001)(86362001)(558084003)(38100700002)(82960400001)(33656002)(38070700005);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?FnQ2cDOI1Y8dqfwBZ9O49we2ex33sga4MDlqyPsi59CHLjzinNdqahxJKb+7?=
 =?us-ascii?Q?nLvA4glwLQWN5EGlwq9Vu5N+6RAHp5zPzMSHYKAI+ROqS5ObV22YE1uWhKPU?=
 =?us-ascii?Q?t/Slc0Vx6la1V2Ehl/8AFvAWHw7Kk3JevtOLqRNrLr0w3euyxPc4I6O7fPTQ?=
 =?us-ascii?Q?wLfN+Opb6mKJvfOq9BzXaoPuzM535gJJgXGiZQqr6/qzazXpx3T737nbJ/fT?=
 =?us-ascii?Q?5AYtInAAQcaVRXLBBJ6GN9tSCFD9aXABykDN429p4xlLfpuoDafHP6Jt5DbB?=
 =?us-ascii?Q?Iydzn9jRd0E0RXYdxFp2csxTMSqFiUWkGWouJQyBb2zUZOXn7G6VB6J4KuZp?=
 =?us-ascii?Q?fgPATSu1EoTsQYfHXonfg+YKrx8NlCxiY/WvDPDFylow6ArLN9X0TnmQSu+/?=
 =?us-ascii?Q?95IkUf/R+6oTU/6z37jGwKNh1BGImR8Z7zNd/uM1kkUQPDt6xtfwy79ITE6l?=
 =?us-ascii?Q?Q9xvZjwe1VhuWGzbavCQQVHCFV7hHqZE4hFqaAuJ/8loV7GxSt384nH03jh6?=
 =?us-ascii?Q?9hvUXSFWyQok4WycdVBAq2Pne6x63Kd/dzPArvViOJMCNXPPzMfEK2zH+VNk?=
 =?us-ascii?Q?3w+JAGP9eY7icR0QYXZpvCQn8jI2n5T3gvnfOW20uZaiR/w7EP9NAVWC238p?=
 =?us-ascii?Q?YyBdPiC0Py8H4BU3o6Exn/i3teu+O1s1FRXY9XsoYqSfv67wXY2BgOSNYQbS?=
 =?us-ascii?Q?A5HFhEpzP7fd8WRvXw6jIXWJduai4VwRFzBDYyAROlXlWkq4K5uZrnKpDVri?=
 =?us-ascii?Q?Lt5+iS19PHx7Rg1R4wXdhMzRCIjeeZd6PFaYSh3xZnuu+5Y/9ohSG9i7K502?=
 =?us-ascii?Q?1a/bzUyzkQNxTw1tQYH5EyiyC91aNMcH4nxXhtJ0Wedzj7mvIGc92lxOt5nE?=
 =?us-ascii?Q?JXxVC1uDiYmPEFzx4Y7D/dReZPhWqdc/jJdKt2W1YymXQazllgQwdagCnVsb?=
 =?us-ascii?Q?womFEzuPHfgISWVwI5IydynP4xWEHyHSeic/OWVf2vvnSOGfChy1xgRteWK8?=
 =?us-ascii?Q?O6lHklcYNZMBh105u3WOxpHTEenIZDxy4CJyZmOxjyHRyQ4/hAEahlgNd5T0?=
 =?us-ascii?Q?IIYsp55Li1hGb6kle+7E42lhFheoGmLSgVlPzJ2wViUr5JkB3zXPshZNHdCK?=
 =?us-ascii?Q?Drnr9ry+2eR2o1K0g1sZTYgaa453J2FLPb9EsxMmvl+A368fmvtLSJc6/GHO?=
 =?us-ascii?Q?kvIPug1OZFdbVSPQJnxaWdWK/ZgXRpNAH8KH2/la8sZCkHzfpGIcxpeAnxvp?=
 =?us-ascii?Q?Fu1KO8wFnzRvdlhTkpS+//xvC//Yvj9IUA7H47sdMX0MyyQstXAAASDIKQzq?=
 =?us-ascii?Q?4itpwg8G4I0h6hT1UWz/LYa9haG+XO08rx/HcQSRBLKhwhVFQQ/8TK7uDzGe?=
 =?us-ascii?Q?UrBw7s5v4mnnSjnPPV0U3E8GhTQO8/rq7n7rEAF9/BOb/A895TI4AENRfP2H?=
 =?us-ascii?Q?p0lPtXAfbYI2WYitkaAvMjep+iCpB8qGIW0MlNI4ahmo4gxlHF5/DOEVAML3?=
 =?us-ascii?Q?BsIhXDlHoRVG0p5dRxMkYVIPTIGR3tyHD8mDdRoSdVHc4PDkENOpi0vFrLjM?=
 =?us-ascii?Q?EsYFTB8/yWBXoKQrEy5lf4EqcvGyrksY/i+ncEk0C/qi0ucMo5O259xy4P5n?=
 =?us-ascii?Q?3OstWIQojxiCGjB3QzJ3ozRjmyPwY1cmzijUV+XzsMpKKikC4jRprDn5XJ3B?=
 =?us-ascii?Q?Z+ROJZpHXnIZCV41bUfdPSJQIk3jFqaSY3c3C5xSCmsfRuvM5N+mx+Qv0l5x?=
 =?us-ascii?Q?vgoI5NvxJ4DIaRE4F1vbqPEUlylYZ3nOFgGkB+69touDu3OoVoMGP2adpG05?=
x-ms-exchange-antispam-messagedata-1: pB0amHYuRq2xU5J1OT0zoHwBXpZuYFgg+OQ=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7416.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f6a7f3a-4bbd-4cc2-85a2-08da17b40972
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2022 09:58:44.4524
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cIO2gZbnUPowYwL5/+TFbMlM0mfXcWCM9eVRDLVDk37wzbnptzItElefyoFDRl92/LtkQZrZmaM/CVn+ZNQbb4SjElNyDclRC+u7dyWjvW8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6607

Looks good,=0A=
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>=0A=


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 10:04:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 10:04:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299785.511006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2Wr-00078Y-Mv; Wed, 06 Apr 2022 10:04:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299785.511006; Wed, 06 Apr 2022 10:04:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2Wr-00078R-Jk; Wed, 06 Apr 2022 10:04:45 +0000
Received: by outflank-mailman (input) for mailman id 299785;
 Wed, 06 Apr 2022 09:53:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AJOc=UQ=redhat.com=agruenba@srs-se1.protection.inumbo.net>)
 id 1nc2MN-0004H7-PB
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 09:53:56 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 759baec0-b58f-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 11:53:51 +0200 (CEST)
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-116-ASstld31PC2R9ZbP_mDduQ-1; Wed, 06 Apr 2022 05:53:49 -0400
Received: by mail-wm1-f70.google.com with SMTP id
 189-20020a1c02c6000000b0038e6c4c6472so2733792wmc.1
 for <xen-devel@lists.xenproject.org>; Wed, 06 Apr 2022 02:53:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 759baec0-b58f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649238830;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5YLfltNsQX6JNVdcfXs5JgFiHm7bLb/2vI3xBdu4ui8=;
	b=QDvwmytGJBYFcLAuAlFR8djCWUWaXf9KYqM2RNPYnbnFwcaQ0iLKsEadYQki1nBe/xOQVo
	/dRrwyHYpDh8eKPROoAlmQtwdLMBkdpDaiO7kWI5pt2TmRt3lF6qFDwLmljI1+qN8uve/y
	hHCt242piT9+esBRJHUpq4EQRh5iJSI=
X-MC-Unique: ASstld31PC2R9ZbP_mDduQ-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=5YLfltNsQX6JNVdcfXs5JgFiHm7bLb/2vI3xBdu4ui8=;
        b=7bBbQl2nBXQAC/MPNuDCV4/SJL2KV8viI8Wumflse5V42+Fa8pGlUhs/p9y8+z+JjX
         UV2uEenlzTJCX391RNTRv+7BY2aLn4SdCh86tvvMOiDupTo1ArJtNNmTGU4XD235EHcZ
         prEWUGenm8FWjEuMnArGU4EdbRZHtgMMjbbmCOeNgocPNfUe45pCodd+j+HkmGQJmbpR
         2DMrUQu07zvUpqJfxOG/BYw+wrtoY9kQ5221wC+A6e6HNbm33HAVGChGhRiZE7xSrkPs
         AEqDtDySNE7v5dop+hse1qQjliVQ5TcTt8zQ0oumXRR8xjfutHbOcDnq1EsuxkbPuYsQ
         qo3Q==
X-Gm-Message-State: AOAM532EGv7EvGvYvbEPDeK7nNe8zbB6KWQvDNL8I5xjQdajuxcRW65h
	zfI1WOHkahHWRZuu221iX8IbqfoKz6A4+mi6H+f/NCRK3KtFSmSpFGMlBG4ytuSexa3gZcsW43w
	Cxn9dUV2v6U0o5ZDeoZ8/XQ1CS23jw+XVwbm9+g3Z6oQ=
X-Received: by 2002:a05:6000:168e:b0:204:f92:53e9 with SMTP id y14-20020a056000168e00b002040f9253e9mr6147844wrd.349.1649238827563;
        Wed, 06 Apr 2022 02:53:47 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx42UTKiXkjFd7vBE49MzUEoFIKgzGGnrD3yn13Cn5diYp72Y7jfRYqMuzHs0kGH57x/uOLoIWIGJtse90Yx4g=
X-Received: by 2002:a05:6000:168e:b0:204:f92:53e9 with SMTP id
 y14-20020a056000168e00b002040f9253e9mr6147779wrd.349.1649238826610; Wed, 06
 Apr 2022 02:53:46 -0700 (PDT)
MIME-Version: 1.0
References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-24-hch@lst.de>
In-Reply-To: <20220406060516.409838-24-hch@lst.de>
From: Andreas Gruenbacher <agruenba@redhat.com>
Date: Wed, 6 Apr 2022 11:53:35 +0200
Message-ID: <CAHc6FU7oZ5HW+JYLp9SxEnE5_i=nZCgBYfWLQk9RR+9M151D4w@mail.gmail.com>
Subject: Re: [Cluster-devel] [PATCH 23/27] block: add a bdev_max_discard_sectors
 helper
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, jfs-discussion@lists.sourceforge.net, 
	linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, 
	Linux-MM <linux-mm@kvack.org>, dm-devel@redhat.com, target-devel@vger.kernel.org, 
	linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com, 
	linux-s390 <linux-s390@vger.kernel.org>, linux-nilfs@vger.kernel.org, 
	linux-scsi@vger.kernel.org, cluster-devel <cluster-devel@redhat.com>, 
	xen-devel@lists.xenproject.org, linux-ext4 <linux-ext4@vger.kernel.org>, 
	linux-um@lists.infradead.org, nbd@other.debian.org, 
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, 
	Ceph Development <ceph-devel@vger.kernel.org>, linux-raid@vger.kernel.org, 
	linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, 
	linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, 
	linux-fsdevel <linux-fsdevel@vger.kernel.org>, ntfs3@lists.linux.dev, 
	linux-btrfs <linux-btrfs@vger.kernel.org>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=agruenba@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 6, 2022 at 8:07 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Add a helper to query the number of sectors support per each discard bio
> based on the block device and use this helper to stop various places from
> poking into the request_queue to see if discard is supported and if so how
> much.  This mirrors what is done e.g. for write zeroes as well.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/blk-core.c                    |  2 +-
>  block/blk-lib.c                     |  2 +-
>  block/ioctl.c                       |  3 +--
>  drivers/block/drbd/drbd_main.c      |  2 +-
>  drivers/block/drbd/drbd_nl.c        | 12 +++++++-----
>  drivers/block/drbd/drbd_receiver.c  |  5 ++---
>  drivers/block/loop.c                |  9 +++------
>  drivers/block/rnbd/rnbd-srv-dev.h   |  6 +-----
>  drivers/block/xen-blkback/xenbus.c  |  2 +-
>  drivers/md/bcache/request.c         |  4 ++--
>  drivers/md/bcache/super.c           |  2 +-
>  drivers/md/bcache/sysfs.c           |  2 +-
>  drivers/md/dm-cache-target.c        |  9 +--------
>  drivers/md/dm-clone-target.c        |  9 +--------
>  drivers/md/dm-io.c                  |  2 +-
>  drivers/md/dm-log-writes.c          |  3 +--
>  drivers/md/dm-raid.c                |  9 ++-------
>  drivers/md/dm-table.c               |  4 +---
>  drivers/md/dm-thin.c                |  9 +--------
>  drivers/md/dm.c                     |  2 +-
>  drivers/md/md-linear.c              |  4 ++--
>  drivers/md/raid0.c                  |  2 +-
>  drivers/md/raid1.c                  |  6 +++---
>  drivers/md/raid10.c                 |  8 ++++----
>  drivers/md/raid5-cache.c            |  2 +-
>  drivers/target/target_core_device.c |  8 +++-----
>  fs/btrfs/extent-tree.c              |  4 ++--
>  fs/btrfs/ioctl.c                    |  2 +-
>  fs/exfat/file.c                     |  2 +-
>  fs/exfat/super.c                    | 10 +++-------
>  fs/ext4/ioctl.c                     | 10 +++-------
>  fs/ext4/super.c                     | 10 +++-------
>  fs/f2fs/f2fs.h                      |  3 +--
>  fs/f2fs/segment.c                   |  6 ++----
>  fs/fat/file.c                       |  2 +-
>  fs/fat/inode.c                      | 10 +++-------
>  fs/gfs2/rgrp.c                      |  2 +-
>  fs/jbd2/journal.c                   |  7 ++-----
>  fs/jfs/ioctl.c                      |  2 +-
>  fs/jfs/super.c                      |  8 ++------
>  fs/nilfs2/ioctl.c                   |  2 +-
>  fs/ntfs3/file.c                     |  2 +-
>  fs/ntfs3/super.c                    |  2 +-
>  fs/ocfs2/ioctl.c                    |  2 +-
>  fs/xfs/xfs_discard.c                |  2 +-
>  fs/xfs/xfs_super.c                  | 12 ++++--------
>  include/linux/blkdev.h              |  5 +++++
>  mm/swapfile.c                       | 17 ++---------------
>  48 files changed, 87 insertions(+), 163 deletions(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 937bb6b863317..b5c3a8049134c 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -820,7 +820,7 @@ void submit_bio_noacct(struct bio *bio)
>
>         switch (bio_op(bio)) {
>         case REQ_OP_DISCARD:
> -               if (!blk_queue_discard(q))
> +               if (!bdev_max_discard_sectors(bdev))
>                         goto not_supported;
>                 break;
>         case REQ_OP_SECURE_ERASE:
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 2ae32a722851c..8b4b66d3a9bfc 100644
> --- a/block/blk-lib.c
> +++ b/block/blk-lib.c
> @@ -53,7 +53,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
>                         return -EOPNOTSUPP;
>                 op = REQ_OP_SECURE_ERASE;
>         } else {
> -               if (!blk_queue_discard(q))
> +               if (!bdev_max_discard_sectors(bdev))
>                         return -EOPNOTSUPP;
>                 op = REQ_OP_DISCARD;
>         }
> diff --git a/block/ioctl.c b/block/ioctl.c
> index ad3771b268b81..c2cd3ba5290ce 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -87,14 +87,13 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
>  {
>         uint64_t range[2];
>         uint64_t start, len;
> -       struct request_queue *q = bdev_get_queue(bdev);
>         struct inode *inode = bdev->bd_inode;
>         int err;
>
>         if (!(mode & FMODE_WRITE))
>                 return -EBADF;
>
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(bdev))
>                 return -EOPNOTSUPP;
>
>         if (copy_from_user(range, (void __user *)arg, sizeof(range)))
> diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
> index 9d43aadde19ad..8fd89a1b0b7b3 100644
> --- a/drivers/block/drbd/drbd_main.c
> +++ b/drivers/block/drbd/drbd_main.c
> @@ -942,7 +942,7 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
>                         cpu_to_be32(bdev_alignment_offset(bdev));
>                 p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
>                 p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
> -               p->qlim->discard_enabled = blk_queue_discard(q);
> +               p->qlim->discard_enabled = !!bdev_max_discard_sectors(bdev);
>                 p->qlim->write_same_capable = 0;
>                 put_ldev(device);
>         } else {
> diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
> index 40bb0b356a6d6..8e28e0a8e5e41 100644
> --- a/drivers/block/drbd/drbd_nl.c
> +++ b/drivers/block/drbd/drbd_nl.c
> @@ -1210,7 +1210,7 @@ static void decide_on_discard_support(struct drbd_device *device,
>                 first_peer_device(device)->connection;
>         struct request_queue *q = device->rq_queue;
>
> -       if (bdev && !blk_queue_discard(bdev->backing_bdev->bd_disk->queue))
> +       if (bdev && !bdev_max_discard_sectors(bdev->backing_bdev))
>                 goto not_supported;
>
>         if (connection->cstate >= C_CONNECTED &&
> @@ -1439,14 +1439,15 @@ static bool write_ordering_changed(struct disk_conf *a, struct disk_conf *b)
>  static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *disk_conf,
>                                struct drbd_backing_dev *nbc)
>  {
> -       struct request_queue * const q = nbc->backing_bdev->bd_disk->queue;
> +       struct block_device *bdev = nbc->backing_bdev;
> +       struct request_queue *q = bdev->bd_disk->queue;
>
>         if (disk_conf->al_extents < DRBD_AL_EXTENTS_MIN)
>                 disk_conf->al_extents = DRBD_AL_EXTENTS_MIN;
>         if (disk_conf->al_extents > drbd_al_extents_max(nbc))
>                 disk_conf->al_extents = drbd_al_extents_max(nbc);
>
> -       if (!blk_queue_discard(q)) {
> +       if (!bdev_max_discard_sectors(bdev)) {
>                 if (disk_conf->rs_discard_granularity) {
>                         disk_conf->rs_discard_granularity = 0; /* disable feature */
>                         drbd_info(device, "rs_discard_granularity feature disabled\n");
> @@ -1455,6 +1456,7 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
>
>         if (disk_conf->rs_discard_granularity) {
>                 int orig_value = disk_conf->rs_discard_granularity;
> +               sector_t discard_size = bdev_max_discard_sectors(bdev) << 9;
>                 int remainder;
>
>                 if (q->limits.discard_granularity > disk_conf->rs_discard_granularity)
> @@ -1463,8 +1465,8 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
>                 remainder = disk_conf->rs_discard_granularity % q->limits.discard_granularity;
>                 disk_conf->rs_discard_granularity += remainder;
>
> -               if (disk_conf->rs_discard_granularity > q->limits.max_discard_sectors << 9)
> -                       disk_conf->rs_discard_granularity = q->limits.max_discard_sectors << 9;
> +               if (disk_conf->rs_discard_granularity > discard_size)
> +                       disk_conf->rs_discard_granularity = discard_size;
>
>                 if (disk_conf->rs_discard_granularity != orig_value)
>                         drbd_info(device, "rs_discard_granularity changed to %d\n",
> diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
> index 08da922f81d1d..8a4a47da56fe9 100644
> --- a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -1524,7 +1524,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
>         granularity = max(q->limits.discard_granularity >> 9, 1U);
>         alignment = (bdev_discard_alignment(bdev) >> 9) % granularity;
>
> -       max_discard_sectors = min(q->limits.max_discard_sectors, (1U << 22));
> +       max_discard_sectors = min(bdev_max_discard_sectors(bdev), (1U << 22));
>         max_discard_sectors -= max_discard_sectors % granularity;
>         if (unlikely(!max_discard_sectors))
>                 goto zero_out;
> @@ -1575,11 +1575,10 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
>
>  static bool can_do_reliable_discards(struct drbd_device *device)
>  {
> -       struct request_queue *q = bdev_get_queue(device->ldev->backing_bdev);
>         struct disk_conf *dc;
>         bool can_do;
>
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(device->ldev->backing_bdev))
>                 return false;
>
>         rcu_read_lock();
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 8d800d46e4985..4b919b75205a7 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -314,15 +314,12 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
>
>         mode |= FALLOC_FL_KEEP_SIZE;
>
> -       if (!blk_queue_discard(lo->lo_queue)) {
> -               ret = -EOPNOTSUPP;
> -               goto out;
> -       }
> +       if (!bdev_max_discard_sectors(lo->lo_device))
> +               return -EOPNOTSUPP;
>
>         ret = file->f_op->fallocate(file, mode, pos, blk_rq_bytes(rq));
>         if (unlikely(ret && ret != -EINVAL && ret != -EOPNOTSUPP))
> -               ret = -EIO;
> - out:
> +               return -EIO;
>         return ret;
>  }
>
> diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
> index 2c3df02b5e8ec..1f7e1c8fd4d9b 100644
> --- a/drivers/block/rnbd/rnbd-srv-dev.h
> +++ b/drivers/block/rnbd/rnbd-srv-dev.h
> @@ -49,11 +49,7 @@ static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
>
>  static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
>  {
> -       if (!blk_queue_discard(bdev_get_queue(dev->bdev)))
> -               return 0;
> -
> -       return blk_queue_get_max_sectors(bdev_get_queue(dev->bdev),
> -                                        REQ_OP_DISCARD);
> +       return bdev_max_discard_sectors(dev->bdev);
>  }
>
>  static inline int rnbd_dev_get_discard_granularity(const struct rnbd_dev *dev)
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index 8b691fe50475f..83cd08041e6b3 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -583,7 +583,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
>         if (!xenbus_read_unsigned(dev->nodename, "discard-enable", 1))
>                 return;
>
> -       if (blk_queue_discard(q)) {
> +       if (bdev_max_discard_sectors(bdev)) {
>                 err = xenbus_printf(xbt, dev->nodename,
>                         "discard-granularity", "%u",
>                         q->limits.discard_granularity);
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index fdd0194f84dd0..e27f67f06a428 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1005,7 +1005,7 @@ static void cached_dev_write(struct cached_dev *dc, struct search *s)
>                 bio_get(s->iop.bio);
>
>                 if (bio_op(bio) == REQ_OP_DISCARD &&
> -                   !blk_queue_discard(bdev_get_queue(dc->bdev)))
> +                   !bdev_max_discard_sectors(dc->bdev))
>                         goto insert_data;
>
>                 /* I/O request sent to backing device */
> @@ -1115,7 +1115,7 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
>         bio->bi_private = ddip;
>
>         if ((bio_op(bio) == REQ_OP_DISCARD) &&
> -           !blk_queue_discard(bdev_get_queue(dc->bdev)))
> +           !bdev_max_discard_sectors(dc->bdev))
>                 bio->bi_end_io(bio);
>         else
>                 submit_bio_noacct(bio);
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index bf3de149d3c9f..296f200b2e208 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2350,7 +2350,7 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
>         ca->bdev->bd_holder = ca;
>         ca->sb_disk = sb_disk;
>
> -       if (blk_queue_discard(bdev_get_queue(bdev)))
> +       if (bdev_max_discard_sectors((bdev)))
>                 ca->discard = CACHE_DISCARD(&ca->sb);
>
>         ret = cache_alloc(ca);
> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
> index d1029d71ff3bc..c6f677059214d 100644
> --- a/drivers/md/bcache/sysfs.c
> +++ b/drivers/md/bcache/sysfs.c
> @@ -1151,7 +1151,7 @@ STORE(__bch_cache)
>         if (attr == &sysfs_discard) {
>                 bool v = strtoul_or_return(buf);
>
> -               if (blk_queue_discard(bdev_get_queue(ca->bdev)))
> +               if (bdev_max_discard_sectors(ca->bdev))
>                         ca->discard = v;
>
>                 if (v != CACHE_DISCARD(&ca->sb)) {
> diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
> index 780a61bc6cc03..28c5de8eca4a0 100644
> --- a/drivers/md/dm-cache-target.c
> +++ b/drivers/md/dm-cache-target.c
> @@ -3329,13 +3329,6 @@ static int cache_iterate_devices(struct dm_target *ti,
>         return r;
>  }
>
> -static bool origin_dev_supports_discard(struct block_device *origin_bdev)
> -{
> -       struct request_queue *q = bdev_get_queue(origin_bdev);
> -
> -       return blk_queue_discard(q);
> -}
> -
>  /*
>   * If discard_passdown was enabled verify that the origin device
>   * supports discards.  Disable discard_passdown if not.
> @@ -3349,7 +3342,7 @@ static void disable_passdown_if_not_supported(struct cache *cache)
>         if (!cache->features.discard_passdown)
>                 return;
>
> -       if (!origin_dev_supports_discard(origin_bdev))
> +       if (!bdev_max_discard_sectors(origin_bdev))
>                 reason = "discard unsupported";
>
>         else if (origin_limits->max_discard_sectors < cache->sectors_per_block)
> diff --git a/drivers/md/dm-clone-target.c b/drivers/md/dm-clone-target.c
> index 128316a73d016..811b0a5379d03 100644
> --- a/drivers/md/dm-clone-target.c
> +++ b/drivers/md/dm-clone-target.c
> @@ -2016,13 +2016,6 @@ static void clone_resume(struct dm_target *ti)
>         do_waker(&clone->waker.work);
>  }
>
> -static bool bdev_supports_discards(struct block_device *bdev)
> -{
> -       struct request_queue *q = bdev_get_queue(bdev);
> -
> -       return (q && blk_queue_discard(q));
> -}
> -
>  /*
>   * If discard_passdown was enabled verify that the destination device supports
>   * discards. Disable discard_passdown if not.
> @@ -2036,7 +2029,7 @@ static void disable_passdown_if_not_supported(struct clone *clone)
>         if (!test_bit(DM_CLONE_DISCARD_PASSDOWN, &clone->flags))
>                 return;
>
> -       if (!bdev_supports_discards(dest_dev))
> +       if (!bdev_max_discard_sectors(dest_dev))
>                 reason = "discard unsupported";
>         else if (dest_limits->max_discard_sectors < clone->region_size)
>                 reason = "max discard sectors smaller than a region";
> diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
> index 5762366333a27..e4b95eaeec8c7 100644
> --- a/drivers/md/dm-io.c
> +++ b/drivers/md/dm-io.c
> @@ -311,7 +311,7 @@ static void do_region(int op, int op_flags, unsigned region,
>          * Reject unsupported discard and write same requests.
>          */
>         if (op == REQ_OP_DISCARD)
> -               special_cmd_max_sectors = q->limits.max_discard_sectors;
> +               special_cmd_max_sectors = bdev_max_discard_sectors(where->bdev);
>         else if (op == REQ_OP_WRITE_ZEROES)
>                 special_cmd_max_sectors = q->limits.max_write_zeroes_sectors;
>         if ((op == REQ_OP_DISCARD || op == REQ_OP_WRITE_ZEROES) &&
> diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
> index c9d036d6bb2ee..e194226c89e54 100644
> --- a/drivers/md/dm-log-writes.c
> +++ b/drivers/md/dm-log-writes.c
> @@ -866,9 +866,8 @@ static int log_writes_message(struct dm_target *ti, unsigned argc, char **argv,
>  static void log_writes_io_hints(struct dm_target *ti, struct queue_limits *limits)
>  {
>         struct log_writes_c *lc = ti->private;
> -       struct request_queue *q = bdev_get_queue(lc->dev->bdev);
>
> -       if (!q || !blk_queue_discard(q)) {
> +       if (!bdev_max_discard_sectors(lc->dev->bdev)) {
>                 lc->device_supports_discard = false;
>                 limits->discard_granularity = lc->sectorsize;
>                 limits->max_discard_sectors = (UINT_MAX >> SECTOR_SHIFT);
> diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> index 2b26435a6946e..9526ccbedafba 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -2963,13 +2963,8 @@ static void configure_discard_support(struct raid_set *rs)
>         raid456 = rs_is_raid456(rs);
>
>         for (i = 0; i < rs->raid_disks; i++) {
> -               struct request_queue *q;
> -
> -               if (!rs->dev[i].rdev.bdev)
> -                       continue;
> -
> -               q = bdev_get_queue(rs->dev[i].rdev.bdev);
> -               if (!q || !blk_queue_discard(q))
> +               if (!rs->dev[i].rdev.bdev ||
> +                   !bdev_max_discard_sectors(rs->dev[i].rdev.bdev))
>                         return;
>
>                 if (raid456) {
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index d46839faa0ca5..4297c38328a9b 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -1888,9 +1888,7 @@ static bool dm_table_supports_nowait(struct dm_table *t)
>  static int device_not_discard_capable(struct dm_target *ti, struct dm_dev *dev,
>                                       sector_t start, sector_t len, void *data)
>  {
> -       struct request_queue *q = bdev_get_queue(dev->bdev);
> -
> -       return !blk_queue_discard(q);
> +       return !bdev_max_discard_sectors(dev->bdev);
>  }
>
>  static bool dm_table_supports_discards(struct dm_table *t)
> diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
> index 4d25d0e270313..cd333a3e4c33b 100644
> --- a/drivers/md/dm-thin.c
> +++ b/drivers/md/dm-thin.c
> @@ -2802,13 +2802,6 @@ static void requeue_bios(struct pool *pool)
>  /*----------------------------------------------------------------
>   * Binding of control targets to a pool object
>   *--------------------------------------------------------------*/
> -static bool data_dev_supports_discard(struct pool_c *pt)
> -{
> -       struct request_queue *q = bdev_get_queue(pt->data_dev->bdev);
> -
> -       return blk_queue_discard(q);
> -}
> -
>  static bool is_factor(sector_t block_size, uint32_t n)
>  {
>         return !sector_div(block_size, n);
> @@ -2828,7 +2821,7 @@ static void disable_passdown_if_not_supported(struct pool_c *pt)
>         if (!pt->adjusted_pf.discard_passdown)
>                 return;
>
> -       if (!data_dev_supports_discard(pt))
> +       if (!bdev_max_discard_sectors(pt->data_dev->bdev))
>                 reason = "discard unsupported";
>
>         else if (data_limits->max_discard_sectors < pool->sectors_per_block)
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 3c5fad7c4ee68..ba75933cc22ca 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -982,7 +982,7 @@ static void clone_endio(struct bio *bio)
>
>         if (unlikely(error == BLK_STS_TARGET)) {
>                 if (bio_op(bio) == REQ_OP_DISCARD &&
> -                   !q->limits.max_discard_sectors)
> +                   !bdev_max_discard_sectors(bio->bi_bdev))
>                         disable_discard(md);
>                 else if (bio_op(bio) == REQ_OP_WRITE_ZEROES &&
>                          !q->limits.max_write_zeroes_sectors)
> diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
> index 0f55b079371b1..4dd5afff72844 100644
> --- a/drivers/md/md-linear.c
> +++ b/drivers/md/md-linear.c
> @@ -97,7 +97,7 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
>                 conf->array_sectors += rdev->sectors;
>                 cnt++;
>
> -               if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
> +               if (bdev_max_discard_sectors(rdev->bdev))
>                         discard_supported = true;
>         }
>         if (cnt != raid_disks) {
> @@ -252,7 +252,7 @@ static bool linear_make_request(struct mddev *mddev, struct bio *bio)
>                 start_sector + data_offset;
>
>         if (unlikely((bio_op(bio) == REQ_OP_DISCARD) &&
> -                    !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) {
> +                    !bdev_max_discard_sectors(bio->bi_bdev))) {
>                 /* Just ignore it */
>                 bio_endio(bio);
>         } else {
> diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> index b21e101183f44..02ac3ab213c72 100644
> --- a/drivers/md/raid0.c
> +++ b/drivers/md/raid0.c
> @@ -412,7 +412,7 @@ static int raid0_run(struct mddev *mddev)
>                 rdev_for_each(rdev, mddev) {
>                         disk_stack_limits(mddev->gendisk, rdev->bdev,
>                                           rdev->data_offset << 9);
> -                       if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
> +                       if (bdev_max_discard_sectors(rdev->bdev))
>                                 discard_supported = true;
>                 }
>                 if (!discard_supported)
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index d81b896855f9f..39b9cb4d54ee0 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -802,7 +802,7 @@ static void flush_bio_list(struct r1conf *conf, struct bio *bio)
>                 if (test_bit(Faulty, &rdev->flags)) {
>                         bio_io_error(bio);
>                 } else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) &&
> -                                   !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
> +                                   !bdev_max_discard_sectors(bio->bi_bdev)))
>                         /* Just ignore it */
>                         bio_endio(bio);
>                 else
> @@ -1826,7 +1826,7 @@ static int raid1_add_disk(struct mddev *mddev, struct md_rdev *rdev)
>                         break;
>                 }
>         }
> -       if (mddev->queue && blk_queue_discard(bdev_get_queue(rdev->bdev)))
> +       if (mddev->queue && bdev_max_discard_sectors(rdev->bdev))
>                 blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
>         print_conf(conf);
>         return err;
> @@ -3141,7 +3141,7 @@ static int raid1_run(struct mddev *mddev)
>                         continue;
>                 disk_stack_limits(mddev->gendisk, rdev->bdev,
>                                   rdev->data_offset << 9);
> -               if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
> +               if (bdev_max_discard_sectors(rdev->bdev))
>                         discard_supported = true;
>         }
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 7816c8b2e8087..eaa86c6a35a55 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -888,7 +888,7 @@ static void flush_pending_writes(struct r10conf *conf)
>                         if (test_bit(Faulty, &rdev->flags)) {
>                                 bio_io_error(bio);
>                         } else if (unlikely((bio_op(bio) ==  REQ_OP_DISCARD) &&
> -                                           !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
> +                                           !bdev_max_discard_sectors(bio->bi_bdev)))
>                                 /* Just ignore it */
>                                 bio_endio(bio);
>                         else
> @@ -1083,7 +1083,7 @@ static void raid10_unplug(struct blk_plug_cb *cb, bool from_schedule)
>                 if (test_bit(Faulty, &rdev->flags)) {
>                         bio_io_error(bio);
>                 } else if (unlikely((bio_op(bio) ==  REQ_OP_DISCARD) &&
> -                                   !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
> +                                   !bdev_max_discard_sectors(bio->bi_bdev)))
>                         /* Just ignore it */
>                         bio_endio(bio);
>                 else
> @@ -2144,7 +2144,7 @@ static int raid10_add_disk(struct mddev *mddev, struct md_rdev *rdev)
>                 rcu_assign_pointer(p->rdev, rdev);
>                 break;
>         }
> -       if (mddev->queue && blk_queue_discard(bdev_get_queue(rdev->bdev)))
> +       if (mddev->queue && bdev_max_discard_sectors(rdev->bdev))
>                 blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
>
>         print_conf(conf);
> @@ -4141,7 +4141,7 @@ static int raid10_run(struct mddev *mddev)
>
>                 disk->head_position = 0;
>
> -               if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
> +               if (bdev_max_discard_sectors(rdev->bdev))
>                         discard_supported = true;
>                 first = 0;
>         }
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index a7d50ff9020a8..c3cbf9a574a39 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1318,7 +1318,7 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
>
>         r5l_write_super(log, end);
>
> -       if (!blk_queue_discard(bdev_get_queue(bdev)))
> +       if (!bdev_max_discard_sectors(bdev))
>                 return;
>
>         mddev = log->rdev->mddev;
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 16e775bcf4a7c..7d510e4231713 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -829,9 +829,7 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
>  }
>
>  /*
> - * Check if the underlying struct block_device request_queue supports
> - * the QUEUE_FLAG_DISCARD bit for UNMAP/WRITE_SAME in SCSI + TRIM
> - * in ATA and we need to set TPE=1
> + * Check if the underlying struct block_device request_queue supports disard.
>   */
>  bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
>                                        struct block_device *bdev)
> @@ -839,11 +837,11 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
>         struct request_queue *q = bdev_get_queue(bdev);
>         int block_size = bdev_logical_block_size(bdev);
>
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(bdev))
>                 return false;
>
>         attrib->max_unmap_lba_count =
> -               q->limits.max_discard_sectors >> (ilog2(block_size) - 9);
> +               bdev_max_discard_sectors(bdev) >> (ilog2(block_size) - 9);
>         /*
>          * Currently hardcoded to 1 in Linux/SCSI code..
>          */
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index f477035a2ac23..efd8deb3ab7e8 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -1291,7 +1291,7 @@ static int do_discard_extent(struct btrfs_io_stripe *stripe, u64 *bytes)
>                 ret = btrfs_reset_device_zone(dev_replace->tgtdev, phys, len,
>                                               &discarded);
>                 discarded += src_disc;
> -       } else if (blk_queue_discard(bdev_get_queue(stripe->dev->bdev))) {
> +       } else if (bdev_max_discard_sectors(stripe->dev->bdev)) {
>                 ret = btrfs_issue_discard(dev->bdev, phys, len, &discarded);
>         } else {
>                 ret = 0;
> @@ -5987,7 +5987,7 @@ static int btrfs_trim_free_extents(struct btrfs_device *device, u64 *trimmed)
>         *trimmed = 0;
>
>         /* Discard not supported = nothing to do. */
> -       if (!blk_queue_discard(bdev_get_queue(device->bdev)))
> +       if (!bdev_max_discard_sectors(device->bdev))
>                 return 0;
>
>         /* Not writable = nothing to do. */
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 238cee5b5254d..fc7953755fd8b 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -501,7 +501,7 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
>                 if (!device->bdev)
>                         continue;
>                 q = bdev_get_queue(device->bdev);
> -               if (blk_queue_discard(q)) {
> +               if (bdev_max_discard_sectors(device->bdev)) {
>                         num_devices++;
>                         minlen = min_t(u64, q->limits.discard_granularity,
>                                      minlen);
> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
> index 2f51300592366..765e4f63dd18d 100644
> --- a/fs/exfat/file.c
> +++ b/fs/exfat/file.c
> @@ -358,7 +358,7 @@ static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
>         if (!capable(CAP_SYS_ADMIN))
>                 return -EPERM;
>
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(inode->i_sb->s_bdev))
>                 return -EOPNOTSUPP;
>
>         if (copy_from_user(&range, (struct fstrim_range __user *)arg, sizeof(range)))
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c
> index 8ca21e7917d16..be0788ecaf20e 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -627,13 +627,9 @@ static int exfat_fill_super(struct super_block *sb, struct fs_context *fc)
>         if (opts->allow_utime == (unsigned short)-1)
>                 opts->allow_utime = ~opts->fs_dmask & 0022;
>
> -       if (opts->discard) {
> -               struct request_queue *q = bdev_get_queue(sb->s_bdev);
> -
> -               if (!blk_queue_discard(q)) {
> -                       exfat_warn(sb, "mounting with \"discard\" option, but the device does not support discard");
> -                       opts->discard = 0;
> -               }
> +       if (opts->discard && !bdev_max_discard_sectors(sb->s_bdev)) {
> +               exfat_warn(sb, "mounting with \"discard\" option, but the device does not support discard");
> +               opts->discard = 0;
>         }
>
>         sb->s_flags |= SB_NODIRATIME;
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 992229ca2d830..6e3b9eea126f4 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -1044,7 +1044,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
>         __u32 flags = 0;
>         unsigned int flush_flags = 0;
>         struct super_block *sb = file_inode(filp)->i_sb;
> -       struct request_queue *q;
>
>         if (copy_from_user(&flags, (__u32 __user *)arg,
>                                 sizeof(__u32)))
> @@ -1065,10 +1064,8 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
>         if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
>                 return -EINVAL;
>
> -       q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);
> -       if (!q)
> -               return -ENXIO;
> -       if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !blk_queue_discard(q))
> +       if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
> +           !bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev))
>                 return -EOPNOTSUPP;
>
>         if (flags & EXT4_IOC_CHECKPOINT_FLAG_DRY_RUN)
> @@ -1393,14 +1390,13 @@ static long __ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>
>         case FITRIM:
>         {
> -               struct request_queue *q = bdev_get_queue(sb->s_bdev);
>                 struct fstrim_range range;
>                 int ret = 0;
>
>                 if (!capable(CAP_SYS_ADMIN))
>                         return -EPERM;
>
> -               if (!blk_queue_discard(q))
> +               if (!bdev_max_discard_sectors(sb->s_bdev))
>                         return -EOPNOTSUPP;
>
>                 /*
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 81749eaddf4c1..93f4e4e9e2631 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5458,13 +5458,9 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
>                         goto failed_mount9;
>         }
>
> -       if (test_opt(sb, DISCARD)) {
> -               struct request_queue *q = bdev_get_queue(sb->s_bdev);
> -               if (!blk_queue_discard(q))
> -                       ext4_msg(sb, KERN_WARNING,
> -                                "mounting with \"discard\" option, but "
> -                                "the device does not support discard");
> -       }
> +       if (test_opt(sb, DISCARD) && !bdev_max_discard_sectors(sb->s_bdev))
> +               ext4_msg(sb, KERN_WARNING,
> +                        "mounting with \"discard\" option, but the device does not support discard");
>
>         if (es->s_error_count)
>                 mod_timer(&sbi->s_err_report, jiffies + 300*HZ); /* 5 minutes */
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index cd1e65bcf0b04..0ea9a5fa7c1dd 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -4381,8 +4381,7 @@ static inline bool f2fs_hw_should_discard(struct f2fs_sb_info *sbi)
>
>  static inline bool f2fs_bdev_support_discard(struct block_device *bdev)
>  {
> -       return blk_queue_discard(bdev_get_queue(bdev)) ||
> -              bdev_is_zoned(bdev);
> +       return bdev_max_discard_sectors(bdev) || bdev_is_zoned(bdev);
>  }
>
>  static inline bool f2fs_hw_support_discard(struct f2fs_sb_info *sbi)
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 22dfeb9915290..71f09adbcba86 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1196,9 +1196,8 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
>                                                 unsigned int *issued)
>  {
>         struct block_device *bdev = dc->bdev;
> -       struct request_queue *q = bdev_get_queue(bdev);
>         unsigned int max_discard_blocks =
> -                       SECTOR_TO_BLOCK(q->limits.max_discard_sectors);
> +                       SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
>         struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
>         struct list_head *wait_list = (dpolicy->type == DPOLICY_FSTRIM) ?
>                                         &(dcc->fstrim_list) : &(dcc->wait_list);
> @@ -1375,9 +1374,8 @@ static void __update_discard_tree_range(struct f2fs_sb_info *sbi,
>         struct discard_cmd *dc;
>         struct discard_info di = {0};
>         struct rb_node **insert_p = NULL, *insert_parent = NULL;
> -       struct request_queue *q = bdev_get_queue(bdev);
>         unsigned int max_discard_blocks =
> -                       SECTOR_TO_BLOCK(q->limits.max_discard_sectors);
> +                       SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
>         block_t end = lstart + len;
>
>         dc = (struct discard_cmd *)f2fs_lookup_rb_tree_ret(&dcc->root,
> diff --git a/fs/fat/file.c b/fs/fat/file.c
> index a5a309fcc7faf..e4c7d10e80129 100644
> --- a/fs/fat/file.c
> +++ b/fs/fat/file.c
> @@ -133,7 +133,7 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
>         if (!capable(CAP_SYS_ADMIN))
>                 return -EPERM;
>
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(sb->s_bdev))
>                 return -EOPNOTSUPP;
>
>         user_range = (struct fstrim_range __user *)arg;
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index bf6051bdf1d1d..3d1afb95a925a 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1872,13 +1872,9 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
>                 goto out_fail;
>         }
>
> -       if (sbi->options.discard) {
> -               struct request_queue *q = bdev_get_queue(sb->s_bdev);
> -               if (!blk_queue_discard(q))
> -                       fat_msg(sb, KERN_WARNING,
> -                                       "mounting with \"discard\" option, but "
> -                                       "the device does not support discard");
> -       }
> +       if (sbi->options.discard && !bdev_max_discard_sectors(sb->s_bdev))
> +               fat_msg(sb, KERN_WARNING,
> +                       "mounting with \"discard\" option, but the device does not support discard");
>
>         fat_set_state(sb, 1, 0);
>         return 0;
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index 801ad9f4f2bef..7f20ac9133bc6 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -1405,7 +1405,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
>         if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
>                 return -EROFS;
>
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(sdp->sd_vfs->s_bdev))
>                 return -EOPNOTSUPP;
>
>         if (copy_from_user(&r, argp, sizeof(r)))
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index fcacafa4510d1..19d226cd4ff4d 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1762,7 +1762,6 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
>         unsigned long block, log_offset; /* logical */
>         unsigned long long phys_block, block_start, block_stop; /* physical */
>         loff_t byte_start, byte_stop, byte_count;
> -       struct request_queue *q = bdev_get_queue(journal->j_dev);
>
>         /* flags must be set to either discard or zeroout */
>         if ((flags & ~JBD2_JOURNAL_FLUSH_VALID) || !flags ||
> @@ -1770,10 +1769,8 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
>                         (flags & JBD2_JOURNAL_FLUSH_ZEROOUT)))
>                 return -EINVAL;
>
> -       if (!q)
> -               return -ENXIO;
> -
> -       if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !blk_queue_discard(q))
> +       if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
> +           !bdev_max_discard_sectors(journal->j_dev))
>                 return -EOPNOTSUPP;
>
>         /*
> diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> index 03a845ab4f009..357ae6e5c36ec 100644
> --- a/fs/jfs/ioctl.c
> +++ b/fs/jfs/ioctl.c
> @@ -117,7 +117,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>                 if (!capable(CAP_SYS_ADMIN))
>                         return -EPERM;
>
> -               if (!blk_queue_discard(q)) {
> +               if (!bdev_max_discard_sectors(sb->s_bdev)) {
>                         jfs_warn("FITRIM not supported on device");
>                         return -EOPNOTSUPP;
>                 }
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index f1a13a74cddf3..85d4f44f2ac4d 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -372,19 +372,16 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
>                 }
>
>                 case Opt_discard:
> -               {
> -                       struct request_queue *q = bdev_get_queue(sb->s_bdev);
>                         /* if set to 1, even copying files will cause
>                          * trimming :O
>                          * -> user has more control over the online trimming
>                          */
>                         sbi->minblks_trim = 64;
> -                       if (blk_queue_discard(q))
> +                       if (bdev_max_discard_sectors(sb->s_bdev))
>                                 *flag |= JFS_DISCARD;
>                         else
>                                 pr_err("JFS: discard option not supported on device\n");
>                         break;
> -               }
>
>                 case Opt_nodiscard:
>                         *flag &= ~JFS_DISCARD;
> @@ -392,10 +389,9 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
>
>                 case Opt_discard_minblk:
>                 {
> -                       struct request_queue *q = bdev_get_queue(sb->s_bdev);
>                         char *minblks_trim = args[0].from;
>                         int rc;
> -                       if (blk_queue_discard(q)) {
> +                       if (bdev_max_discard_sectors(sb->s_bdev)) {
>                                 *flag |= JFS_DISCARD;
>                                 rc = kstrtouint(minblks_trim, 0,
>                                                 &sbi->minblks_trim);
> diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
> index fec194a666f4b..52b73f558fcb1 100644
> --- a/fs/nilfs2/ioctl.c
> +++ b/fs/nilfs2/ioctl.c
> @@ -1059,7 +1059,7 @@ static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
>         if (!capable(CAP_SYS_ADMIN))
>                 return -EPERM;
>
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(nilfs->ns_bdev))
>                 return -EOPNOTSUPP;
>
>         if (copy_from_user(&range, argp, sizeof(range)))
> diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
> index 787b53b984ee1..e763236169331 100644
> --- a/fs/ntfs3/file.c
> +++ b/fs/ntfs3/file.c
> @@ -28,7 +28,7 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
>         if (!capable(CAP_SYS_ADMIN))
>                 return -EPERM;
>
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(sbi->sb->s_bdev))
>                 return -EOPNOTSUPP;
>
>         user_range = (struct fstrim_range __user *)arg;
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index cd30e81abbce0..c734085bcce4a 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -913,7 +913,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
>         }
>
>         rq = bdev_get_queue(bdev);
> -       if (blk_queue_discard(rq) && rq->limits.discard_granularity) {
> +       if (bdev_max_discard_sectors(bdev) && rq->limits.discard_granularity) {
>                 sbi->discard_granularity = rq->limits.discard_granularity;
>                 sbi->discard_granularity_mask_inv =
>                         ~(u64)(sbi->discard_granularity - 1);
> diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
> index f59461d85da45..9b78ef103ada6 100644
> --- a/fs/ocfs2/ioctl.c
> +++ b/fs/ocfs2/ioctl.c
> @@ -910,7 +910,7 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>                 if (!capable(CAP_SYS_ADMIN))
>                         return -EPERM;
>
> -               if (!blk_queue_discard(q))
> +               if (!bdev_max_discard_sectors(sb->s_bdev))
>                         return -EOPNOTSUPP;
>
>                 if (copy_from_user(&range, argp, sizeof(range)))
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index 0191de8ce9ced..a4e6609d616b7 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -162,7 +162,7 @@ xfs_ioc_trim(
>
>         if (!capable(CAP_SYS_ADMIN))
>                 return -EPERM;
> -       if (!blk_queue_discard(q))
> +       if (!bdev_max_discard_sectors(mp->m_ddev_targp->bt_bdev))
>                 return -EOPNOTSUPP;
>
>         /*
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 54be9d64093ed..a276b8111f636 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1608,14 +1608,10 @@ xfs_fs_fill_super(.
>                         goto out_filestream_unmount;
>         }>

> -       if (xfs_has_discard(mp)) {
> -               struct request_queue *q = bdev_get_queue(sb->s_bdev);
> -
> -               if (!blk_queue_discard(q)) {
> -                       xfs_warn(mp, "mounting with \"discard\" option, but "
> -                                       "the device does not support discard");
> -                       mp->m_features &= ~XFS_FEAT_DISCARD;
> -               }
> +       if (xfs_has_discard(mp) && !bdev_max_discard_sectors(sb->s_bdev)) {
> +               xfs_warn(mp,
> +       "mounting with \"discard\" option, but the device does not support discard");
> +               mp->m_features &= ~XFS_FEAT_DISCARD;
>         }
>
>         if (xfs_has_reflink(mp)) {
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 34b1cfd067421..ce16247d3afab 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1254,6 +1254,11 @@ bdev_zone_write_granularity(struct block_device *bdev)
>  int bdev_alignment_offset(struct block_device *bdev);
>  unsigned int bdev_discard_alignment(struct block_device *bdev);
>
> +static inline unsigned int bdev_max_discard_sectors(struct block_device *bdev)
> +{
> +       return bdev_get_queue(bdev)->limits.max_discard_sectors;
> +}
> +

So this patch replaces checking for blk_queue_discard(q) with checking
whether bdev_max_discard_sectors() is nonzero. That doesn't seem to be
equivalent for callers like drivers/md/raid0.c:raid0_run() which clear
the QUEUE_FLAG_DISCARD flag without zeroing out max_discard_sectors,
for example. Should a test for the QUEUE_FLAG_DISCARD flag be added
here?

If I'm misreading things, could you please document that
bdev_max_discard_sectors() != 0 implies that discard is supported?

Thanks,
Andreas

>  static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
>  {
>         struct request_queue *q = bdev_get_queue(bdev);
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 4069f17a82c8e..5d9cedf9e7b84 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -2957,20 +2957,6 @@ static int setup_swap_map_and_extents(struct swap_info_struct *p,
>         return nr_extents;
>  }
>
> -/*
> - * Helper to sys_swapon determining if a given swap
> - * backing device queue supports DISCARD operations.
> - */
> -static bool swap_discardable(struct swap_info_struct *si)
> -{
> -       struct request_queue *q = bdev_get_queue(si->bdev);
> -
> -       if (!blk_queue_discard(q))
> -               return false;
> -
> -       return true;
> -}
> -
>  SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
>  {
>         struct swap_info_struct *p;
> @@ -3132,7 +3118,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
>                                          sizeof(long),
>                                          GFP_KERNEL);
>
> -       if (p->bdev && (swap_flags & SWAP_FLAG_DISCARD) && swap_discardable(p)) {
> +       if ((swap_flags & SWAP_FLAG_DISCARD) &&
> +           p->bdev && bdev_max_discard_sectors(p->bdev)) {
>                 /*
>                  * When discard is enabled for swap with no particular
>                  * policy flagged, we set all swap discard flags here in
> --
> 2.30.2
>



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 10:10:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 10:10:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299808.511017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2cM-0000Fg-FM; Wed, 06 Apr 2022 10:10:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299808.511017; Wed, 06 Apr 2022 10:10:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc2cM-0000FZ-C5; Wed, 06 Apr 2022 10:10:26 +0000
Received: by outflank-mailman (input) for mailman id 299808;
 Wed, 06 Apr 2022 10:10:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc2cK-0000FT-Jv
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 10:10:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c52f0e07-b591-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 12:10:22 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-mn5iOfhnP5GK3O57yKIPnQ-1; Wed, 06 Apr 2022 12:10:21 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB5683.eurprd04.prod.outlook.com (2603:10a6:208:12b::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 10:10:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 10:10:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c52f0e07-b591-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649239822;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2hG+rmv5Lh2TvFpSkOTjwuyENnTLiNL7BXoYJBj+oMs=;
	b=GZR9V6gqiw1vVXBEfYAm10siXXJqE014tnadn4lXTNKSUnAi04jxbh0VV405jIMROoyTuJ
	eJ5ZFC9zvfaHAxp0P449vbq2O0YkhwQ+mmW85mU2583UdJoJ43nVMuax5Mk9LDPATIGyNy
	KlKdOdUTo5zM8QafaCc2OJwygoA2bDw=
X-MC-Unique: mn5iOfhnP5GK3O57yKIPnQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gNhQsBFFBu9V84bZiEiw4UMh+pcvphD2lWDQcbYaHNGgXtM0Abh+yPHZx92V/uFmxR/V0Tpfoyz7DKp6578myPED0aLLeylfWYdqP8elgwZ1iOJm2mrirJJ/CrzUWd3/+xgNEAfs4uj7y5u5HIgOKWkYq4lHz9gyUjUw5HvgutT57zNwJXc2PyYF+KdsSkQyEgB2PNyNLzziVdTKcRHI0WhfYuj+Cvf4fBzxtZp2j8PIugtINBhoj0NXC22bxlnSms2roCwmi1r6F+hPInnW042VB1YvYRNsBBqI7Bqfhr6dUt38ZZA3cOvN7+n/Mgboc2WdKzIfbX59eOQkoEXlDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8oJDKutwYXkEg3HQXrS9wP3QPbnRLnpvikP8gGPI3Ck=;
 b=S+nieOYTZ6ic4BceWmtM6bsfXm2ZNEJSFsxGWczL3BwDLu/zP//SAD4CUJ63L1W+iyGab90W3+avsI3CuCgPQqgYRd2pQTWus5rUXzaJSwSYIQAuVSzoRZSIesm6j9TmI8NK6s3voQXY/6mL78eTVXw02feL/QtPCoWcs2XJHB2lYtWlPEP23GmPuC9pzlECt/gwOO5gwDGxrwJnzCHyhhT/pj7x9WQDHhI6wOLQ0TmISMelhDMFfX+t2ktgI5Jplw0zSmKPi+8qOWw1/SacMBhr3XzNXkYMrD2uPuRuTM64ryfsYTfwRhdC5hPB0uWJdWU39eWBClbEXNQFDnKcLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <72ed7420-5f01-6cf4-b1fd-dd2186162a20@suse.com>
Date: Wed, 6 Apr 2022 12:10:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] Grab the EFI System Resource Table and check it
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
CC: xen-devel@lists.xenproject.org,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <YkeHXFvgB3MwXnuR@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YkeHXFvgB3MwXnuR@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0196.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b6d3c27b-2734-4b08-edd5-08da17b5a75d
X-MS-TrafficTypeDiagnostic: AM0PR04MB5683:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB56834A15CDFFA82FDCF86FD6B3E79@AM0PR04MB5683.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	084o+sbbFtx8vhTTXRq0k8Imz8gqfwSdCMW/FqXkhF3KE2/9a8/xqXxNaV5gn0sMZEqqo24pYC1HeZtNUG/+vJpzHkWn5F3SNPqIdblFAYsHKAFU1VckxmM2JrnyLCusUDscWyT0wsAL9bGORuWIvgwjojWhYntSrARfRVBd3j8uVM/uJgBeVfapM5vr9Jk9q4m8HH718VYLbb8UkvkrfzFXzbvTmILPf9DJzLkVqOEluzfclpSToUhM/PfslbXoc4JyXQ7+/UZ8iri0sC0RnRFTuo35pamjtMBddpnwgFiIXGr3VL8HRBb0y/FP+/A8NZuBdKB/8+OSeii7lKN9OMRLwUFDQsUSPiYasGtM6b1Y3Xk9Ddf7JfjzY8JehS+Kd773Nad207zMoti/m5cHDVC02T95770kjE6vWhxUVF/dcnadNXTHHe/GHrEDA0OUZpkEWoTmlVG1KKlNP4mBuQ4JitdPIUJZY4iGGtoJ3GpeqbDX27/aIFAPNU55Hwd3Wex8FqvHXyZCRNrM6bCD96eu+g7gl5mQ1Ki/+PYqEqxoDLtsItdBIe9cnzUt9q5TLw/CxSPsHcjL0mErJA534PiEFrkCH1gf1jWEyDpAJkpW8zHtRLeg4J/vi92lmY1z06JOrm1Y8umW51idOXh5C/ZD4bnnXp3i/PN+L5BNRkoFJ34L1Q89aPHCWCOgtvu/tRejsLbPllyMoTdRBRCGG2yM1c1I5ySipa8V44z4bAfE1vHP7vGrXbQd3Rkqtln+OTznH+A0yysIWQupJQX4IInGTQQo8zcdjRVQrSt34SkklDBgGAjr11HDTw74b6cM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(38100700002)(86362001)(8936002)(26005)(5660300002)(2906002)(186003)(31696002)(966005)(6486002)(508600001)(4326008)(6506007)(66946007)(66556008)(66476007)(8676002)(6916009)(316002)(31686004)(36756003)(54906003)(6512007)(53546011)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Jx2jNHIJZf2GhUCC+2glDUekqc+z6Mvlwn2GlMWljA2ocfe7HXtC43Mv7Sxs?=
 =?us-ascii?Q?dnbgYC9poU0hhFuhL5TO0jjbwZIt1uZea9WBR3KENSjqp4axqT3ocZeXlrwg?=
 =?us-ascii?Q?poQ+bp5F8hH6kT+LBjJ+HW7L28fLYSwrnWjWYE3IS4WpPj6G1PI8/psFENI1?=
 =?us-ascii?Q?kiYcnVn8bUqsUHmZjhN6rAkjkmSj/aEk4VMUIKEDF94Gtqq7/byBVhRgDm9h?=
 =?us-ascii?Q?yNsEVWV6IyCWd9RD5ZoV4T3Id/nXnsoFrlXg/czDE+cjySp7i4U+0u8u2lGQ?=
 =?us-ascii?Q?ApeVc4P64hDAtYxsTwHCh1rOVZ7oBBAqwg1QyrkjYchsukJhas0C/CS8Rmnl?=
 =?us-ascii?Q?9giP2putQ+xPz7s6cA69zxiNcBmupDZi3nLlCbADraGRowAhT0AspLhaA2uW?=
 =?us-ascii?Q?bH6ei0HyWkbeRtX5iCNHVw9QDPCavHmwk/6j1TEIYpjbTFOBnnbQJ+aepIUx?=
 =?us-ascii?Q?H/lR5dO4uFHQd+UO2uaOOL7vK7vxKMkYJw9Soq2BKTuADffdPUhtIflPw6Xm?=
 =?us-ascii?Q?tNZeltEbk+a//v2ebbXI2ALAtmcpb14qS/SwiWEgh9pAymP4DLWANI4Rktyk?=
 =?us-ascii?Q?4JqUB4Js9ijNT7VXQE0Z+SK8Ht91r7m2KlBvSaqjZ0h819ENzK8607Ee9z1p?=
 =?us-ascii?Q?7OvqZGZ2jE2tuvQt33W2JWW5QxxEHt82UozxddTd/iKFNYD82u3qGErE0XTO?=
 =?us-ascii?Q?oF5p+Lv7r6ms3UaY5fCDEVbtQA/yK9Id3Tex3FsllUNKngUpDFP/EfrlpZnl?=
 =?us-ascii?Q?OjuWgLeiyUjcDQJFihEtB5zy92oBxSHkfMZotHHZ7yfLstSNjbvNjsxQrUjr?=
 =?us-ascii?Q?AqvWXIsaqwgyjZTrPWdCO/dwSinkyPHlK6H/LgBOEBqtUvOiBAYBDSD5ft+D?=
 =?us-ascii?Q?kOJIPvaaXlSOvd88z8CzBPIr+ul1ydol7GOtJkz3lUGe1iZ7nuKLyxNDT9/O?=
 =?us-ascii?Q?1S/5u2GPq9SvuR+7Ycw8I86AdW0k9u+sZzTG69+IQgM2CBWnAXy07jbkHMUs?=
 =?us-ascii?Q?N2M3odMcCBsNRdTluLpLrIi1PVZ53f9J6LgjyPi1LyJXqPHmM12tntQWEcP/?=
 =?us-ascii?Q?0Ch7JCSqE/XtpZHLbOpwnFtWQRj6QMrFC4EOIznFwRjmxGfCwlnDkhffEHoB?=
 =?us-ascii?Q?R/aNSh81hVutdr1lUHzFuyLPhWI3XvscqqU1QEiLza5k5g3uql3JPnhnXePS?=
 =?us-ascii?Q?67HFjON3RDxOHny3V62Lz0QGsKbkZhhxCVMm7TK2Q8S8oAOw8Wm71lzp07ms?=
 =?us-ascii?Q?97nL2IIHCnG+7h7GE18vs50YWCI1H8Bv2FIrPIx1MNIQWDJSyqttkBMncgrG?=
 =?us-ascii?Q?kWH5Qy3MylcFQ3TrG6jcojk8x8UICNYu9pAvh92C1BSEUrtq+hvFWnqpjbDc?=
 =?us-ascii?Q?WfJ7JYb9s4NKZE6monis51/ALKgfISFnoDjAxN9fWRgj8AMWuVDQpb8GzbJu?=
 =?us-ascii?Q?TJFbZExJvOCH7/QudKR8TnFjYn943DYFtpVhRxiX4hCf0KUMzYnybq5TPLJ0?=
 =?us-ascii?Q?Df1AztKy9IxLM1UBlXxMASouMao4EI4XeMCeC52fMjaz6hhF45CXWUEuzUod?=
 =?us-ascii?Q?vq/gn9tAh4JuNS8my2Q0wNiepWKlwddZFERUGxsUhteQFgs0fpvH4H1L2d0K?=
 =?us-ascii?Q?zxORJ9KWUeJgUWuTUhjQqV2Gaoo6ercl9bRLG38MZb1lUbhYc7pfyEUbnIYP?=
 =?us-ascii?Q?YlymOpPlQPU19jnkqBVBszfdd9C8Pb1wAkko7p9XhluWmreg4luqGXAVAoE1?=
 =?us-ascii?Q?xvYMAlnMcA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6d3c27b-2734-4b08-edd5-08da17b5a75d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 10:10:19.2378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +vUv5BBnUy+Ua0noTpB+7r9yYPvei0NRMpguNALvwOH9u4ibSSWXK9P/OL3aYk7NOzGCddfJPAzj6XyKGLWqJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5683

On 02.04.2022 01:14, Demi Marie Obenour wrote:
> The EFI System Resource Table (ESRT) is necessary for fwupd to identify
> firmware updates to install.  According to the UEFI specification =C2=A72=
3.4,
> the table shall be stored in memory of type EfiBootServicesData.
> Therefore, Xen must avoid reusing that memory for other purposes, so
> that Linux can access the ESRT.  Additionally, Xen must mark the memory
> as reserved, so that Linux knows accessing it is safe.
>=20
> See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/
> for details.
>=20
> Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>

First a note on patch submission: Patches are sent To: the list, with
Cc: to involved maintainers (and perhaps other interested parties).

> ---
>  xen/arch/arm/efi/efi-boot.h |  9 +++--
>  xen/arch/x86/efi/efi-boot.h |  5 ++-
>  xen/common/efi/boot.c       | 77 +++++++++++++++++++++++++++++++++++--
>  xen/common/efi/efi.h        |  2 +-
>  xen/common/efi/runtime.c    |  5 ++-
>  xen/include/efi/efiapi.h    |  3 ++
>  6 files changed, 89 insertions(+), 12 deletions(-)

This being v2 (oddly enough with another v2 sent on Mar 30), you will
want to add a brief revision log clarifying to reviewers what has
changed. Together with the duplicate v2 it's not really clear whether
this was a plain resend, or whether anything actually changed (it
looks like you did address the Arm build issue).

> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -176,7 +176,8 @@ static bool __init meminfo_add_bank(struct meminfo *m=
em,
> =20
>  static EFI_STATUS __init efi_process_memory_map_bootinfo(EFI_MEMORY_DESC=
RIPTOR *map,
>                                                  UINTN mmap_size,
> -                                                UINTN desc_size)
> +                                                UINTN desc_size,
> +                                                const EFI_MEMORY_DESCRIP=
TOR *const esrt_desc)

Please omit the 2nd const (here and elsewhere) - no other parameters are
modified like this.

> --- a/xen/arch/x86/efi/efi-boot.h
> +++ b/xen/arch/x86/efi/efi-boot.h
> @@ -154,7 +154,8 @@ static void __init efi_arch_process_memory_map(EFI_SY=
STEM_TABLE *SystemTable,
>                                                 void *map,
>                                                 UINTN map_size,
>                                                 UINTN desc_size,
> -                                               UINT32 desc_ver)
> +                                               UINT32 desc_ver,
> +                                               const EFI_MEMORY_DESCRIPT=
OR *const esrt_desc)
>  {
>      struct e820entry *e;
>      unsigned int i;
> @@ -171,7 +172,7 @@ static void __init efi_arch_process_memory_map(EFI_SY=
STEM_TABLE *SystemTable,
>          {
>          case EfiBootServicesCode:
>          case EfiBootServicesData:
> -            if ( map_bs )
> +            if ( map_bs || desc =3D=3D esrt_desc )
>              {
>          default:
>                  type =3D E820_RESERVED;

How certain is it that this descriptor doesn't cover (much) more than
just ESRT? This could be quite wasteful in terms of memory which
wouldn't be reclaimed just because of the (perhaps small) ESRT.

> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -93,6 +93,23 @@ typedef struct _EFI_LOAD_OPTION {
>      CHAR16 Description[];
>  } EFI_LOAD_OPTION;
> =20
> +struct esrt_entry {
> +    EFI_GUID fw_class;
> +    UINT32 fw_type;
> +    UINT32 fw_version;
> +    UINT32 fw_lowest_supported_version;
> +    UINT32 fw_capsule_flags;
> +    UINT32 fw_last_attempt_version;
> +    UINT32 fw_last_attempt_status;
> +};
> +
> +struct esrt {
> +    UINT32 esrt_count;
> +    UINT32 esrt_max;
> +    UINT64 esrt_version;
> +    struct esrt_entry esrt_entries[];
> +};

Please follow the naming and naming convention used by immediately
preceding structure definitions as well as the specification: All
names matching the spec and using typedef. That's how such structures
would eventually be added to the EFI headers we're inheriting from
the gnu-efi package. At such a point we would want to be able to
delete the declarations here without needing to touch any other code.

> #define LOAD_OPTION_ACTIVE              0x00000001

Also please don't insert in the middle of two related definitions.

> @@ -567,6 +584,38 @@ static int __init efi_check_dt_boot(const EFI_LOADED=
_IMAGE *loaded_image)
>  }
>  #endif
> =20
> +static UINTN __initdata esrt;

Don't you need to initialize this to EFI_INVALID_TABLE_ADDR in order
for ...

> +static bool __init is_esrt_valid(
> +    const EFI_MEMORY_DESCRIPTOR *const desc)
> +{
> +    size_t available_len, esrt_len, len;
> +    const UINTN physical_start =3D desc->PhysicalStart;
> +    const struct esrt *esrt_ptr;
> +
> +    len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
> +    if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR )
> +        return false;

... this check to actually be useful?

> +    if ( physical_start > esrt || esrt - physical_start >=3D len )
> +        return false;
> +    /*
> +     * The specification requires EfiBootServicesData, but accept
> +     * EfiRuntimeServicesData for compatibility
> +     */
> +    if ( (desc->Type !=3D EfiRuntimeServicesData) &&
> +         (desc->Type !=3D EfiBootServicesData) )
> +        return false;
> +    available_len =3D len - (esrt - physical_start);
> +    if ( available_len < sizeof(*esrt_ptr) )
> +        return false;
> +    esrt_ptr =3D (const struct esrt *)esrt;
> +    if ( esrt_ptr->esrt_version !=3D 1 || esrt_ptr->esrt_count <=3D 0 )

Nit: I think unsigned values would better not be compared for "<=3D 0";
this wants to be "=3D=3D 0" (or simply use the ! operator as we tend to
do elsewhere).

> +        return false;
> +    esrt_len =3D esrt_ptr->esrt_count * sizeof(esrt_ptr->esrt_entries[0]=
);

While presently we support EFI only for 64-bit architectures, this
can overflow for 32-bit ones. Better to guard against this right
away. This could be achieved implicitly by ...

> +    return esrt_len > available_len - sizeof(*esrt_ptr);

    return esrt_ptr->esrt_count <=3D
           (available_len - sizeof(*esrt_ptr)) /
           sizeof(esrt_ptr->esrt_entries[0]);

(also correcting > to <=3D at the same time).

> @@ -846,6 +895,10 @@ static void __init efi_tables(void)
>  {
>      unsigned int i;
> =20
> +    BUILD_BUG_ON(sizeof(struct esrt_entry) !=3D 40);
> +    BUILD_BUG_ON(__alignof(struct esrt_entry) !=3D 4);
> +    BUILD_BUG_ON(sizeof(struct esrt) !=3D 16);

What are these about? I don't think we have similar checks for
other interface definitions, and I don't see why we would need
such.

> @@ -854,6 +907,7 @@ static void __init efi_tables(void)
>          static EFI_GUID __initdata mps_guid =3D MPS_TABLE_GUID;
>          static EFI_GUID __initdata smbios_guid =3D SMBIOS_TABLE_GUID;
>          static EFI_GUID __initdata smbios3_guid =3D SMBIOS3_TABLE_GUID;
> +        static EFI_GUID __initdata esrt_guid =3D ESRT_GUID;
> =20
>          if ( match_guid(&acpi2_guid, &efi_ct[i].VendorGuid) )
>  	       efi.acpi20 =3D (long)efi_ct[i].VendorTable;
> @@ -865,6 +919,8 @@ static void __init efi_tables(void)
>  	       efi.smbios =3D (long)efi_ct[i].VendorTable;
>          if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) )
>  	       efi.smbios3 =3D (long)efi_ct[i].VendorTable;
> +        if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) )
> +	       esrt =3D (long)efi_ct[i].VendorTable;

I think all the casts to "long" are bogus here. At the very least
this ought to be "unsigned long", but I think in your case it
actually wants to be UINTN (the destination variable's type). Also,
while I guess you simply derived the two new lines by copy-and-
paste, please avoid introducing yet another instance of the pre-
exisiting indentation issues (hard tab and too deep when tabs
expand to the usual 8 blank positions).

> @@ -1053,19 +1109,19 @@ static void __init efi_exit_boot(EFI_HANDLE Image=
Handle, EFI_SYSTEM_TABLE *Syste
>      EFI_STATUS status;
>      UINTN info_size =3D 0, map_key;
>      bool retry;
> -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
>      unsigned int i;
> -#endif
> =20
>      efi_bs->GetMemoryMap(&info_size, NULL, &map_key,
>                           &efi_mdesc_size, &mdesc_ver);
> -    info_size +=3D 8 * efi_mdesc_size;
> +    info_size +=3D 8 * (efi_mdesc_size + 1);
>      efi_memmap =3D efi_arch_allocate_mmap_buffer(info_size);
>      if ( !efi_memmap )
>          blexit(L"Unable to allocate memory for EFI memory map");
> =20
>      for ( retry =3D false; ; retry =3D true )
>      {
> +        esrt_desc =3D (EFI_MEMORY_DESCRIPTOR*)EFI_INVALID_TABLE_ADDR;

Nit: Missing blank before * and perhaps wants to cast to pointer-to-
const.

> @@ -1074,8 +1130,21 @@ static void __init efi_exit_boot(EFI_HANDLE ImageH=
andle, EFI_SYSTEM_TABLE *Syste
>          if ( EFI_ERROR(status) )
>              PrintErrMesg(L"Cannot obtain memory map", status);
> =20
> +        for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
> +        {
> +            if ( is_esrt_valid(efi_memmap + i) )
> +            {
> +                esrt_desc =3D efi_memmap + i;
> +                break;
> +            }
> +        }
> +
> +        /*
> +         * We cannot pass esrt because we need to explicitly compare the
> +         * descriptor pointers for equality.
> +         */
>          efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_=
size,
> -                                    efi_mdesc_size, mdesc_ver);
> +                                    efi_mdesc_size, mdesc_ver, esrt_desc=
);

Since esrt_desc is a global variable, why do you pass it as an argument
here?

> --- a/xen/common/efi/runtime.c
> +++ b/xen/common/efi/runtime.c
> @@ -52,6 +52,7 @@ static unsigned int efi_rs_on_cpu =3D NR_CPUS;
>  UINTN __read_mostly efi_memmap_size;
>  UINTN __read_mostly efi_mdesc_size;
>  void *__read_mostly efi_memmap;
> +void *__read_mostly esrt_desc;

Why "void *" and not pointer-to-const?

> @@ -269,14 +270,14 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info=
 *info)
>      case XEN_FW_EFI_MEM_INFO:
>          for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
>          {
> -            EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
> +            const EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
>              u64 len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
> =20
>              if ( info->mem.addr >=3D desc->PhysicalStart &&
>                   info->mem.addr < desc->PhysicalStart + len )
>              {
>                  info->mem.type =3D desc->Type;
> -                info->mem.attr =3D desc->Attribute;
> +                info->mem.attr =3D desc =3D=3D esrt_desc ? EFI_MEMORY_RU=
NTIME : desc->Attribute;

Why this override?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 10:39:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 10:39:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299812.511028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc348-0002sI-R1; Wed, 06 Apr 2022 10:39:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299812.511028; Wed, 06 Apr 2022 10:39:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc348-0002sB-Nu; Wed, 06 Apr 2022 10:39:08 +0000
Received: by outflank-mailman (input) for mailman id 299812;
 Wed, 06 Apr 2022 10:39:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc346-0002s5-V9
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 10:39:07 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c68394bb-b595-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 12:39:04 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c68394bb-b595-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649241544;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=4S/+eRG2N7Nmm4j4XF0jaSlzIqfZoycjiY3YRSZ8Mz0=;
  b=hO3qIf0uHTkS/r3ATs91tdkHZr+PEbTjdiaExe54vrtpEgiTQjpFRW+Z
   5dFdtFThYFzTgmuKomblCy2MNx2XCJoAi++svKnAHnwkgqE+J/mzdnRUT
   ISo4bV/YKaXGb2+18bAnvYcz81t9pJrk0BhsH6imFFUtnE3+M1Cq+nhmG
   A=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68156689
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CMDIdqCTtukWpxVW/z7jw5YqxClBgxIJ4kV8jS/XYbTApDgl0zIGm
 2sXWGrTa66CNmakLdAiPNzj9RkG68WGmN5jQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jh3NYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhxz
 uUOu4CoezxyfbeWmskCFBRaLHpHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGjG5t2J4eTJ4yY
 eIwMRB+bgvDUicUYHQ2BLMsuc2h3CnWJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqEmevnjS79HoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiH6Cjl0SR8JiKLZ58luP57WT7gSmXVFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqVFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tmuVh6b/PuREDGQ3C94acu51qXHb4
 RA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSLyJNAMsGEudBgyWirhRdMPS
 BWN0e+2zMUNVEZGkIctO97hYyjU5faI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5DTkU8CD7SiPHK/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chYwJIbX7ZEfFTi3Vw==
IronPort-HdrOrdr: A9a23:HTulkKBoo4SoatnlHehOsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QZiApIs+PvP+UpgNdtvpYfHHfFAlEii8eV57HzzcZdQ60jT22trK3Ik=
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="68156689"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oWdG2bG2MnbjDImoACqCzsnsl+O/67lQhfTEKAdWLoBnq7W2wq5k6k1wRIpN0/YuELDiC/yxZfGPJN71t55hyYVrCLnwb9hePaiJK1/cHj42h2M6m7Q53K35K2evrvNlxlQADt/bTnLQ5rMoEFBWl3dRnMMrm27FqoxoeHpyuwiQoYhw1+IJI0CFff+3EYkzzpINavgrdgDywMPyX6tdJJwv4+xsVkUvhts/C59KFIhiT5buOApWiHNNS6LJlO4ATKu4aZlto5fduxRd204IlkflWPr9U80TRMqP6viFORN6SUEnpzIz8EQh/hNCdqqSZ6mYEjj3EVcFpROOA4y04Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+d+bucWvrqZCnG9AHgIGXShQYWJ04fo3sm0QilA9wIc=;
 b=DGde4BHp8uojqkciw9vSVW5dhwWwIYmgNJaTVn7yqQRk9XYO4Ac9uZpBefDXkRwtYdO7B9gkub7ENk7yFqin0vYzWU0qVSnNgPjyzCLBjlNzg7nxCACo4qeX4bTXObaWLQo5Zs5o+7cbpwMuQWIX7Poffp5cIlZVGOUCXCQZ0LajCihtiHZ7BZejYukllQRTJUQJPToEdfpXyxugigp96oNnbi1t+TPZd1DFf60ReeWriOFmtAYIm2V7mo2wtd7Egz4FF+y0bd4R39G58ztI/8ShaUwftj2C4p2uIsEA7GQn1ak9KRKp9+6vnKOikGQvWqnn20th1S6N1LDVhxO1Dw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+d+bucWvrqZCnG9AHgIGXShQYWJ04fo3sm0QilA9wIc=;
 b=oTprLsIRawtDFL3XDWtnVm2bpsIXqkUA1TDw99p1Dfp+XezMlFC1pPZmMiZrfSexefJZId1OOASmiWnhsByy6PjpU+jmgl95aL2avs5iQ3nQ4wcX0OB3Q7EXkpVotP0hn+Mh+85eFBCRt7xiwihZLtCJctm+QumM4beQbMC+LhI=
Date: Wed, 6 Apr 2022 12:38:53 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: Questions about Cx and Px state uploading from dom0
Message-ID: <Yk1tvf7oqOf3jySX@Air-de-Roger>
References: <YjrgQOYbsaYOV08H@Air-de-Roger>
 <6a029529-fcbe-3923-26a6-58a58926762f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6a029529-fcbe-3923-26a6-58a58926762f@suse.com>
X-ClientProxiedBy: LO4P123CA0311.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:197::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aae96905-ef73-44b4-3953-08da17b9a849
X-MS-TrafficTypeDiagnostic: MW4PR03MB6868:EE_
X-Microsoft-Antispam-PRVS: <MW4PR03MB68689CB23D670912FB9C14A08FE79@MW4PR03MB6868.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ISrP5ejSEW+sX+fT7y1GpAiJbIYo+1e3XtQYCYHUpz7VkeQa+3QYU+HiBkAeFCCYA4/g5rKjOcmikkN/L6YeylT1hQym3tB1czDJ5xN0+6Ron/LCLrRHoul6XoG6oybVefT0OoHTSgd7H4ePXh/Dqhq9hKtlgIoRjELDL723BdHbx4wVbGspOHKAFRzQFb9jshcK0J5V8wRSsmzyudVYzRLMc2NTFSUVkpwrimsYCBf8PuOhNxRSVUDqOOOp4rCOgmYcaYtcdS9HDE56XrwVdS7ybRk+rxXK3flmQ4lrnX0Pz1kjqXK9vzCXYJf14Ovpjq6OU7LEHSFdQHfr5O1Kspm+ZWOVOz+bOvlvDkFLomCJiv6CsP1ZxqsPOxz79/PlyjCakIyOUzPHhMk7j0UelEQI+EKJlmL8JdcGSR4NfuAB0XEDl+Srs3Oo+daOWJgcGIRcphcpn5ZxbfqysxA6yN5CVpbIn3jX4KuaTmCY9UW9mdBaKjoaHlzg62cFd0NmeJODDpvHzJAGd675n5wE4EQ4jIoglVv7rBcVf5FFqI8LX44Puy1xv+zW3AB5I2ZXUNXWSzwBO5uMj2cuNjmhzB7RTG47ehFbjm7BLKiCyRYmHx8/3VYkYf0eeUl+keHH7j5uembiOBCz+EfYZWnbSA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(2906002)(4326008)(8936002)(66946007)(316002)(83380400001)(26005)(6486002)(186003)(508600001)(85182001)(66556008)(66476007)(6916009)(8676002)(5660300002)(54906003)(86362001)(33716001)(82960400001)(6512007)(6506007)(9686003)(53546011)(6666004)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0ZMekZqR2ZWNUx3Y0tUK0R2OHNmODcvNXo3WlhRdHpucFd2RExDNUNSVWZU?=
 =?utf-8?B?VzJSN1BFRzNEc3k2Y0NTVkVpWlJybEdnNFNZRjRLUEtnRlQzNjNodDgxWW1R?=
 =?utf-8?B?VlNoRTRLT0JvZDN4dzhSTFJoSlB0NXBjb2piQ05WNHZBbW1qWVAyL0ZSV2RP?=
 =?utf-8?B?dnoyRU1mc1hRUmxPWVBPcHZ6RFVxUC82YVRGd3FuK05TNDRxUjVXb3RPK21I?=
 =?utf-8?B?Zmg3TThmZms4YUxIZExCdXBJMEpudDRTNHJSUUNqUWJNc2Y4STZwSElldjZy?=
 =?utf-8?B?TkJJYjd2SWZTOER0Z1VoZGYxdU1BY3JYQ0JjYzBQRHBjZEQ3Z0VVL2pHelly?=
 =?utf-8?B?REozSzNvVCtNSjcvcklPMS9BcHBXZnIyd3paT3lTQXJtZGxQTUxOZUc3dlZT?=
 =?utf-8?B?NHN1dWtuVUNpTHhuTXNCUzdGMDAxcWtpSEgxUUUvZlRxdjBSS1p5RjIrcU9o?=
 =?utf-8?B?aDlrcEFqRUZ5SEErK2NLQ3FEU1E3N1JuY0Z1V0VFbXlNZmV2c2xwQVZmb1Rw?=
 =?utf-8?B?VEszSkExeFNlZ0F5NVdleGZHZFNKeWNBY0RVaWIwcm5jUWVXYkZtUEJWT0pK?=
 =?utf-8?B?QnllUUZ3Mk5YU3RzZFJhVHdyZFgxLzBwd0lNSmRvWFBoV1hRNDR6YjU3RHhR?=
 =?utf-8?B?cWZUVHYzRUIvdXljdmswaHlIOTFyNzlSNHdKK0FJZG45bFB5QUN4czNqc1VU?=
 =?utf-8?B?ZjlTMEV6eml4VXcra2ZFWHJiWmdCNjh0RFdWYnJLQUVwdTFpempPN3dzemJ2?=
 =?utf-8?B?ME5HSXhuUUJFdDc4Q0xyM3VLT01DYnB6SjBwek5zQTNNbmthSVR5U3ZSUWR0?=
 =?utf-8?B?ZitoMFc2ZkU2VnI0aDIxOFY3eVFNMnBvcForcTU4M1VTV09tNmk4Z29pR0FM?=
 =?utf-8?B?UDVOdlRuL0l0djF1WWVVc3RiVnhONEREUnBmOTFBNE5SeTF1bmtWMXZ6Z0Vl?=
 =?utf-8?B?eVdsVUpvQmdHcmZ2cW44akFYVjNRckVxc3dmMmFkZkpuWnJjNEJ6LzFxdFNM?=
 =?utf-8?B?WSt5V0RLT0lWeDg3SWhzYWdwM0dTWVlUTDFSeU1RR04yRmlKR3VUSno5cGZs?=
 =?utf-8?B?bDIydUo4S2lFQk52YWJiU0gzL3lmSHEwVSt0VkNUU0NyTFNESE1TcGY3bXFh?=
 =?utf-8?B?WmcrVG9LRGJRUGRsTTU2SGJCdTBOTkdMQ3dheTFBb1VPcE9lWmdqTXo4U3Zw?=
 =?utf-8?B?enhOZStkcDVlTWpZUDN3OUFBQzNmTU8yRGsvSERMSGlVbFdlZFpHWjRNYU00?=
 =?utf-8?B?em5UckhnaEZyTGsvZGZ5dC9IMWVtZmlFUlU0T2dFUC9wNjJ4SGs0aUlzM2ts?=
 =?utf-8?B?YUNZZGNkUjZILzBQTGxwdSt5bXdCQUw4bEhabjRVcnZLNjdMMkNIMWExTUNH?=
 =?utf-8?B?UEF2cjRuTHFja0lTUktYbTBzMUR2eWFxdjBSOXBSQm9pSE16MXoyNzIrVDhl?=
 =?utf-8?B?SjQzNmNzRHAvNVRzakN4c2wvb1dYai9SeFV6QURTdlEwYkRjVGg0QURuTy9r?=
 =?utf-8?B?TWlqVE95RjhZWEgxY2lvL0dyUzA2RE1KWGVUSnBNRW5mbVorTHdGWHhmakI2?=
 =?utf-8?B?aHJ1Qk5sNEYxUEVBYy9vSjdxWWROYVBVeStnVTJWVXRBOEloRjAwNVdVSncz?=
 =?utf-8?B?NkVvdHVBbS8rZlVPb2c3YmoyRkh5OFExZWV1Z2IySHpiQVRPZFVnNDQ3bS92?=
 =?utf-8?B?RG9zS1JnTHRKcXFYVVVldXM0QzAxS0g0WVlYZ3RKWktuREZrMkx4UFIwRzhl?=
 =?utf-8?B?UUt5Qkp1Z1R1Mm8xa1hmQzg5a2xDL3VaRzg5Q2s4WnlEcjBGZ1dhbFlBb2Ex?=
 =?utf-8?B?S3BOaHorcnpUOXl2VzRBSW1YZGZ1Z2VCZ3FiblNta0Y5WTZsVHBBZCtRWUJT?=
 =?utf-8?B?UnZCTGdKaDlkdEw3ZzNJNGZ6YVdoZ1JFQ2theTVadVR3WWx1aCswd0tsS1dS?=
 =?utf-8?B?ZFFNNURWL09FWStkbFRVUEtMWDVvY1YvbHZoNU14QzVxYlFXdlp4ZWN5YVg0?=
 =?utf-8?B?Qm5aVFVqenVYa1ZqbnUrQTNRVldXSUFpYktnNnFIaHY3VmZoQlNVNnpPZnZT?=
 =?utf-8?B?WjlKQmVhMWxhVFZZWGp2S1pXbzB2U3NnNlJ0MHVXZVBpWVdwUFBDakhuQzU4?=
 =?utf-8?B?VjdTZXNKTUsyeW1PU09jaGVOZUN0akNubldKN2daczVOS2RCQkRQWmpWbXVV?=
 =?utf-8?B?Q0lxWUlod2gzeHR1akcwU1lVRmE1SE4yVXVNUGllK2t0QWpxbEVFajBhUkhW?=
 =?utf-8?B?OEtWTFdDTkI2am1SMEtkTnU4dkNRSmFGaDkrZmI1SUg1NlNSU292TmZoZ2lF?=
 =?utf-8?B?eTB1T3BWc3g4UmJydFYzK1hiMkUxTS9oS2c0TlhuNGQ4TFVabWdhUkxmam9i?=
 =?utf-8?Q?gayzJ4N8SEAoJfpk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aae96905-ef73-44b4-3953-08da17b9a849
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 10:38:58.7356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2v6kPdXCoFuy11APzc4hNbXkFTRR8olMKLs2tJY07Fixh7tyBq5dj2uqqyEMpI++yVcX5PKlOC8zAuFL5yKgRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6868
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 10:13:41AM +0200, Jan Beulich wrote:
> On 23.03.2022 09:54, Roger Pau Monné wrote:
> > Hello,
> > 
> > I was looking at implementing ACPI Cx and Px state uploading from
> > FreeBSD dom0, as my main test box is considerably slower without Xen
> > knowing about the Px states.  That has raised a couple of questions.
> > 
> > 1. How to figure out what features to report available by OSPM when
> > calling the _PDC (or _OSC) ACPI method.  I'm confused by the usage of
> > this from Linux: it seems to be used to detect mwait support in
> > xen_check_mwait but not when calling _PDC (ie: in
> > acpi_processor_set_pdc).  I'm also not sure what the hypercall expects
> > the caller to provide.  Should buf[2] be set to all the possible
> > features supported by the OS and Xen will trim those as required?
> 
> I'm afraid upstream Linux doesn't quite use this as originally
> intended. Consulting my most recent (but meanwhile quite old) forward
> port tree of XenoLinux that I still have readily available, I find in
> drivers/acpi/processor_pdc.c:
> 
> static acpi_status
> acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
> {
> 	acpi_status status = AE_OK;
> 
> #ifndef CONFIG_XEN
> 	if (boot_option_idle_override == IDLE_NOMWAIT) {
> 		/*
> 		 * If mwait is disabled for CPU C-states, the C2C3_FFH access
> 		 * mode will be disabled in the parameter of _PDC object.
> 		 * Of course C1_FFH access mode will also be disabled.
> 		 */
> #else
> 	{
> 		struct xen_platform_op op;
> #endif
> 		union acpi_object *obj;
> 		u32 *buffer = NULL;
> 
> 		obj = pdc_in->pointer;
> 		buffer = (u32 *)(obj->buffer.pointer);
> #ifndef CONFIG_XEN
> 		buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
> #else
> 		op.cmd = XENPF_set_processor_pminfo;
> 		op.u.set_pminfo.id = -1;
> 		op.u.set_pminfo.type = XEN_PM_PDC;
> 		set_xen_guest_handle(op.u.set_pminfo.u.pdc, buffer);
> 		VOID(HYPERVISOR_platform_op(&op));
> #endif
> 	}
> 	status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL);
> 
> 	if (ACPI_FAILURE(status))
> 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> 		    "Could not evaluate _PDC, using legacy perf. control.\n"));
> 
> 	return status;
> }
> 
> (This is a 4.4-based tree, for reference.)
> 
> IOW the buffer is passed to Xen for massaging before invoking _PDC.

Indeed.  I'm however confused by what should be pre-filled into the
buffer by the OS.  _PDC is about the processor driver power management
support, and none of this power management is done by the OS (I don't
plan to let FreeBSD do CPU power management when running as hardware
domain), so IMO passing an empty buffer and letting Xen fill it is the
correct thing to do, at least for the use-case in FreeBSD.

> > 2. When uploading Px states, what's the meaning of the shared_type
> > field in xen_processor_performance?  I've looked at the usage of the
> > field by Xen, and first of all it seems to be a layering violation
> > because the values set in the field (CPUFREQ_SHARED_TYPE_*) are not
> > exposed as part of the public interface.  This all works for Linux
> > because the same values are used by Xen and the Linux kernel.
> 
> Well, yes - that's the way code was written back at the time when
> cpufreq support was introduced. It should rather have been
> DOMAIN_COORD_TYPE_* to be used in the interface, which Linux
> translates to CPUFREQ_SHARED_TYPE_*.

I will send a patch to add those to the public headers.

> > Secondly, this is not part of the data fetched from ACPI AFAICT, so
> > I'm unsure how the value should be calculated.  I also wonder whether
> > this couldn't be done by Xen itself from the uploaded Px data (but
> > without knowing exactly how the value should be calculated it's hard
> > to tell).
> 
> As per above - while it's not fetched from ACPI directly, there
> looks to be a direct translation from what ACPI provides (see
> acpi_processor_preregister_performance()).

Yes, the translation from DOMAIN_COORD_TYPE_ to CPUFREQ_SHARED_TYPE_
is not a problem.

My concern is that there's some logic in Linux to assert the
correctness of the provided data in ACPI, checking the match of the
domain and the coordination type between all the processor objects as
part of setting the field.

I see that Xen also does some checks on the uploaded data in
cpufreq_add_cpu, so I wonder if I can get away with just setting the
shared_type field based on the coord_type of the current processor
object, without having to cross check it's coherent with the values on
other processors.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:23:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:23:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299828.511038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4gi-0006K9-RH; Wed, 06 Apr 2022 12:23:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299828.511038; Wed, 06 Apr 2022 12:23:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4gi-0006K2-OF; Wed, 06 Apr 2022 12:23:04 +0000
Received: by outflank-mailman (input) for mailman id 299828;
 Wed, 06 Apr 2022 12:23:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc4gh-0006Jw-S3
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 12:23:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4db3b486-b5a4-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 14:23:03 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-WQ2EFeyNN8qXhBlIg-zMhQ-1; Wed, 06 Apr 2022 14:23:00 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB2992.eurprd04.prod.outlook.com (2603:10a6:802:9::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 12:22:57 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 12:22:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4db3b486-b5a4-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649247782;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=ttWm9ee+aHhw0r/e9vcokzPDdYX2VuhekspXIMntow8=;
	b=ntvnM20wc4nGddsJxIR/X06y3Pe5rOW4haJ+Krb8CPhjMU27y+TlIAUdER0Pw/pxj1x315
	rbKGhesiqJ4ZKul/Kww/Y1Vf6rF2E00AG2F9fldlqssaYOiz+wmvxLRhI5n7jl3iqFL0Y8
	L7JbvowHeeVpsWZF16ohZi24+Ff6zEI=
X-MC-Unique: WQ2EFeyNN8qXhBlIg-zMhQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gIbf9ODaJyaqGYJsNj1kkZiab/9WcIzCkRB3TWgf+k/HKdhuiEIcyErhJHSynlolxj+Qy/A0CciEM2WNDZSmeCcVPJqM86QQeHKi+00RXClFKCJ3AhXrwW1f+NAxaSJrG5bQkkISpMVnjgnrTfiNwV3XKbdPwBwZiAKVS3nDmj85UspY293SBhVlRA0Pt6Lb/C/Ix0v4IaiHErqirSD5r4BKhR85c0XxtXZo7nUHti53EtMb3bP+NngPGYZ+dEZfJXoenh3S1qucuZIpozlC5ZlYTOB1MFpRYaHcXY/QswEuJy8cMIvIZ9V+tPdZJroNhorPkerZDlwvX85q99FnkA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ttWm9ee+aHhw0r/e9vcokzPDdYX2VuhekspXIMntow8=;
 b=J4tfd9I3s6BOiKvqdT+u3U1+6r6Wt0YjpXCOtu3ngx8xxLefgfy6LGJh/yhba1HzDCkyYZEDmEvejcD7GiBrrheoVJ6PzOelbeAtiwYrB2M5FmKnZiwzbmGYAeQeC3GPLcQ7ax23GTXdvEIvqhsgklvTuuX5cM/tnfAjnYHWjCQ/AY6kP9v8/iftBTy0FFT9XUuilsrasSWriUjHAi9x6OS8JXOBE7qMLxYUEnpDxWdjVqyX8AbwRAiHvcMHx3VyvOhsi6QiQnKd+soohJzT24Wpjzr8cGuJYX311XX9DawRTpSNifKWwvfMydn9k/M9RpVL9Y2ig0/bRcS2FUgIoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
Date: Wed, 6 Apr 2022 14:22:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] VT-d: address fallout from XSA-400
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0039.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::33) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4476bae8-4b14-4f7e-2262-08da17c82eec
X-MS-TrafficTypeDiagnostic: VI1PR04MB2992:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB299296B8B49626CD4D4FC08BB3E79@VI1PR04MB2992.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NNTQ3UtqfjzBgS11iyOHQq3Ggqi5mRUjarSJyBgudGW44H0vnod0r0bkpM6rLHFChiO7G0u2KUdp5mlLaKWnk5rCOoy5l+hENjaFleh/Aa7I4zh4M3dFVyce72dDL3WvnG63DZERoVKP63ql04R3f36Nw1aho1Iy6XhYV2QICgs/r2V90fmbtqfCDKFmZwJMbr6HkA6hoG1S4DMLEQKBk3ShSIW6DWWaab+q5N8G15ZB2NdmHVQPWsVRjrBwJFOF+sei0AHDXz3hWaUcJrUU3cVJBMlzzHRz21k1tW37D2dWwVIyb/OAa5il7gOOFwHlo/mqJfiFo0oB3YpBhcNDO1LxLDTbs8orzFIrL6lX/YKjE54wWMKYyRpP/dUNp2rvsxVAgniLmkKyhqQr/sHOOcVTP8YgtXtvv4KgmlOYgaopTUU6e3Pa1XzeZ7r/YZN7blpgQM53CRRqE//3cJOjsMoRGJbnTBdoWPkmFLxeTXy1FFv+rf4O9FwemaDUkpaA4yGG86QQ8IVb9x1hCizN4j1pWlAAirPnZN4kGHEaQy2V017Uq7OnXOl/yqjFaAPB96KLX5x9rUD60jSOyplUPSGtzWiZm/VCGfDH7ZDhf7LRV91WmUFrhVEcVvvbaPKjSk2A/JE0v28BqAogQDatuNlhvdGWzwBmz0yMyE8e0j2qQbLCrepfeGoWPPfI5Wx0xSYra8WAkewfA06ZKj3slF69IRmRZIkYpfWcLYzF+3g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(5660300002)(8676002)(8936002)(66476007)(66946007)(66556008)(6506007)(4326008)(6512007)(38100700002)(31696002)(36756003)(2616005)(6486002)(316002)(6916009)(54906003)(31686004)(508600001)(186003)(26005)(558084003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y2VSQmQ1WWNrN2hCZTZHMGk0VGNrU05Od2FWNHlGeTErQy8vNkNySlFwbkU1?=
 =?utf-8?B?b2gzdkxHb2tjdlp5TUVUOVBhOUJLWGpFK1BjNzBIUGFPNEpCZjh1cHpxZ05B?=
 =?utf-8?B?czVIZlEzUFZpcng1b1dwUUYxeGVrNFBvUHk3TDU1NVZhUmhvS1lxVENQcU5r?=
 =?utf-8?B?S3ZqZEdiWnEvNllQOVE3YnNzRXpTODFId0lvZytXajRDQWZ5cVBRSGJyZkkx?=
 =?utf-8?B?a0pleHhCeFZvOCt3NHFJMm1RNmtRbnU2YjZvWnBTTWU0OXpJOWNHTlA2VFZu?=
 =?utf-8?B?aFpxK3dxS1RUOGFZNEtzSnAwSnZKbDF1T2lzV3lqWWpZTmsxMFBGSG5FUjY4?=
 =?utf-8?B?V3F2eEw4eWl4bVlSUkNQNmEvQ2NQSlloOVVCVjZlMG54aUFVRUVRazVSTnVj?=
 =?utf-8?B?SzJOc2NUWFlncmc2aHMzOG1ra0pKemhZdTA2bGNxREVEK3I2NDU3bmVwcTlG?=
 =?utf-8?B?WCtQWWlOUzAvUHRmQjV2UDE4aXJsQzA3VU5NY29SM2pUZC8xd0N0M0ZaejdI?=
 =?utf-8?B?QkkwZnRFcDdFVCswbEZaWHBHOHlwd0VhdEs4THJhWWM1dmw4SHMya0lnU00x?=
 =?utf-8?B?clY0U1VwbzJhaXBMNVdPK2ZYcmd5TFh5OFlKZEFTREhOc3o5MW5SWjZyaDZH?=
 =?utf-8?B?aVNWNG5JbnRlMlZkeTYvcVRlS1ZIN3dQRHAxdEliMUdKZzlhYzh5VDhsRFVq?=
 =?utf-8?B?QWp3NXZJYXBuM2hrS3EwNC9KVldMKzZIL2RuT0FuaVYrbldNMGxRaElNQ1dC?=
 =?utf-8?B?SFNucmk2VWo0Ny9nZzQ5M2pkckhMVXdaOUVPaXBEWFllVFhuZEl3UGwzY0Jy?=
 =?utf-8?B?WDEzMnZCWEl4bDBHbjMxL3l1Y0U5QXlJZ0FCeTV6OUYwQzFoM0tnamRuSExZ?=
 =?utf-8?B?cW1NMDgwSVM0aDhRM3UxUzhFNFV3c0cvaGVLTzd1d09ib2ZyMnJMOFU3Nmh0?=
 =?utf-8?B?eFh2R3dyUFNMTGFoQ0FQajFwODFqc0J2ZVl5bUJsc05ZWG5nMjkrL1N3RGd0?=
 =?utf-8?B?dy9BUHAyOGtvTVE5cGZCcGJyL0pQSjRRNlN6Q1NoRmI5aUQvL3RBaS9yNzVK?=
 =?utf-8?B?ODZNU2JKMkRHQ3FYZlRkK1VvOHlpd1RIazdYV0M1MFJ1NmxCd1ZDN0lEcjhm?=
 =?utf-8?B?aGtTUkRrWHU3alFrMzJnV2wzQnU5bzliSXMxRWdDMzFWSWE4WlZjYW13bWtv?=
 =?utf-8?B?b2E3QmVvNTR1aTZoL09saGh5azB4RXBEcWFBUzlNQU4xTC9KSSttYUJPaWJQ?=
 =?utf-8?B?S2Y1OU1jc1RzczJtSjgvRi9uczFIdE10WDNraGdsa0RXcWJKR2J3b0EyeEtt?=
 =?utf-8?B?L3d6YmpvVXhGd2ZDMDlRakpnWjZTWUdEVU5VRm5NYmNwdmVzZTVpbzVkSFlY?=
 =?utf-8?B?R09ZcWhFZU5ub1Bvay9zYVRjTUZ1dTRuTFR0U2NyNmpBT0t4STdqTTl5UDI2?=
 =?utf-8?B?RlVLS0RzVEZVMmQzT3ZmMWhNWU5wRHlTN2pKblhaYUxHTlcxSEdEVUIvZmR3?=
 =?utf-8?B?Qng0OGRFR1M2WGtFOU1DMFhOSVBPMGxlQ0U4OGZkb1lsMitCc1daRkxycktn?=
 =?utf-8?B?eXYwblFndnpUbXpkU0NuQkhHWmtxa3JqK3Q4bzI3Nkw5alY1N2ZRMjFSRzB1?=
 =?utf-8?B?STFrSHFBTGl5UkowODBjOHhPdnFQam9nOWQzbko1OXJmdzB6eGw0L3ArR0Fx?=
 =?utf-8?B?VCtybEk5U1ZGUG1sd1hZVGljUTB5UzhEVCtiVUJLM0E1Tk91V3dRUmtEdUdQ?=
 =?utf-8?B?UFh1dWp3UGY2THdodkJoamlZOTFDUVVvRjlNS1BQeU9hVU9ING1SdVQxd1lr?=
 =?utf-8?B?Rk1qSFBCMWdMZE9PZkJpd2l2d3VOa29CejUyUitMWlF4eXFJRURlQUdqbFAv?=
 =?utf-8?B?eElXdnNha0hEeFlKVWJTeVRvSG1Dck5ZSHR4dll3VGc4WE8zMk1paGl4MU9T?=
 =?utf-8?B?RVRmSURvdnRydnpOakhjVFA1b0lVZ3IvdEVyOXlOL3pnMDNYQnhqSS9wV0ht?=
 =?utf-8?B?WFFyWEN4aUtnSDNhTllnamZIdE9BenFhTVppRnhybVpqdEY0WXJZaXBlbVhq?=
 =?utf-8?B?ZXU5VE1MSkJjTzJ3cDNleEIzc1VHd0FNSXZsWVowYVNaL0JsQXREVExXNWdH?=
 =?utf-8?B?czVDdnFxOXY4cFczaURXbnE1Q1o0WkxXY2h0TkozcE1BYTV6NW1RRzRWd1NJ?=
 =?utf-8?B?YWNhZ0V1WFJlL2tMTVAxcGswQ1ZrYmswS3hBcVVVWU9XL2oyb1A2S0tyclVK?=
 =?utf-8?B?UzFmUmoxbm1NL1dLQkd1aDlrRGd5TVlyUEdsOW1RR28zakE0UWZaVDU3UjdE?=
 =?utf-8?B?TmlCL1pJUVg4U2VGcUlFdnBKSk5hT25zRnRnSVUwWEJpVGRCWVpwZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4476bae8-4b14-4f7e-2262-08da17c82eec
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 12:22:57.6502
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m9w/cbwn32b9o88alpZsrhQsNb0VEbe073oyNg0BbnUt0bJgSlJpSzuCnXQxlXeSV3UjfTDZiGz5nGVpZ86DXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2992

1: avoid NULL deref on domain_context_mapping_one() error paths
2: avoid infinite recursion on domain_context_mapping_one() error path

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:24:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:24:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299831.511049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4iG-0006rP-6r; Wed, 06 Apr 2022 12:24:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299831.511049; Wed, 06 Apr 2022 12:24:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4iG-0006rI-3p; Wed, 06 Apr 2022 12:24:40 +0000
Received: by outflank-mailman (input) for mailman id 299831;
 Wed, 06 Apr 2022 12:24:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc4iE-0006rC-OJ
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 12:24:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86175df8-b5a4-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 14:24:37 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-i0tqvcT5NP2GDc_Fn25qFA-1; Wed, 06 Apr 2022 14:24:35 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB9326.eurprd04.prod.outlook.com (2603:10a6:102:2b8::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Wed, 6 Apr
 2022 12:24:34 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 12:24:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86175df8-b5a4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649247877;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=D1H79nwsMeW3yxZjDR3qBFbh8QW9Tvu6xAmwomlRz84=;
	b=eND6D2zGIOQcj1HJ4LRJfrDO6ycyzDO9L+zN/eMJl56UVwIoMxF0ru2P9tkzvKOG5XwkZ5
	T0fH//jflxUSrCCwrHVAONWHXx+rps51uucmXVqvXbzhe6zxQJ0AdtvCKIiMJOsDcU2ITF
	69en9OkBwjvoCbA/VIwCZ+yLTEEqmoc=
X-MC-Unique: i0tqvcT5NP2GDc_Fn25qFA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AvGLn0QSXzHU/kbCVpRHZUVil0sBDFA3w0fdumkuRGxlDihk7b/HsbmdOMsIUtieHdAm7UUbBvNr5b71/T4H7v7agwgBxIV9tYc7slpquOvMCC5LQRJT7wLWT+takgHBa50tnnnucad6d6vhkPKb7K3cumTbJMryUy4Ve0gx/i+etIaHIz69SI7b/jZh1vN+mNCC3Or+wKRwKsaOAXnBO9+URvbbbCoucfelJD4+vWgUsk2aTnJMPK13rL1E8HAwkOuz/7fCkQPzfS6c2p5Ma923ShPPvniBvD7ihtekW4MDusetR2tOCRofnprZSTRFtc6S33B75LDRS4QgyRKUnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D1H79nwsMeW3yxZjDR3qBFbh8QW9Tvu6xAmwomlRz84=;
 b=higyzMtdPQU4xDsL+aovMUgTgl6u/o4rlS5ntv4MDXjU5SbTQOeOpjJJNx6WqlK6H82gJpTJUCmrlGC8uwf/MDxnI6+/oLB/jAtQID3R1ECOevwWPtIrY2ZkS9jc9HzAXiW+gHwHnIq/1KnTS25vdZYyG76DEJqokIgduG1Nhy6cN9tibFd5bJFOXi5asiTrVcSL2NlFo6LeHgrD+f+1+TuIOkiw/7+pqWE50WFdOZ76KwM5uO48co2zKkUBJuIeJ3AeepAoOtbvrDC0DiQbMKRByhXIPLfNAWsmwb7EzC/5IkBKmib0GOFedcubmDhPJd/7mzZ0CIw84Vvu8dGhJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d232b6bd-17d2-c78f-49e1-67ffc2502810@suse.com>
Date: Wed, 6 Apr 2022 14:24:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: [PATCH 1/2] VT-d: avoid NULL deref on domain_context_mapping_one()
 error paths
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
In-Reply-To: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e67ae826-38f2-419f-bead-08da17c86881
X-MS-TrafficTypeDiagnostic: PAXPR04MB9326:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB932661D2ACDA217554B69A02B3E79@PAXPR04MB9326.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AEr2ZtqU/y3UibKYS4HcLP9S7D9zaGD2EYhJ9xKq2EZSgfdiYOrkWaB0uGnbbDv8zCqRztllXdwlpXNQKS+yuIU5ZmxOWZrv+dZmnWESbqjKmh+66GbzsWeFAoh2S8rPErFoY2slfsajUazwdM7oJqbm0x+NLWfILBmWFgHj/cZsOBou+wjEz1euwF7S6nxolcu0ZYgOx7WfcShn1hazkk9QnIInXgZjXc5cp7T0fVVvKnqSXhZTzZm6lHTetRk4dw3ecSBguMCMCPgoto3X+plPxkCGSx5D2RuGmIhtp9xykMjjkLR+97JEm1usbGFe35u/IBZs2m3UICuOMcXb5mhlqGDD4JKkBKM7oGXuIAflC/RrZuK1Y3o1UBcxBISRmNF6r/rAaR8AvI4gzw5urcwAEoTVWTyLoYGwn6cb93UktA/hLF+Jevasm1JNWj6MT5+nRn8QvEA2FfjwAqDhqEuGZlXqaHIZDYPYd3ytDZn2kduKf4+EKTpDTNmS60Od2v7vffX6B7APLCUN6Uqx44i4FySKkqIw02tPgqkznvIvkjo1THpVbS3zQCR4TJ08T0zEEi/rrqb86Qi51kn46PrwuGhY8dUyohvM9IKtgp218K9x+r/d13vguOThDuHGnt7uRCJKRH1PQa8gzZejqYuVvK4aiqWTySCkwl9vWUL7S2LCizUN7l3w11hHoW4xngFdh5vbFr7WO2/RdaMs2zVs/9oluyYXjfJ8/4Qcc+B5yUtxw590NAonZBRiG5XK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(26005)(316002)(2616005)(6506007)(6512007)(31686004)(36756003)(6486002)(54906003)(6916009)(508600001)(2906002)(31696002)(86362001)(66476007)(8676002)(4326008)(66556008)(66946007)(38100700002)(83380400001)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TEJBbnlYcVRnSzVVaFJpR3FBcVNtRFg1QmVzSVJ6M2s1ZHNFQ0VFdjJXa1Nv?=
 =?utf-8?B?ZDA2V2I3eHJHTWVxMzRvTEdkVDEzdkJwR2JES094TXA4Q2dMZEZNVmdqL21U?=
 =?utf-8?B?ejB3dEhUWWRwRXlmOW1McThMYkNVWEF5Vk10ZytOeHdpUnozczBxYUlBcEZL?=
 =?utf-8?B?TGRnSXFrVDY4Ri9FMGU4MG55RWErUStOTXdHNUJRNElCeHd5eEhsaGE2VkRN?=
 =?utf-8?B?aWI3SEQxbmgyOEZQYkgzbGNraENMeEpoZTFaKzdlakJpRDlHdnlJakZ3TzR6?=
 =?utf-8?B?R2E1Mk5tMDJHNzdpZ3FpcjdXdE9JaWVycFhSMWU1Yms3ZnBpV2hLc3BOQ3Y4?=
 =?utf-8?B?TTRja3pHUkF5QTRUc0c1eGg5bGprNWlXbVVZYUxDOXVkYTlJTFZmcWE5bVRJ?=
 =?utf-8?B?TjNrTHVFOWk3VDdCTUlOT2I0WDZwOWxuR21iRm1FeXhrcjVFVnpwZVBtVzk1?=
 =?utf-8?B?N3cxS3BlZW9PQzVLY2JVcEEwd2k3R2M3U3IvVEw3NXpUZ2xjRXNxdUxVTWwv?=
 =?utf-8?B?QTB2bFJMUTUraTRKU3BWc2plN0JJOWRYelJSUmJVcGgwS2NMMXRNK3VaOUpx?=
 =?utf-8?B?Uk9abmR6bXFoYXBhWUFGdGVlZlY2aHlySnBEekdDR1RjejZEMHJNTmpVaDBn?=
 =?utf-8?B?TUZjV2VMKzRadndKZUFMS09uczU0NVZ0NVVscjkwN01nOG16M1VBRnFoZXEx?=
 =?utf-8?B?ZGQ2TWNpcDl6WVpXWjlQRWxyRUZNVkcrTmh4U0l4aCs4Qkl2MVZ3RTRRV3M5?=
 =?utf-8?B?YW5pb1Y4NnVvOGZ0dXZNbG16QnFickFiWTlQQ20wZFhPMlZGZHFsMEJqYnBG?=
 =?utf-8?B?UGJBTWdMTkZMWmUwOWFsN045WWJacGNGSGp5eStBejhHRFNtYzhaMzlmQmFm?=
 =?utf-8?B?QU5pQ240KzY5REh5blJPdnRUendXOE1KNWFUQXdMaVpxWjhwVjVOQkpDbmha?=
 =?utf-8?B?ZG1FVnlmTDJKdzVYN2JLWW5MVGlrUFdXYkY5NmRaZytPUjhEdUVsMzdYTVp1?=
 =?utf-8?B?bVZnWlBzeUpybjRFYmo5Y3dPZkY2Sk9yTUpodmNUKzJuaHdCdnBOcVBFdzVE?=
 =?utf-8?B?ZE45c3AyeE14SVRSN2djRTlLRkY3d20xWXU5cHVaNEJtZkNUSUlseUFhYnJS?=
 =?utf-8?B?dXZGZXVVLzlQNWM0M3BBd2laam45bTNYbVBsNEFvb08wR2hRR1VpdW1YV0My?=
 =?utf-8?B?aHZUeVQ5VzRDTUhiVUFzRWRwZ1BjRFM3c2NjUkRBQUtPV29uUGZvNVJHY2pM?=
 =?utf-8?B?TVU1SGZST2hETkFqZlJobkxLOW96WVFWZXBRaHBHQVNGLzF0LzJ3QWlBcG9P?=
 =?utf-8?B?SGNjTnc0VG1LTDJ3UTEyQmdHdFhMMkdWK2FrTXBPb1orc3ptMEUrTkV5ZHZM?=
 =?utf-8?B?cmh3YXBmUjk3dTR1M054TnNUK09STE9meGM4QzJqbUFuN2NFWEluWHJQaVNn?=
 =?utf-8?B?NmY0YjVTLzFOMWh2T2tiU0RPRmxYRVBMSy9LMGsvK1VVUytWU3JGcTFQOVg3?=
 =?utf-8?B?MjJIK0thcU5nWU01ZW1veW1xdGpJelJvL2xuQ003YkJlQUk2dFpuOUZOamFt?=
 =?utf-8?B?VGJQRHFONS9yU2NGdldyQW9BVXFRZjVYMTFZQUFzdmU0MmFydkMxWDN6TTlX?=
 =?utf-8?B?c0N4ZnF5amJPU2dPQ0ZjY2QraHNzZjFyVGV6M1pyS3ZDa0VMSE9hbzBNS0lD?=
 =?utf-8?B?SzRRQ1FFbUJERC9MYlkxQ016NENqRTFGYThaS2QwMEpxbGlIc0czQUM4cFY3?=
 =?utf-8?B?RXhsVFNkOC9pdmVOMkJCWEZrcVJETE80Q0NuV2p2c2tYQlJUcCtsNEZwTWlI?=
 =?utf-8?B?SkUxOEMyTDJnSk9jRmxJUTlwOUxTajhScmdXbWN3NThLMHBYVXBqK3dMYTZ2?=
 =?utf-8?B?VThjUkJzTkFTNTNuZktDOUFwSGhDWDQrOHNMTDJaWklvOFFIQVVYQ0Vhc3E4?=
 =?utf-8?B?Vlk3SUpWUHhaVDJKc0M1MXN5bEc4N2RxUkd1cVo0a3BlYjQwRVhXYkVYSFhB?=
 =?utf-8?B?SXdVa29qd1dqRDd6alQ4aitxVU43NkY0b2hScGlRRlJtL3U1WThJSnZYdlIr?=
 =?utf-8?B?NkdGSkpiRE4wd1lQbXAvUWlRSXJ6VXoyZnZzc3ViMkk3cFQzcldxRUxnblY1?=
 =?utf-8?B?ZjhtSmJ4UUZuS212dElmOUdSUFdDbjRybWR5R1NiK0lMWXRDZnRhWlhKaFZE?=
 =?utf-8?B?djRweWVoZEkvNHlNdnJsWDNQMjExRFJqb0JZVFh4UXVKbHJpY0ZFMno0eEdI?=
 =?utf-8?B?Rzg5UHE4cFRkRzZnRmRJazZka1NiN1dpWDRVaVNJUFlkTEFnS1pMYm9WRGpz?=
 =?utf-8?B?SUNGWVZFWkJzMG9iTjlxMktBT1ZnNmZqVmh3QjFkRklvc3MrWTM3QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e67ae826-38f2-419f-bead-08da17c86881
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 12:24:34.2140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /IfpHeMbB0sanWakkvum4kPAsxjl+46m2wxNR1Ft/hzmhXeWnBmXi3TdqkDwewdW9D0ClSmd3wvkN2ImVBxbHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9326

First there's a printk() which actually wrongly uses pdev in the first
place: We want to log the coordinates of the (perhaps fake) device
acted upon, which may not be pdev.

Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
device quarantine page tables (part I)") to add a domid_t parameter to
domain_context_unmap_one(): It's only used to pass back here via
me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again.

Finally there's the invocation of domain_context_mapping_one(), which
needs to be passed the correct domain ID. Avoid taking that path when
pdev is NULL and the quarantine state is what would need restoring to.
This means we can't security-support PCI devices with RMRRs (if such
exist in practice) any longer.

Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quarantining")
Coverity ID: 1503784
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -750,6 +750,10 @@ However, this feature can still confer s
 when used to remove drivers and backends from domain 0
 (i.e., Driver Domains).
 
+On VT-d (Intel hardware) passing through plain PCI (or PCI-X) devices
+when they have associated Reserved Memory Regions (RMRRs)
+is not security supported, if such a combination exists in the first place.
+
 ### x86/Multiple IOREQ servers
 
 An IOREQ server provides emulated devices to HVM and PVH guests.
--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -85,7 +85,7 @@ int domain_context_mapping_one(struct do
                                const struct pci_dev *pdev, domid_t domid,
                                paddr_t pgd_maddr, unsigned int mode);
 int domain_context_unmap_one(struct domain *domain, struct vtd_iommu *iommu,
-                             uint8_t bus, uint8_t devfn, domid_t domid);
+                             uint8_t bus, uint8_t devfn);
 int cf_check intel_iommu_get_reserved_device_memory(
     iommu_grdm_t *func, void *ctxt);
 
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1533,7 +1533,7 @@ int domain_context_mapping_one(
                 check_cleanup_domid_map(domain, pdev, iommu);
             printk(XENLOG_ERR
                    "%pp: unexpected context entry %016lx_%016lx (expected %016lx_%016lx)\n",
-                   &PCI_SBDF3(pdev->seg, pdev->bus, devfn),
+                   &PCI_SBDF3(seg, bus, devfn),
                    (uint64_t)(res >> 64), (uint64_t)res,
                    (uint64_t)(old >> 64), (uint64_t)old);
             rc = -EILSEQ;
@@ -1601,9 +1601,13 @@ int domain_context_mapping_one(
 
     if ( rc )
     {
-        if ( !prev_dom )
-            ret = domain_context_unmap_one(domain, iommu, bus, devfn,
-                                           DEVICE_DOMID(domain, pdev));
+        if ( !prev_dom ||
+             /*
+              * Unmapping here means PCI devices with RMRRs (if such exist)
+              * will cause problems if such a region was actually accessed.
+              */
+             (prev_dom == dom_io && !pdev) )
+            ret = domain_context_unmap_one(domain, iommu, bus, devfn);
         else if ( prev_dom != domain ) /* Avoid infinite recursion. */
             ret = domain_context_mapping_one(prev_dom, iommu, bus, devfn, pdev,
                                              DEVICE_DOMID(prev_dom, pdev),
@@ -1809,7 +1813,7 @@ static int domain_context_mapping(struct
 int domain_context_unmap_one(
     struct domain *domain,
     struct vtd_iommu *iommu,
-    uint8_t bus, uint8_t devfn, domid_t domid)
+    uint8_t bus, uint8_t devfn)
 {
     struct context_entry *context, *context_entries;
     u64 maddr;
@@ -1867,7 +1871,8 @@ int domain_context_unmap_one(
     unmap_vtd_domain_page(context_entries);
 
     if ( !iommu->drhd->segment && !rc )
-        rc = me_wifi_quirk(domain, bus, devfn, domid, 0, UNMAP_ME_PHANTOM_FUNC);
+        rc = me_wifi_quirk(domain, bus, devfn, DOMID_INVALID, 0,
+                           UNMAP_ME_PHANTOM_FUNC);
 
     if ( rc && !is_hardware_domain(domain) && domain != dom_io )
     {
@@ -1916,8 +1921,7 @@ static const struct acpi_drhd_unit *doma
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCIe: unmap %pp\n",
                    domain, &PCI_SBDF3(seg, bus, devfn));
-        ret = domain_context_unmap_one(domain, iommu, bus, devfn,
-                                       DEVICE_DOMID(domain, pdev));
+        ret = domain_context_unmap_one(domain, iommu, bus, devfn);
         if ( !ret && devfn == pdev->devfn && ats_device(pdev, drhd) > 0 )
             disable_ats_device(pdev);
 
@@ -1930,8 +1934,7 @@ static const struct acpi_drhd_unit *doma
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCI: unmap %pp\n",
                    domain, &PCI_SBDF3(seg, bus, devfn));
-        ret = domain_context_unmap_one(domain, iommu, bus, devfn,
-                                       DEVICE_DOMID(domain, pdev));
+        ret = domain_context_unmap_one(domain, iommu, bus, devfn);
         if ( ret )
             break;
 
@@ -1954,12 +1957,10 @@ static const struct acpi_drhd_unit *doma
             break;
         }
 
-        ret = domain_context_unmap_one(domain, iommu, tmp_bus, tmp_devfn,
-                                       DEVICE_DOMID(domain, pdev));
+        ret = domain_context_unmap_one(domain, iommu, tmp_bus, tmp_devfn);
         /* PCIe to PCI/PCIx bridge */
         if ( !ret && pdev_type(seg, tmp_bus, tmp_devfn) == DEV_TYPE_PCIe2PCI_BRIDGE )
-            ret = domain_context_unmap_one(domain, iommu, secbus, 0,
-                                           DEVICE_DOMID(domain, pdev));
+            ret = domain_context_unmap_one(domain, iommu, secbus, 0);
 
         break;
 
--- a/xen/drivers/passthrough/vtd/quirks.c
+++ b/xen/drivers/passthrough/vtd/quirks.c
@@ -427,7 +427,7 @@ static int __must_check map_me_phantom_f
                                         domid, pgd_maddr, mode);
     else
         rc = domain_context_unmap_one(domain, drhd->iommu, 0,
-                                      PCI_DEVFN(dev, 7), domid);
+                                      PCI_DEVFN(dev, 7));
 
     return rc;
 }



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:25:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:25:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299835.511061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4iu-0007Pg-HL; Wed, 06 Apr 2022 12:25:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299835.511061; Wed, 06 Apr 2022 12:25:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4iu-0007PZ-Ci; Wed, 06 Apr 2022 12:25:20 +0000
Received: by outflank-mailman (input) for mailman id 299835;
 Wed, 06 Apr 2022 12:25:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc4is-0006rC-Vl
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 12:25:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e85604b-b5a4-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 14:25:18 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-ACsCBD3NPZeQXg9i7mO7wA-1; Wed, 06 Apr 2022 14:25:16 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB9326.eurprd04.prod.outlook.com (2603:10a6:102:2b8::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Wed, 6 Apr
 2022 12:25:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 12:25:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e85604b-b5a4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649247917;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yucVFPGauWfslPNN5yRCj46l5cke1hJdmEdynBbWakE=;
	b=fBigQ/vT3qScunklYRDtF5ewnRpPycYqGqsRAPIA8Mf2AEBs33GygPj4IYNKg6MrGE31NC
	/mlvDjT2hRQA/A3cUFict7XS2k61IG2naEZxbJWgSKQVsUB7V1SK5YSzsiUEhAPy2IkkL3
	e+gZdbt2BTrGr2WmYUD1BCemNtoJb+0=
X-MC-Unique: ACsCBD3NPZeQXg9i7mO7wA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jFv+KzQxgT2zWYy9ZiL3EvQqHJ772/EolD1dyTuK56r7UTtdQdtmrZXN2p6mnVNXt9EbJh99Q/84ozMka8nVL7eXhKTUxmFFGv/7YScWKOvp0BxeG6ea2gvc17qDPJSHx2AXS30NBZUMbvqDUHuIu6+DFyjnwFDstaHNVhcaBT6ZVBZ1kNaNMSWp9w6ByMOKCo3ayRTK3sWWxYaVoStwIhp1B0sUWPeM2sBUHr561A2ZseSMKs/wL0ckuKxPpyyCV+yiw4iKjWVb/ONv6ZZMtyBYn9lFMnSIx0RmUQZY0Aj9uuQd7oNxAs0dFBEENWeJ01uc4l4hGH0fIi9jDhDIow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yucVFPGauWfslPNN5yRCj46l5cke1hJdmEdynBbWakE=;
 b=EYPTyFNgGSW5YNjn3w85cUAKqq7Mmob5yZelliLBaXXs+iMA8AJ1gcNjYE82EC48Yo0//5fqfEqW4GYvNS+TKmNhKtbfhDBIquZlwz91fY+qC1t1lx/APytnZOgxOzZMfksgHVtUFvp9AEIkfip5sOd8DcWoPaq4i7e58R/E0A/4DrJcmNTAoPdopFEudQhPVn73yA+Md0inYVRPXE0oa33Ob2ryNQvjnaP36fc9L67Wm02BLu0qMfFbhZFzLZWleQ+r1gSEQl/HNs+h1EEh3mT4N2it5fDhCy/i8/6gIo1tBw9TXSmd0XAxlot5qni3DrSgiE2s0EHgdX2c+Ugvog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <535d1050-e5e0-6e1f-5299-f41b84350ca0@suse.com>
Date: Wed, 6 Apr 2022 14:25:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: [PATCH 2/2] VT-d: avoid infinite recursion on
 domain_context_mapping_one() error path
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
In-Reply-To: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0052.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: df827b5f-471d-4421-4501-08da17c880cc
X-MS-TrafficTypeDiagnostic: PAXPR04MB9326:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB932644A55C4D42507AA6DCD5B3E79@PAXPR04MB9326.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ufQiu/Rmfahn2fzU4lxOg52qfJFCs2Nq/orOfSHgzXcLqLHg5B9PN9DVjRJWBH30J8JYxSxC3xvajAfOEaHB5OAjCmL/rxtUXGe1vKYBn3ppP/hkJCUjiCe0toBDfywzZM+v5BFlAI/pzFElqG1i6mp8G+S7eOyFAgehMoIyMLUboy1io3Z7ggSoIHlOeaMPpUziXVuWMKqyief1V1CdVQHt6GFsYziwmWYKbWx5REexllCahLAMM01xEqhmt7Bs95OAFxRovr5hw5xOUK+Q/dRUH/9AH4+2LCwf3cZLcjaKWXPNwbjtF869WtFjesIZOmADcSO7v5GZNJja4HXByI96zNtK7dy+iGM4S1OLJc+HvdeSCHyV1mT7IL8HtVF+4jzRcfXY5DYXqsZT5mGfzZTjbcBKZMUnsiB0/Qkzg2c1xCHHwtoTiXAW/s/k/1fiqywi6iF2vgic+r/8ahxzwDrhh0FqN1HQdmOWz+xl4B8yy8WHlb13y2glUqUpZt4XPiO4W5qvl7C5BS2nzQfMMeeN9upofU9OVbW34GiIgG47FaPkKXvygW6UeHn7obtbq7qOWnAIMGzpsy571Jq+uOZYSvGkwhXFP/ejyD0JUhvGHUXnjwPCFSv/yjllI1KKOLDMCYwFexsZQ0RNucpCYf7gGWswLIb5VHQULxYfCKmjC5Oy9t5YWAN239lrLxme/8WVHZiBhQmLB1b8tLach74sAptaXgKabPaqYgdaG/w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(26005)(316002)(2616005)(6506007)(6512007)(31686004)(36756003)(6486002)(54906003)(6916009)(508600001)(2906002)(31696002)(86362001)(66476007)(8676002)(4326008)(66556008)(66946007)(38100700002)(83380400001)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mm5UeW1XNmZqNGlJdEFTaTYwdnN2Rm1Mb0JudVh0SGtwRmVlL3lOelNEcUxm?=
 =?utf-8?B?dVRKdG9ieXFQQ1gzV29hR0xiVkVEd3ZrNm5ubWMrcUdveGlKYWNwZ2RXQlZK?=
 =?utf-8?B?N1dXSDJRTEwwZXBDUlhvTGhkeVozcnhNR3FsbXNTNVJrWGVsajVPOElrNjR3?=
 =?utf-8?B?Q0U5TnNpNzFuM1FPRUVVQUhIdWhydlByazdlWFBZMlV4enBIVTlndkgrRDBq?=
 =?utf-8?B?TlFzYXpJdmF1Nk1YRFcyMVlaTXhGUHpGWEdUS0JKZzFHTUc0Rk94Y1F0N3lw?=
 =?utf-8?B?N3RjdG9MRUUzWHViRjdPVkpGQmpyQmp0VldJZ3hBeG1aWFJHSnBBb01yeFl1?=
 =?utf-8?B?dzJGZDZtTm5hbk1tVGVURFRtZk9sc3VBTVBJcUtFVWI3MFVkMjZZM2VKTUc0?=
 =?utf-8?B?aXcybDNST2E5QmxsVFFUdUtIeUhiU3E5M3ZLY1FUWExIUHhtbjRqbjY2Y3FL?=
 =?utf-8?B?QW5jc01ES1lsTGxMbW8xSklFaWR4MTl2cWNVQnZlY2Y5ejNSdW9FL0J2SDM3?=
 =?utf-8?B?M1IxQ1dGR3ZBNnU5d0tibTlxbTJNaEg1d2lKVWZPb0RFdmNYVmRiYUlxM1Jo?=
 =?utf-8?B?aGFJL0toZHRVTThKWkZTZzhSQ0p5bW52L3g5Y0t3ZjlUbjIwMUVreURacDlh?=
 =?utf-8?B?TStwNFJ4QW01ZVQvdGY2RmZmeDduREdINklvUnErUUxYRGtFY3dSWTlMY29R?=
 =?utf-8?B?d1dNUXlqamlJcGlrNjFWU1JIajlYczF5NXZDZWtQcWNBTWx6dmxUWVpybVhC?=
 =?utf-8?B?dXI2YjZFem42YUtQMDQrL2ltSjQrSUdnUUQvbGpLQU5pUXZnbnE1eVNsVUlU?=
 =?utf-8?B?T1d6NlN6dTV3QkpIRXNYWWlhRTJaczcxbTlmWlhid2tMM1htOU9hVVFsMkpp?=
 =?utf-8?B?SzZSempuaTdYLzFlLzJrbFdCZzJtOVZiTW1BZGpvTUVJTE1VN3hPK3lkSGNN?=
 =?utf-8?B?RDR4dDJGRUZ6RmN4SjJrZTJZU2ZCcldnZVB3MXJKRHVQL1g3SEhCSkFId1lv?=
 =?utf-8?B?dnB5RHNwR0JJUXl4T3F3dG15SHNqb09qcE44SGd3NzJVRmZyaFJyTmJYbmpX?=
 =?utf-8?B?ME4vNVR2ejVORXpPUVJKL1JILy9keXQwMlVNYXdIc3N5eFVxQlVudXdaK1JT?=
 =?utf-8?B?bjBndzE1YXZUeGtUdHJQUVhXYU05NDNsOHFFM3ZKd2x6YTNnOFZUT2RpY2JH?=
 =?utf-8?B?WjllUFJlOVJJQ3lINUgzQ2VldGhnWWs5cktuNXpIS3R0b3RlZnl5T0orLytY?=
 =?utf-8?B?dXBQK1I2QksvZDVDMlJkQW5nL3g1ZWxhOEhJRVB4akpVUHI5Yi95L0J4TEpv?=
 =?utf-8?B?cVdmeTRKb01EcDMxd1V3OUU0TGpsS0JuUFdUTDZqTmhSbU1sQTUwdnRMREdh?=
 =?utf-8?B?c1BCSXdnUjdhQ20zelF2UklYR1pYRFZteUFsb1VwcERZOG1NMWRvbE0xTXBh?=
 =?utf-8?B?S0kyL0xLZUpwazZJeVpXUmIvR1RNR2FpbTJCKzZsUjhtUURzaFF6Q1ZhZm8v?=
 =?utf-8?B?ejhxdVJwOXh0RDZCWmdhWDYyMHpMaVprL1RDT1RTU3pzNFg2U3pUalY1Y01v?=
 =?utf-8?B?Um9kbzl3UjlQZjdiU1oxQk9wMzZlcHVKT0RBTWhrWWtPLzl5TnlyN3BrMVpO?=
 =?utf-8?B?aW1uRWZ2L2lZcXRpR0oyWHBDOFlkQTQvR3piZTFHeGhDUTVMUyszZ2pBc3du?=
 =?utf-8?B?UkUxK1VQc1F5anRMRVJJOWRuVHZEZlFHK290R2RNRVpOdzBKQWZNWDVGU1ZF?=
 =?utf-8?B?L2MxZEhYVitiaW5FczlLbXVZQzYxSE9TNisxV045YTdTWTY4V0Mzd2dlRXJT?=
 =?utf-8?B?SlpPOWo1ZVhNMDJ2S1p5RTRZL1h0dUdnWkJyTGtRN0RYaWVCczhwRkpFdE5J?=
 =?utf-8?B?Z05abGxKZFRySklPT0FCeE94RXJEektybkJoMGtuVnI5OURSY2FQUGhzWUJR?=
 =?utf-8?B?SDVkZjl5OFZidGQ0bzlzMmxZZm9COXdqVytHUGhueHJTRkpVYTJTRVY3WlR2?=
 =?utf-8?B?d2JCQ1RXenNqeTByS0piUXFsaWJ2RHN0eUhQWnN0emNaTlJUSkkxTTRYQkVP?=
 =?utf-8?B?ZkJQTlo3bHNJTjFkWWVuaGcwZVpOYlQvNjVsdDFydG1KYktuUjd1OHhyYkR4?=
 =?utf-8?B?cENoRjdIaWRDZGw0eVRIS0k4MUtPcHJRTnBSSVV1S3NmZWJHMlhJVmJkbUFt?=
 =?utf-8?B?SUtKVzNBdmxtcWgrUnZoRkRUZUZPV1oveGF6MTFyMHB4SG5jT2FvRis3RXhS?=
 =?utf-8?B?ZlhRRmlIbldoSkRrWUt5bmdid3h3alA0TkxHOG9ydysrVVJ4UVpHaXIvTU5W?=
 =?utf-8?B?cmxHMTUyWHRFUnBPOGUwT1J3d3pXWThYUmZTdjJDTGczaGUzNEFFZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df827b5f-471d-4421-4501-08da17c880cc
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 12:25:14.9520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kiiMlkMb5QFwaB+nof5EVBYYyffNxvpO7z5k5Vmjn6Yg4JdfxKjKVglODOveXgZ8S+db1UFdYE/boSbpGkR2aA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9326

Despite the comment there infinite recursion was still possible, by
flip-flopping between two domains. This is because prev_dom is derived
from the DID found in the context entry, which was already updated by
the time error recovery is invoked. Simply introduce yet another mode
flag to detect the situation and cancel further recursion attempts.

Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1608,11 +1608,13 @@ int domain_context_mapping_one(
               */
              (prev_dom == dom_io && !pdev) )
             ret = domain_context_unmap_one(domain, iommu, bus, devfn);
-        else if ( prev_dom != domain ) /* Avoid infinite recursion. */
+        /* Avoid infinite recursion. */
+        else if ( prev_dom != domain && !(mode & MAP_ERROR_RECOVERY) )
             ret = domain_context_mapping_one(prev_dom, iommu, bus, devfn, pdev,
                                              DEVICE_DOMID(prev_dom, pdev),
                                              DEVICE_PGTABLE(prev_dom, pdev),
-                                             mode & MAP_WITH_RMRR) < 0;
+                                             (mode & MAP_WITH_RMRR) |
+                                             MAP_ERROR_RECOVERY) < 0;
         else
             ret = 1;
 
--- a/xen/drivers/passthrough/vtd/vtd.h
+++ b/xen/drivers/passthrough/vtd/vtd.h
@@ -29,7 +29,8 @@
 #define MAP_WITH_RMRR         (1u << 0)
 #define MAP_OWNER_DYING       (1u << 1)
 #define MAP_SINGLE_DEVICE     (1u << 2)
-#define UNMAP_ME_PHANTOM_FUNC (1u << 3)
+#define MAP_ERROR_RECOVERY    (1u << 3)
+#define UNMAP_ME_PHANTOM_FUNC (1u << 4)
 
 /* Allow for both IOAPIC and IOSAPIC. */
 #define IO_xAPIC_route_entry IO_APIC_route_entry



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:32:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:32:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299842.511073 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4pZ-0000ee-D0; Wed, 06 Apr 2022 12:32:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299842.511073; Wed, 06 Apr 2022 12:32:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4pZ-0000eX-8A; Wed, 06 Apr 2022 12:32:13 +0000
Received: by outflank-mailman (input) for mailman id 299842;
 Wed, 06 Apr 2022 12:32:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4vzw=UQ=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nc4pY-0000eP-92
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 12:32:12 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94d5435e-b5a5-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 14:32:11 +0200 (CEST)
Received: by mail-lf1-x136.google.com with SMTP id m3so3780404lfj.11
 for <xen-devel@lists.xenproject.org>; Wed, 06 Apr 2022 05:32:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94d5435e-b5a5-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=seOkLjBsvBkN+jsUVXSFnkZHA1u0fzfaMNnmyD7lAeA=;
        b=gBDL+fKQebuO9JkmANB+9gcME6Ctk2MK3enrNYmRTFzHu/13ZOxVGgzfGCBMtrvSoI
         z0C9y3z2+Pc0YCLpYcvtb3bFTktB26KzR48S/91fhYTQKz7lFElaNnbIn8ws37bpENyO
         N2Aw72AByQutOe4O7M5biofLcBI8naUNZvNZuDmxOdTXA8kcioTJxE4HAXsZ74/s3Iu1
         NATV+mPaC19+LCU2yTYpXuRhfsUvhX9utpada1m8uxCJKZV98DXZ7KGjS4L9XnP1MWvs
         y4bWsyM2JPy8H4xKp2/MVG2kohCuCqm7ktVNp0ARXnJ5mW5rC0hvCTcWsG060OD/eOVb
         JcRQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=seOkLjBsvBkN+jsUVXSFnkZHA1u0fzfaMNnmyD7lAeA=;
        b=ow3x3oaZqS2nsVzHflnkGCGlvDnYLJvtdrOVwZ0FQg4VvZIqu9K2yyZ5c8HUHdzcuY
         HAM1n63DuosBzSNi+i0BUThhgxtIAYwFIXQ+27QjAIA6kf2JJt1tQbt5SfWKvQEWnHEo
         2mdKr3rOHdZTQQG9wEY6VnsdtGdss9yNMxQamhGEOisDMDI1DtzVKnzIJuHsis/aUvnx
         V8dDQLxExT2GLhjziB3GqJ6/NPQtIPI7/ZEf7uk8TVo+l6+zW5cIJe064NmTmorjQ3ae
         CRE9yls91YEqbFkiK4Xp2DjsvTiW5pDkXvnQLjN9nH7Z8rpWCqKUtFERiedaGD7jDlSk
         WNyg==
X-Gm-Message-State: AOAM530dWbO8Em1aF60MErY7JtlXZHlAiFC7wl9W7wtWBtL/ZN2XLKKo
	YgDfST0tJJUCyPfxEtILDtjW+ugZTcgJs6Shi+jWw/X/
X-Google-Smtp-Source: ABdhPJz/aOsg+VDdc1JI1Ma6/EZk3di/lqoseqdla+Z//CBgPq3a0iJsmrcMvTCVONXbL6WDv7nnoi02fyG4bjZqLxk=
X-Received: by 2002:a05:6512:11cc:b0:44a:5770:7425 with SMTP id
 h12-20020a05651211cc00b0044a57707425mr5613946lfr.406.1649248330780; Wed, 06
 Apr 2022 05:32:10 -0700 (PDT)
MIME-Version: 1.0
References: <20220330230549.26074-1-dpsmith@apertussolutions.com>
 <20220330230549.26074-2-dpsmith@apertussolutions.com> <CAKf6xpuA4hQmPdBtmog1UFcSQQkXL2=+e5bmqeocesgNxqD27w@mail.gmail.com>
 <1eaf4555-5221-6cef-6c01-6aea3797e521@apertussolutions.com>
 <CAKf6xpv0LrmAa2A=dXXK2DSRh0j8ac9VM4aLBhTRK0MtnML0Aw@mail.gmail.com> <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
In-Reply-To: <a4759948-d45c-df06-3130-f95aba05b555@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Wed, 6 Apr 2022 08:31:59 -0400
Message-ID: <CAKf6xpvRWcQEwL88YSMOmh=8K+TF0TD+GU9Y0s2P=t3-5f3KFg@mail.gmail.com>
Subject: Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Scott Davis <scott.davis@starlab.io>, 
	Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 6, 2022 at 3:07 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 05.04.2022 19:17, Jason Andryuk wrote:
> > On Mon, Apr 4, 2022 at 11:34 AM Daniel P. Smith <dpsmith@apertussolutions.com> wrote:
> >> On 3/31/22 09:16, Jason Andryuk wrote:
> >>> For the default policy, you could start by creating the system domains
> >>> as privileged and just have a single hook to drop privs.  Then you
> >>> don't have to worry about the "elevate" hook existing.  The patch 2
> >>> asserts could instead become the location of xsm_drop_privs calls to
> >>> have a clear demarcation point.  That expands the window with
> >>> privileges though.  It's a little simpler, but maybe you don't want
> >>> that.  However, it seems like you can only depriv once for the Flask
> >>> case since you want it to be one-way.
> >>
> >> This does simplify the solution and since today we cannot differentiate
> >> between hypervisor setup and hypervisor initiated domain construction
> >> contexts, it does not run counter to what I have proposed. As for flask,
> >> again I do not believe codifying a domain transition bound to a new XSM
> >> op is the appropriate approach.
> >
> > This hard coded domain transition does feel a little weird.  But it
> > seems like a natural consequence of trying to use Flask to
> > deprivilege.  I guess the transition could be behind a
> > dom0less/hyperlaunch Kconfig option.  I just don't see a way around it
> > in some fashion with Flask enforcing.
> >
> > Another idea: Flask could start in permissive and only transition to
> > enforcing at the deprivilege point.  Kinda gross, but it works without
> > needing a transition.
>
> I don't think that would be right. Logically such behavior ought to be
> mirrored to SILO, and I'll take that for the example for being the
> simpler model: Suppose an admin wants to disallow communication
> between DomU-s created by Xen. Such would want enforcing when creating
> those DomU-s, despite the creator (Xen) being all powerful. If the
> device tree information said something different (e.g. directing for
> an event channel to be established between two such DomU-s), this
> should be flagged as an error, not be silently permitted.

Yes, you are right.  As you say, you want the policy enforced when
creating the DomU-s.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:41:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:41:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299846.511083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4y5-0002Ci-7D; Wed, 06 Apr 2022 12:41:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299846.511083; Wed, 06 Apr 2022 12:41:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc4y5-0002Cb-3Q; Wed, 06 Apr 2022 12:41:01 +0000
Received: by outflank-mailman (input) for mailman id 299846;
 Wed, 06 Apr 2022 12:41:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc4y4-0002CV-62
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 12:41:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cf12782c-b5a6-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 14:40:58 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-o38sTySJO3q9nN48xkWhvA-1; Wed, 06 Apr 2022 14:40:56 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4605.eurprd04.prod.outlook.com (2603:10a6:803:65::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 12:40:53 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 12:40:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf12782c-b5a6-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649248858;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EFJzJVPs8Ijlo09XzUn8PVH4pRfF8PYsLrSlY6Oe5IU=;
	b=ZmYKIttEAI/8Q+gPcftdB9JK9HMUHPjgv7iqoNNkVGeWNqSSrE8/rgelnwmKseGhDPRR1W
	39xuY0TMwI1tAS0uBOuo2Hw25W87F2I2h4AAVRMRp1BuFyzaQ7brj7TP0YJ3HZ3zYx8Rb8
	BAZWjbgACoPx5thtMGHVKxxDh6l4It4=
X-MC-Unique: o38sTySJO3q9nN48xkWhvA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ez/F1CYqt7ugyUYmlpZohsQ3K3Rb80rbVkAOprtQ4ZEnEnd+G4LexEOJEUSLrzDS2wBOgz/ybMuZVhrMswzvVpAuhwEJ7kSLiiCYOGmXZy5N6cX3+Xr9tk7dj+1e4jpRQMNzkiieWuCNK/CulLyda5kL/DgWGn/a/Z9I3Fnkj3plFiFr6F9ldtnJ8ZgCNcAWEr0D2IMslcBYhY27/ItGck1tJTpdoOc3gVK+NquKUs6GGR3tPlg4E3JDkcJpY7DBpvBj9HjqsFwP9+xVhpik2rNBBGI6gRTfIViiw/vthCmESnaQXmsF+/wZx+Meg1SNdUd+Xq9yvaKGz66K0mUyPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y24sSMu6ZhudrtCdXDzRBAAbN9tYwKDDrju8+HNyFs0=;
 b=JpJH+699DFpJNYuqX1huJT36tMoEFTmtGdPsywuwPquYnaCIOGoa91l26W/H6TIvOtFZox30heTARmy726at173ILkxtP6dbqgoOiRthty3y6ASixb6kfpLJIr/pwLBhx4jsrk9cJQttcJKnJhJZ5eMHAETGZRgQw8Tp8Qq6hfsI2jjBXMZaReplzmFFkz0HQo3eM/BPBBCx5oBrGjaVRLZLeexSQh0ZTx8+ohZ+3UjyYq8eJ66UezQ3fUs+IPiBKNEHGwvOY+MZQmPATLvjFK0y+VQNrKAiT1+F56MzDs74RbBCdabyn+hoU/mfRF5xZ3TGzHHI2MBscQ0v6pfCLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c9186f2c-25a1-6d97-cac6-126bb32bd22b@suse.com>
Date: Wed, 6 Apr 2022 14:40:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
 <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
 <39640fec-de8d-0c5a-c9aa-daf83fb785b0@suse.com>
 <YkxkfbNpR7yfLP7W@Air-de-Roger>
 <17163e1a-6598-5949-47cc-eb9734bc69ac@suse.com>
 <Yk1erGso3rC68m/e@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk1erGso3rC68m/e@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0054.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 94166212-2db1-4cad-d210-08da17cab007
X-MS-TrafficTypeDiagnostic: VI1PR04MB4605:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB460587ACB00B86B0674F9539B3E79@VI1PR04MB4605.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mqR6+Ac0PzCbVVJybRzYQBC6aI/B1yaQ8VolgUXq07wl4UZYmOfAqIP/C9WSEWabelWsZ2SnFZ13p6rMCf0AgpVLsEtKl2rFmXNxMqQLgKnGTeQOKtZffcGZJQ8E6N1t2TJrdkFQnUubfHoP/j33i2N1UduLExIGkX9OXVgYmDa6iBfdi13DG1msOAgURtStcmJltuLQKJOlNndVXTVTIOKUL81suDkZ6VLW0tnbKzC1Dyia9Tp2sarBBzewbHm/0SIPT7rEjQP2js7wBx/A6aI4s9AwuYvvv8eVhkXSWfA2TVkPHUW5JwPishECewUQCmmULL7pP0Q9CmLdv88foGU3EngBXKhcKccj8sUaRFjUaERik0NUYXxmH9MNAe7tnaX2EXYppiCrUyCOmrYW+YjCB9df0GG/Urpy12jikpbRJzHzA8VIMHYTvAHikcFmT8t2CD7aapiWyTtqbjEUJYtrZlHqWPxNtVLObq06JZwImvuBP7Zlqe8UMTBM7NpHIMO3FNQlRRppHqCmBpWu6+cbVosDB+8cbEGQdYzgCsK13lNYspiGLV2I4tEA8EYzgBTdmVkMLB/7vS9jMrd9ae0gVvrm/eCPJ8m20qPBu2f4WjvTiF7Le2DuhobHAWnNOF2mOpK/HcQ8TvCxnfZ/SEC5FBtqRj6fqDBChyloW1yCEkb2xZTOZhZpnXBLVv7H6VTnjsNdiSUOVck29II8ebo3upORb2uiyvIPHsD6TsE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(2616005)(6486002)(53546011)(86362001)(2906002)(508600001)(38100700002)(31696002)(5660300002)(6506007)(6512007)(36756003)(186003)(83380400001)(26005)(6916009)(8676002)(316002)(66946007)(66476007)(4326008)(66556008)(31686004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?czKZ5XKmI3sfMwGOsFdP9Xz9koxYAWD+yKE7TcX6ajv+WdcJiYWXjA5XgNXM?=
 =?us-ascii?Q?GwktiH6+bWo0XKWSegiUR/VOAydxyPbVH8KEE6okRrZ8JDXR38t8FGMNNECa?=
 =?us-ascii?Q?5s9Cr78pu/nLHAkPcbj+kxUe96RGR5JipygCmPCzO46G09CuRoDPgFXRgSSh?=
 =?us-ascii?Q?UjxxWnCxeU29LmCQ3p7Qr694vpL9GC0g8XfD3GMGyAp+fgkeJ/4jKQABYdAn?=
 =?us-ascii?Q?eH+NSKofGop78om3aIf+h/X8jBqhFYW8TzK9+ZYaavPL/+Oi1RxK1Q+y66oT?=
 =?us-ascii?Q?1cY5eUbdfuR5LRdTATcqRBbabPySUzPcMYAjfOvkV9HMWFZ5c7U4RTuePAv4?=
 =?us-ascii?Q?87W0IMRC9zDMH8jegGLadYf1qY4dBfuyBph6fyIuS+0sd1LJiHs+8tIfntmw?=
 =?us-ascii?Q?77eFmDubGVRkOQe60Zu1R5Yo7pRUXAsyFTY1NFA4qDmk98zEYlcPz7paDM0E?=
 =?us-ascii?Q?f/G1WHMSa5SNa6dFQHRh2bUq1HiKv9ByCJromObTsoZoyHQ8ZM6HA50ZfDKp?=
 =?us-ascii?Q?mmxV6++Sfk0QFEb3Gnabg25/P5kKDzyUmJZA72TWne4HVW3ukG6NgdG8GHxF?=
 =?us-ascii?Q?ARACvA6rnjdquyK6iaGPW/2+1hMPqqrUeUOq93mPbB5UovgQDbgAuoPHl5my?=
 =?us-ascii?Q?+PVrqr5qCKJSrZOqkMTLakGhSWjC3rKvORJMDrZrBFcJhPe2dQBBrxr/lf6Q?=
 =?us-ascii?Q?aSmtr6SISClzrYT6RGhPbTxS5mWu9IT0/KNffPXTNWI25ywt/5jtFu+8VtzZ?=
 =?us-ascii?Q?3i2kEi1Mk1gceohUX8q2XxIxAUtHuOF5g3OBWY1zSKVbLWIgzVU/yycL+VVH?=
 =?us-ascii?Q?0kLlacdoy07rEcmv+czw4Oy/DpnOe1SdLZUfLBQpH2XdXt5wt9wvRNAL6yO/?=
 =?us-ascii?Q?AieNfqGQtAJUMTY+j5nWjxorgUcdG+deoN/ZC4fHVVwYJiM/u+x0VFMoHRuJ?=
 =?us-ascii?Q?AOXKLfWUZGR1KCs/HbA+UZijig1P1WGKjN3g6z79vuMdcqMtn5aJzKdgLQVG?=
 =?us-ascii?Q?iWpbSKCiemba3Q9QHGSnb0OfbnpUroRmW8jhc0Hjd4RPqRZLdbjEULsSOYxW?=
 =?us-ascii?Q?pl16iwN9SXAz9LroIIyttduwZncs/E9ljQvnOta3wM0QJA+hJS64F90DOxF9?=
 =?us-ascii?Q?sZShuftBKy5wJfSuPErbIYNQHhe9pH/xbrgDz82DYjW6Syp11eTTfTSi5jcZ?=
 =?us-ascii?Q?nT2zeNGjCxKwh1C08Ls3V+O50ONtVvRxOp8JhnyHy67XFEIYQYnp7LqmXDdC?=
 =?us-ascii?Q?9LzfNJjrO/3zJOTkUCNA2lCEPRQZVOJKK18uN0pdLqaSHfg7L2NHRUyZKhDq?=
 =?us-ascii?Q?RgflSd2opwdmi8aR09tCqPu4L7OSIsLxqYU1Hfi4yclpWKe+McdYI/ru7HL1?=
 =?us-ascii?Q?cdNeuk0Zj+8obaqkcZZ51etiMV7Ocr8ORGUO0fnFMlWFJpbieLsSAL/NyGVr?=
 =?us-ascii?Q?Cu4wE2AmL/Xb58H5NBJFWFSeAWRhXyHGfWcw/22IO+cYiPDyRLih8s2KNSF8?=
 =?us-ascii?Q?lyzRflrC9cCateV/HwdKlHLqiVGvOQtN4ktg36AEkcnmSkerg8SBPHeG19ek?=
 =?us-ascii?Q?ysj429xuKdQcmDMERTYZcA5WXOjoElDJDlXW6rSbJK2rSlhaRn8KBnI4LAZZ?=
 =?us-ascii?Q?/Por+4I2dc21TOdi9J8wlaHvPV7CN3eDXD4zQmrkcL2W43JoqWn4SgsoBBXi?=
 =?us-ascii?Q?p+mOT8E8XVtRvdHqmV5/9soIISE2pQsscAyk3cjKSjR6FSbfEBxxWySQxgVq?=
 =?us-ascii?Q?Fd3TXo6+fQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94166212-2db1-4cad-d210-08da17cab007
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 12:40:53.3449
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LXqqoPsrfNDGo4b1gy2YKDdBNwXkeNEv3KZPNATdlKzFaFtogGOkWrsy7dNlF6Q5b92yHEbJ4a7DyZlE/93fBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4605

On 06.04.2022 11:34, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 10:44:12AM +0200, Jan Beulich wrote:
>> On 05.04.2022 17:47, Roger Pau Monn=C3=A9 wrote:
>>> On Tue, Apr 05, 2022 at 04:36:53PM +0200, Jan Beulich wrote:
>>>> On 05.04.2022 12:27, Roger Pau Monn=C3=A9 wrote:
>>>>> On Thu, Mar 31, 2022 at 11:45:36AM +0200, Jan Beulich wrote:
>>>>>> +    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
>>>>>> +    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
>>>>>> +    EFI_STATUS status;
>>>>>> +
>>>>>> +    status =3D efi_bs->OpenProtocol(gop_handle, &active_guid,
>>>>>> +                                  (void **)&active_edid, efi_ih, NU=
LL,
>>>>>> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
>>>>>> +    if ( status =3D=3D EFI_SUCCESS &&
>>>>>> +         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
>>>>>> +        return;
>>>>>
>>>>> Isn't it enough to just call EFI_EDID_ACTIVE_PROTOCOL_GUID?
>>>>>
>>>>> From my reading of the UEFI spec this will either return
>>>>> EFI_EDID_OVERRIDE_PROTOCOL_GUID or EFI_EDID_DISCOVERED_PROTOCOL_GUID.
>>>>> If EFI_EDID_OVERRIDE_PROTOCOL is set it must be used, and hence
>>>>> falling back to EFI_EDID_DISCOVERED_PROTOCOL_GUID if
>>>>> EFI_EDID_ACTIVE_PROTOCOL_GUID cannot be parsed would likely mean
>>>>> ignoring EFI_EDID_OVERRIDE_PROTOCOL?
>>>>
>>>> That's the theory. As per one of the post-commit-message remarks I had
>>>> looked at what GrUB does, and I decided to follow its behavior in this
>>>> regard, assuming they do what they do to work around quirks. As said
>>>> in the remark, I didn't want to go as far as also cloning their use of
>>>> the undocumented (afaik) "agp-internal-edid" variable.
>>
>> Actually it's a little different, as I realized while re-checking in
>> order to reply to your request below. While GrUB looks to use this
>> only "just in case", our use is actually to also cope with failure
>> in copy_edid(): In case the overridden EDID doesn't match the size
>> constraint (which is more strict than GrUB's), we would retry with
>> the "discovered" one in the hope that its size is okay.
>=20
> Hm, the specification states in EFI_EDID_OVERRIDE_PROTOCOL.GetEdid that:
>=20
> "Returns EDID values and attributes that the Video BIOS must use"

I'm tempted to say "We're not the Video BIOS." ;-)

> And since EFI_EDID_ACTIVE_PROTOCOL will return
> EFI_EDID_OVERRIDE_PROTOCOL if present it makes me wonder whether it's
> fine to resort to EFI_EDID_DISCOVERED_PROTOCOL if the problem is not
> the call itself failing, but Xen failing to parse the result (because
> of the usage of must in the sentence).
>=20
> I think it's fine to resort to EFI_EDID_DISCOVERED_PROTOCOL if
> EFI_EDID_ACTIVE_PROTOCOL fails, but it's likely not if the call
> succeeds but it's Xen the one failing to parse the result.
>=20
>>> Could you add this as a comment here? So it's not lost on commit as
>>> being just a post-commit log remark.
>>
>> As a result I'm unsure of the value of a comment here going beyond
>> what the comment in copy_edid() already says. For now I've added
>>
>>     /*
>>      * In case an override is in place which doesn't fit copy_edid(), al=
so try
>>      * obtaining the discovered EDID in the hope that it's better than n=
othing.
>>      */
>=20
> I think the comment is fine, but as mentioned above I wonder whether
> by failing to parse the EDID from EFI_EDID_ACTIVE_PROTOCOL and
> resorting to EFI_EDID_DISCOVERED_PROTOCOL we could be screwing the
> system more than by simply failing to get video output, hence I
> think a more conservative approach might be to just use
> EFI_EDID_DISCOVERED_PROTOCOL if EFI_EDID_ACTIVE_PROTOCOL fails.
>=20
> As with firmware, this should mostly mimic what others do in order to
> be on the safe side, so if GrUB does so we should likely follow suit.

But they're careless in other ways; I don't want to mimic that. I would
assume (or at least hope) that a discovered EDID still fits the system,
perhaps not as optimally as a subsequently installed override. But then
I also lack sufficient knowledge on all aspects which EDID may be
relevant for, so it's all guesswork anyway afaic.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:47:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:47:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299850.511094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc54e-0002rE-Ul; Wed, 06 Apr 2022 12:47:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299850.511094; Wed, 06 Apr 2022 12:47:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc54e-0002r7-Qm; Wed, 06 Apr 2022 12:47:48 +0000
Received: by outflank-mailman (input) for mailman id 299850;
 Wed, 06 Apr 2022 12:47:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc54d-0002r1-K2
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 12:47:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2256f51-b5a7-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 14:47:46 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-JbyS8qjFNdyyT1lPzYOEtQ-1; Wed, 06 Apr 2022 14:47:42 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB7916.eurprd04.prod.outlook.com (2603:10a6:10:1ec::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 12:47:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 12:47:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2256f51-b5a7-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649249266;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DjRgFaDObSE/IXkSK7wEe5oFmwMpv5E9wi0+3bKzsG0=;
	b=ZzYPL5zyIWaBYKRYFYHX8wEuIv2CLKWT8/W0HSNSt3u10wLnEfvC8KGhOfh6IBEm7ahFiI
	9vb//30ex8TXh3xqYFrUZHhrHHrZCXRjxU3WpHNNweDsT21iYVIBRKkAILFlYcrHVIksIC
	x7VvvjgBjeBKCTVwRCnFPV7+jqtFSbc=
X-MC-Unique: JbyS8qjFNdyyT1lPzYOEtQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mc6ym7VEiGi3YVls5D6YJLBQX2MkFSmu7sL1wXDpfu9QJfCIwn1wITxgv8Y536G61UADReolWZYQyjcn62u3G9/wEq9BIe1sKWSBq9N1jWZbRy8VR4F+/1Q8yAbQTleQIDdcmgWFdCX/Z6aV85cecAh3n6o++YwHlCbgVl5HpO15YzP20SvfBTHmc3/YnkF5vN91TMTFpSuyer/zD12J5ftvzmwj0oGUP/sXQ7FMy9E+Cu6z5bufpmwA2UlWad+RDBCv6+Y9yLnY5HEyLks3XIBjzcY+kCEfCvnoLjiM4HlexAzWvGzXKVju1OfFIewsYuTH4dpTSR+wSu2U6lJdCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UWs+ei9QE7A9GeTJzx0157FB4uq+nJW9jftA2Flfz+o=;
 b=BLzOWZc1FpKoFRcPy6uTpUr7fMIa7+ltf7ytup4xnUNKveDWmD/OWN5oH1fPvDjlPA7QBtVL0fjS+aMtlLpKe0+wvpEZ19wxdfDdATLTEcPYwR5J8lnDFdPmuO3llo6YvVsvys/cxwM+6k4Yy5T1HjqAvN89yjSy5Aya4GxXemiVNuA3drxDw3Gw4sKRhSN6tUY6xKsTkraIprhueNCHKWfuDccH4Hl8laN7kHYtQBqvB20PwahAS4r5XUf6OS8PNLWCqHnXGFqpULD/TwQOAjhCmA2vqxiALBhTjQekqGLxQSr7JIfgzA5SrRSSdUDGdl0Fyu4hqje2IPHwspmw8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <333e5dad-5a8d-a8b5-99b5-5d349c784b88@suse.com>
Date: Wed, 6 Apr 2022 14:47:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: Questions about Cx and Px state uploading from dom0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <YjrgQOYbsaYOV08H@Air-de-Roger>
 <6a029529-fcbe-3923-26a6-58a58926762f@suse.com>
 <Yk1tvf7oqOf3jySX@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk1tvf7oqOf3jySX@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::9) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: db58bb59-a3c0-4f2f-31bd-08da17cba312
X-MS-TrafficTypeDiagnostic: DBBPR04MB7916:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7916E1472F6808EB3EC4899EB3E79@DBBPR04MB7916.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ycBkWMBR7nmLPurHZEx97InpkzBE2vmyRmR6+7nJKrrFJty3gIhVyzkSz6jBfcbdVvdxMBi9Qtf9HZJX0c8BcmuhUYGiQ6SE+mA+kxuh5ywHwb45dXFfj/wN4O+6toxiu/TLOhC9oxxW4+RKQFLvEFLXJ8Vp+y/vc8myEXgdOOcix6r4ApKL1yBJiXT9UoX84O3CrpL6EGUhUCLu0AJY2xXCok/9sbwDpUYDeMZAX+rqjGKfKp20cvwpjIX+TgBKJEP5hW3O55NsuP891uNiJKH5KktoKX1Kd3bxkVQUIrD69gtyuOfAkiejXy9LSk2wRkKRn2bFH78/2SuslKf122UQMKH3Mumbx/SVtbtkZhop77yfRNLcDEDEICGhyFBlGQiDNR/Rl1wrld9vhh3k6MtmWc/MaRD5w/FIaPM8NXCsvPzbpvDXVeqzwy6h7NEbYKGkarImXA2+xPa6l1pPg+t+FYlNx6H7Zl+YOrYtOJj50OYOSffp5DRhF65jKCpv1jEz7iN8ssZgahFCQ8KiFxow/jgw3uljcE5ErkPlcE5keSjI/iLASZmnd30c7uhQctLSlrd0+dSBb32em8W1WPMY9dIDNOEQWgVkkWzLKW/cw4rVL1H3BC+UTuEbjp2xwh50SPmkcJhga3aHV2M+bzuAU+kxHIctbvcZn7h0HKc53BYzKBM0zQm2AhD5QBXdDvfDBQQ6hJ6u3iCFPX1qsii/+V8XhrXLlsPKfsjT3Uk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(186003)(26005)(66556008)(2906002)(66476007)(66946007)(6916009)(4326008)(53546011)(38100700002)(83380400001)(316002)(8676002)(6666004)(6512007)(31696002)(86362001)(508600001)(8936002)(6486002)(6506007)(5660300002)(31686004)(2616005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LtgQU6P3XaEJTMqK/lAlBlSUOGKE8aRKzE7iQFHSzl++LYQcLpDZk5Qp04/T?=
 =?us-ascii?Q?Q6j845wvkSc75DCDI7CohvNUl+JCvXlhx+6rEFZpxUlO40sG0bU5EzHK18KR?=
 =?us-ascii?Q?1yfYEC+QGuaVouKvS4qY5TIUnw3tid1amAVBPA5Ab8m+S+GBS9vtrq4vpz5C?=
 =?us-ascii?Q?VNFXyGKDMccfarwfffrkfzkLFMhZtmVS0WIq544PsSNIawTwAKowjLpGYwgP?=
 =?us-ascii?Q?49qXon5HRlAVpOmwSj0CE/J31P3u5c4d1cnI9dPr6AeepWBjReFzM5nEdJYd?=
 =?us-ascii?Q?2ti8OjZGYNe8CIhNaHH5aW/09hcTkZEdpEnnZ1wRO4YE+ZHuz8zfQVvlRZWg?=
 =?us-ascii?Q?ZGEnuQBdqulphWRuRhASTRIi6PmZbCrfX3hCBygilVrbjw4bH90hoF/454SY?=
 =?us-ascii?Q?6X08VoJJTlVoJ5vurmrozXjmrxxEX0RgxIREKEIzzHbQEn4k+sWiXs641LbI?=
 =?us-ascii?Q?3gT/jrpJ/hGsGUykQyFgyUN8acXPkboFYKepWB2ME6RcdDKNj4A1YSxuwK/2?=
 =?us-ascii?Q?kPEu92ZogOhqYMwk6JZB3z9hop94cCS2cSGycSoPNxvBSCx2nkYDAv2v5/Q5?=
 =?us-ascii?Q?IMpADy6dKMpVoYku0gpavbwrrLCMTGAL3vZIerKyRItwgXCcLpD7w8Bf/Zo9?=
 =?us-ascii?Q?VReT6ZfdvkmgmKfJyfDzG37OHUqaE1iHqNFOI6xJGdBjX+eFnHfLVpfPzAUa?=
 =?us-ascii?Q?NKhyB3voAh17PzR3C67/0L/u/sFdB85JpYmjqRVgzhmlAMBYOxOI/szzKK4u?=
 =?us-ascii?Q?akxjMHa/sLz6MdWqqrSTpMo4qy+JSVAmbG9td/m5GICHsS/wXffX53aFr5ws?=
 =?us-ascii?Q?0n5zzrS9w5zJGIcJBWLRD8S3DWS7ivsK3d52csNtwx2iDGMDtlfrIegWZbL/?=
 =?us-ascii?Q?RKnp892Sxzi9NZftIzohX4xdDz3DTH8vRMwiyysoWajYkJ7wNwa2g6q1sBuf?=
 =?us-ascii?Q?Xk/mkgFyrVh5Mj0Sh5/dBvH7O+hXfMVG84t0KHaNHXaKYW6mWiTU6OMegGFp?=
 =?us-ascii?Q?VMSNAduwEeAKMLq+zRT/YtkBDIC8rXu2YpxgQcSSEBAZySVYszJivaTV96PR?=
 =?us-ascii?Q?gEl8wtZPEl3OU9tb6EDUfEB+nvVIws7/F419U4cNQtkTVcFqZfAWZfV81qZm?=
 =?us-ascii?Q?eM15w/8sy4xivyzKDWywrXkvU80S3VRI4A3TIlKVzrfV1UVmR121WpoMjYqO?=
 =?us-ascii?Q?gk+LlGMDWzuPHVHhlq+ADFH7LYDOFJ/WjGdO2sEr8rbZFLcDuapcWcd+ktVr?=
 =?us-ascii?Q?f47Pp9iE7FEnjmfh6gPSCw8qT80vuM7t3JxBp/H9bg9S/wBS1oVqurplo/+A?=
 =?us-ascii?Q?riDWiul58KlQQqRraLuR9XFV2Gj61SYWxQfVNWCrTOjKfFLT4NU4YLzmXIoc?=
 =?us-ascii?Q?+Hg692R3WxrvPyKFKErck3fdtgJHwXJTDtOkvoN9f1AwrBSQ/RFnNmcQctCq?=
 =?us-ascii?Q?J29N/uMXP9mcAMJ66ChzBlpwZKl0nI6Bwjd62sJZXJEsb/OUaTvzXWe1Pzuk?=
 =?us-ascii?Q?1MZAowMYe9QcDp41+US1hbcT/EElZqEu+6P+yx+OfdbiOqpSNkeTFkcF0svI?=
 =?us-ascii?Q?FY9tEUNfr2SF5fsmMSMF+9zTsXdjbph8cRkPKZUKdLVpRM55O1+hhy/WgvO9?=
 =?us-ascii?Q?sdE9ErFWd8SkBVpUMSA+NrxuqDjSGhN/MPuR4rzBSbCz1GMRUoGu7zdIWZs7?=
 =?us-ascii?Q?BCEfSG08hjBMFhtdFE9S16Jo8Agmr6elz98rHh3DfqEFfVp3eCTMMIMLvejI?=
 =?us-ascii?Q?itS4DCZJuQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db58bb59-a3c0-4f2f-31bd-08da17cba312
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 12:47:40.9899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U4kcgmca4fIlF3S1fwgE+VQ5rtDICNrRKtOGBqAHoFyG9HLj5Jc7+6txvOGXVZtTjK6kL8TlngFwhtefzFPWwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7916

On 06.04.2022 12:38, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 10:13:41AM +0200, Jan Beulich wrote:
>> On 23.03.2022 09:54, Roger Pau Monn=C3=A9 wrote:
>>> Hello,
>>>
>>> I was looking at implementing ACPI Cx and Px state uploading from
>>> FreeBSD dom0, as my main test box is considerably slower without Xen
>>> knowing about the Px states.  That has raised a couple of questions.
>>>
>>> 1. How to figure out what features to report available by OSPM when
>>> calling the _PDC (or _OSC) ACPI method.  I'm confused by the usage of
>>> this from Linux: it seems to be used to detect mwait support in
>>> xen_check_mwait but not when calling _PDC (ie: in
>>> acpi_processor_set_pdc).  I'm also not sure what the hypercall expects
>>> the caller to provide.  Should buf[2] be set to all the possible
>>> features supported by the OS and Xen will trim those as required?
>>
>> I'm afraid upstream Linux doesn't quite use this as originally
>> intended. Consulting my most recent (but meanwhile quite old) forward
>> port tree of XenoLinux that I still have readily available, I find in
>> drivers/acpi/processor_pdc.c:
>>
>> static acpi_status
>> acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc=
_in)
>> {
>> 	acpi_status status =3D AE_OK;
>>
>> #ifndef CONFIG_XEN
>> 	if (boot_option_idle_override =3D=3D IDLE_NOMWAIT) {
>> 		/*
>> 		 * If mwait is disabled for CPU C-states, the C2C3_FFH access
>> 		 * mode will be disabled in the parameter of _PDC object.
>> 		 * Of course C1_FFH access mode will also be disabled.
>> 		 */
>> #else
>> 	{
>> 		struct xen_platform_op op;
>> #endif
>> 		union acpi_object *obj;
>> 		u32 *buffer =3D NULL;
>>
>> 		obj =3D pdc_in->pointer;
>> 		buffer =3D (u32 *)(obj->buffer.pointer);
>> #ifndef CONFIG_XEN
>> 		buffer[2] &=3D ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
>> #else
>> 		op.cmd =3D XENPF_set_processor_pminfo;
>> 		op.u.set_pminfo.id =3D -1;
>> 		op.u.set_pminfo.type =3D XEN_PM_PDC;
>> 		set_xen_guest_handle(op.u.set_pminfo.u.pdc, buffer);
>> 		VOID(HYPERVISOR_platform_op(&op));
>> #endif
>> 	}
>> 	status =3D acpi_evaluate_object(handle, "_PDC", pdc_in, NULL);
>>
>> 	if (ACPI_FAILURE(status))
>> 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>> 		    "Could not evaluate _PDC, using legacy perf. control.\n"));
>>
>> 	return status;
>> }
>>
>> (This is a 4.4-based tree, for reference.)
>>
>> IOW the buffer is passed to Xen for massaging before invoking _PDC.
>=20
> Indeed.  I'm however confused by what should be pre-filled into the
> buffer by the OS.  _PDC is about the processor driver power management
> support, and none of this power management is done by the OS (I don't
> plan to let FreeBSD do CPU power management when running as hardware
> domain), so IMO passing an empty buffer and letting Xen fill it is the
> correct thing to do, at least for the use-case in FreeBSD.

I don't think that would work: Xen doesn't "fill in" the buffer, but
merely alters individual bits. The buffer really is IN/OUT here for
Xen.

>>> 2. When uploading Px states, what's the meaning of the shared_type
>>> field in xen_processor_performance?  I've looked at the usage of the
>>> field by Xen, and first of all it seems to be a layering violation
>>> because the values set in the field (CPUFREQ_SHARED_TYPE_*) are not
>>> exposed as part of the public interface.  This all works for Linux
>>> because the same values are used by Xen and the Linux kernel.
>>
>> Well, yes - that's the way code was written back at the time when
>> cpufreq support was introduced. It should rather have been
>> DOMAIN_COORD_TYPE_* to be used in the interface, which Linux
>> translates to CPUFREQ_SHARED_TYPE_*.
>=20
> I will send a patch to add those to the public headers.
>=20
>>> Secondly, this is not part of the data fetched from ACPI AFAICT, so
>>> I'm unsure how the value should be calculated.  I also wonder whether
>>> this couldn't be done by Xen itself from the uploaded Px data (but
>>> without knowing exactly how the value should be calculated it's hard
>>> to tell).
>>
>> As per above - while it's not fetched from ACPI directly, there
>> looks to be a direct translation from what ACPI provides (see
>> acpi_processor_preregister_performance()).
>=20
> Yes, the translation from DOMAIN_COORD_TYPE_ to CPUFREQ_SHARED_TYPE_
> is not a problem.
>=20
> My concern is that there's some logic in Linux to assert the
> correctness of the provided data in ACPI, checking the match of the
> domain and the coordination type between all the processor objects as
> part of setting the field.
>=20
> I see that Xen also does some checks on the uploaded data in
> cpufreq_add_cpu, so I wonder if I can get away with just setting the
> shared_type field based on the coord_type of the current processor
> object, without having to cross check it's coherent with the values on
> other processors.

I guess you'll get away as long as you don't hit systems with flawed
firmware. Whether the amount of checking Xen does is sufficient
depends on particular flaws found in the wild (which I lack knowledge
of).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:55:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:55:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299855.511105 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5CM-0004Sm-Pu; Wed, 06 Apr 2022 12:55:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299855.511105; Wed, 06 Apr 2022 12:55:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5CM-0004Sf-MR; Wed, 06 Apr 2022 12:55:46 +0000
Received: by outflank-mailman (input) for mailman id 299855;
 Wed, 06 Apr 2022 12:55:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc5CK-0004SV-Nk; Wed, 06 Apr 2022 12:55:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc5CK-0004C4-KF; Wed, 06 Apr 2022 12:55:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc5CK-0007zN-4l; Wed, 06 Apr 2022 12:55:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nc5CK-0001yj-2t; Wed, 06 Apr 2022 12:55:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=d9teBWEerpgPDeFeU5aplcZnC052uMykfIEz5p+vgjM=; b=vbsoumHeWrHFWAa1kcAknaFSa1
	p2twg6NuRb7X7Fy73Vkyf/fxERtlhmT50Jlfx0FevjakqIr8kAxA+Kyu1ahmvrX2d+IO4G/K8oJ88
	BbwRPTp+5oaXOM1VHuEIn6d7mMPDWUICZ/aJNSKhoE2Y2X0OBQ1T1W3VovYMIeXE2opo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169184-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.12-testing test] 169184: regressions - FAIL
X-Osstest-Failures:
    xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    xen-4.12-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c633ec9451e76015c409bd5119ffcb0f2e61fe8b
X-Osstest-Versions-That:
    xen=944afa38d9339a67f0164d07fb7ac8a54e9a4c60
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 12:55:44 +0000

flight 169184 xen-4.12-testing real [real]
flight 169197 xen-4.12-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169184/
http://logs.test-lab.xenproject.org/osstest/logs/169197/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 168480

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd      12 debian-di-install   fail pass in 169197-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qcow2    19 guest-localmigrate/x10  fail blocked in 168480
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 169197 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 169197 never pass
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168480
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168480
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168480
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168480
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168480
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168480
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168480
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168480
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168480
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168480
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168480
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168480
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  c633ec9451e76015c409bd5119ffcb0f2e61fe8b
baseline version:
 xen                  944afa38d9339a67f0164d07fb7ac8a54e9a4c60

Last test of basis   168480  2022-03-08 18:07:22 Z   28 days
Testing same since   169184  2022-04-05 14:06:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 375 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:56:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:56:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299862.511116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5DQ-00050V-5R; Wed, 06 Apr 2022 12:56:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299862.511116; Wed, 06 Apr 2022 12:56:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5DQ-00050O-1o; Wed, 06 Apr 2022 12:56:52 +0000
Received: by outflank-mailman (input) for mailman id 299862;
 Wed, 06 Apr 2022 12:56:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc5DO-0004mu-M2
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 12:56:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06066c50-b5a9-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 14:56:49 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-KCe3q4fLPc27D_uWnphhKQ-1; Wed, 06 Apr 2022 14:56:48 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:5c::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 12:56:46 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 12:56:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06066c50-b5a9-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649249809;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oLkZDsAwAZkFeGlkbrVjRJB9bEjwOf8d9cZYowO6s/0=;
	b=SAzEa0en4CeZTi88woBoQjdCUepGyFrBUx3KDuVQAFuczA14CM/y9EesuoOhpbCy7k7kgi
	q/nOo7Qf51Cn25dqCHEFQfw4DMgWEmewqyDwC2fTtnOeGVv1s04Lrw/gJs4R7JeWFHLhG6
	gupeK0yVFL/pEqXtIJ1UXOxO8vU4atw=
X-MC-Unique: KCe3q4fLPc27D_uWnphhKQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CTk9up4YJVFKwCqMWECxrYkoEfR/8hdF5/GBSqopwxegMNK0a4zbqZTjAKJ7xv3W+oFbuNkGiwCsKPDvWmpxrA7wMu4K6GfyoFXJkgECEmHbXVsJPGme20WcqAJw8A//ZLt3vk+/vdrM4bEdFrCIK8mVK+EvY5UDmKC5OberOw4rT0G5LkMWIhHoGX8dzcKkUj10oUX1hcmaeoGmX8DmK15XRRZY9CphR0y/3c2UcHJyLcXHX6Vtw+AnXcjMvOYNE2WrnA6K0emnZMgqIDlJkBz2qtxEEg51KJ+RRllGedEJuCTj/7vLXWmmpvCI6oPDrMKHWU8sOPyeneiS1ifBig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oLkZDsAwAZkFeGlkbrVjRJB9bEjwOf8d9cZYowO6s/0=;
 b=Bo+x6oxmSF3yoPBRhSqLBIgNU2LiHsNhTN53XnytulbSAh/rUaMkidq+lawnOqY076Vq9OLWF0UQKtfIttZPtIWQFQj66tttv01ZWuvKVL+3E1yBXdRyuNFLSS7BDN21cL+K6a3mWBUbKWqJu1xBjhdwCp17CRtcrQIVTTR/1EaPz2B5YbcUnXKe8AiXzIS+umDmSnKmeN+AW03J6eq10u9oDKKdrgT8USsrshi3A7QrMEyMRoskw3W65wQXzFBVjIWaULCb0EbBuA7S1ksPwci0gt2IGA2jMy6kfuubaQlOvq0T1jsDVKz8VCjqu6O6P2ybMu6scFcHxW0vzGZUlw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6aa3e42b-e8a8-c925-8f2d-0bc681d842cd@suse.com>
Date: Wed, 6 Apr 2022 14:56:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v9 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: Jane Malalane <jane.malalane@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-2-jane.malalane@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220401104713.22291-2-jane.malalane@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0003.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ef62dd0e-4c01-4001-ac7e-08da17cce777
X-MS-TrafficTypeDiagnostic: VI1PR04MB5327:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5327282372378D334514D71EB3E79@VI1PR04MB5327.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MsdPEn7YywDoaF3LjY3b2aYvHXGXNK3ps2hzwORZSxOCp7HVHC+fdMYTjE/KztU2V9wH6qtO7vnD7jD6yhpEnvw2KjR8OpnM7qQrPM2tbIYgGqcPORz2i//UJ0GTk1rbiJvtrwgoZY66cOVWIBd1ap8SAq92VK8sT8S9TJO/IjHR9M96E8BJjmlooZh8LXAWeEQaPbJI91hUCoxxDlsIUqXB8OoJq/SH2Os4z7DCU67f8+19puL8YBWMefRzyd/jgEqsvtt4SJGdSPNoqUDS5YW3tyabS8ULmJCc7VwPvQWyc7oda90dAjgA6ejEjS9l1DX5ZaWs3Ko22tQnaZ07XHxJcy/pVWhzyjxDRPkTtR3gTXi5OhCmkPyj/JS3NJfEOsYKbOcr9/rtkJvFPJ4RXUTRkh4O5BTqEGQBGB2fYHDqUpRecwIwyWGbcrzu/SDyMjjE30eIOYyraJ0yh4n5+4GhuoCXcC644LjfKkeprdhU5sBlxAa4DVRq/r5tF1GQSrapfx5OP54zhcZ8dJlZNPCspL3P5E6aNVR/jVapOxpln0Cw9G9f0r5yyEWPdxDQx6Qh2DAIQvMu3VQL++oVWaw70DF+Wxhzan3fnlDLOQ3Od0D/tBktJI8x63jRLqOdNQeMXT77kHVw93XnNZXoDGYEXgJxXymz160flfdS3YSaj92sbo7WLcz0SgxJ/W2+IH9VzIl9fTlwg04FC3Ox47Ltlq0ksaMRPRaKxcGQVcU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(66946007)(6506007)(6666004)(8676002)(66476007)(6512007)(66556008)(6486002)(83380400001)(54906003)(316002)(86362001)(53546011)(6916009)(31696002)(4326008)(38100700002)(7416002)(36756003)(31686004)(26005)(186003)(8936002)(5660300002)(2906002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UGZMWnFkNW5FYVpaOFVtMnMyR1pXaHBJeDNyYkZrb1kzM1dvSk5aWnNaQWRT?=
 =?utf-8?B?VjJzcU4yU0ZxakpZYi9kYlI5ZWdsTjczS3lycmlmU2hVYldDZ3hkbC9zaEJV?=
 =?utf-8?B?TjhUMTNLZVNraWhpYTk3RXdoVXltRjFCQlpMOXN6VENWUnhwRnlXK0svZmVM?=
 =?utf-8?B?QW8xM1J2MUJCaHdYdzZ6ZWtzdWhXYWluZW1EMGk2aTBBR3AzUkc3aHBqQVdK?=
 =?utf-8?B?TW5sTExNQ2ZPUUxFbzdwTlVYUWNXZmRuY25MOGQ4Q1RKenVNb3FKenkvc2JH?=
 =?utf-8?B?MXhLVktEZWdKc2F3UmlQOGVDSmJxS3gydGo1SWxKcXBsWHRnczVZejM4c1FP?=
 =?utf-8?B?OXpFRkRaQzJFaGowM0lTcEl3aEVHMU5XRlpIcGc5M2wzUnByRzdwdWlkZTRL?=
 =?utf-8?B?OVdISS9LcnFlaDlUczJLT3piaHdPWDZTeHlXejJUUXR4RVZUanJUVnVNZXJ1?=
 =?utf-8?B?R3BUMDN5YUNmSlJUZXZ1TlkvcWFBcko3S3Y2VkJ5Yi85Y2pZbitBOTQrbURF?=
 =?utf-8?B?M3FNNzlEZ0hJRDF1NVcwelNlZzVmaUxGUHhubXUvcllTMHZUYUhkb2pLc05K?=
 =?utf-8?B?VTd5djB2ZkRzdTl1anRJM1NvS28vRmFXbk5NRjNObDBYNVE2U1VpRitwZmNH?=
 =?utf-8?B?eE5jYnoyZmUzb2Nadm1QZ0NheWMrN2RzelpqaEtrd293WktmelR5MEJqQ01r?=
 =?utf-8?B?S1ZFUklwZGRFdmF6U2VSNU83c1d6TTZQZFlDbUIwWTF2eVJVK01tVm91eGVO?=
 =?utf-8?B?N3pjSHdxRnpVencyVnJ4NTlSWWNOMC9kRFcyVUhFRm5PYkNuSG9WWUZuZEVt?=
 =?utf-8?B?a3ZDSWVmY21vRXljd2NPUU1nWkZyd2x6V0c2b0N3dWhLRjErWTNRSERpUCsx?=
 =?utf-8?B?RkhQR3pQdy8xMEdheElvZDdEMUlDN3NuSnNuUS9uUTErbEgySCt3MU1aYTVL?=
 =?utf-8?B?dTFkbHFoY05KVHRVcWx1Z3hwUXFoL3lFMDBZL2dWOXRCM0RqdXliQU95Y1ZX?=
 =?utf-8?B?V2JsU04zNmJKYVMwbUI2czUzODlmekZBYmVDNHBwUGJCQWgzM3pPNHo5RU5R?=
 =?utf-8?B?S2xXT2huUFZlMkt5cGdrTFNrRUt4bXhiK0R0azNQaTNGQjUreWUvRHRwYjNo?=
 =?utf-8?B?RHdyWHpwcTNrcHphK1hzVWZwTmx5emRYMjZtd0NOb05KeEczaS9qOFBKRmZs?=
 =?utf-8?B?WjNtREtzd2M1V1k5WU9CZjRZbkJnQXQ4aEhiNVY5elUzV1BuM2V2SEp3SG4w?=
 =?utf-8?B?NlVOZ3NyRHlBN3pCVDhwNG9MK09VMGxvRlVWUmhmYjBZYlJpSzVPaHlJRnZT?=
 =?utf-8?B?bEJWYXh2V0RFSnVydHZuUGVqcU9ob3NSQjN0Q05saU55RVppQzRxMkdwemVa?=
 =?utf-8?B?NHVoc0Jnd09oOWpBdng3Ykk0R3dnSzAvK0IyVGFpS01wUzQ1L0xJZGMwSm45?=
 =?utf-8?B?eHVXV2RBcllZUUsyc3l4bWhsaFZJeVdwcVJCMklsTG11US9TS2xpZjQ2MStO?=
 =?utf-8?B?QVlYYkxZNXNialowN0RDUnhacUJWckZHeDcxb2RpTVNTRHhwaE1mY0VyWEp0?=
 =?utf-8?B?ZXRkTmUraFRMN0o1d2dLOW1OYmo2YzNjL0lnaFZndHFWcjJMVkg2Z0YrZy83?=
 =?utf-8?B?Zmk0SHl6d0FRYlhGQm5GSVhkYzlnQ01LelpVRkZvWWd6N09salE2NU16OFMw?=
 =?utf-8?B?QWFtUThnc1ZBL0sxcnprUXdCZEN6dWFSbkh4Z3YycFdEYXE1ay9nZ24rdmV3?=
 =?utf-8?B?UXJUNkNJc1I2MnN0ZTJyMzRjZ0FTTStOQUJPbVVudmZDcFJ2VzlQT3hBbUxC?=
 =?utf-8?B?M292K21kTGxGRmRqclU5THhYTFRRQ0pISncwS3dhNkFCK1E0SE15ZDI3VXE3?=
 =?utf-8?B?MmxIMmlZZm5QMmhmdDVSZU5PdXRyYkh2K0NNemxqSTVLMlVKSEw5STcyVUpI?=
 =?utf-8?B?Y1pvbC81WHFBSllZazVNRFhHcFNvR0FjNWt5enRKMWI1NFNRQTlxaEIrbCtn?=
 =?utf-8?B?Y0RXbkE4T256NWd4TTNrWVVJRUsyWGV4ZzFpSHlxSVVNaUdRSXMxYjhyMjJa?=
 =?utf-8?B?MEpDK3V2U293U0RDcmpvNHV3bUoxdlp3ZEtRZXdXeFZnbkhMRW5CdGhGME44?=
 =?utf-8?B?T09OWUsya0ZoM3BYaXRzQWFrUXN1UjFUbmovZ1BkTTJ2VlFIWFNJWG16U3lL?=
 =?utf-8?B?WXAxbFZvMEJyWGFiUVgza0cza0ZPKytsZUh2c25INWd0dndCQmNiY2N6UHZw?=
 =?utf-8?B?ekNQcGxqV1k4VjMwWDlGTzFGT3BMTE51QWhPRHdTTWs1Ujg5K08wSlJSWUsr?=
 =?utf-8?B?MTcxRkZrM3pEM0F0QTdiUTh5UXRhS0IrdWhPcjQwNUV6azJzamFoQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef62dd0e-4c01-4001-ac7e-08da17cce777
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 12:56:46.3473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ygFtWHWEx+MJpJGs+PgY70pCppMvtmAKea/lL572IPJiRPJwknw0cuKq4w6xoEIcGsqvAoo8mqGTrDd0XiaGkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5327

On 01.04.2022 12:47, Jane Malalane wrote:
> Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and
> XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and
> x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization
> can subsequently be enabled on a per-domain basis.
> No such features are currently implemented on AMD hardware.
> 
> HW assisted xAPIC virtualization will be reported if HW, at the
> minimum, supports virtualize_apic_accesses as this feature alone means
> that an access to the APIC page will cause an APIC-access VM exit. An
> APIC-access VM exit provides a VMM with information about the access
> causing the VM exit, unlike a regular EPT fault, thus simplifying some
> internal handling.
> 
> HW assisted x2APIC virtualization will be reported if HW supports
> virtualize_x2apic_mode and, at least, either apic_reg_virt or
> virtual_intr_delivery. This also means that
> sysctl follows the conditionals in vmx_vlapic_msr_changed().
> 
> For that purpose, also add an arch-specific "capabilities" parameter
> to struct xen_sysctl_physinfo.
> 
> Note that this interface is intended to be compatible with AMD so that
> AVIC support can be introduced in a future patch. Unlike Intel that
> has multiple controls for APIC Virtualization, AMD has one global
> 'AVIC Enable' control bit, so fine-graining of APIC virtualization
> control cannot be done on a common interface.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com> # hypervisor



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 12:58:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 12:58:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299868.511127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5FG-0005ne-Lk; Wed, 06 Apr 2022 12:58:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299868.511127; Wed, 06 Apr 2022 12:58:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5FG-0005nX-I6; Wed, 06 Apr 2022 12:58:46 +0000
Received: by outflank-mailman (input) for mailman id 299868;
 Wed, 06 Apr 2022 12:58:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uak5=UQ=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nc5FF-0005nP-H2
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 12:58:45 +0000
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 496ca0d6-b5a9-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 14:58:44 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id A3C513200754;
 Wed,  6 Apr 2022 08:58:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Wed, 06 Apr 2022 08:58:41 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 6 Apr 2022 08:58:40 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 496ca0d6-b5a9-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=UaXu2ljbFxpHZm2ZR
	ElGGgxV/C/16vS/A9gfGX6+AH8=; b=UMNSFCDaADd5TjYUg8XrRRm5seh2o6lXO
	53vv6jtkPTF5RFs0OPj6nNoivT1rrlA6Was2rwhT+XJxDyHv6l18H+ArkVxKeVq1
	8awYQAIu9o83g3Z/Ehz8Q9jLsCjf5sCNrsfDAoU0CWZ7MHr15fEx9+RGxezpBuZS
	NTVb/qcIpD+2wD1UDNMWq9tWj5pREZ8W+U/qQT+g+1V4bjQQfro8tO706S8d26dt
	jUYlUkfSfQsdifGfkYZOcdc2fDNUGpXi+OIZXAclQSGsVavhILYpNNFUmzCmoMR3
	jyEDFOmNrZyeZzzRMXu/cPza6bsoEIV5VeDxKPJB3ZqTXJT7HVYwA==
X-ME-Sender: <xms:gI5NYoTJ6ceLts4ZpAyoqT-kFUNTxy866iAII-KqCTJA9Ay7tKeBaA>
    <xme:gI5NYlyBPa8Hej19Cl5RN0ZI2q46jNUV1HOFWGqB87ZcNvQ4LLtOPqhZTITBxFs21
    4LqWMV5wNY0vA>
X-ME-Received: <xmr:gI5NYl0Umd9K7puxUvymX4rbtHljuJgsSZiWbiEZ1R-YEOHVRWdSTXk>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejiedgheelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:gI5NYsClGG0l9V_-vep8L1hk-O_P2JB2naFYzrQRSFLzGM-6ev_pAg>
    <xmx:gI5NYhjXrCEwMm0N6-wecMGwaswRpTzQ-AHz5Q15pBMa6sh9cHG9Uw>
    <xmx:gI5NYorB3TpeiTkoWRDMde-aThT1rBlUT-Gn1USvuSqO9zHH3HxRlA>
    <xmx:gY5NYrcDVhCPEC0auNXobCb4LFU34jC174zb2mpxOHEiV2moCMHFqw>
Date: Wed, 6 Apr 2022 14:58:37 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Increasing domain memory beyond initial maxmem
Message-ID: <Yk2OfpSaz9U0agrn@mail-itl>
References: <YkUlLvnEDdc5hwN4@mail-itl>
 <2684376b-3ae6-a2b7-581f-2bd38ab6056b@suse.com>
 <YkWYGFJ/Cl+B2C37@mail-itl>
 <362b6115-e296-e01e-520f-31a0826426eb@suse.com>
 <YkWgQNKK7SarjKDN@mail-itl>
 <a9325c01-f6bd-46e8-d730-3f18b71b9969@suse.com>
 <YkxtOxOCY8nxy0Gt@mail-itl>
 <8e392b3c-8808-509e-adb7-f4a3c1a5c86c@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="K+cFpVUOlasexP8z"
Content-Disposition: inline
In-Reply-To: <8e392b3c-8808-509e-adb7-f4a3c1a5c86c@suse.com>


--K+cFpVUOlasexP8z
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 6 Apr 2022 14:58:37 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Increasing domain memory beyond initial maxmem

On Wed, Apr 06, 2022 at 07:13:18AM +0200, Juergen Gross wrote:
> On 05.04.22 18:24, Marek Marczykowski-G=C3=B3recki wrote:
> > On Tue, Apr 05, 2022 at 01:03:57PM +0200, Juergen Gross wrote:
> > > Hi Marek,
> > >=20
> > > On 31.03.22 14:36, Marek Marczykowski-G=C3=B3recki wrote:
> > > > On Thu, Mar 31, 2022 at 02:22:03PM +0200, Juergen Gross wrote:
> > > > > Maybe some kernel config differences, or other udev rules (memory=
 onlining
> > > > > is done via udev in my guest)?
> > > > >=20
> > > > > I'm seeing:
> > > > >=20
> > > > > # zgrep MEMORY_HOTPLUG /proc/config.gz
> > > > > CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=3Dy
> > > > > CONFIG_MEMORY_HOTPLUG=3Dy
> > > > > # CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE is not set
> > > > > CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=3Dy
> > > > > CONFIG_XEN_MEMORY_HOTPLUG_LIMIT=3D512
> > > >=20
> > > > I have:
> > > > # zgrep MEMORY_HOTPLUG /proc/config.gz
> > > > CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=3Dy
> > > > CONFIG_MEMORY_HOTPLUG=3Dy
> > > > CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=3Dy
> > > > CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=3Dy
> > > > CONFIG_XEN_MEMORY_HOTPLUG_LIMIT=3D512
> > > >=20
> > > > Not sure if relevant, but I also have:
> > > > CONFIG_XEN_UNPOPULATED_ALLOC=3Dy
> > > >=20
> > > > on top of that, I have a similar udev rule too:
> > > >=20
> > > > SUBSYSTEM=3D=3D"memory", ACTION=3D=3D"add", ATTR{state}=3D=3D"offli=
ne", ATTR{state}=3D"online"
> > > >=20
> > > > But I don't think they are conflicting.
> > > >=20
> > > > > What type of guest are you using? Mine was a PVH guest.
> > > >=20
> > > > PVH here too.
> > >=20
> > > Would you like to try the attached patch? It seemed to work for me.
> >=20
> > Unfortunately it doesn't help, now the behavior is different:
> >=20
> > Initially guest started with 800M:
> >=20
> >      [root@personal ~]# free -m
> >                    total        used        free      shared  buff/cach=
e   available
> >      Mem:            740         223         272           2         24=
3         401
> >      Swap:          1023           0        1023
> >=20
> > Then increased:
> >=20
> >      [root@dom0 ~]$ xl mem-max personal 2048
> >      [root@dom0 ~]$ xenstore-write /local/domain/$(xl domid personal)/m=
emory/static-max $((2048*1024))
> >      [root@dom0 ~]$ xl mem-set personal 2000
> >=20
> > And guest shows now only a little more memory, but not full 2000M:
> >=20
> >      [root@personal ~]# [   37.657046] xen:balloon: Populating new zone
> >      [   37.658206] Fallback order for Node 0: 0
> >      [   37.658219] Built 1 zonelists, mobility grouping on.  Total pag=
es: 175889
> >      [   37.658233] Policy zone: Normal
> >=20
> >      [root@personal ~]#
> >      [root@personal ~]# free -m
> >                    total        used        free      shared  buff/cach=
e   available
> >      Mem:            826         245         337           2         24=
4         462
> >      Swap:          1023           0        1023
> >=20
> >=20
> > I've applied the patch on top of 5.16.18. If you think 5.17 would make a
> > difference, I can try that too.
>=20
> Hmm, weird.
>=20
> Can you please post the output of
>=20
> cat /proc/buddyinfo
> cat /proc/iomem
>=20
> in the guest before and after the operations?

Ok, that was a stupid mistake on my side - I've run out of host memory.
With that fixed, it seems to work, on 5.16.18 too.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--K+cFpVUOlasexP8z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmJNjn0ACgkQ24/THMrX
1yxYYAf/TYbp93H4jclpmuhGLbyZ03BaX3pLYKVJBpVlo33V4op1tPtLUMEkYM9U
Qq/zzZuv9sVeDq3ge3X0yT7mRhOa41SxKT4GDyCjjKNdngFy67JWvgRIY4ZDn/t9
jclQe6VToBnN6sgnv0erBJalYrRKnx9WeKZzJdNqjlfxPd6AvgnNMNZnMxzi/7zT
MM/CrnVLjbi239aplFUPxr3Be7/L8z9IrcU8qBJk2bMCncLPt0KJsmn+Jymer58B
x0gzOgtyFjW0KngocDWBBegQcCZWeNjUztNpmdHY2EYhq4SqqNunK1mTuQ3+wTgB
yxbOE3+WMEBrc1Gnr1J56TIZbuc8Sw==
=1sHk
-----END PGP SIGNATURE-----

--K+cFpVUOlasexP8z--


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 13:10:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 13:10:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299873.511141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5Qo-0008Dj-OK; Wed, 06 Apr 2022 13:10:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299873.511141; Wed, 06 Apr 2022 13:10:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5Qo-0008Dc-LB; Wed, 06 Apr 2022 13:10:42 +0000
Received: by outflank-mailman (input) for mailman id 299873;
 Wed, 06 Apr 2022 13:10:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4vzw=UQ=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nc5Qn-0008DP-Ho
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 13:10:41 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f4db19a2-b5aa-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 15:10:40 +0200 (CEST)
Received: by mail-lf1-x12c.google.com with SMTP id d5so3979831lfj.9
 for <xen-devel@lists.xenproject.org>; Wed, 06 Apr 2022 06:10:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4db19a2-b5aa-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=7Nnm+4SYrJfvah7q1xJFB6IeOVdlM7FcfSEnU8mTnms=;
        b=TfjXKlGre5028SMmQDl+/BBmoiv3A4g0ZlD7ZF/f+/uJeQupxi5E/qabjkm090Pyhj
         5HQ3NwJCLEApnKBgbK/gFQU4+5Evo885WrmOLtEzgEFnzgDwE8Kd1cH2I51kMsfGC/aA
         Fku1tp20Q4iYeQmrp5qzTKQKXvbYGi5Ry/mVutHWEZhi8Vuwg8TStFnEoEIyLGs/5laI
         sHGnMBM1oolNVmtaN7Lh+rJIjILFzBwkXQ4ouYFV6v1ScNsewz3v52WHKdVoJdSrwIvI
         zf5r8yPl4pBicRXHYd+h9FYxd/7/4Yv7Tinuu9lISvXFGLMMfMbIpuQpah/IPm6aZ9ea
         V7+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=7Nnm+4SYrJfvah7q1xJFB6IeOVdlM7FcfSEnU8mTnms=;
        b=3ol3OGkbVPq81Cz6yCdc8ZVv58MAbt91wi1NmtybjGTTJ3Z2BY/cyRuD0kZJGERcTd
         btwCkltjI1KbDxvTIeRaHHNQtynNZnd6lpDiY88efygDEtQzt+m1lil1BdgDP+l3EERf
         ju+OaPJ8FsXq5K21QtPRZkrrHNee9NHQgg3mepiTCt6cvPvHtL6e2hvwkWx64GmNoUyr
         KqjN9aJNTB+WXoelySIuVXrNGf39CH8Qy7xoqgwbVByMCXHToFLhbUPx0oIbDj2rP+/S
         ouRULcjePwgGtLpXcuEDHxGMG3SM3PIIynqvaCLFI9T46nfBFmeqeoXzVnpphA3GTcR6
         lKbg==
X-Gm-Message-State: AOAM5338b6kywRmPKCWrDnIMci7ufNd4MeGvOlT+cyT+75pzcMP7i0wI
	Kj3dz+me7Uk53ydXvZuC5C6HQyLVinfhDMDBp+72j+yA
X-Google-Smtp-Source: ABdhPJzmU2QpBB5ybDTj86tGfQRUM026ZUtZac6NLuhUf7nIr27AO/x4vWWq/9DVU2XxRnNGtWpXCygOcbWal4K6Dsw=
X-Received: by 2002:a05:6512:280c:b0:44a:a844:d7d8 with SMTP id
 cf12-20020a056512280c00b0044aa844d7d8mr6143295lfb.250.1649250639480; Wed, 06
 Apr 2022 06:10:39 -0700 (PDT)
MIME-Version: 1.0
References: <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz.ref@netscape.net>
 <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz@netscape.net>
 <78ce5809-8df4-c94e-4313-fffb1b86b771@suse.com> <CAKf6xpsN+uJ=AyxtrnOrQrynFL=dwC=DdT7DHnK=wx9UFtdUDQ@mail.gmail.com>
 <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net> <5d14eeb8-038f-e99a-31b8-f6b3b562c2c4@netscape.net>
In-Reply-To: <5d14eeb8-038f-e99a-31b8-f6b3b562c2c4@netscape.net>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Wed, 6 Apr 2022 09:10:27 -0400
Message-ID: <CAKf6xpsNsYM=fHb4DwiLmsH+Nz+0UF5RvjWr=GeYo5d+6Rmi_Q@mail.gmail.com>
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access
 to Intel IGD opregion
To: Chuck Zmudzinski <brchuckz@netscape.net>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, Apr 5, 2022 at 9:31 PM Chuck Zmudzinski <brchuckz@netscape.net> wrote:
> Correction (sorry for the confusion):
>
> I didn't know I needed to replace more than just a
> re-built i915.ko module to enable the patch
> for testing. When I updated the entire Debian kernel
> package including all the modules and the kernel
> image with the patched kernel package, it made
> quite a difference.
>
> With Jason's patch, the three call traces just became a
> much shorter error message:
>
> Apr 05 20:46:18 debian kernel: xen: --> pirq=16 -> irq=24 (gsi=24)
> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: [drm] VT-d active for
> gfx access
> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: vgaarb: deactivate vga
> console
> Apr 05 20:46:18 debian kernel: Console: switching to colour dummy device
> 80x25
> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: [drm] DMAR active,
> disabling use of stolen memory
> Apr 05 20:46:18 debian kernel: resource sanity check: requesting [mem
> 0xffffffff-0x100001ffe], which spans more than Reserved [mem
> 0xfdfff000-0xffffffff]
> Apr 05 20:46:18 debian kernel: caller memremap+0xeb/0x1c0 mapping
> multiple BARs
> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: Device initialization
> failed (-22)
> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: Please file a bug on
> drm/i915; see
> https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs
> for details.
> Apr 05 20:46:18 debian kernel: i915: probe of 0000:00:02.0 failed with
> error -22
> --------------------- End of Kernel Error Log ----------------------
>
> So I think the patch does propagate the error up the
> stack and bails out before producing the Call traces,

Thanks for re-testing.

> and...
>
> I even had output after booting - the gdm3 Gnome display
> manager login page displayed, but when I tried to login to
> the Gnome desktop, the screen went dark and I could
> not even login to the headless Xen Dom0 control domain
> via ssh after that and I just used the reset button on the
> machine to reboot it, so the patch causes some trouble
> with the Dom0 when the guest cannot access the
> opregion. The patch works fine when the guest can
> access the opregion and in that case I was able to
> login to the Gnome session, but it caused quite a bit of
> trouble and apparently crashed the Dom0 or at
> least caused networking in the Dom0 to stop working
> when I tried to login to the Gnome session in the
> guest for the case when the guest cannot access
> the opregion. So I would not recommend Jason's
> patch as is for the Linux kernel. The main reason
> is that it looks like it is working at first with a
> login screen displayed, but when a user tries to login,
> the whole system crashes.

I'm a little surprised you still had output from the VM & display with
the i915 driver not binding.  I guess Linux fell back to another VGA
or Framebuffer driver for the display.

However, locking up the host isn't good.  You didn't happen to catch
any Xen or dom0 output when that happened?

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 13:32:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 13:32:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299878.511163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5lx-0002Z5-RF; Wed, 06 Apr 2022 13:32:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299878.511163; Wed, 06 Apr 2022 13:32:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5lx-0002Yy-Ni; Wed, 06 Apr 2022 13:32:33 +0000
Received: by outflank-mailman (input) for mailman id 299878;
 Wed, 06 Apr 2022 13:32:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wVRv=UQ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nc5lx-0002JJ-3q
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 13:32:33 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02f1a3f9-b5ae-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 15:32:32 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C08961F7AE;
 Wed,  6 Apr 2022 13:32:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 89BE3139F5;
 Wed,  6 Apr 2022 13:32:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CqxIIG+WTWLhAwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 06 Apr 2022 13:32:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02f1a3f9-b5ae-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649251951; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=fRYpW0cKkoFsVs1W48NO42/Imz4z4xmT/W/n6IF74TY=;
	b=D3hjbmmd26QzFyFTDA48Xbsqomr7pFOECORnOpXG1KTLfMV7NWnPZNb1whNYDl0jBJdcyN
	9ueIMQSlDdUzEDsxOSGDBOtP8iwqmksJZYEGIjGRb1l2Miof/x0AR5AO08NskWCwyPRTk8
	l+gQ7z7loZ9aHCWiaiJSchJerdgl6cE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	stable@vger.kernel.org,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH] xen/balloon: fix page onlining when populating new zone
Date: Wed,  6 Apr 2022 15:32:29 +0200
Message-Id: <20220406133229.15979-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When onlining a new memory page in a guest the Xen balloon driver is
adding it to the ballooned pages instead making it available to be
used immediately. This is meant to enable to add a new upper memory
limit to a guest via hotplugging memory, without having to assign the
new memory in one go.

In case the upper memory limit will be raised above 4G, the new memory
will populate the ZONE_NORMAL memory zone, which wasn't populated
before. The newly populated zone won't be added to the list of zones
looked at by the page allocator though, as only zones with available
memory are being added, and the memory isn't yet available as it is
ballooned out.

This will result in the new memory being assigned to the guest, but
without the allocator being able to use it.

When running as a PV guest the situation is even worse: when having
been started with less memory than allowed, and the upper limit being
lower than 4G, ballooning up will have the same effect as hotplugging
new memory. This is due to the usage of the zone device functionality
since commit 9e2369c06c8a ("xen: add helpers to allocate unpopulated
memory") for creating mappings of other guest's pages, which as a side
effect is being used for PV guest ballooning, too.

Fix this by checking in xen_online_page() whether the new memory page
will be the first in a new zone. If this is the case, add another page
to the balloon and use the first memory page of the new chunk as a
replacement for this now ballooned out page. This will result in the
newly populated zone containing one page being available for the page
allocator, which in turn will lead to the zone being added to the
allocator.

Cc: stable@vger.kernel.org
Fixes: 9e2369c06c8a ("xen: add helpers to allocate unpopulated memory")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c | 72 ++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 65 insertions(+), 7 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index dfe26fa17e95..f895c54c4c65 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -355,14 +355,77 @@ static enum bp_state reserve_additional_memory(void)
 	return BP_ECANCELED;
 }
 
+static struct page *alloc_page_for_balloon(gfp_t gfp)
+{
+	struct page *page;
+
+	page = alloc_page(gfp);
+	if (page == NULL)
+		return NULL;
+
+	adjust_managed_page_count(page, -1);
+	xenmem_reservation_scrub_page(page);
+
+	return page;
+}
+
+static void add_page_to_balloon(struct page *page)
+{
+	xenmem_reservation_va_mapping_reset(1, &page);
+	balloon_append(page);
+}
+
 static void xen_online_page(struct page *page, unsigned int order)
 {
 	unsigned long i, size = (1 << order);
 	unsigned long start_pfn = page_to_pfn(page);
 	struct page *p;
+	struct zone *zone;
 
 	pr_debug("Online %lu pages starting at pfn 0x%lx\n", size, start_pfn);
 	mutex_lock(&balloon_mutex);
+	zone = page_zone(pfn_to_page(start_pfn));
+
+	/*
+	 * In case a new memory zone is going to be populated, we need to
+	 * ensure at least one page is made available for the memory allocator.
+	 * As the number of pages per zone is updated only after a batch of
+	 * pages having been added, use the number of managed pages as an
+	 * additional indicator for a new zone.
+	 * Otherwise this zone won't be added to the zonelist resulting in the
+	 * zone's memory not usable by the kernel.
+	 * Add an already valid page to the balloon and replace it with the
+	 * first page of the to be added new memory chunk.
+	 */
+	if (!populated_zone(zone) && !managed_zone(zone)) {
+		xen_pfn_t frame;
+
+		pr_info("Populating new zone\n");
+
+		p = alloc_page_for_balloon(GFP_ATOMIC);
+		if (!p) {
+			pr_err("Failed to allocate replacement balloon page!\n");
+			pr_err("New onlined memory might not be usable.\n");
+		} else {
+			kmap_flush_unused();
+			add_page_to_balloon(p);
+			flush_tlb_all();
+			frame = xen_page_to_gfn(p);
+			xenmem_reservation_decrease(1, &frame);
+			balloon_stats.current_pages--;
+		}
+
+		p = pfn_to_page(start_pfn);
+		frame = page_to_xen_pfn(p);
+		if (xenmem_reservation_increase(1, &frame) > 0) {
+			xenmem_reservation_va_mapping_update(1, &p, &frame);
+			free_reserved_page(p);
+			balloon_stats.current_pages++;
+
+			start_pfn++;
+			size--;
+		}
+	}
 	for (i = 0; i < size; i++) {
 		p = pfn_to_page(start_pfn + i);
 		balloon_append(p);
@@ -452,14 +515,12 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
 		nr_pages = ARRAY_SIZE(frame_list);
 
 	for (i = 0; i < nr_pages; i++) {
-		page = alloc_page(gfp);
+		page = alloc_page_for_balloon(gfp);
 		if (page == NULL) {
 			nr_pages = i;
 			state = BP_EAGAIN;
 			break;
 		}
-		adjust_managed_page_count(page, -1);
-		xenmem_reservation_scrub_page(page);
 		list_add(&page->lru, &pages);
 	}
 
@@ -480,11 +541,8 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
 	list_for_each_entry_safe(page, tmp, &pages, lru) {
 		frame_list[i++] = xen_page_to_gfn(page);
 
-		xenmem_reservation_va_mapping_reset(1, &page);
-
 		list_del(&page->lru);
-
-		balloon_append(page);
+		add_page_to_balloon(page);
 	}
 
 	flush_tlb_all();
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 13:32:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 13:32:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299877.511152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5lw-0002JW-Io; Wed, 06 Apr 2022 13:32:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299877.511152; Wed, 06 Apr 2022 13:32:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5lw-0002JP-FY; Wed, 06 Apr 2022 13:32:32 +0000
Received: by outflank-mailman (input) for mailman id 299877;
 Wed, 06 Apr 2022 13:32:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc5lu-0002JJ-H3
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 13:32:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 01559f15-b5ae-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 15:32:29 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-gDdYAiVlMBmwWf78i4kMVw-1; Wed, 06 Apr 2022 15:32:26 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM5PR0402MB2882.eurprd04.prod.outlook.com (2603:10a6:203:97::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Wed, 6 Apr
 2022 13:32:24 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 13:32:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01559f15-b5ae-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649251949;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=u+YHHQY0kbqHp0xNgZMAPFfK+BDg9leuVX8sHIIPGqo=;
	b=XoErujylyNdQuqNNvT8PtThYkNDFjpv2LeCmrB4fYgSzRvAS6DzODC0qX8bqYYzqMMMlDF
	pVLE7ajYHSzdTq/3ywgEk46X0S00ZsE5+Vh6/hn1qo32O+cW0NI1m67VoHztvQ5NwxSq3X
	U1NO3MvAdOLSXZXQyxqNXmZbXrjgYsE=
X-MC-Unique: gDdYAiVlMBmwWf78i4kMVw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JBHS76gRkR57DBuORuzx4f1yehY+VdEpkb71WzcHFksJ8DLQm5jHabd0NFqshjPSE6SnWzGRRREAf7Rrb7TMTRfq1Cp0XzynK5VLImY6GueWTuMcKwIo55/mXieAPTQR/kC5D2hRYkrH9varHcjpD91zKEFjHqNkuPMrkA8ZeMJrNlR6WNbnHtpuuP/BLnIg+9Wc/WsR0JZN+TzotghiYF7NGcd2uwj4VD49D7MvJbMRxqyjwR9HOeKXYsKgpNZ9zds96U7VlMocuJwizeR1TqEgBihZiF3kZO/lqX8c9BbTbgy3hdNH+lmyY5Jqnv45tU5cBBHnBesa/JsAF4CY3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u+YHHQY0kbqHp0xNgZMAPFfK+BDg9leuVX8sHIIPGqo=;
 b=Uy+pFrsAEJBW2XnYr+bAL5yF4Lm85OxS3yMz2YfsWH7Rzo+nQ3Ady1ImSSc1508tY36scuO9+PT86NsYZIiH4+YW9nM2MiPOqWlemGHy85IwBfwxshhqsBGUmfU8EVJ9H1drD1++rqLQ2sAGKB3ROJuHKeJEQ1xQdjJJYW6Ge2ouyYOJ2Q7qlOZpUxaFmzYuyzlKfmlIYeMgf7jZA/5KSguVmgmWDbT7qqIqw+6QZy2Ni6QWsl+6AQU8wyIYZvx5TIOeonVvda+bmGRZ4ELhoDbQWd/wEzZqF0mebLBfklo8iox/Ps8Aip52lj9oFlF8nGQ8hdMHSmVq3pooj0uF2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ab79f62f-45e8-7cb5-bf3b-a8c003db63b9@suse.com>
Date: Wed, 6 Apr 2022 15:32:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] EFI: correct indentation in efi_tables()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0054.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0e9b4b51-fb68-4114-bd22-08da17d1e2b4
X-MS-TrafficTypeDiagnostic: AM5PR0402MB2882:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0402MB28826972C683F381DD77BD04B3E79@AM5PR0402MB2882.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VzZnsmPkMkn2y4D0F7PNYp5XRsvtExrqhF/+bJgNC3lU5ZQ9y5fP1xWLcEhzTKQTbyPKh2b9J3tHkdwgrN94OPinJ7WCaHMGDFmnL57nwDscequCIHl5+aGcckv8jJiQ70y2WmwfS/CZ6xF7o0rznc23lYAJPVzWV8lGm0eV95ADj1Nt9o/uEer/lQaeyYz3nTGXsnO16RPmelVvrgAS9J3nmkWwjvsOizqjlQxhhku1aEmEf5mFbGGSkwwkmxFdREjR5KABnf08MgHuW7I4Xw8+vc+PIUwSXcGgkxUWTwfW3s5ib1UnyP5zOFVxkebpSSwkct1px5++4VLesnn8FFKXvGFQ8mi+f+BebGaiWwuex4gDQl2ZvkDRniIXVkpTbpiVEhdvGEp6370ssR8zLiEn3hevpM/PTFdwbq3KKOKoUTds6vN3CciOyPdXztSwkcnSeFLnCvRwNeOzz4pmaCkrVJjyPFTY6N88iQAhcYAesZloqscHSXOWMnGHXB9GZw8HmaLZeQGMqYR5PfRwsBwj48+VZdc+5lnGS8Ot+4ogNz/DtdPwfoP8iEjVMykUib4nCjW7QPpcFxGe5IjdaRnGPDCz/bpcSS8v/NO2MxT/MC+VxoRuYQfYQyiWS+Hs0SCxbUGinLrOfoK1/WnAFjbogwjSnByEg3NyhVw9MP7LVvTvN6qeDuuWS4st174Lg+tw/09sHPBCs9n/Xvo1mOZi8c9J9w0d20awLcYOXiI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(8936002)(5660300002)(2906002)(6916009)(66476007)(6486002)(2616005)(6506007)(54906003)(508600001)(316002)(66556008)(6512007)(8676002)(4326008)(26005)(66946007)(31696002)(31686004)(38100700002)(186003)(86362001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UnhSTEJtcTNUYnpnM3J2K0t2Z0l1dS9XZDRwcDVTVldhbXVMUC9vY3FlMUJ3?=
 =?utf-8?B?MjNzaWVzZzZDQ3dxYjRjU0lXQlhvbzRRSE0rbjkzWk05Z1gvak43TmU5SGRy?=
 =?utf-8?B?M1k3QmRKRjVQb3RoRGMvN1hhNzNKVEpRbVU0UDUzK0p3Wk5QMU1nYkdlbnUv?=
 =?utf-8?B?ZlZ2djdXMDg5citZbXhlYnAzbnJETTZLamRuMjJBdFVid2Z1TkNuWTdoZ3Vi?=
 =?utf-8?B?RTBZYTBtREpTM1lOSlk3ODk0ZzFBZGF6dDhINlo5b3Zma0ZzNmcyYTF1TjFl?=
 =?utf-8?B?N0pkenBTNExIUHJNejVxOGZKMGpicHArMEdTNzdkSWltS3NRdTQ3SUlRa0Ez?=
 =?utf-8?B?OTRxd3FxazJQRWY2cWRjQXRqd1ZsZUlTS1A0K0hrYjRuRk5EeVAyU2l3b1NU?=
 =?utf-8?B?UlZjenNtUHdCUDhtUHBCWjBOTkJEVVJpUS8rbUtlU1gvcUt5cmk1QXNrZllP?=
 =?utf-8?B?emQ2TGd6Vk1CeUxFT005dUZ4QzJEZDJUaVlqOFREbHFhaXhPWGFrN1lzeDQr?=
 =?utf-8?B?dU9jcE5WekN3Rm1oTUVHcDVIa013NzZiWnVtc2FFaHR6RStqdWRsVHBvWlh6?=
 =?utf-8?B?RmErQlVYY0xGYXNnT1F1aUtxRGgxWmlFQmoxa013VzVCd2pwbDNYZzcrWmJY?=
 =?utf-8?B?bnJUM0FPaDI0NjUxV1EvOG5FTy9BcnBCdCtHOVNVMXlCVWl3VjYyOE1PdEJs?=
 =?utf-8?B?cmx2dGxXSG5uZnJIMWkyTDFRTG1lSS9RQitqblFrNHNueFNhUDJMMkRES1Vw?=
 =?utf-8?B?bm9RL1NoWHkrdm1nODNLTkpxRm1oQWR1Z1dPTTNmZnF6amJueGJpZWRCUFpz?=
 =?utf-8?B?aHYyUkd0dXBXbVFiS3hOWkhFZGhWUTBJVnBoRU9wRHBudXk1QUYzSURrMjR4?=
 =?utf-8?B?cWdDQ0RhRjA4dUE5V1hiNmI3TkFiQWkrZzJNZkNCMERPU1doTWZ0RDZYTnk5?=
 =?utf-8?B?S3pnU0xIRWk1SEx3QmFXTENWOFZCdDFvRDlEVGlvUnF1SlVaelRidnNicWF1?=
 =?utf-8?B?TkJnOGlnTUsrU0YzaXBPWnFud3J1NHFiVzFiZmJqU2lvdmVkenIwdjIvcDRH?=
 =?utf-8?B?ZGtVMXlyNW5nVVJ1cHlMUXBXd056UE1VRFRFTG16UlAvUU5QbXhlcnErVWkw?=
 =?utf-8?B?bm9BVnY5R3FqSEUxV3dXZ01tWWtDOG0yNHdNdU1VU1ZmcHlsTEhiWFVlazh1?=
 =?utf-8?B?bVBxU21iN2s2b1lnZlhJckd2czZpQndKc2tEcWdLekcwOGJJSk9jY0pYU25J?=
 =?utf-8?B?dWpnbjJhQjdCenZTMU0zSmoxV2RheUhPUU1QSGdUTUNIcEhWdStLTk5ZNWFq?=
 =?utf-8?B?NFFUMGZoTVFHMGZpdU13QWVlQVVHcDBySXJVcVRJT1hiMG13aHhVejI2bXJn?=
 =?utf-8?B?Qjh6aFI2cDZkZktLb01TVExFNXp6cEJpdGttYmpBaERrL2dwZjNFc2xqejln?=
 =?utf-8?B?N0VwdFpXQUV0NFd6em5VU0xlZm1iNDJid1Q1Y04xbnhRSzFOdU81cGVZeGtW?=
 =?utf-8?B?N05kQjVNOEY3S09NMTBTTjJwYnVzNCtsclJ6SWhxT2NXbTI4OWVUU2dMVCtk?=
 =?utf-8?B?Z0RMZERFcEIxSWJVZFR4WnlMRGpqb2lMaVBhYjRKcWhNYlZmemFiV1lEaUtK?=
 =?utf-8?B?SFQ1ZVNubjJ5WGI1UUtXUGRXWHZEczdNUmMyc2VjS3EvdCtyN3BQd0l3M0xQ?=
 =?utf-8?B?S2h3QVBxMHRCVnZBcTVxbUR5L21uTTJJd2NDTUhUczRkcjBYd3NpUDdLM1V3?=
 =?utf-8?B?THdJTkdWMHdKc1FYNWJLanB5ZXNMejZWV1poQlRNUXh5N3dMazE1bWJreFM4?=
 =?utf-8?B?d2VzTnlSTmtteFpBMkRpRnRydU1kK3VNR1V6a0hPT3pqSVBsMGszZGx2UW9O?=
 =?utf-8?B?eVE4R0RIMDA1WGh0SS82ejlIc3VPSFVyRVhGaWY3U24rUkVCUkdmQzM0M1VQ?=
 =?utf-8?B?L2h1aXE0c3VUV1hwN2ZqYWs1aUZ2Z21ZZDRlaEVENmsvR1I3Tlo2NU1SL2JH?=
 =?utf-8?B?bFFYRHh2a0FOUUR4eWVmckZ5OHlVUnVlVFBUVXF4TW5PM1FEZVdocmhNcm0y?=
 =?utf-8?B?aTlUVGcrVnRBRWZPUEtEeXVEdkNYbUsya0gwYmRaZ0Rod3p4MzJGaHR1VEpT?=
 =?utf-8?B?TnVkSG9KcEtVZFE2SThSazhVMmtOcEFoMStZemtWMlRmc0ZEeVZtNzU3K28r?=
 =?utf-8?B?TXFWUnZaRHA1cDcxd0F3ekdrNURoOHlhb2Q4VFd4MWFDN1Y1QTNETWdqL0ZL?=
 =?utf-8?B?a1ZZTlU4SUs0eVFXQTJWWVczNnRKV0RSZzRqV1FxL2ZFZ1k5R0FMRWJDelBW?=
 =?utf-8?B?SEJRUlRmWnVVZ0hSanZlejlySXEya3l1RGFpV3dxUzZSUFBVOE9ZQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e9b4b51-fb68-4114-bd22-08da17d1e2b4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 13:32:24.6856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ImTc5/e6NHBmwuQZn65N8AJYYz4KlYbKjE3trzRHWofSNCiJhpynfpXWUQHNKEvLvzK/ixQDU63AQc2AE7Mxjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2882

Eliminate hard tabs. While there also cast to the intended type.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -856,15 +856,15 @@ static void __init efi_tables(void)
         static EFI_GUID __initdata smbios3_guid = SMBIOS3_TABLE_GUID;
 
         if ( match_guid(&acpi2_guid, &efi_ct[i].VendorGuid) )
-	       efi.acpi20 = (long)efi_ct[i].VendorTable;
+            efi.acpi20 = (unsigned long)efi_ct[i].VendorTable;
         if ( match_guid(&acpi_guid, &efi_ct[i].VendorGuid) )
-	       efi.acpi = (long)efi_ct[i].VendorTable;
+            efi.acpi = (unsigned long)efi_ct[i].VendorTable;
         if ( match_guid(&mps_guid, &efi_ct[i].VendorGuid) )
-	       efi.mps = (long)efi_ct[i].VendorTable;
+            efi.mps = (unsigned long)efi_ct[i].VendorTable;
         if ( match_guid(&smbios_guid, &efi_ct[i].VendorGuid) )
-	       efi.smbios = (long)efi_ct[i].VendorTable;
+            efi.smbios = (unsigned long)efi_ct[i].VendorTable;
         if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) )
-	       efi.smbios3 = (long)efi_ct[i].VendorTable;
+            efi.smbios3 = (unsigned long)efi_ct[i].VendorTable;
     }
 
 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 13:36:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 13:36:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299886.511173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5pl-0003a8-GB; Wed, 06 Apr 2022 13:36:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299886.511173; Wed, 06 Apr 2022 13:36:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5pl-0003a1-CP; Wed, 06 Apr 2022 13:36:29 +0000
Received: by outflank-mailman (input) for mailman id 299886;
 Wed, 06 Apr 2022 13:36:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nc5pk-0003Zv-C3
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 13:36:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc5pj-0004yu-Kh; Wed, 06 Apr 2022 13:36:27 +0000
Received: from [54.239.6.190] (helo=[192.168.16.200])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc5pj-0001mT-EY; Wed, 06 Apr 2022 13:36:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=aPPqWtGwWZmo50/WjeGVcaZQhnmUgVzChHQsjATChhA=; b=aJH8C3aCST0G+Gbq9g4WOIHNY6
	TFLWeHTDU8l1ONuFPReRA4XkrIry0/VXIcONR27CwRkGVAkdpzHEx64L6nvlUb0eLGHyLhmwFKjdC
	Z0Hg8Oj2fvGVylvVbVF9nnrPAO2tb25WF8C5ot1uEBDGTsda88mKsdMFt3KQQ6/pRFuY=;
Message-ID: <52abc898-fc74-5d3a-debd-118569744459@xen.org>
Date: Wed, 6 Apr 2022 14:36:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] EFI: correct indentation in efi_tables()
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <ab79f62f-45e8-7cb5-bf3b-a8c003db63b9@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <ab79f62f-45e8-7cb5-bf3b-a8c003db63b9@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 06/04/2022 14:32, Jan Beulich wrote:
> Eliminate hard tabs. While there also cast to the intended type.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 13:37:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 13:37:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299889.511185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5qU-00048E-Qb; Wed, 06 Apr 2022 13:37:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299889.511185; Wed, 06 Apr 2022 13:37:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5qU-000487-NE; Wed, 06 Apr 2022 13:37:14 +0000
Received: by outflank-mailman (input) for mailman id 299889;
 Wed, 06 Apr 2022 13:37:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc5qT-000477-6Q
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 13:37:13 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a889f5f2-b5ae-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 15:37:11 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a889f5f2-b5ae-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649252231;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=jA0D4LkSxyQZXXMt/ecYO18ZL0TPEKfwb67+/W22RXA=;
  b=hJ3/2RClp0RoUs82NSqc9867yWvMECoe0aZ0taqN8+IfF96qaSPJlA0j
   NbpkRlvhm4jdEu7r3C4XXYsWi46qvS3uyyIxlYe9bg8r0YZD/+Xukdazg
   lSf9ZW/+Jdnj7EXXrcQCiJ+tN5CQ+n2Jlo08nCuWZP7eKFOCfctmh15zo
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70556846
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mlOtt6lq/9VKM7dfrZF+5Fjo5gxbJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIYWTvSaKzea2r3fYh/YY+3pk9XsZHUnIBjGlRspC4xQiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW13V4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYS18IBKr1tvsmSgRxVBpfBoxiopLgCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQq6DO
 pRJNWQHgBLoRiJdCA0cGpkHotjwj1vCazEJ81nFuv9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt
 m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCn1m71mEVThoMWjOTufCkjmauVtQZL
 FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv
 neKks3oA3pzsbSTYXOb6rqQ6zi1PEAowXQqPHFeC1Ffup+6/d913kmnostf/LCdjIXUIzbJ7
 S+xtTUXwI4ytu8vjYic1AWS696znaThQgkw7wTRe2uq6AJleYKoD7CVBUjnAeVod9jAEATY1
 JQQs43Htb1VU8nR/MCYaL9VdIxF8cppJ9E1bbRHO5A6vwqg9He4FWy7yGEvfRw5WirolNKAX
 aMyhe+zzMILVJdJRfUuC25UNyjM5fK+fTgCfqqJBueimrArKGe6ENhGPCZ8JVzFnkk2ir0YM
 pyGa8uqBntyIf05kGvvF7tNge97mXtWKYbvqXbTlUrPPV22PiD9dFv4GAHWMrBRAF2s/m05D
 Oqzx+PVkk4CAYUSkwHc8JIJLEBiEJTILcueliCjTcbaelAOMDh4U5f5mOp9E6Q4z/U9vrqZp
 RmVBx4HoGcTcFWacG1mnFg4M+ixNXu+xFpmVRER0aGAgCF5O9vwtftBLPPav9APrYRe8BK9d
 NFcE+2oCfVTUDXXvTMbaJj2tot5cxq3wwmJOkKYjPIXJsQIq9DhkjM8QjbSyQ==
IronPort-HdrOrdr: A9a23:FmSP76vo7lKKP6HDrm7DHuNm7skClYMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkDuRYTzrdHGeKjM2YabQQ/
 Gnl7Z6TnebCDwqhoPRPAh2Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iGnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMw4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAkqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocbTbqjVQGZgoBT+q3tYpxqdS32AXTq+/blngS+pUoJgXfxn6ck7zU9HJFUcegx2w
 2LCNUsqFh0dL5nUUtMPpZxfSKJMB2/ffvtChPlHb21LtBPB5ryw6SHlYndotvaPKA18A==
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="70556846"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d1G2hH7Fgq8NmbEvGp/D4Z3HfvoFSBhg6GY1cWhe1Cl8r122AkziiEjQbN/BFNGWi0SZ51ptAK+OUq28OSe5gPRmULIS6LYOYdChbkl5yAZm6WyI2vtTUXhr7y2eCCbxmXYpnUFljPABBOlQ9gFPeiLkO/nOH8AFss03imMHaRQU3zyrKf113WuTzV+J3mx1/UNhbAwDLgL9gBkk5wLf8lISnoulE0SXax2U9A+8jz0Q6sn2TtkRpu1U/ohZGEmb5WCQ/1lIeB0G/easG0xrOiTJR9jgUxAmjkVAU6UvD+zskpgbhGA0S0Ve7Xq9E5aazDVXH6mLH+Ke5ItjaaaTig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rssg5By14zh8Wq19ELzqJ9Nq5Qpn7C2wW1f/XbIf8/c=;
 b=gZvM27eO3L8Q+yZc9TS6LWhQPimeL6B4HXsHT6H1nbrrRY4SUxZjJ62LWuPcEbbIb7b/LqDG4NME/93thBFRyoiDqUa+RnCb+X2DyW6tm5j92IT9l2ELq6nW9ZW1PwhKU8Kwtd62p0hw1NpqmU/k/L/oKyDuD63KzA3Nm8JLxlfY+lupnCzNPuc+PMo52ixYbaTdQw4eD9YN8lI3f43JffdZ5JrbnaAl9WGcvb2vDJcJkAJzZJLM04YVAB0ycguU4++cI3rtjbvAPE5yxRn1YNOMMU/O4jBcyFNdfSfGJGZYVm4u3r9/7DruY4Y1h7Me0X8q9VC3/VrF+uu+ReK1uA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rssg5By14zh8Wq19ELzqJ9Nq5Qpn7C2wW1f/XbIf8/c=;
 b=e5RwBI+PIwCuisTBvFyGL+hQXJa2qEEa3YFwfdbFaXmTfgQrnhwurUCfToo/9CdFEjdA9armeFBUx1uj6V4PJeNlgagEGacvZOlLeXAIAN+Aimiolb78tt17KWhX0kzrTAasOtLFEwTcxRTT9/QaQ1Xph8gww4D4xHexSdAQ8a0=
Date: Wed, 6 Apr 2022 15:36:49 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Message-ID: <Yk2XcUhUn0BYk3lA@Air-de-Roger>
References: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
 <d232b6bd-17d2-c78f-49e1-67ffc2502810@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d232b6bd-17d2-c78f-49e1-67ffc2502810@suse.com>
X-ClientProxiedBy: LO4P123CA0489.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 79a2cbbd-7fd6-48fd-a03d-08da17d283b1
X-MS-TrafficTypeDiagnostic: SN6PR03MB3789:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <SN6PR03MB37895CF25908E688CAD916FD8FE79@SN6PR03MB3789.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: J3KfN0YfIG5FlCHRt/FgspmWxJmVtTIPQvOLtNYG9durvz7B6EGqmg9gXdhEYQ+sqE9+VSJ9sUAROAKTa09S4JJVZVLtF68J5uQRUXrN5Kq1TcIN/WKxMVH8Jksk3gMipvwD8HaqlQv+eLrQXrpwPjKDguetKq2PMqX2QISEuDC+AB5C190JOd9G7HGSHGT2PH29lNH3aMOO89qawDoWJOGe4iHYvrMHRxWVs7bJQz2yKaoLiigUtmy8XJe6cSgPNBi5e4XU6CarJiTLcsrqxnMQcHIJs44F6UoYV4hclvglYndZ2GzQ08V9pSlon422a/3u7fptcCpcxDJzmzO0R86XoZ0oF8BtNDaadoDmyKrlnQ0BBY7SlAKJhI0A3peL/wb9UACMjbSHuCp+IZ4ziUj8zg8sFdwc/F7gq6nZULY5YamP3Pn4Bm5g6g6vCdcl6UjRhjfl3AnmxG8f2lKnm16X4HYFbNFRmNkwFx3vcHlnz1uWKu0kzgRYP3klRQUlPdWJvch+yMubqn5w2Rj4ClxwqBEZn6jpzl/pLqs0eMWaYFzGi4qeME/9HhDdm+kUTrnR3CED+KOgFzAGUI15+1Jq2jP83KMX++xeliMlMLgtuzoneO+bl9QRA6X0xsHPTLr82j/cdK3vBe0V5WRjPQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(6666004)(82960400001)(5660300002)(6512007)(8936002)(186003)(85182001)(38100700002)(26005)(6506007)(6916009)(9686003)(6486002)(54906003)(316002)(83380400001)(86362001)(4326008)(66476007)(508600001)(33716001)(66556008)(8676002)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzEzZjJ1Q0NzNklGOXR0STZ0YzNpdXJHeUFWV1JjTEZ4TzQ1WmJjajAvcVVE?=
 =?utf-8?B?MGZtQkM5eHlsdEFEZ3F5V0RJUVBhRzdkN2lsc2E5VXVEdVlDTlI3Qk9FdndV?=
 =?utf-8?B?WkNZcFg5RTFDQmh4TEo1aTF6RDB4dVlmLzhValpBYjQwSWprNjRyQm1EYVUr?=
 =?utf-8?B?TlNGTXM3cG1mOVFhNXJKdENCdzBRUFB5YVowNWtWSkZkdnJQMzl6SUEwYmh1?=
 =?utf-8?B?enZ1SHhaQ2Jzcm5LT2FLRjBXRW91TnptODNpRVg5d3Rxa1ppZ2Q1UUdLS01G?=
 =?utf-8?B?SkRuTlRsWXpRYzlYQmU4TDNaVzJ4bVloVXRXSWVUdUdoSytxamFMVzhHOUxk?=
 =?utf-8?B?SHhiTWVHTGJSNkR2aWVXUk9odG9YbVNvMGZKbHN4SnZpU3M3SlVyTGQwUHc0?=
 =?utf-8?B?YkY3RGx1V1ZjSlNLaEVYcjhsWEZqVjBoOVZEWjI2bjBzV0psRVdWNWFZcmwy?=
 =?utf-8?B?Q0ZNVTZsWHRpTTI3azV6SjBJUjFPRWRPSS90RW1sZjZ6TWNEL3pERGVBN0FJ?=
 =?utf-8?B?ZU1nMUp2SlFtc1QrYk83Skl0bTVtdWRsQkJmVUVCRWlSM2NyNXdJVGhqRkVl?=
 =?utf-8?B?Q2NtK1JQMzBQTysvaHRnbktBNmtHdEFxeVdnVlJXYXlWMGJjNHM0SzMwWHov?=
 =?utf-8?B?RHVVS3pXVFlZMk5sWVdsOFlDQ0Q4UXp0a0s0OEgrRnBLSUl1QVphRkVPcU1k?=
 =?utf-8?B?dTZkdmFOQmlRckpsQ2FhQ25leVAzQmN5b1Fua2xHSWs0Wkd6SFNhV21zelNL?=
 =?utf-8?B?QkJ1dHNhWFBHWjlqeU5EMGRVc2VwVjIxbjI2bE9ta3VueHNKYTlxT0ptVG04?=
 =?utf-8?B?Sm83TllZQy9CakE3ci9aanpWQ2kvelBoS0lFSkV2Wm96Qm8zTTFQSGFQR3o5?=
 =?utf-8?B?bHF2K1NISUUzTHE1amtnaVNtVHY4c2ZPQzBRRndCM3Y1TTA2WTB1L3MzaDJu?=
 =?utf-8?B?VkZLai9jSGNXYk16bWx6RVNXOGlLWlZjMU56dFJwRDZGWFRmdkdPcnN0YzMz?=
 =?utf-8?B?NWVIQk05NGVmTEEyU1FZNUN3T09NQktCRlJtVWkrenF1VUZNbnVnYktCcWV2?=
 =?utf-8?B?TkUrZFF6L0lzdjI3NUhlZGhyTjZzWVNzZDFubVM5TklIMm5mWEJRd1VwRlhm?=
 =?utf-8?B?aGFUS3MwcmU5MWlRTHQ0NUVacm1UdEMvRXYwVFlCRkJtTjNmcFNwemJmWFRx?=
 =?utf-8?B?MndTMThJZ1J4QzFuWG5paFFvNlFNaVBCNXFsQTIyRHVWRDUxQ2lhK2lGK2F5?=
 =?utf-8?B?RFE0SVdlVmFQVlBHTnVURnJDSmJ0NTcvZnRzUWY1bW5FNkxvNDl5NzJjRlFi?=
 =?utf-8?B?WnFOL1RRTUoyK2pESHNFMnZyYnpBeFF2eU1PYlhJTHhKYnBZTCtHc1hsUlV6?=
 =?utf-8?B?NkVTMUhVbGE0K1hFcGlWQm1YN2xZR0JYL3BQcjRYeHZlMnNUQkZJRXgxdHVp?=
 =?utf-8?B?QnhwL0JVVUl1SENtd0g3bmRhVE5zb2ludHpZdXpnT1lFVUZONStmRFFxdG4v?=
 =?utf-8?B?WHdBd3VjNDNDV292OC8yTjRTZHBJK1pGeldNU09PVVNzVDMyZ1BEa3g2RFI1?=
 =?utf-8?B?c2MrVUVkT2ZEeTE0cjcyOHcrVXdhU0thNDFMOUpUaDVpN1hIMmxSTU1IVW9j?=
 =?utf-8?B?Wlp2R2JCVGVDa2hWVTFsUlNzY04wVjJaYUV4dzZWOW9PaVhOTmNUWjh1bGpl?=
 =?utf-8?B?aWdhZFN0K0NpM1hzSzI4Z3MwOVgzNFRMeDJZNWp0TXlHbzF3WGlmVEhJeVlO?=
 =?utf-8?B?V2xKckRHaUZsVXRxcGJ2RGI0NmlqZVhHMWNBVk84bDBjRHp3TU96Q1Frd3Vy?=
 =?utf-8?B?U2dDYU1sTXRic25xdmJxdjlBOVB1L2I4bWhJMS9nZVVrUWcxYTQ5S1dIWXl2?=
 =?utf-8?B?d0szNHZvekw4Z0Njc0g0Uko0VW93VkRlY2l1b3lkWVdsQTNLMEhwN1hDTGFQ?=
 =?utf-8?B?azdpS0xETG5NWnhURXEzM0lvdWNkU0hZVWl5QS9aZUFGb3BMVDdsaUJEamNa?=
 =?utf-8?B?aVRCSHVUa2FxeUF3K3dQV2p5U3lRcjVIeHVnTG5aZEs3aVZDU3ptWklTQ3hG?=
 =?utf-8?B?elU1MzBXWlZQSS9sZG5ZSVBNT2U3b3ZheXJUekIvNGlwNGhHY1FMSVRtSFdu?=
 =?utf-8?B?K1VmcFgvS3ovZ2NqOW5DRzUwRm94bVN1MU5KL05mRFBQSk5Qc1lDNDB2Z0pE?=
 =?utf-8?B?MFVLWWtmK0JsbWRzNlUyVnJKclR0K1JMRElKRzNjZDN2R3NaMzlJTzdhM2h2?=
 =?utf-8?B?WEY4am15K2MzMzFuOXkzY3VIQ2x6S25vd2VqVXVhcUdQNy81STdOY2pYWExs?=
 =?utf-8?B?dS85NmNORVFvelU0aDN6YWVUSjlrMko1YVRmU3RIYkk4RVRheGR2SDZ2d28r?=
 =?utf-8?Q?NROGi4BdKVApr7Qg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 79a2cbbd-7fd6-48fd-a03d-08da17d283b1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 13:36:54.7467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zf6vV3nZV0zuHitN5tg4dPaCv9/415Ojfz17PZUwY3HLmRSz3zetwwrrcrQPOX+gOJVfMBY8pSm94r/S54MMew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3789
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 02:24:32PM +0200, Jan Beulich wrote:
> First there's a printk() which actually wrongly uses pdev in the first
> place: We want to log the coordinates of the (perhaps fake) device
> acted upon, which may not be pdev.
> 
> Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
> device quarantine page tables (part I)") to add a domid_t parameter to
> domain_context_unmap_one(): It's only used to pass back here via
> me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again.
> 
> Finally there's the invocation of domain_context_mapping_one(), which
> needs to be passed the correct domain ID. Avoid taking that path when
> pdev is NULL and the quarantine state is what would need restoring to.
> This means we can't security-support PCI devices with RMRRs (if such
> exist in practice) any longer.
> 
> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
> Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quarantining")
> Coverity ID: 1503784
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -750,6 +750,10 @@ However, this feature can still confer s
>  when used to remove drivers and backends from domain 0
>  (i.e., Driver Domains).
>  
> +On VT-d (Intel hardware) passing through plain PCI (or PCI-X) devices
> +when they have associated Reserved Memory Regions (RMRRs)
> +is not security supported, if such a combination exists in the first place.

Hm, I think this could be confusing from a user PoV.  It's my
understanding you want to differentiate between DEV_TYPE_PCIe_ENDPOINT
and DEV_TYPE_PCI device types, so maybe we could use:

"On VT-d (Intel hardware) passing through non PCI Express devices with
associated Reserved Memory Regions (RMRRs) is not supported."

AFAICT domain_context_mapping will already prevent this from happening
by returning -EOPNOTSUPP (see the DEV_TYPE_PCI case handling).

>  ### x86/Multiple IOREQ servers
>  
>  An IOREQ server provides emulated devices to HVM and PVH guests.
> --- a/xen/drivers/passthrough/vtd/extern.h
> +++ b/xen/drivers/passthrough/vtd/extern.h
> @@ -85,7 +85,7 @@ int domain_context_mapping_one(struct do
>                                 const struct pci_dev *pdev, domid_t domid,
>                                 paddr_t pgd_maddr, unsigned int mode);
>  int domain_context_unmap_one(struct domain *domain, struct vtd_iommu *iommu,
> -                             uint8_t bus, uint8_t devfn, domid_t domid);
> +                             uint8_t bus, uint8_t devfn);
>  int cf_check intel_iommu_get_reserved_device_memory(
>      iommu_grdm_t *func, void *ctxt);
>  
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -1533,7 +1533,7 @@ int domain_context_mapping_one(
>                  check_cleanup_domid_map(domain, pdev, iommu);
>              printk(XENLOG_ERR
>                     "%pp: unexpected context entry %016lx_%016lx (expected %016lx_%016lx)\n",
> -                   &PCI_SBDF3(pdev->seg, pdev->bus, devfn),
> +                   &PCI_SBDF3(seg, bus, devfn),
>                     (uint64_t)(res >> 64), (uint64_t)res,
>                     (uint64_t)(old >> 64), (uint64_t)old);
>              rc = -EILSEQ;
> @@ -1601,9 +1601,13 @@ int domain_context_mapping_one(
>  
>      if ( rc )
>      {
> -        if ( !prev_dom )
> -            ret = domain_context_unmap_one(domain, iommu, bus, devfn,
> -                                           DEVICE_DOMID(domain, pdev));
> +        if ( !prev_dom ||
> +             /*
> +              * Unmapping here means PCI devices with RMRRs (if such exist)
> +              * will cause problems if such a region was actually accessed.
> +              */
> +             (prev_dom == dom_io && !pdev) )

Maybe I'm reading this wrong, but plain PCI devices with RMRRs are
only allowed to be assigned to the hardware domain, and won't be able
to be reassigned afterwards.  It would be fine to unmap
unconditionally if !prev_dom or !pdev?  As calls with !pdev only
happening for phantom functions or bridge devices.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 13:45:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 13:45:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299895.511196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5xy-0005gU-Ls; Wed, 06 Apr 2022 13:44:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299895.511196; Wed, 06 Apr 2022 13:44:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc5xy-0005gN-Ir; Wed, 06 Apr 2022 13:44:58 +0000
Received: by outflank-mailman (input) for mailman id 299895;
 Wed, 06 Apr 2022 13:44:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc5xw-0005gH-Lg
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 13:44:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bd8dc0cb-b5af-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 15:44:54 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-J9wOXHFeMgimVhxkrUGLGQ-1; Wed, 06 Apr 2022 15:44:51 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 13:44:47 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 13:44:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd8dc0cb-b5af-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649252695;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=heBKlj06CTYVGHNsPSMUURzlVSPp71oReOj5mYLKT1s=;
	b=AMLiMa/XN5hzz/KtF0ZS0uA0WhLk6E2RN6F+iqsQ0VaQ/jGr3KpRlxyxWQzf1H+nv09SvP
	DqywAkAZNTbeN9YLejX7BEiZaOVByVe6dtsr0REBgLzidve9JTHoftuNKUSzcJCrJ5YUiC
	Q68uwYaNVCwbid0GP4AmET1vL1Ryt6o=
X-MC-Unique: J9wOXHFeMgimVhxkrUGLGQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OkNmUGHNjYX74gs/hM94nfUoKIce2VCDgqMYDi7heq/cjsmJO1W8TMmePu6cS6yrp+0wNtQTT956VLLsDhN6AMrF4wx6rEuyUT4Jiq/KcnrGawLmGSodHYOQ6njXvk6IXuHLba8gl7IKguF4MfLS2lLZxcePG4gS4qnSbVluKoBTGeGcIMvbI9MQvKbL/8amUqvL8589n/mb864+kAuRXf8fpOAbYAn67MZ4xIE8cH58wXfELG+DHaGM1onFLY1eyLtF3f4Di77HAWsgLikPmODhULHwCnlUY6qgyv/RS5joO2FhlkpuQdKHsHryFg9GGFcTsx5p2plMFJc521P1cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=heBKlj06CTYVGHNsPSMUURzlVSPp71oReOj5mYLKT1s=;
 b=Ae+uqry6Jiz8vLHDpKR1g6QfM/EAkNXhe7taimV+MNcAZodywOXgOfJkkVclXj2YXpMJTIe22ObJRPpSfH/7JlNrNrvnYIokdlJLE6Ia/yDTxADIHLr4ML0DjHAU8ZRh2KsLQErzofXsUva/l2cEELZlqVc2oEaqK4Feq5QgK3qGHw/Eh5WNmf0Y83v6dwx877VLHWWJCpXcCXZDZmMOoO5AIaqfXBoeHo9cbb4b/nuEK1mHpl+klG4tNMk2ySwewhm90X3nc5MtdUjwOKeUVYqSSmCzAV8eZtrXxAxpP3mopql7aFMZOpXsIfJ2YQd6Cszx3VAxWnbp2w+NA3v4Ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a389ee0d-6b2c-22bd-1004-99f79ad5f301@suse.com>
Date: Wed, 6 Apr 2022 15:44:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v9 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Content-Language: en-US
To: Jane Malalane <jane.malalane@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-3-jane.malalane@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220401104713.22291-3-jane.malalane@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0126.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: afa18fe6-3765-4d40-90ff-08da17d39d7b
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3517:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB35171D0CBB8887DB0A63CEC0B3E79@VI1PR0402MB3517.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eGm4z5fU1HyigS0wu6TSc6HxicyH2NgH7AOq9vvyFjVa51quvv8/ZtwzLk40/q53xSoNHBhqxflev9ZR4nnjqoaUyLnMyH4O1bXsvNE7u21vno3H3GISrAlfx71/WzKWcRLWoVB+wI+xdSZwkmNBqzlTnKtU97sZOv8vNcCPvHAI/98Fn/RILn+m7FrqTKgaVJPkeMol6gFrQL/mBQFxtVnb/Axh7osdyDnPfdz/zDArUIAi94Hpg1wu6aWBeZQNUEiHLaRvi2UOtyMMBilsP8Ln8GhMrqRNN/COBvoC+B0pYE1RQCJ0FxgYSO/fFY2tl2lK7aSajUeyWKaw46HnrZUWv5Us8QhuwldvHlgDBH2BVm4I3LitvgNcxiCohVytks09Rif9FIYFS+P4IHJfcghjl3fm8P2hh6r71/e8VB4AiXL5JTJrf+DufpZ6nWt9dKZmRkrQBssB6Yy1Dj89LSitwXX1o2DvKqWFvxabh+orqDbGDqt08T/CyCPdUYU9IXf+E+jQZrWPeYynBZsZzUjxpXxbeh0W2LStxc+kEZrAGcotv5OHgnPFZ0TAa7W0RWpfiJT47c9RImONrODJ/EVmdbpj/KjtZlQ/7pnCIKeOGN/qi3iGPJpT3sXnUJqvqQsrdd90yvldljXv93icLY+n365ml8vm3xy8YtcpzD0kqB8HEszwSt97aqbBdkjyw04Zx3ynuG3RWir0ovKNpuSVv3LuN69hCjm8xyw3PICynzx071gsRMJ4Iejp0inV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(6486002)(8936002)(31696002)(86362001)(6506007)(36756003)(508600001)(31686004)(2616005)(5660300002)(66946007)(2906002)(186003)(6916009)(54906003)(26005)(8676002)(83380400001)(6666004)(6512007)(316002)(4326008)(66476007)(66556008)(53546011)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eFVMVnROYmxadlBuWXVTcW1pZnArZjdoTkdPbE1VeDRxMzlYNmFCdXRFWisy?=
 =?utf-8?B?Q0FXY1NESHFFRmlxK2kxYkNBdGJsQXducHFERCtXQXIrd1dROXhTWWprNmIz?=
 =?utf-8?B?c2l5V3pidHQ4Nk05Nzh0SkhnYWRjb0tmZzhXYXo0Y2hhdzk0VWZxWFZlcys1?=
 =?utf-8?B?NHBoZksrSUlVRDg4bzE4TTBIcFlFaTYvL2EyM2tjazAyNDFDL2ZFbythZ0dy?=
 =?utf-8?B?N2w4empoT3I0V2R4NEJ6clN3Z1YzR1BMT1k3Qm9BV3p5aHUyNy9oVkZhazEx?=
 =?utf-8?B?WWFWQkRsZlc3ZUQ0b0JzRzl5UmZlWWpMT05yWkZFNmtQd1ZsYmE1VGIxVFpE?=
 =?utf-8?B?MXdNUTlvZmZCWmdlK0xhTHBmYmVtcnp3b2hvVnU2MHpXaWJlR3dleElucjho?=
 =?utf-8?B?MGZMenNTcmhTb2N4ZEozM1d2MWJESHlxNWZlTHVuNlBtZTdtbldUQkM1djJZ?=
 =?utf-8?B?UHFvS0hKWDkrcFFUU3JzdHdHNzBoSGdUWjdwWjBZYklOWUJhdHpDMk5hdmlT?=
 =?utf-8?B?Y3J3Q1JHUlU2NWN5STU1dnNDbE1qazMyeWJaU0FRWjgrNXo0b3gyU2xYQ3Bj?=
 =?utf-8?B?S1lDaG1STEZpQ25EMjlEd2xBblQxU2FDREd2enhJRElhMSswMDJWQm1pcElS?=
 =?utf-8?B?R0twZ3NWTnp1KzkxSUwwTVV2UGF5cWF4SWFNd2tJMkl6dzI3NUYzL2lXSFhl?=
 =?utf-8?B?M0RKNHlCM2dSLzJlcWNFd0trMGo0bTJjNFlVVFliMFYxbE56aEhCZ1NKOUdW?=
 =?utf-8?B?a2hoTFp6Nm5DMzZhNC9GUmhZYit5N0JIZy9QQkpRdUJaYi9Lcm43NmpOTmd1?=
 =?utf-8?B?alNjNmNNN3FoaC9GcUZIZXREdjJQYXZubkpZUDBLeVNGcENoYm9YZlp6TTZk?=
 =?utf-8?B?UlUrTUlFRG9UYm00SGhlbmUyT0NqYWFZa2o5dVBSYnhkVHBlRWJmNW5UQzZL?=
 =?utf-8?B?NnpOZS9yVndPV3J5WEwzdlFrVWxrTmVFclRCV0syZkluQ2RJUVd2TnR3K2cx?=
 =?utf-8?B?ZEIrVzFqUXNpc3g3S3pEby96WTVkV0tpSHBVL0lnUzRjRGZReFhnb0xXNlpX?=
 =?utf-8?B?V3hlYjBKbkRoR1YvUVdWTVg2T08va05aSkJ4QlJ4VTJHcTJvSTF5VzFNZTJC?=
 =?utf-8?B?akZjWURKaHIrR3E0ZnRHa250UnJ5NlRpdTFtdko2N092VzF1YmxXUVFKTjZP?=
 =?utf-8?B?c3dScWhMZlZpVnpPZy9aTExpTHAvNVNpSU5zaUxwU2NaQjFRdUhxTENoTG50?=
 =?utf-8?B?OTRicU1td29BR25zMzdtS0dBQWM5SkJOQjhJSzNYSWlvQ3F5N214V2NrbWxB?=
 =?utf-8?B?Zk1BRm0zSGROZGp1cjd3bHFtWmkxbGEzSTBHZExhS0FXT0hRazZrRHlnVUIw?=
 =?utf-8?B?ajNUVlQ2NWdiVEUzcmpON1U0RnIraG9Dek42ZmMxeEszNHdHSy9hbXRpSE5k?=
 =?utf-8?B?WjIyTUZTd3Z3MzludU1reTFXQWlzSGUyMXVwWVpvTHJCZGZNSkMrRGk3RmtI?=
 =?utf-8?B?RDJDdmpmYUpqUUxzQndMMk1sRDNUNHhTMXJyZmFaOUUzd0ZIMUs3RXVWZ3hL?=
 =?utf-8?B?OThnTWQ1OFlKZFF2RmhIeHNFL1ovRWtQSWl1cGhycm5uR0hEWVc4anRiNGdv?=
 =?utf-8?B?SmVpM1R2MXB6R1FGbkxHVlYvOTJuY0c4VlB2cnh5dWZneHFkTVZkSWVCcnBh?=
 =?utf-8?B?OUVpL3BYZDBYaUpTeXdUN3VvUmJYSnBJc2lWd1VEYXp6NmJQTlI5eVhkZjFL?=
 =?utf-8?B?bUVRRFhwZFVjRi9EUjdlR1R1SEJ6b1RDQ2pSTGhFVndCdWpCL2YyRFBEYnVJ?=
 =?utf-8?B?VnEyVGxMUWdLc0ZmRVJQVTcwbVZlejJsR0tqVENnM1Z6eWZmbXpybHZkWVpL?=
 =?utf-8?B?UyttdHVKa0VtWENkRUF2OXBZdnpta0tnNkd4YWI0SVRZU1lvZGpFeUhPcEpT?=
 =?utf-8?B?c0piOFFwcEI4STdqR3lud0c0Si9TOWlMT0w5VlZxZ3ZRZVJxZHJkUnpGQ00y?=
 =?utf-8?B?R2NBTjdGK08wQTZoQ1Y2dkNocDVwZ20xTmFNRUxyS1B6QW51U1g5cXJqcFBU?=
 =?utf-8?B?WU9EZ2RCTnBXUk1zNHM5Ukp3bzFRU2lydm5rcUxYMlZ2UDZsNzRMOTlURVhJ?=
 =?utf-8?B?WmhIRWdYQi9yUFN0aitXWkZhd040WklJUkRVaWhEV2pyTHpYMm9pYXR0TThz?=
 =?utf-8?B?QlFqSTZqdDRHdlJrd3AzODZBMDZKRGptSnNGRWRrMDZabnp5c3hrNUNJOW5j?=
 =?utf-8?B?QWVmTnNJTkJPMzdocm5sa3dwTUo3RVI4cDNxY3Q2UmkwVUFnWXVTTFdTeEFE?=
 =?utf-8?B?M3YwalYvdVo4YVNhNysxUFhaV1NiQVg4eVpiM3paN2tiVGNpc0RzZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: afa18fe6-3765-4d40-90ff-08da17d39d7b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 13:44:47.5724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oy9g3S1/4VQtLB/rYElBaWX31SmYwfK8BD/d8wDJBzZMSjsMmK9YTMZurRFqWw6C7aNdkT/AsI7ePt9psx5iPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3517

On 01.04.2022 12:47, Jane Malalane wrote:
> Introduce a new per-domain creation x86 specific flag to
> select whether hardware assisted virtualization should be used for
> x{2}APIC.
> 
> A per-domain option is added to xl in order to select the usage of
> x{2}APIC hardware assisted virtualization, as well as a global
> configuration option.
> 
> Having all APIC interaction exit to Xen for emulation is slow and can
> induce much overhead. Hardware can speed up x{2}APIC by decoding the
> APIC access and providing a VM exit with a more specific exit reason
> than a regular EPT fault or by altogether avoiding a VM exit.
> 
> On the other hand, being able to disable x{2}APIC hardware assisted
> virtualization can be useful for testing and debugging purposes.
> 
> Note:
> 
> - vmx_install_vlapic_mapping doesn't require modifications regardless
> of whether the guest has "Virtualize APIC accesses" enabled or not,
> i.e., setting the APIC_ACCESS_ADDR VMCS field is fine so long as
> virtualize_apic_accesses is supported by the CPU.
> 
> - Both per-domain and global assisted_x{2}apic options are not part of
> the migration stream, unless explicitly set in the configuration file,
> so it is safe to migrate a guest that doesn't have assisted_x{2}apic
> set in its config file between hosts that have different support for
> hardware assisted x{2}APIC virtualization.

While I can agree this is the case as far as your changes are concerned,
it reads as if this was a broader statement. Since hypervisor CPUID leaf
contents can change across such a migration (which is pre-existing
behavior), I'm not convinced the statement is generally applicable.

> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com> # hypervisor

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:04:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:04:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299900.511207 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6GK-0008Ke-CK; Wed, 06 Apr 2022 14:03:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299900.511207; Wed, 06 Apr 2022 14:03:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6GK-0008KX-8s; Wed, 06 Apr 2022 14:03:56 +0000
Received: by outflank-mailman (input) for mailman id 299900;
 Wed, 06 Apr 2022 14:03:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc6GJ-0008KR-Gg
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:03:55 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 566f73f3-b5b2-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 16:03:31 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 566f73f3-b5b2-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649253812;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Mu4E1vEqUztEUpqJRZk6zrfmukxQXpT597vDR6Yc47s=;
  b=T0FwRewHhtVXSOMYbPYI+QjmgtrEhDk8oyOMPhyZxlQ5hIfjPZJzFkfb
   Pba5XXc2sKd+o6bzK/1liME2UcO975LSKTsAH0Enhpy8j+dYSr883qmIj
   AOguIFYTzbqL1t6FtOtmV318dMmoA44WsUG0v/xcmTPPGzBlSLhyoT3+z
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68158191
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LdiyfajgcP3Pp0u5GNQAjmW0X161TxAKZh0ujC45NGQN5FlHY01je
 htvXGHUM6qIYWXzeohwOYzg9kkFvMDTxtI2HgVt+3wzRS4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vT4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQ4vAILeo/4vbzl3NQwnIat5+aHiAXfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiOP
 pdJMGs2BPjGSzdgOWgmU4gup7+52n7ccn55rAiMpJNitgA/yyQuieOwYbI5YOeiRshLn0Deu
 mPP+Uz4BA0XMJqUzj/t2mqlm+vnjS79HoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRol6zXZdTJ
 lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEeTDoU+
 U2yheHVJRNJneSJT02c6JK0ombnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn
 W3TxMQqr/BK1JNQif3nlbzSq2j0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU
 ZVtpiR/0AzsJczV/MBuaL9UdF1M2xpjGGeC6bKIN8N8nwlBA1b5IehtDMhWfS+FyPosdz7ze
 1P0sghM/pJVN3bCRfYpP9PoW5h6nfiwSo+NuhXogjxmOMYZmOivpn8GWKJt9zq1zBhEfV8XZ
 /93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92
 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1OQzh7UaKOmO9/IOSIXc19z4/1w
 510YWcBoHLXjnzbMwSaLHdlbbLkR5FkqnwneycrOD6VN7ILO+5DMI93m0MLQIQa
IronPort-HdrOrdr: A9a23:KRfB/qurFXpm5QUu9QDq17z07skDFdV00zEX/kB9WHVpm62j9/
 xG+c5x6faaslsssR0b8+xoW5PgfZqjz/FICOAqVN+ftWLd1FdAQrsN0bff
X-IronPort-AV: E=Sophos;i="5.90,239,1643691600"; 
   d="scan'208";a="68158191"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SVnekTLE4YCIYsQ50hF43UiqanNbROUiFGflaBgcc1FgFfWIclEv2q/F5D1C4qY2VpY5O/0dkIE/6clAoEbJQSJ/9FHN0cfrPQQLm2844gDm8z8mx6GxpXSZokxcg2tLFleozPhKA+IfOGdYmRr9HIzdn8KtwFFnETOZzr89OVoFa2KPJaA6jiP/N+QvEdkNn8//IpvqaoX8vNa1qtzxi5ot2OEVA/PWDwcl1uG39WcOqvcG6iLAJEi4s2pKDSApwhHrQCr9WQYY1x4+G5rlBqlgQ/uOUYuEgusVtO45ejGdvugNqvlWizRHTUnulRmo380dIti1hulw4QPNRrt40Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KkmkANuBOeSe67zXP4NdiqNnGLrAzAMvd1p3Tvzy/zc=;
 b=n7ZKajFpEQHXGuR3qGd38atssBPa/gf0Vv8hVJzuLq//kWgLv7UWOcuLLXLWuJYrWlx+VPg72O9d0JB+aB3EAZ6WXHNsRMvcpFwEV7BYg3TBl7oSlbe3T+xD3UkqnUhg4gTySSeAsxgtg04/VnNF0Zk+AY1xjOnAjTmnNstxT2lvmuIofuF/VbKGLSFxJnIwr9eT9px4a/FO5TQXQN4b9syZZPWXuF4FI32Mhj1NN4P8SKy5WL/2xaSQv7354UEJYLkg/15LtF8D5NaMwfQBWFZkCZezsFwZbomcMlNncGJ2GN2X/6QHufHgFx8GyNVosjnKben1aMMH2gSUpift1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KkmkANuBOeSe67zXP4NdiqNnGLrAzAMvd1p3Tvzy/zc=;
 b=Ddo76LQ1wOD8jibZ1Zv0QHL8EQW6Bhbfsd9dfiIx5RkZ/6cpll9dcLZPtcUVRrKzCVhjRd8JriDFh9reURZGg00kjMAkWJe+vQNyVkTVN2cm+mT/3z3ULqZL9K/J34AYAFSbEx+Sar0Td+sM+k/dkzyL4mp5TQggB2MoNxOr2eo=
Date: Wed, 6 Apr 2022 16:03:11 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Kevin
 Tian" <kevin.tian@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	"Paul Durrant" <paul@xen.org>
Subject: Re: [PATCH 2/2] VT-d: avoid infinite recursion on
 domain_context_mapping_one() error path
Message-ID: <Yk2dnzI4WSm1xMdP@Air-de-Roger>
References: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
 <535d1050-e5e0-6e1f-5299-f41b84350ca0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <535d1050-e5e0-6e1f-5299-f41b84350ca0@suse.com>
X-ClientProxiedBy: LO4P123CA0138.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f8e1bb7e-a789-4735-e48c-08da17d63736
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5807:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <SJ0PR03MB5807BE1AD976B943EBC8031C8FE79@SJ0PR03MB5807.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CbEnRFaeH88Akv+4WEFMcJEZpyhmG1rg85rKIhPgRHeDQESPIhVOftFjoFV0zrOtc1g+VPWi7K6mgJVb7Es4XYPH2y4xDHT3iMLTku5rH8JPvfhYzQ31J2+EWF2JYoFxTvbXvZGjZI+rR3CnzAKgt6aP6kyiMrnPRpRoyVQTKG76JSZ7VAgCrPqovl198u8sUFO8TKI6Z4VyPpnwVBqaxVrcgZaVBFtNcfUpw3t1mqV3iN4uCJ/Td83x3ycO6QQPpNjvgcobKOeGjuBWjN44rzGHyVJevC2rZzbn5UOYLEHhGWqAvajVTUPiED4EzhoGN033O5RZAg/197I5HvwsmwstkoyAr6WQLCZKKI165cjGM4CIvpJP0C4pj4gWnvBvxlRe9qvHq7KwDiVw5JxUJ6RcEGmgLdKzYnuNW6/ykNPh3BsfUQo/stdLNRFscD5CKWH+2xnC6N0hg4d/0mEL9c4gFBOIiAXYMk41Kpe0ANlq2U55Y+moiS9vOlo4Mjc9Ii4a61gVqTVtgNqj/lyhdou3XhjcwuHT9+ibvRVPcGMnxIMi5r8c0eZsS/Fp+Xt8X7pGvwGbTACkATQ1PyuCdQAU0xc7Y1YzK1JkwTJLg6mfCTalVet4J3iUcxjwX7LxrfODT1u21r/XuvQG9uzheg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8936002)(82960400001)(5660300002)(316002)(4744005)(38100700002)(54906003)(6916009)(186003)(26005)(508600001)(6666004)(6506007)(9686003)(6512007)(6486002)(66476007)(8676002)(83380400001)(66556008)(66946007)(4326008)(85182001)(2906002)(86362001)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2YrQ05YekF4T0taeFNZTitlaTVKWnRXdFBQemJXOTFKT1drc1c5TTYzY3dy?=
 =?utf-8?B?Vm54QUpXV0lRcTVDMk5mMnZSeGYxdU1KTy9lWXUyYXpvY3YyTS9hVVM0NXZs?=
 =?utf-8?B?eDVLdWlqUDl6T083MHZ0Nko4Uit0V1luYk1KbStHUjNocUdpSUZPMmZHUEw2?=
 =?utf-8?B?cFhXcERiakltV05yZ3NWNjJrVmZrUy9nWTFjMEtvM2VaSVNSbkFjeHZhK2Fw?=
 =?utf-8?B?MTZReGg3NlV1WGd4QURqMkFISVNiWnB1clQ3K0xoUlA4T0JpUFlrMzYxMFJZ?=
 =?utf-8?B?VHllM1A3RDZLV3lxcEl4TmpQSXFDWTFEWkVyWlZReDJlbnlsNlVTSVZBenZX?=
 =?utf-8?B?VFF6bllpOHNPOWZnOUM5eS9wTkxqRkdWODRSZ3UvZndUL2gwaGtpMm1najl0?=
 =?utf-8?B?RHhjWEpRTEUvTUc4dm8zb3A5SGk0QUJJSVl5aDJaZHlJQ0FWbitFSWYvMnpH?=
 =?utf-8?B?ZFFJdE14c3pYQVNmYW15NVQyeXpLOU45WHQrMTFkK0VGOGl2SDN4MHp0ZGI4?=
 =?utf-8?B?ay9SYTJKQXlFeXhhS0dyT2tyS2MvOThjV1I3dGw5Y0UyUXdZV20rYXFRRFM1?=
 =?utf-8?B?NllyNkdsSnpjcGNvei9sNlFkS09vY2RtbXB2TFZDMFF0aXl0M2VUM044MUtn?=
 =?utf-8?B?bXE0MXNQUVRJaGZOWGJYQWRteEtzWElBZUp1djNGLzVSZ1owc2NtV1ZwWkEz?=
 =?utf-8?B?V3FTUHVCZzAyZFd6MkhSbEpyQmpyYmxxTDJLU2RsRVA1VlhJZXBsNUsxclQw?=
 =?utf-8?B?Q0s5dVhObWRyQm50MjRLb0JYa3lPOENwUmdBRGVIc1ljQW9ma1FSMGtWb0hv?=
 =?utf-8?B?KytEVWkrVTI2QUtCd2puNTY1aGtsZXJjTG5FWWlVNE1kc2o3MFFEbFowOTlz?=
 =?utf-8?B?U2laZ1VjZjNIL3BXMXVlZk1rRmE5UGxLNGNIWWxZRGVsdGRjQ1NiY2hIcVpt?=
 =?utf-8?B?ZnNJVW04TGliaFJZSUIxRnRlbUNkeGZnYStQU1BxTnVZWFB3eFk4Nm9yUVkz?=
 =?utf-8?B?ajZIV01ETjRoSFdxL3lBWEpzRWNVSmc5UlBENFlkUWp3RlRIVHg5VCtjZFNJ?=
 =?utf-8?B?aEZEWCtnV2RmL3lmQ1Q0TS9MajBZdzg4V3V1WnVQbGhQZG0yMmlzQWtGNWFN?=
 =?utf-8?B?VTArdmJielNjL1BOMU41YWVwZDB0NSszQ0R6VGhWOGNkdm1YVitCcjZWbG5H?=
 =?utf-8?B?WVIxQ0RkRGJpTG9UaHloVmJZaXhob3J2ZjdsNFNFblZwR0R0dUdMMlBsTjJP?=
 =?utf-8?B?UUE5QzJSMWQrZ0ZZdU0zM0VHbGVGaThSelJ3NUNYdGk1MDRJYmtLdHp4SWFh?=
 =?utf-8?B?Y1JHa1VrYWtrMVN1enhmVjFSWC9iVUNYdmthdHJkckVwYjduRkVZZ2l3MlBz?=
 =?utf-8?B?ZEdEMURZRlFPTzdxVWhKRGVFbjI4YmJvcnI2aWdUbHNzUDJTWURLeEFVYloz?=
 =?utf-8?B?QUxDdngxOHBiOVlQRnFMM1Axa2lxUVNkQzQrTGxhQW9BZi83amJQRnREYW5D?=
 =?utf-8?B?bXBsMXdQM2NSYjg3cndPK3M5dWZKdENNTW0reExsT1FPNTZsdzRBM2JCZkRa?=
 =?utf-8?B?MkpyeWNSWmJmTkhCT3hGY1ptSUZFT0czRC82VUYwZWs1Si81OG9rQW1zQVNx?=
 =?utf-8?B?MU5kSHFzZ1hQUlhISEp2RU9lSHNKUjJqeTRoT3RreStZUEFkbzBGQ0NvWU1n?=
 =?utf-8?B?YXZIR1gvZmo3Y2FJeWFvQ2Q1WWNPcFl5eFpwQ3pFazJmUE94UnE1aHJyR0dZ?=
 =?utf-8?B?SjY5ZUZ4OEg5NEVvTVFRL0xLOGZpNGJqeVRjK3pkR3AxaUp5RGFIYTMvWERN?=
 =?utf-8?B?N0JBdVQ3bDEzYXd2UnJ5eUVaK2dYWFZ6bzNTdWlqdzBxMzZFejlTaGxzd05j?=
 =?utf-8?B?WVlua0Nhb3dGRWRxaEV1clN4T3Rmb2g0MkpUYkNZd0sxMmFBZElVM0hvRHBL?=
 =?utf-8?B?dE9wTkhGa1UrMnAybU56MlB2KzB4MVdMTzYvNDV0dmI1LzA3aXJFN0l2K2c1?=
 =?utf-8?B?eFV5bHduZ2tyWGpwK3MveVlRTFRmeVhtSkdobW5LcDJyS3hvMEYxdFFiZVJa?=
 =?utf-8?B?elNsajVZZVovS2FOOTUxV2psTmg2MlA3VTFRNGkyY1hSZm5TTVVHZzc0WUpi?=
 =?utf-8?B?MFdCSVF5eE1YMVFwalNzeEhzWlVKZ2E2VEYzbFFDdmhWbUliWXY0N0c0bFNB?=
 =?utf-8?B?d2lqVG0xemZDVGgvTTZpUjdoU1N6cFhFM0VDWW4vakxmWFBteGQyMlVudkZq?=
 =?utf-8?B?L2hpdVY2SERDK3JZbFpwVWRzQjVVRThqSklBWGdMcmYxN3c2SExyU1JxMlMv?=
 =?utf-8?B?SDVhNFdIbno5M2w5dytXZTBsUzdTOWdLbFM3akxUdldlNTE1eExaWGorRFpr?=
 =?utf-8?Q?u+ifQr3qkFXpdbr8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f8e1bb7e-a789-4735-e48c-08da17d63736
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:03:24.4068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jspmxtv6hvOT/zAR2lbKXUdt58XNLb3A3Vi7RMoktQ2pwi1KxcWwp3QkvohBcwzYGN9dF4NqcJqKcUNoJ4Z8PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5807
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 02:25:13PM +0200, Jan Beulich wrote:
> Despite the comment there infinite recursion was still possible, by
> flip-flopping between two domains. This is because prev_dom is derived
> from the DID found in the context entry, which was already updated by
> the time error recovery is invoked. Simply introduce yet another mode
> flag to detect the situation and cancel further recursion attempts.
> 
> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:07:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299905.511218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6Jp-0000WY-SQ; Wed, 06 Apr 2022 14:07:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299905.511218; Wed, 06 Apr 2022 14:07:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6Jp-0000WR-P3; Wed, 06 Apr 2022 14:07:33 +0000
Received: by outflank-mailman (input) for mailman id 299905;
 Wed, 06 Apr 2022 14:07:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc6Jo-0000WE-CP
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:07:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e5ea19ae-b5b2-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 16:07:31 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-Ym77vU_qMdWEBj7YMIHIhQ-1; Wed, 06 Apr 2022 16:07:29 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0401MB2474.eurprd04.prod.outlook.com (2603:10a6:3:81::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 14:07:27 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 14:07:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5ea19ae-b5b2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649254050;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=E5bh+ey1Rw5u5rRXtK5jEsLHmYFwyFby8P88zX/4yGM=;
	b=LUX0n8+GoiSROzmUhCBL/Y9BCrhz5UxA6YUf8paizKEx6WPCIdZx3cv7gnU/Op1a5lTpJJ
	cLrgIVTfvsjk47ffRSGQPlw8DIB7+0NsNfvALfYIOJKMVa2JGgq9BZXDCxtsUARp5drIfG
	OlYgzq/KGVT443fSeQt/nUcg/5zxyV0=
X-MC-Unique: Ym77vU_qMdWEBj7YMIHIhQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SBKrbYFWsHpQmOCn7fADLUaAnCxIHLbKKNt51mUedXHrpB0m1l7BIW2PoTW8FqdeWsRQZO+dfmA0FWAsB77ihEpqe7tK6+wmcdbPxhf/dXaZJHw28oEqDgLkSgAe5Wo7RE5znkgEjeqRaO+IgqsYm/xB3zXa2d9Lb5k7+cckmWk4/wRuUFW/GtYU8JadH7XwKNHOQ6E5tU+W8aRxnlme6SNfg+WndmB9HdB06mxTkxVIPtVxfPYkYGLWmLtJVQJ35aa2+Ss3jkY/ISbhJRUBcGkHHs5RB3MAL1mSlYyRL/EhHMTwq57YD7Fhhm/JRePnWYjfG/PgRhj7dhHWtKGZzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GI6es+cDM5BD7wofvnJq9gfMD7EOKxjxaWmlkahmBHY=;
 b=AKsRdr0paUsm8b7F8NNUggOJkn/935wpuIesekO78kbYUEyDzOwN5WSN4+fmFqivCtLryZBMdV+V/KgkpzmekxIF6yVAZ1/k8+/r7PH0FkkEUGRrjiqas/O69Il0BaIvtmCmgsxp69cYOsY80Nks7nRvJXPetLdJBTersFWLxeqr2W8vjBEBkzbXvBPH7UMoluK96xvmmoLfGugyfMMzaeb7nuxZiOBcpv9WVcX/tKucpKwAy0cQV2ZdHLkDLpDsi6LbM7idmNmqf25glz3Tqod1QnG8pFtjCmoO3fNm/ukNgvGsLDAlrlqnsT2tjaGmaKCZeWy7qAUNon8l2+LiHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ffad005c-d6b9-9f27-9b5b-4f6d7345c81a@suse.com>
Date: Wed, 6 Apr 2022 16:07:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
 <d232b6bd-17d2-c78f-49e1-67ffc2502810@suse.com>
 <Yk2XcUhUn0BYk3lA@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk2XcUhUn0BYk3lA@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0502CA0047.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf2c0f85-0bef-4bf8-d94f-08da17d6c7ca
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2474:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB24749FB9714883D1C6BCA144B3E79@HE1PR0401MB2474.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gV5Ayl/4Q409hTn0dUwYFsS+zpP9m0E6DqFT/zeIK625ZYfDyW8Wo/hO0DuIYaJ99FdEl+EZxNsuwgfoJdnlDwh2JKBlBIs/6od6U9xn+tK9n85WFGuEkszI+V1tx8yV0TmbsD/omrDENkuR8JB5xzdFC4iUVKQieALFDkfn4qszhMwO3V4m0N83N4g6HgEAazX8wYPg8mGIQNZrPuIcSAW6Y3GcmsP1+nIlVN1nIqWInAj4/YKs0CufybdtsNmsG+0zWX7x53IhX/eYKiRT/nqqN1MlZyyyAXK6ELGEfxnn/4cSZBsunEUdkFQRPlPi4bOjWcfUZ3pwi/nvlQ2tSjRnHUX7w40zXjh85N99bQgCGRLqHZ8lH4K4xrgODk6mfdl+2QzoxQZXC/q3YSSbAaF6HYvYbMGieKWNHKU6trDR1Lc54uAowceKUeuj5pBfr7MWF/tcZeR2WFmjThpvK+2TtEdC9Zn0R9XRW8IsiMCn20NEx2nhshmDwgPVDhDC2XTsa+jozU7eCvsQyoG1AqcBexTQErE2af5scbda/ADxo78uPBDRspdX53SSxAaYuDAeL7boFsgoE8PosjPS14wNspLghMdxeDgSyXdo6oU5OAIlYdFcOMFZotFnbITGmcGY2PkMKJ6ou/KVEuO36mFcAXl9ciphNR9cBtCIO9Qsnu+xquT6XB1K5N68+0dmkBVbFhR0Z8eogUdVOcPEKDVEA1RsLOCinDb/GqzZ0eQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(66476007)(8676002)(54906003)(6486002)(6512007)(31686004)(316002)(6666004)(4326008)(508600001)(6506007)(5660300002)(186003)(53546011)(83380400001)(26005)(66556008)(36756003)(66946007)(38100700002)(2616005)(86362001)(2906002)(31696002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?I8tR9W/dpoPvPTKKxVvzdkIkppzzJmy2HddLnZGc9zXv3mpHhwCmiCLutwRh?=
 =?us-ascii?Q?YgqbifWDt1tV6dswTr42f/k/7iMpS193WmVe68PTg0OTcuN17MWDpezB1sj/?=
 =?us-ascii?Q?L7j0QyrckaCLcnbs+uf6GK8E1w7vdMLRXUfAErnh2Uruq2LEdNUySLWUtKBp?=
 =?us-ascii?Q?8pRhBNbeKb/ExXo1K6R1n2Fd/iv204IqHg6peu8bcl5THGOI3igevmH4HTf6?=
 =?us-ascii?Q?FyliOfDt/nvnscXEvawuadr2WqLDOZJQpeYVLM5ktx7+zN9Y4CMCHxNR0yKb?=
 =?us-ascii?Q?3w09Wk37sssyzQ6lAHfkMeZ8zvOF8ipmDgLMGb29jndaDUqimUgD4tD0wzuR?=
 =?us-ascii?Q?cvgoIj5AjqZBHD7hHxblevj+5odhGDs0CdKExSMz/kkh+J6LxMYSmvY7mxXr?=
 =?us-ascii?Q?tAH2J73dY0fx5XaFNfrgYAWcDvGK5h24M74uSEp+gyRd8VuWDRnCsl1/m4/2?=
 =?us-ascii?Q?ENqKeVMZ/R5SGMMooV1OqQFlKi1IbfiHwOrgkZlQV0XpMgMxAGc3cNKQ27lS?=
 =?us-ascii?Q?qoP9U1HJWbMbPTnCqFVqSDoW83823jSkgkCbnzR2vODMptFQCHOgYZmcudt7?=
 =?us-ascii?Q?utS0ETys9u+yh2qUbOxRfIeLrBClMJQHZ+3c8SPcN/YiqBp2NN14QjFqblyF?=
 =?us-ascii?Q?QNT1USy4jcQx/T8lgZJBtRsd0ai/6MVn653KnFcN6TfZHK0uLgCa9+JgCqSq?=
 =?us-ascii?Q?/Qn6HOjHIGkqNXwbAlWCsnmAZsz5kXRf5kyRIjEx3jrMfMnolzOlsDUVovKC?=
 =?us-ascii?Q?eN/xD6aYpAeXAoJtCwpcM+65/fN1dHlLWHhapYvy63qdHjxE73KWjqO7wZtF?=
 =?us-ascii?Q?Pgo9OPYxJFKyO6gFmR35vC9E+yBfTg7qbeSI7tWSVFPp1zatyfB4CWo+pZ6q?=
 =?us-ascii?Q?2MELLVtInVvNsMsOE2nQc0T5WgSlG5xRyK//5RiwATDO22JMuH7+sqbZeOfL?=
 =?us-ascii?Q?xiFJgWn2GGO6SEN7VEGAfU5ERpeUmQdTwsi5L4/fpib6HwJYM+7jWP2RG86l?=
 =?us-ascii?Q?/OBcY7rgpqNI1XOpwn+iyq39/D5MFI5t5Tr1LnIoE+B63Cocje17nkDXwlcy?=
 =?us-ascii?Q?3FmOPGvFLNqSBVh5v5XODeAaWna6kFoYuQGgUq2L5lAA7ub7mdOFYM/aGhoq?=
 =?us-ascii?Q?s1UIF0yrWzQAELMACcaqvPc4BQTPnFMdoqMViL5eVmYUHj+3R1D0CAw9sRn2?=
 =?us-ascii?Q?nKjpWjBoVqblrQ/LDFIINTcC/tkBXx0PRKpM5hczBCzRebm8RTcYiCyAd3/3?=
 =?us-ascii?Q?yng6XaunDiTdoqBeAczrc/GNozSLz3wh+LPLa0UEdk2yHjDjS0m1RXBmXo3K?=
 =?us-ascii?Q?6afVY532rtpIDwMdHXzUtDfM75X8G7GnP3uc+5/QR7Ika9rnIAWgJOwrPSZL?=
 =?us-ascii?Q?5hfo/ZaHtIK/RpV1zqKt/u6E0/ALWI0J8+Kq1RJV6m+QiJzUqE/PzyytXlLm?=
 =?us-ascii?Q?/0Cw8kmpCfwmFKyMuKeQQ5sll6dtw7lN+Gnyv+xfmb1N5klkktUGEDWEQWa9?=
 =?us-ascii?Q?iTEzXqDm1huvF4CZRvfqdExKgh/v7bFto0aRl0949afbOSkVA8xcNZeo7Yy7?=
 =?us-ascii?Q?b8KEDMhRO4RXFfBgai/9AEff0Yu8kC5f7LDR4rmHHnwWyHKUMg+FXc/nH6TP?=
 =?us-ascii?Q?I2DQvE432co7tVFfhe8Dgkzudc6zFEFvnDJJj1a+aAlAstUSK2DkqwwNROBx?=
 =?us-ascii?Q?NZvaeZUckx+vDuqvsnv+Dp5RRskvUyDkeZzHHAuDxVXVK3MNtv9ECrJTmyxr?=
 =?us-ascii?Q?WOkDGSmdhA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf2c0f85-0bef-4bf8-d94f-08da17d6c7ca
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:07:27.0152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FP/b2C1O+F20AmY+27AUwStrB9q4CpmJkL1NoMs3VPj/+5Yts1D87743kq5+WxpZrdsJ3U1Mrikr22Ag3f839w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2474

On 06.04.2022 15:36, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 02:24:32PM +0200, Jan Beulich wrote:
>> First there's a printk() which actually wrongly uses pdev in the first
>> place: We want to log the coordinates of the (perhaps fake) device
>> acted upon, which may not be pdev.
>>
>> Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
>> device quarantine page tables (part I)") to add a domid_t parameter to
>> domain_context_unmap_one(): It's only used to pass back here via
>> me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again.
>>
>> Finally there's the invocation of domain_context_mapping_one(), which
>> needs to be passed the correct domain ID. Avoid taking that path when
>> pdev is NULL and the quarantine state is what would need restoring to.
>> This means we can't security-support PCI devices with RMRRs (if such
>> exist in practice) any longer.
>>
>> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
>> Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quaranti=
ning")
>> Coverity ID: 1503784
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -750,6 +750,10 @@ However, this feature can still confer s
>>  when used to remove drivers and backends from domain 0
>>  (i.e., Driver Domains).
>> =20
>> +On VT-d (Intel hardware) passing through plain PCI (or PCI-X) devices
>> +when they have associated Reserved Memory Regions (RMRRs)
>> +is not security supported, if such a combination exists in the first pl=
ace.
>=20
> Hm, I think this could be confusing from a user PoV.  It's my
> understanding you want to differentiate between DEV_TYPE_PCIe_ENDPOINT
> and DEV_TYPE_PCI device types, so maybe we could use:
>=20
> "On VT-d (Intel hardware) passing through non PCI Express devices with
> associated Reserved Memory Regions (RMRRs) is not supported."
>=20
> AFAICT domain_context_mapping will already prevent this from happening
> by returning -EOPNOTSUPP (see the DEV_TYPE_PCI case handling).

Hmm. I did look at that code while writing the patch, but I didn't
draw the same conclusion. I'd like to tie the security support
statement to what could technically be made work. IOW I don't like
to say "not supported"; I'd like to stick to "not security
supported", which won't change even if that -EOPNOTSUPP path would
be replaced by a proper implementation. Even adding a sentence to
say this doesn't even work at present would seem to me to go too
far: Such a sentence would easily be forgotten if the situation
changed. But I'd be willing to add such an auxiliary statement as
a compromise.

As to "plain PCI (or PCI-X)" vs "non PCI Express" - while I prefer
to avoid a negation there, I'd be okay to switch if that's deemed
better for potential readers.

>> @@ -1601,9 +1601,13 @@ int domain_context_mapping_one(
>> =20
>>      if ( rc )
>>      {
>> -        if ( !prev_dom )
>> -            ret =3D domain_context_unmap_one(domain, iommu, bus, devfn,
>> -                                           DEVICE_DOMID(domain, pdev));
>> +        if ( !prev_dom ||
>> +             /*
>> +              * Unmapping here means PCI devices with RMRRs (if such ex=
ist)
>> +              * will cause problems if such a region was actually acces=
sed.
>> +              */
>> +             (prev_dom =3D=3D dom_io && !pdev) )
>=20
> Maybe I'm reading this wrong, but plain PCI devices with RMRRs are
> only allowed to be assigned to the hardware domain, and won't be able
> to be reassigned afterwards.  It would be fine to unmap
> unconditionally if !prev_dom or !pdev?  As calls with !pdev only
> happening for phantom functions or bridge devices.

Like with the support statement, I'd prefer this code to be independent
of the (perhaps temporary) decision to not allow certain assignments.

Since you mention phantom functions: Aiui their mapping operations will
be done with a non-NULL pdev, unless of course they're phantom functions
associated with a non-PCIe device (in which case the same secondary
mappings with a NULL pdev would occur - imo pointlessly, as it would
be the same bridge and the same secondary bus as for the actual device;
I'm under the impression that error handling may not work properly when
such redundant mappings occur).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:14:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:14:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299909.511228 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6Qq-00021o-J0; Wed, 06 Apr 2022 14:14:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299909.511228; Wed, 06 Apr 2022 14:14:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6Qq-00021h-G7; Wed, 06 Apr 2022 14:14:48 +0000
Received: by outflank-mailman (input) for mailman id 299909;
 Wed, 06 Apr 2022 14:14:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc6Qo-00021b-KQ
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:14:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e4a329b8-b5b3-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 16:14:42 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4a329b8-b5b3-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649254482;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=O6yqI2yNl30rZ60Ur/j5AarcBZs/LPEGhx/UfE9R7Tg=;
  b=fcCVoJ/GyFALW7+gKurXP7sjZS72/ho4VzyQ7HL6uxYy7CfpNhqs338x
   hMGwd+DClUsC3L7vdJHU+HwYf94I/lDeo/Qrv7TIQjK9zNCgKR6B4mXS/
   qBU/fYWSbEkewfg0zFZQatbQSlqK5DkCAgI3d33jF1CQlK2a+4H1g7rnA
   g=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68176440
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fmsShaNUKJ+0xTLvrR1Ql8FynXyQoLVcMsEvi/4bfWQNrUon0TxSx
 2tLDT2Ba/eIYzHzLosjPdywpkxSvMLTmNBgHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zi
 /5V7KGIdCQVFLDpvLs6ThtlSD5FFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmdp2Z4SQa62i
 8wxaRs2dhLwSCZ1InwTE8kZw82M1nuiSmgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSBzj6C/mOpl/X4lyrxU4IPF5W17vdvxlaUwwQ7AhAMSUGyp/X/j0ekQs9eM
 GQd4C9opq83nGSpU938UhuQsHOC+BkGVLJ4Eec39QWMwar8+BuCCy4PSTspQMwrsoo6SCIn0
 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9MmsqdSICCwwf7LHeTJob10yVCIw5Sejs04OzSWqYL
 y22QDYWxJ4L1PMz6oaH103ip22Lu5r0FREOz1CCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U
 Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQQ3d6TN4QhB7JJKkWp4xDhlbHlkPc8fEdMCS
 B+C4FgBjHO/0ZbDUEOWX25TI5lypUQDPY68PhwxUjaoSsIvHONg1HszDXN8J0i3zCARfVgXY
 P93i/qEA3cAErhAxzGrXeob2rJD7nlgmTKKFcyrn0T3juH2iJuppVEtagXmggcRtv3sneko2
 4wHa5viJ+t3DoUSnRU7AaZMdAtXfBDX9Lj9qtBNd/7rH+aVMDpJNhMl+pt4I9YNt/0Mzo/gp
 yjhMmcFmAuXrSCWcm2iNyE8AI4DqL4i9BrXywR3Zg32s5XiCK7yhJoim2wfJuB9rrE8lKIqF
 JHouayoW5xyd9gOwBxEBbHVp41+bhW7wwWIOiuuej8keJB8AQfO/7fZksHHrkHi0gLfWRMCn
 oCd
IronPort-HdrOrdr: A9a23:/igIsqhHr2gj3lHreVeZ3ltJ4XBQXukji2hC6mlwRA09TyXPrb
 HWoB19726QtN9xYgBDpTjjUJPrfZqyz/NICOUqUYtKPzOW21dATrsC0WK4+UyHJ8SWzIc0vp
 uIFZIQNDSaNzhHZKjBjjVRvLwbsaG6GAzDv5a785/NJzsaDJ1d0w==
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="68176440"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JhGMfPaDQnW1x6OZ1bszA/6/V61BVHXhOS9DLtUf2JK3OuJe79R15FaQ9n880/7ac9HbCcH9TtwH/LxTh8KppQ4ncFrrrRuhxeKjEEuU3SSCohu6grYBEKboAsFUQug55PQCia0gxJbbEpUUtdCqLXGEuWnpo4EJiiqHCJ+uulQKNbARnK3mVTb5v6WlRjqmRX1dGZzOrLN8ooTsUIutR9ExB+ZA2vTv7pNoS6GO16O3rbJvCZvClJzOAAFUmbb8MmWXzXSc9t/VxcBpfByBMWheC/MJzrF7nFVvowLij9lHqnKsD+gkEkj+dfCGu4n8A8wp2jSaFN2OszmDLjfWsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R9fw/IHbr+tKaykx1VXn/RWztIvkRlufgpoz8UMrnlE=;
 b=Ezb9j+tiq3bM7/Mhz/zVZO5EMQQKbzZmRiEm9fBoLqP68hipBZG9dSSW1Jgwf5q3w5qHJ2ZwcDFVsqxzCmH9QFKn+gZt5h5gi+PQbTFHlP+Fc6aJu7L1UdNEB68EFyHbyvXRawmGzWeubLlpckKTvvXYOm/4VbtPmLpqzwmmH3LnSMAd91nphU2lD46IfVUJMS3dPRYsAlxxAekW6Ng5BfSDEt/YSfK71umykvTiOKCo6cNz15fEGNhhDmELo5F6bzmZuaOVcAaKqs0YRAASuhT2eaocjV+0iXUgXHyg31jW+5RTXQD7uE4/7pRUU79hYVzYsbXJ0F84RKncNGpL1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R9fw/IHbr+tKaykx1VXn/RWztIvkRlufgpoz8UMrnlE=;
 b=TJSS4Mrb88vHFzoWHAVn3q1ueus8hAf4Ff97PP0f2f8soIYNSegMoWtVKY97leFe1CBH4R4hR8m10f9hiYg0g2g3P7iszrRBSnq9E+JOCG2vyCJYPp/hRvhEndHU8jVHTBJl5vZDiv4SxzJqW7t8AQCgcASdgziEkILVvMB4fUo=
Date: Wed, 6 Apr 2022 16:14:30 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <volodymyr_babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Message-ID: <Yk2gRvXUCfKwRBEj@Air-de-Roger>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
 <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
 <39640fec-de8d-0c5a-c9aa-daf83fb785b0@suse.com>
 <YkxkfbNpR7yfLP7W@Air-de-Roger>
 <17163e1a-6598-5949-47cc-eb9734bc69ac@suse.com>
 <Yk1erGso3rC68m/e@Air-de-Roger>
 <c9186f2c-25a1-6d97-cac6-126bb32bd22b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c9186f2c-25a1-6d97-cac6-126bb32bd22b@suse.com>
X-ClientProxiedBy: LO4P123CA0482.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c531deb-499c-4e23-cd67-08da17d7c6e1
X-MS-TrafficTypeDiagnostic: CO3PR03MB6712:EE_
X-Microsoft-Antispam-PRVS: <CO3PR03MB671225451A780C0323557DBE8FE79@CO3PR03MB6712.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: g6+wmvpEB62FWrgnbjC26TYCGKEWs6AanXGfEauowCA+ZrY6jiT9X5GlfnVEJxEeRBA9LNv18w3jtTKWt0vsxGfVUsKbzOlEv+rhs9YLMJ8GSx/Eox+vSSviEx5YefCrq+R2JhijkzYNrxAozgANfUuCgwFwuHhBGm75aqgF9Zfod7R7tMcI9jHYkH/skp0oVKoTDuL4U8s+psT0b36b3IVZqSj2zXPPhkaNNPnuJN3WRDSZ6Nq5D7a5hJ9pa73NRwsYINfjsLipukBgKlheun3aetKtHJtD99fXYbw6gzUW61wOaGwLYbXGzL72f9gPdeLsWcU9wCQfqA0/XbKZxW4NwQC+MXu7vqUQWbrKE3xE43qZzBO4Qj/wsiov4gjn1P81Mg6XqxZXO9q7BbbBdtkfVrRU0qPus9Tst8HYgNrtvNtZpaOU8VXWyoVrxLv2kL7r31LvabdCwMQdOXlEQWBfcXYFbAcdVn3DdMPMB03KVvTo7n1GhAlNzjZGUFI7JXYJEVF5Bq07XRi7y110EIgkcEUDucYYv7LLaV5lYNZ4p9Bm3skVlFrTDe809JNQ8MMmGLoaJksXTwidenE3m7xRhpNk9lMebynWd6urTW1ntVZXzz4X1C4jZLf/7kntmrSJ7cDoHDZYteygxvF5xg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(86362001)(53546011)(9686003)(6666004)(6512007)(6506007)(316002)(54906003)(6916009)(508600001)(33716001)(38100700002)(6486002)(83380400001)(186003)(26005)(82960400001)(8936002)(4326008)(2906002)(66476007)(66556008)(5660300002)(66946007)(85182001)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmlOQUZINGFpamtCSm9rQ0QzcGJzcmVaVnowaGZQQkdvN2pMUkErN3g0N2p1?=
 =?utf-8?B?RnZ2K3ptcmpESVJYZm9qYmRPSk9LeTZLeVViQ240ZFJnbW8rbE45dWNDZUND?=
 =?utf-8?B?cmxWYzNYUU1rUXJKRVF6bGNNTURsQVJtNHNUZ2g5ZHN0bElZM3BSZkh1QmFQ?=
 =?utf-8?B?Y1ZSMGR2NURLT1JnaWJ5THVNcGtIbGtIYlZxWXU4ODFHdG9icGVqVjUyc2ZI?=
 =?utf-8?B?Z2FlNDJnWGgvdGd1TzRidTBqSkVRblgyY0JJa3ZPbVhGRWlFL1JOVEo0WXdD?=
 =?utf-8?B?NHk5Z0xOdjlEQnBlYlB6RVB4eFlFN0EvUGRNd0JRb1dIQjFONis0RDdDMy9F?=
 =?utf-8?B?aGx5VUMrcWtha2tSMVpIM0xZM09HU3BrbkVqK1orRFR6YzEvTWtPaktjYThn?=
 =?utf-8?B?bTBya3M4Z1FRcHgxQzFsVWozQW1hRlNDZ2xQeG5ORVRvVXBuOFBPaFRnTmpN?=
 =?utf-8?B?VWlQUmV0YmI0KzZOT3R0NlgwKzJ6aUJjcklvbjU0WWZORUFjMXB6NU90eUJJ?=
 =?utf-8?B?dFcwZlpPL0tnaDJWYTVINHJNRTFYZ2JTSVVYbmFYNyszU0VYYVFVM0xSbFpw?=
 =?utf-8?B?aE1nZ0RacEhockRhckkwRWdjTDg4Z2xxekd2b3Z3bmRRaEZUbnFHaTh4YXlV?=
 =?utf-8?B?c2hpazUrWEJxeUtiQzd1dUROWlVTdXVWOWNnS2ZzSXg1eXQvQnlEWTR1dzdD?=
 =?utf-8?B?QmMycTNhOXAxZm1reXRKbGx3a01qT1JROEZYcC9neS92d0RGMVpzc2dnU3cv?=
 =?utf-8?B?ZW14MWZjZTdwSHFncG9WRlR5ZG10MEJlcTdlS01iOG45Rzh4N2IrcnIxdmdV?=
 =?utf-8?B?cnNOR09nSWs2Y3E1VG5DdlY0ZmQ3MFdnZUhMUVoyOGRiVGg1T2pCL2VhQkwr?=
 =?utf-8?B?T05pWnZzNkNGdWVyN0ZUT1RNTWhvRWl2emtkZXcremlvQ1V4VzlyelhCY0Jt?=
 =?utf-8?B?T3A0Ry82V3RhWFRONS93Yjdodk1IM0tCZzVITVBDQVdUaG8xZHNaWkVaa2NN?=
 =?utf-8?B?UFZGOHNaVExDZjhCcHBhNW9FZ0hHZ01wWVJnTk1HRWhiSlprL0RLMkltZmNI?=
 =?utf-8?B?eVFDOEtOaytGajM2SHF3WnowS245dUZma3NJWWJLMXV3Qi9JOG5rK0I5NWcz?=
 =?utf-8?B?WkpDQWRYbDVvRVFvVTZSY0RyUlVFSzFmNEdJTkJTbG8zR2RQVDIrRU9GVFBo?=
 =?utf-8?B?V0p5RzBtQng0R3VmM2w4UjFqeE1PanovMzBlVytBNXJrV0FIbkc1MzdHQU9U?=
 =?utf-8?B?YVJ0dmdTQ2o2ZlkycTJwa1JpNDNkZm1DZDZJZnVtZ0Z6SUl5SnU0dG9VTHpw?=
 =?utf-8?B?Z2lJckdTSTBFUXBETFV3Y0N4R21SZU4xYWpDR3doeUJjczBWUkJpQWRtSDNT?=
 =?utf-8?B?RGFBN0llZzQ3aEZKR2FrRHBPS01CU2wyYUxNNDJZM0lRMnNjd3VMendQMUdO?=
 =?utf-8?B?NTRUcjM3U3Q0NVlVTzF2aFRTb2VSMUxmV1dFZnlXa3hBZFRvb21nRzRHSVQy?=
 =?utf-8?B?RXZETUlBUW93VjhlOUU0dUdvK2dHY0wzaWdLYkF1YVVUdXhuQ0tJV08xQitj?=
 =?utf-8?B?M2dMLzJiUmVVcTMzZlRUKzBneDZuRGpwYXRKRE9rOHRTczUrbHJFaFhNRXVX?=
 =?utf-8?B?d3JmVENISGkzbzFnTzA3ajlJeHUzUUtHeUhQckNBYVF3Y2lNVVB0MDF1WXBS?=
 =?utf-8?B?cFNTeUtBVWlsS1p2T2NHbnoyZGVkMUxScE8rZ3dWa0lIdjFxSVBmT3pZTTJj?=
 =?utf-8?B?NjVOV3dLZThjMDFoeC9PUjlWelZSczRueit1RUZFRXJxZTI5L3QxM2lsRGNX?=
 =?utf-8?B?OHBaaFdCcGxaRXpRdWJ4WXhndDFSdkdNSm4wQm5PejlCbnB4RHRnUERHSDdy?=
 =?utf-8?B?Rm1GVkg3aWtzekdBL09abm9CNUdxNWU1RVJOVnBtVWpNbGhLOWpqTlRaWjdF?=
 =?utf-8?B?VHJubE9DSmp5UWZGTEZ5ZXg5S212UHpGRERuS0Ezd0s1WUJEb050NDJjdmsr?=
 =?utf-8?B?a3haQ29Md1JOWVBrdXdFTzk3KzhyRW9zeWE2UUZ1R0luTDlndVBVRDl1STFC?=
 =?utf-8?B?QkNWbW1qZklVVy90OHdqbGxkSEZyUFdVN3BWVlJMU2M5NWk0aWpXNytqYlBs?=
 =?utf-8?B?Y2d2VkNoaHVSK0VBWm4rYWNZK29aVEo4WjdmRyt0eEwxUzdUaUxnK28zNU5C?=
 =?utf-8?B?Ry9EakdiQzhzU0Jvb0VHV29KNlFJaXhqcGFLbXEzYXpIc3lLNVR2dzQweE8z?=
 =?utf-8?B?bEZ3S3RJOW5pMWlBdUE1ZHgybGRsRTJoL2JndFhvc0ttQWVJYUh4RDk4LzZn?=
 =?utf-8?B?Nm9BMSswL0tKMG9yVjg4Uzl5bXdKa0NYVWtURnhKZlpaUmxwbTJmVmxJZUFu?=
 =?utf-8?Q?6yoEFX6v2j8LIqQk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c531deb-499c-4e23-cd67-08da17d7c6e1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:14:34.9846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8nh1UWbKeI3bZPulm73kvy5I4WDFLYN5NJtz1VdSNVKGWhWJw7xt5rKw3aV5sMTAFQ9N4L5PjNiclFI01NOmpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6712
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 02:40:50PM +0200, Jan Beulich wrote:
> On 06.04.2022 11:34, Roger Pau Monné wrote:
> > On Wed, Apr 06, 2022 at 10:44:12AM +0200, Jan Beulich wrote:
> >> On 05.04.2022 17:47, Roger Pau Monné wrote:
> >>> On Tue, Apr 05, 2022 at 04:36:53PM +0200, Jan Beulich wrote:
> >>>> On 05.04.2022 12:27, Roger Pau Monné wrote:
> >>>>> On Thu, Mar 31, 2022 at 11:45:36AM +0200, Jan Beulich wrote:
> >>>>>> +    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
> >>>>>> +    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
> >>>>>> +    EFI_STATUS status;
> >>>>>> +
> >>>>>> +    status = efi_bs->OpenProtocol(gop_handle, &active_guid,
> >>>>>> +                                  (void **)&active_edid, efi_ih, NULL,
> >>>>>> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> >>>>>> +    if ( status == EFI_SUCCESS &&
> >>>>>> +         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
> >>>>>> +        return;
> >>>>>
> >>>>> Isn't it enough to just call EFI_EDID_ACTIVE_PROTOCOL_GUID?
> >>>>>
> >>>>> From my reading of the UEFI spec this will either return
> >>>>> EFI_EDID_OVERRIDE_PROTOCOL_GUID or EFI_EDID_DISCOVERED_PROTOCOL_GUID.
> >>>>> If EFI_EDID_OVERRIDE_PROTOCOL is set it must be used, and hence
> >>>>> falling back to EFI_EDID_DISCOVERED_PROTOCOL_GUID if
> >>>>> EFI_EDID_ACTIVE_PROTOCOL_GUID cannot be parsed would likely mean
> >>>>> ignoring EFI_EDID_OVERRIDE_PROTOCOL?
> >>>>
> >>>> That's the theory. As per one of the post-commit-message remarks I had
> >>>> looked at what GrUB does, and I decided to follow its behavior in this
> >>>> regard, assuming they do what they do to work around quirks. As said
> >>>> in the remark, I didn't want to go as far as also cloning their use of
> >>>> the undocumented (afaik) "agp-internal-edid" variable.
> >>
> >> Actually it's a little different, as I realized while re-checking in
> >> order to reply to your request below. While GrUB looks to use this
> >> only "just in case", our use is actually to also cope with failure
> >> in copy_edid(): In case the overridden EDID doesn't match the size
> >> constraint (which is more strict than GrUB's), we would retry with
> >> the "discovered" one in the hope that its size is okay.
> > 
> > Hm, the specification states in EFI_EDID_OVERRIDE_PROTOCOL.GetEdid that:
> > 
> > "Returns EDID values and attributes that the Video BIOS must use"
> 
> I'm tempted to say "We're not the Video BIOS." ;-)

I think UEFI expects this to be exclusively used by legacy Video BIOS
implementations but not OSes?

> > And since EFI_EDID_ACTIVE_PROTOCOL will return
> > EFI_EDID_OVERRIDE_PROTOCOL if present it makes me wonder whether it's
> > fine to resort to EFI_EDID_DISCOVERED_PROTOCOL if the problem is not
> > the call itself failing, but Xen failing to parse the result (because
> > of the usage of must in the sentence).
> > 
> > I think it's fine to resort to EFI_EDID_DISCOVERED_PROTOCOL if
> > EFI_EDID_ACTIVE_PROTOCOL fails, but it's likely not if the call
> > succeeds but it's Xen the one failing to parse the result.
> > 
> >>> Could you add this as a comment here? So it's not lost on commit as
> >>> being just a post-commit log remark.
> >>
> >> As a result I'm unsure of the value of a comment here going beyond
> >> what the comment in copy_edid() already says. For now I've added
> >>
> >>     /*
> >>      * In case an override is in place which doesn't fit copy_edid(), also try
> >>      * obtaining the discovered EDID in the hope that it's better than nothing.
> >>      */
> > 
> > I think the comment is fine, but as mentioned above I wonder whether
> > by failing to parse the EDID from EFI_EDID_ACTIVE_PROTOCOL and
> > resorting to EFI_EDID_DISCOVERED_PROTOCOL we could be screwing the
> > system more than by simply failing to get video output, hence I
> > think a more conservative approach might be to just use
> > EFI_EDID_DISCOVERED_PROTOCOL if EFI_EDID_ACTIVE_PROTOCOL fails.
> > 
> > As with firmware, this should mostly mimic what others do in order to
> > be on the safe side, so if GrUB does so we should likely follow suit.
> 
> But they're careless in other ways; I don't want to mimic that. I would
> assume (or at least hope) that a discovered EDID still fits the system,
> perhaps not as optimally as a subsequently installed override. But then
> I also lack sufficient knowledge on all aspects which EDID may be
> relevant for, so it's all guesswork anyway afaic.

Yes, I'm afraid I don't have any more insight. I'm slightly concerned
about this, but I guess not so much as in to block the change:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

I would word the comment as:

/*
 * In case an override is in place which doesn't fit copy_edid(), also
 * try obtaining the discovered EDID in the hope that it's better than
 * nothing.
 *
 * Note that attempting to use the information in
 * EFI_EDID_DISCOVERED_PROTOCOL when there's an override provided by
 * EFI_EDID_ACTIVE_PROTOCOL could lead to issues.
 */

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:21:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:21:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299915.511240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6XN-0003cK-D0; Wed, 06 Apr 2022 14:21:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299915.511240; Wed, 06 Apr 2022 14:21:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6XN-0003cD-9y; Wed, 06 Apr 2022 14:21:33 +0000
Received: by outflank-mailman (input) for mailman id 299915;
 Wed, 06 Apr 2022 14:21:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc6XL-0003c7-FM
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:21:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d984ced8-b5b4-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 16:21:29 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-zFapoJlNNkeWlHg6YZhiVg-1; Wed, 06 Apr 2022 16:21:28 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8691.eurprd04.prod.outlook.com (2603:10a6:20b:42a::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Wed, 6 Apr
 2022 14:21:26 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 14:21:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d984ced8-b5b4-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649254889;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qropIJfSBioGVGimPOasNk80It1ayD289kSkOdTKr/g=;
	b=lWsnWy6CU7wnEmaVbi5HaMQkBoFI0pmwHtaLMLSJkSJ3NzEj1cRvprOFmYx69UCfO31FHH
	geCj7MPxhOwgJXH0g2TbV8P3IYg/cj8alPAXYEmVHKHDJgJrOWaoJdc8EA19V96n6HUJ7I
	LnJzULJIbolrRPseeXCTxbQgB5M/aK4=
X-MC-Unique: zFapoJlNNkeWlHg6YZhiVg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eUR27UYd/0PzS1etrLdxaM9uJxnQBQs55wcuwoIHlQz6+qbnLBpAwHYWqm/61xor1sUkoDSBNSnJMBsE0Mor33H4qIu6gZsjEpc1/E1DbHQFHRw8unLAtsY8LCmt/O69ePmpFW+xAktF/9iZJGLY/GIz1U2JGxIpftjhqKpj5Fd1taXhLKJDCUhgjhNuLFgHsLxFsvgsIIU+hUoD6k0cBhgFwaF8Xx3mT8tsRitPYrpdRKJWG+WxcIqim/3skayQx/DL2AP2Zff/ZuJrTVQZGyAQ5hgXAYr3ep1+5LRmk7SeXQT2kgpXl6Q6aHx+3+LbsutrMVSiXFZvCNr0dB/5PQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CmJqBtWVRIOHkmLpNjjpheDJBmNgDG2EX0lawK/FJdo=;
 b=UkCO76csv6pWI4XCxXsYnYebL1yxhZ2495Y2mmNDuPRY7Vi6jVnDWPJ+85NDlNUPX/+0ALCZi5gvBuR3u7MlsT3hWocb26ediXQn4FKMtEd0vn0A54ey8NdhQNDXKcO900x0MmVIpdoUWPmQ6gO0buRlzPiMb+GTqO7JvMTw/sFtbocMADH3qhaDSz41BlUlS6r+FK4FA9JwewvGoomvyAT6RO7fYR672V69e1Ju37CK2xQspqA346bSIiAZNnHP25ZAM5Opl7DXgWQHAJ+hTiIe9D1PpeYA1qO28tuLFtiwdSqUMw9DXFyo6AWVrLOl7vLlMW2iF3BFcgVu5hv8cQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5e633888-0344-2737-13cb-ccb802651963@suse.com>
Date: Wed, 6 Apr 2022 16:21:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
 <YkwZnBIOQ/jwzq9Y@Air-de-Roger>
 <39640fec-de8d-0c5a-c9aa-daf83fb785b0@suse.com>
 <YkxkfbNpR7yfLP7W@Air-de-Roger>
 <17163e1a-6598-5949-47cc-eb9734bc69ac@suse.com>
 <Yk1erGso3rC68m/e@Air-de-Roger>
 <c9186f2c-25a1-6d97-cac6-126bb32bd22b@suse.com>
 <Yk2gRvXUCfKwRBEj@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk2gRvXUCfKwRBEj@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0040.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 512b84ed-76a6-4074-579d-08da17d8bbe3
X-MS-TrafficTypeDiagnostic: AS8PR04MB8691:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB86915362A0AEBFDE606C82D6B3E79@AS8PR04MB8691.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kGc26os5+9jQ3h6siNHUSW9//W1WKqv4w2ZFZ1xP6kbq6nW5uqkpoJAYORe4mC9TkJg5GOdRUO/eUZbV3Y2YuuNKHhwc2ROT8/0gNNLQI963h6jrlUyaOF13qOIg3ilNkXtRO/Meqz6aLcRjAvPmjNUcOOS5JMvhTBpKTy4UcnM4P+YkpK0qI6XEJYZCP9AhZvK8KIBMJ+RTQPZ6LLlCwCH/957YnT373QkiP+sC08heGKjzryPJ01QTJVFP6OtVwHR5GOQqeA9nOqo4ZaV5dxs+FPeE8q4AXzLqdRatX/SqIkWDAQYCooOvShxiQImliJpxYyy+T5QaiL46DpWmZ9PMhEX1VbpTEyTqfU3CjYp6barGhZNzlWGGh4SJDxoEZe73TK2Y8NnZI9lQavLhc8KN9uZpO95cA4hcXUnTsRQ70wlOYxCVeURhiM5AeAxbcESLdc47eFFRovcHaCMMLJ1C+d5YbkGQqm0jWOMjsBxdfcw0CaDanNVU0pRRMEC+xlX19G9CQPyHceorCbmt/zTbyDBM4UqwFLiVT6osVzTdJDVzME1nbIR0L7ZjSiPZamG5a1V0enGkXS4p/E/eZDKvC9v+3VtIa6djU4o3jn3ii5Og1P0vCsKMcETGdfIrAxFjpz7q3AciFxDZGZybyn/MeON9ICOJKK04UbEwZfzdzRjp9e+Am88Hbl09j4kWIWvfUguPQbCpy0RdR5bvBqDWASQjvF8xM8yLxaYB7R8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(186003)(5660300002)(508600001)(54906003)(83380400001)(6916009)(31686004)(2616005)(316002)(36756003)(2906002)(6506007)(66476007)(53546011)(6512007)(31696002)(66556008)(26005)(38100700002)(66946007)(8936002)(8676002)(86362001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?m2ipoib3TFR0Eo6aXCdhFdFyWyGrB83D8ww4wmgQqtNZ6fAVBNWDweYtVyTY?=
 =?us-ascii?Q?poJ8rKU1D4bK8o1B/jjwPSb82ETRyEYEjN8RjsSpjprlKER7Zq8RRFHdAckN?=
 =?us-ascii?Q?vKto1D6ZvWUOxTF/H2sM5QVD+rC6bzK6PhxP5fC0MseFZPnX37VWNC6MsWIs?=
 =?us-ascii?Q?fyRu0jo6F9OZna/aszb8oX21iytVV7iHce1Isb/Vf5qwCYNxT7ccPh8lH5DC?=
 =?us-ascii?Q?k5m1/5py8uVsrhRxwVjpfVoSG7Ncbo0R4vUSCLgfEs9xwYqtW6o6boX321KL?=
 =?us-ascii?Q?/JPo5IFVnwnKOLyfsyxrR69jTSQiu7v1tJXvnWgT6V3vWiblQ4AdZWCjdDiY?=
 =?us-ascii?Q?g+GMO6ghfMUOk2UUxnsZ6Si1SvwMAr91A6A535RGSOTDlPPiaBeNzvJLYwfO?=
 =?us-ascii?Q?zpqdbKsqY3fFAYDOCaG0ApnHClmcJ68JPiYjAk2DV37JyM6CfHD/9XISl0VL?=
 =?us-ascii?Q?r5Kznvag3hr6HwxPa2+nXWGT7CHbD8s6JYzjdXtPYY8ICKdy/Q4+wiIOUQy4?=
 =?us-ascii?Q?2oF63uZiO5XLMRYo39xsMe7tmXwK1o6aXo6qTE0HPIsT+l+lvq0caECCZJOz?=
 =?us-ascii?Q?mUK99fB8ZIEgl+597/UisrSH80Zg7HTfBjxtdrszTk0wsptjxoVdJ1YvLBYI?=
 =?us-ascii?Q?fySYdFatMqxCMmjw/2vgcUtolx4u6V8q0V5G4ls4QUzKs6Uy9gBeJzYrb+XW?=
 =?us-ascii?Q?uArm2778Eh54zg7+gAdURrlLOASu6sWF8ozn9V2GJOEz/SUt/xjoftY6jqbU?=
 =?us-ascii?Q?GS4oU6l63b70vt8JNKm2oHicnCpJdInHN6/4pTZLthv0sGnpdWAa0An2qpHI?=
 =?us-ascii?Q?xGutzX6ZBC31fRG9zLoeiMt4NP7xWVtxn58dyrCxLbY+eGg/EtVWxYNrLwJj?=
 =?us-ascii?Q?oX/Z73do2CVSgddN2ZtEc3hgdeYjO+u3W6goWu5k/0zTastQOMDNT6oOxfwn?=
 =?us-ascii?Q?gQwlsjkVvmbedq4ICDB5kVwI9tujNHRW/DP/xBLztAzYcasA1tK+rMB5udz0?=
 =?us-ascii?Q?1Ykf/i03EgYcBSGnMIvFE4TXt6FECIUHdWhOHbGgyQNTzDBaaAdl0SDNvWAJ?=
 =?us-ascii?Q?fVwFhZqtvDzUwh9BPZecyzIPOJKbonDBOiTnYtrd1kYfzOdhu6hc6LqcNay2?=
 =?us-ascii?Q?JaCtNkIo/HOUdGCS4RQu8fC+AmfgRT8ZT8IgY2dZHcg8dgdnuYrasyb5ZAFi?=
 =?us-ascii?Q?b20WaK7YhoWXrAuLk31xW2j/tpNeNX3XwBa/7oba7E/c/uM/XqQ0uEsguTR7?=
 =?us-ascii?Q?Qd4aI/3W/JuXOtdWYCnQZiSu7CIsdnRrlIkjCe2RfBK0O/qCHjuC2MPbt/RR?=
 =?us-ascii?Q?nVMxwEXN5ibfUUcAzjIx3hRD8YdYsWL6HAIk3DtWkYRwvhDQRp1eImliVFRB?=
 =?us-ascii?Q?7/h2UdGcIZy3vx2oHkrb6s/PjopYZi3zG2RkJifxepGbe9iQyaazg/92gNv3?=
 =?us-ascii?Q?a6KfZiCMqfzGfnMoY21WPcYAE+z3yvCqgonTvkRcmnGU+MaATC7bNQklCzUf?=
 =?us-ascii?Q?dTWR2pblj1SYvY99vt5wyxHkxj3BIGY3duHJwzRfHmq8BBkEmgiDGMGxWlTv?=
 =?us-ascii?Q?GC9r/i2feQ7RVJhEYV2xFFOjg0gwzhBhPo353Up9TWDNeLLmUshG/DlD3T/k?=
 =?us-ascii?Q?+kLHYG3FU1JT+/xJ2gdvFPur/dKRnCbi+7XHM1mEEvR/YmPAfk2sK2drBzVk?=
 =?us-ascii?Q?pVNJQflIp+943wzlAc2Z4pvbkvNaOE/7Qn6RnEGaQJ8LJdFc9zsj/wZyFc33?=
 =?us-ascii?Q?tYy6ipz2Fw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 512b84ed-76a6-4074-579d-08da17d8bbe3
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:21:26.0365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yT97GLS+Z7XCvNBUd+yVU7YQs+6Lsh9HK4+VBaWsyHShmzFdsS56kSsKh5tbimxXGCc8Jv4YDOcvfrFQ4XqN7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8691

On 06.04.2022 16:14, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 02:40:50PM +0200, Jan Beulich wrote:
>> On 06.04.2022 11:34, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Apr 06, 2022 at 10:44:12AM +0200, Jan Beulich wrote:
>>>> On 05.04.2022 17:47, Roger Pau Monn=C3=A9 wrote:
>>>>> On Tue, Apr 05, 2022 at 04:36:53PM +0200, Jan Beulich wrote:
>>>>>> On 05.04.2022 12:27, Roger Pau Monn=C3=A9 wrote:
>>>>>>> On Thu, Mar 31, 2022 at 11:45:36AM +0200, Jan Beulich wrote:
>>>>>>>> +    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
>>>>>>>> +    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
>>>>>>>> +    EFI_STATUS status;
>>>>>>>> +
>>>>>>>> +    status =3D efi_bs->OpenProtocol(gop_handle, &active_guid,
>>>>>>>> +                                  (void **)&active_edid, efi_ih, =
NULL,
>>>>>>>> +                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL)=
;
>>>>>>>> +    if ( status =3D=3D EFI_SUCCESS &&
>>>>>>>> +         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
>>>>>>>> +        return;
>>>>>>>
>>>>>>> Isn't it enough to just call EFI_EDID_ACTIVE_PROTOCOL_GUID?
>>>>>>>
>>>>>>> From my reading of the UEFI spec this will either return
>>>>>>> EFI_EDID_OVERRIDE_PROTOCOL_GUID or EFI_EDID_DISCOVERED_PROTOCOL_GUI=
D.
>>>>>>> If EFI_EDID_OVERRIDE_PROTOCOL is set it must be used, and hence
>>>>>>> falling back to EFI_EDID_DISCOVERED_PROTOCOL_GUID if
>>>>>>> EFI_EDID_ACTIVE_PROTOCOL_GUID cannot be parsed would likely mean
>>>>>>> ignoring EFI_EDID_OVERRIDE_PROTOCOL?
>>>>>>
>>>>>> That's the theory. As per one of the post-commit-message remarks I h=
ad
>>>>>> looked at what GrUB does, and I decided to follow its behavior in th=
is
>>>>>> regard, assuming they do what they do to work around quirks. As said
>>>>>> in the remark, I didn't want to go as far as also cloning their use =
of
>>>>>> the undocumented (afaik) "agp-internal-edid" variable.
>>>>
>>>> Actually it's a little different, as I realized while re-checking in
>>>> order to reply to your request below. While GrUB looks to use this
>>>> only "just in case", our use is actually to also cope with failure
>>>> in copy_edid(): In case the overridden EDID doesn't match the size
>>>> constraint (which is more strict than GrUB's), we would retry with
>>>> the "discovered" one in the hope that its size is okay.
>>>
>>> Hm, the specification states in EFI_EDID_OVERRIDE_PROTOCOL.GetEdid that=
:
>>>
>>> "Returns EDID values and attributes that the Video BIOS must use"
>>
>> I'm tempted to say "We're not the Video BIOS." ;-)
>=20
> I think UEFI expects this to be exclusively used by legacy Video BIOS
> implementations but not OSes?
>=20
>>> And since EFI_EDID_ACTIVE_PROTOCOL will return
>>> EFI_EDID_OVERRIDE_PROTOCOL if present it makes me wonder whether it's
>>> fine to resort to EFI_EDID_DISCOVERED_PROTOCOL if the problem is not
>>> the call itself failing, but Xen failing to parse the result (because
>>> of the usage of must in the sentence).
>>>
>>> I think it's fine to resort to EFI_EDID_DISCOVERED_PROTOCOL if
>>> EFI_EDID_ACTIVE_PROTOCOL fails, but it's likely not if the call
>>> succeeds but it's Xen the one failing to parse the result.
>>>
>>>>> Could you add this as a comment here? So it's not lost on commit as
>>>>> being just a post-commit log remark.
>>>>
>>>> As a result I'm unsure of the value of a comment here going beyond
>>>> what the comment in copy_edid() already says. For now I've added
>>>>
>>>>     /*
>>>>      * In case an override is in place which doesn't fit copy_edid(), =
also try
>>>>      * obtaining the discovered EDID in the hope that it's better than=
 nothing.
>>>>      */
>>>
>>> I think the comment is fine, but as mentioned above I wonder whether
>>> by failing to parse the EDID from EFI_EDID_ACTIVE_PROTOCOL and
>>> resorting to EFI_EDID_DISCOVERED_PROTOCOL we could be screwing the
>>> system more than by simply failing to get video output, hence I
>>> think a more conservative approach might be to just use
>>> EFI_EDID_DISCOVERED_PROTOCOL if EFI_EDID_ACTIVE_PROTOCOL fails.
>>>
>>> As with firmware, this should mostly mimic what others do in order to
>>> be on the safe side, so if GrUB does so we should likely follow suit.
>>
>> But they're careless in other ways; I don't want to mimic that. I would
>> assume (or at least hope) that a discovered EDID still fits the system,
>> perhaps not as optimally as a subsequently installed override. But then
>> I also lack sufficient knowledge on all aspects which EDID may be
>> relevant for, so it's all guesswork anyway afaic.
>=20
> Yes, I'm afraid I don't have any more insight. I'm slightly concerned
> about this, but I guess not so much as in to block the change:
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

> I would word the comment as:
>=20
> /*
>  * In case an override is in place which doesn't fit copy_edid(), also
>  * try obtaining the discovered EDID in the hope that it's better than
>  * nothing.
>  *
>  * Note that attempting to use the information in
>  * EFI_EDID_DISCOVERED_PROTOCOL when there's an override provided by
>  * EFI_EDID_ACTIVE_PROTOCOL could lead to issues.
>  */

I've extended it like this.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:23:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:23:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299919.511251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6ZE-0004Cu-Os; Wed, 06 Apr 2022 14:23:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299919.511251; Wed, 06 Apr 2022 14:23:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6ZE-0004Cn-Ls; Wed, 06 Apr 2022 14:23:28 +0000
Received: by outflank-mailman (input) for mailman id 299919;
 Wed, 06 Apr 2022 14:23:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc6ZD-0004Ch-CD
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:23:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1f2d88af-b5b5-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 16:23:26 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2051.outbound.protection.outlook.com [104.47.5.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-yOgDzY2NOCyixjxIq60_2g-1; Wed, 06 Apr 2022 16:23:24 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB6614.eurprd04.prod.outlook.com (2603:10a6:20b:fe::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 14:23:22 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 14:23:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f2d88af-b5b5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649255005;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zpJ/CKXcSgGMt9+JgYKICAGQutCWHilkC8imYjya/4k=;
	b=MSspE0rU5YUHpmb8qDw6IzFoHP0kPl/9Rr9hurF/w68O6OrRIb3tnm0aiSsHas8hcepXCV
	sch+Jnqf/jY2VJMUMEV+mnUh5ajmdcei8jjkqi3G+8rKbQl4cxb34uNUvMewTOg1+kzFiT
	HQSDQX9zjx4a+QWTj27yO0MFlXjjdRQ=
X-MC-Unique: yOgDzY2NOCyixjxIq60_2g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Th9K/00cxxjHY3g6TPa8uKx420tcll01N2yjFeB2O+3uHbNaB3GhMC3a6sFXRKDlel2UpaYijCxjiNXl6MhfXnCvLIS1OCVnZp2l/bJRpxeyHQSOGBtpP0RKh14atXL/fCH1z/ApSWtqFKfLdl5xTFJbvZyL6NeLzx9FNWMaXJ7CCaEa6DTObbrL8d/uImLZgQphYE3ZXN08AZLcYYmT/9Hyal6At0mpEO5oYkSQnPJDbt+J8WCZ3vCQOV/83gVFRw1L+lU2Uvx84IMrO8Dqz0lfyILys+MP8gb/Ee/ASc/sdioDZd29EJO3O3TenojywryQ34pEyHtMO8M0JJlzNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kZvBxKd/T0TRkdNeYmow/rSTQy+MbsbZVDbAn7hfI9Q=;
 b=aF3NdFfpbv6+flOpkjL0hSb7ZhPsEBaq352/5/wJ4Ly8FJZNCxuSxElfJvi9H9x+vaiC9ki48yKXbqpZjzrUB2MQR9vd0YnxS9suDLgnbFxNjf7IEQh/Yb10NGb7G/xK1J05+G6Zfqh5p97RvOGgKdpcQurpQg8lCveX+0cnyejLlOoIkt0mfHUBj/tGuOWYnTqjossfhWbOH1aqor+U30KZ4tBPtd8E2vgAhz2tGhrUDu8HHGN94WoRd3xa9c2RtAXPmINczjPvunRySwZLR4Lxm9IxgHetH54WHDfbFSXP1hImffzpOh++zQ1MmGf5MWWDJ6plpLVW7IUllyv+7A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <65d3068b-fde5-951b-9a60-4ba1dcd89a49@suse.com>
Date: Wed, 6 Apr 2022 16:23:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics
 modes
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 "community.manager@xenproject.org" <community.manager@xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
 <YkwBpKcyrnuXyNPa@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YkwBpKcyrnuXyNPa@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR03CA0003.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 599d89c4-d4bf-406f-cc09-08da17d90167
X-MS-TrafficTypeDiagnostic: AM6PR04MB6614:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6614B4FDC474C5B50BC58602B3E79@AM6PR04MB6614.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5whQ9m/aazbp0S8qBzVsqLbbMVLbnROr1LSnEMrHllBAWWUJJsJxN0GvpW394+ZlPYnfvzhZXjtIiaCawh7Y2EfzfSnwYaFmas3R65r+dvn90etSTOsalJ6i/dZDEnFzov32+IQhwXjirc41MThJSiUkXb3NNMMGuqkPvucr9N1QAayE8zJ6ZmAC83NLNdh3wIOKIPEl1Ptsn2ovHnbkMrCvLlQdASK8UbUGXBb/sQXXiB+okKwvbzgGayIfyMbR63Ea2PmEmhFTNV1FONYreIz5adt0DixxVjDLBITR7RgJN4oyyNJ50dO1jRZKgZlIjG4e4dUqPE5Mn0Qa0A9rNwkjn0YD4vkKMeHGGURp8A17pc+XVbAi6N1XJFCMlEssvS47a3CDjaYVSCtdB0/s/nYeYGlAebfjebczOt5iDRsGC5v7VuWZGFbbCXrYoFPVgSC0i2+NJ0BIUuyU8rCZUvDv8KwBw1G9Mh33tnlZjnjLKR2utI1t9IZvB26xuF0CQK3JebqTdGBg/2bL/31pgXKSFeQWX6VlInN1l+N0aatHT5zWbSA1rhs4RVf5eNC6wEpoAAzF/fP+pEcsv6n5IRKTUX6BD5jrgfcwcOAB3ExWkbHHxrUhxrgP0XHu1iKXWuuydkId+4c/ymad8IewGM+yv9GTdhRo09SzuV9ZFhaCaCFy3LqTZ0f6o6XNKMbn3P2ApgggkI63mUoI+GzDxv2TXrYfCrG73B7ejGdzXUdg6lTVTxvOfpKsLs68Pe8p
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(38100700002)(31696002)(54906003)(6916009)(8676002)(66476007)(86362001)(66556008)(66946007)(4326008)(36756003)(316002)(5660300002)(2906002)(8936002)(6506007)(26005)(53546011)(186003)(2616005)(31686004)(508600001)(6486002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0dbc/Dk+56usmvv4eejIP0+hPVQN2XPmnqCyLN46+uam6rXv2X2I+wbB9HhB?=
 =?us-ascii?Q?UPP6Kmu3xjAeQ91YZcN+8XkTbkMGWxppQCkjDWs1OXHx2jR+KYUzAGka2S9w?=
 =?us-ascii?Q?khcuT9nxjEvEw1qmScfRSm73gtw+ZYACuD56KPRYTMC0kxpsxt5fp4gg74Hq?=
 =?us-ascii?Q?E3d0PBnlYq9FZocVfi3OhBIzykEqeJTLLG3krUTUqtEEx4wM8M6EaIpnO8qb?=
 =?us-ascii?Q?t+brIkKLEELEvo3ab3Xr1k++dwFPLIkPvhP9WkEt5zeWMHR/pv09ftIuJYIw?=
 =?us-ascii?Q?m6nvSPObIPaD+S64SNCffTtQZLPjSwdVttRckZmtMLNZRoAx6ujMGxb9tjeN?=
 =?us-ascii?Q?7tx7cQe7EaJfNUC05J0hu5ZLxIR3oUcS1Mpfry5QVl5hS5iGEH5iTqKzgF/3?=
 =?us-ascii?Q?AZBuLxtG1pgdk+HHWbx2nCQYFKMXSJQBq+IhN4tX8i8FpWjK674DVvMN/g7J?=
 =?us-ascii?Q?ftMP59wKexUzlK61EzxyWB/ujGBZFWitpBWba8LBQ2RUCU6Br3axANk/iRKu?=
 =?us-ascii?Q?rzZjQBNHqmmNsTl6qnLwbIqvdSK8bXxhKzzP4DxQyFLjOiVZlTDEvA+e/U9r?=
 =?us-ascii?Q?s6a3FCqRmOXyhJs+OeRtpvg+UMo+HJLDDtcHwPc2yx+nW1M9YE/8Q8C5PI97?=
 =?us-ascii?Q?AgvAJHk10TO+dfVlmldiD9qKslOTcELVXUF66pwb7tulDvp1XxeI9080mUWS?=
 =?us-ascii?Q?a5Wgto2wgP2q6juQJP0IPiiKmKgF1ZN+v0crzn01UCGVhrW5NDY1dCZeWh47?=
 =?us-ascii?Q?GkZ1k167/8P0tj+/Efmrpfv8IZ6YvvDJL9ygCGfd7zFL6quR7rcOJSAlfGQr?=
 =?us-ascii?Q?iitguDcEp8NkH9wxZJlEXCOEAeefZ2rThQF0UWMAzAXI3YMvzkXV3EArIxQE?=
 =?us-ascii?Q?B+t/LXPrxNgHLDLYEYLFvRiwTGqdbFX0brUCOvo4dx7H/YGP/fPKiwKDuZIm?=
 =?us-ascii?Q?LYvdisAn4lBAJlGB0i9OUE4SR4J4wxmLh1xzA9OjKFaXSmLVv0Vdq0pD3twu?=
 =?us-ascii?Q?Qp77anDpE9uGKgAlFaTfykiSUp4CdyZlWCFagfHbkYtUWTwO9NCvmLeZzOpC?=
 =?us-ascii?Q?jnHOF14dglkbPdsbxy54d6IJdf9L+ZcIlxfQBM2d3PLiTStC1RQjzU2s5OTA?=
 =?us-ascii?Q?6eDxTs3NF/gVoCq0A7FuMgQA7ZK6SjMVTOA80tFZ9oXuJV0fkbyH0K2C12gL?=
 =?us-ascii?Q?qmKygnh38x3TJuDv2ZjNKeFSvF58LpopF0r4B49YuQ8jgEG+XaUkt7lS67/3?=
 =?us-ascii?Q?MBY3KD8lfL3l6VHsRfGasoeVExQJI8GZhefaF79t30QM0Ykb5GVxcue/lWwH?=
 =?us-ascii?Q?R0fEGfm9aEigsrvybTJ6vaVNjCIhSxt3HnCzqTZbOqZ0vO9cBq54ZjFgE63p?=
 =?us-ascii?Q?JssZ1SJaEOWDgGTL1vv7OqW/rULP0h0EhCHs/bfYf5rE2e2sh4zcEAgaLbkw?=
 =?us-ascii?Q?EyB5hkQ7Qanq+/dnaf28VmXdNEvovWIX+ZNIf5uR616zcWzTpF9rlrlr/xTD?=
 =?us-ascii?Q?AbyOMKu4FlawP4rpzzzYsVoAk2XliGGYNzSqwjoOXwAPbZJLeND6es1Zvrps?=
 =?us-ascii?Q?L2B5SFkFHGTmfQeRJU2RHhtjFABJ/7pjWewcvhjBiqa5ULP7e1L3U3uNnuw6?=
 =?us-ascii?Q?bZ0VblYYIx83RB7fmxsBgu/ZtAhr3PrZu7zlLZGlQ83F+JwsqshWhcGnxbGq?=
 =?us-ascii?Q?0vq7tn4aIWailBKUs3Uym6POXX8nFBOPwfw9MzypI80Xw5RWEqKF5rATEnT0?=
 =?us-ascii?Q?8B79u5W6bg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 599d89c4-d4bf-406f-cc09-08da17d90167
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:23:22.6674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PZHCVhHLtbf5iP3NvmW47d4hcsC78EcBsGqHSWioxdUfSY50hmi8sMeG5NS30o49z3TiWqrD96hGadTYngB/+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6614

On 05.04.2022 10:45, Roger Pau Monn=C3=A9 wrote:
> On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote:
>> GrUB2 can be told to leave the screen in the graphics mode it has been
>> using (or any other one), via "set gfxpayload=3Dkeep" (or suitable
>> variants thereof). In this case we can avoid doing another mode switch
>> ourselves. This in particular avoids possibly setting the screen to a
>> less desirable mode: On one of my test systems the set of modes
>> reported available by the VESA BIOS depends on whether the interposed
>> KVM switch has that machine set as the active one. If it's not active,
>> only modes up to 1024x768 get reported, while when active 1280x1024
>> modes are also included. For things to always work with an explicitly
>> specified mode (via the "vga=3D" option), that mode therefore needs be a
>> 1024x768 one.
>>
>> For some reason this only works for me with "multiboot2" (and
>> "module2"); "multiboot" (and "module") still forces the screen into text
>> mode, despite my reading of the sources suggesting otherwise.
>>
>> For starters I'm limiting this to graphics modes; I do think this ought
>> to also work for text modes, but
>> - I can't tell whether GrUB2 can set any text mode other than 80x25
>>   (I've only found plain "text" to be valid as a "gfxpayload" setting),
>> - I'm uncertain whether supporting that is worth it, since I'm uncertain
>>   how many people would be running their systems/screens in text mode,
>> - I'd like to limit the amount of code added to the realmode trampoline.
>>
>> For starters I'm also limiting mode information retrieval to raw BIOS
>> accesses. This will allow things to work (in principle) also with other
>> boot environments where a graphics mode can be left in place. The
>> downside is that this then still is dependent upon switching back to
>> real mode, so retrieving the needed information from multiboot info is
>> likely going to be desirable down the road.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

May I ask for an ack or otherwise for the changelog entry, please?

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:25:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:25:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299922.511262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6am-0004nX-6F; Wed, 06 Apr 2022 14:25:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299922.511262; Wed, 06 Apr 2022 14:25:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6am-0004nQ-2W; Wed, 06 Apr 2022 14:25:04 +0000
Received: by outflank-mailman (input) for mailman id 299922;
 Wed, 06 Apr 2022 14:25:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc6al-0004nI-5S
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:25:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 587bd082-b5b5-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 16:25:02 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-D0x56RsFPK6kM6PU8f7h9w-1; Wed, 06 Apr 2022 16:24:57 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3823.eurprd04.prod.outlook.com (2603:10a6:803:19::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Wed, 6 Apr
 2022 14:24:54 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 14:24:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 587bd082-b5b5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649255101;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CQMGbuSph1mdv2l3vc6SQzTY0C5EJ114cvI25l2Z4uc=;
	b=gjOQkTQNSem5o7NmFz+/jk8E/aJ1uUO45clCkYI06Y8GV8fQDIW4c3xup+NRGLCfuobX6L
	DoK5XW0/MqH8FRtmLTgBpQyIONL7gdi2GtUsaN67pmf2ReINP7ZiVp256AYA+sgh2M9cYX
	BgWilxjr4BU/dEpvn13dKtF2YxNxbMc=
X-MC-Unique: D0x56RsFPK6kM6PU8f7h9w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AtQm/pg967C2++0701emy3QnC6nkbTAyqCv/oMNBo+no3tq8Wqwaom4OkFofu3bqm4Q3eVelZlR4yynNw6dDK24AZtb+yHgKqaXBRKQSEd6EUelsswqhb42k/M7TO/B3FZGD361CavqMH+Sc+Mpqs8A5fSaBUmjFj0aauAlAsVO9tldZzrP2Cy5XGN39HWHfyrndXult8PNFZTBSZ5kDFMU5aTCiwDuZWS7kaiBTQ5za+VSHeK+hfRQZL02HsejzCgKI51SJvSPDREXQYCCRTSk/e06AOIK7GMoXFxxHI3njAhY9Y/LSeU9O0UNw94lPGHit1jjqnEkHckCcONORPQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CQMGbuSph1mdv2l3vc6SQzTY0C5EJ114cvI25l2Z4uc=;
 b=P5S2Sz6HauJBS2urG2VEk5PoeO9WH5qmolAWTx0HkY+QI24KsNeSTPyfWMAmyZRLairCiXeaSKC9ICqzBaRYY+4BkyhrmlLrUMJy7wl7fcsckb4YYndoVd8IzlcdyNqHOhzDZvXn+v/0KtWdK/ggJILREhmhL3SM25nblQDeUsGC4LkcIOGEtgyXlUbQ9TECcoF7quhe+KB5lezDEAtrRPYAUSV9BkWx/majSmgrJW7k5+bGlGQWSkZEQG6UZgjvKqnGQAG/7BMo9e8PdMtAty27Q2yUqMcG38hD74LGftL0444okzicCe63xAtJsFnJ1TFjRWuSkaUXbhwLcxsvuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5b3c9ec9-48f3-4900-fb98-c09efdc67c40@suse.com>
Date: Wed, 6 Apr 2022 16:24:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
In-Reply-To: <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0132.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::17) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5f5b415b-670f-4120-f1ef-08da17d937fb
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3823:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3823C0B7C8ABECE2071F1202B3E79@VI1PR0402MB3823.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NYbjqaGrveqCKoBiEFaemnTqA3YUdevIPBDf0GrpwZAGV2t5szqiCHhv66AGqEifBFcNgHbWb+ezCmsrsSn0N/tKQA1D7/shVDUUPFBojOZ5zyCfEv6CZkPcmawon3sIoBGCf7jzesdGg/IByaek8bO+eZhA53gm891Gm38Ccbz93+S5HCCJyzSY6/CGtyw8hJMrjGLOAAzT91wzSd1+K8GQT53c2CyObguGBgdJah7hvBKVrtdWolbWPEcE2lfR7aE3NrGeVp0OrB/27OIpEZIw60MmtBQXYs2QA2pv9FJmz8A/TD/OtxGY9GW2T+yEq2+cwbues9W+qWDUr3GHD70VXvxAElGNMAG4JykvaAxve7G65BQhT2ts3BbTR1gIvDG4BpfFXl7cZCjjb1o76XglZX5Z6TzsmS7zclyifIPlmCNQRschEavideb3v2DfH+rM2dB1EYJDpvvB0U38rJWfRd3a/T8sHW/sU4HBbOXxxtArlwxqCJEQ/Klc2c2+pmoIq30QbhLdXpVVegws0ZeSv3Fs4zCEo1ecCsnPccIQH7sUgofGQT1iASJwGOkkjyN9oUpvziEu3U2l4j1ZYlFQwytu/oXV0497vLIokVs4H7x2EEWwvTBl5ihyf5WvSzxrmwAJ0KhJltUR8KM6iL3SkgejShZ74pBniN1rZVfZBtPnVLPgYmgqBpmZ6sNDdWgoe52VH4r03FTPYTFb8FNooeYo2UrdgL8y+/4zqUf0vqFmyl2sZVWaQtRbplcDw8MobsTD7jNA5JpG9L34iv31L8sh2gkXlGjqEiVBnj4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(4326008)(66946007)(66556008)(8676002)(66476007)(316002)(31686004)(31696002)(54906003)(110136005)(36756003)(86362001)(38100700002)(2616005)(26005)(186003)(6512007)(508600001)(6506007)(53546011)(8936002)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RnR1L05TNHpyVmNZazRlTEJwTDd4QlJKMnBqVEJHT0tZT0MrMk40bkg3cGtK?=
 =?utf-8?B?dmFlKzFSMGFHQ0JjdmxBKzljSXJBN2pTZHVIQnM2VG5URXhEeVlnVnB1M1lP?=
 =?utf-8?B?akJuc3NyZGRZc3h4MnR6V0djN2d3Z2o3Uk5TUmFsbDFUcjRsN1BGNmZrZ2RW?=
 =?utf-8?B?M0d2Uk52ZFhJZ3pLdERFdGM0VEpvT1BIV3BvUWVuMEhZb25GbUdEenZjN3Rm?=
 =?utf-8?B?dVdRZEpQSzVlSUV2alBsMU4xVDFUbEpadDZYODkraS9Sd216Lzcwb3FKMnBK?=
 =?utf-8?B?Uk1UaktjeWhDdUdMM0lRYytyd2IwNG9iU0ZXdHFVVVZjaDd4ekdzL3ZiQjRs?=
 =?utf-8?B?TDFOOS9yYjE0S0xlL0pyc1l5Q3hhT2xoWjBRLy8yVllGZGVtODZYVWdkQmlI?=
 =?utf-8?B?d2dEaXBTTnNXaFpubjFpZzc1UXB1QWZldXNKMGJVM3BTVTNqZk16VFpKK2Jt?=
 =?utf-8?B?U0Y2UXBRWFNGL3J2RGxwNm5ZVllKWjFGc2FuMk9iOXIraEFoTnAzV1QrTG1t?=
 =?utf-8?B?TnR3Sjk4R2hmcW9UTmRvNlQ4cTF5cVNrcmo0SGpadnJna2JORmRqTXNnTmNw?=
 =?utf-8?B?WVNWSVEzdU1zZGpiaDIvSmhwQjFjQzNlcDJUN051ZGc3UnNUTDNNVjhMNXdV?=
 =?utf-8?B?RUdVUlRkeFNSMktseDBLS2w3M2h1Mnh4M3V6NGw4NENQek9TUFpJQWJEb2xC?=
 =?utf-8?B?WXc5MnRqMEtGR29EWkMyL1NXZmEvS3FQNGdZTkFYa1F5cjhmVUZUZ2R6Yloy?=
 =?utf-8?B?S0VMSWZSMVlwOEhFUWpoaCsrVithZjFlTHFvWUN0OHRCUmQyM1RBQkZta2VC?=
 =?utf-8?B?QWRVVnRnaDJxQWo0Z3lnMDNvZG84ekd6Y1BoeGEyUHR1aElLZXZtMEF4Uytr?=
 =?utf-8?B?WlJWTWQ2OHZQK3UvcEZjaGxYSVFpUFNqcEJqSG1sdHpIQzRaUC9iVCtqT0pL?=
 =?utf-8?B?RzBkb2ZpNG1UeGEyV1RCN3Y3QUJGUy9kYjF4d3hvT2hHQXVOWjFzOVhid3hq?=
 =?utf-8?B?cndrdUgybWF2eDQ5ZVBadXVoR0NjMHRUcFlhV1dEdlpnTmd4V2xZa0dURG9s?=
 =?utf-8?B?aytBekxFNERtLzYxUjJWZjFJSW5BMjgwRGx2cHQ2Rnk4emhmWHh3YmxqVWgw?=
 =?utf-8?B?MkFLZUkya2t6aXRhQXlLQnMzbEk4V2N6S1NhRTFzZWpjcktTbWRHb2ZoWDIw?=
 =?utf-8?B?RzZscFVrZ2R3ZlNlTXZQVkNiUy81cDF3Z3NUUE5Ob1g3cUNodTdoQVhuL3p6?=
 =?utf-8?B?T3Y0ZWVPU2I2RFRjNHZnT2VFWW0rcFpkd2FVc3F3cWE0WkpOVEZrcWZwVU5l?=
 =?utf-8?B?eGFNeERaZjJseit0N1FhaHg3UkhMeVhPTWFIajlyZGlFYnkxbEc5UUJFSjcx?=
 =?utf-8?B?cTJ2VmYzOHVNaDAwVHdEQzhDSHBaQzdjaWNPaUwvQ293N3A3MGprYnZrYlA0?=
 =?utf-8?B?MVVnY0djQkxNWHFaZHRwWnlsdm96Q2EwWXN0L1hIZzVQMnlPQzBTSE95YWc3?=
 =?utf-8?B?L2dFTTJ3L1BRQnU2a1o5Z29VVHZqOFlhYTZGaU1qTkVPK0szK25Gb1NJc3FT?=
 =?utf-8?B?Ly9IaTlONitGSFNpWVFrSC9CMnFJK1hsUzNHZzhaNnpwRytOejdlS0owcGVs?=
 =?utf-8?B?WUlCWEVFaUJkb2dQMnljZWd6TmdqbjhYZjAvTTVnRFhmcXdmWTVEZFoyZ3RN?=
 =?utf-8?B?ejJkbWRhS1pvdmNObU9TYkl3YlQ5YUNoYW1UeVJZRkRnTlUyVFhIZVdrNk1S?=
 =?utf-8?B?dElJMDhYcFZSYXdjWFVHVW9MUVBONE9tVVJzdVRSdGE3bFVMWjNZVjZwR3p6?=
 =?utf-8?B?d3dFbVBRMmE5R1A2MFRWQXU3WjhoclhBTHJSY1BKSytDNk8wN2RXR3RTeVRN?=
 =?utf-8?B?MEsrYUV4WlFvOFAxckozTEMzNVFmTnM5aHBIbWxNdTFMNGJJQlA4YXFrWnNM?=
 =?utf-8?B?S1JwRGV1UjZVYmR3UnI3TFVqaCtOTlVwbTRqajVqM0xDQWNobTdGZ0djTisv?=
 =?utf-8?B?dG8zR1lEU01oOHNMb05iQ1FTU1RRZlE3L0VXaEdsMlRKeks1SkU0N1Jsamo2?=
 =?utf-8?B?RUtJZW1YNnBsM1g0Skc4cmdhMFZBaC9hQUtlR3J1bVdReXJPbTJuR0pVT2dM?=
 =?utf-8?B?MFRNL0tQVklYeU8wOEVMTzVtbGpNSFMyNEgxSWMzd2hsS09oU09kUHh2QjZo?=
 =?utf-8?B?cmhOY05nYmlyMlIrWE9lSHpnMVh0QnpuT0JkMlU1eElqTzh0U1dxcVJRTHpx?=
 =?utf-8?B?dytidmsycFI0UVI4V2cxcE9ZTUNSanZxSUZUbEplWDFRdnVBTjgzQ21uZ01a?=
 =?utf-8?B?TlYxSExDM0pPZ25IUHdHb1hPQThWNFA4aHM0ZjBGa0t0aFhBb2xWQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f5b415b-670f-4120-f1ef-08da17d937fb
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:24:54.2196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xsv9dxtgcJVoX37hvrVrnrYeQDgNmkihqss+en4f7Aj0NKkaO6fUmCrQuoj3DFroeyMYDn6PjVOTNxLkaljH0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3823

On 31.03.2022 11:45, Jan Beulich wrote:
> When booting directly from EFI, obtaining this information from EFI is
> the only possible way. And even when booting with a boot loader
> interposed, it's more clean not to use legacy BIOS calls for this
> purpose. (The downside being that there are no "capabilities" that we
> can retrieve the EFI way.)
> 
> To achieve this we need to propagate the handle used to obtain the
> EFI_GRAPHICS_OUTPUT_PROTOCOL instance for further obtaining an
> EFI_EDID_*_PROTOCOL instance, which has been part of the spec since 2.5.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Setting boot_edid_caps to zero isn't desirable, but arbitrarily setting
> one or both of the two low bits also doesn't seem appropriate.
> 
> GrUB also checks an "agp-internal-edid" variable. As I haven't been able
> to find any related documentation, and as GrUB being happy about the
> variable being any size (rather than at least / precisely 128 bytes),
> I didn't follow that route.
> ---
> v3: Re-base.
> v2: New.
> 
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -464,6 +464,10 @@ static void __init efi_arch_edd(void)
>  {
>  }
>  
> +static void __init efi_arch_edid(EFI_HANDLE gop_handle)
> +{
> +}
> +
>  static void __init efi_arch_memory_setup(void)
>  {
>  }

May I ask for an Arm side ack here, please?

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:34:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:34:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299931.511272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6k6-0006QM-89; Wed, 06 Apr 2022 14:34:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299931.511272; Wed, 06 Apr 2022 14:34:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6k6-0006QF-5E; Wed, 06 Apr 2022 14:34:42 +0000
Received: by outflank-mailman (input) for mailman id 299931;
 Wed, 06 Apr 2022 14:34:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dnga=UQ=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nc6k5-0006Q9-0B
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:34:41 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0629.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::629])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b072ae8f-b5b6-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 16:34:39 +0200 (CEST)
Received: from AS9PR04CA0051.eurprd04.prod.outlook.com (2603:10a6:20b:46a::25)
 by DBBPR08MB5913.eurprd08.prod.outlook.com (2603:10a6:10:20b::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 14:34:29 +0000
Received: from VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46a:cafe::28) by AS9PR04CA0051.outlook.office365.com
 (2603:10a6:20b:46a::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31 via Frontend
 Transport; Wed, 6 Apr 2022 14:34:29 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT031.mail.protection.outlook.com (10.152.18.69) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.19 via Frontend Transport; Wed, 6 Apr 2022 14:34:28 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Wed, 06 Apr 2022 14:34:28 +0000
Received: from 75c73aa3cbc7.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1610D7B9-BAA6-4905-A6BD-C39307F12F79.1; 
 Wed, 06 Apr 2022 14:34:21 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 75c73aa3cbc7.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Apr 2022 14:34:21 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB4552.eurprd08.prod.outlook.com (2603:10a6:20b:74::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 14:34:19 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6%4]) with mapi id 15.20.5144.019; Wed, 6 Apr 2022
 14:34:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b072ae8f-b5b6-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dkEt8Hq2s5G1yKfv6nnn+BAJnkQ/ANrkC9KsdGfg4BI=;
 b=rD7z0uRuQKqpofh8YW1K+fjl0A2BABgZmdkHaakzrj/EFvWYvwQUaCeeGF7IiF+0QikdJV59nY38feNyFMWL8tSzPFc0dC4/nuVdIBUDVAehDJMqswFs3RinefCgGP8jWQWUYjv5Ae+dLKghWedzpGWtZqiIa8iYSb/YJtFumvc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 37c053ebd1e1f6c5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ms6+Nv7QobBCiRjzcD47Cm4JUoHoIN+V7+cTCZHJpB40ZtOtUhnAhex71E7ZKQvy8Pi/uZGdAVBcwPOWyvRuv0WCz9mrqeaBviGmhkZM7jat8mMXNezFttz81VhlGbM6d6P4x6eyjROByKOP7MoFVjkJhVY5uBIQj4Ww1Hqh7jRHW8Si4KInWV8e/PJtAkrfqjS4eUsMcpl1JjqJDEFGshB8rxsygbmS3i7s956qBpddlUhWHVwlHj4PF4qOCqNZ4oQ8yZGu6NbPFuA2bsL2H8RB5JIBLj2eES4D3aR8+DM/cqSeH8gN589wiU1b9P31rQ/tlx15eEtn8I27UMjbjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dkEt8Hq2s5G1yKfv6nnn+BAJnkQ/ANrkC9KsdGfg4BI=;
 b=mTsiLD70eXW7tWkkcXFfcNgUiyhcnp9eZNXnfmRNY4091QPCVwCMhJKT1yPTWG7MPxBWVRbb5TTizBd8vOLNIkq98Ae9VqgaTXJ1p9DieqJ4eLlVwICr4a1+OTEt02z9mX+LBubS+xmuBh13TEnDEMTLiich4wmf3tWSzcoHPQGkanaeP+nv1KqQfhfl9ljG0Vfd3ymmHG7WaPR0Q4OAnK0aZlPTaAKv44dleyDF2vzVa4k5pzruBz4Db6ECbHAe8F6bY+96SsEPsSSUOjObeN2XuU2z7zOoBCm3h8S8Ur+TGA1/hIYj68sLSPz6SGIWm/hGlJOmiFAQQqrN2LyhwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dkEt8Hq2s5G1yKfv6nnn+BAJnkQ/ANrkC9KsdGfg4BI=;
 b=rD7z0uRuQKqpofh8YW1K+fjl0A2BABgZmdkHaakzrj/EFvWYvwQUaCeeGF7IiF+0QikdJV59nY38feNyFMWL8tSzPFc0dC4/nuVdIBUDVAehDJMqswFs3RinefCgGP8jWQWUYjv5Ae+dLKghWedzpGWtZqiIa8iYSb/YJtFumvc=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <volodymyr_babchuk@epam.com>
Subject: Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
Thread-Topic: [PATCH v4 3/8] x86/EFI: retrieve EDID
Thread-Index: AQHYROQkwx+joMfjCkSw++1xXxejZKzi/QIA
Date: Wed, 6 Apr 2022 14:34:19 +0000
Message-ID: <903E8C67-ADBA-4C96-A748-0AB57B0DDDF8@arm.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
In-Reply-To: <c11d267f-f6b7-558f-18ce-2b081ae12427@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: d91c699e-7396-47ac-5025-08da17da8ea8
x-ms-traffictypediagnostic:
	AM6PR08MB4552:EE_|VE1EUR03FT031:EE_|DBBPR08MB5913:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB59133A5FCF87A4F26472379F9DE79@DBBPR08MB5913.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 9gV0zAfHXhywXYraIcDz8kp1qhhUKwMgGlP42D67TxcriPlSDjc4DBXiHckFfkAGt+oD3bJdibAVMsUC6BkOFbnJzgxIUQ+zEqYYbwCTF5hKFH1xb1yuSwPu/99hkMoVwmuaUAeTkxdlrmNbB6LzNIrxGJBMZ9zH3g5I0ATOixSvSlHTMJFpf2yXJHPNSOK0bTfpeeNA/vQuch2rZh0rh9PmKRfsdaa0ShFvVlLo8cDGPPB42X4HK8uvU8Mr1uRE+YdwJgicebSW9LSCrmsYZyT3oTLqD9kmwOPVc/617vL5IaEdtYPhLrfG1/j54qJr0JTAxzaIP1ruq02rt2kz0bb4NHepPfZd68min8C0iA6XDvRzdS3zsJatKJYGiluMOgR1BUkOCg6TwzzIn8HCi7cFHA7Ydh21C4I5rBQ4dlwYd2So6+6EYQ9TsXC0HZGBRvKJDueABH6ayb8cSiK2uVy+dGAZvcpLcQx1mtX7TZbYMGyVI8UM9WMYUWgJZ8QYh0my66QNtkvgvGcQV5y8z/un+oyF0/OXzippC0D79QaWVoP/b6sozK3eaoiPTZVqUPTBiCTAA9tuJJFebEMPcx97NsC/ntIkDjtP7HklyYXhbbFrldVsCSpS1z39NXfI4uL/BdnTDKFTsQfI8Notkok38793/vKDchumncckPijias9Jo2Uruc5J4fSaQVGuzH9YbwEsxRc5yyph5yQDt1SDVftgw1pwJwUU4ySl7ut0FZoAYFJ/CbVKG1g/zFoF
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(53546011)(5660300002)(8936002)(186003)(122000001)(2906002)(2616005)(4326008)(8676002)(36756003)(33656002)(26005)(66446008)(6512007)(316002)(6506007)(71200400001)(508600001)(66556008)(64756008)(66476007)(91956017)(38100700002)(86362001)(66946007)(76116006)(6916009)(54906003)(6486002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <58A8F6333BC6544F92B0A8A85881CB05@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4552
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1e537dcf-c915-4c0c-5999-08da17da8909
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ry4yOwF7l149jo6fRGK6rnMfErTWebf87axEmo1x7Gj+jNB5UTfnBCuTSaj9pO8VicNes/R+D5q9C72ac5yLskMB/lvZ+A7CjiyNNCVEK/9g69r9An/x0HuKvFLYDKif5xs60Dhfb4HQful1o8fbotqOVKrYie5SthMycPfQjfLxNwzXoNXbBk7xja3ulbznzalsk6JXpdK5F3f23umk9gc415/besFlRySb2rbj+MOk4JGkI2IDeGplECOMIhusWPH2gQbOMiBDhKvF3qTmjvG1DGnj6CkmbfRVJzrd5YRi8s2Y6bMUzFSg20RSGPn2ZtBTelsnlD2JFfE8IzkI/NK/I98psccFJGBa5tO6a74yz3qPPTJCxcHnDYnP4EY7TIWTvJjoOzt1c/LuJaGOPkwZx45Q6gph2A0jHVGc7ejuY/fOxacQ6QSTXi7FOzBs8Pv6uFAQwQDy6+zWG7rKKOsKvbmsaek3GvoiFhm+fGKGKizgjyfRJVrpDekri6UCVFD5kxWe2RWJzz08Mh3s33NGECRA1ia1PM5QA3rhcIbaXIFnDcZX4cz2uWfaoubcEuymYmDVUZyVUjB0ki2KW9GsXxVHeaSU7Tb9tsvQMuF52Fd5rh/5RU0mdmgBQ+Xlv6aOcTtRSr6mS7ozLbZeXLRU+HKC8GtyeifSqyoy33H1jw8g+Lk3v0HwTbfVViGt
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(316002)(36860700001)(107886003)(33656002)(6862004)(2906002)(6486002)(26005)(4326008)(8676002)(54906003)(81166007)(70586007)(5660300002)(47076005)(8936002)(2616005)(70206006)(336012)(36756003)(6506007)(186003)(4744005)(82310400005)(53546011)(40460700003)(356005)(508600001)(86362001)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:34:28.8957
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d91c699e-7396-47ac-5025-08da17da8ea8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5913

Hi Jan,

> On 31 Mar 2022, at 10:45, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> When booting directly from EFI, obtaining this information from EFI is
> the only possible way. And even when booting with a boot loader
> interposed, it's more clean not to use legacy BIOS calls for this
> purpose. (The downside being that there are no "capabilities" that we
> can retrieve the EFI way.)
>=20
> To achieve this we need to propagate the handle used to obtain the
> EFI_GRAPHICS_OUTPUT_PROTOCOL instance for further obtaining an
> EFI_EDID_*_PROTOCOL instance, which has been part of the spec since 2.5.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm

Cheers
Bertrand



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:44:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:44:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299935.511284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6tg-0007yK-7J; Wed, 06 Apr 2022 14:44:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299935.511284; Wed, 06 Apr 2022 14:44:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc6tg-0007yD-3r; Wed, 06 Apr 2022 14:44:36 +0000
Received: by outflank-mailman (input) for mailman id 299935;
 Wed, 06 Apr 2022 14:44:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc6tf-0007y7-Os
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:44:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 135ae4fc-b5b8-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 16:44:34 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-O-OgIMrePVmZKnMezWAYVA-1; Wed, 06 Apr 2022 16:44:33 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4560.eurprd04.prod.outlook.com (2603:10a6:803:6d::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Wed, 6 Apr
 2022 14:44:32 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 14:44:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 135ae4fc-b5b8-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649256274;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=0bgJSju+vdmXtXwH09gQNY2F0IdkUhfF3FPg22gDVs8=;
	b=YB4w3WkPmuJn7Tku5ki5mAgCrDkT21klYVmNKpNda+3icWYcBHXVB+ZDNa9uD9gHsf3owM
	q8c0pREzJS/wDXz8T1Fq1Ek/QIUcC8lxHC9bFEwAQi4K4pNbwZbgMy6tr2jNKiESOtBbXb
	jAZDQZ9ATaE+0rB59PXGAOHUPh5Q57o=
X-MC-Unique: O-OgIMrePVmZKnMezWAYVA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NGF7manSXHSfOWjP/vLdYJmqWCZWfx77J0Xix7ken5zgYZt5d5dq47/7oga+unAZcFJBU6QmN+S/EwaKbhJh8VMgH9UGQ9r1AMiZL+3h6etZy0ppqnnko3fyAM+YbpITIKiAjO6Q2EqxCwbA/EnSM3Tcw8WP/rhLRjIb//JgDfdr08zUn0yEzMkSRg48IIa7w+0Zd7qJDCUCEaarSjgV3DNObUvOxsuQpY7uuRsqOMNoQPA2YblHIN+i0hVwQPJJfqXRGcOAwm6LeqRYkanAx/MzCcANNI78cQhLUJxkg1m5MpI6SD5zUYa6rgod658SlwLQE7za7uQ8FdpK1R0zDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0bgJSju+vdmXtXwH09gQNY2F0IdkUhfF3FPg22gDVs8=;
 b=BOkxYeHn1TnOWsd9b5R8m9wxl7lReAXJzVkA0riihBa74xIUg3N1CZu2cU7ObWg5BzYB442eaE6XO8G86J0Stk/SamST7O5BrVHehRJS1ZaIphxeA7qu68JJ0FyRgWix5be0o9tGsPEQSPNzqAMpJN3NIB7UQG5Cym3FKVfthVgML4Kqj+3MfsFvnk1KX4AfxtxAX3jmWbFoTAw2JmXYVixHJ2WLn0OQqnXAJpNq/gBX/8lRyCLD0wcHNy4edDIrnWp5TCiwY3+93dIR87uui0EsFI0mQpWNaiKJGP6Djm5LCpUTjhOyEi1w0xTHEM9iPGzLiAUtdUqklVv7wY8Z8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4c49e4cf-9d86-e630-a1bb-37afdf091c99@suse.com>
Date: Wed, 6 Apr 2022 16:44:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] SUPPORT.md: extend security support for hosts to 12 TiB of
 memory
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0196.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 40d9a057-a3c0-4014-00ad-08da17dbf639
X-MS-TrafficTypeDiagnostic: VI1PR04MB4560:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB45601CCE50E9C1B16D19F477B3E79@VI1PR04MB4560.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BiefOBBboYpNSfMitqsuBuO8tmCnauCn+Yw29t5FlRcaUtHb6IKa6gxBvXgKKM0IerTw0SWQTHSiPeHhRkte2HjnLLVa0zRAonmh1qhJSbu9XgjiWtvZh8Hk2PpiiRI5kT918wN7OghD63pnphbL/t+LPkQTcMc5TH6G27ZZSZ4ql/lnUsD1AuaQkRZJYkow+spohn1EQPSmOJKu5XEkkEeKOKOdLC2m3bCQLKeqUzeILyPmX2DY7q98Vj1hbo3gLV/PwawqNGwawq5S4340WFgugg1zx7oxvIgHmxrL6MMW06/WeVSWw2qU0xDU8hQrMmVJWDVLn6NtMfbQEwKriGghuX7UcuOHUcn8PujJhJ1FPeSToylunM8VAfwRYTtb/eCZhTATzsmASbnuUorehWoNr5xqD30oo367R8FNcZQHz4tPHqF2mUNOe8Ep934XaUbjpz3YuulD2O3TnL77B5e4WhL+LUJx7Ssr9RRi2wZQ+9Umz+xd/62r5dUZNZAulFDaHo5h9k6Sa9lhEOQP/S2q2BivctIi/hE3nA9OqQkewgGfEzc9DBNlpqtuiYLe//29MgtY73rBrz9H/bBYvaxrfUTqA/jnYmpepKKA0d7hF2AQj6y7Lp8cgw5a4hCMbHSLtDq08sr+di84BKuxU09/q/TWZCM+83QFiEttvDvSktVc88/3ZFRQt6gGbJc0RdmadXLYoIeaaHCHyyxoz4aCm0q+QbdIEyU5VpD8AN3ZRqqSjn2Dv0Xdn6Fx/DfsBiJo9KZAk1NigqfoD/4qVgG27A+G+aYMQdleuHUcz82gkxCOcBbA4ZZKvhKrjNjR
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6506007)(508600001)(966005)(86362001)(66476007)(6486002)(6916009)(316002)(66946007)(4326008)(31696002)(8676002)(66556008)(186003)(6512007)(26005)(2616005)(38100700002)(83380400001)(15650500001)(36756003)(31686004)(5660300002)(8936002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZHBPdWxhUWNOOHRqRUtVUVJkZUlGM2VUWWRxVEw0V2VBK1lOZjFZRCtseW1i?=
 =?utf-8?B?YmZUWEMzem1JNEE3OEZzajhWNEVoeHltdGRpdVQ4QmJTbW04akdRWFRGUjN3?=
 =?utf-8?B?MDlzbXNuVUFVQ2ttcTZBb1laR09heXJqYWtabEtjQmg5QmVoQU9SUTZFUXM4?=
 =?utf-8?B?SkdtMG92LzNGSHlMMUI4MWNhL25uVEhYM3h5aytpU3I3T1BVN2QzQWFZbHJJ?=
 =?utf-8?B?aEQyUjZ4RS9nYUNhMDhlUXpDbjBSVnNLMUxjUHdWaUw3dmZjSG4rTUFuSTlJ?=
 =?utf-8?B?a0hmQjNkTVRvV0Y0R1lzUG5ZeFd6RDliRnpzU0RQM2pJYUI0RERneEl0djVK?=
 =?utf-8?B?cDlvL0kxZmpwUkxtMWNjNmNPTFRiV0lCS2lJTm9JZ1Z0UE0zRkJPbFlzU2Na?=
 =?utf-8?B?SVVQM0tXZFpxVXVreWNseTJyK1MzL2IxaFhtZTJkWjV2RmtGNlYwNFRHS1pj?=
 =?utf-8?B?emR0M0RXZExlcE12Y3BKNGNVYlFmaTFHa2FRVGVLN3UyU3g4aEpObW5kM1Qx?=
 =?utf-8?B?RE9qTDhxVGN4VWtabWZUYURHeE5iQjQ5bEtLTytwekxFajVVcVJOdWlCYXZj?=
 =?utf-8?B?MEs3dWI5RHNNSXd4UjJZNjhkZHg5UW5jc3Q3UXBCVkdlamV5Y3c1UjZoTzV3?=
 =?utf-8?B?d0VteEZUcGtVVnJjb3FzbktyVzdSQ0o4QWtlYXR4Mnp6K1JQWHJGN3FyMk9V?=
 =?utf-8?B?d05jTm05YUlHSHY5TlVQWEZYcWJuUXZ0WWlVWkxEaDFDblorR0pqR1VGRmNF?=
 =?utf-8?B?VkxTcHdiK3gzMmdsdEJlb0FFQ0Rac0ViM1ZkWXR2UFdISTJqUm9PN1FTVVIr?=
 =?utf-8?B?ZnJ3K3NIbHlRaWNVSnRRMlhPR1NucWVxYzdzRDJISGpIMmhqWkltUHFmUkp1?=
 =?utf-8?B?RGNNbExDK242Sy93TE56VFA2ZHNneTFlNC8wMXBaY3dWL2JzZDhFM1c0NU1H?=
 =?utf-8?B?UWlMTWpwNzQvRXhYd0g2bXVvbXZnTEdXaEJJdlU4Sjhib1FFazVyL3N2TUVx?=
 =?utf-8?B?a2l6MWpKQXZsVEMveGo0azJrUCtvM3A5SkY1RDB0WTJtVFdMU2FOSEJjcUFu?=
 =?utf-8?B?SWU1akJ0R2xnc0MzQjNjQ2JmcXBhRUhpZ1RKVXJ5OXFaN0lmS3pRQ1hqd0FX?=
 =?utf-8?B?TXNPSmQzdzJYb0VrU0ZJbHNPZmJmUlM2VnJyOW04ZkVZSlFJUGc3a1VGeHBM?=
 =?utf-8?B?QkRJVHVYL0JMQW9MYy9hN0w1Q0EwcW9WT0toUEtZVUhvcndsNDRucmp6aWtZ?=
 =?utf-8?B?Q00rUTEzbTRxS095TnlKY09ZV3hMWlQyc21Udm85YlFsUi9TQmNYYnJHaDEz?=
 =?utf-8?B?eC85TlJnYXhlT0dweDFCMXBENU50b041UUN2UHZGUE9pM0ovOGZTcjRjck5E?=
 =?utf-8?B?RUNRTUhlbERtV0lYckZMR3lPeEgySGhtM3JYeWFFNVl1OExQL210K2FHdFBO?=
 =?utf-8?B?eEg3VTRuajJQR3NtRnZ1TUFVN1dKUVE5SHd3amtGSFB5dnNDalVXUjd1cm5T?=
 =?utf-8?B?NElwVXZpblgzN0R2dFNwSDU3S1N1YW5aMWZQZzJJckZ5RFhwSGtKYVQrazNF?=
 =?utf-8?B?Q0dCR3djOVFabTRHcVVOZXowZkQrTlpHSUtDWnZVSTNYNnIrSVVHRzNjdkYz?=
 =?utf-8?B?SUMybUZtbGp1R1BiRjRVb21oS1l6MVRURitiM3RRdDF2UEd3QkZwcnZYdGVY?=
 =?utf-8?B?ZkxpNzFkNXFaYU1mZm9qaUJDSERkSmZkVHJVMTNEYStady9sN0x2bUlwY0hQ?=
 =?utf-8?B?R3BDLy9lS29lMXdxTUNobmdtbnp1ZkN5alZIVFZFMS93eU5NVnZhREN1UDhB?=
 =?utf-8?B?dXkybEZ2end6Nzdwd092VW5qQlFzMVkvNDlPNlZDL1NTRnVvdDZPZDVvNFJx?=
 =?utf-8?B?RHdJTzdmYmp6dEJ1TWlCVTZhS2drc0ZVdkJIUXlTOW8yREJubTd1ZWVFN0lj?=
 =?utf-8?B?WURpS1dMK1dEK3JFVlFVVVZ5dzBydS9hZHMyaWE5VVdObndTd0ZGczU4azFB?=
 =?utf-8?B?MWNGR3JhS1JsaVFHdGQ5eWpEa1d1alVFYlBMUHl0SlZxSlBsT3B1Rm5GdDcw?=
 =?utf-8?B?c3FqM2RWbUxnQzhCeGpKZFdwWGh5ZkdHcHVVWkdsSzBpTkVLbm9aSVZ5Uk9P?=
 =?utf-8?B?MkZybVJUU245ZmZMUlJ5bCtXUVRmb2M3MmxxZ2kzTU92WUlnZVB6Z1MxN3BO?=
 =?utf-8?B?d2JFS2VPS3RoSUdZVnVFUkFxVkhHYTBZYy9mRzhOM1JUSDVZZGlKT3Z6Snl5?=
 =?utf-8?B?bVdxVCs3clYrSkFvTyt0aW02ejlUNUZIbk5yaXBBRnBhbTR6SUxwQk8rRGhQ?=
 =?utf-8?B?TXh5Um43UHRVS0RsZUExVXJVb2FNUUNkY2pSUWQzN2FNVklIcXlCUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40d9a057-a3c0-4014-00ad-08da17dbf639
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:44:32.3960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D7dQvxpCXoJGz/WjHR+wzHswkjJQHKLEwWhbc548r2J6/u4wl/vMDsD1EdPKvYzoxRxw00A/YhMb5su9joS4nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4560

c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very
much memory"), as a result of XSA-385, restricted security support to
8 TiB of host memory. Extend this to 12 TiB, putting in place a guest
restriction to 8 TiB in exchange.

A 12 TiB host was certified successfully for use with Xen 4.14 as per
https://www.suse.com/nbswebapp/yesBulletin.jsp?bulletinNumber=150753.
This in particular included running as many guests (2 TiB each) as
possible in parallel, to actually prove that all the memory can be used
like this. It may be relevant to note that the Optane memory there was
used in memory-only mode, with DRAM acting as cache.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra
 
 ### Physical Memory
 
-    Status: Supported up to 8 TiB
+    Status: Supported up to 12 TiB
 
 Hosts with more memory are supported, but not security supported.
 
@@ -121,6 +121,14 @@ ARM only has one guest type at the momen
 
     Status: Supported
 
+## Guest Limits
+
+### Memory
+
+    Status: Supported up to 8 TiB
+
+Guests with more memory are supported, but not security supported.
+
 ## Hypervisor file system
 
 ### Build info



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:52:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:52:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299940.511295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc713-0001B9-Vz; Wed, 06 Apr 2022 14:52:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299940.511295; Wed, 06 Apr 2022 14:52:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc713-0001B2-T1; Wed, 06 Apr 2022 14:52:13 +0000
Received: by outflank-mailman (input) for mailman id 299940;
 Wed, 06 Apr 2022 14:52:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc712-0001Aw-NB
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:52:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 239ac2b4-b5b9-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 16:52:11 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-q5TUcGPeMT2RVzNeeGausw-1; Wed, 06 Apr 2022 16:52:10 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB4825.eurprd04.prod.outlook.com (2603:10a6:10:1b::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 14:52:08 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 14:52:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 239ac2b4-b5b9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649256731;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EXxMUPdjJ0cPh9pY6piCGH82AFpiP8wrG9npPLLZqik=;
	b=P1J3vpDiuVrjhmWyt10ehTITygUseGVBs73ngIBpJyKLi2tFZ8qG3Y0aZAoHHYvXXb6aSy
	toBj2tXLVHYWTt3Ua/aStZNK13rYPWxTP+p4FSnJDlLCi8W6k2zqqY44D03Uzv184k2Owk
	z4TChXlGLqY0WWv2jxkhsFkZhzicpAA=
X-MC-Unique: q5TUcGPeMT2RVzNeeGausw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H8X08Sh1wTz1cfGCirosAnwvxguMDIoKSnEirXWqeR1JvnZ0V9cseq5sbjPeNYuAEVffN80ObkAk0Jw4PBABryveVno6rRcCG+simshaWvDyAJa/7RGFMpZOv+XiR8ON9iCsJmxkwpb6+FaVotl4tKK9sB7kooTuVOHU3HYnKf8m2QatFP3hk4Z/usqhgxPIBfnnsJ/9NR6R82tEiOnSc4YE0AOqyyJ8AamReGh18P0E6XFi4w69NWvUdmrKIKQG4BTVprxfQni3HMj+fwj7CouH/4427re1cZTIDezZAONm/KLHXV4mhaMT/Ero8PxL29f5dOnagWPvuURN3/+a1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EXxMUPdjJ0cPh9pY6piCGH82AFpiP8wrG9npPLLZqik=;
 b=Tqb7TcikpFANGQjiy+PWMAf9WSRDiGGWu8H14jgVtoq7VB3C0YQfQ9J9qmHzADGWfufzn5GBrGLcg3djjpTH6pZUfOLFJvJLJ6KajXON2/H1CNaCy/zN08hO/0DBFKOq+htkCZCgwG4iZWAb9zUT2LLQLUEWWg4jdjdfw9RV5kw5aZBbjXbqz9ZjdZ88qdDspS2rCEp9X8LgNYk42J1AMX3HlTPnnQ3nXSoFwDhXx+gQz59yXvJM3GT3e/2+G572jRhDbepiN8OXUv9B849Gkf6pUvot1bl0w/VcSu/F6ZpB2z8skdc2MDIFfYFzAFWN3PpJ2Egp+cjn9GuqJGCCxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ca77d916-a283-f3f0-d813-eeedac1c5098@suse.com>
Date: Wed, 6 Apr 2022 16:52:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV
 and HVM parts
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <69623630-cda7-9b2b-4f2f-09a83d5dc22a@suse.com>
In-Reply-To: <69623630-cda7-9b2b-4f2f-09a83d5dc22a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0546.eurprd06.prod.outlook.com
 (2603:10a6:20b:485::7) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 69eb8de8-7cb1-430f-81d7-08da17dd0607
X-MS-TrafficTypeDiagnostic: DB7PR04MB4825:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4825664D5CFBAF8BBB9A2E75B3E79@DB7PR04MB4825.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xak7c9pKrYwBaq0zU1pmEDZw6MQROytuhKuhd+bYnTY0SZP+z2gJZc6+kiWJU2ySCAgyB7h52hUWNeRh2SBiZxIbweSSDb5Swi0l4wd1zxgTjO6mki1W9p+C5CYl+QXY4cMr7t2beIFeY/avde0SN2jkIw2TGNssby2X7gM0XPt3Twt4bIU1s1mRbC7HC1C6gqWozeMvuUeiwFbxbqm3B7YV320Lq1relD5szNcRcbQGxNtlniZHdRHcKpoO4PbQko7Sa8gFedYHwnhwK54ZO4JMqXXz9SMT85/ynLPAR92e+P5kas+nY/6xQIsVimn7LlbikZtnyZxwszWlKv44KER8uTWeDNbpssAOrMC7xqJLZfU3gRXqgC8RlmCeEvLniZ8unBsnqamYvtCXJvHrZ2Nh3WAnB2MRfcnspDtGpcaXtI+1w/BoNwU842hzQ8ffzN4kAlo6wRbCpOMAngdpo1ekiCFXgV+/v0sBB628rR6mF4bLHXV4UptyqxpSLp9FhaV61kAEVJsg+6INBlrq2dJRqHBBCkyfGYcyC/y/XL7DfSKte/i8BWJ7YbLT0i8UEguhtH7ez9FKDi3HiQr/NKr1fgHDt2XHvEewx5EEPydaJfGYSL7Of4Hh8DWIEBvR9Z8guM8dfNRjERsPOA0vfMJsDggfc6VWVz9Z8/ZuDdO8/8RJY0uEHB/qmhCzcSsNML3t0Jot2QwFfpEGXtkzr1DkcLkBQf3Rr006D1NlninMYS6RgQO22vvr4SmQROY1xP5qxzN08RDUZlprORWrIw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(4744005)(36756003)(2906002)(8936002)(31686004)(54906003)(186003)(26005)(38100700002)(508600001)(6916009)(66476007)(6512007)(53546011)(86362001)(31696002)(4326008)(5660300002)(6506007)(8676002)(6486002)(66946007)(2616005)(66556008)(70780200001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cUpseTN5VHYraFFzd2F1dm90eGhPZHlqT1pyakp6dXd0blJ0Zmw0eHZQbkUr?=
 =?utf-8?B?N2NTM3ZXV0FCTDh1QnA3RENocG1FUjJCSngrbGRDT0NiNExFMG9ZcWFmcjA0?=
 =?utf-8?B?UnF3SGtna1ZSV0pJRXpiaXgyb29zazRYOHZmNXJqWTB5bG0wdmx6MjZ5UWtp?=
 =?utf-8?B?WnlHaVpBTHdzOC9uK3lqZHNCTVZac2ErZ1VDc0JlTHlzS3BrWEVxbFRlVXdB?=
 =?utf-8?B?M1NSMGdGUmhvaFRURWU1eCt6T0h0cE5zV0FBVzFYOEJvNjdpdWIwaXVCSkNC?=
 =?utf-8?B?azc2RzMvZDcxcWxTNVZ3TFdJOFFSL1AyeS8yT1ZHZy9kdVFDRjdhR0U4RDdE?=
 =?utf-8?B?bzd0VkcrRUg2aWdiclpLdXNTUk95b1NtYk1CNDFvSFRXbCtZakpMM3Z5d1Bq?=
 =?utf-8?B?N2swVDVKTW8rTlhMM0lqRXhyL2haU08zbndPekxCYWUrbzJIREN6S1pZeUFD?=
 =?utf-8?B?L3UrS0VONkhsdnVxOUFjeCtwOXRjUG0wd004VlRkLzNNMFhOZzVKZEhpMXly?=
 =?utf-8?B?RzdWMDdUOTFPNWVKU3BlWWQwZjM3N2lVRnAyRkNPS283Z1FBSDlvQ05CcDBV?=
 =?utf-8?B?bVhVZlRzMEJqUVgxc0tSZTFMV1NvaDJ1cWVnY2YyUUpUdVFBdVorTCtBTnlp?=
 =?utf-8?B?cU5vNk0wSUZOUUdsY2k5UHVta0l5a2RDNzRkYldwMUkva2NHQUxlNHZvVHND?=
 =?utf-8?B?SlVUREtUaUtUbWlKSVFMOFpQN05RbHV2b0ZsUFlHWGFvNnY0OXZEa2JPOEJK?=
 =?utf-8?B?d1JRaXpFU2R4K2NkMVJXbjNqSGtrY2dnd3JXalFmYnZJTDZvMGNlc3NJZTRl?=
 =?utf-8?B?VlpxS3lZSmhUQUM1UnhJMWJrQ0w4Vi92TmRWVFZjOXRLUTdBWTU0WGcyYXJP?=
 =?utf-8?B?SlV1eEpuTjRYc3dWb3phRTNva3k2OC9kTUxqZHRNeXNpUWFuckxEM040TGpy?=
 =?utf-8?B?aFVsa0NicVBWbFBxVzVhTEVHakdLbGdIQXM1SVE0NUc2OEFOVHBwbHJsakFN?=
 =?utf-8?B?ZVlKQXY5L3Q3Njc2ak9vM1QwUW9yeHR6alV3RzBUSFJrVjd1N3FPNG9OaUFG?=
 =?utf-8?B?V3VYQXoyT05wTlEwWS9RWlZPNnJDOE8rTm5RWGxEV25vY250L0tXY21uZjRM?=
 =?utf-8?B?VnBPL1E4YnVjNWtkcE1keGR2dktndGdKcUdpdXltL3pvS0c3UjBEanF3dGtX?=
 =?utf-8?B?cUhCTFNZMERvQVEwR0k4UnZGeXdtbXhER1Z2R0dueCs5cFdMa3JZZXQxa2Fm?=
 =?utf-8?B?clZrWDUzcklOQjZMSGhrckVhaW14dk5KaHhWSk9tUU5YTjVING1TZWkzMjg3?=
 =?utf-8?B?NWFDSzIxekZLdlVSbzN4ZFVpN2JWVGtQeGRlOUVrQVd1Zmc0MTU1S2VXNlNI?=
 =?utf-8?B?SFJadEtOZUJHTm5oajlVdDhqdDY2WG9RUnFUYzJVWWRtQ3owbEkyd1hIb3dt?=
 =?utf-8?B?ODUrb1NTQ0YxdERRelNYSEFuQmthcGJMSXF4bjhmUGkyOHAxQXJpM3RTUWxo?=
 =?utf-8?B?Wkl6L0RPRnJlbzdHZjYxdzJ6dlhnTXlEN2srUXJmR2ZkekhxZ0tHdVcwQUV6?=
 =?utf-8?B?bTk2bHhVakpHRGQ1NGhBalZEeEZ6OWhlZXlGMVlsMmp6MzY1WW9vSDlLL0pp?=
 =?utf-8?B?RzkrNDRBTzZKYXJlVUpWTUZNRnNUakZ3c0FPTFBhb2p4QnArMFkzeDVzRERZ?=
 =?utf-8?B?QzZRS1oydENLRlV0Vi9RNWQvaXFleE1mbktMZjI3bEpSb2pXdTVpZmQzYTFX?=
 =?utf-8?B?UXlIYmdlcE1WeEtSWEJnVUxJUVRaUGwyUHlIQ2ducSs2QkYxbUZva040TWJa?=
 =?utf-8?B?Q2pCeDBRVTNUblQ1ZDhlcVUwTEFFdmpCNFlWNG52L0dEQ2JEZWhTL205Vmc4?=
 =?utf-8?B?Zk9WdTNRRVh6NFVWRnIwZ09CQmpIVmV4eFRuRmZab2llY000TmxMcnhOT2Zk?=
 =?utf-8?B?ejg0b1NlWnZISXA5R0wyNkRiSnNsSkIxbWZCT2EwZ3JzT0wyT1hGVHNIVVpv?=
 =?utf-8?B?OTF3ZVhzZ1RWWmhSSk41b05jaTRMV2ExYkl0MXIvQlAwendPdGozdXhjaVNB?=
 =?utf-8?B?L29Ddy9HZ21xbHBTUmw2UFpMVGRHN2IzeUFxTkJBRDFxYUZoWGpYOFJFMlA2?=
 =?utf-8?B?VFVXT0VGTWV0VW5wdXZQMmpyL200L0Q4Q0d3a0sydE1QR2Mveks2aGJ4QVl0?=
 =?utf-8?B?bE1nNnZKOGt6bVFzZWNFVVQ2OHpJWFNtQWpTRGJaaTczU1Q4aEcvSnJQSVJU?=
 =?utf-8?B?cW9NZEFIWDJDdHhLY01heDFyZEhTeWhrQmpWQUozb0JZVmdmaE4zanJ0ZmZP?=
 =?utf-8?B?UThGUjdiZ2pRS1lKNlI4Qm9hbUlTNFU5b1YxZDFFbnpxVGJ0emZZQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69eb8de8-7cb1-430f-81d7-08da17dd0607
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:52:08.3962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bUjN/TXhviCfWnc3AfAxCx4k8WxFx29knA5B/EpbO2zPAEKe7ZYkuq2+H+Sz9CCzx5ot9qRBu1bxjqrIbtwivg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4825

On 23.02.2022 16:59, Jan Beulich wrote:
> ..., moving the former into the new physmap.c. Also call the new
> functions directly from arch_iommu_hwdom_init() and
> vpci_make_msix_hole(), as the PV/HVM split is explicit there.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: George Dunlap <george.dunlap@ctirix.com>

May I ask for an ack on the vPCI change here?

> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -409,7 +409,7 @@ int vpci_make_msix_hole(const struct pci
>              case p2m_mmio_direct:
>                  if ( mfn_x(mfn) == start )
>                  {
> -                    clear_identity_p2m_entry(d, start);
> +                    p2m_remove_identity_entry(d, start);
>                      break;
>                  }
>                  /* fallthrough. */

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:56:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:56:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299946.511306 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc74g-0001s4-K0; Wed, 06 Apr 2022 14:55:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299946.511306; Wed, 06 Apr 2022 14:55:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc74g-0001rx-H3; Wed, 06 Apr 2022 14:55:58 +0000
Received: by outflank-mailman (input) for mailman id 299946;
 Wed, 06 Apr 2022 14:55:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2ELh=UQ=citrix.com=prvs=088becc42=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nc74f-0001rr-BH
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:55:57 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8909442-b5b9-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 16:55:55 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8909442-b5b9-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649256956;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=HWzvp88MpAB2kGhzPVFI4VupZOnvLCOztJTzESTZhEM=;
  b=AfFqL+RWZItJ1d49xj1uwdJedS4060SWkyn04p0H3A9g5SGwtxaEfzBc
   LL4VDfIz+GHKEFvwV4lhaDUkdERGPIrEGbCJkJuvx43vDSC0BWOXeGEag
   RrkDYMVOstCu3qoJdqw6+qSV20MM5OBHJqRI6AX0KOQWGwefGeXIROFyI
   A=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68180664
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+gYqy6ne+v2w8lBjcK70KXro5gxGJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXW2+Ha6uOYGb2edB+PNnk904C6JXRztZmTQJo/yE9HiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW13V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYVgUpA4ucxN0maSJZTydsbZF596eYCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHOWM/NEqeP3WjPH8eS4sYgMGK2kD+bjFahknJnvY68TTcmVkZPL/Fb4OOJ43iqd9utlmVp
 yTN/2n/KhgAMZqUzj/t2m2orv/Cm2X8Qo16PL+37Plxm3WI23ceThYRUDOTpeSygwiwUtRUJ
 kgQ5wInt610/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQNYrrtMsTDomk
 FqAhcr0BCdHuaeQD3ma89+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznUdRjLYjl0uTOIwrxn
 zaY/BQBiK1MpJtev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5
 SVfxZDChAwbJcvV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS
 BKL0e+yzMUKVJdPUUORS9jvYyjN5fK9fekJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M
 przWZ/yUSdDWfg3nGrmGLx1PVoXKsYWnz27qXfTlUrP7FZjTCTNFedt3KWmMIjVE59oUC2Kq
 o0CZqNmOj1UUfHkYzm/zGLgBQtiEJTPPriv85Y/XrfaemJOQTh9Y9eMkeJJU9E0xMx9y7aXl
 kxRr2cFkTITc1Wccl7UAp2iAZuyNatCQYUTZnV2Zwv3giR9Ou5CLs43LvMKQFXuz8Q7pdYcc
 hXPU5/ZahiTYlwrIwggUKQ=
IronPort-HdrOrdr: A9a23:ErGQoakK8SSytw+n7cqRWIkKyq/pDfIC3DAbv31ZSRFFG/Fwz/
 re+MjzpiWE7wr5OUtQ4+xoV5PhfZqxz/NICMwqTNKftWrdyRaVxeNZnOjfKlTbckWUnNK1l5
 0QEZSWY+eeMbEOt6fHCX6DferIruPqzEniv5a5854kd3ASV0l3hz0JcjpzPHcGPzV7OQ==
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="68180664"
Date: Wed, 6 Apr 2022 15:55:43 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Luca Fancellu <luca.fancellu@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>,
	<wei.chen@arm.com>, Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v5 1/6] tools/cpupools: Give a name to unnamed cpupools
Message-ID: <Yk2p73WCT5Gi85vK@perard.uk.xensource.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-2-luca.fancellu@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220405085741.18336-2-luca.fancellu@arm.com>

Hi Luca,

On Tue, Apr 05, 2022 at 09:57:36AM +0100, Luca Fancellu wrote:
> diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
> index c99224a4b607..84286617790f 100644
> --- a/tools/helpers/xen-init-dom0.c
> +++ b/tools/helpers/xen-init-dom0.c
> @@ -43,7 +43,9 @@ int main(int argc, char **argv)
>      int rc;
>      struct xs_handle *xsh = NULL;
>      xc_interface *xch = NULL;
> -    char *domname_string = NULL, *domid_string = NULL;
> +    char *domname_string = NULL, *domid_string = NULL, *pool_path, *pool_name;
> +    xc_cpupoolinfo_t *xcinfo;
> +    unsigned int pool_id = 0;
>      libxl_uuid uuid;
>  
>      /* Accept 0 or 1 argument */
> @@ -114,6 +116,37 @@ int main(int argc, char **argv)
>          goto out;
>      }
>  
> +    /* Create an entry in xenstore for each cpupool on the system */
> +    do {
> +        xcinfo = xc_cpupool_getinfo(xch, pool_id);
> +        if (xcinfo != NULL) {
> +            if (xcinfo->cpupool_id != pool_id)
> +                pool_id = xcinfo->cpupool_id;
> +            xc_cpupool_infofree(xch, xcinfo);
> +            if (asprintf(&pool_path, "/local/pool/%d/name", pool_id) <= 0) {
> +                fprintf(stderr, "cannot allocate memory for pool path\n");
> +                rc = 1;
> +                goto out;
> +            }
> +            if (asprintf(&pool_name, "Pool-%d", pool_id) <= 0) {
> +                fprintf(stderr, "cannot allocate memory for pool name\n");
> +                rc = 1;
> +                goto out_err;

Could you rework this loop so that "goto out" is always the right things
to do in case of error? That is the function would always free()
"pool_path" and "pool_name" regardless of their values, and we only need
to make sure both are NULL when they are already free. This is to avoid
having several path in case of error, as this could result in mistake
later. If there's only one error path, there will be less likely to have
mistakes. This loop, at the moment, is using three different error
paths: "goto out", "goto out_err", and no goto followed by a standalone
goto.

> +            }
> +            pool_id++;
> +            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
> +                          strlen(pool_name))) {
> +                fprintf(stderr, "cannot set pool name\n");
> +                rc = 1;
> +            }
> +            free(pool_name);
> +out_err:
> +            free(pool_path);
> +            if ( rc )
> +                goto out;
> +        }
> +    } while(xcinfo != NULL);

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:59:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:59:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299951.511317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc78Q-0002VG-4q; Wed, 06 Apr 2022 14:59:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299951.511317; Wed, 06 Apr 2022 14:59:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc78Q-0002V9-1e; Wed, 06 Apr 2022 14:59:50 +0000
Received: by outflank-mailman (input) for mailman id 299951;
 Wed, 06 Apr 2022 14:59:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xjgL=UQ=intel.com=tamas.lengyel@srs-se1.protection.inumbo.net>)
 id 1nc78O-0002Uy-Gn
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:59:48 +0000
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 318b2153-b5ba-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 16:59:46 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Apr 2022 07:59:43 -0700
Received: from gtomasze-mobl1.amr.corp.intel.com (HELO localhost.localdomain)
 ([10.212.34.72])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Apr 2022 07:59:40 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 318b2153-b5ba-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649257186; x=1680793186;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=m87phGhqUng8DBgUZHPkKJ9RkTLrHt17zXPaorFZAF0=;
  b=aVciBucQnfhEL/AMUPgyueo0mIYtD6tmXBj1uV5mq2q9MkUb5pkehY6f
   H/32ZsIvXknayv/Onsl0eYrIL1P2MXqRGmBiDEW4FI8jFu9MgGV+tHV7O
   FQ09fq2tkhByj33O9veFElDnvnGRZfgxSYBp97egIAkeqF4XJgaIU+ii8
   mx/a+470WHH+VuzzurV5LAXZ/PKvaUqPsNeqcfOnPuFis7+ETKr2xKG/1
   O0clU9DtS8iXJuNL21wntF/l45wmMc5j5KOLydO/RZkpO1HN85WnWCq5u
   8UEzrHdx3tRNYUPHkAMY05ibMPe9I2csFDoDf1PjimMoQycQjMiOKP22T
   Q==;
X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="258661131"
X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; 
   d="scan'208";a="258661131"
X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; 
   d="scan'208";a="658563096"
From: Tamas K Lengyel <tamas.lengyel@intel.com>
To: xen-devel@lists.xenproject.org
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>
Subject: [PATCH v3 1/2] x86/mem_sharing: make fork_reset more configurable
Date: Wed,  6 Apr 2022 10:58:21 -0400
Message-Id: <d1a7a48fa2d46c6a6cbf8f93926a8839aaba92e3.1649256134.git.tamas.lengyel@intel.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Allow specify distinct parts of the fork VM to be reset. This is useful when a
fuzzing operation involves mapping in only a handful of pages that are known
ahead of time. Throwing these pages away just to be re-copied immediately is
expensive, thus allowing to specify partial resets can speed things up.

Also allow resetting to be initiated from vm_event responses as an
optiomization.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
---
v3: Rebase on simpler approach after dropping empty_p2m feature
v2: address review comments and add more sanity checking
---
 tools/include/xenctrl.h                |  3 ++-
 tools/libs/ctrl/xc_memshr.c            |  7 ++++++-
 xen/arch/x86/include/asm/mem_sharing.h |  9 +++++++++
 xen/arch/x86/mm/mem_sharing.c          | 24 +++++++++++++++++++-----
 xen/common/vm_event.c                  | 15 +++++++++++++++
 xen/include/public/memory.h            |  4 +++-
 xen/include/public/vm_event.h          |  8 ++++++++
 7 files changed, 62 insertions(+), 8 deletions(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 95bd5eca67..1b089a2c02 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -2290,7 +2290,8 @@ int xc_memshr_fork(xc_interface *xch,
  *
  * With VMs that have a lot of memory this call may block for a long time.
  */
-int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain);
+int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain,
+                         bool reset_state, bool reset_memory);
 
 /* Debug calls: return the number of pages referencing the shared frame backing
  * the input argument. Should be one or greater.
diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c
index a6cfd7dccf..a0d0b894e2 100644
--- a/tools/libs/ctrl/xc_memshr.c
+++ b/tools/libs/ctrl/xc_memshr.c
@@ -257,12 +257,17 @@ int xc_memshr_fork(xc_interface *xch, uint32_t pdomid, uint32_t domid,
     return xc_memshr_memop(xch, domid, &mso);
 }
 
-int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid)
+int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid, bool reset_state,
+                         bool reset_memory)
 {
     xen_mem_sharing_op_t mso;
 
     memset(&mso, 0, sizeof(mso));
     mso.op = XENMEM_sharing_op_fork_reset;
+    if ( reset_state )
+        mso.u.fork.flags |= XENMEM_FORK_RESET_STATE;
+    if ( reset_memory )
+        mso.u.fork.flags |= XENMEM_FORK_RESET_MEMORY;
 
     return xc_memshr_memop(xch, domid, &mso);
 }
diff --git a/xen/arch/x86/include/asm/mem_sharing.h b/xen/arch/x86/include/asm/mem_sharing.h
index cf7a12f4d2..2c00069bc9 100644
--- a/xen/arch/x86/include/asm/mem_sharing.h
+++ b/xen/arch/x86/include/asm/mem_sharing.h
@@ -85,6 +85,9 @@ static inline bool mem_sharing_is_fork(const struct domain *d)
 int mem_sharing_fork_page(struct domain *d, gfn_t gfn,
                           bool unsharing);
 
+int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                           bool reset_memory);
+
 /*
  * If called by a foreign domain, possible errors are
  *   -EBUSY -> ring full
@@ -148,6 +151,12 @@ static inline int mem_sharing_fork_page(struct domain *d, gfn_t gfn, bool lock)
     return -EOPNOTSUPP;
 }
 
+static inline int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                                         bool reset_memory)
+{
+    return -EOPNOTSUPP;
+}
+
 #endif
 
 #endif /* __MEM_SHARING_H__ */
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index 15e6a7ed81..2f447d94ab 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1879,15 +1879,21 @@ static int fork(struct domain *cd, struct domain *d)
  * footprints the hypercall continuation should be implemented (or if this
  * feature needs to be become "stable").
  */
-static int mem_sharing_fork_reset(struct domain *d)
+int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                           bool reset_memory)
 {
-    int rc;
+    int rc = 0;
     struct domain *pd = d->parent;
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     struct page_info *page, *tmp;
 
+    ASSERT(reset_state || reset_memory);
+
     domain_pause(d);
 
+    if ( !reset_memory )
+        goto state;
+
     /* need recursive lock because we will free pages */
     spin_lock_recursive(&d->page_alloc_lock);
     page_list_for_each_safe(page, tmp, &d->page_list)
@@ -1920,7 +1926,9 @@ static int mem_sharing_fork_reset(struct domain *d)
     }
     spin_unlock_recursive(&d->page_alloc_lock);
 
-    rc = copy_settings(d, pd);
+ state:
+    if ( reset_state )
+        rc = copy_settings(d, pd);
 
     domain_unpause(d);
 
@@ -2227,15 +2235,21 @@ int mem_sharing_memop(XEN_GUEST_HANDLE_PARAM(xen_mem_sharing_op_t) arg)
 
     case XENMEM_sharing_op_fork_reset:
     {
+        bool reset_state = mso.u.fork.flags & XENMEM_FORK_RESET_STATE;
+        bool reset_memory = mso.u.fork.flags & XENMEM_FORK_RESET_MEMORY;
+
         rc = -EINVAL;
-        if ( mso.u.fork.pad || mso.u.fork.flags )
+        if ( mso.u.fork.pad || (!reset_state && !reset_memory) )
+            goto out;
+        if ( mso.u.fork.flags &
+             ~(XENMEM_FORK_RESET_STATE | XENMEM_FORK_RESET_MEMORY) )
             goto out;
 
         rc = -ENOSYS;
         if ( !d->parent )
             goto out;
 
-        rc = mem_sharing_fork_reset(d);
+        rc = mem_sharing_fork_reset(d, reset_state, reset_memory);
         break;
     }
 
diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
index 84cf52636b..d26a6699fc 100644
--- a/xen/common/vm_event.c
+++ b/xen/common/vm_event.c
@@ -28,6 +28,11 @@
 #include <asm/p2m.h>
 #include <asm/monitor.h>
 #include <asm/vm_event.h>
+
+#ifdef CONFIG_MEM_SHARING
+#include <asm/mem_sharing.h>
+#endif
+
 #include <xsm/xsm.h>
 #include <public/hvm/params.h>
 
@@ -394,6 +399,16 @@ static int vm_event_resume(struct domain *d, struct vm_event_domain *ved)
             if ( rsp.reason == VM_EVENT_REASON_MEM_PAGING )
                 p2m_mem_paging_resume(d, &rsp);
 #endif
+#ifdef CONFIG_MEM_SHARING
+            if ( mem_sharing_is_fork(d) )
+            {
+                bool reset_state = rsp.flags & VM_EVENT_FLAG_RESET_FORK_STATE;
+                bool reset_mem = rsp.flags & VM_EVENT_FLAG_RESET_FORK_MEMORY;
+
+                if ( reset_state || reset_mem )
+                    ASSERT(!mem_sharing_fork_reset(d, reset_state, reset_mem));
+            }
+#endif
 
             /*
              * Check emulation flags in the arch-specific handler only, as it
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index a1a0f0233a..f8d26fb77d 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -541,12 +541,14 @@ struct xen_mem_sharing_op {
                 uint32_t gref;     /* IN: gref to debug         */
             } u;
         } debug;
-        struct mem_sharing_op_fork {      /* OP_FORK */
+        struct mem_sharing_op_fork {      /* OP_FORK{,_RESET} */
             domid_t parent_domain;        /* IN: parent's domain id */
 /* Only makes sense for short-lived forks */
 #define XENMEM_FORK_WITH_IOMMU_ALLOWED (1u << 0)
 /* Only makes sense for short-lived forks */
 #define XENMEM_FORK_BLOCK_INTERRUPTS   (1u << 1)
+#define XENMEM_FORK_RESET_STATE        (1u << 2)
+#define XENMEM_FORK_RESET_MEMORY       (1u << 3)
             uint16_t flags;               /* IN: optional settings */
             uint32_t pad;                 /* Must be set to 0 */
         } fork;
diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
index bb003d21d0..81c2ee28cc 100644
--- a/xen/include/public/vm_event.h
+++ b/xen/include/public/vm_event.h
@@ -127,6 +127,14 @@
  * Reset the vmtrace buffer (if vmtrace is enabled)
  */
 #define VM_EVENT_FLAG_RESET_VMTRACE      (1 << 13)
+/*
+ * Reset the VM state (if VM is fork)
+ */
+#define VM_EVENT_FLAG_RESET_FORK_STATE   (1 << 14)
+/*
+ * Remove unshared entried from physmap (if VM is fork)
+ */
+#define VM_EVENT_FLAG_RESET_FORK_MEMORY  (1 << 15)
 
 /*
  * Reasons for the vm event request
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 14:59:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 14:59:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299952.511322 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc78Q-0002Yn-FU; Wed, 06 Apr 2022 14:59:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299952.511322; Wed, 06 Apr 2022 14:59:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc78Q-0002XX-A6; Wed, 06 Apr 2022 14:59:50 +0000
Received: by outflank-mailman (input) for mailman id 299952;
 Wed, 06 Apr 2022 14:59:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xjgL=UQ=intel.com=tamas.lengyel@srs-se1.protection.inumbo.net>)
 id 1nc78P-0002Uy-91
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 14:59:49 +0000
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 32a99ba2-b5ba-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 16:59:47 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Apr 2022 07:59:45 -0700
Received: from gtomasze-mobl1.amr.corp.intel.com (HELO localhost.localdomain)
 ([10.212.34.72])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Apr 2022 07:59:42 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32a99ba2-b5ba-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649257187; x=1680793187;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=sUx9xV830q6Z4ti78sYu6YT0dVUUjjtA9g5HB4fxwL8=;
  b=j0CaeKgmxAEdE7M7m3GuUAKh/hlVFc6U8S071UEY9nVDNlAFLY6DnZE0
   WnaikfWITBJ+pFiT2E//ARdYvYWEhO48HLS+zW3PN7Nshk3SyEiPqQRm6
   GZ2h2+pdNE4Yv9Xuk6JUb+XJwdsvn8XLidWqeYxQgV5mhyfftbL23iOD6
   VNpKDJ9C6jccqRLzEAQGt7VSzxhxhY4juhZ7eWMM26+cToQzxCgunIxK/
   EDQNWjfJTatHNO37KXq15L6DVOG2YSV0lq3QuU4GXRLPvx3qZrTB5EYeq
   ocYfY8B7M9zBLljuCegvXMEma30ZqaFXwNsqB/xifv1CPTb5JEGpbmMqn
   g==;
X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="258661139"
X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; 
   d="scan'208";a="258661139"
X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; 
   d="scan'208";a="658563103"
From: Tamas K Lengyel <tamas.lengyel@intel.com>
To: xen-devel@lists.xenproject.org
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: [PATCH v3 2/2] x86/monitor: Add new monitor event to catch all vmexits
Date: Wed,  6 Apr 2022 10:58:22 -0400
Message-Id: <73e6b45525e1be753d3e243d42ad632bbc5690b0.1649256753.git.tamas.lengyel@intel.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <d1a7a48fa2d46c6a6cbf8f93926a8839aaba92e3.1649256753.git.tamas.lengyel@intel.com>
References: <d1a7a48fa2d46c6a6cbf8f93926a8839aaba92e3.1649256753.git.tamas.lengyel@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add monitor event that hooks the vmexit handler allowing for both sync and
async monitoring of events. With async monitoring an event is placed on the
monitor ring for each exit and the rest of the vmexit handler resumes normally.
If there are additional monitor events configured those will also place their
respective events on the monitor ring. With the sync version an event is placed
on the monitor ring but the handler does not get resumed, thus the sync version
is only useful when the VM is not expected to resume normally after the vmexit.
Our use-case is primarily with the sync version with VM forks where the fork
gets reset after sync vmexit event, thus the rest of the vmexit handler can be
safely skipped.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
---
New in v3.
Note: making the sync version resume-friendly is specifically out-of-scope as
it would require significant rearrangement of the vmexit handler. As this
feature is not required for our use-case we opt for the version that minimizes
impact on the existing code.
---
 tools/include/xenctrl.h                |  2 ++
 tools/libs/ctrl/xc_monitor.c           | 15 +++++++++++++++
 xen/arch/x86/hvm/monitor.c             | 18 ++++++++++++++++++
 xen/arch/x86/hvm/vmx/vmx.c             | 12 ++++++++++++
 xen/arch/x86/include/asm/domain.h      |  2 ++
 xen/arch/x86/include/asm/hvm/monitor.h |  2 ++
 xen/arch/x86/include/asm/monitor.h     |  3 ++-
 xen/arch/x86/monitor.c                 | 14 ++++++++++++++
 xen/include/public/domctl.h            |  6 ++++++
 xen/include/public/vm_event.h          |  8 ++++++++
 10 files changed, 81 insertions(+), 1 deletion(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 1b089a2c02..159eaac050 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -2096,6 +2096,8 @@ int xc_monitor_privileged_call(xc_interface *xch, uint32_t domain_id,
                                bool enable);
 int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
                                   bool enable);
+int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
+                      bool sync);
 /**
  * This function enables / disables emulation for each REP for a
  * REP-compatible instruction.
diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.c
index 4ac823e775..c5fa62ff30 100644
--- a/tools/libs/ctrl/xc_monitor.c
+++ b/tools/libs/ctrl/xc_monitor.c
@@ -246,6 +246,21 @@ int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
     return do_domctl(xch, &domctl);
 }
 
+int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
+                      bool sync)
+{
+    DECLARE_DOMCTL;
+
+    domctl.cmd = XEN_DOMCTL_monitor_op;
+    domctl.domain = domain_id;
+    domctl.u.monitor_op.op = enable ? XEN_DOMCTL_MONITOR_OP_ENABLE
+                                    : XEN_DOMCTL_MONITOR_OP_DISABLE;
+    domctl.u.monitor_op.event = XEN_DOMCTL_MONITOR_EVENT_VMEXIT;
+    domctl.u.monitor_op.u.vmexit.sync = sync;
+
+    return do_domctl(xch, &domctl);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
index b44a1e1dfe..d68fbffafe 100644
--- a/xen/arch/x86/hvm/monitor.c
+++ b/xen/arch/x86/hvm/monitor.c
@@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
     return monitor_traps(curr, true, &req) >= 0;
 }
 
+int hvm_monitor_vmexit(unsigned long exit_reason,
+                       unsigned long exit_qualification)
+{
+    struct vcpu *curr = current;
+    struct arch_domain *ad = &curr->domain->arch;
+    vm_event_request_t req = {};
+
+    ASSERT(ad->monitor.vmexit_enabled);
+
+    req.reason = VM_EVENT_REASON_VMEXIT;
+    req.u.vmexit.reason = exit_reason;
+    req.u.vmexit.qualification = exit_qualification;
+
+    set_npt_base(curr, &req);
+
+    return monitor_traps(curr, !!ad->monitor.vmexit_sync, &req);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index c075370f64..86d8d6e20b 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
         }
     }
 
+    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
+    {
+        int rc;
+        __vmread(EXIT_QUALIFICATION, &exit_qualification);
+
+        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
+        if ( rc < 0 )
+            goto exit_and_crash;
+        else if ( rc )
+            return;
+    }
+
     /* XXX: This looks ugly, but we need a mechanism to ensure
      * any pending vmresume has really happened
      */
diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
index e62e109598..855db352c0 100644
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -430,6 +430,8 @@ struct arch_domain
          */
         unsigned int inguest_pagefault_disabled                            : 1;
         unsigned int control_register_values                               : 1;
+        unsigned int vmexit_enabled                                        : 1;
+        unsigned int vmexit_sync                                           : 1;
         struct monitor_msr_bitmap *msr_bitmap;
         uint64_t write_ctrlreg_mask[4];
     } monitor;
diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h
index a75cd8545c..639f6dfa37 100644
--- a/xen/arch/x86/include/asm/hvm/monitor.h
+++ b/xen/arch/x86/include/asm/hvm/monitor.h
@@ -51,6 +51,8 @@ bool hvm_monitor_emul_unimplemented(void);
 
 bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
                            uint16_t kind);
+int hvm_monitor_vmexit(unsigned long exit_reason,
+                       unsigned long exit_qualification);
 
 #endif /* __ASM_X86_HVM_MONITOR_H__ */
 
diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/asm/monitor.h
index 01c6d63bb9..d8d54c5f23 100644
--- a/xen/arch/x86/include/asm/monitor.h
+++ b/xen/arch/x86/include/asm/monitor.h
@@ -89,7 +89,8 @@ static inline uint32_t arch_monitor_get_capabilities(struct domain *d)
                     (1U << XEN_DOMCTL_MONITOR_EVENT_DEBUG_EXCEPTION) |
                     (1U << XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG) |
                     (1U << XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED) |
-                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT));
+                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT) |
+                    (1U << XEN_DOMCTL_MONITOR_EVENT_VMEXIT));
 
     if ( hvm_is_singlestep_supported() )
         capabilities |= (1U << XEN_DOMCTL_MONITOR_EVENT_SINGLESTEP);
diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
index 3079726a8b..30ca71432c 100644
--- a/xen/arch/x86/monitor.c
+++ b/xen/arch/x86/monitor.c
@@ -332,6 +332,20 @@ int arch_monitor_domctl_event(struct domain *d,
         break;
     }
 
+    case XEN_DOMCTL_MONITOR_EVENT_VMEXIT:
+    {
+        bool old_status = ad->monitor.vmexit_enabled;
+
+        if ( unlikely(old_status == requested_status) )
+            return -EEXIST;
+
+        domain_pause(d);
+        ad->monitor.vmexit_enabled = requested_status;
+        ad->monitor.vmexit_sync = mop->u.vmexit.sync;
+        domain_unpause(d);
+        break;
+    }
+
     default:
         /*
          * Should not be reached unless arch_monitor_get_capabilities() is
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0..4803ed7afc 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -1057,6 +1057,7 @@ struct xen_domctl_psr_cmt_op {
 #define XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED    10
 /* Enabled by default */
 #define XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT     11
+#define XEN_DOMCTL_MONITOR_EVENT_VMEXIT                12
 
 struct xen_domctl_monitor_op {
     uint32_t op; /* XEN_DOMCTL_MONITOR_OP_* */
@@ -1107,6 +1108,11 @@ struct xen_domctl_monitor_op {
             /* Pause vCPU until response */
             uint8_t sync;
         } debug_exception;
+
+        struct {
+            /* Send event and don't process vmexit */
+            uint8_t sync;
+        } vmexit;
     } u;
 };
 
diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
index 81c2ee28cc..07f106f811 100644
--- a/xen/include/public/vm_event.h
+++ b/xen/include/public/vm_event.h
@@ -175,6 +175,8 @@
 #define VM_EVENT_REASON_DESCRIPTOR_ACCESS       13
 /* Current instruction is not implemented by the emulator */
 #define VM_EVENT_REASON_EMUL_UNIMPLEMENTED      14
+/* VMEXIT */
+#define VM_EVENT_REASON_VMEXIT                  15
 
 /* Supported values for the vm_event_write_ctrlreg index. */
 #define VM_EVENT_X86_CR0    0
@@ -394,6 +396,11 @@ struct vm_event_emul_insn_data {
     uint8_t data[16]; /* Has to be completely filled */
 };
 
+struct vm_event_vmexit {
+    uint64_t reason;
+    uint64_t qualification;
+};
+
 typedef struct vm_event_st {
     uint32_t version;   /* VM_EVENT_INTERFACE_VERSION */
     uint32_t flags;     /* VM_EVENT_FLAG_* */
@@ -414,6 +421,7 @@ typedef struct vm_event_st {
         struct vm_event_debug                 software_breakpoint;
         struct vm_event_debug                 debug_exception;
         struct vm_event_cpuid                 cpuid;
+        struct vm_event_vmexit                vmexit;
         union {
             struct vm_event_interrupt_x86     x86;
         } interrupt;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:01:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:01:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299960.511339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7AG-0004bp-VC; Wed, 06 Apr 2022 15:01:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299960.511339; Wed, 06 Apr 2022 15:01:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7AG-0004bi-Rm; Wed, 06 Apr 2022 15:01:44 +0000
Received: by outflank-mailman (input) for mailman id 299960;
 Wed, 06 Apr 2022 15:01:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc7AF-0004bc-VJ
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:01:44 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7684c38a-b5ba-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 17:01:41 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7684c38a-b5ba-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649257301;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=vIA1ejVbSNjFC85HbrXcdNiNQJzi4iuVdaDmkLfJNhY=;
  b=cdpp5uK0UGXeOk+GXPOBxYoUfeLzypF5X5H18bkgRe0L/iteD/Xp3x4i
   MSHsKGM3VsBXpj4o/3T4UyrQD7NGgdHttoiHqV5LmG81HX0LgAel69GDU
   iw/4qfCZZBOfSypfVskssN61eNrj6UbvSef6I1ZexIl+3747iorCj+/N3
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68063133
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YFjS46K+ELmvFZLcFE+RCpUlxSXFcZb7ZxGr2PjKsXjdYENS12YCz
 mQXWzjVOf2OMDOhKYh3bY3k/UwBvZaBn9Y1TlFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 OlIp8ygSlcqAqKPudYzXjtdCngvPIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glg3p4VRK2FD
 yYfQT9RdAvBJCwSA3EGKcM9wuixpSP7bBQN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv
 G2u13/iHhgQOdibyDyE2nGhnOnCmWX8Qo16PKK83u5nhhuU3GN7IAUfSF+TsfS/zEmkVLp3K
 UYZ5y4vpqga71GwQ5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceRjE01
 1nPg9LgAxRutqGYTTSW8bL8kN+pEXFLdylYP3ZCFFZbpYm4yG0usv7RZupmAv6ljY32JT6z4
 gKkoQo7nuxCjOdegs1X4mv7qz6ro5HISCs86QPWQn+p42tFWWK1W2C7wQOFtKgdde51WnHE5
 SFZwJbGsIjiGLnXzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg
 meO4Wu9B7cJZRNGiJObharrVazGKoC6SLzYugj8NIYmX3SIXFbvENtSTUCRxXvxt0MnjLsyP
 5yWGe71UypLUPQ7nGrmF7hGuVPO+szY7TmNLXwc5075uYdymVbPEetVWLdwRr5RAFy4TPX9r
 I8EapriJ+R3W+zieCjHmbP/3nhRRUXX8ave8pQNHsbae1IOMDh4V5f5nONwE6Q4zv89vrqZo
 RmAtrpwlQOXaYvvcl7RNBiOqdrHAP5CkJ7MFXd1Zwz1hCF/P93HAWV2X8JfQITLPddLlJZcZ
 /IEZ9+BErJITDHG8C4adp7zsMppcxHDuO5EF3TNjOQXF3K4ezH0xw==
IronPort-HdrOrdr: A9a23:EmJt9q065uLt8mmyehFFkgqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="68063133"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KzJmeY2jNzvE3yf4q1bg1WU4suGkOCt9U3IkRhLIV/r+7Xnvt0bKYRZq/BDgMgAdwATPXFitwVYaMs3GgGS9aAsUAELphquM4GC6nDmO6OLbfSWWsBw4LBUIXqVSA280bZpdYOQj3PjB9EvCbRgDCAYmWhyR6RWuNS/Okd/8mCeoqYxu5EzYVkcmhNAJwrIzoH/z6QfZtmzOeuA3QJRFa8JJ0EpZmyqFn2BLZ0zbb8xy1AMxpzuen7xkGWvjs8jFJ2p2UAgWMBQU+ftm7RPOlrh1BMq48EVqgKauNBKh4z+Ky4S/30GirJPqilDQIBDG9H5HofHW7He09voXDyP7eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DFay5JcOunxrFtlt5m5C+q0vtIX11QnfKQ750bGrSOs=;
 b=Lto9FTBJT8CnSoq1e/ERUWMxYg2l/ZaECNCeaFdncop1mjGcI75+T+o4ocJsdENQ/zTVDAAcCKhh6K9+YSmG24aedSEUsU1gYXGqeiDBvtBjajSW8cDieVvaYZm9jDDf4YkHrVHJ0tXXEv/zV7ALkoUd9tAMC80bnM5ts1Q83VN3A+lXHQL5fBXzGkCKHdcBDZFSItbyAbJzvcsKDGekwFVk3TYUAW+eyqq97LtAw/bu+mIdCaW78VYxlqQgya2kubsixHpictNVAhrAo2xzs67MkMXGC/B2y/Gv95NXtmJCs/oOvPRNyLywYzfjuWWYHzK5BTAB/3NgyRgOcKODQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DFay5JcOunxrFtlt5m5C+q0vtIX11QnfKQ750bGrSOs=;
 b=cCOBG92d8cAGL7QWnUAvowGYwE5EV9bhxuqxQbpSPBYlcaKp5DHb2Y55qTWgNwQWkLm6Q2Kwqcx/p8kGrSqbKHpdROcNacJ77QJgBPsMjZ3nEwkAie4MlitL1ieI2NFpVhDWur7fpMSY9yfQv9l8aEhDn1Gx9lCWqFVLggUBo6o=
Date: Wed, 6 Apr 2022 17:01:31 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Kevin
 Tian" <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	"Julien Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Message-ID: <Yk2rS+9o2fNkUV8+@Air-de-Roger>
References: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
 <d232b6bd-17d2-c78f-49e1-67ffc2502810@suse.com>
 <Yk2XcUhUn0BYk3lA@Air-de-Roger>
 <ffad005c-d6b9-9f27-9b5b-4f6d7345c81a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ffad005c-d6b9-9f27-9b5b-4f6d7345c81a@suse.com>
X-ClientProxiedBy: LO2P265CA0292.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a5::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 925180a5-c45b-4caf-f06f-08da17de578d
X-MS-TrafficTypeDiagnostic: CY1PR03MB2234:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <CY1PR03MB223477F537D10383A0B479CD8FE79@CY1PR03MB2234.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wATOaHs/5rdIzkB/s9qZ3XZ1NcfusygQ+e0+DELdBovhHOrIf7hUPY8ULhzV2Vt5ht5AFY0XAbIOcEhCZSmETXC2YKqOrGlwKjyx2LmuqYK6GAM1P7Po4iOXqaeRB9+1KopTYidiJ5FSh+toRVTUUAbk5gPPBzRSAdYgoY7w4dWX1yI3um/0U8RP4kP0ikM0vy7WxGM5iBf5sOR0b/479aIiHfW7nnmccbYdPIN4MRB7I5juPTTSrea96ckzcOuE78ZCofJwds6nXfZUxqTe7iGxtpmRv+MJ60cghZl6qikOAZ/cHM/jSxKbsCy0stwi4QoGgEikwSbVqKc1F9VeLMteziFKYOWMlV79KJyM6Ug8ZfDsfsuc3pCvgIIMVXEgWYPaY6ehHJ5/zosDnEbhAiwve3rOQYQF4IhX7Qzc+O5hf2z35bOvk3DwWuRgVJ5V3Vu+ha8CHnpbjdtQFHRauW9gW81ZuCtJLcsOAbIRq8BtAo3fyfOguk2wDrocsiFYt/61Ud61fQCvejt6VTIj6zaXnPa41SodmXfIyluEqcuWr1sKK4YEmZtuRpqCuWjetXtZYTBFD53vM+RMBvEQFgiM6R9A3Oy3/mFL/P62pTAjIlGh0G1ai2K4fjTJF+WNxJ9zBJriC4hLCLSUQvUiow==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(6666004)(186003)(26005)(6512007)(86362001)(498600001)(53546011)(2906002)(6486002)(8936002)(38100700002)(9686003)(85182001)(83380400001)(66556008)(66946007)(4326008)(5660300002)(66476007)(54906003)(8676002)(6916009)(33716001)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTRXRG16N05tNzc1NXl6REhJa05TVkhYY1NTbmpLT1BPZk5WdTlRd2ZTdVpn?=
 =?utf-8?B?Ymp5cVJKWENVa0N1VnlCUmJyd2xsN2VKNWo1UGJuamlKK2RPSk5qV3J2L2JM?=
 =?utf-8?B?M2JoSzlpWFVxL3VLMTNGcDNoZDM4YkczUkJvc0hSZnZNTHd4YkRTR2w5dVhn?=
 =?utf-8?B?eGRJRTYwUm1NQ2ltQ2xtcUxsZWJPRWhTYmFGZU95WEY4WVVodyt2bWxSVDdP?=
 =?utf-8?B?RWdqUTVIaFZVSTkrcnVuT1RGQ2dONGlPcXZBTnJ4YXZvK2QyUng2U0VyZXY1?=
 =?utf-8?B?WGdHeFlzZWo4bFFSRGRua3NSUjBxdGdMLzBlc1d2YllMcU0rTWNXZmpKcHoy?=
 =?utf-8?B?K0I2VGN5bXI3SFcvT3ZFNHJySkc0L0Jrak9KMUV2eHE5djh3dUtJOHhzRDR2?=
 =?utf-8?B?VDdsSW1IaVlhVTM3VnFKbDgxVm9nZTdqbFRLZk0yMzBmOWM3K2hNdERrU1Rk?=
 =?utf-8?B?YjUxemdCdDBzMEtSQnhXbWlLVkYxRkxTaWxQWlZ3U0trMTBpanI0R092aGt3?=
 =?utf-8?B?RGd4SEh5YVZvZ0x3VmFhZUZtMzN3QUlDSlZiWXlqWlZvUWcyREFDVUp1cmdT?=
 =?utf-8?B?L3k4N0JSYkpHbmw5eEVPVDN2QS83MVdBakI2RzJuSGFBeTgveUpFWXZJVmp1?=
 =?utf-8?B?djhrMitkM0Z6bDV2dDJVWEdUSTBxNUhEd3FZcGZjOFhZMnNwa3BUQlFkbWQy?=
 =?utf-8?B?c2RHdVhEYUNjcHdPY2MvMTR6dW9QdWh4SzNmQnhMT1R3dElMQTI5NlcxY1Vt?=
 =?utf-8?B?RThMNi80ZUdzVHo2d1l6cU9DSFd2QzdwWDZYUWhhTE5la2RwSUcvZkJNa0lJ?=
 =?utf-8?B?T2c0aFFCMUFMSGdFWWd4NzZXMVpBQzBRbUdUTkRZd05uZUx2SXlSWDJSS0ZO?=
 =?utf-8?B?MTF2MDVBTmtnQlRjRTc2d2JvNXJDVnBuTUl2eG9LcTF4b0JDUkFNSWpBUzRa?=
 =?utf-8?B?bzRzbTRPbFRJTEdnWXRnODBlWEZtSDdkbHdKSHJsQ0E4OVJuS2ZuSG1GMzBq?=
 =?utf-8?B?cHdXVWZzekRHQjRRc2dDeDdOQUd1dEE4QnFBNzRBR2h0b0o4S0IyYW8xSlNr?=
 =?utf-8?B?dUJVTnZTc3pzZFF4UUFwTnlzOHFickNvNWhxWStkdGhFUUgxM3ZnQ3E3YUly?=
 =?utf-8?B?dlZJUG16VllKU202RzFEcStrMndialBFVmhEdlQ4VDZSaXRjdE9YcU9BU2FK?=
 =?utf-8?B?SVJteFhSREFrQ3FPdlpWVDVYc2hKa3ZCelFPMWFneUhBQytzWDZ0NlNETlRu?=
 =?utf-8?B?TXlreUIzcjVEK21YMjltNEZTU3V6QWkxY0xTR3hVTG05MlYwVXUyWDIrNU1j?=
 =?utf-8?B?cDFLQmRhaGZpMlB2Qno3eFlzWmZlSXAyMm9nRzBnNGdtSXBvZ1V5alZIQnRT?=
 =?utf-8?B?SFYyVGdtbWd2OWpSdVdjVnhkSk1vUWJQc1hISXFBYWY5dy9FRUlFLzZtTmZ3?=
 =?utf-8?B?L2I5eTB2RmRSRE5pY0VJYUxvYzZZcXd2bG5PVVRJbDFLVi9HdlJ0cUJYczhk?=
 =?utf-8?B?ek9OSkhPeUp6c2NUajJ1eEMrYjBLeFhaTCtWdWhsNWRWY2syT3NyT2dGc3ZL?=
 =?utf-8?B?OE5qUlc4c0FQOUFXd3MxT2FLQUFWVlI1T0tPSlVlSmhpYyswb1JwUTFNaVNC?=
 =?utf-8?B?NzVaTXJqRkR6NTgzNnZUYUMxSm1oSjl5akVXQk03ODlsWlNiaHZ2emFQOGVa?=
 =?utf-8?B?UE1BU1ZIaFNWL0t3ZVU0QlpncFlUak02TmVvMDd1V3h0WjUzYzJqSnhvclFI?=
 =?utf-8?B?YXRVQmdWT1B1SGlXRFh2Qy9RMTNEMUlnSmxaUWoyMU9BWFA1STJhTFc5KzdB?=
 =?utf-8?B?UW5IQit1VEFUb0VUbzM1UnJTSkxvUHBZSUw4aldDdHB3WGZtQ0F4R3p0RjJp?=
 =?utf-8?B?SzZEM1lNSEJwNGZoLzNmdkE2R1UyNzN6M1hSZ29rY3VIQmZ3emFVOVEwUGgv?=
 =?utf-8?B?OXN4eTBPZnBkTy9IS0puMWR4UisvLzRJSGR0Q3NRNEZJTDdpQk1HZ1U5OGRk?=
 =?utf-8?B?NXJFaDhQQUJqRThhOTVIZ2RVM25YbFlJOWpLekdmbGlVT2tvZGxzKzZCTjls?=
 =?utf-8?B?VjExVXVoVzFtNlJtbTlnakpENmtyTllySUVmYko1N3F2SHhzSDd2Q2V0UE9z?=
 =?utf-8?B?cHBPbnAwZ0c0UnVsWUJUZmpJTlI2R25kKzdJZ3ZjMytCeDM4OGF5YlIvNG9K?=
 =?utf-8?B?eHlyQ3RzTkZMOVgyT1k1YmhucFQxNnlvWG4zd3I0Y3FXa1M2c1AxMEZuL1Rv?=
 =?utf-8?B?VVZlSm1TRzhneW94KzFJRE5FTzJPUWlqcTh3Rks3RVl6SW1SeTNXREs4MmI3?=
 =?utf-8?B?RkFaaG5oY0VnSnJoM1NzZThoQ1Jub3hHVDdIcWZWVThNQ0tGWlc1b0tROEhG?=
 =?utf-8?Q?AiGB2SsPHWB931pY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 925180a5-c45b-4caf-f06f-08da17de578d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:01:34.7475
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tuiw/TEQrbopRwRLqtA4GHjiA4axims9wXtOzTIUgYaVw7Ff5l8hJ3HP7BVbxvte2QCMleUVABL0aVWJgqrVHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2234
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 04:07:24PM +0200, Jan Beulich wrote:
> On 06.04.2022 15:36, Roger Pau Monné wrote:
> > On Wed, Apr 06, 2022 at 02:24:32PM +0200, Jan Beulich wrote:
> >> First there's a printk() which actually wrongly uses pdev in the first
> >> place: We want to log the coordinates of the (perhaps fake) device
> >> acted upon, which may not be pdev.
> >>
> >> Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
> >> device quarantine page tables (part I)") to add a domid_t parameter to
> >> domain_context_unmap_one(): It's only used to pass back here via
> >> me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again.
> >>
> >> Finally there's the invocation of domain_context_mapping_one(), which
> >> needs to be passed the correct domain ID. Avoid taking that path when
> >> pdev is NULL and the quarantine state is what would need restoring to.
> >> This means we can't security-support PCI devices with RMRRs (if such
> >> exist in practice) any longer.
> >>
> >> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
> >> Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quarantining")
> >> Coverity ID: 1503784
> >> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >>
> >> --- a/SUPPORT.md
> >> +++ b/SUPPORT.md
> >> @@ -750,6 +750,10 @@ However, this feature can still confer s
> >>  when used to remove drivers and backends from domain 0
> >>  (i.e., Driver Domains).
> >>  
> >> +On VT-d (Intel hardware) passing through plain PCI (or PCI-X) devices
> >> +when they have associated Reserved Memory Regions (RMRRs)
> >> +is not security supported, if such a combination exists in the first place.
> > 
> > Hm, I think this could be confusing from a user PoV.  It's my
> > understanding you want to differentiate between DEV_TYPE_PCIe_ENDPOINT
> > and DEV_TYPE_PCI device types, so maybe we could use:
> > 
> > "On VT-d (Intel hardware) passing through non PCI Express devices with
> > associated Reserved Memory Regions (RMRRs) is not supported."
> > 
> > AFAICT domain_context_mapping will already prevent this from happening
> > by returning -EOPNOTSUPP (see the DEV_TYPE_PCI case handling).
> 
> Hmm. I did look at that code while writing the patch, but I didn't
> draw the same conclusion. I'd like to tie the security support
> statement to what could technically be made work. IOW I don't like
> to say "not supported"; I'd like to stick to "not security
> supported", which won't change even if that -EOPNOTSUPP path would
> be replaced by a proper implementation.

My preference for using 'not supported' was simply so that users don't
need to worry whether their use-case fails in this category: Xen will
simply reject the operation in the first place.

Otherwise users might wonder whether some of the devices they are
passing through are security supported or not (lacking proper
information about how to check whether a device is PCI, PCI-X or PCIe
and whether it has associated RMRR regions).

I understand your worry here, but I do think we should aim to make
this document as easy to parse as possible for users, and hence I
wonder whether your proposed addition will cause unneeded confusion
because that use-case is not allowed by the hypervisor in the first
place.

> Even adding a sentence to
> say this doesn't even work at present would seem to me to go too
> far: Such a sentence would easily be forgotten if the situation
> changed. But I'd be willing to add such an auxiliary statement as
> a compromise.
> 
> As to "plain PCI (or PCI-X)" vs "non PCI Express" - while I prefer
> to avoid a negation there, I'd be okay to switch if that's deemed
> better for potential readers.

Maybe it would be best to simply expand the comment before the RMRR
check in domain_context_mapping() to note that removing the check will
have security implications?

> >> @@ -1601,9 +1601,13 @@ int domain_context_mapping_one(
> >>  
> >>      if ( rc )
> >>      {
> >> -        if ( !prev_dom )
> >> -            ret = domain_context_unmap_one(domain, iommu, bus, devfn,
> >> -                                           DEVICE_DOMID(domain, pdev));
> >> +        if ( !prev_dom ||
> >> +             /*
> >> +              * Unmapping here means PCI devices with RMRRs (if such exist)
> >> +              * will cause problems if such a region was actually accessed.
> >> +              */
> >> +             (prev_dom == dom_io && !pdev) )
> > 
> > Maybe I'm reading this wrong, but plain PCI devices with RMRRs are
> > only allowed to be assigned to the hardware domain, and won't be able
> > to be reassigned afterwards.  It would be fine to unmap
> > unconditionally if !prev_dom or !pdev?  As calls with !pdev only
> > happening for phantom functions or bridge devices.
> 
> Like with the support statement, I'd prefer this code to be independent
> of the (perhaps temporary) decision to not allow certain assignments.

I was just saying because it would make the code easier IMO, but maybe
it doesn't matter that much.

The comment however should also be adjusted to mention that refers to
legacy DEV_TYPE_PCI type devices ('PCI devices with RMRRs' is too
unspecific IMO).

> Since you mention phantom functions: Aiui their mapping operations will
> be done with a non-NULL pdev, unless of course they're phantom functions
> associated with a non-PCIe device (in which case the same secondary
> mappings with a NULL pdev would occur - imo pointlessly, as it would
> be the same bridge and the same secondary bus as for the actual device;
> I'm under the impression that error handling may not work properly when
> such redundant mappings occur).

The redundant mapping of the bridges would be fine as prev_dom ==
domain in that case, and cannot fail?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:10:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:10:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299965.511350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7IF-0005NC-QI; Wed, 06 Apr 2022 15:09:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299965.511350; Wed, 06 Apr 2022 15:09:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7IF-0005N5-Mw; Wed, 06 Apr 2022 15:09:59 +0000
Received: by outflank-mailman (input) for mailman id 299965;
 Wed, 06 Apr 2022 15:09:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc7IE-0005Mz-Ir
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:09:58 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d3ff1cb-b5bb-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 17:09:56 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d3ff1cb-b5bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649257796;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=maPMO86fu40OMTwxf6amBWSGcZgqIK3ohXBFIXW/Fg4=;
  b=Zg0oWaoNJkYlx838Qrj2Ikbiy6AxPCPkMpmoqfGYZDEAx7FklXDUgPX5
   hYv/IzHSeexkHxqrep8W8NRUnuTGJn4y+RUIlxg8fi7m/OJyVNkGKB1Ae
   E7Rg21KKDSqwVynAPEBv6sAPDEdevE2UUZ2Oo7e3vDaXr5e8+m/C8EXAU
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70567931
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:F5PVJ66Q0ZLfgidzNeWwdAxRtC/HchMFZxGqfqrLsTDasY5as4F+v
 mAaDWHSaKyOMzCmfYxxYYW+pEkO7MfRxoJjHQBtrnwzHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThXVvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSrbRgAHZbxtN0BcBxSUC1gZr9g4bL+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gRRauAO
 JtCMFKDajz9ZAx+EVoONqtmgduKu1jzTCZ8tFus8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTR4Y6BLC+sPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc8F0DMQZ0zyh87b35gzaCnZfXBhYZeVz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb4
 hDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vfRc1YpZUKWCyC
 KM2he+3zMUNVJdNRfUpC79d9uxwlfSwfTgbfq68giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLanOHOKrtdPcwtiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSSvxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:kshUoa3ZmAs9uIjxsUdcjQqjBVByeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79
 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhRQpENRGtldBm9Ce3im+yZNNW977PQCZf
 6hDp0tnUveRZ1bVLXyOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mOryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idgrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1vDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amGazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCR2B9vSyLaU5nlhBgu/DT1NU5DXStuA3Jy9/B96gIm0kyQlCAjtY4idnRpzuNId3AL3Z
 WADk1SrsA8ciYnV9MMOA4/e7rENoXse2O7DIvAGyWvKEk4U0i93qIfpo9FoN2XRA==
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="70567931"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WXt4/7KFG23b5Rw1OCR7IpS0QP8nP1rjy+AkwfOXWbYAYJv181FTIWAhW8Me7vYz+vx7RVLNkCHapeAfknE8oL7OZnPJwOCMIlJr6lcBcfvipMakqtqI1/jcRMTtil0R/X3z/0kzQgq24vDfgOghcQvsp1ghC+sfNWDtwPGOu8YDri+gb9tf6aWD5kRGQL25I9YOLbwrl0e6dZG3nBTBGRnn7T4+o+gNNrXgVU6QXxmpQEfhKtNpfiFikV4z9A24fR+fJ0Kna3DNAgOQGWDcyH6Kk9clUcm64Lc2gPfd7M3pJLoehVSE9tNQY7Purwcmrzc91kFkmIeQrVV6ielmqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Nen8ntpYGf5NXRLPEtkxedr6pdADJ/uwRwuXXj5ksgA=;
 b=eniiGP2A+j0ygmuoOYtNWzHbTaTdQZJTjkphx8awaNf69PkH4Og1iyojKyd5iT2mKoWQoYnuCLPojE2BkNeMCOahieWB8hj74vGOhD3z0BtGiMS0b25NQrp2ncbiYWZTh/NwPjs0ztsaAaRfhy3CQxT5US0Q6WDQFM6sx4kngiKVbDv+1ZgfCCwNfx01Zra/8STYiZAF4jQGroRDYJUWTLWoL2ukUXM+0cfBcnTzi2E5MsvAzGU8TAiV75b+/NAiVhYtlOv/FMuOWnOWye1Ep3pUjj7K0L8AhmbElppvbTPoc++zdV+kDc8otXKOowIqjWvk2aUM8jMl8OzEddL+zg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Nen8ntpYGf5NXRLPEtkxedr6pdADJ/uwRwuXXj5ksgA=;
 b=t6e/ANK5vq3btAQoWlCC/CTbyoTwguNpCFM3rpHZ1Zqwa9QumIr6zVE1hXW2BBBrgXSRl8Wx59HNpEpUlKu9el61yI6yCUos2ZexyqcYKTckXfWR+nz8B7m1lg7se5+E2lU2SpvAnIR1XOoewgciNPpSTbvlqLzmZB6N5sB3grs=
Date: Wed, 6 Apr 2022 17:09:43 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: Questions about Cx and Px state uploading from dom0
Message-ID: <Yk2tN5h3nB+ijMoN@Air-de-Roger>
References: <YjrgQOYbsaYOV08H@Air-de-Roger>
 <6a029529-fcbe-3923-26a6-58a58926762f@suse.com>
 <Yk1tvf7oqOf3jySX@Air-de-Roger>
 <333e5dad-5a8d-a8b5-99b5-5d349c784b88@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <333e5dad-5a8d-a8b5-99b5-5d349c784b88@suse.com>
X-ClientProxiedBy: LO4P123CA0046.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:152::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6544dfea-a345-4148-8f99-08da17df7dec
X-MS-TrafficTypeDiagnostic: MWHPR03MB2896:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB28968CFB9C3E89DFEB51287D8FE79@MWHPR03MB2896.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: P92NZ0q/BrANezdBguIYAzY/m2Bhuy3IlRkTZoSQPuOh+KSUzSA03Qv8kn0XWRfMUg5xBHSS97l71/xO+tTNh7nMmrjDzFVc2+QxPjJSoptyeFEhbDoocfF9dxgOdpiHfo8Fl5dO5ae8Hlkz8ttY39grSGcIgRYliuMSC6RjcLjlgNjEOwunZOtqvrlQqaGZ/zcEItS1rXR6ZxNemWr51Yu49AcauefXnhK3jdh004Y3EetH/mENmLRA4JqNrtJGSTZfHpCeaIIZzBBhqQJhBj6KX2OX2JsYXgxs8UUE18iXLgkAXgp1p8/oBteiBc5FBp3/2aDcB3wjQYX6UsBI5ajMNIwCrt/MJkZe0q+9S1eTUWSH73Z4Ru2y0H+bIyAK8Qdq3D6nLg2MyDvka3wQ9+x2MMPLK9N5JnOkzbs0+xaKSGuR05Q9XT3s8MVWr+f9nY/aGf0IsjeQfcexat0MvZZQ0sPtc0zBjZMztg3Orao1u4EH+clIfm/H6hyntT8okv3F3CG4TbAosHBTV1VFLr5aI1BHAnWUgsEnlAlCicH423ZXLNC1ZgZx1eNtUeheSiYZGhwsP6Y9Rq0dxF4MrCgHOvRuB4sRoSKL25AOfcFgaCTlSyF/AEgfah7G2IjUGyxXvL6HVVaODcu81wrEHh9OrWa1d2Evwhrpj/DNzlJOgo1uhp07ibRfnhJACQAY24M5+5yqYs1gMKUjpXJhmg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8676002)(83380400001)(4326008)(66556008)(6666004)(66946007)(66476007)(6506007)(53546011)(508600001)(6486002)(33716001)(86362001)(26005)(186003)(54906003)(6916009)(9686003)(316002)(6512007)(85182001)(5660300002)(2906002)(38100700002)(82960400001)(8936002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aE0xa2J4VmZqeTVUQWhNdHN2L2RUcXVCcTJZY25POHRrZFBEZ1pSTzFDN201?=
 =?utf-8?B?Rit4UVNkaTlMSnNRWnBSamJkbkNLOXJ6NTduaGpVTzh2K2taemJqVGVybkNz?=
 =?utf-8?B?VEhic3BqYWRENitmbGU5Mjgxd2xYMjRlckkzcndqNkFlRVRoeTRMTEFmYWhq?=
 =?utf-8?B?bmRzSVFyb1UxcDVCcTZoS3piQzRVT1ZYTE0vMkEvVDAzYzFqbzJ3V1pBUytE?=
 =?utf-8?B?bnZVZWUvMGlGTnc4bnFkNEdCQjlINGRHenBqZFhRQ3J0NThCVGNCcnpVMC9F?=
 =?utf-8?B?T0s0cFc0c2tDSXlidDVsc3lqaFVtMGJGM1lNbFM1NXAzb29jd2pRSXpRYk1H?=
 =?utf-8?B?amdjcUkxUXBNQ0o3ZXZwQktHUGhZMEJJQXBYVzZaZkszZkk1TE84d3d5ZWFn?=
 =?utf-8?B?QXY0VEdWVFY1OTBhblJqQ1J3SzFhbWVCUk5SbDJ6L3BWdFR3c0cvSjlTN3ds?=
 =?utf-8?B?cWNxQXlQclRkaStrNXk5Q2d0blRIZzJ4QWVBQ1VHY0ZyRFZkZzFYTG51aW93?=
 =?utf-8?B?SDhOcjNzeFQ1V3c3TU5oRWhUbHZwMmZ6d0tES3pSdkZwV3ltQjlrL2FkV2d6?=
 =?utf-8?B?ZzNVTEFoZHdXdXhLQWtXKys0TmpQS0Z3K05lRGVMUURzTjJkTWxMWmNiTG5r?=
 =?utf-8?B?ZVVlais3Z3hUQ0tlbWlTaVNPeXRCcGpaVlhuM2lHRUVwYWtBS3hIeGxRTnI5?=
 =?utf-8?B?NGF4Snl1cU8vSVFKZzM2ZVpHVmVqc2NzMFpRZ3pLY0dndUZGWnpJNm9lMldR?=
 =?utf-8?B?MUdZb0RMWHJudDVnSHFHTllXUi82KzI2VkNiQTcvME91czJ3ZDhTREdqdHRv?=
 =?utf-8?B?TUhJY2pyL05CZUxQWFgrVVYwdXFsTG9ka3dSNXVxdzBOUkMyZUIvWlRGWklF?=
 =?utf-8?B?SWZXMnVnTXBsOG5QSDFtdXV4VDNhOTZSam1vNDNqUXRLS2JZR0g3OEJWZG5l?=
 =?utf-8?B?UWQrRGNBc2toRjlqVWIwTjhpWS9FRTVLcGxTdzg3RVJ5Q0FRUXMyWFRHQldG?=
 =?utf-8?B?WGNMdXkyTDcxN0lRa1RkTDY3dmNISHZ6VTdlQ1V2M3RoM3BjRTN1QzNOSXZJ?=
 =?utf-8?B?ODYydjl2WFB6Um10WGc0bnZsc0Y4Z1IrOUFwZjcxcGxaSWRra2xoT3Y3UmFH?=
 =?utf-8?B?bDdTRHJrK29pQ25DQ0NUeWtDSWxjOGZ3QmorTnR6citqODBZblVpYjhVSHdQ?=
 =?utf-8?B?WnFOcTFtc3QyYkFQQUQrU0hqUy9YMnB3Z29nM1VQeXl6cVpSUGx2dzNlc01O?=
 =?utf-8?B?VjFxckttRnVOeGkzQkZ5ZGRTN1JGYUg3bFdTWmpETHFiYWRGSVZLNVhlYk1s?=
 =?utf-8?B?TVUybUZvOFZnTmNaMmhyNFExRFdRQzRLdEZMUWEvYW1OQTlzVzhob0NxWTZ1?=
 =?utf-8?B?bDk4TnJ0MFJQdDJDWS81eHBGZHhFc1ZkTkVURjRYcTRPR2lBandVT28xeDN1?=
 =?utf-8?B?ZTdVZlVJcnJFVGFTS1V0dDc5bzRoY1B6L3hzbGZ6UVowbDVOUEE2U2txallS?=
 =?utf-8?B?eHByM2VEKzB0aUdoeDl4QU9pczlkS2dCVDZlblg1R0x5djVrWC81cFk0RmtS?=
 =?utf-8?B?bFFtcWZTaTZic01QRHlVMmdsSXkrRGJnUmFhRFMySWFhMFZydXE0RWhjd0Mx?=
 =?utf-8?B?b084ZFF6bnpnL2ZvOE5qenVGVTMzaVpLUGlDNmpiT2l6VS9uU0hueEtBK1Nn?=
 =?utf-8?B?N3FmRENHNUFVYjhjUXlwMG5IbWliaENlMnN5ekRKNldjUHJhUXJjQitUUE9U?=
 =?utf-8?B?R3NUdW9qZGlSYVViVHErMG1TNlZoZGk4QzI3Ukd4QVZhVm5vUGthWStZNzlX?=
 =?utf-8?B?dURXWFJmV3dmTGs3aStxbDdBT3ZTVk4za3MwM205YVNGREZjOXJ1VkE2bm1D?=
 =?utf-8?B?TVVpQ2I2WWlBV1ZPbGNIdlNjVk02VlJKY1BqMDMzU2poUnk1bTF6UFhuMWdi?=
 =?utf-8?B?ZUtOL1JXcmU3TlRRMHVFV2JkelloaTlEZjFYazk0UmZlOXFKNmpObzF4eXc0?=
 =?utf-8?B?bUE2dkZyaGdtSS90c095T3VCWUpMNy93cGVkL2l0ejB5YlhpcHptYml5Uldo?=
 =?utf-8?B?MVhISzVwWjdCVFNXZnZXNzBXcmVOdzdwMG5yTVlxWHVFanZDSCtndi9TbDZj?=
 =?utf-8?B?N2szemFYNWlHd0FMdTVqNng3QnhmSnRvMmM4T3dMYUdwODVRVVY2UTN1aHBW?=
 =?utf-8?B?YVE4UHI2ZE5oUkNKWWp6Y0hrT08xUXhzWVd3YzFocmFkbnZQTFVndk1oNjIw?=
 =?utf-8?B?RklCZ3NVVDJPL2tWdkh6Z3JpOEV6cm1IanVGbkJ6RzhHY0hOTmxiRldwUEsx?=
 =?utf-8?B?NEJmdUhGYkt4eGl3cURMMk1qcHdLN3pDbnVPVWVOaTRDVENqVk1LM1BxTU1N?=
 =?utf-8?Q?/xKvhnaz+YZhGIbI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6544dfea-a345-4148-8f99-08da17df7dec
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:09:48.6022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /eq+tODyjpGWfO4Wg4cItF7Uv1tKumo6ZeJDIqQmXhecfYtfs+bIIHp1cq40TcgzEmKU+Tr4Bpw3RLBq1I0DPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2896
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 02:47:38PM +0200, Jan Beulich wrote:
> On 06.04.2022 12:38, Roger Pau Monné wrote:
> > On Wed, Apr 06, 2022 at 10:13:41AM +0200, Jan Beulich wrote:
> >> On 23.03.2022 09:54, Roger Pau Monné wrote:
> >>> Hello,
> >>>
> >>> I was looking at implementing ACPI Cx and Px state uploading from
> >>> FreeBSD dom0, as my main test box is considerably slower without Xen
> >>> knowing about the Px states.  That has raised a couple of questions.
> >>>
> >>> 1. How to figure out what features to report available by OSPM when
> >>> calling the _PDC (or _OSC) ACPI method.  I'm confused by the usage of
> >>> this from Linux: it seems to be used to detect mwait support in
> >>> xen_check_mwait but not when calling _PDC (ie: in
> >>> acpi_processor_set_pdc).  I'm also not sure what the hypercall expects
> >>> the caller to provide.  Should buf[2] be set to all the possible
> >>> features supported by the OS and Xen will trim those as required?
> >>
> >> I'm afraid upstream Linux doesn't quite use this as originally
> >> intended. Consulting my most recent (but meanwhile quite old) forward
> >> port tree of XenoLinux that I still have readily available, I find in
> >> drivers/acpi/processor_pdc.c:
> >>
> >> static acpi_status
> >> acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
> >> {
> >> 	acpi_status status = AE_OK;
> >>
> >> #ifndef CONFIG_XEN
> >> 	if (boot_option_idle_override == IDLE_NOMWAIT) {
> >> 		/*
> >> 		 * If mwait is disabled for CPU C-states, the C2C3_FFH access
> >> 		 * mode will be disabled in the parameter of _PDC object.
> >> 		 * Of course C1_FFH access mode will also be disabled.
> >> 		 */
> >> #else
> >> 	{
> >> 		struct xen_platform_op op;
> >> #endif
> >> 		union acpi_object *obj;
> >> 		u32 *buffer = NULL;
> >>
> >> 		obj = pdc_in->pointer;
> >> 		buffer = (u32 *)(obj->buffer.pointer);
> >> #ifndef CONFIG_XEN
> >> 		buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
> >> #else
> >> 		op.cmd = XENPF_set_processor_pminfo;
> >> 		op.u.set_pminfo.id = -1;
> >> 		op.u.set_pminfo.type = XEN_PM_PDC;
> >> 		set_xen_guest_handle(op.u.set_pminfo.u.pdc, buffer);
> >> 		VOID(HYPERVISOR_platform_op(&op));
> >> #endif
> >> 	}
> >> 	status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL);
> >>
> >> 	if (ACPI_FAILURE(status))
> >> 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> >> 		    "Could not evaluate _PDC, using legacy perf. control.\n"));
> >>
> >> 	return status;
> >> }
> >>
> >> (This is a 4.4-based tree, for reference.)
> >>
> >> IOW the buffer is passed to Xen for massaging before invoking _PDC.
> > 
> > Indeed.  I'm however confused by what should be pre-filled into the
> > buffer by the OS.  _PDC is about the processor driver power management
> > support, and none of this power management is done by the OS (I don't
> > plan to let FreeBSD do CPU power management when running as hardware
> > domain), so IMO passing an empty buffer and letting Xen fill it is the
> > correct thing to do, at least for the use-case in FreeBSD.
> 
> I don't think that would work: Xen doesn't "fill in" the buffer, but
> merely alters individual bits. The buffer really is IN/OUT here for
> Xen.

Hm, but I have no idea what to put here from FreeBSD PoV, as said
FreeBSD will only use the processor object to upload the required data
to Xen, but won't attach any driver itself.

I've so far been providing an empty buffer to Xen and it does seem to
set the right flags so that the Cx and Px states can be fetched
afterwards.

arch_acpi_set_pdc_bits() does explicitly set some feature bits, so
there's not only cleanup done there.

> >>> 2. When uploading Px states, what's the meaning of the shared_type
> >>> field in xen_processor_performance?  I've looked at the usage of the
> >>> field by Xen, and first of all it seems to be a layering violation
> >>> because the values set in the field (CPUFREQ_SHARED_TYPE_*) are not
> >>> exposed as part of the public interface.  This all works for Linux
> >>> because the same values are used by Xen and the Linux kernel.
> >>
> >> Well, yes - that's the way code was written back at the time when
> >> cpufreq support was introduced. It should rather have been
> >> DOMAIN_COORD_TYPE_* to be used in the interface, which Linux
> >> translates to CPUFREQ_SHARED_TYPE_*.
> > 
> > I will send a patch to add those to the public headers.
> > 
> >>> Secondly, this is not part of the data fetched from ACPI AFAICT, so
> >>> I'm unsure how the value should be calculated.  I also wonder whether
> >>> this couldn't be done by Xen itself from the uploaded Px data (but
> >>> without knowing exactly how the value should be calculated it's hard
> >>> to tell).
> >>
> >> As per above - while it's not fetched from ACPI directly, there
> >> looks to be a direct translation from what ACPI provides (see
> >> acpi_processor_preregister_performance()).
> > 
> > Yes, the translation from DOMAIN_COORD_TYPE_ to CPUFREQ_SHARED_TYPE_
> > is not a problem.
> > 
> > My concern is that there's some logic in Linux to assert the
> > correctness of the provided data in ACPI, checking the match of the
> > domain and the coordination type between all the processor objects as
> > part of setting the field.
> > 
> > I see that Xen also does some checks on the uploaded data in
> > cpufreq_add_cpu, so I wonder if I can get away with just setting the
> > shared_type field based on the coord_type of the current processor
> > object, without having to cross check it's coherent with the values on
> > other processors.
> 
> I guess you'll get away as long as you don't hit systems with flawed
> firmware. Whether the amount of checking Xen does is sufficient
> depends on particular flaws found in the wild (which I lack knowledge
> of).

I guess I will do with that. It's all experimental anyway, and if I
find one of such systems I would try to fix on Xen then.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:14:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:14:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299971.511361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7Mx-0006qy-Ff; Wed, 06 Apr 2022 15:14:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299971.511361; Wed, 06 Apr 2022 15:14:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7Mx-0006qr-Cg; Wed, 06 Apr 2022 15:14:51 +0000
Received: by outflank-mailman (input) for mailman id 299971;
 Wed, 06 Apr 2022 15:14:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc7Mv-0006ql-NA
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:14:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4c941bc9-b5bc-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 17:14:48 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-2cAHflC2MUu1dwceugu9Dg-3; Wed, 06 Apr 2022 17:14:45 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0401MB2542.eurprd04.prod.outlook.com (2603:10a6:800:55::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 15:14:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 15:14:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c941bc9-b5bc-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649258088;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Wy0BAGBUiBDqNGLlf+POg46fpf7VoNTa8vzHxtxKSDk=;
	b=IIZ+nyDOs8+jwYF3WMMyHgHg3PNplA9n/PuWfX/ooIxpeHgDxEAB0QXSu0fQjqxo/76e20
	cOv1Xh9/snkGBAyIFosN88mBUPnry0LVkINJtt8hk5ZJlA2hfV9AOq3Hz0jVuXDIUnNVBY
	qby6d8WImeawhDvb+Et+SDFdPAY34o4=
X-MC-Unique: 2cAHflC2MUu1dwceugu9Dg-3
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lmGO6VR425V+v0xQPKLe1WodvsMeD4eBQSCc5M+9nFttesYupn6MxACA25UObhW/wTLIcqLGVOfCq+vlMKMdt4w/T5+5iR04MbnjGiWaLhNfZzCryieN++BbzOB4uPRlZbh1mgL/9eqHPuOlxxaEKsCajbih90Vy6cFjQf69h9grAWxORyGvY+y0N9J8Sibq0z/KT2GDFK4WfmM8//XORUbyb1y4oL9ycJYXHs+tC7zMPx+KKYBeuCW+pzDp9d6XfY34ihPkhLRHtadC1ohzqmY8k39NMaflDtAOdI/e/3tYpaLqLqjqYbY2Na/bc5VUnnzyNbz4hQyu9rPQ1cl73w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Wy0BAGBUiBDqNGLlf+POg46fpf7VoNTa8vzHxtxKSDk=;
 b=nbKG2Nn9Aea166dR2Ohf1zTgkkDfGXaOw9NItW03xQ6zcV/pjM/tS3VLaQNsW1OcWFkQ2Nu4lIkf7lm2lkydCNjSvC8JtVprUIe9D+VuoMzeT3j2/QnXYZUz8uH9DBS3ROmNuNFYLGD5AjICai9lAUDXD45nYJAQlxCrATziiA/5XWUyq+84IUdpIl+81CrvEzNr7qsqnFoanxkhhK94pVnT156J93nCe8X0uVhHFgiygaKaIwEUU3SqdH0vBwg0odHmNgiAi5lN9giwU/7myEt7JFVXqaf2t8hwdvS4zk0Dz69cpeLTvDdGkJBLjyr1lcjfKzReUhgYYmcLwv29zA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9f593bdb-d95a-4705-d24a-f8767d69a09f@suse.com>
Date: Wed, 6 Apr 2022 17:14:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v3 2/2] x86/monitor: Add new monitor event to catch all
 vmexits
Content-Language: en-US
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 xen-devel@lists.xenproject.org
References: <d1a7a48fa2d46c6a6cbf8f93926a8839aaba92e3.1649256753.git.tamas.lengyel@intel.com>
 <73e6b45525e1be753d3e243d42ad632bbc5690b0.1649256753.git.tamas.lengyel@intel.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <73e6b45525e1be753d3e243d42ad632bbc5690b0.1649256753.git.tamas.lengyel@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0038.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cebd7334-1ba5-4a40-485c-08da17e02a5e
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2542:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2542FE9BE1AF1897681EC530B3E79@VI1PR0401MB2542.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RFq0j8iIECTN2ZtOsC3Tyo6Ahz/Jk1jLmMbg5SDKLvjUjQUlyklOLzP2J5ufPuT9VljHrzxnFoDjPe49d2vETZ4zYbJFQLFG8kOR/AI3LpDzO+TOT295cuJizimkldSEci15XhsWM1NDlXMLSOiimBCRY1cZ9rR96qv1qNOu1cQbQBSJ+OrVshVDAQyydAA5/Bm2mtuOfa+7UR/UJTgvmop8BOLpPGvhRjk09DBafLxa8uuE7KxuswRqO13TzC9IRf5tSVaklKXY+ELuwjLPaflmg9Mdy1Ipn8FrNd0hnY6eMjhyWjqShUkTKd4zQGYzYPo+eKYli6Prub3p8HRaNI80eoc9W74g1Xjl7TOa2IUBtoxtfG9vD8dRz7y1giavWBQ4C9EwDsp+0WlEuViqC7IdqqfTrptLYwv9N13Qiwzz2Ith3Ba6somZlYdN6rN0950ucdTHBPlFglBPH3KfEy93svNvAHcF2bZXFhGfjOrr1VcMBsl6SS9XshzGcvJskuwYy2evCA+6Q6/wb+W/Qx74M4Y5aAxfC2WtQmSkt2O8I+kWRK+O2Was9rbw+Yrec+Kv8cBHXt50DqsK62KNKQmQd4BW4+aUnf27EUzIvTSNslth1tMuW2udy47vqYLheMk7Ua/wOLRrMlbEovoXdhjIAKY2md6MUsR9L9YAITpHPezGkkkoSNEtOdAHeLhgx2I7Z2IQ/mwQ2IdSZZ9BAioSHwdE4Z+xKkVVfpVJx9+BcqHuAL8M2FnRQIcd8V2j5vKrjryugrXyxJHbd79Ayjib+Djlb3E8AO8cllWlLw0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(5660300002)(186003)(26005)(31696002)(4326008)(83380400001)(66946007)(86362001)(38100700002)(66476007)(66556008)(2616005)(2906002)(8676002)(508600001)(31686004)(6666004)(6506007)(6916009)(53546011)(316002)(7416002)(54906003)(6512007)(36756003)(6486002)(21314003)(45980500001)(43740500002)(309714004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dGNLcWtodG9vcHFhc21ESUhBTHZiOUdUQUtsMkZucTZpL0NrR29TM1E0RVdK?=
 =?utf-8?B?S21uTml5WTRaQ2pmUkN6bko2QkRYd0dwQzlTTUlHY3owKzQ3YkREM2pMZEF2?=
 =?utf-8?B?Z2hFZEU3eXpENXhSVDVLZE95V0gwSi9pVys4dk5DQTkxR21wd1M1NFRmOVAv?=
 =?utf-8?B?ck1IdlgyZVAxY3oxUDhKRjdKODE1K3JkODFDZ0c2N2pFbE03TnE4cUxkSjFK?=
 =?utf-8?B?Q2t0TldSajhWYmtkd0NmM3pZVzhpL3hEejRFeURoODdGdHFkbFNSKzhwdEFI?=
 =?utf-8?B?VjFVKzVKTHJMNWE5TGJWRkx6RnFVRU5hVG40enZGbEw1bGlDdDFmVDAxbUdS?=
 =?utf-8?B?N3lYb1pPN2N1TDluczdtYzlVbTkrQWtxM2g1cythTmplcXlOems4eFhYQS94?=
 =?utf-8?B?aklZeW5JR2FLZnpob2t1NlRhTDdWMUdmMFdRWGFsbTI0a04zMnF1RHRYanNx?=
 =?utf-8?B?RDdGbFQ5WEhvbjhDZys3TENXMm1zVXVFbFdic3pFYUhGelIrcll3eE9WbWNU?=
 =?utf-8?B?Y0kvRXU3dkZPNzQ0WXJLYi9JSTNiQ0VWMDJ0Y0pTdEw3djZjekRKNlF4eWhu?=
 =?utf-8?B?ODB4UndsYjY0OUhPWENqUjF0MlU3R1ZIUnUvamsvQ3g2K1BETjhvSmw0dUxP?=
 =?utf-8?B?WENwbTRVMjdhYW1xZGRlUW5ueGdLQzFXL3A3Mi9hYzAwNkVyNjgrMG5WR1ZX?=
 =?utf-8?B?dW13dGpPcURDTG1KUjBHMGljUjRrRWZpd2RlV2pXbUlCZGFyUmR0WVVWTmR4?=
 =?utf-8?B?SFBad2t1TlMrWWxWUldrUjJyazVOVDhjOFh0Z0dudHVhNUFxUGZwNjd4VVlF?=
 =?utf-8?B?RVoxcUZpakJvTVJVajR6bUQ3TnZzV0ZQSE0wbFc3ZlZHSzNzQ3BSOTdJZGh4?=
 =?utf-8?B?VjFjb204L2JmZ0dUdmVRTmZmSkMzR09EeHZ0QnFRbml4M0NnNHF0ZDd4M2Yz?=
 =?utf-8?B?ODR5c2tQZ1RMNWtiMFFhZzlDbThtYld2a1Yzc0FFeWVDeHhGYzk2S3FaaVNS?=
 =?utf-8?B?Rm03YnJiT255OEZtdUNsaU94dUhBa3BvcXRiSXRQcm5LMHJpQlpTd2o3WHla?=
 =?utf-8?B?S282KzN0cWEzL0J6OUdNRGw1dkxvR2ZGSEE2WHRFWGF6VWRJOW5sWWgvSGhG?=
 =?utf-8?B?dkh6Z2RrcE1QclVYdXFmcnJLeHc3cEwvTWg3dHRqM1pIN3ZrWWxhQmxvZGtR?=
 =?utf-8?B?VFNSaVBHenRCZTI0T01zQmQ2R1V2am50WUVMbU1FV0xaeW5EZUQrbDJSSEJK?=
 =?utf-8?B?aEswNHB4Q05hWHV3MEwyTzd5VllRNDU1b0dBTmwrMDdXRjZMcGF2NmozMURB?=
 =?utf-8?B?bmkxQUdUaXdKcjIyVzFHb0YxSGdNc1dLZDJGTVdKeUJhd1cyRFZDMlRvWjli?=
 =?utf-8?B?eHlWb2J4YnV5cWJOZ0ZKaGVWdlN2MDYzdWxUM3RRTUNsQnlOR2pGK2c2NWZG?=
 =?utf-8?B?Vy9WRHNacFhTNmNKbThuc3NHMjdiZFQ5eUNydUtOSStBZ0RLTUFwMUhrczlG?=
 =?utf-8?B?MmhnUGt3aWMySTd1WjRTbHpYRFBvNFNLckFlZW4yS0VKc2dyY0hQV0x0UGh4?=
 =?utf-8?B?UzVReEIybThvWFhpVEZVSnlRaS9VaHVCR0hoWEl6TCtEWnM5a0xPY1ZOaUxM?=
 =?utf-8?B?OXdGZ3lNaS9pKzdPMjd5eVNCc21jK0M3K3N6RUhKWGwwVHZrNTFwTVdQUG84?=
 =?utf-8?B?dHJnVDN3bGFTQkd3aHFjVXpYdHVFd2JaajUrK3dMTEkveGRlOEdkYTdwdDRH?=
 =?utf-8?B?RlNNT0YzN1pUaUx6QWhxbWVtYVdHbWo0MUpXZWE5MWZNTklMOTZQazZ2RFQ0?=
 =?utf-8?B?K20wTTk5L3ZWN2FtOWtHVFZ4QzBhRlBmY01BZHJDOEhGM3RHK0x6aWI3TFJS?=
 =?utf-8?B?ZnpBZUJ2TjlrTEJrRU9NOU9lSWxqV1ZLMEd0aHkxS1hNUmloOFBnKzNqSmxl?=
 =?utf-8?B?TVl1Nm9pWG50YkNFSWhpUWd1cmNjQzUwMlpnUkRYVitjOXd6SEloaCs1TFcz?=
 =?utf-8?B?cFFmZStpNlhrOW10dmxnSkhCcUw3VVlsaXZRSVF3Szh2b3d0aHF3L09wcU16?=
 =?utf-8?B?by9MK1hHSXpWcjVtVlphODVFdGR5akpCUnh5K1ZwaEtPMjByM2c5NFkxUnB3?=
 =?utf-8?B?TGVvVUNLTVdNMXV3dWxaM0l3SWp3OHl2MUZkd3FnMDc4djlhTGZ4bEE0QUJD?=
 =?utf-8?B?OHcyMGsvbGw0NmtBYW9ackFZMUdGdWxDRzZUZXFBdUNjZ1hJbEhMbTZFQVRw?=
 =?utf-8?B?LzdyNnRRU3JZSVlkaGhUNWpZdVU3c2c0Tjdsc2cvUzJ1ZWFmci9qZDMvZ2ZP?=
 =?utf-8?B?Sk9heERIYWhxSW5aTVZqRC9sU1llYkhNOU1oaUlrUCtZUUt2RVBCdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cebd7334-1ba5-4a40-485c-08da17e02a5e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:14:38.0106
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Net841zD5kYdTesMhAJB8SXZGFmqHhaKC0Xr1xosvgczX9stVALTYOyTqhDpKNa+hVviKhE0ee7USmCBEmT3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2542

On 06.04.2022 16:58, Tamas K Lengyel wrote:
> --- a/xen/arch/x86/hvm/monitor.c
> +++ b/xen/arch/x86/hvm/monitor.c
> @@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
>      return monitor_traps(curr, true, &req) >= 0;
>  }
>  
> +int hvm_monitor_vmexit(unsigned long exit_reason,
> +                       unsigned long exit_qualification)
> +{
> +    struct vcpu *curr = current;
> +    struct arch_domain *ad = &curr->domain->arch;
> +    vm_event_request_t req = {};
> +
> +    ASSERT(ad->monitor.vmexit_enabled);
> +
> +    req.reason = VM_EVENT_REASON_VMEXIT;
> +    req.u.vmexit.reason = exit_reason;
> +    req.u.vmexit.qualification = exit_qualification;
> +
> +    set_npt_base(curr, &req);
> +
> +    return monitor_traps(curr, !!ad->monitor.vmexit_sync, &req);

vmexit_sync is a single-bit bitfield; I don't see the need for using
!! here, even more so that the respective parameter of monitor_traps()
is "bool" anyway.

> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>          }
>      }
>  
> +    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
> +    {
> +        int rc;
> +        __vmread(EXIT_QUALIFICATION, &exit_qualification);
> +

Nit: Please swap blank and non-blank lines here.

> +        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
> +        if ( rc < 0 )
> +            goto exit_and_crash;
> +        else if ( rc )

Nit: No need for "else" here, just if() suffices after "goto".

> +            return;
> +    }
> +
>      /* XXX: This looks ugly, but we need a mechanism to ensure
>       * any pending vmresume has really happened
>       */

A few lines down from here failed VM entry is being handled? Wouldn't
you want to place your code after that? And wouldn't you want to avoid
invoking the monitor for e.g. EXIT_REASON_EXTERNAL_INTERRUPT,
EXIT_REASON_MCE_DURING_VMENTRY, and at least the NMI sub-case of
EXIT_REASON_EXCEPTION_NMI?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:15:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:15:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299974.511372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7Ng-0007O3-QR; Wed, 06 Apr 2022 15:15:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299974.511372; Wed, 06 Apr 2022 15:15:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7Ng-0007Nw-Ln; Wed, 06 Apr 2022 15:15:36 +0000
Received: by outflank-mailman (input) for mailman id 299974;
 Wed, 06 Apr 2022 15:15:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nc7Nf-0007No-Ex
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:15:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc7Ne-0006tP-LL; Wed, 06 Apr 2022 15:15:34 +0000
Received: from [54.239.6.190] (helo=[192.168.16.200])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc7Ne-0007uQ-Ey; Wed, 06 Apr 2022 15:15:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=zrhhKxYRFt0oNNximxDKFPmJU0HX1ATTCZI1UaDNYBc=; b=zifQb8YS5m6vbD3arrdgagcnsu
	AabfW1ZmRnOxjeuAaSFY6SQvDaG7VHqVK3lhh1ZM5QMmc0MVv5Kbqvvj/Ks3TdMSrkFw3tt+nLIuC
	ilrJb+voV9co2QlP7b39Ik4UEJXfsBAw4mtL80wZgh9h+BZSi6v4KMM3KfeizgAVjziA=;
Message-ID: <6ec0e3d9-374c-1caa-9889-f091dcf894e3@xen.org>
Date: Wed, 6 Apr 2022 16:15:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] SUPPORT.md: extend security support for hosts to 12 TiB
 of memory
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <4c49e4cf-9d86-e630-a1bb-37afdf091c99@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <4c49e4cf-9d86-e630-a1bb-37afdf091c99@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 06/04/2022 15:44, Jan Beulich wrote:
> c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very
> much memory"), as a result of XSA-385, restricted security support to
> 8 TiB of host memory. Extend this to 12 TiB, putting in place a guest
> restriction to 8 TiB in exchange.

And this is even without CONFIG_BIGMEM?

> 
> A 12 TiB host was certified successfully for use with Xen 4.14 as per
> https://www.suse.com/nbswebapp/yesBulletin.jsp?bulletinNumber=150753.
> This in particular included running as many guests (2 TiB each) as
> possible in parallel, to actually prove that all the memory can be used
> like this. It may be relevant to note that the Optane memory there was
> used in memory-only mode, with DRAM acting as cache.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra
>   
>   ### Physical Memory
>   
> -    Status: Supported up to 8 TiB
> +    Status: Supported up to 12 TiB

I am afraid this limit is going to be too high for Arm. Even the 
previous one was technically incorrect. From [1], it should be:
   - 5TB for arm64
   - 16GB for arm32

>   
>   Hosts with more memory are supported, but not security supported.
>   
> @@ -121,6 +121,14 @@ ARM only has one guest type at the momen
>   
>       Status: Supported
>   
> +## Guest Limits
> +
> +### Memory
> +
> +    Status: Supported up to 8 TiB

For Arm, this should be limited to 1TB for arm64 and 16GB for arm32.

> +
> +Guests with more memory are supported, but not security supported.

d->max_pages is a 32-bit value. So Xen can effectively only support up 
to 16TB of memory. AFAICT, it would require quite a bit rework to lift 
that limit. So I think it would be better to spell out the upper limit.

Cheers,

[1] https://wiki.xenproject.org/wiki/Xen_Project_Release_Features

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:17:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:17:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299978.511382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7P3-000811-3m; Wed, 06 Apr 2022 15:17:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299978.511382; Wed, 06 Apr 2022 15:17:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7P3-00080u-0n; Wed, 06 Apr 2022 15:17:01 +0000
Received: by outflank-mailman (input) for mailman id 299978;
 Wed, 06 Apr 2022 15:17:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc7P2-00080m-5X
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:17:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9916c42e-b5bc-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 17:16:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9916c42e-b5bc-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649258218;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=vZdFDCTxII6DTjdZMNTIMRG//1iiEGY1pLgIJzqp3Xg=;
  b=AzVeFguxEOo0HG0wnVmPldqvtLkCKmOgffFlXc7Xyhxn0RPc68dGb/eV
   Q0xrNfHaqnzfn5dufOFkMd9Udp6y8hO4te1SKQ7DZiOPMQYoMiunAQxO8
   TCl3H623IuNaqn8X8KkNHySeNMZ91/MQAryCJ3YkJRcXk7zuVfyZMVJ23
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68183416
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PSGRp6ny86D2n+aMyauiL0Po5gy+JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeD2iFPamOYTH9c9gjYYW/8kJUucDRn9Y1HAtlryFkESMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW13V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYCj4FL7XNuL0ncBhIOhFjbbFfx6/cLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6aHN
 5FFMGQHgBLoPhJhIAsTVbgCgua13HauIxNYimzIuv9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt
 m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCn1m71mEVThoMWjOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYeUddNF+wx6CmW17HZpQ2eAwA5oiVpMYJ88pVsHHpzi
 wHPz4iB6SFTXKO9Ckux56+VjWqIGikFBF8fNTMdchse7Iy2yG0stS7nQtFmGa+zq9T6HzDs3
 jyHxBQDa6UvYd0jjPviow2e6964jt2QF1NuuF2LNo6wxlkhDLNJcbBE/rQyARxoCI+CBmeMs
 3Ef8yR1xLBfVMrd/MBhrQhkIV1I2xpnGGCE6bKMN8N4n9hIx5JFVdoOiN2ZDB00WvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMosXMsQhJF/Xo3oGiausM4bFyhZEfUYXY
 8nzTCpRJSxCVfQPIMSeGY/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9zb6Sp
 CziAxMGkzISRxTvcG23V5yqU5u2Nb5XpnMnJy08e1Gu3nkoe4G066kDMZAweNEaGCZLlpaYk
 9Ftlx28P8ly
IronPort-HdrOrdr: A9a23:EU/p1KApqAqRQLDlHehasceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6LS90c67MAnhHP9OkPIs1NKZMjUO11HYSr2KgbGSoQEIeBeOidK1t5
 0QCpSWYeeYZTMR7beY3ODRKadd/DDtytHOuQ6x9QYJcek8AJsQkjuRRzzrZHFedU1jP94UBZ
 Cc7s1Iq36JfmkWVN2yAj0gU/LYr9PGuZr6aVpebiRXoDWmvHeN0vrXAhKY1hARX3dmxqojy3
 HMl0jc6r+4u/+25xfA3yv47ohQmvHm1txfbfb8w/Q9G3HJsEKFdY5hU7qNsHQcp/yu0k8jlJ
 32rxIpL61ImgbsV1DwhSGo9xjr0T4o5XOn40Sfm2HfrcvwQy9/I9ZdhKpCGyGppnYIjZVZ6u
 ZmzmiZv51YAVfrhyLm/eXFUBlsiw6dvWciq+gOlHZSOLFuIoO5lbZvs3+9La1wUh4TsOscYa
 hT5YDnlb1rmGqhHjzkVjIF+q3tYpwxdi32MHTq9PblkAS+p0oJvnfw9PZv4Evoy6hNO6Wsn9
 60SpiAtIs+OvP+PpgNc9vof6OMex/wqFT3QSCvHWg=
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="68183416"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=npDGWDdM/ei2QOzVQyKeGnte6XyTaKw4fBFNlfkDEwL4ba+LRrgQMpogk1Ayc88NuV24HMH5AKhbSemhQ7/lYeAVX6CDN0hmKpRCQXnOw4Wl2iWKewJMi7fM9vN7uqf736KQDcG2kiY9PJ3mmH7JTifYHjq84lx3T1y4FC6HDkY4CtfybhFyZoA343NdIs9bUVddqvupXL+o+/GHr5UL4Mq7+JRL1Yo3lrB7SkSgWGLXFD/REi57gtLp+IVwbwLd++WnHtL1MszL5zMuiaw9qJ1Vin+KvbEGKf6RHQs+7zbBVwr5HzTrDbTDfp8B3K6vbBdW+QEvJjBJ0CBzL48Zrg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iIQTgOVt3wf93/U8SGKRpU2zbTVt6Bq9lixp/soUrC0=;
 b=gPU4hVuXG5IaASDCHigNh8Tr7K2EQI1aVbKKgS+pYJcagGlYiueS0PG2EPk7EdqIiW3env8+SkAC59RnzR/0v/AsRCE/4oVmMmXF4aMHDbogxuT73KPsZadxZRrA14ieG1pxXDkTmbSDvy2qm+cCc10JvAIKnJd346XhR1HnTxz8Iqyo5Cag7Him7JNAo4OQoKyMUGEedfzp6BgEAStmvxrTEn+CmtsJa7cK8DjFyI/1ni2txez2OB9feVCCIm6eZH4ZxGb/Ca6OTO9PTOL6qEctY6yKhaBkPIvoHDEVjTAc12vmSBSBnaNFDtfOkutCSVnZnzK2HnNED9QqwqSAZw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iIQTgOVt3wf93/U8SGKRpU2zbTVt6Bq9lixp/soUrC0=;
 b=vCPMy2aUmpSwKRGA/pJT5aiayQY2it03qFG1fxKHniFaXG+dB4Pxc4kYZfzoZW0IMy1Z1/6q2uRQoK1wtZaLGxnQjCwYZzhiBnlwyZE7ORpIl2GOyDWGmO7I49ksZO/4hczc+N2V5gyf50L73LsLxOpEJgLBkTjhSsnehmVUW3s=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Subject: [PATCH] platform/cpufreq: add public defines for CPUFREQ_SHARED_TYPE_
Date: Wed,  6 Apr 2022 17:16:45 +0200
Message-ID: <20220406151645.32827-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0022.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:a6::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7e849da5-b895-40c7-b6e0-08da17e07ba7
X-MS-TrafficTypeDiagnostic: CH0PR03MB6082:EE_
X-Microsoft-Antispam-PRVS: <CH0PR03MB6082D1F12864288CBAEAC5308FE79@CH0PR03MB6082.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2jS+hE9R8yoHTnw0daQsqPByYs6EhmfLL0Nu1NyfvxVeN8Iwa7Per1D4mw4oJ2B3T+bueYix1sPRxfO047MK8OFKYGLPfh+GZ02cqNH7WZy604w+/nfmTs/ZkGOznwk066yH+QSj3dPTZbUL7fht0RPqx68ObK50/InIu/vDWwY0FcUt1oAQpkWuB2W/3VbodwFiKwJ59VZ09Dl7fl/UoWD7e7UMZ09iUozoN4uMPbwfpiSYD2ffVxI88A5CtecTgOCPKpWOrctgFiFT8vfTXNOtIRWbmfILjBXjprgRqlYnDncKzF14b/qyCkuaz/C0VbTWGF1OOPGLvKsxQDlREw9EJlgpSOdBMLXZ840AVkJSz5zSoHJvpvAigtWyImbH4FmKCVLJilS79hQCkVrxwxbr1RcYrLW9PCsa8s5bBNGJmiMCd26HtP4xU/NREYKWG6bMhIRS3QxPOVo7ryDCpsk660jJdBdqwIFoa5GF1tLf5dFSjGMG8NvzhXWzh2WgleMGTHifibt8MRHPECFMqAQhbrxCkErh8YfOR6c+qGDDlVzwN408Cfmyeo3wHfXJ5+IxoIJl9w5vRxxoxc+MjZNcGFNO5nDQnVS1t8yw6U2WgKBlNJe1v39TwanQ7fO5XZ1u41CYK9nCaY66E9NVdg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(2906002)(66946007)(83380400001)(6486002)(4326008)(26005)(66476007)(66556008)(6506007)(2616005)(8676002)(186003)(8936002)(86362001)(5660300002)(6666004)(508600001)(1076003)(54906003)(316002)(38100700002)(36756003)(6916009)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzh6dllhbU9vNFFCckNFaDdYbFhFejE5d0hIMEpnTC9YVDdYWVA1Qk5Kbktt?=
 =?utf-8?B?b2luQjhOSDdMaHR6SmdwZ1pnRUYvdUcrckJ0NHVKVnp1UkUyckJhRXF1SlFz?=
 =?utf-8?B?TzhhQkJveWpDVDNSang5ZmFOL0pGOVlBYkRmUC96OW8xN2pyTHZnbjlLKzc2?=
 =?utf-8?B?QlZMZnR3Y1BSRG5FdXlOd1N0ZjQ5WmpiTXNybHFCbGluSC96czFZUFhlZ3I0?=
 =?utf-8?B?VllKN1lkaWVWQWlRcGFhVDZjWEROV1F4SVZYMStWVE5qUWhLN0cxSk56WExu?=
 =?utf-8?B?OVhNV0ZtdVVvbUxSVDk3TGhoMEhuUnZNSmxVNXlmL3hvNnVOZDhDQWhuTisz?=
 =?utf-8?B?L083VitHb2dYaDZEeFFYV3F2OWhKL1pBb3VLaXdJVFd0QW41Y0FJbUdBNFhU?=
 =?utf-8?B?T2o3R0xqMWZncWlWaDhVa2NaRWNZZE1sdXZFR2l6aTNGa1JZSlVscnd5eTdD?=
 =?utf-8?B?NmNrWDU1QThMTmE1VnEwcGRMeEJNelZmTE1rOEdjTlQveDJvUG9XbzR5eEZ0?=
 =?utf-8?B?eHdydDhvRVhKRFpKSTV6YzlkMGEzZFhYK29JcTllcXVIazhJejhUQ29oVXV5?=
 =?utf-8?B?OSt0U3lBMXYvQTRxa1RsVWNyTG9nT2tTL21oQU9KdkdENjBFSXhkd1RxYzJC?=
 =?utf-8?B?L3Y0ZUFmakpsNWtyRjIwbEJXMytpbC9LZ3ZuOXozaU9BRTNoUFJWT1JFTHY4?=
 =?utf-8?B?M1RTdVN2QTg4TFFWYXZNMVR4M0l5dkZ0RVVtQ2x2akNNSDhUUVVqaklUQk1Y?=
 =?utf-8?B?TGFIQXhJL01xZmtkbXFtaVFUK1ovWks4dUFldVptd3IzMGg5MkxibUEvVDBK?=
 =?utf-8?B?VGY1N3k0cm5mckZETkZGcVV2VWRNYzMrQVNlTDBybTdiT3hUa3Jxc0JHZjVn?=
 =?utf-8?B?VE5pZ25EbFFJTG5NMTh2TzQxMUFtRXdJQjVjam1vUlVCdjlTR0hnWUlraVNh?=
 =?utf-8?B?RDR5ZkdHbGE5b2YvT1AyU1Z0WjVud0VOS1VvbFlpZmtnTTc0MHlyS3preTBU?=
 =?utf-8?B?SWNMVzAvSHovcHZkNXhqZy9yNHNzOTE1MS9XdzYycTBSSmd3TlpqOFNZbXNU?=
 =?utf-8?B?OXNqY1U4dHdaVzJ5ZmwyVjVvdVhxTVdhNjhKc0RPYi9WdDY5MVdLSDMxZmVv?=
 =?utf-8?B?STNBL09xSkZvZkVEdEFCSEw5ZHo2Q2xYQWhwb0QzZVJaYUVwQTNrU2dUeWRk?=
 =?utf-8?B?U3ROZzYvUmpEaHltaDlRYjR5UnBoeGRKaFNPd3ZzMTMreFQwZ1BDK09oNk1U?=
 =?utf-8?B?dnlqei94MG1qSVpsemhYNWpYL3ZaVng3STR4WFN6TndhS1F4UW9LbVVIQ1VB?=
 =?utf-8?B?ak55N09NZk9RVTV4NXZHMXNtL29rbFAxQmY2MWN0REhhSStDbjFGMGZsM0dF?=
 =?utf-8?B?NndWVHVoL0tqZzdvVHlmNTRuSDJkUW1leDVNRnVXUkI4YmJpYWJlcEVTK203?=
 =?utf-8?B?ai9HemtkZkgrSGtKZm5GLzRyZXlPLzFMUDJkSmlBMC9adVk0d0tjd0NjSDFD?=
 =?utf-8?B?YlN3S3lreWxVRjB1R250b0lQL2pndkw0MWsvblZ0RjkzVDhOdVV0N1kxalNj?=
 =?utf-8?B?dmNMa1pEdytwRjN4cXYwS0pYWGNkc05zTkVGUFl5Ky9qdSs2YW1jMlRESUhj?=
 =?utf-8?B?MUxZUmo3TnFOT25vdDYySG4raXNsRG5lREhkdk5xQmVXY0YyV1N1RGNlWEt2?=
 =?utf-8?B?Uy9Rb2QzZWQzZGY2R2tmcEJEcERhY1h2R2ZpeDlLWHZOWmhDdnpFYjBDYnor?=
 =?utf-8?B?OXZmRlZmUEVqTTNaaTRucWFHeHlpcEs2U2xhdUZ4YTM5U3R5MzNRdmNYWXBk?=
 =?utf-8?B?eWxpSldsamtCMHg2U01kWUh1TCtkZGxLVWZkWjZtWERjY2hhWm1PR3hJTFdP?=
 =?utf-8?B?UHlKV0M0Y29mZXE3cnJ3cWxQclUva0RDM3gzRVU4OFpCUENpb2xkS2JKUmxU?=
 =?utf-8?B?czBsT1V2R041VjhQM01ndWxMMThwSnc1dmFHRk5YbDRUVEZNdVhLOWNNZmMz?=
 =?utf-8?B?ejd5Wi9pbS8zT2tjREZlRTVJa2kxRHhyb0s1SmtYYjg1YjBaaHBVeWV1MGZq?=
 =?utf-8?B?N1RhMnBSYzd2SU1JMFJ3TEN5MmRicGlHT3JISkJtcFRSbnE2SGR0VlJLUTM4?=
 =?utf-8?B?TUFoYXg5Sk5CbnN2QU4rclA5Ynl5OWwwc0Y4QVVldFh0S1lsS2d3QkRiYzFs?=
 =?utf-8?B?Vko1OWZFVTBCVmlVR05laWRGbExkeFhJcUlwZmh3U2xMYU9KR0tQeWZIaEdD?=
 =?utf-8?B?ZHYxbnBtMXdrbmhLNHE3VENoRkZlU3lValV0a1VFL0pDdzY0OXFLRG1sS2NO?=
 =?utf-8?B?cC8rRzM3YjBwblVLNUpxT01GelhxVnNzU3BaYXI2RzRyTGN3Z2pMbVdUUUlh?=
 =?utf-8?Q?PK90VtqyAXKxN91Q=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e849da5-b895-40c7-b6e0-08da17e07ba7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:16:54.2142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dNh+/CxvOxQ+Wa5A8Tp5Ltycy71FLV5s39SP5S3fI+DM8+R7Az+XgDPALDMAxSFOhngVXyGufMlEJOQAghWTsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6082
X-OriginatorOrg: citrix.com

The values set in the shared_type field of xen_processor_performance
have so far relied on Xen and Linux having the same
CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
public interface.

Formalize by adding the defines for the allowed values in the public
header, while renaming them to use the XEN_PERF_SHARED_TYPE_ prefix
for clarity.

Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
I wonder if we want to keep the CPUFREQ_SHARED_TYPE_ defines for
internal usage (and define them based on XEN_PERF_SHARED_TYPE_) in
case we need to pick up changes from Linux.
---
 xen/arch/x86/acpi/cpufreq/cpufreq.c    |  2 +-
 xen/arch/x86/acpi/cpufreq/powernow.c   |  8 ++++----
 xen/drivers/cpufreq/cpufreq.c          | 10 +++++-----
 xen/drivers/cpufreq/cpufreq_ondemand.c |  2 +-
 xen/include/acpi/cpufreq/cpufreq.h     |  5 -----
 xen/include/public/platform.h          |  6 +++++-
 6 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c
index c27cbb2304..200c6ac851 100644
--- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
+++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
@@ -426,7 +426,7 @@ static int cf_check acpi_cpufreq_target(
         return -ENODEV;
     }
 
-    if (policy->shared_type != CPUFREQ_SHARED_TYPE_ANY)
+    if (policy->shared_type != XEN_PERF_SHARED_TYPE_ANY)
         cmd.mask = &online_policy_cpus;
     else
         cmd.mask = cpumask_of(policy->cpu);
diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufreq/powernow.c
index d4c7dcd5d9..e03a079ecb 100644
--- a/xen/arch/x86/acpi/cpufreq/powernow.c
+++ b/xen/arch/x86/acpi/cpufreq/powernow.c
@@ -109,7 +109,7 @@ static int cf_check powernow_cpufreq_target(
             return 0;
     }
 
-    if (policy->shared_type == CPUFREQ_SHARED_TYPE_HW &&
+    if (policy->shared_type == XEN_PERF_SHARED_TYPE_HW &&
         likely(policy->cpu == smp_processor_id())) {
         transition_pstate(&next_perf_state);
         cpufreq_statistic_update(policy->cpu, perf->state, next_perf_state);
@@ -119,7 +119,7 @@ static int cf_check powernow_cpufreq_target(
 
         cpumask_and(&online_policy_cpus, policy->cpus, &cpu_online_map);
 
-        if (policy->shared_type == CPUFREQ_SHARED_TYPE_ALL ||
+        if (policy->shared_type == XEN_PERF_SHARED_TYPE_ALL ||
             unlikely(policy->cpu != smp_processor_id()))
             on_selected_cpus(&online_policy_cpus, transition_pstate,
                              &next_perf_state, 1);
@@ -220,8 +220,8 @@ static int cf_check powernow_cpufreq_cpu_init(struct cpufreq_policy *policy)
     info.perf = perf = data->acpi_data;
     policy->shared_type = perf->shared_type;
 
-    if (policy->shared_type == CPUFREQ_SHARED_TYPE_ALL ||
-        policy->shared_type == CPUFREQ_SHARED_TYPE_ANY) {
+    if (policy->shared_type == XEN_PERF_SHARED_TYPE_ALL ||
+        policy->shared_type == XEN_PERF_SHARED_TYPE_ANY) {
         cpumask_set_cpu(cpu, policy->cpus);
         if (cpumask_weight(policy->cpus) != 1) {
             printk(XENLOG_WARNING "Unsupported sharing type %d (%u CPUs)\n",
diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c
index a94520ee57..64ed8ab1d3 100644
--- a/xen/drivers/cpufreq/cpufreq.c
+++ b/xen/drivers/cpufreq/cpufreq.c
@@ -179,7 +179,7 @@ int cpufreq_add_cpu(unsigned int cpu)
     if (per_cpu(cpufreq_cpu_policy, cpu))
         return 0;
 
-    if (perf->shared_type == CPUFREQ_SHARED_TYPE_HW)
+    if (perf->shared_type == XEN_PERF_SHARED_TYPE_HW)
         hw_all = 1;
 
     dom = perf->domain_info.domain;
@@ -334,7 +334,7 @@ int cpufreq_del_cpu(unsigned int cpu)
     if (!per_cpu(cpufreq_cpu_policy, cpu))
         return 0;
 
-    if (perf->shared_type == CPUFREQ_SHARED_TYPE_HW)
+    if (perf->shared_type == XEN_PERF_SHARED_TYPE_HW)
         hw_all = 1;
 
     dom = perf->domain_info.domain;
@@ -504,9 +504,9 @@ int set_px_pminfo(uint32_t acpi_id, struct xen_processor_performance *dom0_px_in
     if ( dom0_px_info->flags & XEN_PX_PSD )
     {
         /* check domain coordination */
-        if (dom0_px_info->shared_type != CPUFREQ_SHARED_TYPE_ALL &&
-            dom0_px_info->shared_type != CPUFREQ_SHARED_TYPE_ANY &&
-            dom0_px_info->shared_type != CPUFREQ_SHARED_TYPE_HW)
+        if (dom0_px_info->shared_type != XEN_PERF_SHARED_TYPE_ALL &&
+            dom0_px_info->shared_type != XEN_PERF_SHARED_TYPE_ANY &&
+            dom0_px_info->shared_type != XEN_PERF_SHARED_TYPE_HW)
         {
             ret = -EINVAL;
             goto out;
diff --git a/xen/drivers/cpufreq/cpufreq_ondemand.c b/xen/drivers/cpufreq/cpufreq_ondemand.c
index fbcd14d6c3..ece90cb45c 100644
--- a/xen/drivers/cpufreq/cpufreq_ondemand.c
+++ b/xen/drivers/cpufreq/cpufreq_ondemand.c
@@ -195,7 +195,7 @@ static void dbs_timer_init(struct cpu_dbs_info_s *dbs_info)
     set_timer(&per_cpu(dbs_timer, dbs_info->cpu), NOW()+dbs_tuners_ins.sampling_rate);
 
     if ( processor_pminfo[dbs_info->cpu]->perf.shared_type
-            == CPUFREQ_SHARED_TYPE_HW )
+            == XEN_PERF_SHARED_TYPE_HW )
     {
         dbs_info->stoppable = 1;
     }
diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h
index e5e58c6c30..6e4dcc99c5 100644
--- a/xen/include/acpi/cpufreq/cpufreq.h
+++ b/xen/include/acpi/cpufreq/cpufreq.h
@@ -78,11 +78,6 @@ DECLARE_PER_CPU(struct cpufreq_policy *, cpufreq_cpu_policy);
 extern int __cpufreq_set_policy(struct cpufreq_policy *data,
                                 struct cpufreq_policy *policy);
 
-#define CPUFREQ_SHARED_TYPE_NONE (0) /* None */
-#define CPUFREQ_SHARED_TYPE_HW   (1) /* HW does needed coordination */
-#define CPUFREQ_SHARED_TYPE_ALL  (2) /* All dependent CPUs should set freq */
-#define CPUFREQ_SHARED_TYPE_ANY  (3) /* Freq can be set from any dependent CPU*/
-
 /******************** cpufreq transition notifiers *******************/
 
 struct cpufreq_freqs {
diff --git a/xen/include/public/platform.h b/xen/include/public/platform.h
index a4c0eb6224..0198d249ef 100644
--- a/xen/include/public/platform.h
+++ b/xen/include/public/platform.h
@@ -465,7 +465,11 @@ struct xen_processor_performance {
     uint32_t state_count;     /* total available performance states */
     XEN_GUEST_HANDLE(xen_processor_px_t) states;
     struct xen_psd_package domain_info;
-    uint32_t shared_type;     /* coordination type of this processor */
+    /* Coordination type of this processor */
+#define XEN_PERF_SHARED_TYPE_HW   1 /* HW does needed coordination */
+#define XEN_PERF_SHARED_TYPE_ALL  2 /* All dependent CPUs should set freq */
+#define XEN_PERF_SHARED_TYPE_ANY  3 /* Freq can be set from any dependent CPU */
+    uint32_t shared_type;
 };
 typedef struct xen_processor_performance xen_processor_performance_t;
 DEFINE_XEN_GUEST_HANDLE(xen_processor_performance_t);
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:22:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:22:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299986.511394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7UT-0001CY-T3; Wed, 06 Apr 2022 15:22:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299986.511394; Wed, 06 Apr 2022 15:22:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7UT-0001CR-Px; Wed, 06 Apr 2022 15:22:37 +0000
Received: by outflank-mailman (input) for mailman id 299986;
 Wed, 06 Apr 2022 15:22:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc7US-0001CL-MW
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:22:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 62b08c9c-b5bd-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 17:22:35 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-FOFylHJoPxWrGnvLNWK_vg-1; Wed, 06 Apr 2022 17:22:33 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8691.eurprd04.prod.outlook.com (2603:10a6:20b:42a::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Wed, 6 Apr
 2022 15:22:32 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 15:22:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62b08c9c-b5bd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649258555;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mAEZ2ZCi+s/8ZH/zDpYAq42Jpj14SURi5NhZc118tck=;
	b=QXzqdrEI77l/z9UfErMyhBZBiEfDFR20WjEHH5DWpR/nL74HR+ugx/43SFIZ3OIx84lqwQ
	FcVIr6IRLYVhpcmMXHTPuwF7vlXUOc9HbjFFa/ewl6Qcxxj8DaP+bEztcsGN59quljKhH7
	ZP3f4N+XH/VGet103E4iDvDqPbTyIxQ=
X-MC-Unique: FOFylHJoPxWrGnvLNWK_vg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JdXx0PaLduE6TBz2XbgF5JRsD2bQn9dQeabC9Nzzo1G5F6Kyw9tRwHLeJfUMagfP3r5r2l705GqlwZCDRCSXNYzcfIBN2bgvDWFwp6SlmqJ8lpfeRbqGAxZEuGsND4vAzLP2tSM7tk2YF/FjtBQaKykQeyDXa2i3D7o4ffc5mnhGy/Xm8LulxngpjzVrZT5d3vioeIIXpsuhLqikxIYzmZ4Uro7gZ0B+w3QKVcoQc66j4tUiAHCMjNOdznv1tzsfs6HfVWo+DwQ35cFfK0XQrMRv1Lc6oc35jdFrZWFEZtxT9HAsPd6YWioEqE6Txs+N03RqTWGLNC+jpIJMmeGJlQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mAEZ2ZCi+s/8ZH/zDpYAq42Jpj14SURi5NhZc118tck=;
 b=FBStutJ1zwHTC1yxzhWpRqdQZR507r0HbSX9ivXQMrcnUbczJEEUsdsG+2bqy6cAAsgyRW3Uz4C+fUcOMicTwL6kKybAQ6JAGNsmCSzjecJAvwmlWDCpnKUIFPzbDXA/Xo6nr812hNKfVhWAfzVPSIZQZvEi6CxAOEXefyPEjvW71Bq4JGha50Ftc1yg9/W93PPLmKk6d4orjMIP6XmlhkyBK+yOyzDPxlPySsuv8MGR7UrZu6fMnB5m4pU9ez5IBXDAa06TFofEL7NQ7oN22aSGSWwz84C7XH0AP83bH4FarkDJV2ORnf+hdTxUzPfAwVeyJBKxnUkhpy+9vZ3CcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <44883899-a696-31e1-c134-019de999d796@suse.com>
Date: Wed, 6 Apr 2022 17:22:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] SUPPORT.md: extend security support for hosts to 12 TiB
 of memory
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4c49e4cf-9d86-e630-a1bb-37afdf091c99@suse.com>
 <6ec0e3d9-374c-1caa-9889-f091dcf894e3@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6ec0e3d9-374c-1caa-9889-f091dcf894e3@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0046.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cd7fa217-ecd6-4b11-5745-08da17e14524
X-MS-TrafficTypeDiagnostic: AS8PR04MB8691:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8691800D775DC4352143E8F3B3E79@AS8PR04MB8691.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2AjCxSe/jXudQBsbcBZSJsTAZCRLk4PlbE6cbTPC7wxYcgWP54kh3UveeGwOk0KvbT+QwoxwT4x9gxyLiT5uWj4mfiwAJgrMeoR6dN95JBCbju1vuo1pvkd+te3UBfPbOSTleYeeBttHiF2ucwA0Rnz0H6nxn6m4fL4Hm+LYfxTCwYMlOztdsA3Omdzh4gPhIoYSJ7q59VV5t6FAvPXa7+Mna/Q/bfYXwU9XtehH7yKv7pKOLzXgkY3IPeweWDDXPB3PV7h7TidTbgVl6xqZOVlVl2xMTyOqcKJC5flhHd1Gcdb6NqnrvUUTh3fxuF5CqafixCSiKJb95ZOKBl34n4Y9oDNpstiudlDl7YWNJ/92WzwJiRdVXzA70WworpAwWH9x2gqRb0leRQ+NRR3O+bGw57dB+zY91xegyIbdRR+0a2SpPscVdMlWjy8KzB4RWM0a8QozpA0QJZWKzn35c1qgKSUJiD0om7vNvp7YZ2zKHHq4em5xN9TbcpZJb/xC68Xbg1nNI1SwFem9CjPJLBdlKc/awiFCEpDACVqOexfSYmHt1DH7QzTQCfewEspAgDySHzFMeR+UJ+974xl5jq6GTuev8W98gqMz4YrX3C10ospzMXHDd80sInA7GO2wqnmQ1F1sK5LAeiQTI1Rz0mVcjBjWubFeclrM98ibtKB0RRlfuZdZTp1nQx55CXK+0vSdBZHJdC20O8GSO4G4A4vUVpbEr2SGyNDEnbhT3BI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(36756003)(5660300002)(186003)(508600001)(54906003)(83380400001)(6916009)(31686004)(2616005)(316002)(2906002)(6506007)(66476007)(6666004)(53546011)(6512007)(31696002)(66556008)(26005)(66946007)(8936002)(15650500001)(8676002)(86362001)(38100700002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OUdvbmVrZWpCc1lySEkvYVVoRFBqOHFidk45eXkybklkNUNtdnpXakpVbmxD?=
 =?utf-8?B?VjJLd1hSa2V3TGZYcXBMUm0yU1ZPOVVXMEoxNmtvZ1JTY0ZKTzN1R3FpdEdL?=
 =?utf-8?B?TWYrYzBDTXZ5SFVoQmtFSW1jZEp4c3FzdjN2NW5sajZSejM2WWd0bU5IbnFp?=
 =?utf-8?B?Z0ozWWhvcGozMWhoMytRTUFoVXNIQlVibHU5YW1ZTTB3eEVaWDR0d0xZWTgw?=
 =?utf-8?B?MzdEcS9Ba1VUOG84WFpUdXJIb3c4NUlWWmdXNXY0QUJ6SllJMytFZVMrY0Vz?=
 =?utf-8?B?WGUzWStYMlFJMytBZVR2d1V6Q2hab3JvRHMxaTJVaFNkcEljTmdHZXV4ZE52?=
 =?utf-8?B?VXptZWdDdmdHdEdFVjNBVklCVjRmNXh4TTNJYkM4aVFWazYvd3p2RFB4bDZY?=
 =?utf-8?B?UzBhQ2ZFTnJyWDZNU2JsaXdnUzgyWW9VUzJ5RjR1UTlhNjM3bk5DeDFZSWQz?=
 =?utf-8?B?L2dJNGxSRkt1Z0hSZlJlVVN5RUhPdE8ydnFSd1oyN2xPNFJ3RFAwSXNyN2wv?=
 =?utf-8?B?WUJ1b2J3VERZeGZRY2MrTDBOMXRLYTZGUmhNTkJoeWN0MFlvTVZyMzlNallC?=
 =?utf-8?B?d21xVWxMd1lvOXRDbDhocHJWVjRwaDY2YURrcHA2UzgrSDhvcmVGVStLYWhX?=
 =?utf-8?B?THlaaFh6YVdwcTZKOGd5WHNISklvUlAzNElmRjlkUmFTS01IdHE4N1g5cXlj?=
 =?utf-8?B?TlVmWlJlZGRZUURYaHBBamF3QVA5T01ac2dTV2NQUVRoWFYybGRTdSsxbzJQ?=
 =?utf-8?B?YzVEZ0swYnFIKzl2R1NhdldVWmRidXVlcFkrSkpsOGhnMktWWmtUekRSYUhv?=
 =?utf-8?B?YTBuN3BieXlMc2x6WGxpTXE2K3hTeTl6elZUaVA4Z0NIclpxTDBwWHZVdlVM?=
 =?utf-8?B?VXZ0Y05wV3k2ZnVaSXhFQ3ZuU0MzcVpKYm1tQ1AzT1o2UVFOU25QUFVRaU55?=
 =?utf-8?B?bTVxWm9lTmhheDlodGZZRjNPbzB5emtBbmI3VjBmTFFiYm5DMTZEK3ltbEVG?=
 =?utf-8?B?dUJxeGNDWU5wNy9FREE3SStYcEkxTkFRV2w3STN0azlDcERSVXVxaDJVVVZK?=
 =?utf-8?B?UWlrTXNqdFl0R1BhSFFTNUYvZHorTXdWNVNsTy9wUXkya2s3VFg5cXk4TXNh?=
 =?utf-8?B?a0FaNkdrdGZCTGxHM0xHWG1FQklzdlJPVEdOV1ZVWDIxMzBhRGx0c0xobk9O?=
 =?utf-8?B?VEhTcmJUZStob1ZxaFF0WjM0UjlpcnBxZk9vQjdWKzhReEhTbW1CSDBxVHdJ?=
 =?utf-8?B?SVMvK3h2QjcxUHIrdWlwaHo4RVpyTTdCRUN4bXhBWERBbkd1ZDhETUJXZDNR?=
 =?utf-8?B?b0FkckVqVEpuNis0NXdhRTNwcHpoTk5BQVpyNy84YW5La1NwZTFETm52RDlG?=
 =?utf-8?B?cDFGSnJmQkl5ZFVMbVh3VGNmbi9qTy9MaG0rZXp4Y0lVK2ZjeUhibk01Q21p?=
 =?utf-8?B?ZnRXZ25aZmhyNTlzZGplUlp6Rm54WExVZTd5WjBRQmxZYnFYd1NPSGE0MVl3?=
 =?utf-8?B?REN0VkszeExudDVVRzAzM3piMUYrSUcyR3FBRlpaZStia3dGVnpoYlhTTGVs?=
 =?utf-8?B?c0d1Y3FsSEhabEhjMlBqRWhJdHd6Tlp6Q0poYWE1QkhoTWNXaWtnVHFYSmtT?=
 =?utf-8?B?WmZSLzRFWmwyTjU2WkFPaEFVUVUrcm5yWkdaQ2RFY0xmR1NGMHZuTGIydTlZ?=
 =?utf-8?B?QnhGcFdNS1M1Q09HemxSZGJJMUlyd0dITUJZaUl1a1Y4V053R1huOXpUOGFS?=
 =?utf-8?B?cjcxMjdTcFJBZDVFakdFL3FMMkRQOHluNUJ6UDVhM2lha1hlaEJZTHh0ZzNj?=
 =?utf-8?B?OVV6a1hDMjF5YmQyRlN3QmJZRUtqYVdDWmF4VjhESmxpaEVBZXB0QzBQTUFp?=
 =?utf-8?B?NmpiQTQxT0Jndng5QW1zZnBIMk85ZktlVmhyTTl6OEpQeW9URmFWYS9ydDdZ?=
 =?utf-8?B?ZHhGbGo3cUhSWjRzUzNSVXNraVFvdGg0WWVtTFJpUmQ5TVJtSFpJbEpjMlVx?=
 =?utf-8?B?ZGpKTzlid0dCVm1mM1Fhakp3Qmo1RU1HeGlReU92czNNRzF5cHJIWVBROEx6?=
 =?utf-8?B?QTNVT1FhUGs2UlNIVHRqMnhpSWQ5ZHpCbTROZVZnU0VGb3hlQTVyMEFDaE5B?=
 =?utf-8?B?VTZCVlVlTGN6MmJsZjlqNWkyS21pU3YwOFlZbzZLL1poTk4remdRZUZ5OGJ4?=
 =?utf-8?B?dlVSbysyTDVmamVLMW82WU9uOVZ5aWZuK3dsaXB4bmU5cWQ1Qm1laDRvM2pq?=
 =?utf-8?B?NzY2SUFNamttcmlDSWRqaFhwRUVPYmREOTNoMU5HTHNvUmhRQ2pXNDlRWXNi?=
 =?utf-8?B?TWl4RTdmQ1kzeFp2SWU5UjRLT1Q2eE9jaVBNRGd3ZCtVd0l0U0xBdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd7fa217-ecd6-4b11-5745-08da17e14524
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:22:32.2842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oRsolWgFMldERDSHs4ZHE1hvV3FYhCd1LXSIqG/lCBqfgQTCwr8Dcw9TXcKDMbHH7QKId6kCkMG1A5IWmjGQ0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8691

On 06.04.2022 17:15, Julien Grall wrote:
> On 06/04/2022 15:44, Jan Beulich wrote:
>> c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very
>> much memory"), as a result of XSA-385, restricted security support to
>> 8 TiB of host memory. Extend this to 12 TiB, putting in place a guest
>> restriction to 8 TiB in exchange.
> 
> And this is even without CONFIG_BIGMEM?

Yes. BIGMEM only matters when memory extends past the 16 TiB boundary
(i.e. when frame numbers with ore than 32 significant bits appear).

>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra
>>   
>>   ### Physical Memory
>>   
>> -    Status: Supported up to 8 TiB
>> +    Status: Supported up to 12 TiB
> 
> I am afraid this limit is going to be too high for Arm. Even the 
> previous one was technically incorrect. From [1], it should be:
>    - 5TB for arm64
>    - 16GB for arm32

May I ask that you submit a patch correcting this, and I'll rebase
on top of that? I can't really fit such an adjustment under the
umbrella of the title and purpose of this change.

>> @@ -121,6 +121,14 @@ ARM only has one guest type at the momen
>>   
>>       Status: Supported
>>   
>> +## Guest Limits
>> +
>> +### Memory
>> +
>> +    Status: Supported up to 8 TiB
> 
> For Arm, this should be limited to 1TB for arm64 and 16GB for arm32.

Sure, will do.

>> +
>> +Guests with more memory are supported, but not security supported.
> 
> d->max_pages is a 32-bit value. So Xen can effectively only support up 
> to 16TB of memory. AFAICT, it would require quite a bit rework to lift 
> that limit. So I think it would be better to spell out the upper limit.

Same here.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:24:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:24:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299989.511404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7Vr-0001lt-7a; Wed, 06 Apr 2022 15:24:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299989.511404; Wed, 06 Apr 2022 15:24:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7Vr-0001lm-4i; Wed, 06 Apr 2022 15:24:03 +0000
Received: by outflank-mailman (input) for mailman id 299989;
 Wed, 06 Apr 2022 15:24:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nc7Vp-0001lY-1g
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:24:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc7Vm-00073L-E5; Wed, 06 Apr 2022 15:23:58 +0000
Received: from [54.239.6.190] (helo=[192.168.16.200])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nc7Vm-0008PE-7f; Wed, 06 Apr 2022 15:23:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=BZxfYUHJXhRRfZAdC7ye6dY7Kdzx9CyK8T9yu+2Lti8=; b=TKuQNEBZ8LlA447ueVsfyv52BI
	J8gMu3kAxgFyA546nW5VKV1j1J3+NH/+9YRnJ2zr1MYx8z2Grrl86Hn59kuBbbkdeONTCKhFoSH6q
	EYTSNETNBbZVuP/HNFjMaIka9MLebvorDDFkyJhOewto9RAYb483x/WM7sBAvoF5Pwyk=;
Message-ID: <26ca3b75-6bd2-008f-b393-45ba11f3d0ac@xen.org>
Date: Wed, 6 Apr 2022 16:23:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] SUPPORT.md: extend security support for hosts to 12 TiB
 of memory
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4c49e4cf-9d86-e630-a1bb-37afdf091c99@suse.com>
 <6ec0e3d9-374c-1caa-9889-f091dcf894e3@xen.org>
 <44883899-a696-31e1-c134-019de999d796@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <44883899-a696-31e1-c134-019de999d796@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 06/04/2022 16:22, Jan Beulich wrote:
> On 06.04.2022 17:15, Julien Grall wrote:
>> On 06/04/2022 15:44, Jan Beulich wrote:
>>> c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very
>>> much memory"), as a result of XSA-385, restricted security support to
>>> 8 TiB of host memory. Extend this to 12 TiB, putting in place a guest
>>> restriction to 8 TiB in exchange.
>>
>> And this is even without CONFIG_BIGMEM?
> 
> Yes. BIGMEM only matters when memory extends past the 16 TiB boundary
> (i.e. when frame numbers with ore than 32 significant bits appear).

Thanks for the confirmation!

> 
>>> --- a/SUPPORT.md
>>> +++ b/SUPPORT.md
>>> @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra
>>>    
>>>    ### Physical Memory
>>>    
>>> -    Status: Supported up to 8 TiB
>>> +    Status: Supported up to 12 TiB
>>
>> I am afraid this limit is going to be too high for Arm. Even the
>> previous one was technically incorrect. From [1], it should be:
>>     - 5TB for arm64
>>     - 16GB for arm32
> 
> May I ask that you submit a patch correcting this, and I'll rebase
> on top of that? I can't really fit such an adjustment under the
> umbrella of the title and purpose of this change.

Sure. I will submit one soon.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:24:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:24:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299991.511416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7W7-0002Ay-Hq; Wed, 06 Apr 2022 15:24:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299991.511416; Wed, 06 Apr 2022 15:24:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7W7-0002Aq-Di; Wed, 06 Apr 2022 15:24:19 +0000
Received: by outflank-mailman (input) for mailman id 299991;
 Wed, 06 Apr 2022 15:24:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vAr8=UQ=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1nc7W5-00026l-Gq
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:24:18 +0000
Received: from sonic317-20.consmr.mail.gq1.yahoo.com
 (sonic317-20.consmr.mail.gq1.yahoo.com [98.137.66.146])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9cd18b02-b5bd-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 17:24:14 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic317.consmr.mail.gq1.yahoo.com with HTTP; Wed, 6 Apr 2022 15:24:11 +0000
Received: by hermes--canary-production-bf1-665cdb9985-x6p65 (VZM Hermes SMTP
 Server) with ESMTPA ID dbc7966b12aa1bccbfd1bd342ac80ca0; 
 Wed, 06 Apr 2022 15:24:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cd18b02-b5bd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1649258651; bh=glmZpG8Ksvn68rP5ygnxSxOm/UwqtUdoi82wz9JmjkM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=c9MVY86CQHcPjUrhRIOdvBk3I93EehcKPbIVER86MgeC/OfSaHoVZ8QvvH8MzdQrf6rpQNa9TiYgpAqRdhRXElqGPMUB5xbdN2aGy3yBqVphEm9vjUb3BiHCK+s3RWDFt/A1V6byQ0Z20iaL2o5dnVRHu+SL9qGM4mG/hCnFQ/Fvlw5uTGIwbaR3toa6beTtfly8Qe83VMYdUaRvVsGjsYuyR8RTEbG3LNjnZQ5LOq20C8BPDI1DOx2GEMuJ4huRjr/a9B6dUK239pnL/aTY8yH3Nh83dVnPs9aBKVWI2o7sbY+ioNFsX9IJxotshqCagQ8B3rR5pkEmOPREPJCcDw==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649258651; bh=5wdeMl2cjt49a2re0Xx7deHyq1SSaz9GTAjsbOvzetR=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=qURQQI9N9Usw6hI5Kf+z3zSZrDEVfWaVFNsq/G/jXfXtOvEjbbeYC+gMFsjxXSXjL0Wpg8CiWIOQt+M4cCGHpJI6itWpRJmcKyq30zeCxYyGOx8H8VJJYoEMegNMAfZ+Tt9Asnf5wFgBvlZoRtjaG7izeAIwC8njVJMeLXwC8ax7v1i3Ej5SN57OXEXrnPDvXk1OCK8MxiQiXNUjwWymjzxPJfAg060wvvUE39TCxuiRfDxUA1/HqeXAJNAoT3U8kW6k088RabL/i2hjpXLtouGZH9e0beyO5vpiUKYCaih2iSLzQBhlG06yuFM/gFOt1/bmtmkYiutkUHpO3ZLV8A==
X-YMail-OSG: X6T6.AIVM1mDGsrUy.BJawLMRFRPCxqLU5XHkbXHvbU4ohkBwuan10rYqKJ.lWw
 epxT5Ur9_qJr8fhCh6mUUnYNPFhO8eifO9eb1g4l_4B9McfKIV65ARvQ4oIfkt6XdIwKTSNb9x1I
 LXUqpyTligtZJpsBkvRFf1DXVew0GzOJ3joOWxiCW7QEpO.vcAbbIoziXCenlrTx45I3txeSMj_I
 teLoSd_hXZzQUepfVkCxKgqDhKCeLxwjiyfhX9c4MhZwy2.UxLgY5iIeOqle38ilWIabQiMOxP3Q
 Hsk.AmTNCyCONeO135AF9HF_8gXK.SWNX4aZVQ4quu5XZLVVEVVKqk0KwiJmc7mhk7bOkXyP.vVX
 TENdS5IAe9lmvmxd6Z.ksLGe.EEeIrqKSeq.XxAvrryIjlmEpw5XpkbJrzYYZThqi09YkzB75PlO
 xYJRAlP7GKKkrM1SUuB9YASwnUyGOE2.hdHZYGKCV4Ew4adj2m7BSPTsG2nbM4wpd9IN3KvNULyr
 izLHrUc1FgGZC3ThpwJrkNtFD5CmPTBP2S0qgLtQ57Ec6Yk0eD45Sk53V9OILZNZBzLJxv99abgX
 7b0rLDKYiG0uKbgjFpsYRUh6K7A6BX8LnTtxBhRZUeY829ZIQ0FpzqKYhDPtG6r5KEQB0n9ilcPc
 O6POWpunkCMqeebY_ksKCHdbCavEceD63EkqOyW..z4mDDe.hZ0Rp5rCoi4dyhbNTep25aAJ0dmB
 0Xl7nDDdF4FZgLKUkh4HtxQbQXuDviMUslJJDTiV9_lPi1EOtmMHhonlMOJIvYkqWodabfHv49jR
 WII9YCJTcJKcCkVeoQNkwTqbRhOhPWcYwyQOrjtAYg5A9DMqsgw1cEOnp6bxXxLMRQdhzLgUWms6
 .NCLfSpdHd8RFe3oSvanqaN9dKYC.kFX6XL34uz2xl0hOR48rGTf_q8dzcAHbCweIHre6IANHnSQ
 u9Qsa8dHVjDHfjHTYJhEdJyLg14rLuMPal0WueGXMNlESa0TDMZLiZeU671HWlEsnGfpZ_Cy.9Rh
 QGfCRVxaX8alJvSgporv8elABTv8PicMlQUoAJ7UEnGCijq6E3KJ.cS67wpuD2LCeKyBtxpJsVKm
 BoMw1S76cgcgVPL7QHra80jsAZI7y0Pzyrgd2x0bbXVVBfm2GKFbgc.0rkPca5zXeg.fAbobpZhQ
 r4SCtjsvg3klAUeqUTG.fdh1IRE_ukVhXEkgsj2cBZfstyR4piY.vfxoP3YE7MCAlRZI_wqJ65ZM
 4h.7202wOkQQMYwsy_tpTkIUp4IuNYSNYyrT7gyftdV0JdMvvMuF3ZfJsR42uczZwxOw9V6WYL.0
 FUjDJggt0DvRJP1qS7dU7pEpZqcoXlERP5c4CWyslBhgWAEfVyVWJaY45tZeq1VfBh4wdzYBF6Qg
 7AKq8IiqxBrwWvYFFf_in3i4xvKNpdn6dVZi068XpglCSgZNkhQ9Ew7_a7lwsnhUO8YsvjSaMnc7
 NIAB24qPSVLQROnh9IzhWmgSjkEaGquWk3_ib2y0cIPhM2L3FCOnYi5iwqF54C.E1Q2rQaNn0LzZ
 Z09cxt_k9VfSypaVkOiqSbDacvgd97olf8DbApsGydCthnmY6D7P8fdBDnGtbzm_V9qOEBIyWkYe
 xNmu2DCOrXV598PBnZohSliTpVfvVL5bcxIre3Y5ftJf_LyWZ8YEhmnmqFKK8DFd1sDxiL8XduFS
 Nvsnqyrfn_7hBVW06BMZoc6S7bSsMn9zZFVo.je7TO8DvZvh2WarZS.9NU35wSOrGOfWv22Nkq_N
 zkrhgqhA8ObodKtnwKT2nB9C4DfqHqzZx2NzNwBsZxZs_Ry01agcYBRd6oJN5TWp.P.jQF2O5WR4
 g_nQBf4SzieqhzAoqyrKEhdMXCGLGBpQTeoaWlQpRY0KGcdXniFSPd4eDVtLC5SJLmqL33ztuDry
 mi1218tO5fCUo5n8Wx0XvVk8XW0s5zlj3QzTJWEeKujChd5rST8.idONTT0byAOKZtLJ3UaNw.cL
 UreVjePsUR75rBozK1QYkFav72E.z3HPc2IwnY68cq8lqbeosvBrht1An5RyHBwF.Lemzv.wDdSO
 f5.K3FJGuE.52hmxSwdUFROMk4Hj2Re.KHjLv0GvVt7snFsA4TAhYuqtoboNvZrIAyPhh8IUZKtV
 iM6_9fUijCU5D7G7vBJ6QBOOC0eU1EUnZ5M44FMqALk7pjIwg4EdQLAWkrIDFK9K6ECmSJGiYbLC
 cfR7zEovEf46R
X-Sonic-MF: <brchuckz@aim.com>
Message-ID: <db7f117c-f2e3-b0b9-81e3-edeb7a57c39a@netscape.net>
Date: Wed, 6 Apr 2022 11:24:06 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access
 to Intel IGD opregion
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Jan Beulich <jbeulich@suse.com>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz.ref@netscape.net>
 <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz@netscape.net>
 <78ce5809-8df4-c94e-4313-fffb1b86b771@suse.com>
 <CAKf6xpsN+uJ=AyxtrnOrQrynFL=dwC=DdT7DHnK=wx9UFtdUDQ@mail.gmail.com>
 <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net>
 <5d14eeb8-038f-e99a-31b8-f6b3b562c2c4@netscape.net>
 <CAKf6xpsNsYM=fHb4DwiLmsH+Nz+0UF5RvjWr=GeYo5d+6Rmi_Q@mail.gmail.com>
From: Chuck Zmudzinski <brchuckz@netscape.net>
In-Reply-To: <CAKf6xpsNsYM=fHb4DwiLmsH+Nz+0UF5RvjWr=GeYo5d+6Rmi_Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 5788

On 4/6/22 9:10 AM, Jason Andryuk wrote:
> On Tue, Apr 5, 2022 at 9:31 PM Chuck Zmudzinski <brchuckz@netscape.net> wrote:
>> Correction (sorry for the confusion):
>>
>> I didn't know I needed to replace more than just a
>> re-built i915.ko module to enable the patch
>> for testing. When I updated the entire Debian kernel
>> package including all the modules and the kernel
>> image with the patched kernel package, it made
>> quite a difference.
>>
>> With Jason's patch, the three call traces just became a
>> much shorter error message:
>>
>> Apr 05 20:46:18 debian kernel: xen: --> pirq=16 -> irq=24 (gsi=24)
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: [drm] VT-d active for
>> gfx access
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: vgaarb: deactivate vga
>> console
>> Apr 05 20:46:18 debian kernel: Console: switching to colour dummy device
>> 80x25
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: [drm] DMAR active,
>> disabling use of stolen memory
>> Apr 05 20:46:18 debian kernel: resource sanity check: requesting [mem
>> 0xffffffff-0x100001ffe], which spans more than Reserved [mem
>> 0xfdfff000-0xffffffff]
>> Apr 05 20:46:18 debian kernel: caller memremap+0xeb/0x1c0 mapping
>> multiple BARs
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: Device initialization
>> failed (-22)
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: Please file a bug on
>> drm/i915; see
>> https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs
>> for details.
>> Apr 05 20:46:18 debian kernel: i915: probe of 0000:00:02.0 failed with
>> error -22
>> --------------------- End of Kernel Error Log ----------------------
>>
>> So I think the patch does propagate the error up the
>> stack and bails out before producing the Call traces,
> Thanks for re-testing.
>
>> and...
>>
>> I even had output after booting - the gdm3 Gnome display
>> manager login page displayed, but when I tried to login to
>> the Gnome desktop, the screen went dark and I could
>> not even login to the headless Xen Dom0 control domain
>> via ssh after that and I just used the reset button on the
>> machine to reboot it, so the patch causes some trouble
>> with the Dom0 when the guest cannot access the
>> opregion. The patch works fine when the guest can
>> access the opregion and in that case I was able to
>> login to the Gnome session, but it caused quite a bit of
>> trouble and apparently crashed the Dom0 or at
>> least caused networking in the Dom0 to stop working
>> when I tried to login to the Gnome session in the
>> guest for the case when the guest cannot access
>> the opregion. So I would not recommend Jason's
>> patch as is for the Linux kernel. The main reason
>> is that it looks like it is working at first with a
>> login screen displayed, but when a user tries to login,
>> the whole system crashes.
> I'm a little surprised you still had output from the VM & display with
> the i915 driver not binding.  I guess Linux fell back to another VGA
> or Framebuffer driver for the display.
>
> However, locking up the host isn't good.  You didn't happen to catch
> any Xen or dom0 output when that happened?
>
> Regards,
> Jason

I just looked at Dom0's systemd journal and it did not
capture anything. The six minute gap between
Apr 05 20:46 and Apr 05 20:52 which is when I
rebooted Dom0 after the crash is when bad things
happened:

Apr 05 20:46:01 Dom0 kernel: pciback 0000:00:1b.0: xen_pciback: vpci: 
assign to virtual slot 0
Apr 05 20:46:01 Dom0 kernel: pciback 0000:00:1b.0: registering for 18
Apr 05 20:46:01 Dom0 kernel: pciback 0000:00:14.0: xen_pciback: vpci: 
assign to virtual slot 1
Apr 05 20:46:01 Dom0 kernel: pciback 0000:00:14.0: registering for 18
Apr 05 20:46:01 Dom0 kernel: pciback 0000:00:02.0: xen_pciback: vpci: 
assign to virtual slot 2
Apr 05 20:46:01 Dom0 kernel: pciback 0000:00:02.0: registering for 18
Apr 05 20:46:01 Dom0 sudo[9639]: pam_unix(sudo:session): session closed 
for user root
Apr 05 20:46:13 Dom0 sshd[9541]: Received disconnect from <redacted> 
port 60294:11: disconnected by user
Apr 05 20:46:13 Dom0 sshd[9541]: Disconnected from user <redacted> 
<redacted> port 60294
Apr 05 20:46:13 Dom0 sshd[9521]: pam_unix(sshd:session): session closed 
for user <redacted>
Apr 05 20:46:13 Dom0 systemd-logind[497]: Session 27 logged out. Waiting 
for processes to exit.
Apr 05 20:46:17 Dom0 kernel: xen-blkback: backend/vbd/18/51712: using 4 
queues, protocol 1 (x86_64-abi) persistent grants
Apr 05 20:46:17 Dom0 kernel: xen-blkback: backend/vbd/18/51728: using 4 
queues, protocol 1 (x86_64-abi) persistent grants
Apr 05 20:46:17 Dom0 kernel: vif vif-18-0 vif18.0: Guest Rx ready
Apr 05 20:46:17 Dom0 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): vif18.0: 
link becomes ready
Apr 05 20:46:19 Dom0 dhcpd[9852]: DHCPDISCOVER from <redacted> via vif18.0
Apr 05 20:46:19 Dom0 dhcpd[9852]: DHCPOFFER on <redacted> to <redacted> 
via vif18.0
Apr 05 20:46:19 Dom0 dhcpd[9852]: DHCPREQUEST for <redacted> 
(<redacted>) from <redacted> via vif18.0
Apr 05 20:46:19 Dom0 dhcpd[9852]: DHCPACK on <redacted> to <redacted> 
via vif18.0
Apr 05 20:52:34 Dom0 kernel: Linux version 5.16.0-6-amd64 
(debian-kernel@lists.debian.org) (gcc-11 (Debian 11.2.0-19) 11.2.0, GNU 
ld (GNU Binutils for Debian) 2.38) #1 SMP PREEMPT Debian 5.16.18-1 
(2022-03-29)
Apr 05 20:52:34 Dom0 kernel: Command line: placeholder 
root=/dev/mapper/systems-unstable ro reboot=bios quiet console=hvc0

I would probably need to connect Dom0 to a serial
console to capture something from Dom0 or Xen.
I have done that in the past using a serial cable
connected to a Windows 8 laptop using a usb to
serial adapter I have but last time I tried it the usb
to serial adapter did not work, I think because of
the upgrade of the laptop to Windows 10.

Regards,

Chuck


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:31:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:31:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.299998.511427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7d7-0003vb-Az; Wed, 06 Apr 2022 15:31:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 299998.511427; Wed, 06 Apr 2022 15:31:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7d7-0003vU-7y; Wed, 06 Apr 2022 15:31:33 +0000
Received: by outflank-mailman (input) for mailman id 299998;
 Wed, 06 Apr 2022 15:31:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc7d6-0003vO-6q
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:31:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a2105ff0-b5be-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 17:31:31 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-4931haeeNx-4OmVM12yX3w-1; Wed, 06 Apr 2022 17:31:26 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5191.eurprd04.prod.outlook.com (2603:10a6:20b:1::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 15:31:25 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 15:31:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2105ff0-b5be-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649259090;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ny27UbdDTxOh416l+xnnH3q4ps1yqQg+XobhjMdOicM=;
	b=LD5Jp9+Y9G5hp/MP7SaH6SadyoUAfhIUjaXJ3ZyPeHD0ZfNLtrssekRABOrk74Xf4t86sl
	tGGuE/OSqa2QyamxDPJTO73CkcNChJOSV7YumdmbkRsLuOiX0wjpDlRGeS5JnCLoq9RtCf
	7B29V1Yqim9urUySjqsm7iKyv21opgY=
X-MC-Unique: 4931haeeNx-4OmVM12yX3w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Azttpu6zgY9wXy9kSRBAV34A4ClI4Dj9iof7q1GboaJigWwC0yZaL65Y478VDXXOY3QvGsW3JFGmigMZ7xVaXNyoKN83Dly0QNrVWihJEWmiLcqdXbr4uYCYRobJuD9y2r3lC0ZTDOrFsQuXbm/OnkI8IDxd6HheI2Hd2t4r3lVStJsxsrA8BB0yYWbterzj+Vjp7oZL5sxitPjbOPT54drs6f206TEEqhAEBYz979f9/W5MM3hLuojDRSgCB20+VrP+nMVGk4O28WCq1sQFCk88DdavOrBep2qFPiOR94PV+lhm6oP/PZbGsvkzVHgog9qSil5yuRw50BL0+Yq5ww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NQdpJ0VMc9SRfY2HnOWzylGnWbVgiwJi8Dx+yrakyaQ=;
 b=KfUAKDJ07GSCiSPDCTDGAyT28yUZAr9x0El8tZLkCopEVBhI5Cw9cEZPfncVEmHS0QzQ7yiThgSa3sZIZXTvaF55EHqFPE1UY+F9YjrcIvswKHRTkAcUKmGr9XkrWWmlwc/og8KrwyRAvqCzDKa8A786/c626WYZT2OoWt8dqSCjDvt/dOQrYBp/KXsfGHGyKfhtLbDyPNkL0C9jKWTp9aCXlQhgF8E/VE9iIT3CTLCclMssVN0FgSZrhDONnubj/cqtV8NegE2/u9Fxx7XoKS/4y5TLY+YJSO+sBDMvutkfq9ijv6vSZ8EJGoXQnite0ynVrm/2kPsV90RY7oWHAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3ebd90da-f7f7-fb14-4809-25202f200d77@suse.com>
Date: Wed, 6 Apr 2022 17:31:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] platform/cpufreq: add public defines for
 CPUFREQ_SHARED_TYPE_
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220406151645.32827-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220406151645.32827-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0003.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 042586b1-b32b-479c-95a0-08da17e282d2
X-MS-TrafficTypeDiagnostic: AM6PR04MB5191:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB51916FBB3E2DEEB1DA9D1781B3E79@AM6PR04MB5191.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+zWvWgiGGC1pk0yVW4V+GyJ/88w9/JYD+05AiQTl9BIGeqqWqtOyMSLEqSdDJqIbdogRN1+2HGpNebp3i0NEwHMEZPGql8Mr/exKCLE74w27pSNqw6xgZRJCVqYfpfvNsgghcXrE9XG90r1AJ3tA2xFp+ce9T5sVSJ3fg+8SKTGBp2aU0Bcs8v3kXsWSpb0y8wcRyxoNyep5MYtDontHkO5if97CGaxieyWN2UY/R0wLc0QqR7N9NTp8M7E+b29EHbWv32dDvflAbiLTPqCfmNockrvfQ9focZG+FZSqaC4c6U14WIdTLeL0Wpt8tbNG8O0hBlBd8viMfp82fqxyD5rg/O+RKD8icyT1AtHiXNnLHBbVPgm9VvNfAqA9kyQrbSJwVU4vnAhPC6tVhjvZWErtZkU00UIELl9LMPYTITAR/cA21wUXD+7gL4cOqiT4nwjKYP6m2dWnFD7rpGgkq22Ukk7vMrLZrWxhOmoWNsT+54+saEnNj6QKZs319i2OZKBbc+8n5lNF/5Nh75WC+bewcRzVRqGFcL7IY1Zn6z1gUbYNaAmRgNrYAhB2dem9XF5qLyaBbfvxtbrugLoXr8TK1kN9ne4j3coAGeXew9i2NtpjQGuCSlRs5bj/Nlg3n+OkFOl0aul7XlUw6GiGN3TwvRu5iU4ekjrnRtdAlB5P2+TSy5N2v2Fr09j6RXiNzT+/YoDZmzbcMsNGbM/1ee6bgbDXgRkdlhVIC2tbgkg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66476007)(66946007)(5660300002)(6666004)(8676002)(2616005)(6512007)(6506007)(4326008)(38100700002)(53546011)(508600001)(83380400001)(86362001)(31696002)(316002)(26005)(186003)(6486002)(36756003)(6916009)(31686004)(54906003)(8936002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ehyWHwt2xy0lPe1B3UkcKqsK6H0YRSYo1cKLAI8hboCCi7OWRl7Fi40R+1cx?=
 =?us-ascii?Q?4ru16l2LCsYZw0L6guh0BIaOCBrhbdt7uR1gOZGiuB9Uh+FQVaiXdaIj13eo?=
 =?us-ascii?Q?FcFcUZ9aK8dZPEUwTTDbycK2+XM5P3ASCEeot1f6Wf+63ylwOTon80tdJXXh?=
 =?us-ascii?Q?WiF7CiknmGOcq0P/qNof6Z6ujNchSxxzoDD3vcyPi6Y+RRBNRioanSyX/e/o?=
 =?us-ascii?Q?1X1oZ1NxLzDHV+H3xb0bTaTMqW6VbJKCHCP5NOyKJ8V3OhA/EtJdhGYPtRiA?=
 =?us-ascii?Q?2N8B3Po0HwNFMtmmUnKdSK5xlq3I7ig6/iK8wffa2H5szH9Qw60jPJ+Ig6bj?=
 =?us-ascii?Q?g4rtBS1QYK7XPWjRPjmT7rCKagPcv88y1qDKBUnqkBAo3SXS7YQIChgGCExA?=
 =?us-ascii?Q?NE/yFs7ZyV6f04OwSXz7ZFAel/tXqs7GjEL1Ik/fiGqvtniEVj7kzzM3Lhkd?=
 =?us-ascii?Q?DODhk6lAGjxmvRMNy+VVngw2kik46NhOBASOIOqsGxfp2TM8zwEkVNPeolHg?=
 =?us-ascii?Q?OYjgiea8FsiQsQ03Jtz2PYdMCQ/idL/lIC8hcfd+1efZhO/pX8cxNNhE3jEo?=
 =?us-ascii?Q?tQ0DUOb92DnMVtEmnlndKLTrUQX2TrNO++CPw6roYyxZi4fFmgZuRPLA1D8c?=
 =?us-ascii?Q?IvrcZPmdbuDsLMq8zQEUClUJLrRZUTaL13do23akDfJ9MAIRLi6W6qABTjwY?=
 =?us-ascii?Q?UMFI/LtOpBlPnr0VJcaOPpLnPrtVcSrCmXmYRYlK62NmZnwoCWJyfDrEqGAw?=
 =?us-ascii?Q?i7aazmoVLJPtGOOYbFm+ZsxUOfvFhFt6xuy8zdbXigVa4MJJkxj0EB5rWMpy?=
 =?us-ascii?Q?2K8zLepfCg422HqYsLm02f7+jraF+OyLjhpR8EagLPPjRHhP85Ogtmeq15uQ?=
 =?us-ascii?Q?nVrbIvwTLxdfAkhFk2WR/6xYEDfMUh5iaPoJazfeNarRCDtUqFBUeNYCOzyj?=
 =?us-ascii?Q?4UofWNJCtRR+/1wr/ef+Ezed7b3/wPPtrqVih9epbAMAGeyjz8SbQhBRQYMG?=
 =?us-ascii?Q?IAuqFRPuIN8MW2QZjzEr+/pXNZlHJ41fAw3NwIfxIV4DRTlr9xujE1XehdX0?=
 =?us-ascii?Q?U3NBWFwTYtBJOmtX9gyT318XFaJX8m6/cFCDtJxsPuObeq/I1vSU9SxZE08p?=
 =?us-ascii?Q?0hWugUtM78jrc+iXNmMGXKYuDQXnKhgyAB5R7Bcfmzxw8sbxgBHdi/GOYDcy?=
 =?us-ascii?Q?/DWpmLRjmIunIJw8lp/pW9C7O5TRXjSUNLLlgGUxvyltpmnEbQxqdu+KZMLR?=
 =?us-ascii?Q?tWvKb2xrNar2ifBNoGaeOztCG4I1quFzyyn59JYAZGgoKL9h5D/g60SgMv8v?=
 =?us-ascii?Q?rYKqLXpZJnJToP7jQUvnWQL6I40jR3b7op+rv/Km4ZTA/A5AVYTZcP3ePMRE?=
 =?us-ascii?Q?URDezQJVsxn0lFyFP0DmibAHsM/9yGCWtXP7ZTwIgMQ6ku6RbmB55k9BnXan?=
 =?us-ascii?Q?4aWEBbiLFYosAiT8gztanHaNbU32qJQWbDlP5whVTRfw2kJRKlyBDeq0Nen4?=
 =?us-ascii?Q?xBodCi5ok5Y/PzCzg6bQTSLkkjK2y39UVsHJF3GugoUnAClCVIJwKi4PAndZ?=
 =?us-ascii?Q?KyfRybVR2ULkywzQ/9HaDcrSLEVLQsKPIX5pLFl85vAvD+SIbmjLq7ScSTyF?=
 =?us-ascii?Q?HMdgaumKCVlWlKwRWf9GEpCdNYrGVfsyCCwE6w78RGezU3XJxg1dUUeaHpa8?=
 =?us-ascii?Q?D21JUrihJKmEYzSMCYmueG46iXRI44Wm4qVGkqnqUKB4C3LMaRPHDtETZM50?=
 =?us-ascii?Q?yAAhEZps6g=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 042586b1-b32b-479c-95a0-08da17e282d2
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:31:25.2326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YEN2uFpKUhQCe4MsumTF83ekq7FIbVerK0evakr1WETjiF/YMpOGK7OnwP4yk0947dMvKx4tNCkcp9pPAsjwYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5191

On 06.04.2022 17:16, Roger Pau Monne wrote:
> The values set in the shared_type field of xen_processor_performance
> have so far relied on Xen and Linux having the same
> CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
> public interface.
>=20
> Formalize by adding the defines for the allowed values in the public
> header, while renaming them to use the XEN_PERF_SHARED_TYPE_ prefix
> for clarity.
>=20
> Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> ---
> I wonder if we want to keep the CPUFREQ_SHARED_TYPE_ defines for
> internal usage (and define them based on XEN_PERF_SHARED_TYPE_) in
> case we need to pick up changes from Linux.

I think that would be desirable, also to limit code churn by this change.

> --- a/xen/include/public/platform.h
> +++ b/xen/include/public/platform.h
> @@ -465,7 +465,11 @@ struct xen_processor_performance {
>      uint32_t state_count;     /* total available performance states */
>      XEN_GUEST_HANDLE(xen_processor_px_t) states;
>      struct xen_psd_package domain_info;
> -    uint32_t shared_type;     /* coordination type of this processor */
> +    /* Coordination type of this processor */
> +#define XEN_PERF_SHARED_TYPE_HW   1 /* HW does needed coordination */
> +#define XEN_PERF_SHARED_TYPE_ALL  2 /* All dependent CPUs should set fre=
q */
> +#define XEN_PERF_SHARED_TYPE_ANY  3 /* Freq can be set from any dependen=
t CPU */

While the names may then become a little long, I think it would be
relevant to have "processor" (or maybe "CPU") in the names, to have
a better match with struct xen_processor_performance. Also I'm not
sure you want to define these inside the struct - they're
supposedly suitable for Px, Cx, and Tx aiui (just like the underlying
ACPI constants are).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:35:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:35:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300003.511438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7h3-0004av-UW; Wed, 06 Apr 2022 15:35:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300003.511438; Wed, 06 Apr 2022 15:35:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7h3-0004ao-RL; Wed, 06 Apr 2022 15:35:37 +0000
Received: by outflank-mailman (input) for mailman id 300003;
 Wed, 06 Apr 2022 15:35:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc7h2-0004ai-Ef
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:35:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33791365-b5bf-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 17:35:35 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-1blXUoNnOiuUJmf20AcUfA-1; Wed, 06 Apr 2022 17:35:33 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3776.eurprd04.prod.outlook.com (2603:10a6:803:18::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr
 2022 15:35:31 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 15:35:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33791365-b5bf-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649259334;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ciozZ5JTikXArUsVDhzD96BkLQlS1ZjvVnvOLE8T0S4=;
	b=ID7nG2bFGKTeRTQM/SN1YDOdQMj7TewZg6alSFHirLcPV9p10UxKhLn1WM+TU0yG+DukI/
	Ve4oNNaetDZ6PCRf7HkhK/DmaHzat5daWjR+jSQiGR7ZknlT/uStOp0cSByNrtxwrT4mDD
	lgQoTHGbcGR1zoJYyjbEuY1iGZYm8yA=
X-MC-Unique: 1blXUoNnOiuUJmf20AcUfA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=akSmF9A0h3hdy86VMagU02yo1Q+A4amIFvhfSwY1CjfJ67htonzvr6BzoernjdGdrGjZiZaDKIKvIvwfS6dtaottE5uPVCsV45Sr7Hb0Fit4ispvDAh6DmwN9stWcKZTiUyQXXsli0BtHPoFhkIM2A7BeweprIAWuh4n8p/b9+WEN7bzr94mXWnw2r1xWfwbzqXYqmNOqqN7psPmdGLBQ+3XPApbyQc2iDZfKS1ZZX1k4RZi1RzDj07GW+g4aF0RctSphrzuArPMrG1srjUnXcmpVGi3XqciTL3elPglqlWxs3j1FVn7ODKmgqH6fYfPOfk9aIImATOaFlzt2GOGQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uTlQiAwOhnULjpw6AdmxnG8sxKLuP1rGcQ2vG4BBHxA=;
 b=h8H7bd+zeKbls6MTk2hJ8quxDWFK1Fp3YCLd03Pj0XLiv287VQLjRAkR8+6rIUt1KFvvOJv2vTKDjBxzAfodkRnbgrviRJ00rxNfn6ZpxLL2aGcm5kRvhmLfW7EI/TCILIM8aayTAccRMccpPGr2nzYdfZw6PQZ1FHr3YL/tkAr7pOFN/+4uorfBqBQnVlaiTy9FZlFIk2D2e1Ibj2GhA+6sCWRjsmBjvmalHHXcIkwuJQ0hda13EZMi/JYFaXMNEfpSec2MOwSidExUgRgez/Boih3q9A/6wwaSnJHXxH34W0zNAYIiR3wTPj3d7ZBv2SxL5/3DMSKnmYhH+JNfvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3e82b38c-016f-fb5f-7157-2e3655ab3704@suse.com>
Date: Wed, 6 Apr 2022 17:35:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <e17b98ee-8d84-512b-6403-26c7b2ee1eb5@suse.com>
 <d232b6bd-17d2-c78f-49e1-67ffc2502810@suse.com>
 <Yk2XcUhUn0BYk3lA@Air-de-Roger>
 <ffad005c-d6b9-9f27-9b5b-4f6d7345c81a@suse.com>
 <Yk2rS+9o2fNkUV8+@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk2rS+9o2fNkUV8+@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0107.eurprd04.prod.outlook.com
 (2603:10a6:20b:50e::19) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9f271de4-2290-4882-cef3-08da17e3158d
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3776:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3776EA860F1A53B7D9FAA2DFB3E79@VI1PR0402MB3776.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nwRFHwuMoh1BNyCaUnZt4923WuvHZ98rhL32RzR7G1naHzaC9IXbWmUQMN67Mkea2ShqqsqDOafGoyBNMe3pVeFr1bQ0nOS+WsXnDmJ4POH+WN2A1q8QgP2HeMpX/dotgvtvot/wLa5ra1FzJJOXc0BbKG1l9s8cU/hLl8EJfIevnwWfoXJrmcAm+zoOg60CYBIzvpzTshOa3SgiMNGab9vUIKBaiBMhCj4IXsrGtK5B0Z/hpSuNe1R729grsQiMEHyMKAiRTs8PW3emmXLOIq/w4c9U5R0nEWYQCt5lQortw1QHJRhlIXMEB3VV7m3LwIubucqhskwm3r8L533MpShOIh8G3tdFPQ16oNKTjwJo1wKWpouxcJcmn5MUV0O3J1X0B9d4N6tdHLDHqkF1TFY74tBEKHFBH3igTS9U8om9c5GraBWRGlz/KJoT9tWiPEdsw6otCQRahphfGgeV2/l060M4Ls2fAi0flj66rrhHYZBP8YUo87zfv8+vrYfbL/czUtGZgpEEnAKXbkK9ISJ0t58x9vh9d0o3SAazFaIACdV7djGmDtC7a/xVdoVx3Bb3ekaR3hytPbean+bW9qoorxSMy3/TjIPNGDK+XHG0pjavKJXRrqUFhbVlsI7nDdSsBGiwTZU1zBg6/kOSxSv/jeh09/znvTshM1pEf2sSjTir9k73RWBOM5tKSeNFpb4VKE/DDJZKdG8FYlIsJ+jQBx/G/rv1gsWUHhUVA2g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(6512007)(38100700002)(2906002)(508600001)(53546011)(36756003)(54906003)(6486002)(6506007)(6916009)(8936002)(5660300002)(316002)(66476007)(66556008)(8676002)(186003)(86362001)(66946007)(4326008)(2616005)(31696002)(26005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NubBOXeY/4m39YCXZxWMfY8YPQgA5y89nK83O1TGTn/yJTbOiqTok7USmCgl?=
 =?us-ascii?Q?eaeQbFWZnLYaiBkcTuGL5cYcAjmSEavSLovn5PhlWwZpwDZ6crDozvJuwEPR?=
 =?us-ascii?Q?03gikdpqlxJiBFODoEvTJbMiiWtnF5HKgnQQXc93LQOahORNOCZkIChcP14g?=
 =?us-ascii?Q?c0oh2uxVIUnC9yjAo47cRaJYprmLXDUCdquHRl4P0XDVpCC0sxl0gC4VXVN9?=
 =?us-ascii?Q?zXZ29fUTJOuZbz+DlF8A7zD6eiPwSzrc4nvM5+itBKshEca4EiSGKCBEMDQj?=
 =?us-ascii?Q?iyO6OszKRKN5rJmNfX3GKpPfagGEUEZbURH5JlifnEWPT3PNiHS9p2XU7nq1?=
 =?us-ascii?Q?2NeLzNhoatuisrLz+8lP8VqljpxmCleL+XMKcfKUGAVHw4YdSLiq1I21GOYs?=
 =?us-ascii?Q?fiLa4qPgZiUN/ediSeMUeAV+6XCdqwZLcR2FQq2QXKK6y0/oS7eesw+rZ2ov?=
 =?us-ascii?Q?NkQyLkAwAkk6TsroCGEwLOKTlgep5NBANux8D0scstzYUKWT1n5YSiSZMlAe?=
 =?us-ascii?Q?LkDQuS4zRNTyTkFXVmyFvGQ6SeZb2SVDO+XJMG8UxGsUquq/p4taoXe+I1/Q?=
 =?us-ascii?Q?ikTDqiHGF7DHrTMrzMgaptoyeMtaCcMs5rICJUB6IhWBYGszoT+S2UV3Vtgf?=
 =?us-ascii?Q?BLLxTCZOxaXSBpoN3KL0BO8aeOOl23DtkSfg+jFR+WHcQ8T1wCtD87I1OOcE?=
 =?us-ascii?Q?UhfaHNnE/fNCVdD+OpAb+7XyJqVpok3b8u2JvcDzLl/gwlTYhTBMsCSjJrla?=
 =?us-ascii?Q?CnEiKh8a7WoE/hN9ANNQDs+w41wJ3nN9GB3neG6bG8H/aGwWY5ViaEM+BxFR?=
 =?us-ascii?Q?xfMXC05CHuPkk/9Y+s6v/JGoH3szK8KZ1+uNaB5rcCpqFb3oLq+3SZOckb2I?=
 =?us-ascii?Q?1/I1IDGAJ2ro8XCn38CCBconnAPGtbwpwGsv2Dq3YY1FzYe0r4tUM4dA611O?=
 =?us-ascii?Q?22HjCPs5GWXYHnb0VMg6FA3J9bfJ+IVBltepr/zd1vge1sWDEiUVqHMHpW6E?=
 =?us-ascii?Q?1rV3TuMln8Yr0SC8ppkF9+1wMTMKhI9JU2dknHmunMlIg7Q2Vww2UlObg//f?=
 =?us-ascii?Q?eMVq3FVmkkpgBO1WRVnUTvDyAlyUMMn1u/fmdpO/RUknib5tww3hhfXI7sTf?=
 =?us-ascii?Q?HIi8pqpqVvJMv3n7t0glHqlJM4oH2MUw4vK+ap5o2qflgq2WiXSWGYg6U/UD?=
 =?us-ascii?Q?ZaHQ76vh1ErI4TcD+ZjgWynzoCtuDF8EEXjprWMuCeMRedSZwOIyxkqNSjlj?=
 =?us-ascii?Q?zsyhs32Vvo4F+aS7zkwX5uG8qEuWjddgYaW3cmKpautTksQAWRMmJGW3f+cI?=
 =?us-ascii?Q?XLMffmsdvMKnMuKHk4tCZ+kcNLXfT3SkwNRxBvprodicQDroRBa+9ldcJ8kw?=
 =?us-ascii?Q?akdNClFphUjD5nmaZ1IMEjGoyP0Ww7JMPlDEy4dkTPi2n9LtK8V1cd9Rieqz?=
 =?us-ascii?Q?FG9chFyuG2CYEjUK2bv1ORTsJSkGMzP+WK8BXEOtCg4Nz08rw1m3umgQxHjZ?=
 =?us-ascii?Q?5mK3GJ7FRas6zDg9HpZ1KrunDPD8lUVJWYoDtqwPH/mYJcQ/1Qop5UkKJ8jq?=
 =?us-ascii?Q?4kEWhYDYY+ysl0LPkBbVHX+/39XbMAwioO4JzgRBCbN+D+xsDjaMZgjzaj8v?=
 =?us-ascii?Q?j1ZtneF4KmWIu6KQKBfOqIGYFHGmykGEaCKKCLW00YNS4N9mxtvAFz/8s4oB?=
 =?us-ascii?Q?gIz2zqZ3lEwz/HAJl9Dm8gkiyWvHkSJutYQe8Qqpkd8mojLE9JAabgtvTiol?=
 =?us-ascii?Q?G9GKhG6qNA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f271de4-2290-4882-cef3-08da17e3158d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:35:31.8288
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8bFvFSQyFzm8PLnce95wDZSYy5G5TpPziOTqciRFn8mfId2SNrINCS/Kbwv1KzVdFD814CIszYis8WjvEgp4YA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3776

On 06.04.2022 17:01, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 04:07:24PM +0200, Jan Beulich wrote:
>> On 06.04.2022 15:36, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Apr 06, 2022 at 02:24:32PM +0200, Jan Beulich wrote:
>>>> First there's a printk() which actually wrongly uses pdev in the first
>>>> place: We want to log the coordinates of the (perhaps fake) device
>>>> acted upon, which may not be pdev.
>>>>
>>>> Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
>>>> device quarantine page tables (part I)") to add a domid_t parameter to
>>>> domain_context_unmap_one(): It's only used to pass back here via
>>>> me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again=
.
>>>>
>>>> Finally there's the invocation of domain_context_mapping_one(), which
>>>> needs to be passed the correct domain ID. Avoid taking that path when
>>>> pdev is NULL and the quarantine state is what would need restoring to.
>>>> This means we can't security-support PCI devices with RMRRs (if such
>>>> exist in practice) any longer.
>>>>
>>>> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
>>>> Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quaran=
tining")
>>>> Coverity ID: 1503784
>>>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>
>>>> --- a/SUPPORT.md
>>>> +++ b/SUPPORT.md
>>>> @@ -750,6 +750,10 @@ However, this feature can still confer s
>>>>  when used to remove drivers and backends from domain 0
>>>>  (i.e., Driver Domains).
>>>> =20
>>>> +On VT-d (Intel hardware) passing through plain PCI (or PCI-X) devices
>>>> +when they have associated Reserved Memory Regions (RMRRs)
>>>> +is not security supported, if such a combination exists in the first =
place.
>>>
>>> Hm, I think this could be confusing from a user PoV.  It's my
>>> understanding you want to differentiate between DEV_TYPE_PCIe_ENDPOINT
>>> and DEV_TYPE_PCI device types, so maybe we could use:
>>>
>>> "On VT-d (Intel hardware) passing through non PCI Express devices with
>>> associated Reserved Memory Regions (RMRRs) is not supported."
>>>
>>> AFAICT domain_context_mapping will already prevent this from happening
>>> by returning -EOPNOTSUPP (see the DEV_TYPE_PCI case handling).
>>
>> Hmm. I did look at that code while writing the patch, but I didn't
>> draw the same conclusion. I'd like to tie the security support
>> statement to what could technically be made work. IOW I don't like
>> to say "not supported"; I'd like to stick to "not security
>> supported", which won't change even if that -EOPNOTSUPP path would
>> be replaced by a proper implementation.
>=20
> My preference for using 'not supported' was simply so that users don't
> need to worry whether their use-case fails in this category: Xen will
> simply reject the operation in the first place.
>=20
> Otherwise users might wonder whether some of the devices they are
> passing through are security supported or not (lacking proper
> information about how to check whether a device is PCI, PCI-X or PCIe
> and whether it has associated RMRR regions).
>=20
> I understand your worry here, but I do think we should aim to make
> this document as easy to parse as possible for users, and hence I
> wonder whether your proposed addition will cause unneeded confusion
> because that use-case is not allowed by the hypervisor in the first
> place.

I guess I'll simply drop the SUPPORT.md addition then. It would
probably have been a better fit right in one of the XSA-400 patches
anyway.

>> Even adding a sentence to
>> say this doesn't even work at present would seem to me to go too
>> far: Such a sentence would easily be forgotten if the situation
>> changed. But I'd be willing to add such an auxiliary statement as
>> a compromise.
>>
>> As to "plain PCI (or PCI-X)" vs "non PCI Express" - while I prefer
>> to avoid a negation there, I'd be okay to switch if that's deemed
>> better for potential readers.
>=20
> Maybe it would be best to simply expand the comment before the RMRR
> check in domain_context_mapping() to note that removing the check will
> have security implications?

Hmm, with the changes I'm doing I don't think I make matters worse,
so this wouldn't seem to me to belong here.

>>>> @@ -1601,9 +1601,13 @@ int domain_context_mapping_one(
>>>> =20
>>>>      if ( rc )
>>>>      {
>>>> -        if ( !prev_dom )
>>>> -            ret =3D domain_context_unmap_one(domain, iommu, bus, devf=
n,
>>>> -                                           DEVICE_DOMID(domain, pdev)=
);
>>>> +        if ( !prev_dom ||
>>>> +             /*
>>>> +              * Unmapping here means PCI devices with RMRRs (if such =
exist)
>>>> +              * will cause problems if such a region was actually acc=
essed.
>>>> +              */
>>>> +             (prev_dom =3D=3D dom_io && !pdev) )
>>>
>>> Maybe I'm reading this wrong, but plain PCI devices with RMRRs are
>>> only allowed to be assigned to the hardware domain, and won't be able
>>> to be reassigned afterwards.  It would be fine to unmap
>>> unconditionally if !prev_dom or !pdev?  As calls with !pdev only
>>> happening for phantom functions or bridge devices.
>>
>> Like with the support statement, I'd prefer this code to be independent
>> of the (perhaps temporary) decision to not allow certain assignments.
>=20
> I was just saying because it would make the code easier IMO, but maybe
> it doesn't matter that much.
>=20
> The comment however should also be adjusted to mention that refers to
> legacy DEV_TYPE_PCI type devices ('PCI devices with RMRRs' is too
> unspecific IMO).

I'm happy to use DEV_TYPE_PCI in the comment.

>> Since you mention phantom functions: Aiui their mapping operations will
>> be done with a non-NULL pdev, unless of course they're phantom functions
>> associated with a non-PCIe device (in which case the same secondary
>> mappings with a NULL pdev would occur - imo pointlessly, as it would
>> be the same bridge and the same secondary bus as for the actual device;
>> I'm under the impression that error handling may not work properly when
>> such redundant mappings occur).
>=20
> The redundant mapping of the bridges would be fine as prev_dom =3D=3D
> domain in that case, and cannot fail?

Hmm, yes, good point.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:51:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:51:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300008.511449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7w9-00077r-9g; Wed, 06 Apr 2022 15:51:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300008.511449; Wed, 06 Apr 2022 15:51:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7w9-00077k-5r; Wed, 06 Apr 2022 15:51:13 +0000
Received: by outflank-mailman (input) for mailman id 300008;
 Wed, 06 Apr 2022 15:51:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc7w7-00077e-ME
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:51:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 60bbe1e3-b5c1-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 17:51:10 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-TAOPm7TWNzSSN1mBKMUA3Q-1; Wed, 06 Apr 2022 17:51:08 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB4876.eurprd04.prod.outlook.com (2603:10a6:10:14::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Wed, 6 Apr
 2022 15:51:07 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 15:51:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60bbe1e3-b5c1-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649260269;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5mz91w+myVt0gaNT0IunyzfoAUic4JpyT6OrDsybj9E=;
	b=kb066cRXMhea3o2hQA6qgvrPLu+NTLJwvLdkriKK6G9LZLa7ofxpX9jXMnrSqrbu2cpHgQ
	69x46QtU1ySbiiOdEim+iNq+EHMJYqdGWpnsRsKFtbXVK6iR/EO/Eu4yUuosnt/G17PJNB
	hmxu/oZqCLOHZti62JaUytV1Rk/UOGs=
X-MC-Unique: TAOPm7TWNzSSN1mBKMUA3Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fDiwBRSKsjc/kAsiX9u+d4G7UeKmdEkijrtv88facy50StITSpqjQ2LJMxdT5T1My8a4ghE+B7K/w6sH2lDWYlP8VvYE7GMpO08VtMoWldXaFbj8XESwMtemkwnJy360/EE1daZztiOBM9BLSwmkNn5eTWXG+cmnMbQaHGidYsY3CzAShjYQxn1Bzfo9Y1onIsU3IxzbiC12zHBO80P5Jv+7EVBe61fDjSdKdXDghNVdmleICfpIdMVca/WlgFAvCzsW+MAznxqbcMebTKeGFu5ts4r/GqhlvHLCUGNDpQLScaXBcP73IdLK79s6yObP6/XIC+uJztbsaLZRwDiLKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zM/8Ht9g451vNUxbqUffphuNhcG96RV9F4qN3Gg5vfY=;
 b=UGBf+LZ6XVCV0KB59CGPwGYyT82AiKfm7pI7ztL0BbP+lKR4a8WVLHslFi3jBG6DogGaJ5wZUDN2FeB/wRVReABFGC3uuXZZug1bjjG2r+7dfAdkWvJITsOOOsGkfGwLhCSKO4hKpF0POZutIHkiZsHmA0BoPGSGRFxY5Gkvbx4F2cry3DAktOtPxLrwnH/LpmsRy/tgZjbwkQMIHiXFj1IvixwQkpVcC9LFZ68e4Pk36Rzo4nKYCwporHBJ9Kgeq6aJnBc344+KraldfkCL8XtSXc2SqLAzCjcEtAy2mQbv9okjPaHKYufiSQSh/bfEH7JyWA2qaPb00a0A+xuTaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <373308d5-044f-e7c2-4830-b3fbf5539767@suse.com>
Date: Wed, 6 Apr 2022 17:51:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: Questions about Cx and Px state uploading from dom0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <YjrgQOYbsaYOV08H@Air-de-Roger>
 <6a029529-fcbe-3923-26a6-58a58926762f@suse.com>
 <Yk1tvf7oqOf3jySX@Air-de-Roger>
 <333e5dad-5a8d-a8b5-99b5-5d349c784b88@suse.com>
 <Yk2tN5h3nB+ijMoN@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk2tN5h3nB+ijMoN@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P250CA0021.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0649ed1b-a851-4a86-9f4e-08da17e5439a
X-MS-TrafficTypeDiagnostic: DB7PR04MB4876:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB487635D50E5F1EC39136484EB3E79@DB7PR04MB4876.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	doEUvikOdiZ7PRHh66P2xBZBv6/I4CioNuSCEijdNtzFqjoccGBW0YfuIXSrdlrI7z1I7TIq4J0TyWNei2xqVw/vDjoTIpd4uojon14YHVErWsOVakAXfCZemjkZg1XCovpzqrLR2w8+nvYMg6f64an4wsz/nHIZiUB8ReiKvfiNl2wRYEMTzJh8gAdTMeudy3Bw0s49RHJD0HecW4GXiXwP4xSZDc8d0I38aAoVwjQOjwiSCQoFfjpEJGwAVM1mYtqwNtag6/w/OvzQKdfk9BhktMIGrMB8PFHrfkvAyYk48PkEkK6cExEMrRfAFmhLwwC2f6Q1DmBgbbYSIzU7OUgD4esjI8jV/m8ArjopKmGP5hXME917Zemqntlbq1YEdYeDAEIT1S+rQaAYRALyCyqYhiiyZZQlgc5nwmYUKUZBsSfPTF3rAVG2Xcv2HCwpr/9ZRG339upq+fZiPq6Wc0AsgdllTRga9pl/iaTfsrD7TjpcU8xqUc7GFaz9DWTHyzaCYK0dQbDLwC86q6NI0U8XuVzlHoYieRe/pMjAZ9wmg/Q8y+eOj25AkCl7o87Jtg3OZBWf0wWlcUkpAIJVP1UbYDgoZWP1JZfrtheI1QEkv8OTVWmJZCkrVF4pinD7QzD9zFjlijZYGGtuKaJLfzegYaQNoXjVVgHFZ9UHKx7rpsxH0fVBAZK92jh8jKE0neRijTV4HU0H3IYFvPtIHVs0CKTSYJrhbC4JPKsrZso=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(508600001)(54906003)(53546011)(26005)(6916009)(8936002)(31686004)(36756003)(6486002)(5660300002)(31696002)(66476007)(2616005)(316002)(38100700002)(6512007)(86362001)(8676002)(4326008)(83380400001)(66556008)(66946007)(6506007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VYbjrxiJDuqyZxnI+3S6uJFswOUCHyh9AkOaPMMkCLbiQpZiHK2lflC6dg61?=
 =?us-ascii?Q?4sRAF0RQ/ALwZbjZIk649yy/MGoIsF8ydSP5LLEft/CK8wu3k3RMFd3LZkOp?=
 =?us-ascii?Q?wcnbnt322FqjA5rsvgGSSDBYVnV1+OvmESsK1dxSNR9zgrhNjZ7B7GAWaVDq?=
 =?us-ascii?Q?FrUwwURNTexj60j3YxLj1kT7gqJGnKldxeZCSHcZ6S8MFhKUhlIINYsOGmgW?=
 =?us-ascii?Q?2GSoAjbpt5mmKMTjp7ZFL/ij3H2hswufVfhEUxSW3OvmpLKSlGubtYItC8c1?=
 =?us-ascii?Q?Up0tBlvvsZTHFLEp6rGVsrvEAqN2AOnLBG/iLXVoIorNERkCwA2pSJHTlyVA?=
 =?us-ascii?Q?/iGXRdwgnKCw2tN9O8FIMSlG8p1EUm8pQSXAm2zD+yNr9mcovp2B9d5Ui0R3?=
 =?us-ascii?Q?W28LM4b6vEbudC8ASbnc4TwucRVeUlEEWdMjjpYO8l/LLapgu8jahQHkpPpM?=
 =?us-ascii?Q?CHtSZMZQC7XLSq5cbd8AABk/YoT4uRmRZ8kEcPC7DsoveowmFZniQlsiAEIY?=
 =?us-ascii?Q?ROKJ/VQme6rfbpd/mdSwQairmkETLsPyMyvqC0pZQTrbstymZfsnWY/MaKyY?=
 =?us-ascii?Q?Z5mK3alXrhcfUZBGPGIRuYzK+MLmD03iv4fB2+Jdod/8raouLVti2mfMB2Rk?=
 =?us-ascii?Q?+38wUCSpstZM8cOftZ0pMXqGaOnt9X+N1jSK+Xanx7HkIEr6j0ulpCbNE95f?=
 =?us-ascii?Q?z+gFvO9tEIVb8Rfo9grf3svlaLddc64QZUVjBsyA1bScP+EiLGjZGmzgzGVa?=
 =?us-ascii?Q?R0Ys6OdZP9odz81EzpbhrXnylDhjBZ7ltxs+nhcCzks9F2yuRQ5BCb6+32Ny?=
 =?us-ascii?Q?ymO2Ff2dCU54ti7hFa2X1SsCypxB/Q36O+tyIFoW0wecyL+LPOn5/fx6E/u8?=
 =?us-ascii?Q?CmM/VzYTZYca4R6FffWxhDsq7je8O/iq6A8HmlkzB/q5+vGKxoIFfysu0EYy?=
 =?us-ascii?Q?QCBEaHut3a9jdCShIh7k1c6TkaJ0oscyPtXiGdNSI7VoGk5CcHm+uqlMwgPc?=
 =?us-ascii?Q?1BOCUXomesjlLXGJPeURXHO1N5HQiL5JjpjaxSqohNA1glrieir7JgxMXheL?=
 =?us-ascii?Q?dhvjXrAMYiNyK/FL4YpsaeEP7YdqRYLjy0LFnwihZBLdxn1AsPTxGLpshoS7?=
 =?us-ascii?Q?1NyHcfF4bViY5fD5a4ZOURHIJBQrjA0EfxomcVAv+AYZSFSxuK3R4asbahLD?=
 =?us-ascii?Q?VcLA3W9BEb117uEk2ukX1Omjkibx17EE6yO5uNx9z84kCBRtTM63ps/+kBzj?=
 =?us-ascii?Q?pzkE6jSsuW252C7LunvrZZ61rEalrc+hVuRUWwcPGiUqUBYUixvdeR0gCdtJ?=
 =?us-ascii?Q?57bNhCFZjWFFEFtIaN/qg9WcCUKUyVTLwq0Iih55rM9kjKfJF94iKFFiWDfr?=
 =?us-ascii?Q?ssj4rcHn3k3mY/nDXLv1MeQBOE+WSJyIjImcEn059/kwux9HH6UwC1JrXNY2?=
 =?us-ascii?Q?TYEadTJk5PDKK68CNVLwVrkk3jGAhpbmDwyUBvexcRRW+PasHj+VeRIf+jXI?=
 =?us-ascii?Q?eS4/z6unN90OHW6roNFyXBCtE75kX8/aoKDq7PJQc/LSKwjVIh136kkvo23r?=
 =?us-ascii?Q?rxDkf/7S5SfOUuc5iHILqhfAmQGYzIDr48g0sgLo9gcYW6XOs1g6Rlo4SsbS?=
 =?us-ascii?Q?I0aW+aXWnIvADHu4exPBGWEc001HfP6oTpNETDgHwLwqwtTSAOTDmUlqxD7G?=
 =?us-ascii?Q?yBYd/xztFQEQ55+eoZQmgDXYhs098AIzcY8GOFD4DjM14v5lJjfrdlrULWlR?=
 =?us-ascii?Q?oPCBhSSjEQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0649ed1b-a851-4a86-9f4e-08da17e5439a
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:51:07.6753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZTA1CWAvDB4S1M3y94c5UH+RmBU7psgLxa+9hiC/nL9YTSVD6kTf8Aly1UfThZpqrbTO9wPYuzLb7WJ/icO4ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4876

On 06.04.2022 17:09, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 02:47:38PM +0200, Jan Beulich wrote:
>> On 06.04.2022 12:38, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Apr 06, 2022 at 10:13:41AM +0200, Jan Beulich wrote:
>>>> On 23.03.2022 09:54, Roger Pau Monn=C3=A9 wrote:
>>>>> Hello,
>>>>>
>>>>> I was looking at implementing ACPI Cx and Px state uploading from
>>>>> FreeBSD dom0, as my main test box is considerably slower without Xen
>>>>> knowing about the Px states.  That has raised a couple of questions.
>>>>>
>>>>> 1. How to figure out what features to report available by OSPM when
>>>>> calling the _PDC (or _OSC) ACPI method.  I'm confused by the usage of
>>>>> this from Linux: it seems to be used to detect mwait support in
>>>>> xen_check_mwait but not when calling _PDC (ie: in
>>>>> acpi_processor_set_pdc).  I'm also not sure what the hypercall expect=
s
>>>>> the caller to provide.  Should buf[2] be set to all the possible
>>>>> features supported by the OS and Xen will trim those as required?
>>>>
>>>> I'm afraid upstream Linux doesn't quite use this as originally
>>>> intended. Consulting my most recent (but meanwhile quite old) forward
>>>> port tree of XenoLinux that I still have readily available, I find in
>>>> drivers/acpi/processor_pdc.c:
>>>>
>>>> static acpi_status
>>>> acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *p=
dc_in)
>>>> {
>>>> 	acpi_status status =3D AE_OK;
>>>>
>>>> #ifndef CONFIG_XEN
>>>> 	if (boot_option_idle_override =3D=3D IDLE_NOMWAIT) {
>>>> 		/*
>>>> 		 * If mwait is disabled for CPU C-states, the C2C3_FFH access
>>>> 		 * mode will be disabled in the parameter of _PDC object.
>>>> 		 * Of course C1_FFH access mode will also be disabled.
>>>> 		 */
>>>> #else
>>>> 	{
>>>> 		struct xen_platform_op op;
>>>> #endif
>>>> 		union acpi_object *obj;
>>>> 		u32 *buffer =3D NULL;
>>>>
>>>> 		obj =3D pdc_in->pointer;
>>>> 		buffer =3D (u32 *)(obj->buffer.pointer);
>>>> #ifndef CONFIG_XEN
>>>> 		buffer[2] &=3D ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
>>>> #else
>>>> 		op.cmd =3D XENPF_set_processor_pminfo;
>>>> 		op.u.set_pminfo.id =3D -1;
>>>> 		op.u.set_pminfo.type =3D XEN_PM_PDC;
>>>> 		set_xen_guest_handle(op.u.set_pminfo.u.pdc, buffer);
>>>> 		VOID(HYPERVISOR_platform_op(&op));
>>>> #endif
>>>> 	}
>>>> 	status =3D acpi_evaluate_object(handle, "_PDC", pdc_in, NULL);
>>>>
>>>> 	if (ACPI_FAILURE(status))
>>>> 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>>>> 		    "Could not evaluate _PDC, using legacy perf. control.\n"));
>>>>
>>>> 	return status;
>>>> }
>>>>
>>>> (This is a 4.4-based tree, for reference.)
>>>>
>>>> IOW the buffer is passed to Xen for massaging before invoking _PDC.
>>>
>>> Indeed.  I'm however confused by what should be pre-filled into the
>>> buffer by the OS.  _PDC is about the processor driver power management
>>> support, and none of this power management is done by the OS (I don't
>>> plan to let FreeBSD do CPU power management when running as hardware
>>> domain), so IMO passing an empty buffer and letting Xen fill it is the
>>> correct thing to do, at least for the use-case in FreeBSD.
>>
>> I don't think that would work: Xen doesn't "fill in" the buffer, but
>> merely alters individual bits. The buffer really is IN/OUT here for
>> Xen.
>=20
> Hm, but I have no idea what to put here from FreeBSD PoV, as said
> FreeBSD will only use the processor object to upload the required data
> to Xen, but won't attach any driver itself.
>=20
> I've so far been providing an empty buffer to Xen and it does seem to
> set the right flags so that the Cx and Px states can be fetched
> afterwards.

Hmm, an empty buffer should result in -EINVAL from the hypercall.
The first of the three uint32_t-s should be 1 (ACPI_PDC_REVISION_ID)
and the 2nd (size) is supposed to be non-zero.

> arch_acpi_set_pdc_bits() does explicitly set some feature bits, so
> there's not only cleanup done there.

Well, yes, I did say "alter", not "clear", for that reason.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:51:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:51:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300010.511460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7wQ-0007Uy-Im; Wed, 06 Apr 2022 15:51:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300010.511460; Wed, 06 Apr 2022 15:51:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7wQ-0007Ur-FF; Wed, 06 Apr 2022 15:51:30 +0000
Received: by outflank-mailman (input) for mailman id 300010;
 Wed, 06 Apr 2022 15:51:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc7wP-0007Ra-SN
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:51:29 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a454667-b5c1-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 17:51:27 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a454667-b5c1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649260287;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=MgPYovKrrI16mNgsH0jAjbsTQYO5lXzhPnmeplojkFU=;
  b=AsuAJON4Is7KJKp6AtpsUD8ExdIH8GbDN4ED3n3aAnBgQKCEcJ6CQ3FH
   1Nv1ZyX9vqdOZQ6jd6iJaB29jtD5rYJISL8tVnMAlw1/UPeAg1ZKHMr7/
   fHd/ybkSYDOG8sHW9tv6ER622P87naq4lsSJjD806xdt1ngMljL/q/lMi
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68170352
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jybGNqpw1UA4hru606FnX15Rx2ReBmInZRIvgKrLsJaIsI4StFCzt
 garIBmPM/+PYWDxftx0bouxoEJUv5eGzYQwTARtqCxjRC1A+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y2q+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBOvLAxOQ9QkJjPAIiAqMY57n2M3a5vpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZpANmI0MU6ojxtnFHpPJZFjkuKTonT2fwRU92yo+q4V/D2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BCL
 00Z/AI+oK5081akJvH/VRClpH+PvjYHRsFdVeY97Wml1a788wufQG8eQVZ8hMcO7ZFsA2Zwj
 xnQwo2vVWcHXKCppWy18uiY8TOSKHMuAkxeWiFaUg008dflr9Rm5v7QdepLHKmwh9zzPDj/x
 TGWsSQz74kuYd43O7aTpg6e3W/1znTdZktsv1iMADr5hu9sTNT9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQM3d3XC3270k5JGQWy2yGsgTKuOGpxZEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPskoJFPXrHE+OhX4M4XRfK4Ey/9X1
 XCzK5jEMJrnIf4/kGreqxk1j9fHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgp
 SjnABIHkQah3hUq62yiMxheVV8mZr4mxVoTNi0wJ1e4nX8lZIek9qAEcJUrO7Ig8YReITRcF
 pHpp+3o7ixzdwn6
IronPort-HdrOrdr: A9a23:4+lZD6GvaDjb3imIpLqFDJHXdLJyesId70hD6qkvc3Jom52j+P
 xGws526faVslYssHFJo6HnBEClewKgyXcT2/hsAV7CZnidhILMFuBfBOTZsljd8kHFh4pgPO
 JbAtdD4b7LfChHZKTBkXGF+r8bqbHtms3Y5pa9854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH
 LKjfA32QZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y5o2mfvVmHp6VO91xNPdfKla9CC4kY1jiaWgOKsk8SgbwQtjMkfII2N0=
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="68170352"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NhB2AatSSJCUtEmIjYTys19jMYwfAexyHeWvQCaR1tJxuBrqvURx8uUyuRYA9DBoVMrLCtwKqqUmszs6sM7pW7puL3m869uOKgDbYbOFir8e/25D2jRdZwP31HfJeLhSnKFkjAr48EURPQobZP3S1HfR+uM9QrGffxtBSc6ezOM7H45wqNZeKcUvOYlXoFKcuYb7pkytQ5bsi7Nu4rRkHroBpN8KFjDTXGr3v2Q/T1JoS1SWNxCCfYGcxEbi26OoOf0cuUzuIQuGsjz9jOiwIKFYHUnuyMI0cSLA4TGmzeB3ofuSVc6zU2OX5cv+ww8OyVp6Q8S/BDilDDWJHRM9/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WKqVM0GBLPqOklK3xiEy2rbpa2st/sNad4YP4pPi1X0=;
 b=dXKvpiErpMJ9ahQN66mfE7jhr2SOzPDpQFFWs7FhOc5tTgTSZgjGVpb5jWs5DxD+sEr6AvCcX1YLygPA3GgHfnBzwB5fQCXH+G8WAdKVmbmkSReAxYjQmcEj/tS9Wad/UTgqY9bYF63b2xki6RkrRZY1uWo6jj85dC68fMKfIZSnhrnAbwmKfTtL6dmyY7YbPoj0HOrpftKoWgWkaYHe/+RtPB4mrQ7dB3Phn+zsjdWuFds+IQVeorqDlBZ06yn7uMv4X4CUwcIWMh62v1WBPGuArhsYHsUWfC8s3b/KGMrAxIRrUt9XlgnZ7kHW8YBUTFtFEC+6n+UUhaY/M4tpjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WKqVM0GBLPqOklK3xiEy2rbpa2st/sNad4YP4pPi1X0=;
 b=lmkJxcQMgH+Q6bVORX0/E4Wf1ZHhoT87Ho2xqps4jdkk/G74N1QV35DJGSlT332d9y8ip3O5HMkrdg3uS8mWq7wb6DB7+53QmiJRzGpwvdhC6lmuMeCr6Gi+WxfoBNLNEgmtpK0+dywfpLYFP0Zs2adLSTNGQtOLdvMg4kXp3t0=
Date: Wed, 6 Apr 2022 17:51:16 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, "George
 Dunlap" <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] platform/cpufreq: add public defines for
 CPUFREQ_SHARED_TYPE_
Message-ID: <Yk229J2GMnoAUZsZ@Air-de-Roger>
References: <20220406151645.32827-1-roger.pau@citrix.com>
 <3ebd90da-f7f7-fb14-4809-25202f200d77@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3ebd90da-f7f7-fb14-4809-25202f200d77@suse.com>
X-ClientProxiedBy: LO4P123CA0063.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 69f17427-af95-47ce-35cd-08da17e54b3f
X-MS-TrafficTypeDiagnostic: MWHPR03MB2784:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB2784329017063BA977BDF1388FE79@MWHPR03MB2784.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7yV3Ws2Bnxr7WKKigA9f8PKKZ9fPNpVVuwYXhI57KcSBotY9iNK4LultOU4U/kChJy/9aMnhFf7fdnOtkbwSmC5sygZuZHDgiDazPKXuSOplm2+TwhuMDUTUlOLo5gGBc3ruOGpcK6BGmExUi8bTqD3fbOg/9YrL2zrySx2YWoarI2k4tqWQbmpCx6pmneQKL9lJi1C4KGlzRvTRbtaefnZ7MvVk4mjmruDoK5rAnUEBjHg9baTb4n4N0x3Ll4KVrUiI/WMzAm35+gA6dqGcyUEzKuHm++AOkK7jcggntjRHdftmhzbgiQqs9z+cVNqHN0s7oZ83FlfDS9WLSACBgXtUIJIlPUIXB2b1U9EdejDocJ7eHwgZZTpFVJSnMnPftRJTGbOBKRWwD85N4hvlNGje3kFmmq6yZjG7sSfjuOD2CFNvWCpenBfryxilywIcoczdQNYhRLYln5OlTLoLhOlezg/J/i9MSQbkNSVQaNqdrbyocNH4F+yjT8DO/ZhinfkeaJTjzxbxZuDaIWxSS20UQ7QVTnIkcP5SX34da34l/CNSbHRC7psFGYpS1pdQXTWOslgbhorIFsDEVVYdJyfB3AEzwdSWs/+3H1bt/YMptz6yP67B26pShPEaU/9N5gi1F6cdoKMhARyNB/jqEQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(85182001)(2906002)(82960400001)(5660300002)(8936002)(66476007)(86362001)(66556008)(6666004)(6506007)(83380400001)(66946007)(53546011)(8676002)(4326008)(6916009)(186003)(26005)(9686003)(38100700002)(6512007)(316002)(54906003)(33716001)(6486002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmdaZUl0TEF3djI2TW4zYlNleGEvdDRsTVM4YWdTcDhlU0tzY2xXU3EzYzFo?=
 =?utf-8?B?cFFJUnlMMExqQ0l3NldKaSt5RkVnWUp0TGVxVTBmN2p4MjQ0SkRIYmpTZ0NY?=
 =?utf-8?B?b0hyV0l6UHZMV1VGSVF5byswTjRXOW55ZGZWeURSQlZCSXZTTHJFQTg4WG9O?=
 =?utf-8?B?ZzNSOUNPaGdDbmw1alRXYzlkZE1DaGlsbEZOVkd6UktHT1g0ZWhqMjhMSTEz?=
 =?utf-8?B?cTRQZ3NSWmlaMS9HY1l5cXdlc2I5ZElHcXY4aVI1UURLazlRV3VEZWwxWE0w?=
 =?utf-8?B?aFJwOFVkUzBsWTU3cW8wMUF1cGxjTUpWdHY5b1ZSVmJVcDhFU3JHZ3hvVXNF?=
 =?utf-8?B?bjBReWl6SmpqYndnUEthVXBBZGhFT2pEQ1luVjNFMUFMa0p1RlY1MlJkQU5F?=
 =?utf-8?B?OTIyTzJmZGQ2UFVMSHlkSGMwMzBCbHhYQ2FZMXhyVWpEQmp5SkRnU05pZm1Z?=
 =?utf-8?B?N0F6SUpWMmFCeTlmb3VZNVRuSVNralA1bHdIK2l4UWhnWEdlTVdxeFo2N2ls?=
 =?utf-8?B?d1F2V2h0OHpCMnVkOCtHYjlRU1I0WEwrY0ZMdlZZM3dGcXBKMUpYZnMxUHRh?=
 =?utf-8?B?bWRPbXBWR0VwSXNHcnJWYUQ5aGNqTVZpdFhnalZ4NkRPbXB2S3NwUlg1QWpC?=
 =?utf-8?B?RVE0UnV1Vnl6dklhSjhRNjcxU0EzQ2p4OWJZNEVVTUdpbjZWL21SS3JuTkIz?=
 =?utf-8?B?NTlBUmpUcHJIMWdOeVErR1BLcVV0NEM5KzBNNm9rS1JVNVJFem1ZMWJRTUtM?=
 =?utf-8?B?bzF6czdMdXA0bHF1YS9oM0pIOGZyQnhlK3NmY0RSZ0ExMWp5bEdEeHh1K3NF?=
 =?utf-8?B?amJMZ3VXNWZkYU92dWZIbk5ZQjVZNUdYaSt3dWZxNXNlMVlua005bm1UWStI?=
 =?utf-8?B?TzBLbzFuTWJGcGtFK0VxM0ZHRExnTWpaN2dhcjFENXloOGJXNlZiSStrVlJZ?=
 =?utf-8?B?SmpoSElCcW5RL1pPRTU3NXdoUXZTeXZPUitBVU00WkN4dDdoeWdLa2ZGZkY4?=
 =?utf-8?B?cnNaZUQvc2gxdjBmaUlpdkZGNE1aeDRoUGlTbE5BODQ3NTlwWFNqZy95ZHMr?=
 =?utf-8?B?a3d5U2oxY2d4MCtNWS85UVpiZDRjUVM5V3RWMExWZEZCS0lKTXFUTVY1V05Q?=
 =?utf-8?B?QUpjeE9oWGtUcFZSVnhmMXMycFJPTEU2VFdWUFhtRHk3d3F2WWJ2RkRTVDhz?=
 =?utf-8?B?K1BBZUJ4L0NmZ0tjdWNJQ1pZUnlBWllwNkp6b3JEbTErUFpCbS9jTjJZNG1Y?=
 =?utf-8?B?cENFOXFYS2U4MEUwOHdjTHRwdlBGMXZkQW5XTUhYQTJ3ZTFzcEF2U09MZFJ2?=
 =?utf-8?B?K0lIMVdrVG5hSnZMdHZEbm1EMUUyaEtpOHBpVHQ0WTNTZzlETktBOFAyRk9w?=
 =?utf-8?B?VHpOTzBFdng4T0Mxc3c1MUYzY3dPZTRMNndRSDJmK0NkSTNSK01RZTVEZGFC?=
 =?utf-8?B?YUtucXp6dTYwTkpkM3dueGYyQTMrMUdtNEFuQ0loNFJkdkVvbHJPTFZWTlA5?=
 =?utf-8?B?a2FtdmJTVUlXenYwWFRmV2x4bTlUSVd2UERhUWxRZkdZalFWcUhVL2pnSHp5?=
 =?utf-8?B?UWdTSTVScXBPQmpFSDhpSkxYOUhCUjM4NnRUZXM2Unl1RnJDTmZzTk9ZbWEz?=
 =?utf-8?B?STZPNnA4MllJUlRwV0czRFNJZGJsdXVMUEhGU09XWFZXZlhyWk04QTNLQnc0?=
 =?utf-8?B?dTZ6S0pGazhhSWxJSzdIYzAwYzlIVENuKzNqL05XS1UvbVVEczlHcmJUNWtI?=
 =?utf-8?B?bHpPTXlMblNlZHhyWVJoTHVSL3BOOEwzUlo5WnE2RVFwSit4NmRHMDkxOFJB?=
 =?utf-8?B?R05ieFRFMUZITTdNN2xEYlFTaGQ4amxXdFlmbzJTM0dkMkE3NktyeFpFYitR?=
 =?utf-8?B?SGY4TFZRYXU0VDBUVWhFRmdoQkl1NFNvRXNGT1pxRGp5ODZBQ05rMFB1c0E5?=
 =?utf-8?B?RThpSG10TGE0N3ZNeVVDQ3Zsam9xTnluZnJud2ErcHVIdnNobStMTWIxc0pV?=
 =?utf-8?B?VDgwbWpUTzc1THF0ak9PbklTUW5saS8vKzlVbW5WeXY4QnlNRDNXVU1GUFIx?=
 =?utf-8?B?NW9nUUlEeVhiTDBtQTFrNFVHR1daeDFpWWpYTjRHYjQ3YzVHQUh0MmdVMWxW?=
 =?utf-8?B?czh0UnlCVEQ3V2Rqci85SUlETjdKcUt4VFZZc05ObVp3Q1BNM29zYk1sTCtL?=
 =?utf-8?B?N1F0eHQ0V2pzK1dzaitLVk1DNWhRaDVFaTdlRTlKbjBJL2Exd1h2RExTTGlY?=
 =?utf-8?B?TVNodVErZWdkNGpjVWxQSklybWJlaUx1STJnd2E5cmkrWjZDUzNzckhkdURZ?=
 =?utf-8?B?LzdFbklIWGhlVDd3ZVlPaDgwMTU2UDlkckRsaHVMQXhBTnlxNkMySFJuUS9U?=
 =?utf-8?Q?3SbAz14PvDy60IrA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 69f17427-af95-47ce-35cd-08da17e54b3f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:51:20.5147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yIkzZwXtaL+7ZFsgHmi8EBTFzO/5sc7rX4hvXj+ibcOZbGvoKmldOu006wkN/aWYWuQSF+gphtOzTv4isqxJ1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2784
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 05:31:22PM +0200, Jan Beulich wrote:
> On 06.04.2022 17:16, Roger Pau Monne wrote:
> > The values set in the shared_type field of xen_processor_performance
> > have so far relied on Xen and Linux having the same
> > CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
> > public interface.
> > 
> > Formalize by adding the defines for the allowed values in the public
> > header, while renaming them to use the XEN_PERF_SHARED_TYPE_ prefix
> > for clarity.
> > 
> > Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > I wonder if we want to keep the CPUFREQ_SHARED_TYPE_ defines for
> > internal usage (and define them based on XEN_PERF_SHARED_TYPE_) in
> > case we need to pick up changes from Linux.
> 
> I think that would be desirable, also to limit code churn by this change.
> 
> > --- a/xen/include/public/platform.h
> > +++ b/xen/include/public/platform.h
> > @@ -465,7 +465,11 @@ struct xen_processor_performance {
> >      uint32_t state_count;     /* total available performance states */
> >      XEN_GUEST_HANDLE(xen_processor_px_t) states;
> >      struct xen_psd_package domain_info;
> > -    uint32_t shared_type;     /* coordination type of this processor */
> > +    /* Coordination type of this processor */
> > +#define XEN_PERF_SHARED_TYPE_HW   1 /* HW does needed coordination */
> > +#define XEN_PERF_SHARED_TYPE_ALL  2 /* All dependent CPUs should set freq */
> > +#define XEN_PERF_SHARED_TYPE_ANY  3 /* Freq can be set from any dependent CPU */
> 
> While the names may then become a little long, I think it would be
> relevant to have "processor" (or maybe "CPU") in the names, to have
> a better match with struct xen_processor_performance. Also I'm not
> sure you want to define these inside the struct - they're
> supposedly suitable for Px, Cx, and Tx aiui (just like the underlying
> ACPI constants are).

But those defines are specific to CPUFREQ code, the raw values from
the ACPI tables for the different 'coordination' fields found in the
Cx and Px states use different values, ie:

#define ACPI_DOMAIN_COORD_TYPE_SW_ALL 0xfc
#define ACPI_DOMAIN_COORD_TYPE_SW_ANY 0xfd
#define ACPI_DOMAIN_COORD_TYPE_HW_ALL 0xfe

And hence the values exposed here should be limited to the existing
usage by the xen_processor_performance struct.  Otherwise it would be
preferred to use the native ACPI values, which don't need exposing in
the Xen headers then because are already part of a different
specification. IOW I think it was a mistake for the shared_type field
to use the CPUFREQ defines instead of the ACPI values.

Note the coord_type field in xen_psd_package and xen_processor_csd do
expect the ACPI values instead of the CPUFREQ ones.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:54:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:54:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300017.511471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7zI-0008ML-6E; Wed, 06 Apr 2022 15:54:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300017.511471; Wed, 06 Apr 2022 15:54:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc7zI-0008ME-2f; Wed, 06 Apr 2022 15:54:28 +0000
Received: by outflank-mailman (input) for mailman id 300017;
 Wed, 06 Apr 2022 15:54:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LqB1=UQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nc7zG-0008M8-Pk
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:54:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d55fb50e-b5c1-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 17:54:25 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-DLKrpDQ_Pyuz1fM_a8Y9YQ-1; Wed, 06 Apr 2022 17:54:22 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8067.eurprd04.prod.outlook.com (2603:10a6:20b:3e5::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Wed, 6 Apr
 2022 15:54:21 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022
 15:54:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d55fb50e-b5c1-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649260465;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Mi3EXkuNbgleNf48ohoJc4HHvsGzUhmjATPK8MDlSMw=;
	b=NtGmAyrvtT+5DXG7xiKy7N5oxNBNe96FZ4nCN/NP19D1t6SmuvnhUJVKC/aPKPNc4cpRfw
	YTc6Iv44hAGE3Hz7LKKGyJpFqpzlygLBRC85Nv8WPamD2ePTzS4P5yu9yMi0CIomrBO2YD
	PyQPfwSX5dx3U663CP5OUO4hIpoZcy8=
X-MC-Unique: DLKrpDQ_Pyuz1fM_a8Y9YQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k4z1ob4J6ZmDBycUscHH2CCnFR0r1KUGTWS5Qb270VGhOIiTIqmoA5GuyshN6r5hyO5EQ9xmOMpd4K0jYQbHdoOcm1igqvxJ8Gsowm+iKVMxv30PjgfE0Y1C3V3PBNG33GvsMKgsWOVqmnFupjdz9KcjWVhPc9ck3DLwI7oviKdlkhIWU/KpPCRW88LmIOg1F5QYKvw898wUKSrMZ1hx1eBbgJshKuf+cvDrZ+KsMFf8B36k9gCfdaJCK8RcZ32ZESw4PfYoP0btMdqCXyR5RrmpimWdqsyHP3oaFt5WZEx+wEj8w+8ziuNBHdhzmWQf8v+/trYdgSlmhrNkvjxDOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j4u3NPZpEajzisC3g0rVxRAkrG+CWew5OjjzP3q1X1g=;
 b=X1LTo2G8lUYAjSHWjVLboXkuV4IpknA8whESp/CT7DJyg8zQoFkp+dhs0jm9r8HgasZ8NAl+cX+Ws1znnnjcSqpWm6oBClYskphn6H5Xw6hGxgfbHXw3+YzVYAieID3RUY1SGz6g3bQ1bqedxkTzfpqTx5CNOrTPEtI7rY+cxgM734CceKId+6xFP8r5TaIwzuJ3IUEw7YooXIY1VYOB0y+MxBJfHvCLbmk+RzL0hFvoZnPyENLflmGV+O1Qm2tzw/p+9crQQ7Zzm/PD80cILlqj/0c8lwRNrpO745deccjSvKPmUJpsLQUvoaV3khjKjVlxdJkrLijpo9F/Z2D/bw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8bfacd47-d7a3-594e-7bcd-dc16c208f12b@suse.com>
Date: Wed, 6 Apr 2022 17:54:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] platform/cpufreq: add public defines for
 CPUFREQ_SHARED_TYPE_
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220406151645.32827-1-roger.pau@citrix.com>
 <3ebd90da-f7f7-fb14-4809-25202f200d77@suse.com>
 <Yk229J2GMnoAUZsZ@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk229J2GMnoAUZsZ@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0052.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::27) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 02db5803-fee4-49fc-a954-08da17e5b6eb
X-MS-TrafficTypeDiagnostic: AM9PR04MB8067:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8067D31AD0FB361C411C173AB3E79@AM9PR04MB8067.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7H0dM+j12O+694looxDZnzuOCoWIeJZdtUsogE2jhcn/T0sIyqVZQ9e6HNlSSKXpSZy/qKGxYA56qNYSg+/iBUTtUKIgavijMsrvm+IAtA1U7kOVi2Q8Ug9mQ5YLrvZDUlV2ya1x+D/kvd7gLvYsNWhTuuQMzRomNb47ykLs8zg4LJge/J+dnFZQoRa/gacS62JVacnCvaXPgTcF9ds6d47dted50BF6Jt7TjD2aGSMMK5npBCFYcVbG5GzRrZKV047+XDxJ+bZ8YliB7sYMVaIry7dNjzmUxZ4h1XykCJUv604Kqd70/Y8KdzItL8bxRNUUtAtGNZdanNgumzqOtQ/klD/k5h9uBGHKagPq4jYVFlIUKmVEJnMOAmc99TX5F2bbu77hDLvl153eJIA3v8At1YglkUhSLpJlSQYssK3g6lhmHsrn0pO26KC6/VKmt7PLf9uqxgNGnUedWb3uttQgl2bKQtP+0NVKOji0PTCai32uHNHG2RzQjuBvFhGeidF2RL52Mj7fvpIChmRadOF0nw6KLWMHCuEbNuHQwza4dc4tG8+QzxGnBGmV/fHgConEnJKxCtGAjxW5DvFBUwLvTWI4aze7+Wqn3hvOv94QC0yF4o8TbXnhxeLyVkEafq3YXEi1uD4Vazt9mXaimfL+NRg1N5d6Ppf+fcQ1UZcsbET1OAHrYJt0WDCItpDkcdZsEdML3c9hvrGg/US1quf2BAV6fokU8l9SU37/7j8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(2616005)(31686004)(31696002)(38100700002)(6916009)(6506007)(36756003)(53546011)(186003)(316002)(6512007)(54906003)(66946007)(4326008)(8676002)(66476007)(66556008)(5660300002)(8936002)(508600001)(83380400001)(2906002)(86362001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?CSQ78A+NRaoGSJmgVzIfmPjpme3o4ozSBHEd5W58eugczX7DEUYasBIodpLU?=
 =?us-ascii?Q?/Xf013x2HVIqsO6fosf2S27Exi4JwNw0gJITDMr3ragA2uyHAz//pcxwCWfx?=
 =?us-ascii?Q?dM14aAgIB+WbG1OGty8EzE27o/Q69nMk+ZNZLLLwzRnVvcywW6ZWAtTWbV1F?=
 =?us-ascii?Q?Hd4/bKJjLnk6TVtZVWHMtiYG2s/kShXzBUzUBfJzEynCy0qYRsiTPAGZQ5M/?=
 =?us-ascii?Q?RJRn5RSqzvg/cHbkFoZSsun/MaNh/hxYeAONa3MKzddDCd6bDBUVYEBvMT1b?=
 =?us-ascii?Q?PvJz9QlQI0BUx8dtwJK+hiuTE3btCquFfKRJmDwGvBHUZXUbu9jHbE/G+ulU?=
 =?us-ascii?Q?GP+BC9aEvorhDZhu/5g/x1OqtsMgqZ1EdEqMLUXbD1OgS2WagrfLRrR2E+SU?=
 =?us-ascii?Q?ThHSe3CBshT0cG13pCoC89VI+KM4aIEuLyw9ejT4zl0hgiQQoEdPapAW2NTM?=
 =?us-ascii?Q?FiQwSnMDffAM++FRK1frfcyFJn3znUlwMV6+COctNRv03VD75yiQ6ALH5vKV?=
 =?us-ascii?Q?GP484hXb8YNqYWvLXK1CSh69ObrQtwEuTr/1+Netwuc+vCU2ufVOy8X2qzR8?=
 =?us-ascii?Q?kGa6wwsYhtsZHdcU4yjWLop8hVfZa9qZO3PrJ5ICUkNyKX2TvPhu1W6kV+h6?=
 =?us-ascii?Q?VGWIVhisHtGdFMymkgunWW0m+jAc5HK+TkUPxSLESSWCOxWwGFHkuVZ1zrzB?=
 =?us-ascii?Q?pCvqZb2qNAouAapu+Wux90wT2rZjxwJjqDPn7TXvvFIS8/OIogV+hnd7yT5F?=
 =?us-ascii?Q?IsmjfC6BmmFFUoVfOLrP+f7vtb2SmWCh6VeyRGOwsVaCwvud3Zih1xihHsAT?=
 =?us-ascii?Q?d48vHvmj0/8u28+62iHb9qWsBGRtftcF403Iy2OfmIOzBe5xzRorXHuNohp8?=
 =?us-ascii?Q?7ZTkP1frTQHsVqAPyWaz+t+9TSIzw54OuF0/1rHQhVDwJ6x21xYkVwe0v5HV?=
 =?us-ascii?Q?Q8EIPyw00WFpnkc7sMGynFm0AtiwN5mpaSN74i+8yjSKjrhNbfR0HLzoRds8?=
 =?us-ascii?Q?tKHGvu9Vd8uOvnXmgcWoDNVIzXaqT6NYyr1VBHnTrz8IoItbLA1XoT17FWBR?=
 =?us-ascii?Q?WNiU6SfVIQQvkTkuujX4Q3wITDfXrdlnn9al1KQiCTvPsun59qIqw4+4GOwy?=
 =?us-ascii?Q?kwQwf3GZSOFWO7qmYiKhU4Qi9140z/DWobH2i5M8zzH01iFb8VY7ScEQhaey?=
 =?us-ascii?Q?ozdTTeT/fTtkS7qyQ6ti7ITkYI6Tedv93gDw+md32rAShUxb0LTjm+kMY2+b?=
 =?us-ascii?Q?WeaufGt44zfNaMmC0ogxIJI+REae/4Nx/N0Nvy6LCzNFHrjLjxhCciv3+zmx?=
 =?us-ascii?Q?FMmiW1n+WVU7UQnp07d6TC0jJMzeAGTAaTYBTyAU2LA2s1rRNZmaWkqqGwAQ?=
 =?us-ascii?Q?HTerYuujoqY6lEG8v6AymXSZwWhsOGyJVZu+ejV7wpZI1ADTO+7uCkOx3U8J?=
 =?us-ascii?Q?xItAUC8f38DBDcbgcE7kaE+qVal/j+sloJb1zZZfiU23A5kQ6wwkZ6OdhmqE?=
 =?us-ascii?Q?6rkjTGtk4lvY/fBMXiWX7ZrwiNaDFUYkn6mA+dXctP7GXWpNqtMFRntK4y/S?=
 =?us-ascii?Q?Rb4QWy8D9zFqdueOyYq2KE9ekJXsupIfwihzcGtCWiWhsDGCL+nKUR1LnD9L?=
 =?us-ascii?Q?XElHhZz0BPLI45dGjPnxzE6vj1Ifk4HlZGjIH7BOOX9X9Y2IVCDHPJx5RWp0?=
 =?us-ascii?Q?DfHNX+Gw+b9lIFCJYCBL/NQTKdAqXrPNh4n3UhBOV4UrvlDh21adjTvlsTmf?=
 =?us-ascii?Q?aUFp95860g=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02db5803-fee4-49fc-a954-08da17e5b6eb
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:54:21.1131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IywVyOzxt2cZJuO2Xw8L7QHPlNFPGmM+lhY+a286lGp8wAmgVWUzu/vuzF5KzIHUztnR0bGQ+6fTgG6+AwljTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8067

On 06.04.2022 17:51, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 06, 2022 at 05:31:22PM +0200, Jan Beulich wrote:
>> On 06.04.2022 17:16, Roger Pau Monne wrote:
>>> The values set in the shared_type field of xen_processor_performance
>>> have so far relied on Xen and Linux having the same
>>> CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
>>> public interface.
>>>
>>> Formalize by adding the defines for the allowed values in the public
>>> header, while renaming them to use the XEN_PERF_SHARED_TYPE_ prefix
>>> for clarity.
>>>
>>> Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>> ---
>>> I wonder if we want to keep the CPUFREQ_SHARED_TYPE_ defines for
>>> internal usage (and define them based on XEN_PERF_SHARED_TYPE_) in
>>> case we need to pick up changes from Linux.
>>
>> I think that would be desirable, also to limit code churn by this change=
.
>>
>>> --- a/xen/include/public/platform.h
>>> +++ b/xen/include/public/platform.h
>>> @@ -465,7 +465,11 @@ struct xen_processor_performance {
>>>      uint32_t state_count;     /* total available performance states */
>>>      XEN_GUEST_HANDLE(xen_processor_px_t) states;
>>>      struct xen_psd_package domain_info;
>>> -    uint32_t shared_type;     /* coordination type of this processor *=
/
>>> +    /* Coordination type of this processor */
>>> +#define XEN_PERF_SHARED_TYPE_HW   1 /* HW does needed coordination */
>>> +#define XEN_PERF_SHARED_TYPE_ALL  2 /* All dependent CPUs should set f=
req */
>>> +#define XEN_PERF_SHARED_TYPE_ANY  3 /* Freq can be set from any depend=
ent CPU */
>>
>> While the names may then become a little long, I think it would be
>> relevant to have "processor" (or maybe "CPU") in the names, to have
>> a better match with struct xen_processor_performance. Also I'm not
>> sure you want to define these inside the struct - they're
>> supposedly suitable for Px, Cx, and Tx aiui (just like the underlying
>> ACPI constants are).
>=20
> But those defines are specific to CPUFREQ code, the raw values from
> the ACPI tables for the different 'coordination' fields found in the
> Cx and Px states use different values, ie:
>=20
> #define ACPI_DOMAIN_COORD_TYPE_SW_ALL 0xfc
> #define ACPI_DOMAIN_COORD_TYPE_SW_ANY 0xfd
> #define ACPI_DOMAIN_COORD_TYPE_HW_ALL 0xfe
>=20
> And hence the values exposed here should be limited to the existing
> usage by the xen_processor_performance struct.

Oh, yes, sorry.

>  Otherwise it would be
> preferred to use the native ACPI values, which don't need exposing in
> the Xen headers then because are already part of a different
> specification. IOW I think it was a mistake for the shared_type field
> to use the CPUFREQ defines instead of the ACPI values.

I agree, but we can't do anything about this now.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 06 15:57:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 15:57:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300022.511482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc82L-0000Ze-O9; Wed, 06 Apr 2022 15:57:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300022.511482; Wed, 06 Apr 2022 15:57:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc82L-0000ZX-Iu; Wed, 06 Apr 2022 15:57:37 +0000
Received: by outflank-mailman (input) for mailman id 300022;
 Wed, 06 Apr 2022 15:57:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3N7O=UQ=citrix.com=prvs=088976f43=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nc82J-0000ZR-Rp
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 15:57:35 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 445d259d-b5c2-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 17:57:33 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 445d259d-b5c2-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649260653;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=HeQ1hEP2KxO8OAsiPY8uzcyTo5VzCnVu7zoMccokOrU=;
  b=GjRdlOLy9ka9Sx0NpsvvAjdqVQLe9o71ymqA8KFp2O9VRaNDqaOG1lNl
   7hBaY2MipFSLObG/v02M7BL6dwZ6GxbmvoKMVtTff1DqhWy8FUwnUCCem
   ZI7tuGLdJvzd20xQ1VgPog6GtwQj+23gjGsDHwllkbcQd+aCctDG/q7il
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70573128
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:K+pw2aAIngoTghVW/z7jw5YqxClBgxIJ4kV8jS/XYbTApDImhDQDm
 mNNXz+PafmOY2Pwc9x2adnjoxxSu5+Byt9mQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jh3NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhAl
 s12srCCSTsQFZfrxPY3eh1VE3tHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcHhGpv3ZkUTZ4yY
 eIbVTVzbCnYRyYXO2lLLpwbjeenoWHGJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqEmevnjS79HoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiE/apiUbd+hQL9QR0ibR2ID95wuZXFFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqVFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tmuVh6b/PuREDGQ3C94acu51qXHb4
 RA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSLyJNAMsGEudBgyWirhRdMPS
 BWN0e+2zMUNVEZGkIctO97hYyjU5faI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5DTkU8CD7SiPHK/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chQwJIbX7ZEfFTi3Vw==
IronPort-HdrOrdr: A9a23:w+P5qauEzLGN8MMJiwGh+egB7skCkoMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN
 gsfJ4Y0I2mdfVmH56VNN1xMvdfNVa9NC4kEFjiaGgPR5t3c04klfbMkcEIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="70573128"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WPqi+iomawinjKphj7dcAVADpbS9h4EJbvFE5u1g6HyvJhTBndOawSDfsx73G8UzTlaCDAf4h5RGjQee8cgNsZnh+vaWEREqws6bAgmM7WwXN1UUeNxbZt3xESpi1EWOrEKcFiuD7y9Kp9u7lhRDC7EhsG2wfjPGy43NfyVumbv76C+6UHNjonYjJnQIWJUE77i5JGTAER3LY2Lkc8iKUAklyu9+6OoeMFpGkOMQ5fD0cFeAmMqdNQ6wSicKuk5Qxar2esTKcT4DaLb+YB9YKHShI1Mm2JOufapEPitZpGgUIkhrOz8u/6D5YjiHbQRyPjR8H3MHhJHT1ZiYI44S3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cgFRhV2tmkPELg6HtcElbngN1vuU5CP62IRJyCzhhYg=;
 b=QfFCo+OFd9vgEHzvc/m176MeHfdVK+PYRHMN/e/uYzYsfdvxS5Kihu/f4N8C6qrywmRyE71u10g/heU65bjPny3BGXW2jjMv+VsdA9ofQ8D5iiXm3Deq3QZD8X8NrUybMdXcvUUecoXAs/3CJUoUNC2TL3Y/yNzMqFFEwSfDifPqzWgoHNfVmgWBtld/hJegHanQcwvvoItVpOXJg3phfym7x/TX882vtQGGrsRRfaw+EUj8ReD0KSq9F0LMvf8f9xwiD3ZUExZFamEmJZKw4hWlhG2w6CF2f810iPvkzfVwVG36QnmjWwMcL418hVahG6QiaNTSsSmWnEMWPBWXBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cgFRhV2tmkPELg6HtcElbngN1vuU5CP62IRJyCzhhYg=;
 b=vPIc+ZU7B6ysWBKrNSavaGUuiKfQY/kKtx8z58keiOVkwWBuKmha9aJizpVBe20sUPZyqU+IHYGtFVfGo+mwC6OG0FArIllpzciiV5+PUESE681GjQBT4C7CHXJzRr0PQIrC0sEnHzA9JufDxqEImxMKf9UvskhDjeJaxBfHXZQ=
Date: Wed, 6 Apr 2022 17:57:23 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: Questions about Cx and Px state uploading from dom0
Message-ID: <Yk24Y/Ky1UPy4WVK@Air-de-Roger>
References: <YjrgQOYbsaYOV08H@Air-de-Roger>
 <6a029529-fcbe-3923-26a6-58a58926762f@suse.com>
 <Yk1tvf7oqOf3jySX@Air-de-Roger>
 <333e5dad-5a8d-a8b5-99b5-5d349c784b88@suse.com>
 <Yk2tN5h3nB+ijMoN@Air-de-Roger>
 <373308d5-044f-e7c2-4830-b3fbf5539767@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <373308d5-044f-e7c2-4830-b3fbf5539767@suse.com>
X-ClientProxiedBy: LO2P123CA0068.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 49fa5f31-f9ea-4457-dd0d-08da17e62611
X-MS-TrafficTypeDiagnostic: BYAPR03MB4326:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB4326EC5E25CD1DBD24F3CC438FE79@BYAPR03MB4326.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: f+GlLidahmv8HKsv+A3+EwlDZyRXOEVqXFuPu6w6hmIN0Loeti3hC4H9ONhqPDBTIEpNZ/ppmJqeeS0r9ghU2CdhjZ0juGvkKR4LLAMLTp2bdOhoCgVL0Z/WcM9Tlni3PLEw/pz2309kV/5hcBdC/6pp2XdN0xdZ4dSNL96TRrdh5L5IfA8cqyJddJmdMV/ownoVeCAvReXZiQWF+QSmkhHE8+W8Kmutoih6oS/KtZImoLz4XaC3VZTndWbeb8zQB0IvAowrvVaOvMmPZg9TKfX1Soc90E0HRZjJ2+ELH1jhGTfxSxSjOubWGCJJD1i1beanHspJMzzPqE8cctSVEDvNdlL6rzQZzHQkIAlmqLKI7cT1RCjMXtQmjCX5K/fugkboBZav7Hl9kHWNCOwhL/MYMOgEBsjq67ijTCihjfBqwxhuoI7pME3fUkgHKYKGKkXav6kA2tXeFBaK68d/BNRC97EarIDhnq+lSvX9wzjRzW/Fy+PovwI6jsLpAdyzDDNU1Jw0XnzXD6esfEve87peu2NiYp/fgTvgCvyDpUHq7o0qxQIZsWb0scLXGQqPvU1XxpRBfixNMJ/gDrNjdLOe/QjJ2yXcJaqWflXCyaELth1im3UCG2z3ZJF/KoranvqKXGIYIOmSY+hMOI1RHw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8936002)(82960400001)(6512007)(38100700002)(85182001)(33716001)(26005)(53546011)(316002)(186003)(6506007)(9686003)(6666004)(4326008)(83380400001)(2906002)(6916009)(5660300002)(54906003)(6486002)(8676002)(66556008)(86362001)(508600001)(66946007)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amtyZll1TVhWZEdUR1hrakNzUS9UZUduUDQ4bFQwSWtkMWZOYUlLZlY1bFow?=
 =?utf-8?B?YXM1RUZNd2JMdExUWHd5bTJWc3NvT1ZEODRvcmdnQmtPZndaS0VHTEVSMXZR?=
 =?utf-8?B?SFpuek9oQTNsYUUrUU9MSHhzNTh5cU50czNQcUREb25LZkJoVi9mUXFtcnhi?=
 =?utf-8?B?dUk1MzFYMjVrWFZySFJCTmtWTXZXUjRwVFNyaTJDSG1Sc0RpQ1NxQVY1RHRp?=
 =?utf-8?B?UVVITzZKdHNPSDk4TVhvaE1ET1hSTy80aUtqWCtucXF4UDFVRmZtYUI0MkJs?=
 =?utf-8?B?S2tOVmlaNDN3YmtmOHkvR01RTWRBTzV0RGcxME5ReHZJNklQSjdCQ2ZTVmh3?=
 =?utf-8?B?bDFIdlNNdmF1RlhDVlpiZXp5eHZ2NG9na3A1M3JWa0w0aVErN28wR05lWFE2?=
 =?utf-8?B?b21pUUd5ZFNwak41M2Y5cUZJOHpUaWg2eVFNcytGQ3VXcXdRZExIR0NyejFL?=
 =?utf-8?B?bTZlc2FseGd2UlMxM2dtRlY4VnY5QlBPQVlhMEExV3Q3a3djaTBGem0wcW9N?=
 =?utf-8?B?WVdGTU9wZEl2WVV0dm15T0ZiNTU2a0VkQ3ptdE51UG9tdjRjbHBjd2MzT2RT?=
 =?utf-8?B?K2RhcFRWQko4cWw4cFlWUnN2b1YrSmJFRk9TbnRFTnJkcnBEb081MlN1Mmhl?=
 =?utf-8?B?a1dXSlZRdHl5YnZhNVdCZmw5T0thdzJtZ0Z2WHZ6ZE92ZnBLa1I2SXQvd1hj?=
 =?utf-8?B?MHkzc1krb1JvZTg0aFB3R0RzSG1Cc2hMSnQ3bThINit6UncyR0Q3cGRhM0lk?=
 =?utf-8?B?Mnk1eUo2OVVEeitlVkFLZGF5S1lDL3N5R1dKQy9jdnpoM1diSXplQ2ZOdXpx?=
 =?utf-8?B?ME0rbVRHQzE2andJTE5ZVEhSM0JzQW9JYXdkYmhsNXoydUdzMVBIMEJlKzlh?=
 =?utf-8?B?YlVEcUo4WHdwZlozL2dKVW1JRFF6MnZ4ZWNoUlNLK0UzazUrN2VUN1QrUTBO?=
 =?utf-8?B?YnlRTnBMMDNXVTFOTk9sdkZZemRRbEMxM2lsQ3RSVHJJUld0N0NFN0hKSEMz?=
 =?utf-8?B?aDQ0L3R3TzYrTzh6ZkM0K1dyV1BJTmwzSjFxN1d6VGJHN285RFI3Tzg2WmtJ?=
 =?utf-8?B?TDN5aU5PL0pFSS9oY0RkTisrbjZ3UFU1MC9XbHNZUFFJV0V1SExLVlJzODY2?=
 =?utf-8?B?cDF3c05lMkxld096ZVA5UXpHMmUxZFpwVTNoM1l4eTVIY0F6aVc2ckcrUmFo?=
 =?utf-8?B?RUx0VXAzOXRLKzZaKzI1Y3I5L3NCbndGLzB5dUk3QmFSYXhxRU5qUEdvVmpF?=
 =?utf-8?B?d01zaEF3WFBNU2JTRWVXU0pOeXMzanBtZ2Z6dGJPb054RGdBWmJOZWIzMWtl?=
 =?utf-8?B?VkxXN1FLQzgrRkoxN1pxU1o1UTdVRkZ3bU1BanU0V05FT2c3UmZRYU9Vbk1H?=
 =?utf-8?B?bk1mei8xQkJiQUF3Wng0T3ZzR3h5dVNwYVRLTk1tY1Nvb3phQWovNTE5ek9M?=
 =?utf-8?B?U1g0ZjRYdCtmckJpM0xCUmhOeTF6bEUwVS9Bd3huMFBEUFo3cjBsa1oyTHNZ?=
 =?utf-8?B?elovTWZsN0JpRFRKc0FrN1UvVkZBbmVwY2MyWEg4SnFyVWt4bEpOMnNqS29U?=
 =?utf-8?B?MUF3YytvUkRkMUtPN0ZxUHYzUmI4Nk5aYTVGMzR6MEZDWGk3T2kwZ0h1WTc3?=
 =?utf-8?B?ZmxMVjRkVkcxcGdyWXFxVGlvNlBDNzdzeC9XZTE4NWpqVDAxN1pKcGlWckpK?=
 =?utf-8?B?ODdqVW0zTlVnZ2NCb08xdUxQTVRPTGdBRkFVYUh1aWVqY1FEUlYxbXBiUFJr?=
 =?utf-8?B?OVhIZ2ZiSmh2QUEvRHh1Y3dPcVYxY1UxREduTFU3b1NocG5LUmhLOXExOUpo?=
 =?utf-8?B?OWVvM2x5YWtmMmR0cVRBYjg0MS81T21JSjBHdDJZOHJGYU94QXRNTjY2aTIy?=
 =?utf-8?B?MEZtSVg3QVROamF0YWxMa1BNVW5scDJtaVVPU3Z4SjZvK2EwOHRQZXNiRFB1?=
 =?utf-8?B?L3gwMy9KVllZUDBwaHIvbWxwLzhlTFNqOGkvd3p3ZTNMZVJiWU50WTQzRWtV?=
 =?utf-8?B?eUFtc1dPZjNaVVQxeWp6UkxiNEJkc3dSeGI2NlBJc2lOeG9ZTE85WHp6Zldw?=
 =?utf-8?B?K1BnRnZoQnE2WFpGdWk3WVQxZUQvZG84dTZLUEFKNUVHdEhtR1RyeUgrZW9h?=
 =?utf-8?B?THp5YzdnaXFJaFp3ZHlVam1ma0liclQ1R3NlOGQ1enlSVG4zNlZVSWJVWHkv?=
 =?utf-8?B?UGo3c2tGOVFqOS8veGdkdzU1eGV2S2RsUFVHeGZaaUpuV3hoUXA0VVA4MnhL?=
 =?utf-8?B?M2xmc3dYeU9BZC9zbzVaSGxrWDNQMFFSTW1RemRjTXJTYlBIV2h6Y2d5WnQ0?=
 =?utf-8?B?alRWTEp2dWpSU2M1Yk54bm5CQmhMWFI4MFp3TExZdVdDQktSdFlORGo2OUgr?=
 =?utf-8?Q?Yj2f2EvRnudYp4AU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49fa5f31-f9ea-4457-dd0d-08da17e62611
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 15:57:27.6061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pGovSxcExIsJxHBSy5fBsSVzQPYPAYlDHwJDf0x39wIWuqLhMrwOlHVxtphq8+cL2YcL3olG7pc1oHg4MMlkQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4326
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 05:51:06PM +0200, Jan Beulich wrote:
> On 06.04.2022 17:09, Roger Pau Monné wrote:
> > On Wed, Apr 06, 2022 at 02:47:38PM +0200, Jan Beulich wrote:
> >> On 06.04.2022 12:38, Roger Pau Monné wrote:
> >>> On Wed, Apr 06, 2022 at 10:13:41AM +0200, Jan Beulich wrote:
> >>>> On 23.03.2022 09:54, Roger Pau Monné wrote:
> >>>>> Hello,
> >>>>>
> >>>>> I was looking at implementing ACPI Cx and Px state uploading from
> >>>>> FreeBSD dom0, as my main test box is considerably slower without Xen
> >>>>> knowing about the Px states.  That has raised a couple of questions.
> >>>>>
> >>>>> 1. How to figure out what features to report available by OSPM when
> >>>>> calling the _PDC (or _OSC) ACPI method.  I'm confused by the usage of
> >>>>> this from Linux: it seems to be used to detect mwait support in
> >>>>> xen_check_mwait but not when calling _PDC (ie: in
> >>>>> acpi_processor_set_pdc).  I'm also not sure what the hypercall expects
> >>>>> the caller to provide.  Should buf[2] be set to all the possible
> >>>>> features supported by the OS and Xen will trim those as required?
> >>>>
> >>>> I'm afraid upstream Linux doesn't quite use this as originally
> >>>> intended. Consulting my most recent (but meanwhile quite old) forward
> >>>> port tree of XenoLinux that I still have readily available, I find in
> >>>> drivers/acpi/processor_pdc.c:
> >>>>
> >>>> static acpi_status
> >>>> acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
> >>>> {
> >>>> 	acpi_status status = AE_OK;
> >>>>
> >>>> #ifndef CONFIG_XEN
> >>>> 	if (boot_option_idle_override == IDLE_NOMWAIT) {
> >>>> 		/*
> >>>> 		 * If mwait is disabled for CPU C-states, the C2C3_FFH access
> >>>> 		 * mode will be disabled in the parameter of _PDC object.
> >>>> 		 * Of course C1_FFH access mode will also be disabled.
> >>>> 		 */
> >>>> #else
> >>>> 	{
> >>>> 		struct xen_platform_op op;
> >>>> #endif
> >>>> 		union acpi_object *obj;
> >>>> 		u32 *buffer = NULL;
> >>>>
> >>>> 		obj = pdc_in->pointer;
> >>>> 		buffer = (u32 *)(obj->buffer.pointer);
> >>>> #ifndef CONFIG_XEN
> >>>> 		buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
> >>>> #else
> >>>> 		op.cmd = XENPF_set_processor_pminfo;
> >>>> 		op.u.set_pminfo.id = -1;
> >>>> 		op.u.set_pminfo.type = XEN_PM_PDC;
> >>>> 		set_xen_guest_handle(op.u.set_pminfo.u.pdc, buffer);
> >>>> 		VOID(HYPERVISOR_platform_op(&op));
> >>>> #endif
> >>>> 	}
> >>>> 	status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL);
> >>>>
> >>>> 	if (ACPI_FAILURE(status))
> >>>> 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> >>>> 		    "Could not evaluate _PDC, using legacy perf. control.\n"));
> >>>>
> >>>> 	return status;
> >>>> }
> >>>>
> >>>> (This is a 4.4-based tree, for reference.)
> >>>>
> >>>> IOW the buffer is passed to Xen for massaging before invoking _PDC.
> >>>
> >>> Indeed.  I'm however confused by what should be pre-filled into the
> >>> buffer by the OS.  _PDC is about the processor driver power management
> >>> support, and none of this power management is done by the OS (I don't
> >>> plan to let FreeBSD do CPU power management when running as hardware
> >>> domain), so IMO passing an empty buffer and letting Xen fill it is the
> >>> correct thing to do, at least for the use-case in FreeBSD.
> >>
> >> I don't think that would work: Xen doesn't "fill in" the buffer, but
> >> merely alters individual bits. The buffer really is IN/OUT here for
> >> Xen.
> > 
> > Hm, but I have no idea what to put here from FreeBSD PoV, as said
> > FreeBSD will only use the processor object to upload the required data
> > to Xen, but won't attach any driver itself.
> > 
> > I've so far been providing an empty buffer to Xen and it does seem to
> > set the right flags so that the Cx and Px states can be fetched
> > afterwards.
> 
> Hmm, an empty buffer should result in -EINVAL from the hypercall.
> The first of the three uint32_t-s should be 1 (ACPI_PDC_REVISION_ID)
> and the 2nd (size) is supposed to be non-zero.

Right, I guess I was too simplistic here. I'm passing a buffer with
{1, 1, 0}, so no features added by the OS (because it won't attach any
driver to the processor object).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 16:42:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 16:42:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300062.511625 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc8j5-0008E7-IW; Wed, 06 Apr 2022 16:41:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300062.511625; Wed, 06 Apr 2022 16:41:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc8j5-0008E0-F6; Wed, 06 Apr 2022 16:41:47 +0000
Received: by outflank-mailman (input) for mailman id 300062;
 Wed, 06 Apr 2022 16:41:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc8j4-0008Dq-Fl; Wed, 06 Apr 2022 16:41:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc8j4-0000a3-DC; Wed, 06 Apr 2022 16:41:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nc8j3-0003tV-VQ; Wed, 06 Apr 2022 16:41:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nc8j3-0006Gi-Uz; Wed, 06 Apr 2022 16:41:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=K74hwZj5oS7QC4gVGQYv8BxIFSMiSLwaHMNwZq0HDqE=; b=TQvPoqVfF2R7tyGviMfm7MhNk7
	/KV+0AyM0hgoFBaLUE2kOzTBVdskWFTt+CmCnGFC8I5J8wxBaTe/LALsd16CiNgnerAydb5wfPgBA
	XbnksobQ7pAUYPm48QJ5yKJj3sClSsHNm5j3Vpgp6JE/kwpFybi0tpnRrF1WFtOT/WIw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169186-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169186: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=faed81ff3940b377a981af37a89161bddcacdaf5
X-Osstest-Versions-That:
    xen=ca304edd3ba8c19211107fd2e898249987557ce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 16:41:45 +0000

flight 169186 xen-4.14-testing real [real]
flight 169200 xen-4.14-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169186/
http://logs.test-lab.xenproject.org/osstest/logs/169200/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail pass in 169200-retest

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168482
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168506
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168506
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168506
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168506
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168506
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  faed81ff3940b377a981af37a89161bddcacdaf5
baseline version:
 xen                  ca304edd3ba8c19211107fd2e898249987557ce5

Last test of basis   168506  2022-03-10 14:16:31 Z   27 days
Failing since        168862  2022-03-25 17:36:39 Z   11 days   15 attempts
Testing same since   169186  2022-04-05 15:02:53 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jiamei Xie <jiamei.xie@arm.com>
  Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   ca304edd3b..faed81ff39  faed81ff3940b377a981af37a89161bddcacdaf5 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 17:24:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 17:24:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300072.511635 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc9No-0004Wa-Qq; Wed, 06 Apr 2022 17:23:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300072.511635; Wed, 06 Apr 2022 17:23:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc9No-0004WT-Nz; Wed, 06 Apr 2022 17:23:52 +0000
Received: by outflank-mailman (input) for mailman id 300072;
 Wed, 06 Apr 2022 17:23:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2ELh=UQ=citrix.com=prvs=088becc42=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nc9Nn-0004WN-JJ
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 17:23:51 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 52088294-b5ce-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 19:23:50 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52088294-b5ce-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649265830;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=qCFm7rZTSQ9dvwmFPGhB7Tg1OFCm4Ymp1oDTQlM4XeI=;
  b=P5Yvi7BnolqObZjOPbGwz8VxDkc0BKCvJX70j2CvC9RAq/QervMXKpGu
   NJQUEw+M31L+e8nF8vpeB+QhpcTRLLAvDT3FNyohu9Jx/gZONanjJoPdK
   zLVkbmAun44acwtW0+s8huzY3HtY+NZS/n6fHwaSQ8lC0pMcZfvmA4gHO
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68078984
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5IIdeKOtR/Wb7T7vrR09l8FynXyQoLVcMsEvi/4bfWQNrUp31jQDz
 TFOC23Ta6uKZDb0edEkb4rkp0tS78XUy94wTwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9
 dhfvL6odUAVF/fFqeMWdV5KFg0lIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQTa6BN
 5tJNVKDajz+Sgd2Eww8UagSv+OshVbSLTB6hwq88P9fD2/7k1UqjemF3MDuUuKNQcJZj0OJv
 FXs9m7yAgwZHNGHwD/D+XWp7sfUhj/yUo8WELy+99ZpjUeVy2hVDwcZPXOxrOOlkEe4V5RaI
 lYN5ys1haEo8QqgSdyVdx61vn+C+AIdUtx4Eusm5QXLwa3Riy6bG25CSDdCYd4nscYeRDo22
 1vPlNTsbRRwtJWFRHTb8a2bxRuiNC5QIWIcaCssSQoe/8KlsIw1lgjITNtoDOiylNKdMTP/2
 TeRtwAlmq4ey8UM0s2T/03Dgj+qjojESEgy/Aq/dmCv4x59ZYWlT5e18lWd5vFFRLt1VXHY4
 iJCwZLHqrlTU9fdz0RhXdnhApmU6uSMEiXgxmJGRZAQ8D+LvGymUdtPtWQWyFhSDu4IfjrgY
 Un2sAxX5YNOMHbCUZKbc75dGOxxk/G+SI2NuuT8K4MXP8MvLFPvEDRGPxb44oz7rKQ7fUjT0
 7+/eN3kM3sVAL8PINGeF7ZEiu9DKszTKAruqXHHI/aPjOL2iJ29E+5t3L6yggYRtv3sTOL9q
 Ys3Cidy408DONASmwGOmWLpEXgELGIgGbf9oNFNe+iIL2JOQT99WqaBneNxK9w6xMy5c9skG
 FnnBCe0L3Kl2xX6xfiiMCg/ONsDo74hxZ7EAcDcFQnxgCVyCWpexKwea4E2bdEaGB9LlpZJo
 w0+U5zYWJxnE22fkxxENMWVhNEyJXyD2FPVVwL4MWdXQnKVb1GQkjMSVlC0r3dm4+venZZWn
 oBMISuAGMBZGls7UJiNAB9tpnvo1UUgdCtJdxOgCrFulI/EquCG9wSZYicLHvwx
IronPort-HdrOrdr: A9a23:QwSYpaP4/L3N5sBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy
 nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM
 xbEpSWZueeMWRH
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="68078984"
Date: Wed, 6 Apr 2022 18:23:43 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v9 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <Yk3Mn1uJ8S279Fbk@perard.uk.xensource.com>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-2-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220401104713.22291-2-jane.malalane@citrix.com>

On Fri, Apr 01, 2022 at 11:47:12AM +0100, Jane Malalane wrote:
> Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and
> XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and
> x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization
> can subsequently be enabled on a per-domain basis.
> No such features are currently implemented on AMD hardware.
> 
> HW assisted xAPIC virtualization will be reported if HW, at the
> minimum, supports virtualize_apic_accesses as this feature alone means
> that an access to the APIC page will cause an APIC-access VM exit. An
> APIC-access VM exit provides a VMM with information about the access
> causing the VM exit, unlike a regular EPT fault, thus simplifying some
> internal handling.
> 
> HW assisted x2APIC virtualization will be reported if HW supports
> virtualize_x2apic_mode and, at least, either apic_reg_virt or
> virtual_intr_delivery. This also means that
> sysctl follows the conditionals in vmx_vlapic_msr_changed().
> 
> For that purpose, also add an arch-specific "capabilities" parameter
> to struct xen_sysctl_physinfo.
> 
> Note that this interface is intended to be compatible with AMD so that
> AVIC support can be introduced in a future patch. Unlike Intel that
> has multiple controls for APIC Virtualization, AMD has one global
> 'AVIC Enable' control bit, so fine-graining of APIC virtualization
> control cannot be done on a common interface.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> # tools

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 17:26:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 17:26:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300076.511647 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc9Qd-00058m-9M; Wed, 06 Apr 2022 17:26:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300076.511647; Wed, 06 Apr 2022 17:26:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc9Qd-00058f-6G; Wed, 06 Apr 2022 17:26:47 +0000
Received: by outflank-mailman (input) for mailman id 300076;
 Wed, 06 Apr 2022 17:26:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2ELh=UQ=citrix.com=prvs=088becc42=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nc9Qb-00058V-Lh
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 17:26:45 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b9dd0043-b5ce-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 19:26:44 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9dd0043-b5ce-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649266004;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=6h5mm5ru4URX4F7cJjAauc2rtb1g8wTivre+Nbf3HDc=;
  b=JWiIBSx3MbD1mQEFssbZPerAMDJEQmR2BhamtBWTZuYbDbE+T0Hf1lbI
   uDCYnVJ3j4QsRl+iz/pWTvMVsGlBmmFiL0ze+1m078JJBY1R/ZW3M/NN9
   lNbkNVFUC2MIfL1Zj8t5GwSqpPDR0+o/lANmZfdbO6GMoUYPXPAQMUgAL
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68589586
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:apXQQ6oeVKSp2G+7Yu597iDcUZdeBmL7ZRIvgKrLsJaIsI4StFCzt
 garIBnVaayPMGPyfNt3YdznoxhV7ZLdzYJjTwVp+S1nQ3saoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Y2q+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBBb+LoM43fB9jSjBjNPR8+uLpBnelmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY
 qL1bBIxPEmQMkAfZD/7Drpin/iotlm4SwQbpW/Ou7Fn+TmQ3S5Ihe2F3N39JYXRGJQ9clyjj
 nnd423zDxUeNdqe4TmI6HShgqnIhyyTcIAPELy18NZ6jVvVwXYcYDUoUl+8rei8m1SJcdtVI
 EwJ+QIjtaE3skesS7HVUxSmrVaesxUbWt4WFPc1gCmSzoLE7gDfAXILJhZRZdpjuMIoSDgC0
 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESofIHIGZCQEZRAY+NSlq4Y25jrNQcxkC7WdlcDuFHf7x
 DXikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzj7FGVqPxCx/X9e0eoXx01qGw9FPNq/MGzFto
 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUxRsd8rlxB71bmJNkNu28meC+FJ+5eIVfUj
 FnvVRS9DXO5FF+jdudJbo24EKzGJoCwRI2+Bpg4gjejC6WdlTNrHgkzPSZ8PEi3ySDAdJ3T3
 7/BL65A6l5AVMxaIMKeHbt17FPS7nlWKZnvbZ761Q+79rGVeWSYT7wIWHPXMLxotfPY8FWFo
 4kEXydv9/m5eLegCsUw2dRNRW3m0FBhXcymwyCpXrDrzvVa9JEJVKaKnOJJl31NlKVJjObYl
 kxRqWcDoGcTcUbvcF3QAlg6MeuHdc8m8RoTYHx9VX71iiNLSdv+s88im24fIOBPGBpLlqUvE
 ZHouqyoX5xyd9gw029EN8Og89U+Kk/DaMDnF3PNXQXTtqVIH2ThkuIItCOznMXSJkJbbfcDn
 oA=
IronPort-HdrOrdr: A9a23:nfdMKaHVQ4FSTEeMpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5
 uIGJIeNDSfNzdHsfo=
X-IronPort-AV: E=Sophos;i="5.90,240,1643691600"; 
   d="scan'208";a="68589586"
Date: Wed, 6 Apr 2022 18:26:38 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v9 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <Yk3NTuVKK6sPfBZm@perard.uk.xensource.com>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-3-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220401104713.22291-3-jane.malalane@citrix.com>

On Fri, Apr 01, 2022 at 11:47:13AM +0100, Jane Malalane wrote:
> Introduce a new per-domain creation x86 specific flag to
> select whether hardware assisted virtualization should be used for
> x{2}APIC.
> 
> A per-domain option is added to xl in order to select the usage of
> x{2}APIC hardware assisted virtualization, as well as a global
> configuration option.
> 
> Having all APIC interaction exit to Xen for emulation is slow and can
> induce much overhead. Hardware can speed up x{2}APIC by decoding the
> APIC access and providing a VM exit with a more specific exit reason
> than a regular EPT fault or by altogether avoiding a VM exit.
> 
> On the other hand, being able to disable x{2}APIC hardware assisted
> virtualization can be useful for testing and debugging purposes.
> 
> Note:
> 
> - vmx_install_vlapic_mapping doesn't require modifications regardless
> of whether the guest has "Virtualize APIC accesses" enabled or not,
> i.e., setting the APIC_ACCESS_ADDR VMCS field is fine so long as
> virtualize_apic_accesses is supported by the CPU.
> 
> - Both per-domain and global assisted_x{2}apic options are not part of
> the migration stream, unless explicitly set in the configuration file,
> so it is safe to migrate a guest that doesn't have assisted_x{2}apic
> set in its config file between hosts that have different support for
> hardware assisted x{2}APIC virtualization.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> # tools

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 17:28:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 17:28:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300081.511658 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc9SJ-0005rV-Mp; Wed, 06 Apr 2022 17:28:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300081.511658; Wed, 06 Apr 2022 17:28:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc9SJ-0005rO-I2; Wed, 06 Apr 2022 17:28:31 +0000
Received: by outflank-mailman (input) for mailman id 300081;
 Wed, 06 Apr 2022 17:28:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t0fM=UQ=gmail.com=konishi.ryusuke@srs-se1.protection.inumbo.net>)
 id 1nc9SH-0005rE-Qw
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 17:28:29 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f90b4dbe-b5ce-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 19:28:28 +0200 (CEST)
Received: by mail-lf1-x136.google.com with SMTP id t25so5293726lfg.7
 for <xen-devel@lists.xenproject.org>; Wed, 06 Apr 2022 10:28:28 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f90b4dbe-b5ce-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=WJLYFFwKJzu0AzBejzceyC93Fh4AhvIk3A/MNZXzKIU=;
        b=nHoFYmIVcbUdYBuRBczLdRhO5AcYZ6GHHFtKpS9G1n5vNIpBGLipmKmQ40hQnwfBEK
         9YcCx5HGe8T4NG1UPywpqZKblDsiU8Uam6EvTYaei53mUEV7gX/X6QEIMPDVNdTe1RsC
         lSqUADllCjDlRJ3aqfDHj4gGsZ5WvTndElsOvm3ukXbURNWbOjm9tS3FKy9TW5JIte+s
         iqchodtdlLO+0839AsHapTHL+am4rmkQFqKuweIuQiuTq0iA/dxkHoEkiJl793SmXbAL
         d6FIVbXVTWtg6j4nPkHK8I7vb1+rBuBMN5T4ZVmgoa+qulAgS9/S0AV92hnwAdWJS/in
         gNUw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=WJLYFFwKJzu0AzBejzceyC93Fh4AhvIk3A/MNZXzKIU=;
        b=WXsY2gtasXSiyH4Slf536ZD3xwPlzlB/OCVMMalzpgm0I3chi/LDvekdFmmsZUOQo9
         8ckDZKh4rb16EobtcY8uK9KMA4BbQxRkPqBiWjdnpNhnq0/9Ncr5fgkCkkUb1t9nqcUY
         LZbbAFqb7g70+A1RVNuzN/ASpUCYYW89+EocO97wmONJwENLvHv0I7UHxZ6h+OV2QA8E
         Q+1lDIX3l22Z1Dqgh3GisuFpCcfEE274KL+WCNzP/IOXOc8z4x+rk5O08Xfhdhbxv7ZI
         f8MMQYTItnuazY3x7DvXn0otYXpkeiaQ53jKMReSoFJLKtv6XTWEpUm94uKFYOe5v6BT
         BGlA==
X-Gm-Message-State: AOAM533kkIfxoOj9MVl5O9I02Ea5JMsME5z/bY23ajtkAUlW9YxwpcvO
	EX0A/ZlGgNfQC6HybE1KwDqF4xwZKV2dzZ5YcvQ=
X-Google-Smtp-Source: ABdhPJxvT7YhfWN8QbCVz4oydCsKwT/zbXQ5089WXaSZlqzdjbFflulVc086iBmKtewP4KtbC66vp+jW8qrWjcRFTmg=
X-Received: by 2002:ac2:5f4d:0:b0:43e:da3e:4529 with SMTP id
 13-20020ac25f4d000000b0043eda3e4529mr6768924lfz.627.1649266108188; Wed, 06
 Apr 2022 10:28:28 -0700 (PDT)
MIME-Version: 1.0
References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-24-hch@lst.de>
In-Reply-To: <20220406060516.409838-24-hch@lst.de>
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date: Thu, 7 Apr 2022 02:28:15 +0900
Message-ID: <CAKFNMokGOma3pvHdEsnsjuKgW+jpYX9zx8fWwJWyeKuCpKz-YQ@mail.gmail.com>
Subject: Re: [PATCH 23/27] block: add a bdev_max_discard_sectors helper
To: Christoph Hellwig <hch@lst.de>
Cc: Andreas Gruenbacher <agruenba@redhat.com>, Jens Axboe <axboe@kernel.dk>, 
	device-mapper development <dm-devel@redhat.com>, linux-xfs@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, 
	linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, 
	ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, 
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, 
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, 
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, 
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, 
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, 
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, 
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, 
	linux-nilfs <linux-nilfs@vger.kernel.org>, ntfs3@lists.linux.dev, 
	ocfs2-devel@oss.oracle.com, Linux MM <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 6, 2022 at 11:05 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Add a helper to query the number of sectors support per each discard bio
> based on the block device and use this helper to stop various places from
> poking into the request_queue to see if discard is supported and if so how
> much.  This mirrors what is done e.g. for write zeroes as well.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
...
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 16e775bcf4a7c..7d510e4231713 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -829,9 +829,7 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
>  }
>
>  /*
> - * Check if the underlying struct block_device request_queue supports
> - * the QUEUE_FLAG_DISCARD bit for UNMAP/WRITE_SAME in SCSI + TRIM
> - * in ATA and we need to set TPE=1

> + * Check if the underlying struct block_device request_queue supports disard.
>   */

Here was a typo:

 s/disard/discard/

On Thu, Apr 7, 2022 at 12:19 AM Andreas Gruenbacher <agruenba@redhat.com> wrote:
> If I'm misreading things, could you please document that
> bdev_max_discard_sectors() != 0 implies that discard is supported?

I got the same impression.   Checking the discard support with
bdev_max_discard_sectors() != 0 seems a bit unclear than before.

Thanks,
Ryusuke Konishi


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 17:39:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 17:39:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300086.511669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc9co-0007QH-MX; Wed, 06 Apr 2022 17:39:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300086.511669; Wed, 06 Apr 2022 17:39:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nc9co-0007QA-J4; Wed, 06 Apr 2022 17:39:22 +0000
Received: by outflank-mailman (input) for mailman id 300086;
 Wed, 06 Apr 2022 17:39:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vAr8=UQ=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1nc9cm-0007Q2-UW
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 17:39:21 +0000
Received: from sonic307-55.consmr.mail.gq1.yahoo.com
 (sonic307-55.consmr.mail.gq1.yahoo.com [98.137.64.31])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7b5d0e1b-b5d0-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 19:39:18 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic307.consmr.mail.gq1.yahoo.com with HTTP; Wed, 6 Apr 2022 17:39:16 +0000
Received: by kubenode506.mail-prod1.omega.ne1.yahoo.com (VZM Hermes SMTP
 Server) with ESMTPA ID e883bea2c2e34d2ecd8f0cd69bbd1f21; 
 Wed, 06 Apr 2022 17:39:13 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b5d0e1b-b5d0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1649266756; bh=3PeypdmH4glC5ef2u2jFBuZ4aBnsPgvGQpKC5zTBAW0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=hSMQ7Ulw9w57Tg+yXFXDsRacPOIhTL+0+cQ4kMvlm3ISzi9r8ZbLzM43prHslg1p0YW3v+NTjFv9XRoh62twhLiFiuAvlldb7p5vEeYbtuBeMCaXLk6Dl1pJEV40jTK9Idajm7fSOj2haKdrpByjNdkLTY5HVfofUtMRBe39fOsS6Crniun1o0iERQJdXHjVVfHPjuFhc0P5ZSqWZ8ZxYEaQJtvfa7qL1/3uEZWRkUpkwnqqL1BYrMb0Rdq2pt/31DQBN/RLma/cW6pEplciAJpUQIhntoAG+VgBM6htgw6sFPCup5lw/cqgRknnQqyhlS019k5a5+fa8HWJZPGetA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649266756; bh=/1yH25az6C0Z9qbPNPHGtYWnYU/r0UdmvlENNLV3FzP=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=s50eZXRt1DiSGRU9rpsMkAjxsDlMie7QlJJ5k16Z/BnSDOph8NhPzdRcnCR4sEMm2qiNky6SktAuw594xftt+bvd5xT8+GJX+82tGerqF5JLq/36SnEXpJIcNYx0uI2EUN+l2nbunAe7DlYLn8uZwEOVzuz4uyB+okjC+mGBGfq11oqJctq8eYZU8R08uGAVYn8lV66jKCIwIqaP/rY9rfIfoAL31RibZKby3W3gyOQ27glB8fSNSrxS5mA3wV8FngtmrHEZK0JYLvopkITFvfp/NuMhIIY6iRnr/VEdmo763sL7hyagGuH4adkWCn24FYd/bMn1+N3355drXaXEbg==
X-YMail-OSG: 1ETbDkUVM1nqJp3AF7H1DmYHWfK9Bf3vmarGOcN0A2t40TEAKGrrXXqSDrHWyVZ
 yuBdPZoWP0PERcJzVJLjDWepr3zx91MG_t_gzI7Evw998_7VPs84LM9pNztSJY6_VPjd3bB5J132
 2VIV3ekhoUOpcxYrZD5Nj_UGFP5hOP7S3MqQpDyvMmvq5Cuas8EPM_FzT2JVWrWIdnFsxicNHWFr
 Skv4VTKdCbLRviYOA3Jjhkouv2Cnlam.Byfymt9dYHEQXyg7.waEzaATeHAQdc5Pk78o0R.cHRor
 OqJ3M4rdmCuwKcXfhhLAz9xAC4zJvDIuQuU31u9pu1ucOifrdnBB8iQkj0YzbroC81nKiG7HpYno
 zrZYZlG5WFRKsxD4OVZsNIvhmOovgF82JDI7rYhdIAuBIZQAmMQBCLjHjQtyEg1BmufF_HBGBTgY
 ODqoXvtI8q96__7pWDQxD9Qwtdjuvf15I5.r5ahtz7_fzmxkkbsSQ25HlQv9W0lWdDd40hUGQ15S
 NLlvrEXhdDmdRGxqW._3yHSs8dsR2unhNNQCBoLc7O4EGLUlYni2SMyc70h1_qmPzelmQRnr19oY
 Lk4BAB6EjCmtdh115JkSJ6Ih.xH7B2xOfm_jJWGn8CgbusUonFBTBKtsmHs5VD_TKzNtClH52tlG
 WW5C1yruiOdso4IyaDP4vZln.xXo6piEM.v0wKVnHNYhN1tpITuUubRH774Jhh_5dEEEiHvRp17W
 KZCCsL2LEgQDUZz1bYHnAD3xfDKbd.hIQt3_IBQrVI7Nf96HBP1Ub3MIlaJvwTB5kxCWoie83vBj
 6gj67eNbBjWjEHhM2lN53elybAgy9w9DySWgIjlzlJ2nxV0_wff9pTcqpf9QPMzZOIrRsQdxDrQE
 OMulWFd8U0wTjXLNc4ltpN4NxiIBlqCsBVRM8IMLjTNX_LW9eyTD_efp7I9XQSoPzl3CzgA_w8qO
 UrvJzWullRu._qI3juWM9iczwgN9Kf5q7ZPM52cVDjipkT5m0d6OTB5_4VBQnMIFZsrOizkrB.1y
 pXXrcqEFhdrP.kVxsY8uAd3x_1WC6hUFx8kZglMU.xQSEQ_FJHlW1.n58Z93xgzkc471R60ONYHq
 x2.CXGi5yjSeXxkARE_TyGEZcpSSwTeZR5_aI3QDpaY9Zrru0Wh38S2BkAb51XILFnxoIuo.VX.x
 qOdjYz6PMllfdRV.HTifm3a_6vJIVEqDhIKNlQtKw0aHUfh3hRnudwzWtkLSSux849rUCqRspO.3
 gNdicTfqvAnO8QVeWNHS2UqSjXx5iTMnMkSk9ITMA_o8Xq0PwHC6JhkCQOi9PSf4YjMsjnM5zSIf
 uIN_tgovaGe9q.ukVd1bKhFhyqAH.fWtMnTEqiC2wO6sS0opMKmc3dgdx3TjOiAoTLPoqHu3.wYZ
 dYdutrIC.0XGVNUb9mbokKs6DzmVhSVtLrYUBGrcwtBIGM2rd0ogD5ggMJa7lQDkpUK86406haBC
 52YEkBWcHXN.wWVmXYHuUyiAlov4DDZtz_sjpi1lGK2YpNTCf2WE1HQoeojxYwnw7KryBLqvbGEZ
 4AkVwFFcyypCChVWZ5Rld.iJNHc5e6DgD702a9mB9AXZvspGfTFnMsdVoK2ErH_1C5JxYzsOY1up
 DTyFAC5Rm3_lmzm_ZX5orNmhZOxgesK7LWUyIGlofpBC_NnyyBiSZ0oCcRv0YMg0ode55s8wBYI6
 b0CWIGjnv.ekRkhlxmyztKkbd3GwDe0ek8qkAEvDAvI3zckGO0PJNGou695fGNWEvTfHmzTU8kNt
 a3g4IVw0u4LX5HZx_MnDusgwv6vUHmcPcNx4xOUhoYzSK0HrpgyTKNiIGgsJOKdf6SQO72FB52W.
 DJaf25JADPdg1gV6ALi.TF_AdaCeu.vKV6IiQdyLflzZvb5rN_DBrCHeco1dxzb1FNAcqWo6Wp_x
 VhBf5ReurQp6NzHxeuDimXBspIAWIwt28jrewrk93AnpKqBZZmJbr1sgGdPkRFDyQ.ww4Bo1KAm_
 qT_EI2KTIgp_mQZLnMmkFnx2_1uqvFKF71kG_piZZ0vI9mVE63jQ3qpxbmKdLXyV4U5VMqK58iXt
 NopRbU5ApVXgCWgYDxSg1iKFK6079ZlP7vM3AfPc6l20uhUozSLqkDtdsldfn.YzqpNv.9iJgVV9
 gvAW1.VTswP3CMsOKQmBrYccfjcCfYo4MG9iSD5ICEmu5s6C2Kc1vJfwT4V3z1pYaw.qVq5k7WS9
 RQd36HSn6
X-Sonic-MF: <brchuckz@aim.com>
Message-ID: <a899ee6d-14e6-9218-2f8d-a98d5f3bf6b2@netscape.net>
Date: Wed, 6 Apr 2022 13:39:11 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access
 to Intel IGD opregion
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Jan Beulich <jbeulich@suse.com>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz.ref@netscape.net>
 <b62fbc602a629941c1acaad3b93d250a3eba33c0.1647222184.git.brchuckz@netscape.net>
 <78ce5809-8df4-c94e-4313-fffb1b86b771@suse.com>
 <CAKf6xpsN+uJ=AyxtrnOrQrynFL=dwC=DdT7DHnK=wx9UFtdUDQ@mail.gmail.com>
 <d13f08dd-6575-6215-80e5-9d5b2c85b923@netscape.net>
 <5d14eeb8-038f-e99a-31b8-f6b3b562c2c4@netscape.net>
 <CAKf6xpsNsYM=fHb4DwiLmsH+Nz+0UF5RvjWr=GeYo5d+6Rmi_Q@mail.gmail.com>
From: Chuck Zmudzinski <brchuckz@netscape.net>
In-Reply-To: <CAKf6xpsNsYM=fHb4DwiLmsH+Nz+0UF5RvjWr=GeYo5d+6Rmi_Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 4173

On 4/6/22 9:10 AM, Jason Andryuk wrote:
> On Tue, Apr 5, 2022 at 9:31 PM Chuck Zmudzinski <brchuckz@netscape.net> wrote:
>> Correction (sorry for the confusion):
>>
>> I didn't know I needed to replace more than just a
>> re-built i915.ko module to enable the patch
>> for testing. When I updated the entire Debian kernel
>> package including all the modules and the kernel
>> image with the patched kernel package, it made
>> quite a difference.
>>
>> With Jason's patch, the three call traces just became a
>> much shorter error message:
>>
>> Apr 05 20:46:18 debian kernel: xen: --> pirq=16 -> irq=24 (gsi=24)
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: [drm] VT-d active for
>> gfx access
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: vgaarb: deactivate vga
>> console
>> Apr 05 20:46:18 debian kernel: Console: switching to colour dummy device
>> 80x25
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: [drm] DMAR active,
>> disabling use of stolen memory
>> Apr 05 20:46:18 debian kernel: resource sanity check: requesting [mem
>> 0xffffffff-0x100001ffe], which spans more than Reserved [mem
>> 0xfdfff000-0xffffffff]
>> Apr 05 20:46:18 debian kernel: caller memremap+0xeb/0x1c0 mapping
>> multiple BARs
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: Device initialization
>> failed (-22)
>> Apr 05 20:46:18 debian kernel: i915 0000:00:02.0: Please file a bug on
>> drm/i915; see
>> https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs
>> for details.
>> Apr 05 20:46:18 debian kernel: i915: probe of 0000:00:02.0 failed with
>> error -22
>> --------------------- End of Kernel Error Log ----------------------
>>
>> So I think the patch does propagate the error up the
>> stack and bails out before producing the Call traces,
> Thanks for re-testing.
>
> I'm a little surprised you still had output from the VM & display with
> the i915 driver not binding.  I guess Linux fell back to another VGA
> or Framebuffer driver for the display.

By looking at journal entries in the guest, it is clear the Xorg
driver fell back from the kms modesetting driver to the vesa
driver, as shown by the following journal entries.

When guest can access opregion gdm:

Apr 05 20:42:45 debian /usr/libexec/gdm-x-session[1226]: (II) modeset(0):
  Serial No: LX1AA0044210
Apr 05 20:42:45 debian /usr/libexec/gdm-x-session[1226]: (II) modeset(0)
: Monitor name: Acer H236HL

When guest cannot access opregion:

Apr 05 20:46:22 debian /usr/libexec/gdm-x-session[1164]: (II) VESA(0):
  Serial No: LX1AA0044210
Apr 05 20:46:22 debian /usr/libexec/gdm-x-session[1164]: (II) VESA(0):
  Monitor name: Acer H236HL

But as I said when I tried to login to a Gnome session,
the system hung, and there are no journal entries captured
in either the Dom0 or the guest, so it is hard to tell what
happened. I think maybe the full Gnome session, as opposed
to the gdm3 display manager, did not fall back to the Xorg
vesa driver and when it tried to use the Xorg modesetting
driver it caused the system to hang because the modesetting
driver uses KMS and probably tried to use the i915 module
which was not initialized correctly due to the inability to
access the opregion.

I also noted in an earlier message in this thread that when
the guest cannot access the opregion, the guest overwrites
the register that contains the mapped opregion address for
the guest, which is provided for the guest by the Qemu
device model, with the invalid value of 0xffffffff.

When the gnome session manager started the session, it
apparently caused the i915 module to try to access the
opregion at the invalid address 0xffffffff and thus caused
the system to hang, as shown in the journal entry I posted
yesterday:

Apr 05 20:46:18 debian kernel: resource sanity check: requesting
[mem 0xffffffff-0x100001ffe], which spans more than Reserved
[mem 0xfdfff000-0xffffffff]

This is a request by the guest for 2 pages, which is the
size of the opregion, but it is using the invalid address
0xffffffff for the opregion address. So although this resource
sanity check failed, the system still hung later on when the
user tried to login to the gnome session.

Regards,

Chuck


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 18:03:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 18:03:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300090.511679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncA00-0002Xd-JT; Wed, 06 Apr 2022 18:03:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300090.511679; Wed, 06 Apr 2022 18:03:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncA00-0002XW-Gd; Wed, 06 Apr 2022 18:03:20 +0000
Received: by outflank-mailman (input) for mailman id 300090;
 Wed, 06 Apr 2022 18:03:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c7vZ=UQ=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nc9zz-0002XP-Mr
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 18:03:19 +0000
Received: from MTA-15-3.privateemail.com (mta-15-3.privateemail.com
 [198.54.122.111]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d5788d6d-b5d3-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 20:03:18 +0200 (CEST)
Received: from mta-15.privateemail.com (localhost [127.0.0.1])
 by mta-15.privateemail.com (Postfix) with ESMTP id DD4C11800084
 for <xen-devel@lists.xenproject.org>; Wed,  6 Apr 2022 14:03:15 -0400 (EDT)
Received: from mail-oi1-f182.google.com (unknown [10.20.151.151])
 by mta-15.privateemail.com (Postfix) with ESMTPA id B717D18000A2
 for <xen-devel@lists.xenproject.org>; Wed,  6 Apr 2022 14:03:15 -0400 (EDT)
Received: by mail-oi1-f182.google.com with SMTP id e4so3223662oif.2
 for <xen-devel@lists.xenproject.org>; Wed, 06 Apr 2022 11:03:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5788d6d-b5d3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1649268195;
	bh=iTfs/op7/U89tLYpzIkGPrMwkOtyDHBrtk9BR0UDXgU=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=nZZMYViWEysBDPgbEj7Xk5Y6Zp85n0GH9z+rDZeGfn2TcB6fk1Yn33XXmO/R9bh07
	 g/F/lxVJCQI4282b6n8U9dnN7QiFzNTcPxw/TniVWLPk1EKe7rfis/IC1UwfBjbeqZ
	 eRCqNe5fjNJRyLi/ey0J1TdRgvRhruqlYkQPkyGEMEQhGtOmRUvnG2/PhldYW7UTJf
	 qURnEkypqTDK9tJHVwmWRbq39kb24s85q5qNmAeryaoaWdKI+U/r9QYMWZ3W6aO9QR
	 mVotL8omXITuCkMeOUHbkrgUpfarT0R7erDadDlcwOAeqodhL1xUPNa3qbqqu+WpNS
	 tGStQ8cTRAZ/g==
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1649268195;
	bh=iTfs/op7/U89tLYpzIkGPrMwkOtyDHBrtk9BR0UDXgU=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=nZZMYViWEysBDPgbEj7Xk5Y6Zp85n0GH9z+rDZeGfn2TcB6fk1Yn33XXmO/R9bh07
	 g/F/lxVJCQI4282b6n8U9dnN7QiFzNTcPxw/TniVWLPk1EKe7rfis/IC1UwfBjbeqZ
	 eRCqNe5fjNJRyLi/ey0J1TdRgvRhruqlYkQPkyGEMEQhGtOmRUvnG2/PhldYW7UTJf
	 qURnEkypqTDK9tJHVwmWRbq39kb24s85q5qNmAeryaoaWdKI+U/r9QYMWZ3W6aO9QR
	 mVotL8omXITuCkMeOUHbkrgUpfarT0R7erDadDlcwOAeqodhL1xUPNa3qbqqu+WpNS
	 tGStQ8cTRAZ/g==
X-Gm-Message-State: AOAM530PPQ+Yr5jhoasdyMtK1dBFryKNVe2DFeVF5MCL3CPPntoPNhWp
	bmNPfZbcTOVfzxD7LLbSXboPylL33O9l27UIY3E=
X-Google-Smtp-Source: ABdhPJzQQME4wilDi/pINj6U4XzVFfMRkt0eyusvJzWKCGHeRDKpBwPiBU7EbZh/L6ltHTysqePOxUSCFGuNHMJVGVw=
X-Received: by 2002:aca:d12:0:b0:2ee:f684:bd4b with SMTP id
 18-20020aca0d12000000b002eef684bd4bmr4231524oin.128.1649268195101; Wed, 06
 Apr 2022 11:03:15 -0700 (PDT)
MIME-Version: 1.0
References: <d1a7a48fa2d46c6a6cbf8f93926a8839aaba92e3.1649256753.git.tamas.lengyel@intel.com>
 <73e6b45525e1be753d3e243d42ad632bbc5690b0.1649256753.git.tamas.lengyel@intel.com>
 <9f593bdb-d95a-4705-d24a-f8767d69a09f@suse.com>
In-Reply-To: <9f593bdb-d95a-4705-d24a-f8767d69a09f@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Wed, 6 Apr 2022 14:02:39 -0400
X-Gmail-Original-Message-ID: <CABfawhn=-avd30QieqJ9gWsJMegRYcOV23vGvYeQcaoA-Cu-VQ@mail.gmail.com>
Message-ID: <CABfawhn=-avd30QieqJ9gWsJMegRYcOV23vGvYeQcaoA-Cu-VQ@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] x86/monitor: Add new monitor event to catch all vmexits
To: Jan Beulich <JBeulich@suse.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <JGross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
	Alexandru Isaila <aisaila@bitdefender.com>, Petre Pircalabu <ppircalabu@bitdefender.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, 
	xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Wed, Apr 6, 2022 at 11:14 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 06.04.2022 16:58, Tamas K Lengyel wrote:
> > --- a/xen/arch/x86/hvm/monitor.c
> > +++ b/xen/arch/x86/hvm/monitor.c
> > @@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
> >      return monitor_traps(curr, true, &req) >= 0;
> >  }
> >
> > +int hvm_monitor_vmexit(unsigned long exit_reason,
> > +                       unsigned long exit_qualification)
> > +{
> > +    struct vcpu *curr = current;
> > +    struct arch_domain *ad = &curr->domain->arch;
> > +    vm_event_request_t req = {};
> > +
> > +    ASSERT(ad->monitor.vmexit_enabled);
> > +
> > +    req.reason = VM_EVENT_REASON_VMEXIT;
> > +    req.u.vmexit.reason = exit_reason;
> > +    req.u.vmexit.qualification = exit_qualification;
> > +
> > +    set_npt_base(curr, &req);
> > +
> > +    return monitor_traps(curr, !!ad->monitor.vmexit_sync, &req);
>
> vmexit_sync is a single-bit bitfield; I don't see the need for using
> !! here, even more so that the respective parameter of monitor_traps()
> is "bool" anyway.

Ack.

>
> > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > @@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
> >          }
> >      }
> >
> > +    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
> > +    {
> > +        int rc;
> > +        __vmread(EXIT_QUALIFICATION, &exit_qualification);
> > +
>
> Nit: Please swap blank and non-blank lines here.

Ack.

>
> > +        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
> > +        if ( rc < 0 )
> > +            goto exit_and_crash;
> > +        else if ( rc )
>
> Nit: No need for "else" here, just if() suffices after "goto".

Ack.

>
> > +            return;
> > +    }
> > +
> >      /* XXX: This looks ugly, but we need a mechanism to ensure
> >       * any pending vmresume has really happened
> >       */
>
> A few lines down from here failed VM entry is being handled? Wouldn't
> you want to place your code after that? And wouldn't you want to avoid
> invoking the monitor for e.g. EXIT_REASON_EXTERNAL_INTERRUPT,
> EXIT_REASON_MCE_DURING_VMENTRY, and at least the NMI sub-case of
> EXIT_REASON_EXCEPTION_NMI?

No, the placement is necessary to be where it is to be able to collect
information about all vmexits, no matter the root cause. Failed
vmentry & mce during vmentry would be interesting exits to see if we
can induce during fuzzing from within the guest (indicating some
serious state corruption) while the external interrupt and nmi cases
are for the most part just ignored and the fuzz-case restarted, but
could be still interesting to collect their frequencies. So in effect,
we want to avoid Xen hiding any of the events from the monitoring
agent by handling it one way or another and just let the agent decide
what to do next. We most certainly want to avoid Xen crashing the VM
for us.

Tamas


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 18:27:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 18:27:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300095.511690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncAN5-0005MB-Lj; Wed, 06 Apr 2022 18:27:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300095.511690; Wed, 06 Apr 2022 18:27:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncAN5-0005M4-Is; Wed, 06 Apr 2022 18:27:11 +0000
Received: by outflank-mailman (input) for mailman id 300095;
 Wed, 06 Apr 2022 18:27:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t0fM=UQ=gmail.com=konishi.ryusuke@srs-se1.protection.inumbo.net>)
 id 1ncAN4-0005Ly-BT
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 18:27:10 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2af36baa-b5d7-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 20:27:08 +0200 (CEST)
Received: by mail-lj1-x234.google.com with SMTP id c15so4383533ljr.9
 for <xen-devel@lists.xenproject.org>; Wed, 06 Apr 2022 11:27:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2af36baa-b5d7-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=14ZeLO2m8aH+YS1qjEoT4F85qJZ7QGK39BPrvGxvzsc=;
        b=FPNoADLl+t1rHvkAR4xL1rOVDAlhpOOGr+u25kx4PQUes2dgJf3VMVWx4RqhVzv0kX
         5gpTEucABhvBe61J4YvVZaXJLzFCw916y+PHHhJE/Wk03gJslw060TSXfyhR1UHGywmM
         tUGOjgO/tvv35BrogxJk0r3s4DdOfMfzpXGFBBL0VZ4D2j63zFHyR97t/y7gV0AKAs1R
         hJGS19Gw9w9127XdxMP2Q/fLKeeUGVCZ+7PdNdPrfLy3sdigpvNPW6LqW6+cm1sSbapN
         l5bvXsAYagi8cRbMUqlCJ8BHK39gp8H12JfHpjgHeRLKmO5URsKxvm9vLNu+PpYSBxuq
         Nhnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=14ZeLO2m8aH+YS1qjEoT4F85qJZ7QGK39BPrvGxvzsc=;
        b=123k5pACJxgcCpjaGepUff6RniN31/YpVI36tZtXGilepAY1apPR4t7T7bmP2JbPlL
         pb1O4YwQp88bhPj05BDtmEU1lLMoL/GsXmiwKUtyCz12Ozuba9SsqPF0CPT8lQ1dwOVK
         h0MknVc/4CPsW+LJOWonjAC5LZ0EPo6vdmwWnpkRSt/y7Q+8ueOrEYQixBMKZqB0iexH
         LULw5id0RC8QILbYjY0i+0aW0J0XfRlL952U8n8gx9CxVcuXme7IEDkMre8XvGelq8lT
         MhacyVqX8YEduNtukhVyxmC9Z+VcYebVn+d9iPrezR7xNrjT3cN19JM2+KMC7+QQdeyq
         LcMw==
X-Gm-Message-State: AOAM531TbxiqU16cWV6PGWLf3PfOvqOGA3XpMakjXdCPPI3AzLO0/wfF
	pe+XkfMdECr7vnkciUftcJGDq4MHXGjFQLkE+fI=
X-Google-Smtp-Source: ABdhPJyXW8VZEbBsOkirhtMJbbJG7kJrgPict1d8+Pn0N6NHsEhNVlSmQmy+z/FM0XLhigCLmUpRJ5pzX/36OC/hFtE=
X-Received: by 2002:a2e:b008:0:b0:249:83ad:ab65 with SMTP id
 y8-20020a2eb008000000b0024983adab65mr6004527ljk.350.1649269627731; Wed, 06
 Apr 2022 11:27:07 -0700 (PDT)
MIME-Version: 1.0
References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-25-hch@lst.de>
In-Reply-To: <20220406060516.409838-25-hch@lst.de>
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date: Thu, 7 Apr 2022 03:26:55 +0900
Message-ID: <CAKFNMom3wHtwHyQ0f7gTF+hSNCc716Syn5EADtzb+Sx1iSUiEA@mail.gmail.com>
Subject: Re: [PATCH 24/27] block: add a bdev_discard_granularity helper
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, device-mapper development <dm-devel@redhat.com>, linux-xfs@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, 
	linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, 
	ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, 
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, 
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, 
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, 
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, 
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, 
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, 
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, 
	linux-nilfs <linux-nilfs@vger.kernel.org>, ntfs3@lists.linux.dev, 
	ocfs2-devel@oss.oracle.com, Linux MM <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 6, 2022 at 11:06 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Abstract away implementation details from file systems by providing a
> block_device based helper to retreive the discard granularity.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/blk-lib.c                     |  5 ++---
>  drivers/block/drbd/drbd_nl.c        |  9 +++++----
>  drivers/block/drbd/drbd_receiver.c  |  3 +--
>  drivers/block/loop.c                |  2 +-
>  drivers/target/target_core_device.c |  3 +--
>  fs/btrfs/ioctl.c                    | 12 ++++--------
>  fs/exfat/file.c                     |  3 +--
>  fs/ext4/mballoc.c                   |  6 +++---
>  fs/f2fs/file.c                      |  3 +--
>  fs/fat/file.c                       |  3 +--
>  fs/gfs2/rgrp.c                      |  7 +++----
>  fs/jfs/ioctl.c                      |  3 +--
>  fs/nilfs2/ioctl.c                   |  4 ++--
>  fs/ntfs3/file.c                     |  4 ++--
>  fs/ntfs3/super.c                    |  6 ++----
>  fs/ocfs2/ioctl.c                    |  3 +--
>  fs/xfs/xfs_discard.c                |  4 ++--
>  include/linux/blkdev.h              |  5 +++++
>  18 files changed, 38 insertions(+), 47 deletions(-)
>
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 8b4b66d3a9bfc..43aa4d7fe859f 100644
> --- a/block/blk-lib.c
> +++ b/block/blk-lib.c
> @@ -12,8 +12,7 @@
>
>  static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
>  {
> -       unsigned int discard_granularity =
> -               bdev_get_queue(bdev)->limits.discard_granularity;
> +       unsigned int discard_granularity = bdev_discard_granularity(bdev);
>         sector_t granularity_aligned_sector;
>
>         if (bdev_is_partition(bdev))
> @@ -59,7 +58,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
>         }
>
>         /* In case the discard granularity isn't set by buggy device driver */
> -       if (WARN_ON_ONCE(!q->limits.discard_granularity)) {
> +       if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
>                 char dev_name[BDEVNAME_SIZE];
>
>                 bdevname(bdev, dev_name);
> diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
> index 8e28e0a8e5e41..94ac3737723a8 100644
> --- a/drivers/block/drbd/drbd_nl.c
> +++ b/drivers/block/drbd/drbd_nl.c
> @@ -1440,7 +1440,6 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
>                                struct drbd_backing_dev *nbc)
>  {
>         struct block_device *bdev = nbc->backing_bdev;
> -       struct request_queue *q = bdev->bd_disk->queue;
>
>         if (disk_conf->al_extents < DRBD_AL_EXTENTS_MIN)
>                 disk_conf->al_extents = DRBD_AL_EXTENTS_MIN;
> @@ -1457,12 +1456,14 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
>         if (disk_conf->rs_discard_granularity) {
>                 int orig_value = disk_conf->rs_discard_granularity;
>                 sector_t discard_size = bdev_max_discard_sectors(bdev) << 9;
> +               unsigned int discard_granularity = bdev_discard_granularity(bdev);
>                 int remainder;
>
> -               if (q->limits.discard_granularity > disk_conf->rs_discard_granularity)
> -                       disk_conf->rs_discard_granularity = q->limits.discard_granularity;
> +               if (discard_granularity > disk_conf->rs_discard_granularity)
> +                       disk_conf->rs_discard_granularity = discard_granularity;
>
> -               remainder = disk_conf->rs_discard_granularity % q->limits.discard_granularity;
> +               remainder = disk_conf->rs_discard_granularity %
> +                               discard_granularity;
>                 disk_conf->rs_discard_granularity += remainder;
>
>                 if (disk_conf->rs_discard_granularity > discard_size)
> diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
> index 8a4a47da56fe9..275c53c7b629e 100644
> --- a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -1511,7 +1511,6 @@ void drbd_bump_write_ordering(struct drbd_resource *resource, struct drbd_backin
>  int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, unsigned int nr_sectors, int flags)
>  {
>         struct block_device *bdev = device->ldev->backing_bdev;
> -       struct request_queue *q = bdev_get_queue(bdev);
>         sector_t tmp, nr;
>         unsigned int max_discard_sectors, granularity;
>         int alignment;
> @@ -1521,7 +1520,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
>                 goto zero_out;
>
>         /* Zero-sector (unknown) and one-sector granularities are the same.  */
> -       granularity = max(q->limits.discard_granularity >> 9, 1U);
> +       granularity = max(bdev_discard_granularity(bdev) >> 9, 1U);
>         alignment = (bdev_discard_alignment(bdev) >> 9) % granularity;
>
>         max_discard_sectors = min(bdev_max_discard_sectors(bdev), (1U << 22));
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 4b919b75205a7..d5499795a1fec 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -759,7 +759,7 @@ static void loop_config_discard(struct loop_device *lo)
>                 struct request_queue *backingq = bdev_get_queue(I_BDEV(inode));
>
>                 max_discard_sectors = backingq->limits.max_write_zeroes_sectors;
> -               granularity = backingq->limits.discard_granularity ?:
> +               granularity = bdev_discard_granularity(I_BDEV(inode)) ?:
>                         queue_physical_block_size(backingq);
>
>         /*
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 7d510e4231713..ee93f0cca4228 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -834,7 +834,6 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
>  bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
>                                        struct block_device *bdev)
>  {
> -       struct request_queue *q = bdev_get_queue(bdev);
>         int block_size = bdev_logical_block_size(bdev);
>
>         if (!bdev_max_discard_sectors(bdev))
> @@ -846,7 +845,7 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
>          * Currently hardcoded to 1 in Linux/SCSI code..
>          */
>         attrib->max_unmap_block_desc_count = 1;
> -       attrib->unmap_granularity = q->limits.discard_granularity / block_size;
> +       attrib->unmap_granularity = bdev_discard_granularity(bdev) / block_size;
>         attrib->unmap_granularity_alignment =
>                 bdev_discard_alignment(bdev) / block_size;
>         return true;
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index fc7953755fd8b..f1a1e9519808e 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -468,7 +468,6 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
>                                         void __user *arg)
>  {
>         struct btrfs_device *device;
> -       struct request_queue *q;
>         struct fstrim_range range;
>         u64 minlen = ULLONG_MAX;
>         u64 num_devices = 0;
> @@ -498,14 +497,11 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
>         rcu_read_lock();
>         list_for_each_entry_rcu(device, &fs_info->fs_devices->devices,
>                                 dev_list) {
> -               if (!device->bdev)
> +               if (!device->bdev || !bdev_max_discard_sectors(device->bdev))
>                         continue;
> -               q = bdev_get_queue(device->bdev);
> -               if (bdev_max_discard_sectors(device->bdev)) {
> -                       num_devices++;
> -                       minlen = min_t(u64, q->limits.discard_granularity,
> -                                    minlen);
> -               }
> +               num_devices++;
> +               minlen = min_t(u64, bdev_discard_granularity(device->bdev),
> +                                   minlen);
>         }
>         rcu_read_unlock();
>
> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
> index 765e4f63dd18d..20d4e47f57ab2 100644
> --- a/fs/exfat/file.c
> +++ b/fs/exfat/file.c
> @@ -351,7 +351,6 @@ int exfat_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
>
>  static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
>  {
> -       struct request_queue *q = bdev_get_queue(inode->i_sb->s_bdev);
>         struct fstrim_range range;
>         int ret = 0;
>
> @@ -365,7 +364,7 @@ static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
>                 return -EFAULT;
>
>         range.minlen = max_t(unsigned int, range.minlen,
> -                               q->limits.discard_granularity);
> +                               bdev_discard_granularity(inode->i_sb->s_bdev));
>
>         ret = exfat_trim_fs(inode, &range);
>         if (ret < 0)
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index c3668c977cd99..6d1820536d88d 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -6455,7 +6455,7 @@ ext4_trim_all_free(struct super_block *sb, ext4_group_t group,
>   */
>  int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
>  {
> -       struct request_queue *q = bdev_get_queue(sb->s_bdev);
> +       unsigned int discard_granularity = bdev_discard_granularity(sb->s_bdev);
>         struct ext4_group_info *grp;
>         ext4_group_t group, first_group, last_group;
>         ext4_grpblk_t cnt = 0, first_cluster, last_cluster;
> @@ -6475,9 +6475,9 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
>             range->len < sb->s_blocksize)
>                 return -EINVAL;
>         /* No point to try to trim less than discard granularity */
> -       if (range->minlen < q->limits.discard_granularity) {
> +       if (range->minlen < discard_granularity) {
>                 minlen = EXT4_NUM_B2C(EXT4_SB(sb),
> -                       q->limits.discard_granularity >> sb->s_blocksize_bits);
> +                               discard_granularity >> sb->s_blocksize_bits);
>                 if (minlen > EXT4_CLUSTERS_PER_GROUP(sb))
>                         goto out;
>         }
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 5b89af0f27f05..8053d99f3920b 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2285,7 +2285,6 @@ static int f2fs_ioc_fitrim(struct file *filp, unsigned long arg)
>  {
>         struct inode *inode = file_inode(filp);
>         struct super_block *sb = inode->i_sb;
> -       struct request_queue *q = bdev_get_queue(sb->s_bdev);
>         struct fstrim_range range;
>         int ret;
>
> @@ -2304,7 +2303,7 @@ static int f2fs_ioc_fitrim(struct file *filp, unsigned long arg)
>                 return ret;
>
>         range.minlen = max((unsigned int)range.minlen,
> -                               q->limits.discard_granularity);
> +                          bdev_discard_granularity(sb->s_bdev));
>         ret = f2fs_trim_fs(F2FS_SB(sb), &range);
>         mnt_drop_write_file(filp);
>         if (ret < 0)
> diff --git a/fs/fat/file.c b/fs/fat/file.c
> index e4c7d10e80129..bf91f977debea 100644
> --- a/fs/fat/file.c
> +++ b/fs/fat/file.c
> @@ -127,7 +127,6 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
>         struct super_block *sb = inode->i_sb;
>         struct fstrim_range __user *user_range;
>         struct fstrim_range range;
> -       struct request_queue *q = bdev_get_queue(sb->s_bdev);
>         int err;
>
>         if (!capable(CAP_SYS_ADMIN))
> @@ -141,7 +140,7 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
>                 return -EFAULT;
>
>         range.minlen = max_t(unsigned int, range.minlen,
> -                            q->limits.discard_granularity);
> +                            bdev_discard_granularity(sb->s_bdev));
>
>         err = fat_trim_fs(inode, &range);
>         if (err < 0)
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index 7f20ac9133bc6..6d26bb5254844 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -1386,7 +1386,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
>  {
>         struct inode *inode = file_inode(filp);
>         struct gfs2_sbd *sdp = GFS2_SB(inode);
> -       struct request_queue *q = bdev_get_queue(sdp->sd_vfs->s_bdev);
> +       struct block_device *bdev = sdp->sd_vfs->s_bdev;
>         struct buffer_head *bh;
>         struct gfs2_rgrpd *rgd;
>         struct gfs2_rgrpd *rgd_end;
> @@ -1405,7 +1405,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
>         if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
>                 return -EROFS;
>
> -       if (!bdev_max_discard_sectors(sdp->sd_vfs->s_bdev))
> +       if (!bdev_max_discard_sectors(bdev))
>                 return -EOPNOTSUPP;
>
>         if (copy_from_user(&r, argp, sizeof(r)))
> @@ -1418,8 +1418,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
>         start = r.start >> bs_shift;
>         end = start + (r.len >> bs_shift);
>         minlen = max_t(u64, r.minlen, sdp->sd_sb.sb_bsize);
> -       minlen = max_t(u64, minlen,
> -                      q->limits.discard_granularity) >> bs_shift;
> +       minlen = max_t(u64, minlen, bdev_discard_granularity(bdev)) >> bs_shift;
>
>         if (end <= start || minlen > sdp->sd_max_rg_data)
>                 return -EINVAL;
> diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> index 357ae6e5c36ec..1e7b177ece605 100644
> --- a/fs/jfs/ioctl.c
> +++ b/fs/jfs/ioctl.c
> @@ -110,7 +110,6 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>         case FITRIM:
>         {
>                 struct super_block *sb = inode->i_sb;
> -               struct request_queue *q = bdev_get_queue(sb->s_bdev);
>                 struct fstrim_range range;
>                 s64 ret = 0;
>
> @@ -127,7 +126,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>                         return -EFAULT;
>
>                 range.minlen = max_t(unsigned int, range.minlen,
> -                       q->limits.discard_granularity);
> +                                    bdev_discard_granularity(sb->s_bdev));
>
>                 ret = jfs_ioc_trim(inode, &range);
>                 if (ret < 0)
> diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
> index 52b73f558fcb1..87e1004b606d2 100644
> --- a/fs/nilfs2/ioctl.c
> +++ b/fs/nilfs2/ioctl.c
> @@ -1052,7 +1052,6 @@ static int nilfs_ioctl_resize(struct inode *inode, struct file *filp,
>  static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
>  {
>         struct the_nilfs *nilfs = inode->i_sb->s_fs_info;
> -       struct request_queue *q = bdev_get_queue(nilfs->ns_bdev);
>         struct fstrim_range range;
>         int ret;
>
> @@ -1065,7 +1064,8 @@ static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
>         if (copy_from_user(&range, argp, sizeof(range)))
>                 return -EFAULT;
>
> -       range.minlen = max_t(u64, range.minlen, q->limits.discard_granularity);
> +       range.minlen = max_t(u64, range.minlen,
> +                            bdev_discard_granularity(nilfs->ns_bdev));
>
>         down_read(&nilfs->ns_segctor_sem);
>         ret = nilfs_sufile_trim_fs(nilfs->ns_sufile, &range);
> diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
> index e763236169331..15806eeae217a 100644
> --- a/fs/ntfs3/file.c
> +++ b/fs/ntfs3/file.c
> @@ -22,7 +22,6 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
>  {
>         struct fstrim_range __user *user_range;
>         struct fstrim_range range;
> -       struct request_queue *q = bdev_get_queue(sbi->sb->s_bdev);
>         int err;
>
>         if (!capable(CAP_SYS_ADMIN))
> @@ -35,7 +34,8 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
>         if (copy_from_user(&range, user_range, sizeof(range)))
>                 return -EFAULT;
>
> -       range.minlen = max_t(u32, range.minlen, q->limits.discard_granularity);
> +       range.minlen = max_t(u32, range.minlen,
> +                            bdev_discard_granularity(sbi->sb->s_bdev));
>
>         err = ntfs_trim_fs(sbi, &range);
>         if (err < 0)
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index c734085bcce4a..5f2e414cfa79b 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -882,7 +882,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
>         int err;
>         struct ntfs_sb_info *sbi = sb->s_fs_info;
>         struct block_device *bdev = sb->s_bdev;
> -       struct request_queue *rq;
>         struct inode *inode;
>         struct ntfs_inode *ni;
>         size_t i, tt;
> @@ -912,9 +911,8 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
>                 goto out;
>         }
>
> -       rq = bdev_get_queue(bdev);
> -       if (bdev_max_discard_sectors(bdev) && rq->limits.discard_granularity) {
> -               sbi->discard_granularity = rq->limits.discard_granularity;
> +       if (bdev_max_discard_sectors(bdev) && bdev_discard_granularity(bdev)) {
> +               sbi->discard_granularity = bdev_discard_granularity(bdev);
>                 sbi->discard_granularity_mask_inv =
>                         ~(u64)(sbi->discard_granularity - 1);
>         }
> diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
> index 9b78ef103ada6..afd54ec661030 100644
> --- a/fs/ocfs2/ioctl.c
> +++ b/fs/ocfs2/ioctl.c
> @@ -903,7 +903,6 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>         case FITRIM:
>         {
>                 struct super_block *sb = inode->i_sb;
> -               struct request_queue *q = bdev_get_queue(sb->s_bdev);
>                 struct fstrim_range range;
>                 int ret = 0;
>
> @@ -916,7 +915,7 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>                 if (copy_from_user(&range, argp, sizeof(range)))
>                         return -EFAULT;
>
> -               range.minlen = max_t(u64, q->limits.discard_granularity,
> +               range.minlen = max_t(u64, bdev_discard_granularity(sb->s_bdev),
>                                      range.minlen);
>                 ret = ocfs2_trim_fs(sb, &range);
>                 if (ret < 0)
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index a4e6609d616b7..e2ada115c23f9 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -152,8 +152,8 @@ xfs_ioc_trim(
>         struct xfs_mount                *mp,
>         struct fstrim_range __user      *urange)
>  {
> -       struct request_queue    *q = bdev_get_queue(mp->m_ddev_targp->bt_bdev);
> -       unsigned int            granularity = q->limits.discard_granularity;
> +       unsigned int            granularity =
> +               bdev_discard_granularity(mp->m_ddev_targp->bt_bdev);
>         struct fstrim_range     range;
>         xfs_daddr_t             start, end, minlen;
>         xfs_agnumber_t          start_agno, end_agno, agno;
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index ce16247d3afab..7b9c0cf95d2d5 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1259,6 +1259,11 @@ static inline unsigned int bdev_max_discard_sectors(struct block_device *bdev)
>         return bdev_get_queue(bdev)->limits.max_discard_sectors;
>  }
>
> +static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
> +{
> +       return bdev_get_queue(bdev)->limits.discard_granularity;
> +}
> +
>  static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
>  {
>         struct request_queue *q = bdev_get_queue(bdev);
> --
> 2.30.2
>

I got the following checkpatch warning:

 WARNING: 'retreive' may be misspelled - perhaps 'retrieve'?
 #101:
 block_device based helper to retreive the discard granularity.
                              ^^^^^^^^

 total: 0 errors, 1 warnings, 294 lines checked


The changes themselves look good.

Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>

Thanks,
Ryusuke Konishi


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 19:01:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 19:01:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300100.511701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncAuG-0001XN-AS; Wed, 06 Apr 2022 19:01:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300100.511701; Wed, 06 Apr 2022 19:01:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncAuG-0001XG-7A; Wed, 06 Apr 2022 19:01:28 +0000
Received: by outflank-mailman (input) for mailman id 300100;
 Wed, 06 Apr 2022 19:01:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncAuE-0001X6-VD; Wed, 06 Apr 2022 19:01:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncAuE-0002xr-Sf; Wed, 06 Apr 2022 19:01:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncAuE-0003ho-Hz; Wed, 06 Apr 2022 19:01:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncAuE-00077C-HH; Wed, 06 Apr 2022 19:01:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YuwTLFJlkEbqof0cV3+EjgWO8uIFxAaqI7LFEjPpwlw=; b=3nDIZRudekYdLCz2WKgIkITFDg
	S5mDthM1aLepVEPQGtn8HgCXgUzs32YH7slHNGGdaY0S9hDyHkK5pBhEcax6gkjhfidXpz1ZDOzPr
	vIjedT0ZYu5QsZPyR5CD23ySUM8641+ljFEEuAnc9olhkYpzuFsFX9O7HoUHhUxZiJDY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169196-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169196: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=a298a84478053872ed9da660a75f182ce81b8ddc
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 19:01:26 +0000

flight 169196 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169196/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 a298a84478053872ed9da660a75f182ce81b8ddc
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   37 days
Failing since        168258  2022-03-01 01:55:31 Z   36 days  282 attempts
Testing same since   169173  2022-04-05 05:13:00 Z    1 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4610 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 19:20:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 19:20:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300110.511713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncBCU-0004Bv-2H; Wed, 06 Apr 2022 19:20:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300110.511713; Wed, 06 Apr 2022 19:20:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncBCT-0004Bo-Us; Wed, 06 Apr 2022 19:20:17 +0000
Received: by outflank-mailman (input) for mailman id 300110;
 Wed, 06 Apr 2022 19:20:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncBCT-0004Be-70; Wed, 06 Apr 2022 19:20:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncBCT-0003Er-4D; Wed, 06 Apr 2022 19:20:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncBCS-0004oy-I3; Wed, 06 Apr 2022 19:20:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncBCS-0002I5-Ha; Wed, 06 Apr 2022 19:20:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Q96s9BgKS5MFjecFMoangaDQiRrnMK2xgwpX2WNnJ38=; b=fksbXHhADIn5ManWuTarp6JR2c
	oMYqK91wj/3JUN9ZPb0z41+v15+YdX/lhQx8nLtqf0i8RfCYF1GmzvzCiv8/gg9xhPInrVlaeCdoh
	YME6vxsscyQpXWGAbRASSIAz+Dkms3VtAjwyyPrmz4S32DnbUDiEVbeBaOEoF/0HrfGg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169188-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169188: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3e732ebf7316ac83e8562db7e64cc68aec390a18
X-Osstest-Versions-That:
    linux=3123109284176b1532874591f7c81f3837bbdc17
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 19:20:16 +0000

flight 169188 linux-linus real [real]
flight 169201 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169188/
http://logs.test-lab.xenproject.org/osstest/logs/169201/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 169174

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd      13 guest-start         fail pass in 169201-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 169201 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 169201 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169174
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169174
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169174
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169174
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3e732ebf7316ac83e8562db7e64cc68aec390a18
baseline version:
 linux                3123109284176b1532874591f7c81f3837bbdc17

Last test of basis   169174  2022-04-05 08:27:06 Z    1 days
Testing same since   169188  2022-04-05 21:41:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Borislav Petkov <bp@suse.de>
  Darrick J. Wong <djwong@kernel.org>
  David Sterba <dsterba@suse.com>
  Eli Cohen <elic@nvidia.com>
  Ethan Lien <ethanlien@synology.com>
  Jason Wang <jasowang@redhat.com>
  Johannes Thumshirn <johannes.thumshirn@wdc.com>
  Josef Bacik <josef@toxicpanda.com>
  Kaiwen Hu <kevinhu@synology.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michael S. Tsirkin <mst@redhat.com>
  Neelima Krishnan <neelima.krishnan@intel.com>
  Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
  Qu Wenruo <wqu@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 583 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 20:27:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 20:27:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300119.511723 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncCFE-0002be-0l; Wed, 06 Apr 2022 20:27:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300119.511723; Wed, 06 Apr 2022 20:27:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncCFD-0002bX-U8; Wed, 06 Apr 2022 20:27:11 +0000
Received: by outflank-mailman (input) for mailman id 300119;
 Wed, 06 Apr 2022 20:27:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncCFC-0002bR-KA
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 20:27:10 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee89518f-b5e7-11ec-a405-831a346695d4;
 Wed, 06 Apr 2022 22:27:08 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 50066B8252B;
 Wed,  6 Apr 2022 20:27:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D07EFC385A5;
 Wed,  6 Apr 2022 20:27:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee89518f-b5e7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649276827;
	bh=z0aMA9z9JdtH2ebddpqbNR2kb/h3I9KravvKflFK/vA=;
	h=Date:From:To:cc:Subject:From;
	b=bfBeMIOd6hdm8+RBdjBmXy6mKLBQLeI/NQQUWfKuWdmUWP4RpPisFfTXkWihAIiA7
	 68Jb8Uy1UBRVexu7JPCcE66GHfPpnAcignFhyXKW4CXpDbZImPsTM32elgjWom6nfM
	 C1uqBlZHEqwbVgBMcZMNjCV1vH8M9ffIxBcLJTooDCUeCMnMdi0mGumWMN9RU4lPmd
	 mZKj2wT4QVOk430A3gNNKAqcQ4DcR+NXovLHUhitXR+zU//WTZXi9HeQCfadxN/U6a
	 eOuMA3/mXazMdeS65L4aeiCbeNcJcV6ALbC/YXq6YKgprtrQlyeBX5Ugx8TLflkFAJ
	 kqODvD5WW2pUA==
Date: Wed, 6 Apr 2022 13:27:05 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: cardoe@cardoe.com
cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, 
    andrew.cooper3@citrix.com, anthony.perard@citrix.com
Subject: [PATCH] MAINTAINERS: add myself as Continuous Integration
 maintainer
Message-ID: <alpine.DEB.2.22.394.2204061323490.2910984@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

I have contributed all the ARM tests to gitlab-ci. After checking with
Doug, I am happy to volunteer to co-maintain Continuous Integration.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Doug Goldstein <cardoe@cardoe.com>

diff --git a/MAINTAINERS b/MAINTAINERS
index 6a097b43eb..cc87d5bbf1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -262,6 +262,7 @@ F:	CHANGELOG.md
 
 Continuous Integration (CI)
 M:	Doug Goldstein <cardoe@cardoe.com>
+M:	Stefano Stabellini <sstabellini@kernel.org>
 W:	https://gitlab.com/xen-project/xen
 W:	https://travis-ci.org/xen-project/xen
 S:	Supported


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 20:34:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 20:34:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300123.511735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncCMT-0004AG-PJ; Wed, 06 Apr 2022 20:34:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300123.511735; Wed, 06 Apr 2022 20:34:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncCMT-0004A9-MF; Wed, 06 Apr 2022 20:34:41 +0000
Received: by outflank-mailman (input) for mailman id 300123;
 Wed, 06 Apr 2022 20:34:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncCMS-00049z-B6; Wed, 06 Apr 2022 20:34:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncCMS-0004ZN-3U; Wed, 06 Apr 2022 20:34:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncCMR-00081p-Ia; Wed, 06 Apr 2022 20:34:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncCMR-0007VT-I8; Wed, 06 Apr 2022 20:34:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=h2+PiGDGvmCkawjlV+DktLwYbdBVs0kQBOyhWrI+TDk=; b=uhIBleAyeAgcZmoCDt0LvDw/p1
	vWj97azUJk+GeC27SzJZePuhpUDyGD0HXJYGFDdWN+g/Og2Jm8TeclgNBymIxcRf0T383aZ8fWkWI
	7vVxak3OpUns+OtjOZkK9tONGuzYhA6KNv4aRkXeGJD9KxwFpGIFDO5SjwPctqU52wRA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169192-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169192: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=e53c02ea205f8119865e9f3bfd0121c7829371a2
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 20:34:39 +0000

flight 169192 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169192/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              e53c02ea205f8119865e9f3bfd0121c7829371a2
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  635 days
Failing since        151818  2020-07-11 04:18:52 Z  634 days  616 attempts
Testing same since   169192  2022-04-06 04:21:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 103691 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 20:47:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 20:47:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300132.511746 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncCYf-0005rw-3C; Wed, 06 Apr 2022 20:47:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300132.511746; Wed, 06 Apr 2022 20:47:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncCYf-0005rp-0D; Wed, 06 Apr 2022 20:47:17 +0000
Received: by outflank-mailman (input) for mailman id 300132;
 Wed, 06 Apr 2022 20:47:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7cdP=UQ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncCYd-0005ri-LA
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 20:47:15 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bc732846-b5ea-11ec-8fbc-03012f2f19d4;
 Wed, 06 Apr 2022 22:47:14 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 5C3ABB8254B;
 Wed,  6 Apr 2022 20:47:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AA84C385A1;
 Wed,  6 Apr 2022 20:47:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc732846-b5ea-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649278031;
	bh=ZNa0ebH9QDIo6JAwRlo2+k+VcuI4hbHHsLRPRJSpSFo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=nZiNUb70WUMggp9sETvbPXPj7x5sOnXFqLckfdm1e2KSVtn9jCNhaVwYjhdeMzKWf
	 SE1mxlZzHqDjHIb0mmPgXnLWRONlRt0k+3T18giCoVn55OceYi4qaU6f1Dtn6KKUQn
	 YJABKzbpdLODdvqPuzERBztqScMHXY4tVPGMcD+lOFj6KDkucIsuBcwE28166Fhzx7
	 XppUhVp89+Df/J4CZSuQQ0YEe0FKJSbPY66l1RId0A6mE4v2jaXz7L4BeO0FdABQiI
	 SiS8DHbldq/NbBHayveW8oHpYSrW5cGKJKbjOYvYDo8qXNNQ6TnKB00EEmoliw6RWr
	 4reiFBHRcbZQQ==
Date: Wed, 6 Apr 2022 13:47:08 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot
 time
In-Reply-To: <20220405085741.18336-5-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204061346080.2910984@ubuntu-linux-20-04-desktop>
References: <20220405085741.18336-1-luca.fancellu@arm.com> <20220405085741.18336-5-luca.fancellu@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 5 Apr 2022, Luca Fancellu wrote:
> Introduce a way to create different cpupools at boot time, this is
> particularly useful on ARM big.LITTLE system where there might be the
> need to have different cpupools for each type of core, but also
> systems using NUMA can have different cpu pools for each node.
> 
> The feature on arm relies on a specification of the cpupools from the
> device tree to build pools and assign cpus to them.
> 
> Documentation is created to explain the feature.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Looks good to me now:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

I think we only need Juergen to take one last look at the series and it
should be good to go.


> ---
> Changes in v5:
> - Fixed wrong variable name, swapped schedulers, add scheduler info
>   in the printk (Stefano)
> - introduce assert in cpupool_init and btcpupools_get_cpupool_id to
>   harden the code
> Changes in v4:
> - modify Makefile to put in *.init.o, fixed stubs and macro (Jan)
> - fixed docs, fix brakets (Stefano)
> - keep cpu0 in Pool-0 (Julien)
> - moved printk from btcpupools_allocate_pools to
>   btcpupools_get_cpupool_id
> - Add to docs constraint about cpu0 and Pool-0
> Changes in v3:
> - Add newline to cpupools.txt and removed "default n" from Kconfig (Jan)
> - Fixed comment, moved defines, used global cpu_online_map, use
>   HAS_DEVICE_TREE instead of ARM and place arch specific code in header
>   (Juergen)
> - Fix brakets, x86 code only panic, get rid of scheduler dt node, don't
>   save pool pointer and look for it from the pool list (Stefano)
> - Changed data structures to allow modification to the code.
> Changes in v2:
> - Move feature to common code (Juergen)
> - Try to decouple dtb parse and cpupool creation to allow
>   more way to specify cpupools (for example command line)
> - Created standalone dt node for the scheduler so it can
>   be used in future work to set scheduler specific
>   parameters
> - Use only auto generated ids for cpupools
> ---
>  docs/misc/arm/device-tree/cpupools.txt | 136 +++++++++++++++++
>  xen/arch/arm/include/asm/smp.h         |   3 +
>  xen/common/Kconfig                     |   7 +
>  xen/common/Makefile                    |   1 +
>  xen/common/boot_cpupools.c             | 203 +++++++++++++++++++++++++
>  xen/common/sched/cpupool.c             |  12 +-
>  xen/include/xen/sched.h                |  14 ++
>  7 files changed, 375 insertions(+), 1 deletion(-)
>  create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>  create mode 100644 xen/common/boot_cpupools.c
> 
> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
> new file mode 100644
> index 000000000000..5dac2b1384e0
> --- /dev/null
> +++ b/docs/misc/arm/device-tree/cpupools.txt
> @@ -0,0 +1,136 @@
> +Boot time cpupools
> +==================
> +
> +When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
> +create cpupools during boot phase by specifying them in the device tree.
> +
> +Cpupools specification nodes shall be direct childs of /chosen node.
> +Each cpupool node contains the following properties:
> +
> +- compatible (mandatory)
> +
> +    Must always include the compatiblity string: "xen,cpupool".
> +
> +- cpupool-cpus (mandatory)
> +
> +    Must be a list of device tree phandle to nodes describing cpus (e.g. having
> +    device_type = "cpu"), it can't be empty.
> +
> +- cpupool-sched (optional)
> +
> +    Must be a string having the name of a Xen scheduler. Check the sched=<...>
> +    boot argument for allowed values.
> +
> +
> +Constraints
> +===========
> +
> +If no cpupools are specified, all cpus will be assigned to one cpupool
> +implicitly created (Pool-0).
> +
> +If cpupools node are specified, but not every cpu brought up by Xen is assigned,
> +all the not assigned cpu will be assigned to an additional cpupool.
> +
> +If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
> +stop.
> +
> +The boot cpu must be assigned to Pool-0, so the cpupool containing that core
> +will become Pool-0 automatically.
> +
> +
> +Examples
> +========
> +
> +A system having two types of core, the following device tree specification will
> +instruct Xen to have two cpupools:
> +
> +- The cpupool with id 0 will have 4 cpus assigned.
> +- The cpupool with id 1 will have 2 cpus assigned.
> +
> +The following example can work only if hmp-unsafe=1 is passed to Xen boot
> +arguments, otherwise not all cores will be brought up by Xen and the cpupool
> +creation process will stop Xen.
> +
> +
> +a72_1: cpu@0 {
> +        compatible = "arm,cortex-a72";
> +        reg = <0x0 0x0>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a72_2: cpu@1 {
> +        compatible = "arm,cortex-a72";
> +        reg = <0x0 0x1>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_1: cpu@100 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x100>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_2: cpu@101 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x101>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_3: cpu@102 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x102>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_4: cpu@103 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x103>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +chosen {
> +
> +    cpupool_a {
> +        compatible = "xen,cpupool";
> +        cpupool-cpus = <&a53_1 &a53_2 &a53_3 &a53_4>;
> +    };
> +    cpupool_b {
> +        compatible = "xen,cpupool";
> +        cpupool-cpus = <&a72_1 &a72_2>;
> +        cpupool-sched = "credit2";
> +    };
> +
> +    [...]
> +
> +};
> +
> +
> +A system having the cpupools specification below will instruct Xen to have three
> +cpupools:
> +
> +- The cpupool Pool-0 will have 2 cpus assigned.
> +- The cpupool Pool-1 will have 2 cpus assigned.
> +- The cpupool Pool-2 will have 2 cpus assigned (created by Xen with all the not
> +  assigned cpus a53_3 and a53_4).
> +
> +chosen {
> +
> +    cpupool_a {
> +        compatible = "xen,cpupool";
> +        cpupool-cpus = <&a53_1 &a53_2>;
> +    };
> +    cpupool_b {
> +        compatible = "xen,cpupool";
> +        cpupool-cpus = <&a72_1 &a72_2>;
> +        cpupool-sched = "null";
> +    };
> +
> +    [...]
> +
> +};
> diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h
> index af5a2fe65266..83c0cd69767b 100644
> --- a/xen/arch/arm/include/asm/smp.h
> +++ b/xen/arch/arm/include/asm/smp.h
> @@ -34,6 +34,9 @@ extern void init_secondary(void);
>  extern void smp_init_cpus(void);
>  extern void smp_clear_cpu_maps (void);
>  extern int smp_get_max_cpus (void);
> +
> +#define cpu_physical_id(cpu) cpu_logical_map(cpu)
> +
>  #endif
>  
>  /*
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index d921c74d615e..70aac5220e75 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -22,6 +22,13 @@ config GRANT_TABLE
>  
>  	  If unsure, say Y.
>  
> +config BOOT_TIME_CPUPOOLS
> +	bool "Create cpupools at boot time"
> +	depends on HAS_DEVICE_TREE
> +	help
> +	  Creates cpupools during boot time and assigns cpus to them. Cpupools
> +	  options can be specified in the device tree.
> +
>  config ALTERNATIVE_CALL
>  	bool
>  
> diff --git a/xen/common/Makefile b/xen/common/Makefile
> index dc8d3a13f5b8..e30cd26eef70 100644
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -1,5 +1,6 @@
>  obj-$(CONFIG_ARGO) += argo.o
>  obj-y += bitmap.o
> +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot_cpupools.init.o
>  obj-$(CONFIG_HYPFS_CONFIG) += config_data.o
>  obj-$(CONFIG_CORE_PARKING) += core_parking.o
>  obj-y += cpu.o
> diff --git a/xen/common/boot_cpupools.c b/xen/common/boot_cpupools.c
> new file mode 100644
> index 000000000000..97c321386879
> --- /dev/null
> +++ b/xen/common/boot_cpupools.c
> @@ -0,0 +1,203 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * xen/common/boot_cpupools.c
> + *
> + * Code to create cpupools at boot time.
> + *
> + * Copyright (C) 2022 Arm Ltd.
> + */
> +
> +#include <xen/sched.h>
> +
> +/*
> + * pool_cpu_map:   Index is logical cpu number, content is cpupool id, (-1) for
> + *                 unassigned.
> + * pool_sched_map: Index is cpupool id, content is scheduler id, (-1) for
> + *                 unassigned.
> + */
> +static int __initdata pool_cpu_map[NR_CPUS]   = { [0 ... NR_CPUS-1] = -1 };
> +static int __initdata pool_sched_map[NR_CPUS] = { [0 ... NR_CPUS-1] = -1 };
> +static unsigned int __initdata next_pool_id;
> +
> +#define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
> +#define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
> +
> +static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
> +{
> +    unsigned int i;
> +
> +    for ( i = 0; i < nr_cpu_ids; i++ )
> +    {
> +        if ( cpu_physical_id(i) == hwid )
> +            return i;
> +    }
> +
> +    return -1;
> +}
> +
> +static int __init
> +get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
> +{
> +    int cpu_num;
> +    const __be32 *prop;
> +    unsigned int cpu_reg;
> +
> +    prop = dt_get_property(cpu_node, "reg", NULL);
> +    if ( !prop )
> +        return BTCPUPOOLS_DT_NODE_NO_REG;
> +
> +    cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node));
> +
> +    cpu_num = get_logical_cpu_from_hw_id(cpu_reg);
> +    if ( cpu_num < 0 )
> +        return BTCPUPOOLS_DT_NODE_NO_LOG_CPU;
> +
> +    return cpu_num;
> +}
> +
> +static int __init check_and_get_sched_id(const char* scheduler_name)
> +{
> +    int sched_id = sched_get_id_by_name(scheduler_name);
> +
> +    if ( sched_id < 0 )
> +        panic("Scheduler %s does not exists!\n", scheduler_name);
> +
> +    return sched_id;
> +}
> +
> +void __init btcpupools_dtb_parse(void)
> +{
> +    const struct dt_device_node *chosen, *node;
> +
> +    chosen = dt_find_node_by_path("/chosen");
> +    if ( !chosen )
> +        return;
> +
> +    dt_for_each_child_node(chosen, node)
> +    {
> +        const struct dt_device_node *phandle_node;
> +        int sched_id = -1;
> +        const char* scheduler_name;
> +        unsigned int i = 0;
> +
> +        if ( !dt_device_is_compatible(node, "xen,cpupool") )
> +            continue;
> +
> +        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) )
> +            sched_id = check_and_get_sched_id(scheduler_name);
> +
> +        phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
> +        if ( !phandle_node )
> +            panic("Missing or empty cpupool-cpus property!\n");
> +
> +        while ( phandle_node )
> +        {
> +            int cpu_num;
> +
> +            cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
> +
> +            if ( cpu_num < 0 )
> +                panic("Error retrieving logical cpu from node %s (%d)\n",
> +                      dt_node_name(node), cpu_num);
> +
> +            if ( pool_cpu_map[cpu_num] != -1 )
> +                panic("Logical cpu %d already added to a cpupool!\n", cpu_num);
> +
> +            pool_cpu_map[cpu_num] = next_pool_id;
> +
> +            phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
> +        }
> +
> +        /* Save scheduler choice for this cpupool id */
> +        pool_sched_map[next_pool_id] = sched_id;
> +
> +        /* Let Xen generate pool ids */
> +        next_pool_id++;
> +    }
> +}
> +
> +void __init btcpupools_allocate_pools(void)
> +{
> +    unsigned int i;
> +    bool add_extra_cpupool = false;
> +    int swap_id = -1;
> +
> +    /*
> +     * If there are no cpupools, the value of next_pool_id is zero, so the code
> +     * below will assign every cpu to cpupool0 as the default behavior.
> +     * When there are cpupools, the code below is assigning all the not
> +     * assigned cpu to a new pool (next_pool_id value is the last id + 1).
> +     * In the same loop we check if there is any assigned cpu that is not
> +     * online.
> +     */
> +    for ( i = 0; i < nr_cpu_ids; i++ )
> +    {
> +        if ( cpumask_test_cpu(i, &cpu_online_map) )
> +        {
> +            /* Unassigned cpu gets next_pool_id pool id value */
> +            if ( pool_cpu_map[i] < 0 )
> +            {
> +                pool_cpu_map[i] = next_pool_id;
> +                add_extra_cpupool = true;
> +            }
> +
> +            /*
> +             * Cpu0 must be in cpupool0, otherwise some operations like moving
> +             * cpus between cpupools, cpu hotplug, destroying cpupools, shutdown
> +             * of the host, might not work in a sane way.
> +             */
> +            if ( !i && (pool_cpu_map[0] != 0) )
> +                swap_id = pool_cpu_map[0];
> +
> +            if ( swap_id != -1 )
> +            {
> +                if ( pool_cpu_map[i] == swap_id )
> +                    pool_cpu_map[i] = 0;
> +                else if ( pool_cpu_map[i] == 0 )
> +                    pool_cpu_map[i] = swap_id;
> +            }
> +        }
> +        else
> +        {
> +            if ( pool_cpu_map[i] >= 0 )
> +                panic("Pool-%d contains cpu%u that is not online!\n",
> +                      pool_cpu_map[i], i);
> +        }
> +    }
> +
> +    /* A swap happened, swap schedulers between cpupool id 0 and the other */
> +    if ( swap_id != -1 )
> +    {
> +        int swap_sched = pool_sched_map[swap_id];
> +
> +        pool_sched_map[swap_id] = pool_sched_map[0];
> +        pool_sched_map[0] = swap_sched;
> +    }
> +
> +    if ( add_extra_cpupool )
> +        next_pool_id++;
> +
> +    /* Create cpupools with selected schedulers */
> +    for ( i = 0; i < next_pool_id; i++ )
> +        cpupool_create_pool(i, pool_sched_map[i]);
> +}
> +
> +unsigned int __init btcpupools_get_cpupool_id(unsigned int cpu)
> +{
> +    ASSERT((cpu < NR_CPUS) && (pool_cpu_map[cpu] >= 0));
> +
> +    printk(XENLOG_INFO "Logical CPU %u in Pool-%d (Scheduler id: %d).\n",
> +           cpu, pool_cpu_map[cpu], pool_sched_map[pool_cpu_map[cpu]]);
> +
> +    return pool_cpu_map[cpu];
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
> index 89a891af7076..86a175f99cd5 100644
> --- a/xen/common/sched/cpupool.c
> +++ b/xen/common/sched/cpupool.c
> @@ -1247,12 +1247,22 @@ static int __init cf_check cpupool_init(void)
>      cpupool_put(cpupool0);
>      register_cpu_notifier(&cpu_nfb);
>  
> +    btcpupools_dtb_parse();
> +
> +    btcpupools_allocate_pools();
> +
>      spin_lock(&cpupool_lock);
>  
>      cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
>  
>      for_each_cpu ( cpu, &cpupool_free_cpus )
> -        cpupool_assign_cpu_locked(cpupool0, cpu);
> +    {
> +        unsigned int pool_id = btcpupools_get_cpupool_id(cpu);
> +        struct cpupool *pool = cpupool_find_by_id(pool_id);
> +
> +        ASSERT(pool);
> +        cpupool_assign_cpu_locked(pool, cpu);
> +    }
>  
>      spin_unlock(&cpupool_lock);
>  
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index b527f141a1d3..453e98f1cba8 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -1178,6 +1178,20 @@ extern void cf_check dump_runq(unsigned char key);
>  
>  void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
>  
> +#ifdef CONFIG_BOOT_TIME_CPUPOOLS
> +void btcpupools_allocate_pools(void);
> +unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
> +void btcpupools_dtb_parse(void);
> +
> +#else /* !CONFIG_BOOT_TIME_CPUPOOLS */
> +static inline void btcpupools_allocate_pools(void) {}
> +static inline void btcpupools_dtb_parse(void) {}
> +static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
> +{
> +    return 0;
> +}
> +#endif
> +
>  #endif /* __SCHED_H__ */
>  
>  /*
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 21:43:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 21:43:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300163.511775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncDQR-00057r-NZ; Wed, 06 Apr 2022 21:42:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300163.511775; Wed, 06 Apr 2022 21:42:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncDQR-00057k-Ja; Wed, 06 Apr 2022 21:42:51 +0000
Received: by outflank-mailman (input) for mailman id 300163;
 Wed, 06 Apr 2022 21:42:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncDQQ-00057a-8y; Wed, 06 Apr 2022 21:42:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncDQQ-0005hd-5K; Wed, 06 Apr 2022 21:42:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncDQP-0003MA-R2; Wed, 06 Apr 2022 21:42:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncDQP-0007E2-QN; Wed, 06 Apr 2022 21:42:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RRp7ddAe2WUuDKHT+52Zv/3NjtrKctN/YlwXhsGDZ/Q=; b=CJiCnM3JlaU/6LPWHAkDXzaZX9
	5rTTQPXhSPFBPAB/5eMys+gyubkLYIbRZG57CFY7vPI5JqWafWCmZTw49VV+W6+cEOX/f35YXax+U
	XU59WPIKrN3dVfjzdxVxIpbZz510tbpBlxSpy1D3p0HrbUbyEyByI8/1JxguZ9pGSGUs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169189-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169189: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-credit2:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=14dd241aad8af447680ac73e8579990e2c09c1e7
X-Osstest-Versions-That:
    xen=e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Apr 2022 21:42:49 +0000

flight 169189 xen-unstable real [real]
flight 169204 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169189/
http://logs.test-lab.xenproject.org/osstest/logs/169204/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2 20 guest-localmigrate/x10 fail pass in 169204-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169172
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169172
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169172
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169172
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169172
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169172
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169172
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169172
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169172
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169172
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169172
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169172
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  14dd241aad8af447680ac73e8579990e2c09c1e7
baseline version:
 xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98

Last test of basis   169172  2022-04-05 04:42:27 Z    1 days
Testing same since   169189  2022-04-05 22:39:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e270af9428..14dd241aad  14dd241aad8af447680ac73e8579990e2c09c1e7 -> master


From xen-devel-bounces@lists.xenproject.org Wed Apr 06 23:33:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Apr 2022 23:33:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300194.511861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncF8x-00017i-HP; Wed, 06 Apr 2022 23:32:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300194.511861; Wed, 06 Apr 2022 23:32:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncF8x-00017b-EF; Wed, 06 Apr 2022 23:32:55 +0000
Received: by outflank-mailman (input) for mailman id 300194;
 Wed, 06 Apr 2022 23:32:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3Kdj=UQ=intel.com=lkp@srs-se1.protection.inumbo.net>)
 id 1ncF8v-00017V-KE
 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 23:32:54 +0000
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dd3b35af-b601-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 01:32:49 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Apr 2022 16:32:45 -0700
Received: from lkp-server02.sh.intel.com (HELO a44fdfb70b94) ([10.239.97.151])
 by orsmga005.jf.intel.com with ESMTP; 06 Apr 2022 16:32:42 -0700
Received: from kbuild by a44fdfb70b94 with local (Exim 4.95)
 (envelope-from <lkp@intel.com>) id 1ncF8j-0004r5-Sb;
 Wed, 06 Apr 2022 23:32:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd3b35af-b601-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649287969; x=1680823969;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=pRwkOMm0qHu0lOS5zpitn48/SuLkUxM71YjsDbeCfgU=;
  b=k8sJAnIRTABGPo9r6P9fFHuX2ub2BVcKh6ldIHdGtPrlVYsVJB8RGbhx
   5spofdTCJv22IRr4RPRY9odflKFvmO5cuwbQIVIwq+KogproTNYWebsG8
   A/+zxKw4pfYLu7aoLeQz3DefJNGAFDERSHa2uSnMbYmZuz5mthkYmMGDI
   b3VBclifxD33arxzglIfzn9QendKXzMFgo2N4XFrlZNKn3n1TQ4VUBnZv
   OdG/HnUdn/WHoDr+svxnN7RD0oyVkuT0ccPhDc61qgh1MZhPjDV1faTLJ
   E1mlvGqX9zqFKymFcUfO+im+QAxptDAF/9UxszDLK4uRyqiYzTfAiJ0Dd
   w==;
X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="258775586"
X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; 
   d="scan'208";a="258775586"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; 
   d="scan'208";a="722721744"
Date: Thu, 7 Apr 2022 07:31:44 +0800
From: kernel test robot <lkp@intel.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone
Message-ID: <202204070706.PKz2Th7L-lkp@intel.com>
References: <20220406133229.15979-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406133229.15979-1-jgross@suse.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

Hi Juergen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on xen-tip/linux-next]
[also build test WARNING on linus/master linux/master v5.18-rc1 next-20220406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Juergen-Gross/xen-balloon-fix-page-onlining-when-populating-new-zone/20220407-000935
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: arm64-randconfig-r011-20220406 (https://download.01.org/0day-ci/archive/20220407/202204070706.PKz2Th7L-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b3deb59d5386ade4fb227038f202a9bdb8ade4ab
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Juergen-Gross/xen-balloon-fix-page-onlining-when-populating-new-zone/20220407-000935
        git checkout b3deb59d5386ade4fb227038f202a9bdb8ade4ab
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/xen/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/xen/balloon.c: In function 'decrease_reservation':
   drivers/xen/balloon.c:518:24: error: implicit declaration of function 'alloc_page_for_balloon' [-Werror=implicit-function-declaration]
     518 |                 page = alloc_page_for_balloon(gfp);
         |                        ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/xen/balloon.c:518:22: warning: assignment to 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     518 |                 page = alloc_page_for_balloon(gfp);
         |                      ^
   drivers/xen/balloon.c:545:17: error: implicit declaration of function 'add_page_to_balloon' [-Werror=implicit-function-declaration]
     545 |                 add_page_to_balloon(page);
         |                 ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +518 drivers/xen/balloon.c

   505	
   506	static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
   507	{
   508		enum bp_state state = BP_DONE;
   509		unsigned long i;
   510		struct page *page, *tmp;
   511		int ret;
   512		LIST_HEAD(pages);
   513	
   514		if (nr_pages > ARRAY_SIZE(frame_list))
   515			nr_pages = ARRAY_SIZE(frame_list);
   516	
   517		for (i = 0; i < nr_pages; i++) {
 > 518			page = alloc_page_for_balloon(gfp);
   519			if (page == NULL) {
   520				nr_pages = i;
   521				state = BP_EAGAIN;
   522				break;
   523			}
   524			list_add(&page->lru, &pages);
   525		}
   526	
   527		/*
   528		 * Ensure that ballooned highmem pages don't have kmaps.
   529		 *
   530		 * Do this before changing the p2m as kmap_flush_unused()
   531		 * reads PTEs to obtain pages (and hence needs the original
   532		 * p2m entry).
   533		 */
   534		kmap_flush_unused();
   535	
   536		/*
   537		 * Setup the frame, update direct mapping, invalidate P2M,
   538		 * and add to balloon.
   539		 */
   540		i = 0;
   541		list_for_each_entry_safe(page, tmp, &pages, lru) {
   542			frame_list[i++] = xen_page_to_gfn(page);
   543	
   544			list_del(&page->lru);
   545			add_page_to_balloon(page);
   546		}
   547	
   548		flush_tlb_all();
   549	
   550		ret = xenmem_reservation_decrease(nr_pages, frame_list);
   551		BUG_ON(ret != nr_pages);
   552	
   553		balloon_stats.current_pages -= nr_pages;
   554	
   555		return state;
   556	}
   557	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 00:21:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 00:21:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300201.511879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncFuA-0007Pm-OM; Thu, 07 Apr 2022 00:21:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300201.511879; Thu, 07 Apr 2022 00:21:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncFuA-0007Pf-Jo; Thu, 07 Apr 2022 00:21:42 +0000
Received: by outflank-mailman (input) for mailman id 300201;
 Thu, 07 Apr 2022 00:21:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M9ff=UR=oracle.com=konrad.wilk@srs-se1.protection.inumbo.net>)
 id 1ncFu8-0007PZ-Fq
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 00:21:41 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id af094750-b608-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 02:21:36 +0200 (CEST)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236JxCjd014737; 
 Thu, 7 Apr 2022 00:20:25 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6ec9t711-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 00:20:24 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2370Gvp6035271; Thu, 7 Apr 2022 00:20:23 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f974dghn8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 00:20:23 +0000
Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27)
 by DM6PR10MB2956.namprd10.prod.outlook.com (2603:10b6:5:69::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 00:20:20 +0000
Received: from BYAPR10MB2999.namprd10.prod.outlook.com
 ([fe80::b180:d8da:faa9:f897]) by BYAPR10MB2999.namprd10.prod.outlook.com
 ([fe80::b180:d8da:faa9:f897%7]) with mapi id 15.20.5123.031; Thu, 7 Apr 2022
 00:20:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af094750-b608-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : content-type : in-reply-to :
 mime-version; s=corp-2021-07-09;
 bh=mk3bST2LdEJgJrwU5hj0qhsWCMln+w9W1TSOlBEcxF8=;
 b=XBXAd+spGjebDMqS5XyPYAgXMLKiMfggoodVjjQTn+71Z732/t/9tbgz9VVzsT/a7uGL
 kwIxlCESf5BUy+bVM5eBP9ffuwDr8EJWldp0dmlwOnBOYbexzYf1Vbu6Gjb6prNkYIcO
 teczSIzg/lbSEXLLYATOgM2Q+BZWKp3ZeVesHT738sZw8nOaG2NPdwnclYBgYVu0uzoB
 5fWVDa028g+VLpQsvB2cEoUMgY6dXuekL5hzixy3l/cM18UcSUyL8C+dhTijlP3uJr62
 nl+kVsma4bjhgyb1fVxQqqlonAXaMZhdd0BZ3wEEofI98Agj1B8dWrM57eOgLLqz/o8o +Q== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WdXsHIK+9dNPHCZ9ukamixyte5t+lvXscpq1mkD7UGAgTZJzFi4lkj/Rkk3qeXU20QjqeVcPoLmdQawnA6M+LReZmn81S3rQatGbRRfUxVcU9kksytl0tACwMY0LVZYCQuPk9gOac5M0qS/E+qzwPzdh15zYXdkQog5B1OozlSOWSN74OmTspj5Ria1a5YWbzP2ZSLafz7w6SVAQf45rgykEeQwekIJF0NmmsCf2KmDeFa1OQHIDxmNbBO9rP4cHOXkNDuLED+gvnyt7ukIxiJcGpXHeOmiT6bZKbybsra/Xh1k4RGzSAxAQchhKQcjYsrx2z0Pmo/obAEQglgDMRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mk3bST2LdEJgJrwU5hj0qhsWCMln+w9W1TSOlBEcxF8=;
 b=c/JjNXvVu5w3nrms15vOpSOPWfBmRIF14aXo0dQZwGoolbnmwthm3vVUKEfEJcIjghcxe2qUmSz+Drii0ZYyWnSQZHbi1/WZ73vWy4iKXe3sr0H3O9yo5KR3N08TsbT2OXRxom4ye8idJCC+hMPf3Nxu4xZK8NGQtMuB/YBfv4vAD3J8XD8z+vPfACvpxV8OLXSegvGogWzjhcNjBXWr9N8K0444PjbCwOx1Pt5Oz0zB1uLu0O466f3/cVXeu7TDGL6z7J+JTymk24y5XXrJT9glQCMVUOp7AMrZDOzUttqh3xUsygM/WoFXztMlw1FgLqUzmLbS3ioR29eIuMDa1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mk3bST2LdEJgJrwU5hj0qhsWCMln+w9W1TSOlBEcxF8=;
 b=q9TTJqydGvKnUbnxO5da9v1U4OGoUF7Cey3boFSvrnYXpAdl9MRBz+hVWw+MOVSpSOc/PnDkdwVJeoby0NhTlP4hm+GroPjofbmquFctTRpHgoAgW92Rg7zBdzA8lZzm0ybqA6yhY96hVk8cOFjTz4IPPAiob4mqvwu9r5Q2JQI=
Date: Wed, 6 Apr 2022 20:20:14 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org, x86@kernel.org,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
Subject: Re: [PATCH 07/15] x86: remove the IOMMU table infrastructure
Message-ID: <Yk4uPrrtCxwl3hPX@char.us.oracle.com>
References: <20220404050559.132378-1-hch@lst.de>
 <20220404050559.132378-8-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220404050559.132378-8-hch@lst.de>
X-ClientProxiedBy: MN2PR10CA0011.namprd10.prod.outlook.com
 (2603:10b6:208:120::24) To BYAPR10MB2999.namprd10.prod.outlook.com
 (2603:10b6:a03:85::27)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 16e19221-5996-4e90-6829-08da182c65e9
X-MS-TrafficTypeDiagnostic: DM6PR10MB2956:EE_
X-Microsoft-Antispam-PRVS: 
	<DM6PR10MB29566279EE03FA489A2606AE89E69@DM6PR10MB2956.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	HxxlzuPrRhbu0pN1jQy4U+yleqQxwuezNafnkZSqyB9Uvt6+a9JiUutoBnqH7wWyR0NqLXAL/NfuqnIGxrELdf4VVS3fO8C/SlhI2x1wgm+0IPJno2D6aSH/DqGXvf5my/y7crRWshVbbIykmdn27jkSCQS52OSE8xnhJvvlNq1p7lJzHO7dlwrNJlotd/9Yh/7rBxk7e365iaiLMwuUi2z3kuqDaC/9Jvq+zIgnZXOSnwdVcg6t5mwKwer2feb2CE3cJ06r7T9HbWyjeY8VS/YnVaYcLTucTQepuFIXbwBi2XohzzfxDLP0kk3WUzmwgea1Nig35MYUMevjWE1fKPSKipHCDIwLxCXBemGEr8I6P+k6AD2rbiRa/uTulwzIsYtyg/xEJY8BzN/C+AYAsn3zQ0NlyYXYk7K5INICt65qmaGP42T98EjYeye80+GoSH0z2/VKQpwIot4eJerfDlHu/DSELMn5qVhKaN9+Zzde/eowh+t1R0IS4/KPUxIKxXjONNFjNvISpl2cgCNH2hJH9n8HWm7Yag4HlUXupkHLycCrT/HvFfy5BpGkZjrQRwTHI3l3jtlJd/QmSoIbvtUNsE3PALQGO4lM0/DQIP394Rsvfwta3kXkrx2ZSdQcaW4K/4muQwJjDrCns0MmayxLFxvpVWfYL/TAX3fuMGzs+qLWiPcpoFzvTh/rbWe0AjRfx0LxWwMG92hMFeI9jgjp0Acu1pUzDIx54f/R28c=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(38350700002)(54906003)(6486002)(508600001)(6916009)(6666004)(7416002)(52116002)(30864003)(316002)(5660300002)(6506007)(6512007)(2906002)(83380400001)(8936002)(186003)(86362001)(4326008)(26005)(66946007)(66476007)(66556008)(8676002)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?QPDHV93eg3AbCwOHVDnv01iCH1wgK0tQUZ9lCSO6xiMJ63+8EO8NqBGc+WMc?=
 =?us-ascii?Q?musMoEpd8Nux+iMUNqkSZwA4voJcz9FkY6x3oSsIlDLF44XE7nQ2OlPPyhNv?=
 =?us-ascii?Q?7/LhdLv0focGt7W9v5QXAECOiuQwpH7jM7R6Azzp/KW8rdNX6ZN7fDcMsaVr?=
 =?us-ascii?Q?Uw1f8thndQvHjthLwD9FeEgKCbbVf2ogHnr2zzdauTPM9+B405aqU5exWUnE?=
 =?us-ascii?Q?FBF202IiSrrBb+ICnkvbXzRCPG52r+UzU/AVPNNosAXh+ZUgFUaUK3qdTyaT?=
 =?us-ascii?Q?AVThwAuqw8o7ko6qa84NY0+YIVhiWrK/h1Plv12AxXocc7kA3iZBtmrTImvK?=
 =?us-ascii?Q?kn663siaJJb4KhSTHv/SvuTP6QQ25Zk3uVG1KUCAvQHev75nR6Wwvjp19TNI?=
 =?us-ascii?Q?+riI5gaJqvlhSG+7xm4O2wSWbpx3hdicVbGjtl1f5+i4nBDvxus5EfjGpurw?=
 =?us-ascii?Q?gKvLrEJ2X5JZuOyraW0y62Qtpqe8NB4K+Etbex+VrCPTNXwK2ylhFbLwKL5O?=
 =?us-ascii?Q?wg+PUkIdJ0/oxrdAnlQoKtyurus0bvlhio0nhVmgBQrDqmyLEqNd1n5rFeDz?=
 =?us-ascii?Q?XQcI/e80BXPTTXrZ4UYp5dif+NAjn31aPDXvyk4d01WETLB+9uXLV3N7rGoN?=
 =?us-ascii?Q?Y2QBUia8kOUes+G2sztGOSfE6iV7gJmJounNvYLrvo1Yv8fu4NJQZDTAfZc1?=
 =?us-ascii?Q?zA0VR7HaTqor7v7BCmX6TfG5iFhDlbK3ULKhurrCwdWuY+NVCn/BefmZWJDz?=
 =?us-ascii?Q?bAlcCIXYSn8vxvFRX+UbStNJ+QoUzlIf51R1c2Jd5CfB2A+s1AcbZOkCFsvz?=
 =?us-ascii?Q?M2OCFa+y/GvzNZNU32p5uRq4h9uqCSfpwy2OkseoXvWzmcu0GTsljqF+K/1G?=
 =?us-ascii?Q?m4998MWZSzZluA5B2wVNewN/4WC6hlY4RFmPXZsA4Y6PgWJ9UM9bBMi1uho9?=
 =?us-ascii?Q?Qc3BszX2m5vxHw9UJ1kYkPh+WVDVnrjBYLiJd3Uwm2xE8nXC1sytul04jxwq?=
 =?us-ascii?Q?umqYlWUgvn6EUHGhpnXPQSga5q/j5DuBVUbdnHmMQjgAauLCQ/mObk3zd3es?=
 =?us-ascii?Q?H/sBXnBTyaiOQ5rpqGp5YXOO8pR/NW6bgpSNQ7ACLarnR/L+LDyu5eQxOU68?=
 =?us-ascii?Q?HJp7xYTjop6GcSzwvu2P7OWGYaDGTa9CU+0tQUOZT6hU6BEkxh5wW48W1Rt5?=
 =?us-ascii?Q?Pj5nB+UfCbyjNBKAUV94YorrsA4UORIlHHhWHSkZvy80j0EP2EMh+0FdE/FM?=
 =?us-ascii?Q?T2lUbSHVZPXjBhhVokGAQpU6jTlFxFtYdxGcTqH4It21kXj/KqcB3enuG1qC?=
 =?us-ascii?Q?B4MoDaX6UJhTRiewvPdn46FvRuTHoMo//P4g8HbIe2vJq1dgH/CZLnJ4HnsD?=
 =?us-ascii?Q?98AMtIc5MTBLMCXyl7eEKf89zoRt9FgP8prJE3AdseXBEx7oqajwidbquA+u?=
 =?us-ascii?Q?IZ+Cxp3aRvG42oSTR9IPzxe1JlIuESAvzmMu3XHf/yrRtf2qtMXok/7COL5k?=
 =?us-ascii?Q?WbrwKoJwEQ2y4RuqgBF07J6ERRmadzn6Z+LsWbV9I2joXBtf+JMZuOgEIhjH?=
 =?us-ascii?Q?EMJgp+1w0M/zbntufN+ZO9ecmabyCazIn5CYkPygJQIzVTJhrUnUI1SsGSsn?=
 =?us-ascii?Q?0eUumQfxicX2svTQm/9E63K41TuPk7jH29uIpktO8rQM74Q320VEUOLcQA4W?=
 =?us-ascii?Q?qcMhBTQz6IY+NO25DwM2EoAb+UOB3B7JrJT0moheiH5EE5PWzDGjMbYCnWB5?=
 =?us-ascii?Q?d/Bd/feo49hZVVcxTRCyh2Go7r7P4DE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16e19221-5996-4e90-6829-08da182c65e9
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 00:20:19.6425
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zj9PJLDf/UBSfpVnelsQIZAiIsS3Ecw0CDgVWH/Ibvwm9VkvK3xOO+/vorLEIfj2zZ82wLoiuJ1UaeefEBc7Ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2956
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070000
X-Proofpoint-GUID: ytAdH73P7jBCZtsat6az2JD-IJ9dJFDh
X-Proofpoint-ORIG-GUID: ytAdH73P7jBCZtsat6az2JD-IJ9dJFDh

On Mon, Apr 04, 2022 at 07:05:51AM +0200, Christoph Hellwig wrote:
> The IOMMU table tries to separate the different IOMMUs into different
> backends, but actually requires various cross calls.
> 
> Rewrite the code to do the generic swiotlb/swiotlb-xen setup directly
> in pci-dma.c and then just call into the IOMMU drivers.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Hey Christoph,

There is a bit of background behind this - this whole IOMMU table
dynamic was done as at that point of time the pci_iommu_alloc was getting
way to unwieldy - and there needed to be a more 'structured' way with
dependencies.

Hence this creation... But as Christoph points out - it has gotten out
of hand. So smashing it back to a more simplistic mechanism is good.

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thank you!

> ---
>  arch/ia64/include/asm/iommu_table.h    |   7 --
>  arch/x86/include/asm/dma-mapping.h     |   1 -
>  arch/x86/include/asm/gart.h            |   5 +-
>  arch/x86/include/asm/iommu.h           |   6 ++
>  arch/x86/include/asm/iommu_table.h     | 102 -----------------------
>  arch/x86/include/asm/swiotlb.h         |  30 -------
>  arch/x86/include/asm/xen/swiotlb-xen.h |   2 -
>  arch/x86/kernel/Makefile               |   2 -
>  arch/x86/kernel/amd_gart_64.c          |   5 +-
>  arch/x86/kernel/aperture_64.c          |  14 ++--
>  arch/x86/kernel/pci-dma.c              | 107 ++++++++++++++++++++-----
>  arch/x86/kernel/pci-iommu_table.c      |  77 ------------------
>  arch/x86/kernel/pci-swiotlb.c          |  77 ------------------
>  arch/x86/kernel/tboot.c                |   1 -
>  arch/x86/kernel/vmlinux.lds.S          |  12 ---
>  arch/x86/xen/Makefile                  |   2 -
>  arch/x86/xen/pci-swiotlb-xen.c         |  96 ----------------------
>  drivers/iommu/amd/init.c               |   6 --
>  drivers/iommu/amd/iommu.c              |   5 +-
>  drivers/iommu/intel/dmar.c             |   6 +-
>  include/linux/dmar.h                   |   6 +-
>  21 files changed, 110 insertions(+), 459 deletions(-)
>  delete mode 100644 arch/ia64/include/asm/iommu_table.h
>  delete mode 100644 arch/x86/include/asm/iommu_table.h
>  delete mode 100644 arch/x86/include/asm/swiotlb.h
>  delete mode 100644 arch/x86/kernel/pci-iommu_table.c
>  delete mode 100644 arch/x86/kernel/pci-swiotlb.c
>  delete mode 100644 arch/x86/xen/pci-swiotlb-xen.c
> 
> diff --git a/arch/ia64/include/asm/iommu_table.h b/arch/ia64/include/asm/iommu_table.h
> deleted file mode 100644
> index cc96116ac276a..0000000000000
> --- a/arch/ia64/include/asm/iommu_table.h
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _ASM_IA64_IOMMU_TABLE_H
> -#define _ASM_IA64_IOMMU_TABLE_H
> -
> -#define IOMMU_INIT_POST(_detect)
> -
> -#endif /* _ASM_IA64_IOMMU_TABLE_H */
> diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
> index bb1654fe0ce74..256fd8115223d 100644
> --- a/arch/x86/include/asm/dma-mapping.h
> +++ b/arch/x86/include/asm/dma-mapping.h
> @@ -9,7 +9,6 @@
>  
>  #include <linux/scatterlist.h>
>  #include <asm/io.h>
> -#include <asm/swiotlb.h>
>  
>  extern int iommu_merge;
>  extern int panic_on_overflow;
> diff --git a/arch/x86/include/asm/gart.h b/arch/x86/include/asm/gart.h
> index 3185565743459..5af8088a10df6 100644
> --- a/arch/x86/include/asm/gart.h
> +++ b/arch/x86/include/asm/gart.h
> @@ -38,7 +38,7 @@ extern int gart_iommu_aperture_disabled;
>  extern void early_gart_iommu_check(void);
>  extern int gart_iommu_init(void);
>  extern void __init gart_parse_options(char *);
> -extern int gart_iommu_hole_init(void);
> +void gart_iommu_hole_init(void);
>  
>  #else
>  #define gart_iommu_aperture            0
> @@ -51,9 +51,8 @@ static inline void early_gart_iommu_check(void)
>  static inline void gart_parse_options(char *options)
>  {
>  }
> -static inline int gart_iommu_hole_init(void)
> +static inline void gart_iommu_hole_init(void)
>  {
> -	return -ENODEV;
>  }
>  #endif
>  
> diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h
> index bf1ed2ddc74bd..dba89ed40d38d 100644
> --- a/arch/x86/include/asm/iommu.h
> +++ b/arch/x86/include/asm/iommu.h
> @@ -9,6 +9,12 @@
>  extern int force_iommu, no_iommu;
>  extern int iommu_detected;
>  
> +#ifdef CONFIG_SWIOTLB
> +extern bool x86_swiotlb_enable;
> +#else
> +#define x86_swiotlb_enable false
> +#endif
> +
>  /* 10 seconds */
>  #define DMAR_OPERATION_TIMEOUT ((cycles_t) tsc_khz*10*1000)
>  
> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
> deleted file mode 100644
> index 1fb3fd1a83c25..0000000000000
> --- a/arch/x86/include/asm/iommu_table.h
> +++ /dev/null
> @@ -1,102 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _ASM_X86_IOMMU_TABLE_H
> -#define _ASM_X86_IOMMU_TABLE_H
> -
> -#include <asm/swiotlb.h>
> -
> -/*
> - * History lesson:
> - * The execution chain of IOMMUs in 2.6.36 looks as so:
> - *
> - *            [xen-swiotlb]
> - *                 |
> - *         +----[swiotlb *]--+
> - *        /         |         \
> - *       /          |          \
> - *    [GART]     [Calgary]  [Intel VT-d]
> - *     /
> - *    /
> - * [AMD-Vi]
> - *
> - * *: if SWIOTLB detected 'iommu=soft'/'swiotlb=force' it would skip
> - * over the rest of IOMMUs and unconditionally initialize the SWIOTLB.
> - * Also it would surreptitiously initialize set the swiotlb=1 if there were
> - * more than 4GB and if the user did not pass in 'iommu=off'. The swiotlb
> - * flag would be turned off by all IOMMUs except the Calgary one.
> - *
> - * The IOMMU_INIT* macros allow a similar tree (or more complex if desired)
> - * to be built by defining who we depend on.
> - *
> - * And all that needs to be done is to use one of the macros in the IOMMU
> - * and the pci-dma.c will take care of the rest.
> - */
> -
> -struct iommu_table_entry {
> -	initcall_t	detect;
> -	initcall_t	depend;
> -	void		(*early_init)(void); /* No memory allocate available. */
> -	void		(*late_init)(void); /* Yes, can allocate memory. */
> -#define IOMMU_FINISH_IF_DETECTED (1<<0)
> -#define IOMMU_DETECTED		 (1<<1)
> -	int		flags;
> -};
> -/*
> - * Macro fills out an entry in the .iommu_table that is equivalent
> - * to the fields that 'struct iommu_table_entry' has. The entries
> - * that are put in the .iommu_table section are not put in any order
> - * hence during boot-time we will have to resort them based on
> - * dependency. */
> -
> -
> -#define __IOMMU_INIT(_detect, _depend, _early_init, _late_init, _finish)\
> -	static const struct iommu_table_entry				\
> -		__iommu_entry_##_detect __used				\
> -	__attribute__ ((unused, __section__(".iommu_table"),		\
> -			aligned((sizeof(void *)))))	\
> -	= {_detect, _depend, _early_init, _late_init,			\
> -	   _finish ? IOMMU_FINISH_IF_DETECTED : 0}
> -/*
> - * The simplest IOMMU definition. Provide the detection routine
> - * and it will be run after the SWIOTLB and the other IOMMUs
> - * that utilize this macro. If the IOMMU is detected (ie, the
> - * detect routine returns a positive value), the other IOMMUs
> - * are also checked. You can use IOMMU_INIT_POST_FINISH if you prefer
> - * to stop detecting the other IOMMUs after yours has been detected.
> - */
> -#define IOMMU_INIT_POST(_detect)					\
> -	__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb,  NULL, NULL, 0)
> -
> -#define IOMMU_INIT_POST_FINISH(detect)					\
> -	__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb,  NULL, NULL, 1)
> -
> -/*
> - * A more sophisticated version of IOMMU_INIT. This variant requires:
> - *  a). A detection routine function.
> - *  b). The name of the detection routine we depend on to get called
> - *      before us.
> - *  c). The init routine which gets called if the detection routine
> - *      returns a positive value from the pci_iommu_alloc. This means
> - *      no presence of a memory allocator.
> - *  d). Similar to the 'init', except that this gets called from pci_iommu_init
> - *      where we do have a memory allocator.
> - *
> - * The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant
> - * in that the former will continue detecting other IOMMUs in the call
> - * list after the detection routine returns a positive number, while the
> - * latter will stop the execution chain upon first successful detection.
> - * Both variants will still call the 'init' and 'late_init' functions if
> - * they are set.
> - */
> -#define IOMMU_INIT_FINISH(_detect, _depend, _init, _late_init)		\
> -	__IOMMU_INIT(_detect, _depend, _init, _late_init, 1)
> -
> -#define IOMMU_INIT(_detect, _depend, _init, _late_init)			\
> -	__IOMMU_INIT(_detect, _depend, _init, _late_init, 0)
> -
> -void sort_iommu_table(struct iommu_table_entry *start,
> -		      struct iommu_table_entry *finish);
> -
> -void check_iommu_entries(struct iommu_table_entry *start,
> -			 struct iommu_table_entry *finish);
> -
> -#endif /* _ASM_X86_IOMMU_TABLE_H */
> diff --git a/arch/x86/include/asm/swiotlb.h b/arch/x86/include/asm/swiotlb.h
> deleted file mode 100644
> index ff6c92eff035a..0000000000000
> --- a/arch/x86/include/asm/swiotlb.h
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _ASM_X86_SWIOTLB_H
> -#define _ASM_X86_SWIOTLB_H
> -
> -#include <linux/swiotlb.h>
> -
> -#ifdef CONFIG_SWIOTLB
> -extern int swiotlb;
> -extern int __init pci_swiotlb_detect_override(void);
> -extern int __init pci_swiotlb_detect_4gb(void);
> -extern void __init pci_swiotlb_init(void);
> -extern void __init pci_swiotlb_late_init(void);
> -#else
> -#define swiotlb 0
> -static inline int pci_swiotlb_detect_override(void)
> -{
> -	return 0;
> -}
> -static inline int pci_swiotlb_detect_4gb(void)
> -{
> -	return 0;
> -}
> -static inline void pci_swiotlb_init(void)
> -{
> -}
> -static inline void pci_swiotlb_late_init(void)
> -{
> -}
> -#endif
> -#endif /* _ASM_X86_SWIOTLB_H */
> diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h
> index 66b4ddde77430..e5a90b42e4dde 100644
> --- a/arch/x86/include/asm/xen/swiotlb-xen.h
> +++ b/arch/x86/include/asm/xen/swiotlb-xen.h
> @@ -3,10 +3,8 @@
>  #define _ASM_X86_SWIOTLB_XEN_H
>  
>  #ifdef CONFIG_SWIOTLB_XEN
> -extern int __init pci_xen_swiotlb_detect(void);
>  extern int pci_xen_swiotlb_init_late(void);
>  #else
> -#define pci_xen_swiotlb_detect NULL
>  static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }
>  #endif
>  
> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> index c41ef42adbe8a..e17b7e92a3fa3 100644
> --- a/arch/x86/kernel/Makefile
> +++ b/arch/x86/kernel/Makefile
> @@ -68,7 +68,6 @@ obj-y			+= bootflag.o e820.o
>  obj-y			+= pci-dma.o quirks.o topology.o kdebugfs.o
>  obj-y			+= alternative.o i8253.o hw_breakpoint.o
>  obj-y			+= tsc.o tsc_msr.o io_delay.o rtc.o
> -obj-y			+= pci-iommu_table.o
>  obj-y			+= resource.o
>  obj-y			+= irqflags.o
>  obj-y			+= static_call.o
> @@ -134,7 +133,6 @@ obj-$(CONFIG_PCSPKR_PLATFORM)	+= pcspeaker.o
>  
>  obj-$(CONFIG_X86_CHECK_BIOS_CORRUPTION) += check.o
>  
> -obj-$(CONFIG_SWIOTLB)			+= pci-swiotlb.o
>  obj-$(CONFIG_OF)			+= devicetree.o
>  obj-$(CONFIG_UPROBES)			+= uprobes.o
>  
> diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c
> index ed837383de5c8..194d54eed5376 100644
> --- a/arch/x86/kernel/amd_gart_64.c
> +++ b/arch/x86/kernel/amd_gart_64.c
> @@ -38,11 +38,9 @@
>  #include <asm/iommu.h>
>  #include <asm/gart.h>
>  #include <asm/set_memory.h>
> -#include <asm/swiotlb.h>
>  #include <asm/dma.h>
>  #include <asm/amd_nb.h>
>  #include <asm/x86_init.h>
> -#include <asm/iommu_table.h>
>  
>  static unsigned long iommu_bus_base;	/* GART remapping area (physical) */
>  static unsigned long iommu_size;	/* size of remapping area bytes */
> @@ -808,7 +806,7 @@ int __init gart_iommu_init(void)
>  	flush_gart();
>  	dma_ops = &gart_dma_ops;
>  	x86_platform.iommu_shutdown = gart_iommu_shutdown;
> -	swiotlb = 0;
> +	x86_swiotlb_enable = false;
>  
>  	return 0;
>  }
> @@ -842,4 +840,3 @@ void __init gart_parse_options(char *p)
>  		}
>  	}
>  }
> -IOMMU_INIT_POST(gart_iommu_hole_init);
> diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
> index af3ba08b684b5..7a5630d904b23 100644
> --- a/arch/x86/kernel/aperture_64.c
> +++ b/arch/x86/kernel/aperture_64.c
> @@ -392,7 +392,7 @@ void __init early_gart_iommu_check(void)
>  
>  static int __initdata printed_gart_size_msg;
>  
> -int __init gart_iommu_hole_init(void)
> +void __init gart_iommu_hole_init(void)
>  {
>  	u32 agp_aper_base = 0, agp_aper_order = 0;
>  	u32 aper_size, aper_alloc = 0, aper_order = 0, last_aper_order = 0;
> @@ -401,11 +401,11 @@ int __init gart_iommu_hole_init(void)
>  	int i, node;
>  
>  	if (!amd_gart_present())
> -		return -ENODEV;
> +		return;
>  
>  	if (gart_iommu_aperture_disabled || !fix_aperture ||
>  	    !early_pci_allowed())
> -		return -ENODEV;
> +		return;
>  
>  	pr_info("Checking aperture...\n");
>  
> @@ -491,10 +491,8 @@ int __init gart_iommu_hole_init(void)
>  			 * and fixed up the northbridge
>  			 */
>  			exclude_from_core(last_aper_base, last_aper_order);
> -
> -			return 1;
>  		}
> -		return 0;
> +		return;
>  	}
>  
>  	if (!fallback_aper_force) {
> @@ -527,7 +525,7 @@ int __init gart_iommu_hole_init(void)
>  			panic("Not enough memory for aperture");
>  		}
>  	} else {
> -		return 0;
> +		return;
>  	}
>  
>  	/*
> @@ -561,6 +559,4 @@ int __init gart_iommu_hole_init(void)
>  	}
>  
>  	set_up_gart_resume(aper_order, aper_alloc);
> -
> -	return 1;
>  }
> diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
> index de234e7a8962e..df96926421be0 100644
> --- a/arch/x86/kernel/pci-dma.c
> +++ b/arch/x86/kernel/pci-dma.c
> @@ -7,13 +7,16 @@
>  #include <linux/memblock.h>
>  #include <linux/gfp.h>
>  #include <linux/pci.h>
> +#include <linux/amd-iommu.h>
>  
>  #include <asm/proto.h>
>  #include <asm/dma.h>
>  #include <asm/iommu.h>
>  #include <asm/gart.h>
>  #include <asm/x86_init.h>
> -#include <asm/iommu_table.h>
> +
> +#include <xen/xen.h>
> +#include <xen/swiotlb-xen.h>
>  
>  static bool disable_dac_quirk __read_mostly;
>  
> @@ -34,24 +37,83 @@ int no_iommu __read_mostly;
>  /* Set this to 1 if there is a HW IOMMU in the system */
>  int iommu_detected __read_mostly = 0;
>  
> -extern struct iommu_table_entry __iommu_table[], __iommu_table_end[];
> +#ifdef CONFIG_SWIOTLB
> +bool x86_swiotlb_enable;
> +
> +static void __init pci_swiotlb_detect(void)
> +{
> +	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
> +	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
> +		x86_swiotlb_enable = true;
> +
> +	/*
> +	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
> +	 * devices that can't support DMA to encrypted memory.
> +	 */
> +	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
> +		x86_swiotlb_enable = true;
> +
> +	if (swiotlb_force == SWIOTLB_FORCE)
> +		x86_swiotlb_enable = true;
> +}
> +#else
> +static inline void __init pci_swiotlb_detect(void)
> +{
> +}
> +#endif /* CONFIG_SWIOTLB */
> +
> +#ifdef CONFIG_SWIOTLB_XEN
> +static bool xen_swiotlb;
> +
> +static void __init pci_xen_swiotlb_init(void)
> +{
> +	if (!xen_initial_domain() && !x86_swiotlb_enable &&
> +	    swiotlb_force != SWIOTLB_FORCE)
> +		return;
> +	x86_swiotlb_enable = true;
> +	xen_swiotlb = true;
> +	xen_swiotlb_init_early();
> +	dma_ops = &xen_swiotlb_dma_ops;
> +	if (IS_ENABLED(CONFIG_PCI))
> +		pci_request_acs();
> +}
> +
> +int pci_xen_swiotlb_init_late(void)
> +{
> +	int rc;
> +
> +	if (xen_swiotlb)
> +		return 0;
> +
> +	rc = xen_swiotlb_init();
> +	if (rc)
> +		return rc;
> +
> +	/* XXX: this switches the dma ops under live devices! */
> +	dma_ops = &xen_swiotlb_dma_ops;
> +	if (IS_ENABLED(CONFIG_PCI))
> +		pci_request_acs();
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
> +#else
> +static inline void __init pci_xen_swiotlb_init(void)
> +{
> +}
> +#endif /* CONFIG_SWIOTLB_XEN */
>  
>  void __init pci_iommu_alloc(void)
>  {
> -	struct iommu_table_entry *p;
> -
> -	sort_iommu_table(__iommu_table, __iommu_table_end);
> -	check_iommu_entries(__iommu_table, __iommu_table_end);
> -
> -	for (p = __iommu_table; p < __iommu_table_end; p++) {
> -		if (p && p->detect && p->detect() > 0) {
> -			p->flags |= IOMMU_DETECTED;
> -			if (p->early_init)
> -				p->early_init();
> -			if (p->flags & IOMMU_FINISH_IF_DETECTED)
> -				break;
> -		}
> +	if (xen_pv_domain()) {
> +		pci_xen_swiotlb_init();
> +		return;
>  	}
> +	pci_swiotlb_detect();
> +	gart_iommu_hole_init();
> +	amd_iommu_detect();
> +	detect_intel_iommu();
> +	if (x86_swiotlb_enable)
> +		swiotlb_init(0);
>  }
>  
>  /*
> @@ -102,7 +164,7 @@ static __init int iommu_setup(char *p)
>  		}
>  #ifdef CONFIG_SWIOTLB
>  		if (!strncmp(p, "soft", 4))
> -			swiotlb = 1;
> +			x86_swiotlb_enable = true;
>  #endif
>  		if (!strncmp(p, "pt", 2))
>  			iommu_set_default_passthrough(true);
> @@ -121,14 +183,17 @@ early_param("iommu", iommu_setup);
>  
>  static int __init pci_iommu_init(void)
>  {
> -	struct iommu_table_entry *p;
> -
>  	x86_init.iommu.iommu_init();
>  
> -	for (p = __iommu_table; p < __iommu_table_end; p++) {
> -		if (p && (p->flags & IOMMU_DETECTED) && p->late_init)
> -			p->late_init();
> +#ifdef CONFIG_SWIOTLB
> +	/* An IOMMU turned us off. */
> +	if (x86_swiotlb_enable) {
> +		pr_info("PCI-DMA: Using software bounce buffering for IO (SWIOTLB)\n");
> +		swiotlb_print_info();
> +	} else {
> +		swiotlb_exit();
>  	}
> +#endif
>  
>  	return 0;
>  }
> diff --git a/arch/x86/kernel/pci-iommu_table.c b/arch/x86/kernel/pci-iommu_table.c
> deleted file mode 100644
> index 42e92ec62973b..0000000000000
> --- a/arch/x86/kernel/pci-iommu_table.c
> +++ /dev/null
> @@ -1,77 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -#include <linux/dma-mapping.h>
> -#include <asm/iommu_table.h>
> -#include <linux/string.h>
> -#include <linux/kallsyms.h>
> -
> -static struct iommu_table_entry * __init
> -find_dependents_of(struct iommu_table_entry *start,
> -		   struct iommu_table_entry *finish,
> -		   struct iommu_table_entry *q)
> -{
> -	struct iommu_table_entry *p;
> -
> -	if (!q)
> -		return NULL;
> -
> -	for (p = start; p < finish; p++)
> -		if (p->detect == q->depend)
> -			return p;
> -
> -	return NULL;
> -}
> -
> -
> -void __init sort_iommu_table(struct iommu_table_entry *start,
> -			     struct iommu_table_entry *finish) {
> -
> -	struct iommu_table_entry *p, *q, tmp;
> -
> -	for (p = start; p < finish; p++) {
> -again:
> -		q = find_dependents_of(start, finish, p);
> -		/* We are bit sneaky here. We use the memory address to figure
> -		 * out if the node we depend on is past our point, if so, swap.
> -		 */
> -		if (q > p) {
> -			tmp = *p;
> -			memmove(p, q, sizeof(*p));
> -			*q = tmp;
> -			goto again;
> -		}
> -	}
> -
> -}
> -
> -#ifdef DEBUG
> -void __init check_iommu_entries(struct iommu_table_entry *start,
> -				struct iommu_table_entry *finish)
> -{
> -	struct iommu_table_entry *p, *q, *x;
> -
> -	/* Simple cyclic dependency checker. */
> -	for (p = start; p < finish; p++) {
> -		q = find_dependents_of(start, finish, p);
> -		x = find_dependents_of(start, finish, q);
> -		if (p == x) {
> -			printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %pS depends on %pS and vice-versa. BREAKING IT.\n",
> -			       p->detect, q->detect);
> -			/* Heavy handed way..*/
> -			x->depend = NULL;
> -		}
> -	}
> -
> -	for (p = start; p < finish; p++) {
> -		q = find_dependents_of(p, finish, p);
> -		if (q && q > p) {
> -			printk(KERN_ERR "EXECUTION ORDER INVALID! %pS should be called before %pS!\n",
> -			       p->detect, q->detect);
> -		}
> -	}
> -}
> -#else
> -void __init check_iommu_entries(struct iommu_table_entry *start,
> -				       struct iommu_table_entry *finish)
> -{
> -}
> -#endif
> diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
> deleted file mode 100644
> index 814ab46a0dada..0000000000000
> --- a/arch/x86/kernel/pci-swiotlb.c
> +++ /dev/null
> @@ -1,77 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -
> -#include <linux/pci.h>
> -#include <linux/cache.h>
> -#include <linux/init.h>
> -#include <linux/swiotlb.h>
> -#include <linux/memblock.h>
> -#include <linux/dma-direct.h>
> -#include <linux/cc_platform.h>
> -
> -#include <asm/iommu.h>
> -#include <asm/swiotlb.h>
> -#include <asm/dma.h>
> -#include <asm/xen/swiotlb-xen.h>
> -#include <asm/iommu_table.h>
> -
> -int swiotlb __read_mostly;
> -
> -/*
> - * pci_swiotlb_detect_override - set swiotlb to 1 if necessary
> - *
> - * This returns non-zero if we are forced to use swiotlb (by the boot
> - * option).
> - */
> -int __init pci_swiotlb_detect_override(void)
> -{
> -	if (swiotlb_force == SWIOTLB_FORCE)
> -		swiotlb = 1;
> -
> -	return swiotlb;
> -}
> -IOMMU_INIT_FINISH(pci_swiotlb_detect_override,
> -		  pci_xen_swiotlb_detect,
> -		  pci_swiotlb_init,
> -		  pci_swiotlb_late_init);
> -
> -/*
> - * If 4GB or more detected (and iommu=off not set) or if SME is active
> - * then set swiotlb to 1 and return 1.
> - */
> -int __init pci_swiotlb_detect_4gb(void)
> -{
> -	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
> -	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
> -		swiotlb = 1;
> -
> -	/*
> -	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
> -	 * devices that can't support DMA to encrypted memory.
> -	 */
> -	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
> -		swiotlb = 1;
> -
> -	return swiotlb;
> -}
> -IOMMU_INIT(pci_swiotlb_detect_4gb,
> -	   pci_swiotlb_detect_override,
> -	   pci_swiotlb_init,
> -	   pci_swiotlb_late_init);
> -
> -void __init pci_swiotlb_init(void)
> -{
> -	if (swiotlb)
> -		swiotlb_init(0);
> -}
> -
> -void __init pci_swiotlb_late_init(void)
> -{
> -	/* An IOMMU turned us off. */
> -	if (!swiotlb)
> -		swiotlb_exit();
> -	else {
> -		printk(KERN_INFO "PCI-DMA: "
> -		       "Using software bounce buffering for IO (SWIOTLB)\n");
> -		swiotlb_print_info();
> -	}
> -}
> diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
> index f9af561c3cd4f..0c1154a1c4032 100644
> --- a/arch/x86/kernel/tboot.c
> +++ b/arch/x86/kernel/tboot.c
> @@ -24,7 +24,6 @@
>  #include <asm/processor.h>
>  #include <asm/bootparam.h>
>  #include <asm/pgalloc.h>
> -#include <asm/swiotlb.h>
>  #include <asm/fixmap.h>
>  #include <asm/proto.h>
>  #include <asm/setup.h>
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index 7fda7f27e7620..f5f6dc2e80072 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -315,18 +315,6 @@ SECTIONS
>  		*(.altinstr_replacement)
>  	}
>  
> -	/*
> -	 * struct iommu_table_entry entries are injected in this section.
> -	 * It is an array of IOMMUs which during run time gets sorted depending
> -	 * on its dependency order. After rootfs_initcall is complete
> -	 * this section can be safely removed.
> -	 */
> -	.iommu_table : AT(ADDR(.iommu_table) - LOAD_OFFSET) {
> -		__iommu_table = .;
> -		*(.iommu_table)
> -		__iommu_table_end = .;
> -	}
> -
>  	. = ALIGN(8);
>  	.apicdrivers : AT(ADDR(.apicdrivers) - LOAD_OFFSET) {
>  		__apicdrivers = .;
> diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
> index 4953260e281c3..3c5b52fbe4a7f 100644
> --- a/arch/x86/xen/Makefile
> +++ b/arch/x86/xen/Makefile
> @@ -47,6 +47,4 @@ obj-$(CONFIG_XEN_DEBUG_FS)	+= debugfs.o
>  
>  obj-$(CONFIG_XEN_PV_DOM0)	+= vga.o
>  
> -obj-$(CONFIG_SWIOTLB_XEN)	+= pci-swiotlb-xen.o
> -
>  obj-$(CONFIG_XEN_EFI)		+= efi.o
> diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
> deleted file mode 100644
> index 46df59aeaa06a..0000000000000
> --- a/arch/x86/xen/pci-swiotlb-xen.c
> +++ /dev/null
> @@ -1,96 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -
> -/* Glue code to lib/swiotlb-xen.c */
> -
> -#include <linux/dma-map-ops.h>
> -#include <linux/pci.h>
> -#include <xen/swiotlb-xen.h>
> -
> -#include <asm/xen/hypervisor.h>
> -#include <xen/xen.h>
> -#include <asm/iommu_table.h>
> -
> -
> -#include <asm/xen/swiotlb-xen.h>
> -#ifdef CONFIG_X86_64
> -#include <asm/iommu.h>
> -#include <asm/dma.h>
> -#endif
> -#include <linux/export.h>
> -
> -static int xen_swiotlb __read_mostly;
> -
> -/*
> - * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary
> - *
> - * This returns non-zero if we are forced to use xen_swiotlb (by the boot
> - * option).
> - */
> -int __init pci_xen_swiotlb_detect(void)
> -{
> -
> -	if (!xen_pv_domain())
> -		return 0;
> -
> -	/* If running as PV guest, either iommu=soft, or swiotlb=force will
> -	 * activate this IOMMU. If running as PV privileged, activate it
> -	 * irregardless.
> -	 */
> -	if (xen_initial_domain() || swiotlb || swiotlb_force == SWIOTLB_FORCE)
> -		xen_swiotlb = 1;
> -
> -	/* If we are running under Xen, we MUST disable the native SWIOTLB.
> -	 * Don't worry about swiotlb_force flag activating the native, as
> -	 * the 'swiotlb' flag is the only one turning it on. */
> -	swiotlb = 0;
> -
> -#ifdef CONFIG_X86_64
> -	/* pci_swiotlb_detect_4gb turns on native SWIOTLB if no_iommu == 0
> -	 * (so no iommu=X command line over-writes).
> -	 * Considering that PV guests do not want the *native SWIOTLB* but
> -	 * only Xen SWIOTLB it is not useful to us so set no_iommu=1 here.
> -	 */
> -	if (max_pfn > MAX_DMA32_PFN)
> -		no_iommu = 1;
> -#endif
> -	return xen_swiotlb;
> -}
> -
> -static void __init pci_xen_swiotlb_init(void)
> -{
> -	if (xen_swiotlb) {
> -		xen_swiotlb_init_early();
> -		dma_ops = &xen_swiotlb_dma_ops;
> -
> -#ifdef CONFIG_PCI
> -		/* Make sure ACS will be enabled */
> -		pci_request_acs();
> -#endif
> -	}
> -}
> -
> -int pci_xen_swiotlb_init_late(void)
> -{
> -	int rc;
> -
> -	if (xen_swiotlb)
> -		return 0;
> -
> -	rc = xen_swiotlb_init();
> -	if (rc)
> -		return rc;
> -
> -	dma_ops = &xen_swiotlb_dma_ops;
> -#ifdef CONFIG_PCI
> -	/* Make sure ACS will be enabled */
> -	pci_request_acs();
> -#endif
> -
> -	return 0;
> -}
> -EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
> -
> -IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
> -		  NULL,
> -		  pci_xen_swiotlb_init,
> -		  NULL);
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index b4a798c7b347f..1a3ad58ba8465 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -27,7 +27,6 @@
>  #include <asm/apic.h>
>  #include <asm/gart.h>
>  #include <asm/x86_init.h>
> -#include <asm/iommu_table.h>
>  #include <asm/io_apic.h>
>  #include <asm/irq_remapping.h>
>  #include <asm/set_memory.h>
> @@ -3257,11 +3256,6 @@ __setup("ivrs_ioapic",		parse_ivrs_ioapic);
>  __setup("ivrs_hpet",		parse_ivrs_hpet);
>  __setup("ivrs_acpihid",		parse_ivrs_acpihid);
>  
> -IOMMU_INIT_FINISH(amd_iommu_detect,
> -		  gart_iommu_hole_init,
> -		  NULL,
> -		  NULL);
> -
>  bool amd_iommu_v2_supported(void)
>  {
>  	return amd_iommu_v2_present;
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index a1ada7bff44e6..b47220ac09eaa 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -1840,7 +1840,10 @@ void amd_iommu_domain_update(struct protection_domain *domain)
>  
>  static void __init amd_iommu_init_dma_ops(void)
>  {
> -	swiotlb = (iommu_default_passthrough() || sme_me_mask) ? 1 : 0;
> +	if (iommu_default_passthrough() || sme_me_mask)
> +		x86_swiotlb_enable = true;
> +	else
> +		x86_swiotlb_enable = false;
>  }
>  
>  int __init amd_iommu_init_api(void)
> diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
> index 4de960834a1b2..592c1e1a5d4b9 100644
> --- a/drivers/iommu/intel/dmar.c
> +++ b/drivers/iommu/intel/dmar.c
> @@ -30,7 +30,6 @@
>  #include <linux/numa.h>
>  #include <linux/limits.h>
>  #include <asm/irq_remapping.h>
> -#include <asm/iommu_table.h>
>  #include <trace/events/intel_iommu.h>
>  
>  #include "../irq_remapping.h"
> @@ -912,7 +911,7 @@ dmar_validate_one_drhd(struct acpi_dmar_header *entry, void *arg)
>  	return 0;
>  }
>  
> -int __init detect_intel_iommu(void)
> +void __init detect_intel_iommu(void)
>  {
>  	int ret;
>  	struct dmar_res_callback validate_drhd_cb = {
> @@ -945,8 +944,6 @@ int __init detect_intel_iommu(void)
>  		dmar_tbl = NULL;
>  	}
>  	up_write(&dmar_global_lock);
> -
> -	return ret ? ret : 1;
>  }
>  
>  static void unmap_iommu(struct intel_iommu *iommu)
> @@ -2164,7 +2161,6 @@ static int __init dmar_free_unused_resources(void)
>  }
>  
>  late_initcall(dmar_free_unused_resources);
> -IOMMU_INIT_POST(detect_intel_iommu);
>  
>  /*
>   * DMAR Hotplug Support
> diff --git a/include/linux/dmar.h b/include/linux/dmar.h
> index 45e903d847335..cbd714a198a0a 100644
> --- a/include/linux/dmar.h
> +++ b/include/linux/dmar.h
> @@ -121,7 +121,7 @@ extern int dmar_remove_dev_scope(struct dmar_pci_notify_info *info,
>  				 u16 segment, struct dmar_dev_scope *devices,
>  				 int count);
>  /* Intel IOMMU detection */
> -extern int detect_intel_iommu(void);
> +void detect_intel_iommu(void);
>  extern int enable_drhd_fault_handling(void);
>  extern int dmar_device_add(acpi_handle handle);
>  extern int dmar_device_remove(acpi_handle handle);
> @@ -197,6 +197,10 @@ static inline bool dmar_platform_optin(void)
>  	return false;
>  }
>  
> +static inline void detect_intel_iommu(void)
> +{
> +}
> +
>  #endif /* CONFIG_DMAR_TABLE */
>  
>  struct irte {
> -- 
> 2.30.2
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 00:26:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 00:26:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300206.511889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncFyb-000871-Ex; Thu, 07 Apr 2022 00:26:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300206.511889; Thu, 07 Apr 2022 00:26:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncFyb-00086u-Bd; Thu, 07 Apr 2022 00:26:17 +0000
Received: by outflank-mailman (input) for mailman id 300206;
 Thu, 07 Apr 2022 00:26:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M9ff=UR=oracle.com=konrad.wilk@srs-se1.protection.inumbo.net>)
 id 1ncFya-00086o-Hb
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 00:26:16 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 552b1de7-b609-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 02:26:15 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236KTkns024455; 
 Thu, 7 Apr 2022 00:25:42 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6f1tajsg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 00:25:41 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2370GwCX035353; Thu, 7 Apr 2022 00:25:40 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2177.outbound.protection.outlook.com [104.47.56.177])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f974dgmv8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 00:25:40 +0000
Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27)
 by DM6PR10MB2956.namprd10.prod.outlook.com (2603:10b6:5:69::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 00:25:37 +0000
Received: from BYAPR10MB2999.namprd10.prod.outlook.com
 ([fe80::b180:d8da:faa9:f897]) by BYAPR10MB2999.namprd10.prod.outlook.com
 ([fe80::b180:d8da:faa9:f897%7]) with mapi id 15.20.5123.031; Thu, 7 Apr 2022
 00:25:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 552b1de7-b609-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : content-type : in-reply-to :
 mime-version; s=corp-2021-07-09;
 bh=4VBD+xTDrv7ic3fHzrAugnoyxmDzOdFCwThtcFLyfUM=;
 b=kfgCrQ3xHjIQumzQLPkl8jM4boNWtsdnergYf7u15HG02AXCYOqIXhrPftqK3PcTVVZg
 DwCFcDgLkB3biYaGSEX84Lw1z5f4JnFreu2dEnkfUneeBZe9AMDsugxQVQjKfyA+sN+C
 FPEMxbEjoTdIVjUbeQPcd8r/+9YW+41kBAwLsQ/Qhx8aWKDeYAD2vqg/nl5sTaLQizQp
 c6VxS7AC+xDYwWtoVZJEa3qNF0Eb1xqOatk7H5HMJ/adgR4GH4F4NSKBloKTchbAxaIR
 6Nz/QGtYojpun8h+5skhsAoeUu5/oGw/+r3T3E2DH/dw69jEvxruo0DubKZxNMUghHk4 /w== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EHUqu8wMc+5BNgLOSG5XOMsN8ev3KbNVUoIQ3Gv9x9XTBePvvYtSmol0aJBBHeN1zzPHzv6e56R7O3a0dukSuCNRkSPE0wyHEGxGf/Yhfe3n5mnCzrF0xMKowQA+Wc+7+VGuyyKGrq3gzcuMhUzKS+nL8OS+0QlDVwhNVZGcc4PzZ11UrcTfW0EXzF8oMaBvWFZrMyUq0ORfm5h+gHN3bSpbLpIXbmvUglB/xUEKXSuTHosBOjMAIx2w0MxJRKz5XGzwR6FCCGf0eM6f0KnKLF4pDNF0EM/WIyoMJrxSl2Qeh85LMWW+NV8c72dgp4jKumw5RceE+JzuFmTHRXRZsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4VBD+xTDrv7ic3fHzrAugnoyxmDzOdFCwThtcFLyfUM=;
 b=ASj8M2afa9KH38oyc8YA+wYn2gMFKB7/WngAY0QRBO4ssyuJTcTD3FXKtZd0HdhNoN9zWxGTguRBiEn9qbkJigrG+UvHD6BsDs6MwlDtLTaxgOBmYxA9tmI2arXhFUL+mgKBVpnzGWbZLnl5D+ZbZsMbCfmDwK5gnH7hoY59WnOXCctuwOUit38MvzFqDTPLsPBUtXQpMQoZhMONxlNlyyaIQi5Ty7J85dXAd4JlWl4RDLqO/0wmhROKpFYOY4LInMJv500hnEJDQFqtiUoq5UzCV661YedujdTC+7xszqTLKdZ16mPC3+St4tTvR+pFqNtWkO4IRNyvOF9IqwZe1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4VBD+xTDrv7ic3fHzrAugnoyxmDzOdFCwThtcFLyfUM=;
 b=ZWOnuZYC2RzkWruEmhx2TXkEiRTBg1h4kCuYFZuu0a4zY6nhqgugq1flS7AsVnBe+0uDTdIGKsV7U/djKYXypWMRvT2KuaqWymoQsy7+KKsX8DsOPUonck5HnZQakW9rZeJP8qchfAA8gy0paqeP33poSCeMWjMl/ZLnSI/vZes=
Date: Wed, 6 Apr 2022 20:25:32 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org, x86@kernel.org,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
Subject: Re: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low
 memory restriction
Message-ID: <Yk4vfAd0J5u+wUsq@char.us.oracle.com>
References: <20220404050559.132378-1-hch@lst.de>
 <20220404050559.132378-11-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220404050559.132378-11-hch@lst.de>
X-ClientProxiedBy: BL0PR01CA0007.prod.exchangelabs.com (2603:10b6:208:71::20)
 To BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 32cfdc6d-28c4-405c-95a6-08da182d233c
X-MS-TrafficTypeDiagnostic: DM6PR10MB2956:EE_
X-Microsoft-Antispam-PRVS: 
	<DM6PR10MB29563B03BB66A0758EDBE81389E69@DM6PR10MB2956.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	yVEMdlbl17J2sBucHVU49RSEesVaMFb1Clrv9I8dCMmu32Nqky5c6OzeBII5Glgtnl3qHhCV7TosVnYpNqAD1ZP0+fgZs4fAp0AsQYWiauVL/DQxRrd9uw9Zjkc+/AGktlT3mEfz6P4aPIJNGesLuJKxh+77Ql3Fys0vDG+OOS5Bt9UtRZPnOq+cxcGnGoi7u6MnvCNKBdhqA4JqLdZDDL/hWD3S6LK64ibPmM65VqwiUpdompvZwbNcQayexT5C+NEnJKE8joinWrDXDZecfCcDRBdA0ZvgYHoR3GqFI5zdsBOh5wSOf1lsaQHRPcNOU+aHNbo2l40YWMDUHkfls9Q5tvgZNC6yBBfkAdEizQHnY19BfPzj4BDttjpYq+Ig4CcnqQSy2O8c2t+oYZA13bnbf9wDUQVTci4f8eSjq3r5lwjtbJb3m8pVvyrQ36SA1gNRTyX/BIqa/gFHOTBASChu0gH5SjbSp3c8uKZHma+iO6EyIsUUM2ZFfELUr9QodFTCExDly4oHkK3XxZHkH8n3lMt9uwO6yB0V7AkfKt+dtv9STsV0XBp662ij56m97co7BCGtAYPkXPR/u/KqQx9IoTp5G1iE/CJZOTHLhJrD2VfiXKPTlWKKtKe9h1qHrJDBJluDetb3YIefxI4U6C1vtOa/lgCm7k5fLGsi59zQa+RCWC0bOmjqPXXA8rTwAJgUHe/gLV51EkEAhKMb8iVDyrD2fAkKIHSNy5tOCYE=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(38350700002)(54906003)(6486002)(508600001)(4744005)(6916009)(6666004)(7416002)(52116002)(316002)(5660300002)(6506007)(6512007)(2906002)(8936002)(186003)(86362001)(4326008)(26005)(66946007)(66476007)(66556008)(8676002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?SsskQz4wBvmzjo+shgAHYZrhtqz967Ls1yCu2hR1EII5QJUuEec9hZddsl5h?=
 =?us-ascii?Q?jMoCVVZxvxTf7I9l7XKvCSPGizfpw0zpoEuVsmcUjIu/ajbD2mwj8XbQtmE2?=
 =?us-ascii?Q?zym0dXyHX43WXd2VP6mCBamJKcyIf/PRQO2kt99Xq+ETKb5wC73x+sGHYGg+?=
 =?us-ascii?Q?y05QNUGxB6c6RjDHJz97PXdW2QelMC39x1yHGIOuVMVeRe4hw2jmJ5h42Xrd?=
 =?us-ascii?Q?CNL6skUarjAgpNTl4Q3CN2lPFPd+7ctQ65MZPoeTlVyK0t1hjfJatFC8eWPz?=
 =?us-ascii?Q?2uJwwzv+H3lwKq+vGNdtVuVygEd7Gz7cpBWxpCLpyF+jSyLj4Tp9mMnUKep1?=
 =?us-ascii?Q?/NBbGDF6GCmabUrkaqx3vgaNC+7hy7jzDUCAgezrIIWd9YghYJXkjNXRA5/O?=
 =?us-ascii?Q?xvwmIcoxcyZysoyPUOAhkqWjgmZuyQJqhNKaI2ST3x8LwhgDboA/DvRlOrSm?=
 =?us-ascii?Q?waE759qCrFsxS3Zgwjg8+uZadvfU9Wo8L6qPM9QA4m/QG14NL/fUEHV3zVUb?=
 =?us-ascii?Q?pz3VwACZJ1YKGVHDLioBcgs2us4LXjNFru+q/lOeAsuG9tCYBEErS1aMTFQu?=
 =?us-ascii?Q?4E9UHRy8pQDjmlxZWAX4mhd73u6oAsj2UYz6sCJm65sHMueUwo5noHBNjCLe?=
 =?us-ascii?Q?uVjbnA0jfwQI1Gmeq+tFL8oM3LV+iOfp4NmxrsJHyY4xZVgm7hBso1eAixcO?=
 =?us-ascii?Q?2tjFAWHI6vwAmm9v4uufBqyj2pNm+9xQ9dEFaU1ci8+tBg7rXAUL/jol6xy3?=
 =?us-ascii?Q?SlyVUDUFSfY82ZuZ40u5L4z+Edcw0IEu1o89wJShpzjGlQ7Y5Pc42is9oKyq?=
 =?us-ascii?Q?qkbnKzSpn5BjqpJbrqv3+Flt4SdHcaNgZl9PdlNn05LmMPl3n0uEUIhVgMJW?=
 =?us-ascii?Q?sNkVEIHICTQwt4DYDUlYawUy8Z7xShGcCDcZLNpg84JW0eWGpR1Pjst9b/D9?=
 =?us-ascii?Q?BBmest2UYuvA8Vx0oETCm8gVNJG/b1+VYwhp7Uu1N9RAGzTHoC6MdPSYMRVf?=
 =?us-ascii?Q?0brAzOHH6NiQ1W+3PPGdXwwB7kLnTTneyG4d1I4sbOuthffendrfrn2Y0acL?=
 =?us-ascii?Q?GZoVfqk3gOZcAW/KCRxGglN/b2Xq26Z2FaE4TPV7tpvD3bTWmj7kkybeezs1?=
 =?us-ascii?Q?X5L6xqVLj0Y6cWjmKnQFMthW2mWT0T2LflecntqaMMrprapQmd09mbGv4jyt?=
 =?us-ascii?Q?iHo+g+6PFXTZSDoMqI6oRKK5ypbmv27xdLm164NJ1xLIaHRukE/UpIxWNqVs?=
 =?us-ascii?Q?6X6g3EneVh0MFVHUzPv548h9It+Mar2CTslPF2/5/nwmDTUaxw7oPGaA8h/J?=
 =?us-ascii?Q?wHAHyG3dixVYsXhyBnRbYtIgvdzkkDdl3lSZ39QZFMs9X+I9u+7fLrwsLPEy?=
 =?us-ascii?Q?JjodFzo/uKJlJ56vwd96sFyoWsNVm/o79+9V2a+R1yNR8Ecz3/fQYa+j+ksp?=
 =?us-ascii?Q?iauV9U/Sl5FGzrX7v0tsjMJGgZiQ5x10tOI04ClFlWG61BvB+u6Gavw3RBdg?=
 =?us-ascii?Q?NGTrtTFKAYOogAnxI8dmcE4SvJCtry1oN98pe6++HECrPe+7XFmKcGOZVC2V?=
 =?us-ascii?Q?r5I+LqZXY1TB+br61jHgeMsBZ8f1RUA3Al5csZx0DGwLLkfnovyWv1lHSCCy?=
 =?us-ascii?Q?Kz8VdwmmJ3QRBsjNWKf2b5ofBQRH1OyX81+YMl0V7qNNE20xhxEKVp4Usc2R?=
 =?us-ascii?Q?f0aF5xVNSeKwkPQ19jA9QBnCCn8C9tyr/jkV8c7m257I4bXEu9ozoYUEZOs1?=
 =?us-ascii?Q?7ykTvASgx1RNyUd7FAR7mVJM7jGa7C8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32cfdc6d-28c4-405c-95a6-08da182d233c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 00:25:37.2458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SC6Cwvi3WVhap1WOl4F8s7qNrjaf+C5t4kAYIbVDvnAKVg4tA6BPF3thxGGRhp3sZu9Vwxer3sRzuF8b42s1nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2956
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070000
X-Proofpoint-ORIG-GUID: FVZwPHdQkifKkRd3Ow_-czKd7bqyzmzK
X-Proofpoint-GUID: FVZwPHdQkifKkRd3Ow_-czKd7bqyzmzK

> diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c
> index c5228f4969eb2..3b4045d508ec8 100644
> --- a/arch/powerpc/platforms/pseries/svm.c
> +++ b/arch/powerpc/platforms/pseries/svm.c
> @@ -28,7 +28,7 @@ static int __init init_svm(void)
>  	 * need to use the SWIOTLB buffer for DMA even if dma_capable() says
>  	 * otherwise.
>  	 */
> -	swiotlb_force = SWIOTLB_FORCE;
> +	ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE;

This is the only place you set the ppc_swiotlb_flags.. so I wonder why
the '|=' instead of just '=' ?

Either way:
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thank you!


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 00:33:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 00:33:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300210.511901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncG5K-0001Ee-7o; Thu, 07 Apr 2022 00:33:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300210.511901; Thu, 07 Apr 2022 00:33:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncG5K-0001EX-2X; Thu, 07 Apr 2022 00:33:14 +0000
Received: by outflank-mailman (input) for mailman id 300210;
 Thu, 07 Apr 2022 00:33:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M9ff=UR=oracle.com=konrad.wilk@srs-se1.protection.inumbo.net>)
 id 1ncG5I-0001ER-6S
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 00:33:12 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4aa609de-b60a-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 02:33:07 +0200 (CEST)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236JxCl8014737; 
 Thu, 7 Apr 2022 00:32:30 GMT
Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta02.appoci.oracle.com [147.154.18.20])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6ec9t7e8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 00:32:30 +0000
Received: from pps.filterd
 (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2370GVD3038607; Thu, 7 Apr 2022 00:32:28 GMT
Received: from nam04-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam08lp2174.outbound.protection.outlook.com [104.47.73.174])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f9803exag-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 00:32:28 +0000
Received: from SN6PR10MB3006.namprd10.prod.outlook.com (2603:10b6:805:cf::13)
 by CY4PR10MB1671.namprd10.prod.outlook.com (2603:10b6:910:8::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 00:32:26 +0000
Received: from SN6PR10MB3006.namprd10.prod.outlook.com
 ([fe80::8dcf:404c:fc1a:1d42]) by SN6PR10MB3006.namprd10.prod.outlook.com
 ([fe80::8dcf:404c:fc1a:1d42%5]) with mapi id 15.20.5144.021; Thu, 7 Apr 2022
 00:32:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4aa609de-b60a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : content-type : in-reply-to :
 mime-version; s=corp-2021-07-09;
 bh=aTC2y3mQ6ctLwH7KhTj5tu3INTi3vFwfSn8kYqrFJ/I=;
 b=vbABOKANvJEte1zCObWsmp86gQ19e+q/0fCbpcWM7KRCzHlf5b9J4G/lH3rghB76hLgp
 WvDL7s8vbO6zZ7YxN7cfkpXckS+FCFyd7EFcrJdIQaABE5AnF4bl2R86O14K4wcGn0kk
 MZEYIa9sX+KhceXQdVygPjKA/uQ5ClbyvYt7oFvPqgjwqsK1WIkohnsQGEiaVfWg9VZH
 fhIGzNtAI+pgGe5IJPZJJoHUD4/NTWoixTQvnGW3GiCFCqlUKras9o6aF/+a4h6BLY7h
 WSZ9Sd0u4tzQ0FXNelO1wUx9vpkurZQr5ApkzR7HqJMqUpB4weej4qmGR7eIFRlhmW5K bQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lB3x2bO4bT/T66mk3N25TJKP/iXq6PKwsnn7sP+HC5w6AdiRm7KX++dFqRfMAr3O2v4i/btXyNWxpUeK4E/SjXedSYJkWaAXxkxCwfbzhTQgPf0p34GjSi/aNHDNHkIY7Gf9aqMn03ZbmLBhYY2zMrMJ4pYsFgQ2LYdNZl6VDxrP6sERAisxGH0l93R4E1yEW0M3WIHAY+J45lSWUK3t+qOhFxodISwiE2E8nw8xP7ugsPV5pvamfkj4F2LeJPWmwr/71SDxW0DfrxBZP0Yy3bNUp/Gp2GbFIMUYwyiL7hKB1GO6GBZOwGRoyKpR6GdJJN3GfyznGuFaQB1AVj1A0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aTC2y3mQ6ctLwH7KhTj5tu3INTi3vFwfSn8kYqrFJ/I=;
 b=cuZDqa4f4t7JAuP7uiGmheGqJo4V4a+Y+tEVmSdqf3yEUvtts5xDGYdExSeN4a7UfZytalygqXIFBb4uMJb4lsAsR6dutz+rGzjAb6XIb21BokYgHP9wc4TSKsQt+38BFgYSir9KMzNt8i5NN4SZ4hfH+ZKax6JIubZZvU/iKrj/RtVIuPqO4Y5rDRQsQOKQvYALuyv0m6rdSy3WwPUddT91o1RHTYxA1LdeYuQOriCjXwfa3MIO/DYluGghAh6A0Y/+qNrvuOsKWP9+Mx6K5G9ZokNNNRi6tdJYl3OvzNIgH/wsdlenVB8hKaDjTx8uUCP/t/YdU0196B6QFikvLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aTC2y3mQ6ctLwH7KhTj5tu3INTi3vFwfSn8kYqrFJ/I=;
 b=Lti0hsKhdFS7CxBaGjYp/89+ECoctmFlBIvKsRkVbNga0249wYVeqIzZnLEezTDgHyN84F5fri4qSSE8p7POTvnvFr6v5wYwOfe+r0/mrrjWwh7fdPrmw+d03h/AL11eOL6y0pzT/iWtbSCB7wvKObIWw7X+N7Whz5KIIyrXlKE=
Date: Wed, 6 Apr 2022 20:31:48 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org, x86@kernel.org,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
Subject: Re: cleanup swiotlb initialization v8
Message-ID: <Yk4w9N7IATu20RaM@char.us.oracle.com>
References: <20220404050559.132378-1-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
X-ClientProxiedBy: BL1PR13CA0160.namprd13.prod.outlook.com
 (2603:10b6:208:2bd::15) To SN6PR10MB3006.namprd10.prod.outlook.com
 (2603:10b6:805:cf::13)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 15af4aa8-0caa-4107-ef2f-08da182e035d
X-MS-TrafficTypeDiagnostic: CY4PR10MB1671:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR10MB16714A57414F3639DEE8C8D689E69@CY4PR10MB1671.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	y4OPyhwqyzNUQwZTEDOrOu+QjfgWXAZIcmrvPugyPcQp3yhxfTcYqkNlTkegqXR8CZlxmHEg23QPXhIVnmn1sv2j4odmmbQqJV1eWx0xyFtVSr5y8wDiZeqzgz1p98slepqY8eN808paxIAvdu3sp4Y/zeK8SXwKXqVEZfPt0rb03/+0+WT/g2VmYeu3NALfha14pQyLuF85kBUD7nwacxjeEuT1WHgi5Zt4o8BB1I8v13RZLdoBuGjZ54gnZiH2iHoeGhGKk9/vl0pxxDTmwTosocb52+aJBfdaEfP0ZXBEyF44uWzaSynqwR5L/O616z+Q2yT3Val3kFuy5RoVimfN+t3Vnm1uCImvA/C/HvfhmaOiFy1UDRF2HPXHheTH0bjzTJ8t1AwZjKyGBrneO1xosiGga2l7Bi+6k7Wllkj+pIUuNudw2lyhvAiUtwrA38tBiThQLBEOBsnealxR5zDl7r2o1P3A8DHVFlOH9fOtSAsksa4B21GgAIUTr8dbzESdmAXpmrnW3p53vFkxFZgJp47lSRA7PGti2V91rAvLShlGD6r5kmdTdiUXEZ3WCOt5YRPjfhcShhqIFiYcVAMWreh6hL/KqX9pOEKsZnQg2TOKwgz2yftMJZzCTT1qsyyfiAFAUTOX6xeTp+3HUpx+VtXgFzXQYcXkxM4tVxIQpZm/Z6GGYZ4uwkgqBtVaT/4f+jrYQq5sVFTkrbPJRRJr49FIZoL7g88haUFZvEqB48OALKBXQTMjKQchl0C50RL1O8ewoRTfHr3Cycr5wZ//Rjhmwprudh/brBS6lhk=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3006.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(4326008)(8676002)(6916009)(66556008)(54906003)(66946007)(316002)(66476007)(6512007)(8936002)(86362001)(6666004)(4744005)(966005)(5660300002)(7416002)(6486002)(508600001)(38100700002)(38350700002)(6506007)(2906002)(52116002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?z7n1E6F/Avl8goOftI/glJgLJ//gveoI+X1zaSPZ/FjFAIamrFiWEYrQ0wJ4?=
 =?us-ascii?Q?cBHwM6PEyN7FRfmdP4aDWx1pp92XYrlsPzt9/EOT9jmRK7ZoTUt5Ahz/jijL?=
 =?us-ascii?Q?LxfT4wT1UO/s+CzPUjfOeqLsdMdPRZ/G4phE/krD4NebzKdWV/tp8XA6/YMb?=
 =?us-ascii?Q?UHv9QUm0IwjmXluuHtZL86DPAliyzWhzHTHfqH6iVIJG9RwYUEdSaZu4cYmA?=
 =?us-ascii?Q?NlC+ZjkycbkMFg1TndvxnIZ5uPV6LuTAQQ/XnC9fSNEfXQo3aWOL0K/w67KS?=
 =?us-ascii?Q?EsxZMko4F+pZSAO5e0g2NhA0chfgHwDDPSdTUBTQaC9ObuUjJueDX/8Oi3bu?=
 =?us-ascii?Q?UTS1KnF49d+EwgsJyi02rSN2+mkVXcSse5KQYijGBsmVjIxDVzvCLqJU/Veh?=
 =?us-ascii?Q?LxuUkbpLJTcTuDyd98CDzrg+NfVTyTWGsxL4P9Z1v8NmhjTR/5GEaz2WwSEh?=
 =?us-ascii?Q?tTC4aXwrJxNBRxstZG6E/hlAMlwJCfZsNe7wgH89QJXUOIfOaklxXg3vEK9o?=
 =?us-ascii?Q?6By2/S/oU51KWnvWh/BUYo4LgQFDVMOmACvIISckeWx9TyA0TVMcoMOwduee?=
 =?us-ascii?Q?Zm5sS53ODUj09hpxLdqJI+XoeyrYOoU6vzzyr33EJzplVKNjSWEJ0InyKbVx?=
 =?us-ascii?Q?UtiqFf1f4/yRY+o8Ov05EvDK/EemA1JfmRiGropJ8OmJhwq8Kt9O1WxrNu9n?=
 =?us-ascii?Q?LRdiwCf6jzvgW1EzgNWZ/PWpiXn0vS8k7ZPq8LsFffx2CDxTz9tjXKbTwF6+?=
 =?us-ascii?Q?g1YnsINBQLJAL2dWKzM1oeRekkfQ2iG6w8Qq7aUd4krzSkHSH2vknH9fP9wm?=
 =?us-ascii?Q?eM2+v7eXlFaF4gCcnOJAw3FCfIyHoS2XDHTOnvva6nWPupxwQ8UF4z9CNSpS?=
 =?us-ascii?Q?oq1d/I2dFT5u6p0ce4xuI/qOrwohW6hB0nPICT6rnuHauUgoxcurieFh26zw?=
 =?us-ascii?Q?8WpJx7epNCW0/8JRb0TULt4rmtWtMWpHvQ7G7WWZnHjzjLBkwqTm3hSXDS5C?=
 =?us-ascii?Q?o6cJGzSunXAwin4Kf4OyFHxdiJ27Z2jsJxi9Mjh1aRt3AQNh7iSwCD6CQG67?=
 =?us-ascii?Q?7IJ143SWVFScaYlVvEi872JS4sngAvTLIu7NFLuYAXv9UGXCjItPwzF9zQ9z?=
 =?us-ascii?Q?jW1Mdp4315zejlbwHkepTlE7L8d5lCFg12iWn7d6XRx3hee0YswMLsW/BXV2?=
 =?us-ascii?Q?pa0O2gml6Mf7HD7qVWLSiqZ9OmKJX1bmgCTCphXOfTMGRfiXeCmdbXl4Wmlh?=
 =?us-ascii?Q?JqQ8zGirzvhDdfxkDF+684GtUESRryDhe6jR9V0Xt0WblnjYzMkNW/4EM4FI?=
 =?us-ascii?Q?MNqZyUvqsWkjDeKDT98QsX9IncBlNp0Z4Gtm3Fd54UtW+5GQPJMTF/lOfKwM?=
 =?us-ascii?Q?tkmw/FV7hQxit8xclLcETgdHJ7SZzABetxodWwTVnzCB5Jtaq8Ko44PwzNb3?=
 =?us-ascii?Q?Fni0Tz3BO3XPsymYTVePHrSik3sFsjVlYY0WJOSqYmDKOCHsRLPI2M7exNo6?=
 =?us-ascii?Q?feQe1MkKA/14LUsDnnbuctl2+pZyxBcWHwkmcS/99XcCbYN4sD+t1MmA1/vy?=
 =?us-ascii?Q?S7CEsw6YYXNwdfqX7LBu8xoubFkn62Cyv9czS5elp0a03hQhKbbiA5AX4Wlx?=
 =?us-ascii?Q?a+qa7ifCdX0Y64uwNrxIjt26JFkTvNwrxxpsctV1fjNLkFW1Q0CDQzMmopXn?=
 =?us-ascii?Q?j98cuI1HCAqt7Bvbr98TPELE7asAbXasalz0D8ToVDa09UVdnwiWlNLfSpR6?=
 =?us-ascii?Q?VTSNUXwcHy1VPiyiz0+2+FoJkEU3Euw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15af4aa8-0caa-4107-ef2f-08da182e035d
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3006.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 00:32:25.9904
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0Zuge13Gx6/cDD5X0rmdeOMD9yPKu+maNN9cfLEdyChjeVqGf42KY8/s1WlFgS/stdwI2QQgMZ1lgZs11nmp2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1671
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070000
X-Proofpoint-GUID: Ld5JT0Q0K8pOByVfmiRRkW68u3Olyj10
X-Proofpoint-ORIG-GUID: Ld5JT0Q0K8pOByVfmiRRkW68u3Olyj10

On Mon, Apr 04, 2022 at 07:05:44AM +0200, Christoph Hellwig wrote:
> Hi all,
> 
> this series tries to clean up the swiotlb initialization, including
> that of swiotlb-xen.  To get there is also removes the x86 iommu table
> infrastructure that massively obsfucates the initialization path.
> 
> Git tree:
> 
>     git://git.infradead.org/users/hch/misc.git swiotlb-init-cleanup
> 
> Gitweb:
> 
>     http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/swiotlb-init-cleanup
> 
> Changes since v7:
>  - rebased to Linux 5.18-rc1
>  - better document the lower bound swiotlb size for xen-swiotlb
>  - improve the nslabs calculation for the retry case in
>    swiotlb_init_remap and swiotlb_init_late

Hey Christoph,

Feel free to tack on

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

on them if you would like.

Thank you for doing the spring cleaning of this codebase!


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 01:01:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 01:01:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300214.511912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncGWx-0002oM-FV; Thu, 07 Apr 2022 01:01:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300214.511912; Thu, 07 Apr 2022 01:01:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncGWx-0002nb-CF; Thu, 07 Apr 2022 01:01:47 +0000
Received: by outflank-mailman (input) for mailman id 300214;
 Thu, 07 Apr 2022 01:01:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9hzW=UR=citrix.com=prvs=089009d52=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ncGWv-0001nx-Hq
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 01:01:45 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 48c5ee60-b60e-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 03:01:43 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48c5ee60-b60e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649293303;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=OyNgCoUVokh104p7gNuXy6J39X/cwubSQuNrcN+Q8No=;
  b=cBqlxwHkSgyBFLPxrfxDJAf6kSvljKnELTAhuLZ0zdjDPxANpIIk226L
   zVP+Lp/pjwJofXo3wRplSQZN21kxHv9Csk/JlnRbyl0YyvLF10V8S16fQ
   8XNYJpVQru4OeT/2xizr+ESr0Sk5DE5NSuNWaX/zt2qtV9JBdrXRc5y9D
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68229048
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7ThJ8KzEcBVNJHonAqV6t+dNxirEfRIJ4+MujC+fZmUNrF6WrkUOx
 2tJXG+POKyJNGrxfI1xbozi9hwH6sPRy4BjSgA/pCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YfhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npll4D3URciI5b1x9sfVSBRTiJPPPRI5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AN
 5BDOGIzPHwsZTVMMHMqKYw3xtuqj130YRYFqlerho84tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO88mrxmdwbfv2lmmBG49R2NCWd1/utBjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WvQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW
 lBexaByC8hUUPmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehs4a5ZYKW+5M
 BCI0e+02HO1FCH0BUOQS9jvY/nGMIC6TYi1PhwqRoQmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU
 ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or
 b6y9qKiln1ibQEJSnWPqt5McApSdBDWx/ne8qRqSwJKGSI+cElJNhMb6epJl1BN90iNqtr1w
 w==
IronPort-HdrOrdr: A9a23:Brp4MK32KPcG/dD7QBRzYAqjBLwkLtp133Aq2lEZdPRUGvb4qy
 nIpoV86faUskd3ZJhOo6HiBEDtexzhHP1OkO0s1NWZLWvbUQKTRekIh+aP/9SJIVyGygc378
 ddmsZFZuEYdWIK6PrH3A==
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68229048"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/cpuid: Clobber CPUID leaves 0x800000{1d..20}
Date: Thu, 7 Apr 2022 02:01:21 +0100
Message-ID: <20220407010121.11301-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

c/s 1a914256dca5 increased the AMD max leaf from 0x8000001c to 0x80000021, but
did not adjust anything in the calculate_*_policy() chain.  As a result, on
hardware supporting these leaves, we read the real hardware values into the
raw policy, then copy into host, and all the way into the PV/HVM default
policies.

All 4 of these leaves have enable bits (first two by TopoExt, next by SEV,
next by PQOS), so any software following the rules is fine and will leave them
alone.  However, leaf 0x8000001d takes a subleaf input and at least two
userspace utilities have been observed to loop indefinitely under Xen (clearly
waiting for eax to report "no more cache levels").

Such userspace is buggy, but Xen's behaviour isn't great either.

In the short term, clobber all information in these leaves.  This is a giant
bodge, but there are complexities with implementing all of these leaves
properly.

Fixes: 1a914256dca5 ("x86/cpuid: support LFENCE always serialising CPUID bit")
Link: https://github.com/QubesOS/qubes-issues/issues/7392
Reported-by: fosslinux <fosslinux@aussies.space>
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

I was hoping to do something better, but it turned into a rats nest, and this
fix wants backporting.

It turns out that Intel leaf 4 and AMD leaf 0x8000001d are *almost* identical.
They differ by the "complex" bit in edx, and the $X-per-cache fields in the
top of eax (Intel is threads-per-cache, AMD is cores-per-cache and lacks the
cores-per-package field).

As neither vendor implement each others version, I'm incredibly tempted to
reuse p->cache for both, rather than doubling the storage space.  Reading the
data out is easy to key on p->extd.topoext.  Writing the data can be done
without any further complexity if we simply trust the sending side to have its
indices the proper way around.  Particularly, this avoids needing to ensure
that p->extd.topoext is out of order and at the head of the stream.  Thoughts?
---
 xen/arch/x86/cpuid.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index bb554b06a73f..7e0b39569847 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -328,8 +328,15 @@ static void recalculate_misc(struct cpuid_policy *p)
 
         zero_leaves(p->extd.raw, 0xb, 0x18);
 
+        /* 0x19 - TLB details.  Pass through. */
+        /* 0x1a - Perf hints.   Pass through. */
+
         p->extd.raw[0x1b] = EMPTY_LEAF; /* IBS - not supported. */
         p->extd.raw[0x1c] = EMPTY_LEAF; /* LWP - not supported. */
+        p->extd.raw[0x1d] = EMPTY_LEAF; /* TopoExt Cache */
+        p->extd.raw[0x1e] = EMPTY_LEAF; /* TopoExt APIC ID/Core/Node */
+        p->extd.raw[0x1f] = EMPTY_LEAF; /* SEV */
+        p->extd.raw[0x20] = EMPTY_LEAF; /* Platform QoS */
         break;
     }
 }
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 02:03:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 02:03:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300223.511948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncHUf-0005EG-Je; Thu, 07 Apr 2022 02:03:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300223.511948; Thu, 07 Apr 2022 02:03:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncHUf-0005E3-GK; Thu, 07 Apr 2022 02:03:29 +0000
Received: by outflank-mailman (input) for mailman id 300223;
 Thu, 07 Apr 2022 02:03:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nqs0=UR=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ncHUe-0004h6-IB
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 02:03:28 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20611.outbound.protection.outlook.com
 [2a01:111:f400:7d00::611])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e9fe1fce-b616-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 04:03:27 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB6PR0401MB2437.eurprd04.prod.outlook.com (2603:10a6:4:35::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 02:03:25 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%7]) with mapi id 15.20.5123.031; Thu, 7 Apr 2022
 02:03:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9fe1fce-b616-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WlZa2PGZC81sksg1MbgpAPy+UpeX3hzwnIhf9LyKqcA57O3fCbAxThO8EcWNA8uS2yYuCQcp3xlYfnJwlLuvoKJGTQXs+hnYN5K7VTK/J3zmLljBQRkHWi6aK56Pkbcab5mICpr1xhV0dCV6fyBqeywplFeSm6bXA+F5v1BCRVkmOa8qt2CNiFQpk3P0AxBomNviu52BYBg7O09d5+lIGBbxRpybqZEEyNIgaeQn7hapaY64A796H4t/GXzIZdDuuOnYDvs+c6c61RmPxowE6Q88T1/NpFRMfCsWTezaEKwgYrg+G84ThurXcaLJnyg/bJz4JVhy/C661L3K0djjIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aJJ17xML25oDlOV39Kw3EgsKV4hvJLgWZl9kJev+dnA=;
 b=MaZOOUBtXOC9Ku52fBFRIoxBKordXEbkvVuGN3vg3X9vrcwpbz0gq1NXS+AJx9N9Buk/uWLJrjC/kROFENpdSlhsXsjBQZNjd4304L66mb4vf/yC+twYKPBKuZjdnzIm3lg64yfz/BQ/l9NesR2dj1JR7u0ib6MjiqP1sBjT+T4rTHbFY2P4pxJ7OteEwNyu689I7H4s8+jzTMvEIDAbyAM8YtK+KY/Q4J1omREURb/LmuDnK2144xSjxnbUONoG3ct1TrM3iV9LFxeqy+hqvppte/QkPi71C41EgAIxr2lTUhKX/W/lll/+7jgNwTaSufbj5P1FAnSZ1hrjGxh4nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aJJ17xML25oDlOV39Kw3EgsKV4hvJLgWZl9kJev+dnA=;
 b=FUFtR1e/1p0hbJU9yTPtJ+a1MpfDsqdXojH3U/3ONsELEhNSV4QGse6KWpn3WQB6MOcyZrnqji3sEwsLny6lXReLQNgngx3XpTf1MWqQz1Is75qbR+xsE7RIR7iI8dU/Im4+DMGzNyYbGVwKwzQFwoJLsvFu/i4FAYRnOUYv5aY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V3 2/2] xen/arm: Add i.MX lpuart early printk support
Date: Thu,  7 Apr 2022 10:44:18 +0800
Message-Id: <20220407024418.9827-3-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220407024418.9827-1-peng.fan@oss.nxp.com>
References: <20220407024418.9827-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR02CA0047.apcprd02.prod.outlook.com
 (2603:1096:4:196::14) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2b7f86c0-201a-485a-ea94-08da183accf1
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2437:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB2437F108BA83D2A8F614C0E7C9E69@DB6PR0401MB2437.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tBrkc08VPPUiqJVLIds3FbxVlY5oz2EVGR206B8fSQ9rtmJEVgM6z8pdMAGDC69Iq+54KR4OD+XrbJS9tKFGo+crpYwgL0niY7A2yBtnB3dvOVvNdU5LYWhz6LcyNcVSkY3LnVFxraMamWM6k0SAMt/ydEG+LUsVLCHWTpFVehNnE4ZmapMdcyIQbSH1y4AR9x8lDCERH2E92bhgkEaOex8Ns7j3E+jn0FC+jTnSOesZlwZmHkQ0G27Dw/B8/ijew47jbzHf1lYuQ45hvgbHu3iq70SQjqVNrZwYR3I43LvHRsh53LZ/ftLrkdPKq6TahCC1USmDya5T8YMZC/uQleKJ7v+W0y5QYIiZLzqR9/feUH40slZIesPUZsGlV3RZVYqc0M6Z9BfsatJ6BYjnDj+PfAhQEkchlZuf4UMQ0zIqofCYgSBqcfD7K3EcaocQhNSHSSiUAEH4918HkbQjvEyPEtxaHBDeednXTAoRkBGnojJ3YeASe7JxN6kvMHVNuboTHa4fWJFSEZYn4LiIW0Kn8HMfmkwb6tpPqjq2Scm5o/Xn7Y3owmnDRSo74PFKM9A7Ad7k9bQsjgIs3QyjmQtBFKcPAfecsBH4zjz+1TUqh8JAMUfegQrAX/v7PitHuYkrPgjTzgVyGHuLhb/Q5tB2htUHTar0i+Iqn7y3U8excbk26FslwF0BHkqPWzR9g0pts4BiKbxph6a5SDZ62vPvQC1faZEHITtaGBEAb9g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(26005)(186003)(52116002)(6506007)(8676002)(4326008)(7416002)(6486002)(2616005)(1076003)(66476007)(316002)(508600001)(5660300002)(66556008)(66946007)(8936002)(83380400001)(38350700002)(38100700002)(6512007)(2906002)(86362001)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PxwPyq/tUVGHJBwluEmLmcqMBi4GOFp/4ZejQ6SpBWyOrIv5YlT/3pwZyqT6?=
 =?us-ascii?Q?Bs1lwuoVb3KikyuHUafKPhcXQrIMESxtKGMxEzaulLwnwUiDHz773qQd/vhD?=
 =?us-ascii?Q?MTSkVsycbrq0txd0IuHiKIOebg3/CL6Xkw2iT8Y9gcodqKrv0lhwx6R8IWMD?=
 =?us-ascii?Q?YTRj8GUfE8CBMXPd7RJKUi94sAMKj1dwM+ug2NqxjAIyIMyPOuCR870VsQih?=
 =?us-ascii?Q?J2t6lEOXm2AqihMvjaICvVVwGGZxbdY9SCp9nWFHSu0GdaggbwVCTVM6uKqD?=
 =?us-ascii?Q?d9iFjO5o09MXMckRIXGxntV8nmCLuLMect/BWqq2SopmuXMlorhjfytY8eVV?=
 =?us-ascii?Q?w0FDH9PO4y9RshLvklpUQmIEH4cftYWLAZR+m+NlbAW7PcOWlmaddah1Kgka?=
 =?us-ascii?Q?vyMws39cwWLzvoAuPHOC9hRGAjKvE7c+NoaJfrLHSTA/4jkCLk+ILW5PJBbG?=
 =?us-ascii?Q?oInIPlpL6E8GIqITbVAbvT/Elh0OW0vHULjJUhHzJovchQOv1JwdOr0i9mI4?=
 =?us-ascii?Q?YbhHX5pLJwA1bk97r6fFnQdVNYR6Vo3CpiARh7h1ssfEop3HDgoboWOZaAp1?=
 =?us-ascii?Q?IoXC+m75qC55khO9vYuNKPAKhwIMu6u0a9pkNuEUMHc44EU6nCmmXiZwmNzO?=
 =?us-ascii?Q?CNnQaG/D30YDvnxwT82mkbV4DHfoerQHtP9PiSqv35Brs83n9uSxpe/G4itq?=
 =?us-ascii?Q?r00jUcdIC+D882cxM6HLFYuZD4JgQfnlY97MTNeTALaFSGcjJnV9HuFfP2Py?=
 =?us-ascii?Q?wOwxMwEDfW6NTNYvbZR3OM/WnBMXB6MXVvDyisO3ZFyNlPrnVB7KI7BdDgOa?=
 =?us-ascii?Q?x4Xf6M0Aw6UYqTXG7rS8fRVjBegAvxqzm/Cwps4ZXzYx0LCF+3aoFEc8bQ34?=
 =?us-ascii?Q?OJHdhTZ8nXBv3hdEiA3pkM/4CDAb8zqEd9AQ6u3NMe4uCzmC4c89o1ehZYXh?=
 =?us-ascii?Q?2Bh7gAJWb5EnVq2XSXGX8V4Kcv796BiH7l39iy7YB5z6ZxODlVKOrW4ESi9n?=
 =?us-ascii?Q?rKdcvbV3RFdndZPirFcWO8DNgyUUdrfOocdJYAPDhOxI4tZwzMYmIydD+xeN?=
 =?us-ascii?Q?sMHE9WK4sxzQYt2/mE4oiSFdut5FyTNbnMdhYORaaDuNaHCm+3HJLkmMs5B/?=
 =?us-ascii?Q?vYYW+xB4F592cWrZ+phFh8XXQgRSUaSmo31SMsa9upPyK019w+cBZCavW2VV?=
 =?us-ascii?Q?3ZXFoq3+Olf2Akgfi+nPG1m2Iyxh9onnqaOA7m7Xda+eb/aOuhab0eJTNXN8?=
 =?us-ascii?Q?2EC7qKwiVA2Ds2v/e0Va5zFQ6cwZHPSv20Ru5u0HbecWpeYoyxHXN4pYHeHU?=
 =?us-ascii?Q?uom2PiTrusLnvot2Wim575q2h0g4fX4ELXP5UL+HWNA2sCXAnyzSipd/DIqJ?=
 =?us-ascii?Q?8NW8lD/1pasprj8xn4UgI5R3LnOeVRQa6zXN0TujVt+pQpTIpZeKr3TkAUYw?=
 =?us-ascii?Q?zngUU5CWafPfbIGGFuQlGty+ehTZzI1X5mb63IvxcdSRUt3iGdFZDP5AP7dB?=
 =?us-ascii?Q?SNvz7iLms0ULTo93pwJA0gEIpHYC7pCk8XNF0FaAijI6RQJ6OEh3dWTKKMUO?=
 =?us-ascii?Q?k9jl13D28ME5v6tdYhU+94G8gkBXbThpdVuO483o2DTI/5BqglSOEuieJDyd?=
 =?us-ascii?Q?sQlKsL8RCjYGi6nHashR4lLE9mN0y7kW6iN49918/O8Q1eV3iz3wrd/RIx4B?=
 =?us-ascii?Q?wL27a+hzUEiiPSrDtpIJ6f72Y1Qy39HOLU9G+hHftXjBZqYWARBOxWG7SNvc?=
 =?us-ascii?Q?J880FVZMcg=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b7f86c0-201a-485a-ea94-08da183accf1
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 02:03:25.3484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ze0YecGmJvAsxYCztH2MyQjG7qxpZsN5bVHIvZE379xt4pK8qjlInJwnJejJyD1nt/l47j6KZWHNRKxRcvowg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2437

From: Peng Fan <peng.fan@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/Kconfig.debug              | 14 +++++++
 xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 +++++++++++++++++++++++++
 xen/arch/arm/include/asm/imx-lpuart.h   | 22 +++++------
 3 files changed, 77 insertions(+), 11 deletions(-)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index 35ccd13273..842d768280 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -58,6 +58,16 @@ choice
 			This option is preferred over the platform specific
 			options; the platform specific options are deprecated
 			and will soon be removed.
+	config EARLY_UART_CHOICE_IMX_LPUART
+		select EARLY_UART_IMX_LPUART
+		depends on ARM_64
+		bool "Early printk via i.MX LPUART"
+		help
+			Say Y here if you wish the early printk to direct their
+			output to a i.MX LPUART. You can use this option to
+			provide the parameters for the i.MX LPUART rather than
+			selecting one of the platform specific options below if
+			you know the parameters for the port.
 	config EARLY_UART_CHOICE_MESON
 		select EARLY_UART_MESON
 		depends on ARM_64
@@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
 config EARLY_UART_EXYNOS4210
 	select EARLY_PRINTK
 	bool
+config EARLY_UART_IMX_LPUART
+	select EARLY_PRINTK
+	bool
 config EARLY_UART_MESON
 	select EARLY_PRINTK
 	bool
@@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
 	default "debug-8250.inc" if EARLY_UART_8250
 	default "debug-cadence.inc" if EARLY_UART_CADENCE
 	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
+	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
 	default "debug-meson.inc" if EARLY_UART_MESON
 	default "debug-mvebu.inc" if EARLY_UART_MVEBU
 	default "debug-pl011.inc" if EARLY_UART_PL011
diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
new file mode 100644
index 0000000000..f68252da86
--- /dev/null
+++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
@@ -0,0 +1,52 @@
+/*
+ * xen/arch/arm/arm64/debug-imx-lpuart.inc
+ *
+ * i.MX8QM specific debug code
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <asm/imx-lpuart.h>
+
+.macro early_uart_init wb wc wd
+/* Already initialized in bootloader */
+.endm
+
+/*
+ * Wait LPUART to be ready to transmit
+ * rb: register which contains the UART base address
+ * rc: scratch register
+ */
+.macro early_uart_ready xb, c
+1:
+        ldr   w\c, [\xb, #UARTSTAT]   /* <- Flag register */
+        tst   w\c, #UARTSTAT_TDRE     /* Check FIFO EMPTY bit */
+        beq   1b                      /* Wait for the UART to be ready */
+.endm
+
+/*
+ * LPUART transmit character
+ * rb: register which contains the UART base address
+ * rt: register which contains the character to transmit
+ */
+.macro early_uart_transmit xb, wt
+        str   \wt, [\xb, #UARTDATA]  /* -> Data Register */
+.endm
+
+/*
+ * Local variables:
+ * mode: ASM
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
index 111640edb4..26e2cf0249 100644
--- a/xen/arch/arm/include/asm/imx-lpuart.h
+++ b/xen/arch/arm/include/asm/imx-lpuart.h
@@ -30,10 +30,10 @@
 #define UARTFIFO          (0x28)
 #define UARTWATER         (0x2c)
 
-#define UARTSTAT_TDRE     BIT(23)
-#define UARTSTAT_TC       BIT(22)
-#define UARTSTAT_RDRF     BIT(21)
-#define UARTSTAT_OR       BIT(19)
+#define UARTSTAT_TDRE     BIT(23, UL)
+#define UARTSTAT_TC       BIT(22, UL)
+#define UARTSTAT_RDRF     BIT(21, UL)
+#define UARTSTAT_OR       BIT(19, UL)
 
 #define UARTBAUD_OSR_SHIFT (24)
 #define UARTBAUD_OSR_MASK (0x1f)
@@ -42,13 +42,13 @@
 #define UARTBAUD_TDMAE    (0x00800000)
 #define UARTBAUD_RDMAE    (0x00200000)
 
-#define UARTCTRL_TIE      BIT(23)
-#define UARTCTRL_TCIE     BIT(22)
-#define UARTCTRL_RIE      BIT(21)
-#define UARTCTRL_ILIE     BIT(20)
-#define UARTCTRL_TE       BIT(19)
-#define UARTCTRL_RE       BIT(18)
-#define UARTCTRL_M        BIT(4)
+#define UARTCTRL_TIE      BIT(23, UL)
+#define UARTCTRL_TCIE     BIT(22, UL)
+#define UARTCTRL_RIE      BIT(21, UL)
+#define UARTCTRL_ILIE     BIT(20, UL)
+#define UARTCTRL_TE       BIT(19, UL)
+#define UARTCTRL_RE       BIT(18, UL)
+#define UARTCTRL_M        BIT(4, UL)
 
 #define UARTWATER_RXCNT_OFF     24
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 02:03:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 02:03:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300221.511926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncHUa-0004hK-0l; Thu, 07 Apr 2022 02:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300221.511926; Thu, 07 Apr 2022 02:03:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncHUZ-0004hC-Ru; Thu, 07 Apr 2022 02:03:23 +0000
Received: by outflank-mailman (input) for mailman id 300221;
 Thu, 07 Apr 2022 02:03:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nqs0=UR=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ncHUX-0004h6-HZ
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 02:03:21 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2061b.outbound.protection.outlook.com
 [2a01:111:f400:7d00::61b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e501d563-b616-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 04:03:19 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB6PR0401MB2437.eurprd04.prod.outlook.com (2603:10a6:4:35::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 02:03:16 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%7]) with mapi id 15.20.5123.031; Thu, 7 Apr 2022
 02:03:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e501d563-b616-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dcXLPsOLv94e2IW82L1h/Y7RYtcm9tq5eCu+hyxklA+StRobFfiVnIXrrYDjXbNtE9srGtM/2qQ5Kn1lh5iwoe37GTefdPUA6QrgeYbMD+OrdN63+uih8OhK9ZQqkuyY0hqLPpLD9X6POQsF+AJYyCaM8XXdjpP9vkOrLqcZDKtAlKJ0d57ilkWmF9an6UdAAurTIQ9jeO7VdOALUelLjZ72b9vJFGg4plCj/x0VfSK5AKClJ1aiTnniXXiC8ZnnDDCP+1OazSrv+UuMkof6U+x1L9sesk63Vd8+a8ErAWi012RLUnd+XWegnHbVaDsI0NdOrsc7AwxTlXzSsAfdXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tMtO8m5P0hklnRQ8pvPMxCuv6RmFAE2YYFGpQFQtUYs=;
 b=fKBCh8Fi5ZzQdwuLJ8s0n/fzlEaStCEKYCUl/s7lHkpe1OV7pLI9nNzA/YoKJCbiIwBZzFtZxuFPgWQc9YVGEAwTwIOxngyUQ0Rewc1LpZI8EJ7s1P3fGPeZj8MwugXU5SVxBQ7V8qTXiUWlOVCTAQTconf2IHCwKH8Lx3wlEheICC7RBralaR5SIcpO5dvwBztkdrK2kfyRhyqh7CtXQvfCYOkoLlsEGToVRB6WYTE4ukvJGmqtaJ2ttjZpyCiDb++zkK6VLAdpH8c50H56YHaoxj5LCOEhFPUVrka8MGog25AlYY96RGWJRVrqJ53240y+KH0LfpgMPUiaG47ddg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tMtO8m5P0hklnRQ8pvPMxCuv6RmFAE2YYFGpQFQtUYs=;
 b=IIIw6rIiebzH0mgayg0w8CONDgAU4one8PF5LvTpnMdrZZWBNv0H/vILoCo4BRFVhryIhJZgJjxl0ZOVbKVnWfCdvgIR5OuyOyiUQpw74fyjSZ8D92VrzgQfPKTIvkH7+/oD2v8trxpHWDOMPb8Dlf8Jw/NcgwACjNs9odoEEkM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V3 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial support
Date: Thu,  7 Apr 2022 10:44:16 +0800
Message-Id: <20220407024418.9827-1-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR02CA0047.apcprd02.prod.outlook.com
 (2603:1096:4:196::14) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c55ea0a4-a54e-4a2b-068f-08da183ac780
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2437:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB2437D5C90B112B8625C289BDC9E69@DB6PR0401MB2437.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PMAgaPjde+Gv6UpMQWGvgYRLHM1+KQYL5TFsKY7PStVxb0vBLMNSkiu9Gl9cE59bE3+NhwH6g6Vz6sWIIgeJsDaV9N1FSe4Dgp5eljC6Ksx0luFijoCLhN5bCVt9NceYwcP5T7pCh1P8AX5pLVHGU8rOxquzRAe0BOGiwalnRXUh0a0qjJTGydtkEwg2Njpr9vy+yXikuLQiwJoVNINbhSM/aZXAr3biUC2GIqi/Ctay4sj5DCyaLEbKSNAt9n90TvCH35Y8TpP4Gp6XbP6m8YhvJYSvjX1kbMmvOnT4jpliDCu/idH6Mwx5OZNELefe+tHj/+WuH1U0MB2toGnGX4pbvNBTll/QvmBPurCG4LT2/NbH9mhllh+1NSQXCXhHlfGOoCpVjoDRNRAqrUg8xpAED49nIdM89rCzoeRVWO3Mzz8k4oYAK9VrofSoQm9YB06eSywC9TWgjTX7Zo4icYFJxn6uuavq9+JXfQKSclVFlGa5W4mYlhYNM4zFOxQVVVJonwWlX8mVrJd/Ag14O+mU9VqjvlLOkmxB55pfQo2U+ZrhQB/zxUuo7EJ0E2SuU+T7XyPiuCgykk5IgWJSYEQz//CAKFH2YhLVAvsY5Z+Os62RtpI24etbSMVowmX0s3aTVeLN4pA+ChtB/4UsUe8fOiMCea3NHcU+iI1rUEEkFPNCxSlvNTDVz7lPZafz6dua2Xd9Rj6Gj0Hlurb5Pw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(186003)(52116002)(6506007)(8676002)(4326008)(7416002)(6486002)(2616005)(1076003)(66476007)(316002)(508600001)(5660300002)(66556008)(66946007)(8936002)(38350700002)(38100700002)(6512007)(2906002)(86362001)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?T52KuZUsbbm8znE4JdzsByLxbBwGVg2rG4visaipTnKn8chCJb+OvVKqgRNn?=
 =?us-ascii?Q?oFL7JMOCv4aqXhjIzvhA4/gM1OHq3r7/TyTjtygvcZaqS+NSY/EQ56mEurDI?=
 =?us-ascii?Q?qUPoFR9MozC3i3+3eS+RT63UrLt2wgmdzU43mB69sjtnACTstw3jFXPnXtsi?=
 =?us-ascii?Q?7ujzX3HxxQRNSv8pgCCRpOUlDOQIZ8nbWyUlm/hO+8PwNd05rpZT8JPOZIqV?=
 =?us-ascii?Q?2e1cbEYxgi+yPsdXZQIgszG7r5Dz6p9reAJz7a5+g4s+GZ+WMAG3iA7hYcBO?=
 =?us-ascii?Q?2t8ThE65icSwm22pSeg9Q5aWlOjClaP3DNp9yjEb9dQbvY/4C9eiKrMIVzg5?=
 =?us-ascii?Q?sqW0UfkQ57ymgr5dm1igaF6qg+6vpSBamVbB5wfokH/lsbPzpgqihR+jIqyV?=
 =?us-ascii?Q?/EZTGbuU+bq8LR0ncSmzcBuBQ1s1b+4WDWmKlB99hNvLKGlAC75qxgWKqrrs?=
 =?us-ascii?Q?xsRKfS5m85S507M9qQtnBBdD6WoUm0tARboAIqOFuQDg8keOQRrzTp5velJT?=
 =?us-ascii?Q?NW/6g4G/R6oZFNJ6XNIquYMWAjFbRBDWCzpEh6fDHsrRBGLFPge3ICl4oiSO?=
 =?us-ascii?Q?GwCOpgaAhxS76KQf7KNfsZkNNeCZ9LdDTJ5/onPC/3N80YOj/bf1ImHnl6vP?=
 =?us-ascii?Q?xJzniuiDaepjGUqp5U7LhZWaIdnKd3rhD+/Fw0qVzMJQGK79u2sXNGzveLbA?=
 =?us-ascii?Q?VgSsZZWnp5jb+9acWNnA4+1tfeD8xYN8bxe0MxQUmuH7uSmCLTae3cUXI/F1?=
 =?us-ascii?Q?cRwilg3tp3PDAJin1K4FCSDNxr1reay2LiGwX9qG+AMDA8yvGjbEUl47V7uu?=
 =?us-ascii?Q?5fuY3kSlO6jf4CHTm3n4H300VXraSdGRfpL+OCKvcbGKGHFR5uQ3lyQrDbVJ?=
 =?us-ascii?Q?XGGjtofQGMbyeF8d5+nhzrnhkh8TiD36JeWkOLuAVL0I1jfkC1zbAxUJoUts?=
 =?us-ascii?Q?qVOqJ+Ff1QioJbuVRjaMHlOhrXGGRBtVPDUSxHYcKZCxVZklkMjYWltaLqbh?=
 =?us-ascii?Q?shdcTcQU6/USWPb52ZxiQ0ZpmQzy9OyfMmV4N5+YaaV2tTl2UskvqLWvdMoe?=
 =?us-ascii?Q?3qZhsDEu16KuHO6jBhBNf+s8EJdhk4yE6uTdqWWI+VOBYIbdJDDxAsunct0u?=
 =?us-ascii?Q?yQP+L9HRl3KGi1/eN0iEw83eBD7ZrpljUHq9sqw6UAQEZ/GUj95W1o6V6S/f?=
 =?us-ascii?Q?SsfgxIrkGJDhc8FoGUiICkcTSl4ftEKOX71jjVKEv5dtCSfUQcAqdNh6nsU6?=
 =?us-ascii?Q?RzrKj9HQ+HpKH3+t7ExGBACcc55rkJBZvU9JqZEl9La6Edfp+u+MnwDcfa0k?=
 =?us-ascii?Q?t+vz2gLapcnVC8dUgD+hxMdt8U01Ya8SKMnLZ09bP8ZHZsS0Pwaya75S4MK6?=
 =?us-ascii?Q?v+zT6EiFdwGrpEViDLYMYjN7aPE3gUsLlv2h694XdisFW+/4jwuT7ab5UhzX?=
 =?us-ascii?Q?iJI4D8hJUvFLSTkzEKchoiNyNJDvg84z6CLQ1go84VzOO2YUB120riyDaKJa?=
 =?us-ascii?Q?D6eh9kjz2296QA2Iw05XfeSVMUlL4u0n498TkspVwbfNubAPi5S54V69ugFc?=
 =?us-ascii?Q?cb1LPUfc6OuxmpRWL/RtkRhVxggJ2S0hG7Izojn5elXPpfF4GZ26yTQKl2N6?=
 =?us-ascii?Q?eHUIh+xWSLEAJGaHJgbbjSefhxY8DsXlFIPZRaIrjbV6HQhIX4ThwlDQcZTf?=
 =?us-ascii?Q?Xx4JEuXdrZahRSYpqCw5YZM92EvfFcHinzSCRcqn29n9SgCkPjt1Ohq2whzY?=
 =?us-ascii?Q?mjuNB7ovog=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c55ea0a4-a54e-4a2b-068f-08da183ac780
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 02:03:16.4008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iAy3ChpNy7UcOS+A2vcITLAkWniHMApW7ODDgo8Tm8419w137sZKq4qzXQIjJc0TH4dX+z9zDXv2/mGCwHhHqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2437

From: Peng Fan <peng.fan@nxp.com>

V3:
 Addressed Michal's comments.
 Add Henry's T-b

V2:
 Per Julien's comments, fix coding style issue, drop unneeded code

Add i.MX lpuart driver and i.MX8QM platform support.
 - lpuart is the uart IP used in i.MX8QM/QXP/93.
 - Very basic i.MX8QM platform support.

Peng Fan (2):
  xen/arm: Add i.MX lpuart driver
  xen/arm: Add i.MX lpuart early printk support

 xen/arch/arm/Kconfig.debug              |  14 ++
 xen/arch/arm/arm64/debug-imx-lpuart.inc |  52 +++++
 xen/arch/arm/include/asm/imx-lpuart.h   |  64 ++++++
 xen/drivers/char/Kconfig                |   7 +
 xen/drivers/char/Makefile               |   1 +
 xen/drivers/char/imx-lpuart.c           | 276 ++++++++++++++++++++++++
 6 files changed, 414 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
 create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
 create mode 100644 xen/drivers/char/imx-lpuart.c

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 02:03:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 02:03:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300222.511937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncHUc-0004ws-7c; Thu, 07 Apr 2022 02:03:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300222.511937; Thu, 07 Apr 2022 02:03:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncHUc-0004wl-3w; Thu, 07 Apr 2022 02:03:26 +0000
Received: by outflank-mailman (input) for mailman id 300222;
 Thu, 07 Apr 2022 02:03:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nqs0=UR=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ncHUa-0004h6-LP
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 02:03:24 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20618.outbound.protection.outlook.com
 [2a01:111:f400:7d00::618])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e7750b31-b616-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 04:03:23 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB6PR0401MB2437.eurprd04.prod.outlook.com (2603:10a6:4:35::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 02:03:21 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%7]) with mapi id 15.20.5123.031; Thu, 7 Apr 2022
 02:03:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7750b31-b616-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E6plFObetNrjreWD34uCptHnpj0UXRvGezdXtIDWu4dxQzKYBZwVmffBwIeyYiuQYjHmxzDGHUL3QTPRap2ruMRhx+z0Dp6ON4ProEuUOk53Q1x0deCwvXxwx93/G06tK82l73MxwWKzBsCGG+9FLzcsx6fxhfrDqoBErUdwmTMTvlA3oM9iGod2tAHpdKVWdaM5xCnetjaQXkGIKmrR9B6y95VzS0lsmIt52/6W8SfZPBSw111Cm7UcuujONMocvnZ6kUdiuq2wHUkryezjaDJObu9wmoC4wFYISjisP8MQbyRFPX40OhXmESdtbHeBb3LCXsDzyNsPK+OpRfiTfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6Ea60UXWNEu2YSN7ELCxvrnBQ+J1Dknsgns4VJXC44o=;
 b=Af9yRWriE0Rt2QtgeEnK+P6RThOJ6ZDZjfgz/yomrKK0cZbUTF6k8zWO3r2pss5Zizw4NVtcoebfHRW/HP7gLP48J+UKzo2EHcjJ/TFmWPVgCxYqu8rNKPRk2U5mYzj9ntxe1HSj9CtTmJYNqtB2KZaIK/XyaJhiiE//NbrL+LS7v1SRh3ZmEVXZRUzK9trDKx+Qr5KMtjSsU3leR74u6eZhVS7Qg/0bZhOMSekwAIK/uul8VzGjqiGxIDgkiVMZaItUR5xkXgZMCqSv/7iU7ppcX78rQ+daWpf8BkIZze/otg3+5xnsKEw/4aCmtye2ubqdOCiOPFWFqaoj7+17nQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6Ea60UXWNEu2YSN7ELCxvrnBQ+J1Dknsgns4VJXC44o=;
 b=VmUYT0ZAgiKxSur+gN1NgAxhymXWygmzD/Qp6qR3aBsTb7z1aBejDiukf6bapZZOnKbrut5HIJmYxukWHpOmKnCQ7zSuIuR8S10UyQBHdm7+pSKjiodcLvoSvSXQ0BPoYsIF5YDK4vMb3jHUnNVanD8B23c2GTxtfDFkbZsK8OY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH V3 1/2] xen/arm: Add i.MX lpuart driver
Date: Thu,  7 Apr 2022 10:44:17 +0800
Message-Id: <20220407024418.9827-2-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220407024418.9827-1-peng.fan@oss.nxp.com>
References: <20220407024418.9827-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR02CA0047.apcprd02.prod.outlook.com
 (2603:1096:4:196::14) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 30f5c77b-3faa-43a1-ab4e-08da183aca8b
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2437:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB24373EF807E92FD89C8BE2C8C9E69@DB6PR0401MB2437.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BUjq0qHVC9HK+bF0ruC1k9sG7JBJgVvd01szyRhKyxPU8vOkaZrbHL9BUZ57DUb3ZoLh50defivF+kOC62e4s16m4L2ZLrmeqbHGUKfmXZZ1GphDoPjNQFzxP6uwaeJUHl3fhGs8CQr2I8jldosbQCcxVwO4OnZkaUi4Yey194sO3lsmfy+9ksO60gTr4KE7qomUMsPnU0+IIuDoDqRla0wYecB77WpV5MzL2o1WvAzj4LgKlchCU8i2x015VX6Samb96/2xNcbb3Re2bABOcenpJr21nP8lXTXaQngbw84JbM226V3godpd31ghIoTAre7rDpC6Ucd+joVEDBoBW3sdpoPkmB9ddXXOXTDVRPHEmLHWK5c9rhv5Rn4lbaNvtSrYlUC2NSceNdBq2CB8UKUL0GlNCPDeWfxCXs3Ls67ik6IeVor/J7Ed0ix18RDEJidMtTb51hrni6XJ4J7zBYYXycfF9y9CtW2NIO9isQmUwU2LLcMC7eCDAR4cfKB08Y5s9UUPncnfGzJm9BsV2XhhYkQmlDhBtMsi5kS4UduCDHa+ysBC3XEQZdzHl2PBPtQJU9IEdQN+7ZdYu9TKRVnIkQp0Xdk7MzNxBwJdyd6tKliCpvj9uIxZZHxEjstw6kt66SgULk9m7dePA3Q5NNEJm7QsDW7dUu/LTfQVBs7xB9BVqdqTUgxe1FD8SSusALMseEm1HeJ1BeP0W74NWNE3x5sw7wxWzBKxecqaSasbHeeBBW4wMbf49WRm9My6ujViN4oBq0+SeKiszpylDwbfwNU+tsFtkVuXb3g5NdFYcrrANwySVn8YExy+QVYD
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(26005)(186003)(52116002)(6506007)(8676002)(4326008)(7416002)(6486002)(2616005)(54906003)(1076003)(66476007)(316002)(508600001)(966005)(5660300002)(66556008)(66946007)(8936002)(83380400001)(38350700002)(38100700002)(6512007)(2906002)(86362001)(30864003)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bHseDMZpnyuK/SB4p9AJOunS5sfMMRiwcPzSl9Lp8UQirOlOVD+49PVTVX3D?=
 =?us-ascii?Q?kE7H2a7y+kVKCVD4STK4fI1Q4fphgju7IuXwZJ2NL8SrjFFz33IChuH8tpkR?=
 =?us-ascii?Q?m1Foj8zXsyws16wdN8oy+chv4nOJAbQZz/7IQhQclLzW6gn/T8OjEAaeOplR?=
 =?us-ascii?Q?wWLaAtNweroXeCP9uaP2oC/BnWIpnrIvluJaRGf5cZEU2RnrFli8ZDFjGkWr?=
 =?us-ascii?Q?rRVFLzgnHqzE6dOfCZ/NCVypFWJ5T0f/4OiRcFvxYg0zFIUrtxjfe0rc6w+D?=
 =?us-ascii?Q?4Gp8yDcrlNjthz1lz5qoD6wRSZ0xugQhqfQtQ7kYkTNaMpQTRzAOAgCQoeBJ?=
 =?us-ascii?Q?vIj8d/hBYK+ojWIo3v3WR83ryNEVcOV6SvjtFSGvoWqjEMExNoPSwQFSgrXx?=
 =?us-ascii?Q?BqErYljDQL2pPvkztwoEiDBlhsWwWCjk996WXNmoUa93T5bm+DQhrXPY/jSU?=
 =?us-ascii?Q?6N8Nl/JatBTpvw10E+3SMjYlwPTs98dv+ORlOnPI9Hjkz8Z+Yav8r/2XvIkc?=
 =?us-ascii?Q?IEL3hQ6CsHukoKhm5Q5uCzNRofD+YwMfIhFfEiRRnYU2e2BtQeCuUnm1MxYI?=
 =?us-ascii?Q?vBOZd1qChs2+kHf2u0Kc02geupELAu9RT/ggF3TQU9IElRbh5HpF5HaDnH5+?=
 =?us-ascii?Q?KdFK1pvdQecZBqsk/yvMy/uMp8qeJRPawLURXTrcuDOhMLOlhU/pQLgZxGSR?=
 =?us-ascii?Q?guevrGNfBhZ4m8OHJbcwNN5uQNVFxgeCUpyYfU1BYAGQ71EPptNJwtE+QgeN?=
 =?us-ascii?Q?pX7fXg2mWeSJaqSlde4P6ValTxKsbWdhPbpTJW7gi+6tVVEVYOd28GTtrPXg?=
 =?us-ascii?Q?98n20Ifx1r6YfJsEfX6EWqxzYOuv85QMhSKO4yQrkP9D3FKwmHXECYM7tR4k?=
 =?us-ascii?Q?Wf26A2LPet2Yx6/HAJVU5UlPo8iIV4toE9KfjTWLM7JAkxgOKhHPG9HBpjzO?=
 =?us-ascii?Q?pmv3BFcK2FNUJBE8dGzvlVWJTNejyDvA7lo0NdsqziDsfjU+hHbXG5YCSkqn?=
 =?us-ascii?Q?loRd80NucxnSM/1CphvSe0vxQQY0T3CuryB6pupc34vQJYEiJwMMJJGEHMkt?=
 =?us-ascii?Q?6ibPFw1fs0qMV3L/rOQ54dFsQQ//l5qD9NrHwoxy1PxpvixQIrMox1uu7hY3?=
 =?us-ascii?Q?N62V5wMZZJPvC+i1XSkvJYM4Uc/0yfm6NOCIsMTmts53/774BgXKDJdc6hmL?=
 =?us-ascii?Q?/jlB1uvEBa6Z9g0nCJoDVzekN4XJsQDJRdnZyiCO5aM5CBJJ50aeJOj94Fkm?=
 =?us-ascii?Q?1OSwqcGRW2j0IJAHGHpBapox8VgckxABhkQ20oznVsBrkC4qyCNYvfKn6xm6?=
 =?us-ascii?Q?78jzOrpsxxisWGZJ8KoMYCA7SJYHjpeNr7xZEKQ/8EPmYm4EDD1AqW61/MRu?=
 =?us-ascii?Q?JlF83cuL6Kv8qfXY1hiIPdfnFRxyIwGa4Yxw8Yz40ilbYs+UNF9gnY5GGsOh?=
 =?us-ascii?Q?/TOMdC0bVGG/hXh9GSlTXhYgAbLqw+xyIJQ3DY3lRSr22zlA7KSCidQ/aNYq?=
 =?us-ascii?Q?1cgQvcIhOycK8WJqLBkOXAPYhCyWsihVoBWjhPDCXbSElnSF/dpn1/z+EXxV?=
 =?us-ascii?Q?DMYyLxetuRPlhsN24rQazM7RyrE4VSdFkmyi6DNhpTEUqatN68PxOgbaVuRv?=
 =?us-ascii?Q?jYXgFAbhAPYLc3xSrOIX4LfOI8rVhBpw/83DX6+Px2qxahoLN7PFB6y72uOJ?=
 =?us-ascii?Q?JjKr05bDj6ze6pG8949putZkFHwLR4rRu5AYUwKPQ/qwSK9Cl+bqcnC3vUbD?=
 =?us-ascii?Q?d88dv+uhtw=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30f5c77b-3faa-43a1-ab4e-08da183aca8b
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 02:03:21.4323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9abojc9AyKulFTVJIi3pAWXcDgvuTINEg6WTI7XnwrXhTOun2yaSzlnHYQSLCuFpxAd9wiIS0FrxeNTsFRq4mQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2437

From: Peng Fan <peng.fan@nxp.com>

The i.MX LPUART Documentation:
https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
Chatper 13.6 Low Power Universal Asynchronous Receiver/
Transmitter (LPUART)

Tested-by: Henry Wang <Henry.Wang@arm.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
 xen/drivers/char/Kconfig              |   7 +
 xen/drivers/char/Makefile             |   1 +
 xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
 4 files changed, 348 insertions(+)
 create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
 create mode 100644 xen/drivers/char/imx-lpuart.c

diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
new file mode 100644
index 0000000000..111640edb4
--- /dev/null
+++ b/xen/arch/arm/include/asm/imx-lpuart.h
@@ -0,0 +1,64 @@
+/*
+ * xen/arch/arm/include/asm/imx-lpuart.h
+ *
+ * Common constant definition between early printk and the LPUART driver
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ASM_ARM_IMX_LPUART_H__
+#define __ASM_ARM_IMX_LPUART_H__
+
+/* 32-bit register definition */
+#define UARTBAUD          (0x10)
+#define UARTSTAT          (0x14)
+#define UARTCTRL          (0x18)
+#define UARTDATA          (0x1C)
+#define UARTMATCH         (0x20)
+#define UARTMODIR         (0x24)
+#define UARTFIFO          (0x28)
+#define UARTWATER         (0x2c)
+
+#define UARTSTAT_TDRE     BIT(23)
+#define UARTSTAT_TC       BIT(22)
+#define UARTSTAT_RDRF     BIT(21)
+#define UARTSTAT_OR       BIT(19)
+
+#define UARTBAUD_OSR_SHIFT (24)
+#define UARTBAUD_OSR_MASK (0x1f)
+#define UARTBAUD_SBR_MASK (0x1fff)
+#define UARTBAUD_BOTHEDGE (0x00020000)
+#define UARTBAUD_TDMAE    (0x00800000)
+#define UARTBAUD_RDMAE    (0x00200000)
+
+#define UARTCTRL_TIE      BIT(23)
+#define UARTCTRL_TCIE     BIT(22)
+#define UARTCTRL_RIE      BIT(21)
+#define UARTCTRL_ILIE     BIT(20)
+#define UARTCTRL_TE       BIT(19)
+#define UARTCTRL_RE       BIT(18)
+#define UARTCTRL_M        BIT(4)
+
+#define UARTWATER_RXCNT_OFF     24
+
+#endif /* __ASM_ARM_IMX_LPUART_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index 2ff5b288e2..e5f7b1d8eb 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -13,6 +13,13 @@ config HAS_CADENCE_UART
 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
 	  based board, say Y.
 
+config HAS_IMX_LPUART
+	bool "i.MX LPUART driver"
+	default y
+	depends on ARM_64
+	help
+	  This selects the i.MX LPUART. If you have i.MX8QM based board, say Y.
+
 config HAS_MVEBU
 	bool "Marvell MVEBU UART driver"
 	default y
diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
index 7c646d771c..14e67cf072 100644
--- a/xen/drivers/char/Makefile
+++ b/xen/drivers/char/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o
 obj-$(CONFIG_HAS_OMAP) += omap-uart.o
 obj-$(CONFIG_HAS_SCIF) += scif-uart.o
 obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o
+obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o
 obj-$(CONFIG_ARM) += arm-uart.o
 obj-y += serial.o
 obj-$(CONFIG_XEN_GUEST) += xen_pv_console.o
diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
new file mode 100644
index 0000000000..df44f91e5d
--- /dev/null
+++ b/xen/drivers/char/imx-lpuart.c
@@ -0,0 +1,276 @@
+/*
+ * xen/drivers/char/imx-lpuart.c
+ *
+ * Driver for i.MX LPUART.
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/errno.h>
+#include <xen/init.h>
+#include <xen/irq.h>
+#include <xen/mm.h>
+#include <xen/serial.h>
+#include <asm/device.h>
+#include <asm/imx-lpuart.h>
+#include <asm/io.h>
+
+#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
+#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
+
+static struct imx_lpuart {
+    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
+    uint32_t irq;
+    char __iomem *regs;
+    struct irqaction irqaction;
+    struct vuart_info vuart;
+} imx8_com;
+
+static void imx_lpuart_interrupt(int irq, void *data,
+                                 struct cpu_user_regs *regs)
+{
+    struct serial_port *port = data;
+    struct imx_lpuart *uart = port->uart;
+    uint32_t sts, rxcnt;
+
+    sts = imx_lpuart_read(uart, UARTSTAT);
+    rxcnt = imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
+
+    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
+	    serial_rx_interrupt(port, regs);
+
+    if ( sts & UARTSTAT_TDRE )
+	    serial_tx_interrupt(port, regs);
+
+    imx_lpuart_write(uart, UARTSTAT, sts);
+}
+
+static void __init imx_lpuart_init_preirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t ctrl, old_ctrl, bd;
+
+    old_ctrl = imx_lpuart_read(uart, UARTCTRL);
+    ctrl = (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
+    bd = imx_lpuart_read(uart, UARTBAUD);
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
+	    cpu_relax();
+
+    /* Disable transmit and receive */
+    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL_RE));
+
+    /* Reuse firmware baudrate settings, only disable DMA here */
+    bd &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+
+    imx_lpuart_write(uart, UARTMODIR, 0);
+    imx_lpuart_write(uart, UARTBAUD, bd);
+    imx_lpuart_write(uart, UARTCTRL, ctrl);
+}
+
+static void __init imx_lpuart_init_postirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    uart->irqaction.handler = imx_lpuart_interrupt;
+    uart->irqaction.name = "imx_lpuart";
+    uart->irqaction.dev_id = port;
+
+    if ( setup_irq(uart->irq, 0, &uart->irqaction) != 0 )
+    {
+        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
+                uart->irq);
+        return;
+    }
+
+    /* Enable interrupts */
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp |= (UARTCTRL_RIE | UARTCTRL_TIE);
+    temp |= UARTCTRL_ILIE;
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static void imx_lpuart_suspend(struct serial_port *port)
+{
+    BUG();
+}
+
+static void imx_lpuart_resume(struct serial_port *port)
+{
+    BUG();
+}
+
+static int imx_lpuart_tx_ready(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
+}
+
+static void imx_lpuart_putc(struct serial_port *port, char c)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
+        cpu_relax();
+
+    imx_lpuart_write(uart, UARTDATA, c);
+}
+
+static int imx_lpuart_getc(struct serial_port *port, char *pc)
+{
+    struct imx_lpuart *uart = port->uart;
+    int ch;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
+	    return 0;
+
+    ch = imx_lpuart_read(uart, UARTDATA);
+    *pc = ch & 0xff;
+
+    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
+        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
+
+    return 1;
+}
+
+static int __init imx_lpuart_irq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return ((uart->irq > 0) ? uart->irq : -1);
+}
+
+static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return &uart->vuart;
+}
+
+static void imx_lpuart_start_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTSTAT);
+    /* Wait until empty */
+    while ( !(temp & UARTSTAT_TDRE) )
+	    cpu_relax();
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
+}
+
+static void imx_lpuart_stop_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp &= ~(UARTCTRL_TIE | UARTCTRL_TCIE);
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static struct uart_driver __read_mostly imx_lpuart_driver = {
+    .init_preirq = imx_lpuart_init_preirq,
+    .init_postirq = imx_lpuart_init_postirq,
+    .endboot = NULL,
+    .suspend = imx_lpuart_suspend,
+    .resume = imx_lpuart_resume,
+    .tx_ready = imx_lpuart_tx_ready,
+    .putc = imx_lpuart_putc,
+    .getc = imx_lpuart_getc,
+    .irq = imx_lpuart_irq,
+    .start_tx = imx_lpuart_start_tx,
+    .stop_tx = imx_lpuart_stop_tx,
+    .vuart_info = imx_lpuart_vuart_info,
+};
+
+static int __init imx_lpuart_init(struct dt_device_node *dev,
+                                  const void *data)
+{
+    const char *config = data;
+    struct imx_lpuart *uart;
+    int res;
+    u64 addr, size;
+
+    if ( strcmp(config, "") )
+        printk("WARNING: UART configuration is not supported\n");
+
+    uart = &imx8_com;
+
+    uart->baud = 115200;
+    uart->data_bits = 8;
+    uart->parity = 0;
+    uart->stop_bits = 1;
+
+    res = dt_device_get_address(dev, 0, &addr, &size);
+    if ( res )
+    {
+        printk("imx8-lpuart: Unable to retrieve the base"
+               " address of the UART\n");
+        return res;
+    }
+
+    res = platform_get_irq(dev, 0);
+    if ( res < 0 )
+    {
+        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
+        return -EINVAL;
+    }
+    uart->irq = res;
+
+    uart->regs = ioremap_nocache(addr, size);
+    if ( !uart->regs )
+    {
+        printk("imx8-lpuart: Unable to map the UART memory\n");
+        return -ENOMEM;
+    }
+
+    uart->vuart.base_addr = addr;
+    uart->vuart.size = size;
+    uart->vuart.data_off = UARTDATA;
+    /* tmp from uboot */
+    uart->vuart.status_off = UARTSTAT;
+    uart->vuart.status = UARTSTAT_TDRE;
+
+    /* Register with generic serial driver */
+    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
+
+    dt_device_set_used_by(dev, DOMID_XEN);
+
+    return 0;
+}
+
+static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
+{
+    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
+    { /* sentinel */ },
+};
+
+DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
+    .dt_match = imx_lpuart_dt_compat,
+    .init = imx_lpuart_init,
+DT_DEVICE_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 02:06:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 02:06:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300234.511959 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncHXr-0006Wh-42; Thu, 07 Apr 2022 02:06:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300234.511959; Thu, 07 Apr 2022 02:06:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncHXr-0006WY-0y; Thu, 07 Apr 2022 02:06:47 +0000
Received: by outflank-mailman (input) for mailman id 300234;
 Thu, 07 Apr 2022 02:06:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0ZzD=UR=intel.com=lkp@srs-se1.protection.inumbo.net>)
 id 1ncHXp-0006WK-0C
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 02:06:45 +0000
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5cff4ae5-b617-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 04:06:42 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Apr 2022 19:06:36 -0700
Received: from lkp-server02.sh.intel.com (HELO a44fdfb70b94) ([10.239.97.151])
 by orsmga004.jf.intel.com with ESMTP; 06 Apr 2022 19:06:33 -0700
Received: from kbuild by a44fdfb70b94 with local (Exim 4.95)
 (envelope-from <lkp@intel.com>) id 1ncHXc-0004yZ-MW;
 Thu, 07 Apr 2022 02:06:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cff4ae5-b617-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649297202; x=1680833202;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=dQrnEJaSMkZbyuRDxzwznPl1VKPOiEnuTwnVLSNQtLg=;
  b=P+xRyrQK47vxm6ysP3pFiwFeh7A/0MNji1z3qbdJt5ruxL/yZD/zixYI
   u+ZoiXzwg7KocaILrBhgHiiZolSbcBc9wgOmESPIs20dgCPlIIs7ykJvJ
   y+SLi0P88C7DZ12f++n+nDNGfF3s+8h/ACQ7UR3ATinQKTCISetmX/jjF
   DdieZRhrjWyKqe2y0pAvZNeX/XsD6OtKmYRhBp9PkwsK8hx8//TFINkaQ
   SrfyuaW7S0zE42aoVYq1Y4z7JAmZK3/sVTuG3CnEBkFIoLANDl8c4bSNm
   MAz3F1zMAPFQd3QrS32v7rqNpyEoAq2KxnWuRKnYiso1OOyjL1fOOb4tw
   Q==;
X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="347648313"
X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; 
   d="scan'208";a="347648313"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; 
   d="scan'208";a="658861171"
Date: Thu, 7 Apr 2022 10:06:01 +0800
From: kernel test robot <lkp@intel.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone
Message-ID: <202204070950.mzGBYW2q-lkp@intel.com>
References: <20220406133229.15979-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406133229.15979-1-jgross@suse.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

Hi Juergen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on xen-tip/linux-next]
[also build test WARNING on linus/master linux/master v5.18-rc1 next-20220406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Juergen-Gross/xen-balloon-fix-page-onlining-when-populating-new-zone/20220407-000935
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: arm64-randconfig-r036-20220406 (https://download.01.org/0day-ci/archive/20220407/202204070950.mzGBYW2q-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c4a1b07d0979e7ff20d7d541af666d822d66b566)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/b3deb59d5386ade4fb227038f202a9bdb8ade4ab
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Juergen-Gross/xen-balloon-fix-page-onlining-when-populating-new-zone/20220407-000935
        git checkout b3deb59d5386ade4fb227038f202a9bdb8ade4ab
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/media/platform/ drivers/xen/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/xen/balloon.c:518:10: error: implicit declaration of function 'alloc_page_for_balloon' [-Werror,-Wimplicit-function-declaration]
                   page = alloc_page_for_balloon(gfp);
                          ^
>> drivers/xen/balloon.c:518:8: warning: incompatible integer to pointer conversion assigning to 'struct page *' from 'int' [-Wint-conversion]
                   page = alloc_page_for_balloon(gfp);
                        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/xen/balloon.c:545:3: error: implicit declaration of function 'add_page_to_balloon' [-Werror,-Wimplicit-function-declaration]
                   add_page_to_balloon(page);
                   ^
   1 warning and 2 errors generated.


vim +518 drivers/xen/balloon.c

   505	
   506	static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
   507	{
   508		enum bp_state state = BP_DONE;
   509		unsigned long i;
   510		struct page *page, *tmp;
   511		int ret;
   512		LIST_HEAD(pages);
   513	
   514		if (nr_pages > ARRAY_SIZE(frame_list))
   515			nr_pages = ARRAY_SIZE(frame_list);
   516	
   517		for (i = 0; i < nr_pages; i++) {
 > 518			page = alloc_page_for_balloon(gfp);
   519			if (page == NULL) {
   520				nr_pages = i;
   521				state = BP_EAGAIN;
   522				break;
   523			}
   524			list_add(&page->lru, &pages);
   525		}
   526	
   527		/*
   528		 * Ensure that ballooned highmem pages don't have kmaps.
   529		 *
   530		 * Do this before changing the p2m as kmap_flush_unused()
   531		 * reads PTEs to obtain pages (and hence needs the original
   532		 * p2m entry).
   533		 */
   534		kmap_flush_unused();
   535	
   536		/*
   537		 * Setup the frame, update direct mapping, invalidate P2M,
   538		 * and add to balloon.
   539		 */
   540		i = 0;
   541		list_for_each_entry_safe(page, tmp, &pages, lru) {
   542			frame_list[i++] = xen_page_to_gfn(page);
   543	
   544			list_del(&page->lru);
   545			add_page_to_balloon(page);
   546		}
   547	
   548		flush_tlb_all();
   549	
   550		ret = xenmem_reservation_decrease(nr_pages, frame_list);
   551		BUG_ON(ret != nr_pages);
   552	
   553		balloon_stats.current_pages -= nr_pages;
   554	
   555		return state;
   556	}
   557	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:06:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:06:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300240.511970 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncITD-0004tl-Fk; Thu, 07 Apr 2022 03:06:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300240.511970; Thu, 07 Apr 2022 03:06:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncITD-0004te-BI; Thu, 07 Apr 2022 03:06:03 +0000
Received: by outflank-mailman (input) for mailman id 300240;
 Thu, 07 Apr 2022 03:06:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncITB-0004tY-Tu
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:06:02 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a53d7d4d-b61f-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:05:58 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236LpIFL004895; 
 Thu, 7 Apr 2022 03:05:19 GMT
Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta02.appoci.oracle.com [147.154.18.20])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d932m5e-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:05:19 +0000
Received: from pps.filterd
 (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23730Wj4013140; Thu, 7 Apr 2022 03:05:19 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2177.outbound.protection.outlook.com [104.47.56.177])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f9803h1d3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:05:18 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by CY4PR1001MB2152.namprd10.prod.outlook.com (2603:10b6:910:4a::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 03:05:16 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:05:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a53d7d4d-b61f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=YsLEXwzHHuhF8Y2ubKs7WB5IRORi93e0Vmn68Bi4rNA=;
 b=NfkaK2NCMW3x6JiAe6CyDENNOARvHDPb02I5fwoWxOu6QfcjwiXHY8Xrx4mcDWkinikI
 6y4iSHee4zyBe8QJm5tGfgOkAj83SF9OykxjXn7vNSW2mJgWYrf5/fUSzDfg0XfmCs1J
 +oAbW8F3tDhDUqTy+eCamQ91BX21vJ4MJB4EGZR8HynPhZNqhlYoDA/HLfQDBP+Bo4CR
 x9rTg/eQ+/XOfhq/Ik5Mn266beB4VlXnYt6pQZmsHu7vA+BBuG6FRivVgrT/mpZl+pEH
 mlVBoOLNp7A97wLDUSOK5yHa7XAT643O9e2NZAIcfD0zc10YNOs0pYfWr7nlIIE2mlT4 XQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pp4OarTXw+ZWc+bEDRdAMXK755D2xX211YX+owPz9Du0TAvRUTo0JMux+A2OBM8Q2RUIis1E841+yCJs3xSxOmManJFMNq/HKUK46nW4ugGIOqLPGPgQd14A1tT8dQfZlck321dug3Mlr2oaMTCQFvDd9E0upVxo+d9LhdX4SwQT3T8h8pK6k6iRAaCjv4YL50Q0xnldBeKAjs11+DaPoBl3CCRMJKr7fmlIrDoclgTj6ihaJnWuAbqLIm7qh9YvCfak7EPF5C9DPbF1lWENUC42C9Z7b0y7xOYJ+PhU/FYlCF6pgrdVPLHHqR7SIoekmjE054OxDImP2k0DAwej/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YsLEXwzHHuhF8Y2ubKs7WB5IRORi93e0Vmn68Bi4rNA=;
 b=MJpc+Q7Ee5f5cXgLArRFIO4GyTTByPQx/d+m/IktmZG1Q2KjRsf3Svl5A68hZNXDF7kpuKr0pGRYjRw0C4XD7EoN0n07HUtxAO+b5dM7h/Uz6tdrf8b4he6u5lJlRmKgpr04K9z+au2MRXr+x8POHZP/ZqFMZA1PvWr7ZZXtfD3C99pZ5FRmFQM/9TdsrBDSlVYpU73UGohcFQJ3GfN9i3QL1W+5s2ONRlUGdyHlytwDfgucSyTx6OZi/RwSYs2QdaJqUc1nlht+1irrCCn5KicE7KDAfgGur/oyN7PP7VCj97AuEL+jFJAmbHFPbZB+igWeXGiRoFpF9eKUVY46cA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YsLEXwzHHuhF8Y2ubKs7WB5IRORi93e0Vmn68Bi4rNA=;
 b=nQ1EV2Z2MwlvkJGlLAO7iFJYI6/mpP6qHesyCjyJNkoNah/7fILGtoubqQmqI1YcRdlyln9Kt9HjWF/h9c7R0jKk1BKfkc8enXMa4DreRin9+h1VJ4fFvcD86VOH7JoEWo+TzBXyBlfYYFG+s2hxLrvDcOlC6vYzT0JUfYneq2c=
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, jfs-discussion@lists.sourceforge.net,
        linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
        linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
        linux-btrfs@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 01/27] target: remove an incorrect unmap
 zeroes data deduction
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wng1k2zn.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-2-hch@lst.de>
Date: Wed, 06 Apr 2022 23:05:13 -0400
In-Reply-To: <20220406060516.409838-2-hch@lst.de> (Christoph Hellwig's message
	of "Wed, 6 Apr 2022 08:04:50 +0200")
Content-Type: text/plain
X-ClientProxiedBy: DM5PR07CA0068.namprd07.prod.outlook.com
 (2603:10b6:4:ad::33) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 446c5253-2f86-4e5c-b24c-08da184370bf
X-MS-TrafficTypeDiagnostic: CY4PR1001MB2152:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR1001MB2152E05222F1BBC5E98158F98EE69@CY4PR1001MB2152.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	/nK5r/MuRnz8ktLCSFU22KjRIztZG5J+F4JDyOjXsdc31ie4LJRCbfsRVHM01SOjoWooWtF/OnruYEf2sJXIEJue+piPjYr79bmJhLuQxBTBaQMOegKNCL9P2RvPOPpM8gfjxEr2yp80dF71knzsUCiBPN97PDjwemHuidm0+ofeUYw32YiEMBOy+1Iswc5HiqLGRnNF0e3b6Kc4eUmHS5wX2i2DpHYidv4jAIaSRvP/UhzP3/8X+TMW52/5lz7HRoqyi+sOrCXAsCpWuXfg/E5nkUNHBjyV4ftC4ywCqRzk3NtYhWbzdvu0h+jV5tT9PvegMNvV8rz9qOzTy/mZcIGQ8D0GMCS3y0XjDGIJnAO1ORk75BbzU928Z1XBN6iT1tS/rKgnjO9Ql8iLGFulJ/lh7kVVnbOazr4/rqcL+YEoNsRgPBL02Y95X/uBSe7ksFXUETPP6a93DCohbGGlDToepS4lrXNrU4ROpdJoK55bybd5iNINiXPe3iivRayOLl6+iGGxfChhwp9ku/zix51NXgP9T4nGMBQ6OTYoMYhKm5hcti/urkEGQOejQc8TFc2MKf0a5e/IusjLKxQksMTYESwPmzNuRnrIgR0MIGkNtfxCCxtk3G2DtlJNoyCblF0gBziHq5pkVPTHzLnkyYZSvfhYWtCtSxeacZo2xalKWfaSiplfVJx53owNYdHAAejIzZINATBpKhooZ+F4Vw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38350700002)(38100700002)(26005)(6916009)(316002)(186003)(52116002)(2906002)(6506007)(6666004)(66556008)(86362001)(7416002)(508600001)(66946007)(8676002)(8936002)(66476007)(5660300002)(6486002)(4326008)(4744005)(36916002)(6512007)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?qY1nBGMXTuj8DG81dMRc1M9V4GVzuBIJ9qlOqc0uEdupd1bv+wCC59Ok6bo6?=
 =?us-ascii?Q?xybN22YVd/YDX8pGkxRCTpNSAXeh7lEoIdjnKlD4FPDjd1Q/zUsgbz5nMYM8?=
 =?us-ascii?Q?ITgNiQBp3NFaZGQCH225g0rN4jvLRSrMbzrlQ1xNMKU/mw2v54+/JIO8KuXG?=
 =?us-ascii?Q?Ivbo2zsRUjQQ4GiFmEtFh3YswKW7gJqMaRHsb9UcYsfregBwGVUrDiqZxBM2?=
 =?us-ascii?Q?ZSTlD0veR8ee7l0+5ApD/bKF/A/9kyzPsB3OusFL8ArYkHJfgCBJFqbfUuvr?=
 =?us-ascii?Q?t2lClIH4fAcA/eivwaSfLdMv7MEccMoyc2BbqUCvwG1DmCVjdjclfmwAkipO?=
 =?us-ascii?Q?3cVkfQRz8YKcbBcMV1KRP/DTMct+zBYnFNpfNy1Qmu27R8foSFqOKBVouGru?=
 =?us-ascii?Q?ydHGK86lkXLIYlfgwAtlU54MpAwHPpbVGHexsYhVbhXFm/jv1Rox725aNt8Z?=
 =?us-ascii?Q?KWzLwwQMSFGclLUtjLxxwuk3VjPY5HQPq02436NzC6gE5QTAUJH7PAVReXyp?=
 =?us-ascii?Q?d7iS93ChD8r2pGPAW2Q7cV8HeCT3GZR8cP9/5sLujMHhYrIwuJ0JyRWQs2AA?=
 =?us-ascii?Q?S7WO1oE7n00OGyZxnzbPhh86u4clsYw7nu+zWEccbvkd3H73a+s55DBdhBsX?=
 =?us-ascii?Q?EOSm3vUpPdWqd/NFB6Buav//MlAsh1j0ZetHi6J7XNmG3MCK2Ypd/KLkWxAQ?=
 =?us-ascii?Q?a9JJtEKXaG44jB8I6cCApuB5Evi/JP6sDm1C2LHDGy5MPg1jOeU1NpYahRbs?=
 =?us-ascii?Q?BZaDVmD3jyJ6H+SXWlW6MyKUScTXOMH/E8C02jCKsizLJbM5dOaJXCtJjp0t?=
 =?us-ascii?Q?ocGw9J1Eb7HZ+X3pYDM0/GO2ev238mT65vcSA0MrvfeeTKVuByoBoqy+7GJT?=
 =?us-ascii?Q?9I+REuB5mK3DT7ngexEU0TSy/hk6IDvbjLBPBEV8ak75ftSp40C5v14WbuvC?=
 =?us-ascii?Q?p9XcjGOhncF8nf1NCaLAY7wO9zgOnk+DzCaUG9pnt2iKGS+x12y3tFeqyupG?=
 =?us-ascii?Q?rlNVlp41NrsO2WD0Dj38OPI/CmJX+a/V3QxYrZs2pzCxwUxBkaS16BYJ19gs?=
 =?us-ascii?Q?utAJkPO9UcbMD1+p215yuOrF92OGRwnXIWUhWR0j1jnarPXh8Rx1g6WU5kIw?=
 =?us-ascii?Q?o6D5qM6yCgzqQS4ti8CR3a7YAUU+5K+Lur1IQbZ0jZ0UNcYqVAiRb0j1EDB9?=
 =?us-ascii?Q?snHxE2XKWTJ2Mc9tza3YxNjH+GoOVSmXsYmD/HLDjJ2rIDVtDmwZIuKlFStA?=
 =?us-ascii?Q?omkqKxn9xz8TAkZMov+tIAv3gSUfwB5k0yQH/9rv/TBeVR4K2/YqKhDBQffa?=
 =?us-ascii?Q?HgYYBLKVuV6ceja2TdZ/CiHIWMujNH3OPXFFfldRfkuoslxSbRk+AFl/0nul?=
 =?us-ascii?Q?bEYpvSqdZTuzCkhL/2DBp/sbtQHmJ1NkWMfGzA61MWF1wKm83Y36Nsrkqf9E?=
 =?us-ascii?Q?o+E8ycTJrFoj0R5DpHdN6kYroViJ50Gz89cLuSVSSDfXQc10hX06ize9gyU+?=
 =?us-ascii?Q?/ZOQYRwRDYL3DvU4idJibgI/zufed0BUnXDaI40FReyrrjtz8aMUU5sjQQEy?=
 =?us-ascii?Q?iUXFTa/BX37Lp80KVcYTfRZjxe1N/PeHsQwdyGpPuGOQjqHIVhWZPyD+I1ld?=
 =?us-ascii?Q?8qv1/Uxosiz61rt1qgrjx2Rcvox57kV9ZCsNKzW9mdJtSBiSCDurcEV+OILv?=
 =?us-ascii?Q?wHo9IC8tCyj7fQ3lZr3yKFe+94f5EPtGJDq5xbOz2yiALz4f+quYstOYI+gE?=
 =?us-ascii?Q?JTt78DP66djTrkit7F/PPtKpGwvCvXA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 446c5253-2f86-4e5c-b24c-08da184370bf
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:05:16.1549
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8wd1AdPWpIjcCjxsi2pbd+ciWqzHOAajRxs38iCvhynb2Xri9DgaS4+iigUZuPE6wN79jbNBsZ1lsFi5zU6X0feZ+MmPZxgDmebjEXCo6PI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2152
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 suspectscore=0 spamscore=0 mlxlogscore=953 bulkscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070015
X-Proofpoint-ORIG-GUID: z327C3w_lmDACCGlZXgN11Rpzh40Eu0h
X-Proofpoint-GUID: z327C3w_lmDACCGlZXgN11Rpzh40Eu0h


Christoph,

> For block devices the target code implements UNMAP as calls to
> blkdev_issue_discard, which does not guarantee zeroing just because
> Write Zeroes is supported.
>
> Note that this does not affect the file backed path which uses
> fallocate to punch holes.
>
> Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout")
> Signed-off-by: Christoph Hellwig <hch@lst.de>



-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:07:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:07:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300244.511981 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIUS-0005Up-S2; Thu, 07 Apr 2022 03:07:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300244.511981; Thu, 07 Apr 2022 03:07:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIUS-0005Ui-P1; Thu, 07 Apr 2022 03:07:20 +0000
Received: by outflank-mailman (input) for mailman id 300244;
 Thu, 07 Apr 2022 03:07:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIUR-0005Uc-IB
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:07:19 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d4830c2c-b61f-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:07:18 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2372lGBk024447; 
 Thu, 7 Apr 2022 03:06:50 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6f1tar6c-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:06:50 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 237312LF004298; Thu, 7 Apr 2022 03:06:48 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f974djun3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:06:48 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by CY4PR1001MB2152.namprd10.prod.outlook.com (2603:10b6:910:4a::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 03:06:19 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:06:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4830c2c-b61f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=GpTq+EYaOf33mkP0QbI4hVWDfTMc3+BcRAeyKVHiQdA=;
 b=0NtihXCzQ1+FQ1tCY3eP6NaSpVt4C62wBMyONHaQNDXk+Df7NABfYZ8ObxD6z0o7h0Uc
 4hadU2EUf9PJcm+SUs3zQ9fmikp6iPVKfKznotYPBhCxFizO3X7756CP4yBhNN4ETH+d
 zRknrleWVirHM8J6jWMYloqaVcNB8LeCiln5KswXELm519im3zOt+dJH4qPAGniklmBH
 bESiGf/Di83wWhWNbSjeJTOjlax0eu+rRflOqChjuyVyITKb/Ywanr4aHYF0/eba8zNN
 7gHxkMSTCK0+dV6aKHHStj60hOdZtNU2yzeS/UQagbF8ZY+LhFGqdP/KG8ZK+UbN7UwB hQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cLQyDGZjz9e5kGsIXiasl+FudbBS83gooaVFwXgwFs2a8+SJVQFEqquL+nxm13lbPaI4QWnBC6ArtnXcEKpgyHY7foFdwv/vGOXP5SJDBdKSNSqSQiLL0z0KTxkpZTdA4E9+sNu6Ofe/CE0cOwVvg+OKGnTf81t3rdYOZoCunKxqpObWCVTIWrg8Qvyns3LYmoNFH4Weo2VVMa1LpN/YL4OmiGWGGfNogwBjzVE0KvZ354/QhVnuCyPaFJiobgrLCq9Zh9AX8Aj+ZgvFVIimrmxaw97uZa0Kg6B2fWTd2+He9tbP2rQ03zzQb4mbfRMiHhNh3YU0rGctNb6uvfD/rA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GpTq+EYaOf33mkP0QbI4hVWDfTMc3+BcRAeyKVHiQdA=;
 b=Qg0WMF55k/bOfrrcrnEmDyEj8/Yp+C5Vk+a3YPGgDogOp+ItWErekTFUKCnG8IbWNs1QvnGQcyrBmmwdWeM3JHSWCTbK92XjBf+aoo7pJWvm+LBSGHF/d6Xkv6qG3ef+5vrPETXfTFkrF4OdBCs3njMfAitQCKR0qrMuO6PfUb/eoKdTieySwTlQrDPwMpD5BRUrA9lOsT7NNtKDIpqBqCgTEI4HuIFrXFLGbxlSy0x4kAd17GUE2FKxQG7Z+h9Aiy5L40wDM3o4ngyJSqVGaCT6yX+jzPUM0t6SPAXKvtlRcdNY91nRjLzZYyaeKBKaUM1QHtQ3GTfeaW/pIrFDnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GpTq+EYaOf33mkP0QbI4hVWDfTMc3+BcRAeyKVHiQdA=;
 b=gDztzgY+0MTm858J5pOD5Pd9XMYDn8b3HB9bRXThKIG3nIuA8Iz2WZr54mlYTUGmJHgrh7VZTPz1jnKsBMZHQiDBv2ZEbUfHxUS2PxyPG2xYsavbOoPW8RgKq3rHpGae6dXCiruNikqadkTSoHNxT1m65ZTORLyJX9MSlakIxUI=
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, jfs-discussion@lists.sourceforge.net,
        linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
        linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
        linux-btrfs@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 01/27] target: remove an incorrect unmap
 zeroes data deduction
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1r169k2xu.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-2-hch@lst.de>
Date: Wed, 06 Apr 2022 23:06:16 -0400
In-Reply-To: <20220406060516.409838-2-hch@lst.de> (Christoph Hellwig's message
	of "Wed, 6 Apr 2022 08:04:50 +0200")
Content-Type: text/plain
X-ClientProxiedBy: SJ0PR03CA0039.namprd03.prod.outlook.com
 (2603:10b6:a03:33e::14) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a45fa5a3-2b8c-4663-be6d-08da18439656
X-MS-TrafficTypeDiagnostic: CY4PR1001MB2152:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR1001MB21524D0DD0DA9107A204A6C88EE69@CY4PR1001MB2152.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	U4jjgczi03ykHWBNvY7OUBUl1+P80cR/Pe815rLSpQPiNX4p1O5QhDHqf1wb0FEsseboc977hNdEwEtbd1OycC6feYukDwwGM6vRWJ9hnSl8Qla7fwnuzysY6uZhV0fNUxdDpjxq8jkvS2Ds06PvCrhiQ+38fH2gifhYXSRWFhmO9Cf3jrRek4L/CaYDd6oRJp21Q5GIc25es3mUqapUBvooJxsToL5+O/kxRSJGZrxGqkgW8Mf20mbBDDl7GkFeYBfdWOSR9al3dKNsnXVmY88hK/BBnj52ELHutiC/iARkhBn2EZTAa+Iz7gjhIXlwk1CEDgzrY5iIDMREZZ4oe4qXriRBFYbkgvrJZPZkUE8CVWfhUs62b1f7iOt4a38I93Aymu4OVExiacn/TAU3qNyq9Buu9/Mkkak5PexXn1+OUquKnzsGRHJvz/+eXAjnyRAjbJ4EPnqvffFyBI0vGRR+L6VExC0M6f6TD/camXxxE+fhAWa7wyIQEa1tACHnd9nXf27FxWInrEfmagMuctIHlaHcmMfzcwJ+zRXj3cNxXo42AMclnbT5HS2pGNAqHpGJsBLjvGPEfKpqfJsppBI2yNkwkzlKrXLVIN2L/0r0XaR3eg3jeSnkza4XGYe1DKIbnhfiLFZPWRUdryMWADWw1nBWFwnf54YkAJ/QZoUtK1Sr0ySgpMS5Nhr+i/yxz+NTO9Eemx5gQFo4hvkM2w==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38350700002)(38100700002)(26005)(6916009)(316002)(186003)(52116002)(2906002)(6506007)(6666004)(66556008)(86362001)(7416002)(508600001)(66946007)(8676002)(8936002)(66476007)(5660300002)(6486002)(4326008)(4744005)(36916002)(6512007)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?UbvtdeY/WpI7IE69sOVw6UEfNF70GJW4dnXBu/iHpMIYsgZ0OAJz2FQNTf1+?=
 =?us-ascii?Q?Ru4fQ3g0T/TgD/819x8t7i7339YNEizfmv94rhlwOoT7Xu0X3aLk2XkimHvW?=
 =?us-ascii?Q?f9Lc4klBY5eJ1+h+gp1vsELef0t5NM/8NFPn+J80OEGlRMl1ACjxWJSFpq9m?=
 =?us-ascii?Q?28C/eV5eRPyUizccET58vd6jR6jHJsH2BgV1+7ERmJ0FAzR94ltDjrjVqQAw?=
 =?us-ascii?Q?iLu6Vzhb6n0XZe06opRi+A2GYGXlTgQ4QVAfAxHQcCU8TZqxhrNd5N1elAMT?=
 =?us-ascii?Q?oz2AqQREpFDUZuQkmXppAyclNqTDj1q8XwM3nithmNqDIKHtfDh6BXBl2P4i?=
 =?us-ascii?Q?96nT6qK56M+I7DoLF0TI+mGnCKp8CGHA+KJ4oa3NYkrvDbISAjCgNyfOyygQ?=
 =?us-ascii?Q?lUN5jAzKyN8DHzXhsG38Wz503ogU1IUzpY/t/ngSpdKnPvcx4gGFeSoZaBxy?=
 =?us-ascii?Q?14c8GApONY0RA3PX+4U5PBnZkEFpV2s3QK1O+LwZi3+l3oooKuiZcZrXpgwc?=
 =?us-ascii?Q?BgoPN+GCogcsK+hDCnPNliicbNBnGMS1/cXHmMo2te+LH2HDYcguSdYEl7jq?=
 =?us-ascii?Q?DINuBF+4N2a6Dy3Dhy0WV2u+bZXNCJi4+15zo6U744ljBLJrjmDU8WB5U1zK?=
 =?us-ascii?Q?4YMOQcQ19o0IP8kiOushhRkHkISqjfNGJcOYfzoo/sMNMTjnFw5L0vkRYXJe?=
 =?us-ascii?Q?vaEpQ6mDjzbmdh660Qo7v/rlIOt7RlZhNP2qfEqd8x4we6KtlcYP609iZkDW?=
 =?us-ascii?Q?54gWsCGGPZ35NzWZ1cII/oemqT1iwWUruuKf7y6eMppj3Fsv9SgUFzMx0UcD?=
 =?us-ascii?Q?0vhgX+deU1WetRzCH2mHfgPfBV5Kx87kUxyhRHTX7ZyLihGLNESJxcyGYO0p?=
 =?us-ascii?Q?UeLxnGf/iC+uTAIPFHclyD8jp7+tGqvWt0PyptEI/yFHN9z0Ldg6aRbRmaVC?=
 =?us-ascii?Q?PffbDi1/0F1IBTaR8CxfpAHJR5BUu7oPUUwL1qFU06F/ZrfTHDpd98/kMDpl?=
 =?us-ascii?Q?FsnXVpDsvKa3bWITIL3CQp6NszgaHGtshcy1uXQBQP55NGx2wKlrm7U0uQyb?=
 =?us-ascii?Q?akyb2mWSObChzNDNWua7ruo0MOGVRvWnOGYuQjY5zKCBCAW2LUssmPhoqHyE?=
 =?us-ascii?Q?PktZB0bUt+9Ffs/aDkMD7UHuv9bTVvO+XW2sA428ASfsT19L8hOwTsthBtSc?=
 =?us-ascii?Q?/hzBdNfVSSHf/bnCQwQhs5NH693YW+cGIj553WaWzgsytBn7F8BxOxoczloa?=
 =?us-ascii?Q?+WsnoJR338uaO2mJGRcLjSsgjvn0FoaXsyn+f8J3H+yTmeMdyTG5SFwJEd25?=
 =?us-ascii?Q?cTgzv0KBRqMKHCLSklj2zE0jCzgnYq8TdNbUMva5uLplmFImrbcGaoadlnnR?=
 =?us-ascii?Q?dAhwtzfKWNHI22QUH2/i907lloRx1w8doY7sahy2SKBQudgVJetaK+nXGKzz?=
 =?us-ascii?Q?UC7Xv6ftacJJfEfyDUYifmw/5IuRL+TqI3OviHY/jJPdMoFcyqr0AbMB88TA?=
 =?us-ascii?Q?7gA/rgTVv7cDVqDTWYPGDZ3OrnpYSq/CiuqI+opiLh7byOAXtnmhCldW9wz+?=
 =?us-ascii?Q?5z60/4KCkzGHdabh1/zB9SVo9ZbdlqJdsj/A89QRczyR1sU2dYYX+4mPks4J?=
 =?us-ascii?Q?sx3ggqr/u34vNYrMvtjepDnHb4iaMEMrMF2Q43wpVpRiQH0oc2Shhjj7RTMg?=
 =?us-ascii?Q?DMyWTVwsHHKlHQBaE7IosidvjTg0RgT8wcuD3HuXbgWbCLnLDZGwp94QJkKh?=
 =?us-ascii?Q?zCANJIQgaxWY4L7FiOz3415QyP3prOM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a45fa5a3-2b8c-4663-be6d-08da18439656
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:06:19.3144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5tkEIoZ4H14YUgKrlQd1Y9moaGyVjpl1sLoZnstWUDniQCbedG8LT5Gd1DY+Ny8/39s7sr5pKhBb9B5hbVtDgDdzDmpGJ/9F7To1TqLdYLg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2152
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070015
X-Proofpoint-ORIG-GUID: ACpnJmmUm1Uk0SAf9i9nz7kyk6fpQP0Y
X-Proofpoint-GUID: ACpnJmmUm1Uk0SAf9i9nz7kyk6fpQP0Y


Christoph,

> For block devices the target code implements UNMAP as calls to
> blkdev_issue_discard, which does not guarantee zeroing just because
> Write Zeroes is supported.
>
> Note that this does not affect the file backed path which uses
> fallocate to punch holes.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:07:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:07:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300245.511992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIUe-0005pP-4v; Thu, 07 Apr 2022 03:07:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300245.511992; Thu, 07 Apr 2022 03:07:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIUe-0005pG-1x; Thu, 07 Apr 2022 03:07:32 +0000
Received: by outflank-mailman (input) for mailman id 300245;
 Thu, 07 Apr 2022 03:07:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIUd-0005oU-CZ
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:07:31 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc25ddc6-b61f-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:07:30 +0200 (CEST)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2372POUT012451; 
 Thu, 7 Apr 2022 03:07:13 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6cwcja1v-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:07:13 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23736Qew029514; Thu, 7 Apr 2022 03:07:12 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f97wqsegs-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:07:12 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by CY4PR10MB1590.namprd10.prod.outlook.com (2603:10b6:903:2c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 03:07:10 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:07:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc25ddc6-b61f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=F3x6P1kenH1Hm7uyRz1muMBaUZJEydwA1QWe1BNT6dc=;
 b=cfJmdlT0b28dv1IZ57X77wNW/0fqQIlICfwO+w21wI/1c0lHpUBi2zuV+EXoHxuLCx9+
 gzqua7rNKLsJh19hOfS/0zBGvCfkCYy2lrweCkMd8JtuJNhLctuWbAoww6EZ2zply3JC
 ZIqbDi1nv88R8J2m5pMK46KWih6U/y6utEmvmiAxqETsgHdTNSMNSF/VAFFXPW5xmymY
 5RqSgSb60kNgdK+p1lDvCcexMmB0yW/JWqgG+vd6dul2009SoBlCouO+lunuW/I1DRXe
 dOiSjL78iwHW23gE+ZvYCuXRRyi57NDTPg+ynkS2WqJlrCVV/u5tO5CQddADUltB1K3M dg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XrCvlE1NBFTDUpegOdY5bGDTCwM0CCJGtKQtelIaqMpJ7L/nT0Hkc6aFsUcNugG9Vivl7PUD7CAlXVzVK4GL5Q7XkugvuRjZnJuICNnwHdS/0VrxpW1OA+Xv7SIk0GztXBIT8/fPge4xLXBV228hOo71QhAQnwqUC3U5/0pbFLs1bUVrmt5WIJUL5D/HLF3b7LLXy/iVp0rDOPEf6fw3BdmcoG+0GG/PJ2pu/8NEEHps2MJl3fOhwT2dBsEQ6CBh7fw7po9yq1WAz9Of96lC+hrn8jkLM5mojNH0C51Iy000yFb7EiSNlzf94ez3zRxtTsNllu5Sg1ZrPshQXIUNkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F3x6P1kenH1Hm7uyRz1muMBaUZJEydwA1QWe1BNT6dc=;
 b=iLS/RB2jzMUtJGoaERI3S9n4osy+zSxkMPBizCQNtbcjjVn3+vM/eHQKiSM4kY/o2l8l7ZMSUCfU+EsQvwtZeu7OFFt0twT1+qhhKMHp5oxA4BOkgfHl2wUa1wX+SSltp6NjC2kGn/eUGdKzEmCIe9U+DvUpBCt7FaXjpWuWwoPucI8HHji0BikNynM3y4ZsjgFLFqRgm80zYOxu/HXnG14EkjIM9uS6w2SYYkopRZiSX0yt7xBPg6x0HFdioSTK9NrBxYJyu+zvBCXCzy2HQ5QFx/IB9H1ZeXeGwN9Af/AhWvzxmTgH5UARs5ts8WdgypyEMjbG+6wC407c0+r7Nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=F3x6P1kenH1Hm7uyRz1muMBaUZJEydwA1QWe1BNT6dc=;
 b=N2cSI0L09BukAAC2ZOhx8qz0NNNe89edzYFU8Lh//FiCv7KyzXtkTUF06NH7q3cG/ftto95agMLQfKat2F8KX1qQeVJcG6DjvXQsplX2Xi3h+93pjoauE8hqRXxIIDcnc980ndgEcHjUtm/2hTkzz81u8UYXtss6nYLKbcgIdLw=
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-um@lists.infradead.org, linux-block@vger.kernel.org,
        drbd-dev@lists.linbit.com, nbd@other.debian.org,
        ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org,
        xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
        linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
        linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
        linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
        linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
        ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 02/27] target: pass a block_device to
 target_configure_unmap_from_queue
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1lewhk2wm.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-3-hch@lst.de>
Date: Wed, 06 Apr 2022 23:07:07 -0400
In-Reply-To: <20220406060516.409838-3-hch@lst.de> (Christoph Hellwig's message
	of "Wed, 6 Apr 2022 08:04:51 +0200")
Content-Type: text/plain
X-ClientProxiedBy: SN4PR0501CA0036.namprd05.prod.outlook.com
 (2603:10b6:803:40::49) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0159823a-59ea-43a5-79e8-08da1843b492
X-MS-TrafficTypeDiagnostic: CY4PR10MB1590:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR10MB15908E13CAB5A6BA15CA19858EE69@CY4PR10MB1590.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	PA2Z3zvnaginXNr0BRdbzRmx4+M6QabC9KKOk44bWlwv1FaywbY9U4dnphNSSK+v/7CcGP9sv89lLuxFchBSBrN6REJmV/ST7yYZCg2v0w3RdYrZCj7jqemUbzytCBhN6mRJZMTJA63mVdBaWPg3lmS5wtA18HWw5+kQMTN0C1rB3N+WbNN7WYjHIkuhxeGwkEhee2LAXUBtG40t3Tw0f9X1R1JebCAVWXvms0sQCJ3aK76BAW72/uw4c9Aveuj6fIDIJVa7b2BWAS+HjPxufBSdGP9hORIvYgJcOJ5161LkSyDMnvsfn5oEjoYLM8IVR+oRUU8v16Tw4rpgAhbczXdHXNfeIMvBC0hrEWtKNbHzrnnvRSGwlxsjinoXy9uAp1h+jeqtkYm1CQsWrwmDwmF7VK5IvwdjWHI1vTOeYAu2OZ0XPqivDhux2S57H5xKVHS/yYWohiQEINSbOuMWfYOCwKYt4omyU9tMD2sIOyEXuw1lIseDTeloFGqw66QuqvZmzzdWZtwjZGL5s46SEY+UWZm6fwfoYsp8DAw89XS+fMKOjC/jHZZMZgiqujuRzczDpLT9EZQjlI1eMvAiMa2psQsodwI8iZ5qSF9kXjjcBvmjrrNrVBqPgaF6cY2Jv8kRhp+rH7g9xKrYX1151xgocKc3xQjpfBM4a1Hr3jXqVThJpZR8CuCeDk4u9e+HKtBgpY1eW9JFbgJKLrGPzA==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(66476007)(7416002)(5660300002)(4326008)(66946007)(66556008)(8676002)(8936002)(6486002)(38350700002)(26005)(38100700002)(508600001)(186003)(316002)(6666004)(86362001)(2906002)(36916002)(558084003)(6506007)(52116002)(6512007)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?7jOSGYtXx9bA9WZieGCt/o3XE6/UbuWTzsPziP7YgPFtz5rxZj/YbslYIg3d?=
 =?us-ascii?Q?IfID32//vXGCsYbZ93N7wfpG2KUECicS+tuke8qmAFSJRZodMYV3tWLwqFUY?=
 =?us-ascii?Q?wWlanGPpN2/59tfDHEEIGuyAAyNMFWXbVir/PJ4+YRSpfa8rV/V1OZDhtyOB?=
 =?us-ascii?Q?+LddzHBmYUm8LOcJcBJD3WFSD0ZjU2BtERIjTFpoZusVNzeGa5OGgs54YbUC?=
 =?us-ascii?Q?aqJaWpI2w16X6FDC0X98k+0I/lNyxwNYtk2dcixdxFO7/3S403PFtlDgZkMh?=
 =?us-ascii?Q?AV9P5vJjQXRZTLHyygghsV/gmc3V3sxf9BPtS+9q4GBAyFHLE1liJ7hgve1R?=
 =?us-ascii?Q?yHYQD5ftoCrW5zhGK08+N0iBCStRpijKetnXcZ0dZ0e5vmVNl2HO0TY8UWO0?=
 =?us-ascii?Q?yxBK43BmxuVLOEeQxvEdEXf2ocA5NLUH9Sx1ndRD9DwBN7gGM4aP37pRuu5I?=
 =?us-ascii?Q?JtBBLLZVzRS7DsC1Iq6i2xAN/eIBCunuplqn4crvq7Q6OtrvHzAmknjKxL/L?=
 =?us-ascii?Q?mynJcV+cHBqiV/ItBSDHCYfG8dtK1mONjx85/pncIUyxDa0yAJ6t8KJgavUL?=
 =?us-ascii?Q?jsk9wqjJoj2Fu925tNkEpWP673qdG1V7oEA+WxeOnp/TeQBRWbYBHXM6bTw6?=
 =?us-ascii?Q?PoJ8EDlcOZ0Fn4gFcRnsp3P/R/2Tr1qNa8pC/2QDYuCjJaCXn08w2ERmni14?=
 =?us-ascii?Q?IDqFkst+HaZMKtCc5ZKzvHV80pshcOIywm5y2ad9Nfbew48PgZSi8Uo5ZdZ0?=
 =?us-ascii?Q?jee5l2757c201u4lUc1/7xU0z/jG8MEMRpzqG6ugyOmaJ7TJj7HGIqaExbe5?=
 =?us-ascii?Q?2YMmQ2oEeBtspequlBRjY3HTiljM4vKgzgu84M+vFedSMQ+jq4ShumsFnPIM?=
 =?us-ascii?Q?GdYdS9GWwRhCce7HPlrg3ZSHNfvbO9/1bnOQD0FYxXD7QkgBayEiKxWYrej/?=
 =?us-ascii?Q?TwDGp9anU/x4IEY8XrtyUGOXTkxBRTpXwYOCLBu7jOgmVBi+k6suYMxP64hz?=
 =?us-ascii?Q?hXRPRbAEmg87imQn4FDEokjeIX58Qz1feQt06RPF9Sn84dnKEfPAYJV8IRys?=
 =?us-ascii?Q?znf/M26t5kZMDaBZ3x7VHmSmli0jsmtJJnPL7mvF8Mf3WkVScrkWW5i5ptrO?=
 =?us-ascii?Q?2Cl9cc1gPh7lPUwXnoc+NEphMM7+oprjdOgQcI24ZOUbuHwbX1HCPbSyoy6C?=
 =?us-ascii?Q?3IyUrtdTqIchGflbVd0Xww0f6+rzBc0rF9GpbFlnLwq/BX2X7WsGrxDd5XYq?=
 =?us-ascii?Q?ygQgR5ruLhmz+wpsasTpt64MQ0Ic4UgIzkIxyszl9TxR9FfxGoFSXrQUVHLL?=
 =?us-ascii?Q?RKJntEzbhVP/6h/R8pROoYJUkn+bmNbgh9K137PFH2mWYuqI8pZq5KzX/5+O?=
 =?us-ascii?Q?hYv4LhXz6EpYWMiifAreccy8vZvNK5wRiT63dnJhzMmnPBwAMjGwmlwOSr1Y?=
 =?us-ascii?Q?avctRXJWD23qeM5F//b36pFJZH6tMYKrDHT3AdfU0nPnL5xhjhPaukeGfoVT?=
 =?us-ascii?Q?x1vc/7/NVk2g658sDHE94Iwy5h6aa0mLPMaTL66FG+AoorGpG7MuthEbhK6t?=
 =?us-ascii?Q?nj9WCOSCYfuVTHwjwWolZsS9zxyBzzdPzsz7G9Pr0HzjO6d0DHxt57zsYTOy?=
 =?us-ascii?Q?sZqifPtp8ZsTptLFHA2ho5qUK8qmJR098HdKqXKdNkRdK4kFeRwg2fmUpO1H?=
 =?us-ascii?Q?WX/OL3eo90YkrbLdD/iCVKGkjgeZ8c14I2N7/ckBwzeFCgrrHxuG0DZkkl22?=
 =?us-ascii?Q?PhN/NP/Qw+ifIeAZLtiYz5N+Dygw+k0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0159823a-59ea-43a5-79e8-08da1843b492
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:07:09.9126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kG9UjttGiRw3JVf+jwyI08QGAOc5aSrKx67j79jMLLO3Ff/ZV9VhprSYJVdNJOr8vqf7ZUAqbYsGc8mjgfl0GBN0niA5yaYJtcy5AtXhsag=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1590
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 mlxscore=0 mlxlogscore=849 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070016
X-Proofpoint-ORIG-GUID: YVpZ40QVgdXlllEflIKiZiI8VDmJlUra
X-Proofpoint-GUID: YVpZ40QVgdXlllEflIKiZiI8VDmJlUra


Christoph,

> The target code is a consumer of the block layer and should generally
> work on struct block_device.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:15:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:15:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300253.512003 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIce-0007jJ-0U; Thu, 07 Apr 2022 03:15:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300253.512003; Thu, 07 Apr 2022 03:15:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIcd-0007jC-Ti; Thu, 07 Apr 2022 03:15:47 +0000
Received: by outflank-mailman (input) for mailman id 300253;
 Thu, 07 Apr 2022 03:15:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIcc-0007j6-T3
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:15:46 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 032baca0-b621-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:15:45 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2372avAj024455; 
 Thu, 7 Apr 2022 03:15:27 GMT
Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta02.appoci.oracle.com [147.154.114.232])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6f1tarf1-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:15:26 +0000
Received: from pps.filterd
 (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23735a9N024750; Thu, 7 Apr 2022 03:15:26 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97tstrnt-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:15:26 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by MWHPR10MB1711.namprd10.prod.outlook.com (2603:10b6:301:a::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 03:15:23 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:15:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 032baca0-b621-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=/31Aq/ogkEv3D7v1WrDP1er8ISBaDWd1x7R1AJi/49Y=;
 b=fkJ2mbsXZbZ0/3/iFv1zlTG9gEFJm0maqWl06jukCCkr2AnJ0aM0Ey5INnLidVbzeSht
 eXDlf9+L3fzcP+hS32NxnQonQ6Mq2pS2JyyXWG4rU6upIYmgHesXCCyeBw4UIrvQAUqh
 mjpGELWXKLQpFVTUxeLMLabmeSf7uXpGtjGRpVnQBl/dx4ezIQrlpX3lX72A7GUmgtIJ
 8aX1qOjWiZ1wh4s1WZyMbpZvxwvqiqYSnj9NSpDnc0boGLa8RowHe6IR9MUHbhTq90Ev
 x6nQ8TFJ/4GM/IhE5D91uWWUoXJ9KKPTEovSaX75FkTKjv7uVI6igk5wKZ673/zU4di9 qQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z4+xx59Hv1djusoKEVk4AgRRfjJouSAPkkiq8XHi2smufb9cVyJZjOskKFFza+OENkntQg4r38siTa/H0Oqp8pr9ZApM1ccNxocR9MPhtx1gtIfeD+ryF3cmi+wYIYRupz/AzPspopV8l8BG7EtCwZqDyf7KTLSBjmki9vTE7phT0sQXYsYGoKihk2QgRfFzwoBfUUGN/0g44JDaaO7utgssXMCtiGyfCjwefbFdPhZQ4hwZbubNrYv38j6dKoOM+8uoPM9q+p7w6ZRk4tmM8C3AJ0D6eh+LlAZ7M+3rMSXnmKbVwhcd1aaTPTyZ170M1anUuHWwmIpZn7289qkjow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/31Aq/ogkEv3D7v1WrDP1er8ISBaDWd1x7R1AJi/49Y=;
 b=Q9az3qJnJ/6VFGlF5T8ZpnK7+v2+1vmdjEqp7g2RCmkKhTUcbB758KTxmLPHw3j7ctltdA23sLSnT7Ss970Cmuo1kz/LrzQ6yfwzhrkD/bpuoKi4Tq6CUHAYvHwx5WYUp2dpbSfA/ucJp7K1aDi8tqHOFdGVCKIAVskfwSH4znhcEQ2HinXrGBPG53tj4e5nearyqwccWDagDoT2eY9gCwFcYoH7AdbggSuvQSwaWZdlvuK1kjCqQ5FS/xH7y7WeLHv7fSZjRR6hU6lHQiywybDPEvgRNLFDqk4FwBcLY+VnCIzL7Naj1GfZOJVZAuPamPRsp9ADEeZ6p8jMm5ckIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/31Aq/ogkEv3D7v1WrDP1er8ISBaDWd1x7R1AJi/49Y=;
 b=i+KpI7mYp8/WZWk6IU6ucB70P75atPwgoZ8Tk6F2tAKFbOihQA4Qr/xa8Yrmw9HHrWWp6CVvAmgjgO7JPGKHmTQWntgTaH2nN0U8vv37fssQi5E+G2T6k11o6QLPfksx0s8mG1BX3krn37m8TMB828FvYDxRGffASS1NgAMRbAU=
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, jfs-discussion@lists.sourceforge.net,
        linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
        linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
        linux-btrfs@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 14/27] block: add a
 bdev_max_zone_append_sectors helper
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1a6cxk2io.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-15-hch@lst.de>
Date: Wed, 06 Apr 2022 23:15:21 -0400
In-Reply-To: <20220406060516.409838-15-hch@lst.de> (Christoph Hellwig's
	message of "Wed, 6 Apr 2022 08:05:03 +0200")
Content-Type: text/plain
X-ClientProxiedBy: BYAPR07CA0057.namprd07.prod.outlook.com
 (2603:10b6:a03:60::34) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4633d708-a1a2-4a74-c466-08da1844dafa
X-MS-TrafficTypeDiagnostic: MWHPR10MB1711:EE_
X-Microsoft-Antispam-PRVS: 
	<MWHPR10MB1711503F5A0BB2B0A400CFDE8EE69@MWHPR10MB1711.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	Y4FiugFGeFbmb8PnjvBwaJ3cJzRDELCyJpKHCvmnkE9UifUQvtFOE9jpuffFklqEBxT2nOLbgIbcGsKuaPc03l+WeG7LZT12eCdWPYC/N3H4m1it5zxnChG55xziGjbUu3O0x6wjyxuIqifeGbOKFt8iZ31k+ed0BTPxJJ3o0mqTjAboiQTt6p2C9ZAvz9EzdfuMZHfyU5ePJV1sll71j155LElen4hzdJ2TWJVR8Ia4+ZmwhycQyRgLt1qqyS9qyB/9tcYTCyCKT4a8by00nBHziSInPwv6+UyWpG1pEnomwxpPOphlOzBCsh2jB/LFojDh8aR5hy3kuxHDC6/KAIYtWsr3wyaeukYTgK2pLlWZ5NWVJq+ZhznPcnzeaFnNtK5N4SNt3EN+sQPw/ap3j0RLnc14ouWvPPIoMjAnKZRFF8m8tp8tquk43Nq3Ei+n8+fnY1a//u3BeIXFiaHJBXcnzEOxgzM4UmITtMuaUu2WgiwIECluy6IMnrYVr7722GhrOpZxvyi3QM7ecgw6N3/wDNPUVkEbAelL/M4ah73PM/LrSmkfIY4ntwoYSvc8+K49oqRTTxXNehZYvA3B8wRq6mZDT6lcz7azc3QvA92khUlSvEgX15iJA622ZnzptQWWc+CcFkxcFKxfMNLRjH7OlaxkkBKvn5+sRBu4k0wSQxiOf98HSEkQfXYGGwA5rH66Ovk1Nw7Ha9epocawZg==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(316002)(66946007)(66476007)(66556008)(8676002)(4326008)(38100700002)(38350700002)(86362001)(83380400001)(6512007)(558084003)(6916009)(186003)(508600001)(7416002)(2906002)(36916002)(8936002)(6486002)(26005)(5660300002)(52116002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?SXPUbwvAbIMrgeIGcXihtK7F/d/QeGf+2AY8X2keMtgxdICznYLcl/OTbR81?=
 =?us-ascii?Q?p34XhSf8oG1UMVRfKGeKqPQnahsKRaXvQKrtaRO9NptcM7/rnsdY756L18Af?=
 =?us-ascii?Q?I4uWb/uRnVH5TPp1C+yvwZw3jD+1Zmc5U3Xb+899RKKBTU6ffzqyLkaZiC8p?=
 =?us-ascii?Q?L7ft/gTgGuB5GRjQJdoZfBB6yy6u7B6g+iJLxmu9qsfE8iJzTLf6uyBPipzX?=
 =?us-ascii?Q?o6w0MDPcADUEQ9XrfvgNEwx544vxkCFk6fQhrzB+Si0qek8tYO4fLVcymyxM?=
 =?us-ascii?Q?bNouJJfhR8lG2Iu+7nbURE1U6KY2i09Emf6Tijrdhhtctwv8jbaU5eY/RJTS?=
 =?us-ascii?Q?+2H7eoez+NxaLnVtHol/9zz+JcmU9euyaXdF2nJUoDz7Z7w9h5+js9gmatqB?=
 =?us-ascii?Q?5tAD7/tEVC97V/7p0xpyg7viihtA3EP/CkdVem1F2UIVnHC3cn0ClgTDqh0z?=
 =?us-ascii?Q?UQE7rI+D15jyEngv9KbANg8cY/o3Xx7VvUMPVUeIA7PklPk/V82jbrYHqzBf?=
 =?us-ascii?Q?GNGTfD/V8DtpBPU1w5aodu4n51qaRyDn/7Ukz34HMfgym4dUafZt4ywk6mFY?=
 =?us-ascii?Q?7cF8qmbMNN0/Jym6fUxdFyZmj1ZPhE3KpRhQMlPX1VRtjojCNLuKWW8WMsU3?=
 =?us-ascii?Q?iEkv5gUfoHxTfJD67bDAUaUjOfSp49qIV5Hn0GS8TBHc3BaCA88wMgUANDg2?=
 =?us-ascii?Q?s0rKvytZWeYG5hRgfifaj75083wDQMfHCNG0VHNY5VdTkyrPo5IPf9A3nsfW?=
 =?us-ascii?Q?hBhof1VyzhZHUdFrx/hugS2+ClvX73CVxsnEUCN4u8DVbyZU1UpIEZK6Mti/?=
 =?us-ascii?Q?AETQyMtKhJ+0MiXh6VxBOoOQBrzb1ybyC7R6rFpyDUIVIMLFLVoVUes81XgI?=
 =?us-ascii?Q?7rlqF6J1H5chI/8ELw6GDZWmocQgYYg2QYwM3YfmKsz/jFSLSRasmdvXNVLU?=
 =?us-ascii?Q?3FD6nWJKeH1IXX/iyr2kavSGBFEpz3Z4WUE9btFEILS9Hl4qn2f0na9Qu4/B?=
 =?us-ascii?Q?fMMp6p5Zg5ANIMszgwzUMLtqEZGDtzA8YV1YGoNgDEePOCcq+p/QtQxIPKDL?=
 =?us-ascii?Q?c0W9INPhMFkk6FbxNJbcFlobGzsNMu7zhBAaivFoTCNX8WFTkidYXEzftn4i?=
 =?us-ascii?Q?cRQ70BeSLtZ2OLz/IFX/iPOsDCcCWw1T0WqACQnEd3bww9paMJA51fwRueYq?=
 =?us-ascii?Q?rU28YasdX08mTU1KFEA9KpJMXvgSRoZRvzzKpAvn+YFSd8zCQc/oN1U2freS?=
 =?us-ascii?Q?DA49MsFJCVYZFqYLxELZjiGLc5wf/Bx2nUZx3xlhOk+DyyjIFGXBJpGe2ZLo?=
 =?us-ascii?Q?VNDEOX4vG5OCkMuDfKHZauJ0UboyNot7unO9/27jzD3VDm8LWyWX0p3jJm2J?=
 =?us-ascii?Q?56uhP4r/Klu2KnNkI/81BCBJTM/yRwFoXGtD4nsBG7T+eVr8NXw3wu5BUmM9?=
 =?us-ascii?Q?d6THTGmAzLcwotonFFeAfWz85YW6pGjxIeCfoukgmSTXwFcLEyZg1C+swQYR?=
 =?us-ascii?Q?Cfp0i+2IgoLZ2br0IcUg66iWT4+SM1+Yudaffy0Hvt4jFGjR+lmEZA2wmhky?=
 =?us-ascii?Q?U/WsRCEYDnennvJYlkhMI9kMLN0czh6LJuibMaTFJoYpA107laQB3qSnx/9+?=
 =?us-ascii?Q?9K3lqVcI6jPcTan3jrbF7/C6kWuesos1BUq6lM7hfRwgrsoYQZ4P+Vopc04o?=
 =?us-ascii?Q?UisfB73KFvMMdCy44bEsH3TcS28MrKL3ZSLkNzwl7v9hQCdr5l38ANRpqxVv?=
 =?us-ascii?Q?vMoccR7eYgE3WBSKmhYvKiQTN0VV59k=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4633d708-a1a2-4a74-c466-08da1844dafa
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:15:23.8630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4rE+Cty+MdB1lsa3xpRQOVZo5AIqezB8UTRn4pi2YZV5q5rlU8dbrHhIEVkj8tZ61PJI35Q7kugW5WJ/ugaefQRi6DJb1C4qHnVNCBMTQUE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1711
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=925 malwarescore=0
 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070016
X-Proofpoint-ORIG-GUID: hg0fgzSyHHjuLAMFNKOZE-KrKC2qf3WF
X-Proofpoint-GUID: hg0fgzSyHHjuLAMFNKOZE-KrKC2qf3WF


Christoph,

> Add a helper to check the max supported sectors for zone append based
> on the block_device instead of having to poke into the block layer
> internal request_queue.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:17:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:17:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300257.512014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIeI-0008Ml-J1; Thu, 07 Apr 2022 03:17:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300257.512014; Thu, 07 Apr 2022 03:17:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIeI-0008Me-Fq; Thu, 07 Apr 2022 03:17:30 +0000
Received: by outflank-mailman (input) for mailman id 300257;
 Thu, 07 Apr 2022 03:17:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIeH-0008MW-9C
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:17:29 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4003f981-b621-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:17:27 +0200 (CEST)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236LdvDA006381; 
 Thu, 7 Apr 2022 03:17:12 GMT
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d31jpev-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:17:12 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373Gg9N035300; Thu, 7 Apr 2022 03:17:11 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2170.outbound.protection.outlook.com [104.47.56.170])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97y72k7n-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:17:11 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB4408.namprd10.prod.outlook.com (2603:10b6:510:39::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:17:09 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:17:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4003f981-b621-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=tUJnubd8gZXBDmR5y0HccTdVKl0H84DH174jOcutIYM=;
 b=MpF7s5DZ8ufwzPew/71u+lD2uIs/gd7p212hZkW2MMzH9Z0VU6qO9Yxhu3OWemD0QKv0
 DNm3uvLZOAswhBVHwNIffo5S76DiL2YSWSi69llniRSTVN48ndZYUgtccIGRq0tpCN9D
 YAUuhQw3Zyz7e5dWGbFKKQ2IT2Gi08Fwfu6M2zWCBOcBEwHfAk+9lqS+pi0Q1z5F2lYi
 DsmL3LuIpZTZ6KsFTf2zoW3s3QGDy2wbNZncPR6SR/sPawh4OVJ+EaogbNB0dos6TW/9
 fmnGmjkr8eQPdgXEKjuNCKY2pRLtk0iuwvhrKhC2sgTK8fVzZ6G4l8UcH1Aq3wCl2L1S Xg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VeF5xcv0+uWHQOGX5EkoqZCDOfcW0a9an7AnmvIB13oqeIa2mQqPplsqvgq2vqu55wkG2WNopqHNJsTCF5tz3EXQKwXjSqF2jktNdlSAq4NVS6KYTpjW19j8PBDBe6R/wM1HxpT+AI5yWLcnRptOD3xHxmlr8V+jVDGDKEPUrZxYIb5la0Oj7VDHu4e6loKskelaRf85zRv2Ve0pkiMcTwoZclKiZvSeRVBZspkQiGCukBnNtB473Wk18OdjvwppYaXitLSoVuNvxUg4GTsrb/1wMQ1NEciiEydme5U4P3vW0+hlAW0FIjMbPvoO9uiysNsTpHu8HRzMu0MDzgIQsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tUJnubd8gZXBDmR5y0HccTdVKl0H84DH174jOcutIYM=;
 b=LW/XqSWzsB1zP522FEsz+eluDqpzplUSNGCGBaKU/9/bLSdhbphOAfiwLXvcorY4GtuWkqQPS7Ca96P7WnC742+QuVc4VyoN7OqrNxAlzcI/1DcRstXGJwSy6yh4T++o57Q2wKZT2b0VOzxA8hgCUAoHrGwPpPBswdhLWcwY7JGANEvGdRJLPzSyGyfVuB4GW87w+JUpuCgv09F/kHYBqNMK0eG5OF0oWs9/+Bw56E+XibDT+D3Q26sgK2uDcZOlROeM0KsG8HsJJyxIs7+mq8s/pfFRZGjGbtEXJ5u/oM3vCa2vL7VSCL+OaVtS9iE2NSIKFJW97gsGPrKUUtaajQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tUJnubd8gZXBDmR5y0HccTdVKl0H84DH174jOcutIYM=;
 b=InAlEa7smslEM3yAsuBysF1ZefoXvPonEpC35nynzWKEvSwPa6RYOiS3fv3lCNV/vc/VaXOpBUUUNZzV0khNjo/1ybIvFYUgaQ8E9Rw1jwVnYcOkE7mTOSYml2Gbyr/mjKcXy724kG8i9E1OjoTLUmMPTAhImWgBcnTlZ1gZLtE=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 11/27] block: add a bdev_write_cache helper
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1y20hinvl.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-12-hch@lst.de>
Date: Wed, 06 Apr 2022 23:17:07 -0400
In-Reply-To: <20220406060516.409838-12-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:00 +0200")
Content-Type: text/plain
X-ClientProxiedBy: SJ0PR13CA0051.namprd13.prod.outlook.com
 (2603:10b6:a03:2c2::26) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e6756038-ebba-420f-2828-08da18451a11
X-MS-TrafficTypeDiagnostic: PH0PR10MB4408:EE_
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB44083B803B46374C4EBE89248EE69@PH0PR10MB4408.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	o4fWyFlXKHFB7B6skBHonvbP60P0LOo3KZR1Jd2wstrj0CIqWehVwNPOY5neM+iwAPYSGfEvLzAie6KPA/3mpPkq79lg3NXMC/LuNwGlFqOp15ot7vrmCxByl/1t+aKpo4lLnVD+kyROJ1/GcXhcwinrRFLxf2ItJpdD3Uu1yPKSStlFrXW8uc4b4C7wB+w58M7Pji71nPoBDt1ehfBdzuE72upxIxvtopqcKZuqyomvbdXzK16SuSsrbR7qCGrbS8HByMTW7Wzuvh+W1i7LKcbhBfbCgQ9zwFu+VEtnSyhsxe/9uv6cJ9GJYDa4rEqIDm//HO0LpydImWiH7LETpwg64iIh5r3k2MONUqHxjPCjRlRcn0MmWicWmmfSf5tyf/NP9HSy1Hub0Ci36o3SAs0ibhjdsvyKxzOHTo87c9+/7+ZrUrc92PFPS6xd1TlSHr+ZnoT0mvzxCBenUQHbqRWNyqmnsB7bw14nYgMqwVIHb0485grLpf3jCjHD71srGcyVMJeKDG+M4SGcZ5cpLPhNHJM/AKoHf2Wq8PFXGN/ltJkcra5yG9YZAhV6GJc6E8LQqF8l64SnIZba9S6p3jnasjfjRTEjqKWIm7oRJbVgf7nIYATYkeEY4aiO8UchfJr5ho2HDnGILwcBvFnuyZyILJA/9NZzjB8YDGXQT3UvWKo3Q3dnE+7Dy0vBCQQYlCNWTzvZQt5a38WH0dogGA==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6512007)(26005)(6506007)(36916002)(52116002)(7416002)(83380400001)(186003)(5660300002)(2906002)(8936002)(54906003)(316002)(66946007)(38350700002)(38100700002)(6486002)(6862004)(66556008)(4326008)(8676002)(66476007)(86362001)(558084003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?WJ8omMkvGyKUxr7EpW3QB6yFZeq0RL+EI3/W7yvXNSWPHHqAr2jiv6smvSYk?=
 =?us-ascii?Q?v+ahBK6tVj2be12TB2ADpvceCFtl0RytbOgef0utOVNZ8s4jIXk+B5voAtAY?=
 =?us-ascii?Q?9QLViRoFlrZHWN4erZJUveaf7vkiU/H9snNjtjmaZmHupEgF23Z0QeFE/m6T?=
 =?us-ascii?Q?0kafvg72fVpElVlyH2elKY1QANjgfZJ0JnZop/AjDo5zX8rOzwjG3gRBDlsu?=
 =?us-ascii?Q?AUK97JmubqaHOlvzy7BUILlrr4n4VSkKmdXPYNifr3ugmZ2V651F99jXam9W?=
 =?us-ascii?Q?VhbVwwMo0iC8Odd+UA0TUm+SkRAU0Q7D7XFNU8YJ+ndiRXt655mV4YjMTy+K?=
 =?us-ascii?Q?oYR8Ck6ChcmEfdbEztfXO3GXP1I4/emUlwA0rv+hq3h2Y2U1KP6bC7FNExqW?=
 =?us-ascii?Q?St+1EcCgUxNoEE0Z0hWGuAjxyjCba7qW+QtHQ4Ndk6HrFmfwlJGFPfpTMDuO?=
 =?us-ascii?Q?bHiuyJqznFxdoGXxHGcCU3FxuaTwRBh9X9xM1BM/z3HPjL6msAYbcurEGoL0?=
 =?us-ascii?Q?G3bt/W+wk2OvgT/9mpfAZnk9ymMbDYn3EW9hxDdHyvHekCgeSSmt5D9cL+42?=
 =?us-ascii?Q?dcBFpqg4ymFcHGA+SOI+bsCoXtBCj5IN0ucCvGl98aOwPljZxQ7A/c80LGoQ?=
 =?us-ascii?Q?kVKT+RHh7r69ZHNwGLVOV9hz4oaB5HbyOKo42+DwtGhlJjcWsHyOFnW5kOos?=
 =?us-ascii?Q?djiN5osR9CtRg7gAetkyeHF4eTIRm+BunbeK/VpZ14vhJVGafNrWwJPvOUfv?=
 =?us-ascii?Q?SxwuxIXgynFU1WlFRhnVuB19X5CZ3mFmQ0sE4kTtNdnXxSWUDVBr4GHcV+U3?=
 =?us-ascii?Q?hxNW725v+IE3rPrbIwUtw3TZd4BwxE2PtlTbIZNDZtlGsqjYWB0mZPGnaqLp?=
 =?us-ascii?Q?/gMwyza0cTkwn520zEXthjOu2fO7z9gKNCbLwDkqbw3yEBbAFIQEXDdTFEZU?=
 =?us-ascii?Q?I8xNB3zfwTfznZCT71owN6C3ipomf2Rv759MXwsrLXw3k1yaL77RC35A76Tz?=
 =?us-ascii?Q?cQ8deDQ/bjKx7bFjayfZpLzJ7AJl4Tzyuz+24oYAMnhlADAv+5XzsAceiNco?=
 =?us-ascii?Q?CcRMfie/KRcE6RSSF0hmoFYbv4NfiOHhGOcqTS2dU2yz3CSSGavAFGZDkg3a?=
 =?us-ascii?Q?YVCgfB7Y95TV6VvUD3FbA3TJ+eMlkyggVAguMS+ZMtzBRXENbXOoU7zt5k+U?=
 =?us-ascii?Q?hQeNS5FQOBxFrLPBjR1r8DIyd6/zEdG7aGOr+xQwbW/ww7qxMyGn9NIxvm/u?=
 =?us-ascii?Q?lo3qY3aFVKOEvJoMVXmjOM3dZNH30RrGEAmjq90gweDiL4vMaT1VycnaV+ox?=
 =?us-ascii?Q?ed0ykHaJMXPPLVfm2u4OMuEkPNDQuL5oS9YKJv06q5XdLZVJUCpH7Oq+br5s?=
 =?us-ascii?Q?ELoPrlPws6LndL+1aalVLUoWKSKQ/2iB0cX1OssFj0ou6/IuzPjNZORxEUHp?=
 =?us-ascii?Q?pyF35AjBS1TFi1KbA8ppMN8h4uADjq+g9xDq5Q10CcaYIiE+q9sYvuikWAJJ?=
 =?us-ascii?Q?x59r9C4140vhZ3vKt6XwJUQS0JjWFNGtkG/1WSQNbl3AdWiKeoHGRFQAUap+?=
 =?us-ascii?Q?UAgmp/Stvw+Y+uT2WJZqnfEU2S9BHBamHrrWWDr3tzfG3PYqw3hGWo8n7nS/?=
 =?us-ascii?Q?Ws1Jc4KdO9MFV7RI65KH9R+lo5O9QAMgYqq9cYZZEzP+Jfi2N96x0OHzDAnC?=
 =?us-ascii?Q?NM33+Eq44AMi2OY/RWRuI7Ae9xlvWiMArrbnBON1pZRot+CuXvtScq9g43Vm?=
 =?us-ascii?Q?oKY0YhZXtFjsthdcIZ4Pm3pz6Kp7tf0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6756038-ebba-420f-2828-08da18451a11
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:17:09.7050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vdn52TmNEFKJmHV6h3SFAVHVwIz+ZDkKqUguEUXGoRfnJF6GC3nWc0xMQF1itEcnBnB1dvzxdmeKSxJoWvPlnPk4GBP89IYF14zOzWDQNsw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4408
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=979 spamscore=0
 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070017
X-Proofpoint-GUID: etJQXC1BdPvaG3xYzpqZdzv4Yvr78Bbk
X-Proofpoint-ORIG-GUID: etJQXC1BdPvaG3xYzpqZdzv4Yvr78Bbk


Christoph,

> Add a helper to check the write cache flag based on the block_device
> instead of having to poke into the block layer internal request_queue.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:18:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:18:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300261.512025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIes-0000dZ-UK; Thu, 07 Apr 2022 03:18:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300261.512025; Thu, 07 Apr 2022 03:18:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIes-0000dS-Pc; Thu, 07 Apr 2022 03:18:06 +0000
Received: by outflank-mailman (input) for mailman id 300261;
 Thu, 07 Apr 2022 03:18:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIer-0008MW-Aa
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:18:05 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 55d879b6-b621-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:18:04 +0200 (CEST)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 237165Gk014690; 
 Thu, 7 Apr 2022 03:17:48 GMT
Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta02.appoci.oracle.com [147.154.114.232])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6ec9tcwa-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:17:47 +0000
Received: from pps.filterd
 (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373Famr004015; Thu, 7 Apr 2022 03:17:47 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2177.outbound.protection.outlook.com [104.47.56.177])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97tststf-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:17:47 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB4408.namprd10.prod.outlook.com (2603:10b6:510:39::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:17:45 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:17:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55d879b6-b621-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=hejc02oDRtTMionT7uhL/jPXdYrz1VtvS0qdI7z+BvU=;
 b=HLmzvxJ3wBc8WfhU5whUJ9v/GbVRrJ1KEOYPwaACIASEc7I/4zkLyK82k7nAs5rpDsJB
 q6kd2X7hclSLT04HVeb/WeLH2EsNGJd5G1GaszXPowYZa57aoRVd6nYMRWFrHgcX+Oy3
 6s/UgHEPW8hd/T79ae2hPskB2XTA2N8/zV4yRDCZX0UN5RQ7z/QCF1YjCTOlLujGF9OP
 NldM1Ujfxh6HZi3u2SA90HsqctoR9NphIJmfbD1hLEEnxiGlVZcyhq+ev0+0tLfbBoHQ
 h6tE6oJm4ao9s23m5uuzHuCA/E+zRrIL1U2WQVZa/0qy6WCMsIBA592BxXV2ow2u9cqh Kw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KI/iuI4AZyGCIJ3iTtiQ+6hHZpjJpANjEYGCPKFLXznA537x/XPG9Q9RnW46l3aeJNa4Mg52N/oUNr1Ki+9oYCksZmLFkpHbdQYJhKHr6j7oBvPuPrdsQINyIijKjPsDYi3F3xsp+HWh8fmchisN1j6B9y/MH7ONhrL5pi9UPYaR6zliDLWRl3gsHdGiRE6OxhSDHwtOXT3LFWifftAomnWbh9j0b9IedeNaMswcwxjKf6DdrjB95d7h0+nyXSJbXyJGy01icykPpp0zVn5Q1VZMMf7O+bLtGMuX9q5TnXdpJcXISNeDaCXoBya6zrSikQCJZ5WdKbGhNrtTvDJg3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hejc02oDRtTMionT7uhL/jPXdYrz1VtvS0qdI7z+BvU=;
 b=R7alCdtWd7y52qSpiyx0oPJhUH7uWIn25ojmVDUWz8xFovlazafyOQoS5XZK3cclh1WKr8axazJS1blcVVI5PFuulsZpT3EkX45nziu8hF9hpAxkDudvv9g4tAFgSITwSSHGF38qkPabtzLv/vyUFTmQxzEYmes2XjWBV9bv3MfDv4lhQaZvc1iaZzL2dX9226t6ZPTOQqjhIyIh8jIN+QZDEg5jlpgfaaSXs6LvuNhqfVSa6LUdg5fAw2sroS1ApON0Qx+WHskIAuY9H7uXd3pMqfjdJWjKpsiv+iyAEtwN11LIlvvtq2Wh8th5Eepo1sWeaCF1KDBpJ7GprA0eZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hejc02oDRtTMionT7uhL/jPXdYrz1VtvS0qdI7z+BvU=;
 b=uDTjU1wIwZaXEPamdduWjBG4hkO8iR6ZKhOZZvh798i7eCtoPpxw8Z1bGFtcrtLpimT1c/MdAECj6woyKfdvbhiavv/AIoK9NW8B2D3t+42MFH4Nj8vLV/CzJu9kgiU/6wCC9AZg13DUxlcKBhHFMSj5zu2uPaBM/3nOsSAYWEw=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 12/27] block: add a bdev_fua helper
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sfqpinuh.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-13-hch@lst.de>
Date: Wed, 06 Apr 2022 23:17:43 -0400
In-Reply-To: <20220406060516.409838-13-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:01 +0200")
Content-Type: text/plain
X-ClientProxiedBy: SA9PR13CA0129.namprd13.prod.outlook.com
 (2603:10b6:806:27::14) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4d6f5c4f-09ce-4dca-6516-08da18452f3c
X-MS-TrafficTypeDiagnostic: PH0PR10MB4408:EE_
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB4408F5BE300B85FD77766A158EE69@PH0PR10MB4408.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	QymSv9kMr0E9rJMwIJ8INrKljArbWusrbyf7l9t4lmaxc1FRl+w1EfUM2Jfud/kNMfQLZSvqHiSvaDiIDZg9gLyzgebXWi1+J65UVejET0aJlAMILKRCl+o9FiIuxHQHfQg7ci07KSlskXWOPg0Agq+UgLC7VJQXm3/Rxmh84rXhrV9d0l1ehFFl/TlpmZGRdYFQD8/0WK8oMaVpZ3qpQcE96fbI5rJKMOFTv0UsvVFEe7QS7640dcZ/iW1acCopHPfgH/pZ/El2lWGEpocpAT4cq/9KM9EF40Y06lIlHU//gelZs7sc4aUFxMdQLnPCCDi0EGlFyL3TJbK+SLqX4Hm8Cb9mkoRirqZm71yKGicbPVGs2vNWqRygXn2y0w+V3BZk6Dyw0H7A86prrnnfGOjrzDpMunSh6y5pHAftUb+8icS0FSu2HdgXJpjsXqjxD74HZe2Cg0yZ9bWUK2h/pU05tKhx+EcPgMEZKn3JfP6JgCL1z4F8Mqqt67cmNNrd8olDc4JgCqIfQ4LzyfxuNaNvVC8RTMRegLOzsojHJ1EnC4xeBfZv5ONcjvqiG695lo8GUdSKvaoOnw15D5CgyY0ItPi32muuJTc1urnldMoqDln5l5GXorNEx2ZE4ml+MxNn1h6KHa80SFSp6/batgoxoFbs/O8ISJB45Jztujfb3vvZKjAO7MAGRLiagpwlsAcAVD11x0iKvR1JjdQCCQ==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6512007)(26005)(6506007)(36916002)(52116002)(7416002)(83380400001)(186003)(5660300002)(2906002)(8936002)(54906003)(316002)(66946007)(38350700002)(38100700002)(6486002)(6862004)(66556008)(4326008)(8676002)(66476007)(86362001)(558084003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?lMDH6ktrhG4WjULAJWCzTSBpUEGRbnI+XkWo+m+dUdXtk1wTAvYoERSa5BxF?=
 =?us-ascii?Q?QebEe8wVngoVb1TXBZuSXZoKaHkPW6stsOLDSBQuHbHQ2BnpV7PbNsb0vMwN?=
 =?us-ascii?Q?AM4GPRAlh/zejuQNGfr5ieAm6dnWlwKlr++8LdPyF8XMjkhH86nON60X2xQs?=
 =?us-ascii?Q?CwaF3RV3c4Nyy3P8T/9Jy4K98AF5HuLIY4Uz69rGT0yVc7NaTFEjIrGXk2TF?=
 =?us-ascii?Q?bkFT98C7NVZFlTU7ds7oE0SJawz8yS1M/1Sunx1XiVQ3rbdjEWXoBQ5D0LZx?=
 =?us-ascii?Q?Xo8qfSQAFOeE9CeUAL5VcPn9guzR3bg6rAXI1JGV5M6+YeGPAbGBLONQmDrX?=
 =?us-ascii?Q?TJtxF7BuutkODths9sUCawLxH2UiJGdWnv6JRXVTd/6AzBtFLWq8F2I/ScpC?=
 =?us-ascii?Q?6jtiE2o8EL8iPFxv1FsLym+PXLCHoohT9lMzmRHgtiBincSPwE70KeOOAB/8?=
 =?us-ascii?Q?a2iGaXz0UM6gciEW6bV7mRC6wAMOYiR3wp7Spudu+FyHc/1oj058KT8b74Wn?=
 =?us-ascii?Q?qVk0B4CURAfRS2dGuv1r0RCg4hKuQtkTdQk3m98IZp4SLgWGeC4xqhKxin/M?=
 =?us-ascii?Q?ROJKiORW++3T1xbzjiXuaCNMbMTyEbmVY5xj1mvPHC20jMvr/dVoQKGCHhLX?=
 =?us-ascii?Q?EYhrQfpvn54xuQwMvNAy0oKtZcn4A8WvmSuGAuWdNtKWQmCAgpL3sy/Vbinn?=
 =?us-ascii?Q?hQ1PzWlS9++zlwsaiw/7rJ123mOzopAiMlpHW8kGBTjanL0E2S50L98YINT8?=
 =?us-ascii?Q?G7DrBvWBybWQOR+08b2Xdaau+qtSetk7vQkDX6wz7uUHDDU214kuL2PTrGgC?=
 =?us-ascii?Q?Pz+2lwbvnh4Mk9jA4I94DE266ZWBDP6WpClUadblwq92xgZegMyu7TfypwsI?=
 =?us-ascii?Q?R16JfkCqk8qR3Ki69Z0yBPB+Gn3wO6zhB5C5TvDZ+/7wxKuSBqCGicaZR7l3?=
 =?us-ascii?Q?sxNXPGzRSxLs0h+qvGRNazcrCFCGnfhXIRDwlpGfUcAfkcxrQL7RLCPUanT1?=
 =?us-ascii?Q?97IFx0A9UjVlqjzakdrokgrXWZz1qC0bCvyg0+xiAt+d24eP0gjt1z7MOjBI?=
 =?us-ascii?Q?ZpEzTSLaH373UJKpBPF57mmjaUj/+5NsUeRrIF5oAjMWSECeq6Eeh3gGwNCF?=
 =?us-ascii?Q?3q2VCRygT77j7dcY5qatGkCTHvl84Uey6Hb9zixADDIxcjVeEnwJssUc3CCB?=
 =?us-ascii?Q?Xg+XxNjFAlq7d8TZQoT+P3aDAP9FSVkB1zqeJNx8sbcjmfGmRnKl4p+dhs6Q?=
 =?us-ascii?Q?j8rV4ZT0SWk4AXMf1BHYNDHoE+jpMdyQR2/PuZ9wB69Tm4jz5Gewt9S9EGj3?=
 =?us-ascii?Q?WlhylvcE5dp8mTSVEh1cGxrhzb+f8ObqfzGo0RV54V8WL/+gWxdQNexhZUvM?=
 =?us-ascii?Q?afmpmpIXJoQMSdFoHQYpel/stXwpAgYj/J5aVn+Irt7qOMUiFSWKnabuj0Na?=
 =?us-ascii?Q?HdfyK/yCzi4mNeRPYvtJPTSsUcq4m0lliV5bSCu5QS00TjZWO/CFWjB0VZUe?=
 =?us-ascii?Q?GEC/2X8sH3x7grRoV+rCWwvilIMfdMAE1uE55eHaeWkqElY3P4QqgVU9XQ6w?=
 =?us-ascii?Q?rUtUn9sScEkAPqgFBBg7oGHFfBRfhHEi2uPFSz5CKE0u+JB6tBczLcdPTyuU?=
 =?us-ascii?Q?+k5VaoJzbZSC6/tFQ+GbEH3m5GGwCzBouSG1ws0XO0k1cLL0Iuf9PCjX0OAt?=
 =?us-ascii?Q?y+Ss13cHXOzUhwIkoYECHYxUr/dAspnaYRBUDrf/fMqbVYnMToPBZUfrhJmf?=
 =?us-ascii?Q?Hi/NKuIrK2eWfje3rgQEdgUGrvRhu7U=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d6f5c4f-09ce-4dca-6516-08da18452f3c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:17:45.2049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aBJZRnTe5Kx0LzLVx81GItdPKiCUwqUPHtBHkFL4z2+UkdDsGENVRb/GxmKjyxCvUy2HemVTsPNJYKyuHK3cHqYGwBsE2ihiVcqQWJbOMKI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4408
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070017
X-Proofpoint-GUID: ltKuv-mLVXiJy_PpAHZUvxU_1hIMo61V
X-Proofpoint-ORIG-GUID: ltKuv-mLVXiJy_PpAHZUvxU_1hIMo61V


Christoph,

> Add a helper to check the FUA flag based on the block_device instead
> of having to poke into the block layer internal request_queue.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:18:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:18:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300264.512036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIfX-0001DI-5n; Thu, 07 Apr 2022 03:18:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300264.512036; Thu, 07 Apr 2022 03:18:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIfX-0001DB-2g; Thu, 07 Apr 2022 03:18:47 +0000
Received: by outflank-mailman (input) for mailman id 300264;
 Thu, 07 Apr 2022 03:18:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIfW-0001Cu-0L
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:18:46 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6e1cede1-b621-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:18:44 +0200 (CEST)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2372POVs012451; 
 Thu, 7 Apr 2022 03:18:27 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6cwcjad5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:18:27 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23736PuX029482; Thu, 7 Apr 2022 03:18:26 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f97wqsm3k-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:18:26 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB4408.namprd10.prod.outlook.com (2603:10b6:510:39::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:18:23 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:18:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e1cede1-b621-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=4R18pwpZs4MCAT1nUpfEebB1dGvjB+oR2X9XNPWO4p8=;
 b=K00aU85PLQqbvLtFWFoJrDU265LTE87Pk/HdBAP/k00+nUFnbt0HzC28qXULort8/5dT
 0MHpiTEsWCfgWIp/VfQe9wiWPEAirP8mYmfSrg47AbJZDmThd0V1PsvRsYi51NPFYNvr
 NP2yLcU3EOsB2gWzmVP8aRKlbSwElWU+lSbkDiCvniySQOstZ1VwrWhBJ4RcKNHPBxrF
 V58nasvrQdpQg2m7CndmhycOsf0q09wIS8eq6lycZSkVJxROXgRbjAvJF9JwSI0MotNd
 lbjdKIs09wAmCsCRIasNHrHq321KOUHGDNEJaaEZd2owY8TuK0k2deMmuCCqk82rG8Ea 4w== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O25uO0BueHUJN4G5YWQ/pZKSQFUTVgJDOUxEmxaadRGxJcbSKf6kdI1i4cqtX0sTTskKg8DjCjxfpEobxGIx95JUiYel+ilDSgSrjxjEzhpN76YABubhkRT9yiZIJJpo9Zgbc0uz1GfQs8/NrbS57CinKt6dSFg4HHnOhnGLl5eOhQjfHJusa/VDx6Bef9BlsUjr/ZtM7hPrn6iY2/1nAUYuAYuPG/x/zAmi5qDm9F+cNQQNsoM6rfPflQUqJFw+LgzUYD5Mfl25IR0NILxV2mbpC2UJk8P4uYpdTnnd9gv13GoslRQIl1LQl0hjNLIgEVn7xLEh+HdKST2r0RQWmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4R18pwpZs4MCAT1nUpfEebB1dGvjB+oR2X9XNPWO4p8=;
 b=V4FaobBp/9RjdJNp8dnQh12p8QjOIb2fJkFjC9yK/wFeOxgrMwGq6aDEyu1t3e/cPpNFd4iEKDVauxukGJE3e9ghhDQokDAXj2BfPVME+X29tAP73TSRBT2iiQ6dsiCJfEp6F5ySdFsz01vPqFchEGfYSlhMP5EuQRcHwWzBWcbfHg+l6NrSEftNeo6J9oEjJsYmBMcnFMSYUYv7QsiaVRdeuobHtXEAADOKFwf0nFxXL4mmiTp8Fi3DSFqIq8zG0BnnEHYl+hJXjBUGHMAvtHvB6WE5co2Mkk3EdhstyxkRMPV23wSosaSJTEiRO3up6fqaHR546MAgbjhPqikpLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4R18pwpZs4MCAT1nUpfEebB1dGvjB+oR2X9XNPWO4p8=;
 b=cxLXo3OvLrTa628//kIET7Ti0V6/UZFRGi9WHq1SXkLaJWXQcI3oYPMnBjQ7xLW0zTObAoEjQLfK43tQmNc6mLfp/lWYt8DWQCyoCc9Rnb//ecM/57CfmvxCySwNMe5n+PKd+Ig1TQXRcim1T4Kx5kFPFl088aE8yTpp0FEh3HM=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 13/27] block: add a bdev_stable_writes helper
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1mtgxintf.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-14-hch@lst.de>
Date: Wed, 06 Apr 2022 23:18:21 -0400
In-Reply-To: <20220406060516.409838-14-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:02 +0200")
Content-Type: text/plain
X-ClientProxiedBy: SN1PR12CA0078.namprd12.prod.outlook.com
 (2603:10b6:802:20::49) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2ad1994-3c3d-4e6a-83b6-08da18454625
X-MS-TrafficTypeDiagnostic: PH0PR10MB4408:EE_
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB4408F2AE0D298AF4ACC6B2E08EE69@PH0PR10MB4408.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	SLUvISXJLjYUGupRQ2XT1s9tBnJewgVitQqt3VbaYK1TlsSRvia+IY6r1cACAlU0Wa9sgavIuhykxLRm2HHe0Pdr64qYaVsO1e2Y/l7KspFO8oSlqX4OsmfRnYdI20hlWEaGs4kWvsvm/5mVwcwnyEKRAF5RE9SHBE1Knr0mMH/zSmqo4bp3hkT82WooPA8N5riuntQXkoB/rNN7cnESYFFPL2asRWA+jwPCZVUphEvJ5XPFvyT1z2Eq+NQwtwzdcvgLA+IBZswJePmovMcCLym7FxouJeyk0vlpY3eLrZNZhP/6ECTKFt+JJ0PAaO6eArEkX+hClm4sYV6QFop66FauGhK2UYdYYA4opvhsBScbB5d4Ed8/cQCqQQ+dhdvW9pdbQoPmm06l/Ahmogsm7wLzTX0M+JEoODGs33L2YsXb/cL8UawqLEDKnXTkjWs2M1XmfwZ/zkzZFNgzArnuUVx7eIPt65HU/Tk1oJrY5ysSRqrw4b3w46oDSItf5KrU9Dp9eoCGmADWlTqdgPqBj3kN9pTb8d0Oc2PybL2XdJH8pDG1B1GumdgkmZjBrEvoXcN6aVgIojHhHdUHDGeGkGQtFkG19FJ6njKmifx5j1yJA5ZsiOBoHwLYh6Zi5wpftFEN5GFzmaxFhO7stvzBoqXlPrLN/M+oOPsEm60V21SQkSDCCwDKlkOodU+X+oC+TQ95BXh9aAkiCMJct1gRlQ==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6512007)(26005)(6506007)(36916002)(52116002)(7416002)(83380400001)(186003)(5660300002)(2906002)(8936002)(54906003)(316002)(66946007)(38350700002)(38100700002)(6486002)(6862004)(66556008)(4326008)(8676002)(66476007)(86362001)(558084003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?xIsd0zLwcVDDnh7s1S0dJ4gppcaVSQwl81pqFbYz/+egH66fuo2Jc5jaKjrG?=
 =?us-ascii?Q?5iZ9E5EH+nYNwN8C6r3SBW1b9dbddV+7pieUtyv0jx1J2YD5Zzt/4MLaM/ko?=
 =?us-ascii?Q?I0nzssasq8sQbtr6/sAG7CmZrQpDLmiT+qpBj3wFUafqk85W+Drzww2xyEpz?=
 =?us-ascii?Q?wI0DSIThoePrDVlDDs8ivw9D3oeEGiNA1ioOAExJdUzArdsS8jer3gKF+rO2?=
 =?us-ascii?Q?ZvU220BzEAtzCOhzO8Ff/U2ZjsQ1TkmSKxflXEjpGHY0cJ6zhVVNNp3HB2iC?=
 =?us-ascii?Q?bX3J9jWoS4tsyz+wWwpJJrTnQJ4zPsO6+ki48PWPdsh2euaJ36jks7y94hZi?=
 =?us-ascii?Q?V/cN3QBs/4R9l81o4Uwurg0tzElEY/5T+H3wo6uTYg2ylkdH/Jmw+nqKzPGN?=
 =?us-ascii?Q?4YDGYkt9Sug99AMbl29IOHzCzYc1oUBMobgGJMbLklxYvuIgUIRrsWnRJuqi?=
 =?us-ascii?Q?ZIyHsyLPdR2QF6NwFaadAFAn1tjlB3IQVnjCjWkj7L+oJGFk7P8W/uJEo5Q5?=
 =?us-ascii?Q?T/c5ZzvwDW+94AZzbaWiENJI4Ctp/2vbovviAIZVOJEhMqaojguOJt2bRJMO?=
 =?us-ascii?Q?Y+748XcIrXL8IEUWvTiHgZYiOOsIhJzz0+hHIvk/yly9LJ1+hb4pRfxtnTC5?=
 =?us-ascii?Q?TMf3WWY/vby6rTVShdQNrzoNMGjnbcEHW7hNd4ZksoAX6LVufUAbUaL8PF6m?=
 =?us-ascii?Q?VBzXXc97sA+qu+HcVVA9PAVO5u2rWh6e0kIw7MFVLOcKd2Q/DqcKYobFs41O?=
 =?us-ascii?Q?qY1zIbQjB89zPwjOOdwl9orWX0fCdfuawnQpOhIToO1UVkhmzdymnn5Lkq+x?=
 =?us-ascii?Q?Xz3U/pDNM/7XXFjSc95PFNwEi/Rdc4l2bxSZMAdvqQZIGrzqapnBUMY4CD33?=
 =?us-ascii?Q?d5giA1c9NSqUUoQSi6SS3Oxsne/7mmvsWjGhDB02IB3O3qXiUVZGLVls3g1r?=
 =?us-ascii?Q?FGY3G0vC8ZetoHeQa8UMBfEYNwQ6KkCWJpwhGISTrgTb/Nq3vwYOP5kWdY3k?=
 =?us-ascii?Q?SAwF+RAnM4qU1Z4QNlCBrx662uuC9IawT2Kk9A+lXP16FAm8vQ9b6IOy2X3D?=
 =?us-ascii?Q?rQf3kx/nU4QPe2JannqJimA8cG+wIGuoTH0Xf7v8vbEIVt8dpGHnpSH6qIZj?=
 =?us-ascii?Q?sbTPBIThpBD6cDEiSSSjKMB9pZrBK1gwMWBy1kiw+T71IBnMkc0gjPpFkFO8?=
 =?us-ascii?Q?InOFEkVOZfl/2n5j8jRuyH8wA1H8KkddXKUwqZSERpwjVZmXvDo8Fp9laCpo?=
 =?us-ascii?Q?MmB40C2ECG/Cue6W8SMe5Y9zunHmiBcfxendBmJgFqnPzHwH65DkGs4y56eK?=
 =?us-ascii?Q?RU7FxGRN84qz5e01RViYgxspfOMT+NtQsKRINgp4oywm5U3jLnumrYnaYT1M?=
 =?us-ascii?Q?/sG2odArhsDNTeuPtDYCCTCKWNrFHuibcJ4SfhQVefycP+gdmnxHjEdB0p5e?=
 =?us-ascii?Q?wl3LG9BFWzfHBRcE24beJ2a60HJYtr5i51pQOOWU0+3NRhTcrkxMQarzn+o5?=
 =?us-ascii?Q?U6JvwGc1Sis+FYUsNIKJzbs07TCq2AeZmof1g/k779pG7UMHfg2oKC5dAD0o?=
 =?us-ascii?Q?0+diKePSeMM9CRHkEK58cTVlS+sTGDjnhSWvaOM2zOWO69Ny5CaatYLC+rAX?=
 =?us-ascii?Q?OHcId1N0UPO0A8mnGFLCCFEgJ72887m2LOfEr5JhHePt4eLhRXXQJ0jVUXrb?=
 =?us-ascii?Q?6Ag3ZB/97Kzn3SXO2TvruRccP3HpJnQWG/K+tS+j3t7o22HdESkN69evPfSL?=
 =?us-ascii?Q?kLkG+Yu6HtWm/SQFpdF0wHGl3iEZ90M=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2ad1994-3c3d-4e6a-83b6-08da18454625
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:18:23.6582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hZ9wn6/Z6Gqa+JKgYT944VbgDZ5imkniqjRmEsIQ1javdBvsN1/Na1raINqCIDzfpbrVWYGXUV59K401IhUHeyecdeVGfgDhGALhkfADxIA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4408
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 mlxscore=0 mlxlogscore=946 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070016
X-Proofpoint-ORIG-GUID: Yoj1mmlMui-AZzQWBd4yidsBNyVdnJfj
X-Proofpoint-GUID: Yoj1mmlMui-AZzQWBd4yidsBNyVdnJfj


Christoph,

> Add a helper to check the stable writes flag based on the block_device
> instead of having to poke into the block layer internal request_queue.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:20:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:20:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300270.512047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIgl-00029w-KR; Thu, 07 Apr 2022 03:20:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300270.512047; Thu, 07 Apr 2022 03:20:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIgl-00029p-Gl; Thu, 07 Apr 2022 03:20:03 +0000
Received: by outflank-mailman (input) for mailman id 300270;
 Thu, 07 Apr 2022 03:20:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIgk-0001tT-7A
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:20:02 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9b623972-b621-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:20:01 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2372avAf024455; 
 Thu, 7 Apr 2022 03:14:42 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6f1tared-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:14:42 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23736QaM029516; Thu, 7 Apr 2022 03:14:41 GMT
Received: from nam02-sn1-obe.outbound.protection.outlook.com
 (mail-sn1anam02lp2048.outbound.protection.outlook.com [104.47.57.48])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f97wqsj63-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:14:40 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by DM6PR10MB2698.namprd10.prod.outlook.com (2603:10b6:5:b9::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 03:14:38 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:14:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b623972-b621-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=/V0Fwxr5Zm+y2aUbPU9s25E9VnsikKMkCQTHQ7fjVfw=;
 b=i5FMU2e8LcZtJnTYkwV6E8F1CmXHTpq432Z3UWXvhHLaaqaB1qLy6grINx2kAbYvfYer
 SN8+/U4jQlO+0tJQjU+RPhn990QZ+/KevL2vFVzK0vh6BtHNWBUaW3rP8TJIRu5RxPuv
 5q2FGGgnsw+BcWFF1Ul8Va26S+QruBwCczAAZMsHEiODM474wY/Lvn/qpjgofktuHQbB
 rQLE30y5Jj2kFRYSzXmvZ2Kccneww/aRTF0VL25SLIHueHK/uGvY09oouCorc2CXAmuQ
 F+gCGaE5kiQpxNaK/oVtrj9/VdkTmpTFEg/S0107fuEBTxgj0Cf4xnG1niTDoPoQ1Vjv dw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZejwOG2RyBy5APoCPpRRDnrxjPNsDEUuDWsaQSgIqhJOpZDVvU3rEeDbquZ28wabUwh/cVx2ULrFoV4jtiOLBcfskMdPsetzIKDFIVlHCEdLV9fsaUzmsTyBFICK4C0VFPa/cmC67dDZykbWIi5qJoPvTR6VQeqwpRqL4QPA4nQf8+j1Wcj/KH0HVxLLQzf9P6oTWhzSEfwn4KOQZa1Ix2TT3e9PiVsZwlovL1/q43oAeakpHZGVW4IqGYliLE3I/yMWFZrfiSgbzG/BGUKhKhbR4AXcLm598Cdzj6Mc+UXjWBQ+9UGH3Z60W2N/BaBe+kHBmFNzOrhqIzWzDeIShw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/V0Fwxr5Zm+y2aUbPU9s25E9VnsikKMkCQTHQ7fjVfw=;
 b=GEVUnwxEjR7Y9KPKNHK9EJliSrWYamRIZ73sHezNUx8fGSYFb5nzR2cBkYgRGnVUyoLwUN9KQFJxnxs/UZvO4PyVrOicG7IsS9rIMQwg75OgZei4vJ54Jj9DiVJ6oa6u2XBSTjRpnfHHOJ90sTfJiiD9Ny7ecfnXQ167vkEsU6A03LEmS+/+l4wrxjn8H7PW/jZ3WL2X4n+Eoq8kB4j+NCOVk9OADTL8WZL7ey1R5SN3t09O6u8W68yUN1qaCZSvua5HleYiQCV6FcM0krUbwxhqmmCkTMZpATS/c0BglOa1pX/K8KgoLXpVWZiaT8aHgFUHpEdRsRXXxMXfzbOtHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/V0Fwxr5Zm+y2aUbPU9s25E9VnsikKMkCQTHQ7fjVfw=;
 b=eAUxHlJe9dYjSx39nvRTqPMnjkc8ntSDSTlBA/YnG45Q86Uzz9W4anDsjmFExxI1AkFiVdGg9+f5xOEQGGa/wWlpAf4FhZuqEND5u7spmQS8Pk+9zF2P7zUDPeb0EJIuMcTWbIQd4f5YhGwoDsPmrUuRlVkXD23e+HEZ083OZy8=
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, jfs-discussion@lists.sourceforge.net,
        linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
        linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
        linux-btrfs@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 03/27] target: fix discard alignment on
 partitions
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1fsmpk2jw.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-4-hch@lst.de>
Date: Wed, 06 Apr 2022 23:14:35 -0400
In-Reply-To: <20220406060516.409838-4-hch@lst.de> (Christoph Hellwig's message
	of "Wed, 6 Apr 2022 08:04:52 +0200")
Content-Type: text/plain
X-ClientProxiedBy: DM6PR02CA0103.namprd02.prod.outlook.com
 (2603:10b6:5:1f4::44) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd16d686-cc37-4a76-3d91-08da1844bfae
X-MS-TrafficTypeDiagnostic: DM6PR10MB2698:EE_
X-Microsoft-Antispam-PRVS: 
	<DM6PR10MB26985E3A4FCB8369FFD925C58EE69@DM6PR10MB2698.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	EWt/W6binc2eK/lECYWJ5MwOHdOLjtV+I63HmdvkMRPRB2htoEOcPRGRfBMW9tbPGBqlwpjpAkJkS41gbveQu/1ScCzlgh6qfX+5SUmKqzDqD9VCEurwxyL8ZDNRsdz7Dpk3QBzQh2SlIHtjGfQdTIdFlCS24a6OkGPBx1tSbQMGWlo+oMG+mJyyP90zI5KHK6+ICjV/1NE32IA8lIUzdKd2C502SWwtmefP0PT6F1HTtPFJYADznODzb1W9VN4bDPmdWuMeuD1jiGv+fTYDvXhGCSj308rqAwwzVVW9OdzGECRPxQ5aIjcCMSahoL9olDxMGzyrRM/8lHzaucrBhvV3NDQ1CMr6SMrzXb6fdYEDgt9/G5LqWRhdPIcNm226/JikUF5Nyn1bD14RhA6VSTmuILGHdcgAtVxRKnBDqWUDTQbwfZlFL9V7k2ssGgxHy4cR/k1cgqKf314TPQxIHL+KP0TLYM1MCYTgKqEAP+H7T26foljEU/ExTs8iuJ8lpIvqL1uZLZDefvYp7Nb+th6wIJtUXdnHcTL07mRkkGzPAA6VOo66s2Fa7rfuatRkW+KnPCZHskImIZcvDZGmNzG+W08C+CM6/1iZcDOS8U8RKtYpTaIs++MNs+syELQw6R/pto2AZPDxz6dSuzvVFt28XRVCfsI0SJSvgbhKdK9Cm0osZW5O2c+hf1fM6QCEexoFmHfDTRVUNFmBW1Acvw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(316002)(66946007)(66476007)(66556008)(8676002)(4326008)(38100700002)(38350700002)(86362001)(83380400001)(6512007)(558084003)(6916009)(186003)(508600001)(7416002)(2906002)(36916002)(8936002)(6666004)(6486002)(26005)(5660300002)(52116002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?0lCHWB5CBAfwxdmlYZdoZWcbAIAxhJ3LODYJThGmg7jDyutQne0bNBmdyDur?=
 =?us-ascii?Q?ByoGymw/Mop0IlkkOV+oyCY7nLNjITJCUSg9MCdcaq5JYJP24EqvYPFdX2rT?=
 =?us-ascii?Q?EpB4c5NM1fjYkwTZph+pufL8FGWp74GdC+JL5lX5qfhCMUSsxav9iHP4vAVx?=
 =?us-ascii?Q?YPHuc3hMHDhBFgSS9Uv7R4Nhr2wMr1sA8n/EiiJSjGEiEY76rJnCaI5w4fmh?=
 =?us-ascii?Q?q9tpd8DGH4QihSpZgc9issz6MhKD66MCp6iUv6aHIVCBvVxO/0JMonYZSYKl?=
 =?us-ascii?Q?enTfd9Zt7rKdhtOXydajK+3LT/QeppMoj4yefqPJQI3VFi3Rlzwy1E/Rvtwr?=
 =?us-ascii?Q?ee2wlH6PQY0/aM0wa5AAZklIXcDd8mCuuqzkpRTB5yI+iLslVVTR9uBhpt2p?=
 =?us-ascii?Q?JKf1DuCnMhXJcSAB5KsFDWqN/y0ddIUIQ8d+63k6nnPwDAm/wGesJIyzZNAU?=
 =?us-ascii?Q?gDu10O+HzN9khXj/iHdhVTB0iVmtP800x1T2SfH/qUbhyQyAhcLlQFqlizLE?=
 =?us-ascii?Q?3V/cg8VXQZ6p1ERUkv2z7PwmZ9rEBHnUjyvWa5u8btsWLsa6ebMCRDNW7it4?=
 =?us-ascii?Q?/BN3htjhk3MrHj4pHfYaAb2HwNCQRjrjXyc2pUBiiupu3XCJFC/vQYF79Xap?=
 =?us-ascii?Q?dhpiqCwmEsmHnXbhHMURJhmFqpFjGQM0rmE7VYtaS1azRH/zH2TqK8HW8pwz?=
 =?us-ascii?Q?TT/eH5/bYBYmb7JWQZn1K68lBk3v9ggLRJEPCM05Jk8LGsF5KpcGNVE4pgKg?=
 =?us-ascii?Q?4wU/icVJyufC99p/FPHbL+NihjwQjGYcPWFgcsisxTrRrMb2cGhmKTGbT6PW?=
 =?us-ascii?Q?RfNpNHvqtrgo3ANfvyR9Xp5jxXKUwch60zmR9Uk5vgfncScjbcjQ4HYYlUFd?=
 =?us-ascii?Q?vFddJTWKXkIkugR0EPcmXoyOvGme2SVnwY+Ib4pH00P8ZGZeIuH99iM6g/to?=
 =?us-ascii?Q?TFeJTH+Td/paquVRUEJuE7J0yMRrdV/Sax5+EtDFe98NIG+whyI/6Bj1pNqZ?=
 =?us-ascii?Q?wOxPRR6nGmWycCS0nKv9YSiVjwgtRnOxIg3NK+XcPi1oBfVz/TpbxEX4/kMg?=
 =?us-ascii?Q?m/AwBLjNevFMvwTFqmi23A5aK3TZhSU9TnAL3af9msEWxUzOH6FpqZqVvp8H?=
 =?us-ascii?Q?4Js9ZlIyr3E4FnvS9OguYjqKW5DJEs3mb/zBh97Dcj5LFyioMsPh/8mGnSYU?=
 =?us-ascii?Q?84UqYKNe5gS67rR4fEVKDrxZhu+GK1i3TNzQt/S+aCAyI4U+BA8muQftrtdb?=
 =?us-ascii?Q?hBWSXul3WwBbd16Hn/0meDVY7qCPBaaCbFxY47FSll6l3IOEUnLLT8iE3Wy1?=
 =?us-ascii?Q?gxVqtOXX1j27wClIJNcMn0ouYT/Q1ExScWcQUN4bzUk1qFHuu5M09nbQ3qa5?=
 =?us-ascii?Q?gglYD+TRIFgjl1PWuqnOT5xcm6L9/0iOYJZNoNwHYEAEB/Udrxiyea4lpBjV?=
 =?us-ascii?Q?aGMWobILBsEOQ8iI9tmBsMc8xwMkSRAsF1rgcFqTYWuR6TVkwV9h3cACztyj?=
 =?us-ascii?Q?n0v+y0ZGv+/DZqRDh8xCA2h3FYBxucCT6YVND0UGYifN2k1Vx00zY5fd6a8t?=
 =?us-ascii?Q?MjiolsTl/hoVVWbWtxtLdTlwrnjF+KNM0bgPhRpARfUs6Rtrb9rwaAJ38xl7?=
 =?us-ascii?Q?yF+BsrT69GYVCe3qoe0SHsjokAv9TmjFF4WJO2GFjaycWThlGLk1SuEx7ER9?=
 =?us-ascii?Q?yyg+pneArLHJOfX8+vAxAQNmqtL8Ut+fvQAF7I7RALWEuVD+PVU9mY0qqkS5?=
 =?us-ascii?Q?zJyf1w3vMz9oPxOtwim/64f7os3CZL8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd16d686-cc37-4a76-3d91-08da1844bfae
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:14:38.0462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xa7XDsF2TUSmbTPOLGTD/Asj3pN0wQx3E3uvOsKaxFNEGn5p6T6o4mitNxIXls+I9gNOdTohIBjq9Or2InsQZNGmqeEh2TEB3f7kd9F/mXI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2698
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 mlxscore=0 mlxlogscore=949 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070016
X-Proofpoint-ORIG-GUID: mizjd7EMRmxU8Dxf6z3sZxhlMV4xX3Ds
X-Proofpoint-GUID: mizjd7EMRmxU8Dxf6z3sZxhlMV4xX3Ds


Christoph,

> Use the proper bdev_discard_alignment helper that accounts for partition
> offsets.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:22:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:22:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300275.512058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIik-0003IZ-Tg; Thu, 07 Apr 2022 03:22:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300275.512058; Thu, 07 Apr 2022 03:22:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIik-0003IS-Q4; Thu, 07 Apr 2022 03:22:06 +0000
Received: by outflank-mailman (input) for mailman id 300275;
 Thu, 07 Apr 2022 03:22:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIii-0003II-Rd
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:22:05 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e4306521-b621-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:22:03 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2371SjBS024505; 
 Thu, 7 Apr 2022 03:16:28 GMT
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6f1targg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:16:27 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23736gj5016366; Thu, 7 Apr 2022 03:16:27 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97y72jh4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:16:27 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB4408.namprd10.prod.outlook.com (2603:10b6:510:39::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:16:25 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:16:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4306521-b621-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=W1WqCICKHnvyvIEevFUyUtdGDLu7sKYBjmUGmhlgDFw=;
 b=Ijw2Hbs8JlfO85BdJ/ePlHYrF2UCKxnJLItzdWFviUalxElI3wDrwqjNlyiB7i84rddJ
 LFAlhUCGk+g1Qiv/GNS3oehC3qPVbzzWFH48CUBLJZLeqKLmA+nzGF7CFwDmAsCUR4DG
 g6JzSWOAHIDuyYwrXKfwzYmvCgQPE04R/QmdQSE5q8GaqvzJ2dfuPVDQJbClBaWJt6Uk
 2yQut1Eh7TwRv8dlTTuLi0zBfffH50lZT5l7pAWvweJY71CPUr12IN2nu/3nLikq/61m
 UYouBqsKJVTAyLHMoePtKdZR7LZbm+/1Nb4FYlCom29laVhilgBW2d/i+YxuiSCaoVLj xA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AOUVSlsMFTX96n+sfV0vWyh8RwRugxxPRDM/EHGpyLa4geTx3Dn9+OFR3qJyIFV/YeJYEDrKJMI0vxyWqAxsMSY4ueqHuND608axNP1Y1aWLnONKXmkPFfMy/IrGLCpkFyoIrKxx+86DrEZyK+nb3z5Hwh+oUnNmOEdtoh6Ozfq9SjMFTdf8FrZGWFmbgDMOSa+mn44JJMIQ+Fyphlx5nQ2QJO1IDsyo9wvzFOgwf/BhNcdAGzsAr27fVeQ8k5EGlxhQReMm42rJVkF2tgG4NC0Av+KBgM7d4405tJI9wci7L2huHo84nwi73xRDu8rna2UelCNgOjdVn28ZhlmBow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W1WqCICKHnvyvIEevFUyUtdGDLu7sKYBjmUGmhlgDFw=;
 b=VbR3L8bgFBs+hSLjoRtgL6RD7RqfjQnwU1iLudxLsBoRiqqH90ovTG7WJvg8K8uDCE9oygIe+cuujeZFNcv8Q6mp2kGAoWvqfDkGDlcZwXKNqU4xvI0BMLx81Ahjf4/owEkh5MsSvTybAzHIiU12Ccp9yZr5kDuWJ1v3ygWYP5LWDSKVzI36SAOZxAhlzVdoM8iPRmsW5EgaUXn5wpGMISqG5Ve+JI8K7MgeY/QBWPXLu5yLCHGMv4bhXfK2exFPwz4DxmyZp8J38DR+UVCWs9CKumsyrbtv6yQU7cnfYIi1ZrLRt3p8H0KRYYf7GlMVBVIR0T2T47T+33padv8QMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=W1WqCICKHnvyvIEevFUyUtdGDLu7sKYBjmUGmhlgDFw=;
 b=d1mW83v97OXADeEhiNwno4KHtAI1Dr/+rfv/xp/Div5IkCokXN8XJgFqPMOvRx1qGArbx3W+Ih5BSOZkemvBHmMsRm9EsBi4czSxbNzQ+B6BKyEEVrC8iqfSjIX1by/wOiMQjUo4/0Ts4Bv85+SzzsC/ynTPMowE6yh3sNbq0dM=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 10/27] block: add a bdev_nonrot helper
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq14k35k2h9.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-11-hch@lst.de>
Date: Wed, 06 Apr 2022 23:16:22 -0400
In-Reply-To: <20220406060516.409838-11-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:04:59 +0200")
Content-Type: text/plain
X-ClientProxiedBy: BYAPR07CA0077.namprd07.prod.outlook.com
 (2603:10b6:a03:12b::18) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0f462271-2218-4474-a0d3-08da1844ff73
X-MS-TrafficTypeDiagnostic: PH0PR10MB4408:EE_
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB4408AE965ED0AB2544822BF28EE69@PH0PR10MB4408.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	NMmh+ZQkavrZ5cLbUFkqRpr7UKCi9jo+ltTf6PUYmds3TizqkdwQnoCwKSxZMljAA3tJuCEL/MJObq6aVMKnoZCKQqUAcsjosyZY2BxNwm/LJRIQGaYzz7Ws0cD2MY3+9QJKH0+fRGi4vT6g4i+vI3gP7jEbfGEnTX9Q9yaimvyzRGp3ReMnwLiiHoVt4NmMi4i19q3NHtL6oIdEH8KK39O3zwyJUUz+cFHMBqY3TUvZIM6pLdBBIZWZjpIQb9cIVOesvwty/6hYIt5UFfexVAOHA+7LCpQBKM0KWjF2QXGHHDm4KN1yChXbcJZaTAurki4hx5oSu1gdSdhyuES2RxoogeQ8U+3ijGwG8xJbxXmX+5qYemwY2w3dxz+W/IZ6LLbVyUM6QTc0zo7GhYQKtFICKiGxRKzEIp5IoPYVnFXqYIN+/JSXL/djlnJnz2YRHxtGaHutvnxfTymiRbbyrrd22DkHvQIgU3W9XOcXLz+Sllw3hmm5WnJToqM2+OhZANuRWGOSyf1vTyoU9jShqq/hL4OoQXswbd4FYrGHQEr/Z4gobNIop0w45O47qg/mkBU0wtANumIpzIhnALOUVdA/ovm395J/UDLOscRojhQhrvYl7cjim6SZ96hzCByfOuRvHDkWe7YaTa5jUpkiZPbah3i6kU903QdA835ZUxbEBEkK34ka4qSZD5lIFbaW4CqZlOxLgRmHyzJV1dlknw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6512007)(26005)(6666004)(6506007)(36916002)(52116002)(7416002)(83380400001)(186003)(5660300002)(2906002)(8936002)(54906003)(316002)(66946007)(38350700002)(38100700002)(6486002)(6862004)(66556008)(4326008)(8676002)(66476007)(86362001)(558084003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?dqm37A3fFwPDBYCZ8m/YhNWV2AakwE7LCtT1gRQIWx3qs4R/6xQkkBL59DZP?=
 =?us-ascii?Q?tcgNVzh5hC3cZfEax8MgfE4B5jpU4dFX7o+vtjh8GWF3fhNkbC5rfTVAcoYc?=
 =?us-ascii?Q?F6YQkSxJ7KpO69eS9B53LSLJcVHiheWWu71iDzKzgzCumtcJkLSmKk5mi800?=
 =?us-ascii?Q?TAW+VdVcQ3NxBzZ9huoW/00HSSJlzkPmwysdfXNaGk8ivQmzMo7G6xctKZ+p?=
 =?us-ascii?Q?pJop70//r+SZ/qN1N2X+wpcXL7QWQKHmzjHQjOro42e3xQuwxTQpp0kPQ7P3?=
 =?us-ascii?Q?GTDptxumWKmJVGFwtYUqt5vIPKUQnASodEAN+PDxEEsDf2FvbBtttNDQZEn2?=
 =?us-ascii?Q?3026vtNQa/f0GamZ3ujPmBrdSDobtKSWo6l0/AhdzLM0Z4Qfv9kHcMVcvrly?=
 =?us-ascii?Q?zb1K7TDD2MR4qtn58KjRskwnWpzNvIFgIjhpI3WUk5LGTV00uuvvQiihzq92?=
 =?us-ascii?Q?txUDhW+yWQf3jKyYHIAoFEXXtr23ZBYSglWsm1/Hbq2+nmg9GBU2xqlOgwrk?=
 =?us-ascii?Q?d8aK8G2jsHqMJc281/q/Ujlx7M87J5MpPv5qWojTV9AN47ZZ/k7gfXa8iWeE?=
 =?us-ascii?Q?55H9HEh9teG57zClCOXhd4OWFStqefQG55c3G2pv6tKm9/pN6XdpLJvjwDsw?=
 =?us-ascii?Q?697KrnbmCtd4Nfrn5tqytr+GkJh3WIhrH7eRhgpbIYS4k5nH7GqiDT1pf++8?=
 =?us-ascii?Q?N030bLWALhKSPDDEwgVQa176rVM7mbmETd6fVgEqiahkEsrI/nhJc3UGc2a4?=
 =?us-ascii?Q?wszywQotJJRyizFJBoQeALldKHp0dg46fnriHefKPnSgrlDy7TgQUMZd1uGH?=
 =?us-ascii?Q?lWwX6C5SCP/Hs0EUCRizmir4s3mYjZM3qwx4H2A0GtXHC2tVOIFlvc+dfUGV?=
 =?us-ascii?Q?bnVndkEyMM+us1GQ2RuBeCuvzHBHq87NGlv536NRiNPKrMDYIDVT96UjQM4H?=
 =?us-ascii?Q?M/DD3EivG+FNZ8JNuBkIoveCWwcAWZ+oXYoT3/jTlQZBuUuNQNKwmRfm5AlE?=
 =?us-ascii?Q?bTg90C0SIJhNMh0rPLLGBbWnfE9RTfpAeq9B2B43VTbZiDvzYdhbb6QjbRkp?=
 =?us-ascii?Q?x0G9q8McPIx6dSa1cBSMzaUG3QGfdWa00WLUx5SguMDX91RNGL36TuUYy3MQ?=
 =?us-ascii?Q?0K8scPp4RHWSgnXbmTByotwN+QrSf2q+RXRV3cSbvCRQ6SZzWwHrvs7sp/+3?=
 =?us-ascii?Q?ZWhY0CdB//Im55dbkm6sDk4YX0nmDXEs9ZOLdNwaSUvd8eLr2nZIRD7/iVae?=
 =?us-ascii?Q?jplBeAIfmklP33Z8djBa8X0watCnKZMH927IcGT0oXozJvzjLQsc67Z404Jw?=
 =?us-ascii?Q?bOluilJSSWOHqUdwRfpGwNdFqmnHnuqeuGMpTdvDEf86jjkYS4E3GiTCzTbt?=
 =?us-ascii?Q?y6kTuBxeZnHUMd9V952getEXjmZhQOgbPOFiLS6tWqbfN+MAWJ/81TUn1VVZ?=
 =?us-ascii?Q?Z+MCst2/AhtYvzRCiilkT7efQBLgRZ7J5qWDKmUnseKtgrPn3uKC9MyJUahv?=
 =?us-ascii?Q?gSvUSkv0aDo3FHA4AtFpdH+r4yWCGyO4ymjBY4rq4gF8dgIBoF1zUsuKqIm/?=
 =?us-ascii?Q?mHdy7HBL2OL+vC/I+vXrzr50rbyUdRwTZS5MVgdQsOKV/1c/p4g4Bvtgoi/Y?=
 =?us-ascii?Q?JWWj+Ci1k6TOmCebOE9WcIJVhgnp4u35pOkOt3pus7871K27tM9hRrl22iCd?=
 =?us-ascii?Q?dEE18UQJWBetzeHiyP04vFn4ks5ZHZmnzqiMqDbKPySW8jnxzy10+H6JqMIs?=
 =?us-ascii?Q?atFkzk62ROIcd8UrP9QgdHcETbD3fHs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f462271-2218-4474-a0d3-08da1844ff73
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:16:25.0831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JXFvtoZt+QZMvRB6K4PJ4QiEIxz8aILvosFrOC8hdGeBDG9wKGnZ1zG8skw3ymsA5ydm145Ye8FME6355LIf/PPAyCH3Foo/UE50UBcpBQU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4408
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=951 spamscore=0
 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070016
X-Proofpoint-ORIG-GUID: S_lfOALZEJ9FyQJROgu5wgM4eBntOwtZ
X-Proofpoint-GUID: S_lfOALZEJ9FyQJROgu5wgM4eBntOwtZ


Christoph,

> Add a helper to check the nonrot flag based on the block_device
> instead of having to poke into the block layer internal request_queue.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:25:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:25:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300279.512069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIlb-0003td-AJ; Thu, 07 Apr 2022 03:25:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300279.512069; Thu, 07 Apr 2022 03:25:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIlb-0003tW-7G; Thu, 07 Apr 2022 03:25:03 +0000
Received: by outflank-mailman (input) for mailman id 300279;
 Thu, 07 Apr 2022 03:25:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIlZ-0003tP-5y
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:25:01 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4d8851df-b622-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:25:00 +0200 (CEST)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236LT0rb006378; 
 Thu, 7 Apr 2022 03:19:40 GMT
Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta01.appoci.oracle.com [138.1.114.2])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d31jpgy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:19:39 +0000
Received: from pps.filterd
 (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373FNjt015384; Thu, 7 Apr 2022 03:19:39 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97uwamrp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:19:38 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB4408.namprd10.prod.outlook.com (2603:10b6:510:39::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:19:37 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:19:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d8851df-b622-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=nG3sI1771Qzwkix+7woUumXPeYpDKLLcIMXUM/nZXzc=;
 b=uCX4EVIMxM0btfDpTw5w1ew9bFLCrQilscmuwmVdRolfLJunbh9KT5j69VKpBFtOcJAq
 ObSXwXW1pjDG1XcmTA2ht9GIUnTTPukHcg63rNhtrS2pFvtUQU30jO65uVjIMPB7TAQ6
 M3z4ik2IbLzB7K5bswElc2TQSorNj2XqvboFkJ0QDgkOI0JlZpNXTZl+3TF/DJajXHTk
 8hGfsTiGys+WFrXr7iEbTTgcs7X+hTPGSqmMwHaLtKUw0KaZroaIflimn4O+OXx2aqdt
 +19y5fxddpLswZXH4y4t3+qmqVkl+7EYZAckUFjvjawOty9JLhF6oHbEW/rqImOgBjYX wg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aeBKK8wmaZsO7X3MKYx+cP0NIPwThePF6OgXJN9eJjYoE61Ca4WnVWzIwon8zubWcc51fCiKIAGJSKkSzjZCtm5P17mKoYzyB4BoiSFE6XKPqGAOgECn02zjz2LUBY8b3E5k5E4qnIKyVuAGLsNHK1OvU0JmBlsTlHOldSr3QX35N4yymkcoK0qst0GvuOXiT8frduCyt7L98xkVhlwvH/qKrXsxZ9/tx1xf31n5NpJUXbVZTTaKva0ddlv9mfV5dr6Ytws0KDwQdNOuM4vLSTBVKgMtOMb6hYDc4gty4PCc2T2X1AHrUzduuYEDaEIW7Q598SWBEf39o4wzICLeDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nG3sI1771Qzwkix+7woUumXPeYpDKLLcIMXUM/nZXzc=;
 b=HmTg0RJy+iXrkjtl8lk00eiOq9/L5QrBz53uyW3z8WOBU2vYWGSFPClVCOoyp2qO+suBKdLX7aLJli/Q78jI9t6Ljxlu+TWowrUT+EXK8J66dshejZRs4BpvqvY6i+bPgkH9oP2H786SoQur+xaLRkxhRXb5H0YREIVWqPszlXHch6VV5OVjoK47O/Rn3Y046HldO8VzOedNF0qvCfluPlJRQt9YE8CEQwVJUmwc6cq7mlYu+BweJjAh/+vkBLEuq2H+L9pz3mbn5i8tgl8hpqTP+OAxdxoF5m3AuvdLj4vwW7y3QQK0tovhaynkwK+86htZ49Kx8HQYV85u1R9gow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nG3sI1771Qzwkix+7woUumXPeYpDKLLcIMXUM/nZXzc=;
 b=MLUZOxgb88Mde+78DEy0UZP5WVFusHEBbq/vjQIQIR8r4BS5W6s4Q8aQKGyXqKdDq+YD3vkzyihq8zM4+GZd7fMViQopAcLx4GHajrlD6Rr9AsisUc1bzBPWRbjcOU4KxtbcMR1Cp3oF+HFP8EV91//bwMu30rzG0ZlARgkOTv4=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 15/27] block: use bdev_alignment_offset in
 part_alignment_offset_show
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1h775ins6.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-16-hch@lst.de>
Date: Wed, 06 Apr 2022 23:19:34 -0400
In-Reply-To: <20220406060516.409838-16-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:04 +0200")
Content-Type: text/plain
X-ClientProxiedBy: BY5PR17CA0018.namprd17.prod.outlook.com
 (2603:10b6:a03:1b8::31) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6bce8477-072f-4601-b4e7-08da184571d9
X-MS-TrafficTypeDiagnostic: PH0PR10MB4408:EE_
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB4408DAE994838FAB82473B3E8EE69@PH0PR10MB4408.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	rjpbJIEZKnNEYKvuq6mDkATU/XSk8rTGWhmb5BtdQPXIoA12PnI264xUaR/rDlDVV+WBKqN46ZTvSslyjx+vvmVSavnTq+ToxU/lxZ7jwCM0jkRWS6565SYeRh54rE0dFknk774nCe4mFT4kxRJW4rISoJXfX4c8wbJoGp5v0wwqcH4JU7G16moP4wWn9rWOgIRfhBOwB1LuA93pH/xGSMRetF1bgbkziL9/ygQxpSE2uajI6pdYtdcdsWew1l1pv+/fFUO2zbgoicMFfsPWtx0PIki+XILDeVGZPwdSUDq53Fd9tapAqcEp3loBIjdMBb0UfTAhpnocXc+W1qv41QZq7+7KAI3lm7/gSmaSnoe5hbPZ07FRqYyZZ+/LLYsdG07rCd/VneFYYEDDvdulWVadiEsZ1wwRHndYdGyLL9xu6nplKlkJOnf7dL+hxO30blOO8AaZ+lOyBvqvLtDlXoiA/lKECDGrvAMWxiwtERcVPjR8NemBDXP0SX1oEjx5mO6URk+lR/Bmk59yrbCZx6fJAPMgarBNWzL1JYJm5UiWQeTg7a617m/3LT9d7lMH4LIBCNZ5iVN8sAtfq8R98eSBqPm/0FfXVV5CJK+RrC9qgdZshBuqRT9cViOcWQ3xitqcvP5D+i9t849caJMnshXNcwMAJkpJzA/DidseX96z/rOISWGxyab0giL9dGjWo6ZwK9hhF4BQqMVVo/PSYA==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6512007)(26005)(6666004)(6506007)(36916002)(52116002)(7416002)(186003)(5660300002)(2906002)(8936002)(4744005)(54906003)(316002)(66946007)(38350700002)(38100700002)(6486002)(6862004)(66556008)(4326008)(8676002)(66476007)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?otwK22u1FQL4H8p4tyeZC62SDKzQ2319TBwKD+0F5UmNPrBHHS4u0L6o2rWr?=
 =?us-ascii?Q?BdCuYhm2AiMo3Guj0AFAfewm0uazSezzFtLBMoDvh37dzt9lc99kNXH42YmG?=
 =?us-ascii?Q?ZSOeXycw6UPgFnYE6VQgzHH7lH3/eOqtm4S+7aSyK46h/AcoCl3LzHDZCjaN?=
 =?us-ascii?Q?FuVSwD8zgeOJ609VQQ62zQTPwh7+dVjDGpRojU38wJ6rZayrpeZaiSFbDq32?=
 =?us-ascii?Q?51kDYCIcVO23CVaL1If2RP3KziQzQJJ7M2bfk+ryCErPwZ6RaRj3wBcsnGVJ?=
 =?us-ascii?Q?yTegiaDAdy7fdvUVede7qNpal791NbXn4OQLOtUlkkft0eaxNhK3ZxmmPFzn?=
 =?us-ascii?Q?JTvm9ej/6pdqBL++5RATxdWTz5Df3z7J36ASOTWjjSkf3BcD6w3q0WS2AdGI?=
 =?us-ascii?Q?Z4AgqeeJTg2vkgjjPirXv7k+OhpowPR1tYlMG8NgliGRt8bC4IZvCwhXV1wW?=
 =?us-ascii?Q?R/LTR3xxNRo4hbqR7vrryQ8SM4Rv1kkBRQT/osU5Ivyw6DvQmYWK4GyvJnJG?=
 =?us-ascii?Q?/lgi6zxtBkpFkT4q1TLIbh7U7rh5KKGhEXtY51yjGeDtUfttvijKRI2xc42j?=
 =?us-ascii?Q?xN8x1B1zwTUTQkjePbxXhue3+JM1JcU+s4/EEOGl97MPxKpTI6PQvDmk8ILT?=
 =?us-ascii?Q?Jwcl2rD1xnpjGH4wXKOYvbvcpEb231x5hMBtbKQY5r/1/o1L6WAgwSSJvTNF?=
 =?us-ascii?Q?lOMnsIAAOBDMhVAqMCI2jOOcHbvxza6bSQ3NGQDXXbap6X9Y28Yyq3x2R+86?=
 =?us-ascii?Q?hovdBD/ZnL7xvGIPx4XwCSjPCcTet5+DxbB2FigmjYmLS4rjelW7V4d92EKP?=
 =?us-ascii?Q?CMW/91NOnWt1WqDG5yIOhQzcPdOws67BeoQM+gzurxCfVJMIY1kEgJfOnNkE?=
 =?us-ascii?Q?iyEPLhPfEzU/4SSEfYuMYD6kXoyqabl6TvbCovxQNHKTsZzZLlAWlF+LQbpZ?=
 =?us-ascii?Q?6v0Jcqj6Vv9D/fA1iZb9gelZYTTPNSLgtTeNXAOqI2UUqxe9RJHe4FF9lMEn?=
 =?us-ascii?Q?f6bZwNxMFFaaWHcc5aIFbm4+/sLXNDHqd+G6w/ywQLHZkJS6/Vu/k9e3xDoT?=
 =?us-ascii?Q?vug5WuyJo1lnQLnmFheQnARNkp4HeYIL1FrknslxhA6LQh/erpD3tNgo7vWg?=
 =?us-ascii?Q?JaiMvKKEhrOD/380Wb5Tf28f4SMOfOxKY9yVA4zLUcSA+rJx8AOk6aJd93Gl?=
 =?us-ascii?Q?DhNlK6OF8RnPjO9kkOo3ZPl3THdemigQ/7LL78QGlJA16s86an2DvDtD6Evv?=
 =?us-ascii?Q?EJAb7zDdA75RTRClkeU26zUQAd5UThlOw9U3jtIQTs/q3glc7vV+yHYn5FPv?=
 =?us-ascii?Q?Bq+sX52pOI1xJe4iWkfI5cUtiVSN76XMUiOrrGM4mNg3vJVwMFVbIzFCuB4Z?=
 =?us-ascii?Q?TXzp12MMNRG3rY7qCXW68s4Y2qtVYMBKFq1n4Wbxgk9HYe7CweRxtwcrl/TG?=
 =?us-ascii?Q?U10IlZXrd8kLdRypfjaEHhWwC/Bd28fJQiwa8rA6H6c05wB9OjRU1zyRJdgi?=
 =?us-ascii?Q?kww9ah519h8AE+kusJ/kIpzmR8+JaGwjhtORJIVIdgg48JPrg30buPZ63isM?=
 =?us-ascii?Q?fan3VsX71nsFWugPDz+MtxzpBMIFUALk+fjCLUzoa4ZQF/zS4h71ssrIQKDY?=
 =?us-ascii?Q?4kKJG+ghbLVRph8/80wYAQ6ZC7zyPOwMMVCmqVHfL/jaWd5oG2QLzk8o0wos?=
 =?us-ascii?Q?KaDNz3TI/FIAjzpDKo4lo8K285eBU+6L4CijIqnP3JAaf1HD32fV94E6u+OA?=
 =?us-ascii?Q?JU1Rv4Xgmgi17AEgwLo6SNA7cxvmtLI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bce8477-072f-4601-b4e7-08da184571d9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:19:36.9967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7z4HIuRW5zOTYnm/hMTpO4vuTWv+jkeYUlfnyT66exez8dXOJ7CIITksd8DVeQqY0+uYHTF7JUR/z8AslARHH0hcSzhm6hezqxwsLgDYqbI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4408
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 bulkscore=0 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070017
X-Proofpoint-GUID: Cnauo41eLSEi8FKkodYmDkATtkwCXzp1
X-Proofpoint-ORIG-GUID: Cnauo41eLSEi8FKkodYmDkATtkwCXzp1


Christoph,

> Replace the open coded offset calculation with the proper helper.
> This is an ABI change in that the -1 for a misaligned partition is
> properly propagated, which can be considered a bug fix and maches what
> is done on the whole device.

Looks good.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:25:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:25:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300282.512080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncImM-0004X4-Nm; Thu, 07 Apr 2022 03:25:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300282.512080; Thu, 07 Apr 2022 03:25:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncImM-0004Wx-Ka; Thu, 07 Apr 2022 03:25:50 +0000
Received: by outflank-mailman (input) for mailman id 300282;
 Thu, 07 Apr 2022 03:25:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncImL-0003tP-93
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:25:49 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6aac15f2-b622-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:25:48 +0200 (CEST)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236LenV9000752; 
 Thu, 7 Apr 2022 03:20:32 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6e3stj7c-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:20:32 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373GxPm034237; Thu, 7 Apr 2022 03:20:31 GMT
Received: from nam02-bn1-obe.outbound.protection.outlook.com
 (mail-bn1nam07lp2049.outbound.protection.outlook.com [104.47.51.49])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f974dk1tm-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:20:31 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB4408.namprd10.prod.outlook.com (2603:10b6:510:39::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:20:25 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:20:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6aac15f2-b622-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=m/EtCka1eaYsLn4wuLA71mCTmTy3QS19BJ8BeeqSuOU=;
 b=ZPHXH9uSshBLgJPOxwZdazVTI+3fnYybLxHdKrsDfbz5gkyocWDiaMS5jDrpJhY6dH5t
 e3roP2aEvv+YiJGGj3Z3QpMrYYwBTf9bl4ClquniFhHPfEJr4qm2Ds/oGFYCcZW7QCdw
 vQNumMDNVOrEzJbwGs4lvvr1Ud3XtzCYD36ZWDl8nKE3T0bnZudKB6NDXQ2OkGYiGJ/r
 DBND1X6o67sgshKOphRvOHMKUI7ve5ERUZzP10He02rnpHiV9o6r9EN38BXG5yjXwQQz
 Y28XuFlAWl8LJodhIZpPSjsQxEVlq9XeTW3ytrox3m87QG2hyIs+lG1EQs5JwJqYG3i/ SQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EmWMAF6RlPMTPIjba3406fZbNjZKdxfQZWWOhcV0o6F/Dp+mWgSqd97qlv6uvoeAtWXOaHeUbQ026BavoTQH3Jyi1DwXzIk4vscLyyPMEitpGfGtx/uteLJ7/2hMJMSP1aJcFMU2VJG6EZ7WgCWHluw5+mW49NiDWuugF2sFIKD0PuCxiwuk058+YFfQISJCWciRSvf3jUS6fkS53HVcM+7n5yzrjy7ui7J0oAMfeamZfrAP6bJnDv0icjxhbLsWeGrrMj1FdwDAFv0qvdrmHMupUrvKvw5UenIq2fyZRqbMQX2uvT/ujC+tDeccCJmyp1mLU7YPhvcIOcER/iFc/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m/EtCka1eaYsLn4wuLA71mCTmTy3QS19BJ8BeeqSuOU=;
 b=OGt2jLB3jVL1PllFYKxlo5TLcIdlllHeJdcqh60R/7oYoF89Wevj0nEHIOAV6otkguyyNaAq5MsyVnyvRiZLiySgnlFBhNnT0Ox4t+Y6T+lr8xjnXdRTnpR/ok6hugfx+ubzFxjMxS4+1i7nUQDdVrsXO8UeW2kyT6Oq/Zf420U5BdcVf8R3HgFBGTtuq8fT8V/Z4nagHTS8cr/peh0qOqfJ6kKmRm5w6VR5G5Onk3O1IcO6OZ2ZAUNw9brjn2X67TSrbILtF0XbFm9aq3wSE8vqxNzqdaLicVZz3KdilQ5BfHyfFYZCEGEP1Maz2x6xWDRUcuRqZECpjTjz4LC4tA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m/EtCka1eaYsLn4wuLA71mCTmTy3QS19BJ8BeeqSuOU=;
 b=lOBRSf50M7+euaHqSQJt/7bPr18Dmc+z+Fqe83qmUYBLJJ/bEGizprCo/oEl8XGt6mapacdyPV+3KGVKaLZ8is3TCEoJBoJgCZfZbSxXHItPhMnaVteE3B4spY8AJHFfSKMwrv0MJPLGFcP+6oYuxKa0fqqZkuzccC+75hZgJGM=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 17/27] block: use bdev_alignment_offset in
 disk_alignment_offset_show
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1bkxdinq1.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-18-hch@lst.de>
Date: Wed, 06 Apr 2022 23:20:22 -0400
In-Reply-To: <20220406060516.409838-18-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:06 +0200")
Content-Type: text/plain
X-ClientProxiedBy: DM6PR05CA0060.namprd05.prod.outlook.com
 (2603:10b6:5:335::29) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 87fc0a92-fd00-4c0d-f908-08da18458e5e
X-MS-TrafficTypeDiagnostic: PH0PR10MB4408:EE_
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB440840B4F7573923E7BC21928EE69@PH0PR10MB4408.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	iY05ploJTVvtgWX47V1zhW6/RV6XKHjvY5mGoivTIgaxEm5+fsJ7T5pfciGE+fLIKTpH8ii2QiiwiUQg3ub7h6z7rpyUzQlH3vsLuAlWoRBidRc5cn41WCD/emrmgar3U8HSdbI6d2V3bcVEp1I1zVZZE3Jm22IlXzCd7J7fj87GC1St+e94Wjn6qef1dcvvNvxfdfCyFLMcsHCxn8qJOJUT4WgJ/OhsyodiglU7+FgW+Rs/PDPBMZA2O7ZMFGkj0KgVZGx1FYsJQD2IoJ2wzEzTZB8aBhpmilagNjnTH0HGO0r02Qpe8wpoeXJqsPxV4IL0OZcDgOs6TalGjbFUOzL7iS4N+86+91RWxpHajsffd0X29FYGCNaG4xGNExGVWvNadmNpip9ivamEuFdJMSbBH999J4rrCd1PJva9Xo88GayAGURJO6/aEBC3C2XM1kwpuOkA6Of4JIphWVunTvG+o8P0ta42cNVbZDg/+WQAceg0Ql6THgb49ARJGx+Gb10CoWdph8MIozxbE/lE4kqDHF4+q6ZraItYZV+JHaZk7PBN0meCBzLnygnaz1RO9HXP9NOp/oM05qtfaRRgsY5tV5fZITGEAYGeC8Ut8o1OBwVZg9c2OrqTSqRnVReRpYtyTkHMC4Wvv7po2WrWepJwdnglLNnpMlV+mbcxQ3mF2FQoAxhA1yvSRc4Nuv7JotojJ30sJTdxksjIVUeoBQ==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6512007)(26005)(6506007)(36916002)(52116002)(7416002)(186003)(5660300002)(2906002)(8936002)(54906003)(316002)(66946007)(38350700002)(38100700002)(6486002)(6862004)(66556008)(4326008)(8676002)(66476007)(86362001)(558084003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?WYwG50Jvgo3EAvl+oAiS+1EcYzJSp2a+tS4uTNe1bVEEGMy/dSlL6N8ODjjr?=
 =?us-ascii?Q?2LUsW+GdVfcHLijnMn/oRfVm9d0TnEsFkCerkJnRxLMEZLGAl2zW7axQKdPo?=
 =?us-ascii?Q?ANSQZ49XOn4WxRnE3oK8HiSPdCnd0MtZ2RxGclgXQO02zuTkxhRh4v+PiHIi?=
 =?us-ascii?Q?UHMnd7yLKOoj3gi5cjWnfKnyP2YfqyjI44tOXNTGMVCeStelXYQkkfmPV5Cw?=
 =?us-ascii?Q?1rgaPJKuiZCRegtsndOOJFwF5ZoopSOBa9hFDTcn0YZTkbXINBQwzMeAU2Sj?=
 =?us-ascii?Q?Kj/ZWdmcyY3IVJbZlN2/oxJi7dz2yiwEF0dHpsOkD0FG9zwIo1a77kV+pXxo?=
 =?us-ascii?Q?MEfPreCpv3DqnIePj2WlLW9l6LnEbBNo20H0+8cjO+aB6/43TW7K2eKdbcGJ?=
 =?us-ascii?Q?v7G+wHqljHZjeawzrdqbJpDlh4k2oQpYiFplYHOhhmB7J0azEycPm2educ3B?=
 =?us-ascii?Q?lH64+iuwkihF9Pi6EJlzpElscvZfUtrWdPFP6rwE2itkAWDQVNn/y8huIpAx?=
 =?us-ascii?Q?OejbLL8SvvFV5wWNOlDRec8fWv7MYSvggEJMrIqTvmPGsiIlhnlG/n1KjUCl?=
 =?us-ascii?Q?5xvoox4hu/WU0sMZo7yltEYYxLnougfchXjVjc267Vs4mb3yWuMFikGaQaR/?=
 =?us-ascii?Q?AGgII19xr3fwgG1WndBwhcPeiL7BZudnUaqxSXWmx6v2wCjM6WyJ6mHZiUum?=
 =?us-ascii?Q?zK2swo+sdDJJGIau2kXI5PYatR5KgUIxFO/wuJhU+tqmIFTK8QYk6nt+2nrQ?=
 =?us-ascii?Q?CmW9qebYN2uZjJWYVihVukKxrJMOmR6VQiKGixLZqFxNWavKVIV8/tXK1o8P?=
 =?us-ascii?Q?5rP5iQ9kSpDMQazweqo4JYW77AyJccQv8uvL7s+6GqvFqmXpugsmRrfTgNGO?=
 =?us-ascii?Q?EVaRvVUmTYwNZZGbg2Eu7u2LkfidYoeFHFq4me3mheq46qm9HMID8W5lJCdk?=
 =?us-ascii?Q?hMtExzeRzGhPOAt2MgBhKXNyyS9IIGQunLpcx5eQXgHig8LFSw7OsgibOx3J?=
 =?us-ascii?Q?9RTzkls9h/4YgC4dk31S7ckTMbqlXHNyfTn1lu93TozDS03T2nX8UD+GIRL0?=
 =?us-ascii?Q?CZjr1d4mp2g+n22DZ32Ki6ZoqREAIWrY23ZgZo/Tj1rPVbAvq0/HvH96SbVj?=
 =?us-ascii?Q?ATXGfv2C30DbhuXB8s6OScJlP+aC0PyDZ6I2fXU8pkwPc4W1mzfBT6X+/Xst?=
 =?us-ascii?Q?axLrhK7Dno05Y+OS38SM/7Crv5cxx3/OtllEz4Uu2ZTSGw9tVKl/TibYo7AL?=
 =?us-ascii?Q?Syfauvn7vMUzXyzgwPxP0A4FxZfNDANLExKF7XJYojORdXQxA68YbvCbDmgi?=
 =?us-ascii?Q?S729jfTBGFjBsbyQHWStBoF0TPKh0sXj31uHgWzeBwnLBde4S2gFcQ6mca8r?=
 =?us-ascii?Q?takaLfh/5u9/9bbNuB52ixkFVJtsMs0kJSiYdGVl9WwbVvWIqkBQ/reISVTv?=
 =?us-ascii?Q?jFEXxaJVmyOMqdQ3bi1ooxaCb3Or+y6uCFT6MLEumnNeavwA0wiuNdt2PPNk?=
 =?us-ascii?Q?EezKFVLfVzNFBA0XU9tpv88JgLwLWbaCWVJQXnlKXKB3yoNkFALRePTtHN3l?=
 =?us-ascii?Q?EcZQpE3lwQPgn8a/croxHMjWF3r5lGR2oEzpwxnz+MRC2hBkPWjMcX0XS7/S?=
 =?us-ascii?Q?m20OSXL3DeHgnR7IT24C1qTUbz/Lc9Gya0DFtvnUJviUo71gZYuP1mXYNbCj?=
 =?us-ascii?Q?yVU4yMTnArzEV8STEHNMkNGwxOMX3w6ctjo5Xd4W5ubkVwWfd36Z75Po8ReI?=
 =?us-ascii?Q?054/ti2vBNNpUEpz372aNKfV4z9PBEA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87fc0a92-fd00-4c0d-f908-08da18458e5e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:20:24.8162
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VFEnsGp9iNzofXDdWVUeVagsevQzAzfKAOUZ7RC8FjwjaI0mXTbFbRwcCPA8WoGfksB8fb4MPqkE7YwP7Z8bcHVScgdeWqmGWAJHw3IuqJU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4408
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=899 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070017
X-Proofpoint-ORIG-GUID: vYbDyoypZ9KFYtB9fEf5zDVkTy-enKed
X-Proofpoint-GUID: vYbDyoypZ9KFYtB9fEf5zDVkTy-enKed


Christoph,

> This does the same as the open coded variant except for an extra
> branch, and allows to remove queue_alignment_offset entirely.

Also fine.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:26:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:26:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300286.512091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIn1-00057I-1e; Thu, 07 Apr 2022 03:26:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300286.512091; Thu, 07 Apr 2022 03:26:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIn0-00057B-Ut; Thu, 07 Apr 2022 03:26:30 +0000
Received: by outflank-mailman (input) for mailman id 300286;
 Thu, 07 Apr 2022 03:26:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncImz-0004sb-K8
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:26:29 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 82704dd8-b622-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:26:28 +0200 (CEST)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2371bB8b014737; 
 Thu, 7 Apr 2022 03:21:10 GMT
Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta01.appoci.oracle.com [138.1.114.2])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6ec9td09-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:21:10 +0000
Received: from pps.filterd
 (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373FMdG015367; Thu, 7 Apr 2022 03:21:09 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97uwanbv-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:21:09 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by SA2PR10MB4748.namprd10.prod.outlook.com (2603:10b6:806:112::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:21:05 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:21:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82704dd8-b622-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=U+fTrz9scjvUlmcuDEtUdP2MIqdifGmBnbiweLe7F2I=;
 b=YUMdnGZuzek/W+HawPDaaLfxI+Yo6VABZTXVZ6R8VbQc924wt04u0sirTy2Iwmbk9FVl
 /OpgKryhR1e3Y84u35EcxlrfG+CRudZayKtWXhZ58oLzkQVqUhknU/gQ/BTvDtmjSP/l
 Ke+S1e7qTo6WD0F3OCHx47/sHT7F9R8sfpJ9Uy2hQ3h1SeOp7P1QTjGq79xi+8LNUyVf
 PTMBYdQrUC/zUulYntbR8hQfeiAXG7mrqrQYIpxuy9v6IPl+ojNDqwos11kNCNNxNXPb
 iccZ7AYkq/524guLzOsAePFN112wVNxb5djErynah9vV1tKNLr9L9K2gHlamHeLCIRcw sw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VZIQz/j1Fb5IU4komH8ez3bVmtttyn9V7ShNIx/1Q/J/bWD261us7A9/TPX06DwS2mkn7BChyKnN4Hg2CYGlufMZR7dxhhnE40r5IWuVYjzKyAewkdNn2ymyYJSvH5qFhi1TvBgqd7Xr4eHz081/YeiMawV6m0xnTyFsFVoFgV6QhBl7v9+je1ZBYDNIun6lqR2RLtuscIshJopGo3k+vcNOtOd7vpw39EvoPBg1QsvjUSZWkGyrtaQvM+jKMGUzIAYhSYmMFy05tGzQLJjKHK0SrRUk4C6a26R+qXROt1HjAXjv0aajnA5ls6+3pFkmcCEwc/ccDjfShNLP0SXdmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U+fTrz9scjvUlmcuDEtUdP2MIqdifGmBnbiweLe7F2I=;
 b=DVrCnGwvP++Elo4tefRs8S0K9xet8SIuwYTGYszrLFS0kB0QDUiJtdUnZ++NXS6N0ymlUK4gCwNLJ+8cbdCNSp4SGsnWtzmldtLJlxfrin8RMYUq1MhjOOFrKD3DRSNxcdqqUdnWPM1UcqkwJoWb3P1tXX5ioDjMep+d6DR+OlGThrFwBwlGQz8OJ2nDPmwQunsTtIIDfTudH5zBt8wb0YBdUTUS2ryrlndrPouH2Rx9dDq20Hi5kE9hg0zXYUz3Ag+GGSDh8vgE9gGkRTiSF7iYJEOa4UK9tFG8LxYZvzc85S0/4BYJTxNK0nyxebwUYXr7CWIgGdVXdhp0bOYfQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=U+fTrz9scjvUlmcuDEtUdP2MIqdifGmBnbiweLe7F2I=;
 b=n6+ILMx/lQ/iZCxB/hOJR8YGSZRIaZea8Df09jCCjgZ8OlXeLUbalIT+V4dXlarVBJdC4RZsLkoypik2s6KdONmO38tGRXYkPsTC1TzEiO0A4DzLQxgc0lMVLjNjMI2zzGUAUcp5oSRB1jswVpBmemVd+7n8AVKTahlyd6OSe4w=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 18/27] block: move bdev_alignment_offset
 and queue_limit_alignment_offset out of line
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq15ynlinou.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-19-hch@lst.de>
Date: Wed, 06 Apr 2022 23:21:03 -0400
In-Reply-To: <20220406060516.409838-19-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:07 +0200")
Content-Type: text/plain
X-ClientProxiedBy: DM6PR03CA0026.namprd03.prod.outlook.com
 (2603:10b6:5:40::39) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2a4e7c4e-e224-43c0-eb44-08da1845a688
X-MS-TrafficTypeDiagnostic: SA2PR10MB4748:EE_
X-Microsoft-Antispam-PRVS: 
	<SA2PR10MB4748213FE9D4050DE86175748EE69@SA2PR10MB4748.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	DjOT9NXGZpB3sgRJJcgUJ/BSS9uBxOPNforpn8fJk807ksHl/anICaf3eJNywVGAdFiXwLjSdw1DYG5Kz6W8IVurfBB826TDEBIuwKWEQO1yXm3j/X0bihSfBBWL3FAXy1rgQbCrj/j8BRUBc2IAiQRVDVgEgp5uIXfqlsnl8OnwVyFuX6Ce+3tIsYhMLuFGwCPMixdP5EXrMrMpBVxcgkpnoz6HWNy7sRAD76bXi+6Cfuc/1EL4HCod2AKGSwg6rorZ7Julw1sfS0RP0v+PkcruyX0eIPRv5ZX6yFxLwQFyJcFKjTGgufq7B8CRu6gtRuIW61oRS7e1w2XNGBDy6bay6KjJ0CAEy0jWVtNxNzj5YGwhcPz/NLSqO1i9AvmvPWYSOyzCCpJ4OxYoFV9sNlC0f8jbWNTFOtFiPBPNCCfDp4S5X+5LdKOAw9+OK402XXtGcyrbEdrOk1vVEP029PkhHS3dBEwk8sGA9lHUfqumq3fUhKyR8dsnA6rA6c0V5MEPTfIpR9mwxMXaUCZQuGbicHzLEQ3Bj3WLSdrBbG5in42MzL99flygFqM5ItkI0iRjcZ/B/Ydd48RM8/xO0SFYNvmQCgFku5XfQUJG658fY6LUwwh3QTvkLM9GvBnSrfn8VzdXPWQDzR/Hm1Gh0fQoJ5czdXWlVZS9wGgQnzFxmYxHtAn6xAowBwd+dXqxbzO52pCHdIYpQPgVcuqRxA==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(38100700002)(38350700002)(508600001)(7416002)(8936002)(5660300002)(2906002)(6862004)(66556008)(4326008)(316002)(86362001)(54906003)(36916002)(52116002)(26005)(6512007)(558084003)(66946007)(66476007)(186003)(8676002)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?ed8KfOdD8BWFvOLjceSlZe9U6fC/CRjmtYJvhqHgLWj1Qzi2JWDev8VVm9Dk?=
 =?us-ascii?Q?fX4TT0IjkA47nbTC07tXTBoxj92TWjmke60BtNzznvjMqlzj4H0pRESnGFcL?=
 =?us-ascii?Q?ReP/cud4XoGiGhylfNKhKoRB4LQtYFul/e6gUJWBysLbO6zg+csEizV3X7j2?=
 =?us-ascii?Q?oN0D7agXA8mJTmZAMmxOvXkSKlH28yrdPaabPn/A9jCli/xoJPTc5M83J5yL?=
 =?us-ascii?Q?mhuB3V3ss++8NtvwHmQRgz8iXR3WLcsKi/fwhrXCx7R+iJZVz1VFwlBYzLno?=
 =?us-ascii?Q?PInan0qNsvg36QXhREZUayPq3icDLQu64IsHfizxMnTw225ULdhnc6Q97J2B?=
 =?us-ascii?Q?EYwbByEAg0d1Qi79SEj3197IQ2tKdU0lUpFlcba/HBog9knHqqB07/cC97kG?=
 =?us-ascii?Q?dHhfNW6Ms6oyqxkWr7TfJQenmjw+Odu363ITfRXkoWiRYprtPuZg8wYAzT3q?=
 =?us-ascii?Q?HTGFQ58gjjJ1ivuGAy9jTqLkXBUzpcQAbmElQubR0D6w2b7kZ0ipHshvaVP1?=
 =?us-ascii?Q?ctT7airiTwDLFFvUy62g0ZL1n7hYzrpkuYDy6OfwIgB0HGXaKSgYuINLofY5?=
 =?us-ascii?Q?7S2CGX2SpLCKBgyRk9WgwX3r2Yek+oSjJW4wOzebtRbMV1I+pn3UmMxqH+qr?=
 =?us-ascii?Q?iyLQMiGUdTqQ+Rd5rUVB/8hgj4c6XViDbVrQVEgZbWEevHTQDtP1Qeoiy//F?=
 =?us-ascii?Q?F/UWf3TxqwkBReCMiGZAbwHpFUbUTGaqsOAc4OZX0bQ9wIifakpeVVhTT7LF?=
 =?us-ascii?Q?ZvkuPlVlYf/NCgqtlRLkufmvvSMkGWGm12JIg53lxJAOFdbnJ/8uhw4zbkac?=
 =?us-ascii?Q?IbfOAZhlWgiOgetIcC0Jz8uFX5eR0s5PpFze/u7+HIpw+PMI3JrdYz1NJXLJ?=
 =?us-ascii?Q?GG1Ydpf8waNPelCyu0bMpPn4KZIMuSfsapXcqs7iqu6pSAewuX41dFhHwmas?=
 =?us-ascii?Q?1qQ+2PYBc8N1tzw4lIxpIyANFL7TaSOgeYdEF7PrYGXHtMm0CawpZx1XZ1iy?=
 =?us-ascii?Q?/bBX4QgtT9+95VDqUTVF6tmjSyOH/CoELITwNKqCsqnIQZvVnGqm4/SjXfCN?=
 =?us-ascii?Q?PEEGMSnK8zFC9gdobEWDNhr7xKuVgxNSQ5HIJu+76gIuWJmZCM+T7jshrjJr?=
 =?us-ascii?Q?ZTsUsUrxNWnbWIKsmAelPeT9s6IKhO1dl4gEyJ5fGARnTT/qXpUlDFdMfv8E?=
 =?us-ascii?Q?fyQ+d5VfTTO3hlTM0fmibyZ/L6JWK3ggzJWI+xyHDlwE2TGt31vwKH0DLvtw?=
 =?us-ascii?Q?9/tqablQh1kZcndJni4723IEzlLjlPi7o8l/onyEwVxfAxzqjXj0+jr6WpbH?=
 =?us-ascii?Q?UHIth0EHdnXF6ueUg/1hQPkZq3Ldrla7fNQN05q1o/LkSoWpAc9N6o5xcASa?=
 =?us-ascii?Q?hTad7oYreU4T/WCuQIliJMeVcdESB3ai0n0SmUaAxGJPNok3MyqpqJGMDnTh?=
 =?us-ascii?Q?zKozK9ZeWq11HstdRq3OXexs+utwnwRBMb0V6U6DWaZR6mwek1QbrOR1you3?=
 =?us-ascii?Q?oRzKFW7hCCPHAO9KoWPU99SnlC0QRwmXDFZn2LfwO1W+IyQp2yf7jJHy4cC+?=
 =?us-ascii?Q?bnKE6ST8ltzVlbhHG6qjzMyRwCtLyrBqBYwskMFBos44TunRCxGJC1xaEVzy?=
 =?us-ascii?Q?reUZI3VZbBZD6WSgZT8nLvh6FCg0lJGvMLC7SHuHGvTez2xLxtaOtjfl4mlm?=
 =?us-ascii?Q?kmB7kkZSAQlIm6N+Oes/xh1eXWWDzhTUhcg0KiT38d53sryoHA8zvWpgSxco?=
 =?us-ascii?Q?Azb9HyFJxo9vqWlUYpWy4CXVjw40yxE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a4e7c4e-e224-43c0-eb44-08da1845a688
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:21:05.3709
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T/WlI7i40n4VOjlex5MfakSjplwXRvhr2/q9rsNGMZXOqMWjhXVBrAKp8zt1ZMqkDxKK+4gPVb28EAbtiZ++8LZxftn48EIY41evxMiUqNI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4748
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 bulkscore=0 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070017
X-Proofpoint-GUID: 5fk5of0wXRiyNRb822P8bYa2EqANeN03
X-Proofpoint-ORIG-GUID: 5fk5of0wXRiyNRb822P8bYa2EqANeN03


Christoph,

> No need to inline these fairly larger helpers.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:27:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:27:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300290.512102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncInd-0005hj-Bp; Thu, 07 Apr 2022 03:27:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300290.512102; Thu, 07 Apr 2022 03:27:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncInd-0005hc-8P; Thu, 07 Apr 2022 03:27:09 +0000
Received: by outflank-mailman (input) for mailman id 300290;
 Thu, 07 Apr 2022 03:27:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncInc-0005hO-5X
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:27:08 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9981dd4c-b622-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:27:07 +0200 (CEST)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236MuBtL000849; 
 Thu, 7 Apr 2022 03:21:47 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6e3stj8j-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:21:47 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373KQC2014128; Thu, 7 Apr 2022 03:21:47 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f97wqsnk9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:21:46 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by SA2PR10MB4748.namprd10.prod.outlook.com (2603:10b6:806:112::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:21:45 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:21:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9981dd4c-b622-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=MwpJLE0ch36RZGcSE+/AeVbeOa9UnzSlj2os7foWWmM=;
 b=BpVrgP7pZM2rYu5nt2t4F2ysbF7RJDV+g9efkP5dlSDOob3JAcqdY2u9AXbeQp1X2+Im
 vMrro2GAz9Ynd9mCgwOafDJ8CRk2pV9i43l+iHJewXJYg1reuA2CVL00+vBPMQnjuau5
 vzUTtYMpLEyWtLwkvvwVt2k+Hw7QsrY5PMlkAensS6qqS7A4356N8aS5Cr2bs1Z9EJbK
 5xbQEKdb9oE2mcV1Jk/OLsVAQA2qfyM1kNXeP24E9wfqVwsb76trveL/s5sMReitLnLP
 t/FS7582ACLN0GXLcJvvOyLgj6pvU3LQW5g+LfnQ+fEkQa9/g0dqfQwTNTetZHI1MdxE 8A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AdYNcQuSrhOdaCLDcaxSrJ9V7v6c5+HvXVHxNrONOGf+yVIh2n4N3VJbuF1RjHeM9ivvFytMVN+R2YioTghaLlxHNpA0CRv1ggchKbjx3xKkrWm9z8CO5qaJlk9OvtfxqSv9vPdyalQE1XI33YArvQn91vBpqqwmsNJmc2o4pZHJ58RU5CLHQR2RQdqA7buz0+idItVK9H3zNLsBORM2bcfn4gZkOrdgXZqUGSRMKqklFZM1mEfxsJataKVb2A7Ebbw10PunWyi6/yC7uoXGkHn4fUywx4YqMO5PFlEMmBCUnbemYcy3TPZwWRNJ2PuIeG61y1o9SbDYjeqbsDHZZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MwpJLE0ch36RZGcSE+/AeVbeOa9UnzSlj2os7foWWmM=;
 b=NxdpyKSaHn+GZcCBwC2VICfo06WxGOvE66KBzE6zjbc0DrjSzw9+7N8Z92bdI+mlg2X51EUbjtrUSbg9dIuHrVQ1kBJOxcZJ93D6fU4hn/wcifeFQbErydgNCgdWvKSyK67FEOZSCVPSKJiDCKi310gsAlVcceQtY2EB210+aqkdkXCAfSkC/X5BRRBE2Jp4dfS2OUMQVCtGqJL7B0Nkc88C9g9hCMHu0y/AnpPAMVNK/9CsccTWZI06RsGdyGmvHI3+AORPuQT9YKaY+hVTEHX5XeEmAFaNrITNefYwOpFM1XBGlOtwCOV9spqNnQ+4shEtt/jBl88va8C5Q5ZGrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MwpJLE0ch36RZGcSE+/AeVbeOa9UnzSlj2os7foWWmM=;
 b=tMcNZkT5xkLgKFbWVgLhopqHkckF7XJnf18ykVhh+q1o39W9Ccu73TKumF/tHb6zkFnfB9v2K9ZOK8Xvk3i50Hao7ter1Wg/aUZkU/cRwOMOd0Ly6EPFjQkFesTlm9k07ftmb2F+sM5bFg7FaDa729P2e/lXrqSSrpiBTn4PWiU=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 19/27] block: remove queue_discard_alignment
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1zgkxh93c.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-20-hch@lst.de>
Date: Wed, 06 Apr 2022 23:21:43 -0400
In-Reply-To: <20220406060516.409838-20-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:08 +0200")
Content-Type: text/plain
X-ClientProxiedBy: SN6PR16CA0047.namprd16.prod.outlook.com
 (2603:10b6:805:ca::24) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b782a8d-1555-41a2-ce83-08da1845be65
X-MS-TrafficTypeDiagnostic: SA2PR10MB4748:EE_
X-Microsoft-Antispam-PRVS: 
	<SA2PR10MB47487CB30D87456E26BD01E68EE69@SA2PR10MB4748.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	r3APAev8/yNnvPO2ONPsd55TlLDafMD9/0KkFFmWyCugSoqV/Bo9f/xHUkJ2dYIygJ0zF+rqAdn43HcZNzOqUFsJMUB/aFVj8+Mz6SfiyBDKHKpYoRD996MsYB3gS3ugUG7Vnb/rqkZ6594ReLDXgIpm2+C7RHHqDsvApyrsCc6T3q31HjAgwLE3Rk3o1zLDHWGHMgCZHPLDA9sQuSjGWCvBwEJWlALKdtH0zLhbe5C7mrG+897oLKkM8ie0Q9581uCPEBbNWuFdHFfJOE7gtamyYHpU3mphGp0dLrxZuKiY6Kjb8j8/Z08grsfgK26C/C3oESQHVjew85Er/9KYKOGEX/pBSsfqVDykdvwXE4t8QkOLSv9qYqRHKlDsMlsRZ5IKSnQsRgZh1Imyu3Gg6b/IBRmXhhJU0KyohOY3kYjFSMzPBqmkEBxj9LniXdK6tW02h0JWuSczcfajK6TnsZQQmZb1+pZSwsSUL1m7urMYWtXHpst41qLNOI30C8yrKr7ARifJ3bhZHpHADw9J0oY+LQv4enaY1OcrawmkzqzIPvnBUQ+UhloPhZIngRq2+oLs2cBeX1ozBUqD6e9/u3MVShyUdiR9ZJTTwlgqL+0BcdLUgBsaMWvT310fiDBpMoAK/XvI8NRThp0tl6EABJk/yz1iFQeHm7Xt+1QvVkuUQI9zGcGI8a4BgL2oi80fQVSyG+ppEGPImfcl19rIZQ==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(38100700002)(38350700002)(508600001)(7416002)(8936002)(5660300002)(2906002)(6862004)(66556008)(4326008)(316002)(86362001)(54906003)(36916002)(52116002)(26005)(6512007)(558084003)(66946007)(66476007)(186003)(8676002)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?uZfvgnwv9ipZot9FZJz1YPgJlpD+RpgsBE4GZ57AHVCH8967zIhDPxGzUGcG?=
 =?us-ascii?Q?MCJOkbGbDiv6hmtBKLdr23Kots427V/tH8h4uGLEEbOr54E2HRNbGiuXwesX?=
 =?us-ascii?Q?pFAvjm1u9bFSHNbXXP0pOz0djnwDIRM5+29Yu2M/tL3khxcWpqer4TNoG9o/?=
 =?us-ascii?Q?hhstfA61ymEDe+1/Q590nOjpyF6M4pFdSl4W6B97a+OyCosadCZiI4G1Fpt9?=
 =?us-ascii?Q?I58Zj+/6WugYElT4dlVxUm3gEk+egO+DgqNhPVANmMVlnO3HM8gSArCc9psN?=
 =?us-ascii?Q?w0n+r2LxgNR8U7D0Y2ayWJfmGRpeJg3b7AbeoBHMM9kckwBqynR7L6FHI0bM?=
 =?us-ascii?Q?tjFes7GfvFCEN1jauYK75BLTWZUt0VJrczfQ/Lby2B0rBeKvR1LWtA9pGCMA?=
 =?us-ascii?Q?GVy3FeOSUTKn7De9qeAdyD/GewzDel6KYu9vLEIj0FqPA01eD9nLQQcY4KaM?=
 =?us-ascii?Q?im9/iP/wrZffpdhUNYA66zFYwFWNb1EFCe7oomRT04/nMOGqqTD6nqPR/ZcB?=
 =?us-ascii?Q?h3u8yUgbv+X6W2SW3FHT98GOAivOhpWcmuIEwUmK/4x/+1+UNXh7qCtAIIUZ?=
 =?us-ascii?Q?j2QbTXOQfcGNieGdYaQ0XeSnhGltIDkB/3z5uCjLN03bLoERZOlIfYq0soxW?=
 =?us-ascii?Q?Qwp7k9y6qHJWAzfjCvrgA7esjsswwwzk2CqpaH/tC+Fn6lGfaJlIIDXP38R9?=
 =?us-ascii?Q?xe/IdQlRJW4rrn4KL4j8c6zuzIO/L4PnjOgu9AJ/neCI07U4I/LYGlR/u8Jp?=
 =?us-ascii?Q?m5wB0iOJMvn6+LJ263wdYX7RUArGH1q3H+fhEKnqV9hzx92jOXPiw01PWjbg?=
 =?us-ascii?Q?vEkIixMD7cSFxAXjPUShOlDk9wI8WslUPWerEw2c5tv7OqgSdSULfAzTTi3y?=
 =?us-ascii?Q?PPxiYDtMyVkZf0xkjicexi57XTLXbdqUvKcGN6E4BZMKvGh0/25cf3/oQBFT?=
 =?us-ascii?Q?FFPA+0lPq0drb297tD5PIRi01qu2JHrRMFP0hnPYhh8M860RsAD5dU7k5C8S?=
 =?us-ascii?Q?6NgEikj7oD+bdJxZANBdxtsRgTMMXsNajOyFOsDhAd5+YzHq1UQ0k0NAHu2U?=
 =?us-ascii?Q?P7yK7hfChwn+FVcJGLheqLgIgB7f/2oMV/LXJ6Uk6+9qG0eoWwFdIlMj7Gw1?=
 =?us-ascii?Q?rBZNQo2kzSlDTE0IJLlwPRwfSFD1Y7gitUWEkm/3FFmrneZF3EF3kUFoz7Tg?=
 =?us-ascii?Q?+GqgDsOeAEeqSBcC5c0Jy5OguprAlA3wvp38voi+VW2hefSeMaDn5jOuzUQ0?=
 =?us-ascii?Q?6uGXy1zBzD1CgBGxk+/g3jCSW8gxe/69C+OOlP4aCoLAK1j+DhBwG2Chq3Gz?=
 =?us-ascii?Q?MuBTGhYRXVsiR4Ikr6Xmlv3dNPxG+dKE58+0jBchks5UsLE9a6vOkIGBVpAN?=
 =?us-ascii?Q?wQpGXx6BKoymp2yxKp/+ESJMIg/yPda4edDCBsRnf5QQthsiiTBZwlt8Zu8e?=
 =?us-ascii?Q?au0pW8yGv4Gfy0maGrnNQU4WAhZ1WdWJXySCNNagKrAdLipcysPKuoSCXWNO?=
 =?us-ascii?Q?SHaEyTsyw2NWWL+iYDZcAZe1RHA5HPX0GIm/q8gldgzeBcbeyWb80UcoaDaP?=
 =?us-ascii?Q?2nFduYeVlIHE5l3nMu8PzEtIPDWRQQ+kHab/5nFDgc4gPaqugedvRAtOSyIL?=
 =?us-ascii?Q?UcpzKxRjKCUbjH5ououikKpy9LgPaJdFIrR96Jn3p/LvSYOSTW0CMch+G9ef?=
 =?us-ascii?Q?oLZ8ZO7HouDicqdZEDjOt6aJtfrqvX5aqAJZOcl5tll7mINz8kEuEayOLgYq?=
 =?us-ascii?Q?Dkqh4HaSPMpBRLL3L3RRMAX+WtjMMOY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b782a8d-1555-41a2-ce83-08da1845be65
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:21:45.4061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: opcVm0PkPXaf4HZxnKxOHb4X+rGBtfP/T3ZHqBFIIJITSXvlzHF2YwjgNEUwD3W+CDMVYkTMzJaqIE5gg25nzagEcSQ2vILQxddUusffC6k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4748
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070017
X-Proofpoint-ORIG-GUID: gRrzI3-NrkjWnSzj8q8OSLqgsw1tXcrt
X-Proofpoint-GUID: gRrzI3-NrkjWnSzj8q8OSLqgsw1tXcrt


Christoph,

> Just use bdev_alignment_offset in disk_discard_alignment_show instead.
> That helpers is the same except for an always false branch that
> doesn't matter in this slow path.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:27:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:27:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300295.512114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIo8-0006Jz-R5; Thu, 07 Apr 2022 03:27:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300295.512114; Thu, 07 Apr 2022 03:27:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIo8-0006Jq-LU; Thu, 07 Apr 2022 03:27:40 +0000
Received: by outflank-mailman (input) for mailman id 300295;
 Thu, 07 Apr 2022 03:27:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIo7-0004sb-Sk
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:27:40 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ac38c4f2-b622-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:27:38 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236LsrRt004892; 
 Thu, 7 Apr 2022 03:22:19 GMT
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d932mqg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:22:19 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373GhBh035403; Thu, 7 Apr 2022 03:22:18 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97y72nm7-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:22:18 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by SA2PR10MB4748.namprd10.prod.outlook.com (2603:10b6:806:112::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:22:16 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:22:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac38c4f2-b622-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=tAPmbbaCkvVZPvRGbdErqYJrUZb0QsK/3MVtxkvtM78=;
 b=U4YAcWA4jAisZZK//5B1Q0Bz/XRLUueeIrA8QtDqWbfRoJFt6ww6ZmEUob2Y/jy1sDg3
 VEi5fCC9yWTf3nvupLHm/YIzJPr7h7ZwuiJ+JTcuJZCb5CbP7NmlaLnAERPFAnOYbOYE
 +h9ql0/JQJboCoKu9y6jxoiL5yjQj1LOXIcN8Hk7tIedSgevMXYjg6UChMxtQr1PKZzU
 NtBFsW+j6C9r8V7FhFq+QTNg0BBhAXzF86OpyuXQw+KKI1flFf3QrS7/jbrHoGmM1fXm
 GO9VW1PZsX4FHp5zwhKsd0faRseJ8aBOcK7adMvInz51QRy6VmWGQG1Ss3Z2TSDrpSxd ZA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RsBwi7g0NwGQg6t1xP5oMZVKwn3MtYRePunjGc0MyZrXQX39LqrGcGdil+TbHna3HcJWZNny2OQmlqdDHk7pC2rJyQ6k4Fz8PeDcp7ZnQMrNu36Ea773LXoqIVir6Pbi0oeDDP3nBQpwnpJZVMJSjTWOfcHgAvw9dCA4kr0yFv9J7Tq/2lOfNkbvojuPVZut9KcS5VOGWZNcDE7BtbaxdXfvtnFvZK2FIqW21dkSww6RYLrY+Y3vUlDCSDGQ/5N8eKGlhs5R6M/OFtjJ0plklkTb6VgQ8UK9Du+vLtLgH9dww89omTtOZ0oaEpdX4UaumJemm0QuO+bIb+aa7xWqrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tAPmbbaCkvVZPvRGbdErqYJrUZb0QsK/3MVtxkvtM78=;
 b=JnBwmgC7LFwrQh4Ae93PWvlnXQ6j3VAkqIWP48hbX1N5Z+JdPEn4AqF3m+kZbw6+OjH4K1yWN+vqBbLNRRH+JPXWFPwL/nRR1kHwd6VEORJM6aEdUC1selehpRYRCnI6kzEDnj3N0u+Cdi2D+Nk/NhKeY9HzZD1iCPHHpwIDVqIAmrLHMTMXvaOsbHbg8tRAJWp1LiwWqXEpzpSaJ4oF6f2MCZOl4L92Bv2HQMnPx4vKhPLZSm+l4+1630WyoORr4Und3Ygb1/3TopZKYd/C+zh3KPvz9TsHxahRAjFHaLU5oN/ZGQWJRCPqeYKp1we0g6kRKuF6edEkgYe/p7jBUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tAPmbbaCkvVZPvRGbdErqYJrUZb0QsK/3MVtxkvtM78=;
 b=MRrjdMSLg06qPTU3S1SGeGQnPR2zAejXn14jAWS/xhEBAkGh8Oc9hT6qEzuPeQitZqKnTnE8YfcgmlrYrC06UJGXooPq++fgLAPl20rNvALQPvprAiZvRAXk1/H4MNoVbfWPC+3bcuo+ndYbontOUqr7e/eHqBypLrudSwOC5Vw=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 20/27] block: use bdev_discard_alignment
 in part_discard_alignment_show
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1tub5h92g.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-21-hch@lst.de>
Date: Wed, 06 Apr 2022 23:22:13 -0400
In-Reply-To: <20220406060516.409838-21-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:09 +0200")
Content-Type: text/plain
X-ClientProxiedBy: DM6PR08CA0027.namprd08.prod.outlook.com
 (2603:10b6:5:80::40) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 48dfe498-a030-4603-882a-08da1845d094
X-MS-TrafficTypeDiagnostic: SA2PR10MB4748:EE_
X-Microsoft-Antispam-PRVS: 
	<SA2PR10MB47487EA3A8AE47C7ED7289758EE69@SA2PR10MB4748.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	ph7TJz13ybahhFzUjKzZz6hoi9EjoSE4dHQMnFWDfV18h+5KagqOADbAnIVWpAvozVEycMdYYa8zzCg252RO80zRbpNyi9T7tc+92ezusUxorrNXJ18kwYLL2sVdMfNTVGBN7kpBqAV0CvQvMwuUGSMaAfantVV3LpC90npPuGwNQTSDxEjJFIrbcAiO7eeUE/UbnOEkK0XyuNUrc/lM45zIMm+FF7KsB0oCUbZoq5uNwuKI/0usdEuC4DRkeNDzO8c5VWp4NXr9qKG0yxYMh3QyRGvQ30zCJyLsi0360gV7sb/Fx4lhM8+CCLd17P5YAGQXW5RaCpVErImRZf30K67W8cpMbjfpP49BqPyG3rMGRtVUlP8wsBobWI/A7+dI2JU0oxgJV5Vmmxd766Qv5twJNVgCsKgjOY92Yfm4U8TLhuPrE/Ut+u5+aqDvZIR07d6+kv0sjvuzm+hCvr0gabjG/QYmzAQ2zTU3czU5W+Z4PbMnec8vOSjI5xzLEYUg1eDZBGO80yfoTs5gGhELT3Wz/oPD5mPsiTazRBjnJtPnq+NArdeqSNJRAylw3IaqEhyUB7PM+mxpVEuCOp+RpV54qAlwUf1gyuObDXCCYjc1h9rL/5L6Kf4E3gf9K3BIcemjNmTWiBI5nYL1JFETX/q/OAD24cNAuJqG/lPMYMK1TU0DQYreYJPiTSc79UWqq1q1p9AqzmKgHlsUO2ayJg==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(38100700002)(38350700002)(508600001)(7416002)(8936002)(5660300002)(2906002)(6862004)(66556008)(4326008)(316002)(86362001)(54906003)(36916002)(52116002)(26005)(6512007)(558084003)(66946007)(66476007)(186003)(8676002)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?smfdKzkzzQC5MfcTkNTRJx6MrcqktBYibTu1WZRM33ZRHVagZq6Fx6eYeOgA?=
 =?us-ascii?Q?bXhKM/v75VXxhdovlGb5kKYuZsDFnCsuzbjo1SPQqI2sJbBbNg8GrAxuF/NP?=
 =?us-ascii?Q?KBuFCvyY/eilUlZ8CYLCvM9NwInI2Lk8kbxHG0qBMc1LSgNYxyzVqYIgkjjS?=
 =?us-ascii?Q?9wZUzpuyXmw/OHBcStedtnal8ZjvXj/3wm4s/H6FFjq6ACg5F3L5U0BnTTFc?=
 =?us-ascii?Q?/QzbRcjS/COrxILp2Z+g9zeg+unT6+51ZgERIwnXfurOr5SmtKITtugPt7S+?=
 =?us-ascii?Q?p0DO6V/ZO2Dt+o9D+62WHFFgA7yNiDyvVp/6axGTkkicWOCDAzQJ3pMf7Zin?=
 =?us-ascii?Q?qQVobFt6aEFOSM0+HYW9SpnTJ73qr9nJmliGWuclbBgvKH4CEmpvvaOhenDc?=
 =?us-ascii?Q?K9Gnx5cKNJ2jqJoD3iB1apRQoMPZv3wpW4MMQPMtS5PIjpOHDWdC9pXu+fBP?=
 =?us-ascii?Q?JT5Q/9Qua+91p5DrGd0WYIoxSj/F7XY1AqEWCS+eNXIt40BG9G7kbEu6O6Wi?=
 =?us-ascii?Q?XHd8EoCPLBwM1NiHvOUgAk+zZZzpyI2jJYTS6FXl6aWaY3EH5cX7iEDtmqtU?=
 =?us-ascii?Q?2R9y1El0peGOfhITCq5E8JEYhBGObk3SEfu4I7aa/OdO9JoEfuPRmkMiyTBy?=
 =?us-ascii?Q?jdfhAF/ijlwNMUceopzBXyYZi7pVDMdLrco1QqUkIL1Osct6Jhe3StjwwsmU?=
 =?us-ascii?Q?NHNu1OU0QEp82EqTdt+ZYtheKExOPOD8UsUptsGAABNON4HF7mE77a/0U89a?=
 =?us-ascii?Q?LM2IbqhI09DwxhTllDEqqhdklhZEhWlfUSxHoPP1oFd74IVJyAY+u3MEnF74?=
 =?us-ascii?Q?KMLw458R6hnzdGcXlsJBo7p46V01v84gHfVbMmWiyiEca8+N3PoepN5Nn9kw?=
 =?us-ascii?Q?ZdDCvKCeeFVhMLVNL6axV2tmUk0iFv4m1m0dZ6FVmRX3NaNhkVHPoZrptmjr?=
 =?us-ascii?Q?VBt2+33iKm8BghK6TD1bM9N539nCQ59YjiSv9TNwGxhzMjVuW9dSFMbeffyv?=
 =?us-ascii?Q?3igRst9ERRUAQrxVHRoA9UHcf3JPUTgc1ksnDFl4JtBYfZPUpfkTvJRfAMAH?=
 =?us-ascii?Q?A5z+VnH8Dt1orSNOo+bGXRJ9n2+xJHjLLTM3m7vl9iw8br+p5zoAW45+K9X7?=
 =?us-ascii?Q?jn6GqoV66kRS2PzB1GvyqKfsPoBH5KpBgTW0UFURoch/eCByKNKprXuzWT7w?=
 =?us-ascii?Q?wS27Lysj+Hm5mBt8OHvd7tRb10WBkfvDMEjeCdx6nO4LzOV/H45v3Jf1cNp2?=
 =?us-ascii?Q?AslMP+FWldX/mh6V3bdglSLt+YcPjUWBsp7YGf6w2JPWhWZFwd7z2SZGhNJG?=
 =?us-ascii?Q?6cNzBaAj0626t36i5I7bLET9wdAubKkmiwsBsWB1/rfEd+9jv4TjUAf2bGsv?=
 =?us-ascii?Q?C7+zUgXuk/SIYFjzokPsd8rD0Cxy1/CDsI4OUdsLpJ0y7G1vHeLX3wFHl8Pl?=
 =?us-ascii?Q?6xiUhb8itUQ0jrl/eLZJYv48WUiz7Vkc0HhWr/UKedQSm+HpsfmqBu6zXPbQ?=
 =?us-ascii?Q?JWOjmtXfOD/l3OG0FERkZjIORLQGTDmMed7dEoL8U6PsQcrNeGfEvX+7S+4d?=
 =?us-ascii?Q?B9EpcQdO0FUNi8+JE3n+rkNJDvvH/DLnCRCx+5ljkK5wk35aMOUUIVk1gPVV?=
 =?us-ascii?Q?JS80ZhhdfoMiqI1rG2Llu7fUx5VR9pWFenqE3jOFUo9jr5L8BR2Gev+wYfwR?=
 =?us-ascii?Q?3KzWO19pjJGdmeCAgZMEZKABjvl2X4GzNxOk4IAwLd74ROSZenPf9AfA05Vs?=
 =?us-ascii?Q?J+jC/LDaTYy1byqBokxGIhJ4DXvKE98=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48dfe498-a030-4603-882a-08da1845d094
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:22:15.8957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mouFQTiGIB3sqIlUkexWTCexFzQ2PEHssCgeJ4E6Wra5R4KAPVyvJyuCB6zCHxahDwRdbWgEroHmtjXA5lGtLWj+q7jaev1O8w8EMd3wEKE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4748
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=920 spamscore=0
 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070017
X-Proofpoint-ORIG-GUID: qEU8oo0GXgxRhC2NABzBkCtpoPeQvZDd
X-Proofpoint-GUID: qEU8oo0GXgxRhC2NABzBkCtpoPeQvZDd


Christoph,

> Use the bdev based alignment helper instead of open coding it.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:28:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:28:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300298.512123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIob-00075Z-1V; Thu, 07 Apr 2022 03:28:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300298.512123; Thu, 07 Apr 2022 03:28:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIoa-00075S-Uo; Thu, 07 Apr 2022 03:28:08 +0000
Received: by outflank-mailman (input) for mailman id 300298;
 Thu, 07 Apr 2022 03:28:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIoZ-0004sb-Bt
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:28:07 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bceda822-b622-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:28:06 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236LH0PF004957; 
 Thu, 7 Apr 2022 03:27:47 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d932mvy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:27:47 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373KQcJ014140; Thu, 7 Apr 2022 03:27:46 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f97wqsqmc-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:27:46 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (20.182.127.76) by
 SN6PR10MB2637.namprd10.prod.outlook.com (52.135.81.152) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.31; Thu, 7 Apr 2022 03:27:44 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:27:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bceda822-b622-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=jtZFiukrDrNaKwudMOYgmK4y6ZDoL7W+5uSf9uS4Pw4=;
 b=syOONMklItTPSXz7KtfaCFVFE5ivjGKYsK8owDdJX+p3veRe56GBeWrYdskEry8eGz2Z
 c9zdGKmBs2gZ2XoUbepmD7qQNBxG6tQ5j2ZUx60TtC8+OdqTmLjVFPsmu3BiSk4h2g9t
 iWHcR7KAWHZCsLBwzDWPwabAUA3V8+/vKC252bPJ1HkIMYaLe74IPGnWTpuUh6GI0b2P
 Tje7hyIT9B3Go36b+Kc8u8F/RbQoq1L2rEe93W5y0GZpNb9PLi1p1XDiIvz+wyNt01yZ
 eONd83VdVCQnI483aopIRy7FIm9GO4/Z/SyF64TYHe5SJpXrPVZUZw5fskMd8zi7M+Az RA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W9TZnLPriT0nVopc6LN0PYhEoK3lmS7AaNWeqhG5LvWs021seVGbcwAFIsnCksfrqDyKDwOH0Hy/2RD+OWoWERmmUwNhIS9MHmakX6AQbrQV1VITLzHj+gLnFC8m7Pb+YJexO/amZReAiXmAbRJeBd3a9lIp4sjSkKmx7MoeF4Xv5lsHpmoHQNhFPluUuq7o+0PwdvZiRg4QhPqWuLRpaGd91wDuBJ7EMYN4zvKwfr66VHBIzkPoxLWP0RxCEDfKPF7JQcWWJ66OZ6GSs+CZVzKo35jS/F9LoDcZRtbGEiTU6lwBRgmOVBk7WYTgb41Ooib7SWuBaNn7PpFxQTBE+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jtZFiukrDrNaKwudMOYgmK4y6ZDoL7W+5uSf9uS4Pw4=;
 b=MmrpUPnu4UHo+3QzuJPyWKtbOTDvP6MWvbApRIzcMXlBxTwNkRfqHnZxhZWTpmI/YdOz/ygGRyf4N3Ya4BaSu9dkeEasWepaotPlQljL70d3irEbkFZr2qQCigniqjY6GB5m+cPlTlidHVC1Onrg29vPBOTRO1lMjUaytSmBqBoS/jy0CKsd2wcEyjHdkE6cQ/mvTgjnO+pVYsijnjU8E8WqnTbXA3SamvLmlHgur/XC672MOS3DF9Rlqd8W/ZW/0W76KMZS/nGOnI7gritwBJzWOqcOXzZ7LdOkZrUuwMFyQ88cZAxGbTmQIQ2FrZdaeb+Wz8uTM5IgCxPlsl+VAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jtZFiukrDrNaKwudMOYgmK4y6ZDoL7W+5uSf9uS4Pw4=;
 b=vuBysj3Y0/+eXCH5ZS/chYtrN3+muZXWmhOCpB/xsf7NoXSCf/3vEpQMNch5Ur9r6rsK34Pi20wMCNJ29aTdL6uEEu7WI0Vqq9dVOFtbU00VQcA24EjTcgcb42dwOk/rwLYGr0OH620LYgGh1VqJ8BpFXmGir4EOIwE5J6IregM=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 21/27] block: move {bdev,
 queue_limit}_discard_alignment out of line
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1k0c1h8w3.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-22-hch@lst.de>
Date: Wed, 06 Apr 2022 23:27:40 -0400
In-Reply-To: <20220406060516.409838-22-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:10 +0200")
Content-Type: text/plain
X-ClientProxiedBy: DS7PR07CA0015.namprd07.prod.outlook.com
 (2603:10b6:5:3af::26) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a3cf4a52-2840-46fd-60f0-08da18469423
X-MS-TrafficTypeDiagnostic: SN6PR10MB2637:EE_
X-Microsoft-Antispam-PRVS: 
	<SN6PR10MB2637242310AFCC3ED6A78FCE8EE69@SN6PR10MB2637.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	80ZcmGqzlbvvIyV7lPcstKvNsrhiQ+bTVR36mE6L60RiIGEC93HNm6rYQA65jPsqgEKYSz/hJ3t67uqkuqt61mVjzzhobGZ10ZEq33oarwh4MAMyI6hYCB82f7BiGXv2LTleB5utnhrSVG0tk7xMZw2+gG+gUwC7yWWgYDMJN3vpUZA7I6JkDhVxRGhEHzRMsvQR4gLCN+qouUbtAvdLK9QiZSTsxdV6yVDPDr1YKigKrDzn3pLiv+aXKqfW/vUTPVpeyel4gm6MW9yPmyZ+KYAQvwOMG9h4iwALBSDWnN7uveJ88l2+v9n0mqciYAA6tftgdKyM22kACSCsqFS0Q70xz8VSilUl6gfFosZEH3IkO1YZpmrfvSh6RgUPSxE5MSWsNuyIUpeq2CONtLZKyFbT5AztxmjBHQverJyDXWKnddK6nIMFE7BWYo8A1vw7jZxZh/knSpZ7q8nvSxBZnWyCYvrrpsGUiitGDil/5ixUBqRPlhUnx/51aWqT6DV+kbVCql9HQCoNpyXXOavwHQVkGozrVIkZswcmuoQnIl9/cDSoAyiBtS29eZVUwm7vzuRUfC3lwnKbeInwpuDjwjxbebPLEWyuZp456PM5DTFjhbAR/YxRgKcs3HdTxmL5Iq+TyRHX6axPRAgxUYvSz8SfQj5qFg6cUCLRML3Ir6dGXP69fPxeAkGNlgz+f9K+rF3hY7+rzYPSoT9ePzGiVw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(54906003)(6506007)(52116002)(186003)(508600001)(6486002)(316002)(26005)(8676002)(66556008)(4744005)(8936002)(38350700002)(6862004)(66946007)(4326008)(2906002)(5660300002)(7416002)(38100700002)(66476007)(6512007)(6666004)(86362001)(36916002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?u9k/spZLbn35lT2rj7uUyrSkLUM4QiWXwjvis3+AG0O06OXk8hxpjp13E5Q9?=
 =?us-ascii?Q?jCKmVAKJjK0b1BqKmFPPsrjNsRSZviGmhLxN6AVHtny/+V+UP/7gGo1BR5wD?=
 =?us-ascii?Q?BAh46yeBvQX+QeX+oHB1p+38lFDByoJJoA/AfA2p2GNgG1p+B4EpLjvVNtKc?=
 =?us-ascii?Q?d3Z3TDMWuXi5dFo2nF07J4HJpCzYA7d2ZJNlU5D47DotVoOByyPWuA2bbCd/?=
 =?us-ascii?Q?5f3AY6gj+nMHGlD6W67B3a+RqOakF1rxuErIDKzf6GQJEd2q1FprBe/Bjfsw?=
 =?us-ascii?Q?kkVuY1hCUNF5s1jdULq9/yr4YajldxnidRM1WFauudLKW5MEXIIywFT9fBTt?=
 =?us-ascii?Q?ZsZZElyn7gmeuCC5TUu2XWTEZegoO/4Dl094c5feMU1VOlHGnoxs/WQ9iJYi?=
 =?us-ascii?Q?sYnC9C4E3rvF9ndecbvvw76RkpMRT2lRr5m6GWTeVZ1sphOOTpV3BpViJo22?=
 =?us-ascii?Q?GDv0S6sa6Dgyd3GeHrVyK8jEmqk9EdeEHnjMqFc7L1JmgnGQLAOoVJSF8mb7?=
 =?us-ascii?Q?dZS2VgI5mrDDBUtAbwwVwwWGMhSZHQMZUA1IWlKtLlZpMmycmiuo2+bDLCSv?=
 =?us-ascii?Q?4xfJqT7vEABOffMHtpa1yqhdnvWiKFui1CjnHEZy7kpgo3UoaNamzKf/NB08?=
 =?us-ascii?Q?KhcRK4yxS7MRllUNu6iqtTc4JAIrLsPAlgpfvZiF5+Flj7iivGfhrc2PX+8l?=
 =?us-ascii?Q?oPNyvTU9hUUxGboynV3yD0SPtJTa7rNkqv9NGbv7BbKmJCqPD5rlXxjohONG?=
 =?us-ascii?Q?XdCtSpqCK+sSVGoHzsQF+CzCk9TO1OKXFfi0XaaF9eLCu7FvSg7KDcnJsAq3?=
 =?us-ascii?Q?GDnySRzucIC6Nx+DBThslp6PSwk4EZ0hrRRbni8Xa2dg2QwRW8aFejKJUsOw?=
 =?us-ascii?Q?J6G74oCF1YEVfGLmfAQvkL8UrTKvrXqlyPDL5zYak+xAHHYp05fOg4I6twxe?=
 =?us-ascii?Q?iucRkGVoYX+WHalcQrE3ZYXn4XabiYqkR7NBp4W+gKdE8L/I1qH4DVDX4Auj?=
 =?us-ascii?Q?HDu+bMxbOhSjRfox2eUzooAq2sGT/s2+DsRq6fjfIQzIZHdjVW9KQDX4f+nT?=
 =?us-ascii?Q?xlWYc6NA8ZoOTI+0eLLN+wD8yVbn0uDalJbHClE4Lk6+KE04EuMApdKLUC8e?=
 =?us-ascii?Q?L2H+6mw6O2h3eYyNUwuyXb/BwAxJiM3QQAvNksD4EjhdzX7HfME0jUW8TFcE?=
 =?us-ascii?Q?2GpmDgoOrz+NNYAxkIn5mfXrnwwEJlrcUE06GRf1pXSf7F4qllOafQ/gYmuf?=
 =?us-ascii?Q?+vshV+DgeTiLK6UJZtovoqF9uI8D53/qwm9hl07ki3JvBOVtv+PWtU3y2wRl?=
 =?us-ascii?Q?IKcf0rXMuxbrDnyr+YMgvREl/5SCmnbSLaaz4AQ5A3f144r2GU5g40rJugMo?=
 =?us-ascii?Q?hHcl5j4Ld9WABou6McobvaFoQmbM6zctXNTsWZWKwC5ce0A+SD7cx1hP5Id4?=
 =?us-ascii?Q?ThHzD9s9xsyYa+RUQN0Thj9eOeQEPyLYpWJcWRiGFJ6LGtfwT/Pb/rdaesrN?=
 =?us-ascii?Q?xQATOdCzRdltOgP4hFPyX8KnN/gX5xPdV6RmmZLd575yIzojrDPTsUtnT0uX?=
 =?us-ascii?Q?0jnOoAJVefp1NTRFWcC3XdMM/yqcF4k9FA0EF+OWZr5fSVCUf3g2fylwjOds?=
 =?us-ascii?Q?n3E4C40X3NBVKuY6X2BBhydGqEZwDWtS3MAcrR6DaQ75ackm8rxoSUA2okCy?=
 =?us-ascii?Q?qQoMKf4QkZI8o54TodyBpPwHKrRwD/febLODZeN2gknDIy6RYu74Q4ALNBmG?=
 =?us-ascii?Q?t+EtYOfH/GlA8kNWzOd59B58dsZKFc8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3cf4a52-2840-46fd-60f0-08da18469423
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:27:43.9876
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eyUcy9/MGctZOofiA5xyPFtM1nZ908KVPJjnyQfCHQlpI4CSGsRtGP5YZVc9zUFfqAJB8w5g9VIHZ4PeBrVg8TSsYaV90Ss0i8yVCGDR2d8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2637
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070017
X-Proofpoint-ORIG-GUID: _zEf6t9FfwbB1Zj1bWzsrGq7918sG9Hn
X-Proofpoint-GUID: _zEf6t9FfwbB1Zj1bWzsrGq7918sG9Hn


Christoph,

> No need to inline these fairly larger helpers.  Also fix the return
> value to be unsigned, just like the field in struct queue_limits.

I believe the original reason for the signed int here was to be able to
express -1 for sysfs. I am not sure why I didn't just use the misaligned
flag.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:29:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:29:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300304.512135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIpx-0007mo-DL; Thu, 07 Apr 2022 03:29:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300304.512135; Thu, 07 Apr 2022 03:29:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIpx-0007mh-A6; Thu, 07 Apr 2022 03:29:33 +0000
Received: by outflank-mailman (input) for mailman id 300304;
 Thu, 07 Apr 2022 03:29:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIpv-0007mV-TD
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:29:31 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eee2a658-b622-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:29:30 +0200 (CEST)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236M7gW2006371; 
 Thu, 7 Apr 2022 03:29:15 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d31jptr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:29:14 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373KQkh014152; Thu, 7 Apr 2022 03:29:13 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f97wqsre0-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:29:13 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (20.182.127.76) by
 SN6PR10MB2637.namprd10.prod.outlook.com (52.135.81.152) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5123.31; Thu, 7 Apr 2022 03:29:11 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:29:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eee2a658-b622-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=FspSHwF13B9BbpmnqcGUERmum6Re9oIDd5MfxvXKoCc=;
 b=jXI1CzYEboy0GNUF6p687VbmW9R550d6ikVNLtrqzG9nquNygNVHYrP7eoa7jctskKF4
 KeIloS+shiz5kphPTwYWc3pNDEJIw4HsW7QNmTCxbwps+wQB4YldmJn7P9mJzS23yiDV
 fqqvbkec3PqVydLqQO+y1Wn0ajviBVE0KsO5mht5RlWI0SnUfHb1FIYWN7fRxxOxwnbg
 RzCw2JiYddeM+gS6fA9duMVLmrj+YKLOGXTlWrqOBtXKQd/pZKAPX0igHD6aGPdWJyxD
 YLsXGiTgCfXwNpPSTUa2L4ZwNM4ZZfuKydW/34EIQ1j6QH499OtWj8aIkGpYfH4Gpa22 hA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KBtu/oD8OttihczZFWhcEdaCWqtwVtV3jM1TVamHPpErBve4hPXNtoB6lwdJpg9pAQxunkFhKO6G0m519MX4i0q2Ht9DBkHs3O+a8ZhPk5jOFXnrfbEioR4nABnomTlu/BLcuq1VaDZ4oczWNeHEaO66juCF5+boOZ532CYqu4cdTVAYf2KIbaaf61l/fKKd/qEhUBQ28VnVq8RG41qngUC2Ss2njq2MRW7a5AirVOk3hkrUbATVnMRlPtrzKwCsGllPXy5bVS2/wEO2rlKupKPA0regNGjoUjXBwVzjB5otwWNJaOeUVeWfuacRiz5vybaxsk5N9NCbEClPhI7w8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FspSHwF13B9BbpmnqcGUERmum6Re9oIDd5MfxvXKoCc=;
 b=ffcYlZMpnQmQYtj0AQM3arsM/UL/OPytocPAtBitJCfFYCr52gSYB4+CBML4lgGsoE7Y5XGZgUdyYhS72q7CSB79SaG0ZKhyyvQnNQwujzXmlCu0rHU+vpYzm/e9eMfuI27xdtLBmyZfiGxc44Qq1uLfnXv3H5b4rTPOcTW2Wpc/s5p6qKPBoC7bhrb9PAYyaEJgr+xc7Vy3y5XZbDvQ6SsOKzziVqYfGzxfV5el/WucIk1JQCbL3O6QiDS8FsM7r8HC13D5xuCipdIdPiWED9lI4zTkBNOyZ0tSt+3zIC7Trnkp16FGWJW4sjU6Fy6jlJta4/Lf77qUE4OAmf3gDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FspSHwF13B9BbpmnqcGUERmum6Re9oIDd5MfxvXKoCc=;
 b=CMlo+9k8exY1H/xsxYRsnGoFadfUU6ixuoH9kPQVb5bvaMk14fq11ag4UNzE8dfo10i2efWZu8mH6PhR4PU95S96Jumf9NMXyeFVDn3OS/xB4EEmujB4PNmJbIhY1FrVxwwotM8ClQY3FG8lOL9ml1kzmK1+xbdgtiSyAPYwGE4=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 22/27] block: refactor discard bio size
	limiting
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1ee29h8qx.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-23-hch@lst.de>
Date: Wed, 06 Apr 2022 23:29:08 -0400
In-Reply-To: <20220406060516.409838-23-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:11 +0200")
Content-Type: text/plain
X-ClientProxiedBy: DM6PR02CA0141.namprd02.prod.outlook.com
 (2603:10b6:5:332::8) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e8070910-ebee-4181-449c-08da1846c81d
X-MS-TrafficTypeDiagnostic: SN6PR10MB2637:EE_
X-Microsoft-Antispam-PRVS: 
	<SN6PR10MB2637A3B76030A51B21A21FD68EE69@SN6PR10MB2637.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	KBpq+aayhUAT1pO7O7lX4YJ5rmC/ymbcYRAvX26Z08Y8oQ5OC2BPymwjj5K76vcB4dSLDTSUvvo/dRe6V34hT3xGMvNaAlMBELuNoxgHV1PnutkOiGEzImc3I6z6D2OmQWt3+fim8uCpdG1E9RLu6N5PMnuux6W3GoJju40aZ7yfo3+MILsD7kP2NO6XAMQ2dEMGyJnKxHsnvAzvzfZWOWqENSs+ynCpHoR18aBtqIy3dN35sSw66+tsZ061H7w/WMp/CTUSb08cv69Bmz0VjFAwK0gNSynz/0zt62AbfvCOBeKllzziqiVvUzVHgFPYOrAbAyMTsIHEcY9ZmRMAU1VHuh8DYWl+Tta11PGicV3k8U2E8ncwwKkdD9IlsPFLTI2Fu/r5Sb5o6i+taQdsmizoJv/lqV4j2EOjinm4YgFw8giw3fy66BNUvHNhtkmhvt3j6YDygf+jcNyWob2Krpwck1f8LaCYEpYl+1USJs96cXikOCFvzKZmgRIBR+pcpFj92BkXVlqfGzxIvqDoKGqCnqNrTSwo7/3N64Atz82uXNL4T13nJNSz+D2cP4pMd4g3PKTIxECxfvIhH/ETamwTnk3Cy1JnNwsh+DK6Yqi0VvKt7YReYH522aX0RMpAyRdZR2jFF13NevqludULWwUeSazJ0QN4xFwxhLDdYUPyJR6fD5qWQQDokpgT3Z7hHcQCXSrZSpTicAIf49Z3vg==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(54906003)(6506007)(52116002)(186003)(508600001)(6486002)(316002)(26005)(66556008)(8936002)(38350700002)(6862004)(66946007)(4326008)(2906002)(5660300002)(7416002)(38100700002)(66476007)(6512007)(6666004)(558084003)(86362001)(36916002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?SPOdVXZ0+i+GnjawtDUnbmSAWLngszVdO5C8CxxotLuixJuu3IFgSAaoCNGb?=
 =?us-ascii?Q?ZWGlOaUTK+r96PcQ27XzpLW51NL4qPCdz+47SVqd/Lqggz/H2t7ChkbkuKjG?=
 =?us-ascii?Q?OZLSC7667yVg+hkfNKptOBLhNkX4js+75fK+3S1f3WqNzWujU/lCE0i4Jvff?=
 =?us-ascii?Q?orAP8outnZXpiR/+1jzkrdD1QyRdW03kQPjmex9NpTUkugW6dgaHMpfueVMJ?=
 =?us-ascii?Q?5lJe2nq9Pjx83JYh775/ujlJx/VA05ZgE1d0tA8uJ91vgm6PzUPO4n07s0mU?=
 =?us-ascii?Q?FHzcrTNHn5SfHHGBmoitQGOrzlscedQzeaQhjb3AuSGzyEePl0evWsBrYLyy?=
 =?us-ascii?Q?xBa0AJVANloyU1uKw1q1v444qulQFNGugIN0w+Cx/PCazy84MOTlxt9MWAsT?=
 =?us-ascii?Q?qmpwCAhbmJeyWLEwB1v1KpRhkvexr+XWWoNslPn+ScxmxQC8MiOwvjR5nzI3?=
 =?us-ascii?Q?Ywp7/BIcJh+9Bit58puiEHNf2W4Dulm66Dv4S+x9qJk5rxSXdzq5LJWychIY?=
 =?us-ascii?Q?tjMzrcyqm547+qJbjAODeE4re7w3ExzliRLIgGZsKalRxocNd7iS9zImfcjh?=
 =?us-ascii?Q?nX9IPOv6iIolhB7WhmWBH7l0n6ZpfSlNJgbgop0yg8OyBvKCrnKTXa7xc7Iy?=
 =?us-ascii?Q?+ivSktS1VAEnWYwY3j+sdL5AW6kBBgNWaTWh/s/8UsgEz0snP47I2sAeU2Ps?=
 =?us-ascii?Q?8WlPwpKTwKrTUg+miqG5AsBoWXjdjMPZBrwvHl57Qlr0ulHsZDTcDYYlmYJ8?=
 =?us-ascii?Q?SnmOqQiNcb6ZnPqB2YXSC/VhxJoXlT2v/rxvV9CZZjx9R84bSd/jVu2qLUMS?=
 =?us-ascii?Q?BYmKLAkGPuR2pXQwLT/3SdoRdcw0BlA8TvdrOB/04Cd+s1hMR4uaKr4lBV6O?=
 =?us-ascii?Q?PQMi3A8E+n3wyvmISSddSW0dcOl7p1ChxcRFBtTZS7fCqatTpAhGsJDPWcfb?=
 =?us-ascii?Q?30Bc7SXQn00ARZK3PMiVoIsaVKs/dbCQoSsZS+jH/AJxgVS9YzLQVzKj76WC?=
 =?us-ascii?Q?6uH1gsf1dCf0ACTdIQWGqN/nMLcVoHStsjWLbmAMtqtSo/+FluAVHFDfvHyC?=
 =?us-ascii?Q?9BqZ+LCirLAC0W6xOAua4O0X+RHlpPK6guZ8cS6RQEZVAlyDsTvNIdnmY1mc?=
 =?us-ascii?Q?LlnJ4GP/CV5Oj5DCEbMmQVv3Y8sWDtTMTx7pCnt9i4PGn3wIULCfDgKoG8Rt?=
 =?us-ascii?Q?QIW0qCQvZ6CVvp1sd/QWBs8yQa70FN/TyixcJRHvxsndkpab1ngIZDrgZlW7?=
 =?us-ascii?Q?OzmroAm6t1WWtX3vB/9sZypprpYrX4TOb6B1C2cFo9Oi7hZrw8L8+Cg8YYON?=
 =?us-ascii?Q?9ZAaGQB8tphUSKelFXFWeZqtFumcjQENNtlIk+O9xMNlKfTbVPiIcwOinw6q?=
 =?us-ascii?Q?fW0LXIARA2UgtbapzMggqC3CNr9HzGU2M+CYUY1402NTj591OG7ICbHg+nzW?=
 =?us-ascii?Q?/0NuOcbDG77Yd7lnm+mkaMZWG/AijhtgX3gtenoQzTd97CpcIMsgx5Uby9Zs?=
 =?us-ascii?Q?qUO6uisTDag8+yZNxjt9TAW6dO5QGaycBh9ehb2giX7AreedPRsgvmXr1g9I?=
 =?us-ascii?Q?FsGiOuQAnIhOsEo8RXrojUqn02esH7vPVmPSTQbQluRbCGUSx+d/tuslMbr7?=
 =?us-ascii?Q?3Yt7JknUR5F59Xl1SyifJrdH8GQnCLQljPGj7AxMFpLl7cTR/ee+O/kSyOZE?=
 =?us-ascii?Q?4Ul2IhyKbKmdok1Y/hYgp8TrtFudohXlhY48tibWOtgY2KGoSM0oV234lUU3?=
 =?us-ascii?Q?fSGDBOSWFoagbxS/Tzn4AD5YSlb00oE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8070910-ebee-4181-449c-08da1846c81d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:29:11.1892
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gi0BFA2Ok7V3tE3LFDdJiO5tuxtDLwrPwtU1KTZgJtOze8Mi+AtLFgp/5Z2pc2BPvLLQTZ5iuHjo0466k0W+Blb8S3MwLDwPCIAyDfcmlAI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2637
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070017
X-Proofpoint-GUID: r6gyQw1VOXHdH7f3ZbK8XF6W2k4Rmy-H
X-Proofpoint-ORIG-GUID: r6gyQw1VOXHdH7f3ZbK8XF6W2k4Rmy-H


Christoph,

> Move all the logic to limit the discard bio size into a common helper
> so that it is better documented.

Looks OK.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:33:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:33:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300310.512145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncItB-0000pi-VK; Thu, 07 Apr 2022 03:32:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300310.512145; Thu, 07 Apr 2022 03:32:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncItB-0000pb-SI; Thu, 07 Apr 2022 03:32:53 +0000
Received: by outflank-mailman (input) for mailman id 300310;
 Thu, 07 Apr 2022 03:32:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIt9-0000pV-U3
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:32:51 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6646a534-b623-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:32:50 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236LpIIu004895; 
 Thu, 7 Apr 2022 03:32:34 GMT
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d932n34-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:32:34 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373GgZ3035307; Thu, 7 Apr 2022 03:32:33 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97y72sg5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:32:33 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by BN6PR10MB1618.namprd10.prod.outlook.com (2603:10b6:405:3::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:32:30 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:32:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6646a534-b623-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=rtM6WQf1X5CFX+vgnRgQOYigjQ6xnz/J1uu/PU11Tp8=;
 b=eHUph2bNrH8sJCZpXfwCiY5eudCWKAsSl43XDtCTsBQtI2OHAoWMdLFE/AB4RtpkLDOx
 54w0wxzP5iqXInt1LLMcTIZyUIRzDmq3kH3PPHOEpDi/nB0hBWtwGPTKA9ssEaWYXe35
 wSXAjvgDZLbUzrtsepfTSwWU9aC/LFEXXgeLPpWTK3JGCgj/VYojCHhdB1+/qlHzr0mG
 iCQVphtYo1YXLxBdcTSD1OIOXSqRNVlN1kE89zsLQ6Ou9zfAAehK5Xtp1i0AFX6zMvH8
 w/71ngjIhEZLLFAUWtUf3b3GqbJ8u7Ewgenmek4KqglQ+jox2tcGAMvY2GvSbom0VN/f Dg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lhX2n8/By0P+ArzIbZswHV5WvUVgWn2QzdVvtMwDQNDIB12rmsZaTTN7eerA3Fhk4aQq6ZurcODAQYoDXXIBzrpGMDKpSK4/XvQtwuSuNcrhbBCi0ORZuiso9izgP8JawxNK16F+FYo9w5e4ORmfkkmstD3T1ZUDxZUfXp/ZcaLqCBt1qAO9wSqLC0eM89sGeRzPzMqP9KAuMuxdL89aulqX3hrXuHCowg+hnGji9BW1s0iYvkIdcMIM7aN1xR3PC5tVW4ZHcyrFXR9WMzp9n5+c+lIoRuDl3J2qd0f61aPN8mVIwY/eXS35XOLAngkpOx4iWrU9OsKY95vAwT3bfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rtM6WQf1X5CFX+vgnRgQOYigjQ6xnz/J1uu/PU11Tp8=;
 b=c3QS2wfMRfX4nxp1Pic3mfrcpfk04IzqPishSAlZM07fdPWf+BThY6MDny+2tUIf8F70Nx4RXylJrQFs3Ekatjc+II2lCwdEj70gZEpZVHvQ6mQHtnknFb3O/NOPl3crowv9BdrTZ7ZP3CsCdT6w0flL4mK8r64wixuyN5OgzD77v2thLilXO/VYg4yGNyjZnfwWbkTV8W8v5s0DC+xsDfjS6/rsYTNBjD6zbObZ1+BO1vmacu1KFvyr2jXAvqSELnUOiv62f8DLkiN8fwTtotQ6mat9O6o8I3TXMwii9Ij1X3SOzp57Onl89pRHUnHFq4i+40UnSIWfaOz1QAusYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rtM6WQf1X5CFX+vgnRgQOYigjQ6xnz/J1uu/PU11Tp8=;
 b=CFdOjRutwHI/pDkDa1Ew1ROIoVCl3Zoy5B5Hwl1I4sC03wTDKB1LDdpUfucfFi73Nkc0ypGuXVcvmYKOweC9DnSwqfiLtMKkgHTzvnumMctTA7dD0eePcu/C+QJyjnZRL2jlo+CHb4BeitpKSunjZ56jA6oJy2G8dbj909W2En4=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 24/27] block: add a
 bdev_discard_granularity helper
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq135iph8lc.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-25-hch@lst.de>
Date: Wed, 06 Apr 2022 23:32:28 -0400
In-Reply-To: <20220406060516.409838-25-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:13 +0200")
Content-Type: text/plain
X-ClientProxiedBy: DS7PR05CA0006.namprd05.prod.outlook.com
 (2603:10b6:5:3b9::11) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 073c7bad-f00d-4d5b-ec41-08da18473efc
X-MS-TrafficTypeDiagnostic: BN6PR10MB1618:EE_
X-Microsoft-Antispam-PRVS: 
	<BN6PR10MB1618B131F14E3475ECEF0ECF8EE69@BN6PR10MB1618.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	gIfFN6ZUD2su2U1lfuo26oFy3DXVBykbx0dwaYEGzK7BsICvXIUb2YHrfD6R1SpHzZLdoy60EygwHWUppYBHwYNhRvVGdJY9eV9cs6HWqGwjPhgeaWa49V5vtBExI24PdhtYTHWQo/9nx4xmpOvQRF9m9IqidD5y7tPVV2S2IREDO6vdIxew3Kx7h2FzpTGbrM9j8xlfVqXTHLEmAO9/4oVXKOI01Ju73rheURL2cy4KRtPHROSrpT1umFK+wQdh7o38LblS10zVIfr0/UEX2GMXj7nO43B8KT4l7PNLgheG5vOb0afIiE/1+RpMQjOrr4K60SxozwkiPwoNgdurI4VV6sQ6oWdeHPetek4WARqYGGSsbIQPPULIlwvZgKjwzNUsg8MCHx2c4CvhpY3hOPZeiXEIW9lr6jj95b1A3U+w87ea3wWRBoXccuO6jjFgNXemwnaUCXbOTiyFDPtBjZjCy89Pf5IPzDLxGNQDDq6wCqfZ/2oiA4Ktw3NEwfZmOPd7mhKXul+uW+iV2L3/bXZIWmec/8Z4QjsaFFd9Fpz9JMRisb6rpNPWwFTZfeFdHBAjYJ1Cmc2E3rmVTanNSxZ/M3rct21P5mE5Fx5XgAUbW1ut9l5Z2/W3KreCvEKSOcDy0oWWrzK98HizxC7ceQREIX+GfP2CgCmzP8PUmgry4YLwuBuD1OGqLemfGT8zTdq/KgGP98cRO/ylDdg3Tw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(38350700002)(38100700002)(2906002)(6862004)(4326008)(8936002)(66946007)(66476007)(66556008)(52116002)(36916002)(5660300002)(54906003)(86362001)(6486002)(83380400001)(316002)(8676002)(26005)(186003)(508600001)(558084003)(6506007)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?8swuNszgtWladoaG2ebwZi/0ZzH6DeyV/bthpZusiDJQYxylmSbA5PRO7qqk?=
 =?us-ascii?Q?7VvYQHpjnVKcs4+A7satuAEMQnvnsFDCBEj3b9Xpgns3QrbvSvSb9sZ5U3NH?=
 =?us-ascii?Q?rLKuDQ+Zh4E1yctPsyKoTxG7Z8Wfd9A+O9dhc1Sf8LZJFWwB4wj1WwlJGVxD?=
 =?us-ascii?Q?lbSr6mSEEfD61JouYuRW6FIuYm5K2H5lync3tmP3xLxXx87mKS0HDKaDyBjo?=
 =?us-ascii?Q?wcuybuiUGt9Wx8qT26WAgBMFrqTcJdsc8PgWhdIu4Oe9xLgHg668qkHKTTRb?=
 =?us-ascii?Q?OcNN7Vp1iDl9y53W22ZMw1YmvjLlSda+Xi5WoupaTqeePxD4kJL8W8YrS9k1?=
 =?us-ascii?Q?5MXqgaFpz+k8zQdJ4k0XmIsJ2XFj9BEEY/W+f/w/QBJnlR+pQFhNsRZBV0gM?=
 =?us-ascii?Q?ArxFxFRQxVkbGi0aIEECqn+FcrzSuvkrDKu+uucg+uO96Z6zf4JOHeksq/98?=
 =?us-ascii?Q?nQl5ZPXqpG5hQlpbHtwNDhxigCd3tIjZkRvQnDxqshd5PwIrLj7xVNuet4mb?=
 =?us-ascii?Q?6pjlKHAOk71nkKVi//P6MvTQ7zIor0zVRqOxe2wIXnvRexAmssGDGM5dMX+U?=
 =?us-ascii?Q?bELptqKzy7PZJiXJ3GopBUHUSPrQnOqMQtiG98a7hxW0pPxHxGqgHf07BxGI?=
 =?us-ascii?Q?nCvZyyu95XACEbquobj7xaTgDa/GCCXswpbQCiN5WY56QrcktkedPaPc0/5p?=
 =?us-ascii?Q?huOfjf6smTgyU5IPoeHOE9zhn6b2jXJJO/CVw3ZrPW6TUWL68mQs+fhmNcUs?=
 =?us-ascii?Q?oPzRBn/D8gFKKFNnuyVbiMkS5FaZat3CKUzVNfWtlc0CzTq7SQbUJAYIKuak?=
 =?us-ascii?Q?Sa2On3EGoEZ/obAmO+/6SceIkNAA3YhQKuC6t/teDMxvwWrZfOEl0qSsnL4W?=
 =?us-ascii?Q?Xo7oA7d8Xx251pvSx4jLRe4uUFpXgpwT8aKmEsPl0YmQ0cXLEreV1OIkB028?=
 =?us-ascii?Q?ug4gAjeAdSw2lQHXB65EXyetLFaentH22o6QXieEgJ+9TtOfxjJsrgRMXT+E?=
 =?us-ascii?Q?0ZwTAuQRbojDATmBh77GnsRIpIbcbl8KL4sav6ScENnXR62MVs1ONADxT7QG?=
 =?us-ascii?Q?Zhtpe8/W5WF+hBlZ0m73lq+nZYQRHCZGi68sdgbC8bKOeY0IK/HQWbnuJRJl?=
 =?us-ascii?Q?JorA06/wHlXj1T/ESfgbaXGaW21mHefygocLmPQ/1tn+DSMiwAvrTjgfD/b5?=
 =?us-ascii?Q?Ttg3SEtVlfHizipMwVmb5G/9GfdS4r0jBJzNj3T6J+6f1KcnTS4lCTvFFXWu?=
 =?us-ascii?Q?Q2NzxQ6ABea2CN0LrYQzB6X1/n1/2195xk/ERh14WJAxy4cG5VeEB/BFLb14?=
 =?us-ascii?Q?V6qTl/T9g4k1KYp81ocVjLwT+kdI1Nkdk8/+DM7FQjXB2ZDnM6UVdWcWycc5?=
 =?us-ascii?Q?4uMburs8Vtf/K0E3huz8tFudnSkyK9MRPYRBLCc+M1a6Jz269Y9bGBdnSMNQ?=
 =?us-ascii?Q?xrDNjO9qEXwo7ptfJJFT/z4roRmVQ1pLKSzST1mqVbwXn0p5EEY+wtU1OgpK?=
 =?us-ascii?Q?FpCVF7PfWCM/JdiFeLIW4nAXOOix/uBy+PLdlzWzffh8XuheQXzJ4v2L6bDt?=
 =?us-ascii?Q?+oJpdFLVj/2VbaiG07pFBN4ZWNdaQV25c1I20QPtfCp1QPQQNvBgr25MqmD7?=
 =?us-ascii?Q?8tDSEMJnEykf7aewPfAJvdpYb1vU5CVTCV6IJGAWQX3Bd+kCvlBuVxZFqwfU?=
 =?us-ascii?Q?gXDlgusFFa6Oj78zk6O3u/uW64TR5IzzEu+lIQMOfrk1BUNGOraCJPRjgsxU?=
 =?us-ascii?Q?755pnrTMt+PRNTb6o2BFHe5QJY6jbZQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 073c7bad-f00d-4d5b-ec41-08da18473efc
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:32:30.6416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hwGzzH7OhkF8PNNh3yM9ri4dh2R9VUt7jXac7Lm4rAo/rmhpAzJ3fZmkBEtZO72lGTEl96s8zj4YXk68qPq0GSp3vjt9qNgWQQclO0sGZLE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1618
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=926 spamscore=0
 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070017
X-Proofpoint-ORIG-GUID: i5ueGU4Do136tb5GM3VcintEL9nTn7F7
X-Proofpoint-GUID: i5ueGU4Do136tb5GM3VcintEL9nTn7F7


Christoph,

> Abstract away implementation details from file systems by providing a
> block_device based helper to retreive the discard granularity.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:35:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:35:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300314.512157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIvD-0001Q1-Be; Thu, 07 Apr 2022 03:34:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300314.512157; Thu, 07 Apr 2022 03:34:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIvD-0001Pu-8H; Thu, 07 Apr 2022 03:34:59 +0000
Received: by outflank-mailman (input) for mailman id 300314;
 Thu, 07 Apr 2022 03:34:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIvB-0001Pm-GF
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:34:57 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b0e44644-b623-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 05:34:56 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2371SjDl024505; 
 Thu, 7 Apr 2022 03:34:34 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6f1tas3d-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:34:34 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373HEhx034877; Thu, 7 Apr 2022 03:34:33 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f974dk6x6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:34:32 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by CY4PR1001MB2200.namprd10.prod.outlook.com (2603:10b6:910:3f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 03:34:30 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:34:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0e44644-b623-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=Dhl90G26tVGJN6+0kzY1Z14efJgXppesGyE9OgKXAkk=;
 b=PmWQbEvT5swaS4vnVygPu92hJ8vj9PPRJ35STBFd0uTjMDBtw30xhHvAiJruGGpVwLHx
 ti2/8OaT253Rw0q0jzCD2wpbGM3BMDOFI7D/udzPEa4HSjqaeXyQag5ZE3xeO/dX95CU
 N2FMQ7BsIMJyIrvO/Xzwub/4DYYUneLv17TqrrGGBhssbQHb/hJ713GcdcGwZGtx5zuE
 3eXhwo6t8CtBWgTHg4Zcg3CTGaNd/mzT6rssskQYsimiO7iUoi93FNQp2FOV83z/seNf
 8+2eoefhbeNKaoMOCxk6Zp+fwGSExFkW7Ur+QewXYs6KWMVcbTN2Fw9//5ZNE+Pu0v2J 9g== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SOk4aVboSNEiOVvt5d2tKYGLeSgkmQTKostxebcRNgrp119qVqncIukXwV5Wjvia5zU9uww0HSJpL0mq5GI8YQRgB5WgS7tYQmYGaQMJochVuOsjER6VcNh9TXfBVg02K4McOkueYDkOwXJRJLMXcj/c9dpCvl5rG1rIY38Teyut644XqDH+ExOu9u515E9nvi/QlDzx1e9OLKJTpC0pSUFpdtXhDS4Oxv70AhgK8PrYL48yJ0NoV2OMEESxb3QiDNqXUmd07V3Ql7h6ZgoCFkqUAKw7drckXY6/I/XB9Z1s7RI/uHw3beTqcf7dBKj5mhjmnQQh+Vwc5NrLrxBv1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dhl90G26tVGJN6+0kzY1Z14efJgXppesGyE9OgKXAkk=;
 b=UPY0UCyYL32Z7ruDgiQ2xg2ki4MLYgtfofxOxbt4GX2cpRZIByQ9WEkkwdGSOCyDxNCtWAI/ouMrQpij94i7Aebk8sXhssGz6okTAc8t+L8IZjpg1obJHFyFtVhttenTU6ZQUTFB1pIov+2mxTmONtsY9L+hVw1GUAqvlZZ+rhHxddvbVhFe0kxBJ+H0zBg6xMb1+46J5aWWwjLvGm9Ge8Nq9x3LDIIhq+s+y8sOAbLmMRu8HKsd1M0OJP2Qlpjh6Umh4hkYozqf/FkorYT6hYJe72VHvFf3NTfC80VF4d8d35cjJf5FnC5FI9ZPSw/ScNxIBNRIJvXE2Msi7W6fUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Dhl90G26tVGJN6+0kzY1Z14efJgXppesGyE9OgKXAkk=;
 b=bbbgNyIljIcOvP0CAmqNL781dot/1GdZD9tp2eIl5aKJv159Bhyu3ODqvRl45+A7QOmIuzTOkP+qDyrDyLBT0F6nIE/Azeg98DJWxwxhzgvonyBMX/vu+NouUF2/m6QNYdfNN1AtL6CVkWGzZVJ6kxG2+3jmThaq/sptFlG0m98=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wng1fu00.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-26-hch@lst.de>
Date: Wed, 06 Apr 2022 23:34:27 -0400
In-Reply-To: <20220406060516.409838-26-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:14 +0200")
Content-Type: text/plain
X-ClientProxiedBy: BYAPR01CA0045.prod.exchangelabs.com (2603:10b6:a03:94::22)
 To PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d446413f-1c36-4dd0-b7ca-08da1847869f
X-MS-TrafficTypeDiagnostic: CY4PR1001MB2200:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR1001MB220039B1E7C83FCF44C38F6F8EE69@CY4PR1001MB2200.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	kQXOcZRdSEjuaBtDcjetAtqBll8S+8aGRn8Hv9IKXz8u61VNfWBvl/0w2Xu2iHpc8otKBZJiSgSqudn9fjyPJ/XzZ524umM+F4BenIFUJ94hXXK9YNkXOyear3/COPiCq9u95FNMu1OT2/HdvfTXcRMjYpLKpOJa+98C0nFGD0vZlNlkRh6fwOHDhAssU2yu5hw8xvoaei78y9SMcvtsrkcMHHnL0G9Zz2gKNE+UZ2Wt2NI4X47yd7YTuRetVXDlbUNxu9tIGzxJo5E9QwCtt+Nc6Szv4l00dVHUCO+VE7e7fWSbxRcEX8ncD2f7Qvbt6b5Qk48qxl9M7pQmZMtu9QMXHQfty0LRIMbN3ipdrzwYHVTE7Uh6VqXLa01r7NcnPT38ik7iYy6J9jSZEvx3kUNjygySDJknKU/2x6EiOyxLE7d4qiBkDIXdXaHT5Owiy5Zgf21vpFqA0XBSRcNAYf1u5iKZKe1nE0MV1LH4CoTqpDVp/3VItQFuY3gfqX3Jm/aDpd9DAUJqYD7nr6TxlWCsWAwJ1DeV1fNJOMn4puOJ/hfN5mngEwxLLRxOjJW6K3ZoS5J1mjGFczi3V7yDy9Z6DFfoDdNKBXJb9yBLFtAPtNmFotrbcf5w0dX22BposfSbPQdfy73SLwPvoeo+ExRydbheeO6Ng7NJc1xaCCCUgYU5uO+wqLD/Vsqq3jtLsEsHPiZe8YA6DVAo16hkFA==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(26005)(52116002)(186003)(2906002)(8936002)(8676002)(5660300002)(6862004)(4326008)(558084003)(38350700002)(66476007)(6486002)(38100700002)(36916002)(66946007)(66556008)(6512007)(6666004)(508600001)(316002)(54906003)(86362001)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?OClvsL1mJtH76eGWXfATOm5aZvAfetUXgIZor60KTFybLgfxxK/y07VPVSLS?=
 =?us-ascii?Q?a1FTh3dx8XuT2m2WqzHGDG69aZ8Fe6jYriY7iXIlNPErk3iEsOJRcFueuQrB?=
 =?us-ascii?Q?2g4XpyaowygMNy5TltYQ/7RMxb8CYfs4hSpXpqR3Txyk9egnq4JvffKEimKu?=
 =?us-ascii?Q?U6vJGNNRoZ5+UaVIvh4UnVOlkkXnQTkTuJ3KZT2znzQcTVJXCMqK05p24lVW?=
 =?us-ascii?Q?r3Ainz2tYkwHfKAcQkHs2Q5Os04vpI882kemelEApSxTIpV0ygGrdLS8IHCr?=
 =?us-ascii?Q?sTE4P4GHoKLJepSjLYIATT64pcZrOSQ3VjFtbx9nzTzMeJtUrkx/ROOWAZ9y?=
 =?us-ascii?Q?pBe/chsV/splOJccdHkOASWqgwMG6fhZML9fT9CgUcM/Fj1tRgyH959+J9UN?=
 =?us-ascii?Q?XrJspaaehtQTCsTqX8tPEL/E5e/Uvy5mZ4lyebNiBUgRhNvGZwHvU7HNr6mW?=
 =?us-ascii?Q?rlbHhAGvrPi2b7Se0rOUo4cF9Jl4UwUatBnyWzJhVw6xICiBQcnVKYNZ/J7c?=
 =?us-ascii?Q?np1TGbblrBIu5buBoPistvLnCb3VUyTNKcKtrg5nLFJsO/TlrcTEhcmGwWDV?=
 =?us-ascii?Q?Y9qO4u17CWMXhJH/eKVlu1hoYmWebi7jIEVILpBjK2CSH2fmdYTVM/sLbWKM?=
 =?us-ascii?Q?+gPHxQ7EJ6cYcrVW12f+v2GouYJKYWljh2xNzRN+CQnjnOqDDy7ZCa5kaM+q?=
 =?us-ascii?Q?6s/IhLCROIQzG+GUCYYWVA7c7j72Lc9uBzAwnxhLZwkLQEFleFsO3sCnj/mT?=
 =?us-ascii?Q?0ZflMKos4evIAWCiHZWcFlnRaRc74ILi/y/cndHD2SAoNI+zFg6DlIy4J1w8?=
 =?us-ascii?Q?LwX7IDk+ia0ArR0O/TXjHW+8KP0lVPw37QWATrN5BfqA+9RK/c3VVPE/BB34?=
 =?us-ascii?Q?s4Vx4RTkqxVic+DHa7M7DUJ2c5QTxL71AuoJ7Z2aW5J/wC6pXtC/hEXZfh74?=
 =?us-ascii?Q?juAiBmHnTsJLXvQL9qcTrZgf/85DSd6L+K6soXRvRaoXFs8PskMZQiNMuBGu?=
 =?us-ascii?Q?u4V/9zCS7fYyU8wG1yvbzkJ93NcjOldptn3JaNuYtTnxWFvja3GA/+fE83kJ?=
 =?us-ascii?Q?W01aUJtIljIonH+l3eOXxF8RRmxsQRa2NSobCM+GZ1Yzw3sB45PNUUGhFdJv?=
 =?us-ascii?Q?3iZBLkzd8AUEdL4ZSllZ383vttQhTg8UUEPbC5rWNYAl6R5RZk+7VMoXIgwG?=
 =?us-ascii?Q?FKDqrtvtUHaRPTjb7phi8rTVNWz+D5Nc+Irb7ig1QGNCspfmdzp7ZvEJzLmS?=
 =?us-ascii?Q?GF+t6Q9Buf41WxdwYHOYcDYdgr3I+eKvSdO9Jc+ORIrmeY/fuh/YY6kHt6x+?=
 =?us-ascii?Q?1bxXm0w/avAB8TqReBmm8pH8Vu7Jn+5tYjYSp1skFasrcr7Eu8Y3GDsig2sL?=
 =?us-ascii?Q?jB/CCOxr7hHWS6/K/zE/xa1Zpiz8kSZQBvvxQwUh37FdN/GfzJBOdxcIZUh/?=
 =?us-ascii?Q?bFuwglqOu6DCeR+UxcZYSPerXd19A4jsUS0u75w0Evv3dPLMXAI8PCK6lg+Y?=
 =?us-ascii?Q?09SXCdTua5x5Qttm0BUoALA+nrKF91G7E+9WNAMtYIq0SlhO+ezV0kCYBD5B?=
 =?us-ascii?Q?RLQL19cvDpoR9TISYvDiHUgWC+ayYSxwW2HaSPYHz8VNIxdw7pyVAgqGBuFD?=
 =?us-ascii?Q?sXR7Nn9Jjy78d/O2JwNRqNKz5etuVZs4Lm4pKmPcIJUUmJyhmem7Ays7N2w9?=
 =?us-ascii?Q?X9JFHY7xSYpC4nbVtOgzXbKEorxkJgALvQxkaLhJgXpInT1GlP/CceITi1Uv?=
 =?us-ascii?Q?il/H+EL5eoA4PPzqwctHlWgNEN8eZtw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d446413f-1c36-4dd0-b7ca-08da1847869f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:34:30.8111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qi5ZBTiCMEHI0hzCpuN8Suykv6oircyOFfbm9FhjnlsASopNs/FgELDlEAXqhXKCWz04v0TbcTa07lyOWMxCueyQiz/XeHZ45dT9SsSwQvg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2200
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070017
X-Proofpoint-ORIG-GUID: KYaZ3coqmCT5WsXPVPLzqm4zdv8P9wTl
X-Proofpoint-GUID: KYaZ3coqmCT5WsXPVPLzqm4zdv8P9wTl


Christoph,

> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.

Very happy to finally see this flag removed!

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:36:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:36:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300317.512168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIwU-00021S-N4; Thu, 07 Apr 2022 03:36:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300317.512168; Thu, 07 Apr 2022 03:36:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncIwU-00021L-Jm; Thu, 07 Apr 2022 03:36:18 +0000
Received: by outflank-mailman (input) for mailman id 300317;
 Thu, 07 Apr 2022 03:36:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncIwT-00021D-R4
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:36:17 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e0bdd64f-b623-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:36:16 +0200 (CEST)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2373LlwI012558; 
 Thu, 7 Apr 2022 03:30:59 GMT
Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta02.appoci.oracle.com [147.154.114.232])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6cwcjat8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:30:58 +0000
Received: from pps.filterd
 (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373FaXk003994; Thu, 7 Apr 2022 03:30:57 GMT
Received: from nam11-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam11lp2172.outbound.protection.outlook.com [104.47.58.172])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97tsu2tf-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:30:57 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by BN6PR10MB1618.namprd10.prod.outlook.com (2603:10b6:405:3::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 03:30:54 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:30:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0bdd64f-b623-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=mYq6byqIyiFjHV8Jr0Ype4Fjz5k3Y7rfnHXOHjRgy9A=;
 b=UoLG9f3rZI3Wt+K09rjVRxZ9B08Rhn+8Grv4X1PNpsDZE/RDxHcFxHCQUgwuEjjZ6rJq
 wNuNdlyjT8obYSvTpy3fP8BF876Zs+hqOsSrpBucEgo+EGYJuY95NOIj/xV4vE8YbjAM
 Vagf4r2oIzDGXZGT1bdnYp5qbnHGYW7ZJYGyzEiZs3s6Ry00lGPuyfSwiiKyo3rmS6Xs
 jIimKiYXYc+jcfhgOe5RxG0KhocTvE23Yl2MlbRB7vMxhf8ntKaiSqTtKKykNy2isH9t
 U+pUa7b3DleXFwYe6m9t9XKqagf5GTTGyB+OMYYemMPa9DZQE+veiYorobvoHI2Ri9I9 vg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZREMpp6H5+VPMk9i2bRpb3y7S8qDajb0lIZ1QGaczRwc0mi/PK39l7MJBAUSRl5P+pACWwAEnZUNIln8sTVXnUBo+4GQitsaV1H8bnnMOFOkWVDowIHrx94bwa7+AeGDQCPA3vQYQGu6zzA7Jiyx1IXzj0YzihvwAELEmtxsPzjQUQY2Rh+2m0HQBxlc0rJkXgC9p9YVyRDpVgO/vIxbw8CMZ+f89VfeOfMvHY5aJODzlqCpSeYHdO+JrbH4jwSJoXeNwaO0XWvSU2AajIf29qu0m4Ug1nbAlqQWC3cO0RbwWyD2aAz1jeYjJ6oPDJBSOl41RjVyi6kZSlPN6rJDKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mYq6byqIyiFjHV8Jr0Ype4Fjz5k3Y7rfnHXOHjRgy9A=;
 b=nSyNgauYv2h5VXaSrOWCSBqeiU+09xRdINopgU01a3b83Eu0h0BNFXVyealu1LLMQOE6sVYw2/g7D/m7USv0atSRM6Qu6sb5Z55Wv6P4rOX3VdWwJ7bXMmS/h5tTp80hywx3mBz94nc73Nz0yndnWY75E1aAnYORpsHx73NyAppFTdJVB9wjxN8qS/e1atQy4ijscqEdyOWLQWQTvM19Mik4GRzhH3ZKiGX76FWMK9myCgW1KSNLwWjaRE8HOYgYigCJTys8K1GdXjkulGFH3tcOGDRQsbYKr63UQdFUaBE1fAPi3OgztJn20kUwj5Wpf4h8EZDqNmXkz8Ih7SOlzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mYq6byqIyiFjHV8Jr0Ype4Fjz5k3Y7rfnHXOHjRgy9A=;
 b=Eq21Wo+j1JF7OTWA82B9borMkMphwY8igrWHR4LUBmyqVvlgcx8FVIJUwbmKdh+L5EQ9Jv9PuMecfsquNzJY+mcwWkiVOlR6FgCJX0GNs3UISUzrsOhNNFWZSMcdkqsDwJX8uKCIJCU4bK3t5lY/Fsw3+RryaRh/fdY/cELhbQs=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 23/27] block: add a
 bdev_max_discard_sectors helper
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq18rshh8o7.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-24-hch@lst.de>
Date: Wed, 06 Apr 2022 23:30:51 -0400
In-Reply-To: <20220406060516.409838-24-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:12 +0200")
Content-Type: text/plain
X-ClientProxiedBy: SN1PR12CA0105.namprd12.prod.outlook.com
 (2603:10b6:802:21::40) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1be5c088-2287-49ae-6394-08da18470588
X-MS-TrafficTypeDiagnostic: BN6PR10MB1618:EE_
X-Microsoft-Antispam-PRVS: 
	<BN6PR10MB1618E32487955B9F9B5D96918EE69@BN6PR10MB1618.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	8gxwN1qd766/FEvTxZsvps09fsNZz2Blg4R07kgI9m9KSHnl0dLCc5qCOHdyDxKnJMTlLhipMc6ID3ADVW6mLW8YWr4aDKYjz1h4KSFybqlMxpb/2tKUo23Y/adTdXMem7XT/fUObner72zcjRSg9AZsmvCkSc4GkR/XUqZN/tws0pXNieSzyPkrRkDl/HbLNN4lUZYwxMbsn5ThClVT/AwTw9laykF7s/6rWzhc0PmPp5luCM4bEN5e13q2Bbbs44WqzYvvwoCG3rRRMhRDKZ46DBp0kDB+2rRhYaQ6YZ03QhfIzOV3PI6eM5qkyquBKVNW1nWJvk1Zf2Hg175UcZLAjPMw7F7jYvcP+l2YeA7GLNiho45HDNKIRtnyr80hV25BKUKMD/e8nQwn7Wtc/rbZrz3Q54VW70zH3epBZ4Tlpt0RNp89LnvKYkO9gqkqDVvgvDD4qniH8WKJLShlrTETisSnC8GCfHLB5SAg2uGGxoV3D8caapwIEImkU5R0mR+7bHgZpp5bfynlIY3iTbZBMTFeNoRjZ8Q/hzb7qpUuwKtXjyNo4oKY6edsDD6O9ruwMsBk9t3EFSfgORHTFLMTJpj0B4joVjWC8geFsavcrJTmBtGj+jTFKdq8SCTPNrSLiNDJ87mHeErrwzYXnk3/Ke9fAuZHJ6zhbOuL7p3LsssEMTZUQXuxoEqbWhtMa0KFiBBxrkYGHhNF6WGX1A==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4744005)(7416002)(38350700002)(38100700002)(2906002)(6862004)(4326008)(8936002)(66946007)(66476007)(66556008)(6666004)(52116002)(36916002)(5660300002)(54906003)(86362001)(6486002)(83380400001)(316002)(8676002)(26005)(186003)(508600001)(6506007)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?ihvR7bczvaIQG7216CB5ol7nO55w+ON2inWn385F6dh/MzMWSfxomVyaGD77?=
 =?us-ascii?Q?pW8D0hyTx7T7mV7k796CjeXFDR/6kzd3SKmnRnGOYRBe/i42T+KfII+CTx0c?=
 =?us-ascii?Q?m8pdY1ElIYOYf2JoQHxnANYxDi2UKRlWIHQfxRaU4df4+P9mkUnX37GG8J9P?=
 =?us-ascii?Q?nBryl26ZzROotKfi+iQHT5maY8Y3viYToEXME2P5XZBCO/miHuhySS63mZAR?=
 =?us-ascii?Q?fMr3JT9qm6osYO8dpXLa3WEroi+gaUOpd900IdcvdU+llj3jnjCpQLd8uFMl?=
 =?us-ascii?Q?qNHavVkYIe2a4GVuafKp4g82wPBzMpQrKE1kOjGgIFwLF2fXbWI/eZeizGWv?=
 =?us-ascii?Q?TQwE880JqTrbdCbSYHjGGbs5Q5eeRxvarjqzsnbACAd+sR9HsTDpJJxA26vu?=
 =?us-ascii?Q?CfGIHH05IgvFMX901w6+gjBnErff2m/+tw/eDynQdNf7Deqjp2vBjxC3xAgf?=
 =?us-ascii?Q?pT8ddmtP1XEjife3m+TAhoH5RKgtWqy0JCd6uymKBI0Ni77JqOAk8rBnqU8Q?=
 =?us-ascii?Q?Su7UklOI7XCxWw6I0ktsadRj6yOqvBqwLq1oZVcJQ2XNTafCNXO4uNF6DvRb?=
 =?us-ascii?Q?fiEQf1G0NDJbjkSfLRYHyiQdJQ5L0t5X0cr3bzCo4deMeELbapEGI5cDPo7e?=
 =?us-ascii?Q?I4pTCP7o8mZe2wm7Rgv5hS338Xz27geN6vruuXlgSEejOkAZUoFIKXBR2IB7?=
 =?us-ascii?Q?/8+pTmu2kJqldFYVou8PaPL2w8RxFF5hU6zJXk9xuOh/DDwrd7X4dS0/+v9x?=
 =?us-ascii?Q?AzL+AvAOI12o8KyrGCISq//Kyepv0JFq8D6ZbKMigU1Gzbwc7IxQIEOIq5aI?=
 =?us-ascii?Q?fvT4D6CU7Ns3AMoJPRDHoK2O7s89XEk0nzqYgV8EOOAonVQRlV/WcL4+CPH0?=
 =?us-ascii?Q?y7aQVIE9nilKoI+qkImwkxdtwBwFB1ukxPmjbLO8iyAAeTwFH1E6BHf/xgbV?=
 =?us-ascii?Q?swFGmP5HI0idJPLHNlIkaLaYrdeAiSZv6ywVAhiwsMJ8ky0o/7qQlO+ycaSA?=
 =?us-ascii?Q?XvHvuki8VDF64H5Ipj1dzhjS8TQojQ84NBKOGqv67kWHXN2AERiW3gxM5u5U?=
 =?us-ascii?Q?MguLFXcDY/ytuOK5mbl3zOzdWW+2VUFdfBHuv6IKXAeyv+05G9zLy84ACG2/?=
 =?us-ascii?Q?2oK4tPYgouzSGTwfeggOmxM4lqXmZfu8PECYwEzIUATZzbUk2LXUqyOId9Ww?=
 =?us-ascii?Q?yxImetNs+yiutTXJSBFpwwnaUwfPQUQ0+qh7K2h+gABqTZANE7EDpoMe6iNd?=
 =?us-ascii?Q?c9546r57vTNquOACsA6+pt1IpTonnQDCFKHWw8FX4GvyxavbDhry3A0ymwjp?=
 =?us-ascii?Q?1VX7GvNpu1Ybfq1K/Ofwey6M2gwcksu0I0bqfrKU3BtLki2st3g+Xjfrjuda?=
 =?us-ascii?Q?fBdoZj5TwY8RN+0TFsN4oEQgrZ9UwyADY8zu4Ct6JIrjFIulqVB+IlaxXlhM?=
 =?us-ascii?Q?EFn9F/zsWNkXYQC/WXVI6hmKeIuzB+UJayXXwJvSAry1w1895YcQx+/gIdrg?=
 =?us-ascii?Q?EjdxHGTjc6+NfWqwp1siJQE+tUmvy+3cPWpo9EMItkn/ZLvdrzWKP2XnJ1MA?=
 =?us-ascii?Q?5+SsSLBXqr5jKW9B+1RYmID9CwCDV1D04zmqavLc9iVEmYO9YqExX2RJQ9oy?=
 =?us-ascii?Q?9GWgc/r92xStyJx0I3lvVeHgUraywUOK3T469OLkd7rpJVtPR01OUbnc9V+5?=
 =?us-ascii?Q?DW2LqW5EvmlKR3SYyggM6qOiF9bVeTV6+QkQJ5Xh/aEOy7NjqZTPCn6LTKyW?=
 =?us-ascii?Q?Ht/8ijb3KU0pi0uuR7R4ZsXzy+B3izE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1be5c088-2287-49ae-6394-08da18470588
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:30:54.2477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fZsxFmvQzbP4r8yjJO40wi4P7IVmH9WINqip+vYPN9usm3gvSP/VHIESPlyRfsIAkdL64OGdqNNYNpMQLS7mVX4jP/XZqTlg8HmQkUT1qUo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1618
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070017
X-Proofpoint-ORIG-GUID: UEFFmcnOQOZkMAhFK4yUzrohDzy5qqTT
X-Proofpoint-GUID: UEFFmcnOQOZkMAhFK4yUzrohDzy5qqTT


Christoph,

> Add a helper to query the number of sectors support per each discard
> bio based on the block device and use this helper to stop various
> places from poking into the request_queue to see if discard is
> supported and if so how much.  This mirrors what is done e.g. for
> write zeroes as well.

Nicer!

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:42:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:42:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300323.512179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncJ2L-0003gm-G9; Thu, 07 Apr 2022 03:42:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300323.512179; Thu, 07 Apr 2022 03:42:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncJ2L-0003gf-CR; Thu, 07 Apr 2022 03:42:21 +0000
Received: by outflank-mailman (input) for mailman id 300323;
 Thu, 07 Apr 2022 03:42:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HACk=UR=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1ncJ2K-0003gZ-0Y
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 03:42:20 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b90559cc-b624-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 05:42:18 +0200 (CEST)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 236Lmv86000758; 
 Thu, 7 Apr 2022 03:36:57 GMT
Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta02.appoci.oracle.com [147.154.18.20])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6e3stjs6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:36:57 +0000
Received: from pps.filterd
 (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 2373aWrY036365; Thu, 7 Apr 2022 03:36:56 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2177.outbound.protection.outlook.com [104.47.57.177])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f9803hf4d-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 03:36:56 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by CY4PR1001MB2200.namprd10.prod.outlook.com (2603:10b6:910:3f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 03:36:54 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::48e3:d153:6df4:fbed%4]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 03:36:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b90559cc-b624-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=0fSH05fVrj4EsKu7GruSr6V8eDQcmEnuW15iSPtYu3U=;
 b=iag3pmaogwT0fVNNtSBn/JoHcAOg5JTOiwAr7G+XUgGvcNjxegCBNThSYqe+F4T0NNMS
 B/59HaBNX03xPzKp11moq8ZsFxeak9RIA3RrLouwkC4YK+71tDVE0sdTjSK6BxxCftbo
 0EZ+onJIUBjU/ENdCS5sy3svT9bx0UEJmXm8G3Vy6SHK2y8Xy6l3WbHoInOxD2xK3+eI
 6prGeQ9aYuOEK5xF9lkj3vVuts9fdh0ePfPpNw+bzbLVZ7ePbcRp8+ED14FvB3NB4vug
 6MW3QIbWBa8G316LrQWtBIEFgUnKlZc368HFrB7khC0iArMf4byEey+uTWpLJY8E6DL7 IA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bBtux/rJhtrl5yFsMQjtRJdNwFQDZ9e04K1j7qVY0mAmG6dIu7xDxjOrjBgp+kFuKMueCgrSMqOXko+XEZyej82ypi5BX6JAzWkqNsGhUOaj9PoAInFp9H4bruc2aiGt0CpE3Oue7uzYHCHlFhY6fVqtxqRotkx5lbzGr+6d27jpkn9KVr+sww7X6KU3E78q4Zy5BVnQgPfDp+CNOWIqTN9BpVqzHDmMW5bonjigwV/kHLDJthWtpi54PVY2SZSFbWTXEgGbPtwV4PNWRmZ1i1EYm+cP89DdG7R2Kg5tQR1oYE8DTKOr8BIpQ4stnk3+Ku4OfQA0CTF1UpS9t3yQoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0fSH05fVrj4EsKu7GruSr6V8eDQcmEnuW15iSPtYu3U=;
 b=odYnQWdRRJ4FXJrzHv2+etqgNvxmSn2vvpwdNqfb5DEFoolf4R4cEZiboooNhkOdz02fjvfzGeFU7WGIKhYip/D1zaygAcFdVFpG1UGZbKuLWYf8zYKkFZgprk9Qnv0MrM3oSQ6x29lGO59/H2p0zdh2xcBWmLowqjeG53Vxoj6ei1BJCaF84DHi6/jNnw2LpC8Y1hWzXH6Cpuoyu4EQhhOJmke/h01RkdXQ5cKLYlvUIchQcC5wSWttmpGfg/NOaL99WAPP9WKqRwjUBcVfR6O/V1Et/yQknL/BQ8lm+kWpbBkbwma4xwMnQyw9dzYiYwoQIuGa+qHEbJtauHpjbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0fSH05fVrj4EsKu7GruSr6V8eDQcmEnuW15iSPtYu3U=;
 b=lD2AOIVmspgZK/pwyBQri5RZA765JIpiAnX41gCyPVtP+Y0SeaHhVXkNeMjdO0jW+v8zL255prslBhs6U+n+XeYmqaxrxa75WKicpSdy1fVEeZ7x8Qf8na7UC0cNAtS20puZeuMXz7/6AAnLUVOLh00DYpJUCv3AWFnY07aff5g=
To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE
	from REQ_OP_DISCARD
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1r169fttr.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
	<20220406060516.409838-27-hch@lst.de>
Date: Wed, 06 Apr 2022 23:36:52 -0400
In-Reply-To: <20220406060516.409838-27-hch@lst.de> (Christoph Hellwig via
	Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:15 +0200")
Content-Type: text/plain
X-ClientProxiedBy: CH2PR20CA0025.namprd20.prod.outlook.com
 (2603:10b6:610:58::35) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75691adb-1eb9-469a-d0c0-08da1847dc61
X-MS-TrafficTypeDiagnostic: CY4PR1001MB2200:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR1001MB220040178D0947BB8E0291BA8EE69@CY4PR1001MB2200.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	ZxwI0u0en9TbpPBjX+jKQqZmtEjdTU+hpQXjR0MzzgXrLrJ065c+0SD/3sGksMlfGH/BB2BD7TmYRbIwz1E2JgaPlpy/OS74QnhtwcOrRBvy8UBGECnQRnU8lCQ175MRgpma4j/Vop6oaQGlIk8AU2Q9DcipoSNEy5NbVfSKmQG6Be/CKtH8M8hPgFY8MD2skrgtTuu/qSpHcuM3x+NVIzIhwe+1wmhZuwqfVWY1Y89pvX6NSPNe6ailXnUeNs5dwWEGWjyKwY1aHy0mflMVqfGe/dZSSMUON9lk6WXh32PaXbATnzVymeODLke9XQ7v6aiMzOvTNIUiYzu9Fdq6xL1rUzwmnDzGDpI56rFwJBKxvwSYIWRTp/oOcqSCFtXIPVmEWHWsNj3Rm2t1cium8u/AubDLbk38TzvsTW5LdTC9aUjfLW8vA0bj1OU8jNICNqopoV1Qm99CJW8WMOFYAKzbw0U3TfNDU4wU8Gem6Huq7Ql3SR5sVvEWkyXQp+ysiyQKlEP0mmidBgWBgt02lxRtOpH9nBgBsQclSHetDc7nWBlwsiG6Zzj5ZDXRBw/W8ajrBDzFxCOIaRd6CfbhOO+fMLikDEHFGEmHS//VkhovtgJkPbJKtH/8df2Q7/OVLXPH8kNlpyhs++T1nL95ewdcC+tuWEQbgMOBzlbJ37TIjdyetJ/Cgv4PtXrAMopz/WRYSdvX/1UuU+jv2RpzGA==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4744005)(7416002)(26005)(52116002)(186003)(2906002)(8936002)(5660300002)(6862004)(4326008)(38350700002)(66476007)(6486002)(38100700002)(36916002)(66946007)(83380400001)(66556008)(6512007)(508600001)(316002)(54906003)(86362001)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?g82OZEWV3QyBoHz83z1vwz2sBBr7It7JAYL4pSpihGQXQVsMQI4Ppcfg6J4u?=
 =?us-ascii?Q?PU50KIresDLXg+OH6CjUolrM2T6sKjMXWLOBpEuO46hh6PVTbrhpVU1+JjlU?=
 =?us-ascii?Q?mMAENapGGv/v/7ycuAUX/W235hHMNzvQ28L931QOmUOYyDQilhcvklPMETU2?=
 =?us-ascii?Q?pgAaX6+ZIZe6zfuKqD0235OLnPBNMavw7xq8qVz1ER4C1K7YgEjgmbmpJx5k?=
 =?us-ascii?Q?3SYZGv56O0KMd3mrspayjqV2t+/s7EyFYryrF/fWsWOR+fYpuy4k42flI4qa?=
 =?us-ascii?Q?+Jj//A6FqJkVvhFBz1CokQe7NpOr8+P5svmNoAC9H1asUzJ//wzK3Cb2QThH?=
 =?us-ascii?Q?wGH96Vv9SpG8KzErtx0luYvL6aLZviM+Qv+rUvQYuzYg7EipDuWHC6T+KJfc?=
 =?us-ascii?Q?x6ell8xS3Kez/vWwpRHgFLoxidiEkZOzceKeBos1psf+8J1ybirGML0xB+RF?=
 =?us-ascii?Q?yJo9Gr23XWxqDZiwP72uIuiJDswH1Ka0fmQMibUXdHrDLCB/+wQhTYV7wfFF?=
 =?us-ascii?Q?RysQUrk3OWUKJC08cSiPZWVS/LoMxzh8Zv6lV3t1JBXJpIfa7nH7uz7jZHVf?=
 =?us-ascii?Q?BNMiaHkgUTR7mfVOAjWa4+01QacTB4FubvclHAPnyMm/MetdPuVJEQKX6W+p?=
 =?us-ascii?Q?lvTyo+/wbNniMJrJNISMItIq6Gv9VDW8kNKliftLs7Wb8gSdgAIGYSk0k9DR?=
 =?us-ascii?Q?O3MAe5iLlMlNW4wVRoKF4wgKQGIdgT4Td+vUWRlW292GBQo9RdtGTn+CMluu?=
 =?us-ascii?Q?XeyFRr0boZf3h5/63NI+aMBToiAMAhIyK9lGbrVCdh5tIZXW5tXQi24PiVNb?=
 =?us-ascii?Q?C1z2z+KEHPYZ5NfTImPYmsNF7sG794hTNnRo0z82+gkF81tNCp6eReUombyS?=
 =?us-ascii?Q?CKfvPa+L3z944Cx7CLsm+FkNEmlM/mokqmy+meiuNMIbOgEVOGEnb1O5ybOI?=
 =?us-ascii?Q?6rVxntAu+AA/gNacun3DPGUuwwbd9+pdBjoC8hr86lHaljzim+loGq+V6RCo?=
 =?us-ascii?Q?nlJvZpMk9naBhExYED7lBpJjT6CO7pUEz+fIxvaGKLiIe0T+AnNxta2JtD2f?=
 =?us-ascii?Q?ycutLjj+XVcdbDaWt5HLsMnCStH7jrv9wZxHfHjMxdHxU47CkmyydLC6wqn9?=
 =?us-ascii?Q?70Fj3sK43LNgjbB9qL7BFyqmMT7soDMzg/voargbfqRVIEErbM/isHtWTmyQ?=
 =?us-ascii?Q?IDCwvunTzHjXRqo3uDkVL2PNQjrMrfNfl4s36onpZ/M5UMAv9Wp+rU8/V/IJ?=
 =?us-ascii?Q?ZvEmN2wi2clCy+5ZhmPjG4DAZ5Ea2Xs2X1s9FKpLHUrIPOKELkyfsCXH7Xlw?=
 =?us-ascii?Q?2wTJ+y3s3gOXJw3nHkOH6x5WfKGk9BGnXKWAAOJzfowQPDK1nykLCqLMqAHZ?=
 =?us-ascii?Q?iVbJIXtTEx5czdjx6+VowJ3GiRfdzL++TM+xbIMsEwev3+FxNDza98tZa63t?=
 =?us-ascii?Q?fMsevOztJxpUydWpvzh7VVW3mAwJroktBg1Wnd+o7LnG/vmoNT2AMttO2Nuk?=
 =?us-ascii?Q?5USTcGTEonuwQFPubXBavRrNfqpa9MkYOR3kuU3gHbvqvfa4N5ToV+BqQb1Q?=
 =?us-ascii?Q?K7a90zxFWiWPAwTqZ8ODDAMj4BPZOS6iffa+ULDPfA9MGhBFhha0QkG/UYeJ?=
 =?us-ascii?Q?XSgAC08xWhGOlnpbglcYSiRxhPgyeyJOFwfiOlbdTkI/Iql0Q82Gf73x9dX/?=
 =?us-ascii?Q?699odWRzsDBBcTy9wW/nJ3yeNUyCCNXq1qZCig32aJOvyHJZcokuyqzOn9cZ?=
 =?us-ascii?Q?hoyJIeCr1vf7iUvpVbxUwHDen9QGcfo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75691adb-1eb9-469a-d0c0-08da1847dc61
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:36:54.7050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xxI5XHXU2sbc/fWC9ndbwbsQZvdnJajAa1/8lQ+60/0I67zBHPfFXIKkzPg1a7pl8jTUriXu7jFYTH2C+zxBhKKaELIPNtXE5AOXygQB+ng=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2200
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070018
X-Proofpoint-ORIG-GUID: PQKfP4CskAkKSo2NFyL3CJikBxo0t_l1
X-Proofpoint-GUID: PQKfP4CskAkKSo2NFyL3CJikBxo0t_l1


Christoph,

> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint.  Fully split the limits and helper
> infrastructure to make the separation more clear.

Great!

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 03:52:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 03:52:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300328.512190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncJCJ-0005L9-Dz; Thu, 07 Apr 2022 03:52:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300328.512190; Thu, 07 Apr 2022 03:52:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncJCJ-0005L2-Aw; Thu, 07 Apr 2022 03:52:39 +0000
Received: by outflank-mailman (input) for mailman id 300328;
 Thu, 07 Apr 2022 03:52:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncJCH-0005Ks-VQ; Thu, 07 Apr 2022 03:52:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncJCH-0005Fu-PA; Thu, 07 Apr 2022 03:52:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncJCH-0002Ff-3T; Thu, 07 Apr 2022 03:52:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncJCH-0007x4-2e; Thu, 07 Apr 2022 03:52:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xklbiR1pnder17l0SZlNf4zje+uX1U09Clto8ZfkGzQ=; b=FOG/PRT0toI9+IaZdIqFPWKYYT
	NqWMnIszNRD7ok1sKFduJSYnIEuBjEJnu+mBRw+AUGp8eXf34QZkBA/zPHhyXsctO0s8EFqYnCAJG
	jR3IngFihpJtWSB0I9SpHXHiXiABX8HQP/D/qzCtCwwV/4rMO7SxKk+G9p7F89gXvBGs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169194-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 169194: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2c026fe1f159494b3ec05f19ddfb3d39ff901296
X-Osstest-Versions-That:
    xen=54e37f44a219a987189c566e15ccad7af0bcc4ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 03:52:37 +0000

flight 169194 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169194/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169179
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169179
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169179
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169179
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169179
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169179
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169179
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169179
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169179
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169179
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169179
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169179
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  2c026fe1f159494b3ec05f19ddfb3d39ff901296
baseline version:
 xen                  54e37f44a219a987189c566e15ccad7af0bcc4ed

Last test of basis   169179  2022-04-05 13:07:05 Z    1 days
Testing same since   169194  2022-04-06 08:39:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jason Andryuk <jandryuk@gmail.com>
  Juergen Gross <jgross@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   54e37f44a2..2c026fe1f1  2c026fe1f159494b3ec05f19ddfb3d39ff901296 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 04:29:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 04:29:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300343.512225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncJlD-0001Jc-Mi; Thu, 07 Apr 2022 04:28:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300343.512225; Thu, 07 Apr 2022 04:28:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncJlD-0001JV-II; Thu, 07 Apr 2022 04:28:43 +0000
Received: by outflank-mailman (input) for mailman id 300343;
 Thu, 07 Apr 2022 04:28:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncJlC-0001JL-5P; Thu, 07 Apr 2022 04:28:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncJlC-0005vn-1E; Thu, 07 Apr 2022 04:28:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncJlB-0003xG-FO; Thu, 07 Apr 2022 04:28:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncJlB-0000eR-Ex; Thu, 07 Apr 2022 04:28:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=79LLfcWonu30lBUIQwSpIRr9uS6+aMJw2Us3GB64oBM=; b=EBpRzU2yi7Qwu+rpCufpLmpOOf
	aPrNO4bIlWcDm1ztO1ZfpVUxR4eYRODe+6y+O5sarh6L0TuzHoqxjxFJn7saMgsIRPgFbyiTqciFB
	5NT+tLfw4NGsIBhtDStHPti2vSo5SSQYPJpWMHZH/NXK95iOVKYw0r67r41/XDsRmmaM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169193-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169193: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=10cd51d5bf5f2d9ebe5f36a1b428f65ff5efd115
X-Osstest-Versions-That:
    xen=aaa61028803a64e72f1026f9608dfa34d0c255ec
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 04:28:41 +0000

flight 169193 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169193/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169178
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169178
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169178
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169178
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169178
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169178
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169178
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169178
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169178
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169178
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169178
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169178
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  10cd51d5bf5f2d9ebe5f36a1b428f65ff5efd115
baseline version:
 xen                  aaa61028803a64e72f1026f9608dfa34d0c255ec

Last test of basis   169178  2022-04-05 13:07:05 Z    1 days
Testing same since   169193  2022-04-06 08:39:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jason Andryuk <jandryuk@gmail.com>
  Juergen Gross <jgross@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   aaa6102880..10cd51d5bf  10cd51d5bf5f2d9ebe5f36a1b428f65ff5efd115 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 05:10:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 05:10:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300358.512260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncKPZ-0007ew-6A; Thu, 07 Apr 2022 05:10:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300358.512260; Thu, 07 Apr 2022 05:10:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncKPZ-0007ep-3I; Thu, 07 Apr 2022 05:10:25 +0000
Received: by outflank-mailman (input) for mailman id 300358;
 Thu, 07 Apr 2022 05:10:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0ZzD=UR=intel.com=lkp@srs-se1.protection.inumbo.net>)
 id 1ncKPX-0007ej-KW
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 05:10:24 +0000
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 036be10f-b631-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 07:10:19 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Apr 2022 22:10:16 -0700
Received: from lkp-server02.sh.intel.com (HELO a44fdfb70b94) ([10.239.97.151])
 by orsmga003.jf.intel.com with ESMTP; 06 Apr 2022 22:10:13 -0700
Received: from kbuild by a44fdfb70b94 with local (Exim 4.95)
 (envelope-from <lkp@intel.com>) id 1ncKPM-00055m-NU;
 Thu, 07 Apr 2022 05:10:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 036be10f-b631-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649308219; x=1680844219;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=myTDEhVwrLnCdPZFU3d6dVMJ7GMZKVQMpzunGAxXFgE=;
  b=jRbUmBThTYZsz0PAaq+NtUw8p3RyHnTwuasJLkoHaxMkF8Z0K5pH9Df1
   QBbMqkBzCTMe+nMlMxtS7Q2IAxYYbX3wfi8e/eOvdQe3Fy11HtsCs+j2x
   Vv+yL/FK6HlO64vb+/uJ3BR7w2V0gLhoKXKR3ZKSg72ZKVFRDKgTMc6KQ
   jn2HkGL4EULOqjUhIk+lRr+1VjO5xE1qsADrNmrRt3DUQjRdS7GxNu5OC
   2I/6RRe9oj3Dpej9NdguWZnsk6J8/wy1MA3NmD0Ui/XOs0V7AVa5WePMs
   33MjhoEZiN8m0JeQHmxM4yO1eKhLmBOppICWUBUhT9vdOQAmtahQ//Fw8
   Q==;
X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="347671270"
X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; 
   d="scan'208";a="347671270"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; 
   d="scan'208";a="506008518"
Date: Thu, 7 Apr 2022 13:09:27 +0800
From: kernel test robot <lkp@intel.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone
Message-ID: <202204071359.uas4tsu0-lkp@intel.com>
References: <20220406133229.15979-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406133229.15979-1-jgross@suse.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

Hi Juergen,

I love your patch! Yet something to improve:

[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on linus/master linux/master v5.18-rc1 next-20220406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Juergen-Gross/xen-balloon-fix-page-onlining-when-populating-new-zone/20220407-000935
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: arm64-randconfig-r011-20220406 (https://download.01.org/0day-ci/archive/20220407/202204071359.uas4tsu0-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b3deb59d5386ade4fb227038f202a9bdb8ade4ab
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Juergen-Gross/xen-balloon-fix-page-onlining-when-populating-new-zone/20220407-000935
        git checkout b3deb59d5386ade4fb227038f202a9bdb8ade4ab
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/xen/balloon.c: In function 'decrease_reservation':
>> drivers/xen/balloon.c:518:24: error: implicit declaration of function 'alloc_page_for_balloon' [-Werror=implicit-function-declaration]
     518 |                 page = alloc_page_for_balloon(gfp);
         |                        ^~~~~~~~~~~~~~~~~~~~~~
   drivers/xen/balloon.c:518:22: warning: assignment to 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     518 |                 page = alloc_page_for_balloon(gfp);
         |                      ^
>> drivers/xen/balloon.c:545:17: error: implicit declaration of function 'add_page_to_balloon' [-Werror=implicit-function-declaration]
     545 |                 add_page_to_balloon(page);
         |                 ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/alloc_page_for_balloon +518 drivers/xen/balloon.c

   505	
   506	static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
   507	{
   508		enum bp_state state = BP_DONE;
   509		unsigned long i;
   510		struct page *page, *tmp;
   511		int ret;
   512		LIST_HEAD(pages);
   513	
   514		if (nr_pages > ARRAY_SIZE(frame_list))
   515			nr_pages = ARRAY_SIZE(frame_list);
   516	
   517		for (i = 0; i < nr_pages; i++) {
 > 518			page = alloc_page_for_balloon(gfp);
   519			if (page == NULL) {
   520				nr_pages = i;
   521				state = BP_EAGAIN;
   522				break;
   523			}
   524			list_add(&page->lru, &pages);
   525		}
   526	
   527		/*
   528		 * Ensure that ballooned highmem pages don't have kmaps.
   529		 *
   530		 * Do this before changing the p2m as kmap_flush_unused()
   531		 * reads PTEs to obtain pages (and hence needs the original
   532		 * p2m entry).
   533		 */
   534		kmap_flush_unused();
   535	
   536		/*
   537		 * Setup the frame, update direct mapping, invalidate P2M,
   538		 * and add to balloon.
   539		 */
   540		i = 0;
   541		list_for_each_entry_safe(page, tmp, &pages, lru) {
   542			frame_list[i++] = xen_page_to_gfn(page);
   543	
   544			list_del(&page->lru);
 > 545			add_page_to_balloon(page);
   546		}
   547	
   548		flush_tlb_all();
   549	
   550		ret = xenmem_reservation_decrease(nr_pages, frame_list);
   551		BUG_ON(ret != nr_pages);
   552	
   553		balloon_stats.current_pages -= nr_pages;
   554	
   555		return state;
   556	}
   557	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 05:16:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 05:16:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300362.512270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncKVL-0008KR-Rg; Thu, 07 Apr 2022 05:16:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300362.512270; Thu, 07 Apr 2022 05:16:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncKVL-0008KK-Oo; Thu, 07 Apr 2022 05:16:23 +0000
Received: by outflank-mailman (input) for mailman id 300362;
 Thu, 07 Apr 2022 05:16:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hdtG=UR=suse.de=colyli@srs-se1.protection.inumbo.net>)
 id 1ncKVK-0008KE-M6
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 05:16:23 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc51ed81-b631-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 07:16:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B76E021122;
 Thu,  7 Apr 2022 05:16:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 81FE713A66;
 Thu,  7 Apr 2022 05:16:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0FojFJ5zTmLoQAAAMHmgww
 (envelope-from <colyli@suse.de>); Thu, 07 Apr 2022 05:16:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc51ed81-b631-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1649308580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3mSljOe/NcqR0nJ5LYJS1IexMd+XWdNrUUnY7u8p4ss=;
	b=S8u6tT4MOmjtYxCqeb3qmZNn/bHZfqArgo8fnUTx30csmaC8EzqkNzsFCobTftsYYuUnLo
	j2CEECTylf45En922p7zGMdDliHlOB0W/p8IrTqMAAnrwN0MZYWeSbIR9ZZAecmXn6aNZm
	pYWtnVOXe4neFTwM3RVsKoYuaP4pLxY=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1649308580;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3mSljOe/NcqR0nJ5LYJS1IexMd+XWdNrUUnY7u8p4ss=;
	b=8wVCLmcmG2fqohkxPiOTT+zNzsZDHS4xqLNwNHKElc9o7Ynzusas5Vi1t3zyX0xdAJFT8y
	NypPr2uWld7TnxBQ==
Message-ID: <2aee78dd-d5b6-5444-da28-34ab2631b264@suse.de>
Date: Thu, 7 Apr 2022 13:16:12 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH 23/27] block: add a bdev_max_discard_sectors helper
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 nbd@other.debian.org, ceph-devel@vger.kernel.org,
 virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
 linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
 linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-scsi@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
 target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
 linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
 cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
 linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
 ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-24-hch@lst.de>
From: Coly Li <colyli@suse.de>
In-Reply-To: <20220406060516.409838-24-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/6/22 2:05 PM, Christoph Hellwig wrote:
> Add a helper to query the number of sectors support per each discard bio
> based on the block device and use this helper to stop various places from
> poking into the request_queue to see if discard is supported and if so how
> much.  This mirrors what is done e.g. for write zeroes as well.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>


For the bcache part,

Acked-by: Coly Li <colyli@suse.de>


Thanks.


Coly Li



> ---
>   block/blk-core.c                    |  2 +-
>   block/blk-lib.c                     |  2 +-
>   block/ioctl.c                       |  3 +--
>   drivers/block/drbd/drbd_main.c      |  2 +-
>   drivers/block/drbd/drbd_nl.c        | 12 +++++++-----
>   drivers/block/drbd/drbd_receiver.c  |  5 ++---
>   drivers/block/loop.c                |  9 +++------
>   drivers/block/rnbd/rnbd-srv-dev.h   |  6 +-----
>   drivers/block/xen-blkback/xenbus.c  |  2 +-
>   drivers/md/bcache/request.c         |  4 ++--
>   drivers/md/bcache/super.c           |  2 +-
>   drivers/md/bcache/sysfs.c           |  2 +-
>   drivers/md/dm-cache-target.c        |  9 +--------
>   drivers/md/dm-clone-target.c        |  9 +--------
>   drivers/md/dm-io.c                  |  2 +-
>   drivers/md/dm-log-writes.c          |  3 +--
>   drivers/md/dm-raid.c                |  9 ++-------
>   drivers/md/dm-table.c               |  4 +---
>   drivers/md/dm-thin.c                |  9 +--------
>   drivers/md/dm.c                     |  2 +-
>   drivers/md/md-linear.c              |  4 ++--
>   drivers/md/raid0.c                  |  2 +-
>   drivers/md/raid1.c                  |  6 +++---
>   drivers/md/raid10.c                 |  8 ++++----
>   drivers/md/raid5-cache.c            |  2 +-
>   drivers/target/target_core_device.c |  8 +++-----
>   fs/btrfs/extent-tree.c              |  4 ++--
>   fs/btrfs/ioctl.c                    |  2 +-
>   fs/exfat/file.c                     |  2 +-
>   fs/exfat/super.c                    | 10 +++-------
>   fs/ext4/ioctl.c                     | 10 +++-------
>   fs/ext4/super.c                     | 10 +++-------
>   fs/f2fs/f2fs.h                      |  3 +--
>   fs/f2fs/segment.c                   |  6 ++----
>   fs/fat/file.c                       |  2 +-
>   fs/fat/inode.c                      | 10 +++-------
>   fs/gfs2/rgrp.c                      |  2 +-
>   fs/jbd2/journal.c                   |  7 ++-----
>   fs/jfs/ioctl.c                      |  2 +-
>   fs/jfs/super.c                      |  8 ++------
>   fs/nilfs2/ioctl.c                   |  2 +-
>   fs/ntfs3/file.c                     |  2 +-
>   fs/ntfs3/super.c                    |  2 +-
>   fs/ocfs2/ioctl.c                    |  2 +-
>   fs/xfs/xfs_discard.c                |  2 +-
>   fs/xfs/xfs_super.c                  | 12 ++++--------
>   include/linux/blkdev.h              |  5 +++++
>   mm/swapfile.c                       | 17 ++---------------
>   48 files changed, 87 insertions(+), 163 deletions(-)

[snipped]


> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index fdd0194f84dd0..e27f67f06a428 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1005,7 +1005,7 @@ static void cached_dev_write(struct cached_dev *dc, struct search *s)
>   		bio_get(s->iop.bio);
>   
>   		if (bio_op(bio) == REQ_OP_DISCARD &&
> -		    !blk_queue_discard(bdev_get_queue(dc->bdev)))
> +		    !bdev_max_discard_sectors(dc->bdev))
>   			goto insert_data;
>   
>   		/* I/O request sent to backing device */
> @@ -1115,7 +1115,7 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
>   	bio->bi_private = ddip;
>   
>   	if ((bio_op(bio) == REQ_OP_DISCARD) &&
> -	    !blk_queue_discard(bdev_get_queue(dc->bdev)))
> +	    !bdev_max_discard_sectors(dc->bdev))
>   		bio->bi_end_io(bio);
>   	else
>   		submit_bio_noacct(bio);
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index bf3de149d3c9f..296f200b2e208 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2350,7 +2350,7 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
>   	ca->bdev->bd_holder = ca;
>   	ca->sb_disk = sb_disk;
>   
> -	if (blk_queue_discard(bdev_get_queue(bdev)))
> +	if (bdev_max_discard_sectors((bdev)))
>   		ca->discard = CACHE_DISCARD(&ca->sb);
>   
>   	ret = cache_alloc(ca);
> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
> index d1029d71ff3bc..c6f677059214d 100644
> --- a/drivers/md/bcache/sysfs.c
> +++ b/drivers/md/bcache/sysfs.c
> @@ -1151,7 +1151,7 @@ STORE(__bch_cache)
>   	if (attr == &sysfs_discard) {
>   		bool v = strtoul_or_return(buf);
>   
> -		if (blk_queue_discard(bdev_get_queue(ca->bdev)))
> +		if (bdev_max_discard_sectors(ca->bdev))
>   			ca->discard = v;
>   
>   		if (v != CACHE_DISCARD(&ca->sb)) {


[snipped]



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 05:19:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 05:19:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300368.512281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncKXs-0000jo-D2; Thu, 07 Apr 2022 05:19:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300368.512281; Thu, 07 Apr 2022 05:19:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncKXs-0000jh-AF; Thu, 07 Apr 2022 05:19:00 +0000
Received: by outflank-mailman (input) for mailman id 300368;
 Thu, 07 Apr 2022 05:18:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hdtG=UR=suse.de=colyli@srs-se1.protection.inumbo.net>)
 id 1ncKXr-0000jZ-1h
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 05:18:59 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 39cd8751-b632-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 07:18:57 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B3E5F210E1;
 Thu,  7 Apr 2022 05:18:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F2F413A66;
 Thu,  7 Apr 2022 05:18:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 9Lo/Nzp0TmKaQQAAMHmgww
 (envelope-from <colyli@suse.de>); Thu, 07 Apr 2022 05:18:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39cd8751-b632-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1649308737; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=A+yNUODWma7WknR/jI5cBa/CbnRiNAE8PcMaVQDIzR4=;
	b=mnCB1gF89XJ5ZS0vn/sLXjbjQHE0OVf5/BCbnACnemfg918qFrAMS1uu96deBrWbKaTk0y
	986H3NVh/IurAPnL2y9HkNS4LPMQclLG/RGT1PVgOxZNeKUsvsv1qbmzIT0Ddpaw+xC6qE
	NWA7dPYsE9i1SiYQLl3VkO1mNMjLBac=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1649308737;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=A+yNUODWma7WknR/jI5cBa/CbnRiNAE8PcMaVQDIzR4=;
	b=kD2ssGZ1opFQemhwtjj59lbGNVo/3qb1+9BNGH243uIB4Twx+Dpu/NW4coV8ja6JRSUAIx
	INPQyHL1JAX+fNCg==
Message-ID: <f326944f-46b1-e888-18f6-97dcf69d945d@suse.de>
Date: Thu, 7 Apr 2022 13:18:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 Jens Axboe <axboe@kernel.dk>, nbd@other.debian.org,
 ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org,
 xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
 linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
 linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
 linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
 target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
 linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
 cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
 linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
 ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-26-hch@lst.de>
From: Coly Li <colyli@suse.de>
In-Reply-To: <20220406060516.409838-26-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/6/22 2:05 PM, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
>
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

For the bcache part,

Acked-by: Coly Li <colyli@suse.de>


Thanks.

Coly Li


> ---
>   arch/um/drivers/ubd_kern.c    |  2 --
>   block/blk-mq-debugfs.c        |  1 -
>   drivers/block/drbd/drbd_nl.c  | 15 ---------------
>   drivers/block/loop.c          |  2 --
>   drivers/block/nbd.c           |  3 ---
>   drivers/block/null_blk/main.c |  1 -
>   drivers/block/rbd.c           |  1 -
>   drivers/block/rnbd/rnbd-clt.c |  2 --
>   drivers/block/virtio_blk.c    |  2 --
>   drivers/block/xen-blkfront.c  |  2 --
>   drivers/block/zram/zram_drv.c |  1 -
>   drivers/md/bcache/super.c     |  1 -
>   drivers/md/dm-table.c         |  5 +----
>   drivers/md/dm-thin.c          |  2 --
>   drivers/md/dm.c               |  1 -
>   drivers/md/md-linear.c        |  9 ---------
>   drivers/md/raid0.c            |  7 -------
>   drivers/md/raid1.c            | 14 --------------
>   drivers/md/raid10.c           | 14 --------------
>   drivers/md/raid5.c            | 12 ++++--------
>   drivers/mmc/core/queue.c      |  1 -
>   drivers/mtd/mtd_blkdevs.c     |  1 -
>   drivers/nvme/host/core.c      |  6 ++----
>   drivers/s390/block/dasd_fba.c |  1 -
>   drivers/scsi/sd.c             |  2 --
>   include/linux/blkdev.h        |  2 --
>   26 files changed, 7 insertions(+), 103 deletions(-)
[snipped]
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 296f200b2e208..2f49e31142f62 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -973,7 +973,6 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
>   
>   	blk_queue_flag_set(QUEUE_FLAG_NONROT, d->disk->queue);
>   	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, d->disk->queue);
> -	blk_queue_flag_set(QUEUE_FLAG_DISCARD, d->disk->queue);
>   
>   	blk_queue_write_cache(q, true, true);
>   


[snipped]



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:01:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:01:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300372.512293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLD0-0006Qk-Mx; Thu, 07 Apr 2022 06:01:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300372.512293; Thu, 07 Apr 2022 06:01:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLD0-0006Qd-Jd; Thu, 07 Apr 2022 06:01:30 +0000
Received: by outflank-mailman (input) for mailman id 300372;
 Thu, 07 Apr 2022 06:01:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncLCz-0006QX-Cd
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:01:29 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 29d39f87-b638-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 08:01:28 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-dryFybIHMtu0TrLTvtiKGQ-1; Thu, 07 Apr 2022 08:01:25 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB5292.eurprd04.prod.outlook.com (2603:10a6:10:1f::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 06:01:23 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 06:01:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29d39f87-b638-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649311287;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XrYNGUzlWUG8eVswJNjylNqEWaClHkCSLOhcEYeBcIU=;
	b=j3CV3Yx3jZdAwKl8bsVC/F6MiZz0EP2sUErLjc83yrSVTd7CL1CITz7XeB0ZHDp0ZhLgyu
	HWwc/O1zI6Atx49rWiSIINZhhxeIBRd00sDBUx1RqE4eFwWCrHVURAi/5w01Arz/hvCWhC
	jGdKfIBauFE4MvdWsQmt/jOAnSCqmg4=
X-MC-Unique: dryFybIHMtu0TrLTvtiKGQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Op2b7HuAR8oCUDMJvyQyu/WcLbh2rfeRGR8wpIvce/GLHLCi2BxpYLLfMExlwcqRLQTEDHPahlZyeo7NvQJmI2hYibcVV96edhsJTNslwt/AuiXgJvfgjQKJCaYlHGTN2JA+VmmLW8rjgA1NVYniyBcL3u/UiWDZY4UqqhwfEfe430iV/RwT6J755JjQ9xPp+4fUwvgCZ4H3C0CYPug2/pwapBwR3qRkZjZaYvgiNK1p9HLMnH61jEe5uEfVrx1fZ8Hgjej6fc34hdEoTcb6i8tqMF8gQ8q+uIm45hx+SWU0OybpurTJi5uyb+6ozzLTXpMn16fCIppGsTtDpjx4jg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XrYNGUzlWUG8eVswJNjylNqEWaClHkCSLOhcEYeBcIU=;
 b=FbQl50AGcN64SeVT+jqBBaIbrlIANNSEHGNpd2vrmpygFJQhNTz2N9DUfr74ib3UjSaIvRuTXHpvO7qobbmBaqpm73D4DX/harfAoUSYcss7AK4xspmx+seGDs1mmkpYtaMW8XFXqGyqHW6T9vrh7mrYOLaRI/ZcUYIe6tJ+JqUJo5zdNd9o+fiV2F9+7Cvl0256C/yDW0ZkjoG61KIiTG6BTeQeyduVwScqaUWQTaumYng1763LIYr6YUvXjEb88Ipafn1OewNGsuEUFeI1vhELIPNkD0hA4ghOvAD2nKd31N5pzKE7BW5dFrhB/f5pGpS3GXjq+/DeMdMmOYrTiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <425d5e65-cf37-6098-074d-0dc1dadda8e2@suse.com>
Date: Thu, 7 Apr 2022 08:01:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v3 2/2] x86/monitor: Add new monitor event to catch all
 vmexits
Content-Language: en-US
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <JGross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 xen-devel@lists.xenproject.org
References: <d1a7a48fa2d46c6a6cbf8f93926a8839aaba92e3.1649256753.git.tamas.lengyel@intel.com>
 <73e6b45525e1be753d3e243d42ad632bbc5690b0.1649256753.git.tamas.lengyel@intel.com>
 <9f593bdb-d95a-4705-d24a-f8767d69a09f@suse.com>
 <CABfawhn=-avd30QieqJ9gWsJMegRYcOV23vGvYeQcaoA-Cu-VQ@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CABfawhn=-avd30QieqJ9gWsJMegRYcOV23vGvYeQcaoA-Cu-VQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::8) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0cf43a6d-89a1-42a3-4df5-08da185c0ad6
X-MS-TrafficTypeDiagnostic: DB7PR04MB5292:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB52923EB14B5A789C480016E5B3E69@DB7PR04MB5292.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AXzy1foky9/hg4WHfz4sS97n/eciDR8hVEXRzq5mXMAbUvTfLfGXnerfO6lONfZdBvEdGeNJa1oqlCuP4eoyJsblzUpESil+Rm8TldQCK9sYFDI1EP6bnhPzmE3uj8KH6PaQK7/IlOUSzI72kQhaQSdAKqgulAj8rt4PJAoXg4qYYyivnQxfeVs2EUOOLS/5TUk04ueNCDmofPEbTEABgD/uiCseDqiE3vXSklB3KNOXv6fV7asH/GT4kI1UbjMiFzoOoKoJkfvMcnHi5Ii98K3JpE9/UPFq59OVStVZ/OD0SI3e0Ju8boUDk3lhIBo/4gkFng8yCgBvqfPpDNFukjN6FT0L9wuozx39rQsGujWONisgiZ114vnRkPDB5BHe4Ri3ZBSqYKzQ+fAM3znoZHlRQLyerudQJcSTVu2BHdzdeZu8koEjoIvJc6L+ILXVsmw/IRrQTN/y/PYt5AXEUGrf4VFDkalKhoHAoyjIqRmVG8NIKsKBUs+zH8lx9rlgTGZTwE0+/v5YdmE5aBzf5YrPLCj2QRHFECGqVIM0YAU0HS/iTfLZB8HwyJqF74oPHvM3qsVZ9p8WKYH2V7M6OjI36VVFyW3JsVT9Lh0wgcwtWGO+bkHj3SaQizJc/jZ7tVVlqYf3X60SOlAHK4OB0YgD/HzLNoES6Fs0APZ5rOu49SQ1WT4zmex6PLpJWMyFzNUp6RB6f3eNJNkjq33UMlOONXJHQp7JSGUnEIeoBG5kq/+cvREDjMOAcDuPEHv1l9eVLfORJqVGcs9Mm2xxmQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(7416002)(6512007)(2616005)(6486002)(508600001)(8936002)(86362001)(53546011)(6666004)(6506007)(31696002)(2906002)(38100700002)(186003)(26005)(83380400001)(4326008)(54906003)(66556008)(66946007)(316002)(6916009)(36756003)(31686004)(8676002)(66476007)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TlFiY29qMWJ3RExZVmNFWithQVA3eTdXTEt5OTFWYUZCY0NCKzlLZHdRZlV2?=
 =?utf-8?B?VTk0VHVRb1Z5UFVmSnJ3WWNUcUcyL2tiWUw3cm5ZbE9jM2FIN21wdUpPeThC?=
 =?utf-8?B?ZWI4V2huVFNUUVpkeFpGOTVnMWZNMTNkakNxakMwWWNTYkJUV3pTMHZaV0RB?=
 =?utf-8?B?UUsyY0c2eU9zaXZLNm5UTDJPNTFKRjVoZDd6ZHUveXhhelJUNlRoNXUwdENu?=
 =?utf-8?B?dlQ5a2lhM3NNdFZNNU1zaVhsZUw4ZHhLMGwvMVEvR2VNNUNUWSs1eDlYK3Zn?=
 =?utf-8?B?RzFFS1ZUalc0U0JMTUVYQVpXTmU4dmN3RGVpU1ZtMVpLRmFVTy9FbzVMa00w?=
 =?utf-8?B?a2RGVkhrRmZncEdjWEhCUTA5SHJIc0N2YXF6QlpuUE9MN2JrbVA3MzNBdFRN?=
 =?utf-8?B?dmMyWkJWRFpDTFRVT3QwTTdXWlA3Si9EaHB5MmRYbnBuVU1zSjdwRjFKTVEv?=
 =?utf-8?B?V2xHNGh4WERKUzA0WmZpeDdHcFcxSXRRcEhDRVpJTU9mNnI4aEN1TllQbWdG?=
 =?utf-8?B?SUZ5MG05ME1QaXdwRnZKUnB6RXJWSy9Ncm50MnlzdWZWblkrMjg0clEyTU96?=
 =?utf-8?B?N1pXVzV6ai9CZUljM2wxSFR4RTdqRjZrM2dFZTRmaEVrNkpWR0x2dlhEdWlR?=
 =?utf-8?B?Z2x1YkliaVY4bXc4Q1g3c2ZocHF2UmZOUnpmd3Jsa1NDQ1gveC9nRm55MCs2?=
 =?utf-8?B?QlJtc0dmbVZzeElkTzlyc3AycWJVT3YyQTU0aXkrc2ZEMlByNHJwbmY3WFJh?=
 =?utf-8?B?UnZSS1d4dDVGa2VsdGNYT0VEbnlZM1VqQUJ3aTdxdDNxcXpqdkc3WkhCczUx?=
 =?utf-8?B?YlJjdmMwZFI0SUc0ckphYUJpQkFrbEdFK1lBUDZXUU1YSEMvMUdvK2tYWThZ?=
 =?utf-8?B?bEdpVE42akNESE8xNkk5Y0dVeERYeUtGL1RVU3E1RmxRNGdMK3lObmhYdStU?=
 =?utf-8?B?RlVTMWFITDlkUlo3eDFEQWdQYWdmZ0hMMkthVjNYVFpXa2lKNW9jSEg4SHh1?=
 =?utf-8?B?NFZDbkhLTWwrRSt4SEg4aXVxNTM3azgrQjQ5Y3dLZXdOU3RsM291dHJBMG5j?=
 =?utf-8?B?K2dDQzNadWQwNVQ0WWVVbVAzMVFEWkVjeGMyOTI1aXhQVkhqRU1JYXJyVlE3?=
 =?utf-8?B?QllQa2pTOVAwVWt3aGpudmxRMzFrVTdxcGdNWnNJNnRONlVPbktUYVhaaDQ1?=
 =?utf-8?B?QmZTUUplZ0hIZC9NZGN1MkZ0emVXcnBFdWp1bGhQRU1aNk5pR21Gc2Q3UE9G?=
 =?utf-8?B?SUM4Um1kditPZWtSb2hnM1hNd2JZV28xcHNTSDhBa3U0WU1Pd0hvbWM0YVRw?=
 =?utf-8?B?WkIycm1lSmErR1lFcWJFRFVaRW5taWdxS3dNWXNCbllhS2N4NTZTYVdmMDBX?=
 =?utf-8?B?K1NzZzJ0TXc0OVJvdWlFMXR3eTBFcnkzOVE2RGU0K1NxOW1DV1ArTE5FenVX?=
 =?utf-8?B?bE9wdnpYbDU0Mzk2OFFaa3R0MzR1VUxUekxSUzF4Z25nejZ4UklncXFQWEpS?=
 =?utf-8?B?b3FGRmhXa2hlb0JMdFN0RU1OSkFKeHkvd3R2N0tVREtzTnk2V2NKUlU2RXRV?=
 =?utf-8?B?TE9pWFJ6eVh6cldNQXplaUU4cFczWm8ra05McmlhSXNKdldOUkx5STdEc2JR?=
 =?utf-8?B?VHhEYVNWUmI5ODdwbUMxcWozRko2L2xZQUtDcXE3Rk0xNFdhdXhQOE5LSHBy?=
 =?utf-8?B?MlcwQUltWVFraHhiSWNPMllEOXU1NGc5RzkvU0g1TWk0eTUrd09KeHRRa3Mx?=
 =?utf-8?B?YXJsRGQrcWVhcnNGeUlYRTRpZEFUSXJsZ1VZczRJYi9TYVNVZ3d5SDlwT1cy?=
 =?utf-8?B?b2pLcUkvYVBVcEY5TndjUWFOdGVObU5vcUtCMzJoQ1BGcEFZZ3VmOXM1QTRB?=
 =?utf-8?B?RmdpYUlLU1UwVlRqazgyZ3pJbVczREQxamFrZnNDZmlQQ2FqemFEWXFoL0JH?=
 =?utf-8?B?YklzNmZnTUR5UVVGMWVmYkVxaXlkcGRxTExlVWtqMFdiOWNYVTFuWmE2bFJD?=
 =?utf-8?B?bkJJaklabGdRL29QTWkycitLVmxYWlR5NDc1bXlrb04rSWw5TzNYWmVKNGxW?=
 =?utf-8?B?ejFrNUdkUnM1T28yRkt6bm94TGZRVS94R3lYbjlsUDIwQ2xSRlhONUZ1QXd4?=
 =?utf-8?B?VjVicGtRcTBjbnVMck1oT1lFRFFxRFpMTHorUjhQSHJzdXdHZ2VqREhUdGZx?=
 =?utf-8?B?T0FYNVpyUmRmUS82YkIzZUUzZklHNWdtSjhPNE5UTDVCVG9LR1ZhWE5tMUZm?=
 =?utf-8?B?TGw3UTRlVng1YkFlbGxMRUxUMzRaU2dpTWxWU2d5cGdmRGVqQklhWTJpYlk4?=
 =?utf-8?B?dVduK2RSWTZiVmJaWk92V09EWmlSVzBLOGhFdG9GMUt3ODJMRmRxdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cf43a6d-89a1-42a3-4df5-08da185c0ad6
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 06:01:22.6562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h2+0SlB3ducm7dGGaT5C7lfKjYWdY7rjz55M81xhTZU97Nd/h4j/VuscEO5yzw97M/G+gjETI//LwTq9NveGMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5292

On 06.04.2022 20:02, Tamas K Lengyel wrote:
> On Wed, Apr 6, 2022 at 11:14 AM Jan Beulich <jbeulich@suse.com> wrote:
>> On 06.04.2022 16:58, Tamas K Lengyel wrote:
>>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>>> @@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>>>          }
>>>      }
>>>
>>> +    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
>>> +    {
>>> +        int rc;
>>> +        __vmread(EXIT_QUALIFICATION, &exit_qualification);
>>> +
>>> +        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
>>> +        if ( rc < 0 )
>>> +            goto exit_and_crash;
>>> +        else if ( rc )
>>> +            return;
>>> +    }
>>> +
>>>      /* XXX: This looks ugly, but we need a mechanism to ensure
>>>       * any pending vmresume has really happened
>>>       */
>>
>> A few lines down from here failed VM entry is being handled? Wouldn't
>> you want to place your code after that? And wouldn't you want to avoid
>> invoking the monitor for e.g. EXIT_REASON_EXTERNAL_INTERRUPT,
>> EXIT_REASON_MCE_DURING_VMENTRY, and at least the NMI sub-case of
>> EXIT_REASON_EXCEPTION_NMI?
> 
> No, the placement is necessary to be where it is to be able to collect
> information about all vmexits, no matter the root cause. Failed
> vmentry & mce during vmentry would be interesting exits to see if we
> can induce during fuzzing from within the guest (indicating some
> serious state corruption) while the external interrupt and nmi cases
> are for the most part just ignored and the fuzz-case restarted, but
> could be still interesting to collect their frequencies. So in effect,
> we want to avoid Xen hiding any of the events from the monitoring
> agent by handling it one way or another and just let the agent decide
> what to do next. We most certainly want to avoid Xen crashing the VM
> for us.

Okay, I can accept this reasoning. But then don't you need to move
your code _up_, ahead of an earlier "return" (i.e. immediately after
IRQ enabling)? Also may I ask that you transform your reasoning into
some form of a code comment?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:07:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:07:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300376.512303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLJ2-00074c-Cz; Thu, 07 Apr 2022 06:07:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300376.512303; Thu, 07 Apr 2022 06:07:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLJ2-00074V-A3; Thu, 07 Apr 2022 06:07:44 +0000
Received: by outflank-mailman (input) for mailman id 300376;
 Thu, 07 Apr 2022 06:07:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncLJ1-00074M-Ou
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:07:43 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 09390ee8-b639-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 08:07:42 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 52F12210F4;
 Thu,  7 Apr 2022 06:07:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2B1C13485;
 Thu,  7 Apr 2022 06:07:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mhayNa1/TmIoUAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 06:07:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09390ee8-b639-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649311662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=JGmSjF6pVNGXAInKuwVmHmKz0Sh1UD4JOuhFLGlC+xc=;
	b=FP1ydTeuJrHWWkE1J/souxlHHPv93g6Y1c+eJV6mE39SVuc60dJrCTRT6jnIny7oTPBn2J
	X+WCDq7aoGhMr6L61Q1Id3P1th2dk6vXEX2p5vEWTdIpVSn/qVQN7R2wR75UEMFNNtg3Rt
	G/+iaQY6iQrU+KS1ku2GevSn/iqTj9c=
Message-ID: <9e776738-7e54-27ad-0a41-dc5cf8669510@suse.com>
Date: Thu, 7 Apr 2022 08:07:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v5 2/6] xen/sched: create public function for cpupools
 creation
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Dario Faggioli <dfaggioli@suse.com>, George Dunlap
 <george.dunlap@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-3-luca.fancellu@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220405085741.18336-3-luca.fancellu@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------axlaadpoda6kaQUZsfixwwE0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------axlaadpoda6kaQUZsfixwwE0
Content-Type: multipart/mixed; boundary="------------5wUE9qfpqmOJvTqHFuilU2lx";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Dario Faggioli <dfaggioli@suse.com>, George Dunlap
 <george.dunlap@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <9e776738-7e54-27ad-0a41-dc5cf8669510@suse.com>
Subject: Re: [PATCH v5 2/6] xen/sched: create public function for cpupools
 creation
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-3-luca.fancellu@arm.com>
In-Reply-To: <20220405085741.18336-3-luca.fancellu@arm.com>

--------------5wUE9qfpqmOJvTqHFuilU2lx
Content-Type: multipart/mixed; boundary="------------ZBw4fphiiDH1pWalTaI9MWaf"

--------------ZBw4fphiiDH1pWalTaI9MWaf
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMDQuMjIgMTA6NTcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IENyZWF0ZSBuZXcg
cHVibGljIGZ1bmN0aW9uIHRvIGNyZWF0ZSBjcHVwb29scywgY2FuIHRha2UgYXMgcGFyYW1l
dGVyDQo+IHRoZSBzY2hlZHVsZXIgaWQgb3IgYSBuZWdhdGl2ZSB2YWx1ZSB0aGF0IG1lYW5z
IHRoZSBkZWZhdWx0IFhlbg0KPiBzY2hlZHVsZXIgd2lsbCBiZSB1c2VkLg0KPiANCj4gU2ln
bmVkLW9mZi1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPiAt
LS0NCj4gQ2hhbmdlcyBpbiB2NToNCj4gLSBubyBjaGFuZ2VzDQo+IENoYW5nZXMgaW4gdjQ6
DQo+IC0gbm8gY2hhbmdlcw0KPiBDaGFuZ2VzIGluIHYzOg0KPiAtIEZpeGVkIGNvbW1lbnQg
KEFuZHJldykNCj4gQ2hhbmdlcyBpbiB2MjoNCj4gLSBjcHVwb29sX2NyZWF0ZV9wb29sIGRv
ZXNuJ3QgY2hlY2sgYW55bW9yZSBmb3IgcG9vbCBpZCB1bmlxdWVuZXNzDQo+ICAgIGJlZm9y
ZSBjYWxsaW5nIGNwdXBvb2xfY3JlYXRlLiBNb2RpZmllZCBjb21taXQgbWVzc2FnZSBhY2Nv
cmRpbmdseQ0KDQpJIGdhdmUgeW91IG15ICJSZXZpZXdlZC1ieToiIGluIFYyIGFscmVhZHku
DQoNCg0KSnVlcmdlbg0K
--------------ZBw4fphiiDH1pWalTaI9MWaf
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------ZBw4fphiiDH1pWalTaI9MWaf--

--------------5wUE9qfpqmOJvTqHFuilU2lx--

--------------axlaadpoda6kaQUZsfixwwE0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJOf60FAwAAAAAACgkQsN6d1ii/Ey+L
9Af8DShp5jmpFaJdq0x4kVym4BgB5qmsovBHhsjrmbFHsl1hzv7o0rUQ1etVQYfb41ftwXls91x6
WvQxmZDZuP3Yu3vW/i2hP3DpSaw0rzqdS1f58xOP3uyTjPNceY5LYkpCPq7nGad64X30Phxb6lVa
OOJzAlUbgAWB96OcNv2MZQKeSJDRuMjiZC6kt47Of9KONisOEVP1BpxwOOCrGY6h612wm50skHGm
9IqBPeEZgOUfWd+bKh18/UWfiov/M7vm6p3gvwAXtpFQtZboU9+nnZKU4izac3/XvCxd6UE14I3w
i71u96ehmvA0oBswgJhB5qdn1UV3DbQu9Nm1VzTtJw==
=8b7S
-----END PGP SIGNATURE-----

--------------axlaadpoda6kaQUZsfixwwE0--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:09:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:09:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300379.512315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLKo-0007qN-P2; Thu, 07 Apr 2022 06:09:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300379.512315; Thu, 07 Apr 2022 06:09:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLKo-0007qG-Li; Thu, 07 Apr 2022 06:09:34 +0000
Received: by outflank-mailman (input) for mailman id 300379;
 Thu, 07 Apr 2022 06:09:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncLKn-0007q8-EQ
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:09:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4a700897-b639-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 08:09:32 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-kk4g0Cb5PH-V-lQDQLNMkw-1; Thu, 07 Apr 2022 08:09:30 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB9PR04MB9259.eurprd04.prod.outlook.com (2603:10a6:10:371::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 06:09:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 06:09:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a700897-b639-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649311771;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=ttWm9ee+aHhw0r/e9vcokzPDdYX2VuhekspXIMntow8=;
	b=bTDInIXJnqz09Q8FqGUvvnjeaAF+TkBGGK/0IAAhC/NO33PUOuhiQT9fMm6KLeoRRp53vZ
	c0YMHZmLwQddKUjBA6K5TlS7Lp3L9ltiAZRybTWzbZzpMH4b5kR5o4a4zHPxJFmGwfh25X
	qLjqTWQYt+3anBlCoHgO1YtkeGMewdQ=
X-MC-Unique: kk4g0Cb5PH-V-lQDQLNMkw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KucKEVyvVAiorJgflsEc1usjRNCJkx9ZF5nOsXNP+d3UmiMsVdT2DJpQUw+EtTfUCI3Bl0siXzU7ByaaFaxGxt7B/MzwEq4NjAYI+twHVJZTBxbybA1Zy3HBJiGic8c13W2MIT2P+FP+lb6SJRp5gCW4LDJ0eMzL9M3y0qxiWFQ4j/D9BRRusDkWkiAyFrOaO4GOJPILJPUNGMAuXBHHnNARgv7Ubo1hlebQd0giPZ3mT3kvs+Jd+zJ/0J8gb41qFMIdd0kX7nh+GzA6650D/pt0XLqx4MRbLY1DiAmSQNbFn1aFF2zwURDooEPHjBsDwKECwvDBFayfzB1VO1T8IA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ttWm9ee+aHhw0r/e9vcokzPDdYX2VuhekspXIMntow8=;
 b=JU8FJbruwvIlEx+HJFf+O0xPX4v+hriUH9TL580dH5kERPYQSTretF/i9xQoIGAZTGj/EsA/2N8RCwtlb5DjaBaxXQsUzvjDdBO/9QHUc64j63dKN7F7rZF470TsDVKpR4uajuSA1V9qJAQPshQ07EPH4rKmqOih2Yghz2nwwZQ1WSFooDyn/ya5IiGNeKaQkuaw2hwhtFcjyFqXuNsZIjsrpcy5c+xNqPLzfVpvkSLzo4x543xqU/MVlmVp1hcyNZRvcpilyRP/ERN8too5eYRP4z13CcWwfuvdq2PLO0l8nCJjYk+CFMxLsOauL3OoSDuZ7U8EADeIv/6UBJXZIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
Date: Thu, 7 Apr 2022 08:09:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 0/2] VT-d: address fallout from XSA-400
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9P194CA0018.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::30) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4e1e58e8-f89f-4014-e900-08da185d2cb9
X-MS-TrafficTypeDiagnostic: DB9PR04MB9259:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB925974BA66F245D03D414EBBB3E69@DB9PR04MB9259.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TLVFOkYoVhuhMm4HTH7XTrZxjfhIgxV3wqloagQhBLAHS6EByTTjhPZjy1NfM/1wyZ4/BPn5cJQeFVabLHv4clLvt/HEaUg6kmseZmDpB70kum55YZnRMVb2QcvpSNBIFWVefrGZnMfiROwhSqogfWt91W44sHU1SPfbCnUjNKC1IU/go0yxxaodgdRt6oJeGI2XfDYQHyFxm+gctM81+QPsVgQYl3aZ9vJ9OsfK+225uXOQmawmlv0cZpUBVMXOo2O4m/kNDdwknrSDGD00LyaUFXahS0dSd702Of8c6/jH4gv1dLlsvMLZCz2tX8oGjM61C/4i0abJs/bvipvaRdKzNUrQfbD7Gfjy1LdiYf8Tv1qQboQwTdHZhjCxfodEdIit0cuxk68NqLQ5atk12/bplpQNpN1CF6jObUshLMj7lujGh6NfpR/6vwfjeiwZjknesWmgzOlyqdPf0Lh98C5ydED1VAEEh8mNXzKIDXykGXF+MR/Nn+4nIxFDZG99m9fuZETjYk2zOyG9077ZW94/Infos4z4kqoxoyaSvKxrb6XsPKy2e9JR4lR2CIb13T4+A75mFKmi6nrNTD6uen7Hzu75g+4HYSg/uhwQ1DaPAU15cfyYO6PNSRbSanfftWPieWDtXehzsV2WVh0pkbOYdy0rY5TmjANhHrxzaGXmkwUjuRc29wdyodMhYkfwSytZuMdfDHb14qSslBqYhX2XAnlqehkwXAi2BgF5pABF4hZQJebpiY5u1WSFfaqU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(26005)(558084003)(66556008)(66476007)(6486002)(66946007)(186003)(8936002)(8676002)(508600001)(38100700002)(5660300002)(6512007)(31686004)(31696002)(316002)(6506007)(6916009)(2906002)(54906003)(36756003)(2616005)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aHpMNlVzWW8rRDlPVW9sVUlodE9VR1E0UDBmS0xJN0IzZGgrSWNXbkREVXNx?=
 =?utf-8?B?MXZLcHlZdnIyVTBFS3hhMURFSk1CTzV3KzhKYitZTk1lOTBqOTBJb2dOczlC?=
 =?utf-8?B?ajc5Y2htU0Z2cm5MZUs4K2pyNk55eGp3aHVqYytvdkhnRjRuTC9ZdGxJSDFo?=
 =?utf-8?B?Tktrejc1YlRCV1pEd2IrdTA0eDV2QkFuSm1ZQXV1ajMwTkVEamZhcEpHZjFn?=
 =?utf-8?B?T1FEeE1icDIybXNnZ096b0lyUER2R3RXbHpsTkdKNDBXUlU2ZlhMczJXMFhB?=
 =?utf-8?B?R1NTU3VIMXZuTSsrSlY5U1JuazhubmtjbXZCbktWU1ZoU01uMTNYZ3kwQWly?=
 =?utf-8?B?RDlYbCtBYmxPSmVtVVRFKzNUbWZQL2ZUNzhuSUJHVmFVMENxUlF2Z3NiaFQ5?=
 =?utf-8?B?YzJsdzM2K1NXMzNUMDQxNmo1SFFVZzFnUlhOT2FXN1REWjZJaW53RlhoRnl5?=
 =?utf-8?B?bng1L3h1UmdwdHU0aTU0ZnEzSnQ0eUVCUDVoZkJrcGdyc0tab1B1alNWL0Nh?=
 =?utf-8?B?MGxKakJTU2kreEJwVS9ZVVhUSzdYcFJ0RnArZnNDc3RUSXFoR2k3UGcrbnI3?=
 =?utf-8?B?emFNYTVJMkhUd1R2RWxjbFJ1Tmw0WTdOYzh5dWNidjEvekFJYnNOUmpBQlNt?=
 =?utf-8?B?MjI4TmVvSE85LzlsVTg3Mi9ET3pEQzBvVFk4RE0xcEY1UEY0QVNtVi93eFpJ?=
 =?utf-8?B?amhFLzErQmxYaHh3ZE1wY0gxdTJVa2tEa1l2bE5LRG42TEtvNUV3aVd4MTV0?=
 =?utf-8?B?YitGRFFsTTllQk84Ym1QQ0tiMjUzSkU4ZjRxTGFORkh6eXJiYjYvVGgzZndo?=
 =?utf-8?B?OTNFdXlRRXpjMXNzMlIxWmJaSllzS2NIanN6MVlodk45dVhOKy91YXhwaG4z?=
 =?utf-8?B?eXF6Y1JtSmU4MFRwWC9zR1h0V2srSzJiQlp6akFzT2xyMnUyVmxrUGJ0Mms4?=
 =?utf-8?B?N0M0KzBZb0xnQmpFVlJYOUhkZ3ZFckNGdS9sSEdyaFZoWitYeWcxZFJRN0Qv?=
 =?utf-8?B?UHhWdGpiTFpzNHh4UDBVRUlLcHJPNGhWYTlqNm5EOVJlY09hWnZPOWxVck9C?=
 =?utf-8?B?a3VucFZ3NWZNQ3dhOWlxb3hkc0RVZklLOEh2Tis4NU5NUTZERk1oWE43TmF4?=
 =?utf-8?B?OWRNQjR5R09FZm53SDR3S2ovMmhRb0tabFV5SFZ4ajg4dmFIM3IvMXMzTmNv?=
 =?utf-8?B?Y0hpUjQ4L1YwVGpnbG1rMjcrL1RCYTdaQWtmck05cERsdW1MYi8xQ0JmbVZk?=
 =?utf-8?B?YUpvT2haZkpQaEFnK3FRN0RmdXZ4eXZEdzQvNGFQMWJmaDNBTkxzOXdvWkpi?=
 =?utf-8?B?SlRnZ0RLWDZKWXZjOUlnZ2MyVUZtTkhYK0F6K0NTTGxOYnFjOVV1U1BITEEz?=
 =?utf-8?B?dWlENzJPQzNOejNMMWZFdXNhQk9IVjlTUnluK0hGcE92OGFabkJsVnljeFpv?=
 =?utf-8?B?aXh0bU1Nc2pOYXNuRnZPTnUzZTRMQ2JNVFNCWjI3ZTZKTlU2bEhpQk5ZOVJE?=
 =?utf-8?B?UENqbytMek9tZnBsbUMzcllkYWhMbHk4Sm5qNWxtY2pLZENJWjIxejJaYklG?=
 =?utf-8?B?SkFSRHlmSjB3UXZva3VpS05oU3R4aDJuUTVHODNRWFBVenNmczRrUU84a3c1?=
 =?utf-8?B?V0IxOTc2NGd6OEdZQW8rZGVnSnQ5VHEvMms2OXRTMlRraHNKK1dWUW1icXEx?=
 =?utf-8?B?MDZSQlNZV3FzRXRjb1RXdVAzempOVFpLZTgrbUhuVWJGazRkeUpySkJGN1R5?=
 =?utf-8?B?L3NHOXM4ZnZxekdLeVlibzArVmRQSUxoUkZRYUE4aXhPRjdsK1YxWVJHYXRt?=
 =?utf-8?B?VHhkaXgrczh5VHlMVld1bTI1ZndaTHhxSm1BRUJzbmtLdkI3QlFlZlZ4Wi9H?=
 =?utf-8?B?ZlAzVThWbEJIdHhlWEpqSEtqKzhCTHk1NSt4Ly93MlR3RVRUU3JJY3RmeXRQ?=
 =?utf-8?B?MGozQ0pGUGRWazZ0RVZWNEpqK0tKTHg2ZTM2dzFQbDUyMmRPanhTNklqYlFW?=
 =?utf-8?B?MWdTZWNGVVJMMkxUbFhYMmExdnlJRVp2SjhSTVYyZHpNU1lQQnFoaDkwNC9F?=
 =?utf-8?B?ZGJRRU5XQWY4QzU2dkZ5L2paNTRKcWVhTm41dEp3eW5ZWGlaWU8yZC91TlpD?=
 =?utf-8?B?V3l4bFNLU0YxWFpkenhiQi9Yd0c3R2FaMUZiUHJKRkJZY3N5Ly9QV1Z6Y3hM?=
 =?utf-8?B?N1JxMlVHUC9mTmpLN0pGdWR3L08yWGVvM3ZVL25MTENBSUxvWlh0cU5WbkFY?=
 =?utf-8?B?dWVMdDU4RDV1aG5ja05Fc0tnd1NrQkh5ak1EY1dIZnBwN28wOGhrbVRmMWlF?=
 =?utf-8?B?WjZzUmVKdUllK0VPNXVLMjduNlEzTW9KcHZEQmtoZjVGeFBEVGM5dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e1e58e8-f89f-4014-e900-08da185d2cb9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 06:09:28.9158
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ogXaKd5xb2bitr9FO8AK8KHoXqdzpJExNsV5CA86+aAO1TBOFrkmE06A1qxqwCoEC2CIKiaTqI+2xKexuWxs3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9259

1: avoid NULL deref on domain_context_mapping_one() error paths
2: avoid infinite recursion on domain_context_mapping_one() error path

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:09:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:09:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300381.512326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLKu-00088y-4D; Thu, 07 Apr 2022 06:09:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300381.512326; Thu, 07 Apr 2022 06:09:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLKu-00088o-0p; Thu, 07 Apr 2022 06:09:40 +0000
Received: by outflank-mailman (input) for mailman id 300381;
 Thu, 07 Apr 2022 06:09:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hdtG=UR=suse.de=colyli@srs-se1.protection.inumbo.net>)
 id 1ncLKs-0007q8-To
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:09:39 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4de73857-b639-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 08:09:37 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A29E1210E4;
 Thu,  7 Apr 2022 06:09:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4017213485;
 Thu,  7 Apr 2022 06:09:32 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kE04BRyATmI2UQAAMHmgww
 (envelope-from <colyli@suse.de>); Thu, 07 Apr 2022 06:09:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4de73857-b639-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1649311777; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JT4UvlPRTF1rf1PNVYTQl5oxY75vXHbMm6cxI+vJlzM=;
	b=wOiyRM1WKAijaiXA/6UPpDOabfmgWyFiXfUydWL/10ZCv7yghtyaXvUcoBtsxJ2dnhBhf4
	MXxBRV2J27Fs0oBPGyW3Bcz1OeFP7yQybfPi0d2TDSS1Rp6Pn1IPyM3ErNotkeHAJf1Ysz
	2ylrrplM7mJGkpksfcE/0PXv/RJ0b84=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1649311777;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JT4UvlPRTF1rf1PNVYTQl5oxY75vXHbMm6cxI+vJlzM=;
	b=qH6/6KvekVW7yUEoPIXC0j8Nl8eBqt7dLT/vdiczEh3nQdRmXIIFkTLVPwnvPg8wyiCLJm
	FUCApLKkaSIR8qDQ==
Message-ID: <ac88801d-c1f9-e8a4-e0cf-e5f7cbdfbfc3@suse.de>
Date: Thu, 7 Apr 2022 14:09:30 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from
 REQ_OP_DISCARD
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 nbd@other.debian.org, ceph-devel@vger.kernel.org,
 virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
 linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
 linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
 linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
 jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org,
 ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
 Jens Axboe <axboe@kernel.dk>
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-27-hch@lst.de>
From: Coly Li <colyli@suse.de>
In-Reply-To: <20220406060516.409838-27-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/6/22 2:05 PM, Christoph Hellwig wrote:
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint.  Fully split the limits and helper
> infrastructure to make the separation more clear.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

For the bcache part,

Acked-by: Coly Li <colyli@suse.de>


Thanks.

Coly Li


> ---
>   block/blk-core.c                    |  2 +-
>   block/blk-lib.c                     | 64 ++++++++++++++++++++---------
>   block/blk-mq-debugfs.c              |  1 -
>   block/blk-settings.c                | 16 +++++++-
>   block/fops.c                        |  2 +-
>   block/ioctl.c                       | 43 +++++++++++++++----
>   drivers/block/drbd/drbd_receiver.c  |  5 ++-
>   drivers/block/rnbd/rnbd-clt.c       |  4 +-
>   drivers/block/rnbd/rnbd-srv-dev.h   |  2 +-
>   drivers/block/xen-blkback/blkback.c | 15 +++----
>   drivers/block/xen-blkback/xenbus.c  |  5 +--
>   drivers/block/xen-blkfront.c        |  5 ++-
>   drivers/md/bcache/alloc.c           |  2 +-
>   drivers/md/dm-table.c               |  8 ++--
>   drivers/md/dm-thin.c                |  4 +-
>   drivers/md/md.c                     |  2 +-
>   drivers/md/raid5-cache.c            |  6 +--
>   drivers/mmc/core/queue.c            |  2 +-
>   drivers/nvme/target/io-cmd-bdev.c   |  2 +-
>   drivers/target/target_core_file.c   |  2 +-
>   drivers/target/target_core_iblock.c |  2 +-
>   fs/btrfs/extent-tree.c              |  4 +-
>   fs/ext4/mballoc.c                   |  2 +-
>   fs/f2fs/file.c                      | 16 ++++----
>   fs/f2fs/segment.c                   |  2 +-
>   fs/jbd2/journal.c                   |  2 +-
>   fs/nilfs2/sufile.c                  |  4 +-
>   fs/nilfs2/the_nilfs.c               |  4 +-
>   fs/ntfs3/super.c                    |  2 +-
>   fs/xfs/xfs_discard.c                |  2 +-
>   fs/xfs/xfs_log_cil.c                |  2 +-
>   include/linux/blkdev.h              | 27 +++++++-----
>   mm/swapfile.c                       |  6 +--
>   33 files changed, 168 insertions(+), 99 deletions(-)
[snipped]
> diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
> index 097577ae3c471..ce13c272c3872 100644
> --- a/drivers/md/bcache/alloc.c
> +++ b/drivers/md/bcache/alloc.c
> @@ -336,7 +336,7 @@ static int bch_allocator_thread(void *arg)
>   				mutex_unlock(&ca->set->bucket_lock);
>   				blkdev_issue_discard(ca->bdev,
>   					bucket_to_sector(ca->set, bucket),
> -					ca->sb.bucket_size, GFP_KERNEL, 0);
> +					ca->sb.bucket_size, GFP_KERNEL);
>   				mutex_lock(&ca->set->bucket_lock);
>   			}
>   


[snipped]



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:11:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:11:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300389.512337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLMU-0001PC-Fk; Thu, 07 Apr 2022 06:11:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300389.512337; Thu, 07 Apr 2022 06:11:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLMU-0001P5-Cf; Thu, 07 Apr 2022 06:11:18 +0000
Received: by outflank-mailman (input) for mailman id 300389;
 Thu, 07 Apr 2022 06:11:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncLMS-0001On-BJ
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:11:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 86b0c26a-b639-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 08:11:13 +0200 (CEST)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-2gvv9xDFNYuVpzB2ZjNOIw-1; Thu, 07 Apr 2022 08:11:11 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB5596.eurprd04.prod.outlook.com (2603:10a6:10:a2::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 06:11:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 06:11:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86b0c26a-b639-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649311873;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JnE8xJC6aHLf7QxEU8ahXxNaM953sp4uj3NcYFvGw4w=;
	b=UTuyyBMXvuPlzy6qO41800MS3mTPFHrBC7aGPYs+242oJNxt9gibvALqrLHx5tR+CsK14W
	p8UakZTE4jOOsFKUWDwBsWlNxkqe0rdhbjt/2WsdvE+57SyCLShSwYxk9iG/Wp+PbSqlIM
	+pGkwqf7ssi/KapnGMTVYG9DbwnqaZA=
X-MC-Unique: 2gvv9xDFNYuVpzB2ZjNOIw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UYJHfxJYTvjphDtDwU6kA7rmjWtZzKsk8cSc9pLYxxVdlrqo1e0AP/z2JDQzpxTp6/GDr6gaxYsEgeOFRz7SF3flwDt0eCjHB1dU/6+UWswvDGYGJcCH74IJgF8OCMrQ4iv+umqR5DwBe0/Z3MSfmapQRyu9ODnqeHuhDa0Ovq8k56oGa+F53BaRVZHVFZly5oafX0T5cUnf4kQA6XRSd318Lo3TgEoVQvmUD+E5Vj4LUYSzRYAQW53y0dYlbLfIFD+5KFCRk6QrgT18ugEhhAKEbbEluAGeiwwMjkBXSHdH6HjxRThvp3RwhOeS3liHhhhQOVuETgTXPYINXpeCNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JnE8xJC6aHLf7QxEU8ahXxNaM953sp4uj3NcYFvGw4w=;
 b=MFXTtBz1LsvLiHp2vezzPitN4GvehIZ+gJ/dx3GkArn5Jh+vMsGkXiJdHM6lgFNADhA7r6/7e1jyDxNjJvhuJQrsK90T4Aeoe757O1fRUKyOqpr/CtjES7eXKreFmF3JXOZfOvVUsvwLpmQAIhn+o6DxaeNGNbcjguCoUZgkt420ly8k9N3QhUgBQnI6AAE0F4vAKk2i7WdD1ksxgROb6aaCIbtXXnjnr4cJtKaVjZXY8I9CaG96QoqHbziksYKr/Lmaty1nP/5lu47fRIOO+yy8svBihtEWDZmitodJLHZ+QUU/z1gCCpM82+gCKQp1XfNAM3Mhl+GAEcA6Sc8SRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6739cf19-a74a-208d-82e8-28dfde7710f5@suse.com>
Date: Thu, 7 Apr 2022 08:11:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: [PATCH v2 1/2] VT-d: avoid NULL deref on domain_context_mapping_one()
 error paths
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
In-Reply-To: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0008.eurprd07.prod.outlook.com
 (2603:10a6:203:51::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f80f7f91-a89c-440c-bd95-08da185d682e
X-MS-TrafficTypeDiagnostic: DB8PR04MB5596:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB5596BC14F52B543D7ACB789FB3E69@DB8PR04MB5596.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	m7qoYDeR6Im35qJmRYTm8ZXmzSGUE8WGGjvKMOegZUelOh/Rv0gXNWXES2ywt8FUWRR3LYdW5Tgq6EfAdWAb0i1OK+1E87KyQnFLFUP5r+/yT/X02gLFu3u3vA/6OZ10je4sCCJMh0rn2Lci6KftlcIvl+/g3qtw9cENvE92lByKMnz0konBz3OVLfyPKCSTNG6TFts+J0MaXmj56eK12UT3A6TMNiIaKRcUaGYZXlIiGnXGD+e90+EA8mHHCVQCQ9kYS66wjs0vupqQqgezeTga9Z0vOfEV15pqb+eA1OCbaih1XWKIYshedhULqllGXFyEmLyXnURPE+YH+oez4eJ7ahBlJspjFmLA2zalMP4xAV6cK6fF24usJILztVVcVHrhtZHJxKJqSSBBRRYqMgq0WerLk0E4/EwCQLXzWA8+RklLNb1/iFl388UV+J0I/rq0Oiz/1NW9ieelCDVFBLAmcTqGCdpp5r43Go5UjeBG2GPoTTDXJHC6cNoz/+h70bFRGsKJ4s/JOKHDBGC/uttqqGq7CIEGw7B/akWYPFC5WbfCGMYnFG6Vdf8/C0AdpzfbkGy0/BL2EbKrc2YcYKHXQJYr0yLn37QVx/fUOUfEmP7L6rYVwUFobeBphypJp1iM6DekkhN3vwty7tWXazCVx8fhlX4Q6RmnVnqx/7lj/BzltfWjyBmhbZLrCgT+mhKbEw3YyXWVGKTfAEyBNX60PDOkgrMUIhzddPyahKBEAQkQJd3+PbHbjiAVXZ77
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(2616005)(6486002)(54906003)(26005)(186003)(38100700002)(5660300002)(6916009)(316002)(36756003)(66946007)(8936002)(31696002)(6506007)(6666004)(508600001)(31686004)(8676002)(4326008)(86362001)(66476007)(6512007)(66556008)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YzBYbGgvN2dMMThDMDFsaUR4T3VhdGhxdTNwOHVxeXJMQUtLOVlsMldGYkEw?=
 =?utf-8?B?aTVpdTEzM3JENHd0Nm9Od05raXNmSHhiWDBUTjhKRUZGOU1yazQrbDFUZnUv?=
 =?utf-8?B?S2pmTzZ6am1WQ1NuN1pXblpxc3V0QVdVdy9TaXRkZ3B3VlNrMzZvdWJVeGZi?=
 =?utf-8?B?N3BRSFFhY3k5Y3FjbTFYTkZJNHFvRjJtVjFLeS9wUmhVanlMNUJNQ0Fxc0Y2?=
 =?utf-8?B?ckY4WGdpN0pGU2lLaVRUeVAvazZQTU9nanNyeU1tcXBGSjBOM3QzWnh0Tkky?=
 =?utf-8?B?ZHBXaS9pM3M0UWdJeHZITm01OGVoaXJCd0dCVWJkYVNtRDVQblhXbnVNcUN4?=
 =?utf-8?B?YzFZeHJoY3M0emhZaGJtLzRwN3hFbEF6KzB0TGJEeHN3SEhVUVNaSE5NVDdj?=
 =?utf-8?B?ZEJLY3pYOEswMG5yaFo5bHRockZONzZJOG16aHJVZXcxWGdMNXV3SEZ3YldU?=
 =?utf-8?B?dzlEOFppcFFQRjZ1cWF5NFVmb2RkRGJWSXhkWnZiRkZXMVNrcmNvL01MUkRL?=
 =?utf-8?B?WnZsdDhrc1p5Y3JpcmZwdnN2ajJqSGx5czE2cE92OXZnRVlUbWlpL0JPTjND?=
 =?utf-8?B?TzdLdzZHNkd6cXpTOFppSExHTWVFQVJQTTJnUS9yejZGcGlCeUpNY2R0b0Na?=
 =?utf-8?B?emNrUjM5aHYzZ1Ixc0tQR3ZNejEwOGxLRVErNGd2THhwdmdWeFg3WUpQbmtO?=
 =?utf-8?B?RTAwQjlKV1FaKzhBeGV2ZTgzSDVtK2NwaFIxSmpwTnp2dmp0NXgrRGk1NXRr?=
 =?utf-8?B?YTFkT3FPWUpTdUR0MzlKUXRUcUF2dllVS2VUSmVwYVEwQW50bnBvc1FwZjBR?=
 =?utf-8?B?MVFBU1FsYnd2Z2xBRlJXWU9SYmdGYzlBOGwzTGxBMlVpcE9xZmQzSjVZaUM5?=
 =?utf-8?B?VE9qR2txaG10MGdmbWFpVFFHVmJaN2h1U0p0Vk9VbjBoOVc2VlljMnU3bnlT?=
 =?utf-8?B?WVVIc3laWWtRazMyT0xpd2s0ckRpR3JJRGpIY3BhYXVjSXlLa29ZK0s5R1ZF?=
 =?utf-8?B?c1dvZVZvcGJhWndDeWl6b3FtMGgwL0cvQnBpaUhyeFZVL0lpMEtZUHV4b2VN?=
 =?utf-8?B?aTZJSW5IendhNnBzZVRETGtDK2hFQWQ1Sk9YUFpqR2ZwSGFka25XUUs1SXFB?=
 =?utf-8?B?ZW5BT3p3c2lzUEx0REJmWDl6cUZFV1YraURieWMwdVdyR0hRMHduelVmQzdL?=
 =?utf-8?B?T2UwVjBTdFcyTnN4Q2FYK1dWaW5LUHBSNi9hNmUwemlteDJ3b0VqbzQwbzVE?=
 =?utf-8?B?R3l5YXJvQ2xxK1NxNnBobkd4dTdrN0QwYlhGalYzajZ2eTRuY2FtKzA4OUhp?=
 =?utf-8?B?V2pmQysrcEo1VHEvb2t4RkJiK0xxaVFyU1pqNHdxUEkrQ0RkOGdBYVVrcHhF?=
 =?utf-8?B?NGdqYVNzL2diMnVFSGNQMTVBQjlQRGd0Mk1SamFldi9MZlpsTjdCU1VlOHN3?=
 =?utf-8?B?MmtLTnRlaktuVE45TEhadUo0ZDErRU9haXFuN2NPditBdzBVdmlZK2duTXhm?=
 =?utf-8?B?ZU54TXBaWWNOWk9SSXhiZ2xZNEJ1eWQ5MjJKaWpxVTNTWUJwTzI5eEY0L2Fv?=
 =?utf-8?B?VFBLQ09ybFB6WVU3bWhhZnE3TEsvYnY3N1lhY0JTZnFUTXpmTnhOdHhSQVZn?=
 =?utf-8?B?MGNmclA3UVh2WUlSZHUxbXpqSGI2cXpsSFVtZFpaWVNoM3RFSUZrY0R5cWF1?=
 =?utf-8?B?SGtpWVBhVXNyVVZYUnBNZFVWTWtHSHlpcGpiZjVYdEpXdTdUN0lQV2oySkVu?=
 =?utf-8?B?S05UUEVqbnhUREcvYWwxZnM4V2VQS1VmRzdia05JVFBBSDdYQm1hNUVrU1E5?=
 =?utf-8?B?OG84a2FRc0pyNWY2b2RVU1lqWHkvTDNOaHNmQlZXUnJ5aE04cjdocjYzc3lV?=
 =?utf-8?B?V0hYK1FZazFmNjMrSHpkSVhGeUVSTkFReXRJRlJ1WWsraGxsZmF0TmJKY09v?=
 =?utf-8?B?akp2OExMZWdkWXBramM5ZnJuZFRRelFkcHdZamtSZFNRME1RQWJKSE15T3Nu?=
 =?utf-8?B?UWpNSHgxcFZMZm5KSmtnMjJOQnhDWkQ4YVUrdWxJZWFMUHNHN2N2MVhaOWRJ?=
 =?utf-8?B?VkNHNCtta0lvallwendCcTU5UEwzZ0ZGRWFadjQ1WlNQQ3dxVlJBeDhEalJv?=
 =?utf-8?B?d0RsSWNZSTB6Qkc0d1dnbkNiN0tIWmFlbFVtQmlmUDJ0VTRlTDNkWS8wSnNK?=
 =?utf-8?B?ZU40N05SVWtuNU8rVytJeEVsRzU5VGJ5alNVdmJObEJKdXQzazdmRlpqanB2?=
 =?utf-8?B?SFh2U1NZWHRvZzJ5Q25YK0JTeDFJQy9qK2oxK1A2aXVEMys4V01GRFJveXdw?=
 =?utf-8?B?bmFWNHFWcDFCeEswME1ZWU1FNUdHZXFmclp3ZmtNeHY3bEVmUWtxZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f80f7f91-a89c-440c-bd95-08da185d682e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 06:11:09.3701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T4efavg+Hg4fLY5etLUBzC+Q5RIyjjnBWQdsk087jaC7pldJQKJzi7iNf9UT2rDjcVsqb2Tj64GyXflnBw9wxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5596

First there's a printk() which actually wrongly uses pdev in the first
place: We want to log the coordinates of the (perhaps fake) device
acted upon, which may not be pdev.

Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
device quarantine page tables (part I)") to add a domid_t parameter to
domain_context_unmap_one(): It's only used to pass back here via
me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again.

Finally there's the invocation of domain_context_mapping_one(), which
needs to be passed the correct domain ID. Avoid taking that path when
pdev is NULL and the quarantine state is what would need restoring to.
This means we can't security-support PCI devices with RMRRs (if such
exist in practice) any longer.

Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quarantining")
Coverity ID: 1503784
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Drop SUPPORT.md addition. Adjust comment. Extend another comment.

--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -85,7 +85,7 @@ int domain_context_mapping_one(struct do
                                const struct pci_dev *pdev, domid_t domid,
                                paddr_t pgd_maddr, unsigned int mode);
 int domain_context_unmap_one(struct domain *domain, struct vtd_iommu *iommu,
-                             uint8_t bus, uint8_t devfn, domid_t domid);
+                             uint8_t bus, uint8_t devfn);
 int cf_check intel_iommu_get_reserved_device_memory(
     iommu_grdm_t *func, void *ctxt);
 
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1533,7 +1533,7 @@ int domain_context_mapping_one(
                 check_cleanup_domid_map(domain, pdev, iommu);
             printk(XENLOG_ERR
                    "%pp: unexpected context entry %016lx_%016lx (expected %016lx_%016lx)\n",
-                   &PCI_SBDF3(pdev->seg, pdev->bus, devfn),
+                   &PCI_SBDF3(seg, bus, devfn),
                    (uint64_t)(res >> 64), (uint64_t)res,
                    (uint64_t)(old >> 64), (uint64_t)old);
             rc = -EILSEQ;
@@ -1601,9 +1601,14 @@ int domain_context_mapping_one(
 
     if ( rc )
     {
-        if ( !prev_dom )
-            ret = domain_context_unmap_one(domain, iommu, bus, devfn,
-                                           DEVICE_DOMID(domain, pdev));
+        if ( !prev_dom ||
+             /*
+              * Unmapping here means DEV_TYPE_PCI devices with RMRRs (if such
+              * exist) would cause problems if such a region was actually
+              * accessed.
+              */
+             (prev_dom == dom_io && !pdev) )
+            ret = domain_context_unmap_one(domain, iommu, bus, devfn);
         else if ( prev_dom != domain ) /* Avoid infinite recursion. */
             ret = domain_context_mapping_one(prev_dom, iommu, bus, devfn, pdev,
                                              DEVICE_DOMID(prev_dom, pdev),
@@ -1744,7 +1749,9 @@ static int domain_context_mapping(struct
          * Strictly speaking if the device is the only one behind this bridge
          * and the only one with this (secbus,0,0) tuple, it could be allowed
          * to be re-assigned regardless of RMRR presence.  But let's deal with
-         * that case only if it is actually found in the wild.
+         * that case only if it is actually found in the wild.  Note that
+         * dealing with this just here would still not render the operation
+         * secure.
          */
         else if ( prev_present && (mode & MAP_WITH_RMRR) &&
                   domain != pdev->domain )
@@ -1809,7 +1816,7 @@ static int domain_context_mapping(struct
 int domain_context_unmap_one(
     struct domain *domain,
     struct vtd_iommu *iommu,
-    uint8_t bus, uint8_t devfn, domid_t domid)
+    uint8_t bus, uint8_t devfn)
 {
     struct context_entry *context, *context_entries;
     u64 maddr;
@@ -1867,7 +1874,8 @@ int domain_context_unmap_one(
     unmap_vtd_domain_page(context_entries);
 
     if ( !iommu->drhd->segment && !rc )
-        rc = me_wifi_quirk(domain, bus, devfn, domid, 0, UNMAP_ME_PHANTOM_FUNC);
+        rc = me_wifi_quirk(domain, bus, devfn, DOMID_INVALID, 0,
+                           UNMAP_ME_PHANTOM_FUNC);
 
     if ( rc && !is_hardware_domain(domain) && domain != dom_io )
     {
@@ -1916,8 +1924,7 @@ static const struct acpi_drhd_unit *doma
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCIe: unmap %pp\n",
                    domain, &PCI_SBDF3(seg, bus, devfn));
-        ret = domain_context_unmap_one(domain, iommu, bus, devfn,
-                                       DEVICE_DOMID(domain, pdev));
+        ret = domain_context_unmap_one(domain, iommu, bus, devfn);
         if ( !ret && devfn == pdev->devfn && ats_device(pdev, drhd) > 0 )
             disable_ats_device(pdev);
 
@@ -1930,8 +1937,7 @@ static const struct acpi_drhd_unit *doma
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCI: unmap %pp\n",
                    domain, &PCI_SBDF3(seg, bus, devfn));
-        ret = domain_context_unmap_one(domain, iommu, bus, devfn,
-                                       DEVICE_DOMID(domain, pdev));
+        ret = domain_context_unmap_one(domain, iommu, bus, devfn);
         if ( ret )
             break;
 
@@ -1954,12 +1960,10 @@ static const struct acpi_drhd_unit *doma
             break;
         }
 
-        ret = domain_context_unmap_one(domain, iommu, tmp_bus, tmp_devfn,
-                                       DEVICE_DOMID(domain, pdev));
+        ret = domain_context_unmap_one(domain, iommu, tmp_bus, tmp_devfn);
         /* PCIe to PCI/PCIx bridge */
         if ( !ret && pdev_type(seg, tmp_bus, tmp_devfn) == DEV_TYPE_PCIe2PCI_BRIDGE )
-            ret = domain_context_unmap_one(domain, iommu, secbus, 0,
-                                           DEVICE_DOMID(domain, pdev));
+            ret = domain_context_unmap_one(domain, iommu, secbus, 0);
 
         break;
 
--- a/xen/drivers/passthrough/vtd/quirks.c
+++ b/xen/drivers/passthrough/vtd/quirks.c
@@ -427,7 +427,7 @@ static int __must_check map_me_phantom_f
                                         domid, pgd_maddr, mode);
     else
         rc = domain_context_unmap_one(domain, drhd->iommu, 0,
-                                      PCI_DEVFN(dev, 7), domid);
+                                      PCI_DEVFN(dev, 7));
 
     return rc;
 }



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:12:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:12:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300391.512348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLN5-0001uo-PF; Thu, 07 Apr 2022 06:11:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300391.512348; Thu, 07 Apr 2022 06:11:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLN5-0001uh-M6; Thu, 07 Apr 2022 06:11:55 +0000
Received: by outflank-mailman (input) for mailman id 300391;
 Thu, 07 Apr 2022 06:11:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncLN4-0001On-6m
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:11:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9e871d36-b639-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 08:11:53 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-yAqrafMGM3yC60nFVaQr1A-1; Thu, 07 Apr 2022 08:11:49 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR0402MB3620.eurprd04.prod.outlook.com (2603:10a6:208:1c::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 06:11:48 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 06:11:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e871d36-b639-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649311913;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=E6G0lhWDzKngo22Cqa5yFBt1cU5VEIbGGSfIbs2WoXA=;
	b=VdcbK9z14RwkQr9+l4dhRlhtKNhJaBC9MzSYRAZH5C/JAsCY83YLYpZUsLTig/Hbp2sFaU
	z75fwLGUhNKjJ7cfXLdhTrkljQE49F/SdKJEx7h3RYXb2Tapl1Zo+sWQMu3F0B9XtcR/Li
	gNgmzlWkjBgCPGCxsmvex+UFm/jR5Lg=
X-MC-Unique: yAqrafMGM3yC60nFVaQr1A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Dq3lw7XZacNFhs1Cz0SGnmrmzWQ1dLsL9kg599Nag5GAylMP/gf7osFv9/3nxTxCdjTbComiXVF5oFx/mz54do3wnjn9XdZqsAMqyrHOVZyZKy0wumB2t06W6d7+Jjax3v0GLoGTsmkewYv5gwx6Yc2RYek+2yl7dahBx1ws5GyObTkri5hhtmwywrw/M8mIyzIjY5YK9PNyaEN7dvfQ3qgvA1OaQUAxVx1GXDvVQLuyTQAFlQq6cXfFpO/+taskf/voIIxv91AcE4LY1KQvC4EGFN12hItffyDmBISj32aBigBpuhe0KQA3LTlUSL1XFtOjsAUl0m5aiBWAiH154A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E6G0lhWDzKngo22Cqa5yFBt1cU5VEIbGGSfIbs2WoXA=;
 b=TxIaEUflRhoixXGlv21DitWLc2WgrCcWSPRRQin23/TerJGzTXknrBavIx76RI2olPDaCWebJU+IxA0JBG+0XECamcW+2iDAoU9JtuD0SCQYr7VMDnf6LmZmawi3C99MRxubEgvhv6YzKw5vDrBBOSaHBZtnR7fJRqXC94sLsUnBD438GE75ArC+UHComH1iYt8lVhZJbxHtpwUkIC062vn11Ydc+S77Jo33Ro3Pg7RC2W5KeehK6x4K1d79v5Dh+gtj9Ck2QErBwHvDNYzaM/kBU3lha8td3C1gNQIEooJO7B8k6jOk8VpkBlaSlva+bsyllK4BTmdcaiTg7CW93Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fcc51df9-0896-247b-d4ad-0de4db6c2a9c@suse.com>
Date: Thu, 7 Apr 2022 08:11:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: [PATCH v2 2/2] VT-d: avoid infinite recursion on
 domain_context_mapping_one() error path
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
In-Reply-To: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0005.eurprd07.prod.outlook.com
 (2603:10a6:203:51::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54631877-aa11-48ee-3c42-08da185d7f51
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3620:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3620137B61EE96CE967414BCB3E69@AM0PR0402MB3620.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	z2xD/SLGybNKvML+sa9c/lvtMeKbi1JMbA8CJ3pKz/Wu+per61Iv/8QXWAPCgmRnMsq2WK2MF6SkVXnhyOy1wiXGG2LsMBRVXcrI52gzO8DpOJXSYFzlme+PT/0zgZ8wdZkPAl5q3B/lFUU/t2r8U3bla9ExRPKO0g1uJMm62AWOdULlte6mS2k4mMGHeBJSnEA7l5/WJbX1WE1qXxiU9ZNHeRG5jFqflsiPRD472ucAmfOuLIua9tG5nCcVO+0b+5E57+k0D7X1o7vl1wFyOQ3LTZSocn1BFgzmFMMS74M6J4wUGfTaWBoFwtjekgiap/vkZdpi+mf4kynAGdZf3AtOFwdUkm021sxFSSn/l7sAhatiVQZXxecpFnPoTZKqgkc2rDw5ANUThi8TSA3yj13oApNNUB0gdD3YRJdKVB8zetN7rekwrD320JC3QZ/yaxbh1d8Eh+Ed5BXZa/s2TCT4Tej9tm7ho/pqt+fpsyJ43GcRgYDlzVhODRkKmyef6x3plyL+woxHGcP2u22KCGgYTpwe4M2bdkgtoK4QLAly1HJw/h6yEp1k+gA4QWb5tijbANxu/duKW5dIZRX6CYoQy86HqaGTR4tfnLrhQVNpuxcGsv3y4NNGE/OlWmjCNQ5noz08YwSp6ckrBdesKAXa6PzuLQ26CTrhnxCYwCJIt1zVLQYy7DVeFnjrs1VRBk3usybj9CiSsjM2NhS/A5TzAwKzjdz2HO7p5LtpEJxXreeaZQNqMoC4IJ2PWQE7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(508600001)(8676002)(31686004)(36756003)(6506007)(6486002)(38100700002)(66946007)(66556008)(66476007)(2616005)(8936002)(31696002)(26005)(6512007)(86362001)(54906003)(5660300002)(316002)(186003)(6916009)(83380400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGd5M0gzV00yaCtKUVZRSmdwR2VFUU9FZTZBenpYdFRteXRsMVlud2k1RGt2?=
 =?utf-8?B?NGhHRXpmMXRMS0ltSXoyZ2Q3ekwvSFBnZlZJUUJxcTBEenhIdmRCdnZ3aTc5?=
 =?utf-8?B?Y3JmbXlVL3lCVHFtdGs2Z1dSVGNCU04zMWV0TFlKakJHN29qY2s0TTVHR3FS?=
 =?utf-8?B?WXVtRWZadlR5S1c1d2RDeTY5dDh1dHNVRmcrUW9DSWlEN1FldVloREpMZkpF?=
 =?utf-8?B?OUlwOWQ0eFoxdHN2SGg2S0FjSy91NUhKK05TMFZzcUhHdjlDYlk4UjkrYksy?=
 =?utf-8?B?YUdXTElFZVFTaU00aWhsSlJDQnJzZjNiZFEvZlgwdVF0Z1dReDJFRGxYeWNi?=
 =?utf-8?B?ZlpEckxpK2JWTVZ3YVB6YWdWL1J5V0JIMWRwcmJub0p0TW5aN0FQWGxWOW5u?=
 =?utf-8?B?VkN3SlpOWXNJcmpxS3RBaEtoSk41US9lWHdza1VFQVlXeEIzVXdCLzh1alRJ?=
 =?utf-8?B?czFQSHRZd1BIYVJhNi95QllvM1BidHJITUI4RDdyZ1dBSmNqanNTSkdTMmZJ?=
 =?utf-8?B?Y2wzaEJzNEdyOWh0N1RNZU5WQUlWUXIvRFRjc1pCcW42K0ZXenppL2tpbk14?=
 =?utf-8?B?VlkvVnhZQkVYL21TV2FMMTdJK0ozSnc3c1NGUi92R254OWRyQ3hiY3RXbW1u?=
 =?utf-8?B?SWFnTkZxQ2d0TXJnYzVNUExYdVRTcVFyQWZlcndLaEZXa0xyc1BmdU9KREw1?=
 =?utf-8?B?Um44NytiQ3hqR2VuZzdZMFg2ZDdKNEQxVnZsVkdmS0NqcWxOY1g3SzhTbU02?=
 =?utf-8?B?OTQvTUZsVkVQV2lHNlNybmxmQytlcHlvVnNUMFhiM0VER0hGdm1MNkNRVzBa?=
 =?utf-8?B?K3BTSmFaeTJHbEtlNVVNUDlBeWNDbWovK2xkR2swTys4QjhTbFlLd1psRWxn?=
 =?utf-8?B?bnhlZlViTFhlWEFjRFZxYUp0RFVoR0FXTEF2MVR5MjNWMG80WUl2c0QzN2dX?=
 =?utf-8?B?a211UkpNWlRmcDNnR2xXaVQycGRsZGhpZW11ek1HcmtjaTFWNEQxcGRnL3hL?=
 =?utf-8?B?MzQ2TWJLWXl1Rmc2dFVYVGdIT3R3Rms5OEZMTnFKNFdKZit4UjFFQWlLbm80?=
 =?utf-8?B?dHhueSs3SFBNQm5WbWU3WTYxWDdFT2tSTHZ3K0IveFpFZ0FCNEJSV3ZMaEJS?=
 =?utf-8?B?NVNkcndReklRcjZuVWk4dXIrcHZhKzN5TDJXTjFkWW05cGRyaEplaGNkWURn?=
 =?utf-8?B?Z3FFRU5NVVMyVWt6d2FVOWlxcTFURHpobThPeTNBajN5b2ZDU0w4bktKSEhG?=
 =?utf-8?B?b3MvTFVXeHQzdjBXSHNUWFloMFdhM1pPS1JKRXVLNE5SWjUzNmtlTmpZV0pt?=
 =?utf-8?B?eEJDWFpTb3h4T3oxeXZMdXNITmdZdk1sRzVYOFVDZ3NtVjRxaDlMZ0FXbkZ2?=
 =?utf-8?B?WXVLdDQvVEViaUZsdTgzNk81K1FIdlcvZUxnNjVXVngvQzVEUXJBSzY2dWRY?=
 =?utf-8?B?Vlp2NjZGcFNUK0c2VXJvbHE3TzFWbW1kWThzZVNYZFNXSjdYcDhNMDdiVVBU?=
 =?utf-8?B?WG1OTWZzQ2RhVm56OTlxYkdkajhuVndGWUNxOEk1YW9QM0I0L0hsVmdaQWJE?=
 =?utf-8?B?M3NiVFVkOEloTlRuZVZTdkwyeHpuckpKand5eldqbmYrVjdBOFRwMGFkQlBH?=
 =?utf-8?B?eEhXWm5lWEY4NWd2OWR3bVVRc2dGUXJENnhNcVJJSVVYTnhrZkpkcXJrRjhV?=
 =?utf-8?B?N2lzS2w3L1Bvbm5heklHY3I4QW5kRFduR2tEbEo0S0lyUE1tUVBSZUkvYWpM?=
 =?utf-8?B?TVZoU1ZJZHRWK2taVEhpdTluTmFuU1ZFQU0wczhqU09rRmNwT0NtV1A2Mkdt?=
 =?utf-8?B?YjVOTHh2WStsWXBndlVER0kwTzFObU03ekpNYThTaHdyV0UvbGpka3RnbGdN?=
 =?utf-8?B?Q0FKSC9jWEJ1UkkwS3JrWXc3YlFRVkN6OGpNMFQvYUcwcytqTVBnNGUwbFl5?=
 =?utf-8?B?cDVUTFU2Nmh4QlloalpBc0JyeXdvOGk0aXBTRHhzcWYwZHo4ZVNkVDJmTnVF?=
 =?utf-8?B?Y05ja2tGVEJNaUtQbkh6N05kY29mam5sYlpObVN0WjIxYWltcjg3RHkxcytr?=
 =?utf-8?B?T1AzY2Y2U0xlMnBmdUhTK0F0RWx3eVVNdjFJYmkxam53V2ZkMnE4RWFZWStj?=
 =?utf-8?B?NEpqRlpSeXpYSkwzODd0K2dSb3VzalBoTmZBenhmcWU3N0poWTl0QUI5UDBt?=
 =?utf-8?B?aGt5ODNkMGM4eFMwb2toTlE5cVM5bDhBTGpOV3k4eDNvc3E3WGFCc2svQnV3?=
 =?utf-8?B?L1hycjE0d1pheUJjaHRqQzk0UFF0MlVsanpRSE1lS0Z5L2RISVBodHFCd3dU?=
 =?utf-8?B?YzBhakZBeXJHYlp0NFFjc3NEaW1pMEMxKzNTVHlzVWlBK0YwYjk1Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54631877-aa11-48ee-3c42-08da185d7f51
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 06:11:47.8869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8aIh2LfGPAsNOHAsS4hbnDvr4HLQewkijJrlZAgZGGsdFIggFaFWqmw4GDnoT6LFkDjpi77RzsRFyDfN2nI94A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3620

Despite the comment there infinite recursion was still possible, by
flip-flopping between two domains. This is because prev_dom is derived
from the DID found in the context entry, which was already updated by
the time error recovery is invoked. Simply introduce yet another mode
flag to prevent rolling back an in-progress roll-back of a prior
mapping attempt.

Also drop the existing recursion prevention for having been dead anyway:
Earlier in the function we already bail when prev_dom == domain.

Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Extend scope of the approach taken. Leverage for some cleanup.

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1599,7 +1599,7 @@ int domain_context_mapping_one(
     if ( !seg && !rc )
         rc = me_wifi_quirk(domain, bus, devfn, domid, pgd_maddr, mode);
 
-    if ( rc )
+    if ( rc && !(mode & MAP_ERROR_RECOVERY) )
     {
         if ( !prev_dom ||
              /*
@@ -1609,13 +1609,12 @@ int domain_context_mapping_one(
               */
              (prev_dom == dom_io && !pdev) )
             ret = domain_context_unmap_one(domain, iommu, bus, devfn);
-        else if ( prev_dom != domain ) /* Avoid infinite recursion. */
+        else
             ret = domain_context_mapping_one(prev_dom, iommu, bus, devfn, pdev,
                                              DEVICE_DOMID(prev_dom, pdev),
                                              DEVICE_PGTABLE(prev_dom, pdev),
-                                             mode & MAP_WITH_RMRR) < 0;
-        else
-            ret = 1;
+                                             (mode & MAP_WITH_RMRR) |
+                                             MAP_ERROR_RECOVERY) < 0;
 
         if ( !ret && pdev && pdev->devfn == devfn )
             check_cleanup_domid_map(domain, pdev, iommu);
--- a/xen/drivers/passthrough/vtd/vtd.h
+++ b/xen/drivers/passthrough/vtd/vtd.h
@@ -29,7 +29,8 @@
 #define MAP_WITH_RMRR         (1u << 0)
 #define MAP_OWNER_DYING       (1u << 1)
 #define MAP_SINGLE_DEVICE     (1u << 2)
-#define UNMAP_ME_PHANTOM_FUNC (1u << 3)
+#define MAP_ERROR_RECOVERY    (1u << 3)
+#define UNMAP_ME_PHANTOM_FUNC (1u << 4)
 
 /* Allow for both IOAPIC and IOSAPIC. */
 #define IO_xAPIC_route_entry IO_APIC_route_entry



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:12:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:12:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300396.512358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLNy-0002aY-6v; Thu, 07 Apr 2022 06:12:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300396.512358; Thu, 07 Apr 2022 06:12:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLNy-0002aR-3z; Thu, 07 Apr 2022 06:12:50 +0000
Received: by outflank-mailman (input) for mailman id 300396;
 Thu, 07 Apr 2022 06:12:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncLNw-0002aD-Pl; Thu, 07 Apr 2022 06:12:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncLNw-0008Rg-MR; Thu, 07 Apr 2022 06:12:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncLNw-0003Xv-6q; Thu, 07 Apr 2022 06:12:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncLNw-00035M-6L; Thu, 07 Apr 2022 06:12:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TC/OrK4pznHJ93NBT8e4uRmhQ0rtWYtuiiWzp/RrlV4=; b=KK5SUJh6wcnH36iPv18LA6Mj9h
	gcNA6wJzeGAb6cgALGeb+Km/SUQ+araAglERosbp/uGYOINofseUwUgiVYB52IZqwOCRHRsF7058A
	iNnfROj7oi7xnFWS24R9y/nNhMsIk/gl8bcIDh2Gnc4pn+HO9HgSqD8EZ2MGQ2aeCfOE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169195-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169195: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=f53faa70bb63cc0c8e2fd0752b7ad2c8a79616ba
X-Osstest-Versions-That:
    qemuu=223a8671cac29f64591a8e01c00d8db45a343d52
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 06:12:48 +0000

flight 169195 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169195/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169181

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169181
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169181
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169181
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169181
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169181
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169181
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169181
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169181
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                f53faa70bb63cc0c8e2fd0752b7ad2c8a79616ba
baseline version:
 qemuu                223a8671cac29f64591a8e01c00d8db45a343d52

Last test of basis   169181  2022-04-05 13:38:18 Z    1 days
Testing same since   169195  2022-04-06 09:26:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dov Murik <dovmurik@linux.ibm.com>
  Helge Konetzka <hk@zapateado.de>
  Markus Armbruster <armbru@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Victor Toso <victortoso@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   223a8671ca..f53faa70bb  f53faa70bb63cc0c8e2fd0752b7ad2c8a79616ba -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:16:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:16:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300406.512369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLQz-0003GD-Nq; Thu, 07 Apr 2022 06:15:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300406.512369; Thu, 07 Apr 2022 06:15:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLQz-0003G6-Kn; Thu, 07 Apr 2022 06:15:57 +0000
Received: by outflank-mailman (input) for mailman id 300406;
 Thu, 07 Apr 2022 06:15:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncLQy-0003Fw-3M
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:15:56 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ec4962d-b63a-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 08:15:55 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id DD8AB1F85B;
 Thu,  7 Apr 2022 06:15:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8156313485;
 Thu,  7 Apr 2022 06:15:54 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 3POMHZqBTmKQUwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 06:15:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ec4962d-b63a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649312154; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=8SutVXeCr1YmsqlT/WY69fwgxgczRzOCrKzxQx/uaeA=;
	b=TQobK7zZ2WByT6i3sVlYhwxXO8bLaLq0FF2Mbe93KSj/TeHpjlTzI3gmH1BZ6xsKQBxrPw
	ClUu4ShL/oxZOB0NIuVlMS959yjHq9mDvjxwOjcY7pGKI0pC8U4+ynSiiGWN8RJ3j7/uj9
	cj23DHvo4/CKAB6lRQG/uMEmjRUgRLo=
Message-ID: <985e0230-bfc3-8cf1-84b9-0d3a43e4f58f@suse.com>
Date: Thu, 7 Apr 2022 08:15:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-5-luca.fancellu@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220405085741.18336-5-luca.fancellu@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------d3V8DgBcMTj0NZmT54PdL4lK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------d3V8DgBcMTj0NZmT54PdL4lK
Content-Type: multipart/mixed; boundary="------------QKdZ4klpWqssqoh0U90f2J8s";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
Message-ID: <985e0230-bfc3-8cf1-84b9-0d3a43e4f58f@suse.com>
Subject: Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot
 time
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-5-luca.fancellu@arm.com>
In-Reply-To: <20220405085741.18336-5-luca.fancellu@arm.com>

--------------QKdZ4klpWqssqoh0U90f2J8s
Content-Type: multipart/mixed; boundary="------------raFQN2Ydhj6LWNJqeiuKVe3l"

--------------raFQN2Ydhj6LWNJqeiuKVe3l
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMDQuMjIgMTA6NTcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IEludHJvZHVjZSBh
IHdheSB0byBjcmVhdGUgZGlmZmVyZW50IGNwdXBvb2xzIGF0IGJvb3QgdGltZSwgdGhpcyBp
cw0KPiBwYXJ0aWN1bGFybHkgdXNlZnVsIG9uIEFSTSBiaWcuTElUVExFIHN5c3RlbSB3aGVy
ZSB0aGVyZSBtaWdodCBiZSB0aGUNCj4gbmVlZCB0byBoYXZlIGRpZmZlcmVudCBjcHVwb29s
cyBmb3IgZWFjaCB0eXBlIG9mIGNvcmUsIGJ1dCBhbHNvDQo+IHN5c3RlbXMgdXNpbmcgTlVN
QSBjYW4gaGF2ZSBkaWZmZXJlbnQgY3B1IHBvb2xzIGZvciBlYWNoIG5vZGUuDQo+IA0KPiBU
aGUgZmVhdHVyZSBvbiBhcm0gcmVsaWVzIG9uIGEgc3BlY2lmaWNhdGlvbiBvZiB0aGUgY3B1
cG9vbHMgZnJvbSB0aGUNCj4gZGV2aWNlIHRyZWUgdG8gYnVpbGQgcG9vbHMgYW5kIGFzc2ln
biBjcHVzIHRvIHRoZW0uDQo+IA0KPiBEb2N1bWVudGF0aW9uIGlzIGNyZWF0ZWQgdG8gZXhw
bGFpbiB0aGUgZmVhdHVyZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUg
PGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3Mg
PGpncm9zc0BzdXNlLmNvbT4gIyB4ZW4vY29tbW9uL3NjaGVkDQo=
--------------raFQN2Ydhj6LWNJqeiuKVe3l
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------raFQN2Ydhj6LWNJqeiuKVe3l--

--------------QKdZ4klpWqssqoh0U90f2J8s--

--------------d3V8DgBcMTj0NZmT54PdL4lK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJOgZkFAwAAAAAACgkQsN6d1ii/Ey8c
kgf/T8iBC/kzZY4oxJhLHTUWuf5PZqr8ttbtI/P4XNAtZGlV7Z2Pe+sOUJUqRWKKu/okcYyRc/i8
PStsEhgY3Z4kytUbRU7m9AzPTqKaQ3nZ4HlMYDu+FkvKQgiKubYkfHcHFKgxCGm14O4P6M4Ljjw9
SST1MoAvEfeENYcjZRZjZ0JYeAPDdHnaha8YvADsqSGZC7lUNbTOjPBPAkd6Y9FDZer6SNShew0I
BQwPpsqDL9+g9w847xdQAW4WCaXR1AQUUoB7xYnuXnUl4aN1oHd6zeKJRFLfKbhHQ2kryG42Dl3w
ThkbTeBuR+SAu5XGLsSYtSH+nsLuR23e0qSyuZhrfQ==
=ZvMl
-----END PGP SIGNATURE-----

--------------d3V8DgBcMTj0NZmT54PdL4lK--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:26:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:26:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300410.512381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLb9-0004yA-P1; Thu, 07 Apr 2022 06:26:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300410.512381; Thu, 07 Apr 2022 06:26:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLb9-0004y3-Lu; Thu, 07 Apr 2022 06:26:27 +0000
Received: by outflank-mailman (input) for mailman id 300410;
 Thu, 07 Apr 2022 06:26:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncLb7-0004xt-Rb; Thu, 07 Apr 2022 06:26:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncLb7-0000D7-P9; Thu, 07 Apr 2022 06:26:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncLb7-000445-8m; Thu, 07 Apr 2022 06:26:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncLb7-0005Ik-8I; Thu, 07 Apr 2022 06:26:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BmAIfW/6t/yRp9v9+H1YN1ubcc+aeqqCIlOmcCds9mI=; b=WjBm1px8+Lc5Dfmw5vncc+AVzD
	vcSKPXZTsnaH3kVEgbd4yqPfSGTdu6IkhRmscxBSZUvvg07QZpyWTQVmOTK9guI70Mfv+osHHod99
	Aj6Va6LJHTwub0tnLAnrY7yGdrRN65CGHZ3zAfJ0ZSZyu2mCyeV8k9S09hYufQEemJpo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169202-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169202: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=a298a84478053872ed9da660a75f182ce81b8ddc
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 06:26:25 +0000

flight 169202 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169202/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 a298a84478053872ed9da660a75f182ce81b8ddc
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   37 days
Failing since        168258  2022-03-01 01:55:31 Z   37 days  283 attempts
Testing same since   169173  2022-04-05 05:13:00 Z    2 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4610 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:26:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:26:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300415.512392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLbQ-0005KX-8C; Thu, 07 Apr 2022 06:26:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300415.512392; Thu, 07 Apr 2022 06:26:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLbQ-0005KQ-4p; Thu, 07 Apr 2022 06:26:44 +0000
Received: by outflank-mailman (input) for mailman id 300415;
 Thu, 07 Apr 2022 06:26:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncLbP-0005HB-1i
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:26:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b03dddb8-b63b-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 08:26:42 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-ag8o-M_EOZ6b-BL2HC6C6w-1; Thu, 07 Apr 2022 08:26:40 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB9PR04MB8218.eurprd04.prod.outlook.com (2603:10a6:10:24a::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Thu, 7 Apr
 2022 06:26:39 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 06:26:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b03dddb8-b63b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649312801;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=s/hF5cU3CbhSuiIAEiiAPiAmzxHlreCDMq5HYReQQkA=;
	b=hQd1EH4j13mzk5ougBKHPFTI4i++btYry2nfCSZJ75/HJe+H/1YPbpzixQnxWYfkK9OKh4
	ny0NAfImkl9VcDcbuzUsk3S919xM75JY3w++EdQnNo12WyP8hIuVmDg+ok3SJhKBVe0DLl
	7PfdSt7uH9HQdcHELJGqi1rFZvAZ4wM=
X-MC-Unique: ag8o-M_EOZ6b-BL2HC6C6w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WNIlmhB2YL//iCcrCicTc385HqmFcM0in4oXNvL9qZ0lWCvSemK3c/YHB6sHq+yV38/jMPUTIOX4dOENa+AUiIg3EMVvwvuf7jH/W2VAKY/ho1ztam+QxpJimPhk0heoR7j0Bn24KqseqVZp8v537gujTL9KG3BMreL94/Je55PwUqdHKiFHpSl4E7Gtak15Is2HI+9CFb64KY1UJyNNGHS7vIdOnU/nw1o/cBz9u/Y/koDo7Zgu6Yr0YLWVSv2k9gyIzs0I4jRLAMyMeSMCYEejJOg6TaEJPmiSUKJUcfimwha37KJl/xZ/JQ0JQawv+GefVlzJyirYaviRqjacjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TC9iNGShkKwJsEptMl2ysrvbuIHZi2Ew1KNOn995Z98=;
 b=lTpDD0OCT16qLnF/aauxC5oilQ5pNHBxWRcpcS34d0EHaylyEYNlJb6ucpZuXAEFLaV+LY9mwALbyVXjRvtrjmeXNeo7drtibHSaM1h8sCVS7QUwoU/iXfnmKBzwhTLLH/GtxbPADHE/1Oja6M3siPqzPI3bOdyE1TCM1v2f1l+zFdUU3b2y8LmjACdCcKB1GDGdPgQtPE+w+5DqJKgKBb4uTmK+2JMgrbHoifBNcRFxcGgVTYcGTTJWdqljjT03ys3MP1zYDiUHjVRW2SbBBfaFPm56EV1w6bMAiOnZuSwqzfttzNVR6bd2cqFT96rErd4bVUe4vrQZbsvMNjHi+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <008be273-8730-5637-f35c-021e67d3d664@suse.com>
Date: Thu, 7 Apr 2022 08:26:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] x86/cpuid: Clobber CPUID leaves 0x800000{1d..20}
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220407010121.11301-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220407010121.11301-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR01CA0044.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::21) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f1d6ba9f-7be8-4062-a683-08da185f9307
X-MS-TrafficTypeDiagnostic: DB9PR04MB8218:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB8218A218E563449A0BB4A40BB3E69@DB9PR04MB8218.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KVAhFFPdgcr6wAK7oly3XU268OdyF18kEptSnXGkXsx23L9hjMkFQ4wEsgSe6eNH+M1oBfeDmdcySOKyVIVk8wIdN2F2K4cmqT6DFnPskUUYZHRJ/fJOhfj7zcRjIFBlHF37bLU406QCiE25NtHdfETZnvYBHsBe1cWNIiJwbEwCR65cmLO4hL7dNB6dh5AupPL9IFRwDA9cdeIIeXbu0tX7cGgC5f1yJJ9TUWa+tu4lA64wZ1p68X1OTPD0karvmQInUWMH4TqthgKAt3o0GSwkJ+66ahzZfsTjs7L8ZJOhEw6S1xJB13Hsd9kWphf7+lsAdqzMsu4Mn0yCC0kXE+yPp5TnsL+r3p9pLRdSHkFmHWuIji/GCXcaSIrmYaDW+CMCydSBruw+IPME8jjl0ZF+E8o9KZN1jPAQwRHwKNx1t/4WH0spDqPvSmvU5XQ9UXs8QZ/x46Zi+cf1hLo4CY1yD+TTRMpTcPntWhQCMzQ2m5AOb1O6XT8DXcj2BuNpVjsDvsUuvyFXNaG5aX+Pl1C5/jEthb9B+nL+S9D+Z41llz+lLseEepoy47zyc4a/LplT6ShyiK0oH9Hi/tEXGTwH2/iYEdsofToSDWJzT8boPl2hPcXmn3qLtjdkJs3N8xCE6Krm5x6CxUlqAJAUtWDFlvcaABUHwtF+GuS3k3kgFbj0UKtqlCQNQPmPZgJymI3Z3/W9iZ3/g7HmrpeU6MHu9x6cmNp7P+eJI1Gc4alvzcVvHwf/4uWBx2yQtH28KJ1VdotWqRjdz4UAWPfRSK+kFtGCdAPnHOlpUJr8+9auYmQ5bwQgqBp0cs8qS2Mg26YIZMuFpksep0HJEZmALt2wiPwMjYlDZ26aSZWtSic=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(66574015)(86362001)(6506007)(6512007)(6916009)(316002)(2616005)(186003)(53546011)(54906003)(5660300002)(6486002)(26005)(966005)(508600001)(66946007)(4326008)(31686004)(38100700002)(2906002)(83380400001)(36756003)(8676002)(66556008)(66476007)(8936002)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tXS/+9vZKLnxeXfd+OM2ON22SyaJ99ti9FK2D1UQNsAn5FModUyJsRtoQSn+?=
 =?us-ascii?Q?mGtDLwRic9iQ5O/6m4ycyzQVFrezjfuwPfXu7tOmWDYSY/MBNUSbhpRCO/mI?=
 =?us-ascii?Q?+NQvikE+m73WPcVGicdjqn120khMRxOF5ruFlEsqb8cnaXFQiHLK7/H8ftYW?=
 =?us-ascii?Q?rqECNPoiRYXe6N+FYpm/6vD5Oxgd9GLhjL5HKEt0rifWEIaG/I2/ucvuJsWA?=
 =?us-ascii?Q?vAlAVqvCirlYt7zx/7CaGq4f8GH69oWafeeeHJylzp72vCPuP4cLmV5at85X?=
 =?us-ascii?Q?pn3I7n0vg3tTlxFhGy9IuHsqNVmjUPhqndlpbZ3ukrVMAVx3QyUYTtz3Cr03?=
 =?us-ascii?Q?98nmFqPSH0Y+6/ON1r/C3Z9tKLERZ7tyRidZODFkvR9QnlzGhJpbwcL1Cfn/?=
 =?us-ascii?Q?/GpNZ0PXKGQdFZahWMXRpWN/YS6yiJ9UjXhqU4y/ZBInGrsDFL4Y8YyVq4mA?=
 =?us-ascii?Q?7TO3VF5YvH0HMig2Ch2cFwBo8gRkn1vn0cmde4aXtdg8J5ZLYJSSM0PaEu7j?=
 =?us-ascii?Q?Gq9cIN7bbPF6bFJdAflAoQmP/Wgde5mMKL0+GoGziQFlGEUvexCw8ZNn478w?=
 =?us-ascii?Q?+KIAELBBh0s+BDAoow4oKR3hYJvr0kZtUQP/auRS4V/s10SuXTpovp9dPgbm?=
 =?us-ascii?Q?z0n8EIFQ+qmjDjFhlsEel22s0rgE3z1yZlSe/5753kA9GEdCj36DzsertI/p?=
 =?us-ascii?Q?j10uxDG1NBVwnilD5OvQcdc3YwOrf8LlaFsiHPpO/K92VOxNaxvtCk83vZH5?=
 =?us-ascii?Q?6ZtJSaj3M6lQ+aYy6BWjfpqY+/mb1+xOxs5Zd5VjyzMJy535IQ4Iym4Lq0s0?=
 =?us-ascii?Q?OTAVp9ikxNKr4b337gYIDYy/EAHRnYszuRO3jjuloaXArwYxU8mdoo3zn7NG?=
 =?us-ascii?Q?D8UT8xjotd3ogoFYA5tI5KMUUrlcYdY69VefCu4rmystdtjVFBHQggCptBlD?=
 =?us-ascii?Q?RoQjZ5vC1y7IgqrOJeU6VYMnmIYqKaF7Mn34CXxOqPgjLYfLnE3NVp+pQkaL?=
 =?us-ascii?Q?XB+N8LVsJ+uVPA7TE1kCKlxyU44oXH9Gxts15njXr3NhFLGtR8lQReFDIG6J?=
 =?us-ascii?Q?QOearrchrVC1rT72DmyxZ2MY0vDLBNslJZoQu3iZRo0OWSoXY5cZHbYvEbzU?=
 =?us-ascii?Q?sFdhlzxux7pN5o/G7wKMEwNOGNOx9kS2WyqAN2wf6dNAoBRlw+C7Mtrb1tXn?=
 =?us-ascii?Q?O6/jfnA1K9uRkeW14B4QxlJrsxwI5kpBXruNZF3mhokKqdLf125knSYVVX7V?=
 =?us-ascii?Q?YpMi/KCUQGi7gPUi0l3ctwjraoR4WFzzKRSOtbcuqthcadk4lDI7F5ANnnYW?=
 =?us-ascii?Q?wzoC4ImnMnqLLVJR3qYn+XFcvObNn9cmSH9Ev3qlirvI19NaojmRLTtCxRnA?=
 =?us-ascii?Q?0Jk1HhJ3Uk7WFcXYIeqS8BZViDrkrr6Rn6FO6qEshrjUyA9g+Bx/63O1xpS+?=
 =?us-ascii?Q?J80CTeRwhhor0PK8K+07Rbl7oqbzeiO1zMQ0Hh6OlpNM1OIUxExZJkYvOPpg?=
 =?us-ascii?Q?c3b+V3j6CZBTDIHjfor6uoWdVs4jtT8QkZRKLLq2CR55WNuD6LdEOCz5Xweq?=
 =?us-ascii?Q?/d5Y61gG52WkeSXa1T/wNZ2UY/xun+avAgjG9dcR/OZzx3vF10bFVBJongJi?=
 =?us-ascii?Q?rE0iC9j3ZqVBDMqsDMDcB2/2ef+SRTDD77PO+FuYh1m775ttjTzxUcbe8zAc?=
 =?us-ascii?Q?KJib25JTqFpgMxbXHoUY34UGCJiytziaZQKSDTiyl8BNt43Hm48I88k+w4yr?=
 =?us-ascii?Q?E5s7lzhvBA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1d6ba9f-7be8-4062-a683-08da185f9307
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 06:26:39.6401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VAkY5bWSIEhwUw+EUEnQbKjMqV7y7qwSgtDyZ79VrGQXCXrb0ov+RMe8DqfiWVU9Zj3zHhZp104JYlxW8OAdEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8218

On 07.04.2022 03:01, Andrew Cooper wrote:
> c/s 1a914256dca5 increased the AMD max leaf from 0x8000001c to 0x80000021=
, but
> did not adjust anything in the calculate_*_policy() chain.  As a result, =
on
> hardware supporting these leaves, we read the real hardware values into t=
he
> raw policy, then copy into host, and all the way into the PV/HVM default
> policies.
>=20
> All 4 of these leaves have enable bits (first two by TopoExt, next by SEV=
,
> next by PQOS), so any software following the rules is fine and will leave=
 them
> alone.  However, leaf 0x8000001d takes a subleaf input and at least two
> userspace utilities have been observed to loop indefinitely under Xen (cl=
early
> waiting for eax to report "no more cache levels").
>=20
> Such userspace is buggy, but Xen's behaviour isn't great either.
>=20
> In the short term, clobber all information in these leaves.  This is a gi=
ant
> bodge, but there are complexities with implementing all of these leaves
> properly.
>=20
> Fixes: 1a914256dca5 ("x86/cpuid: support LFENCE always serialising CPUID =
bit")
> Link: https://github.com/QubesOS/qubes-issues/issues/7392
> Reported-by: fosslinux <fosslinux@aussies.space>
> Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab=
.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> It turns out that Intel leaf 4 and AMD leaf 0x8000001d are *almost* ident=
ical.
> They differ by the "complex" bit in edx, and the $X-per-cache fields in t=
he
> top of eax (Intel is threads-per-cache, AMD is cores-per-cache and lacks =
the
> cores-per-package field).
>=20
> As neither vendor implement each others version, I'm incredibly tempted t=
o
> reuse p->cache for both, rather than doubling the storage space.  Reading=
 the
> data out is easy to key on p->extd.topoext.  Writing the data can be done
> without any further complexity if we simply trust the sending side to hav=
e its
> indices the proper way around.  Particularly, this avoids needing to ensu=
re
> that p->extd.topoext is out of order and at the head of the stream.  Thou=
ghts?

Sounds quite reasonable to me. I guess the main risk is for new things
to appear on either vendor's side in a way breaking the overlaying
approach. But I guess that's not a significant risk.

As to ordering dependencies: Are there any in reality? Neither vendor
implements the other vendor's leaf, so there's only going to be one in
the stream anyway, and which one it is can be disambiguated by having
seen leaf 0 alone.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:45:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:45:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300432.512439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLtn-0000KP-6K; Thu, 07 Apr 2022 06:45:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300432.512439; Thu, 07 Apr 2022 06:45:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncLtn-0000KI-3D; Thu, 07 Apr 2022 06:45:43 +0000
Received: by outflank-mailman (input) for mailman id 300432;
 Thu, 07 Apr 2022 06:45:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncLtm-0000KC-0c
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:45:42 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 56ef5c30-b63e-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 08:45:40 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0370C210E5;
 Thu,  7 Apr 2022 06:45:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A6C8813A66;
 Thu,  7 Apr 2022 06:45:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4w0xJ5OITmLMXgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 06:45:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56ef5c30-b63e-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649313940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=fZTbClyKGGoIN+6/3vy0k/EUsRrzSi6W8nYjD4NuceI=;
	b=YVaO6inOwtu1oLDMIA5EdgLUD91wuRBsRcz+R+YoUujzH0yIHIRwuxCBIeevW4m3r/vpHU
	lU9PfyVayWI26CuB8JyQ7ypg1Czx/GSZQ0vZ0xS0NsFT+T/DZoTcGYK+SbV5l+2rWeuF0u
	EB9DkXruvD4wvnMze6dwchlNmfiT+xY=
Message-ID: <f9e6e597-f9e7-50a7-1abf-aaa20d07c10f@suse.com>
Date: Thu, 7 Apr 2022 08:45:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v5 6/6] xen/cpupool: Allow cpupool0 to use different
 scheduler
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-7-luca.fancellu@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220405085741.18336-7-luca.fancellu@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------TIIQGH3C2eDhPCh50lo72Iqt"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------TIIQGH3C2eDhPCh50lo72Iqt
Content-Type: multipart/mixed; boundary="------------jNLT8zg4w90D8SE50DZu6oG0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
Message-ID: <f9e6e597-f9e7-50a7-1abf-aaa20d07c10f@suse.com>
Subject: Re: [PATCH v5 6/6] xen/cpupool: Allow cpupool0 to use different
 scheduler
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-7-luca.fancellu@arm.com>
In-Reply-To: <20220405085741.18336-7-luca.fancellu@arm.com>

--------------jNLT8zg4w90D8SE50DZu6oG0
Content-Type: multipart/mixed; boundary="------------as1trS9w68ATLmwdzrcFmW0j"

--------------as1trS9w68ATLmwdzrcFmW0j
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMDQuMjIgMTA6NTcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IEN1cnJlbnRseSBj
cHVwb29sMCBjYW4gdXNlIG9ubHkgdGhlIGRlZmF1bHQgc2NoZWR1bGVyLCBhbmQNCj4gY3B1
cG9vbF9jcmVhdGUgaGFzIGFuIGhhcmRjb2RlZCBiZWhhdmlvciB3aGVuIGNyZWF0aW5nIHRo
ZSBwb29sIDANCj4gdGhhdCBkb2Vzbid0IGFsbG9jYXRlIG5ldyBtZW1vcnkgZm9yIHRoZSBz
Y2hlZHVsZXIsIGJ1dCB1c2VzIHRoZQ0KPiBkZWZhdWx0IHNjaGVkdWxlciBzdHJ1Y3R1cmUg
aW4gbWVtb3J5Lg0KPiANCj4gV2l0aCB0aGlzIGNvbW1pdCBpdCBpcyBwb3NzaWJsZSB0byBh
bGxvY2F0ZSBhIGRpZmZlcmVudCBzY2hlZHVsZXIgZm9yDQo+IHRoZSBjcHVwb29sMCB3aGVu
IHVzaW5nIHRoZSBib290IHRpbWUgY3B1cG9vbC4NCj4gVG8gYWNoaWV2ZSB0aGlzIHRoZSBo
YXJkY29kZWQgYmVoYXZpb3IgaW4gY3B1cG9vbF9jcmVhdGUgaXMgcmVtb3ZlZA0KPiBhbmQg
dGhlIGNwdXBvb2wwIGNyZWF0aW9uIGlzIG1vdmVkLg0KPiANCj4gV2hlbiBjb21waWxpbmcg
d2l0aG91dCBib290IHRpbWUgY3B1cG9vbHMgZW5hYmxlZCwgdGhlIGN1cnJlbnQNCj4gYmVo
YXZpb3IgaXMgbWFpbnRhaW5lZCAoZXhjZXB0IHRoYXQgY3B1cG9vbDAgc2NoZWR1bGVyIG1l
bW9yeSB3aWxsIGJlDQo+IGFsbG9jYXRlZCkuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBMdWNh
IEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K
--------------as1trS9w68ATLmwdzrcFmW0j
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------as1trS9w68ATLmwdzrcFmW0j--

--------------jNLT8zg4w90D8SE50DZu6oG0--

--------------TIIQGH3C2eDhPCh50lo72Iqt
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJOiJMFAwAAAAAACgkQsN6d1ii/Ey+f
SQf8Dq+erOZ7dBzwOVAlA2+PvcKdyVwUgj8JUQv7pMAzWn4+o9psk9F4dP4n2It8RfxKFiQk6uhW
qYWIdveMYYu0+a1p4xv9N9FBCsioOnB9bLy5hNkf454XigHWvQ/SaQtGNBjx73SB1p8WoPi8Zvdd
jrKLxCUye9pgqrbq5fjNXqZwpELjS6a0VLacbFqjmkmGMWCJ+TDMMqdTwWKntwjGSH165JvoznEo
RwHfLTqAWG7CXkI0WIEIEcsCc1/yrsHyW2BEKeS7i9WjfcmkGW0vJLEh8F8mSdKjIGYC953xVs1u
wE+r7/E2iKHWyWD2TVZK4WxIYTIvUSML5IGsEtvbig==
=rpyy
-----END PGP SIGNATURE-----

--------------TIIQGH3C2eDhPCh50lo72Iqt--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 06:57:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 06:57:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300436.512449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncM56-00020T-7h; Thu, 07 Apr 2022 06:57:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300436.512449; Thu, 07 Apr 2022 06:57:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncM56-00020M-4c; Thu, 07 Apr 2022 06:57:24 +0000
Received: by outflank-mailman (input) for mailman id 300436;
 Thu, 07 Apr 2022 06:57:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncM54-00020G-M7
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 06:57:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f89c0649-b63f-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 08:57:21 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-LQhGggxnNOqI3C9tLaxHOQ-1; Thu, 07 Apr 2022 08:57:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM8PR04MB7730.eurprd04.prod.outlook.com (2603:10a6:20b:242::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 06:57:17 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 06:57:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f89c0649-b63f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649314641;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=f87FcFknBJQAXzdfPptgGAbYYSNoePKfT9sVQ82H0Mw=;
	b=K8Ru7GU/EBd/mfgpatuwNQKjRwLF8HH9ib9R7r8pNziJm6fNlVN5lQIphtlgvYSZ94H+CQ
	qrbwLft3gc8DNVYuZIbZ4s7CvTjNLrP/Bylj0Q05oeUGe6zjZcJ7L1DnfayljqGQxE0V7K
	Cg8R6mRgjU4Nxa1ATki/p5twjMyatBg=
X-MC-Unique: LQhGggxnNOqI3C9tLaxHOQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N/b5EJvtR9/5ZfoJQr4NFYqAT+1khbHosZRUpC70XFm9JHSnnNqS27USqCmzA2ns0+z8PKXCVpNX4QAUYigRADfhxXV82M+5JPfk5n6Qs2iwTomHDq6kOEr8FVJysxcohMjIR/El3cYFMR6CTj9vgn6TL2EmkVD/esucLXYQAwlYGibBZblU0yfEA9FL+tj/+MFtWbB4nZeLvHVdwWfFgc8g22RJ8Sb8q/FVsjRpkGepC65Yb79r3WNxADDTQq6gY195areeBR3UdX/yE8fY8FL+xlQwtvRaCZfUD6pq8OmhE1Sz0RDvfDnuLY3mb2j18CpfCXotyYX5WqHByIpH1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f87FcFknBJQAXzdfPptgGAbYYSNoePKfT9sVQ82H0Mw=;
 b=nat5BNGf8xvV0YQEqk3SpnCE49gsCfYgrELquUmBpCR8xJugq5UcGdZJLB8z+Eas7pnyg01K3df2nLu2Z/HxKRJRLFy5tgxr31Z/otTGeHTnUNQA5MKnUfauZ5cDXUaX9ZcyhLuxtTGo9/tJS+2Wl7HiwNIrQg21tCLU2n8DmrUoHNg+BoS9u9U7ayxt/fGHNTlfSuhY5C43Hn41vO/SjFfH+tHceQQ6mqSGZwERRjploAClLcOEZDUE4kp9A7/Zknfrr8A9ceNVk4KFiNgp+jIgfcE5JIzMMqD7Tnw2xeQIDJkp1VgbvB/7sBIVvqpsg4cXeqxBlZS/vnDyU3HXKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a3881491-93ce-ff41-fca3-31d4e38c3cd5@suse.com>
Date: Thu, 7 Apr 2022 08:57:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Ping: [PATCH v2 0/2] x86: correct fencing around CLFLUSH (+some
 tidying)
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <265e87fa-0f05-7953-1bce-34999119d3c4@suse.com>
In-Reply-To: <265e87fa-0f05-7953-1bce-34999119d3c4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0048.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d978f38b-9171-4dff-7a9a-08da1863da81
X-MS-TrafficTypeDiagnostic: AM8PR04MB7730:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7730F90286EA64E8208DECC9B3E69@AM8PR04MB7730.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cJU9PHlMP26i+SiQkRSRJxucmKRjoShZT6yHliEmXnrh5FXYzclWQPMnP6Jadk+IbQXr1jYY2pHcPHPWsCxS7hKVU23koqqxN+YAGPF25kyE0iUtUUH3hhYrgNJ5aU7pldQkW7995g73RXyZwyJEbb933a3We2FmuF4vffCRy0Is9H9+9cbwrQ2/45cLcdYsmELJo5UnvEBwVpBNPIDizWqY62AvXcGgXWsJfg0+wdbZjESD/K48H8X1IdFf3SN9eVSpUawLM2XXbzbeIpVKBiOq7tQoUkBU1UYN8y/endqXbAq5Mn7WfmD1DBTGS98HRDBb/TxF49jqS1QglgQBu4fTSlrQ7vnIR8m5f2AXziXIZtnel7ZCofMgANHA+XZ+CxMvpqEj+h6+rE5hmX7SKtQYFDlhsQQAUQ8n5uxeL4iOehMQY3wudn8dPGMbwUqzFPgijuOAcYnQB/3LXgFg4P9I6InPTfTmYcaX+YYMATeu8heFN4R+FA+B7s5EtjMZ1ja04I+VNeg9xi1fdiOfjdfue43fe7oyeHQUaCM0qHJFebTWrpN1Zk5WTSnZwm3klRAZrDxHlm9Mw5cl7tTsnc2vjRNmCuBsKq/KEmfzEyhiHfyHky5vR8vFoTGrqV9sa4MVobknjrswcL7gbRel3kELKqwNg+MWLeC9N3TLEluCwXcM+iuw6LScy7BmxKDRaCqMYACjBRp5j+ItITqWqpzA4G2j0VSHQ/UQGzu/EJo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4744005)(53546011)(6486002)(8936002)(86362001)(316002)(508600001)(54906003)(6506007)(31686004)(36756003)(2906002)(110136005)(6512007)(66946007)(26005)(66556008)(66476007)(186003)(8676002)(4326008)(5660300002)(2616005)(38100700002)(31696002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mm9HU09OREl6WkduYjF4TlVxOXEwa1lnVWhOOTVJNS9SRkwvYzY2a3NnQnRX?=
 =?utf-8?B?Vk1jZmFyYlpNQzVyU29wcnRNc0pDUmdueWJ6bWhMUGc4TkVpZzUvSk80NmpP?=
 =?utf-8?B?RXUwNEpWSnhUMlZrblU1R09zQjM0MG45MUFibUx6d3NqaHdKbnVDalBKcDhE?=
 =?utf-8?B?OWVxYUFweEF3czVjN3gzQjNvdkg5a2FtL3Vma1dBclV4cDZtc2U4L1hFT3Fy?=
 =?utf-8?B?T29RZUlacmVLdGRrVmRVU3V5V3VpS3ZOOE9mMmZ5WGVlTE14Yy90L251OTRJ?=
 =?utf-8?B?bklNRm02YWpHM2VXbGR3YnNxOXFBdGxOOVhXQjlObnRiMXlzMXczS2dGNW9j?=
 =?utf-8?B?YVllaFo5UlM5Zzh2eWUwY1U3cks4RFZzRWZqaFFWblFvd29QVDlYTWJITXUz?=
 =?utf-8?B?Y09DZ244Lyt6elJaWDljaEJIKzVxR0JFbU52dHo3L0JFQ0VWMkRIM0tOTnlB?=
 =?utf-8?B?ODdRZjcwME9ESTlrZU1RSGFBdlFHanV3OFlubGtGMlNNaVowN2xRWHpocXBF?=
 =?utf-8?B?L3U0eHBjQkhQVWpLWmZTaFdLemdNbDNMSkNGY05YQ3VWSytmbkR6WFM5WUN0?=
 =?utf-8?B?TWZHbG9EQ3dUT0ZxMXYvQ0UrczlidG1FWFJobWxlZE9aOUVDUVFmQ2p0U21h?=
 =?utf-8?B?L1UrM0hhWEdmdVhaQVNhdlRMeDd5bjdzWmZzcFBUZFRSQmNsQmRGbHB0L25N?=
 =?utf-8?B?WEdIM2JJUnI5UTlPRnYzS3I5bVBvNmlYaXVIbWdKSFNwL0tXay9PUDV3MDl3?=
 =?utf-8?B?SGxxR1FKL2hNUXJ2ZGpYMkZrNTlhbnpZSGx5eTM2bFVXWkhQQWZybk9zVlNO?=
 =?utf-8?B?MVhqbExKMlN3RkphVHU5U3hFR2JyS2ZKNkJycFJ3M1NMUzN4dnREb0YxOHBL?=
 =?utf-8?B?bmh1SWlrZHJVRS9JVFNvSkdUaXdDeEVZanNqYXZMV2JqdUw1Vmx5OHlWUWFV?=
 =?utf-8?B?WVFqMTNqSFUyTHBRcU5GMG9XOW5kRHdEcTZrM1k2TmFIS2k2N0Frd2pNV09J?=
 =?utf-8?B?THBydTJveXVSVHNRVHQrWUxuUGlCM1lxV25QRFBFTVYrREIwN3JzbmxsbFBW?=
 =?utf-8?B?dDg0b1NlNWRuQTBDS0pEN0hYQldsa0grMW5ubUs4NC9kOGZHY0lpZXplSTNU?=
 =?utf-8?B?VHZ4QStocUJ2WU0yNjlrZEdsOFFtejlETDdPYm1SS1ZhU2dMY3JYWGJKUXZN?=
 =?utf-8?B?dllsb3Q4TnN3dGlxWi9wVjlrNDJUdUxVWUMzOTk1L1hMYW9BUDFJeG5SM1NZ?=
 =?utf-8?B?TllmV2o1dXVDbkgvZHVjdzMrSzhldVp5dE5kK1ltZy9VckI1aFZsbTlhUkds?=
 =?utf-8?B?ZENHRTJCZnpkblc3S3JTOElPVVBYSVJrcFVPcmJQdENleGJtZW5BR01aU2pZ?=
 =?utf-8?B?eUo1TktVSGE2c3YyRGkvUGF4UkpzUUtVSlNOL2Qwa2dGM1NDSCswOHVmcUpo?=
 =?utf-8?B?N01PWE5BRjdrSmVERUhibjBpVVJTcmNHWW9abkRtdkhOdXlhQVlVb2VzbExw?=
 =?utf-8?B?eUNqVW9WbFdNaG9OUk5DRERDc1VPV1B6KzlXTmVVQ2dicUp3RWFjVXlOQ1lo?=
 =?utf-8?B?K0JoQWhsQ3N3Z1QzZFhvYWpwUDYrems5SGM2SDlrdWVtcW5uLyswZnNZcHlY?=
 =?utf-8?B?Wkp2dGpCMUo4Y2pjRmhkT0UxdENNS090blFFSlVjWHlZMjFZR1JmMDdqWGFC?=
 =?utf-8?B?Zm8rSzh2eGFrM0xrRUUzank4MUYyMVlvQTZRdFNLYzU4WkJPbEZaSU5pUW5F?=
 =?utf-8?B?djQ3SDZHVlJ4Y0lRSDE2NytGQU9lZExwMXZta05UbGIvUzY0WmJoSzF5Z3FR?=
 =?utf-8?B?d3hnWEtackI0VHZybmxWSWlaaUtQcGRnc25uYm8zYURKMFJxekt2VVVLdkli?=
 =?utf-8?B?aFFYeStCQnkrakpkR2FKY09kSkJybGo1c1JwRXYxMkxsQ1VpRDlmam9RcjFs?=
 =?utf-8?B?TUw3YXcwbUlpMmNUdlp4NGpuWmFZLzFJNUFwVDNhdzB3Mm0xeUZkaVdidVY3?=
 =?utf-8?B?ZmZabDQ0eTNrcDRENnUxbzMwaTZDb3hGTXUxRVpsbXlaeXV2YlhWVi9GN2FN?=
 =?utf-8?B?NnVRem1ONmpqZ05NRm1qbVlFNVJoc0JmUlV0TFdNemxPYkt3ajY0RHFhTXJp?=
 =?utf-8?B?OGNZTFJpakhIQ3R3ZEVzYUNGak5aaHBtVTN2MzZOazBkU3BYeWNweFBxc0FP?=
 =?utf-8?B?d284L3dOQXU0K3Y5bXJvMGVOaXR2c2E5VFVFSDI4WmlhcG9MYlh5YjNwMXFL?=
 =?utf-8?B?OWY2blFsWFhmKzg1Ry9YbG81bjdkVWNaeHBSRzdIR3ptNm90NW5TcHVxdUdi?=
 =?utf-8?B?UWx3OC9OdThLdkpER3FUYjBRYitBVlJCR0MxeUNnVWR1djNQQ05nQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d978f38b-9171-4dff-7a9a-08da1863da81
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 06:57:17.6530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F0b7IpvJlL/nbswtW6qknGUp8DitnxBHpOBtWKBAM70nYkt5MvMF/FinG7duVeFgNM78vYjhiti6bnP/EPFSLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7730

On 24.02.2022 14:23, Jan Beulich wrote:
> 1: AMD: collect checking for bugs in a single function
> 2: correct fencing around CLFLUSH

It would be nice to get this bug fix in (and perhaps even backported), no
matter that we haven't had reports of the wrong behavior actually causing
any noticeable problems.

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 07:02:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 07:02:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300441.512461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncM9I-0003iP-Tm; Thu, 07 Apr 2022 07:01:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300441.512461; Thu, 07 Apr 2022 07:01:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncM9I-0003iI-Pz; Thu, 07 Apr 2022 07:01:44 +0000
Received: by outflank-mailman (input) for mailman id 300441;
 Thu, 07 Apr 2022 07:01:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bTf3=UR=gmail.com=konishi.ryusuke@srs-se1.protection.inumbo.net>)
 id 1ncM9H-0003iC-FB
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 07:01:43 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9366c9a0-b640-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 09:01:40 +0200 (CEST)
Received: by mail-lj1-x236.google.com with SMTP id o16so356612ljp.3
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 00:01:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9366c9a0-b640-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=nnTWv4OeMbCbgBhQRwVeVyiJPEpPmmOhrjkiBta75u8=;
        b=f4BUQ/1HWS/MrEkc6pch5l/QafzAtfm97Caw+bZOkWrcxLpsn9xaxZooLV6i2RzANR
         aukVIPC6JpUW5PUsAj+ocL0cGKTmvkPpZAvVLFoYxCD2uM+NTvMy2LTrzQOXL3KQA6HE
         PdNH8jYyFlnQbQz73vmgEkHi7Ynvt5a2TzW7HjF61wfm414wZJyNU1fVqdZTyC4JH4mJ
         67tsn9Vdz+AGb5LgCQivfcoHOsC1rX1jzd+zIAMWqgGu2RsW/a8QfVshE55BQGKDQWaK
         XM0tHzEVJS6wXXhLWI9VgF2h7GbogfN9olWJu7Tr2X9PVTB5138y8sqkKaU9xvop7W6H
         j2FQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=nnTWv4OeMbCbgBhQRwVeVyiJPEpPmmOhrjkiBta75u8=;
        b=imMnYYwR7GSym5uHBX5O6AJk7dpUCS5qGn6dJBwwHuMANbuPAZKhBNIUkj2eylr+MI
         oSPno/sHe/KXQPO2+z+ud7mSPeXfx7Juy03e1I3ZRYggTJ/9prL7KMjR4R9SxUa6bFH5
         XnXXai3R0k1yBn+z/7J8VOU98KEtmlStUlqYKI2uGX8ai2TCEpcOTBq/MGk1Cvop1U+l
         cfW0A6Rn/CmLVQdYRqhUIzLOcl6diQJl2o91Tt4RRb2Ee7O4EpEAlLLaCDnhhcgUrp+C
         iTLe7rE2Am57bYK/5Ju/QBy1LaP+tjRRb8quH8fgECRIPEX2hb5syn3rDmDvyPyNnIEi
         30gg==
X-Gm-Message-State: AOAM532IcnQV4M6CHwCsQ6BBqGjPE8RAM0rF+kFYPrHr+iV260q7OruP
	A+1YShmPQIdvfVmdWYUqQuRhHIH5GFm2106Ftro=
X-Google-Smtp-Source: ABdhPJylJdKU+UHL+6CAx/7DbvUUCtRhTTIDFcHA+6Ywi+0Y7yghrQ45JGxi1UefcHH90OcbvN8Oln73zfVQkid2TQw=
X-Received: by 2002:a2e:b008:0:b0:249:83ad:ab65 with SMTP id
 y8-20020a2eb008000000b0024983adab65mr7573130ljk.350.1649314900211; Thu, 07
 Apr 2022 00:01:40 -0700 (PDT)
MIME-Version: 1.0
References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-27-hch@lst.de>
In-Reply-To: <20220406060516.409838-27-hch@lst.de>
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date: Thu, 7 Apr 2022 16:01:27 +0900
Message-ID: <CAKFNMo=gcJKF60Py7FB57be1xo3aKCLTYW2TUvxw2k51DjUmNw@mail.gmail.com>
Subject: Re: [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, device-mapper development <dm-devel@redhat.com>, linux-xfs@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, 
	linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, 
	ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, 
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, 
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, 
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, 
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, 
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, 
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, 
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, 
	linux-nilfs <linux-nilfs@vger.kernel.org>, ntfs3@lists.linux.dev, 
	ocfs2-devel@oss.oracle.com, Linux MM <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 6, 2022 at 11:05 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint.  Fully split the limits and helper
> infrastructure to make the separation more clear.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/blk-core.c                    |  2 +-
>  block/blk-lib.c                     | 64 ++++++++++++++++++++---------
>  block/blk-mq-debugfs.c              |  1 -
>  block/blk-settings.c                | 16 +++++++-
>  block/fops.c                        |  2 +-
>  block/ioctl.c                       | 43 +++++++++++++++----
>  drivers/block/drbd/drbd_receiver.c  |  5 ++-
>  drivers/block/rnbd/rnbd-clt.c       |  4 +-
>  drivers/block/rnbd/rnbd-srv-dev.h   |  2 +-
>  drivers/block/xen-blkback/blkback.c | 15 +++----
>  drivers/block/xen-blkback/xenbus.c  |  5 +--
>  drivers/block/xen-blkfront.c        |  5 ++-
>  drivers/md/bcache/alloc.c           |  2 +-
>  drivers/md/dm-table.c               |  8 ++--
>  drivers/md/dm-thin.c                |  4 +-
>  drivers/md/md.c                     |  2 +-
>  drivers/md/raid5-cache.c            |  6 +--
>  drivers/mmc/core/queue.c            |  2 +-
>  drivers/nvme/target/io-cmd-bdev.c   |  2 +-
>  drivers/target/target_core_file.c   |  2 +-
>  drivers/target/target_core_iblock.c |  2 +-
>  fs/btrfs/extent-tree.c              |  4 +-
>  fs/ext4/mballoc.c                   |  2 +-
>  fs/f2fs/file.c                      | 16 ++++----
>  fs/f2fs/segment.c                   |  2 +-
>  fs/jbd2/journal.c                   |  2 +-
>  fs/nilfs2/sufile.c                  |  4 +-
>  fs/nilfs2/the_nilfs.c               |  4 +-
>  fs/ntfs3/super.c                    |  2 +-
>  fs/xfs/xfs_discard.c                |  2 +-
>  fs/xfs/xfs_log_cil.c                |  2 +-
>  include/linux/blkdev.h              | 27 +++++++-----
>  mm/swapfile.c                       |  6 +--
>  33 files changed, 168 insertions(+), 99 deletions(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index b5c3a8049134c..ee18b6a699bdf 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -824,7 +824,7 @@ void submit_bio_noacct(struct bio *bio)
>                         goto not_supported;
>                 break;
>         case REQ_OP_SECURE_ERASE:
> -               if (!blk_queue_secure_erase(q))
> +               if (!bdev_max_secure_erase_sectors(bdev))
>                         goto not_supported;
>                 break;
>         case REQ_OP_ZONE_APPEND:
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 43aa4d7fe859f..09b7e1200c0f4 100644
> --- a/block/blk-lib.c
> +++ b/block/blk-lib.c
> @@ -36,26 +36,15 @@ static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
>  }
>
>  int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -               sector_t nr_sects, gfp_t gfp_mask, int flags,
> -               struct bio **biop)
> +               sector_t nr_sects, gfp_t gfp_mask, struct bio **biop)
>  {
> -       struct request_queue *q = bdev_get_queue(bdev);
>         struct bio *bio = *biop;
> -       unsigned int op;
>         sector_t bs_mask;
>
>         if (bdev_read_only(bdev))
>                 return -EPERM;
> -
> -       if (flags & BLKDEV_DISCARD_SECURE) {
> -               if (!blk_queue_secure_erase(q))
> -                       return -EOPNOTSUPP;
> -               op = REQ_OP_SECURE_ERASE;
> -       } else {
> -               if (!bdev_max_discard_sectors(bdev))
> -                       return -EOPNOTSUPP;
> -               op = REQ_OP_DISCARD;
> -       }
> +       if (!bdev_max_discard_sectors(bdev))
> +               return -EOPNOTSUPP;
>
>         /* In case the discard granularity isn't set by buggy device driver */
>         if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
> @@ -77,7 +66,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
>                 sector_t req_sects =
>                         min(nr_sects, bio_discard_limit(bdev, sector));
>
> -               bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
> +               bio = blk_next_bio(bio, bdev, 0, REQ_OP_DISCARD, gfp_mask);
>                 bio->bi_iter.bi_sector = sector;
>                 bio->bi_iter.bi_size = req_sects << 9;
>                 sector += req_sects;
> @@ -103,21 +92,19 @@ EXPORT_SYMBOL(__blkdev_issue_discard);
>   * @sector:    start sector
>   * @nr_sects:  number of sectors to discard
>   * @gfp_mask:  memory allocation flags (for bio_alloc)
> - * @flags:     BLKDEV_DISCARD_* flags to control behaviour
>   *
>   * Description:
>   *    Issue a discard request for the sectors in question.
>   */
>  int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -               sector_t nr_sects, gfp_t gfp_mask, unsigned long flags)
> +               sector_t nr_sects, gfp_t gfp_mask)
>  {
>         struct bio *bio = NULL;
>         struct blk_plug plug;
>         int ret;
>
>         blk_start_plug(&plug);
> -       ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, flags,
> -                       &bio);
> +       ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, &bio);
>         if (!ret && bio) {
>                 ret = submit_bio_wait(bio);
>                 if (ret == -EOPNOTSUPP)
> @@ -314,3 +301,42 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
>         return ret;
>  }
>  EXPORT_SYMBOL(blkdev_issue_zeroout);
> +
> +int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
> +               sector_t nr_sects, gfp_t gfp)
> +{
> +       sector_t bs_mask = (bdev_logical_block_size(bdev) >> 9) - 1;
> +       unsigned int max_sectors = bdev_max_secure_erase_sectors(bdev);
> +       struct bio *bio = NULL;
> +       struct blk_plug plug;
> +       int ret = 0;
> +
> +       if (max_sectors == 0)
> +               return -EOPNOTSUPP;
> +       if ((sector | nr_sects) & bs_mask)
> +               return -EINVAL;
> +       if (bdev_read_only(bdev))
> +               return -EPERM;
> +
> +       blk_start_plug(&plug);
> +       for (;;) {
> +               unsigned int len = min_t(sector_t, nr_sects, max_sectors);
> +
> +               bio = blk_next_bio(bio, bdev, 0, REQ_OP_SECURE_ERASE, gfp);
> +               bio->bi_iter.bi_sector = sector;
> +               bio->bi_iter.bi_size = len;
> +
> +               sector += len << SECTOR_SHIFT;
> +               nr_sects -= len << SECTOR_SHIFT;
> +               if (!nr_sects) {
> +                       ret = submit_bio_wait(bio);
> +                       bio_put(bio);
> +                       break;
> +               }
> +               cond_resched();
> +       }
> +       blk_finish_plug(&plug);
> +
> +       return ret;
> +}
> +EXPORT_SYMBOL(blkdev_issue_secure_erase);
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index fd111c5001256..7e4136a60e1cc 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -115,7 +115,6 @@ static const char *const blk_queue_flag_name[] = {
>         QUEUE_FLAG_NAME(IO_STAT),
>         QUEUE_FLAG_NAME(NOXMERGES),
>         QUEUE_FLAG_NAME(ADD_RANDOM),
> -       QUEUE_FLAG_NAME(SECERASE),
>         QUEUE_FLAG_NAME(SAME_FORCE),
>         QUEUE_FLAG_NAME(DEAD),
>         QUEUE_FLAG_NAME(INIT_DONE),
> diff --git a/block/blk-settings.c b/block/blk-settings.c
> index fd83d674afd0a..6ccceb421ed2f 100644
> --- a/block/blk-settings.c
> +++ b/block/blk-settings.c
> @@ -46,6 +46,7 @@ void blk_set_default_limits(struct queue_limits *lim)
>         lim->max_zone_append_sectors = 0;
>         lim->max_discard_sectors = 0;
>         lim->max_hw_discard_sectors = 0;
> +       lim->max_secure_erase_sectors = 0;
>         lim->discard_granularity = 0;
>         lim->discard_alignment = 0;
>         lim->discard_misaligned = 0;
> @@ -176,6 +177,18 @@ void blk_queue_max_discard_sectors(struct request_queue *q,
>  }
>  EXPORT_SYMBOL(blk_queue_max_discard_sectors);
>
> +/**
> + * blk_queue_max_secure_erase_sectors - set max sectors for a secure erase
> + * @q:  the request queue for the device
> + * @max_sectors: maximum number of sectors to secure_erase
> + **/
> +void blk_queue_max_secure_erase_sectors(struct request_queue *q,
> +               unsigned int max_sectors)
> +{
> +       q->limits.max_secure_erase_sectors = max_sectors;
> +}
> +EXPORT_SYMBOL(blk_queue_max_secure_erase_sectors);
> +
>  /**
>   * blk_queue_max_write_zeroes_sectors - set max sectors for a single
>   *                                      write zeroes
> @@ -661,7 +674,8 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
>                 t->discard_alignment = lcm_not_zero(t->discard_alignment, alignment) %
>                         t->discard_granularity;
>         }
> -
> +       t->max_secure_erase_sectors = min_not_zero(t->max_secure_erase_sectors,
> +                                                  b->max_secure_erase_sectors);
>         t->zone_write_granularity = max(t->zone_write_granularity,
>                                         b->zone_write_granularity);
>         t->zoned = max(t->zoned, b->zoned);
> diff --git a/block/fops.c b/block/fops.c
> index 9f2ecec406b04..c0ca3254d38cf 100644
> --- a/block/fops.c
> +++ b/block/fops.c
> @@ -672,7 +672,7 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
>                 break;
>         case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE:
>                 error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT,
> -                                            len >> SECTOR_SHIFT, GFP_KERNEL, 0);
> +                                            len >> SECTOR_SHIFT, GFP_KERNEL);
>                 break;
>         default:
>                 error = -EOPNOTSUPP;
> diff --git a/block/ioctl.c b/block/ioctl.c
> index c2cd3ba5290ce..5b5027fa78f7e 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -83,7 +83,7 @@ static int compat_blkpg_ioctl(struct block_device *bdev,
>  #endif
>
>  static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
> -               unsigned long arg, unsigned long flags)
> +               unsigned long arg)
>  {
>         uint64_t range[2];
>         uint64_t start, len;
> @@ -114,15 +114,43 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
>         err = truncate_bdev_range(bdev, mode, start, start + len - 1);
>         if (err)
>                 goto fail;
> -
> -       err = blkdev_issue_discard(bdev, start >> 9, len >> 9,
> -                                  GFP_KERNEL, flags);
> -
> +       err = blkdev_issue_discard(bdev, start >> 9, len >> 9, GFP_KERNEL);
>  fail:
>         filemap_invalidate_unlock(inode->i_mapping);
>         return err;
>  }
>
> +static int blk_ioctl_secure_erase(struct block_device *bdev, fmode_t mode,
> +               void __user *argp)
> +{
> +       uint64_t start, len;
> +       uint64_t range[2];
> +       int err;
> +
> +       if (!(mode & FMODE_WRITE))
> +               return -EBADF;
> +       if (!bdev_max_secure_erase_sectors(bdev))
> +               return -EOPNOTSUPP;
> +       if (copy_from_user(range, argp, sizeof(range)))
> +               return -EFAULT;
> +
> +       start = range[0];
> +       len = range[1];
> +       if ((start & 511) || (len & 511))
> +               return -EINVAL;
> +       if (start + len > bdev_nr_bytes(bdev))
> +               return -EINVAL;
> +
> +       filemap_invalidate_lock(bdev->bd_inode->i_mapping);
> +       err = truncate_bdev_range(bdev, mode, start, start + len - 1);
> +       if (!err)
> +               err = blkdev_issue_secure_erase(bdev, start >> 9, len >> 9,
> +                                               GFP_KERNEL);
> +       filemap_invalidate_unlock(bdev->bd_inode->i_mapping);
> +       return err;
> +}
> +
> +
>  static int blk_ioctl_zeroout(struct block_device *bdev, fmode_t mode,
>                 unsigned long arg)
>  {
> @@ -450,10 +478,9 @@ static int blkdev_common_ioctl(struct block_device *bdev, fmode_t mode,
>         case BLKROSET:
>                 return blkdev_roset(bdev, mode, cmd, arg);
>         case BLKDISCARD:
> -               return blk_ioctl_discard(bdev, mode, arg, 0);
> +               return blk_ioctl_discard(bdev, mode, arg);
>         case BLKSECDISCARD:
> -               return blk_ioctl_discard(bdev, mode, arg,
> -                               BLKDEV_DISCARD_SECURE);
> +               return blk_ioctl_secure_erase(bdev, mode, argp);
>         case BLKZEROOUT:
>                 return blk_ioctl_zeroout(bdev, mode, arg);
>         case BLKGETDISKSEQ:
> diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
> index 275c53c7b629e..2957b0b68d600 100644
> --- a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -1547,7 +1547,8 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
>                 start = tmp;
>         }
>         while (nr_sectors >= max_discard_sectors) {
> -               err |= blkdev_issue_discard(bdev, start, max_discard_sectors, GFP_NOIO, 0);
> +               err |= blkdev_issue_discard(bdev, start, max_discard_sectors,
> +                                           GFP_NOIO);
>                 nr_sectors -= max_discard_sectors;
>                 start += max_discard_sectors;
>         }
> @@ -1559,7 +1560,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
>                 nr = nr_sectors;
>                 nr -= (unsigned int)nr % granularity;
>                 if (nr) {
> -                       err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO, 0);
> +                       err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO);
>                         nr_sectors -= nr;
>                         start += nr;
>                 }
> diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
> index efa99a3884507..d178be175ad99 100644
> --- a/drivers/block/rnbd/rnbd-clt.c
> +++ b/drivers/block/rnbd/rnbd-clt.c
> @@ -1365,8 +1365,8 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
>         dev->queue->limits.discard_granularity  = dev->discard_granularity;
>         dev->queue->limits.discard_alignment    = dev->discard_alignment;
>         if (dev->secure_discard)
> -               blk_queue_flag_set(QUEUE_FLAG_SECERASE, dev->queue);
> -
> +               blk_queue_max_secure_erase_sectors(dev->queue,
> +                               dev->max_discard_sectors);
>         blk_queue_flag_set(QUEUE_FLAG_SAME_COMP, dev->queue);
>         blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue);
>         blk_queue_max_segments(dev->queue, dev->max_segments);
> diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
> index 1f7e1c8fd4d9b..d080a0de59225 100644
> --- a/drivers/block/rnbd/rnbd-srv-dev.h
> +++ b/drivers/block/rnbd/rnbd-srv-dev.h
> @@ -44,7 +44,7 @@ static inline int rnbd_dev_get_max_hw_sects(const struct rnbd_dev *dev)
>
>  static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
>  {
> -       return blk_queue_secure_erase(bdev_get_queue(dev->bdev));
> +       return bdev_max_secure_erase_sectors(dev->bdev);
>  }
>
>  static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
> diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
> index de42458195bc1..a97f2bf5b01b9 100644
> --- a/drivers/block/xen-blkback/blkback.c
> +++ b/drivers/block/xen-blkback/blkback.c
> @@ -970,7 +970,6 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
>         int status = BLKIF_RSP_OKAY;
>         struct xen_blkif *blkif = ring->blkif;
>         struct block_device *bdev = blkif->vbd.bdev;
> -       unsigned long secure;
>         struct phys_req preq;
>
>         xen_blkif_get(blkif);
> @@ -987,13 +986,15 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
>         }
>         ring->st_ds_req++;
>
> -       secure = (blkif->vbd.discard_secure &&
> -                (req->u.discard.flag & BLKIF_DISCARD_SECURE)) ?
> -                BLKDEV_DISCARD_SECURE : 0;
> +       if (blkif->vbd.discard_secure &&
> +           (req->u.discard.flag & BLKIF_DISCARD_SECURE))
> +               err = blkdev_issue_secure_erase(bdev,
> +                               req->u.discard.sector_number,
> +                               req->u.discard.nr_sectors, GFP_KERNEL);
> +       else
> +               err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
> +                               req->u.discard.nr_sectors, GFP_KERNEL);
>
> -       err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
> -                                  req->u.discard.nr_sectors,
> -                                  GFP_KERNEL, secure);
>  fail_response:
>         if (err == -EOPNOTSUPP) {
>                 pr_debug("discard op failed, not supported\n");
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index 83cd08041e6b3..b21bffc9c50bc 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -484,7 +484,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
>  {
>         struct xen_vbd *vbd;
>         struct block_device *bdev;
> -       struct request_queue *q;
>
>         vbd = &blkif->vbd;
>         vbd->handle   = handle;
> @@ -516,11 +515,9 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
>         if (vbd->bdev->bd_disk->flags & GENHD_FL_REMOVABLE)
>                 vbd->type |= VDISK_REMOVABLE;
>
> -       q = bdev_get_queue(bdev);
>         if (bdev_write_cache(bdev))
>                 vbd->flush_support = true;
> -
> -       if (q && blk_queue_secure_erase(q))
> +       if (bdev_max_secure_erase_sectors(bdev))
>                 vbd->discard_secure = true;
>
>         vbd->feature_gnt_persistent = feature_persistent;
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 253bf835aca1f..9fb7c69f72b2d 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -949,7 +949,8 @@ static void blkif_set_queue_limits(struct blkfront_info *info)
>                                                  info->physical_sector_size;
>                 rq->limits.discard_alignment = info->discard_alignment;
>                 if (info->feature_secdiscard)
> -                       blk_queue_flag_set(QUEUE_FLAG_SECERASE, rq);
> +                       blk_queue_max_secure_erase_sectors(rq,
> +                                                          get_capacity(gd));
>         }
>
>         /* Hard sector size and max sectors impersonate the equiv. hardware. */
> @@ -1605,7 +1606,7 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
>                                 blkif_req(req)->error = BLK_STS_NOTSUPP;
>                                 info->feature_discard = 0;
>                                 info->feature_secdiscard = 0;
> -                               blk_queue_flag_clear(QUEUE_FLAG_SECERASE, rq);
> +                               blk_queue_max_secure_erase_sectors(rq, 0);
>                         }
>                         break;
>                 case BLKIF_OP_FLUSH_DISKCACHE:
> diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
> index 097577ae3c471..ce13c272c3872 100644
> --- a/drivers/md/bcache/alloc.c
> +++ b/drivers/md/bcache/alloc.c
> @@ -336,7 +336,7 @@ static int bch_allocator_thread(void *arg)
>                                 mutex_unlock(&ca->set->bucket_lock);
>                                 blkdev_issue_discard(ca->bdev,
>                                         bucket_to_sector(ca->set, bucket),
> -                                       ca->sb.bucket_size, GFP_KERNEL, 0);
> +                                       ca->sb.bucket_size, GFP_KERNEL);
>                                 mutex_lock(&ca->set->bucket_lock);
>                         }
>
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index 0dff6907fd00d..e7d42f6335a2a 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -1920,9 +1920,7 @@ static int device_not_secure_erase_capable(struct dm_target *ti,
>                                            struct dm_dev *dev, sector_t start,
>                                            sector_t len, void *data)
>  {
> -       struct request_queue *q = bdev_get_queue(dev->bdev);
> -
> -       return !blk_queue_secure_erase(q);
> +       return !bdev_max_secure_erase_sectors(dev->bdev);
>  }
>
>  static bool dm_table_supports_secure_erase(struct dm_table *t)
> @@ -1975,8 +1973,8 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
>                 q->limits.discard_misaligned = 0;
>         }
>
> -       if (dm_table_supports_secure_erase(t))
> -               blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
> +       if (!dm_table_supports_secure_erase(t))
> +               q->limits.max_secure_erase_sectors = 0;
>
>         if (dm_table_supports_flush(t, (1UL << QUEUE_FLAG_WC))) {
>                 wc = true;
> diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
> index eded4bcc4545f..84c083f766736 100644
> --- a/drivers/md/dm-thin.c
> +++ b/drivers/md/dm-thin.c
> @@ -398,8 +398,8 @@ static int issue_discard(struct discard_op *op, dm_block_t data_b, dm_block_t da
>         sector_t s = block_to_sectors(tc->pool, data_b);
>         sector_t len = block_to_sectors(tc->pool, data_e - data_b);
>
> -       return __blkdev_issue_discard(tc->pool_dev->bdev, s, len,
> -                                     GFP_NOWAIT, 0, &op->bio);
> +       return __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOWAIT,
> +                                     &op->bio);
>  }
>
>  static void end_discard(struct discard_op *op, int r)
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 19636c2f2cda4..2587f872c0884 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -8584,7 +8584,7 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
>  {
>         struct bio *discard_bio = NULL;
>
> -       if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, 0,
> +       if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,
>                         &discard_bio) || !discard_bio)
>                 return;
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index c3cbf9a574a39..094a4042589eb 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1344,14 +1344,14 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
>         if (log->last_checkpoint < end) {
>                 blkdev_issue_discard(bdev,
>                                 log->last_checkpoint + log->rdev->data_offset,
> -                               end - log->last_checkpoint, GFP_NOIO, 0);
> +                               end - log->last_checkpoint, GFP_NOIO);
>         } else {
>                 blkdev_issue_discard(bdev,
>                                 log->last_checkpoint + log->rdev->data_offset,
>                                 log->device_size - log->last_checkpoint,
> -                               GFP_NOIO, 0);
> +                               GFP_NOIO);
>                 blkdev_issue_discard(bdev, log->rdev->data_offset, end,
> -                               GFP_NOIO, 0);
> +                               GFP_NOIO);
>         }
>  }
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index cac6315010a3d..a3d4460055716 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -189,7 +189,7 @@ static void mmc_queue_setup_discard(struct request_queue *q,
>         if (card->pref_erase > max_discard)
>                 q->limits.discard_granularity = SECTOR_SIZE;
>         if (mmc_can_secure_erase_trim(card))
> -               blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
> +               blk_queue_max_secure_erase_sectors(q, max_discard);
>  }
>
>  static unsigned short mmc_get_max_segments(struct mmc_host *host)
> diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
> index d886c2c59554f..27a72504d31ce 100644
> --- a/drivers/nvme/target/io-cmd-bdev.c
> +++ b/drivers/nvme/target/io-cmd-bdev.c
> @@ -360,7 +360,7 @@ static u16 nvmet_bdev_discard_range(struct nvmet_req *req,
>         ret = __blkdev_issue_discard(ns->bdev,
>                         nvmet_lba_to_sect(ns, range->slba),
>                         le32_to_cpu(range->nlb) << (ns->blksize_shift - 9),
> -                       GFP_KERNEL, 0, bio);
> +                       GFP_KERNEL, bio);
>         if (ret && ret != -EOPNOTSUPP) {
>                 req->error_slba = le64_to_cpu(range->slba);
>                 return errno_to_nvme_status(req, ret);
> diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
> index b6ba582b06775..e68f1cc8ef98b 100644
> --- a/drivers/target/target_core_file.c
> +++ b/drivers/target/target_core_file.c
> @@ -558,7 +558,7 @@ fd_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
>                 ret = blkdev_issue_discard(bdev,
>                                            target_to_linux_sector(dev, lba),
>                                            target_to_linux_sector(dev,  nolb),
> -                                          GFP_KERNEL, 0);
> +                                          GFP_KERNEL);
>                 if (ret < 0) {
>                         pr_warn("FILEIO: blkdev_issue_discard() failed: %d\n",
>                                 ret);
> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index c4a903b8a47fc..378c80313a0f2 100644
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -434,7 +434,7 @@ iblock_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
>         ret = blkdev_issue_discard(bdev,
>                                    target_to_linux_sector(dev, lba),
>                                    target_to_linux_sector(dev,  nolb),
> -                                  GFP_KERNEL, 0);
> +                                  GFP_KERNEL);
>         if (ret < 0) {
>                 pr_err("blkdev_issue_discard() failed: %d\n", ret);
>                 return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index efd8deb3ab7e8..5c1d3a564da5a 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -1239,7 +1239,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
>
>                 if (size) {
>                         ret = blkdev_issue_discard(bdev, start >> 9, size >> 9,
> -                                                  GFP_NOFS, 0);
> +                                                  GFP_NOFS);
>                         if (!ret)
>                                 *discarded_bytes += size;
>                         else if (ret != -EOPNOTSUPP)
> @@ -1256,7 +1256,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
>
>         if (bytes_left) {
>                 ret = blkdev_issue_discard(bdev, start >> 9, bytes_left >> 9,
> -                                          GFP_NOFS, 0);
> +                                          GFP_NOFS);
>                 if (!ret)
>                         *discarded_bytes += bytes_left;
>         }
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 6d1820536d88d..ea653d19f9ec7 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -3629,7 +3629,7 @@ static inline int ext4_issue_discard(struct super_block *sb,
>                 return __blkdev_issue_discard(sb->s_bdev,
>                         (sector_t)discard_block << (sb->s_blocksize_bits - 9),
>                         (sector_t)count << (sb->s_blocksize_bits - 9),
> -                       GFP_NOFS, 0, biop);
> +                       GFP_NOFS, biop);
>         } else
>                 return sb_issue_discard(sb, discard_block, count, GFP_NOFS, 0);
>  }
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 8053d99f3920b..35b6c720c2bc1 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -3685,18 +3685,18 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg)
>  static int f2fs_secure_erase(struct block_device *bdev, struct inode *inode,
>                 pgoff_t off, block_t block, block_t len, u32 flags)
>  {
> -       struct request_queue *q = bdev_get_queue(bdev);
>         sector_t sector = SECTOR_FROM_BLOCK(block);
>         sector_t nr_sects = SECTOR_FROM_BLOCK(len);
>         int ret = 0;
>
> -       if (!q)
> -               return -ENXIO;
> -
> -       if (flags & F2FS_TRIM_FILE_DISCARD)
> -               ret = blkdev_issue_discard(bdev, sector, nr_sects, GFP_NOFS,
> -                                               blk_queue_secure_erase(q) ?
> -                                               BLKDEV_DISCARD_SECURE : 0);
> +       if (flags & F2FS_TRIM_FILE_DISCARD) {
> +               if (bdev_max_secure_erase_sectors(bdev))
> +                       ret = blkdev_issue_secure_erase(bdev, sector, nr_sects,
> +                                       GFP_NOFS);
> +               else
> +                       ret = blkdev_issue_discard(bdev, sector, nr_sects,
> +                                       GFP_NOFS);
> +       }
>
>         if (!ret && (flags & F2FS_TRIM_FILE_ZEROOUT)) {
>                 if (IS_ENCRYPTED(inode))
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 71f09adbcba86..e433c61e64b93 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1244,7 +1244,7 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
>                 err = __blkdev_issue_discard(bdev,
>                                         SECTOR_FROM_BLOCK(start),
>                                         SECTOR_FROM_BLOCK(len),
> -                                       GFP_NOFS, 0, &bio);
> +                                       GFP_NOFS, &bio);
>  submit:
>                 if (err) {
>                         spin_lock_irqsave(&dc->lock, flags);
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 19d226cd4ff4d..c0cbeeaec2d1a 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1825,7 +1825,7 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
>                         err = blkdev_issue_discard(journal->j_dev,
>                                         byte_start >> SECTOR_SHIFT,
>                                         byte_count >> SECTOR_SHIFT,
> -                                       GFP_NOFS, 0);
> +                                       GFP_NOFS);
>                 } else if (flags & JBD2_JOURNAL_FLUSH_ZEROOUT) {
>                         err = blkdev_issue_zeroout(journal->j_dev,
>                                         byte_start >> SECTOR_SHIFT,
> diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c
> index e385cca2004a7..77ff8e95421fa 100644
> --- a/fs/nilfs2/sufile.c
> +++ b/fs/nilfs2/sufile.c
> @@ -1100,7 +1100,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
>                                 ret = blkdev_issue_discard(nilfs->ns_bdev,
>                                                 start * sects_per_block,
>                                                 nblocks * sects_per_block,
> -                                               GFP_NOFS, 0);
> +                                               GFP_NOFS);
>                                 if (ret < 0) {
>                                         put_bh(su_bh);
>                                         goto out_sem;
> @@ -1134,7 +1134,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
>                         ret = blkdev_issue_discard(nilfs->ns_bdev,
>                                         start * sects_per_block,
>                                         nblocks * sects_per_block,
> -                                       GFP_NOFS, 0);
> +                                       GFP_NOFS);
>                         if (!ret)
>                                 ndiscarded += nblocks;
>                 }
> diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c
> index dd48a8f74d577..3b4a079c9617c 100644
> --- a/fs/nilfs2/the_nilfs.c
> +++ b/fs/nilfs2/the_nilfs.c
> @@ -672,7 +672,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
>                         ret = blkdev_issue_discard(nilfs->ns_bdev,
>                                                    start * sects_per_block,
>                                                    nblocks * sects_per_block,
> -                                                  GFP_NOFS, 0);
> +                                                  GFP_NOFS);
>                         if (ret < 0)
>                                 return ret;
>                         nblocks = 0;
> @@ -682,7 +682,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
>                 ret = blkdev_issue_discard(nilfs->ns_bdev,
>                                            start * sects_per_block,
>                                            nblocks * sects_per_block,
> -                                          GFP_NOFS, 0);
> +                                          GFP_NOFS);
>         return ret;
>  }
>
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index 5f2e414cfa79b..5781b9e8e3d85 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -1333,7 +1333,7 @@ int ntfs_discard(struct ntfs_sb_info *sbi, CLST lcn, CLST len)
>                 return 0;
>
>         err = blkdev_issue_discard(sb->s_bdev, start >> 9, (end - start) >> 9,
> -                                  GFP_NOFS, 0);
> +                                  GFP_NOFS);
>
>         if (err == -EOPNOTSUPP)
>                 sbi->flags |= NTFS_FLAGS_NODISCARD;
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index e2ada115c23f9..c6fe3f6ebb6b0 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -114,7 +114,7 @@ xfs_trim_extents(
>                 }
>
>                 trace_xfs_discard_extent(mp, agno, fbno, flen);
> -               error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS, 0);
> +               error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS);
>                 if (error)
>                         goto out_del_cursor;
>                 *blocks_trimmed += flen;
> diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
> index ba57323bfdcea..c9f55e4f09571 100644
> --- a/fs/xfs/xfs_log_cil.c
> +++ b/fs/xfs/xfs_log_cil.c
> @@ -605,7 +605,7 @@ xlog_discard_busy_extents(
>                 error = __blkdev_issue_discard(mp->m_ddev_targp->bt_bdev,
>                                 XFS_AGB_TO_DADDR(mp, busyp->agno, busyp->bno),
>                                 XFS_FSB_TO_BB(mp, busyp->length),
> -                               GFP_NOFS, 0, &bio);
> +                               GFP_NOFS, &bio);
>                 if (error && error != -EOPNOTSUPP) {
>                         xfs_info(mp,
>          "discard failed for extent [0x%llx,%u], error %d",
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index f1cf557ea20ef..c9b5925af5a3b 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -248,6 +248,7 @@ struct queue_limits {
>         unsigned int            io_opt;
>         unsigned int            max_discard_sectors;
>         unsigned int            max_hw_discard_sectors;
> +       unsigned int            max_secure_erase_sectors;
>         unsigned int            max_write_zeroes_sectors;
>         unsigned int            max_zone_append_sectors;
>         unsigned int            discard_granularity;
> @@ -542,7 +543,6 @@ struct request_queue {
>  #define QUEUE_FLAG_IO_STAT     7       /* do disk/partitions IO accounting */
>  #define QUEUE_FLAG_NOXMERGES   9       /* No extended merges */
>  #define QUEUE_FLAG_ADD_RANDOM  10      /* Contributes to random pool */
> -#define QUEUE_FLAG_SECERASE    11      /* supports secure erase */
>  #define QUEUE_FLAG_SAME_FORCE  12      /* force complete on same CPU */
>  #define QUEUE_FLAG_DEAD                13      /* queue tear-down finished */
>  #define QUEUE_FLAG_INIT_DONE   14      /* queue is initialized */
> @@ -583,8 +583,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
>  #define blk_queue_add_random(q)        test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
>  #define blk_queue_zone_resetall(q)     \
>         test_bit(QUEUE_FLAG_ZONE_RESETALL, &(q)->queue_flags)
> -#define blk_queue_secure_erase(q) \
> -       (test_bit(QUEUE_FLAG_SECERASE, &(q)->queue_flags))
>  #define blk_queue_dax(q)       test_bit(QUEUE_FLAG_DAX, &(q)->queue_flags)
>  #define blk_queue_pci_p2pdma(q)        \
>         test_bit(QUEUE_FLAG_PCI_P2PDMA, &(q)->queue_flags)
> @@ -947,6 +945,8 @@ extern void blk_queue_chunk_sectors(struct request_queue *, unsigned int);
>  extern void blk_queue_max_segments(struct request_queue *, unsigned short);
>  extern void blk_queue_max_discard_segments(struct request_queue *,
>                 unsigned short);
> +void blk_queue_max_secure_erase_sectors(struct request_queue *q,
> +               unsigned int max_sectors);
>  extern void blk_queue_max_segment_size(struct request_queue *, unsigned int);
>  extern void blk_queue_max_discard_sectors(struct request_queue *q,
>                 unsigned int max_discard_sectors);
> @@ -1087,13 +1087,12 @@ static inline long nr_blockdev_pages(void)
>
>  extern void blk_io_schedule(void);
>
> -#define BLKDEV_DISCARD_SECURE  (1 << 0)        /* issue a secure erase */
> -
> -extern int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -               sector_t nr_sects, gfp_t gfp_mask, unsigned long flags);
> -extern int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -               sector_t nr_sects, gfp_t gfp_mask, int flags,
> -               struct bio **biop);
> +int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> +               sector_t nr_sects, gfp_t gfp_mask);
> +int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> +               sector_t nr_sects, gfp_t gfp_mask, struct bio **biop);
> +int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
> +               sector_t nr_sects, gfp_t gfp);
>
>  #define BLKDEV_ZERO_NOUNMAP    (1 << 0)  /* do not free blocks */
>  #define BLKDEV_ZERO_NOFALLBACK (1 << 1)  /* don't write explicit zeroes */
> @@ -1112,7 +1111,7 @@ static inline int sb_issue_discard(struct super_block *sb, sector_t block,
>                                               SECTOR_SHIFT),
>                                     nr_blocks << (sb->s_blocksize_bits -
>                                                   SECTOR_SHIFT),
> -                                   gfp_mask, flags);
> +                                   gfp_mask);
>  }
>  static inline int sb_issue_zeroout(struct super_block *sb, sector_t block,
>                 sector_t nr_blocks, gfp_t gfp_mask)
> @@ -1262,6 +1261,12 @@ static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
>         return bdev_get_queue(bdev)->limits.discard_granularity;
>  }
>
> +static inline unsigned int
> +bdev_max_secure_erase_sectors(struct block_device *bdev)
> +{
> +       return bdev_get_queue(bdev)->limits.max_secure_erase_sectors;
> +}
> +
>  static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
>  {
>         struct request_queue *q = bdev_get_queue(bdev);
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 5d9cedf9e7b84..a2b31fea0c42e 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -179,7 +179,7 @@ static int discard_swap(struct swap_info_struct *si)
>         nr_blocks = ((sector_t)se->nr_pages - 1) << (PAGE_SHIFT - 9);
>         if (nr_blocks) {
>                 err = blkdev_issue_discard(si->bdev, start_block,
> -                               nr_blocks, GFP_KERNEL, 0);
> +                               nr_blocks, GFP_KERNEL);
>                 if (err)
>                         return err;
>                 cond_resched();
> @@ -190,7 +190,7 @@ static int discard_swap(struct swap_info_struct *si)
>                 nr_blocks = (sector_t)se->nr_pages << (PAGE_SHIFT - 9);
>
>                 err = blkdev_issue_discard(si->bdev, start_block,
> -                               nr_blocks, GFP_KERNEL, 0);
> +                               nr_blocks, GFP_KERNEL);
>                 if (err)
>                         break;
>
> @@ -254,7 +254,7 @@ static void discard_swap_cluster(struct swap_info_struct *si,
>                 start_block <<= PAGE_SHIFT - 9;
>                 nr_blocks <<= PAGE_SHIFT - 9;
>                 if (blkdev_issue_discard(si->bdev, start_block,
> -                                       nr_blocks, GFP_NOIO, 0))
> +                                       nr_blocks, GFP_NOIO))
>                         break;
>
>                 se = next_se(se);
> --
> 2.30.2
>

For nilfs2 pieces,

Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>

Thanks,
Ryusuke Konishi


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 07:42:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 07:42:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300461.512532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncMmK-0000vf-Pw; Thu, 07 Apr 2022 07:42:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300461.512532; Thu, 07 Apr 2022 07:42:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncMmK-0000vY-Lx; Thu, 07 Apr 2022 07:42:04 +0000
Received: by outflank-mailman (input) for mailman id 300461;
 Thu, 07 Apr 2022 07:42:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncMmI-0000vP-G0
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 07:42:02 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 33ef43fa-b646-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 09:41:59 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33ef43fa-b646-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649317319;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=BYI35DPL5ZAdeR7w/J+YiEEZGBRL9DYWE7YRtZYqEZ4=;
  b=XtP/rSDfvD78g92eDmPlwng9qjFqGEIdcyvUvEt1MSyV5HTBnjKycN0G
   wibpIMyoWqzsjh3TiMvqxqqg2WdvKpv05XA/HLCl2CkoAmURVjJImQfv9
   wEzFr30kR2ZG4Hp3xrGPhtKY0T8EUHeCsbVH0zc4YM4NPET067jipPe8Z
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68130971
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DVWhN6PMqXHxKa/vrR2Jl8FynXyQoLVcMsEvi/4bfWQNrUor1TZWn
 zMWXmCBbK2NMGvzetB0YYTlp0xUvcWGmNZnHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tEw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0
 ugRvoadUBcQYajjiMteUUlCGTtzFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmdp3ZgfQq+2i
 8wxRDZEVB7pWzR1AE4NWY8Dn76qgUm4WmgNwL6SjfVuuDWCpOBr65DuPcTUfJqWRMxTtkeeu
 m/CuW/+B3kyLNWCzRKV/3TqgfXA9Qv5Uo8PELyz9tZxnUaegGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZbVYAtruIvVQV10
 3CZsJDrVSZlqrC8HCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh
 mnT8XNg3+l7Ydsjjf3TwLzRv967SnElpCYR7x6fYG+q5xgRiGWNN93xsgizARqtwe+kori9U
 JosxpD2AAMmV8jleMmxrAMlRuzBCxGtamC0vLKXN8N9nwlBAlb6FWyq3BlwJV1yLuEPciLzb
 UnYtGt5vcEPbSH6MPInPN3oUqzGKJQM8/y/C5g4ifIUPPBMmPKvpnkyNSZ8IUiz+KTTrU3PE
 cjCKpv9ZZrrIa9m0CC3V48gPUwDnUgDKZfobcmjlXyPiOPGDFbMEOttGAbeP4gRsfLfyC2Io
 ok3Cid/40gGOAEISnKMqtB7wJFjBSVTOK0aXOQLLrXTfVc8QDhJ5j246epJRrGJVp99z4/g1
 nq8RlVZ2Bz4g3jGIh+NcXdtdPXkWpMXkJ7xFXVE0YqAs5T7XbuS0Q==
IronPort-HdrOrdr: A9a23:NoDw6Kqs4MqZbzyKKOt7zGoaV5uyL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUXsGIP41qj2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U
 XMjgS8v8yYwryG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls
 XKvn4bTo5OwkKUWlvwjQrm2gHm3jprw3j+yWWAiX+mmsD9TCJSMbs2uatpNj/ir2YwttB116
 xGm0iDsYBMMB/GlCPho/DVShBDjCOP0DQfuN9Wq0YafZoVabdXo4Ba1lhSCo08ECXz751iOP
 VyDfvb+O1dfTqhHj/kV1FUsZyRt0kIb1S7qhBogL3W79EWpgE086Ig/r1fop9an6hNDqWt5I
 z/Q9NVff91P4srhJlGdZQ8qPuMexzwqC33QRCvyHTcZeg60iH22tbKCItc3pDfRHVP9up0pK
 j8
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68130971"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IsX7w0K3A2QeVbsOEypXFE0QCVStW5HlcOR8STEGJEqKKmcjSvcE4SfLPaHII/p62DmZ7f56Tx9M/MC1vg4dpWbtDv67ll9E0Vqk0GCh2XvlHKAxgE6Xm6vXEv8or9p+9SJAfyNi+gtXLkprJCT0Azdf7PZH/6OwDKBQWO4MfslSlPbI319m/bzWIw4pbxpvqNgbqeMxormdDz3yaQR411ZwHn6dPNgvLvm1QUNdDjiu74ZROIYgbd1ryD6qVsTOU7Ho1qV/acS264FohNYD4vd8obXECtRFyuYyEumQS0jhCuTadzVnAVJGY8rwDg1KSIeRWn2omOTBALJI+m7kBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B5a0AwH1+6W0V6mgG4NE1u8Cpx6mBKVJKukjtzyKPCg=;
 b=lTGct5jippnUPw5labweW7cjVeEW24/qPB4VEjAouHaWwhEsBWiVdVb170Ad/nE2eHfA2TkEfh/BWS/3ycDP2EDcpYSr/H3vAOYy6ztzOYk321+MODtvkpaIPLB6GykFuO/UazFMBDvOYMJsSuRXEW4lKtyQ6F1ztiYcsaX+g5HJ1C3vs/yzU8DVWArtBlCa0uOXL9tCXZysNCJ0h3WmcUuzcM2UFnK2rfDzCk5fYrOriAR5hV0G6DBcuSDGsc3tJCMqYAFq/NZUONjGUilaQ05QY9NXhZlSeaLBjD3T08Yhf52mejFUvZPxnv8IBpISz7wzytPYQ9gZIQL9Nq7xrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=B5a0AwH1+6W0V6mgG4NE1u8Cpx6mBKVJKukjtzyKPCg=;
 b=W3YYHyHROrotqMOvxFmzPXvRHZa4+J05BiJ6JTH9Gf95RDt++smFpXAbDW5+b4tt95NSiuElEAnhUas/vlemST+zNE90qRnWKtoDGCL0f13Ef9aEJ+nBQfoV1Zt+QjXlcevM9t407yToUDgIfjaDG1Ka/Gjd2XcUBfeSeVPPT8A=
Date: Thu, 7 Apr 2022 09:41:49 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Paul
 Durrant <paul@xen.org>
Subject: Re: [PATCH v2 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Message-ID: <Yk6VvXJHWxJZTgeF@Air-de-Roger>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <6739cf19-a74a-208d-82e8-28dfde7710f5@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6739cf19-a74a-208d-82e8-28dfde7710f5@suse.com>
X-ClientProxiedBy: LO4P123CA0064.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dcde59e6-990e-433d-c61b-08da186a1627
X-MS-TrafficTypeDiagnostic: BYAPR03MB3719:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <BYAPR03MB37191C7AFC542DA71707F1228FE69@BYAPR03MB3719.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GfWwYuQDHXa0LjwVPVpMHD01X9AdCtfp3/BYw7JdSjpjxDP+cOrHauRCptNQ5lVv64OcPe0iLz07syZH4ew0SCEbyruxrt1X6EZv5vlNqdRP0FpzinVpx5CjHw7V5XuA9RfY6JHZZaNuwcNncoaxpi2URN97CQpWwa9ax/QQZzlvUY7e3MUBlAyYONWznazuRxHi41NaMxBfZ3bDX8bLKVR8y4NXUgvqxn3KPWrWk7g7XPkM3WAyZb1h5TtwlmYlDpbhvasJHOpWUOhKdaqSwzLmOEYsjVeNVnRZyI8C5tcAGPWJ+mzPiIKWOeZr+dV+cqYmJz4cXp/jjiKt+uZdSEznulht7ArNcHkmVMFwxzTtQ2vlz1lgFvvwZVrYzGsJFSkWXG+OaRzZ0Ef8oidYlRcjGfwwEcfj4l22bxGkQKmO/85/TLOxSPPcxibXB4yxEhmq1Ae0TYtiYr/PhXAUr5eHw7M7GKXPBSzzzAzR52cxnmf04x565g+ZuQXNSJi84xfRa26tTAYMrTo+lVU5A+YG+r33nwSexpyzLZwbi7yKXZd2Gg/u6Em3cBv0wt7ulwabBzuWFsyGQuG02CDTouNv9dZLPWEXTaOzeqDNoYpQUF+KofXOaK6WulIl0UG51cqk76hSj4kr4c9g7+WPXg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6916009)(316002)(26005)(38100700002)(186003)(54906003)(33716001)(82960400001)(85182001)(9686003)(6512007)(66556008)(66476007)(83380400001)(508600001)(86362001)(6506007)(2906002)(6486002)(5660300002)(66946007)(4326008)(8676002)(8936002)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ry8wWm50NHNQQTFaSEdSZE1kdFZOWmNzc1ByOE9XeWIxd1JZaDk3aVJMS3c0?=
 =?utf-8?B?bmtyazZFdHFhSllsSCs1aDJlQ2pncG9iczhQZEpGaklmWmlxUFRJeUFJSi9N?=
 =?utf-8?B?cng4N013ZHZmalA4QWtpSFlaTFVLVU1wRlU3aURZcWx2eVlFaUZQRTRJZHV4?=
 =?utf-8?B?dHQyNGVRa0R3bnMyMTVVSkYrUEhPejZxK29EWWk3cHpPUWtOT3pFdXRKOVRM?=
 =?utf-8?B?bWkzeWtXakc0Y1lvbFVYcEh5VTk4VXgzMWdzVG44endxbWdtNDB5ZDNwSU8z?=
 =?utf-8?B?RjhXRWVvMUxOWWhrbUZqNXZKeEt0dTZiZHlFQWpackZ5UlNzUEQrK05PTWV3?=
 =?utf-8?B?QlJ4NjJNOVNyVXJFN0xzeGJONHNvVXFoTmRHWjEwR05zbmNXUUNNLzAyRzNs?=
 =?utf-8?B?Yk5nMnBveEZadzBkOTBGWVNCc3BCZklrZlhEb2hHZmpqWWhkdVFqTU9QcVl2?=
 =?utf-8?B?dzd5Tm9XYXlzbzJWWGxqMVF2RFNaSzAwMHhwZnQ1Vi8xVkVkbkpZMVdlTGFi?=
 =?utf-8?B?clRLRmRCVUt3Q1dQcWpKM3gzSm9MM3pVZk1IbGdHbW1MemxIWUFMTnkyejhJ?=
 =?utf-8?B?MEhQbjJacks3eVh3eXk4YlJHTTJFZEgrWXNuS2xETVNNS1N5TDV3TGRRS29P?=
 =?utf-8?B?VVBjN1RFUG1WYnF2OFRUZXJKcWZaL0NkbkJFaDFrd09tS29ZdUh5T1BBOHRQ?=
 =?utf-8?B?Vm0wd2RtZHpKNE1hY3VyaXVIK1ZSYXJETVhrbWh3NnEweEdabVZDZkQxeURl?=
 =?utf-8?B?SkQweEozM1dubHpyRDdHUkx4b0RUb3hwYUJUTTViaDFueVQzOFZoM1Zna3k4?=
 =?utf-8?B?WkpJVUo1N1FiQ1I3dVllcFFuR2dScHJhWU1wSTBDYllRUlZCbTlXNmxveW5T?=
 =?utf-8?B?dG1oL21RSkg1aVVsbm9MbUlpVElEYmdtc0doSStFSEV3NWh3VlVCckg3Yk1X?=
 =?utf-8?B?NVNmVDlQYnlvV1RpT1NHNUNSNjNQU1NqR0ZnL3BkZEtyMUdSYnJKcEYzRDM0?=
 =?utf-8?B?Y0pHdGZsVkNKcGJ4NVdQelZWSlBYMUxMbkxDakhxMXJseWkzNGlON2hBNlRI?=
 =?utf-8?B?bWdBOHhFQlY5VkM4NENCUys2L0ZZRVZyam9WTWsxRklIbFFBODE5VEYzMWxZ?=
 =?utf-8?B?MllQQ1lhSnZldEdESTZsdU5lWVVqb2g3ZjJ6QlAzSnl5cEZNNXpJSmJPTk8v?=
 =?utf-8?B?eFRkeUh0N01lS1YzU2lsZ2dQak5LSzFIVVNYc2xkMEthUWxlendUdEZ1dGNh?=
 =?utf-8?B?RmVKTHhJV3dLbVdtNlQxMEdxWW9LQ0pNNHVKcWV5NmsxcjlLaitRSDVXclJ0?=
 =?utf-8?B?L2hFdkRIUkRxWExhUzJXQzAyMGI5b2dxcTNBaGh2T2psV3F5VWZCRUVhME5t?=
 =?utf-8?B?RVlyWkxaUFJjYjBCT0VKSmltVkVjYzZCa2lNdzVWRVdjdVltVGRPUFlIZDFZ?=
 =?utf-8?B?dXV4QmpBUldpVTBkaDI4T1hLWXo5S3pQQzVXOUFFUkp4TUlvb0tZSDZabmJw?=
 =?utf-8?B?ZkRGTTY1Q3M3WkRrdWVWZEVGRDNtcVFxOU9IQnlXbUt6V0NFbmxlUy95aEZl?=
 =?utf-8?B?LzdudGx1cjdLTGxEUXBXMHpFeDBDdjkvcHRvb252N1JhbXA5R1J5QXNkS3p3?=
 =?utf-8?B?VEx0aVdQZi9Oc2czTHFGc093QkFDOVYzbjY3QUZNTFd1TW54UHc3NXBGeWR0?=
 =?utf-8?B?WTNaZWV2dzRyZkpSMHZtVnBha3dmQms0Um1XK25RSTg2clc4a21zSW9kQW95?=
 =?utf-8?B?MHpMbDBjblFMYlNiM1dybVZHZUxNbk1VblBqczBQWTlvclJsVHg0WTdYT2Zo?=
 =?utf-8?B?dFRleERXRE5hRzF5blpaWTZ0dzFyeFlvdDVzN0dvRmxpMm1OalR4c0puazFL?=
 =?utf-8?B?SFFjMU0yMDNGT0t2M1huS3ZLclN3Rm5EMkplbmJyWVlXR3hudlJsNHVDdjYz?=
 =?utf-8?B?N0R2eHpGdWNtbHhyY3ZkNk9GeStyOWUzZmlkbTBDd0RSKzBwbFpMczk0THhL?=
 =?utf-8?B?b3pWYTFhTUtYaGhvdEtXcW0rVWtScHEzbE41ZHZKK3lTdTNKc09Xb1pncWN0?=
 =?utf-8?B?ZEVJNktBREdMdjNBUy95eW85QmdndFNhK2lBWHIwN3ZQWEVjY1N4OFFEayta?=
 =?utf-8?B?cUpvcGlIV0k3V3h0eG5CS0dNbTRHZFJVbjR4ay9hUWRJcWRpMjFmNWllb3RQ?=
 =?utf-8?B?clR2b28zRnVZZ3lZbFh4UDhIZS9Ic2JrNTlEWEs0NXIxSGJvdFRKVS9aVTM5?=
 =?utf-8?B?dTdSaWZ4MGdBU3VvbVhQRTZSTWhLTTJOVDRIRGJHTmZPcjdrVWhwbEVMak96?=
 =?utf-8?B?eXBac3VlTzJpWVgxRE5mQ1k5TFFwbUErMmxoaHFIRGltTDl5K2Q5em96RnJl?=
 =?utf-8?Q?9HKpeN9r6hSxRBHY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dcde59e6-990e-433d-c61b-08da186a1627
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:41:54.5682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H31nuf30Rj283y2vhAJbcjgouyesbKk8wzXObME8Ifk/YRW2DUrVUTOZFl8mDqD4jotWZ3EoIS28QFQHgJ5qSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3719
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 08:11:06AM +0200, Jan Beulich wrote:
> First there's a printk() which actually wrongly uses pdev in the first
> place: We want to log the coordinates of the (perhaps fake) device
> acted upon, which may not be pdev.
> 
> Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
> device quarantine page tables (part I)") to add a domid_t parameter to
> domain_context_unmap_one(): It's only used to pass back here via
> me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again.
> 
> Finally there's the invocation of domain_context_mapping_one(), which
> needs to be passed the correct domain ID. Avoid taking that path when
> pdev is NULL and the quarantine state is what would need restoring to.
> This means we can't security-support PCI devices with RMRRs (if such
> exist in practice) any longer.

The sentence:

"This means we can't security-support PCI devices with RMRRs"

Seems too broad and could lead to confusion. So I would maybe use:
"legacy PCI devices" or "non PCI Express devices".

> 
> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
> Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quarantining")
> Coverity ID: 1503784
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 07:45:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 07:45:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300465.512542 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncMpa-0001Wq-7f; Thu, 07 Apr 2022 07:45:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300465.512542; Thu, 07 Apr 2022 07:45:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncMpa-0001Wj-4r; Thu, 07 Apr 2022 07:45:26 +0000
Received: by outflank-mailman (input) for mailman id 300465;
 Thu, 07 Apr 2022 07:45:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncMpZ-0001Wb-F1
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 07:45:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af0c1ca0-b646-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 09:45:24 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-1gQ_7DP8Mju4y9_xdrK3sw-1; Thu, 07 Apr 2022 09:45:23 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0402MB2859.eurprd04.prod.outlook.com (2603:10a6:3:d7::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 07:45:21 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 07:45:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af0c1ca0-b646-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649317524;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KyI39DVD2eJjSOo+tdQjm/3WPYgJrr+nJ+X7QWy+z8o=;
	b=UBt+eB4CHn36RFhJTRYk3G4G47hLd7FBuO/WtaRYq7rNAZi2oYEATmdXAM5LzLACwPxjFd
	oBCFCC78QpLepYvhc94+JQKngUlQRMCQRsqQfYD2TdIY80otwOj1CrKNqVrhk2gH4705IG
	iyptgO8uBKzfteKdM1lsl1TIxEKPERE=
X-MC-Unique: 1gQ_7DP8Mju4y9_xdrK3sw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R3JNVWQAPRwkkemILRGWxe1mcQ+gww/VLUCcWpQE3hzMHrABtOmgoGVTIqM2KWBcxkqoD3BkuZDg1fpN65aSz6R2AMZjMD0KQzaMjaWLm0NamjzeI9TzWim3jEEafYDI1RXtEaYlK//Fc6tGwbiYJblquQxCuPLURR4/sRunSUQYtpgsz1yQ3Qkv5Ra9WAJfmGGZfslPdmaQ6cCF7UQBeOtwN/cRXXklge2A7j06Cvf7EafhWrE5aQr3Gg/v2+cQdv2ollSu2NZEeuTGvUJTR8OWzFnjFl0VPaGJYjqUe8Q+Le0ihfX+/BDM1dniNtRyLdZpm54hHE60InujsSq+1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fkIlB57yCEt6Waar1zlwNpDuPjCppWtm3cQCQlXRgWY=;
 b=UTU8HgRRo8u5D4q3RJxKXf5NiDFQ2m48ca3pCmWfzgZxW5UUYfHqCf/1mQeIC3aFz4zOFKcDfZXRzoi74tdS6+6cVJDRmvGbOVfuJMl6YfqqoyX6ELyr5x5C3sB6ChtFhjfAxKBS1mL6ANKbeZsC3VWDtbz32YwwX8ePMEFV0aX5Ffa+WVvERGQtNwGsQI3kunxq9qb6ytk78dRlJT3oQm6jEOZKX+XeYtPvIZADLxUUY/R6hKowoeIFUb+5ZNrvfUd38xa/s7idul9eZyDouh9DULPWo0R7WuWMPP8x8XDIpf/GdvGE/aSWZHjQzP+2fxhtXFnla9r9HRz03AZ0aQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <211ca973-553b-e2dd-ab12-e05a8e624b8a@suse.com>
Date: Thu, 7 Apr 2022 09:45:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 00/14] x86/mm: large parts of P2M code and struct
 p2m_domain are HVM-only
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <A88AF737-14B3-4EE8-BF36-5D68F9FFD780@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <A88AF737-14B3-4EE8-BF36-5D68F9FFD780@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0022.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::35) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2be66ba6-64d2-4da1-0da6-08da186a9162
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2859:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB2859F89FF8DA0080ACB52012B3E69@HE1PR0402MB2859.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	G+7GgERq21VPj+nn6D+6gBLD1v4dns1P4cfSV4+x10d7TaoFj3c2RO4X4tw5hZJ3DhU/BniI1u2PALcEej3OF0Cdd6Ye/yges7B3ry9R5WmRKGCKKquNfHYUR3b6sPs6tzmHRWi/Pm78KCVaTM61z9fZ1rLRw6yMH+pNpjcZOobFcp0wCreqra6YSbvjJ8YAnmXVCZLsw1LLiMfbW+c2jrk0hBkOfteZ2Zxw1XuviwgViN2wngtdVH9JPWshtpXtgE2xNei7YrUETZ4axAHPY0xz2bur5EQe1LPXuiuqGYuOLXarVILE1V177694RogAJi6dA5KTyc5hhvd5JHAt0rRoEFK7JtjitEbYW7jvqoNFBQ+8mLJ4nNJLT9ItQ5yEZCbDqmj1VtD8M45/WAKscBWjzjyMz6a0qntmnXopUair5IRGgDTGu9zIqLRWdHAjWSKZb6Y9SfB29doVPqIm+y7ThWgZavM5a39sgleV6bBeiKi9byBf0zR6mZu4Vb/cxTilIaFZ7v6hryJETfmtx39pGeezWLyKfM2I0c8UoAJt7Z50WSgk6P60Qr1Ii6a6x2asPoK3Mnsm2SEM5wj9Fu4bYYG4iDwmZAadbMklDtSrEvveuV1BYLCxFUDT7wEaNPB3WuBl3+HlbEUBZ1qm40HBfxR+UM0l6+AoNkJgA6v0Jyvzkf1d2yMTH4l51Snqd1GlIjRc8cDZteWCIZjIAd1zA+yU+wmNflu3tu/TSO1LKEGuID+J+LxtYxn/74G+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(26005)(36756003)(2616005)(6486002)(83380400001)(31696002)(31686004)(38100700002)(86362001)(508600001)(8936002)(6666004)(66946007)(2906002)(66556008)(316002)(66476007)(6506007)(6512007)(53546011)(186003)(54906003)(5660300002)(6916009)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?m7t6CCX9vXnTXAlZYdKkO/X/zIWUIo4eO1Xd0gtxlmUXq9ZOJHZjhyhNryyL?=
 =?us-ascii?Q?T6J+kTmqIsxYTbEQsUWivfEE0wUMb7rKVKQN7E1gije6nrWXfQKAI13JtcOK?=
 =?us-ascii?Q?4API3cSt/rcjelsDMFRJvax6l/APcV3v0sKJ54GBwz9eeefrERGyKs7dT8qb?=
 =?us-ascii?Q?mvA69njENtVdlMQg1q1bygELDkAAytI553nbHmzgrZ5oJDg2uumLPWRB/0ya?=
 =?us-ascii?Q?3QgLZlirEbsalr+RnQmxejAi5DqRmAEoMzcAM9CUH21MEn1JzwOdWgPILS93?=
 =?us-ascii?Q?KPeZRvWyEuvq0JK6Rm1TVv5KJKzC29vixGa99cl9+BwKey/xuglXE+Zaeehp?=
 =?us-ascii?Q?/3oH0RfU1YMkvlTmD7LFelsXEyWDYjWUMJYKno7bETvCD/Oj4FLis8Et8t/L?=
 =?us-ascii?Q?BUQMAj6uZ4PT+Jd77GXJOf2z89AagPStd1Ss8bUn5zmZsqp/EmiTIhyIjwQT?=
 =?us-ascii?Q?HrMI1mgvBqkN5YkjqRtJBqBLcyZS2Tvu9jDz0wUaEuiOTRXOQmxGIRsgVAVR?=
 =?us-ascii?Q?b+xBUlSodyKtxvbOFA/lZQM9GXOlyjE1qCFd/rXQdGfueuetWdAyKNloY0bU?=
 =?us-ascii?Q?DznlVZSNOcWgQJXRGiz9h1pVdPpmzCFyK1XjDpZ4AW539yH0ghEAYHl895KL?=
 =?us-ascii?Q?RbP3FFn6+rWAraZI29XVUQwQNouof/iBND/rOkvdhMciysXfLhK+QLo0iB9y?=
 =?us-ascii?Q?8wBg5n60+2wRBjMRB/yspmLsaPV5+9TtQ0QfbmksWs+Fsd9Z3XPonRwaL5mN?=
 =?us-ascii?Q?KQpFehHwiHVeTGi/RVSev+VM6v4gTdyjmiVfMN2N0QQpp0UbXCjP41Lt6cCQ?=
 =?us-ascii?Q?osIln0uQNd5BmO0XB8f9fAf8KUp9Hxjk2y2DeNbDl2mHGqeAoQWp87AblmgZ?=
 =?us-ascii?Q?nPKgxbZNkH5vr7t+4UWbez+YN1TnMWXJEcPPiPT4LJg4kZ6qRdAT4QzgYh/z?=
 =?us-ascii?Q?I9Ui+oXxfzM6+NmRB4Q4ZwzQBj2Kn/t2tSrqeDI8asK4cp2Ixr9ItYRUhUTD?=
 =?us-ascii?Q?1CEslocA3/VjsIw+wbUrD8olW7YuP92uw0wSXtg7bOWuPGHTpO7N78XcOJyF?=
 =?us-ascii?Q?EJARPrL/MHaWy49fJIrTcWklzoUFembaIH8Z3vo5H6h+cpKJ/SeCAT0jRk4k?=
 =?us-ascii?Q?dQKCqvz34OGUtPQ2Nhbo4qH7Pv/7+k+PCAydpbDV9+fnkFYonEbjmNGctin9?=
 =?us-ascii?Q?Z8kwB8zC6FpFXu9ZZdXLHsF+EAP0NcTlgwC7hCPkczSitnIwIQvT3ezIV8Xd?=
 =?us-ascii?Q?HdFeDyEUPwVDjyrGfppG7mvbw5uCy+4oOEZaUP6ftzCI6hqVvLmcY/LpHs3u?=
 =?us-ascii?Q?gzmO4lRouvmMzaOtvSgoXPbRTmdge9ypxaFDVIH2NPCD2ejsj03d2pF8goFt?=
 =?us-ascii?Q?ypGBJTxt5X1vb2hoYijugwJfBoOtkv8UDAxEFengvPmAoJBndfwTsA1nqUzk?=
 =?us-ascii?Q?+EuqrQwGptzHvUnsKS9dmhWclqWVN0tqosfYIDPHzSI0OooSDuBLhGiuYyUy?=
 =?us-ascii?Q?a2fjIj7CXK/mdDxReL0iwxXmj7Q4wwmR7725e/EqxnZRZ5x2vPaREyTm/Rno?=
 =?us-ascii?Q?bVgM8jq3wfNqTLLaJnZw6b3hsuhANnswnsNkhJ6mPjpfHoZ2tha1+Nni+18c?=
 =?us-ascii?Q?GnuGJ5ogCCXXGW7A93nsPg0QsvQmlBi0i0yt5pX/aMB1ym7Db41uKUoAak9T?=
 =?us-ascii?Q?Y2dPesMldI3t4xZ3mFqYuATSsPYGvB50v0qoZbih7R5oQW9+NpRK+nTylrNn?=
 =?us-ascii?Q?rHqhbjHj2A=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2be66ba6-64d2-4da1-0da6-08da186a9162
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:45:21.3724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3jwDOb2luFcElQgxf/eFyd2sbDLrW3fS9IQwOELbZjMQIsBUa6BUViy6gdFiOSev0v22tu0KkyWqws+uOnEA7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2859

On 01.04.2022 14:47, George Dunlap wrote:
>=20
>=20
>> On Feb 23, 2022, at 3:55 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>
>> The primary goal of this series is to leave p2m.c with, as its leading
>> comment suggests, just code for "physical-to-machine mappings for
>> automatically-translated domains". This requires splitting a few
>> functions, with their non-HVM parts moved elsewhere.
>>
>> There aren't many changes in v2, mostly from re-basing. See individual
>> patches for details.
>>
>> 01: x86/P2M: rename p2m_remove_page()
>> 02: x86/P2M: introduce p2m_{add,remove}_page()
>> 03: x86/mm: move guest_physmap_{add,remove}_page()
>> 04: x86/mm: split set_identity_p2m_entry() into PV and HVM parts
>> 05: x86/P2M: p2m_{alloc,free}_ptp() and p2m_alloc_table() are HVM-only
>> 06: x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
>> 07: x86/P2M: split out init/teardown functions
>> 08: x86/P2M: p2m_get_page_from_gfn() is HVM-only
>> 09: x86/P2M: derive a HVM-only variant from __get_gfn_type_access()
>> 10: x86/p2m: re-arrange {,__}put_gfn()
>> 11: shr_pages field is MEM_SHARING-only
>> 12: paged_pages field is MEM_PAGING-only
>> 13: x86/P2M: p2m.c is HVM-only
>> 14: x86/P2M: the majority for struct p2m_domain's fields are HVM-only
>=20
> OK, I think every patch has an R-b from me on it now =E2=80=94 let me kno=
w if I missed anything.

Thanks a lot! I don't think there's anything missing; I've committed
the first few patches, until one where I still need an ack from Roger
for a vPCI change.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 07:50:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 07:50:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300470.512553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncMuE-000389-ON; Thu, 07 Apr 2022 07:50:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300470.512553; Thu, 07 Apr 2022 07:50:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncMuE-000382-LA; Thu, 07 Apr 2022 07:50:14 +0000
Received: by outflank-mailman (input) for mailman id 300470;
 Thu, 07 Apr 2022 07:50:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncMuD-00037t-VQ
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 07:50:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5aca65c1-b647-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 09:50:12 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-LWoQaKiZPhitUfXrd-F2uQ-1; Thu, 07 Apr 2022 09:50:10 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB3069.eurprd04.prod.outlook.com (2603:10a6:802:9::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 07:50:08 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 07:50:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5aca65c1-b647-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649317812;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jN77GZG4mCMwqGZ+/YpyXkkaeNwozUatRJtjWE/Vb1c=;
	b=Wz1TdKIx3VaE07E1Yv0VC1PRLimHyM9rQrfETLfl59PhA68GnpPdI/57Dupe0tGTArCVJJ
	uqi0HKxTzIPopWWBYFbMxMV4GsZIXXcQM6VGE0AXAqmDiynNBfEwB8KD+tkZWvTQoTmauS
	LMcvu6wyql77qNFaEyONICgn1ypo0bU=
X-MC-Unique: LWoQaKiZPhitUfXrd-F2uQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GpmXgaOLf4crsAymoN8f502ZP/vG4BxoCPKuKw868cuYkzDz7yKzIcEl5Ib1uQ4YrZRP/XjJYdR2V+cUM8Sxy2d3JwgoTTMWolbSM7YIt8Cc3AVDhz+8AJbNOOj96fMx7Uu/fL5Gv6jkWl26OoZvCYy/xukop6YFuSsjQIvEzlRCRznePGBLHbvz7tDdI5LNNXja6qFk17XPb964cHcSL8ewSM1hAWYvOwgp/BjCi76mkustPTn4eCp6RNGCCBRLpSCtb0sQ81Kx6LpnrIuo4KTkFm8i8eoM4bS2H4+avMT6cN1ldJk+v6Rku36HRfVC0j7U8ZzLhxx63wQxqvx0nQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HDWPZgW3PnKuc7oxBCrFOLRo1A13WwxHzKdhk1RsW7s=;
 b=WSZDtnZoWD3OpFYyzvg9KecxR6aMH053qBkmNPbRz3xKB8G3/+4NvIvhLhm5VW2hCpEhdYQPqAhPSLCMhZecx2fZ0ddoFsoEs+9daGVi3Q2VH5pVecepLyPGSqVrR6Ie3ZdAYL+7Klfr5skpp3PdOlQXyTW2LB1/AQr2kWn4knwi9gUKot2NpxN3UEVL3ix+Xn8RZ1+cTLNFVWsCOyLpfpB4m93XFLbQiWHlTL+BOJOjXE64WUE2rgkDtm1Ix73N/KTWB86pv86S/6BRxY9HP1wcZMojbkil3eaGnumF0opQTyxV3wfsuGkGeXGbFqMSwyR7QhtGpTvThvUZiGeTaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <15a53720-4dd1-3139-5d78-5b8a5704a953@suse.com>
Date: Thu, 7 Apr 2022 09:50:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <6739cf19-a74a-208d-82e8-28dfde7710f5@suse.com>
 <Yk6VvXJHWxJZTgeF@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk6VvXJHWxJZTgeF@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0502CA0068.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::45) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa2f8c89-4eb4-4073-5e9c-08da186b3c57
X-MS-TrafficTypeDiagnostic: VI1PR04MB3069:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3069F39512C1620E3CE33F06B3E69@VI1PR04MB3069.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	99cF1vQtIfoOm3T7vM6C9EcoEghYmAyj/e4eipBFR/bJa7yyey24tj8I2hKu3vGmORVrc0jzh5wnyMA3e8ogTdZXyutXLnKldyjCMn6EhuUOz1HOyZMLHjl1sqov4jcAKOJLr9v599rttooeCV4pBg5+3BREuN86UjWoxtQgTW+9j33oli4dAF2g2u5AtigylsjCqBhCktpSX8IITGuQ2lP/NwuCfflhsy8oIabMvdA++qutTwea/OTC0/KdQ1eMMFdef8o530z/WgJW2QEgASBMmdUHC/reKiGMEGkBE9CgTatWFctykcUmHaio81qiVfHYGvgbItS4fkytKZQhct4MQCTxjww6Jh772SFr6XpYLzoQM4WFLUelYjewvTJ9CjIAugsmEBCEIvB5roeumaVBcwgxedQ85PvIIClo9qChtjeB2zE31LHII+wKp0rfIE6stwUIx05Gp21j6xkJ2wWtVStMV43xpL/e6WLjL4z+ZOWkjc3XD+25xrE11TEk3B7QlwsYeG1ZDoUoVgnPBYecRl0tdAVVXsSR9tgfZPAeroM6In/SnNMfHzd7JVIaAuWQTIO7WHSYmpiKIeEHvFJ35OJzC/SkOUeOaE6AiaMNRwjMhieP/Jhd8HXWv2pWwg1QYB2sCRf49FOBod7LVthx92pwndbP/nV+VjM6k3zJZodxnZlnriAjlOxtIS3KsycnESr+s59IeHiQJz/KKGfCDuiy/I52zzH37a4uBN7IG1Vla0cBPvoRxfYY/x3p
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(6916009)(2616005)(54906003)(6486002)(5660300002)(6506007)(316002)(508600001)(53546011)(6512007)(83380400001)(31696002)(2906002)(86362001)(26005)(36756003)(66476007)(4326008)(66556008)(66946007)(8936002)(31686004)(8676002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?e2q3K7K/dcBhNbO5RnuGJSn3+KmMhSCVF+Bf0N7FQAj9sSwcLIL6fa58fUc6?=
 =?us-ascii?Q?qFAh3+lFpRRtJ0jtyW/pPsjitScPZk5pIhWelC7+uibKxHY6G6b0Vk7G7GB/?=
 =?us-ascii?Q?2lYTZMlIus2Ivg+H0A+n9TQIZcoPovzhvdmkEccRJFkGQ6O0pDFeeQ1Wbgjh?=
 =?us-ascii?Q?MFD6xFa+OefSsNBx7PIkptk0QrEvsPcMtiideiBYXyOSnWQHqQ48OLYBBBDl?=
 =?us-ascii?Q?qv5gEZOpM9fLSpeUp+j7v/x8TWjUasq28f9SSOW26ec4PqPCgLiZY+ZKxSRa?=
 =?us-ascii?Q?lQg8Le12GE8LTqQtLizNGgvI3cMnVgidrXgUaounuroKuOSm6nt0VLcnJ2en?=
 =?us-ascii?Q?edWxBgVK7PClh8Qrb+dQQGnlay2BYar1APIyT56edJneJtUIxOkV36In5wMN?=
 =?us-ascii?Q?52lhJvGFg61/r1ZLJWboU23qGlpFbgq2aydt5oR9umAxtAYEP5xz3ZK2acyR?=
 =?us-ascii?Q?Sh14uNRk9oXNJdM6DZF7U7YUyFUZRyENxh05uAelT0B5DAH2Kz2LA0C+/6su?=
 =?us-ascii?Q?Y/T8lhpO0pODBW23GqlSSsBd9bNxYRSvkcpXjWH09cin4gmsCrHu3pZt9TV7?=
 =?us-ascii?Q?ZJTaBZ6UkwNA9RlpI+MI/6G/sOSeamtbfl6NOhf2hrGkXVuhzEujbyBlezj+?=
 =?us-ascii?Q?i0sE3jzRqBD3LXeBtNU4eFsmU/mD9O9LzxqJAkz/ULcrEh0/dz9vWHN05ErP?=
 =?us-ascii?Q?n46RmwXai2zXEW5cZU6jtbjZ1QPypGeSuvZWfuMYE6rYlKoH/rqZYSP9cMcH?=
 =?us-ascii?Q?tUrOD9tEP5Pf7SsTbWJfSfUulwSbBmy/Z9D5yQDItlYbSS97auJfbDDIDeYl?=
 =?us-ascii?Q?LaYy8bz/oJgLCsr1MPuySBvRLGW3CBWrYLwCJlWf8HaTo1KNLPk006HiiBcF?=
 =?us-ascii?Q?lBqekdikbTnyU2p8xmxbzU6XoWq/NytcSRHOokdynm909PbeOIiZzMOvC80i?=
 =?us-ascii?Q?xhgJPFEFfctWkfGO4E5/t2dGxQpva7sZBmagpsX85qwt+DQ4XMZu+z/GOxdI?=
 =?us-ascii?Q?4Fw3tlyOpaCu+6o8GP4GSlqW05Zyi44byUbYHrcJAnNkZZjQnaNKCdJy1JhI?=
 =?us-ascii?Q?DPwAX64USRi/F9V5mrKqi021W2IA2iZeRluXQfbLXJD4qpOKRkXkk+M2B0Os?=
 =?us-ascii?Q?K9x1yMyh2pcgRKSXHr3LwZFCxk9gxM3m5MFC4ldXL8fh+VogHuLcx+MpLED5?=
 =?us-ascii?Q?pG4S9LCG0pBoI9jVaEYs3jpd74vZ41kzhg6rh0kSBbh0pkD/+JQonQeTx52a?=
 =?us-ascii?Q?slU8p0cFCxf+p6I+8pSr2c9EQTJdpVs+y/64dgUTOXgTJTadrsSMaT1PDC0m?=
 =?us-ascii?Q?3QJKUnNXHaVdFB2C4se4a21dEhy73fXENirTCRWSLVmVhe+lEU1Jg52+bh7f?=
 =?us-ascii?Q?6RezLNgIJThENFDJAdWLAl9wFGF1TV9QI/Go7oZy0fLEPLix8KDL5m+2kMow?=
 =?us-ascii?Q?f6B6DAoQFW1N6GhcoAQRyHfoDy1L7zN7wnC/RrqI/kU/fJz+jJKykk8Q6hOP?=
 =?us-ascii?Q?o4SRysv3aFEGs0I/4huF4Z1DKd5Yi3l3d6dUUZL5GU5CXLXRv09bhcSIzfeD?=
 =?us-ascii?Q?G+pv6+P5OcT3xEQMe3pxqfKnxGm/tUku3JRbwu0OJ7ks2auiC+ntL+nJFcs8?=
 =?us-ascii?Q?mxql9/+syh8ud+Zvda9yPKZx5f2APs2sgs2Xii293Mp6L1S2LNgKmiPu0hgi?=
 =?us-ascii?Q?JkIVBhtqIQHwye4FCkQ5mHOFJWfLturTSOX7XONnidplOP8Z9GTTu/Y9+OmS?=
 =?us-ascii?Q?cL0jjZBqSg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa2f8c89-4eb4-4073-5e9c-08da186b3c57
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:50:08.0522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1EZAerDKxAHPdnzFP0nng5kkFL/6jpbnkv+VBKTIU2+qPm9Z5ukuuNe72Ce0lLMnmFYmX37Xe2ChapRbPj2hBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3069

On 07.04.2022 09:41, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 07, 2022 at 08:11:06AM +0200, Jan Beulich wrote:
>> First there's a printk() which actually wrongly uses pdev in the first
>> place: We want to log the coordinates of the (perhaps fake) device
>> acted upon, which may not be pdev.
>>
>> Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
>> device quarantine page tables (part I)") to add a domid_t parameter to
>> domain_context_unmap_one(): It's only used to pass back here via
>> me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again.
>>
>> Finally there's the invocation of domain_context_mapping_one(), which
>> needs to be passed the correct domain ID. Avoid taking that path when
>> pdev is NULL and the quarantine state is what would need restoring to.
>> This means we can't security-support PCI devices with RMRRs (if such
>> exist in practice) any longer.
>=20
> The sentence:
>=20
> "This means we can't security-support PCI devices with RMRRs"
>=20
> Seems too broad and could lead to confusion. So I would maybe use:
> "legacy PCI devices" or "non PCI Express devices".

Right. I did actually forget to either drop or edit that sentence. I've
now extended this to

"This means we can't security-support non-PCI-Express devices with RMRRs
 (if such exist in practice) any longer; note that as of trhe 1st of the
 two commits referenced below assigning them to DomU-s is unsupported
 anyway."

>> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
>> Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quaranti=
ning")
>> Coverity ID: 1503784
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 07:51:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 07:51:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300474.512565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncMvg-0003mo-AI; Thu, 07 Apr 2022 07:51:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300474.512565; Thu, 07 Apr 2022 07:51:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncMvg-0003mh-5m; Thu, 07 Apr 2022 07:51:44 +0000
Received: by outflank-mailman (input) for mailman id 300474;
 Thu, 07 Apr 2022 07:51:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncMvf-0003mZ-4R
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 07:51:43 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e9558aa-b647-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 09:51:41 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e9558aa-b647-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649317901;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=iuzz5TjosdkX7axvdCs2xyp2M77EnJ+zWOTnFVIIdZ0=;
  b=aEArxyl0X6/7k3VMAPjtmMW/H71YHH6dZfQOhpLB5wQJJQ0EJSfghVun
   urZPHOO3MzUzEKetkSbwJjCbhWHYSXXd5ChWkgzUpwvLrnhtqvGZwPwD/
   PmsVwcA5NPMuGCmU5dJLAmmmavRFkSTNOe7qRRd6mK4eTW58sm1Pkt5mm
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67655932
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:m9fQM66EjgUDZieBmhoUzAxRtBTHchMFZxGqfqrLsTDasY5as4F+v
 jdMWG/TPPuKMDCheookaY2xpE4Bv8OBzdA3SAU+pHxmHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThXFvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurTrFQd3GLLNt905eCMIMAdBIoBU2brYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQQqiDO
 ptCM1KDajzyeQBpYVw0BKgCker3n2bcfT5C81ea8P9fD2/7k1UqjemF3MDuUt+HW8RT2FqZr
 2Tu/mLlDxVcP9uaoRKd+2+orv/Cm2X8Qo16PL+y++NugVaT7ncOExBQXly+ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nJRqRWIMy
 V6mpvfCP2xMloKKZGC886jB+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm
 lhmuAB73uxO1pBTi81X6Hid21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshTVflhdwTXGY3h+Y1FAd7fbVUwZnY1QvEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/MmOdLsVpR1kvG5fTgAahwyRoATCnSWXFXZlByCmGbKhzy9+KTSuf9X1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClY+QzF+VqWJmNvMueVNxsxoqwsBx
 VnkMmdww1vjn3zXbwKMb3FocrT0Wphj63k8OEQR0ZyAghDPva7HAH8jSqYK
IronPort-HdrOrdr: A9a23:yM4SgqPl7ds3OsBcT1j155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu
 vi2iMLnUvqRZxRBf7Lc0UtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+XZgNdNvpfvHHeFAlYSi8eV56cm6XXJ3uBRr22urKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="67655932"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g65vN52xpCMMJKvKPHEoVC58q8HiPYH3IrH6dAm/pCjN0XYkQ+2pc4fbRRgsg3GqNZBHm0uW11UmfsX1iYszwcDCX+LFl45q8jK+sOLwwTPp/8TwG1qTFgxlmf+lCJOS5qdpjJbBKB9VCV+4a7YuWvjX4ABYKcbV7Z4Fqr7QacuVGwED0phZQH94QikYL2zsrXlYx55ET8VpzSRDO62Hq02vQlnQf0ffi+yLCSS/92oyCUfXmVahlCctzxve3dziohuJx/84PPxZVZOxzst+KLVSdEjLN1MvScMH/ekS05jKnBS8jT36cGqOmYkAg7D9ohbCtp/+Cjdo3VsyUdJOKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v2Kpg8y5RPcHqkiCNsY2dXAlF1DobT7TsFHypAPVAbM=;
 b=h+WWsf1RpIoro6nGPgT7A568UJ8gLZQn6uE/jc7iwRKYAwaZ+S65wO51zy6ECI9OX9idzWLbIEpsbW6V0OdB8UzKPVd79j8nRXDJuEDWGa3aISvcSMxSl9VzXawEwdEmXYsMXwzbKv4tJX5RewWA6zITjRFKMzmfkjv929BzWuJrX2a3y/RVdlUgnrrsoxtpZ8ryyZz3s2BQOkuTJQY8ISwwQLdYA6u0R0nhgP3tPb1huSItCvHrhN49rLa2WwBaL4zPqAsFa9V8JKqYxYWrTCBphuAr5GELzxytNQh+k/AYT66JkpK4cnu3TWxuviubBVRwNZLIp8j2CaRS1PcRCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=v2Kpg8y5RPcHqkiCNsY2dXAlF1DobT7TsFHypAPVAbM=;
 b=Zmspf28J79sWXcGD6CWSUk96mf14dnf7vH9wTNoNRSqYYaGSGX0/kCJviHmtMqqajWd6w0jXfgpbDPLfAfI/faq76N1qPTewmsscbkXVCXza07V0DhTk2HVXRJ1/nKKmA+x0oHKKcWMv/0EFFfJJV3gpyhWrpu2pmwuFDhV9sIU=
Date: Thu, 7 Apr 2022 09:51:30 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Paul
 Durrant <paul@xen.org>
Subject: Re: [PATCH v2 2/2] VT-d: avoid infinite recursion on
 domain_context_mapping_one() error path
Message-ID: <Yk6YAoxuOZ4Ejosm@Air-de-Roger>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <fcc51df9-0896-247b-d4ad-0de4db6c2a9c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fcc51df9-0896-247b-d4ad-0de4db6c2a9c@suse.com>
X-ClientProxiedBy: LO4P123CA0411.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ae49b020-6fc9-4e89-4404-08da186b7016
X-MS-TrafficTypeDiagnostic: MWHPR03MB2864:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <MWHPR03MB28640FB9FE502890E48131558FE69@MWHPR03MB2864.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HbLae0XiqwPkTNf3455rIdOPLi/v0rT9ZjWxAf8mz9YEKRt1mFyMI0UR6iG+XNQeDdtGF7jC3/194BbddUtaHSniaQGCRALzeYDw+e+lZUvZgWw/74QDufqcOKkgirDoTfk/JyK2Wtt5WQY5B4KocrGcJkMpij0D2Q5f4XIy39xJIms0yRv10uzNnU1670q8swVgiTZxm0/nnukKR+lUwriqVxwaCjQsYeFrfLm5yKJkx2z44SIIEeqH0KmxyN3gQyStVLprQZFgVVuXTVw0XgnxfjsWv04XoFkNbodkmD3MZH5oOrbqPDmxXU2IMwAm6UE8Fk37ggWe0GEnpls6dnM7EVUokv/q2xbsjhTEWi26QPBp4eEIfxhln8mpUP3d+BUh8vhxB05h1xY3WjK2Hb9p2/Mq2WXfPvtcXKr2VY8uv45Ks0N+r+2dMGF2hG0m53RY7ZLHz7mA0DAZupVEpVexffz1DM+iZpvwbaI1sdNH4wJyUjxoI5tflKfdQ50QBO0yaxULF6+9DxfdLWwJ5C3HFRmn2Ajupi/y8HKNxa0gYHipTIarbJjNg9X2PjXzRrnon2MENgRe5wjbGnIAMYx9FSMGo3mHpNj30GDDSEbeOK8Uf0RCQ2qeuTHn2a3X37HzImRxstJnhgpuD2BtwQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(26005)(6512007)(9686003)(6506007)(6666004)(186003)(2906002)(83380400001)(4744005)(8936002)(33716001)(5660300002)(6916009)(54906003)(316002)(8676002)(66946007)(4326008)(66476007)(66556008)(6486002)(86362001)(82960400001)(85182001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmxHZjM3cjVwZTNHalRpNGRaa1BEZW1LR3pMbCtMcW5VeVNneXRDemlnUjhp?=
 =?utf-8?B?a1N3ZFUxZGlMNWVyVE54QllVNkJ2TU56UnY5d2ZQZ1pyamczUTNTMEkvT1oy?=
 =?utf-8?B?WHBRdHpUR2RTUlMyb1kwa3MwTUlXV3V5OENqeTNpNTVnaDNwcDMyeU4yYXpm?=
 =?utf-8?B?cTF6eXl4OHBMalF3cGhaNzFCb0kydktGdWN3L2VCTlhNMVpzT2ZNVTJHcXdL?=
 =?utf-8?B?VUlWNzVLTXpTTml2cFZVcWtLQ1U0RWhxU1hSMHhQTWtUOHpMWFJTLy9PKytW?=
 =?utf-8?B?VlZmQ29XN0w3YnBzQnEwZEF3bTZEOTBETVo3M2VicFVCRWdrQVEzRklkT2Ny?=
 =?utf-8?B?YkQ2TEp6Nm03V0c3aGJ3U1pzd2JzbWNIc3Jtc1NSdHN4SENDaldRNGY1bFhW?=
 =?utf-8?B?b25uclNHSVRUT1JoT2wvT09xMTM2YllTM3dvVk81elBMUEtRakpWTE9zU09T?=
 =?utf-8?B?SVh1T2UyQnBWNlprcHFjQWRRai9yN0NNVEFoU1d5NGpSdmwyNStvWlhDUy9P?=
 =?utf-8?B?MEw4TG1YcUhJdENRTjl6TFNJZEMvS3hKb3RveEttZHdRclJROFlzeGduSENm?=
 =?utf-8?B?bGlReEQ3WVVHWjlLZ1NmMnFtdjRlZ1ZjMjNRQzBzQjJITWgzckM5TEZpeDA3?=
 =?utf-8?B?NDdPOWJlR2E2eFl6dnhaWGZqZXp1VStINmRIUnE4a1RETXhteWtGVnJmSFZl?=
 =?utf-8?B?U3Zva2FTb2tIaEN0RjZHUWRRclprTEtlRmw2SDBqTkl1TTljYTQ4RFNpbXdW?=
 =?utf-8?B?QmphZ3FUaVJvK1dnWUxPZlh5N1FPQXArY2lHK2RvV2NNRTBoWEM4WUdSb3Z4?=
 =?utf-8?B?VlVvQmdFbGMzUXZRb3Z1QVYwNEpzT1ZvQUxidCt1NE1ndXdMdHd0REtWK0hT?=
 =?utf-8?B?RUgzeGxacUtqYTlHdHhGQW5pc0dTZHE3NWsyK0Fzbm52cUJvbS9iUkRFNU0w?=
 =?utf-8?B?UmVDYVNvZEVvNE9GT2dqRXZPc2lSWDRHN0JoR2oyR0dERmJDS2sycmZjdnhS?=
 =?utf-8?B?OEloa2FzZ3VYUGpZUHpDbUpCL2FNaW9NT1NIQUJqNTV5UFphd1ZYMWtUUHlM?=
 =?utf-8?B?MGNKZ1YvbE9LdmdjYlg2TnhobWZrTHQ3UUZkMWZOVkJmSHM3dU51cnIxRzhs?=
 =?utf-8?B?N3RLODFzVDNjTCtSRkpNalk1L3NaUGk0bjNNK1gxKzB5aXRhWi93YWZUUHBz?=
 =?utf-8?B?bkJzL2JlNy9aaWhuT2I4S0M2VDB4YkVXaHJxRGdHTjJETGt4RmxCY1VtWE9l?=
 =?utf-8?B?RUo2U2tDakFPZUtid2QvSmxFSk03alN3SkpPaWFKeXR5Vld5WHRXdVB1K29V?=
 =?utf-8?B?RnNlOFY1SDF4MkpZeVBWaGxHUmpuL2FzSFV5WHpvaXhuSXF0VHVwdC9McVVD?=
 =?utf-8?B?M0VvUUUyRVZvTzhCZGl5dWl0aTBVOUZmZVRiM3JkVjZhc28wTVNYWVRXd1JQ?=
 =?utf-8?B?ckVvQTJmaE5ObGtDTWorN3hpYmt5RngwVGRRSmNVN2JEN1ZaR2NnZ3VpU1dl?=
 =?utf-8?B?RmMyTnNhRVlkeEprbkMrY3h2QTJhME5DdStVR01SR3ZsWUd5VWRxbVdCYXVr?=
 =?utf-8?B?NUJYSzZTcWFQRm5hOVlGd3BMbWFweGI3Uk9lWllTZzNxVERNRlQzUVEweXJx?=
 =?utf-8?B?Sk5Gd2N0dzU4YjUyYysvTElRRjFxeWh4WC9HTUhvWFVkVE9Ma3d2MjYzRUV4?=
 =?utf-8?B?bkJJN2xpZHdHTlpFYkxVdW5PeURodFU2aktzQ2xvNE95WGxOUWFWclAvbG4y?=
 =?utf-8?B?dVJqdXloaklTSlVUOGZYM3A4MmQzRUdKQzAzK0J5YktGZi9tdFlEa3A5THpV?=
 =?utf-8?B?dTVwYmxybGZWNkRDOCtGcmtiMllTUXdtSFU5T055bzBOMUhOeFN6Rjdrc3Vs?=
 =?utf-8?B?djZRY1QxZjdGSDFwaENINmNaVkZhUGhMNHh3V0t1dko5TFlMVkw2blA4aUI3?=
 =?utf-8?B?OUhxS3ZsMjdrUy83MURIK2ViYUgwRUp5Uk5EZW8wUlc2Mkl5YlU4b1UweW5H?=
 =?utf-8?B?T0UxL1NJekFWRFBRclRaaGN3ZlRaWVRNMHJYRTVsMklQOWJ0NC9oTndOV0Rr?=
 =?utf-8?B?UkdYT3lNYzFsQU1QQU1Iby94UnVrbjVMbm44WTI4d1BBQzNwcVFVeXNCelNO?=
 =?utf-8?B?RWRLeXNrQnRvcHNpTzgvaGFPTGdyTEVPanZURXhqV3pRdjFlT1hBdFUrelVE?=
 =?utf-8?B?dFdjVGJGWUgwbDNIQzlYNWU2TXBjLzB2WnFLYTJSRlM2WFhMUmJJdHpRY0Y2?=
 =?utf-8?B?VWNzc3Bqd0Y3NkxMWWZNeWt3S1l6dHpITW9CTUNuTkRNSzZxQTR5V3c4THMw?=
 =?utf-8?B?Z09KT2craFM0QUJyM3k1MGdMZlBVWTJUdDFTelZPbStBU2U5dUZzTFFjTVo3?=
 =?utf-8?Q?+M+64BcK96ATw0jc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ae49b020-6fc9-4e89-4404-08da186b7016
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:51:34.8358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zVL4ql0lp/P3ier1EXPebeJIzFrLM6z7UIljQa3hD1egYJFHgR6DGKj1B9UnwP9dLlODm4D0zWwCVXWl6gD6Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2864
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 08:11:45AM +0200, Jan Beulich wrote:
> Despite the comment there infinite recursion was still possible, by
> flip-flopping between two domains. This is because prev_dom is derived
> from the DID found in the context entry, which was already updated by
> the time error recovery is invoked. Simply introduce yet another mode
> flag to prevent rolling back an in-progress roll-back of a prior
> mapping attempt.
> 
> Also drop the existing recursion prevention for having been dead anyway:
> Earlier in the function we already bail when prev_dom == domain.

I wonder whether it would be cleaner to stash the previous context
entry if present and try to (re)set that one instead of recurring into
ourselves.

> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:03:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:03:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300487.512576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncN6t-000640-Le; Thu, 07 Apr 2022 08:03:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300487.512576; Thu, 07 Apr 2022 08:03:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncN6t-00063t-Hh; Thu, 07 Apr 2022 08:03:19 +0000
Received: by outflank-mailman (input) for mailman id 300487;
 Thu, 07 Apr 2022 08:03:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hdtG=UR=suse.de=colyli@srs-se1.protection.inumbo.net>)
 id 1ncN6s-00063n-D2
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:03:18 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2e7c4807-b649-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 10:03:17 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id BA7481F859;
 Thu,  7 Apr 2022 08:03:16 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4CF8613485;
 Thu,  7 Apr 2022 08:03:11 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id F2mtCL+aTmKlAgAAMHmgww
 (envelope-from <colyli@suse.de>); Thu, 07 Apr 2022 08:03:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e7c4807-b649-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1649318596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7k0z5t+RkWgzil40AtKwhJmpL0iBjAFtHXia6nIwjc8=;
	b=BFj1weRWNO0gJwf1a0jytpVaNV2SIOQyml/DNHaVaAYv+GWtC9RRp3Nkr1QhUY/V7QdLG9
	baoJsXmF2FufEolsvsTPwbwZ3Or5/MyPwA8jPnqPoYDtXH5U9TjRT7F8cNWLR3Nqx6fvJv
	Ws2fOIHqbo98FqfWwnQjig+YJFloGxM=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1649318596;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7k0z5t+RkWgzil40AtKwhJmpL0iBjAFtHXia6nIwjc8=;
	b=DjSOFiN41nmAx2XAVq/tnPaDKbkIhCw6FaIeWu9KyiZMi8ecy7DPyjacZPoBAIl6E7Jspy
	2pyi9oy0n8T7WCDA==
Message-ID: <9f91936a-7dd7-2ee6-3293-f199ada85210@suse.de>
Date: Thu, 7 Apr 2022 16:03:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH 22/27] block: refactor discard bio size limiting
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 nbd@other.debian.org, ceph-devel@vger.kernel.org,
 virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
 linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
 linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
 linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
 jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org,
 ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
 Jens Axboe <axboe@kernel.dk>
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-23-hch@lst.de>
From: Coly Li <colyli@suse.de>
In-Reply-To: <20220406060516.409838-23-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/6/22 2:05 PM, Christoph Hellwig wrote:
> Move all the logic to limit the discard bio size into a common helper
> so that it is better documented.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Coly Li <colyli@suse.de>


Thanks for the change.

Coly Li


> ---
>   block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
>   block/blk.h     | 14 ------------
>   2 files changed, 29 insertions(+), 44 deletions(-)
>
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 237d60d8b5857..2ae32a722851c 100644
> --- a/block/blk-lib.c
> +++ b/block/blk-lib.c
> @@ -10,6 +10,32 @@
>   
>   #include "blk.h"
>   
> +static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
> +{
> +	unsigned int discard_granularity =
> +		bdev_get_queue(bdev)->limits.discard_granularity;
> +	sector_t granularity_aligned_sector;
> +
> +	if (bdev_is_partition(bdev))
> +		sector += bdev->bd_start_sect;
> +
> +	granularity_aligned_sector =
> +		round_up(sector, discard_granularity >> SECTOR_SHIFT);
> +
> +	/*
> +	 * Make sure subsequent bios start aligned to the discard granularity if
> +	 * it needs to be split.
> +	 */
> +	if (granularity_aligned_sector != sector)
> +		return granularity_aligned_sector - sector;
> +
> +	/*
> +	 * Align the bio size to the discard granularity to make splitting the bio
> +	 * at discard granularity boundaries easier in the driver if needed.
> +	 */
> +	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
> +}
> +
>   int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
>   		sector_t nr_sects, gfp_t gfp_mask, int flags,
>   		struct bio **biop)
> @@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
>   	struct request_queue *q = bdev_get_queue(bdev);
>   	struct bio *bio = *biop;
>   	unsigned int op;
> -	sector_t bs_mask, part_offset = 0;
> +	sector_t bs_mask;
>   
>   	if (bdev_read_only(bdev))
>   		return -EPERM;
> @@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
>   	if (!nr_sects)
>   		return -EINVAL;
>   
> -	/* In case the discard request is in a partition */
> -	if (bdev_is_partition(bdev))
> -		part_offset = bdev->bd_start_sect;
> -
>   	while (nr_sects) {
> -		sector_t granularity_aligned_lba, req_sects;
> -		sector_t sector_mapped = sector + part_offset;
> -
> -		granularity_aligned_lba = round_up(sector_mapped,
> -				q->limits.discard_granularity >> SECTOR_SHIFT);
> -
> -		/*
> -		 * Check whether the discard bio starts at a discard_granularity
> -		 * aligned LBA,
> -		 * - If no: set (granularity_aligned_lba - sector_mapped) to
> -		 *   bi_size of the first split bio, then the second bio will
> -		 *   start at a discard_granularity aligned LBA on the device.
> -		 * - If yes: use bio_aligned_discard_max_sectors() as the max
> -		 *   possible bi_size of the first split bio. Then when this bio
> -		 *   is split in device drive, the split ones are very probably
> -		 *   to be aligned to discard_granularity of the device's queue.
> -		 */
> -		if (granularity_aligned_lba == sector_mapped)
> -			req_sects = min_t(sector_t, nr_sects,
> -					  bio_aligned_discard_max_sectors(q));
> -		else
> -			req_sects = min_t(sector_t, nr_sects,
> -					  granularity_aligned_lba - sector_mapped);
> -
> -		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
> +		sector_t req_sects =
> +			min(nr_sects, bio_discard_limit(bdev, sector));
>   
>   		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
>   		bio->bi_iter.bi_sector = sector;
> diff --git a/block/blk.h b/block/blk.h
> index 8ccbc6e076369..1fdc1d28e6d60 100644
> --- a/block/blk.h
> +++ b/block/blk.h
> @@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
>   	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
>   }
>   
> -/*
> - * The max bio size which is aligned to q->limits.discard_granularity. This
> - * is a hint to split large discard bio in generic block layer, then if device
> - * driver needs to split the discard bio into smaller ones, their bi_size can
> - * be very probably and easily aligned to discard_granularity of the device's
> - * queue.
> - */
> -static inline unsigned int bio_aligned_discard_max_sectors(
> -					struct request_queue *q)
> -{
> -	return round_down(UINT_MAX, q->limits.discard_granularity) >>
> -			SECTOR_SHIFT;
> -}
> -
>   /*
>    * Internal io_context interface
>    */




From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:19:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:19:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300493.512587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNLt-0007zb-W4; Thu, 07 Apr 2022 08:18:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300493.512587; Thu, 07 Apr 2022 08:18:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNLt-0007zU-Su; Thu, 07 Apr 2022 08:18:49 +0000
Received: by outflank-mailman (input) for mailman id 300493;
 Thu, 07 Apr 2022 08:18:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncNLs-0007zO-K5
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:18:48 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 57254402-b64b-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 10:18:47 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57254402-b64b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649319526;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=qY7FBTagxd4jhkKjTx/xVU9t2OTJ9bU81KNufS2Swck=;
  b=MjspBlR9jF9dUJC7gjvwzpn//Rz4Y5G9WXaR6z0Vk3npoHVkuSLGwNxu
   NfvfK8LH0vXJ6OQSQZeCfrMffGwOt48x0noz2YSvZaaNdRC+bj0djeKow
   BZ+yUvb/4DSbiT9ql5se9nmyasU6Sps/7Sz/Bmkz+zpeFf58Ybs9/cJqP
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68645317
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:45DzuKN8beG7Mg3vrR2Zl8FynXyQoLVcMsEvi/4bfWQNrUoq12RSz
 mYeCjiAPfrbZGamfdgiPI2w80JVuJWGmtVnTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tEw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zm
 OgKrIaVTCkQDqjnw7gCThdIHiQlMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmdu2p0VRKm2i
 8wxRwFiZRLBTg12ZU5JK59mvumur1X9bGgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSAzRKV/3TqgfXA9Qv5RYYTGbuQ5vNsxlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzW6qnOZuh8XW/JLDvY3rgqKz8LpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BVQEoqaewTFykxrK/9m+tJCYFIGpZanpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzl+PNl9J+D+Vc2JMi2aAzVHApchNI4+CJrVql
 ChVwpPOhAzi4HzkqcBsfAnvNOzxjxpmGGeF6bKKI3XH327wk5JEVdoNiAyS3G8zbq45lcbBO
 Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+SYW/Bq2JPoURO8EZmOq7EMdGPxP4M4fFyhZErE3CE
 c3DLZbE4YgyV8yLMwZat89CiOR2l0jSNEvYRIzhzgTP7FZtTCX9dFvxC3PXNrpRxPrd+G39q
 o8DX+PXm0Q3eLCvOUH/rN9MRW3m2FBmXPgaXeQMLbXdSuencUl8Y8LsLUQJJ9Q+z/sIzL+Rl
 px/M2cBoGfCabT8AVziQlhoaa/1XIY5qnQ+PCc2Ok2v1WRlaoGqhJrzvbNsFVX73ISPFcJJc
 sQ=
IronPort-HdrOrdr: A9a23:myXtBaoHzzZSQsiC6QZsuK8aV5vdL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBfhHPlOkPMs1NaZLXLbUQ6TQr2KgrGSpQEIdxeOlNK1tp
 0QDJSWaueAdGSS5PySiGLTc6dC/DDuytHVuQ609QYLcegFUdAE0+8vYTzrb3GeCTM2c6YRJd
 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoILSIly95FMzQjlPybAt/S
 zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+cwzqAVcBEYfmvrTo1qOag5BIDl8
 TNmQ4pO4BJ53bYbgiO0G7Q8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnZ
 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvtn+9KK1wUx4S1bpXXt
 WHVKrnlbdrmBKhHjvkV1BUsZCRti9ZJGbHfqAA0vbloQS+0koJjHfw//Zv70voxKhNNaWs2N
 60QpiA7Is+NvP+TZgNcNvpEvHHfVAkf3r3QRGvyBLcZeM6B04=
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68645317"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S3sBmV9vxh1iQ8gMCnWSoV2MxsgRIMxnVlrWp8Tw4tZefCemqwJsVyDji9QAYvEmHSQAgN3dackY4FwHz4ONDbRtwaiE8m8Z9L8mLJY5T6qCik/tqOyyx/0W390DOeKMF4RjrW0jgWI3dqbyVAsAHiXqnWnHXCmYK8OJ2STW21N9ED75e5lgMJiMvfGXWG+gvmXWul+sg8zA4/oTFN4oGI0c8Tc/EsLCUJHBSPUIYwPzne8Qyo1dgOr18J5HCOY3Pfd3BM3c7Au9Hhyml8QJrI4/aFfAhingXd+dNmdJcEN6ADEV3T8yCrru2mQxm5VPZgbQfPF6zW0zaUKrEn0fhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lnWFLCRmcqKxtQAxn4E6pLSOOXyBQJiiTqwqs5RlTYc=;
 b=DuC21If1ts/jw96UOCvM4sR8C16DlouV8gPFm4MmnvmF2bKvzWahXr1DT/lRp9i1cNE0hhJMscsFwANM0lnk0PniqKoqOIqUbiLKispA0dPQ8Tn2tVkgUHb2C7idDLD9NuEd47v3COyZnjyHFHJTHbzjGSV/eMqFMw/BTEpgAWJd6wROnfsMiNRyW2+HVuEMjkzHypFnWbA1EgqUL8XwLNUwq0S/Ywp4W4L1yms5+yei9mQhs6XJNZQr8q2+jmSAe4zLsZgpUE/5ncm4sxjQu3UdqQgd7kHnDUzXJIEAMbleh88ETgCpDRr1FSsh8/5c8rNUFJQ5bTm/G/psJ4+lsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lnWFLCRmcqKxtQAxn4E6pLSOOXyBQJiiTqwqs5RlTYc=;
 b=BOI8mPQ3UcpHNpmrn6tvFMZ7Qbnlfr8yyxY8CkoDvSMYhv/x44ouD4E6fbi5TvnzPGnvGJ8GemR4d8cLcbBDKi88NvJeBUrlfDBajAuk+JZM3mDl9+RpmggZVnApVE5dBJDsRQjirz00xYPHDr9YF3RphepuhfC6zVDfngr0x/Y=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH v2] platform/cpufreq: add public defines for CPUFREQ_SHARED_TYPE_
Date: Thu,  7 Apr 2022 10:18:28 +0200
Message-ID: <20220407081828.38747-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0053.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:152::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 66eed729-6337-4ed0-c6fa-08da186f384f
X-MS-TrafficTypeDiagnostic: BN6PR03MB3235:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB3235B872436456E78FFF09888FE69@BN6PR03MB3235.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Cc6cjepdoafVUuhOFe9MuilHAMC3tZJv+tYQ5za/z+h+irJRnqicBzUBT+bVfhztkFHl/z6TYhgmGJj6FDzYo6krUO7teH0jCN4lDeonJpNuHwlsvyfysR311xarVmwUfT7Pf6fOn7q/mawqz/KMXJC11X7rxhck6jBk8+ii3KPrt2ne7vhyLD3o0Oh6w/CEWthuueHA094rFbuEftFMYPSnH2snDrlXzVXNlClzMQFUuw6X6sgjXPyHIvEVXi1fsiHdteHS1xefXpu6VckvhDJUOUN/cNNGu65KwVLATsMiIL9pxgzU2keI8zdQ5pNHOpzzH5rFgfmUOK0zrTffA4paasuSwV/rGIvVAbrPhOPhAALUf3hjoSx9cJpsgc/iNpgdPHbvybeaXv5AKpoB381vuT8HyUY+Rg6O+F+E8l/1ESDizVJjYPqW+m29eUH5BGT3ubmRBHpGGda/xXb1Emlixd7nAWUNmi3e5kNDbD8a2NcgAuvOvSBo8fvZYPupiHE7RhWtPOrajsTGh/dejXv25s/Bb6rSxkNldDHWaQiK2MEEoMRYUVjzrxb1/LunHhmHSPxfOGQDeQaGxgz1yZvOtrQ7dpaXB9xS740db27WJF70WKZu7pG6A4s+F5EBoKK1RHC8o2Qq26hnSFF++g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(6916009)(54906003)(186003)(86362001)(26005)(83380400001)(2616005)(1076003)(316002)(6486002)(508600001)(6506007)(5660300002)(6666004)(4326008)(82960400001)(8936002)(2906002)(36756003)(8676002)(66556008)(66946007)(38100700002)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUxNdlZPVWtjbDAwWUhydkhMVHlKeWNqTCtVajdQcWRkVk55NHorYXdYMXRn?=
 =?utf-8?B?ME84cFk4YlhwdVlDZXVkbGxTZWRHU3VYajFMc2ZOM0lDT0JGMytjcER6bDc4?=
 =?utf-8?B?Z3grb3BYRlhEaGVNRFMxRFFrVlg2dGFvS0M0aE1pZDl1N1pta2huYXVOWXBy?=
 =?utf-8?B?aU56ajc3clJDcUltZTlTcXNERzNGaTYwaVZxVEdsajBGUmVnOWFLVlU3azNz?=
 =?utf-8?B?cXgweXNhTkM1dm1rMHVaT25tcGpqc1dvWVFKN0E5cjhXcXloR2YyN29peEF5?=
 =?utf-8?B?NHI3REtWaHJ1bW1WNy9GL1NQQlU1SEpqM0NkZWZlSlYxL0luQ0g1bW00MlhS?=
 =?utf-8?B?N0hvUlVMdzN0d05iZzJDS1RhZm5IcngwTElvQm93OUxjK1ZrcTNSYmYzRVg3?=
 =?utf-8?B?YjIwS210Z0lPbG5CNE8rN3ZtR0tIQXI4bjVDNHhyNkRkV2JKTURnSjlvTHph?=
 =?utf-8?B?QTNVL1doL3REcG5wUVZJNlVjR3ZBMlM3b1pnblVvRXVqQ0p4Qks2QWpWbElY?=
 =?utf-8?B?ZXljWjhFQkgyNGNvMUd5bUdaRTI2eTZmZDJnYVplMWo4aC9NNUFFZXJXN1ln?=
 =?utf-8?B?cTNpbDU5TVAvaE1FdWhWU2dwQnBjblNoS0kzWEt3SnNtVmt2YXdMYU9Jd3RT?=
 =?utf-8?B?K3JqV2d1U20yQlZBWEJYNjZoNjV5NlY3bkpuSXMzQ3lyZy8xeGFtbUIyejFI?=
 =?utf-8?B?RFMvZWQ1RXkwM0ZjbTNDN21YR0xiTVNtUnhGZFNDY0Q4K0x4WXFZUnBuaExR?=
 =?utf-8?B?QmRrNUFpZzhJU1pDQjhOUzJWeGZUSVl5R1BkNFovalBudVMyc2pORmVMZ0hY?=
 =?utf-8?B?cHFIV1VJcmIrMUFucUlLTzNDRXh0RmVyckVjVEUrMlhpTVdCUFNaaUdYT2Vt?=
 =?utf-8?B?ZitXeTVZMU9BTzRlL05OdGd3QzZnNWJIZC9MTy81UHhvNDRDZWhrYnpqekF3?=
 =?utf-8?B?WUNFNjBZQlRSTUFVMURETm85SFFJN0x1Q0FLdml1Y1FjWnhZN29kWlZib2N6?=
 =?utf-8?B?MXRxcm1jVUl6aFA4WWpLdm01aHVDU2JVb2ViL3lmS0MrOWlvUW9NbU16enJU?=
 =?utf-8?B?amJZNDVVNGN0MFNUYmRnZGdhajRabzJhc3V3R2hOWVhTdHlreFE5WWV0V3du?=
 =?utf-8?B?eVA3dVcvdWthK2toYVdvR2xBek1VVEJlYjEyNUpCRVZGM3EvZ01MQXhHSDBG?=
 =?utf-8?B?Q09YdDF0dStlRkR6L2QraXEvbXliTVBEdXhLU0ZkaTllRnh1aEdnSFlpN3Z4?=
 =?utf-8?B?S2cvdDVsT1ZNT0djOVlvVFBXQWRDc1gzSk01cGtCb1R1THFNS2RYc2x0bWtt?=
 =?utf-8?B?a3d1RndSZXo1OHYwOVhQWUtFU0wrTVNZTWF3WFd0eTM2bDZKTkx4NE54RXEy?=
 =?utf-8?B?dU5tOFNqQnNOOTVZZkY3WDVJTE40MzhrTitucE1pNXgzNHBCemxhbklEQWs5?=
 =?utf-8?B?dnA2MTRKL3NWazhiVUZtdzN6ckVEeTlCN1JGOURpLzVQOFQ3M3JDTFdPR2NN?=
 =?utf-8?B?N2RtWTQvZHVkQkFncE9JZG5WN0ZIUmd0UU5jMk1jeFBmdzd5NlVPUHEreTN0?=
 =?utf-8?B?M1c3WDFqejhiQkgrSmpTeFNuMTIyREtJcks5M2RRYWZJbko2MXFlTHNwMEF2?=
 =?utf-8?B?R0o3VFlROUN5U2ZkMmJWU2lFTDNvM2UxRXpZeEl6OWVjV3RqaUVveHhiYStr?=
 =?utf-8?B?QkVyS01mcDZCSlBkeTJoeEoycEo1VlFPN0pCckI0dTgrKzY3V3JodjJwNG41?=
 =?utf-8?B?YjJybXFCQjRzdEE4cWsrTlA0Z1FsQm9BYWtMUGxFYlJMaG9od2M1bUo1bW8x?=
 =?utf-8?B?K1RBWUZFV3hXQjIvZDVSMzJOVko0UjlWNWRNU01ZeDBzeXQ1dThLVlhieldj?=
 =?utf-8?B?WFZQMDRobFlJcGtxNlRSKzdwQUVoMDBpMk13ZTUzTGZQQ2JIMUlZb0EzbmpY?=
 =?utf-8?B?TllOMjNrTDJsbmFGNlhMT3hGN3FQSUdQN1RXWkZqZGhSV0g5WjEwZWdpSnJG?=
 =?utf-8?B?UWlRQ1dhK1BTUDZqc3JSRFJseUMwYUQvaW5HekRvZVF2TDhHR2tuMzVWZUVo?=
 =?utf-8?B?Nm8wdkUrWFVmV3Q5NVBMbWgyYm1qbkRWL3RRRTJYZjZXUitTL1hTUXdjL2xo?=
 =?utf-8?B?RExHMUxFa3FsbTNTRWxrSjZnY1lXb2tWV0F0SVdlOS8rbjhUZGY2TmdyMWl2?=
 =?utf-8?B?UE95Yk11MVpZNi9OV1hmRGcyKzhWZVp2emtVT2hkeVhYVjRnRGhWK2NkRWFB?=
 =?utf-8?B?UlF6SGFGK2FaeU11SStxay94amNURzRBemMxUVNHZGcwSWFMKzJKSjZSd2hz?=
 =?utf-8?B?THNmOUhLWE1Obzc0L3ZvRE1xbXVPcGZTQWo0aDE5NjRvT2xxN1BUd25aaDVr?=
 =?utf-8?Q?0kImyv53j2h1Mgaw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 66eed729-6337-4ed0-c6fa-08da186f384f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 08:18:39.3410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S1slDTW3ka4/xtusxo0OB1QNN2hLbgLQJ0WFF2fxYhT2BINgmUSDi0c5RjpwTCsrGFQS5OoLtW6JDJVfwBHHPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3235
X-OriginatorOrg: citrix.com

The values set in the shared_type field of xen_processor_performance
have so far relied on Xen and Linux having the same
CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
public interface.

Formalize by adding the defines for the allowed values in the public
header, while renaming them to use the XEN_CPUPERF_SHARED_TYPE_ prefix
for clarity.

Set the Xen internal defines for CPUFREQ_SHARED_TYPE_ using the newly
introduced XEN_CPUPERF_SHARED_TYPE_ public defines in order to avoid
unnecessary code churn.  While there also drop
CPUFREQ_SHARED_TYPE_NONE as it's unused.

Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Keep CPUFREQ_SHARED_TYPE_ and define them on top of
   XEN_CPUPERF_SHARED_TYPE_.
 - Use CPUPERF instead of plain PERF.
---
 xen/include/acpi/cpufreq/cpufreq.h | 7 +++----
 xen/include/public/platform.h      | 6 +++++-
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h
index e5e58c6c30..35dcf21e8f 100644
--- a/xen/include/acpi/cpufreq/cpufreq.h
+++ b/xen/include/acpi/cpufreq/cpufreq.h
@@ -78,10 +78,9 @@ DECLARE_PER_CPU(struct cpufreq_policy *, cpufreq_cpu_policy);
 extern int __cpufreq_set_policy(struct cpufreq_policy *data,
                                 struct cpufreq_policy *policy);
 
-#define CPUFREQ_SHARED_TYPE_NONE (0) /* None */
-#define CPUFREQ_SHARED_TYPE_HW   (1) /* HW does needed coordination */
-#define CPUFREQ_SHARED_TYPE_ALL  (2) /* All dependent CPUs should set freq */
-#define CPUFREQ_SHARED_TYPE_ANY  (3) /* Freq can be set from any dependent CPU*/
+#define CPUFREQ_SHARED_TYPE_HW   XEN_CPUPERF_SHARED_TYPE_HW
+#define CPUFREQ_SHARED_TYPE_ALL  XEN_CPUPERF_SHARED_TYPE_ALL
+#define CPUFREQ_SHARED_TYPE_ANY  XEN_CPUPERF_SHARED_TYPE_ANY
 
 /******************** cpufreq transition notifiers *******************/
 
diff --git a/xen/include/public/platform.h b/xen/include/public/platform.h
index a4c0eb6224..8100133509 100644
--- a/xen/include/public/platform.h
+++ b/xen/include/public/platform.h
@@ -465,7 +465,11 @@ struct xen_processor_performance {
     uint32_t state_count;     /* total available performance states */
     XEN_GUEST_HANDLE(xen_processor_px_t) states;
     struct xen_psd_package domain_info;
-    uint32_t shared_type;     /* coordination type of this processor */
+    /* Coordination type of this processor */
+#define XEN_CPUPERF_SHARED_TYPE_HW   1 /* HW does needed coordination */
+#define XEN_CPUPERF_SHARED_TYPE_ALL  2 /* All dependent CPUs should set freq */
+#define XEN_CPUPERF_SHARED_TYPE_ANY  3 /* Freq can be set from any dependent CPU */
+    uint32_t shared_type;
 };
 typedef struct xen_processor_performance xen_processor_performance_t;
 DEFINE_XEN_GUEST_HANDLE(xen_processor_performance_t);
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:23:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:23:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300499.512598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNQE-00011N-Lp; Thu, 07 Apr 2022 08:23:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300499.512598; Thu, 07 Apr 2022 08:23:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNQE-00011G-Ic; Thu, 07 Apr 2022 08:23:18 +0000
Received: by outflank-mailman (input) for mailman id 300499;
 Thu, 07 Apr 2022 08:23:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1UeT=UR=redhat.com=david@srs-se1.protection.inumbo.net>)
 id 1ncNQC-00011A-Tl
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:23:16 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f83cf557-b64b-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 10:23:15 +0200 (CEST)
Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com
 [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-653-eU60n2h0NsK9eSJoalqmpw-1; Thu, 07 Apr 2022 04:23:11 -0400
Received: by mail-wr1-f70.google.com with SMTP id
 j67-20020adf9149000000b00203e6b7d151so1028014wrj.13
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 01:23:10 -0700 (PDT)
Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8?
 ([2a09:80c0:192:0:20af:34be:985b:b6c8])
 by smtp.gmail.com with ESMTPSA id
 k11-20020a5d6d4b000000b0020599079f68sm16415621wri.106.2022.04.07.01.23.08
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Apr 2022 01:23:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f83cf557-b64b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649319794;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6Ak2L++rWGA7iZB3bqmGGUjd7xVRHy3vUvtqw/fn7ZM=;
	b=ZU6tbuVq0bVIwesQJrqY9aWA4JgQ8BUeFWseLDHAHUrZTSeTKN91nn9E1o1xaHrvJ8zORD
	Dl7Q8tyl8BXmNOmXGv8+h+C1wyzE+mwx1pDiNfzdpZQZdbT0FEBBB8dvNUgwnG3S8L7Ner
	qQYyVtrh6TG4XN/WBuib+EzKSGS7CBc=
X-MC-Unique: eU60n2h0NsK9eSJoalqmpw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent
         :content-language:to:cc:references:from:organization:subject
         :in-reply-to:content-transfer-encoding;
        bh=6Ak2L++rWGA7iZB3bqmGGUjd7xVRHy3vUvtqw/fn7ZM=;
        b=MbScjmV87BxkF8D16KgXpUDleJ/IHTOtIQ0r8JbdDikxIdKRXOnoWvnzi+3NQLxFCk
         omekUVvnWb+3vKsNP7Utks8NM4BS9495b8kHndEw3BC1iII3LxCftySNjZlSXiGGjAPX
         j1404MDSxSW4sse2BpIDueiGOmTzJ/wFbPARN0fp3XxN3d+Zyo2vkpt6k51Zky+O7iRt
         10TAonAbIHBH+op+/SxMwjhb+KHUmyKJJMPMedAujHHjgwnlfybF1LYuLKt/5zj+jMRY
         bCKzjgx4pQr6j8RpHg+qSbWAOejxfWKbyRaR0DnOJDdWrVJ6hjMO3WxvtSRwe9a0GUa5
         WOsQ==
X-Gm-Message-State: AOAM530IO10LRHgEMw91eHqOp7qeovmuY2SjkQnKk8E86V/x/rUQKmbU
	2hYXq6x2W/AcXKd7bTTG3BL3R7IDCGS2mxNoRYrLk+glY2viWNx6pHkb7YAH30pJstQmZSuTgq4
	22pR5nXg07PRvYWIyqpvRwkHjTL8=
X-Received: by 2002:adf:8046:0:b0:205:db94:4766 with SMTP id 64-20020adf8046000000b00205db944766mr9967290wrk.565.1649319789914;
        Thu, 07 Apr 2022 01:23:09 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx2Tu0tp6Y15gnR0aUGERxnoLQ64ptBmMTawYi6J5rkgZz3tkxFuWT9Vp/1zCYi8qjcSciYkA==
X-Received: by 2002:adf:8046:0:b0:205:db94:4766 with SMTP id 64-20020adf8046000000b00205db944766mr9967251wrk.565.1649319789519;
        Thu, 07 Apr 2022 01:23:09 -0700 (PDT)
Message-ID: <89ad978d-e95e-d3ea-5c8f-acf4b28f992c@redhat.com>
Date: Thu, 7 Apr 2022 10:23:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Wei Yang <richard.weiyang@gmail.com>,
 Michal Hocko <mhocko@kernel.org>
References: <20220406133229.15979-1-jgross@suse.com>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat
Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone
In-Reply-To: <20220406133229.15979-1-jgross@suse.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06.04.22 15:32, Juergen Gross wrote:
> When onlining a new memory page in a guest the Xen balloon driver is
> adding it to the ballooned pages instead making it available to be
> used immediately. This is meant to enable to add a new upper memory
> limit to a guest via hotplugging memory, without having to assign the
> new memory in one go.
> 
> In case the upper memory limit will be raised above 4G, the new memory
> will populate the ZONE_NORMAL memory zone, which wasn't populated
> before. The newly populated zone won't be added to the list of zones
> looked at by the page allocator though, as only zones with available
> memory are being added, and the memory isn't yet available as it is
> ballooned out.

I think we just recently discussed these corner cases on the -mm list.
The issue is having effectively populated zones without manages pages
because everything is inflated in a balloon.

That can theoretically also happen when managing to fully inflate the
balloon in one zone and then, somehow, the zones get rebuilt.

build_zonerefs_node() documents "Add all populated zones of a node to
the zonelist" but checks for managed zones, which is wrong.

See https://lkml.kernel.org/r/20220201070044.zbm3obsoimhz3xd3@master

> 
> This will result in the new memory being assigned to the guest, but
> without the allocator being able to use it.
> 
> When running as a PV guest the situation is even worse: when having
> been started with less memory than allowed, and the upper limit being
> lower than 4G, ballooning up will have the same effect as hotplugging
> new memory. This is due to the usage of the zone device functionality
> since commit 9e2369c06c8a ("xen: add helpers to allocate unpopulated
> memory") for creating mappings of other guest's pages, which as a side
> effect is being used for PV guest ballooning, too.
> 
> Fix this by checking in xen_online_page() whether the new memory page
> will be the first in a new zone. If this is the case, add another page
> to the balloon and use the first memory page of the new chunk as a
> replacement for this now ballooned out page. This will result in the
> newly populated zone containing one page being available for the page
> allocator, which in turn will lead to the zone being added to the
> allocator.

This somehow feels like a hack for something that should be handled in
the core instead :/


-- 
Thanks,

David / dhildenb



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:25:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:25:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300503.512609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNSe-0001d6-4T; Thu, 07 Apr 2022 08:25:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300503.512609; Thu, 07 Apr 2022 08:25:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNSd-0001cz-W6; Thu, 07 Apr 2022 08:25:47 +0000
Received: by outflank-mailman (input) for mailman id 300503;
 Thu, 07 Apr 2022 08:25:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WyQK=UR=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ncNSc-0001cq-M4
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:25:46 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on061f.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::61f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 51ae8211-b64c-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 10:25:45 +0200 (CEST)
Received: from AS8P250CA0003.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::8)
 by VE1PR08MB5807.eurprd08.prod.outlook.com (2603:10a6:800:1b2::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 08:25:41 +0000
Received: from VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:330:cafe::93) by AS8P250CA0003.outlook.office365.com
 (2603:10a6:20b:330::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22 via Frontend
 Transport; Thu, 7 Apr 2022 08:25:41 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT034.mail.protection.outlook.com (10.152.18.85) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Thu, 7 Apr 2022 08:25:40 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Thu, 07 Apr 2022 08:25:40 +0000
Received: from f6342b574644.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4FED5E74-749B-4C8C-B41F-5ADC526EB92A.1; 
 Thu, 07 Apr 2022 08:25:29 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f6342b574644.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Apr 2022 08:25:29 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM0PR08MB3011.eurprd08.prod.outlook.com (2603:10a6:208:64::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 08:25:27 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 08:25:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51ae8211-b64c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kBfftMvijzxMFWX18I6SGsfEneQUU14yaAzJ8zmWfns=;
 b=GwOzeHG9nvdf0gQ2s6l2F2BQh9AArO/8eUQnn+GHe36HttFhATL98DdnQkf/oXHohsqilJGl2EE3EfbXFsS1sV6cs0+kkTOiUVDDKsLLCFdVd2kbUqdeGAxB/6ff41RR7ZU0tUNuITAgsCDuwUp21GJDCIS9rt25yPzeHQg4BFo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a09748658cc7ad8b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IpKnxRVvcuhCK8D76qHQmdjtzQnRgXS1l2ogTUJCVhc91yqrWGN0szkSTxvybWEDd224jrGq57YFKUQJfd4RP+7I8DSmoqOOnXmpEmMsk6d4wpXODepx4se3tNjTaCBIoIzKzSBLPm/SFPAdW5FSVCU9ljR3JMdAPM8I+B0TN+ZaLCuzgi30nucw82kZVnpWRd+LDwLxAOS4nMQ5UyZ7OIvuXGJKAUIzpVPAnJLxGzV9GCltK/nqBzFNfhssRLBLxSr3723WR2xh33Bza+VR8u3iC02oITkJngaS4NBi26ywNARHusQM2MlQqNc7Z3kiq11uj2f0+I1yL0QGySSk6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kBfftMvijzxMFWX18I6SGsfEneQUU14yaAzJ8zmWfns=;
 b=OI5UiCOnxYNaJLKw/6ezNzbOam4lLOnwRDLj2zYsKJrYxAlfhy1SEIkMwylf52bHOb0KV3jfthziMEQTX72udn+psI1Z3KRYEr6ufl95+B/eQywCezAblezCHL+MmzepnKObCZGSDYFfrpsRRw4iXGqgcFsDB4W21sffpTJM8Vok6mwHE5XnbJ/a41odSl5F3fbDmsVjkrYS5ieCS7vPjZLZ8irXUMRDTQl8odnajQzmxPscQcXm5F/xn4Tj+9pfHZwpb4DwRIPWWj9Fd8o+ttR0ILfwErnYA0tm3j2APZhLaJge29O6190W85QVRSSAluOB/3XPn5sxTN/d57F0gg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kBfftMvijzxMFWX18I6SGsfEneQUU14yaAzJ8zmWfns=;
 b=GwOzeHG9nvdf0gQ2s6l2F2BQh9AArO/8eUQnn+GHe36HttFhATL98DdnQkf/oXHohsqilJGl2EE3EfbXFsS1sV6cs0+kkTOiUVDDKsLLCFdVd2kbUqdeGAxB/6ff41RR7ZU0tUNuITAgsCDuwUp21GJDCIS9rt25yPzeHQg4BFo=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Juergen Gross <jgross@suse.com>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Dario
 Faggioli <dfaggioli@suse.com>, George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v5 2/6] xen/sched: create public function for cpupools
 creation
Thread-Topic: [PATCH v5 2/6] xen/sched: create public function for cpupools
 creation
Thread-Index: AQHYSMtc+gOWASCxzkqv6vdg7Z4J9Kzj+f2AgAAme4A=
Date: Thu, 7 Apr 2022 08:25:26 +0000
Message-ID: <E9AE3F33-F828-49FE-9270-559A268FCFD8@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-3-luca.fancellu@arm.com>
 <9e776738-7e54-27ad-0a41-dc5cf8669510@suse.com>
In-Reply-To: <9e776738-7e54-27ad-0a41-dc5cf8669510@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: c2422e45-a3df-4cce-4592-08da187033a9
x-ms-traffictypediagnostic:
	AM0PR08MB3011:EE_|VE1EUR03FT034:EE_|VE1PR08MB5807:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB5807D7425324CEC43DE93783E4E69@VE1PR08MB5807.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 FXZsJzZJQLAstSgAtI11EjvY0I8Ok3vGlR0veMTSCLnEW6CAWLbueSCPsxQdgLSy7HiD0P4ob9prX8k1fnS+ijtOI9d2D3TniSR4TKvNjuth0w6N6aoi+1GTdk1CWNc6kC+qywSCVQFxu5F4gi3qAK8VRq5vnAaFnvBMp3yzf1dG2Xf3yZWQn790zziHmX+Sv1LyU3pdBI3Y6KYyGxyRP2BwfEkXubNRPtpqC3K1VXw7b45kuKD7N4SM074fpXOLFVY4VJhzJRAWh2YBd+twCx7j+5+lUP0i+ddy+9DGGI3lz1GEOP+p3P5v9wuB5LkVzI4Gog65c0Gw2EpwIXEccXrFHVfBKxv3jSPP9FU8Pf3Gd8Rtyjspt++QXQ0yHoxK48FQex0+yGWTn0OMBaS7pvp0B3mwfMsVPyY4MmwX8OQuSbM43x7fd7IqsBej2qtThiu3p7AXLSs3hzV9oOTXHEm1n+uDiPhw7d0YGPAVxYVgr5X/pwuEbpN/coo98Lp0yGmMvbQt2wf3zP2zn1rVU9XdW0ix01z7znqrznmPl8zXEzRD98vZm/qVkg53NeobqS04BCirCASTYzocqWvku2qYAGjCwfhHC4Jj5Gi4B4NUykEGvqCfvhJFgpjddMlAez39u/rcxx1npHa+uZ3uB5xTkjuFW1F/doZQSB+gb5t79IoHWoNTUngSxa9ryNr/k7DOLVqlmeg4X+8xJfFRTW403c0pOCW/G0/jfGgtD3CLLA65xooWDYr8QjOu3fWw
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6506007)(4744005)(316002)(53546011)(2906002)(38070700005)(54906003)(8936002)(6916009)(5660300002)(2616005)(6512007)(38100700002)(66446008)(83380400001)(4326008)(66476007)(8676002)(64756008)(86362001)(33656002)(76116006)(66946007)(508600001)(91956017)(26005)(6486002)(186003)(122000001)(71200400001)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <066082DCCC534444B3EF841315173112@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3011
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	61636500-e6cc-450f-200d-08da18702b40
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1Zu5Bj7KrhEI7RCVHrxnvfqhbs9nUK+0rD1oDVLcUcme010URdyu05Et5Q8Tg3A/m9N0GYiVsM/bYbq1PQQqEQonYcwCuGiQttiLBb25Gh9AjaYNlZmSqREpyf4H5nRNUyzZlcdwesdrtoB88oEv3bzbUoj7IZfuyBp3w6tBzggic8OC6tts5U1S5iRfxvDYkIWKDH1HG0Ikzgnjf4K8X9nFsWs4yPisoOIQRb+qFPT6uR1CQRtLH5Ou/SfRp2e+TExus+7MWq7mly/ssZeofps5WMva/gRyN710Esmds/JvUE/CeKs3VHzUk0LFOpZjCQ2V7T4StGmfQp7abCxZddGG3P87u7WRgK2jhDFnEeyIrKKT6AF1VKdxB7rE4mRf4RPUY022M0qa957ysUHgWc14wILLtD8EnCGMRHOMGBBI0583F9hGf3AiOgxqku+F69rJWTu5jSZE3oZSP7DocrK0Cm//L9CRbpWkxrugeC0sTs3Dx1Y4HRuNrDQP+2Gw2GdGPIqRgRk+kiGvCpm5VY/HFV9EIhfs6BwfaJdbAUSCoxMvAtfnSTyAA2FemwI6n92bBQfwum5rQmUYZoEnR9uo/VpXGv1JCpmb7AlxARb72ptQRR0PaiKgKa7adfuu3nCLG4pKLNN7wCGKbAAKbGfz2JHyiInaKtVMCUHN9sn27uQdKBP3J9OIPNBG/Bju
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(4326008)(6862004)(86362001)(8676002)(70206006)(70586007)(2906002)(4744005)(81166007)(5660300002)(8936002)(356005)(336012)(83380400001)(40460700003)(54906003)(36860700001)(2616005)(6506007)(508600001)(6512007)(53546011)(26005)(186003)(47076005)(6486002)(316002)(36756003)(82310400005)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 08:25:40.7544
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c2422e45-a3df-4cce-4592-08da187033a9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5807



> On 7 Apr 2022, at 07:07, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 05.04.22 10:57, Luca Fancellu wrote:
>> Create new public function to create cpupools, can take as parameter
>> the scheduler id or a negative value that means the default Xen
>> scheduler will be used.
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>> Changes in v5:
>> - no changes
>> Changes in v4:
>> - no changes
>> Changes in v3:
>> - Fixed comment (Andrew)
>> Changes in v2:
>> - cpupool_create_pool doesn't check anymore for pool id uniqueness
>> before calling cpupool_create. Modified commit message accordingly
>=20
> I gave you my "Reviewed-by:" in V2 already.
>=20

Oh ok, I thought I had to drop it because of the change, I will retain it i=
n next
serie.

Cheers,
Luca

>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:26:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:26:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300506.512620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNTY-0002Ay-E9; Thu, 07 Apr 2022 08:26:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300506.512620; Thu, 07 Apr 2022 08:26:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNTY-0002Ar-9q; Thu, 07 Apr 2022 08:26:44 +0000
Received: by outflank-mailman (input) for mailman id 300506;
 Thu, 07 Apr 2022 08:26:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WyQK=UR=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ncNTX-0002Aj-0K
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:26:43 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0618.outbound.protection.outlook.com
 [2a01:111:f400:fe02::618])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 73b243b7-b64c-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 10:26:42 +0200 (CEST)
Received: from AS8PR05CA0029.eurprd05.prod.outlook.com (2603:10a6:20b:311::34)
 by VE1PR08MB4704.eurprd08.prod.outlook.com (2603:10a6:802:b0::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 08:26:31 +0000
Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:311:cafe::b0) by AS8PR05CA0029.outlook.office365.com
 (2603:10a6:20b:311::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22 via Frontend
 Transport; Thu, 7 Apr 2022 08:26:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Thu, 7 Apr 2022 08:26:31 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Thu, 07 Apr 2022 08:26:31 +0000
Received: from 29e1ab1c2663.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FE2F45BB-AEFE-47D8-AF50-9914C823A381.1; 
 Thu, 07 Apr 2022 08:26:20 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 29e1ab1c2663.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Apr 2022 08:26:20 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM0PR08MB3011.eurprd08.prod.outlook.com (2603:10a6:208:64::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 08:26:18 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 08:26:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73b243b7-b64c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gAf35f9MNqHW/6RMCK1wmqGwGM3tG+Fuo6ex+MaKSD4=;
 b=rBcBoMyIRJrRC0LzWf78EF/4+3FFpNi2wQCmaASKt4E+4rei7idsGoznDutBYC7phIiK2bBl/kmnjJ9Sy6gqRY3j6MzCauLFfL4BqWU8MpmNL6aLBl3D4uu6TRuAmjHJJwIkRTYTr1kXIZL7oe+20RfS1yuapnEzhlXFoSTy+0o=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9d1d0de6160579a9
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=miD2w7UPezTtTBxu47NXPTwDfZh2QRTbA1p5Ma3Gu+yWS0DOjPfxgc2fOVCIFbdqNq2FqEDKEa58892N9bNeO8jAMuaywgpmwBIftShX+LEOit07hRVKygOlrt/Tam8e7uUe7g0YbGNp24TCv8MQxT1FIzhNg8ufeaNvhSA6kVaPepobOoGjXL8WLZqprvWSYRwO2yjOQDEVQgKOj+EG2+ITCjWPjYxU1j4N9mmq2ZTDEj0l4RQWKwiAe+6QSBY9VZHgFooKXmZXohVB14DRXfc0XN1MdDJnVAN9jtEG32Alxi+wl97hKi4XVcdZZ6TiUYlb0FkRq/KA8H3wyE6mNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gAf35f9MNqHW/6RMCK1wmqGwGM3tG+Fuo6ex+MaKSD4=;
 b=MGTLkhXR7kbxvPDPmvuI3hnE9Q/kgzV+Btp4WvvaLT6Y4iHhwoMHiNQ2VLnq1e6DsSjBSfE0zXhirRZ7ojEGBDU+T0u7E7bQ94MMIz3SJWnOcxJyQwZAzUNJlV1UPs7RI50BaQWE7bcE1jQdz/70hGvJqin1Z9PsWI2hYOaAKH7zCseDVXIk/WgJWL8MzW7fAwnsi0HFtC6+bzHYhYN9UF3aOViXIV3YwMPVGHLXqKE4U7zM253XokD9sgZR+baIW++yYt2Xhu0N/3Wa4EV18rdOoon8GboEvDxCHHQ/7itNEx8Dr4nJTxxQudC664DZPv3XW5MyZ7g1JR6b/M069A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gAf35f9MNqHW/6RMCK1wmqGwGM3tG+Fuo6ex+MaKSD4=;
 b=rBcBoMyIRJrRC0LzWf78EF/4+3FFpNi2wQCmaASKt4E+4rei7idsGoznDutBYC7phIiK2bBl/kmnjJ9Sy6gqRY3j6MzCauLFfL4BqWU8MpmNL6aLBl3D4uu6TRuAmjHJJwIkRTYTr1kXIZL7oe+20RfS1yuapnEzhlXFoSTy+0o=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Anthony PERARD <anthony.perard@citrix.com>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v5 1/6] tools/cpupools: Give a name to unnamed cpupools
Thread-Topic: [PATCH v5 1/6] tools/cpupools: Give a name to unnamed cpupools
Thread-Index: AQHYSMtXyn8LVgjvo0+6iWYmcNxLBKzi+zCAgAElhoA=
Date: Thu, 7 Apr 2022 08:26:17 +0000
Message-ID: <DC9DBD73-6E4F-487E-A9C4-F86202059ED1@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-2-luca.fancellu@arm.com>
 <Yk2p73WCT5Gi85vK@perard.uk.xensource.com>
In-Reply-To: <Yk2p73WCT5Gi85vK@perard.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: fab108d5-9ae6-4ea1-cfe3-08da187051df
x-ms-traffictypediagnostic:
	AM0PR08MB3011:EE_|AM5EUR03FT007:EE_|VE1PR08MB4704:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB4704D6FC3A37A9792E846163E4E69@VE1PR08MB4704.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 XVGDJiXJwxupogkqUmojGcqw2tx6G6h7772JKHxBL2n/V9RmTPGGRmUSsbs6yh+LmrZxJ/ckNBkRcApC5D8fx92dwIq0zIb9kuBjdxfRgxoLX+TF9y9/JHSX18EVKKUxUAroNUCOOmPWkUuNKjyeMKCzNecRKwvbMumUhW2dJFeXTxc7ZHF2eGvdPxNIXdbd7hxIOnSLp1HbcESHLDe5Hr41lDmjjBKz8XvOtgxFfQSAcWB5zBVtC1RYG2O6hespJORGZ9fyBwl35otYVHcEJW1wor0STRgm3X8hkd95zOyBwFMQ/vzqOaw/QAzqOzn4Lk43rYSlLfR58WsF06LwHcCQ+xNWfzbZH+pnwqrgaPJKhtOpWVHL1ytUdFI2eO3IBQfB3GbTu5lQeQMFrDi74bvR9L8YV0i2JvcUK8fshUH0WpBVzLFukc+mZDf8lO+VgQTe8E7byz7ZH+20k4RhhHepC1Xc9W/h9n7jKTe+ZkANmL+h4Y/cVuNsvqY36S6yX+Re/ZHQu0vmiCayT3CEBV86QCisionIsATpSrC1y51OyQjMSqour99/fxiIK+dp32tF6uF8aAFAkAU6vj0NYrwsb9NiVOFEE5rJ+tiNQvkSKSvwCV5PBFCRq5rc1y1zQ9Q0K3X0DLzhGhqR0WFVfrZuK515mXKV2d9VZBy8qmSBPvd2u+c8GI/LfJ1CBZBxwHO99oincunSOA/QI+nDaj063e7G1M39jXdL963wOro=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6506007)(316002)(2906002)(38070700005)(54906003)(8936002)(6916009)(5660300002)(2616005)(6512007)(38100700002)(66446008)(4326008)(66476007)(8676002)(64756008)(86362001)(33656002)(76116006)(66946007)(508600001)(91956017)(26005)(6486002)(186003)(122000001)(71200400001)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C26EBC72DCBE4F4F9E773A2FAAD90D7D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3011
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	83db19ec-aaa2-40a7-2056-08da187049ce
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4iDYHEB+NmmFk7tiFj/9Iv3KZT8or04rkcamk93kjcxjAk/RMNy1wbJWyWm+OnO4KKjaWOZCAW9fJkFRJd9OyY/dhLcRVmOqs+BIPkOYZfGirJJHyeIaxiNIkCeJgN3kxiLjOva+SjyEtrTP/vlDHLK/at6TOiRC4oFvMVXUkbNNaH77HM6qjz7OblaTRgQDRMoXdKA4SCwsDFmvHsNmnogGvooY3X8AAzBq2GSbo7RsYJ6yVNa0MxVjSaRkh31m3zqxjPVaBh91iSCLmNevV6Iu7HukNmxB8WwIthUV/7bPz4VOfpekg386kBRf/0O2kJhY/Ko6q3jLDp6K2o4MasU4nQPB3G1nu9Yr3Tzv+EqFNsmEZ/fcg3rIy+9dWk3CXtQL9osQE+NTEmh2F79PDmMzY0gMkjtqOBXkVRSK5KwNY6NsLrBXBuphmrUND8Cz2TRIvWIA6FyuYAf4xKJDT4MIQzjbGOi/54oiKUHPXKtVJmE5O1zIko0bwJr1zGfh1hK/NqRLxzuF3sfY1x0Q+K+XqnGLsbLsZCI6eGZp2Lb6M6Rb9WOi0bQ98VphqkRpF+ufo9648Fw5eAlQN5snjiPRoHlPuN20e258KHHslBYu2KFLCAD54Fs1YXJ0QfJkASMe0quPu//JoXW3ftfoU0kGeODDyWkCycubW9KE8EZqV3jvTD8Ie0EshTAeirLG
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(36756003)(186003)(107886003)(508600001)(54906003)(33656002)(82310400005)(8936002)(5660300002)(6486002)(26005)(2616005)(2906002)(47076005)(6862004)(4326008)(8676002)(70206006)(336012)(6506007)(316002)(356005)(40460700003)(6512007)(36860700001)(81166007)(70586007)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 08:26:31.4773
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fab108d5-9ae6-4ea1-cfe3-08da187051df
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4704



> Could you rework this loop so that "goto out" is always the right things
> to do in case of error? That is the function would always free()
> "pool_path" and "pool_name" regardless of their values, and we only need
> to make sure both are NULL when they are already free. This is to avoid
> having several path in case of error, as this could result in mistake
> later. If there's only one error path, there will be less likely to have
> mistakes. This loop, at the moment, is using three different error
> paths: "goto out", "goto out_err", and no goto followed by a standalone
> goto.

Hi Anthony,

Yes I will rework it and send v6. Thanks for your review.

Cheers,
Luca

>=20
>> +            }
>> +            pool_id++;
>> +            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
>> +                          strlen(pool_name))) {
>> +                fprintf(stderr, "cannot set pool name\n");
>> +                rc =3D 1;
>> +            }
>> +            free(pool_name);
>> +out_err:
>> +            free(pool_path);
>> +            if ( rc )
>> +                goto out;
>> +        }
>> +    } while(xcinfo !=3D NULL);
>=20
> Thanks,
>=20
> --=20
> Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:28:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:28:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300513.512630 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNVC-000357-T4; Thu, 07 Apr 2022 08:28:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300513.512630; Thu, 07 Apr 2022 08:28:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNVC-000350-PS; Thu, 07 Apr 2022 08:28:26 +0000
Received: by outflank-mailman (input) for mailman id 300513;
 Thu, 07 Apr 2022 08:28:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncNVC-00034s-3D
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:28:26 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b03173b8-b64c-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 10:28:24 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b03173b8-b64c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649320104;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=RTd9bN7jetfpjAoMPcprr0AqMw/mey32W5oEKJu0LNo=;
  b=SKFChOuSN4XH6tLNWRzGi+TKzGvzsldgcFt5W/YYnXUMyVJ+T01LgKa5
   o9B8NEVYD260tT5Rd1tnf1+aNwDKNh01fBeKwXmV1uamoMwsJKiXtw4HL
   vZ4UtxvxSYLPT/vUOxLQKcgC1OLGa6c62hqT7m+bgQi3megzZAlLWOvMo
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68253756
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:zERF/alEM7pIsfEjs233gcvo5gwrJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLWmuPM/rYYzbwfN8nb4nn9U5S75+AzIBnTVFl/y1hESMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1zV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYEz0rFbDgyO4kawhgPhgjZagW9o3lCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6aEO
 pFGNGQHgBLobSZqF3YoCNEHnsCDiSj0dyJqlGylnP9ii4TU5FMoi+W8WDbPQfS0QsFSkledt
 3jx1W3zCREHN/SS0TOAtHmrg4fnhjjnUYgfELm58P9Cg1CJwGEXThoMWjOTq/SjllS3Xd4ZL
 kUO4zcvtoA77kntRd74NzW7rWCFuFgAWtNWO+w89AyJjKHT5m6xBHUCCDhIa9Uktco/bT0sy
 lKN2djuAFRHr7m9WX+bsLCOoluaKSUTaGMPeyIAZQ8E+MX45pE+iArVSdRuG7Lzicf6cRnyz
 CqNtzMWnKgIgIgA0KDT1VLahzOhoLDZQwhz4R/YNkqn5A5kYI+uZ6Sz9EPWq/1HKe6kokKp5
 SZe3ZLEtaZXUM/LxHflrPgx8K+BvcyHGyDw0VRWJ4gZ2g3wo3vzc7JyyWQrTKt2CfosdTjsa
 U7VnApe4p5PIXenBZNKj5KN59cClva5S4m8PhzARp8XO8UqKlfblM17TRTIt10BhnTAhk3W1
 X2zVc+3RUgXBq18pNZdb7dMiOR7rszSKI66eHwa8/hF+efGDJJ2Ye1cWLdrUgzfxPnZyOky2
 4wCX/ZmMz0FDIXDjtD/qOb/12wiI3khHozRoMdKbOOFKQcOMDh/V66Lke58K9M6xv09egL0E
 peVABIwJL3X3yOvFOl3Qio7NOOHsWhX8xrXwhDAzX73giN+MO5DHY8UdoctfKlPyQCQ5aUcc
 hXxQO3ZWq4nYm2eo1w1NMChxKQ/JEXDrV/fZEKNPWlgF6OMsiSUo7cIiCO0r3JQZsd23ONjy
 4CdOvTzHcJYF1s/Vp6PAB9tpnvo1UUgdCtJdxKgCvFYeVn28ZgsLCr0j/QtJNoLJwmFzTyfv
 zt6yz9B/4Ehf6ddHAH1uJ25
IronPort-HdrOrdr: A9a23:2C7v06hrWEeEvVbLgtS4EnH0xnBQX0F13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKOzOWxFdATbsSl7cKpgeAJ8SQzJ856U
 4NSdkbNDS0NykEsS+Y2njJLz9D+qj+zEnAv463pB0BPGIaCZ2IrT0JcTpzencGNTWubqBJba
 Z0iPA3wAZJLh8sH7qG7zQ+LqL+T5qhruOTXTc2QzocrCWehzKh77D3VzCewxclSjtKhZMv63
 LMnQDV7riq96jT8G6R60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKBsQaeLsjwZqPymrHwqjN
 7PiRE9ONkb0QKdQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8AAk3DsJQ7LgpOyfx2g4FhpVRwa
 hL12WWu958FhXbhhnw4NDOSlVDile0iWBKq59Ts1VvFa8lLJNBp40W+01YVL0aGjjh1YwhGO
 5ySOnB+fdtd0+AZXyxhBgg/DWVZAVxIv66eDlBhiTMuAIm2UyRjnFoi/D3p01wtK7UEPJ/lq
 D52qcBrsA5ciZZV9M7OA47e7rENoX8e2O+DIusGyWTKEgmAQOEl3el2sR/2AmVEKZ4u6fa3q
 6xFm9liQ==
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68253756"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B+Xb9oDw2w5h7u7SEqEfceqm700PY1Hwj7Ii3IVlVdwbKIajpYv66yhGhd6wFdHbRfK1IzN1zw4UVhwOIu9UNEFenB829EEbY6kj6/imGAX9MGdK/f/RhU7Bl0TOnR32a9wUCwLtcWx39xk+lQ5dcFfKvk8YkchWDfpIC3m+RbOqZ/kyM1Sz+LrhxRN0ifdvcokD0IDnhHvIS9uG2doYeAfNZcN63JCyHh1b+vMSiUAMOQctbgMoqVGNTpfjCYurseOtdp7Ldc7sEjPTK+DFr033apE54gBh0WbEG+xUgETuwfSh37mWNDj3YHrgo8OSImsnQVWNwjYmcrpGOJgSWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5nDfqYXk4k2p9jJC+zgR2+/QjmY/2QJMwVgszh3DnuQ=;
 b=T76zZPtkZCjFh4fvQQZtIxJbamJCGQb789v1HfYBGslVEeSr+5fgS0gWzVlXqWG1LyRMIKKDDJWqluHbNGFTnbzO8mnA5J35C0YllNBYM3+UtvKLuCjGftt/8DC/s8QldV6Usq2uuxcKq1AogAQJxvzSSKevkzvJWHF6OvTSXrzYMxBtbjGsSF5cTvUh7GBOq4+usPKUNvHyw0U4ityB8wS1k7tpuechPFHRAsyLA/FBpUjyhBTlBFKPkFwBRuCLYwS4e9lsleoZ9KQ7npU+shyRgnwb/HsoJCETSx1EvaiPZ+s30o0C7lzAhYGLSiN9ZEK3Fiv+H1W7TsDt3ahnKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5nDfqYXk4k2p9jJC+zgR2+/QjmY/2QJMwVgszh3DnuQ=;
 b=nriy8uq/U8BGJE/Ep8mhe1HUdRYvGlZp5hQOxO7zQD7shaHMzRJAy54Haf6hdvKdqg2/msgoZ4lvHvq5pEF2WpKGz4KiyiKKUDr5QG6T8AcfrXq2RZd65dih5Rn1l7i0v4sj4cMw7jjtmx0DHxd4gD6V+C5J5p8jbwhaM/IUUfE=
Date: Thu, 7 Apr 2022 10:28:05 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v9 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <Yk6glX+SHMyY/GYF@Air-de-Roger>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-2-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220401104713.22291-2-jane.malalane@citrix.com>
X-ClientProxiedBy: LO2P123CA0018.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:a6::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ba67d0a5-51e8-4754-f1ff-08da18708d20
X-MS-TrafficTypeDiagnostic: MN2PR03MB4719:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <MN2PR03MB4719CD60A55241978756DD8F8FE69@MN2PR03MB4719.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: uEKz3Lz2ek4z85VJrW4IpreydbEaJUWH/RCVCkMasSBv4Nla0u2M8gufuvD6+Wn/9tnxmlx1AsJRvJ50C6NJczibf9hM/RY9QnaLHhNOzaF9JTJJ1t7rEJdCYucw5oRH1JR8m4xHO9aU/9IJJ78BTrNNe4m2KthORJDP/dmAc/u17soSpdChzKIHdxqsXL6VP/EAshwgFoE5ar5TDxqvvKJFpLm3qa1bWGWraIYIR681uulb2e/dKSU0hBEKv0vwaQb9KbDjUPwXSOvpO4OEoDKkquz/V77HQ+9Z7iY6CFT302IU0y+RqJs2q9MJvJDqp2Sm+S8KdXnMWJvS92cmnsUhcLpuDL7SvZi0N/XNRP0Ce048SH8u7AXrk8FjicMD0oca0yaFbA+K/UoJy5sa4UKiyhZQoK9DpYbyz8MRh6RzfvbxCKB2X8uBJA3k8yOjO2VDCDYuDw/C50VX+5Wl5n/miP8q5hxEaHx8e0Ep7dmBSSXBZIbvePvBP+JDp+n4gFzxllOoYiICQAVmMGCnoAzTRbb9ihdjkwv3W6MexmcX8HZ+OaLsu6BcRWcg19BBS7/v5Ffrr5Iy9aaLwX9z0a4gw5vYntt1dwyIE0WNu78y6rwqLYbkKkZUjhUkUX8Pn+oY6M778xPSV0bdY1zJHA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(6506007)(9686003)(6512007)(8936002)(66476007)(8676002)(6666004)(6862004)(82960400001)(4326008)(85182001)(2906002)(66946007)(66556008)(5660300002)(186003)(6636002)(26005)(54906003)(86362001)(508600001)(33716001)(316002)(83380400001)(7416002)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlZXMjZScUV5SFNwRk1oS0VPWUI4aXcwd0JvdEN4RDN4cUZ1K1VSM0FFK09o?=
 =?utf-8?B?cDYyNnZZZlVlV1c5MVpJM2lKbHgzNEN3ZUxqRlJ3Y3ZnZ2hHNjZSbHdHODBu?=
 =?utf-8?B?aEV0amcxSTdWa2xwU0dwc0pHVTA1YXAyc211WVlPT00rMWZOUDdBQ09LYURE?=
 =?utf-8?B?Q2ZlUm5GN3FWUkJYRjBvUGxVckY0WUd0UU5xSDdaTHN1ZjZrK0VLYWpSVE1B?=
 =?utf-8?B?akpRSW4vQzlIWE90UHpSNHZoWWVIazVrYm1BZ1FwV25TTEV3UVpseUlRWnhZ?=
 =?utf-8?B?NFlGUnQ3cDMzWlZleGZXNjA1ZldGN2d3RzY0bUtzVHRET3NUQVhXSWxVN3l2?=
 =?utf-8?B?KzZHUVdqTXA1TEVZazA5ZWlsTmxpbDdEamwyempvTE9pOWFPZVBtM1h3QUVG?=
 =?utf-8?B?OFBXL3dSWXlRdTgvNUNMUkZxSVU4dWVsUFpmeUNYczlPLy83RGFRdk94VDJI?=
 =?utf-8?B?SlIzRlRHUm9lNW8rR2RDaTluak5YckFpdnNnUW85QWMyN1Q4QkhFR2NGT2M5?=
 =?utf-8?B?c0JreXNnWlEwUlowRllYRDk3NmZuYlpvNi9hTVl4MmU1WTZXREptZUNhZkZv?=
 =?utf-8?B?MXNGcktCRFdieURNNG05Um9ESnFvQVQ4TTZBS2l2c2liYnlZdXUrNWVFU3Vo?=
 =?utf-8?B?RGFPcXBNTU5YTzc1M3JxNkl4dXIweTZIOHg4R3RRNXFYdEMzaWhWTS9CZUNM?=
 =?utf-8?B?bDY4S1FoV2V4dXNKeUtYUFFnVXlpUkpGQlNjVU9jSHhEOUdmdVN4N2dySUp1?=
 =?utf-8?B?UC93QXNSc1RCZjlhU1NJTXRReGRmZWtqSUtVYVZOU2hyTnVSK1dzMXBkeDl5?=
 =?utf-8?B?V0RnbjRKUjlnZkJoTHc5NnlBVUZrdy82aEJwdXVFVERjMG9USmVXSGgzRFpQ?=
 =?utf-8?B?THd3c0RKOVE3NlFVNlBzV1orWjI5OGkzeTFGM3VQalBJYjNRVDVjUjhMUlpF?=
 =?utf-8?B?OWpNWlFxNnFJYzJwUDIwVS9TeElBWGVQeXRXS29VVS8vMFRBL3U3dTMxVHpJ?=
 =?utf-8?B?SWJYVmM4czAvVEcwSEhnS21yU3FuNlJsSGd0MUY1VFo3VThTTVdyenpVbjRJ?=
 =?utf-8?B?MU9IZEwwbW55MHk1ZjlqeVlETVlDZk1iZnRIVVNwSEdRRFdIbFBDRDBiOVRK?=
 =?utf-8?B?WHNYRlRwNTFyUEZYQ0F5NkgrMnJmT2tyRTlBbzJkY3VXOXRPNUxBM1FhbW5L?=
 =?utf-8?B?RnBTTXhURm9DbXNPd2FHWVlZMEZHd1czWmJoRlVqdmtmcjhERThIWjVFSjg1?=
 =?utf-8?B?VTRLWEtaamYxTm5vdXR5UDlHUjVXSUJ4YXlRb3FkWjVvQldJM2hHZ2NzaEox?=
 =?utf-8?B?TURnRkU3SkozaGp4Y0xzMGVQZWtGbkJsaXJ3R3VmY2xxQVJ3VnNIWTFvVTN0?=
 =?utf-8?B?YlFhU0JvWExpbmlwUVFBUUM1clgrUUtxVnI1blRzVzJTeG1zSitLaXB2WHRH?=
 =?utf-8?B?aDZIS0FyRXRqWUdRKzJzSmVSR3VDK3g2ZjN4RUtLc0FuZm8zMlJxREs5cVZG?=
 =?utf-8?B?TG1zbFJnOHJtTks0MTdlcWhBcDNJWHZRM0J6TFlaQVErV01BUmlDbTVvM1da?=
 =?utf-8?B?L0tKalYvOE1YV1U2Z3dLbExIQ05ENXU4Ny9aTUVZTXRZL0t0VTN3U0JwbkJ6?=
 =?utf-8?B?YlpNamdwV3VqN2JxUUJDYU1XalBUSkg0OXZYa0ZEaVA4ZmhxV3YzNklDRjZp?=
 =?utf-8?B?Tm8rb3BPalZ6QnA0QkMyb1d2MXdKRE0vRkpTUWgyalQyRVEreWtjWEZpUTZF?=
 =?utf-8?B?MlBUd1R3eGZrNXUzTHlZOVltSVV5bWE2N0VqUGRtQm03VWJMei9YT2MrMDcr?=
 =?utf-8?B?STNVckJhUitHbEVwaW9JdHhBNTg4WmRmN2hWdTlSRXduT28zREVuNTRKOXdt?=
 =?utf-8?B?blBaVTZWNUQ3UDQwWTRiczJDMnlodzZWTWRHZndpQTAySWhjNXhHbGNqY3Mv?=
 =?utf-8?B?akEzVVRXS2hJb2NVdTlSdk5HSnprckRrS0lyN2tMUmQ2aW5JYjZZY1hYdjNa?=
 =?utf-8?B?Sm5NWHNwZDlkMTV2UE5nMVRJK2hSaG54dmFQeTFaOS9rNjNOWm5WbUVKaGRD?=
 =?utf-8?B?OU03K0JCUm1XUlhkWkd4U2ZHalJ3Uzhnbmx1TlF4VHJqWkpnZnpySkxmTmVK?=
 =?utf-8?B?b21hQVFsbGlwOGc2UkNrNkwvUHQ0UStjaHp1QXpUY3VzSm9kTEVKOUxDekE5?=
 =?utf-8?B?WFhHM1VPUEgrbTlQWk8yS1lQVlY3SisvZUJFYVRRZzVwMENJL29LZHR5SUZI?=
 =?utf-8?B?TVJsQXVFRnJ0aXV3Uk16UzIxVWk4MDVoSU9NelFveGg2Z0VHM3crSUF0Qzls?=
 =?utf-8?B?NnpqQ0ZHZHpua1ZvVjd2S25CdlVvYTZCb0g2Z01PNExhNFdqcTNXcHVqN0p5?=
 =?utf-8?Q?JnT6m/Y+lXIHtZS4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba67d0a5-51e8-4754-f1ff-08da18708d20
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 08:28:11.2130
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: geZRxK3sMc+eBWxODrYU2v3SX9SluqZH2CADP27IHmWL/rm+DHEootoMFhUGK9weBE7LykjFujQXqVYjaQEsuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4719
X-OriginatorOrg: citrix.com

On Fri, Apr 01, 2022 at 11:47:12AM +0100, Jane Malalane wrote:
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 709a4191ef..e5dde9f8ce 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -117,6 +117,9 @@ static const char __initconst warning_hvm_fep[] =
>  static bool_t __initdata opt_altp2m_enabled = 0;
>  boolean_param("altp2m", opt_altp2m_enabled);
>  
> +bool __ro_after_init assisted_xapic_available;
> +bool __ro_after_init assisted_x2apic_available;
> +
>  static int cf_check cpu_callback(
>      struct notifier_block *nfb, unsigned long action, void *hcpu)
>  {
> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
> index 56fed2db03..53d97eaf13 100644
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -2145,6 +2145,12 @@ int __init vmx_vmcs_init(void)
>  
>      ret = _vmx_cpu_up(true);
>  
> +    /* Check whether hardware supports accelerated xapic and x2apic. */
> +    assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
> +    assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode &&
> +                                (cpu_has_vmx_apic_reg_virt ||
> +                                 cpu_has_vmx_virtual_intr_delivery);

Setting assisted_x{2}apic_available should only be done !ret, or else
we might be reporting those capabilities when VMX is not usable, which
would be misleading IMO.

The rest LGTM, so with this taken care of:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:45:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:45:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300518.512641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNlZ-0005bI-AE; Thu, 07 Apr 2022 08:45:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300518.512641; Thu, 07 Apr 2022 08:45:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNlZ-0005bB-76; Thu, 07 Apr 2022 08:45:21 +0000
Received: by outflank-mailman (input) for mailman id 300518;
 Thu, 07 Apr 2022 08:45:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncNlY-0005b5-0V
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:45:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d534542-b64f-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 10:45:18 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2058.outbound.protection.outlook.com [104.47.6.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-lTpXDD1AN_mu79ALWVKB2g-1; Thu, 07 Apr 2022 10:45:15 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB9PR04MB9645.eurprd04.prod.outlook.com (2603:10a6:10:309::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.23; Thu, 7 Apr
 2022 08:45:13 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 08:45:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d534542-b64f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649321118;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9Vgy/nQhPaEJae7S5nCPjqoPV5kuRYuknf6OE1w3sW8=;
	b=CjzROzE3pD8xP0m+bAX/hZgooG2gPCpYYEYdVBqFIUnuYQVe+cOnLAoW+mNDPFwID3jWTv
	3UD4PXyVbY2YiDVxIWzpuscg/CwvMbnpM31kLNc/MnDWift3XYrHHhOVIW1FQnrOZJWoMV
	NyXFZoua/iphb0ldSXpRGzqsKIlayIQ=
X-MC-Unique: lTpXDD1AN_mu79ALWVKB2g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fxigr1bOkxFzEj27GiwSiz9vuitN/Qk+sG1zVPd6RlFGfTaim2OlFHySSs3/iAUUg8coBzP4lWU0RmrIWGZ3Kq6maV4M4aPadMquNrSDXdHKu5Zh1a5yzMMsLF4Nd6JTItoxtxUynbZi+23X1v8RpYzkP38NafqvYT+9kcnf4BWlmuBByl0a4yoa9mVFj/YlgfZrvVRAQpnFfxt44J0NvlFQPJPMk44W+WOauKSvKEivKYLWw6y5B0Wjwl5LlMVlkrfuij/8Zl7nFCmAvZlWO4jarB707HYsd/xx/I3ydLV5z8KVjwItZHi1LJHC5OIhLnZctjLlwbO/jcxorBgjFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6CLZAi0cLY6kqsFOAu7uy8giJZDS95AXEjzDsNp3OeI=;
 b=i3iFKZB3hSOyWHkEUFCddHYzB4XNMurH1G/Nxt0Kdgih1ORmF0JiQ+Ak+XsKu2dCsM4VLzpjPnWMhAcp2C5mI/7To7jbHzB4ba+Q/Q3gtfOkHvB423g4RUeOYRdJJQxe+wPNz6fuidvZTt1bJcIlC1vGzGlxrsuSgjlAELFgfRkRrNwdlN7vgJEz5oHD3uoufgyh3fv2lZkEuXROesihbXrUoktMTvsQikXmyDwvRLWTz8t87Amf5b5WArkW7pGTlBch6jjil7sKov8kwPDWKhGrbnHzjBXgKd6htIxqDPdwf8DeMbeG8vActZBBEU5qGWDLt72sY1ixke555COTQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <de79b53d-0129-ee14-f7ec-fb7fb768b27f@suse.com>
Date: Thu, 7 Apr 2022 10:45:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v9 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Jane Malalane <jane.malalane@citrix.com>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-2-jane.malalane@citrix.com>
 <Yk6glX+SHMyY/GYF@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk6glX+SHMyY/GYF@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0038.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89f3a793-35fe-439e-f153-08da1872ee5a
X-MS-TrafficTypeDiagnostic: DB9PR04MB9645:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB9645377F8588EBD20BBE8785B3E69@DB9PR04MB9645.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	k6PFDXMXUTB7ppzikQUGSnWSxun3jJzHj4CLtdmgO2g2pQ+iMVzkrnk8qsYGk9QiPLtmMaNRZHtL/MoWMlxcLOyRNIS/Zs1ukYsrRq1vEOg4sL2T0d0pvTG3xkCK4yb6qVORUcGJYaP88IfCdk1Q79KUjhtDwLUWUX0mXeTmvjJELS4lzsmX7dzx4m2IXzt0O8dhMtBgQp5oLBUfHPydT38DWd8teCcSQdgTbhJ9OX74g+tJux/ACrvZZUA+y5KYtFdmT6pZgXPi8S++rOY4cbQf7A9uC04O3wMJMmVe2KE8v7f5kVbMITZvWJEniib6bQ9ZGAUCZ8+VH7Mg+po4Syj7Xuwn2xFYDBC/YFBQkcaiz9Y/QLSSoS670pNiGQPrO7vkVYzgZtUutpCzL39kPIPhYL7Mqk7xLFrFWf2p/lyHml00nt+WySI/1nYd/Zqa1nPgmWKBu73Di1UKD8DWw0ftasdKiDc79rBgtkmlBrzcV+FrpBW5x95CHX2J+1yGDXzcyBtz9Q/agIIMj2jhNtzbq90jF3haJEifRQeYme52VQHWCI0OD/YzT40QYlQoHgBXhmi5qAp9cbDEWWzHcpNm9aGt0yvczEblroE/cQtuA5cTgEVymdUfK9cDdwoutP3mlVCwUe61L/8eNdrYDSHJ1TaKx5FqkpVPb2KNybbK6C9Bo65Rh9Wt7n/erUJ2O7bWZERCc3lff55uAFVn1DFGmJvtjKGm4T7lsEFIZnlkMq0nMKzNmY8TEH7xp6mm
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(26005)(66556008)(316002)(4326008)(66476007)(6512007)(2616005)(2906002)(8676002)(53546011)(6506007)(38100700002)(5660300002)(508600001)(7416002)(4744005)(83380400001)(8936002)(86362001)(31686004)(186003)(6916009)(31696002)(36756003)(54906003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1VguRN0j0tzoSs9rc9ql8vJUeLg5GM+lr5i97sMZ9KRXlCA4J1se/CrSHr5j?=
 =?us-ascii?Q?4saLOa+JObUl3UTrwoD4OUWZjZPnmchI7d2g/x9tYkttCM1Kc5hp0UJRTtMe?=
 =?us-ascii?Q?WH42PaZE7d9NJooZxi9uDXRe5y8fgusbKg/XhrzzO2tQarLu3ktWLn2fjB8s?=
 =?us-ascii?Q?h1mFgmjsTUmAjvCO7b9NCsLnR+rkvHonVmVacyQMXtXDFyUixIO3Vt4mSt0+?=
 =?us-ascii?Q?iNC7KB7Fciw2C4vT/e2pe9hdLcmLSZmsavdSMhM7HDlfRJWVdI/QhyUdOrDG?=
 =?us-ascii?Q?jVme84Ed4X0xnT/u8iKB5S7v33Jv3ssBt6Bxl59unry0PY4bIWpOaAmbvVWt?=
 =?us-ascii?Q?Q6KO5r5piuW+7pPzPHsHlhamiSc5YYzyP8LCCvV9MYidG7qfb/sXDy9vnMZf?=
 =?us-ascii?Q?BrwR5PFdXNj+CgrSnlQV+1xESzFhoh/Io2OviJWdnYgCkAtqmTbUk8LNNnwq?=
 =?us-ascii?Q?n7dXjquV7ueJabcrQr4f6LRY7xNvhhJRYMZw5fR/xJ4k+mYNelodTeDVmIue?=
 =?us-ascii?Q?B5yjP3274u10aIasE5EM6hryzm+bNFf0nbMuFUgvlga+pbJGM3bR0jWmx0NZ?=
 =?us-ascii?Q?z/nGE56hrtQ1fwbCiHfUqGKRQF9q6Kl019ojSjnVY+MvkZYTZap+ihTMuwdZ?=
 =?us-ascii?Q?LcrReTp7kSy3/CLLjLm6auc4m0xNrMsRivKbj44apPbLi/t48xc7qEk3uBY5?=
 =?us-ascii?Q?HCBCu7I+osM3eAFyaW+LQbhY94Qd8h29uCFLEGFmMceGTw50KlzmPnKIvdQE?=
 =?us-ascii?Q?pDdNLCZ6sHM73et9ywDCppuG6rq9jWrpohsauZw8p4xmZW4CatFf5NFtxEfA?=
 =?us-ascii?Q?O+pDcu4oCCTL3w0YFNfmXjgJZfpKh4ino45yS4aEJ169MIwt/DgqNLxKak5o?=
 =?us-ascii?Q?lHU+HyPvZzT6CSXkLMXCnpw9z5W4unzmH76ehE+ajtOvx2CuICg8oefGT9i5?=
 =?us-ascii?Q?cDqK7Na1nehXdNlTQ+MMmCxJgir8MUr5+CJNJtyi77spFuR2XXrIhzfDMCeL?=
 =?us-ascii?Q?joHQo/tVE3gv3iMc0IbMORDG2ZFE7KVS/cJ9nVs7fp1C4GvugFwLnS5Xme/n?=
 =?us-ascii?Q?kC76ezljXHlcX+gd6hPnI4TeA4JDyTMBo/Xa9K4gEADL3BYA9jiGVnYCmu4o?=
 =?us-ascii?Q?DfdErMouV2+ls28pcxLa6YtS0ItPXzi3TnsEeqw5dMignUpIYvOncD8Zqbue?=
 =?us-ascii?Q?YEJhrlML8kWh3EyQjDXslUkvjM9mY3l8q56zljgLIdlhdKXJxE6cC+rvczyJ?=
 =?us-ascii?Q?FP1pUkDac0BmGCPMvLVOHaTFe0E7DLO+VHDJwiJQdyWbvtyht26IjThU59dg?=
 =?us-ascii?Q?rhaIqPq0XIHIBWVhV+u2TXacu8FpL70+lrjbuaQZk+R8wqK1b+DqpyHJAMR6?=
 =?us-ascii?Q?K4TSH7VyexBcVrTHP/rkho5imSOKZC0Umqn9PcbiRpy61ScFwZbYpxa/Tm7F?=
 =?us-ascii?Q?8Oc6//Rg7sMoJigV+5zR8Xpjtjs9dhCU8iFZPbm42+F5GfxeOXOJBI9AO52y?=
 =?us-ascii?Q?Fp3UPnFZiyWBw8UOzJ9NshQ7Zx3vdY4/nR68hUx7dSKl4RFmoCR1L35QJqgR?=
 =?us-ascii?Q?eZ6QKoU7j89oZQJFM8ywFzig/fWrkUvqCN1yqsbSjg6zoTIt6muL6tOd65mS?=
 =?us-ascii?Q?X31VQkWN4ExdwlKxXWHRPA44f2kZ1xvFXT9/DYkSj27qqWVpN3pazLndKQrd?=
 =?us-ascii?Q?xXHElcABkby1p+ervTfxjVtkDXy1ZCGspsaEWi7NBWEEpexcla5IAT1Z7fRl?=
 =?us-ascii?Q?CsEx78uBgQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89f3a793-35fe-439e-f153-08da1872ee5a
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 08:45:13.2496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e5ryZw1kjYh+9rGJCp1w4EsbrwMBuxQjAz7R0GzGMVeDiv96KQeJFvB5oMvP88aH4yMfat8hh1X09ar5xooX3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9645

On 07.04.2022 10:28, Roger Pau Monn=C3=A9 wrote:
> On Fri, Apr 01, 2022 at 11:47:12AM +0100, Jane Malalane wrote:
>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>> @@ -2145,6 +2145,12 @@ int __init vmx_vmcs_init(void)
>> =20
>>      ret =3D _vmx_cpu_up(true);
>> =20
>> +    /* Check whether hardware supports accelerated xapic and x2apic. */
>> +    assisted_xapic_available =3D cpu_has_vmx_virtualize_apic_accesses;
>> +    assisted_x2apic_available =3D cpu_has_vmx_virtualize_x2apic_mode &&
>> +                                (cpu_has_vmx_apic_reg_virt ||
>> +                                 cpu_has_vmx_virtual_intr_delivery);
>=20
> Setting assisted_x{2}apic_available should only be done !ret, or else
> we might be reporting those capabilities when VMX is not usable, which
> would be misleading IMO.

Hmm, while I agree with the observation, wouldn't it be better if all
the feature masks were cleared in case of failure, such that other
code using the predicates wouldn't be mislead either? (That would
likely want to be a separate, prereq change.)

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:45:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:45:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300519.512653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNls-0005yy-KR; Thu, 07 Apr 2022 08:45:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300519.512653; Thu, 07 Apr 2022 08:45:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNls-0005yq-Ez; Thu, 07 Apr 2022 08:45:40 +0000
Received: by outflank-mailman (input) for mailman id 300519;
 Thu, 07 Apr 2022 08:45:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncNlr-0005xS-3V; Thu, 07 Apr 2022 08:45:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncNlr-0003F1-0B; Thu, 07 Apr 2022 08:45:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncNlq-0003Gq-MA; Thu, 07 Apr 2022 08:45:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncNlq-0005vC-Lk; Thu, 07 Apr 2022 08:45:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Rj1zyedCR/fbNvv2HM282bEf81gsFM7KXLK5tHBElug=; b=tOsFHGhTaOYWSBVlFxufnV2Iw8
	CK1ysfsf0MtyiMG5iqw2NRA2J6xQUfaARoGFzfUFZGDLzkaV6CMTbMcPB6MH1YCIedFwhuX5m6vDY
	rW2GAJA64H5WOnatsna8/aP2y/Z+lNIacsiO7YBCHD/z2xNwscUw4ILmALvNNnb25WVU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169199-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.12-testing test] 169199: regressions - FAIL
X-Osstest-Failures:
    xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    xen-4.12-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.12-testing:test-amd64-i386-xl-vhd:guest-localmigrate/x10:fail:heisenbug
    xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c633ec9451e76015c409bd5119ffcb0f2e61fe8b
X-Osstest-Versions-That:
    xen=944afa38d9339a67f0164d07fb7ac8a54e9a4c60
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 08:45:38 +0000

flight 169199 xen-4.12-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169199/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 168480

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd     12 debian-di-install fail in 169184 pass in 169199
 test-amd64-i386-xl-vhd       19 guest-localmigrate/x10     fail pass in 169184

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qcow2    19 guest-localmigrate/x10  fail blocked in 168480
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168480
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168480
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168480
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168480
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168480
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168480
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168480
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168480
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168480
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168480
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168480
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168480
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  c633ec9451e76015c409bd5119ffcb0f2e61fe8b
baseline version:
 xen                  944afa38d9339a67f0164d07fb7ac8a54e9a4c60

Last test of basis   168480  2022-03-08 18:07:22 Z   29 days
Testing same since   169184  2022-04-05 14:06:03 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 375 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:49:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:49:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300531.512664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNp3-0006wn-6j; Thu, 07 Apr 2022 08:48:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300531.512664; Thu, 07 Apr 2022 08:48:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNp3-0006wg-3a; Thu, 07 Apr 2022 08:48:57 +0000
Received: by outflank-mailman (input) for mailman id 300531;
 Thu, 07 Apr 2022 08:48:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncNp1-0006wa-RV
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:48:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e33d50e-b64f-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 10:48:54 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-Gc9rv6lSOmOKvtRbTMFJSQ-1; Thu, 07 Apr 2022 10:48:53 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8465.eurprd04.prod.outlook.com (2603:10a6:20b:348::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 08:48:52 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 08:48:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e33d50e-b64f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649321334;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NbsBrv7YATuJa9XVFRtUNuu/TqIuZ4vHMNX4wjJyXMU=;
	b=mpNeSyyv0ZiYDu53BsQsbvYgDV2bcDuG00wCEG8cmLK7pzN9wo+IeFYGka1QK+Ne1ATrMi
	5oKGSodn/mWfP0GwkANWWKO1iLTtTnb6ziclMFH1lsk2EchapHaVapx4mViog5ko7JNbel
	HvpdtfJVLNfIni8eS945MLf6wxNLfOo=
X-MC-Unique: Gc9rv6lSOmOKvtRbTMFJSQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Uh8LrjGgeGzZhSH2YDxvoDkvDCm7IsJoK49OgIKeF5Q3JBrI88pbznsRX5vP5ARG5vYYiPb2Yv3B59PLCIS5It0AqlmCCKtSRybGM6QhAFlL4MMW7rwkO5opTlRH1/BFJF0L89/sSMzJdKhKzzW2zHJI7il00uWuLP8eKUkwdnEfK79+RdB/2980uaGvMT8wptIxM303CGc3ncUSAmC9RMPOagzkxPk6cQAO8bgaAoUj6zkqtzlEf31RLEJiLQ3qMw8+IKe0fcEDSOSVTLDIZtIFSueAkKe4J8wfWrjBLoeXE4jU2SciZzD57zeNMd8jF5sfU33tq6cIPN3KTZ1CUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LNz4rY8TQQ7ymti0pAQe70QDxUDiKhQhvx6bvBnXNRw=;
 b=WimmknB5p984O7vBD4m/kbxupTeCPk6HJmdSCm2BneUtKWm4d5n55oK/FZvzuideu0qS5AFm1bH1LjyKYkbVwpL0Oe/vvUqymKxtfGr2nG6uQ4QWvtIZiKSRfrlG+ZliA3pMUBqAxoH78QBQv/FHEkNGyqLks0Np4jH3n7/qNsYzlGn47Yb1gArt+wIG7VEbYMFGYaVyBbH8KeLd+/yZKHyW8+NuqW/GLGeFWbmB0X7Q5dA9lo1iZL1Cu76hDoyei+Sc2O+9Jid1OO8P4s4ZYKNaxAm/WSWYebFUxjT1yJs1GoQtWtecV0JzWNVN0bIgxw5BfGCTtDYuz0nHmXsDqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1d05e311-d466-b729-ebd6-178554f67872@suse.com>
Date: Thu, 7 Apr 2022 10:48:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] platform/cpufreq: add public defines for
 CPUFREQ_SHARED_TYPE_
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220407081828.38747-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220407081828.38747-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0182.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 50873b2c-933a-4472-ea65-08da18737105
X-MS-TrafficTypeDiagnostic: AS8PR04MB8465:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB846570DBD42142331B35B646B3E69@AS8PR04MB8465.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EPnPF76wi6ZuGiKtTONTIR8zjMOx+fJCxOLvLBJMTvpKNQnpkw03oqOwnNJMJR7+GrH8arLK6wZjaYzRqIhmTD2xXG61bgrt2AOE1QbxoCNMmP2x1hkmtSMXrb1cThTS5nefyfJBLXYgzq8xjN/6lCA/4ayabgcRXI4uD7yuuHu0bcbjUkXViybWB4kA2uJnQrtLxhnHrTBxs1Asz1DXUmA3ulxny8vFSwof8ZSdunZr2CnzaNiHWvr0YuiHU2pEEKvVeKCOCnlwSo5+oWLIwwdDNT2QMgsy4hM9ikUTKT7W4RgXF9QczzODfg6zR3nMQRqPekRiXOkhcsWXjBp29pM5mJC06JKNZydb8vhBHoDhrTYI3vzgemz2EKWmK4kB14BgWrT1cjzGTT7duOhvDxOnUwKn0SwXVFn49KtSQ1QdDEZqL1AyeyshsWVGTgNQeg1EvjxreeMWvHF28MS45EbwN8+dZH/8ZIOnd/mN5q54D6LfvS865U2Jmqppn3X88GLjTZM1YJeTNIN0YbmL2LmvmemBy0ByP5V7/sUjRNoWT8rbXqaGZp4qvqWvwK8FzWwnYFPG8McVS/E/c0ZGxGpSNI6GwIQ7wJrhBlZZhyUxTx2iYQZkavqRbhhn+VbCKRdrRvsvdDRwmagIQwNgTSglLWpY9KXV6i6N8FkxBMVai66/BiShbmG/IbN7aku6qlBG/QK1prvT3JfMHGqofaxu55bbkU4lvRZbIIXXtNNrfFTNwBDcUCKnegdOAIIv
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(6916009)(54906003)(6506007)(53546011)(316002)(186003)(26005)(31686004)(36756003)(31696002)(8676002)(4326008)(83380400001)(38100700002)(508600001)(5660300002)(2906002)(86362001)(8936002)(6486002)(66556008)(66946007)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VdBSsM6Zt6TNvsRmaH478qb4cyxC+IjwjE3ymcA7+vNiB846QWiHdy4VCwBi?=
 =?us-ascii?Q?qDvAjvlOQQ+aDhZb9zVKuaZ4b/6L2epzIHVo/ma4TT4K8EErFs4m1Ay1D+84?=
 =?us-ascii?Q?pnxPKoHYBiYiK74dbWgED/G9x7fBpiHQteGpT0XRYV3Pn3hcgpI697lB5cyq?=
 =?us-ascii?Q?IcgRh314Fc1GNU+NGCO0xISBJLeIYG1OckKwVM7Wxo3EeokgyVQ4WT3jjgBf?=
 =?us-ascii?Q?SdVBWUpN/C8A0MBA1mS+1mTjy6uAZTliWxrAMShtEeJALHeo0AdzcSsr2xF1?=
 =?us-ascii?Q?NWFGzS9qCgYBts/Eyjv8ZqBh54ASLe3BqW6Kpw2zjz7W7JFQl6Nfw/Bp+qnl?=
 =?us-ascii?Q?hq6q1xj/RyRVziZOk0gUDicKmVD9q72tpjE0Qf3OVFBPMfUKGXdryul6ohM4?=
 =?us-ascii?Q?pbZ7B2uRwFvWvJ3CSkuxOmFIE1wF21di9zyblfmu02Y7TknPKEm8MUGwfSWD?=
 =?us-ascii?Q?NiEXiZHoqxITZVt0bhtIiLQnRlVEt8atAIJBk8rM3vUh3cFuG7s0jfUXMuXH?=
 =?us-ascii?Q?u8f9u/GpEhtyWF+Z29fGe52p+aDwjgQdyt+UJDkCnzyt0tnKLyaWXAvLR9Ti?=
 =?us-ascii?Q?wQVrJoiWJAnRl/1Tt1MFhwBeUfKGy8yh/pDKind4hyGiF527URB2m4b+ZCLw?=
 =?us-ascii?Q?L0SsigWVrbaEtFGmteg1jEj4bpfrDnMNWDXsYIOrJZMi5XPGALJ+WTPcEigb?=
 =?us-ascii?Q?/eJrfpX7deU1OZ2N7YiHQd+QcMIM8SdZ8xjHn8X7/5JxbqV4QVsDY5j8jVko?=
 =?us-ascii?Q?pt5mKtIS/2eLoZAzw9/l9BWRa9hM4QZuSfO4gAqifhrwJUGzPWE4s2EdEZU3?=
 =?us-ascii?Q?kqmvjInWLGJ1xVYTLUIvS4F4kUeMC0OLoWcmVLslAsrO5T+pGQoA3NjjLTHm?=
 =?us-ascii?Q?dVYFON/vmqaGPA3WrwtJGYT4lkSsywlRK/7B4I0ksHabSY7LRKG/ZK8P1gBB?=
 =?us-ascii?Q?xabTHuYKAg/2jd/KEN1xiRfd591NtV8Z07w+sTsiiRAwRaTl17MWhSECCaGq?=
 =?us-ascii?Q?Ay5prT/ehIYgNx3Wi1M4paML0vuTOBBP8rfzMi4/hNNKLbW8e/O8u08wQaXd?=
 =?us-ascii?Q?BzZYfuat92pkknH8XWRnQQzfwXTlvKvXFECRyZpMMBdjZHnzr7xPuQhu6xPz?=
 =?us-ascii?Q?kpXYNbv3oGU+fRXHBBPoUMeMnqXmGuvbEaQqkzNmY+vKlq6SmPeWMWhGlxcu?=
 =?us-ascii?Q?Q+aGhLvdJca2jjFfMBCEodIDWZpAyCh25QYvt8ibGWtFOtEDJUbJX5a5/iCG?=
 =?us-ascii?Q?6i78hi8/EWrLBnSWrEk/UfmnRpSru/44oLmSjiKISaabTcmJ42+RREHEYV4/?=
 =?us-ascii?Q?Ex3fCJo+D/UOMpW5ypvgYlZKWFcJleU+Y9d1hGOOR9pieVqlswLPWVg3ZkdL?=
 =?us-ascii?Q?HEMfV8Er0PZBPbxMlhklUN+KrPM4JS6Q4SlTH1cLWuyAlWeN2o/2Kb378nCD?=
 =?us-ascii?Q?aq5X16f/FGeQ7aMS4cMDlOERJrII3CIW0dnYuflB7B8f/GfolDwkLPJ5KYvO?=
 =?us-ascii?Q?9YuAv0tULlDQaeueijXa4Q3j4/34DjJoF0gIqj0YjtDz8pSShr4l1XTeQkX2?=
 =?us-ascii?Q?sRxOuorTO9iXUcm+j1t/oFGs/XQFEaQK2QF6f4+3JNXbgmP8vINtuZJWYwTn?=
 =?us-ascii?Q?kmV60ZeOd6QqyPWON1xBPokGCdwJR9UnWqdDfmXq+uCe7ObtG3zReXnMdeQm?=
 =?us-ascii?Q?iwF5JbnbA84dnBDQsN+yb6dNBfu+TejSGRXJi0By2B5OOmnk/j2LtZP3XM8p?=
 =?us-ascii?Q?tvOh3qDgPg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50873b2c-933a-4472-ea65-08da18737105
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 08:48:52.3958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3ywYV9iXyANpX4+azlYtqxgQmCmcLCT6zdmwX2nUJXvVqIWPewzVea8G0ncQ5v4C2peW5IXk4Ey6GHeo8wL25A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8465

On 07.04.2022 10:18, Roger Pau Monne wrote:
> The values set in the shared_type field of xen_processor_performance
> have so far relied on Xen and Linux having the same
> CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
> public interface.
>=20
> Formalize by adding the defines for the allowed values in the public
> header, while renaming them to use the XEN_CPUPERF_SHARED_TYPE_ prefix
> for clarity.
>=20
> Set the Xen internal defines for CPUFREQ_SHARED_TYPE_ using the newly
> introduced XEN_CPUPERF_SHARED_TYPE_ public defines in order to avoid
> unnecessary code churn.  While there also drop
> CPUFREQ_SHARED_TYPE_NONE as it's unused.
>=20
> Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with one remark:

> --- a/xen/include/acpi/cpufreq/cpufreq.h
> +++ b/xen/include/acpi/cpufreq/cpufreq.h
> @@ -78,10 +78,9 @@ DECLARE_PER_CPU(struct cpufreq_policy *, cpufreq_cpu_p=
olicy);
>  extern int __cpufreq_set_policy(struct cpufreq_policy *data,
>                                  struct cpufreq_policy *policy);
> =20
> -#define CPUFREQ_SHARED_TYPE_NONE (0) /* None */

I realize this is unused, but do we really want/need to drop this?
I think it is used implicitly right now by assuming the value would
be zero; this could do with making explicit, in which case we'd
need the #define.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:51:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:51:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300535.512674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNr1-0008SK-Jq; Thu, 07 Apr 2022 08:50:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300535.512674; Thu, 07 Apr 2022 08:50:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNr1-0008SD-Gr; Thu, 07 Apr 2022 08:50:59 +0000
Received: by outflank-mailman (input) for mailman id 300535;
 Thu, 07 Apr 2022 08:50:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncNr0-0008S7-Uw
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:50:58 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d78bb692-b64f-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 10:50:57 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5A5EC21117;
 Thu,  7 Apr 2022 08:50:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F1BF213A66;
 Thu,  7 Apr 2022 08:50:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CCuBOfClTmKqGAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 08:50:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d78bb692-b64f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649321457; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6SzK6SzOgNWz1m/SzosRnb7vWlnb02hg+E4YETlNzYU=;
	b=Fv7RgqTwrGDFRVK8OyrzYTjVn6wJQjiS3DmVe55+4UZu/AlxWAmlwWwXrxBUzDtnt18eit
	PWpp4aawl7rCmHQPgJojrn2Ogw1gptw5r+02Wj1fBq0Q+F6flTQzAB5O0aRpOZARDK3/uc
	0dbBqCiH+jIHx63L2+TxOEuQw8vgAXA=
Message-ID: <4f1908b5-5674-a772-3cd9-78e4dc40f776@suse.com>
Date: Thu, 7 Apr 2022 10:50:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: David Hildenbrand <david@redhat.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Wei Yang <richard.weiyang@gmail.com>,
 Michal Hocko <mhocko@kernel.org>
References: <20220406133229.15979-1-jgross@suse.com>
 <89ad978d-e95e-d3ea-5c8f-acf4b28f992c@redhat.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone
In-Reply-To: <89ad978d-e95e-d3ea-5c8f-acf4b28f992c@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------OMFgksYuijuhI3hZ2iAJlos0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------OMFgksYuijuhI3hZ2iAJlos0
Content-Type: multipart/mixed; boundary="------------Pgc0gcsWI2D0D5pFykv836Uc";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: David Hildenbrand <david@redhat.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Wei Yang <richard.weiyang@gmail.com>,
 Michal Hocko <mhocko@kernel.org>
Message-ID: <4f1908b5-5674-a772-3cd9-78e4dc40f776@suse.com>
Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone
References: <20220406133229.15979-1-jgross@suse.com>
 <89ad978d-e95e-d3ea-5c8f-acf4b28f992c@redhat.com>
In-Reply-To: <89ad978d-e95e-d3ea-5c8f-acf4b28f992c@redhat.com>

--------------Pgc0gcsWI2D0D5pFykv836Uc
Content-Type: multipart/mixed; boundary="------------lBWdgohUpDbOpCr4EznLRraE"

--------------lBWdgohUpDbOpCr4EznLRraE
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDQuMjIgMTA6MjMsIERhdmlkIEhpbGRlbmJyYW5kIHdyb3RlOg0KPiBPbiAwNi4w
NC4yMiAxNTozMiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IFdoZW4gb25saW5pbmcgYSBu
ZXcgbWVtb3J5IHBhZ2UgaW4gYSBndWVzdCB0aGUgWGVuIGJhbGxvb24gZHJpdmVyIGlzDQo+
PiBhZGRpbmcgaXQgdG8gdGhlIGJhbGxvb25lZCBwYWdlcyBpbnN0ZWFkIG1ha2luZyBpdCBh
dmFpbGFibGUgdG8gYmUNCj4+IHVzZWQgaW1tZWRpYXRlbHkuIFRoaXMgaXMgbWVhbnQgdG8g
ZW5hYmxlIHRvIGFkZCBhIG5ldyB1cHBlciBtZW1vcnkNCj4+IGxpbWl0IHRvIGEgZ3Vlc3Qg
dmlhIGhvdHBsdWdnaW5nIG1lbW9yeSwgd2l0aG91dCBoYXZpbmcgdG8gYXNzaWduIHRoZQ0K
Pj4gbmV3IG1lbW9yeSBpbiBvbmUgZ28uDQo+Pg0KPj4gSW4gY2FzZSB0aGUgdXBwZXIgbWVt
b3J5IGxpbWl0IHdpbGwgYmUgcmFpc2VkIGFib3ZlIDRHLCB0aGUgbmV3IG1lbW9yeQ0KPj4g
d2lsbCBwb3B1bGF0ZSB0aGUgWk9ORV9OT1JNQUwgbWVtb3J5IHpvbmUsIHdoaWNoIHdhc24n
dCBwb3B1bGF0ZWQNCj4+IGJlZm9yZS4gVGhlIG5ld2x5IHBvcHVsYXRlZCB6b25lIHdvbid0
IGJlIGFkZGVkIHRvIHRoZSBsaXN0IG9mIHpvbmVzDQo+PiBsb29rZWQgYXQgYnkgdGhlIHBh
Z2UgYWxsb2NhdG9yIHRob3VnaCwgYXMgb25seSB6b25lcyB3aXRoIGF2YWlsYWJsZQ0KPj4g
bWVtb3J5IGFyZSBiZWluZyBhZGRlZCwgYW5kIHRoZSBtZW1vcnkgaXNuJ3QgeWV0IGF2YWls
YWJsZSBhcyBpdCBpcw0KPj4gYmFsbG9vbmVkIG91dC4NCj4gDQo+IEkgdGhpbmsgd2UganVz
dCByZWNlbnRseSBkaXNjdXNzZWQgdGhlc2UgY29ybmVyIGNhc2VzIG9uIHRoZSAtbW0gbGlz
dC4NCg0KSW5kZWVkLg0KDQo+IFRoZSBpc3N1ZSBpcyBoYXZpbmcgZWZmZWN0aXZlbHkgcG9w
dWxhdGVkIHpvbmVzIHdpdGhvdXQgbWFuYWdlcyBwYWdlcw0KPiBiZWNhdXNlIGV2ZXJ5dGhp
bmcgaXMgaW5mbGF0ZWQgaW4gYSBiYWxsb29uLg0KDQpDb3JyZWN0Lg0KDQo+IFRoYXQgY2Fu
IHRoZW9yZXRpY2FsbHkgYWxzbyBoYXBwZW4gd2hlbiBtYW5hZ2luZyB0byBmdWxseSBpbmZs
YXRlIHRoZQ0KPiBiYWxsb29uIGluIG9uZSB6b25lIGFuZCB0aGVuLCBzb21laG93LCB0aGUg
em9uZXMgZ2V0IHJlYnVpbHQuDQoNCkkgdGhpbmsgeW91IGFyZSByaWdodC4gSSBkaWRuJ3Qg
dGhpbmsgb2YgdGhhdCBzY2VuYXJpby4NCg0KPiBidWlsZF96b25lcmVmc19ub2RlKCkgZG9j
dW1lbnRzICJBZGQgYWxsIHBvcHVsYXRlZCB6b25lcyBvZiBhIG5vZGUgdG8NCj4gdGhlIHpv
bmVsaXN0IiBidXQgY2hlY2tzIGZvciBtYW5hZ2VkIHpvbmVzLCB3aGljaCBpcyB3cm9uZy4N
Cj4gDQo+IFNlZSBodHRwczovL2xrbWwua2VybmVsLm9yZy9yLzIwMjIwMjAxMDcwMDQ0Lnpi
bTNvYnNvaW1oejN4ZDNAbWFzdGVyDQoNCkkgZm91bmQgY29tbWl0IDZhYTMwM2RlZmI3NDU0
IHdoaWNoIGludHJvZHVjZWQgdGhpcyB0ZXN0LiBJIHRob3VnaHQNCml0IHdhcyBuZWVkZWQg
ZHVlIHRvIHRoZSBwcm9ibGVtIHRoaXMgY29tbWl0IHRyaWVkIHRvIHNvbHZlLiBNYXliZSBJ
DQp3YXMgd3JvbmcgYW5kIHRoYXQgY29tbWl0IHNob3VsZG4ndCBoYXZlIGNoYW5nZWQgdGhl
IGNvbmRpdGlvbiB3aGVuDQpidWlsZGluZyB0aGUgem9uZWxpc3QsIGJ1dCBqdXN0IHRoZSBv
bmVzIGluIHRoZSBhbGxvY2F0aW9uIHBhdGhzLg0KDQo+IA0KPj4NCj4+IFRoaXMgd2lsbCBy
ZXN1bHQgaW4gdGhlIG5ldyBtZW1vcnkgYmVpbmcgYXNzaWduZWQgdG8gdGhlIGd1ZXN0LCBi
dXQNCj4+IHdpdGhvdXQgdGhlIGFsbG9jYXRvciBiZWluZyBhYmxlIHRvIHVzZSBpdC4NCj4+
DQo+PiBXaGVuIHJ1bm5pbmcgYXMgYSBQViBndWVzdCB0aGUgc2l0dWF0aW9uIGlzIGV2ZW4g
d29yc2U6IHdoZW4gaGF2aW5nDQo+PiBiZWVuIHN0YXJ0ZWQgd2l0aCBsZXNzIG1lbW9yeSB0
aGFuIGFsbG93ZWQsIGFuZCB0aGUgdXBwZXIgbGltaXQgYmVpbmcNCj4+IGxvd2VyIHRoYW4g
NEcsIGJhbGxvb25pbmcgdXAgd2lsbCBoYXZlIHRoZSBzYW1lIGVmZmVjdCBhcyBob3RwbHVn
Z2luZw0KPj4gbmV3IG1lbW9yeS4gVGhpcyBpcyBkdWUgdG8gdGhlIHVzYWdlIG9mIHRoZSB6
b25lIGRldmljZSBmdW5jdGlvbmFsaXR5DQo+PiBzaW5jZSBjb21taXQgOWUyMzY5YzA2Yzhh
ICgieGVuOiBhZGQgaGVscGVycyB0byBhbGxvY2F0ZSB1bnBvcHVsYXRlZA0KPj4gbWVtb3J5
IikgZm9yIGNyZWF0aW5nIG1hcHBpbmdzIG9mIG90aGVyIGd1ZXN0J3MgcGFnZXMsIHdoaWNo
IGFzIGEgc2lkZQ0KPj4gZWZmZWN0IGlzIGJlaW5nIHVzZWQgZm9yIFBWIGd1ZXN0IGJhbGxv
b25pbmcsIHRvby4NCj4+DQo+PiBGaXggdGhpcyBieSBjaGVja2luZyBpbiB4ZW5fb25saW5l
X3BhZ2UoKSB3aGV0aGVyIHRoZSBuZXcgbWVtb3J5IHBhZ2UNCj4+IHdpbGwgYmUgdGhlIGZp
cnN0IGluIGEgbmV3IHpvbmUuIElmIHRoaXMgaXMgdGhlIGNhc2UsIGFkZCBhbm90aGVyIHBh
Z2UNCj4+IHRvIHRoZSBiYWxsb29uIGFuZCB1c2UgdGhlIGZpcnN0IG1lbW9yeSBwYWdlIG9m
IHRoZSBuZXcgY2h1bmsgYXMgYQ0KPj4gcmVwbGFjZW1lbnQgZm9yIHRoaXMgbm93IGJhbGxv
b25lZCBvdXQgcGFnZS4gVGhpcyB3aWxsIHJlc3VsdCBpbiB0aGUNCj4+IG5ld2x5IHBvcHVs
YXRlZCB6b25lIGNvbnRhaW5pbmcgb25lIHBhZ2UgYmVpbmcgYXZhaWxhYmxlIGZvciB0aGUg
cGFnZQ0KPj4gYWxsb2NhdG9yLCB3aGljaCBpbiB0dXJuIHdpbGwgbGVhZCB0byB0aGUgem9u
ZSBiZWluZyBhZGRlZCB0byB0aGUNCj4+IGFsbG9jYXRvci4NCj4gDQo+IFRoaXMgc29tZWhv
dyBmZWVscyBsaWtlIGEgaGFjayBmb3Igc29tZXRoaW5nIHRoYXQgc2hvdWxkIGJlIGhhbmRs
ZWQgaW4NCj4gdGhlIGNvcmUgaW5zdGVhZCA6Lw0KDQpPa2F5LCBJJ2xsIHJld29yayB0aGUg
cGF0Y2ggKGJldHRlciB3b3JkaW5nIG1pZ2h0IGJlOiByZXBsYWNlKSB0byBzd2l0Y2gNCmJ1
aWxkX3pvbmVyZWZzX25vZGUoKSB0byB1c2UgcG9wdWxhdGVkX3pvbmUoKSBpbnN0ZWFkIG9m
IG1hbmFnZWRfem9uZSgpLg0KDQoNCkp1ZXJnZW4NCg==
--------------lBWdgohUpDbOpCr4EznLRraE
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------lBWdgohUpDbOpCr4EznLRraE--

--------------Pgc0gcsWI2D0D5pFykv836Uc--

--------------OMFgksYuijuhI3hZ2iAJlos0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJOpfAFAwAAAAAACgkQsN6d1ii/Ey+N
tAf+OKaLICMk6ZJi29vD8L8v6HtVrz+K0ZW3vob8jSe0Gl1bjadVddpD4A+zG1tLW2gQWaCnqLUP
kjS4x44UWX3qhV/piaXve2Qcd2iyy6WOvp/ZTfihXD5w6aStLo2sfPHTY5OtExk6TlflmaZzUEr9
ePBxQMyUd8ApPirAaybmOPrK+ler5ppLftCbH9VGcJuXCNdgIoeAuMDA7Gg3pM06AkhwE0jhljGL
50T7v0nY548SF9jKaDQ+Op0aQr36JYgKkvEAsSAE0+0A/KSbrFiQk5POUpUlHlbDkeqja234ekPl
tvyQ1SS//5iSGhQd1bd7sQ3YgmBU+k3WN0f7+xbheQ==
=xIhG
-----END PGP SIGNATURE-----

--------------OMFgksYuijuhI3hZ2iAJlos0--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:54:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:54:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300539.512686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNum-0000dQ-5F; Thu, 07 Apr 2022 08:54:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300539.512686; Thu, 07 Apr 2022 08:54:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNum-0000dJ-1W; Thu, 07 Apr 2022 08:54:52 +0000
Received: by outflank-mailman (input) for mailman id 300539;
 Thu, 07 Apr 2022 08:54:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncNul-0000dD-Ca
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:54:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62081fc4-b650-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 10:54:50 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-tHo1w9lCP5WA6Zf1ufORMQ-1; Thu, 07 Apr 2022 10:54:48 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8741.eurprd04.prod.outlook.com (2603:10a6:10:2df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 08:54:48 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 08:54:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62081fc4-b650-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649321689;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=auJkAJgRObzvD3bsusK4L+BaHYhaa6APSHZn8u3t2KQ=;
	b=LydjGquHgF72V3yvhtQ/cf+Z9otqSl23Hc7WbYLOiLlw6emw57FajDeJxQl4Onu0G6RS5m
	FatDkBsTWxraB8kVTjXWh7KvaFYw0BX5u3SpIfFXbDbURnOiWdqqVGjZvhogI4DeiCN7KK
	66fg6Xh/gyoUey/Zjs0OF0DpiSOlxF8=
X-MC-Unique: tHo1w9lCP5WA6Zf1ufORMQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pg6ZwaUds0svrnZQB875WhbXGNmVj7fxcXoodoNb6/CL8g5JTmgUxPTPeveqoiqckfJ+4zF8lBKprOBtEPW8gigvNgddSxDXW8eWG4WDxmgKKP1vSBsJMCt2m44PlYcGhrX2qsUTMeWZMeh+GvBPovTRQkNqiwoW48jxMzvxuBku9VqVK4ox8xjyKEKP8vvrujXx+0B0sWFcQL7N7+cUTwx/Bn/CTy2piPQsTjkSCuRITzNz3Et3mQMFhnS2T65rs4idQPGoplGb/FqiDT61e3qhBFPlRLj/0Nwc3PC/Jnpatumu5Qg7GUqt0CHp+ceQkU+6zj3jO1Ndv+Wty/cbzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q9Nglw6eE4Dsn6wn+HpgWD0PvY6JLqpvnlu7/OBr0kM=;
 b=QAZ5sJWGx/YyHCy6vUnCArYzeS+GsNYBiBQTCLQRhK08jXKifQLf5Y/vq9tHkNEyKlLWGdYsSZP5VLvj3vKOdL50JGIpv/yawVsDpPUKj2D2i5rm7FJfxMYeu/3fc6UpJGBCpZaZn3xIkwquV7WKKcO2LMXGw9P3iDH8mqfbcNcEsmq5pKBB7Q8cq+v0CCiHv2hRHUlBiiv1aouu5raaegrosf6ZuavHkFgaNNnCfmRGFTXDVxGPyX7vajn9uCp6aNvPnxcfnSmCWVmtF/DFfZ/CjjUBo9k3KB9sKmyxtc3knavQCrb3RqBy3aoxj0Z/g1K/2OQ+w/SCee8JKttQxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3ab13efd-c4ca-43ff-05e8-1d29b3c438ab@suse.com>
Date: Thu, 7 Apr 2022 10:54:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 2/2] VT-d: avoid infinite recursion on
 domain_context_mapping_one() error path
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <fcc51df9-0896-247b-d4ad-0de4db6c2a9c@suse.com>
 <Yk6YAoxuOZ4Ejosm@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk6YAoxuOZ4Ejosm@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0037.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::14) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0082f328-f4e2-415b-5612-08da187444a1
X-MS-TrafficTypeDiagnostic: DU2PR04MB8741:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8741BD622FEE04A06C452F94B3E69@DU2PR04MB8741.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SR69YHHZqQUlcR1cqznWhZ+404+Ri210oXTSfN9SEJiVBQ33oUk6wItOzHypmg18TnqIkttjb1y8cn1vY9xGOxxpjpXfu9M6WszePnAfRnTXmurQaCa++igGftj4uPd0faG6Yb8WBvlmiYgblT0GyaS2Twe4/dWKnzC1B3EPbPPSD+qohcWgxXbiOmtqVhzehPECzJBUa4E9F3Y4DDOzvKi2AvWjHaH6/83P1waRO3ce0LtpX3wbObQbQMEJAPVGy0MmnV+prXao142ffIlMVoQAmizhKQ0ImpxMPv4xb8mMfwsNEzLQ7fRPlxmn8S1xE9HeS3P0bHAq9XvHfHsw9oAa9eZv1YbeAPYN0I+eEZctT+/U7ETKvpe8g+1EwkxhT3XiXFL+VXNS2OBkyrC1eN6nb1uqBKJ3myfDf2M1zQueBPLf3we2xZzqa+GFsSLGCnif/linwkKbqui+1M8L1BWGoZVhKPs5wINVyVJMmKI17HePe65vKgX2gzJ50RkrgvfSF5mgwXLmKOXAQNoF43IuZZGk91uRn1LDrHMfVp4ZCC96vOQrBLeo4d2qlWCwUq1lBvK//h1a5vqvqIli/wmkdHBXQkD7eoGlGzU1Q95DFa2FT7FelJWTXIiJ+aGFoLE8Pp4tSMvG6gsU9HISheubdxWaCuLOj/7zerjOzbJ1GRkGRYuW7TToU/odBVARPaU6RAVycWQ5xQ8uwX23sM/Y33TycZF3HlQJ/wUdXT7+W+nvGMm6N5eCmjnkKU9x
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(4326008)(66946007)(8676002)(31686004)(8936002)(31696002)(6486002)(66556008)(66476007)(2616005)(86362001)(6512007)(186003)(5660300002)(316002)(36756003)(54906003)(508600001)(6916009)(53546011)(2906002)(6506007)(26005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tmm4ybXWYHK6k80b1g+TLiPZ/eL4+b1Yf1m/nJDEq7iYBZTTm+uPVtEXKpCV?=
 =?us-ascii?Q?w0vfTpO5NzS7nrXvA60pD4XFwewXOYFX74cjHlE2rTCtJoJEDQ2lXubUnofF?=
 =?us-ascii?Q?u5+vY1iBeyg2Jrvh6AKZ5H1DLrHq0tkOsm/ZLTlAkkgsvNQl6a41QMMIjNDc?=
 =?us-ascii?Q?IHOO8wYRhnvXp1HnakTn6/dqigBR+d/wG6j2EWl8+vy+jay8QIXN5fFNeNim?=
 =?us-ascii?Q?H6UCxlQ9exP5rvB6BGXh5kDXBwLOIKJFaL5EjqoX2a7EAJdw5+J+bBUaQlDs?=
 =?us-ascii?Q?nkNxnw3hv/+WVkoTi5tt42x9JZl1FMLZE+j51rCXsMp9CfTex1FoZEIO+Q0k?=
 =?us-ascii?Q?YDIVvfI+YnpLtffkeB+tcxYMw7wzxCSRjjxreDMahAKW3FWuKlwIPLCNW/Ra?=
 =?us-ascii?Q?sZnfvSUX7VK77LWbvednp0rC+wFMMqiSZehwT/kwcBaAKyyFOkrcyxYF3d/e?=
 =?us-ascii?Q?A0MM5ArAfZEhqvJifAjugqVd4eA5yPjTnSRt0AgUipQDItXT1Tks+NMIcig9?=
 =?us-ascii?Q?gWIo5Oy8mA0/o/KuMTeVJy46ViPjS3ptbsEpGP8VqevRLui4S0J3C6oZSo+B?=
 =?us-ascii?Q?A/Z4CGgWxsaz52GTcf1LoFW/4fQuXzIMDbQM4fRlqmMDZHLJlEirbXvj/qtL?=
 =?us-ascii?Q?T8/tGxzQIgHs34XkZl+CsnSDVHr4LJ3pK/BDX0cjehkP7cxm+rmzJn6JoEhm?=
 =?us-ascii?Q?+oHIfsW5+MG1PHzxgeSmqL+RlJ3eadScgfG5EtmkbY8Qch4pYNifeTYMUFfZ?=
 =?us-ascii?Q?+/fdr50x15rr/072AZK7+JGBrvpmBx6OR9Kb2xToeIa3qRJo5m/bHXwQc3M7?=
 =?us-ascii?Q?kS9sPpKneYJAwSx1C+3j6XxvPBckoDc1O7Y1xaTnR6eQBw1f6aEJcJCQQ41Q?=
 =?us-ascii?Q?aR94diWUbtSwIQaLnQRNw86tmaldxAGuxPcp7rfQ6mtkHaxvI5BDBqm5fzZ7?=
 =?us-ascii?Q?VOm7bFXf07b1xgWTVQkY6ij8yTNSe7KXVOdwRc0AyheIIsm2O1l8/HwPc0q5?=
 =?us-ascii?Q?4ddrAo2T04xZTt0zboZoUIIb98EoVhW+ULkbsLkZ3N8+1Y3nop5L7pccs/ZC?=
 =?us-ascii?Q?koqxeDv2d14AumaJ2DVbAOi5lv1Qi5hJ0ip9zkDd2JdxZtO/FP/vNu8ktjHo?=
 =?us-ascii?Q?am7ROVfvKdRVjfEHMV7dJzoSZ2gq8lI8Kl5EJ43g25PsKLjFe855i2AwCWcb?=
 =?us-ascii?Q?4cZwI5ujJHX7RXLu9bpeiLPm+ERJc2BZVzfSAcSWcaJi9v2oaceuVMgsUhTz?=
 =?us-ascii?Q?JLViByeqfVHCSYt9SjKsKyyxIyRzZSjgtcIm7zR4Uwk69PS1zixlkCe5t5GU?=
 =?us-ascii?Q?AxHBLZTzFd69R1bZbIbWpGha2qQHge0tRffxsuNho8ruJEgg2WgBds5Xmb7Y?=
 =?us-ascii?Q?EAQbjxTTk/YdERkiDq427l4tq7edT52Q9g/ifchszVeKm2Pens4KaZoay1Id?=
 =?us-ascii?Q?oVj2IV+WtbCJsFX6LEmGS5NIc2W1lwRljDa6cbuFbd0+3lqj39Rahh+se961?=
 =?us-ascii?Q?+HMYssQlxq4F8EEz3IRNb4+q9s1jmSzFQICHg2o3q34MGyvyaCGAnEM6TOXl?=
 =?us-ascii?Q?RrjC82+NoYK4owdz4PX6UHqNEult/iSVoBzQNc8M5cU36lmPTolkHaiy/WYO?=
 =?us-ascii?Q?2s423mUD0ZemvdikBmXqwRW0+hk8R+aujCP0/N+ga+Fr281MhbAIsfUw5HtC?=
 =?us-ascii?Q?IGQNG3TGFFiuG5hEZRCMNXuYqv2RE0OlcJdPaR/m73+1oGNm3rwebj4So+DE?=
 =?us-ascii?Q?lAhQmo7Giw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0082f328-f4e2-415b-5612-08da187444a1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 08:54:47.7430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZSvMDB9/3MeYXpGP3W4Q94MKulhRqWUFdrPGF5IqjCLRCiDVFkboi+qVoBTp5Y+AnxN3DVo6lOU99n8fOPYHww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8741

On 07.04.2022 09:51, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 07, 2022 at 08:11:45AM +0200, Jan Beulich wrote:
>> Despite the comment there infinite recursion was still possible, by
>> flip-flopping between two domains. This is because prev_dom is derived
>> from the DID found in the context entry, which was already updated by
>> the time error recovery is invoked. Simply introduce yet another mode
>> flag to prevent rolling back an in-progress roll-back of a prior
>> mapping attempt.
>>
>> Also drop the existing recursion prevention for having been dead anyway:
>> Earlier in the function we already bail when prev_dom =3D=3D domain.
>=20
> I wonder whether it would be cleaner to stash the previous context
> entry if present and try to (re)set that one instead of recurring into
> ourselves.

I'm not sure this would be cleaner (it might be easier): The entry
may have had modifications which we want to undo by a clean
establishing of the "new" (really original) mapping. Otoh roll-back
can certainly mean simply going back to what was there. But that
would likely want to be a separate change, for likely coming with
a lot of code churn: I'd see the function gaining a two-iteration
loop then, which would mean re-indenting fair parts of it. But
maybe it could also be dealt with by other means, while still not
introducing a fake loop via adding a "goto" back to the top of the
function ...

>> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 08:59:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 08:59:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300544.512696 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNyi-0001Yg-Nz; Thu, 07 Apr 2022 08:58:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300544.512696; Thu, 07 Apr 2022 08:58:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncNyi-0001YZ-L2; Thu, 07 Apr 2022 08:58:56 +0000
Received: by outflank-mailman (input) for mailman id 300544;
 Thu, 07 Apr 2022 08:58:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncNyh-0001YT-N1
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 08:58:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncNyg-0003TP-Dw; Thu, 07 Apr 2022 08:58:54 +0000
Received: from [54.239.6.189] (helo=[192.168.11.175])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncNyg-00082z-6p; Thu, 07 Apr 2022 08:58:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=sP38xVjOooTtw2CuuAOwWKLsRja/GbMoQ43bwGgG10A=; b=bAH8+NcKjqnMPYH7G7lU1tbMt1
	tn24Y4tO2eoRjkkT4PykUpWQxCwoxREmnAdMj2E7w7NNmKUZB0hT/T6nJ7tgD29upyP8JcOHYTOcz
	KjK9TNs8B2NiN2ePHBw9QSEt843bQAoOCLx0VFUDED6/v+ifl6kMJTCF+PSfuD6iKGio=;
Message-ID: <deffb58a-984a-1016-4ac8-c3badc946ea0@xen.org>
Date: Thu, 7 Apr 2022 09:58:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot
 time
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Dario Faggioli <dfaggioli@suse.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-5-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220405085741.18336-5-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 05/04/2022 09:57, Luca Fancellu wrote:
> Introduce a way to create different cpupools at boot time, this is
> particularly useful on ARM big.LITTLE system where there might be the
> need to have different cpupools for each type of core, but also
> systems using NUMA can have different cpu pools for each node.
> 
> The feature on arm relies on a specification of the cpupools from the
> device tree to build pools and assign cpus to them.

How will this work for ACPI? Note that I am not suggesting to add suport 
right now. However, we probably want to clarify that this is not yet 
supported.

[...]

> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
> new file mode 100644
> index 000000000000..5dac2b1384e0
> --- /dev/null
> +++ b/docs/misc/arm/device-tree/cpupools.txt
> @@ -0,0 +1,136 @@
> +Boot time cpupools
> +==================
> +
> +When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
> +create cpupools during boot phase by specifying them in the device tree.

How about ACPI?

> +
> +Cpupools specification nodes shall be direct childs of /chosen node.
> +Each cpupool node contains the following properties:
> +
> +- compatible (mandatory)
> +
> +    Must always include the compatiblity string: "xen,cpupool".
> +
> +- cpupool-cpus (mandatory)
> +
> +    Must be a list of device tree phandle to nodes describing cpus (e.g. having
> +    device_type = "cpu"), it can't be empty.
> +
> +- cpupool-sched (optional)
> +
> +    Must be a string having the name of a Xen scheduler. Check the sched=<...>
> +    boot argument for allowed values.

I would clarify what would be the scheduler if cpupool-sched is not 
specified.

Also, I would give a pointer to xen-command-line.pandoc so it is easier 
to know where 'sched' is described.

[...]

> +void __init btcpupools_dtb_parse(void)
> +{
> +    const struct dt_device_node *chosen, *node;
> +
> +    chosen = dt_find_node_by_path("/chosen");
> +    if ( !chosen )
> +        return;
Aside when using ACPI, the chosen node should always be there. So I 
think we should throw/print an error if chosen is not present.

Also, I would check that we haven't booted using ACPI rather than 
relying on dt_find_node_by_path("/chosen") to return NULL.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:00:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:00:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300548.512708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncO0Q-0002wL-2x; Thu, 07 Apr 2022 09:00:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300548.512708; Thu, 07 Apr 2022 09:00:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncO0Q-0002wE-00; Thu, 07 Apr 2022 09:00:42 +0000
Received: by outflank-mailman (input) for mailman id 300548;
 Thu, 07 Apr 2022 09:00:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1UeT=UR=redhat.com=david@srs-se1.protection.inumbo.net>)
 id 1ncO0N-0002uc-VO
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:00:39 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 31428097-b651-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:00:38 +0200 (CEST)
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-399-LExrpKdLOEeDUeqSiasDjQ-1; Thu, 07 Apr 2022 05:00:36 -0400
Received: by mail-wm1-f71.google.com with SMTP id
 189-20020a1c02c6000000b0038e6c4c6472so4298870wmc.1
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 02:00:36 -0700 (PDT)
Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8?
 ([2a09:80c0:192:0:20af:34be:985b:b6c8])
 by smtp.gmail.com with ESMTPSA id
 u7-20020a05600c19c700b0038cc9aac1a3sm7933452wmq.23.2022.04.07.02.00.34
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Apr 2022 02:00:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31428097-b651-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649322037;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0inCEjJJWw//2DoC93l0BxRCxkrP6GV4SWwsKG2zpLQ=;
	b=aJxOc89Id1Wis/A/CoCs0zLw7VELjzmN2teAJK6WWAhLr6n7bnho+Y0w9T2rKrUXufBbP9
	GNU81ZsqKgErQZHC+xC+DN5PJcussH5ZmHjY1rd8JHXIPUjUBAAgU1p76xGc015DhRfX45
	0LrTsmj5F8cxn7sGsqm4lv/aU1MsYCY=
X-MC-Unique: LExrpKdLOEeDUeqSiasDjQ-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:organization:in-reply-to
         :content-transfer-encoding;
        bh=0inCEjJJWw//2DoC93l0BxRCxkrP6GV4SWwsKG2zpLQ=;
        b=09vRx/qEJo7TG2/gXQHIU20nOkxIvbPUIdZ5A7uIQR6sY1R/Tksxlvkz6BNLeMOtEj
         qo5NfeJpIFNaKRprW1bVbf0mwqLfXyydz8B4GngQkmueWXSVv1YQb/bdXtuzYB4OFQ9/
         yTNL+AkTyjw8d2lsc+qMkNbYK7flLf/ZvnZ0D8ndKFjl5RWKwxCdFyUKcR5uwiTJaRL3
         YbEtmQe3Eqg/V/9zrwQbxnXBDIRgxgmdTdB/4UfoL5xaZWnxpHj/HPZnGQ3lNtX4jrzw
         XZn+k5sOg0FhjRfswIQns9XgSXWym8E7jscIF10rv9LMEP1RLaiMTbOXkjFiJPZpVWzb
         qstw==
X-Gm-Message-State: AOAM531aBDncp1ZicsUYMSCarZ14hGK+snmmkbIsmslWk+52ujCwxkV2
	aoAFsoZ3V69FFveFMBAXTFJrnVUnUQl+Z/7Nn0RvpNHnA/WklfW1K57J5O3JnQvlecBbqrvqXCW
	wdSn6Cx0/xbYp9MVO8jKYjQbBK04=
X-Received: by 2002:a05:600c:17c5:b0:38e:7853:e915 with SMTP id y5-20020a05600c17c500b0038e7853e915mr11065437wmo.123.1649322035313;
        Thu, 07 Apr 2022 02:00:35 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwDXbmi0MYBbhyvRv3XQym+Vvb0hr0yJXFvC8twCFVw7fXFScumPU3//4ro5ZrKBn7rVoiing==
X-Received: by 2002:a05:600c:17c5:b0:38e:7853:e915 with SMTP id y5-20020a05600c17c500b0038e7853e915mr11065408wmo.123.1649322035047;
        Thu, 07 Apr 2022 02:00:35 -0700 (PDT)
Message-ID: <f423e210-3e28-73f8-1082-869ef680b9b0@redhat.com>
Date: Thu, 7 Apr 2022 11:00:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Wei Yang <richard.weiyang@gmail.com>,
 Michal Hocko <mhocko@kernel.org>
References: <20220406133229.15979-1-jgross@suse.com>
 <89ad978d-e95e-d3ea-5c8f-acf4b28f992c@redhat.com>
 <4f1908b5-5674-a772-3cd9-78e4dc40f776@suse.com>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <4f1908b5-5674-a772-3cd9-78e4dc40f776@suse.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 07.04.22 10:50, Juergen Gross wrote:
> On 07.04.22 10:23, David Hildenbrand wrote:
>> On 06.04.22 15:32, Juergen Gross wrote:
>>> When onlining a new memory page in a guest the Xen balloon driver is
>>> adding it to the ballooned pages instead making it available to be
>>> used immediately. This is meant to enable to add a new upper memory
>>> limit to a guest via hotplugging memory, without having to assign the
>>> new memory in one go.
>>>
>>> In case the upper memory limit will be raised above 4G, the new memory
>>> will populate the ZONE_NORMAL memory zone, which wasn't populated
>>> before. The newly populated zone won't be added to the list of zones
>>> looked at by the page allocator though, as only zones with available
>>> memory are being added, and the memory isn't yet available as it is
>>> ballooned out.
>>
>> I think we just recently discussed these corner cases on the -mm list.
> 
> Indeed.
> 
>> The issue is having effectively populated zones without manages pages
>> because everything is inflated in a balloon.
> 
> Correct.
> 
>> That can theoretically also happen when managing to fully inflate the
>> balloon in one zone and then, somehow, the zones get rebuilt.
> 
> I think you are right. I didn't think of that scenario.
> 
>> build_zonerefs_node() documents "Add all populated zones of a node to
>> the zonelist" but checks for managed zones, which is wrong.
>>
>> See https://lkml.kernel.org/r/20220201070044.zbm3obsoimhz3xd3@master
> 
> I found commit 6aa303defb7454 which introduced this test. I thought
> it was needed due to the problem this commit tried to solve. Maybe I
> was wrong and that commit shouldn't have changed the condition when
> building the zonelist, but just the ones in the allocation paths.

In regard to kswapd, that is currently being worked on via

https://lkml.kernel.org/r/20220329010901.1654-2-richard.weiyang@gmail.com

-- 
Thanks,

David / dhildenb



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:02:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:02:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300551.512719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncO1m-0003VF-EK; Thu, 07 Apr 2022 09:02:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300551.512719; Thu, 07 Apr 2022 09:02:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncO1m-0003V8-Ae; Thu, 07 Apr 2022 09:02:06 +0000
Received: by outflank-mailman (input) for mailman id 300551;
 Thu, 07 Apr 2022 09:02:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncO1l-0003V0-IZ
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:02:05 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 62ba1dc8-b651-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:02:03 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62ba1dc8-b651-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649322123;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=TORuY2rvbBLGP/MaauekUkUm5+f7SaWS4p6bds02T3E=;
  b=NIUzDaSNKYz6tix0ceLj/tPPJetNLOGWr9o3UeRd0ePflGQjFXV61x6N
   sBdW4i6SCka1DnfSflsuxEl84C+/2tSIsRI8QbixV7pFtJGxGWfj0XJ5H
   n9kyiMpnpLPrK8uO1TtoCsAzqlURkQxTPUhRTKujJZLK2/1oallgNUTzB
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68239714
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rCYrY6nEu00VVXU1bQZEq6vo5gxzJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaDT2GPvfbYGOhKo11Odmz8klQv5HcnNQ1HVNlpS8wQSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1zV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYURgKDJbHuf0hED4EMXFcB/F31p3lPi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6aEP
 JtGMGYHgBLoU0R/OXo2DaMHvuq4jFDuTBxFqgqbjP9ii4TU5FMoi+W8WDbPQfSRXtlclEuco
 mPA/kz6DwscOdjZziCKmlqum+vOkCXTSI8UUrqi+ZZCvlqXwWACDQwMYnGyq/K5l02WVspWL
 gof/S9GhaQ76kGDVNT2WBy85nmesXY0RN54A+A8rgaXxcL88wufQ2QJUDNFQNgnr9MtAywn0
 EeTmNHkDiApt6eaIVqf/LqJqTK5OQAOMHQPIyQDSGMt4db5p5oopgnSVdslG6mw5uAZAhmpn
 WrM9nJnwexO04hbjM1X4GwrnRq0ubv7dQUU/zmUeT6HviFDOL+LRa63vA2zAel7EK6VSVyIv
 X4hkseY7fwTAZzlqBFhUNnhD5nyua/bbWS0bUpHWsB4qm/zoyLLkZV4umkWGat/DioTldYFi
 mf3sBgZ2pJcNWDCgURfM9PoUJRCIUQN+L3YuhHogjhmP8AZmOyvpngGiausM4bFyhVEfUYXY
 8rzTCpUJSxGYZmLNRLvLwvn7Zclxzol2UTYTo3hwhKs3NK2PSDJGO1VbQbeMb9gtctoRTk5F
 f4FaqNmLD0FDoXDjtT/q9ZPfTjm01BlbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9zY/1E
 oWGchYAkjLX3CSfQS3TMywLQO6/DP5X8CNgVQRxbAnA5pTWSdv2hEvpX8BsJudPGS0K5aMcc
 sTpjO3cWq8fFWmdo211gFuUhNUKSSlHTDmmZkKNSDM+Y4RhV0rO/NrldRHo7y4AEmy8ss5Wn
 lFq/l6zrUYrL+i6MPvrVQ==
IronPort-HdrOrdr: A9a23:ZcTaBK4e1LRfLjmDkQPXwSyBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc6AxwZJkh8erwXpVoZUmsiKKdhrNhQYtKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkANDSSNykLsS+Z2njBLz9I+rDum8rE9ISurUuFDzsaEJ2Ihz0JezpzeXcGPTWua6BJc6
 Z1saF81kSdkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq
 D5259T5cNzp/8tHNFA7dg6ML6K40z2MFvx2TGpUBza/J9uAQO4l3ew2sRz2N2X
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68239714"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DU+SQy/ki+gkt7lpVrFUQyFbc04QtwdenjsJv/6aisCKAOgivzb1MvWYQIUODezOmTx+dd2aDLGLcIp2HyKOt62EG/c3eT9Me1V/ExqN+AFNhJgbTFYLe/7akX8gzC2/phOWCAFL4TKLnmGn2DmHtQo7zD9oIaifS60c6J50FmbtaGyv9PeGafklgZHrD1hEUXsbksCTYeSY6TSe8xUlI2u0D+KyxptQeu6/0TKx6hpNp0h066satDRqtzEJXx4lXzH3oOOe7l8EZcHT0nzk8vAj9HTE/zAFKuGisexnyAPv56LXAdQgcUNCQl5jRiaCl9KBZ9NYEN7lJPNxkZT/SA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FaG12ZkIagFOGVa5EwLSVI2EahEPMc0oBg4/E9fa9Qc=;
 b=fbCKRejC654CKUnVSAGYP3bbdF29qNclaJ7gs4erGS5sRXeAhsgxDdKU155czVYpDE8A3xaBHqwIff5Ahahyo2Bw4JUys++3wb1wpBdGLxLVwauHhTF3xEWlMLs5Ip+Zl/L9mT8A63iTBs5bvRkP5W5EsdxrQmOmETLdf9U7LWmqc6AwhMdwrKwcY9k4YWw+GwgINueA/NkQatQ1LsYmwD+SJmIWXC47mIQnqYOfuuxZ5X5jmHlKmPBomMareFVSv69kOfR6GqYpgivmkz6yFetwx75RRQVggqrPOe6viGPTpODvm03VK4XW/KpEeE/5Yp43/kd3Ro/SUEOb56GZeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FaG12ZkIagFOGVa5EwLSVI2EahEPMc0oBg4/E9fa9Qc=;
 b=idWO7wGV52rEtPMKaNMpByxHIUju4QPIVripMZwEEuXuL2xxheDfQydupB7OtGOz47UvUXTVA46Pczh6/gDYbdqnDuvNrpjF2OcvRD8h90koUeZZdv5rJ4dO1MKlvBPd5CnQ/xOUPnoX5/momP1QM938X3D/JT1AT7kKOW0IbFo=
Date: Thu, 7 Apr 2022 11:01:51 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v9 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <Yk6ofw+JcKpuJN/a@Air-de-Roger>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-3-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220401104713.22291-3-jane.malalane@citrix.com>
X-ClientProxiedBy: LO2P265CA0158.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9::26) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cbf94411-cd6e-4ce8-030f-08da18754407
X-MS-TrafficTypeDiagnostic: MWHPR03MB2447:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB2447B6935CC76B3E29590F468FE69@MWHPR03MB2447.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1NwmbVYTEBrRIWuK7wTKFa/rG+sUoxXCtWWBu0vbtDdj82i3t8wDYqke6yKOdUeYaTfWKVRo3OyDqIxLHUMYl4ilEJejmv4WSarHvPzW+p1fsxrcBq+c71gwyaw4r0krH/Ca6v46zttzaxHqkGcLQ7aIzuI6TbyuWY+4l6qu9n/HAl8oRdymkrR5FSKMsNKmTwJZRbeuUfGrU/GM3BxNcM1rEikRjBOFppwSZZJxJLj403CmMOoiHYiamd03CwpWZUy9zgnTnz6IrB+yh80bf+Pv3cjrXXBm128UutTCw+nAf9A2O9KHQV6iBRPM5Hu7gZygM5xXFD26nsC+WNHhIoU7HqOhJ7iAyLCzK3tBqGHZfafoqwKW0YdseC8Ga3mc+Yy2CqR8GFpJ9QDoTB36FFpvBNOh57MNWijXL6y+NN1AkxyEY/pttO4PeXCWL/jT1Gcu4qSIKswnqunJdxZBbhq2qWSAdIgl20wvSL63LmkYi4pFheN7Nc8/dcrAt4CfrPhe379Yquj0kmSdevlhoITLdBeJBDoIQUZATdVCgagzHDI/sSr7TEMPZfZdLsqjpDOJpq1AkkydP/0z/RuK1NF9Tq1R5COqOqYo3vCGjXFcUY+XWrbZZ7YK3CvYrOoOmIoKUyUA2w0SUFFwWI03lw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66946007)(4326008)(6486002)(6862004)(66476007)(66556008)(316002)(54906003)(6636002)(8676002)(38100700002)(86362001)(85182001)(82960400001)(186003)(26005)(508600001)(9686003)(6506007)(6666004)(6512007)(33716001)(8936002)(5660300002)(83380400001)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dklWSlZ2Rm94SHZVZVA4SWpiN1YvektzSVhPMGVyUWF3YmQrTC9GVVlubjZJ?=
 =?utf-8?B?YXpESDNVTklreVNVcXd0SUxnQ1g4dk1rYTRjWk00dG1OL01YVGJDQnQ1c1Br?=
 =?utf-8?B?d1JzZWo0bWhMd1BCbkdIaHA0b0xBQ0pRUm5hSlFXZ1pLUlVhTjdBTlNvV0hx?=
 =?utf-8?B?dkhJN0M5Y2liR2cydlMyemRxT2RYUUYrRTd1dVhFRlY5OUZ5NXY4RDRQREQx?=
 =?utf-8?B?ZFdvclNGUk9aM2VEMjV1cVZZdEJDMFErSlJnOXpXNmZSZUJIWFFtZGVrZTJR?=
 =?utf-8?B?dVRoNmdIUUFWcXhMclQxRjRtbEtPWU13aFZFMEgyOGpyUHphdWs1UXp2WjZu?=
 =?utf-8?B?Wkt3d0VTWFBVMkFJVXpyTmRSWTl5ZGZRRTVsZ3JUWWlLenB1U2lzY0dZcWxu?=
 =?utf-8?B?QWVDMko0T005ZjBPb3BxLzFWaGVTM0pNV0JKWFp1bVdsaWNZSEdyM2FoL014?=
 =?utf-8?B?R3haN3FJbm51TGtoVjBnRUx1N2NjN2k1ZmgxRmFWcWlxT081a2lyRmtJOWpS?=
 =?utf-8?B?VWc4dnVUQk9yN3NRU2hkWkZsM05sbUN2K3JDSHNTRjNiVEdCUWNpWlR6UmF6?=
 =?utf-8?B?QTJEOU5KOWxQbFJJd2ovTS83SUxONHVyVEl4WXhOaXdnS21xNHVFdG9qLy9Y?=
 =?utf-8?B?K2l5ZXA4ZjFkNmljUXNja1BIeFZiZWp0anBiMEtocStmR3QreVNWVUdVRnpT?=
 =?utf-8?B?aDVicUg1QnkvOC9WMHl3dG5rb3ZRQmtTYXFrMWVHZGNOSlRzY3FmR29BeHcv?=
 =?utf-8?B?Vlc4V21VK1FEaFlCSlo4ekdaWm9tREtZQWd2dmFxcHdEN1dSWk9lWnljd2g4?=
 =?utf-8?B?VE92Nmh4K09lUUVMZkZQQ1FzaHpjZ2l6QWlyaTExclVsQ3ZWU2VncndtMlow?=
 =?utf-8?B?R0ZNMUZ5c3RYM2kzRnRCdURmMURaYndTN1gzaDVTYlpHRnRIUGJnVmtrYTVZ?=
 =?utf-8?B?TzhRV3dLT0poTTJ4bHhNRlRUUkRFT0FNclRXMDRWMXI5andsR1hKb1gwcUsr?=
 =?utf-8?B?cEo0dlIzcG4xeDNqZER0dHFBV0w5d0RoZi9weGFCWXp5clBMZVdTSTFlWXRV?=
 =?utf-8?B?YTc3dCtaYnhqN3RqWG5OT1FML3RQWitpZ1V5U2dHRWpXbGREYytrdnlBY1BH?=
 =?utf-8?B?cGt5VDMxQlo2OFdneGRuOUlOdFFlOXlmVnBDdGxFSkRxU29mdHpYRVdxTjJF?=
 =?utf-8?B?MXpzZ1RIZE9uU092bU9lOEdueWF4RG51b2VVVXdKZFFKWHZYb2pIbXYyclBt?=
 =?utf-8?B?MTRGbnRMUHpHbFhDUm1HVFMzNWdXY3Yyd04xSHgra3R2QXNuY2Y3QWN5VGdP?=
 =?utf-8?B?dDNyL1NXOWhGdzd0RzRVN0F2Z1praDIzWWc1bUVuMS9HVmFaZEtiTGN0Y3dk?=
 =?utf-8?B?WnNkNlA5UVlpamF4YjZxUHorRjErU09iMWdGMkl0Wm9TQUJWN3R2NlIzOUdp?=
 =?utf-8?B?NmtnRDl1ZzQ4TWdJUWE1UmIyUmd4WW9WNzF0Ti9hWThXV05xeDBtSTA0b1NQ?=
 =?utf-8?B?SHk2TUtrVXZ4NGZNdmRSRVJjV255ckEwYUJpSGo4Rm82aDlCaFZLazJqVFQw?=
 =?utf-8?B?TmNWaVpQaCtPbE85WCttU1RFQmc0Y1JqRTBXeU5Ed2EzOGhCWHpVaEtEbnJu?=
 =?utf-8?B?M3JpeEJtSDFtUnV4aTVXR0prNjQwS0M5a25PbUZ4Yzd3ZHZwZURoWXRCd1dT?=
 =?utf-8?B?T0wzcURjQ1BNYXpyQmlBYzVIR2tjWkpsNzRVZFdaVjhsVVdZdVZHZCtrMC9V?=
 =?utf-8?B?dW1QVGtZN3E4cTI0OE9sTktBUnlVWGlCMTE1YW9za0laRnJNQlpWckRxRStS?=
 =?utf-8?B?bklKN3ZFVk5jdDJoM21HZWZxUkNLTmdRL3ZZYXZPVTVFbFNmQ0dCUGJCMC9t?=
 =?utf-8?B?S2MzT0pNR0NWUTRIVUNoSDBvZjQ0MHlyVXpmRmYyVC95d1Q4c1ZtS2JRWCtF?=
 =?utf-8?B?VnprY2pNVU5CSE00S2g3d2pSVS9VRXQ2eFFJV3VrYmRyVEk2NWVJZk1wQTJw?=
 =?utf-8?B?SWw0WldMZVdDZlZEeDlLZkVDWE5HZGs0YWp5VjJsVVVRVGpTa2JlNk5BMmVY?=
 =?utf-8?B?SStxZ1BHM2h0NE5KUy9hY1R0QmNMZjZzaGdpcGpZYVN4emcrYVBuSGl1Ykcv?=
 =?utf-8?B?Ui9xaG52Rnk5TmRhRmVDVFcvR3k1Q3hHb3JrUEZhWTFnTEM1UkRVaW84MFZp?=
 =?utf-8?B?bzY5R0MzWDJpZ29QM3M5Q3JMOU5zckc3bklBWC9GWjRwdWwvRG9uUFdndmpB?=
 =?utf-8?B?blJINEFrZC9IQjVVRE05QTNYajB1MHJZdktTRHZvald4MjY3c2hBcGN1NGo4?=
 =?utf-8?B?RkhkbWYzTGZFNXlZY2Y2Q3dqMnNrSDRUcFBjZGVsZG96aGNlQ1hKb1hGVlUx?=
 =?utf-8?Q?SJpNpauHWnVRwMbw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbf94411-cd6e-4ce8-030f-08da18754407
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:01:56.0083
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9qs6XuXHfQ6ZjKACRLXR2gN1MEi47vwu/Taxuo2/sjvHkwN2LKAuAD2HXFQTtiALFMh9jQhJaFjfcNhpeHrz4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2447
X-OriginatorOrg: citrix.com

On Fri, Apr 01, 2022 at 11:47:13AM +0100, Jane Malalane wrote:
> Introduce a new per-domain creation x86 specific flag to
> select whether hardware assisted virtualization should be used for
> x{2}APIC.
> 
> A per-domain option is added to xl in order to select the usage of
> x{2}APIC hardware assisted virtualization, as well as a global
> configuration option.
> 
> Having all APIC interaction exit to Xen for emulation is slow and can
> induce much overhead. Hardware can speed up x{2}APIC by decoding the
> APIC access and providing a VM exit with a more specific exit reason
> than a regular EPT fault or by altogether avoiding a VM exit.
> 
> On the other hand, being able to disable x{2}APIC hardware assisted
> virtualization can be useful for testing and debugging purposes.
> 
> Note:
> 
> - vmx_install_vlapic_mapping doesn't require modifications regardless
> of whether the guest has "Virtualize APIC accesses" enabled or not,
> i.e., setting the APIC_ACCESS_ADDR VMCS field is fine so long as
> virtualize_apic_accesses is supported by the CPU.
> 
> - Both per-domain and global assisted_x{2}apic options are not part of
> the migration stream, unless explicitly set in the configuration file,
> so it is safe to migrate a guest that doesn't have assisted_x{2}apic
> set in its config file between hosts that have different support for
> hardware assisted x{2}APIC virtualization.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:06:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:06:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300556.512730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncO5S-0004Ay-Uy; Thu, 07 Apr 2022 09:05:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300556.512730; Thu, 07 Apr 2022 09:05:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncO5S-0004Ar-RD; Thu, 07 Apr 2022 09:05:54 +0000
Received: by outflank-mailman (input) for mailman id 300556;
 Thu, 07 Apr 2022 09:05:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncO5R-0004Al-JI
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:05:53 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ebdf87b5-b651-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:05:52 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebdf87b5-b651-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649322352;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=0rwFr/lMH4pUY5wN9eVOTb1WyMvDa/nzkPMOsZaiI9Y=;
  b=QkoxJADAgqBuYwdX6GlgP8rlaVZiA82CHXLh0gNZiMf5CuyxY+V//UfN
   CNZSoaheZkQMuruKzV9Si7VfxewcCu/vwJJCTz6A9GO6F7GggRLZ00xrc
   2u5ADpGElUNY3rMcAkdWCldMnOZbCmoWF8AK+4uUzcEJ0ZIzPQWgi3t2w
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68648913
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ugbwga7mPbGQhYbmktkOmgxRtJPHchMFZxGqfqrLsTDasY5as4F+v
 jdNDWCHaa3YY2b3KN5+bYu38EgH7JPUyIJkSlA4qS4xHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThXFvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurToSlcnHaTtlt8acEgEATx5AqIf8ebIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQTaiCN
 5tAMlKDajzySh19ZXIQK6tip6CMrEHNeCBlgQi88P9fD2/7k1UqjemF3MDuUuKNQcJZj0OJv
 FXs9m7yAgwZHNGHwD/D+XWp7sfUhj/yUo8WELy+99ZpjUeVy2hVDwcZPXOxrOOlkEe4V5RaI
 lYN5ys1haEo8QqgSdyVdx61vn+C+AIdUtx4Eusm5QXLwa3Riy6bG25CSDdCYd4nscYeRDo22
 1vPlNTsbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bphDFQ8tnEaW1psboAjy2y
 DePxAAhg50DgMhN0L+0lXjFnjatq57hXgMzoALNUQqN7AxjY5W+T5e18lWd5vFFRLt1VXHY4
 iJCwZLHqrlTU9fdz0RhXdnhApnx5KaLEzT9j2VoPMh95SmqxHH6dNlftWQWyFhSDu4IfjrgY
 Un2sAxX5YNOMHbCUZKbc75dGOxxk/G+SI2NuuT8K4MXP8MvLFPvEDRGPxb44oz7rKQ7fUjT0
 7+/eN3kM3sVAL8PINGeF7ZEiu9DKszTKAruqXHHI/aPjOL2iJ29E+5t3L6yggYRtv7sTOL9q
 Ys3Cidy408DONASmwGOmWLpEXgELGIgGbf9oNFNe+iIL2JOQT99WqWBnO5xJNM8xsy5c9skG
 FnnBye0L3Kl2xX6xfiiMCg/ONsDo74hxZ7EAcDcFQnxgCVyCWpexKwea4E2bdEaGB9LlpZJo
 w0+U5zYWJxnE22fkxxENMWVhNEyJXyD2FPVVwL4MWdXQnKVb1GQkjMSVlC0r3dm4+venZZWn
 oBMISuHGcFTGFk4VJ++hTDG5wrZgEXxUdlaBiPgCtJSZF/t4M5tLSnwheUwOMYCNVPIwT7y6
 upcKU1wSTXly2PtzOT0uA==
IronPort-HdrOrdr: A9a23:E4UMOaofmrYf3ynFVT+XYSYaV5uwL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ
 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGNXguNbnnxE426gYzxLrWJ9dOME/f
 Snl616T23KQwVoUi33PAhOYwCFzOe74K7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W
 bIvgTl7uH72svLhiP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv
 PLvxA8Vv4Dpk/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69MtkWyqcz3BlkMB30a
 pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS0NI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa
 1HENzc3vBLalmXBkqp8FWH+ObcHUjbIy32AHTr4qeuon1rdTFCvgQlLfUk7zc9HMlXcegB2w
 zGWp4Y4o2mAPVmKp6VP91xM/dfOla9Mi4kD1jiVGgPNJt3c04l+KSHq4nc2omRCes1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68648913"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R0PceeB5oZc6ZvhaFBit8PpnRlYlOTzaqBOMZejF+bYRJXWQjV+vR4fe9CUJA2y46wDmD+DqxVqVxJSh4u4HPKsMw+u/nJ5gYToTls3ZLDb0GbVboICeZzs7WDzrgBDzQHs45NfSeQltJSlKrD6WBYCTSxPibPP781oV/IaLVcZ4Cm4NEMXM+0rA5iE2eK4oZROhsbSl4gg4pfzE1iuAG2sAbnJPB4Y4lPQ/iwBmeseqsTmuh8QUibQmp/4q+8ofi/lHyALHxuuatd8Rt/T2M6eBj/W4JhnYNVzMeQAjAu6zsjrXeTCYql+1SqtJ2r/zR3tng7xAzjoihwNNV+NJkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=97FY5pGFaDyDA4WaxUBvufnFLrAolBIUYgsh1p3FBlo=;
 b=DS+lcIC9nyXPeoC+J1PSFZHIbf2eh459P+PbhqkcvrrT+5HWQEmkul6ymFyg4kXYIiMjVMSWnXNRUJSPXfNlaqSq2s0l/fQxUz8110eKYr14GJ5z9WPXAYRWrPBsqI2AsJq5M4x95+hEz+J7o5rO6ZBUue8K9h08OdWT6aeugctBla8jFoo8hJ6AAnTRCcp8w/jvNqJ8JIO9Q32mtGk+MKSNurqKDjfD+DkeH0vekWIbj6gkyi/Qo1UAGAJmwd3HkRAQDyh+9GSirLq7Wg/6+yHPsIJF/AaVFl92p6fp5YPzxPG1/54dE2npROtTcaslXM34Lme4E4wZwFmM6zYgQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=97FY5pGFaDyDA4WaxUBvufnFLrAolBIUYgsh1p3FBlo=;
 b=B5vhkivgjGEiX8UHyEZKb53y6G54D5pREEORux6pofD5DCzCIylzDDO+XM0viXLlT0CxkcNvDO2VGbqs1LfZ9Z4zZEJeEf5VHLU7F9OndCinCtHKZFaEvg6DdCXWx2P7qGMKABlt+iQACF/x/rpaUiOy3wGIrFbyRTXAomG63GU=
Date: Thu, 7 Apr 2022 11:05:43 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, Jane Malalane
	<jane.malalane@citrix.com>
Subject: Re: [PATCH v9 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <Yk6pZ8QkaC7QPqvv@Air-de-Roger>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-2-jane.malalane@citrix.com>
 <Yk6glX+SHMyY/GYF@Air-de-Roger>
 <de79b53d-0129-ee14-f7ec-fb7fb768b27f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <de79b53d-0129-ee14-f7ec-fb7fb768b27f@suse.com>
X-ClientProxiedBy: LO2P265CA0225.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 87dd7dad-7c8f-40f8-43ad-08da1875cdc3
X-MS-TrafficTypeDiagnostic: SN2PR03MB2286:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <SN2PR03MB2286012BA330AE2E5C4B88198FE69@SN2PR03MB2286.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LujoEJ+UAa1vR+GUdnAkx8HnFSH2LxEBGlPZKPcfRmcSKhqT8yaITZWgP2ppzZzmeS+4XFIml3Jt1UuSyIBoHG48zxAHJ7Emq4POXd4SWkjxISPkhC9CQeMZhO9vwFLpcQ2sG8MwK8X8Y2bxpVisqJr0xaUHviKQ8nmDLa36c8G4TEB/uT3jwyZCoLZOZLGYiofThO6OcxYbBl80i2th/UPytCGHuCgaSS2uPChWkCtjAt+lSO30M+raj7L86GctNIMy7Etm7MBkB6/FbUS3Bk+gy8/CTV9Q8K0lVHbHl8T+AdEUOF5yIG1zxZXAIUprvuY6A2yESb7KuwwNd4yf7UQQbNqLb5yhDUssb2rOc0oAsJxswBPz4Ejp7AlvFbNLoufH32p5+MZNu2v2h09ajmkD+WgwyWGIucfMrRPTbD2B02yPmAYYPO41c6ww8HW+H0qAkpbY/7DWN2500Km/fscZ5A4JIs7Fp1GRzuRiO4q8yfIH7VZn0Pf3oylk4VD+s8hWh2FieLI89a3nCpuX/8QS67O4kcYuxEuxTnztWal52k7D1bQWcLVNlY/YhEaYydQ206cvIHqG+hsy5RzWuwyk47quNDw7U3AokSOdxpMyNoPbSj2baGPsUWYHzaTemlMuHOqRqGbMrHU1Qgm4Gw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(6916009)(4326008)(85182001)(66946007)(186003)(26005)(508600001)(7416002)(66476007)(8676002)(8936002)(316002)(6666004)(6512007)(6506007)(2906002)(9686003)(33716001)(107886003)(83380400001)(53546011)(38100700002)(86362001)(82960400001)(5660300002)(6486002)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0JaNHZEZCtna1FxRUQ3OGU3LzF2aW9uYlhHcktMRnJQTzl0Y1dxRlZycUgv?=
 =?utf-8?B?dGJvOFVqSXEyM2tZcmNGKzFIc1owY3hiMEwzTkcvY2dmQ1RMazkxMnFCakxx?=
 =?utf-8?B?NDNUZm1UaVhzenpyZFRCZ1VBRTExNzlmU1NUSmVQNmRMRVZDNHF2ZGRQaE96?=
 =?utf-8?B?TW9ocklJRUZ6SXVCNDRNd3NZcFBlRittVTFacS9nUHBJQnljeC93aEU4VlF0?=
 =?utf-8?B?b01IaWlBL2QzVUZuMDRybks4YmYweHk4Mm1uWUZMeVdDNG5mdGFTZzJxQXRt?=
 =?utf-8?B?cmVmc2phQ1lDNlM4Y2h2ZXFGQ0xVOTFoRm5NYmVUUGd4MEx5NGhkK1FEL3Ja?=
 =?utf-8?B?eXM3S2FqMDZOeHVXV2c0RVhTWTR5VDlyQ0RJKzRqUjZHOWxKZTZsbHpSNERY?=
 =?utf-8?B?cUVVa1EwMUl6a0gxRlduaEpBNEh1WldmRlBZZG9nUVFqK1JWeHM2cGFwODZk?=
 =?utf-8?B?TTNUZjRTeE8yaEp1cjFFeDdJdktkaEdKdm0wVTlKME5MNjR5QXdzQ0ZuL2Iy?=
 =?utf-8?B?SXlUTDlxVm44SUI1VG1jTUY4Y0lKR21DU2NvblVsOTduVlg5SmZPZEpqWUxw?=
 =?utf-8?B?TW50VVRXY3BEdlJhdzJ1emxWUkFiRWovcnN3ZTNMZGQvOEFLMUxQN1p5b1A0?=
 =?utf-8?B?c0lpem90UHZJY0NjYTB3aE9icklJajgyMzZkd29vTGtjNnl0T1BvRmhPa3Rq?=
 =?utf-8?B?OXRzSzVuWlBWTWI1VzltamtCU2EzT0xJaFhZV1JXZU1uTEVLcTdPQzIxdGZH?=
 =?utf-8?B?WkF0QnlLTHVqcHg5VzVJd1NCSGIvQjZXbUdtT3JzMHlZMWxWZ2FKZ1F3YTFO?=
 =?utf-8?B?ZjFtVzhUampJcklROEgreFhRVjYrdXNGS0tlZnlqWnI2NklLdmF3SUVWaEtC?=
 =?utf-8?B?K0JZSWZDTkRhMFk0eUNCcjRidFdjWDdYaHRYejV1LzllY3Y3NXJnSU1TSDhv?=
 =?utf-8?B?ZU45ampKNjJ0R0pPTTVNK0E4d09nSWtsdWdxeWZQYlFVMEtsQlNjczdEcGJh?=
 =?utf-8?B?NmZQcDNpd3kxbk5HNEw0SVg3ZUxQMlZPSFN2L1hsWUhqL01lelVyaXZLamx4?=
 =?utf-8?B?ZjJmaWI3Z2VvdkNiS2pTWC84bVVyNFBoVDlQMU4vOWxjUkFJMkFYSEUxUnNC?=
 =?utf-8?B?cHFlWnF2QlpRK3ptT2FrekRRaUc2NXByaU9YbDVqb2Y4blJwZVMzQU9QM2RE?=
 =?utf-8?B?bU1LVXJmY0tBTUFwdzEyM0RZZWlnd29tbTdtZGlTZVNMaXIrK25jT3pHWHEw?=
 =?utf-8?B?KzF1QTFtdGw0b1luZm13b3c0VEgrM1hqaG53c3N2a0ErT1c1c28vUnZpemY3?=
 =?utf-8?B?TnVZN3d0UWllcjdjRkpLN0ZyU1NaemlWVGR5S3dwOUVDMVpIMmwxRjhHenY5?=
 =?utf-8?B?U0NFdHd1UkhzY1RFSFR5WGtVck5NR0xHR1M4ZVVXYzhleUpkY3RtKzRiN05L?=
 =?utf-8?B?VExzbUhYc3lPcS9RbXJsTTZzeWRkeS8vMWtoUmpFVjhVRHJTbGFoc3ErN25n?=
 =?utf-8?B?YVVpWWx6Q0tsdDlnS3ZUc25LbVErQU1YVjlsZm1vZFYzMEo3WXJSYTJXY2FD?=
 =?utf-8?B?NE4xbnI5RjBIQVVNUzdtd0JnTUYwQUNCWURzc1hVRmlUNEJqUFRTV2NCQ09z?=
 =?utf-8?B?ak9wdGxCQk9tYmx6aloxLytFMWlvVUlZSlB0ckg5bkR6L2pwSHZ6SFdhd0xY?=
 =?utf-8?B?aTE0MXlzRkROaW1pNmFOdGs5QXpVMWhHSS9jRS8vcytsbHNzamVIVGtWQ2N3?=
 =?utf-8?B?aitXTlhnZDU3ekYwQXBlK0piMTRBZC9Sc3VHTW1taXBtZ2pud1NkdXZ5L3U1?=
 =?utf-8?B?SzVNZWRQWmkyMXVncW5LME52Z3hHS1RIK3pqbHM3Q0JLbWNBUzBaTWRoWjFY?=
 =?utf-8?B?ZWd3NTBuOEc3RC9qeUU0U0hWeXlDVUV5emtwdGhHRCttZlkwM2hySkxXVmRL?=
 =?utf-8?B?OTJZZWs2L3NETmkxMnVZRXpNVkw1NGVldm93QjFvdzRHZTZZbC9hS1pSVlpW?=
 =?utf-8?B?OG9Xb1hVVGtEQ0IzYjhFUkxjc2sxM0tFTDduL1FJcis1VE9qSkxjSTU4QlE4?=
 =?utf-8?B?Ti9BQnduRDA2TXUyd2t4M2daL2ZBb1pSazRJT2lRdzJ3MytRemxtckpXb3FQ?=
 =?utf-8?B?NW5SV0RaVEZxNTc3Z2JXakdvZFVOek1yOXFpTVE1c3pCbU5wNkg5T2Y2aCtv?=
 =?utf-8?B?TmZiL01qNnMwaWFFMS84elJlQXBHcmNMWHdsSkZvaVFqbW5LWGZnRi9CeW1D?=
 =?utf-8?B?WFJtK2p4RXJiK3llKy9RaFZ2WGtKcHQrZzBsQWY5aFdjN2hOMmhhc2ZLZ01l?=
 =?utf-8?B?c3V5MVl1bkViRjZtM2Q0VElPb1hPc0xjdHdJUlhxTmJ5VnFqV3FBS281U2RW?=
 =?utf-8?Q?g3m0PGAXQ76xnHF0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 87dd7dad-7c8f-40f8-43ad-08da1875cdc3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:05:47.0587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kqUIpCBzwzaMgbaA4ZkQ4+7HDr9onjBwvb4TWsX8GgLReR3aC/bkjCPXrUE1rT1IxpHm0sePOB9xzOmvduvv1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2286
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 10:45:10AM +0200, Jan Beulich wrote:
> On 07.04.2022 10:28, Roger Pau Monné wrote:
> > On Fri, Apr 01, 2022 at 11:47:12AM +0100, Jane Malalane wrote:
> >> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> >> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> >> @@ -2145,6 +2145,12 @@ int __init vmx_vmcs_init(void)
> >>  
> >>      ret = _vmx_cpu_up(true);
> >>  
> >> +    /* Check whether hardware supports accelerated xapic and x2apic. */
> >> +    assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
> >> +    assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode &&
> >> +                                (cpu_has_vmx_apic_reg_virt ||
> >> +                                 cpu_has_vmx_virtual_intr_delivery);
> > 
> > Setting assisted_x{2}apic_available should only be done !ret, or else
> > we might be reporting those capabilities when VMX is not usable, which
> > would be misleading IMO.
> 
> Hmm, while I agree with the observation, wouldn't it be better if all
> the feature masks were cleared in case of failure, such that other
> code using the predicates wouldn't be mislead either? (That would
> likely want to be a separate, prereq change.)

Possibly, yes.

vmx_vmcs_init failing will lead to start_vmx failing and thus the
hvm_function table won't get setup, so I think we got away without
doing the cleaning because there where no code paths using it
anymore as HVM was disabled.

To not delay this series anymore it might be easier to just set
assisted_x{2}apic_available inside the !ret if where the keyhandler
also gets set.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:23:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:23:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300563.512740 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOLu-0006zp-Gk; Thu, 07 Apr 2022 09:22:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300563.512740; Thu, 07 Apr 2022 09:22:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOLu-0006zi-Dj; Thu, 07 Apr 2022 09:22:54 +0000
Received: by outflank-mailman (input) for mailman id 300563;
 Thu, 07 Apr 2022 09:22:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncOLs-0006zc-Or
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:22:52 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4ad3cf3d-b654-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:22:51 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ad3cf3d-b654-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649323371;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=JyEumARdcZ/q3QURekD/nEisKxI9oAoukv3P7eGFKgo=;
  b=CcROWpn5BpvEdA80V+UEg1zMQP3sgqI8Vhj4xXxT1fd1byABhj1trzpE
   70/C7nuRRNEATrVFAuWAwDY8+Lr1MbuoBB/8vbpjdcXF6ckcFZvxF3ahO
   DBmMkL7P4F3OSKRs3Xk6QUdJ4goapio8ib4/xiG6GhzmgscKW3crj1e1M
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67662869
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6i099q5ewlVx5CsW7XXAGAxRtATHchMFZxGqfqrLsTDasY5as4F+v
 jcaUD2OPv6CYmrxLdlyYYS1pElV65SAzNdkTQM/qy03Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThXFvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSvch8mI4nyh98YSihWDDl+OpNa1K/IdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQQqiAP
 ZpHOFKDajzgUyNCBGtMDa4Us8aKu3WlXANB8W6s8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW73XcPARcbUV+6p/iRiUOkXd9bb
 UsO9UIGr6I/6UiqRdnVRACjrTiPuRt0c9hNF+w37imdx6yS5ByWblXoVRYYNoZg7pVvA2V3i
 BnZxLsFGACDrpWKcmqS65Oqsgi3IBkbMncCYhEYYRsKtoyLTJ4IsjrDSdNqEaiQh9LzGC3tz
 z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNtFsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWW0bb1HRcBJG9GRF5iLJ904DNZWfhoBDyr8UWW1C
 HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66IP4AeP8UhK1DepUmCgHJ8OUi3zSDAdollZ
 /+mnTuEVy5GWcyLMhLoLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q
 o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwJzryYo
 SznAhYwJZiWrSSvFDhmo0tLMdvHdZ1+sWg6LWorO1Op0GIkeoGh8OEUcJ5fQFXt3LYLISJcJ
 xXdR/i9Pw==
IronPort-HdrOrdr: A9a23:w060o6GwZZPNpmZ/pLqFCpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkTuRYTzrdHGeKjM2YabQQ/
 Gnl7V6TnebCDwqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP0f2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aqSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7uvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wM9HdwGOtx5Dt
 //Q9dVfYF1P78rhJ1GdZU8qOuMexrwqEH3QSuvyWqOLtBzB5uKke+y3IkI
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="67662869"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gK+wLqufx9d11XaZyCef/kIqG/wr7ZymJNr2g0HwnfdyKGmWTEzsy8IgaE82ezHfrBSj1TrCdnO4OxV+Yae4eRT/gQEuKatj4HEWVAGKvNL1cjTWLBPG9VSmRuqUAfQ4mKNRIkPH+B9SscTOzxi8eiGDYjZgtcft8kEbMBYlU4DV26WuXbYoR+NANEcnBR52Fj/0Mw9maQ1uvSzNKjqEb0H1d61NeEUMdQ2ylL41oQ8reBUkqTE6KtFenxzHoZp9XvtV6/wgy/FffkZohIFsnjfRG4MgTbl/Tq9vzzwxZ7uie4P1MVMHtliKMoP4TTfJo6NA0RzzVphJW/CCexPuzw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BoEkVdeuF0017vsm02abjyJ5Ut7M4pi8LJ13OXWTqw4=;
 b=RtZlUTkM77KA8Cr89u8IShDW43oTm8aNH6Sp6vIQS+f+3GCaw3mzJLTkYfCjSiFCZBHC3c71y3mYN++oYKtHu+TB1LZgSSInOXhUcsKi4zoLmqHxAGVy65bP++b18BffiXrs7Uklk4ux/0y4/r9Wx54Jdn+1tXwOL0mV7wJ8NVoM8129lqM88Q7QG6VxMWFhfTcqpIFoexwG+hT/1oqXBTJyaYxVOP10JTKnpDcr1d15cvajofdozYHXri9igZyIOZK1Y+LzLtl4OQVUnI7qvRudn+AUrKawEWLf0Bxmwol/SA64z/snpa7bxNQXGnr7e9hfKMKGRGT8xYLOkj7NlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BoEkVdeuF0017vsm02abjyJ5Ut7M4pi8LJ13OXWTqw4=;
 b=GWeWOoJmtiM1QW4stO6Z8CNRal9Q2c72eXIKaBmE+xnkINO5ca5T5Fdg+QsXb7iObQ9a+w+zeNBHgQbsfAx90H1c1A4Zzfj2CvLDNL9UowRSuySV6kz3QGCuv7t1oNbg1Nli5y0K3TpiLgzftKbxGJby++WSFuXdut6fuh4+kF8=
Date: Thu, 7 Apr 2022 11:22:35 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] platform/cpufreq: add public defines for
 CPUFREQ_SHARED_TYPE_
Message-ID: <Yk6tW0Q9ROWABn4l@Air-de-Roger>
References: <20220407081828.38747-1-roger.pau@citrix.com>
 <1d05e311-d466-b729-ebd6-178554f67872@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1d05e311-d466-b729-ebd6-178554f67872@suse.com>
X-ClientProxiedBy: LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::11) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7bb73d3a-f1e7-4259-e541-08da187829b1
X-MS-TrafficTypeDiagnostic: CH2PR03MB5174:EE_
X-Microsoft-Antispam-PRVS: <CH2PR03MB5174CC328584ECD8C19122688FE69@CH2PR03MB5174.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: vvTMo4SsWAfc2ogejTkdeXhiZgbP9uWWal09d33hnT38VaaF6AjEpHijQ1ZfdvjsdfSkYwAUOpYI194SplCrRVhbY6K53Jgow7gxGrmIcS8Y5NIn7CZxomF79dybS0X93OqPaypPvgw1M8erb7aGVMfIuJHzfaeNBACEEtgZg7m7x2t8kXsUihjhQrzYw9gkipRi3QORI/6sNg/JExx+JYNTmPRhx0YAQ7pxIj8GZeoJW+0765B74nmGGkCR0bXA9mjaDtOYAvr8j8LNn8WKM5KbPWlW15sp05aVLrM3ecy2XgaIc9e5jsES9462ZOKh0bGL65rmitWOxwB/UG1w6BwzQ3VdbCncCGy+LsocAS4961TuEXDehZykhqkBbIy0u8udS9plFwzKRAtdGj6iRKSMr9xTMvCAvva7syFgPFg3kJ+hwBoQLMsOeZscc7K/KKyVAvonftG1XlobaCuWa+T644W2M7latkg0XEtx+gBNO944RRiX13mwoGQp1MFQA8BfIqzL2Kugh+qB2c9IxhYHaq27u5bKPbkVSTyOUIUhxb6sDIDqywSDZNu6TAea/0kYvrqMmfyj5AKB02SfQztje8Qk2KAzaLeAcc+7nH+yjYQBGC169MTBIKSwJr0L+DkCon1J3mO0V3F4Qmc/3g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(26005)(316002)(186003)(6666004)(86362001)(33716001)(4326008)(6506007)(6512007)(6916009)(508600001)(54906003)(9686003)(2906002)(53546011)(6486002)(66556008)(66476007)(85182001)(66946007)(82960400001)(8676002)(8936002)(83380400001)(38100700002)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkVwaW1LM3FsbFN0ZUZQc0lkMWlWa2Izd1Nhc2ZBYmNiUDJURGZOZXVYd3Q1?=
 =?utf-8?B?WE5COC9KSlFxTWR3VFNVUjV3NDQwRlYzTmYrREM5U0hiWUd1TFNGWjFKK3hT?=
 =?utf-8?B?M1greWhoNmFwM3VDMnJDQUhWVEhka1lhZ21zWGlEaS80dEx1TnpkeGRhZndl?=
 =?utf-8?B?cDc5N0Z6RkpnVDZCYnZJWkQySGpjc2hIdEI5WXFHdVFTTTBPdUM3OUhjUXJ1?=
 =?utf-8?B?OWRmeVFVS3prY3J1M05aQkM4U2hBMlgvNWh2dXNvbzBJczR1ZXRqS01rRFU5?=
 =?utf-8?B?SDJVa2d4Mjd6Rm5QcXZVcEZYWWNZbWkzcXpGSTZaRG5XT2NXUzBENEhZNXdL?=
 =?utf-8?B?T0hKVHlwSStkOE5obElVUzZzOG1KaFhBRTNMTlB6SmUzUGJOOThib1pickFS?=
 =?utf-8?B?QnMwK3dUYWdlQWJOV3VaNERUaEdrWDZTK2NESDVxTEJoK0c5Z1JoL1lrKy96?=
 =?utf-8?B?dStHT2VOSDBvdkVUSkxEbVFBci9NbXRKTFNvaWZTckxGekZEQVhRRi9jZkJQ?=
 =?utf-8?B?Nk90QUdRRHE3ZFhNWlRuakZHdnBHSFpwQ3RTaXBlQ1FXTENsODQybnhjUVVh?=
 =?utf-8?B?UlZhb0tEdTRGaXFJRzFVZUVrekQwUmxwWVc5OUdSWFVVTWozVSsxVFJJNWVw?=
 =?utf-8?B?cFhodHVzZ3pTdUpHMjlucktIRU9XMURzN09wOWpQS0VQT3lmdThQM0xXUmwr?=
 =?utf-8?B?NmcvbnpaNmFNcjJJWlhvZU8rRGoyaXRBS0tZYlljNDYxeHlxcTJlcm8zK1B2?=
 =?utf-8?B?Y0N4aHRmOEpFK0xDSEFxSnVNdDE0VldKd1lxeVhManhNb2F1U0dSMURkbU4w?=
 =?utf-8?B?a0R2Rkl0S29FdG5PeGt2NkxpOVNwRlRuRE1WOTVEd2lXWjY0UHpMZlZnV0pV?=
 =?utf-8?B?VWZ1TC9HQjZ0cVRIb213dlgvRm5XbFVoMkFabjZLRHUvSVRjM3FTdWx0QkV0?=
 =?utf-8?B?SjQ5aVh1K00wN3VObldVZEwzdFhxWWMzVUJiY3hETnRBTlB1TlAvdktoVnMv?=
 =?utf-8?B?NzhvbFJ3dEk2cTQ2UytjQWF3R0w2LzhiRmZlNmpRMlc2eVVYYS9JTW5OZEpT?=
 =?utf-8?B?M1RpRk12ZitIQ1VoWVFjNW90V2pJY2hvQnIwVG9ZTks4Mjc3V3c2WDRKSExU?=
 =?utf-8?B?TWQyMkhVVDkyWGxpRVdEbEJ6TUlBT2hFUzJCUWQ3Z3VDVUJOWkdyWXhxQldV?=
 =?utf-8?B?Ri9TNG9Cd3NtUFhDNlhudUdGLzZpNEp4UXVQZlRkQldOYTYxV1Rob0ljYVJn?=
 =?utf-8?B?ZFZ6Z1JYUndtOVN0eWMvZHB3ZStRaUV5UldiTUZVNno2cEZlUzMyY1Y4eDhP?=
 =?utf-8?B?QVV0SXFBd0dqWVJtMEFEMHR2OGg0Z29saTNTOHpXUFJsZXpEbm1vNEUvdmJS?=
 =?utf-8?B?VVNVdGZJQ3lTRm9Hd0xkK2VjcVVqUUNpK1ovQmdOMGNuUThRZ2xlSjlLcTZn?=
 =?utf-8?B?UUo3ckZ1c0Z3NThpTnFPQk5IZjVENjBXM3hIMks5aVBibGQrTjFUUlJZSW9I?=
 =?utf-8?B?MkVjNFY5U0ZCbWZHUVgxbkp1c0Fyd1hIMHVxNkYxc3pqSzl2RWJtYnE1Q3lm?=
 =?utf-8?B?Qyt6akhLSWd3bmFyWmxKai9ZTTZtNmxNQkhTa0NsMk9mV2YvQnp0WHQySEN6?=
 =?utf-8?B?bXo5Ly83elByWDJlQStwUGVpYnJOYlY5c1NkSGNDMVRVbkpwNzhpbFFZMWdH?=
 =?utf-8?B?Q2lyQXUxRXlUaCtIZUpla205VHkrcUg2TDFkOG5ta2puZUhndTY1bTJVY0dU?=
 =?utf-8?B?N0xHMDNESDFDOXFnb2hwZXJxTlRkKzVCajRxTDRUM3ZOMXloMFQrMmZmellX?=
 =?utf-8?B?cmF2KzFOSUlzdVdzY21CSndMdjlLNzVjR3dNdnBHa2FQY2k1TUkxSVErOTFy?=
 =?utf-8?B?NFI5TVpBaFZ4YUN1YndPUDVpeTkvbDFxOWJaMURNMDNsUlRrMDByOEp5NTlF?=
 =?utf-8?B?R0w1OXk1cWZPNlBhY0dyTkVOS3dwbXp0K3lMdGc3Zi9STkoyMTd2L3JMRE82?=
 =?utf-8?B?VWovV3Qzd3VnclQ1elFGU1pNYnhDWmVtcWNPRzFZWW9aQlE3bE9ZR2V2YzRR?=
 =?utf-8?B?SFlSaHVhTElydEJTMWQ2aTlQNXM1N21yZU5PWHBlelpla3dJQ2lhTmI4ZVdC?=
 =?utf-8?B?ZUVVQ05obW1ZbUp0cmJGSHlJa3U0TWNPZm04U3M5TDhUN2w0ZzRSZ2ZGNUtE?=
 =?utf-8?B?MmN1MHJkRndrY1FxMkh2cTlxMERPR2NvR3FnZnBiUVl6VlBiYjhoMXV5ZERz?=
 =?utf-8?B?RjZWVTFIeENIU3VrM0tjcmFueHBVOW1wZjJsa3dTT3psbzczWjBHak93WHdF?=
 =?utf-8?B?ZnlJMXAxZy9EVnpRTXNtcWlDeFMvNzJ2NlBKSjBra05LZWxQa09Ya29mOVlu?=
 =?utf-8?Q?T9mDq2K7ksU2T39c=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bb73d3a-f1e7-4259-e541-08da187829b1
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:22:40.6024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PmCfhYE4dCTVTHitmzc0f1JNOsJCkOmmdLBmu0jRgBvS2qpYooUKxTMU+8Fvc69DU8JVnLHCbWuh5tnI+UQaIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5174
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 10:48:50AM +0200, Jan Beulich wrote:
> On 07.04.2022 10:18, Roger Pau Monne wrote:
> > The values set in the shared_type field of xen_processor_performance
> > have so far relied on Xen and Linux having the same
> > CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
> > public interface.
> > 
> > Formalize by adding the defines for the allowed values in the public
> > header, while renaming them to use the XEN_CPUPERF_SHARED_TYPE_ prefix
> > for clarity.
> > 
> > Set the Xen internal defines for CPUFREQ_SHARED_TYPE_ using the newly
> > introduced XEN_CPUPERF_SHARED_TYPE_ public defines in order to avoid
> > unnecessary code churn.  While there also drop
> > CPUFREQ_SHARED_TYPE_NONE as it's unused.
> > 
> > Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> with one remark:
> 
> > --- a/xen/include/acpi/cpufreq/cpufreq.h
> > +++ b/xen/include/acpi/cpufreq/cpufreq.h
> > @@ -78,10 +78,9 @@ DECLARE_PER_CPU(struct cpufreq_policy *, cpufreq_cpu_policy);
> >  extern int __cpufreq_set_policy(struct cpufreq_policy *data,
> >                                  struct cpufreq_policy *policy);
> >  
> > -#define CPUFREQ_SHARED_TYPE_NONE (0) /* None */
> 
> I realize this is unused, but do we really want/need to drop this?
> I think it is used implicitly right now by assuming the value would
> be zero; this could do with making explicit, in which case we'd
> need the #define.

I don't think Xen uses it explicitly, all checks of shared_type are
always against a specific CPUFREQ_SHARED_TYPE_{HW,ALL,ANY}.

I don't have a strong opinion about keeping it however, I've just
removed as a cleanup, if you don't think it's helpful I can resubmit
keeping the define.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:28:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:28:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300568.512752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOQq-0007mK-4n; Thu, 07 Apr 2022 09:28:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300568.512752; Thu, 07 Apr 2022 09:28:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOQq-0007mD-1e; Thu, 07 Apr 2022 09:28:00 +0000
Received: by outflank-mailman (input) for mailman id 300568;
 Thu, 07 Apr 2022 09:27:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncOQo-0007m7-NM
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:27:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02976ab3-b655-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 11:27:57 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2059.outbound.protection.outlook.com [104.47.6.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-9otTH9cQNGysJqkhjb3Xyg-1; Thu, 07 Apr 2022 11:27:56 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB5507.eurprd04.prod.outlook.com (2603:10a6:208:110::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Thu, 7 Apr
 2022 09:27:55 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 09:27:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02976ab3-b655-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649323677;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0IrZylJTpCAzfeSRjCQ3TVLzNp2tEk2Z4BxiHpu3jec=;
	b=hg6KESjQmQE3iAhs0tDQRJHQNamemz2TRxP+zdYa4ji0rnE+WYULivPXpaDIVFIyHjfXSQ
	B+LIjm/Wln+5WTvVpQVe4aB+wn4CuOvfa23LFL/wyw/fxAeV+G1HtpH9XGMlcoeOzNhSgV
	AdnoldSHwgPEJDOV/mb2iq9VHXJ0+/Y=
X-MC-Unique: 9otTH9cQNGysJqkhjb3Xyg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cKk6qagDZQFV3w5j38n2fD5jpJ1jicuw/eIZoPniNXGyTlIHc9RaTXRmpGmJ8rV6d8uJ5xhKEyzpXxyYG3qhZAFHchJ/41KW9uVIMiVu+sGUixXTcDYIJB70gmkY6Mrwbb0+mStvhQFfu5a/aEvKRCvzV4OvmrztVLXkqBqN02jByZi6kb8Ph7WWfM1N77fGl08zd/DX62+86IFg325Dao0zBVTFdkaCczWZTZuCxRlbScSN9gzllNCSkS/lZl7uIv5TiK8Oxh5/XlNjclJwcV+Uhx+dZ+EpdKV5mQGXjaOgh3g+48UP6XZS5iPMyCGdi4nKxi2pJ+KDTFIVYMlFGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0IrZylJTpCAzfeSRjCQ3TVLzNp2tEk2Z4BxiHpu3jec=;
 b=bBg+IaoNUordQHDzpuCZ9riviFxnSczYx4wJPC4devL+OXB/v2jBoyYGJyeOHbDdA1Dn/l8gnrpVPMoACkqYXtqMbNzjbBx/NxdVN8x2ZqmT893MeAhJlENMEWQ/64UPENJhNRIQaIR0EW908kBXxjPaSim36xcoC0LZXTxzSx1iY1Rif2Z7LTyzduHYlV3skBryfJ6kXU/Jt+QZmbTN9ISXdmn6cJVhr0OqCVI4y9eZitz3i7xzzuuSbaSByAGm4eYa6YO/evteocIhDjB78VBm+6lfLW60kfC2ThSAg0ABHwxy3PoGDUlLlnFBQhizbzI3qy3WhUOaIn9Oh0tEVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7671478f-e7c0-c43e-6395-1adc70333e04@suse.com>
Date: Thu, 7 Apr 2022 11:27:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: [PATCH v2 0.9/2] VT-d: don't needlessly look up DID
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
In-Reply-To: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0010.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5cdd8ea7-612f-4902-7572-08da1878e562
X-MS-TrafficTypeDiagnostic: AM0PR04MB5507:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB55072F842206F56998709BB1B3E69@AM0PR04MB5507.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xezOVYSmxcYXWldNOhPvZNbFmg30dC/hKzq7hDgQt2ZOqjKm57qgXKFZPUX2Z5/pKk7Cr+Xm8+lWUsGD7JRuD0+p4ec3vHsP9++RA8367yjfI7t1biBUxEI3HyGFUFGWY4OTa+zMLj4Ua4WxeSp8KCfeHMafslJ3YsArZPNp6K6DyDQWiBZpfe++fP98Bn2ps0orUZm5kH71n6oBt1cmLggZJaQzocEsXe5r1NAPNerWtOVX3pWTpYsTHDzZqm/cZiYDjk54+FTUqEhaNOJ45aAR7w61lMKpLxoNHBdC8YlybqOmEM8dF6Bx6eA18z5yx2sREB0kWWwztBqtQylfcyz/Qdzya2+2zEnU1ZGYatUVDsezClD/ZxIlZvGCoR3zaCBB4vSzKr4IppFHhhjE3rkq3DahdqbEnBGOGGoy0FJ4YGYo/Izm7rZBz7de7rAbm+pytvyLjFgq9kjmY1/3UMdTbFatNSK04JWev6F23iCXFYbwTOryuGD3tnMFvLJ20oHHvB/PULyrsYKd/8uVC3fISBJYWg6ox5wL2+XeX+U4NMLzT2JiWCVgzm/wxVhzGAx10EkVZ1t3B8a3M+YxuiUjF99ZKFsRyyQlZYXmHSoNOG8xaa9kV0+v3cVmVh/chk4B6/XPolSJX6arffzYcg+JUKXSf7/KcXHcAt5S2vIvGAbEUDJ5PVH05DzOWDAZ1OnkL/55MyLQS0h/9gnvg0jwNhU3/y08Wo7cvMoq3Qc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6486002)(6916009)(6506007)(6512007)(26005)(54906003)(316002)(2906002)(83380400001)(2616005)(186003)(38100700002)(8676002)(66476007)(4326008)(8936002)(66556008)(66946007)(31686004)(5660300002)(86362001)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?by95UFJYTytkanFxNmJoUXIveWRUTXFuRmU3ZkljZkN5OXVSelVBWkhuRHcy?=
 =?utf-8?B?cWRPbzVSZG1wek9XbjBicnZrejR3U2drOHZLdkxVVnBBZnNrb2RkcUE2K0NY?=
 =?utf-8?B?WUJTSDZxMmw3M3ZDQkJ5d1lUbi9CVk1XY1dwK1dITzJhOHJWaWtDVmJPWEZQ?=
 =?utf-8?B?cDJjMGg5QzJJSmV0cnpPYWZqWEM5UU1sZkptTisrTmVQNEYyenhXNXVTMmc2?=
 =?utf-8?B?S002WWpyc2hUTnlIUHZxWUU5QlI1RUYyNGZBMnpSL1NZQng4Y2o1eld2aFli?=
 =?utf-8?B?NjdGMUp1bW4vMEdsUW1UQXIycWhFNlU5M0pSbXN4N1UxeEwyMzJDNmZGS0ta?=
 =?utf-8?B?cnBMbkZVak0wYWRNanI3Mm5Ta3Z4VmJLdmtyT1p3dHRYMDdhekhmSUhRdkVt?=
 =?utf-8?B?Z0JZYWJmY2M4Q1lUcFlsbHhwNWtnK0RmRUw2ZXUwRm05OGsrTWFicGhvNmxF?=
 =?utf-8?B?YjVLSGw5VVpUY3BUamZKWUlrbENNQ1lwOGRZc2JBSENYaVVFQW93eFZQcW0v?=
 =?utf-8?B?QVRFSUtPVWsrNUlvbXlyWUpwNnRNN1lTUnp1cnZEaTVJNjlBMHF3eDZ6MTM4?=
 =?utf-8?B?NUJFdXo0aU9OOHF6ck1Ga05CZzFQdWIrdnN3eDZNZzMrSHNlV21oUUEzWWhE?=
 =?utf-8?B?ODdqTXlvOURaL1ZEVG42a3g0dFBNTXVmeW1wQzFJa0c3ZzdRS2tFS1NjSjNI?=
 =?utf-8?B?ZVZNemxYRHpUQlpGRFlOS2dKQitBeG9aYTh5NjlDQmZvWWlUL25UeVFQV0Vm?=
 =?utf-8?B?YWpRTkdIUVp3b3UrOElXMmVUTDJYbWgrWnJRaTRXK2todndncGFVSHljY2Fq?=
 =?utf-8?B?cHVOWUdHeDBqeGNySUlUcjdFY2t4RU92OEVHeDBPcjlBZ0E1OXZ0ckZTRmwy?=
 =?utf-8?B?UTFuWFhQVUM0ZFdrR0JtZ2t1VjUwMmhIQnBaV3VXQVdxQ3pHYjdycUowSU82?=
 =?utf-8?B?WDN4dGpQSFp1eWRCQUJEcHFCWFZydnBUbU96R1hDcm1zcldjRVlFaW5FTmdF?=
 =?utf-8?B?VVFqSGJpeWNOeG5pZTgzU1F4dkNwakJ6Y1hKSmpoWkhZUERkRldtOFFXcmg5?=
 =?utf-8?B?cWUvTU9XY0hYWFBURTJ2bWN0UTJ6cTlsMXRDSkU1bGI0a0NEZXJMaGFvMGtF?=
 =?utf-8?B?YVdyNUhOQVB4UDJyanZZaGpMMlR0Yk53dVhyNGlrcnNibUtqQ1VVeEpZRTh2?=
 =?utf-8?B?Wm5DSFo4eUxlMktNemhXRWJCZU5pUzlYZ1VrM2hrZkFscEM2aGNBbjVFeXRF?=
 =?utf-8?B?S2hOYVd4ZWsyTGNZVHZyT2ZWM1l1ajdTbFYvY05xcHk5MG0wTlFMMWtyV2oy?=
 =?utf-8?B?ckY2MEc0d2JtbjVaV04ycG11cWJ6TVhsb0FnYXBXTjF6TWlkckR1cHlJcHh5?=
 =?utf-8?B?b29yZFl5M0E4RldWM0g2ZDhBcVRFZHYwOSsrSHN2Wk1SRER4TFphQ2poY1lS?=
 =?utf-8?B?enBKY0xGT2dGWkJMbFV3TUIxM2pRV0dIemZZZnppTFVSMEhOb0NpeVY4b0kz?=
 =?utf-8?B?cjhLbFg0MndSeXRyNmZCV0doY1lQSFgrUXRqbzZvK3o0b0VFbHJTeFZLR3Yz?=
 =?utf-8?B?STEvUU5kUU95ZFpyYkhJZUJFY3F4dDg3MGtGZFNKNDFlamY5U25vODlJOTFF?=
 =?utf-8?B?VFA1Z0RuYklzTGQxL2s3Y25sdkJwdVFUVC8xUFV1aEZIekI1SkNONFA4Y2ND?=
 =?utf-8?B?QWxsSU5GaDA5d1NqeUhTUFlYay9WNy9wd3hJTVVPWFZSN3lkcVZMMUp4bHNB?=
 =?utf-8?B?dXB2S0Mwb1dSQmtTSXFKUUs3bTVicjluWTl1Z0JQb25qeS9EaEhJaitXRklD?=
 =?utf-8?B?dHRaL2gydXhxMW4wM0luOVRDejNrbEVLb0NMMis3ZTBFaEtDN3FJRzVpSU0w?=
 =?utf-8?B?anJlQitvYU9YU2JmS1UydjZscUd0dkxKZGExZHprMnNJMFF0QUdFK1dnbDFI?=
 =?utf-8?B?TkFCOTBoMFNhQzJSYjNIM2RveElJeWJKR0lQNjd5bENYbVMzdGxxTTNKbFBG?=
 =?utf-8?B?M0JIMGFjZzN0cGFrdTRYYmxydlFiaFE3VVlJUURaQlFiU2J6eGNhME81b0t2?=
 =?utf-8?B?QzdCdVpUZUlrb3FVSzlKRTVLWjRscktzUFNjbHVrL1h4MEFITjMxeDUxM3VS?=
 =?utf-8?B?UXlKVHduNXpqUFBRVWhkZUJhUlFsbk9hcnM3aThFQU56LzZYdXZTUnFEMUVI?=
 =?utf-8?B?ZVFrcFVHYkxJWXdRZmQ5TFdBdS9NZ1krWnpvVXovNVgrTmFFempHQnNyYjJO?=
 =?utf-8?B?Zkt0eG9od2V5RnFBUi9hRmRVK3h4dWRFRWhYRWpUVWpsUlRoZ3pZdlhqZEll?=
 =?utf-8?B?bUxXSXJGbWZZMWRNa2hMT0hsd09Ccitpc0hHM3FxbGErVERoOUpvUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cdd8ea7-612f-4902-7572-08da1878e562
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:27:55.1329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yC97r7LOGS9qa2PDJ+uKnoBR3IoxliSCv+XsbTy+tsAPRkpUJciCFYfDJ9DT0f2/I48HyEotwwEPCc81HBXKpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5507

If get_iommu_domid() in domain_context_unmap_one() fails, we better
wouldn't clear the context entry in the first place, as we're then unable
to issue the corresponding flush. However, we have no need to look up the
DID in the first place: What needs flushing is very specifically the DID
that was in the context entry before our clearing of it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
This (an intended follow-up to XSA-399) is actually a prereq to what was
called patch 1 so far in this series.

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1830,18 +1830,12 @@ int domain_context_unmap_one(
         return 0;
     }
 
+    iommu_domid = context_domain_id(*context);
+
     context_clear_present(*context);
     context_clear_entry(*context);
     iommu_sync_cache(context, sizeof(struct context_entry));
 
-    iommu_domid = get_iommu_did(domid, iommu, !domain->is_dying);
-    if ( iommu_domid == -1 )
-    {
-        spin_unlock(&iommu->lock);
-        unmap_vtd_domain_page(context_entries);
-        return -EINVAL;
-    }
-
     rc = iommu_flush_context_device(iommu, iommu_domid,
                                     PCI_BDF2(bus, devfn),
                                     DMA_CCMD_MASK_NOBIT, 0);



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:32:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:32:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300572.512763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOV7-0000q0-MG; Thu, 07 Apr 2022 09:32:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300572.512763; Thu, 07 Apr 2022 09:32:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOV7-0000pt-JA; Thu, 07 Apr 2022 09:32:25 +0000
Received: by outflank-mailman (input) for mailman id 300572;
 Thu, 07 Apr 2022 09:32:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncOV7-0000pn-1f
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:32:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a180c455-b655-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:32:24 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 94A37212C2;
 Thu,  7 Apr 2022 09:32:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5B6E913A66;
 Thu,  7 Apr 2022 09:32:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 5vzuFKevTmJVLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 09:32:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a180c455-b655-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649323943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=iMz/fVk+XpC4IDojCtgZdhSbgaH5sJ66FU6YyYC0dAU=;
	b=srp3svmAJ66vDcJogBKiIGdVGuq5CEJs6NzN+Dq5b4+v+huIvNyS5C2rdiaVbhfch0DbrT
	75BoiGD0hZpc6CLImwmff34i2BgedTfCkHnIdUGSlX2blYRSglJ9ApB8mrYmE1yFAMAhOC
	HK7B66ciQOpkaSSp/7AQBiyKBcgA1u8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Date: Thu,  7 Apr 2022 11:32:21 +0200
Message-Id: <20220407093221.1090-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
initialization") only zones with free memory are included in a built
zonelist. This is problematic when e.g. all memory of a zone has been
ballooned out.

Use populated_zone() when building a zonelist as it has been done
before that commit.

Cc: stable@vger.kernel.org
Fixes: 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index bdc8f60ae462..3d0662af3289 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
 	do {
 		zone_type--;
 		zone = pgdat->node_zones + zone_type;
-		if (managed_zone(zone)) {
+		if (populated_zone(zone)) {
 			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
 			check_highest_zone(zone_type);
 		}
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:35:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:35:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300576.512774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOY6-0001R0-4t; Thu, 07 Apr 2022 09:35:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300576.512774; Thu, 07 Apr 2022 09:35:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOY6-0001Qt-1q; Thu, 07 Apr 2022 09:35:30 +0000
Received: by outflank-mailman (input) for mailman id 300576;
 Thu, 07 Apr 2022 09:35:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncOY4-0001Qn-Qy
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:35:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0ef0e694-b656-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 11:35:27 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-xv1h-gyNNN-zTdEjA486MQ-1; Thu, 07 Apr 2022 11:35:24 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM8PR04MB7955.eurprd04.prod.outlook.com (2603:10a6:20b:249::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 09:35:22 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 09:35:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ef0e694-b656-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649324127;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MAUXw3cP89AymUKIjB7co3uqbixDNYuXAJVcJsJ6lMA=;
	b=SF2Rennc8aDfunzU1Tuo4nD8uveMfpzH8cq6M+78s/qKFBxRD4ME/UkNrd2QuYxghhMsvT
	RxFxm9PJY7iYh0fBxAVeuCxiEuqoUgR1AF6OzIprEiStukstiuymgSHQvSQQVa7cfz78IM
	KwX0rXjtfdQ4CS3nWzVaI3KjapNr/Kg=
X-MC-Unique: xv1h-gyNNN-zTdEjA486MQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mYHxayyrfQ4L/YfUeCfszPjL12Ay4+LAhmDuE6CkJLtBOP8q55ew6nB7UUulQoBbUVYUK6D9WSiZUfHMZzRfnNtXKwvT0owe509spYU1b4SDkYqb/yjvcOsE9Ggs/Dj6PlDu7ZMeu33/SHEfCCgpBjynFhZF2Z3k6wynrkruyRVnLuFZ6pNRgS9vEIlwkKgvYavJP7K+KHqaEkhUd/DK5LUr8QqvmAIQiGvKK8G4QzkKvIkh26ObBs2WxA92fKfuJcDIcCyGryRyXcmT10L7UywHf1Rg91xsC1IQk2dF4+/jm7fCEEM0NQgzN16atM2xX+ccjxk4MH88zwt0OL5dsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rqmnFV86czVWPs5sMKoEdYF2ER9xYGyCET3b2wi+2UQ=;
 b=PSGY/5Pvw49IHefmBswIhSDUW09fHdqqxGoYBByNR8/0EVVf4CwY8LtucXudb6So7X/rU8CzdGoTdPOYTiwH1CKIlJHcDhfqlgeGeem+iXNEiHy15cz9rYkFxJif5kurl3TLHEUpCtUmi2ip8ggLon7lSG28rM+Idklt5xIuDyNLX8MhvFBeOS0rof7ss4ktXZv/JBYQTYqhGgO30YdZe1EN0D8ADsbYPgmPSkuw9SGcRrfEK+2WH9gyOIvHO4UHJV/w827+COSnlrQ9ReyVu9ALiTMMKPuJOII4hbtzxsEs1ESlQ6ULnsSIZ7Fln+MzlL6wz3eo1zx0d8iayKKFLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <edfe5d74-9ff2-1fe5-7078-f72ee6ed4f5e@suse.com>
Date: Thu, 7 Apr 2022 11:35:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] platform/cpufreq: add public defines for
 CPUFREQ_SHARED_TYPE_
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220407081828.38747-1-roger.pau@citrix.com>
 <1d05e311-d466-b729-ebd6-178554f67872@suse.com>
 <Yk6tW0Q9ROWABn4l@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk6tW0Q9ROWABn4l@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0021.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 472ec749-2877-49d2-2b92-08da1879f00e
X-MS-TrafficTypeDiagnostic: AM8PR04MB7955:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7955DBFA5FA2AFBA00E16D9BB3E69@AM8PR04MB7955.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AN31ucGeM/MBLn4wqoqJpkpq+7WwZbY2CL4q5dhN3wJCaktGrs2pjnfASCjCx7dl5+5T3mVwdB40q7Lwhxjilx1MXILN3AS+YeYMrdKlNiS6zoc04hWlcrvgKIzuJUppWPN0B8DHFCP7kCNDjFAGGte0mkl4kLNClwbMbAlCELQJUMvzpmrg9p27Wcpvv12+/ZkM+gsoXFQzS7+/nXSUUQJw+NNI4s74pDdIa8hodKmW9Jz82GhP+GSYK+pqlgl06t4E+P5GYiSk/Lbbp7CT1wthgnsTdpMIfm7MrQeRgg/ltHEV4gd4JPaU2LsTttUViX7g8lug7qUlQNRV6jUyvmLOoK+AmTPdnLhEdrK2wBOuUQ0JvMKkz5D2J/t0tHZYRSl1qrEPzRr9MrKkPKh5KjegcQEF/AevqqfHldRIvk2GQIIQ4zJ7buQMX/qBpArniaPMa7q2NgKijMNXgoh8k5W1llBJw6sLx1vi64hkdfY5fatCJscPj7DiTSz/XCv+KulYKnqB1fHYtPYTVldGoMkHydyqKsSpL8ScDHc5Md0D5E9pFIsvTdeHG0fCb2SqxYgXBoltN/dS6hmDPmO0OYHADodI0KWn49kYNGLa0gYdTjqEHK5cAF8XziFtIhHMxEgTx9Cw0TGEDQGFlH3g0tEjdRrjZMmvGKof2xjotj4Jd2bV3dCdTTYbqdeg7qMWvmysIfB//+wIMbH+Mks2XsHETFCsErtxvHjllfvlblTDn4nkTM1ToC9JW/Gl4Sv8
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(2616005)(2906002)(36756003)(5660300002)(8936002)(31686004)(8676002)(31696002)(66476007)(66556008)(86362001)(38100700002)(66946007)(4326008)(26005)(83380400001)(186003)(316002)(508600001)(6916009)(6486002)(54906003)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fGP25Q7K5MijU16IvEmiuLQgfnJZUVscYggdqVnbo+eu7nG3Nsx0sZRvwTRh?=
 =?us-ascii?Q?pTTEdbjEaEjd2Ni+bZb96ec5HvDIrSLZFMCGoDODUKdXF0aNVz0PlesDX2HP?=
 =?us-ascii?Q?KZx/I35+bBfx8F+qc3Odw5+2X1TZGdobFGKnu8qhSh6Ywp5zXle1ars5Bv4A?=
 =?us-ascii?Q?2ak36YpE5mE+VTTUMpeul3FwRfzi9jRKtRW5uZ5VYZ5CQY7GLiG7M6Gtcj2s?=
 =?us-ascii?Q?U1GBV5lXWcDd5tmwe+jwzk0p7tfv8leqrJs+vg+nxjqcDqt7lsLrVz+Rplqp?=
 =?us-ascii?Q?DE7C0A37MpteltvTPZP70YNODEFZluUOgYmqBY/4anwY4NX/FZaz7AclgIO9?=
 =?us-ascii?Q?u3/fkCD7ov590Yj8vxOHcm+9q6qX7rpWaZqK6g+WUj1je8zI9uph6AKjO7J/?=
 =?us-ascii?Q?R2Wrf49tDDLQgnj+axYF7CcCtaHjLSHRqz2iGqjqHiDJE1eU/pBYhmLwmd1e?=
 =?us-ascii?Q?vBaYbWCJ4aRQchVAuOWF5G2rnVZ7oqvaNcuko4eQYDeEZdyUbB0CXOJrnXS/?=
 =?us-ascii?Q?k++eWVG4LpUJMD5Ob6WH2Xw9CQtWn+vBoVIZdkWGCo3d4jl2pUvekDtlp+vV?=
 =?us-ascii?Q?b0UZwb3Icj8ai8IY95zXbdnNztbvIJ7VvJe5MrpkkT6hc1TlU1yqUleirwSo?=
 =?us-ascii?Q?m+MN4CMCuvhVy9+Z5THMx2BzeVesOel4+sbuggTpxZeQa4s4NgEgnSoG0+DS?=
 =?us-ascii?Q?62Znt7vA4CZAjDOWkl0C4CmiquHh8OG3raVIEu9Pe++IrWrYEv4odLDWgY8c?=
 =?us-ascii?Q?apSq8m8G/3OB5ngl40TQoFtRPpm//ErYaMMMcqCQcZBbIOwUlMc27W6D5UBX?=
 =?us-ascii?Q?xN9Tgm69dIYLbtgqyCwo5vjqoIPFs8cixwG0sT79vPI4W2tg5n5KHItdLWed?=
 =?us-ascii?Q?FfaR+AnpQ/To642LQ4Ay2Jy0roxsxiU4ae9kcl13Jps7kvz8x5LfI7mpxPPm?=
 =?us-ascii?Q?FC9o+2esYNdphrg2JmWkeQ96aFAWzje6SuszGhCbdBgYQK3Cd7Y0UyEKzJie?=
 =?us-ascii?Q?e8W8IqFwnpwTqCAi+AyzD64qSnjfYfToiUWISg+PSBB6ZEorIYUEf/mwfEZY?=
 =?us-ascii?Q?6Npk2K69qyqmAI3o7JqyYUlmX7WDeZ7qHL3zRrI/1Kthl7kL4tADH6XtWM35?=
 =?us-ascii?Q?W46qS6/Ibs0XHTWLmwgleBAk10I+PgbWbfIn0fEES+LSlB31Avqtey7ZGVYV?=
 =?us-ascii?Q?/i3Mc+/y+Q1Qdxu7bjAn0G/kXTHWveQ7Xu1iDaqrFQ2zVqVmNhQelYmY0GVP?=
 =?us-ascii?Q?wfuG9cYXfJtDUYdx6rWHt2N9FdRfqaRR1r9vHcda73FyNCBORMLP/o9Hw69Q?=
 =?us-ascii?Q?e+F75uj6Ak27rr5SGRyyU4dopc7k/ZfKcBf5IsHrrnMJtssTSnhONgXmTfIQ?=
 =?us-ascii?Q?auFHwBJ9hVIZ6WYSeuoGLVKD1RamFFcgr9cqgTpHUVBkfu05sYxJPxIN5NqD?=
 =?us-ascii?Q?IiDFQQAPfGvwhR8H7THw8Lr70qMinIsjp/87KVh9D5+EPqQ83g2XzePn0vSn?=
 =?us-ascii?Q?WBi7XSi3WRlShOmv2KpoAXoB3nrjFkmIS5QuPGHvWd+s7adnJwM0YBI/63Fb?=
 =?us-ascii?Q?Lqesr3hM7RYe8HITSfIJqUC9EIEYQyjAccEWsf+f7rHE30ylg5mSlkzUrldE?=
 =?us-ascii?Q?CrxILoxy+dAbdXnxSeVf77SFj/ZiR8tzgTbQbKws+1+rf2hOmFcgc73BszZO?=
 =?us-ascii?Q?oBSjJjSRJvzGgdzLGc7qgfCZqC5JnR5nvEbPREoINJQXuQQWQkWcBmwI80Jd?=
 =?us-ascii?Q?7EwGCcGxDA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 472ec749-2877-49d2-2b92-08da1879f00e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:35:22.5791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MuXjALpKVH7u0VYUXpiDJnL7rTqeRTHiaOv1vjwNlUTSskSDsd/r5fauS2OyyzkNtAqawsjtbPlM6wpwBNdLTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7955

On 07.04.2022 11:22, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 07, 2022 at 10:48:50AM +0200, Jan Beulich wrote:
>> On 07.04.2022 10:18, Roger Pau Monne wrote:
>>> The values set in the shared_type field of xen_processor_performance
>>> have so far relied on Xen and Linux having the same
>>> CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
>>> public interface.
>>>
>>> Formalize by adding the defines for the allowed values in the public
>>> header, while renaming them to use the XEN_CPUPERF_SHARED_TYPE_ prefix
>>> for clarity.
>>>
>>> Set the Xen internal defines for CPUFREQ_SHARED_TYPE_ using the newly
>>> introduced XEN_CPUPERF_SHARED_TYPE_ public defines in order to avoid
>>> unnecessary code churn.  While there also drop
>>> CPUFREQ_SHARED_TYPE_NONE as it's unused.
>>>
>>> Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> with one remark:
>>
>>> --- a/xen/include/acpi/cpufreq/cpufreq.h
>>> +++ b/xen/include/acpi/cpufreq/cpufreq.h
>>> @@ -78,10 +78,9 @@ DECLARE_PER_CPU(struct cpufreq_policy *, cpufreq_cpu=
_policy);
>>>  extern int __cpufreq_set_policy(struct cpufreq_policy *data,
>>>                                  struct cpufreq_policy *policy);
>>> =20
>>> -#define CPUFREQ_SHARED_TYPE_NONE (0) /* None */
>>
>> I realize this is unused, but do we really want/need to drop this?
>> I think it is used implicitly right now by assuming the value would
>> be zero; this could do with making explicit, in which case we'd
>> need the #define.
>=20
> I don't think Xen uses it explicitly, all checks of shared_type are
> always against a specific CPUFREQ_SHARED_TYPE_{HW,ALL,ANY}.

Well, I said "implicitly"; if there was an explicit reference, you'd
have run into a build failure. But I did check now - all comparisons of
->shared_type are against explicit CPUFREQ_SHARED_TYPE_*. So I guess
dropping the value is fine.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:39:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:39:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300581.512785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncObX-0002MO-PI; Thu, 07 Apr 2022 09:39:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300581.512785; Thu, 07 Apr 2022 09:39:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncObX-0002MH-Lw; Thu, 07 Apr 2022 09:39:03 +0000
Received: by outflank-mailman (input) for mailman id 300581;
 Thu, 07 Apr 2022 09:39:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncObW-0002MB-NV
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:39:02 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e43933d-b656-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 11:39:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EEFF91F85A;
 Thu,  7 Apr 2022 09:39:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C04CA13A66;
 Thu,  7 Apr 2022 09:39:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id zjJlLTSxTmKcMQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 09:39:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e43933d-b656-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649324340; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=t80M3AxgwPtFqBrAe3eNHmWvOG2zVPYy43qfmNkj2UM=;
	b=qt5W8Jyn9g+xgxIpsFNHAe1jRMg+ww9Hwr/2wces4xQ6LPSHQrPrlRsGY+8Xv7n+f2OxGf
	x1uZyqDArGdHlMfem7DcN6viT33f+H9GiS03IuWqZcaHygPJ410EmdfvqX5TQXY3+hFMxV
	hkiqfiqYKOpqRY4fWR5ONLyUptPfrEw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] xen/balloon: don't use PV mode extra memory for zone device allocations
Date: Thu,  7 Apr 2022 11:38:57 +0200
Message-Id: <20220407093857.1485-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When running as a Xen PV guest use the extra memory (memory which isn't
allocated for the guest at boot time) only for ballooning purposes and
not for zone device allocations. This will remove some code without any
lack of functionality.

While at it move some code to get rid of another #ifdef.

Remove a comment which is stale since some time now.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c           | 54 ++++++++++++++-------------------
 drivers/xen/unpopulated-alloc.c | 33 --------------------
 2 files changed, 23 insertions(+), 64 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index dfe26fa17e95..617a7f4f07a8 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -689,29 +689,34 @@ void xen_free_ballooned_pages(unsigned int nr_pages, struct page **pages)
 }
 EXPORT_SYMBOL(xen_free_ballooned_pages);
 
-#if defined(CONFIG_XEN_PV) && !defined(CONFIG_XEN_UNPOPULATED_ALLOC)
-static void __init balloon_add_region(unsigned long start_pfn,
-				      unsigned long pages)
+static void __init balloon_add_regions(void)
 {
+#if defined(CONFIG_XEN_PV)
+	unsigned long start_pfn, pages;
 	unsigned long pfn, extra_pfn_end;
+	unsigned int i;
 
-	/*
-	 * If the amount of usable memory has been limited (e.g., with
-	 * the 'mem' command line parameter), don't add pages beyond
-	 * this limit.
-	 */
-	extra_pfn_end = min(max_pfn, start_pfn + pages);
+	for (i = 0; i < XEN_EXTRA_MEM_MAX_REGIONS; i++) {
+		pages = xen_extra_mem[i].n_pfns;
+		if (!pages)
+			continue;
 
-	for (pfn = start_pfn; pfn < extra_pfn_end; pfn++) {
-		/* totalram_pages and totalhigh_pages do not
-		   include the boot-time balloon extension, so
-		   don't subtract from it. */
-		balloon_append(pfn_to_page(pfn));
-	}
+		start_pfn = xen_extra_mem[i].start_pfn;
 
-	balloon_stats.total_pages += extra_pfn_end - start_pfn;
-}
+		/*
+		 * If the amount of usable memory has been limited (e.g., with
+		 * the 'mem' command line parameter), don't add pages beyond
+		 * this limit.
+		 */
+		extra_pfn_end = min(max_pfn, start_pfn + pages);
+
+		for (pfn = start_pfn; pfn < extra_pfn_end; pfn++)
+			balloon_append(pfn_to_page(pfn));
+
+		balloon_stats.total_pages += extra_pfn_end - start_pfn;
+	}
 #endif
+}
 
 static int __init balloon_init(void)
 {
@@ -745,20 +750,7 @@ static int __init balloon_init(void)
 	register_sysctl_table(xen_root);
 #endif
 
-#if defined(CONFIG_XEN_PV) && !defined(CONFIG_XEN_UNPOPULATED_ALLOC)
-	{
-		int i;
-
-		/*
-		 * Initialize the balloon with pages from the extra memory
-		 * regions (see arch/x86/xen/setup.c).
-		 */
-		for (i = 0; i < XEN_EXTRA_MEM_MAX_REGIONS; i++)
-			if (xen_extra_mem[i].n_pfns)
-				balloon_add_region(xen_extra_mem[i].start_pfn,
-						   xen_extra_mem[i].n_pfns);
-	}
-#endif
+	balloon_add_regions();
 
 	task = kthread_run(balloon_thread, NULL, "xen-balloon");
 	if (IS_ERR(task)) {
diff --git a/drivers/xen/unpopulated-alloc.c b/drivers/xen/unpopulated-alloc.c
index a8b41057c382..a39f2d36dd9c 100644
--- a/drivers/xen/unpopulated-alloc.c
+++ b/drivers/xen/unpopulated-alloc.c
@@ -230,39 +230,6 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages)
 }
 EXPORT_SYMBOL(xen_free_unpopulated_pages);
 
-#ifdef CONFIG_XEN_PV
-static int __init init(void)
-{
-	unsigned int i;
-
-	if (!xen_domain())
-		return -ENODEV;
-
-	if (!xen_pv_domain())
-		return 0;
-
-	/*
-	 * Initialize with pages from the extra memory regions (see
-	 * arch/x86/xen/setup.c).
-	 */
-	for (i = 0; i < XEN_EXTRA_MEM_MAX_REGIONS; i++) {
-		unsigned int j;
-
-		for (j = 0; j < xen_extra_mem[i].n_pfns; j++) {
-			struct page *pg =
-				pfn_to_page(xen_extra_mem[i].start_pfn + j);
-
-			pg->zone_device_data = page_list;
-			page_list = pg;
-			list_count++;
-		}
-	}
-
-	return 0;
-}
-subsys_initcall(init);
-#endif
-
 static int __init unpopulated_init(void)
 {
 	int ret;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:41:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:41:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300585.512796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOdf-0003j0-5o; Thu, 07 Apr 2022 09:41:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300585.512796; Thu, 07 Apr 2022 09:41:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOdf-0003it-2E; Thu, 07 Apr 2022 09:41:15 +0000
Received: by outflank-mailman (input) for mailman id 300585;
 Thu, 07 Apr 2022 09:41:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncOdd-0003im-JU
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:41:13 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d7edbf93-b656-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:41:06 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7edbf93-b656-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649324466;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=WTGLgbQ0WkBnRcIFG0/J3+KcjhKLJrfkPfxNdAj+Czo=;
  b=PWxTStJAl8IvWzBkVC76+FLfqK6oQQYtdvlvA4JNoF6x9d95IxSy6U/v
   c9P5BunF9T5JoiRLuq6y7OBoZWIe8NH82NZq1uVV7EF7KkdOJwKEqTf+Y
   PwoTt9J/nO4IM3bXsZ9PHo3wcaiFO3VA/cwr1nOdMs7J+mqnE/D9ZywYR
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68140121
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Ktl9r62JllocnUY+J/bD5f9xkn2cJEfYwER7XKvMYLTBsI5bp2ACn
 GUaC2rSMv3cMWume90gOoSxpkhQuZDUzt5jT1E+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIw3oDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0Oi5eTUlooYZfQv7g/fRVWFX9hELVJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u1pkSRa+EP
 qL1bxJBRg3uOS12IGwwN78Uk/+u2lzjWBlx/Qf9Sa0fvDGIkV0ZPKLWGNnYZN2MA9lUl0Cwp
 2Ta8mC/CRYfXPSHwCeB2mKhgKnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHsg/IHc4MOSatgsljLk/eKpVbCboQZctJfQJ8Yv+wtGD117
 EOuw/HHCTJp7qK4UX3Io994sgiOESQSKGYDYwoNQg0E/8TvrekPs/7fcjpwOPXr14OoQFkc1
 xjP9XFj3OtL0abnwo3hpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX
 UToeeDDtIji7rnXzURhpdnh+pnzup5p1xWG3DZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif
 VXevwhcjLcKYif7N/8qPtLuVJ1zpUQFKTgDfqqJBjapSsIvHDJrAQk0PRLAt4wTuBZEfV4D1
 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7BohIvZ8V692
 4sOaKO3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrLbeVo5RTt5Upc8A9oJIuRYokicrc+Rl
 lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEZD5EB1BLjV6T0Zoi
IronPort-HdrOrdr: A9a23:rhuULqOJMUSARMBcT1j155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu
 vi2iMLnUvqRZxRBf7Lc0UtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+XZgNdNvpfvHHeFAlYSi8eV56cm6XXJ3uBRr22urKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68140121"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QX5wNIUbwP+imZYiGeT0g1+7Jz3Y0zjorFZOKlET0r6SNmGDwdWhGhfgP1XP8aeRzfvxXeQIs5w+ifvPjwXv7qWSWbLRWkHPZfS87EwzK9Oxle3yMC7lzKirFXEeeg5bnCkotYDbIilO6A6TkkZMzGO9q0LWYB5/Lw9tkmcn8nd+3lfDA5br4zU5/BorxGIX+X/6NsPurluEsO0eWa9VDYDWGXW97VyP2qpJ+SdzZ+GEe3tI+dZNWuqFiXjW1UAQliTvgX7BO5/yUhw4orQpCo6BpiP+q2JwiMBoSsFLRwJFikGtYns8OghaRCeuqvTfCZDdEnfwt4zKV0VuTlCSZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Bq9sl9b0QstNOmyN2kU3r7P4OKgqjlnWCRO0YZS0w+Y=;
 b=QRTKE0/w8/ltfKSr7gQqN0TJuntm0WfZ8DmhzBcZvoa061QFpcYxKA42PgghRp+ftwbQae6CWmEiYugsqXcn5sofYkWamKiF5KC0rnyVHZBjyMApHjCgt5PTpZ4bvbfHgbzV9GCnqVnvDLYKpj9ZiS/oyb0t9JRAG5KREl7n2unBZC+KeR915bFIMfv1PmfyanIpZpmzZJUxvc530YWKREhdE80AtxuEnjhloxS2uKDuJFpJeLKNnfLg0yGwhk0OFKgNDfHcQ9v5VXqZMTix9An7gzOH8hiU0NOcmy3R5d4eof3gAh+ZikkJHxYOQd7Z02pgLiLjCpLW5e7AOsR54w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Bq9sl9b0QstNOmyN2kU3r7P4OKgqjlnWCRO0YZS0w+Y=;
 b=hwbgTDmVeq8pUH8LMEJaGMAVSrxUKrcX7wacY9vH/U4RcDkmbLyZMOXKyMgqwQjiMfBGfosPMWzHDsqnL4AElw4CmX08CnqWWVO/X5xg6iXnEZ5cm0gBxr48hwECNTtoXNcv5flAWaI0IoMcXl57zjcpW6DKPWGbR45GFbAQkrk=
Date: Thu, 7 Apr 2022 11:40:56 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Paul
 Durrant <paul@xen.org>
Subject: Re: [PATCH v2 0.9/2] VT-d: don't needlessly look up DID
Message-ID: <Yk6xqHM37nXhAGQM@Air-de-Roger>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <7671478f-e7c0-c43e-6395-1adc70333e04@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7671478f-e7c0-c43e-6395-1adc70333e04@suse.com>
X-ClientProxiedBy: LO2P265CA0508.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::15) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7de10cf2-1ed1-4329-0ec0-08da187aba4c
X-MS-TrafficTypeDiagnostic: DM6PR03MB3900:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM6PR03MB390095AAC2D27E821C2202B68FE69@DM6PR03MB3900.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: XeOVQr9z7+RXZpTfaGt1XnolSelHTYhRp958KjSnv2LY0I/uaXcOdNd5XtIt4R1PldUhGjlLuBVzGgLO9wBihGMhGzhsKsWV8cIHsXU9UXqJ9nDqfQhisfl1uVjVtbdrLyibUYmFher4d12JbaFq6pPAPOSwL2C4pwo2AumgqD/2Ad4ev79JckoMdP6hlsVJNxr8a3scMI58FeFV+r8F3qsTnmkUrJtZNOl03P3N6bi25BhnI3XVVEPlrzUBtRPs3g5tsfAplc+sHXmWVTDwxwlDomcfvYl6X0UXPlt4nJpIdt3Jv071bWOQL5yMopCW6fHJ4g51I/J20uFsmYJIRC74AiRtEZrYrybnxAt5dqYOiyvE8HxH7/WxpITx4WZGWPoJmyjZdrJQN1G3h0Z/ta515JPtJQwDVM/7p4mQFNwg0Ik7OCImAsLuoxqPRYL46xkyk3I+N+cQ6ETROIrXub0aHV0lzonyN2Nxny/mNrh8QTbIhnlyeqzBXAJe8uCFaCX9DPmPkyqo+ZszvIBHtPJDWjfcpKtSbwN7ePlEHox/TRMfxrAnOwTGfccMcH8/+7rmYMg71dGY0SqFwcOJeCeBnvumkhMdLjW4NlKZV2hCyrjpM9lGCmGtcFvT7P6ZdMaWxBbGQng8gwPq+NEUlw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(316002)(33716001)(66946007)(66476007)(66556008)(8676002)(38100700002)(4326008)(86362001)(82960400001)(6512007)(9686003)(54906003)(6916009)(4744005)(508600001)(186003)(2906002)(6486002)(8936002)(6666004)(26005)(85182001)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0hNZVBIU3o3ZXdJS3phdU04VW5VUU9sWHhEQkJuVHNtbU9CRGh1a0wwaHZD?=
 =?utf-8?B?MEgxMjEwKy91Z0dYOWp4V1pKUW5IT0lrV1dEa3pEY05KZFl6d1VaWGNGQytW?=
 =?utf-8?B?Qk1hTUtraUhObU1TRXErK2hOWTErUWFWWTZDZmZody85WjBEQzkvZ05LMk1F?=
 =?utf-8?B?eWNPUnIrQTJKUU9nMUN2S3duUGJQbFkzZDlSNXN6RXJvM1hlNzdnQWJlWU9L?=
 =?utf-8?B?UlhKL2U5ellnMUJybXp3ZUxiemxKaVpYRzJoVzVlaW1nSW9Yd25WcUhYVkQw?=
 =?utf-8?B?aWNaTWsvVENiT2RqRTF0TlZaWnpDUzgrY2NILysrMHh4cEZHU2Y4K09QYTZW?=
 =?utf-8?B?cGhkOW41bkkxQjNoV25PZmVIdEd6VmJWK3VqYVRuTXpsT2dQZGRULzBwSlU0?=
 =?utf-8?B?OURnMDdocG5pQUFFREs0TkptNnVTaWplZDgzT2VzSk43RThkSzg1MHVvWm9n?=
 =?utf-8?B?S0tGRWVMR2pVejNwT3h2cTlJZit5TE5GNncwYkk0REdUT1NQSXBKOXlvY0ln?=
 =?utf-8?B?VEkzTzR3WmRuOGF5QTl6TFd6YVo1bzhqWm03WGM0dVl1Q2tNZWNIQUJGVDN5?=
 =?utf-8?B?K0tOWjQxNm92T3d0cmZZZDE1MTZEVFRtZ2hQZU4wUVVOMGZvVmhxemdYcFR5?=
 =?utf-8?B?RHNjYTFWS09RRUZjU3dGV2lPUzVxOHhEYlMvRFo0T0ZNSGlIckpSVTF2MW4z?=
 =?utf-8?B?Unl2Q29xNXFaYTRwSGpPVE5vRldsOHBxd1IxVG8zMWxZWmhCVVk2dGRiRnMr?=
 =?utf-8?B?cXRkT0J6aDVxWnJWK3hFZ3RVSTVmV0NudlJCbnV1MTExWkEwczEwM2VQVHZO?=
 =?utf-8?B?dFdiRWtMV2kwWFY3WVpiOHI5cmljZ3laOWo3TW44cnM2alNjemxXemFuQWRB?=
 =?utf-8?B?VFRNSXRYemRKVVEwbjRUU25NYTZkd2ljSFVWK3JBemo3aFhVUjNWZTZlM1Br?=
 =?utf-8?B?K2RzQ29VSmxKaHVhYU1SRDQybXcyWktQNXBVcDNoNFFYaG5tSklBMEJ2ZUpE?=
 =?utf-8?B?UDlzS2R0bWJJV1RpdGg4ZFVlZEJKa1dITVBvZHU5NUpUa3V5Sy94eG9nRm9m?=
 =?utf-8?B?TFNlMzRRTWwxbFRoQXNpVU11QndDcTB5T0xqemx2ako2RSs4NEZ1UHZjVmti?=
 =?utf-8?B?RDgyV0VuYUdCREl2dlNwcFRKSzQwaW5Gdm5xZUwzMVFGUlAveGJSUzgxbUZK?=
 =?utf-8?B?U2krOE9RMHg1cFFjK2RhN20xenBRcWJzRHVNdENkQzBSQkl5dFlrbDFsZTBR?=
 =?utf-8?B?ZGlJTTB0RFIxVkRKNHplSlVBYi9TalowdmU3T291SFp2YmpYM1huWTlrYzc5?=
 =?utf-8?B?NGY5L1FQZlhHc0ZhOXcvVnlrZG9TaTF6U2JvSHZrQUhMZDFnVm5aT2NWaVdL?=
 =?utf-8?B?VXA1VGZNalNUOUpJTGF4alQ0T205c3lDRE84cDhZeHR2UnVKeGpFclZlUWZn?=
 =?utf-8?B?bW95eVdSNUpLZ3IvQlpHbFE0K0gyajNydXBpNlZVa21YYWprRDhhSm1CQmo2?=
 =?utf-8?B?TUljK2pSa1JubGRpZ2xuRlY3YWphNTd2SVc3S0lCM2djeG9oZ1ZQTUlFSE9V?=
 =?utf-8?B?OENUcmIvb3MrU2dVS0UxYkFDVjZCa0I0R2s0cDVTSmJIdXVzOGNWb2pPaGEz?=
 =?utf-8?B?VmFyZld5Z2IrbHhWdnEyRkdlbE91OEdQb05oRDhpeVNQTUFuL3NucXNmRmRL?=
 =?utf-8?B?bVNhVC81aGY4N1dxSW5NMXJkcjdBWFo0amQzMjUyUUV0dWRhNHRwSzRsa1pw?=
 =?utf-8?B?QVdLSjE5OXpDaHl3QjdVb1JaTmtWVVVFcWZick1adHJIVzN5UW41Vmh2TkpX?=
 =?utf-8?B?bFhoM0dNT3NpdU5FTFF4Z2Rwcnp6Y3FJdXlBK0dPZHRJcVZuK0FTY3hpSXl0?=
 =?utf-8?B?dE1WU215Wlp1UGZ0eVFQRVVHY216WUR6NUFCVGY3dDhzOCsxZ1JZenBMWDZr?=
 =?utf-8?B?SW5QTURlRXJVTTJHU3VLNHFBZk03U1Btc3U3Q2c5Mysyby9Ya1gwY2FPUE1a?=
 =?utf-8?B?TTRrN1dBako4aS9la3FDVWtnblJwQnRnRURzcUpHdFVpM0N2OXFlSVljQWEy?=
 =?utf-8?B?eTVPM1ZCV0dKRUhNQjM4MnF1SC9ucHBjeUZEbDhyOFpVbmJYSm9ZbU5KVjNY?=
 =?utf-8?B?MllpbmsrQkdQZ0RZbVAvNFRsN2gzQmdKcG5CUEFmNlZNQi9zQlRIREJBMldU?=
 =?utf-8?B?cUZwelZWRkZvM3JxZXBzQUpPYVlHNjlXYmdxYVI5UWg4MUhBZzYzQXprMGRO?=
 =?utf-8?B?RlJTK0FzVk9HV2VOWGdUeWlpR3JBRnZnSUtRNU4yaXZQMXIzcG5lQnJPNlpG?=
 =?utf-8?B?K2tPa0tEaVdGbUdQb3FLaGVybmp0cFUyaERQTCtnNVlsTnBHdDRaNjdtRnNU?=
 =?utf-8?Q?05zJXpCIlTVFVMxg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7de10cf2-1ed1-4329-0ec0-08da187aba4c
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:41:01.8063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YOHxiHnyd3/aKUlAqApjl3vSQqzNDKUOPtnuF0rFiuQvcIcn6+imPHUnLOPCxHbvZvFhl3LfAxhaHiYaCB59Rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3900
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 11:27:53AM +0200, Jan Beulich wrote:
> If get_iommu_domid() in domain_context_unmap_one() fails, we better
> wouldn't clear the context entry in the first place, as we're then unable
> to issue the corresponding flush. However, we have no need to look up the
> DID in the first place: What needs flushing is very specifically the DID
> that was in the context entry before our clearing of it.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:44:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:44:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300590.512806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOhA-0004KW-L8; Thu, 07 Apr 2022 09:44:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300590.512806; Thu, 07 Apr 2022 09:44:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOhA-0004KP-Hy; Thu, 07 Apr 2022 09:44:52 +0000
Received: by outflank-mailman (input) for mailman id 300590;
 Thu, 07 Apr 2022 09:44:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncOh9-0004KJ-49
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:44:51 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5cf6433f-b657-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 11:44:49 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cf6433f-b657-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649324689;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=3n5OrzF9EKXOggYsoC6qEpeZQsYOh/aq0imU8p+1vCE=;
  b=epWAy0jS+O+5TnZxpJd8bjvBp6y6ON6KLToFbJEMJyyPo08Y48cq3t+Q
   cVh0lzpmxFz0bAAvZGwJt0+EINv19JkE7GaQ4VClWh0xVXqPZ42WMATGj
   Yl77pRPc0lL0PMIiO8DYoHr2dCuzkP+SkXwFeJGIzJTwEQHU/bhIypIFx
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68242955
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZErQiKIODF6c5ci/FE+R7ZUlxSXFcZb7ZxGr2PjKsXjdYENShjIPy
 DMdC2CDPP7fazHzL40laom+80kO7ZSByN8xTlFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY32YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 IgSkrjpchwJB5TrqeEcdD1bTgBUAJQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glg3JwUTKuDD
 yYfQWF2bBrpaiVfAVo8LLgjlb2OuCHFLwQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZxm0GazGEXDBwQVHO4rOO/h0r4XMhQQ
 2QW8Cczqak59GSwU8LwGRa/pRasvAMYWtdWO/037keK0KW83uqCLjFaFHgbMoVg7ZJoA2xxv
 rOUoz/3LWEwl5nMcmm9z46znDazHgwWcE4oWBZRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnM/
 tyakMQtr+5N1JBWjs1X6XiC2mvx/caREmbZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV
 1BUypHFvIji4Xxg/RFhodnh/pn0v55p0xWG2DaD+qXNERz3phZPmqgKvVlDyL9BaJpsRNMQS
 Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4i0DKCJM4oRPcEoHONiwM2ITRTNt4wKuBJy+ZzTx
 L/BKZr8ZZrkIfoPIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292
 48Ga6OilkUOOMWjM3K/2dNCcjg3wY0TWMmeRzp/LbXYfGKL2QgJVpfs/F/WU9A9xPQKy72Qp
 xlQmCZwkTLCuJEOEi3TAlhLY7LzR5dv63U9OC0nJ1Gz3HY/J42o6c8im1EfJNHLKMQLISZIc
 sQ4
IronPort-HdrOrdr: A9a23:wvWT4qhWbopw249fFGHqH3KjP3BQXz513DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKOzOWxFdATbsSl7cKpgeAJ8SQzJ856U
 4NSdkbNDS0NykEsS+Y2njJLz9D+qj+zEnAv463pB0BPGIaCZ2IrT0JcTpzencGNTWubqBJba
 Z0iPA3wAZJLh8sH7qG7zQ+LqP+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+iemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30l0dFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNNN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wSJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABynhkjizylSKeGXLzcO9k/seDlBhiXV6UkboJlB9TpY+CRF9U1wsa7USPF/lp
 P52+pT5fVzp/QtHNBA7dc6MLiK41P2MGfx2UKpUB3a/fI8SjrwQ6Ce2sRA2AjtQu1O8KcP
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68242955"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eBQuLIMyXHpYaixUuHqeBIWoaT94ciB6Zpu6ARAsJ/jKM4tIGLECBKGbEcr8YS1RK01vOlhHC4+1PgjV+2pbYzS57hG4rP0IUySoTbbL8q99Ao9/KcPPIvaNeQVU9Z6GQa/qDdfLuXZ4dNyUQbPAnwMsDwlkCl7cakD3hMcvWGpTFlySGDyKGluB1lgxeyEFlS4WUh1gkhWAB430DnZ/WlTMN/8BJhq6WwKlzXMBM0MkCh1PduKDA8uEoKU3SoKT3XrXGy4kYv22OGte7ZPBYJmACou8y1UPvQZdVmZXJeCTCKmZ/CTT8JNGq+yCTXOF2zRmcj5Wt3byVAAUT2ptsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j66CzFnaLl05peFo5LKAcYlaAD/N6oXFnRPL4ET/YAw=;
 b=hdN7JIF3YiQNYOpvexBG6wu6FlNGkMMJZkeDzOftZrmIIdX1Co1ML7+wLOgm6n7NGfsOOapZ5A+iISlwPO8AI6hZPt23zmDf2/QGwz/Tu9PbKXQhA25OiiSdC6w+oJzMl3Be35AinwbYGBbSN/HYYiCbj1scRLrgg22+7uhv55zlLBEPWX5JoxBLdm2W+WdLBT1u6lqaRiLK6Km/GRaCEVjruEcuxDHD3u1VBAWY2wjGSwJGmdHfRmA6LS2jFwn1aARuE78JOBWKmODzsxgsQf3c56awTIbHmtLh7wOsC35GAh4M0jmwmQ3R/5gYc5MGcZgE/1JsPQtPxhB+PWtnPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j66CzFnaLl05peFo5LKAcYlaAD/N6oXFnRPL4ET/YAw=;
 b=DWcEKPUuu0V/1/8e9YmgeRJ/7uQnTO/yS8rnSaWtL8NpQMT8ZlkyKjI+CImTKM8SdNCfGFjML345QtAY5lPRbC1qJlUWcf0EOll9kpyKUm6y0HxdQrnqRn9764cyJFV43Lw4HO+qzgys8FhQIiOdTIjDuYMHkkHSMTPWFNujFgw=
Date: Thu, 7 Apr 2022 11:44:40 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] platform/cpufreq: add public defines for
 CPUFREQ_SHARED_TYPE_
Message-ID: <Yk6yiPpV6pM4GyGq@Air-de-Roger>
References: <20220407081828.38747-1-roger.pau@citrix.com>
 <1d05e311-d466-b729-ebd6-178554f67872@suse.com>
 <Yk6tW0Q9ROWABn4l@Air-de-Roger>
 <edfe5d74-9ff2-1fe5-7078-f72ee6ed4f5e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <edfe5d74-9ff2-1fe5-7078-f72ee6ed4f5e@suse.com>
X-ClientProxiedBy: LO2P265CA0009.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:62::21) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b6e3b81a-23ca-4233-c35d-08da187b3ea8
X-MS-TrafficTypeDiagnostic: DM6PR03MB5066:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB50660FADD63287AF00B2E89C8FE69@DM6PR03MB5066.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: dqkfc61XRalqKYhb1Cj3dEwr0SP5zs8zJCMZVM6stlS/3UBH/lXxbk6zXhvvNAYKupF2lDF33xTFRJkImYua4xQ3bJI0v+SyA6j6I8QVh6oI10d0kVnFaqs/oH5Qqg5q2ZOd2lTHu7PFnQA4VtdXL47Rv98tGj421hjqtkJ8Sw6IHNQGkaM2v9Qkmpwpmno5Qdvxi2GPtwwZXys3K6bqPtzyZNU+8dh/98rftv3lXpD0ajKgcOmOXNgNg8QYoym0tljq7adFuQTQ69l5UT8HjNtI62KBeVPUMpH56CVhY1M0bY6IeXaOL7VGI+sxRDgp3gOeOqNq47607N0Rt8L/bVGDyUaoMUkdoUvoOKqfZOvjUcuQz+bVKwNvt1WXPDcDIi0vogHdtx8qiWNlPBzb/uNaI49HTvY/DPHj4UBn+CfbjdAq6lNl3ksdjeXMfke8Kmph4x2pIikLGce69j0jDaLQN0gaGIoSLi1nmwESPQMA26l+U47+MTeFPMu6zOXtAaXNtOKSANyCxZxEFewA2xtya6BDiCuLFf79h/K2zdBVJvbmCJpEn9j+AZgDjTgOZSC+NoCUMbFKIVCbtE02dhvO+H8x8PRXKbuUYtKn1c67by6tn1K25K3zETVqAgO1K1FFQ1IFHjQVV1pLJTSgcw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(86362001)(2906002)(8936002)(508600001)(82960400001)(6486002)(316002)(85182001)(26005)(38100700002)(186003)(83380400001)(54906003)(6666004)(9686003)(4326008)(6512007)(5660300002)(33716001)(6506007)(66556008)(66476007)(6916009)(8676002)(66946007)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVZXWG9zVUJnUXgwSGtDR1FtWHBRUkpQUUttakZTa3luOFNuS0IzeE9ZZFNU?=
 =?utf-8?B?MVRwNGlCSC9XeG5sV2gwcUVvWGZjSEFrRFpad0UvdXZRaHlRc2xiUHhNV3Mv?=
 =?utf-8?B?RlcyaWVMdlBoMDJCOGViK0dJRWVlTHFJbktUaFZJb1Z5OUx0Z212U0V4Z0tX?=
 =?utf-8?B?NnM0V2pQZTAwYWxsWUhMejBHQmVDYXJhZDIyMWtyWHV4U2FQQ3R0Ymo0RHpp?=
 =?utf-8?B?aXlTQmlPb25JU0x0L0JrNFVUTHJsK3lmUmQ2K2MyeHF2SE5PcjdPSEc4aDlU?=
 =?utf-8?B?cVRXMVo5bGVsZmlmdTdJVDJtS2lRUDByL1FVT1NGSVU5MVJkM0RhMGJyRENw?=
 =?utf-8?B?OVFSRE05R2h4bitxYlpZMU5pQUxOMU9WR244R2FGakllUWNFcDh0dk1IMnEw?=
 =?utf-8?B?M1V0MUJLTmsyRnYxZ0hrVHFKbDg0K1U5a0crWDViM0o1TWw4c2xwTmtuaTha?=
 =?utf-8?B?QlkwZGpTaERTbHU1L20wWFBOeURPL0dmSmVtSWZCZ0QyUFNIbmZUL3hiTGxO?=
 =?utf-8?B?c1JQWitZMXVKRk9uaTZYWWozaCswOFFlNzVidytCeXZJdFBRQWRMQUVPRmg1?=
 =?utf-8?B?YUY4Ny9qUzN2Vnc2dGhWWVR6UXdZNElRSjhqZjY2NnAyNEswMUNiMG1EbElt?=
 =?utf-8?B?RTg4ZGJyY012QitsSHNtYjN6V2NoVjZIRnd1S1pVMVNxMGQ5MWFPckg3RXJa?=
 =?utf-8?B?MEhnRk1pL2Q1amkzQmJCYWRYYWIwL09EZTJ2dG5iSDFoK2F6bE5ya2NKeldU?=
 =?utf-8?B?L29OMWVMRWdPbFJ4NVl5a1pUT3JQY3U5R0JmUWFwZWRZYXNHSk5iZnVhUVVW?=
 =?utf-8?B?dnpkbWRlblpob3YwN21RdlJ3ODBreHdnZUNOYWhqUHdVaktVZ2hCUDM4b0Ju?=
 =?utf-8?B?UzY4UFpHbzdHN0psOE8zMVFWaEo2TEJTQlVac0JFUitIUmRVVFNWdzNJaTVY?=
 =?utf-8?B?cEhSeWlNbk4zVWpHK1o0cThFMDdxMXUrekhMVFNLQ1M2Ty8vbEFnWU1rZHdZ?=
 =?utf-8?B?MUtjQ0dZSngwK01DSWZseHg4QlBOelNrQXpKTDloRitYU2JlWllQeHF1ZTl6?=
 =?utf-8?B?ZEY1TzByRHYyQ2dldFpZd1BMTTIxOE9TdVdlTm5lbWxwSm5OTmdYQVN0c2cy?=
 =?utf-8?B?L3dGYkdKVG02QmE0NURTbk9OWXVKVm5ibG5maEZPdDdhY3dBZ0pWWE90OUc4?=
 =?utf-8?B?THIrcGl1QTJrdFNFU2ZxRitJVENvWllTcHJCNUFxOEwxeERKVVFiaXkwRk5C?=
 =?utf-8?B?RjZqR0ZEa3VrZ3VCM0Q0WC92aHRHNHg3bXhGVnMrTTdnMmlpdVYwTU9SQU5v?=
 =?utf-8?B?OGhheWN6cndxaTNFYlo1aXFPbDRwSWRsL0tXU2hlbEJRNWRNNmZuRC9Ealgx?=
 =?utf-8?B?UWlkQmNDU2JHMTcwclpiamJPamRHTDFCYnR2L3k2K2cwRVdXU0xFRm9qZHhU?=
 =?utf-8?B?TGZvcU5NakxtUE9BQnV2Tk5ZcU4wU1Ryck9SZHRFcFg2NGI2TWJuVXRrOFM1?=
 =?utf-8?B?dEZDUzFuNWRScmFLNUU1NmJiNi80SDMxeXU2VDRQRXNyVVpLM0VKbThERVJL?=
 =?utf-8?B?aHlZUU5MMkhFejhWMjRBWG1jU0l0RGFCV09IR2xvdk1ZMW1hUHIrWm1UaWNF?=
 =?utf-8?B?dXRmc0p3ZGVmNjlYb2NXUDk0WXVRbDlzVjRTTzBGY3Z1TkZsUjdBMHVTT29h?=
 =?utf-8?B?R09QNENZZmd1N1U4eFFxQVdiMlpWbU54a0VET1BNdWRCY29BaFp0Q0hvZDBC?=
 =?utf-8?B?cDNTeFI1V204L0k1eFR2dXdhS1JkWTFTa2VOTlp1YTJsSmhXTC95T3NTUkg2?=
 =?utf-8?B?aHlFOWIyN0lPdWJYTkJEdXlpZ3R4MlNIYWY4TFp2Y0Zta2dKZ2I3MlNPUG02?=
 =?utf-8?B?UVpPbXdlc2dtSW4yK2dQbmgrRzFFU3RhRnNRSnlPVDZ1MEcwaklMYUxMdWox?=
 =?utf-8?B?cTQySno5U0dndWY0Q2JpTXBMdzF0UlJDWXpxOGg4YXhJQm01b1NvNUx2Rkky?=
 =?utf-8?B?RHl6cjgvVlN6U1BqTDNOeHF0WUVhazVqbzJGc2xHbVBFdS9zaXUvd2xpLzZL?=
 =?utf-8?B?S1Q3T3Y1SkVZck9hY3pkQ1lDQzNxZ3ZMYTUwWnc4YnVBR0RWRVZrWUdBc2Vy?=
 =?utf-8?B?bG5sQVNINHRielh1bU5WaFhmd0VmVy9ZaUJhT3cwbThiNEloS0R0V04vdWtO?=
 =?utf-8?B?Zlk5ZE5IMThQUG1zcDE5VlRUY0d1M1Zpb2x4MFRZUHI2dnRuM0x4S3NiREMv?=
 =?utf-8?B?SlBaUG9wTms5emJvZEwvMzV1elhmbk5iV1dMN2k5ZW5ocmIzdnFzU1FRK2hx?=
 =?utf-8?B?TTFqYlNVczFROVNEejNCWjFuakJxS2dROFRIeUNCMmNYZ3Jud2VJYlNaMUQ1?=
 =?utf-8?Q?V8C/dZ9y4AGcg1OY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b6e3b81a-23ca-4233-c35d-08da187b3ea8
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:44:43.9825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tWdKEXQFxpc/s5Onc3mz6h4D11dky2fU00DyYbR6LlUT8JCehR/UiNcRdBgh7RnHmJ/9OiGFnwS34NQCSj4x0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5066
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 11:35:20AM +0200, Jan Beulich wrote:
> On 07.04.2022 11:22, Roger Pau Monné wrote:
> > On Thu, Apr 07, 2022 at 10:48:50AM +0200, Jan Beulich wrote:
> >> On 07.04.2022 10:18, Roger Pau Monne wrote:
> >>> The values set in the shared_type field of xen_processor_performance
> >>> have so far relied on Xen and Linux having the same
> >>> CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
> >>> public interface.
> >>>
> >>> Formalize by adding the defines for the allowed values in the public
> >>> header, while renaming them to use the XEN_CPUPERF_SHARED_TYPE_ prefix
> >>> for clarity.
> >>>
> >>> Set the Xen internal defines for CPUFREQ_SHARED_TYPE_ using the newly
> >>> introduced XEN_CPUPERF_SHARED_TYPE_ public defines in order to avoid
> >>> unnecessary code churn.  While there also drop
> >>> CPUFREQ_SHARED_TYPE_NONE as it's unused.
> >>>
> >>> Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>
> >> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> >> with one remark:
> >>
> >>> --- a/xen/include/acpi/cpufreq/cpufreq.h
> >>> +++ b/xen/include/acpi/cpufreq/cpufreq.h
> >>> @@ -78,10 +78,9 @@ DECLARE_PER_CPU(struct cpufreq_policy *, cpufreq_cpu_policy);
> >>>  extern int __cpufreq_set_policy(struct cpufreq_policy *data,
> >>>                                  struct cpufreq_policy *policy);
> >>>  
> >>> -#define CPUFREQ_SHARED_TYPE_NONE (0) /* None */
> >>
> >> I realize this is unused, but do we really want/need to drop this?
> >> I think it is used implicitly right now by assuming the value would
> >> be zero; this could do with making explicit, in which case we'd
> >> need the #define.
> > 
> > I don't think Xen uses it explicitly, all checks of shared_type are
> > always against a specific CPUFREQ_SHARED_TYPE_{HW,ALL,ANY}.
> 
> Well, I said "implicitly"; if there was an explicit reference, you'd
> have run into a build failure. But I did check now - all comparisons of
> ->shared_type are against explicit CPUFREQ_SHARED_TYPE_*. So I guess
> dropping the value is fine.

Yes, that's what I've tried to explain, unsuccessfully it seems :), on
my reply.  I should have used 'explicit' instead of 'specific'.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:46:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:46:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300594.512818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOib-00050K-2j; Thu, 07 Apr 2022 09:46:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300594.512818; Thu, 07 Apr 2022 09:46:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOia-00050D-W0; Thu, 07 Apr 2022 09:46:20 +0000
Received: by outflank-mailman (input) for mailman id 300594;
 Thu, 07 Apr 2022 09:46:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1UeT=UR=redhat.com=david@srs-se1.protection.inumbo.net>)
 id 1ncOiZ-000507-Ox
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:46:20 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9221d961-b657-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:46:18 +0200 (CEST)
Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com
 [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-628-ZHB8039tNR-jm-40Dp7zmA-1; Thu, 07 Apr 2022 05:46:15 -0400
Received: by mail-wm1-f69.google.com with SMTP id
 h18-20020a05600c351200b0038e82e6321bso1344468wmq.5
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 02:46:15 -0700 (PDT)
Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8?
 ([2a09:80c0:192:0:20af:34be:985b:b6c8])
 by smtp.gmail.com with ESMTPSA id
 l28-20020a05600c1d1c00b0038e72a95ec4sm8249142wms.13.2022.04.07.02.46.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Apr 2022 02:46:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9221d961-b657-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649324777;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CIrkyxw2ltSATsongCKPkeTXMJ2u05ZyiioovqE8L0s=;
	b=cxj+M8aFF8GeLJI7MQCFr/hY8TkmAm8CBPwDFYLrtJLSFKxzH4IrBwa2eGxTg45Vyf3Ifr
	HnheAAvacCUEuFbNS1JUnkGSLtu2KR7RXYPdWBPFdZN++9Jfg6G/r1iisOG8DYPyiF7Lh0
	4sZA6Gl0ANUI74kEBxIDB65Wrt/c8x4=
X-MC-Unique: ZHB8039tNR-jm-40Dp7zmA-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:organization:in-reply-to
         :content-transfer-encoding;
        bh=CIrkyxw2ltSATsongCKPkeTXMJ2u05ZyiioovqE8L0s=;
        b=kDdjH2YWl4VEQGGUEFyg2xfQ6BreDkCLY7bM58YmNECsxJaxXsldNmVd61i6DfQ2pL
         5VupmwWyX22JR82FtsCILLMBZ4bBaxZkF80IWKc3t1V9se5XJsCmSlxeFQqedWYPW8OI
         QWHbYNos2f8WnnmUb8UqpckoQvoSvJ4Q6Yg6Nwy9/a/g+att/+HihgrzX7aCfrArtBN5
         tRWLFN1T+VdpeToccl1mDOvpTPtN+gse5xSYpr0pVeUsv4PFQSvE9luKm0/2Jz/VCGrA
         O07fe2Vp/DC20UlJgoU809l1tUE9qh2KEXNvIbv84Q9Tod4Zdpuv621So5VV1dUJLMWp
         7DqQ==
X-Gm-Message-State: AOAM531zX7QR4jXwrQsXRTpLpEDGhWFxgdc0x3yV1dAtOj+VhgNYCg4y
	YvOvF50nOQ6nIkNND7iLs7jM8qm25OStW5YJ2GlCv364aCEr/1vQLCRnFf6S2mhUhVZyaCUr/OI
	5o95uus1tuPpIjkJY+nNDFTsu5ho=
X-Received: by 2002:a1c:f005:0:b0:38c:b6d5:5c2a with SMTP id a5-20020a1cf005000000b0038cb6d55c2amr11560877wmb.89.1649324774615;
        Thu, 07 Apr 2022 02:46:14 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzaV/O4sc8yI66xNvj9tArkavzQBoS8J9F6Pviebz+CdcTWfctMEO9PWcH/8H60MajLM0j21Q==
X-Received: by 2002:a1c:f005:0:b0:38c:b6d5:5c2a with SMTP id a5-20020a1cf005000000b0038cb6d55c2amr11560857wmb.89.1649324774387;
        Thu, 07 Apr 2022 02:46:14 -0700 (PDT)
Message-ID: <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com>
Date: Thu, 7 Apr 2022 11:46:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Michal Hocko <mhocko@kernel.org>,
 Wei Yang <richard.weiyang@gmail.com>
References: <20220407093221.1090-1-jgross@suse.com>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20220407093221.1090-1-jgross@suse.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 07.04.22 11:32, Juergen Gross wrote:
> Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
> initialization") only zones with free memory are included in a built
> zonelist. This is problematic when e.g. all memory of a zone has been
> ballooned out.
> 
> Use populated_zone() when building a zonelist as it has been done
> before that commit.
> 
> Cc: stable@vger.kernel.org
> Fixes: 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization")
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  mm/page_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bdc8f60ae462..3d0662af3289 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
>  	do {
>  		zone_type--;
>  		zone = pgdat->node_zones + zone_type;
> -		if (managed_zone(zone)) {
> +		if (populated_zone(zone)) {
>  			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>  			check_highest_zone(zone_type);
>  		}

Let's see if we have to find another way to properly handle fadump.

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:47:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:47:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300598.512829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOjN-0005Y6-Cu; Thu, 07 Apr 2022 09:47:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300598.512829; Thu, 07 Apr 2022 09:47:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOjN-0005Xz-9o; Thu, 07 Apr 2022 09:47:09 +0000
Received: by outflank-mailman (input) for mailman id 300598;
 Thu, 07 Apr 2022 09:47:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qRyv=UR=citrix.com=prvs=08953f4ff=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ncOjL-0005V6-Ek
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:47:07 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ae627908-b657-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 11:47:06 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae627908-b657-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649324826;
  h=from:to:subject:date:message-id:mime-version;
  bh=P8w9wCw3Z+Rdnf0zFn5NGbSsJv1PG4q1IOZhGUUEFdM=;
  b=CVLCQubYrWQT3ixl/VAGpL0pzrNaDc4yxn2KfUM36MvhFAkulMFz8hWL
   w7rvb7h9lOlVcR9PBjwa+/7IirArw5OLj/168Gat7UMOGzzxarPIK8NKk
   AE/Iour/ikMY5LmrQITSBRbQUkZnnbSoZwgkZ/1RmaZE3oQCvWDaoIkza
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67664484
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pwrcPqipzt1CXFHZLNrQE/ZzX161RBQKZh0ujC45NGQN5FlGYwSy9
 lOraxnFY6jUMyawOYxoOc7lxf41yZGGx9Y3TgA6qSE1RnsbopLJD4XIfh78ZXvJc5aaFUk95
 pkSM4acdZhrQHbR/EqhbuK8oSR2iP+CFrbwBrDIMCoZqWOIMMsEoUsLd7kR3t446TTAPz6wh
 D/SnyH+EAP61jd9Yj4ds/mK908+7f2jsjhD4FZvOaEQsAeHnnceXc4Tfa2/ESD1E9JedgKYq
 0cv710bEkfxpUpF5gaNy+6jGqEyaueOe1DI0BK6YoD66vR4jnVaPp0TabxNMS+7tx3Tx4ork
 IkV6sTpIesUFvakdNo1AkEw/x5WZcWqyJefSZRomZXOp6FuWyKEL8RGVCnaD6VBkgpEKTgmG
 cgjACIMdni+a9eem9pXfAXOavMLd6EHNKtH0p1pIKqw4fwOGfgvSI2SjTNUMatZammj0p8ya
 uJAAQeDYigsbDVVZ1M8BIMHudyZxUjHXmBH+WCToZsetj27IAxZiNABMfLQc92OA85UglyZt
 iTN+GGR7hMybYLFj2DfqzT127GJzXiTtIE6TdVU8tZFjVqJyWFVJAAQUVKjifK4llS/S5RUL
 El8Fi8G8/dsqhD3HoWVsxuQi1+A7iMiUplpP/QD6AaR9ZjE6SXJCT1RJtJGQIN/75JnLdAw7
 XeKks3oA3p3vbSPUnWb3rCOsTa7PyMSK3QfYTMFSwRD6N7myKkrgwjUR8t5OKGwh9zxXzr3x
 liirickgK4IpdUWzKj99lfC6xquoZjPCAw0zgTRQm+hqAh+YeaNf4C180LS6+poJYOQXF6H+
 nMDnqC28OkLBIrLl2qJTeMCDbytz/mAOTzYx1VoGvEJ9Smp+nOlVZBd5nd5PkgBGscCZTLtJ
 V/evytQ4oNeOD2haqofS4mxEcUx0a/4Fdn/EO+SZd5HeJtZewqO/SUobkmVt0jhmU4tnKV5O
 paDfNyECmwTAqBqijGxQo8187IlyGYd2GnaXpv6zDyr1qCYaWSKTq0GKx2FaeVRxL2DpALZ4
 tNOLfyAwh9UUPD9SiTP+ItVJlcPRVAgHoz/ocFTcu+FIyJlFXsnBvuXxqkuE6Rgnq9Vn+OO+
 WuvV0twwUD6w3bALG2icHFqbqryXJB5hX0+NC0oe12v3hALe4Gl7aFZbZIxcbku6+VLxORxC
 fICfq2oD/hAQy6B+jsZYIL8pZdKZBWvhASeeSGiZVAXVoR8Sgn+387rdwri6gEDFiOy88A5p
 tWI7R/WXpMZW0JCDcLaZfi1xlW9lXQaguR/RVTPONpIPk7r9eBCDiXtkrkMO8wKIhjZ7jKA0
 kCdBhJwjeXVuIo07NnhjLiJtZu0CPB5GldGHm7d9vC9Miyy1mCky4VRFuuTfTTQUWry0Kqnb
 ORRifr7NZUvhlFA9ZZ7DLBvwLMW6N7mprscxQNhdF3AalWtG7p6LlGDw8hUqqQLzbhc0SO/Q
 ULJ+J9FOLGFOcXqOFEULQshKO+E0Jk8nT3T8/U4OgP+7Sp98aCbeVtbIxSXziJHRJN5L4Y66
 e4ksdwR7Uq0jVw3Mb6uni1SsmiBMHEEe6EmrY0BRp/mjBIxzVNPaoCaDTX5iLmGbtRQGkgsL
 CWdiKfLi/Jb3EWqW3ApFHHLm/VagpgVkABLyF4ENxKCnd+truE+xhRd/j0qUg1Q5hpC2uN3f
 GNsMiVdKaiD5ytohY5Gd2SwBxoHDxqckmT2z1YKj2TfQ1OfSn3WLGY9NOCO+2gU62tZODNc+
 dmw023iTSr1cOn+2yIzXQhurPmLZdZ88CXPiMe7FsKEApx8YD2NqqSnf2YPpjPsCNk9g0CBr
 u5vlM5oaKrnL2gTuao/I9Kf2bkaDhuDIQRqe/hh4adPJmDadzGa0CKLbUu2f6tlLebH90OxD
 c81f5pnWBG31SLIpTcebYYLJ7J3h/cv6MA1c7XnP3Mds7Cfozxqt7rd7iH7wmQsRr1GkMAmN
 5necBqYE3edmGMSnWLRxPSoIULhP4NCPlelmrnorqNZTPrvrd2Ab2koj7+fs2SsFTBWvCOsk
 V7cNp3Qy91LnNEEc5TXLo1PAAC9KNXWXeuO8Ryuv9kmUe4jIfsipCtO9AC5Yl0+0a85Ho0uy
 O/T6IKfMFbt5u5ebozPp3WW+0ClD+2WVfEfDM/4JWIyccCqCJ61uEtrF4xVxPV0fDJhCiuPG
 lPQhCiYL4d9tzJhKJt9MXU2//E1UfmfU0sYjXnhx8lg8zBEueA9EPup9GXycUZQfTISNpv1B
 2fc4qjyt4oI8dkcW0BdXpmK5qOUxne5BMPKkPWr61Gl4pSA2Ave6tMOazJ+gd00NpV0OJmju
 s+ULvQPXB+zpLvJ3LlkX39a5XUq4IJGqbBoJCo1oocu4xjjVTJuBblNYP0uV8AP+gSvhc6QW
 d04RDZ7YckLdW8fKkuUDRWKdlr3O9Hizf+lfmd5oB7OM37e6UHpKOIJyxqMKkxeJ1PL5OqmN
 csf6jv3OB2wyYtuXuEd+rqwhuIP+x8Q7ilgFZzV+yAqPysjPA==
IronPort-HdrOrdr: A9a23:NgG+b6H6PBr8xAlYpLqFaJHXdLJyesId70hD6qkvc3Jom52j+P
 xGws526fatskdrZJhSo6H7BEDgewKXyXcR2+gs1NiZLXDbUQeTXeNfBOjZsnDd8k/Fh5ZgPM
 5bGsAUYrCRfDtHZK7BkU6F+r0bsb26GdWT9IHjJgBWPGZXgs9bnmJEIzfeNnczaBhNBJI/Gp
 bZzNFAvSCcdXMeadn+LmUZXsDYzue72K7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFqQrk/a+u2svLhSM0llWjoai+quGRiuerN/b8yfT97Q+cyDpAUb4RGoFqegpF5d1Hpmxa1O
 Uk6C1QQvibo0mhAl1d5yGdnTUImQxelUPK2BuWh2Durtf+Qy9/A81dhZhBeh+c8EY4uspguZ
 g7ll5wJ/JsfGz9dQnGlq/1vitR5zyJSLsZ4Jwupm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO
 V1FsnT6PtfbFvfNhnizyJS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e
 XZNaZjkq1IU6YtHOpALfZERdHyBn3GQBrKPm7XKVP7FLsfM3aIsJLz6KVd3pDfRHXJ9upGpH
 3saiIpiYdpQTOeNSSn5uw5zizw
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="asc'?scan'208";a="67664484"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bhb9xowAHt0AP9m9BHxrWKIXXUTxJMLSFcDm6KezD61tsqdtdicB4M9OPDl1n4/33ZCv9Qs/+qJ0PU+yjav83vatdLwWBJpwO4MzYAcSCSgE8aV/um234ys5x9VhcKT58oHR0V/lQVKJ4p7fGJOBBp93mlOndjrngC7z66MjZIs6YgY7eelFfFu43/tceHgeBdDPr4xjLWyu6nm0JMjzd4HMxMtfIzPNbX4Ji0yfa8l6KobyQpSg+Jju2BZsYYs6+S+pdgk4ndbOOYu+UPM200mD9WQjQY6ondA86cXF/WLca9atZbcHjxm2KONcetl51lgtwcdqeoUOzYp5/Tm+Lg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M3jSzJ5z1popMJaWZZaG/YO3bI8OYCUmFP8XE1cNoS4=;
 b=kT98GR9yeoBZbDcnTvkqqgJljpfW8oh1i5qKecUfj0JIjyzae6EUP5CPLc6EzMwd84diC4s5m1ee1hUDKEVKU9ogYou3aJAi2uiGrsbjDwgv1RYFWJHuo+w4s8k153UjTjlJgvgRT/nU3kEcCK+GI9kaamrh8s0I8R6L3hDqJy6ZoHtFKuyjJTmv6mqRQgemtG+kDsmnC7RpmczQmeVMElyY2tdz1pKScS7q/uX8pJ2D5rHaKnvPkLk24KFxSjXLjStiZNxb/6PAJEzPbjmeMa5eiEUb4OvWRNAzOp69FlHzvQ3N4XMQXqKRJQskd25ot4IHWAUr7Yz/HqDD2Qa7rg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M3jSzJ5z1popMJaWZZaG/YO3bI8OYCUmFP8XE1cNoS4=;
 b=uck5hhTq6iOW1Dwf8LExBz24dz7Ef5/+ZZHdjphE74o3kUXaQMr6mbW8AFLl6Uk471ylrbLr/uUDKWPh4ADdikkfDLioR4Lg75rXOwXuRr6BJxzAMsPYGMad+vVZVljEBdx50R00NgqwrfNTX13G8gEAXyen/9dOm1hlKqPAFw8=
From: George Dunlap <George.Dunlap@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>, Tamas K Lengyel
	<tamas.k.lengyel@gmail.com>, "intel-xen@intel.com" <intel-xen@intel.com>,
	"daniel.kiper@oracle.com" <daniel.kiper@oracle.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Sergey Dyasli <sergey.dyasli@citrix.com>, Christopher
 Clark <christopher.w.clark@gmail.com>, Rich Persaud <persaur@gmail.com>,
	Kevin Pearson <kevin.pearson@ortmanconsulting.com>, Juergen Gross
	<jgross@suse.com>, =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= <pdurrant@amazon.com>,
	"Ji, John" <john.ji@intel.com>, "edgar.iglesias@xilinx.com"
	<edgar.iglesias@xilinx.com>, "robin.randhawa@arm.com"
	<robin.randhawa@arm.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>, Matt
 Spencer <Matt.Spencer@arm.com>, "Stewart Hildebrand"
	<Stewart.Hildebrand@dornerworks.com>, Volodymyr Babchuk
	<volodymyr_babchuk@epam.com>, Jeff Kubascik <Jeff.Kubascik@dornerworks.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Rian Quinn <rianquinn@gmail.com>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?=
	<cardoe@cardoe.com>, George Dunlap <George.Dunlap@citrix.com>, "David
 Woodhouse" <dwmw@amazon.co.uk>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= <amit@infradead.org>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?=
	<varadgautam@gmail.com>, Brian Woods <brian.woods@xilinx.com>, Robert Townley
	<rob.townley@gmail.com>, Bobby Eshleman <bobby.eshleman@gmail.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?=
	<cminyard@mvista.com>, Olivier Lambert <olivier.lambert@vates.fr>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Ash Wilding <ash.j.wilding@gmail.com>,
	Rahul Singh <Rahul.Singh@arm.com>, =?utf-8?B?UGlvdHIgS3LDs2w=?=
	<piotr.krol@3mdeb.com>, Brendan Kerrigan <brendank310@gmail.com>, "Thierry
 Laurion (Insurgo)" <insurgo@riseup.net>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@epam.com>, Deepthi <deepthi.m@ltts.com>, Scott Davis
	<scottwd@gmail.com>, Ben Boyd <ben@exotanium.io>, Anthony Perard
	<anthony.perard@citrix.com>, Michal Orzel <michal.orzel@arm.com>
Subject: Poll for new Community Call time
Thread-Topic: Poll for new Community Call time
Thread-Index: AQHYSmRs/5/iWGInM0OnERQ/FcJ0qg==
Date: Thu, 7 Apr 2022 09:46:59 +0000
Message-ID: <A4C455B8-C7DF-4287-9DB3-BCFBDBCAFA12@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ceaf4f86-44ee-407b-6248-08da187b8f97
x-ms-traffictypediagnostic: DM6PR03MB4923:EE_
x-microsoft-antispam-prvs: <DM6PR03MB49238AEDE8A6F418CDE20E3699E69@DM6PR03MB4923.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 4zpQ2Xc6VrP1Mkz+z3cEEnh5yXLMUr+Om+2VkOZmggOf6mOuQel5JVDTJ22Wkw5gcbmp+lY0cQqxAj+GdBDdaSPC75Ejvev5cFrpwGox3g2SJ2V98mOdDRo3rnwr7BqThQQd5ql7gUCWcreoqBC679UJUa8V0njDTTPhkVblaHNTP8EIDoaBSLnEN4xs9XKhuMTxhXY/Fqj18qpZ8OoJkmCTsArBaIAo2dbRIx7Obv3FB0LvpSdYEyTDSJGGdbR+2PTN/QiBt9dgnlxVOP5M1+wh+X1CGoEB12kGhewi4u2Mal7EkAPzDlDwMgunbX6rE6mUMejYE9FsTqbtUHHIoGMrLoTLhBR5MFEhahGL3Dgk2j2QbJ6P55VP2aX1H749eEUiv6Hb55zYvSlBt6kkFQNGIbjTvxQBrzY+OCqj7cd+Kp9gYU5vyYXuAeiWFsndr9z161OLxian20JbxYYx/YHsGpjmIK+87etWMVOGR1oBm8DY9c1o4fCokeR0IOUVK58hRqo8tlf4dBkuVolp68E1phwMGKnzTrFF/e8t2LOfhJ8GBgCIjoCBiQSwYz2JC0Tm1t3LZoFt97PvzvJaFxeLv0q/78qBVNQxM6DP1sNZ8lXHQa76r4YMti5yXk6ZIfu9+nOAkPkvO9StSxBK0RhgC5C395kbh7fi1VZBApX6WUWbP4STgAg7M3ZESwgtYVKF7gY6kywQbSVSvQp3rCyrx5WE+YvRE428dK9PQ1VDgokj6FBXTCMoVU/n1Vy9tBRfWI/YlkjR0tN26VKlnWBM9EOP4ZQMHJn/yuRekjuqzyyhm71B1Jy5sfHKNb4AWYfoCe3oDf1rWn2SKgNepGYkVp57TLSbaisTAMhsFcs=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(508600001)(99936003)(6486002)(7416002)(6512007)(966005)(7406005)(8936002)(110136005)(2906002)(122000001)(921005)(82960400001)(4744005)(91956017)(33656002)(316002)(38100700002)(66446008)(2616005)(6506007)(66946007)(186003)(86362001)(8676002)(38070700005)(36756003)(76116006)(26005)(64756008)(66556008)(66476007)(71200400001)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZHBSYW5Qc0JGRmNRZjVIYlBkcW9VK3o5QVBCQjY5ck0wV1d0dGZRc2dLZGZa?=
 =?utf-8?B?K2k5Nk40RGZvV3lEeDFKcVFHcThUWm5WWVFzeXZ5dnY5dHh4V2ZGeFg3eGs2?=
 =?utf-8?B?dE1FRHFOQmZBY043eldLdTFMWnJLWjFqeEgxOUNOQXVXWUxrK3BUOUVLR282?=
 =?utf-8?B?UWdYaXd0SGI1Wno0SUlvV0VWMUJScWxWcG5YbVNDakUybGx0M1Fuc1FYdUtF?=
 =?utf-8?B?MkpxK2NKZlg4RFFaTXBUOStrS3JodWErZVVJUGp4dUV6aEhpa056UmJacnM1?=
 =?utf-8?B?T1NiYW1wcENabklDcE5ybGlKamxOazRlRGJTM1JndlpERkd6NVZvaTlyclA1?=
 =?utf-8?B?eXl0OExHU3gyR1c2NjZKN3dMdnZ6eEtGamc4TUxWNUt2SnlKaG1FQkdvaU9H?=
 =?utf-8?B?S0htRndoZGZLa1NySDljekQraW8rbkJiYnFERk9JRkxZazdtQVZSeTJPVkhn?=
 =?utf-8?B?V0VKbUtKWTZQVzg3Mjh0MlBmZTRYdXNIVkVxRTVMaHl3MVdWTG9WTUJHVTlP?=
 =?utf-8?B?WHBsQW4rd2ErNjdzMlh2VGJ2emF6eEVDNDB4THZGaVVmSzkvZGRaQVBoc2x1?=
 =?utf-8?B?dWVtQ1QrS0tzMktEMlJxY28zQjdQYVJRdjVRT200VmRrY1J3dEM5c2U1WFo1?=
 =?utf-8?B?NGxaRklsUExsdUYzRGIrVmh0K05xN1AzVkhQWjB4SVJQZzBseElmSWswclBk?=
 =?utf-8?B?R1JsUWxpQS92cGJPRUdjTkMyMjV2U1AxOWNYdmJFZnozMFpqMWxnRjA5L2xi?=
 =?utf-8?B?U00zUEVkZitQRmNoQmlSM2krU2ZmQ0l1bUFlN2crRUdTUVcvR0hXUW9BaDVy?=
 =?utf-8?B?WEJqTUJZU3puRURHVjk5VTZjOXVlanJsOHJOVFVoQWlWMWE5TURjanJDSTRE?=
 =?utf-8?B?YW84NzRJOVNTa0p1SUVmcmJ2dFdzRWc5QTZKZWNvckR6MkkvVFozRm1mRFB1?=
 =?utf-8?B?WllrNDQ2UEVXbDcvRW52YlBpc3BGZkJHN2FRb2U3TkJrK0dCS3ErVXJ4OW1r?=
 =?utf-8?B?Uk51VmhOTHI4T0lQUFhld1ZNYzUrb0tEYkhNUnVGQStLRWp2di9GVEZoMTdz?=
 =?utf-8?B?YThraWwyaFZOMTdoeE1rSzkwTWI0S09MUFZpREtRMjk3alNsTzJPU0k1aEFL?=
 =?utf-8?B?UVR0TXhvS0dwUDRVU1hicU56UHhpSEtYaDh1NTVQWHhXU0Q3S0QrSDM5S3Jm?=
 =?utf-8?B?TVFzaTlvamhERUZWRmRuYUdMNGtQcVFaSUNXSGFoTDNuWFplMnZaK252aEJ2?=
 =?utf-8?B?TEEwSGkzVStveXVoYzM3SzFaMWxhT3d0NE9LVGNBemtxcjRqNG15VjY0V21l?=
 =?utf-8?B?SzNpWFJ1ZlNud3RXZytIeURnUFUxU2F2cUdNcUNjaXVPYXpoYUlpK3grWDgw?=
 =?utf-8?B?cGJ1TVdsbTdDMlVoZU9NSVJyblI3ZFNiT0tXZzY1dE1qaytlcC83L2tZa0Nu?=
 =?utf-8?B?WGVzaXkvUTk5OVJ2RzlHR25YUW0zSEdYYzZTd2NUb3hyUGQzdThXQWY1K25Q?=
 =?utf-8?B?a2s1Zis3VVl1K0JrVjM5UUFzbzYyOVlWSm9OZmVVcktTRWh4NGkzTTMvcUE5?=
 =?utf-8?B?YUZRSGNWN21kZkVYQWlXY1UrSjI0bFc3bzJpUUpybS95dFZxdmgyZzAya1ZC?=
 =?utf-8?B?RVFmeG1xbUxBbzJyTW9zaWw3OWNsclNzK0V2SmV2eGRpa0NFTER0WmNYYzBN?=
 =?utf-8?B?VUJtckM4RGRqN01CbHhPd0ZTd21uN0JQU0ZoWEtXVXNrWkE4eWw5ZUpNZ2JV?=
 =?utf-8?B?V25RZ2phTEtVaXoyRmxxUnpwYm93d1RHbXdsZlNsUmEzYUE3eDJtcWhheVpY?=
 =?utf-8?B?eHJvS1VyYmY4ZWFpMTBJd1BrUFp3WURpR2x6b3NoRkhXRWcyQ214dnVjTkx4?=
 =?utf-8?B?SE0yaTVuOUFyN2ExM25EYjBudDY0eUY1blhGOS81UXdKL0R5MWM5M2pOZ0Z0?=
 =?utf-8?B?bkdtUG1UWHdYL2ROaVFCcnprUGJ1RXVqbG1iWkE3cC84eXgvK2hYMzFPd2k4?=
 =?utf-8?B?aFRZSnZVRFh2amVmVHhaSE1abkl6eUxZYU1WQ2tabG0xVnRreVNzMFNLK0dm?=
 =?utf-8?B?a1FUU1JRUTFzL1VxblRUcGZreGxCeTIzZG1ob1lpWW16dTlKWEpFb0xBb0ta?=
 =?utf-8?B?bkpqc014OTVnSGtvUXJTWEFuNThQTE5CRXMrWVZ5RWFrUTZHRVRMSXhZQldH?=
 =?utf-8?B?K003MnE2QXFtU2d6ZkpFQW9lbjlDem8xeTBobk5CTjFHVDJ4OWs2aURWMzhn?=
 =?utf-8?B?Yk02eS93MFEvaUx0a2EzT2x3Q1BjQ0tGZXpmUDJieTBTanJxWEhEMGpKOWJY?=
 =?utf-8?B?S3Y0UUVsUzBuY1h3R0ZVeDAwVVJQRG96aUI5OGR5UmFpbnVnOElFK0RPSWtT?=
 =?utf-8?Q?E9uum8NHsYCBCF18=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_DF980058-62CB-47AA-A541-3E459976C741";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ceaf4f86-44ee-407b-6248-08da187b8f97
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 09:46:59.3110
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nTZS4JNu4jo9arBCCI5iZaBhJGGqDAiDMPyqRUxl+E3EzUkvvtT7qC/CDN1rIDFEZdAHFW6mYC38qC/9KhPL2D8Xw+IDsaLRmMeK/34HbNQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4923
X-OriginatorOrg: citrix.com

--Apple-Mail=_DF980058-62CB-47AA-A541-3E459976C741
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

As discussed in the community call on Tuesday, here=E2=80=99s the poll =
for the new community call time.  If we don=E2=80=99t find a good time, =
we may just move back to 4pm BST Thursday, which is what it was before =
we moved it to Tuesday so that Ashley could run the meetings.

I=E2=80=99ll close the poll and announce the new date after 2 weeks.

https://doodle.com/meeting/participate/id/e1wwl5mb

Thanks,
 -George

--Apple-Mail=_DF980058-62CB-47AA-A541-3E459976C741
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJOsw4ACgkQshXHp8eE
G+2KJQgAt6jSw69V0xzZGTsKmbukpEclB2qxPWUHN5rxOhlLPw75roTakfX5po0N
7SDOq/9S17sQPRpARCK0aawNe7yrYXjW478zjc56+9vPF6EDSjVQBLTo3Nkriuo/
uDy2S+1/jiYxpRNsMlobNmI0M3cA/HrpCPBZuD3Ri2ORmHT5wVe9RubrQpczWVzJ
CYzmeZ+OSTKqUfinyjX7/sjFqE9beabvQG6ZOG9OzLnAMewiyLoQEPWaSZmlhoTQ
zJRydMJI9TqCg2/bDdQJrsLG7gM6UJ+kwP1vIg64PHW31tYcpMJKfk87UmaNxUUz
d4mvjJT4oilJGTYgyYiT0kUr3CKnpg==
=mYDm
-----END PGP SIGNATURE-----

--Apple-Mail=_DF980058-62CB-47AA-A541-3E459976C741--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300605.512840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOnO-0007En-Ur; Thu, 07 Apr 2022 09:51:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300605.512840; Thu, 07 Apr 2022 09:51:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOnO-0007Eg-Rh; Thu, 07 Apr 2022 09:51:18 +0000
Received: by outflank-mailman (input) for mailman id 300605;
 Thu, 07 Apr 2022 09:51:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncOnN-0007Ea-7h
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:51:17 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4352da93-b658-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:51:15 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4352da93-b658-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649325075;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=cYqpbDQqf02GR5KQJXZmp/6iABf7gag6MoT1VAJi9kQ=;
  b=Ajb5I2MFORAOOb5NreiiN6bNPCq8irx9ZMQVGqsoQ2chqvaLowGJEBEq
   fd3XUOrfZt3mZAXUEWMsCGgWAtzHw5XCXuJxE7mahspTetHURJcdawzYO
   9x1vrGJJipz/sN2vOcdI9+N26lBLoN7sCppfaiIzvSM3QWLXMRlfA/MId
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67664722
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AGvxvKqG/qlHj0ADdGl4YkLqeaZeBmIbZRIvgKrLsJaIsI4StFCzt
 garIBmFbK2MZDT9Kd8gPdi2p0kBsZSEm9BrTQpu/3s0QXgaoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Yyq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBM5Xvl903byZjVGJuDJZB36TrJXelvpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZVHN2YwNk6ojxtnNVMFEcowrt+UpFL0KmBT9ECf//Fr/D2GpOB2+Oe0a4eEEjCQfu1UgUSwt
 m/A537+ABwRKJqY0zXt2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQrUansSc2Z+VrVK4q2TqK7bH45wmDCT1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpkiXJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj/9hu+aTNT8D2BN1bQ9xawdRGp+ZgPc1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpy/5Ld0NsG4hfR4B3iM4ldnBO
 hK7VeR5vsE7AZdXRfUvP9LZ5zoCk8AM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3a5PRm0oCCrWnCsQVmKZKRW03wbEALcmeg+Rcd/KZIxogH2ckCvTLxqgmdZAjlKNQ/tokN
 FnkMqOE4DITXUH6FDg=
IronPort-HdrOrdr: A9a23:eAXxtKnSe9t61nMGGzY8uQU930/pDfPaimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPpICO4qTM2ftWjdyRCVxeRZg7cKrAeQfREWmtQtt5
 uIEJIOd+EYb2IK9PoSiTPQe71LoKjlzEnBv5aj854Hd3AMV0gP1XYdNu7NeXcGOTWuSKBJYq
 a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWySw71M7aXdi0L0i+W
 /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYLbhJavmnhnQYseuv4FElnJ
 3lpAohBd167zfrcmS8sXLWqnzd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ
 g7kl6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklWqvoJBiKp7zPLd
 MeQv01vJ1tABKnhjHizyJSKeWXLzgO9kzseDlDhiSXuwIm7kyRgXFoh/D3pU1wha7Ve6M0md
 gsDZ4Y5I2mNvVmFZ6VJN1xNfdfWVa9Ni4lDgqpUCfa/ec8SjDwl6I=
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="67664722"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h8sDRbVsvDwBQ2Tl4YwaCxQkGyDCzdtbIHqplyEdSyo4D7W8Ld94VPvJYdtwowm+klUKQlZb0MuzbROES76iMGVRGHZYjZDus+PHQxR8zyg3HuLWlj1PW9HwrjdLgElZzzdxnJro64W00BMtnQZB4wiYyNWF+EQ1K3xWEIDvuoLmsd5me14vSFWehN5/jIbmkBzKohI8ltELuuLzDhntddmTjHeuphAXgAawv+Hyxi/jaiVlp/Q/bMsfFEnbKPOwwO5mfwX1OzJLhBI0XPbHqtgZR/LjNTobCGkYmMhN8R9MLm/NENmSpjLPnWs/yIF7DpdIqbmUd0ZNAbfN69ikfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=COJ4dxymG6NuCRh1xh1Ff+0ACQ+F40iSsjOWKPSgmSo=;
 b=i4292OfXq+938Ou1IoHAAoQDFwINTFljyvH1ndANb5pp7RTM4ER4o1vprvwgSrysnRSFFXlzsfxNi72mMfprSbGK4v64kI7EQEqVm3Lm6tnJJpO3+eMXRr/QT34MWUn6Agu6yHpxzV+cSvkXqDQnGdEHfb1eIIXiePhLLPo1QIYAQe/0CxCe9qtvvPgfNmqfIZkDeFU044dGBVg212YlH1X43loAmZ0cPCPh76GzPpgjesIhF7wfqIz9xJ9cuo5VJcUXigFicnWAJZxcTAZELTVyOedqvj+1efCY6crdu+Bb7B9nD7Rg/7F7XlDtU6jQ+FPPmIJCnc2ZHFxNP39TEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=COJ4dxymG6NuCRh1xh1Ff+0ACQ+F40iSsjOWKPSgmSo=;
 b=YtggFnEVn6DTx2JzTGtnL1Vv3sST88fiPqHH+6gI9fouz0KwQ4cYxc4pls7RzXD0OMDbwNv45+LX3j6WALR4HmETwOy/Ifvfr1d2S4SU7/FmSCyR5MCdAIY6vnqjqIl8sRBzLGNyum2z1sNIVWTJo16buXMEy89j+oC6OzzKbF4=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH v2] osstest: stop anacron service
Date: Thu,  7 Apr 2022 11:51:04 +0200
Message-ID: <20220407095104.39545-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0291.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d5617fbc-1d35-4f71-667d-08da187c24a9
X-MS-TrafficTypeDiagnostic: MW5PR03MB6905:EE_
X-Microsoft-Antispam-PRVS: <MW5PR03MB69058021E812BBBC854805678FE69@MW5PR03MB6905.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mf//jhiQJXAnlp8ONOWXLBAWL3r+RGNoJOuSdTV2RVYG6dVnLgJxYC0YfovMpwcJJW4CjkcXXBHrPbOJYg8Abnll+wduZtAMG/cE9LDuf3byg9NbC3F2MRSvoq22tJNkXqV2FNel9GN+o/Bd7lJ2z+8tS3NMawwi5AKrIm5U7RlW8Z6Fm3Lalyp79N5GgauIHRkc5Ciui0hAyNYb8I9IEx6eb/Y3dPXLqcgHvDyMHiwTUXjFaXMjcKplVJnBac5TTIpOBiiDOeTqlrr9LPBXE3fwI+6gDZiDkIj7a6nDvLQcOjQwLAF03ZgN5ZXfQUV2nN1He4MhBp5OCzUEdlBxoBS7oA/9+rUSY20MeP/Erw8gXDgF+kwXonmF2xMRi1XTknFpf3IaoWl5/woRzUJsgQhSF0uzJtpjSKuqM6gdq5w+eAhbwtA1aNi5tZuyBW3/bjjV+P1/PI7wddYtk40evArRyXyxr9JAppdtWYFqaykeYfKGmzt/JvL+UjBjx8DDQfdPBaKX0NAxR0hcRgTdhwmoCBsCwRcg7/i6MkWIw28aYmil5lWmudQ3nzT529KlWsjqg0vMp0hv+t95SCY/anna1V4BEXZOrFUYy/srXB1FaPNdBmL1YNUdmVxb+McwUN2JQgBES+GX68pcT8XwJ18xtkC53PwufXTfb/ONEhMfbixsoVXHdcmuR9DSB2u1f0dSj0OsQQOy5wPC77RRvYUlGmcwuJTK64tazbbRpmM=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(5660300002)(966005)(6486002)(316002)(66946007)(66476007)(66556008)(36756003)(8936002)(6666004)(4326008)(6506007)(8676002)(83380400001)(26005)(107886003)(186003)(6512007)(2616005)(82960400001)(86362001)(1076003)(2906002)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWRscVhrd0dLZjh2bDIvYXpaWmhqVisrMzhabnNyVmhzRlJzZEh2V21mM3Rs?=
 =?utf-8?B?TUVDUGRBQUNXa3hYSU9TdXlhbloxbGdOMUlNdE02cmFIN05uTCtDN0hpV05u?=
 =?utf-8?B?dE5vNHlXRW44T21FV01BSmt3Tzc1YWV3WlM5dEN2NSsyVU5qd0RnM3N5WG5l?=
 =?utf-8?B?djJQWVZNVWdtbndxb1hHZHA3UDJCTndkZHlGekIxL25OY3c1MzNHWkEzVk5j?=
 =?utf-8?B?cFJHVXFSZ25UTWxBVmN2NWkwdDZLa1g5ZDVwL3Q3MlZqcG0zZFlZWFI2d1hZ?=
 =?utf-8?B?Vll6UmduUTRFMUlNN3RNeHhGd1NNZnoyWEhDSnhiM1owNmhnTmNaV3JTMEJX?=
 =?utf-8?B?KzQzQjQrUHRNK2dPeGRpRm4wVWxrbUR6cmZxZkJYY1NlaitFNFQ2M3pVUEF1?=
 =?utf-8?B?WE5sbXBtZWFiNzRJcEQzWFk1YlkyTElobGNqSllsQTlKb3FjVllEN1p0YUpN?=
 =?utf-8?B?ZXNCZkdRQ1ZCenhpOVpJRXEydGNTa3RDcGhYcTZoZ0VkZnlWWFpMVExmbHZP?=
 =?utf-8?B?VUR3OWhWOVhXby95Y0hSdmwvRHJnS1RnU1h4VDNzS0g2a1AzeFNwQ2dHcFNr?=
 =?utf-8?B?VGwvV2NlNjF5VWhRZ3FESzZCb2QzRFkyWSs0b2ZsNmlwZlVSNzNRd3hyc0hh?=
 =?utf-8?B?TEx2c2pSYW41YzBDajM2dS8xWENvU2pkMUk3dC9hRVNLd2tSSVlSTkhoSlUy?=
 =?utf-8?B?OElTMzA0RWloSzZIWmExclRva1NFV1NUOEw4U3ByS0pQRnRsTWZEdU9uSmJC?=
 =?utf-8?B?SnYxZHFZWlQ1bVQ2eGUxdmYyeDlDdForYlIrNkdsRWt2Y3JWenBaUExRWHNV?=
 =?utf-8?B?a3hiMzRYTWFkVmJJUXN3c1FvQThNVFdEM3RhaFJ0VVpTMmJQcFJTQnM2VjV0?=
 =?utf-8?B?SCtEOEYxV0lsYS9KTmZCcFJrbE1YWktLdE8yai94QnlOQzB4V1IvcXJwTWZI?=
 =?utf-8?B?R1lUM2YydmczR3o3RmphYXlvTGNHZXk3UG85dmtUbFAxUVppZ21MZ2Roang2?=
 =?utf-8?B?TjBCQUlXaFVLTGwzR050MHVQK0JNLzRvRlZmMEJKczdBL1NwWUdUUlBrakd0?=
 =?utf-8?B?ZjF5QjlCa09pWmlMWXg4cXdhMzl1ZFRDVnRuT3dsSlJ6L3crSmNISEN1aTE5?=
 =?utf-8?B?VVA5MlNaZ2hlWVp3THFRYTBtaGtTd0tlK2hzMjhLMTd2T3dxUFFUaTA5R3ZE?=
 =?utf-8?B?VFlsa0ZVT2JwdlpURUx5Y3lPQmFFOUQ5cThZa1VYUXJxZzljdzBSZTljalcx?=
 =?utf-8?B?aCtqV3ZwYmhhamtacHlTZlFGaXVwQ1lHOXdTRjFCMlJ4TnVRZllqbVhWVTBW?=
 =?utf-8?B?czdmT2Y3YjZkYzJIdy9mbmpHdFJQL0pDb2pDcVZGUHRJZkJZOXYvOWpILzQw?=
 =?utf-8?B?OCthR2U1c0luVzJFZkhQcThzWG5rQnFnWkNoZFRmN1JNcG9TNVV6cHpncmJI?=
 =?utf-8?B?RGlvMFZZNEZuYkRPK1NpMVd0ZTdiM2M1ZnhnR29ldHJNTVFZRTdwdkFTOTZO?=
 =?utf-8?B?azRuMXplY21jK2ZLR2IzczhmKytFR1NUdVVYS2wzV0NEOGFQNEJCSUJGS0Mr?=
 =?utf-8?B?OEZxL2VwSlZpaS95WncvN21RS1JoanNFeWVRK2ZiYjZSRFp1TG1FaVBpSUY1?=
 =?utf-8?B?VWs0K2tGNS9ZNStzVU4wNGduWUZxNGwzMDV3a1Y5a3ZKaTlCM1lITklBaGcr?=
 =?utf-8?B?bWFWdVdrSHlDSkZoV3h1N3haQkFRc0ZadU12NG1aem13TDNrZGdKMG03Z2RD?=
 =?utf-8?B?c2NtM0VtbkJOKzVzY1VhV2Rpak9xOTNMZW1DWTFxU1FCYXJoRFFIVUZ0TkJI?=
 =?utf-8?B?cUVVSjZsWXJsWmFaTUJjSzFiOXVGTnpQdUlGcDhwWFgvS1pqaTN0akhJZGpG?=
 =?utf-8?B?c05razdXZnhGK0QxWDlVYVJXSzJIMG50L1JKRkhYMHdzV3EyRUxKNW1TVWFL?=
 =?utf-8?B?TjV3WlZXWlpiazZsWVpoVjlWSDVPZ0tMbVltQ0Jlby9lMjlhK1lXVm5YY0dY?=
 =?utf-8?B?RGhLSmdZU1o1a2RoYnNlNzkvR2dUMVM1c2RxMDJJSytNakJNSDJ6OGQ5NzRj?=
 =?utf-8?B?Z25DR0llb28xd3ZpOEIrb3VQYWdNOHVGeEZybUlBNk82dmVVcEVGbjFFZU1M?=
 =?utf-8?B?NktFMEVMSlBqVWJCYTJVWm93Und6bzJ4Y2dDeVZ4NWlSV2R6UVJPOXk3YU5k?=
 =?utf-8?B?ZWdXN2djWlhkRGlsdVhuTzl3WS9QSEtpRVJQdGphSXFKNE1rRlZzcHpsYi93?=
 =?utf-8?B?TGtnZUJHeUY0RllJdnZHOHNHUnNscUU3UVl0VXFGUThRTnZnczNYRnpQd2JO?=
 =?utf-8?B?N2JTYVJwS0VubUtzaDRrMTFmL2dDSE5TV3ZQVmRuWGt6K1J3NFJ1TEV6dDFa?=
 =?utf-8?Q?V3SWHDDTVF6y83Fw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d5617fbc-1d35-4f71-667d-08da187c24a9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:51:11.0207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b0+gdKLmbqNWzHs5Z9S6FDxjarcFMa7vB2ZIBNgd2rcZGz7RgN6k90SZfrhDFhmVscqT9eIMZ4OKyJhuTr6djA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6905
X-OriginatorOrg: citrix.com

Just disabling cron in rc.d is not enough. There's also anacron which
will get invoked during startup, and since apt-compat has a delay of
up to 30min it can be picked up by the leak detector if the test
finishes fast enough:

LEAKED [process 14563 sleep] process: root     14563 14556  0 07:49 ?        00:00:00 sleep 1163
LEAKED [process 14550 /bin/sh] process: root     14550  2264  0 07:49 ?        00:00:00 /bin/sh -c run-parts --report /etc/cron.daily
LEAKED [process 14551 run-parts] process: root     14551 14550  0 07:49 ?        00:00:00 run-parts --report /etc/cron.daily
LEAKED [process 14556 /bin/sh] process: root     14556 14551  0 07:49 ?        00:00:00 /bin/sh /etc/cron.daily/apt-compat

From:

http://logs.test-lab.xenproject.org/osstest/logs/169015

To prevent this disable anacron like it's done for cron.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Don't fail if the service is not present.
---
 Osstest/TestSupport.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 8103ea1d..156cac79 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -3151,6 +3151,11 @@ sub host_install_postboot_complete ($) {
     target_core_dump_setup($ho);
     target_cmd_root($ho, "update-rc.d cron disable");
     target_cmd_root($ho, "service cron stop");
+    # Anacron is installed as a dependency for task-laptop which is only
+    # installed on bare metal.  Don't error if the service is not present
+    # or else nested virt setup will fail.
+    target_cmd_root($ho, "update-rc.d anacron disable || true");
+    target_cmd_root($ho, "service anacron stop || true");
     target_cmd_root($ho, "update-rc.d osstest-confirm-booted start 99 2 .");
     target_https_mitm_proxy_setup($ho);
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:53:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:53:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300609.512850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOp7-0007sC-Dd; Thu, 07 Apr 2022 09:53:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300609.512850; Thu, 07 Apr 2022 09:53:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOp7-0007s5-Ah; Thu, 07 Apr 2022 09:53:05 +0000
Received: by outflank-mailman (input) for mailman id 300609;
 Thu, 07 Apr 2022 09:53:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WyQK=UR=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ncOp5-0007rv-2e
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:53:03 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2061c.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::61c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 823fb51c-b658-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 11:53:01 +0200 (CEST)
Received: from AM6PR02CA0032.eurprd02.prod.outlook.com (2603:10a6:20b:6e::45)
 by DB8PR08MB3947.eurprd08.prod.outlook.com (2603:10a6:10:ae::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Thu, 7 Apr
 2022 09:52:39 +0000
Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:6e:cafe::3f) by AM6PR02CA0032.outlook.office365.com
 (2603:10a6:20b:6e::45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22 via Frontend
 Transport; Thu, 7 Apr 2022 09:52:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Thu, 7 Apr 2022 09:52:38 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Thu, 07 Apr 2022 09:52:38 +0000
Received: from 41bff3df526c.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0A080921-55EE-442A-A35D-A1754EB5B211.1; 
 Thu, 07 Apr 2022 09:52:28 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 41bff3df526c.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Apr 2022 09:52:28 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by VE1PR08MB5136.eurprd08.prod.outlook.com (2603:10a6:803:107::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr
 2022 09:52:18 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 09:52:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 823fb51c-b658-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Hq3oahg5QT6EUzbvsX5jWcZmPTbDZIxo39RyUZA4e1Y=;
 b=KJgDTeLalJ9Kaqa2x0MCIKRdbJg6A5cmbNuh2IkqA2d4wYnLJ5WAzPT6J+9MV7FJa7ERU4IOIXI5zs9KOsgoUlZDKFU/d4szVBJUGang+il3D9RMst9g5wakq2W2i3/03qiNnWL+sFbS1KXHsdb4CWXo0m6IRBgbe3I2Ot416qo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 17a962a90257ea39
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b2vA5uJ97YUpcBVV6/sOldQ+1/rkO5QXw/Yw4WlnTkPVchtJcrnkFvADkq+QBWKDyNXcpW74qZ6ouQ57ycsYFefzoRqac8HpaTkgP3A1vBDZiMuhGS+EKgo5AFe/8sR3u2h9FARiK7gxDVZS8MBwHOxCesNt6LBIujbiPqqgdjwFJR0qWX3sDznE8jx/GyQE7qCIGAOmnWUJkRnlykdP8LLiMcQMkd0aXyTlMpH0/x/epJ6+5KDeETyOD/ZwBOFiLv5XouWtnWRoNMsAcVsvwNjc0KXFo2SvUfbWAF7aR1sSiSQ/bdqlpPYb15uvX64cc2Dt0EOljHsI7sP+9T1Upg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Hq3oahg5QT6EUzbvsX5jWcZmPTbDZIxo39RyUZA4e1Y=;
 b=GGPiqn555VGSI8dkSuevSzGQbbo/yvdFOf7VFpcydzwMOkWQNFrfuTvUft45Yk0N7YLkNfjpk9yJEl2SY0pmTzZA8D8zJ6HWOYWns1ADLfvqoane84MlMRnOCBcSvQyaaIB/ShUZuPHF1Wm8vX7IPMncxX3q1sxbBRx8SGlIW9yWZQblISAeEHTrZDPOhgPv1vavODAuNyhy3KjOuegxU9NEDIAfdaEb5qNV/i8+xOLZEu/qjwvfe+rJuZb+8nQrr2DPprt04vBb+EP8O7e1eeZFFYNvOuZRDAzVNy8DlhGgP3sUIQ0GYxKP5vb0ilnnfXj2aZr3u9Z4Ef1+gCxJsg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Hq3oahg5QT6EUzbvsX5jWcZmPTbDZIxo39RyUZA4e1Y=;
 b=KJgDTeLalJ9Kaqa2x0MCIKRdbJg6A5cmbNuh2IkqA2d4wYnLJ5WAzPT6J+9MV7FJa7ERU4IOIXI5zs9KOsgoUlZDKFU/d4szVBJUGang+il3D9RMst9g5wakq2W2i3/03qiNnWL+sFbS1KXHsdb4CWXo0m6IRBgbe3I2Ot416qo=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, Dario Faggioli
	<dfaggioli@suse.com>
Subject: Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Index: AQHYSMtZp02WrBHGjUK6R54AwN8yA6zkKdCAgAAO7AA=
Date: Thu, 7 Apr 2022 09:52:17 +0000
Message-ID: <475D681D-9D0C-4302-B1CD-B8BD2E7D95AE@arm.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-5-luca.fancellu@arm.com>
 <deffb58a-984a-1016-4ac8-c3badc946ea0@xen.org>
In-Reply-To: <deffb58a-984a-1016-4ac8-c3badc946ea0@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 06d92824-17f7-4f48-2105-08da187c59c8
x-ms-traffictypediagnostic:
	VE1PR08MB5136:EE_|VE1EUR03FT055:EE_|DB8PR08MB3947:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB39476935334F84D8420A9B58E4E69@DB8PR08MB3947.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 I7nqG1hRFEAID4x/PRoUfVeiyhh8OYehTB1YhLEf3jaXiL2Toy7+T8OOnITQFIrizZchZ6l8VmLyhCtqFxeOdYXRzC3VyfuB4HII7+nDSyMFInxAa/IS9TPUVzn39Bpifibpny9qr3uWHHKFqS9unhHugmN2KOxIfkSRvKjS11Xo8oX0ccJdgndwQkbtEakPsTzD5ziszEF83MSFSw8ey/eYzbQ3wneTO39MITPlI2AKK/xqElb1VqL+hLGdWOrrSn6kBiLSMAWskQvhs3+aloUWo+1aHK6PGnqBTNg+HA7nghJUR+l3SkfDotkU+gljzvac6552ajt8uoXWxupLEtqrmkwlmj1RcoH2NQr2qX1RNBwaomCZelteC1zXfT0dJMPl5TNSrGzhMENbyRUHoDSSA9ERZQtAWPpr45xU1BQ2BtFWaossBPqPTVKoHf8anBL3vzHE6e+M5BUYjJOtj05vxKBtyYjlLAx6GOq/xTWEwsX6m22J+H84fcC0nL5MuYNaAKOXTcUW5fcGrwCHSs1k3Dxz52ehP2v+DxtIruPSRpS7z85mS6PvUkkQS749jTs2dLjN/DPIyDVVuoOt5cy8yMnKJ/DxynlCC7z5OrzD4pT2mkLFBqhRHr9Oo7sDKD/3LeQ5M3qdm+CB6936yQAxbLqkZO3VKUXoc8b7eJQvrMPEoOIK0+69BySNXFEo5XTqNS1HSAkNVsMKUP+ARA5PAt/4sEqGzbzsuP/3EJ1Jev2xXC/HLTa+l/gGM6OM
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(186003)(6486002)(86362001)(26005)(71200400001)(33656002)(508600001)(38100700002)(7416002)(38070700005)(54906003)(4326008)(8676002)(76116006)(66476007)(6916009)(64756008)(66446008)(91956017)(2616005)(6506007)(2906002)(316002)(66946007)(122000001)(6512007)(5660300002)(53546011)(66556008)(8936002)(36756003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <0BFD213938886849BAB7373B8EA32107@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5136
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a7329af0-1b80-427d-2b7a-08da187c4d38
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TTDQmpbC/ZbnGzQsewm/wBLzQCDGf4nDHqtMAYQG+02xBJlkXPdNAjAdx1B+Xc4TLbG3kIsDXYGYGEicRgmhcSyXwfUCesHjgiBlAXCpDdoUm2D1SHleKBeUIcaRV6AfJABetiOJaMllCNyqt3Fm1g1unyE4Q7TfQj+uEj5v3kfblB5sNBfqbCk6Z1txMM0e7dPTJTP637NpSm6WanIGR2Z7LZpZG0Qxmou6E2JpkMBmqumv7L9RAn5hNpCA471cnYYmR4+RfBe8sAtRpGccZVPeUwvvalxPJoE679pVstP5Ay75eMELCw2z9t2jzqq9KwSnQssHyUR6ruYsJDiKXon/MZYmnlv1SHqG/LpMPeGOF66qGA4HxQ0Oa/Ao8B6v7KU8ia1hggrt8pCszlBQML3bFQ55E264urKjQbZxhauRiss7VFlvO/wXPVkSCusZIVwxzcwX5IJPLEqldH2K+bHQ4ZQ5h2m1j7LbXzAbjXjohAg+ltGU5clLXh3fuAYEWEny4xictgxKkljBWCpiyeXOmeNTTda7aWCn9Mde1zwA2byH7crgaQh5D16J3u1iSuwOzYQjxgMXpjY1Ce0jBXf0U//0xUIHle+WuT0D+4gNlmDVjcmVck0nyNeMP2BOX5s9xvo79bvG95PI6tuWeczrzQm0XJu3dZyhGzBs3U56THZP7Ml/VNrLSzsetLhC
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(8676002)(8936002)(36860700001)(356005)(81166007)(4326008)(6862004)(2906002)(26005)(186003)(6486002)(6512007)(508600001)(54906003)(40460700003)(70586007)(336012)(5660300002)(86362001)(6506007)(2616005)(53546011)(83380400001)(107886003)(33656002)(82310400005)(47076005)(70206006)(316002)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 09:52:38.6552
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 06d92824-17f7-4f48-2105-08da187c59c8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3947

DQoNCj4gT24gNyBBcHIgMjAyMiwgYXQgMDk6NTgsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v
cmc+IHdyb3RlOg0KPiANCj4gSGkgTHVjYSwNCj4gDQo+IE9uIDA1LzA0LzIwMjIgMDk6NTcsIEx1
Y2EgRmFuY2VsbHUgd3JvdGU6DQo+PiBJbnRyb2R1Y2UgYSB3YXkgdG8gY3JlYXRlIGRpZmZlcmVu
dCBjcHVwb29scyBhdCBib290IHRpbWUsIHRoaXMgaXMNCj4+IHBhcnRpY3VsYXJseSB1c2VmdWwg
b24gQVJNIGJpZy5MSVRUTEUgc3lzdGVtIHdoZXJlIHRoZXJlIG1pZ2h0IGJlIHRoZQ0KPj4gbmVl
ZCB0byBoYXZlIGRpZmZlcmVudCBjcHVwb29scyBmb3IgZWFjaCB0eXBlIG9mIGNvcmUsIGJ1dCBh
bHNvDQo+PiBzeXN0ZW1zIHVzaW5nIE5VTUEgY2FuIGhhdmUgZGlmZmVyZW50IGNwdSBwb29scyBm
b3IgZWFjaCBub2RlLg0KPj4gVGhlIGZlYXR1cmUgb24gYXJtIHJlbGllcyBvbiBhIHNwZWNpZmlj
YXRpb24gb2YgdGhlIGNwdXBvb2xzIGZyb20gdGhlDQo+PiBkZXZpY2UgdHJlZSB0byBidWlsZCBw
b29scyBhbmQgYXNzaWduIGNwdXMgdG8gdGhlbS4NCj4gDQo+IEhvdyB3aWxsIHRoaXMgd29yayBm
b3IgQUNQST8gTm90ZSB0aGF0IEkgYW0gbm90IHN1Z2dlc3RpbmcgdG8gYWRkIHN1cG9ydCByaWdo
dCBub3cuIEhvd2V2ZXIsIHdlIHByb2JhYmx5IHdhbnQgdG8gY2xhcmlmeSB0aGF0IHRoaXMgaXMg
bm90IHlldCBzdXBwb3J0ZWQuDQoNCk9rIEkgd2lsbCBhZGQgYSBub3RlIHNheWluZyBBQ1BJIGlz
IG5vdCBzdXBwb3J0ZWQgaW4gdjYNCg0KPiANCj4gWy4uLl0NCj4gDQo+PiBkaWZmIC0tZ2l0IGEv
ZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9jcHVwb29scy50eHQgYi9kb2NzL21pc2MvYXJtL2Rl
dmljZS10cmVlL2NwdXBvb2xzLnR4dA0KPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+IGluZGV4
IDAwMDAwMDAwMDAwMC4uNWRhYzJiMTM4NGUwDQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi9k
b2NzL21pc2MvYXJtL2RldmljZS10cmVlL2NwdXBvb2xzLnR4dA0KPj4gQEAgLTAsMCArMSwxMzYg
QEANCj4+ICtCb290IHRpbWUgY3B1cG9vbHMNCj4+ICs9PT09PT09PT09PT09PT09PT0NCj4+ICsN
Cj4+ICtXaGVuIEJPT1RfVElNRV9DUFVQT09MUyBpcyBlbmFibGVkIGluIHRoZSBYZW4gY29uZmln
dXJhdGlvbiwgaXQgaXMgcG9zc2libGUgdG8NCj4+ICtjcmVhdGUgY3B1cG9vbHMgZHVyaW5nIGJv
b3QgcGhhc2UgYnkgc3BlY2lmeWluZyB0aGVtIGluIHRoZSBkZXZpY2UgdHJlZS4NCj4gDQo+IEhv
dyBhYm91dCBBQ1BJPw0KDQpTYW1lIGFzIGFib3ZlDQoNCj4gDQo+PiArDQo+PiArQ3B1cG9vbHMg
c3BlY2lmaWNhdGlvbiBub2RlcyBzaGFsbCBiZSBkaXJlY3QgY2hpbGRzIG9mIC9jaG9zZW4gbm9k
ZS4NCj4+ICtFYWNoIGNwdXBvb2wgbm9kZSBjb250YWlucyB0aGUgZm9sbG93aW5nIHByb3BlcnRp
ZXM6DQo+PiArDQo+PiArLSBjb21wYXRpYmxlIChtYW5kYXRvcnkpDQo+PiArDQo+PiArICAgIE11
c3QgYWx3YXlzIGluY2x1ZGUgdGhlIGNvbXBhdGlibGl0eSBzdHJpbmc6ICJ4ZW4sY3B1cG9vbCIu
DQo+PiArDQo+PiArLSBjcHVwb29sLWNwdXMgKG1hbmRhdG9yeSkNCj4+ICsNCj4+ICsgICAgTXVz
dCBiZSBhIGxpc3Qgb2YgZGV2aWNlIHRyZWUgcGhhbmRsZSB0byBub2RlcyBkZXNjcmliaW5nIGNw
dXMgKGUuZy4gaGF2aW5nDQo+PiArICAgIGRldmljZV90eXBlID0gImNwdSIpLCBpdCBjYW4ndCBi
ZSBlbXB0eS4NCj4+ICsNCj4+ICstIGNwdXBvb2wtc2NoZWQgKG9wdGlvbmFsKQ0KPj4gKw0KPj4g
KyAgICBNdXN0IGJlIGEgc3RyaW5nIGhhdmluZyB0aGUgbmFtZSBvZiBhIFhlbiBzY2hlZHVsZXIu
IENoZWNrIHRoZSBzY2hlZD08Li4uPg0KPj4gKyAgICBib290IGFyZ3VtZW50IGZvciBhbGxvd2Vk
IHZhbHVlcy4NCj4gDQo+IEkgd291bGQgY2xhcmlmeSB3aGF0IHdvdWxkIGJlIHRoZSBzY2hlZHVs
ZXIgaWYgY3B1cG9vbC1zY2hlZCBpcyBub3Qgc3BlY2lmaWVkLg0KPiANCj4gQWxzbywgSSB3b3Vs
ZCBnaXZlIGEgcG9pbnRlciB0byB4ZW4tY29tbWFuZC1saW5lLnBhbmRvYyBzbyBpdCBpcyBlYXNp
ZXIgdG8ga25vdyB3aGVyZSAnc2NoZWQnIGlzIGRlc2NyaWJlZC4NCg0KR29vZCBwb2ludCwgSSB0
aGluayB0aGUgaW5mbyBnb3QgbWlzc2VkIHRocm91Z2ggdGhlIHNlcmllcywgSeKAmWxsIGFkZCBh
bmQgcHV0IHRoZSBsaW5rLg0KDQo+IA0KPiBbLi4uXQ0KPiANCj4+ICt2b2lkIF9faW5pdCBidGNw
dXBvb2xzX2R0Yl9wYXJzZSh2b2lkKQ0KPj4gK3sNCj4+ICsgICAgY29uc3Qgc3RydWN0IGR0X2Rl
dmljZV9ub2RlICpjaG9zZW4sICpub2RlOw0KPj4gKw0KPj4gKyAgICBjaG9zZW4gPSBkdF9maW5k
X25vZGVfYnlfcGF0aCgiL2Nob3NlbiIpOw0KPj4gKyAgICBpZiAoICFjaG9zZW4gKQ0KPj4gKyAg
ICAgICAgcmV0dXJuOw0KPiBBc2lkZSB3aGVuIHVzaW5nIEFDUEksIHRoZSBjaG9zZW4gbm9kZSBz
aG91bGQgYWx3YXlzIGJlIHRoZXJlLiBTbyBJIHRoaW5rIHdlIHNob3VsZCB0aHJvdy9wcmludCBh
biBlcnJvciBpZiBjaG9zZW4gaXMgbm90IHByZXNlbnQuDQoNCldoZW4geW91IHNheSBlcnJvciwg
ZG8geW91IG1lYW4gbGlrZSBhIHBhbmljIG9yIGp1c3QgYSBwcmludGsgWEVOTE9HX0VSUiBhbmQg
cmV0dXJuPw0KDQo+IA0KPiBBbHNvLCBJIHdvdWxkIGNoZWNrIHRoYXQgd2UgaGF2ZW4ndCBib290
ZWQgdXNpbmcgQUNQSSByYXRoZXIgdGhhbiByZWx5aW5nIG9uIGR0X2ZpbmRfbm9kZV9ieV9wYXRo
KCIvY2hvc2VuIikgdG8gcmV0dXJuIE5VTEwuDQoNCk9rIEkgd2lsbCBhZGQgYSBjaGVjayBvbiBh
Y3BpX2Rpc2FibGVkIHRvIHJldHVybiBpZiBpdCBpcyBmYWxzZS4NCg0KQ2hlZXJzLA0KTHVjYQ0K
DQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 09:54:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 09:54:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300614.512862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOqF-0008Rk-Pa; Thu, 07 Apr 2022 09:54:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300614.512862; Thu, 07 Apr 2022 09:54:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncOqF-0008Rd-MJ; Thu, 07 Apr 2022 09:54:15 +0000
Received: by outflank-mailman (input) for mailman id 300614;
 Thu, 07 Apr 2022 09:54:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q2qr=UR=citrix.com=prvs=08907668d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ncOqE-0008RT-Ch
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 09:54:14 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ace57bb0-b658-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 11:54:13 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ace57bb0-b658-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649325253;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Q9ilmh6Q/+4PCubIhN7HuEFE1hpMKlPHUEJzlDY1wf8=;
  b=VknEoeZYZZEVlBhzWGxTV5uxMFSfM9QWJeMUBl7AImojSefy3NegcLLJ
   20AJLnrTuHO9lmUyWGxTCOEVZJmfof2rwPmFPrA4XcAU847IBF7Cn8CPK
   CM+AdRsEblX32jHol2RHZpvo1bluF/onVql+kh3k+7fJ7B3wQgrYMfItP
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68652061
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:J97cyKu5geq52G5Lq9VtBbvJe+fnVFheMUV32f8akzHdYApBsoF/q
 tZmKW7VPqmLMWqhftEnboXlpkgEsJbdnIRmGgpkpShkEisT+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/V5
 ouryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8EMoHQpP0gWiJGUH1vMYoBobqXC3iw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD
 yYcQWQ/MkmaO0MWUrsRILQZjsCVjHnTSWJRmAKe5rQ702HfwyUkhdABN/KKI4fXFK25hH2wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZhiUefwWE7AxQMWVy25/K+jyaWQMlDI
 kYZ/i4vq6ka90GxSNT5GRqirxa5UgU0AoQKVbdgsUfUl/SSs13x6nU4oiBpRdAKqPMveDURy
 BzVjt/OQmVq4JeVRifInluLlg+aNS8QJG4EQCYLSwoZ/tXuyL0OYgLzosVLS/Ds0ICscd3k6
 3XT9XVl2e1P5SIe///jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5XGhAztJcvU/MBofAnrNOv0jxpiGGeB6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNYCrwPfIqM93uUp1CIU3c+TLNDK28gj1mOMYZSeN61Hs2OR74M57FziDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r
 ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/KrbYclU7Qjl4YxITqJt4E7FYc21uvr+g1
 hmAtoVwkTITWVWvxd22V01e
IronPort-HdrOrdr: A9a23:TqZG9quiEh1w5/V7DUjIlqZJ7skDdNV00zEX/kB9WHVpmszxra
 GTddAgpHjJYVcqKRUdcL+7VJVoLUmyyXcx2/h2AV7AZniChILLFvAA0WKK+VSJcEeSygce79
 YDT0EXMqyIMbEQt6bHCWeDfeod/A==
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68652061"
Date: Thu, 7 Apr 2022 10:54:06 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <cardoe@cardoe.com>, <xen-devel@lists.xenproject.org>,
	<andrew.cooper3@citrix.com>
Subject: Re: [PATCH] MAINTAINERS: add myself as Continuous Integration
 maintainer
Message-ID: <Yk60vk2xmnTfBZsR@perard.uk.xensource.com>
References: <alpine.DEB.2.22.394.2204061323490.2910984@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2204061323490.2910984@ubuntu-linux-20-04-desktop>

On Wed, Apr 06, 2022 at 01:27:05PM -0700, Stefano Stabellini wrote:
> I have contributed all the ARM tests to gitlab-ci. After checking with
> Doug, I am happy to volunteer to co-maintain Continuous Integration.
> 
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> Acked-by: Doug Goldstein <cardoe@cardoe.com>
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6a097b43eb..cc87d5bbf1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -262,6 +262,7 @@ F:	CHANGELOG.md
>  
>  Continuous Integration (CI)
>  M:	Doug Goldstein <cardoe@cardoe.com>
> +M:	Stefano Stabellini <sstabellini@kernel.org>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>
for the addition.

>  W:	https://gitlab.com/xen-project/xen
>  W:	https://travis-ci.org/xen-project/xen

It's look like this entry is staled, we don't use travis anymore.

There's some more entry that are staled:
> F:      .travis.yml
This file was removed by e0dc9b095e ("CI: Drop TravisCI")

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 10:06:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 10:06:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300620.512873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncP1n-0001rD-Uk; Thu, 07 Apr 2022 10:06:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300620.512873; Thu, 07 Apr 2022 10:06:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncP1n-0001r6-QU; Thu, 07 Apr 2022 10:06:11 +0000
Received: by outflank-mailman (input) for mailman id 300620;
 Thu, 07 Apr 2022 10:06:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncP1m-0001r0-I0
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 10:06:10 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 56245c61-b65a-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 12:06:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BB14221122;
 Thu,  7 Apr 2022 10:06:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 76A8D13485;
 Thu,  7 Apr 2022 10:06:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 772XG4y3TmKHQAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 10:06:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56245c61-b65a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649325964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ViNMmtauRUZTlEmfR2WCY8dl0yCS/arQ83AKCE1RXss=;
	b=eLF4I7sK4P7PVy9ZxnRn5tPFd1d8qIOsftuMehMGbf8uGw3wh+Pm8vqJbd0ObODLB3f1WE
	JihY1J/cnoWJ8l03H1j2534V6nkmqVu0NjugR1tG/mSSs/Hp4G8VYN6mBLjetmal2p0mO+
	PbftG9ju3TIpeDNhwLVQaPjYowONo40=
Message-ID: <2491f4fb-cb4b-55d7-d23d-2f6917c859cb@suse.com>
Date: Thu, 7 Apr 2022 12:06:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Content-Language: en-US
To: David Hildenbrand <david@redhat.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Michal Hocko <mhocko@kernel.org>,
 Wei Yang <richard.weiyang@gmail.com>
References: <20220407093221.1090-1-jgross@suse.com>
 <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------R6URGsa0NFZmm44zukJXCTkF"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------R6URGsa0NFZmm44zukJXCTkF
Content-Type: multipart/mixed; boundary="------------J0C1DDTD70mjAc0TYWh1eHXU";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: David Hildenbrand <david@redhat.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Michal Hocko <mhocko@kernel.org>,
 Wei Yang <richard.weiyang@gmail.com>
Message-ID: <2491f4fb-cb4b-55d7-d23d-2f6917c859cb@suse.com>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
References: <20220407093221.1090-1-jgross@suse.com>
 <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com>
In-Reply-To: <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com>

--------------J0C1DDTD70mjAc0TYWh1eHXU
Content-Type: multipart/mixed; boundary="------------FebjrF4g9WpyJ5mEPwYASAiv"

--------------FebjrF4g9WpyJ5mEPwYASAiv
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDQuMjIgMTE6NDYsIERhdmlkIEhpbGRlbmJyYW5kIHdyb3RlOg0KPiBPbiAwNy4w
NC4yMiAxMTozMiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IFNpbmNlIGNvbW1pdCA5ZDNi
ZTIxYmY5YzAgKCJtbSwgcGFnZV9hbGxvYzogc2ltcGxpZnkgem9uZWxpc3QNCj4+IGluaXRp
YWxpemF0aW9uIikgb25seSB6b25lcyB3aXRoIGZyZWUgbWVtb3J5IGFyZSBpbmNsdWRlZCBp
biBhIGJ1aWx0DQo+PiB6b25lbGlzdC4gVGhpcyBpcyBwcm9ibGVtYXRpYyB3aGVuIGUuZy4g
YWxsIG1lbW9yeSBvZiBhIHpvbmUgaGFzIGJlZW4NCj4+IGJhbGxvb25lZCBvdXQuDQo+Pg0K
Pj4gVXNlIHBvcHVsYXRlZF96b25lKCkgd2hlbiBidWlsZGluZyBhIHpvbmVsaXN0IGFzIGl0
IGhhcyBiZWVuIGRvbmUNCj4+IGJlZm9yZSB0aGF0IGNvbW1pdC4NCj4+DQo+PiBDYzogc3Rh
YmxlQHZnZXIua2VybmVsLm9yZw0KPj4gRml4ZXM6IDlkM2JlMjFiZjljMCAoIm1tLCBwYWdl
X2FsbG9jOiBzaW1wbGlmeSB6b25lbGlzdCBpbml0aWFsaXphdGlvbiIpDQo+PiBSZXBvcnRl
ZC1ieTogTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIDxtYXJtYXJla0BpbnZpc2libGV0
aGluZ3NsYWIuY29tPg0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3Nz
QHN1c2UuY29tPg0KPj4gLS0tDQo+PiAgIG1tL3BhZ2VfYWxsb2MuYyB8IDIgKy0NCj4+ICAg
MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+Pg0KPj4g
ZGlmZiAtLWdpdCBhL21tL3BhZ2VfYWxsb2MuYyBiL21tL3BhZ2VfYWxsb2MuYw0KPj4gaW5k
ZXggYmRjOGY2MGFlNDYyLi4zZDA2NjJhZjMyODkgMTAwNjQ0DQo+PiAtLS0gYS9tbS9wYWdl
X2FsbG9jLmMNCj4+ICsrKyBiL21tL3BhZ2VfYWxsb2MuYw0KPj4gQEAgLTYxMjgsNyArNjEy
OCw3IEBAIHN0YXRpYyBpbnQgYnVpbGRfem9uZXJlZnNfbm9kZShwZ19kYXRhX3QgKnBnZGF0
LCBzdHJ1Y3Qgem9uZXJlZiAqem9uZXJlZnMpDQo+PiAgIAlkbyB7DQo+PiAgIAkJem9uZV90
eXBlLS07DQo+PiAgIAkJem9uZSA9IHBnZGF0LT5ub2RlX3pvbmVzICsgem9uZV90eXBlOw0K
Pj4gLQkJaWYgKG1hbmFnZWRfem9uZSh6b25lKSkgew0KPj4gKwkJaWYgKHBvcHVsYXRlZF96
b25lKHpvbmUpKSB7DQo+PiAgIAkJCXpvbmVyZWZfc2V0X3pvbmUoem9uZSwgJnpvbmVyZWZz
W25yX3pvbmVzKytdKTsNCj4+ICAgCQkJY2hlY2tfaGlnaGVzdF96b25lKHpvbmVfdHlwZSk7
DQo+PiAgIAkJfQ0KPiANCj4gTGV0J3Mgc2VlIGlmIHdlIGhhdmUgdG8gZmluZCBhbm90aGVy
IHdheSB0byBwcm9wZXJseSBoYW5kbGUgZmFkdW1wLg0KDQpUQkgsIEkgZG9uJ3QgdGhpbmsg
dGhpcyBzaG91bGQgbWF0dGVyIGhlcmUuIEEgem9uZSBjYW4gYWx3YXlzIGhhcHBlbiB0bw0K
aGF2ZSBubyBmcmVlIG1lbW9yeSBsZWZ0LCBzbyBvbmx5IGhhbmRsaW5nIHRoaXMgY2FzZSB3
aGVuIGJ1aWxkaW5nIHRoZQ0Kem9uZWxpc3QgY2FuJ3QgYmUgdGhlIGZ1bGwgc29sdXRpb24g
b2YgdGhhdCBwcm9ibGVtLiBJdCBtaWdodCB0cmlnZ2VyDQphIHByb2JsZW0gbW9yZSBlYXNp
bHksIHRob3VnaC4NCg0KPiBBY2tlZC1ieTogRGF2aWQgSGlsZGVuYnJhbmQgPGRhdmlkQHJl
ZGhhdC5jb20+DQoNClRoYW5rcywNCg0KDQpKdWVyZ2VuDQoNCg==
--------------FebjrF4g9WpyJ5mEPwYASAiv
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FebjrF4g9WpyJ5mEPwYASAiv--

--------------J0C1DDTD70mjAc0TYWh1eHXU--

--------------R6URGsa0NFZmm44zukJXCTkF
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJOt4sFAwAAAAAACgkQsN6d1ii/Ey8m
hwf9GoM9befCZ8OMyFEmJXC37VS+oZhOJZfxZhuXhQhsTQRMly3vQfcF+zOF8NbUeXRi2WnoX679
9iDpcx8gueWWNlH+p7q50BT+8cOTaQRyyjEjNexf6g5XDvqSkYg0FTHITSVjZtcs4l51EGhHT2nO
saoL7JCwBP8ofq+oLPJo7zDh+VUvP6E9oxgO6KqiCV3/E457hV0SwcWTdRC8p4VDmfwvqGervZW8
UpjfgFiGYRJq7rgZGK/Lbr4P+83tSJkYCFy5NAUmK97PFF2/7yFUz8DC+RamLwwdKUxc4PJEgaAJ
WxPjXlvk3ZvdQ1s+SVCYJ9T04YfQ9WTsVuWKXcbKTw==
=bAsf
-----END PGP SIGNATURE-----

--------------R6URGsa0NFZmm44zukJXCTkF--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 10:26:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 10:26:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300681.512920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncPKp-0006om-Dk; Thu, 07 Apr 2022 10:25:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300681.512920; Thu, 07 Apr 2022 10:25:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncPKp-0006of-A9; Thu, 07 Apr 2022 10:25:51 +0000
Received: by outflank-mailman (input) for mailman id 300681;
 Thu, 07 Apr 2022 10:25:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9hzW=UR=citrix.com=prvs=089009d52=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ncPKo-0006oZ-9D
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 10:25:50 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 163656af-b65d-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 12:25:48 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 163656af-b65d-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649327148;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Qn2okBuQiWWfDw22hd6NnZw2j/XExmOdZFxMH5E+Wno=;
  b=UBI8Lk1u+1CfeMQ0GMMcyiz+G5FmEksf2DMyUfb/pm3VJvqTwcTOQ/GW
   C0S51UruxrOYv9bkORT2WAM+ZxVEjKfBnVuO/WDrX947CkEaeC/oQXsNd
   mKKncr6A7+cZ67P4mdESByojg9L+ywUVkQahRPBFsKkKMQCUZ7VhEoK9X
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: None
X-MesageID: 68245550
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1hYLm6Oibq5XdIDvrR3slsFynXyQoLVcMsEvi/4bfWQNrUpzhDNVn
 2EaCmuPP/3ZYmLyKd4iPo/j9UMO6MWHm4VqHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tEw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9
 JZom4TzcVYQLIrNheJBTRpBAT1vIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTayCO
 pdEMVKDajzuW0xeA0clGKlvt9fyjGjgSTNmjles8P9fD2/7iVYZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfngifTSI8UUrqi+ZZCglee22gSAx0+TkagrL+yjUvWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnEO5Utcnc4M4O8Ux6R2Xy7qS5ACcB2MeSSVGZsBgv8gzLQHGH
 HfQwbsF2RQHXGWpdE+g
IronPort-HdrOrdr: A9a23:T7IIhauRtD9neiU2KVwCRVmA7skC2IMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPiftXrdyReVxeZZnMXfKlzbamHDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sZxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMEE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJppmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF491HqWxa0u
 UkkS1Qe/ib2EmhOV1dZiGdnTUI5QxerkMKD2Xo2EcL7/aJHA7SQPAx+r6xOiGplXbI+usMip
 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdw99Q/Bmcka+d
 NVfYnhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtR5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdY15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAp23G4gMyKeFPGC1zwdLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.90,241,1643691600"; 
   d="scan'208";a="68245550"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b+w3CrtuCTMIIFmdi3kvEdPx1Fif81sWKl1Yu32LYj338GTkfsz2daV6/uIoa6F81iE9hNMnYRbx3jR0U916MgKQsJW0R+tJsa1S3baQ8Pw2UcM5LVdLh9Hsihrc0GpsOc1l2A3E7MktHOwVfq/djqQX3XriltqJ43qFGfyPBFqco5Ycfe1Ml5L5S9MjjVIDrFhSfvADfMvHKvMCILjmwAQArWxWlvzrjz/YykcOXpb1E+omqzG5avgBEOA+yqq2PSn7cHJlT2EgJNOU8FJQU4GqPXQgUkgirXbNyGfeokYR2iCVO12TUqDAFXjxASoUNa4fHdUXQbVYGGhOTjYblg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Qn2okBuQiWWfDw22hd6NnZw2j/XExmOdZFxMH5E+Wno=;
 b=l6y9bFYmf9WUXaKlG72HURUm8/EiUynlI0xPGFPgHZ99uyU+U4cGQpdBbRly/F3ZhlfvCAw1o/OeDF5QZb94QKJfsHEGRoC6/7A5dLrtgDcXROUaOsz0nfj3xjUdIebA/QO0+0HaLEXiU9VkisBFhjV6scwCibW7gaqv+HtzvUr3QN0KN7Ni2LjBSd9NqUL5EIIPDPpXnkU/VVVYSeyiwi7b14LCiv133CtuenHiw8JKFFGaun8UY8tLTc9JFuX/V1CYUl4Jzt4kbP71Syd/1npwSlJ69JbqfofHRHHdIorJeYZrZDACZbHSj7RfpLEQMyMsskUOG7siySFYDuyB3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Qn2okBuQiWWfDw22hd6NnZw2j/XExmOdZFxMH5E+Wno=;
 b=X+lmZfCLs0RjXVF7AioDVy2wr51tFPGOlKq6BBqGd3tUzR7TH5x++382D3yHc0FSxlHc7ae31G+Oi9AY/qkTY+qR1uuK9vfsRER9xuEWWxIvswOPWmBSiVHidqMiyacUS7MIgNQAKbuwv9ilNq5AcgRmOk2TS9p5EXFW7Y7IXWc=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/cpuid: Clobber CPUID leaves 0x800000{1d..20}
Thread-Topic: [PATCH] x86/cpuid: Clobber CPUID leaves 0x800000{1d..20}
Thread-Index: AQHYShse3pTPowzhzUqzya5673Xmyazj/KiAgABCvgA=
Date: Thu, 7 Apr 2022 10:25:30 +0000
Message-ID: <caef7cae-c771-cb30-c24a-f802e5fda047@citrix.com>
References: <20220407010121.11301-1-andrew.cooper3@citrix.com>
 <008be273-8730-5637-f35c-021e67d3d664@suse.com>
In-Reply-To: <008be273-8730-5637-f35c-021e67d3d664@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1558c95c-b351-4884-2966-08da1880f13f
x-ms-traffictypediagnostic: DM6PR03MB3850:EE_
x-microsoft-antispam-prvs: <DM6PR03MB3850C62131E64C2859F20FD2BAE69@DM6PR03MB3850.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: FJ1Es4SL8yS1o1H9CSbVJ8U8kC9wTYTjhH4l1mvHZIOrDBYTLrPZBX/Cj4bezzk3hESuNMmd4eonl73GraW7FLi7HmfJ2kCeApNiuLqIYPp26qK7s1qoFoQgn1LK4snseqXTKD9mfhxEmOPzxVwVSbI5fKVIcJc8cEAryBDB+LKiAcA4uOiqCEVNw6lge2ECDXk8YAVzGZAzXs+cw4Av2WixOifQ2SiBhgWtgkyoeFURm2wirMQIksXNJ2xlQD7kd9WO3atp9nPTr2VgzBxWT5vydC4R6d3oMZicve/IdzRjVjg5cYXTBkMqgVWnmlowC0SquVQW57HZudDzbp/vPT9STlR4VvyDsIcaisXk4CuAdZeAxWbRa3QMeOvvgoBSu6nummG84qeEqKrgrpJZ6PmdKZ1YZ7sqZZE4O+ozQ1JaYDl2A3ZpCsTjfqXnKLxKNZF1tBt89HxrYBfqWorgCWjdr0sd9CQB3SN1LFRUJ3zLSNyWq+p0r7RZQscCogaUeM9wIbJdpeDwllzlM/Tko3aYWJf18NQ1fIWBCSdomQ8idsiS3buV1OJpuuGbi6ce3HKaYoGGwbmhTkoSFbpjVbA2sV+lMtrraVlvPuMst9ZkjbDULWWSCQ/VJSgUyd7OZN82Tvhka9NwZtohcDWbeMHESraMrw+WKEKEUSyHamDlARynQiKdpQlqjPMKgBL2Wu2SSTlhrPR/3DOcGrH4jwI2vbVs7jASvBG7s/HmVnSxLDeWSNdOumXD963wgTi1p9N3NSpM+JPjZwZTyu3OrQ0c1/9MjPxzYtAZmGN0nIFTj0olZNLrVszUNIvTZyxFs24ia628tL6oR3PNdZ0as+Z2TIxTw67qWvI3wxWbc6ES/FyZggPcftmLW891wWAM
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66574015)(66476007)(64756008)(508600001)(54906003)(66446008)(966005)(6916009)(26005)(38070700005)(2616005)(76116006)(4326008)(8676002)(6486002)(91956017)(316002)(186003)(36756003)(66946007)(71200400001)(66556008)(31686004)(31696002)(6512007)(6506007)(86362001)(53546011)(38100700002)(122000001)(83380400001)(2906002)(8936002)(5660300002)(82960400001)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RVM1ME93QWpYbFBYaXY5T1laVFNpU2NHdnc1bDJNYk1nSm5XTll0dXAxZ0Z3?=
 =?utf-8?B?RTlWRk9va0tQOUVYMU1XN1MwWjNxL3Y5Y2ZhSCs3M1M2QUhMeFBuY2xjUkdz?=
 =?utf-8?B?Q1JHZFRzM0dXTy9HK1A4Smp6aGVCL2xkcHNlS1lmV2RFL2g5UHBDZ013cGNt?=
 =?utf-8?B?aE82U3ZOSDViMlZiV0hYN3JiejA3Z1o0YUlCS3QwUEhYdzF4VW9Valg4TWxj?=
 =?utf-8?B?a21hWGNCWU1nNk8xd0wzZE9yQWZ0QWcvUDROY1NZSVpSWHFhZzVTMEJBS0Nh?=
 =?utf-8?B?MlhWcXFiUGpHd3hzbUEzaHgyeUtNbG1jRFE3VFlaVllPZmROZHh4Q2FDM3ZJ?=
 =?utf-8?B?YkJsbGQyWUtMRTBPZ1FHeWZSZlp1eHNWcVYrbVcvazVjYXhSMFRZZUsrbW5z?=
 =?utf-8?B?OVFtb2NBckcrNXNFRk4xaUdvcHE2aHlFWXo2ais0bXlmNHM5dC9HZStLR25G?=
 =?utf-8?B?SjNYYU1aWjZWNVVNYS8zUVY1WTllVlJRZ1pnK3RNaUc1TU1SYkw3U05DdUxw?=
 =?utf-8?B?NlA0MEhWaWlVQlJHbDZhbUNvQm1GUjIvN2NreCtLSWdlTXNYeWM3a0Q3WU1W?=
 =?utf-8?B?dFlmTGVadmM4VkNKbnQyQk5EcmMyY1pKUnNTdVNHNUt6U1pncHczNGFGODRH?=
 =?utf-8?B?N250TmpheSttSFBweVVyS3JNblduYzFETGtPMmNaY0l4WGxZWjZwV2VOaGRm?=
 =?utf-8?B?UUFNWXhNc0R4eTI5YWsyTm9Ec0gzdGhSR1hIOHU0a3ozQkpPSzhkU05adkly?=
 =?utf-8?B?SzdqY0VsTGl0ZGpnYnZkZDZ0NmY4ZmFHazNLbFBkUEdza2VPWE45ZDgxaHFp?=
 =?utf-8?B?VFJ2OGROS21YaUUzOUZBVGN4cnpuRlBnTlRqSUVTZVgySnpmU0ZMTUFQWmY2?=
 =?utf-8?B?dTFWM0hJYlBEelBTRWVoaGlMUVhvTmx2anFUSXBJU3dNT085WDV6TlVxa01v?=
 =?utf-8?B?OFNSSUVuZjFhY1RkWjAwenY3QVVpOXNBYk5MWjBuYjlUK29QRVF3UjFYc0Vz?=
 =?utf-8?B?bHZXMElyV09wa0lDYXNjSFpRckpuWUNWYUZoNERHL1NweVBndUhJa2JLNVR2?=
 =?utf-8?B?U3BkampZWTRHOVZMWGxnWFBNSHAwNGpjdkVURUdQdVBsSUZpdXNsQ1BlZENR?=
 =?utf-8?B?YUxHSFlQWFBjY1FXNDdvZVlTRFBUZTZBajNES1ZyNnZZV0o0ODI1VWIzUVBO?=
 =?utf-8?B?K0lISngyTEhSM01yUGFlTXNUVzgwMEtvSDFMcVl5UHNtanNudFM2VWNkR25D?=
 =?utf-8?B?cmVPckNsZmZsWE51MHVyL0dwV1owS295ZWZ4d2U5WGpMaFk1Y1l1c3Jhbldv?=
 =?utf-8?B?WWtqVlVKTExkRlc4REpTcUJDY2ZFNkt0U1dRbzdSaEdjOGdGOXB5MzQyV3NP?=
 =?utf-8?B?RE1HeWtFbVVGQWlEZWNoSitFc25CbXFNMUZuMFdkUGpwMzlqcTJBaEJVYUh1?=
 =?utf-8?B?a2Z1QzdPRnlZeDhaYnRKNWdXdXdTNjFjam05elRBUGZ5amFhR29LS25La3ND?=
 =?utf-8?B?T0pZZUlSaTcrSWV1MCtTQmEvY1k0dTN1TzRyamNEcUd5ekpsVDdtdFpFNGlX?=
 =?utf-8?B?SlVUbHowejczbWpSVHlSMzczQ05DckEzTzViTExUMEo3b0IzN3E5MUl1bGpE?=
 =?utf-8?B?ZWtPcGxMMzVhN3A4TW4xalk1LzZlNC9FQjJwVHVoSFRpelVPaWViSldXWWcw?=
 =?utf-8?B?dVF4RkpDdERkbUdBNXZXN2dEWFBLMkJmK3B4RHFtbVYrQTNVWDIvbzNpMWVQ?=
 =?utf-8?B?WjJtb2F0eWJGTVI2QVp5eXZqRWlHVzZpNGNkSlNmenNBZllMMDI4ZzNldjVu?=
 =?utf-8?B?RlZlMFM5RmpKL0pqcFFLQ0lqYU9jMnhYUzhRWjNrL1JXdng3eXlKRFNnYVBG?=
 =?utf-8?B?aVJVNTBMT2ttZGg3SndSaHBLN25UNlNZZHlEbHZhUFl0L2o1ZHN3RFRoMi91?=
 =?utf-8?B?OGZsd3VUQWdKUVF3MGl2ZGM5NlhQYWo4R0JCaFpGdDdaaEFSNmpnd2IzWVhV?=
 =?utf-8?B?K21Kd0pCZitYRTFHZ3ZQblFvUXMwL2FQVlJSYU9tNlo0NUluZk9uS04zZ0tO?=
 =?utf-8?B?WmUrdnR0Y1hzU0R5V3ZORTRTS2FLL04wR05PSGdNdEZkNFJQZlltdi9tNk15?=
 =?utf-8?B?cW1penhJdGY4dUdaMVE5VWhKWkxLVGtESVZlNkVaTG5GbUQ4am5YeStrdEJT?=
 =?utf-8?B?MGdCTExJQlUyNURydUhVMEI5NC9KRFhXRTNGTWExdzV3K2JhRURyZ1pPUXJX?=
 =?utf-8?B?TXJPR0FndCt6R1dXRWlKVXpUbnZCT3F5UTBMcnhheXduNFp5NVVMQ0ltMjBt?=
 =?utf-8?B?c3AvdXhkLzBsNmtqVWtza1dRcWRaZHNYSXJ1aXl1Tlp1akFCUklmZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DA722F45B0B66047871B119F3EB2A0F3@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1558c95c-b351-4884-2966-08da1880f13f
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 10:25:30.7737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /Xd/1qTesS7tdTOO9qvEKpnJkUioOnbxPMjHLtTcU6t093wTB+0yYf2VMiv0GJqkOOjodQpydbfQvaLFWqvmuFKlk91ke0r3IjyiuwnEGvc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3850
X-OriginatorOrg: citrix.com

T24gMDcvMDQvMjAyMiAwNzoyNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA0LjIwMjIg
MDM6MDEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBjL3MgMWE5MTQyNTZkY2E1IGluY3JlYXNl
ZCB0aGUgQU1EIG1heCBsZWFmIGZyb20gMHg4MDAwMDAxYyB0byAweDgwMDAwMDIxLCBidXQNCj4+
IGRpZCBub3QgYWRqdXN0IGFueXRoaW5nIGluIHRoZSBjYWxjdWxhdGVfKl9wb2xpY3koKSBjaGFp
bi4gIEFzIGEgcmVzdWx0LCBvbg0KPj4gaGFyZHdhcmUgc3VwcG9ydGluZyB0aGVzZSBsZWF2ZXMs
IHdlIHJlYWQgdGhlIHJlYWwgaGFyZHdhcmUgdmFsdWVzIGludG8gdGhlDQo+PiByYXcgcG9saWN5
LCB0aGVuIGNvcHkgaW50byBob3N0LCBhbmQgYWxsIHRoZSB3YXkgaW50byB0aGUgUFYvSFZNIGRl
ZmF1bHQNCj4+IHBvbGljaWVzLg0KPj4NCj4+IEFsbCA0IG9mIHRoZXNlIGxlYXZlcyBoYXZlIGVu
YWJsZSBiaXRzIChmaXJzdCB0d28gYnkgVG9wb0V4dCwgbmV4dCBieSBTRVYsDQo+PiBuZXh0IGJ5
IFBRT1MpLCBzbyBhbnkgc29mdHdhcmUgZm9sbG93aW5nIHRoZSBydWxlcyBpcyBmaW5lIGFuZCB3
aWxsIGxlYXZlIHRoZW0NCj4+IGFsb25lLiAgSG93ZXZlciwgbGVhZiAweDgwMDAwMDFkIHRha2Vz
IGEgc3VibGVhZiBpbnB1dCBhbmQgYXQgbGVhc3QgdHdvDQo+PiB1c2Vyc3BhY2UgdXRpbGl0aWVz
IGhhdmUgYmVlbiBvYnNlcnZlZCB0byBsb29wIGluZGVmaW5pdGVseSB1bmRlciBYZW4gKGNsZWFy
bHkNCj4+IHdhaXRpbmcgZm9yIGVheCB0byByZXBvcnQgIm5vIG1vcmUgY2FjaGUgbGV2ZWxzIiku
DQo+Pg0KPj4gU3VjaCB1c2Vyc3BhY2UgaXMgYnVnZ3ksIGJ1dCBYZW4ncyBiZWhhdmlvdXIgaXNu
J3QgZ3JlYXQgZWl0aGVyLg0KPj4NCj4+IEluIHRoZSBzaG9ydCB0ZXJtLCBjbG9iYmVyIGFsbCBp
bmZvcm1hdGlvbiBpbiB0aGVzZSBsZWF2ZXMuICBUaGlzIGlzIGEgZ2lhbnQNCj4+IGJvZGdlLCBi
dXQgdGhlcmUgYXJlIGNvbXBsZXhpdGllcyB3aXRoIGltcGxlbWVudGluZyBhbGwgb2YgdGhlc2Ug
bGVhdmVzDQo+PiBwcm9wZXJseS4NCj4+DQo+PiBGaXhlczogMWE5MTQyNTZkY2E1ICgieDg2L2Nw
dWlkOiBzdXBwb3J0IExGRU5DRSBhbHdheXMgc2VyaWFsaXNpbmcgQ1BVSUQgYml0IikNCj4+IExp
bms6IGh0dHBzOi8vZ2l0aHViLmNvbS9RdWJlc09TL3F1YmVzLWlzc3Vlcy9pc3N1ZXMvNzM5Mg0K
Pj4gUmVwb3J0ZWQtYnk6IGZvc3NsaW51eCA8Zm9zc2xpbnV4QGF1c3NpZXMuc3BhY2U+DQo+PiBS
ZXBvcnRlZC1ieTogTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIDxtYXJtYXJla0BpbnZpc2li
bGV0aGluZ3NsYWIuY29tPg0KPj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3
LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4NCg0KVGhhbmtzLg0KDQo+DQo+PiBJdCB0dXJucyBvdXQgdGhhdCBJbnRlbCBs
ZWFmIDQgYW5kIEFNRCBsZWFmIDB4ODAwMDAwMWQgYXJlICphbG1vc3QqIGlkZW50aWNhbC4NCj4+
IFRoZXkgZGlmZmVyIGJ5IHRoZSAiY29tcGxleCIgYml0IGluIGVkeCwgYW5kIHRoZSAkWC1wZXIt
Y2FjaGUgZmllbGRzIGluIHRoZQ0KPj4gdG9wIG9mIGVheCAoSW50ZWwgaXMgdGhyZWFkcy1wZXIt
Y2FjaGUsIEFNRCBpcyBjb3Jlcy1wZXItY2FjaGUgYW5kIGxhY2tzIHRoZQ0KPj4gY29yZXMtcGVy
LXBhY2thZ2UgZmllbGQpLg0KPj4NCj4+IEFzIG5laXRoZXIgdmVuZG9yIGltcGxlbWVudCBlYWNo
IG90aGVycyB2ZXJzaW9uLCBJJ20gaW5jcmVkaWJseSB0ZW1wdGVkIHRvDQo+PiByZXVzZSBwLT5j
YWNoZSBmb3IgYm90aCwgcmF0aGVyIHRoYW4gZG91YmxpbmcgdGhlIHN0b3JhZ2Ugc3BhY2UuICBS
ZWFkaW5nIHRoZQ0KPj4gZGF0YSBvdXQgaXMgZWFzeSB0byBrZXkgb24gcC0+ZXh0ZC50b3BvZXh0
LiAgV3JpdGluZyB0aGUgZGF0YSBjYW4gYmUgZG9uZQ0KPj4gd2l0aG91dCBhbnkgZnVydGhlciBj
b21wbGV4aXR5IGlmIHdlIHNpbXBseSB0cnVzdCB0aGUgc2VuZGluZyBzaWRlIHRvIGhhdmUgaXRz
DQo+PiBpbmRpY2VzIHRoZSBwcm9wZXIgd2F5IGFyb3VuZC4gIFBhcnRpY3VsYXJseSwgdGhpcyBh
dm9pZHMgbmVlZGluZyB0byBlbnN1cmUNCj4+IHRoYXQgcC0+ZXh0ZC50b3BvZXh0IGlzIG91dCBv
ZiBvcmRlciBhbmQgYXQgdGhlIGhlYWQgb2YgdGhlIHN0cmVhbS4gIFRob3VnaHRzPw0KPiBTb3Vu
ZHMgcXVpdGUgcmVhc29uYWJsZSB0byBtZS4gSSBndWVzcyB0aGUgbWFpbiByaXNrIGlzIGZvciBu
ZXcgdGhpbmdzDQo+IHRvIGFwcGVhciBvbiBlaXRoZXIgdmVuZG9yJ3Mgc2lkZSBpbiBhIHdheSBi
cmVha2luZyB0aGUgb3ZlcmxheWluZw0KPiBhcHByb2FjaC4gQnV0IEkgZ3Vlc3MgdGhhdCdzIG5v
dCBhIHNpZ25pZmljYW50IHJpc2suDQoNCk5laXRoZXIgb2YgdGhlIHZlbmRvcnMgYXJlIGdvaW5n
IHRvIGNoYW5nZSBpdCBpbiBpbmNvbXBhdGlibGUgd2F5cyB0bw0KaG93IHRoZXkgY3VycmVudGx5
IGV4cG9zZSBpdCwgYW5kIGl0J3MgZGF0YSB0aGF0IFhlbiBkb2Vzbid0DQpwYXJ0aWN1bGFybHkg
Y2FyZSBhYm91dCBpdCAtIHdlIG5ldmVyIGludGVycHJldCBpdCBvbiBiZWhhbGYgb2YgdGhlIGd1
ZXN0Lg0KDQpXaGVuIHdlIGZpeCB0aGUgdG9vbHN0YWNrIHNpZGUgb2YgdGhpbmdzIHRvIGNhbGN1
bGF0ZSB0b3BvbG9neSBwcm9wZXJseSwNCnRoZSAkZm9vLXBlci1jYWNoZSBmaWVsZHMgbmVlZCBh
ZGp1c3RpbmcsIGJ1dCB0aGF0IGxvZ2ljIHdpbGwgYmUgZmluZSB0bw0Kc3dpdGNoICggdmVuZG9y
ICkgb24uwqAgU2luY2Ugd3JpdGluZyB0aGlzLCBJIGZvdW5kIEFNRCdzDQpjb3Jlcy1wZXItcGFj
a2FnZSBhbmQgaXQncyBpbiB0aGUgYWRqYWNlbnQgbGVhZiB3aXRoIGEgd2lkZXIgZmllbGQuDQoN
Cj4gQXMgdG8gb3JkZXJpbmcgZGVwZW5kZW5jaWVzOiBBcmUgdGhlcmUgYW55IGluIHJlYWxpdHk/
IE5laXRoZXIgdmVuZG9yDQo+IGltcGxlbWVudHMgdGhlIG90aGVyIHZlbmRvcidzIGxlYWYsIHNv
IHRoZXJlJ3Mgb25seSBnb2luZyB0byBiZSBvbmUgaW4NCj4gdGhlIHN0cmVhbSBhbnl3YXksIGFu
ZCB3aGljaCBvbmUgaXQgaXMgY2FuIGJlIGRpc2FtYmlndWF0ZWQgYnkgaGF2aW5nDQo+IHNlZW4g
bGVhZiAwIGFsb25lLg0KDQpUaGUgY29tcGxleGl0eSBpcyB3aGF0IChpZiBhbnl0aGluZykgd2Ug
ZG8gaW4NCng4Nl9jcHVpZF9jb3B5X2Zyb21fYnVmZmVyKCkuwqAgSSd2ZSBkb25lIHNvbWUgcHJv
dG90eXBpbmcsIGFuZCB0aGUNCmVhc2llc3Qgb3B0aW9uIGlzIHRvIGFjY2VwdCBib3RoIDQgYW5k
IGUxRGQsIGluIGEgbGF0ZXN0LXRha2VzLXByZWNlZGVudA0KbWFubmVyIHByZWNlZGVudCwgYW5k
IHRoYXQgd2UgZG9uJ3QgY3JlYXRlIGludGVybGlua2FnZSB3aXRoIHRoZSB0b3BvZXh0DQpiaXQu
DQoNCkkndmUgYWxzbyBnb3QgYSBwaWxlIG9mIGZpeGVzIHRvIHRoZSB1bml0IHRlc3RzIHNvIHdl
IGhvcGVmdWxseSBjYW4ndA0KbWFrZSBtaXN0YWtlcyBsaWtlIHRoaXMgYWdhaW4sIGFsdGhvdWdo
IHRoYXQgd2lsbCBkZXBlbmQgb24gZ2V0dGluZw0KdGVzdC1jcHVpZC1wb2xpY3kgcnVubmluZyBp
biBPU1NUZXN0IHdoaWNoIGlzIGEgdG9kbyBsaXN0IGl0ZW0gd2hpY2gNCnJlYWxseSBuZWVkcyB0
byBnZXQgZG9uZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 10:34:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 10:34:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300690.512947 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncPTQ-0000En-Fl; Thu, 07 Apr 2022 10:34:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300690.512947; Thu, 07 Apr 2022 10:34:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncPTQ-0000Eg-CR; Thu, 07 Apr 2022 10:34:44 +0000
Received: by outflank-mailman (input) for mailman id 300690;
 Thu, 07 Apr 2022 10:34:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uyv1=UR=suse.com=mhocko@srs-se1.protection.inumbo.net>)
 id 1ncPTP-0000Ea-7J
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 10:34:43 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5577123c-b65e-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 12:34:42 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id 938FE21115;
 Thu,  7 Apr 2022 10:34:41 +0000 (UTC)
Received: from suse.cz (unknown [10.100.201.86])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id 5DE87A3B95;
 Thu,  7 Apr 2022 10:34:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5577123c-b65e-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649327681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sO0QE8JyTuj2LMUjDwYdva6iLYEDQBctYiGgxMGKAN8=;
	b=LwAe3jQ5+TGKWdY4ZX3tUU+fSU5rP4vpxcto9Sc4TqPdlpx/37BzVOasiq+mZLyGY2r3Zg
	aSkdPXBFU824M9PVCIeBYcjeBeW/5V9U3ZQA6IwASjiNwGdtrFXUf+auXBLpqpRdKE9xIn
	3timskGhpz+vIVqqyIju/BRrPH9QULc=
Date: Thu, 7 Apr 2022 12:34:40 +0200
From: Michal Hocko <mhocko@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
References: <20220407093221.1090-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220407093221.1090-1-jgross@suse.com>

Ccing Mel

On Thu 07-04-22 11:32:21, Juergen Gross wrote:
> Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
> initialization") only zones with free memory are included in a built
> zonelist. This is problematic when e.g. all memory of a zone has been
> ballooned out.

What is the actual problem there?

> Use populated_zone() when building a zonelist as it has been done
> before that commit.
> 
> Cc: stable@vger.kernel.org
> Fixes: 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization")

Did you mean to refer to 
6aa303defb74 ("mm, vmscan: only allocate and reclaim from zones with
pages managed by the buddy allocator")?

> Reported-by: Marek Marczykowski-G�recki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  mm/page_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bdc8f60ae462..3d0662af3289 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
>  	do {
>  		zone_type--;
>  		zone = pgdat->node_zones + zone_type;
> -		if (managed_zone(zone)) {
> +		if (populated_zone(zone)) {
>  			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>  			check_highest_zone(zone_type);
>  		}
> -- 
> 2.34.1

-- 
Michal Hocko
SUSE Labs


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 10:45:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 10:45:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300695.512961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncPe5-00021o-Hp; Thu, 07 Apr 2022 10:45:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300695.512961; Thu, 07 Apr 2022 10:45:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncPe5-00021h-Ea; Thu, 07 Apr 2022 10:45:45 +0000
Received: by outflank-mailman (input) for mailman id 300695;
 Thu, 07 Apr 2022 10:45:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncPe4-00021b-86
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 10:45:44 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df6bfc7a-b65f-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 12:45:43 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 82D1E1F85A;
 Thu,  7 Apr 2022 10:45:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4683A13485;
 Thu,  7 Apr 2022 10:45:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id fo+8D9bATmK9VwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 10:45:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df6bfc7a-b65f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649328342; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3sIYAjKG+ir9t1Xfq2O2bvY4pK7tgGKcci1Lb9ZLb/E=;
	b=T2GeSlh5bMffFn6Wrev58YTl7GerUzxaIEtGzkGShCEYEBQ+oW/i5Yj/kAb3O7XPcs2nM+
	8v4R0hMm8xfUC90uATGNZV7HKJxT1GwOTqfCHqViNlu8KcC0fHwtC8zT4kUH/c0jr7a/vE
	xqIwP5oSdzVN1oki0h/qVcu2uC9wfJQ=
Message-ID: <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
Date: Thu, 7 Apr 2022 12:45:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Michal Hocko <mhocko@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
 stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Mel Gorman <mgorman@suse.de>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
In-Reply-To: <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------TIl0s0UqKaX7PIe2u5NyjClQ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------TIl0s0UqKaX7PIe2u5NyjClQ
Content-Type: multipart/mixed; boundary="------------4EuXqQpxank1GYekfOIj7tkc";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Michal Hocko <mhocko@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
 stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Mel Gorman <mgorman@suse.de>
Message-ID: <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
In-Reply-To: <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>

--------------4EuXqQpxank1GYekfOIj7tkc
Content-Type: multipart/mixed; boundary="------------JB9VhSY0XY0ANUPejKIckOrg"

--------------JB9VhSY0XY0ANUPejKIckOrg
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDQuMjIgMTI6MzQsIE1pY2hhbCBIb2NrbyB3cm90ZToNCj4gQ2NpbmcgTWVsDQo+
IA0KPiBPbiBUaHUgMDctMDQtMjIgMTE6MzI6MjEsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+
PiBTaW5jZSBjb21taXQgOWQzYmUyMWJmOWMwICgibW0sIHBhZ2VfYWxsb2M6IHNpbXBsaWZ5
IHpvbmVsaXN0DQo+PiBpbml0aWFsaXphdGlvbiIpIG9ubHkgem9uZXMgd2l0aCBmcmVlIG1l
bW9yeSBhcmUgaW5jbHVkZWQgaW4gYSBidWlsdA0KPj4gem9uZWxpc3QuIFRoaXMgaXMgcHJv
YmxlbWF0aWMgd2hlbiBlLmcuIGFsbCBtZW1vcnkgb2YgYSB6b25lIGhhcyBiZWVuDQo+PiBi
YWxsb29uZWQgb3V0Lg0KPiANCj4gV2hhdCBpcyB0aGUgYWN0dWFsIHByb2JsZW0gdGhlcmU/
DQoNCldoZW4gcnVubmluZyBhcyBYZW4gZ3Vlc3QgbmV3IGhvdHBsdWdnZWQgbWVtb3J5IHdp
bGwgbm90IGJlIG9ubGluZWQNCmF1dG9tYXRpY2FsbHksIGJ1dCBvbmx5IG9uIHNwZWNpYWwg
cmVxdWVzdC4gVGhpcyBpcyBkb25lIGluIG9yZGVyIHRvDQpzdXBwb3J0IGFkZGluZyBlLmcu
IHRoZSBwb3NzaWJpbGl0eSB0byB1c2UgYW5vdGhlciBHQiBvZiBtZW1vcnksIHdoaWxlDQph
ZGRpbmcgb25seSBhIHBhcnQgb2YgdGhhdCBtZW1vcnkgaW5pdGlhbGx5Lg0KDQpJbiBjYXNl
IGFkZGluZyB0aGF0IG1lbW9yeSBpcyBwb3B1bGF0aW5nIGEgbmV3IHpvbmUsIHRoZSBwYWdl
IGFsbG9jYXRvcg0Kd29uJ3QgYmUgYWJsZSB0byB1c2UgdGhpcyBtZW1vcnkgd2hlbiBpdCBp
cyBvbmxpbmVkLCBhcyB0aGUgem9uZSB3YXNuJ3QNCmFkZGVkIHRvIHRoZSB6b25lbGlzdCwg
ZHVlIHRvIG1hbmFnZWRfem9uZSgpIHJldHVybmluZyAwLg0KDQpOb3RlIHRoYXQgYSBzaW1p
bGFyIHByb2JsZW0gY291bGQgb2NjdXIgaW4gY2FzZSB0aGUgem9uZWxpc3RzIGFyZQ0KcmVi
dWlsdCBhbmQgYSB6b25lIGhhcHBlbnMgdG8gaGF2ZSBhbGwgbWVtb3J5IGluIHVzZS4gVGhh
dCB6b25lIHdpbGwNCnRoZW4gYmUgZHJvcHBlZCBmcm9tIHRoZSByZWJ1aWx0IHpvbmVsaXN0
cy4NCg0KPiANCj4+IFVzZSBwb3B1bGF0ZWRfem9uZSgpIHdoZW4gYnVpbGRpbmcgYSB6b25l
bGlzdCBhcyBpdCBoYXMgYmVlbiBkb25lDQo+PiBiZWZvcmUgdGhhdCBjb21taXQuDQo+Pg0K
Pj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcNCj4+IEZpeGVzOiA5ZDNiZTIxYmY5YzAg
KCJtbSwgcGFnZV9hbGxvYzogc2ltcGxpZnkgem9uZWxpc3QgaW5pdGlhbGl6YXRpb24iKQ0K
PiANCj4gRGlkIHlvdSBtZWFuIHRvIHJlZmVyIHRvDQo+IDZhYTMwM2RlZmI3NCAoIm1tLCB2
bXNjYW46IG9ubHkgYWxsb2NhdGUgYW5kIHJlY2xhaW0gZnJvbSB6b25lcyB3aXRoDQo+IHBh
Z2VzIG1hbmFnZWQgYnkgdGhlIGJ1ZGR5IGFsbG9jYXRvciIpPw0KDQpZZXMuIEkgcmVhbGx5
IGNhbid0IGV4cGxhaW4gd2hlcmUgdGhpcyBvdGhlciByZWZlcmVuY2UgaXMgY29taW5nIGZy
b20uDQpJIG11c3QgaGF2ZSBzZWxlY3RlZCB0aGUgd3JvbmcgbGluZSBmcm9tIGEgZ2l0IGFu
bm90YXRlIG91dHB1dA0KDQoNCkp1ZXJnZW4NCg==
--------------JB9VhSY0XY0ANUPejKIckOrg
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------JB9VhSY0XY0ANUPejKIckOrg--

--------------4EuXqQpxank1GYekfOIj7tkc--

--------------TIl0s0UqKaX7PIe2u5NyjClQ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJOwNUFAwAAAAAACgkQsN6d1ii/Ey/4
qQgAnJxLJDcydEybZ6xKrNlhYEdZMI2p1iPldUfmz7mK0PPHWsPGfVIA6FqdtKq1d+Ne/egV88bH
Lv1NFCzKnCyux4IWJuv8Hbr03qxnbTtUJD0hQ/Igdb3xXGCxtwk11OzPM+MTe5UgadnNnBIDb0Gm
mSE30rnSjxXc7OZ8HmbCRaK4Nokf4qJNnCfJpKV/PAzoUuT1hsYu2rRSdqx/EGtc7RxASol2CUpN
C6VakkcZx7eKHlNQ0ZfGMmK2bixYXAcFTDwmpf6McoICMJ1Qoc5KnRUb14HLFFT6Rm8OLvyvultE
/JvgO2Tlhy7r2S+WB1rFRwC/jyJp6aJjWrHC1hUZnA==
=YuTn
-----END PGP SIGNATURE-----

--------------TIl0s0UqKaX7PIe2u5NyjClQ--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 11:07:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 11:07:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300701.512974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncPyn-0004zJ-Fs; Thu, 07 Apr 2022 11:07:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300701.512974; Thu, 07 Apr 2022 11:07:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncPyn-0004zC-Ak; Thu, 07 Apr 2022 11:07:09 +0000
Received: by outflank-mailman (input) for mailman id 300701;
 Thu, 07 Apr 2022 11:07:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uyv1=UR=suse.com=mhocko@srs-se1.protection.inumbo.net>)
 id 1ncPym-0004z6-42
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 11:07:08 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d978d2c9-b662-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 13:07:01 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id 340A621118;
 Thu,  7 Apr 2022 11:07:05 +0000 (UTC)
Received: from suse.cz (unknown [10.100.201.86])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id E1E68A3B82;
 Thu,  7 Apr 2022 11:07:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d978d2c9-b662-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649329625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=LE2tVt6E1/57kcFgpWdjdBQU6aDSlbFwP46O5S44+90=;
	b=Tp5lGLf1ElWVIcInGlUGAoJ1sx0YdUjQTq9tC8LzRgATKZFC9iS34ryFP2GTDsBD0Mirv1
	vRg/4eIJkZ5rGRuZIS6FxwFEhz62Vaik76t94HU2LQ2QePTUL26rXUg85lWH0KUDm4GPrG
	NFM/0kDfL93OeH1mpzliJJGkaQkmwQk=
Date: Thu, 7 Apr 2022 13:07:04 +0200
From: Michal Hocko <mhocko@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>

On Thu 07-04-22 12:45:41, Juergen Gross wrote:
> On 07.04.22 12:34, Michal Hocko wrote:
> > Ccing Mel
> > 
> > On Thu 07-04-22 11:32:21, Juergen Gross wrote:
> > > Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
> > > initialization") only zones with free memory are included in a built
> > > zonelist. This is problematic when e.g. all memory of a zone has been
> > > ballooned out.
> > 
> > What is the actual problem there?
> 
> When running as Xen guest new hotplugged memory will not be onlined
> automatically, but only on special request. This is done in order to
> support adding e.g. the possibility to use another GB of memory, while
> adding only a part of that memory initially.
> 
> In case adding that memory is populating a new zone, the page allocator
> won't be able to use this memory when it is onlined, as the zone wasn't
> added to the zonelist, due to managed_zone() returning 0.

How is that memory onlined? Because "regular" onlining (online_pages())
does rebuild zonelists if their zone hasn't been populated before.

-- 
Michal Hocko
SUSE Labs


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 11:10:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 11:10:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300705.512983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQ20-0006b1-Tr; Thu, 07 Apr 2022 11:10:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300705.512983; Thu, 07 Apr 2022 11:10:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQ20-0006au-QX; Thu, 07 Apr 2022 11:10:28 +0000
Received: by outflank-mailman (input) for mailman id 300705;
 Thu, 07 Apr 2022 11:10:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncQ1z-0006ai-Jo; Thu, 07 Apr 2022 11:10:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncQ1z-0005si-GV; Thu, 07 Apr 2022 11:10:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncQ1z-00033E-1t; Thu, 07 Apr 2022 11:10:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncQ1z-0005Y0-1N; Thu, 07 Apr 2022 11:10:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YT8y4GPItkBYlOkmHKTVTMschAs6tZeTvEygByC0A3g=; b=dOpyo5HX6Wq6gUYZOKd7MgoKNG
	+rNh8rKxZaE5jCO4nvMrU/vlmq5UjSMAS/HNeu5TyD7/BkQYTfZXUPt4oLPNQP3jbvA+8M/Z3/xQK
	YSRTGwdC0vXjE28GvZRZkL2zUgzpwEajEJ1gSccA2KwJ7Sh6taHwcqZS3D1P213Mt5Ec=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169210-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169210: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=609b8b0153e9bdb4e15be88a8911c6360e13e268
X-Osstest-Versions-That:
    xen=14dd241aad8af447680ac73e8579990e2c09c1e7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 11:10:27 +0000

flight 169210 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169210/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  609b8b0153e9bdb4e15be88a8911c6360e13e268
baseline version:
 xen                  14dd241aad8af447680ac73e8579990e2c09c1e7

Last test of basis   169183  2022-04-05 14:01:59 Z    1 days
Testing same since   169210  2022-04-07 07:00:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bertrand Marquis <bertrand.marquis@arm.com> #arm
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   14dd241aad..609b8b0153  609b8b0153e9bdb4e15be88a8911c6360e13e268 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 11:17:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 11:17:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300713.512994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQ8h-0007OY-KD; Thu, 07 Apr 2022 11:17:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300713.512994; Thu, 07 Apr 2022 11:17:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQ8h-0007OR-HA; Thu, 07 Apr 2022 11:17:23 +0000
Received: by outflank-mailman (input) for mailman id 300713;
 Thu, 07 Apr 2022 11:17:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncQ8f-0007OL-Rw
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 11:17:21 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4a88dec6-b664-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 13:17:20 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 533AF1F85A;
 Thu,  7 Apr 2022 11:17:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1355313A66;
 Thu,  7 Apr 2022 11:17:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id XolAA0DITmJEaAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 11:17:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a88dec6-b664-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649330240; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=dDQfiRLPVufvuVPTY+UISB3k5/4wdwlCC/3nm8qjtgk=;
	b=PRC6lKgDiL1NRZkKcmcZuYOdO1EGXE33ge2qnp2I6aWxhzhrHKmUqqwvuMEck4mxhxLjOE
	iKDrz1r1YxoUlCv+EitCl+h5BpSRLKQ+uz1vIIckZit4bm6jKC+8fzIjWLmDC2UhXrN7PH
	XCTrO2rBAKLxrizqg+mJdITG7aDpBn8=
Message-ID: <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
Date: Thu, 7 Apr 2022 13:17:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Michal Hocko <mhocko@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
 stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Mel Gorman <mgorman@suse.de>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
In-Reply-To: <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------nskH6gXR0GLd03pWvxgkqJK0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------nskH6gXR0GLd03pWvxgkqJK0
Content-Type: multipart/mixed; boundary="------------qUBVfqv5H5ox4HKrWPGghlVf";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Michal Hocko <mhocko@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
 stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Mel Gorman <mgorman@suse.de>
Message-ID: <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
In-Reply-To: <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>

--------------qUBVfqv5H5ox4HKrWPGghlVf
Content-Type: multipart/mixed; boundary="------------0Ft6bscHGfCDkhcPpHvpVFr1"

--------------0Ft6bscHGfCDkhcPpHvpVFr1
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDQuMjIgMTM6MDcsIE1pY2hhbCBIb2NrbyB3cm90ZToNCj4gT24gVGh1IDA3LTA0
LTIyIDEyOjQ1OjQxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDcuMDQuMjIgMTI6
MzQsIE1pY2hhbCBIb2NrbyB3cm90ZToNCj4+PiBDY2luZyBNZWwNCj4+Pg0KPj4+IE9uIFRo
dSAwNy0wNC0yMiAxMTozMjoyMSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gU2luY2Ug
Y29tbWl0IDlkM2JlMjFiZjljMCAoIm1tLCBwYWdlX2FsbG9jOiBzaW1wbGlmeSB6b25lbGlz
dA0KPj4+PiBpbml0aWFsaXphdGlvbiIpIG9ubHkgem9uZXMgd2l0aCBmcmVlIG1lbW9yeSBh
cmUgaW5jbHVkZWQgaW4gYSBidWlsdA0KPj4+PiB6b25lbGlzdC4gVGhpcyBpcyBwcm9ibGVt
YXRpYyB3aGVuIGUuZy4gYWxsIG1lbW9yeSBvZiBhIHpvbmUgaGFzIGJlZW4NCj4+Pj4gYmFs
bG9vbmVkIG91dC4NCj4+Pg0KPj4+IFdoYXQgaXMgdGhlIGFjdHVhbCBwcm9ibGVtIHRoZXJl
Pw0KPj4NCj4+IFdoZW4gcnVubmluZyBhcyBYZW4gZ3Vlc3QgbmV3IGhvdHBsdWdnZWQgbWVt
b3J5IHdpbGwgbm90IGJlIG9ubGluZWQNCj4+IGF1dG9tYXRpY2FsbHksIGJ1dCBvbmx5IG9u
IHNwZWNpYWwgcmVxdWVzdC4gVGhpcyBpcyBkb25lIGluIG9yZGVyIHRvDQo+PiBzdXBwb3J0
IGFkZGluZyBlLmcuIHRoZSBwb3NzaWJpbGl0eSB0byB1c2UgYW5vdGhlciBHQiBvZiBtZW1v
cnksIHdoaWxlDQo+PiBhZGRpbmcgb25seSBhIHBhcnQgb2YgdGhhdCBtZW1vcnkgaW5pdGlh
bGx5Lg0KPj4NCj4+IEluIGNhc2UgYWRkaW5nIHRoYXQgbWVtb3J5IGlzIHBvcHVsYXRpbmcg
YSBuZXcgem9uZSwgdGhlIHBhZ2UgYWxsb2NhdG9yDQo+PiB3b24ndCBiZSBhYmxlIHRvIHVz
ZSB0aGlzIG1lbW9yeSB3aGVuIGl0IGlzIG9ubGluZWQsIGFzIHRoZSB6b25lIHdhc24ndA0K
Pj4gYWRkZWQgdG8gdGhlIHpvbmVsaXN0LCBkdWUgdG8gbWFuYWdlZF96b25lKCkgcmV0dXJu
aW5nIDAuDQo+IA0KPiBIb3cgaXMgdGhhdCBtZW1vcnkgb25saW5lZD8gQmVjYXVzZSAicmVn
dWxhciIgb25saW5pbmcgKG9ubGluZV9wYWdlcygpKQ0KPiBkb2VzIHJlYnVpbGQgem9uZWxp
c3RzIGlmIHRoZWlyIHpvbmUgaGFzbid0IGJlZW4gcG9wdWxhdGVkIGJlZm9yZS4NCg0KVGhl
IFhlbiBiYWxsb29uIGRyaXZlciBoYXMgYW4gb3duIGNhbGxiYWNrIGZvciBvbmxpbmluZyBw
YWdlcy4gVGhlIHBhZ2VzDQphcmUganVzdCBhZGRlZCB0byB0aGUgYmFsbG9vbmVkLW91dCBw
YWdlIGxpc3Qgd2l0aG91dCBoYW5kaW5nIHRoZW0gdG8gdGhlDQphbGxvY2F0b3IuIFRoaXMg
aXMgZG9uZSBvbmx5IHdoZW4gdGhlIGd1ZXN0IGlzIGJhbGxvb25lZCB1cC4NCg0KU28gdGhl
IHByb2JsZW0gaXMgdGhhdCBhIG5ldyB6b25lIGlzIGJlaW5nIHBvcHVsYXRlZCwgYnV0IGl0
IHdvbid0IGhhdmUNCmZyZWUgcGFnZXMgd2hlbiB0aGUgem9uZWxpc3RzIGFyZSByZWJ1aWx0
Lg0KDQoNCkp1ZXJnZW4NCg0K
--------------0Ft6bscHGfCDkhcPpHvpVFr1
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0Ft6bscHGfCDkhcPpHvpVFr1--

--------------qUBVfqv5H5ox4HKrWPGghlVf--

--------------nskH6gXR0GLd03pWvxgkqJK0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJOyD8FAwAAAAAACgkQsN6d1ii/Ey/g
+Af/RaYeBV8VeGsuNXwt+3+abYnZw1S6fHU0/1SAUHlwvSU6ZjAUZva6kquKTk1nER67MDIbJFYk
DtwPu0ga+1z9j3MOajigjUJf2J+Zd24fQFMnQpjUn+ghR93kcgG/R06/ZsY7c4S03Xzr2KJ/bhFM
hiDDo9yCUkNZDvdYvGiy1D6zc8xOayskvmCnqeY2XHKXSmrvERBr67MFs5My6xBGNL1DcTz7zwRW
/OvTjuMzCzCX1sYdiI6WLg0ij1kn8MuyCstIshfU7VaE1shf7blsOlHiBRLsMcDsKH9YzYZI+TG+
56sSCuHViR+r08oUxiduznDOnhgLkPwXj3Th/TgZQQ==
=ods5
-----END PGP SIGNATURE-----

--------------nskH6gXR0GLd03pWvxgkqJK0--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 11:40:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 11:40:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300718.513005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQV3-0002s1-G1; Thu, 07 Apr 2022 11:40:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300718.513005; Thu, 07 Apr 2022 11:40:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQV3-0002ru-D8; Thu, 07 Apr 2022 11:40:29 +0000
Received: by outflank-mailman (input) for mailman id 300718;
 Thu, 07 Apr 2022 11:40:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uyv1=UR=suse.com=mhocko@srs-se1.protection.inumbo.net>)
 id 1ncQV1-0002ro-IO
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 11:40:27 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8476526e-b667-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 13:40:26 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id D40A81F85A;
 Thu,  7 Apr 2022 11:40:25 +0000 (UTC)
Received: from suse.cz (unknown [10.100.201.86])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id 95BB4A3B95;
 Thu,  7 Apr 2022 11:40:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8476526e-b667-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649331625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+hp8aAhVzpbG5JIjzC8mz1QFVXZDRqkDj1g7csHIECc=;
	b=UIULFBvyzCxIs+7UbHxsZU7G2yAOeXkpELPQc+nmPKjeexqyi8swlls9C2ojcKahaK5b3t
	H2rxtpzuFFtpGMGJpXEU5E76BZSQt2awxD3msEz2Thesrt8aivfxwdWHp/v4GBEKCgW960
	uNCcf9e9ZxHHc3A916CLQlkqYgm5LL8=
Date: Thu, 7 Apr 2022 13:40:25 +0200
From: Michal Hocko <mhocko@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <Yk7NqTlw7lmFzpKb@dhcp22.suse.cz>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>

On Thu 07-04-22 13:17:19, Juergen Gross wrote:
> On 07.04.22 13:07, Michal Hocko wrote:
> > On Thu 07-04-22 12:45:41, Juergen Gross wrote:
> > > On 07.04.22 12:34, Michal Hocko wrote:
> > > > Ccing Mel
> > > > 
> > > > On Thu 07-04-22 11:32:21, Juergen Gross wrote:
> > > > > Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
> > > > > initialization") only zones with free memory are included in a built
> > > > > zonelist. This is problematic when e.g. all memory of a zone has been
> > > > > ballooned out.
> > > > 
> > > > What is the actual problem there?
> > > 
> > > When running as Xen guest new hotplugged memory will not be onlined
> > > automatically, but only on special request. This is done in order to
> > > support adding e.g. the possibility to use another GB of memory, while
> > > adding only a part of that memory initially.
> > > 
> > > In case adding that memory is populating a new zone, the page allocator
> > > won't be able to use this memory when it is onlined, as the zone wasn't
> > > added to the zonelist, due to managed_zone() returning 0.
> > 
> > How is that memory onlined? Because "regular" onlining (online_pages())
> > does rebuild zonelists if their zone hasn't been populated before.
> 
> The Xen balloon driver has an own callback for onlining pages. The pages
> are just added to the ballooned-out page list without handing them to the
> allocator. This is done only when the guest is ballooned up.

OK, I see. Let me just rephrase to see whether we are on the same page.
Xen is overriding the online_page_callback to xen_online_page which
doesn't free pages to the page allocator which means that a zone might
remain unpopulated after onlining. This means that the default zone
lists rebuild is not done and later on when those pages are finally
released to the allocator there is no build_all_zonelists happening so
those freed pages are not really visible to the allocator via zonelists
fallback allocation.

Now to your patch. I suspect this is not sufficient for the full hotplug
situation. Consider a new NUMA node to be hotadded. hotadd_new_pgdat
will call build_all_zonelists but the zone is not populated yet at that
moment unless I am missing something. We do rely on online_pages to
rebuild once pages are onlined - which usually means they are freed to
the page allocator.

The zonelists building is kinda messy TBH. I have to say that I am not
really clear on Mel's 6aa303defb74 ("mm, vmscan: only allocate and
reclaim from zones with pages managed by the buddy allocator") because
as you have said unpoppulated zone is not (or shouldn't be) really all
that different from a depleted zone.

I think a better and more complete fix would be the following. In other
words the zonelists will be built for all present zones. Not sure
whether that is going to break 6aa303defb74 though.

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 2a9627dc784c..880c455e2557 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1062,7 +1062,6 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages,
 		       struct zone *zone, struct memory_group *group)
 {
 	unsigned long flags;
-	int need_zonelists_rebuild = 0;
 	const int nid = zone_to_nid(zone);
 	int ret;
 	struct memory_notify arg;
@@ -1106,17 +1105,13 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages,
 	 * This means the page allocator ignores this zone.
 	 * So, zonelist must be updated after online.
 	 */
-	if (!populated_zone(zone)) {
-		need_zonelists_rebuild = 1;
+	if (!populated_zone(zone))
 		setup_zone_pageset(zone);
-	}
 
 	online_pages_range(pfn, nr_pages);
 	adjust_present_page_count(pfn_to_page(pfn), group, nr_pages);
 
 	node_states_set_node(nid, &arg);
-	if (need_zonelists_rebuild)
-		build_all_zonelists(NULL);
 
 	/* Basic onlining is complete, allow allocation of onlined pages. */
 	undo_isolate_page_range(pfn, pfn + nr_pages, MIGRATE_MOVABLE);
@@ -1985,10 +1980,8 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages,
 	/* reinitialise watermarks and update pcp limits */
 	init_per_zone_wmark_min();
 
-	if (!populated_zone(zone)) {
+	if (!populated_zone(zone))
 		zone_pcp_reset(zone);
-		build_all_zonelists(NULL);
-	}
 
 	node_states_clear_node(node, &arg);
 	if (arg.status_change_nid >= 0) {
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 3589febc6d31..130a2feceddc 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6112,10 +6112,8 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
 	do {
 		zone_type--;
 		zone = pgdat->node_zones + zone_type;
-		if (managed_zone(zone)) {
-			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
-			check_highest_zone(zone_type);
-		}
+		zoneref_set_zone(zone, &zonerefs[nr_zones++]);
+		check_highest_zone(zone_type);
 	} while (zone_type);
 
 	return nr_zones;
-- 
Michal Hocko
SUSE Labs


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 11:48:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 11:48:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300722.513016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQcX-0003p7-9q; Thu, 07 Apr 2022 11:48:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300722.513016; Thu, 07 Apr 2022 11:48:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQcX-0003p0-71; Thu, 07 Apr 2022 11:48:13 +0000
Received: by outflank-mailman (input) for mailman id 300722;
 Thu, 07 Apr 2022 11:48:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uyv1=UR=suse.com=mhocko@srs-se1.protection.inumbo.net>)
 id 1ncQcW-0003ou-CS
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 11:48:12 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9970649e-b668-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 13:48:11 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id A5A361F859;
 Thu,  7 Apr 2022 11:48:10 +0000 (UTC)
Received: from suse.cz (unknown [10.100.201.86])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id 74176A3B88;
 Thu,  7 Apr 2022 11:48:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9970649e-b668-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649332090; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hzzsqE3lHhZNTb0uSMaOKkro2CJhyy2oCUvOJqbqZYE=;
	b=LRhI4GBAtx/ASTu7jlVvYU6iX4vVt2LFIwag927OFBVZh0Lr1jMIOfEGw9c9SxZNVzFQha
	xg7kb97zo3WZEJKBe2Wv6WIhoduV9gMh9VFa634GDpd0fIs7PH2Z4rZb+cA1AixjYxlkAm
	hEI1iPyd5PLXUAREH5GDnfoMbvX/Fgk=
Date: Thu, 7 Apr 2022 13:48:09 +0200
From: Michal Hocko <mhocko@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <Yk7PeQ8sClX5VVWa@dhcp22.suse.cz>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
 <Yk7NqTlw7lmFzpKb@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yk7NqTlw7lmFzpKb@dhcp22.suse.cz>

On Thu 07-04-22 13:40:25, Michal Hocko wrote:
[...]
> Now to your patch. I suspect this is not sufficient for the full hotplug
> situation. Consider a new NUMA node to be hotadded. hotadd_new_pgdat
> will call build_all_zonelists but the zone is not populated yet at that
> moment unless I am missing something. We do rely on online_pages to
> rebuild once pages are onlined - which usually means they are freed to
> the page allocator.

OK, I've managed to get lost in the code and misread the onlining part.
After re-reading the code I have concluded that the patch is good as is.
online_pages relies on zone_populated so it will pass and zonelists will
be regenerated even without any pages freed to the allocator. Sorry for
the confusion. But I guess this still proves my other point that the
code is really subtle and messy so I guess the less rebuilding we do the
better. There are two ways, go with your patch and do the clean up on
top or merge the two.

That being said
Acked-by: Michal Hocko <mhocko@suse.com>
to your patch with an improved changelog to be more specific about the
underlying problem.

Thanks and sorry for the confusion.
-- 
Michal Hocko
SUSE Labs


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 11:59:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 11:59:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300729.513028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQmq-0005ci-HT; Thu, 07 Apr 2022 11:58:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300729.513028; Thu, 07 Apr 2022 11:58:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQmq-0005cb-Cz; Thu, 07 Apr 2022 11:58:52 +0000
Received: by outflank-mailman (input) for mailman id 300729;
 Thu, 07 Apr 2022 11:58:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1UeT=UR=redhat.com=david@srs-se1.protection.inumbo.net>)
 id 1ncQmo-0005cV-I6
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 11:58:50 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 155b2b41-b66a-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 13:58:49 +0200 (CEST)
Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com
 [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-513-CpzrCZnLM-iYeAOaY96yBg-1; Thu, 07 Apr 2022 07:58:46 -0400
Received: by mail-wr1-f69.google.com with SMTP id
 u30-20020adfa19e000000b00206153b3cceso1197952wru.1
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 04:58:46 -0700 (PDT)
Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8?
 ([2a09:80c0:192:0:20af:34be:985b:b6c8])
 by smtp.gmail.com with ESMTPSA id
 t6-20020a05600c198600b0038cafe3d47dsm8146389wmq.42.2022.04.07.04.58.44
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Apr 2022 04:58:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 155b2b41-b66a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649332728;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mfC6ACVN+r1+9aoelvI2SUHBx6evFIztIF7swQ8/a5o=;
	b=Dwws9Boh1oRHkSaRUIPJpg/DfLJ04our/NAShDLRlZ2ORw+KgxferKAbWMBTSJiRh4fA0V
	d44cNh4kzGFeI9IjEOo2zj6q1zR6O9O4iXyMeuoSmgipwWQXaWnChMZRiMbsvR/zzlJL6J
	GAkeTYzTWL6yIF3GUGoPCsQfZsnKid4=
X-MC-Unique: CpzrCZnLM-iYeAOaY96yBg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:organization:in-reply-to
         :content-transfer-encoding;
        bh=mfC6ACVN+r1+9aoelvI2SUHBx6evFIztIF7swQ8/a5o=;
        b=ggkV1jZhzH7KLUGjyCIL6B+gGOMn400xhtMdTOa/4GIzYXIDvcQ9VXIVKq8a0YyyYB
         LNb/VPRRMuegKmftQ6+K8/n/K9MPKV5d5A7WhJ99gaFTvy0Gmer1cWXxsVaJSos7en8E
         ryHGamlVleio8WV+h6K+FmynFkJnnyurVpT/Rq1WqW35wirVBVLHZteODHGRzZVPAsUQ
         NFJR08fbVaKLOAhus91subnC3fGklqQglZeq+HKsJnqUUaDWyUo7UC/CzWH9yaGJmbJM
         JK/9sQhrLAkREl3xgO9/V9rIOSMcIEbc880Hvmbuqpo2RB+3vrtWr/j25vNQQGvvtgKv
         sBFw==
X-Gm-Message-State: AOAM532/g46ginx6AX6N24aJy9x8TO+5KRlfBHyP2SFigLd//TrlNgwn
	KuwoaBzyN59csM4LJFepYFExj+N5U4JcE9SKbNg0EayHYzprf28MpV1yNngThlbGQ+pJKYP4kec
	gdhvmhl09el72KbzupPHEWBVjbAs=
X-Received: by 2002:a1c:c912:0:b0:37b:e074:dfcb with SMTP id f18-20020a1cc912000000b0037be074dfcbmr11670729wmb.161.1649332725627;
        Thu, 07 Apr 2022 04:58:45 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwiets5YBv99cCr5Y+tvMGupOQmvkvg995AmX+y5wfvqAYms+Yx9LXLB0EbPyOeut+xYOcbkg==
X-Received: by 2002:a1c:c912:0:b0:37b:e074:dfcb with SMTP id f18-20020a1cc912000000b0037be074dfcbmr11670706wmb.161.1649332725340;
        Thu, 07 Apr 2022 04:58:45 -0700 (PDT)
Message-ID: <770d8283-4315-3d83-4f8b-723308fffe5c@redhat.com>
Date: Thu, 7 Apr 2022 13:58:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
To: Michal Hocko <mhocko@suse.com>, Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
 stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Mel Gorman <mgorman@suse.de>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
 <Yk7NqTlw7lmFzpKb@dhcp22.suse.cz>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <Yk7NqTlw7lmFzpKb@dhcp22.suse.cz>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 07.04.22 13:40, Michal Hocko wrote:
> On Thu 07-04-22 13:17:19, Juergen Gross wrote:
>> On 07.04.22 13:07, Michal Hocko wrote:
>>> On Thu 07-04-22 12:45:41, Juergen Gross wrote:
>>>> On 07.04.22 12:34, Michal Hocko wrote:
>>>>> Ccing Mel
>>>>>
>>>>> On Thu 07-04-22 11:32:21, Juergen Gross wrote:
>>>>>> Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
>>>>>> initialization") only zones with free memory are included in a built
>>>>>> zonelist. This is problematic when e.g. all memory of a zone has been
>>>>>> ballooned out.
>>>>>
>>>>> What is the actual problem there?
>>>>
>>>> When running as Xen guest new hotplugged memory will not be onlined
>>>> automatically, but only on special request. This is done in order to
>>>> support adding e.g. the possibility to use another GB of memory, while
>>>> adding only a part of that memory initially.
>>>>
>>>> In case adding that memory is populating a new zone, the page allocator
>>>> won't be able to use this memory when it is onlined, as the zone wasn't
>>>> added to the zonelist, due to managed_zone() returning 0.
>>>
>>> How is that memory onlined? Because "regular" onlining (online_pages())
>>> does rebuild zonelists if their zone hasn't been populated before.
>>
>> The Xen balloon driver has an own callback for onlining pages. The pages
>> are just added to the ballooned-out page list without handing them to the
>> allocator. This is done only when the guest is ballooned up.
> 
> OK, I see. Let me just rephrase to see whether we are on the same page.
> Xen is overriding the online_page_callback to xen_online_page which
> doesn't free pages to the page allocator which means that a zone might
> remain unpopulated after onlining. This means that the default zone
> lists rebuild is not done and later on when those pages are finally
> released to the allocator there is no build_all_zonelists happening so
> those freed pages are not really visible to the allocator via zonelists
> fallback allocation.
> 
> Now to your patch. I suspect this is not sufficient for the full hotplug
> situation. Consider a new NUMA node to be hotadded. hotadd_new_pgdat
> will call build_all_zonelists but the zone is not populated yet at that
> moment unless I am missing something. We do rely on online_pages to
> rebuild once pages are onlined - which usually means they are freed to
> the page allocator.
> 
> The zonelists building is kinda messy TBH. I have to say that I am not
> really clear on Mel's 6aa303defb74 ("mm, vmscan: only allocate and
> reclaim from zones with pages managed by the buddy allocator") because
> as you have said unpoppulated zone is not (or shouldn't be) really all
> that different from a depleted zone.
> 
> I think a better and more complete fix would be the following. In other
> words the zonelists will be built for all present zones. Not sure
> whether that is going to break 6aa303defb74 though.
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a9627dc784c..880c455e2557 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1062,7 +1062,6 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages,
>  		       struct zone *zone, struct memory_group *group)
>  {
>  	unsigned long flags;
> -	int need_zonelists_rebuild = 0;
>  	const int nid = zone_to_nid(zone);
>  	int ret;
>  	struct memory_notify arg;
> @@ -1106,17 +1105,13 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages,
>  	 * This means the page allocator ignores this zone.
>  	 * So, zonelist must be updated after online.
>  	 */
> -	if (!populated_zone(zone)) {
> -		need_zonelists_rebuild = 1;
> +	if (!populated_zone(zone))
>  		setup_zone_pageset(zone);
> -	}
>  
>  	online_pages_range(pfn, nr_pages);
>  	adjust_present_page_count(pfn_to_page(pfn), group, nr_pages);
>  
>  	node_states_set_node(nid, &arg);
> -	if (need_zonelists_rebuild)
> -		build_all_zonelists(NULL);
>  
>  	/* Basic onlining is complete, allow allocation of onlined pages. */
>  	undo_isolate_page_range(pfn, pfn + nr_pages, MIGRATE_MOVABLE);
> @@ -1985,10 +1980,8 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages,
>  	/* reinitialise watermarks and update pcp limits */
>  	init_per_zone_wmark_min();
>  
> -	if (!populated_zone(zone)) {
> +	if (!populated_zone(zone))
>  		zone_pcp_reset(zone);
> -		build_all_zonelists(NULL);
> -	}
>  
>  	node_states_clear_node(node, &arg);
>  	if (arg.status_change_nid >= 0) {
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 3589febc6d31..130a2feceddc 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6112,10 +6112,8 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
>  	do {
>  		zone_type--;
>  		zone = pgdat->node_zones + zone_type;
> -		if (managed_zone(zone)) {
> -			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
> -			check_highest_zone(zone_type);
> -		}
> +		zoneref_set_zone(zone, &zonerefs[nr_zones++]);
> +		check_highest_zone(zone_type);
>  	} while (zone_type);
>  
>  	return nr_zones;

I don't think having !populated zones in the zonelist is a particularly
good idea. Populated vs !populated changes only during page
onlininge/offlining.

If I'm not wrong, with your patch we'd even include ZONE_DEVICE here ...

I'd vote for going with the simple fix first, which should be good
enough AFAIKT.

-- 
Thanks,

David / dhildenb



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:04:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:04:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300741.513039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQrr-0007H6-GN; Thu, 07 Apr 2022 12:04:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300741.513039; Thu, 07 Apr 2022 12:04:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQrr-0007Gz-CM; Thu, 07 Apr 2022 12:04:03 +0000
Received: by outflank-mailman (input) for mailman id 300741;
 Thu, 07 Apr 2022 12:04:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uyv1=UR=suse.com=mhocko@srs-se1.protection.inumbo.net>)
 id 1ncQrq-0007Gt-Nx
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 12:04:02 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cd9a1891-b66a-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 14:03:57 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id 50D771F85A;
 Thu,  7 Apr 2022 12:04:01 +0000 (UTC)
Received: from suse.cz (unknown [10.100.201.86])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id 0887EA3B96;
 Thu,  7 Apr 2022 12:04:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd9a1891-b66a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649333041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=yD6Hv0Qev4TUL19bY/g1Sx375Qm9AbFeZHHdH3oY4hs=;
	b=nyUXqwYZBdRJ+l/n+nNGbkZWDe7Bqq+oy/9xD+GmBS6dBr+gvMlU+jcSshfTcrFJFz1eKf
	WOdzx1NwqOpGiWVEPbEodpWKamYAO+1G6nea8neoVBEI9wnICynBWROc1V3VeqRcWfHsxN
	oH6daT+1azkNl7uvjrk1FB4sy6VhfOs=
Date: Thu, 7 Apr 2022 14:04:00 +0200
From: Michal Hocko <mhocko@suse.com>
To: David Hildenbrand <david@redhat.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <Yk7TMKBAkuSVZRLT@dhcp22.suse.cz>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
 <Yk7NqTlw7lmFzpKb@dhcp22.suse.cz>
 <770d8283-4315-3d83-4f8b-723308fffe5c@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <770d8283-4315-3d83-4f8b-723308fffe5c@redhat.com>

On Thu 07-04-22 13:58:44, David Hildenbrand wrote:
[...]
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index 3589febc6d31..130a2feceddc 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -6112,10 +6112,8 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
> >  	do {
> >  		zone_type--;
> >  		zone = pgdat->node_zones + zone_type;
> > -		if (managed_zone(zone)) {
> > -			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
> > -			check_highest_zone(zone_type);
> > -		}
> > +		zoneref_set_zone(zone, &zonerefs[nr_zones++]);
> > +		check_highest_zone(zone_type);
> >  	} while (zone_type);
> >  
> >  	return nr_zones;
> 
> I don't think having !populated zones in the zonelist is a particularly
> good idea. Populated vs !populated changes only during page
> onlininge/offlining.
> 
> If I'm not wrong, with your patch we'd even include ZONE_DEVICE here ...

What kind of problem that would cause? The allocator wouldn't see any
pages at all so it would fallback to the next one. Maybe kswapd would
need some tweak to have a bail out condition but as mentioned in the
thread already. !populated or !managed for that matter are not all that
much different from completely depleted zones. The fact that we are
making that distinction has led to some bugs and I suspect it makes the
code more complex without a very good reason.

> I'd vote for going with the simple fix first, which should be good
> enough AFAIKT.

yes, see the other reply

-- 
Michal Hocko
SUSE Labs


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:06:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:06:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300745.513049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQuO-0007tR-TR; Thu, 07 Apr 2022 12:06:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300745.513049; Thu, 07 Apr 2022 12:06:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncQuO-0007tK-QY; Thu, 07 Apr 2022 12:06:40 +0000
Received: by outflank-mailman (input) for mailman id 300745;
 Thu, 07 Apr 2022 12:06:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncQuN-0007tE-Uw
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 12:06:39 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2b6b0a45-b66b-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 14:06:34 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C4B5F1F85A;
 Thu,  7 Apr 2022 12:06:38 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 851E113485;
 Thu,  7 Apr 2022 12:06:38 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1/lNH87TTmIFBQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 12:06:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b6b0a45-b66b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649333198; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=UpuTzjjU3dwrDNlWUgU1m4VL7JE5wjWtlut0wOZ6+Us=;
	b=bamm/WXnOVYE8ZOho6XQUe7FCEZovOUuJfhlzWNhhXeUA04h7c/K9EahBbNmRzY3a1B0GV
	PYCeX6iSGlyPLVgg+TcAICaXy7ccBN1LFAaAz/36KVQU1wVrrWfK5NFQkqu3UV7fDyUDHl
	I7ddY451v2TFm/p8DP18Y42M5VrwxQE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Michal Hocko <mhocko@suse.com>
Subject: [PATCH v2] mm, page_alloc: fix build_zonerefs_node()
Date: Thu,  7 Apr 2022 14:06:37 +0200
Message-Id: <20220407120637.9035-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Since commit 6aa303defb74 ("mm, vmscan: only allocate and reclaim from
zones with pages managed by the buddy allocator") only zones with free
memory are included in a built zonelist. This is problematic when e.g.
all memory of a zone has been ballooned out when zonelists are being
rebuilt.

The decision whether to rebuild the zonelists when onlining new memory
is done based on populated_zone() returning 0 for the zone the memory
will be added to. The new zone is added to the zonelists only, if it
has free memory pages (managed_zone() returns a non-zero value) after
the memory has been onlined. This implies, that onlining memory will
always free the added pages to the allocator immediately, but this is
not true in all cases: when e.g. running as a Xen guest the onlined
new memory will be added only to the ballooned memory list, it will be
freed only when the guest is being ballooned up afterwards.

Another problem with using managed_zone() for the decision whether a
zone is being added to the zonelists is, that a zone with all memory
used will in fact be removed from all zonelists in case the zonelists
happen to be rebuilt.

Use populated_zone() when building a zonelist as it has been done
before that commit.

Cc: stable@vger.kernel.org
Fixes: 6aa303defb74 ("mm, vmscan: only allocate and reclaim from zones with pages managed by the buddy allocator")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Michal Hocko <mhocko@suse.com>
---
V2:
- updated commit message (Michal Hocko)
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index bdc8f60ae462..3d0662af3289 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
 	do {
 		zone_type--;
 		zone = pgdat->node_zones + zone_type;
-		if (managed_zone(zone)) {
+		if (populated_zone(zone)) {
 			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
 			check_highest_zone(zone_type);
 		}
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:13:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:13:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300749.513061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncR0I-00018J-HH; Thu, 07 Apr 2022 12:12:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300749.513061; Thu, 07 Apr 2022 12:12:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncR0I-00018C-Du; Thu, 07 Apr 2022 12:12:46 +0000
Received: by outflank-mailman (input) for mailman id 300749;
 Thu, 07 Apr 2022 12:12:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1UeT=UR=redhat.com=david@srs-se1.protection.inumbo.net>)
 id 1ncR0G-000184-Oy
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 12:12:44 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 069ef4bd-b66c-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 14:12:43 +0200 (CEST)
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-614-LwJ02UxGNW6o0TXp7NXWJw-1; Thu, 07 Apr 2022 08:12:41 -0400
Received: by mail-wm1-f71.google.com with SMTP id
 r19-20020a7bc093000000b0038e706da7c0so2895998wmh.1
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 05:12:40 -0700 (PDT)
Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8?
 ([2a09:80c0:192:0:20af:34be:985b:b6c8])
 by smtp.gmail.com with ESMTPSA id
 b8-20020a05600c4e0800b0038c6c37efc3sm7370765wmq.12.2022.04.07.05.12.38
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Apr 2022 05:12:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 069ef4bd-b66c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649333562;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=He8h+g9gcpriqclLdlbV5LzBn0WlLmTvUFHHwXaoICE=;
	b=GxmHoz3mvqVkuOjk50fkuE1bi4h4MZKOWFLKa8nWsAp4YZeFb+45Jq3XxZW8Ch4/bqxTCH
	NiSizmijzHDzMGDBd2VjGmFse/ElX8XZmscI9WhNXKHw3EiJQhL/mgoijBx40taApubI6I
	/svwLnGe2oH6OIOks9qZNBG3rOYe4mg=
X-MC-Unique: LwJ02UxGNW6o0TXp7NXWJw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:organization:in-reply-to
         :content-transfer-encoding;
        bh=He8h+g9gcpriqclLdlbV5LzBn0WlLmTvUFHHwXaoICE=;
        b=IZk6YzAWh1A1Jyw1TEIOBDSw8REZEoJtOZuKn5KrFRVNsOYeVdeWccEI8jlqvAJISc
         8BHSwgCPB9P+r2ykubBPEVmruAQusCRtFEKHK/hWEkjmEyBuqeOYl9SFBpxWtAIBgGg3
         MepthnMq+yHbeW1Dye448S+k0L9fsLCRR/h30evvIJcTDA2DHkyGebwL0mQubHQiZw2b
         jCY0+Em0qUQXFb4ZgfKlpgeHOzModvuE3l4y2L2s2yC3XjYxyWygwfkPfPpbSLh7G60U
         JwEKgZARTMKiya4SK/i8FeV1Q12jaz8/jSdnL2zyT3V9eVoAGGjbxb0KtHmyEd6ApiEY
         ewZA==
X-Gm-Message-State: AOAM532AiRphYbNMOzQU5+gEnOyb8SjCai/naTOsnkOR7BFW/fhah9FX
	B9kHaCDMscy5fJhVKDjHAjkdGqMnU+YeeYZLyURrUeUPc+ZZkatVtT2A1rFQQ4CakVu3bj/suJN
	WKYnshJINYBG/vVsGgFEMmlclgoc=
X-Received: by 2002:a05:600c:4f08:b0:38c:93fd:570f with SMTP id l8-20020a05600c4f0800b0038c93fd570fmr12048352wmq.136.1649333559834;
        Thu, 07 Apr 2022 05:12:39 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx8VD2jmyYCLdT1LS37dFQHExBQz5m/CcSM2lhqIzro2UScARspuOQOmGyPtwzTU/phPmvvNw==
X-Received: by 2002:a05:600c:4f08:b0:38c:93fd:570f with SMTP id l8-20020a05600c4f0800b0038c93fd570fmr12048327wmq.136.1649333559539;
        Thu, 07 Apr 2022 05:12:39 -0700 (PDT)
Message-ID: <ca22625e-b72c-059a-9242-f10b291be4fe@redhat.com>
Date: Thu, 7 Apr 2022 14:12:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
To: Michal Hocko <mhocko@suse.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Mel Gorman <mgorman@suse.de>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
 <Yk7NqTlw7lmFzpKb@dhcp22.suse.cz>
 <770d8283-4315-3d83-4f8b-723308fffe5c@redhat.com>
 <Yk7TMKBAkuSVZRLT@dhcp22.suse.cz>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <Yk7TMKBAkuSVZRLT@dhcp22.suse.cz>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 07.04.22 14:04, Michal Hocko wrote:
> On Thu 07-04-22 13:58:44, David Hildenbrand wrote:
> [...]
>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>>> index 3589febc6d31..130a2feceddc 100644
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -6112,10 +6112,8 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
>>>  	do {
>>>  		zone_type--;
>>>  		zone = pgdat->node_zones + zone_type;
>>> -		if (managed_zone(zone)) {
>>> -			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>>> -			check_highest_zone(zone_type);
>>> -		}
>>> +		zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>>> +		check_highest_zone(zone_type);
>>>  	} while (zone_type);
>>>  
>>>  	return nr_zones;
>>
>> I don't think having !populated zones in the zonelist is a particularly
>> good idea. Populated vs !populated changes only during page
>> onlininge/offlining.
>>
>> If I'm not wrong, with your patch we'd even include ZONE_DEVICE here ...
> 
> What kind of problem that would cause? The allocator wouldn't see any
> pages at all so it would fallback to the next one. Maybe kswapd would
> need some tweak to have a bail out condition but as mentioned in the
> thread already. !populated or !managed for that matter are not all that
> much different from completely depleted zones. The fact that we are
> making that distinction has led to some bugs and I suspect it makes the
> code more complex without a very good reason.

I assume performance problems. Assume you have an ordinary system with
multiple NUMA nodes and no MOVABLE memory. Most nodes will only have
ZONE_NORMAL. Yet, you'd include ZONE_DMA* and ZONE_MOVABLE that will
always remain empty to be traversed on each and every allocation
fallback. Of course, we could measure, but IMHO at least *that* part of
memory onlining/offlining is not the complicated part :D

Populated vs. !populated is under pretty good control via page
onlining/offlining. We have to be careful with "managed pages", because
that's a moving target, especially with memory ballooning. And I assume
that's the bigger source of bugs.

> 
>> I'd vote for going with the simple fix first, which should be good
>> enough AFAIKT.
> 
> yes, see the other reply
> 

I think we were composing almost simultaneously :)

-- 
Thanks,

David / dhildenb



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:14:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:14:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300753.513071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncR2H-0001hT-TS; Thu, 07 Apr 2022 12:14:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300753.513071; Thu, 07 Apr 2022 12:14:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncR2H-0001hM-QW; Thu, 07 Apr 2022 12:14:49 +0000
Received: by outflank-mailman (input) for mailman id 300753;
 Thu, 07 Apr 2022 12:14:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uyv1=UR=suse.com=mhocko@srs-se1.protection.inumbo.net>)
 id 1ncR2G-0001hG-Bg
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 12:14:48 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50e3e2f0-b66c-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 14:14:47 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id D5A2F210EA;
 Thu,  7 Apr 2022 12:14:46 +0000 (UTC)
Received: from suse.cz (unknown [10.100.201.86])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id 9F5F8A3B82;
 Thu,  7 Apr 2022 12:14:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50e3e2f0-b66c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649333686; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PtNVmE1emwW/zSfcFurzs/NtccDx0eiUPTowKoz+RNk=;
	b=QvJvZjV3tnz+F/+YT8CTV+iCfToW0qpQ1YrYkaoPuNKKBfsYg3NyFAmcfqk67894y2NESO
	gIq26lohcEJChJElvQSTvMjfREMEIQhWvtmPFJVWAP1l0iEiHuh7wEkgEKqkZrSkRUiI8G
	0hVaK9HWxIE7RMwIqk4KMKL+YLHFRtE=
Date: Thu, 7 Apr 2022 14:14:46 +0200
From: Michal Hocko <mhocko@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v2] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <Yk7VtrgrQ5WabLcb@dhcp22.suse.cz>
References: <20220407120637.9035-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220407120637.9035-1-jgross@suse.com>

[CC Mel]

On Thu 07-04-22 14:06:37, Juergen Gross wrote:
> Since commit 6aa303defb74 ("mm, vmscan: only allocate and reclaim from
> zones with pages managed by the buddy allocator") only zones with free
> memory are included in a built zonelist. This is problematic when e.g.
> all memory of a zone has been ballooned out when zonelists are being
> rebuilt.
> 
> The decision whether to rebuild the zonelists when onlining new memory
> is done based on populated_zone() returning 0 for the zone the memory
> will be added to. The new zone is added to the zonelists only, if it
> has free memory pages (managed_zone() returns a non-zero value) after
> the memory has been onlined. This implies, that onlining memory will
> always free the added pages to the allocator immediately, but this is
> not true in all cases: when e.g. running as a Xen guest the onlined
> new memory will be added only to the ballooned memory list, it will be
> freed only when the guest is being ballooned up afterwards.

Thanks this is much more clearer!
 
> Another problem with using managed_zone() for the decision whether a
> zone is being added to the zonelists is, that a zone with all memory
> used will in fact be removed from all zonelists in case the zonelists
> happen to be rebuilt.
> 
> Use populated_zone() when building a zonelist as it has been done
> before that commit.
> 
> Cc: stable@vger.kernel.org
> Fixes: 6aa303defb74 ("mm, vmscan: only allocate and reclaim from zones with pages managed by the buddy allocator")
> Reported-by: Marek Marczykowski-G�recki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> V2:
> - updated commit message (Michal Hocko)
> ---
>  mm/page_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bdc8f60ae462..3d0662af3289 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
>  	do {
>  		zone_type--;
>  		zone = pgdat->node_zones + zone_type;
> -		if (managed_zone(zone)) {
> +		if (populated_zone(zone)) {
>  			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>  			check_highest_zone(zone_type);
>  		}
> -- 
> 2.34.1

-- 
Michal Hocko
SUSE Labs


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:21:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:21:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300758.513083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncR90-0003RZ-LW; Thu, 07 Apr 2022 12:21:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300758.513083; Thu, 07 Apr 2022 12:21:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncR90-0003RS-Hg; Thu, 07 Apr 2022 12:21:46 +0000
Received: by outflank-mailman (input) for mailman id 300758;
 Thu, 07 Apr 2022 12:21:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncR8y-0003RI-TN; Thu, 07 Apr 2022 12:21:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncR8y-0007KJ-Q1; Thu, 07 Apr 2022 12:21:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncR8y-0008Ad-Ep; Thu, 07 Apr 2022 12:21:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncR8y-0008D2-EM; Thu, 07 Apr 2022 12:21:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ypLqCc4z9YIKYe2kn76b8sz3tiRBjds9bPc5E+cdDdY=; b=yFHyaZ/CK1Z/CTllmYggTfAa1J
	Mxdnm9FARlDMA+EN/PMon6xMbfWl2t0Ou04alISjsgGOAyy3ZioFrK4ux0pVAvJsGkzTYMncwv8ai
	jw3cHyoQrc+KYbCgyyrNC0JSuUucBKsCbL1M9OnnXt4lyuFn6uRYYMqr2XjrNBXhju8M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169207-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169207: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=9890eb005625efaa83d5a83dbf104ca50503c2d4
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 12:21:44 +0000

flight 169207 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169207/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              9890eb005625efaa83d5a83dbf104ca50503c2d4
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  636 days
Failing since        151818  2020-07-11 04:18:52 Z  635 days  617 attempts
Testing same since   169207  2022-04-07 04:21:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 103777 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:33:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:33:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300767.513094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRJm-0005Gd-ST; Thu, 07 Apr 2022 12:32:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300767.513094; Thu, 07 Apr 2022 12:32:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRJm-0005GW-PU; Thu, 07 Apr 2022 12:32:54 +0000
Received: by outflank-mailman (input) for mailman id 300767;
 Thu, 07 Apr 2022 12:32:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dlDc=UR=techsingularity.net=mgorman@srs-se1.protection.inumbo.net>)
 id 1ncRJm-0005GQ-9C
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 12:32:54 +0000
Received: from outbound-smtp31.blacknight.com (outbound-smtp31.blacknight.com
 [81.17.249.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d7cadad1-b66e-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 14:32:52 +0200 (CEST)
Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152])
 by outbound-smtp31.blacknight.com (Postfix) with ESMTPS id 2E541C0B72
 for <xen-devel@lists.xenproject.org>; Thu,  7 Apr 2022 13:32:52 +0100 (IST)
Received: (qmail 22167 invoked from network); 7 Apr 2022 12:32:51 -0000
Received: from unknown (HELO techsingularity.net)
 (mgorman@techsingularity.net@[84.203.17.223])
 by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated);
 7 Apr 2022 12:32:51 -0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7cadad1-b66e-11ec-a405-831a346695d4
Date: Thu, 7 Apr 2022 13:32:44 +0100
From: Mel Gorman <mgorman@techsingularity.net>
To: Juergen Gross <jgross@suse.com>
Cc: Michal Hocko <mhocko@suse.com>, xen-devel@lists.xenproject.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek Marczykowski-G?recki <marmarek@invisiblethingslab.com>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <20220407115414.GA4148@techsingularity.net>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

On Thu, Apr 07, 2022 at 01:17:19PM +0200, Juergen Gross wrote:
> On 07.04.22 13:07, Michal Hocko wrote:
> > On Thu 07-04-22 12:45:41, Juergen Gross wrote:
> > > On 07.04.22 12:34, Michal Hocko wrote:
> > > > Ccing Mel
> > > > 
> > > > On Thu 07-04-22 11:32:21, Juergen Gross wrote:
> > > > > Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
> > > > > initialization") only zones with free memory are included in a built
> > > > > zonelist. This is problematic when e.g. all memory of a zone has been
> > > > > ballooned out.
> > > > 
> > > > What is the actual problem there?
> > > 
> > > When running as Xen guest new hotplugged memory will not be onlined
> > > automatically, but only on special request. This is done in order to
> > > support adding e.g. the possibility to use another GB of memory, while
> > > adding only a part of that memory initially.
> > > 
> > > In case adding that memory is populating a new zone, the page allocator
> > > won't be able to use this memory when it is onlined, as the zone wasn't
> > > added to the zonelist, due to managed_zone() returning 0.
> > 
> > How is that memory onlined? Because "regular" onlining (online_pages())
> > does rebuild zonelists if their zone hasn't been populated before.
> 
> The Xen balloon driver has an own callback for onlining pages. The pages
> are just added to the ballooned-out page list without handing them to the
> allocator. This is done only when the guest is ballooned up.
> 

Is this new behaviour? I ask because keeping !managed_zones out of the
zonelist and reclaim paths and the behaviour makes sense. Elsewhere you
state "zone can always happen to have no free memory left" and this is true
but it's usually a transient event. The difference between a populated
vs managed zone is usually permanent event where no memory will ever be
placed on the buddy lists because the memory was reserved early in boot
or a similar reason. The patch is probably harmless but it has the
potential to waste CPUs allocating or reclaiming from zones that will
never succeed.

-- 
Mel Gorman
SUSE Labs


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:46:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:46:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300771.513105 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRWe-00078g-3m; Thu, 07 Apr 2022 12:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300771.513105; Thu, 07 Apr 2022 12:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRWd-00078Z-Ve; Thu, 07 Apr 2022 12:46:11 +0000
Received: by outflank-mailman (input) for mailman id 300771;
 Thu, 07 Apr 2022 12:46:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1UeT=UR=redhat.com=david@srs-se1.protection.inumbo.net>)
 id 1ncRWc-00078A-K0
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 12:46:10 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a9d70e42-b670-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 14:45:55 +0200 (CEST)
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-401-zNnOiP86NXigtgSe3wxxxA-1; Thu, 07 Apr 2022 08:46:00 -0400
Received: by mail-wm1-f71.google.com with SMTP id
 r19-20020a7bc093000000b0038e706da7c0so2934358wmh.1
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 05:46:00 -0700 (PDT)
Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8?
 ([2a09:80c0:192:0:20af:34be:985b:b6c8])
 by smtp.gmail.com with ESMTPSA id
 p5-20020adff205000000b0020614a499fbsm13364584wro.90.2022.04.07.05.45.58
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Apr 2022 05:45:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9d70e42-b670-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1649335562;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9/Us2cruhioCbl6RqJqudnxQAOhVEhkUDGtI39MXnNI=;
	b=F3khc/wRidAUIZRG6NgLnks5rzpZim9W81gt+QCnTAJfk5j1Joa/IQHi3RgMmRwPutOdDh
	HMeGrL6ZHj9L58h5BoOmlQ+qKfejMk8XN2l2RgWuMc+eZxg3nu9vzn8ME1dqeYQ5YvXXgo
	opnrhPU0Lu5PEW1Qf+BM1dj8T4Knu/I=
X-MC-Unique: zNnOiP86NXigtgSe3wxxxA-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:organization:in-reply-to
         :content-transfer-encoding;
        bh=9/Us2cruhioCbl6RqJqudnxQAOhVEhkUDGtI39MXnNI=;
        b=RSIZVe6Wf7zVD2dxoLefs7MxOk55RclA3+Sp1RYHusO3cXTJe4WZoJ17B1mGSu82G3
         O+pFvbdydvk2ngjXDPSFIO0Q2giPFDbTO6+AkC3qw1Qn52tIYJuJt0hpHht9n4rTZGfH
         BdaKW36YRg4HxWrJIrxGYFQekcpgW4z+mXmAS0Z0tDwOpmwUug/bv5vZY/7UxkJZSVhz
         qE7xROKrrTA6iQTzCYhVzV/CAijI9vNx03Kkxox4E+vRGnBlTseGwCAEYdEd/L+Pl5pH
         7Fhw96NQQ4loyB0tWxJU+2j28uizuqLO1UMeHH9iT94iHGW8CCGNRtl39jafYdM2t3Th
         93Uw==
X-Gm-Message-State: AOAM531GGTEV+DFy6PpOYn4hOuLkF3ydBklKLfmwDGxqM4GvZoLo9UW1
	YzUXaWDLQVCqZy9uFD92R6SGyY5l7Ts9j1cb8qRjja50HoaWGCEmHqB2bfp7QpVA28nKoBPQZA2
	nl0LVwNsjspGeoU76a8/As1x+R08=
X-Received: by 2002:adf:f6c4:0:b0:206:1581:dabc with SMTP id y4-20020adff6c4000000b002061581dabcmr10825213wrp.375.1649335559572;
        Thu, 07 Apr 2022 05:45:59 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyM1kHX4+XtYoFq61dk62qQKc+KfdCBkhZ/B4Cy+Xlwxk5a3SuVrXH/rmpX3u/AmPLQfe4l7w==
X-Received: by 2002:adf:f6c4:0:b0:206:1581:dabc with SMTP id y4-20020adff6c4000000b002061581dabcmr10825196wrp.375.1649335559301;
        Thu, 07 Apr 2022 05:45:59 -0700 (PDT)
Message-ID: <42046fe0-d4da-625d-6412-b5459b80ee11@redhat.com>
Date: Thu, 7 Apr 2022 14:45:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH v2] mm, page_alloc: fix build_zonerefs_node()
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Michal Hocko <mhocko@suse.com>
References: <20220407120637.9035-1-jgross@suse.com>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20220407120637.9035-1-jgross@suse.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 07.04.22 14:06, Juergen Gross wrote:
> Since commit 6aa303defb74 ("mm, vmscan: only allocate and reclaim from
> zones with pages managed by the buddy allocator") only zones with free
> memory are included in a built zonelist. This is problematic when e.g.
> all memory of a zone has been ballooned out when zonelists are being
> rebuilt.
> 
> The decision whether to rebuild the zonelists when onlining new memory
> is done based on populated_zone() returning 0 for the zone the memory
> will be added to. The new zone is added to the zonelists only, if it
> has free memory pages (managed_zone() returns a non-zero value) after
> the memory has been onlined. This implies, that onlining memory will
> always free the added pages to the allocator immediately, but this is
> not true in all cases: when e.g. running as a Xen guest the onlined
> new memory will be added only to the ballooned memory list, it will be
> freed only when the guest is being ballooned up afterwards.
> 
> Another problem with using managed_zone() for the decision whether a
> zone is being added to the zonelists is, that a zone with all memory
> used will in fact be removed from all zonelists in case the zonelists
> happen to be rebuilt.
> 
> Use populated_zone() when building a zonelist as it has been done
> before that commit.
> 
> Cc: stable@vger.kernel.org
> Fixes: 6aa303defb74 ("mm, vmscan: only allocate and reclaim from zones with pages managed by the buddy allocator")
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> V2:
> - updated commit message (Michal Hocko)
> ---
>  mm/page_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bdc8f60ae462..3d0662af3289 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
>  	do {
>  		zone_type--;
>  		zone = pgdat->node_zones + zone_type;
> -		if (managed_zone(zone)) {
> +		if (populated_zone(zone)) {
>  			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>  			check_highest_zone(zone_type);
>  		}

Did you drop my Ack?

Also, I'd appreciate getting CCed on patches where I commented.

-- 
Thanks,

David / dhildenb



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:50:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:50:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300775.513115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRaF-00081E-IH; Thu, 07 Apr 2022 12:49:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300775.513115; Thu, 07 Apr 2022 12:49:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRaF-000817-FO; Thu, 07 Apr 2022 12:49:55 +0000
Received: by outflank-mailman (input) for mailman id 300775;
 Thu, 07 Apr 2022 12:49:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncRaD-00080z-A3
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 12:49:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 373cd6dc-b671-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 14:49:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5F51F210DF;
 Thu,  7 Apr 2022 12:49:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C4EB13485;
 Thu,  7 Apr 2022 12:49:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1q52Be/dTmJPHgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 12:49:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 373cd6dc-b671-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649335791; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=JRuyghqBSswsUg1+uaNCd7gZNZ3+HLGOdgUt2B+8tHk=;
	b=Cu0pSc2YSWAmZ64wj3ik7Q11oXy0oNKXvhbg38csHSX12KU+ew66rQtr817EaJXS8EifYR
	vxOMQzZSP+JcsP3MWAHIKwV7w/pTmfqwtNuykoH5Is+4fp9BkZJuboBwx2oZbrJC0KKize
	HyaQDI4VCkHEE2HMbV6oYTKzCNXYSbk=
Message-ID: <67bde881-434e-8aca-ac68-21aff4bdb231@suse.com>
Date: Thu, 7 Apr 2022 14:49:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@suse.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 Marek Marczykowski-G?recki <marmarek@invisiblethingslab.com>,
 Mel Gorman <mgorman@suse.de>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
 <20220407115414.GA4148@techsingularity.net>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
In-Reply-To: <20220407115414.GA4148@techsingularity.net>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------CRFwnQwTs316DYKyrzvZhvNI"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------CRFwnQwTs316DYKyrzvZhvNI
Content-Type: multipart/mixed; boundary="------------0a3DHUPxD30uAbBuyhfGEwS6";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@suse.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 Marek Marczykowski-G?recki <marmarek@invisiblethingslab.com>,
 Mel Gorman <mgorman@suse.de>
Message-ID: <67bde881-434e-8aca-ac68-21aff4bdb231@suse.com>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
 <20220407115414.GA4148@techsingularity.net>
In-Reply-To: <20220407115414.GA4148@techsingularity.net>

--------------0a3DHUPxD30uAbBuyhfGEwS6
Content-Type: multipart/mixed; boundary="------------YPysLWDWql3vQilGpQWrCUm5"

--------------YPysLWDWql3vQilGpQWrCUm5
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDQuMjIgMTQ6MzIsIE1lbCBHb3JtYW4gd3JvdGU6DQo+IE9uIFRodSwgQXByIDA3
LCAyMDIyIGF0IDAxOjE3OjE5UE0gKzAyMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP
biAwNy4wNC4yMiAxMzowNywgTWljaGFsIEhvY2tvIHdyb3RlOg0KPj4+IE9uIFRodSAwNy0w
NC0yMiAxMjo0NTo0MSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gT24gMDcuMDQuMjIg
MTI6MzQsIE1pY2hhbCBIb2NrbyB3cm90ZToNCj4+Pj4+IENjaW5nIE1lbA0KPj4+Pj4NCj4+
Pj4+IE9uIFRodSAwNy0wNC0yMiAxMTozMjoyMSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+
Pj4+PiBTaW5jZSBjb21taXQgOWQzYmUyMWJmOWMwICgibW0sIHBhZ2VfYWxsb2M6IHNpbXBs
aWZ5IHpvbmVsaXN0DQo+Pj4+Pj4gaW5pdGlhbGl6YXRpb24iKSBvbmx5IHpvbmVzIHdpdGgg
ZnJlZSBtZW1vcnkgYXJlIGluY2x1ZGVkIGluIGEgYnVpbHQNCj4+Pj4+PiB6b25lbGlzdC4g
VGhpcyBpcyBwcm9ibGVtYXRpYyB3aGVuIGUuZy4gYWxsIG1lbW9yeSBvZiBhIHpvbmUgaGFz
IGJlZW4NCj4+Pj4+PiBiYWxsb29uZWQgb3V0Lg0KPj4+Pj4NCj4+Pj4+IFdoYXQgaXMgdGhl
IGFjdHVhbCBwcm9ibGVtIHRoZXJlPw0KPj4+Pg0KPj4+PiBXaGVuIHJ1bm5pbmcgYXMgWGVu
IGd1ZXN0IG5ldyBob3RwbHVnZ2VkIG1lbW9yeSB3aWxsIG5vdCBiZSBvbmxpbmVkDQo+Pj4+
IGF1dG9tYXRpY2FsbHksIGJ1dCBvbmx5IG9uIHNwZWNpYWwgcmVxdWVzdC4gVGhpcyBpcyBk
b25lIGluIG9yZGVyIHRvDQo+Pj4+IHN1cHBvcnQgYWRkaW5nIGUuZy4gdGhlIHBvc3NpYmls
aXR5IHRvIHVzZSBhbm90aGVyIEdCIG9mIG1lbW9yeSwgd2hpbGUNCj4+Pj4gYWRkaW5nIG9u
bHkgYSBwYXJ0IG9mIHRoYXQgbWVtb3J5IGluaXRpYWxseS4NCj4+Pj4NCj4+Pj4gSW4gY2Fz
ZSBhZGRpbmcgdGhhdCBtZW1vcnkgaXMgcG9wdWxhdGluZyBhIG5ldyB6b25lLCB0aGUgcGFn
ZSBhbGxvY2F0b3INCj4+Pj4gd29uJ3QgYmUgYWJsZSB0byB1c2UgdGhpcyBtZW1vcnkgd2hl
biBpdCBpcyBvbmxpbmVkLCBhcyB0aGUgem9uZSB3YXNuJ3QNCj4+Pj4gYWRkZWQgdG8gdGhl
IHpvbmVsaXN0LCBkdWUgdG8gbWFuYWdlZF96b25lKCkgcmV0dXJuaW5nIDAuDQo+Pj4NCj4+
PiBIb3cgaXMgdGhhdCBtZW1vcnkgb25saW5lZD8gQmVjYXVzZSAicmVndWxhciIgb25saW5p
bmcgKG9ubGluZV9wYWdlcygpKQ0KPj4+IGRvZXMgcmVidWlsZCB6b25lbGlzdHMgaWYgdGhl
aXIgem9uZSBoYXNuJ3QgYmVlbiBwb3B1bGF0ZWQgYmVmb3JlLg0KPj4NCj4+IFRoZSBYZW4g
YmFsbG9vbiBkcml2ZXIgaGFzIGFuIG93biBjYWxsYmFjayBmb3Igb25saW5pbmcgcGFnZXMu
IFRoZSBwYWdlcw0KPj4gYXJlIGp1c3QgYWRkZWQgdG8gdGhlIGJhbGxvb25lZC1vdXQgcGFn
ZSBsaXN0IHdpdGhvdXQgaGFuZGluZyB0aGVtIHRvIHRoZQ0KPj4gYWxsb2NhdG9yLiBUaGlz
IGlzIGRvbmUgb25seSB3aGVuIHRoZSBndWVzdCBpcyBiYWxsb29uZWQgdXAuDQo+Pg0KPiAN
Cj4gSXMgdGhpcyBuZXcgYmVoYXZpb3VyPyBJIGFzayBiZWNhdXNlIGtlZXBpbmcgIW1hbmFn
ZWRfem9uZXMgb3V0IG9mIHRoZQ0KDQpGb3Igc29tZSB0aW1lIChzaW5jZSBrZXJuZWwgNS45
KSBYZW4gaXMgdXNpbmcgdGhlIHpvbmUgZGV2aWNlIGZ1bmN0aW9uYWxpdHkNCndpdGggbWVt
cmVtYXBfcGFnZXMoKSBhbmQgcGdtYXAtPnR5cGUgPSBNRU1PUllfREVWSUNFX0dFTkVSSUMu
DQoNCj4gem9uZWxpc3QgYW5kIHJlY2xhaW0gcGF0aHMgYW5kIHRoZSBiZWhhdmlvdXIgbWFr
ZXMgc2Vuc2UuIEVsc2V3aGVyZSB5b3UNCj4gc3RhdGUgInpvbmUgY2FuIGFsd2F5cyBoYXBw
ZW4gdG8gaGF2ZSBubyBmcmVlIG1lbW9yeSBsZWZ0IiBhbmQgdGhpcyBpcyB0cnVlDQo+IGJ1
dCBpdCdzIHVzdWFsbHkgYSB0cmFuc2llbnQgZXZlbnQuIFRoZSBkaWZmZXJlbmNlIGJldHdl
ZW4gYSBwb3B1bGF0ZWQNCg0KQW5kIGlmIHRoaXMgInRyYW5zaWVudCBldmVudCIgaXMganVz
dCBoYXBwZW5pbmcgd2hlbiB0aGUgem9uZWxpc3RzIGFyZQ0KYmVpbmcgcmVidWlsdCB0aGUg
em9uZSB3aWxsIGJlIG9mZiB0aGUgbGlzdHMgbWF5YmUgZm9yZXZlci4NCg0KPiB2cyBtYW5h
Z2VkIHpvbmUgaXMgdXN1YWxseSBwZXJtYW5lbnQgZXZlbnQgd2hlcmUgbm8gbWVtb3J5IHdp
bGwgZXZlciBiZQ0KPiBwbGFjZWQgb24gdGhlIGJ1ZGR5IGxpc3RzIGJlY2F1c2UgdGhlIG1l
bW9yeSB3YXMgcmVzZXJ2ZWQgZWFybHkgaW4gYm9vdA0KPiBvciBhIHNpbWlsYXIgcmVhc29u
LiBUaGUgcGF0Y2ggaXMgcHJvYmFibHkgaGFybWxlc3MgYnV0IGl0IGhhcyB0aGUNCj4gcG90
ZW50aWFsIHRvIHdhc3RlIENQVXMgYWxsb2NhdGluZyBvciByZWNsYWltaW5nIGZyb20gem9u
ZXMgdGhhdCB3aWxsDQo+IG5ldmVyIHN1Y2NlZWQuDQoNCkknZCByZWNvbW1lbmQgdG8gaGF2
ZSBhbiBleHBsaWNpdCBmbGFnIHBlci16b25lIGZvciB0aGlzIGNhc2UgaWYgeW91DQpyZWFs
bHkgY2FyZSBhYm91dCB0aGF0LiBUaGlzIHdvdWxkIGJlIG11Y2ggY2xlYW5lciB0aGFuIHRv
IGltcGx5IGZyb20NCm5vIGZyZWUgcGFnZSBiZWluZyBwcmVzZW50IGF0IGEgc3BlY2lmaWMg
cG9pbnQgaW4gdGltZSwgdGhhdCB0aGUgem9uZQ0Kd2lsbCBuZXZlciBiZSBzdWJqZWN0IHRv
IG1lbW9yeSBhbGxvY2F0aW9uLg0KDQoNCkp1ZXJnZW4NCg==
--------------YPysLWDWql3vQilGpQWrCUm5
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------YPysLWDWql3vQilGpQWrCUm5--

--------------0a3DHUPxD30uAbBuyhfGEwS6--

--------------CRFwnQwTs316DYKyrzvZhvNI
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJO3e4FAwAAAAAACgkQsN6d1ii/Ey+X
YAgAnYflQLETlejV5vQWm61d5tudx9M3lEU2RyVGrXKexR0dJyeREbRoCJXE76wlZ7xeV/RbiVmj
NppAkYsI+3Dve9D0emCXYdxKwnnTjrpRXIDdA8o8IyFwkqxAWSvA1NrQFlyJ/fMmJ6Db4NP2j+hC
VYFAWEZBaIXf8rufT75PWibg3wGhAHYuJQl/VuUaTlpazXf0RkjZkE+jD2FNtIlCogZUOxqefQGK
cIBBtM8DpQs0FKqPez4uNMC82EX1KfoOUyLR02B7UiYogPsj/2vg7M30JdxLFc0EsmLqolYqDrWb
wyJN7POWb6zJeiEKO7LJK6qjnRz/8TRYipLj9fp1tA==
=2FSz
-----END PGP SIGNATURE-----

--------------CRFwnQwTs316DYKyrzvZhvNI--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 12:53:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 12:53:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300779.513127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRdu-0000xy-3O; Thu, 07 Apr 2022 12:53:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300779.513127; Thu, 07 Apr 2022 12:53:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRdt-0000xr-W3; Thu, 07 Apr 2022 12:53:41 +0000
Received: by outflank-mailman (input) for mailman id 300779;
 Thu, 07 Apr 2022 12:53:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncRds-0000xl-3F
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 12:53:40 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b9fa3934-b671-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 14:53:31 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 95A79210DF;
 Thu,  7 Apr 2022 12:53:38 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 59A8E13485;
 Thu,  7 Apr 2022 12:53:38 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id t7iQFNLeTmJGIAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 12:53:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9fa3934-b671-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649336018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/EuTQDDNt7SlKZvq8vUG4vSUxDPXDs3qHzbCGwSVzWM=;
	b=LGj17H47bAtUxspDmYaq2rczUJIP3ND7VaPahOHbVgS26sH1r3xtU3BsbjE/65ldmi7Ebg
	w6tFh3XIC3D+Vzlp2paPKF+uBsCM850iGcxSSOJan2pc8SrhjUnw7ZdkIGN3tQ0YCUy2F/
	3u8k82tdGFYOMTyzYY5pMsIcBw/fUt4=
Message-ID: <bd29e3c6-45ef-cfe3-4c86-567c2d9ab728@suse.com>
Date: Thu, 7 Apr 2022 14:53:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] mm, page_alloc: fix build_zonerefs_node()
Content-Language: en-US
To: David Hildenbrand <david@redhat.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Michal Hocko <mhocko@suse.com>
References: <20220407120637.9035-1-jgross@suse.com>
 <42046fe0-d4da-625d-6412-b5459b80ee11@redhat.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <42046fe0-d4da-625d-6412-b5459b80ee11@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------t04bfqdDWv4XrdQIqVux6Csd"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------t04bfqdDWv4XrdQIqVux6Csd
Content-Type: multipart/mixed; boundary="------------Z4GSgTHl0SATVg0EAu030Dy6";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: David Hildenbrand <david@redhat.com>, xen-devel@lists.xenproject.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Michal Hocko <mhocko@suse.com>
Message-ID: <bd29e3c6-45ef-cfe3-4c86-567c2d9ab728@suse.com>
Subject: Re: [PATCH v2] mm, page_alloc: fix build_zonerefs_node()
References: <20220407120637.9035-1-jgross@suse.com>
 <42046fe0-d4da-625d-6412-b5459b80ee11@redhat.com>
In-Reply-To: <42046fe0-d4da-625d-6412-b5459b80ee11@redhat.com>

--------------Z4GSgTHl0SATVg0EAu030Dy6
Content-Type: multipart/mixed; boundary="------------izDrloGJ8V3l9n3GAw6J6OtS"

--------------izDrloGJ8V3l9n3GAw6J6OtS
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDQuMjIgMTQ6NDUsIERhdmlkIEhpbGRlbmJyYW5kIHdyb3RlOg0KPiBPbiAwNy4w
NC4yMiAxNDowNiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IFNpbmNlIGNvbW1pdCA2YWEz
MDNkZWZiNzQgKCJtbSwgdm1zY2FuOiBvbmx5IGFsbG9jYXRlIGFuZCByZWNsYWltIGZyb20N
Cj4+IHpvbmVzIHdpdGggcGFnZXMgbWFuYWdlZCBieSB0aGUgYnVkZHkgYWxsb2NhdG9yIikg
b25seSB6b25lcyB3aXRoIGZyZWUNCj4+IG1lbW9yeSBhcmUgaW5jbHVkZWQgaW4gYSBidWls
dCB6b25lbGlzdC4gVGhpcyBpcyBwcm9ibGVtYXRpYyB3aGVuIGUuZy4NCj4+IGFsbCBtZW1v
cnkgb2YgYSB6b25lIGhhcyBiZWVuIGJhbGxvb25lZCBvdXQgd2hlbiB6b25lbGlzdHMgYXJl
IGJlaW5nDQo+PiByZWJ1aWx0Lg0KPj4NCj4+IFRoZSBkZWNpc2lvbiB3aGV0aGVyIHRvIHJl
YnVpbGQgdGhlIHpvbmVsaXN0cyB3aGVuIG9ubGluaW5nIG5ldyBtZW1vcnkNCj4+IGlzIGRv
bmUgYmFzZWQgb24gcG9wdWxhdGVkX3pvbmUoKSByZXR1cm5pbmcgMCBmb3IgdGhlIHpvbmUg
dGhlIG1lbW9yeQ0KPj4gd2lsbCBiZSBhZGRlZCB0by4gVGhlIG5ldyB6b25lIGlzIGFkZGVk
IHRvIHRoZSB6b25lbGlzdHMgb25seSwgaWYgaXQNCj4+IGhhcyBmcmVlIG1lbW9yeSBwYWdl
cyAobWFuYWdlZF96b25lKCkgcmV0dXJucyBhIG5vbi16ZXJvIHZhbHVlKSBhZnRlcg0KPj4g
dGhlIG1lbW9yeSBoYXMgYmVlbiBvbmxpbmVkLiBUaGlzIGltcGxpZXMsIHRoYXQgb25saW5p
bmcgbWVtb3J5IHdpbGwNCj4+IGFsd2F5cyBmcmVlIHRoZSBhZGRlZCBwYWdlcyB0byB0aGUg
YWxsb2NhdG9yIGltbWVkaWF0ZWx5LCBidXQgdGhpcyBpcw0KPj4gbm90IHRydWUgaW4gYWxs
IGNhc2VzOiB3aGVuIGUuZy4gcnVubmluZyBhcyBhIFhlbiBndWVzdCB0aGUgb25saW5lZA0K
Pj4gbmV3IG1lbW9yeSB3aWxsIGJlIGFkZGVkIG9ubHkgdG8gdGhlIGJhbGxvb25lZCBtZW1v
cnkgbGlzdCwgaXQgd2lsbCBiZQ0KPj4gZnJlZWQgb25seSB3aGVuIHRoZSBndWVzdCBpcyBi
ZWluZyBiYWxsb29uZWQgdXAgYWZ0ZXJ3YXJkcy4NCj4+DQo+PiBBbm90aGVyIHByb2JsZW0g
d2l0aCB1c2luZyBtYW5hZ2VkX3pvbmUoKSBmb3IgdGhlIGRlY2lzaW9uIHdoZXRoZXIgYQ0K
Pj4gem9uZSBpcyBiZWluZyBhZGRlZCB0byB0aGUgem9uZWxpc3RzIGlzLCB0aGF0IGEgem9u
ZSB3aXRoIGFsbCBtZW1vcnkNCj4+IHVzZWQgd2lsbCBpbiBmYWN0IGJlIHJlbW92ZWQgZnJv
bSBhbGwgem9uZWxpc3RzIGluIGNhc2UgdGhlIHpvbmVsaXN0cw0KPj4gaGFwcGVuIHRvIGJl
IHJlYnVpbHQuDQo+Pg0KPj4gVXNlIHBvcHVsYXRlZF96b25lKCkgd2hlbiBidWlsZGluZyBh
IHpvbmVsaXN0IGFzIGl0IGhhcyBiZWVuIGRvbmUNCj4+IGJlZm9yZSB0aGF0IGNvbW1pdC4N
Cj4+DQo+PiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZw0KPj4gRml4ZXM6IDZhYTMwM2Rl
ZmI3NCAoIm1tLCB2bXNjYW46IG9ubHkgYWxsb2NhdGUgYW5kIHJlY2xhaW0gZnJvbSB6b25l
cyB3aXRoIHBhZ2VzIG1hbmFnZWQgYnkgdGhlIGJ1ZGR5IGFsbG9jYXRvciIpDQo+PiBSZXBv
cnRlZC1ieTogTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIDxtYXJtYXJla0BpbnZpc2li
bGV0aGluZ3NsYWIuY29tPg0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdy
b3NzQHN1c2UuY29tPg0KPj4gQWNrZWQtYnk6IE1pY2hhbCBIb2NrbyA8bWhvY2tvQHN1c2Uu
Y29tPg0KPj4gLS0tDQo+PiBWMjoNCj4+IC0gdXBkYXRlZCBjb21taXQgbWVzc2FnZSAoTWlj
aGFsIEhvY2tvKQ0KPj4gLS0tDQo+PiAgIG1tL3BhZ2VfYWxsb2MuYyB8IDIgKy0NCj4+ICAg
MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+Pg0KPj4g
ZGlmZiAtLWdpdCBhL21tL3BhZ2VfYWxsb2MuYyBiL21tL3BhZ2VfYWxsb2MuYw0KPj4gaW5k
ZXggYmRjOGY2MGFlNDYyLi4zZDA2NjJhZjMyODkgMTAwNjQ0DQo+PiAtLS0gYS9tbS9wYWdl
X2FsbG9jLmMNCj4+ICsrKyBiL21tL3BhZ2VfYWxsb2MuYw0KPj4gQEAgLTYxMjgsNyArNjEy
OCw3IEBAIHN0YXRpYyBpbnQgYnVpbGRfem9uZXJlZnNfbm9kZShwZ19kYXRhX3QgKnBnZGF0
LCBzdHJ1Y3Qgem9uZXJlZiAqem9uZXJlZnMpDQo+PiAgIAlkbyB7DQo+PiAgIAkJem9uZV90
eXBlLS07DQo+PiAgIAkJem9uZSA9IHBnZGF0LT5ub2RlX3pvbmVzICsgem9uZV90eXBlOw0K
Pj4gLQkJaWYgKG1hbmFnZWRfem9uZSh6b25lKSkgew0KPj4gKwkJaWYgKHBvcHVsYXRlZF96
b25lKHpvbmUpKSB7DQo+PiAgIAkJCXpvbmVyZWZfc2V0X3pvbmUoem9uZSwgJnpvbmVyZWZz
W25yX3pvbmVzKytdKTsNCj4+ICAgCQkJY2hlY2tfaGlnaGVzdF96b25lKHpvbmVfdHlwZSk7
DQo+PiAgIAkJfQ0KPiANCj4gRGlkIHlvdSBkcm9wIG15IEFjaz8NCg0KT2gsIHNvcnJ5IGZv
ciB0aGF0Lg0KDQo+IEFsc28sIEknZCBhcHByZWNpYXRlIGdldHRpbmcgQ0NlZCBvbiBwYXRj
aGVzIHdoZXJlIEkgY29tbWVudGVkLg0KDQpXaWxsIGRvIGluIGZ1dHVyZS4NCg0KDQpKdWVy
Z2VuDQo=
--------------izDrloGJ8V3l9n3GAw6J6OtS
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------izDrloGJ8V3l9n3GAw6J6OtS--

--------------Z4GSgTHl0SATVg0EAu030Dy6--

--------------t04bfqdDWv4XrdQIqVux6Csd
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJO3tEFAwAAAAAACgkQsN6d1ii/Ey/N
7wf/Q6ls4N2V/vkNWRdh1a7qLQuOcrlxdBS3Om7l3hk+u508DrODIMwB4XViur0F0dLmy+MCI1PC
aVsIUkokUlOia2J/wHC+c4MxmkvWz0+fTrhgWMwl0voREDdhtZLXuO4U+axxo5d0D25/BmF+z+PL
ge4zgPYgQjEMF84xmTnLOsywX+eQ5fieoU21y98doQ+di2y+GPu1hms2+w3mdZHL3xGdDc8OyNdJ
WZDmDYZnelXI9LyZSt9lPHaO2X2Vn5b3IhWMBoaTxHuvjSiMe4gVuuZvWoDiQc0WZm9jA77iGhoU
5lbLRjyDnbbXNmW+YYLbJEIzj8kcAxxaLAuwOHnHdQ==
=Yhvw
-----END PGP SIGNATURE-----

--------------t04bfqdDWv4XrdQIqVux6Csd--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 13:02:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 13:02:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300784.513137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRmY-0002md-39; Thu, 07 Apr 2022 13:02:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300784.513137; Thu, 07 Apr 2022 13:02:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRmX-0002mW-Vf; Thu, 07 Apr 2022 13:02:37 +0000
Received: by outflank-mailman (input) for mailman id 300784;
 Thu, 07 Apr 2022 13:02:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8WiQ=UR=bounce.vates.fr=bounce-md_30504962.624ee0e9.v1-c0508264023b43e7a34cf74ecad8f976@srs-se1.protection.inumbo.net>)
 id 1ncRmW-0002mQ-DW
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 13:02:37 +0000
Received: from mail137-2.atl71.mandrillapp.com
 (mail137-2.atl71.mandrillapp.com [198.2.137.2])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fd8c834c-b672-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 15:02:34 +0200 (CEST)
Received: from pmta07.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1])
 by mail137-2.atl71.mandrillapp.com (Mailchimp) with ESMTP id 4KZ1kd2dgBzQXg3cJ
 for <xen-devel@lists.xenproject.org>; Thu,  7 Apr 2022 13:02:33 +0000 (GMT)
Received: from [37.26.189.201] by mandrillapp.com id
 c0508264023b43e7a34cf74ecad8f976; Thu, 07 Apr 2022 13:02:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd8c834c-b672-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr;
	s=mandrill; t=1649336553; x=1649638953; i=olivier.lambert@vates.fr;
	bh=wDhq2JHs7DUC7urGnRJ513yb5CcqY8Emf7iSx9W7n7U=;
	h=From:Subject:Message-Id:To:Cc:Feedback-ID:Date:MIME-Version:
	 Content-Type:CC:Date:Subject;
	b=fxydZ9DJt9kcsktDNlQY/c2yG59PNj8dZOtu/bF9IQ3KUsob6Tj/nYeKYk/uLyE6B
	 zn8ZzEjhz3IofMrVeD7K+7P2BUkF1TMHI+8YaKEmQ84wBKc12nZAPprPzyFZEticzR
	 RRjxD/zYdko0bMLqRcjImTFLBI27zsIqAVFdcBmU=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; 
 i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1649336553; h=From : 
 Subject : Message-Id : To : Cc : Date : MIME-Version : Content-Type : 
 From : Subject : Date : X-Mandrill-User : List-Unsubscribe; 
 bh=wDhq2JHs7DUC7urGnRJ513yb5CcqY8Emf7iSx9W7n7U=; 
 b=p+SQLw2tdUX0OKxYvzvoDZlyPj+02mtItgRfs8a1TA6OkFC+rp5gPW0DiAY7iDIyCcQd3r
 AVUeKVWOH8f5BA2NyJAcLlYsDHk9Ji4qCXu7XGAOzwi6bH3wPF+Gte7FMhI2r3apKAp+Tpql
 2oHedHxsjbDZI8b81jo8XFdp9hzkg=
From: Olivier Lambert <olivier.lambert@vates.fr>
Subject: Xen Project management working group
X-Bm-Draft-Refresh-Date: 1649336550818
X-Bm-Internal-Id: 51E2DD5C-2A80-4022-B0C6-3DE883716B7A#bluemind-4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2:708981
X-Bm-Previous-Body: 486ec8e9d57b4bccb6cbb1afc1970088572c15bf
X-Bm-Disclaimer: Yes
X-Bm-Milter-Handled: ccd00a1f-1643-428b-8802-f28a7c8bc680
X-Bm-Transport-Timestamp: 1649336551558
Message-Id: <l1oyquzo.rukzku9wc9og@vates.fr>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, george.dunlap@citrix.com, Marc Ungeschikts <marc.ungeschikts@vates.fr>
X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com
X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.c0508264023b43e7a34cf74ecad8f976
X-Mandrill-User: md_30504962
Feedback-ID: 30504962:30504962.20220407:md
Date: Thu, 07 Apr 2022 13:02:33 +0000
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="_av-eeEylkwaZNJ7YKuIyeuMzQ"

--_av-eeEylkwaZNJ7YKuIyeuMzQ
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi,


As announced during the latest Xen community call, we (George and I) would like to provide a simple and global view on the current state of the Xen project. For example: what are the current features in progress, those to discuss, things blocked, some finished and so on.


We'd like to make it simple as possible (only tracking biggest topics), so anyone could understand what's going on, instead of having to rely only on the mailing list, which can be hard if you don't follow it on a daily basis (or if you don't understand all the technical details). We also think it could help a lot to remember what has been done, what's next, and what are the important or blocked topics, maybe to discuss during a monthly discussion or the community meeting itself?


And to do all of that without adding any extra burden for developers, we can provide some time of our project manager working at Vates, Marc Ungeschikts. I think this first non-technical contribution to Xen project could help it on multiple aspects: easy of internal tracking for release managers and developers, but also for people who want to communicate more on the Xen project itself, and discover the cool features that are currently developed. In any case, having someone dedicated for these tasks will also be a guarantee we won't miss anything.


Obviously, we want to move step by step, starting by a simple "demo" by gathering ourselves the things in progress and so on. Then to show it during a next community call, and discuss from there.


Before getting to that first demo, we need to choose the tools we'd like to use: Jira, Gitlab, something else? We need something that's simple to navigate, but also ideally if we could avoid multiplying platforms/tools, that would be great (so we have a small pref for Gitlab right now, but nothing is decided).


If you are interested to help us on our next tool choices and discuss about how to fetch the current relevant topics on Xen mailing list, please join us for a first dedicated meeting. I created a Doodle link, and tried to keep it at as a "compatible" hour if you are in EU or in the US:


https://doodle.com/meeting/participate/id/b822G1ge


I will probably leave the Doodle opened for few days (like up to Monday evening) until we can decide the best schedule without waiting too long. When I'll have the validated time slot, I'll communicate about it here.


Let me know if you have any questions :)



Regards,


Olivier Lambert | Vates CEO
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com

--_av-eeEylkwaZNJ7YKuIyeuMzQ
Content-Type: multipart/related; boundary="_av-VkpJar4l9AA4VAwV-Jrgcw"

--_av-VkpJar4l9AA4VAwV-Jrgcw
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
 <head></head>
 <body>
  <div id="bm-composer-content-wrapper">
   <p style="margin-bottom: 0; margin-top: 0;">Hi,</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">As announced during the latest Xen community call, we (George and I) would like to provide a simple and global view on the current state of the Xen project. For example: what are the current features in progress, those to discuss, things blocked, some finished and so on.</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">We'd like to make it simple as possible (only tracking biggest topics), so anyone could understand what's going on, instead of having to rely only on the mailing list, which can be hard if you don't follow it on a daily basis (or if you don't understand all the technical details). We also think it could help a lot to remember what has been done, what's next, and what are the important or blocked topics, maybe to discuss during a monthly discussion or the community meeting itself?</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">And to do all of that without adding any extra burden for developers, we can provide some time of our project manager working at Vates, Marc Ungeschikts. I think this first non-technical contribution to Xen project could help it on multiple aspects: easy of internal tracking for release managers and developers, but also for people who want to communicate more on the Xen project itself, and discover the cool features that are currently developed. In any case, having someone dedicated for these tasks will also be a guarantee we won't miss anything.</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Obviously, we want to move step by step, starting by a simple "demo" by gathering ourselves the things in progress and so on. Then to show it during a next community call, and discuss from there.</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Before getting to that first demo, we need to choose the tools we'd like to use: Jira, Gitlab, something else? We need something that's simple to navigate, but also ideally if we could avoid multiplying platforms/tools, that would be great (so we have a small pref for Gitlab right now, but nothing is decided).</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">If you are interested to help us on our next tool choices and discuss about how to fetch the current relevant topics on Xen mailing list, please join us for a first dedicated meeting. I created a Doodle link, and tried to keep it at as a "compatible" hour if you are in EU or in the US:</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">https://doodle.com/meeting/participate/id/b822G1ge</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">I will probably leave the Doodle opened for few days (like up to Monday evening) until we can decide the best schedule without waiting too long. When I'll have the validated time slot, I'll communicate about it here.</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Let me know if you have any questions :)</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Regards,</p>
   <style></style>
  </div>
  <div class="x-disclaimer995950824">
   <div>
     &nbsp;
   </div>
   <div>
     &nbsp;
   </div>
   <div>
    <div>
     <br>
     <table>
      <tbody>
       <tr>
        <td style="font-size: 10pt;">&nbsp;</td>
        <td style="font-size: 10pt; padding-left: 20px; border-left-color: #b42626; border-left-style: solid; border-left-width: 1px;">
         <div> <strong> <span>Olivier Lambert</span> | Vates CEO</strong>
          <br><strong>XCP-ng &amp; Xen Orchestra - </strong>Vates solutions
         </div>
         <div> <strong>w:</strong>&nbsp;vates.fr&nbsp;| xcp-ng.org | xen-orchestra.com
         </div>
         <div>
          <img style="width: 187px;" src="cid:x-disclaimer995950824-1649336551558.png@bm-disclaimer">
         </div> </td>
       </tr>
      </tbody>
     </table>
    </div>
   </div>
  </div>
 <img src="https://mandrillapp.com/track/open.php?u=30504962&id=c0508264023b43e7a34cf74ecad8f976" height="1" width="1"></body>
</html>

--_av-VkpJar4l9AA4VAwV-Jrgcw
Content-Type: image/png
Content-Transfer-Encoding: base64
Content-Id: <x-disclaimer995950824-1649336551558.png@bm-disclaimer>
Content-Disposition: inline

/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB
AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/
2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB
AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA
HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF
BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK
FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1
dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG
x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB
AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC
AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom
JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE
hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU
1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA
CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo
AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR
8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0
nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7
9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq
rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8
F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+
Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5
+GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS
b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL
iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m
J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/
4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B
axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8
Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W
0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+
7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4
S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM
fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN
iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+
JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL
QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3
aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8
M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm
sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e
Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/
j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/
hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f
Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL
hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8
HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI
/wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt
y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r
7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3
hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia
2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT
jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW
KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x
D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9
/p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP
DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx
XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT
6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A
BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F
tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt
X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI
re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb
9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv
F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ
pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88
KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf
izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM
77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8
e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7
i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4
ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4
P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD
4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4
ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01
8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet
R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq
/wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n
dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M
vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8
SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y
+NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67
SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW
krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI
Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n
/Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP
A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX
uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d
yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa
fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm
8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt
Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D
fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN
PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD
vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc
oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf
EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg
uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS
0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K
U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if
xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60
qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A
wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj
BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z
B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z
3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5
Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz
AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx
7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8
vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44
+IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v
+/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb
AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3
uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq
XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx
fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0
Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr
W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340
fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4
Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn
/BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G
o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38
KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/
jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2
mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr
HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm
3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh
h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U
YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD
adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun
RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF
43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt
4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7
G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH
ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP
2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju
FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94
uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr
IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+
J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21
OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3
/g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0
r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ
D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox
8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w
dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T
vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A
g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe
0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v
14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S
8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+
BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/
AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/
sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X
WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G
n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T
wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4
M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW
iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy
/wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr
S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd
+wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv
CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E
T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i
Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e
aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR
8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg
v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp
YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/
BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT
NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b
jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk
0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf
oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua
VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ
88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS
tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr
5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6
Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6
RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx
mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC
EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/
Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F
PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT
w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc
PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7
sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU
qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD
GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU
AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF
0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF
Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+
GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo
0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv
tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740
xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a
eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT
zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n
XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h
ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl
Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4
YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k
P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK
HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez
wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl
0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH
x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd
oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u
0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc
pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i
C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm
qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV
v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u
WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2
fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x
A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT
i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5
rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD
xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP
X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l
/q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6
WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL
EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw
fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB
p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin
JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU
62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF
AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7
694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY
vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k
Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv
jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH
XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el
OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/
BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L
+E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt
L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW
8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw
2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+
HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G
0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad
pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD
e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If
GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP
4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh
qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4
NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2
/wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0
1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI
8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+
Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy
3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy
2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8
RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW
SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp
ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv
FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv
ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz
B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe
NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74
meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r
Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR
oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl
kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0
nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ
JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO
nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI
pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT
lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K
Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un
jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q
jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J
wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV
cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1
W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs
8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY
PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx
mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay
NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i
gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N
ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX
rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0
H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p
1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj
MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy
OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx
/tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM
n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/
2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn
LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH
/wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd
5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun
XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ
uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9
6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf
C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c
yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A
qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM
SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr
8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV
lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL
/wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W
G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz
ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b
+GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w
9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B
ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k
mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS
qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf
XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815
60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr
xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl
nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft
RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3
s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE
jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690
H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM
NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj
7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs
ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1
ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4
nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG
4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD
3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A
HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd
anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ
hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj
TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm
IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS
P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh
6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q
Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8
T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj
G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw
mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr
xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v
VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC
61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+
ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR
OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5
TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf
8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v
wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh
Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM
2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44
YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3
KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e
PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx
Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf
gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg
AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu
PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+
WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G
/CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr
CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y
RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze
Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+
TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt
Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+
WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP
ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If
iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng
sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/
B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1
JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV
8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P
4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9
u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ
8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u
eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1
K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO
eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB
ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK
FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL
8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj
5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg
oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0
FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7
f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX
PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km
22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/
sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL
L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND
COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ
qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+
wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp
6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm
ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy
n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj
Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB
Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/
AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7
fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u
1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu
XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR
1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0
n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd
8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS
lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV
ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU
j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O
I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw
0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN
3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k
z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1
tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY
B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj
KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s
XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN
bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7
rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w
R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr
9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl
UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG
NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm
FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc
/tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy
zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+
ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U
3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl
gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE
ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt
WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi
Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9
bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl
ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR
pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh
2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z
NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo
3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp
utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj
Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB
ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST
gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N
PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0
7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0
cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa
jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA
CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV
5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV
xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq
5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx
A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl
B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/
FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I
7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC
m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/
4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli
x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP
tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8
PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K
3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6
nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs
1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA
FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej
7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm
eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+
D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi
lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf
Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs
6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z
1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP
2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r
T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp
q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M
XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3
HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7
u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT
ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP
rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf
i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh
a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O
pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp
08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj
XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG
MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q
ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2
R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+
P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i
xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax
vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF
Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk
Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP
82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb
LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA
CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo
AKACgD//2Q==

--_av-VkpJar4l9AA4VAwV-Jrgcw--

--_av-eeEylkwaZNJ7YKuIyeuMzQ--



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 13:13:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 13:13:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300789.513149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRwx-0004bF-5w; Thu, 07 Apr 2022 13:13:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300789.513149; Thu, 07 Apr 2022 13:13:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncRwx-0004b8-2x; Thu, 07 Apr 2022 13:13:23 +0000
Received: by outflank-mailman (input) for mailman id 300789;
 Thu, 07 Apr 2022 13:13:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncRwv-0004ay-EM; Thu, 07 Apr 2022 13:13:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncRwv-0008Dh-CQ; Thu, 07 Apr 2022 13:13:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncRwv-0002AJ-2z; Thu, 07 Apr 2022 13:13:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncRwv-00042Z-2U; Thu, 07 Apr 2022 13:13:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mf7bQiV8EIoh85/3XGgwZWRJ3d19EJF/gITIXUToy44=; b=sN35zADfFBe3OBp05wC4Q+Ld3D
	N8No5a83+WdyheH0c5W8Pu3/h1xmdeuC2FjTPh+scvvlIloccpOLL01IihsTqE3WpxAllfX9soN3/
	v57gKyiVWN3c6vb5s8NBpi+R5A2bn2vzdg67VV8JfMdU0JvvfcLiCcPpPUTBPRRZ48uM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169209-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169209: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=a298a84478053872ed9da660a75f182ce81b8ddc
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 13:13:21 +0000

flight 169209 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169209/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 a298a84478053872ed9da660a75f182ce81b8ddc
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   38 days
Failing since        168258  2022-03-01 01:55:31 Z   37 days  284 attempts
Testing same since   169173  2022-04-05 05:13:00 Z    2 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4610 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 13:24:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 13:24:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300797.513159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncS75-0006Mj-5T; Thu, 07 Apr 2022 13:23:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300797.513159; Thu, 07 Apr 2022 13:23:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncS75-0006Mc-2H; Thu, 07 Apr 2022 13:23:51 +0000
Received: by outflank-mailman (input) for mailman id 300797;
 Thu, 07 Apr 2022 13:23:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uyv1=UR=suse.com=mhocko@srs-se1.protection.inumbo.net>)
 id 1ncS73-0006MU-OE
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 13:23:49 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f08cc905-b675-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 15:23:40 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id 134C21F85A;
 Thu,  7 Apr 2022 13:23:48 +0000 (UTC)
Received: from suse.cz (unknown [10.100.201.86])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id D2BE9A3B9C;
 Thu,  7 Apr 2022 13:23:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f08cc905-b675-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649337828; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6kx9n4k18EeAoUx1f5fom/mHD05wbK+BXq9P0qrUE0s=;
	b=CBAIxuyfQWJKGRJKMV4AiNEBZCl0yC6CKa9+31uIG8KGlgrDvozgdg9H1WZA0Oo1Qzsgle
	64ixAZFYMZlAuBacbmCFiMKqUs10OgYbsUUINBsozhl49g8dtsH3VltZo2pH0YoMF6NF4N
	pxfOnpdtge2avIwq0hr1p2OkqbUYSgY=
Date: Thu, 7 Apr 2022 15:23:44 +0200
From: Michal Hocko <mhocko@suse.com>
To: David Hildenbrand <david@redhat.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <Yk7l4CEpQFoPnYB/@dhcp22.suse.cz>
References: <20220407093221.1090-1-jgross@suse.com>
 <Yk6+QBacbb6oI8lW@dhcp22.suse.cz>
 <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
 <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz>
 <5e97a7f5-1fc9-d0b4-006e-6894d5653c06@suse.com>
 <Yk7NqTlw7lmFzpKb@dhcp22.suse.cz>
 <770d8283-4315-3d83-4f8b-723308fffe5c@redhat.com>
 <Yk7TMKBAkuSVZRLT@dhcp22.suse.cz>
 <ca22625e-b72c-059a-9242-f10b291be4fe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ca22625e-b72c-059a-9242-f10b291be4fe@redhat.com>

On Thu 07-04-22 14:12:38, David Hildenbrand wrote:
> On 07.04.22 14:04, Michal Hocko wrote:
> > On Thu 07-04-22 13:58:44, David Hildenbrand wrote:
> > [...]
> >>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> >>> index 3589febc6d31..130a2feceddc 100644
> >>> --- a/mm/page_alloc.c
> >>> +++ b/mm/page_alloc.c
> >>> @@ -6112,10 +6112,8 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
> >>>  	do {
> >>>  		zone_type--;
> >>>  		zone = pgdat->node_zones + zone_type;
> >>> -		if (managed_zone(zone)) {
> >>> -			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
> >>> -			check_highest_zone(zone_type);
> >>> -		}
> >>> +		zoneref_set_zone(zone, &zonerefs[nr_zones++]);
> >>> +		check_highest_zone(zone_type);
> >>>  	} while (zone_type);
> >>>  
> >>>  	return nr_zones;
> >>
> >> I don't think having !populated zones in the zonelist is a particularly
> >> good idea. Populated vs !populated changes only during page
> >> onlininge/offlining.
> >>
> >> If I'm not wrong, with your patch we'd even include ZONE_DEVICE here ...
> > 
> > What kind of problem that would cause? The allocator wouldn't see any
> > pages at all so it would fallback to the next one. Maybe kswapd would
> > need some tweak to have a bail out condition but as mentioned in the
> > thread already. !populated or !managed for that matter are not all that
> > much different from completely depleted zones. The fact that we are
> > making that distinction has led to some bugs and I suspect it makes the
> > code more complex without a very good reason.
> 
> I assume performance problems. Assume you have an ordinary system with
> multiple NUMA nodes and no MOVABLE memory. Most nodes will only have
> ZONE_NORMAL. Yet, you'd include ZONE_DMA* and ZONE_MOVABLE that will
> always remain empty to be traversed on each and every allocation
> fallback. Of course, we could measure, but IMHO at least *that* part of
> memory onlining/offlining is not the complicated part :D

You've got a good point here. I guess there will be usecases that really
benefit from every single CPU cycle spared in the allocator hot path
which really depends on the zonelists traversing.

I have very briefly had a look at our remaining usage of managed_zone()
and there are not that many left. We have 2 in page_alloc.c via
has_managed_dma(). I guess we could drop that one and use __GFP_NOWARN
in dma_atomic_pool_init but this is nothing really earth shattering.
The remaining occurances are in vmscan.c:
	- should_continue_reclaim, pgdat_balanced - required because
	  they iterate all zones withing the zoneindex and need to
	  decide whether they are balanced or not. We can make empty
	  zones special case and make them always balanced
	- kswapd_shrink_node - required because we would be increasing
	  reclaim target for empty zones
	- update_reclaim_active - required because we do not want to
	  alter zone state if it is not a subject of the reclaim which
	  empty zones are not by definition.
	- balance_pgdat - first check is likely a microoptimization,
	  reclaim_idx is needed to have a populated zone there
	- wakeup_kswapd - I dunno
	- shrink_node, allow_direct_reclaim, lruvec_lru_size - microptimizations
	- pgdat_watermark_boosted - microptimizations I suspect as empty
	  zone shouldn't ever get watermark_boost
	- pgdat_balanced - functionally dd

So we can get rid of quite some but we will still need some of them.
-- 
Michal Hocko
SUSE Labs


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 13:27:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 13:27:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300801.513170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSAV-00071a-M3; Thu, 07 Apr 2022 13:27:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300801.513170; Thu, 07 Apr 2022 13:27:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSAV-00071T-Iz; Thu, 07 Apr 2022 13:27:23 +0000
Received: by outflank-mailman (input) for mailman id 300801;
 Thu, 07 Apr 2022 13:27:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncSAT-00071L-UF
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 13:27:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 739a1262-b676-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 15:27:20 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-CHl0xR3IPmuFYhT2BynHxg-1; Thu, 07 Apr 2022 15:27:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB6321.eurprd04.prod.outlook.com (2603:10a6:208:143::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 13:27:17 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 13:27:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 739a1262-b676-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649338040;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=BQOVcAGYC8ddiE2/MCQ8tM4DG8UY9B3n/ZS2T6mggZk=;
	b=b1kg0AmOV3JxpmQtAZdgM8eNGCDRxlD8GdA/xNFfqhHJD/koz82MjZVBf5g8ZAh5cuW+eP
	Ta0zoYAx9CiE/XEucvc/XGc14e4B8VYmrlDZ48y3rCfx0YDnVkLzlNUZTnjMKNHvHE23cE
	YDT82M5yjo2sdjxhBQPKTIVPy6Bi6UI=
X-MC-Unique: CHl0xR3IPmuFYhT2BynHxg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MVkMqapOCKKFj63UAk8SxUcqXarXyPm3/0vgizDxwoufv9Hp1bvRDPk94WadBLiBuVcIJZdsxwM7Ua67kuhdQdvMUiW4ESIQ6iN4AtegLqE/mx73tomjCpuVUfxF+U0lIBK4M1HqttUBnGqvzSz5EF5ODbgTrD+c25gsdC4DegoJ+TtlTX/tUUetXOArE8LP1v9P1jjgErnTFvbqlhQHACLenxHuqEsX7tP2E+BNsyjteRiEYOSa64/YeU50HYGffJEY4v+bUKqKcM9f59ttSj/Y9oZOLxe5GA1CDLvK2TeQfLq2988bDgH3WhKEQv5x5T2lnnltWTrE1D54+B+DUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BQOVcAGYC8ddiE2/MCQ8tM4DG8UY9B3n/ZS2T6mggZk=;
 b=WGgZwX9y05PnDclLpQ7T9/dJP5/OWOPtHGIeEuj4Q8CQGZJJUZ+NEVOZUn1zl2xu7S15GtZnWyeFbpvgtTHEjfldRQ2U6pslWdqqBNFQoorGBMN1BLEPJFOvX+HZ4mIPs1V2WAqmv87Sdl6dfiC0DcUMJz1VvKMNMBF8WwFSoB02kc/Uu8S6BPn5obGZjgGQG1Z/9qAf9QFSZn9o7fZ84C7BMp0M0HAk3vh2q1U/Jiil1Nh2vEAVwJGXwyQdGCHHQrEFAMyVVQ3JR0CIFCDuQY3CSqdbGhAw1jTRTItPVZEFgPpxPc1LvFJy4l9P2PPjcQDCJyXPFMb3yH9yOTCzeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
Date: Thu, 7 Apr 2022 15:27:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>, Olaf Hering <ohering@suse.de>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86: make "dom0_nodes=" work with credit2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::18)
 To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb084767-a481-492f-eb9d-08da189a55d8
X-MS-TrafficTypeDiagnostic: AM0PR04MB6321:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6321BB40A891C0198358BE79B3E69@AM0PR04MB6321.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iuRtJnqYNY6jQX0WBDRlvIFQuJXcAc/O44Bk96r7M16sjTA5CVAu6Q2yhogtQNQD23XyVALUbxCgl0NQ+AkeN2cNb5gqY15Ahjmo53VUnYe6aoZlbOHbQDnb0XQahV5GyMHc4bXBngIx3SXHXyD/5r+9SUsMCbUAUdU3uzWdm7v7v9thG1JsZUlOxacQLR4B59BA/uqSMJSLrTTPRhO6ohian0M79APP/zH5mM4eW9MMHsgtYayVX2uev56f51AaxrBas+445UgHoLN/0yfPVxuHHGKjKOfON7AF8cq6hra6VYUohob4AJLYrh2BkurFyVZSE1d8jafEyBsmoZ75wmKa3u3TE+9WAEXB7DcGRV0nVOJZqBiKI4/lfIJiBQ6BK4y5FGuMCIPShkZSOUUDN1i5QSIaxptKeOunxYM6P2WykkTzugRQDrfvNybYfqdQHSWn1ICyhovZ/+iVQ7NZGe7pN/XOsgL6UbuDlf2XjTVTxwocJOFoH+2vzQesz2L5+SkfY8jh+Z8iG3/nTzkiwVzIZHtnv/nEcFnho73i5pRm4ec4lbvzVNkBGucZujlcpZ35NaZ8Y32o+0T2Ze2vF3pR6HAZZPtPRYAesekjWJsDL08bmWWE/oDLfFlCup6g5H+yKrBqA4oF2KO9gCkOkoddx8r2FdAwhKtL339Mlus6ZOBXogjlHjxuRw9CfINI8HmtTT+Z5AXQDoTpeBRSYhJl4qP36gVPtm3t5f8WPPI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(508600001)(8676002)(31686004)(36756003)(8936002)(6506007)(6486002)(38100700002)(66946007)(66476007)(66556008)(2616005)(6666004)(31696002)(26005)(6512007)(86362001)(54906003)(186003)(316002)(5660300002)(83380400001)(6916009)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a2tPdTN4Z0lTdlE4Z0xaSG5kWHVnOUpzaWVRK2xNZUkvbkg3Zk9EMlBuT0JV?=
 =?utf-8?B?bFB2dWxjVjhCNFRKdUIxOW1DdVgxKzBJbnNnd3FxNUVFL1pvZng1ZlB2MVJN?=
 =?utf-8?B?YVk5bFpaYkNIb20wSzZrVEMyWUMrck5FNlFPQTlzSHc1MkcxZUFySW9RYm9B?=
 =?utf-8?B?dnNPYlNXOFYyR0VoaDZiaGk2NUpEblB6TVdrK2I2cVUza0g0QVJPcHFYZmtq?=
 =?utf-8?B?VTRrWmVIRVFiZWw4b3dMSVNJRGhkUmc0bFJMbEdyTTdtb1ZBNlRvcUlUdW5q?=
 =?utf-8?B?ZVg5U09oSnVjR2tiQU8vZzdqbk5FRFZMQ2xSbnBBa1dJemMvTCtsZTRnUGRN?=
 =?utf-8?B?T1BRVTE4U1pEZVdoUzlmUXYydFNxNVJ0SmFCcEVXdTcwVEQwanpoZEl3MTJT?=
 =?utf-8?B?SXczZmEzeGVhY1VjN1h3Qm9oc0Z6YlBiNnBCc25CVFV4S0hFNXV2dmp1NXU5?=
 =?utf-8?B?eDJvRTNXcmdrdUVCd0RORVVzRUJPeE9SWGNvWktNQjZ3ZkhPQ0lzMEFvcFFH?=
 =?utf-8?B?dmtnQUNMWGJVRXpwNDhYNTZzV1Q2d1gxYnpQeXFOb01BNlE2eUg0L0o5aGlP?=
 =?utf-8?B?UkE0Q2dZNTBnTHYwcXo1ekw4bGZIK2VIVEtzYlhZOSt4MnF1YkcxTkxPQkgr?=
 =?utf-8?B?WXdIT04wbVgxSnV5ajBMMTQ5VURBT1JWSHg3MHJRL0cybnIzOGlHbGFkaC9T?=
 =?utf-8?B?WVVhY3VKcVZCdk5HOTNQQW41eS9EL3JvMHdOWk9GdnFqY2VvVGdGUERmSFBB?=
 =?utf-8?B?Vnd3N1dhT0lSUGQydVE5ZDdkL0FQeXl6bDFEUmFGYjlkbjgwV1h0ZXJ0Y0NR?=
 =?utf-8?B?aVlrakkxNUFOM1ZhYmhWQ1V2ZmY3MmlGWUtkQ1MrYTFWTk5aOEk5QVVuaHN1?=
 =?utf-8?B?QVJmQTlVR284R0tTc0xoejNZenNPL0VsSkMrckJmamMxZC9UYjczcFM1LzNF?=
 =?utf-8?B?ZkF0RE1TcThVK3Q4ZmNrTHBIZUFvcldVcmdubnZCQXpuSXpNNUFlT1haSC9a?=
 =?utf-8?B?UDRLWWV6bnFYN21jRUUyY3U2YWRMeG5IdFV1M2NLRFRERXhqVDh0VEo0dXpO?=
 =?utf-8?B?NERkTmh6a1U1c1NEdElBeEgxOXJZRjZjWGQzUCtyZHlGUjdhQVlQS3ZuUWFs?=
 =?utf-8?B?YmVnMkp6Y1lkZVE3MVl2aFF2U2hBaWJVMUtmdVJQTU5hdmNYVVJNb3VoOFJL?=
 =?utf-8?B?L0pkOW83eEg4QXVnUkc0am5SZm9HYjQwQ09iZlp6MEwrNXRtMGg0S3VZeTA3?=
 =?utf-8?B?VlFSNFAwc0QvT1N2OVdHK0drdDFwOG11VlY1RVNzNC9DQ3ZsZlVwaEN6dHdu?=
 =?utf-8?B?MDJDbDNZQkVROHFYcnl6TWNMWDZrNlpiQTlTSHlUZjVWL0FqdnhEM0NOQUJY?=
 =?utf-8?B?OWdrM2FNS0pSMXNOMjR6bUgyV3ZxV2ZkZEVWR2MwMmwrSzA5UmFKbTg1ZVNp?=
 =?utf-8?B?MDhwMEhDNTNiQS8zMFAxeXBxYVhPbVZyd0E3M0ZJVlZSM3V4ckJLaGhCQ3pL?=
 =?utf-8?B?cGo0OERwM2dONmt0dDJNQ0lvU0V5NVo4dHVxYUFBRS9LejgvM3ZydWJULzBz?=
 =?utf-8?B?cVRPUlFOa092Vkp1Q0laZ09kWFlJYk01K2c2cVBUbnhOUlNoT2tlVndJb1d3?=
 =?utf-8?B?VTQvWUNCNlBDMXRIcGNMWUJGQUZTbFVacWpHZERiWGRGcWI4UHFlSjlKWGpR?=
 =?utf-8?B?ck94cFVLRVhTaGIxWUJSZ05LaHVob2U2RThaVWhCcXUwbE14dzV2WnVKbW0w?=
 =?utf-8?B?bHMrMVdONXpnLzhzalJMNGYwTnBwV3dSemJjSHhwS01PdEgrZjgwYjU4cGhW?=
 =?utf-8?B?TFR3QnROcytncWU2Q1ZnNVpQRmM5NDRweVhIck5vMTVBd1loYThXakFmTlYx?=
 =?utf-8?B?Wk1DandwcDArL0tkWk9CbEt0ZXh0UHgrU2VrVWN1VTNpQmZlVlRSeWY4dGZP?=
 =?utf-8?B?U1hveUdua3llVVkvQmFEUGN0QUM3VVdYQmVJZGdrWEZxWDU1Q0pGVlVhcUoz?=
 =?utf-8?B?TXVPTitlN2M3Y21PWFB5aGUxMXdITTZna2U0M2xOdk5US01FUnJqZjZHUmc0?=
 =?utf-8?B?SVNQVWhWdWt0a0laekkxdGU2QlBzSDRGQUovdUJGK2RONVZKSVFwWWF6SERH?=
 =?utf-8?B?L0ZPOW0zbEpSUjFYdWxLclB3a1NtOEs1YzFYTnhETExCeDJ4ZFVGYnJxeWsy?=
 =?utf-8?B?ckJWdGgzK2xvejFGZ2FzMDUyVHRpT0N6bW8zdlN0TThvd2RDRlZ5TG1oQUJm?=
 =?utf-8?B?YmFydnNEU2NsUTNDemN3TlgwU1k4b2lYa0FTY2hWcHZVWUhFdWt5WmpFOEFT?=
 =?utf-8?B?M25pNFhGN2U1OVJHSmdaQWpvNDJmU3pxYlVnSjY1enBzZFR4RjJXUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb084767-a481-492f-eb9d-08da189a55d8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 13:27:17.1905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G0AJPc4/3UqgLNHiUKKerSeJZcay9F9sogIXyS29Nec0lfrzO9uAr2BSptPnie43YXKefzNu7Szoz6S6FZgFBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6321

Apart from setting the affinities, vCPU-s / units also need to be
migrated off of CPUs which aren't part of the affinity. Otherwise, for a
reason I haven't been able to determine, credit2 won't actually schedule
them, resulting in the Dom0 boot process to hang (either right away or
when bringing up "secondary" vCPU-s).

Fixes: dafd936ddd ("Make credit2 the default scheduler")
Reported-by: Olaf Hering <ohering@suse.de>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
The Fixes: tag isn't very precise - it's rather the commit exposing the
issue by default. I haven't been able to identify the actual commit
which did introduce the problem; it may well be that it has always been
there since the introduction of credit2.

Credit2 moving the vCPU-s off of their initially assigned ones right
away of course renders sched_select_initial_cpu()'s use of cpu_cycle()
pretty useless. But I guess that's still useful for other schedulers.
I wonder though whether sched_init_vcpu() shouldn't use the CPU map
calculated by sched_select_initial_cpu() for its call to
sched_set_affinity() in the non-pinned case, rather than setting "all".
(I guess doing so might mask the issue at hand, but I think the change
here would still be applicable at least from an abstract pov.)

--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3403,9 +3403,15 @@ void __init sched_setup_dom0_vcpus(struc
     {
         for_each_sched_unit ( d, unit )
         {
+            spinlock_t *lock = unit_schedule_lock_irq(unit);
+
             if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed )
                 sched_set_affinity(unit, &dom0_cpus, NULL);
             sched_set_affinity(unit, NULL, &dom0_cpus);
+
+            sched_unit_migrate_start(unit);
+            unit_schedule_unlock_irq(lock, unit);
+            sched_unit_migrate_finish(unit);
         }
     }
 



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 13:52:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 13:52:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300806.513182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSYE-0002ab-J2; Thu, 07 Apr 2022 13:51:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300806.513182; Thu, 07 Apr 2022 13:51:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSYE-0002aU-Ft; Thu, 07 Apr 2022 13:51:54 +0000
Received: by outflank-mailman (input) for mailman id 300806;
 Thu, 07 Apr 2022 13:51:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncSYD-0002aK-Ld; Thu, 07 Apr 2022 13:51:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncSYD-0000Oe-J1; Thu, 07 Apr 2022 13:51:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncSYD-0004AP-7f; Thu, 07 Apr 2022 13:51:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncSYD-0005KT-6z; Thu, 07 Apr 2022 13:51:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bVinWr0jic7HupGcx1Fx1LNcWs88TDH4myKrunn9gqg=; b=tEh/pg87yxm4wqBN8kDKOr2j+p
	2ItcUi54/bdyjhq7HU3KOaHg3mKGyps2H0WObZGx2XPNfJxeG5ZkJ6DB459dvKoH40TpF2L4qelHU
	6A3Lpw0iQDJtM1dfC9b9idiKRiZ4wdrF13yvsa4jkmBnLruZ+pY3cPyo5AbOI3GiAWSU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169203-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169203: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-multivcpu:debian-fixup:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3e732ebf7316ac83e8562db7e64cc68aec390a18
X-Osstest-Versions-That:
    linux=3123109284176b1532874591f7c81f3837bbdc17
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 13:51:53 +0000

flight 169203 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169203/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 169174

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd      13 guest-start      fail in 169188 pass in 169203
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 169188
 test-armhf-armhf-xl-multivcpu 13 debian-fixup              fail pass in 169188

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 169188 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 169188 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169174
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169174
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169174
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169174
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3e732ebf7316ac83e8562db7e64cc68aec390a18
baseline version:
 linux                3123109284176b1532874591f7c81f3837bbdc17

Last test of basis   169174  2022-04-05 08:27:06 Z    2 days
Testing same since   169188  2022-04-05 21:41:40 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Borislav Petkov <bp@suse.de>
  Darrick J. Wong <djwong@kernel.org>
  David Sterba <dsterba@suse.com>
  Eli Cohen <elic@nvidia.com>
  Ethan Lien <ethanlien@synology.com>
  Jason Wang <jasowang@redhat.com>
  Johannes Thumshirn <johannes.thumshirn@wdc.com>
  Josef Bacik <josef@toxicpanda.com>
  Kaiwen Hu <kevinhu@synology.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michael S. Tsirkin <mst@redhat.com>
  Neelima Krishnan <neelima.krishnan@intel.com>
  Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
  Qu Wenruo <wqu@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 583 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 13:54:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 13:54:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300815.513192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSaX-0003FD-58; Thu, 07 Apr 2022 13:54:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300815.513192; Thu, 07 Apr 2022 13:54:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSaX-0003F6-2C; Thu, 07 Apr 2022 13:54:17 +0000
Received: by outflank-mailman (input) for mailman id 300815;
 Thu, 07 Apr 2022 13:54:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uF1Z=UR=chiark.greenend.org.uk=ijackson@srs-se1.protection.inumbo.net>)
 id 1ncSaW-0003F0-6k
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 13:54:16 +0000
Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk
 [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 30af1f4e-b67a-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 15:54:07 +0200 (CEST)
Received: by chiark.greenend.org.uk (Debian Exim 4.89 #1) with local
 (return-path ijackson@chiark.greenend.org.uk)
 id 1ncSaT-0003pM-L2; Thu, 07 Apr 2022 14:54:13 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30af1f4e-b67a-11ec-8fbc-03012f2f19d4
From: Ian Jackson <ijackson@chiark.greenend.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25166.60677.416016.20030@chiark.greenend.org.uk>
Date: Thu, 7 Apr 2022 14:54:13 +0100
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] osstest: stop anacron service
In-Reply-To: <20220407095104.39545-1-roger.pau@citrix.com>
References: <20220407095104.39545-1-roger.pau@citrix.com>
X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu)

Roger Pau Monne writes ("[PATCH v2] osstest: stop anacron service"):
> Just disabling cron in rc.d is not enough. There's also anacron which
> will get invoked during startup, and since apt-compat has a delay of
> up to 30min it can be picked up by the leak detector if the test
> finishes fast enough:

Well done for tracking that down.

Acked-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 13:58:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 13:58:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300819.513204 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSeo-0004B3-Lu; Thu, 07 Apr 2022 13:58:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300819.513204; Thu, 07 Apr 2022 13:58:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSeo-0004Aw-IV; Thu, 07 Apr 2022 13:58:42 +0000
Received: by outflank-mailman (input) for mailman id 300819;
 Thu, 07 Apr 2022 13:58:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RQZM=UR=bounce.vates.fr=bounce-md_30504962.624eee0d.v1-72f657e10429476f8c23490f1f914f4e@srs-se1.protection.inumbo.net>)
 id 1ncSen-0004Aq-4g
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 13:58:41 +0000
Received: from mail137-2.atl71.mandrillapp.com
 (mail137-2.atl71.mandrillapp.com [198.2.137.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d2f3a828-b67a-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 15:58:39 +0200 (CEST)
Received: from pmta07.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1])
 by mail137-2.atl71.mandrillapp.com (Mailchimp) with ESMTP id 4KZ2zK6c3VzQXg2vP
 for <xen-devel@lists.xenproject.org>; Thu,  7 Apr 2022 13:58:37 +0000 (GMT)
Received: from [37.26.189.201] by mandrillapp.com id
 72f657e10429476f8c23490f1f914f4e; Thu, 07 Apr 2022 13:58:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2f3a828-b67a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr;
	s=mandrill; t=1649339917; x=1649642317; i=olivier.lambert@vates.fr;
	bh=0qGw+5B1itrez9pdJTpf2t2vX4siPSzso7d+oZx7ROQ=;
	h=From:Subject:In-Reply-To:References:Message-Id:To:Cc:Feedback-ID:
	 Date:MIME-Version:Content-Type:CC:Date:Subject;
	b=OH+WyqU7VDJLOSiiCrR7B/Lf97xOAFuJohJ2nNoUeJncFpNZ+EHzRtnqyLGDYlx8G
	 RYrgJvohNajjutaHJs0FPduKPhhpFxjJ0hhYKQlaV2r/1alXaATu3kAv/Gq055qMRg
	 LXu56MsiJzw2S2Rgr82sLKR4W6v8IuTT0Z5LA7Tc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; 
 i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1649339917; h=From : 
 Subject : In-Reply-To : References : Message-Id : To : Cc : Date : 
 MIME-Version : Content-Type : From : Subject : Date : X-Mandrill-User : 
 List-Unsubscribe; bh=0qGw+5B1itrez9pdJTpf2t2vX4siPSzso7d+oZx7ROQ=; 
 b=e9gR/U4Y6mee+vobY880whWh0kpIQ1P6Yxbr4R6ZHqdnXWrp9zXuRs52T5yiO3ZWgxeQM/
 zWB9JR18NZlhxUR3UzmLL0p5g9NKppaI6UQdijyedXiCVTgBlW6kYITQfGr0DsIS5/AK2F8j
 ZclkOgaET8DjRwMhl8sPg91nRBvKg=
From: Olivier Lambert <olivier.lambert@vates.fr>
Subject: Re: Design meeting for AMD SEV-SNP project
X-Bm-Draft-Info: {"type":"REPLY-ALL","messageInternalId":705982,"folderUid":"182eb7d2-73cf-407b-a01a-cf4dc491b5c2"}
X-Bm-Draft-Refresh-Date: 1649339914771
X-Bm-Internal-Id: 51E2DD5C-2A80-4022-B0C6-3DE883716B7A#bluemind-4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2:709223
X-Bm-Previous-Body: ae949cd25f504ebc51d0c8284317f78043e1c93f
X-Bm-Disclaimer: Yes
X-Bm-Milter-Handled: ccd00a1f-1643-428b-8802-f28a7c8bc680
X-Bm-Transport-Timestamp: 1649339915673
In-Reply-To: <l1miow10.1tgmtwcqqwtmo@vates.fr>
References: <l1miow10.1tgmtwcqqwtmo@vates.fr>
Message-Id: <l1p23f22.dr91zwnf4q2o@vates.fr>
To: xen-devel@lists.xenproject.org
Cc: Andrei Semenov <andrei.semenov@vates.fr>, roger.pau@citrix.com, george.dunlap@citrix.com, dpsmith@apertussolutions.com, julien@xen.org, bertrand.marquis@arm.com, Marc Ungeschikts <marc.ungeschikts@vates.fr>
X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com
X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.72f657e10429476f8c23490f1f914f4e
X-Mandrill-User: md_30504962
Feedback-ID: 30504962:30504962.20220407:md
Date: Thu, 07 Apr 2022 13:58:37 +0000
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="_av-ySF4ElciNHmprsBUBpcLkw"

--_av-ySF4ElciNHmprsBUBpcLkw
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


I will let the Doodle opened until the end of the week to let you know quickly here which day was selected.

Regarding the meeting location: https://meet.vates.fr/sev (Jitsi powered)



So we got a clear winner: everyone selected this Monday, the 11th at 3PM UTC (don't forget summer time on your end, London is UTC+1 and Paris UTC+2). I suggest to book this time slot in your calendars :) Meeting room doesn't change: https://meet.vates.fr/sev


Right now, we are 8 participants in total. The room will be open without any password. See you on Monday!



Regards,


Olivier Lambert | Vates CEO
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com

--_av-ySF4ElciNHmprsBUBpcLkw
Content-Type: multipart/related; boundary="_av-ca7PXqIVBDKpPbMG4UFDCw"

--_av-ca7PXqIVBDKpPbMG4UFDCw
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
 <head></head>
 <body>
  <div id="bm-composer-content-wrapper">
   <p></p>
   <blockquote style="margin-left: 1rem; padding-left: 1rem; border-left: 2px solid black;">
    <p style="margin-bottom: 0; margin-top: 0;">I will let the Doodle opened until the end of the week to let you know quickly here which day was selected.</p>
    <p style="margin-bottom: 0; margin-top: 0;"><br>Regarding the meeting location: https://meet.vates.fr/sev (Jitsi powered)</p>
    <p style="margin-bottom: 0; margin-top: 0;"><br></p>
    <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   </blockquote>
   <p style="margin-bottom: 0; margin-top: 0;">So we got a clear winner: everyone selected this Monday, the 11th at 3PM UTC (don't forget summer time on your end, London is UTC+1 and Paris UTC+2). I suggest to book this time slot in your calendars :) Meeting room doesn't change: https://meet.vates.fr/sev</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Right now, we are 8 participants in total. The room will be open without any password. See you on Monday!</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Regards,</p>
   <style></style>
  </div>
  <div class="x-disclaimer995950824">
   <div>
     &nbsp;
   </div>
   <div>
     &nbsp;
   </div>
   <div>
    <div>
     <br> 
     <table>
      <tbody>
       <tr>
        <td style="font-size: 10pt;">&nbsp;</td>
        <td style="font-size: 10pt; padding-left: 20px; border-left-color: #b42626; border-left-style: solid; border-left-width: 1px;">
         <div> <strong> <span>Olivier Lambert</span> | Vates CEO</strong>
          <br><strong>XCP-ng &amp; Xen Orchestra - </strong>Vates solutions
         </div>
         <div> <strong>w:</strong>&nbsp;vates.fr&nbsp;| xcp-ng.org | xen-orchestra.com
         </div>
         <div>
          <img style="width: 187px;" src="cid:x-disclaimer995950824-1649339915673.png@bm-disclaimer">
         </div> </td>
       </tr>
      </tbody>
     </table>
    </div>
   </div>
  </div>
 <img src="https://mandrillapp.com/track/open.php?u=30504962&id=72f657e10429476f8c23490f1f914f4e" height="1" width="1"></body>
</html>

--_av-ca7PXqIVBDKpPbMG4UFDCw
Content-Type: image/png
Content-Transfer-Encoding: base64
Content-Id: <x-disclaimer995950824-1649339915673.png@bm-disclaimer>
Content-Disposition: inline

/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB
AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/
2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB
AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA
HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF
BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK
FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1
dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG
x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB
AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC
AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom
JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE
hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU
1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA
CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo
AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR
8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0
nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7
9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq
rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8
F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+
Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5
+GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS
b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL
iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m
J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/
4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B
axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8
Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W
0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+
7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4
S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM
fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN
iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+
JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL
QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3
aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8
M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm
sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e
Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/
j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/
hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f
Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL
hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8
HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI
/wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt
y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r
7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3
hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia
2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT
jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW
KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x
D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9
/p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP
DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx
XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT
6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A
BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F
tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt
X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI
re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb
9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv
F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ
pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88
KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf
izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM
77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8
e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7
i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4
ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4
P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD
4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4
ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01
8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet
R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq
/wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n
dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M
vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8
SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y
+NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67
SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW
krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI
Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n
/Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP
A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX
uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d
yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa
fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm
8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt
Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D
fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN
PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD
vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc
oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf
EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg
uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS
0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K
U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if
xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60
qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A
wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj
BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z
B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z
3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5
Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz
AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx
7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8
vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44
+IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v
+/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb
AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3
uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq
XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx
fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0
Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr
W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340
fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4
Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn
/BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G
o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38
KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/
jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2
mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr
HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm
3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh
h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U
YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD
adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun
RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF
43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt
4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7
G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH
ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP
2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju
FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94
uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr
IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+
J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21
OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3
/g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0
r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ
D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox
8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w
dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T
vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A
g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe
0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v
14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S
8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+
BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/
AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/
sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X
WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G
n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T
wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4
M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW
iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy
/wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr
S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd
+wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv
CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E
T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i
Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e
aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR
8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg
v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp
YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/
BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT
NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b
jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk
0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf
oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua
VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ
88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS
tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr
5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6
Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6
RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx
mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC
EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/
Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F
PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT
w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc
PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7
sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU
qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD
GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU
AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF
0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF
Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+
GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo
0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv
tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740
xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a
eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT
zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n
XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h
ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl
Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4
YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k
P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK
HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez
wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl
0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH
x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd
oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u
0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc
pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i
C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm
qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV
v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u
WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2
fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x
A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT
i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5
rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD
xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP
X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l
/q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6
WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL
EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw
fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB
p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin
JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU
62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF
AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7
694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY
vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k
Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv
jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH
XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el
OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/
BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L
+E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt
L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW
8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw
2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+
HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G
0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad
pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD
e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If
GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP
4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh
qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4
NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2
/wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0
1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI
8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+
Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy
3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy
2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8
RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW
SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp
ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv
FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv
ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz
B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe
NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74
meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r
Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR
oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl
kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0
nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ
JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO
nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI
pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT
lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K
Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un
jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q
jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J
wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV
cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1
W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs
8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY
PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx
mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay
NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i
gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N
ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX
rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0
H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p
1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj
MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy
OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx
/tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM
n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/
2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn
LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH
/wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd
5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun
XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ
uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9
6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf
C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c
yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A
qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM
SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr
8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV
lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL
/wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W
G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz
ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b
+GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w
9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B
ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k
mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS
qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf
XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815
60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr
xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl
nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft
RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3
s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE
jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690
H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM
NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj
7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs
ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1
ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4
nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG
4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD
3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A
HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd
anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ
hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj
TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm
IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS
P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh
6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q
Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8
T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj
G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw
mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr
xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v
VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC
61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+
ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR
OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5
TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf
8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v
wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh
Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM
2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44
YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3
KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e
PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx
Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf
gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg
AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu
PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+
WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G
/CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr
CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y
RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze
Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+
TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt
Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+
WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP
ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If
iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng
sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/
B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1
JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV
8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P
4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9
u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ
8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u
eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1
K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO
eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB
ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK
FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL
8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj
5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg
oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0
FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7
f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX
PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km
22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/
sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL
L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND
COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ
qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+
wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp
6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm
ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy
n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj
Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB
Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/
AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7
fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u
1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu
XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR
1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0
n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd
8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS
lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV
ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU
j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O
I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw
0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN
3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k
z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1
tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY
B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj
KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s
XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN
bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7
rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w
R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr
9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl
UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG
NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm
FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc
/tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy
zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+
ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U
3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl
gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE
ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt
WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi
Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9
bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl
ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR
pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh
2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z
NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo
3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp
utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj
Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB
ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST
gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N
PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0
7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0
cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa
jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA
CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV
5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV
xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq
5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx
A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl
B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/
FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I
7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC
m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/
4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli
x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP
tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8
PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K
3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6
nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs
1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA
FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej
7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm
eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+
D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi
lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf
Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs
6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z
1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP
2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r
T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp
q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M
XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3
HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7
u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT
ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP
rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf
i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh
a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O
pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp
08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj
XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG
MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q
ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2
R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+
P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i
xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax
vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF
Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk
Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP
82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb
LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA
CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo
AKACgD//2Q==

--_av-ca7PXqIVBDKpPbMG4UFDCw--

--_av-ySF4ElciNHmprsBUBpcLkw--



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 14:02:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 14:02:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300824.513215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSiP-0005i0-9Z; Thu, 07 Apr 2022 14:02:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300824.513215; Thu, 07 Apr 2022 14:02:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncSiP-0005ht-6V; Thu, 07 Apr 2022 14:02:25 +0000
Received: by outflank-mailman (input) for mailman id 300824;
 Thu, 07 Apr 2022 14:02:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y6u3=UR=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1ncSiN-0005hn-9r
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 14:02:23 +0000
Received: from MTA-07-4.privateemail.com (mta-07-4.privateemail.com
 [68.65.122.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 575af1c8-b67b-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 16:02:21 +0200 (CEST)
Received: from mta-07.privateemail.com (localhost [127.0.0.1])
 by mta-07.privateemail.com (Postfix) with ESMTP id E16AA18000B1
 for <xen-devel@lists.xenproject.org>; Thu,  7 Apr 2022 10:02:19 -0400 (EDT)
Received: from mail-oa1-f47.google.com (unknown [10.20.151.185])
 by mta-07.privateemail.com (Postfix) with ESMTPA id BC37118000AF
 for <xen-devel@lists.xenproject.org>; Thu,  7 Apr 2022 10:02:19 -0400 (EDT)
Received: by mail-oa1-f47.google.com with SMTP id
 586e51a60fabf-de3eda6b5dso6492054fac.0
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 07:02:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 575af1c8-b67b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1649340139;
	bh=SzxOtn/Gb++owqIsHpnYUSap7PATy85nOiTHURn6tdU=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=BxWgUo00QpDTRc8D8ZPWllANon0ErLTAk+fBLjW9iiTsBHj0ze/iIXsWiVCgAGidA
	 wK5tqLa7XU484vc4jDccZLiZNDySmqugh5SYBMM2cROqsXIF6RcMhJ5Qo+1bdEq94c
	 1FC1CgpWT8qau8ZzuLXY0GXtb5nEP9Jo6NC9f2fXjvSLK1i2JoCmPkCuptZMxsyXb7
	 arSfThWaJXUo1fwsax9mclAU73N4CVrJomG6IPRcZA9Hh8XUQjp6BjyL/FJgnshWMj
	 4OHM5cRMTnkPaFcab/GHRZRxWNWoUIcS6SHipS/8SCy7SyB55CpN73YigUTmdDjmwJ
	 qEPa+N2xRiqig==
X-Gm-Message-State: AOAM5304IcJ63HH2dBwl7sNtrk7UaO4j7fa9ek93NZC6b0kiGv7D0Zv/
	1YkRZMKWNiqt6nah1Ta/qWePhMmTwLbuAMIUP58=
X-Google-Smtp-Source: ABdhPJxPq3j73QSJ1DnFSQCmRO9ypvv3D7JPl7N4nRLMQuIoKaU9odjnn/LvGa5RYfjRhUd9uT/To/Jlzlhhi4fid7U=
X-Received: by 2002:a05:6870:ea81:b0:db:3e68:7ae0 with SMTP id
 s1-20020a056870ea8100b000db3e687ae0mr6294794oap.9.1649340139116; Thu, 07 Apr
 2022 07:02:19 -0700 (PDT)
MIME-Version: 1.0
References: <d1a7a48fa2d46c6a6cbf8f93926a8839aaba92e3.1649256753.git.tamas.lengyel@intel.com>
 <73e6b45525e1be753d3e243d42ad632bbc5690b0.1649256753.git.tamas.lengyel@intel.com>
 <9f593bdb-d95a-4705-d24a-f8767d69a09f@suse.com> <CABfawhn=-avd30QieqJ9gWsJMegRYcOV23vGvYeQcaoA-Cu-VQ@mail.gmail.com>
 <425d5e65-cf37-6098-074d-0dc1dadda8e2@suse.com>
In-Reply-To: <425d5e65-cf37-6098-074d-0dc1dadda8e2@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Thu, 7 Apr 2022 10:01:43 -0400
X-Gmail-Original-Message-ID: <CABfawhm4kH9=7anYnnQmAqFZbPbYJGGb2kxHzugp1othcTL38A@mail.gmail.com>
Message-ID: <CABfawhm4kH9=7anYnnQmAqFZbPbYJGGb2kxHzugp1othcTL38A@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] x86/monitor: Add new monitor event to catch all vmexits
To: Jan Beulich <JBeulich@suse.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <JGross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
	Alexandru Isaila <aisaila@bitdefender.com>, Petre Pircalabu <ppircalabu@bitdefender.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, 
	xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Thu, Apr 7, 2022 at 2:01 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 06.04.2022 20:02, Tamas K Lengyel wrote:
> > On Wed, Apr 6, 2022 at 11:14 AM Jan Beulich <jbeulich@suse.com> wrote:
> >> On 06.04.2022 16:58, Tamas K Lengyel wrote:
> >>> --- a/xen/arch/x86/hvm/vmx/vmx.c
> >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> >>> @@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
> >>>          }
> >>>      }
> >>>
> >>> +    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
> >>> +    {
> >>> +        int rc;
> >>> +        __vmread(EXIT_QUALIFICATION, &exit_qualification);
> >>> +
> >>> +        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
> >>> +        if ( rc < 0 )
> >>> +            goto exit_and_crash;
> >>> +        else if ( rc )
> >>> +            return;
> >>> +    }
> >>> +
> >>>      /* XXX: This looks ugly, but we need a mechanism to ensure
> >>>       * any pending vmresume has really happened
> >>>       */
> >>
> >> A few lines down from here failed VM entry is being handled? Wouldn't
> >> you want to place your code after that? And wouldn't you want to avoid
> >> invoking the monitor for e.g. EXIT_REASON_EXTERNAL_INTERRUPT,
> >> EXIT_REASON_MCE_DURING_VMENTRY, and at least the NMI sub-case of
> >> EXIT_REASON_EXCEPTION_NMI?
> >
> > No, the placement is necessary to be where it is to be able to collect
> > information about all vmexits, no matter the root cause. Failed
> > vmentry & mce during vmentry would be interesting exits to see if we
> > can induce during fuzzing from within the guest (indicating some
> > serious state corruption) while the external interrupt and nmi cases
> > are for the most part just ignored and the fuzz-case restarted, but
> > could be still interesting to collect their frequencies. So in effect,
> > we want to avoid Xen hiding any of the events from the monitoring
> > agent by handling it one way or another and just let the agent decide
> > what to do next. We most certainly want to avoid Xen crashing the VM
> > for us.
>
> Okay, I can accept this reasoning. But then don't you need to move
> your code _up_, ahead of an earlier "return" (i.e. immediately after
> IRQ enabling)?

I was considering that but that crash+return condition I don't think
is possible to actually reach. It's on a path when the CPU doesn't
have #VE support and the EPT_POINTER is not found in the altp2m list.
There is no possible way for that condition to occur AFAICT. When no
#VE is available and the guest is allowed to use VMFUNC (ie not
altp2m-external-only mode) it gets emulated and the EPT_POINTER is set
by p2m_switch_vcpu_altp2m_by_id which sanity checks that the idx being
switched to is found in the altp2m list. So the guest can't switch
itself to an invalid EPT_POINTER. When the toolstack switches altp2m
it does the same validation after pausing the domain. Again, no way to
switch to an invalid altp2m. When an altp2m view is getting destroyed
by the toolstack it errors out if there are any vCPUs still using that
view, so no way for the vCPU to be stuck with a stale altp2m view
that's now invalid.

> Also may I ask that you transform your reasoning into
> some form of a code comment?

Sure, I can do that.

Tamas


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 14:27:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 14:27:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300828.513226 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncT6W-0000DI-Ad; Thu, 07 Apr 2022 14:27:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300828.513226; Thu, 07 Apr 2022 14:27:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncT6W-0000DB-71; Thu, 07 Apr 2022 14:27:20 +0000
Received: by outflank-mailman (input) for mailman id 300828;
 Thu, 07 Apr 2022 14:27:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncT6V-0000D5-Qs
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 14:27:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d456945c-b67e-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 16:27:18 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-ssyjTSQUOPS56_r4nY1vwg-1; Thu, 07 Apr 2022 16:27:16 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR04MB3257.eurprd04.prod.outlook.com (2603:10a6:7:17::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 14:27:14 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 14:27:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d456945c-b67e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649341638;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vGzGK1vQdoVKXrrKQ2YHQsvPjrtBajn1TL0F4zIeRI4=;
	b=FRHrDQ0JrBJBto+kCdO9+YmL7hh+uIaSKYDaJn05mAv6txv71tu4qqfG+J00FTU//ERUGi
	rhxUM275Blhp+/KjPMwgTZ6rZDBecMSaQnuWIriYPuyhU9fDcH7qJ5K1084bxExIU8wgMw
	WO95Dk5UbcSuqhYSw+iiT+CwaZ15Slo=
X-MC-Unique: ssyjTSQUOPS56_r4nY1vwg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XoCbh8HcwAybPnOU05Pf9dE/APzkvjuu9JFsD6NbAMDzQdd6G4lDlxgNrlbJWMLJqkObLsOZbYNQr9PHj0Z+sG0v/dpkqONz3V2kxTI1ztYPFEZc4bM+Ln/0Hf0TBoJ+ww2AgisAbgvCxyPgia7SUlHeSs65Bn3oXrHWbSmVDpWO8Abk4JS/DjdxhDeFF07E7hNFxROyHVG6gdE3Mk5D++83mPH0pPfjgoTOimCzOlgspqphaRDFBOCIUk9t5jdNUncjPHF3oWyMFofAYm3em99u8piJk41OwEu6veAtR8nDiR9XK+q5YAo31Y/AjaTCcwMnwMLKtR1AjTBpdGG4QA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vGzGK1vQdoVKXrrKQ2YHQsvPjrtBajn1TL0F4zIeRI4=;
 b=FjAzMIRz/iITky05rIsOk1Mokk3AUxkgW4hck5yvZwhA2TpJiBhO+ReSwh2N77NfElP7fLy6Jq29NImk+HoeDm2j8nHR/lRwSRLBS9OY8MLJhbdDsJVsRbN7IS8Vu/QPQqqiIm1eC/UV/25Wbzna0KVTJ/QjH6/ydcrCtg+0pailCnP3+2WhOEv28atDimUnsn1+3ebtpWt5GZivfjMzJ556aIhgyEFH08zo5bagR2eyx1HebrP9bQ/NEEJlNJp4dt4Y7R1VbgpwV/vXnv3ajftCblyhIs8VN5/2gzuLfoc3dHd5n/UlUFYWXgIlVgWv/ikq67O8Ex1Ac17PiDr5Ug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4206733c-c4be-2e8d-7ea2-d145d3599e48@suse.com>
Date: Thu, 7 Apr 2022 16:27:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] x86/cpuid: Clobber CPUID leaves 0x800000{1d..20}
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220407010121.11301-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220407010121.11301-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0055.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfe43b6d-6dda-4ba9-3fe8-08da18a2b5ab
X-MS-TrafficTypeDiagnostic: HE1PR04MB3257:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR04MB325730CAEB23968BEEA5FA3AB3E69@HE1PR04MB3257.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZuuYswJ1RjIj4u4rJvAx2kgypXDCiWX26ivaB1tRg8ljzLGMcP9xGYnUuxmNmGOgdCSgRWwpSBg5Z6ncBT0Oo0FUqFtQAxr0zCkLwzRnpNhl3HmyqncaUcYU/IF1G1zxoTf7scjtJJo+rGTyNkOhusKdpniwu/Hu+Fr0HVF4+eLrNiXc0hKB5a3uI+eLcairIJPLBaBuMXxa72GHCE6tF3PXPR8A2/RU9R8nes3zPeu70q23xK1KaVlshE8Zlvuc0k45Ypy0plDsLPqfNBfJYHYkT9HmXRZ9Avt1qpyVFUxHw11cA6NPpEA/qp2+Wod1c593TClVXCTBDRqGvWJAbygcKgVNMWQ1WLW088JVUHE8QMRSe2NGVH5wC2VPNRkzyVQ2JBGvyFHxS3MvsCzkFNXuHgboheJ9pgNg6c0mP8U1nO+jGcwE6yd5FgnElCIxAGP/6oj7+BC/6J8p2qHoy3S+UXn65UH3PtsVEKS0URFgZI6bsFF/TiIEJqFdPicySst4DDj7jV3CmwKx0Dvehc6wrp7z+muoR1fy+cEztKWd6UpBQOxxee4AUa1J4BmeHelvqApEc/n29vVVk7u18gCF7tT6/HeBpAuV8gP7OPZsode90ogEwgONIeckVFlo2O7DyGHen+2YrO8tJ1qg2k1q90pmMCMQ1fNnMXNz1lz6TkL3n1B0RIwArUABGKWgX0bR0nI2qiyqOV95Qy8wEGX5+ub80Rjr90lfzPlipmyYJmOGs9NBZQ6d+mfiBrxxwm2GZyF2wdW+LwyWMTbnvQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(36756003)(508600001)(186003)(54906003)(2616005)(5660300002)(26005)(8936002)(6486002)(31686004)(2906002)(66946007)(66476007)(66556008)(4326008)(8676002)(38100700002)(6506007)(316002)(6512007)(53546011)(86362001)(31696002)(83380400001)(101420200003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z0lORUhSdVI4eXJub3R4eEQ5U1NZcjJaaXprZHZwYkNvVkRsU0xMUU5zVjdJ?=
 =?utf-8?B?SVpiSFJ6bG1KWFB3Q3Z4Y2UrWlh2a2JHSnFnd2VEanhPNThwZ1VRQ3JZY3NM?=
 =?utf-8?B?bzJxdUVYRGdraUtwU3FUWUpwOHByOG9sbnVPSExCVXB0ZVZabUxleEpYcmlG?=
 =?utf-8?B?dDhGZHc3RlBrK2ZPMTJYVVpmTldrN256NTh4Zy81eWRlRExidHZIY0F2QTFa?=
 =?utf-8?B?TDBxSEpyVFJqekp4cDVrVk05VlV5akx6TkpSTldMUWEva1FIaUNwVWZ4UlZJ?=
 =?utf-8?B?eksydDdzNUt6Tm5GNGg3MUxrRkZxTjRhb0NLNXdPT2t3Zkcza1haQUZJT01v?=
 =?utf-8?B?WmhjdnZ6L0xCRytCSEc3UmFuUDdRdkx1Zk8yY1daKzdlWkFXSFRXRzBCeVM4?=
 =?utf-8?B?bzZackVmZ3NnREpVdklvYjdZdndkOFBmMWhpVDFkRTJOOWdzNWxVNE13LzJL?=
 =?utf-8?B?eDEyTENEaU9TZGFEK1JWZ3UxSGwzUC9rZUNjZ1FOQURFVCtOTGFSdC9iQ1pK?=
 =?utf-8?B?aGtKWDN4eXZJQjAvdko0VjNFbVA4aGdROXFNa1poTUtLOE8rbFp2Q2M3SnNM?=
 =?utf-8?B?NTZZVTRKYWhSTjdlYThlaHZ4Mk5JVnNnT3hoTzlwaXRhTTRMOXV6MHMwMlVh?=
 =?utf-8?B?b3dqbVdDbmRuT0Rwd1dsK2RvRGw1MGxNaytlNUloQ3llYlp0RTJpTFhwTjJh?=
 =?utf-8?B?Zjlyam5aU0hNeUVQN0RRR1NxRFM5QTQ4YUFzbUk0YUx6M01QNkp1eUs5TXVa?=
 =?utf-8?B?bW03clloWk9LYXg0L01QaVg4NWlsaFVNMm5oaGdIa1pneFVXdlNhSFY1V2Rz?=
 =?utf-8?B?TUJJSjJIZXdNU2NSUm54WnlHdndsdU1hVDdJQUI5cnpTbDZiVFlVWm9Pd2Rq?=
 =?utf-8?B?NnNROVR1Tzd3Q2dPNWFzMzE3eGNMUzk0cnFNZW9JQXRrZUpLWmZpbEQxWXhk?=
 =?utf-8?B?VGZBNDBSemhhU0pON1ZYNm1tTktlUGo1ck1WQVZ0c2daNTRXMG1vZ0lvVnBr?=
 =?utf-8?B?UTQyT01WYlY5ZzdObitzdTYrUFRIQlBjdGU3bWIxT0pkNFlkNUpFYmxkSno0?=
 =?utf-8?B?VEZrNHJuRUMzUVplRXg2clEydGEydndDKzZaRzkwdVI0Z3BqOExhdmNuTWZj?=
 =?utf-8?B?M0Y0VEczMmdWQ1VMd1hSWktxS3FDdlM3T3dJWUVDQllaQ1RQM3Q1OHBtaWJN?=
 =?utf-8?B?NTh0U0ZFa0UvYmxObVBOYVNqNjJta0p1bjAxaTNjMGxVZEthNmhXUGZjeE1k?=
 =?utf-8?B?WHhQQWRYOExtWDA2a1Z5dkRzRExvTkFGUnU4b2NBVm1CV0k5MHR2UWNKNVNQ?=
 =?utf-8?B?cUx3b3ZUK0NacFkxZTNiYnpRTGlaNzVCTTZ6Vm9ic3dLcHU0aS9DZEhKM1Zx?=
 =?utf-8?B?V2lDWldOLzlvRlg4d1EzOTFsdlFkeW9URWEwWG15TCtMWnpxOEkzSEJIZS91?=
 =?utf-8?B?bzdOWjF3YzZKb0Y0ZzJjZzJEaE42cEE4MzhSTUx0amhCQTdhbDBsQ3RzQ2cv?=
 =?utf-8?B?MllTZGRTMUhPbkwwbWhOWmlHTzZHSnZCRWxGd0FMbG1WSUlqREpTcUlSMGQr?=
 =?utf-8?B?dEdvTGgvME1pdE0ydFZZbkp2Z2VGNGFuVjY4Nm9rek8xcExTQmNZRTJ6K1Er?=
 =?utf-8?B?b0I1U2FVd2QzVFB6bDkzeUxudlNIaFV0K01kWVVoOE1xWWp4OVBKcnhMd3Yz?=
 =?utf-8?B?VzlsQmN0MkM1SWR4akV0dk4xYnBHVVI2MUhBZXF5S3pscXE2QkhEbjIvenpY?=
 =?utf-8?B?eUlDZ0JGdFhQWVh4VE9HYWVwTmRkdVpleitwYXV1YVlZc3RLd1JFSHNlZGhl?=
 =?utf-8?B?QXd6cmdWSVNGUHlMN0RBS0pLK1NENWpwQk55b2gxL0krbHhvWDdDckF3NFE4?=
 =?utf-8?B?d21HR2p0cXVJVkY5cFJwM2tRSFdkMDQ1ei9XdldocVEwR1gyT2hrVlczQkUr?=
 =?utf-8?B?dmZCR3haRzdZOXFPYTFzckJROW4zbXNEdnIzZ2w3d04xUG9aQm1OVnd2R2xN?=
 =?utf-8?B?YzZVNTBJVk9IZlNJc2dNUElxenZCSU1BN245VnlPWTY0ekJKaFJKWmxIcGFJ?=
 =?utf-8?B?a09QbGRSY2lLNnRTRjlWNTJ2UERQSVYwRUtpWEoxb1ljRU54d0lZRW1yci9U?=
 =?utf-8?B?RmhHMmdudS9OZGhRblNxQkdJd3E4cUpmVExmV0lWVjZVQUtGZmNKWW51L2F3?=
 =?utf-8?B?RWsxRlpKTHhtRi9PTjFPa0psTE9ZSS8remllTmhpYWIraTRUUUNUUG1oejhE?=
 =?utf-8?B?WjNlUnYvM1BFUGhIRWVrVkRiYm94RUhhUHBJVFpGVGdrZXIyd1BzQjQ1empQ?=
 =?utf-8?B?RlJTamNSWEtyN1pBRE1RbCtPUml1UVhoam9iVjlrQ0U4VTZ4YzVCQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfe43b6d-6dda-4ba9-3fe8-08da18a2b5ab
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 14:27:13.9575
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TVoedzCHKX+il81t+FUOkOzykbpG7nh9UDVOzfez7iRy9W9GtQeTpiQTQ/eOJJox46drrZfF8ytq1DL4SEariw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3257

On 07.04.2022 03:01, Andrew Cooper wrote:
> c/s 1a914256dca5 increased the AMD max leaf from 0x8000001c to 0x80000021, but
> did not adjust anything in the calculate_*_policy() chain.  As a result, on
> hardware supporting these leaves, we read the real hardware values into the
> raw policy, then copy into host, and all the way into the PV/HVM default
> policies.
> 
> All 4 of these leaves have enable bits (first two by TopoExt, next by SEV,
> next by PQOS), so any software following the rules is fine and will leave them
> alone.  However, leaf 0x8000001d takes a subleaf input and at least two
> userspace utilities have been observed to loop indefinitely under Xen (clearly
> waiting for eax to report "no more cache levels").
> 
> Such userspace is buggy, but Xen's behaviour isn't great either.

Just another remark, since I stumbled across this again while preparing
the backports: I'm not convinced such user space is to be called buggy.
Generic CPUID dumping tools won't normally look for particular features.
Their knowledge is usually limited to knowing where sub-leaves exist and
how to determine how many of them there are. Anything beyond that would
make a supposedly simple tool complicated.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 14:36:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 14:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300832.513237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTFH-0001x4-7g; Thu, 07 Apr 2022 14:36:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300832.513237; Thu, 07 Apr 2022 14:36:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTFH-0001wx-2m; Thu, 07 Apr 2022 14:36:23 +0000
Received: by outflank-mailman (input) for mailman id 300832;
 Thu, 07 Apr 2022 14:36:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncTFF-0001wr-R0
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 14:36:21 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncTFF-0001EB-8X; Thu, 07 Apr 2022 14:36:21 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.7.236.16])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncTFF-0005sV-1Q; Thu, 07 Apr 2022 14:36:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=YeW0jGxNfAQvhRV0IWYHpGIvN5Ik3amX7id+xeOHxv4=; b=sZ+kCCxE35AenEn3TVGx3MfPmQ
	0Z7gj5QwdfoHAZazS2Z6GyX4oi5yf+6O3uL+RSId5Gf2OrIvPayf9I4xHuU0NPBTK82cM6ETTQP0l
	vOz1Gy2jkq/SaPidEHPtUBtuCkVTHFHcEEfcouT/o4zapI9CeZa4TwJzf8x4WSjpS3Qo=;
Message-ID: <f4d76d05-fc42-f417-3704-1b7608954028@xen.org>
Date: Thu, 7 Apr 2022 15:36:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot
 time
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Dario Faggioli <dfaggioli@suse.com>
References: <20220405085741.18336-1-luca.fancellu@arm.com>
 <20220405085741.18336-5-luca.fancellu@arm.com>
 <deffb58a-984a-1016-4ac8-c3badc946ea0@xen.org>
 <475D681D-9D0C-4302-B1CD-B8BD2E7D95AE@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <475D681D-9D0C-4302-B1CD-B8BD2E7D95AE@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 07/04/2022 10:52, Luca Fancellu wrote:
>>> +void __init btcpupools_dtb_parse(void)
>>> +{
>>> +    const struct dt_device_node *chosen, *node;
>>> +
>>> +    chosen = dt_find_node_by_path("/chosen");
>>> +    if ( !chosen )
>>> +        return;
>> Aside when using ACPI, the chosen node should always be there. So I think we should throw/print an error if chosen is not present.
> 
> When you say error, do you mean like a panic or just a printk XENLOG_ERR and return?

You seem to use panic() below. So I would also use panic() here as this 
shouldn't be expected.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 14:38:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 14:38:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300836.513247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTH4-0002ZN-HS; Thu, 07 Apr 2022 14:38:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300836.513247; Thu, 07 Apr 2022 14:38:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTH4-0002ZG-EJ; Thu, 07 Apr 2022 14:38:14 +0000
Received: by outflank-mailman (input) for mailman id 300836;
 Thu, 07 Apr 2022 14:38:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E9KF=UR=citrix.com=prvs=0897b442a=ross.lagerwall@srs-se1.protection.inumbo.net>)
 id 1ncTH2-0002ZA-Mt
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 14:38:12 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 57f3d2ee-b680-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 16:38:11 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57f3d2ee-b680-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649342291;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=CwYRepV9LF+sx0WoxLchvnEWTWnAZFrcqCU6taNz3do=;
  b=fYSr8BUa75MsxR4QIuWfTe2s/tCYPZPcYGRW3M50bkhhhXscn7sgqeWD
   uX5zCAXrFUg4v5+oWPyhP9ZEHrXtsu4pRfsQ6PYyKI1i0URVDSe48yDMU
   9tqNePpxLk9h4pfol+yssFFV2NVPdcakhmHpIjGgt5D7/l8VUvdeHBY7S
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70674654
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mRFFx6k42HWMAellk4Fdvzbo5gwIJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKC22HOf+IYWHzf9EnYIi/8kgHsMXRnINlSgA4pCxjQiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1zV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYeBoCJKDxh/0nXjpFM3knLY1f4J/jLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZ71nfdBPkrW4/KR6Hi7t5ExjYgwMtJGJ4yY
 uJGMWQwMEqdP3WjPH88I6k9mcaEoULBbj5VoXbEtKAF+zP6mVkZPL/Fb4OOJ43iqd9utkyVv
 H7c9mL1RBQTLsWCyCGt+2ipwOTImEvTR4Y6BLC+sPlwjzW7xWsVEhQaE0S6pfqRjVS3UNZSb
 UcT/0IGk68280C6S8jnaDexqnWEox00VsJZFqsx7wTl4qje7hudB2MEZiVcc9Fgv8gzLRQ62
 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBsZRAe/9DprYU3jxTOZtVuCqi4ipvyAz6Y6
 zKXqCkzgZ0DgMhN0L+0lW0rmBr1+MKPFFRsoFyKACT1tWuVebJJeaSZ9HPB4MtfNbyUbUSh5
 CEUu9GGzMQBWMTleDO2fM0BG7Sg5vCgOTLagEJyE5RJywlB60JPbqgLvmggeR4B3tIsPGawP
 RSN4V85CIp7ZiPCUENhX26m5y3GJ4DEHM+taP3bZ8EmjnNZJF7ep3EGiaJ9MgnQfKkQfUMXZ
 M/znSWEVy9y5UFbINyeHbp1PVgDnH1W+I8rbcqnpylLKJLHDJJvdZ8LMUGVcscy576erQPe/
 r53bpXWmk8PDbCuPXaOqOb/yGzmy1BhWPgaTOQNKIa+zvdOQjl9W5c9P5t/E2Cao0ilvriRp
 SzsMqOp4FH+mWfGOW23hoNLM9vSsWJEhStjZ0QEZA/ws1B6ONrHxPpPJvMfIOh8nMQ+nKEcc
 hXwU5jZahi5Ym+coGp1gFiUhNEKSSlHcirSZ3H1P2VlJ8cIqs6g0oaMQzYDPRImV0KfncA/v
 6ehxkXcR58CTB5lF8HYdLSkyFbZgJTXsLkas5fgSjWLRHjRzQ==
IronPort-HdrOrdr: A9a23:UH9o46M8qBomasBcT3b155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjzjSWE9Qr4WBkb6LW90dq7MA/hHPlOkMYs1NaZLUXbUQ6TQr2KgrGSugEIdxeOldK1kJ
 0QCZSWa+eAQ2SS7/yKmDVQeuxIqLLskcCVbKXlvgxQpGlRGvldBmxCe2Km+zhNNW977O0CZf
 2hD6R81lidUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+
 O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStmNwyUGT3/ARAghKUPapzLgpAicw5ycbzaBB+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jdiuKYlGfZsRLYkjQto+VY7bVbHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7T1E5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZes6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z54HSKyGG7fIyQZ0We9igF3ekLhlTVfsufDRG+
X-IronPort-AV: E=Sophos;i="5.90,242,1643691600"; 
   d="scan'208";a="70674654"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a63Eo3wnO6cdYKfIjo95eiK+FP+dXAb77WAUXL9XRFUuYlxtlykA15gJoEFCAGf9/qmYVO/58Psg0orFMUXw+QK8K4T1bqFvMdH0FvokD2Ltsj3sI8raU4uPwA1hjQPh5xiLesmDOsoGlPV/rv0tSxm0AuQaio6NVe3LOtxlTTDzvlQ8rOuAzcUwfBIOpo7O1kxesJR4L7D1WvRDLLePdAfy9KfXXXnP2ImK3lZ2uF1VaqPBR3XGUvhGTtWqjvHnywXKOeeYgSsLo4W3dLXRAI8FpT8WnDkObniWkaLoiL4mK2kJ6jy4Ah7vCSMcWRvKMFHQ/Z4snMtDRzeaydWBcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ocQQ9ZFh6y5Ah9sdGtLkG5xPJmoJmSOc0Fq/I/MmYRw=;
 b=Zp1mMOpHw7pqI0Z0GoiBUnH/HouqnETPJUfTs9pu+NEsc9xUHpLjlfADApI+I+Nlh0YgcMZoKTXSsWeUrKWz/EVZl+g9AT2X/SwMM1FEB3MKNhtjDhCD6ggldwqJb34/cpU//pjFGNYhRWtquTFjlHK2LN9T1WHkDnnThbhSacIaQ+xEV1wT5+z1p0uipUtskHXAwp0HxSaYWsZnqPlXfsVzThuttumvs4jWXYthvbM3IWjY7mC8IhfloojrcQACTgEK0k3NpeRa9mkHyrtIMDvurjqSyft3Tcy1Bnj6Fli3xmOJ6PtT9MUi1LHJSKeJ2PbTr3mQCA5OCPj5Qo1Awg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ocQQ9ZFh6y5Ah9sdGtLkG5xPJmoJmSOc0Fq/I/MmYRw=;
 b=MvLqvLh0hEzUTH1G+XFtKcebb8tcXV0QANmp9OxEoWI5cCWNAl7oAEgSBSf972AT9UQvUB1k3knSw/fkCby/BF6aGsUZLvaR0+eEpMXf+n+PmSeJmk8snv75LhKxnVwwzldOfpzLwmM64gMud6IN8/kH8tDpoPHnHv9bdoFo2lQ=
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, George Dunlap <George.Dunlap@citrix.com>,
	"Julien Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau Monne <roger.pau@citrix.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Subject: Re: [XEN PATCH v10 2/7] build: replace $(BASEDIR) by $(objtree)
Thread-Topic: [XEN PATCH v10 2/7] build: replace $(BASEDIR) by $(objtree)
Thread-Index: AQHYPd89/8ailHGG5EeamVnyUqUluazknFd/
Date: Thu, 7 Apr 2022 14:38:04 +0000
Message-ID: <PH0PR03MB638278497E7666896DA969CEF0E69@PH0PR03MB6382.namprd03.prod.outlook.com>
References: <20220322112238.1117737-1-anthony.perard@citrix.com>
 <20220322112238.1117737-3-anthony.perard@citrix.com>
In-Reply-To: <20220322112238.1117737-3-anthony.perard@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fdce1558-3e84-44e6-deb6-08da18a4396b
x-ms-traffictypediagnostic: CO6PR03MB6275:EE_
x-microsoft-antispam-prvs: <CO6PR03MB627533BF946FC818A58832A2F0E69@CO6PR03MB6275.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +FUraiUXkJxjOFt2pBfD+IetP2vozcl37eWDLFY1zEOZnjJokacMVy1S0ug8IClGlgUqBUhUymTRBCALDZHN1p+Xs1fYH4xAkPL+PYRI2hRHmjz/SseL4CzDIw4M80jmsmMWExBD0SaDWXmLIDZNqGTxS9pfWMSwff2ak5FesQYfHPoBU0uPXKQz/oOag6FP6vcWyorUeVqlscpmxS/qeG0TE+eIq8PYbkBNNB7kEh+61jEQONleBaKJ0x4AhzlTiZVUJkb79sz0FZgLUHNIvUw9ahDvclZqdc3EofXft+1fL3Nrgs7iMbvo5ccQZrLr41jK01BJbupLV+MJkvSXzPaMS9NHA4hIt2NaBVssn0NBZuCoj449x1JnI/m2PdZzINgABmh0LByEU+k2Sy/QRWxsvNGdJhKkJ8I0dDCLGLe8vD3itstddpTp+bT7y2QydEtC0+V/ROwvCOdBf3KE8cgfCZXwhvAOSuoHDmtvifWdjmOgR2sZ7Rgcz0qQEGejU/WW+ttqhLtKVQQwVvhNgz9h0DN4BJlAWsjx9AxrJm0IzdT+X+59F4HAd1J9IqgXaMJ7ElFjYXiAQKJWTihpWQN3y7Vk40DfzCrVqShqpfmMNTcYDPiO2iYga7fXmJtn3HzAPnXby2zUxdayUBOaj/0B1kwmPfvHz5chdI1i/rQUPkJVg2Dsoya3oJSb6FMEFk+9SJShxWNBOuXJ7db2hQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(9686003)(53546011)(110136005)(38070700005)(86362001)(33656002)(7696005)(54906003)(6506007)(38100700002)(316002)(76116006)(66556008)(66476007)(26005)(508600001)(186003)(44832011)(4744005)(8936002)(5660300002)(71200400001)(52536014)(122000001)(66946007)(4326008)(66446008)(64756008)(8676002)(82960400001)(91956017)(55016003)(2906002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?2d4FtgKC9IohhqZZ+YUGTmG3hwzXi4+8xa98zF7JhWz9zRLZdwm1YcET+F?=
 =?iso-8859-1?Q?S33a22EdOSlb6O72OeOZw/qwrSJU1vGEQeGbtusgu6o7B6HnQ6Btrq4r8W?=
 =?iso-8859-1?Q?K2KfyYJiHY1oWNrLprK/2CFEDxfYvHuC+xe9H1yr2FvehBpRSo8RpejJCs?=
 =?iso-8859-1?Q?pzoDghZ9zkfuVrrhAZQt0+6+4XtR4pkgfTT17ILx85eHomUX+tDOS7CAcX?=
 =?iso-8859-1?Q?2F5gEjRE7WavjHEgIbBkxZJzrl5WD9JJQJypKRMRf3Op9S142lyjC5HwFu?=
 =?iso-8859-1?Q?XJ+ktpW4SzF8UepHyelVrzMNDp9gdL1gxK27+f78St4wGOoAbCeFZJTbCD?=
 =?iso-8859-1?Q?Q9vd6pEo0ZCvQtSn0/tleP7G8pqEoqJPAohrKZIchlx7JkIRijEazwa0IA?=
 =?iso-8859-1?Q?SIn+ye+jlLykMtKuebIEbVtQg02w3509yTWykDHqwxbw0bO0Ehd9rIQY8g?=
 =?iso-8859-1?Q?6W0n++8q3xDgeHaA6d13Opd3O0UxXo384C1daqu2y+tylUegY9ykidbIfV?=
 =?iso-8859-1?Q?mWHY5tg9KHIbJYyGT4iJHpvR629i9d0I6+ca9/Wq/XomV5irsm6lgc/4EC?=
 =?iso-8859-1?Q?wGx2E4Xxtor9gfWuD1j5yHUQllEF48O6FlQ9pMKmCdPNgYSCPQLX4rx+Lr?=
 =?iso-8859-1?Q?acazMoWIoi1ymHtE/L+5Ob4zPalmNwBHtd0C1Zk085BaDKlHA6CNlWNuDm?=
 =?iso-8859-1?Q?Ugyn3GnjbQlIqkoBaddXT2A2m4EftNH2dl1iQ0tjxPx/CciBrQKAZRnAGD?=
 =?iso-8859-1?Q?W3QZHIwfjt287W3GDvWUwhj8EpQoGfjt510FGcfaZbXaeDGUFXsXchV20l?=
 =?iso-8859-1?Q?n/oTBSEtshCyBVFC4+VDZniOFkqk75UngQWsGjuAk/ptaeOqeUZ31RwZfF?=
 =?iso-8859-1?Q?zYipOld63le1iT++UZt+ghvelz57mjHW1zNtIYvHuremQSFEp28BF0FI9l?=
 =?iso-8859-1?Q?TCCndzaKS/Pj+Rb9S2HlZmROXxhR5vqvH4V+7Stz8yalcyHzaJCM83Abe8?=
 =?iso-8859-1?Q?0SyfguNZE8B1o4w+mBAMzViF+r9upGOI5yyK4NaAvAsYqf8CFpIT0OkKGZ?=
 =?iso-8859-1?Q?LgmkH1Ye9Z8hUEqVgMHziKI7E9CvVqKP5mTfjQ/HybdnVx/l28YtqA88U4?=
 =?iso-8859-1?Q?+p9S8y0efJqtQW3aylLlcXd9rmJhW+mbmUJdcq3mwZtfXo1k4ekYFnFugl?=
 =?iso-8859-1?Q?mHcesFXMumbflDm69VA+evm8cLHmWS2w1Wz8cPd0QCRvgIH6/l0jyZVX9C?=
 =?iso-8859-1?Q?023Xlflz+yOmX2ee3b5D82GKi7/DFP6eVoYUz8chhuxFTOaN2iz88fSCDS?=
 =?iso-8859-1?Q?sB6NCt5Qihk4J4MyNcG8i8AJtHyvlEIo7T3TTROZxnDK12XHxeq6c/h9Z5?=
 =?iso-8859-1?Q?yPZxZ45QE3y0JcmABt4Lfh4fwb0RHXU6lvq1l8D0vJFd7MsqHm3kAuTBt6?=
 =?iso-8859-1?Q?kR+XMMc/MdHmmbzxIk06oqBXFunB8xOV8DPTfDuZFUNv55vuMO/avg5hfR?=
 =?iso-8859-1?Q?Gqii50ZKj3VWQ0TiICnz09GFcho9+acxc0tbMYtdnv273g+cuMhwkY0xss?=
 =?iso-8859-1?Q?NQp8LUMPAAApThswfQkxU2SPtP0uwr2+EFLQpqLfBzWzbbv5U+9bwiMarO?=
 =?iso-8859-1?Q?gB8H75gr5UR5zrqgig9M43dv5yPEHMHzkRzLUSDdnQOJJGHFlyuoHe0i0E?=
 =?iso-8859-1?Q?8c/UyyA79Njo3RCs6GM0SaK/BzQXf27QmdKJkFinIBHBHvBaeNvoe+pfyF?=
 =?iso-8859-1?Q?ICUVlO4zTdkmPk6YWnj+LPO+v6+0ZZXaBjTFnpCsTV7+HYJdRa8A+TCcfF?=
 =?iso-8859-1?Q?Jr37tGNCIA=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdce1558-3e84-44e6-deb6-08da18a4396b
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 14:38:04.1701
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5/uwsSCqFSzajWHhYm6IhykiUALzZYIbE3gqd7HIn3K7bSmr+TAXvEq8CYJlN26F9e2FdGvy9hywrQtnfKfdZ2jZGNMNrgbG478aqe36us8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6275
X-OriginatorOrg: citrix.com

> From: Anthony PERARD <anthony.perard@citrix.com>=0A=
> Sent: Tuesday, March 22, 2022 11:22 AM=0A=
> To: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>=0A=
> Cc: Anthony Perard <anthony.perard@citrix.com>; Jan Beulich <jbeulich@sus=
e.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; George Dunlap <George.Du=
nlap@citrix.com>; Julien Grall <julien@xen.org>; Stefano Stabellini <sstabe=
llini@kernel.org>; Wei Liu <wl@xen.org>; Bertrand Marquis <bertrand.marquis=
@arm.com>; Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>; Roger Pau Monne =
<roger.pau@citrix.com>; Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; Ros=
s Lagerwall <ross.lagerwall@citrix.com>=0A=
> Subject: [XEN PATCH v10 2/7] build: replace $(BASEDIR) by $(objtree) =0A=
>  =0A=
> We need to differentiate between source files and generated/built=0A=
> files. We will be replacing $(BASEDIR) by $(objtree) for files that=0A=
> are generated.=0A=
> =0A=
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>=0A=
> Acked-by: Jan Beulich <jbeulich@suse.com>=0A=
=0A=
Acked-by: Ross Lagerwall <ross.lagerwall@citrix.com>=


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 14:44:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 14:44:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300842.513259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTNR-0004IH-EO; Thu, 07 Apr 2022 14:44:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300842.513259; Thu, 07 Apr 2022 14:44:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTNR-0004IA-A6; Thu, 07 Apr 2022 14:44:49 +0000
Received: by outflank-mailman (input) for mailman id 300842;
 Thu, 07 Apr 2022 14:44:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q2qr=UR=citrix.com=prvs=08907668d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ncTNQ-0004I4-3F
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 14:44:48 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4385fe71-b681-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 16:44:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4385fe71-b681-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649342686;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=lyEj5XMgguLgdNftO1hrdIpBh/48hWEyA25CgqLHDtI=;
  b=DCMauLMAx0V3cKsX9bec0EsZDo7r/W6ubEHVb1k7jiVKgVWvExOrBvFe
   TW2e6MsSFKhKcwvYBK9r2KmQ0WTU3ik+qfZjbR0Y7uA5S6BYELoQGzOks
   Ekfi6ekdpWXcq0wzSCwPZvsAqc6xNZhzDhKsKpVnDG7YV6lbmYap0eFxk
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68270732
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:p+ZG5KqAOC1LqEjzCUv4WlA+EvVeBmJgZRIvgKrLsJaIsI4StFCzt
 garIBmGb/yJZjTwKIhyaIm+oxlTvMLTztQxHQVu/y00HiwSpJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Yyq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBA6LqyMdEfyViMg5TAYZHpJP2I2jmmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY
 qL1bBIxPE6fO0IUYD/7DroBw8u4pD7DbQdXpXfKn7cd2mzCw09+he2F3N39JYXRGJQ9clyjj
 n3C13T0BFcdLtP34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/ajjVWlc8lCM
 EFS8S0rxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9imwxYyEwF+1OlIlYRN9Q916mP40VWUDg
 wrhc8zSORRjt7icSHS4/7iSrC+vNSV9EVLudRPoXiNevYC9/dhbYgbnC486TfXr1oGd9STYm
 WjikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsK4owGWxFADpU
 J04dy62tr1m4XalznHlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYKGW5P
 RKD5lwIvfe/2UdGi4ctPupd7Oxwk8Dd+SnNDKiIPrKinLAvHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZPdQtaciVhXcmeRg4+XrfrHzeK0VoJU5f5qY7NsaQ/90iJvo8kJ
 k2AZ3I=
IronPort-HdrOrdr: A9a23:KSrRxqPcmPOwgsBcTsOjsMiBIKoaSvp037Eqv3oRdfVwSL3+qy
 nOpoV+6faaslossR0b9uxofZPwJ080lqQFhLX5X43SPzUO0VHAROoJgLcKgQeQeREWntQtrJ
 uIGJIfNDSfNzZHsfo=
X-IronPort-AV: E=Sophos;i="5.90,242,1643691600"; 
   d="scan'208";a="68270732"
Date: Thu, 7 Apr 2022 15:44:39 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/libs/light: update xenstore entry when setting max
 domain memory
Message-ID: <Yk74172+jHIn4PJW@perard.uk.xensource.com>
References: <20220331070755.10894-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220331070755.10894-1-jgross@suse.com>

On Thu, Mar 31, 2022 at 09:07:55AM +0200, Juergen Gross wrote:
> libxl_domain_setmaxmem() should update the domain's memory/static-max
> Xenstore node, as otherwise "xl mem-set" won't be able to set the
> memory size to the new maximum.

`xl mem-set` doesn't call libxl_domain_setmaxmem(), but calls
libxl_set_memory_target().

Or maybe you are speaking about `xl mem-max` followed by `xl mem-set`?
In this case, it is documented in `man 1 xl` that `mem-max` has no
effect to `mem-set`.

quote from man, about `xl mem-max`:
    It is allowed to be higher than the configured maximum
    memory size of the domain (B<maxmem> parameter in the domain's
    configuration). Note however that the initial B<maxmem> value is still
    used as an upper limit for B<xl mem-set>.  Also note that calling B<xl
    mem-set> will reset this value.

> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  tools/libs/light/libxl_mem.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tools/libs/light/libxl_mem.c b/tools/libs/light/libxl_mem.c
> index c739d00f39..2f4f9d4a4a 100644
> --- a/tools/libs/light/libxl_mem.c
> +++ b/tools/libs/light/libxl_mem.c
> @@ -82,6 +82,15 @@ int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t domid, uint64_t max_memkb)

There's a comment on this functions:
    /*
     * Set the maximum memory size of the domain in the hypervisor. There is no
     * change of the current memory size involved. The specified memory size can
     * even be above the configured maxmem size of the domain, but the related
     * Xenstore entry memory/static-max isn't modified!
     */
    int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t domid, uint64_t max_memkb)

So it was already known that "static-max" wasn't set.
At the very least, this comment needs updating.

>          goto out;
>      }
>  
> +    rc = libxl__xs_printf(gc, XBT_NULL,
> +                          GCSPRINTF("%s/memory/static-max", dompath),
> +                          "%"PRIu64, max_memkb);
> +    if (rc != 0) {
> +        LOGED(ERROR, domid, "Couldn't set %s/memory/static-max, rc=%d\n",
> +              dompath, rc);
> +        goto out;



So, I don't know whether increasing "static-max" is fine or not, but
according to the documentation, it isn't expected.

Is a guest fine with "static-max" been changed?

If yes, there's documentation and comments that needs to change with the
code change.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 14:52:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 14:52:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300847.513269 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTUg-000627-5o; Thu, 07 Apr 2022 14:52:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300847.513269; Thu, 07 Apr 2022 14:52:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTUg-000620-2p; Thu, 07 Apr 2022 14:52:18 +0000
Received: by outflank-mailman (input) for mailman id 300847;
 Thu, 07 Apr 2022 14:52:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yv5T=UR=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ncTUf-00061t-Ei
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 14:52:17 +0000
Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com
 [2607:f8b0:4864:20::72d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 50795586-b682-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 16:52:16 +0200 (CEST)
Received: by mail-qk1-x72d.google.com with SMTP id a38so2338067qkp.5
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 07:52:15 -0700 (PDT)
Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:ba27:ebff:fee8:ce27])
 by smtp.gmail.com with ESMTPSA id
 c17-20020ac85a91000000b002e1dd8ae44bsm16537157qtc.29.2022.04.07.07.52.13
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Apr 2022 07:52:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50795586-b682-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=aXzHPEsOE9oT+djL0tSiJY62IZUE0RTntN0nR7AbokI=;
        b=FX4ET5aT1BSUsJka48WWFpvPyv51q55N8QUCfUkG0iI+edqbQEa483wokrOSAivcs1
         l2g8XX6YD02LYCxRIYY1c/NalLvFFtUOhiBk2/YodevqFHIQNBW93et4n0eJxhBTMuDB
         jKShGganwHW6evpSiEQcWzkJPF4DAQpRA4A9mxNzJscBl3oF5sVymXyKNOQH8MLp9m79
         REPnn4wZFJKdy0Sax7ZI0zs91KucjotqOXMbPalsq4LhXx/ZaNmwr4XuPKHiWm2Bcs/M
         SdrIfhPlR3Q6IAEyZazn2U80241SgZ2ufOSNbYN+P4xZM5mH3xvy4dvwT31KYYqJSBNc
         9beQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=aXzHPEsOE9oT+djL0tSiJY62IZUE0RTntN0nR7AbokI=;
        b=EBv16kFLcSZlrGeY8NgAD8J24MCy/0ve7ETlomFVGnhONKvk0fNW93Qza9vWR9uL/1
         Z0LxI1d8zPr7N7NjFaFy1Vfr6mUoGz4wTaar8gKuzs0Vf4H2HojWlAFvbeHFF30e2onW
         jdMbwm95JCJJAjwmWRi6BOREH7jcULcrP7ljZpv9y9S1J17VJldywvAqwif8/8YGiL+x
         V5cYskoRtdh/EHgfCf8ZcMzfjlDRlrH3U/kM2MKle2bjliS8tSncaum732Nh5M/fmgWh
         +ggqJCTyz/RS1uM6anCWjsDOqCbxOEF1Ir08EJeOgXhqQ/i1YIReMv5gIgwWSyFiy4+T
         FhBw==
X-Gm-Message-State: AOAM532Lzz5pIQ1eoEmC/m/2JxCJqiBPW3SjrXK9hOnqqAIdvlHh33l/
	/VirpIVVSNf97czySSeS3stDLrYR5vA=
X-Google-Smtp-Source: ABdhPJyhvwseWsv6Rh/cRzoxWBunjNDss2rFLgFd2Geu1XruEBfT8gfbQJMnXnhe4CnnWjJ+U4TDGA==
X-Received: by 2002:a37:c403:0:b0:699:f96c:3b13 with SMTP id d3-20020a37c403000000b00699f96c3b13mr3391458qki.105.1649343134644;
        Thu, 07 Apr 2022 07:52:14 -0700 (PDT)
From: Jason Andryuk <jandryuk@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Jason Andryuk <jandryuk@gmail.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction
Date: Thu,  7 Apr 2022 10:51:50 -0400
Message-Id: <20220407145150.18732-1-jandryuk@gmail.com>
X-Mailer: git-send-email 2.35.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
complete_domain_destroy as an RCU callback.  The source context was an
unexpected, random domain.  Since this is a xen-internal operation,
going through the XSM hook is inapproriate.

Check d->is_dying and skip the XSM hook when set since this is a cleanup
operation for a domain being destroyed.

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
v2:
Style fixes
Rely on ret=0 initialization

---
 xen/arch/x86/irq.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index 285ac399fb..de30ee7779 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -2340,8 +2340,14 @@ int unmap_domain_pirq(struct domain *d, int pirq)
         nr = msi_desc->msi.nvec;
     }
 
-    ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
-                               msi_desc ? msi_desc->dev : NULL);
+    /*
+     * When called by complete_domain_destroy via RCU, current is a random
+     * domain.  Skip the XSM check since this is a Xen-initiated action.
+     */
+    if ( !d->is_dying )
+        ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
+                                   msi_desc ? msi_desc->dev : NULL);
+
     if ( ret )
         goto done;
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 14:59:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 14:59:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300853.513281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTb6-0006yc-Qg; Thu, 07 Apr 2022 14:58:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300853.513281; Thu, 07 Apr 2022 14:58:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTb6-0006yV-Nc; Thu, 07 Apr 2022 14:58:56 +0000
Received: by outflank-mailman (input) for mailman id 300853;
 Thu, 07 Apr 2022 14:58:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yv5T=UR=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ncTb5-0006yP-Nj
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 14:58:55 +0000
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com
 [2a00:1450:4864:20::22b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3e26e683-b683-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 16:58:54 +0200 (CEST)
Received: by mail-lj1-x22b.google.com with SMTP id h11so7820506ljb.2
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 07:58:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e26e683-b683-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=cOslDdcSTDQ4USGpyEHsz9DDfYodPnQ6mATljnaVBRA=;
        b=mbO6YZhESGkYqOtxsbMf15WO0FJjSCYikuigxOqZJ5RAUQMAegfRSMfI4YaJPbr0VT
         Ai31lV6WOgObqGN5oNXRBIJrQ48c14+un+440Qq43qUM3fXQ8u2+rJ1SACEU4p4d/efX
         uOnOpP08EmKfrknNMDpKHrtLH/tlCAp4+zR/wmUIZpf1LEsQp0pTdTtLVN1gKd5cNqGB
         OTW80yMrl5t5aGaJc6NiDCPMHZy1NrSXY4LptABTtkJva16E9b3JfAdL9aNmFyHDXGbw
         7sJ6EcfYb9A2RFSEXWPPMEpO9Ca4STL3x6rOuH0B/W/FIWc20Qwe0qx6qjBMGzyybrJK
         0Jqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=cOslDdcSTDQ4USGpyEHsz9DDfYodPnQ6mATljnaVBRA=;
        b=7l7xHDimGiEtGXCQdfBQ0cbxy4eixDgkInx148qmGD9D5ZI+YFyY/a3cgsQ9UBwaB4
         j8/d4IxRTEuOdyhUtCwsVsqLzMyZ0ni+hzbjD9cw5YbDaUAhxFIHfxLRiwuRkXKzc44d
         BVlaPy1h18FE/8l/ylEEsrS0Xr9vCYE6dl7oA9IW9hqLDv+N6X7WTGaaBzeiaZ95g1dL
         FORbDXnq7yNrlcigpV7H2meUjRJOOQCYnFlfuB4Sm+JYEZZiGTu4Xl+bgpUyw212YmV1
         8UZ8LZKNzJt2O6IKVdFRWTRCaN7FJJJz0Zw+JinrVaD91Qyz+tPoKU23nWaUHNWfLXUf
         f4pA==
X-Gm-Message-State: AOAM533qGuLkB8cIgLNaKDvUF/EeCfJXpGzL7OA7IjN2p+cdTJpGZvgi
	MRsrQRDZO+67rlJrtfzSveRBunlk5MxdNZdKBwYLErg7
X-Google-Smtp-Source: ABdhPJzsDEKuTTgvFGKZSoEGVaeHYgzY75p096mUnR7SRAxrmExfJ0oHagvBmwFJsj//fn+1oCjRm8WgF79/df/vZEI=
X-Received: by 2002:a2e:b054:0:b0:248:5819:b946 with SMTP id
 d20-20020a2eb054000000b002485819b946mr9008586ljl.389.1649343534077; Thu, 07
 Apr 2022 07:58:54 -0700 (PDT)
MIME-Version: 1.0
References: <l3LThLG8tkJBvD-3WTxzw6TRrj7GPAN9uWh-AWqzelw75qpdP1ZLXzBV7599MWrjrHH-lRKof3b0jm1DEGrUXLJszgh5hjW25oNtHoTI9Ts=@protonmail.ch>
 <6bd17005-b662-125b-76c9-ac971c8ac2e5@suse.com> <VL9_sTXEiw8YngLJ-_sfNtIrw4Ofj1iVlw_jTKSCAwEW_DSJukiTpsl1GLCMKWY_9jhCZh3MwN8WF4v1dd_OgrDHoyFs27CrXLVMNckLzdQ=@protonmail.ch>
In-Reply-To: <VL9_sTXEiw8YngLJ-_sfNtIrw4Ofj1iVlw_jTKSCAwEW_DSJukiTpsl1GLCMKWY_9jhCZh3MwN8WF4v1dd_OgrDHoyFs27CrXLVMNckLzdQ=@protonmail.ch>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Thu, 7 Apr 2022 10:58:42 -0400
Message-ID: <CAKf6xpueKcyFMR-H8RegDZkgNdSPLxQKZ9pVkYSa6VEtiHytbA@mail.gmail.com>
Subject: Re: PCI passthrough: possible bug in memory relocation
To: Mateusz <mati7337@protonmail.ch>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, Apr 4, 2022 at 7:37 PM Mateusz <mati7337@protonmail.ch> wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> > I'm afraid answering this requires debugging the issue. Yet you don't
> > share any technical details (as to how things don't work, logs, and
> > alike), and the provided link also doesn't look to point to any such
> > information (and as an aside I consider it somewhat unfriendly to
> > point at such a bug as an information source, not just for reference).
> > I'm pretty sure this code in hvmloader did work at some point, but
> > since it may be used quite rarely I could see that it might have got
> > broken.
>
> Thanks for responding!
> I only wanted to ask to see if maybe it's a known issue, but I guess not.
> I'll try to debug and fix it myself so that's why I haven't posted more
> technical details yet.

OpenXT manually configures the xl.cfg mmio_hole setting by reading the
PCI BAR sizes.  The (haskell) code is here:
https://github.com/OpenXT/manager/commit/33fef12b242e3cc9b46a32d07c84bc593ee537c9
.  It runs in dom0 and can access the PCI sysfs entries.

Trying to do this in QEMU in the stubdom is tricky.  Vanilla Xen
hotplugs the PV PCI devices to the stubdom and then hotplugs those
into QEMU with QMP devce_add.  (Qubes changed (or has a change
pending) to cold plugging the PV PCI devices to the stubdom, but they
are still hotplugged into QEMU via QMP device_add calls.)  You won't
know which PCI devices are applicable, but I guess in the stubdom you
can just assume all of the PV ones should be passed through.

It would be better for QEMU to do this itself, but hotplugging PCI
devices means it doesn't have the needed information during startup.

Looking at https://github.com/QubesOS/qubes-vmm-xen-stubdom-linux/pull/44
You look at /proc/iomem - I guess that works with the cold plugging of
PV PCI devices into the stubdom.  You only grab the first PCI device
and return after that - not the sum of all PCI devices detected.

libxl knows the devices that will be assigned at domU boot time.  So
it could do the calculation and adjust the mmio_hole size itself.
That doesn't help hotplugging, but it will be better than the
situation today.  libxl already does some PCI sysfs stuff, so it might
be a good place to solve this.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:00:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:00:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300856.513291 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTck-0008KW-6Z; Thu, 07 Apr 2022 15:00:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300856.513291; Thu, 07 Apr 2022 15:00:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTck-0008KP-2o; Thu, 07 Apr 2022 15:00:38 +0000
Received: by outflank-mailman (input) for mailman id 300856;
 Thu, 07 Apr 2022 15:00:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9hzW=UR=citrix.com=prvs=089009d52=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ncTci-0008KF-AL
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:00:36 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 776a17a8-b683-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:00:34 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 776a17a8-b683-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649343634;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=W0SXZnqS7IACHqJsaqvS0txvblc45PE1ryirYDXysyY=;
  b=iCtCa0rcqebm6VTfeUm2CNmCABKqTL/0jYx0S9KUmX56eGTKEm0aq1bn
   TxqsZSwPa5YUwqO1iZs4g37pz0Qk3apNIqH/ddhBuBdKFVE2sPj6II8Pw
   ojbuzTIPfdjPEtJsvXH3KIsCMI41Km8Wc+dSWzafqWisCnWPNvuRkMLYz
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68681110
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NMgve6uMNYSf6A2ZYz8e5cE6+ufnVEReMUV32f8akzHdYApBsoF/q
 tZmKWGFb/iDYmb8KNt2Oorko0ME7Z/VnNVkGQRsrXxnRikS+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/V5
 ouoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8IJIHTmt4aXiMBOBl4MKt4v5ruI1aW5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD
 yYcQWQ/MkSZOkQXUrsRIIBm39/02lP/Ty9JtXDLhZgH+0XaxxMkhdABN/KKI4fXFK25hH2wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZ1hHWDy2pVDwcZPXO5q/Skjk+1W/pEN
 lcZvCEpqMAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l67D4/ASjAWU+FxV5btEgiogTbD4E/
 wrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6
 2rSxBXSkYn/miLiO0+T2VncywyhqZHSJuLezlWGBzn1hu+ViWPMWmBJ1bQ5xasYRGp6ZgPY1
 JThpyR4xLpTZX1qvHbQKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aJW6zM
 BKO6VwOvcY70J6WgUlfOd/Z5yMCl/aIKDgYfqqMMoomjmZZKmdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7cQhRfSdmX8ivwyGVH8baSjdb9KgaI6a56ZsqepB/nrQTkeHN/
 3qnXVRfxka5jnrCQThmoFg6NtsDgb4XQaoHABER
IronPort-HdrOrdr: A9a23:sSX74qNWZhhnRMBcT2/155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjzjSWE9Qr4WBkb6LW90DHpewKSyXcH2/hsAV7EZniphILIFvAv0WKG+VPd8kLFh5dgPM
 tbAstD4ZjLfCJHZKXBkUiF+rQbsaG6GcmT7I+0pRYMcegpUdAa0+4QMHfBLqQcfngjOXNNLu
 v72iMxnUvGRZ14VLXYOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee
 r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LPErXoBerR8bMRiA0HkAgMbzaFBOO
 gg5RPpi7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4bkWUzxjIdLH47JlOz1GnnKp
 gbMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Tol4QsJYmD5VU7e
 XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+83JwloOWxPJAYxpo7n5
 rMFFteqG4pYkrrTdaD2ZVamyq9NllVnQ6dvf22y6IJyIEUHoCbQhFrYGpe5vednw==
X-IronPort-AV: E=Sophos;i="5.90,242,1643691600"; 
   d="scan'208";a="68681110"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gCaj/Be5ZGl5XeinTV95KAV4HKvX8d2ngoQm1uGyB/IjS2FGY+Zx/Cjz+/IvQmdG6tqMSNaS5Auc6K2ht3aHEjMYXXaFaTzj0BD39cmFjEYQs/07sG1aKOo38NJ9yYJMfDEhHQaae6oVaRFnWM/mVNTBX+O//J3WACsIroEB3bpneFpG7LtHI9HKpEdOAyB4jIaESn23s9fkit7C4q01VYgsexd+FP9ytdE9KdwJE76jSsWMUeacaT9nnrRHfcXD2XHGZJtJ9I7s1jSIN3vKUdHGxRRqzn5klcGx9ZaK2OUK7ubZFag5BAylyKHbO0siE3wcCukELXoTe878fdvSyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W0SXZnqS7IACHqJsaqvS0txvblc45PE1ryirYDXysyY=;
 b=HDTklbn2Qr1WQ5zJEYJSwII8bIWJJbP7ByqPMukADRDaScQUuX7L4kgddjQDaZZat1kEhZjaH+hinhBPnYCB25AFoLbZ5wcMhL/pSPHz9VPjI8RabgQEF97k6c2GjS0E0QrWGF1lzpycbu7FdDE5nYRd6wwdy1j31H5yNolEi6ZsLmC3fVz7RfaBdEoMoZEA/XSPEjRyf1y/FBOAdhw2WGn4oC+brbVhxzHeEV/Cfe18NZutR8b23ElAxP+D287yxD7Whe1sDiDSOFSVc67wA+xSIUmSdCD/VQE5B/EUIVYTgcJZsOoqEFpqLHEPDCLvoqW9DWAAmMSuQfzd7sG5BA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=W0SXZnqS7IACHqJsaqvS0txvblc45PE1ryirYDXysyY=;
 b=Xybg55dwooztcUe/2JTYGi1jI+oD/QtBfljy4vfH6iaMaD8OVO0XHo4XXIsOmT41B9/Au/LRINDDslCumTkUs2ohJRuIzVtYT4PDoNwJ0cmls20TigwohGNrTkn2+1TnUjiSK/CVm7FVOK4r7usYd2Fb0eDxDKXqXHiCDrHFvMo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/cpuid: Clobber CPUID leaves 0x800000{1d..20}
Thread-Topic: [PATCH] x86/cpuid: Clobber CPUID leaves 0x800000{1d..20}
Thread-Index: AQHYShse3pTPowzhzUqzya5673XmyazkguyAgAAJR4A=
Date: Thu, 7 Apr 2022 15:00:23 +0000
Message-ID: <a8a54dd4-4e55-d833-dc09-92e0122c9969@citrix.com>
References: <20220407010121.11301-1-andrew.cooper3@citrix.com>
 <4206733c-c4be-2e8d-7ea2-d145d3599e48@suse.com>
In-Reply-To: <4206733c-c4be-2e8d-7ea2-d145d3599e48@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 600a6049-5165-43ae-530c-08da18a757b2
x-ms-traffictypediagnostic: DM6PR03MB4298:EE_
x-microsoft-antispam-prvs: <DM6PR03MB4298CE247651467B16F02B48BAE69@DM6PR03MB4298.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 1G8bIQeXOhaXDyTZCM5fIqqz5eS1ajreKBPsO9IlTxTal9vwxUAodogLkpGt9K/mUGI41lw1Eox50yQnJRw5Uau8JEq43lrx+al5GnZsYQTRBKsGnV03Q1uuzuxnpUDvPnB4a4wO7x2dDvJFWIkPjJmcZREhHwvPka549BRFtAPhXrtg0dAQvgrvlSeALBpZq5d2qt4X+/J8UEqPAEbuy5n+D02cEwEGu0gyc5TIfTk+yZzN0HBpteeVMGFwfoTV/Yo9rJORWOG/VH7Opv12U57LZ+/2P7qEJiLa0EPDaifwdkoNZrMRc4VcNjPbmloiK2p1ycfg8Xza9f8xxIxLgJAJgq2CvbvSPBymV3MSGTKVuO4KYA8LptVYD4GyZcv2kiegXM7ynduNxUbB9TK+yQ72hrWWgb5tFNrZk/XXwR83+aby9BJbSVW2qv9MZsD1+wfWwJg6aoGNKEoGUTo2vbpBmTVh6O1fXs3S/fkTUFEl96WRZHiv4duabSUeN8SxdThSbPzWGvaf7aOBqh3GNv0kMLuEsPsznxfa5vwXk28aOOoCBeGkeTGXoWQUpAjxCYSckLMGwa+uyY1lqncuzIfPxOSC4izF9QQnGzQAIEzPuJCIGNW57B5CWGomd1u4j8phwI223BMaCUovphf7VL4bndoS14M/QA3qz/0CLBFZ7IR+y/x264mH5HA1kUiYUjznx8ZO5l734ba5nAZ2tjSRYYXTzicC48s+fNT6jaP1zrevXI7LB3YPy5o5Lj7leEYrht5BsHIQxU8paXw45S11kuMxmTzQkC0zSD4lWLrxvOR5FqRkfq36lm0TS0IQCqJDiyFdaSqk4XdSwZIZ7kV3OMR7zQRhKab7XKum0t0=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(2616005)(36756003)(6506007)(31696002)(38100700002)(83380400001)(53546011)(31686004)(186003)(26005)(66446008)(4326008)(71200400001)(76116006)(38070700005)(86362001)(2906002)(6486002)(508600001)(8676002)(64756008)(66476007)(54906003)(122000001)(6916009)(66556008)(66946007)(316002)(5660300002)(82960400001)(91956017)(8936002)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K05mK3NYbDlBZXl5YktOSkxDWjdpSlZhVk5HbmdVVTFkN2taTWlWUEJIUDFE?=
 =?utf-8?B?bVFMTDlFZHVQNnVjYldjNkViWUE0TGhidHJhcVl1NWg1Q1dQSjRLbXVuSDBk?=
 =?utf-8?B?TENkTHRXcmFiOVdldWJsanFiTEtWL2dZS1MzdHZCeFdnOFpTb2pkMmxDenFq?=
 =?utf-8?B?NGs3ZCtwYzBiRWplYUoxNkVqa25vK05aSi9jNHBXZzh0S1dRL2tLWmtWMHg1?=
 =?utf-8?B?ZlVuUktTNzR6Qy9DanJwK1ZsdHBXOVM2OTA3VGlpcGR5SndqNXJBeEhFNktO?=
 =?utf-8?B?cGppVE13cUtmbzFPc056VmU3UGtQNExENlY0bFhaNmxNN0VTL2RQZGYwU0Za?=
 =?utf-8?B?cldrdFZGaUtvdGxoTGlKQXM1Z3MzcmNFdU0vOXFZTU9raUlBTWNjaXkrNHhG?=
 =?utf-8?B?RWx3enl3UXhTNGdMZ1owQ1lkMjZ5RnNGZjIzSS9jS2J3d1d4aGdhVDAwVmxT?=
 =?utf-8?B?TlA3TTBWTjgyTCtIOW5YTVNPMlJaZEcwQmdzTE4yS1g4YWo3eXRFRGg5M1E5?=
 =?utf-8?B?MExYRXJ3TVlBU2x5aU45SjlqNW4rSUNCSFd1NHJORlE0REppU1NMeXhGQnFB?=
 =?utf-8?B?a3hqNnorRzRYYlZJdFdXbzZlNzVZVndBbjNOeDJGL1dxOUR1NmxHc2ZQN1NS?=
 =?utf-8?B?cFdmVHcraDZyRFVLaml2RTBpQVllbHVTdWJhZm9tTzVsWEM2Z3ZtZTVyZlV6?=
 =?utf-8?B?eFJuN0JaLzEvK1QrMWx5SUVYSkdCRloxV21MUDF5MkNxSFRHZTdRSzBLOXQx?=
 =?utf-8?B?dEROUDBscTVrd0xmRTRuN1YzcW5TSWxZOUp4RkJXbkpZVUt1QVE5LzF3Tlc2?=
 =?utf-8?B?QXcxb21CUmhUckZEU2QvSVZOd2VmbDZzSGF0cDF0ME5aaUhFZTF5TGxXZVRC?=
 =?utf-8?B?c3RudTVaMVZ4YTAyaTdiY2dtRWF6SmhWTFJGNEZoQzlBZnBscE15YnEvN1BM?=
 =?utf-8?B?dWxOc09NTEluU1BNb2hTMFE3eGlxanVhd1ZPYzM0d2p5TldycnV2YnQvYk1Q?=
 =?utf-8?B?aEU0L0ErdU4zYmxSdEsydmpKM3l1YUlORVdaUlZhWEJRVUJ5dzJiRXM2MUxG?=
 =?utf-8?B?aHFNYXlMcE5qc3ErZnA5TENoanRUUS9rQzdyWXVKTHN2ZzI1dHg1SkVWV3Zt?=
 =?utf-8?B?WFZVaExwMzYreUlLdU1INEJLT2c4SjRJa2U4RDRpNXB1TkFnN0RNT0NFeXNk?=
 =?utf-8?B?OG9rOVBpMzVwcEhMaW10WTZNd1UrMjU5NFBBeHgvU0VUQ2dyUUZDSnZ3Ylhp?=
 =?utf-8?B?TGRWMitNVURlWnljU2hBdmJ1TWtnMTk5TVA1SHM1NTI5cERYNVBPWFpRZk9r?=
 =?utf-8?B?TGlnMTFyN1lqbkN1WmFxOWpCcTRMSktUSU5kNGVVMHBaU3VDdWJDSmdoSTBB?=
 =?utf-8?B?Qkw5WHlEZWtXSzlqbk1tSVpCRnJxY0o3QlpXMkE0ZlpQeXZCZzFybnM3YVR1?=
 =?utf-8?B?d2laT1VvWk9WMTczNWFCNnhOMmV6VVFhYXBWN2dITG9CMXpWVTA2Y3JRTmgv?=
 =?utf-8?B?d2hPUGFwM3kyWmJHekRLV0JkMmpxNXhCZnBVaEpoRjdKakE2aHliM0tMTWJo?=
 =?utf-8?B?cmROWEQrQUQ5UmlTaUFjTTUydFZuM1c1Q0FrWkRJQm1hV0podFZpeVovaDVi?=
 =?utf-8?B?akFBWHBLVjhlREhKdEtOekhLQXR1ejBNeU9rdnJjMHBmeUhjaC9FYUd6QXFW?=
 =?utf-8?B?V0RtL2VxQjFOa3FKa291V0lKNUxoQkkzVW9EWXZ3QkMrZ0xXeEhMUisyejdH?=
 =?utf-8?B?dXFMeDgvaFl3blJmcEp4aUlpUkk4SENmSEJML2pYSUgvZ3NrZnJsVE5hT0pT?=
 =?utf-8?B?ZHgzRWpvRGh5ZFR3QjE4TDhKV0VPOURzYit6Wk1DSlNCRkluWkVoMXY5Y0NQ?=
 =?utf-8?B?T25LMlA1OHFoZ2h2WERJZW1ZTTVYMHJEczdYME5XUklsREdGN3VkcGRiejhH?=
 =?utf-8?B?VU1QNVVVZmJueUJUK1E5eVd5b2FwMmo4dW5Zc2Q1U2ZwVmYrV3JncmR4Y2Ju?=
 =?utf-8?B?d0tCOWo1WEVZN3ltQ0RPQ1Znd1BHTWxUejBpdXl1ZXhRNjZxeEZ3ZHozTy8x?=
 =?utf-8?B?Qi9hWWNGKzlYOEIzSDNjN2NBekZtZERhT0VvdnhFOHBVczJmc3NPUi8xaU5Z?=
 =?utf-8?B?aHppaHVvSzFDYTZ4Q2x5UVpVRHEwNnhjQy8waFIyQUgzcXlUajh5Vm5lUHNo?=
 =?utf-8?B?SUhrZXo3R2ZFUkhEMERxQnZyNkI3cjVRSmJwZEdYVGNDNWpTanIyUjVlVStM?=
 =?utf-8?B?VHZnU1lZazFxMXZ6eGFXdjhNUHF4Zlp3d2VGakxSL3lPL2lxVUlSMkIzTEM1?=
 =?utf-8?B?YVlHejRHUzdCQjFiQXpVNHc5R0NoZnRoSUVuNzA1VFhja0IzZDRqZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7954C7AC1D4CA949BBB32CD60B95C30B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 600a6049-5165-43ae-530c-08da18a757b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 15:00:23.5318
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VKyerdM72pvjMKz8x1IE6oiad3XgYxoeROFFpY7o82nyLsOPnV4aX6FCuQD+x2R9VEzc2W01pUQ7OByY9k6y5ZDaZjDJPAoryy5ABQcBkJA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4298
X-OriginatorOrg: citrix.com

T24gMDcvMDQvMjAyMiAxNToyNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA0LjIwMjIg
MDM6MDEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBjL3MgMWE5MTQyNTZkY2E1IGluY3JlYXNl
ZCB0aGUgQU1EIG1heCBsZWFmIGZyb20gMHg4MDAwMDAxYyB0byAweDgwMDAwMDIxLCBidXQNCj4+
IGRpZCBub3QgYWRqdXN0IGFueXRoaW5nIGluIHRoZSBjYWxjdWxhdGVfKl9wb2xpY3koKSBjaGFp
bi4gIEFzIGEgcmVzdWx0LCBvbg0KPj4gaGFyZHdhcmUgc3VwcG9ydGluZyB0aGVzZSBsZWF2ZXMs
IHdlIHJlYWQgdGhlIHJlYWwgaGFyZHdhcmUgdmFsdWVzIGludG8gdGhlDQo+PiByYXcgcG9saWN5
LCB0aGVuIGNvcHkgaW50byBob3N0LCBhbmQgYWxsIHRoZSB3YXkgaW50byB0aGUgUFYvSFZNIGRl
ZmF1bHQNCj4+IHBvbGljaWVzLg0KPj4NCj4+IEFsbCA0IG9mIHRoZXNlIGxlYXZlcyBoYXZlIGVu
YWJsZSBiaXRzIChmaXJzdCB0d28gYnkgVG9wb0V4dCwgbmV4dCBieSBTRVYsDQo+PiBuZXh0IGJ5
IFBRT1MpLCBzbyBhbnkgc29mdHdhcmUgZm9sbG93aW5nIHRoZSBydWxlcyBpcyBmaW5lIGFuZCB3
aWxsIGxlYXZlIHRoZW0NCj4+IGFsb25lLiAgSG93ZXZlciwgbGVhZiAweDgwMDAwMDFkIHRha2Vz
IGEgc3VibGVhZiBpbnB1dCBhbmQgYXQgbGVhc3QgdHdvDQo+PiB1c2Vyc3BhY2UgdXRpbGl0aWVz
IGhhdmUgYmVlbiBvYnNlcnZlZCB0byBsb29wIGluZGVmaW5pdGVseSB1bmRlciBYZW4gKGNsZWFy
bHkNCj4+IHdhaXRpbmcgZm9yIGVheCB0byByZXBvcnQgIm5vIG1vcmUgY2FjaGUgbGV2ZWxzIiku
DQo+Pg0KPj4gU3VjaCB1c2Vyc3BhY2UgaXMgYnVnZ3ksIGJ1dCBYZW4ncyBiZWhhdmlvdXIgaXNu
J3QgZ3JlYXQgZWl0aGVyLg0KPiBKdXN0IGFub3RoZXIgcmVtYXJrLCBzaW5jZSBJIHN0dW1ibGVk
IGFjcm9zcyB0aGlzIGFnYWluIHdoaWxlIHByZXBhcmluZw0KPiB0aGUgYmFja3BvcnRzOiBJJ20g
bm90IGNvbnZpbmNlZCBzdWNoIHVzZXIgc3BhY2UgaXMgdG8gYmUgY2FsbGVkIGJ1Z2d5Lg0KPiBH
ZW5lcmljIENQVUlEIGR1bXBpbmcgdG9vbHMgd29uJ3Qgbm9ybWFsbHkgbG9vayBmb3IgcGFydGlj
dWxhciBmZWF0dXJlcy4NCj4gVGhlaXIga25vd2xlZGdlIGlzIHVzdWFsbHkgbGltaXRlZCB0byBr
bm93aW5nIHdoZXJlIHN1Yi1sZWF2ZXMgZXhpc3QgYW5kDQo+IGhvdyB0byBkZXRlcm1pbmUgaG93
IG1hbnkgb2YgdGhlbSB0aGVyZSBhcmUuIEFueXRoaW5nIGJleW9uZCB0aGF0IHdvdWxkDQo+IG1h
a2UgYSBzdXBwb3NlZGx5IHNpbXBsZSB0b29sIGNvbXBsaWNhdGVkLg0KDQpJdCdzIGJhc2ljIGlu
cHV0IHNhbml0aXNhdGlvbi4NCg0KSWYgeW91IGhhdmUgZWxlY3RlZCB0byBpZ25vcmUgdGhlIHJ1
bGVzIEFNRCBzZXRzIG91dCB0byBjb3JyZWN0bHkNCmludGVycHJldCB0aGUgZGF0YSwgdGhlbiB5
b3UgZ2V0IHRvIGtlZXAgYWxsIHRoZSBwaWVjZXMgd2hlbiB3cml0aW5nIGFuDQp1bmJvdW5kZWQN
Cg0KZG8gew0KwqDCoMKgIHggPSByZWFkX3VudHJ1c3RlZF9pbnB1dCgpOw0KfSB3aGlsZSAoIHgg
IT0gMCApOw0KDQpsb29wLsKgIFRoZSBvbmx5IHJlYXNvbiB6ZXJvaW5nIHRoZSBkYXRhIGhlcmUg
dW5icmVha3MgdXNlcnNwYWNlIGlzDQpiZWNhdXNlIGl0IGFsaWFzZXMgdGhlIGxvb3AgZXhpdCBj
b25kaXRpb24uDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:01:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:01:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300861.513303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTdO-0000Vv-J6; Thu, 07 Apr 2022 15:01:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300861.513303; Thu, 07 Apr 2022 15:01:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTdO-0000Vo-Ff; Thu, 07 Apr 2022 15:01:18 +0000
Received: by outflank-mailman (input) for mailman id 300861;
 Thu, 07 Apr 2022 15:01:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncTdN-0000Vc-9r
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:01:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9261c03c-b683-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:01:15 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-jxtdQqawOPuZi6AuXWaE8A-1; Thu, 07 Apr 2022 17:01:14 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB9024.eurprd04.prod.outlook.com (2603:10a6:102:20f::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 15:01:13 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 15:01:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9261c03c-b683-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649343675;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=F4Fy+HuQ1ahLRZkkeLjYi3ElgU7JhahZPR2UkCBKzmg=;
	b=FI5apdjok+WJLO3j8xoXfdDm4xB5+OGO8+hAlXpvnG3J/fqRjxFZQ+yTbFyJt4bjb7FDkI
	xPk7upn4GelO+jIgE6iBM5PDt8ej5jGLs/cFipSl5Ox0DZucvGuvjftBUpl7rpX8m6j4yK
	ofnKT3CztqL9r/812vVjDdxoST+3gbg=
X-MC-Unique: jxtdQqawOPuZi6AuXWaE8A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vc/WwV4fq5NMpC7EaUqRWUmkKEla2Y89CH6g6ajz0b/bHsumcqwmBI9Ql6bJmB+4wl24DWKa0adWogLVuKsuRDuNE+mKjwVsB3V/2Gv/QIreB76KlwQhlA2kOAM35DSJbTPpdcHCQddMvu0oW9egjZrJBxsjs/VZ7CPLs+H6VxzPF1lCscY4ipj0j4i4b9DkaFcCv2vjXOw4zQT3MZx5IenES0wYg2irYONuVC9mQYjOu77eM2nVScmH+vUkpd22MfeGYZk9ObfHV5+P3fnKqH9Mwcgpfg5wVwivKDImycHaGe+JqwU4iINWSTb/MQTx2aydHfr4BxseGCKg50K0rw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F4Fy+HuQ1ahLRZkkeLjYi3ElgU7JhahZPR2UkCBKzmg=;
 b=SIM8bWJAANGywSUWLnPNqrqvRUpl5H0E+xP9LDE3lLMKy7ITzum804E+V5O9bYMB1UBQX+KBBkGyolLaCviUTRD4wT4ymFhr2CmuUA+zwsY+hyaaK8rhc0v7/cn7veO8P3zpyFJW3FSXortlKUsGDQioe49PWdoDXGxLtSWSHpDgT4Q+Iw9QTTOtWFAf5y5gc2536n3WoKyaRShiGZWgrrdroYhaEE7z2GqyjZExYt2eoht36rjYsyLiEi3YN7xHzn2vqRnRGeghu0KUkGFe0mEkSABcMklbt+7GY8KVDiy/3LZAWJbYfJOu5EaAiYcfBxIaH/XklpSbb+VS4B6oIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <56a57946-04f9-90a0-ac4c-17773347dcea@suse.com>
Date: Thu, 7 Apr 2022 17:01:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] vPCI: fix MSI-X PBA read/write gprintk()s
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0121.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3eccde1b-d8b8-4bca-5418-08da18a77528
X-MS-TrafficTypeDiagnostic: PAXPR04MB9024:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB9024FF57017B750700F3AADAB3E69@PAXPR04MB9024.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/yxjJjLrwKjme6+bB7uiyadRRT/r1T+GQi4KN7S2vgLZUXyUd7jcubXI8pgXmKg9HMA7DhMdD5jm7XDdhD2XG+2SiPjCMby2nLeWkYM4d4nzaNGgLkZ5iVFWWlborq2+A4rGn/Ll96uxw4/HAtDikZpbMAcw97wCMq7h6OXLoa7gV3PMpzZYBGg9LCP02d5wsPwTIlm+pJWeKsjxUYy7z6gfaiV3KWE5/FMmoezWYs9A0KeTdRc91E37XOZEreyqpxLzvpWPExw6aHAB8RrXylUgwevy2hCsocLlva1e/N8gKbASoNvfgKIGgK3qn6xaK5r6RUcauQxsDk2B/vluxOWHQ3FsbTPAV1t8+/5/hoY8a09HWPDf7NxqzPjihQ41rSQOhmtSbYAZ9cWgRkl9zShT5+Fl9qp4O8kNJqBDXJC2JLQL4qBVNviu9BTJ8x4bShGzhqmkEJgWaMZVofOCP7lVWgyfTGVWYgiuJZWILIL2GE2/nuio6vpq5R/smEDieHIUlxXBbn2B80o3HC0PU1Qz17hfpi8Zp7TwL2y67RNSziBomOYvFWSMmMkRCDCaALh7R9DGjXOStskQ7/B/SSFp7xk2gCAajRCyqEYzhgT60c3qerZ5+Fq4Z0KrAN5fpirLlXC0oQUoM6POCbzdScln6MF/VUngdx0KElQhnEnu6aXVJ7fnMeDLLvcsxsxDYasP5qJio4yAfQ7s2LAoGMv9m8wu/vtVMQs9chL+dgE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(4326008)(6512007)(8676002)(6486002)(83380400001)(66476007)(66946007)(66556008)(2906002)(6506007)(38100700002)(8936002)(5660300002)(31686004)(36756003)(31696002)(6916009)(26005)(86362001)(316002)(4744005)(508600001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Yy9tQTNwdGpwdVplVWo5ak1aRWZnVWlHWVZkUXhWYjdSYUQrN0dPMlg0RVdS?=
 =?utf-8?B?NlNkUDNqaFVGRkVkZFkvVllQbFJ6QWlxdE5JWGFvYWVUNVB6Z2RHL05ZVGY1?=
 =?utf-8?B?c2JPYUxCU1NqcHZYSEF5NmlNKzJFQ1NKT2dvWnFzWWgwREhNYW54N3BTNmhX?=
 =?utf-8?B?M3h3Qjg5YXZkalJxSEJhUklQWnl0QUF2SDQrRFMrenJhdVNsaXFQMjVyZ0V0?=
 =?utf-8?B?VHd6ZFQvOFNjMjRIeUtzTHAvbWUrWkVId1VRSVA2L09JUVdESnFtV0dUZ0ty?=
 =?utf-8?B?WmVZbXB5dG9udG0xZnVwQ1FSelpIRXlpWVZwMnlrak41T0dFaVNQTFM3Q01w?=
 =?utf-8?B?ZytYbzRZYzQ5NUR2c2FSMFVTVXRMb3RFZlJQNWl0OGNYNFlPaVVOQjh6eW0z?=
 =?utf-8?B?UVZqREkyT2I0VlJEZ0UxQlB5OUoxWnp5QjUzYzFNU2cwbkZTekJEUktRK3ZC?=
 =?utf-8?B?MU5CS3o1TzNJQ2JBR3VyVkpyQUpDMUNuUmNPSGJYVlNEMC9uUG15eU1ZWk1J?=
 =?utf-8?B?QXdKVURIOU9DcjhJS3dnc2M3QWRORW0wNi9FSkVQb20ybVN1R2YyZWhvbVI5?=
 =?utf-8?B?UkIvbGkvK1dvQzlNa2hBcS9QUm5XVTBseFEyK3Y3MHk4ZVVKYjhTMWtvRERC?=
 =?utf-8?B?VlplWVJPbGxGNTNhZGZYMitQSWE2aU1ZcFpBOVhsRC9FR1FhMEZXRUVrVUxL?=
 =?utf-8?B?N3hma1JLbUVRamNVK05nK0poNjdQaTdKQnNmZWpQSjM3S3lpYmxIWlp0ZHNK?=
 =?utf-8?B?K3BUMVh0VTBTUUtnblNkUFRseVJWSjRySHlrbzBmMC9tK1Vua3lTemlPYnlF?=
 =?utf-8?B?VGZJTUM1TWlsdmR3dW5hTDFUa2I2VXpMQWpoRDFYUXBUbC9QVVUydGFLV3NO?=
 =?utf-8?B?WGpUL0FpYi91ZDVzODhFMzdYaFJPVFRrK1Y2anZ5aTBtV3dnVVc2OW1pMXFV?=
 =?utf-8?B?ZTZ2R1JHRTVabEFYelg3RENpNk81ZkRRZ1J1U2QwaEo5Z3JJYmlpYzFLMW9q?=
 =?utf-8?B?WlFYZXNVTXhVcjVlUi9VRit5MVh6akFhbWZuaDZOaS9ERnRaRW0zMmUwVDJw?=
 =?utf-8?B?T3BFT1lPK29CZHB0cE5kOHVYVUQ2ZTA0MzdOZFliVGY4TWhxNnZCVlYwaWdk?=
 =?utf-8?B?R2IveldtVS9tczN1VHhrZHRUancvek5rVk1nL0hRaUxJNmtYR0wrL3ROSzhp?=
 =?utf-8?B?Zm5ZaUl5aEYrbE53c3cxS3lRUFErTlJhcktiSTRqK1NGYlN3VGxaa1FsNFJq?=
 =?utf-8?B?TUlmY0hieFlvTENON1d4YW1nb1hlQzZPcWZKbVJUNHNrRlFEMkc1WTFMcnlT?=
 =?utf-8?B?VmwyU0FPSjh1M25uTlpSeHVmSGtuektVRFIvOGFQT2EvOXVkSnJkVmMwT2w4?=
 =?utf-8?B?YjBFbkozWjNXMzVKa3VpQkdXMGJLbG9MV2FWZWU2SXdFWFRvQmdwQUxPOEVL?=
 =?utf-8?B?Q1BPOWRKU1B0NDJBSFBEL1VCNVJiQ1ZTRUxVaHBnbHAwSE12aFBmWGpXczhi?=
 =?utf-8?B?NGlDNW9yRVdRNE9JcG93ODE1enN1SnpRa0FUVGM2NzVIUjR1WGxvT1Y2a0tV?=
 =?utf-8?B?UDIwZ3dJK3FteWNlUjZUSjJpSFhOTytIWU8reEFpVHVtOUE0Tk55Y3lzdFNr?=
 =?utf-8?B?Q2FBK1hoazB2OTFubk85aVpwOXRsMGQ5dis3VlRhMHlFaUhZVmgxOFREN2hx?=
 =?utf-8?B?RlhiMnR6LzhtOXdESDVkL2xqeVM5WVJxNlZtZ3FHb1c4bHlPVkVWczRXTjVF?=
 =?utf-8?B?b2F3TzlEV3JuOHNINVFXczZSUW1SN0gyekYraDBZckliai9jQ3lIeDhudmpS?=
 =?utf-8?B?Wk5DcTRsdDErSWFnclA2VzlhbFNCNmFqWkVjM3F1RUJjRGZzNDNkMWxIWlVr?=
 =?utf-8?B?NzBsK0daZFozSjdUN3R1amJEVU5KSkpUaGJGSXYzYXpRSGgwYUF2OVRQL0Zp?=
 =?utf-8?B?dERjQ3U4ckpoaWR6VW1teUd3ckZFT2dzL01mUXJ0ODZ2QVZKZUUzd2psNlNG?=
 =?utf-8?B?aGZjSU02Wmcrc3FFKzJmOG9QRFlzOTJiTis1NGtwVVdTRXB1MGhuT01WMUpp?=
 =?utf-8?B?M29SeGpUNU1NcHI4NnhwU2Z0a2twZlhMa3RYNzBQZllsamNwQjVsZk5BZU5s?=
 =?utf-8?B?Um9nMnRxM3I4RDFFcE1Qa1BKMHZJOFJ1a0lpUUIzWnA1aEJ6dVFyemMrUWhX?=
 =?utf-8?B?dHAwTmRjQzc5c2U3UlpheEV2SUlxbHQzRENmMUpOUlc1MWdQTUxJMmc0YmpQ?=
 =?utf-8?B?VVFKQmlrcWx1N1JadGI1NCs0Q3hVZWx1WEZIdFFkWEcvRHhRdUpyTEp5RDg2?=
 =?utf-8?B?cGh1cEwzeTlLdGFtTFB6M1JMMVpXeWZDR0FGc3owTzh2V2NoZEg3dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3eccde1b-d8b8-4bca-5418-08da18a77528
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 15:01:13.1622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LNW/Aj2/lhmQX3o9okIafsZKG/yGY0OHqoMdmojGYZ+JSBxB8itmacedBnUvl4ArWwlmGzDjLfNrB4Fb6o2P1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9024

%pp wants the address of an SBDF, not that of a PCI device.

Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I can't resist to say that this would not have happened if we hadn't
made this a %p extension, but e.g. a %o one as I had proposed.

--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -247,7 +247,7 @@ static int cf_check msix_read(
         {
             gprintk(XENLOG_WARNING,
                     "%pp: unable to map MSI-X PBA, report all pending\n",
-                    msix->pdev);
+                    &msix->pdev->sbdf);
             return X86EMUL_OKAY;
         }
 
@@ -332,7 +332,7 @@ static int cf_check msix_write(
             /* Unable to map the PBA, ignore write. */
             gprintk(XENLOG_WARNING,
                     "%pp: unable to map MSI-X PBA, write ignored\n",
-                    msix->pdev);
+                    &msix->pdev->sbdf);
             return X86EMUL_OKAY;
         }
 



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:04:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:04:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300867.513314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTgC-0001B1-0a; Thu, 07 Apr 2022 15:04:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300867.513314; Thu, 07 Apr 2022 15:04:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTgB-0001Au-Tq; Thu, 07 Apr 2022 15:04:11 +0000
Received: by outflank-mailman (input) for mailman id 300867;
 Thu, 07 Apr 2022 15:04:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/6v3=UR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncTg9-0001Ao-NY
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:04:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f95b85f9-b683-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:04:08 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-QBmmBVfaNqWFMzeG0ggKgg-1; Thu, 07 Apr 2022 17:04:07 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5175.eurprd04.prod.outlook.com (2603:10a6:20b:e::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 15:04:06 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 15:04:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f95b85f9-b683-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649343848;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=jnqZVrwb0NaHLt4TFQFuycfDG5MtXpUoN1vga+mT/TI=;
	b=kKjl1GQ8WhKJ67h3CHP4eUVY2aGFSmIPqVEKeMERcYhOe/dxc3H8sV28dXd/5NxpMw6jtx
	4WvT655MHodlgXt0EXhcXruOfDzavt9XpLHWbdLkhx+Wk59ImbXxo7vxD9Ntktr6zA5mje
	jItNeWRiDJG+vuEYhbh6SkUPBX2uUqE=
X-MC-Unique: QBmmBVfaNqWFMzeG0ggKgg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ctd5KEB8eG+/JwkDf9kHU8c9fQVPd0LtEwkSBtn0xoAe1OSruBKVpiC3bSiLml7A2jPuRLFRD773PnWQUuO0wSyTSHTcfvl0QMYU8OzlXMkzH9kIGYQBUT2e2o29IF4ShlIVfsLDyG733Cu2p9pmqq/eTe2xIu8Qvv+TnpmV1P/nOh5zh3GCIznAQdCL4xFxrwvRDNOSuQQFg4wcBK0hOicfsxbcsp/0CfBtXwLxKXOJBMmeXeEUVLOG14gAX/gT75KGuvpOkmlcOkvv0szHC6bOGi+gdGPWURb0Tq+lRcu3BpDFwt0E+mBi/2DIzTQPSIp/SUYtn/YYMf50+ziuZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jnqZVrwb0NaHLt4TFQFuycfDG5MtXpUoN1vga+mT/TI=;
 b=fpuKatJ8mjRr6S89zgKLMY6LEdEpy+vnganUa6SuNOUOZXrJZHHyx7WYGp8wytQ/AfQN4t2N/HnKAk3GktUcdB4X+/3UtM6xtUBUHHJbwQnZlxXXEBG7YnQLne9D4M90KJFYIOaffbhX8plfYsFWWmzoHawN3vLNQRgMGmR9UjIVtRC6h8bpc9I2S+jG3lR9UNQQW+UefWhl1OdRflhstkOXg73LS7aTR3lLXLqB3fon/OUoiMKZ6BYdd3TH5t+rLnFS/B0qrt5kGLch1B7RNIIV6Q3KYwH00GKYfgwlS5u69AMpWSGYVjdL82PlGulpFZWOQzI2vvyZS2sEdMEdNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <36f65270-8807-323f-c1bd-d14dc742ee74@suse.com>
Date: Thu, 7 Apr 2022 17:04:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 4.14] vPCI: replace %pp
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0018.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b0420552-44b1-4599-697f-08da18a7dc48
X-MS-TrafficTypeDiagnostic: AM6PR04MB5175:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB51752BAB0203547A10348716B3E69@AM6PR04MB5175.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0iPuvNZGeZOHarYgmVi67ImqGdZKB/EWdOjasYaCG3/ihWD6gwBkmuKxap2MktInWODRbrNsnn6zIX0HlmPYh5cZlokcUMxlqcvX4VioSIRbyxIgsPktIxp0Oo78oIShalJ3fn13CUIeYAKJLBnlcvXyUKUrT/LsHsCJDW6xC3vjxwKbY9+7cc6e6jF4KYBCobSrdW6wsifDatTKE2uXuEJ23L2bn5hR0iUJWGUsoigsyIJSSSg16yRwAFHcDJKK0N4gTmQWZ/ZtjDQ4bjf86BJr1ELCXQw4ctjYMbw8TcNQAHWUPM9afvkzkJQ6hC5Oc223/Rt2KzUg8VnDpooqk/V+2P8LmRCcalAP4mdKfDZS1dr25kVZ1HyJnNhmyceYAIiyWChwR2omnRKuMZX2i3G2CIABkPU9lM4l/LR2pNIysM74eVsmTzB1tyqZTAgtSkVvJDzj23cbaVbOX0tuY0V7vCMAKoFomBhJZGzBboV8Rg5zhTP0k8HVnSO94c9cnnUmTDHZr3NcrPb2Wd/Rup6khBsdEY1Ig8yxg2PApGQ2ibJ++kVaAC83TTnqUYmP+7GKjhpr8sYqvcpxMgAeOI/ajeHjtlaEOFV0dgY+xYzgJ//HrB3xqfT1w7zudTQ+F0+CSXUodaqlkfKHKrBBtr2KT0M8dUiVMRPPAfzYQnkgDHh5ndilEjXrH+vSiKK3BLfQ34u5Hf6QB0zuhuNaSB+PlFLrFUxOD0GhQJvE30IlCO6+zEKpX6HbwpcPNAiP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(316002)(38100700002)(66946007)(66556008)(66476007)(4326008)(8676002)(86362001)(83380400001)(31696002)(6512007)(6916009)(4744005)(508600001)(36756003)(186003)(2906002)(31686004)(2616005)(6486002)(8936002)(26005)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NThmUG5HSm9jbzJndHkvNmh1YWYrNHVIVGlhZlhvL0ZkdEFvOEhwejkyQnBJ?=
 =?utf-8?B?OEpHak40SmZiMVAvV094TUVWcFI3dE13ZEF5eW93RTNVNms5UEtkdEptRXZ3?=
 =?utf-8?B?YWwra1pqOWFGbERycXo0QXk1WGVucUN5bkR3YWUraTVmUW05ajMrNjlFYmpD?=
 =?utf-8?B?NFdENytEWDFEazA1b0FZWExxWU1scEhyTTdxeThZL2NnQVV3b1N5OWR2UTIv?=
 =?utf-8?B?M212RTl1bURDUkMyVWFDN1oxYW41Zmt6N0xXVm5RcURQQ2JmVlJRQk1vUEF2?=
 =?utf-8?B?cExvcWg5aGgvY1ZXMHphdzJBc1NKVWNFcnNZVytFQ0pUOVp5VXY2RHF0WHpv?=
 =?utf-8?B?RGdoVzd6M201cnhjSWxHRklPWS96MWNKRFNtb1N6QnR4Zi8vcW1sV3EvT2Fs?=
 =?utf-8?B?WGJtV3lHVEFTRVcyVjVtWks3Q0FkSWhRSG9yc1VMaUc3Y0MyZmNFb1V2Tktt?=
 =?utf-8?B?cmpLbkViajNMcjYzQlB2TTR1bkc0a2p0ZUpIMm9qYlRoclZVZGpna1NObEtQ?=
 =?utf-8?B?c1pJRGlyMS96K2p3Y044UGxrZ0lJam9RcjJVczU3L0luNENHdmF2UG1oS0Ew?=
 =?utf-8?B?OGRwU0RGLzcyWHdGNjJ1UVhIMUlyS0h3bWV5ZmFKWVgzQk81N0RKYUZrMU9M?=
 =?utf-8?B?YW02M01kNzB5OEpydWtod2RhcGNCRHJ2dVlNcXg4TDI5Rkp5M1pEMjU2Y0ta?=
 =?utf-8?B?eVNWT29LTWxna1pVR2F5N3dOZzI3eWZoSzN4S0EwRWZUdmNyeW1IWTJwZlRa?=
 =?utf-8?B?OGJKTnR4WG05bnAwMGx1Vk4wM3ZPWmRPZzQ3NGx5aytEUE5UVGt0Q2JTV3E4?=
 =?utf-8?B?V2Y5YjVaSi9paFFEQkl3SzdDV1Y1WWNLSktUQW9wRzJydlhGcjVPVlFTMVow?=
 =?utf-8?B?dHJ3TXA5MWtMbTF4MmlJTXd6TTY4MXBCTWpTdnY3MW5CZHgvTC9zV0tjT1RY?=
 =?utf-8?B?Q0tCUUNxWGtxVXVFNWVqdGdLeHR5WEVFbWlud1FWRER6cm1XTUZBM0tsUmFK?=
 =?utf-8?B?ajZEcTJRdFZ4UmJybHVWME9WV25VNnRRVHg5VjZHc0RPV3FrSlJWU1Qrb2RG?=
 =?utf-8?B?VTZnWFdIRmxPMWJ5dU56bk1HNk5admdkRnBnRUlkcExKL0wwUy9kUE9DWUNW?=
 =?utf-8?B?WVU1eVNSd3pVR0MxWG9VVXdDUVE1d0FyTWNEcEV5TkY1UnBObkJLYWFsQjBp?=
 =?utf-8?B?V2d1cXdjWWk2djd2M25DVTRIbFNVRHhmY2taWGkxTkFJcEhPVjlKbFhlRUVQ?=
 =?utf-8?B?SUJmQzI3UjhKUi8xdG5Kbmd4MnpQQlJWNHB0VDdEUmRDaDJwejYxb3p2RU0z?=
 =?utf-8?B?L0dRdU9rYjBnNHE3VE9aSElFN1dYbndHVDlBQ1BGdlZ1eCtwVVZJQm9qdDU5?=
 =?utf-8?B?TGJEelkxcXdRRm1PUldZbHcwM3FUVHpMMnlpZW9ZTGR4RkdjaUlULzZUMzRP?=
 =?utf-8?B?cFc3MW55RHdmanBQSU9Qb0hETkRoREdpM2JNemdFazlSL3Z3L2dTS2ZZMnRU?=
 =?utf-8?B?UjhMaVlpeVlrYndqb2huWlU1dUsxNkZudERhQUk4TzhBRzlpNGpwVFRQVHoz?=
 =?utf-8?B?OXpsUWFzamVhUHdFRkMyTkhPNTdMSWhia2hoV1h4QkVEVTVMeXFML2l2dGdS?=
 =?utf-8?B?dkZKNThNejV5cFdaRXNRNDl0V1ZSb2hQTHpBWnZyM0VNanBtRm5keHdET1Uz?=
 =?utf-8?B?cUoyOUlrZ2VRVXdwSVVjeWJFMlpPbWpETXdrWTVxV0g2N1lFL1NVQk9TcnBr?=
 =?utf-8?B?azlZL1RZdUF4Z05uQlBERGRPSjU3L3VnNE8xNnZoaWp0eFhkRWl3azlscTdF?=
 =?utf-8?B?c3YxWkcxRXNLb3pWWlNBRUE4dEJuRDloQlJPQW5FNnJubkdySkZBcC9EUlR5?=
 =?utf-8?B?V0ZsZXcraFNkSmhXOW1UQVJCUmRVeEhDY25pbmxIRjVVd0hwS25lWDJQRDVm?=
 =?utf-8?B?aDk3dDNxcHlibTdVSlhOdlB3cmJ0SVlTSDVpdk9FNDlCYlVLb0svTnpTQmpi?=
 =?utf-8?B?aFhqOW03NXArWHd3RFB5V3BiWURobGJGTXVhdTc4dnlxMDN6MFl5cy83S2x1?=
 =?utf-8?B?aVAvNDJJem45TFF6YW5pTy9rTGNRRzYyaWNJbkNuU1NYKzRTOEw0THBHMGFj?=
 =?utf-8?B?cmZWRDZwTzF1NmRDWUdmeXBPZzFvL09FMFNmOVc1Y3YzY1lhVFhqL0FEUzA3?=
 =?utf-8?B?UXc1ZG1yOVk0L3hqWlljZGRFeUVhenJEOGFvU0M0Uksxa2p1Nm01Zk1hNEJ6?=
 =?utf-8?B?TGZxMHNlRmpxWlZocnpYRUQ3VVJTTmRuRlVHWVZ4cXk3cmZNMEcyVWlzR2x6?=
 =?utf-8?B?emFDOWlTMHUwS0ZoVTk2YXFaWmFBQ3plSldpb0VSV2pXUi9tNXBEdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0420552-44b1-4599-697f-08da18a7dc48
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 15:04:06.1778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fQSvxwkFYST41l9VWqEyFLUqp5Aq864bjtFqwJpB7nZQdI18jC4QREJLfU7u8G0Q0fGygNBJ7Diq3+H8R8Z2yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5175

4.14 doesn't know of this format specifier extension yet.

Fixes: 47188b2fdcc6 ("vpci/msix: fix PBA accesses")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -258,8 +258,9 @@ static int msix_read(struct vcpu *v, uns
         if ( !pba )
         {
             gprintk(XENLOG_WARNING,
-                    "%pp: unable to map MSI-X PBA, report all pending\n",
-                    msix->pdev);
+                    "%04x:%02x:%02x.%u: unable to map MSI-X PBA, report all pending\n",
+                    msix->pdev->seg, msix->pdev->bus, PCI_SLOT(msix->pdev->devfn),
+                    PCI_FUNC(msix->pdev->devfn));
             return X86EMUL_OKAY;
         }
 
@@ -342,8 +343,10 @@ static int msix_write(struct vcpu *v, un
             {
                 /* Unable to map the PBA, ignore write. */
                 gprintk(XENLOG_WARNING,
-                        "%pp: unable to map MSI-X PBA, write ignored\n",
-                        msix->pdev);
+                        "%04x:%02x:%02x.%u: unable to map MSI-X PBA, write ignored\n",
+                        msix->pdev->seg, msix->pdev->bus,
+                        PCI_SLOT(msix->pdev->devfn),
+                        PCI_FUNC(msix->pdev->devfn));
                 return X86EMUL_OKAY;
             }
 



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:05:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:05:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300870.513324 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncThl-0001ld-Ce; Thu, 07 Apr 2022 15:05:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300870.513324; Thu, 07 Apr 2022 15:05:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncThl-0001lW-99; Thu, 07 Apr 2022 15:05:49 +0000
Received: by outflank-mailman (input) for mailman id 300870;
 Thu, 07 Apr 2022 15:05:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncThj-0001lQ-Tn
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:05:47 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 32f25b56-b684-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:05:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32f25b56-b684-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649343946;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=BbKwJGnBg+WpuvFH+VXc8Z4GjsbFiG1ceXXGEuddvKE=;
  b=hmRsZdJXc+V2XQ+xnwWb/vzw4c4gaRA3h/z7i30rVwZftB0cn1ARK9YO
   5yFI4o1/r1kyZ80tcYI0TWPJY0sc0EJ/122QLnLiz6zf4oAuVVgFvv3Nk
   FqAKpjEaqNRgebeMoG47L2oIBDwYtsl1FNmdwIpv64dzu//PczgH9WiSW
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68682003
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hoTboaMoBUkZUMrvrR2ll8FynXyQoLVcMsEvi/4bfWQNrUoigmYPx
 mMbWm3Taa3fY2qhKY13OoSy8xtVvsCGnNFmSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tEw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 exxp5y1TzwSEpaQqdstUCtRKhpnMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmdu1poWRa22i
 8wxNQVtchfRYyJ1AGwbGZgwpsWR3VLQSmgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3Eru3FkD7/WYkSPKal7fMsi1qWrlH/EzVPCwH9+6PgzBfjBZQPc
 CT45xbCs4A3zXC5Ttz7ZCaUmyK1gS4fadNpKPQ1vVTlJrXv3y6VAW0NTzhkYdMgtdMrSTFC6
 mJlj+8FFhQ07uTLFCv1GqO86GrrZHNLdTNqiTosF1Nt3jX1nG0kYvsjpP5HGbX9sND6ECqYL
 9ui/Hln3OV7YSLmOsyGEbH7b9CE+8Chou0dvFy/soeZAuVRPtPNi2uAswWz0Bq4BNzFJmRtR
 VBd8yRk0MgADIuWiAuGS/gXEbei6p6taWOA0AQ/QsRxqGv0ohZPmLy8BhkkeS+F1e5eJ1fUj
 LL741sNtPe/wlP0BUOIX25BI5tzlvWxfTgUfvvVcsBPcvBMmPyvp0lTibqr9zm1yiAEyPhnU
 b/CKJrEJStKWMxPkWvtL89AgOBD+8zL7T6KLXwN50/8iuT2ib/8YeptDWZimchltPjU/1iPq
 4832gnj40w3bdASqxL/qOY7BVsLMWI6FdbxrclWffSEOQ1oBCcqDPq5/F/rU9ANc3h9/gsQw
 kyAZw==
IronPort-HdrOrdr: A9a23:Qw7L8an1abWS6ONfVtyCNXqsO0bpDfLW3DAbv31ZSRFFG/Fw9/
 rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM
 xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv
 Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
X-IronPort-AV: E=Sophos;i="5.90,242,1643691600"; 
   d="scan'208";a="68682003"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fOtyfMMOlAj53CIzjzRDwsKi8XVgZrhVnpoA0Pf7Fvm5VjCFhKUVbCOwjwjEuh89YDP34cGWO+S6Np/VXKiaAfOeEDAH55W1himiKfteREBjCJSriua1lC8AFcKA+VifzPhZoYC9bqpzvsfKv0H8n0KS5K45ipKs0xwAEz7qu2C2XMYS0vBhwJlr8DRrBvz/QgHjvmlfa5Iw8YiPcYKtcOHpdMgag5qc+6cbQI2Bxh8grP0QjwJwoG0NrjFmn2WR8Oq5kz0RkY5dtmVFCCxKM706VDkF7qBz3pDX2kr0DR+6SOVRRpOJW9S6zrLRYKFp6xsad4lV5iE6rLL6CNZZ4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lGd6cA+Yy1VyE3vwwOd4GCBdYtHFIvXCXHzoelx6Hrw=;
 b=QW+yIa/l/Fofa0T8FC5wC0hkemPC6LjUTxzJqJfzQDvcgJFAWberHviaiTXSuVnlKtlHz14/VOWLlHhsSaTx76ee0IQnSggctc2VGcC64z/pKVePMR7zvWkxLKVMkhhZI7WWS/WiTTQfWYP7sc7zbho/XzJYnaXiGkVPObg4x69+KB+m1HgZQDfkMYWvq5YvWP9Iklr3re0SSQ46DLI23mr7GqXw2xhuAMV3zMQclNBHSiUWnWwSTIByTnCYeUsZM7a6m34uV780RuwzMQeXg/SOFYr9ZL4F/WTGN0ov3PhouLXwNV+N90z5qKsIG/jazXLIJmbtTsmnWbZGxy6AYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lGd6cA+Yy1VyE3vwwOd4GCBdYtHFIvXCXHzoelx6Hrw=;
 b=TuGgNDVjZOYKnUdToJ51+qoaaIvs5qZ1sK7qBTr7kmeNum9rkKP6qjaZmSCZQZEfULq8szLdGUzyuApaaZAzVYl/o8tHtxpnBJ2SeUuftUn2w4MBv5O8fdGbyt6Ykl2Szb+GMu67bRDeTSgBRWtfYs+BrEPE0YDhl2+0xCinoQs=
Date: Thu, 7 Apr 2022 17:05:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] vPCI: fix MSI-X PBA read/write gprintk()s
Message-ID: <Yk79wNy1H6PDSVVS@Air-de-Roger>
References: <56a57946-04f9-90a0-ac4c-17773347dcea@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56a57946-04f9-90a0-ac4c-17773347dcea@suse.com>
X-ClientProxiedBy: LO2P265CA0239.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::35) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a0b6f546-a149-4d00-5366-08da18a815da
X-MS-TrafficTypeDiagnostic: SN6PR03MB4095:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB4095A8B6C877EF8F1CD1EF5B8FE69@SN6PR03MB4095.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9wEKnYaoz34xp5V9Q2f3tRIdQN4Uzaw1I96Nuqez0KCjAVANTA4yggQOT9Ej5KtO+i3iPpzYSnB+EldxaCt2jLhuf9W7MavqfGXios4GAwjE+BOGIwaknyJuA0s8lCaNJTWcVz8X9nQ5mf9bJbNK+tmvDXx7RIiQXQwQ+rEf3grR94WMizhQx1djAIdUGgim/j6WXXip02D8jrwFs51yA7a0GBQpfQLWSsObXCpQpjQ9pFxNIyZFABwUPhUq7ZrxoHTrYwQZEM6SU+APkwg3MYJcW1WRqg+eqEB5NZafGzXI3qd19pO2+jeZzlZFyHK+V24oZbTPk67yhOyX4S4KhqeKetzp8eAVjD/w/ZhRGaKaz/goqjW9zuPGuew2wzjn6AxhqbfSpIg0E0jGctK2A5TRUlitHBD8lPomY/NAoVGjBO/LLolTdt+csF3s/BPy3eLBU3ifBZl7q0mFKM7KogrOVPp91vkvWTEDqsFrYyA3Ma47iAI5ALxuwH4UgJkmd8A+fHX1PAKM2VvxmBJ6Gpb6uBp3RneRS4hHawmY4SHj/kskwm1YIUZGQ1dL9QMTD7Ag+8y3Qgl3f/1CSnm2GZ7pLaGajJVUcOiUnnUnxbm6Tzq0kjgWpOiXT5TuFsAi5lKYiWgcVW4JZCMYm8W8dA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(82960400001)(83380400001)(26005)(186003)(38100700002)(5660300002)(8936002)(4326008)(316002)(66476007)(558084003)(33716001)(6666004)(2906002)(9686003)(6512007)(6506007)(66556008)(6916009)(508600001)(8676002)(6486002)(66946007)(86362001)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHpCQjhoeDI4NmRqTCtPZjBwZ1ZqS3lSZDcyV2RkZHdidnVxWWpTcE1BcEhH?=
 =?utf-8?B?Umhnc0NDNWIzcDd4SVNwZlRIVmRZMVp6R1hrK1BjcmMyMjc2TW9JU29UeXFx?=
 =?utf-8?B?bk1TaHIzQnhicmlRWUZZT1p5USt2RklhYmp1WEVnb0owZkFhaGxHRC9haklR?=
 =?utf-8?B?cUgwWVNLTFVzdVVZSTMzUVFIL29rbnlnaHp1bnpqa05TTUE0YWpxaS9sR0VD?=
 =?utf-8?B?Y0hwWWg4eVFuaG8wQXFQeTM3QUsreG1VZWxlWUZTTnVJakhLWWM0T0pCak1y?=
 =?utf-8?B?YVQ5ZFo1dHJpOVFUOVVNZjNzT09meGRDK2NWeGxlQmtVdS9KNCtyWERmUHJY?=
 =?utf-8?B?RXBjeWRKQWtoNGgwQnoyc091RFRxdm9iM2FFVmJKb25FTXZpbXBBZ3RBcGJo?=
 =?utf-8?B?OVlpSldyMk1PK25zeWVBUnVkWFBqejQyTDRlbU9tVmFjSGY3WnMrYnBEVWF1?=
 =?utf-8?B?MU5LUjlKR2ttY3h3elpKcVc3WDVGa0FCL2cyUHJhelFhU0dNOUkwVjJ5RUpw?=
 =?utf-8?B?enlqay9VQzl3dThETTJoZUplV0VvM1oyaWI0TUJ4cnR6d3RoSlNuTjNkZ0J2?=
 =?utf-8?B?YzlmNFBYOGIyeUtRTUVCQWQ4bEE3ZUJsY1FBTGdwS3dBUWtQSXoyaGczT3Q0?=
 =?utf-8?B?cjQ0NVQrYXV5VC9abHo0Ym92NjgvVk1aUHNwZkRmdms1MGhkbmVpR0Z0MGQ1?=
 =?utf-8?B?eE1SczlQMW4xQnlMTlorQ24yajd1bnlweXdjMlFUd0VKenQyRHpoNHFlMkNB?=
 =?utf-8?B?ZHVQU3J1YnkwVWR0b0w4Mkgvb2RXdk1DWDkrUjAzWnJ4UHdRT2I0bE5lNklv?=
 =?utf-8?B?S1VvNE1vYUc1cDVrVUtRK01mOS9XVFVlR2RKeDY3TFdPMXNacmNreFZEUU53?=
 =?utf-8?B?ek1DMVpTT05JSzJLUGR4ZEVXU0oxeHNvM2RCQ3l6Wnk3ZWhHN1gwVGk1Z0tS?=
 =?utf-8?B?MTRCZEhBbFg5MHp3b2FLemQ3N3NDZlpxMmhzckllOEtpZVdKZEFwQ3lEa0VW?=
 =?utf-8?B?eGJ2MFdYdWVQNHova1ZRM1NLbDdpOGZYNWk4L094Y0hJcWhZVzFzQmVLbVY4?=
 =?utf-8?B?RmJCNkRzVkl2bER3N1lMeXRsOUJkbEltZVVuWGl5N3R2T0JoTFc1WjhES1Ar?=
 =?utf-8?B?TzlWYXl2MVkwS3BXcGI4Rmg1bWhCWHc1ZmJqNlMvcWhGeFhnbTg4dUgzRW9S?=
 =?utf-8?B?WjVGdjREZ3p6SEtQRlVSY2hOWFp6YUR6ZHFad2NXQWtNMUh3UTdWN0hCaDRu?=
 =?utf-8?B?NjBqNHd0eTZhQU4zQytlNUJ4RXdiV0RYbHhMVVZ5WkZ4RENmQldRWWpmNXFa?=
 =?utf-8?B?YzV6TEorNU5pM1FJNEllaE5HTDdlT2pZODgwOVk2QS9nWFIxUU1WUzgrK2Jw?=
 =?utf-8?B?OUI5T3VVbVJDZTByK2lBd2lGUGkzTGM1K2RBcytHMFVUR0tLb2VUdG94ZzY3?=
 =?utf-8?B?TEl4Uk9wMWFZNFl6TkxLU2ExRXZLYUZzZ1dhMWY4dVgyMmU3T2tKekVDK3Zj?=
 =?utf-8?B?YWxyT044MnJWNlpDYk4reW5zUVEvbW5ZQlJYdEROWDEyYUxiT2pReWNIbVhz?=
 =?utf-8?B?dVFhU1VVUG1ha1cvTUIzR1pEUmpOeHBVR0N5aXZVcnl1ZmpWZE1yOXJxcVNv?=
 =?utf-8?B?dTdpampXNDI4a1NpN3JJb282Nm5EVEZwNHZsMnFraTZpbGJGcGtBZVFtMmx2?=
 =?utf-8?B?L3RIV1NXZ29Sd3RnQm9wM29NMU14ZmMxZy8wUElIV1hPUXJRblVuZnVrNlJy?=
 =?utf-8?B?S2tKMFdNeFo4a1p6VUROYzNjMG5pbGNQZmtmTS83U05VdjY0dkpSaUZ5TzJI?=
 =?utf-8?B?WVBJV1dsZmlCTEd3Vi9tTCtoZFVSKzMrQzU3aytGa0NIODI1RUdrdGNWbUho?=
 =?utf-8?B?Y0dreExpQjhhek03dGprNlhlQk41MmpRak9yWUZrcE1USHdUV1NYUll6Qzl5?=
 =?utf-8?B?bHZRZWNWNnlhdWZadENqYWVxMkJuOEdWanlUeXBwOVg3eDJCK1Fxc0tLMFdE?=
 =?utf-8?B?aVpHQkQ1WUdqOEVsWHZHZ2hlOEkvc1F1NHkrdy8wRjFycE5CaVppZFpkdG54?=
 =?utf-8?B?U2w2MnVUSGVKMjJhYmgrS3owbjkzc0dRQWJTS3pPTzhpa3VzZUwwUXM3QlF4?=
 =?utf-8?B?YXR2L3BuUWRDUklDWVdDU2p6b0R3d2hqQll3TUNJemVZaitoK0FKOFFXMHFY?=
 =?utf-8?B?OEpKUjZJbHR5U0t4VWNVaXVBeEJ4UkQ5MjMzNVFQV0l6dkJVY2RqNzFQd1Bm?=
 =?utf-8?B?Tmt6QndsVmhkcmxsZ0ZsWGhEeFlJV3FwcDZIYnBkOGJySmFKSVl6WmF4aUsz?=
 =?utf-8?B?M0svY1Ywb0ZJVFN3SnNrUW1TWXR1ZTBYNUVBYTZoaXV1LzFueGhhWnE1MUoz?=
 =?utf-8?Q?6Ov1j6UFjO+AzFcI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a0b6f546-a149-4d00-5366-08da18a815da
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 15:05:42.7798
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RHqEXpiJQGiArv6EfLZHJPS16JTZg5yU+Z+YPUPRsKBiS642YWlopid2SjmG8jEFgaeTiuXTjctEqglOy9135g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4095
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 05:01:11PM +0200, Jan Beulich wrote:
> %pp wants the address of an SBDF, not that of a PCI device.
> 
> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks!


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:09:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:09:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300877.513335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTl6-0002lZ-Va; Thu, 07 Apr 2022 15:09:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300877.513335; Thu, 07 Apr 2022 15:09:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTl6-0002lS-Sd; Thu, 07 Apr 2022 15:09:16 +0000
Received: by outflank-mailman (input) for mailman id 300877;
 Thu, 07 Apr 2022 15:09:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qv4n=UR=citrix.com=prvs=089d11f18=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncTl5-0002lM-Iz
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:09:15 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae6fbce6-b684-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 17:09:14 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae6fbce6-b684-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649344154;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=qyZG7BZzXEXMaZb0MTf1MEolA2NinnKxmmFqBBOBsuc=;
  b=fDCyJ/6ZYUChTQS/LCsg58x84DehL+/sbEDwLUMIYgOJM4PCpupnBuYh
   aqqQ4ra77LHr1GpSyUvrlg+Mx1cWN/VpwsgpxatvRMszIotDV/wlvJCR2
   cDjVoMBwgJTyzbs6Bz6XJUiyXiN2g+enKpKRNbTl6Vr2FIgpLWiLj4lay
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67696212
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2Bber6wVuTy469pUejh6t+c3xirEfRIJ4+MujC+fZmUNrF6WrkUOm
 2IcXTrTb/+MMWKhLt5/O43lphxS7JPWnYIyTVdk/yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YfhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl6rmPRzojffD1vqc9DUJ0L2Z8YvFf0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J8QTKiEP
 pBxhTxHdg/8Q15/ChAuFcg6sMqlvlv4SRRigQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCntSHxVZ8WFba43uV3m1DVzWsWYCD6TnPi/6P/0BTnHYsCd
 QpEoULCsJTe6mT0a+bzYhf7/Uei/T5CAPZsVO9ltBikn/+8DxmiOkAISTtIadoDvcAwRCA32
 lLho+4FFQCDo5XOFyvDq+78QSeafHFMcDRcPXNsoR4tuYGLnW0lsv7Yoj+P+oaRh8a9Jzz/y
 iviQMMW1+RK1p5jO0lWEDn6b9OQSnrhE1ZdCub/BDvNAuZFiGiNPdHABb/zt6soEWphZgPd1
 EXoYuDHhAz0MbmDlTaWXMIGF6yz6vCOPVX02AAzTsNxqmn9pCH6JOi8BQ2Swm8zb67onhezP
 ifuVf55vscPbBNGk4cpC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk3nVKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4vY+F6Fr
 IsFb5LiJtc2eLSWXxQ7OLU7dDgiBXM6GYr3u4pQcOuCKRBhA2YvF7naxrZJRmCvt/k9ejvgl
 p1lZnJl9Q==
IronPort-HdrOrdr: A9a23:hjYdOq/3DIq1gsA1iLtuk+E6db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wgK7VBaM0ot
 gsCZ4Y542mfvVmHZ6VO91xM/dfKla9Ny4kY1jiaGgOKsk8SgfwQtjMkfEI2N0=
X-IronPort-AV: E=Sophos;i="5.90,242,1643691600"; 
   d="scan'208";a="67696212"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fshvUTyl1AR8Ok+9K1ODFO8m4v4yohPpdgC90kkZT1QbDkCjVuvFbUQ+Z7W2JU2AEU9hYBclnhvTRLckbLyf0oCkwx5L/Eufo10+08bvKcXYu6vMCFOjCy5zrP7dHL/gow3xgTzcjs0vSm1uxQ7f+mHtTtBjoiWKZVuzcpxYw2cZJuXheLjpO45tzn5ugA2ZvQXTOayhwFKyegbaYSkRI2dOtqc5XHedycICEOpJUDGKDUtfDWf5fQWliWojPJQMTlX93E9B8ybC7alCNFh/x3ljgtKVbj6HUC8Z0OjGjZoCcis6JmbMnaN7QcE9NIUmoYGWLaoBXkVKuHfIQlrV0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y/FbFEWhY9PbV5wZOuV7ziLlYJTmx9SuC5JkI5h0Ioc=;
 b=JavIoTCWGgYL5qGP57Fls+03AijvXjDCbmb6mE2FmV6zjX/piun3Kg9CND1vrgS8EWVYx5u+zqaLw4BOHqmYNGv0z64Aux0uFPljG5kWF6w9+wgTkAXP/4r56Nd2bMKo5kBvUgcvnhgfLS2uq2npLt6gGzZTzh6A+OSCth1St+F4dwnrnp+rkUWjvRYKCzC4IBt1zUIm2S6549BFdSYkL5Bf82wRhTgEKcGaH4AOV9sSVZ6KrDEeNMe4E0EfFkksU7YqnXa5EGDzld07w2anufi85pwZENpg5tqEWwAxFUAQY4ScCQqgKo99pwBJAdxxM60uV5eUittH6OkMWqDVgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y/FbFEWhY9PbV5wZOuV7ziLlYJTmx9SuC5JkI5h0Ioc=;
 b=fHReCqUO307rK6Q+ULCUGsYHcb2ppbjAeCz3V/QXgAhVlKyzk5mG67e7QZuc9lDfn6e6vJIRF7oowmElJgSv4kqQl9qgJrw5q7m8kDPcEjhYKqSI352TCsBG79ckqJxH2V2ubdVHNQl8gu8qNfBA3YAyWPEhwLYa6qX7jSY1ck8=
Date: Thu, 7 Apr 2022 17:09:05 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 4.14] vPCI: replace %pp
Message-ID: <Yk7+kTmkVNl4WJWz@Air-de-Roger>
References: <36f65270-8807-323f-c1bd-d14dc742ee74@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <36f65270-8807-323f-c1bd-d14dc742ee74@suse.com>
X-ClientProxiedBy: LO3P123CA0005.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:ba::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfd61e37-be00-43cc-a504-08da18a890d5
X-MS-TrafficTypeDiagnostic: BY5PR03MB4966:EE_
X-Microsoft-Antispam-PRVS: <BY5PR03MB4966BFC827769341DDE3BD158FE69@BY5PR03MB4966.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aXC9JKjRQwvDIATrClgKlCGnQx5ozAcjmWtm3GRsXq3YASEJ7cPsfEImbiMoAv5+Lw1ExgbIikz6jQYzawwSZT3QqnvhDQXK2gLx7OkEU4VCZOtul+mk5ZLnyBiAUVmhRVtkC2ssdMq8BnWe76742Q9PwFktSwbySqxdlRrjJTpD044mwSUVqL2j8zyN9CG62SoSpEmhC2wAvS9RU+G6sHes1iWy80D4LCdwj+WWdE73babp5FvV17hfEvO58uWH8EalTQOX9lutEF+0n+Eor2Cr6Ycu7mV+L4HXOYGnwau4+jjCHi5PqFHgTzQ3mpFgXu4gdqTMt/ysMvF26Pe8Kovp9gZWrn/535+yLgYjbAHsU/fasx2Rs0bR1UlF4KivMd+hXkiYBAJ04PzTriY3r5sscRJfvp6zADeiUbx7V2RipnKwxbrvYxqZpB61c2qEuduedZimSwfrE6uMThngKcxiGaHWbWxYYvA2e8P+nS1CoEuOKDNyNNUj4AM4LnXNHvtRJPdZ43yVU51exDc2XLtZsnlg2oIP5T0ze3WvmRgcmB5PoPDF4lti4LftPQJrarVp91JrRjQEronuwUhGNvLMsTNFDKm+DJp6Yk/E7QxKbGFtDce3HUf9d5xl49rc+nqfwxMX69WFFWdLYIbEYYRPLOYhI02vEIWyE+ov3OC48OYvT2W0pQixEw6vKGjaCr4XTrPRVpPj6ORUt+jjuQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(316002)(82960400001)(85182001)(6916009)(33716001)(2906002)(6486002)(6512007)(9686003)(508600001)(83380400001)(86362001)(5660300002)(6666004)(8936002)(6506007)(26005)(8676002)(66556008)(66946007)(558084003)(66476007)(4326008)(186003)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUpQbFY2TGNoNXlxVlpObCtUVkRaZXZPYkwzamNCSll6anl6Q3lPWWxsalQ1?=
 =?utf-8?B?aGVrS1RGSnhrcUV3eFRWQnR2dmlQZ2IrbWZDem5JZW5UMUdkb1dhb0N2aitI?=
 =?utf-8?B?dVd5Z0NJVFlzTGpHYzZ0SlMvOWlucUZ1YlBlVVd0VFh1emh1TUJINXBEdGxx?=
 =?utf-8?B?UXhLR29ubzdaZVdwNDlxYU9Sb2F0K3JsZHhzK3JsbnRIRTFsb21LVncwZ000?=
 =?utf-8?B?dTJRdUZvcUw3ZTgwRUVWZ1EvRjMxbGNSSE0zMHZtdTBiV1RMY0x1bG1QSjBx?=
 =?utf-8?B?Y2JNSnRPWGx0SlRiOXhwWndTczUzcGp0TFZtME0vRjcySlZRMWMrbHJOd3Z6?=
 =?utf-8?B?WlpTWXNsZTZRSlgvQ3BMSWtvaTF6K2RTZ1pmQ05jcWw4bWU1NTNLQ2lPeGdF?=
 =?utf-8?B?RGxPMFduL01PWTlBOHhJN2FsOGVQUkdObmlSZjB2TDBHKzdjSGVidlVualFx?=
 =?utf-8?B?ZmNtR1VzZXh6U0dqTlRTY3hDYksvUnVjK0tPK3dWbk1SZ0xOZk5uMzNNYUdU?=
 =?utf-8?B?TlZnTTUvR2J6dkZ4aXRtUExHcDB4eHoweGdoRmVveU5sRyt2VDBRY280blFn?=
 =?utf-8?B?TkcyM083aWZzK28vSENsMzN3cEpjbXJKVE5rQUNlOWZuY2NabFRBM1N4Y0FU?=
 =?utf-8?B?YXI0aExKdHlTL1NSV0FVSkZRUkdYc0EybXlpVXNlVm16VTc5eDFOOGVhbldE?=
 =?utf-8?B?VzZvSHltREEwQTJKYksvMDV5dHk0bGJwUm9kcFNSUldiN3F0VXF3SlVaSHFu?=
 =?utf-8?B?ZjBtMWpzSUI2Q3J0S1RSNW9iOVNRTEptNUdvRUIzaXBuQVZ3L1IzR1BhU0tL?=
 =?utf-8?B?TlBycUpLTlV3eE1HSnVQK04ybWR6MGNSMGd1QTBEd005VTNVSy9SUmlxRjVk?=
 =?utf-8?B?WGYvWUY5V3BuQVdqWnZCSnd4SnlxQURNYzhxeVdPaFJ0bm5oOXFydEkyNnoy?=
 =?utf-8?B?bk1jN3VXRnNaUjlqSWVhUlk2QmdOaFRXYUUrYzlJL2lWV1NzdVQzaFNCUkdv?=
 =?utf-8?B?b0dRWkN3UXVwNW1qVmJJRGhNNWIyNTBacHFackl6NW14YjFxcXRlREw0N0R1?=
 =?utf-8?B?TjFQdmE1ZVpyNXNtUWVNYzkweWgzTEdIUjM1ZEFxd1FET2FGcnRaRm41NjdU?=
 =?utf-8?B?c1V0bXFwcno3S1kwQVNMTTl1eGFGKzI4WHp6ZFFsOTFZY0xSVld5emZGYlE4?=
 =?utf-8?B?WTlNbDc1NXlsYUtnMEJCNm54ZEhOYmtMem9pYkpvbXZQUzNrZUZ0RDNody8x?=
 =?utf-8?B?S3ZhdWQyRW5QK2Z2cDlqT3VieVhweHdjamNKcExFMzJKejNzenMvbkFWM0FT?=
 =?utf-8?B?L1lyQndBcTZKRW9tY25NaDgvbnhrVkpQYm93SkdCc2R1UGhrWHNEUzVyc05M?=
 =?utf-8?B?VStnUnBCWTRaV3JlRmJON285Q1RBWHZUTXBjTDVvOVFZYXpuVEJKT05jNTZO?=
 =?utf-8?B?VENuQWxZRlZiTVNNdXIrY1dPK1VkaG5aWi9aUUEyS0RrZkQzM2MrS1dva1Rk?=
 =?utf-8?B?aS9MTU1sS2c3T3NpeHE1ZkVvdU5FWDNlUTRXMUdvOFNlZXJQdnc2R1JpWUJR?=
 =?utf-8?B?TkI3aEhEYmE3WXlUeFRkVmRhamRGWTltUVRoTlJmdk1tTUtMa1J3ejJHNzZt?=
 =?utf-8?B?azRQUU5HM3BsVGRyMG9MQm1YT054QXNjejBpRkRMb2JuR3dFaTdpRjVtUlNR?=
 =?utf-8?B?ZUJJeU50Z1A3L0lwZDRYT1ovWG1KdWZXQ0M5T2Fya1d1VVhiaFR3Z2hmRXpw?=
 =?utf-8?B?NG5qVzBhNGI2OFYrQmFJaU0vVFVaMzVYNTV1MzVkOE9uT1R0V0JSZy9pRUNY?=
 =?utf-8?B?aVh6dTI2NldESncvSEFGaS9jTGRRSFJzbjJDS1Z3eURGeUJxc255cEI0UHdt?=
 =?utf-8?B?djFkVlAyMEY1ZXJxZlFFQ0ppeXl0N1dEVzFIZ0dSeWpwT0JwY09FalZvZGJU?=
 =?utf-8?B?UVAyR0x2RDRjSHprNlovUlBGUC9SMVArQ0VtVnJjVS9HQ2dDWjJNakNOWVB6?=
 =?utf-8?B?WDlZMkd0OGhSYzNrTUxCUkhZUWFBWkxzNkF3RDAyU1RxTWxFdjErS2R4a043?=
 =?utf-8?B?cEVqRnN0bHJOckdqNkd6Q1hEOWxsZzZSV1NCRUI0Snp6aGRBcjRickZSNTdK?=
 =?utf-8?B?Wkc2c2gzYm92UjBFSVNueDJVSEozTWFCK3RIdGdBMG1Da09tUU42VmkwQUVL?=
 =?utf-8?B?ZE1WcXgyNVZCY25idU5EcU9McXlqYVQ3aHVjUmlHekFzQk12TTVaaVJ5bjFo?=
 =?utf-8?B?TWhNbXFkTTFTRWNiMHk4VE9jaUdJVEdPN1FaeTRRbUJXU1RkMCtVREFtNHdi?=
 =?utf-8?B?RGFRNCs1N3UrMlZ6Uk9wQ3pwVTQyVHo3UU0xMC94Y1JTT0M2eTh4SENTRmZt?=
 =?utf-8?Q?9wAt9s9skiyAefkk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dfd61e37-be00-43cc-a504-08da18a890d5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 15:09:09.1401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y99DCDQ/JKVQpp6Hr6MfmresH81sWUSV96+MiBLO/8jLMMPIdL6T4sMby0b09fzFQ8+DcuHiifoeWMLM6JftDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4966
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 05:04:04PM +0200, Jan Beulich wrote:
> 4.14 doesn't know of this format specifier extension yet.
> 
> Fixes: 47188b2fdcc6 ("vpci/msix: fix PBA accesses")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:10:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:10:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300880.513347 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTmW-000470-DH; Thu, 07 Apr 2022 15:10:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300880.513347; Thu, 07 Apr 2022 15:10:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncTmW-00046t-8m; Thu, 07 Apr 2022 15:10:44 +0000
Received: by outflank-mailman (input) for mailman id 300880;
 Thu, 07 Apr 2022 15:10:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncTmU-00046h-Ps; Thu, 07 Apr 2022 15:10:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncTmU-0001ra-Nb; Thu, 07 Apr 2022 15:10:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncTmU-0000PS-6S; Thu, 07 Apr 2022 15:10:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncTmU-0004Mw-5z; Thu, 07 Apr 2022 15:10:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mVN6vvjGT32rXdU7EsPXnn1U8+WbvdY+tCsjAaIGnrM=; b=P48PB2OP3BkK4IaifTn82vHZHj
	t1A1wDCXwVHVRKYbUGNUAXd1Irh6IUS2Hlrn002EP+jK3YHKsInFvktO+12KbCdeoalhSILjR+tZS
	5g+R038PK8shRIB8dC+WPnMN88K2lCWb73JScbszHO4CrfV0hX7OY0YP+i/EmyKVxbbI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169217-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169217: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d4012d50082c2eae2f3cbe7770be13b9227fbc3f
X-Osstest-Versions-That:
    xen=609b8b0153e9bdb4e15be88a8911c6360e13e268
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 15:10:42 +0000

flight 169217 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169217/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d4012d50082c2eae2f3cbe7770be13b9227fbc3f
baseline version:
 xen                  609b8b0153e9bdb4e15be88a8911c6360e13e268

Last test of basis   169210  2022-04-07 07:00:31 Z    0 days
Testing same since   169217  2022-04-07 12:01:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   609b8b0153..d4012d5008  d4012d50082c2eae2f3cbe7770be13b9227fbc3f -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:25:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:25:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300890.513358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU0G-0005wm-Kr; Thu, 07 Apr 2022 15:24:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300890.513358; Thu, 07 Apr 2022 15:24:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU0G-0005wf-Hz; Thu, 07 Apr 2022 15:24:56 +0000
Received: by outflank-mailman (input) for mailman id 300890;
 Thu, 07 Apr 2022 15:24:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4yZA=UR=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ncU0E-0005wZ-AH
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:24:54 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df5d01d5-b686-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:24:53 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id D66A6212CA;
 Thu,  7 Apr 2022 15:24:52 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id ADAE4A3B82;
 Thu,  7 Apr 2022 15:24:52 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 25B6BDA80E; Thu,  7 Apr 2022 17:20:50 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df5d01d5-b686-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649345092;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RtA+SPF4j8BVXsqmszO7xH0OxCICEh+Est/knHN20Pw=;
	b=JdwcskixEmG8Id6CFcHmK2HMPcVcB071Gxs55mSKq7gYvR2Ikd8MNoO/fLtEbVpgdj1eqK
	9zmwivWn67QHHcgD9Kfm5GQ7CXBQeMe5lW9iJ9AGGV3Pl0ul2ocJyd3loaCvdRBmNQxip+
	WgCnpcThcFxRJmTkxC30BSU3q0i1qd4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649345092;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RtA+SPF4j8BVXsqmszO7xH0OxCICEh+Est/knHN20Pw=;
	b=pkLC9VLc/9JNFZ5DsOV/UM/28hXligCH1VLYaRzzl6m3sxWEGPlvl1H8p8FVldpalCYBR6
	DsLUEWMcp0v/ApCw==
Date: Thu, 7 Apr 2022 17:20:49 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open
 coding it
Message-ID: <20220407152049.GH15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-8-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406060516.409838-8-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Wed, Apr 06, 2022 at 08:04:56AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>

As it's a standalone patch I can take it (possibly with other similar
prep btrfs patches) in current development cycle to relieve the
inter-tree dependencies.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:25:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:25:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300893.513369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU0u-0006T6-U9; Thu, 07 Apr 2022 15:25:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300893.513369; Thu, 07 Apr 2022 15:25:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU0u-0006Sz-R4; Thu, 07 Apr 2022 15:25:36 +0000
Received: by outflank-mailman (input) for mailman id 300893;
 Thu, 07 Apr 2022 15:25:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4yZA=UR=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ncU0t-0006Pk-KJ
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:25:35 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f83ab9a8-b686-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:25:35 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id B53392129B;
 Thu,  7 Apr 2022 15:25:34 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id A2CECA3B94;
 Thu,  7 Apr 2022 15:25:34 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 7459CDA80E; Thu,  7 Apr 2022 17:21:32 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f83ab9a8-b686-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649345134;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=u5NLYRb0iRWqH+wp45tMsxWQ+2lcKX7UH+x3jrUc4CM=;
	b=gyRKbvUTSeCHD0kZFeha6b8GtwnfMcBVdpUrcZUXAMFpgjyGa2cKvGcE+1LQgsvJsr0yFR
	VJy4sQoNdJcuIc7oMupD7ITgqoAKAsjuZZusxwRbFTjJc52vRJgP/0hGLJXdzVq3P3r19L
	5WyRvzygj8B2JBXB13wX08lyO4vdhmc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649345134;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=u5NLYRb0iRWqH+wp45tMsxWQ+2lcKX7UH+x3jrUc4CM=;
	b=h4c6BQrPPD9W33KeeEtgIxkffE6SxGamCvLBsxsw2FlmdG/K+M8MV8ruvANXF9Az9aOJRY
	CNJk3HEoegzTiHDg==
Date: Thu, 7 Apr 2022 17:21:32 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 10/27] block: add a bdev_nonrot helper
Message-ID: <20220407152132.GI15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-11-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406060516.409838-11-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Wed, Apr 06, 2022 at 08:04:59AM +0200, Christoph Hellwig wrote:
> Add a helper to check the nonrot flag based on the block_device instead
> of having to poke into the block layer internal request_queue.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/ioctl.c                       | 2 +-
>  drivers/block/loop.c                | 2 +-
>  drivers/md/dm-table.c               | 4 +---
>  drivers/md/md.c                     | 3 +--
>  drivers/md/raid1.c                  | 2 +-
>  drivers/md/raid10.c                 | 2 +-
>  drivers/md/raid5.c                  | 2 +-
>  drivers/target/target_core_file.c   | 3 +--
>  drivers/target/target_core_iblock.c | 2 +-

For

>  fs/btrfs/volumes.c                  | 4 ++--

Acked-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:26:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:26:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300894.513379 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU1F-0006xP-64; Thu, 07 Apr 2022 15:25:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300894.513379; Thu, 07 Apr 2022 15:25:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU1F-0006xI-2v; Thu, 07 Apr 2022 15:25:57 +0000
Received: by outflank-mailman (input) for mailman id 300894;
 Thu, 07 Apr 2022 15:25:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4yZA=UR=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ncU1D-0006Pk-JD
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:25:55 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0428fde2-b687-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:25:55 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id BB87B215FF;
 Thu,  7 Apr 2022 15:25:54 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id A2E13A3BA5;
 Thu,  7 Apr 2022 15:25:54 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 7C344DA80E; Thu,  7 Apr 2022 17:21:52 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0428fde2-b687-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649345154;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Bgv24cnq4wL+/PQXezU/e2ARnHoovKOhXIgsZis+Zv8=;
	b=xtGtLoA1rxTAfbwnyD8y0m1GZXkoG2Eqm/JKAR1yflAQGXCIe+EPKLsQ3Jl3HF1ejkdCzO
	R69fN/3GghEjXF7FLzZ630UM55zcmFGAOi43l86+pog72f9MfM9XFXEk72PJM2lSVIy0eO
	Ar+NvvcjWPRZc9tp6WgYAzpMBH3HwQA=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649345154;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Bgv24cnq4wL+/PQXezU/e2ARnHoovKOhXIgsZis+Zv8=;
	b=J9TTigpMGNAp9ruFfwwGecAvDY029f3E2IK2t7dI3TCObbagdDL5XIR1t0kPQCQDtlPljo
	bs6igqf+zh/8rsAg==
Date: Thu, 7 Apr 2022 17:21:52 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 11/27] block: add a bdev_write_cache helper
Message-ID: <20220407152151.GJ15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-12-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406060516.409838-12-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Wed, Apr 06, 2022 at 08:05:00AM +0200, Christoph Hellwig wrote:
> Add a helper to check the write cache flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/block/rnbd/rnbd-srv.c       | 2 +-
>  drivers/block/xen-blkback/xenbus.c  | 2 +-
>  drivers/target/target_core_iblock.c | 8 ++------

For

>  fs/btrfs/disk-io.c                  | 3 +--

Acked-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:26:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:26:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300901.513391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU24-0007hc-Jt; Thu, 07 Apr 2022 15:26:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300901.513391; Thu, 07 Apr 2022 15:26:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU24-0007hV-Gs; Thu, 07 Apr 2022 15:26:48 +0000
Received: by outflank-mailman (input) for mailman id 300901;
 Thu, 07 Apr 2022 15:26:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4yZA=UR=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ncU22-0007h8-My
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:26:46 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 22662023-b687-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:26:45 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id 7851C1F85E;
 Thu,  7 Apr 2022 15:26:45 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id 5D6D3A3B9B;
 Thu,  7 Apr 2022 15:26:45 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 35565DA80E; Thu,  7 Apr 2022 17:22:43 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22662023-b687-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649345205;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=HY0WGnVyYhCp+LhKaKmQstubuC2NBeDsW4/sLmH6Z8c=;
	b=XoJXkAIgylqQHPJw/RxdnXZhZyl5PP42kkTd2vQs5Kg1qV6D3ZEimN/Ndmez2jDD02c8y/
	8Kt3GvifEuI3376MaNJ/2N1im2t4mIvENdAjGSrIrgJoXtExfV2shXkVVqkhj++pc+sxkE
	nCY7Te6kyLzniSfS/9ZPp+5ltDd/oy0=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649345205;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=HY0WGnVyYhCp+LhKaKmQstubuC2NBeDsW4/sLmH6Z8c=;
	b=tIy2FgiTF5PZUTeuG9JADUiSC1+VAIkjbGxP/lEc71v2qsAsFxGTxeSFScU8FNeVlGcnPr
	Dj41KlwW0MN6N+Cg==
Date: Thu, 7 Apr 2022 17:22:43 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 23/27] block: add a bdev_max_discard_sectors helper
Message-ID: <20220407152243.GK15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-24-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406060516.409838-24-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Wed, Apr 06, 2022 at 08:05:12AM +0200, Christoph Hellwig wrote:
> Add a helper to query the number of sectors support per each discard bio
> based on the block device and use this helper to stop various places from
> poking into the request_queue to see if discard is supported and if so how
> much.  This mirrors what is done e.g. for write zeroes as well.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/blk-core.c                    |  2 +-
>  block/blk-lib.c                     |  2 +-
>  block/ioctl.c                       |  3 +--
>  drivers/block/drbd/drbd_main.c      |  2 +-
>  drivers/block/drbd/drbd_nl.c        | 12 +++++++-----
>  drivers/block/drbd/drbd_receiver.c  |  5 ++---
>  drivers/block/loop.c                |  9 +++------
>  drivers/block/rnbd/rnbd-srv-dev.h   |  6 +-----
>  drivers/block/xen-blkback/xenbus.c  |  2 +-
>  drivers/md/bcache/request.c         |  4 ++--
>  drivers/md/bcache/super.c           |  2 +-
>  drivers/md/bcache/sysfs.c           |  2 +-
>  drivers/md/dm-cache-target.c        |  9 +--------
>  drivers/md/dm-clone-target.c        |  9 +--------
>  drivers/md/dm-io.c                  |  2 +-
>  drivers/md/dm-log-writes.c          |  3 +--
>  drivers/md/dm-raid.c                |  9 ++-------
>  drivers/md/dm-table.c               |  4 +---
>  drivers/md/dm-thin.c                |  9 +--------
>  drivers/md/dm.c                     |  2 +-
>  drivers/md/md-linear.c              |  4 ++--
>  drivers/md/raid0.c                  |  2 +-
>  drivers/md/raid1.c                  |  6 +++---
>  drivers/md/raid10.c                 |  8 ++++----
>  drivers/md/raid5-cache.c            |  2 +-
>  drivers/target/target_core_device.c |  8 +++-----

For

>  fs/btrfs/extent-tree.c              |  4 ++--
>  fs/btrfs/ioctl.c                    |  2 +-

Acked-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:27:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:27:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300903.513402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU2L-00089v-SE; Thu, 07 Apr 2022 15:27:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300903.513402; Thu, 07 Apr 2022 15:27:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU2L-00089o-Ok; Thu, 07 Apr 2022 15:27:05 +0000
Received: by outflank-mailman (input) for mailman id 300903;
 Thu, 07 Apr 2022 15:27:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QPCU=UR=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1ncU2K-0007h8-20
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:27:04 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c8abfed-b687-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:27:03 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id AE08468AFE; Thu,  7 Apr 2022 17:26:59 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c8abfed-b687-11ec-8fbc-03012f2f19d4
Date: Thu, 7 Apr 2022 17:26:59 +0200
From: Christoph Hellwig <hch@lst.de>
To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open
 coding it
Message-ID: <20220407152659.GA15200@lst.de>
References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-8-hch@lst.de> <20220407152049.GH15609@twin.jikos.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220407152049.GH15609@twin.jikos.cz>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Apr 07, 2022 at 05:20:49PM +0200, David Sterba wrote:
> On Wed, Apr 06, 2022 at 08:04:56AM +0200, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> As it's a standalone patch I can take it (possibly with other similar
> prep btrfs patches) in current development cycle to relieve the
> inter-tree dependencies.

Unless there's a conflict in other btrfs patches it would probably be
easiest to merge everything through the block tree.


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:30:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:30:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300911.513413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU5n-0001av-CX; Thu, 07 Apr 2022 15:30:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300911.513413; Thu, 07 Apr 2022 15:30:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU5n-0001ao-8t; Thu, 07 Apr 2022 15:30:39 +0000
Received: by outflank-mailman (input) for mailman id 300911;
 Thu, 07 Apr 2022 15:30:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4yZA=UR=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ncU5m-0001ai-7x
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:30:38 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac6de6c3-b687-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:30:37 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id E56341F85A;
 Thu,  7 Apr 2022 15:30:36 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id AE7A3A3B94;
 Thu,  7 Apr 2022 15:30:36 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 5C928DA80E; Thu,  7 Apr 2022 17:26:34 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac6de6c3-b687-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649345436;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=zPq01JLA6dLoXnFchjjFxJhIcKHBhEdkrZLnR4TbLUY=;
	b=arXCGHubFNDMJivA50IVAh5E18SENgaJ+8psB29O+dYSp9GznJDHN9eBNpNqVEEypC+xPt
	YsOhdRjVTg1mFsMpWqZ4oNaVAGZnjLyClojrRdjsUuitokjLJy7oqe8RxGnlNpP0HUVyi6
	8uSBZYdSoqUowgEJK8P6YGm7aUVWSbo=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649345436;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=zPq01JLA6dLoXnFchjjFxJhIcKHBhEdkrZLnR4TbLUY=;
	b=+RoHDuxhi8eXdx1m79jW3LC9fhbmevwd72sFBk44Osas+gmEsPN5qSbgbwIpqCBgrNluyA
	EXeawVVGeX85rgBw==
Date: Thu, 7 Apr 2022 17:26:34 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 24/27] block: add a bdev_discard_granularity helper
Message-ID: <20220407152634.GL15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-25-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406060516.409838-25-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Wed, Apr 06, 2022 at 08:05:13AM +0200, Christoph Hellwig wrote:
> Abstract away implementation details from file systems by providing a
> block_device based helper to retreive the discard granularity.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/blk-lib.c                     |  5 ++---
>  drivers/block/drbd/drbd_nl.c        |  9 +++++----
>  drivers/block/drbd/drbd_receiver.c  |  3 +--
>  drivers/block/loop.c                |  2 +-
>  drivers/target/target_core_device.c |  3 +--

For

>  fs/btrfs/ioctl.c                    | 12 ++++--------

Acked-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:31:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:31:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300913.513424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU69-00023N-L7; Thu, 07 Apr 2022 15:31:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300913.513424; Thu, 07 Apr 2022 15:31:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncU69-00023G-HR; Thu, 07 Apr 2022 15:31:01 +0000
Received: by outflank-mailman (input) for mailman id 300913;
 Thu, 07 Apr 2022 15:31:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4yZA=UR=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ncU68-0001ai-6Q
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:31:00 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b9a72019-b687-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:30:59 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id 34AC9215FE;
 Thu,  7 Apr 2022 15:30:59 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id 19364A3B83;
 Thu,  7 Apr 2022 15:30:59 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id A6C86DA80E; Thu,  7 Apr 2022 17:26:56 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9a72019-b687-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649345459;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=VK52HHYwZ5mydc6ONgZ3weVRrNtBzOOpSIr7pOvXQbs=;
	b=WySqupirn7YZPnIWLV0GfVAqxihpYRle8XEAkyNVF3WBqDMBwi92kUG3G7Geq80fpEpqDG
	ac7ABA9wFAVhQVApAGDNJmbt/DMKsm4fE53BT+WEDXzbauuxegcpY8cjYEPD+30zCAK/0V
	/KcfIrKcEqFeLeaqKdylieoJrRuFiL8=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649345459;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=VK52HHYwZ5mydc6ONgZ3weVRrNtBzOOpSIr7pOvXQbs=;
	b=dPYi+hdX0iWuGGA7k7dxuydFXSe1+2WyOjXtxXeAslnPVSFPemFb/xuBKsBNhRAOcY4W1X
	dBEDeLvzeSqw+rCw==
Date: Thu, 7 Apr 2022 17:26:56 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from
 REQ_OP_DISCARD
Message-ID: <20220407152656.GM15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-27-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406060516.409838-27-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Wed, Apr 06, 2022 at 08:05:15AM +0200, Christoph Hellwig wrote:
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint.  Fully split the limits and helper
> infrastructure to make the separation more clear.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/blk-core.c                    |  2 +-
>  block/blk-lib.c                     | 64 ++++++++++++++++++++---------
>  block/blk-mq-debugfs.c              |  1 -
>  block/blk-settings.c                | 16 +++++++-
>  block/fops.c                        |  2 +-
>  block/ioctl.c                       | 43 +++++++++++++++----
>  drivers/block/drbd/drbd_receiver.c  |  5 ++-
>  drivers/block/rnbd/rnbd-clt.c       |  4 +-
>  drivers/block/rnbd/rnbd-srv-dev.h   |  2 +-
>  drivers/block/xen-blkback/blkback.c | 15 +++----
>  drivers/block/xen-blkback/xenbus.c  |  5 +--
>  drivers/block/xen-blkfront.c        |  5 ++-
>  drivers/md/bcache/alloc.c           |  2 +-
>  drivers/md/dm-table.c               |  8 ++--
>  drivers/md/dm-thin.c                |  4 +-
>  drivers/md/md.c                     |  2 +-
>  drivers/md/raid5-cache.c            |  6 +--
>  drivers/mmc/core/queue.c            |  2 +-
>  drivers/nvme/target/io-cmd-bdev.c   |  2 +-
>  drivers/target/target_core_file.c   |  2 +-
>  drivers/target/target_core_iblock.c |  2 +-

For

>  fs/btrfs/extent-tree.c              |  4 +-

Acked-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:38:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:38:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300919.513435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUDY-0003Al-Cm; Thu, 07 Apr 2022 15:38:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300919.513435; Thu, 07 Apr 2022 15:38:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUDY-0003Ae-9f; Thu, 07 Apr 2022 15:38:40 +0000
Received: by outflank-mailman (input) for mailman id 300919;
 Thu, 07 Apr 2022 15:38:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncUDX-0003AY-0v
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:38:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncUDV-0002My-Jm; Thu, 07 Apr 2022 15:38:37 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.7.236.16])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncUDV-0001Xr-DL; Thu, 07 Apr 2022 15:38:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=g4iOFFcZEG1xgD3lc4YglNfcxGkk9zA7lYLzt1ZOiKM=; b=cQiXHOwGxR+CZKUhfFZSMboF75
	/qY+4+FtCUWjbK4o/xt/cYO9+tDkE6hf2Br1y3Mummv8mcCFxb5JmtBMCgfB8eJuKrNChjHvbKm/T
	xiy4cutwKERqJ3WDmarZgwF7RV2R6+vtXWvYm9alQXqXZH8UGu31QzDFAQRmQdKMT/Qw=;
Message-ID: <7ff80bc6-5937-43aa-784b-fbba016bcfe3@xen.org>
Date: Thu, 7 Apr 2022 16:38:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH early-RFC 4/5] xen/arm: mm: Rework switch_ttbr()
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "marco.solieri@minervasys.tech" <marco.solieri@minervasys.tech>,
 "lucmiccio@gmail.com" <lucmiccio@gmail.com>, Julien Grall
 <jgrall@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220309112048.17377-1-julien@xen.org>
 <20220309112048.17377-5-julien@xen.org>
 <140E78FF-8281-48BA-BE13-C4B3E12F34A5@arm.com>
 <9673f201-080b-8800-65a2-144d21b030fd@xen.org>
 <7069C935-A275-4D1A-80EF-C20DE1D3103C@arm.com>
 <284b300e-d400-4bd7-0b0e-aa53983d6ee8@xen.org>
 <099CD8F1-C92A-4402-897F-538821AD66EE@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <099CD8F1-C92A-4402-897F-538821AD66EE@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 25/03/2022 14:48, Bertrand Marquis wrote:
>> On 25 Mar 2022, at 15:42, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Bertrand,
>>
>> On 25/03/2022 14:35, Bertrand Marquis wrote:
>>>> On 25 Mar 2022, at 15:24, Julien Grall <julien@xen.org> wrote:
>>>> On 25/03/2022 13:47, Bertrand Marquis wrote:
>>>>> Hi Julien,
>>>>
>>>> Hi Bertrand,
>>>>
>>>>>> On 9 Mar 2022, at 12:20, Julien Grall <julien@xen.org> wrote:
>>>>>>
>>>>>> From: Julien Grall <jgrall@amazon.com>
>>>>>>
>>>>>> At the moment, switch_ttbr() is switching the TTBR whilst the MMU is
>>>>>> still on.
>>>>>>
>>>>>> Switching TTBR is like replacing existing mappings with new ones. So
>>>>>> we need to follow the break-before-make sequence.
>>>>>>
>>>>>> In this case, it means the MMU needs to be switched off while the
>>>>>> TTBR is updated. In order to disable the MMU, we need to first
>>>>>> jump to an identity mapping.
>>>>>>
>>>>>> Rename switch_ttbr() to switch_ttbr_id() and create an helper on
>>>>>> top to temporary map the identity mapping and call switch_ttbr()
>>>>>> via the identity address.
>>>>>>
>>>>>> switch_ttbr_id() is now reworked to temporarily turn off the MMU
>>>>>> before updating the TTBR.
>>>>>>
>>>>>> We also need to make sure the helper switch_ttbr() is part of the
>>>>>> identity mapping. So move _end_boot past it.
>>>>>>
>>>>>> Take the opportunity to instruction cache flush as the operation is
>>>>>> only necessary when the memory is updated.
>>>>> Your code is actually remove the instruction cache invalidation so
>>>>> this sentence is a bit misleading.
>>>>
>>>> I forgot to add the word "remove" in the sentence.
>>> Ok (my sentence was also wrong by the way)
>>>>
>>>>> Also an open question: shouldn’t we flush the data cache ?
>>>> Do you mean clean/invalidate to PoC/PoU? Something else?
>>> Yes, probably to PoU.
>>>>
>>>>> As we switch from one TTBR to an other, there might be some data
>>>>> in the cache dependent that could be flushed while the MMU is off
>>>>
>>>> I am a bit confused. Those flush could also happen with the MMU on. So how turning off the MMU would result to a problem? Note that the data cache is still enabled during the switch.
>>> If the first level of cache is VIPT and we turn off the MMU, I am wondering if this could not create troubles and could require the cache to be flushed before turning the MMU off.
>> My reading of the Arm Arm (D5.11.1 "Data and unified caches" ARM DDI 0487F.c) suggests the data cache is always PIPT.
> 
> You are right, only the instruction cache is VIPT.
> So the problem most probably does not exist.

As discussed yesterda, I tweaked a bit switch_ttbr(). Below the version 
I plan to use:

         /* 1) Ensure any previous read/write have completed */
         dsb   sy /* XXX: Can this be a ish? */
         isb

         /* 2) Turn off MMU */
         mrs    x1, SCTLR_EL2
         bic    x1, x1, #SCTLR_Axx_ELx_M
         msr    SCTLR_EL2, x1
         isb

         /*
          * 3) Flush the TLBs.
          * See asm/arm64/flushtlb.h for the explanation of the sequence.
          */
         dsb   nshst
         tlbi  alle2
         dsb   nsh
         isb

         /* 4) Update the TTBR */
         msr   TTBR0_EL2, x0
         isb

         /* 5) Turn on the MMU */
         mrs   x1, SCTLR_EL2
         orr   x1, x1, #SCTLR_Axx_ELx_M  /* Enable MMU */
         msr   SCTLR_EL2, x1
         isb

         ret

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:40:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:40:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300923.513446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUFh-0004YB-QG; Thu, 07 Apr 2022 15:40:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300923.513446; Thu, 07 Apr 2022 15:40:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUFh-0004Y4-Mr; Thu, 07 Apr 2022 15:40:53 +0000
Received: by outflank-mailman (input) for mailman id 300923;
 Thu, 07 Apr 2022 15:40:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mzit=UR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ncUFf-0004Xu-Qr
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:40:52 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1a06e212-b689-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 17:40:50 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3C7A121601;
 Thu,  7 Apr 2022 15:40:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D2D213A66;
 Thu,  7 Apr 2022 15:40:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id C2GcBQIGT2JndgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 07 Apr 2022 15:40:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a06e212-b689-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649346050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=WmMQRF8GDKs+n1pSDhCsYjhWRKXUz2BWsXbXtBibKGQ=;
	b=ikgdq04eNa4HSQOVMGByLkHUdtTUzTvVVnRJ3XOO4CVEzXF4H/Pet4IRaYYZVaRIZbbnA5
	LQ6z7yeKkcKIsDOHZtlsthlJbC27E/FJi7FsnbcJXVRIhppmDxeqJnoQx/XilR7u/A9Qmy
	KBxYRy6ddQZNMULViCHQg9RDHRZ8/HY=
Message-ID: <3699fe77-68cc-d6f0-8614-182f90741531@suse.com>
Date: Thu, 7 Apr 2022 17:40:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>
References: <20220331070755.10894-1-jgross@suse.com>
 <Yk74172+jHIn4PJW@perard.uk.xensource.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] tools/libs/light: update xenstore entry when setting max
 domain memory
In-Reply-To: <Yk74172+jHIn4PJW@perard.uk.xensource.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------bn0oLX7TcYRT1h0Sb2oC8mtb"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------bn0oLX7TcYRT1h0Sb2oC8mtb
Content-Type: multipart/mixed; boundary="------------D8Vm4tA0Dt01EkUZzsRtc2Am";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>
Message-ID: <3699fe77-68cc-d6f0-8614-182f90741531@suse.com>
Subject: Re: [PATCH] tools/libs/light: update xenstore entry when setting max
 domain memory
References: <20220331070755.10894-1-jgross@suse.com>
 <Yk74172+jHIn4PJW@perard.uk.xensource.com>
In-Reply-To: <Yk74172+jHIn4PJW@perard.uk.xensource.com>

--------------D8Vm4tA0Dt01EkUZzsRtc2Am
Content-Type: multipart/mixed; boundary="------------0vLbkL00ggIurmhGBdhL06RV"

--------------0vLbkL00ggIurmhGBdhL06RV
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDQuMjIgMTY6NDQsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBUaHUsIE1h
ciAzMSwgMjAyMiBhdCAwOTowNzo1NUFNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
Pj4gbGlieGxfZG9tYWluX3NldG1heG1lbSgpIHNob3VsZCB1cGRhdGUgdGhlIGRvbWFpbidz
IG1lbW9yeS9zdGF0aWMtbWF4DQo+PiBYZW5zdG9yZSBub2RlLCBhcyBvdGhlcndpc2UgInhs
IG1lbS1zZXQiIHdvbid0IGJlIGFibGUgdG8gc2V0IHRoZQ0KPj4gbWVtb3J5IHNpemUgdG8g
dGhlIG5ldyBtYXhpbXVtLg0KPiANCj4gYHhsIG1lbS1zZXRgIGRvZXNuJ3QgY2FsbCBsaWJ4
bF9kb21haW5fc2V0bWF4bWVtKCksIGJ1dCBjYWxscw0KPiBsaWJ4bF9zZXRfbWVtb3J5X3Rh
cmdldCgpLg0KDQpDb3JyZWN0LiBBbmQgaXQgcmVmdXNlcyB0byBkbyBzbyB3aGVuIG1lbW9y
eS9zdGF0aWMtbWF4IGlzIGJlbG93IHRoZQ0KbmV3IG1lbW9yeSBzaXplIHRvIGJlIHNldC4N
Cg0KPiANCj4gT3IgbWF5YmUgeW91IGFyZSBzcGVha2luZyBhYm91dCBgeGwgbWVtLW1heGAg
Zm9sbG93ZWQgYnkgYHhsIG1lbS1zZXRgPw0KPiBJbiB0aGlzIGNhc2UsIGl0IGlzIGRvY3Vt
ZW50ZWQgaW4gYG1hbiAxIHhsYCB0aGF0IGBtZW0tbWF4YCBoYXMgbm8NCj4gZWZmZWN0IHRv
IGBtZW0tc2V0YC4NCg0KV2hlbiBoYXZpbmcgZS5nLiBhIGRvbWFpbiB3aXRoIDFHIG9mIG1h
eG1lbSwgdGhlbiBjYWxsaW5nDQoNCnhsIG1lbS1tYXggPGRvbWFpbj4gMjA0OA0KDQppdCBz
aG91bGQgYmUgcG9zc2libGUgdG8gdGhlbiBkbw0KDQp4bCBtZW0tc2V0IDxkb21haW4+IDIw
NDgNCg0KYnV0IHRoaXMgaXNuJ3QgcG9zc2libGUsIGFzIHhsIG1lbS1zZXQgd2lsbCBsb29r
IGF0IHRoZSBtZW1vcnkvc3RhdGljLW1heA0Kbm9kZSBvZiB0aGUgZG9tYWluIGFuZCByZWZ1
c2UgdG8gZG8gdGhlIHNldHRpbmcgaWYgaXQgaGFzIGEgdG9vIGxvdw0KdmFsdWUsIHdoaWNo
IGlzIHRoZSBjYXNlIHRvZGF5Lg0KDQo+IA0KPiBxdW90ZSBmcm9tIG1hbiwgYWJvdXQgYHhs
IG1lbS1tYXhgOg0KPiAgICAgIEl0IGlzIGFsbG93ZWQgdG8gYmUgaGlnaGVyIHRoYW4gdGhl
IGNvbmZpZ3VyZWQgbWF4aW11bQ0KPiAgICAgIG1lbW9yeSBzaXplIG9mIHRoZSBkb21haW4g
KEI8bWF4bWVtPiBwYXJhbWV0ZXIgaW4gdGhlIGRvbWFpbidzDQo+ICAgICAgY29uZmlndXJh
dGlvbikuIE5vdGUgaG93ZXZlciB0aGF0IHRoZSBpbml0aWFsIEI8bWF4bWVtPiB2YWx1ZSBp
cyBzdGlsbA0KPiAgICAgIHVzZWQgYXMgYW4gdXBwZXIgbGltaXQgZm9yIEI8eGwgbWVtLXNl
dD4uICBBbHNvIG5vdGUgdGhhdCBjYWxsaW5nIEI8eGwNCj4gICAgICBtZW0tc2V0PiB3aWxs
IHJlc2V0IHRoaXMgdmFsdWUuDQoNCk9oLCB0aGlzIHNob3VsZCB0aGVuIGJlIGFkYXB0ZWQu
IFRvZGF5IGhvdHBsdWdnaW5nIG1lbW9yeSBpcyBqdXN0DQphIG1lc3MgYXMgeW91IG5lZWQg
dG86DQoNCnhsIG1lbS1tYXggPGRvbWlkPiA8dmFsdWU+DQp4ZW5zdG9yZS13cml0ZSAvbG9j
YWwvZG9tYWluLzxkb21pZD4vbWVtb3J5L3N0YXRpYy1tYXggJCgoPHZhbHVlPiAqIDEwMjQp
KQ0KeGwgbWVtLXNldCA8ZG9taWQ+IDx2YWx1ZT4NCg0KPiANCj4+IFNpZ25lZC1vZmYtYnk6
IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gICB0b29scy9s
aWJzL2xpZ2h0L2xpYnhsX21lbS5jIHwgOSArKysrKysrKysNCj4+ICAgMSBmaWxlIGNoYW5n
ZWQsIDkgaW5zZXJ0aW9ucygrKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xp
Z2h0L2xpYnhsX21lbS5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9tZW0uYw0KPj4gaW5k
ZXggYzczOWQwMGYzOS4uMmY0ZjlkNGE0YSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2xpYnMv
bGlnaHQvbGlieGxfbWVtLmMNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfbWVt
LmMNCj4+IEBAIC04Miw2ICs4MiwxNSBAQCBpbnQgbGlieGxfZG9tYWluX3NldG1heG1lbShs
aWJ4bF9jdHggKmN0eCwgdWludDMyX3QgZG9taWQsIHVpbnQ2NF90IG1heF9tZW1rYikNCj4g
DQo+IFRoZXJlJ3MgYSBjb21tZW50IG9uIHRoaXMgZnVuY3Rpb25zOg0KPiAgICAgIC8qDQo+
ICAgICAgICogU2V0IHRoZSBtYXhpbXVtIG1lbW9yeSBzaXplIG9mIHRoZSBkb21haW4gaW4g
dGhlIGh5cGVydmlzb3IuIFRoZXJlIGlzIG5vDQo+ICAgICAgICogY2hhbmdlIG9mIHRoZSBj
dXJyZW50IG1lbW9yeSBzaXplIGludm9sdmVkLiBUaGUgc3BlY2lmaWVkIG1lbW9yeSBzaXpl
IGNhbg0KPiAgICAgICAqIGV2ZW4gYmUgYWJvdmUgdGhlIGNvbmZpZ3VyZWQgbWF4bWVtIHNp
emUgb2YgdGhlIGRvbWFpbiwgYnV0IHRoZSByZWxhdGVkDQo+ICAgICAgICogWGVuc3RvcmUg
ZW50cnkgbWVtb3J5L3N0YXRpYy1tYXggaXNuJ3QgbW9kaWZpZWQhDQo+ICAgICAgICovDQo+
ICAgICAgaW50IGxpYnhsX2RvbWFpbl9zZXRtYXhtZW0obGlieGxfY3R4ICpjdHgsIHVpbnQz
Ml90IGRvbWlkLCB1aW50NjRfdCBtYXhfbWVta2IpDQo+IA0KPiBTbyBpdCB3YXMgYWxyZWFk
eSBrbm93biB0aGF0ICJzdGF0aWMtbWF4IiB3YXNuJ3Qgc2V0Lg0KPiBBdCB0aGUgdmVyeSBs
ZWFzdCwgdGhpcyBjb21tZW50IG5lZWRzIHVwZGF0aW5nLg0KDQpZZXMuDQoNCj4gDQo+PiAg
ICAgICAgICAgZ290byBvdXQ7DQo+PiAgICAgICB9DQo+PiAgIA0KPj4gKyAgICByYyA9IGxp
YnhsX194c19wcmludGYoZ2MsIFhCVF9OVUxMLA0KPj4gKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgR0NTUFJJTlRGKCIlcy9tZW1vcnkvc3RhdGljLW1heCIsIGRvbXBhdGgpLA0KPj4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgIiUiUFJJdTY0LCBtYXhfbWVta2IpOw0KPj4g
KyAgICBpZiAocmMgIT0gMCkgew0KPj4gKyAgICAgICAgTE9HRUQoRVJST1IsIGRvbWlkLCAi
Q291bGRuJ3Qgc2V0ICVzL21lbW9yeS9zdGF0aWMtbWF4LCByYz0lZFxuIiwNCj4+ICsgICAg
ICAgICAgICAgIGRvbXBhdGgsIHJjKTsNCj4+ICsgICAgICAgIGdvdG8gb3V0Ow0KPiANCj4g
DQo+IA0KPiBTbywgSSBkb24ndCBrbm93IHdoZXRoZXIgaW5jcmVhc2luZyAic3RhdGljLW1h
eCIgaXMgZmluZSBvciBub3QsIGJ1dA0KPiBhY2NvcmRpbmcgdG8gdGhlIGRvY3VtZW50YXRp
b24sIGl0IGlzbid0IGV4cGVjdGVkLg0KPiANCj4gSXMgYSBndWVzdCBmaW5lIHdpdGggInN0
YXRpYy1tYXgiIGJlZW4gY2hhbmdlZD8NCg0KTm9ybWFsbHkgaXQgZG9lc24ndCBjYXJlIGF0
IGFsbC4NCg0KPiANCj4gSWYgeWVzLCB0aGVyZSdzIGRvY3VtZW50YXRpb24gYW5kIGNvbW1l
bnRzIHRoYXQgbmVlZHMgdG8gY2hhbmdlIHdpdGggdGhlDQo+IGNvZGUgY2hhbmdlLg0KDQpJ
IGFncmVlLiBXaWxsIGRvIHNvLg0KDQoNCkp1ZXJnZW4NCg==
--------------0vLbkL00ggIurmhGBdhL06RV
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0vLbkL00ggIurmhGBdhL06RV--

--------------D8Vm4tA0Dt01EkUZzsRtc2Am--

--------------bn0oLX7TcYRT1h0Sb2oC8mtb
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJPBgEFAwAAAAAACgkQsN6d1ii/Ey+Z
qwf7B848NKg7K1WnD1HRRZD62Qn3BJ6dz8UU3K0LA+D3ofrZeiaGp2haCZJjuvH/XjVSewI6pDkM
ejOJAULb+Oldtm4lkJEj3jZ693etBKEN75MtxIoyrQmfpC4t1K2VhXhm2zVoKkEQHYrWy27NXIuD
w7AIZjHpSM4yNI3jKXCixIxbBdzDtvt2ZhXj14+OwowifiLaUlAvjR6yM//MbpH1RJ4D8F7LuqMA
cbR3CBHNWL7qzV+bFAz8zsSxU+gQOWD5/D1xxYobyFBWYCsTFuMMpnsq17LtVv2IdxyP+2fho0WS
t+ekevYN2Tt0bDLSx2JRHa7/7C2RZbUfjRE+3ZF2aA==
=+V5w
-----END PGP SIGNATURE-----

--------------bn0oLX7TcYRT1h0Sb2oC8mtb--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 15:44:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 15:44:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300928.513456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUJ6-0005EF-DE; Thu, 07 Apr 2022 15:44:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300928.513456; Thu, 07 Apr 2022 15:44:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUJ6-0005E8-AC; Thu, 07 Apr 2022 15:44:24 +0000
Received: by outflank-mailman (input) for mailman id 300928;
 Thu, 07 Apr 2022 15:44:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E9KF=UR=citrix.com=prvs=0897b442a=ross.lagerwall@srs-se1.protection.inumbo.net>)
 id 1ncUJ5-0005E2-2E
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:44:23 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 967ec1b2-b689-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 17:44:21 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 967ec1b2-b689-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649346261;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=6uyf1+YGGVGpV5zOfNWYZNyYmjT26kg3SBpomHFwZ7Q=;
  b=E+i4DP25dCEgBwoHLZ2JnluEgv4RNhcGioFNQIQC/2BTU7xKslcfh5WC
   obMLn0s58mP74Mb/HCQAXRj5UfU8qNc3y69Ob6ZSkc8WxDUCMYk799BUr
   +702ix9+VNkPBQKNDxubG4c76BZg64ddHj5VDCG90ExEswnDWEswRE5jV
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70682955
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eP1Me682pNkDedtlFCbSDrUDRX6TJUtcMsCJ2f8bNWPcYEJGY0x3m
 2seD2mBM6yIYmGkLY9/aou//BkHuZfRzd4wHlBu+Ss8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YDmW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYbsbyUCfYr9pOU+fxh4Oh1vAJBW0rCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYoWomyTjWAOw5SJTHa67L+cVZzHE7gcUm8fP2O
 JJHOWA+MUmojxtnF0wQN4Azm8uS1lr2KSVlrmjPnLUuyj2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkWM9GVxD6t+3ellOjJ2y/2MKoRE7ui//Isn1yXxUQUEhQdUVb9qv684ma8Ud9CL
 00f+gI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAOHKr+dvG2Zsj
 AXQ2Yq0W3o/69V5VE5x6J+O8RWQEmsyHFMDRgMFbSI58uTesKs820enoslYLIa5idj8GDfVy
 j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNPdTA1LTN0RpXwG91pHGlt
 WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43NzgbbxHQsFJG9eFoSfLkWVsDNdWfhoB3iEsI2KBX
 aMrkVkNjKK/xVPzBUONX6q/Ct4x0Y/rHsn/W/bfY7JmO8YtJVXXoXw+OhHJhggBdXTAd4llZ
 P93lu72Ux4n5VlPlmLqF4/xL5d1rszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRt8u5TPHu2
 48HbaOikkwHOMWnO3W/2dNDfDgicClgbbir+pM/SwJ2Clc/cI3XI6SKmu1Jlk0Mt/k9q9okC
 VnhAhQIlwel3SSvxMfjQikLVY4DlK1X9BoTFSctIUypyz4kZ4Ou570YbJw5Yf8s8+kL8BK+Z
 6BtlxmoahiXdgn6xg==
IronPort-HdrOrdr: A9a23:btlffK5fGIxiudkNIQPXwCbXdLJyesId70hD6qm+c20uTiX4rb
 HSoB1/73XJYVkqKRcdcLy7Sc69qDbnhPpICOoqTNWftWvdyRKVxehZhOOIrlHd8m/Fh4tgPM
 xbAtBD4bPLfCNHZAXBjjVQ0exO/DBKysCVrNab6WxsQ0VLUshbnnlEIzfeK1ZxQgZeA5o/Cd
 6z2uprzgDQBUg/X4CDHX8CUPHEp9rX0LTcQTBDKSIGxWC1/EyVAJiTKWno4v7WaVI/oosfzQ
 ==
X-IronPort-AV: E=Sophos;i="5.90,242,1643691600"; 
   d="scan'208";a="70682955"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fw9FNh8iApjWXIGYXYv11VCegtFpLsh4KsyW6MTQVhMUs9GQcRA4NKkJ/h0dT+IrtoceWyB1fnV2WPX/38P3jxV93nBUI3E2vF/1ssshuwxDEx+3iNVgshd9yYp/iRFtRtyaetPP0EfkBE5ly1wwy/+rnAeWlqZRnj+AA/gY3TWhmVk/4RId6AxDbozAFZR2c88DqwvJvEpoS9E9ZuAgjQP1QAlAd2flHPM/iTBGk22l9C2y8Wg2JYLHILPBZ/Rk4LYDjOHWvcmhxhTpriCNEI6dhQFgm1FQm7oEzPmFvWfJ2V1d2OWoypVWuUTd0RJ9sX/DT8Wjml57wYch60rVeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RJSCYQC13VBjLksu7bWsgiNW2ZBpgAQuRX+6zZqKSvo=;
 b=EP/t3eemlMUKvcJ4HszO5ysVWpXiV0dT5zcOIHcrpRDkESyjly8cWGyhrJyyUnjky77mX+NsKoGCk9P/oXZe4MylqXqqz/4MufffPjgR7HMcHfAYHFiuRCxBdjKOtF4wI/qpAGU4LMmVlBznid5wmgc2werjnIdGc1zRWKubBKDLiQnV7KnGiZIuT2BM/jGb+PDmtIcn39VLDqNZa9WaRwcWSoutju0NtjBh+huv935NkbS7oCCWXre1qeOtLO9KubgY2v01BdBnoiubud415jy/RWUtXIeqSHVVR5mOK+bfhRoQuWUF0UnEB/WTibLH7xxefUrTyuG5NIuwpNDtRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RJSCYQC13VBjLksu7bWsgiNW2ZBpgAQuRX+6zZqKSvo=;
 b=IcMOXVuFRoM3rj3crzRRZNLNHGr/RPo6GckiOSSBdKqO7N6UmVHb2GjiG6kY1XeY7KVmBvPiVek2G+PPPBh1wDYG+PoEODj7eAWvBUqu0qCoIbv93BrcdKExVMceHzXYEFrh0K2mxKtuUPOkXIwLoCNuuN97VqfBVZIhnLx9wTY=
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Konrad
 Wilk" <konrad.wilk@oracle.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"Wei Liu" <wl@xen.org>, Bjoern Doebel <doebel@amazon.de>
Subject: Re: [PATCH v3] livepatch: account for patch offset when applying NOP
 patch
Thread-Topic: [PATCH v3] livepatch: account for patch offset when applying NOP
 patch
Thread-Index: AQHYRMuYkv/j9QPlc0OOPsJ/our1NqzZJyyAgAAFroCAC27ZFg==
Date: Thu, 7 Apr 2022 15:44:16 +0000
Message-ID: <PH0PR03MB638290EA5503FE0FED792C44F0E69@PH0PR03MB6382.namprd03.prod.outlook.com>
References: <8db632ef-9d9c-d17a-54fd-49912d88d599@suse.com>
 <YkVko/vqhfAfS5Jb@Air-de-Roger>
 <ef884c3c-26b4-1bde-9344-aa9be30c1cbc@suse.com>
In-Reply-To: <ef884c3c-26b4-1bde-9344-aa9be30c1cbc@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d5ff6291-9a26-4620-ecf8-08da18ad78d8
x-ms-traffictypediagnostic: SN6PR03MB4096:EE_
x-microsoft-antispam-prvs: <SN6PR03MB4096D2C7283FBEBE9DFFD401F0E69@SN6PR03MB4096.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: cMCWUcPsqL8EDelbFBzatzzVS9/M2NwkDI/rpLI+bbff27M1uL61WqPmztvHFtBATuH7YtryGasBDW0GAypK95bQiv1JH1qEMYPr8YRoimX6llDfPPf8251n1dqjBi8J4izMX9sQFUcwNAMpUaW7xJ2UofrNm0txSaWHbi1mu7+i6kAm36vG9uV2rHZh0nDSMe1WjAjSx3cbcOpHGsPKEbf14V1lEcpXYzx+2gyykdKqAJ8xb/DdErHV6MES7Ja4e20QH/YGRRpSmqwjj/9RX3V1Mf6MFElEcRdKTXUslX6t07JaTgwXxRk9LnJVo7Vzfwh3ymMjPrjpIZkom7dEFDr7a28WFQDDqqQqoETVnLmtDPehA6LIBADPf+a8pUmglHyuEugfqrxX4jWWyhvfTcRQ/dAv0nTOMOHRvvIgZhUYIfupBgb0X8P1y9qPEpPoZbmFN6Qh+aDtZWEQstDy3jYEWK+xuP6vv1U5bmBftBUFhymREpboeoouhBf/7x3vaK9XjVAA57MTBe1Y2ZJBce4mZiYOjLUDOy4AZXxLat20Gqt14zgm4DYX4bksZHLtAPoS0wS+1oUYbUDSebRkqZnCHbaAbGm7MbrP2sGeuDEmRkhz/GpsskIJsT8kop0oGXxlO9W51OnhgwDT7lstFVZb3mdlyg8oNKU0QwuuHfv8GnuskJ+YmcWI2BQK2wcSh4EEmEASZsrgrGaRyVqqMA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(508600001)(5660300002)(66556008)(44832011)(91956017)(66946007)(26005)(186003)(64756008)(66446008)(66476007)(38100700002)(4326008)(122000001)(76116006)(8676002)(71200400001)(82960400001)(110136005)(15650500001)(8936002)(7696005)(2906002)(54906003)(55016003)(9686003)(6506007)(53546011)(52536014)(83380400001)(86362001)(6636002)(316002)(33656002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Z16kSkf0nuPVOKH86Gb3qzRLQMv3eE6aBqj2CnYbrHFvSpPAs17Tt/wYkw?=
 =?iso-8859-1?Q?wbEepQEEO337BY0eIkYSDEe9O4B6Qh4m1lQ/Ts5sZHh2s9q5vhQCE7jYMs?=
 =?iso-8859-1?Q?S1Eq8zKmFCvmRJQLNLAmk/nJzAepZrZCswQUtEA8IiCQvcwz6e4i/VqECd?=
 =?iso-8859-1?Q?UoCRhqD46zfFrJqEpkZ3GPBaMvsLmSRBvuxF244Nm0z/C3IQoglQWizaJj?=
 =?iso-8859-1?Q?lWsjBw/LasZ4CaHjRtgaiE8Bngd27o9U7Ag/HGMlCNWyGPyUa1V/jFHO2R?=
 =?iso-8859-1?Q?bpyrmLCYthZug4DJ1Fn7D2AGpY5bkSR3zqgOhbXO7AQGzHs5oqg4XzLNhe?=
 =?iso-8859-1?Q?UkRgWxKqRHPwouzj0zW4SGO2+E2mOXkjkWj7BPt+gKVPQmQw7ZyQqCHiVm?=
 =?iso-8859-1?Q?Yx67VpeGbxqaMNqNwv6UpOBvpDgG9+X+q7kpYJH6+kaJ2T4QsQS3oqQCw/?=
 =?iso-8859-1?Q?1twNZzMjgNBUlsT9JfvbRgrzubmXi+1pFdY955gwnF7RjgU7zHvQE1XtO8?=
 =?iso-8859-1?Q?Tb2kadyPxSEM1S5j1SspSw5dE5a21B26NgPcEMsukcGLsO+PwwFIpP37QT?=
 =?iso-8859-1?Q?0WzwGp0c/nuRrjYuzqlW0ko4D5QNZgMC35a1OgcLNEcCzQGlOiBmh48uGr?=
 =?iso-8859-1?Q?8GWZQR5hWcQLy07jhpwajm3Q6oKCUCHNmHmlmSTPrBVO/XgeYUhYJbrV/6?=
 =?iso-8859-1?Q?2NFBGtPEXR43xfZF3hBzgN0K5VJk1hjDZZHZ8E0hoK/DMFO+7KcqrIxBxV?=
 =?iso-8859-1?Q?89C4GFVZs9Y0B+AZNOWESiib4Y2Y5/sDDw5oMLvrsdVCBBIe9toU1VKG3d?=
 =?iso-8859-1?Q?Q5+CBx2nZrm2Kgp28iQT5xFymfWX+nvWCKMpAWJIIdsRZq0VOKWs5TaD9R?=
 =?iso-8859-1?Q?MyRSOnLUzyOA+zHCEtRJc0mBr45G73+RZ6BvkaKoN5xuSr2zSGPwi+MnKA?=
 =?iso-8859-1?Q?3ZU2BVXH1Q+c1Z4OIJD8RMzGzSzopRsVhKqlcrRd0Xb8LlpYpv1hlYCC8u?=
 =?iso-8859-1?Q?C+YYicTLQL0wANcNzof3H32BhUonxw0mHK9uG17F7GjvE7QmTDnRTNviuN?=
 =?iso-8859-1?Q?lSyzpAHyw7duSAxMSJaqup+G0t/mwD5koJWO3u7UNJiQHJ5z59ZyHEb7MS?=
 =?iso-8859-1?Q?pu66T3rG2Fl9zL14AtTidaLpk861mEQINajNFwp1QmWDKoZvpiWYypmgaU?=
 =?iso-8859-1?Q?xv5j8FhC1HUqeEv4xqekzB3g9c0Jnt0ASeumKl9U6pAGGKzKIgCRPhx9Nt?=
 =?iso-8859-1?Q?j/wZMWEYUyq8eNtsk2jFwv4G6CFFCFDapBZKQedSsHrdo2A7erhsW3bHzb?=
 =?iso-8859-1?Q?pCUlCq+vwze1Tbl9hCnScir8jSNqtKCBUvAjKXiwsUptn2vniguk5mPkgZ?=
 =?iso-8859-1?Q?3KKI0d0AzBjMxXWbN7pNp7zi6jcdNg8ZXtyyJBVqMebCrwT+7uWrA+f/Mz?=
 =?iso-8859-1?Q?AQl07Hy33jD7iddvSOL7kszIPJXlY+6TI3fFttJPHVomRWU4DaDAzASrUT?=
 =?iso-8859-1?Q?Aby8tiVrPsuaMmF8XLMcC8VqXMYyiiVt1HMl3NjyDFFmZqHpN3JR02LpXo?=
 =?iso-8859-1?Q?lfK3R2IYKoawvO2fmUpADDATnByMC/M2i43i3wXuzocw8uL0X0VyKdr0DU?=
 =?iso-8859-1?Q?Ryai2wZLuXIwOct3N1cgl+x3slj+oEUpnHYg/JNYKSwuHgHqd2Wu5VKvbj?=
 =?iso-8859-1?Q?YJSBNzZ/3oB4d+Cav1aWYg8VujXiBA29GyszhhKT3wvfs4O+rEguJpr6FG?=
 =?iso-8859-1?Q?dRu0bgy0i1f+jv6zAo5N0dOhYMjhQcRo7uqF8PVxExS0whjVFMVkNqOpfG?=
 =?iso-8859-1?Q?2LlyUvIHOQ=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5ff6291-9a26-4620-ecf8-08da18ad78d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 15:44:16.0831
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xPyoWHJaNrH1aDDy9ohaiFPUPETtOPSojPaJp4Cs4bsnPjqE3lz1onSjy6Ak69Y+jg1eZPgFjMAayj7rqs0dij7kfNsdpifGQUy5sVnQ4zI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4096
X-OriginatorOrg: citrix.com

> From: Jan Beulich <jbeulich@suse.com>=0A=
> Sent: Thursday, March 31, 2022 9:42 AM=0A=
> To: Roger Pau Monne <roger.pau@citrix.com>=0A=
> Cc: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>; Ross=
 Lagerwall <ross.lagerwall@citrix.com>; Konrad Wilk <konrad.wilk@oracle.com=
>; Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>; Bjoern =
Doebel <doebel@amazon.de>=0A=
> Subject: Re: [PATCH v3] livepatch: account for patch offset when applying=
 NOP patch =0A=
>  =0A=
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments=
 unless you have verified the sender and know the content is safe.=0A=
> =0A=
> On 31.03.2022 10:21, Roger Pau Monn=E9 wrote:=0A=
> > On Thu, Mar 31, 2022 at 08:49:46AM +0200, Jan Beulich wrote:=0A=
> >> While not triggered by the trivial xen_nop in-tree patch on=0A=
> >> staging/master, that patch exposes a problem on the stable trees, wher=
e=0A=
> >> all functions have ENDBR inserted. When NOP-ing out a range, we need t=
o=0A=
> >> account for this. Handle this right in livepatch_insn_len().=0A=
> >>=0A=
> >> This requires livepatch_insn_len() to be called _after_ ->patch_offset=
=0A=
> >> was set.=0A=
> >>=0A=
> >> Fixes: 6974c75180f1 ("xen/x86: Livepatch: support patching CET-enhance=
d functions")=0A=
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>=0A=
> > =0A=
> > Reviewed-by: Roger Pau Monn=E9 <roger.pau@citrix.com>=0A=
> =0A=
> Thanks.=0A=
> =0A=
> As a note to the livepatch maintainers: I'm going to put this in=0A=
> without further waiting for suitable acks. Just in case I'll put=0A=
> it on the 4.16 branch only for starters, to see that it actually=0A=
> helps there (it's unusual to put something on the stable=0A=
> branches before it having passed the push gate to master).=0A=
=0A=
Thanks (was on PTO and away from email).=0A=
=0A=
> =0A=
> > Albeit I don't think I understand how the in-place patching is done. I=
=0A=
> > would expect the !func->new_addr branch of the if in=0A=
> > arch_livepatch_apply to fill the insn buffer with the in-place=0A=
> > replacement instructions, but I only see the buffer getting filled=0A=
> > with nops. I'm likely missing something (not that this patch changes=0A=
> > any of this).=0A=
> =0A=
> Well, as per the v2 thread: There's no in-place patching except=0A=
> to NOP out certain insns.=0A=
=0A=
Correct. FWIW I'm not really aware of a valid use case for this=0A=
=0A=
> =0A=
> > I'm also having trouble figuring out how we assert that the len value=
=0A=
> > (which is derived from new_size if !new_addr) is not greater than=0A=
> > LIVEPATCH_OPAQUE_SIZE, which is the limit of the insn buffer. Maybe=0A=
> > that's already checked elsewhere.=0A=
> =0A=
> That's what my 3rd post-commit-message remark was (partly) about.=0A=
=0A=
old_size specifies the length of the existing function to be patched.=0A=
=0A=
If new_addr is zero (NOP case), then new_size specifies the number of=0A=
bytes to overwrite with NOP. That's why new_size is used as the memcpy=0A=
length (minus patch offset). It is checked against the size of the insn=0A=
buffer in arch_livepatch_verify_func(). I think the code is correct as is=
=0A=
but I could be missing something.=0A=
=0A=
Ross=


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 16:00:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 16:00:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300933.513468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUYX-0000AU-OU; Thu, 07 Apr 2022 16:00:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300933.513468; Thu, 07 Apr 2022 16:00:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUYX-0000AN-LL; Thu, 07 Apr 2022 16:00:21 +0000
Received: by outflank-mailman (input) for mailman id 300933;
 Thu, 07 Apr 2022 16:00:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncUYW-0000AH-C8
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 16:00:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncUYU-0003I2-Ei; Thu, 07 Apr 2022 16:00:18 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.7.236.16])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncUYU-00035g-8F; Thu, 07 Apr 2022 16:00:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=B80q+p+aCwQSw9V8KWhT0wsQxF1lmRA3ZIY/LS0xyYY=; b=BdN3McEgf+Sq9GBaq1R9s+bluO
	4JCHjxfq5gWOQotHo4wWMCtrK8IJTTvSA7KBGG4b3G5lrK5bQZnNmzOFrGSpgKbn6ZEsVg5odz8Sa
	HVkbG2DW+SkoTfLwdD4yoT/mFQPDw4G7si6QAkrelu014RKRszNdlu2YyG3d7ZDh4qHo=;
Message-ID: <80f0eb2a-43c0-7663-a1ca-481535361c68@xen.org>
Date: Thu, 7 Apr 2022 17:00:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v2] SUPPORT.md: add Dom0less as Supported
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 iwj@xenproject.org, wl@xen.org,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <20210714234809.30483-1-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20210714234809.30483-1-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 15/07/2021 00:48, Stefano Stabellini wrote:
> Add Dom0less to SUPPORT.md to clarify its support status. The feature is
> mature enough and small enough to make it security supported.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

I was going through my inbox and notice this was no follow-up. Dom0less 
is getting more traction, so I think it would be good for us to have a 
support statement.

Is it still under your radar?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 16:09:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 16:09:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300937.513479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUhM-0001ML-Kj; Thu, 07 Apr 2022 16:09:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300937.513479; Thu, 07 Apr 2022 16:09:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUhM-0001ME-H9; Thu, 07 Apr 2022 16:09:28 +0000
Received: by outflank-mailman (input) for mailman id 300937;
 Thu, 07 Apr 2022 16:09:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncUhL-0001M2-90; Thu, 07 Apr 2022 16:09:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncUhL-0003SI-5Q; Thu, 07 Apr 2022 16:09:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncUhK-0003d8-Q4; Thu, 07 Apr 2022 16:09:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncUhK-0005XR-PZ; Thu, 07 Apr 2022 16:09:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MJDCpX9x+ogygRBAoKK4rj8Tcjd14MSW9kW5iAG05F8=; b=GkRwgbxrG9pblpVdnzAi0SZvN7
	Uf5zqXxdoS/O7+MW8+T5VMx+0HYMKIOxdRsdl17txVcF7rJkU8HuFEZnR7AejR/3nrzEAWwF3k/1k
	UKFyJHv63GbAWNwYGHpsQZHaWz0XuKrnMK5T+pYo8Cgmv6KxzEUqP+r3xsa6LeilkmrU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169205-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169205: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-credit2:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=14dd241aad8af447680ac73e8579990e2c09c1e7
X-Osstest-Versions-That:
    xen=14dd241aad8af447680ac73e8579990e2c09c1e7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 16:09:26 +0000

flight 169205 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169205/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2 20 guest-localmigrate/x10 fail in 169189 pass in 169205
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 169189
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 169189

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169189
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169189
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169189
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169189
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169189
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169189
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169189
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169189
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169189
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169189
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169189
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169189
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  14dd241aad8af447680ac73e8579990e2c09c1e7
baseline version:
 xen                  14dd241aad8af447680ac73e8579990e2c09c1e7

Last test of basis   169205  2022-04-06 21:45:01 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Apr 07 16:16:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 16:16:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300952.513514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUo1-00039N-Pl; Thu, 07 Apr 2022 16:16:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300952.513514; Thu, 07 Apr 2022 16:16:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUo1-00039G-Mj; Thu, 07 Apr 2022 16:16:21 +0000
Received: by outflank-mailman (input) for mailman id 300952;
 Thu, 07 Apr 2022 16:16:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E9KF=UR=citrix.com=prvs=0897b442a=ross.lagerwall@srs-se1.protection.inumbo.net>)
 id 1ncUo0-00039A-2T
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 16:16:20 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d341fc8-b68e-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 18:16:18 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d341fc8-b68e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649348178;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=IE8ojdgnhP5M7dJdFkLCgcDcNg8pTX7z4DBM2Yhk4LA=;
  b=KfBEWUme/0WNXsHMZwaSQqlHn4azubAyHKXDRIyIUdk0+FPHHrA92fVI
   zw3t9B6T2KtBqD2AgYMeaqZgRKb4dclVsIkg2b4pcAYlgbwOusm/cIhJB
   yq/m64s0KUlU5h+lRB83jEYH7m8jy1sZSikC5guIKU5VFYEf16bMj7Al/
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68690557
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/XfhV6mhei5SNjvIsQoZUsro5gyLJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJMCG7UOP+OZ2WnKohyaYXjpEgH7J+Gz4MxHFFk+y88FSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1zV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYCigvD6+TnfghQhgCOCZEIoZUoKOALi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZ71nfdBPkrW4/KR6Hi7t5ExjYgwMtJGJ4yY
 uJHOWQ+NEmdPHWjPH9ILqJhsrmTt0PkUCRe8F6kqIFw2Gr6mVkZPL/Fb4OOJ43iqd9utkWfo
 HjP8yLmAxUZHNuFwDGB/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0GPVWIu9l7R2x26uOyAGjGUMWFiIGZ4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPTt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPc1
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGAkdBo0YplbIGaBj
 KrvVeV5vsI70JyCN/EfXm5MI55ykfiI+SrNCJg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3DLWlMnaKq9ZKRb3IRFBiba3LRwVsXrfrCiJtGX07Cu+XxrUkeod/mL9SmPuO9
 Xa4MnK0AnKm7ZEbAW1mskxeVY4=
IronPort-HdrOrdr: A9a23:/4eOVqE84VJfBbO3pLqEi8eALOsnbusQ8zAXPiFKKSC9F/byqy
 nAppkmPHPP4gr5O0tApTn/Asa9qBrnnPZICOIqUYtKMjOJhFeV
X-IronPort-AV: E=Sophos;i="5.90,242,1643691600"; 
   d="scan'208";a="68690557"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XeQHF6umAfQDb/xvZsI1v6v4F6z7WwBquc4DDg7tSr3DwrwLcWEdPdKLlDkO3DSbZ7L0Uw6986ZXV4g1XgQL803wLnKW60AVQJ5dUwYPdVEgVB0Gqfcile+oiOdNj4pRCRrTMKmzQH3GQNjqIn2g7o5qS5fud/94RajbDPvfXfwNhy5hHRIeWPfkw/YQwukUld8HoJmjGu+Po0xVp6/zwHL1ApM40OizmoO1UcudA1a1tvvZ7944E6zxvJHDgsaU3sZO4s6AnBkDziHNX2k1qQzdtrvNDUjoJhe+SXervmnjCmqbCM35T373xeXLYTcTGYXnP9872dS7DyUhJl/UkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p+bKdzziTzyhaZjlUs5f17T9HEOXH44BuH4BfxkL9Fg=;
 b=ZVdcZ0dNSx8bo1I+czyqV3Sa0H/5VmzCFvAM6r5lMknVf0v9nKrcTQtbeIU9ATx4HNlbl/rDMDkvkOZ+2VzaZxOYJsLAbNJQ18ThU0gmbndY/ieHEouyc3k/9boRdr/d7rmjXYHTSW86Boiy1GVmkDBKff9JD9062xNp5pJrfvzSZaaMiuVWc+92nfj/53bLVVWZLab035M6S+yoOwVLRIYkHmV5iKfBQAfQhE1SXLf7bLQQELgEST87WIzo83ZKx/7uLyA/QQI8wVxZYDsLIpspBCoO+s2hZNqJd9ZaQGkGFi1msdbwMMf1AGjf+iY4q50MYeUvprcpU0I4NSfXng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p+bKdzziTzyhaZjlUs5f17T9HEOXH44BuH4BfxkL9Fg=;
 b=C4D4u9qLcybl4q4/cexYKg6iH/4PiqzmEroaF6//MD21SISPJzLxWAEvIhdq0xTaDPjq1ngjJ7Xq/QxzntFq24a7L9+JzGLU4w2/a6TXwjZzDUA0UIXNNBhWtticBSFhIqCLNhvK4TInCjkhqo/tF3CtbZWt3gxkNRQZUPRZdKU=
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 1/2] livepatch: do not ignore sections with 0 size
Thread-Topic: [PATCH 1/2] livepatch: do not ignore sections with 0 size
Thread-Index: AQHYOe9tRJv1F56fOUuExIhUnmsVN6zkwUJS
Date: Thu, 7 Apr 2022 16:16:12 +0000
Message-ID: <PH0PR03MB63829916B44D38A5B5B8F72CF0E69@PH0PR03MB6382.namprd03.prod.outlook.com>
References: <20220317110854.39050-1-roger.pau@citrix.com>
 <20220317110854.39050-2-roger.pau@citrix.com>
In-Reply-To: <20220317110854.39050-2-roger.pau@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: efe1c0ec-3473-471e-47b8-08da18b1eeec
x-ms-traffictypediagnostic: DM6PR03MB5114:EE_
x-microsoft-antispam-prvs: <DM6PR03MB5114E5D9179C26E709C5F4C4F0E69@DM6PR03MB5114.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Sv0KQ0LoyMoZLNKCSyphY0hiEu1hOWCqLC19NF/79xrOXpUJn3OeQEWXIV/1WdLpN2JLmuuLyk78BUzAam5rRARwrsp35Tf3OC6/QT1ZW7FOya0n8hRfN8ZNkWun8iWG8DHrBEWAEUXk8gyTMkJUvicL/w+KWTbF1hZcB4a6d6a5oSZ3EoYXziAyrli0sbNUCXa2FQaoJuPfwlf1nkKRq6tsQ2m9El0WpoZuEd6/4i791aJrRllF9WmqNO+ZJszkX6/dY0vOPWIoMVRvgCDW3W4a8dsM7OtaWyOGeGb2tjbhUJ4W0Px2ZMLIRkyD9xDW7FFqINEEzU7NmDxZ1fNInxbKLfptDbwqgdNT8by+Yjre7zaBDfgv+FV9uq/Hckf63VmPBv1+VZZPUho2/5i5e9tn5r4zainWOdlxYZAJ2NXI46rfluyO0ahnenvZWkWpS1pHanwOWzqZ6jcaF4UiNq2ojAF7GdzHCOx0pncCxSPfDhOwWF5LdUQJ3ys810Zax8U2N1+fW5RL4IXbOjmTUdGTHp6NVwti/AsD36ak7wC2O1qFGhqs5EIHzbQtFmSk6DLgXqbwi0GFuoMASwhf6oyxmocfg0fkeReFVJM5uTCwxv5BTamUthX7mo8bs026/X3cnPAy3eD+R9v8Q9oGQsc88v9+zyKlxGM/NkCsF0tVzYIT1y7BC/XEqOx2kVJrgfjsv5XoAEKO6VtG6zMWsw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(53546011)(55016003)(44832011)(6506007)(9686003)(508600001)(83380400001)(5660300002)(66556008)(91956017)(8676002)(4326008)(66476007)(186003)(86362001)(26005)(8936002)(71200400001)(52536014)(64756008)(66446008)(7696005)(66946007)(2906002)(33656002)(122000001)(38100700002)(82960400001)(110136005)(316002)(38070700005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?S0aZcBsCexQ8k0qbc5YTcKIa6UTOQmiQH+D4+BEpCUubuJlJS5UG+0Gc2k?=
 =?iso-8859-1?Q?sq8BzSaaM3ty7V2J/e67yvUe3Br7PVDIrZK4TbI467ZQmHHJJfAL7c17oF?=
 =?iso-8859-1?Q?YW8bDyh6Lx4g9sTG1ULaCZBri7uBgrxgsxqXqye5WZsub0DUhSiLm0fbjg?=
 =?iso-8859-1?Q?Y2DxejzX99zPP9C4lnKCY67uW8FyI4VJ2NIHG9P5bKeKnSq5IwJhQq/Qqi?=
 =?iso-8859-1?Q?uZEYygkdqFqw22UuwJdOMXgA61XGFdlhOnOKGSEA9HdEiRWvNeM0+2kK7y?=
 =?iso-8859-1?Q?ne9Pk0JMy7qe9z5Wtl+PbBSMaFnI0wQBhMacbPai3++QmWuSrZF1nkwDLs?=
 =?iso-8859-1?Q?uMIlxt5/Ms5mehdqUJFnuWLXFyCRuYpp9vQ+BxiAJvmG0d9kzEW84K5IkC?=
 =?iso-8859-1?Q?oiICPpY8NTE5iPeLYtEyZnAymH8sWOYE9VQDtI7h9Ackz5ZuWVfSfa2dyu?=
 =?iso-8859-1?Q?q09l3HN0UGuxsMswD7nX/HF4DjtAOTBjrUqN6i39lpFNcNy9rrMW/TPy5L?=
 =?iso-8859-1?Q?PrL3j59IkpQ0zCbiy1sEXEvZmRIv92FQ/fYA3Lv8JxQN9r7O6gIH140YZe?=
 =?iso-8859-1?Q?xIc/U4cBwPyjEVq4Jx0M6kXrmOxiWHqJE5NAwgBh/tauCSIdb5sR0OOkZT?=
 =?iso-8859-1?Q?KjMS/S+JRDrEsLTqd+F6ieiYcaS2DM99Cg1w0vL/1kZgVkHxYYDx6v0tj0?=
 =?iso-8859-1?Q?XzhQi+HzewzhnkTJmhCpdvtsABXw8off4EnNRP1OP3GNxH9TgFuVmIyTS9?=
 =?iso-8859-1?Q?eAoOT2Kyt9h47d4zvWm5Zm+LXGKZP+EtvezQqJ7MJV9TxiDONPVVnU+8P5?=
 =?iso-8859-1?Q?a2jGJC+sygi0OVBDJAP7hBmzGHVXgXqAfZ7yEfl5pYrLOhssE+Bb721GXP?=
 =?iso-8859-1?Q?WS5cn6TFgNK4PKGMrhA18FGKiWp2KGF9DAOIId5bRKgNyIFIelnbnC431p?=
 =?iso-8859-1?Q?DMJZgy0uH1AEiGC8Yzt9d8VFH2oiFJm+injaQri/3Wu2KhC9jQnNxa6o2S?=
 =?iso-8859-1?Q?hiOwnxkwztk/34nR2zo6d2qyDTccwCB1rC/ZBeNypzxfMN8+CBFyA+9Prf?=
 =?iso-8859-1?Q?kpgi/4ukeJvzrKUiQ2txZ3U9fvbzCKCZOJGNUiLU9LNIrnt3i3hMgsmUPQ?=
 =?iso-8859-1?Q?A4maTq9XG2oTwz+rvApjfCvrv91vcGDY+gE7+AFY2PWL7sns4j8k5y88Mk?=
 =?iso-8859-1?Q?ETXCDh+obQJzb6F+1QgxdP9qkA8cUX+vWQ9CTTj1EmwjXfMEs3HSIRE3XJ?=
 =?iso-8859-1?Q?nBzQH5GMUuMhQZUmruCVc1bphaFLNZUnNz7Hg4Lida7WAz7sDYlUOCFIkt?=
 =?iso-8859-1?Q?1lO5OXNvF4u0BMa1ptef5EFZSKeGQE4e3mFNXBA78M/stYhRRIwrgKj/Zd?=
 =?iso-8859-1?Q?c36NzyyIFRszeFI/uuhZMVB2qxoB9LnDcYfcWxrgq46w/fPQdiuutzl/f0?=
 =?iso-8859-1?Q?ljSSkcJtEw1TLMXbhw7TIdVhpZ3qsXTUHCSWy7yyBOdlW+Q7Du/N68Ztxs?=
 =?iso-8859-1?Q?4eNjB3LNqrFJh7fOmlAkjLrxwRiYfrxlJobsnshOeTc2zcTAB2Dt9gEM+a?=
 =?iso-8859-1?Q?QHHL4zwyz/6IBrg1bnLjV47x9rdfn+wclz8/LAxSWqBoGvcqGns9/m21IC?=
 =?iso-8859-1?Q?k3X45tU44upSUeo5+qijmEUVAdvWE0XfaOrA5rj5aj57a8l0SuzzX4auZw?=
 =?iso-8859-1?Q?i4b9MHqPhWKpznKMn7FBDkpWv58PqIcGop2W+/Hd+btnTTrCDbDwqKoReU?=
 =?iso-8859-1?Q?1zVMUfjb+zb8WNLV8i8RFHZA+EpcMXKXtPx0eEW6Qjzyac3E8WDs81re2m?=
 =?iso-8859-1?Q?9cFxVz+jlg=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efe1c0ec-3473-471e-47b8-08da18b1eeec
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 16:16:12.2149
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VAWdi7H6R1UdzqOexWdsFtu3WHd8C2ndd+qpUr77ba1dfBv6283b4t4xyQkNN96wmkB8HWkaHgY332Tan18p2mnWUxBvLZD5pJ3rsRsyKH4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5114
X-OriginatorOrg: citrix.com

> From: Roger Pau Monne <roger.pau@citrix.com>=0A=
> Sent: Thursday, March 17, 2022 11:08 AM=0A=
> To: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>=0A=
> Cc: Roger Pau Monne <roger.pau@citrix.com>; Konrad Rzeszutek Wilk <konrad=
.wilk@oracle.com>; Ross Lagerwall <ross.lagerwall@citrix.com>=0A=
> Subject: [PATCH 1/2] livepatch: do not ignore sections with 0 size =0A=
>  =0A=
> A side effect of ignoring such sections is that symbols belonging to=0A=
> them won't be resolved, and that could make relocations belonging to=0A=
> other sections that reference those symbols fail.=0A=
> =0A=
> For example it's likely to have an empty .altinstr_replacement with=0A=
> symbols pointing to it, and marking the section as ignored will=0A=
> prevent the symbols from being resolved, which in turn will cause any=0A=
> relocations against them to fail.=0A=
> =0A=
> In order to solve this do not ignore sections with 0 size, only ignore=0A=
> sections that don't have the SHF_ALLOC flag set.=0A=
> =0A=
> Special case such empty sections in move_payload so they are not taken=0A=
> into account in order to decide whether a livepatch can be safely=0A=
> re-applied after a revert.=0A=
> =0A=
> Fixes: 98b728a7b2 ('livepatch: Disallow applying after an revert')=0A=
> Signed-off-by: Roger Pau Monn=E9 <roger.pau@citrix.com>=0A=
=0A=
Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>=


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 16:22:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 16:22:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300957.513525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUth-0004mV-FD; Thu, 07 Apr 2022 16:22:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300957.513525; Thu, 07 Apr 2022 16:22:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncUth-0004ly-Bj; Thu, 07 Apr 2022 16:22:13 +0000
Received: by outflank-mailman (input) for mailman id 300957;
 Thu, 07 Apr 2022 16:22:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E9KF=UR=citrix.com=prvs=0897b442a=ross.lagerwall@srs-se1.protection.inumbo.net>)
 id 1ncUtg-0004kX-M0
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 16:22:12 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df904ea5-b68e-11ec-a405-831a346695d4;
 Thu, 07 Apr 2022 18:22:10 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df904ea5-b68e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649348530;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=ZerbvmKhPN7WWYE0dvapRUXhan96DIMbmVpIjFPcEnE=;
  b=YGhZUfn4WNNhCRBESFDZpJH9n48vkKB1wLaLwAmhZ/T5bVL+0GvJSP/V
   frkM7MDXEh5vOnz41C51BvDNpF5hqV8Oyb4xAmYh4qQ+c+UF035JnVxoG
   H5eLO5zJBgkPsYO3lnzma/zridp6hbkChhgj2UXBmmUBSzpeqXj/6H11r
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67704095
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:stJc46z70cT5Yef9Wld6t+e+xirEfRIJ4+MujC+fZmUNrF6WrkUDx
 zMYD2+BOfiLZ2PzeYgibYS28h9UsMCGzodiHlRuryAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YfhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npluqe9FwI3Hvb3w8NFaBVcCz5bYoxh0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQEoTdkxD7UF+kvRZTrSKTW/95Imjw3g6iiGN6AO
 JVBNWI+MXwsZTVDGUUsBpYYsty3j2vtTj1S9X/EnIAotj27IAtZj+G2bYu9lsaxbftSmkGUt
 2fX5VPTCxsRNMGc4Ted+3fqjejK9QvxVZgODrS++rhviUeK220IIBQMUB2wpvzRolG6c8JSL
 QoT4CVGhao4+VGvT9L9dwalu3PCtRkZM/JTFOsg4Q3L1avQ4C6eHGEPSjMHY9sj3OcmSDpv2
 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTS0ZSQoI5fHzrYd1iQjAJv54C7K8hNDxHTD2w
 hiJoTI4irFVitQEv5hX5nie3Wjq/MKQCFdouEOHBQpJ8z+VeqaqXIH27Eb7ts0bC96iQl2Zo
 11buu+3ubVm4Y62qASBR+AEHbeM7vmDMSHBjVMHI6TN5whB6Fb4I9kOvWgWyFNBd59dJGS3O
 BO7VRZ5vsc7AZe8UUNgj2td4ewOxLOoK9nqX+u8gjFmMskoL1/vEM2DiCetM4HRfKoEzPlX1
 XSzK5/E4ZMm5UJPlmfeqwA1i+JD+8zG7TmPLa0XNjz+uVZkWFabSK0eLHyFZf0j4aWPrW39q
 ogDZpHalkgPD7KnO0E7FLL/y3hQcBDX4ris9aRqmhOreFI6SAnN9dePqV/eR2CVt/sMzbqZl
 p1MckRZ1ED+lRX6xfaiMRhehEfUdc8n9xoTZHV0VX7xgiRLSdv/vc83KspsFZF6pbML8BKBZ
 6RcEyl2Kq8UEWqvFvV0RcSVkbGOgzz33VneYHf/OGFXklwJb1Whx+IItzDHrUEmJiG2qdE/s
 /un0AbaSoAEXANsEIDdb/fH8r97lSJ1dD5aN6cQHuRuRQ==
IronPort-HdrOrdr: A9a23:oshxratEP2yh6abpR0KsVCdq7skCwYMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKdkrNhQYtKOzOW91dATbsSobcKpgePJ8SQzJ8l6U
 4NSdkcNDS0NykBsS+Y2nj3Lz9D+qj+zEnAv463pB0NLT2CKZsQlDuRYjzrSnGeLzM2YabRYa
 DsgPav0ADQHkj/AP7LZEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZizU
 H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUgZ1TChkF3nAic0idurD
 D+mWZlAy210QKXQoiBm2qu5+An6kdp15at8y7AvZKpm72HeNtzMbs+uWseSGqD16NohqAN7E
 pGsljpxqZ/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh5rD30XklWavoJhiKoLzP0d
 MeeP309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw9ArfZv00so5dY4Ud1J9u
 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCaZIEjhFqsAJ3XRwqSHqokd9aWvYtgF3ZEykJ
 POXBdRsnMzYVvnDYmU0JhC4nn2MROAtPTWu7ZjDrRCy8/BreDQQF6+oXgV4r6dn8k=
X-IronPort-AV: E=Sophos;i="5.90,242,1643691600"; 
   d="scan'208";a="67704095"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zk2AhIxnGzLfmP/oMk+MHUXBI1oX9L7rgTrEkMzwDCZsCTjrndtKIZffqYgLEG12HhliPaJpxrPwSGX6udZeS7beKI2kfT6DzCTOAE7Q42ikks/99c8EmdAily4VIqkGF2edP8QrRDvPVpkh+NWhoyGqD1L5K3o3qFMH27uSqjx/+sIGsO5M+tWcy2uJWMpSwpB9eHhpXtso024uMqavPABzeeMiEL6yQvouHDAMTh8d2CFa9K/XpZyMa+HwMUsDypdc6HxhInEC/OdTyFYjdW9gAAlHzPmKjWLcDFRg0vvmQkKbYiKblaoaaC+r5WItUXSPTWuppaagGsjXE53yuA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gyXqMY64O1Uug5/+9YckpenDTGpRE0ZidxQ9DU+y+d4=;
 b=hum6crxDi7ftw4e9ieavNtwSRsgYsg1O75eJP4RzhBuKqoV8UOVzu3j5jB6780bCG74EXbV+dCrVKbqhwn1m2jRGN3EmiPLA9W/x1qQwTMkwoFNYxbMp91vEzd7RgowvCDqwYCFq+GIMC3kgzopKQBUTVajMW3I9tOvwyZ68PIx6R6T99KOykk2SPHd62FEOP/PNTVvgy7N0qcZIpk0AOw/qKUyjHwhm1XgsVfHo+sucCNGglsRCU/PMTmt98FcXnfK8RiqizLiyWSvW4krMEZ72UJASBE5cnvIbXlkXALOiWFE2Nl/VELZBsjx4SfJRyLLH0tPkgaqucsBAb25WIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gyXqMY64O1Uug5/+9YckpenDTGpRE0ZidxQ9DU+y+d4=;
 b=P9kyWL9DFlEJadB1cVr3DiMzMsPxjARiDUpGoerpS0xMHLSIKoURTQvGQoM3Mq46UnOi8pm99wQvvXe7RZ15nucGXUHsDPAKkJOXoJ+o1qPbE4zojxqUCApcSiWsr+2L8nGeAps07ufi6Db4NCQfugmb7E199h4DjvyPZ72cfVA=
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/2] livepatch: avoid relocations referencing ignored
 section symbols
Thread-Topic: [PATCH 2/2] livepatch: avoid relocations referencing ignored
 section symbols
Thread-Index: AQHYOe9wc0rCrpONwkq7moDToUASPKzkweYm
Date: Thu, 7 Apr 2022 16:22:06 +0000
Message-ID: <PH0PR03MB63826C1CEDC5C336B4DA501CF0E69@PH0PR03MB6382.namprd03.prod.outlook.com>
References: <20220317110854.39050-1-roger.pau@citrix.com>
 <20220317110854.39050-3-roger.pau@citrix.com>
In-Reply-To: <20220317110854.39050-3-roger.pau@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 48509fc6-e05b-4d66-9c80-08da18b2c1ec
x-ms-traffictypediagnostic: BL0PR03MB4291:EE_
x-microsoft-antispam-prvs: <BL0PR03MB429117ACC91696693D181BC0F0E69@BL0PR03MB4291.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: mF8LH03LI3kzDzbGZ9dKQ7+BxH7SOuchFzWHHIGrmTWkfekwzu4memiAFN7kstK5RDvYtTbmp6r5ijGkXELjv5oSyOH6EPHtQgGieBRd9QwX/gncqJcsvJtVRYiyEMj7K5rAQfZBAbjTaqhvlFqCveFGmDpZPCGjnzd6F37TwLKNMRLrM0mns35/7I1paSxv7uEuqaOTFS+RTefdGnJzof6sFI11btoOzO5XbM+3lHDQMTOFrETQzlNpIVsbJJ3Lmupeixhag30ygtW5/DQhif3os9PX8952aKW9J+Tu0hDtThb/pBqbAWSKfxrZlc+inellZc+c1hdrFEAWLVifO9hp/OzQXEJGgaixGvvxXW4e3jPXhYAUl6mZoael8ms3/DiZrlw458A0n/couQLTnl0xr/adrbPpV+a8Ew4XdAc2SGHWcGNcM6gLa0Xl/wzfdOfoPLkJkSXFVNqa5rUy4sfiXI1A8JvMNJ6OyOJNJpwjY7vU60n8NHajy8UphwM8fDAcEUCs0oQIuoP3HNJ3ox4YrK3c34WMcQctK4yopC0jPJELGb6tp9w4lfkH5KJmrOw7xU/X0HtkmMH/hUaJBjUvL9le9baIiowOj3H3YmexqZ9PQ+B9+q/SxxYv//JIuIQpiHhziq2NRX28PpiGLwdRTqeRVw6kMxuSbSbeA7PKYVv5qob30b4gAm9+ZzJ7yxA0Cexeu8NweYuK7of0gA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7696005)(6506007)(4744005)(316002)(53546011)(2906002)(110136005)(55016003)(8936002)(52536014)(54906003)(5660300002)(44832011)(9686003)(38070700005)(66476007)(38100700002)(66556008)(26005)(86362001)(4326008)(64756008)(66446008)(82960400001)(76116006)(33656002)(66946007)(508600001)(91956017)(122000001)(8676002)(83380400001)(186003)(71200400001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ZC1hdFb0LvZyNivbeZXq8lctQruNRCB4jnSUGYbZL2vVsP+M3489fpnqhs?=
 =?iso-8859-1?Q?8iYq7wRtFyB4ucVzTJQVxCJ2KkGxJ0fBOD3wzs1zDDYIdFSkFSj3nB4lfT?=
 =?iso-8859-1?Q?eafFcwmxWKk1Tv46Hns3Wf/ktStbxdh7D1Yv3BkS/QIOiWTp/d0bUpgQw8?=
 =?iso-8859-1?Q?Nhc1pbokQDitEis28FHY6rl8buElsegwS88p6zXUXIqrF7RLE89Nbptl6Q?=
 =?iso-8859-1?Q?z5UvItRP1m4kCgyQxlUkIuGAB82mcIStVh+dSmi3OMgMPpw1sE75ZHIpYy?=
 =?iso-8859-1?Q?mTOES5Q8y1N9OEwS4sgjI3HfWc8CK3T3dVDgPlr1EbJ2c8+rW6jqvVWSrq?=
 =?iso-8859-1?Q?P7mXBmyUgL80q6YHCEbI/dxB0G/Fv72fkfAPG+zowEQ5koqr9XFS8WTXpp?=
 =?iso-8859-1?Q?hyH4tJ8PvmPvALPVr2BbOYRB4U8jcWnyCdjIQbcolxEsW5qy8Fq1/ukkxa?=
 =?iso-8859-1?Q?PFKVch4Z7Hr7js2v+ajlGzmZ0NCu0lKwiqDd9oOewENHcSHSHbS0hXB9Vl?=
 =?iso-8859-1?Q?D28VBDxlMeEzKjHfB1TmGb19xXst71uc6IZHgRpr/au51XEqC9MIyWEHf3?=
 =?iso-8859-1?Q?v/9G+ZQWcFC9SixDlcIgGi/ZvQVx2KCPi0hq9IUUESthIfaMnnFxRP38QQ?=
 =?iso-8859-1?Q?JdfqUXQcGxNm46OV3Ik52Gp4ueieXaGGS2b8QTZFvbCAGv6f+W9aMZUXj6?=
 =?iso-8859-1?Q?W3F1MPRcO+aHTXfjEzspxb5htNrNmI62GLHe3PeDSePhs4QXX7coDTpkTH?=
 =?iso-8859-1?Q?WuOHsS5kknLBVUTfiKUTFT0OiLFv0TmzgnWGm8UNCd8d2yzU82jfEWEdwD?=
 =?iso-8859-1?Q?ppdK+QG5DciMrU53jMO4RrmN1HZ0+yl7LNIPWSbMqx5YQNSSEaBGzmp5+Y?=
 =?iso-8859-1?Q?14JZkERLWsMKXdLKfyeIEIKlOpTj/nivpfO7MLTB87/fdaPZHw387IyBqs?=
 =?iso-8859-1?Q?bqAXdwBFT07S50rDIGTll/bhHO4N5ujqzBWYxtkp7QQ+oFBCPS9AE723Cg?=
 =?iso-8859-1?Q?Fph8uvjEdLKltypktZXibFAmqu2s/84tfTCtnF0ZfoqsTeuPc56p3wB2ad?=
 =?iso-8859-1?Q?3FU3qfy5bFx5Hs3Nrwb2I3Z+dDcunmfKjiIqP7T4P8digeq8XS8zKgtWik?=
 =?iso-8859-1?Q?lU8UiwP7Q66+dXoV1xKeYIE25lHRDdDWKRkk5h3lWyMEicZY/MWjyfRHvU?=
 =?iso-8859-1?Q?BPvxUhJXkOU+18yJo/1Aay/Uu1gJtAxUC9Ehb2hx5tIW4xygg8pIZrULr6?=
 =?iso-8859-1?Q?vuyoxL0Pa1qNSX693n7Xt4ehRkpo0lu3V4tz4Gf0vDdtrR6W38OQYTMrri?=
 =?iso-8859-1?Q?z3HQCkPhQGhtg+DjuXQ66mjbB43oR/19FTDylmpd0/VJzspjdNr0QbExIV?=
 =?iso-8859-1?Q?wOZm2A5HnrrJ0iJqy8yjVClXJhNH5krFqnvp/O/kh+ybkA3OsSbvP42ZTT?=
 =?iso-8859-1?Q?SgFsS+yUTmSh2TMzPfWyE0BWvvVFt5i5d/ir2ZsAorssAN/6/dNPCvgiK8?=
 =?iso-8859-1?Q?zNCD5J4ZXc/x33LIyhPjmXnIgzqNoPI4BPB0w2SHciv5lzvXii9IrLdRmG?=
 =?iso-8859-1?Q?xMoyDTfMsUaHi3MDgWkOPD6Jrm75hRTKOkWGx+rPL7EOXI4cd4B6YcKQPd?=
 =?iso-8859-1?Q?Do7LBjh0w/uGZyo7764VPEgJYZa48MM/Ua+oix5WDrX1fY9aZeb05jtcNs?=
 =?iso-8859-1?Q?MeLKzpFdKV/+11RDdCBXkgj0H9gF1BbAuSwI27V+kowjC5tb+WnUNBLIrq?=
 =?iso-8859-1?Q?cukuRjZHX/YPFXopvNHP6LD6uMCUY1ZiN0PvmLpFQf7Ykh9zZmHKxB2ODb?=
 =?iso-8859-1?Q?nCDZpMA7hQ=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48509fc6-e05b-4d66-9c80-08da18b2c1ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 16:22:06.2007
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /SbhMXstGYn2IgHHokUzFaY1DSzowgzE1fb4TAIxVphgU5tUZUPsADkuDPpJoRZaxzQHcPOyHvg7VLAU5Dh0uUap7rvjwmEjuOMY5XjCzd4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4291
X-OriginatorOrg: citrix.com

> From: Roger Pau Monne <roger.pau@citrix.com>=0A=
> Sent: Thursday, March 17, 2022 11:08 AM=0A=
> To: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>=0A=
> Cc: Roger Pau Monne <roger.pau@citrix.com>; Konrad Rzeszutek Wilk <konrad=
.wilk@oracle.com>; Ross Lagerwall <ross.lagerwall@citrix.com>; Stefano Stab=
ellini <sstabellini@kernel.org>; Julien Grall <julien@xen.org>; Bertrand Ma=
rquis <bertrand.marquis@arm.com>; Volodymyr Babchuk <Volodymyr_Babchuk@epam=
.com>; Jan Beulich <jbeulich@suse.com>; Andrew Cooper <Andrew.Cooper3@citri=
x.com>; Wei Liu <wl@xen.org>=0A=
> Subject: [PATCH 2/2] livepatch: avoid relocations referencing ignored sec=
tion symbols =0A=
>  =0A=
> Track whether symbols belong to ignored sections in order to avoid=0A=
> applying relocations referencing those symbols. The address of such=0A=
> symbols won't be resolved and thus the relocation will likely fail or=0A=
> write garbage to the destination.=0A=
> =0A=
> Return an error in that case, as leaving unresolved relocations would=0A=
> lead to malfunctioning payload code.=0A=
> =0A=
> Signed-off-by: Roger Pau Monn=E9 <roger.pau@citrix.com>=0A=
=0A=
Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>=


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 16:32:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 16:32:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300962.513536 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncV3G-0006eu-Dp; Thu, 07 Apr 2022 16:32:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300962.513536; Thu, 07 Apr 2022 16:32:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncV3G-0006en-AE; Thu, 07 Apr 2022 16:32:06 +0000
Received: by outflank-mailman (input) for mailman id 300962;
 Thu, 07 Apr 2022 16:32:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yv5T=UR=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ncV3E-0006eh-S9
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 16:32:04 +0000
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com
 [2a00:1450:4864:20::235])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 41bfae7d-b690-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 18:32:03 +0200 (CEST)
Received: by mail-lj1-x235.google.com with SMTP id h11so8182018ljb.2
 for <xen-devel@lists.xenproject.org>; Thu, 07 Apr 2022 09:32:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41bfae7d-b690-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=6oZEohghZh/tDrW7Cu3Ag2GmsIuQIYAvbXvbKsDroRA=;
        b=JLMM6USeNMgl+jwcgl5Wb2Op0AexP/0LUpGqbQAsqvDvyYQR8e39VL2cIbdZoRWXZd
         6I8eWxdWQhSOMnwrKmWeZJM2kxvr4TSS9iZgw8rMWiFn9/KgkgpXm3EULHn+KeU0E5U7
         w4bHXaA8MKU2503Yt18YSXWsARDb/+xHFeZ6750yNo0SrlyG24OXabTYjdWOoA9NeLd9
         R65sxh1IqIko2lv8G0iZX8ShMzpjZ9mBf6l625YkQW+YbchFPdjUe/BKofSCqBZk4aOg
         1C6tFa0rKDpfOd2Z9hYz4+uDXVMUOpoXKyITXq7a5797b8J4pOzoU3QDaXyANpYIw6mX
         nJhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=6oZEohghZh/tDrW7Cu3Ag2GmsIuQIYAvbXvbKsDroRA=;
        b=AcfldYKDQs+cpfny/0hT1tIYgbv/y1KtE6+UeeQexUDxKkm/IizKOws8iNd/tMy/ck
         J7r2z8BtpgN2ffqtsdVayJLBu6I6/73bIp3HjQ+xxdSBJf9P9U9j3Br8iH9eZrOMpcqZ
         G+pf+r922nI1hNS7VrCWtNA0a7CFz3s1f2q6DnjGnVNS0P3MHFrvIrSt1TKZCzTQ+t6o
         B4uUkfTT1YU1DmcrWtMiSwmL0IifQ7b4lk/mU0wAHUlgWUS+lW1OQk3kkAhMFEseUfss
         jf2ewgDtS4p39/YCwVebgb2fxzvm1vCxACITmyxaQuQL7nO3PNQn9oO9TvI2inhynzYT
         GBfg==
X-Gm-Message-State: AOAM533HRBAUsrJULqOj3brkggTwLUJz1QA6Al58KsuP1zvnnS7aFTDg
	/9juQ/42VylPfJ6OjxbxIjkafzJvfJvYaplg+Oo=
X-Google-Smtp-Source: ABdhPJxnjCmFa/NbUN2f3fSFbTy7/tVfXqOoAafA9+pQxOGriUiJ/DHCctyqBVRrCzu3Y/f+elu97vNtSHJJui/fVcY=
X-Received: by 2002:a2e:b0c9:0:b0:24a:fb55:8661 with SMTP id
 g9-20020a2eb0c9000000b0024afb558661mr9347577ljl.168.1649349123259; Thu, 07
 Apr 2022 09:32:03 -0700 (PDT)
MIME-Version: 1.0
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <6739cf19-a74a-208d-82e8-28dfde7710f5@suse.com> <Yk6VvXJHWxJZTgeF@Air-de-Roger>
 <15a53720-4dd1-3139-5d78-5b8a5704a953@suse.com>
In-Reply-To: <15a53720-4dd1-3139-5d78-5b8a5704a953@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Thu, 7 Apr 2022 12:31:51 -0400
Message-ID: <CAKf6xps+VAvi1QcDGG=mB2pVt3frWFj=6pYrDMVKH+KgE6qaEw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] VT-d: avoid NULL deref on domain_context_mapping_one()
 error paths
To: Jan Beulich <jbeulich@suse.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin Tian <kevin.tian@intel.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Apr 7, 2022 at 3:50 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 07.04.2022 09:41, Roger Pau Monn=C3=A9 wrote:
> > On Thu, Apr 07, 2022 at 08:11:06AM +0200, Jan Beulich wrote:
> >> First there's a printk() which actually wrongly uses pdev in the first
> >> place: We want to log the coordinates of the (perhaps fake) device
> >> acted upon, which may not be pdev.
> >>
> >> Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
> >> device quarantine page tables (part I)") to add a domid_t parameter to
> >> domain_context_unmap_one(): It's only used to pass back here via
> >> me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again=
.
> >>
> >> Finally there's the invocation of domain_context_mapping_one(), which
> >> needs to be passed the correct domain ID. Avoid taking that path when
> >> pdev is NULL and the quarantine state is what would need restoring to.
> >> This means we can't security-support PCI devices with RMRRs (if such
> >> exist in practice) any longer.
> >
> > The sentence:
> >
> > "This means we can't security-support PCI devices with RMRRs"
> >
> > Seems too broad and could lead to confusion. So I would maybe use:
> > "legacy PCI devices" or "non PCI Express devices".
>
> Right. I did actually forget to either drop or edit that sentence. I've
> now extended this to
>
> "This means we can't security-support non-PCI-Express devices with RMRRs
>  (if such exist in practice) any longer; note that as of trhe 1st of the
>  two commits referenced below assigning them to DomU-s is unsupported
>  anyway."

Mentioning "Express" makes the support statement clearer.  However,
I'm not clear on what unsupported means in "assigning them to DomU-s
is unsupported anyway".  They can't be assigned?  I'm testing with
staging-4.16, so with XSA-400, but not this patch.  I seemingly have a
legacy PCI device still being assigned to a domU.

It is an 8th Gen Intel laptop with:
00:14.0 USB controller: Intel Corporation Cannon Point-LP USB 3.1 xHCI
Controller (rev 30) (prog-if 30 [XHCI]).

lspci output for 00:14.0 does *not* have capability "Express (v2)",
but it does have an RMRR:
(XEN) [VT-D]found ACPI_DMAR_RMRR:
(XEN) [VT-D] endpoint: 0000:00:14.0

It looks like it is PCI compared to 39:00.0 which does have Express (v2):
(XEN) [VT-D]d1:PCI: map 0000:00:14.0
(XEN) [VT-D]d1:PCIe: map 0000:39:00.0

As I understand it, an RMRR is common with USB controllers for
implementing legacy mouse & keyboard support.  The Cannon Point PCH is
fairly modern, so I'd expect it to use PCI Express.  Xen seems to
identify it as DEV_TYPE_PCI given "PCI" above.  It is an integrated
PCI device, so it has no upstream bridge.  Maybe that is why it can
still be assigned?  The "unsupported assignment" is a legacy PCI
device, behind a bridge, with an RMRR?

Thanks,
Jason


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 20:05:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 20:05:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.300998.513565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncYMy-0000j7-S6; Thu, 07 Apr 2022 20:04:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 300998.513565; Thu, 07 Apr 2022 20:04:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncYMy-0000j0-NY; Thu, 07 Apr 2022 20:04:40 +0000
Received: by outflank-mailman (input) for mailman id 300998;
 Thu, 07 Apr 2022 20:04:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NjTl=UR=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1ncYMw-0000iu-QO
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 20:04:39 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1ecc6d6-b6ad-11ec-8fbc-03012f2f19d4;
 Thu, 07 Apr 2022 22:04:35 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 237Jv8tV005378; 
 Thu, 7 Apr 2022 20:04:31 GMT
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d9351ws-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 20:04:30 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 237HXJUL031723; Thu, 7 Apr 2022 20:04:29 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2171.outbound.protection.outlook.com [104.47.57.171])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3f97y81p00-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 07 Apr 2022 20:04:29 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MWHPR10MB1472.namprd10.prod.outlook.com (2603:10b6:300:22::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr
 2022 20:04:27 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%9]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022
 20:04:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1ecc6d6-b6ad-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=h42ziWwbYgAUAYilcI+fTyDeYpkmHQ3G1Gs2uWgyrkI=;
 b=ZNhG4Bh8vsgnHDnE0/T9teWYem0k48qSlmuqcNjFaOddQ4IdJnU5IEV34rqV4/9OyPLW
 /ps5s4lOOFjkxlSdAA2WZlaKc6m5+dy0BEIKwQMAGaDUdIT6x5AA3jBURcVskjqNzpo8
 tCOCECaNDRfWO/7rWm+U+yTwYIyX1vpVeV+NhPoiPhdBJ3ZQAmb0EGMrOxJrN0+Bmkoa
 Wk+b8kCU53ZxAOlVhnuDX6K/V+aY3SDAtxMFfjK8vifaPZRfFjaKfDnBZDzL2Q2InmUK
 5sDjSElRoAaZts7qvFb6gw2f0Z/ZgHYKk3gPQP8px6aP52bQNYyxSBzYNXp/1BuIlBCt Iw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L0BEC/FY8vcf0RSqYzSgvfgbXINdcGhXg7crd9YNJzPSINjKrlz+PBZxf/Uak9PTIK41AMF1HpOUU/H91soZ2OWXfjuXaFpr5YoHsx3P9Ad+LphL2rWdtpMn2sDjL0pRipHzTNOmhLlTFY0PkMbekf0PUlkKHIQ/yvZiYktViC7M/L2enyAe7Z/15WKZQ9adCYtlG040jxCt6lkbLboBk5NxrDskKron19qOSnqYNAHXzV7+esSG6UZAoGFt6rn7J6fE3bpNndNKRdCUPg+tbvU35MhxfvOufDFYhlFk7QZR5jJdW9EDAFcqnmmD6DFIuvHSvqKsWzOkBp9TMZfdZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h42ziWwbYgAUAYilcI+fTyDeYpkmHQ3G1Gs2uWgyrkI=;
 b=dCDMlZI8oHVb8x49N0mMuDqW6IaGTomRBEd/H8lG5ZUbtCOaRyNqpDNnBcZbEQFenbKMTBugE4J/PhZ5OIFrNe97kbieZTmFXYZPb9mJfnKp+I3IGFwLrv4aw+IXqbnq2tbAR6ywp6ZMR82c/rw1GA6ChDEbnNCfSCTinXPlvVn4C9aFqllVG84rTGpmeIAl7ebuD6+9HqARiMgmnPUxrShd6CZuIyyxiXb1cNYiCJUBJY74xRoXbg78X22T2IS5/AAg+B58e55aEomIcQbQMpY9P7I1UZY7Nd3QH3kFWwMpXDjqOjltR8KcLCZCZf0AsGQWx1qMIGrVGIZZmR9bXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h42ziWwbYgAUAYilcI+fTyDeYpkmHQ3G1Gs2uWgyrkI=;
 b=efCn9AN2dZ4GoCBRbA6RAEgei3f2uutgZg28hIe8+tpqw+tuxIkpHQJzME8EohbuZl66SDKGZ8mC1spOfsqMply58YMDo4FBRuUNraWxwz3g759kk4UrSzvxvfVeyREE1g2vVbUkeWCE8dA2+8Di9lXMBcguBwG63dvszSMt2yY=
Message-ID: <c2d5f0c5-803d-7ca9-3f57-3d230874e310@oracle.com>
Date: Thu, 7 Apr 2022 16:04:21 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] xen/balloon: don't use PV mode extra memory for zone
 device allocations
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20220407093857.1485-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220407093857.1485-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0PR13CA0175.namprd13.prod.outlook.com
 (2603:10b6:a03:2c7::30) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d5b83252-a378-4918-4fe4-08da18d1d0fb
X-MS-TrafficTypeDiagnostic: MWHPR10MB1472:EE_
X-Microsoft-Antispam-PRVS: 
	<MWHPR10MB14727C6B291BCCF1220DE6078AE69@MWHPR10MB1472.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	/H/KapVb7bQbxksmPNMazJtY4exlQKblNPc/D4qnLgKeNUUQzPBXcUVYrzOlGPrGGlNRdMc0gdocjWt3FZeyUiKWbZMSFJvBORs/L9ujxp6csyPlWEdUPYnqOJegE1u8Zl257kHXZbXJWlN+P5qrXSF7ZccLcJ4si06XGlcg1AuzRfWazpyD4rYhms1467ZW8JqN43kvkeNVm1rdQB7GYKrD0XRpB+l1rgBS+uhE/4vHEgp1EmXa/mTAhcRTWNXGpHXOCuvo9kJ5gCjAf+Sn0AIMnQqmLdd/PBS5eCrQniSEvsywc3wT786dpXW5ixmw6PNkkxXnGRU8SgukfaoL2f2jnH2xw4uOVitji3f7DO2nqe2X/XgTHubiIjudtOnyvj3MFqBUfE7aGtKEeN4FCtEOFeoAprkqomsTmN/F33tDuHwrTkZoG+yvAGCj2Ic1A+PbsjtFd6u4P/+gMgEb3Pt3IP2LLqKUa/AqKV7RYGy+d/lMOM9klyWXuraPWIWqklCawBPBtaP15WyStlkOSL8wPgZ1XGf+sWaywC4V3uAn1pI4288A0cDSCIVOGk9iznNBJn9XxQ9U7ic+oJ9N00zOfYKTtPNrL3ahLMS5qp4wSyXes61S4xLBHxuAXrRz6yG9gr8rBIRgH4oWwU29EUHG6JTjD1eCSwp7e1L0uWH2WrPT+BbUikcvtvHiy96rLyo3v/3i+pE7cB/xRv/MEgl7vW0nch83USzvemmymTqlgqnEarcJxP/E9b3pm2Qk
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(86362001)(66476007)(31696002)(4326008)(8676002)(5660300002)(66556008)(38100700002)(316002)(6512007)(26005)(508600001)(186003)(6486002)(6666004)(53546011)(6506007)(31686004)(44832011)(36756003)(8936002)(2906002)(4744005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MXFIaXZwQVdjdWdzelV0eUhaSmlIeWhIdm9CMXh1OGszSW1WU05mL3FVYnpP?=
 =?utf-8?B?cDZaYStKdVU0TTFGc1BRVFB3b2V1ZFRiZUE0Tm5iSkxNRGRqWGFHSXVEdDh0?=
 =?utf-8?B?UEhyRi9TcEJ5N0hsOWdJdFo2N2QwS1d5SVBHOGJ5dUpSN2FibUw5dWV4cWtX?=
 =?utf-8?B?WDdrWi9kemMxV2RkUlEvSHVkRjRFQVU3QzhLK0N4R0NTbHRSWTNzVUhWZ0xw?=
 =?utf-8?B?YldtaVNpZDVJbi9VbkZNQTNHNHFHNytjSUNZanRBT28zWXpJS2R5N2xWd1ZE?=
 =?utf-8?B?Skt3NWpORmZpT21vQVV2V1dDSU9icUFMc1lTN2tkUFgxYUYvZG1uZFZYM3Jv?=
 =?utf-8?B?WWdld204Z3B0Wm9yUFZrQmxzSU43ZGZiVFJHWG5YdEYwWnB6a1I4WUduQTNN?=
 =?utf-8?B?ZzJKTmxnc2xxZGZVMmpUYTVkRDRpSlhNUG1IN3pvaVhFUFUxdzNTdjgyTHlF?=
 =?utf-8?B?UUtNbTFjRktVMFpVV2J2bStXN1B6QjZFclhyeFJpTlhqdmRJQnlSTnNGTURD?=
 =?utf-8?B?R0JweXFaYmNBTmVubEtJZVRXdWphdXA0WG5KV2tlaFNXL0lhOXJFc2dpUDZy?=
 =?utf-8?B?SVI2SkFJeHdjdUV3N0VzdEdwYTNYcjB6VG93WTcxbXFlcW85b0ExbWI0L3NK?=
 =?utf-8?B?M3BoK2RrNVlzS2o3S00zb3Y5cmN6eS9ndnlNUnNXaEJPb2VXM2ViOTE4aVpJ?=
 =?utf-8?B?V0RyaUNaVnYyZnExYURNUjNqcHNOYUtFeTU1SXA2UGtDMlg0Tzd1WVFzYTZi?=
 =?utf-8?B?OFVlOWdhV0RtL2dSWEdTeFdQSldKc0JhajJ5UER6YUt5OXJTMkxSa2NSNS93?=
 =?utf-8?B?SmdxdUY2OEc1V0pmVXRja2tSMy8wNCtaakk0STZEeVQ2bHNKY2VGeEZqVVBs?=
 =?utf-8?B?TXZnS2c0R3M1VWk4dGxTbnhIRENpY3lvcjU0emlMR2hzNzJpRUhIeFJ0UndE?=
 =?utf-8?B?NFdqc3NpdmJPN3RVUTNJZk1TWWdaN09lM0M3b3RhQk4wV2xSZVNZdmdIbUQ5?=
 =?utf-8?B?Q3R5NmoxSjVIQUxyVGVWQlU4WGkvSXk5TWdkbnJOaGtKTWxweEFnVUNldDBn?=
 =?utf-8?B?RFBJNTlDdGFpTHJWdzBQSUViSFdRSEE1dGFEVUJySVdpWGUwTWtyVlY2RSsz?=
 =?utf-8?B?R0p2NndHMXZ6YlN6MFFFcktIdkhLWjZ5OUhRbTZpc2VOcEFjUk1OSFNDQ0lo?=
 =?utf-8?B?MDIrbjM5WDg4ek5WSXlaKzJ0NURPYXZOd1UrdnJGRVRpT1hXQ3BSUWI5ajhS?=
 =?utf-8?B?ZDQrL2g4YWdVOGVpTFdndzBpbHpDTmkzNmROY2hKRUFJWWYyWjF3MWZaNk9l?=
 =?utf-8?B?WXlVOURWcFlZdExYRzZDVkFWV2pHYXY0MHZnenhjUFQxTlJYdThwZ2ljMGI5?=
 =?utf-8?B?Y1VvSEtnamJDUlFQUzdZdjZkZVRKTEY2NG9mOGtUenIySEdENDk3UDlNVWpn?=
 =?utf-8?B?MWFjUkgyZ3ljaGR5M2ZGOE9wU0FJSThrZmczRXpJVms5UlhNQTErQTdzQmxP?=
 =?utf-8?B?RldEekVTNUpNU3V1RXhkYjNEakRSMmpReS9OT2NOU1J6RC9yaGVjWjdkY1lo?=
 =?utf-8?B?cG1LS0FRNVZvamd6aWFmaGJLd0VhWDcrOXZNck5RekI0cnZkT0FHWlFzOGVP?=
 =?utf-8?B?SG13b1dteWtaUDBWcGlOY2ptV1ZUL3ZDczlEWXlCazlibWtjVjBuYmlCWlUy?=
 =?utf-8?B?cGRXMHQ1Q0pUTC9ucnN1K3dmQWtLNFNWWW1pbm9zbk9ZR3NVU1JteTZXU0to?=
 =?utf-8?B?RXM1elU3cFVZSG84KzloZVlxWUZkQWo0YUpKOHNBSVIwejdRcGhJTjlCd3pL?=
 =?utf-8?B?VmpwenVHeTdxT2xJZXlkdWpRWGgySzM0dGpjdHY2K0JCbjR2QUQxTTlBLzAw?=
 =?utf-8?B?Y256WDYvUzBEWDhYWWxQTmJIWUY0MlZvU3dxZWpDalBOamFTQTVWa2o2UHg2?=
 =?utf-8?B?QjRkMzE0TEdRaVBxWWhVZXlRTUQ4UHZEK2dPRy9wY0ZqN1g0Z3lnL3prelRS?=
 =?utf-8?B?MXppUW5pSXArd0RjQkpJcEYrdS80VXBSU2RJSTAxeFlrUUFnSE9JU3VOalMv?=
 =?utf-8?B?SFNzeVFCMDRHOFlOTUY4N0RTS01HSDlkTmF3YWE1ZHNUL3R6eUtPdGg0YlFy?=
 =?utf-8?B?eThqZHNiRnpSSVNNVm9xUExYNmtpQVBFQVQwRm01azFOc0FzeXFrZk9ybkhu?=
 =?utf-8?B?d05BaC9rWkgyTWNvV1FpWXYyYVQ5RTJhc0VMMU90VDFaVVdQR1pKczlTRVV3?=
 =?utf-8?B?VWxYUFhsR3I5bnlOVExhVG5WRXlRbytwQWtEUUZ1RWhWL0Zrd3NpVVhBSlNY?=
 =?utf-8?B?MmpwWnordGdyaGhFaWNpbTlsYWhPQ1BrSEpFdEFtOWMrOHlHZE9MVzlGRUdE?=
 =?utf-8?Q?ahXLLHU0dBCxssz0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5b83252-a378-4918-4fe4-08da18d1d0fb
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 20:04:26.2534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /gdLGAd+j1xDqALvMWQE5Tc7SRuJh/+R9mMsXmQ36H0XlKa6zsVaMZKmTv4oejkNeezk5WHvNjNKsdyeoZne9n/QwRqNS/ZjDEw2eJmTd9A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1472
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-07_01:2022-04-07,2022-04-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 spamscore=0
 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070064
X-Proofpoint-ORIG-GUID: OdMpIMOh9LFK_hvTvb4Zpv18Cayr15SY
X-Proofpoint-GUID: OdMpIMOh9LFK_hvTvb4Zpv18Cayr15SY


On 4/7/22 5:38 AM, Juergen Gross wrote:
> When running as a Xen PV guest use the extra memory (memory which isn't
> allocated for the guest at boot time) only for ballooning purposes and
> not for zone device allocations. This will remove some code without any
> lack of functionality.
>
> While at it move some code to get rid of another #ifdef.
>
> Remove a comment which is stale since some time now.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>





From xen-devel-bounces@lists.xenproject.org Thu Apr 07 20:52:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 20:52:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301002.513576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncZ7M-0007I2-BT; Thu, 07 Apr 2022 20:52:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301002.513576; Thu, 07 Apr 2022 20:52:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncZ7M-0007Hv-7j; Thu, 07 Apr 2022 20:52:36 +0000
Received: by outflank-mailman (input) for mailman id 301002;
 Thu, 07 Apr 2022 20:52:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncZ7K-0007Hl-6C; Thu, 07 Apr 2022 20:52:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncZ7K-0008Gh-4D; Thu, 07 Apr 2022 20:52:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncZ7J-0004wp-OF; Thu, 07 Apr 2022 20:52:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncZ7J-0003Kk-LG; Thu, 07 Apr 2022 20:52:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dQXQMLb32ruV53m7jQa/tUNAMo7wZZ1WCDp6lGJtFfc=; b=ZCYPZBNvu9MD/CGtdVCF1sjOT0
	orCefh0PiDVJ2VmBtRWVtJSqXUIWFOYY4jfQQeKsKIsqZXbkFJH1wEW5Ihr+9hXPuKaRjy5i9zrF3
	vNlaaBOgD3yxPZHKyUarLaMxD9rUBhXHFcL22q2ybpaoNT7xvJ7q3mCD48dJuin9n+sw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169222-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169222: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d3f61beea4255e2d86ae82303384c57a3262435e
X-Osstest-Versions-That:
    xen=d4012d50082c2eae2f3cbe7770be13b9227fbc3f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 20:52:33 +0000

flight 169222 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169222/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d3f61beea4255e2d86ae82303384c57a3262435e
baseline version:
 xen                  d4012d50082c2eae2f3cbe7770be13b9227fbc3f

Last test of basis   169217  2022-04-07 12:01:51 Z    0 days
Testing same since   169222  2022-04-07 17:00:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Ross Lagerwall <ross.lagerwall@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d4012d5008..d3f61beea4  d3f61beea4255e2d86ae82303384c57a3262435e -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 21:20:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 21:20:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301010.513586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncZXg-0002IL-Ih; Thu, 07 Apr 2022 21:19:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301010.513586; Thu, 07 Apr 2022 21:19:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncZXg-0002IE-Fp; Thu, 07 Apr 2022 21:19:48 +0000
Received: by outflank-mailman (input) for mailman id 301010;
 Thu, 07 Apr 2022 21:19:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncZXf-0002I4-HP; Thu, 07 Apr 2022 21:19:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncZXf-0000Mu-F8; Thu, 07 Apr 2022 21:19:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncZXf-0007TI-3O; Thu, 07 Apr 2022 21:19:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncZXf-0005ho-2v; Thu, 07 Apr 2022 21:19:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iuNP9K4KLlIf9CxrZMvTFnOyYH94LwCI7+hRKd64q5U=; b=49xSmDXVCdHDtd2SQYktsm6DHs
	wM50vEz1tQq7JcS1qi4DmnLULuRaNPgB4kkninLLPrmftifkTk9wS3h8fTExTku+wuiVTWtpgEEGP
	YMjcCmdAEqbYVZCaq1kN0vExsRUnsxQj0vWhrvVK4b3m99jZY9f/LHFNygjIjTd1V5Hs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169218-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169218: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=a298a84478053872ed9da660a75f182ce81b8ddc
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Apr 2022 21:19:47 +0000

flight 169218 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169218/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 a298a84478053872ed9da660a75f182ce81b8ddc
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   38 days
Failing since        168258  2022-03-01 01:55:31 Z   37 days  285 attempts
Testing same since   169173  2022-04-05 05:13:00 Z    2 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4610 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 22:37:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 22:37:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301020.513598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncaku-0003nj-D4; Thu, 07 Apr 2022 22:37:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301020.513598; Thu, 07 Apr 2022 22:37:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncaku-0003nc-8v; Thu, 07 Apr 2022 22:37:32 +0000
Received: by outflank-mailman (input) for mailman id 301020;
 Thu, 07 Apr 2022 22:37:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aJop=UR=cardoe.com=cardoe@srs-se1.protection.inumbo.net>)
 id 1ncaks-0003nW-TM
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 22:37:31 +0000
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4af91fc3-b6c3-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 00:37:28 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 739BF3200B5E
 for <xen-devel@lists.xenproject.org>; Thu,  7 Apr 2022 18:37:22 -0400 (EDT)
Received: from imap49 ([10.202.2.99])
 by compute1.internal (MEProxy); Thu, 07 Apr 2022 18:37:22 -0400
Received: by mailuser.nyi.internal (Postfix, from userid 501)
 id B7ACC15A005D; Thu,  7 Apr 2022 18:37:21 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4af91fc3-b6c3-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; h=cc
	:content-type:date:date:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to; s=fm1; bh=NRjo0gQPxPtQ0DxJJIo/qoaHlyx8Bge6EAXf7W
	pAT+4=; b=B/MvYysW4pIjuy6ykQemuJk8urLJbGsGCH80fmYr3CbqdOmczbOA6G
	9xd4HD1VnnqHj8od3yVt3WvD3OD+D77eWUKlZoGC6pbWszEWeuU4+XgCWYO7BRIo
	u3Z9UeItPLvR9FlTIuD2hhhO3VqwDr4SkmG7/wa35DVOwljBVAmKlN+f1oWxn2RV
	qavhsz5+IDfkFQ2ZYKqWsKvVf5+sLKBJ05zyrTc7/PuNvLJNS7XWAcug2bIrjeS+
	HWb8I2VcJ0W3CFtGvonPGg9jIS7lsEio+W8U6PoFXwfbVeQSJG4jGO4hWg9+o3iY
	6P5FvYAvdTft8M/8LNqn+AoAWstCzqfw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=NRjo0gQPxPtQ0DxJJ
	Io/qoaHlyx8Bge6EAXf7WpAT+4=; b=gc+iOMSmZbblY9fFQUAgKcJEsOklN/BKy
	R+KGGwS4gVe8/H0bj3PHkRKeFFxz2Vw8th5FaXRq3DheLAPVK2DxGp4pfUId+Yoo
	qzhEHH+pejTa5wY5xc7lRFX2JgfrcHL3dVOmlfenAw0dbbCjuyOkFKfV8S+kDror
	Oc9ZAfkocWQdxnWXc2T2Tya1th2YAreCH7pvBu3Ri1WbC/+yirC8VgE7V8NC5+2V
	baVnTCWefH3OMETfDgwNCHzpZyBfwzVrHzDsCE6tfn960cnPZFnDQDyWt63lmAsk
	cSja/uuN1sbeb21EWaiLjLdGpWrFupXGAWpc64y70pejXBzlQ9Vvw==
X-ME-Sender: <xms:oWdPYrN7IecAtCod2b7LGd8qcINHSw_cVwrIV9r4DPYSVF3zx5s7fA>
    <xme:oWdPYl-ZXgm16NK-Jqn4CnAsgEUiG9RYtWAGALLCJbkpLlAaplthiWxM56WMQO-EL
    _UDBm8FshJ3kcKW_co>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejledgudduucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsegrtd
    erreerredtnecuhfhrohhmpedfffhouhhglhgrshcuifholhgushhtvghinhdfuceotggr
    rhguohgvsegtrghrughovgdrtghomheqnecuggftrfgrthhtvghrnhepvdefjeduleeivd
    egleelffegleeljeehjeeiueekudfhgfegveehheeludehjedtnecuffhomhgrihhnpehg
    ihhtlhgrsgdrtghomhdpthhrrghvihhsqdgtihdrohhrghenucevlhhushhtvghrufhiii
    gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtrghrughovgestggrrhguohgvrdgt
    ohhm
X-ME-Proxy: <xmx:oWdPYqT_BrhCnYnOPqENOrGPG_uDXOpjAn0EllTJr2kf2gPFcRAc_Q>
    <xmx:oWdPYvucu8z550g2mKJlTsLbzVwjzrhT0gLaDFsMHrgdnUrpP2E2-g>
    <xmx:oWdPYjcdk1h6V8sItcsLA-z_ApDDYzsinZlEr4kxn0hvcFpvei3XnQ>
    <xmx:omdPYtqJVDEz00rrFiMSIlY9BUmspHJeMy9PSekeQLV9u7tdp4tSnA>
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.7.0-alpha0-386-g4174665229-fm-20220406.001-g41746652
Mime-Version: 1.0
Message-Id: <e92fdb05-c0c7-4006-9b52-952028eaf95f@www.fastmail.com>
In-Reply-To: 
 <alpine.DEB.2.22.394.2204061323490.2910984@ubuntu-linux-20-04-desktop>
References: 
 <alpine.DEB.2.22.394.2204061323490.2910984@ubuntu-linux-20-04-desktop>
Date: Thu, 07 Apr 2022 17:37:01 -0500
From: "Douglas Goldstein" <cardoe@cardoe.com>
To: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] MAINTAINERS: add myself as Continuous Integration maintainer
Content-Type: multipart/alternative;
 boundary=6a531eadccdc48d0a383929157f936a5

--6a531eadccdc48d0a383929157f936a5
Content-Type: text/plain


On Wed, Apr 6, 2022, at 3:27 PM, Stefano Stabellini wrote:
> I have contributed all the ARM tests to gitlab-ci. After checking with
> Doug, I am happy to volunteer to co-maintain Continuous Integration.
> 
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> Acked-by: Doug Goldstein <cardoe@cardoe.com>
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6a097b43eb..cc87d5bbf1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -262,6 +262,7 @@ F: CHANGELOG.md
>  
> Continuous Integration (CI)
> M: Doug Goldstein <cardoe@cardoe.com>
> +M: Stefano Stabellini <sstabellini@kernel.org>
> W: https://gitlab.com/xen-project/xen
> W: https://travis-ci.org/xen-project/xen
> S: Supported
> 
Just want to make my ACK explicit here.
--6a531eadccdc48d0a383929157f936a5
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>=
On Wed, Apr 6, 2022, at 3:27 PM, Stefano Stabellini wrote:<br></div><blo=
ckquote type=3D"cite" id=3D"qt" style=3D""><div>I have contributed all t=
he ARM tests to gitlab-ci. After checking with<br></div><div>Doug, I am =
happy to volunteer to co-maintain Continuous Integration.<br></div><div>=
<br></div><div>Signed-off-by: Stefano Stabellini &lt;<a href=3D"mailto:s=
stabellini@kernel.org">sstabellini@kernel.org</a>&gt;<br></div><div>Acke=
d-by: Doug Goldstein &lt;<a href=3D"mailto:cardoe@cardoe.com">cardoe@car=
doe.com</a>&gt;<br></div><div><br></div><div>diff --git a/MAINTAINERS b/=
MAINTAINERS<br></div><div>index 6a097b43eb..cc87d5bbf1 100644<br></div><=
div>--- a/MAINTAINERS<br></div><div>+++ b/MAINTAINERS<br></div><div>@@ -=
262,6 +262,7 @@ F:	CHANGELOG.md<br></div><div>&nbsp;<br></div><div>Conti=
nuous Integration (CI)<br></div><div>M:	Doug Goldstein &lt;<a href=3D"ma=
ilto:cardoe@cardoe.com">cardoe@cardoe.com</a>&gt;<br></div><div>+M:	Stef=
ano Stabellini &lt;<a href=3D"mailto:sstabellini@kernel.org">sstabellini=
@kernel.org</a>&gt;<br></div><div>W: <a href=3D"https://gitlab.com/xen-p=
roject/xen">https://gitlab.com/xen-project/xen</a><br></div><div>W: <a h=
ref=3D"https://travis-ci.org/xen-project/xen">https://travis-ci.org/xen-=
project/xen</a><br></div><div>S:	Supported<br></div><div><br></div></blo=
ckquote><div>Just want to make my ACK explicit here.<br></div></body></h=
tml>
--6a531eadccdc48d0a383929157f936a5--


From xen-devel-bounces@lists.xenproject.org Thu Apr 07 22:44:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Apr 2022 22:44:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301026.513609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncarg-0005c4-7H; Thu, 07 Apr 2022 22:44:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301026.513609; Thu, 07 Apr 2022 22:44:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncarg-0005bx-47; Thu, 07 Apr 2022 22:44:32 +0000
Received: by outflank-mailman (input) for mailman id 301026;
 Thu, 07 Apr 2022 22:44:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vJP+=UR=linux-foundation.org=akpm@srs-se1.protection.inumbo.net>)
 id 1ncarf-0005br-0N
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 22:44:31 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 48d636e7-b6c4-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 00:44:29 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id B7E8BB82816;
 Thu,  7 Apr 2022 22:44:28 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4757EC385A4;
 Thu,  7 Apr 2022 22:44:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48d636e7-b6c4-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1649371467;
	bh=hIvqS6RVxt92RR7xvo4WKRMmb/Y56ZN8tL5vx0hkAGs=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=HM77SMATfGFl5LMW36PL6MtnIJvmB/XAW+fcPCI29k5nWhVpuUTY3HzmBNmIqdg3v
	 uP48N1JWMBDzHVnrKsuoXOsc22VHVDUHOfbrW1ak0p4vMB9ounTiSYUk6QPs7aeNlq
	 SzxKfbBfdjsvz1qfo0G3dGVoLZu5FtkwlT9+a+ME=
Date: Thu, 7 Apr 2022 15:44:26 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, stable@vger.kernel.org, Marek
 =?ISO-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
 Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2] mm, page_alloc: fix build_zonerefs_node()
Message-Id: <20220407154426.7076e19f5b80d927dd715de9@linux-foundation.org>
In-Reply-To: <20220407120637.9035-1-jgross@suse.com>
References: <20220407120637.9035-1-jgross@suse.com>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu,  7 Apr 2022 14:06:37 +0200 Juergen Gross <jgross@suse.com> wrote:

> Since commit 6aa303defb74 ("mm, vmscan: only allocate and reclaim from
> zones with pages managed by the buddy allocator")

Six years ago!

> only zones with free
> memory are included in a built zonelist. This is problematic when e.g.
> all memory of a zone has been ballooned out when zonelists are being
> rebuilt.
> 
> The decision whether to rebuild the zonelists when onlining new memory
> is done based on populated_zone() returning 0 for the zone the memory
> will be added to. The new zone is added to the zonelists only, if it
> has free memory pages (managed_zone() returns a non-zero value) after
> the memory has been onlined. This implies, that onlining memory will
> always free the added pages to the allocator immediately, but this is
> not true in all cases: when e.g. running as a Xen guest the onlined
> new memory will be added only to the ballooned memory list, it will be
> freed only when the guest is being ballooned up afterwards.
> 
> Another problem with using managed_zone() for the decision whether a
> zone is being added to the zonelists is, that a zone with all memory
> used will in fact be removed from all zonelists in case the zonelists
> happen to be rebuilt.
> 
> Use populated_zone() when building a zonelist as it has been done
> before that commit.
> 
> Cc: stable@vger.kernel.org

Some details, please.  Is this really serious enough to warrant
backporting?  Is some new workload/usage pattern causing people to hit
this?



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 00:01:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 00:01:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301036.513643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncc3a-0008IG-0t; Fri, 08 Apr 2022 00:00:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301036.513643; Fri, 08 Apr 2022 00:00:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncc3Z-0008I4-SG; Fri, 08 Apr 2022 00:00:53 +0000
Received: by outflank-mailman (input) for mailman id 301036;
 Fri, 08 Apr 2022 00:00:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncc3Z-0008HQ-Ew
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 00:00:53 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3829b66-b6ce-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 02:00:51 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C7B6161714;
 Fri,  8 Apr 2022 00:00:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB34BC385A0;
 Fri,  8 Apr 2022 00:00:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3829b66-b6ce-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649376049;
	bh=c5dS3TwPtb69HRei2wtCh2ZccLHimKYt5cZX8Ct28zU=;
	h=Date:From:To:cc:Subject:From;
	b=j36RiKVYNWyfjjmwg5BkWi5PrlHtH5O9Mh7XQCI9sXXYp6YuPr1f8Ui08Y72Am4ZU
	 Q6x7Cta2LKdlblyGinW9IgFSNP6Nouj9Nck67/Puh6MZstF9yLJCAY4UWjO1e1Nx3u
	 k3qNanO2CDVYHu3M43C35ugC+9arlDOKmE+ERy4rmdueIyA6upcpnl6ng7YWCMmZtY
	 r0bX1sXa11aNwm8Oc9o2lGCZxGtSziMK9gtcKuGhsWy0fj4ThW5gINyUzR4RDkC8KV
	 JkV0ODdZHSFqKKSGcEX5J4bmcW25ivMA6d66MwU7IA7lnRGlD0kc382JkmQbFNrL4R
	 hn0W4hycmeVaQ==
Date: Thu, 7 Apr 2022 17:00:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, cardoe@cardoe.com, anthony.perard@citrix.com, 
    andrew.cooper3@citrix.com
Subject: [PATCH v2] MAINTAINERS: add myself as Continuous Integration
 maintainer
Message-ID: <alpine.DEB.2.22.394.2204071658320.2910984@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

I have contributed all the ARM tests to gitlab-ci. After checking with
Doug, I am happy to volunteer to co-maintain Continuous Integration.

Also take the opportunity to remove the stale travis-ci entries.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Doug Goldstein <cardoe@cardoe.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
---
Changes in v2:
- add Anthony's ack;
- remove the stale travis-ci entries

diff --git a/MAINTAINERS b/MAINTAINERS
index 6a097b43eb..2a47fafe85 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -262,11 +262,10 @@ F:	CHANGELOG.md
 
 Continuous Integration (CI)
 M:	Doug Goldstein <cardoe@cardoe.com>
+M:	Stefano Stabellini <sstabellini@kernel.org>
 W:	https://gitlab.com/xen-project/xen
-W:	https://travis-ci.org/xen-project/xen
 S:	Supported
 F:	.gitlab-ci.yml
-F:	.travis.yml
 F:	automation/
 F:	scripts/travis-build
 


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 00:01:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 00:01:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301039.513659 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncc3u-0000HE-AV; Fri, 08 Apr 2022 00:01:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301039.513659; Fri, 08 Apr 2022 00:01:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncc3u-0000H7-70; Fri, 08 Apr 2022 00:01:14 +0000
Received: by outflank-mailman (input) for mailman id 301039;
 Fri, 08 Apr 2022 00:01:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncc3s-0000G6-Pt; Fri, 08 Apr 2022 00:01:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncc3s-0003cn-NQ; Fri, 08 Apr 2022 00:01:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncc3s-0006ul-6t; Fri, 08 Apr 2022 00:01:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncc3s-0006Xy-6S; Fri, 08 Apr 2022 00:01:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QhSgAMptURT3uDvjP15GGC7Z1gWju5CFLHpSvZqLZnI=; b=QTHr7J6RHQwBCkLOEV417F2bye
	J5eb4YOHpZiFof2jJdAfovBpcXY+mKeMHbdlgjrxfS5mCHHNCwzlcjXLzDkpbePq9p/bWR0j6c4U0
	rwVzAAqyVsPVNxudx2g//j2utQpXwkdO0ncbrJy1LiOwqv+AIb3uq5XVkLFgHf5HTiDQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169212-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169212: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d7b22226b5172c86c0c19b23edc16a4432d04fb8
X-Osstest-Versions-That:
    xen=faed81ff3940b377a981af37a89161bddcacdaf5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 00:01:12 +0000

flight 169212 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169212/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169186
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169186
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169186
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169186
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169186
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169186
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169186
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169186
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169186
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169186
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169186
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169186
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  d7b22226b5172c86c0c19b23edc16a4432d04fb8
baseline version:
 xen                  faed81ff3940b377a981af37a89161bddcacdaf5

Last test of basis   169186  2022-04-05 15:02:53 Z    2 days
Testing same since   169212  2022-04-07 07:36:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Olson <Alex.Olson@starlab.io>
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Juergen Gross <jgross@suse.com>
  Kevin Stefanov <kevin.stefanov@citrix.com>
  Lasse Collin <lasse.collin@tukaani.org>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   faed81ff39..d7b22226b5  d7b22226b5172c86c0c19b23edc16a4432d04fb8 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 00:03:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 00:03:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301056.513702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncc69-0001T1-2O; Fri, 08 Apr 2022 00:03:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301056.513702; Fri, 08 Apr 2022 00:03:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncc68-0001Su-Vg; Fri, 08 Apr 2022 00:03:32 +0000
Received: by outflank-mailman (input) for mailman id 301056;
 Fri, 08 Apr 2022 00:03:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncc67-0001Sk-7v
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 00:03:31 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5236b6f6-b6cf-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 02:03:30 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 3D87E60F36;
 Fri,  8 Apr 2022 00:03:29 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F3AAC385A5;
 Fri,  8 Apr 2022 00:03:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5236b6f6-b6cf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649376208;
	bh=K6WP8MFCn7MSjHyNGFY18z+tla2/JeIqNJRvlZjXy2c=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=WBtRgMLg8sQGT6TIBHczPIbnR8gPXgbmwAN/jrcB6ICqQCMHPS2bFafjQe7tH5F06
	 RbhaldsjMLHUXEO0OwYdfmrjzh5GhlvRwAZoztjJfoEJtXhQzoFZNs70CZ2notXfSb
	 mVk3dALqer8AhLzf7zfpf5uB8DpgX5rMXGVG+tYVTZZB73t+U/LkKbpKt829Cn7s6a
	 0l5BYuL5HCRIPbX0S9L7+z7xaDeIw0hl6H6hqIh/zm8XOVQ69zncoRUQsJDiHz11Au
	 qYLyEU3u342p/OtLYFZs5bTvcJamAO9kL2P5la8m8C0cZ2IqAIEZBcYE12tln5Oy9l
	 nRMwCVe1erDAw==
Date: Thu, 7 Apr 2022 17:03:27 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, 
    george.dunlap@citrix.com, jbeulich@suse.com, iwj@xenproject.org, 
    wl@xen.org, Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v2] SUPPORT.md: add Dom0less as Supported
In-Reply-To: <80f0eb2a-43c0-7663-a1ca-481535361c68@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204071703120.2910984@ubuntu-linux-20-04-desktop>
References: <20210714234809.30483-1-sstabellini@kernel.org> <80f0eb2a-43c0-7663-a1ca-481535361c68@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 7 Apr 2022, Julien Grall wrote:
> Hi Stefano,
> 
> On 15/07/2021 00:48, Stefano Stabellini wrote:
> > Add Dom0less to SUPPORT.md to clarify its support status. The feature is
> > mature enough and small enough to make it security supported.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> I was going through my inbox and notice this was no follow-up. Dom0less is
> getting more traction, so I think it would be good for us to have a support
> statement.
> 
> Is it still under your radar?

Totally fell through the cracks. I'll resend.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 00:10:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 00:10:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301062.513712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nccD4-0003Lb-Td; Fri, 08 Apr 2022 00:10:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301062.513712; Fri, 08 Apr 2022 00:10:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nccD4-0003LU-Qe; Fri, 08 Apr 2022 00:10:42 +0000
Received: by outflank-mailman (input) for mailman id 301062;
 Fri, 08 Apr 2022 00:10:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nccD3-0003LO-Vf
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 00:10:41 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 530072a6-b6d0-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 02:10:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id C6AFDB829AF;
 Fri,  8 Apr 2022 00:10:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27795C385A4;
 Fri,  8 Apr 2022 00:10:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 530072a6-b6d0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649376638;
	bh=mKuPJUxAnDUNxszfqdZ+hoE5YPUItakxxFDr0vIqiMw=;
	h=Date:From:To:cc:Subject:From;
	b=usUkFlMgkV/y8OGo9a2E425NttgYS791eHy4Z08whLj6oR4MfUoFcr9AXL9pOvbj0
	 pYdja/UyKX0UO4TtwyplE7VV+r5nghbliqXclJZnDTHFbKpcrF/kz+p080cbHHEUks
	 rSQK6a/ONgmns5aRoVkHcN4HL4E7so0HRr0ulZ4ABJk1zOm5z5WW9x1teXXtGO2Ztx
	 DBRsKIm0xBa5asU17zT5enifQ9dqnPG0sOMCk5A0vCrUHH/BBBn+ikcTbmLynpTCjS
	 n3ncDbyiL5xgshcEmk7PacyEv0GQsDGKHlHMEnF5NSUq94UN/nW7Sks4YuV3HWhCyk
	 PsrxVWwJT3zIw==
Date: Thu, 7 Apr 2022 17:10:37 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, julien@xen.org, andrew.cooper3@citrix.com, 
    george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org
Subject: [PATCH v3] SUPPORT.md: add Dom0less as Supported
Message-ID: <alpine.DEB.2.22.394.2204071706470.2910984@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Add Dom0less to SUPPORT.md to clarify its support status. The feature is
mature enough and small enough to make it security supported.

Clarify that dom0less DomUs memory is not scrubbed at boot when
bootscrub=on or bootscrub=off are passed as Xen command line parameters,
and no XSAs will be issued for that.

Also see XSA-372: 371347c5b64da and fd5dc41ceaed.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v3:
- improve commit messahe
- improve SUPPORT.md statement
- add Bertrand's reviewed-by

Changes in v2:
- clarify memory scrubbing
---

diff --git a/SUPPORT.md b/SUPPORT.md
index 32fb0aa8de..088dda9561 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -882,6 +882,17 @@ OVMF firmware implements the UEFI boot protocol.
 
     Status, qemu-xen: Supported
 
+## Dom0less
+
+Guest creation from the hypervisor at boot without Dom0 intervention.
+
+    Status, ARM: Supported
+
+Memory of dom0less DomUs is not scrubbed at boot when bootscrub=on or
+bootscrub=off are passed as Xen command line parameters. (Memory should
+be scrubbed with bootscrub=idle.) No XSAs will be issues due to
+unscrubbed memory.
+
 # Format and definitions
 
 This file contains prose, and machine-readable fragments.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 00:35:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 00:35:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301066.513724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nccaQ-0006OW-V4; Fri, 08 Apr 2022 00:34:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301066.513724; Fri, 08 Apr 2022 00:34:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nccaQ-0006OP-Qe; Fri, 08 Apr 2022 00:34:50 +0000
Received: by outflank-mailman (input) for mailman id 301066;
 Fri, 08 Apr 2022 00:34:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nccaP-0006OF-IF; Fri, 08 Apr 2022 00:34:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nccaP-0004Dc-Ey; Fri, 08 Apr 2022 00:34:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nccaO-0000l1-WA; Fri, 08 Apr 2022 00:34:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nccaO-0005JI-Vg; Fri, 08 Apr 2022 00:34:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/RYu7BjkPZLVY4mCizBVd+xDY65ykiLr+VDmjv+mKHE=; b=lpq6K6HWHZPZIK1+umm9z5R9Zf
	GHVD5zYli/vpbENrdctLT28VHL8XPXfwqxFIyKAohcTou1Ju/Yhy0CMrVvnexBuN2sQxztOuU4T74
	BBTZcGuQp6/CYimmfs1YxhDK2ad1UzGUG3GoHnOE7YRqPtKMBXJVYCk3hNC87LYqgDFM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169208-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169208: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=95a3fcc7487e5bef262e1f937ed8636986764c4e
X-Osstest-Versions-That:
    qemuu=f53faa70bb63cc0c8e2fd0752b7ad2c8a79616ba
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 00:34:48 +0000

flight 169208 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169208/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169195
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169195
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169195
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169195
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169195
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169195
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169195
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169195
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                95a3fcc7487e5bef262e1f937ed8636986764c4e
baseline version:
 qemuu                f53faa70bb63cc0c8e2fd0752b7ad2c8a79616ba

Last test of basis   169195  2022-04-06 09:26:58 Z    1 days
Testing same since   169208  2022-04-07 06:16:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   f53faa70bb..95a3fcc748  95a3fcc7487e5bef262e1f937ed8636986764c4e -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 00:50:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 00:50:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301074.513735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nccpU-0000wO-Ay; Fri, 08 Apr 2022 00:50:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301074.513735; Fri, 08 Apr 2022 00:50:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nccpU-0000wH-7v; Fri, 08 Apr 2022 00:50:24 +0000
Received: by outflank-mailman (input) for mailman id 301074;
 Fri, 08 Apr 2022 00:50:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9kDr=US=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1nccpT-0000wB-4x
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 00:50:23 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2061c.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::61c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dd7ac3f5-b6d5-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 02:50:21 +0200 (CEST)
Received: from FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17)
 by AM9PR08MB6242.eurprd08.prod.outlook.com (2603:10a6:20b:283::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 00:50:18 +0000
Received: from VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1e:cafe::f8) by FR0P281CA0078.outlook.office365.com
 (2603:10a6:d10:1e::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.12 via Frontend
 Transport; Fri, 8 Apr 2022 00:50:18 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT035.mail.protection.outlook.com (10.152.18.110) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Fri, 8 Apr 2022 00:50:17 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Fri, 08 Apr 2022 00:50:16 +0000
Received: from cad39a13cb8c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 816A0150-1EFF-4DB9-BD43-CE0956A4E65A.1; 
 Fri, 08 Apr 2022 00:50:11 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cad39a13cb8c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Apr 2022 00:50:11 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by HE1PR0801MB1995.eurprd08.prod.outlook.com (2603:10a6:3:52::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Fri, 8 Apr
 2022 00:50:09 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a%4]) with mapi id 15.20.5144.022; Fri, 8 Apr 2022
 00:50:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd7ac3f5-b6d5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IeAy2b+ry8eus9mR99lysqtlW1p6PP0BsLtk7hOrYbM=;
 b=F0zjxegPFgguSKsBKbtmk5u+tyKUD9kH67fIgqngn3YvL/oWqcxOAZwIkUkqcQjUx9rNGdEr8u+esmy06MPktnvnHS2oR33xudhr7FPgmCrPJrii4c5bzMCxiGsbgKndyoR8mu+VNq5OF+SFVA7iV+9YPPoPt2Nv4ra9/An473s=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y8lLnpdyA4ep6mBEetXXowbUBFTDMObAzgDqAqwmGDjFP5jiYsDYJ0zkk9hT8mYrBvoaaJNwuI4yWA0WhlE7pAcvtsXSoaH1GN9ipPxtrr52z5Dt0xHCCyusU9m6FBcG1ZU8+WGXs7CJrwrW46bVCZtlnFqXu0oi2bddbRY0/9vOByPZKlA+eQAFJXHdffIIsNiGxbnwQxAmTeRbCz3u1j6uC1DQdyQOyo0bXCFN/UKsVXbaokmTA9juVnCrkUTNCPkYBUtna4LYJQwCFC+HUhC6Ld7QU6hOPqaqV/+51ae62ozxF9gMHzKYDroyhGgxBHJJ9mVNEKFSoOqMgXooag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IeAy2b+ry8eus9mR99lysqtlW1p6PP0BsLtk7hOrYbM=;
 b=DT2WAmYVKY41t5HWk02mt1++/2CUW03JaiTiaaNh44s6/36a+UMX0A1cuhyZFRcHOdNUhxR7t19awjwk85IesYvyOWNxUo5AUFUuBJOvH/CKQDRnAOrr/b/V1TiI9BvQZo89gFdvsqSkEu+7IGUHQTXg5dyLaVjE+FGrpHrgewsoyppFfTKhLG6Dcmk9T6MQ15Xsb5WCknqXO5AZrRxIBMug2MDMrjNVb+LgH/SHFnACf9o7eCCHQ2uMXVd6eMTxpix7NqLnXXQWNmdJxMu4rM451PbWaIjUqEhHuRnk+ftVJDIRYZlT7pS/5WOlA7DMWl29Xeke8QmcmtYjxocm2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IeAy2b+ry8eus9mR99lysqtlW1p6PP0BsLtk7hOrYbM=;
 b=F0zjxegPFgguSKsBKbtmk5u+tyKUD9kH67fIgqngn3YvL/oWqcxOAZwIkUkqcQjUx9rNGdEr8u+esmy06MPktnvnHS2oR33xudhr7FPgmCrPJrii4c5bzMCxiGsbgKndyoR8mu+VNq5OF+SFVA7iV+9YPPoPt2Nv4ra9/An473s=
From: Henry Wang <Henry.Wang@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "julien@xen.org" <julien@xen.org>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>,
	"wl@xen.org" <wl@xen.org>
Subject: RE: [PATCH v3] SUPPORT.md: add Dom0less as Supported
Thread-Topic: [PATCH v3] SUPPORT.md: add Dom0less as Supported
Thread-Index: AQHYSt1CmA0pSQ994kax2RW1hM7xyKzlLkpg
Date: Fri, 8 Apr 2022 00:50:09 +0000
Message-ID:
 <PA4PR08MB6253660FF724000CFCD7A8C192E99@PA4PR08MB6253.eurprd08.prod.outlook.com>
References:
 <alpine.DEB.2.22.394.2204071706470.2910984@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204071706470.2910984@ubuntu-linux-20-04-desktop>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 6E6DD5A437362D4ABADF617DAE949013.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: a09f3da8-ff27-4e97-d1d9-08da18f9c00e
x-ms-traffictypediagnostic:
	HE1PR0801MB1995:EE_|VE1EUR03FT035:EE_|AM9PR08MB6242:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB6242129911C58389BD1B07CE92E99@AM9PR08MB6242.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 hDzKby7sWY+jCDCd4sqongvXlSWVVKv3tbG0w0CZLWjWvpswqG3WMmXCRLSHyKZ4EidHTJj0NZ6qvnDVuflMh2S86kZ1MSnaZ3R0wnDccKQuVZgsVA5XBVAkdFewsOsOiZLNQzeOkgKygk6DY3Xdet6bS+wydbwhqRSMXaXgVrQ1e5I+7+223rytOJpbESGHb8nHMpc5MHte8tc3eZ/ZtR8DZ6Dx7q0EweXzMXZxp0i8mqXd7N/uywuGix0cc7Rt+pS4si6Dlk9Znwx6stHpVUtBN06zM6Y2oy4u5LWVZDqvTsandcG6uA/ovuH+BKUmZDzGRjiswEiJuBjpRXa9XLP6fqC3nYMY6xLf5pAssRufcfsaGSDBDORUGhmSMSfVsKkSVjm94O9qA+nov29F/doQJEFnMkswWh68C0cGx/Q3IA2A8FRht4KL7BsjioXqXCekAuayP8eDVuEh9/Rnb+VEZ0cHL35jQujOqx7xWU124HIB7+JVXayfIsXXFQRUXnX62MdPeLoeFnV4S2mhmhyoz6mkcPrfmH+7Pty/pd2EEaPlPbVgLU+L2ibMoNm7TbixKBiiz07zNQ5A40A4mDXgQHQO4M6ILJ9YB/RhJeE8aeEFA86q1L5rfQ7UF4nkHsCpDVcHoh82doZI/STxvG23/XH6MCMzjUIrtDjlEce5uCiaIyXLlM4eRhAwu82zOw+yEs39LjUy49R0qg1GqIEujBT+f5WMedB9lez0vhU=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(508600001)(66946007)(38070700005)(8676002)(4326008)(71200400001)(8936002)(66446008)(66476007)(33656002)(52536014)(110136005)(54906003)(55016003)(2906002)(186003)(66556008)(64756008)(7696005)(316002)(76116006)(38100700002)(53546011)(6506007)(83380400001)(26005)(86362001)(9686003)(5660300002)(32563001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1995
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	01361518-c69b-4d84-7ec2-08da18f9bb5c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FM4TiSPVH7+AvovfjVSnNxFZ2aAYhF61fty/z3saLIsMDleCzF4Q5wwseu6oBi1gT/rm7YCyPDexQQQ61Ta74dJm0WIxkhUf3yju3RWxyZypBMl3Naya2t5iRX8kujKa9OqMMzEUzxCtNXhN/lS7qtFLxyogw4lzxFFSNv8UA9C3oiQrxU2up9lBsXrqeD47+v6E1NAXg75TSbLY+jVSlRWgw7uS1et7Skfi148vUyvRuDwXibePTiedHxbHBfRQBIlwLYrgMIJEpL3B1+bppVDrs64RxV4Yd9CSh88v5iPDqcwdwqAZn5aAOf+8/H71XzARsKTB7n/beOOH6kaGqLSnP5/QbMckfkiMHDt74vlwxezPyTPQ3oA4hM00wocYsMlMKLi6zPJ0uqaKldckyUGZbnlNuFnMJ0Hb6DQufK/DapJEduaIJ4umqjawZJcsk849DmQfv/MeggaLfWCUyu3YTkQQQq4YvoxizlDkLx4Pk7vghAhyDZTxkpZVZM4DeSbk9w0+P7/HSGJGEWVZT78YSotCfU73kmZUP3KbfoeXZMyF/Is8re0MOBPJ03DkOfI4eUw38ZuTE2aRhHG//3hbGJw9zciwVlW1+Z/FbvRWOO7Vj66OtGu9SQb3wsuAV18Gbq94E/JHylT6DeC8SCxg35N+I+Hh1+EGoH6zivJBZr9j70RjkIiLZ1ZiXZyFl9eomMJu1wCFz+pVDXQf9A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(26005)(54906003)(83380400001)(110136005)(8936002)(2906002)(186003)(82310400005)(316002)(40460700003)(336012)(86362001)(356005)(81166007)(47076005)(9686003)(70206006)(70586007)(36860700001)(5660300002)(508600001)(33656002)(4326008)(6506007)(8676002)(7696005)(52536014)(53546011)(55016003)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 00:50:17.3372
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a09f3da8-ff27-4e97-d1d9-08da18f9c00e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6242

Hi Stefano,

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Stefano Stabellini
> Sent: Friday, April 8, 2022 8:11 AM
> To: xen-devel@lists.xenproject.org
> Cc: sstabellini@kernel.org; julien@xen.org; andrew.cooper3@citrix.com;
> george.dunlap@citrix.com; jbeulich@suse.com; wl@xen.org
> Subject: [PATCH v3] SUPPORT.md: add Dom0less as Supported
>=20
> Add Dom0less to SUPPORT.md to clarify its support status. The feature is
> mature enough and small enough to make it security supported.
>=20
> Clarify that dom0less DomUs memory is not scrubbed at boot when
> bootscrub=3Don or bootscrub=3Doff are passed as Xen command line paramete=
rs,
> and no XSAs will be issued for that.
>=20
> Also see XSA-372: 371347c5b64da and fd5dc41ceaed.
>=20
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> Changes in v3:
> - improve commit messahe

For the patch I don't have any comments, but I think here we've got
a typo: s/messahe/message. I think it is ok to fix while committing this
patch so this is just a kind reminder :))

Kind regards,
Henry=20



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 02:11:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 02:11:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301079.513746 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nce59-0004N4-Br; Fri, 08 Apr 2022 02:10:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301079.513746; Fri, 08 Apr 2022 02:10:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nce59-0004Mw-5z; Fri, 08 Apr 2022 02:10:39 +0000
Received: by outflank-mailman (input) for mailman id 301079;
 Fri, 08 Apr 2022 02:10:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nce58-0004Mm-Ci; Fri, 08 Apr 2022 02:10:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nce58-0006vC-90; Fri, 08 Apr 2022 02:10:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nce57-0005wf-Td; Fri, 08 Apr 2022 02:10:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nce57-0003tU-TC; Fri, 08 Apr 2022 02:10:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/hA1OaX2PWi+CCOmDYwh2BU7IJ8f26JLSxigoBBOOzU=; b=KiHFdG5I2zCWz/rtaNXHcNnHN3
	lvJCp0tYjAgvKog9l85XQ2c0Nr7/x9852zHjk2ox51jInrYtdAdBt3FJgIwaNSNKOqy7trXHdZB7M
	hWa2VfJcGxxL+UroAPqi0E8j7DvtJkl0IxnSm67gXQJD8GPr3RlR16wrHEej2M2/RaLw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169214-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.12-testing test] 169214: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.12-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.12-testing:test-amd64-i386-xl-vhd:guest-localmigrate/x10:fail:heisenbug
    xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c633ec9451e76015c409bd5119ffcb0f2e61fe8b
X-Osstest-Versions-That:
    xen=944afa38d9339a67f0164d07fb7ac8a54e9a4c60
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 02:10:37 +0000

flight 169214 xen-4.12-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169214/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd     12 debian-di-install fail in 169184 pass in 169214
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 169184 pass in 169214
 test-amd64-i386-xl-vhd       19 guest-localmigrate/x10     fail pass in 169184

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qcow2    19 guest-localmigrate/x10  fail blocked in 168480
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168480
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168480
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168480
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168480
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168480
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168480
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168480
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168480
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168480
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168480
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168480
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168480
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c633ec9451e76015c409bd5119ffcb0f2e61fe8b
baseline version:
 xen                  944afa38d9339a67f0164d07fb7ac8a54e9a4c60

Last test of basis   168480  2022-03-08 18:07:22 Z   30 days
Testing same since   169184  2022-04-05 14:06:03 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   944afa38d9..c633ec9451  c633ec9451e76015c409bd5119ffcb0f2e61fe8b -> stable-4.12


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 03:50:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 03:50:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301102.513813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncfd6-00005c-8J; Fri, 08 Apr 2022 03:49:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301102.513813; Fri, 08 Apr 2022 03:49:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncfd6-00005V-56; Fri, 08 Apr 2022 03:49:48 +0000
Received: by outflank-mailman (input) for mailman id 301102;
 Fri, 08 Apr 2022 03:49:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XiXL=US=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1ncfd4-00005P-0l
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 03:49:46 +0000
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e96df4ab-b6ee-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 05:49:41 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 07 Apr 2022 20:49:36 -0700
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
 by orsmga003.jf.intel.com with ESMTP; 07 Apr 2022 20:49:36 -0700
Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by
 ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Thu, 7 Apr 2022 20:49:36 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Thu, 7 Apr 2022 20:49:36 -0700
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107)
 by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Thu, 7 Apr 2022 20:49:36 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by MN2PR11MB4192.namprd11.prod.outlook.com (2603:10b6:208:13f::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 03:49:33 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%9]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022
 03:49:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e96df4ab-b6ee-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649389781; x=1680925781;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=VsUhYrABAvhixG0HToXLVsh6lPWgrKHiTOKfvrp0woc=;
  b=QqZDhv6SpbnJPaqVbUWNFpq+YZv3XVjT0MA4N28ZP6tRNvUG7lPfDlHj
   tZVU1chDDXV+pcqRrA+1ckBIj9EiN9Djlojngj01IEj36SS4ohj6u2lh6
   W9MwPOYK+P4LrXG6OBtlnGd42Q34wpKy5XCVcYKWHlFcqDjcslTDfJjJ2
   ew25ORcnnuwn/3a4fyhqGVtxuta2b8eTzLHmi/s6lyJvXnhT12Y+ld7rL
   Ka4tFSjoXLs6L1TgHndVdyq6NsDxwOkxIq1kwU4QEhn7fZbkP/ndKcqbc
   MJG+wRZQI96aIshsMewASXVJEHG6ZJQBnNqKkN1pE3QsGZAlutlMPLKj/
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="243634531"
X-IronPort-AV: E=Sophos;i="5.90,243,1643702400"; 
   d="scan'208";a="243634531"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,243,1643702400"; 
   d="scan'208";a="506412958"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eljQ3yfUAeR+6Wd2/WnDJqkD0m+67Ix8rIE9FmqwTNa2mOZWKvXStf/2lh+Bc9O30cqT3kIg6+60qqeOPBQTozg7UroDlen37DmIc1T0xZBpuLZwRW4MPqH+PxEVMPzPLo6iDnVGpGMAru2vp7xFlLmOiZmmo8q+4/KgNUdImtPX64qKfzoQexcMqaPAL89HC052O/c7NzoSJL8wdQT74im+KQ07oU6sLQuOLAGVOOSURqseKXjvFA2ZgxckPWwrMjkNH8wzp76axKECmsCU2+Qaf8yqLdpdwG76t+RQ3RU1rF/Ve7bEysEMTbYfU7nHnJSgTil9bhYW1UWv1jIQhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6+VtECB6xpr3PRbgy+fyvwfhQ7Zi8rfhiTacVSs9lCs=;
 b=hq2MXtCzMMjLcSIThCsjmZryyEQzkBdo5Du+LiVhESVfA4Imd8Z2PhU+0QlMcUYmXRhL4H9a7TF+F6FmKvqCDBvF7KRr2lTxj8PdpqZHdWbLwMIGfHs3Y4vIHx+OSs1SRKEP6JCuk48uI8CN04JSx7nS4Vpx6XuAsRN7qm+AwIF7ire8hfP35XbBr1SwD72QkP6/fgKmRwNUt6/smR4NfRxBigWig9CEFjwiOo7priyYn9wsUAya0+VLG1l92+EqbD6DNQ3SxpbtP3ydbInCTh8mRTL4yzoRoRQQsTFAG9AKSk65V7jLHNNAPwZFyya1aqW6XB5rPBNx+UJtll9wKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Lengyel, Tamas" <tamas.lengyel@intel.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "Nakajima, Jun" <jun.nakajima@intel.com>, "Beulich, Jan"
	<JBeulich@suse.com>, "Cooper, Andrew" <andrew.cooper3@citrix.com>,
	=?iso-8859-1?Q?Pau_Monn=E9=2C_Roger?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>, George Dunlap
	<george.dunlap@citrix.com>
Subject: RE: [PATCH v5] x86/vmx: add hvm functions to get/set non-register
 state
Thread-Topic: [PATCH v5] x86/vmx: add hvm functions to get/set non-register
 state
Thread-Index: AQHYQE0JDO4TZ1lTNEeFxdnKer9Q96zlc1KQ
Date: Fri, 8 Apr 2022 03:49:33 +0000
Message-ID: <BN9PR11MB52762BD5E8F62281A5C326F88CE99@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
In-Reply-To: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-version: 11.6.401.20
dlp-product: dlpe-windows
dlp-reaction: no-action
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dee95e1b-4930-4bf8-c3ab-08da1912cb4f
x-ms-traffictypediagnostic: MN2PR11MB4192:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <MN2PR11MB4192844D5BB4A083BD8558E78CE99@MN2PR11MB4192.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: hox3YpF5eszroIqEDBGUrWpwXjWzfgTrT/vd/HnUOSFqmOh5u572EZ68EPxno7WLr7MPAxUYiK/iMPnq6jd2nJrSB7jHBH+UKjVDtMxJUy84HMe0+O5T78MyhA7rgkl0c9laqi623HyG0Aqj5ziwz7Ri7UJTI89Hf/Fa033CeAcUJ/2Zvpkl0M0js4wWKEnqTEOp9aOGpzOAqapME6Bgq64tSFzJD5aBcUiQRCKDWCfk8QmYzeCNj27LCTef5a+ghcg6tWSwskmrdU4Ag3B26hWwCa9kmbpROGqKHnx8mZ3VtFiK8gzUaR6rRsBHz7kn/RH16IDRnxsBqldJdNJNsZjcXwZyRls6tdV93/pZ4kR6vyvY2cZ8uh+KaDzNfh6oTlpnhaA8o3hqG+HZNd3ltIIX/TbCRCzcREFlQ5ZrHnQ341KM+yiqqVGj8aBYsJM+s5wRjwxds6MFFmLoUu//WpsDNWyJ5gyP2IyPWj63Tr2hN9QXZeeBIOVNnWPeWFhkh0Pfk91O1jjdanhY8ZZiAJZLhYTbX4oeBvFzaBnmhSiRRnkMVascsdoQdMp+GdFLmkyENYhn2lytQcjX51CNvNTb4Smm8EElSxHglGYBX8QSnNIt7Vf/agw4/XqFEl2KaM4vuTk+b3BBrygnFQwLBULgeEH/38J4Fl4bH5vP6WbqIl0Dddbz3Ds3v+MUaoah8pn5rHrjNVO4DuUe7Oc4DA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38070700005)(52536014)(110136005)(54906003)(8936002)(64756008)(66446008)(66476007)(66556008)(8676002)(4326008)(83380400001)(71200400001)(86362001)(316002)(508600001)(82960400001)(122000001)(5660300002)(33656002)(76116006)(38100700002)(26005)(2906002)(66946007)(186003)(55016003)(9686003)(7696005)(6506007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?wWwGrmSI5DTjxLjAWWVpWV7rkxZ4y0FBTjb4CCqoQd9kk0uaQyLHGbHCGO?=
 =?iso-8859-1?Q?IG/5NosqGK0XZFbOVA3OT5uOT2W8UpTZL19WQBwm5RXQtexv7QaZ6iS19k?=
 =?iso-8859-1?Q?jTr8kKfzI3aNU+FR+u3HSfVOdAacSDsnVoQ4l7UYOZTYx8wLH5sFCzDCyL?=
 =?iso-8859-1?Q?JpiiF+dRSAOMoq6j1XJkdN12g7VuFpQn9vJoxGymV/xIJznt8d02GdjtGZ?=
 =?iso-8859-1?Q?mg38V7yTKg790yin93kCGb8usHPQJqdXM7tlG1AbL/MafyogMxiYRzS2GA?=
 =?iso-8859-1?Q?U2LTbeaEaEzfD9JI5oNfN+mHTDR6w7eDhVjfXazeBU++cWz76yvKTVCyys?=
 =?iso-8859-1?Q?iZ/ZUC0oCXHGAdWdvJj9SC+sgnGGvLwCI1AAuSa9sVCnNExWQrSF4xE5yi?=
 =?iso-8859-1?Q?ReyLkcioOwjpy2bex+x4bZW/32ApdLXDYSb517TRYckrDZV6Wpsc4/Ydn3?=
 =?iso-8859-1?Q?2Qlq8nQBfTchS2xWlqRPqL4lrtebNO+BN9/Wkl+wNe0evq7S+V6iuL7URg?=
 =?iso-8859-1?Q?eKfojB6Z7DHKFU2ymHw4TjVojvBxH1HzXXU/C8qi/PS7/3R2FCd15OFnpf?=
 =?iso-8859-1?Q?zd1WEyRk7lsr7vj+lCsb7/xYiK9SPuLnmcdVTKtXMKsGnWBEkpSzUC6N9O?=
 =?iso-8859-1?Q?oyo4aQP3kpWTHUpn7mCpjnEyYo1fqp9sKqMdPa1annxQqcusQLr4p4bx1w?=
 =?iso-8859-1?Q?Qqu7KpzbtQLUWqLwq/A0k9dY6W+wBK94bfK+BbLvBpXvHhEPWjZouWhsCC?=
 =?iso-8859-1?Q?6DtvIvTqQbsyev2dfXJWTozRRGeRCcEP99F05prplPMQEZCEsc1MPJp7TX?=
 =?iso-8859-1?Q?PsEqza5bWdY8EfNRNkV99fFfERmC70bAkqLhsq4i6L1YbBLt7auJi5BBXv?=
 =?iso-8859-1?Q?zC/TYJxzepWOYRxfoO8C8u2AtPTqhD1WbTVJQpKJF3ge/yvCZSAdDgVVnT?=
 =?iso-8859-1?Q?+77cPXWhxGGIcSWrLHYLW9N5P+YnGKeJhu19jZNk4k6qsa+YAocgEcCVQK?=
 =?iso-8859-1?Q?Woz5vXMjIig/BwFS2CLwcKB0aTgEw5Fc7dNElLww/SmTL7z4mt3hkPDR0r?=
 =?iso-8859-1?Q?xLB8mSFHK8/mthnCLorqjtx0qcPBi2ykvWfFCK7+47CE+OBgbRv1vLwh49?=
 =?iso-8859-1?Q?+K2UgYA1IOVRfoTfjmcVNotuyjqK24wuzuVEdrD46jQtLHR08lakcSpew9?=
 =?iso-8859-1?Q?Ak5vDrMJDlpWJNQUejQ9GiRf4oMK0nduxujutkw3jJFCO1nV8mWN22GJnB?=
 =?iso-8859-1?Q?bAROI2lT2wZ+UiUskGqi0DAIjZs0FOWfRwLdpUPbGFeUNsTtYqGA1tg09h?=
 =?iso-8859-1?Q?5k2zxCi9E0nSwBzCuGdp3wIEIOhsjZA/Tu4SEhPjNm8gu/Dqv0zSEzX9pi?=
 =?iso-8859-1?Q?tzIQ17xic+5rvdOE4OiYxwuYQftDcqvuZ6Bv0IvfGfLC9Y8ADUSbvVAzLf?=
 =?iso-8859-1?Q?7Nr1OZ+KbSbO0FY2RdZYlm1m/AXXOiKIEVI5Y5IUFazaRSWn4LBWtta7e8?=
 =?iso-8859-1?Q?1swmEDEUG7FpC1zy2tG4GmLkauNU1l0M1LEHwWmnSZV1xkJq8AOWnYsLaa?=
 =?iso-8859-1?Q?H5pkDXyWgTYLb74QtE34AmZKLN+i/teXsnoNO2iUpJQAXUycWUT/HqtY8k?=
 =?iso-8859-1?Q?91IamJLwM2F4SxHw5B0stfsKzi9gkbXyoY/TaFChmz6NIVXU+SHjk12gC2?=
 =?iso-8859-1?Q?D57YlkLTbfaye3celvbUDl6SlRHTgL/N2FSEhHVN9gWXrAu9r7olD+RusJ?=
 =?iso-8859-1?Q?9Roiey84orh10ky55zlVay6J0i4EMnB9cHSaf3z7fQFesGCrvmSXIPD+4G?=
 =?iso-8859-1?Q?F4Dno62r8g=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dee95e1b-4930-4bf8-c3ab-08da1912cb4f
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 03:49:33.5892
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GZ6Rog95mpPdYSSPjgDUjeRJzguP/tf45JLf3enBHWwLbOPBmEOq21LScv0r/R1ZSQlJIZ5MC0BivbHYEOMDFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4192
X-OriginatorOrg: intel.com

> From: Lengyel, Tamas <tamas.lengyel@intel.com>
> Sent: Friday, March 25, 2022 9:33 PM
>=20
> During VM forking and resetting a failed vmentry has been observed due
> to the guest non-register state going out-of-sync with the guest register
> state. For example, a VM fork reset right after a STI instruction can tri=
gger
> the failed entry. This is due to the guest non-register state not being s=
aved
> from the parent VM, thus the reset operation only copies the register sta=
te.
>=20
> Fix this by adding a new pair of hvm functions to get/set the guest
> non-register state so that the overall vCPU state remains in sync.
>=20
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> ---
> v5: Switch to internal-only hvm funcs instead of adding to hvm_hw_cpu
> ---
>  xen/arch/x86/hvm/vmx/vmx.c         | 32 ++++++++++++++++++++++++
>  xen/arch/x86/include/asm/hvm/hvm.h | 40
> ++++++++++++++++++++++++++++++
>  xen/arch/x86/mm/mem_sharing.c      | 11 +++++++-
>  3 files changed, 82 insertions(+), 1 deletion(-)
>=20
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index c075370f64..2685da16c8 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -1334,6 +1334,36 @@ static void cf_check vmx_set_interrupt_shadow(
>      __vmwrite(GUEST_INTERRUPTIBILITY_INFO, intr_shadow);
>  }
>=20
> +static void cf_check vmx_get_nonreg_state(struct vcpu *v,
> +    struct hvm_vcpu_nonreg_state *nrs)
> +{
> +    vmx_vmcs_enter(v);
> +
> +    __vmread(GUEST_ACTIVITY_STATE, &nrs->vmx.activity_state);
> +    __vmread(GUEST_INTERRUPTIBILITY_INFO, &nrs-
> >vmx.interruptibility_info);
> +    __vmread(GUEST_PENDING_DBG_EXCEPTIONS, &nrs->vmx.pending_dbg);
> +
> +    if ( cpu_has_vmx_virtual_intr_delivery )
> +        __vmread(GUEST_INTR_STATUS, &nrs->vmx.interrupt_status);

There lacks of explanation somewhere how those states are selected.
Your discussion with Andrew leaves me the impression that Andrew sees
more issues in general save/restore path while you only want to deal with
the requirements for your own usage. But according to v1 your usage only
cares about the interruptiblity info. This implies that v5 is kind of in a =
state
between your original intention and what Andrew actually wants...

Thanks
Kevin


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 04:03:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 04:03:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301107.513823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncfpi-0002hb-CY; Fri, 08 Apr 2022 04:02:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301107.513823; Fri, 08 Apr 2022 04:02:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncfpi-0002hU-9O; Fri, 08 Apr 2022 04:02:50 +0000
Received: by outflank-mailman (input) for mailman id 301107;
 Fri, 08 Apr 2022 04:02:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XiXL=US=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1ncfpg-0002hO-VU
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 04:02:49 +0000
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bed02cb5-b6f0-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 06:02:47 +0200 (CEST)
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 07 Apr 2022 21:02:44 -0700
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
 by fmsmga007.fm.intel.com with ESMTP; 07 Apr 2022 21:02:44 -0700
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
 ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Thu, 7 Apr 2022 21:02:44 -0700
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
 ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Thu, 7 Apr 2022 21:02:44 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Thu, 7 Apr 2022 21:02:43 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176)
 by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Thu, 7 Apr 2022 21:02:43 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BN6PR11MB3970.namprd11.prod.outlook.com (2603:10b6:405:7a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 04:02:41 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%9]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022
 04:02:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bed02cb5-b6f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649390567; x=1680926567;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=phGxcuf1slm3xC0SW6r11Hueh97a2kYsmSxyYMVtcsw=;
  b=Eq3c5u3jBMdum/AyevOnj7euRnKVjyE9p5BiYIiAPvV/kkqosYGybi3B
   zng06mGCYtOkucjhilQ+m9XE3LifRiw5joA7UMIDO6lA+g3Qs+ESJVuxL
   7GkZyMt1M4mZ26nM/Z7jQ8j73AH0CLyWOAyinGRTOxPOiat+rgcJZT50J
   HJUr0BbYL1C+cNySk4n+qbmhf9xivYBw6oUSsdYtmIhhLjA2O6RfxFsvs
   cLeD48XEbMl+z2r2JYjPt/JRmpwsPEWwKj9+E76m7cMrKss7d0S2VPM0w
   1IqnnSf9FC+QCZ43wdTrSvNNk0dFKrX/oJckjRVbbNhPDzCLdzZEeGK5b
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="260337351"
X-IronPort-AV: E=Sophos;i="5.90,243,1643702400"; 
   d="scan'208";a="260337351"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,243,1643702400"; 
   d="scan'208";a="557628804"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ljicBIL4VZZDGWdEaeFOEPyfJwWRbVJUyl8hACmcBASM+i8OwXureU0x12pblQuoa6Nr8HZIPv7PCX9bQTVK/qWcQ2gpaACwE/DwtBnBKokB/4tVsUYSVSovb3pA92tw1Wsa6CUydMLhpAnrOUCnoXTdT4a63fjTgbqrfz8l7qz4emrN9FFgJQVm2cL8rQ+Ow86RMkmla6Z3omtpx2FwqyRBiR0kcLGk2+WvQZ3WXvKu3CqXHMdIFELWGtiUAwHL4EzoSy/8mf1oHjbfmAW+D2BED3MSWvddHYNF/jASjsLKcR+OoTte8mUPT70zz7s+VGS8Va7u/62plC+THjQDiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=phGxcuf1slm3xC0SW6r11Hueh97a2kYsmSxyYMVtcsw=;
 b=beX/Nx1+BUs6gm+3jQ76pZYRiO+ldtPDklhp5uJpa8zT2DqUvE1+eLi6S+UeyStemvDz9nhyvDvMa5qvh8/W4SHOXaylPp5Jk26TrFTUCSxC9WCLnJRRK5OgR2Py6OykNw+7zC+j8U0WxhwQxHrhmx06uOrou87AolqSnTXM4vUEPVIiawa4S8O85fkvfDb+nR2g5cgfLaMkbW/bAYRUxs2Bx+6BkbCl69STvGOaQX63DbQq6+6MK2xks/jfVlGTbnqvOMDX4WM+k7QZhZEkzEOTMTvuCE9mFbYh3g9Kcs/wg7gUMILgX2orEwJQSov78H9UloKtPHjNN6wdsqoCog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?=
	<roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: RE: [PATCH v2 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Thread-Topic: [PATCH v2 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Thread-Index: AQHYSkZPFo7HWMZ/FU2EAP8xR7sG9KzkEVSAgAACUACAAVKe4A==
Date: Fri, 8 Apr 2022 04:02:41 +0000
Message-ID: <BN9PR11MB52762D79BCBE87DE0E21914C8CE99@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <6739cf19-a74a-208d-82e8-28dfde7710f5@suse.com>
 <Yk6VvXJHWxJZTgeF@Air-de-Roger>
 <15a53720-4dd1-3139-5d78-5b8a5704a953@suse.com>
In-Reply-To: <15a53720-4dd1-3139-5d78-5b8a5704a953@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 86cff8b7-4ec2-4dba-8887-08da1914a0e3
x-ms-traffictypediagnostic: BN6PR11MB3970:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BN6PR11MB3970324B32D540AAC4A87E808CE99@BN6PR11MB3970.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: EW0HMcgza0IwdS8yI7+n5R9oYu1oHtI+vXYqzSyL0+htWf4Zzqf+RcNfgDCruh8OSpeZeskJHIlNKhrcNwAifsVzcPUdtAFv28qclFmcwh646fiJjG6cfqvNU6aWiMWRBe84tR07nX/yDILrKr1IVlzS4EgmPK7xGygJpgZD45GifyjD4QFlXFCFblox+ejDpNWvVFwheXeEE2F2/EWS0y/L/bihdBYQb5mjf6bFFIGbDjkK9n7j6hy7JbYm/vq5Ml19gyMfKQvY6MxWi/1u/V3MSscV54TvKDVjrXZy3y9jTOMfo9okcvyWiEoy1TvRfQrAZmbTl0wabxTiT5HAZYo3tzSWUUD/jQ7s3oAXHFXVuRZgeVMr47yrOPsmRBfZFl8yMl8kN3TQmbCbLvno/HZJFrmEpHRddQiqDTZrlnmJaaY40aeVob77Qpo+WZNsOrvjNmnaxBFJQ1Av5wN6pGYUj2BHRjzyaouMpcPnDh9sKPn0l5E413Bz4DFoMsqpwXeyV1m1CaJjQnOurQSi6U2ibL5Ul8xSZrtI2WB4VbNfjD0Sg8rlqcniqFUjqq9s7QWDbYR57k/ldqp8jMLWKdBuWQrlNRcXEOsBvIzFPgcY2dyFiWgyPvCC1khMT5dxvHTEAHKDovZQOw1mkt34Xn73IGBOsmFTyU+9XEynSHpz1Ha2rhKgWygepjGAQrO3P95JIfecUa80/XqsKv+e0A==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(71200400001)(66946007)(8676002)(4326008)(83380400001)(76116006)(86362001)(66446008)(8936002)(64756008)(122000001)(66476007)(66556008)(33656002)(82960400001)(110136005)(54906003)(508600001)(38070700005)(26005)(52536014)(5660300002)(6506007)(7696005)(2906002)(186003)(55016003)(38100700002)(9686003)(316002)(53546011);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L1hab0RLMTQ4ODh5ekdEQTJMdmJGZXFYZ2h2QmprSTFNUFVyT2ZzMlFBUG9q?=
 =?utf-8?B?Nyt3c2NxdkxDU1ZhZmZGdmY4bkxrVkxOMDF5Rmtkektpb2d3RldEQTBjN0Qv?=
 =?utf-8?B?NU10UlI3N3pQTUUvZG83QWpudnNSWlZ4MG54cEpZZG5pYVFuYzVKNlF5bHVQ?=
 =?utf-8?B?UkVxekg4Q2FGcVVya2duME5OS01qK0xkdVhDeVVZa3FCd2VlNkhyakZUTElL?=
 =?utf-8?B?MjhiblV1UWNoTURPN3F5N0x3Q1MrMkpHN2s3cFRGczNvSnFzWjlyYWNmWFV6?=
 =?utf-8?B?Q2VmUTZMVXMrQVlubnJRRmt6N2NyazRIRkRHTTdSYno5dHAzRHlSUVBnbU1K?=
 =?utf-8?B?alJ5cXUzbkdzaTZnUEVLWFpyZVJtcWZLVndNbFdUODJma2YybW5yRnRFanlx?=
 =?utf-8?B?M29uL05hTFJxdEN0UGptNWg5S253QlNKdTFLNFJTWitlYUVkUHRxOHJyVzVp?=
 =?utf-8?B?K3QvRG5sZTVoTkpqRzVwZFQ5Wm9oNERBU3NvVDNCQ3RnNEVwaWZ2VnhxUFZ1?=
 =?utf-8?B?Tm1LNzhvZWlXd0lpenBZRFdNNlJQaU5CSVN3T08yMXZWa0NRN29OdVhLaCsr?=
 =?utf-8?B?RkIzK1hORGloR3FMU083RXY0akdqc1pIR1gzK1pKTmlVZk1JY1lHN1RoMVhE?=
 =?utf-8?B?SGRwb0laclczMzFqbzVTSzdwR0NOcDJlQ28vbVU1QytLZk0wTTVWUFlPWTUx?=
 =?utf-8?B?Rjc3cUVFOW5tcGpYQVlXVlJ1ZVZDMzVIYUlFOUMxMlM0ZkIwUEZCSkVPVEhG?=
 =?utf-8?B?WjFYUjQvdlRGQ3pNalIwcjBlOWp6blg3SXJSK1BZNmVxU29wcklja0k3WndV?=
 =?utf-8?B?akpIVlR3ODFueS9Kb2ZhUVhYcTN0RzkxSExKc1VIU0t3ZTY1YzZxa0tSd0RS?=
 =?utf-8?B?Szk4c1JQWWtiNkJ1TVZvRzl4K2VGd3dsbzROUkFMc1BmbnBGU0lTNTVYSGNK?=
 =?utf-8?B?WE1qL1NJc2ZnenA1cGp2YnFwUnUzRjMvSGlSOWZaMUR4NmhJQjczdGVxZklL?=
 =?utf-8?B?d2NsTjJpdDZqMy90RTJUQ0lnSU9TMGpjQkMxQ2dBTGdLSldMT2VRZnFOQk8v?=
 =?utf-8?B?aFlhVG1TaGZzWGt4aXB4TzN6dmJaWEtCN3hVRENzV3YzYjBobHBmTkF6Z0ha?=
 =?utf-8?B?SW9KaGxKZlh5aktXQnJIRHpSM0h2cE13R1ZadTJGaHE2VDY5NG0xWWdqYzBM?=
 =?utf-8?B?OXlCT0I5VmJ3SElpYjFLSlRCQ0tVRllCYk0vSDRpOTdtVmFMN2VkbmFBOXpS?=
 =?utf-8?B?YWlyRXMxK0g1eS9Qc1IxMUs2Vmo5Z2xKM0FVc0FJVW41cXFQVDlzZlBCdlow?=
 =?utf-8?B?UGd2QjU0VXF5cjlJN2RHbkM0dW5QSjhvTThTZU5EMlBCaEwvN1ZyNW51UlBL?=
 =?utf-8?B?cndtcnBxajBEYmR2TTFWcm5CbzVHc2lOU0U4TUJ3cFZDUVdueUwvR3p1RDRN?=
 =?utf-8?B?YXZXNGhKSk56V1dqYSs5b3BvT1BHZ0dPQjBKOFVZYmprZExIek1SWk9lR09R?=
 =?utf-8?B?MTgwL1l2cUdtWXFsYWhoQUxCT0xtVmJXSnVMcSt6RkhUOHpTLzVleUNOWjBJ?=
 =?utf-8?B?ZVVSRncwYzFZWFZYYTZoZWVBNlg2cnhKRmJIS0RCeWgreGNmNHhYOEJxNTRJ?=
 =?utf-8?B?K2pxdXpPbmMrMy9UMWJubE1FQkV0LzNLWVU1T2l1Mmtid1pjRDdMbEpMc0ww?=
 =?utf-8?B?UTUrSmoyaktUNXlLTHZnWnZ0MFJHV2pldkZlSHpORVFOTkNVdWtuYzFjL2hD?=
 =?utf-8?B?WGdhVUIvb0NsY2twN2NBYnQwRUM0V2JpQUZGS3E2b3FyYUhucC9PM204Q1Fa?=
 =?utf-8?B?S25zNEFTSWo4clJ3VSsybHJkY2hRUk14amczd3o5dWVuZXVOc1gweHdwRWp1?=
 =?utf-8?B?UGpoZ1ZpdGV6ZnV5a0tObWJobnFBbDN6VnVscXVUblB4Ui9iK2VUL3FnbVFV?=
 =?utf-8?B?alZhMU82SXhoME9yR2Q0aktHTDR3OGptVWM2V2UxSm8ySk83Y1VycHdUL1hn?=
 =?utf-8?B?QlpDdDl1dnZiUHQwWU90ZU5zU242KzhmQmt0Q254bU5LTGR5eXZaRmNtRHQw?=
 =?utf-8?B?RG5ybHhPeitiWmh1V21BemVQZUYvbjVoV1JNWEgyZ2E2SHJEUDdTN1N1WGtW?=
 =?utf-8?B?dTkzZnljWXZ6Q2g2c2ZPWmd2NUdLbVNXRGwrSnM1dGtJWnJEbjNDN1FESmtQ?=
 =?utf-8?B?dUpQYW5uYXZkakZ5VWhoeVlZMmZtZzgxUkFVK0dTbGt2dEtmQmlzdWxJTENR?=
 =?utf-8?B?SURhOFU2cTYxWHNhMnRtTDFMTVYxTndkNUh4NWFjVTNObkQ3dlJwN3Q1M21F?=
 =?utf-8?B?ejZiaFNZUy8vQ2JQeUtldmVycnV3V0ZycE1aa2NxUXdFN2kwNE4wUT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86cff8b7-4ec2-4dba-8887-08da1914a0e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 04:02:41.4559
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4yAFGxNsBEyDM8niAC48GxL0A+V6U72hYIgpLXRdso0okKjhBhvAdaBLvInBPOp2caTmW1MbWUsb5SKLZbLoXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3970
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5
LCBBcHJpbCA3LCAyMDIyIDM6NTAgUE0NCj4gDQo+IE9uIDA3LjA0LjIwMjIgMDk6NDEsIFJvZ2Vy
IFBhdSBNb25uw6kgd3JvdGU6DQo+ID4gT24gVGh1LCBBcHIgMDcsIDIwMjIgYXQgMDg6MTE6MDZB
TSArMDIwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4+IEZpcnN0IHRoZXJlJ3MgYSBwcmludGso
KSB3aGljaCBhY3R1YWxseSB3cm9uZ2x5IHVzZXMgcGRldiBpbiB0aGUgZmlyc3QNCj4gPj4gcGxh
Y2U6IFdlIHdhbnQgdG8gbG9nIHRoZSBjb29yZGluYXRlcyBvZiB0aGUgKHBlcmhhcHMgZmFrZSkg
ZGV2aWNlDQo+ID4+IGFjdGVkIHVwb24sIHdoaWNoIG1heSBub3QgYmUgcGRldi4NCj4gPj4NCj4g
Pj4gVGhlbiBpdCB3YXMgcXVpdGUgcG9pbnRsZXNzIGZvciBlYjE5MzI2YTMyOGQgKCJWVC1kOiBw
cmVwYXJlIGZvciBwZXItDQo+ID4+IGRldmljZSBxdWFyYW50aW5lIHBhZ2UgdGFibGVzIChwYXJ0
IEkpIikgdG8gYWRkIGEgZG9taWRfdCBwYXJhbWV0ZXIgdG8NCj4gPj4gZG9tYWluX2NvbnRleHRf
dW5tYXBfb25lKCk6IEl0J3Mgb25seSB1c2VkIHRvIHBhc3MgYmFjayBoZXJlIHZpYQ0KPiA+PiBt
ZV93aWZpX3F1aXJrKCkgLT4gbWFwX21lX3BoYW50b21fZnVuY3Rpb24oKS4gRHJvcCB0aGUgcGFy
YW1ldGVyDQo+IGFnYWluLg0KPiA+Pg0KPiA+PiBGaW5hbGx5IHRoZXJlJ3MgdGhlIGludm9jYXRp
b24gb2YgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoKSwgd2hpY2gNCj4gPj4gbmVlZHMgdG8g
YmUgcGFzc2VkIHRoZSBjb3JyZWN0IGRvbWFpbiBJRC4gQXZvaWQgdGFraW5nIHRoYXQgcGF0aCB3
aGVuDQo+ID4+IHBkZXYgaXMgTlVMTCBhbmQgdGhlIHF1YXJhbnRpbmUgc3RhdGUgaXMgd2hhdCB3
b3VsZCBuZWVkIHJlc3RvcmluZyB0by4NCj4gPj4gVGhpcyBtZWFucyB3ZSBjYW4ndCBzZWN1cml0
eS1zdXBwb3J0IFBDSSBkZXZpY2VzIHdpdGggUk1SUnMgKGlmIHN1Y2gNCj4gPj4gZXhpc3QgaW4g
cHJhY3RpY2UpIGFueSBsb25nZXIuDQo+ID4NCj4gPiBUaGUgc2VudGVuY2U6DQo+ID4NCj4gPiAi
VGhpcyBtZWFucyB3ZSBjYW4ndCBzZWN1cml0eS1zdXBwb3J0IFBDSSBkZXZpY2VzIHdpdGggUk1S
UnMiDQo+ID4NCj4gPiBTZWVtcyB0b28gYnJvYWQgYW5kIGNvdWxkIGxlYWQgdG8gY29uZnVzaW9u
LiBTbyBJIHdvdWxkIG1heWJlIHVzZToNCj4gPiAibGVnYWN5IFBDSSBkZXZpY2VzIiBvciAibm9u
IFBDSSBFeHByZXNzIGRldmljZXMiLg0KPiANCj4gUmlnaHQuIEkgZGlkIGFjdHVhbGx5IGZvcmdl
dCB0byBlaXRoZXIgZHJvcCBvciBlZGl0IHRoYXQgc2VudGVuY2UuIEkndmUNCj4gbm93IGV4dGVu
ZGVkIHRoaXMgdG8NCj4gDQo+ICJUaGlzIG1lYW5zIHdlIGNhbid0IHNlY3VyaXR5LXN1cHBvcnQg
bm9uLVBDSS1FeHByZXNzIGRldmljZXMgd2l0aCBSTVJScw0KPiAgKGlmIHN1Y2ggZXhpc3QgaW4g
cHJhY3RpY2UpIGFueSBsb25nZXI7IG5vdGUgdGhhdCBhcyBvZiB0cmhlIDFzdCBvZiB0aGUNCj4g
IHR3byBjb21taXRzIHJlZmVyZW5jZWQgYmVsb3cgYXNzaWduaW5nIHRoZW0gdG8gRG9tVS1zIGlz
IHVuc3VwcG9ydGVkDQo+ICBhbnl3YXkuIg0KPiANCg0KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4g
PGtldmluLnRpYW5AaW50ZWwuY29tPg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 04:07:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 04:07:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301111.513835 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncfuC-0003Kn-08; Fri, 08 Apr 2022 04:07:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301111.513835; Fri, 08 Apr 2022 04:07:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncfuB-0003Kg-SZ; Fri, 08 Apr 2022 04:07:27 +0000
Received: by outflank-mailman (input) for mailman id 301111;
 Fri, 08 Apr 2022 04:07:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XiXL=US=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1ncfuA-0003KV-7S
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 04:07:26 +0000
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62dad44e-b6f1-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 06:07:23 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 07 Apr 2022 21:06:14 -0700
Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18])
 by fmsmga001.fm.intel.com with ESMTP; 07 Apr 2022 21:06:14 -0700
Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by
 ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Thu, 7 Apr 2022 21:06:13 -0700
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
 orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Thu, 7 Apr 2022 21:06:13 -0700
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173)
 by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Thu, 7 Apr 2022 21:06:13 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB2572.namprd11.prod.outlook.com (2603:10b6:5:c8::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Fri, 8 Apr
 2022 04:06:05 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%9]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022
 04:06:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62dad44e-b6f1-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649390843; x=1680926843;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=Qe7eB1djGRTbiZBQklyx6HOMWFXUF8ac3wdWaK7mOYQ=;
  b=UbuKFdt4WAEu4MYIlBnoSEjOM67LhapnLmGwKbeNaajgWm/1vRCc1Np7
   AU8+cnYOWFGJqGfbKQ/GGv1kfDkCFsRJJUOYXVJZxQy8QkeRn/2RL+Cr5
   U4s8advA3VKTN/huFYAZ6AzhSrEliJmTbfOTqYTA6fT4uddpxwQo+IJMd
   ykar2iepbFkMPE3gEkyYsL/+ADTPEZ8CuWqYCRYzpOmZ9NFPHAFXRojf+
   fMMvD64+TTidHZEgQqFftyin8VdlPdfRThm+LMg6mz7WSMnFA9Bo18+jO
   RwyUCdSi5DhWBw8RIojQAbsiUl6dXhUeISdwiunpYKyPEwhW0L+Xx5lyG
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="243636948"
X-IronPort-AV: E=Sophos;i="5.90,243,1643702400"; 
   d="scan'208";a="243636948"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,243,1643702400"; 
   d="scan'208";a="698045946"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hiJfb7eUXE+jauO0ee182LfEzLsK1XSECnituG/+z6HLiHIqJRQmtlQbqjzFPCVTXZAUfRlxNAFqqSx4g+2gaTWIXerkgNwtKrQktD1b+w+/Ig+8W/IIs0OeTKDxAW/w3VokL6eEUXTB8b078f/2r1HVT0/hRsmITHeqQ58tq8XLFl5bCwz5wbxujdCDeWs4XuTQPFhAHv7aO/klY+G3MtpqRHJR/svdGou8pjSgT5zY+ji2oL89XG5l8BUKTIvdcrA5hapmX+k+5kU9ZcDzlQj2pPwNH0xovv/4xCXST62oiOYXXHozBL1Yhu2RbbVcT52KWMm8vpD7ci5gPa+I8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Qe7eB1djGRTbiZBQklyx6HOMWFXUF8ac3wdWaK7mOYQ=;
 b=PpoP046jMEY+k/r4vkZp40paB2kXZsfkTvoYBcHzTALAthVJDFNgGQAmpcHTLW5h5x1K19H00okOtZpJeMY7n1SZJzbYNgbRCNE6APe+D5J8vM1/VV75zbli/pbd0CBtfieetFhDdjKbyPD01V78uqEaUdBMugaD370nNN54ln3/zLIxdU6sIVU/kUT7TEb/bgxPOcJUi4WrQYFhz3oK748i8Fzkvq6La5rGbyDIE8aIeSpHdmbNRqhfT8RHFg4keDfRQc8mWKFz5n7gAfXlt1C+oZazzCKvDYhKyDv86JgCv37w/kBGFApJYdQlJiSCFkh4Li0RZ9rsXIE+Z/ENzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>, "Cooper,
 Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: RE: [PATCH v2 2/2] VT-d: avoid infinite recursion on
 domain_context_mapping_one() error path
Thread-Topic: [PATCH v2 2/2] VT-d: avoid infinite recursion on
 domain_context_mapping_one() error path
Thread-Index: AQHYSkZlky/MvMCmm0mF/2MIXKQq76zlZ0YQ
Date: Fri, 8 Apr 2022 04:06:05 +0000
Message-ID: <BN9PR11MB527603919C5C8C7906E8B6B98CE99@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <fcc51df9-0896-247b-d4ad-0de4db6c2a9c@suse.com>
In-Reply-To: <fcc51df9-0896-247b-d4ad-0de4db6c2a9c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 24234e8b-1d7d-4b37-d566-08da19151a67
x-ms-traffictypediagnostic: DM6PR11MB2572:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB257292F277720700C7414C458CE99@DM6PR11MB2572.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Ke4nwXZXxUuIb4qkwPe2nUSQ/wJj9NAAtCjcNZ/ica9uyAsxEOXJifj+IlB1IfM6dd4C6WxdKlFC3yBzd5UPtDN71ZLvG/8+Cieg4FiN4vggattlKC3zj3fwivfQgH7+u6BaqpP7kjj6BpaiualnvWOGxn72ZFkY18cFWCBBsYAuNdtuxMn2OGld7pPmwdpOCONwBNLc7/nArDNBwUDRl2f0XKBkLdb+5IDz7jhr+vGFT1N8wMWzF9lL4t27q2Es0kKS7DMoX+hTdKiQAdZCev2/v0KqyAVUCnxnW9h4r0wplkHmcs51FyJ9tqZ8lcNZn6XOcvf+0HE4lRneUd7IKAjmZrp7Di/ZQOoLi+86WbovlGq8vNzwYKsahDDzJRUsgBu9qf6fqVJfPLeQD6KZiPCu1u2amtouGWnftAkQ7Ih1ZlDjIhf+x2Xc6lx7beXHCQuxAcGO0S3GbBLkp8PzvybyDe3MM8umX9oW6cz8qXm6GYxKewqo6thkQyCpH6xi5Bc6/SpwMqSldavbTJ5YhlsYrq+01IfUi83vnqwtrnfoTzu7xo1ZGtVVMqrMuvUkqnsG7Dbhv1OJ11YcQDaj69bTaGxWE3g73YJsp0rkhOP2ca0hqEx4UvRdbmBRtlZp8kgdV0LoVY6R6psi5b0YTveXqPY4LnT00ZV6EvJAb5ew7PJLj8dusNDD/0gXlvu8gCNCrNW3ETyk7XzC7OgDwA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(33656002)(9686003)(86362001)(508600001)(83380400001)(7696005)(52536014)(2906002)(5660300002)(8936002)(186003)(26005)(66476007)(71200400001)(66446008)(66946007)(66556008)(38070700005)(38100700002)(122000001)(82960400001)(55016003)(64756008)(54906003)(4326008)(8676002)(110136005)(76116006)(316002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cVNNQVZxZVBrQ2hCUEh5R0Y3dGVMb2psQ21wbXU5ZlRDbUJoZzJ0THpxNHgz?=
 =?utf-8?B?QTlwcGNnUzcvL0Vzb1FkUmhuekhuYThoZXlLTThYSWZGTEVtRzFzQzdpZC9R?=
 =?utf-8?B?cnpvOEkxOEtyRWx1UXp6ZG5xb3Q5SGs5NUgyeTVMcmVmT1pWNy8yM3VnSlMy?=
 =?utf-8?B?UWNmbUxIUENaTzJvc25JOUMvcm5nL0FYYjFUejFFbjRGYWhzajE0aytCT3NT?=
 =?utf-8?B?QTBsc2hFemFtdzNQNU8wVzNXOGF3VFVYWElyanZ1SklGQy9tOTN0SkpuUDZy?=
 =?utf-8?B?SEFFckRTNUxFNDNyZE1oS0tSYkQvZFAwNk82c0t4QW1WU1hhT29LRnYwR1FR?=
 =?utf-8?B?RlFOSGJZL2N1cTZYc3l4cTlkTVlJOXNYaWFqMlFyRlBWYnpyTHdtTFJJV01R?=
 =?utf-8?B?YVhSdDI0bGhHcFVyN1pjcDZ6UmFERHIwNnVtWWQ1U2pKeFBGTW4xeW5HUVRr?=
 =?utf-8?B?WFIxN0lYd0p1a2R6Y0tMbktydEJCZEtjU0IyeG9VQlNMK09ha2hMQ1gvbGtu?=
 =?utf-8?B?U0NoODF4WGdkSnE0aHZtTFhoY1Q5K3dEQ3c3RHhITHYzSjkrL04wdEE1THlC?=
 =?utf-8?B?VC9oNzZibzM3dlhGRXNvaWgrSUxjNEE5ODRQWnU3M3dhcWtyYWxONW1pYXUz?=
 =?utf-8?B?bXpmZ05QYXROMjY5V2pVOGNXN2M5cFBicjliTGNmYzYwa3A3NmhjMzRVQ2F4?=
 =?utf-8?B?dU56YjlDVDJJdlRibXB1bDl2cjVEelJ3SGxtQ0IzRVlZa0FSdnVsZHF2TXN5?=
 =?utf-8?B?V2x1aGN4V0lMZFZwWkk5QUQ5a1BTRCtwYmJJaFhpQXBqbGpWOFF6UXZlNUw2?=
 =?utf-8?B?Zk83Si9SajVkb1hCOHFpRGRDWFlGUkg0YmdscitDT3dUS2drdFVEa0dQOFBT?=
 =?utf-8?B?a3lLY21xQW5BbC9HbVVKUzg4eG5Yb1M1a1JCYmQ5R0J6cENFemZQbDczVUN2?=
 =?utf-8?B?WThDT0hUT2hxT1pZTG1XWUNPY3Jaam16Y0ZKZlp6NHVvR0xIdDlnR1BIVlFx?=
 =?utf-8?B?a2s4Rm4yNU9OTGdycUdrMzBxNVg4N0FVVzdlcW9xWHBmZkZWbnRuNFM2eUh3?=
 =?utf-8?B?UjlJcXVncUFsSTFuZWVMbExaMGdqZEpFNm1xbWVvVlNrdW1sajlEeWYyTnI4?=
 =?utf-8?B?WndMd0ZKSHFSZWZEQnRDVElKSkllcHRjT3dacFdWQ0doNVNyQW12UDZ6U2s3?=
 =?utf-8?B?MHhBVmRyM0xhYkRFK0xUalVFeFpNUDFOSXpmaWFNNlZZM3g4WElQM3V4SCtw?=
 =?utf-8?B?V2puSkxQSkppZGZrdTM2VE5CK05BOXp1R084MUxHemxiSjlIM2cxZ2dtdzhx?=
 =?utf-8?B?MjV5Y0ZkR3FIZ0FWTkNVNU9TaWhjd0xmTW5FZURkWEc2YThpS1psMHd5a2h4?=
 =?utf-8?B?V3kzRlRkcHU3NGZoQmJ4aE1reFNrS2ZNUjVRSDI0V0pvNG1VNllpakF3cDJS?=
 =?utf-8?B?azJnUTdHSm5EYWVLRE4xM3QwSCszZmtvYUN6YmVCbTQ5MEZNazJmZWYyVUQz?=
 =?utf-8?B?Mk1NY0tTU3dPLzJpVnRkb0REeE9YeG5lVU5aLzNudi9aZXhMT0lRSUtMYTA3?=
 =?utf-8?B?U3NpL1B1YkN6ajRUUUM3Uk81aVhVSUxia0tRcGdtNXlnWVJvbHBLR2JkRmpI?=
 =?utf-8?B?anE5K2N2OFJCK0h5d2x4ayt2c0M3TGlBRVFyTVo0ZkQwNkNtZGZWdlF0cGNM?=
 =?utf-8?B?SVgvWUFYMURiRWV6SExaSHBaaFhSVCtDQTNmZ2RXVGQ4c1ZyTXdrWWxsbWNT?=
 =?utf-8?B?MnAwcnJrNExxZkZTNmtsa2pmUVczME45Z0doSnk0azNxMzBwTXpzR0UxWVlX?=
 =?utf-8?B?YWNHc1JqNEh3eUVHb2MwWThOVmZyOUdML1FJMTVRanpnY0JpQlVid2FBZkhv?=
 =?utf-8?B?L0lnZm45SHExVTZwTURLdTQ3S2pzTTZOU0hYRjl2eVpONUxNY1dEek1nWkZr?=
 =?utf-8?B?QkxUZjFYYUl0Qjh4SzNTUFJiVVRnaE81czZwS081NnZIK2d3YWR3UWdvVHEw?=
 =?utf-8?B?Wndtc3p1ZS9LWGpCaGw0bkFoMzdiZWlndmpadTVrZmdnUTdMN3g3bHhTTkw1?=
 =?utf-8?B?eHNNUVFHditZVkVuVkRaUWpCbUlzTDcrVk9UYnZXZ2liQTRjYlU0cFMxOVlk?=
 =?utf-8?B?aGNVRCtzeFBSajdMcXVHcW9NTmx5OVh3Z2tsdS9pbVA0bk96c1NOb2JTTXZy?=
 =?utf-8?B?NVNrVHR0dVdFOXIvQWlvK0U3REgxWWFjd3dOd2pqZFM2V2F5WlZuQnpGRUEx?=
 =?utf-8?B?ZitWR0ZtK1llQ3R1UjVJYk5MTkh4bDJsb0JtcWF1N0V3VWh2azQ5RWV5dmtx?=
 =?utf-8?B?UlI3ZFBpTGlIaFI0bzY3c250MUFiQ2JGd2NaeVcyMTJva1BNcnQ5UT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24234e8b-1d7d-4b37-d566-08da19151a67
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 04:06:05.3429
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2JTpeSfGInN709cVJC3VbfFqZG3GCTSmRlk56s7rRlq/5C/9B0CO9qJkt/CJtwAJHDDvIjAjy/ij+1bz3Bxzyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2572
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5
LCBBcHJpbCA3LCAyMDIyIDI6MTIgUE0NCj4gDQo+IERlc3BpdGUgdGhlIGNvbW1lbnQgdGhlcmUg
aW5maW5pdGUgcmVjdXJzaW9uIHdhcyBzdGlsbCBwb3NzaWJsZSwgYnkNCj4gZmxpcC1mbG9wcGlu
ZyBiZXR3ZWVuIHR3byBkb21haW5zLiBUaGlzIGlzIGJlY2F1c2UgcHJldl9kb20gaXMgZGVyaXZl
ZA0KPiBmcm9tIHRoZSBESUQgZm91bmQgaW4gdGhlIGNvbnRleHQgZW50cnksIHdoaWNoIHdhcyBh
bHJlYWR5IHVwZGF0ZWQgYnkNCj4gdGhlIHRpbWUgZXJyb3IgcmVjb3ZlcnkgaXMgaW52b2tlZC4g
U2ltcGx5IGludHJvZHVjZSB5ZXQgYW5vdGhlciBtb2RlDQo+IGZsYWcgdG8gcHJldmVudCByb2xs
aW5nIGJhY2sgYW4gaW4tcHJvZ3Jlc3Mgcm9sbC1iYWNrIG9mIGEgcHJpb3INCj4gbWFwcGluZyBh
dHRlbXB0Lg0KPiANCj4gQWxzbyBkcm9wIHRoZSBleGlzdGluZyByZWN1cnNpb24gcHJldmVudGlv
biBmb3IgaGF2aW5nIGJlZW4gZGVhZCBhbnl3YXk6DQo+IEVhcmxpZXIgaW4gdGhlIGZ1bmN0aW9u
IHdlIGFscmVhZHkgYmFpbCB3aGVuIHByZXZfZG9tID09IGRvbWFpbi4NCj4gDQo+IEZpeGVzOiA4
ZjQxZTQ4MWI0ODUgKCJWVC1kOiByZS1hc3NpZ24gZGV2aWNlcyBkaXJlY3RseSIpDQo+IFNpZ25l
ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmV2aWV3ZWQtYnk6
IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KDQo+IC0tLQ0KPiB2MjogRXh0ZW5k
IHNjb3BlIG9mIHRoZSBhcHByb2FjaCB0YWtlbi4gTGV2ZXJhZ2UgZm9yIHNvbWUgY2xlYW51cC4N
Cj4gDQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+ICsrKyBi
L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+IEBAIC0xNTk5LDcgKzE1OTks
NyBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoDQo+ICAgICAgaWYgKCAhc2VnICYm
ICFyYyApDQo+ICAgICAgICAgIHJjID0gbWVfd2lmaV9xdWlyayhkb21haW4sIGJ1cywgZGV2Zm4s
IGRvbWlkLCBwZ2RfbWFkZHIsIG1vZGUpOw0KPiANCj4gLSAgICBpZiAoIHJjICkNCj4gKyAgICBp
ZiAoIHJjICYmICEobW9kZSAmIE1BUF9FUlJPUl9SRUNPVkVSWSkgKQ0KPiAgICAgIHsNCj4gICAg
ICAgICAgaWYgKCAhcHJldl9kb20gfHwNCj4gICAgICAgICAgICAgICAvKg0KPiBAQCAtMTYwOSwx
MyArMTYwOSwxMiBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoDQo+ICAgICAgICAg
ICAgICAgICovDQo+ICAgICAgICAgICAgICAgKHByZXZfZG9tID09IGRvbV9pbyAmJiAhcGRldikg
KQ0KPiAgICAgICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKGRvbWFpbiwg
aW9tbXUsIGJ1cywgZGV2Zm4pOw0KPiAtICAgICAgICBlbHNlIGlmICggcHJldl9kb20gIT0gZG9t
YWluICkgLyogQXZvaWQgaW5maW5pdGUgcmVjdXJzaW9uLiAqLw0KPiArICAgICAgICBlbHNlDQo+
ICAgICAgICAgICAgICByZXQgPSBkb21haW5fY29udGV4dF9tYXBwaW5nX29uZShwcmV2X2RvbSwg
aW9tbXUsIGJ1cywgZGV2Zm4sDQo+IHBkZXYsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBERVZJQ0VfRE9NSUQocHJldl9kb20sIHBkZXYpLA0KPiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX1BHVEFCTEUo
cHJldl9kb20sIHBkZXYpLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgbW9kZSAmIE1BUF9XSVRIX1JNUlIpIDwgMDsNCj4gLSAgICAgICAgZWxzZQ0KPiAt
ICAgICAgICAgICAgcmV0ID0gMTsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIChtb2RlICYgTUFQX1dJVEhfUk1SUikgfA0KPiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTUFQX0VSUk9SX1JFQ09WRVJZKSA8IDA7DQo+
IA0KPiAgICAgICAgICBpZiAoICFyZXQgJiYgcGRldiAmJiBwZGV2LT5kZXZmbiA9PSBkZXZmbiAp
DQo+ICAgICAgICAgICAgICBjaGVja19jbGVhbnVwX2RvbWlkX21hcChkb21haW4sIHBkZXYsIGlv
bW11KTsNCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL3Z0ZC5oDQo+ICsrKyBi
L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC92dGQuaA0KPiBAQCAtMjksNyArMjksOCBAQA0K
PiAgI2RlZmluZSBNQVBfV0lUSF9STVJSICAgICAgICAgKDF1IDw8IDApDQo+ICAjZGVmaW5lIE1B
UF9PV05FUl9EWUlORyAgICAgICAoMXUgPDwgMSkNCj4gICNkZWZpbmUgTUFQX1NJTkdMRV9ERVZJ
Q0UgICAgICgxdSA8PCAyKQ0KPiAtI2RlZmluZSBVTk1BUF9NRV9QSEFOVE9NX0ZVTkMgKDF1IDw8
IDMpDQo+ICsjZGVmaW5lIE1BUF9FUlJPUl9SRUNPVkVSWSAgICAoMXUgPDwgMykNCj4gKyNkZWZp
bmUgVU5NQVBfTUVfUEhBTlRPTV9GVU5DICgxdSA8PCA0KQ0KPiANCj4gIC8qIEFsbG93IGZvciBi
b3RoIElPQVBJQyBhbmQgSU9TQVBJQy4gKi8NCj4gICNkZWZpbmUgSU9feEFQSUNfcm91dGVfZW50
cnkgSU9fQVBJQ19yb3V0ZV9lbnRyeQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 04:08:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 04:08:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301114.513846 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncfvQ-00046R-AI; Fri, 08 Apr 2022 04:08:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301114.513846; Fri, 08 Apr 2022 04:08:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncfvQ-00046K-7H; Fri, 08 Apr 2022 04:08:44 +0000
Received: by outflank-mailman (input) for mailman id 301114;
 Fri, 08 Apr 2022 04:08:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XiXL=US=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1ncfvO-000464-Dg
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 04:08:42 +0000
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 91ecb56f-b6f1-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 06:08:41 +0200 (CEST)
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 07 Apr 2022 21:08:19 -0700
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
 by orsmga006.jf.intel.com with ESMTP; 07 Apr 2022 21:08:19 -0700
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
 ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Thu, 7 Apr 2022 21:08:18 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Thu, 7 Apr 2022 21:08:18 -0700
Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.47) by
 edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Thu, 7 Apr 2022 21:08:18 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB2572.namprd11.prod.outlook.com (2603:10b6:5:c8::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Fri, 8 Apr
 2022 04:08:16 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%9]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022
 04:08:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91ecb56f-b6f1-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649390921; x=1680926921;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=x7QBY+2397q67d8T16EQA4MJaySGLnCri0MEKS8LzgY=;
  b=fqYm460piC2O4kObwq1VUfWgD1H9TEWpK+3759cykKPRdwo9018XTCg9
   tHsC652hS7s4RQXB66NwFFgv2eCsWZIPkiqZH+0fEFuy7swSj5c3aY9up
   Nt3IivZ1UyQfVtKomt7uNUNiHUCUyG2yiFCbfznGZKlmGZsNYtC7koc2t
   WOv2ipNKK+yL5TV7U3vxC4ShqjdRY5O+CKOc+Gn3f93g0IU3tRAA1Z0hr
   d2ELKeGtpVW3mCYY+OYwEbRP7qfNLWpEElnQ7XcSmlHnoPUn1vY/QIV+c
   dsLQvsvjm4FV9CLTfFBcwx/U9bm3zq0tEN2n2fDo60G7alx8KHwbLV7NT
   A==;
X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="261498263"
X-IronPort-AV: E=Sophos;i="5.90,243,1643702400"; 
   d="scan'208";a="261498263"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,243,1643702400"; 
   d="scan'208";a="525216571"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bg1HSdmmoy9DLbKQjTvNmgvS4vPsFmSG7h37z1w22LolCdPjnuRYSMrICvUfVpOnIzpX2IPfAF5gY0I/CSa7ONvYCCJ7ienyDfag+av10JXZyk00Dz5XOcpNGUN4BZi/VGJ9JkeuxrmxQO3FhNt0upJjtdKRtiX0cr2n7R+Y3a8EYcABf8a5gpveK6eSZAErOljgZT99GK0+99i122zpeD4CO++UV1VxIkIEQ8OZIyrLZyG94yKcZSW7zqv7+nEaq+OP5/RsYtxEuHfqYnJelVjhwPlcWhOuZCsnJciJ0NPtrOa4SGuKUeVgcFcKMicn72uybbFy9pHP1LWxzrYSSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x7QBY+2397q67d8T16EQA4MJaySGLnCri0MEKS8LzgY=;
 b=bNyCa281tljK7Ywxc5nfRFIlpPrIIlJt2IA49gZwsNYquMnH9TH+TqDmJ+AcRSPpMSREo9bT29wTwwa9EJPbG8hWlGbl6pnIqRUtNQqNC+eFjIBEmlDKTDi79VkeBT9inCGhEm1eMOT4Cq5MJD3iuRfN4TBeKKg3/fzvJX3uNehagXRz76SRDExwJQFxUCTxNlbPduhGPSQeIeJmYLO5PjXAhOPC27moxMV210Cn2TDdryCTszcE9B717toOjecA4e8rgnXmjbo3L+//jydpVAa16pT/MUBus0bQaJyXwMwis9lJFStQ85MlWPHmXU9TKLaEKGen6BsYqyiqYuB+MQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>, "Cooper,
 Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: RE: [PATCH v2 0.9/2] VT-d: don't needlessly look up DID
Thread-Topic: [PATCH v2 0.9/2] VT-d: don't needlessly look up DID
Thread-Index: AQHYSmHO5XmPjC2LsUKpawre5sD9M6zlZ60w
Date: Fri, 8 Apr 2022 04:08:16 +0000
Message-ID: <BN9PR11MB527666EFEF577609B4F254488CE99@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <7671478f-e7c0-c43e-6395-1adc70333e04@suse.com>
In-Reply-To: <7671478f-e7c0-c43e-6395-1adc70333e04@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d7de706e-f13f-4bb7-cfff-08da1915686b
x-ms-traffictypediagnostic: DM6PR11MB2572:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB2572350C51F52F945AD682D08CE99@DM6PR11MB2572.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: NFexa4EwRb5bEHMPdDcJDzt0MnFjo83OOwxwSvaGIJp1h2Yhbm1b/jWZ7Ra8Qb0YSZXhTujb7QwqpERI2BVfE8E203O7a4aHJpKq6S32aVjMJUMPqjX1y52euSCU3lFrTolFb7zknawO6PLG28ci2pjQg3NpOLjgpz6LzOoEqqS839P6yNcBtyzvCe1rxjQFuVVPbS/xPlPoF5OHBX4eaFP8Xi7KJY2bVru3RxtBxqYP2E9PqHFO76c8TVWovfy9gn11dB7JDsJWe+eGOkbtGBs0FLQuPBOTmJ2Uai72hPKdGEeI3BErg46goSnN9JFtpQTRYUZn/ERmhyGXlrtbeLy0uE+T57S/Jc34QKap7aZE6plZb9txWB3vC+ZZfHrxVfg+U1KoXfb3cis1z3z8kFWrwoEHit7qDXwXVsVBzwFn4GzfU5X+3iEUEHg8+V6/7WnfGaep0En2ZmXCZlQvnObwwsWkYmz+HWEGy7Pfwi81MqMAa5eMaOiRljehFCBhmrP8VyrbeGc9ktzIhz7ZZwMn3KYXhsZJRqDdGEoX1p6Bl2CUNFx8SrjjKW681l/4b/bevTYUPEJrZK9GufFaZJTAm7l5tCeKz1kmauF6AF/v6easLD84jNJmRIXpgcKHtuXXKsvJtICRKu4hSUkyR95qz4r1dQoiFCfBVUQDwT4xu80lrxnNFyRIZTeJDirbN5NRzq+JMSdlVCCpfRHT6Q==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(33656002)(9686003)(86362001)(508600001)(83380400001)(7696005)(52536014)(2906002)(5660300002)(8936002)(186003)(26005)(66476007)(71200400001)(66446008)(66946007)(66556008)(38070700005)(38100700002)(122000001)(82960400001)(55016003)(64756008)(54906003)(4326008)(8676002)(110136005)(76116006)(316002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MlJFZkRCSWZVKzNkZG9QbHdDTjNwNmpQSTBwKzgxZmdpWlNMNGJENDhhVitY?=
 =?utf-8?B?WTNYMlNDeGg3ZmlRNkd2K3lxSDhiOUNvaEMzQVRNR281Skgwc2Y3NXhmOXZK?=
 =?utf-8?B?eHhXQkhqS0JVTVQ5b2hBWURJaVo0ODljS05WTHVhZWdlbmVUa05TMXFZNlZJ?=
 =?utf-8?B?UjI5Ykg4YWVRU004NGtNS1Y2Qklmd0FZLzNOSzZuZXpESWEyRnhFTEdUR25y?=
 =?utf-8?B?WmZ4dWpSVTFHUzhtSzJLM3QwbFNJTC80ZXJteDlnZ1QvRHZRbVpIWW1zQ2Uw?=
 =?utf-8?B?Tnh4L0tDTDYxZmpSTzRXbmM2SFBGUWhua1RZM282c0o2bG16Y2RPSEZVWFY4?=
 =?utf-8?B?V1MzTTdJZmUvb2NkQ2VNaGE4TnlSVE44TEhvUkVZNDZObFZYclc2Y3BkVTNX?=
 =?utf-8?B?aTF2ZTM0T0EwTGg2b1lMYXB1ZXNqT09nNzNuQTFsR1owTWljSkVXdDJXUXpB?=
 =?utf-8?B?OEszTGJYZDlHakozRlZsZ3NnSkJ6REZNM3E0T3kyVjJmQmdIZSt2eW56T2xp?=
 =?utf-8?B?S2xnWjU0VlFRa2VzWjRISWlHbGcxekVnYXR5cFRmZG1odUhXejV0Y0FmL2Fn?=
 =?utf-8?B?WGZkNml4Q2hGMFhKNi9YQUtnRC9WbnZlK0t6QUkwa3JFRWk1d3pRWnJXdG4w?=
 =?utf-8?B?U0Q5WE5ZVzNYVTE5VWh5SUxEV1R1RzFWUEVLZDA2U3JWcXcrUU00YS9ZYXBq?=
 =?utf-8?B?WnBDK0g1Y0ozb2g0bjFaNUhyNDhKRWJKWSt5MkFRcUk1bmIwdVRvMlBVSkYw?=
 =?utf-8?B?MFlqcFJ4eTY0d3hsZ2duUGtCTHVBRjhrcDBzYXgvTndzSm50SnNCeWVUWXNm?=
 =?utf-8?B?RUtFTDVvNUNLVXk3WkhzWXIrM3ZZWlFnWDZGSGdPZlhTeGpad1kyb2l5Sk9t?=
 =?utf-8?B?dmp3NlA3Y2owUTRzc2pTUmd6b1VpaXJtbXlQbXoyN0VJRENsaU9haEhMZTU2?=
 =?utf-8?B?QUNUZW5qREhBMHVFVWErRFVTUTRjSHhOeHFWamxUUHdLV0phQ1ZidHRJTDhI?=
 =?utf-8?B?bC9JTTRsRlhwY0tnd05jVzlZaWxvWWdFMTdEMlpoZ1BOWGU0QmpWazMzTlhl?=
 =?utf-8?B?NkJsODlHOXhiLzV2MkFOL0ZVaE80ZlpPaUZ4aFc3TW9hdFV5VkJJbGxxV3hE?=
 =?utf-8?B?WDZtUklRcTgwU0UzbzFHK3BQRWpYVTdhMmRRZ3cwZ1k0SUE4KytZaW1mTTZ1?=
 =?utf-8?B?OGpHcTVodkVZYlBodzdDOEVBQ0o5WDh0VnZsNUtxek84am1HcE5wYkNXY1BS?=
 =?utf-8?B?Syt0VHB3SHhRTXErY25JaGpBQ1NnbWpWank2U0JHZjVYYUJPckRyYnF5QkRn?=
 =?utf-8?B?czFhOHBudHdud3h6L01EcUFCVlhYVEVpUXJoTk9SMTFNMW1Wekk3eXNGN3po?=
 =?utf-8?B?NDljWll3S0FvVEdNMmM4NzltTmVOVUtSREViZ1RkcnRMd0hWclBsei82bmtk?=
 =?utf-8?B?dDRwQUR3bC81UnBEaVpzaWk5Ylc3Y01BRU02dUZFUFJjMjVIU3hzNGt4RmlK?=
 =?utf-8?B?U0lrNXBhY0Y5UkJQb2lDWXdZRENhUUJlSGNwWnVIWmtZdVdVeXc0T2JoaVVB?=
 =?utf-8?B?WVRvTWR2WlVWU3cvN2xkK2cwUzlkUHhXdUJWWmFvY3MzUlQ0ZGd4V1gvYjBh?=
 =?utf-8?B?cEZ0cE10d0c4bUJZNDBsRVRvTE5wV2liM3MyeXBxZmtoVEZlK0hVSzhPMC9u?=
 =?utf-8?B?WGdvWDVsUlBBZ0tNTjU0TzRSUjdqeTdrNE4yeVVaN2pHeUdaMCtkcjJvMjN3?=
 =?utf-8?B?ZHhrNm5UT0ZvTlUrLzZYcmZXMU9XMUIwZThZbXR1eDlPc2dVbXY1amZxTitI?=
 =?utf-8?B?aXhGSGJlYjR6RjE5cnFiM0FuUGd0WmFlVW92clhjRVdYZlUxWE5OZzRNbTBi?=
 =?utf-8?B?eFNHMlFFV3pnZkVvdUZySHd4N2dFQTk5SXdEMDljSlJWcXNVRmI3RExVckdl?=
 =?utf-8?B?eGlMM1k1cFExdTd0ekM5ejdVRHpxV1JxWG94OEcyMUM3Wm5VRUxMRkZWMmRy?=
 =?utf-8?B?Zit0VHI2RHBqYXlMK1BTa2dlbmwwTzJNb3JBNGtjNmczUkE3dzQ3a0g4bUox?=
 =?utf-8?B?MmlhQTE3VzRKeVhRekZ0NC9ZWmU0QTZCeGI2cGdmK3NVamdYbTJRMEcxa045?=
 =?utf-8?B?MTE2MkN1TmNEcDhxTExjUnVVN005bDRBdWM1TGhSMWkyOW9Jb3J3K3UxWXdt?=
 =?utf-8?B?akVqUTk0eUFCOFkvQjRqR3JjVGJsbEdNdjZkZklJc1hHb1Ric3RodUdEYXpz?=
 =?utf-8?B?TXQwZWZqZU92V29YN3RreHpQVjkyNGRCS0t1QWdIZjBqZTE2MVhTK1U1VFVn?=
 =?utf-8?B?QkZ5cW5mZEdxSEt5WUdzRS9jWWtnczR1ai9yYkovN0I0Zm92eGpZZz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7de706e-f13f-4bb7-cfff-08da1915686b
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 04:08:16.1844
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qyzVuTbDuAyfx9SvDxV6HXttikOsrwsZXRTSFcHh3w4aO6blKSmgy4sv7zlZP8vIi+SyU2klyGV8x/6E221PKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2572
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5
LCBBcHJpbCA3LCAyMDIyIDU6MjggUE0NCj4gDQo+IElmIGdldF9pb21tdV9kb21pZCgpIGluIGRv
bWFpbl9jb250ZXh0X3VubWFwX29uZSgpIGZhaWxzLCB3ZSBiZXR0ZXINCj4gd291bGRuJ3QgY2xl
YXIgdGhlIGNvbnRleHQgZW50cnkgaW4gdGhlIGZpcnN0IHBsYWNlLCBhcyB3ZSdyZSB0aGVuIHVu
YWJsZQ0KPiB0byBpc3N1ZSB0aGUgY29ycmVzcG9uZGluZyBmbHVzaC4gSG93ZXZlciwgd2UgaGF2
ZSBubyBuZWVkIHRvIGxvb2sgdXAgdGhlDQo+IERJRCBpbiB0aGUgZmlyc3QgcGxhY2U6IFdoYXQg
bmVlZHMgZmx1c2hpbmcgaXMgdmVyeSBzcGVjaWZpY2FsbHkgdGhlIERJRA0KPiB0aGF0IHdhcyBp
biB0aGUgY29udGV4dCBlbnRyeSBiZWZvcmUgb3VyIGNsZWFyaW5nIG9mIGl0Lg0KPiANCj4gU2ln
bmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1i
eTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQoNCj4gLS0tDQo+IFRoaXMgKGFu
IGludGVuZGVkIGZvbGxvdy11cCB0byBYU0EtMzk5KSBpcyBhY3R1YWxseSBhIHByZXJlcSB0byB3
aGF0IHdhcw0KPiBjYWxsZWQgcGF0Y2ggMSBzbyBmYXIgaW4gdGhpcyBzZXJpZXMuDQo+IA0KPiAt
LS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPiArKysgYi94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPiBAQCAtMTgzMCwxOCArMTgzMCwxMiBAQCBp
bnQgZG9tYWluX2NvbnRleHRfdW5tYXBfb25lKA0KPiAgICAgICAgICByZXR1cm4gMDsNCj4gICAg
ICB9DQo+IA0KPiArICAgIGlvbW11X2RvbWlkID0gY29udGV4dF9kb21haW5faWQoKmNvbnRleHQp
Ow0KPiArDQo+ICAgICAgY29udGV4dF9jbGVhcl9wcmVzZW50KCpjb250ZXh0KTsNCj4gICAgICBj
b250ZXh0X2NsZWFyX2VudHJ5KCpjb250ZXh0KTsNCj4gICAgICBpb21tdV9zeW5jX2NhY2hlKGNv
bnRleHQsIHNpemVvZihzdHJ1Y3QgY29udGV4dF9lbnRyeSkpOw0KPiANCj4gLSAgICBpb21tdV9k
b21pZCA9IGdldF9pb21tdV9kaWQoZG9taWQsIGlvbW11LCAhZG9tYWluLT5pc19keWluZyk7DQo+
IC0gICAgaWYgKCBpb21tdV9kb21pZCA9PSAtMSApDQo+IC0gICAgew0KPiAtICAgICAgICBzcGlu
X3VubG9jaygmaW9tbXUtPmxvY2spOw0KPiAtICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2Uo
Y29udGV4dF9lbnRyaWVzKTsNCj4gLSAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+IC0gICAgfQ0K
PiAtDQo+ICAgICAgcmMgPSBpb21tdV9mbHVzaF9jb250ZXh0X2RldmljZShpb21tdSwgaW9tbXVf
ZG9taWQsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfQkRGMihi
dXMsIGRldmZuKSwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERNQV9D
Q01EX01BU0tfTk9CSVQsIDApOw0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 05:50:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 05:50:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301121.513857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nchVZ-0008U9-EO; Fri, 08 Apr 2022 05:50:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301121.513857; Fri, 08 Apr 2022 05:50:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nchVZ-0008U2-BX; Fri, 08 Apr 2022 05:50:09 +0000
Received: by outflank-mailman (input) for mailman id 301121;
 Fri, 08 Apr 2022 05:50:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lx0l=US=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nchVX-0008Tw-Kg
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 05:50:07 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bdc39f41-b6ff-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 07:50:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 92DD3215FF;
 Fri,  8 Apr 2022 05:50:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 58C6113A9C;
 Fri,  8 Apr 2022 05:50:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id xew+Ew3NT2JdbwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 08 Apr 2022 05:50:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bdc39f41-b6ff-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649397005; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CCWJpKBkGkBtB6QKi+SIV4EeTDG+NjneafWSyWp8DjY=;
	b=ElU7Gmkq8YB7VD4P/ytTyDkRrTrye9prti/xWakjXrFE93JsPT3eNBNpPJXbO6dK+JkDm1
	vsk8mhNxecz7BdgaBFAzpMUhuJFrLeURrT1KhvSLatK2a9l6llBKTwAVvL4zPI7eLZ6RPQ
	K2BqESUxFiA0wopZ9XQvaVgcF6wV6UY=
Message-ID: <fa36ede3-3f5c-e10c-107d-0e4fae4af098@suse.com>
Date: Fri, 8 Apr 2022 07:50:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] mm, page_alloc: fix build_zonerefs_node()
Content-Language: en-US
To: Andrew Morton <akpm@linux-foundation.org>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Michal Hocko <mhocko@suse.com>
References: <20220407120637.9035-1-jgross@suse.com>
 <20220407154426.7076e19f5b80d927dd715de9@linux-foundation.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220407154426.7076e19f5b80d927dd715de9@linux-foundation.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------sl2QoL0SE9T9mqPa0uesbJXC"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------sl2QoL0SE9T9mqPa0uesbJXC
Content-Type: multipart/mixed; boundary="------------nrdROtZnvzPMdkoaABz0zRfP";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, stable@vger.kernel.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Michal Hocko <mhocko@suse.com>
Message-ID: <fa36ede3-3f5c-e10c-107d-0e4fae4af098@suse.com>
Subject: Re: [PATCH v2] mm, page_alloc: fix build_zonerefs_node()
References: <20220407120637.9035-1-jgross@suse.com>
 <20220407154426.7076e19f5b80d927dd715de9@linux-foundation.org>
In-Reply-To: <20220407154426.7076e19f5b80d927dd715de9@linux-foundation.org>

--------------nrdROtZnvzPMdkoaABz0zRfP
Content-Type: multipart/mixed; boundary="------------5RLqE0Putz0HASSlv97z00ZA"

--------------5RLqE0Putz0HASSlv97z00ZA
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDQuMjIgMDA6NDQsIEFuZHJldyBNb3J0b24gd3JvdGU6DQo+IE9uIFRodSwgIDcg
QXByIDIwMjIgMTQ6MDY6MzcgKzAyMDAgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t
PiB3cm90ZToNCj4gDQo+PiBTaW5jZSBjb21taXQgNmFhMzAzZGVmYjc0ICgibW0sIHZtc2Nh
bjogb25seSBhbGxvY2F0ZSBhbmQgcmVjbGFpbSBmcm9tDQo+PiB6b25lcyB3aXRoIHBhZ2Vz
IG1hbmFnZWQgYnkgdGhlIGJ1ZGR5IGFsbG9jYXRvciIpDQo+IA0KPiBTaXggeWVhcnMgYWdv
IQ0KPiANCj4+IG9ubHkgem9uZXMgd2l0aCBmcmVlDQo+PiBtZW1vcnkgYXJlIGluY2x1ZGVk
IGluIGEgYnVpbHQgem9uZWxpc3QuIFRoaXMgaXMgcHJvYmxlbWF0aWMgd2hlbiBlLmcuDQo+
PiBhbGwgbWVtb3J5IG9mIGEgem9uZSBoYXMgYmVlbiBiYWxsb29uZWQgb3V0IHdoZW4gem9u
ZWxpc3RzIGFyZSBiZWluZw0KPj4gcmVidWlsdC4NCj4+DQo+PiBUaGUgZGVjaXNpb24gd2hl
dGhlciB0byByZWJ1aWxkIHRoZSB6b25lbGlzdHMgd2hlbiBvbmxpbmluZyBuZXcgbWVtb3J5
DQo+PiBpcyBkb25lIGJhc2VkIG9uIHBvcHVsYXRlZF96b25lKCkgcmV0dXJuaW5nIDAgZm9y
IHRoZSB6b25lIHRoZSBtZW1vcnkNCj4+IHdpbGwgYmUgYWRkZWQgdG8uIFRoZSBuZXcgem9u
ZSBpcyBhZGRlZCB0byB0aGUgem9uZWxpc3RzIG9ubHksIGlmIGl0DQo+PiBoYXMgZnJlZSBt
ZW1vcnkgcGFnZXMgKG1hbmFnZWRfem9uZSgpIHJldHVybnMgYSBub24temVybyB2YWx1ZSkg
YWZ0ZXINCj4+IHRoZSBtZW1vcnkgaGFzIGJlZW4gb25saW5lZC4gVGhpcyBpbXBsaWVzLCB0
aGF0IG9ubGluaW5nIG1lbW9yeSB3aWxsDQo+PiBhbHdheXMgZnJlZSB0aGUgYWRkZWQgcGFn
ZXMgdG8gdGhlIGFsbG9jYXRvciBpbW1lZGlhdGVseSwgYnV0IHRoaXMgaXMNCj4+IG5vdCB0
cnVlIGluIGFsbCBjYXNlczogd2hlbiBlLmcuIHJ1bm5pbmcgYXMgYSBYZW4gZ3Vlc3QgdGhl
IG9ubGluZWQNCj4+IG5ldyBtZW1vcnkgd2lsbCBiZSBhZGRlZCBvbmx5IHRvIHRoZSBiYWxs
b29uZWQgbWVtb3J5IGxpc3QsIGl0IHdpbGwgYmUNCj4+IGZyZWVkIG9ubHkgd2hlbiB0aGUg
Z3Vlc3QgaXMgYmVpbmcgYmFsbG9vbmVkIHVwIGFmdGVyd2FyZHMuDQo+Pg0KPj4gQW5vdGhl
ciBwcm9ibGVtIHdpdGggdXNpbmcgbWFuYWdlZF96b25lKCkgZm9yIHRoZSBkZWNpc2lvbiB3
aGV0aGVyIGENCj4+IHpvbmUgaXMgYmVpbmcgYWRkZWQgdG8gdGhlIHpvbmVsaXN0cyBpcywg
dGhhdCBhIHpvbmUgd2l0aCBhbGwgbWVtb3J5DQo+PiB1c2VkIHdpbGwgaW4gZmFjdCBiZSBy
ZW1vdmVkIGZyb20gYWxsIHpvbmVsaXN0cyBpbiBjYXNlIHRoZSB6b25lbGlzdHMNCj4+IGhh
cHBlbiB0byBiZSByZWJ1aWx0Lg0KPj4NCj4+IFVzZSBwb3B1bGF0ZWRfem9uZSgpIHdoZW4g
YnVpbGRpbmcgYSB6b25lbGlzdCBhcyBpdCBoYXMgYmVlbiBkb25lDQo+PiBiZWZvcmUgdGhh
dCBjb21taXQuDQo+Pg0KPj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcNCj4gDQo+IFNv
bWUgZGV0YWlscywgcGxlYXNlLiAgSXMgdGhpcyByZWFsbHkgc2VyaW91cyBlbm91Z2ggdG8g
d2FycmFudA0KPiBiYWNrcG9ydGluZz8gIElzIHNvbWUgbmV3IHdvcmtsb2FkL3VzYWdlIHBh
dHRlcm4gY2F1c2luZyBwZW9wbGUgdG8gaGl0DQo+IHRoaXM/DQoNClllcy4gVGhlcmUgd2Fz
IGEgcmVwb3J0IHRoYXQgUXViZXNPUyAoYmFzZWQgb24gWGVuKSBpcyBoaXR0aW5nIHRoaXMN
CnByb2JsZW0uIFhlbiBoYXMgc3dpdGNoZWQgdG8gdXNlIHRoZSB6b25lIGRldmljZSBmdW5j
dGlvbmFsaXR5IGluDQprZXJuZWwgNS45IGFuZCBRdWJlc09TIHdhbnRzIHRvIHVzZSBtZW1v
cnkgaG90cGx1Z2dpbmcgZm9yIGd1ZXN0cyBpbg0Kb3JkZXIgdG8gYmUgYWJsZSB0byBzdGFy
dCBhIGd1ZXN0IHdpdGggbWluaW1hbCBtZW1vcnkgYW5kIGV4cGFuZCBpdA0KYXMgbmVlZGVk
LiBUaGlzIHdhcyB0aGUgcmVwb3J0IGxlYWRpbmcgdG8gdGhlIHBhdGNoLg0KDQoNCkp1ZXJn
ZW4NCg0K
--------------5RLqE0Putz0HASSlv97z00ZA
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------5RLqE0Putz0HASSlv97z00ZA--

--------------nrdROtZnvzPMdkoaABz0zRfP--

--------------sl2QoL0SE9T9mqPa0uesbJXC
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJPzQwFAwAAAAAACgkQsN6d1ii/Ey+q
xwf+Nu5lwR5zq7N46XnDYJl+VsQfKsv7hOhxKwDvLg5gKUurgIIEMvrue6mUa240PbY69VmJYap+
8TjtG0Ate4TKSO+a/XeBPAXI6A2RFHoVczzCPRXnS0LAPF0t9gHEWWnD9mle73VNQZrGCwbrdn9e
1fii2ZPxyMGcEvJdZS+2Ef+bMMsqMlWo8MbSUdfEItKmr6pTdrKle9SJl/RO2o7OhP2LbO9hso+F
XViLpw/Ej+BDPLtHO0umxQv2c8be5A9f2/uk4WAqTBezTgBopyFywodAwCNQ5T4G+szybMfb1ZKe
fZ7eq6d8ml4alH/p80fqN0rC/8hHsJc4xLEOdAb7vg==
=wRjz
-----END PGP SIGNATURE-----

--------------sl2QoL0SE9T9mqPa0uesbJXC--


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 06:03:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 06:03:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301125.513868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nchio-0001qK-M8; Fri, 08 Apr 2022 06:03:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301125.513868; Fri, 08 Apr 2022 06:03:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nchio-0001qD-Hg; Fri, 08 Apr 2022 06:03:50 +0000
Received: by outflank-mailman (input) for mailman id 301125;
 Fri, 08 Apr 2022 06:03:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nchim-0001q7-JB
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 06:03:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a737c84c-b701-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 08:03:47 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2050.outbound.protection.outlook.com [104.47.0.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-xV4G5GKeNvKi46z3qrVAcA-1; Fri, 08 Apr 2022 08:03:45 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by DBAPR04MB7350.eurprd04.prod.outlook.com (2603:10a6:10:1a9::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 06:03:42 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 06:03:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a737c84c-b701-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649397826;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vsVpE/z6laqzXfNvL1yEb/zsFtdxv061bBUPWii4/Uc=;
	b=VHbtjpnsIzkRzOQt/NdGCBPgybAp21eqW/RiDjcz7e6t/HDZq/3OPHEhFmRRRPHv9pJj4e
	MA5jb0MHfLyuR18i7sWZGgJx+FAud9GRXAyaYhasnvO8NIaBz9FaLdyakjKnCPYZRdZe2M
	e0KunvIeZfzyGjhX78J3VDYtRrbPV7U=
X-MC-Unique: xV4G5GKeNvKi46z3qrVAcA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eBeQRk1/AibbsO53vUA6ahfxCvV20aNYlkhjdskpsdhCFUGGpP4u6zElXQrhHGgkgr5OebAO4bXs3kwLu0qS/EmSsEJUqHIPGMGU7ZvZAv7yfA/FY0xQlMJdyKXkTUKyhf3R0KRvnnztl4sROBrlhLdtEc6e0K8upSlGnzH6/ozwNbg61Lk915nyb0A/d0jRpIeumLS8wQk0ElHWfMwvjt++EaLTeP3ivmCEN6DrNQaNhFSwK05ZQUnHSsaD9NsedWET/Y5ZWNGHTaESrl7GS2cIS9OsmjW/jA7wmO4Nzcpx2GIPPhOBHAz94mvLxe/vhvGdFkflsYz7anfgt+XXRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0iUQMe8rwMW19mCVcx3iXH18hdYYZg4WLaVzzpl0b+o=;
 b=A6Ohh61foZiGNPKqCY4D9bLEDh5gFsZOM/skzQDienNLU6ePsnKb/iKgKKDu5OH/n0DX5l6ibzmmLJIGYn71/DgHAtH+UowZOe/arEIVyKZ1vnb/Ddi3FvnD86GpyF7ykHCaouzJnFwe9GoVs0+WlDouX7CyDMAPFJYMvlTU8B9+QbPGfG/fZLHruB4cr1QQTh2LhpScXYGIdKH45hjYxRYvX1tWaXBipDrB1droMsejNEQ+8Pbpgj3SbEmtawoNtS2E+p2u286ZTcK3Q1jQfpET36RcbKviJsTSRZ0F4aLWoYo+1+vVSAQlbFSelZwZ2SSsyoS8DndcGGF9xWQByQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0057e1c5-a651-dfbe-18ed-dc118abb723d@suse.com>
Date: Fri, 8 Apr 2022 08:03:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] VT-d: avoid NULL deref on
 domain_context_mapping_one() error paths
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <6739cf19-a74a-208d-82e8-28dfde7710f5@suse.com>
 <Yk6VvXJHWxJZTgeF@Air-de-Roger>
 <15a53720-4dd1-3139-5d78-5b8a5704a953@suse.com>
 <CAKf6xps+VAvi1QcDGG=mB2pVt3frWFj=6pYrDMVKH+KgE6qaEw@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAKf6xps+VAvi1QcDGG=mB2pVt3frWFj=6pYrDMVKH+KgE6qaEw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR0301CA0002.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::15) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9c656d26-7422-43c5-4be5-08da192588dd
X-MS-TrafficTypeDiagnostic: DBAPR04MB7350:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB7350D9B5667168969D01B9AAB3E99@DBAPR04MB7350.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RnlQcAd4tz2tGywsv6FcwsOpZKwdWyzHwwV8Rh///vlVtCLjPbDGwp1VngMZmjlMo3XS1FJLXdEzDrEc8C92fH1idahtKMQNCHGTonXTRn4QQxKtPru1EF7Dmss2OvAGY/sCdPuaEKK4EdDJWfwoJSeQVPyVpv7PAE2FgREyfrVPaX5bu9FJpTIjDqBdRciWPWWmhalLOAhwAMHW+lpFEN1AcB8mF9J2PjuUbpOD6//bSEERcScDDKXM9lHvx83Ub58bZdyeJBY3h+9SU9I4zdqOsQqBD78KzPZg+23VoryIOr7uudL1UYDQe6PvXRvxaiQKUKICYdHSc16u9K3aDGHniYYHJNoODKb1wX9G0fmFe4Na08FqZZtAKcQGLDuiQCkv2rzuHzUsX3QvLLdKIEsK4gNMFht6IzdTrsmFKHsr4D+8mUxyDS7d5YL/3oo95RdFuDCXlyg8X3KGmrV31//JHHZdxAzPT+3s+EhTNwxy1jMAEtJeUcfBUABbCZ9AQQuu/xfTRQElxp0iZi0EeGmqy2o9ZBkr1YxjMBTBNzQnDhpuJgo/0cf44vf+IigaD7+WAWm/RX8/RX1+y1mKhrYH7ZoLR0bYEm+Qrq/yWUJpYwRevpcoc3LzR5Dd4Gla2ZinVxGYQY2AddSkuJOjbNGfQGHM7RRSg8FYe8tbfGef1ycuCLKen9JynIYpZEuXzwbgCGUmiQr3zXXQFnBABg5a6WhvCkBoTxnMmoftZhZ30Q49zhBnI030YLEghIuB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(66946007)(66556008)(66476007)(6486002)(8936002)(4326008)(31696002)(31686004)(38100700002)(6506007)(6512007)(86362001)(53546011)(2906002)(83380400001)(26005)(54906003)(316002)(5660300002)(186003)(36756003)(6916009)(508600001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?nTWbVKcPDx6ZYkMpGQ5EeX1slovt2LDf1zC6noaH4hb1rmnhaiXu4SwgEjAi?=
 =?us-ascii?Q?2FqXV/YFR9O5G0PctgvopnViI976dla7QkkE20+2VzR37ebDD/VlPaUpeIxR?=
 =?us-ascii?Q?nNFugAC9r9kfEMc9Haxt3TYx1TOhdaUMopq8FYlWv+ENx6M/c8K0Z88u6uvv?=
 =?us-ascii?Q?/n1aHAxwcC/sAyU5CCONxrXgP0m6qqiqBaHMguy2jbKB0okj5rBjydgOpqnV?=
 =?us-ascii?Q?ricNDyYX9w3XCWhKBapTQpa7oCGqVQxhKcgcy+ftDxcO4NHSPUPX2pCUI2Uk?=
 =?us-ascii?Q?HNZH5xLIbJptBWuw1PujoYdHRcSq0gf66ID6Xo+CzIuwrXnFYlmh90cwIDgr?=
 =?us-ascii?Q?PpjemzGuoLgjQq9yOwcCmmqf97CGeYTb8e9NzlGauT6cW40Sqop53xleRbFw?=
 =?us-ascii?Q?TS/Pmj5p6ofkqxFwYQRi3EW3yZdaXNmzJ7aUA3xtuDBnhDtnmocPxNKOrNYJ?=
 =?us-ascii?Q?DfM8ylWcmTPRurJwnPUTFwDKYgUs7/QB3K0vCAIyOJ1JFRC/x2F2saEZhQ96?=
 =?us-ascii?Q?+viWcuRUFg95iJTFjk1naq8lj0D1DRBFy+/54KXDRTKCgqZOett8SqLDDglP?=
 =?us-ascii?Q?UK/k36tYZc6Yvio4zf1gtiG2oMbzyAuTjPcsRum9bAv1GCCzRLwpLienVFJZ?=
 =?us-ascii?Q?6G/uCt/GvlWP54XFqq1V35mDPwSF2LUOakdzSAzHlyNFOR4fuDN5AdZQ2T3o?=
 =?us-ascii?Q?K4M9rkAUzUbbZUHf/CSdIDqm7AEH4oN6nh0eTjtTdCdFlnJvFvLe+GfOf/oe?=
 =?us-ascii?Q?3s5J7GBykkfutUEDIP7Cycdl4zexXrMS4HR0iTJt8yyf2yuKy2pM5cic6evi?=
 =?us-ascii?Q?rcr6pj8AHTKEM+uhyB4B3Wn0wSMuqu3ALOZPiWKnr/UUCM4zWIEbQbI95pgs?=
 =?us-ascii?Q?L3WMyD+Qdowk/vU7diErJpUXVHqn9ZUtm/zbPY5G+3sSEqZcl6rngvC7hr/e?=
 =?us-ascii?Q?zZdvRAkA0kOkumAqhN9XiH9SJ1CjgG/C0QmqB9H5h9yJmkLKu4PTCueFjhwp?=
 =?us-ascii?Q?A2YzbMBJc7kUqxJKQcZjv74Sh/7/Talo2bS524Lpj//703fcCXzIvOhb9ZkC?=
 =?us-ascii?Q?KWjfm4C5DY+kzF+dJYjnSO8u9BoapyFx74P45c/MYtbffZSnBBE9q5IBENr+?=
 =?us-ascii?Q?yeSf/hPmCuIQ9UcWK+i9ecKw8635VscuV2JL3dEXy9ki2QAGF2lx2HJa/L+/?=
 =?us-ascii?Q?f8mFB4TpjmDUyklnYl9me78raE2QZs9SagdFx+O4x3F/xtY9UIJng1lHpOdr?=
 =?us-ascii?Q?JXtYNrO9ANOnPfnFFU5J8rze4UHXa062yyn0BoQBt8zuwLydPJ2Xl41rxvAU?=
 =?us-ascii?Q?q2odJ44OR2D5adJAzT9gG2JuQIftwxDjLFV1KjCx40a5xTIFuxSQV0OhI9nx?=
 =?us-ascii?Q?IQZKQT/sQwPtRCxyHcGSsAcG0KNsMrWkjG+t+XiWyaDOupEWuH+by0qLwmNJ?=
 =?us-ascii?Q?d0hhWN5Ylb2M05Fxbc7s+c5a/wv2+SkAljchMjveI/IVN33mvaHG33MjCCD1?=
 =?us-ascii?Q?V1hVdIIUWJ9ma24oDNAe6+WkfHLePT1Yv9RdWnZZbZV3rNPEX/2dyPCPnMey?=
 =?us-ascii?Q?nG7DigzWs5fRlfOMU3ENqNAPFPqNIChsQGgFYmIruzWS5cPPbiiXr6oianAO?=
 =?us-ascii?Q?7pR3MuiPUIDbnECQryBhcBeJMfnw8JsRPrBbV3uR6HWRu+lggi7OJZXCmZSa?=
 =?us-ascii?Q?uJpFpkp8LlfCkw57Cf7jkrp/uQaBQ+MAczrBCZ8hzdGT1Mx+jzyQ5MkpTbUk?=
 =?us-ascii?Q?nqp9eL3zJQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c656d26-7422-43c5-4be5-08da192588dd
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 06:03:42.8441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wlvx8X6KQJZ00AIXn6FSCqIOC69bzdSqHmZbVduli9n9JJi3Bh1JEeG12GYBAi89ct2e7/QFArRJPu2Mi5FySw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7350

On 07.04.2022 18:31, Jason Andryuk wrote:
> Hi,
>=20
> On Thu, Apr 7, 2022 at 3:50 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 07.04.2022 09:41, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Apr 07, 2022 at 08:11:06AM +0200, Jan Beulich wrote:
>>>> First there's a printk() which actually wrongly uses pdev in the first
>>>> place: We want to log the coordinates of the (perhaps fake) device
>>>> acted upon, which may not be pdev.
>>>>
>>>> Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
>>>> device quarantine page tables (part I)") to add a domid_t parameter to
>>>> domain_context_unmap_one(): It's only used to pass back here via
>>>> me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again=
.
>>>>
>>>> Finally there's the invocation of domain_context_mapping_one(), which
>>>> needs to be passed the correct domain ID. Avoid taking that path when
>>>> pdev is NULL and the quarantine state is what would need restoring to.
>>>> This means we can't security-support PCI devices with RMRRs (if such
>>>> exist in practice) any longer.
>>>
>>> The sentence:
>>>
>>> "This means we can't security-support PCI devices with RMRRs"
>>>
>>> Seems too broad and could lead to confusion. So I would maybe use:
>>> "legacy PCI devices" or "non PCI Express devices".
>>
>> Right. I did actually forget to either drop or edit that sentence. I've
>> now extended this to
>>
>> "This means we can't security-support non-PCI-Express devices with RMRRs
>>  (if such exist in practice) any longer; note that as of trhe 1st of the
>>  two commits referenced below assigning them to DomU-s is unsupported
>>  anyway."
>=20
> Mentioning "Express" makes the support statement clearer.  However,
> I'm not clear on what unsupported means in "assigning them to DomU-s
> is unsupported anyway".  They can't be assigned?  I'm testing with
> staging-4.16, so with XSA-400, but not this patch.  I seemingly have a
> legacy PCI device still being assigned to a domU.
>=20
> It is an 8th Gen Intel laptop with:
> 00:14.0 USB controller: Intel Corporation Cannon Point-LP USB 3.1 xHCI
> Controller (rev 30) (prog-if 30 [XHCI]).
>=20
> lspci output for 00:14.0 does *not* have capability "Express (v2)",
> but it does have an RMRR:
> (XEN) [VT-D]found ACPI_DMAR_RMRR:
> (XEN) [VT-D] endpoint: 0000:00:14.0
>=20
> It looks like it is PCI compared to 39:00.0 which does have Express (v2):
> (XEN) [VT-D]d1:PCI: map 0000:00:14.0
> (XEN) [VT-D]d1:PCIe: map 0000:39:00.0
>=20
> As I understand it, an RMRR is common with USB controllers for
> implementing legacy mouse & keyboard support.  The Cannon Point PCH is
> fairly modern, so I'd expect it to use PCI Express.  Xen seems to
> identify it as DEV_TYPE_PCI given "PCI" above.  It is an integrated
> PCI device, so it has no upstream bridge.  Maybe that is why it can
> still be assigned?  The "unsupported assignment" is a legacy PCI
> device, behind a bridge, with an RMRR?

Ah yes - the "behind a bridge" aspect does matter (but I can't
adjust the description of an already committed patch). That's both
for the respective part of the XSA-400 series as well as for the
change here.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 06:25:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 06:25:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301130.513879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nci3f-0004bA-Ep; Fri, 08 Apr 2022 06:25:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301130.513879; Fri, 08 Apr 2022 06:25:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nci3f-0004b3-B6; Fri, 08 Apr 2022 06:25:23 +0000
Received: by outflank-mailman (input) for mailman id 301130;
 Fri, 08 Apr 2022 06:25:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nci3e-0004at-P4; Fri, 08 Apr 2022 06:25:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nci3e-0003He-Ln; Fri, 08 Apr 2022 06:25:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nci3e-0003r8-0c; Fri, 08 Apr 2022 06:25:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nci3e-0003ha-09; Fri, 08 Apr 2022 06:25:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VWGm3sWVAusiWNGIXmSYuvc9+Y6KSltOWA0lY2gQAqo=; b=AOgGq71Wu92I+f2d4TdFdrRh9/
	e6vvrizfwJo97ZgylK/bBBVUew/X8UPW2ett5C3fC/dKfA8lGT24eId54H7vp1LCPhi+s/UNhFJbF
	vAunRWcTz2JtKHfWtahP13LWtmaT7h+paFnK7S8lIiPedooGkVcP/LgS623BKWUR8DHs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169223-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169223: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=a298a84478053872ed9da660a75f182ce81b8ddc
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 06:25:22 +0000

flight 169223 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169223/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 a298a84478053872ed9da660a75f182ce81b8ddc
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   38 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  286 attempts
Testing same since   169173  2022-04-05 05:13:00 Z    3 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4610 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 07:01:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 07:01:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301139.513890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncicR-0001Cj-CY; Fri, 08 Apr 2022 07:01:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301139.513890; Fri, 08 Apr 2022 07:01:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncicR-0001Cc-9R; Fri, 08 Apr 2022 07:01:19 +0000
Received: by outflank-mailman (input) for mailman id 301139;
 Fri, 08 Apr 2022 07:01:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncicQ-0001CW-KD
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 07:01:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id afb8a5ce-b709-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 09:01:17 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-YEft6iqqP2SVmIY70AmwnA-1; Fri, 08 Apr 2022 09:01:15 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by DB6PR0401MB2293.eurprd04.prod.outlook.com (2603:10a6:4:47::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 07:01:14 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 07:01:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afb8a5ce-b709-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649401277;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i8Tb+DZM38MOHgaL9OtsGqtYxTFRI9YuIADuuOOfexg=;
	b=O3a/xhi4+GYnlA6vZzCkd5EYrb1WvQPuzOZy4mY1TZpa2xOCo8C9g/6tCmpH+9SdzfGLtJ
	xr7Zvp3hvHO1THcIaAVd7VA/8Fk3f5J38DCc+j8ADiPLOsGWKm+BBnFK1L8t7IXFjTPQTU
	uLJKyN6F3YSsx20/q3zaDtyy0PIczeA=
X-MC-Unique: YEft6iqqP2SVmIY70AmwnA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MbbYKXju7PB/yxDZFy68yaq163WcTCacLvHNZywln16OqrjWmmr26Grfi51nUdxi5awfEXnTLdurluyms4Xr6OKHk4KWRWzCrMtSyYOe2C1DKW7A0vWP/ql+D9qfXarxYZ+63PeKLdS4+5URokBsc7cc93htG3X8O9vOSdwV36apjeLVGLA0ytZAvwq+92xAFuGIJULxfd3Qh7W7dvhgFKLHTmIgZvxhFDU7/AOLhsUy0ND9yEWSa+7/okTeGJ67Na1BaOL6G7kHzOhN+qPmiy0Fx4P1kDAbVR857/lEH93MNdGl4SA9mGZ9QikAXFzCIXedO7cp2mtpDHe51oh6Fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i8Tb+DZM38MOHgaL9OtsGqtYxTFRI9YuIADuuOOfexg=;
 b=boeT9/4BFWEWyMy8+mVVa1ZZGjymEwRLfhoO/Z4ypai0jKk9ho0JSINk20Zc52595CK67XvoXcR5a78l8cVD1p4j07XLuOgUFBjQIt0uWpx5rDaYc0nTaUaQBb7ZofpQcxvVlj7yu2Af2M7lZop3PEEuKSfm+DzsJ1SzmD3neBFT2kMydAdpyGZ4V6xq0Dx6mDWfxwWNcqgu7EEhUh4XeiJnYu8TkvKz7EB448xp4FG1cgdDtYKy9zuohOEdFKA8pOuVaPw03+YVKmjLvmwvxYXqTteYRsGH3+or9pFp8jnKuBjboChLFT4CF/0rczUmsnT1jR5l1ub8SqVG8ui70g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
Date: Fri, 8 Apr 2022 09:01:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Content-Language: en-US
To: xen-devel@lists.xenproject.org
References: <osstest-169199-mainreport@xen.org>
Cc: osstest service owner <osstest-admin@xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <osstest-169199-mainreport@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0071.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::48) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 50da6413-af27-47a4-f97f-08da192d91d5
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2293:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB2293960BF3ECBF6773B24B87B3E99@DB6PR0401MB2293.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Whid7LvLiNCFf2XrSASZcXKivn9YUJF3Z2omiRrugcQaAjuOjakBKgVZooXKKJuaaVyjz7lakyXFDz4FWMJyHRqMouVmWqwVn8y35UMBl3ZUMGuhGkEQPqpqOWAfu3dErLSdfJ2Z9A/FaiBUsTH027Kthywpfsr1m3al1zexqv2hitK49KyY2YxJTBTiuz3S1XQAvFXSLvPS/s8ulzICxEN222tf862pxoYtFpPgLhIzAacVS51Dp4+TN6nA3ZdQViwHUx/ruqMrzzVBv4myWTRBEO3lcJ1BAOoHMt1vjgPZDQCBkKCszjz749cCCzVBPg0OcN7y0rzgCeJXGwL1T3O+O+5kE+y4By6sAAI7/tDtGrZhkq4vcQhA14amfmhDK+vcHIxppKWQXwlM97s+UaKFimYc+uktk4Xps/FPmztKHb1epIL9KCSTtLx24I2cgvWa30eVEjRS5oKUMWtORWyC/IBt877Q3sWbLTAOEoeqhPFH5Bog9t8bnafsHNV6Yq2RmfiYD88tH4vPyN/dvpi8hHzr+8QlxJmmbEqLL9giocTWNIfzaVlJtxF8EuVo+NYOb8g8xOhaN4yXVUs3rSag9uozrcKtN1yiaW84Cme6Ji/iBkKC0b8JhgXSqNbhd4giz/w1sHcXTS1eR0GMmgkV+/965KzqQHr9wKL2N67wFf6TV1vJ5upxvq+fy1kSFb1wtbnZCw6p6DUk6P7Sk48Hp9amGQwR258l70vE0o3zVzsqiAleLhumrt8Mo6Iz7ityI0ch+QxH+XnsWElHtEYblMAmiOGqeoDlzUSH9z7VDWIwAqt7xjAP/cdVEhJb
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(38100700002)(5660300002)(66556008)(66476007)(8936002)(966005)(186003)(6486002)(31696002)(6512007)(86362001)(2616005)(83380400001)(107886003)(26005)(53546011)(6506007)(6666004)(2906002)(36756003)(316002)(54906003)(6916009)(66946007)(31686004)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MURxRzkrb2xtVlIzbmdiYUd1UFBvWFdNMU5Zak03aldaZkpmMWNwbVRmNFI4?=
 =?utf-8?B?eDRwYmRzVzBZeEpGbkxmanVUNkdESmlMNkplT21ZZCtXSzc5Vk13ZU5INTZT?=
 =?utf-8?B?WDN2eXFnRnFDZ1c0NzhHUFd1YnJ6bnBMVGlyZmtCd1ZHaU5NREc2Ykt0SU90?=
 =?utf-8?B?ZSt3S1ZRL0RCTjVuNjRpVEpNUmhxOVRpRkw4YWtXT0t6SElwK29WK1M5eGVW?=
 =?utf-8?B?SmRobHNOTUdVWnZwdHBjcENaVWs4Q2JwUHdORC9rRXZveHNYTXZ4aUhSdU1q?=
 =?utf-8?B?ZHd3WXUvUWs3V3IwMTE4QWErbTBhYXN3a1RGcS8wU0ZHZDVPa0Q3ekpYcEcy?=
 =?utf-8?B?TGtwdXJjYTh2Y2UvWUZDdFU1T0dkMDV2amNncEN1Y2M4dU0zTXN5VXJ2bXYz?=
 =?utf-8?B?c2k4d3BjeTJmM2pubkZwejRQZ3VXS3RzN2FMT1ZPN3Y0UHVvNzFvdGxXR3VR?=
 =?utf-8?B?dFBpNlV3L1JCU0dCNVkrMlY1MWNkcU13ODNucklxODdDZXZPVm13RmdZUnl6?=
 =?utf-8?B?Sms2dENFemwyY2RYQVJkdkxtMThqZ1F1bnpDdkUxZmVnMW95RFFiQmd0RnVD?=
 =?utf-8?B?aGZDODFabUhoN2VuWHJLYzl4VEJKYzNwK3hpT1hXazJ5QVZ3N040NkQ0WERL?=
 =?utf-8?B?OEVOa1BBdml1Z1BFK3AvMzFKWUtnM0tHMzRuWmgrVS9RNkFXTmdwaG5SQnJO?=
 =?utf-8?B?dmxuVHE5ZWtId0hEa0s3ZE5lK0RxRGVrNWExako2Mlc2dXZRa1VPd3hQZTFS?=
 =?utf-8?B?T3FXcTd2Wm04eXBKYnZuUFZoVk1ESTBkeVRJZjkrMDI2N0dkdDV4Y1hROEVz?=
 =?utf-8?B?N2xNNmhwcFZ6YnRvQmhxMWRWakJiWlFWS3NhMHprTy80eDR0bVdoVktYOFdi?=
 =?utf-8?B?TGlBTi9VTm0rOVhnU3BPL3d0enVYNVRWdkl5TWZZWnNOUTlQcWw2ZWM5ODZV?=
 =?utf-8?B?ZEhITVl2T3pIR0FiU0o0MUxObFhCV1hhQ1RqMFkvWDdVS0ZGTEsybTFDWGN2?=
 =?utf-8?B?djJzZmlrUmliczQrVUJNaEhYR29WUFJIYjNlQXVscTZnSjRuZjErcEoxVmpN?=
 =?utf-8?B?aEpwSU8waHB0RWZKSXNzR1Fhbjl4c2xpa1RTQitvTVJLT3lCS0ZmdEs2Y0d1?=
 =?utf-8?B?dnlpMElobkVFR2VhaGkzbzdncCt2OWRodUlWUldIMkEraE55TldLeURHb3p4?=
 =?utf-8?B?a0pkK01HTk1ZbkUzTFNSdlRvK3FHSGprN0EvMTYyTkhTKzRxV3NnUHRLMXJx?=
 =?utf-8?B?bUFBRmVQY3ZHakU2NVZ1b3lzWXBXRTJtRDNuRHZxdWdGR2tGMlYrZGlBVFVM?=
 =?utf-8?B?Tmd3blRWaVF1VFg0WW9Fa3E3a2hOSkErTTVpa3ROdlhjeHM2OElMWWNsem5N?=
 =?utf-8?B?aVFaV0VxTUFsNThRL2YxT0pnUFl5eGlGdndYNExPRW9Cb3VHeWd5ZFFtOUE4?=
 =?utf-8?B?b1E1dThxWXpFa3RCN2ZnSGpVSFZxM3BqQ0dnT2Z6dmNEYUVDVVVUZmxHQWFZ?=
 =?utf-8?B?RlNFaXN0TWRUWVllc2Y2U0hTQkVFN21kVTRUQy9WVXJJcDFpc2JqTVNZang4?=
 =?utf-8?B?bHRENUh6MzFBb0cxWS9IMnp0UTB1QVluMi9nZkViZFVFVlhMbDBoeVpjZUtH?=
 =?utf-8?B?QVFzQ2ZCc1lUZDNTYjF0bnl1eHlNSE5PQ1d0NlVCV3cxZlk3WE5rNWJWTXFV?=
 =?utf-8?B?QUhKUm85MXY1SURuZzZNV29tenI3MmxZWDdLREJTOUNtR2F6dWVoYjF4NDJq?=
 =?utf-8?B?Z0hYQm1DU0NIUFJjd0ZRWWphMlFnZ2M0d1NhZ2VINHZLbHZ2UWx0WDZlWXMz?=
 =?utf-8?B?c05PVW1pYlc1KzROT1kwZG5DZlduMjYrTlh6S2ZGcmNXcXVRUFF3QWZiUEZM?=
 =?utf-8?B?UUVSVXhHNEFMWXVsOVR3M3NQOHVYeEFRRno5WGkxM2s5d2h0dWVDVU1qKzha?=
 =?utf-8?B?MTc4eVUyRFJEUmt0V1ZjczFzL0dTOU05M3FrWmg1QzgzSUVDRjExSmM2bHdi?=
 =?utf-8?B?NEt2QU9vNk9JKzJZTEpUcmphdkp1eisvV2tieDAweXZ3Q3RqT1h2WWpxcnJi?=
 =?utf-8?B?aTBNT1J1SG9EaFhsMnJSaU02KzdqcE9oR1IrdWpIdGxsL0tvOTljZ3czSXJO?=
 =?utf-8?B?SkpRZGdJUGVRME01MU5UdTFBeVpHR2U1MEF3bUtNYXdNenlLNDRDRndUZGp4?=
 =?utf-8?B?TWdITmNFWEo1cXpZalp3QlMxMWRDMU9VSjJ0a1NKRm5iOWFxYnR4dU5PVzFE?=
 =?utf-8?B?dnhoRk1Ea0FuSHVoRkluTW9tUUUrbWlENDVOVTJtSDViRmNrMERmOXlOdTZ4?=
 =?utf-8?B?S3E5bVJnUkVYdzhHVnJqdXBXUTV5OERBVCtPSERQTFo0QzBMNllydz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50da6413-af27-47a4-f97f-08da192d91d5
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 07:01:13.9006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HfRSRN18Fnsonfi61MmHpwBAevU50tNMia8CzEtdD/lJccAcZ/9Ku1q8LpleZepWy+y6rjtCOijHqLwcYFrrxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2293

On 07.04.2022 10:45, osstest service owner wrote:
> flight 169199 xen-4.12-testing real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/169199/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 168480

While the subsequent flight passed, I thought I'd still look into
the logs here since the earlier flight had failed too. The state of
the machine when the debug keys were issued is somewhat odd (and
similar to the earlier failure's): 11 of the 56 CPUs try to
acquire (apparently) Dom0's event lock, from evtchn_move_pirqs().
All other CPUs are idle. The test failed because the sole guest
didn't reboot in time. Whether the failure is actually connected to
this apparent lock contention is unclear, though.

One can further see that really all about 70 ECS_PIRQ ports are
bound to vCPU 0 (which makes me wonder about lack of balancing
inside Dom0 itself, but that's unrelated). This means that all
other vCPU-s have nothing at all to do in evtchn_move_pirqs().
Since this moving of pIRQ-s is an optimization (the value of which
has been put under question in the past, iirc), I wonder whether we
shouldn't add a check to the function for the list being empty
prior to actually acquiring the lock. I guess I'll make a patch and
post it as RFC.

And of course in a mostly idle system the other aspect here (again)
is: Why are vCPU-s moved across pCPU-s in the first place? I've
observed (and reported) such seemingly over-aggressive vCPU
migration before, most recently in the context of putting together
'x86: make "dom0_nodes=" work with credit2'. Is there anything that
can be done about this in credit2?

A final, osstest-related question is: Does it make sense to run Dom0
on 56 vCPU-s, one each per pCPU? The bigger a system, the less
useful it looks to me to actually also have a Dom0 as big, when the
purpose of the system is to run guests, not meaningful other
workloads in Dom0. While this is Xen's default (i.e. in the absence
of command line options restricting Dom0), I don't think it's
representing typical use of Xen in the field.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 07:07:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 07:07:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301143.513900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nciiV-0001qr-3P; Fri, 08 Apr 2022 07:07:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301143.513900; Fri, 08 Apr 2022 07:07:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nciiV-0001qk-0Y; Fri, 08 Apr 2022 07:07:35 +0000
Received: by outflank-mailman (input) for mailman id 301143;
 Fri, 08 Apr 2022 07:07:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nciiT-0001qa-Fy; Fri, 08 Apr 2022 07:07:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nciiT-000416-E3; Fri, 08 Apr 2022 07:07:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nciiS-000587-Uc; Fri, 08 Apr 2022 07:07:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nciiS-0003pc-U3; Fri, 08 Apr 2022 07:07:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+ZeXAs20ImrMVCZDgEn67u8RC6Vd6dO76mqluxmeFnU=; b=uyztNAO4eJXhfAs4mphKt24NBU
	ZEKEsFZVqONKiUvJkuTVW9JeEbAQDMfYImki1HVAeGJILItZzXlVc4ACnEs+52ScRXo27Q2mEsTw2
	rARzE8plDQf0AyNMYu2sf+Yj3QKLIUCx3XmJQFZbjrUQH0drDQCHWbvpwvA5Ztp+e27M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169226-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169226: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 07:07:32 +0000

flight 169226 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169226/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   38 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  287 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 07:13:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 07:13:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301151.513911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncioV-0003Tc-Ob; Fri, 08 Apr 2022 07:13:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301151.513911; Fri, 08 Apr 2022 07:13:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncioV-0003TV-LG; Fri, 08 Apr 2022 07:13:47 +0000
Received: by outflank-mailman (input) for mailman id 301151;
 Fri, 08 Apr 2022 07:13:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncioU-0003TL-G1; Fri, 08 Apr 2022 07:13:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncioU-00046z-BH; Fri, 08 Apr 2022 07:13:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncioT-0005Is-UB; Fri, 08 Apr 2022 07:13:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncioT-0001gn-Tg; Fri, 08 Apr 2022 07:13:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mg12cEnSRCl7cVh4NmEaBp1hHlsPFRHCt2HWfcTadwU=; b=KA9cNqUIvgsEJLYp635lSaUQKS
	IkrGTHAlsea0HBsiQkv3pBKJ/JUYm0/0lOOfvkPFYTl6nOwvYFvLLfo10fy6dr58txkL5J/5NiPk2
	UaLh6EZD6oZ/UGmZEZpC9qIMePCaHOwEQGgITSGldnnIgt78e4rupOXFFaiwDBVmT0YU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169219-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169219: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3e732ebf7316ac83e8562db7e64cc68aec390a18
X-Osstest-Versions-That:
    linux=3123109284176b1532874591f7c81f3837bbdc17
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 07:13:45 +0000

flight 169219 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169219/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 169174

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd      13 guest-start      fail in 169188 pass in 169219
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 169188

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169174
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169174
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169174
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169174
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3e732ebf7316ac83e8562db7e64cc68aec390a18
baseline version:
 linux                3123109284176b1532874591f7c81f3837bbdc17

Last test of basis   169174  2022-04-05 08:27:06 Z    2 days
Testing same since   169188  2022-04-05 21:41:40 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Borislav Petkov <bp@suse.de>
  Darrick J. Wong <djwong@kernel.org>
  David Sterba <dsterba@suse.com>
  Eli Cohen <elic@nvidia.com>
  Ethan Lien <ethanlien@synology.com>
  Jason Wang <jasowang@redhat.com>
  Johannes Thumshirn <johannes.thumshirn@wdc.com>
  Josef Bacik <josef@toxicpanda.com>
  Kaiwen Hu <kevinhu@synology.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michael S. Tsirkin <mst@redhat.com>
  Neelima Krishnan <neelima.krishnan@intel.com>
  Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
  Qu Wenruo <wqu@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 583 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 07:16:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 07:16:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301160.513923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nciqn-00049h-BN; Fri, 08 Apr 2022 07:16:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301160.513923; Fri, 08 Apr 2022 07:16:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nciqn-00049a-8M; Fri, 08 Apr 2022 07:16:09 +0000
Received: by outflank-mailman (input) for mailman id 301160;
 Fri, 08 Apr 2022 07:16:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nciqm-00049U-JS
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 07:16:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c24f8a69-b70b-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 09:16:07 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-I7YZqA81P6e09bUd0eAoeA-1; Fri, 08 Apr 2022 09:16:05 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by DB9PR04MB8187.eurprd04.prod.outlook.com (2603:10a6:10:24a::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 07:16:04 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 07:16:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c24f8a69-b70b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649402167;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=+pDejtzsEifzIy04C1ku0J2v8gAR4+ceFtzM7W/JNZU=;
	b=EpbOHXSl51OheHSV9uXUdWQH6hT0V2WoqDFUWPkU6D0K5JEfc2CCTONzUAOXZMmyLBKfo4
	V8IEuTzQojMcsgsrhX6B6rDJccah13bfOgakGhPmqpb3oM/fogzob16RtTcv28fUOwMgAh
	LfJ+Lnw81mvU/WkHdwopqtB6V9gjLgA=
X-MC-Unique: I7YZqA81P6e09bUd0eAoeA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TT/bTL6Vx0RmcSyIdDdW0lSFT67aPCF/va7VY4xFHPT+2fI30MdBIzW+T54G7QaEFhVzpvZmRgmQLNSH+CnQuh1FxxLoLoAuVwYT5DDEED9ngjj642OPs/005zeF8h+/fFBL0AeZuUOFnszK5F/7QZbK42M+pG8iQpnCEu6H3cMdpwFPNDG45hlJaViBXk4qlYoKQfOvoRagxrqRYJH5Jl6rzYji5YhVis1J9CrESmP1juf98T5AIufMXYGnWvzNt+qcEAmqK8ox+ax0FpZGsfAWf+/c7MKnZhS5hDUQQ6nyoi0AOv1D3HnQEpm3jOBgkb45mF3VF/E2JlMUbOSjoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+pDejtzsEifzIy04C1ku0J2v8gAR4+ceFtzM7W/JNZU=;
 b=Vs3FwxauyNgRpBCHbmLWuQ93ue+QSV/j0inIbv9DjGphilUivhkmiXXt9+skdQgy+ctL+GSTkD7Udn+339ylbP+xMn1kMH/TJHdIj8Pjg25twyZjTjAY/ODEBO7nYOT+p9Lr7g5U94HvDlsjrZtjBqjty5owRwPXw1P6WZ/Bb01vdBEriBK4GrAj8/mH/ZMm6t2VABml980sW49fzUNVcU2hkCgO/4Xihi3uk4LsqsVgveVfX3NWYTuc05oDUhL+SRm9dIGEDCWGJI4UztMuarN/28MqkiXWXyobpCgmFwCCblZDLmGaUqS0/bx1VOK2A9LUfC1vNkaCE2fRTRAtqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
Date: Fri, 8 Apr 2022 09:16:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0332.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::11) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 60aeb074-888a-46c6-3fe5-08da192fa457
X-MS-TrafficTypeDiagnostic: DB9PR04MB8187:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB8187676A98825D373B6B66F9B3E99@DB9PR04MB8187.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jshlfy7pFnv4uh+P84j1H0/jDx5rojKB7P38YPTv34WtwaCzgQrPkK2LSdCMo1urQ9kUnvCRgr/Gxm3PA4+36FhYPIsB7UNWdw/ZQH1tg+s0/BycOkUmKu8mp/Dg2VTcCFb1RxC0F2qkbu23HgvqOqaP++UqNm2E+8fIDTYRlnEEu2GP4H8PHg9y0WiF5oAuRWaN1MvyOC3JPrbIarqzfhslv0qMNQ1LZXn4TA4vkD8aivVj4KZx2OdvRKmo/OmJdaKLUSykNVJlldtXx10kwhSD6bVIjIDbNXtXqb19cEYtV+xVz20ftTE4XT50VtlongWespp8JnI5aQkJDpQieZJgRU77oeXkTmq8fnTWVxMkhyw53P5jH6igUUnzSJRs38xF0JxkDrBRyvIKF02Li+dqyIuSCBXMzLXzyGzNiBlrBLwDv3JAnNKl5lAhEmsgtX7AeYZiSZojm5NEBMLzyivaFj3POhWzEnvlnNZipq210nhimHoJm0rbtzuu3zGCGD9hFQIJGTIkHwhOITi/iVIUyXbT+ghI75D85DOVctx6dH2FnQtsvV4OAmL8P3koLKBNlaaS5JZ8F1x66lreH/srnQor0apMIvyh4crCUmZ/KTX5JOyWqA2YECMyR+U+qDHOULv4gHhFCYM76BR/bXEi1v9EISKFgksIZ8ZODS7Y295iDrhlx7/sguyhPnCIU5ZydHrr5Sn9tnyEp1tyEI3rQa64nHIaL0JEsmIy6HyhcxX/Pi0gCPfFEjtoMRsw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(54906003)(83380400001)(107886003)(6506007)(6512007)(26005)(86362001)(31686004)(316002)(31696002)(2616005)(6916009)(8676002)(4326008)(8936002)(36756003)(6486002)(508600001)(66556008)(66946007)(38100700002)(5660300002)(2906002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aFM1WDU4VXJLZmJwei9GWHBFeW1paVFTaFczZmE1UlN1bVlxN2NtTVdWUnRZ?=
 =?utf-8?B?cVJRV3dLbGV2VzlOVGlQUUxoQXF3Q1RLcVFQdmlYdW9IVUlKc3R4R1dCek1m?=
 =?utf-8?B?V01VQWg2NXpBZXpFWkVRVmVJeU5vTGJOeWZodnRKeE4vS1BaVVhUbnY3b0d4?=
 =?utf-8?B?U2Y4UlpYT0RBbERJbnJPYWx5OUZ3Z3JCMUhaNlFOYTEvWjlmWHdQU1RpeE9l?=
 =?utf-8?B?Wnl3VS96N084MFU4SFlxZXMvbEdCOEZRc0dFTHJEZms2V0g2NUhCOElQZ1RK?=
 =?utf-8?B?SldtcFJIZHpTR204Y2JnWFpUaHlpVEErSHNqWmRldUNvTDY1NFRlb2J3L3ht?=
 =?utf-8?B?M1VDU1I1b1VJQ3NNRkRPYWovcHRmQXFzRTU0L2QxK1hzZi9wYTliVEJjYnps?=
 =?utf-8?B?R0xpSDc5cVJKTUJwTVovOS9LSGdWb25jZ1BlS0ZXUm10eitNVFpUcDBkc0lz?=
 =?utf-8?B?bm5TczA5T0dlWkpsd0ppUXIrd1diL2hpRy9obC9COStsNko3Z2Z4TXFRbm1S?=
 =?utf-8?B?cXJlU1JHekh4cjFuVnNvS0ZwU0FjMlF5bDI2dllPNDRtd2FoTkNraitsRFpz?=
 =?utf-8?B?WGF2ZXYvWHovSElPeGtFcitFZUJtQXFDN3NyMUdIUmVjNGFSOTE0VGhXRi83?=
 =?utf-8?B?QklZTW12b3VpbGVzMHhTdEtvaUhySDZMUFhiU1lmVndyMUdPYjJodjJOTVJm?=
 =?utf-8?B?N2VhRkU4aXgvWXNjSEZJMUxRZlk0dUpVeUROZlJ2RE5RdzYwck1tK05LR2RS?=
 =?utf-8?B?NFhhUHJHdVhnS1hTZExsMldWV1FDYlZwdTNQZGFORjlyeGVBTURPVllnZm1C?=
 =?utf-8?B?azNBNnJKODVpeWZyTjlKbE4yb25zZmlmd2JtcmVtcWlid0oxdEhBdVdqU1h2?=
 =?utf-8?B?QVIxR2ZJUG9IRU55SHlTUE9xZlhTenBacVY0MGI0ZmszRHROVGF3ODh3SExC?=
 =?utf-8?B?cnRWbGxIVTg4TkhjdERNR29qSHNac1dEaC80RXVkdEJUY3dmQ1IxUk80MzFD?=
 =?utf-8?B?ZHFacnhQZngzc0dTbGpxUGVSK0V0VXA4K1laaStFKzVvcDB3RkhRSktGRlFM?=
 =?utf-8?B?VXhab0pvQ1E5dnRjOGI0bVpvaDV6NFNCeXJZcnROSlFHRytlSDJTK1I4MitK?=
 =?utf-8?B?cXdSTkw3TllaOTJRNEJJZk1RQ04vOVhHSEJvTjFlUWh0V3R2d2o3aDRVNGkw?=
 =?utf-8?B?MEJkM1JucU0wRy9IZTB6Njg4cHpYRkE4empLakM0TzdzeXVHM1pvSWxTeDJB?=
 =?utf-8?B?d2JrMDNKa0lHZUFSd3QzNW9QZTNIUWNLZ0VCYk5LTVBDNDRlSUR4OCs5QUFu?=
 =?utf-8?B?WFgrYXQraFlMb1NMdFhuRVB3ajIzVDlUendFaDA3TC9TTmJVSE12K0pDaTlo?=
 =?utf-8?B?Rlloc1V2K014ZVRoOVNMcHo3NnRqUDZmcDFTWW9IVkNiQ1lXRWt4MW9hSkxs?=
 =?utf-8?B?Vk04ckZrR2t4WldnSkFMVW1ZZVNYRjZ0ZEMwdVBZYzUyQVo0N3RzQys5M0ty?=
 =?utf-8?B?QlJrNks0R0ZDdjVqYjNuamlwOGVNZWlJV1l5ejJSWnVHTDJyelIyVGNGNEtV?=
 =?utf-8?B?WG9xdkNsUk16MVRuUzQxODJDZi9TSGpDbDFjSlZFNXRSdnEyZ1VJWWJuNjBl?=
 =?utf-8?B?cVU5K2FuR2dCU1FtOEMzRVhVUENmNmJsaWVraDdraVNpWCsvNzdjdHNlMzNw?=
 =?utf-8?B?cE9kM0w2bFdpUExvSkRIODI2SVdmemFBQzNxMEN3ZXRwZ3IwMkVDdmg0M3Br?=
 =?utf-8?B?OGFUVitsOXBuZGpzNVJIVUJCTXNSU2J3Nld3VDNOTndnL0svelJCVlYzRVlQ?=
 =?utf-8?B?alhmNFBjVGFnb2tzZkJSUERxZmxXMTYydVNXU3R1Y3crb3F5TEI0TjRkQ1FJ?=
 =?utf-8?B?K3BCL2JnOVBIQXByREo1MzFVbVUyWGhnZGRJcmNpTUxMa1RERmFlM2NHcS9N?=
 =?utf-8?B?cnEyRTRBWmY3Q2h0Vml1c01oY3RoQXhFYW0zSDBVSW9kYVgxUFpweFk1dHdm?=
 =?utf-8?B?QTVLVHRqVTNRbVd6MEZ3ZDhsVFNVeDdzV3J1ZXRaWHlLbU11ald3Ulk2Y0NK?=
 =?utf-8?B?dkg0YUVnLzNrVld0SzlBNk5TbWxuMngrTGFFMFJpTmphaEk0U3dzeC81Ykpq?=
 =?utf-8?B?TGI3SmdsUkdwb0tzeHN5SDNTVmhRUk9YeGViZVpJL0QrQ09MS1B1V3pHQXIy?=
 =?utf-8?B?ekVKdXU0UzhYNHNkOGNUazdaN1licy9TeTN5UDNIOEhNUEE4RHRlbW1sVmNM?=
 =?utf-8?B?cDI5a3R4L3FjVy9nYythblpOZGtxZWozR0FqY0luKy9tWXEwYktsRGdTVTNH?=
 =?utf-8?B?TmtIbEZ6dzZNYUFRVS80NHdkOFZkc0lra2dFcEI0OGJGSzJER3BxZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60aeb074-888a-46c6-3fe5-08da192fa457
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 07:16:03.9559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FAEZ4lo3siy2TgrfbgK3mDz2rMBOZ2ZRt5qMWUqmHeSsUYQQwoYGO+INixZ1kRFbZVjT9Y9jGurQxUDNUIK4Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8187

See the code comment. The higher the rate of vCPU-s migrating across
pCPU-s, the less useful this attempted optimization actually is. With
credit2 the migration rate looks to be unduly high even on mostly idle
systems, and hence on large systems lock contention here isn't very
difficult to observe.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
     unsigned int port;
     struct evtchn *chn;
 
+    /*
+     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
+     * vCPU-s they're to be delivered to run on. In order to limit lock
+     * contention, check for an empty list prior to acquiring the lock. In the
+     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
+     * until the vCPU is migrated (again) to another pCPU.
+     */
+    if ( !v->pirq_evtchn_head )
+        return;
+
     spin_lock(&d->event_lock);
     for ( port = v->pirq_evtchn_head; port; port = chn->u.pirq.next_port )
     {



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 07:59:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 07:59:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301165.513936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncjWJ-0000y9-H9; Fri, 08 Apr 2022 07:59:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301165.513936; Fri, 08 Apr 2022 07:59:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncjWJ-0000y2-EG; Fri, 08 Apr 2022 07:59:03 +0000
Received: by outflank-mailman (input) for mailman id 301165;
 Fri, 08 Apr 2022 07:59:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncjWH-0000xs-TH; Fri, 08 Apr 2022 07:59:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncjWH-0004sG-Qb; Fri, 08 Apr 2022 07:59:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncjWH-0006ST-A5; Fri, 08 Apr 2022 07:59:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncjWH-00079Z-9e; Fri, 08 Apr 2022 07:59:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WwL9LZwmfz7JAqaqUeeO0UIWkIoh4JIL0hFbYx8X2xk=; b=v6aIqsm1ppHTPaGwLD/rBBfvoK
	oDm8ZBVxbGF/u7SvSEhfeqgwzfuFBAiS8LEpTdiUvIpFfGOZ161Rne+9Sb9WFHrcDC74UwfJGKXWH
	HSgveQ52020viDoTuCn/WvEWSPzBW9Eklgh4W3wgZ5oDSTbTTmstRsPK7/rMqTYB/fDQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169227-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169227: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 07:59:01 +0000

flight 169227 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169227/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   38 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  288 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:10:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:10:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301185.513947 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncjh1-00040a-0H; Fri, 08 Apr 2022 08:10:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301185.513947; Fri, 08 Apr 2022 08:10:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncjh0-00040T-TQ; Fri, 08 Apr 2022 08:10:06 +0000
Received: by outflank-mailman (input) for mailman id 301185;
 Fri, 08 Apr 2022 08:10:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncjgy-0003F8-Sm
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:10:05 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 494caacc-b713-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 10:10:02 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 494caacc-b713-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649405402;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=kvBj1g8m5kMmsSZu8y2sqkdO47uMzmblBm3IIeFZhG8=;
  b=hoIFyuIUALhX1YKVV1MhOLY2eUpfNWZTAvOAhWkJ1dwX4fqlbMQxcGyO
   2YBpzZ+hxNCT/FdJfI9yAEk6HUpcEdCGcNRh7DvoGMklnAMrzMfodx6fC
   etU0eXT4LaOsYC6gO7hlYsYBHWdbj6+Yc6yQ12UlKZs6cU5e1+5C6N/cC
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67762387
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UjaubKBCvof9JBVW/8fjw5YqxClBgxIJ4kV8jS/XYbTApG4q02FUm
 mJNXWqBa6yKYTP2e4t1PITg9RxTu5eGyNU2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jh0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhRi
 /ZojraiCj50O6LXwf8gAgllSh1XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGg2hu3JseQp4yY
 eI2bwNsVzb+cSRzGW8SI5MXzPyV3kXGJmgwRFW9+vNsvjm7IBZK+KP2LNPfd9iORMNUtkWVv
 GTL+yL+GB5yHMOb4SqI9DSrnOCntS/1UY0dFbq899ZxnUaegGcUDXU+V0a/oPS/ol6zXZRYM
 UN80igkoLU29UerZsLgRBD+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/
 liShM/kHiAqubGQSHS15rqStSm1OyUeMSkFfyBscOcey4C9+sdp1EuJF4s9Vv7u5jHoJd3u6
 xDJjw0FradQtJMO2L7i5m2Wkw/1mrGcG2bZ+T7rdm6i6wp4YqusaIqp9UXX4J58EWqJcrWSl
 CNawpbDtYjiGbnIzXXQG7tVQNlF8t7faFXhbUhT847NHthH01qqZshu7T53Py+F2e5UKGayM
 Cc/Ve68jaK/3UdGj4cqO+pd6OxwlMAM8OgJsNiOM7KihbArKWe6ENlGPxL44owUuBFEfVsDE
 Zmaa92wKn0RFL5qyjG7L89Ej+N6nHBjmDOMGsmip/hC7VZ4TCTIIVviGAHQBt3VEYve+FmFm
 zqhH5XiJ+pjvB3WPXCMrN97waEiJnknH5Hmw/G7hcbYSjeK7FoJUqeLqZt4ItQNt/0Myo/go
 yHsMmcFmQGXrSCWdm23hoVLNeqHsWBX9ilgY0TB/D+AhhAeXGpYxPtHLMtoION/rYSOD5dcF
 pE4RilJOdwWIhzv8DUBd5jt6otkcRWgnwWVOCS5JjM4evZdq8bhoLcIoiOHGPEyMxeK
IronPort-HdrOrdr: A9a23:mS2Deai3jjhO5IodlR6WWBNHBHBQXzR13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkDNDSSNykKsS+Z2njBLz9I+rDum8rE9ISurUuFDzsaEJ2Ihz0JdDpzeXcGPTWua6BJc6
 Z1saF81kWdkDksH4yGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87heYAotd/lq
 H5259T5cJzp/8tHNJA7dg6MLmK40z2MGTx2TGpUB3a/J9uAQO5l3ew2sRw2N2X
X-IronPort-AV: E=Sophos;i="5.90,244,1643691600"; 
   d="scan'208";a="67762387"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cr417hGJu3KCSlW71NLzK5YDIufgtuihT5RAwj8SYfRQqDkyKLuUaenUgf3Mvz+kNxe4nVYRl4XoeG00wHAOURha2rvL84XEgEjxLPD0RzIQT7wkPjIvao4m9Zsde+/b80aNXtuL4lsXD/IaDsMlOsNerl5OFpQvZ7y9adz8wsYjCXCoOV/Aa65p2Jwwrbma9WDY7a1kC27q64gubiJ3waHqXgpOYriVBnFR8tL4rR28AXubbYynoAfECzlimi2Kwkva1gN7i2yxejTTMD5W780/AOGCWURVt7XSVIUpNYnd6YYArG5jPxFDMCkiBPh1c0TWWPe7ivem7/xV7qZijg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YhIcRCxA9o8VUGgY5jmlY4CTX4e20NJrMwY7FQoS2Gs=;
 b=VZJ2qHJ6hMfwJ1BQjIZ/POdOX98/4qLPX7pGf8XINPNRdDdggcoq/ndANEobSw2d7oJNXpYhM5P2ROsYXmfRhzFaBCRFXbv8Kjk79oeyI8I0B0bYdP2wNXOqOUSPELAM392H9uHmscBfKnF+wkH1tREOwq9wQBdJ89e6GyEB0LyJ6aBofXtooXTTSYXozbHbnyy8USJlwpYirR2X7lLPg2jcThE1vo9gvN/54zydZGWgIH93zdNakzJ/XWqywedf3xUng6qGFkKi3YNIytuydsoVSkilMzeUWEPixjVDUMc+bZeaL0OANber1P6wuVZagjZ81qhRz81U67sUBMEtzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YhIcRCxA9o8VUGgY5jmlY4CTX4e20NJrMwY7FQoS2Gs=;
 b=Mk9jkyxKY285+zW5C0jiBopBpDQGNDyM+piRglh7Go6NVmj++iY7wDbkSR3oQ46BzadnsBsTJjSvXsVQjjjgBn/0TPoxMh+dtC5vLJJeUA9X5OeYB+l46WH/xvnUQhLh8J7OBKpEeSaF/IkGhY+helC8M1VL0u/NSqIh/cWaxPA=
Date: Fri, 8 Apr 2022 10:09:50 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, osstest service owner
	<osstest-admin@xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Dario
 Faggioli" <dfaggioli@suse.com>
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Message-ID: <Yk/tzuKq4D3mFEQu@Air-de-Roger>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
X-ClientProxiedBy: LO4P265CA0042.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ac::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d0ecd681-c5e1-4ac8-eef3-08da19372ae0
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5600:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB56002B5C1C769BAD16C87F978FE99@SJ0PR03MB5600.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: dZdEOs5JdyumdFZfyK9cYRcvxMOTpI0dMKo73bz5i+Px56IfUrEDpJmJolK1bNAvMKSqyfip6tc1UG4dyh8ExSWErpZbgsNDmKtKlOCuYhIOBzes52L9q34RbZ8NfRW3KScSPSJsy867lnm3Y9cSWILHlB1+YcjqvRVIoz+D2PkMzhlsO3TXBk9zkzotzlgEI7aAAFWRnqskWuBYrPZIFYZxWMP0d3B/TlgSBUDIFHKwVH+tf2H3pRTi368OPpGvOtvj7SX82LpuJyjEap0a7L7m7UDvznLevVROFc4zOyNfu0pI4PtPMnY4Kh+5B8TFXKnlnK49JyB58P9aiBOYZkBIa/bxYTd4dtz0WmNcuxLPOGQb0qCGqIatJ4H1R7dihpOatXaSUQtRRVosan4H172kqBfKFVY0OoVxSFmy15HtH/uPQj7tFkedyCPy52BnIY06ygVinH+f9eDakg9VyuQ6Foq0tgrTxgrVXa6jPIUNyCa5dM7jwajYvhVeVIDD87OvrdfzhkqjpVyGEe7NbrKjkCXjXES3uF5MEfKXSDVl4ngc/MCsTkQaIQZu952CenzycpUZIAs9MxO5a7/8EOgupBKXHYZd9J/5xOTOJknG9AM9L3WzkXRo6E7BSio1+LNgvB+Pkvsz2DxvT9brKkksm0p9ZGA9zn2fj5IfFa7XrLj4CiJn1J4nPF/0f4l9G2mAit68X8pHxfjf6C/NDeLbxllh8sxCO8gCUYEeuu8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(82960400001)(53546011)(9686003)(6666004)(6506007)(6512007)(8676002)(86362001)(8936002)(2906002)(33716001)(85182001)(5660300002)(66556008)(66476007)(966005)(38100700002)(4326008)(66946007)(83380400001)(186003)(26005)(316002)(6916009)(508600001)(6486002)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHBZaW5zUUltRmhvallsbVZCN1F0QlZKd2ZMUjdzVk56dCtvK3I4amJWRkpO?=
 =?utf-8?B?b080MGZNS0MxblVZN2ROS05KcVRvWmE2OCtaRGk2Z000clZEbkJpbTk4R0Fl?=
 =?utf-8?B?dmZ2MXE5QTVIRVNaYjF1M3oxbHpoV05xY0ZHWGZ0RHdCZDNzemQ4YXF4ZWtk?=
 =?utf-8?B?Ymp1a0EvREFmYldHSXRxaWw2U25DSTBiTVRXNm9tSVZtdjZPMmMzOW5VNjcv?=
 =?utf-8?B?SElhK1d6UjM3cUtTdFVGbmoyKzRVcDUxaytWSndYbVR3cnlNWTcrSlRHdEhz?=
 =?utf-8?B?SnpUUDlqbFllaUh0Nm1FcGtISERObkJQWTNjODhtUWpob3RyOWhhL01rQ3NG?=
 =?utf-8?B?T2ppb0Q2c1JWcjlra1lUR0RnNDRLRk9SK0lTakhHNjFVOURrWTd5K3pYcEo5?=
 =?utf-8?B?OWtOUlZyR0dGT2R5VkZKRmV0Yjg5SzQxOWIrU0Q2NTRVYnNPeUJTN2lwREFq?=
 =?utf-8?B?R01uVmR5M1hlNnh2NGVxcGFPSkZIMGM0dVRab2hHYlhSYVVoU2NrMFFXRVBu?=
 =?utf-8?B?NmFjbnVFdkpwZjZPbXpPNlpNTzlORHNYLzBqZlo2TURxZ21QQTlYNHRVakd0?=
 =?utf-8?B?SUYzTlhmUjhUQUdhNnliMUF5U1lwSHhnREUvRFRRYlpuRmsxbWZ4TlBaeDdk?=
 =?utf-8?B?SWNJSzBIYzZsbkxqVzYycGo3TWk3RWVsTGREUUpSeUtxT3F3ZVIvTGVZR1F5?=
 =?utf-8?B?b0Zya0pxQS9RQ1lGeFQxR3EwbmtnblJRUEU2enR4OWtQUVNGdTRURWV0akJt?=
 =?utf-8?B?S2E4MUN4TUFsUkFkM2J1ejNxSHVtVmFTMVNWSmlpRnVPRnMrT2Z6U0I3Z0tj?=
 =?utf-8?B?eDNlNCtoY1drakxuMWg1YWhud2MrSm1adTczZVF2U1JOc2JSSWFueUphaWll?=
 =?utf-8?B?MnBlVzlxcVFWSExWZnI5YmF0NVhGa1VQRGhUQ0VuNWk3Q2xmVkw4aEpDZzJU?=
 =?utf-8?B?ZzJkT3ZqM0lNc0FYbXpVVElHVC9UVUc3c0RYZkluSldHeXdwSFNPUTliTFFp?=
 =?utf-8?B?c3RVUlBNZDhZV3JFSllsdDg5UnRJaGhaTE44bXFwYlorMUNqK0g5MFNPVmY5?=
 =?utf-8?B?V2I4ZkFrWUFpSURvWjU0RVU5RTFTSXc3YkZwQ0xqa3A3SW50NzVUZXkrYytG?=
 =?utf-8?B?Rk96aDNCNjZNVThCY05BeWdLM1RESUsrNUozaGRIM2tmUmdrcTcvVUtKVkVi?=
 =?utf-8?B?V3RKUmpSSExGRFpzRTZVdHRUVUxPREl4NG9leHJyaWxuTHFKOEs3cG1NTzhn?=
 =?utf-8?B?V2NuKzZPcWlSU0FDM3NQUjU2eTBQNEVIblFRNUZIcytiZU1YaG01OU03b3Y0?=
 =?utf-8?B?dnF0NERVQVZVQmpRdFBPSS9uLzY2clRYM0FGQW1mYnY0a2J5am01VE1FbElw?=
 =?utf-8?B?Q1huUDNvcVVmbG55TlJjNHprWVFvWFBDWDZPYUFYWSt0Q0xyWEI1aFVaVkdw?=
 =?utf-8?B?ZStURStSbkJxNDBNalgrNFZoMkluay9Uc294TjBZc240OTNlZ3dvNy9aU09h?=
 =?utf-8?B?SWhyNXh3YjZ3L1VXdGxhMkxmODM5R1NGOERUYzEvYW5DcmVSSE9TRHhIOEl5?=
 =?utf-8?B?cmRsanFwRnd3d0ZTMWZLTFhZdXplbWFpYmFFbUZnR3NKMnV1Vk9aOXBaYUNw?=
 =?utf-8?B?SFpOa0doZFo2R29wWWt5MVFBY1NnZUdPanQwK2NsRU1mZThsNWFrZzAyU1E4?=
 =?utf-8?B?TDF6RE0wSEJrb3J2NE9qM2xPd0tpMmFKcHljRk5HNFdDaW4yZ3dsNzR0d1Vm?=
 =?utf-8?B?bjdBdERMZDgvYWkxL1B3M2lMayt4RHdybGthaTNkMkpvNnlkTnhXRjg5a2Nh?=
 =?utf-8?B?UWhGMHArQmpvcHQrZHJHLytWeWNyYWttb1ZPZVhjUzVGRHZWMFpUK09xK2hV?=
 =?utf-8?B?SkhlVVBvNmZiMlRFcEhZa212QTJ1WWVja09ZdDB2S1dlYXR1OFhvQVh4aUFS?=
 =?utf-8?B?UUw1OWZIajdMaFUxY25mYXZoMlMreHpEVE1sYnF5bFcxcnRFekE5SVBkbEhx?=
 =?utf-8?B?L21tMUlNNXZUQ0Rqay96NC9vUW5SY0VSS1RUYmsvZVBRc1dLQUtqVWMrWWZE?=
 =?utf-8?B?VXFJbmdSTUFzcUY2YW1DVFhHZWZ3WWMzdFR1WUFEWVhSbFJ2TkV1NXhuRE5G?=
 =?utf-8?B?TkExKzBIZ3dES1JtNnMwSmJVa3c3NDRzUHM5RVpScEpJNFAvbUpJOVcrcWlR?=
 =?utf-8?B?NzJRaURMZ3ZmWDM2RDM3cDdnV00ramNnMEkxZ2lSTUMxNTFqUzB3RzZtWjFC?=
 =?utf-8?B?d3hBclBGcnZBcVZPSm5mQUhBNk5KL3lYZ3Y1V1hNWFBoeW9rVHIra09tRWRY?=
 =?utf-8?B?THMyRjlDZ3g5VDRhNjBsKzJqN1NGeVpYZGp4MXRKY3FsL01QQXNKMmQ2aTVs?=
 =?utf-8?Q?r7DfpicAA/EkN5o8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d0ecd681-c5e1-4ac8-eef3-08da19372ae0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 08:09:56.1500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jMLKqjriGKNbw6mdNMZCBlP8371+JYGioulzvvCHQdkcjGZELXteraZVQLGjmLUTmYI9Sr//HwSpQ05FjXu3Qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5600
X-OriginatorOrg: citrix.com

On Fri, Apr 08, 2022 at 09:01:11AM +0200, Jan Beulich wrote:
> On 07.04.2022 10:45, osstest service owner wrote:
> > flight 169199 xen-4.12-testing real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/169199/
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 168480
> 
> While the subsequent flight passed, I thought I'd still look into
> the logs here since the earlier flight had failed too. The state of
> the machine when the debug keys were issued is somewhat odd (and
> similar to the earlier failure's): 11 of the 56 CPUs try to
> acquire (apparently) Dom0's event lock, from evtchn_move_pirqs().
> All other CPUs are idle. The test failed because the sole guest
> didn't reboot in time. Whether the failure is actually connected to
> this apparent lock contention is unclear, though.
> 
> One can further see that really all about 70 ECS_PIRQ ports are
> bound to vCPU 0 (which makes me wonder about lack of balancing
> inside Dom0 itself, but that's unrelated). This means that all
> other vCPU-s have nothing at all to do in evtchn_move_pirqs().
> Since this moving of pIRQ-s is an optimization (the value of which
> has been put under question in the past, iirc), I wonder whether we
> shouldn't add a check to the function for the list being empty
> prior to actually acquiring the lock. I guess I'll make a patch and
> post it as RFC.

Seems good to me.

I think a better model would be to migrate the PIRQs when fired, or
even better when EOI is performed?  So that Xen doesn't pointlessly
migrate PIRQs for vCPUs that aren't running.

> And of course in a mostly idle system the other aspect here (again)
> is: Why are vCPU-s moved across pCPU-s in the first place? I've
> observed (and reported) such seemingly over-aggressive vCPU
> migration before, most recently in the context of putting together
> 'x86: make "dom0_nodes=" work with credit2'. Is there anything that
> can be done about this in credit2?
> 
> A final, osstest-related question is: Does it make sense to run Dom0
> on 56 vCPU-s, one each per pCPU? The bigger a system, the less
> useful it looks to me to actually also have a Dom0 as big, when the
> purpose of the system is to run guests, not meaningful other
> workloads in Dom0. While this is Xen's default (i.e. in the absence
> of command line options restricting Dom0), I don't think it's
> representing typical use of Xen in the field.

I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
uses 16 for example.

Albeit not having such parameter has likely led you into figuring out
this issue, so it might not be so bad.  I agree however it's likely
better to test scenarios closer to real world usage.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:20:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:20:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301192.513959 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncjql-0005kL-3D; Fri, 08 Apr 2022 08:20:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301192.513959; Fri, 08 Apr 2022 08:20:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncjqk-0005kE-WA; Fri, 08 Apr 2022 08:20:10 +0000
Received: by outflank-mailman (input) for mailman id 301192;
 Fri, 08 Apr 2022 08:20:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncjqj-0005k8-Lz
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:20:09 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1c21004-b714-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 10:20:08 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1c21004-b714-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649406008;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9wTCxEl06g2DDNH3Cv1wFYzDy1LQD+gqrfOekSzJHBw=;
  b=Vv+XNbkL5pwsqv85F6jEHwTEHeWSxBazUsYTK2AKpzUs3Fu9ZKImq3QM
   GHzIJOezPCmTU+LdqNZQOtbtKR7Ri6cQuJql5ghymsAS94lb/hWidrEPu
   tjF/rFkcJRfYc/cQ5qIpUWpDooYxfqWLRpOSKT9AU01+8SkjKiSMD9asW
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68238175
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fE9SSa0NwtThJRgIrPbD5e1xkn2cJEfYwER7XKvMYLTBsI5bpzxVn
 WMWWWmOPfnYMGv8Kth3YIq+oUJVsZDdzIJmTAJspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIw0YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0Vkd+PdVYIJ5Tjs8cWXBUBDTomBfNvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u1poVTa+BO
 qL1bxJGQzSYQjIUJWsVL58fl8yQmH7fMDRh/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 m7B8m70BjkTMdWNzjzD/n/EruzImznyVMQNFbm73vlwiVaXyyoYDxh+fVmxrOS9i0W+c8lCM
 EFS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxO4QfZmcfMpp87pZwHGF0k
 A/S9z/0OdBxmOWxCk2hp5aNlByZGiMaITYcfnc8EyJQtrEPv7oPph7IS99iFou8gdv0BSz8z
 li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp
 xDocODOvblVXflheMFgKdjh/Y1FBd7YaFUwYnY1RvHNEghBHVb5IOi8BxkkeS9U3j4sI2OBX
 aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CKyFNIoTP8guK1belM2LWaJ29zqw+KTLufthU
 ap3jO72VSpKYUiZ5GTeqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9eWGZimtsRtfveyC2Mq
 o43H5LTl313Db2vCgGKoNV7BQ1bchAG6WXe9pU/mhireVE9RgnMypb5nNscRmCSt/gNzbeXo
 yvlAye1CjPX3BX6FOlDUVg6AJvHVpdjt3MreysqOFejwX84ZoizqqwYcvMKkXMPrYSPEdYco
 yE5Rvi9
IronPort-HdrOrdr: A9a23:6Rts5qvpX/Ed7FCYBeOJYD8c7skClIMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzE4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 LxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72PeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl5Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbprmGuhHjHkV1RUsZyRtixZJGbEfqFCgL3Z79FupgE286NCr/Zv3Evp9/oGOu15Dq
 r/Q+FVfYp1P7wrhJJGdZc8qPSMex7wqDL3QRSvyAfcZeg600ykke+D3Fxy3pDvRKA1
X-IronPort-AV: E=Sophos;i="5.90,244,1643691600"; 
   d="scan'208";a="68238175"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YUyvVfViTzhwtQNH6pjHgWz5ayLnFJnCJCzkbTRtYUrfhbThjSdl7qEcvbyABN8EZW+dhpW45pKIRrGfdDQGun4e5/GyqME+BtxE4qICGAHM82ckHttzOzRDAcJbrXuTFToT2e+6pdj7ghA1gatAQHUFy4PT0OryrYVpn1JFTw20m0AIPKoyerp8K8VPyJmUOjU0qyAeqy8aoaa4rObbmBYoHm2BqrXyUaCmLt+tNeENH1HNpEqi3K0R2zjxRou/3YVkfuXtmz7bzpZz73dAhPgaiZ4c6w5GWniT+ouT6CF99l6QuuFXR2suULuZfWuU1+8Iq31szgg7XRs2XL8Mwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=smyQIvUoVkqdAKDiGKZM1MrDQ6rHXGCDw1hkHrsAksI=;
 b=PDyRN3o52JFpswG/WFYKBkKcM6iElx1uoGdbZnGqrkF3bGwdCXx/SloNQJH+cBy5cqlB2Ea/Cv3V1cL6mndwlGQ45jndJOqJ2EW/3QfhK6XYNxanSIpYQ0DkSqCzSpSc2hDMU57Mf3S3slOw+kBkreYs5IIFyANaXHq8iVZ5UjTvKBGaAx8Fm4GkavXtxcTqz2+jnCUMj2vIDFZ90jf9DCpo9F0T6BeMBW7UNW96eP2XWefN66e81moB2AglDTlaLV19avKUizwwk6C8Qa1R87px1pRyPYWlgkGAbYUk4lxvItlkUucXp08S0as2nOJvrHAWgeLTwI0u6F4X/DwxZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=smyQIvUoVkqdAKDiGKZM1MrDQ6rHXGCDw1hkHrsAksI=;
 b=LW7qevdPMT3RkeOn5tir9iWsSGc2lyaJPJnT0nuVErG5w9U0M3V9NGm0LD9NhMUmoJC+fWkxxpbnobnHcbw6MJOTZK5yVnhxb0+m5FHXMjxMnd3z+mPg8E/JlNchIlvZ7NWdVnI408bQ7VLIJkh5AMHvRTzZ0HnUm1do1x9U03U=
Date: Fri, 8 Apr 2022 10:19:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Konrad Wilk <konrad.wilk@oracle.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Bjoern
 Doebel <doebel@amazon.de>
Subject: Re: [PATCH v3] livepatch: account for patch offset when applying NOP
 patch
Message-ID: <Yk/wKp3XyAAPbqgc@Air-de-Roger>
References: <8db632ef-9d9c-d17a-54fd-49912d88d599@suse.com>
 <YkVko/vqhfAfS5Jb@Air-de-Roger>
 <ef884c3c-26b4-1bde-9344-aa9be30c1cbc@suse.com>
 <PH0PR03MB638290EA5503FE0FED792C44F0E69@PH0PR03MB6382.namprd03.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <PH0PR03MB638290EA5503FE0FED792C44F0E69@PH0PR03MB6382.namprd03.prod.outlook.com>
X-ClientProxiedBy: LO2P265CA0356.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:d::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6cea2644-9ec6-4143-88e6-08da1938929d
X-MS-TrafficTypeDiagnostic: MW4PR03MB6393:EE_
X-Microsoft-Antispam-PRVS: <MW4PR03MB639380ED7B8E54A592374ACF8FE99@MW4PR03MB6393.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Hg8c2JtmpdkzaFiFTpqx39xxwRxOPDC077vbXKhR0oVQIz50jWlYxD+i4xJN8HtNTq3m3fPUtXwNswHmxrCmYgXIH5RWaBATZUC4Ecn68o0eQ9NPU9HKnv0kb9eID+VkL5iVeBB4qVCV9OW96H3krCT34/qRhofU+1AcmMaIWp0NyTKLmxd2ZUMGlKqTPuu1VNczWruhD3DTaLIwVAKCTA07GADc518lnyo4u3LOMloR3LkXU24NYxnmInR65vjoEtrzvnIu5EZGVA1MflGosct/+ZoQRi/WrrJyvBWfI+toO9cQiOQ0nQG3+wbDXLhc5cnwVfszL5blji1oLqutuwApIF4xr2kiyNfRuNBDtwNECShTJLY36KYIVEqWdd6M1YALkWb7wYkILGlhx4Nc7K7UgdDH3W17qo1WUQ45tJfoNvsZkhsPxwrSbgErN9Fz0mPuo/k7R6U2AQFUCb+DUkzf9ngj1KV8pyCsV21e+4GTWqxe2uD0DMy74lnRuzuwWMZeP+38cqjGuQZhoHFOgOp7AdBJhAgK3uEus+t7tZtcDfkU0YiYasevOObQ1XtsLPpTJ/ecEIfSqiywPPAEolG1S6GOfF/mubq8VWYKn0kbonenK0U76Rr5po1jMxV4egWAEO3Rhcwa1vmOq4Lb4A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8936002)(186003)(26005)(83380400001)(4326008)(8676002)(33716001)(66556008)(66476007)(82960400001)(6486002)(86362001)(508600001)(9686003)(2906002)(6666004)(66946007)(15650500001)(6506007)(54906003)(6512007)(6862004)(53546011)(38100700002)(5660300002)(316002)(85182001)(6636002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDNiTFhRN1FweFdoK2pSRHJqaWpuS3lBaHRtR2VsVXZxL3laQUl4SkdDMEFQ?=
 =?utf-8?B?MGVqd1U3c09PcGdXbTRMZS84UUZ1alZvYjVTZlZhOVBIY1g4RnFrWWFKeDMx?=
 =?utf-8?B?YmFzditrVEhUT054WVU1SGNYd3BLL2JRTXB3L0ZIZUZmcnp1Ykg1RWN6Ylh3?=
 =?utf-8?B?b2VFQU44d2QxdDhWSGtMMVExZW5IVW5wREh0N1NzRGFIc2VDOTVDTjhNdlc5?=
 =?utf-8?B?SlkyQUM1b3p3Z2Z4Y1gyOFdaK1Jnc0U2UzBUTDh3SXArQkZwZFRQV1grZEhD?=
 =?utf-8?B?VlJFS2dhTjdQNGppaC9QOGlmbFc4bHpWMWxPV01melM4SjJuenU4ZFZ4SytC?=
 =?utf-8?B?VjM3RHJ0WDFSZlhEY2t6VkV2OHhzQUN2U3kxbDQ0ZkNNUWg0clhDT1JXVGtE?=
 =?utf-8?B?Y3luaG1EZmUzOVQ2azg3cHlFS0RwVTNIWlJEdDZRR0o5Zlk0T3dOV3ExRjFZ?=
 =?utf-8?B?RERISlZ0ZlV5RVMwd01paVBCSUZvV254MTNuM2liMnpSVVN5a3lvOHA3eml3?=
 =?utf-8?B?TTFUUzBRVXpoeVVLQ2M1andOdXgwL3VqbWxVVjJGNS9Ub0RjOExsMTE1MlJa?=
 =?utf-8?B?S08rSldRaW92SHVHbEM2VUtUWCt1NnczcDNsYUpneDJnaitrbmJlRkhMNk9U?=
 =?utf-8?B?ZmFPa0ZUenJpakVNQmNGdkwrZGR5RG9kZFV3dzdwTkR4K2ZOYjROWml0aU03?=
 =?utf-8?B?M1kzVHo4cnEwRnRIMFV4cnhUVkxUdVpCcVJmWEExbWkxZWlSTVdMbWNFeWhC?=
 =?utf-8?B?dUFYWmxwZHUvZGJlYjAxZjB0RHhUOVVSZHJzL2tJWUw5NHRicW5jQkdZcjhI?=
 =?utf-8?B?dE9vK0VYV1lmUVY3bysrODQyYzQ5M3ZQYWFQTml0ajhldCs3QVpxSFYyc0N5?=
 =?utf-8?B?WmphM2VnQkpQQ09CVE1FTnk5L3FFeVRhekdkeHcvT21pYUpqYWx3eVlwNDdQ?=
 =?utf-8?B?L0wwMUNYRTdzcXhKRVR0N1IvQjFTMHZzRHMxTnNocm4zTFQwbzhFWEpkZzJq?=
 =?utf-8?B?cWJRQllqaDU5WUtyMzNYamMvNlFWK3orRzIxendCQmxTQTJPallsWUR4NU5v?=
 =?utf-8?B?andmT1BJaFVqTlRaVjFCNzJFN2grMUpDMHBQWXp0Z1QrVVdCb29DVmRoMUUw?=
 =?utf-8?B?TWVKWDVzc2h0N2lzZVI2SVVMOXVuVGMvK2FJdnZPbFdEa3JGenVsME1JNTUw?=
 =?utf-8?B?MkJxd3EvSVQ1SndXdTdIcEZmNTdsN1ZmcFA0RHZLNVZPZFpLR0xIS2VOOUFK?=
 =?utf-8?B?djdyb2s1SWQyRGRDSXk4OHNnWDE1YktzcXZsRnJyMkFrV3VUbytVUjFtajBF?=
 =?utf-8?B?US9nWk5FVzE3cnhNTzI3NlM3U21vNkFGWGRtVG1XRncwTWJkR2dCREU0WVN4?=
 =?utf-8?B?dVBhei9oTHRrY09IaVBob3RLRmxiR1padnlhd2JQMEJOUmZpeUYzdmN5OEto?=
 =?utf-8?B?VE16SFkwTkFraytxRGtGdXd1b0ZDSnErQm10ZGxiUGwzZ28vNXFlbEhFdkp6?=
 =?utf-8?B?SkNMNGNpQmhSYTJIWjlvSDllOFhDQTFsT3oyMXZ3SnJLVnEwYkw5Y3BTcWZO?=
 =?utf-8?B?UlA2bjIzZXNhM2xobHdEKzhubXpjSjNXdVltK0NCVFprbVExbFp0Ky9IdUlu?=
 =?utf-8?B?aXlZc01pWWZiOUJJbDd6UmdrNTRlTEFlZ1lzcEticXp1bFdQUFNQdVJLNTBw?=
 =?utf-8?B?bElic29xVmNCVG95SXV5bGhCODdaVTNWVmFPSGhRemxFODlsY3dSRndOUFBY?=
 =?utf-8?B?bUVSZHhEZXRUS1YwRWljdXVWcCtUaC9zeXJqaFpzeEc1c0lKdktiZlZjeXpo?=
 =?utf-8?B?TnBrMUFHSXV2M3Y0czZ6Y0JueHdITWF0MVRHS1NYVW1oWlBrYlRkR2orNFpX?=
 =?utf-8?B?VjdrRFR6TkJFUTBBZVBlNmpHRVF1b2pCdGVXbSt3Rk1sWm5iS1QvYzduejQy?=
 =?utf-8?B?ZEZpZDZWQ3ZHUk1RSW9VVExXN1IvcEphYnQ3MEREOTVIMWJkSUgvT3JjK21C?=
 =?utf-8?B?elJtN2xqYXVXbTZnZnE4V1NkTUFkK1JxNVdoOGxyRFdXY0xabnBBYncvaTA4?=
 =?utf-8?B?ZC9BYTJ1VGVubGJqbnRMc3ZFQUZCa0ZkS3NNNXpBSkFsNjR4QUFHT0VYQWV3?=
 =?utf-8?B?ZmE2N3d3aUNFVThkSkliYkFkU3BuVDJtNGo1KzljaVNBSTFVTjhRMjN6a0VE?=
 =?utf-8?B?b0pway9rT3dhZjNqTjN5Q05KdDArTzBVZThQWk4xYlZTQWdKSHFGa1lzeTNr?=
 =?utf-8?B?Yy8vRnhrS1J1QW9HTzFyNTJCZnNhcGg3cVdvUmFPN3lQMWk3c1p1Sm92bUpN?=
 =?utf-8?B?dzVjUnRoRWVvZjd3ajQrMWhvZzdiYkNmazVGVlZUZTJBWndHVHF5c0VnNWZ5?=
 =?utf-8?Q?HyzHRrxcubPMi3bk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cea2644-9ec6-4143-88e6-08da1938929d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 08:19:59.6882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2zlNFt3UR4jVx0VLNmwDb6uXB0lHr71tm+p2mAiMchQjYHH0dYsoksXnNaZzSqQQuhc6C1TaC4SABG7xLo9Xnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6393
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 03:44:16PM +0000, Ross Lagerwall wrote:
> > From: Jan Beulich <jbeulich@suse.com>
> > Sent: Thursday, March 31, 2022 9:42 AM
> > To: Roger Pau Monne <roger.pau@citrix.com>
> > Cc: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>; Ross Lagerwall <ross.lagerwall@citrix.com>; Konrad Wilk <konrad.wilk@oracle.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>; Bjoern Doebel <doebel@amazon.de>
> > Subject: Re: [PATCH v3] livepatch: account for patch offset when applying NOP patch 
> >  
> > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
> > 
> > On 31.03.2022 10:21, Roger Pau Monné wrote:
> > > On Thu, Mar 31, 2022 at 08:49:46AM +0200, Jan Beulich wrote:
> > >> While not triggered by the trivial xen_nop in-tree patch on
> > >> staging/master, that patch exposes a problem on the stable trees, where
> > >> all functions have ENDBR inserted. When NOP-ing out a range, we need to
> > >> account for this. Handle this right in livepatch_insn_len().
> > >>
> > >> This requires livepatch_insn_len() to be called _after_ ->patch_offset
> > >> was set.
> > >>
> > >> Fixes: 6974c75180f1 ("xen/x86: Livepatch: support patching CET-enhanced functions")
> > >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > > 
> > > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> > 
> > Thanks.
> > 
> > As a note to the livepatch maintainers: I'm going to put this in
> > without further waiting for suitable acks. Just in case I'll put
> > it on the 4.16 branch only for starters, to see that it actually
> > helps there (it's unusual to put something on the stable
> > branches before it having passed the push gate to master).
> 
> Thanks (was on PTO and away from email).
> 
> > 
> > > Albeit I don't think I understand how the in-place patching is done. I
> > > would expect the !func->new_addr branch of the if in
> > > arch_livepatch_apply to fill the insn buffer with the in-place
> > > replacement instructions, but I only see the buffer getting filled
> > > with nops. I'm likely missing something (not that this patch changes
> > > any of this).
> > 
> > Well, as per the v2 thread: There's no in-place patching except
> > to NOP out certain insns.
> 
> Correct. FWIW I'm not really aware of a valid use case for this
> 
> > 
> > > I'm also having trouble figuring out how we assert that the len value
> > > (which is derived from new_size if !new_addr) is not greater than
> > > LIVEPATCH_OPAQUE_SIZE, which is the limit of the insn buffer. Maybe
> > > that's already checked elsewhere.
> > 
> > That's what my 3rd post-commit-message remark was (partly) about.
> 
> old_size specifies the length of the existing function to be patched.
> 
> If new_addr is zero (NOP case), then new_size specifies the number of
> bytes to overwrite with NOP. That's why new_size is used as the memcpy
> length (minus patch offset).

Sorry, maybe a naive question, but why not use old_size directly to
overwrite with NOPs?

Is this because you could generate a patch that just removed code from
a function and then you would ideally just overwrite with NOPs the
section to be removed while leaving the rest of the function as-is (so
no jump added)?

I wonder whether we exercise this functionality at all, as I would
imagine is quite hard to come with such payload?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:45:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:45:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301202.513993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFJ-0000XR-OM; Fri, 08 Apr 2022 08:45:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301202.513993; Fri, 08 Apr 2022 08:45:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFJ-0000Wz-IA; Fri, 08 Apr 2022 08:45:33 +0000
Received: by outflank-mailman (input) for mailman id 301202;
 Fri, 08 Apr 2022 08:45:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nckFH-0000Ej-VL
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:45:31 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 3efbd494-b718-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 10:45:30 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2B4121655;
 Fri,  8 Apr 2022 01:45:30 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B55C13F73B;
 Fri,  8 Apr 2022 01:45:28 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3efbd494-b718-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 2/6] xen/sched: create public function for cpupools creation
Date: Fri,  8 Apr 2022 09:45:13 +0100
Message-Id: <20220408084517.33082-3-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220408084517.33082-1-luca.fancellu@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>

Create new public function to create cpupools, can take as parameter
the scheduler id or a negative value that means the default Xen
scheduler will be used.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v6:
- add R-by
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- Fixed comment (Andrew)
Changes in v2:
- cpupool_create_pool doesn't check anymore for pool id uniqueness
  before calling cpupool_create. Modified commit message accordingly
---
 xen/common/sched/cpupool.c | 15 +++++++++++++++
 xen/include/xen/sched.h    | 16 ++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index a6da4970506a..89a891af7076 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1219,6 +1219,21 @@ static void cpupool_hypfs_init(void)
 
 #endif /* CONFIG_HYPFS */
 
+struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id)
+{
+    struct cpupool *pool;
+
+    if ( sched_id < 0 )
+        sched_id = scheduler_get_default()->sched_id;
+
+    pool = cpupool_create(pool_id, sched_id);
+
+    BUG_ON(IS_ERR(pool));
+    cpupool_put(pool);
+
+    return pool;
+}
+
 static int __init cf_check cpupool_init(void)
 {
     unsigned int cpu;
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 406d9bc610a4..b07717987434 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1147,6 +1147,22 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c);
 int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op);
 unsigned int cpupool_get_id(const struct domain *d);
 const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool);
+
+/*
+ * cpupool_create_pool - Creates a cpupool
+ * @pool_id: id of the pool to be created
+ * @sched_id: id of the scheduler to be used for the pool
+ *
+ * Creates a cpupool with pool_id id.
+ * The sched_id parameter identifies the scheduler to be used, if it is
+ * negative, the default scheduler of Xen will be used.
+ *
+ * returns:
+ *     pointer to the struct cpupool just created, or Xen will panic in case of
+ *     error
+ */
+struct cpupool *cpupool_create_pool(unsigned int pool_id, int sched_id);
+
 extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:45:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:45:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301205.514027 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFN-0001Nw-Uc; Fri, 08 Apr 2022 08:45:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301205.514027; Fri, 08 Apr 2022 08:45:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFN-0001NB-Ow; Fri, 08 Apr 2022 08:45:37 +0000
Received: by outflank-mailman (input) for mailman id 301205;
 Fri, 08 Apr 2022 08:45:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nckFM-0000EZ-QL
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:45:36 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 41eadbc2-b718-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 10:45:35 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2203E11FB;
 Fri,  8 Apr 2022 01:45:35 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C717A3F73B;
 Fri,  8 Apr 2022 01:45:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41eadbc2-b718-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Date: Fri,  8 Apr 2022 09:45:16 +0100
Message-Id: <20220408084517.33082-6-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220408084517.33082-1-luca.fancellu@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>

Introduce domain-cpupool property of a xen,domain device tree node,
that specifies the cpupool device tree handle of a xen,cpupool node
that identifies a cpupool created at boot time where the guest will
be assigned on creation.

Add member to the xen_domctl_createdomain public interface so the
XEN_DOMCTL_INTERFACE_VERSION version is bumped.

Add public function to retrieve a pool id from the device tree
cpupool node.

Update documentation about the property.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes in v6:
- no changes
Changes in v5:
- no changes
Changes in v4:
- no changes
- add R-by
Changes in v3:
- Use explicitely sized integer for struct xen_domctl_createdomain
  cpupool_id member. (Stefano)
- Changed code due to previous commit code changes
Changes in v2:
- Moved cpupool_id from arch specific to common part (Juergen)
- Implemented functions to retrieve the cpupool id from the
  cpupool dtb node.
---
 docs/misc/arm/device-tree/booting.txt |  5 +++++
 xen/arch/arm/domain_build.c           | 14 +++++++++++++-
 xen/common/boot_cpupools.c            | 24 ++++++++++++++++++++++++
 xen/common/domain.c                   |  2 +-
 xen/include/public/domctl.h           |  4 +++-
 xen/include/xen/sched.h               |  9 +++++++++
 6 files changed, 55 insertions(+), 3 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index a94125394e35..7b4a29a2c293 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -188,6 +188,11 @@ with the following properties:
     An empty property to request the memory of the domain to be
     direct-map (guest physical address == physical address).
 
+- domain-cpupool
+
+    Optional. Handle to a xen,cpupool device tree node that identifies the
+    cpupool where the guest will be started at boot.
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8be01678de05..9c67a483d4a4 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3172,7 +3172,8 @@ static int __init construct_domU(struct domain *d,
 void __init create_domUs(void)
 {
     struct dt_device_node *node;
-    const struct dt_device_node *chosen = dt_find_node_by_path("/chosen");
+    const struct dt_device_node *cpupool_node,
+                                *chosen = dt_find_node_by_path("/chosen");
 
     BUG_ON(chosen == NULL);
     dt_for_each_child_node(chosen, node)
@@ -3241,6 +3242,17 @@ void __init create_domUs(void)
                                          vpl011_virq - 32 + 1);
         }
 
+        /* Get the optional property domain-cpupool */
+        cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0);
+        if ( cpupool_node )
+        {
+            int pool_id = btcpupools_get_domain_pool_id(cpupool_node);
+            if ( pool_id < 0 )
+                panic("Error getting cpupool id from domain-cpupool (%d)\n",
+                      pool_id);
+            d_cfg.cpupool_id = pool_id;
+        }
+
         /*
          * The variable max_init_domid is initialized with zero, so here it's
          * very important to use the pre-increment operator to call
diff --git a/xen/common/boot_cpupools.c b/xen/common/boot_cpupools.c
index 9429a5025fc4..240bae4cebb8 100644
--- a/xen/common/boot_cpupools.c
+++ b/xen/common/boot_cpupools.c
@@ -22,6 +22,8 @@ static unsigned int __initdata next_pool_id;
 
 #define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
 #define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
+#define BTCPUPOOLS_DT_WRONG_NODE      (-3)
+#define BTCPUPOOLS_DT_CORRUPTED_NODE  (-4)
 
 static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
 {
@@ -56,6 +58,28 @@ get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
     return cpu_num;
 }
 
+int __init btcpupools_get_domain_pool_id(const struct dt_device_node *node)
+{
+    const struct dt_device_node *phandle_node;
+    int cpu_num;
+
+    if ( !dt_device_is_compatible(node, "xen,cpupool") )
+        return BTCPUPOOLS_DT_WRONG_NODE;
+    /*
+     * Get first cpu listed in the cpupool, from its reg it's possible to
+     * retrieve the cpupool id.
+     */
+    phandle_node = dt_parse_phandle(node, "cpupool-cpus", 0);
+    if ( !phandle_node )
+        return BTCPUPOOLS_DT_CORRUPTED_NODE;
+
+    cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
+    if ( cpu_num < 0 )
+        return cpu_num;
+
+    return pool_cpu_map[cpu_num];
+}
+
 static int __init check_and_get_sched_id(const char* scheduler_name)
 {
     int sched_id = sched_get_id_by_name(scheduler_name);
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 351029f8b239..0827400f4f49 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -698,7 +698,7 @@ struct domain *domain_create(domid_t domid,
         if ( !d->pbuf )
             goto fail;
 
-        if ( (err = sched_init_domain(d, 0)) != 0 )
+        if ( (err = sched_init_domain(d, config->cpupool_id)) != 0 )
             goto fail;
 
         if ( (err = late_hwdom_init(d)) != 0 )
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0aa..2f4cf56f438d 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
@@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
     /* Per-vCPU buffer size in bytes.  0 to disable. */
     uint32_t vmtrace_size;
 
+    uint32_t cpupool_id;
+
     struct xen_arch_domainconfig arch;
 };
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 453e98f1cba8..b62315ad5e5d 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1182,6 +1182,7 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 void btcpupools_allocate_pools(void);
 unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
 void btcpupools_dtb_parse(void);
+int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
 
 #else /* !CONFIG_BOOT_TIME_CPUPOOLS */
 static inline void btcpupools_allocate_pools(void) {}
@@ -1190,6 +1191,14 @@ static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
 {
     return 0;
 }
+#ifdef CONFIG_HAS_DEVICE_TREE
+static inline int
+btcpupools_get_domain_pool_id(const struct dt_device_node *node)
+{
+    return 0;
+}
+#endif
+
 #endif
 
 #endif /* __SCHED_H__ */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:45:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:45:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301201.513989 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFJ-0000Us-Ci; Fri, 08 Apr 2022 08:45:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301201.513989; Fri, 08 Apr 2022 08:45:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFJ-0000Ul-9Q; Fri, 08 Apr 2022 08:45:33 +0000
Received: by outflank-mailman (input) for mailman id 301201;
 Fri, 08 Apr 2022 08:45:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nckFH-0000EZ-99
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:45:31 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 3d68c4df-b718-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 10:45:28 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6859511FB;
 Fri,  8 Apr 2022 01:45:27 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B6E4B3F73B;
 Fri,  8 Apr 2022 01:45:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d68c4df-b718-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v6 0/6] Boot time cpupools
Date: Fri,  8 Apr 2022 09:45:11 +0100
Message-Id: <20220408084517.33082-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

This serie introduces a feature for Xen to create cpu pools at boot time, the
feature is enabled using a configurable that is disabled by default.
The boot time cpupool feature relies on the device tree to describe the cpu
pools.
Another feature is introduced by the serie, the possibility to assign a
dom0less guest to a cpupool at boot time.

Here follows an example, Xen is built with CONFIG_BOOT_TIME_CPUPOOLS=y.

>From the DT:

  [...]

  a72_0: cpu@0 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x0>;
    device_type = "cpu";
    [...]
  };

  a72_1: cpu@1 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x1>;
    device_type = "cpu";
    [...]
  };

  a53_0: cpu@100 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x100>;
    device_type = "cpu";
    [...]
  };

  a53_1: cpu@101 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x101>;
    device_type = "cpu";
    [...]
  };

  a53_2: cpu@102 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x102>;
    device_type = "cpu";
    [...]
  };

  a53_3: cpu@103 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x103>;
    device_type = "cpu";
    [...]
  };

  chosen {
    #size-cells = <0x1>;
    #address-cells = <0x1>;
    xen,dom0-bootargs = "...";
    xen,xen-bootargs = "...";

    cpupool0 {
      compatible = "xen,cpupool";
      cpupool-cpus = <&a72_0 &a72_1>;
      cpupool-sched = "credit2";
    };

    cp1: cpupool1 {
      compatible = "xen,cpupool";
      cpupool-cpus = <&a53_0 &a53_1 &a53_2 &a53_3>;
    };

    module@0 {
      reg = <0x80080000 0x1300000>;
      compatible = "multiboot,module";
    };

    domU1 {
      #size-cells = <0x1>;
      #address-cells = <0x1>;
      compatible = "xen,domain";
      cpus = <1>;
      memory = <0 0xC0000>;
      vpl011;
      domain-cpupool = <&cp1>;

      module@92000000 {
        compatible = "multiboot,kernel", "multiboot,module";
        reg = <0x92000000 0x1ffffff>;
        bootargs = "...";
      };
    };
  };

  [...]

The example DT is instructing Xen to have two cpu pools, the one with id 0
having two phisical cpus and the one with id 1 having 4 phisical cpu, the
second cpu pool uses the null scheduler and from the /chosen node we can see
that a dom0less guest will be started on that cpu pool.

In this particular case Xen must boot with different type of cpus, so the
boot argument hmp_unsafe must be enabled.

Luca Fancellu (6):
  tools/cpupools: Give a name to unnamed cpupools
  xen/sched: create public function for cpupools creation
  xen/sched: retrieve scheduler id by name
  xen/cpupool: Create different cpupools at boot time
  arm/dom0less: assign dom0less guests to cpupools
  xen/cpupool: Allow cpupool0 to use different scheduler

 docs/misc/arm/device-tree/booting.txt  |   5 +
 docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++
 tools/helpers/xen-init-dom0.c          |  37 +++-
 tools/libs/light/libxl_utils.c         |   3 +-
 xen/arch/arm/domain_build.c            |  14 +-
 xen/arch/arm/include/asm/smp.h         |   3 +
 xen/common/Kconfig                     |   7 +
 xen/common/Makefile                    |   1 +
 xen/common/boot_cpupools.c             | 234 +++++++++++++++++++++++++
 xen/common/domain.c                    |   2 +-
 xen/common/sched/core.c                |  40 +++--
 xen/common/sched/cpupool.c             |  35 +++-
 xen/include/public/domctl.h            |   4 +-
 xen/include/xen/sched.h                |  53 ++++++
 14 files changed, 550 insertions(+), 28 deletions(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/common/boot_cpupools.c

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:45:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:45:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301203.514011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFL-000113-3q; Fri, 08 Apr 2022 08:45:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301203.514011; Fri, 08 Apr 2022 08:45:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFL-00010l-0V; Fri, 08 Apr 2022 08:45:35 +0000
Received: by outflank-mailman (input) for mailman id 301203;
 Fri, 08 Apr 2022 08:45:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nckFJ-0000Ej-Bw
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:45:33 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 3fea7354-b718-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 10:45:32 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF42C139F;
 Fri,  8 Apr 2022 01:45:31 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6035F3F73B;
 Fri,  8 Apr 2022 01:45:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fea7354-b718-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 3/6] xen/sched: retrieve scheduler id by name
Date: Fri,  8 Apr 2022 09:45:14 +0100
Message-Id: <20220408084517.33082-4-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220408084517.33082-1-luca.fancellu@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>

Add a static function to retrieve the scheduler pointer using the
scheduler name.

Add a public function to retrieve the scheduler id by the scheduler
name that makes use of the new static function.

Take the occasion to replace open coded scheduler search with the
new static function in scheduler_init.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v6:
- no changes
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- add R-by
Changes in v2:
- replace open coded scheduler search in scheduler_init (Juergen)
---
 xen/common/sched/core.c | 40 ++++++++++++++++++++++++++--------------
 xen/include/xen/sched.h | 11 +++++++++++
 2 files changed, 37 insertions(+), 14 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab67818106..48ee01420fb8 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2947,10 +2947,30 @@ void scheduler_enable(void)
     scheduler_active = true;
 }
 
+static inline
+const struct scheduler *__init sched_get_by_name(const char *sched_name)
+{
+    unsigned int i;
+
+    for ( i = 0; i < NUM_SCHEDULERS; i++ )
+        if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) )
+            return schedulers[i];
+
+    return NULL;
+}
+
+int __init sched_get_id_by_name(const char *sched_name)
+{
+    const struct scheduler *scheduler = sched_get_by_name(sched_name);
+
+    return scheduler ? scheduler->sched_id : -1;
+}
+
 /* Initialise the data structures. */
 void __init scheduler_init(void)
 {
     struct domain *idle_domain;
+    const struct scheduler *scheduler;
     int i;
 
     scheduler_enable();
@@ -2981,25 +3001,17 @@ void __init scheduler_init(void)
                    schedulers[i]->opt_name);
             schedulers[i] = NULL;
         }
-
-        if ( schedulers[i] && !ops.name &&
-             !strcmp(schedulers[i]->opt_name, opt_sched) )
-            ops = *schedulers[i];
     }
 
-    if ( !ops.name )
+    scheduler = sched_get_by_name(opt_sched);
+    if ( !scheduler )
     {
         printk("Could not find scheduler: %s\n", opt_sched);
-        for ( i = 0; i < NUM_SCHEDULERS; i++ )
-            if ( schedulers[i] &&
-                 !strcmp(schedulers[i]->opt_name, CONFIG_SCHED_DEFAULT) )
-            {
-                ops = *schedulers[i];
-                break;
-            }
-        BUG_ON(!ops.name);
-        printk("Using '%s' (%s)\n", ops.name, ops.opt_name);
+        scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT);
+        BUG_ON(!scheduler);
+        printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name);
     }
+    ops = *scheduler;
 
     if ( cpu_schedule_up(0) )
         BUG();
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index b07717987434..b527f141a1d3 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -758,6 +758,17 @@ void sched_destroy_domain(struct domain *d);
 long sched_adjust(struct domain *, struct xen_domctl_scheduler_op *);
 long sched_adjust_global(struct xen_sysctl_scheduler_op *);
 int  sched_id(void);
+
+/*
+ * sched_get_id_by_name - retrieves a scheduler id given a scheduler name
+ * @sched_name: scheduler name as a string
+ *
+ * returns:
+ *     positive value being the scheduler id, on success
+ *     negative value if the scheduler name is not found.
+ */
+int sched_get_id_by_name(const char *sched_name);
+
 void vcpu_wake(struct vcpu *v);
 long vcpu_yield(void);
 void vcpu_sleep_nosync(struct vcpu *v);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:45:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:45:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301204.514022 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFN-0001KJ-Ea; Fri, 08 Apr 2022 08:45:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301204.514022; Fri, 08 Apr 2022 08:45:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFN-0001K6-Aq; Fri, 08 Apr 2022 08:45:37 +0000
Received: by outflank-mailman (input) for mailman id 301204;
 Fri, 08 Apr 2022 08:45:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nckFL-0000Ej-Qo
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:45:36 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 41078176-b718-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 10:45:34 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91AF71650;
 Fri,  8 Apr 2022 01:45:33 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E56693F73B;
 Fri,  8 Apr 2022 01:45:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41078176-b718-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time
Date: Fri,  8 Apr 2022 09:45:15 +0100
Message-Id: <20220408084517.33082-5-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220408084517.33082-1-luca.fancellu@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>

Introduce a way to create different cpupools at boot time, this is
particularly useful on ARM big.LITTLE system where there might be the
need to have different cpupools for each type of core, but also
systems using NUMA can have different cpu pools for each node.

The feature on arm relies on a specification of the cpupools from the
device tree to build pools and assign cpus to them.

ACPI is not supported for this feature.

Documentation is created to explain the feature.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v6:
- Changed docs, return if booted with ACPI in btcpupools_dtb_parse,
  panic if /chosen does not exists. Changed commit message (Julien)
- Add Juergen R-by for the xen/common/sched part that didn't change
Changes in v5:
- Fixed wrong variable name, swapped schedulers, add scheduler info
  in the printk (Stefano)
- introduce assert in cpupool_init and btcpupools_get_cpupool_id to
  harden the code
Changes in v4:
- modify Makefile to put in *.init.o, fixed stubs and macro (Jan)
- fixed docs, fix brakets (Stefano)
- keep cpu0 in Pool-0 (Julien)
- moved printk from btcpupools_allocate_pools to
  btcpupools_get_cpupool_id
- Add to docs constraint about cpu0 and Pool-0
Changes in v3:
- Add newline to cpupools.txt and removed "default n" from Kconfig (Jan)
- Fixed comment, moved defines, used global cpu_online_map, use
  HAS_DEVICE_TREE instead of ARM and place arch specific code in header
  (Juergen)
- Fix brakets, x86 code only panic, get rid of scheduler dt node, don't
  save pool pointer and look for it from the pool list (Stefano)
- Changed data structures to allow modification to the code.
Changes in v2:
- Move feature to common code (Juergen)
- Try to decouple dtb parse and cpupool creation to allow
  more way to specify cpupools (for example command line)
- Created standalone dt node for the scheduler so it can
  be used in future work to set scheduler specific
  parameters
- Use only auto generated ids for cpupools
---
 docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
 xen/arch/arm/include/asm/smp.h         |   3 +
 xen/common/Kconfig                     |   7 +
 xen/common/Makefile                    |   1 +
 xen/common/boot_cpupools.c             | 207 +++++++++++++++++++++++++
 xen/common/sched/cpupool.c             |  12 +-
 xen/include/xen/sched.h                |  14 ++
 7 files changed, 383 insertions(+), 1 deletion(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/common/boot_cpupools.c

diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
new file mode 100644
index 000000000000..40cc8135c66f
--- /dev/null
+++ b/docs/misc/arm/device-tree/cpupools.txt
@@ -0,0 +1,140 @@
+Boot time cpupools
+==================
+
+When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
+create cpupools during boot phase by specifying them in the device tree.
+ACPI is not supported for this feature.
+
+Cpupools specification nodes shall be direct childs of /chosen node.
+Each cpupool node contains the following properties:
+
+- compatible (mandatory)
+
+    Must always include the compatiblity string: "xen,cpupool".
+
+- cpupool-cpus (mandatory)
+
+    Must be a list of device tree phandle to nodes describing cpus (e.g. having
+    device_type = "cpu"), it can't be empty.
+
+- cpupool-sched (optional)
+
+    Must be a string having the name of a Xen scheduler. Check the sched=<...>
+    boot argument for allowed values [1]. When this property is omitted, the Xen
+    default scheduler will be used.
+
+
+Constraints
+===========
+
+If no cpupools are specified, all cpus will be assigned to one cpupool
+implicitly created (Pool-0).
+
+If cpupools node are specified, but not every cpu brought up by Xen is assigned,
+all the not assigned cpu will be assigned to an additional cpupool.
+
+If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
+stop.
+
+The boot cpu must be assigned to Pool-0, so the cpupool containing that core
+will become Pool-0 automatically.
+
+
+Examples
+========
+
+A system having two types of core, the following device tree specification will
+instruct Xen to have two cpupools:
+
+- The cpupool with id 0 will have 4 cpus assigned.
+- The cpupool with id 1 will have 2 cpus assigned.
+
+The following example can work only if hmp-unsafe=1 is passed to Xen boot
+arguments, otherwise not all cores will be brought up by Xen and the cpupool
+creation process will stop Xen.
+
+
+a72_1: cpu@0 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x0>;
+        device_type = "cpu";
+        [...]
+};
+
+a72_2: cpu@1 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x1>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_1: cpu@100 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x100>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_2: cpu@101 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x101>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_3: cpu@102 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x102>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_4: cpu@103 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x103>;
+        device_type = "cpu";
+        [...]
+};
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a53_1 &a53_2 &a53_3 &a53_4>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "credit2";
+    };
+
+    [...]
+
+};
+
+
+A system having the cpupools specification below will instruct Xen to have three
+cpupools:
+
+- The cpupool Pool-0 will have 2 cpus assigned.
+- The cpupool Pool-1 will have 2 cpus assigned.
+- The cpupool Pool-2 will have 2 cpus assigned (created by Xen with all the not
+  assigned cpus a53_3 and a53_4).
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a53_1 &a53_2>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "null";
+    };
+
+    [...]
+
+};
+
+[1] docs/misc/xen-command-line.pandoc
diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h
index af5a2fe65266..83c0cd69767b 100644
--- a/xen/arch/arm/include/asm/smp.h
+++ b/xen/arch/arm/include/asm/smp.h
@@ -34,6 +34,9 @@ extern void init_secondary(void);
 extern void smp_init_cpus(void);
 extern void smp_clear_cpu_maps (void);
 extern int smp_get_max_cpus (void);
+
+#define cpu_physical_id(cpu) cpu_logical_map(cpu)
+
 #endif
 
 /*
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index d921c74d615e..70aac5220e75 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -22,6 +22,13 @@ config GRANT_TABLE
 
 	  If unsure, say Y.
 
+config BOOT_TIME_CPUPOOLS
+	bool "Create cpupools at boot time"
+	depends on HAS_DEVICE_TREE
+	help
+	  Creates cpupools during boot time and assigns cpus to them. Cpupools
+	  options can be specified in the device tree.
+
 config ALTERNATIVE_CALL
 	bool
 
diff --git a/xen/common/Makefile b/xen/common/Makefile
index b1e076c30b81..218174ca8b6b 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -1,5 +1,6 @@
 obj-$(CONFIG_ARGO) += argo.o
 obj-y += bitmap.o
+obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot_cpupools.init.o
 obj-$(CONFIG_HYPFS_CONFIG) += config_data.o
 obj-$(CONFIG_CORE_PARKING) += core_parking.o
 obj-y += cpu.o
diff --git a/xen/common/boot_cpupools.c b/xen/common/boot_cpupools.c
new file mode 100644
index 000000000000..9429a5025fc4
--- /dev/null
+++ b/xen/common/boot_cpupools.c
@@ -0,0 +1,207 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * xen/common/boot_cpupools.c
+ *
+ * Code to create cpupools at boot time.
+ *
+ * Copyright (C) 2022 Arm Ltd.
+ */
+
+#include <xen/sched.h>
+#include <asm/acpi.h>
+
+/*
+ * pool_cpu_map:   Index is logical cpu number, content is cpupool id, (-1) for
+ *                 unassigned.
+ * pool_sched_map: Index is cpupool id, content is scheduler id, (-1) for
+ *                 unassigned.
+ */
+static int __initdata pool_cpu_map[NR_CPUS]   = { [0 ... NR_CPUS-1] = -1 };
+static int __initdata pool_sched_map[NR_CPUS] = { [0 ... NR_CPUS-1] = -1 };
+static unsigned int __initdata next_pool_id;
+
+#define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
+#define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
+
+static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
+{
+    unsigned int i;
+
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpu_physical_id(i) == hwid )
+            return i;
+    }
+
+    return -1;
+}
+
+static int __init
+get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
+{
+    int cpu_num;
+    const __be32 *prop;
+    unsigned int cpu_reg;
+
+    prop = dt_get_property(cpu_node, "reg", NULL);
+    if ( !prop )
+        return BTCPUPOOLS_DT_NODE_NO_REG;
+
+    cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node));
+
+    cpu_num = get_logical_cpu_from_hw_id(cpu_reg);
+    if ( cpu_num < 0 )
+        return BTCPUPOOLS_DT_NODE_NO_LOG_CPU;
+
+    return cpu_num;
+}
+
+static int __init check_and_get_sched_id(const char* scheduler_name)
+{
+    int sched_id = sched_get_id_by_name(scheduler_name);
+
+    if ( sched_id < 0 )
+        panic("Scheduler %s does not exists!\n", scheduler_name);
+
+    return sched_id;
+}
+
+void __init btcpupools_dtb_parse(void)
+{
+    const struct dt_device_node *chosen, *node;
+
+    if ( !acpi_disabled )
+        return;
+
+    chosen = dt_find_node_by_path("/chosen");
+    if ( !chosen )
+        panic("/chosen missing. Boot time cpupools can't be parsed from DT.\n");
+
+    dt_for_each_child_node(chosen, node)
+    {
+        const struct dt_device_node *phandle_node;
+        int sched_id = -1;
+        const char* scheduler_name;
+        unsigned int i = 0;
+
+        if ( !dt_device_is_compatible(node, "xen,cpupool") )
+            continue;
+
+        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) )
+            sched_id = check_and_get_sched_id(scheduler_name);
+
+        phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
+        if ( !phandle_node )
+            panic("Missing or empty cpupool-cpus property!\n");
+
+        while ( phandle_node )
+        {
+            int cpu_num;
+
+            cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
+
+            if ( cpu_num < 0 )
+                panic("Error retrieving logical cpu from node %s (%d)\n",
+                      dt_node_name(node), cpu_num);
+
+            if ( pool_cpu_map[cpu_num] != -1 )
+                panic("Logical cpu %d already added to a cpupool!\n", cpu_num);
+
+            pool_cpu_map[cpu_num] = next_pool_id;
+
+            phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
+        }
+
+        /* Save scheduler choice for this cpupool id */
+        pool_sched_map[next_pool_id] = sched_id;
+
+        /* Let Xen generate pool ids */
+        next_pool_id++;
+    }
+}
+
+void __init btcpupools_allocate_pools(void)
+{
+    unsigned int i;
+    bool add_extra_cpupool = false;
+    int swap_id = -1;
+
+    /*
+     * If there are no cpupools, the value of next_pool_id is zero, so the code
+     * below will assign every cpu to cpupool0 as the default behavior.
+     * When there are cpupools, the code below is assigning all the not
+     * assigned cpu to a new pool (next_pool_id value is the last id + 1).
+     * In the same loop we check if there is any assigned cpu that is not
+     * online.
+     */
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpumask_test_cpu(i, &cpu_online_map) )
+        {
+            /* Unassigned cpu gets next_pool_id pool id value */
+            if ( pool_cpu_map[i] < 0 )
+            {
+                pool_cpu_map[i] = next_pool_id;
+                add_extra_cpupool = true;
+            }
+
+            /*
+             * Cpu0 must be in cpupool0, otherwise some operations like moving
+             * cpus between cpupools, cpu hotplug, destroying cpupools, shutdown
+             * of the host, might not work in a sane way.
+             */
+            if ( !i && (pool_cpu_map[0] != 0) )
+                swap_id = pool_cpu_map[0];
+
+            if ( swap_id != -1 )
+            {
+                if ( pool_cpu_map[i] == swap_id )
+                    pool_cpu_map[i] = 0;
+                else if ( pool_cpu_map[i] == 0 )
+                    pool_cpu_map[i] = swap_id;
+            }
+        }
+        else
+        {
+            if ( pool_cpu_map[i] >= 0 )
+                panic("Pool-%d contains cpu%u that is not online!\n",
+                      pool_cpu_map[i], i);
+        }
+    }
+
+    /* A swap happened, swap schedulers between cpupool id 0 and the other */
+    if ( swap_id != -1 )
+    {
+        int swap_sched = pool_sched_map[swap_id];
+
+        pool_sched_map[swap_id] = pool_sched_map[0];
+        pool_sched_map[0] = swap_sched;
+    }
+
+    if ( add_extra_cpupool )
+        next_pool_id++;
+
+    /* Create cpupools with selected schedulers */
+    for ( i = 0; i < next_pool_id; i++ )
+        cpupool_create_pool(i, pool_sched_map[i]);
+}
+
+unsigned int __init btcpupools_get_cpupool_id(unsigned int cpu)
+{
+    ASSERT((cpu < NR_CPUS) && (pool_cpu_map[cpu] >= 0));
+
+    printk(XENLOG_INFO "Logical CPU %u in Pool-%d (Scheduler id: %d).\n",
+           cpu, pool_cpu_map[cpu], pool_sched_map[pool_cpu_map[cpu]]);
+
+    return pool_cpu_map[cpu];
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 89a891af7076..86a175f99cd5 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1247,12 +1247,22 @@ static int __init cf_check cpupool_init(void)
     cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
+    btcpupools_dtb_parse();
+
+    btcpupools_allocate_pools();
+
     spin_lock(&cpupool_lock);
 
     cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
 
     for_each_cpu ( cpu, &cpupool_free_cpus )
-        cpupool_assign_cpu_locked(cpupool0, cpu);
+    {
+        unsigned int pool_id = btcpupools_get_cpupool_id(cpu);
+        struct cpupool *pool = cpupool_find_by_id(pool_id);
+
+        ASSERT(pool);
+        cpupool_assign_cpu_locked(pool, cpu);
+    }
 
     spin_unlock(&cpupool_lock);
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index b527f141a1d3..453e98f1cba8 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1178,6 +1178,20 @@ extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 
+#ifdef CONFIG_BOOT_TIME_CPUPOOLS
+void btcpupools_allocate_pools(void);
+unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
+void btcpupools_dtb_parse(void);
+
+#else /* !CONFIG_BOOT_TIME_CPUPOOLS */
+static inline void btcpupools_allocate_pools(void) {}
+static inline void btcpupools_dtb_parse(void) {}
+static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
+{
+    return 0;
+}
+#endif
+
 #endif /* __SCHED_H__ */
 
 /*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:45:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:45:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301200.513979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFI-0000Ey-8V; Fri, 08 Apr 2022 08:45:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301200.513979; Fri, 08 Apr 2022 08:45:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFI-0000Ep-1d; Fri, 08 Apr 2022 08:45:32 +0000
Received: by outflank-mailman (input) for mailman id 301200;
 Fri, 08 Apr 2022 08:45:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nckFG-0000EZ-GZ
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:45:30 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 3e0ac67a-b718-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 10:45:29 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F7AE139F;
 Fri,  8 Apr 2022 01:45:28 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9BC6A3F73B;
 Fri,  8 Apr 2022 01:45:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e0ac67a-b718-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v6 1/6] tools/cpupools: Give a name to unnamed cpupools
Date: Fri,  8 Apr 2022 09:45:12 +0100
Message-Id: <20220408084517.33082-2-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220408084517.33082-1-luca.fancellu@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>

With the introduction of boot time cpupools, Xen can create many
different cpupools at boot time other than cpupool with id 0.

Since these newly created cpupools can't have an
entry in Xenstore, create the entry using xen-init-dom0
helper with the usual convention: Pool-<cpupool id>.

Given the change, remove the check for poolid == 0 from
libxl_cpupoolid_to_name(...).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Changes in v6:
- Reworked loop to have only one error path (Anthony)
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- no changes, add R-by
Changes in v2:
 - Remove unused variable, moved xc_cpupool_infofree
   ahead to simplify the code, use asprintf (Juergen)
---
 tools/helpers/xen-init-dom0.c  | 37 +++++++++++++++++++++++++++++++++-
 tools/libs/light/libxl_utils.c |  3 +--
 2 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
index c99224a4b607..37eff8868f25 100644
--- a/tools/helpers/xen-init-dom0.c
+++ b/tools/helpers/xen-init-dom0.c
@@ -43,7 +43,10 @@ int main(int argc, char **argv)
     int rc;
     struct xs_handle *xsh = NULL;
     xc_interface *xch = NULL;
-    char *domname_string = NULL, *domid_string = NULL;
+    char *domname_string = NULL, *domid_string = NULL,
+         *pool_path = NULL, *pool_name = NULL;
+    xc_cpupoolinfo_t *xcinfo;
+    unsigned int pool_id = 0;
     libxl_uuid uuid;
 
     /* Accept 0 or 1 argument */
@@ -114,9 +117,41 @@ int main(int argc, char **argv)
         goto out;
     }
 
+    /* Create an entry in xenstore for each cpupool on the system */
+    do {
+        xcinfo = xc_cpupool_getinfo(xch, pool_id);
+        if (xcinfo != NULL) {
+            if (xcinfo->cpupool_id != pool_id)
+                pool_id = xcinfo->cpupool_id;
+            xc_cpupool_infofree(xch, xcinfo);
+            if (asprintf(&pool_path, "/local/pool/%d/name", pool_id) <= 0) {
+                fprintf(stderr, "cannot allocate memory for pool path\n");
+                rc = 1;
+                goto out;
+            }
+            if (asprintf(&pool_name, "Pool-%d", pool_id) <= 0) {
+                fprintf(stderr, "cannot allocate memory for pool name\n");
+                rc = 1;
+                goto out;
+            }
+            pool_id++;
+            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
+                          strlen(pool_name))) {
+                fprintf(stderr, "cannot set pool name\n");
+                rc = 1;
+                goto out;
+            }
+            free(pool_name);
+            free(pool_path);
+            pool_path = pool_name = NULL;
+        }
+    } while(xcinfo != NULL);
+
     printf("Done setting up Dom0\n");
 
 out:
+    free(pool_path);
+    free(pool_name);
     free(domid_string);
     free(domname_string);
     xs_close(xsh);
diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c
index b91c2cafa223..81780da3ff40 100644
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -151,8 +151,7 @@ char *libxl_cpupoolid_to_name(libxl_ctx *ctx, uint32_t poolid)
 
     snprintf(path, sizeof(path), "/local/pool/%d/name", poolid);
     s = xs_read(ctx->xsh, XBT_NULL, path, &len);
-    if (!s && (poolid == 0))
-        return strdup("Pool-0");
+
     return s;
 }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:45:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:45:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301206.514044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFQ-0001x8-OV; Fri, 08 Apr 2022 08:45:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301206.514044; Fri, 08 Apr 2022 08:45:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckFQ-0001wn-IE; Fri, 08 Apr 2022 08:45:40 +0000
Received: by outflank-mailman (input) for mailman id 301206;
 Fri, 08 Apr 2022 08:45:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nckFO-0000Ej-IT
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:45:38 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 42f136f1-b718-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 10:45:37 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C17831650;
 Fri,  8 Apr 2022 01:45:36 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 582933F73B;
 Fri,  8 Apr 2022 01:45:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42f136f1-b718-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH v6 6/6] xen/cpupool: Allow cpupool0 to use different scheduler
Date: Fri,  8 Apr 2022 09:45:17 +0100
Message-Id: <20220408084517.33082-7-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220408084517.33082-1-luca.fancellu@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>

Currently cpupool0 can use only the default scheduler, and
cpupool_create has an hardcoded behavior when creating the pool 0
that doesn't allocate new memory for the scheduler, but uses the
default scheduler structure in memory.

With this commit it is possible to allocate a different scheduler for
the cpupool0 when using the boot time cpupool.
To achieve this the hardcoded behavior in cpupool_create is removed
and the cpupool0 creation is moved.

When compiling without boot time cpupools enabled, the current
behavior is maintained (except that cpupool0 scheduler memory will be
allocated).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v6:
- Add R-by
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- fix typo in commit message (Juergen)
- rebase changes
Changes in v2:
- new patch
---
 xen/common/boot_cpupools.c | 5 ++++-
 xen/common/sched/cpupool.c | 8 +-------
 xen/include/xen/sched.h    | 5 ++++-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/xen/common/boot_cpupools.c b/xen/common/boot_cpupools.c
index 240bae4cebb8..5955e6f9a98b 100644
--- a/xen/common/boot_cpupools.c
+++ b/xen/common/boot_cpupools.c
@@ -205,8 +205,11 @@ void __init btcpupools_allocate_pools(void)
     if ( add_extra_cpupool )
         next_pool_id++;
 
+    /* Keep track of cpupool id 0 with the global cpupool0 */
+    cpupool0 = cpupool_create_pool(0, pool_sched_map[0]);
+
     /* Create cpupools with selected schedulers */
-    for ( i = 0; i < next_pool_id; i++ )
+    for ( i = 1; i < next_pool_id; i++ )
         cpupool_create_pool(i, pool_sched_map[i]);
 }
 
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 86a175f99cd5..83112f5f04d3 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -312,10 +312,7 @@ static struct cpupool *cpupool_create(unsigned int poolid,
         c->cpupool_id = q->cpupool_id + 1;
     }
 
-    if ( poolid == 0 )
-        c->sched = scheduler_get_default();
-    else
-        c->sched = scheduler_alloc(sched_id);
+    c->sched = scheduler_alloc(sched_id);
     if ( IS_ERR(c->sched) )
     {
         ret = PTR_ERR(c->sched);
@@ -1242,9 +1239,6 @@ static int __init cf_check cpupool_init(void)
 
     cpupool_hypfs_init();
 
-    cpupool0 = cpupool_create(0, 0);
-    BUG_ON(IS_ERR(cpupool0));
-    cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
     btcpupools_dtb_parse();
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index b62315ad5e5d..e8f31758c058 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1185,7 +1185,10 @@ void btcpupools_dtb_parse(void);
 int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
 
 #else /* !CONFIG_BOOT_TIME_CPUPOOLS */
-static inline void btcpupools_allocate_pools(void) {}
+static inline void btcpupools_allocate_pools(void)
+{
+    cpupool0 = cpupool_create_pool(0, -1);
+}
 static inline void btcpupools_dtb_parse(void) {}
 static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
 {
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 08:56:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 08:56:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301241.514055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckPe-0005YO-QF; Fri, 08 Apr 2022 08:56:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301241.514055; Fri, 08 Apr 2022 08:56:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckPe-0005YH-M0; Fri, 08 Apr 2022 08:56:14 +0000
Received: by outflank-mailman (input) for mailman id 301241;
 Fri, 08 Apr 2022 08:56:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nckPe-0005YB-3n
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 08:56:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bd9ceba5-b719-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 10:56:12 +0200 (CEST)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-Y-IFFjv7OHKNO4HvPiNUJA-1; Fri, 08 Apr 2022 10:56:11 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AM6PR04MB6215.eurprd04.prod.outlook.com (2603:10a6:20b:b6::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 08:56:09 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 08:56:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd9ceba5-b719-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649408172;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pJ83ZyX3Wfmhr25pSB1NdJuYUOMwju4ixDsWs41q++0=;
	b=gd0RwU13uZzM1U4hi0IrFFX2zovrb5+LbVLGs0AXlBY53dGGa+LLErx0ctCRPote/29y3J
	D2jZLurPOhZsMRbf/mofCn/HTwG6WliyAYbqInTAdt7+iszJQkhrBxnDjqL2VTbxTsWO1n
	ojsMWAva2+waOnwK2le3iCkDw5a2BDw=
X-MC-Unique: Y-IFFjv7OHKNO4HvPiNUJA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LALNOTpLVcjh2JrS/KSmQ/wlwrfSN0ePZYvsOqbraZwCmYdM80GhqP8GG+wtpngJ/bmGuXzMpufsSRwjuI4ow1jC5XQttAqjhrFIDVysXAkGaoIrJmfeBoKqBMEEIceYCqK6FvAd82xITSmHcyaARqYw4QDtTpyyvXZQtIC1pHFjVn5fjViXkkIa+980R9IG9K3XBPQJqydj6WO+buQbDlWmfZF8H3d3G8pUWDAPRdfLbf4VZ/XmD0fWMCdKwOuE896TCGXaOhG6YtCRs5YAoePuFHby4fhgdunW+UiidwEyf8jQpT4yoGwBnGs2I3BJ7taYxeLBHgHlBTMehgIadA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DdlLG7gvpmaAmKuDr2i2R8fXtn802hh1Q5HlsBqTN+o=;
 b=JqDrPeb/6bMNrvhjuGaiMFq2mEHz8HuOy8imaFbYe7/eblXAZQLMcmzj5uSsC5GCydOe2mOdMWjYkc6BaUfSzUszIFOkKda3WQ+mVRIqBsx/XkvJHVTjNneJNI/5RyJUno/pveAb377MglMkwMv1C1SZpCXdu55QaaA65oKLdOkwWwC36vLKrNnjKXsIr5MwOlK37czafqsoXEnS6ne9egNycfp7jUplfgARWtfdxqKWlQYC/SmxHEmRNfQEn71T/smwMsKYLuJs7SoFmmGRWPR7yj2uXZJN2npkUJm0DVcMAF776dM23+GxU+wycM+DCcdxvLfENnUqiM8LoKHN9g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <93f86ba7-79f5-614d-3cae-a265f3de9b86@suse.com>
Date: Fri, 8 Apr 2022 10:56:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>
CC: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Dario Faggioli <dfaggioli@suse.com>,
 xen-devel@lists.xenproject.org
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220408084517.33082-5-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0058.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::35) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a49631e8-50b0-4513-8d7c-08da193da014
X-MS-TrafficTypeDiagnostic: AM6PR04MB6215:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB62159C6A9073EED7E7F45C34B3E99@AM6PR04MB6215.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DPbbyBUjiH12T7pxlWiS/KThSgWXvqj313ja7sWiEaM/M51p0p6LKaxBWJLOq8lRCh/NE7h9qYlYw293pp+GjxkJiINQV/mgZvqBIqXpjhiowTbAsx1qJamzKngNJquLI/JrvnKpgeBoLhvKs2tllYEwvSMGzwgp6Mo8MRMMxdJXXZelUHlGNrJD3MddqDbCEKlOqnYI1Em+4pnxN6xPocSpq8jDd+tiC1QRpn41CA0/8vVzTgQHOK2yc+ScssbDzQJ6jkjBmXwAHh7OvJeGS+Jc0lZR1GSFuehjpRkVZPTvq3DL9/O/IIp8UYo0n9K6bPglUwVn3BDmW6UcYKVNBXw4ge8U1Uf+7LAtBsmNIfUegOZVMfztfSGOHLUfcc9Q98wMbJNPlNeVBnieS4Gi5xMYUAcr3dhBEgaoFwT+Zn1P7Q/5HKTqnOj9kkcMULXPKIxEgwBbYA5lxJLWUQ1mKSbYSXXngdngwkIXOyHBNyfoOHhljOteN5yoJDZchL2iWw66FyqzlusZOvy1JsxnPiE56AViJEnTkxMqRY2R4CKPR100ZaxL3CJivQ1WySoXMKoI594ojzoLFFQLm2bUgFwbdYDh+IPKO0j/y6YITy0Kf/KKAQ2FJu/E8DqxRdnclStqz+au1GG/mnrcFoeAqSwhcdwBMV2F+OwfEkqmosGi8AdvRfi6A2J7OyyoWaxLxAzcj4CHRfUE1sWrA9Xm+Zm5hWiJYsHyqQECj/G2WJwn/Z+CJ/XTpg3w5Q8suBfV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(53546011)(6506007)(66574015)(31686004)(8936002)(6916009)(6512007)(38100700002)(2616005)(31696002)(2906002)(26005)(186003)(7416002)(5660300002)(54906003)(316002)(4326008)(508600001)(66476007)(8676002)(66946007)(6486002)(66556008)(36756003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?dlMe5YEz7HYtWMweXRo+G56J2HhimC/gx6lFWu0yrch3AoOwUluvwkBBpasD?=
 =?us-ascii?Q?1RpVQbZg1HrUsOyjMooLjgrMFeMiovHtwoiiMa6mA1GghBAL4+n46rTgBQM8?=
 =?us-ascii?Q?Euoe+EU1iQDJMUFhVvwBV8r4BNJB158hg1qnkROzAhh2OboNcSU/rfQGWHG7?=
 =?us-ascii?Q?fyC3UFvEg7wlVc8lKdP2320nzPdwu1fdk5qmP5llvjjQ8jLCrWLOylL1iKQS?=
 =?us-ascii?Q?0BuU20f1QA9pR7rnEWB3+nR7wLeuUgE1v/DF2OlUqADH+KugIXuWHAA++ctZ?=
 =?us-ascii?Q?YvLobTtkK36+CS/tfScbnPmhlmI1KFDoK4yKJ5DYMhkYnHHDlxXGPR/jbsqX?=
 =?us-ascii?Q?j1BxpqxZnt8Vp4u3ZCEh3jEHjOgiIBgYir+NOwfDg7PqCsQFrZ40gxx87iqd?=
 =?us-ascii?Q?5QS4TXYwouAe5N9XZoETCmnybFTFZEjCPXPAm6xw55TOYgsMxP1gTVwgZmVJ?=
 =?us-ascii?Q?YGyHbDrxuHOmC51MYekihgLrn1GPuB094kQ6tsKu9L0DLCjfrokDO7y8BRp5?=
 =?us-ascii?Q?ZAVdCOEuon1MqPGnceFv6cNPSXahh+61p6rKIVPh4OIhzBUes319oT+tgHjM?=
 =?us-ascii?Q?IxTS8LwycEdPhBvcHn6wAd7pUbnuDmkcA9JDKNy1jNN0FlLBHbWL8bnJwhKi?=
 =?us-ascii?Q?B+0gqL0XfKvDQ9Z3ExEqWho0fEMX8EV2mFR3ZEUB22dopyTNdasluOPYG3ez?=
 =?us-ascii?Q?4f3YqCOcTfJ2qJCRCqSoFStnNXFve5MOFKVVGC0RoFALrREJpR2OTqmjlyM4?=
 =?us-ascii?Q?361GDromqfSn6gV7Ms7jxcTl+R0VoTVLEXgfuKdpGUWS4LaI33dVfZICicMu?=
 =?us-ascii?Q?BEk4jkF04w20/HkW2h7BP1yagsxFeOj+z5NPqpailnbRNjeNVGQY3RZg3AQb?=
 =?us-ascii?Q?q3UG5GJuXpFTDb19hvMWEUdEQz0XSP66XsEMuhuQgOuiZ6YEyCS22w7E4zRU?=
 =?us-ascii?Q?Pz04Lg/uzg9kj4AtrSDZ4qADdrYmF8nEKyGKq9vJ7IWzZcyUn4xL0C6BB3B2?=
 =?us-ascii?Q?52fhWTWSYVkH0PlwKXq141+tfxlX4W1AeDfwh9BHATutGvNmN31BIZCUdPVm?=
 =?us-ascii?Q?rj5X54okJ+1+DkHnIRPW2/soG9CBiPctW/ACdWw8cxHtgPSEy6l3vpi/Hdz5?=
 =?us-ascii?Q?779FIZIwmAMRYAscQPG6HeZo5qDuC9nl1wqjI+toJhJvzXihkO4Tg1GNYqY4?=
 =?us-ascii?Q?W4yL3D+6BO/Mkem4gTQ0k3VIYv/iLmZ49vmAJv+TDlD/2HqB1lUtLbXoPNGY?=
 =?us-ascii?Q?Z6las6/aLuE8KUvvLOeyJ2sWOqjCy54iN+SVLYU/pIAB0rl9ywDysgaTuxYD?=
 =?us-ascii?Q?lgD5rcGOOk/K7mq/5LRKuEj7Fv9/rE2D/1grFE1AqDFNN6BIPbzlcvHGnpyk?=
 =?us-ascii?Q?tAMTeu0VtjZq3EQ0NryKgfe2Z0XCpscXrvS/GYyejWhgu15yJtDuL6pdnmNB?=
 =?us-ascii?Q?9tPt5soqjiLQMAm/8pKa54P+I4IeY/YYgwqr81W1PkO0m9d21uTmaN/AcX4d?=
 =?us-ascii?Q?RofUuB/bnpRpqvWU3VzQg9/2lqEi8W7WUec7rUoxshzm1goQaBjQXHeXdRqh?=
 =?us-ascii?Q?NJ/eCgQhtDbtUWSeTy8QAr4BiU3qBED5QKrfokv2Xeu/aJgIGgnsycxrYQru?=
 =?us-ascii?Q?HnuBPxMOj1jCJMrkRuAKZh3c3PNs8RSpyjCAUDoxpLcvTwyL8JUeJYtIbccw?=
 =?us-ascii?Q?2i7PtTFpl822udN+mspypwFBdreZjNHBK0/rzBlKVOtXxbbgsp/8OUTYarKm?=
 =?us-ascii?Q?Z90HpTChOw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a49631e8-50b0-4513-8d7c-08da193da014
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 08:56:09.7309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gIPM2xTTcE21BAnVdhMwYUPpk0YHsWivmBr+9nLTN1RZkDKcvmJb5lHT4R6oSxZrmMqq+G3hAeEP6ZfEFOSEMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6215

On 08.04.2022 10:45, Luca Fancellu wrote:
> Introduce a way to create different cpupools at boot time, this is
> particularly useful on ARM big.LITTLE system where there might be the
> need to have different cpupools for each type of core, but also
> systems using NUMA can have different cpu pools for each node.
>=20
> The feature on arm relies on a specification of the cpupools from the
> device tree to build pools and assign cpus to them.
>=20
> ACPI is not supported for this feature.
>=20
> Documentation is created to explain the feature.
>=20
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>

This looks to be not in line with ...

> ---
> Changes in v6:
> - Changed docs, return if booted with ACPI in btcpupools_dtb_parse,
>   panic if /chosen does not exists. Changed commit message (Julien)
> - Add Juergen R-by for the xen/common/sched part that didn't change

... what you say here. What's the scope of J=C3=BCrgen's R-b? If it has
restricted scope, you need to retain that restriction for committers
to know.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 09:02:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 09:02:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301246.514066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckVM-0007Dn-Fy; Fri, 08 Apr 2022 09:02:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301246.514066; Fri, 08 Apr 2022 09:02:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckVM-0007Dg-Au; Fri, 08 Apr 2022 09:02:08 +0000
Received: by outflank-mailman (input) for mailman id 301246;
 Fri, 08 Apr 2022 09:02:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nckVL-0007Da-AF
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 09:02:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 904cae19-b71a-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 11:02:06 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2057.outbound.protection.outlook.com [104.47.8.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-KDQrQwzHP9CC9fudRQ8qOw-1; Fri, 08 Apr 2022 11:02:03 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AM0PR0402MB3843.eurprd04.prod.outlook.com (2603:10a6:208:12::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 09:01:48 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 09:01:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 904cae19-b71a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649408525;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2l5XVfc3HnYN8zk/7bqg4CjtKczWdpVE3hLQeczu80Q=;
	b=aHWaqS5jtBsEeBvTetIfzNygJxKc75n3nfJDHuxHFXaPRtJ3IbFzpUTdYU/OVrDxIQkL+j
	yrrjddVRbtlZFTGaHMqIQNsnZqMusyG2VmJOtLSlPWUa3mc+nqO+VEdM6EFsjr88VXL0jn
	a9BAo/irn5Arq4RytD5r0EoeOKtLCzI=
X-MC-Unique: KDQrQwzHP9CC9fudRQ8qOw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kUd+0J/HFdQRI2AGQ+s2o6fIerCPFwAVWHthepyg9s6FfBJz9mPIwRu/V1kGtgYe9QH7YZGP4vqkZwOTvNJW95nTrlEVluOAgzO44kdcHmV4abmEFlZfMABkkD3DZ273ULgbJClCdO6PjoVe5AFsymVMv7lD6z15ukne9XTKCozypn45yoeEwt8+6bBUg0iwxyTUtNXvIiSgk2e08KVo+r+irALJoSyIqo905NxtOQpg+TgCgluQbBV1OcE5QaXch/NLcle/7E8/caP7Pnl+/CKfRRKWPhF0/sVKXahYQqtWa7O2eEmZXbPySM43cHP4x4y0l/C4dFPgmfMxGQiP2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2l5XVfc3HnYN8zk/7bqg4CjtKczWdpVE3hLQeczu80Q=;
 b=fpOExsJSSI1nd3sMf1qsfxm/GIqskvsRSNcJCuBVgdhNeXs+0jjMeY/2KOHP87fWOok23npVPPBWq3bs7LOkNtnYrem0U60Lbd59vhu5MCskIZzemvLoSWRwvb6u+ZaXG8kyxEz7D+Odj6iLLMlkVMqBL7VFnt0yIGtH5G6gPGy/2iFPoMvyZ0otvoCqYoHm/RukkpEvGfYpumPWdJjb53kdx+pT4sszxlDCB7sq1PEXwMeLUnxClMR8UNFnAbhMcGWykNBNbKJE0nFhB2NqNikErdKvUpJR/MdaG0JCDTcy+PglSOvQyMsFybWZEQZXh4NBPYgobAn8rK0LfHSTXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
Date: Fri, 8 Apr 2022 11:01:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Dario Faggioli <dfaggioli@suse.com>,
 xen-devel@lists.xenproject.org
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220408084517.33082-5-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0024.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::23) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e413d31b-f42c-4ecc-86bd-08da193e6a03
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3843:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB38432B79045EA7788A511751B3E99@AM0PR0402MB3843.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3zAQgUvsl/d4woB/4S/WW1DvGcLKmegrKxR6j9F8eDbQIUI3ei+17fQ40zhjaE7u8aj11xzAZnTjtx4gQPvHEyHe+mZkSCk6odVzj+BqaXNCUiwWYiTpkXOBYaoUVz61bcJ3JWpXKFbHFLFdHTI5Xv6kJHMoMm1i4XTimWCuxk4URaNS5j6/JubyHbwr6AHIKkbpnABwQfDOd6EtXC2KFQ71m2qwZBMJNncooR9XDBEG4nFxQif5LBNYa8KZqrz8i8fn/aTw0TbQMIDaG6n6+YLAna9oEmhbZ9uJAEWkhDqBtfgx88yPPjk8s9G5I/c4FQf9jaCFlzO4EEmeEhdsj78/U5WsqNZq5jBsDeJb2tF1fR5RqhOs4cwBO3FiMozEtj+vwSzN0TFLgmFNVZNgDILv01Kkv9KCvXylJYk7nOChJ89rN4M5tT9aSZSKa+b3J/KD98lqhBpqUl4WTbfbuqyZhcznpqp8wV07TdeA8NCAm/z+yOTG+fFqBZrx2+7X7M1A6DJzVlzzrIyB0Tc4G1vDrg4Bofkh2DU0dtW/ycsccN12t80evHc4OZ2X2ILw1THPZpbypNiIvNhJXFJbPU6SXkULIgTqQ+F1R/PNU737PTSHDoUJH65L+xmc4GdY+TM06XU5LVZIBewoudJrvb4G19X8a0GrggvCsVwySKpk1ylGQR+7+/NYFAdMr0+HKyNgZJK7WvRUQR8DpLIWVD85R2qFluzM7L/eGQliv+g3uos+jQ6sWRRrCuPtw6BG
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(7416002)(83380400001)(31686004)(316002)(2906002)(66556008)(6512007)(36756003)(66476007)(8676002)(4326008)(38100700002)(66946007)(86362001)(6506007)(53546011)(5660300002)(2616005)(6916009)(54906003)(6486002)(508600001)(26005)(186003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YUsydU4yVVdrOGo4UGVMOVlnQmN3a00yUGdRTjhzYXdPOFduK1VRaHY3c1Z1?=
 =?utf-8?B?WGEvVWxrb054MWV5L3FlUG8xRjNaWHVXSU1NYWkxcGNTZ2tKSjg5Z0xPckJW?=
 =?utf-8?B?OXc1bktVZzVXSEpKNkw3OENLQS91RVB2U1VrcVlLb0tHWisxdGZYS3hsNUg4?=
 =?utf-8?B?SHhTWWRsNFUwTk5CYWQ5SUtwS3pzbHBmOXZCYnlDSXhHOGlVNk12OWJzMjRu?=
 =?utf-8?B?c2ZVRFdjVTRsY2JNUHJnMUZxdFl3Z0lhenVwNk9CN1VZazhzUEQxNzFFcXE3?=
 =?utf-8?B?RzZCTmcweVAra29OUE9ScU1nSExMVTc5OC81Q0FqUmJMZUdScXVWUjVrUnJO?=
 =?utf-8?B?N3Z1SXBRL0NuOEE3RGdmK09LbEw4T0RnWFpwRUJSZWVEUDQwUE4vVWh1Mnpo?=
 =?utf-8?B?WjhFQ2Q0dFduUWRnNjNsZXNEaytiekFXaXYrK3FFR3R0Rnc4Qzlkb1JEelB6?=
 =?utf-8?B?Rm5OaVgwQ3piQXhMd1YyaVEvTVZ6a1JFUjVnRkpxd0pDWi9nSlhiejNUMjcy?=
 =?utf-8?B?anFDb3hTUjdTWkppTUZYQ2ZRSzJCNU9hWmRaaDNKbW11V2ZUOGIwTzhlWUVl?=
 =?utf-8?B?QU8rM2hMaWJSY3JLSUIwT0NVMktQT0xjdHF5aWNJcE9vZjVFYk1sZFF5Zlpu?=
 =?utf-8?B?ZXpOUmdZMnhJU2IrWGh4Z3Zaa3QrRHlVekgzSmZ3VVljK3k3VXN1MzlYN1NM?=
 =?utf-8?B?SE5SOHVFUmZWNVR2QjhvUDhyYUJvZG1YZURUTVI3QTQ4UEpUb2ZLWUlaTGJH?=
 =?utf-8?B?dmdoQ1ArZFczeTJVSDVCYW1ZSUR0cTFlRnZFOFc5Z25WV0srMHE0NEIvWCt4?=
 =?utf-8?B?TTk3WmUxNVQwakljUkxRVmorTUtlMlVTaGs2VmYrVEVXQXNJNFpvcTNHdmpE?=
 =?utf-8?B?R1JsMWxJcS9rdDV0K0xGdGY3d3JjcWVPYUVTcnh3ZDZrQlhSbjcveTVCQisr?=
 =?utf-8?B?c2UrazAyM05OYVNTRjZoaXRKWDc3eVo2TEw0TmltaGp5VEhUeFZwUGRqUUpP?=
 =?utf-8?B?aHFHYmVtdUdEdzRTRHJVTkhFM1BxQUJ4UTNwL3p5QUNoQVlkZE5GNXJtUS82?=
 =?utf-8?B?VDFDN0NNZEQ3RE5ueDdPNThXY1g3UUV2c0puTjZqalBmZlZGeDE5ekZLVDE3?=
 =?utf-8?B?WFJVWVRUMTExdjJRdThpQjVBSTE5N3lQdVhQVCtHZGdjTDZZRm9ra2ZiOUxB?=
 =?utf-8?B?Mm9WNHdMWWdtTlIzQXZXZU9Ba0ZtT0crc21PQ1pKMlRGN0F4Yjl4UGxzb0FD?=
 =?utf-8?B?SkVtMWxmU3FPekM3NGYrTGxjUlIrbWFzZUJYdUtoRFJHVjdJZWdHM2h1Uklh?=
 =?utf-8?B?aEsxZTRLRlhhMzYzaVZ1U0R4V3R6cUZLQ2lNVWd6YTJjV2k1RFZwa1dFWUZp?=
 =?utf-8?B?RHlVNmlTN1hFZmNYWFl1SS9aUWtidms4NVpVTE95L2tuTlZaRzRkeUQ4d0xi?=
 =?utf-8?B?bEpNMXV4akNpQ1BpSldtVkJsYklRai9GMUIveUJmb0hiNnkzUFVpSHQzWElL?=
 =?utf-8?B?TkxYL1VHMVdXQWROR09PUHRzb01pNHNVQkZvMGRyYXpwMWRuOWtxR21sSDZX?=
 =?utf-8?B?ZXc1OG1FLzJBS3Vmbm14b3dESFdmcDhqV2M5OEs3K09NM1VXeC9KdDJZS3g1?=
 =?utf-8?B?b21jcU5ETWpXb0ZBbkNrek5VaENoWmczRFo0WThnTlNwM1kxY1Exekd2UFF3?=
 =?utf-8?B?SzYwMjRYMnpuM0M5Z3I4b0Y0SHE5ZXVjdkpTVUZEUSt6MlZWai9ub3hSODkw?=
 =?utf-8?B?czErdDRSOE9RbzZZSkVxdW5Sczg1UWRzamJQc1U0WnJudVp2cHBIMW05NmVk?=
 =?utf-8?B?QkUzcS9HY1pna0tTZzUwM09mWHkzV1VleGtpelBUQUkyWkl1M0FIbmVLZHZ2?=
 =?utf-8?B?aGI3VTY3anlncDhpY1dSZng4K3VYYVcyN0xFN2l3RXg3Nm9YUEtFM04vWkov?=
 =?utf-8?B?QVlXWlBkemZQaDhzeXMwbTB2dUk1YVZUM0ZnZzlKREpCcks1RkNzMUNaQm94?=
 =?utf-8?B?M0s5UjBhc3VqUXZjdjY2Yi9PWG40WFllOTJ2dzgzVWpIamVVMVRQWTk1YVZO?=
 =?utf-8?B?dyttNGY2K1hyNVQyMHN3aTlpdHkvM2hJNGhQT1JSNnZFNE05SGpMbEl4aEhU?=
 =?utf-8?B?STJDWGc0WjVRcERJUFZ2MUUxRTMxK0toSHh3NlRJaVFSYTRXSjJaelBOMVNv?=
 =?utf-8?B?elJBMDZXYmNaL1N2azZwRnU5L0tQQlQ5Ykt0WDNZMC9zT2lDcGprVHdGODc2?=
 =?utf-8?B?emlJZXA3N3hhTm9SZnZMYnpYWjIzRWVDMk9vUjcrR3NmQnpldm40bjNYZ3do?=
 =?utf-8?B?d3hpcm5Ec3pHazBKaFRkaDV0MFFDWlJJNTRSeWM4NEJ5MXZJQzN0UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e413d31b-f42c-4ecc-86bd-08da193e6a03
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 09:01:48.4566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E0y/SimX5E+fGKTYRFw8zA4VmeKWkLVGk2XdxNd16jf4Nx9cXqKPR39dlYTuWuu9Lm2dnXJkTyWxZr/wMiCncA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3843

On 08.04.2022 10:45, Luca Fancellu wrote:
> ---
>  docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>  xen/arch/arm/include/asm/smp.h         |   3 +
>  xen/common/Kconfig                     |   7 +
>  xen/common/Makefile                    |   1 +
>  xen/common/boot_cpupools.c             | 207 +++++++++++++++++++++++++
>  xen/common/sched/cpupool.c             |  12 +-
>  xen/include/xen/sched.h                |  14 ++
>  7 files changed, 383 insertions(+), 1 deletion(-)
>  create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>  create mode 100644 xen/common/boot_cpupools.c

Under whose maintainership is the new file to fall? Without an
addition to ./MAINTAINERS and without the file being placed in
xen/common/sched/, it'll be REST maintainers, which I think would
better be avoided. Would it perhaps make sense to have this as
xen/common/sched/boot.c, allowing other boot-only code to
potentially be moved there over time? This would then also avoid
me asking about the underscore in the file name: Underscores are
a somewhat artificial thing for use in places where dashes can't
be used. Yet in the file system dashes are fine, and dashes are
(slightly) easier to type.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 09:06:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 09:06:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301251.514077 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckZZ-0007sK-T8; Fri, 08 Apr 2022 09:06:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301251.514077; Fri, 08 Apr 2022 09:06:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckZZ-0007sD-Q3; Fri, 08 Apr 2022 09:06:29 +0000
Received: by outflank-mailman (input) for mailman id 301251;
 Fri, 08 Apr 2022 09:06:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nckZY-0007s7-Cm
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 09:06:28 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0610.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::610])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2b89a291-b71b-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 11:06:26 +0200 (CEST)
Received: from AS9PR0301CA0020.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::26) by DBAPR08MB5590.eurprd08.prod.outlook.com
 (2603:10a6:10:1aa::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.26; Fri, 8 Apr
 2022 09:06:24 +0000
Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:468:cafe::5) by AS9PR0301CA0020.outlook.office365.com
 (2603:10a6:20b:468::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.23 via Frontend
 Transport; Fri, 8 Apr 2022 09:06:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Fri, 8 Apr 2022 09:06:23 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Fri, 08 Apr 2022 09:06:23 +0000
Received: from 67aec624e431.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A86D292D-49F5-40AC-9D8E-D3CBCE1BC11F.1; 
 Fri, 08 Apr 2022 09:06:17 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 67aec624e431.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Apr 2022 09:06:17 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM6PR08MB4296.eurprd08.prod.outlook.com (2603:10a6:20b:b6::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 09:06:15 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.025; Fri, 8 Apr 2022
 09:06:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b89a291-b71b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HzI+bN9oppV40ggV3ApoXTUWt1JVb6XB+aCZy2YBP7k=;
 b=HgwoJyHzncEShA2kvCgGiUf54Y1dnHTrZgnbLGbe5fp2eFVvfpn8PbxRWGMO7nl/eaeoIZ9shLigFChgms2SyaKvNA6HYirRdqYx2cdtQJt0MhQN9HpIlWr+ax7uCBdMs5Whs4Gq2DRzRKrV7d2gJCagwseU/ytc6iynrrLtlPA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3bd59ca12cf876c6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M48TuKoFofsoc/vPdUCeIW+6RsHunDpeAl2r+vvZTwb986O9kfP/b3Arx5ZHDTdknFqs0b8NULdcNr7b6Tzp44sNhCQbpQEUyddkdPUejwje1Br+yjaaLZSpvKsit3867l8sX7MTd8nF8IfxWQX/I9PMXXk9CLXinO1yZC1lsrxTmf6/dubD4DaQ1ME+oY2ME36xrU917AAy8uXaYekoGbpQjo0Z776+qKfjCuos0ulOWVccJS0IVb0aHNXtQi6+ZM+78ldv/HozTTwQtOehI0eeNkoJewOR4u/Lhx81j0JEFyoh+4naKWnvG3s8ktQyrmcZyJo3HFpfxq1QYdeXog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HzI+bN9oppV40ggV3ApoXTUWt1JVb6XB+aCZy2YBP7k=;
 b=ks9ShoUsJr3JYbcRm5FM5kuA5sByTNE4X+JOHOJJLYaj3R2ddxAHALwAc1p0SsWn4y0ChjBqif/cSNyEfRGz7FDM6PiySya1Yim+HQ3E0W/txmeGzrdbOuJFiEALr8wL7MQ3TFa9MjvmXkTfdOGeJb9w7qXU1kM0uiQqU6tjlg0yyiNPnid2xzcK5fk38yc5TJAimSK69EE7/9vVg/VjW9cNYWa4Dp0Um095CXuvf6QWYe5tv6WayOD9WhIxbpsxsQcWagxsjcjEkz1UIwQK9dcb2NoYbk1Cdui/XsZ6UquHGdluiaJBRPy9dRX0M306Tm0GZC2b4IkI9v/h7r2WfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HzI+bN9oppV40ggV3ApoXTUWt1JVb6XB+aCZy2YBP7k=;
 b=HgwoJyHzncEShA2kvCgGiUf54Y1dnHTrZgnbLGbe5fp2eFVvfpn8PbxRWGMO7nl/eaeoIZ9shLigFChgms2SyaKvNA6HYirRdqYx2cdtQJt0MhQN9HpIlWr+ax7uCBdMs5Whs4Gq2DRzRKrV7d2gJCagwseU/ytc6iynrrLtlPA=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Wei
 Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, Dario Faggioli
	<dfaggioli@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Index: AQHYSyUg2T6WkJDiXECW3myZV3L//qzltq2AgAAC0gA=
Date: Fri, 8 Apr 2022 09:06:13 +0000
Message-ID: <863B8803-1535-4B81-BA4B-8B1A453AB063@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <93f86ba7-79f5-614d-3cae-a265f3de9b86@suse.com>
In-Reply-To: <93f86ba7-79f5-614d-3cae-a265f3de9b86@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: affe4e53-1083-4c77-dde8-08da193f0e52
x-ms-traffictypediagnostic:
	AM6PR08MB4296:EE_|AM5EUR03FT018:EE_|DBAPR08MB5590:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR08MB55900C5D401AC013F98B7121E4E99@DBAPR08MB5590.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Be9sbBwrkFWYxWMz7zv8LUeZhCnXxbCQJ/3lzaqF5WXnH2h4zWRpKjG4GLD5nx8TDlSj4So+WWSYkufg4lRIz8aGglMDFoaMTKQtRwOekKsEEU+Vq8o/scLokAdMptpSjYqNqEYIeZcxynyoxYYgmrjqBDOCXCyZAJgdwhrAvX0AEpQCvqYmR2tnQsaMxpWF4dZxlFlPDRM9dTVP5FL4wlYjQi6/wSlsh/VrMvnbznce7hiXXilc85L+KP/pYCO650PGYbokHaJw2kwh9jIwn1EoLhq7WUlLHH8F/GUTx1kJwTp/77vordJ2zSUBhpPn0CN6Fucgkd9qNqFVKziUZerXk17YE1vyGcczIyvLOdIa2zL+uNT10s+NJMCs7HaOQ7kzLhWmcnTrxs61EF6I030qO1gtYGnGOtVK+OFpwsyIKp+eSynCC32XiQBs1hs4EpgRbBK3DJZr9egr2CtT70/LnW5UqZgLOi/zYYP+6fgCIbPGvwx11plo9PAdo09AYs0FmhYP1YrxhJWMyl+cnGZqYsr0odHXBK210ajnPKS4euhKNJdwOHfjMmbTipIVawGGcfe4AJaJ6BHB6wA/DtN6WUGCC2Wz4fDhwGtS2E7k9Km8KgGI2koQRLV6PZ55ff+4g+DXeOe40/uq0PkLr4fv8IMQ9jriHhZxBWGiJC6W4N3WhDyUNf2xJf0J6GMG1INq0jFZSw5/7V5OA0/4g4koXx2OzmdQfuFtlj/WfJtNP0wzCqAPz+L8r4v5GDB4
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(66574015)(2616005)(33656002)(38070700005)(6916009)(83380400001)(54906003)(76116006)(66476007)(7416002)(86362001)(122000001)(71200400001)(508600001)(64756008)(53546011)(66556008)(66946007)(91956017)(4326008)(8676002)(66446008)(2906002)(186003)(5660300002)(6506007)(316002)(26005)(36756003)(6512007)(6486002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <4EEF63621E38C14085B99134567E69BE@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4296
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f829ced9-598e-4c77-f1f7-08da193f08bc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iyn3cOxtTAaq5hNsLS4pe2eoelaYIHmjp3unYkdSDchBpGKIicyoLy5OyRM1AgxvGJEzhJbC1sZhsaxIEQwUf1NqCqxTJMKMEDyGOr+Uf+mVyWn+5WePM5hySBas1C0ZijZMQKGolnUfKb47WNcIUPnRK8LXHjU3DSzIZosjkKVzBzJYQmQ4Xbz9QObL1MbNgAtW17X5R9EqgjrEa1Iq/893oN6yT/7+h+9yGxWlZaQZBjeiKZlwoYQFE3VJ+bPyWE+/VkNq23CwvbaYrZca94CFeqwR3+h9wSl/wxzNEy+ym3rXsWc9L3NJd3IytWWkJ7jueaUmDLo3nUVcJFz6TBo37VtvhjslXrbCq84Ej152xE+wkSA3uhryGtqi7qlvoeqaXeLbF22FKXb1Yr2JnDh1fa7tfcpyB3xpQvnhi/ZEKW0ZKohRQMUSTfrYBWBdSOkFRHTm4sUdMUFDTS3zT51rKnQ0RrtW2Yl/oBujXiQomqX5HZUS17W0W/pB76RKq3B8aIVhuPGspjSPoLkN2eN6IjmoAm8c/52nDy9dIizDaS2s4NhTsU73R01p6OYOBNTnrYXDxBxIcu2spocH+a5HaaiFZLCyecGpvUCGK4rdYn9E5uSGWKbEJnLMlihCMfXWr5NrtWmk+pvXyeOfYWqHGvcBtfcFg/Y4DmW2lkqn+edac/fnddET8ume9W+5
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(5660300002)(336012)(53546011)(316002)(54906003)(66574015)(2616005)(8676002)(6512007)(40460700003)(8936002)(6506007)(6486002)(83380400001)(26005)(82310400005)(186003)(47076005)(508600001)(2906002)(36860700001)(33656002)(86362001)(36756003)(81166007)(6862004)(70206006)(70586007)(356005)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 09:06:23.9667
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: affe4e53-1083-4c77-dde8-08da193f0e52
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5590

DQoNCj4gT24gOCBBcHIgMjAyMiwgYXQgMDk6NTYsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl
LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOC4wNC4yMDIyIDEwOjQ1LCBMdWNhIEZhbmNlbGx1IHdy
b3RlOg0KPj4gSW50cm9kdWNlIGEgd2F5IHRvIGNyZWF0ZSBkaWZmZXJlbnQgY3B1cG9vbHMgYXQg
Ym9vdCB0aW1lLCB0aGlzIGlzDQo+PiBwYXJ0aWN1bGFybHkgdXNlZnVsIG9uIEFSTSBiaWcuTElU
VExFIHN5c3RlbSB3aGVyZSB0aGVyZSBtaWdodCBiZSB0aGUNCj4+IG5lZWQgdG8gaGF2ZSBkaWZm
ZXJlbnQgY3B1cG9vbHMgZm9yIGVhY2ggdHlwZSBvZiBjb3JlLCBidXQgYWxzbw0KPj4gc3lzdGVt
cyB1c2luZyBOVU1BIGNhbiBoYXZlIGRpZmZlcmVudCBjcHUgcG9vbHMgZm9yIGVhY2ggbm9kZS4N
Cj4+IA0KPj4gVGhlIGZlYXR1cmUgb24gYXJtIHJlbGllcyBvbiBhIHNwZWNpZmljYXRpb24gb2Yg
dGhlIGNwdXBvb2xzIGZyb20gdGhlDQo+PiBkZXZpY2UgdHJlZSB0byBidWlsZCBwb29scyBhbmQg
YXNzaWduIGNwdXMgdG8gdGhlbS4NCj4+IA0KPj4gQUNQSSBpcyBub3Qgc3VwcG9ydGVkIGZvciB0
aGlzIGZlYXR1cmUuDQo+PiANCj4+IERvY3VtZW50YXRpb24gaXMgY3JlYXRlZCB0byBleHBsYWlu
IHRoZSBmZWF0dXJlLg0KPj4gDQo+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNh
LmZhbmNlbGx1QGFybS5jb20+DQo+PiBSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3Nz
QHN1c2UuY29tPg0KPiANCj4gVGhpcyBsb29rcyB0byBiZSBub3QgaW4gbGluZSB3aXRoIC4uLg0K
PiANCj4+IC0tLQ0KPj4gQ2hhbmdlcyBpbiB2NjoNCj4+IC0gQ2hhbmdlZCBkb2NzLCByZXR1cm4g
aWYgYm9vdGVkIHdpdGggQUNQSSBpbiBidGNwdXBvb2xzX2R0Yl9wYXJzZSwNCj4+IHBhbmljIGlm
IC9jaG9zZW4gZG9lcyBub3QgZXhpc3RzLiBDaGFuZ2VkIGNvbW1pdCBtZXNzYWdlIChKdWxpZW4p
DQo+PiAtIEFkZCBKdWVyZ2VuIFItYnkgZm9yIHRoZSB4ZW4vY29tbW9uL3NjaGVkIHBhcnQgdGhh
dCBkaWRuJ3QgY2hhbmdlDQo+IA0KPiAuLi4gd2hhdCB5b3Ugc2F5IGhlcmUuIFdoYXQncyB0aGUg
c2NvcGUgb2YgSsO8cmdlbidzIFItYj8gSWYgaXQgaGFzDQo+IHJlc3RyaWN0ZWQgc2NvcGUsIHlv
dSBuZWVkIHRvIHJldGFpbiB0aGF0IHJlc3RyaWN0aW9uIGZvciBjb21taXR0ZXJzDQo+IHRvIGtu
b3cuDQoNCkhpIEphbiwNCg0KU29ycnkgYWJvdXQgdGhhdCwgSeKAmXZlIGp1c3QgcmVmcmVzaGVk
IG15IG1lbW9yeSB3aXRoIHNlbmRpbmctcGF0Y2hlcy5wYW5kb2MgYW5kIEkgc2VlDQpJIHNob3Vs
ZCBoYXZlIGFkZGVkIEp1ZXJnZW4ncyBSLWJ5IHdpdGggIyBhcmVhLg0KDQpJdOKAmXMgdGhlIGZp
cnN0IHRpbWUgSSByZXRhaW4gYW4gUi1ieSBmb3IganVzdCBhIHBhcnQgb2YgdGhlIGNvbW1pdCwg
SSB3aWxsIHJlbWVtYmVyIGl0IGZvciB0aGUgbmV4dA0KdGltZS4NCg0KQ2hlZXJzLA0KTHVjYSAN
Cg0KPiANCj4gSmFuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 09:07:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 09:07:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301255.514088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckaH-0008Rf-Bg; Fri, 08 Apr 2022 09:07:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301255.514088; Fri, 08 Apr 2022 09:07:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckaH-0008RY-7c; Fri, 08 Apr 2022 09:07:13 +0000
Received: by outflank-mailman (input) for mailman id 301255;
 Fri, 08 Apr 2022 09:07:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nckaF-0008RK-BD; Fri, 08 Apr 2022 09:07:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nckaF-0006cw-8v; Fri, 08 Apr 2022 09:07:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nckaE-0000wc-Qj; Fri, 08 Apr 2022 09:07:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nckaE-0006F0-QK; Fri, 08 Apr 2022 09:07:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/Rh506GXjyYCO5GYbkbuNXL5PxKi2TwKmS81gWOZWX0=; b=ByLIgDOpgFjqd/MF0vWOAJK9Ef
	HHq4kbMjqFahpAftpfj1jvY8sfrpaLsV3ln28IUKMJ1hy7nGTTRhT6BD6+FpdmWobsMTzbcMXU9nV
	Ewytl0p9C8ZrHYztbDNvvjL37iaqdel84c6cT+flW9u03bly35v1u6tR3wGDgqbj8Yk0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169229-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169229: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 09:07:10 +0000

flight 169229 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169229/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   38 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  289 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 09:11:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 09:11:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301265.514099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckdt-0001iH-SP; Fri, 08 Apr 2022 09:10:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301265.514099; Fri, 08 Apr 2022 09:10:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nckdt-0001iA-PC; Fri, 08 Apr 2022 09:10:57 +0000
Received: by outflank-mailman (input) for mailman id 301265;
 Fri, 08 Apr 2022 09:10:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nckds-0001i4-DK
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 09:10:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb19dc4f-b71b-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 11:10:54 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-lcxIjcFvOQqp9aJM-dJsWA-1; Fri, 08 Apr 2022 11:10:53 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AM7PR04MB6775.eurprd04.prod.outlook.com (2603:10a6:20b:102::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 09:10:50 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 09:10:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb19dc4f-b71b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649409054;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DYSxQSM3CYhfd5TXUvhU3jXDxT6dvZg75S5ddVjARJI=;
	b=c7aBH7S0tE1EZBmLa+yKtCw+8NK78vOnaNZeM1c3Tl5DdXmp9fxSe8JQWVkL7BP/pLmXuZ
	7uevXCwAsSYUgfAfZvIWfhuEGVj8mRmrx2uPEHvzepUnqBOA0oW5sz03FB3s7fcLFH9PUQ
	x3IEl9i4W1YPm73g3xR3MuFxtG8tjkQ=
X-MC-Unique: lcxIjcFvOQqp9aJM-dJsWA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VgmtBEN2WTkxY05PCxcHZuKYKBPbAwqbBdi0AEg4bVwHlbSMxzAMNwVic9KE5eirXmHJeasmJVZpqB5/MYY7gSvWP9z648JW6J9+KlmOl+IcdKhRwiK3MVYPSX9PnroVRev6xm8qY80HZz9XD3l+/kWwBYczP1ptp1iYA5DNapmAurxYxwT38d5YC1amffTpq5iZiaJW6RPT2awFJhhEeCz0Em2EAzE4ZTsKcOlCwNCyWJNA1alxIAs7YShnwW6NsGoBJ3yR6FCpj3kZgInG5us7ifBUMWe8wpnWhcb1GAuJvH4AvpYphmgxI36hUGEpSOPr8CsAV5dqc0nDGrsK7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W1xeU0RmUz3RtNke3MQimnA6qk3rju1aPUVKx/AKLNQ=;
 b=TElOycPDHW9M2nEqw384wUa/a+TkQfvzZUnjE0ngacNnBSYVAftp1fzlpZoKA+K1fAu04MljM5902ZUa/GC8sapz0FVdInBhpCQ5kax2wQXhuGWcy58+w0t1Vl/OLEWrBFbHcGbyQiFFJEtFr5JuVAJud0x833/8k7omgPl58JoZlmAeINruuD+2vtZwOnRDhYxFZGH4JtvsGCOWVohjJcVRAQN57RjDopDSUIGqdtaGr0xXN4trzlgMHqlFQj0wj58GbsmkeXrJlraLqLXZg43nRyQs3s6XdKC23Z31Z2G2JPvJUT2DgXsYWB6Yt0VoGHH8F1NM0JhtnxhErTCbLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
Date: Fri, 8 Apr 2022 11:10:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, Juergen Gross <jgross@suse.com>
CC: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220408084517.33082-6-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P251CA0003.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::23) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2be6de99-7f6b-4547-f9b7-08da193fad01
X-MS-TrafficTypeDiagnostic: AM7PR04MB6775:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB67750732BB8FCDB370632143B3E99@AM7PR04MB6775.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bxj3GZ3X1/AD86qLvEQk7CfOexGqZRoeZCc+0B451oHxUb172WsBCq6LqcWgasYe3g0rmHn4fUW0ULVffVk/Yf1k2Fupsa0Ia962phC0zw++6AIY1Vrv9UDCQRjYkZI24R4i8OyumHqZ5KcAscanF2KWUsXEbgTXvwus6JDOnXg1LOlt6ZAHPXeai2so4YAbQv4FI/fu1BjYwpRlY6wwiRA/Ypg+ZuAxMK24bAwNS6i80PgA9Fy37RorTnVrWqjYu1g+xB1k6XEyB4yTkg9rYIab1Z1Xhco9CLqJCsE4dFQLsSjijcttjuS+PIpBDZV2Sm8NW2wMYQkU6beAjloNJzPPTNkVRxZV8p6VrqT80EySHtxSYb9RiKo2ca7KCVqRuc56jHmdROzEqWxKd3F/XAoW4MgWfeEAxTwwNVEXMivL9f0cj5iAvphUGGLUDgmml2e4JJiqw1bmSarPKD9MMKqpqZhljNOw8xsMcDUF02xXycts7vXAtEhHcBRbcMg5rmKWL98HnwAgHarilkiY8wS8ciCqAEtAvN8QZDjaEwOV0l6vT57QJfMl8/FdMbSGuUl7SMXCAZUSQO5LW6ruVbLZFKrg3LH+kbjt6p0V32sZ0nOd3HkRnMVj6RhbN3JGWsXy438nKqiTgLhRidKrw1YsVfHteKLx9bYiw+LuHG5n+hYuA9Q0Fyw/ngVl6owjJgayjFGvSKFQ1pz0/YQIS64SzHDIrf06KszvLtbwhkxtgUCa5Vzk/dc3xIwrg00Xvh1yNuvV6CtSUmBRJGtZaA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(2616005)(6506007)(8676002)(6512007)(86362001)(36756003)(8936002)(2906002)(5660300002)(7416002)(4744005)(31686004)(31696002)(66476007)(66556008)(6636002)(38100700002)(4326008)(66946007)(26005)(83380400001)(66574015)(186003)(316002)(110136005)(508600001)(6486002)(54906003)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?a+x29x3fk7Wl6lG9U8zHYi4CHFNqhcP0P1ZvZv9NaUfAiOIWb1pGi1mMOjsG?=
 =?us-ascii?Q?Z/8ef5vAryRgQIv9xvgTxxISl+yvokisYoLpJGIDN9HgWeAyQL3hGKHH4TRe?=
 =?us-ascii?Q?5vahsNe2fzBjcy7PKbJeGmkqzr+8GuZiY5ktWYhYQBrb3bpuWrBCJ2TOVv4G?=
 =?us-ascii?Q?t90tPG+rfdGREe4TcPNR54bcq4TacSVvBzb5fHZVr4b4iZ1F72ZlrFuabTkF?=
 =?us-ascii?Q?oARjN+ee5xgRAkiYQoIz6mhlRairnC4DZgUTXmg5LnQoq280IZVcBK8yza9/?=
 =?us-ascii?Q?KNN1in3c0+ccAY4AgY01NJ8CwQYH0dSj60WrA01ncOqBcfoTgTl9N8evVUuB?=
 =?us-ascii?Q?vQsHJBbjm9t5DqSlCzjm3LWc+GH3wPwAQgaZ3qlbNZKCpoV8cNQrFNtJnA45?=
 =?us-ascii?Q?qNc7gHCv9LNgMG+1DI6rI31+Tdz3/Be04iba/7qI/MRLgxV2BdWj2IBhQbGT?=
 =?us-ascii?Q?ZmC4GmprLB+v82A8QAV2cVatJae0s3OrhFX+26MuBMgGRZZ+TwRnOk7nMCrQ?=
 =?us-ascii?Q?TVdKgg4PeMfyx/xUiDlNEWbP2o2UHp3ityv1qjVeQ6MJoZ2oeSg0PSTa+MJa?=
 =?us-ascii?Q?phyjmfR0WkLXoAmvP9CDpGxIMX2/pRqjuciRQzz75VF9Nj6a1YBXqpxz3vF9?=
 =?us-ascii?Q?OhpRUdklhEtCvHutUL4N6CSHciFqFkex2d+tK6A0oiUELHEhbJDPLAPVYtoz?=
 =?us-ascii?Q?AG/8nSBnDbsxuJyJSgyoHRxC3xurIbj2ujOX30L7iRatWbyxQcB/osA9VtnC?=
 =?us-ascii?Q?rI0y4PrjANJ/jUAR2MsWoZa/wK34bb4LostSqI8U3JgXMJyUri8+dAu6kV2D?=
 =?us-ascii?Q?Gfks2D0EOGAqIh5lWBP/VHZ5HS6ZQ1my+CZ5jrsf4euXa41+SeohBgsO9sHi?=
 =?us-ascii?Q?eQwrYc61tAq4vnSECuMZ/gXm1fO+xktGCV3hj53pXYLw0ytFeZwnDJ+ORQ/O?=
 =?us-ascii?Q?/Jv/vx5z4BI1sHbfuFG0gKBxXTMg7t7XrUP1wZTdJPvMS39DDCdUmOiak5sJ?=
 =?us-ascii?Q?DWhkDtNZgA8T03/RRUQOBBIGcn/44VFrogj/SutyTFOHfwDHeic7Yw7n4ljC?=
 =?us-ascii?Q?0Qkt9ZnBfAjN0yqJIcBD3RWLInHc869ftyjJUdr2x+5CZFCsH5YfB8wwTrm6?=
 =?us-ascii?Q?EkbE0bvoevQXwnCrqtJCdB9Pc5qfR/Nkj21LybOiD2o4H7Vqi+yMd15m7IX+?=
 =?us-ascii?Q?N3HioYQ6LfZRb7EHG10GVCI59G8Jo7XJ32Ozv+9mT13l8pyTNwFYjd9S1Nix?=
 =?us-ascii?Q?woQKm3NVcSeD8drTwQPWiAi8WyK0B/8hVfBf+sN6HWvHZp5GXCOIelOk1UHg?=
 =?us-ascii?Q?cP8O8kSkaxoYkHGN/tzZhuhEh2CRHbXURAsL+M4PmhFz+CZbuZRiFZUArV90?=
 =?us-ascii?Q?tLTSK/aYyTJOEuSUn+2qB/VxSz4jiMbeaacLpziP0/oAlRWfaH/yZbhuHWp2?=
 =?us-ascii?Q?5IU5AsKzsGxDddLg9IgNlaQ5lFY7U9nOCa11M6Eh7hGC9gYRQyFaIs9tc2mR?=
 =?us-ascii?Q?uKVygHAyxNqZf5Fjm2AJYzQgGyvUwNH8uI8yZyZJJElfJQl5OCTXFrTJ3Ow3?=
 =?us-ascii?Q?RuKAGlmwHa+CCQtMgqHbV1u5XnC9aq3gMSfSccdTAjFJdI+uS1baRO09S6l2?=
 =?us-ascii?Q?0s52gCvhG4cgufE3ZpzMYqz8wybU8FPr33WmfEMpx5dPgD+OGgS9UEX50PvJ?=
 =?us-ascii?Q?Mghkt4ubECqbsELBfxWOQZ4k7RB8g1+w5VgUBkoD4+Vbxh1uhIJKt0Z3DQp4?=
 =?us-ascii?Q?bEROwUzmkA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2be6de99-7f6b-4547-f9b7-08da193fad01
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 09:10:50.5067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DJyzxo52OHnSr5qkn2COfqHFtbXFJnvdyYFvTZPMvpW1zRiWipgVi6pa1Mh5MBDSqeSAepcnpbYFJ5Ukf1Pt2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6775

On 08.04.2022 10:45, Luca Fancellu wrote:
> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
>      /* Per-vCPU buffer size in bytes.  0 to disable. */
>      uint32_t vmtrace_size;
> =20
> +    uint32_t cpupool_id;

This could do with a comment explaining default behavior. In particular
I wonder what 0 means: Looking at cpupool_destroy() I can't see that it
would be impossible to delete pool 0 (but there may of course be
reasons elsewhere, e.g. preventing pool 0 to ever go empty) - J=C3=BCrgen?
Yet if pool 0 can be removed, zero being passed in here should imo not
lead to failure of VM creation. Otoh I understand that this would
already happen ahead of your change, preventing of which would
apparently possible only via passing CPUPOOLID_NONE here.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 09:25:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 09:25:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301271.514110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncks4-0003TT-5g; Fri, 08 Apr 2022 09:25:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301271.514110; Fri, 08 Apr 2022 09:25:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncks4-0003TM-2S; Fri, 08 Apr 2022 09:25:36 +0000
Received: by outflank-mailman (input) for mailman id 301271;
 Fri, 08 Apr 2022 09:25:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncks2-0003TF-LE
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 09:25:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d6e9ae38-b71d-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 11:25:33 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-EgZ-pw4vNzy2SW4VYH46lA-1; Fri, 08 Apr 2022 11:25:31 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by DB6PR0402MB2917.eurprd04.prod.outlook.com (2603:10a6:4:99::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 09:25:30 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 09:25:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6e9ae38-b71d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649409932;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xBiWPL9Yq4YswZyyVmA0xld+FXIWll+lUshzuKP6e28=;
	b=Sy9gTckA8alsV9I+lDFqAEQ7Z7S/OIfCfdtFT2ORmG5EUkWPbONlNQ56dODo/icBzVnScS
	81tK32wipxkBd00vndS4EpgG5rgFtO9IVHat4EqCa3JEXMWk9QLZILhJLy1SJEwYZ7JV9R
	jxpsrzLYn8rlpBTiO6TE2EK+vPsvrHc=
X-MC-Unique: EgZ-pw4vNzy2SW4VYH46lA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ie/yLMkk/BItzzrDMxAZ3ZI4/cJTD2b3+pYAMXeolOfRIxdELfu4RMaotDcQt9PfctFEmqwHIQY9JvIcqi2kG0gxwuncCQE17z4nU0w/ctkV9+KjTwUpFHd7wL0XmcGVHt4Ma3CT5wboNoQcS7KgQIr+fHOAHQwpvWOdGsOlEqD8hkSWIttlaayLCoc+KwCG2C6Uvwq1tV3ZgtiQJB9BWbgtiwYOjEPLvC6by8AkN/WVfQwDhVlUay9VK9uiIlEYcOjgKGKNWXNrYTnRCd891qJRDlo2miU5Cd6UeKnBatybvDyQPRZV89ffx7Om5DqSJsidgQuQ2UfMWrofq39wnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=py4JQSQM5+JO8FvUWTXkGb8C07lU1m8ZN9z+bPH/dc4=;
 b=AUsjfGTmEnBGBucxr1zhqahQ9nvglprvFzVucRnfAPH26i0fT9k9+IotSTFeTpRloYQECx9M+mpCI20rVDjTOGH7lrcHunwJ/liyZETGF9RsUKIjhfHwnFyJFMB1oIrOvlcZp0jlHeKJnJTAxa3+hvHcHQ95x7vp7/fiyzSw97sZEdoIL+gKLVlyWC9BPtp7dvoqoZDFJR0ZKKbpMgrv/v4v9ShI1BFthMea/6xMlj2uVLA5zyEkMg/yNDkWBHkhmI1b8G3UZScZGhaAs1nzqX+AVUhyF1/NHnHHC+QAZFySsBh7K4eqii2Sc3OB+yXfcz13Npg8w73HphTbo6Xzow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
Date: Fri, 8 Apr 2022 11:25:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org,
 osstest service owner <osstest-admin@xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yk/tzuKq4D3mFEQu@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0054.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::31) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6ed11761-94a7-4a6e-cdb9-08da1941b971
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2917:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR0402MB291779D66A70C8FA44A7B07CB3E99@DB6PR0402MB2917.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LqsXDf649lN5p4u4qILlrDYDwdMW2yWmH09vtpEZ2Uo1BcKkxYDgwZtC0WFBWoJsQlfxzZHEJxTWHxDq9cHOLpnMffyga7lkRljoQOLBVsT8aJTcFe2n5EE6znvth7hddsmgb0LJi1YBcp1C1pjH76/JyNdQt2a67bDpxaiGrXqd4CFxnmbMQkTabMuSHRuHE8QuLv/+idc7PFzgJzB4mZbmQ5X10xWSEpI3DZzW4UURQ8JWkNN5qnmD3twwZqnCts7re4+KbMtRNGG/qJkNnuA6S8e39wlHltUgC11YMEzXFyEEn8D88luYU6rKUgXfsGQjlNI/dRC0NHWbSSdHiQPB4IJPTzLHlJk0kdNq4pjlr5BwM6NMpPZjk1nZFtPynOuRWIa7RfWcAM/Ei9I6wPI53ez2rRLLNLF6klvv8JaH3hpj1bsJtc0X9MQIhaET7q4tUgALj4GE+GpSQbX5ebJDC/djeXGkJPNRcd6rUUQ8SvB7zlb4rtTIE3ilnHeY7X5DXvAYhZH/+E2fA3pzKJTELihHUpdkND2gSKLsN8VU1p8UxlJmOA1fZsWcTCf2DKu+D/oi6Hb0I0LQZyDcRsOxDF/oC4DGIZfSoDeKrptdgLK4jCU1ndNrinO2dDYJbW7HHJBiG4OMYTbNtXK79sQwQvFJYDHsdhdvMWPtyzcCjvItVn6VYwsuh3c0tALCuX8rMgZ2hzfZdA0Y/eFCyw3bZGdWTk4jTdaGBmbYFtoazdX9PResdNTZAXd6RPlLcDQuZurEOXlJgctZU8YuDhudI6j6I+QWi0CFVbzjwgrOrtdfGlfJrIAU99G1//iiJWp1t42Hvi+S4gOBSkBC4Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(966005)(54906003)(31696002)(6506007)(38100700002)(2906002)(6916009)(53546011)(107886003)(2616005)(508600001)(6486002)(316002)(8936002)(8676002)(31686004)(4326008)(6512007)(66946007)(66556008)(66476007)(5660300002)(36756003)(86362001)(26005)(83380400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/tvb6LeU5SFMLRhBhyPrtt6LtN9ZyloCK7x55N7yVQ8hWavmf2pYZ9sJIFf3?=
 =?us-ascii?Q?ueGJRXFLgnrtt4CnexPKMzoWSnwiDc2shAPtme0v0DPYq52LqAIIgERr2N2/?=
 =?us-ascii?Q?u7sP5toY5M4G2WTm+JTV9x7MG+BTuBn95SBg3qEiSTtf5jS2LVG/xXDirBnW?=
 =?us-ascii?Q?Va7vM6wjmn0Atf8k8tk/BakwuKgUl4wiFHMm9RXOiZVCrCovHOvOHEDJrm8m?=
 =?us-ascii?Q?rpABVAjAkCkqPi/01iZuqrr23d0T6zLaScUYaFxsNYtzfaGWBXZCsDXjMHPo?=
 =?us-ascii?Q?XGpZO9ZmZmYYKBZhtTMqGnFmEmSuWfOqilr3HIm//nAelTOEFcowQm+pgEEF?=
 =?us-ascii?Q?qALzkr4q8juPfu8uHsaTa0s5eMOoLefMFgt/jERlYIXu2YnI+lUmJwndRhqA?=
 =?us-ascii?Q?S2fC8j5X8Y1ek5hqOQpk8dFBOQ0pLB0R9xhFADfX5GZpliXu/jvtKCaFT4fk?=
 =?us-ascii?Q?cMauNDlQ8H/1GQ8YdCy6G5yNXCkq9q7KgaLb+QU4N17yWtTRHLauL5yPC67S?=
 =?us-ascii?Q?DbwiY1wsxhuRqtvjEhjzV8ejCPbSvHqneVWnAcfwze+01cDozkEPSPIwFZEF?=
 =?us-ascii?Q?t5XzJI4EfBz+bjwBAez0A6ifoiuye0JpZVOB3KlZfuJCG8+kCiwl97p+fYXT?=
 =?us-ascii?Q?byZind1PYLRLZ+BDfevy5PKJzbrl71WH0DMF/00GL1/X10xpTHaxinoC9DQJ?=
 =?us-ascii?Q?JJk+OgPtRhtzXCfX3RhwXqWhmV47FGh/MUKgP+q8XaEy2G6D3EQVgPKeK2Z9?=
 =?us-ascii?Q?Ak6X0RLyNrQdPfYeQaOqjIoGSMJ3BAofUYkB26dF2LFOHR0IP0M4mPMToJab?=
 =?us-ascii?Q?4XO97WV6whXknXp0tOdG3b++LunKN21BBmQHFH+WrMamyyYZSAJ+zA/WfBPh?=
 =?us-ascii?Q?H2Scsffk1bs8NMGweFQNcKSveQ+yOdjb7g5PNahNeppLlg4p6boe0skwdEam?=
 =?us-ascii?Q?59KPdAUCyi9xt3LYEWDXWygSHQJ4JBaWvhnwDfZXcXZ9I1PUL3Av2bULdzIW?=
 =?us-ascii?Q?+czTuwOvaPE4aTBW+CgFW/RzjYaYQU6KeW+tbxgsUVck/lCAEJeh3gScUal3?=
 =?us-ascii?Q?7MuovcDnfOCLnSm+B9hT8qmMvAiW1rPbuhO4TZ2ya63J6pVa1Id9EamDoS15?=
 =?us-ascii?Q?VmAcnYLQDwYPYe8aAOVoEPQ3kYG7URhklQll9o9VjhvhRv88oTKoBl6bnAw0?=
 =?us-ascii?Q?IMJ6QS0JAGKWwvkOHiemKV5F30YsnVkK+MlElzJuHgQbq+LCMg3l6ploCw/a?=
 =?us-ascii?Q?5h7qRM9goNPNVR+79EHlft+y83h1e6yVb+Pw/fjWi5f741gj+zbJILyfA6HW?=
 =?us-ascii?Q?ozweTF0G2B7d5TL7pDA6qQouRYHiOinY9yAZP+AaiJ1+6SOCcN0nTrMKbp8f?=
 =?us-ascii?Q?9PnLAH9QBVGtCLtE+eV6iOt4viToI/+q9TnKzpDVcr2VWl+t8y5BS9HXVM9o?=
 =?us-ascii?Q?YvQsEtQBF4pW0EV5bdZrvcc65wItuzLZT/CQfdAcpiqNzPcZlOsTsHS4nwg/?=
 =?us-ascii?Q?GiGexQUiDhWV8cyNt+bzOHK3I95o1TkuFKX8aITxFloBO6SVjQvCeOa7WbNb?=
 =?us-ascii?Q?HLQQzrcpX9bnY+ywuofXvuFUoByYsEe4j8CCmLIaAQydPvilgTduZbOr7XEs?=
 =?us-ascii?Q?MOrh7nC92nrQwsx40p+86qLuOSLgq1xDhff/+/c/CStj6lY0yBBz2mSAqhRt?=
 =?us-ascii?Q?0yb8IjZTkUo9l1TaiLyYCwYSSeeoaxupKNJDoqU0oxUPce9ui7YbEh9uS2CH?=
 =?us-ascii?Q?NdS+GvztRw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ed11761-94a7-4a6e-cdb9-08da1941b971
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 09:25:30.1939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YW7sJFF7jgPUJkz3Eaa7vhTA4LHUBXavxI5lkMtndAddD8puADFJOcEdEQ/QPe8tv9BnbcQrdgNoSGETM0OPnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2917

On 08.04.2022 10:09, Roger Pau Monn=C3=A9 wrote:
> On Fri, Apr 08, 2022 at 09:01:11AM +0200, Jan Beulich wrote:
>> On 07.04.2022 10:45, osstest service owner wrote:
>>> flight 169199 xen-4.12-testing real [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/169199/
>>>
>>> Regressions :-(
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>>  test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fai=
l REGR. vs. 168480
>>
>> While the subsequent flight passed, I thought I'd still look into
>> the logs here since the earlier flight had failed too. The state of
>> the machine when the debug keys were issued is somewhat odd (and
>> similar to the earlier failure's): 11 of the 56 CPUs try to
>> acquire (apparently) Dom0's event lock, from evtchn_move_pirqs().
>> All other CPUs are idle. The test failed because the sole guest
>> didn't reboot in time. Whether the failure is actually connected to
>> this apparent lock contention is unclear, though.
>>
>> One can further see that really all about 70 ECS_PIRQ ports are
>> bound to vCPU 0 (which makes me wonder about lack of balancing
>> inside Dom0 itself, but that's unrelated). This means that all
>> other vCPU-s have nothing at all to do in evtchn_move_pirqs().
>> Since this moving of pIRQ-s is an optimization (the value of which
>> has been put under question in the past, iirc), I wonder whether we
>> shouldn't add a check to the function for the list being empty
>> prior to actually acquiring the lock. I guess I'll make a patch and
>> post it as RFC.
>=20
> Seems good to me.
>=20
> I think a better model would be to migrate the PIRQs when fired, or
> even better when EOI is performed?  So that Xen doesn't pointlessly
> migrate PIRQs for vCPUs that aren't running.

Well, what the function does is mark the IRQ for migration only
(IRQ_MOVE_PENDING on x86). IRQs will only ever be migrated in the
process of finishing the handling of an actual instance of the
IRQ, as otherwise it's not safe / race-free.

>> And of course in a mostly idle system the other aspect here (again)
>> is: Why are vCPU-s moved across pCPU-s in the first place? I've
>> observed (and reported) such seemingly over-aggressive vCPU
>> migration before, most recently in the context of putting together
>> 'x86: make "dom0_nodes=3D" work with credit2'. Is there anything that
>> can be done about this in credit2?
>>
>> A final, osstest-related question is: Does it make sense to run Dom0
>> on 56 vCPU-s, one each per pCPU? The bigger a system, the less
>> useful it looks to me to actually also have a Dom0 as big, when the
>> purpose of the system is to run guests, not meaningful other
>> workloads in Dom0. While this is Xen's default (i.e. in the absence
>> of command line options restricting Dom0), I don't think it's
>> representing typical use of Xen in the field.
>=20
> I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
> uses 16 for example.

I'm afraid a fixed number won't do, the more that iirc there are
systems with just a few cores in the pool (and you don't want to
over-commit by default). While for extreme cases it may not suffice,
I would like to suggest to consider using ceil(sqrt(nr_cpus)). But
of course this requires that osstest has a priori knowledge of how
many (usable) CPUs each system (pair) has, to be able to form such
a system-dependent command line option.

> Albeit not having such parameter has likely led you into figuring out
> this issue, so it might not be so bad.  I agree however it's likely
> better to test scenarios closer to real world usage.

True. One might conclude that we need both then. But of course that
would make each flight yet more resource hungry.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 09:39:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 09:39:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301278.514120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncl5Z-0005W2-Hr; Fri, 08 Apr 2022 09:39:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301278.514120; Fri, 08 Apr 2022 09:39:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncl5Z-0005Vv-Ep; Fri, 08 Apr 2022 09:39:33 +0000
Received: by outflank-mailman (input) for mailman id 301278;
 Fri, 08 Apr 2022 09:39:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ncl5Y-0005Vp-05
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 09:39:32 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on061b.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::61b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ca2e1d38-b71f-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 11:39:30 +0200 (CEST)
Received: from DB6PR0301CA0060.eurprd03.prod.outlook.com (2603:10a6:4:54::28)
 by AM6PR08MB5254.eurprd08.prod.outlook.com (2603:10a6:20b:d6::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 09:39:28 +0000
Received: from DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:54:cafe::92) by DB6PR0301CA0060.outlook.office365.com
 (2603:10a6:4:54::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25 via Frontend
 Transport; Fri, 8 Apr 2022 09:39:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT037.mail.protection.outlook.com (10.152.20.215) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Fri, 8 Apr 2022 09:39:27 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Fri, 08 Apr 2022 09:39:27 +0000
Received: from 1bae8742b400.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 87678929-4FF7-4053-8AC6-6740EA48CC3F.1; 
 Fri, 08 Apr 2022 09:39:16 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1bae8742b400.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Apr 2022 09:39:16 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by VE1PR08MB5647.eurprd08.prod.outlook.com (2603:10a6:800:1b2::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 09:39:13 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.025; Fri, 8 Apr 2022
 09:39:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca2e1d38-b71f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Hpk+DkCtsLrRIBk7beMxpcNnE8UXtlXQ+7cDI+RfkFc=;
 b=NaP6x9dlbIP4AK6qmuwAnAoLX2bIZpzXUTckLDjj8lYiaJqwfDa1BWTMl9zXRWAT/ANCe9qX4Pd9ksn6KDVUfWE7glTc5gZuXNOe+UzPNEQ3/MS2s8bNTtoXhXt7RJ4rHs4vqOK9XDQZY4Au67liraKPO80ovSM7CP4sTW/BXdw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4d51174eacacd499
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c4+7l25TNujyxCK7SC5oJPnNqfyFsfiatt/DDT3o1WKc8tl2cmG5eMfuYcF4xNtTm9IfC+aDjEGCbhSeyerNivBifisu+fzlahyvf97lZHxrrbIwdVDNI0Z2Tiyrq+fxCNBxlgmrwdrVNutO60iYuHMjIZ+l2/70URmH/PkiLlPsO34ot1p7L9SKHYwGLH+4YgiKhGnOF1cIlmNA/RJMkvY5EYB3/dj5ZH6SbV3dIK5iVsu3cJj37dQE7cOaibMJQ2SBRedPOq9YUmFAQvvDcdrOJf9/4Bn76sWU53BW7PB5Cd832Gk2tFIlqLMn6Hwo+1klbJBULnYTMNjB+AJ5Zg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Hpk+DkCtsLrRIBk7beMxpcNnE8UXtlXQ+7cDI+RfkFc=;
 b=gO2tGKJtoh5rOZ23im49wsLNkgZFy6szTG3NzWupoch6QssUArRO94lefg6NwfaEW9LVRiuyp2/y5CKIzxGVSLkyqfAqLropXHZyqL+eRxE+oMNS4v/oi7xZCrrjxfXmPIAMGMA+0pDPL7JeprIcIcDTp4t+ycvtT+2uEzXbJNLha+hBunyQD4e0X+/bb5ZSlX/XkHo+wXU/jdfPOO4n5pdkcpZxXxfkKCVkIW474fCNQYKwX9OFqN5LH64WUceCW/pbQcgP5OO3ffaJeoX2chgCc9khfBd36fIKqvpYRDVEz8PjZFsXsHTVOC7sXM++aPEU333QnegTe7G3xCUYKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Hpk+DkCtsLrRIBk7beMxpcNnE8UXtlXQ+7cDI+RfkFc=;
 b=NaP6x9dlbIP4AK6qmuwAnAoLX2bIZpzXUTckLDjj8lYiaJqwfDa1BWTMl9zXRWAT/ANCe9qX4Pd9ksn6KDVUfWE7glTc5gZuXNOe+UzPNEQ3/MS2s8bNTtoXhXt7RJ4rHs4vqOK9XDQZY4Au67liraKPO80ovSM7CP4sTW/BXdw=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Thread-Topic: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Thread-Index: AQHYSyUS0CLVSvR2nk+ITbzc2Ry0wKzlusgAgAAH7oA=
Date: Fri, 8 Apr 2022 09:39:12 +0000
Message-ID: <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
In-Reply-To: <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: bfafded5-d114-47f9-0911-08da1943ac6b
x-ms-traffictypediagnostic:
	VE1PR08MB5647:EE_|DB5EUR03FT037:EE_|AM6PR08MB5254:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB525465933BF5D70BC2B26E64E4E99@AM6PR08MB5254.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 VrnJQYF3sjvbwaFR87h7uQ3jfv/lUKhOP7W6mT4uKvqK+ygZeBGB+2Od7N9q8/4+lo3PV5IQYEocyJflpWAhj7NvQa2XpsLIDynwpborMIHDA8rQjO2wp3UC5gPLbA0aM7D0X3CsOrUXg09cHCttG6PxxPsgB45eE998q0gpPEl7UWcr8cbYH12K33+efYo8JyJTfiFL4FSNnETkKok4t1e5VmkOvYx7QvJKRzDRzOoq7rSkafOYsYfOq7zB1HO5dQ/EfSq39BF10lym1cRbQqxllvM3Uyhhe4ReP9ao7j4RoMwPGir4bcfIQPh+0nc2P4nILXObNeyofVrbY7otZihF83/4/nDq/d4CPb+Ex7Z4v8bqk3O/KFiYP8bmM6ILiXz5msPUhEAPcpQL8xOvqfZnmzGDGUPW8TTfdL05szxvLiL/tNycSTwnrAcu19GK6JFMHX3gs6IGFlB+6kugFz2SMICbxJ4sy1ohDdkrBinyK2sDbCNNanIILZClLwrwGQKV8SAJZ1pn1kOICCTvFEpI8eX7IrYX15ZlpyMW0DxaFd8ueqdgv73ntIU4uoGYpY6i49wDPpSXP8eScKRMCqSe0T6ZP3WywrldEyAgQj/vpTIb6HOtr5F6WGLlcwAgmcSkgXo5UcKJ6DzekzORfuukyck+c+lve9RJBk3DlfqA18iHc849elQw4UD1Lgm1s9kwFI2Jvn8UYVrYwzjV1jyPoH6Vo38W0JGKFGe3lzjjZ9KVck21H6lYs7ZiJxXxTqTPXF9m/2pwtKmBZ1uGMw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(8676002)(4326008)(76116006)(66556008)(66476007)(66446008)(64756008)(66946007)(508600001)(26005)(38100700002)(186003)(83380400001)(71200400001)(122000001)(6486002)(36756003)(6512007)(53546011)(33656002)(6506007)(6916009)(2906002)(54906003)(5660300002)(86362001)(66574015)(2616005)(8936002)(316002)(38070700005)(32563001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <4427A46D02FB844BA11CB48FD78DACB9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5647
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f618ba79-b340-4426-d68a-08da1943a409
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BJ3yzEKu1dF//BnfZNqcGa0v1LaxzVu02XlTlhG6z+ZpmTQeK6h46B6EUPb/gVyI8Gs8p27RiGw3GBzA/Ir8yLjrzshGTC6NXN9ocB0f/fcg8OIkzG2aGMw3Ynfia1XUmuODL6XObUxhPtdiv8o4+i7msgkuziq4Q3rqDG8xi6DZ3mMcIu1H0cRZspYNC9WSNtkGZOUYS7VG/P7wfsHV79a39isLsBYuH9eANFhzOyMAbFmpXg7P/MdU+fq4DVBk+mOzYWpH5m8mBQsFnzH++arER7Xttk1VsN3j0OhNB8UKLL1nWlxS1Wil3dP12d6Z0AK/+16kvzT6BsjlrzNh6m4ek1gZTSn8ZmxN3pHg4a7LMnr6V062xwFqgrzDXOl8o9PJ+zvcK8D7Dcj08o495Af2vqEQzas9Sg+Ji7VQWvYI8zMifFaWC/uVfN7eaA7eKnY9j2wAg0eeWFOo+niLe7ZzqmIpOR9QELsUFwh0Z6876Ss0p/c24hesmEbdUJWKK6WROtPLU881qD0IDgdt6BD/sRxl5gRkMw0wutU/V6CMTx5Fy1LdvNm9omSo3dKspaI5m2fkfYE1/Sw5tG73FfvedBFeFS1hxC8odyDdMc8W/hrcAadu0Vxn66STcqqf51T5PqZPlaYQUJ8hewVNNQ2oAr3FPZugeEkvSPdV5AeIj8/nzO8XD3PeT10uapRi3KYDF3SohrwBNhRRqIHLVw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(83380400001)(316002)(36860700001)(5660300002)(336012)(6506007)(53546011)(2906002)(40460700003)(186003)(33656002)(26005)(2616005)(8676002)(6862004)(508600001)(36756003)(8936002)(4326008)(70586007)(70206006)(82310400005)(54906003)(66574015)(6486002)(47076005)(86362001)(81166007)(356005)(6512007)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 09:39:27.2460
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bfafded5-d114-47f9-0911-08da1943ac6b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5254

DQoNCj4gT24gOCBBcHIgMjAyMiwgYXQgMTA6MTAsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl
LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOC4wNC4yMDIyIDEwOjQ1LCBMdWNhIEZhbmNlbGx1IHdy
b3RlOg0KPj4gQEAgLTEwNiw2ICsxMDYsOCBAQCBzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21h
aW4gew0KPj4gICAgIC8qIFBlci12Q1BVIGJ1ZmZlciBzaXplIGluIGJ5dGVzLiAgMCB0byBkaXNh
YmxlLiAqLw0KPj4gICAgIHVpbnQzMl90IHZtdHJhY2Vfc2l6ZTsNCj4+IA0KPj4gKyAgICB1aW50
MzJfdCBjcHVwb29sX2lkOw0KPiANCj4gVGhpcyBjb3VsZCBkbyB3aXRoIGEgY29tbWVudCBleHBs
YWluaW5nIGRlZmF1bHQgYmVoYXZpb3IuIEluIHBhcnRpY3VsYXINCj4gSSB3b25kZXIgd2hhdCAw
IG1lYW5zOiBMb29raW5nIGF0IGNwdXBvb2xfZGVzdHJveSgpIEkgY2FuJ3Qgc2VlIHRoYXQgaXQN
Cj4gd291bGQgYmUgaW1wb3NzaWJsZSB0byBkZWxldGUgcG9vbCAwIChidXQgdGhlcmUgbWF5IG9m
IGNvdXJzZSBiZQ0KPiByZWFzb25zIGVsc2V3aGVyZSwgZS5nLiBwcmV2ZW50aW5nIHBvb2wgMCB0
byBldmVyIGdvIGVtcHR5KSAtIErDvHJnZW4/DQo+IFlldCBpZiBwb29sIDAgY2FuIGJlIHJlbW92
ZWQsIHplcm8gYmVpbmcgcGFzc2VkIGluIGhlcmUgc2hvdWxkIGltbyBub3QNCj4gbGVhZCB0byBm
YWlsdXJlIG9mIFZNIGNyZWF0aW9uLiBPdG9oIEkgdW5kZXJzdGFuZCB0aGF0IHRoaXMgd291bGQN
Cj4gYWxyZWFkeSBoYXBwZW4gYWhlYWQgb2YgeW91ciBjaGFuZ2UsIHByZXZlbnRpbmcgb2Ygd2hp
Y2ggd291bGQNCj4gYXBwYXJlbnRseSBwb3NzaWJsZSBvbmx5IHZpYSBwYXNzaW5nIENQVVBPT0xJ
RF9OT05FIGhlcmUuDQoNCkhpIEphbiwNCg0KUG9vbC0wIGNhbuKAmXQgYmUgZW1wdGllZCBiZWNh
dXNlIERvbTAgaXMgc2l0dGluZyB0aGVyZSAodGhlIHBhdGNoIGlzIG1vZGlmeWluZw0KY3B1cG9v
bF9pZCBvbmx5IGZvciBEb21VcykuDQoNCkkgdGhvdWdodCB0aGUgbmFtZSB3YXMgc2VsZiBleHBs
YW5hdG9yeSwgYnV0IGlmIEkgaGF2ZSB0byBwdXQgYSBjb21tZW50LCB3b3VsZA0KSXQgd29yayBz
b21ldGhpbmcgbGlrZSB0aGF0Og0KDQovKiBDcHVwb29sIGlkIHdoZXJlIHRoZSBkb21haW4gd2ls
bCBiZSBhc3NpZ25lZCBvbiBjcmVhdGlvbiAqLw0KDQoNCj4gDQo+IEphbg0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 09:54:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 09:54:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301283.514132 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclJi-00081A-P8; Fri, 08 Apr 2022 09:54:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301283.514132; Fri, 08 Apr 2022 09:54:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclJi-000813-M4; Fri, 08 Apr 2022 09:54:10 +0000
Received: by outflank-mailman (input) for mailman id 301283;
 Fri, 08 Apr 2022 09:54:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DXVu=US=citrix.com=prvs=090e341e7=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nclJg-00080x-QJ
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 09:54:08 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d2eb159f-b721-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 11:54:07 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2eb159f-b721-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649411647;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Dxp93n2HD9AxpqLZ/PlJbBq+qNAF8oUrnFTeJkkwvdI=;
  b=bSbAIesh+0EnzmjeKBGGTELHcpMfFmoyQvGX1R/Asj1Djm0X27m7sPT4
   2SWev91/p+256670IamYCfNlWTK8iW9/V/iacEpr+e1KveBPxoXr3iyS/
   yjzpRRtnHNXEEgrRgCtJ36LVWvn39HC13A2ndZjmHKCfBLUJiZTr4car3
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68366493
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0idMjqLE5sNrj6w8FE+RFJUlxSXFcZb7ZxGr2PjKsXjdYENShmcPm
 mscX2+FP/aIa2b0e4h+Ot/gpEJX75bUyNAxG1ZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tY42YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 I1PmJaITQcqBKKPwMcMekMBLA8uObITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ6aFO
 ZRFOGEHgBLoTkdjJnxQKb0HjMCHnGHlSx8CqVi4qv9ii4TU5FMoi+W8WDbPQfSVSMQTlUaVo
 ErP5WG/CRYfXPSAzRKV/3TqgfXA9Qv5V5gVD6aQ7eNxjRuYwWl7IBkLXlL9r/C/gUO6X893I
 lYRvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAOQyRdctUguIkzTCYzy
 16St9rzAHpkt7j9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iNkxoxj3StZgKqH21v7kMGup/
 B7aqDdr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4
 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5ZIVcFg
 2eJ4Gu9AaO/2lPwMMebhKrrVqwXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ
 8vKK5bxUCZFVv0+pNZTewv7+eV2rszZ7TmNLa0XMjz9iebODJJrYelt3KSyghARs/rf/VS9H
 yd3PMqW0RRPONASkQGMmbP/2WsidCBhbbiv8pQ/XrfafmJORTFwY9eMkOhJU9E0wMxoehLgo
 yjVtrlwkwGk2xUq6GyiNxheVV8Ydcon9iJkYHZ0ZD5FGRELOO6S0UvWTLNvFZFPyQCp5acco
 yUtEylYPslydw==
IronPort-HdrOrdr: A9a23:OUDvBqi6qWC0uKEDUS+sulKLSXBQXt4ji2hC6mlwRA09TyX+rb
 HIoB17726RtN91YhodcL+7VJVoLUmyyXcX2+ks1NWZMjUO0VHAROsO0WKI+VzdMhy72ulB1b
 pxN4hSYeeAaGSSVPyKgzVQxexQouW6zA==
X-IronPort-AV: E=Sophos;i="5.90,244,1643691600"; 
   d="scan'208";a="68366493"
Date: Fri, 8 Apr 2022 10:54:00 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Luca Fancellu <luca.fancellu@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>,
	<wei.chen@arm.com>, Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v6 1/6] tools/cpupools: Give a name to unnamed cpupools
Message-ID: <YlAGOLvpHMcxp1PG@perard.uk.xensource.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-2-luca.fancellu@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220408084517.33082-2-luca.fancellu@arm.com>

On Fri, Apr 08, 2022 at 09:45:12AM +0100, Luca Fancellu wrote:
> With the introduction of boot time cpupools, Xen can create many
> different cpupools at boot time other than cpupool with id 0.
> 
> Since these newly created cpupools can't have an
> entry in Xenstore, create the entry using xen-init-dom0
> helper with the usual convention: Pool-<cpupool id>.
> 
> Given the change, remove the check for poolid == 0 from
> libxl_cpupoolid_to_name(...).
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> ---
> Changes in v6:
> - Reworked loop to have only one error path (Anthony)

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:00:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:00:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301306.514199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclPQ-0001WT-5N; Fri, 08 Apr 2022 10:00:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301306.514199; Fri, 08 Apr 2022 10:00:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclPQ-0001Vy-02; Fri, 08 Apr 2022 10:00:04 +0000
Received: by outflank-mailman (input) for mailman id 301306;
 Fri, 08 Apr 2022 10:00:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nclPO-0001Hf-Jj; Fri, 08 Apr 2022 10:00:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nclPO-0007dd-FB; Fri, 08 Apr 2022 10:00:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nclPO-0003mC-5v; Fri, 08 Apr 2022 10:00:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nclPO-0002Wt-5V; Fri, 08 Apr 2022 10:00:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eo6qShFT5LPK/h4AQl+RaN26PBufQ8rxs3C4ODAiTyI=; b=S1Xjs26WGZRJjnFt0ypBz7as7k
	2NhEq1ATnFuGMUDUgWmBGEpBtSicz4dOIOjw3Ummg9nUIx76u/xvBRtZyt4vxx+yfNX/FMiyoLq4e
	qg2FJJIxa83xXzU6XMhaftE+CwLTUbzZXuWiO7lM9cCAd5txdoxBABY18XQW07cBybaQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169221-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169221: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d4012d50082c2eae2f3cbe7770be13b9227fbc3f
X-Osstest-Versions-That:
    xen=14dd241aad8af447680ac73e8579990e2c09c1e7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 10:00:02 +0000

flight 169221 xen-unstable real [real]
flight 169230 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169221/
http://logs.test-lab.xenproject.org/osstest/logs/169230/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail pass in 169230-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169205
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169205
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169205
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169205
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169205
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169205
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169205
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169205
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169205
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169205
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169205
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169205
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  d4012d50082c2eae2f3cbe7770be13b9227fbc3f
baseline version:
 xen                  14dd241aad8af447680ac73e8579990e2c09c1e7

Last test of basis   169205  2022-04-06 21:45:01 Z    1 days
Testing same since   169221  2022-04-07 16:13:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bertrand Marquis <bertrand.marquis@arm.com> #arm
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   14dd241aad..d4012d5008  d4012d50082c2eae2f3cbe7770be13b9227fbc3f -> master


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:11:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:11:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301315.514210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncla2-0003kF-B2; Fri, 08 Apr 2022 10:11:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301315.514210; Fri, 08 Apr 2022 10:11:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncla2-0003k8-7q; Fri, 08 Apr 2022 10:11:02 +0000
Received: by outflank-mailman (input) for mailman id 301315;
 Fri, 08 Apr 2022 10:11:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncla1-0003jy-0g; Fri, 08 Apr 2022 10:11:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncla0-0007or-O8; Fri, 08 Apr 2022 10:11:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncla0-0004CS-8J; Fri, 08 Apr 2022 10:11:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncla0-00078R-7r; Fri, 08 Apr 2022 10:11:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2BYTHBx9d7q4h0SrP0wOw75UfaPjrlK0vPanrCUABOY=; b=rBLb2R81uGR6T8LDP9L6qaNaC2
	FGK/jUf5PL4f0PjYXiiaQNbz2REQfrl9XHc6fwKho8tONtWjdCLVZfI7jJBHbgBaGhr2zWtsJig+l
	hbnJOZN3mA1umvA9qkKixYg8vIRflMsqe/5ggIfmjs5ckgdEVNOtIfKbhNvNU/o4TAlA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169232-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169232: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 10:11:00 +0000

flight 169232 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169232/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   38 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  290 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:23:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:23:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301325.514220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncllZ-0005SW-F9; Fri, 08 Apr 2022 10:22:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301325.514220; Fri, 08 Apr 2022 10:22:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncllZ-0005SP-C1; Fri, 08 Apr 2022 10:22:57 +0000
Received: by outflank-mailman (input) for mailman id 301325;
 Fri, 08 Apr 2022 10:22:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=co1q=US=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ncllY-0005SJ-CQ
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:22:56 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id da5c6c9b-b725-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 12:22:55 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 38EE811FB;
 Fri,  8 Apr 2022 03:22:54 -0700 (PDT)
Received: from [10.57.7.146] (unknown [10.57.7.146])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 24E633F73B;
 Fri,  8 Apr 2022 03:22:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da5c6c9b-b725-11ec-a405-831a346695d4
Message-ID: <363333de-0ec9-dff7-09c3-426530657a43@arm.com>
Date: Fri, 8 Apr 2022 12:22:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V3 2/2] xen/arm: Add i.MX lpuart early printk support
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220407024418.9827-1-peng.fan@oss.nxp.com>
 <20220407024418.9827-3-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220407024418.9827-3-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Peng,

On 07.04.2022 04:44, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  xen/arch/arm/Kconfig.debug              | 14 +++++++
>  xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 +++++++++++++++++++++++++
>  xen/arch/arm/include/asm/imx-lpuart.h   | 22 +++++------
>  3 files changed, 77 insertions(+), 11 deletions(-)
>  create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
> 
> diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
> index 111640edb4..26e2cf0249 100644
> --- a/xen/arch/arm/include/asm/imx-lpuart.h
> +++ b/xen/arch/arm/include/asm/imx-lpuart.h
> @@ -30,10 +30,10 @@
>  #define UARTFIFO          (0x28)
>  #define UARTWATER         (0x2c)
>  
> -#define UARTSTAT_TDRE     BIT(23)
> -#define UARTSTAT_TC       BIT(22)
> -#define UARTSTAT_RDRF     BIT(21)
> -#define UARTSTAT_OR       BIT(19)
> +#define UARTSTAT_TDRE     BIT(23, UL)
> +#define UARTSTAT_TC       BIT(22, UL)
> +#define UARTSTAT_RDRF     BIT(21, UL)
> +#define UARTSTAT_OR       BIT(19, UL)
>  
>  #define UARTBAUD_OSR_SHIFT (24)
>  #define UARTBAUD_OSR_MASK (0x1f)
> @@ -42,13 +42,13 @@
>  #define UARTBAUD_TDMAE    (0x00800000)
>  #define UARTBAUD_RDMAE    (0x00200000)
>  
> -#define UARTCTRL_TIE      BIT(23)
> -#define UARTCTRL_TCIE     BIT(22)
> -#define UARTCTRL_RIE      BIT(21)
> -#define UARTCTRL_ILIE     BIT(20)
> -#define UARTCTRL_TE       BIT(19)
> -#define UARTCTRL_RE       BIT(18)
> -#define UARTCTRL_M        BIT(4)
> +#define UARTCTRL_TIE      BIT(23, UL)
> +#define UARTCTRL_TCIE     BIT(22, UL)
> +#define UARTCTRL_RIE      BIT(21, UL)
> +#define UARTCTRL_ILIE     BIT(20, UL)
> +#define UARTCTRL_TE       BIT(19, UL)
> +#define UARTCTRL_RE       BIT(18, UL)
> +#define UARTCTRL_M        BIT(4, UL)
>  
>  #define UARTWATER_RXCNT_OFF     24
>  

I find it a bit strange that you fix the header file in the patch 2/2 while
patch 1/2 introduces it. Could you do these fixes in the patch where you
create this file?

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:24:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:24:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301329.514232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclnQ-00061h-SO; Fri, 08 Apr 2022 10:24:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301329.514232; Fri, 08 Apr 2022 10:24:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclnQ-00061a-PL; Fri, 08 Apr 2022 10:24:52 +0000
Received: by outflank-mailman (input) for mailman id 301329;
 Fri, 08 Apr 2022 10:24:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nclnP-00061U-D7
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:24:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1f053029-b726-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 12:24:50 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-aMzqQ5UnNfKd8iRNKvdyEw-1; Fri, 08 Apr 2022 12:24:47 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AM6PR04MB5063.eurprd04.prod.outlook.com (2603:10a6:20b:a::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 10:24:45 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 10:24:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f053029-b726-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649413489;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lYzuMb+9wSwpn3pznb/WDLsP30N1pRhxT9lvfxHm5kI=;
	b=E6oTxae4ooq4xHopIoL8zQzE+2LNNOmDz01XQLeURZ05A9SbjseKurqq/rgbyIqICpcIdY
	0qHe/7a1BY4KYq0uV0zxBJ1FdeLPrT7vvJIgDxIYMGXu//2CYl3IcDgCWIeXpzMxVfGiab
	q2tr+6b+ygjtv44skx0QwYVIXXKYLO0=
X-MC-Unique: aMzqQ5UnNfKd8iRNKvdyEw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FznU9IKrFpyHARVP8ItGWmZneLQdAlKQJgTOABJiuSF9hkRrpkk80vwkNfYnmkGsfUBwpuyMiVqSyelp9iApxnYSdWDCQadZMOcKrbPEp59g0yGnup4FxVvqelkoc2J2wNqig18ZIxotfY88bYOeUy2QqG75No0oMiySx4Arqr8/sT7+9m1KneBd7AaQfK47n5kvFb53DrQFwIb2zqiwqqe+ay9/qOhjESKXe1zEHiqoyjNOjbTsMAIfuyJGFFid/mniLzskE5F8YMaSAVhM6BLT6++KY75Ef/suECfzKtet60oFV54fbB7T6johgfEGx3mYUL93W4EdSzd29SnYGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J8ORu/hmTr7dlvtRyRsBP40DOzjbltA4Il3DUI1S7jg=;
 b=mvRoR1H/f4g/XFEfWju3FSzHNNX82zMdvRfL7Ds9DG0GjhDu+WHLLgsoDNuCt7krByjXseMzHxx3VKQMdcQYe55Kn623ScAoG53wasD01QDNJB9iJyCr232HSJGGXOUOBBNxBBW0z9Dh7ZI1f5Giu1SBr951IHA75VmElPxAf+3ZhcGhiLqM/4vqmKw1zUNFVLMX64fmqyDCghMmMDvmZ73H2F89uQmPfKNzXimRYzuij+xGS4bFhAHA7leSWYmoKL2uBnUf7CTmcp4U5iSAqjSOkeko/GAw7foEIF0Ap1haHrnkEmKA3BnVGDScDNjz0AoQKj7aaZFOYCuJ/dN4YA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cacbaa1c-8ae8-9314-9364-97e5a53d876b@suse.com>
Date: Fri, 8 Apr 2022 12:24:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: Juergen Gross <jgross@suse.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
 <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR01CA0053.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::30) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe3b42f5-13c2-462e-6fe6-08da194a00b4
X-MS-TrafficTypeDiagnostic: AM6PR04MB5063:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5063FF8E151B063F1A384120B3E99@AM6PR04MB5063.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ul0stOIqjFzNaE6vkdOklvQ472jUFmukqx8T/RhillVwdHTDsAJ4letlcuxSBmjnBI4eWKDAPTH3CfKXxFz4Wq29AHEuaM3/mEkx7TxAbWrYkYAnLeN07jydXkZbMrIFZPW/xP0RNVnFbmrRCUmWxlmyOK/hzsdiAiHVl7gHcON8UTWoE32AfYoGOMmlh0rigVt57UJIhvSUFPpqyvNlIJahM6yTVaq1oIjoREnzB5hNUX8/m5ZNiJrMrv/9j0Txixa8Fib9BwKDPeRqXQ8uvLTm04htAF2qKtx9l8VlsX2qu0o/1Vg0aBMIbb1IGN3wKL12FASf08+fCixtFajBJa1tn1VCIyfWnapbYzv+DEwZageCePNqI1W8RsYrsgpgat2J+QsyhDeyDRmGEyLlZEARzpRPLEbTyz/ceLq23/YCCauTGGhY5KlvHb6EdIDrmiStajbuaN8ZaXHNJotPewOBpXpOGpWYEpY1g5FAygSvJ65sBJBqJoaTYMp/p4Uy5Ne9CkZvYfQNjOsFFZSchu2HpycsfsXP4AzucI+MhraqG/g+vMCt8aWGQEbi1JlU+mBPMoZX5w73BWYfftJm3DdQ+5bfVLxI71FBMeqPCbcQwP9+0Mw+bfFKMtKPvn2MgsEYIPZUvxv7Bn2E3FqeEicWQvjLdvnaCaFWJa1waypJ/ioS5c/HHSLItIGBaB8pSQ09xcbKZci6+n116FfORo3V90GANSMovs2CRsg/aCMisGcg42stdxdyLLvtP0v9RyOvgZENMUH+V0n2OKF/qQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(66946007)(316002)(31696002)(8936002)(31686004)(86362001)(6486002)(508600001)(36756003)(54906003)(4326008)(8676002)(6916009)(66476007)(66556008)(186003)(26005)(66574015)(6512007)(53546011)(83380400001)(6506007)(2616005)(5660300002)(38100700002)(2906002)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NfSlyUOahPMi77AaiydoVOPK0Fk/abg/uLWhU5T5Y7PMHFqNq9su9akCBmO9?=
 =?us-ascii?Q?VISFGCOKo5s9uqq2D2CNJkrZVI08MLiywAhmylqEKukMJI4yA+jIT+LGdKC+?=
 =?us-ascii?Q?Aw5AvS6YKQ7Xlh6CuiWbzmhxnMKqe1rNmDA0DBQ70uXy3jtToQ+LWUJz9gQg?=
 =?us-ascii?Q?PxHINGDqwyPYXkGR2KUsErJzKakErOPMnOPQzHrSGI1Pn6MMTwc0pZC54a6g?=
 =?us-ascii?Q?0gWqod4meyFNGHriV+w1MdCY9s0nCHIkE9yAJKF0gGG6RJnI2D7j7GpAJPwd?=
 =?us-ascii?Q?LKMcJuGhB4fqRMxBPJomty3x3R0M0arm2etk77gwMunfrVl1dNo2OlUJgMb1?=
 =?us-ascii?Q?oQ+wP5nMvn0Klo2xxLdk9+Cg9kBK6H2FyeHQgfeAFCBj+Bu6Q9DK3mBAeYSw?=
 =?us-ascii?Q?OIqMkXfN5rvFpfRQbpTxtqsRsP0Qziwst8fe6hVJZh4NOVuRi8KkDpwVecuU?=
 =?us-ascii?Q?8RLdFDB+nNUF72oKj1cH0R5pGc7ioLRjox6bSgwP8oxoFt9nfkZZEQezGC1m?=
 =?us-ascii?Q?TBfMoCK21d/vdO3MDbfZ4PSBMp6Nc6llQOVmQqCJPvcmqhaB41KGAP5CF+z3?=
 =?us-ascii?Q?w5Ql6AgcJLoqZ4tSDqVn5lwhRtXtbXEqKjVXiBINLuFE9Hb4ZErbwn5AjdVf?=
 =?us-ascii?Q?r1NTxLxLX5WM7Gn5y9QtIiU84F4Ot2HiC0Vm5nNEtkYTT07nVfPu5IjFMpqp?=
 =?us-ascii?Q?jf+fgG6bsi2mr6INaYDuEA6R9o8iyxClH6JbTNONs2X/735bupqbukJ1idil?=
 =?us-ascii?Q?/a2dvav3WN2wwEdye4cb9SulPOOZhROOpHidqLAGsPs14HgTiIsYZ4wVFVuL?=
 =?us-ascii?Q?9WMuggQpn8wuBRl1vIfI27zx9w4OikOCc6T8wKkW+aYEJFew9jEdqSqkVOXo?=
 =?us-ascii?Q?y+4C+9kFbkli39BwCVohuxFYlyz5BrvM/qrs4lj73zJf4S/W0Q4w/JdPuC0P?=
 =?us-ascii?Q?kkY5QkbMKLiSy1c3CbuhRvZrK29qr6jRvm+Y0F7orZQrGtzD1aNB7L3eZ5Fi?=
 =?us-ascii?Q?NxnU0wjIc1fMlKf5qwBbHhStkT+kcEgQJzgxsQ35WYNR7oZ7i/gfMnkt8dps?=
 =?us-ascii?Q?tzqw3BljWe1EQuyb3sG77NMWuh1R4oSsGu7RK32xV59whzEVVuitumS+LSy2?=
 =?us-ascii?Q?SaQL49NLtXB0gnPw3j9sbY9nAA1aa9K71W0JzSQRAMacWqUZ1N2v7r5YHGwt?=
 =?us-ascii?Q?a5PjtsuHoAeuJSYudm9Ve/fbayIGmn/QOBKJ3FW8He4lR24jRkyzTyEjwInF?=
 =?us-ascii?Q?eBd4LWashXlaJjkxlqOXIVX/39rEB7E7tXjSlTrwss7uLWC16rRfRsvSMaYT?=
 =?us-ascii?Q?XnW9SXt4MFtW905fBXUlH2bM/fs6hy08CUYygbZBxkrDgx8Sii6Jk0ngjzYG?=
 =?us-ascii?Q?MB37iaPVAbixr0RyJhklez2nqMY+KXOw8kNluQiJ/F9GyN/LqKeiQL0o9muN?=
 =?us-ascii?Q?3JVK+yC6B/mts1jTKNk+2xqQoS3k1UrM4l1e/9Z29yP88d0CdP0BYEyag2ch?=
 =?us-ascii?Q?ZQVGVjLtWMoqiFPgs6DuwSyloMixUnQnSrS6A1nBBvPmpSGF5xF+Gk7iub0E?=
 =?us-ascii?Q?11bqa54R6EruSWbnrURr+eGDXaLxeUP/iYSflC1MxkRhhuxL1vq9094vq72U?=
 =?us-ascii?Q?v9JSs/m6bSr+yjXTu1IocB8AO3oI8vHAGg8pNIEpUUeB3groezsjZlr8+RhB?=
 =?us-ascii?Q?3hMrtB9I42o35866ujCJcwXDF+TehoSJKSXO+bHf8uVAAcn88bam1lo2WHzJ?=
 =?us-ascii?Q?M05ciQgMMw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe3b42f5-13c2-462e-6fe6-08da194a00b4
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 10:24:45.7539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ki7tjG8TKok9o1q+EHR30AYKO8Y8HdSb4xrn9zC1V/XN2JElMv2sBbzoan+vVvfjyBOgc5Umf6VMfDL4GzOZ+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5063

On 08.04.2022 11:39, Luca Fancellu wrote:
>=20
>=20
>> On 8 Apr 2022, at 10:10, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
>>>     /* Per-vCPU buffer size in bytes.  0 to disable. */
>>>     uint32_t vmtrace_size;
>>>
>>> +    uint32_t cpupool_id;
>>
>> This could do with a comment explaining default behavior. In particular
>> I wonder what 0 means: Looking at cpupool_destroy() I can't see that it
>> would be impossible to delete pool 0 (but there may of course be
>> reasons elsewhere, e.g. preventing pool 0 to ever go empty) - J=C3=BCrge=
n?
>> Yet if pool 0 can be removed, zero being passed in here should imo not
>> lead to failure of VM creation. Otoh I understand that this would
>> already happen ahead of your change, preventing of which would
>> apparently possible only via passing CPUPOOLID_NONE here.
>=20
> Pool-0 can=E2=80=99t be emptied because Dom0 is sitting there (the patch =
is modifying
> cpupool_id only for DomUs).

But we're talking about dom0less as per the subject of the patch here.

> I thought the name was self explanatory, but if I have to put a comment, =
would
> It work something like that:
>=20
> /* Cpupool id where the domain will be assigned on creation */

I don't view this kind of comment as necessary. I was really after
calling out default behavior, along the lines of "0 to disable" that
you can see in patch context.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:29:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:29:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301333.514243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclrn-0006vG-EN; Fri, 08 Apr 2022 10:29:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301333.514243; Fri, 08 Apr 2022 10:29:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclrn-0006v9-BM; Fri, 08 Apr 2022 10:29:23 +0000
Received: by outflank-mailman (input) for mailman id 301333;
 Fri, 08 Apr 2022 10:29:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rWku=US=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1nclrm-0006v1-3W
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:29:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c05fea3d-b726-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 12:29:20 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-B9XIrisXNxunwhQ6KZw_fw-1; Fri, 08 Apr 2022 12:29:19 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by HE1PR0401MB2316.eurprd04.prod.outlook.com (2603:10a6:3:23::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 10:29:17 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa%4]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022
 10:29:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c05fea3d-b726-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649413760;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Qi3gBZqVU9GOiA6inmQOKJ+XPy6pK8sUY8RJrVxwmNk=;
	b=K72aWyALg2Vxkshhq14WT/BEfq1fGnYRNv/KJIBbPY0RLwwqTSsmlIHUHAd5N0nfZvmBI8
	V3cJrF6FmPfrkzxEYK5U/VVj4FCiqKA7TLTThTBrb/CnQEtpYaCQbys+pQSK8+oJ2YThDz
	pLEkv7O+d3YHxu9WaAfa70CMoE+XboE=
X-MC-Unique: B9XIrisXNxunwhQ6KZw_fw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bWjX7B8UakHSoxtHGlksbe3Rj1KYKRSkAp1INwTtoOOPqli41z1CYwmh+zLr+DjyAIqewVIKcbD0VeohlggtpVHFVyFyw7QN++s7ijzWEbMxz8PGi5P3HdhJtd0YvYAoAS+7X6ru5kOen9sl76Il2Fev22gXOuxvaZCahnZwFc0ArL/fGa8+BNJQF0Xo8PE/3gc6Lq4FfM+u85KJ6b0hJ1qbJAp0OoCBfKNl5NwJs6l3pVZzYenk6X++xUlF+k6DvFZEuC7tbWCe6hivJ9sneQ8gfuwBEgTGy6RDjmTnPqI1/2vrMXNXzTcBjeXspyAXdn7PSd9fe35VdCmgBvOhgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Qi3gBZqVU9GOiA6inmQOKJ+XPy6pK8sUY8RJrVxwmNk=;
 b=ONxganN/CFdMkZgQjzYHE9SrQftnBL0sXuJwx7CF/vz6zN5Ns4pnbhR+lGZt5s+eIfY5yrAxerpEulnsx3zydVXnpEhMADLKUXW82isu9Fp+wfb5thwp082NBHSEqpjrRIereWeOJ6MvD2qvfCwj5mARiDLW+lYjnATOewaRiT6VPcGzuKmfcRcSmGuCPJamoGbwBHRFsX2NiOcNbcoG9hvrVD+Hrg5fqmOLGE03aLxEBMJSDqfD4RILYG6S0+LZRrD6AiQCQpzo7sxm83FlXC6fTvfL5HZ18Zocdo8mFJdNZOqrCG4h8OsrEH6beTyT/J9x/g1D+H1oRc2TsO5aIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: "luca.fancellu@arm.com" <luca.fancellu@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "julien@xen.org" <julien@xen.org>, Jan Beulich <JBeulich@suse.com>,
	"bertrand.marquis@arm.com" <bertrand.marquis@arm.com>, "wl@xen.org"
	<wl@xen.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"wei.chen@arm.com" <wei.chen@arm.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>
Subject: Re: [PATCH v6 3/6] xen/sched: retrieve scheduler id by name
Thread-Topic: [PATCH v6 3/6] xen/sched: retrieve scheduler id by name
Thread-Index: AQHYSyUE9E7urcTvC0i0eb3jd4Nypazl0LOA
Date: Fri, 8 Apr 2022 10:29:16 +0000
Message-ID: <a33a1cc55573a1e8d32bb22da31b17058ba76d53.camel@suse.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
	 <20220408084517.33082-4-luca.fancellu@arm.com>
In-Reply-To: <20220408084517.33082-4-luca.fancellu@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 936821b8-f875-4708-7984-08da194aa2aa
x-ms-traffictypediagnostic: HE1PR0401MB2316:EE_
x-microsoft-antispam-prvs:
 <HE1PR0401MB2316AA00A9E86DDA372BEBAEC5E99@HE1PR0401MB2316.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 OhGW18rR/9hLgo1Aa+h7ADxHFfg34LN6VOjiiXO7IwP91tP4nF+ZSoGIM5HF7UtX920pbVea0mvrsqRoVhvEeI9OAbLt8ec1H9VjBj4+F834ByqXHbuUaCr5dG2QEQmltD8VWI5Ft+0wiVXfDX280dBIBsPgh2qB0IBvzDx4Z3ULdkZIXqzh+oLJBpayNCNJJ7k0wvQCbLRtwtxQvQTxhu7J7/LUkUl3Er+sA0XiFoknJrwDWLU/Xcniads+wd7ltL0VVDaZsSltwvqSd4366PSBgL7WDvL/ihux1F0V4Mfg88NjM50idJb1fMl0Rk7HzWh3D4uZbf+pP26tdhzzZxIQVl0nOT9YMq4rdlbsoGEANyZLxjtOwK5UV1AgakPuFC8JLK4V5udaOl8K3zeMS5oViU8zWSVEqpuab1vmcVoCAu9apJySbfa4O5lEk7G8cp2xhiqLPt0DbBlgl6ZvB3IGSshXsvXxmIS6twXeaF1na5895m64pVw4x4JRaky5YQmP3RmnKigIfQTHRTNo02ZZwR3dcLjgiWmwLjBRIoi0P1+D+2w/SptBfjFDIQgXfXosH2N63DZsdu2jMUizu6i74ksxq1VVdfWKBKYhz8BHLAMAqbqL70WLyAoE84k/IjqIZ2pDAxSrKZIVxvOAHziPN3McRQX9E5RVfRIfjs819+WuBzVLfaGGX9wRKZRSRccMOOrqgGuEDsgqzwMB9lyAjGtc10AVYXwB4DpbYtFYaCMgrDpuOIs2TX3/YdQQ0ze8DIx3ZEAlFtD8L7FLyfK91IQh1sHUKY4NXcDp5HozoZwHEBy+e5QIiOj7X8fN
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(86362001)(122000001)(186003)(66556008)(66946007)(38100700002)(76116006)(66476007)(91956017)(99936003)(8936002)(2906002)(36756003)(8676002)(4744005)(38070700005)(64756008)(66446008)(5660300002)(71200400001)(6512007)(2616005)(26005)(54906003)(110136005)(508600001)(6486002)(6506007)(316002)(966005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bFhNemw1T0pSYklrREtKNWlldGkrbEtMVVd0OUxHL2IyakVLcS9rbVA0YzV0?=
 =?utf-8?B?cGdhelJwMlM1a3RpNnl5bkMxbFdLRzRpbWhFUGp0L3FRUUtWUFJ0YmdCcFM0?=
 =?utf-8?B?d1pJK0hSM2NYRm80ZjlnZDhqVG1Zb09QeDF2L2lIeHBUbWxFbTJ4ZWl5SkxB?=
 =?utf-8?B?VnRWUHlZY2JVeW5QMzByTFpQRGNodmJpUkNpc2s5ZUhwNktvL29hL3RiSmNV?=
 =?utf-8?B?TXRIaEZiSEUxZCtsRmFFREVDdTBNZ2FQWk1XaGh0dnhockNiSjFyWEtyTGZz?=
 =?utf-8?B?eDFqUTJjb2lIWEkzb0FwM2dOVzFGUW9VNnJ4MjVXRWdRdjVVY1F5SktWYkJt?=
 =?utf-8?B?aS8xdFQwcEZ0UE5aSEdlWDRQaTRBZ29GMmp0VXgxRVZHb3JsaExIamxOYy9Y?=
 =?utf-8?B?NVJMd2FPUldrS1Nzd2ljU3owdWdjd0hmV21iZmVsT1JwK0pzZ0tCVklVM2RC?=
 =?utf-8?B?S0pnWUJSMHNGS09kTGs0Q29lWUdRNGI4V3prbm5lTFIvb2R5RFJKTi82Sk55?=
 =?utf-8?B?VkFHalBLemVzRTRyWFRxRmg2dTRDQ2ZxaG1wYzJLRGdzeWFzdlRBN0RXam9J?=
 =?utf-8?B?UWJlbWs0Rjl1Y2pvYmUxZnVnK1RNK2JCWTFsTDNjMUJWVGNENjdudTVFTGZX?=
 =?utf-8?B?SjVoanUzNDNubDgrdDNNOXdwMFNLUjkvbTJXQ0xMWW5TVFN0NjdwM3F5aFhM?=
 =?utf-8?B?eS90dkp3Q0I5aE82eWJOK1YyaHU4WnpiZGI3WUxIVHhjcWZwS1BVcHNWbGNL?=
 =?utf-8?B?ZG41TTJSb2thditlNkdJTEtWQjlWbE9DSDkrNElMdXN1NllpNGpqelJTUnhp?=
 =?utf-8?B?cG5hcDFxemg3bjArZmNEOXVid0xhL2t6NWYxZU5oZkcrZkN2M3hvbTA2b0Nl?=
 =?utf-8?B?N2hwOEloVlVweUlUejhwRkgzSkpXMFVkK2VuMUdSbFQzaSs1dWNvQ1BMdElL?=
 =?utf-8?B?WnlHZkpnMFVXczFIOVJ5OGdjSDM3eGU3Z2V4QWh2Qk5XN1J4Y2RITHk5aGsv?=
 =?utf-8?B?Q21hT0R3ZjU1L3BsbVd3WmpMMFVDak01MmF2TE5DdlpYdm5wdld5bEVVWnZn?=
 =?utf-8?B?U0haOTJDaXRqd2lUc2pnS3BEZHRyWlpNd25RVEQwU2d6SHpkSy9ERjVtVkVq?=
 =?utf-8?B?RXQ2M2lDRkxZeGFyQVlxeTIyOEM4V1c4aGlnSjhrOHFBRktDRnhjOFpzRHUy?=
 =?utf-8?B?dm0vVVJjMnVybEhGaWd1dXd3ZlNjalZnU0twRHlmMFBsR3FOVHRpaU5BYnhN?=
 =?utf-8?B?Znl3blYyOEd1QWVoSEVNY2Z0YS9adWZXcjRpY0k2S2xxZkdRSzJBdUd1NnZ6?=
 =?utf-8?B?OUVFTy9XNmlzN0tRbjRWR1FnVC85NjlXNFhMdzZ3YnVuR1pEK1Viam9YQ3dF?=
 =?utf-8?B?dTBIM3NqcWZMcTYvOENEUGd3RWQ1SDVRSTNiYTAzcFI1MC9KbW1IczEySkVK?=
 =?utf-8?B?R0d5MXFqUmx1eDh1dDFXVERvQVVjQ2xnN0doOC93L0FxbFR6RlJ6cEpMR0hI?=
 =?utf-8?B?dGdGTk9XUHdoMkRLUVhLSUwzVnlYODlobGZWeWF0UDhrTXRKRXd6dDRhVG9W?=
 =?utf-8?B?ek1TTWQ5cjZ6ZVdYWUpZQ1J5VWpuMUdXcGhUMnAzVU4rb1lOdjdXUW5WWVQ1?=
 =?utf-8?B?RFk0R2Zzby9zbWJpMkVoaGx3aWY1NjdkNVd4MUlPRzFKRjZiQ3IwdHJVOHZI?=
 =?utf-8?B?MXpCYjZJUW15MHpZZWFlTEZsQ1BFSy8vMm4xUkVmNTBhUkt5UndHN09nZEw3?=
 =?utf-8?B?WEQvdmRUM1lnNzRHaGdWSWk1NDFZZVR3ZG5TTjZUVU1MMDVWMFFTRThENEp1?=
 =?utf-8?B?WjA2ZUY2eVRsOEJreGp2aTJGZnF5S0hsbnkwZ082c044S0VwM2V0M3BNN3dC?=
 =?utf-8?B?RGN6RkhGdmVtQXFFcVpRVFFZN3UyV0tPMkZwcDc0bDBXckE3eGlaQUp3eGtM?=
 =?utf-8?B?ZEM4dVpteGthbWJacHFLcE9uamtFVXprTHJ1MUc1dDFKL2gyY0NsYnJBQTU3?=
 =?utf-8?B?SnMwMkRYbGl1R254eVJmb2NabkI5bFV2MlF0Q0d5ZHZ3elZXTHZBM21HUXZM?=
 =?utf-8?B?dTZmc0padDA0WkVNS3J0aU9wY1lBSVZtNUd1ZG5uZ0RjWld1Zm1kOVUwdWZI?=
 =?utf-8?B?N3pSYUh3Slg0VGt5VFlKNm1CSkZGWHN1eTRoUVJBWTlxMGlIVlhsbEhVM01S?=
 =?utf-8?B?SUhEZW9wWm9XRHFNMXhIeXFGam0reDFCVVlOU1R4R2xtUU01YUxlYlpEQ0VH?=
 =?utf-8?B?VmJkQU5uVk55dkdQWVNRYVdHS01UT1k2WjZhT1FmZUYxdzFVQnVRTmpVRDkr?=
 =?utf-8?B?dXk4TDJpUjBQdVhPRnR6TmRRM1l0d1RXSnVOc3hlSGd6T2pWR0pVdz09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-ZDmeGkWQCWAlNOJLp/wK"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 936821b8-f875-4708-7984-08da194aa2aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 10:29:16.9952
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ge3+UnBn758GSG+0zL/r/fdMXDCnqvyzPLpqd2UvppYI0Doy5D7dAbaRGBobhrWin1JqsHVPI0gDlKdZuh5DGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2316

--=-ZDmeGkWQCWAlNOJLp/wK
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2022-04-08 at 09:45 +0100, Luca Fancellu wrote:
> Add a static function to retrieve the scheduler pointer using the
> scheduler name.
>=20
> Add a public function to retrieve the scheduler id by the scheduler
> name that makes use of the new static function.
>=20
> Take the occasion to replace open coded scheduler search with the
> new static function in scheduler_init.
>=20
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-ZDmeGkWQCWAlNOJLp/wK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJQDnsACgkQFkJ4iaW4
c+7I4A//QXxz2l0PkZtxAg2cC4eY4Jk2uZD0KX4Rxb/WJE30v8Am5L5WPfV+KxZM
nlj8xjdk+hZgxFySM29RhSuG7nAef7GtgvQ2jkOQh6SxkXk27v3Oq7Ma6wXYjloS
6OI+qEW3eDl9YWraTqxKtBJhw3RyP9FFdOaO82EbYide/kJwi1J6Ivri6rtmp3OC
tHlapUWSPu8EmK55fHidLfv6is9lizkSFEo3Rg6+ShIfEuGQlMUc4A3dozMDXZIF
4aNDistpriC8mId0aj8WHhtYA8U8cc8zxBzYXU4xaS6N4XWRBba1wl4dfkhC0j6H
bFrSJ/wrWa9X4natp+OU1a5QEUVp9/9ROE9/fTUHGPMyNmOfp+CU02tyqZAUhqnF
WqK66hu2W6Zx7yfFug91SA6vVayg/SbT0Z1OK5jFNJUwxEmeoqSLfNHB8TI8qsyo
Qifd5/Lo8HFDOmOeLBH2adoAivvcDIdjzEkoXZMtvGPrWnAsWIxxvwEiph33fPZq
mkXhemAQSYLuf+sHgFkYQXc9P/KvFzRorW0JTanVXoXXd7SXDvn6SS5Hs8e6z0Eb
A8dT57BlNkawaeRy12Wx6MwQichfiPUAudqQwRDsd3h82S2XI1t8svaL4tJXo8O+
5nbpzRe7wdTeOSoxEqlAN4pC1MMqZdmKu6Rdg/HRxt7n/I+70aw=
=WfFm
-----END PGP SIGNATURE-----

--=-ZDmeGkWQCWAlNOJLp/wK--



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:33:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301340.514254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclvH-0008Ng-3f; Fri, 08 Apr 2022 10:32:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301340.514254; Fri, 08 Apr 2022 10:32:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclvG-0008NZ-VA; Fri, 08 Apr 2022 10:32:58 +0000
Received: by outflank-mailman (input) for mailman id 301340;
 Fri, 08 Apr 2022 10:32:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nclvF-0008NP-N9; Fri, 08 Apr 2022 10:32:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nclvF-0008Bg-LE; Fri, 08 Apr 2022 10:32:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nclvF-0004qu-8E; Fri, 08 Apr 2022 10:32:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nclvF-0007Uj-7m; Fri, 08 Apr 2022 10:32:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=91OLTBizMf/gAsJltFdp4UXlfE+7Ow7bwIPvW/Rqyjw=; b=sqcR1+OWXAEANQ2Qu40Au4sNfK
	tsNwXkRMV7MRDsFjKbUf7TfYZLKHO9ariq3TKQdGd2Qz+NuMQCcu/RmBS03porPAexqnaoL1RBZBf
	UW8aMLc0guWFUiBzl6QZW6LSvnS7p5ST95XKEDY1DG0GOQ+oSRBPwwwH7gy6PyYMI7ko=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169224-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169224: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=a8682ab79150b6eee565478c7febdb3bb12ab64e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 10:32:57 +0000

flight 169224 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169224/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              a8682ab79150b6eee565478c7febdb3bb12ab64e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  637 days
Failing since        151818  2020-07-11 04:18:52 Z  636 days  618 attempts
Testing same since   169224  2022-04-08 04:22:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104004 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:37:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:37:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301348.514264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclz9-0000aN-Kc; Fri, 08 Apr 2022 10:36:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301348.514264; Fri, 08 Apr 2022 10:36:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclz9-0000aG-HZ; Fri, 08 Apr 2022 10:36:59 +0000
Received: by outflank-mailman (input) for mailman id 301348;
 Fri, 08 Apr 2022 10:36:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rWku=US=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1nclz8-0000aA-GL
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:36:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d062d2c8-b727-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 12:36:57 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-EVXCirVYMP2302s_yuqJ1A-3; Fri, 08 Apr 2022 12:36:55 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by AS8PR04MB8231.eurprd04.prod.outlook.com (2603:10a6:20b:3ff::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 10:36:53 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa%4]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022
 10:36:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d062d2c8-b727-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649414216;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=pxr2FxyNIlWpLU43N2xrobkIYb4Dr4GMzwO2XMKzp34=;
	b=bY9k2cO4/3qzAC8OFtKjqj2DFOYyVVx6X4RB4G88tQsi+FKe9O6j+9biRCiTIIugWeXULW
	bc5uA9PX+JSjs2AYBvrb4C0wenEAI65HmZn++QcCRz4ZgStHk3pE3XJ7QKG3KiE2RYhFTu
	xujcCe0X9jCnVVePb0zEFCO7o2XBowI=
X-MC-Unique: EVXCirVYMP2302s_yuqJ1A-3
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cUqdgOQXPuSI1oXr2pkuwiQniPve/4ZuV/jsDt5BxZz5ScgCvnvyFBjGBQCFe39jwtvCSId765GDeNmDDM13/MeP7JVB/dOIIEBx7UEyCT97ShrX+xuYyT2GnP/sPFA+gTVQ8pPsLNolzhSUStk3LsovaFgw6wVgiTPlVlIGnyRY9Wp0mVfgiKU/5RIN3vu3kUScMb/YHzfCYBB17EmT4nOFATiQLo6O+NR27dh7sY1D3ntFdwHGrwOSkxCLq0n2rHxdpPeC5j8I44oJ673UwpEbI183kppGlTqECHlEF2ScDS+FsC0RUiozcDz2IXi8UxGfwNgcbYVo347xCRjnrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pxr2FxyNIlWpLU43N2xrobkIYb4Dr4GMzwO2XMKzp34=;
 b=LM/Eor/qQSaDH4EHlIjm8FjkuYxgGm0WfwbBnZh1xORKqygfxZRoZkTmpfLmD4M+1J5vlq6cI9gJHvEDZ/pUCrR9lT5XCH9CcUKqRKNeJ7dEnfOMDq31ePfYWLY2VeQ1i7tM9ihn8A9s9Pn1bc5l+waG+LnQ8WRw3H9uHjJMq0xfzdCZDEooSK531IkX2mIk47jFl8tI5na4Magsk2+cxdSzccJQqcxaBDXg2o1UUmBIqHnhizIsYvaF8GKcxcLlyLmmxr3RRjivRygmU8QnZc+XPymqVVUzIuNlAnqYa5QixcE5RxVtgnujQU9LuHm9qSlMev3Sx9eIqg0+pVeguA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <JGross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <JBeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"wl@xen.org" <wl@xen.org>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>,
	"christopher.w.clark@gmail.com" <christopher.w.clark@gmail.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	"dgdegra@tycho.nsa.gov" <dgdegra@tycho.nsa.gov>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "dpsmith@apertussolutions.com"
	<dpsmith@apertussolutions.com>, "teo.coupriediaz@arm.com"
	<teo.coupriediaz@arm.com>
Subject: Re: [PATCH v6 9/9] xen/x86: remove cf_check attribute from hypercall
 handlers
Thread-Topic: [PATCH v6 9/9] xen/x86: remove cf_check attribute from hypercall
 handlers
Thread-Index: AQHYP4e1Btli+fX6E0anyJstROAZBqzl6g2A
Date: Fri, 8 Apr 2022 10:36:52 +0000
Message-ID: <85a8542e3eb6d5c8aa182fd291faca45d1c0ae9b.camel@suse.com>
References: <20220324140139.5899-1-jgross@suse.com>
	 <20220324140139.5899-10-jgross@suse.com>
In-Reply-To: <20220324140139.5899-10-jgross@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0937b406-08ef-4a92-6423-08da194bb23c
x-ms-traffictypediagnostic: AS8PR04MB8231:EE_
x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
x-microsoft-antispam-prvs:
 <AS8PR04MB823126810822BBCB83E23447C5E99@AS8PR04MB8231.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 IUEUWG2JRktRrWXajgo3fONp/4nMlw+yBFZdUsWDIrw7WW3Go5mRBag4M/RraZnIvMbz/OlboFBuYs0P3JiN2p9Dt/rdQaYRIOHmrL2INMbQ5AdLyDHPvNpQuxJZ5xkNfQCDH8NeulOk0c5egYRfhJq5Sor9jh85N3tg4xl++sL8NbozkfkTwqZ+0aZm5vn9/HaRoxO2V1XV1pK8Npu6O1IngS04rSLa7QsZKnOpOsL9O2STBfECK1JiLrK97ebZK0ZP7szMCMmHHjtHLz3J38+IPncrlYlW/S+dEwoKFtIEfSiFNINubXrcnjF2CZLmKJJvrrbmnvnwTEI/TkSNFiRKzdHz/tMfaIQ+hoVOx12bgTSLL9bec/pZTkG3MSA5ejJMHnyUYQebY9aNcOuDPPdrgSCuTd0XVemV8ckChEu54VhqoUsKH+lg1WgAPm2f6bggpJKRe6XiGWgYkNTZrOZC23Bw5Q9kfXohMU3+wIyOxvRKw028WVHMSfy7f5Gjvt7gK6ofJ8Nph/bvlT83ojKEt8JlQpugQldCZ1lVNR2AwzT48s8h//WO9ZDrN0uWGwZrR4QefSuk5Y9HaoW7vkJxUi+2HTHejn6B2YkU4p8qh06mS3ne/JQAnDYTasvKqt3tRPtXPrXZ4vaR2lISGvznchmRj1WLA0BVmE956mTnu4RJqkWkMObcqfHi9R4ip9uWF75e+kbGJbN/J2/vcPrn3j26dnZr4mdX1xA65o+ZovLUXLaJFspSdrXdX33IZQJB1ersN2Jdral5lfuWqL84Hb+55LHCyl0YG7vOFCejDbsFUbOxTe8BEy3UC7CvMwsDVE3WgSX8ZEoRltP7Xw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(7416002)(4744005)(8936002)(966005)(508600001)(5660300002)(86362001)(66476007)(38100700002)(66556008)(66446008)(4326008)(8676002)(76116006)(91956017)(38070700005)(66946007)(110136005)(64756008)(54906003)(316002)(99936003)(122000001)(2616005)(186003)(26005)(6512007)(6506007)(36756003)(71200400001)(2906002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dkxGYUxJM3JkcStEK1dvNmI3Q1RYa2t5Mkh3cGNBNi81NXYzRkh0Z3psclpT?=
 =?utf-8?B?S1Q2ZmNXbjBrd0RMV3VYMFJ6eU1WSGtqd2VTaWJkeVhiUHhvOTZrcDlaVEk1?=
 =?utf-8?B?TTZlVXBzNm4xTEdWZm1ZZEFDVzJXdHcyN2c1NVlZNkFSTlpZRlcxVWJOeTBV?=
 =?utf-8?B?dllHNllucHdQSnRncXVHbVJURmhyQUlhN2hTVzhJT3k2L3AxTTVSRGJCMnA5?=
 =?utf-8?B?LzZRMENiRmxsZElhOS9FMFJ4UXQwRkNqMmw3RFplV25YNzNCV0lMQ1MyUk1Q?=
 =?utf-8?B?ZGVKMHFWM3VGU2Uzdi94RmZDWG0xcHJwOVpYS1VLVTEzU20rZFhQbS9qZE50?=
 =?utf-8?B?R2tER25yQXFIdXllSXpmdVVyUFA0RHZkdXVScTRxQk5nelpSOUFzNlp0d2Ny?=
 =?utf-8?B?S3BHVlpESWNyMUErQmZPOVNBZ3N1bXgxeFN0YUwwMlJkMzg1NEl6dTllVU1a?=
 =?utf-8?B?SzUrNlg0a3M2emFVUVB3Wjd0NXdKMUtyN3lxeWY1bG51L0tkTVhRUmpoYjcr?=
 =?utf-8?B?c3RhdzZVazI0aDd6bjI2RHFOVlEwckxPYU4yWkRGN3N3NG9IZHF6aTFsRE5q?=
 =?utf-8?B?NTcrM05zbG9UNFdoMjI1cWEzR1NBc1hYSFNxWldZUUdFeFhXMFJoR24xSDhE?=
 =?utf-8?B?NVFZdVlmNXB1WEhSNk9kSWV1WTI1S1JmanV2aDJFcDhrdTUzUzhsZEVpUlZr?=
 =?utf-8?B?dllwWTF3NW95VUl5Ujh4RmhrNTFVUGl4UE85RHdMNXZ2UTQwdHNGaEcvZ0tE?=
 =?utf-8?B?aUlHZFZKRkNQN0JGWE5kYjArRVFzVU9pR3JYU0VoOHZrQ0lOMmtGQVUzQ3Ri?=
 =?utf-8?B?NTg1cCtTd0c0Q1JRbmovL25RY2E3cmNIZWdva1c1ejhza3pEZTBjZ3Nvc0p2?=
 =?utf-8?B?eWozT1lUNmVDU1NWT1N6RjBlN3NJa1IzcVVCK3ExSUxkeEFQSUxmV2xSMkFp?=
 =?utf-8?B?OGY2dVJJTHBORWFiUUpnVGZDNllSb2ZiaEJFeGlCSjVDMit4VEpIanViN3Nx?=
 =?utf-8?B?V3FsZElidWlWZFVwSHdGR2Yza1FnYmpOa250eS91eHovOUJZYlZsdjNpN3U4?=
 =?utf-8?B?OEFGNjVzd0Z5aXdLMk9lamh5K1RHWUdJZ3ZTUU5qTW9rZkpPMCs5dGc2RGlE?=
 =?utf-8?B?cHcwWnZwalVYTDloRXZlc0ovaXJaTWdFdWowVTIvdEM1QmZKRC9VUUwwYnMr?=
 =?utf-8?B?OUVHQjRWWEVRNUNVOEJ1d2gyS3huZC9QYUVHQ1dtTnY5UDgrZHVnNEM5bHZ0?=
 =?utf-8?B?N2VwL2NBQ3h4T0RKaThlTDU3REpCMG9aVXdQNU0valh2VXlSTGcxTjZZM1lT?=
 =?utf-8?B?NGwwTC9RV0FUNW1BTUl6cHVVVXFwejVPdGluL2VXSjlnQWxvbStCdU84c3pD?=
 =?utf-8?B?VEZYVlFGWENBTm1lU002S0h3ZzZTRXh6Y1F0a2lpQWxiWFVOZ2REbE9QZlZt?=
 =?utf-8?B?Rzc5UVRHZ0lkbUt1eUVjZ1c3NlJNeUNuZ2xpcGVkczJObnlOT05leGhMK2VP?=
 =?utf-8?B?YU81blc4cEowV0lsV0x0bkRTUUVja25lS3pDWTBvMXVmNjM5eTkvQ0VyMTBN?=
 =?utf-8?B?Z2dkRlhsM0lKS2tsVnB3ckV3MGh6WnpUN1l3Wjg1SkhZRGxJMFpLNnZkdXRO?=
 =?utf-8?B?SUxFZFI5SXNxbEJjZVpjVEZKakxKemU5SnU5bVFnREtITnJnVVNsWlp1RUJq?=
 =?utf-8?B?WlNseXp3L0llU2wzNS9Ja0xNYkJWNEsxQ29EN08yMXYzVGVTWUI0L2Nod1Mz?=
 =?utf-8?B?TDU3cERLTHltYkQyUlNlY2xzN1FCMEd1c2ZXNG83bFMyakRHU2VwRmMya2pq?=
 =?utf-8?B?ZmdRYm5HUjBjWkZsNHQ0eWlZcGM1bENyZ0FDdGxVQVlTU1pZL2cwZVBSZWli?=
 =?utf-8?B?aDA4c2N1N2pTZWpXK1JpTC9xNjhhZWlkOExRRDdrbFZOWHlzZnhiOSs0bVQ4?=
 =?utf-8?B?MjR5bnMzYkI5QkJCcFE1eHFSbVZ5bWhPMnhjeS8yNlFCVm90Ykp1ZGs1dnFX?=
 =?utf-8?B?U3ZIekRsZnI1NTA0Mk44TWIrZEJjRUlBUXlxekY3cFdwM2QzYTU0TU90ckRo?=
 =?utf-8?B?SnpXTDNDandiUkJSd0RZSVRpRUlEdmF3Rkw0U2w5cytMRE5lakRUS21ORkx5?=
 =?utf-8?B?dGozNnVhSlpod2ZoKzRTMmw5UUZaRzNLQ1o2N1NhSW5MYXBwT3UxSS9tTkFU?=
 =?utf-8?B?R2RTOUdvSVR3c3R4M3hWQWZQTGpwZ0h2S0sxdXJoeGNEUUdCWmR6UktvT2xW?=
 =?utf-8?B?U05aQ2F2Q2JsWE8rRnZWeHY5RS9BLzYxT3pQcU1ZdDF6S1Q3V0hPd05vNjUx?=
 =?utf-8?B?MjQvdVBqSk90UHFwdWxIclpNRGh4VU1iNUgwQndnQ2ZrT0taSWtOZz09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-FkS4YUeNE10+g+qGb+wv"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0937b406-08ef-4a92-6423-08da194bb23c
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 10:36:52.8953
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9TPz7Sxoqrq8sJ6a0NjEtlf51DRG4qljKcbBPdTjIPX+gUbq7mEtbRjrUl+Ee91oA8DRxiPPzy/qPVAzd+BLgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8231

--=-FkS4YUeNE10+g+qGb+wv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2022-03-24 at 15:01 +0100, Juergen Gross wrote:
> Now that the hypercall handlers are all being called directly instead
> through a function vector, the "cf_check" attribute can be removed.
>=20
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com> # xsm
> parts
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: T=C3=A9o Couprie Diaz <teo.coupriediaz@arm.com>
>
Acked-by: Dario Faggioli <dfaggioli@suse.com>

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-FkS4YUeNE10+g+qGb+wv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJQEEMACgkQFkJ4iaW4
c+75bw/6A7+0qUlVCN/KNSm41aY85S+FDRTzAV4C639E4MomzYztlBoOs5pNkMa7
MA9IXgsKV+0hfPGzTLrHd1xwLfA8JOzD7t/dzQR0XYchxVRi6+GVPtb0dwzrlmq+
bS5ho+94qXcashqfMwvpip83lP8n57n0N1Otm6yEMPUr2RoBieGWu1mgf2gZ10Yf
av2IDY5TCT5Q2NPkeqjESv04yXhpRYVBUFGnWKEx/YF9puEYoXYgREgEseJeBmhY
9czpaSvNafAodpir833UnUCQRVn2nqhqxGVTWc0xjoYqLUyfTb5wJ0OGfWpDuib6
RpQfDEahMVqKxzIA5DRoawjiFpKt4NUt024BDGzN+Dm3WNRRX3G8iMgtxCroSVEC
fDShvM0Xeg8kF9e14wmXzTdOpk2cznvr3+J5QVfK50vm71WEbap962u4/AbwZFVF
b4Qag1DgZgpqWULnEM89YPtEkBuaS57MIZw7pDu2ry44O8DuTjsP/4PQgTugi4lY
Nc3TGA8DmGxx76bgxFeuWnrfmMJAoBbsYm3emWp0wYxZMrHsw8O52qY+HvoiFfl2
/S2VD++OqfQ8jMNmeD2oRlH8wvBxW7xaVc5fiQDd6wksC7+/ymvW9MDarWocXz/o
DAKS5AWI52JcK+9BmPuPyH4RjjQMktDD7rbuu6nz3hmFeFNrbJE=
=eD2D
-----END PGP SIGNATURE-----

--=-FkS4YUeNE10+g+qGb+wv--



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:37:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:37:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301350.514276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclzS-00010J-Tl; Fri, 08 Apr 2022 10:37:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301350.514276; Fri, 08 Apr 2022 10:37:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclzS-00010A-QH; Fri, 08 Apr 2022 10:37:18 +0000
Received: by outflank-mailman (input) for mailman id 301350;
 Fri, 08 Apr 2022 10:37:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nclzR-0000w2-PF
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:37:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc490bb1-b727-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 12:37:17 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-gShiYJ72MB2u7-nJuhnYYA-1; Fri, 08 Apr 2022 12:37:13 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AM0PR04MB4419.eurprd04.prod.outlook.com (2603:10a6:208:7b::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 10:37:11 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 10:37:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc490bb1-b727-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649414236;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cogzCrZyJ1Tj6sTl/3vAb4/QkolEAe50Cp1WAOlNi2Q=;
	b=mdyLzAWaWBMET7fH17WidUrb6bIypR5d7Gwj2ZHU05dlTQalha7yeTxeHernumNkY4ySD9
	yJUsUdKarXb5SbpwsUNdcOP6jJG+des70N2J6gOnUZ479HTiFtkGID51PtHewuCGfcJL0+
	JxSMZziaFN1NRRLOR2cpmX5+aTnmf3U=
X-MC-Unique: gShiYJ72MB2u7-nJuhnYYA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gYA7Z9T9iuyNQfBkPMM2Vsfzpl+IwscV5WUkuhPXvirrqcLo2kmgd76HS+Y8bpN3HpYRcZwRgvXIhcX2yQ0Qq3rNNbdW9RIFuwHv0eblxdZOPPQKCqK06NIM0dnsGrvVu1Fu+gDyRzSjDWRQQOTyzzVvLwiw3mlxA8PaoMyejReO9FZya1b1UFWl0HIp6nahZG9mlXILA/hUfr2TW/Iv/9EpLKZ6mA9pfKxh+abbmwFP7HPhKmTR7uhpbFoG0KOKYqa1gvxy4wIE2HsUrUX1NiC2kzvTcARtJsbn9lAgUbQyhwqMyTdi0UmbvYZ2Vn7Asn+cgushVh7q9EiPQBX1yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+L8XbTYH5iN0XL/FNUMIrcVAFDUQX1nzM7sUDNTxEH0=;
 b=M8WczUwKp2u5uwuradTn6RoY+bJQxbONji8qdQR0QMtwglCJYeKlIKr2e0PCn4rbnyQ8/quH5/uQQMjdIN94xheSlyh61+gWqzoor6M7O9onncdMLQQ++F1e72zxDSJSZ7EzIIHCbXoC5deRUB1afbW4HM7QDxZDppuJNSPtpapD1wQ3eUgaXJZ8jWvOP1PxQShcLcVQxpoxevTsKnoQgtHQKNcdDyAKsk5tFUJJECwu1KnssgFksnRHKd3Ha/5Ol6G6dVeYQRSS1RUyDN6Ik/kQJxU64AqwUiGuZnXf4FEmRUVNZCyiQ0p9xsxZmz0lvZI/TaiCS9KBTj2T3cpNBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7be11e83-4854-1894-ee46-9ea23a66a5cc@suse.com>
Date: Fri, 8 Apr 2022 12:37:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220407145150.18732-1-jandryuk@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220407145150.18732-1-jandryuk@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0114.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::29) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 51687aa2-ff8d-4663-8682-08da194bbd5d
X-MS-TrafficTypeDiagnostic: AM0PR04MB4419:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB44196BB74D8A04D292359F5DB3E99@AM0PR04MB4419.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	X4zJiwHbkf7c50m6PbyAEi9HVDrpY8lmheOvepr9ZW7EupfF2HeXIJH3rCxGsjWf1doGoL+VLmUVenrIDK41oJuRxL3JumfXNcUTrhqOujhQlRELwgMgCfhJjCaTTnOZY41x5r78/l4tKBuKOeTNkkgWMu3xr+qaSZhKC7EbT+It/YgVtmc2OLcTh9R0+uiIs9UFVrc9o2+TCtGKO5iS27ZI5ZyCvZ4VebjvNfuKiqBmGx+xO8aALSPEPteF1j6BKFHAflzsGSWWNHL/VvZKV6LTuynOpy9gsIeV+PMcMvq+78o4lKXjV5/TIYxWS1YQMCTPoSz/bQEJvSKC5ZFCFmM3HfV8uG28zjJbTln24DGwBn8GWlv9cYxEu/Qe5m+KRukgmvq9/cjAuI9w5zDGUG1m6n69NGb4I8qSr6qROASEpyOgReVoLcfI/+yFhtxXXhiNTi1UYHrDLsGUPKVIj0lPcT+SZBHS3ECRMK6NvdCUUm4qxhiJtZaFJ8LH9u/jA4syVFiNeG+Bp1VqhbMYgr1aYth6tDea8gXuS+VKF2632b7aZrAFZO0xElBSjDu5GrHJX2IUQRzz3OS3nt4PBvph2N6gmwyArJLpO+577bPw17Jjj8KeJJM1BQ6JS0oR+j9fVlmukHhaRGPmG4Akm3/zIVKn90HehGKRUbkWfouwiF3lbb6g4SoAzxpR44K9V+t3TPvbwlsUv/hkPsatn0m/zgSg+8MJdY2fNIH2J4tmanaHwfbg4f2edpawwLYO
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(2616005)(6512007)(54906003)(6916009)(316002)(6486002)(508600001)(53546011)(6506007)(4744005)(31696002)(31686004)(186003)(86362001)(5660300002)(4326008)(8676002)(2906002)(8936002)(36756003)(66556008)(66946007)(66476007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BpWtpQ6GRn4TJW5kduU3zoolEW42GSC+1uuYQBazuwM4HVvwmO5pTwy1zzz6?=
 =?us-ascii?Q?IHdJgVGXHwyOYAAf5T4B9i6pEIDviAzP/sF/OQuPmXAbW1i2f+Hr8K+9+CpL?=
 =?us-ascii?Q?UDDiWmJKP2AseWnETpvLFYMrPyE0aLwMBCDR4hFzM5LBLTD7590G/doVIzpS?=
 =?us-ascii?Q?LkVkuDPShVq8MbXNOKfnY97QDEVMxJz3M7Eh62u+22aER4Rz/leavQQHCMgW?=
 =?us-ascii?Q?DUWw8fth7FWn5EY0Wazf+jjDyyQ4NB80WwI2xHch4X0i86+NKuGacmHBYWP+?=
 =?us-ascii?Q?IIs0+zcZLdMFNF4DTnRdfOvMeMqEewHulfFaiIxtspWbAEDthB8bmjXosH0R?=
 =?us-ascii?Q?FK+hvkg4TKZZRpgHh43Ab7u/kLhkWxMVFNZtLd+wFb/CXRE0XqttoYaizQho?=
 =?us-ascii?Q?66PtQc5hjf+jMhUTYQ9FKqCI4DDUpEjxUgu8/1hi+8ejCPQ3CnGUgJOT9KNd?=
 =?us-ascii?Q?UuQHC5rpTzNn7INDBMry8UjH1HHgBpzezZ2fyUIgcNwhfse2W8+acMYeGLpL?=
 =?us-ascii?Q?xq/t13Q8d+wEvXdYLYGXB3FdYZA32Fr3Xxqr81XKe8iANrqPjiyr1THVUKms?=
 =?us-ascii?Q?ev6CkWDkfeeSZRsZpdLNrDP4ezHanGavMoks12ZoYz4suzrCTInKRcqmoda7?=
 =?us-ascii?Q?m/K4JGTGlqK5c8ACodp3cuy9Al5bcjM+bdxdPIf2hRD8KonbKqFbCdV7SPEX?=
 =?us-ascii?Q?wq4GQmpg1NDOLJh483CWjsgmpQQw7xqUTvgWr7gJNp1hZ4Y+w1v7VerXxBSB?=
 =?us-ascii?Q?ixe8tDluQ8L50Kg4Pznrx1hcGsRN77kKcyH2McBJ3fH7uxBfCQzdukwQ4X1h?=
 =?us-ascii?Q?1pfqvvicTZxrzMHSPY9IZ+mmayPK9o6vkJOFfbcmfvPWsPUIvVPXpqUCNieC?=
 =?us-ascii?Q?Yj7FaRnQjg/fut/UV6ZGz+ERV5My+6BsUCnf/x/EWB0eJ8ECK1GxEAVI6BL7?=
 =?us-ascii?Q?8g3tJiedAWXbqFmWZ+/9avVt1tchj9fm/bFrAo2sU7ZY8XM2CYxN776HH/Yy?=
 =?us-ascii?Q?KZYfF2k1qrkBHyhuJXqJyLfigRHugp5X4Dzv34a4rg8Z0os/uaRvl8y8BLti?=
 =?us-ascii?Q?hSrZi+gZ5uIE0I+Ep4S3bBRFhOiu2konH1dD/44+ajPfSgTDhnw9DauFDn+J?=
 =?us-ascii?Q?DgPoxnOeso6qPESpYKGsDE0JetPZsxAW+12nl7I/+s2zW7b6GA0X1rg3DSV6?=
 =?us-ascii?Q?mh8wa3/eI/fyeqfxGw5tXN1Ie0ykYYh2MhJU3IWJ+O94Iq/GfG1zQne0xp5F?=
 =?us-ascii?Q?ZiiuwQ8po+vqU70Rr1A0OnKLGbl0VkE4ESwHGOaMrPxRL4+uB+IJwmCVrQCF?=
 =?us-ascii?Q?tgHMnmSvqQaRZhJNQawm/2t3zx8WvklmwNUJ9rZpCFf1GlsOzetqu5wAXvUx?=
 =?us-ascii?Q?L3pOYP9VXjQvsFWDL1A53SoRFhdhaUtNbR0zVv9qhUWfLgkJtD4i+kWH90D2?=
 =?us-ascii?Q?KbIvREweIuWidZ5fN8umb2gpGYj3PIU0riODSQcwHbk0SIMiCq3gMcS/5wnZ?=
 =?us-ascii?Q?0QNmUIwxQW983BmhW0hmvvhHPWVnBzg26oQ8KCj2sFBooe3CktXYrLnxeHDf?=
 =?us-ascii?Q?eHdcXjpdLWPd0/PHkYv6sWLoyk70ZsL7VBZ4K/BLDx+14mdX9vjfOXM9/fmU?=
 =?us-ascii?Q?9EjxWMhpjbuZQoqQyQNkW/fSZmd8ty6RPsXA3f+feoxETEbY748uu5MVg9Ys?=
 =?us-ascii?Q?r63P9XJDMjUGd8lObxkvtruCv4qlwPEC6arr7eRQGMheG4U0WHseHZ9gQkVg?=
 =?us-ascii?Q?YWooZpGbDA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51687aa2-ff8d-4663-8682-08da194bbd5d
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 10:37:11.7548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 31nuASMhJJGUEdud0D+g4qqZUFxjxO8wfaMQSMACXtMUlSODxji7ifkO1mh6fqJ+L2iPPmXiTgNw/NvdWJjjNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4419

On 07.04.2022 16:51, Jason Andryuk wrote:
> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
> complete_domain_destroy as an RCU callback.  The source context was an
> unexpected, random domain.  Since this is a xen-internal operation,
> going through the XSM hook is inapproriate.
>=20
> Check d->is_dying and skip the XSM hook when set since this is a cleanup
> operation for a domain being destroyed.
>=20
> Suggested-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:37:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:37:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301351.514287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclzY-0001MM-9z; Fri, 08 Apr 2022 10:37:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301351.514287; Fri, 08 Apr 2022 10:37:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nclzY-0001MF-5g; Fri, 08 Apr 2022 10:37:24 +0000
Received: by outflank-mailman (input) for mailman id 301351;
 Fri, 08 Apr 2022 10:37:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lx0l=US=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nclzX-0000aA-0g
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:37:23 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df5a035b-b727-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 12:37:22 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id DAAA21F861;
 Fri,  8 Apr 2022 10:37:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8B051132B9;
 Fri,  8 Apr 2022 10:37:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6Q5YIGEQUGJjYwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 08 Apr 2022 10:37:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df5a035b-b727-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649414241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=fzY6e9FDGSdD+Ov6uU4u4SnAC0ql/VbLnal17jJ5tbc=;
	b=N5YybeliQp0Oa/gjLfVooNtQabYCr0PI2Mpx501CBZ4qHwyYmDiy+GzSfQ6Wg3e00jNxQj
	UhedkNGv94FDc9tSWZFjhjeju8/EnN1tND3P9XbTa8thWg3Eo2miFRvVU9SF0uSIlEL1/j
	PG7MV2gzwQDCgG3fes3m4NL5qoSfEEw=
Message-ID: <795479a7-4bc7-3538-373f-1ae79bfc27de@suse.com>
Date: Fri, 8 Apr 2022 12:37:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
In-Reply-To: <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------WPYb6qRMuhoPAByKX06WUwcR"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------WPYb6qRMuhoPAByKX06WUwcR
Content-Type: multipart/mixed; boundary="------------QXab3Ts7nGmiLyzqjZMxNXLn";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <795479a7-4bc7-3538-373f-1ae79bfc27de@suse.com>
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
In-Reply-To: <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>

--------------QXab3Ts7nGmiLyzqjZMxNXLn
Content-Type: multipart/mixed; boundary="------------Fir2hz04VniXn9UV0TVDV0Yc"

--------------Fir2hz04VniXn9UV0TVDV0Yc
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDQuMjIgMTE6MTAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwOC4wNC4yMDIy
IDEwOjQ1LCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4gQEAgLTEwNiw2ICsxMDYsOCBAQCBz
dHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4gew0KPj4gICAgICAgLyogUGVyLXZDUFUg
YnVmZmVyIHNpemUgaW4gYnl0ZXMuICAwIHRvIGRpc2FibGUuICovDQo+PiAgICAgICB1aW50
MzJfdCB2bXRyYWNlX3NpemU7DQo+PiAgIA0KPj4gKyAgICB1aW50MzJfdCBjcHVwb29sX2lk
Ow0KPiANCj4gVGhpcyBjb3VsZCBkbyB3aXRoIGEgY29tbWVudCBleHBsYWluaW5nIGRlZmF1
bHQgYmVoYXZpb3IuIEluIHBhcnRpY3VsYXINCj4gSSB3b25kZXIgd2hhdCAwIG1lYW5zOiBM
b29raW5nIGF0IGNwdXBvb2xfZGVzdHJveSgpIEkgY2FuJ3Qgc2VlIHRoYXQgaXQNCj4gd291
bGQgYmUgaW1wb3NzaWJsZSB0byBkZWxldGUgcG9vbCAwIChidXQgdGhlcmUgbWF5IG9mIGNv
dXJzZSBiZQ0KPiByZWFzb25zIGVsc2V3aGVyZSwgZS5nLiBwcmV2ZW50aW5nIHBvb2wgMCB0
byBldmVyIGdvIGVtcHR5KSAtIErDvHJnZW4/DQoNClllcywgSSB0aGluayBkZXN0cm95aW5n
IG9mIGNwdXBvb2wgMCBpbiBhIGRvbTBsZXNzIHN5c3RlbSBzaG91bGQgYmUNCnByb2hpYml0
ZWQsIGFzc3VtaW5nIHRoZXJlIGlzIGEgY29udHJvbCBkb21haW4gYmVpbmcgYWJsZSB0byBk
ZXN0cm95DQphIGNwdXBvb2wgaW4gYSBkb20wbGVzcyBzeXN0ZW0uDQoNCk1haW4gcmVhc29u
IGlzIHRoYXQgY3B1cG9vbCAwIGhhcyBhIHNwZWNpYWwgcm9sZSBlLmcuIGR1cmluZyBkb21h
aW4NCmRlc3RydWN0aW9uIChzZWUgZG9tYWluX2tpbGwoKSkgYW5kIGZvciBjcHUgaG90cGx1
ZyBvcGVyYXRpb25zLg0KDQoNCkp1ZXJnZW4NCg0K
--------------Fir2hz04VniXn9UV0TVDV0Yc
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Fir2hz04VniXn9UV0TVDV0Yc--

--------------QXab3Ts7nGmiLyzqjZMxNXLn--

--------------WPYb6qRMuhoPAByKX06WUwcR
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJQEGAFAwAAAAAACgkQsN6d1ii/Ey/E
twf/djZMvyq02pvicvrk0xFreUrEPSS9Bt3kE/sdrMwjtobDwLgtYUQYGHmfBKbEugnFqfSgw7x0
xwGJslm8DmbBXVKX5SuYlfAgvg0H79DS81ES3E5yXyTlUBO7122IAY4wdvQfxcY3fiC3W2Z/51us
0ffT38RSUGltZFxcwoJ7If/xgTfK5zgP6HxLzXsyWU7NfvONLv/04D7CGbPZX1pBDwUEnrOuNCtq
J4QeQyOp7LtOoKQ0SIRLazsSLg/VPysNS/qL2qTyLdFWm38mIaXOfzoTii5ZcZNIZidzMuRfiZqU
lEcc3Xx5MJsddaJEcCoDxdAijDnxUgccSB1VwFupGg==
=1AX6
-----END PGP SIGNATURE-----

--------------WPYb6qRMuhoPAByKX06WUwcR--


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:42:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:42:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301365.514298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncm4K-0003Rn-S7; Fri, 08 Apr 2022 10:42:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301365.514298; Fri, 08 Apr 2022 10:42:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncm4K-0003Rf-P0; Fri, 08 Apr 2022 10:42:20 +0000
Received: by outflank-mailman (input) for mailman id 301365;
 Fri, 08 Apr 2022 10:42:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ncm4I-0003RZ-PX
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:42:18 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20605.outbound.protection.outlook.com
 [2a01:111:f400:7d00::605])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7747f20b-b728-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 12:42:06 +0200 (CEST)
Received: from AM6PR01CA0059.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::36) by AM9PR08MB6675.eurprd08.prod.outlook.com
 (2603:10a6:20b:300::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 10:41:23 +0000
Received: from AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:e0:cafe::e7) by AM6PR01CA0059.outlook.office365.com
 (2603:10a6:20b:e0::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25 via Frontend
 Transport; Fri, 8 Apr 2022 10:41:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT044.mail.protection.outlook.com (10.152.17.56) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Fri, 8 Apr 2022 10:41:23 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Fri, 08 Apr 2022 10:41:23 +0000
Received: from a26c190004dc.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A9EF81A7-BCD7-4EDC-B734-F10C5043D52E.1; 
 Fri, 08 Apr 2022 10:41:16 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a26c190004dc.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Apr 2022 10:41:16 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM8PR08MB5859.eurprd08.prod.outlook.com (2603:10a6:20b:1c6::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 10:41:15 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.025; Fri, 8 Apr 2022
 10:41:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7747f20b-b728-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3Qk8r6tMph7YlJ0wonA36vDVHlkC5Llyql8w+K4+Rr0=;
 b=xdWTHisaZCpTxc9hnNpNNSGKiwdz25uOkZrRa+Rtpr5b4r9tjZnlN+EGhpHWzjgjbUpuADaa0tVWYFg3HKbcNoWDAwEbTM1n6S0P9tHTfg2AGIOgeYbLDs7tmzfBcwDhMl9kh/Xk8sdCLgUvENc7KYWHEfZF+90I9ldj2xiYhw4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 18711b6413794e32
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jQsg5J+2W/m2Is+Yhn0xeU6RzHXUinEDVGaLp1UKOkOi4OQiPBIUuPHqD0rhKf/uGzr33zj8lufaH4n9K5rrct4QGHtK7hHrCWCfsS1DE19qbWPwscg4l7QFk0FYgBW5EvxqhIrCtX3gWF7/4OySChOHwHSNNVbJ3acr6v7SIqwE3Ev6h2TjcqdgZ4L/KP5eXCwFr7eTjYyu52RtcreVO1GHnzTiEHabkyFHANu+z+Xr9jKeisBiixuxG3Bp8YUGEcWmT+VlpEz1P5j2DI9UDJTL6mjRepX1X23pd1pYwXsMP+27BBxYlSpcYrWkOSok6tir00XT+YDeWJZAQRQ7+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3Qk8r6tMph7YlJ0wonA36vDVHlkC5Llyql8w+K4+Rr0=;
 b=e5zQE273TN6SdqznA5jlG2Gbn3Uclk6HJKU3HQb+AJ/R6Aw5ktBUO+gUT8n6EUiySL4tKmo1GkaK5skuQjqpnSoRL/TSi+q83tGwrXIyPgvAGx8KGsoxEUMBK662/h09Pi4jmhpEVkH+sFjTZ8E4C+Wdg/x4auE/47BSHIQvNNP1KLQ5FBElCXVFgkbtqdgf48SNofls1sDM5xk1B0sIikNVoQhsiEVXBddSOUsKoOx4X4FxigyzWBbG50K/i08/624UKGGhf20vX2xfBR/J8Rxm9jsiBye/aZHqo8DZdSC7lqHKpy9LWscIirNUwC8FI482tM7/0/U+U9de4bU3UA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3Qk8r6tMph7YlJ0wonA36vDVHlkC5Llyql8w+K4+Rr0=;
 b=xdWTHisaZCpTxc9hnNpNNSGKiwdz25uOkZrRa+Rtpr5b4r9tjZnlN+EGhpHWzjgjbUpuADaa0tVWYFg3HKbcNoWDAwEbTM1n6S0P9tHTfg2AGIOgeYbLDs7tmzfBcwDhMl9kh/Xk8sdCLgUvENc7KYWHEfZF+90I9ldj2xiYhw4=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
Thread-Topic: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
Thread-Index: AQHYSxiRdnHI8V+CTUSAwReJymUaGqzl1CMA
Date: Fri, 8 Apr 2022 10:41:14 +0000
Message-ID: <920E9874-E720-4536-B5DE-5222948DB1EE@arm.com>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
In-Reply-To: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: b2ef3eb1-a890-4623-6e97-08da194c5391
x-ms-traffictypediagnostic:
	AM8PR08MB5859:EE_|AM5EUR03FT044:EE_|AM9PR08MB6675:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB66750CF3A508F3D3B2D00BB2E4E99@AM9PR08MB6675.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 xfGhXsU5gC4vRRl+nxUESjVI+Ckz2mue5tVx4dSDb45wv6/KnIQWp3tNEJk2cRIFmreztaZyuhXCZNVGiY853qSMywPoxKQoP+6uT4NhRennSyWmccoADxRokQK5RMNcMuF51pBg1iR67tYRAq3BVMl4pXXq9enVfhNvhDCFebYlkYt924Jkc62EWlobWYgGwh3Cm2f/MYJaPb5OmwgpBpuApQTiFd15QR5z4sEH4Ek/T29WKNTVOEwJAj6aw46y3/Dk9b6UtrJBph+YI81y4y/b3Q2MNW5ngrXqeXRDEJocN2WJxxtHdIvqFk4KDwSwEcAYEmM8831RUhrOXJ1IxSUywjpHQim5S4/74/9HYl8JGTNgkzTIbFewfiKUiafQ+eL9PQl4dQu1yjd2reMXKwN8ViGVqfNRAuzfgJLPc3VP4Ji8A6QmTjv0WD8j3lUPLLQPF81k9nFy6dVKO9DYugi78KJAnBV7N36Hs65qyN/BZQcv+F6FgHACbiIUCdKphoDT4c4K8dy55PD6tx1pyh1zcPLhwsqcdFDvMpk4kwvEI7aYGyaLZQ9uLakE/RB6DKMBxK6PGyEXNK31n3UqqsGWjSg8LVFZZbB1APqIepZNYgyvW7g8VreZvIQiZ1AuywGCZ6K395CUg1Eee+WI5SNiX0e4X+m7ODb/LaSQalAImmMo2zgBHbjBXwigzQns8wKX8yJXw751o3WnQBjom3m0wiKy6s2gN6y3A7hBaQKC3pol9WE3KOlUfHQMAYkx
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(6486002)(8936002)(508600001)(5660300002)(86362001)(66446008)(38100700002)(66556008)(66476007)(8676002)(76116006)(91956017)(4326008)(66946007)(38070700005)(64756008)(6916009)(54906003)(316002)(53546011)(2616005)(122000001)(186003)(26005)(6512007)(6506007)(83380400001)(71200400001)(36756003)(2906002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <B838E085B0C58141884E037E8DE703A5@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5859
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	722ab166-a805-45e0-adaf-08da194c4e2d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hL6wKI/64jgdroBpVUwO+xhKr/AlADBlgGF6JBO+dK6tPIKZCfWlVDFEADjPpZcDcsWu2/oY2K/ZTzC7wIMCQFSwrwVUgiPMDSU8hVoyzICJwXxs4/tlA95V4E2fLSAgfigPXalmQ1Q/W7Us+b07WBFeBrTBI+xlS85t+J5eR+IyjX72rckxY1WQstOQ4xWNan1puKpuGBHwMg7g8gG0nlh6WN5nUsHEMXjwxzN9ir6x/47iKMIA0jm4lbXuGvHFHsKYyDbsxawuzpTMhBs25ZJ98BMWE6A0O55AjbP0ilHcyGLYQv+iyENC2QoXje5XdLeFje0k8n91hOy4FrZCOwDp3JEPtu6vyIdJ9nHfjF1nowoaGVdWGZa2jbvfgYBzsb/EfhjgJNJ0hmzoSHswcXe9ccW2m0i9vFOXQ/QkAAT4fUyqGA9AVWencxhwppyk3RuOvEy599Vj6sOd8Khgy3LELTtAWCVu4cdQGUoQl6PZ8o1LSPGHvv7DzzxD4VRGZae1c05D8q88HHx7pmp/yJOWKRfmCP9Whwz33Ng+ja0pTNVeaNSh9hy1Cs8tb4Z9XDMQiY/XTjzxyd9qxeIX5RbQ1k7X7N1th4zU+vl28qOMDx+TgqBQxvm7ISpm/nhG3UHNBvu/GBjqKDMKQ6jLt3aSagSn1j3+x2VJaWeLeyoWy1gft0xbN60IHqXhbF6D
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(86362001)(107886003)(2616005)(26005)(83380400001)(186003)(70206006)(8676002)(336012)(356005)(36860700001)(81166007)(47076005)(6862004)(4326008)(316002)(36756003)(33656002)(8936002)(40460700003)(54906003)(2906002)(82310400005)(5660300002)(53546011)(508600001)(6512007)(6486002)(6506007)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 10:41:23.5970
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b2ef3eb1-a890-4623-6e97-08da194c5391
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6675

DQoNCj4gT24gOCBBcHIgMjAyMiwgYXQgMDg6MTYsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl
LmNvbT4gd3JvdGU6DQo+IA0KPiBTZWUgdGhlIGNvZGUgY29tbWVudC4gVGhlIGhpZ2hlciB0aGUg
cmF0ZSBvZiB2Q1BVLXMgbWlncmF0aW5nIGFjcm9zcw0KPiBwQ1BVLXMsIHRoZSBsZXNzIHVzZWZ1
bCB0aGlzIGF0dGVtcHRlZCBvcHRpbWl6YXRpb24gYWN0dWFsbHkgaXMuIFdpdGgNCj4gY3JlZGl0
MiB0aGUgbWlncmF0aW9uIHJhdGUgbG9va3MgdG8gYmUgdW5kdWx5IGhpZ2ggZXZlbiBvbiBtb3N0
bHkgaWRsZQ0KPiBzeXN0ZW1zLCBhbmQgaGVuY2Ugb24gbGFyZ2Ugc3lzdGVtcyBsb2NrIGNvbnRl
bnRpb24gaGVyZSBpc24ndCB2ZXJ5DQo+IGRpZmZpY3VsdCB0byBvYnNlcnZlLg0KPiANCj4gU2ln
bmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpJ4oCZdmUgdGVz
dGVkIHRoaXMgcGF0Y2ggb24gYSBKdW5vIGJvYXJkLCBzdGFydGluZyBEb20wLCBjcmVhdGluZy9k
ZXN0cm95aW5nIGZldyBndWVzdHMsDQpkb2luZyBzb21lIG5ldHdvcmtpbmcgZnJvbSBndWVzdHMg
b2YgZGlmZmVyZW50IGNwdSBwb29sIGFuZCBldmVyeXRoaW5nIHdvcmtlZC4NCg0KVGVzdGVkLWJ5
OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCj4gDQo+IC0tLSBhL3hl
bi9jb21tb24vZXZlbnRfY2hhbm5lbC5jDQo+ICsrKyBiL3hlbi9jb21tb24vZXZlbnRfY2hhbm5l
bC5jDQo+IEBAIC0xNTU5LDYgKzE1NTksMTYgQEAgdm9pZCBldnRjaG5fbW92ZV9waXJxcyhzdHJ1
Y3QgdmNwdSAqdikNCj4gICAgIHVuc2lnbmVkIGludCBwb3J0Ow0KPiAgICAgc3RydWN0IGV2dGNo
biAqY2huOw0KPiANCj4gKyAgICAvKg0KPiArICAgICAqIFRoZSB3b3JrIGRvbmUgYmVsb3cgaXMg
YW4gYXR0ZW1wdCB0byBrZWVwIHBJUlEtcyBvbiB0aGUgcENQVS1zIHRoYXQgdGhlDQo+ICsgICAg
ICogdkNQVS1zIHRoZXkncmUgdG8gYmUgZGVsaXZlcmVkIHRvIHJ1biBvbi4gSW4gb3JkZXIgdG8g
bGltaXQgbG9jaw0KPiArICAgICAqIGNvbnRlbnRpb24sIGNoZWNrIGZvciBhbiBlbXB0eSBsaXN0
IHByaW9yIHRvIGFjcXVpcmluZyB0aGUgbG9jay4gSW4gdGhlDQo+ICsgICAgICogd29yc3QgY2Fz
ZSBhIHBJUlEganVzdCBib3VuZCB0byB0aGlzIHZDUFUgd2lsbCBiZSBkZWxpdmVyZWQgZWxzZXdo
ZXJlDQo+ICsgICAgICogdW50aWwgdGhlIHZDUFUgaXMgbWlncmF0ZWQgKGFnYWluKSB0byBhbm90
aGVyIHBDUFUuDQo+ICsgICAgICovDQo+ICsgICAgaWYgKCAhdi0+cGlycV9ldnRjaG5faGVhZCAp
DQo+ICsgICAgICAgIHJldHVybjsNCj4gKw0KPiAgICAgc3Bpbl9sb2NrKCZkLT5ldmVudF9sb2Nr
KTsNCj4gICAgIGZvciAoIHBvcnQgPSB2LT5waXJxX2V2dGNobl9oZWFkOyBwb3J0OyBwb3J0ID0g
Y2huLT51LnBpcnEubmV4dF9wb3J0ICkNCj4gICAgIHsNCj4gDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:55:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:55:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301373.514309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmGg-0005AP-SS; Fri, 08 Apr 2022 10:55:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301373.514309; Fri, 08 Apr 2022 10:55:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmGg-0005AI-NS; Fri, 08 Apr 2022 10:55:06 +0000
Received: by outflank-mailman (input) for mailman id 301373;
 Fri, 08 Apr 2022 10:55:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncmGe-0005AC-VM
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:55:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncmGe-00008x-3m; Fri, 08 Apr 2022 10:55:04 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncmGd-0001nQ-TI; Fri, 08 Apr 2022 10:55:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=wbyQUubja02MTYVxYT+xYePWDImUwKRn/G8jmpE1IRI=; b=VgJ2XqKwzHXf9a4SX9ALtLMM/4
	ETMSyM/Qc7kQ6YNaTM0bR2DXpegLbjdlzqjm7ugRXRpQqQ3cPKQVAIEG8+2j9btxjRm6q7uWs/BEm
	MZrzyT2EW0EJRccuKD5WOQmo/w9KMgfmq8Ui7RE5jkYRj3LP2pObtynq1QAHbhw0v4fw=;
Message-ID: <a2b530c7-7b20-df44-7935-9d448f617bf3@xen.org>
Date: Fri, 8 Apr 2022 11:55:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
To: Luca Fancellu <Luca.Fancellu@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
 <920E9874-E720-4536-B5DE-5222948DB1EE@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <920E9874-E720-4536-B5DE-5222948DB1EE@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Luca,

On 08/04/2022 11:41, Luca Fancellu wrote:
> 
> 
>> On 8 Apr 2022, at 08:16, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> See the code comment. The higher the rate of vCPU-s migrating across
>> pCPU-s, the less useful this attempted optimization actually is. With
>> credit2 the migration rate looks to be unduly high even on mostly idle
>> systems, and hence on large systems lock contention here isn't very
>> difficult to observe.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> I’ve tested this patch on a Juno board, starting Dom0, creating/destroying few guests,
> doing some networking from guests of different cpu pool and everything worked.

FWIW, we don't support PIRQ on Arm (alloc_pirq_struct() will always 
return NULL). So evtchn_mode_pirqs() is basically a NOP.

This patch has the advantage for Arm to avoid taking the lock for 
nothing. I will comment on the x86 part separately.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 10:55:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 10:55:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301374.514320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmH7-0005d0-3S; Fri, 08 Apr 2022 10:55:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301374.514320; Fri, 08 Apr 2022 10:55:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmH7-0005ct-0E; Fri, 08 Apr 2022 10:55:33 +0000
Received: by outflank-mailman (input) for mailman id 301374;
 Fri, 08 Apr 2022 10:55:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncmH4-0005cW-Re
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 10:55:30 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 660eb0a6-b72a-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 12:55:28 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 660eb0a6-b72a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649415328;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=7wynkonSg8ayrlwGklHn10sleZpJHNxYCY2oWzcqqAs=;
  b=WDXSulMNJwFcdVaMaaBYRATpubuxsCJzaFOixzrxGYzHKIbIXbiRTqrr
   H4iBh9dIOO1sCB10oPzNdBypoyyhkOsDLr11YHpcdV9SrYXG4FVViqfJI
   39iBfiFYblvOw9/aPz5aQMvdTrB4v0I3IyO+htDrv8OLo9FbCtgWKxYrp
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68355068
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1GFykKjtnmJEBjgxyX9ut1HFX161ehAKZh0ujC45NGQN5FlHY01je
 htvWzyHP6uIMGHzKdlzaoi+/E4B7ZWAnNZhTldqpC0xEyMb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vd4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YRVxZ7f0x7Reb0AbKwB+MYAc/YPjIkHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiOP
 JdEMWQ/BPjGSxtoEUUNLJM3peepjGKlIi9gpUCfvqVitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRGhgHMPSPxDzD9Wij7sfNly7mXIMZFJWj6+VnxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEAWFmdbUIN29/NvBgQL1
 lOkxdbVIT9W5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn
 mvU9HRWa6A715Zj6kmtwbzQb9tATLDtRxV92AjYV3nNAuhRNN/8PNzABbQ2AJ99wGelorup4
 SBsdyu2trlm4XSxeMqlGrhl8FaBvavtDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib
 Sf74F0NtcUDYSb6MvAuOupd7vjGK4C6SLwJsdiOMLJzjmVZLlfbrEmCm2bOt4wSrKTcuf5mY
 srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepVYTOmM7FihIvZ8Vq9z
 jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8riq85cHKbPZelMO9aNII6a5/I7NsrdNxsx9vuzJ4
 mu8Sglfzl/+jmfAMgKEdjZob7aHYHq1hStT0fAEVbpw50UeXA==
IronPort-HdrOrdr: A9a23:YpTOMaw/a686HeoPCr3HKrPwIr1zdoMgy1knxilNoH1uHvBw8v
 rEoB1173DJYVoqNk3I++rhBEDwexLhHPdOiOF6UItKNzOW21dAQrsSiLfK8nnNHDD/6/4Y9Y
 oISdkbNDQoNykZsfrH
X-IronPort-AV: E=Sophos;i="5.90,244,1643691600"; 
   d="scan'208";a="68355068"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AFEy1xJU4Pw1e1RN+UoMsCX3xUMab1qqy8jqj8+Sgx3gIqsmnKm2CY8vmGTZhGB71w+ocQ8fz5z0dIogccbOqw7KsIjq55dzBcY2/Nr4AEWcXP6phvunJqUzN4bfC3zyXsfFEc0bkYLCegZBg4NUpxCCvj+cBqjUeQynQthBWhi8n3jnYbVgceZoWEGAsPGfOLac+3nteVqNJNIFlOVCjmLXdHMKt1bdCDEluWgRGm2oM8tQ7F1fLtDSwAvbrlRGHNtri7DzNbL2YCJzhpXmraDLTglG2wqityYhNObL26z78bXf10YNqdAhSvxKLguSL4fnZ3yan3bpy7ySr9YssQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dPIji40V/ZjD/odqpInMrAyzokkt4ybmnCbHG3Pc8vI=;
 b=lA6XuJkZbptCTch7+SWzsLbDqirUc3mlU9aVMbCOjSYkFlachnX8fOxQ6kE2DGy/dgbmufKaCknpDLJrOHjDdQunz5lo0i2IV8ZD8Sdhlm1AHyG80msij56qMq+ah5xLii7R/7+KJnLpLf6WRmrGMwq0U9YhSVj5isjwEIdaX0K5fvOLDGDI4M305nczFimVBMA/GycNESTAlXQwKcyUPPgNJevb20MZvfeC02YQKbxf9NHUrUWlZNRBPNpdW32oRDIABDUBCQczGGACky8QtQlQVhDCEmIsX2f2J7cgaRGEY3Ku2Xg5P7jcdyOQ/E/T5STeD0z44LuuXw/zpxITrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dPIji40V/ZjD/odqpInMrAyzokkt4ybmnCbHG3Pc8vI=;
 b=EOhKzJw/WMT8vLAMCB1a2KLMXXGqrvgfBUCxPoEkkz85GR6jkp8SxOk4mU54QrNOLIcT1XygKfkJwHLxtnJwO4f1uif8hh91+hWBN0R5n1edrU9WBy1t6zInuNVtApCkJJmilgSKKWNDOXY18XgUDiZwecjrZgqUz5KFWtsVOWY=
Date: Fri, 8 Apr 2022 12:55:18 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV
 and HVM parts
Message-ID: <YlAUloDvk20Y01tn@Air-de-Roger>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <69623630-cda7-9b2b-4f2f-09a83d5dc22a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <69623630-cda7-9b2b-4f2f-09a83d5dc22a@suse.com>
X-ClientProxiedBy: LO4P123CA0304.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 942066b4-5c89-4333-94f3-08da194e47aa
X-MS-TrafficTypeDiagnostic: CH2PR03MB5157:EE_
X-Microsoft-Antispam-PRVS: <CH2PR03MB51577BAAE283F1F1848E3A3A8FE99@CH2PR03MB5157.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3CUR7PiydanLkdn7OXWiLbGD2nkiw7ZgYLSRZMv4n9C0I8nogHZeTzAyHZePrfGgxNCNqXizl3bGOMbMeWpFSsG6XmJAIylff14YrR/gwx2gq0bMc/8aRJBzF+dw8zdSkfAUgBW/F+RO15vbhijGdwpp1f1RrpplPzAeolNvC3jGMGzcNLnnBobFHxxGcdnxXC2BTj+MxSk8RDzA3PVYCp07u7oUpxiU1DO7wX1YnA9R4/GJXHh8nMEneCFYAoqTn2jupIvp+9Prd3wfqLrqNv/8c2cM++bJ6DY3kfnTVyX22Uz6OGa5jlmNxLijhCK6NDGUpnAk2INW777/tMtC7gGWzBByU2yOT56KEAlEnmPkmXu4bOFZ0op4N4yCUWtMItZzzYD8QqruU6oUW6npDZOHHMxJKKEzBLRPp+hgBmdtRQVEUAUbkB+JaIkS+BaJtcL7xUd1O7XDRg+qf9TgJ4W8MHG7sB+5Ch9qZ8MoMrDnBpMGS/AxNmVD0cFAKAVAXy+BwkEgOqcUarXXazvDN681F2WGicf/dCU+AcEnDmJSmIVM9KL1m/xrcO/qbymkUGZXdXhr4V2lHBLXNSYKxIisyaywi0HUkQInutw8SaTKcKUgAr7AZ+ZdHZH1MuQ9mtasP09RLNBMPRUfOLoIxEpG13pzwWC05rZTA/Uzays9xheplljHQdX9VmRwb3AOgR82A5QIvKi4LrKnC+tRIQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(8936002)(82960400001)(6916009)(5660300002)(4326008)(8676002)(38100700002)(54906003)(33716001)(316002)(6666004)(86362001)(2906002)(85182001)(66946007)(66476007)(9686003)(6512007)(66556008)(26005)(186003)(6486002)(6506007)(70780200001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkNxNVZpT296WWJyaGFCbXRpYnhLRE90WW1VK1lLaUN2NUc5UVVCNHZpTEJH?=
 =?utf-8?B?bXY1dHVvTGJYZ04wanJYVEtPK054MTRUdEJ3eHhBek1aQ1NlSEI2cmtlelNT?=
 =?utf-8?B?RHBsZThENzRaR0RZL2Nyd0t6OWQ4ZEQ3ZUdqdXNyR04zNWw3SSsyTEE3U1h4?=
 =?utf-8?B?aHdxdC9nc1FiNVZHc0xGbEtFcHNiSi9jMWYvZ3cvV0FoZFFXcFpuZ1p6NjFG?=
 =?utf-8?B?Vy8zR09Gcm5kZHhVNHpvbHpvWG82ZzZLcUVFdmhrQlU4V0F0b3pQU2s4NGk0?=
 =?utf-8?B?RzVuUlpDQXpkY3dXS3BjOUhQRDlPTVRZc2g3aFVnN29rN01xM3IrZkdzOVhL?=
 =?utf-8?B?YVg0MWFZeEdXemZJcStnd3dqdk9vbEY5SnlBWWVoL0w0REM3RzNMRnA0VHdZ?=
 =?utf-8?B?RENXNmxlcm04Q2R3U2kvR2twSG9kSzdiank1TmVEaVRCV1lFV0VEbGNqSjVa?=
 =?utf-8?B?T3BPQzc3WVRoaUt5VVV5TkExd2JQOHpKQWk0QVpZYXptNllHK2tEeWdVS1Nx?=
 =?utf-8?B?UmYvRUxBZ2ZZOVhHb2wvVzMxWlh2UmlJRCs1SDhrNFBMTzRqT3RnRFJBZVNN?=
 =?utf-8?B?UjN1eTBUZlgwdGVYWWgzZTNjbDJkaDAxN1lVRkIxM0Z4ek1UQlFJS2tlSDZP?=
 =?utf-8?B?bndzbVJJMCtKMDRMS0E5aUNZMjZiM2JQNk1QdHNySUE4dDZHMldOS0RYMDNF?=
 =?utf-8?B?UklSM3hPeWU3VnhrUiswNWNzVFhYYmNGcHRJQU1CSVdhMWQ1eU5BVmlTY0Vi?=
 =?utf-8?B?a0w2b2ZscGtvSFRTWE81bzB0eUl5S3E2cXBhQ254ZU0wd3F3cC9tR1BXRXM3?=
 =?utf-8?B?S0FPKy9Pc3FVRlRCYkdEVWp4elF6K2tTemYvU05leGR3Z1VVUkVuUjlialdm?=
 =?utf-8?B?R1N0TDR0NHpSUFFsSUptR0toeGNjK0xJV05qYXRBOEUvdUZKalB4RW16YTNI?=
 =?utf-8?B?aUtQRnJibjRLV2F1MklTNlA1UittcDBrejZ3bjNqQXBoakM3Y2g1ek9nM3c3?=
 =?utf-8?B?YUlzdWNFNm9GQldDK1dYUmZiK21ZelhhRTM5aXZRemVraENEYXI0Q0sxZEV0?=
 =?utf-8?B?SUh2YWxTVE95Ymp0UUdKRGxDQlc4UVZEMThtelo4TTFTaTBjOExIZDNRdzN4?=
 =?utf-8?B?T1d6NmxOQnB4N092YTEwdzJpMEQybGR1RWtlbVpGczlpWjMxSlJEeGlKMjhF?=
 =?utf-8?B?S2hIcy9Ea1VFY3A0K2Zvb3dYUENFNDNYSGIrTWVZeTZ1NUkxa25MQXZBZHRy?=
 =?utf-8?B?UGlYQlJTWW1Cc2hSaDkrS2ZYNkZOZEtIelpwdmYwUE1kYXpiK0lVbmg2V2xr?=
 =?utf-8?B?cm9JODA5Ri8vZVRHQzhBZWN0TlJDMTR2RE4xZHExUnp5Y2FibExPejhlcUFo?=
 =?utf-8?B?MENCNVYyckNEV3dDR3J3NURNYThEOEpzaUVaNERJYmJ5S1VpMlBOc0lyUGc2?=
 =?utf-8?B?bGloTE96b1BXTzRtQ3N3Rmp0aUtXbzR5VzJZRisxa0J4YlpRTFNxb2xFQk9w?=
 =?utf-8?B?UVpvQlE2dmVIb3ppYWJRUHZoamhlS2E4dUVQcXBXL0ltYmR4MWVSS1VhQ1hP?=
 =?utf-8?B?YTNobjd0cEFNcHVqSzE5WmtuOVRxcXZxb2JHTHo2RUxqeS9vUjJMV2hERmw3?=
 =?utf-8?B?VUlqNDlxckxiSmxJaHBjVThLTkUwMDVSaTF3UGM2ZUZjZTUwVlBoMzlTVkV6?=
 =?utf-8?B?cUtDMlhGSTZtSERINUVDMWNVc3dkZDZGNjEvb3BkSTB1LzZkdWE3NjEyczJo?=
 =?utf-8?B?NG5vc2lEMGlSSmVZWjEwYklWWmFNZnhlTU5ybjRSbktNNS8rb2xyaG5QVGFz?=
 =?utf-8?B?WjkyaXJ3WTM3VE9TTnlXNmUzL016UUh3aFFZcW1zbnhuWlFnQ0ZUWDhVaUhO?=
 =?utf-8?B?SDd6VFFzQXJOUTUzdzV1OWRMV0FTU2dScjA3S2o4S0lrOFl6K212bVREdG9R?=
 =?utf-8?B?RXVMbzhqWUVPdW1oTm1MZS9VclZsRjhmN2hTZGUzRElIQm43dXpJM3BObHkz?=
 =?utf-8?B?ejk1L25qUjJpem9YbGVlSmw3STBJUUJPcmdlZHBzQWVlZ0VWV2lTZ0xsZ2tq?=
 =?utf-8?B?SWZPWGI3UmN4QjhYc1E5aHdncGllbk1yZzAzbklnSW9pb3plbjN5cUlhSlhJ?=
 =?utf-8?B?djY1NldYUlZLejhuN2NRMHJWUXo4WEd4TDFCTzdJU1huWEFMSzAxWG4xM0tR?=
 =?utf-8?B?d3hudklQRFhyK3pJazIydWNhaTVUcnN6VkxHWVNwK2NlNnBwZktKc1RPSWl6?=
 =?utf-8?B?VUE0WjBLbTVxVmFjVmU5ZU96eGtSeUphNGROSi8wRjlDZWNmUTVRTWxoaU9O?=
 =?utf-8?B?K3dYcWdYaGZGOS8zZXZvaGVWdzJjYkdPa3VsdDNCOGFWYk9YSENKZz09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 942066b4-5c89-4333-94f3-08da194e47aa
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 10:55:22.9038
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XJsQlciUusKB8gDK7wplpr9t3K6myX5EPavstKRwjSLG7eh4ZV/Enx3fMziy9VshhkPoDtKr9scb4iIIESCFjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5157
X-OriginatorOrg: citrix.com

On Wed, Feb 23, 2022 at 04:59:42PM +0100, Jan Beulich wrote:
> ..., moving the former into the new physmap.c. Also call the new
> functions directly from arch_iommu_hwdom_init() and
> vpci_make_msix_hole(), as the PV/HVM split is explicit there.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: George Dunlap <george.dunlap@ctirix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Just one comment below, which can also be taken care in a followup
patch if you agree.

> ---
> v2: Change arch_iommu_hwdom_init() and vpci_make_msix_hole().
> 
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1473,12 +1473,9 @@ static int clear_mmio_p2m_entry(struct d
>      return rc;
>  }
>  
> -#endif /* CONFIG_HVM */
> -
> -int set_identity_p2m_entry(struct domain *d, unsigned long gfn_l,
> +int p2m_add_identity_entry(struct domain *d, unsigned long gfn_l,

I guess switching the gfn_l parameter to be gfn_t gfn, and then
defining:

unsigned long gfn_l = gfn_x(gfn);

Was too much churn?

(this is just so that the exposed interface for p2m_add_identity_entry
is cleaner).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:01:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:01:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301385.514331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmN1-0007Wf-To; Fri, 08 Apr 2022 11:01:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301385.514331; Fri, 08 Apr 2022 11:01:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmN1-0007WY-Ql; Fri, 08 Apr 2022 11:01:39 +0000
Received: by outflank-mailman (input) for mailman id 301385;
 Fri, 08 Apr 2022 11:01:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncmN0-0007WS-To
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:01:39 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 41d154e6-b72b-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 13:01:37 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41d154e6-b72b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649415697;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ciBmRyzsvMQg+vH0lpgSiG3CqQQ8q+FXVZ8jg7oSHnE=;
  b=b+Mhn20DGLu6+5gQej2QDAUyMNLI/BgRZawFnKQKMeSocvLZUfuHcgjR
   FIrh3bXKUDQS2qR6j7QAiLXasAaQrejWeHsftNLKfOxo4EWIenKHOE6bx
   j0yRQXvajUNSC+y47dUjqh9T6DIDZO/puJnYFDYvAjav7t9pCLJK0PzA7
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68247366
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:In2YEqP+etvINorvrR1Ll8FynXyQoLVcMsEvi/4bfWQNrUojgmNUz
 mQWD2+Pb/eLY2b3cogiaIqw/EsGvsOAz4JgGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2t4w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zm
 ed1kqO1UEQQHaTpwMIaaUVRQn5UBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmdq2p8VQ6i2i
 8wxdD9TXj/NfEFzBnQ2C9VmwKSS3XLSbGgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSAzRKV/3TqgfXA9Qv3VosdG7y/8v9Cm0CIyyoYDxh+fVmmpfi0jGauVtQZL
 FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv
 neOhMj1CCdz9bSZTHOb3qeZqyuoPioYJnNEYjULJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3
 RjbnhAZuLAKzvco3oDj21f93zv9+bLwG1tdChrsYkqp6QZwZYiAboOu6ETG4fsoELt1XmVtr
 1BfxZHAsblm4YWl0XXUHb5TRO3BC+OtamW0vLJ5I3U2G91BEVaHdJsY3jxxLVwB3i0sKW6wO
 x+7Ve+8CfZu0JqWgU1fPtrZ5ycCl/GI+THZuhb8NIcmjn9ZLlLvwc2WTRTMt10BaWB1+U3FB
 b+VcNy3EVERArl9wTy9So81iOF3l3pumD6DGs+ilnxLNIZyglbPFN/p13PUMIgEAF6s+l2Jo
 76zyePUo/mgbAEOSnaOqtNCRbz7BXM6GYr3u6Rqmh2reWJb9JUaI6aJm9sJItU994wMz7ug1
 iztCydwlQuk7VWaeFriV5yWQO62NXqJhSlgZnJE0JfB8yVLXLtDG49DL8BnIuR9rLULIDwdZ
 6BtRvhsy89nE1zv0z8ccYP8vMplchGqjhiJJC2rfH40eJsIeuAD0oaMktfHnMXWMheKiA==
IronPort-HdrOrdr: A9a23:80lz/KrCt3RPwlEknpdlO58aV5vPL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ
 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGNXguNbnnxE426gYzxLrWJ9dOME/f
 Snl616T23KQwVoUi33PAhPY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX212oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iHnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMg4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegy2w
 2LCNUtqFh0dL5lUUtMPpZzfSKJMB25ffvtChPaHb21LtBOB5ryw6SHlIndotvaP6A18A==
X-IronPort-AV: E=Sophos;i="5.90,244,1643691600"; 
   d="scan'208";a="68247366"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RsYTaIymx8ah+IHj8c+rnUN+R5fWesgpaSDL3x/CTl/v5+dEqh7LnfMYNb8blk5e2t6I83m2C45KSSE+EVUJYmWDW3R1hnVMGvII4VqPr4rThhexQ24Qx3c3lWitPVd1qfLdmEJsGXpGPCmxNLIiOJXcr64PnYTLetHR/vGtqThQse2fKHRsaXUkh+ERwIDvkFCsDPtj0wH6C3YnLoCka6CipYvzPwNqSBT0WeAA0yWPeQxOH/ndg+xoIyg+Cm+DGtmeS1W1LW5MVdSmu8pzpaceuktujoAJ5jRJh7vOp3QPEtf/qnnv8q5QOrl2bgzzac8F/y6Qhnh+qfPXzkNHnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eZlysfu2xbLtIojeMpQ+WOfCVfjYgxoa3eNp8pGK3G8=;
 b=OW3NozzjcBzVTq8QsrH5yAMnW+AIks7Zk76ZXa82VZAhN1KaQ0VgQFZnY4SOqFF7iyENs1hwDbA4qlbZE1B0h42Qq89W4tLH49zUskNLRvjKGIWNzLjDEOkO5xtYp/WbAPLHz267Kc+4zJsHPt9vELCY42472Kc3k4SoJ+XAPbbtG3CpsjNOHd6WUeOgNzD99+6VcGLhRqQcVojVTDBjWyKZm8H5EbyCHqxfwRI1PBPzSR9V26kgiMJYEPQEjpw2obmYvD+dSWyxtZ0rZLn2lhbxuLDn+E3FwqYmH7IHYP7aY8cepB1Vj2TTs5PnPdlVs5NaaeHFcZHIwNlKfPU5aQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eZlysfu2xbLtIojeMpQ+WOfCVfjYgxoa3eNp8pGK3G8=;
 b=CTs3Frr/HmfumjBUtxAXNakQqmZCBWVVkcaUmIDjdiPzxnFymr8DYXgXWZWDVC90O8OGKQ1I2Sat73p51KucHjobSg45t84PW05g4io4DF3jp7/6TYOXt/74xXwNtqbF5V6Px664E1RT97bFjkzgS7D1TUvG4ax/gm+nVv7zb6w=
Date: Fri, 8 Apr 2022 13:01:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, osstest service owner
	<osstest-admin@xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Dario
 Faggioli" <dfaggioli@suse.com>
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Message-ID: <YlAWBom8O8d1lCpQ@Air-de-Roger>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
X-ClientProxiedBy: LO4P265CA0096.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2bc::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d873a4b3-3c02-4d5b-d453-08da194f2312
X-MS-TrafficTypeDiagnostic: BN7PR03MB3443:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB3443116104DC0411ED6DDCF28FE99@BN7PR03MB3443.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: AIn/CMDaJzRexEQ8IykvOwclTSSGkD3m4EwRBZhxy+EacIBSWhrT0KZwCsWLEdvDM7pyxi0H+ndzIo8PoQbA71enG+uYZVAe2Khm0Gw9UzJOvEA4Yxc/Uw2Add80mIvgJ5u369IZc7nRd3NZIVP4RxiVu2Azt/mwhrA9a+yao+r6J4EXBgW8iWp1Z+J7xMG0GWVZNkU1y4IKI9rnrQsF58/jaVNzdnVH/4I2uvret6CkOC+EcdJsGMqWs27v8sUzum0+Cj8qsLpWH/XlZLGOeqNoGgoaF6WykWuiXSoNiXji7apzDhk5Fg+YOY8k7b+cynwbnHegCK/0IJgeTFyW1Ot///LN9eJRUy/PHozxgs2ZybSm8QyFweAyhihFh+mQu1EMOrkUmgxK6mLUEeM8QdehzG/7dqOvgQdjLAvSjIDLvq3eUXCTzQSqo9Z4s9/EmxD5PAP0HbFYFBQVpjrsxwAOmlueT1z6BHpI8JCsy5H+f6DchvtNTHjId6tl8EmoTxZmj1POGfsNWztrFYoGhathDttY2nPCLUgl06DRqMdIgoZgYPxy4xzSyfUDYMEh50WOQEhamytrClVTs46yezbHrr1kkOGzFZoecNavxLI4AwI+RZJ4w9hbkTpj6Qk21RX8glEYoIeXWByPIJPrwkSgh+yoHiXXVcxU+NQXMOmhcppCUyuNGupX3WKwXzcVbrwXw93p4jZkQPwR2d8Cqj7zOMKJ8I7x/3IGkPOiIkc=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(966005)(6486002)(33716001)(66946007)(4326008)(186003)(54906003)(38100700002)(316002)(53546011)(86362001)(6506007)(83380400001)(8676002)(2906002)(66556008)(85182001)(66476007)(6916009)(6666004)(5660300002)(82960400001)(9686003)(508600001)(8936002)(26005)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDlHcXdZRVBQbGZDN0JtMFlrNHpUYi9uUjZCNFdzQ2Zna1FqNEpvaDI5Tmdz?=
 =?utf-8?B?bTVjU2lRbkdzRVU2eDlBQnp3WElTakZIMm1Gb2F1eEp4d094UDZKemhuOU9a?=
 =?utf-8?B?TjFpT242K2t1b3IwM2F2K2REMVVJNUtQTDQ2d3ZSd1NRWFIzSHZmRUlTNndF?=
 =?utf-8?B?ZENRRkY4dndOeVF6dWNEeVB0alZqMlFRaFQ2QjFlanl0dFpoUm1sNERZK051?=
 =?utf-8?B?VUZ2MkVVd1VGeUxKQ2dLellDSnV3OExpYlNkUmYrbUlwUkQ0cGlhQlU0TWFh?=
 =?utf-8?B?SmtRMTdLRGFHU21NYlVveUZnVEZCdC9zUXZvMW9ibGMvVEdmZi9Edm1ray85?=
 =?utf-8?B?N3N1R3VKMjVWbmVOaThidmVRVmNYbnpEQ1JiVEVqNlJ6Z0xmcGE5eTBiQ2hy?=
 =?utf-8?B?cUFRbWF4VzJ5VzdrR2dHVnlSaDBsVmtVUFhJRy8rcTZXT0Y1ZUxiREVCdklo?=
 =?utf-8?B?ZlRUSXlYdDBVNk5rOWZzNk9rdDdFUkYrR1o2Nk5GSklaSVRBblp4dW1wNC9V?=
 =?utf-8?B?c25NVzgySDFYOTdqMlAwWm8wVCtoWUxKOGJkOURNOGFHdHZXTjNQclFHb3Rq?=
 =?utf-8?B?alVXVFo1U2hOMVYzOGMvNStWR1ZlYjJ5UHhzdjk2NWZFdDBvSFpacVVNVi9n?=
 =?utf-8?B?R3VvUUh1MDhRcForN09jbmFTOFliQmlYcVY2Qnp4WWxzOTJaTStTZGdKcWpw?=
 =?utf-8?B?NlpYMmw1bWR1NjlUVWYzelduSDZudGFhMmdsT1JlWHE0aVF3T0laMVIzWWVx?=
 =?utf-8?B?N1NnQXdIVVVNWlBPaW91aVBTMkdoRlJuYk5jdXJrYkc0TEVDVFFIU2ZETHA4?=
 =?utf-8?B?QUtsZ2dkbi9HeUFSWHZSa3lCVnFsRXFGckk0cnF1dms3ODJVUnh2UVhpR2dS?=
 =?utf-8?B?cjF5MFVrVXQ4QTJlS1lpM3hOMkZCeDFOUENKYjB2dm53cTZEMUpaR0UweEtS?=
 =?utf-8?B?UElTQ1k5RFhhbHpsUnh1MGxmUXYwblJoaDVPWjlnMXhrN0hjWnB0b1V2TnI3?=
 =?utf-8?B?M0NXay9KRGdBTDFKOXI5VW93VkUrN3grSElnZUQvTmFBMGcrQS9RMVpUM0lT?=
 =?utf-8?B?MnZhcHJER1ZaK0VpMU9BS0hkNzUzTC82dE9TbW4vUDNVd1haakdOSThFR1JF?=
 =?utf-8?B?b0NmaEpkN25ML3FHUEE5Y2tGcXI0M2tuaFNTazlWUUxWcXBRY0szMnZCcGlT?=
 =?utf-8?B?aU5LVk1CT3cvQ2gzTTZNd1E0V0kveVlZSHVDb1A5NmN1bEt1Tjkzb09MMDdQ?=
 =?utf-8?B?UUZBMmdtWjk1eStIR1BtSnpHWVhIdmtuNlNGb3hRUGsxV1diaDNrZWJ1MWFs?=
 =?utf-8?B?NW5KVG51VEpZbnFWWi95YXdwcjRwUnBNYWdqc2pzZGNBV3VWTzFHQk9DVHFW?=
 =?utf-8?B?dm9qMTF0NlphL3QxRmx6bWdiMFdBZWZTNVhUSTBSMGdsS1BTOW5zTjZ2UlMv?=
 =?utf-8?B?Q3JyYmNsR1hNaEVFdG5YZW93OUpxT3dUTHA0ckRCcWV1aG5JSm5ETmhJYzZW?=
 =?utf-8?B?dlVTNE01OUdsSzljQWtHR2N1NDQ1U1Ywbkp6TnpGUnhocXR4YXdjRVV0aThl?=
 =?utf-8?B?czVZNm1zMitObHpHMXBvRGJUVWdIQnBsUytkOHdwdGRLeVY1T2xJR3FCMGtZ?=
 =?utf-8?B?QW9SeXpFOWZUQ1B6N0Z0QUJPaW9SeG5BV2Y2b3IySm5YOUNvajJ5NHRWTTBn?=
 =?utf-8?B?T203d2dibHZVR3ZXbzFmakgxSHdxSHhCRXpZRS9IKzhhelhjalJQZStXM2JK?=
 =?utf-8?B?WWhabGE1Uklic2QwZFplMWx3REc5UmNSaTR0Ty9hUTllOTVMOTQ5RGEzS25B?=
 =?utf-8?B?NEl2U2llalJwczB5SmYrQ1JCRzBBQURJMTV1WjlmMmhvYjhjaTExaWVmVXc1?=
 =?utf-8?B?U21BVXJUVU40bDNFZXZOZjJPZVhMUkU3U1NSZ0hrNS84UjQ5L2VpVW1LYmVL?=
 =?utf-8?B?czNMYlRGa3JLWnlJRjk1RTdVQ21LaGFsRGJLWTlKNjZYa0tqZGdsaE9JU2Yr?=
 =?utf-8?B?SVFXRjk5TXVyaWdrLzcycVpESnVsQzB4Sk0vYnMyMFRkbEhYM29yV2tEQXI0?=
 =?utf-8?B?SXdrNTloSjlMWXVwVlZ3aDNKMUJxdWx0blJHZnJ2WFZFTVRyb2hrWk5aYk5V?=
 =?utf-8?B?MkU5ZHZDcy9XK0Q4aWdVUFlmSW8waEJGTVZudERVZ3pzZWhZT2ZkampDcUpa?=
 =?utf-8?B?bkMvUllFOG52bC9MaW9KdmtWNWlKWldZTys4L1pOODkwUDN6bG5LK0h1dGJs?=
 =?utf-8?B?TWhqTG9RWld6K0VDS2ZJSEd5OUJmcmhkaytpOXh6MGt4VENOUHF2VGREZFVT?=
 =?utf-8?B?U01DMHFhR1l4MmtUWkhmcUswdEJYdlN1dUd3VmkxMWYxdWdMUUM0TlFDQVBw?=
 =?utf-8?Q?NK4egCkDtUQNEjF0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d873a4b3-3c02-4d5b-d453-08da194f2312
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:01:30.9612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P7NXE/7K11ATYtoGG+c/skafRahGX+5P2j/u9AeB8kqcPXbD8/wYNtbe2ccTzTSRmHdZUfKKQlvl2iAnCcvp+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3443
X-OriginatorOrg: citrix.com

On Fri, Apr 08, 2022 at 11:25:28AM +0200, Jan Beulich wrote:
> On 08.04.2022 10:09, Roger Pau Monné wrote:
> > On Fri, Apr 08, 2022 at 09:01:11AM +0200, Jan Beulich wrote:
> >> On 07.04.2022 10:45, osstest service owner wrote:
> >>> flight 169199 xen-4.12-testing real [real]
> >>> http://logs.test-lab.xenproject.org/osstest/logs/169199/
> >>>
> >>> Regressions :-(
> >>>
> >>> Tests which did not succeed and are blocking,
> >>> including tests which could not be run:
> >>>  test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 168480
> >>
> >> While the subsequent flight passed, I thought I'd still look into
> >> the logs here since the earlier flight had failed too. The state of
> >> the machine when the debug keys were issued is somewhat odd (and
> >> similar to the earlier failure's): 11 of the 56 CPUs try to
> >> acquire (apparently) Dom0's event lock, from evtchn_move_pirqs().
> >> All other CPUs are idle. The test failed because the sole guest
> >> didn't reboot in time. Whether the failure is actually connected to
> >> this apparent lock contention is unclear, though.
> >>
> >> One can further see that really all about 70 ECS_PIRQ ports are
> >> bound to vCPU 0 (which makes me wonder about lack of balancing
> >> inside Dom0 itself, but that's unrelated). This means that all
> >> other vCPU-s have nothing at all to do in evtchn_move_pirqs().
> >> Since this moving of pIRQ-s is an optimization (the value of which
> >> has been put under question in the past, iirc), I wonder whether we
> >> shouldn't add a check to the function for the list being empty
> >> prior to actually acquiring the lock. I guess I'll make a patch and
> >> post it as RFC.
> > 
> > Seems good to me.
> > 
> > I think a better model would be to migrate the PIRQs when fired, or
> > even better when EOI is performed?  So that Xen doesn't pointlessly
> > migrate PIRQs for vCPUs that aren't running.
> 
> Well, what the function does is mark the IRQ for migration only
> (IRQ_MOVE_PENDING on x86). IRQs will only ever be migrated in the
> process of finishing the handling of an actual instance of the
> IRQ, as otherwise it's not safe / race-free.

Oh, OK, so then it doesn't seem to be that different from what I had
in mind.

> >> And of course in a mostly idle system the other aspect here (again)
> >> is: Why are vCPU-s moved across pCPU-s in the first place? I've
> >> observed (and reported) such seemingly over-aggressive vCPU
> >> migration before, most recently in the context of putting together
> >> 'x86: make "dom0_nodes=" work with credit2'. Is there anything that
> >> can be done about this in credit2?
> >>
> >> A final, osstest-related question is: Does it make sense to run Dom0
> >> on 56 vCPU-s, one each per pCPU? The bigger a system, the less
> >> useful it looks to me to actually also have a Dom0 as big, when the
> >> purpose of the system is to run guests, not meaningful other
> >> workloads in Dom0. While this is Xen's default (i.e. in the absence
> >> of command line options restricting Dom0), I don't think it's
> >> representing typical use of Xen in the field.
> > 
> > I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
> > uses 16 for example.
> 
> I'm afraid a fixed number won't do, the more that iirc there are
> systems with just a few cores in the pool (and you don't want to
> over-commit by default).

But this won't over commit, it would just assign dom0 16 vCPUs at
most, if the system has less than 16 vCPUs that's what would be
assigned to dom0.

> While for extreme cases it may not suffice,
> I would like to suggest to consider using ceil(sqrt(nr_cpus)). But
> of course this requires that osstest has a priori knowledge of how
> many (usable) CPUs each system (pair) has, to be able to form such
> a system-dependent command line option.

Well, we could get this number when installing Xen, because at that
point the system is started and running plain Linux (so can see the
real topology). No need for osstest to have a priori knowledge.

> > Albeit not having such parameter has likely led you into figuring out
> > this issue, so it might not be so bad.  I agree however it's likely
> > better to test scenarios closer to real world usage.
> 
> True. One might conclude that we need both then. But of course that
> would make each flight yet more resource hungry.

Yes, let's focus on real-world uses first.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:02:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:02:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301388.514341 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmNd-00082W-7g; Fri, 08 Apr 2022 11:02:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301388.514341; Fri, 08 Apr 2022 11:02:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmNd-00082P-4s; Fri, 08 Apr 2022 11:02:17 +0000
Received: by outflank-mailman (input) for mailman id 301388;
 Fri, 08 Apr 2022 11:02:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncmNb-00082G-Sq
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:02:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncmNb-0000J0-Nd; Fri, 08 Apr 2022 11:02:15 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncmNb-0002T0-HR; Fri, 08 Apr 2022 11:02:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=LMe3To61OXohR7koCtJf8NTT774Wi+Jroh75YN21Vb0=; b=5darWaA3SQnnGMU31KF+ialTyi
	6i76DSi7gmjgqRzLPnmHn8BKiLONZ0nlEMQOLRM/4W4x0gMQKx6fmX37Q3p9CoNfmaf4b7G/3GiG8
	fSOHiP89aBKuq71FM2GswLT6icBpBpxdKIdtHLLP5Nk37PCQWcgxu2m95DHD/bgjV3DI=;
Message-ID: <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
Date: Fri, 8 Apr 2022 12:02:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 08/04/2022 08:16, Jan Beulich wrote:
> See the code comment. The higher the rate of vCPU-s migrating across
> pCPU-s, the less useful this attempted optimization actually is. With
> credit2 the migration rate looks to be unduly high even on mostly idle
> systems, and hence on large systems lock contention here isn't very
> difficult to observe.

"high" and "large" is quite vague. Do you have more details on where you 
observed this issue and the improvement after this patch?

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>       unsigned int port;
>       struct evtchn *chn;
>   
> +    /*
> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
> +     * vCPU-s they're to be delivered to run on. In order to limit lock
> +     * contention, check for an empty list prior to acquiring the lock. In the
> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
> +     * until the vCPU is migrated (again) to another pCPU.
> +     */

AFAIU, the downside is another pCPU (and therefore vCPU) will get 
disturbed by the interrupt. Maybe we should revive "evtchn: convert 
domain event lock to an r/w one"?

> +    if ( !v->pirq_evtchn_head )
> +        return;
> +
>       spin_lock(&d->event_lock);
>       for ( port = v->pirq_evtchn_head; port; port = chn->u.pirq.next_port )
>       {
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:05:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:05:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301395.514353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmQG-0000GU-LF; Fri, 08 Apr 2022 11:05:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301395.514353; Fri, 08 Apr 2022 11:05:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmQG-0000GN-IN; Fri, 08 Apr 2022 11:05:00 +0000
Received: by outflank-mailman (input) for mailman id 301395;
 Fri, 08 Apr 2022 11:04:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=co1q=US=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ncmQF-0000GH-CI
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:04:59 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id b9e44d5c-b72b-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 13:04:58 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B6F1A11FB;
 Fri,  8 Apr 2022 04:04:56 -0700 (PDT)
Received: from [10.57.7.146] (unknown [10.57.7.146])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 118223F73B;
 Fri,  8 Apr 2022 04:04:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9e44d5c-b72b-11ec-a405-831a346695d4
Message-ID: <6a806c9d-2723-1db0-49c4-25a98ac06ff5@arm.com>
Date: Fri, 8 Apr 2022 13:04:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V3 1/2] xen/arm: Add i.MX lpuart driver
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>, Henry Wang <Henry.Wang@arm.com>
References: <20220407024418.9827-1-peng.fan@oss.nxp.com>
 <20220407024418.9827-2-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220407024418.9827-2-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Peng,

On 07.04.2022 04:44, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The i.MX LPUART Documentation:
> https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
> Chatper 13.6 Low Power Universal Asynchronous Receiver/
> Transmitter (LPUART)
> 
> Tested-by: Henry Wang <Henry.Wang@arm.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
>  xen/drivers/char/Kconfig              |   7 +
>  xen/drivers/char/Makefile             |   1 +
>  xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
>  4 files changed, 348 insertions(+)
>  create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
>  create mode 100644 xen/drivers/char/imx-lpuart.c
> 
> diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
> new file mode 100644
> index 0000000000..111640edb4
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/imx-lpuart.h
> @@ -0,0 +1,64 @@
> +/*
> + * xen/arch/arm/include/asm/imx-lpuart.h
> + *
> + * Common constant definition between early printk and the LPUART driver
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ASM_ARM_IMX_LPUART_H__
> +#define __ASM_ARM_IMX_LPUART_H__
> +
> +/* 32-bit register definition */
> +#define UARTBAUD          (0x10)
> +#define UARTSTAT          (0x14)
> +#define UARTCTRL          (0x18)
> +#define UARTDATA          (0x1C)
> +#define UARTMATCH         (0x20)
> +#define UARTMODIR         (0x24)
> +#define UARTFIFO          (0x28)
> +#define UARTWATER         (0x2c)
> +
> +#define UARTSTAT_TDRE     BIT(23)
> +#define UARTSTAT_TC       BIT(22)
> +#define UARTSTAT_RDRF     BIT(21)
> +#define UARTSTAT_OR       BIT(19)
> +
> +#define UARTBAUD_OSR_SHIFT (24)
> +#define UARTBAUD_OSR_MASK (0x1f)
> +#define UARTBAUD_SBR_MASK (0x1fff)
> +#define UARTBAUD_BOTHEDGE (0x00020000)
> +#define UARTBAUD_TDMAE    (0x00800000)
> +#define UARTBAUD_RDMAE    (0x00200000)
Could you please align the values at least within the section?

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:08:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:08:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301401.514363 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmTJ-00019d-3b; Fri, 08 Apr 2022 11:08:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301401.514363; Fri, 08 Apr 2022 11:08:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmTJ-00019W-0l; Fri, 08 Apr 2022 11:08:09 +0000
Received: by outflank-mailman (input) for mailman id 301401;
 Fri, 08 Apr 2022 11:08:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncmTG-00019P-Ui
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:08:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncmTF-0000PT-DN; Fri, 08 Apr 2022 11:08:05 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncmTF-0002wI-6b; Fri, 08 Apr 2022 11:08:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=osVK69YQoPVCEAYXBk/+qr/6y9mMC14WucU8SEetKRc=; b=BEkFW9Msn62Ndi11entcRDj0eh
	kTdy/bvs3jkvKeEav4MGp5smiv7GtPChk9CXODWXxKd3dKcj2S1jC7O/IQW1NT1cmL/aSbfCGbY5K
	v0p75Vx1qNpMGiJqjwJ7c2UNGVAejAz1LkLd3YwBC/byiHfeb/l81bZIvmoXuRE2sla8=;
Message-ID: <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
Date: Fri, 8 Apr 2022 12:08:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
 osstest service owner <osstest-admin@xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YlAWBom8O8d1lCpQ@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 08/04/2022 12:01, Roger Pau Monné wrote:
>>> I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
>>> uses 16 for example.
>>
>> I'm afraid a fixed number won't do, the more that iirc there are
>> systems with just a few cores in the pool (and you don't want to
>> over-commit by default).
> 
> But this won't over commit, it would just assign dom0 16 vCPUs at
> most, if the system has less than 16 vCPUs that's what would be
> assigned to dom0.

AFAICT, this is not the case on Arm. If you ask 16 vCPUs, then you will 
get that number even if there are 8 pCPUs.

In fact, the documentation of dom0_max_vcpus suggests that the numbers 
of vCPUs can be more than the number of pCPUs.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:11:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:11:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301405.514374 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmVy-0002WZ-Ia; Fri, 08 Apr 2022 11:10:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301405.514374; Fri, 08 Apr 2022 11:10:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmVy-0002WS-FX; Fri, 08 Apr 2022 11:10:54 +0000
Received: by outflank-mailman (input) for mailman id 301405;
 Fri, 08 Apr 2022 11:10:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncmVx-0002WM-E7
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:10:53 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c8c2d89-b72c-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 13:10:52 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c8c2d89-b72c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649416251;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=8bXHeHhTsI/wl6MOO/7onxex2EW9xcyKUhsMiCcmNoU=;
  b=hth4d0qeUBU8ZA/T5VmmPlhkfN+WxvOcsZCf3mkyuwGpR3UZsW9HIk38
   nORpNeMYkwzZVcnJMtjKWf0E18QUj9VrJniKkbPYhs+vmSqJarWEZSzRk
   eIq4DTFQNMiy8dJqcrR72BaDu8vhZafaWBlA++OsDjHx82qM1tKeSh4ol
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68248070
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/cA4ga9zpSqPt9qUZVYsDrUDoH6TJUtcMsCJ2f8bNWPcYEJGY0x3n
 zdNCmCPPf+La2OmLtBwOtu280xSvsWHx4A2HgBs+S88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YDpW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbbtQwo1IIr0o+JHaDh6Aht1J4h9v4aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4eR6qOP
 5VBAdZpRDbORzpvJw82NL4vnr/ytEGhKzx69k3A8MLb5ECMlVcsgdABKuH9eNaHWMFUlUawv
 X/d8iLyBRRyHMOb4SqI9DSrnOCntSHyXo4IBaC73vFviVyXgGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZrNdYrqNERfQcsj
 GSovcLTDiZKi/qsHCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh
 mnT8XNg3+l7Ydsjjf3TwLzRv967SnElpCYR7x6fYG+q5xgRiGWNN93xsgizARqtwe+kori9U
 JosxpD2AAMmV8jleMmxrAMlRuzBCxGtamC0vLKXN8N9nwlBAlb6FWyq3BlwJV1yLuEPciLzb
 UnYtGt5vcEPbSH6MPInPN3oUqzGKJQM8/y/C5g4ifIUPPBMmPKvpnkyNSZ8IUiz+KTTrU3PE
 cjCKpv9ZZrrIa9m0CC3V48gPUwDnUgDKZfobcmjlXyPiOPGDFbMEOttGAbeP4gRsfLfyC2Io
 ok3Cid/40gGOAEISnKMqtB7wJFjBSVTOK0aXOQLLrXTfVc8QDhJ5j246epJRrGJVp99z4/g1
 nq8RlVZ2Bz4g3jGIh+NcXdtdPXkWpMXkJ7xFXVE0YqAs5T7XbuS0Q==
IronPort-HdrOrdr: A9a23:6hRrTa+TAdDwwvXwUwtuk+E6db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wgK7VBaM0ot
 gsCZ4Y542mfvVmHZ6VO91xM/dfKla9Ny4kY1jiaGgOKsk8SgfwQtjMkfEI2N0=
X-IronPort-AV: E=Sophos;i="5.90,244,1643691600"; 
   d="scan'208";a="68248070"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VV6dmM6g+IAKv4NY9YEVJKmyNQzZS48dizzdx/2UDNQxAGVkThQPLNeMECgUC5DAEtAs63yqqQaOsJWEjOPfJVicaxsBaZb53bYJ0K+YIayoVeTfBm8ICuv1T1G+ql1Qb6gRJBvD3EFCvkV8uCexmUzAVMpOhOS8cpEWhlYSs1e8tODzFWR3XBVECJ48lW03IN4eu9/K6VSothVTiPKPaVygxGfCnZ+O5RTYRYD2TdBQqdbBdaCoZzS2w7paitzjlENNweY9RD30L263vj2fwMMc0LXWz/7D4B3vAAJh/gwfcp0rEDMBOIsfflavJHH5h8o1hzf8DvtWHW3vsvOW/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6zIGZihN9QrKO1Zv8VBfev9JOsAi53q1iOoPU3YLL7s=;
 b=ROChJNkLD8IJfbg/22JIHSe+Pvbc1Y2LalCfK+VYeH3gn37GfR/UUKtQ+ngLRx9pzOBHhr6QR8E7pfkRHjnxqO2vph7vTqUCXyCi9iWPjTJ5+NoiVC4lcmKnIG7pHSsGCbYzyAATNxnJ8nndP75sjUkU0Rz2MGsvsvovdLh2fEJoWhTa1XiimH9GvoHSpYzIcQsH6J0Uxfa8DcF/FJNi9rH+nyyZN3Cktw4pcxR2GHe8DV0Vybird2tMZAxDdwgb8uqybLx6bHCmH3oAbdfu4x2QbTWOi+dyGCncwNqI5HGkmN5W8NHI0z9oBhrh9m8Qnb2dxW8/ewKtmceuIGQRMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6zIGZihN9QrKO1Zv8VBfev9JOsAi53q1iOoPU3YLL7s=;
 b=m6HBbbWR5G6g/NehrRaon22XaoLvxogXGcao2He+BAjdPYqn8Oo8k3a2d9iK30uyiR5H0ggJChYflh5ZKd3cCOBu7dcQ44TcRw3VkO1H+UuzSyexAVroj+lEl85+WjT2TSYnghfFYpCdDxnNbMuTNRhralZ0zgh7vb0A3Bfp/oQ=
Date: Fri, 8 Apr 2022 13:10:42 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>
CC: <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction
Message-ID: <YlAYMrirDQUz8u49@Air-de-Roger>
References: <20220407145150.18732-1-jandryuk@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220407145150.18732-1-jandryuk@gmail.com>
X-ClientProxiedBy: LO2P265CA0267.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a1::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 20fa5bc1-1c6f-4c4a-ea8e-08da19506e87
X-MS-TrafficTypeDiagnostic: BN6PR03MB3249:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB324981936179D5EBADE292398FE99@BN6PR03MB3249.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GQbcdRAXoRnwi8QHfnMf53xS9nvZneE/XQ+8SDlPlO+9nXkusO+NPF3DysqLIcIfhtFtYJAcVayJNc2+YKgnacsXZX5dibZRM9bgL0s4J2bi/zcQ40cM0Ij0Wt2ALKxRx6v3P6Ylb1C0B2Cp5rrJE6rrn+byFXG2eCCTlixXSQYXMoMKGBcjoSMPwabQUk6AttAdXsCVEy//4fzURGHIfVOm4xDSmVAUYv05RTXR3S8Q/KJaB2K+nY2u3VrLKbcroxjZGNj6Mr/yTYVy7Z28IwVC6CVsSr1k8gtdUgAtFN5mNXJ6brVaCnW/RaSEiWMu/zWrdofFfdCBKkxFghI9d+j6jRL7z5oddmC5xhB5xERy7qgq8Cz7oJwoala3x5jl5AVI4KR1YrXY/ue858VCDX+4BunfMQxWKlL4xan+dXwiArca3dyvgd6vSEL3dZmiB1UdTa/n0xrIJaFqQGPf+5eadtZE5pJakCph18KgDlKTbOqBzyLRq4QgtyhhvdV1S2KO4AhTR+t7aK9xaw+5LpcjjKVtAh7t9Wcj+FeMWt/JnjcI/UGp6AwNncfgjcR3RIVSYnewgSvi1Rw6jYRPXJyaDCaGvKvwMKwr64wBLkOf0OEoJjkCX1IdSgdlUmUWWtVZAjzsL9E8crdDmrJGrw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(6512007)(6666004)(9686003)(33716001)(38100700002)(85182001)(82960400001)(83380400001)(26005)(186003)(5660300002)(6916009)(54906003)(8936002)(316002)(4326008)(2906002)(8676002)(66556008)(66476007)(66946007)(6486002)(508600001)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjlrRkxLcDFSdTBNY1QwYWN0S1NjUGs0dmVmclVPaEZCbnZiWjN1V1dJU1J4?=
 =?utf-8?B?NFQxTDYzM0RpY1U5bFg1RHg3QXY3cm1SSENRTEp5elNFOStXd2l5d2dhRTRP?=
 =?utf-8?B?dlA0ZEpYVllhNmxSVDdwSkJYQkFOWi9kaGZMSWQ4YkRRanV4cjY4ZkFwWnFY?=
 =?utf-8?B?cXl4eFl2NkVWekVkZlAxQi94TGljZ0R5SXR4U3A3cDlpODZ1ZGJwdmpIbENa?=
 =?utf-8?B?WnRRa2ZiM1NaWUFOb3Z2SDBaMVBKdkhZelV2Rk5hRnJMSEJaOUVrOUIwM21K?=
 =?utf-8?B?MENTcmFEUmwvNGlGNGwra0szYnpCSm9qenAwUmtmWDBGbTRGZ3RLc3Y4Z1RQ?=
 =?utf-8?B?M00zdTFDTTdKayt5OXJ3V0RiMmppWlZHZERab0s3eDg5OTNVMXQzODc4VVVO?=
 =?utf-8?B?V3BTY1N5VFB4dEhRblJlWmpjQWg4SWVFNFdtRFdCRzRDNW94OHY3b1dNLzJ4?=
 =?utf-8?B?Z3YyTk1OQkhidTdMRVNXMW5UemtEazdaZFlDbmdZeDRzRGlqZWNKZ3JNVUdp?=
 =?utf-8?B?cktyRUpFVjBmVHAvaFdYajBJbDN5Y3ZsMEN2VG1zTUtkOHFpYmZObjduQ2Qx?=
 =?utf-8?B?Y3psMlliaVI2RmdpQU4vSmJVUGlmY1hYY1E4Y29UY3hrUVJsRWNiN01tODFD?=
 =?utf-8?B?aDNDUnZFSUpGYUo0dTNIVjdWaVZrci9sbFVmM3l1RWdzZGtaRnpyOWhyU3du?=
 =?utf-8?B?TkhLN003dGw5VGlmMHpyS3pidFFIWGpqQjlHY1hObWMxMFJxS0RLNFpOeDdw?=
 =?utf-8?B?NURXU1BOT281SjNpejlQRy9DdW42OUlkRkE1TVA1cVlDU1pKeUkxbHNBSGls?=
 =?utf-8?B?UzRHUzdpV1BCbUtsSVZFMCtMdzcyMkg3NGtQNFVUS3BONnlKc1Jqa3hIOGRH?=
 =?utf-8?B?K0drMnFFZ0FGUjh2MUtHdkkyNXY1ZWhUU2I0azgrdndHWG4vTTJqYjFHWHor?=
 =?utf-8?B?dDJ4N29EMzAwWlRhT3ZzOVZwZUVOblZ5VkEyeWNsYllZVHpFTHlRVjRuNWRi?=
 =?utf-8?B?RE9jRjdOeXJocWFXRlhtM3pTZWJqbUwrMjlTRzNPRG9hWUxEeEF0UFRKaFVp?=
 =?utf-8?B?ekl0eHdIOUJ2NVlXVnNXS1NFQjA0QitDYzhOYUs1TWVTbE5jRjIyTFZTQmNp?=
 =?utf-8?B?UVR3M3VJVExqaGhVdjBNbENMekRTY2Fna1FOdVdkZGhjS1h4cTYwbGZqaDJJ?=
 =?utf-8?B?ZzM0bVpTMitKbWhjRXozL1U4T0JuVW5DcEZtYXo0clFlVUQzSXJQZis1VEhn?=
 =?utf-8?B?REVSc0ZEMkpIK2JpY1p0bEgwaWVrdFY0SDJLNUtFZ2hFckJpZGdUc2M0NVhx?=
 =?utf-8?B?UTJrRDF2aFdjUkNsSjRzcnpickcwNGJHSFpkQlF0aFBDbHFXTGxpQ1VjNU1W?=
 =?utf-8?B?OVBDdVdRbGw0djdjOWl4WUxWbFA1QU0wdGRKSmNiSHlNbnMra3lOZEwwWDFw?=
 =?utf-8?B?RUhUbXFoMi9kcG00TnQ0UTF3eGdUWEc5aDFPTE5abmRCSXBOUms5TkhpN3ZK?=
 =?utf-8?B?VjJhTUFsa2czSHRQQjZKRHBNaGQvTVI1V2o1OFZjSE5UVmdOamZ3aW9TRFpu?=
 =?utf-8?B?bHBMZDJ6Qm1pZ0pWd1cvZWlFTGE2N3cvRmluZmJnWjJiczZGdnpOeTFja1JS?=
 =?utf-8?B?SlRoenpQL2dtZFl4SGt6RFljdUsxWXVOK2ZCQkNVOGV6T0FpcGZ0NkpRdDd3?=
 =?utf-8?B?QXk5WVlsVmkzQnAzc0VNKyt2L0NBVWRURHp4dlNDZVBPeXlVLzF6WU9rMEox?=
 =?utf-8?B?dURzZ2x2eGo4Zm5Mdy82ajJqU2Q3VGZ3NExnRmRLdXFjVjdJMnpJdUFsYTBx?=
 =?utf-8?B?ODZ6U0RTQUdFYUVhK0ZlcTVYaTBEbFVMVzRZOEZOdlorYVk5SUFxWmlnSGlO?=
 =?utf-8?B?TU0yb2FNTDkvR2hIRVNzdnVYL1JSWGRPQ29wdUR3SzExNmNUZ0k3QVFtY2k0?=
 =?utf-8?B?QVBLOEhEaU9wNkl5dWM3d2N0djhxc0U0UXlXSk85Z1JBRzNCL3RQaVJwTEgx?=
 =?utf-8?B?ZlNqQUZYUjZ6cVZSTnBmaGlIZEVOWWRXYUdyblJBa1czT2c0MWkwTmNxQ2ph?=
 =?utf-8?B?aTdJVG01V3pRdGFGOXVnS2lUMWNiOGlLbStpYjhETTIrTW81Y0pUbVFsei9k?=
 =?utf-8?B?S3ZmS1FrbTQ4TmU2Y3p6QzlrTWQyNXVYamk2a2MzNkphb3RWT0QrZWpvMUhU?=
 =?utf-8?B?ekZzcGJRMDg5d3E5UUlaN0lXMFNYVDhmZHl4YkcrR0xLOTVSTVdIUkl4N01Z?=
 =?utf-8?B?R0Q2VXVONUVReGFTSXpJeUtrellaa1l6ZEJNM3ZTSFEybkkvSW1WVzRraDhM?=
 =?utf-8?B?c2ZDOHJzR0xsOWFSdmRWRkRNb2RUa0RnR2gzbUlidjVTZSsyOXltcVRNTWw2?=
 =?utf-8?Q?1KBGH48ff3T+uBmA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 20fa5bc1-1c6f-4c4a-ea8e-08da19506e87
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:10:47.1012
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qzCk7wnK++cPU7nciNB7DBxDYUXE1tejxMcWV7ucyGIqj2MPB0EBDWzMjOm+gZZ0ewhZaKMkEtQLHBCdqc1PpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3249
X-OriginatorOrg: citrix.com

On Thu, Apr 07, 2022 at 10:51:50AM -0400, Jason Andryuk wrote:
> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
> complete_domain_destroy as an RCU callback.  The source context was an
> unexpected, random domain.  Since this is a xen-internal operation,
> going through the XSM hook is inapproriate.
> 
> Check d->is_dying and skip the XSM hook when set since this is a cleanup
> operation for a domain being destroyed.
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> ---
> v2:
> Style fixes
> Rely on ret=0 initialization
> 
> ---
>  xen/arch/x86/irq.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
> index 285ac399fb..de30ee7779 100644
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -2340,8 +2340,14 @@ int unmap_domain_pirq(struct domain *d, int pirq)
>          nr = msi_desc->msi.nvec;
>      }
>  
> -    ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
> -                               msi_desc ? msi_desc->dev : NULL);
> +    /*
> +     * When called by complete_domain_destroy via RCU, current is a random
> +     * domain.  Skip the XSM check since this is a Xen-initiated action.
> +     */
> +    if ( !d->is_dying )
> +        ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
> +                                   msi_desc ? msi_desc->dev : NULL);
> +

Nit: I would remove the extra space here, but that's a question of
taste...

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I wonder if long term we could make this cleaner, maybe by moving the
unbind so it always happen in the context of the caller of the destroy
hypercall instead of in the RCU context?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:16:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:16:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301411.514386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmaw-0003E7-Ad; Fri, 08 Apr 2022 11:16:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301411.514386; Fri, 08 Apr 2022 11:16:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmaw-0003E0-7B; Fri, 08 Apr 2022 11:16:02 +0000
Received: by outflank-mailman (input) for mailman id 301411;
 Fri, 08 Apr 2022 11:16:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ncmau-0003Du-Av
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:16:00 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0623.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::623])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 43d23bf2-b72d-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 13:15:58 +0200 (CEST)
Received: from AM0PR04CA0063.eurprd04.prod.outlook.com (2603:10a6:208:1::40)
 by AS8PR08MB7282.eurprd08.prod.outlook.com (2603:10a6:20b:421::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 11:15:55 +0000
Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:208:1::4) by AM0PR04CA0063.outlook.office365.com
 (2603:10a6:208:1::40) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25 via Frontend
 Transport; Fri, 8 Apr 2022 11:15:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Fri, 8 Apr 2022 11:15:54 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Fri, 08 Apr 2022 11:15:53 +0000
Received: from 272ac47fa801.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D12740C0-0A17-4A71-923B-7BCFA9A6C647.1; 
 Fri, 08 Apr 2022 11:15:43 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 272ac47fa801.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Apr 2022 11:15:43 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM6PR08MB3206.eurprd08.prod.outlook.com (2603:10a6:209:46::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19; Fri, 8 Apr
 2022 11:15:33 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.025; Fri, 8 Apr 2022
 11:15:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43d23bf2-b72d-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+83DT/uAtdMxoQzYy0KHyrfyw7jZqiTUrnK7IvFHIbM=;
 b=qh1C5Q3HAcfMgGTJeqg87iiOqFxX5vQvzLDqrXX2+JLxDcOVg91tA3AVKxMKMZTPI0/QBivpmweSxDEMcKWX3Dsk4iyA41s1vS6MAkvAVkBTzmmelINUnQ0TTD0YEy8fr9TOAFaa6Z2kPzbdWfiCddr2u+XNp4dYtyoVvNP0y5g=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8e9ddf363c0633d0
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JnLMPAYyztF9jSp0JFykN+DulAzCEZIr01ynTeMvMMdSJnMVilNQwU7xolG+1ydf6wqx3IJa5oidW6NDIAjxCNY5mfGLFZBP26Ao8w9byStfAWlu6t7QqiWhX6qqCaT/juK8DefLtJ/e1OXpUsY/8cjo30GFsibZvsisqe0NA+T1QgYrvmxV92oCQRUoosUHViZaxeRBxLBE22IfcYbmmrZoB1zoSDNTAJ/iwKEo8v5uQU859K0+37Nd/WCskQXOTZbJcP0UdscHINJ/JC/jDibakmAo0zOvjdAfR+ZypfUXMid95Eehpk6erkBfULtd9pPTQgpzH6RPh0TwzqpTWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+83DT/uAtdMxoQzYy0KHyrfyw7jZqiTUrnK7IvFHIbM=;
 b=ljPj/ZBszVJ4zLzbEpF3TdM8OVqSgOvraz9IMU4CcoJJ/eeDDDnI86S3EtOYnmz79xbLgL58ng3+nF72wvxoUquesppLp6rxFADlcF6zY1/mWrokOaJR4sDz2PbprQzmE6dX/1jCkD7YN+PWtnp2I/h+20Mg8IGwpxcJRvnArlFqSA+Ft+t7dB37xeHnDdYOFhMO5aQJW6YP0W2iKWgjyhd3MgclJjLNu4KUUOAVK+AktqXKQuY3YtOjGC26/fuVcUQ6ncrXW7IJc0sBXXAZE1Vo5JFZmbH7zWUnPH5w5RjkATc+4rvWgUWFG4xTTc/a6H3ZjWbclNG8V9b3Oieilg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+83DT/uAtdMxoQzYy0KHyrfyw7jZqiTUrnK7IvFHIbM=;
 b=qh1C5Q3HAcfMgGTJeqg87iiOqFxX5vQvzLDqrXX2+JLxDcOVg91tA3AVKxMKMZTPI0/QBivpmweSxDEMcKWX3Dsk4iyA41s1vS6MAkvAVkBTzmmelINUnQ0TTD0YEy8fr9TOAFaa6Z2kPzbdWfiCddr2u+XNp4dYtyoVvNP0y5g=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Thread-Topic: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Thread-Index: AQHYSyUS0CLVSvR2nk+ITbzc2Ry0wKzlusgAgAAH7oCAAAy5gIAADjGA
Date: Fri, 8 Apr 2022 11:15:33 +0000
Message-ID: <61DEEA58-E570-4FEF-9B71-27316C7F8D7C@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
 <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
 <cacbaa1c-8ae8-9314-9364-97e5a53d876b@suse.com>
In-Reply-To: <cacbaa1c-8ae8-9314-9364-97e5a53d876b@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 5abff261-8e40-4f9b-a2a0-08da195125c8
x-ms-traffictypediagnostic:
	AM6PR08MB3206:EE_|VE1EUR03FT028:EE_|AS8PR08MB7282:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB72829207B6D47E7F6A9C6DF8E4E99@AS8PR08MB7282.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Mg+BBjrQ0yMKWTrJa2aBfqRLfpSK9JyNGrXi1VucM2w6iqPlHwVXmWdF0B9rWCKWYXj+khTsAkwgFbNqQGSTcdlFp9HgrpQwp8fpO4/7z2Jy0w0VjzTyjM5Bt4S8TG7NTDr0Irh8Ap0ijW161lZnHvrPbRvXSZVD6YHJsZ1I1dlckGCFm04yWIKe8CtkGtbYOg9x8FiSahKA9sfLlJTKvZSl1xmlrIQoUs6nTsc1CRGS3BjQ2EasPqOSxl7xNY05H6Nhdsb5REmpcTD2pISylIGHIh41i4BgcKr6qN/T+tURoyGGQD+2si26GFqDPN1XP7/AMWY59aBWd5AArjWlbZ/dyToLh56iOZeI7p7f1tseGgXTu+ju7STPNLC9DqFUrHgjZczWlyVDIY443fhcZ2ievnnIhtarBu/Wz8hppUF3CIDGqlsxjLzQIPFxD2ZEGrPg0yhsEYrSqS+h3S4orU4IQ4hEwnV/yWTjoXTN+9vO1Tw7VqJ6uC9chXjekvdVO3Vrkfno5DlTT7ab3TlFCMjo3NF0p/txSClysXO3dZwb4msulYex68KnMzdZQ8GMqpMvMfKzPoVZYmGINPe9dgCllTnBzDaZ2U+gLbMNX6Cxj++muo7hgFrZbYM6i3mwvn6eu3vUS9VZZw9Mu6Jv0BH0e+dkY6xuh6mqgw712B6Trms0VZmmDM2Y6nv/tRJreZ67UGMbB9Yx51RFLzj0cNgGg8SRXmrxTtmF78pjQO7zkEMWTWVuy/JVy6yz9Ccm6yPIYopz8ai2mkRic3fFDQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(6486002)(71200400001)(66946007)(6916009)(91956017)(64756008)(66446008)(2906002)(4326008)(8936002)(76116006)(8676002)(316002)(86362001)(33656002)(54906003)(66574015)(2616005)(66556008)(122000001)(26005)(38070700005)(5660300002)(186003)(508600001)(38100700002)(36756003)(6512007)(53546011)(6506007)(83380400001)(32563001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <6DED4A989765B74796FB0CD6515C8B15@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3206
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a6bf91cd-32a8-4ebb-b3eb-08da19511926
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MiXgpCa4h9IFYac0ag00NBrLRj5xcxRjx9G+7ufwpUB2RJSzY3zrbidoLzbQjtkSYQgXo4NRuqqnmTBcVmtqkeLUrL+tdzPFbNClIi2r+LvoIMOm+zagDbJlPVCd8c9s8Lgb4tZFqVT1KQCNMp27vzbGKp5DgvUnNoYmPW51xvzYsH4XMRMdbPWKecukE7s6ghYHMa3BkJfu4EjZ+uUXvjDPPMME6CbtVVi/5Z7UKTM0kGTlXDsFk7zyWZq3hVZZsnqsvdoprkX3+s+crVmMumDz9nZ7BmR4C8iJ750h7/O5uf2BN+kpYpOkQY8tv2oC0Ja1pEL2mRZoPc1EQQnCTZBSUYT33D6SxdsUWfl9HDNzeAi9tFeUHtwGt5KWwubumfMQVrHqD4clpU8hcbCFW+JJbD6gUtNMU9OP5BTToOyL4UVg0nghRtpL3iKh3V7BQ3NrY1lKf3SWkZC9IOk4ueqjQeD8FFsU6en5HVwj7MpjU/ra3jtq4yTXJ5MtBT35NPEwd43jL1tMAeY6iG5Hvcgu6y6QK/LmpfkxNJ6/Cabv6iUW0coAenmKpqeSCI82BY7jPt5OdSHkI6L1Kj/+CqjXhpzdTOlh++FhOOQlOsigED8oweT2ixsCJ6fVnZj0/bPvGsjdV/GS0MBZFFhyHUBa1pxJjcHmJPoM7wlF1g4VH+j6TxAoCDXbxTwlYBW6xQ1Cd6GE7iwJ7UkaTPpJkQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(36756003)(508600001)(70206006)(26005)(2616005)(70586007)(83380400001)(336012)(82310400005)(33656002)(66574015)(6506007)(186003)(6512007)(47076005)(36860700001)(356005)(53546011)(6486002)(86362001)(316002)(2906002)(8936002)(5660300002)(54906003)(6862004)(8676002)(81166007)(4326008)(40460700003)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:15:54.2203
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5abff261-8e40-4f9b-a2a0-08da195125c8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7282

DQoNCj4gT24gOCBBcHIgMjAyMiwgYXQgMTE6MjQsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl
LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOC4wNC4yMDIyIDExOjM5LCBMdWNhIEZhbmNlbGx1IHdy
b3RlOg0KPj4gDQo+PiANCj4+PiBPbiA4IEFwciAyMDIyLCBhdCAxMDoxMCwgSmFuIEJldWxpY2gg
PGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiAwOC4wNC4yMDIyIDEwOjQ1
LCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+PiBAQCAtMTA2LDYgKzEwNiw4IEBAIHN0cnVjdCB4
ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiB7DQo+Pj4+IC8qIFBlci12Q1BVIGJ1ZmZlciBzaXplIGlu
IGJ5dGVzLiAwIHRvIGRpc2FibGUuICovDQo+Pj4+IHVpbnQzMl90IHZtdHJhY2Vfc2l6ZTsNCj4+
Pj4gDQo+Pj4+ICsgdWludDMyX3QgY3B1cG9vbF9pZDsNCj4+PiANCj4+PiBUaGlzIGNvdWxkIGRv
IHdpdGggYSBjb21tZW50IGV4cGxhaW5pbmcgZGVmYXVsdCBiZWhhdmlvci4gSW4gcGFydGljdWxh
cg0KPj4+IEkgd29uZGVyIHdoYXQgMCBtZWFuczogTG9va2luZyBhdCBjcHVwb29sX2Rlc3Ryb3ko
KSBJIGNhbid0IHNlZSB0aGF0IGl0DQo+Pj4gd291bGQgYmUgaW1wb3NzaWJsZSB0byBkZWxldGUg
cG9vbCAwIChidXQgdGhlcmUgbWF5IG9mIGNvdXJzZSBiZQ0KPj4+IHJlYXNvbnMgZWxzZXdoZXJl
LCBlLmcuIHByZXZlbnRpbmcgcG9vbCAwIHRvIGV2ZXIgZ28gZW1wdHkpIC0gSsO8cmdlbj8NCj4+
PiBZZXQgaWYgcG9vbCAwIGNhbiBiZSByZW1vdmVkLCB6ZXJvIGJlaW5nIHBhc3NlZCBpbiBoZXJl
IHNob3VsZCBpbW8gbm90DQo+Pj4gbGVhZCB0byBmYWlsdXJlIG9mIFZNIGNyZWF0aW9uLiBPdG9o
IEkgdW5kZXJzdGFuZCB0aGF0IHRoaXMgd291bGQNCj4+PiBhbHJlYWR5IGhhcHBlbiBhaGVhZCBv
ZiB5b3VyIGNoYW5nZSwgcHJldmVudGluZyBvZiB3aGljaCB3b3VsZA0KPj4+IGFwcGFyZW50bHkg
cG9zc2libGUgb25seSB2aWEgcGFzc2luZyBDUFVQT09MSURfTk9ORSBoZXJlLg0KPj4gDQo+PiBQ
b29sLTAgY2Fu4oCZdCBiZSBlbXB0aWVkIGJlY2F1c2UgRG9tMCBpcyBzaXR0aW5nIHRoZXJlICh0
aGUgcGF0Y2ggaXMgbW9kaWZ5aW5nDQo+PiBjcHVwb29sX2lkIG9ubHkgZm9yIERvbVVzKS4NCj4g
DQo+IEJ1dCB3ZSdyZSB0YWxraW5nIGFib3V0IGRvbTBsZXNzIGFzIHBlciB0aGUgc3ViamVjdCBv
ZiB0aGUgcGF0Y2ggaGVyZS4NCg0KRG9tYWlucyBzdGFydGVkIHVzaW5nIGRvbTBsZXNzIGZlYXR1
cmUgYXJlIG5vdCBwcml2aWxlZ2VkIGFuZCBjYW7igJl0IGRvIGFueSBvcGVyYXRpb24NCm9uIGNw
dSBwb29scywgdGhhdOKAmXMgd2h5IEkgdGhvdWdodCBhYm91dCBEb20wLg0KDQo+IA0KPj4gSSB0
aG91Z2h0IHRoZSBuYW1lIHdhcyBzZWxmIGV4cGxhbmF0b3J5LCBidXQgaWYgSSBoYXZlIHRvIHB1
dCBhIGNvbW1lbnQsIHdvdWxkDQo+PiBJdCB3b3JrIHNvbWV0aGluZyBsaWtlIHRoYXQ6DQo+PiAN
Cj4+IC8qIENwdXBvb2wgaWQgd2hlcmUgdGhlIGRvbWFpbiB3aWxsIGJlIGFzc2lnbmVkIG9uIGNy
ZWF0aW9uICovDQo+IA0KPiBJIGRvbid0IHZpZXcgdGhpcyBraW5kIG9mIGNvbW1lbnQgYXMgbmVj
ZXNzYXJ5LiBJIHdhcyByZWFsbHkgYWZ0ZXINCj4gY2FsbGluZyBvdXQgZGVmYXVsdCBiZWhhdmlv
ciwgYWxvbmcgdGhlIGxpbmVzIG9mICIwIHRvIGRpc2FibGUiIHRoYXQNCj4geW91IGNhbiBzZWUg
aW4gcGF0Y2ggY29udGV4dC4NCg0KT2ssIGNvdWxkIHRoaXMgd29yaz8NCg0KLyogRG9tYWluIGNw
dXBvb2wgaWQgb24gY3JlYXRpb24uIERlZmF1bHQgMCBhcyBQb29sLTAgaXMgYWx3YXlzIHByZXNl
bnQuICovDQoNCj4gDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:16:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:16:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301413.514397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmbU-0003jt-JP; Fri, 08 Apr 2022 11:16:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301413.514397; Fri, 08 Apr 2022 11:16:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmbU-0003jm-Fu; Fri, 08 Apr 2022 11:16:36 +0000
Received: by outflank-mailman (input) for mailman id 301413;
 Fri, 08 Apr 2022 11:16:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncmbS-0003jc-96
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:16:34 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 57071bb8-b72d-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 13:16:31 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57071bb8-b72d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649416591;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Ky3iroG1Yy0kR0KlTHtg7jmW1vpDs+uS0YRCiszdGJs=;
  b=JqCxJ2JBAIdeMVMC8AcYAeVi51tuO12UBdzwcggbNKI1C4RVkL8utlK3
   sYCprXG2ty0IqHGhJ2Ts8OnYOvQOWKz35Zaih73b1wzzofhpYOLYtxiZP
   G0sQ5s6VohCFZAGFBi081COXi8MpSn9GJPrcbVuhYMhusNviRGlNB8Yjo
   U=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67773439
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:O66NN6+Zb94I3HZcXYfoDrUDcX6TJUtcMsCJ2f8bNWPcYEJGY0x3y
 DZMUWyHPv7fNGShKt51b4mz/BgE65bTy9FqHFM6/n08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YDpW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYe/UxUtBIj2ou1HayRhEht3FKhm8rCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4RQqmFO
 5FIAdZpRAzZeD8UFwslNLYVwea1r1SgVxMDo3vA8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt7XaEluLJ2yThV+o6GLOx+fFrh1mS7ncOExBQXly+ydG+kVWiVslDb
 kUY/ysohbg/8lSxSdvwVAH+p2SL1jYeRt5RHusS+AyLjK3O7G6xBGIJUzpAY9wOr9ItSHoh0
 Vrht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJob10yVCIw5Sejs04OzSWqYL
 y22QDYWnLoJn8ox8p+B9Ar/vgutnJHgSy4/6VCCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U
 Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQQ3d6TN4QhB7JJKkWp4xDhlbHlkPc8fEdMCS
 B+C4FgBjHO/0ZbDUEOWX25TI5lypUQDPY68PhwxUjaoSsIsHONg1HszDXN8J0i3zCARfVsDE
 Zmaa92wKn0RFL5qyjG7L89Ej+N6nHBjmDOMGsmip/hC7VZ4TCTIIVviGAHQBt3VEYve+FmFm
 zqhH5XiJ+pjvB3WPXCMrN97waEiJnknH5Hmw/G7hcbYSjeK7FoJUqeLqZt4ItQNt/0Myo/go
 yHsMmcFmQGXrSCWdm23hoVLNeqHdYxhtkgyISFEFQ/ugxDPl670t/xBH3b2FJF6nNFeIQlcE
 6FeK5rdWKwWItkFkhxEBaTAQEVZXE3DrSqFPja/YSh5eJhlRgfT/cTjcBep/y4LZhdbf+Nky
 1F8/ms3maY+ejk=
IronPort-HdrOrdr: A9a23:adNX2qu+LGRer1iet0jTsh6x7skClIMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzE4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 LxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72PeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl5Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbprmGuhHjHkV1RUsZyRtixZJGbEfqFCgL3Z79FupgE286NCr/Zv3Evp9/oGOu15Dq
 r/Q+FVfYp1P7wrhJJGdZc8qPSMex7wqDL3QRSvyAfcZeg600ykke+D3Fxy3pDvRKA1
X-IronPort-AV: E=Sophos;i="5.90,244,1643691600"; 
   d="scan'208";a="67773439"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YTIPbd402Vd00pq+NH+ZhnqQjAGhRCsjM9fDz/VX1FbRH8Wn1Gyg1NnjM57XSxLBs74EV5qz9N+cLlzk/UAAkrCmvDUqnXD6TpYd7WwplI4j6xoAttF3wuK7ZeEjZb+lvowcSasWvDpgJa9+NcG89stbbkX27NDg0K52BFuGXA64LjSab3kdMLlIR0+ej21icRksRvuvlahRNg5QuaHDKQwGPxIBLDkTAP1yxKAVlEATODFIN3GuG9QOnpwk5bWFeoyGzMx1hZDjTphNR2eAECzKxoIbT1+IaqjFDESTXN8FUw9EGZWv9lHlwi8/NXA75wAS8mVHqCyLnnF7Z0l76g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DHBUewqf1lhrLr+WV0/oLjO4AS+vJmrXN10z5b0fMjI=;
 b=bsvKaTkh73p+bgI6rzoBwpNGKox8mlf6IhXrahpHVYy0ZX7Y+6vGrGK5b7xLD6TTVltb3rJQcUUWwkorpmUOotDY+iPwYdZ9neoX+5hA5aQv0bT3cTp0vGLCnc1iyxwFhZgbCt3YJBEJ7dCboj3tnRVF7W9qeq3fWx7XzVdTVCfyJm5eMgeSZLqVdfrpYjqTslbhMQ2X/03GbkAJT85SkvP2JP5PPep+hm9DLvYBxehC+bCIasvnC/SFV/3EgexGSJwwwc23Vit7H/4dJh/CQrOnQaQSysqfTde9ZlYSgwf1hhQn42JfCosHvgGl8a2fRBiwRNk9suWfNyVpsF2v4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DHBUewqf1lhrLr+WV0/oLjO4AS+vJmrXN10z5b0fMjI=;
 b=nipdkZ5UzGRMZCB9BwO0sc67aYUZZ+nBiVPurSrvkx+DQyTTXf0mOxs7n6j4RUk+EZUQoiyei05OzoYLD6nAcR29Zl8iS5mOktkobC20EPCz2rIIdC1SaOe8GVYx/YC7aMbjDI1Ite82KSNnT0QPDIDoFUryZrcU8P8mnmUVAV4=
Date: Fri, 8 Apr 2022 13:16:21 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>, <xen-devel@lists.xenproject.org>, osstest
 service owner <osstest-admin@xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Dario
 Faggioli <dfaggioli@suse.com>
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Message-ID: <YlAZhWVFziwoL0rb@Air-de-Roger>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
 <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
X-ClientProxiedBy: LO4P123CA0184.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fcc1f283-e11b-4dd0-5363-08da195138d7
X-MS-TrafficTypeDiagnostic: SA1PR03MB6628:EE_
X-Microsoft-Antispam-PRVS: <SA1PR03MB6628A9786558EC3309CB67238FE99@SA1PR03MB6628.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: X88hkNNQaZSXsRW040nIpk0H+MkOoFnjQ/lRpcV3E12ebYfjNxeo0hRWnfUKxnmhyNxCapfqxMjaC1rqMEgkemX+bsHkHLAZWFmTq92MaREdLzeV8hOH07wCfa1DMcseQ8sdOC2e0u8cnvLfMf07y+ilpu/yEV3DQE2C61gbIm+vGDw5DloYEo18YTpWOpTxsVTK2YIlbb9+pElJf43Aw6Vi+uwJ2aJ12UNaxkXHF1rpGTO+OYJf5inT1YUnZpHpwMKE1rlTSO44qmq82L/opRoqTUc7zOOgq5oM5hilaZ9XbiY6fyOc9n4l9bwhHG09GkBDh8HEANi/IzTYLjR7kBbS3Skbt9T7d/oHFLua04gJRyPLpxm+BMvop0tsCU0Yge+RKE2dMs3pg/DOpleFp+foXioyqBgpcH/23JoOwyGLbZbB+B24Ipj5KZcaY4v+98e9J1v5EzPtKday9b9l4OO+wzV3f/KymwSG3eYiDymsdAluit0A5UwfnxRmB0X15G5RxWLORV+qRLl7djSdce5/oFrLIr/eswfAq/DqxBo7++9TPtYK5Yy9joXwPq/criXQq+6L4vEpnYoU3sDzvjGIGDAEAkZ2coE9CK5Y6JSjYSDWB/9k4x/cmuM+Coaf2zzP7H65VJrhz9t8plLCnw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4326008)(66946007)(66556008)(66476007)(8936002)(38100700002)(6512007)(33716001)(82960400001)(9686003)(85182001)(6916009)(86362001)(54906003)(6486002)(508600001)(6506007)(2906002)(53546011)(5660300002)(316002)(83380400001)(6666004)(8676002)(26005)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0pCblRHNFNuMkhLVGp2SDNiTFpwWHlIUVFacGVGVjBXdms5ZjJFTnRORGg4?=
 =?utf-8?B?bkgzdGlBMklOR3hKWlhYbnBBMWJQQ2orYmNseC9HWUt0Q0hZeUE0cGRjMVpZ?=
 =?utf-8?B?Wi9DTVVXUThQdmFBRlE2YlhRTWk2b0dTVnIwOVhqZUNGcnJMNGhIcVplQnBs?=
 =?utf-8?B?UGluZ2dCSm9VM0FWRlVVdS92TUFlK3VNZWhaUExVamdsRW0vMld2ZnhDWHZy?=
 =?utf-8?B?RmZxZ1JyOWJqS1RnNlRyMnFYVkMwdGlBb1VteEpHUG5rN3hBcUpxOTFEeWdU?=
 =?utf-8?B?TnlvOEVVaDZuOXVSdFdydzBaWHhvWjRkSnJ4d2dMWGVKbVphNUhDTXZQSTdk?=
 =?utf-8?B?TW9ycHZob0x1YzV1MXIwWGZLRU5QWFVFYXdWV0RUSGkvYjZCdWtQKzVtWG82?=
 =?utf-8?B?eE1tU2loSElvKzBIWlBCT2hVcU5yQ0lFTCt4QVVyaW8rbHVnaWo1cDJlOWJ6?=
 =?utf-8?B?VmtHWjk0VjIrZHh6WmZJWkxrVFpxOVN2b01QYUlqWmdWQm9vMkRTTEx6VWQw?=
 =?utf-8?B?a2hYLzJBWGkvN2ROeDJTREp3YnRia3IrR2h5VlNhazRkMHR3SEpOdnJ0aXRt?=
 =?utf-8?B?YWpGa3hwNlEzSVJnT3VDdUJ6dGk2S0F4QWpQNThKZjF0bUwyZjZ0VHQyQ0pv?=
 =?utf-8?B?MEVZejRTZDMvT05YNVFITEtNMjRhZzNWbncvZWRPTlp3enNrMVVyTUFWNy9l?=
 =?utf-8?B?KzRDZ2lpRjBDbW1hUU9tQVh5TWNzVUdObGRPZkszZGdINUdvSDVMMDJTa0Nm?=
 =?utf-8?B?YXh2YTlBS0NYSnE2WXJDWElKcVl2dmZsUlVHRkl3SjlWRlZFbE1YOElWdlg3?=
 =?utf-8?B?dllQWnBjZUxaTHpkM0c4Tk93VUUvc2tJR0oyaTFiaG5KM2JLQXRhNTk0d0Yy?=
 =?utf-8?B?YTZ0ZzhpaDlHL08wa1pIQ3FVSVhDTGJsYytQbjFSQjBlZC8yMzN4amQ1aE51?=
 =?utf-8?B?bE5weWVhYzYvN0tnQ2lvb1d0aSs4WWlLV290UFlVYjFpcXg4bTBVL012U1JN?=
 =?utf-8?B?UTJpbWFzUWhVbSswOTBOSGt6NmJyWWx2VXJUZGtyaDhaaFBRRHkvUVpGRUc3?=
 =?utf-8?B?azBHYnBnY3FpY2NpRmFOeDRZZXNUVEcwc20xem43NERHRnJEb2ovRkdaTDNX?=
 =?utf-8?B?Q05xLzYwenRQS0I2OC9xUWk2Ym13L3YvaUhaMlMzcGU3UmcrbGFMeFVqL1Vp?=
 =?utf-8?B?cUM1ZVg3VWJqQ0kzYXhCVVQyUHZSM25Za2VUU1A0dHRrZEVjVC9QSzFuUzZk?=
 =?utf-8?B?eEdtd1d4bmQxN240QlNBSDdLR0ovaGJFWDh2YTlNSEpMdzlVY05vbGs0TW85?=
 =?utf-8?B?M05rRGVtNmFIaEk1QU4xbXVOWjRoWHVHYXo3NW54dnRaY1Z2Zk9DUEwrcllG?=
 =?utf-8?B?MVBabjRIVkgzTWIyMkZWUThBelpNWWw2TG1yZk9YVFkyUVJ5UUN6N1NndmdP?=
 =?utf-8?B?Lzl4MVFsZm12dkpYdkNIYzBaQkpnNUxKRUxTNUtYS1gyV3VVdTVOY3E2WkJJ?=
 =?utf-8?B?OXE2WlBVQ3hQYWNzbDVtZ1J4YzVRaUQyckNHbUpNMXV1T0tWTnFtdjRtaHNE?=
 =?utf-8?B?aThwZlBZY21CZldpNlZvUTFBT0ROOHJwbnU1Slc5VTNONVYrZERIZ3ZzMkJB?=
 =?utf-8?B?MjdVNjVHWG16NldzcUUxZnJ3d3d5ZHFBMkp3YkdLTFFFY3FDVzFTc3ZPVUdp?=
 =?utf-8?B?Y1cwOEUrNFBrZ1U3SGw3eTAwd3BOM2FjdlZOVkllL2NSc0FLbGdqKzd6aHEy?=
 =?utf-8?B?QVlmb2NnQk95UExaVjlYOTRvQmE3Y1NRenBXZUlVNXluSm4vb2dpZll0RVEw?=
 =?utf-8?B?cnhxWER4MVdYOWFVRmFTNC92c1dlNVFxOFI2T01GRnl0eUtNYmNrWXlCbVlK?=
 =?utf-8?B?UnBQQm1MTDZmemtpNzZiUnhrNko1ZStkNlg2ZloxTTQyNi9CY0NLSUU3Mmlz?=
 =?utf-8?B?SWxTK3BvTDIzRGM4elVRY1E2MUxmMFdXOTZPamwyMC94bTJua1hHUERaM2Uv?=
 =?utf-8?B?UDRNaFBrdS84RVFFNkZ4ZmNCWVBlbElVdWlWeVRlQWVBOFBQYzFWeXZaMm9Y?=
 =?utf-8?B?bkhyTmpWeUh0eUs5bE84U1hhdEVaMmRxQWxqSkJxK0V0c3VrWkwvMnFYM0Ri?=
 =?utf-8?B?cytJT2NWNFk1Tkd4ZzZ6aDFrRy9zdlBuTUZyNjI3RTdjS09sK0dyOXpyN3ly?=
 =?utf-8?B?a1gzZ1MveFZsN09peXJKYUc3bk1FVmNCYVA2RktGZ0l0N1FZVXZJcEZWRExK?=
 =?utf-8?B?VHduVDBOQ09ISDBnMXNPSm1hbnNWVTluTjU3OUthZkZVc1B3K1pGem1OSkRR?=
 =?utf-8?B?NEkzMnR3S3ZUWFpsZis5cTZlMmVxTS9CcTZwTFBMMVk0dkFJeE5uRW9MbHl5?=
 =?utf-8?Q?uQjuytQBoeO2XD4Q=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fcc1f283-e11b-4dd0-5363-08da195138d7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:16:26.5057
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j2Mbj+uH1LoxfdLFl/RR5EdpdDzY7KL0jhqNTbk8QMZBrlO6AgqPpBg7v1v9DfO/0wz+qrGkFuzNGgjH/J7Lmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6628
X-OriginatorOrg: citrix.com

On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote:
> Hi,
> 
> On 08/04/2022 12:01, Roger Pau Monné wrote:
> > > > I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
> > > > uses 16 for example.
> > > 
> > > I'm afraid a fixed number won't do, the more that iirc there are
> > > systems with just a few cores in the pool (and you don't want to
> > > over-commit by default).
> > 
> > But this won't over commit, it would just assign dom0 16 vCPUs at
> > most, if the system has less than 16 vCPUs that's what would be
> > assigned to dom0.
> 
> AFAICT, this is not the case on Arm. If you ask 16 vCPUs, then you will get
> that number even if there are 8 pCPUs.
> 
> In fact, the documentation of dom0_max_vcpus suggests that the numbers of
> vCPUs can be more than the number of pCPUs.

It was my understanding that you could only achieve that by using the
min-max nomenclature, so in order to force 16 vCPUs always you would
have to use:

dom0_max_vcpus=16-16

Otherwise the usage of '_max_' in the option name is pointless, and it
should instead be dom0_vcpus.

Anyway, I could use:

dom0_max_vcpus=1-16

Which is unambiguous and should get us 1 vCPU at least, or 16vCPUs at
most.

But given Jans suggestion we might want to go for something more
complex?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:20:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:20:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301423.514408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmf1-0005Qp-1T; Fri, 08 Apr 2022 11:20:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301423.514408; Fri, 08 Apr 2022 11:20:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmf0-0005Qi-U5; Fri, 08 Apr 2022 11:20:14 +0000
Received: by outflank-mailman (input) for mailman id 301423;
 Fri, 08 Apr 2022 11:20:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rWku=US=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1ncmey-0005QX-Ly
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:20:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id da8c6099-b72d-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 13:20:11 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-WZ0QwXQEM22DUp9cl3wqPw-1; Fri, 08 Apr 2022 13:20:09 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by DBBPR04MB7515.eurprd04.prod.outlook.com (2603:10a6:10:202::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 11:20:08 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa%4]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022
 11:20:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da8c6099-b72d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649416810;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tpHOOFkNLOW3CUFaBJazP3CHbIw6xQpArDcPv3B12+E=;
	b=W+YK+ZZaZ51JHyh7a9U/umdFgcbflfApwo7vF00I/uIb2cC4B6n/theJv7XqYHk3eHhiUd
	G9bGKMNdAzZlyg+J2zDFD66u8r5/OcAacBfRlo6/zRSr6hF1Up0r3POuuIAhG1b2/AWWTw
	Vy0pDIAMgO4ZaQKRsytEK5BQmUi5zeA=
X-MC-Unique: WZ0QwXQEM22DUp9cl3wqPw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ifEcXAXfrvdCUEwHQJbNupEmU5pm3xBLfExYjJYuekZ4g/2kO7kw6Fx49+giWVp5Xp9RHlkkkaHZ7e5Oa6hNKzPrDdkXADLBzccQgxNyrbL+CKAAh5PCMJjXv6eF1zPFaw555xc0yaGTMS0IL8OeFbCkD4z99nmYL+W6DP6AGkTmtpqi8yvI/zPvUrZyaHhUNqb8OKSvzMOx4D3o7nwcfyoBRKiAyVmL4T27ZNGaZQQVxkic8FRAzUFk3Yhgu7rC7T9yG88MCIc4Mp8mbCNxfAPQq50/OIje8G/eB0bEzCYD1OHY063A3lYvmiy3RD0rOiUib/xzFxE8ypA2mSVjXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tpHOOFkNLOW3CUFaBJazP3CHbIw6xQpArDcPv3B12+E=;
 b=bMN6j/WqxKAPJseSx9T70Ptm5Gze+NmceuUS4fJ7YKj3fTib2dIJfQvYmnhGZeiycfzFofcb6RH9+AR14OcinNA2Zp97QfP9by8JoKXejsyQBkF2uDXoAXj9cHstxJCKfy1U1yiAeb8XE80A/vONWOYPRRGnx42MB+cEh4++dYMVUeI9vM69bKJLX0aufRiHFboSpVQ+TDTPGMW/BCpb3Giv58q/HkG39N+3GhKFNmkZNFJNGuqLFg1B+W9YCl/hjFwX0tTuYvlJJusr3Vk82l3vpTrNc8mge3rdL7EVRxzv4wbj9/tDajnRMSC05fPqWbWv8G176RDkYcMfx4T/3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "ohering@suse.de" <ohering@suse.de>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Topic: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Index: AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2A
Date: Fri, 8 Apr 2022 11:20:07 +0000
Message-ID: <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
In-Reply-To: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 62b0a344-f18c-47c9-5794-08da1951bd13
x-ms-traffictypediagnostic: DBBPR04MB7515:EE_
x-microsoft-antispam-prvs:
 <DBBPR04MB7515DC8110F3FF1940B06AC4C5E99@DBBPR04MB7515.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 rgz0TjdlEUI87fueMkBDDrmtLV31Kv4qP0mU2nSlHGQABWMybRLHJDkdgRbJu+fbX16d9E4LMO3NUu7oiFPk4Ne6bF7Yxi5kQxI+a8ydUmpUpfKeUD/2Qk2+Wv4bE3iMk6qLgezfEHh24UYZlC0g6ngxmNmwb/KCYntujBufKBQx+zWyH2/4rDT0bZthqO0TZKCczKkd7GuISOiFuxHeOk/DNPl3iqvJ8JH4UFnv4T6hOPdhpFckfH/mUmN/MmKM0MCPpXhwsMtlc8Hc+2QdOuEFLX/W2YL15lITTuQr6bdsMWG1qF5NWlY4l3omQfiqbF4eXIoTs1FhMl363/1U7lJH5Li2tkZaejWqszRShv8ea8Js1mESiU9v8DOadKsXSi8qweZVDAN7oAgd784sH8v/R5Qhh1sThAHfEQcyWbwwZH5SkvGd4dDUK8i1frZ2BqjTzadigeB3/EM3yOT7U37CQa8SK+vcWmGJtnV8nLCLEkNTEt2tRQ69U8gv/uX4mIeQMSLpH0Jqp6gu1jzjPqMypSnSoODGzCRa6hLdN2pL7gHUwqw6dyyyjR1yDpSGcP7mxCu0pWm4AmyuO+Iyx9SotiWNfFj/f+d42giJvP/Y6ggrr4z+B5iOWACkX4ZNwUOxFx73Uk0DWY0RDs+X3fO3hOj6v7+oMe/8dNcxz2PiaG9dlZyI+XabVqa8aIuSLWP4BwhYxqHPEWh6C50WMoZaapGpOoJX9/5H9VbSSRjsRY5xyViTqQ+jh6FwWr+YzfwBE92p+KHljbAHeNIP0bll9vXBJTOEl8K+XyAR76CGlgZGYSGhkN3nwTkF9ZlN
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(99936003)(122000001)(38100700002)(316002)(5660300002)(8676002)(66476007)(4326008)(66556008)(64756008)(66446008)(86362001)(71200400001)(66946007)(76116006)(38070700005)(2906002)(91956017)(8936002)(6506007)(6512007)(54906003)(110136005)(36756003)(83380400001)(186003)(6486002)(26005)(966005)(2616005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?T2t6bzIrVVRWcndOMzRJeWswSC9rc2Z0SE9sOW55bkZFVjA1dHdTQ0RUV01G?=
 =?utf-8?B?cjV2ZWdoVGMwZTFwZWxKa0NqNlZLNW5jZStEWlFSdGIzRXNxV1NrQ0M2T0Mr?=
 =?utf-8?B?azZZS28vRjJ0UzUxU0RpWnVIcjYxKzdYZEdCRG5WcmRFKzQrNk8wZEI1Y0Za?=
 =?utf-8?B?T2VmQUhRTksvR0J1am1naHZrbXhTTG9Rb2M3N1hDMUZBbGV2TmxWSkhCOEw4?=
 =?utf-8?B?ZitFT0QxYjdyQWpieGJ4ZUNsaEt1M2c3ZElra2tSR2lzdnZ5VEdSMlBhZmpG?=
 =?utf-8?B?eUlRdlhzc3NiQ2pJSUoyb1VIekdLalpLeCtCR2VSMkVhSzFaazZGVk5WT1Vo?=
 =?utf-8?B?YnZNUWRodFE4b3BpL3J6bXJHQk5XQ1NUdjZSelBaTU91SEl6SHVVUWQ0Ymw3?=
 =?utf-8?B?bXNBMFJ2UGpWSzAvdU1xSVQ0NllYbGZaVGJVbWVvaXRBN3NpejF5aXN0Z1kz?=
 =?utf-8?B?aE9NOG1vYUJPSmFTZm51YWtvVnpyUmU2SzRqWDFwSnpmaWZqbzJ3YldNWUYw?=
 =?utf-8?B?LytXYkgyRndMKzNJbExqME9QSGJPc0syYnU4NHNmeVI1YXhxREhUL2RuNkxD?=
 =?utf-8?B?RXNrQlNGT0lTa25IVCttakhENHFMRHNiMEpBR0M4Ymw0N3ZBUmYrQmQvelBU?=
 =?utf-8?B?UElyQ1RDNHBaREdoWnptWHZ4SDg0K3VydDlUYWdMUGxON1BuL0cwS1RDWkhL?=
 =?utf-8?B?S3N1REZRMnpweEg4ZmVPZStrcnI2ZHVTSy9hb0xORER4a3dXYTlMQmc1MjlW?=
 =?utf-8?B?K2hGSzFNeU9Oa05QQWkzeS9BbXFDY2o0VTMxb1Q4bzBtTVl2M3hJWTR1M0hG?=
 =?utf-8?B?SklMM2FqTTU5cGo2bVhYMjRlTkcwckdaUUxjNllTQmV2Q2phQUdnT1BRWTgw?=
 =?utf-8?B?YlpDMU1mYlljaGd1TWk2aHg0WkRHVnBMZmtMdWhaL0lQcFg5YVU2Qzg0eEIx?=
 =?utf-8?B?MnVibkRLQUkyOFMwK1ZxVE5MWE4rYi9HSVZlOHlyTlBYMWR2RVUwbmVuWEFI?=
 =?utf-8?B?eDVBSTNtWDVsQWFKYVY1ZzlIcG1SWmtPRDQ5d04zQkpmM0FFUW80d1Iya0h0?=
 =?utf-8?B?Y2RHczNHM0hoVDRXNlM3eHJGRjNxTjRHcGdQRkl0cjkzTDl1Q3NSaW9BeDl2?=
 =?utf-8?B?bEl3MnhUQjFNeDJ0Q1dxNzg5TjU1OGhqZWoxY3htZkNjOGpndDVmNmZxbEVq?=
 =?utf-8?B?NlhsbjQ5NFZpSEpuUUsvdWlTUElPZWpJK2QvenBrM1B5S1FCU0VBTXM2TXFF?=
 =?utf-8?B?TzdmbkRjc1I0NU44VmZWV3ZZNXA4ZGRPbFRCM24yOVVHSkdPZUl3T3pCZFpF?=
 =?utf-8?B?VmY5bDFKMnpNRkVWNlBJblN6MW1ER0dtRVJQTkhpUWFWcDRiNlVXMmk2ME41?=
 =?utf-8?B?L1YxaWVXL3ViYVJrc1RXVnNYWmlROEFHbmovdWptSnh0OHhkSCswNlNUdFpB?=
 =?utf-8?B?ZkhUUnJJYVpHa1VDYSs4Zk16QWlyZE8zUUZjSzhvOW1LTm9pUUU3eVFKMElD?=
 =?utf-8?B?ZW1jMkhReUl1a1ZLd0VJYTl4MFlMaGRjT01vRk14alo0ekJPUTQ4UnV6K1Bk?=
 =?utf-8?B?emZJTDdDZnhXWU1DNU1hQ3J3UlE5b2xEeDJVS2UwaXcvZjlMWlRPUkVvNnov?=
 =?utf-8?B?aURsUE5lTDdUS1B2ZVQ5ckltRkxlNXRTck5DYjZjSUhWVm12L0VhMWZNRnVU?=
 =?utf-8?B?aVZSQkNNelBsVGhkRzZoQ1FyOE42VGIxMHpXYk03ZkM0UUpVWTNseGRsaGZo?=
 =?utf-8?B?WHhTTC9rRXU0T0xyemt4cUovR0VNcm5RMFFUNUNlekc5ZEFYaHl5NTZHRkxj?=
 =?utf-8?B?KzNpWGJiRGdGMmR6L2pQUjJ2UHpWZUJhQjNsVVVBSGo5aGQydTF5ODZWTWtM?=
 =?utf-8?B?Y01FajFoVVFWZTZIY0JBbXNjVFZkQ1BtWGxzaENJSXpMcjZuWTNmdDdUVHp2?=
 =?utf-8?B?V2o4K2NFYUp1V1d6dnBQQnFHazRsaDZpWUM4UFYvTWkwbGdvdnZES09EdXZo?=
 =?utf-8?B?RjFvWXF0ZkdXcWF5MEdINkZyNHNBdUQ4T3d3VmZSZDFVOUY3K0x1NlBKQ3RL?=
 =?utf-8?B?ODZ5UksvOEg0c2NHbUhYTjhTNE5UbmxFK1lUWTVRWWhYK1J6Q2llekhwUVRD?=
 =?utf-8?B?cTEwd0huZlRhUEcwK0xvN2dCamNIcEluaVNkQnFZTTUxbEh2MUl0T0lsdHA2?=
 =?utf-8?B?b3J2Ti9yWFBRRVU5RDhtTmt4aWgrM1M1THhXYWozU09EOUl5L085eGRXQWZz?=
 =?utf-8?B?eDYycno4b2wvUWZYbGVYTU0yRE9SZkFrVDdzTWlWY3VXUU0wZE1mTGswS3Fp?=
 =?utf-8?B?b1RIdkczeEJSbXJ3a2JETGx0czBzUzZoSEJQTXByRXBUVmdLQkU3UT09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-BrWJb1CqFi2RJpl9K0CU"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62b0a344-f18c-47c9-5794-08da1951bd13
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 11:20:08.0459
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6IQJw+f0K08aBUieHB6JfEIBK3uAprTgUYA1h4XKBHu8fVTW7JhUAD+1QOic/TqZACWW/5SH5sQaa0xj/Pvxqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7515

--=-BrWJb1CqFi2RJpl9K0CU
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2022-04-07 at 15:27 +0200, Jan Beulich wrote:
> ---
> The Fixes: tag isn't very precise - it's rather the commit exposing
> the
> issue by default. I haven't been able to identify the actual commit
> which did introduce the problem; it may well be that it has always
> been
> there since the introduction of credit2.
>=20
> Credit2 moving the vCPU-s off of their initially assigned ones right
> away of course renders sched_select_initial_cpu()'s use of
> cpu_cycle()
> pretty useless.
>
Mmm... you mean that Credit2 is moving the vCPUs off they're assigned
ones _right_now_, or that it will, with this patch?

If you mean the former, I'm not sure it is. In fact, when
sched_select_initial_cpu() is called for dom0, dom0's node affinity is
just all nodes, isn't it? So, the we can pick any CPU in the cpupool,
and we use cycle to try to spread the vCPUs kind of evenly.

If you mean after this patch, well, sure, but that's normal. Again,
when we pick the initial CPU, we still don't know that the vCPUs have
an affinity. Or, actually, we know that in sched_setup_dom0_vcpus(),
but there's no direct way to tell it to sched_init_vcpu() (and hence
sched_select_initial_cpu()).

That's because, by default, affinity is just "all cpus", when we create
the vCPUs, and we change that later, if they have one already (due to
it being present in the config file, or in the dom0_nodes parameter).

Something that *maybe* we can try, since we're handling dom0 vCPUs
specially anyway, is to directly set dom0's node affinity to the nodes
of the CPUs we have in dom0_cpus, before calling vcpu_create() (in
sched_setup_dom0_vcpus(), of course).

This should make sched_select_initial_cpu() pick one of the "correct"
CPUs in the first place. But I don't know if it's worth, neither if
we'll still need this patch anyway (I have to check more thoroughly).

>  But I guess that's still useful for other schedulers.
> I wonder though whether sched_init_vcpu() shouldn't use the CPU map
> calculated by sched_select_initial_cpu() for its call to
> sched_set_affinity() in the non-pinned case, rather than setting
> "all".
>
If we do that, and there's no affinity configured for the guest, or no
"dom0_nodes=3D", when will we reset the affinity to all, which what it
should be in such a case?

Also, if I'm right in my reasoning above, when we come from
sched_setup_dom0_vcpus(), the mast calculated by
sched_select_initial_cpu() is basically cpupool0's cpus_valid, so this
wouldn't really change anything for the problem we're trying to solve
here.

> (I guess doing so might mask the issue at hand, but I think the
> change
> here would still be applicable at least from an abstract pov.)
>=20
I don't think it would mask it, but I do think that, yes, the change
you're making would still be applicable.

And, about it, One thing...

> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -3403,9 +3403,15 @@ void __init sched_setup_dom0_vcpus(struc
> =C2=A0=C2=A0=C2=A0=C2=A0 {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for_each_sched_unit ( d,=
 unit )
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 spinl=
ock_t *lock =3D unit_schedule_lock_irq(unit);
> +
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed )
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 sched_set_affinity(unit, &dom0_cpus, NULL);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
sched_set_affinity(unit, NULL, &dom0_cpus);
> +
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sched=
_unit_migrate_start(unit);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unit_=
schedule_unlock_irq(lock, unit);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sched=
_unit_migrate_finish(unit);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
> =C2=A0=C2=A0=C2=A0=C2=A0 }
> =C2=A0
... The result of this (also considering the call to
domain_update_node_affinity()) ends up looking very similar to what
we'd get if, instead of calling sched_set_affinity(), we call
vcpu_set_affinity().

I'm therefore wondering if we should try to just do that... But I'm not
sure, mostly because that would mean calling
domain_update_node_affinity() for all dom0's vCPUs, which is clearly
less efficient than just calling it once at the end.

So I'm thinking that we can indeed do it like this, and add a comment.

Anyone else any thoughts?

Thanks and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-BrWJb1CqFi2RJpl9K0CU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJQGmcACgkQFkJ4iaW4
c+4uEQ//WnkUf1ReyzLAcyfHdp5yUXA7m0Ybvm7FPjFQLbUf9xHfyDue28XVxpWs
3RDmCkuTGb5/JyO4Jd4EEtnmPa11N4UCeGF7/c9vZNprBfCFFvNsRDSzVQKRnJTO
MlIKqcQ8/mgAHnjNHWKoR142XW1iRnoFqStgXhxT95lqdICruqHabYJzW+7i60HF
MFDQEuYx98Klx1MilWhwIUbUHcm5qwuHb8RyDM4vmksqIzZbWiCR+OIczlvPMOVE
jL7skqph9Cgj3g/Fl/RylDG0/IDsL4nPTTiEA2/MpZE2ar0kNqphq/X0kLYTu0HI
SVb2rGpTmqiWUgzT0a+FX4Es5HMe1VNyPVcY5PHjiyVgeGN2Sv7MVaPpeoPBBR2J
gf0LSmGgcxC0xQ7B7r5i2INYnmwodVJ4a9rxmVQmiF4G0656W9GV1v5QJKMJ2LgB
08eJg140xAH7J4vH9oek2vIfJK/m7chPWB/JmqGWXMw/dcErXGvSy7gf0PpJfOkV
3O8rZyacpz4fhURC61FPpfBPknF0l3r7iCKQ7r6CUfhZyJOrRkTH+h+3aJt1RnYN
nR0cWOLFw0aIG4E1ypqHtW2NFBy/hRAiJg8wulAvKds0Hvii9t9RfaJkHaDa+U5C
p9RkjT1QtTiRh4OUS3Zu8Ith6sqXjW2VFDWB7ftPr6pqFs12v28=
=BnT8
-----END PGP SIGNATURE-----

--=-BrWJb1CqFi2RJpl9K0CU--



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:24:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:24:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301428.514418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmjC-00068A-Ls; Fri, 08 Apr 2022 11:24:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301428.514418; Fri, 08 Apr 2022 11:24:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmjC-000683-Iy; Fri, 08 Apr 2022 11:24:34 +0000
Received: by outflank-mailman (input) for mailman id 301428;
 Fri, 08 Apr 2022 11:24:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncmjB-00067x-7R
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:24:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncmj8-0000ip-6R; Fri, 08 Apr 2022 11:24:30 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncmj7-0004Dj-VA; Fri, 08 Apr 2022 11:24:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=dfZYbA2+g/Mq99fHHN1OrLY+2tfL2C0kh8EFlYfSwWY=; b=SAp9nHwyDFp3xV2UM11rOB6SHr
	1b0DLR3sFuDR50sORuxDqf65qkYPnQNU1O+4BC+2j/kWXkcJ/YmFt/Xo49tVt+KnJKkDWj30N/s4a
	laOg8+rZbSpONMNexut4vU95Q2dRkm1Z8gc0lvugZGOMMUema9as4YDxi4NXJiZ963bc=;
Message-ID: <41fe950e-cbc8-1da9-02d2-733c6fe4bb7a@xen.org>
Date: Fri, 8 Apr 2022 12:24:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
 osstest service owner <osstest-admin@xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
 <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
 <YlAZhWVFziwoL0rb@Air-de-Roger>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YlAZhWVFziwoL0rb@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Roger,

On 08/04/2022 12:16, Roger Pau Monné wrote:
> On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote:
>> Hi,
>>
>> On 08/04/2022 12:01, Roger Pau Monné wrote:
>>>>> I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
>>>>> uses 16 for example.
>>>>
>>>> I'm afraid a fixed number won't do, the more that iirc there are
>>>> systems with just a few cores in the pool (and you don't want to
>>>> over-commit by default).
>>>
>>> But this won't over commit, it would just assign dom0 16 vCPUs at
>>> most, if the system has less than 16 vCPUs that's what would be
>>> assigned to dom0.
>>
>> AFAICT, this is not the case on Arm. If you ask 16 vCPUs, then you will get
>> that number even if there are 8 pCPUs.
>>
>> In fact, the documentation of dom0_max_vcpus suggests that the numbers of
>> vCPUs can be more than the number of pCPUs.
> 
> It was my understanding that you could only achieve that by using the
> min-max nomenclature, so in order to force 16 vCPUs always you would
> have to use:
> 
> dom0_max_vcpus=16-16
> 
> Otherwise the usage of '_max_' in the option name is pointless, and it
> should instead be dom0_vcpus.
> 
> Anyway, I could use:
> 
> dom0_max_vcpus=1-16
> 
> Which is unambiguous and should get us 1 vCPU at least, or 16vCPUs at
> most.

Unfortunately, Arm doesn't support the min-max nomenclature.

> 
> But given Jans suggestion we might want to go for something more
> complex?

I think we already have some knowledge about each HW (i.e. grub vs 
uboot) in Osstest. So I think it would be fine to extend the knowledge 
and add the number of CPUs.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:26:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:26:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301432.514430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmkn-0006ik-2O; Fri, 08 Apr 2022 11:26:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301432.514430; Fri, 08 Apr 2022 11:26:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmkm-0006ib-UX; Fri, 08 Apr 2022 11:26:12 +0000
Received: by outflank-mailman (input) for mailman id 301432;
 Fri, 08 Apr 2022 11:26:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OHy9=US=citrix.com=prvs=090a3f169=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ncmkm-0006iL-93
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:26:12 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af16dbe0-b72e-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 13:26:09 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af16dbe0-b72e-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649417168;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=7rYjZmCw0+UEOys+hXlQKe9S94XsKq7tUj4vhZkqTYo=;
  b=iYwxlpG8jt+wJ+jiv7njjaP81BlTA/sINxWJMkWGLIpXFyeuufiFbtaA
   okxqd/K+fJQM3lewXkquPk9OnmV9MkJ6u8H/fS//5F52Z8c1TS03ObV23
   8zTcgl+Btw7XmpYiDSjJM+urrzr6pla+WMkCMhESeqRD7pOVsxrRxSxt3
   I=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68248977
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:F0qCZq4mH6fdFhfzMhLgdAxRtM3HchMFZxGqfqrLsTDasY5as4F+v
 mRNDG6Ga/aKamDzf412OY6x/EgC7cLXz9Q3SQRrrH88Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThU1vU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSWbj0FGO7ih9gYfAhgPTtvL5Ecu7zYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RJM2Y/PUufC/FJEkpNDJQAk+6wvH6heCcE7xWH+4hm5lGGmWSd15CyaYGIK7RmX/59hV2Er
 2jL+2D4BBAyN9GFzzeBtHW2iYfngifTSI8UUrqi+ZZCjFOayWMSDxkXfUCmuvT/gUm7M/pYM
 FcI9zEy6KE+8U2tZsnwWQWip3yJtQJaXMBfe8U49QWMx6z88wufQG8eQVZpatYrqcs3TjwCz
 UKSkpXiAjkHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXryos1LSfDvyIevQHepn
 m7M/HNWa6gvYdAj8YKB0XaErS2Qo7fYdiAv9xfrBCGm8VYsDGK6XLCA5V/e5PdGCY+WSFido
 XQJ8/SjAPAy4YKlz3LUHrhUdF29z7PcaWCH3wYzd3U03271k0NPa7y8992XyK1BFs8fMQHkb
 0bI0e+6zM8CZSD6BUObjm/YNijL8UQCPYm9Phw3RoAXCnSUSONh1HszDaJ39zqw+HXAaYllZ
 f+mnT+EVB7285hPwjusXPs62rQ23C04zm67bcmlk0X9gefDNCHKEO5t3L6yggYRtv7sTOL9q
 Yg3Cid3408HDL2Wjtf/r+b/0mzm3VBkXMur+qS7h8aIIxZ8GXFJNhMi6ehJRmCRpIwMzr2g1
 ijkAidwkQOj7VWaeVTiQi0yM9vHAMcgxU/XyARxZD5ELVB4Ot3xhEreHrNqFYQaGBtLkaYvH
 6ZYIZ3ZahmNIxyekwkggVDGhNUKXDyghB6UPjrjZz46fpV6QBfO9MOidQzqnBTixALt3Sfii
 9VMDj/mfKc=
IronPort-HdrOrdr: A9a23:7k4YC6simCapg4nvCreWbcZr7skC2IMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPiftXrdyReVxeZZnMXfKlzbamHDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sZxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMEE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJppmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF491HqWxa0u
 UkkS1Qe/ib2EmhOV1dZiGdnTUI5QxerkMKD2Xo2EcL7/aJHA7SQPAx+r6xOiGplXbI+usMip
 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdw99Q/Bmcka+d
 NVfYnhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtR5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdY15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAp23G4gMyKeFPGC1zwdLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.90,244,1643691600"; 
   d="scan'208";a="68248977"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZWSLnDM0uwYjuKF4qfMNL3TP7HepH7Vx/7OkVdr/fWEeLJVndj0rUut2bd9ecwYevsiTDV7qC2ryS7VqzwbnmiMbanWHklAc8LJRG9BsrnxqvRvKkI4Qnfd14FXC4SCcj5WpYqqvdcg4i0COGSntpb7yX1c1xwp4GRhhaesM4R9PBCgngbwPPTY5xcPIISH3A5LU0oB3lD+uC/w0Ec7p3uC0vAs2cb2tQo2dDYTraBKkLsFl2sgjuxBN/rJ4NIBJqJ2mJc8sBZGVeTQhp0mRLkiDhkYuY03/CZECwjEJv18o/iPur3ixZZjwYoD8HCIuwPk0sTo1r1RmzH6+t5+qAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7rYjZmCw0+UEOys+hXlQKe9S94XsKq7tUj4vhZkqTYo=;
 b=RNRuhatDlShMPSfPcqd6IjdgmcVMy2/lqpJCszTU4M5pnd1AfWTDFRuVazekDW9c8t0lXqfxTsxISwZMJXxBFbfgCyK+rVH8e16Imzqw/ovcmwOEprl/nv3dl6Kn4E/spYn3BxYatpdClb8IrI75SyPyGIsJYJKG7QqRbYMnzukmYG5Ft5Wo2W7m2mIN7Y9crnaQupwlGIel0ol83lyeyJg31JnsG2fncrxPnlZWiaVpYo1UPRayDbl+TJPVNCIz1wHTMfbw37n0fmH9TxKq43b/tgCYaGlWoPdKnS4VTTgwTvrceRiVvH6ujDIHV32Vj+s69YAgxU/0DyGif0/w3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7rYjZmCw0+UEOys+hXlQKe9S94XsKq7tUj4vhZkqTYo=;
 b=S/EM6hauRrZGjmS2vz9P3x0ChB3pVz02P4DsHQJF2QCnw6zeBdtbMcCa7+kYJ7C9UznzJbfvzatmrrfyMwBj39zEBUObxCog/fSgN0Wu/CHjRoDRePBgwXJ3D9Oia9bhFyhDudDqVYnVabhQjKUqv6nAp0V+lOT6H+Kc7UyVP1E=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"osstest service owner" <osstest-admin@xenproject.org>, George Dunlap
	<George.Dunlap@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, "Wei
 Liu" <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Thread-Topic: [xen-4.12-testing test] 169199: regressions - FAIL
Thread-Index: AQHYSlvwuwuenWmolE2vvQwyk4J/36zlmCOAgAATLgCAABUiAIAAGtAAgAAB2ACAAAUIAA==
Date: Fri, 8 Apr 2022 11:26:03 +0000
Message-ID: <22912e60-9cd8-2c68-ebb2-37392bce9436@citrix.com>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
 <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
In-Reply-To: <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ffd2b735-8d3d-4ea1-f3cb-08da1952910d
x-ms-traffictypediagnostic: DM6PR03MB3449:EE_
x-microsoft-antispam-prvs: <DM6PR03MB3449BC0AC8E254D9B1C3C9E1BAE99@DM6PR03MB3449.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 64g8CCrJRX7FJUWpPYMhmkYhZ/Mw5JICGEyljFjkB9tcSBosc1y4m9GQefL7bCwWyrrLzaMGBXcjt8z5tW48bV4By8ss1sVgLsTYI9mX2VNBKJX4jG3nQ1YofdjaElGuda3kSEE4vS494WfidNHaMozpoojrhHlgQWTn+f2ksBG3UlANGyFrpulSWywR5joDEqdqebXkC5w4IgcMpSadWBL38MoyEEyrk091KsV5P0TIaQlXC8MtJfnC7OfX0rzYvwF4q33z4+khlGIisLA74inEOAagdrh6bkkouGp6RH4qXruct1nZEj/vKZ6+9BgIp4R4g1h0PK4Qe4pkJgWD7+mIjOyiBRgvay4Z3z6KHvJlaVJdXsDtCLcMwX5SRXxLH2pcFFuFoiuzJTxtqOukbKldSgcmfoqNSOd0UcINKfT5M7H5a35Sr7+VVjSym5R2JdfdwuTGxhfl5Lp2riqItjoIE+xGPsslzSUiIzsKL7vksAfcvGPJOZn7Lwb1r6CGsZQOd8MmpzNACFBv/YTuVmw1+BY1ovGRj3IZ2XshQW4t/GTSGJuOfgGIe+R16B05S7bgr43WUdBWUw9VAqVidrKtAehdoXYxgyPt47Xi0vKbJPAj/uAG8pbDgTu4wii+X2KJlzxNyjZxrNijfTDwkWNkLYwS73GUKuYvIC034rttquGDWeLb8YnX0IZYTdODoqfjjsSns/C7ls5786RVdawW2l/+GBWcmD3HOpQAhmFx9uo3lnIrUOiWY+YoKrgeCZBsqEVMNyAhqycewZ6m9Q==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(31686004)(36756003)(6506007)(122000001)(5660300002)(38070700005)(8936002)(2906002)(31696002)(66556008)(91956017)(8676002)(4326008)(110136005)(66946007)(26005)(186003)(54906003)(71200400001)(38100700002)(64756008)(508600001)(66446008)(66476007)(76116006)(316002)(6486002)(6512007)(86362001)(2616005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NmNWSmZ5U3B6ZllsVHFkc1gyc3MxOU9GWVRGS1RKSm9Xa3VldHVvdjMxclRt?=
 =?utf-8?B?dWxvT3pDQ3AwamhjY3FLK1RjS1AxUEYyNXgxZkJMQjAyM2J3akN5a1hsVVI4?=
 =?utf-8?B?eG5yaDhwdHZKZGdGOSsxZE5NL1pTUkdnTHZ3UmFwaXdnSE9ITjFKb29Hek1X?=
 =?utf-8?B?WFFmK1lYSEVnTkpleVJGQ3J0bVAvTjk3VXJpNHBzVklQZm9ObTJ1N1RaQ1pH?=
 =?utf-8?B?aFZXMit0QzFwV1NsUWp1bnMycU53MmhlQWRwVG90M1J1TWtwWWlqbVJxdzNj?=
 =?utf-8?B?OTYyV3l4VStteGIxK1lWODFJc1dhek94RE5LdTZwZXdVQWFkV1BjY1V4aGVF?=
 =?utf-8?B?QVEzdW1UbWtCMUVRMU9MWW16Z2s4KzM5MjFrMjNra1FRSm4wTkF3bGJSMHl1?=
 =?utf-8?B?aGJVbW83NWd0bEpLSXNlVjN2L2VYYlNJNDljKy9rN2Q4V3dVcmdEaXlZem5H?=
 =?utf-8?B?eFVRcWJDMXBMSno4TGQ4R3BFOGN1RVdPdUxIWG1UTlY1enlGR3YzSDYySkJo?=
 =?utf-8?B?dUhYVk5sRTdDUWdPRG91TzJ2YlFCVU9VdDlZMUJZQUpYUU5UM281N1p2L3Zq?=
 =?utf-8?B?NEs1YW83M2NRcnVyMzN1QUhnbUlCRkV6eCt4VFIrVDRIamgwUVoxM29CbGQy?=
 =?utf-8?B?UXZsUFJKaWVZU0MxNG1KbkVmWDNIOUw2SHJoRHNVcjkrNWxuRC8yZ2JpSzNy?=
 =?utf-8?B?T2hqbkxNQmtQV0FGZERUWFEwbGE0NFVWaGs2YWJDYlloYkxYSmlyTDZMZDZx?=
 =?utf-8?B?a2N0ZXpBVWVhaHpjWW56VXlMOEpvU01CVFBlSFVndXRKOTJKTDhzNXRKNW53?=
 =?utf-8?B?UG5PUWwxaGIrOXZOQjJ3TkFXMytSM0c2R0VnbnRWbjY2VmJLWGk5ZGRnREVa?=
 =?utf-8?B?Nk1LRlduRXUxWnBNbEo2d2lIZzA5bm1UTFBCMkhwK0IrUm4vRUpPSVBVRHB1?=
 =?utf-8?B?emphNzJGMS9wSk1CWkV2Q0YyRlZrQWJ1V2pubVk2UDIwMjE5YUVseTZhNXQ2?=
 =?utf-8?B?QklQdkZmMC8wcm5yNFJuczlObUJOQnFmUEhydTlFL3lHUWFzdUprbi90OWRr?=
 =?utf-8?B?OWZzVktVVFlJVHNYYU40a250dHZqUFVYMGRMVVdDT0I2aUs2ak05WlVIKzM2?=
 =?utf-8?B?OHVTNVlmaUtma2RJSDNsNTJPcStIMFY1VTd2Wk13WHhHb0IyUWJnKy91czVj?=
 =?utf-8?B?YUpEVHlUTGNkQ252VTVkZVVCRTBmckRPSmY3RmVuYkxUZEZRSUQ5cFh3RHlH?=
 =?utf-8?B?NDBad3ZkRHFYcDVCU0xqVFhQTVpDaWdKQXU0dWdmLzM1SnVTSzVTOFRDMU1B?=
 =?utf-8?B?c29tTjdBYzBRQWlVVGFaMHFkdjZxRGZ6ck9OM1JxcXFIOWxkNmNYVVFCTmVP?=
 =?utf-8?B?d3pOWTVkMUlxTUtIYjZXRVYvN3UxNlhQbC90TDBYbXF2M2pUcU9xMnBxd3Nt?=
 =?utf-8?B?VjFMN0JPWWJCcmNvMVFDeVloeXJFSG44cE5PNlVBRmpuZEVDeGJmWCtxeUFH?=
 =?utf-8?B?N0JFTTc4RHlJZXZuRWxOdHgzQ0ZBODJ4eUNJaElvUm5zVjB6WmdLKzlHczE1?=
 =?utf-8?B?cGQ5ZEVabzdwclJQVWRvWTRvWjA2QkUwUnZCRWtOcHVRdWNLRS9UZytjK1ZU?=
 =?utf-8?B?YmxmVzRYekVHQ0FsSEprMFpLeWZPR0tpVzEwejhBcDJleXZJelJYcStBRlR5?=
 =?utf-8?B?T29pV1ZTTVdXVzVpNXFTTmt4KzlqZWxFMnJQSGlpRldxUk1pOE9kdW03SWYx?=
 =?utf-8?B?L0xBeHpJN3ViRHhNcm5sMnVqWHFjT0xHKzBsQS9vWEM0b3R1VysyeG0wSWNw?=
 =?utf-8?B?b1FzUkg1UkpPeDdFN2ptUkhGWFVxRG5Sbngya3daYmN5T0Q5MzUvWGVzbHAz?=
 =?utf-8?B?UzJjNUlKOHdPclFyQU1XRUlqeTdaVmt5d3JOSTJiTGxGNGhNU3lpU1J2MmV5?=
 =?utf-8?B?ckVOWFZIVDJYMlZsTnFHMElMdnRQb2xzWVUrSlJvc0ovc29LZktOWkc1NGFS?=
 =?utf-8?B?emNEUTE0dWFqVXpVWmJEV3p4VjA3blFkNUJEb3J1OWN0cExSRVJNTTVRL2U1?=
 =?utf-8?B?aGdtZWhOVnRFOTd2dkZwSStKVDk2UjJON2xjQmhmRjh3UENRVEN4K0tWSDRs?=
 =?utf-8?B?eWVnRHN2OGh0MnBxWDMxTmpWYUEvQys1MHBKM3JocWd2L2NXT0FVYm81ZWln?=
 =?utf-8?B?NkREdEFJVHdFSUNnMEhCNEhUTCtKait0RUxib0hSRjdsNDd3MzIrQkdKWEw0?=
 =?utf-8?B?algvMEVEWGtiaWhpSGh4L3ZsRUcvMzRZZWhOSUlFRGJTNm9uRjBoT2Q2eWVI?=
 =?utf-8?B?OEFEVTBramZlSHBmbm9VeWhIUlQyMWFFbE81enJBU09wd1J0dTB0Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <42090F27A9E80349BA14C8BF36CC75CB@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ffd2b735-8d3d-4ea1-f3cb-08da1952910d
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 11:26:03.2657
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kTemNmPlPOsaO6KgdeSy3mYnEKHy0C61nCnm0kMb3+8HYwN0etf4U65bYn/ryl+xV9icC3bXItFCCi6Z7F1N032bRsBb8V63yXFIwzdey5Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3449
X-OriginatorOrg: citrix.com

T24gMDgvMDQvMjAyMiAxMjowOCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSwNCj4NCj4gT24g
MDgvMDQvMjAyMiAxMjowMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4gSSBjb3VsZCBh
ZGQgYSBzdWl0YWJsZSBkb20wX21heF92Y3B1cyBwYXJhbWV0ZXIgdG8gb3NzdGVzdC7CoCBYZW5T
ZXJ2ZXINCj4+Pj4gdXNlcyAxNiBmb3IgZXhhbXBsZS4NCj4+Pg0KPj4+IEknbSBhZnJhaWQgYSBm
aXhlZCBudW1iZXIgd29uJ3QgZG8sIHRoZSBtb3JlIHRoYXQgaWlyYyB0aGVyZSBhcmUNCj4+PiBz
eXN0ZW1zIHdpdGgganVzdCBhIGZldyBjb3JlcyBpbiB0aGUgcG9vbCAoYW5kIHlvdSBkb24ndCB3
YW50IHRvDQo+Pj4gb3Zlci1jb21taXQgYnkgZGVmYXVsdCkuDQo+Pg0KPj4gQnV0IHRoaXMgd29u
J3Qgb3ZlciBjb21taXQsIGl0IHdvdWxkIGp1c3QgYXNzaWduIGRvbTAgMTYgdkNQVXMgYXQNCj4+
IG1vc3QsIGlmIHRoZSBzeXN0ZW0gaGFzIGxlc3MgdGhhbiAxNiB2Q1BVcyB0aGF0J3Mgd2hhdCB3
b3VsZCBiZQ0KPj4gYXNzaWduZWQgdG8gZG9tMC4NCj4NCj4gQUZBSUNULCB0aGlzIGlzIG5vdCB0
aGUgY2FzZSBvbiBBcm0uIElmIHlvdSBhc2sgMTYgdkNQVXMsIHRoZW4geW91DQo+IHdpbGwgZ2V0
IHRoYXQgbnVtYmVyIGV2ZW4gaWYgdGhlcmUgYXJlIDggcENQVXMuDQo+DQo+IEluIGZhY3QsIHRo
ZSBkb2N1bWVudGF0aW9uIG9mIGRvbTBfbWF4X3ZjcHVzIHN1Z2dlc3RzIHRoYXQgdGhlIG51bWJl
cnMNCj4gb2YgdkNQVXMgY2FuIGJlIG1vcmUgdGhhbiB0aGUgbnVtYmVyIG9mIHBDUFVzLg0KDQpY
ZW5TZXJ2ZXIgdXNlcyBkb20wX21heF92Y3B1cz0xLTE2IHNvIHdlIGRvbnQgb3ZlcnN1YnNjcmli
ZSAoZXZlbiBpZg0KQ1BVcyBnZXQgdHVybmVkIG9mZiBpbiBmaXJtd2FyZSksIGJ1dCB0b3Agb3V0
IGF0IDE2Lg0KDQpJdCBpcyBwb3NzaWJsZSB0byB1c2UgdGhpcyBvcHRpb24gdG8gY3JlYXRlIG1v
cmUgdmNwdXMsIGJ1dCB3aGV0aGVyIGRvbTANCmRlY2lkZXMgdG8gZG8gYW55dGhpbmcgd2l0aCB0
aGVtIGlzIHVwIHRvIGRvbTAuwqAgTGludXggd29uJ3QgZ28gYW55DQpmdXJ0aGVyIHRoYW4gaXQg
Y2FuIHNlZSBDUFVzIGxpc3RlZCBpbiB0aGUgQUNQSSB0YWJsZXMgKGFuZCB5ZXMsIHRoaXMgaXMN
CmEgaG9zdC9ndWVzdCBsYXlpbmcgdmlvbGF0aW9uIGZvciBQViBkb20wIHdoZXJlIGRvbTAgc2Vl
cyB0aGUgc3lzdGVtDQpBQ1BJIHRhYmxlcy4pDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:37:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:37:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301440.514441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmvu-0008Tn-0c; Fri, 08 Apr 2022 11:37:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301440.514441; Fri, 08 Apr 2022 11:37:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncmvt-0008Tg-Tu; Fri, 08 Apr 2022 11:37:41 +0000
Received: by outflank-mailman (input) for mailman id 301440;
 Fri, 08 Apr 2022 11:37:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2zQ4=US=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ncmvs-0008Ta-DO
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:37:40 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03on0607.outbound.protection.outlook.com
 [2a01:111:f400:fe08::607])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4af5b07c-b730-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 13:37:38 +0200 (CEST)
Received: from AM6PR0502CA0059.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::36) by AM0PR08MB4498.eurprd08.prod.outlook.com
 (2603:10a6:208:13c::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Fri, 8 Apr
 2022 11:37:28 +0000
Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::12) by AM6PR0502CA0059.outlook.office365.com
 (2603:10a6:20b:56::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25 via Frontend
 Transport; Fri, 8 Apr 2022 11:37:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Fri, 8 Apr 2022 11:37:27 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Fri, 08 Apr 2022 11:37:26 +0000
Received: from 26f709ce624a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6956AB34-AE89-4F68-86E4-B4953F5B6912.1; 
 Fri, 08 Apr 2022 11:37:17 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 26f709ce624a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Apr 2022 11:37:17 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AS8PR08MB6022.eurprd08.prod.outlook.com (2603:10a6:20b:295::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Fri, 8 Apr
 2022 11:37:14 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.025; Fri, 8 Apr 2022
 11:37:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4af5b07c-b730-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zrjB8naPO4x5SjcD2RVl8FjfX+vJZzCnoJ6YTmMHkjk=;
 b=RhxRzCoHfCujjrMPZ7dBSdghwbKNk0o6f+voaw43LMcwFG7IMEn2xWwovsrVE1JywF8tk2ibnysenee1EMPqpiec7PWFLERrNrkS/tQVlgo6OPGicEZhElQKGhkZBB1rUDJdRm7M4VXE4oIwwljVKbeZSbIS+xX0RMuJUk4ye/Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 956d90d0bbea9ed6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MPOdEu7/e/b5bsMDeMiR0wGsAb8/7mx5fEp+4z34ZcJIKwSbdJuEoejfdrmU6iSYdKHHSecpJIqas1HVYovuGIcMsnX3NKI9Qzrhj+7vVxFKdWoROg4644idQx3pRRbLK+sE4R8Wd75hpb0NUhp8xYSEgK3sSJT4YJZ67dTX5OpyNDztZXIhkWo5p2GWkNSoBIFPNkacF5q01zPuIrUKVomJbHv0qqHcvBL+0d9CsZDcO0mh/QKykAo9xXHzCrPvonnF3AB35O9nvP3kPmFWGwYEnPf3vmptNaSDFLNhj03bKf38LRycq+BQIokNnpUKvBOg8PKMuHDQZrlZrXkuyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zrjB8naPO4x5SjcD2RVl8FjfX+vJZzCnoJ6YTmMHkjk=;
 b=GxMCQByEfaLUlX5dAcrCEiwCPSQI/PeClTruYLXbmeyGeEn/rje1cMhrENqD4+kiyiPy5rj/uSM+n8VKZiH0l7k/M+endRgEP2qzbIoDSoEzihd8dJG4gGxzrVVr4UJNFWCFelE3NbGGS+CsGYMAkvBrgswkdTYShJ8vBPZxPandMXKxKogdzQU6ibN9IYbfh18q1xFOLkS0njsWP7w5Gh7rWq/TB3JE3v9dhYHp+0HkRfQt9GBAcQVPY1tm9shJa9vL5u05n6gw/fainisPJ1Owd3DvlboBilpGGa2Z5WlhEFsWCZMbHHVcLkK19yKVMVqjoP+jmQCqPrjYG8oHJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zrjB8naPO4x5SjcD2RVl8FjfX+vJZzCnoJ6YTmMHkjk=;
 b=RhxRzCoHfCujjrMPZ7dBSdghwbKNk0o6f+voaw43LMcwFG7IMEn2xWwovsrVE1JywF8tk2ibnysenee1EMPqpiec7PWFLERrNrkS/tQVlgo6OPGicEZhElQKGhkZBB1rUDJdRm7M4VXE4oIwwljVKbeZSbIS+xX0RMuJUk4ye/Y=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Wei
 Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, Dario Faggioli
	<dfaggioli@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Index: AQHYSyUg2T6WkJDiXECW3myZV3L//qzluEIAgAArbIA=
Date: Fri, 8 Apr 2022 11:37:13 +0000
Message-ID: <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
In-Reply-To: <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: a7f404d2-e735-4b97-682b-08da19542871
x-ms-traffictypediagnostic:
	AS8PR08MB6022:EE_|VE1EUR03FT008:EE_|AM0PR08MB4498:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB44981261F735E87B3EC09155E4E99@AM0PR08MB4498.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 D54Dna3aOqXECl4TA6KpKkRLupm3gVn+tVIlNgen27kjoTZ0RVgZvHe3Kd6wmfBF8hX/tr01zIky+60eHUthgLeYoE5OzbfF25PXKkATcuQTjXqlxSYdsvp0h/VAPszrEHWxVi8nLAF7ODXnc6io8QxWKKu/SJ+qCPJDc6HszTxtDZI6lJS4RKysIRJqlk597zJiq8+Z60z3OLw9VG3ZQY4/FIJpDN5ze59BlYpkXLu2hVrm8Khpxycj/TPJD8H+L7gy5UbTOqp44SOJ1PsO1u3mf6gpEYRBS9YLfQSniMcbz8j5kNFpKwqOpVNhRIwst33MESTV2zohB5X8k/OUri04hf/7qANVX5LhWyrNRvHZsnMc20bj9dz1B8IuQTS/s9Qs33KdF63JWsWHSpQSbR/Jq6rirgdEAp8lNFu6KfOA3Sf3icc5TjxsimsC34PMBUu4qOdmUe6U5JbnjezrfoNhObV36PLI27JvmOSD8+bLc+j2O9gHx3ogjnCWhYn7Lb4Fha3MG+lcKczSIRAJ04HYqQyXePu4feWS9vv2Q4otAjw5tWc9V50Nq5SqRy1bQFxoalKgspSn7ZK92wavcFx47tS9jk3J5rczqfYiZek/aHmHgYppmVEafjkLOYq6/RtVK5IpfQGOl8asppym7jNsqYVF801nQGDfHPaey35dQAecJbnNoxrEEQLOX7iIf14dCu2JlKFUCARk/uNhwhkLOGvFwSvZUvQakE92n0PzJTgRgSe7mWwLFwKMtbaE
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(316002)(7416002)(66946007)(76116006)(83380400001)(36756003)(66446008)(33656002)(38070700005)(6916009)(8676002)(5660300002)(54906003)(71200400001)(2906002)(508600001)(86362001)(6486002)(4326008)(64756008)(8936002)(66556008)(66476007)(26005)(122000001)(2616005)(6512007)(53546011)(186003)(38100700002)(6506007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C1083D84872D2948B465EF37A6148842@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6022
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7f978769-1875-4b26-c7b3-08da19542084
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kdxUaW2Ikb0H3ZSdvOAqaSafh11bMpAo3oMeIr+rVwVbrFYMoI0vny/RjFmFnGqNT9CGqQPMfsnFuXdXEueryVumqL6NtooANc8uN/vuM+iiTW0WN89fnzhel+NTTzZjv2ZcKq9vccVCAln8UZfomxey9fQFXTCTEejYkWE1UcnTRTmpnEg3T4GvfW6qgP+DUshSY2Hn9OgX2N+ucdfcLHV40P4rw8PWqrnC06pT1JS1w/n9FptfcvcoLoY1N6L0ZLiyRWou5we5fYnbUuQ7xNqqY/cy0vHHFajSyRK3BbitjGvCkSN+qp9Iyvd7maYq/6XfkL22jwLahbbwQjPf4gGN4qzlkaNDvu0Ita7TbFsrPoBetYea7R7BplQr3o/Z/jx22LMhcpvpNcl+n6JMnDPG/K4Bp93GIFyrDlR632P1YRsoMLseSFtsEZ7galnT/bflhqMsvMjHi1i5FhYAYYc5T8gHEbIGgWvX0B/ce8cz+yuNwefXY/DlAQmOWG8HWi7rIywaH4qbyIAgiiyMxCiFlDkrXuskT2b90CfCdpsZr/CLrTjYUKquLeyXiCfAxOX/+sMYtFvY9sZYU+FUhgOJRy2lvllIpr6KwXRofk7vW/bcxzNOzH5PlDhznM1fgL/77qJTtrmiLQiokdhE7ZL27nLHt67OHYhLKpwxogUFEs5QwAdAbSBtR6HOfa6l
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(40460700003)(70586007)(33656002)(8676002)(336012)(2906002)(83380400001)(8936002)(6486002)(54906003)(82310400005)(36860700001)(6506007)(2616005)(53546011)(508600001)(356005)(70206006)(26005)(186003)(6862004)(5660300002)(4326008)(47076005)(36756003)(81166007)(316002)(86362001)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:37:27.1720
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a7f404d2-e735-4b97-682b-08da19542871
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4498



> On 8 Apr 2022, at 10:01, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 08.04.2022 10:45, Luca Fancellu wrote:
>> ---
>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>> xen/arch/arm/include/asm/smp.h         |   3 +
>> xen/common/Kconfig                     |   7 +
>> xen/common/Makefile                    |   1 +
>> xen/common/boot_cpupools.c             | 207 +++++++++++++++++++++++++
>> xen/common/sched/cpupool.c             |  12 +-
>> xen/include/xen/sched.h                |  14 ++
>> 7 files changed, 383 insertions(+), 1 deletion(-)
>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>> create mode 100644 xen/common/boot_cpupools.c
>=20
> Under whose maintainership is the new file to fall? Without an
> addition to ./MAINTAINERS and without the file being placed in
> xen/common/sched/, it'll be REST maintainers, which I think would
> better be avoided. Would it perhaps make sense to have this as
> xen/common/sched/boot.c, allowing other boot-only code to
> potentially be moved there over time? This would then also avoid
> me asking about the underscore in the file name: Underscores are
> a somewhat artificial thing for use in places where dashes can't
> be used. Yet in the file system dashes are fine, and dashes are
> (slightly) easier to type.
>=20

Ok I can put the new file under xen/common/sched/ as boot.c, should this ne=
w
file be under this section?

CPU POOLS
M:  Juergen Gross <jgross@suse.com>
M:  Dario Faggioli <dfaggioli@suse.com>
S:  Supported
F:  xen/common/sched/cpupool.c
+ F:  xen/common/sched/boot.c


> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:53:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:53:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301447.514451 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnAj-0002tq-F1; Fri, 08 Apr 2022 11:53:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301447.514451; Fri, 08 Apr 2022 11:53:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnAj-0002tj-Bv; Fri, 08 Apr 2022 11:53:01 +0000
Received: by outflank-mailman (input) for mailman id 301447;
 Fri, 08 Apr 2022 11:53:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncnAi-0002tZ-59; Fri, 08 Apr 2022 11:53:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncnAi-0001Ar-2Y; Fri, 08 Apr 2022 11:53:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncnAh-0000XF-Lv; Fri, 08 Apr 2022 11:52:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncnAh-0008PZ-LV; Fri, 08 Apr 2022 11:52:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yoCnyT53TmLTjisY5a3zpOYpES22dt4uH6cdlu+vk90=; b=DrByODt+oonoWbfPWZAYOMA1ZR
	8/S1VYbi90fes3gr2gToV1DNiTA7zHrFyCmecwJ6mIej2zyF/FAFD9YdHjbGstrfYF4gb0DpBtf1i
	tnZEwCGji0DAvBo66u4NWiQNOgSWlV2rQ32clMVPANsngQ/hGz3q1Avxx60wAebP2lSE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169234-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169234: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 11:52:59 +0000

flight 169234 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169234/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   39 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  291 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:56:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:56:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301456.514463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnEM-0003XU-0M; Fri, 08 Apr 2022 11:56:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301456.514463; Fri, 08 Apr 2022 11:56:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnEL-0003XN-T5; Fri, 08 Apr 2022 11:56:45 +0000
Received: by outflank-mailman (input) for mailman id 301456;
 Fri, 08 Apr 2022 11:56:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncnEL-0003XH-5L
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:56:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f59b752f-b732-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 13:56:44 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-Z4ysZYpxPD6JRx_743zglw-1; Fri, 08 Apr 2022 13:56:39 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by HE1PR04MB3018.eurprd04.prod.outlook.com (2603:10a6:7:1f::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.21; Fri, 8 Apr
 2022 11:56:37 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 11:56:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f59b752f-b732-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649419003;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=N61m5+XXIocqQACsDxX3OV9XDtV7Ib8JAZJR8n29Ftk=;
	b=b1vqCX4T8OBG+ojdiHNTrH4JfUmLlWVNKJciVNZZIbOvpJ/dCEonb1i2mxFqhTKAEEHfo4
	I5pweOaMA+xVQ6LafWhkXmSE3/heqsniKM8KNixdJysPzoImC1tjdeUZdLoa4cPz3VFgYP
	ay0O3bkRCbIV7fLMQUJiWCq1KrH9HgE=
X-MC-Unique: Z4ysZYpxPD6JRx_743zglw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h56x1sWUgeyS/K+D0y4ZzGB/eR0V8iHS8sWEUKQaf3B4wGKH63Ni3BXuBHab7PJfEhovW0pGNPvepxZlKtB0x1GRF1SD37ZfFAJuMmVNHDVu++D96d4jOAmJQCWVS1tdlDyuJxONq+0lx2wxnsdkLKnKcZw+gZ3ybF3wVNB3bQSz50WRH6VnJYfkCMY0jhhf5GZIe7CJzct31OPltg15eXV6VQ3YXmm/mZZZRWJ28ccXvmRkde3EtDBM3Fvuwh5x6dI2rlIRlgOdpS2IiTFI+PoggYqZOGBng4E7f21S5TtI7Z8vqVGXy0IKn37LgkG6rR8XQdt0tIdsea+e8Ihvsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cBgQXbzxEM28/OTZDOhd8GH2S0kUGAVhy9BrHrE0V6M=;
 b=Ab5fi8WzQqRtoxVJBsnTe1Q3NHguNIb22V/zH7fP+jatd7+lBgr4be0F1kYiX5W5mH+rWZwdOJMzOiCPTgxQRS2Gb0dXywlqOGxErO4B3XYYkcQNJx1bwCE2oFs3gBkl+7DMfOPIYaSssXUnCwegozSjR0ZaejEbGdwSe3c65cUQ/WKrGEOtpn16s5Vi98KAuwaWaSZLzseZQgTJ6Y8KECIWCbL0aoCpmmmRVAksHKqI4v/1regrtW1XabGZldY6udBemCHIlIQqQy+WtDkS3JVeCPsZioW0iKvgRygaDHSJ7nj6SS9xh2c4sbOxc26PM/IqxHUdtJpKpNd/0VjyCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cbd9fcdf-645a-58ae-dd11-1f5c91e283c4@suse.com>
Date: Fri, 8 Apr 2022 13:56:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 osstest service owner <osstest-admin@xenproject.org>,
 George Dunlap <George.Dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
 <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
 <22912e60-9cd8-2c68-ebb2-37392bce9436@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <22912e60-9cd8-2c68-ebb2-37392bce9436@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::6) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e6ad3210-1927-4932-b717-08da1956d5e7
X-MS-TrafficTypeDiagnostic: HE1PR04MB3018:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<HE1PR04MB301865897C86EB852EC3BD25B3E99@HE1PR04MB3018.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BJlKdoLXpuXik+SytuxC60+lTCD6pdYO3DQadSWCr6ftt4U/HzueILtf2ki46UadqtVsum2Ic1av8qIV6U7w5/i0HKALgk7sIPvKExcCOm2iKRyAiPAwqPAbh62xFC+Wl2aFlwQfe/MwNoXZgLl1saPWXWHiCvB73WXgAn+A5z6E4VsZ4GQkF64jdPXuStJKh/oSe+Mdg5BRp4OUqK8/mMAMaU7n0AAyy49CIMvqwLRQnvdw3mzTKdG+5GFsEExnHsdYS0VN8KpzeDm0fi4f29/O2Z5hRB2aiTyrXzKrN6OOD4BCrptgBUbbpxGO+4VvDyYWiPCcfo8hHYkOBFzEv12a1M8DmVZU2iXxnXL5CoI/H9gzUTynjWZrXTxELdgIoV4LNPGTi+BXnBbx1X6JTy4FxnWSD4AeZU8cgiWevZ05xLAGhVSJpyIqM7PFF16Jj59OAjf0m0Dfd5iZp7LtV2T0ZomNoigWQkHIamHOYAuKkCUZ14KcdyPUA6NyxMfY0aaEmKivubnqzPBAuCqbWzQ0xi8OHpWcL42qN6V4P5JwaB0LMYr40jfn8SWtDw/hVlhjdtP3D+2Wwofc5L0IPjT6drdMcjvEphijmfeDMsfMH0OJvCoxyvqGSxnIjsVpij34TvI8m9oINWmpRM6kvVEnIQb5Xg1W7BNUhmi+PK6Xr+fE0MzOO6WEDdIxsMISEvW5ksfUptVl566PPR7xIV46Q+4r7SCCw/hyf0/sZZQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(2906002)(66556008)(316002)(66476007)(508600001)(86362001)(8676002)(66946007)(4326008)(2616005)(6512007)(31686004)(38100700002)(6486002)(5660300002)(186003)(26005)(6506007)(36756003)(53546011)(54906003)(110136005)(107886003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?wtdUrbM8HM0s19e33CCMLOLW+t35K2pbFeOBOyLa/fk0MAtEY6thq/W44aU3?=
 =?us-ascii?Q?WW4yhMSUsEeDMVVJDaq6m5hTLMtdXZRhdgLVkcFhWPzWP38y8p4cwjZg6DP7?=
 =?us-ascii?Q?JmR9Forc/63T8lhTP7tiWBNJCGM3icqHrd3q06dbzpp21/wX7az5LLVkhATC?=
 =?us-ascii?Q?Rvc1CysyaYFCPc6/h7ihE9auvnMaXptAQj399Y9hXAQteK4zSiz4OzLDpbSN?=
 =?us-ascii?Q?lfS5G/sJxSDCgwsgUxMl0pgSsmVY9dY54dBEUrgG17K41MGCYaQkgRXxf2g3?=
 =?us-ascii?Q?hYCBf9fLy+osPBi/lbFBdoobEb33tSVDY393E2zdQUmWplACzAQfmdoksmux?=
 =?us-ascii?Q?5guS2z/uIxSrl3zgtO5ILFJujFfvlF1icsERKAg7DV02CgJTtNq6+hzB67Yi?=
 =?us-ascii?Q?PmIGje1xtNVRLrsB9SoW5x3xJwMwvjpYEkZR9kbxmZGkWV2/9hKt6emjPFyO?=
 =?us-ascii?Q?t1QSdaKoEAn6/RxKhDE2a9YU6hKTSFs5Fl2iFPArPQMs/MP4Tp1bTi8lfYlg?=
 =?us-ascii?Q?4pJLWjZaTZw7CV+7JE0Uv9XBxrasyPLEMx36isPa48MoWxvSHb4a6LJLlIql?=
 =?us-ascii?Q?iogum8ahnmJ7ps8IUWxT9Yu23s1wDs96Rj9PMSbVOaI9/XZKilsGmIn2KMF8?=
 =?us-ascii?Q?EP7Pd/K9VkQ+P/t91TMLhZxVZppMgG6APhOBMwyx6wlKUhAmo0clDqOSaAkm?=
 =?us-ascii?Q?1HB2azU+6KV+p1nULgYMVsaZTPusoq5TLgeOv0cj6RKSjgSjjneyJpHJOO3p?=
 =?us-ascii?Q?GPEuWU25icTPkTKyRZUlVG8CkGXqgc9oM0LmsdaGGye1vTsNYx3muMsYVNob?=
 =?us-ascii?Q?belHINsRmdJizqYPlys9cl1SnQyuhIa4mLEdXEXJveFX/STMUaJxmaPk8Xr3?=
 =?us-ascii?Q?oN6J+GTZSEvk0TzrvXgKNNIqO5fUewzC/YyXxuLGkrGfJfV3qniGSjHVYgmD?=
 =?us-ascii?Q?Y64GzNHY7g0P5eHC/idqBIef7rZ5TRKkCerh2Slo5bmHCYMcCXMYNdNNgbtE?=
 =?us-ascii?Q?JiE4XjTPNzZdmiDHPOJio27PoxaYG8+86Kcder8+UpKEQj3Aq/NbqzwLuevu?=
 =?us-ascii?Q?/qUrEfHCD/9DpSXIJCs4J/bUNPkA/v58PSPx75AaP04jHIJeqBjMb7uI8qnd?=
 =?us-ascii?Q?byHu96JrcE5KZh2+Hjb7rwbo59JpudGLxwk+TDfcR04rfmEzsDxLG+2VVwVx?=
 =?us-ascii?Q?TvQCD0sAoKfgCitDx95oKDHaeyqkHX6PpVhYY6HGE5eJtLuUbAm2HwgHK9eE?=
 =?us-ascii?Q?g/SDH5tsFRHKAbjDNll6Z/LUTVisHdFl0fPfyCFdQpGDHWspW8TKPuI8RAY4?=
 =?us-ascii?Q?PldN1Kw/v9RG4j5/TZHGVpbNclqXaTamMlgf4HqHi3c10xCj0t7anfWngiGo?=
 =?us-ascii?Q?aZ9vnRWFCez2Ir6t3PXQZ+qZD2VPAD6YAB11zo0y5OZGULm7lwhZ5hqWpAe2?=
 =?us-ascii?Q?i0VNHvL8wjVS/wnsyu54VWkcWust1+a6/BW9FKhu5tx8csE9HFxSOCrO+1i+?=
 =?us-ascii?Q?FR+3OLioQX9li3GO5/MjFt6UFOwUXTOx937LNu1s8sM318yRgiZglc2M/pse?=
 =?us-ascii?Q?seNuI91lJmSdeig67HSL18KYDjPafMiSrpjNYqPUZtlRBx2n1dnI33vY0LwY?=
 =?us-ascii?Q?RpI/ZFDe3bc8BAgfTSava7V6PGi25CH1+F5bRJDfTQB3zIHL4+Vt1x/sOp4Y?=
 =?us-ascii?Q?k7C8OdNUQS/B6qTwWcoqM3XeaGj9Ug4flPl9BIXGUTQeYe3Lw9lJzqzQEMIC?=
 =?us-ascii?Q?U3qTEaBGvw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6ad3210-1927-4932-b717-08da1956d5e7
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:56:37.4367
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OBnUQIBs9/Y8XaCEJX06Umdz6Y/Kn7cd8HVW2q55cNcAOwOY/oQVHAKLWHx+pzplgewimB7C4lCQzNgDQFs99A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3018

On 08.04.2022 13:26, Andrew Cooper wrote:
> On 08/04/2022 12:08, Julien Grall wrote:
>> Hi,
>>
>> On 08/04/2022 12:01, Roger Pau Monn=C3=A9 wrote:
>>>>> I could add a suitable dom0_max_vcpus parameter to osstest.=C2=A0 Xen=
Server
>>>>> uses 16 for example.
>>>>
>>>> I'm afraid a fixed number won't do, the more that iirc there are
>>>> systems with just a few cores in the pool (and you don't want to
>>>> over-commit by default).
>>>
>>> But this won't over commit, it would just assign dom0 16 vCPUs at
>>> most, if the system has less than 16 vCPUs that's what would be
>>> assigned to dom0.
>>
>> AFAICT, this is not the case on Arm. If you ask 16 vCPUs, then you
>> will get that number even if there are 8 pCPUs.

Same on x86, afaict.

>> In fact, the documentation of dom0_max_vcpus suggests that the numbers
>> of vCPUs can be more than the number of pCPUs.
>=20
> XenServer uses dom0_max_vcpus=3D1-16 so we dont oversubscribe (even if
> CPUs get turned off in firmware), but top out at 16.
>=20
> It is possible to use this option to create more vcpus, but whether dom0
> decides to do anything with them is up to dom0.=C2=A0 Linux won't go any
> further than it can see CPUs listed in the ACPI tables (and yes, this is
> a host/guest laying violation for PV dom0 where dom0 sees the system
> ACPI tables.)

That has changed not so long ago, Linux will now use all vCPU-s
supplied by Xen. Since I was able to over-size Dom0 with XenoLinux,
I wanted to have the ability also with the upstream version.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 11:59:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 11:59:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301461.514474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnGZ-0004JJ-C0; Fri, 08 Apr 2022 11:59:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301461.514474; Fri, 08 Apr 2022 11:59:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnGZ-0004JC-8y; Fri, 08 Apr 2022 11:59:03 +0000
Received: by outflank-mailman (input) for mailman id 301461;
 Fri, 08 Apr 2022 11:59:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncnGY-0004J4-Cd
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 11:59:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 47731534-b733-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 13:59:01 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-2iZ1LtUiOvGJrsYPBrCVdg-1; Fri, 08 Apr 2022 13:58:58 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AM0PR04MB6179.eurprd04.prod.outlook.com (2603:10a6:208:13a::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 11:58:57 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 11:58:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47731534-b733-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649419141;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=K069cJ/0fzb1j3nlccwM8sH1TZx0KZliOM5PfUVmheY=;
	b=FMyfFv/++m2LfA3wradxRlZAWZyBDu6BC7QUwgRXlsDyPKGakrarcDOSsmm8eGZgs+K1VD
	xD7F2U2sZ2Q0pircLoiAiyBmyFwBYo6TKeLv6EZl1qklEEcUD6o2gxQ1icad7wgv5vIb2T
	oCV+JmkRyq0wz0bEnpPkOSun75VXeKI=
X-MC-Unique: 2iZ1LtUiOvGJrsYPBrCVdg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WZHYPR27/DlfsMxIZq9eHnTZvzeRcCbBApMPneaXO11JUldFX33sGokcrCtlJR6lfnhoX1xebYRfaUrfXc56gaNhpZMzGAuiFwdOBRa5FbbUx7QWLIN7tf2DgTn2Iy43bKyZBTDZdPXbIgTTD58t7tTnk85k9R93JI7atscZ4PoReMz/2Z4UMAov8wo4nhFSSL4kz1CKvL6frfVt3V9DZpco1AZi2w4U2nIZwMZNE6ijoxxYYMCLJVgWWpBZPN3O+NuVFu46NX8Txa99iHqwEc0J1wkH+uIlgBL7zUkFBzDUKhpRVf1kMJavNeqAAOa1pkc6d0zgTgp1+EllFcaWoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K069cJ/0fzb1j3nlccwM8sH1TZx0KZliOM5PfUVmheY=;
 b=NIWbNgPS8vSe35iOll22Aw8WI8MRob5FZsxmjb1Mx1P0wtCfJDsI9oUrSXWzi2PU5DPqQigBxzhJ7PMLkJQwtgbpcxswQk87L/s0YD+vuH6243feQzHF327G9mzynzpOKoSa2fk/8GMGR4nPnLRNuz4s4VytkIjVOJggNs+YK4b5HQU/9u1QXuakoea0QqtCZWQ8FU4ZtqJlvuIC1GZAfqNAva0I5oEER1drj8wFo+YcBSDL6AUHH8zpfenDk30az4zvEC1z9yFCOqlbQnfSf+8fD79BX/r5l3svHPPHkld5k3tzoKqWSeecZVq1jUhTPNr0ZKjaBSpy7vY7yhXy9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <511b60be-c6c6-d13a-b9aa-40e67e5a1b1c@suse.com>
Date: Fri, 8 Apr 2022 13:58:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
 <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0156.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::13) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2b50c709-72f9-4534-8a5e-08da19572962
X-MS-TrafficTypeDiagnostic: AM0PR04MB6179:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB617926C9B69749E950F0F131B3E99@AM0PR04MB6179.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cVsibcRr4Gshgb4KN9pOpRxYBS6L0tG37VUEUpy5ZoZxNm1wNMm0mxhigQmf3gs03/AKnu+dTCuYMxUvaA6PN4kMxBhks8cte+wvOuz1rK3xF+y9uoeI6GsVm/J5WPyDb9LxOnblwSH7iEbdJtc5F8pmiAOpp2PwtzjO6JPDp1N0VN9DQJ/kjFLyc8TZ2qn3pF1hpGQ7OTiHBQcwigpkpHGbOjoGir+fVP/xxAjDWmnZN//5uN/1OC/kvXDVPLsQzlJqzCwVQi5zHdpL38lGpqnIINNwIxe7hW55g6qReaG7kpodXSddeg72jLJNhC1Qqy0dTNCC12OCq10wkAGSy7CZCcsLbibWVYyO9eCI/CP1KQqfRlr27B+5si8ivWmj5KSBW6XUKcV1xbsyDKImpGTaBH6EPnFB0BdbztTYQY9JUd4ZrFiQ3ULSx6GDHkVqefuSUh9JnHMkwrEiima6Q2LY2Jt7Z024al1vAShwTo4KzeVBWVLUuqAMfQoOm4aB9IJq3lt//eupkXGWA56GCU9IQTZy6OcKD9UBfwVDn+2F9wp/KjqRPnblSTBwMclaPWGODSNJKaywV9aPyScUfCEZDR2Efqcx7PqOTCTSVQTdTUF3qbl1tdR5bKdfKil2ujDmwPDWlOOUGfJB/tahzKvNV6y/wZebX7VFh6gwGqZA2yijcDZS5YCmWll8GGk7fOSSzEKSHUt1oTLITEkuD7DJe5Ic8t8peF5h3DHIr0tAVB1A0mWmgJMUzawGKnWA
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(2616005)(316002)(31696002)(36756003)(31686004)(2906002)(6512007)(6506007)(186003)(26005)(83380400001)(54906003)(508600001)(5660300002)(6486002)(8936002)(7416002)(66946007)(4326008)(8676002)(6916009)(66476007)(38100700002)(86362001)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dUwxYmY0U1pxTEc1ejZzRzlkeDVEeGcyMVJCWkxFYU93WVJpOWZQSmQ4MWxI?=
 =?utf-8?B?UjVmWDRvbTJLZDVyY2FIUHhBUGd2Rmh1cFhVYmdiamMxdTNOSitxWUcreFFh?=
 =?utf-8?B?NUllVUNVSW9YcWZHWDROb3ZlUnBEcndzYmJjTjBXQmRETWtQdUJqNXJvaUhS?=
 =?utf-8?B?ZzZLQnBsNG5UNm9OL1M5TTFmc0lBR2JWSzN5cnNZcnNuZmZROGdQYkVmNGVy?=
 =?utf-8?B?dWFSNUVxOCtJSGt0MnZRWXBzSTlVb0xJNjExVWFwOWphcWZpWVpCck15bTB2?=
 =?utf-8?B?MWxBNGFGNXdKakVzbFM2MURtZVV2V2hERzNUUEg4WlUxSUVlOXBnMkQrVWs3?=
 =?utf-8?B?c29MaHdUVEFJaGZrMEZnQzRqVExRWDU1U2VKSVNsc3A1R0lPSFZwZm5DaGhp?=
 =?utf-8?B?bU96eU9nT0l1ZDB5c1g1Mm5wUnFrMVZZNlNMZkphM2RTM2J2V1ZBYm5rSnZk?=
 =?utf-8?B?Y0Fqc3pjSHJUM3VnajFnY1QyMmRKcDFGeU1EaGJlYjVvdjNrNTFSTVJVWmxw?=
 =?utf-8?B?S2puN0prY2ZXU2Q4a2xCL0dMM2VXMmhGZ3J1UUpPeTJ2MjhaWi9pUjdpdDdI?=
 =?utf-8?B?UUYxSzJleDhOdDRhOU5yaVJ3M3BpKzFLK3VaYVlUd2VTalZhOEJoTFJ0K2JQ?=
 =?utf-8?B?RjBkVWVPbnBjL21JcEI0SG9EbjZEZEt2SWErWitVSjB5RGZWeXk2c3NGUTBH?=
 =?utf-8?B?cGJJWHZnc2Zkd1dGUCtjUStZT09UQThGbWROKzh6SlNuenpmYmh3TkZiTHBw?=
 =?utf-8?B?VDVlcEJ2YW41ZWllbFlpR216WjgxNDdUMUR0dldIRmhML0tTeUdUbXhMN0RD?=
 =?utf-8?B?MzNPeXhRc0pOV2dKMUpKQXNQY252amJBZ2h2L0RlT3AvaFM5MDdWL3M4cDU5?=
 =?utf-8?B?aXQ5dG5mamNwallxaXV2RHhFSXdnY2lZeVJnTFdKNS9wcnlCdnFXc2cvZ2kv?=
 =?utf-8?B?bDRpRmNDSy9SYm4wUUlBRnQ4VEtTb0Yvc0ZTSUxpQzM5RE1HT1NoNkpub2lZ?=
 =?utf-8?B?MDVZUTd2WS9iUzJDTzJtZVVuSGdMckJMdDF1elpNNFlaKzZYd0JjZmV5K2Ni?=
 =?utf-8?B?Y241a3BlUUozRS8zMXJIT0toTmk1eTIrWWR3RTVlNjVaK2pQZnE4cC9UU2Vw?=
 =?utf-8?B?Wk56RDExWHM3SWtSME04ZVJ5SWFKcWdIT3FBbVh0RnpCN1RMNFgyUUZBSVZM?=
 =?utf-8?B?TTZrbmFqSW4wM0NSZlpuUDNocjFUN28xRW5CaWFJYmtSUnJWempxYTdWcjRw?=
 =?utf-8?B?NnZIeVFvTUtONFRWRlNsSGx0amR6ZUx6LzEzWDh3UG1yUDJqNllJc2V3QjRS?=
 =?utf-8?B?ZHlkaGpZSEJxRlJRWHNFQ3Bmdm1KMmNCWjg4RmRLNmJmZ0xzWEpUWDZjdTdD?=
 =?utf-8?B?blMvVk0vcjFsRVJPQ2k4TEdLUkp4TXJndGwwV2E3Z3pZNUM0NmFMN2NmS3ZG?=
 =?utf-8?B?WC9DYS9QQ1lkWDdzY2JtcjFYa0ZDVTl1UUxJRFppK0g1WE1KMjdxTXJEd0xs?=
 =?utf-8?B?QkV0b0NpRldqYlZETmxlUHdoanZ3cStjb2g5NGxHNEtJeWsvZXZIRmRFdFN0?=
 =?utf-8?B?YkNHd0s0OXZ3ZU5NWFFKRzdTckw5b0QvY0txM1R5V2liWDV3cDQ2RzdLT0ZM?=
 =?utf-8?B?ZTE2MWFUTHN5SmRvcUhKeVhsTGNEbFRmYWxvTHdycmNBbjNicHU4eGMrSWd5?=
 =?utf-8?B?MjhPanZFdlFRUWJBczBaekN0SHUxNVlrR2VoV1dmcnYwVEtRTTcydk85R0lj?=
 =?utf-8?B?NDlDOVh4R2pXaWwwTGhMV2RrcVJONlIyUXhOZklEaHdscmJhL1p4K2VzRFVW?=
 =?utf-8?B?TFdyL0w5VWZNWGovdEI0R0FHcUNaajNIbk9XWHNOUGtsMk5ML3BGMjBYK0Js?=
 =?utf-8?B?YVZCSWcrVTFzSjlNZ3Z5UjlkejQwZjNqZmNDWnl4RllsSzEzbFN5aFhkK0RI?=
 =?utf-8?B?L0wwd1pZNURuQjdjbkZBQXZSODdOeUV4NE55ZVpraHdnWStnUkRVeTBDYXVt?=
 =?utf-8?B?RzM3Z05NRHRFckJhUFlhQVI2NU9JRUtmT3ZmYkFuOE9BVTVvS2JMdFluSGdp?=
 =?utf-8?B?cWNXRk1vQm1nb1M3SFdhNmJtU2dyV0tPYmNpaHVoVHZjUnZzVjF3cTNZTzFz?=
 =?utf-8?B?YlJkbzZaOUJPbCtkK0JJbVNoK2t2TVZZNGQ4M3hpTUt0MkJYZ1hFbmJiZ05I?=
 =?utf-8?B?STlKRUgwUWhSL3ZnWGVEdVFQWmpIeU8vSUpxMlVRWFY0WnZSd2FqU24xSTNh?=
 =?utf-8?B?SDMvcGxCTW90RWZ3dG5HalBlb0oxb1J1NTN5WjBwSWFEclhIL1ZmNkdNOE5m?=
 =?utf-8?B?ZGRqQnlaZUdPR1R1WHJkMGRyM3RVU1RsUTIyTG92MDZ2dWducXpJZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b50c709-72f9-4534-8a5e-08da19572962
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:58:57.4456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BfaWya9fH5/mByHhOc/zvoSODxfiTuqseAiLLxi3VjVgHP0XbeqYR7tgrkfAMzljXtoV8mJERzes53fGDBsHbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6179

On 08.04.2022 13:37, Luca Fancellu wrote:
> 
> 
>> On 8 Apr 2022, at 10:01, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>> ---
>>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>>> xen/arch/arm/include/asm/smp.h         |   3 +
>>> xen/common/Kconfig                     |   7 +
>>> xen/common/Makefile                    |   1 +
>>> xen/common/boot_cpupools.c             | 207 +++++++++++++++++++++++++
>>> xen/common/sched/cpupool.c             |  12 +-
>>> xen/include/xen/sched.h                |  14 ++
>>> 7 files changed, 383 insertions(+), 1 deletion(-)
>>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>>> create mode 100644 xen/common/boot_cpupools.c
>>
>> Under whose maintainership is the new file to fall? Without an
>> addition to ./MAINTAINERS and without the file being placed in
>> xen/common/sched/, it'll be REST maintainers, which I think would
>> better be avoided. Would it perhaps make sense to have this as
>> xen/common/sched/boot.c, allowing other boot-only code to
>> potentially be moved there over time? This would then also avoid
>> me asking about the underscore in the file name: Underscores are
>> a somewhat artificial thing for use in places where dashes can't
>> be used. Yet in the file system dashes are fine, and dashes are
>> (slightly) easier to type.
>>
> 
> Ok I can put the new file under xen/common/sched/ as boot.c, should this new
> file be under this section?
> 
> CPU POOLS
> M:  Juergen Gross <jgross@suse.com>
> M:  Dario Faggioli <dfaggioli@suse.com>
> S:  Supported
> F:  xen/common/sched/cpupool.c
> + F:  xen/common/sched/boot.c

If it's to hold general scheduler code (which this shorter name would
suggest), it shouldn't need any change to ./MAINTAINERS as the
scheduler section would already cover it then. If it was to remain
CPU-pools-specific, then you'd need to stick to the longer name and
put it in the section you have reproduced above.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:01:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:01:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301467.514485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnIg-0005u9-3I; Fri, 08 Apr 2022 12:01:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301467.514485; Fri, 08 Apr 2022 12:01:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnIf-0005u2-W8; Fri, 08 Apr 2022 12:01:13 +0000
Received: by outflank-mailman (input) for mailman id 301467;
 Fri, 08 Apr 2022 12:01:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncnId-0005tm-Vv
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:01:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9479c721-b733-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 14:01:10 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-H-K1EbqLOeq8MHjaG17_7w-1; Fri, 08 Apr 2022 14:01:09 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Fri, 8 Apr
 2022 12:01:05 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 12:01:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9479c721-b733-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649419270;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nTwYta0hLJaFLLJVCx3cFaXfh8k3WbEKyxvvotHAmyA=;
	b=Xaphu6oxiEyQMFRDpwoYs5smRbSE//lszv8NSsBtKnUgReXlNgcCG2Lxz0uFF0Za2Gjqst
	qnWYKgvXmLGahzfRWSObE2jYFUenKHJ4LtDDy46hfW+T56AOfJC/9l9IjOXZIrA+oRJx+i
	u5q73fuVy00NIwegLDLkKj/oCzGz31Q=
X-MC-Unique: H-K1EbqLOeq8MHjaG17_7w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WWvprlJtsPRdZG/pQYj/mcrkcByTKrt/QA4JoIWutF8IT07tIEGAynfO4nPnPnklStw4VyG/CmRoUvKJQtIW5fwSHWAyXnP42mvWYSJ79V/ve7GhHsx4k5gey+2wR9R9m6+WLVI2Ct6FP+yYqEICxpysQm0SC3AQAXXrs6sPiWBSjZ3dIDlQqIXAIaUnZiKn9MNWdflGxf6huyEesCLiTAduvmpZu7s7cet38UjFdMgf+/M3cy41dEA4rKGU06oYGIyarcGDVyxuPsm7oI6a3bzhNUaNZRwggSoVq4u9scVbhusyZFW0AqzwBW09Bgw9872LIw/im4O6eS/MzD0yHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XN3WTJFEKD82PiIFkvb8ac/2L9v1ssxFrbkCnU3IPpU=;
 b=cfi+KBLhjN8H37feeA5WSNdJ7F5tcpnUlp2ehJDufrEZ/zSQdN/7tsodPG45V3yyfU2cGM6+xQjfJfil5r7NAfoIWbTIFgWZIJheFGoOVjsIdpDCV4UYNHF92fl7T+YQcb+M2xztvVpI9aUcIxTBkNlme3cvohY+x3JvIVQlcuttYm31ExlE5N6xHMukr5xzC3APgy9I2SL85fT0YcJHyvdHSoLAMQEK7Ow51L459e5h1y0LWiCKkRyn5+8Z01Aefi785Pm4sYpZE6qRtKpYjuFn0izlcGlxn46hkduWr9skqhXMrf5oiKkewNJgK6/QO6llhS5cZf3pI7FVaPlsPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <507516be-e0a1-c8a2-64cd-1facfc36d7c1@suse.com>
Date: Fri, 8 Apr 2022 14:01:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org,
 osstest service owner <osstest-admin@xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>, Julien Grall <julien@xen.org>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
 <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
 <YlAZhWVFziwoL0rb@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlAZhWVFziwoL0rb@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0105.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::46) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 72b9d0d8-dd7f-4039-2aac-08da19577574
X-MS-TrafficTypeDiagnostic: AS8PR04MB8039:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8039D94861E186048631EA06B3E99@AS8PR04MB8039.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2YOqsL7RhAlt7JsN8c3wrZjyp+uTh13jE/L6eLaFT7tYYnUMeQhALv/0MaQOT8rQmNPEsbQZDOkB3wFYhJ8qMO4dyQEdQYKZrxfYfTKiLtQJCGZ7EElpaTWPCtYoW+tWOiNmr2fqWKR06/LbEQtJVDxacCN3rccDktFtc6/VBMC1wYhi7PCZy+g+YNUUT6+3ysLUdI+xAJrMex+npGY/6m2FFi3kQAo18LH2jkrTnbuCZ91kOwCGgigEjjm0yKSwW79cd9Uu7xZtU7F+xHZkl/ra7VQLMM5D2+EDSPjR9E9bzvaxtJ1k+9OfRSPpoPmIVRmt55vF4lSfFbAxarrzbI2jiM/d/p1f5+sbCeRL319Rc+LtUNYIvkaibuC7IclvtCqwgHTXRBM+myLCjXqk8PwVxgIO3mW5vSWy5HUC0IpKBxeW6iiezw2HZ91WnhLPjh3kUKw4wsqYLfl3Q5jvtku2UUSvaeyusHRoTiUxykfwn5hbHBt0QWW87tZzPKwCKvD0pe7dPSkBkL7YltPZOJ4d6bHKAxCLFoOqvWcO0pyYpT/SSX5vRTKlckJd42a76w9mKel/KRXxA2Q4u3FjNX86UmD2bXSjqKq1Cag1yHBCOjaqdwaVvDQqn+88eMKbSi+uATeeCjqOuaJtejGCyD97chNazoHCnp8Hui66PELonXlL16K7EddXC+fG7ijwimo1cvxLPhJKmdBBENa4zrFI8f2lFlR4rPuAnFHOPYWXRiUizh56F8pNYTOE9biN
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66476007)(8676002)(5660300002)(316002)(31696002)(54906003)(66946007)(53546011)(86362001)(6916009)(8936002)(83380400001)(4326008)(508600001)(6512007)(2616005)(38100700002)(6506007)(26005)(31686004)(186003)(6486002)(2906002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MvNUNd7NAJY22FEIwf2JZN9Cr/IzeP9l3aanucQD1RsGC6f1LdV223bbPP3E?=
 =?us-ascii?Q?Sx+XewdGib807AY7E1Ihof4qcuchvBJO2qOnES7yXEF3XkBxwgbXY+eP/SJa?=
 =?us-ascii?Q?WKtdsXr8nJtU7T1qqSb0jjVT3vkDgmfG0+BgdogbgUiTiG3yKmdfB8DrZ52F?=
 =?us-ascii?Q?rGkWg+87Vg17GbPwfOe4tvM0vldIygnf4GWMJ6Ba20iBnyTE/9MizHjQeAa3?=
 =?us-ascii?Q?TNSSBGS8Mn5U+PQaHyXqKaJwo591ZtiOCJ8PH2DX9LRBpxZQklrI6D5Cuwam?=
 =?us-ascii?Q?H3RuX1X3vzeme07Gr0clhc/ERln/c8ghWKIhLUh3DFg1SlDMeZvH4xUUBSjX?=
 =?us-ascii?Q?fsG0K8PXkVEP+r11/MFo9km/UDHgOCzmB+PtC6qUFLWbe0mAJwo2fCpYdRJW?=
 =?us-ascii?Q?1OlHNwsbhwfbSEeo9BUb4lBGCN77aBV/iqcFEwBLcvyNrGbGrhjBWYJm99+G?=
 =?us-ascii?Q?kMqjEMrK6QenrA121eUKuqigO4eZ79BXSVk+SowpIcg3ZQHXeYLDMLtm4Srs?=
 =?us-ascii?Q?TV2pxT79XL8JSCxO0nJfj8FrI0/fbpyxyBLnjSWrKtq8b3OvycwU2HZN6VW/?=
 =?us-ascii?Q?HrCbbmNOWb/jCHQTjC7il+GW5ypQBJXAvoYo57aVVhPx70/my2kLKppkhG6U?=
 =?us-ascii?Q?gN6Y5jepsQlCyP8hYKht4cXsKl1PHk4Tnk+lXPLJCYeDTEeckj2pBx0BpzQO?=
 =?us-ascii?Q?8wJlvyXxfPYqw6Hc9Wm+1UV2W5eL6FGijzm6efXWLFB5yMSpAtvOrVh2JxxF?=
 =?us-ascii?Q?SWAmEedP0X40VNsuNAYJcnbAUCN8ZzH9gvHn3px3SDnT7B4OMEinOWn6+e/A?=
 =?us-ascii?Q?HSeruHiWi+I2Bvtmuz4AsRs2vEg7AwEfGNadCTh2cVZLZT3PovSw0+SwyNO5?=
 =?us-ascii?Q?U1pGFRQREWhWwKFD94fVUQ3JP8F37mqFPPslVYXKIuDjgUOqDfu3YNPfrgXq?=
 =?us-ascii?Q?/CNB5d+m0pP75NIza+Dwt9T3uhjsrZB1Aw+fIeYndY8eYcDsF81UWhnj8ai+?=
 =?us-ascii?Q?UuyOHJVCU5+5NjVHLzS5e/DoiYNS8/giSgYioqCPxWqam5wrrTNMmG8puKzG?=
 =?us-ascii?Q?dy72NdLeLgDLZqRARgbm6leFioSrQcPxEy3TeY+aD2b2zCpycupZLiGXCvod?=
 =?us-ascii?Q?r9LG5Vs0N7pcAY6JhV7z2nPrMNxGDQVjJ1Yznz1pZp/Jpk0NB2nrq+SsT5bf?=
 =?us-ascii?Q?83t/yk+wasdw5v7eJyPjfhiiOroohvPFeodR64AfDEJtPx/RPZoAO4qQAfMK?=
 =?us-ascii?Q?tLdwlxsewWk0C6UnkUaYMNwOeozgXNg4Jf9Cn+iy5aAOJQf3aulqhtpzPTaH?=
 =?us-ascii?Q?HtR6qkCz1z37BUX+lmkUgwkZiE7Ig5tHTGwuDzO/1L61J9AbwhZkFcZ7hrtp?=
 =?us-ascii?Q?FZ+0bGEDqKJOpxMfYBmQKXHsJPxQW8GKBoDtI+RBnp+H5PWpbzsHW6Z8EPw+?=
 =?us-ascii?Q?3ZeensnmpT5938WjRttHvZEs0mmT519kZ/m5MT/XVRcV3QTXwWMtLS6oTLZB?=
 =?us-ascii?Q?eAa/9ssi8WKbEBdOKqqc49xxsFzS1Xo/PtmxWHTyoPAvMVB61Vp5fSh/LJmS?=
 =?us-ascii?Q?SrZh87byQrDJPaQyHcXT4HovUx26YxnziInfnC/2E3oP8irm9rWKZ4zXQd7q?=
 =?us-ascii?Q?4lhs3FjgGFx2cuA1fKnZiN9XOwqUgvkWGc07AXpMkfyF8YaCvPxxAzsNSgFj?=
 =?us-ascii?Q?u4ZUp86wht8pqRjwnGVd+zcBuhmahJb1PNVoPVwtHBwFhAJGfXX2v2bARvsM?=
 =?us-ascii?Q?AFEDunqjhg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72b9d0d8-dd7f-4039-2aac-08da19577574
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 12:01:05.0836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jtSSdfLR8TCwBKZ1RnkngFMY/aXKjYV4dQQczyXtvHwjg2Sn+opd/PYBSSuSogOBNRV7bzWlX9IUXY/um5htQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039

On 08.04.2022 13:16, Roger Pau Monn=C3=A9 wrote:
> On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote:
>> On 08/04/2022 12:01, Roger Pau Monn=C3=A9 wrote:
>>>>> I could add a suitable dom0_max_vcpus parameter to osstest.  XenServe=
r
>>>>> uses 16 for example.
>>>>
>>>> I'm afraid a fixed number won't do, the more that iirc there are
>>>> systems with just a few cores in the pool (and you don't want to
>>>> over-commit by default).
>>>
>>> But this won't over commit, it would just assign dom0 16 vCPUs at
>>> most, if the system has less than 16 vCPUs that's what would be
>>> assigned to dom0.
>>
>> AFAICT, this is not the case on Arm. If you ask 16 vCPUs, then you will =
get
>> that number even if there are 8 pCPUs.
>>
>> In fact, the documentation of dom0_max_vcpus suggests that the numbers o=
f
>> vCPUs can be more than the number of pCPUs.
>=20
> It was my understanding that you could only achieve that by using the
> min-max nomenclature, so in order to force 16 vCPUs always you would
> have to use:
>=20
> dom0_max_vcpus=3D16-16
>=20
> Otherwise the usage of '_max_' in the option name is pointless, and it
> should instead be dom0_vcpus.

I disagree: Unlike for DomU there's no way to keep a "reserve" of vCPU-s
for Dom0, except by offlining some once Dom0 runs. Hence this "max" in
the name is quite applicable.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:05:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:05:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301476.514495 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnMM-0006cw-KF; Fri, 08 Apr 2022 12:05:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301476.514495; Fri, 08 Apr 2022 12:05:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnMM-0006cp-Gy; Fri, 08 Apr 2022 12:05:02 +0000
Received: by outflank-mailman (input) for mailman id 301476;
 Fri, 08 Apr 2022 12:05:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncnMM-0006cj-1P
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:05:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d521b32-b734-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 14:05:00 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-Gfso_v97MjaXsFrXXfayAg-1; Fri, 08 Apr 2022 14:04:58 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AM8PR04MB7794.eurprd04.prod.outlook.com (2603:10a6:20b:247::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 12:04:58 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 12:04:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d521b32-b734-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649419500;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=a+Jz9vLoN0M4nIA6uRF69BNuGXwRqZlGMGPshin9uBE=;
	b=AB0OzPYiV6xGcKlBMHmrJjM8Xeh1o+rqaxUoN/oMp8pB0AekrZ/gHKKy2QBMiU0smkDw5b
	ISjAZjt+ECsrbSYI3XEAUGHzETeb8FTnPxdFoJCGj0uyFiDdBRdvNhRVf5XKjDlBFAyTA+
	h/IeS2mxnuU18/NBUVkqKeu3BqX0b+0=
X-MC-Unique: Gfso_v97MjaXsFrXXfayAg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hCjejnPeU0SX3ejVPBQ0b82WZA9oMnb801FHwneWDl0NtSpiDV8PtVTsSJDdsrdRFK0i9yTy5VXucpurIbrlutDdLznPI8hiLhRypbuVsuqOeAKL9/SMW/8s4Y45BQ1g0a6cL+QqfKWonK6RQpiN1lJk7EiCu4KTxI2dPGxksoPJfxr8fTj6LI4eAPv1agw/KWfinpe2Hj4Im3XsbRA9PColpG2P7nXt7x0KcNXKX8z/kQmGE/dfPuyKuic/DoOmyNt8XkkElGjLXcFyP6hag/sxm/twRt4xD5My2ZVrBlEChbyXQER1eX2O0vhW6aX72079yzasIJorad30ebaHyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yH5xe4LQ4xyMXtmT0Qwo490/x3HABlNRcuLEch+8eoI=;
 b=mWBLVmwUUQuzqQMx/0T4y2FooGbxCfYqx3ck2bjnwiiSsV44CYfAFUDTH5K+9QZzdBWhyquCunsX9jL1WTuVn7fWHMxLBLI5jJ9K8NeBWvBip8XTU2bEd5n+O7wd0LCXx2lY7qO33yByUBVwq5n02+TUHuov1NHPr1RMjN0KQNuSYnCRN5MyDMOKt1ILLRNcNM2ZpcLeZ9espOaOt3y8/+Ak9Ay432snmibVt2LfA/X/ePXOlRSaPzcmALeNqZEE7FazR3nrL4jqJWiVx/EGhzK1QrRKcA7BnP9YRf2hDFBIntfADomHNNhQRGf647IJRoa2WM7w7K81UWWJuia8kg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b1478c94-3289-7fb9-5d92-84a2803388af@suse.com>
Date: Fri, 8 Apr 2022 14:04:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Jason Andryuk <jandryuk@gmail.com>
References: <20220407145150.18732-1-jandryuk@gmail.com>
 <YlAYMrirDQUz8u49@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlAYMrirDQUz8u49@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5P194CA0006.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::16) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 148c1124-5fd9-4223-38e0-08da19580050
X-MS-TrafficTypeDiagnostic: AM8PR04MB7794:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7794750B2501C625010C7CE1B3E99@AM8PR04MB7794.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3Lq/iIiqBgdy4x6xAGvwt+NPSARYHtgx8AbnJbcSxS4NNBSerziBJP/7aOySVqwJcVRD0zYkxOoA6+r8FwuMA2iqZ1CgegZOwen3PLDmXpAScTkJJaKZHZHgfNuXwoXSF9TvsgcziddD4O0JhkJMB8QkTF8SUWVnW+lsvlsYN0/czNttQISv2UUEDUbzGV1jd5tYQ4QSldAiCPLCoxeL98Bm3E7xh15vxKlW9FSKMsbJ6V9QLph5PLcMjbsWfgqlpU9QA18HdWeVRyT3tTHSJx3oH8JSUtEiSKR5CNwYIAYDAG6via0+TQj5u2vxodCYjn8TPjRg4u4YKPhfF3C3TKo+aR3v0yBWrlSuWZ7ATTE/P5Dp2I9zBNAuE/McvwC6gUiPNHdaw+9hABspwAxsVyK7jU6bI53M8Zhw4+JZJgN3rL2beT8y1C9wr7ZcVFk+l6iMvsIWtdI2//yuaKLMmzzGjoqRdlIj1TQJ/bOvxHRbn6nrD4s6UJt48yjVyaUsabJp0kbO+otyViSi5OYLB0BzSo11AUrFaBaH2FfoM6/8Y+FpouqCLSRToC1xLgRGbPxKyvnMh1nx8QNycTrz7owCEW1Yq2Z5CdOk2paw79ZNkp1cmS3aJFHqBiawNzRMWNYQWje4Lo6olVyTb9IP9OyuX+EH1zZ76qjd66drsLdCMtvOuppUdIkU4yl8XMaiUx7X9bj42C+PkkyJhmaC7vjlmg3OrfZDTcrLzJlqe47Rxj9M42ZnGSTYc/Ki199z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(31696002)(31686004)(36756003)(26005)(86362001)(6486002)(6916009)(54906003)(316002)(38100700002)(53546011)(6512007)(6506007)(186003)(83380400001)(2906002)(4326008)(5660300002)(8676002)(2616005)(66946007)(8936002)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tgL9daBVRBBjl7LthCLmVpa/RIpt5k7ZIpsdsxpP2ikZqsql2XvpzAQEsMz7?=
 =?us-ascii?Q?pyyYn6fh3LA4QeKc+vTbA8V91gSZq1OR5f6wIczndUVE1g4lKRD5dWN4fyH3?=
 =?us-ascii?Q?iz2pvGTBQPzqOQ5ZFzlTo4K2zw1Ktzdp6XHMJSGIy+IKTYUq/ZZW6q9JjnH4?=
 =?us-ascii?Q?RNr8bdS8hLEBfstKUthHM/Ur99dYZDsRojxu8V7aLNgsqQxMnEHSJH8/Td76?=
 =?us-ascii?Q?L+gMeE3+Zwchyhswhuh4Yxx5skABDGGXnU0jnyVNLvkAC4GkdBOlGOog0eWr?=
 =?us-ascii?Q?YEFbH2GWMtMrykgd2rYt0tODsI+Fp4tA7hzLEs/X1MUKpzP14y6+McJfn0uQ?=
 =?us-ascii?Q?o7O2ZKgwPmAWrChKMK/7YXVmXIFEgA3pEH6npT4xyHSL/MYZnIi9Dm2IPBSz?=
 =?us-ascii?Q?k0yCrCFmh02XTf9sTE6maR01lkYV0Km6mC7UQ0IvNqqys+l5PkvH0VXyGk0G?=
 =?us-ascii?Q?NKviwBLRpD9WMlyquIp105p6C+55xGKEGNO2R9Q7nHcDZfYPzIqkVBWOztg1?=
 =?us-ascii?Q?MUEcviiqrnZlySSU3kT9HuU1Vs6HJaVoQLU4Rw5yJAl3+k6lEOZxpktj5SBz?=
 =?us-ascii?Q?tCJlUi99dYrXIYCqwW/mSNqdQVUKsZG+q4Ie7vUjCNiX52NqBzbVaubOrHNX?=
 =?us-ascii?Q?4qsw0ErHgA7XSFgCkqGvTPwfhsePZyMLKsUjLgK7vde9uRXc+vnNpkrWZOcg?=
 =?us-ascii?Q?kXzc3EuHGQ0VsFiUTl7kuw1usMTi4mX3sQiZeaGPhf2zDv0GtyyYJw+zAwWV?=
 =?us-ascii?Q?Q8o34IyiSXCuYSsYu39EM2Q6a95q/h25hzQNPtONpai8rsyIy8R5iALqv582?=
 =?us-ascii?Q?AFk2uGWG/3kUAz+swgJScmUoVDOBrFauIjIBAPQIKyx1lPHWNeGUcDi39BOk?=
 =?us-ascii?Q?xyjfXHBadc9U05LI+w8v9B8i6i2EV3ZF14D0qKXVrqhM9+s+wrzGRUfLmmxd?=
 =?us-ascii?Q?67beLmv5tsCo1zA4pef3mqzZejL0NfqW2FWlFHujL7OB1YFY07WiaH5sdfOt?=
 =?us-ascii?Q?tP/dkjIX/amPIywuDeuZQQDUgxFuQJDZNctVRV50ECCogZzDcNt3VQLtGwgx?=
 =?us-ascii?Q?A7BsaOyi3ZTUxxQrTKA2nsalynDAUXG0GgwEArbSw1TETBLd6FGWOAc5dlk2?=
 =?us-ascii?Q?0VlXuBR6RtuopLJka0XOvpuAoMgNE2CgROaJaFcgoHONX6uKwW9I759Ofkh0?=
 =?us-ascii?Q?WJ08jRnVF4uN9mwN8UMFCi3r9lJ79aLhZRzwmlwHWBhdUHtu+u7JAL4R196b?=
 =?us-ascii?Q?kRVW3H9EwbG4X6MVagpDyniZdwpLEgmk9UbuHcqNH0DIrb41/ypdU+y9kL/W?=
 =?us-ascii?Q?8kWGrhX4GZDHNbsjoRgxeBXT0fojXQONHg38eG079aPuqQ+ZifIPFoo+8wKz?=
 =?us-ascii?Q?x49Ntr1wnfqIwsqAyGXM0vhQk2GFyFLcVarH8DsqWuF6OIzO10UeAFMZVxhg?=
 =?us-ascii?Q?WuKcNPrP75f3me4pM8yCwwtKSahBhwDGsZM+Y9S9OH53OgZLP+bhed7nD/x8?=
 =?us-ascii?Q?SXYyljJn5kB2Zdw4N1XTOO4Do4pXJmf2+GI7uRFWzWhx9kv9HWccYIyuSqWi?=
 =?us-ascii?Q?A/UDVvzuHgweQ3Xe1s1WBnVW3QQv6C2WP3k9mxtLCYPckMK4g9DpxF6UjZHT?=
 =?us-ascii?Q?GaiCQRUINlidXEVV59PlBDfiodBY8rg7sOiB1e+WrEv4YwU6Dh3qCIZvzhMD?=
 =?us-ascii?Q?VcqPPsyk/jJjLKk+SQ9QeiMrSpQpxARfzxP1aOJmuSuAMl4l27XTmrjMrVWw?=
 =?us-ascii?Q?Xq22SJ/0GQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 148c1124-5fd9-4223-38e0-08da19580050
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 12:04:58.0513
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p0WxhfLPnk6mrQf9QMSKnH/HZuWEVCGdtlnB1PhWkB2xvesF5KMACtWZ9GhUKTpZ/366m0gCUvczY1SabL10rQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7794

On 08.04.2022 13:10, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 07, 2022 at 10:51:50AM -0400, Jason Andryuk wrote:
>> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
>> complete_domain_destroy as an RCU callback.  The source context was an
>> unexpected, random domain.  Since this is a xen-internal operation,
>> going through the XSM hook is inapproriate.
>>
>> Check d->is_dying and skip the XSM hook when set since this is a cleanup
>> operation for a domain being destroyed.
>>
>> Suggested-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
>> ---
>> v2:
>> Style fixes
>> Rely on ret=3D0 initialization
>>
>> ---
>>  xen/arch/x86/irq.c | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
>> index 285ac399fb..de30ee7779 100644
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -2340,8 +2340,14 @@ int unmap_domain_pirq(struct domain *d, int pirq)
>>          nr =3D msi_desc->msi.nvec;
>>      }
>> =20
>> -    ret =3D xsm_unmap_domain_irq(XSM_HOOK, d, irq,
>> -                               msi_desc ? msi_desc->dev : NULL);
>> +    /*
>> +     * When called by complete_domain_destroy via RCU, current is a ran=
dom
>> +     * domain.  Skip the XSM check since this is a Xen-initiated action=
.
>> +     */
>> +    if ( !d->is_dying )
>> +        ret =3D xsm_unmap_domain_irq(XSM_HOOK, d, irq,
>> +                                   msi_desc ? msi_desc->dev : NULL);
>> +
>=20
> Nit: I would remove the extra space here, but that's a question of
> taste...

Which extra space are you referring to? The only candidate I can spot
are the two adjacent spaces in the comment, between the two sentences.
But that's several lines up. And I think we have examples of both
single and double spaces in the code base for such cases. I know I'm
not even consistent myself in this regard - the longer a comment gets,
the more likely I am to use two spaces between sentences.

> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>=20
> I wonder if long term we could make this cleaner, maybe by moving the
> unbind so it always happen in the context of the caller of the destroy
> hypercall instead of in the RCU context?

This would be nice, but when I looked at this long ago it didn't seem
straightforward to achieve.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:10:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:10:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301483.514507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnRZ-0008Ir-6v; Fri, 08 Apr 2022 12:10:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301483.514507; Fri, 08 Apr 2022 12:10:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnRZ-0008Ik-3T; Fri, 08 Apr 2022 12:10:25 +0000
Received: by outflank-mailman (input) for mailman id 301483;
 Fri, 08 Apr 2022 12:10:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncnRX-0008Ie-H0
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:10:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dd41b40d-b734-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 14:10:22 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-O9aD-cxePJ-giWz5iJNmIg-1; Fri, 08 Apr 2022 14:10:20 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by AS1PR04MB9558.eurprd04.prod.outlook.com (2603:10a6:20b:482::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.25; Fri, 8 Apr
 2022 12:10:18 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 12:10:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd41b40d-b734-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649419821;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=E1wo0fTsh9XaUvBpjxJPWlSeZ+zKv59QP8OYwsrKzjM=;
	b=SnphM1FMrDXslBrtTDVQ4hYsPJXU6CjoGsJzZszDJ4qXK9hODS7D74YKP9hhK9tONPxaqE
	aTZylft0T5li5WQ5v+o6dV6mdl3solmZck2ZF2tQsNJKlavIBCeDP3gJC4AUlGDZIj85+W
	j4MqMBxNS+1G5RsbGUikArgVnBboL3c=
X-MC-Unique: O9aD-cxePJ-giWz5iJNmIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CiYjx7CXFjngRuxI7SBMdDAxWKbB0hp6mN0yXNrXc8adq1uG92jm+II0uUums26uxQPjSjLh1sWFMyUcWR27DhGAxDhlH0RDa62VsGWS7/ORjvH9T/sgnOImX1BHrG9iiZo9Rbwrbgi0XVNrYQCI0pMqxeccY1NZN6OjuDpHNeMvLdc+OYoqr4jQ8wCPfvohA3DuLGul4VqIqrUDqvVaufZG8YqR2m5OtZ9Y9/QQWGsXbqDeSNUKqCgMk4v8WkGoRoOFPvg4jD3D5AvBla05dexC+9eV3XlOi56XKPoU2CdcNqS9c920Tn96foIJLsT0LUYi6ksOyYjIIpi/K++W4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=H8gUcpW0Qi4HwGdRb/eVY8/nLnpxDLjctSbhndvAeNI=;
 b=lPeQLH9DsqpRdkAsIjhDLs7rTDv9gkAHC/VO6Qx9mpzo8aFySjQVBQwXWPHs/avw25/VXykMEM+UfHdl0LYUofZM/I86nNhE5OB4Ioq3PZD3mufZQToyTlYvnYj19etTA2r1YqpmqT7axyhtBKs4h1fddmCp7xm0Aq+K4pmMrQMNFlfJv/hMuAlghf/dVfkINiRsxBL+Z12FiEH+QkfQlMY9nh2lSU2u7wHZDWUYi+swCAhATtMZ9HLqOA3vhAjT8OgZNsPljB0WHt2NitVhLB3prT9Pr6/0Gb7PEl6O6mpugDfU1Lmiqc8e1rvO6BSYiB4pWZc1UbFQCA85bSaDIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0a85f239-dbf8-2e06-0158-75a1c1c40a4c@suse.com>
Date: Fri, 8 Apr 2022 14:10:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: Juergen Gross <jgross@suse.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
 <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
 <cacbaa1c-8ae8-9314-9364-97e5a53d876b@suse.com>
 <61DEEA58-E570-4FEF-9B71-27316C7F8D7C@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <61DEEA58-E570-4FEF-9B71-27316C7F8D7C@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0065.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::10) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71528621-ff1a-4d75-a9ef-08da1958bed3
X-MS-TrafficTypeDiagnostic: AS1PR04MB9558:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AS1PR04MB9558858A096BE4EABB61883BB3E99@AS1PR04MB9558.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CZRVIw2rq7n5TiJlLX2v1dEe0iJZ6ptdsHMk6qtsbL8xCjvkpweOlDfgjEp+NQ26ot0DRtoWxQRD8RNjdMGTwHh+DahpXvvXqdVSgK+ZUfJtDpiK828HlyNoAgoCd0w2Z2dCK4KR1e1i9lRGO78BC9GoT6xF5LBxCnzvl8JvUrf0TDJkks04+5YhhyIMCpluh63ybaPSXKbfGrRoL+rHHXxzMhWHUwdJFRLMblIEiiJzfmyTz7DeyuIlyXOVeiJI3YTAVNEXWZf6eOZtGN5qeA1YpUl3SNIfbRA+lHAp/EqVhddFoaNlRUttTKTrdnVGUh3Gn/C0jhgtgNYTjWATGQqhZhvKwkNquW3QfkAu6AK4jNAh1cbAcaOkz77hbrg6o1Y5XcNw/2HsWrlx5KFGf8b6m1xYzSAtYDIVc51Y/e8+ghPhrdiViDhyY8tvW61ImoPTcZciPW7ul7tXf0K8P3xUJdxmJGFY8Cvu4cKm0RWL1fJrRfv4TL6rnG8/glq5dAhGbHsuOz+E/jqOMJJE6ABPI9bJA2R4pyEKB5rkhJcsdT/jYxCt2xe5oA5ytQKN8g0gu1hPp831WFrC2lTYMhW1goHAiRG0N20S7kZMvSdMm8kXOkQRdn75DKAlhsG9DgSEE9DU7YSuxtY1WHVwV5BwL3JKJupiMXSpx06bDlBx4RJtRGgv9mTOKq/bVv0czJ/k233N6+l+c0oWse9BKMiC+keh0Q68unrRDRiso/yjiJEzj2n/GYsvwYGcbhKeYP+AXEoKwrWelR6ELEtoUw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66946007)(66476007)(83380400001)(6512007)(6506007)(86362001)(8676002)(31696002)(6666004)(53546011)(6486002)(508600001)(26005)(186003)(66574015)(316002)(5660300002)(36756003)(38100700002)(54906003)(6916009)(2616005)(4326008)(7416002)(8936002)(2906002)(31686004)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?x6FsDLWujKTMZKBFBer6Kvbcnwzdn5If21cDxMIdBH4/xrI7lpPpxTgFIed7?=
 =?us-ascii?Q?f0ph9iFWK72afkfi26lbafbUOiwb3y6pyYliCzK+FBOqvKBPaDa1RFXiaIQl?=
 =?us-ascii?Q?rIrkWR49nF70P8Pz5tR3tLoSlJx4IvMYAw2WqhEjjEVZgMUgiy1PaCrKU5ER?=
 =?us-ascii?Q?R4fhEulxllBb1wKym2BBvVLE2FNaq1b3urhGYpMip1HdmxzddsssNkHwd3ja?=
 =?us-ascii?Q?/FuKZ0vbWLFL5y/fIv/zfHW4TdZFx40Xn37LquUHHmB1UQswO+xeddzYfx1e?=
 =?us-ascii?Q?JK+8OAtsI9EZHX6FZcyJwD6aTF+Ss3EI5pFLQ2uu+OI5tn/XRWH1v0AAL9qA?=
 =?us-ascii?Q?m6FF3qK0teyhpeFLJfD96W9HJ9N3wUvYvRKrcWx/a0hWJpxYNqk3D6Q+YMHC?=
 =?us-ascii?Q?xn0VZYhQyte9pWvHTqmdg5RpAq4GpJ7TSFZv2oZbahfFtxwBGG3rIaomMSbB?=
 =?us-ascii?Q?s5disUHinZMWFZ9r0/+xAlUG0LlbKA/dJhd2bzT6F5hEyKlX6XerUYAyDG02?=
 =?us-ascii?Q?19AEMl00crthPSCesyWkkUOq6/sN2j1ut6mrdlM9ss9RfrGUBoyIzn6jrQ/j?=
 =?us-ascii?Q?8XFZi7htBBZDyId+MZRdPI9fHki8KkRtpi8Hr8GXhJNocylWhxxBroJlz5R6?=
 =?us-ascii?Q?Fj6JvzrL6T5xsLpYymGaBshLuXjj3rBbF/Z+MTnZJ/eLDf9G35glSbpA5E9T?=
 =?us-ascii?Q?JViE0p4reShq1GFrHaEu7P1dwKmfUj/uQp4YDRRT7USIU/+mEr+Mnn6NDbNh?=
 =?us-ascii?Q?Ep0ejGkRM4ekQMrhT8QDnTeuYJ+PlPD15p3iGt77tuVOTNN0rVrSXSalaNkL?=
 =?us-ascii?Q?MhB2qaBXuKgR3I1JTPPBhIGbEUg1hiLyyoQh9LxacFYX/863YccNin4/+fnH?=
 =?us-ascii?Q?rR0ZEFl0odoaK3DdGD0z6GlRYZDYItzz8KWYZMoXZYVoNYS3PXDDu/P07t94?=
 =?us-ascii?Q?9cjlS6Dp7D1BUXRSw8gvOcCwCrRaah2Mm20leIc0WiPpGkAkmHxkL2tOIZDM?=
 =?us-ascii?Q?sGGpXBsJMSRhrt2fQsN+GEpb50gvZpZ4Q/VEOuETDEeqRKCC2RbL9UCC3LFx?=
 =?us-ascii?Q?r86Pje7KejUPi/6VOGEKMTg1ZkHispP2mIpV9/b90kOo0NeCR89/sMxuT0+T?=
 =?us-ascii?Q?majgNMbkKJ9A63jHB4qtzWGsOg/iC/yuVS0iarvIOJP8k4l+yXZgDQ9ak1mz?=
 =?us-ascii?Q?PFT+CVYuyLvtx1Q7FeCpmrJqVllUvxu74A+Fx0o77yFQTx8ThiJDcopQqh+V?=
 =?us-ascii?Q?eoIuGVcZCe+mHuB1NmAdzj9iEWqvvFI6BhaWsmOLDEJM0uYR9i3pHrCrUKa9?=
 =?us-ascii?Q?ye3lESTi4UV9pwYqQj5su+TaSpi9/KADSjDgK9hgPy/2uXzDX0iiE7yVGx99?=
 =?us-ascii?Q?/ECU9eYai+FvXrN2ipvJyDnVOoLKxqRnS4QOd20P3nfC45Ay7k0Jssn3vqYc?=
 =?us-ascii?Q?Vrwa7VYud1eBdSuclpJ1oyQ7jVukxSDjv7G7uqPK1SOMf7T580BCAyLspVaj?=
 =?us-ascii?Q?Zw/PrmMldsUSYiyLnzgHJhlby26m0v18u06SqOPkVZ7p9iBsLX7kgaeqceI2?=
 =?us-ascii?Q?EnQY0xsLrL82xMnF+E5hd5eKusMRmV+XZ4m0dqO7/W1o9EJUpdLYnpPI9oL/?=
 =?us-ascii?Q?t8bAI9U8fJOVr7YEWJ1d3L3T9Y/gW+b48WINRtvqs/g2KPxwCSO+r1Mzbds8?=
 =?us-ascii?Q?xM+0W+GBWC+KpggauIkhnF6JgKY2uRPfsgrXKYCKw5WEX3lKXgZhkZ2GfYg8?=
 =?us-ascii?Q?X1xtrmWc3w=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71528621-ff1a-4d75-a9ef-08da1958bed3
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 12:10:18.2423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xB3xcSqgKxQCZpoV2T7FbpRs+yNj0wTP+Uw2Nepx/2ag+BgKZ4KT3BeTAxI1N2OVxapsxsYNkbTEK4b6btdu2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9558

On 08.04.2022 13:15, Luca Fancellu wrote:
>=20
>=20
>> On 8 Apr 2022, at 11:24, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 08.04.2022 11:39, Luca Fancellu wrote:
>>>
>>>
>>>> On 8 Apr 2022, at 10:10, Jan Beulich <jbeulich@suse.com> wrote:
>>>>
>>>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>>>> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
>>>>> /* Per-vCPU buffer size in bytes. 0 to disable. */
>>>>> uint32_t vmtrace_size;
>>>>>
>>>>> + uint32_t cpupool_id;
>>>>
>>>> This could do with a comment explaining default behavior. In particula=
r
>>>> I wonder what 0 means: Looking at cpupool_destroy() I can't see that i=
t
>>>> would be impossible to delete pool 0 (but there may of course be
>>>> reasons elsewhere, e.g. preventing pool 0 to ever go empty) - J=C3=BCr=
gen?
>>>> Yet if pool 0 can be removed, zero being passed in here should imo not
>>>> lead to failure of VM creation. Otoh I understand that this would
>>>> already happen ahead of your change, preventing of which would
>>>> apparently possible only via passing CPUPOOLID_NONE here.
>>>
>>> Pool-0 can=E2=80=99t be emptied because Dom0 is sitting there (the patc=
h is modifying
>>> cpupool_id only for DomUs).
>>
>> But we're talking about dom0less as per the subject of the patch here.
>=20
> Domains started using dom0less feature are not privileged and can=E2=80=
=99t do any operation
> on cpu pools, that=E2=80=99s why I thought about Dom0.

It's all a matter of XSM policy what a domain may or may not be able
to carry out.

>>> I thought the name was self explanatory, but if I have to put a comment=
, would
>>> It work something like that:
>>>
>>> /* Cpupool id where the domain will be assigned on creation */
>>
>> I don't view this kind of comment as necessary. I was really after
>> calling out default behavior, along the lines of "0 to disable" that
>> you can see in patch context.
>=20
> Ok, could this work?
>=20
> /* Domain cpupool id on creation. Default 0 as Pool-0 is always present. =
*/

Hmm, I may have misguided you by talking about "default". There's no
default here, as it's the caller's responsibility to set the field,
and what's there will be used. Maybe "CPU pool to use; specify 0
unless a specific existing pool is to be used".

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:13:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:13:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301490.514518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnUH-0000YI-NW; Fri, 08 Apr 2022 12:13:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301490.514518; Fri, 08 Apr 2022 12:13:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnUH-0000YB-Jr; Fri, 08 Apr 2022 12:13:13 +0000
Received: by outflank-mailman (input) for mailman id 301490;
 Fri, 08 Apr 2022 12:13:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K+qN=US=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ncnUG-0000Y3-JR
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:13:12 +0000
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com
 [2a00:1450:4864:20::12e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 41d0d5db-b735-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 14:13:10 +0200 (CEST)
Received: by mail-lf1-x12e.google.com with SMTP id d40so7178161lfv.11
 for <xen-devel@lists.xenproject.org>; Fri, 08 Apr 2022 05:13:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41d0d5db-b735-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=fjzsqM2Aq6bI/R4MOEHqqKcutv3AUjy6oe0odTRwJHk=;
        b=OkLVfZDGLNoEi6MHXGNE/OqYMV8TezXnrz6AHIxPq/g41cG+Zb/KWS3GxYeiqtLGxF
         DIchmMJ0YPNKrJog73gTkTOo3orE29LadzNfoItGo+fdL6hfXGCim4HrXEZ9r1eHGW8G
         Xzo0+SHN+dk3x8K6eyJtrfSbUkSzKQ3JZs2rxNq3pT8hu4T+rOsS5RFSX50o5U43byWJ
         PI3lo2TZqEQTSchc+v+0v+codwtdA4lT8Q9sIR3fdXiK67gj8MrOYuzyDhafRz2AKo6K
         Ru1HRmAokMdIBkxw2aUUFBKRmw3XpbX2a06GjZNv336AeFjB8etg4BN8SjxGhR2BpeW7
         5UeA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=fjzsqM2Aq6bI/R4MOEHqqKcutv3AUjy6oe0odTRwJHk=;
        b=KGSQHjuSFjoLXkLBNQAjE5EslOl8N5NgBh9JkeXrCdIaYm6trJ41AAWR7A0p6vanS6
         S4KlLVQdwGHk7MfDBAGoCH6Q88D0saCHV9YzAMsHX6WxcrxstxSpe0LiGBKZ1IT3Z+fd
         d8JvNlxHJEe3tChIwUJ4oTYj74JKLA6o2kjuNvaRRBAiWvafZAfMzDadMusxmDvkiHNY
         2XEz+5xvLxu6LIOizACrrCcXSStdbgC3DUyypg0PphG0c2zDtyXWnF8Pmrr8yu8xSxr1
         Q/j2cpvmogDjgOyfnhFtNdsS85ruM05uqKlHYWQVP5OJki9cR6PeqJsPP8YHltyeun2C
         18MQ==
X-Gm-Message-State: AOAM531b/tdtEpoTeTn6HQYwYmLugZ9OP0r4JkunSYBuF/RJlcJJ8nU2
	jMGJdqamm72JalLtj0CbZO/wzymDGR9VTa43bfc=
X-Google-Smtp-Source: ABdhPJwh6PLV+9ltHILguAbZi+RA9qkesxQ5cgyt3M4KGWPf54n8d6YruewMPHLIeY1zGsxAzsfMkReHmsMjBIT0dTo=
X-Received: by 2002:ac2:43d0:0:b0:46b:8248:57d5 with SMTP id
 u16-20020ac243d0000000b0046b824857d5mr2756448lfl.250.1649419991199; Fri, 08
 Apr 2022 05:13:11 -0700 (PDT)
MIME-Version: 1.0
References: <6e1c7faf-d1ea-1a61-5452-9dec5b8fd221@suse.com>
 <6739cf19-a74a-208d-82e8-28dfde7710f5@suse.com> <Yk6VvXJHWxJZTgeF@Air-de-Roger>
 <15a53720-4dd1-3139-5d78-5b8a5704a953@suse.com> <CAKf6xps+VAvi1QcDGG=mB2pVt3frWFj=6pYrDMVKH+KgE6qaEw@mail.gmail.com>
 <0057e1c5-a651-dfbe-18ed-dc118abb723d@suse.com>
In-Reply-To: <0057e1c5-a651-dfbe-18ed-dc118abb723d@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Fri, 8 Apr 2022 08:12:59 -0400
Message-ID: <CAKf6xpux1Eo7necx8OdiApWs=hKAf663C0E2zcKiszBnDY9f6g@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] VT-d: avoid NULL deref on domain_context_mapping_one()
 error paths
To: Jan Beulich <jbeulich@suse.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin Tian <kevin.tian@intel.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 8, 2022 at 2:03 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 07.04.2022 18:31, Jason Andryuk wrote:
> > As I understand it, an RMRR is common with USB controllers for
> > implementing legacy mouse & keyboard support.  The Cannon Point PCH is
> > fairly modern, so I'd expect it to use PCI Express.  Xen seems to
> > identify it as DEV_TYPE_PCI given "PCI" above.  It is an integrated
> > PCI device, so it has no upstream bridge.  Maybe that is why it can
> > still be assigned?  The "unsupported assignment" is a legacy PCI
> > device, behind a bridge, with an RMRR?
>
> Ah yes - the "behind a bridge" aspect does matter (but I can't
> adjust the description of an already committed patch). That's both
> for the respective part of the XSA-400 series as well as for the
> change here.

Ok.  Thank you for confirming.  It is captured in the mailing list
archive at least.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:14:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:14:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301493.514529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnVN-00016z-0y; Fri, 08 Apr 2022 12:14:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301493.514529; Fri, 08 Apr 2022 12:14:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnVM-00016s-Tp; Fri, 08 Apr 2022 12:14:20 +0000
Received: by outflank-mailman (input) for mailman id 301493;
 Fri, 08 Apr 2022 12:14:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncnVK-00016h-U8
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:14:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 69b2b7f0-b735-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 14:14:17 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-dAgOwjJWOWK7qRm-h6L0PQ-1; Fri, 08 Apr 2022 14:14:16 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by PAXPR04MB9668.eurprd04.prod.outlook.com (2603:10a6:102:243::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 12:14:15 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 12:14:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69b2b7f0-b735-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649420057;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uVfb5Bd6fmwMHlQ6EzAUC1CaEkWi/Gi6okL2pb65sIo=;
	b=fMxhvNju1Hlh4gJrmZPhYomQm+uhg5UTlybMM7U554Whh+Whc/LnzsBrGi3hcVtFD8Xf12
	fH3pxSqX3e9VRMv2DHn5f/UYWS6xJRpmwykbEFtR3USkuPIYM7obzde2IEoRJBKySfw6bJ
	QrD/5WMATMxQn2NBoHfR5XoH7BtRL5I=
X-MC-Unique: dAgOwjJWOWK7qRm-h6L0PQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RX/+FZYcDZBFgfjXz/lESUzWFz8T6Na/2kDqcp1Xd2Ykg1bgkHAJCJdRk40BzFfZNPZSp3U/7VW4wClqCj2M5otLfVVCfi3Pbfss/poyiVM2oDDXoQviYOt/0RUdZaBg7vi+LcNpGPVZWHaFJIr7cbWG3d7VJOGjrPqXkX2D7yNfDykvNyH/4iQ7duMM62mpkYLlE1ZA3KBzUxOfWVe7Ku23MbwJElYmDVULJdH/0gz5JYp7tqxSteVfgZFEI60Z8sfalVOHEcfcnxq1cnUqkcocQyB5bzPKEYuj/3qM7mnfxQl7ygnZ8yjwJ1/K34Jci4dpBpDMnSqZ08k04dcQ6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UHV6gbW///R1wlj+a4qra8fR15tXppu/qY55Lum5rV8=;
 b=YF6UxMmNk9ezVtW/+0ib9KJNIo3qnmAwzSKIAMs37KVqGWyQ6EerPjTKxqgw6xCmYuQ5U0Us/xCkrQnFZ8vxKjYf3CKKYmnH6ZcHhVOst+VM652rQOoEPT0nvLOuLaMo8wvIucLq+GiJvl9qpzAoFPQsFwi1oY2O4pX+ascsogJ/kiue4B3VClSGTxf5TJ0hy7OKgHINaiYElz3Soph19sZ3ZzXI3bpVKgnOOkj9rXZJPaWG5k+GmLKCZWeN5EfHinTSZF6NhCr2KC6Jx1+/7G6FvzIGxyqvRubScMxp5HEJsXubXEYldnIv+wH7LBoXdvwOz45L23xXKU0CNBua1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0c0d4b41-5c4f-cad2-dc0d-d87e47e08ea4@suse.com>
Date: Fri, 8 Apr 2022 14:14:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV
 and HVM parts
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <69623630-cda7-9b2b-4f2f-09a83d5dc22a@suse.com>
 <YlAUloDvk20Y01tn@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlAUloDvk20Y01tn@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0601CA0048.eurprd06.prod.outlook.com
 (2603:10a6:203:68::34) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 91a65b68-956b-44a0-deb7-08da19594ca0
X-MS-TrafficTypeDiagnostic: PAXPR04MB9668:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB9668CE1503DA20E40D012D40B3E99@PAXPR04MB9668.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	V/kUFQi8YNeItILVA2MIMge5Y6Ze+Bv1Q+WKBROypOSrfTs01tz9B/lUDuXohLQlC57dWOlCW6aThb6W7oj28NHmwxP+t55dwRQ4C5ybRlpFoEx4vq0jBARntHBe0aJhDwnZo1Gq4odVdQu3jU371y6kDJGE1tkGyky2b4pIWYZvy2P/mQhBv9NCT9tPEKHh8Pq1DB6+a53VbyEmYuLdrNTxHls74RhOZoGUCOgBxgn5uzzPHZ6UkdXhH0pW+BPYZJfOO4j5+6vK84ALuG4imMpEAuq0a/zOpUxs5en2RiEWRl/2ClrmMkNv8fGUTVBC/OXnx2Q4S6m0V/JTEXBu2yn6tDwTwcwKOh259pcg3cx2Av/pWPXEcJXXBZ6lntdS9RfS+0owKkjNiTcnBamKCCrdruLIAEOBPa6JFR8lVA5l9R/jKKm6NdbnSosL8HVMm0vO6RBs8eFBcrXJ1/889viNaKSpAgaERY6gzaFiNSy2LhN4PSYCPvStV+Lm0UDxiaOPG9paxBn9L6EmFkTHRjU4aI+nAxf9EvZM5FhSURHBEtuEEGhtklV7pt4t9Z7/pDgTaAZSEyGnv1xkFDoEYUh/Iw8vxiIIZSfkLtSq80fb32IpmzZGyoXB5vW0uFfTOGFOeD3HbOd7Bzlgt8h6S57z52QloQL5XDcQzTvVihvXj5komMrX3XYfxwn2wD6c+zqbFIkQkZG5BPIw8DoDZ6ARatN9JAdaT9/OI5y8wJXDGzNquofRBD7VMNfn3IuJXvws1+B/+P4PCKoYq89UKA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2906002)(6506007)(8676002)(38100700002)(53546011)(316002)(6512007)(86362001)(36756003)(5660300002)(6486002)(31696002)(31686004)(26005)(508600001)(66946007)(6916009)(54906003)(8936002)(2616005)(4326008)(66556008)(66476007)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pkwnvrwDT5ecAej5eI8pXdNwlQtgriTrciCfJtQu4ha3MvWM7+3uS7+Pk/cj?=
 =?us-ascii?Q?EaL2FoFDmAkXV80YUm4B/HtUcLmkYgiUgMm4wZQseQ5eww2PooSzxChF8Gva?=
 =?us-ascii?Q?cm8W5junLXdIpQ8ZkNSEAgsXH+ZGpY8BjH9UQ6jKJ2bVtoYwOgAzEzqtGPRJ?=
 =?us-ascii?Q?4s803DMq+Tuxk6Q6XjJ81uZUy3sep3br0v7d+X2xhqDXPV545Uo4twPs0hVr?=
 =?us-ascii?Q?4gEZow8j+eR0n2plF7a9buYm1h94ybTvjGpyPVulY43bSoaqPFEdWhX9/dcE?=
 =?us-ascii?Q?JyKx453uIWK9qyGlemg+l3Wf9kqrmGfCBNMcqnJ0qlJnOwm33qJZeGMk8LPE?=
 =?us-ascii?Q?i2nCnSSlPps/4gkorgmrQjLbZxFKxOIqz2zUeBwmSjw11Vx8AxZ5H9pkKcMs?=
 =?us-ascii?Q?EQTXfvX/OVh+MiyoxX3qOXKes2WMUNthu4rI6Hocfu0xY925b9Edla7R4ID9?=
 =?us-ascii?Q?GrXo4uCkv52tVV6czLQxP/p4QvLbkFU03XNAOzEJaQrEErC1Ekjjs/xqckHf?=
 =?us-ascii?Q?nvGEkYhT31CQ8GE+aE0njSFJul1z9OUUnAkq8TCOealI/QPOCMA57pRlxk/J?=
 =?us-ascii?Q?2MI5DrzvuHG9lBPHeQ8pVAPSKpHjYcIdBfUOftSSNdP4PIctMWPIinHKBGua?=
 =?us-ascii?Q?zDxpdU/UxLib9Zo7zRyN+/aI7qqLwaox7LYpXsSQuvXMXof2BmTFTaxJVboq?=
 =?us-ascii?Q?YhmqFky+Knn7B1iZ/AOFsT92fGGeETpWDqNaWNaoph69lVwwKf0BivBYQjEY?=
 =?us-ascii?Q?1mjtWYVKxvQ76yZObWccvs4rV8ajA1xdxAURa3qvDxhGG/VVPYr4z4joNZGK?=
 =?us-ascii?Q?RoZ2u4zvgK30RynrEiIagHbOosj2OF2pyAFOiIv7A3sfV9tuiB53qznQThmu?=
 =?us-ascii?Q?mOU6jVBxcDJSaNDfOaNUfzF2g2KuSA2bW1K9FQLRjmoRrmzXqxcWHxGy9yf9?=
 =?us-ascii?Q?sb9JNwHoEJwH+5lXh+6nN4s43bnFN2Y1qL4DD2oC9n3FsYAriatwrqj0ZebD?=
 =?us-ascii?Q?f8Sb41X8QZNLEJ5qh5FFuC54rSbb945nvqajKIzMjVepfdgQHXPKSihHUZ5r?=
 =?us-ascii?Q?HgL016WClHefrCYI4CT82CksuUSKm7sz5colyoUvAViWeB8sJgz6Ehz/ud3O?=
 =?us-ascii?Q?3YqSE/UqymBANPgH0o49glz5qZoMfk/+8j4v74BgLgcua6kuAcDybkUrOuJs?=
 =?us-ascii?Q?jWCjSS2t4qP0y6NU/FeuJjVJY0Dz4pmRfpjfkf2jedCopWa1K82RlECFcfP6?=
 =?us-ascii?Q?wmRxyg/e1xN8dmvNq85ke735vxgez0KzZ9/7pLBwAx7pI7eOQmEE4LLyOem3?=
 =?us-ascii?Q?Yew1dioiFxe3pKOG/anA8HJj9vFOfzu2jIrtmePi3O7TfhCy9Z/wSPGw9/K6?=
 =?us-ascii?Q?ZLeJbLLiaoB29+UVpcWF4rgbL9Lun+cX3Tlpd3kZP/l8o3UKBdorPAz39/YN?=
 =?us-ascii?Q?qOwmBIM1YZNDiweHxeRXeD014pHvllgvjh974DQpdU27DrxAgY7CWnoQ5qTI?=
 =?us-ascii?Q?7awkKFah6X6/BEq32muwyXpkaES0/D8B2g/81rgjl68EwPBSQJMQFC3HNQbn?=
 =?us-ascii?Q?N6Ilkuia3srnoPnk4ljebB/175Hifoaq6wpOc4Mbj5IMLrYnBxaNv4toVHPl?=
 =?us-ascii?Q?RX8ou8GJCU0Zu5ORL5V42fDePx1Qg8E7Rk9nF+B7T2MLvgQZoIJksPODFIzA?=
 =?us-ascii?Q?3cLE8BBlP8IuhsiQXPukpAjTP4Q3OjKx1Qggsn+PzlJxtN2YP3x1kiM95Iu3?=
 =?us-ascii?Q?0A4nOLLB6w=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91a65b68-956b-44a0-deb7-08da19594ca0
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 12:14:15.5991
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8C+EVIKUkVzWHKZFPnQvDjEQ+E8ncDtRim8nw67E8sY8yavAJMxVVu/F3bDAksSYBIdAEOI3Zpf/vO5BmEnbaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9668

On 08.04.2022 12:55, Roger Pau Monn=C3=A9 wrote:
> On Wed, Feb 23, 2022 at 04:59:42PM +0100, Jan Beulich wrote:
>> ..., moving the former into the new physmap.c. Also call the new
>> functions directly from arch_iommu_hwdom_init() and
>> vpci_make_msix_hole(), as the PV/HVM split is explicit there.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Reviewed-by: George Dunlap <george.dunlap@ctirix.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

> Just one comment below, which can also be taken care in a followup
> patch if you agree.
>=20
>> ---
>> v2: Change arch_iommu_hwdom_init() and vpci_make_msix_hole().
>>
>> --- a/xen/arch/x86/mm/p2m.c
>> +++ b/xen/arch/x86/mm/p2m.c
>> @@ -1473,12 +1473,9 @@ static int clear_mmio_p2m_entry(struct d
>>      return rc;
>>  }
>> =20
>> -#endif /* CONFIG_HVM */
>> -
>> -int set_identity_p2m_entry(struct domain *d, unsigned long gfn_l,
>> +int p2m_add_identity_entry(struct domain *d, unsigned long gfn_l,
>=20
> I guess switching the gfn_l parameter to be gfn_t gfn, and then
> defining:
>=20
> unsigned long gfn_l =3D gfn_x(gfn);
>=20
> Was too much churn?

Well, yes, I probably could have done that, but the series was (going
to be) big enough already, so I tried to stay away from such (for
consistency's sake I think I would then have needed to do the same
elsewhere as well).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:25:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:25:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301500.514539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncng4-0002sX-0b; Fri, 08 Apr 2022 12:25:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301500.514539; Fri, 08 Apr 2022 12:25:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncng3-0002sQ-Te; Fri, 08 Apr 2022 12:25:23 +0000
Received: by outflank-mailman (input) for mailman id 301500;
 Fri, 08 Apr 2022 12:25:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncng2-0002sK-8Y
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:25:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f4dcd3b8-b736-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 14:25:20 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2051.outbound.protection.outlook.com [104.47.2.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-p4ZjR1-YPfuizrTu6gUkmg-2; Fri, 08 Apr 2022 14:25:18 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by VI1PR04MB5120.eurprd04.prod.outlook.com (2603:10a6:803:62::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 12:25:14 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 12:25:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4dcd3b8-b736-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649420720;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=I+aBgUDsMue/9QuwXh0YTmAd1VbyoxChf6uGobDPAO8=;
	b=DGlTbvYK7MNR9w5mCrY6+lYYGmGzY3nhU0Pn2arhT9ImdePitQh0izv3sPWN8AbC8WvDrv
	fLRKeXRjyrg+SmeFG1jkeG8qFdDii9FfnT7s4O3DahGeVjmSWwDuXt5664WpnjqvujoszF
	yqGp8cAXSnaixOYAW1cDQgiKTH+1Ye4=
X-MC-Unique: p4ZjR1-YPfuizrTu6gUkmg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dIqpgUPYDF6UNqgE745Wl4O/aHqg4RFoD8eO6NHTnDii7HUtr1VY4mM/p6hEeuSV16QpYPwjcuyEfscONqiLRMcg+oISC0yYzmsWWC+5k+u4mrMOt0ibEY94LYocYkiffTMBBkfwN1q7lnZajXQlwNOH1y/SZUWsNI+Eun2PQs9kOuj729QLeOBqlHjeDWPr2awzLxcIGD9cq6T+cTqgMq0MuhDS45q1I5Zv71ls8uULwmvhI6ooPY21Ti27gh5CUp5cujjVWISfMsN8sIsPbUp8JQ0BmMi9J09ldPSEL0W6KdHSXRl/fFSLTAcxgs9RMaWbVjaJRtced58jV4Q0IQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I+aBgUDsMue/9QuwXh0YTmAd1VbyoxChf6uGobDPAO8=;
 b=oboNyuHI+4cHLD5MAvI2fDyvxDjJ2tZ9o++XKMjnn7pJjaPFz1scWTeQiKOKb10VfHhAvCF1v+OLiIaKlymCT/FLzeG21NrCm4LsrtIu9cIbctEPqNnjnN8AeVfvwjIaBu+Ph5HApZmsVy6mH6pvfj5Isihz/9ISg6/tBJ9euY+XCTuqyPpbnYAVOvBu+RiYTzwlCLWtAsOo9bGGdUjmVX9tXRmUc+bc5veyTSPHDQgJt3ssXhfjvXkQIG0mutSkU7h+KnJL9alFG+SGwNKX19hsTVfsMWBcAYi7G2BWNoD1CLihAn3bi3awuoMUYl5CQxOOF6EsLveCAggcLszLgQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3217803e-16d5-6e2a-bde7-ff9a1237dd39@suse.com>
Date: Fri, 8 Apr 2022 14:25:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
 <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0187.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::21) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4ee6404f-60cf-45d1-6176-08da195ad516
X-MS-TrafficTypeDiagnostic: VI1PR04MB5120:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB512056AC83C26DD7E736A447B3E99@VI1PR04MB5120.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GYmZdRhz9WM0t1rz4vR0BXGW89LXz488f3xmMwKpNwoxtVXD1YEmo/avB0/R5BQaYFIzS+B9EDBBqj0DHqDwhtOKZIbL71TDnPAaq2HFE6WY5tGKFKAvdXpU7Ljw06l1UubS8/AwOVu2ztwOP1JpbNJ6fLKy318u0w1sRtnGAVJYVW/Ml5obizRaIoTthnFBDkh5AVDqaGcsKMUevtu5LZF+Bs2eST6fGlHEhkUxER0sLhChvgYzQP8kjnihF7wgkc71fBpM2DvtbbjO2nJKtnDl7XDyxbLgkQKB5vr1Y37xXHP85BP1ECsCLLZ2eBB4xYTyhmoiefrz4Jus+9Iz9GAnpvUeOYuKO1yj2ploHPwYvfYkPix86ItrUkOmqaqDC9DGjTk8HXFLt/GsGmIMNI2EHj/QOJp2T2VIicAV8t0+6uC44af3n+Fnw7HOdTJylf1aAT1Pg2wrrOBcwhEclocItfPdbvGpoMfZKsaYb+/Ex8VJz0TLDRQm5yfAs2LvaTuSQFiwYD7YSrk1/sNO+X7F2aXrN5dWtRA6wJ/SdTgHAMc5zJG5Au1HtlOYginXMyFbfeldhD0H2rqE4dR3avPW1NByRMMSAw/r0Ox3CAYmf17W4GJL3gG94/LQLS2ES0pZaOPOO2CIzn4BlmqBmz/tTpOQIZkqlh7hC86Xk1Htm3R1VQj6TJ6ekxIzgrO++uzb12HFROlLTYZ4NUYtnFdDSn6HLLFtxxGG42RaMTc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6916009)(8936002)(83380400001)(31686004)(86362001)(8676002)(53546011)(66946007)(6506007)(66556008)(4326008)(186003)(26005)(6512007)(36756003)(316002)(2616005)(66476007)(508600001)(38100700002)(31696002)(5660300002)(6486002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UzcvZU4wajVoaG5CRStOQ21TUSt6S0dFOG40UnBYNTVJSGQrMEZDVGYvalZW?=
 =?utf-8?B?ekx4a2sxQlczbDdZOTUxZkIvRE8weHpGcDNxVDdNVDg3Ulg1anJvOWkvQ2NN?=
 =?utf-8?B?OFowVHEyUklSWXVaS2JKSUlwbXZxOTBPREJUZUpEbVFTZ3hJRklYellFUjRv?=
 =?utf-8?B?enVsaWludkhrTGxDdkJIbXlzRlNTNDFqTURxTE5DTlVzcGMyTWthY2prdXpX?=
 =?utf-8?B?b0twRkFzeGVES3JTVVo2U3hEYlZvbk1BS3lVQVBWWFRWa2Rsb01HYXNCczNy?=
 =?utf-8?B?QUlTM0pFbzA4TFF1cU5EMXYyM2trYnlXVmMzVnFmSzJVcUN5c2gwU0R3VG9T?=
 =?utf-8?B?MmFDd0F3SWVjelI1Qy9tQlR5Tkl0akZlYW5jM0YrRStUc1RrQWdYOHZZbytF?=
 =?utf-8?B?ekd0aUNraHFPTkFKSWVFWC9pSzcxODU2Y3IycHpZOUU0bW5GZUYvTmlVNk5Y?=
 =?utf-8?B?MnRoSmZBc29PTDFMNjE2VWo3cTlDcVFZSGVoUVZuViszKzNjdkdJZFEzcmR0?=
 =?utf-8?B?NEFmS1hzYkRqbWpkWlM5RU1lUm93MXExRkFJVlVsd3hnVURXWDhlUTNKUnVr?=
 =?utf-8?B?anNBcTZJOEE0anNUSitFcHBqWmdsWE11QStVZ1ZMS21zTGZIUTNXK2wxUlZo?=
 =?utf-8?B?aTI0NkF5VGJSYmR4UEQwL2xBdCtCZUlGKzkzYVZXT01CLysrVkZiNDgzcG9m?=
 =?utf-8?B?QjhqZjVxVDBTcGNyblFYSGxqSXYwS0hzT3dZUlc3dEpZRmtZeEpyTjl4cUJa?=
 =?utf-8?B?czNOMDVGYzRMdEpFdHM1eFRKWkJEdm1QOVQ4WDc2TCtCVjdmYmZJTVZNUU8z?=
 =?utf-8?B?OHIwaDBrTXpjZWZISVMvcUd2aW9wRWlUYkZ2UUFWb2RjRkZISkRDOFNacVBU?=
 =?utf-8?B?V2trdUNxN3ZnU3J5VFVPNUNBaTR2SUJPampjbEkvWUxWSVYySTdjUlhmWTM4?=
 =?utf-8?B?NUdxMit3NkVVTW9ZTEEwa28wZDRKQ3QrcXZiUjNjQm52UXkvM3JIcEtLekda?=
 =?utf-8?B?QlErckp5UnJSakN1d3QwZHh4ZTRLdXFtZm05MkNFTEVBMEFIWDlsTkZocDR0?=
 =?utf-8?B?bUdlMVI0QURhN0Vza3pDTjkvamZYaVBMMWZLTlRlb2NpQkt0T29vR29waGZK?=
 =?utf-8?B?VDVVM0JsVC9jdjdxcHR2cTFFdzFJcC9UV0JTaURpN0FtTW9IMkNHWTNnbm1N?=
 =?utf-8?B?RkVwSjZRb2NPU1dCRkZ2RDR6RGh5ekdRTzJFbTl2WjRhZW1walUwbHdoSFJI?=
 =?utf-8?B?KzNCVHg2Y1M3anlCM0srR2xWUzk0Z0NDZFJjajRSNlMwaHd5UjV0Z014UlhB?=
 =?utf-8?B?NlNjZGNoRnExVGkwUHkreWkyMHBQV0hyWFYrRm40aFowMmxkTGZKWkFUenRl?=
 =?utf-8?B?RVMwMFBYY0h5RnFoRFFBTU5Jb1d3bEJiZEQ3cWlwbGo5dysrSmVBRGNoNGha?=
 =?utf-8?B?V0R2SlQyUVloQ2ZxVFZyQnRhakszTEJWMnAyeVhwUkp6dXJ3Y09oS1lSdVda?=
 =?utf-8?B?Wi9EUWJJd0NrVDlWUkRkbUFHamFYTmorMXVMSm1KWVh5dEptRFNlYUE4U1I1?=
 =?utf-8?B?NU9xQTAzNlgrZU94S3Y4U3VhQjZtQ3Q1QmYyZEltSnFONXQ3SmhwUjlqRk9U?=
 =?utf-8?B?M2U5OVhvcERRL2VqSi9FbXBWTlQ2alhDTXN0YjIvOU4vVDNkTmppZ1NKMmtM?=
 =?utf-8?B?QW9OaGc2VHBBQ3hTTFRLTzhWVHY1M2w3NkFrZ1RrTklkcEd2QktCZWZBaVll?=
 =?utf-8?B?YmE2M3Ivbk1yc2hLTGhvTGwxc2c5dGRaVERSOHM0OE1STEZBM2RYaFY0MWJX?=
 =?utf-8?B?Qkpiek9LUk00d05uL3U4ZVJlS3hwM2JscElzOXVja3hrZmtzbWJBMmxtYjVa?=
 =?utf-8?B?cFFxYnJqM093eGFlUFdUZW14MUFVaTErcmJJTWI3TmMwWjRjaEhTNU1Md3VT?=
 =?utf-8?B?UHBkUVBIVFE0K2lTSnYxYWZsLzdjbGtvek1Cc1NZYlpGNjZpNGFFNGNmQlE2?=
 =?utf-8?B?Qkw5ekw0TkFqeHNXY0FKS2NSd01Yc1c0a243bEdwR1BpTTBlNnA0a3ZaakZr?=
 =?utf-8?B?MnFJWUF6NmFFVUMxNk5kTVR4VDlmTTk2c3Z5MWhMbnlKSVAxTzV4UTdBUHdi?=
 =?utf-8?B?QUJ3ZUVYSFdYTUNzU1RNQU00Y3hVbW1URGl6a0E1bjVMeDBWMk5qanZ2aWly?=
 =?utf-8?B?VENjeDYvZzd4MDcwbUZwYnZnZlFJdEJMOVlWdUlHK0d1UVY0NldoMVg1OUZD?=
 =?utf-8?B?SUVlUFNhOEhLY1lqRW0yNHZtbk1ScEFQU1hHRitEQmRCS3dBMndPNjl3S2o4?=
 =?utf-8?B?UDFxK3lGSS9wU0ozMjNCcEdtcFJDdE8vOER3bUUrdk80cWdBOG1Cdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ee6404f-60cf-45d1-6176-08da195ad516
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 12:25:14.0048
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9rQzEK5vL2x9fKJuSaH9Rxvwyj4Johvu5TyLjRxrYHRV6d0Pf3TXOHAwSfW2OMb527eb5WMGvflkm6OuSzF95g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5120

On 08.04.2022 13:02, Julien Grall wrote:
> On 08/04/2022 08:16, Jan Beulich wrote:
>> See the code comment. The higher the rate of vCPU-s migrating across
>> pCPU-s, the less useful this attempted optimization actually is. With
>> credit2 the migration rate looks to be unduly high even on mostly idle
>> systems, and hence on large systems lock contention here isn't very
>> difficult to observe.
> 
> "high" and "large" is quite vague. Do you have more details on where you 
> observed this issue and the improvement after this patch?

I have no data beyond the observation on the failed 4.12 osstest flights,
where I mentioned I would make such a patch and send out as RFC.

>> --- a/xen/common/event_channel.c
>> +++ b/xen/common/event_channel.c
>> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>>       unsigned int port;
>>       struct evtchn *chn;
>>   
>> +    /*
>> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
>> +     * vCPU-s they're to be delivered to run on. In order to limit lock
>> +     * contention, check for an empty list prior to acquiring the lock. In the
>> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
>> +     * until the vCPU is migrated (again) to another pCPU.
>> +     */
> 
> AFAIU, the downside is another pCPU (and therefore vCPU) will get 
> disturbed by the interrupt.

But only rarely, i.e. in case a race would actually have occurred.

> Maybe we should revive "evtchn: convert 
> domain event lock to an r/w one"?

Not sure - the patch was rejected for there, overall, being too few
cases where read_lock() would suffice.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:36:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:36:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301507.514554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnqs-0004fe-4l; Fri, 08 Apr 2022 12:36:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301507.514554; Fri, 08 Apr 2022 12:36:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnqs-0004fX-0G; Fri, 08 Apr 2022 12:36:34 +0000
Received: by outflank-mailman (input) for mailman id 301507;
 Fri, 08 Apr 2022 12:36:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tFry=US=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ncnqr-0004fR-0k
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:36:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 849954ba-b738-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 14:36:31 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-wMTVG6bXPiWsP8y8zb1izg-1; Fri, 08 Apr 2022 14:36:30 +0200
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 by DB3PR0402MB3771.eurprd04.prod.outlook.com (2603:10a6:8:6::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 12:36:28 +0000
Received: from AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd]) by AS8PR04MB8609.eurprd04.prod.outlook.com
 ([fe80::48e:2a59:a71b:d6dd%8]) with mapi id 15.20.5144.021; Fri, 8 Apr 2022
 12:36:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 849954ba-b738-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649421391;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZSemnoX7dyp6p0/0CQfLlAiRWmI9I36BHishgZUrHr8=;
	b=dOkDHWyaHsw7EMJhgbivFKnXCpIWvDyr+zTTmO2e7vAMLb0jlatX8PvQRYvmCCDFBEdKB5
	MefMLKIgD0lfVWqqTBsauFtmUEPZ144hFTkAbQK6HjB+glJtKvyRWfZiCnOs1XGfrwPXTp
	8fH+ZgPA5rEkkkRU1CSckAlhe0NLiPo=
X-MC-Unique: wMTVG6bXPiWsP8y8zb1izg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=InrDKFC3x/srg0A/dBHW2ivAxdI7FNHBdY1jrHT9zene/XYAPLsnC/PQb0v6eF026Gnyre6KlXaQftJ7R0VEI/NGgGhalE2U9aKxuf69lRAMjZ1KCGfJxmli+Ax4J5A0pHOOF4AIcg3f+/l7ISGIxjncOzrFaAHXB65d6Fdze70iY0sLTotLjOsD+E0V0OIHeCOaA25RMoSPB//JQ9Zyz708Ehvlo0RTWC9bv/pkls0az9GA8eeY8K5uRNPLNerUmS0Q7u62DzLr6GKgr05PinG3PuwkpQkrpj7tqd47lnfkZ0aa57Ra/GFiouB56ZsHtEey+3XOc7i8D+wqoPIY+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nJ9DjZ2YgBITR4o5KgspTRYuUPRJnVk9AglH4dqAqOY=;
 b=gpzUPy0UAFxbSMADXwD57r01lrAgKDR7xC0XPh374YaxtOpdO6mvjHiw4rk7QT7SgUQvmt5XDvtT3byhEfU72QE9+eSUP7k9BvdT8nZ2NQSkLPFEtSu5cT0MavD9owty6bmu123/zbvV/vzoV/5YY3BzdCDp8sXXb0UD9DQG3Xa0ohDFKtHaCInGESpt0roeXqfyrqsJtvSGAPITGhoMfX/CcLNYNoUZ33rao7yg6MTe8TnSmMaOcBblLTyT80CVJ4LRW1dM541PTTrdeH1Ed4lKHPU/whUgj253RXBIjdVYashvi6fdtbEB0E9HxsC1w/yELKV0IgCJT/sas0Cq+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
Date: Fri, 8 Apr 2022 14:36:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Content-Language: en-US
To: Dario Faggioli <dfaggioli@suse.com>
CC: "ohering@suse.de" <ohering@suse.de>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0102.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::19) To AS8PR04MB8609.eurprd04.prod.outlook.com
 (2603:10a6:20b:424::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b93ed4e-3ec9-4bb5-21b7-08da195c6714
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3771:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB3771C50DE1A3A3B375563732B3E99@DB3PR0402MB3771.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9yBtp8u6+QiYo+25FnvyZ/fthnVyWEBdpuYYyDBUK9eqRoUQosiPdxMCpecx/tbtn3QRYzxtZn5CHwO/8QITNmb82/SXtfg1Rd4HJhBfunOC7UB9/oxNHmH9qt2YNyTvn3h6HdzNS7MWJ+N58DbSVHIs70tbgW70g8o+Wwr8MHlJId/jSFDua/TddtgFL9UNVIxwXMoCZhERFzSx3msuDoWWP34CaBBirwtfKRzv2cKSOp+KhF3d57TyEj9ZHxb5FrpJJhXcCQucyozPHa7GUyUekFKEIYskEnp7cdI5lreetMZ1XkOeG710R3LTiuxRZbN7OmLAfhxFFUVB4nKeQOu9CMtz36rcmoJ7yM5Z3ovtg3J0BKMRwM57JIBVrecbQB/v/tpns+cnyVXPGqeOmx0R9AWCqDLcSx0RAInb6MohgNrDWxt/sQYDea8bTf+TgqbV4vEwoj6tu8/0b7tcjhakS4MPZsCtAUv5FkIzlfmvUaNGbo9Jcl3TUC5pZYt+B6caUxTFls3A8sKFtJ2pRJh406frMWPBDllGu9cCm4z7zzFypHZPbooKEG3CFxQ91x3FV6MSxZ6M9h//CH+JHjBaFwGzFHavK5c3eicqUZw8aw6BRLPGzQk2ClETq1uhcndhYHB132fNgc+t0WPpI089zHN2I/o/uWOTMBFsiqPVTRBCnMvtmSD+pRrLKFc4M4xxENUOlJF3c4CQzRcMQNuN7HXIgIcsjEQ4VH2pTAA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8609.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(6512007)(53546011)(8936002)(2906002)(6486002)(186003)(2616005)(6636002)(26005)(54906003)(37006003)(31686004)(83380400001)(36756003)(38100700002)(316002)(508600001)(66946007)(86362001)(31696002)(4326008)(66556008)(5660300002)(6862004)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bJVLT2M05n7RCKD3HkcVidLW4y55DZZUKoEXX39/ccKgac2E0/JWcYxJki0Z?=
 =?us-ascii?Q?6YbIgDJz5jPG1FfS/sTblwCOBWY+GZMYEBGu9V5BqUnNesVt/dxIDFEcIsvs?=
 =?us-ascii?Q?HB/kBK+aBR2neUVBh5hzPFcbcbWGfLlT9IdxGO+rQLLMP3hQkYHKJXzLG7Tz?=
 =?us-ascii?Q?1zRNeFSVIB0vwSJ9Ta0iyBgXWYXd/MX8MK68egDFmujwwbxmDoCBViY7B1PB?=
 =?us-ascii?Q?ZSmVHfj+xJ3AF7fWZO/XGfAc4NSbUifJUlWar/w2wgtc1mqord2BLPYc0TSx?=
 =?us-ascii?Q?YgMS+J0wW/AF4zI9f13MTmXjqfn4SGKEPUUxMwcCq+kiH8Vs+V7SUJ71xASM?=
 =?us-ascii?Q?KZdho4jqdhDm65GOo52zbN40RkTL0A+TGBnjNguiFpP86/2p+VEwsGZy4Nik?=
 =?us-ascii?Q?NMtDcGjH681Sq4GiYeMNOW5uCGmqvKTsJFQqvd7EoCGt30UCKL0V7OWVikxd?=
 =?us-ascii?Q?2aZGukadRkMXy2T/ZQ6VxupcuyqaG14SUNee7R076Q1x/hCi/XkNOYw/S932?=
 =?us-ascii?Q?wHYeL5RXYwtFLNOOGXNtAgLIbpNVfSeO+VbVQVLkLiuq2I70bVBI+k3mftzs?=
 =?us-ascii?Q?v5T2vO7D8wsMBYhtnnjuNqOW5Q1dZvnkhe4PBtNlHDOt5cWTyH8VXr7uGCX/?=
 =?us-ascii?Q?JCqdtQsgcZjGhlXlU1SJGndogH51R95HNub72bW84/U8AauNvUIqzCtke7mE?=
 =?us-ascii?Q?w+kraVlDrkev3DfbscdSJ5RbAiE9RP1WkhRqvtpO+9GJDXFm3hhPFflVGHi8?=
 =?us-ascii?Q?yDk14bJEbGcQ7AT4uejwKKkeZ3jC4RExPplMNsdlw0L0QwFNCXgOfThmb7ay?=
 =?us-ascii?Q?6Wtcth3zUaHiQTOqjCAJ0moc7pf2t14sc+mjsBQ2BoTBWQRJOuhoLMIRGXlO?=
 =?us-ascii?Q?lv6BPVXZe6N8F29OriCrw9y+rqaZ0GeXxP2Yhadb1gWaUdHypzUtueQ368gi?=
 =?us-ascii?Q?vU/PeJx+2TlvwjivYXYyrDl184Sc874TDPCRmWE36YYyVfEuDP/jNlEHQLoP?=
 =?us-ascii?Q?CoBny2ESvboJnnjqtEbASdLnxHJKAbhJ6z5Gy/yy25dYoz2jJrsXoreyqpgB?=
 =?us-ascii?Q?t0IYmrrW4ha8cnD6Ek/QssJ0kDK71SL9pT3GO4ZbSZZFKlAlsxOP3Jva0jMv?=
 =?us-ascii?Q?Hu4loRqGMqTuqJHU4eQzpDusGOvg6aRJfNnr61sDhI9i52BUfNoX/jw9euDZ?=
 =?us-ascii?Q?jYoGTpXZ98AdBJxLhqVXQTy7GRZa65RH5RR8FNJnZ6gNeeUCxVeo+Ctja/HS?=
 =?us-ascii?Q?xvDShu05kGcRer5h2EWEa39iz6fjfQz0K1fHKoMRrkei9Af8jliM2z73ffqs?=
 =?us-ascii?Q?wrXVsjR057CBHcFqsXgtBgCpn+xvNU0wTF/QeHg+CuBWeefFsQ65d7aOrrBa?=
 =?us-ascii?Q?O0xMjUYgF0sTDo7HIhsQLjdeyGhjF/Dj3Fg9PNNhVzRDXGGZ9Vf9rNaCxdkH?=
 =?us-ascii?Q?N2hh6E5EBbeerFkCpssIyQrwn8AlBU6Rpff3xBKiIHX0RET3xbt0ggqgJI6Q?=
 =?us-ascii?Q?A0HhGTjPukftDr9gzizUwhWzjftHe3aPKOcXXfrvENAE6Ns87SVy0Jw3C66J?=
 =?us-ascii?Q?VRl7/YFa1MR91wm+T4tMSV+P7kNz+iWUA7RMPY02UMWgWgrOhyW0mZE2KCGv?=
 =?us-ascii?Q?T8vroLL23kIOqbTC4PB2HQliSvxizaJSfL+9QlPOPcX2tfGHUkQzgXA9NZy9?=
 =?us-ascii?Q?m9TzlKKYABpaq0QApCx2iIWbhJtV0qLYG5pUfnMc6V+ZsHR6sgxYQeZZ81tt?=
 =?us-ascii?Q?3KuZpWdz2Q=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b93ed4e-3ec9-4bb5-21b7-08da195c6714
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8609.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 12:36:28.4342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dut2Sxv79CN9ucTTzGm8NY8wfjTefPh1tqABzWoRb1HbWmxGVRQ0G9yxBHtmZXUqYX08pP9rlHNW/zbz5WXK2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3771

On 08.04.2022 13:20, Dario Faggioli wrote:
> On Thu, 2022-04-07 at 15:27 +0200, Jan Beulich wrote:
>> ---
>> The Fixes: tag isn't very precise - it's rather the commit exposing
>> the
>> issue by default. I haven't been able to identify the actual commit
>> which did introduce the problem; it may well be that it has always
>> been
>> there since the introduction of credit2.
>>
>> Credit2 moving the vCPU-s off of their initially assigned ones right
>> away of course renders sched_select_initial_cpu()'s use of
>> cpu_cycle()
>> pretty useless.
>>
> Mmm... you mean that Credit2 is moving the vCPUs off they're assigned
> ones _right_now_, or that it will, with this patch?

Right now. On a 4-node (6 cores each) system with "dom0_nodes=3D0" I've
observed the 6 vCPU-s to reliably be put on CPUs 13, 14, etc. The
patch is actually undoing that questionable movement.

Since I have a large amount of other patches in place (none of which
I would assume to have such an effect) - Olaf has meanwhile confirmed
that the change helps for him as well.

> If you mean the former, I'm not sure it is. In fact, when
> sched_select_initial_cpu() is called for dom0, dom0's node affinity is
> just all nodes, isn't it? So, the we can pick any CPU in the cpupool,
> and we use cycle to try to spread the vCPUs kind of evenly.

The CPU mask used in the function is 0x3f for the example given above.
I did not check which of the constituent parts of the calculation have
this effect. But the result is that all CPUs will be put on CPU 0
first, as cpumask_cycle(..., 13) for a mask of 0x3f produces 0.

> If you mean after this patch, well, sure, but that's normal. Again,
> when we pick the initial CPU, we still don't know that the vCPUs have
> an affinity. Or, actually, we know that in sched_setup_dom0_vcpus(),
> but there's no direct way to tell it to sched_init_vcpu() (and hence
> sched_select_initial_cpu()).
>=20
> That's because, by default, affinity is just "all cpus", when we create
> the vCPUs, and we change that later, if they have one already (due to
> it being present in the config file, or in the dom0_nodes parameter).

But that's what I'm talking about a little further down, where you
reply that you don't think using the more narrow set would hide the
issue.

> Something that *maybe* we can try, since we're handling dom0 vCPUs
> specially anyway, is to directly set dom0's node affinity to the nodes
> of the CPUs we have in dom0_cpus, before calling vcpu_create() (in
> sched_setup_dom0_vcpus(), of course).
>=20
> This should make sched_select_initial_cpu() pick one of the "correct"
> CPUs in the first place. But I don't know if it's worth, neither if
> we'll still need this patch anyway (I have to check more thoroughly).

As per above - sched_select_initial_cpu() behaves as I would expect
it. It's credit2 which subsequently overrides that decision.

>>  But I guess that's still useful for other schedulers.
>> I wonder though whether sched_init_vcpu() shouldn't use the CPU map
>> calculated by sched_select_initial_cpu() for its call to
>> sched_set_affinity() in the non-pinned case, rather than setting
>> "all".
>>
> If we do that, and there's no affinity configured for the guest, or no
> "dom0_nodes=3D", when will we reset the affinity to all, which what it
> should be in such a case?

Why "reset"? When no restrictions are in place, afaict
sched_select_initial_cpu() will calculate a mask of "all".

> Also, if I'm right in my reasoning above, when we come from
> sched_setup_dom0_vcpus(), the mast calculated by
> sched_select_initial_cpu() is basically cpupool0's cpus_valid, so this
> wouldn't really change anything for the problem we're trying to solve
> here.
>=20
>> (I guess doing so might mask the issue at hand, but I think the
>> change
>> here would still be applicable at least from an abstract pov.)
>>
> I don't think it would mask it, but I do think that, yes, the change
> you're making would still be applicable.
>=20
> And, about it, One thing...
>=20
>> --- a/xen/common/sched/core.c
>> +++ b/xen/common/sched/core.c
>> @@ -3403,9 +3403,15 @@ void __init sched_setup_dom0_vcpus(struc
>> =C2=A0=C2=A0=C2=A0=C2=A0 {
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for_each_sched_unit ( d=
, unit )
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 spin=
lock_t *lock =3D unit_schedule_lock_irq(unit);
>> +
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed )
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 sched_set_affinity(unit, &dom0_cpus, NULL);
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 sched_set_affinity(unit, NULL, &dom0_cpus);
>> +
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sche=
d_unit_migrate_start(unit);
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unit=
_schedule_unlock_irq(lock, unit);
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sche=
d_unit_migrate_finish(unit);
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>> =C2=A0=C2=A0=C2=A0=C2=A0 }
>> =C2=A0
> ... The result of this (also considering the call to
> domain_update_node_affinity()) ends up looking very similar to what
> we'd get if, instead of calling sched_set_affinity(), we call
> vcpu_set_affinity().

Funny you should say this - this is what I had done first. It works,
but it is less efficient than the approach above. First and foremost
when there are multiple vCPU-s per unit.

> I'm therefore wondering if we should try to just do that... But I'm not
> sure, mostly because that would mean calling
> domain_update_node_affinity() for all dom0's vCPUs, which is clearly
> less efficient than just calling it once at the end.

Indeed, that's the other reason why I did change to the approach
above.

> So I'm thinking that we can indeed do it like this, and add a comment.

A comment to what effect?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:41:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:41:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301513.514565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnvR-0006OR-NY; Fri, 08 Apr 2022 12:41:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301513.514565; Fri, 08 Apr 2022 12:41:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncnvR-0006OK-KO; Fri, 08 Apr 2022 12:41:17 +0000
Received: by outflank-mailman (input) for mailman id 301513;
 Fri, 08 Apr 2022 12:41:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=chE6=US=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1ncnvQ-0006OE-Sb
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:41:16 +0000
Received: from MTA-15-3.privateemail.com (mta-15-3.privateemail.com
 [198.54.122.111]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2d326540-b739-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 14:41:15 +0200 (CEST)
Received: from mta-15.privateemail.com (localhost [127.0.0.1])
 by mta-15.privateemail.com (Postfix) with ESMTP id A93E718000B4
 for <xen-devel@lists.xenproject.org>; Fri,  8 Apr 2022 08:41:13 -0400 (EDT)
Received: from mail-oi1-f174.google.com (unknown [10.20.151.143])
 by mta-15.privateemail.com (Postfix) with ESMTPA id 19ED61800084
 for <xen-devel@lists.xenproject.org>; Fri,  8 Apr 2022 08:41:13 -0400 (EDT)
Received: by mail-oi1-f174.google.com with SMTP id 12so8645886oix.12
 for <xen-devel@lists.xenproject.org>; Fri, 08 Apr 2022 05:41:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d326540-b739-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1649421673;
	bh=DP+NHR9//4G9Rjhj0kYzbqhTewtuNRi3eNslDYha7QY=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=xiproq7O/uHS2b4CpvXuicBqwz8dB5X0sJKHdGgXlDb95wLBnpupuGTJsm+Ax2QQY
	 appz2Q63GgD4SgMUEPLPgzM0O0XomZ7g/RGbmDYftChDeWOFvDsgmKk6VpHQEmePIW
	 Y+Fh8K1rA2XzVYcNB58AX0KL/UMlRkHKYzJdBuNdA91nVENGEbo2YFsJJEuqQ9jMRM
	 DwMTbJsIZsIZGX7elMC2VCbcJXpv4PAbyuAK/TLuSbqftca2cYXb7cCoUqIftmfxeA
	 ssb8Nb1qvR4hq7aRnXa5/LMpmY6G/GDDdsIgx6y8JfL6/qrPzyzcSxzGLS3ZBP7Xo1
	 U58WuIwQpgc+Q==
X-Gm-Message-State: AOAM530tKO9eu2DUmt61D3T4db0ThLFx8d9auhryGAVbB6WcT8EOrx/j
	I6S8jvKFryvkPMi9BRvGYGq+kdaBkw/ru8MV3fU=
X-Google-Smtp-Source: ABdhPJyRxBCgWaklEkPejPBHE/jhwYVvbebiqnAMotnGnANaTbgoaX36uCAbbeQ3cl95PK3+vjGFjkDE8wNLuB08EyQ=
X-Received: by 2002:aca:d12:0:b0:2ee:f684:bd4b with SMTP id
 18-20020aca0d12000000b002eef684bd4bmr7877583oin.128.1649421672442; Fri, 08
 Apr 2022 05:41:12 -0700 (PDT)
MIME-Version: 1.0
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
 <BN9PR11MB52762BD5E8F62281A5C326F88CE99@BN9PR11MB5276.namprd11.prod.outlook.com>
In-Reply-To: <BN9PR11MB52762BD5E8F62281A5C326F88CE99@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Fri, 8 Apr 2022 08:40:36 -0400
X-Gmail-Original-Message-ID: <CABfawhkC_56t57fFwJXC0-kevfTyp_8UcZ+47W4QVWF64+AoDQ@mail.gmail.com>
Message-ID: <CABfawhkC_56t57fFwJXC0-kevfTyp_8UcZ+47W4QVWF64+AoDQ@mail.gmail.com>
Subject: Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "Lengyel, Tamas" <tamas.lengyel@intel.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Nakajima, Jun" <jun.nakajima@intel.com>, 
	"Beulich, Jan" <JBeulich@suse.com>, "Cooper, Andrew" <andrew.cooper3@citrix.com>, 
	=?UTF-8?Q?Pau_Monn=C3=A9=2C_Roger?= <roger.pau@citrix.com>, 
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Thu, Apr 7, 2022 at 11:49 PM Tian, Kevin <kevin.tian@intel.com> wrote:
>
> > From: Lengyel, Tamas <tamas.lengyel@intel.com>
> > Sent: Friday, March 25, 2022 9:33 PM
> >
> > During VM forking and resetting a failed vmentry has been observed due
> > to the guest non-register state going out-of-sync with the guest register
> > state. For example, a VM fork reset right after a STI instruction can trigger
> > the failed entry. This is due to the guest non-register state not being saved
> > from the parent VM, thus the reset operation only copies the register state.
> >
> > Fix this by adding a new pair of hvm functions to get/set the guest
> > non-register state so that the overall vCPU state remains in sync.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> > ---
> > v5: Switch to internal-only hvm funcs instead of adding to hvm_hw_cpu
> > ---
> >  xen/arch/x86/hvm/vmx/vmx.c         | 32 ++++++++++++++++++++++++
> >  xen/arch/x86/include/asm/hvm/hvm.h | 40
> > ++++++++++++++++++++++++++++++
> >  xen/arch/x86/mm/mem_sharing.c      | 11 +++++++-
> >  3 files changed, 82 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> > index c075370f64..2685da16c8 100644
> > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > @@ -1334,6 +1334,36 @@ static void cf_check vmx_set_interrupt_shadow(
> >      __vmwrite(GUEST_INTERRUPTIBILITY_INFO, intr_shadow);
> >  }
> >
> > +static void cf_check vmx_get_nonreg_state(struct vcpu *v,
> > +    struct hvm_vcpu_nonreg_state *nrs)
> > +{
> > +    vmx_vmcs_enter(v);
> > +
> > +    __vmread(GUEST_ACTIVITY_STATE, &nrs->vmx.activity_state);
> > +    __vmread(GUEST_INTERRUPTIBILITY_INFO, &nrs-
> > >vmx.interruptibility_info);
> > +    __vmread(GUEST_PENDING_DBG_EXCEPTIONS, &nrs->vmx.pending_dbg);
> > +
> > +    if ( cpu_has_vmx_virtual_intr_delivery )
> > +        __vmread(GUEST_INTR_STATUS, &nrs->vmx.interrupt_status);
>
> There lacks of explanation somewhere how those states are selected.
> Your discussion with Andrew leaves me the impression that Andrew sees
> more issues in general save/restore path while you only want to deal with
> the requirements for your own usage. But according to v1 your usage only
> cares about the interruptiblity info. This implies that v5 is kind of in a state
> between your original intention and what Andrew actually wants...

These fields are all guest non-register states so they are not
completely arbitrary. True that at v1 only the interruptibility info
was observed to be causing issues when it goes out-of-sync after a
reset. Since then pending_dbg was also noted to be needing a reset
under some circumstances. So at this point I see no reason to wait to
include the other values in the reset. If you have an insight into why
those fields don't need to be kept in sync with the rest of the vCPU
state, please share.

As for the save/restore path concerns I don't really have a clear
insight into what is needed to fix it. Furthermore the proposed sanity
checking on these values that would be legitimately needed for
save/restore are just pure overhead for our use-case. So the two paths
are better left separate in any case.

Tamas


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:46:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:46:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301518.514576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nco0C-00072X-9n; Fri, 08 Apr 2022 12:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301518.514576; Fri, 08 Apr 2022 12:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nco0C-00072Q-6H; Fri, 08 Apr 2022 12:46:12 +0000
Received: by outflank-mailman (input) for mailman id 301518;
 Fri, 08 Apr 2022 12:46:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nco0B-00072G-3K; Fri, 08 Apr 2022 12:46:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nco0B-00029k-0A; Fri, 08 Apr 2022 12:46:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nco0A-0003cb-H7; Fri, 08 Apr 2022 12:46:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nco0A-00037K-Gh; Fri, 08 Apr 2022 12:46:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IlCFUWkqchiDZllcvHP+idJ8UB45i7uMiVMfRa3K5Mk=; b=d1zD2lYKm2PPiDI8Ctxz2crG8c
	eIjSj4n8pIDco2eUBoJOsofBTZ9jQQixd6nS5q/Vmsbk/NLRkqZiN+qG1/tSu7CU0VrSktwcODvXL
	aPcl/SODiONi6Gd18401qm+R7p56JestoMXuSSU+B2pfMevqa+k+kgCKzxSuDiON4Ckw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169231-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169231: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9120b5737f517fe9d2a3936c38d3a2211630323b
X-Osstest-Versions-That:
    xen=d3f61beea4255e2d86ae82303384c57a3262435e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 12:46:10 +0000

flight 169231 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169231/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9120b5737f517fe9d2a3936c38d3a2211630323b
baseline version:
 xen                  d3f61beea4255e2d86ae82303384c57a3262435e

Last test of basis   169222  2022-04-07 17:00:54 Z    0 days
Testing same since   169231  2022-04-08 09:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bjoern Doebel <doebel@amazon.de>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d3f61beea4..9120b5737f  9120b5737f517fe9d2a3936c38d3a2211630323b -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 12:57:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 12:57:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301539.514635 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncoAe-0000tz-Tw; Fri, 08 Apr 2022 12:57:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301539.514635; Fri, 08 Apr 2022 12:57:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncoAe-0000tq-QK; Fri, 08 Apr 2022 12:57:00 +0000
Received: by outflank-mailman (input) for mailman id 301539;
 Fri, 08 Apr 2022 12:56:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uR8K=US=oracle.com=konrad.wilk@srs-se1.protection.inumbo.net>)
 id 1ncoAd-0000tR-4p
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 12:56:59 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5ebb7b24-b73b-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 14:56:57 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 238CS1um004892; 
 Fri, 8 Apr 2022 12:56:53 GMT
Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta02.appoci.oracle.com [147.154.18.20])
 by mx0b-00069f02.pphosted.com with ESMTP id 3f6d9371vq-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 08 Apr 2022 12:56:53 +0000
Received: from pps.filterd
 (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 238BamYp029143; Fri, 8 Apr 2022 12:56:52 GMT
Received: from nam02-bn1-obe.outbound.protection.outlook.com
 (mail-bn1nam07lp2041.outbound.protection.outlook.com [104.47.51.41])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3f98057s6t-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 08 Apr 2022 12:56:52 +0000
Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27)
 by PH0PR10MB4791.namprd10.prod.outlook.com (2603:10b6:510:3a::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 12:56:51 +0000
Received: from BYAPR10MB2999.namprd10.prod.outlook.com
 ([fe80::9c00:2a13:f115:537a]) by BYAPR10MB2999.namprd10.prod.outlook.com
 ([fe80::9c00:2a13:f115:537a%7]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022
 12:56:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ebb7b24-b73b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : content-type :
 content-transfer-encoding : in-reply-to : mime-version; s=corp-2021-07-09;
 bh=2tMULLAsbjJqyFUalDHVaZPz1XTQyIQQkcroQqZjE+U=;
 b=uj7wd1ti0yKJ9xTpOCbDHkk6tyTGLd12mSIMYflb8egYhDD8PRkE9xCKbga+pXcxZVCP
 LBk/WqDu59JOpd0NirPf/s8KZuubh6/Zf7GGzPCmTnSEGuMwhuDO1uEHccfFyz0mQef+
 sa5UsZzdmSA9rsTqqsmKwOD4J38CVhotWblxjWjxILc4XF0ZssWX0xMLfs++62DN7HFd
 x4T9ievqMiJVrTcMxZBBOVPWjVyLXdXPOZnTwfzzQZU3FieqUK/4L8BdeBRSNsKl30LC
 FNgbv/BefYzWrgZQQnDwpWu1XE1yp1o5tvEvONAhJ0Um/6HIBgSxwxfBIO8fHaaoBfoC 2A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fas4RhK+Lz+tEqQuOV5cd93JeEv2vw6Zq4IJCsdi1diu7uvc+jcdNmeBzqhPMQDdMWOkGBcH3Cy6PmDMXfPVKiGUljW1rXueQjaFUFdwppVgJeV+CSTdUE7oKLlcIFBTkXKX27Aq9walKqJfo2wZ5V/gVTTyqqjjX/tceLLfrJgpu0DOwbgqw8q14TVxRUeKXbA9fUFBmBQPMoqF1N48mLGvk4I7ugUgsgQLwoN3bceCxtl5qwDv+x/5dX4PA/GPz1Ihxta13/vgoON8S/Kc1iT33oc76PXY+Uzi6kjYjtPUTkQnn/kMszMzDHF39qtHPah7hBUHUfpQ/fry7zcOuQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QhU0EhWRD5EtPJRO9+dZowPxPurWnxgiJx8pnKnN5cI=;
 b=V8xV216k8pFigZOPtxXXYIOgQ4OjER4FRvxiRBlL0uttepeXnJu0T0XeHxAJckbD8VEH9QUMYw8OlHGP04aEMgYgq/286EEWaZuG1MhAMzKgm8jtccdrEytKzkA1LU/VCRvHFyNDiLoBgBXn1xJdq4bwJbGhkEbY9cLhpFjiXJOG1ccgzkhdXc8tEB4oS3ccgSEv4ZxoUxJ19HV5PAvISpSzUSseMb2raX3rAwKB5Yx/g/qsOItiG88RB1VTRdJTivNW50PPCjvHOTT6VAgWWHga+bd8pQnqfyM03VYlXsy5RBu6DIZRX5OtRzYOrCb2N4V4cYzce4rBNzI5taGC3A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QhU0EhWRD5EtPJRO9+dZowPxPurWnxgiJx8pnKnN5cI=;
 b=Y7a+R4uyUTKypk2+QAHQvY5h2JRwOvHrB3TXP/aizIMIYq2ViAqTs3+BYd9mT8We2neI+oo5vXG0ZO6nP8tf/VKvKha1kCU2djSSnwSlrSR2/pd4LC71ngz+pWkY54GHpw++yVzS1MFYpcmZmvXd5dPMMYc4xjYT9zMq6TeW3Go=
Date: Fri, 8 Apr 2022 08:56:44 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
        Jan Beulich <jbeulich@suse.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
        Bjoern Doebel <doebel@amazon.de>
Subject: Re: [PATCH v3] livepatch: account for patch offset when applying NOP
 patch
Message-ID: <YlAxDEYL/ZOVd2Oh@char.us.oracle.com>
References: <8db632ef-9d9c-d17a-54fd-49912d88d599@suse.com>
 <YkVko/vqhfAfS5Jb@Air-de-Roger>
 <ef884c3c-26b4-1bde-9344-aa9be30c1cbc@suse.com>
 <PH0PR03MB638290EA5503FE0FED792C44F0E69@PH0PR03MB6382.namprd03.prod.outlook.com>
 <Yk/wKp3XyAAPbqgc@Air-de-Roger>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Yk/wKp3XyAAPbqgc@Air-de-Roger>
X-ClientProxiedBy: DM6PR06CA0020.namprd06.prod.outlook.com
 (2603:10b6:5:120::33) To BYAPR10MB2999.namprd10.prod.outlook.com
 (2603:10b6:a03:85::27)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f153a00f-ac4e-4c23-c942-08da195f3fab
X-MS-TrafficTypeDiagnostic: PH0PR10MB4791:EE_
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB4791D3E0661BFF0949CE319989E99@PH0PR10MB4791.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	qyaukqDaWoCmWUUFDhfluI8ODMAz0CMgNEEG3C8MV4aDlmZlj542+k/w9hxPl+J9k8lLGifdBEjrBpI6BaehzZncVobeXlE0dM8U2DzNv88Jc0oX7tK2/bKED43d3RcFavMzNQXIclC2RBkMe6HE42o5A0HZ7yPrkOAOuYDDBA9zrgnR40wyc7pQ9J9ErOKwzqsYzO73UuEVWqP5bnrZM4veC7epEWrORsVBMWPGH58VlNgcnu3EPPsUII6UHdPSTG5J1x+o56I2JsGtgXqiJ6W96iH+zYfiViX9BbETYHKVuowX03ftXFju9ONm8C6UEb/p0z0GkSQRFTUUI541MRCIXJUKTXicSze25lZKQuKEwQBWhtwkcYtZK9UVUUtiiD4leNlEl666y12cRu3MDTU5Cm/5/Vc2Zovd4smYvLbIMLvrVQ65mrMdsZz1dATuzYBGSt2b5y5PJis68AdPJqfoEEhT9dmqQaGsQiP97+VCIUvc5cMUayjR+5uwCxnm8rmdHFt361ljdL31hpxdlxj2+BpLsCtBNxlGfP4AJJmWu1mQOTyVwL1q31Mx+h04f2tS16wGZDiuOJ2bVdU5qryS5gmwu4y31Fj0zQhAObhgaVieoBo/K9A8q+WZWOx85bnbYajuMZ6tvDNJnw+q5+6xT9np6ocs9iKLnqXwQcmAWjqCJnysk9BkcS25TZ6rZnFIaSiVHG54s+W118e9xw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(316002)(38350700002)(38100700002)(54906003)(4326008)(66946007)(66476007)(66556008)(53546011)(86362001)(83380400001)(6506007)(6512007)(6916009)(508600001)(186003)(15650500001)(6486002)(2906002)(6666004)(8936002)(26005)(5660300002)(52116002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?iso-8859-1?Q?Px405TECkJytZul9XqTL/sZm3xRehN2ABhUXmYTMZu66y0AENcmF44AN3b?=
 =?iso-8859-1?Q?XmXaCTdWEd4NiGTyLr6eV7tVaPHOfNUQyq5kAwzkRtAC+6Cb51FHoQuIpa?=
 =?iso-8859-1?Q?T/Y9xud+296kc2bX2elepeiLJSVwJW1m/2VIV8Xg0W+60j9jOVjFwvvhQw?=
 =?iso-8859-1?Q?p0azSh6RKa2VV8y42r46BVaxwWS2bMNexBtBznpD5g5ZYBg+mADJfz7fYg?=
 =?iso-8859-1?Q?+npFMBj2AysLH9E9spIOUzfv++t+lh2eg+folqWs7ESBBH/Klxl7spDvL9?=
 =?iso-8859-1?Q?AX9TgQj7/bpFZNJV/0u6PCQSSYo7nAfxKgwK1Z2akeE3t6hBYts+VoahQ7?=
 =?iso-8859-1?Q?ACRPHF6QdO09phxqfWaOOgqQpfIl4QYGX6jNxIaXaBDp5JL2pqoZbQG0Q5?=
 =?iso-8859-1?Q?b2q98q8eAbCoLtxurfCrfGzayJO42SyBJ5cpk/agv5mnS8a5GrJ2YZFGU0?=
 =?iso-8859-1?Q?qfslEBfXnlxCr16uUHthzuODZIBhrK1qS/foT95D09Ca4oNyOguHEaFXMZ?=
 =?iso-8859-1?Q?sgVC8JHuOaK06HNthzBo+i6vRpfn8bFBkBi0GVu2ufzIPJLEI0htJ+H0/g?=
 =?iso-8859-1?Q?oV85p16PTSoi3Oq9nrjZReLuyC+B5rg3NN2j3S+4kZgJdYlbdioxNy7r11?=
 =?iso-8859-1?Q?l2ZHQO4UD1fTdZMF+Zb7sje5NNwqe2uJmY+r5G8xqT39yvFC3YMTwx+K8H?=
 =?iso-8859-1?Q?B4KjrQBv3Q84WOP4iEM98RAjl1je12w/zQCH8pKjWahVXp2BJP/NsY2821?=
 =?iso-8859-1?Q?aiSQbAac45WaZt21jNUWvBvKLlQwQscpBLK47ARYuXjS+AxAHJour76OLN?=
 =?iso-8859-1?Q?8PIwNwccOEOPhFGxasde29T0WAa5Qz1dJjzuLZYFEoF9eQsCSyWtWrQWCe?=
 =?iso-8859-1?Q?QG4c/pBY35+jBq8MnHkazlI42565bddLos4dO52usd0gkFWguCOZaAXbMO?=
 =?iso-8859-1?Q?TL4HOmjzE2qkKx1HgOOW7KD55ygPuokP0c7NqeNLdYNcT3b05nHau1+JIB?=
 =?iso-8859-1?Q?MRJpkOwkMmQb8TAD0zeJbxailcsMYzhid9PJPTmkGTj7oDsgTVpE68iDgE?=
 =?iso-8859-1?Q?SfXY/75/gnr53KvudcbVP9kZxWyc1OYAx6pCN3hQoqLIfHMzdB1Jh8meKr?=
 =?iso-8859-1?Q?yWr0SmlixgYXy0uXAqXsWWikz4VxfD1pDx37asVEISBf5oR4buO4EFUyzu?=
 =?iso-8859-1?Q?HzkODsCYwkSMEhm+7MXmz0baXgIM7BIESKUSppxln45J7ANp2jioTGRB4r?=
 =?iso-8859-1?Q?z+1cRlP/fuOWTAkQnlkgvay5Mb8gF2JamKTTRDHYA1n89+6ncinGmWiEfr?=
 =?iso-8859-1?Q?HSLnz7dHXcJU364+7zijyYQ0LY35jXXQu0+Fb4KrDPSMtQejHhZS/J5TyD?=
 =?iso-8859-1?Q?DiTiXQZfTzK77yDG+gGYxd7jc5BGJ8xJWujlETp2PNSpK9MBxamXgTFurQ?=
 =?iso-8859-1?Q?e1/r2fHsv05KttHKFuhwyNzbV5gIBe6fUD/kDNpcxhG94ovx/+QQf7mTSY?=
 =?iso-8859-1?Q?A9AKa6fYa+zLQ0He9Em8WQLLINsUqOu2OATpoWbxGaPgACY/gXHmNpkwrL?=
 =?iso-8859-1?Q?8mSSTfBIB8ygrkEDevqkuFSCXieUcGtAScBcRCCNFTgHcSyR7+u+v9lKzp?=
 =?iso-8859-1?Q?HYxixXRDGGo+J3uYZHHfDFOOVnApsGIy5NYD2kBcetpb8OtMG/J95v4qhn?=
 =?iso-8859-1?Q?CxrkP8xzM1HQbmN2rufsdgAaEiXJfFdClcHAV9Mhkl9WitPlGOvB0POY12?=
 =?iso-8859-1?Q?d95K7kmc5siM4ct2F8lbcpxTDD80q7dheY2Co5Nkpiy6x0ipVCmbcAus6k?=
 =?iso-8859-1?Q?s4STDXDc/+Vl2egu3Az3dkuZhGpplDk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f153a00f-ac4e-4c23-c942-08da195f3fab
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 12:56:50.9344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s1Zunrr2MEYry/4oq9smV5GHGBNxDpLy+S3bmbm3C2QNOJohETF2FyYxF7yvHa0Q95xpLoifoALbx3H0lbUSWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4791
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.858
 definitions=2022-04-08_04:2022-04-08,2022-04-08 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204080058
X-Proofpoint-ORIG-GUID: lXNOn_KpkuhvteZQtTxFKE-vtC5aejng
X-Proofpoint-GUID: lXNOn_KpkuhvteZQtTxFKE-vtC5aejng

On Fri, Apr 08, 2022 at 10:19:54AM +0200, Roger Pau Monn� wrote:
> On Thu, Apr 07, 2022 at 03:44:16PM +0000, Ross Lagerwall wrote:
> > > From: Jan Beulich <jbeulich@suse.com>
> > > Sent: Thursday, March 31, 2022 9:42 AM
> > > To: Roger Pau Monne <roger.pau@citrix.com>
> > > Cc: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>; Ross Lagerwall <ross.lagerwall@citrix.com>; Konrad Wilk <konrad.wilk@oracle.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>; Bjoern Doebel <doebel@amazon.de>
> > > Subject: Re: [PATCH v3] livepatch: account for patch offset when applying NOP patch 
> > >  
> > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
> > > 
> > > On 31.03.2022 10:21, Roger Pau Monn� wrote:
> > > > On Thu, Mar 31, 2022 at 08:49:46AM +0200, Jan Beulich wrote:
> > > >> While not triggered by the trivial xen_nop in-tree patch on
> > > >> staging/master, that patch exposes a problem on the stable trees, where
> > > >> all functions have ENDBR inserted. When NOP-ing out a range, we need to
> > > >> account for this. Handle this right in livepatch_insn_len().
> > > >>
> > > >> This requires livepatch_insn_len() to be called _after_ ->patch_offset
> > > >> was set.
> > > >>
> > > >> Fixes: 6974c75180f1 ("xen/x86: Livepatch: support patching CET-enhanced functions")
> > > >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > > > 
> > > > Reviewed-by: Roger Pau Monn� <roger.pau@citrix.com>
> > > 
> > > Thanks.
> > > 
> > > As a note to the livepatch maintainers: I'm going to put this in
> > > without further waiting for suitable acks. Just in case I'll put
> > > it on the 4.16 branch only for starters, to see that it actually
> > > helps there (it's unusual to put something on the stable
> > > branches before it having passed the push gate to master).
> > 
> > Thanks (was on PTO and away from email).
> > 
> > > 
> > > > Albeit I don't think I understand how the in-place patching is done. I
> > > > would expect the !func->new_addr branch of the if in
> > > > arch_livepatch_apply to fill the insn buffer with the in-place
> > > > replacement instructions, but I only see the buffer getting filled
> > > > with nops. I'm likely missing something (not that this patch changes
> > > > any of this).
> > > 
> > > Well, as per the v2 thread: There's no in-place patching except
> > > to NOP out certain insns.
> > 
> > Correct. FWIW I'm not really aware of a valid use case for this
> > 
> > > 
> > > > I'm also having trouble figuring out how we assert that the len value
> > > > (which is derived from new_size if !new_addr) is not greater than
> > > > LIVEPATCH_OPAQUE_SIZE, which is the limit of the insn buffer. Maybe
> > > > that's already checked elsewhere.
> > > 
> > > That's what my 3rd post-commit-message remark was (partly) about.
> > 
> > old_size specifies the length of the existing function to be patched.
> > 
> > If new_addr is zero (NOP case), then new_size specifies the number of
> > bytes to overwrite with NOP. That's why new_size is used as the memcpy
> > length (minus patch offset).
> 
> Sorry, maybe a naive question, but why not use old_size directly to
> overwrite with NOPs?
> 
> Is this because you could generate a patch that just removed code from
> a function and then you would ideally just overwrite with NOPs the
> section to be removed while leaving the rest of the function as-is (so
> no jump added)?
> 
> I wonder whether we exercise this functionality at all, as I would
> imagine is quite hard to come with such payload?

The original idea behind this was to do any type of changes - not just
nop but other instructions too. Aka inline assembler changes. It is not
something livepatch-build supports but you can handcraft those if you
are in a pinch.

And the test-cases just do nop as that was the easiest one to create.
> 
> Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 13:23:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 13:23:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301566.514730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncoaG-0005tT-1d; Fri, 08 Apr 2022 13:23:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301566.514730; Fri, 08 Apr 2022 13:23:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncoaF-0005tM-UT; Fri, 08 Apr 2022 13:23:27 +0000
Received: by outflank-mailman (input) for mailman id 301566;
 Fri, 08 Apr 2022 13:23:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncoaE-0005sw-Ny; Fri, 08 Apr 2022 13:23:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncoaE-0002r1-Jt; Fri, 08 Apr 2022 13:23:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncoaE-0005B7-6B; Fri, 08 Apr 2022 13:23:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncoaE-0007uD-3P; Fri, 08 Apr 2022 13:23:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kxTb1gua213KuYZTMkw6jE5iVbbfFD3oFUrzDmUGLJc=; b=agURqQOKmu/xjExb/9IuRJcPpI
	HPoYhtUVklxatcNyw3j+bvAhBQ5vQupR8OrdkXe8NJjZwE+idrfDUyZcPt7UkVZscbHfBPYhmxsuH
	kYMiT3rKUdvUnSgyioUSmj+jpmVpXj5ktiA5IWBiDJiCQtBUGPsQ54eaMtuyCXY5OZeA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169235-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169235: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 13:23:26 +0000

flight 169235 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169235/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   39 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  292 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 13:28:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 13:28:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301578.514763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncofI-0007SV-EH; Fri, 08 Apr 2022 13:28:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301578.514763; Fri, 08 Apr 2022 13:28:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncofI-0007SM-Ax; Fri, 08 Apr 2022 13:28:40 +0000
Received: by outflank-mailman (input) for mailman id 301578;
 Fri, 08 Apr 2022 13:28:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SA5n=US=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ncofH-0007Q5-QF
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 13:28:39 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on060d.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::60d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb634302-b73f-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 15:28:36 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by AM7PR04MB6949.eurprd04.prod.outlook.com (2603:10a6:20b:102::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 13:28:35 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5144.022; Fri, 8 Apr 2022
 13:28:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb634302-b73f-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IgV6tA+oAktRtC0SX5nswa3Ede+qtHd29x2XLTuzyg9SqXkrhVkQ89L9IzMCK2k7m3RzPulMQn3oLiPDQDSagYt6aTo2UMue3ettaM4QMpBfn+rLNn7rn0BK93vp77xyKCbd6H68BgiBT032AGC9vuUzXOrA/qI8kfhp5S+ezMrOyYC1+ZE2rb2WxsAtWQk2wHnhw2rRf8k6wdm0IGAfMgaISp5jxLk1vxd5TiMMtmaejy/IGm9R80VIv7MDJ0HNGAfM77WTGUutcQ6oOI10UoD7TBiRUkudRZ0pX80Y1ct7zJZ22XVsK+12qpHMfGDvcQQYHKi9G04sHFq5gQ7Uyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TWdVjcMnWozl05+E5IE0z2YpFwdCyGDLKaNm3kllK3o=;
 b=b0oeQrA8HWaYJsezh5fv6z6tLGxZBNsqFciYSXa6BJwtpBB0CdElBOBrvlbptQNA8PbR+1CNtaC7lVEGtuZuAdwbao4Ud6DWBZfmKhHQ5Uu8Ko4x771cTsAgMx6WNvdP4ELBA5zwPXlbYzbioT/Nl0Z3C9xQaufBRyElH0Oz4pcIik95uFRl3hzdnFomoxQwXGVa9Nr0moTo3Crg9EsD8xi/7NbUoIZNpaopuonz3eCHflXhiCcrs+dRK6mL3ST6ZPYN73eSET4Mp/qhCnmIJ4eglHtrem9rliLBNxV9jy1a0h6lZI/VdZJZz/sd673jrB0zYcz2M7bSBBSvkQybqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TWdVjcMnWozl05+E5IE0z2YpFwdCyGDLKaNm3kllK3o=;
 b=XEsmLXPo1OfGZ51nWzjqAEvRlsoTMjRSwB/+gTrLJodkxtVMLb7Pj/PjtYT5m+M9ZwPIKib/qYjke5WWgyA/PmKNmvqL/J7FROgUeOztCCYUVjBGfQKw6UlB3d4b6mdmpSKQGW5Ny5s8vRKq9riuW0I/yqTsQ/fVMSy4TPdE56I=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V4 2/2] xen/arm: Add i.MX lpuart early printk support
Date: Fri,  8 Apr 2022 22:09:32 +0800
Message-Id: <20220408140932.17968-3-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220408140932.17968-1-peng.fan@oss.nxp.com>
References: <20220408140932.17968-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR06CA0001.apcprd06.prod.outlook.com
 (2603:1096:4:186::21) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 276d5a56-f2ed-4806-745e-08da1963ae6f
X-MS-TrafficTypeDiagnostic: AM7PR04MB6949:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB69493D503F7FAAFD6DFED29FC9E99@AM7PR04MB6949.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CuRccfkGa8G7dSKUcJIB8EaN0pQaI0Mf1TOie2vdOu2OGU4sUl7A5YQIxs9heLjNOlYVQmLM1YQ1GifWJiD4ZHTZM5pW8COZOIhBy9lkT9uVEk93plHmktGhYDa0J1I8icItQBWClus3BeKNNEcuAX0I0z/1sGOaHD3E0gI00COiCV7WVF1Osr6CXjd1CQVsFvynzGB4qWb26HY4lbkNFcKMNACiQjqePEa0yKjkTixXRApGtd3f2Q4GP7NDkoDAkDlhbG3lLcJOlxxgp7fbIehSAiw0Ak8/tVvYajlxr/HanXGtNCbqc13Parkxox7RnTFUMo/9H5INDQqbcfbTh8I47vLnG6fFI3uMXkMacIuDIFcXhNa1gfZ3dHoJD3WK1w7QascMO7MgZnOlA9XB2ABT1EyPgsxBge1gipzBY9r/y25BfGn3xQ5HNXr1I7iI+DE0R7SNkbwyS0uA2bO8/q8fvxXdwecbTSe3B9e0N8Se4pecTrDG2rl+YcLEGqY5ab2nxst71LjFSwn2NMecGwO2AAgKSSAdxV2PIwC6j1ZPjG+U6AwYbiIwVFnuw0BPICrVgpbC7i6C8Xk5NZ2o/M+vDHvs4ppv+Qrw7h3oxzvxXw1q+rp3X+BlmLd0KVdK602Q6Py7wGuQOv0KOtdtWcy/rmwtOe9zIqE9hPA/LhHPa8dRCZremis2v2/08Oqnr3lF0Vlpdn4U+EW2spa5F+qP1GUnJTgg/i+DgNRB4ps=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(6512007)(8676002)(52116002)(6666004)(6506007)(4326008)(508600001)(2906002)(5660300002)(86362001)(7416002)(38100700002)(2616005)(186003)(26005)(38350700002)(1076003)(66556008)(316002)(66946007)(66476007)(8936002)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9mQntZZUvJi9RKLkVNwEtI+rvB+CcydTnBNwFneojYNHNejyhA7oRIhVQwQB?=
 =?us-ascii?Q?Tv9Ze81jbiG979pLZZ0WQWzXS1H3rFBpLggiX9Lzx3IqEVHrwQMX2yLZCAB6?=
 =?us-ascii?Q?euxHDfOwF2UjY+yVdh2KV68WQ+Hxgm99Ij2YsFuuP+h2A7UnHhSQKPBfgy/x?=
 =?us-ascii?Q?P6+5eFZIupJzmZS3puqbF0YzgeLjt3SfRd0AsmzczNB0oHXVBuoFPzGXOlje?=
 =?us-ascii?Q?0mwLxVIjrs0LDvqD9zJ8pIqkqWXyO1oCqeMNSxI1k37b8H4BByx1isaeLSbX?=
 =?us-ascii?Q?8+V8PIvX8s2qYMyO/1mK1Hj59vOWhAeA9+22k2AwXvZPpFjFncy5vwgNgn/x?=
 =?us-ascii?Q?6ckNVLWfEWKsmofqB6XZGOhPN2eYI7mJZvTIRtzu0grCmYfy7KM9f3rEJ990?=
 =?us-ascii?Q?/yozS4f2rJe+0r+l3nmGxMkY/JOPgpg+ZMjRJHyr1GC2kTpHep7htKl1hKRt?=
 =?us-ascii?Q?z0zH+hGl8NrEg50YkdVvyWPAaWL0WSSs7gFZSTBWXHKbQm7oqWJkxckC3K7l?=
 =?us-ascii?Q?CvzSbgH8GUxKZMFeffcDT2yklus6DqmUM61KH7d5Ng/SqAlCnEjwCmlY6mMP?=
 =?us-ascii?Q?FTe6a2VtsNLHMcasmgRQOi1iat2U1AQNPaqTBdbRSnK/PudWAhbQFrKdoxZU?=
 =?us-ascii?Q?lqYWyIQIThN+t7Cd9JPP/gIj0O8wdWYSEgUcYqqA736Wo1SX/wPZ/g3XJXI3?=
 =?us-ascii?Q?Rz2rKfBW/zzI6RosML+oLR+625xHwotDgGKuaPTBvW/dBX3wuBHE4uNixl2s?=
 =?us-ascii?Q?ExFlXN4F4Tlb1m0kOpp2BORIPKON92qlxAezF15CaGiDPmCoO9e+DRm5DlXI?=
 =?us-ascii?Q?VOuE+t1Ew+E4eoSL/AuHvcifxhq3Q1eqZxU+w7hKOgVNgt2BppjJ2R3uX6mb?=
 =?us-ascii?Q?ghipcUawyLMod1BwGZimoeEDp+SriRdqr2bVkcwwSR7rf1QhdT3B5kDTURrY?=
 =?us-ascii?Q?MatvnLIintftgfzc+G2V65Nn8SCpK5KnaWiRTWnAw00wR4qdvSFaVFo8d73g?=
 =?us-ascii?Q?JviVOzO7DSVVB2GC4tntgGvXpWGl2IIR1kPLwnPS3BTpQ76jAuPXyrr7hscd?=
 =?us-ascii?Q?XWLwFfvoUqzOiKI65ehxc24kVmoPehZWzos+DD857a+VnZ98GajXSTJuIiys?=
 =?us-ascii?Q?lzriCZTu5EDOnVp1Zi5JWUKH3SjWmEzFpDLhxEMdzlUEa99BLr6KTJD+Q4eS?=
 =?us-ascii?Q?ph7c0Lz9LhK3WVsjaU64XIfsEk35pTSLDBRqCwkIOPhwRmtABnxWwfX808ux?=
 =?us-ascii?Q?WpbiCzmunLlFwpiq0Ugr2IWkB9lV7qUF9ytWOsIS9WOg+qJ848/d4r3HKPDa?=
 =?us-ascii?Q?vyZOeYr/Jkkgme7UYyyMDHNuRSUfD8qMWkuFLzLX9sYk0xK/VkuO9e2/cBvR?=
 =?us-ascii?Q?cTaoH3DtsWMqPSPNzYmqa2neI/2Mb0F+sjD3wC3E+4Lvl11EkjMPY220uFTJ?=
 =?us-ascii?Q?wPA03MYaZbM0ZxKBS5kVZN0Ndf3RTfJo7Aw7ShrWpbk4aC6akMHDMaxd77/K?=
 =?us-ascii?Q?XD9jBL0efF6tiTdOAulIOKeXeSTH7V4qZsbaUe028rGMB1zDoZRrH3zP1DRS?=
 =?us-ascii?Q?aquwCcUcdhYny2Cgare7HsXPIW80fvX1r2LEmmxhXMaXnuKNUQRCZaxGnVSn?=
 =?us-ascii?Q?Hqp5xeT6BL5PBAXz01QhbzU/9xZIjWZoczMpPhQxDNSiQJiIe1mwkXbwDgWI?=
 =?us-ascii?Q?5WK88yO7HR5e3KnBWbzLiG5HC1ebZZ7s/hkFJoeLQKBIUkETwYTUQMCgdZ7C?=
 =?us-ascii?Q?/HylQmV+Aw=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 276d5a56-f2ed-4806-745e-08da1963ae6f
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 13:28:35.0342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f9SRG9vMeGFDDYZHVSn9mS1/pKGA7C91mgHlxoHea8w5V0zFaDEL3TiSWgFUVZyId1IUa1i5SGofEGyjazWaUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6949

From: Peng Fan <peng.fan@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/Kconfig.debug              | 14 +++++++
 xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 +++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index 35ccd13273..842d768280 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -58,6 +58,16 @@ choice
 			This option is preferred over the platform specific
 			options; the platform specific options are deprecated
 			and will soon be removed.
+	config EARLY_UART_CHOICE_IMX_LPUART
+		select EARLY_UART_IMX_LPUART
+		depends on ARM_64
+		bool "Early printk via i.MX LPUART"
+		help
+			Say Y here if you wish the early printk to direct their
+			output to a i.MX LPUART. You can use this option to
+			provide the parameters for the i.MX LPUART rather than
+			selecting one of the platform specific options below if
+			you know the parameters for the port.
 	config EARLY_UART_CHOICE_MESON
 		select EARLY_UART_MESON
 		depends on ARM_64
@@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
 config EARLY_UART_EXYNOS4210
 	select EARLY_PRINTK
 	bool
+config EARLY_UART_IMX_LPUART
+	select EARLY_PRINTK
+	bool
 config EARLY_UART_MESON
 	select EARLY_PRINTK
 	bool
@@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
 	default "debug-8250.inc" if EARLY_UART_8250
 	default "debug-cadence.inc" if EARLY_UART_CADENCE
 	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
+	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
 	default "debug-meson.inc" if EARLY_UART_MESON
 	default "debug-mvebu.inc" if EARLY_UART_MVEBU
 	default "debug-pl011.inc" if EARLY_UART_PL011
diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
new file mode 100644
index 0000000000..f68252da86
--- /dev/null
+++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
@@ -0,0 +1,52 @@
+/*
+ * xen/arch/arm/arm64/debug-imx-lpuart.inc
+ *
+ * i.MX8QM specific debug code
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <asm/imx-lpuart.h>
+
+.macro early_uart_init wb wc wd
+/* Already initialized in bootloader */
+.endm
+
+/*
+ * Wait LPUART to be ready to transmit
+ * rb: register which contains the UART base address
+ * rc: scratch register
+ */
+.macro early_uart_ready xb, c
+1:
+        ldr   w\c, [\xb, #UARTSTAT]   /* <- Flag register */
+        tst   w\c, #UARTSTAT_TDRE     /* Check FIFO EMPTY bit */
+        beq   1b                      /* Wait for the UART to be ready */
+.endm
+
+/*
+ * LPUART transmit character
+ * rb: register which contains the UART base address
+ * rt: register which contains the character to transmit
+ */
+.macro early_uart_transmit xb, wt
+        str   \wt, [\xb, #UARTDATA]  /* -> Data Register */
+.endm
+
+/*
+ * Local variables:
+ * mode: ASM
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 13:28:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 13:28:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301577.514752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncofE-00078V-1Y; Fri, 08 Apr 2022 13:28:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301577.514752; Fri, 08 Apr 2022 13:28:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncofD-00078O-U7; Fri, 08 Apr 2022 13:28:35 +0000
Received: by outflank-mailman (input) for mailman id 301577;
 Fri, 08 Apr 2022 13:28:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SA5n=US=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ncofC-0006sY-3o
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 13:28:34 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on061f.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::61f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c932c11c-b73f-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 15:28:33 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by AM7PR04MB6949.eurprd04.prod.outlook.com (2603:10a6:20b:102::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 13:28:30 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5144.022; Fri, 8 Apr 2022
 13:28:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c932c11c-b73f-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zy8UeqeAC9/uYnq6glHa9R/ma7FmPgWYEkKJMaV7RSYepY4JGK+to+tdQ3wuE1amks+EXKGpqeogRFdpY8bacgGss8iYHbusQemL9YMlPuFQraM3u1xcYVUR7s2b7VZjKlfivngyi4lMm2nr433TK5qwK5A8rOhnMBxS76JeXviLtY+O1Eprevfi7cu5FhGm9cb7fxR6GHrI1raDCEenakesOViJE9Wg5Wm0zmtuxXEMWtoTaQXukk9Wt3BYE0apkqgSywyGsIKLtc8Npiiy/6gzq/sRxUqVPktW2sx3XTnj+RAA8QxiqfJP2JBOi5x+OPStJPZdB1g18DXSuGftog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YOybCCL3522NRlFfet5yBrEZKjVeEkrG0sQQ70PYMaA=;
 b=OIwPHEoQI3a1NbGHCE3JUm2h63y3OEJxp6xeZqDBFtP4wlnvrMOMFX+MlUrFiY92OkzgJIAfUT/Knh7aY2/gTPdiwBquV+yrAXjybqiX2O8LSCQ8ub67eODud98RO7r/BOiQ0UB30cenY7fBwEgqntjVc0+NkJRQko3zR8YbuBBYF+tpCgLfkdEyGdqcPQlwNUYiHts6cvyB1VGNCmJDQm8x4kYALZTBRqzSMuXMaJoM2ZDltjheYMAFU7W+A/2tjpFYZCepZILTx4BWuxAAgu5pwmDUjHIjl4ymBw6+4h1DlUw+P0E10acmuflB34qk7urUASRKDZCr4cBAy6cutw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YOybCCL3522NRlFfet5yBrEZKjVeEkrG0sQQ70PYMaA=;
 b=ejbS5znFhYIBvtFO5nfXMvLSRLzk/PedoRYbNCmGlgD2PyucbuAvqQnQrt5ndYQb/d4f3jU3k9Z7MoV6gkAorylKKxvsQgXe4+1tipsy0CTp+QUZ1VBTmTxbmupuJSSp3+OtsQQxwl3H9546x5hbGpE2PMXY1GzykC8OnSG4QEk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH V4 1/2] xen/arm: Add i.MX lpuart driver
Date: Fri,  8 Apr 2022 22:09:31 +0800
Message-Id: <20220408140932.17968-2-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220408140932.17968-1-peng.fan@oss.nxp.com>
References: <20220408140932.17968-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR06CA0001.apcprd06.prod.outlook.com
 (2603:1096:4:186::21) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bb64134a-cf59-4f5e-06f8-08da1963ac08
X-MS-TrafficTypeDiagnostic: AM7PR04MB6949:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB6949BD7F9C19B657804FC003C9E99@AM7PR04MB6949.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1Dif43dAkCA4rmSGoQqNx53uUV5a+8aor/2AG50Kw5ubrEWf7iSHewTDAzHvJ4kMPqPOhNy4PpUAp0wdRp8CNzXuMOI6ck/dMZkaZ/wT8xZzztPyAQ8yHuWUjzLrfehzNRZQ7gY/5lAyqwmEeATk+9XVwEKnW5huuJ/ZqSA81EzPXjsONd118pfigrOuCNm2WuJx/9fR9ay7wyzxjY8C9n5tatsM41+U/3QFmnNKJ9oFtqfthbvwlyT/kEMzn4sXUOQibumybbIjL3NkN7IoBfqGGcIIGIj9JNZ0HHo2xx9ONSRHJOGcMqUYbIbuTpsEG7artgKw44RaEMW8fIzGjcR3Jl9mBm6kovv3PgAtsVEgZxKeqDpQd4C5JtNWCJxSKRcFMFjfeq+BJ/psnbin0lV1aOMkIBcTdTwviiM+VH7mKMQMER+it7SzwyFCIhLbtVUKCC9oi+7vTWKE7ECAeOQsB05+CXqYhlvioO7SslIle0lbVs6M5QjO2rpZgg+pBaNVR4Uidra8qthIQqBjy+UCI0h3lu5sv2gsTLrhSgnHESndECVisvHVKl/l4h4y1SmsSEs20PCNvniEmrNFN/vUVQuT84VRe3MUL+3oPNN4gV4fC53e9/YhNGPk1u/VUu2wzU36xF4ra5YRu3BLRz2xoup9KcpwAU+5aITg63GKjY4PxpDoDqH3qXwBeim0lcjvHdoaYIrJ7lUv22woVpD7KC+bcXJVogSaDm7CPWOnw086efyn7zVMDj+TtP3dVFmB2WIhhJX93gDHC845Y7uCbRmpaP1dOZDrCpDv5eIm76vqf0LPQiSOYnev4HxK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(6512007)(8676002)(52116002)(6506007)(4326008)(508600001)(2906002)(83380400001)(966005)(54906003)(5660300002)(86362001)(7416002)(38100700002)(2616005)(186003)(26005)(38350700002)(1076003)(66556008)(316002)(66946007)(66476007)(8936002)(30864003)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?88Uf+WOMJacQ+jAEg4oDJayvhPlJeTUZGphFu1dnQvs7aXM0m+rqpVJxqOvN?=
 =?us-ascii?Q?ODB5KooEMBO7mUO+FHP/Tyxtw2HDiaVWAMAGSHssccI0uKcIpMSkx6Zafkq3?=
 =?us-ascii?Q?mhpQdI3fyi2N3pFc4GtYZnQ5D8sKVj6pmyDsvMphJXIRlnG6ueAg+hTzfqbG?=
 =?us-ascii?Q?+dlzPjj8YraPT/aHBSlvKpSUXnYGn74Vegp9bFvcFH/aVOEjOwOmUPu0QJ4c?=
 =?us-ascii?Q?7t49FFMpQgROy4oYxZze99+0tcfm7Gxg+pzSyef4JQ/4O2213Kx5ZL4A/9zn?=
 =?us-ascii?Q?xYmiFGdPUI4SQGHeis9vILTR4H4FJP90p0B6puRBGZW1OlPByJEE7yDqR3Ws?=
 =?us-ascii?Q?LEJV0tu//EAkuHZ6nlrhRi7PFdKzxEOpflaFI8e62Mrk98KuGDDJ4S1wGpTL?=
 =?us-ascii?Q?mE/sRoxBE5ZPDlHSvvoujiXcvanQxwbQKR2nt+KdMbixW/SXMjO9qkTkZmkz?=
 =?us-ascii?Q?yfTykisgu7OKGdwGxdPUrAARFe9Dw0ILaGamIGAWrpcu/RI4eNX+50Lt3h1F?=
 =?us-ascii?Q?iHRrDtw4F6Mfj3qOqhJt08/rFKczIPv7SFfGI/TbP5wcRjRzG6evd6zyXnre?=
 =?us-ascii?Q?FE5hgUp0cPvfpVybLp3y63kLxmtNlvHZp1J3OXoV3JNfGF4VbxbUA7JBRQIW?=
 =?us-ascii?Q?pOQnkmUOAkt+ZYJbnA4yh6plu/isSzuH4YASysIdGAVPM1ojPKa3tde4+eAA?=
 =?us-ascii?Q?4a4MQb8HDpdItW4cD5k1mDbnohBh2NwN1aXn6jQCHEAtfhn3kdUkxIAH9Fea?=
 =?us-ascii?Q?cqvm5xMQVoSYcUa1TO+v0+9qqeVXWkXrghk9ub4t73b3kIyoYEjemwCPygmQ?=
 =?us-ascii?Q?m09DIXP0dBzSB/jh7fB/pykEd/zT54YB6QmX7GcHn308O6TNL8ZnbRrBCg6A?=
 =?us-ascii?Q?PUKWGKHLhv6j7H4ckvy18/DlFr+CXscHDKdVBfvY8qW07jGz//QHHFWHBJ31?=
 =?us-ascii?Q?Xp0eDdoPiZZ3GdHMwP6AGcI5vTnNVndEp92BJcvyC24/i0ZFDrMxn4iJ+eok?=
 =?us-ascii?Q?0ZsW6X/VGijdnVeScAs2iyXMnoZ29gsZkyctdwe8A6e4VbZsDWTG8fKXRIQ4?=
 =?us-ascii?Q?YD9FWc2IjxwD+XtKjSiJ5rPDhFeEDUVpYh7bB+XqUhLp1noEqP6/tQxNuRkr?=
 =?us-ascii?Q?EK6fFyiObhiVPBKrt98qFOi1FEiPc8iIXTxXnpixJMI9mwudRa2CIlxBBG8m?=
 =?us-ascii?Q?qI6ubJ6noGZX5prrIOyQk1nue3Fn3wgmCYgwuMcMNhCGehI9U/mN1YbZsA7U?=
 =?us-ascii?Q?JSMQRRcVNdcW/IHQrzteqCbdHyhaJ2rGaCZJ8feGrrtmeRtxJuOmqfcNOBqi?=
 =?us-ascii?Q?1UJ6OKqu5rxnrZLyXqeg0R9NR33uqycA7XpRN/0fW4mKtDzD+rosWrzxkwQa?=
 =?us-ascii?Q?NgSc+xtM7xvu9TuSfytx8hhSMTH5rlHTybauzZVg5kzULy3pfG/3zTC8c9UA?=
 =?us-ascii?Q?CESDeLI7+cJmuZJEwcjOmi+uZIwGya+yRUmUsZtmYAnkpgiT7FpsM7skc5Sv?=
 =?us-ascii?Q?aW4g4e4fc8UO/A00ibPwCRNHxx2plIobOEAAPrybR2FZc0ZNGV4XR+2LY4Xs?=
 =?us-ascii?Q?zqt8J88zbN4GOBl5c0uOyotwTE7DBzlyTKQeLpDMj5bi4NbcrK9fY1PPcF/L?=
 =?us-ascii?Q?F5Ek0efprKeErleWKCoPtI+g32Bk+82ImiPB96DsRrnGjspSwl69U06RziX1?=
 =?us-ascii?Q?Zd2zA3zHUcTRmfnvAuLiAT5QN0ApkRVZAAChecg5WCZ4VdjlWGXUE2GoxHe0?=
 =?us-ascii?Q?aDvRXQTpEQ=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb64134a-cf59-4f5e-06f8-08da1963ac08
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 13:28:30.7978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fkqgfz2OF5Q5Wl84rqL47bR1xdJaFlbX8CVdo/HShVrv7yxQ1AUlHnhaLPtk8E1x0sSaVTlnt+lBKWOFmnzF5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6949

From: Peng Fan <peng.fan@nxp.com>

The i.MX LPUART Documentation:
https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
Chatper 13.6 Low Power Universal Asynchronous Receiver/
Transmitter (LPUART)

Tested-by: Henry Wang <Henry.Wang@arm.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
 xen/drivers/char/Kconfig              |   7 +
 xen/drivers/char/Makefile             |   1 +
 xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
 4 files changed, 348 insertions(+)
 create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
 create mode 100644 xen/drivers/char/imx-lpuart.c

diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
new file mode 100644
index 0000000000..26e2cf0249
--- /dev/null
+++ b/xen/arch/arm/include/asm/imx-lpuart.h
@@ -0,0 +1,64 @@
+/*
+ * xen/arch/arm/include/asm/imx-lpuart.h
+ *
+ * Common constant definition between early printk and the LPUART driver
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ASM_ARM_IMX_LPUART_H__
+#define __ASM_ARM_IMX_LPUART_H__
+
+/* 32-bit register definition */
+#define UARTBAUD          (0x10)
+#define UARTSTAT          (0x14)
+#define UARTCTRL          (0x18)
+#define UARTDATA          (0x1C)
+#define UARTMATCH         (0x20)
+#define UARTMODIR         (0x24)
+#define UARTFIFO          (0x28)
+#define UARTWATER         (0x2c)
+
+#define UARTSTAT_TDRE     BIT(23, UL)
+#define UARTSTAT_TC       BIT(22, UL)
+#define UARTSTAT_RDRF     BIT(21, UL)
+#define UARTSTAT_OR       BIT(19, UL)
+
+#define UARTBAUD_OSR_SHIFT (24)
+#define UARTBAUD_OSR_MASK (0x1f)
+#define UARTBAUD_SBR_MASK (0x1fff)
+#define UARTBAUD_BOTHEDGE (0x00020000)
+#define UARTBAUD_TDMAE    (0x00800000)
+#define UARTBAUD_RDMAE    (0x00200000)
+
+#define UARTCTRL_TIE      BIT(23, UL)
+#define UARTCTRL_TCIE     BIT(22, UL)
+#define UARTCTRL_RIE      BIT(21, UL)
+#define UARTCTRL_ILIE     BIT(20, UL)
+#define UARTCTRL_TE       BIT(19, UL)
+#define UARTCTRL_RE       BIT(18, UL)
+#define UARTCTRL_M        BIT(4, UL)
+
+#define UARTWATER_RXCNT_OFF     24
+
+#endif /* __ASM_ARM_IMX_LPUART_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index 2ff5b288e2..e5f7b1d8eb 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -13,6 +13,13 @@ config HAS_CADENCE_UART
 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
 	  based board, say Y.
 
+config HAS_IMX_LPUART
+	bool "i.MX LPUART driver"
+	default y
+	depends on ARM_64
+	help
+	  This selects the i.MX LPUART. If you have i.MX8QM based board, say Y.
+
 config HAS_MVEBU
 	bool "Marvell MVEBU UART driver"
 	default y
diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
index 7c646d771c..14e67cf072 100644
--- a/xen/drivers/char/Makefile
+++ b/xen/drivers/char/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o
 obj-$(CONFIG_HAS_OMAP) += omap-uart.o
 obj-$(CONFIG_HAS_SCIF) += scif-uart.o
 obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o
+obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o
 obj-$(CONFIG_ARM) += arm-uart.o
 obj-y += serial.o
 obj-$(CONFIG_XEN_GUEST) += xen_pv_console.o
diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
new file mode 100644
index 0000000000..df44f91e5d
--- /dev/null
+++ b/xen/drivers/char/imx-lpuart.c
@@ -0,0 +1,276 @@
+/*
+ * xen/drivers/char/imx-lpuart.c
+ *
+ * Driver for i.MX LPUART.
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/errno.h>
+#include <xen/init.h>
+#include <xen/irq.h>
+#include <xen/mm.h>
+#include <xen/serial.h>
+#include <asm/device.h>
+#include <asm/imx-lpuart.h>
+#include <asm/io.h>
+
+#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
+#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
+
+static struct imx_lpuart {
+    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
+    uint32_t irq;
+    char __iomem *regs;
+    struct irqaction irqaction;
+    struct vuart_info vuart;
+} imx8_com;
+
+static void imx_lpuart_interrupt(int irq, void *data,
+                                 struct cpu_user_regs *regs)
+{
+    struct serial_port *port = data;
+    struct imx_lpuart *uart = port->uart;
+    uint32_t sts, rxcnt;
+
+    sts = imx_lpuart_read(uart, UARTSTAT);
+    rxcnt = imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
+
+    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
+	    serial_rx_interrupt(port, regs);
+
+    if ( sts & UARTSTAT_TDRE )
+	    serial_tx_interrupt(port, regs);
+
+    imx_lpuart_write(uart, UARTSTAT, sts);
+}
+
+static void __init imx_lpuart_init_preirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t ctrl, old_ctrl, bd;
+
+    old_ctrl = imx_lpuart_read(uart, UARTCTRL);
+    ctrl = (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
+    bd = imx_lpuart_read(uart, UARTBAUD);
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
+	    cpu_relax();
+
+    /* Disable transmit and receive */
+    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL_RE));
+
+    /* Reuse firmware baudrate settings, only disable DMA here */
+    bd &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+
+    imx_lpuart_write(uart, UARTMODIR, 0);
+    imx_lpuart_write(uart, UARTBAUD, bd);
+    imx_lpuart_write(uart, UARTCTRL, ctrl);
+}
+
+static void __init imx_lpuart_init_postirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    uart->irqaction.handler = imx_lpuart_interrupt;
+    uart->irqaction.name = "imx_lpuart";
+    uart->irqaction.dev_id = port;
+
+    if ( setup_irq(uart->irq, 0, &uart->irqaction) != 0 )
+    {
+        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
+                uart->irq);
+        return;
+    }
+
+    /* Enable interrupts */
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp |= (UARTCTRL_RIE | UARTCTRL_TIE);
+    temp |= UARTCTRL_ILIE;
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static void imx_lpuart_suspend(struct serial_port *port)
+{
+    BUG();
+}
+
+static void imx_lpuart_resume(struct serial_port *port)
+{
+    BUG();
+}
+
+static int imx_lpuart_tx_ready(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
+}
+
+static void imx_lpuart_putc(struct serial_port *port, char c)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
+        cpu_relax();
+
+    imx_lpuart_write(uart, UARTDATA, c);
+}
+
+static int imx_lpuart_getc(struct serial_port *port, char *pc)
+{
+    struct imx_lpuart *uart = port->uart;
+    int ch;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
+	    return 0;
+
+    ch = imx_lpuart_read(uart, UARTDATA);
+    *pc = ch & 0xff;
+
+    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
+        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
+
+    return 1;
+}
+
+static int __init imx_lpuart_irq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return ((uart->irq > 0) ? uart->irq : -1);
+}
+
+static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return &uart->vuart;
+}
+
+static void imx_lpuart_start_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTSTAT);
+    /* Wait until empty */
+    while ( !(temp & UARTSTAT_TDRE) )
+	    cpu_relax();
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
+}
+
+static void imx_lpuart_stop_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp &= ~(UARTCTRL_TIE | UARTCTRL_TCIE);
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static struct uart_driver __read_mostly imx_lpuart_driver = {
+    .init_preirq = imx_lpuart_init_preirq,
+    .init_postirq = imx_lpuart_init_postirq,
+    .endboot = NULL,
+    .suspend = imx_lpuart_suspend,
+    .resume = imx_lpuart_resume,
+    .tx_ready = imx_lpuart_tx_ready,
+    .putc = imx_lpuart_putc,
+    .getc = imx_lpuart_getc,
+    .irq = imx_lpuart_irq,
+    .start_tx = imx_lpuart_start_tx,
+    .stop_tx = imx_lpuart_stop_tx,
+    .vuart_info = imx_lpuart_vuart_info,
+};
+
+static int __init imx_lpuart_init(struct dt_device_node *dev,
+                                  const void *data)
+{
+    const char *config = data;
+    struct imx_lpuart *uart;
+    int res;
+    u64 addr, size;
+
+    if ( strcmp(config, "") )
+        printk("WARNING: UART configuration is not supported\n");
+
+    uart = &imx8_com;
+
+    uart->baud = 115200;
+    uart->data_bits = 8;
+    uart->parity = 0;
+    uart->stop_bits = 1;
+
+    res = dt_device_get_address(dev, 0, &addr, &size);
+    if ( res )
+    {
+        printk("imx8-lpuart: Unable to retrieve the base"
+               " address of the UART\n");
+        return res;
+    }
+
+    res = platform_get_irq(dev, 0);
+    if ( res < 0 )
+    {
+        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
+        return -EINVAL;
+    }
+    uart->irq = res;
+
+    uart->regs = ioremap_nocache(addr, size);
+    if ( !uart->regs )
+    {
+        printk("imx8-lpuart: Unable to map the UART memory\n");
+        return -ENOMEM;
+    }
+
+    uart->vuart.base_addr = addr;
+    uart->vuart.size = size;
+    uart->vuart.data_off = UARTDATA;
+    /* tmp from uboot */
+    uart->vuart.status_off = UARTSTAT;
+    uart->vuart.status = UARTSTAT_TDRE;
+
+    /* Register with generic serial driver */
+    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
+
+    dt_device_set_used_by(dev, DOMID_XEN);
+
+    return 0;
+}
+
+static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
+{
+    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
+    { /* sentinel */ },
+};
+
+DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
+    .dt_match = imx_lpuart_dt_compat,
+    .init = imx_lpuart_init,
+DT_DEVICE_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 13:28:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 13:28:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301576.514741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncofA-0006sl-Og; Fri, 08 Apr 2022 13:28:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301576.514741; Fri, 08 Apr 2022 13:28:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncofA-0006se-Lk; Fri, 08 Apr 2022 13:28:32 +0000
Received: by outflank-mailman (input) for mailman id 301576;
 Fri, 08 Apr 2022 13:28:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SA5n=US=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ncof9-0006sY-3E
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 13:28:31 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on062d.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::62d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c6db23df-b73f-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 15:28:29 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by AM7PR04MB6949.eurprd04.prod.outlook.com (2603:10a6:20b:102::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 13:28:26 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5144.022; Fri, 8 Apr 2022
 13:28:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6db23df-b73f-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ey3UXQUWn+D59xWuPlAthpB9zY+zMTYoDhXvDiY4q8tIIarN8aowGy5DqAz2EUjhovxYiUhRM+xKTga6YpudDuTBSdtCoYfU8K7Rj7IlOkzNQKQZjqmxlxU/zgdF87oCAcFwhvqlsU8zJKPDEvVEzBPxLlEkM2d74axGi4JQ02AMK+c0lbQhIUvbthfLPWx8HcCwuMMidJF0S003teAadWOdtxQ0yhl7b38Ay7RmCvdPFe8akqbw9dGN4nL+LOojLkayg42scDhOHOaSzs8hdQou1YQ0lCXJKuALcW1sw8hEXAlPBf8n7hqzk2MR5kHMso+M97BDLeAd+Px19NrcGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Wj4aoEwaCJpMNFh0cDJdxM3bLEEMVtTQDia5GLR+WRc=;
 b=FIBKKl0nqzHoi4+5ClCfQnz/7lGR9a9Xyoqbgn8IzLb3Y74AiLXZem3S5Pd85iVnsivRU5gQmMjNbSjm+U1DVuTY/YNEqG2Bioa/Y2p4o6JxX23aWiSDF7QpPM9HuanGUw1XMFaq0+PIK/Xv4CmRwDKgMoy4YHutSqzkZMFjzmXN9RAEGcW732xoYujmWHLgc3h9RMTwKieOyv2ae7LP6Ba0bNYqbp5WTWIBB9vkG7KDARxjFMiM2fB3DOyQF+aIOw3ZOgLKI0w7BGszuLvn7VE2+1h+y9nukNhmLCS1QCZFkV8pdpPAa40E0OBBHbGaqd5XXVyJpjT1QVWKBMUybg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Wj4aoEwaCJpMNFh0cDJdxM3bLEEMVtTQDia5GLR+WRc=;
 b=EJwqqa+s9xUTY6WRTgXsqxC3Tm/duGwzz51P7UIRvjPzvU9kpk626dW4kERzykhd/Sgdh1fh394ntlUYv5YNoUJIWfW0d9eKJRGaVguagpFtFaInpRpKinaSfYK7+pdVlqt+NQk6IqWIc7BpxIrE69RlrVpba9pbmiWTtCaZnFs=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V4 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial support
Date: Fri,  8 Apr 2022 22:09:30 +0800
Message-Id: <20220408140932.17968-1-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR06CA0001.apcprd06.prod.outlook.com
 (2603:1096:4:186::21) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fbacc201-50d0-4d8a-f36a-08da1963a8da
X-MS-TrafficTypeDiagnostic: AM7PR04MB6949:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB6949AA3D8615CB0FC4A87589C9E99@AM7PR04MB6949.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5zMmRsbSu9odXkXk7u2uamK/2ZvbmnPsEqR9D2EjMKRo36UHnX9Ts4U6HCFaAOT2k/3JeN9SdSxGUF0hNhPoPqtJ+U3ZwnLMhizpSB9c2IlJpOI8A1J31bTOKY5AK3QZBXENN/gun9GbARFYqComd4XWW5t/SvlskIz0pmAPRDwFFd5+gckx8OCcyDsspj7goI95lVS0Qg4npnGk8B1L5TNKxNZt1UVHNYiZy2PbLX2uUYh6dFqNX8rjRxhMSQ4T36mn0eGPX+8ptaq7whX7+Na19/Lmi8Y0CchLsGoOchU7KetR8HUBH+WiYEXLdoHlGYRPA96CPdJTaaBV2AmHqpX7mv+B81esmBtgc/Mp2BlZZSFcbMO5Fg7AILqwa8z4EsfBKKBbQ3hRHJYCNf3n66Dvk0+1qFWk/r+fD6lXnD46S/ch8cAwBKoDKM8Z7CWRDtWsfLSnWpgSWqdsgcIDWH2nJliyQcdNhLbA/xj03CjivgZPaMoc9cWI/57tQqbAMRooe991RK735mKqDChHW3AZzJ+/OlMZBNLfsQCGNG7thWmWsLUuBb1ANRV/G/V910HV444GV23CKBd83EnEL4Z6usZpVfCyvCXtzS1nGBmcpO9E8sc1bjr+9N4SDMBAuUzI80XqbpSgEQBg/D2n2JALAfxWCKwofNNJG51+KlczkP+8lvDA8AnzW6DOa5ofPIOyEv3bX65BlTUeu+efZw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(6512007)(8676002)(52116002)(6666004)(6506007)(4326008)(508600001)(2906002)(5660300002)(86362001)(7416002)(38100700002)(2616005)(186003)(26005)(38350700002)(1076003)(66556008)(316002)(66946007)(66476007)(8936002)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PylUa2CeE9vavL/F56KajXbz5oRh2CpkTAtek0Y6c26NrxY3zjYPcUA6X+52?=
 =?us-ascii?Q?Zazo10S109SJi23jmJK4waP3NoXFRzK5s4WrtWeMmPGbX44THqoWyXHARmrc?=
 =?us-ascii?Q?na7jOTeadOZWqs3FfkWprU12q/vZQGX0f7Bi5NKH1F3s3AGXpnMEP5xixoAX?=
 =?us-ascii?Q?95fE7ftX60sV1sRqdQ6Aie374/n6UkWGmDvkcVYJE3ELgfKIXi38J9G+2NGw?=
 =?us-ascii?Q?4fOfxZiRpew3uSvIRcLJ6qti7iZbjDH0uqj2zJgeAt1pFMNo7ZuLRpIwVXVn?=
 =?us-ascii?Q?Qkj9NC/A9EUuw0Mtd3c0Ofh6Y2M4O2rqKCR7OnTpEKP4yy+lUq4gh6qYeb/g?=
 =?us-ascii?Q?KibP+LnH6w+x9sdMZsca7iWEGKzDmqHcpwGRKRyoTaoZmZseYEWU+nq8gqOn?=
 =?us-ascii?Q?M+9GyBJmUZ2ZfPYebnax0JnbaSgxvWlxykbrB/ZLy8TrUz5FEdxc36MKBasY?=
 =?us-ascii?Q?nRLpmd56EwxlQXb3Jq8C9E+a/qgzH0RdYmT4DUbGSpmmzknQYXy/z8r+ugkf?=
 =?us-ascii?Q?LcMjm9oOf5p7bL7d2IxvhkX6+k7+4kuXJd8nwroAxzPq9T/Zd2DGRjLBtQlu?=
 =?us-ascii?Q?Iys6l+xglJXy9idDwfA3cLvmtLvCUoO7hQ4aTLkuEhVRPZzWvCxU0WW5yFqR?=
 =?us-ascii?Q?DZLnuh52rMVZgslbmEQTHvhabTEyfgrE5wdIsthkRfOkJoAPyUf7pMWTEmEq?=
 =?us-ascii?Q?LP5mxzr+qN+r+esRF2Il/4Q0Tzl3zDzcV4a7k2mW2APrA/Jg8vY9vqfvIci2?=
 =?us-ascii?Q?8htiZxkfT3GVNVKvO4ZHTWrMnWV2o1qvhj50kcG06Ge2PObWJ7ZNdsNXOL5t?=
 =?us-ascii?Q?isJVyeNPIemX8NNw//eITnEoYtZ9lg7H4ZQJyfceEqW3hfnSvy/u1Vwc5O3y?=
 =?us-ascii?Q?sjCoPBc28Yn0avRVGKI3lOqd4xeDABG89yFXHXo2oQ3B5qYeW/noWPwwOprJ?=
 =?us-ascii?Q?CwPL4wp/T+eBIedZ11qzEE+NMjjPx3JsK/5pue7bRQ0wq1QE4pMPO7HOLnDC?=
 =?us-ascii?Q?7yvdO2AHIGicjfTgcV37Svdlee24LVrW2qTiJvf/wuAx74t2EkSgS7izai/5?=
 =?us-ascii?Q?oSsMMUNPFlSXwE9XBDQY02D3j7oyA8QEjuAEDEoGs4QfvJgs1qDI//d8sv/U?=
 =?us-ascii?Q?AGX/gdip+OsveiXev4Yvf0eLOS88W7P0t1HfNCTgeu71jetv3fd3HAogtdZv?=
 =?us-ascii?Q?XeFNdDBp5x7CfclyIvBwbphEaS9h6Ml5rIjPxWM7QFBfQsMFuar0fFF2P7Po?=
 =?us-ascii?Q?IRyEXQOG+YiY9bv63I58zDXQtsvED+lvMHi5aMU2PZ6w0ZN7GaiAS6aYH8gZ?=
 =?us-ascii?Q?wbkjn1iHiMRGGgKzHYmYk7lKM719M2FoWe/m/bHHfHXp5HX+5B3kFkhFLu3j?=
 =?us-ascii?Q?j10qgSaUTcSEsitjKoZiA/Lf5ea2z7jJhWnlE/MfKVQzyCM/hpMMWXvQ7jkB?=
 =?us-ascii?Q?jnQctihm1uiXYsL3EibFlKS/f2z1nrmOW2iPNcN9Mvbp+FIV3L4KMoR4tFy7?=
 =?us-ascii?Q?b/FIzDHNfbE3v58+YqByRFbgXACu5zWMU0vLpewjbKVgFHRZrSfLmQsfQmv0?=
 =?us-ascii?Q?PdFQIjpKrTYA2GFtFrCiDXmA24TlWgYUM/QrJwmnv+MMqlqCKHPIJq6GlL0i?=
 =?us-ascii?Q?lHlyixY0miFXiRrp1Fmc4w13ykAjnVnsFHjY2hYbhmdt7Q30PPnb1KQgrGEK?=
 =?us-ascii?Q?uT7gFsaxx5gVpNcxLwmNih1VoASXw2YI9B0LHi+jLo5jEcs5hI9qm6PxQv3/?=
 =?us-ascii?Q?jN5Bp767yg=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fbacc201-50d0-4d8a-f36a-08da1963a8da
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 13:28:25.8285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X/cyXppO0EuvAZvX9SANDicZ1Y6UQdbKv/BF9yKu6p5GekrUoC5ytQaHwIBGgghdqr9neXnGMCme+rj9M/J2yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6949

From: Peng Fan <peng.fan@nxp.com>

V4:
 Wrong v3 version, some BIT definition are mixed in patch 1,2. 

V3:
 Addressed Michal's comments.
 Add Henry's T-b

V2:
 Per Julien's comments, fix coding style issue, drop unneeded code

Add i.MX lpuart driver and i.MX8QM platform support.
 - lpuart is the uart IP used in i.MX8QM/QXP/93.
 - Very basic i.MX8QM platform support.

Peng Fan (2):
  xen/arm: Add i.MX lpuart driver
  xen/arm: Add i.MX lpuart early printk support

 xen/arch/arm/Kconfig.debug              |  14 ++
 xen/arch/arm/arm64/debug-imx-lpuart.inc |  52 +++++
 xen/arch/arm/include/asm/imx-lpuart.h   |  64 ++++++
 xen/drivers/char/Kconfig                |   7 +
 xen/drivers/char/Makefile               |   1 +
 xen/drivers/char/imx-lpuart.c           | 276 ++++++++++++++++++++++++
 6 files changed, 414 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
 create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
 create mode 100644 xen/drivers/char/imx-lpuart.c

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 13:29:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 13:29:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301586.514774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncog0-0008Vq-PB; Fri, 08 Apr 2022 13:29:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301586.514774; Fri, 08 Apr 2022 13:29:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncog0-0008Vj-Lt; Fri, 08 Apr 2022 13:29:24 +0000
Received: by outflank-mailman (input) for mailman id 301586;
 Fri, 08 Apr 2022 13:29:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wmu2=US=nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ncofy-0007Q5-S5
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 13:29:23 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on062c.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::62c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e6588c95-b73f-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 15:29:22 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by AM7PR04MB6949.eurprd04.prod.outlook.com (2603:10a6:20b:102::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr
 2022 13:29:20 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5144.022; Fri, 8 Apr 2022
 13:29:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6588c95-b73f-11ec-8fbc-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fAlvv+3oE8eLD2B4J5dVFAwlckiAotrIkUwaNBVYhqwfEcp0NYunJIZMPP83XGe0W4FHu2S/ycVx1lqwIcr3qEkGDGWay6PN4/uIyfuuNib+tJAJEEWjoS7tgyyfuynfyFnvSrsW/tCmsLzVIHR27qsDIs6bEFATHN4HKXwGrd9AWahrXSeTTsark25ra6zbSvfC+/S7vs7Cz0B6I3PcRPkZpetWGLqzCGvLQ/2Xkr73wQ2eASTWUZUhxHWQnoa2r3yk4U+cqB8V6kti1DZwyJVOYNfwxNcZ3h/qWoc/rvhwmKk3DZPq1wcd/oART+zXACd7HMq49CKj9EiLf3JPLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wPOee9pnMGqVU9xIGltswGcbvk4wTGHaAUduAbIrVyQ=;
 b=RuzZjdgkB3BEKw4IWjwiBb7LQ9ookyo27KfNSOWbxtUMpRRDdvHG6wnYk7o/Cs754Kkeg8cMgKMNTzfJ0YaNcZZf1K/pTV7hDP1nmv8jgLCw3aXLqA8x9RUioyyJxn9FlvZK26YqUm/IxHazPkp7ovwlmHp/K/mZ2WkWEV7nm7GJZOUeiigGE7Gr+88bdE07caKSmCZ9k2DOoNafiRvNBAKWqg2/b/peIZ8Vru0NjoDyGGC0hJRl6DLtLgm5sQI87hMfpIWfpoEB+alH1h2gcSFJtSWN7O9CbDwhpwpATvi7GBrSjwkFOmogFWkMhHo36DWkm2LKXdoofCIgbBKVYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass
 header.d=nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wPOee9pnMGqVU9xIGltswGcbvk4wTGHaAUduAbIrVyQ=;
 b=LHGgX3Z7Wf26wFmRCUULRTAAStxHGQoHdpnbVQhil529ZPx7sMeVSSrRaZwoTM5df3GtT9/HASPXvpRsTREkmKMit5zqOx2vtHFY5yWg/7f6vf5qNaqH9+6oQ63vaIgmyH1VwCBVBaMZY+RJEM0uG2RuCwtv0OklZYxzAkhuQbM=
From: Peng Fan <peng.fan@nxp.com>
To: Michal Orzel <michal.orzel@arm.com>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, "bertrand.marquis@arm.com"
	<bertrand.marquis@arm.com>
CC: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"van.freenix@gmail.com" <van.freenix@gmail.com>
Subject: RE: [PATCH V3 2/2] xen/arm: Add i.MX lpuart early printk support
Thread-Topic: [PATCH V3 2/2] xen/arm: Add i.MX lpuart early printk support
Thread-Index: AQHYSiOqexdlapMzRU6Bt2qQ3HStYazl0OeAgAAz44A=
Date: Fri, 8 Apr 2022 13:29:20 +0000
Message-ID:
 <DU0PR04MB9417803BB8B28A9A1DDCB29488E99@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220407024418.9827-1-peng.fan@oss.nxp.com>
 <20220407024418.9827-3-peng.fan@oss.nxp.com>
 <363333de-0ec9-dff7-09c3-426530657a43@arm.com>
In-Reply-To: <363333de-0ec9-dff7-09c3-426530657a43@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nxp.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2364cc53-d527-4e8b-9fbe-08da1963ca05
x-ms-traffictypediagnostic: AM7PR04MB6949:EE_
x-microsoft-antispam-prvs:
 <AM7PR04MB694967206EAA14166AE43CAD88E99@AM7PR04MB6949.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 fahjMYiEFaY34JLEpfgIskoR2W/icZ4OtbPxioHvhSoD7DE75/dPy0gg/G7wHkSRDs7F4AtK+y/heoTeMuDV58RDP34SD4yhGG7fMGTp3c+V77gOSvg9uH8UjcC63cG5GswKBH8EDRq7gVzs++c3s9yCH7LdhREiPpMOQRZDwT9aw+2XwzGPZOuukWxwvIfGsP1HprU/dDbolUCrIbFiD805iXFiNTk8+iSxHl3ehOQoMFoCwO6z4hODk7bG44XP1GSLoSq+sNtdRElyjpCFwq1qKy+CqBxqce+rIGev8VpJfj+ORoasmqUKTdsZKkB3I6T5h/4vf+4s6JNk/4Ha2bECVkZuewDbFUtD4+ozDPhxNhYTR5b2UjXc+2BQOxrbR9qaWBFEBsUumiMF9xmvo/Wh8KeGqGXQj4TY4XmoVoCd4uFGxcmIllErL01E2jCU9FuG1ynimS0j2P46ysGo7/5t031HS7b/DOp1jRNksVFPhm9FwOWk/4/A18z5L9Cuf7XzACJGNVLITx38qzPv7uwBAh5hIxHDCgfYJff4KWESozx/jB1gOdWPQcn/O4vUZmQPcRsfRYzdjRL0kLUCiSK5OXysAoVdMsZSD36SzNV7TUFOfUo5wcKXQSlGRhE1oyjG8n9ndlPv2mb5OCVVpDdoNswJmJ+lINiCbzUoG8ta542UJd5XpBC+oOCsKjvRFB7YFDM0B7Qp7/vKHkE/cw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(9686003)(7696005)(53546011)(44832011)(52536014)(110136005)(6506007)(4326008)(508600001)(33656002)(71200400001)(2906002)(83380400001)(54906003)(76116006)(55016003)(38070700005)(5660300002)(86362001)(7416002)(38100700002)(186003)(26005)(64756008)(66446008)(122000001)(66556008)(316002)(66946007)(66476007)(8936002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?TUQrQXZwQTdnSmpzbklJWi9YMDRzU2FCWUFKdmFSQ1Ryd09FNUJncVA4emNR?=
 =?utf-8?B?NkRTVWNXeUpMelA1b1ZYRU5FVXl5TXhtcnNhRndxVkxobDNLUTZGQ1NmN1RS?=
 =?utf-8?B?RUVpalRwRHgvY0xvT1Zxa0tQY0hyek1kZjFDUnJOZUxsSEYwK053VG5OSEY0?=
 =?utf-8?B?Y3Y5NnBhTGU2MTF4WUVXVWR5bnpYY0cwcm5MY05kcmgvV2tCK0h6eExlUGpF?=
 =?utf-8?B?bUkwZnVsYkFKVkpCdVBqSnBXZzNaNGgrN3d3Si81OHlwVUNPMzFYZ0gvdVA1?=
 =?utf-8?B?NGY0UWt3L0FKL3NzdTdkVVpCbDZ0eWFob2VpR05wR0RSOUl1dVMwMWsrK0RZ?=
 =?utf-8?B?OU45UitZMUtOT0dCMHZhbzVpMWg5TkxQa3ZMWkRmeDQrNUhEZ25LbWxtU2lV?=
 =?utf-8?B?R1lJSStoaWJ0TGtUZDZLRkxabDNMNHhCTjZkenY2U1VDaXhOMTJiSHF6bHd1?=
 =?utf-8?B?TDNJMjZnNEkxcElzVjgxdnFMWStvWkRwNXphdE12SVBXNVFGMDZDd1EwWUFM?=
 =?utf-8?B?Y0lZa09UVWlIY3NpM3NyTFdKOWI2U3VUUmx6djhjaHJibXhSWVZkNmViK2sy?=
 =?utf-8?B?YzBPdGZYdTE5ekRrU1h0Umg0WFNFeDdKcGF3S09vb0p1Y3dvNW1ORlNvRGF4?=
 =?utf-8?B?bUVJTFZZTWdpcFpTRko5MWFubmFWWHZGVmJvdXlRbGtIbm1lWHRwRmpnWlBk?=
 =?utf-8?B?YVAxaXMwTHpBNnNzTEtkOWRrNVdjZU5Zc3dpY01MV3hqTnNYRTZGTFB4ZlFl?=
 =?utf-8?B?bEVSMXY5bDFscjRpNlRvNXZMT2xoY3BKQnN4WFJvaVlOa2NOeHREVU9PQ0xw?=
 =?utf-8?B?TkMrM3B1SHZKb0IxZlMxOFZ2Q2ZtTHR5bjI4amRZMzVKdUFRNUszN2ZIZmVG?=
 =?utf-8?B?Rm05Z0E0aDFLeWx4Z2ZPdXdGZnVPUkJDbVhhZUlkbm11T3QxWmF3V3hVUzg5?=
 =?utf-8?B?UDhnNXAvT0dCcUZIYVhjQklqamJXbGFnNEhTR29PMVRUTis1MlZZMGJKOFVL?=
 =?utf-8?B?ZWtFbG9KdnZhNCtqWmkwalNXUnV5SjNUSjgzdDJhdlpoVW8zU2RRalV0ODJ5?=
 =?utf-8?B?QkErb3FjdlA5WHdKVnJ1UGg3TnEyaGFZRDVGQzlUTzJ0c1JVUmliL0VKUmRp?=
 =?utf-8?B?TFhHNU5aMlI2cGk0RURwSGRSTC9WQzI2NVR0TDJCbVhaaEh4bW9UNHFGS1Vw?=
 =?utf-8?B?K251WDdoSzhodERQeUFtbjliK3BFZzFlTXBxYmVWRVkrMkZWbDBycE5FV3FR?=
 =?utf-8?B?UjBDU0JzczJKSURDbzJ4TGxpY3lJQzM5NUxGM3NHTDNlRXd2TTg0UFVnNGlC?=
 =?utf-8?B?WHpqUzh4WE5Nd0ljMnVTcjhnSFNtdE50ZUR1Z2d0S0dnSjVoS0VTTWxjK1Jr?=
 =?utf-8?B?aWZBMzdmTW94R3dkOVQxR0FpUXN2emFjS0FhSnlKbEs1bzZIMkw0bzB4L0FH?=
 =?utf-8?B?bklqMnNmMTdwS0ZVMVZiZGc4QW94UFdpejhKODVmVWlsdllEVUxCNzN3bEhQ?=
 =?utf-8?B?TGtjSnNQSk9rT2QvWWVWUy9BWENJZHpwZW9iQWFWUEpqOUhZa2o3Mi9XcHlW?=
 =?utf-8?B?YmlrTklSWklaMjBwQk9yQko2ZVJDeGp0aXRtbFlOY3lLcWRoN2MyRjJpZ1gx?=
 =?utf-8?B?a1hYKzg0T3RUMHJxdWlnMW5xcFBuV2JncVRFSDF5U2ozTFFuZ0JsbDg0TGZu?=
 =?utf-8?B?NzFiUVZLY2NkUXNxQkU2ek13L3ZNWGpONTlmcE82d3NaR2VmUVpHS1IwN0Uw?=
 =?utf-8?B?KzIwaVcwTHdobEhRRVJPQ0dsQVlTS3BkQkxQRDBCUSt1WUFEbmcwVklBcWVY?=
 =?utf-8?B?cWZocFRnb3NadzFMOXpFUTdQK1FwZXMzYnlVKzh2NG83dVNnVThkNTlTL2xL?=
 =?utf-8?B?bDc2VUh0S09CcU81L2FqMW5aeGh5ZGZZWnVScnE2UDRPZFRleS9FOXIrUVlE?=
 =?utf-8?B?Y0FXNURzSjdCZFVIMFlDWnZzSlZXbnlBditoVW84djVVc0pTL2gyWWpVeUwv?=
 =?utf-8?B?MjhEckE0czg4OUZKTnZ3bWxMMFBtZzVycmJmWlB4YmdkVko4cFlUenhQNE1u?=
 =?utf-8?B?NTl4cGRjd1F2Mmh3YUJDMjkzTldQNG40SVorOThpbC8ycDh6b2RXdmo1YklX?=
 =?utf-8?B?VEQwSEFDZUt0aG84ZTRHcjdEekNycjk1TzBjS2ozMzU2cVZtK1BFeFBqTGJo?=
 =?utf-8?B?ZXdDYWRXK29zbFIxTlNtRnhCLzB3SnN3Y1VNVWRCamdpdndDWG8xSzg5NGNy?=
 =?utf-8?B?NHYyTDFRc1loVmhlamJIbXpSWFFTK0xYaGltM0x3WW42OEhlWXNpSW5id3VS?=
 =?utf-8?B?aVppY2VCdmM3Z1FVR3RaTzA4OFhkQkxyall6Z3YxenZqOWZBdk8vQT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2364cc53-d527-4e8b-9fbe-08da1963ca05
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 13:29:20.7544
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fpmjocHuhkccSkPTcwcem3rnMHZH7FQ4tgGwrlXfouPVAtWxEOIEYEmtmsgxz+Prm4BLyzYu3abKHJhCv6Nf1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6949

SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh
bCBPcnplbCBbbWFpbHRvOm1pY2hhbC5vcnplbEBhcm0uY29tXQ0KPiBTZW50OiAyMDIy5bm0NOac
iDjml6UgMTg6MjMNCj4gVG86IFBlbmcgRmFuIChPU1MpIDxwZW5nLmZhbkBvc3MubnhwLmNvbT47
IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc7DQo+IGp1bGllbkB4ZW4ub3JnOyBWb2xvZHlteXJfQmFi
Y2h1a0BlcGFtLmNvbTsNCj4gYmVydHJhbmQubWFycXVpc0Bhcm0uY29tDQo+IENjOiBhbmRyZXcu
Y29vcGVyM0BjaXRyaXguY29tOyBnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb207DQo+IGpiZXVsaWNo
QHN1c2UuY29tOyB3bEB4ZW4ub3JnOyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7DQo+
IHZhbi5mcmVlbml4QGdtYWlsLmNvbTsgUGVuZyBGYW4gPHBlbmcuZmFuQG54cC5jb20+DQo+IFN1
YmplY3Q6IFJlOiBbUEFUQ0ggVjMgMi8yXSB4ZW4vYXJtOiBBZGQgaS5NWCBscHVhcnQgZWFybHkg
cHJpbnRrIHN1cHBvcnQNCj4gDQo+IEhpIFBlbmcsDQo+IA0KPiBPbiAwNy4wNC4yMDIyIDA0OjQ0
LCBQZW5nIEZhbiAoT1NTKSB3cm90ZToNCj4gPiBGcm9tOiBQZW5nIEZhbiA8cGVuZy5mYW5Abnhw
LmNvbT4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbmcgRmFuIDxwZW5nLmZhbkBueHAuY29t
Pg0KPiA+IC0tLQ0KPiA+ICB4ZW4vYXJjaC9hcm0vS2NvbmZpZy5kZWJ1ZyAgICAgICAgICAgICAg
fCAxNCArKysrKysrDQo+ID4gIHhlbi9hcmNoL2FybS9hcm02NC9kZWJ1Zy1pbXgtbHB1YXJ0Lmlu
YyB8IDUyDQo+ICsrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgeGVuL2FyY2gvYXJtL2lu
Y2x1ZGUvYXNtL2lteC1scHVhcnQuaCAgIHwgMjIgKysrKystLS0tLS0NCj4gPiAgMyBmaWxlcyBj
aGFuZ2VkLCA3NyBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkgIGNyZWF0ZSBtb2RlDQo+
ID4gMTAwNjQ0IHhlbi9hcmNoL2FybS9hcm02NC9kZWJ1Zy1pbXgtbHB1YXJ0LmluYw0KPiA+DQo+
ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9pbXgtbHB1YXJ0LmgNCj4g
PiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9pbXgtbHB1YXJ0LmgNCj4gPiBpbmRleCAxMTE2
NDBlZGI0Li4yNmUyY2YwMjQ5IDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRl
L2FzbS9pbXgtbHB1YXJ0LmgNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vaW14
LWxwdWFydC5oDQo+ID4gQEAgLTMwLDEwICszMCwxMCBAQA0KPiA+ICAjZGVmaW5lIFVBUlRGSUZP
ICAgICAgICAgICgweDI4KQ0KPiA+ICAjZGVmaW5lIFVBUlRXQVRFUiAgICAgICAgICgweDJjKQ0K
PiA+DQo+ID4gLSNkZWZpbmUgVUFSVFNUQVRfVERSRSAgICAgQklUKDIzKQ0KPiA+IC0jZGVmaW5l
IFVBUlRTVEFUX1RDICAgICAgIEJJVCgyMikNCj4gPiAtI2RlZmluZSBVQVJUU1RBVF9SRFJGICAg
ICBCSVQoMjEpDQo+ID4gLSNkZWZpbmUgVUFSVFNUQVRfT1IgICAgICAgQklUKDE5KQ0KPiA+ICsj
ZGVmaW5lIFVBUlRTVEFUX1REUkUgICAgIEJJVCgyMywgVUwpDQo+ID4gKyNkZWZpbmUgVUFSVFNU
QVRfVEMgICAgICAgQklUKDIyLCBVTCkNCj4gPiArI2RlZmluZSBVQVJUU1RBVF9SRFJGICAgICBC
SVQoMjEsIFVMKQ0KPiA+ICsjZGVmaW5lIFVBUlRTVEFUX09SICAgICAgIEJJVCgxOSwgVUwpDQo+
ID4NCj4gPiAgI2RlZmluZSBVQVJUQkFVRF9PU1JfU0hJRlQgKDI0KQ0KPiA+ICAjZGVmaW5lIFVB
UlRCQVVEX09TUl9NQVNLICgweDFmKQ0KPiA+IEBAIC00MiwxMyArNDIsMTMgQEANCj4gPiAgI2Rl
ZmluZSBVQVJUQkFVRF9URE1BRSAgICAoMHgwMDgwMDAwMCkNCj4gPiAgI2RlZmluZSBVQVJUQkFV
RF9SRE1BRSAgICAoMHgwMDIwMDAwMCkNCj4gPg0KPiA+IC0jZGVmaW5lIFVBUlRDVFJMX1RJRSAg
ICAgIEJJVCgyMykNCj4gPiAtI2RlZmluZSBVQVJUQ1RSTF9UQ0lFICAgICBCSVQoMjIpDQo+ID4g
LSNkZWZpbmUgVUFSVENUUkxfUklFICAgICAgQklUKDIxKQ0KPiA+IC0jZGVmaW5lIFVBUlRDVFJM
X0lMSUUgICAgIEJJVCgyMCkNCj4gPiAtI2RlZmluZSBVQVJUQ1RSTF9URSAgICAgICBCSVQoMTkp
DQo+ID4gLSNkZWZpbmUgVUFSVENUUkxfUkUgICAgICAgQklUKDE4KQ0KPiA+IC0jZGVmaW5lIFVB
UlRDVFJMX00gICAgICAgIEJJVCg0KQ0KPiA+ICsjZGVmaW5lIFVBUlRDVFJMX1RJRSAgICAgIEJJ
VCgyMywgVUwpDQo+ID4gKyNkZWZpbmUgVUFSVENUUkxfVENJRSAgICAgQklUKDIyLCBVTCkNCj4g
PiArI2RlZmluZSBVQVJUQ1RSTF9SSUUgICAgICBCSVQoMjEsIFVMKQ0KPiA+ICsjZGVmaW5lIFVB
UlRDVFJMX0lMSUUgICAgIEJJVCgyMCwgVUwpDQo+ID4gKyNkZWZpbmUgVUFSVENUUkxfVEUgICAg
ICAgQklUKDE5LCBVTCkNCj4gPiArI2RlZmluZSBVQVJUQ1RSTF9SRSAgICAgICBCSVQoMTgsIFVM
KQ0KPiA+ICsjZGVmaW5lIFVBUlRDVFJMX00gICAgICAgIEJJVCg0LCBVTCkNCj4gPg0KPiA+ICAj
ZGVmaW5lIFVBUlRXQVRFUl9SWENOVF9PRkYgICAgIDI0DQo+ID4NCj4gDQo+IEkgZmluZCBpdCBh
IGJpdCBzdHJhbmdlIHRoYXQgeW91IGZpeCB0aGUgaGVhZGVyIGZpbGUgaW4gdGhlIHBhdGNoIDIv
MiB3aGlsZSBwYXRjaA0KPiAxLzIgaW50cm9kdWNlcyBpdC4gQ291bGQgeW91IGRvIHRoZXNlIGZp
eGVzIGluIHRoZSBwYXRjaCB3aGVyZSB5b3UgY3JlYXRlIHRoaXMNCj4gZmlsZT8NCg0KT29wcy4g
SSBtaXNzZWQgdG8gbWVyZ2UgdGhhdCBCSVQgZml4IGludG8gcGF0Y2ggMS4gSnVzdCBzZW5kIG91
dCBWNC4NCg0KVGhhbmtzLA0KUGVuZy4NCg0KPiANCj4gQ2hlZXJzLA0KPiBNaWNoYWwNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 13:32:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 13:32:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301597.514785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncojB-0001gZ-8I; Fri, 08 Apr 2022 13:32:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301597.514785; Fri, 08 Apr 2022 13:32:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncojB-0001gS-54; Fri, 08 Apr 2022 13:32:41 +0000
Received: by outflank-mailman (input) for mailman id 301597;
 Fri, 08 Apr 2022 13:32:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncoj9-0001gM-7Y
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 13:32:39 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5a09c2bb-b740-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 15:32:37 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a09c2bb-b740-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649424757;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=WGJ4CgXNLi1TAOJBwy//92r7OiD6bYyBigPIi1XfE2c=;
  b=ZNhCePHCMttnzcFINn5N1L/q4HEHc3C4zUEAKWkuWw8n/UFuWQa7cdhL
   dp2cg7qBGFfveJ8x14HMGKegGzZsjaTS/a2jMSVRBRR3hf9eYriMZzCAd
   o4gOBiUpifl0lB/PStUgaOnbiTHNb1C31mIwOt4dHQ+a1YUe+8s4AWCU7
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 70771134
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pg6FVKjruX5gnEX7lml3iI8CX161GxAKZh0ujC45NGQN5FlHY01je
 htvWDuHPffcY2Pzc9Byb4Wzph4PvsXVyoQ2GlRuqXoxFykb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vd4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YT4wF7fWvcNGajwGKysvAq8Z9pDbCGfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNamGO
 JVAMGEzBPjGSwxmIGZOOsMgp+CpiGfOdXp7lUOql4NitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrlH/EzVPCwH9+6PgzBfjBZQPc
 CT45xbCs4AL7WWxVPzaBCSd/kaO7yEeBNR/D8QlvVTlJrXv3y6VAW0NTzhkYdMgtdMrSTFC6
 mJlj+8FFhQ07uTLFCv1GqO86GrrZHNLdTNqiTosF1Nt3jX1nG0kYvsjpP5HGbX9sND6ECqYL
 9ui/Hln3OV7YSLmOsyGEbH7b9CE+8Chou0dvFy/soeZAuVRPtPNi2uAswWz0Bq4BNzFJmRtR
 VBd8yRk0MgADIuWiAuGS/gXEbei6p6taWOA0AQ/QsRxqGv0ohZPmLy8BhkkeS+F1e5eJ1fUj
 LL741sNtPe/wlP0BUOIX25BI5tzlvWxfTgUfvvVcsBPcvBMmPyvp0lTibqr9zm1yiAEyPhnU
 b/CKJrEJStKWMxPkWvtL89AgOBD+8zL7T6KLXwN50/8iuT2ib/8YeptDWZimchltPjU/1iPq
 4832gnj40w3bdASqxL/qOY7BVsLMWI6FdbxrclWffSEOQ1oBCcqDPq5/F/rU9wNc3h9/gsQw
 kyAZw==
IronPort-HdrOrdr: A9a23:Lh+EcKuKnjm1PQyHO6Pa4XwZ7skCgIMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK5yXcT2/hqAV7CZnichILMFu9fBOTZslvd8kHFh4xgPM
 RbAtdD4b/LfCFHZK/BiWHSebZQo+VvmJrY+ds2pE0dKj2CBZsQijuQXW2gYzBLrUR9dOwEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfbHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+0+VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qZ5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 929lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQlo+a87bW3HAb0cYa
 dT5Jm23ocWTbraVQGTgoBX+q3hYpxpdS32AnTruaSuokprdT5CvgglLfck7wY9HaIGOud5Dt
 v/Q9RVfcl1P7crhIJGdZM8qJiMexvwqSylChPgHb2gLtBEB07w
X-IronPort-AV: E=Sophos;i="5.90,245,1643691600"; 
   d="scan'208";a="70771134"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ih2orIlwBhK9/4YXOWTFIJ5ce/RAA/lL7hr51Zad0SmHTrtSi+0cFVQxHZ7v40e37YlzJxxPW1qt1gtNrOlWQinZFXhcL6XUW0gKk3KQeG8CStZrCUTWBNMC3zEn8WbmcvBob95S8qswQ0nZPh9P5zgcQGXSyHfGxc59qhEZztV8E51AO/4D1tcvNiVswtM2RrZ2aB4hOv01C5LFqX2mTtLpuZHEv7K8v0pVEm7oAmRkYABEPm29Qf8XP8I3HOGUuyyuJ3MZ/VKVaQMoqM1D1+RXYq5p2lQe+hXgoXQsNdjk1MNWaEXcoRtzRQQu2+lw6+2wHucyhgTz2LgKaN+7jw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mycfYRjCuGQviAUZ42UDfke1LB0gXnoRC/rpO3Rwhhs=;
 b=nzB3cKjTwFd6oX1BVSYqsgqsdhbFvaz8BeDsgMz0D30lGtFrYEVnfWxEr8MpKd0RcRohcID1ImCtXUC43l2LKe0ST0VkX2HC8OtAgCEtFTnmU4X2JZZHca1mx8beqae+miZ9Kjp4z81CaAj03RwsdmsMhTkqHmJOETTE7qdVdOeeGw9BRwKtMsqmuqcfm7MzKZOZp2YW1T83zr99wRq4WnuGpwCH+1c9Yf/gYhqxT+n10VzsfDB31soNTUt+QGLyfiBdgUtoDuSMOBW9s8lhyBrTEhhRQx4jRz4cCcAR1oU+zVybw528wciZ10S02356NO+ePqvr4hzTHnSh+9L6hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mycfYRjCuGQviAUZ42UDfke1LB0gXnoRC/rpO3Rwhhs=;
 b=TbKYu2ZMPBiEKScCJ9VFaumv1K3DYjdMRyWLoCKkVJkwchCdG6p5jpyFs7WJYAI1WLKnRHWMMaKdHm36T4pIuh4TRWjtEcecKBhsyH/2k9dyiCOErs1TZZCFHNwfBl8J5yXLy/zC3O4Jf1yA06VmCxnnBd4OWA3UDqF8b10ear8=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>
Subject: [PATCH] tools/xl: fix vif and vcpupin parse tests
Date: Fri,  8 Apr 2022 15:31:46 +0200
Message-ID: <20220408133146.48117-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0020.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ae::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09fb0442-1224-43be-44b4-08da19642f5f
X-MS-TrafficTypeDiagnostic: MN2PR03MB5247:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB5247168DE2E5CF28BF5153108FE99@MN2PR03MB5247.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: y4gSdwEllLQmPUZML5UgTFuz+KrS/62nHSFTFVjJsxI4ZF76oupXkfX7Cec9zoMrQxavJWSXwjFM1UZQSNwkmXSvJNYo1CwPWEJibXAj50XOThFs/FISplkVoit4LrULc6X5WvCInHg/3MCeIAJlSNmTLCH/hA2Ir8JiiD0G9MVvf+ColNEGPexoT85Ft3ELz+iAGOXNt5UvgaU0xrhb6v+2eMGgk+2yOwfs2e2iC2ZT/z7hTHKccdGvk8Wq2rvgSt9cGWvsOG5ToMqDxyAOVAjoTe5xwQroB+1FUyLIb+PK+xSFJIrHCzTazA9gx5r0mcV4UFM5usLW8xawqg+kxz/nBLrB1ZTqPExrhiJfQj55bav5U52UOCnK+QUVsu3zjrFmZER/+kWaGW8q7VXj++4EPqgwgHqwIJ9qjmo49X3//I38dUbXHo+Vje5xhOUWYyWfKaCyiYkZXhCAP4bh2CcHEXP8VqQkPjVHbOVMezRuBdnBTo+PZfjmzV9U9plvcq8xh64LL1/Ly+Hw1/ItftsHxFfpMN4cW7H0qIO6oAjPrHRVRjlgOpjIWjsYNDGq4z6EJp303taaqVMzXhlAshtqQDhNvK3ZEOguJds3Hjk0gfRMlUtyirE7qJ57SEc/vU68QyFjWvYo9i1PwW1IHQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(6512007)(54906003)(38100700002)(8676002)(66476007)(66556008)(6916009)(2616005)(66946007)(5660300002)(6506007)(86362001)(186003)(82960400001)(83380400001)(6666004)(508600001)(6486002)(8936002)(2906002)(36756003)(1076003)(107886003)(26005)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3EvdW5hNGFWd3JxSGhRVXZ5NW01MGRFSFgvd1hMSitDVzkzY2YvWmY2U1Qx?=
 =?utf-8?B?MUM5K3QyME84SllCcW8veCtha1R5RjRpWk9PYXFmWGJObFpKSlZBSTZSeitM?=
 =?utf-8?B?YmVUWlBTdVZrTlZXZEtnZDNpaThBZ0xoNk9Hc0NHQmYyd3JkMVY5emJLT2ts?=
 =?utf-8?B?cllmSG5yYVNkU08rdjFFUHJiSXFJZ1RjT0lwM3ZJK3hDWTZoYWN0cjk4VU5q?=
 =?utf-8?B?ZmNzM3JXYmgrclhMRW1zWEd4d2N0WCtZeHRIVm9NR0V3NmpNZWoyVm5WZ3A4?=
 =?utf-8?B?clgvQkRwMDkzUnRTSmVxZ1M4QS9DWllsTEFIVlNtVk43RXZxMzczL3JYbUpD?=
 =?utf-8?B?Vk9WR2I4SGZFUlJOQkpGaE1WK05URXhsVjY3cXFPRFRHcTFrb01Ndmo3ZFVB?=
 =?utf-8?B?Q29NYkVTelNFZVdmTzdtbXlNbE5WUkJZR1ptUFdqZDdxN3BCSnF2OXZWWFB5?=
 =?utf-8?B?NTRWWnZqTm1IaDBmQTJqb2x1eERrVHU3aW8zZGRNSG5QRWd5T3BiZmFlTDlK?=
 =?utf-8?B?Q0tLZEpVNERNSnNGbGJ2YWlwc1MxRkFZVk9VcEVXUm16eW53b2x6UFhYYTBD?=
 =?utf-8?B?RG5IcFRhMUxCZEphT0wvcHFYYlErWUFZRldWRUFENjhKM3grQUg2ZWluMHVD?=
 =?utf-8?B?QkhlSnQ1cnRwV2twSkkxR1g4S3FySmJPOFVtNjBxRlpRNk8zd2NvOWY5cURa?=
 =?utf-8?B?ek5xci8zWENJc2lJeVhYVmdXcUpjSFB4QzltYnozbUl2c1Fic2RIRXE0eS94?=
 =?utf-8?B?enI0L2o0ZmRSdkNqaHpXd0h0VXpvOTdsdXRhRWNxKzdrUUMxZk9IV1krcXNs?=
 =?utf-8?B?eCtHTG1RNU9xS2dNN3VXTGZ5djEvVmxibzRBeHdTcnhZUERGNExPZGdvaHM2?=
 =?utf-8?B?aFIvMXY3TFErWU1TTkhva1lkSHlkVGhIVERBcmJELzdGaXljbVhsYkRjb1Zm?=
 =?utf-8?B?V3YzUHZQT0piR0lheU82RWtHdTZtcnlOWFB1cUtkdjVVbjZNVnlEMVptRGNE?=
 =?utf-8?B?R1FET05qRnVNSmZTbEY3S3NUd0hIK201b2pHV3lJeUN2eHQ4cWZDMUhDalFn?=
 =?utf-8?B?d004T3cyWG9WVmRGTFE3b1BtV1RUcTVESzN3RUhOK3llYUE0YUxCWkpCZ0wr?=
 =?utf-8?B?b2Ywby9FOGd2bHc0Ry9tbWJSbW96bDlMM053Rml0b3V3czJHVXhzbS9RbVpz?=
 =?utf-8?B?b29WZUZ1a2hKMXZBOWxUNllFTTRKdU5GTjlDZVdIMWVsTFNCbWR0Sk15c1Y2?=
 =?utf-8?B?Y0ZXZnhWS1Z2QWtnSm5sb3RHVlFhYWgxL01OSTFuanVUNlZGQitubm5raTVz?=
 =?utf-8?B?eko3QU41cXFQdlJXbG5ob2g5VjdYbmQ1aFdaV25KRGJSL2JVbWhrUEh5aXl6?=
 =?utf-8?B?RkF6SDh2ZHdCbWcrTldzL3pSRHJrVVppbFlXUVpaaEN4SHRyekxCVWlUNkMr?=
 =?utf-8?B?UXR1eXZ3bmk2Z0xMb0JKZ251cDNMbGN2QkRxSWhiREFXN1RKbXdYZEF6TlZz?=
 =?utf-8?B?Qk5CODZ2TFU1aTcwTFFtYXBWWkt1dk01aG9LbkY3MytldzcraTIwSzhGT1Rh?=
 =?utf-8?B?R29BeXgvcVZJRFpkM0NEOHhTVUcreEcvSm10V1JoNWd1YWY3NkY0N0JRcG1O?=
 =?utf-8?B?MGZmZVZmZGJ2c0c4SVNxTHpvT3MwM2pVWnRoVlp1SXR4THYzTkJBWkVKTUJu?=
 =?utf-8?B?YVBvU2hwOTh4UU9GbUNHMFRiNFZFWXZHWmxyUEQ3Vm0vck81TVNFU1grclM4?=
 =?utf-8?B?Nm1URy90R2taakJiQ2hPU3N0R0RCQkxHbmhHRGxiUisxWkxFTEJNanhVZ1pu?=
 =?utf-8?B?bGJqUFpBY0ROWFBVelZQZ0JzdEF6WTEzZG5FdU9wTWQ5T05SZ2M0c3lSc2lG?=
 =?utf-8?B?YWNha3ppQVpxMDJ5b1VqWjFab1pzRUJKd3l3b28rTEhkZlJuWTcwMnVXd3kw?=
 =?utf-8?B?UktBODlLNmF6SnF6Rkg0cFhpYklySndkZUxvaTUxalBxY0o3SCtwdjVNN2ZV?=
 =?utf-8?B?Ti81ZEFhTkl3K3NWZHd6L3FPQ3pBT29STWg5WkJJeXRUYnhJNy9tcThGSkxG?=
 =?utf-8?B?Ym5vOXd6MjQ1cDBwcUI2RzV0K0dhdS9wOVZ3Z1lEbVJ1eCs4WnByZmVGOVBQ?=
 =?utf-8?B?T3hOclpQeE4yRmNldklxUU03NENTR0diSUgyQXFWTTVCRUFjd0RGNTZzYU5n?=
 =?utf-8?B?OXBKM2dEV0VtbUFaN0xjMTByb01iZHloWkxGdE04aXJMNzdiOWJPdm50UDdv?=
 =?utf-8?B?emoxdm1hWjU3T2QzQ3cyYXo1UFgreXlmQlIrRUxRbXVDMTVpNWdISWIrdnky?=
 =?utf-8?B?N05rVXo3QllIZWlwcnRNMzVHUnFJVnd2TXVjQXpYaytOTWlEWWhydz09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 09fb0442-1224-43be-44b4-08da19642f5f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 13:32:11.0730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JGQ3ZiXe/EAqYmM1bRwZj/QVA7aD1EmZEHVVw6wPdi+DurS4k+dbDrcswW+biLIdUCtregAzlZCGYaBGsLZgAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5247
X-OriginatorOrg: citrix.com

Current vif and vcpupin parse tests are out of sync.  First of all, xl
returns 1 on failure, so replace the expected error code.

Secondly fix the expected output from some vif tests, as xl will no
longer print the unpopulated fields.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
We should find a way for those tests to be run as part of osstest, or
else they will go stale again sooner or later.
---
 tools/xl/check-xl-vcpupin-parse |  2 +-
 tools/xl/check-xl-vif-parse     | 52 +--------------------------------
 2 files changed, 2 insertions(+), 52 deletions(-)

diff --git a/tools/xl/check-xl-vcpupin-parse b/tools/xl/check-xl-vcpupin-parse
index 21f8421ad0..633616a597 100755
--- a/tools/xl/check-xl-vcpupin-parse
+++ b/tools/xl/check-xl-vcpupin-parse
@@ -158,7 +158,7 @@ END
 RANDOM=$seed
 
 echo "# Testing a wrong configuration" >> $outfile
-write foo 255 ""
+write foo 1 ""
 
 echo "# Testing the 'all' syntax" >> $outfile
 write "all" 0 "cpumap: all"
diff --git a/tools/xl/check-xl-vif-parse b/tools/xl/check-xl-vif-parse
index 02c6dbaeb6..04bd9463d8 100755
--- a/tools/xl/check-xl-vif-parse
+++ b/tools/xl/check-xl-vif-parse
@@ -40,7 +40,7 @@ complete () {
     fi
 }
 
-e=255
+e=1
 
 
 #---------- test data ----------
@@ -62,16 +62,6 @@ one $e rate=10ZB/m
 # test b/s and B/s rate units
 expected <<END
 vif: {
-    "backend_domid": 0,
-    "devid": 0,
-    "mtu": 0,
-    "model": null,
-    "mac": "00:00:00:00:00:00",
-    "ip": null,
-    "bridge": null,
-    "ifname": null,
-    "script": null,
-    "nictype": null,
     "rate_bytes_per_interval": 100000,
     "rate_interval_usecs": 50000
 }
@@ -86,16 +76,6 @@ one 0 rate=2000000B/s@50ms
 # test Kb/s and KB/s rate units
 expected <<END
 vif: {
-    "backend_domid": 0,
-    "devid": 0,
-    "mtu": 0,
-    "model": null,
-    "mac": "00:00:00:00:00:00",
-    "ip": null,
-    "bridge": null,
-    "ifname": null,
-    "script": null,
-    "nictype": null,
     "rate_bytes_per_interval": 100,
     "rate_interval_usecs": 50000
 }
@@ -109,16 +89,6 @@ one 0 rate=2KB/s@50ms
 # test Mb/s and MB/s rate units
 expected <<END
 vif: {
-    "backend_domid": 0,
-    "devid": 0,
-    "mtu": 0,
-    "model": null,
-    "mac": "00:00:00:00:00:00",
-    "ip": null,
-    "bridge": null,
-    "ifname": null,
-    "script": null,
-    "nictype": null,
     "rate_bytes_per_interval": 100000,
     "rate_interval_usecs": 50000
 }
@@ -132,16 +102,6 @@ one 0 rate=2MB/s@50ms
 # test Gb/s and GB/s rate units
 expected <<END
 vif: {
-    "backend_domid": 0,
-    "devid": 0,
-    "mtu": 0,
-    "model": null,
-    "mac": "00:00:00:00:00:00",
-    "ip": null,
-    "bridge": null,
-    "ifname": null,
-    "script": null,
-    "nictype": null,
     "rate_bytes_per_interval": 50000000,
     "rate_interval_usecs": 50000
 }
@@ -173,16 +133,6 @@ one $e rate=10MB/s@10h
 # test replenishment interval in seconds
 expected <<END
 vif: {
-    "backend_domid": 0,
-    "devid": 0,
-    "mtu": 0,
-    "model": null,
-    "mac": "00:00:00:00:00:00",
-    "ip": null,
-    "bridge": null,
-    "ifname": null,
-    "script": null,
-    "nictype": null,
     "rate_bytes_per_interval": 10000000,
     "rate_interval_usecs": 1000000
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 14:56:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 14:56:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301610.514819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncq2K-0003cL-SY; Fri, 08 Apr 2022 14:56:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301610.514819; Fri, 08 Apr 2022 14:56:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncq2K-0003cE-Pd; Fri, 08 Apr 2022 14:56:32 +0000
Received: by outflank-mailman (input) for mailman id 301610;
 Fri, 08 Apr 2022 14:56:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DXVu=US=citrix.com=prvs=090e341e7=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ncq2J-0003c8-V8
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 14:56:32 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 114b0c09-b74c-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 16:56:29 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 114b0c09-b74c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649429789;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=dwiG6vcPk/TTJGdAPxdaOUR+aUpBDUjuCoJQTN7ME94=;
  b=LwNtAv3KuR7c5/fWUh/w54nboZ4fBm0+2MAoXVTpeamy4sVBTCTZufHI
   38Z9rSSHnQ8re2P8pDiyVydRW1tYlV4xkmUjqFDOz0euS2goCBldF2cRH
   KVub8p/JlTPp/mESn5F28yQajLc5Ju4Iwv4m3HmLcmrHZQimkCFUveG+v
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68267032
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:c9J7u6uZHXG5DMrK+TVAz0NffefnVGFeMUV32f8akzHdYApBsoF/q
 tZmKTuGP62JMGPye9pxatmx9R4G656AzdA2TVBtrXw0FyMR+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/V6
 YuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi81EfWWpf0+cCBTLBBsOpZb94PgGyiG5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD
 yYcQWQ/NkqfO0YVUrsRII0gos2x11TUTxJdpBWwgIcL4XrRxSUkhdABN/KKI4fXFK25hH2wp
 G3c+H/iKgoHL9HZwj2Amlqpj/XKlDn2W6oTEqO57f9ghFCPxm0VBwYSXFH9qv684mahX/pPJ
 kpS/TAhxYAw/UqnVMjgXDW3pXeFulgXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k
 FiTkLvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsUSRdueT6g6IKhS3+XNFYDaGJqeelIGSlq
 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BTz8sF4gDGKxT8nxsAWAs64cRGqMZgPZ1
 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyyyGwmTKuKGpxdEdMMX
 KM1kVkMjHO0FCH3BZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzzBl2wfxia
 cjEKJ/E4ZMm5UJPlmfeqwA1i+FD+8zD7TmLGcCTI+qPj9Jym0J5uZ9aaQDTP4jVHYuPoRnP8
 sY3Cid54043bQEKWQGOqdR7BQlTdRATXMmqw+QKJr/rClc3QwkJVq6OqY7NjqQ4xsy5YM+Tp
 SrjMqKZoXKi7UD6xfKiNig4OOyyB84mxZ/5VAR1VWuVN7EYSd7HxM8im1EfJNHLKMQLISZIc
 sQ4
IronPort-HdrOrdr: A9a23:8A8z2qj1s27QWDThLB2O8XU/XHBQXtoji2hC6mlwRA09TySZ//
 rBoB0+726RtN9xYgBEpTnuAsS9qB/nmaKdpLNhWotKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM
 RdmsBFebvN5DNB7PoSjjPWL+od
X-IronPort-AV: E=Sophos;i="5.90,245,1643691600"; 
   d="scan'208";a="68267032"
Date: Fri, 8 Apr 2022 15:56:24 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?=
	<marmarek@invisiblethingslab.com>
Subject: Re: [PATCH] libxl: Retry QMP PCI device_add
Message-ID: <YlBNGCXm+wh2v7Yr@perard.uk.xensource.com>
References: <20220330194656.39051-1-jandryuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220330194656.39051-1-jandryuk@gmail.com>

On Wed, Mar 30, 2022 at 03:46:56PM -0400, Jason Andryuk wrote:
> PCI device assignment to an HVM with stubdom is potentially racy.  First
> the PCI device is assigned to the stubdom via the PV PCI protocol.  Then
> QEMU is sent a QMP command to attach the PCI device to QEMU running
> within the stubdom.  However, the sysfs entries within the stubdom may
> not have appeared by the time QEMU receives the device_add command
> resulting in errors like:
> 
> libxl_qmp.c:1838:qmp_ev_parse_error_messages:Domain 10:Could not open '/sys/bus/pci/devices/0000:00:1f.3/config': No such file or directory
> 
> This patch retries the device assignment up to 10 times with a 1 second
> delay between.  That roughly matches the overall hotplug timeout.
> 
> The qmp_ev_parse_error_messages error is still printed since it happens
> at a lower level than the pci code controlling the retries.  With that,
> the "Retrying PCI add %d" message is also printed at ERROR level to
> clarify what is happening.
> 
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> ---
> @@ -1252,10 +1258,22 @@ static void pci_add_qmp_device_add_cb(libxl__egc *egc,
>                                        const libxl__json_object *response,
>                                        int rc)
>  {
> -    EGC_GC;
>      pci_add_state *pas = CONTAINER_OF(qmp, *pas, qmp);
> +    STATE_AO_GC(pas->aodev->ao);

I think this changes are wrong, what is the reason to use STATE_AO_GC
instead of EGC_GC?
I think in this case, it is fine to keep using EGC_GC, as there doesn't
seems to be any allocation that needs to live after this function
returns. And you could just pass `pas->aodev->ao` to
libxl__ev_time_register_rel().

>  
> -    if (rc) goto out;
> +    if (rc) {
> +        if (pas->retries++ < 10) {
> +            LOGD(ERROR, qmp->domid, "Retrying PCI add %d", pas->retries);
> +            rc = libxl__ev_time_register_rel(ao, &pas->timeout_retries,
> +                                             pci_add_qmp_device_add_retry,
> +                                             1000);
> +            if (rc) goto out;
> +
> +            return; /* wait for the timeout to then retry */
> +        } else {
> +            goto out;
> +        }
> +    }

So this retry logic would be done regardless of whether stubdom is in
use or not. It's not going to be useful in the non-stubdom case, is it?

When adding a pci device to a domain that has its device model in a
stubdomain, there's a first call to do_pci_add() which works fine,
right? Then there's a callback to device_pci_add_stubdom_wait(), which
is supposed to wait for the stubdom to be ready, but the sysfs entry
might still be missing at that time, right? Then, there is a second call
to do_pci_add() for the guest, and it's the one that fail in your case,
right?

If my reasoning is correct, could we enable the retry logic only for the
second do_pci_add() call? So that guests without stubdom aren't impacted
as I don't think retrying in this case would be useful and would just
delay the error.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 15:26:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 15:26:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301616.514830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncqVK-0007l7-Bx; Fri, 08 Apr 2022 15:26:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301616.514830; Fri, 08 Apr 2022 15:26:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncqVK-0007l0-92; Fri, 08 Apr 2022 15:26:30 +0000
Received: by outflank-mailman (input) for mailman id 301616;
 Fri, 08 Apr 2022 15:26:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncqVJ-0007kk-5E
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 15:26:29 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 40810de7-b750-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 17:26:27 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40810de7-b750-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649431587;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=j8Y/KsIZX2DxU5o+pXEa2Gk2zlV07+AADXawE89UsfI=;
  b=UHpLNdO4OyEU7Z5kjPq0pNOdLWyceTg/e9u4/tPe//aQvgEzs/PhjSwQ
   +RBYHUiqf0Vp/RnCUMNghEQJbM5QrCcOCAs0D6QC4vfHESk9EIKzqyq2/
   pYd2v/N7vIMbkYYiO39Vc4u6YVCyslvcbQVNRkdh0MFSkWOdOROUJbe3q
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68270731
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:F/E5CKqcQbXPCsF62QHQwhDius9eBmL2ZRIvgKrLsJaIsI4StFCzt
 garIBnVO6zYMWX3eYtwaY6+8hsB6MeGmNc1SwY4qSFkESMX9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 YOq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBIYPQv+klSiBkIg5TD7xq25qfECCVrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZpDNmIwN02ojxtnIW84KLMXv8GSq3DOURNVthXE9LJu2j2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sfQmQvrVYRUE6e3ntZmjlScyW0UDBw+TkagrL+yjUvWc9VEM
 FAZ4TZrpKQ39UqDXtT7Rwe/onOPolgbQdU4O+8n7ACAzILE7gDfAXILJhZDYtE7sM49RRQxy
 0SE2djuAFRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf46TvTz1IesX2itn
 Xba90DSmon/k+YU+bmc8Gjeug6dibX7XyIWw13mBki6u1YRiJGeW6Sk7l3S7PBlJYmfT0Wcs
 HVsp/Vy/NziHrnWynXTHbxl8KWBoq/cbWaC2QIH84wJrWzFxpK1QWxHDNiSzm9NO91MRzLma
 VS7Veh5tM4KZyvCgUOajuuM5yUWIUrISIyNuhP8NIMmjn1NmOmvpnwGiam4hT2FraTUuftjU
 ap3iO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6nnk73jOfOOyHMEN/p1WdiiMhjsctoRy2Pr
 b5i2zaikU0DAIUSnAGJmWLsEbz6BSdiXs2nwyCmXuWCPhBnCAkc5wz5mtscl3het/0NzI/gp
 yjlMmcBkQaXrSCXeG2iNyE4AJuyDMkXkJ7OFXF1Vbpe8yN4OtjHAWZ2X8ZfQITLA8Q/laUkE
 KRfI5zo7zYmYm2vxgnxpKLV9eRKXB+qmRiPL2yiZj0+dIRnXAvH5pnveQ6HycXEJnPfWRcWy
 1F46j7mfA==
IronPort-HdrOrdr: A9a23:qtspq6rd5o4dZp3+4Ger8jkaV5vPL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ
 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGNXguNbnnxE426gYzxLrWJ9dOME/f
 Snl616T23KQwVoUi33PAhPY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX212oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iHnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMg4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegy2w
 2LCNUtqFh0dL5lUUtMPpZzfSKJMB25ffvtChPaHb21LtBOB5ryw6SHlIndotvaP6A18A==
X-IronPort-AV: E=Sophos;i="5.90,245,1643691600"; 
   d="scan'208";a="68270731"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c7X2wzsFGmAOjZxUDh5w+1JuCn46hI5ziFgjRci45m46hbCLoUCYzCpSus3asUXbqp9+Ima0xz7QB4XWB17U1fEyATCeB7rPAMXieDTAJ8vis7cgsnS/2yGJukfI8SDGUVvWL+d3ljUxPzBF1CwLVm5aWhRJnzR4HGhIS89R+ujQCSkc3h7VnS6eZql/XOS8ib4b+0V7M/cQP+gHQGi87Vsv/zSiICFBLJcRWK+lOjftnYczSI6ss7SgxLdZkrbkSlQHjU5LxlZDwa4N+53ehvM0PeNcoYZmpjDUT326+zRTF66OaccO5u/tB7GA/B18kkpONN9zBnKDcZg9ZYqpwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=20joXjWoCsFs/bgDV9BSrLGsWkq/pure/OzURUl4wXk=;
 b=h+uX2gbgJ2sM/n1yKCSW9fjA/Bcf6pIXWqlNUYKc180HV7WWSJqtMRccd8KY8Zskp9QIstJVSxGcrfwFofh/AZOCnvwJxI0onPlQltZIj3kwIOPNaTIOjH9EL4skAI0JtlWMkGQl33hfL12QWVMD7OfRr85ROzEtNEEJ/XFqHzGC2FEfPkup06fx54/blulTe+I5SXC7SzCqdh4s6oEflB9QLlXZPwNHIXG/gggaeXl3BY7m6xPKnj1lXYfl+eJzWr4us30B7lhC5Mv7QmQ0yhRjzdSUR0oG8J770v83J9FGL2arYQ6MLKVYG68t5f7UtwDrkhx/eir94HUmUUnIlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=20joXjWoCsFs/bgDV9BSrLGsWkq/pure/OzURUl4wXk=;
 b=XsVb1zlsbaBnghWeu1ofOXUaP4p70EFJ2mFbb3TY3QcsUyEmUTXm6lTCwhcdTVqO6PCxLOKZP9asqNUq0zqcrCyz+GlKImOwodHlM0NPkUq0/wkmZrusTkOaNPDPxNXr1idoSCHQazERte21/Zr86UmaaeHikVqeVGPfDqtGpGA=
Date: Fri, 8 Apr 2022 17:26:15 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>, <xen-devel@lists.xenproject.org>,
	"osstest service owner" <osstest-admin@xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Dario
 Faggioli" <dfaggioli@suse.com>
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Message-ID: <YlBUF0j8HEpRX8Hs@Air-de-Roger>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
 <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
 <YlAZhWVFziwoL0rb@Air-de-Roger>
 <41fe950e-cbc8-1da9-02d2-733c6fe4bb7a@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <41fe950e-cbc8-1da9-02d2-733c6fe4bb7a@xen.org>
X-ClientProxiedBy: LO4P123CA0194.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1643f93d-9336-4280-6e34-08da197421a5
X-MS-TrafficTypeDiagnostic: BYAPR03MB4072:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB407218459F0478739724EFAE8FE99@BYAPR03MB4072.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: uep5q3S939/N11PMDJoEKJgGIsClCuY8tKlJIA9B9cP7/XcjAzGfSH8kP4/2He8OR+Q+JYNaa1x1TvcShU3shpT4qa02WnZxrf8uYNo5xyicXUVICgn3FghYpwHGx5SqUDOd6XlPyVc1kQqa1dZAx8wvW4HycLGbGY0hMmgpJQQ/ng7aPg5jZ+9KIs3zzabba5mnH3dsjTU1N7DpwYcELalTuYeS1QuZSb6/QvAayPUysN6+XPYSkQqAjdUVpR2/6AygCZucNzor+YEAh9d2TYu01ZiVHo6/zhkhXcWIwme4VeqwY5QgPgFSbvnQYLcNleO5fGxAER0t0JhkLmu4BXIYtq9WB9nle0UnXCUN3CxoxMxM/HiD93mDjBzLnkL6a89KufhMAanOpwTyhQDaYR0re7YgdvhtvIvKW1oz+zUBnCvZeqEw8mQeJDm5y1UyqlynMVpu1LPHhxdfUKtNQiU72vdfIfkehBE5AxES0+QabqVAAD93ZkbWmVCBU6OPAk5Az2nWchKLtbFoZKCe8M2d9qWM1pjiuOt9YO0F5kbUNBEVYwzxy2MspcEV77uS2PoQc2o1SB++fgoJuPDIoS7evRrgKWhMRmSSYGpEb/5XUrqfUqGpcYE2Prv24MRYaxBCOuvY1ilS/ISPRpVOQA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(82960400001)(6486002)(508600001)(6916009)(54906003)(5660300002)(83380400001)(66556008)(66476007)(38100700002)(85182001)(2906002)(66946007)(8676002)(4326008)(86362001)(316002)(26005)(33716001)(53546011)(186003)(9686003)(6666004)(8936002)(6512007)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXVGSi9GU2taRjQ5SUVXeUlrdkJ1Q1lNQWUxekhsbktaZWE2UjdqTHNnaFZ3?=
 =?utf-8?B?MEREZ2NpWHZoSlZqcVB6bnRNRVBnZjBKQWp2KzVlalpWc0c4Q3ZCK0JuWDNp?=
 =?utf-8?B?bnIwR1c2ckhvV01wQ2RMSk9UTWc0MFhvUVQ0dmk5MTM2Rys2VkR3ZjZ0Y24z?=
 =?utf-8?B?VENZZHRtdC8vYzN6WEJOdVMrK1lURXRxV2RkaWpycWs1TW9Cc1R0Vno1b3ZE?=
 =?utf-8?B?K1RXcjd2Sk10VzFwN3ByS1lLSXVoYm1PMEhQT1I1Z3M5N0k1SDRyRDE4VWhG?=
 =?utf-8?B?aG1WT01zcE8wN3dZaXVnSFhkLzlic205dUtGUVFzNCswMjdyWWhiVUZNWGVq?=
 =?utf-8?B?djc1aU1pVE93TE5sMXZka01QVXEraGFhb0VQMGhLRVpqeVRmc3BKZUdvcXIw?=
 =?utf-8?B?ZG8zM0xBNTJGOThUZjZoRHRaOTdOSmFVNDZTMCtQOGY5L3FVS1hLZWxDTWFQ?=
 =?utf-8?B?bzNEMytVdDR3bC9hTDhTWWkvcEZJd0hGcDFndlMxNjJBUEVPN3RWSSt6WDlX?=
 =?utf-8?B?WFlnYmpGd0FvcERZRVQwaEEreWFicndoRnFNWWdmREhJdSt4SU8zUTlXRjhC?=
 =?utf-8?B?THBQMEVHTE9MZXJTcGRWUDc0QkN5ckcwV0RmZGNURUhoTXhUYjZFN055UGRH?=
 =?utf-8?B?MllaU09vS0oxSjh2QUh0cEEzTW52UHRaZ1Nxc3l5dmpaVEZZK04xUjFZUGEr?=
 =?utf-8?B?UTg5eFNTZ1lGWlhEaStQSVlVdXJMRVNvUnBvdzl1LzNWQTd2SElBQm1CYkRj?=
 =?utf-8?B?czNYVDh3QkV0VFVDSGxDQk9vQjBvc3JtM1VRdmZjT0hiYmpYRTZSTVI3Um1G?=
 =?utf-8?B?YWNaV21UYlZFMm53TkdwK0I0ODliM1lqVUNzOHIzb0UrY1pONlBpTER6c005?=
 =?utf-8?B?Q1FQSUt6QStrQ09TWmVQTk9yeE1oZ2lMSmVKbzAyR0hmYnBHY2JQZjRmZWZ5?=
 =?utf-8?B?d1FTOWpVYkFQUkpqNURCOTF0UFNJMm5IVkRUY0dwc1F5M1QrQWlrc1lUcXNZ?=
 =?utf-8?B?ZFZTN3FkdWd0S3BJOUVsVi96VkxTdUNuMU1MOEpIYVczSW54SG9NTzFBelY2?=
 =?utf-8?B?QkQ2eW5sMmZ5QjlUYmJaZGFiNEZTRjlxazJ5TEVScVZXRnBqOEtoOStaeHFu?=
 =?utf-8?B?WXRobEJlNTNoaXZEWjM1VzZEdGVOaFFSdTZkc1V5MW1XV21ZUzZsaWQydUg1?=
 =?utf-8?B?Vkx1UEM1dkd2M2t3RjVmUVEvVVQzZEJVUVBjSHMzMkpmZVJtL25Wcmo1aEhh?=
 =?utf-8?B?WlFTSExUQ0U5NER0dFYveitmTlpOL3RpajVpaWcwcUorWWtTaGNSS2F0Q0wz?=
 =?utf-8?B?SW9aY3M1VlB3NUFsNTFONDlEdG5Td3BRRG9Ydm5sSVh6V0xSRnNMUU5PK3ZU?=
 =?utf-8?B?TEVHd2lYRTJaWFJKaVdiVWpNRHd1VTJBTENjQStHVHZqSklPMmV4TUtLMkpn?=
 =?utf-8?B?OFNHNzBsUDZJTkR3TnRqRlFZRzhkZmE3aGJNZUdURVJTc3ZGOFlHZUlna3Nu?=
 =?utf-8?B?UlBQVTJleFcvTTJnNnVnaGd3MDhFSzJwRitoaElUQkNlQTh2Tjg3c0xTVFBF?=
 =?utf-8?B?dGFPbWJmV3oxTWhMWldkbnZYZXdaZkkva2dNZDRPUGtNcFFBTFhiYk9qSGti?=
 =?utf-8?B?Q2hjZHVodTJCSG9DelBvSkxYbFArYzAxYkg5bXdERHozTVdETGw3VWRON1R0?=
 =?utf-8?B?MVZQc1NuZlg5eE9VOTZMQ29NcVVRMFNONldmNWJ0ODBhWDBibm54VkVsUldV?=
 =?utf-8?B?YktZeFc4Z1R0TzRWTGdWTkt0TUUxTEV1eWplTld1MFFBQU5MNzVXQTMzb1RK?=
 =?utf-8?B?dUpFcFluQkdDaEN6eTRsdDlHQ0czU3d5cGowTVE5bFZaZUdESXZYc2xSS3hs?=
 =?utf-8?B?MjlYSTZicDJ6YXA1T01XOWdNdUcvQW5YR0VLVWpLd1dzNFh2V3dPR0NXeTBK?=
 =?utf-8?B?ei9lRmtYYUpBN3NveHB2UG1McDNPSzk1NXR0ZHpabFlHVlgwQkFnRVJkbW54?=
 =?utf-8?B?MkkzQllaK21EOEFrNFVoNFRCaHdaeW5tZnBOQ0lPcDJERzZycWpVYU9FcnNV?=
 =?utf-8?B?SFFwQUZJekM3NWtMclp5QjlKLzA1ZnM1cW9FSE9BZXZ0bGhZenNzTXV5d0Yv?=
 =?utf-8?B?ekZQN2ZnS1M4QjBnYWpIeWVpVUpKSkRXeThwbytTTjd1Z0lCV0FhblhXV0xz?=
 =?utf-8?B?S3I2SWltb2xNWHBVTFdLbHoyemxLSml6UURvY2pkZkVCQ3c1dHFEK1U3dkI1?=
 =?utf-8?B?akZmV2YwL0dGUm53TWRtU29XMHBlNU5YWGh0K3UrMlIvKzlBMVp3NEZKQ0oz?=
 =?utf-8?B?N1NyejJpTGlGV3VTQlBGRFpoWlFVUlRISitqUTR0L2Q1em9OTENsYkxRbWdU?=
 =?utf-8?Q?9mp/EYJWp62SthBE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1643f93d-9336-4280-6e34-08da197421a5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 15:26:19.9611
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1aJFgj9Pza5McsH/SR6shCxSBY+on1pIidZHPNF8A/8Kx+k+n4T4hN1/9fjy3kUW+YyrJnd4cj0VpuPAUyENmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4072
X-OriginatorOrg: citrix.com

On Fri, Apr 08, 2022 at 12:24:27PM +0100, Julien Grall wrote:
> Hi Roger,
> 
> On 08/04/2022 12:16, Roger Pau Monné wrote:
> > On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote:
> > > Hi,
> > > 
> > > On 08/04/2022 12:01, Roger Pau Monné wrote:
> > > > > > I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
> > > > > > uses 16 for example.
> > > > > 
> > > > > I'm afraid a fixed number won't do, the more that iirc there are
> > > > > systems with just a few cores in the pool (and you don't want to
> > > > > over-commit by default).
> > > > 
> > > > But this won't over commit, it would just assign dom0 16 vCPUs at
> > > > most, if the system has less than 16 vCPUs that's what would be
> > > > assigned to dom0.
> > > 
> > > AFAICT, this is not the case on Arm. If you ask 16 vCPUs, then you will get
> > > that number even if there are 8 pCPUs.
> > > 
> > > In fact, the documentation of dom0_max_vcpus suggests that the numbers of
> > > vCPUs can be more than the number of pCPUs.
> > 
> > It was my understanding that you could only achieve that by using the
> > min-max nomenclature, so in order to force 16 vCPUs always you would
> > have to use:
> > 
> > dom0_max_vcpus=16-16
> > 
> > Otherwise the usage of '_max_' in the option name is pointless, and it
> > should instead be dom0_vcpus.
> > 
> > Anyway, I could use:
> > 
> > dom0_max_vcpus=1-16
> > 
> > Which is unambiguous and should get us 1 vCPU at least, or 16vCPUs at
> > most.
> 
> Unfortunately, Arm doesn't support the min-max nomenclature.

Hm, can we update the command line document then?

There's no mention that the min-max nomenclature is only available to
x86. I assume it's not possible to share the logic here so that both
Arm and x86 parse the option in the same way?

> > 
> > But given Jans suggestion we might want to go for something more
> > complex?
> 
> I think we already have some knowledge about each HW (i.e. grub vs uboot) in
> Osstest. So I think it would be fine to extend the knowledge and add the
> number of CPUs.

We don't need to store this information anywhere I think. Since we
first install plain Debian and then install Xen we can always fetch
the number of physical CPUs when running plain Linux and use that to
calculate the amount to give to dom0?

Jan suggested using ceil(sqrt(nr_cpus)).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 15:34:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 15:34:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301622.514841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncqci-0000yb-4H; Fri, 08 Apr 2022 15:34:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301622.514841; Fri, 08 Apr 2022 15:34:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncqci-0000yU-1K; Fri, 08 Apr 2022 15:34:08 +0000
Received: by outflank-mailman (input) for mailman id 301622;
 Fri, 08 Apr 2022 15:34:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncqch-0000yK-0I; Fri, 08 Apr 2022 15:34:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncqcg-0005C7-Uh; Fri, 08 Apr 2022 15:34:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncqcg-0003NS-FS; Fri, 08 Apr 2022 15:34:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncqcg-0002z9-EX; Fri, 08 Apr 2022 15:34:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Bl+zQJlJnqcFsz4wZCV0aBXGvE4nKYegV0zFywM2wVk=; b=uFYx5jA6wdSnpKvUWpt729xEIN
	LA/NJrM7cfFxoFHPyeJsbxa9jrGye/f/l9cSKV+N4fsZ0jTN03vrLiAGAmdMNYUivWjGQyLsQYwl4
	SJwTC2VtAAhWWrAE7H2ImmnTjYXXB0IswPRgpCgVFhxeWddsgKclAfCUjQX+PUcMOw3w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169242-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169242: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 15:34:06 +0000

flight 169242 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169242/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   39 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  293 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 15:35:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 15:35:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301629.514853 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncqdV-0001WG-F9; Fri, 08 Apr 2022 15:34:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301629.514853; Fri, 08 Apr 2022 15:34:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncqdV-0001W9-C6; Fri, 08 Apr 2022 15:34:57 +0000
Received: by outflank-mailman (input) for mailman id 301629;
 Fri, 08 Apr 2022 15:34:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d3bc=US=citrix.com=prvs=090ff2996=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ncqdT-0001IV-2I
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 15:34:55 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f197b2a-b751-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 17:34:54 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f197b2a-b751-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649432093;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=XsBwR9IM+pr6MsWv/5so7RDZ99JVO48kd6S6+KN/TPU=;
  b=FLkj0n2QJrqNOVQvdJcNyHUF8TUic5UODJ4V9DRlocTrSE6XdZcZQe2W
   UEoZaK+SHn90XTH3i5zDhC+qqFK+fpxz92JuM3ANcSyqW3hdstKsjODp0
   Olh/3qvr96ck3YU/uU8b3XuSI1jsuSiZWNV0JRuDI6kmDs/KQCjGWaiCo
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68395549
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OEf6qaBeeyMqShVW/wnjw5YqxClBgxIJ4kV8jS/XYbTApDkr0zYFy
 TNKCmCGa/rYamb0eY1yaoS3oRwC6JLXnYRnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jh0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPg28
 tNNq8yAbDwsN4nFpqMDaRYJSStxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGjGxh250STJ4yY
 eI+awBsUj7/PyZhK1AUDokclqSswSnGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tkSRo
 G7c7nn6Kh4fPd2bjzGC9xqEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHAswaQ+SDe+ERGApwJTrN8uFrlJrfoDxixQVICTiARWPkdscYSTAJty
 GWGzonjCmk62FGKck61+rCRpDK0HCEaK24eeCMJJTc4D8nfTJIb1UyWEIs6eEKhppisQGyrn
 WjWxMQrr+9L5fPnwZlX6rwub9iEgpHSBjA46QzMNo5OxlMoPdX1D2BEBLWy0BqhEGp7ZgTZ1
 JTns5LHhAzrMX1rvHbQKAnqNOv0j8tpyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS
 BaN5VILtMIObCT1NPYfj2eN5yICl/WI+TPNDK68UzazSsIpKF/vEN9GOyZ8IFwBYGBzyPpia
 P93gO6nDGoACLQP8dZFb7x17FPf/QhnnTm7bcmil3yPiOPCDFbIGeZtGAbfNYgRsfLbyDg5B
 v4CbqNmPT0EC7agCsQWmKZORW03wY8TWcit+5MKLLbaSuekcUl4Y8LsLXoaU9UNt4xel/vS/
 2H7XUldyVHlgmbAJxnMYXdmAI4Dl74lxZ7nFUTA5WqV5kU=
IronPort-HdrOrdr: A9a23:74TVz6jakMSrw3xU5ltHr3Unn3BQXzh13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKOzOWxVdATbsSlrcKpgePJ8SQzJ8+6U
 4NSdkaNDS0NykHsS+Y2njILz9D+qj/zEnAv463pB0MPGJXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhMY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iGnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMw4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAkqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocbTbqjVQGZgoBT+q3tYpxqdS32AXTq+/blngS+pUoJgXfxn6ck7zU9HJFUcegx2w
 2LCNUsqFh0dL5kUUtMPpZwfSKJMB2+ffvtChPlHb21LtBPB5ryw6SHlYndotvaPKA18A==
X-IronPort-AV: E=Sophos;i="5.90,245,1643691600"; 
   d="scan'208";a="68395549"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mX9c/KEYwZSzgf1i2UI5t9w+XlF0tnKsPhZTD0wDaOo6zXrwKE8CiXcvQ3Y0GHp71HUI9XdFIakCaqe4MaXD8/kUbg6zZJ03+I6byznGHrHe2hdZ6bcu4PCISWC1IIhM/be51R61oPmOu91Ig+1WAbGwnoERHLp6a2+jdcLZxzkZaNCL6nd7XVxp77noTwQ/dXOYp7f3GBCmdVN79RFlfsOAmLODY9O2eTF8Q6rrIRw7tiJPOQYcyIB0zf5hdFWWdr8u/pR8TA/DBmoiNtMwE7ducKo6N1IC8RXurvnQpJYJR4rS01LbjYX5BM2YoeWYmTq7JBrauCu2cpwxy0lvPQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DJN07v4BYiGlw6dV5abG68LwUphAwtTST69GxUOUivU=;
 b=Ae6+uuVs81LHAYtXCFSTcYah2h0pXyIxXzSgieg95eVA2ipJY9Jb8ATGOrw9jgabPSqfst5GRgDKgNOzmk4o3cOP2wJWMyVIeSPpsBap5NvqhQJXrgyg7TxERX6djP9h3tKbpw5/kWvzPaeg/yp/fZjnsz2DhL/YQtMAheS+tBTE9F7jnHvmk+rqIQwvLx8WN/EgtS87bogPTkzUz8XV5CJUlNy8bZzHa7xK5LM02g6OvWba+L8G8HCpS/Nvh6iOoO7CAAQVEHomBv8zSs73lBnzp1X0mXwABPhBrEuvlVwgrZmbcEYaOXTfqG5RtRsMjo5tEeNSkziwibDhbR0mCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DJN07v4BYiGlw6dV5abG68LwUphAwtTST69GxUOUivU=;
 b=Nf/H1MyVlifBt/CmijPM4yHWiTNyJoEgPT2o3uj4sMe70bPQ+2L/Ikbc0bTEbJdKkJWLNMpJs8C+GUwD85vG8UJV0L5Pb7ymDnVo8cNGgAD7iyjTAT1RjnNKznjBMeFAM8YFSHdO7rt5eTl2qRct2CzypVy9/6lLiZN0IqX+n/E=
Date: Fri, 8 Apr 2022 17:34:43 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Jason Andryuk
	<jandryuk@gmail.com>
Subject: Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction
Message-ID: <YlBWE8W9HV+zwMWj@Air-de-Roger>
References: <20220407145150.18732-1-jandryuk@gmail.com>
 <YlAYMrirDQUz8u49@Air-de-Roger>
 <b1478c94-3289-7fb9-5d92-84a2803388af@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b1478c94-3289-7fb9-5d92-84a2803388af@suse.com>
X-ClientProxiedBy: LO4P123CA0187.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3dd3cff9-e225-4210-9c84-08da197550f3
X-MS-TrafficTypeDiagnostic: BN9PR03MB6060:EE_
X-Microsoft-Antispam-PRVS: <BN9PR03MB606037A0B02DF6B5BCA4670C8FE99@BN9PR03MB6060.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: I2GtCBlkSHLLYEdxM1umosDrRckGR5as8JLRQxJPuGbpnDJ0MxgDOkXh44v9CQ46JiGIFY52MG28PL8N/EDKttLsypEazzySxortH6yJohhDSvKyCzSpkj383Ljv+A7uRYJxV3yxbec8e/ghvOVvn5OqlDIx1uR+EWNir4qv91bV65q3TrN6k1O3pK8DIEM2WCS5qSDC+q+HfW/7Wv7e9MpTw1U3mQf7tgK6il/KJsLswlVS0xwqd5311/MK9qFp1Mab/I61ewhSuZhTrfwGhgiOnPzOP/8+Vy6t7t4Bqg6iOtIQ9s1s6+nTUvtAg1iWa9lPWDalDcQTua8Xkstn+flOZ/7qdNjg8obcjEnAsRl3ywyysPeyhno3OaAEvJrjUzAPKBgWw7rqQkzVqgcdAwCVF04gRqYS/EWu9y12lcJpUgX+zvpHJGm1YF7fhHAZM/xotN81C8iS9273b3Wofl+dYqFAsLJdhnoy5wqCN7I3+lgRU4VqhpeLrtgBhbhHIwerIv1iA8/3eo8KsZnY3cSHQRfY+TGAe/ec2rM5P648BHo6k9whG+D7EFlnjaxt8HNeAB5cT/XR4jtdi47oOvh/fZevFE3xzpL4Micb0TCDjj3aP2tNb+IPDNjYrjVDXb9jtuH8acs5biHgHbTHHLylPKMWxjLqegLrqvWprHqt9r8kTjaH1jnB//WHDgsGhsqbXCMnkNW6GqMr4LacjQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(5660300002)(6506007)(508600001)(66556008)(66946007)(66476007)(4326008)(6512007)(86362001)(26005)(38100700002)(83380400001)(186003)(6666004)(9686003)(53546011)(33716001)(2906002)(82960400001)(85182001)(54906003)(316002)(6916009)(6486002)(8936002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2VENUVVdjd3bTIzWG9GZHFvRXk2WHpDcXRQd1BoSVlVYXVVNDl5b0s1L2E2?=
 =?utf-8?B?Z2lEU3hXWWtSVThZd3lISStZTU10Q0hUL1RHQlU1em02SnJuOEk4K3N0TUNn?=
 =?utf-8?B?S25pbU9scGJ1MDlMclRQeHBGMllYVlNqU21pY1IrTUxHTkgvSkxwNjJzR0pq?=
 =?utf-8?B?QVJJWEUxY25CZzdtQkNDZUlNMThSZ0FITnZ6M3d4T0w1TFI2NEhkVHliRllL?=
 =?utf-8?B?cHhsSFI5ZU42b3c0VHNLaHcydVlRc0tyTUU1TklyQVUxUEVwZjVLbVFZeGs5?=
 =?utf-8?B?ZjRFdkFRUVFPckpDUTJGMS9JbWVlVDJXMFBFWFZ2RFlUSUY0T2UyNFpVOHJJ?=
 =?utf-8?B?R1ZwOVoreVZSaGZzWWxnN1d6ZUIvNWpIaERPbzQrbDJMVnMzbjhkNG9qdEhx?=
 =?utf-8?B?ZS8weG5JSzhUcnJwWWZOUzl5b2RudFhQd1FYODJCZ0NwMkJrMGNwWUxBUEZC?=
 =?utf-8?B?czV1cDlYa3p6N2pmWlN5U2RZWDRXWDRoUktrdFBkRWh1ZXFSSjhPUHNGNnhO?=
 =?utf-8?B?U2JTc0JJUlhlVGMrbHV3UXhZQWdFQjBPUmdRUFhLT3EzYTU5SCtwVEp3ZWpB?=
 =?utf-8?B?VXJIc3ExSkNMUHd5SmV2MUx3NG5MdEM2Y1RSb2xmZm91SVJkTUVWTzI5QWZX?=
 =?utf-8?B?SFlSUTU4eFgwaFBhU2xxNkFmS2J0YWVOeXR4NEd6dU9tY1poRTI2UjM5R2Qx?=
 =?utf-8?B?Q0JrdG1yOWM1S2lzcHgzZmc4UTljYjRpVGZQeGcxeVkxb1Y2MGVIaG54ZVE0?=
 =?utf-8?B?eDZndVhnVlVaQUF1TndZVldRNnVIQ2JpdzhRRVAvRFQ5dTFabWJKb2xBNnpX?=
 =?utf-8?B?NmZ3amlpdCtXeS8yNERWUVU0eXJ5d1JmOTlqZEp3QktiWUMwZXF4MDFjUzdo?=
 =?utf-8?B?S1hDZDJTYlFzclA0YlduTGtzTWlXLy9NVUJnK1VXWFIxVmozOXFuNWlsNTV0?=
 =?utf-8?B?YzFqYmNFUS9WcmtJNm9ZaWIwUGc3bkFYQlgzY1BYQmNidXFhL05BQ0d2N0lK?=
 =?utf-8?B?NUlHU09MMGFSSDdEVmgwazBtK1Q0NzV4THhNYUh0eG1RbFlHc0phZHM5OFVN?=
 =?utf-8?B?TlQ1KzFyRC9MaUFQYm1KV3ZYdlRPNXoxQmx4M24yN2lpNWwvVWFROVBQb3I4?=
 =?utf-8?B?WlNHYzhxcXdLV2lIYzdLQjI2Z3IwbDU0blFyZXY2YkFRSjVFeUhJSjhISkhN?=
 =?utf-8?B?RlJnd2Jtak03bm02VGVVOVdyUzczTjY5bmcxT1MydE1pVFhoTUpJdkhGazdL?=
 =?utf-8?B?ZFBYeDNsQVN5d1lycU91Y2ZyOVM5ODNsT0gyVlp2Q2E3V2tRaEJ2U1pSSXhx?=
 =?utf-8?B?REtWaDU5bkpIaFAvNHdHTEN5cGhnWFp5Vkh6VHErOFVTa28rQXl0ODYrQkl2?=
 =?utf-8?B?MEYyZldNM083eHpaSGlSeVV0ZDl3RHNQM2hWeWpSK2JHV2I1OTRqOTNFMWZI?=
 =?utf-8?B?UmhVdTJXb2dEV3ZjTGhtRnJoV0o3VFFWaGpybzV2N1RoWWFlQjhrZUJrdG5n?=
 =?utf-8?B?U2ZDb0h5anAzckN4MU9Ybml2Y3pzdTJmcEhrTHZZVVpiOWN1SUM0cEw5ZkRJ?=
 =?utf-8?B?ci9VeTNmTTJoTEVsRnB1QllWUVRva1hDY0JGUC9GTlFxTGNEVGpDMEpiUmJB?=
 =?utf-8?B?b2g0UGRlUGVMcnZQNjRCVnkrZm1zM3ZTQmh4QXF1MVNZaWl5Yy9FVzRSUFFI?=
 =?utf-8?B?VlhRZGl4Y2NHcFZKSDRGMFMzSUIwNkw3Vm5DMlFaUWE4OXdUcW53aC9uYUtI?=
 =?utf-8?B?cEFERG1uY3ZJaXZIV1JXbkVibmRBTmpZdnhwQ3BrV21IdzRaeUV3MVJTTnRR?=
 =?utf-8?B?RnhhblZBNTNhTk9GUTFGUVZ5ZVFuTUdQRmJQNktNOGpjZ0NQdEFFY0d3NXZn?=
 =?utf-8?B?Z2dndWtBNno4a2VFOHprMXBjNFBjSjhpRkNKSWRLNThQNjhLSWt2NGJVS1NI?=
 =?utf-8?B?aURJSHdwck1rYWVLYmlBTnp6TnJReGdhWUFkYnpBU3N1b3lmVys2MTZubE04?=
 =?utf-8?B?K1MrclJ5V2RVMUFVaGd1RE15YTFDdGtZZzRCTFR5TGlnSXRnZWN2Zmk3S1Rr?=
 =?utf-8?B?TTJOZ1didGQvbVRabjdTcWNtemxMT0NXR085ZUtZUlIwcDBqclBNV3Q1UkRH?=
 =?utf-8?B?OFJCTWRFbXFqUVh0NFhJbkUvamh3cU9TZGtIaTI1aFQzTVBjNktQWEZzbjRM?=
 =?utf-8?B?WHhGdThWNmxhVXNSbVJvcjcxR2VSbm5zMU5OcTgvLzJwMmVjOHU4QmRVN0Mw?=
 =?utf-8?B?SGZOOGtXUnJmZGdOUkdJeGoyVEh3T3dQdzhQVGMyditNSDY2NllvU1dkRWRT?=
 =?utf-8?B?RVM4SVdJM1Y5dlVsNkdkYytmM0FWRmU3SmVsbE0yWEhyUktXbnIzYXR5SXVU?=
 =?utf-8?Q?aT3r1N5+wv76Yhps=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dd3cff9-e225-4210-9c84-08da197550f3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 15:34:48.8387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8c9i9DHjRUxSAsXIM4y5oEmko843a9rjPaj1SbUe2cJ0mP2PxveMhvucEHeXu1ISdz+rPyi1nZ+Yspr9K+lnMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6060
X-OriginatorOrg: citrix.com

On Fri, Apr 08, 2022 at 02:04:56PM +0200, Jan Beulich wrote:
> On 08.04.2022 13:10, Roger Pau Monné wrote:
> > On Thu, Apr 07, 2022 at 10:51:50AM -0400, Jason Andryuk wrote:
> >> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
> >> complete_domain_destroy as an RCU callback.  The source context was an
> >> unexpected, random domain.  Since this is a xen-internal operation,
> >> going through the XSM hook is inapproriate.
> >>
> >> Check d->is_dying and skip the XSM hook when set since this is a cleanup
> >> operation for a domain being destroyed.
> >>
> >> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> >> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> >> ---
> >> v2:
> >> Style fixes
> >> Rely on ret=0 initialization
> >>
> >> ---
> >>  xen/arch/x86/irq.c | 10 ++++++++--
> >>  1 file changed, 8 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
> >> index 285ac399fb..de30ee7779 100644
> >> --- a/xen/arch/x86/irq.c
> >> +++ b/xen/arch/x86/irq.c
> >> @@ -2340,8 +2340,14 @@ int unmap_domain_pirq(struct domain *d, int pirq)
> >>          nr = msi_desc->msi.nvec;
> >>      }
> >>  
> >> -    ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
> >> -                               msi_desc ? msi_desc->dev : NULL);
> >> +    /*
> >> +     * When called by complete_domain_destroy via RCU, current is a random
> >> +     * domain.  Skip the XSM check since this is a Xen-initiated action.
> >> +     */
> >> +    if ( !d->is_dying )
> >> +        ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
> >> +                                   msi_desc ? msi_desc->dev : NULL);
> >> +
> > 
> > Nit: I would remove the extra space here, but that's a question of
> > taste...

Er, sorry, s/space/newline/.

> Which extra space are you referring to? The only candidate I can spot
> are the two adjacent spaces in the comment, between the two sentences.
> But that's several lines up. And I think we have examples of both
> single and double spaces in the code base for such cases. I know I'm
> not even consistent myself in this regard - the longer a comment gets,
> the more likely I am to use two spaces between sentences.
> 
> > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> > 
> > I wonder if long term we could make this cleaner, maybe by moving the
> > unbind so it always happen in the context of the caller of the destroy
> > hypercall instead of in the RCU context?
> 
> This would be nice, but when I looked at this long ago it didn't seem
> straightforward to achieve.

Right, I don't doubt it.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 16:06:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 16:06:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301668.514882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncr7X-0007Ak-EE; Fri, 08 Apr 2022 16:05:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301668.514882; Fri, 08 Apr 2022 16:05:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncr7X-0007Ad-9e; Fri, 08 Apr 2022 16:05:59 +0000
Received: by outflank-mailman (input) for mailman id 301668;
 Fri, 08 Apr 2022 16:05:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DXVu=US=citrix.com=prvs=090e341e7=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ncr7W-0007AX-CC
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 16:05:58 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c51433db-b755-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 18:05:56 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c51433db-b755-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649433956;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=OnsSgoG8TneszAt4weG2faBw+7vVCykxV8DnvwCjI9k=;
  b=A7FUtbOiZlULSbSvO16y7Pg9UylwnuYyR5TV/EdYrnq/f9/sLDS0MxKJ
   Tc9gcO5+mg2D4lqTxzTQ7pTxfa2tJEJQpOlnAGRt7n4c/RsuT9mx5OlbB
   BVmlJt1ai7UlFNB140vUtGDio+SqFOlwCdwhaHzgUxEZ229AKpYxKcp0G
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68274931
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TXhMAqkclAyX33xhOKCYDh3o5gzoJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXDW+GP/aLZmujKth+YITg/BgAvpKDzNFqQVFr+CA1HiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1PV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYQloiO/X+trohWDJ6Mxx9N6JPu4bZLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHOWAwMEWbOnWjPH8nJrIbkOaCiEDHYhxqoVOemqY452bMmVkZPL/Fb4OOJ43iqd9utlmcj
 nLL+SL+GB5yHMySz3+J/2yhgsfLnDjnQ8QCGbug7PlojVaPgGsJB3UruUCT+KfjzBTkApQGd
 hJSqnFGQbUOGFKDRYT2WkWKjiC4tTU+e+dTGeIzqziTxf+Bi+qGPVQsQjlEYd0gkcY5Qz02y
 1OE9+/U6SxTXK69EizEqOrNxd+mEW1MdDJZO3dYJecQy4O7yLzfmC4jWTqK/ESdqtTuUQ/9z
 DmRxMTVr+VC1JVbv0lXEL2uvt5NmnQrZlNtjuk0djj8hu+cWGJDT9b1gbQ8xawdRLt1tnHb4
 BA5dzG2tYji962lmi2XW/kqF7q0/fuDOzC0qQcxQ8h7p2nwqyH8JNk4DNRCyKFBaJtsldjBO
 hG7hO+szMULYCvCgVFfPepd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs/F2Oo
 4kCbZPTo/idOcWnChTqHUcoBQhiBRAG6Vre9KS7qsbrztJaJVwc
IronPort-HdrOrdr: A9a23:0YeH4KOQjj4Yv8BcTgujsMiBIKoaSvp037BL7TEVdfUxSKGlfq
 +V88jzuSWbtN9pYgBFpTnYAtjmfZq+z+8W3WByB9uftWDd0QPDEGgF1+rfKlXbcBEWndQttp
 uIHZIfNDUlZWIK9PoT/2GDYqgdKMjuytHPuQ/Bp00dNT2CYZsQkDuRcjzraXGfGWF9dOAE/I
 L13Ls7m9K6EU5nEviGOg==
X-IronPort-AV: E=Sophos;i="5.90,245,1643691600"; 
   d="scan'208";a="68274931"
Date: Fri, 8 Apr 2022 17:05:51 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/xl: fix vif and vcpupin parse tests
Message-ID: <YlBdX71RcEZ/IzwW@perard.uk.xensource.com>
References: <20220408133146.48117-1-roger.pau@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220408133146.48117-1-roger.pau@citrix.com>

On Fri, Apr 08, 2022 at 03:31:46PM +0200, Roger Pau Monne wrote:
> Current vif and vcpupin parse tests are out of sync.  First of all, xl
> returns 1 on failure, so replace the expected error code.
> 
> Secondly fix the expected output from some vif tests, as xl will no
> longer print the unpopulated fields.
> 
> Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

> ---
> We should find a way for those tests to be run as part of osstest, or
> else they will go stale again sooner or later.

I guess having those two tests case in "tools/tests/" would be better,
then having osstest runs all tests in "tools/tests/" might be the way to
go.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 16:12:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 16:12:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301674.514893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncrDE-0000Op-2F; Fri, 08 Apr 2022 16:11:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301674.514893; Fri, 08 Apr 2022 16:11:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncrDD-0000Oi-VL; Fri, 08 Apr 2022 16:11:51 +0000
Received: by outflank-mailman (input) for mailman id 301674;
 Fri, 08 Apr 2022 16:11:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OHy9=US=citrix.com=prvs=090a3f169=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ncrDC-0000Oc-3H
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 16:11:50 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 96ef65e0-b756-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 18:11:48 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96ef65e0-b756-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649434308;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=5OMeak4hfaNzOmfDzZPjGqMl6ofgNZCXLnCiqHXqFrg=;
  b=Rztd8Iwvw970WgJw4ScR46q7wDMXNfUuFzmS9qao2AIJynYhxVa+kzE7
   sUoDWRx8zJjqT/62Hpm4858vnLLskAn1nbtev5+P087q74hBQybT5x0ie
   NTcsRujbidloCD8eaq1tOQfbqx0uxg11IbixBDZGhEJatG02XJUcmu9BW
   w=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68383440
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5diG5K6TwM5k5TMD1x9N8gxRtM3HchMFZxGqfqrLsTDasY5as4F+v
 jYfXGyCO6mCMTD8f9glb9jn8UxS7Z/cx4Q1HQI4/31jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YThU1vX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurTrEFYQEKbml98hVj1fHRx7YpJi2efYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RJMmo0MEiYC/FJElAqNZ8shuuXv2vEUzpHk0OY+K4y+WeGmWSd15CyaYGIK7RmX/59hV2Er
 2jL+2D4BBAyN9GFzzeBtHW2iYfngifTSI8UUrqi+ZZCjFOayWMSDxkXfUCmuvT/gUm7M/pYM
 FcI9zEy6KE+8U2tZsnwWQWip3yJtQJaXMBfe8U49QWMx6z88wufQG8eQVZpatYrqcs3TjwCz
 UKSkpXiAjkHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXryos1LSfDvyIevQHepn
 m7M/HNWa6gvYdAjjPzqxH7MqT2Xmp3tSQAI41roekP98VYsDGK6XLCA5V/e5PdGCY+WSFido
 XQJ8/SjAPAy4YKlz3LUHrhUdF29z7PcaWCH3wYzd3U03271k0NPa7y8992XyK1BFs8fMQHkb
 0bI0e+6zM8CZSD6BUObjm/YNijL8UQCPYm9Phw3RoAXCnSUSONh1HszDaJ39zqw+HXAaYllZ
 f+mnT+EVB7285hPwjusXPs62rQ23C04zm67bcmlk0X9gefDNCHKEO5t3L6yggYRtv7sTOL9q
 Yg3Cid3408HDL2Wjtf/r+b/0mzm3VBkXMur+qS7h8aIIxZ8GXFJNhMi6ehJRmCRpIwMzr2g1
 ijkAidwkQOj7VWaeVTiQi0yM9vHAMcgxU/XyARxZD5ELVB4Ot3xhEreHrNqFYQaGBtLkaYvH
 6ZYIZ3ZahmNIxyekwkggVDGhNUKXDyghB6UPjrjZz46fpV6QBfO9MOidQzqnBTixALu3Sfii
 9VMDj/mfKc=
IronPort-HdrOrdr: A9a23:DA7kkKO52UPx/MBcT2H155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjzjSWE9Ar4WBkb6LS90DHpewKTyXcH2/hvAV7EZnimhILIFvAs0WKG+Vzd8kLFh5ZgPM
 tbAspD4ZjLfCVHZKXBkUmF+rQbsaK6GcmT7I+0pRoMPGJXguNbnn1E426gYxdLrWJ9dP0E/e
 +nl7N6Tk2bCBIqh6qAdxw4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ssl
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGYFq/QpF5d1H2mxa1+
 UkkC1QefibLEmhJ11dlCGdnzUIFgxes0MKh2Xo2kcL6vaJOg7SQ/Ax9L6xNCGptnbI9esMo5
 6ilQiixupqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+S
 hVfbbhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyIeFOwC1zwdLkHqbrVn8ki
X-IronPort-AV: E=Sophos;i="5.90,245,1643691600"; 
   d="scan'208";a="68383440"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UNYFKV9w6GL2ZrzHkrJwzbzUcQUZOpn+UBKECUgEN4W34qHBn8fkorfkRNMYM7cYjdeT7DATLZSObh1eh+2PXLi35n9jz+4opQ4k/EsDTAUiy1b/Nr5nOxeecj+52FCNoQCqyAkPx8sea8GVLFmqxu3m/FIUpm0JexuEJQ2FjKUo0BpZBIptoRF3gxWb/8N8DlBnow4l8no/mudZE1f9eCb3eSd83RgiYFjVgbKWKck8Y7uuhyCDhM9Occ69vhK76PWo1NM1RbTT2p3pMvSnBIQ1MfUC/i+yuJDEEl5DbAMN5451/By7YxNtJ6/4ijq56ZY1ZAYrRer0H1AUEFZHgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5OMeak4hfaNzOmfDzZPjGqMl6ofgNZCXLnCiqHXqFrg=;
 b=SlUJCZ+yn6mxtDk6NmxBNWXpgwlJFMQX1bwgED5GXtEp62gbzzPCrqPbPDMRP7GtoTkZ0QKJKANamwiq013Vn7mfcHDxuV0jO0VdLuKF7PrFJrz8e01OzDAiI+v0nTnTg6tYcU4qM51r53ACxzcfIEBPtoVAcSE+C5EKM0az8ZRK2Qn0F7L07jKMxJpC7CmpOL5dDCNUhb9iuwvLIR9r6VNyEl9WG8ANC0Qx9xRQLXoPHmQwMPGP9DdvHWPEJEsarDeY3o5wIKQZmhbGdeOzM7gIcR6MHNG4pgs11BYz75+/iELqrQKny2/7wpbWQuNbZTB0KerU7XXBXh3yd7xUxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5OMeak4hfaNzOmfDzZPjGqMl6ofgNZCXLnCiqHXqFrg=;
 b=vfz5tDZ9ITO5fi8r5hZv43di9D4Ad3q9tkdlQBZSXfGibdXuhrzmb6/PEpYv8aBNXdsxfExE39QMTz13odhusDyFYLQHlCTPP0opdd3TWPG05w/yUA28vyn8F/YC5NxE4Vp3XyqaNFR4NRODPSMHhVxd/a3am14/97Idnvcj5Bg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, osstest service owner
	<osstest-admin@xenproject.org>, George Dunlap <George.Dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Dario
 Faggioli" <dfaggioli@suse.com>
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
Thread-Topic: [xen-4.12-testing test] 169199: regressions - FAIL
Thread-Index: AQHYSlvwuwuenWmolE2vvQwyk4J/36zlmCOAgAATLgCAABUiAIAAGtAAgAAB2ACAAAJTgIAAAkOAgABDj4CAAAyygA==
Date: Fri, 8 Apr 2022 16:11:41 +0000
Message-ID: <e12ad0f2-b37f-e5f9-33c8-e7a5898b1384@citrix.com>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
 <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
 <YlAZhWVFziwoL0rb@Air-de-Roger>
 <41fe950e-cbc8-1da9-02d2-733c6fe4bb7a@xen.org>
 <YlBUF0j8HEpRX8Hs@Air-de-Roger>
In-Reply-To: <YlBUF0j8HEpRX8Hs@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b74d2820-0ded-4732-655e-08da197a7840
x-ms-traffictypediagnostic: DM5PR03MB2665:EE_
x-microsoft-antispam-prvs: <DM5PR03MB2665420D8B041128C8589706BAE99@DM5PR03MB2665.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: E/bdO1HF3EkA2Kk5MMKzcaXiv368fSB30YfWVfecq78ogv9Inw0L+ZXAu2rrqZTJxkOwDbSiy6Mjw8uqUlypLZ+IV2EyF4KuAC1+a/VTPq9os70Yo+11+Gs83tRyag34A4DzI5mrRYEaDFSzMfF238Jl1QCZmuiUUsRVUL3uhkNbEGmlMD3kV4E2xa4qBQd0bPkQA1E9HmQ/D42jF0Y+7uyK64qmL1LaCWGYewebK9ctvjU2rzI6gBYaPDGOHU+fz6YzQpKyVykMr79eQtbxAxgqaHhv+XRTZf5ohVdBor5LH2RxXUcueDtBM2eS/1kItsyK1RWxF+s/dVvlFwtbekacjkVWVgWFEAqAWWLrVG8qPlBHgYhXLzz2ow8317QpMOKBaVW3ZjByTuelzewuTqOScoAdIn0bLlxF4K7EHy2iL9YgzA/MTmUiWLg4MFt4xujCRaLIaQgyV+ltzScelPQEKGLIOA1TrzWWFWBAdr/j2iuzehrDBaflLmd/6ilQmkolcrPDmC97AMAP1s4Wt0PucQn7uwhGNGXpgHOIkLv0hRuylz5W4JWIOdzTm9z//FAI/Wy/SgTPWIOVGj30cs+sp54iOsFmT62ZZJcB1bFMv3NZNLeVUGk3F1a2/cf2uN9I+wp3EWOEyprUxWer5DG8DKY3EaC5/SC0KBrcWmTTMv4kLXXwiOyz7j4hQBkh3BC/sOykGsmKgHvx7pFMEdjKjWPyLDfcd/cDUPJat4+08/GF9T/BVMWtLS1hRKhHv0DQoWSsKGxD+6UGZLkb9w==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(66446008)(66946007)(91956017)(76116006)(86362001)(38070700005)(66556008)(186003)(26005)(53546011)(6506007)(316002)(508600001)(6512007)(4326008)(66476007)(64756008)(2906002)(82960400001)(54906003)(38100700002)(36756003)(2616005)(31686004)(5660300002)(83380400001)(122000001)(31696002)(8936002)(110136005)(71200400001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WUxEcUpEaTB3R3VCVlN1Q3pNR3RsUlpEcUZOL3JuVytXd2RwRXM0bVlwcjkr?=
 =?utf-8?B?QjBrM29ZcjRFZ00wR08xSWdNSEpxQjFmNGE2NVhaalhHZ093TlRzalE2MURw?=
 =?utf-8?B?Q0pDei9QeG9JbmJHZnQ0UDFlRXBURmYzMTlMbVppQW83S1JtcGJMT2VLTXhm?=
 =?utf-8?B?QTFIZUV2QTU0aXFUb1lsTUhzTTErOGhlbXZOTUV1ZEVYTFJxREY3RzM2Vjlk?=
 =?utf-8?B?dlFoOHhkNWkxdk40a2FXWVBKaFhaZnFnZm4vSVlheDVRWnBSQjZPdUo5V01M?=
 =?utf-8?B?eUVrLzJiV3JkN040SE0vc01udGR5cFBESWE4U3VhdmxpL1dsbk5OWUFQWnRF?=
 =?utf-8?B?YzFPdjFUU2hvaDdFM2E4VVhlZGlNSXVLTFNUNzRpcStUTlluOXdTUjNZYjBs?=
 =?utf-8?B?eUcwWVp4dDFQV3gxU3VPVkhtNndzTFpheFFxMzdkUXFJb29hTFNWZDEwaThS?=
 =?utf-8?B?bEwxVXVQaGR3bzFKcGR3RU9TSWpUTXl5bk05azFoR2hqNGIwbUQvbzZGcWJa?=
 =?utf-8?B?WDhHM2wxcGorU3FuU096MlcrQzFxZGNneWFJdnNQOFdhcWZiUnRRL0oyTzFX?=
 =?utf-8?B?dkRUQjR4aHViN1dHQytXejdLQVhOL2lCUVpoZks0dTRzNG5WWkJ1U25VeE1L?=
 =?utf-8?B?ekltRnV6WlZGc0tpTStudlhWaFBQMVRIZ3dwcTN5eVVpMW1qcUdoVlVsUS9E?=
 =?utf-8?B?aEErYW1xcmVDd2U0czRaVlE0ZHpqOGNGTzRxVXpYRXpySTNwNkpUYlVsWnRS?=
 =?utf-8?B?ZjM3Y1prdFJwNUlPWVpXWFk2SG03T2g2Um44L3FDeUFaL21UaHJibXp2VkVO?=
 =?utf-8?B?YlVyaUQ2ZjRWaW9zYUtMUnZFTUMwcG4vbjJnajBzU0dmR0l5Nm14dXZrd3F5?=
 =?utf-8?B?bWxrRHdBTVB6cjFQNHhjM3FuSHBuZ0x4czRxNGhsRE9UM0U3cllKZTMwM284?=
 =?utf-8?B?dWxTMXNPUVNlZHdPV3lZZGFzZ2RJRmE5eTJqdzJPdU9uYUthUkt6YnFGNVly?=
 =?utf-8?B?UzY2WTFSb2w2OHF5ekwrWmRxOGljNFliRmRjMjAycE4rb05tQjFEN0FXQU9M?=
 =?utf-8?B?SEU3aCt6cTUvYTdoMnMySDlMQkNldGo2NHV0bnRXT01CVTVveEpNZUgrUUEy?=
 =?utf-8?B?cURWSHphTWJpSUVXVEpkaFRuMlFhVW5oZzd1L0ZuV29ZRjIrcEVUSmVBODR3?=
 =?utf-8?B?Z1cvNTFjQ2xtdmJMUGY5WnRpWVNWRXVtNmRscjd4d2I5b1locFF6UzN5RGVW?=
 =?utf-8?B?NWhBTWFmR0hNalFtVjVHbVdJQURoWGlwbnk5WCtqWVlSSEkwQi85MytNdm5p?=
 =?utf-8?B?VE5HcDE1QmFhbFU4VkFCdWhRMGllbXoxTjJnS0o5TGZzZy9kQW1qaDMwZXE3?=
 =?utf-8?B?emxEWFIzSlpOc1VCMEF2VjdwYk80aDU3OWJJMmtPZ1BSVDZPKzAvbDdPdDNC?=
 =?utf-8?B?OE9VVnhuUzU3RGh4djEzR0pGSWd4dG5PTHdwL1pqSlgra3FnZ0QvdEVlQUxW?=
 =?utf-8?B?RG8rb0RJRGxmM2JrSlIyNnNYNGhQcE9tOURzSG1Zcm9HMUcwN1ZXVmFkQ2s1?=
 =?utf-8?B?d1ZHMEg3ZzRLRHVWK0NDckcxWDlyNTB1VjdvWUpyV2QzV0JtaC9OcDNDK0wr?=
 =?utf-8?B?c3VBOHNLUGJGMjJ1TkdrWE93Q0FiNllMdy91YU05ODNielJGU21mdkk1dmZX?=
 =?utf-8?B?VWRLQnAvRTJ1T01Lam0zakhqSjQ2b2xEb2gzTjFjZko2R3JWNXZ5dlpUd2tT?=
 =?utf-8?B?NEQ4V1Z5ZnNIa1FWQU9iMDBPTndKblJ2OWxaYU4renVRS1IxcktMMUVxVm5W?=
 =?utf-8?B?ZTIwdTdLdkNmbVJPVGVZVHlzZUF3RlBUOHp0aEZMOFUwMlF4SC9kbWU0Mjho?=
 =?utf-8?B?YTBOUE9TV2IyK2dUMUp0Wll3OFQ0NkRRb3ZIc0swYnRnQzlNenVtUUo3MWZu?=
 =?utf-8?B?blRiQjl1eEFGMXpBZEpzbkV2Ym0yQVJqZUhCSno5ZHlNOFpaNnpLNlRXYkdS?=
 =?utf-8?B?bzdVNG5Ja08veld3NXJQdVB1OHlGdXpka3RGWG9uV3g0QVJxZUx2Tk0xZDZk?=
 =?utf-8?B?b1pKVVdPcVgvU25pWU5DN2dvRlliekNobm1IeHQraFJySEV1b0VMUitQcEEy?=
 =?utf-8?B?NE9mclRDMGVzR1dXZWE5YVFjR291Wng0TUNueXg2cWhrdWNEaERld3pNV1po?=
 =?utf-8?B?Lzdvd0R5TDczbXpVN0V2TEZDNHR4YmNna1hseExCYjhNdTNFVEpGc1E4TzRh?=
 =?utf-8?B?MndWSW9heUlPWHBtLyt3YTRaaDJyTnVUY2RzUDBGejNaandCVGs4VmtEZlZm?=
 =?utf-8?B?di91eVVFMkFkYkxJM0xtNWpwTGJGK0MxYVhKTFlIMTExKzk0SDRuZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <82F9E3F884961D47B5E69C5A37BE5BE5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b74d2820-0ded-4732-655e-08da197a7840
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 16:11:41.9599
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: O2BahW6N8KkkjeEnR/G5UwZxXmN4zonTYNfgHz/EFlRiqeFXMfDPhFc3hWY3LuvQrRdTEPYvBREAmjVJa89m8l9103S4Z+WhBmnCZ+g1u1o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2665
X-OriginatorOrg: citrix.com

T24gMDgvMDQvMjAyMiAxNjoyNiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBPbiBGcmksIEFw
ciAwOCwgMjAyMiBhdCAxMjoyNDoyN1BNICswMTAwLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+PiBI
aSBSb2dlciwNCj4+DQo+PiBPbiAwOC8wNC8yMDIyIDEyOjE2LCBSb2dlciBQYXUgTW9ubsOpIHdy
b3RlOg0KPj4+IE9uIEZyaSwgQXByIDA4LCAyMDIyIGF0IDEyOjA4OjAyUE0gKzAxMDAsIEp1bGll
biBHcmFsbCB3cm90ZToNCj4+Pj4gSGksDQo+Pj4+DQo+Pj4+IE9uIDA4LzA0LzIwMjIgMTI6MDEs
IFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+Pj4+IEkgY291bGQgYWRkIGEgc3VpdGFibGUg
ZG9tMF9tYXhfdmNwdXMgcGFyYW1ldGVyIHRvIG9zc3Rlc3QuICBYZW5TZXJ2ZXINCj4+Pj4+Pj4g
dXNlcyAxNiBmb3IgZXhhbXBsZS4NCj4+Pj4+PiBJJ20gYWZyYWlkIGEgZml4ZWQgbnVtYmVyIHdv
bid0IGRvLCB0aGUgbW9yZSB0aGF0IGlpcmMgdGhlcmUgYXJlDQo+Pj4+Pj4gc3lzdGVtcyB3aXRo
IGp1c3QgYSBmZXcgY29yZXMgaW4gdGhlIHBvb2wgKGFuZCB5b3UgZG9uJ3Qgd2FudCB0bw0KPj4+
Pj4+IG92ZXItY29tbWl0IGJ5IGRlZmF1bHQpLg0KPj4+Pj4gQnV0IHRoaXMgd29uJ3Qgb3ZlciBj
b21taXQsIGl0IHdvdWxkIGp1c3QgYXNzaWduIGRvbTAgMTYgdkNQVXMgYXQNCj4+Pj4+IG1vc3Qs
IGlmIHRoZSBzeXN0ZW0gaGFzIGxlc3MgdGhhbiAxNiB2Q1BVcyB0aGF0J3Mgd2hhdCB3b3VsZCBi
ZQ0KPj4+Pj4gYXNzaWduZWQgdG8gZG9tMC4NCj4+Pj4gQUZBSUNULCB0aGlzIGlzIG5vdCB0aGUg
Y2FzZSBvbiBBcm0uIElmIHlvdSBhc2sgMTYgdkNQVXMsIHRoZW4geW91IHdpbGwgZ2V0DQo+Pj4+
IHRoYXQgbnVtYmVyIGV2ZW4gaWYgdGhlcmUgYXJlIDggcENQVXMuDQo+Pj4+DQo+Pj4+IEluIGZh
Y3QsIHRoZSBkb2N1bWVudGF0aW9uIG9mIGRvbTBfbWF4X3ZjcHVzIHN1Z2dlc3RzIHRoYXQgdGhl
IG51bWJlcnMgb2YNCj4+Pj4gdkNQVXMgY2FuIGJlIG1vcmUgdGhhbiB0aGUgbnVtYmVyIG9mIHBD
UFVzLg0KPj4+IEl0IHdhcyBteSB1bmRlcnN0YW5kaW5nIHRoYXQgeW91IGNvdWxkIG9ubHkgYWNo
aWV2ZSB0aGF0IGJ5IHVzaW5nIHRoZQ0KPj4+IG1pbi1tYXggbm9tZW5jbGF0dXJlLCBzbyBpbiBv
cmRlciB0byBmb3JjZSAxNiB2Q1BVcyBhbHdheXMgeW91IHdvdWxkDQo+Pj4gaGF2ZSB0byB1c2U6
DQo+Pj4NCj4+PiBkb20wX21heF92Y3B1cz0xNi0xNg0KPj4+DQo+Pj4gT3RoZXJ3aXNlIHRoZSB1
c2FnZSBvZiAnX21heF8nIGluIHRoZSBvcHRpb24gbmFtZSBpcyBwb2ludGxlc3MsIGFuZCBpdA0K
Pj4+IHNob3VsZCBpbnN0ZWFkIGJlIGRvbTBfdmNwdXMuDQo+Pj4NCj4+PiBBbnl3YXksIEkgY291
bGQgdXNlOg0KPj4+DQo+Pj4gZG9tMF9tYXhfdmNwdXM9MS0xNg0KPj4+DQo+Pj4gV2hpY2ggaXMg
dW5hbWJpZ3VvdXMgYW5kIHNob3VsZCBnZXQgdXMgMSB2Q1BVIGF0IGxlYXN0LCBvciAxNnZDUFVz
IGF0DQo+Pj4gbW9zdC4NCj4+IFVuZm9ydHVuYXRlbHksIEFybSBkb2Vzbid0IHN1cHBvcnQgdGhl
IG1pbi1tYXggbm9tZW5jbGF0dXJlLg0KPiBIbSwgY2FuIHdlIHVwZGF0ZSB0aGUgY29tbWFuZCBs
aW5lIGRvY3VtZW50IHRoZW4/DQo+DQo+IFRoZXJlJ3Mgbm8gbWVudGlvbiB0aGF0IHRoZSBtaW4t
bWF4IG5vbWVuY2xhdHVyZSBpcyBvbmx5IGF2YWlsYWJsZSB0bw0KPiB4ODYuIEkgYXNzdW1lIGl0
J3Mgbm90IHBvc3NpYmxlIHRvIHNoYXJlIHRoZSBsb2dpYyBoZXJlIHNvIHRoYXQgYm90aA0KPiBB
cm0gYW5kIHg4NiBwYXJzZSB0aGUgb3B0aW9uIGluIHRoZSBzYW1lIHdheT8NCg0KVEJILCB0aGlz
IGVzcGVjaWFsbHkgd2FudHMgbW92aW5nIHRvIGNvbW1vbiBjb2RlLsKgIEl0J3MgYXRyb2Npb3Vz
IFVYIHRvDQpoYXZlIHBlci1hcmNoIHZhcmlhdGlvbnMgb24gdGhlIHN5bnRheCBmb3IgImhvdyBt
YW55IHZjcHVzIi4NCg0KPj4+IEJ1dCBnaXZlbiBKYW5zIHN1Z2dlc3Rpb24gd2UgbWlnaHQgd2Fu
dCB0byBnbyBmb3Igc29tZXRoaW5nIG1vcmUNCj4+PiBjb21wbGV4Pw0KPj4gSSB0aGluayB3ZSBh
bHJlYWR5IGhhdmUgc29tZSBrbm93bGVkZ2UgYWJvdXQgZWFjaCBIVyAoaS5lLiBncnViIHZzIHVi
b290KSBpbg0KPj4gT3NzdGVzdC4gU28gSSB0aGluayBpdCB3b3VsZCBiZSBmaW5lIHRvIGV4dGVu
ZCB0aGUga25vd2xlZGdlIGFuZCBhZGQgdGhlDQo+PiBudW1iZXIgb2YgQ1BVcy4NCj4gV2UgZG9u
J3QgbmVlZCB0byBzdG9yZSB0aGlzIGluZm9ybWF0aW9uIGFueXdoZXJlIEkgdGhpbmsuIFNpbmNl
IHdlDQo+IGZpcnN0IGluc3RhbGwgcGxhaW4gRGViaWFuIGFuZCB0aGVuIGluc3RhbGwgWGVuIHdl
IGNhbiBhbHdheXMgZmV0Y2gNCj4gdGhlIG51bWJlciBvZiBwaHlzaWNhbCBDUFVzIHdoZW4gcnVu
bmluZyBwbGFpbiBMaW51eCBhbmQgdXNlIHRoYXQgdG8NCj4gY2FsY3VsYXRlIHRoZSBhbW91bnQg
dG8gZ2l2ZSB0byBkb20wPw0KPg0KPiBKYW4gc3VnZ2VzdGVkIHVzaW5nIGNlaWwoc3FydChucl9j
cHVzKSkuDQoNCkknbSBnb2luZyB0byBwbGF5IGRldmlscyBhZHZvY2F0ZSBoZXJlLg0KDQpPdXIg
Q0kgc3lzdGVtIGhhZCBkZW1vbnN0cmF0ZWQgdGhhdCB0aGUgZGVmYXVsdCBiZWhhdmlvdXIgaW4g
WGVuIGlzDQpicm9rZW4uwqAgQW5kIHdlJ3JlIHNheWluZyAibGV0cyBib2RnZSBhcm91bmQgaXQg
aW4gdGhlIENJIHN5c3RlbSB0byBub3QNCnVzZSB0aGUgZGVmYXVsdCBiZWhhdmlvdXIiLg0KDQoN
ClRoZSBvbmx5IHVzZXItZnJpZW5kbHkgd2F5IG9mIHJlc29sdmluZyB0aGlzIGlzIHRvIGZpeCB0
aGUgZGVmYXVsdCBhbmQNCmxlYXZlIHRoZSBDSSBhbG9uZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 16:25:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 16:25:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301680.514904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncrQi-0002Mn-8a; Fri, 08 Apr 2022 16:25:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301680.514904; Fri, 08 Apr 2022 16:25:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncrQi-0002Mg-5G; Fri, 08 Apr 2022 16:25:48 +0000
Received: by outflank-mailman (input) for mailman id 301680;
 Fri, 08 Apr 2022 16:25:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncrQg-0002MW-SZ; Fri, 08 Apr 2022 16:25:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncrQg-0006bl-Q2; Fri, 08 Apr 2022 16:25:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncrQg-0005S0-FR; Fri, 08 Apr 2022 16:25:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncrQg-0007aQ-Ev; Fri, 08 Apr 2022 16:25:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fv0qkFIy7NNWJfZC6npKGJsmllsw3ZKYAbmUxMyFe7I=; b=XXuG/F5vrqEkmCEFESoCLpqqeE
	bgmenkvWN1u7FuK+TMRFzrvS+uSx4gAdr/59RQIifsD5s0WVCCtPU0fb/JzcSPcdGi+4MkauGUG4u
	pYze5lmhPD7rZGquLffXq6Gl7wW84bY2ZajQtAB2eDqlT6M/vDpzrEJF+wGV6VKxuWZ4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169236-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169236: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2e6f95a942d1927a53f077c301db0b799c54c05a
X-Osstest-Versions-That:
    xen=9120b5737f517fe9d2a3936c38d3a2211630323b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 16:25:46 +0000

flight 169236 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169236/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2e6f95a942d1927a53f077c301db0b799c54c05a
baseline version:
 xen                  9120b5737f517fe9d2a3936c38d3a2211630323b

Last test of basis   169231  2022-04-08 09:00:28 Z    0 days
Testing same since   169236  2022-04-08 13:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9120b5737f..2e6f95a942  2e6f95a942d1927a53f077c301db0b799c54c05a -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 16:26:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 16:26:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301687.514914 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncrRK-0002sF-Ic; Fri, 08 Apr 2022 16:26:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301687.514914; Fri, 08 Apr 2022 16:26:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncrRK-0002s8-Fl; Fri, 08 Apr 2022 16:26:26 +0000
Received: by outflank-mailman (input) for mailman id 301687;
 Fri, 08 Apr 2022 16:26:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncrRI-0002rd-Vk
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 16:26:25 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a1beba3b-b758-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 18:26:24 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 7EE78B82C01;
 Fri,  8 Apr 2022 16:26:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5728C385A3;
 Fri,  8 Apr 2022 16:26:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1beba3b-b758-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649435182;
	bh=tWYTaAaLnPcszS3FdrfrSfNwkM7cVtKruxx5Vq4g+vE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Mz4ohBp7+wuCxJLvKXmf7jkNiM5/gNf2FzWTTvblCib1JedymAKI+xUBS6NB4Iqgj
	 Te5Zj9v1mqOC9CyLmQ7GX4K+wctahr7yTZWKDz7zgcwJ/DrpvVoOIIz64oOBQZk10/
	 HxCE5hwlUWjx+Kmdwnw123eXmQDxEXHP+U1Z5lcAMU0I4lS9j2laDx+lXM+Db0GhI1
	 IripqReMHLWwysuz8Y1zuEleruIuudAwa27S56UiieEx3eKOwmyFPs9jkqYZUhHNQx
	 PFMaA+DUa9YhbYtqN2n2KQp4EesG98VKY8Nn9C60CBngHJBqforl2BCyz8RfaoI9tr
	 8TrF0fQ7P1QfA==
Date: Fri, 8 Apr 2022 09:26:20 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
cc: Roger Pau Monne <roger.pau@citrix.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    osstest service owner <osstest-admin@xenproject.org>, 
    George Dunlap <George.Dunlap@citrix.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
    Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
In-Reply-To: <e12ad0f2-b37f-e5f9-33c8-e7a5898b1384@citrix.com>
Message-ID: <alpine.DEB.2.22.394.2204080924400.2910984@ubuntu-linux-20-04-desktop>
References: <osstest-169199-mainreport@xen.org> <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com> <Yk/tzuKq4D3mFEQu@Air-de-Roger> <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com> <YlAWBom8O8d1lCpQ@Air-de-Roger> <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
 <YlAZhWVFziwoL0rb@Air-de-Roger> <41fe950e-cbc8-1da9-02d2-733c6fe4bb7a@xen.org> <YlBUF0j8HEpRX8Hs@Air-de-Roger> <e12ad0f2-b37f-e5f9-33c8-e7a5898b1384@citrix.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1631907031-1649435182=:2910984"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1631907031-1649435182=:2910984
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Fri, 8 Apr 2022, Andrew Cooper wrote:
> On 08/04/2022 16:26, Roger Pau Monne wrote:
> > On Fri, Apr 08, 2022 at 12:24:27PM +0100, Julien Grall wrote:
> >> Hi Roger,
> >>
> >> On 08/04/2022 12:16, Roger Pau Monné wrote:
> >>> On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote:
> >>>> Hi,
> >>>>
> >>>> On 08/04/2022 12:01, Roger Pau Monné wrote:
> >>>>>>> I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
> >>>>>>> uses 16 for example.
> >>>>>> I'm afraid a fixed number won't do, the more that iirc there are
> >>>>>> systems with just a few cores in the pool (and you don't want to
> >>>>>> over-commit by default).
> >>>>> But this won't over commit, it would just assign dom0 16 vCPUs at
> >>>>> most, if the system has less than 16 vCPUs that's what would be
> >>>>> assigned to dom0.
> >>>> AFAICT, this is not the case on Arm. If you ask 16 vCPUs, then you will get
> >>>> that number even if there are 8 pCPUs.
> >>>>
> >>>> In fact, the documentation of dom0_max_vcpus suggests that the numbers of
> >>>> vCPUs can be more than the number of pCPUs.
> >>> It was my understanding that you could only achieve that by using the
> >>> min-max nomenclature, so in order to force 16 vCPUs always you would
> >>> have to use:
> >>>
> >>> dom0_max_vcpus=16-16
> >>>
> >>> Otherwise the usage of '_max_' in the option name is pointless, and it
> >>> should instead be dom0_vcpus.
> >>>
> >>> Anyway, I could use:
> >>>
> >>> dom0_max_vcpus=1-16
> >>>
> >>> Which is unambiguous and should get us 1 vCPU at least, or 16vCPUs at
> >>> most.
> >> Unfortunately, Arm doesn't support the min-max nomenclature.
> > Hm, can we update the command line document then?
> >
> > There's no mention that the min-max nomenclature is only available to
> > x86. I assume it's not possible to share the logic here so that both
> > Arm and x86 parse the option in the same way?
> 
> TBH, this especially wants moving to common code.  It's atrocious UX to
> have per-arch variations on the syntax for "how many vcpus".

In my view, it would be OK to share the code, but I would also want to
retain the current behavior when e.g. dom0_max_vcpus=2 is specified.
Otherwise we break existing ARM tooling. (It is actually used by Yocto
and others.)
--8323329-1631907031-1649435182=:2910984--


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 17:08:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 17:08:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301699.514926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncs5q-0008IB-So; Fri, 08 Apr 2022 17:08:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301699.514926; Fri, 08 Apr 2022 17:08:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncs5q-0008I4-Ol; Fri, 08 Apr 2022 17:08:18 +0000
Received: by outflank-mailman (input) for mailman id 301699;
 Fri, 08 Apr 2022 17:08:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncs5p-0008Hu-V1; Fri, 08 Apr 2022 17:08:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncs5p-0007Jj-TC; Fri, 08 Apr 2022 17:08:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncs5p-0007Rz-LC; Fri, 08 Apr 2022 17:08:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncs5p-000521-KM; Fri, 08 Apr 2022 17:08:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+r35rRTsfnmUokpsDapXccQirUCMtPXtirVQhDYEwsc=; b=nyUL4HtlpGNMdgirFzAm2bhL85
	kaU9Rcpquc73bjvNunp+xF9PTbCaQ7rn/79TJWwUONVAqvXZN2UXErOAWUFYVOgN3KsB/FzXmhDVp
	wgXz9lbguHxJwwuwh/eNDssk6N6J3eUfx+J1yYSFWmi1NhXeDNanTPSu4FucMuWvsEtI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169247-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169247: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 17:08:17 +0000

flight 169247 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169247/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   39 days
Failing since        168258  2022-03-01 01:55:31 Z   38 days  294 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 17:17:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 17:17:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301709.514937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsEW-0001Q5-Od; Fri, 08 Apr 2022 17:17:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301709.514937; Fri, 08 Apr 2022 17:17:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsEW-0001Py-Le; Fri, 08 Apr 2022 17:17:16 +0000
Received: by outflank-mailman (input) for mailman id 301709;
 Fri, 08 Apr 2022 17:17:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncsEU-0001Ps-PH
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 17:17:14 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsER-0007TY-Oy; Fri, 08 Apr 2022 17:17:11 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsER-0008VI-Ie; Fri, 08 Apr 2022 17:17:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=gPBSk+MugYwReZloyZfoZ9xwzZZ4Gb0ZuG3/5p/ix8E=; b=f08zShVfgA/Y9gYtjFtnoNpNKh
	E/FQunVxfpRok4lf06jbzRI4BEftxnHlGWhmwO4J1L0p9NoYqhNNNwEqy4dQvEtKy2knzJHGKs2d8
	53BwnD/TPbqV/9saRK6SueD+9tRx57lUFxq/121b+9qew7LBiXH9RhaN6uCdTUbn+cA0=;
Message-ID: <decf721a-8062-a23f-a810-78fb86a42d1d@xen.org>
Date: Fri, 8 Apr 2022 18:17:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
 <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
 <3217803e-16d5-6e2a-bde7-ff9a1237dd39@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <3217803e-16d5-6e2a-bde7-ff9a1237dd39@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 08/04/2022 13:25, Jan Beulich wrote:
> On 08.04.2022 13:02, Julien Grall wrote:
>> On 08/04/2022 08:16, Jan Beulich wrote:
>>> See the code comment. The higher the rate of vCPU-s migrating across
>>> pCPU-s, the less useful this attempted optimization actually is. With
>>> credit2 the migration rate looks to be unduly high even on mostly idle
>>> systems, and hence on large systems lock contention here isn't very
>>> difficult to observe.
>>
>> "high" and "large" is quite vague. Do you have more details on where you
>> observed this issue and the improvement after this patch?
> 
> I have no data beyond the observation on the failed 4.12 osstest flights,
> where I mentioned I would make such a patch and send out as RFC.

Ok. I think a pointer to the failed 4.12 osstest would be good here.

> 
>>> --- a/xen/common/event_channel.c
>>> +++ b/xen/common/event_channel.c
>>> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>>>        unsigned int port;
>>>        struct evtchn *chn;
>>>    
>>> +    /*
>>> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
>>> +     * vCPU-s they're to be delivered to run on. In order to limit lock
>>> +     * contention, check for an empty list prior to acquiring the lock. In the
>>> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
>>> +     * until the vCPU is migrated (again) to another pCPU.
>>> +     */
>>
>> AFAIU, the downside is another pCPU (and therefore vCPU) will get
>> disturbed by the interrupt.
> 
> But only rarely, i.e. in case a race would actually have occurred.

Maybe I am too paranoid here. The other side of race is controlled by a 
domain. So wouldn't it be possible to increase how often the race is hit?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 17:19:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 17:19:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301714.514948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsGj-000247-5v; Fri, 08 Apr 2022 17:19:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301714.514948; Fri, 08 Apr 2022 17:19:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsGj-000240-25; Fri, 08 Apr 2022 17:19:33 +0000
Received: by outflank-mailman (input) for mailman id 301714;
 Fri, 08 Apr 2022 17:19:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncsGh-00023u-B7
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 17:19:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsGe-0007VH-SL; Fri, 08 Apr 2022 17:19:28 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsGe-00008Y-MB; Fri, 08 Apr 2022 17:19:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Qn3UzhhlOvXOZ1ANcSgA5LBCniAwrX0PiTAcl9iakWM=; b=3vEU047UpQWjx3i28xVWMqfIfB
	GgkA9FD5mcuDcxIlTkOyICKb6BSfCHzYWj2QmicZgV2pq8qKTgeaYHSsxesOuJlGC8M1tJJ8NcsZV
	v5rjZ4s8jQAVfEltNL96cdtxW52ob9iI+KFJ9DORjzznXgBfk7hvrgItqmACgQD0wGxw=;
Message-ID: <b8b62b5f-a643-2624-fa57-ad42d315b39e@xen.org>
Date: Fri, 8 Apr 2022 18:19:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v3] SUPPORT.md: add Dom0less as Supported
To: Henry Wang <Henry.Wang@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>
References: <alpine.DEB.2.22.394.2204071706470.2910984@ubuntu-linux-20-04-desktop>
 <PA4PR08MB6253660FF724000CFCD7A8C192E99@PA4PR08MB6253.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <PA4PR08MB6253660FF724000CFCD7A8C192E99@PA4PR08MB6253.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 08/04/2022 01:50, Henry Wang wrote:
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
>> Stefano Stabellini
>> Sent: Friday, April 8, 2022 8:11 AM
>> To: xen-devel@lists.xenproject.org
>> Cc: sstabellini@kernel.org; julien@xen.org; andrew.cooper3@citrix.com;
>> george.dunlap@citrix.com; jbeulich@suse.com; wl@xen.org
>> Subject: [PATCH v3] SUPPORT.md: add Dom0less as Supported
>>
>> Add Dom0less to SUPPORT.md to clarify its support status. The feature is
>> mature enough and small enough to make it security supported.
>>
>> Clarify that dom0less DomUs memory is not scrubbed at boot when
>> bootscrub=on or bootscrub=off are passed as Xen command line parameters,
>> and no XSAs will be issued for that.
>>
>> Also see XSA-372: 371347c5b64da and fd5dc41ceaed.
>>
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> ---
>> Changes in v3:
>> - improve commit messahe
> 
> For the patch I don't have any comments, but I think here we've got
> a typo: s/messahe/message. I think it is ok to fix while committing this
> patch so this is just a kind reminder :))

Anything after --- will be stripped by git am. So there is nothing to 
fix it on commit.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 17:24:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 17:24:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301719.514958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsLS-0003cE-OY; Fri, 08 Apr 2022 17:24:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301719.514958; Fri, 08 Apr 2022 17:24:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsLS-0003c7-Ld; Fri, 08 Apr 2022 17:24:26 +0000
Received: by outflank-mailman (input) for mailman id 301719;
 Fri, 08 Apr 2022 17:24:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncsLR-0003c1-Iz
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 17:24:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsLQ-0007ah-Mh; Fri, 08 Apr 2022 17:24:24 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsLQ-0000VC-Gv; Fri, 08 Apr 2022 17:24:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cZKIsOh8usOIMQnUhdiePQniy7HY4ZZBbtAP+Jccb4k=; b=UhddpBsZlTsw/d/PAAYCBg0ahS
	50mWcMYcxHo3gqGCNblAXXEJAGu+TzZJfQG7ylI8e80tLpEy2NGth0vpsREnwjejkzoeGd5kOeTF9
	mv8XM70d96ZCSaxhH5qEsD0NyMaSeIg/X0BjRCqhQy1bEvxwyWYtG3ncDW9DE732N/gw=;
Message-ID: <6c6c14a1-a070-0afe-fafd-0d219febb0d1@xen.org>
Date: Fri, 8 Apr 2022 18:24:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v3] SUPPORT.md: add Dom0less as Supported
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org
References: <alpine.DEB.2.22.394.2204071706470.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204071706470.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 08/04/2022 01:10, Stefano Stabellini wrote:
> Add Dom0less to SUPPORT.md to clarify its support status. The feature is
> mature enough and small enough to make it security supported.
> 
> Clarify that dom0less DomUs memory is not scrubbed at boot when
> bootscrub=on or bootscrub=off are passed as Xen command line parameters,
> and no XSAs will be issued for that.
> 
> Also see XSA-372: 371347c5b64da and fd5dc41ceaed.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>


Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 17:38:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 17:38:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301724.514970 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsZ3-0005er-0S; Fri, 08 Apr 2022 17:38:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301724.514970; Fri, 08 Apr 2022 17:38:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsZ2-0005ek-TA; Fri, 08 Apr 2022 17:38:28 +0000
Received: by outflank-mailman (input) for mailman id 301724;
 Fri, 08 Apr 2022 17:38:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncsZ1-0005ea-FB; Fri, 08 Apr 2022 17:38:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncsZ1-0007oy-6x; Fri, 08 Apr 2022 17:38:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncsZ0-0000OR-UA; Fri, 08 Apr 2022 17:38:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncsZ0-00036s-TQ; Fri, 08 Apr 2022 17:38:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YwXA5SoCXHdQXpz3CHw3opEgmn2Qc9BU2KyLKp68E+o=; b=cK2srsEh15A+Ae1+uDoSgFYo2b
	gblofD5KacY7fD+35PVN+/lURRebfoCP/mR6n5p4+aogRSWhDU2OLoqBwWew7ZirOgaFahzmxyH1s
	yQQEUJKGuCH404FU6n+wiOxXmW5HMQXK7/enmicUh3BiX5ptAzkXTPGpmGOpAyAnmjV4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169228-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169228: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1831fed559732b132aef0ea8261ac77e73f7eadf
X-Osstest-Versions-That:
    linux=3123109284176b1532874591f7c81f3837bbdc17
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 17:38:26 +0000

flight 169228 linux-linus real [real]
flight 169246 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169228/
http://logs.test-lab.xenproject.org/osstest/logs/169246/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 169174

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 169174

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169174
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169174
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169174
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169174
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                1831fed559732b132aef0ea8261ac77e73f7eadf
baseline version:
 linux                3123109284176b1532874591f7c81f3837bbdc17

Last test of basis   169174  2022-04-05 08:27:06 Z    3 days
Failing since        169188  2022-04-05 21:41:40 Z    2 days    4 attempts
Testing same since   169228  2022-04-08 07:16:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Conole <aconole@redhat.com>
  Alan Liu <HaoPing.Liu@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alex Hung <alex.hung@amd.com>
  Alexander Lobakin <alexandr.lobakin@intel.com>
  Alexei Starovoitov <ast@kernel.org>
  Alice Michael <alice.michael@intel.com>
  Alok Prasad <palok@marvell.com>
  Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>
  Andrea Parri (Microsoft) <parri.andrea@gmail.com>
  Andrew Lunn <andrew@lunn.ch>
  Andy Chiu <andy.chiu@sifive.com>
  Andy Gospodarek <gospo@broadcom.com>
  Ariel Elior <aelior@marvell.com>
  Arthur Fabre <afabre@cloudflare.com>
  Aurabindo Pillai <aurabindo.pillai@amd.com>
  Benjamin Marty <info@benjaminmarty.ch>
  Bjorn Helgaas <bhelgaas@google.com>
  Boqun Feng <boqun.feng@gmail.com>
  Borislav Petkov <bp@suse.de>
  Boyuan Zhang <boyuan.zhang@amd.com>
  CHANDAN VURDIGERE NATARAJ <chandan.vurdigerenataraj@amd.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen-Yu Tsai <wens@csie.org>
  Chiawen Huang <chiawen.huang@amd.com>
  Chris Park <Chris.Park@amd.com>
  Christian König <christian.koenig@amd.com>
  Christian König <ckoenig.leichtzumerken@gmail.com>
  Christian Lamparter <chunkeey@gmail.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Mack <daniel@zonque.org>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Airlie <airlied@redhat.com>
  David Ahern <dsahern@kernel.org>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Delyan Kratunov <delyank@fb.com>
  Dimitris Michailidis <d.michailidis@fungible.com>
  Dimitris Michailidis <dmichail@fungible.com>
  Divya Shikre <DivyaUday.Shikre@amd.com>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eli Cohen <elic@nvidia.com>
  Emily Deng <Emily.Deng@amd.com>
  Eric Bernstein <eric.bernstein@amd.com>
  Eric Dumazet <edumazet@google.com>
  Ethan Lien <ethanlien@synology.com>
  Eyal Birger <eyal.birger@gmail.com>
  Felix Kuehling <Felix.Kuehling@amd.com>
  Florian Westphal <fw@strlen.de>
  Gabe Teeger <gabe.teeger@amd.com>
  Guchun Chen <guchun.chen@amd.com>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Haowen Bai <baihaowen@meizu.com>
  Harry Wentland <harry.wentland@amd.com>
  Horatiu Vultur <horatiu.vultur@microchip.com>
  Huang Rui <ray.huang@amd.com>
  Ilias Apalodimas <ilias.apalodimas@linaro.org>
  Ilya Maximets <i.maximets@ovn.org>
  Ivan Vecera <ivecera@redhat.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamie Bainbridge <jamie.bainbridge@gmail.com>
  Jan Varho <jan.varho@gmail.com>
  Jann Horn <jannh@google.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Ekstrand <jason@jlekstrand.net>
  Jason Wang <jasowang@redhat.com>
  Jean-Philippe Brucker <jean-philippe@linaro.org>
  Jeremy Sowden <jeremy@azazel.net>
  Jesper Dangaard Brouer <brouer@redhat.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jimmy Kizito <Jimmy.Kizito@amd.com>
  Jiri Olsa <jolsa@kernel.org>
  Johannes Thumshirn <johannes.thumshirn@wdc.com>
  Josef Bacik <josef@toxicpanda.com>
  José Expósito <jose.exposito89@gmail.com>
  Kaiwen Hu <kevinhu@synology.com>
  Karol Herbst <kherbst@redhat.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Lang Yu <Lang.Yu@amd.com>
  Lee Jones <lee.jones@linaro.org>
  Leo (Hanghong) Ma <hanghong.ma@amd.com>
  Leo Ruan <tingquan.ruan@cn.bosch.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Ying <victor.liu@nxp.com>
  Luiz Angelo Daros de Luca <luizluca@gmail.com>
  Ma Jun <Jun.Ma2@amd.com>
  Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Manish Chopra <manishc@marvell.com>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marcin Kozlowski <marcinguy@gmail.com>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Jonas <mark.jonas@de.bosch.com>
  Martin Habets <habetsm.xilinx@gmail.com>
  Martin KaFai Lau <kafai@fb.com>
  Martin Leung <Martin.Leung@amd.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Matt Johnston <matt@codeconstruct.com.au>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Maxime Ripard <maxime@cerno.tech>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Kelley <mikelley@microsoft.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Walle <michael@walle.cc>
  Neelima Krishnan <neelima.krishnan@intel.com>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Nikolay Aleksandrov <razor@blackwall.org>
  Noralf Trønnes <noralf@tronnes.org>
  Oliver Logush <oliver.logush@amd.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paolo Abeni <pabeni@redhat.com>
  Paul Kocialkowski <paul.kocialkowski@bootlin.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Paulo Alcantara <pc@cjr.nz>
  Pavan Chebbi <pavan.chebbi@broadcom.com>
  Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
  Philipp Zabel <p.zabel@pengutronix.de>
  Prabhakar Kushwaha <pkushwaha@marvell.com>
  Prike Liang <Prike.Liang@amd.com>
  Qingqing Zhuo <qingqing.zhuo@amd.com>
  QintaoShen <unSimple1993@163.com>
  Qu Wenruo <wqu@suse.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ray Jui <ray.jui@broadcom.com>
  Rob Herring <robh@kernel.org>
  Robin Murphy <robin.murphy@arm.com>
  Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
  Roman Gushchin <roman.gushchin@linux.dev>
  Roman Li <Roman.Li@amd.com>
  Ruili Ji <ruiliji2@amd.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Shirish S <shirish.s@amd.com>
  Shwetha Nagaraju <shwetha.nagaraju@intel.com>
  Stanley.Yang <Stanley.Yang@amd.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Taehee Yoo <ap420073@gmail.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tianci Yin <tianci.yin@amd.com>
  tiancyin <tianci.yin@amd.com>
  Tom Chung <chiahsuan.chung@amd.com>
  Tom Rix <trix@redhat.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tushar Patel <tushar.patel@amd.com>
  Vasily Averin <vasily.averin@linux.dev>
  Vasily Averin <vvs@openvz.org>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wei Liu <wei.liu@kernel.org>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>
  Yifan Zhang <yifan1.zhang@amd.com>
  Yonghong Song <yhs@fb.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4812 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 17:41:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 17:41:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301734.514981 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsbq-000762-JZ; Fri, 08 Apr 2022 17:41:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301734.514981; Fri, 08 Apr 2022 17:41:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncsbq-00075v-GU; Fri, 08 Apr 2022 17:41:22 +0000
Received: by outflank-mailman (input) for mailman id 301734;
 Fri, 08 Apr 2022 17:41:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncsbp-00075p-1t
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 17:41:21 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsbo-0007tC-LP; Fri, 08 Apr 2022 17:41:20 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsbo-0001h0-Ep; Fri, 08 Apr 2022 17:41:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=GGVoppc/A36pKW5+3cgl0r2udRWupLyOWMZWnQsnOZY=; b=O6zS3G5NvjDT03AC2iqC+XQcn3
	Be9r5MH6oc/rWtaEGDphk+hAADvSXlNqi9MhBFPn46hsdLQEa6qWVaVoVumsxKJd9/pmjOQ86CopZ
	+qSPg8AFPpx4ex0sAwOIuy574aLtyvoN+ctwd5j01XWxI9wemHbqiu1eWXqddhgR5ez0=;
Message-ID: <e3a732b6-33b2-a6fc-6d9f-5f7f7a1872d4@xen.org>
Date: Fri, 8 Apr 2022 18:41:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Dario Faggioli <dfaggioli@suse.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220408084517.33082-5-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 08/04/2022 09:45, Luca Fancellu wrote:
> Introduce a way to create different cpupools at boot time, this is
> particularly useful on ARM big.LITTLE system where there might be the
> need to have different cpupools for each type of core, but also
> systems using NUMA can have different cpu pools for each node.
> 
> The feature on arm relies on a specification of the cpupools from the
> device tree to build pools and assign cpus to them.
> 
> ACPI is not supported for this feature.
> 
> Documentation is created to explain the feature.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
> ---
> Changes in v6:
> - Changed docs, return if booted with ACPI in btcpupools_dtb_parse,
>    panic if /chosen does not exists. Changed commit message (Julien)

I went through the changes and they LGTM. Stefano has paid closer 
attention to this series, so I will leave him to do the full review.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 17:58:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 17:58:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301739.514992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncssi-0000kn-0Y; Fri, 08 Apr 2022 17:58:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301739.514992; Fri, 08 Apr 2022 17:58:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncssh-0000kg-Ti; Fri, 08 Apr 2022 17:58:47 +0000
Received: by outflank-mailman (input) for mailman id 301739;
 Fri, 08 Apr 2022 17:58:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncssg-0000ka-27
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 17:58:46 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsse-00089b-Re; Fri, 08 Apr 2022 17:58:44 +0000
Received: from [54.239.6.190] (helo=[192.168.16.176])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncsse-0002w8-LA; Fri, 08 Apr 2022 17:58:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=j0fTXeN5exj+eBF7M7XT5/D8jf/244X16JRS4r0n9Fk=; b=EmWMHhUBQniT/FXGjp0ORk3cdV
	MoczPCPtqmFZUJnJL9jm87vOAV3y26X7pcp2MpxdSmxkWrWUK3oWoLdihT9jbr0qogabSgB+TAQ5S
	p3bHbQTpSfR/A1iHN7hGC5a9E+V6t4Ypr44lYeX5xboXd5NtsFhrZ3XbPxCisqKpQw6o=;
Message-ID: <3c5a736d-3c38-a975-62d9-7c5623d89728@xen.org>
Date: Fri, 8 Apr 2022 18:58:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220405091616.200270-1-michal.orzel@arm.com>
 <20220405091616.200270-3-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220405091616.200270-3-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 05/04/2022 10:16, Michal Orzel wrote:
>   #if defined(BUILD_ID)
> @@ -109,12 +104,7 @@ SECTIONS
>          *(.data.schedulers)
>          __end_schedulers_array = .;
>   
> -#ifdef CONFIG_HYPFS
> -       . = ALIGN(8);

This will be replaced with POINTER_ALIGN which is 4-byte on Arm32. 
AFAICT, there are no 64-bit value used in struct param_hypfs. So it 
should be fine.

That said, I think this is worth mentioning in the commit message.

The rest of this patch looks good to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 18:21:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 18:21:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301745.515014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nctEU-0004he-48; Fri, 08 Apr 2022 18:21:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301745.515014; Fri, 08 Apr 2022 18:21:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nctEU-0004hX-0e; Fri, 08 Apr 2022 18:21:18 +0000
Received: by outflank-mailman (input) for mailman id 301745;
 Fri, 08 Apr 2022 18:21:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cJw0=US=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nctET-0004ck-Dn
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 18:21:17 +0000
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com
 [2a00:1450:4864:20::435])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ad485c6d-b768-11ec-a405-831a346695d4;
 Fri, 08 Apr 2022 20:21:15 +0200 (CEST)
Received: by mail-wr1-x435.google.com with SMTP id d29so14080177wra.10
 for <xen-devel@lists.xenproject.org>; Fri, 08 Apr 2022 11:21:15 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 y15-20020a05600015cf00b00203e324347bsm24084701wry.102.2022.04.08.11.21.13
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 08 Apr 2022 11:21:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad485c6d-b768-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=wu3IDi2V7jgskHzubEp1kqQM4PIE1W72Wqr7diNZVBU=;
        b=mvLdi8gO4Vc531vdXWU7xo8B9vi0k4DfZDcYZas01eEXLI19TbQicOYt2/JgWvAX1O
         Xby65uDuLs+XCpfMqSgggYC3kNiqadGvgVEkYppxR3sCIElV4J40qbSYA+qEYioGEUsg
         Iu4Bbo0JKVyjWcoYM+lbwnwOHYVRA2y4TkvMBHVlmUaCPoH9lsD4+5jSLIE5YD9D/Frp
         EUAejeXEA6f3SmFJidujMWqFE0DRMStfLGKLrQ6NFJQghNrzay5Hbz8ehGE0H9aU2JOJ
         XDC0GicU8txQy+HQZyiZQgvvGu+ua+xYjNTJcgNK+1xtEvFSL8BUxsUHDzuBJyqwTbb1
         urkQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=wu3IDi2V7jgskHzubEp1kqQM4PIE1W72Wqr7diNZVBU=;
        b=k3EcvPK6LyEt/dNwfPBREoIC8uTeAdzQtyV3gXIJmloDm0cxpplkZyHjtWL02p3uB6
         7CBUE4IPoENncRjjA6sT1m9ylMI4Xi/aFimDWchsCuIAMR1VSdaOmeTOzUaSbWGqLQ4y
         oX8upjZz4zX41IIQ1W/VpsTpTzVALIR0c8UT0zkEmAMkSh68deYsDB7OYMdd3+dSygrn
         0wsuhqiNB1lUeFoN0x46h9n+qOqj38epYvhb+dGi8rC5yDDRpVgvpro3wj7jUM+bqIBO
         glJh2E9vYlHIo8iW8Fh7/hOxKwg2YyfDKOZ0o6upolYrY61K6nNG9zwlWXJbQ8XxsonN
         HcEw==
X-Gm-Message-State: AOAM530N7VBTQkqTZlt2XsNsju8ak8myseI/qZKymUT3fG3t4kWxGv+z
	3SOGD1C9YNu5A85CHzXyjFbzEsM1ZdM=
X-Google-Smtp-Source: ABdhPJzaK4J55tGqs9WU9lgrCWQB+2TncGu24+eYVqkgClefoHyTxWUNymfR+XbClUdJ6hhzxaz/Wg==
X-Received: by 2002:a5d:47a7:0:b0:203:d1b4:8f6 with SMTP id 7-20020a5d47a7000000b00203d1b408f6mr16038103wrb.36.1649442074700;
        Fri, 08 Apr 2022 11:21:14 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <julien.grall@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jiamei Xie <Jiamei.Xie@arm.com>,
	Henry Wang <Henry.Wang@arm.com>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
Date: Fri,  8 Apr 2022 21:21:05 +0300
Message-Id: <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

This patch introduces helpers to allocate Virtio MMIO params
(IRQ and memory region) and create specific device node in
the Guest device-tree with allocated params. In order to deal
with multiple Virtio devices, reserve corresponding ranges.
For now, we reserve 1MB for memory regions and 10 SPIs.

As these helpers should be used for every Virtio device attached
to the Guest, call them for Virtio disk(s).

Please note, with statically allocated Virtio IRQs there is
a risk of a clash with a physical IRQs of passthrough devices.
For the first version, it's fine, but we should consider allocating
the Virtio IRQs automatically. Thankfully, we know in advance which
IRQs will be used for passthrough to be able to choose non-clashed
ones.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Tested-by: Jiamei Xie <Jiamei.xie@arm.com>
Reviewed-by: Henry Wang <Henry.Wang@arm.com>
---
@Jiamei, @Henry I decided to leave your T-b and R-b tags with the minor
change I made, are you still happy with that?

s/if (disk->virtio)/if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)

Please note, this is a split/cleanup/hardening of Julien's PoC:
"Add support for Guest IO forwarding to a device emulator"

Changes RFC -> V1:
   - was squashed with:
     "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way"
     "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node"
     "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT"
   - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h

Changes V1 -> V2:
   - update the author of a patch

Changes V2 -> V3:
   - no changes

Changes V3 -> V4:
   - no changes

Changes V4 -> V5:
   - split the changes, change the order of the patches
   - drop an extra "virtio" configuration option
   - update patch description
   - use CONTAINER_OF instead of own implementation
   - reserve ranges for Virtio MMIO params and put them
     in correct location
   - create helpers to allocate Virtio MMIO params, add
     corresponding sanity-сhecks
   - add comment why MMIO size 0x200 is chosen
   - update debug print
   - drop Wei's T-b

Changes V5 -> V6:
   - rebase on current staging

Changes V6 -> V7:
   - rebase on current staging
   - add T-b and R-b tags
   - update according to the recent changes to
     "libxl: Add support for Virtio disk configuration"
---
 tools/libs/light/libxl_arm.c  | 131 +++++++++++++++++++++++++++++++++++++++++-
 xen/include/public/arch-arm.h |   7 +++
 2 files changed, 136 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index eef1de0..8132a47 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -8,6 +8,56 @@
 #include <assert.h>
 #include <xen/device_tree_defs.h>
 
+/*
+ * There is no clear requirements for the total size of Virtio MMIO region.
+ * The size of control registers is 0x100 and device-specific configuration
+ * registers starts at the offset 0x100, however it's size depends on the device
+ * and the driver. Pick the biggest known size at the moment to cover most
+ * of the devices (also consider allowing the user to configure the size via
+ * config file for the one not conforming with the proposed value).
+ */
+#define VIRTIO_MMIO_DEV_SIZE   xen_mk_ullong(0x200)
+
+static uint64_t virtio_mmio_base;
+static uint32_t virtio_mmio_irq;
+
+static void init_virtio_mmio_params(void)
+{
+    virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE;
+    virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST;
+}
+
+static uint64_t alloc_virtio_mmio_base(libxl__gc *gc)
+{
+    uint64_t base = virtio_mmio_base;
+
+    /* Make sure we have enough reserved resources */
+    if ((virtio_mmio_base + VIRTIO_MMIO_DEV_SIZE >
+        GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) {
+        LOG(ERROR, "Ran out of reserved range for Virtio MMIO BASE 0x%"PRIx64"\n",
+            virtio_mmio_base);
+        return 0;
+    }
+    virtio_mmio_base += VIRTIO_MMIO_DEV_SIZE;
+
+    return base;
+}
+
+static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc)
+{
+    uint32_t irq = virtio_mmio_irq;
+
+    /* Make sure we have enough reserved resources */
+    if (virtio_mmio_irq > GUEST_VIRTIO_MMIO_SPI_LAST) {
+        LOG(ERROR, "Ran out of reserved range for Virtio MMIO IRQ %u\n",
+            virtio_mmio_irq);
+        return 0;
+    }
+    virtio_mmio_irq++;
+
+    return irq;
+}
+
 static const char *gicv_to_string(libxl_gic_version gic_version)
 {
     switch (gic_version) {
@@ -26,8 +76,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
 {
     uint32_t nr_spis = 0;
     unsigned int i;
-    uint32_t vuart_irq;
-    bool vuart_enabled = false;
+    uint32_t vuart_irq, virtio_irq = 0;
+    bool vuart_enabled = false, virtio_enabled = false;
 
     /*
      * If pl011 vuart is enabled then increment the nr_spis to allow allocation
@@ -39,6 +89,35 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
         vuart_enabled = true;
     }
 
+    /*
+     * Virtio MMIO params are non-unique across the whole system and must be
+     * initialized for every new guest.
+     */
+    init_virtio_mmio_params();
+    for (i = 0; i < d_config->num_disks; i++) {
+        libxl_device_disk *disk = &d_config->disks[i];
+
+        if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO) {
+            disk->base = alloc_virtio_mmio_base(gc);
+            if (!disk->base)
+                return ERROR_FAIL;
+
+            disk->irq = alloc_virtio_mmio_irq(gc);
+            if (!disk->irq)
+                return ERROR_FAIL;
+
+            if (virtio_irq < disk->irq)
+                virtio_irq = disk->irq;
+            virtio_enabled = true;
+
+            LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64,
+                disk->vdev, disk->irq, disk->base);
+        }
+    }
+
+    if (virtio_enabled)
+        nr_spis += (virtio_irq - 32) + 1;
+
     for (i = 0; i < d_config->b_info.num_irqs; i++) {
         uint32_t irq = d_config->b_info.irqs[i];
         uint32_t spi;
@@ -58,6 +137,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
             return ERROR_FAIL;
         }
 
+        /* The same check as for vpl011 */
+        if (virtio_enabled &&
+           (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) {
+            LOG(ERROR, "Physical IRQ %u conflicting with Virtio MMIO IRQ range\n", irq);
+            return ERROR_FAIL;
+        }
+
         if (irq < 32)
             continue;
 
@@ -787,6 +873,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+
+static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
+                                 uint64_t base, uint32_t irq)
+{
+    int res;
+    gic_interrupt intr;
+    /* Placeholder for virtio@ + a 64-bit number + \0 */
+    char buf[24];
+
+    snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base);
+    res = fdt_begin_node(fdt, buf);
+    if (res) return res;
+
+    res = fdt_property_compat(gc, fdt, 1, "virtio,mmio");
+    if (res) return res;
+
+    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                            1, base, VIRTIO_MMIO_DEV_SIZE);
+    if (res) return res;
+
+    set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING);
+    res = fdt_property_interrupts(gc, fdt, &intr, 1);
+    if (res) return res;
+
+    res = fdt_property(fdt, "dma-coherent", NULL, 0);
+    if (res) return res;
+
+    res = fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 static const struct arch_info *get_arch_info(libxl__gc *gc,
                                              const struct xc_dom_image *dom)
 {
@@ -988,6 +1107,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config,
     size_t fdt_size = 0;
     int pfdt_size = 0;
     libxl_domain_build_info *const info = &d_config->b_info;
+    unsigned int i;
 
     const libxl_version_info *vers;
     const struct arch_info *ainfo;
@@ -1094,6 +1214,13 @@ next_resize:
         if (d_config->num_pcidevs)
             FDT( make_vpci_node(gc, fdt, ainfo, dom) );
 
+        for (i = 0; i < d_config->num_disks; i++) {
+            libxl_device_disk *disk = &d_config->disks[i];
+
+            if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
+                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) );
+        }
+
         if (pfdt)
             FDT( copy_partial_fdt(gc, fdt, pfdt) );
 
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index ab05fe1..c8b6058 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -407,6 +407,10 @@ typedef uint64_t xen_callback_t;
 
 /* Physical Address Space */
 
+/* Virtio MMIO mappings */
+#define GUEST_VIRTIO_MMIO_BASE   xen_mk_ullong(0x02000000)
+#define GUEST_VIRTIO_MMIO_SIZE   xen_mk_ullong(0x00100000)
+
 /*
  * vGIC mappings: Only one set of mapping is used by the guest.
  * Therefore they can overlap.
@@ -493,6 +497,9 @@ typedef uint64_t xen_callback_t;
 
 #define GUEST_VPL011_SPI        32
 
+#define GUEST_VIRTIO_MMIO_SPI_FIRST   33
+#define GUEST_VIRTIO_MMIO_SPI_LAST    43
+
 /* PSCI functions */
 #define PSCI_cpu_suspend 0
 #define PSCI_cpu_off     1
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 18:21:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 18:21:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301746.515025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nctEV-0004xK-CL; Fri, 08 Apr 2022 18:21:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301746.515025; Fri, 08 Apr 2022 18:21:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nctEV-0004xD-94; Fri, 08 Apr 2022 18:21:19 +0000
Received: by outflank-mailman (input) for mailman id 301746;
 Fri, 08 Apr 2022 18:21:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cJw0=US=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nctET-0004Rr-SU
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 18:21:18 +0000
Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com
 [2a00:1450:4864:20::429])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ad117e5b-b768-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 20:21:15 +0200 (CEST)
Received: by mail-wr1-x429.google.com with SMTP id d29so14080170wra.10
 for <xen-devel@lists.xenproject.org>; Fri, 08 Apr 2022 11:21:15 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 y15-20020a05600015cf00b00203e324347bsm24084701wry.102.2022.04.08.11.21.11
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 08 Apr 2022 11:21:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad117e5b-b768-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=eHPD+vVWIBvq/dPK+HYt2wla5Lo/yXzHhwikZqN3mrU=;
        b=hR9xp6vNsHtZ4XnLgxTHY03IyH45uSQCtIraktRqiWu6gX9BlvS7nreP7zgiwX6JZJ
         AbjBEKZ8IJ3YmP+T7pRbMx+vlPX8uXG51n1rnVtEPaGQl5aIWzKVNvz1PlAobMsOHCr0
         4YRNhqfzb0qPgvVzavMwiL9UAQ/jJnK7MSm1CmpBFTnlhDbY8+5LxJqq243M6yTopgk1
         lzqyYscHJ7JH6IUpudihUs14MMx1pkHgc5MzQ5/VS2d9SylO6T1aTIPvmTLz4VVNFZyv
         haipcKvQkHOnZUjfFRQaNLINfMetFQ8DB+45TeJNhYCqrWnCEMMQZCLFsQFPjg63+aDu
         2kCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=eHPD+vVWIBvq/dPK+HYt2wla5Lo/yXzHhwikZqN3mrU=;
        b=fALugykqJmaj9NEd7Iax275RfOmDI7rBTWuf7Em1Al0j1c48Uel4PFJLQjEIeJknzx
         d6btRi3uSHh3AMfO4OoPqlSTqzhXBKr9siFIi56pEfz84UBYFNLQyTEGwOk/vneAYoc/
         b3t374ZivZeI4V+fMZVV4noWC/jVUC93wHhzqtlFebNCFf0U5F0CHtI0dYunYOtRKyWS
         zNlSSyB590sG5cIvyoXw0aWxlMnFKj8IBdTM9bwzWm1WKjeV6rCJRQjFoFaa3YOBs2ym
         ToMGHHP3Jb+D8zpz93hN8IYNLjFlKPdY7E5rqyfEuPyzq2l2hgPwDgM0VvTBRS5Mq/uT
         K+IA==
X-Gm-Message-State: AOAM530VF6o4BdOcFEIIUmTv3MAiB/BKi1d2rtBcHhdu91aXYYI3OHMJ
	+z4FBdX52SrPTYDt49PxKbfbYun5bDA=
X-Google-Smtp-Source: ABdhPJw6pRr3zkVCss7RRK0I92VEprt+Xhv81VmgWuYzVjvnpqCsfT+h9Da/DsQ3zrbz52ibfxBPWA==
X-Received: by 2002:a5d:4712:0:b0:206:120d:b038 with SMTP id y18-20020a5d4712000000b00206120db038mr16414283wrq.542.1649442073265;
        Fri, 08 Apr 2022 11:21:13 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@gmail.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
Date: Fri,  8 Apr 2022 21:21:04 +0300
Message-Id: <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This patch adds basic support for configuring and assisting virtio-mmio
based virtio-disk backend (emualator) which is intended to run out of
Qemu and could be run in any domain.
Although the Virtio block device is quite different from traditional
Xen PV block device (vbd) from the toolstack's point of view:
 - as the frontend is virtio-blk which is not a Xenbus driver, nothing
   written to Xenstore are fetched by the frontend (the vdev is not
   passed to the frontend)
 - the ring-ref/event-channel are not used for the backend<->frontend
   communication, the proposed IPC for Virtio is IOREQ/DM
it is still a "block device" and ought to be integrated in existing
"disk" handling. So, re-use (and adapt) "disk" parsing/configuration
logic to deal with Virtio devices as well.

For the immediate purpose and an ability to extend that support for
other use-cases in future (Qemu, virtio-pci, etc) perform the following
actions:
- Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect
  that in the configuration
- Introduce new disk protocol field to libxl_device_disk struct
  (with LIBXL_DISK_PROTOCOL_XEN and LIBXL_DISK_PROTOCOL_VIRTIO_MMIO
  types) and reflect that in the configuration (new "protocol" option
  with "xen" protocol being default value)
- Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
  one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model

An example of domain configuration for Virtio disk:
disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, protocol=virtio-mmio']

Nothing has changed for default Xen disk configuration.

Please note, this patch is not enough for virtio-disk to work
on Xen (Arm), as for every Virtio device (including disk) we need
to allocate Virtio MMIO params (IRQ and memory region) and pass
them to the backend, also update Guest device-tree. The subsequent
patch will add these missing bits. For the current patch,
the default "irq" and "base" are just written to the Xenstore.
This is not an ideal splitting, but this way we avoid breaking
the bisectability.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V1:
   - no changes

Changes V1 -> V2:
   - rebase according to the new location of libxl_virtio_disk.c

Changes V2 -> V3:
   - no changes

Changes V3 -> V4:
   - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT

Changes V4 -> V5:
   - split the changes, change the order of the patches
   - update patch description
   - don't introduce new "vdisk" configuration option with own parsing logic,
     re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk
   - introduce "virtio" flag and document it's usage
   - add LIBXL_HAVE_DEVICE_DISK_VIRTIO
   - update libxlu_disk_l.[ch]
   - drop num_disks variable/MAX_VIRTIO_DISKS
   - drop Wei's T-b

Changes V5 -> V6:
   - rebase on current staging
   - use "%"PRIu64 instead of %lu for disk->base in device_disk_add()
   - update *.gen.go files

Changes V6 -> V7:
   - rebase on current staging
   - update *.gen.go files and libxlu_disk_l.[ch] files
   - update patch description
   - rework significantly to support more flexible configuration
     and have more generic basic implementation for being able to extend
     that for other use-cases (virtio-pci, qemu, etc).
---
 docs/man/xl-disk-configuration.5.pod.in   |  37 +-
 tools/golang/xenlight/helpers.gen.go      |   6 +
 tools/golang/xenlight/types.gen.go        |  11 +
 tools/include/libxl.h                     |   6 +
 tools/libs/light/libxl_device.c           |  57 +-
 tools/libs/light/libxl_disk.c             | 111 +++-
 tools/libs/light/libxl_internal.h         |   1 +
 tools/libs/light/libxl_types.idl          |  10 +
 tools/libs/light/libxl_types_internal.idl |   1 +
 tools/libs/light/libxl_utils.c            |   2 +
 tools/libs/util/libxlu_disk_l.c           | 952 +++++++++++++++---------------
 tools/libs/util/libxlu_disk_l.h           |   2 +-
 tools/libs/util/libxlu_disk_l.l           |   9 +
 tools/xl/xl_block.c                       |  11 +
 14 files changed, 736 insertions(+), 480 deletions(-)

diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in
index 71d0e86..36c851f 100644
--- a/docs/man/xl-disk-configuration.5.pod.in
+++ b/docs/man/xl-disk-configuration.5.pod.in
@@ -232,7 +232,7 @@ Specifies the backend implementation to use
 
 =item Supported values
 
-phy, qdisk
+phy, qdisk, other
 
 =item Mandatory
 
@@ -244,11 +244,13 @@ Automatically determine which backend to use.
 
 =back
 
-This does not affect the guest's view of the device.  It controls
-which software implementation of the Xen backend driver is used.
+It controls which software implementation of the backend driver is used.
+Depending on the "protocol" option this may affect the guest's view
+of the device.
 
 Not all backend drivers support all combinations of other options.
-For example, "phy" does not support formats other than "raw".
+For example, "phy" and "other" do not support formats other than "raw" and
+"other" does not support protocols other than "virtio-mmio".
 Normally this option should not be specified, in which case libxl will
 automatically determine the most suitable backend.
 
@@ -344,8 +346,35 @@ can be used to disable "hole punching" for file based backends which
 were intentionally created non-sparse to avoid fragmentation of the
 file.
 
+=item B<protocol>=I<PROTOCOL>
+
+=over 4
+
+=item Description
+
+Specifies the communication protocol to use for the chosen "backendtype" option
+
+=item Supported values
+
+xen, virtio-mmio
+
+=item Mandatory
+
+No
+
+=item Default value
+
+xen
+
 =back
 
+Besides forcing toolstack to use specific backend implementation, this also
+affects the guest's view of the device. For example, "virtio-mmio" requires
+Virtio frontend driver (virtio-blk) to be used. Please note, the virtual
+device (vdev) is not passed to the guest in that case, but it still must be
+specified for the internal purposes.
+
+=back
 
 =head1 COLO Parameters
 
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index b746ff1..3190671 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1751,6 +1751,9 @@ x.DirectIoSafe = bool(xc.direct_io_safe)
 if err := x.DiscardEnable.fromC(&xc.discard_enable);err != nil {
 return fmt.Errorf("converting field DiscardEnable: %v", err)
 }
+x.Protocol = DiskProtocol(xc.protocol)
+x.Irq = uint32(xc.irq)
+x.Base = uint64(xc.base)
 if err := x.ColoEnable.fromC(&xc.colo_enable);err != nil {
 return fmt.Errorf("converting field ColoEnable: %v", err)
 }
@@ -1788,6 +1791,9 @@ xc.direct_io_safe = C.bool(x.DirectIoSafe)
 if err := x.DiscardEnable.toC(&xc.discard_enable); err != nil {
 return fmt.Errorf("converting field DiscardEnable: %v", err)
 }
+xc.protocol = C.libxl_disk_protocol(x.Protocol)
+xc.irq = C.uint32_t(x.Irq)
+xc.base = C.uint64_t(x.Base)
 if err := x.ColoEnable.toC(&xc.colo_enable); err != nil {
 return fmt.Errorf("converting field ColoEnable: %v", err)
 }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index b1e84d5..4ff14c2 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -99,6 +99,14 @@ DiskBackendUnknown DiskBackend = 0
 DiskBackendPhy DiskBackend = 1
 DiskBackendTap DiskBackend = 2
 DiskBackendQdisk DiskBackend = 3
+DiskBackendOther DiskBackend = 4
+)
+
+type DiskProtocol int
+const(
+DiskProtocolUnknown DiskProtocol = 0
+DiskProtocolXen DiskProtocol = 1
+DiskProtocolVirtioMmio DiskProtocol = 2
 )
 
 type NicType int
@@ -643,6 +651,9 @@ Readwrite int
 IsCdrom int
 DirectIoSafe bool
 DiscardEnable Defbool
+Protocol DiskProtocol
+Irq uint32
+Base uint64
 ColoEnable Defbool
 ColoRestoreEnable Defbool
 ColoHost string
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 51a9b6c..66dbf63 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -528,6 +528,12 @@
 #define LIBXL_HAVE_MAX_GRANT_VERSION 1
 
 /*
+ * LIBXL_HAVE_DEVICE_DISK_PROTOCOL indicates that a 'protocol' field
+ * (of libxl_disk_protocol type) is present in libxl_device_disk.
+ */
+#define LIBXL_HAVE_DEVICE_DISK_PROTOCOL 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c
index e6025d1..846e8c4 100644
--- a/tools/libs/light/libxl_device.c
+++ b/tools/libs/light/libxl_device.c
@@ -289,9 +289,16 @@ static int disk_try_backend(disk_try_backend_args *a,
                             libxl_disk_backend backend)
  {
     libxl__gc *gc = a->gc;
+    libxl_disk_protocol protocol = a->disk->protocol;
     /* returns 0 (ie, DISK_BACKEND_UNKNOWN) on failure, or
      * backend on success */
 
+    if ((protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO &&
+         backend != LIBXL_DISK_BACKEND_OTHER) ||
+        (protocol != LIBXL_DISK_PROTOCOL_VIRTIO_MMIO &&
+         backend == LIBXL_DISK_BACKEND_OTHER))
+        goto bad_protocol;
+
     switch (backend) {
     case LIBXL_DISK_BACKEND_PHY:
         if (a->disk->format != LIBXL_DISK_FORMAT_RAW) {
@@ -329,6 +336,29 @@ static int disk_try_backend(disk_try_backend_args *a,
         if (a->disk->script) goto bad_script;
         return backend;
 
+    case LIBXL_DISK_BACKEND_OTHER:
+        if (a->disk->format != LIBXL_DISK_FORMAT_RAW)
+            goto bad_format;
+
+        if (a->disk->script)
+            goto bad_script;
+
+        if (libxl_defbool_val(a->disk->colo_enable))
+            goto bad_colo;
+
+        if (a->disk->backend_domid != LIBXL_TOOLSTACK_DOMID) {
+            LOG(DEBUG, "Disk vdev=%s, is using a storage driver domain, "
+                       "skipping physical device check", a->disk->vdev);
+            return backend;
+        }
+
+        if (libxl__try_phy_backend(a->stab.st_mode))
+            return backend;
+
+        LOG(DEBUG, "Disk vdev=%s, backend other unsuitable as phys path not a "
+                   "block device", a->disk->vdev);
+        return 0;
+
     default:
         LOG(DEBUG, "Disk vdev=%s, backend %d unknown", a->disk->vdev, backend);
         return 0;
@@ -352,6 +382,12 @@ static int disk_try_backend(disk_try_backend_args *a,
     LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with colo",
         a->disk->vdev, libxl_disk_backend_to_string(backend));
     return 0;
+
+ bad_protocol:
+    LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with protocol %s",
+        a->disk->vdev, libxl_disk_backend_to_string(backend),
+        libxl_disk_protocol_to_string(protocol));
+    return 0;
 }
 
 int libxl__backendpath_parse_domid(libxl__gc *gc, const char *be_path,
@@ -376,8 +412,9 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) {
     a.gc = gc;
     a.disk = disk;
 
-    LOG(DEBUG, "Disk vdev=%s spec.backend=%s", disk->vdev,
-               libxl_disk_backend_to_string(disk->backend));
+    LOG(DEBUG, "Disk vdev=%s spec.backend=%s spec.protocol=%s", disk->vdev,
+               libxl_disk_backend_to_string(disk->backend),
+               libxl_disk_protocol_to_string(disk->protocol));
 
     if (disk->format == LIBXL_DISK_FORMAT_EMPTY) {
         if (!disk->is_cdrom) {
@@ -392,7 +429,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) {
         }
         memset(&a.stab, 0, sizeof(a.stab));
     } else if ((disk->backend == LIBXL_DISK_BACKEND_UNKNOWN ||
-                disk->backend == LIBXL_DISK_BACKEND_PHY) &&
+                disk->backend == LIBXL_DISK_BACKEND_PHY ||
+                disk->backend == LIBXL_DISK_BACKEND_OTHER) &&
                disk->backend_domid == LIBXL_TOOLSTACK_DOMID &&
                !disk->script) {
         if (stat(disk->pdev_path, &a.stab)) {
@@ -408,7 +446,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) {
         ok=
             disk_try_backend(&a, LIBXL_DISK_BACKEND_PHY) ?:
             disk_try_backend(&a, LIBXL_DISK_BACKEND_QDISK) ?:
-            disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP);
+            disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP) ?:
+            disk_try_backend(&a, LIBXL_DISK_BACKEND_OTHER);
         if (ok)
             LOG(DEBUG, "Disk vdev=%s, using backend %s",
                        disk->vdev,
@@ -441,6 +480,16 @@ char *libxl__device_disk_string_of_backend(libxl_disk_backend backend)
         case LIBXL_DISK_BACKEND_QDISK: return "qdisk";
         case LIBXL_DISK_BACKEND_TAP: return "phy";
         case LIBXL_DISK_BACKEND_PHY: return "phy";
+        case LIBXL_DISK_BACKEND_OTHER: return "other";
+        default: return NULL;
+    }
+}
+
+char *libxl__device_disk_string_of_protocol(libxl_disk_protocol protocol)
+{
+    switch (protocol) {
+        case LIBXL_DISK_PROTOCOL_XEN: return "xen";
+        case LIBXL_DISK_PROTOCOL_VIRTIO_MMIO: return "virtio-mmio";
         default: return NULL;
     }
 }
diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c
index a5ca778..9bb5098 100644
--- a/tools/libs/light/libxl_disk.c
+++ b/tools/libs/light/libxl_disk.c
@@ -163,6 +163,9 @@ static int libxl__device_disk_setdefault(libxl__gc *gc, uint32_t domid,
     rc = libxl__resolve_domid(gc, disk->backend_domname, &disk->backend_domid);
     if (rc < 0) return rc;
 
+    if (disk->protocol == LIBXL_DISK_PROTOCOL_UNKNOWN)
+        disk->protocol = LIBXL_DISK_PROTOCOL_XEN;
+
     /* Force Qdisk backend for CDROM devices of guests with a device model. */
     if (disk->is_cdrom != 0 &&
         libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) {
@@ -204,6 +207,9 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid,
         case LIBXL_DISK_BACKEND_QDISK:
             device->backend_kind = LIBXL__DEVICE_KIND_QDISK;
             break;
+        case LIBXL_DISK_BACKEND_OTHER:
+            device->backend_kind = LIBXL__DEVICE_KIND_VIRTIO_DISK;
+            break;
         default:
             LOGD(ERROR, domid, "Unrecognized disk backend type: %d",
                  disk->backend);
@@ -212,7 +218,8 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid,
 
     device->domid = domid;
     device->devid = devid;
-    device->kind  = LIBXL__DEVICE_KIND_VBD;
+    device->kind = disk->backend == LIBXL_DISK_BACKEND_OTHER ?
+        LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD;
 
     return 0;
 }
@@ -317,6 +324,11 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid,
             goto out;
         }
 
+        assert((disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO &&
+                disk->backend == LIBXL_DISK_BACKEND_OTHER) ||
+               (disk->protocol != LIBXL_DISK_PROTOCOL_VIRTIO_MMIO &&
+                disk->backend != LIBXL_DISK_BACKEND_OTHER));
+
         switch (disk->backend) {
             case LIBXL_DISK_BACKEND_PHY:
                 dev = disk->pdev_path;
@@ -330,7 +342,14 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid,
 
                 assert(device->backend_kind == LIBXL__DEVICE_KIND_VBD);
                 break;
+            case LIBXL_DISK_BACKEND_OTHER:
+                dev = disk->pdev_path;
+
+                flexarray_append(back, "params");
+                flexarray_append(back, dev);
 
+                assert(device->backend_kind == LIBXL__DEVICE_KIND_VIRTIO_DISK);
+                break;
             case LIBXL_DISK_BACKEND_TAP:
                 LOG(ERROR, "blktap is not supported");
                 rc = ERROR_FAIL;
@@ -386,6 +405,12 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid,
         flexarray_append_pair(back, "discard-enable",
                               libxl_defbool_val(disk->discard_enable) ?
                               "1" : "0");
+        flexarray_append(back, "protocol");
+        flexarray_append(back, libxl__device_disk_string_of_protocol(disk->protocol));
+        if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO) {
+            flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64, disk->base));
+            flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk->irq));
+        }
 
         flexarray_append(front, "backend-id");
         flexarray_append(front, GCSPRINTF("%d", disk->backend_domid));
@@ -532,6 +557,37 @@ static int libxl__disk_from_xenstore(libxl__gc *gc, const char *libxl_path,
     }
     libxl_string_to_backend(ctx, tmp, &(disk->backend));
 
+    tmp = libxl__xs_read(gc, XBT_NULL,
+                         GCSPRINTF("%s/protocol", libxl_path));
+    if (!tmp) {
+        LOG(ERROR, "Missing xenstore node %s/protocol", libxl_path);
+        goto cleanup;
+    }
+    if (!strcmp(tmp, "xen"))
+        disk->protocol = LIBXL_DISK_PROTOCOL_XEN;
+    else if (!strcmp(tmp, "virtio-mmio"))
+        disk->protocol = LIBXL_DISK_PROTOCOL_VIRTIO_MMIO;
+    else
+        disk->protocol = LIBXL_DISK_PROTOCOL_UNKNOWN;
+
+    if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO) {
+        tmp = libxl__xs_read(gc, XBT_NULL,
+                             GCSPRINTF("%s/base", libxl_path));
+        if (!tmp) {
+            LOG(ERROR, "Missing xenstore node %s/base", libxl_path);
+            goto cleanup;
+        }
+        disk->base = strtoul(tmp, NULL, 10);
+
+        tmp = libxl__xs_read(gc, XBT_NULL,
+                             GCSPRINTF("%s/irq", libxl_path));
+        if (!tmp) {
+            LOG(ERROR, "Missing xenstore node %s/irq", libxl_path);
+            goto cleanup;
+        }
+        disk->irq = strtoul(tmp, NULL, 10);
+    }
+
     disk->vdev = xs_read(ctx->xsh, XBT_NULL,
                          GCSPRINTF("%s/dev", libxl_path), &len);
     if (!disk->vdev) {
@@ -575,6 +631,41 @@ cleanup:
     return rc;
 }
 
+static int libxl_device_disk_get_path(libxl__gc *gc, uint32_t domid,
+                                      char **path)
+{
+    const char *dir;
+    int rc;
+
+    /*
+     * As we don't know exactly what device kind to be used here, guess it
+     * by checking the presence of the corresponding path in Xenstore.
+     * First, try to read path for vbd device (default) and if not exists
+     * read path for virtio_disk device. This will work as long as both Xen PV
+     * and Virtio disk devices are not assigned to the same guest.
+     */
+    *path = GCSPRINTF("%s/device/%s",
+                      libxl__xs_libxl_path(gc, domid),
+                      libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VBD));
+
+    rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir);
+    if (rc)
+        return rc;
+
+    if (dir)
+        return 0;
+
+    *path = GCSPRINTF("%s/device/%s",
+                      libxl__xs_libxl_path(gc, domid),
+                      libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK));
+
+    rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir);
+    if (rc)
+        return rc;
+
+    return 0;
+}
+
 int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid,
                               const char *vdev, libxl_device_disk *disk)
 {
@@ -588,10 +679,12 @@ int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid,
 
     libxl_device_disk_init(disk);
 
-    libxl_path = libxl__domain_device_libxl_path(gc, domid, devid,
-                                                 LIBXL__DEVICE_KIND_VBD);
+    rc = libxl_device_disk_get_path(gc, domid, &libxl_path);
+    if (rc)
+        return rc;
 
-    rc = libxl__disk_from_xenstore(gc, libxl_path, devid, disk);
+    rc = libxl__disk_from_xenstore(gc, GCSPRINTF("%s/%d", libxl_path, devid),
+                                   devid, disk);
 
     GC_FREE;
     return rc;
@@ -605,16 +698,19 @@ int libxl_device_disk_getinfo(libxl_ctx *ctx, uint32_t domid,
     char *fe_path, *libxl_path;
     char *val;
     int rc;
+    libxl__device_kind kind;
 
     diskinfo->backend = NULL;
 
     diskinfo->devid = libxl__device_disk_dev_number(disk->vdev, NULL, NULL);
 
-    /* tap devices entries in xenstore are written as vbd devices. */
+    /* tap devices entries in xenstore are written as vbd/virtio_disk devices. */
+    kind = disk->backend == LIBXL_DISK_BACKEND_OTHER ?
+        LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD;
     fe_path = libxl__domain_device_frontend_path(gc, domid, diskinfo->devid,
-                                                 LIBXL__DEVICE_KIND_VBD);
+                                                 kind);
     libxl_path = libxl__domain_device_libxl_path(gc, domid, diskinfo->devid,
-                                                 LIBXL__DEVICE_KIND_VBD);
+                                                 kind);
     diskinfo->backend = xs_read(ctx->xsh, XBT_NULL,
                                 GCSPRINTF("%s/backend", libxl_path), NULL);
     if (!diskinfo->backend) {
@@ -1418,6 +1514,7 @@ LIBXL_DEFINE_DEVICE_LIST(disk)
 #define libxl__device_disk_update_devid NULL
 
 DEFINE_DEVICE_TYPE_STRUCT(disk, VBD, disks,
+    .get_path    = libxl_device_disk_get_path,
     .merge       = libxl_device_disk_merge,
     .dm_needed   = libxl_device_disk_dm_needed,
     .from_xenstore = (device_from_xenstore_fn_t)libxl__disk_from_xenstore,
diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h
index a26daec..f4eb75d 100644
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -1493,6 +1493,7 @@ _hidden char * libxl__domain_pvcontrol_read(libxl__gc *gc,
 
 /* from xl_device */
 _hidden char *libxl__device_disk_string_of_backend(libxl_disk_backend backend);
+_hidden char *libxl__device_disk_string_of_protocol(libxl_disk_protocol protocol);
 _hidden char *libxl__device_disk_string_of_format(libxl_disk_format format);
 _hidden const char *libxl__qemu_disk_format_string(libxl_disk_format format);
 _hidden int libxl__device_disk_set_backend(libxl__gc*, libxl_device_disk*);
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 2a42da2..5d57e3a 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -130,6 +130,13 @@ libxl_disk_backend = Enumeration("disk_backend", [
     (1, "PHY"),
     (2, "TAP"),
     (3, "QDISK"),
+    (4, "OTHER"),
+    ])
+
+libxl_disk_protocol = Enumeration("disk_protocol", [
+    (0, "UNKNOWN"),
+    (1, "XEN"),
+    (2, "VIRTIO_MMIO"),
     ])
 
 libxl_nic_type = Enumeration("nic_type", [
@@ -704,6 +711,9 @@ libxl_device_disk = Struct("device_disk", [
     ("is_cdrom", integer),
     ("direct_io_safe", bool),
     ("discard_enable", libxl_defbool),
+    ("protocol", libxl_disk_protocol),
+    ("irq", uint32),
+    ("base", uint64),
     # Note that the COLO configuration settings should be considered unstable.
     # They may change incompatibly in future versions of Xen.
     ("colo_enable", libxl_defbool),
diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl
index 3593e21..8f71980 100644
--- a/tools/libs/light/libxl_types_internal.idl
+++ b/tools/libs/light/libxl_types_internal.idl
@@ -32,6 +32,7 @@ libxl__device_kind = Enumeration("device_kind", [
     (14, "PVCALLS"),
     (15, "VSND"),
     (16, "VINPUT"),
+    (17, "VIRTIO_DISK"),
     ])
 
 libxl__console_backend = Enumeration("console_backend", [
diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c
index b91c2ca..eb816dd 100644
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -303,6 +303,8 @@ int libxl_string_to_backend(libxl_ctx *ctx, char *s, libxl_disk_backend *backend
         *backend = LIBXL_DISK_BACKEND_TAP;
     } else if (!strcmp(s, "qdisk")) {
         *backend = LIBXL_DISK_BACKEND_QDISK;
+    } else if (!strcmp(s, "other")) {
+        *backend = LIBXL_DISK_BACKEND_OTHER;
     } else if (!strcmp(s, "tap")) {
         p = strchr(s, ':');
         if (!p) {
diff --git a/tools/libs/util/libxlu_disk_l.c b/tools/libs/util/libxlu_disk_l.c
index 32d4b74..af22055 100644
--- a/tools/libs/util/libxlu_disk_l.c
+++ b/tools/libs/util/libxlu_disk_l.c
@@ -549,8 +549,8 @@ static void yynoreturn yy_fatal_error ( const char* msg , yyscan_t yyscanner );
 	yyg->yy_hold_char = *yy_cp; \
 	*yy_cp = '\0'; \
 	yyg->yy_c_buf_p = yy_cp;
-#define YY_NUM_RULES 36
-#define YY_END_OF_BUFFER 37
+#define YY_NUM_RULES 37
+#define YY_END_OF_BUFFER 38
 /* This struct is not used in this scanner,
    but its presence is necessary. */
 struct yy_trans_info
@@ -558,74 +558,75 @@ struct yy_trans_info
 	flex_int32_t yy_verify;
 	flex_int32_t yy_nxt;
 	};
-static const flex_int16_t yy_acclist[575] =
+static const flex_int16_t yy_acclist[589] =
     {   0,
-       35,   35,   37,   33,   34,   36, 8193,   33,   34,   36,
-    16385, 8193,   33,   36,16385,   33,   34,   36,   34,   36,
-       33,   34,   36,   33,   34,   36,   33,   34,   36,   33,
-       34,   36,   33,   34,   36,   33,   34,   36,   33,   34,
-       36,   33,   34,   36,   33,   34,   36,   33,   34,   36,
-       33,   34,   36,   33,   34,   36,   33,   34,   36,   33,
-       34,   36,   33,   34,   36,   33,   34,   36,   35,   36,
-       36,   33,   33, 8193,   33, 8193,   33,16385, 8193,   33,
-     8193,   33,   33, 8224,   33,16416,   33,   33,   33,   33,
-       33,   33,   33,   33,   33,   33,   33,   33,   33,   33,
-
-       33,   33,   33,   33,   33,   33,   33,   33,   33,   35,
-     8193,   33, 8193,   33, 8193, 8224,   33, 8224,   33, 8224,
-       23,   33,   33,   33,   33,   33,   33,   33,   33,   33,
-       33,   33,   33,   33,   33,   33,   33,   33,   33,   33,
-       33,   33,   33,   33,   33, 8224,   33, 8224,   33, 8224,
-       23,   33,   33,   28, 8224,   33,16416,   33,   33,   15,
-       33,   33,   33,   33,   33,   33,   33,   33,   33, 8217,
-     8224,   33,16409,16416,   33,   33,   31, 8224,   33,16416,
-       33, 8216, 8224,   33,16408,16416,   33,   33, 8219, 8224,
-       33,16411,16416,   33,   33,   33,   33,   33,   28, 8224,
-
-       33,   28, 8224,   33,   28,   33,   28, 8224,   33,    3,
-       33,   15,   33,   33,   33,   33,   33,   30, 8224,   33,
-    16416,   33,   33,   33, 8217, 8224,   33, 8217, 8224,   33,
-     8217,   33, 8217, 8224,   33,   33,   31, 8224,   33,   31,
-     8224,   33,   31,   33,   31, 8224, 8216, 8224,   33, 8216,
-     8224,   33, 8216,   33, 8216, 8224,   33, 8219, 8224,   33,
-     8219, 8224,   33, 8219,   33, 8219, 8224,   33,   33,   10,
-       33,   33,   28, 8224,   33,   28, 8224,   33,   28, 8224,
-       28,   33,   28,   33,    3,   33,   33,   33,   33,   33,
-       33,   33,   30, 8224,   33,   30, 8224,   33,   30,   33,
-
-       30, 8224,   33,   33,   29, 8224,   33,16416, 8217, 8224,
-       33, 8217, 8224,   33, 8217, 8224, 8217,   33, 8217,   33,
-       33,   31, 8224,   33,   31, 8224,   33,   31, 8224,   31,
-       33,   31, 8216, 8224,   33, 8216, 8224,   33, 8216, 8224,
-     8216,   33, 8216,   33, 8219, 8224,   33, 8219, 8224,   33,
-     8219, 8224, 8219,   33, 8219,   33,   33,   10,   23,   10,
-        7,   33,   33,   33,   33,   33,   33,   33,   13,   33,
-       30, 8224,   33,   30, 8224,   33,   30, 8224,   30,   33,
-       30,    2,   33,   29, 8224,   33,   29, 8224,   33,   29,
-       33,   29, 8224,   16,   33,   33,   11,   33,   22,   10,
-
-       10,   23,    7,   23,    7,   33,    8,   33,   33,   33,
-       33,    6,   33,   13,   33,    2,   23,    2,   33,   29,
-     8224,   33,   29, 8224,   33,   29, 8224,   29,   33,   29,
-       16,   33,   33,   11,   23,   11,   26, 8224,   33,16416,
-       22,   23,   22,    7,    7,   23,   33,    8,   23,    8,
-       33,   33,   33,   33,    6,   23,    6,    6,   23,    6,
-       23,   33,    2,    2,   23,   33,   33,   11,   11,   23,
-       26, 8224,   33,   26, 8224,   33,   26,   33,   26, 8224,
-       22,   23,   33,    8,    8,   23,   33,   33,   17,   18,
-        6,    6,   23,    6,    6,   33,   33,   14,   33,   26,
-
-     8224,   33,   26, 8224,   33,   26, 8224,   26,   33,   26,
-       33,   33,   33,   17,   23,   17,   18,   23,   18,    6,
-        6,   33,   33,   14,   33,   20,    9,   19,   17,   17,
-       23,   18,   18,   23,    6,    5,    6,   33,   21,   20,
-       23,   20,    9,   23,    9,   19,   23,   19,    4,    6,
-        5,    6,   33,   21,   23,   21,   20,   20,   23,    9,
-        9,   23,   19,   19,   23,    4,    6,   12,   33,   21,
-       21,   23,   12,   33
+       36,   36,   38,   34,   35,   37, 8193,   34,   35,   37,
+    16385, 8193,   34,   37,16385,   34,   35,   37,   35,   37,
+       34,   35,   37,   34,   35,   37,   34,   35,   37,   34,
+       35,   37,   34,   35,   37,   34,   35,   37,   34,   35,
+       37,   34,   35,   37,   34,   35,   37,   34,   35,   37,
+       34,   35,   37,   34,   35,   37,   34,   35,   37,   34,
+       35,   37,   34,   35,   37,   34,   35,   37,   36,   37,
+       37,   34,   34, 8193,   34, 8193,   34,16385, 8193,   34,
+     8193,   34,   34, 8225,   34,16417,   34,   34,   34,   34,
+       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
+
+       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
+       36, 8193,   34, 8193,   34, 8193, 8225,   34, 8225,   34,
+     8225,   24,   34,   34,   34,   34,   34,   34,   34,   34,
+       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
+       34,   34,   34,   34,   34,   34,   34, 8225,   34, 8225,
+       34, 8225,   24,   34,   34,   29, 8225,   34,16417,   34,
+       34,   16,   34,   34,   34,   34,   34,   34,   34,   34,
+       34, 8218, 8225,   34,16410,16417,   34,   34,   32, 8225,
+       34,16417,   34,   34, 8217, 8225,   34,16409,16417,   34,
+       34, 8220, 8225,   34,16412,16417,   34,   34,   34,   34,
+
+       34,   29, 8225,   34,   29, 8225,   34,   29,   34,   29,
+     8225,   34,    3,   34,   16,   34,   34,   34,   34,   34,
+       31, 8225,   34,16417,   34,   34,   34, 8218, 8225,   34,
+     8218, 8225,   34, 8218,   34, 8218, 8225,   34,   34,   32,
+     8225,   34,   32, 8225,   34,   32,   34,   32, 8225,   34,
+     8217, 8225,   34, 8217, 8225,   34, 8217,   34, 8217, 8225,
+       34, 8220, 8225,   34, 8220, 8225,   34, 8220,   34, 8220,
+     8225,   34,   34,   11,   34,   34,   29, 8225,   34,   29,
+     8225,   34,   29, 8225,   29,   34,   29,   34,    3,   34,
+       34,   34,   34,   34,   34,   34,   31, 8225,   34,   31,
+
+     8225,   34,   31,   34,   31, 8225,   34,   34,   30, 8225,
+       34,16417, 8218, 8225,   34, 8218, 8225,   34, 8218, 8225,
+     8218,   34, 8218,   34,   34,   32, 8225,   34,   32, 8225,
+       34,   32, 8225,   32,   34,   32,   34, 8217, 8225,   34,
+     8217, 8225,   34, 8217, 8225, 8217,   34, 8217,   34, 8220,
+     8225,   34, 8220, 8225,   34, 8220, 8225, 8220,   34, 8220,
+       34,   34,   11,   24,   11,    7,   34,   34,   34,   34,
+       34,   34,   34,   14,   34,   31, 8225,   34,   31, 8225,
+       34,   31, 8225,   31,   34,   31,    2,   34,   30, 8225,
+       34,   30, 8225,   34,   30,   34,   30, 8225,   17,   34,
+
+       34,   34,   12,   34,   23,   11,   11,   24,    7,   24,
+        7,   34,    8,   34,   34,   34,   34,    6,   34,   14,
+       34,    2,   24,    2,   34,   30, 8225,   34,   30, 8225,
+       34,   30, 8225,   30,   34,   30,   17,   34,   34,   34,
+       12,   24,   12,   27, 8225,   34,16417,   23,   24,   23,
+        7,    7,   24,   34,    8,   24,    8,   34,   34,   34,
+       34,    6,   24,    6,    6,   24,    6,   24,   34,    2,
+        2,   24,   34,   34,   10,   12,   12,   24,   27, 8225,
+       34,   27, 8225,   34,   27,   34,   27, 8225,   23,   24,
+       34,    8,    8,   24,   34,   34,   18,   19,    6,    6,
+
+       24,    6,    6,   34,   34,   15,   34,   10,   24,   10,
+       27, 8225,   34,   27, 8225,   34,   27, 8225,   27,   34,
+       27,   34,   34,   34,   18,   24,   18,   19,   24,   19,
+        6,    6,   34,   34,   15,   34,   10,   10,   24,   21,
+        9,   20,   18,   18,   24,   19,   19,   24,    6,    5,
+        6,   34,   22,   21,   24,   21,    9,   24,    9,   20,
+       24,   20,    4,    6,    5,    6,   34,   22,   24,   22,
+       21,   21,   24,    9,    9,   24,   20,   20,   24,    4,
+        6,   13,   34,   22,   22,   24,   13,   34
     } ;
 
-static const flex_int16_t yy_accept[356] =
+static const flex_int16_t yy_accept[368] =
     {   0,
         1,    1,    1,    2,    3,    4,    7,   12,   16,   19,
        21,   24,   27,   30,   33,   36,   39,   42,   45,   48,
@@ -633,39 +634,40 @@ static const flex_int16_t yy_accept[356] =
        74,   76,   79,   81,   82,   83,   84,   87,   87,   88,
        89,   90,   91,   92,   93,   94,   95,   96,   97,   98,
        99,  100,  101,  102,  103,  104,  105,  106,  107,  108,
-      109,  110,  111,  113,  115,  116,  118,  120,  121,  122,
+      109,  110,  111,  112,  114,  116,  117,  119,  121,  122,
       123,  124,  125,  126,  127,  128,  129,  130,  131,  132,
       133,  134,  135,  136,  137,  138,  139,  140,  141,  142,
-      143,  144,  145,  146,  148,  150,  151,  152,  153,  154,
-
-      158,  159,  160,  162,  163,  164,  165,  166,  167,  168,
-      169,  170,  175,  176,  177,  181,  182,  187,  188,  189,
-      194,  195,  196,  197,  198,  199,  202,  205,  207,  209,
-      210,  212,  214,  215,  216,  217,  218,  222,  223,  224,
-      225,  228,  231,  233,  235,  236,  237,  240,  243,  245,
-      247,  250,  253,  255,  257,  258,  261,  264,  266,  268,
-      269,  270,  271,  272,  273,  276,  279,  281,  283,  284,
-      285,  287,  288,  289,  290,  291,  292,  293,  296,  299,
-      301,  303,  304,  305,  309,  312,  315,  317,  319,  320,
-      321,  322,  325,  328,  330,  332,  333,  336,  339,  341,
-
-      343,  344,  345,  348,  351,  353,  355,  356,  357,  358,
-      360,  361,  362,  363,  364,  365,  366,  367,  368,  369,
-      371,  374,  377,  379,  381,  382,  383,  384,  387,  390,
-      392,  394,  396,  397,  398,  399,  400,  401,  403,  405,
-      406,  407,  408,  409,  410,  411,  412,  413,  414,  416,
-      418,  419,  420,  423,  426,  428,  430,  431,  433,  434,
-      436,  437,  441,  443,  444,  445,  447,  448,  450,  451,
-      452,  453,  454,  455,  457,  458,  460,  462,  463,  464,
-      466,  467,  468,  469,  471,  474,  477,  479,  481,  483,
-      484,  485,  487,  488,  489,  490,  491,  492,  494,  495,
-
-      496,  497,  498,  500,  503,  506,  508,  510,  511,  512,
-      513,  514,  516,  517,  519,  520,  521,  522,  523,  524,
-      526,  527,  528,  529,  530,  532,  533,  535,  536,  538,
-      539,  540,  542,  543,  545,  546,  548,  549,  551,  553,
-      554,  556,  557,  558,  560,  561,  563,  564,  566,  568,
-      570,  571,  573,  575,  575
+      143,  144,  145,  146,  147,  148,  150,  152,  153,  154,
+
+      155,  156,  160,  161,  162,  164,  165,  166,  167,  168,
+      169,  170,  171,  172,  177,  178,  179,  183,  184,  185,
+      190,  191,  192,  197,  198,  199,  200,  201,  202,  205,
+      208,  210,  212,  213,  215,  217,  218,  219,  220,  221,
+      225,  226,  227,  228,  231,  234,  236,  238,  239,  240,
+      243,  246,  248,  250,  251,  254,  257,  259,  261,  262,
+      265,  268,  270,  272,  273,  274,  275,  276,  277,  280,
+      283,  285,  287,  288,  289,  291,  292,  293,  294,  295,
+      296,  297,  300,  303,  305,  307,  308,  309,  313,  316,
+      319,  321,  323,  324,  325,  326,  329,  332,  334,  336,
+
+      337,  338,  341,  344,  346,  348,  349,  350,  353,  356,
+      358,  360,  361,  362,  363,  365,  366,  367,  368,  369,
+      370,  371,  372,  373,  374,  376,  379,  382,  384,  386,
+      387,  388,  389,  392,  395,  397,  399,  401,  402,  403,
+      404,  405,  406,  407,  409,  411,  412,  413,  414,  415,
+      416,  417,  418,  419,  420,  422,  424,  425,  426,  429,
+      432,  434,  436,  437,  439,  440,  441,  443,  444,  448,
+      450,  451,  452,  454,  455,  457,  458,  459,  460,  461,
+      462,  464,  465,  467,  469,  470,  471,  473,  474,  475,
+      476,  477,  479,  482,  485,  487,  489,  491,  492,  493,
+
+      495,  496,  497,  498,  499,  500,  502,  503,  504,  505,
+      506,  508,  510,  511,  514,  517,  519,  521,  522,  523,
+      524,  525,  527,  528,  530,  531,  532,  533,  534,  535,
+      537,  538,  540,  541,  542,  543,  544,  546,  547,  549,
+      550,  552,  553,  554,  556,  557,  559,  560,  562,  563,
+      565,  567,  568,  570,  571,  572,  574,  575,  577,  578,
+      580,  582,  584,  585,  587,  589,  589
     } ;
 
 static const YY_CHAR yy_ec[256] =
@@ -708,216 +710,221 @@ static const YY_CHAR yy_meta[35] =
         1,    1,    1,    1
     } ;
 
-static const flex_int16_t yy_base[424] =
+static const flex_int16_t yy_base[438] =
     {   0,
-        0,    0,  901,  900,  902,  897,   33,   36,  905,  905,
-       45,   63,   31,   42,   51,   52,  890,   33,   65,   67,
-       69,   70,  889,   71,  888,   75,    0,  905,  893,  905,
-       91,   94,    0,    0,  103,  886,  112,    0,   89,   98,
-      113,   92,  114,   99,  100,   48,  121,  116,  119,   74,
-      124,  129,  123,  135,  132,  133,  137,  134,  138,  139,
-      141,    0,  155,    0,    0,  164,    0,    0,  849,  142,
-      152,  164,  140,  161,  165,  166,  167,  168,  169,  173,
-      174,  178,  176,  180,  184,  208,  189,  183,  192,  195,
-      215,  191,  193,  223,    0,    0,  905,  208,  204,  236,
-
-      219,  209,  238,  196,  237,  831,  242,  815,  241,  224,
-      243,  261,  244,  259,  277,  266,  286,  250,  288,  298,
-      249,  283,  274,  282,  294,  308,    0,  310,    0,  295,
-      305,  905,  308,  306,  313,  314,  342,  319,  316,  320,
-      331,    0,  349,    0,  342,  344,  356,    0,  358,    0,
-      365,    0,  367,    0,  354,  375,    0,  377,    0,  363,
-      356,  809,  327,  322,  384,    0,    0,    0,    0,  379,
-      905,  382,  384,  386,  390,  372,  392,  403,    0,  410,
-        0,  407,  413,  423,  426,    0,    0,    0,    0,  409,
-      424,  435,    0,    0,    0,    0,  437,    0,    0,    0,
-
-        0,  433,  444,    0,    0,    0,    0,  391,  440,  781,
-      905,  769,  439,  445,  444,  447,  449,  454,  453,  399,
-      464,    0,    0,    0,    0,  757,  465,  476,    0,  478,
-        0,  479,  476,  753,  462,  490,  749,  905,  745,  905,
-      483,  737,  424,  485,  487,  490,  500,  493,  905,  729,
-      905,  502,  518,    0,    0,    0,    0,  905,  498,  721,
-      905,  527,  713,    0,  705,  905,  495,  697,  905,  365,
-      521,  528,  530,  685,  905,  534,  540,  540,  657,  905,
-      537,  542,  650,  905,  553,    0,  557,    0,    0,  551,
-      641,  905,  558,  557,  633,  614,  613,  905,  547,  555,
-
-      563,  565,  569,  584,    0,    0,    0,    0,  583,  570,
-      585,  612,  905,  601,  905,  522,  580,  589,  594,  905,
-      600,  585,  563,  520,  905,  514,  905,  586,  486,  597,
-      480,  441,  905,  416,  905,  345,  905,  334,  905,  601,
-      254,  905,  242,  905,  200,  905,  151,  905,  905,  607,
-       86,  905,  905,  905,  620,  624,  627,  631,  635,  639,
-      643,  647,  651,  655,  659,  663,  667,  671,  675,  679,
-      683,  687,  691,  695,  699,  703,  707,  711,  715,  719,
-      723,  727,  731,  735,  739,  743,  747,  751,  755,  759,
-      763,  767,  771,  775,  779,  783,  787,  791,  795,  799,
-
-      803,  807,  811,  815,  819,  823,  827,  831,  835,  839,
-      843,  847,  851,  855,  859,  863,  867,  871,  875,  879,
-      883,  887,  891
+        0,    0,  927,  926,  928,  923,   33,   36,  931,  931,
+       45,   63,   31,   42,   51,   52,  916,   33,   65,   67,
+       69,   70,  915,   71,  914,   75,    0,  931,  919,  931,
+       91,   95,    0,    0,  104,  912,  113,    0,   91,   99,
+      114,   92,  115,   80,  100,   48,  119,  121,  122,   74,
+      123,  128,  131,  129,  125,  133,  136,  135,  137,  138,
+      140,  142,    0,  165,    0,    0,  167,    0,    0,  917,
+      148,  143,  165,  146,  162,  167,  168,  169,  170,  171,
+      175,  177,  180,  178,  182,  186,  210,  193,  188,  192,
+      196,  197,  218,  211,  185,  226,    0,    0,  931,  210,
+
+      222,  253,  195,  223,  232,  229,  231,  910,  236,  909,
+      237,  230,  249,  267,  253,  261,  279,  224,  242,  288,
+      275,  291,  301,  268,  284,  298,  285,  301,  313,    0,
+      315,    0,  302,  310,  931,  314,  311,  313,  319,  346,
+      323,  320,  324,  353,    0,  355,    0,  332,  348,  362,
+        0,  364,    0,  325,  366,    0,  374,    0,  353,  376,
+        0,  383,    0,  362,  364,  914,  331,  379,  391,    0,
+        0,    0,    0,  378,  931,  384,  386,  389,  393,  399,
+      395,  411,    0,  415,    0,  402,  411,  424,  427,    0,
+        0,    0,    0,  410,  425,  436,    0,    0,    0,    0,
+
+      425,  438,    0,    0,    0,    0,  434,  447,    0,    0,
+        0,    0,  438,  443,  871,  931,  855,  442,  450,  449,
+      452,  454,  459,  458,  453,  469,    0,    0,    0,    0,
+      835,  470,  481,    0,  483,    0,  484,  481,  479,  823,
+      467,  495,  795,  931,  783,  931,  489,  771,  485,  491,
+      493,  496,  508,  504,  931,  767,  931,  511,  523,    0,
+        0,    0,    0,  931,  518,  501,  763,  931,  545,  759,
+        0,  751,  931,  523,  743,  931,  508,  525,  530,  546,
+      735,  931,  552,  553,  555,  727,  931,  549,  501,  719,
+      711,  931,  560,    0,  569,    0,    0,  562,  699,  931,
+
+      530,  567,  671,  664,  655,  931,  562,  566,  571,  573,
+      588,  647,  931,  594,    0,    0,    0,    0,  578,  595,
+      597,  628,  931,  627,  931,  584,  591,  602,  604,  931,
+      626,  931,  625,  624,  623,  622,  931,  603,  931,  598,
+      577,  606,  572,  537,  931,  530,  931,  442,  931,  402,
+      931,  610,  377,  931,  334,  931,  260,  931,  204,  931,
+      931,  621,  147,  931,  931,  931,  634,  638,  641,  645,
+      649,  653,  657,  661,  665,  669,  673,  677,  681,  685,
+      689,  693,  697,  701,  705,  709,  713,  717,  721,  725,
+      729,  733,  737,  741,  745,  749,  753,  757,  761,  765,
+
+      769,  773,  777,  781,  785,  789,  793,  797,  801,  805,
+      809,  813,  817,  821,  825,  829,  833,  837,  841,  845,
+      849,  853,  857,  861,  865,  869,  873,  877,  881,  885,
+      889,  893,  897,  901,  905,  909,  913
     } ;
 
-static const flex_int16_t yy_def[424] =
+static const flex_int16_t yy_def[438] =
     {   0,
-      354,    1,  355,  355,  354,  356,  357,  357,  354,  354,
-      358,  358,   12,   12,   12,   12,   12,   12,   12,   12,
-       12,   12,   12,   12,   12,   12,  359,  354,  356,  354,
-      360,  357,  361,  361,  362,   12,  356,  363,   12,   12,
+      366,    1,  367,  367,  366,  368,  369,  369,  366,  366,
+      370,  370,   12,   12,   12,   12,   12,   12,   12,   12,
+       12,   12,   12,   12,   12,   12,  371,  366,  368,  366,
+      372,  369,  373,  373,  374,   12,  368,  375,   12,   12,
        12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
        12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
-       12,  359,  360,  361,  361,  364,  365,  365,  354,   12,
+       12,   12,  371,  372,  373,  373,  376,  377,  377,  366,
        12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
-       12,   12,   12,   12,   12,  362,   12,   12,   12,   12,
-       12,   12,   12,  364,  365,  365,  354,   12,   12,  366,
-
-       12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
-       12,  367,   86,   86,  368,   12,  369,   12,   12,  370,
-       12,   12,   12,   12,   12,  371,  372,  366,  372,   12,
-       12,  354,   86,   12,   12,   12,  373,   12,   12,   12,
-      374,  375,  367,  375,   86,   86,  376,  377,  368,  377,
-      378,  379,  369,  379,   12,  380,  381,  370,  381,   12,
-       12,  382,   12,   12,  371,  372,  372,  383,  383,   12,
-      354,   86,   86,   86,   12,   12,   12,  384,  385,  373,
-      385,   12,   12,  386,  374,  375,  375,  387,  387,   86,
-       86,  376,  377,  377,  388,  388,  378,  379,  379,  389,
-
-      389,   12,  380,  381,  381,  390,  390,   12,   12,  391,
-      354,  392,   86,   12,   86,   86,   86,   12,   86,   12,
-      384,  385,  385,  393,  393,  394,   86,  395,  396,  386,
-      396,   86,   86,  397,   12,  398,  391,  354,  399,  354,
-       86,  400,   12,   86,   86,   86,  401,   86,  354,  402,
-      354,   86,  395,  396,  396,  403,  403,  354,   86,  404,
-      354,  405,  406,  406,  399,  354,   86,  407,  354,   12,
-       86,   86,   86,  408,  354,  408,  408,   86,  402,  354,
-       86,   86,  404,  354,  409,  410,  405,  410,  406,   86,
-      407,  354,   12,   86,  411,  412,  408,  354,  408,  408,
-
-       86,   86,   86,  409,  410,  410,  413,  413,   86,   12,
-       86,  414,  354,  415,  354,  408,  408,   86,   86,  354,
-      416,  417,  418,  414,  354,  415,  354,  408,  408,   86,
-      419,  420,  354,  421,  354,  422,  354,  408,  354,   86,
-      423,  354,  420,  354,  421,  354,  422,  354,  354,   86,
-      423,  354,  354,    0,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354
+       12,   12,   12,   12,   12,   12,  374,   12,   12,   12,
+       12,   12,   12,   12,   12,  376,  377,  377,  366,   12,
+
+       12,  378,   12,   12,   12,   12,   12,   12,   12,   12,
+       12,   12,   12,  379,   87,   87,  380,   12,   12,  381,
+       12,   12,  382,   12,   12,   12,   12,   12,  383,  384,
+      378,  384,   12,   12,  366,   87,   12,   12,   12,  385,
+       12,   12,   12,  386,  387,  379,  387,   87,   87,  388,
+      389,  380,  389,   12,  390,  391,  381,  391,   12,  392,
+      393,  382,  393,   12,   12,  394,   12,   12,  383,  384,
+      384,  395,  395,   12,  366,   87,   87,   87,   12,   12,
+       12,  396,  397,  385,  397,   12,   12,  398,  386,  387,
+      387,  399,  399,   87,   87,  388,  389,  389,  400,  400,
+
+       12,  390,  391,  391,  401,  401,   12,  392,  393,  393,
+      402,  402,   12,   12,  403,  366,  404,   87,   12,   87,
+       87,   87,   12,   87,   12,  396,  397,  397,  405,  405,
+      406,   87,  407,  408,  398,  408,   87,   87,   12,  409,
+       12,  410,  403,  366,  411,  366,   87,  412,   12,   87,
+       87,   87,  413,   87,  366,  414,  366,   87,  407,  408,
+      408,  415,  415,  366,   87,   12,  416,  366,  417,  418,
+      418,  411,  366,   87,  419,  366,   12,   87,   87,   87,
+      420,  366,  420,  420,   87,  414,  366,   87,   87,  421,
+      416,  366,  422,  423,  417,  423,  418,   87,  419,  366,
+
+       12,   87,  424,  425,  420,  366,  420,  420,   87,   87,
+       87,  426,  366,  422,  423,  423,  427,  427,   87,   12,
+       87,  428,  366,  429,  366,  420,  420,   87,   87,  366,
+      426,  366,  430,  431,  432,  428,  366,  429,  366,  420,
+      420,   87,  433,  434,  366,  435,  366,  436,  366,  420,
+      366,   87,  437,  366,  434,  366,  435,  366,  436,  366,
+      366,   87,  437,  366,  366,    0,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366
     } ;
 
-static const flex_int16_t yy_nxt[940] =
+static const flex_int16_t yy_nxt[966] =
     {   0,
         6,    7,    8,    9,    6,    6,    6,    6,   10,   11,
        12,   13,   14,   15,   16,   17,   18,   19,   17,   17,
        17,   17,   20,   17,   21,   22,   23,   24,   25,   17,
        26,   17,   17,   17,   32,   32,   33,   32,   32,   33,
        36,   34,   36,   42,   34,   29,   29,   29,   30,   35,
-       50,   36,   37,   38,   43,   44,   39,   36,   79,   45,
+       50,   36,   37,   38,   43,   44,   39,   36,   80,   45,
        36,   36,   40,   29,   29,   29,   30,   35,   46,   48,
        37,   38,   41,   47,   36,   49,   36,   53,   36,   36,
-       36,   56,   58,   36,   36,   55,   82,   60,   51,  342,
-       54,   61,   52,   29,   64,   32,   32,   33,   36,   65,
-
-       70,   36,   34,   29,   29,   29,   30,   36,   36,   36,
-       29,   38,   66,   66,   66,   67,   66,   71,   74,   66,
-       68,   72,   36,   36,   73,   36,   77,   78,   36,   76,
-       36,   53,   36,   36,   75,   85,   80,   83,   36,   86,
-       84,   36,   36,   36,   36,   81,   36,   36,   36,   36,
-       36,   36,   93,   89,  337,   98,   88,   29,   64,  101,
-       90,   36,   91,   65,   92,   87,   29,   95,   89,   99,
-       36,  100,   96,   36,   36,   36,   36,   36,   36,  106,
-      105,   85,   36,   36,  102,   36,  107,   36,  103,   36,
-      109,  112,   36,   36,  104,  108,  115,  110,   36,  117,
-
-       36,   36,   36,  335,   36,   36,  122,  111,   29,   29,
-       29,   30,  118,   36,  116,   29,   38,   36,   36,  113,
-      114,  119,  120,  123,   36,   29,   95,  121,   36,  134,
-      131,   96,  130,   36,  125,  124,  126,  126,   66,  127,
-      126,  132,  133,  126,  129,  333,   36,   36,  135,  137,
-       36,   36,   36,  140,  139,   35,   35,  352,   36,   36,
-       85,  141,  141,   66,  142,  141,  160,  145,  141,  144,
-       35,   35,   89,  117,  155,   36,  146,  147,  147,   66,
-      148,  147,  162,   36,  147,  150,  151,  151,   66,  152,
-      151,   36,   36,  151,  154,  120,  161,   36,  156,  156,
-
-       66,  157,  156,   36,   36,  156,  159,  164,  171,  163,
-       29,  166,   29,  168,   36,   36,  167,  170,  169,   35,
-       35,  172,   36,   36,  173,   36,  213,  184,   36,   36,
-      175,   36,  174,   29,  186,  212,   36,  349,  183,  187,
-      177,  176,  178,  178,   66,  179,  178,  182,  348,  178,
-      181,   29,  188,   35,   35,   35,   35,  189,   29,  193,
-       29,  195,  190,   36,  194,   36,  196,   29,  198,   29,
-      200,  191,   36,  199,   36,  201,  219,   29,  204,   29,
-      206,   36,  202,  205,  209,  207,   29,  166,   36,  293,
-      208,  214,  167,   35,   35,   35,   35,   35,   35,   36,
-
-       36,   36,  249,  218,  220,   29,  222,  216,   36,  217,
-      235,  223,   29,  224,  215,  226,   36,  227,  225,  346,
-       35,   35,   36,  228,  228,   66,  229,  228,   29,  186,
-      228,  231,  232,   36,  187,  233,   35,   29,  193,   29,
-      198,  234,   36,  194,  344,  199,   29,  204,  236,   36,
-       35,  241,  205,  242,   36,   35,   35,  270,   35,   35,
-       35,   35,  247,   36,   35,   35,   29,  222,  244,  262,
-      248,   36,  223,  243,  245,  246,   35,  252,   29,  254,
-       29,  256,  258,  342,  255,  259,  257,   35,   35,  339,
-       35,   35,   69,  264,   35,   35,   35,   35,   35,   35,
-
-      267,   35,   35,  275,   35,   35,   35,   35,  271,   35,
-       35,  276,  277,   35,   35,  272,  278,  315,  273,  281,
-       29,  254,  290,  313,  282,  275,  255,  285,  285,   66,
-      286,  285,   35,   35,  285,  288,  295,  298,  296,   35,
-       35,   35,   35,  298,  301,  328,  299,  294,   35,   35,
-      275,   35,   35,   35,  303,   29,  305,  300,  275,   29,
-      307,  306,   35,   35,  302,  308,  337,   36,   35,   35,
-      309,  310,  320,  316,   35,   35,   35,   35,  322,   36,
-       35,   35,  317,  275,  319,  311,   29,  305,  335,  275,
-      318,  321,  306,  323,   35,   35,   35,   35,  330,  329,
-
-       35,   35,  331,  333,  327,   35,   35,  338,   35,   35,
-      353,  340,   35,   35,  350,  325,  275,  315,   35,   35,
-       27,   27,   27,   27,   29,   29,   29,   31,   31,   31,
-       31,   36,   36,   36,   36,   62,  313,   62,   62,   63,
-       63,   63,   63,   65,  269,   65,   65,   35,   35,   35,
-       35,   69,   69,  261,   69,   94,   94,   94,   94,   96,
-      251,   96,   96,  128,  128,  128,  128,  143,  143,  143,
-      143,  149,  149,  149,  149,  153,  153,  153,  153,  158,
-      158,  158,  158,  165,  165,  165,  165,  167,  298,  167,
-      167,  180,  180,  180,  180,  185,  185,  185,  185,  187,
-
-      292,  187,  187,  192,  192,  192,  192,  194,  240,  194,
-      194,  197,  197,  197,  197,  199,  289,  199,  199,  203,
-      203,  203,  203,  205,  284,  205,  205,  210,  210,  210,
-      210,  169,  280,  169,  169,  221,  221,  221,  221,  223,
-      269,  223,  223,  230,  230,  230,  230,  189,  266,  189,
-      189,  196,  211,  196,  196,  201,  261,  201,  201,  207,
-      251,  207,  207,  237,  237,  237,  237,  239,  239,  239,
-      239,  225,  240,  225,  225,  250,  250,  250,  250,  253,
-      253,  253,  253,  255,  238,  255,  255,  260,  260,  260,
-      260,  263,  263,  263,  263,  265,  265,  265,  265,  268,
-
-      268,  268,  268,  274,  274,  274,  274,  279,  279,  279,
-      279,  257,  211,  257,  257,  283,  283,  283,  283,  287,
-      287,  287,  287,  264,  138,  264,  264,  291,  291,  291,
-      291,  297,  297,  297,  297,  304,  304,  304,  304,  306,
-      136,  306,  306,  312,  312,  312,  312,  314,  314,  314,
-      314,  308,   97,  308,  308,  324,  324,  324,  324,  326,
-      326,  326,  326,  332,  332,  332,  332,  334,  334,  334,
-      334,  336,  336,  336,  336,  341,  341,  341,  341,  343,
-      343,  343,  343,  345,  345,  345,  345,  347,  347,  347,
-      347,  351,  351,  351,  351,   36,   30,   59,   57,   36,
-
-       30,  354,   28,   28,    5,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354
+       36,   57,   59,   36,   36,   55,   83,   61,   51,   36,
+       54,   62,   52,   29,   65,   56,   32,   32,   33,   66,
+
+       36,   36,   71,   34,   29,   29,   29,   30,   36,   36,
+       77,   29,   38,   67,   67,   67,   68,   67,   75,   72,
+       67,   69,   73,   36,   36,   74,   78,   79,   36,   53,
+       36,   36,   36,   87,   36,   76,   84,   36,   36,   85,
+       36,   81,   36,   86,   36,   36,   36,   36,   82,   36,
+      354,   36,   36,   95,   91,   36,   89,   36,   88,   90,
+      101,  100,   93,   92,   94,  103,   91,   29,   65,   29,
+       97,   36,  102,   66,   36,   98,   36,   36,   36,   36,
+       36,  108,  107,   86,   36,  104,   36,   36,  109,   36,
+      105,   36,  111,  114,   36,   36,  106,   36,  110,  112,
+
+      117,   36,   36,  120,   36,   36,   36,  349,  133,  113,
+       29,   29,   29,   30,  121,  126,  118,   29,   38,   36,
+       36,  115,  116,  119,  122,  123,  125,   36,   29,   97,
+      124,   36,   36,   36,   98,  135,  136,  127,   36,   36,
+       36,   36,  138,  140,  134,   36,   36,  154,   91,  120,
+      142,   36,  128,  129,  129,   67,  130,  129,   36,  143,
+      129,  132,  137,  347,   35,   35,   86,  144,  144,   67,
+      145,  144,   35,   35,  144,  147,  148,   36,  149,  150,
+      150,   67,  151,  150,   36,  164,  150,  153,  155,  155,
+       67,  156,  155,   36,   36,  155,  158,  165,  123,  159,
+
+       36,  160,  160,   67,  161,  160,  166,   36,  160,  163,
+       36,   36,  167,  175,  168,   29,  170,   29,  172,   36,
+       36,  171,   36,  173,  174,   35,   35,  176,   36,   36,
+      177,  188,   36,   36,   36,  179,  201,  345,  178,  217,
+       36,  180,  187,   35,   35,  181,  182,  182,   67,  183,
+      182,  186,  194,  182,  185,   29,  190,   29,  192,   35,
+       35,  191,   36,  193,   29,  197,   29,  199,   29,  203,
+      198,   36,  200,   36,  204,  195,   29,  205,   29,  209,
+      364,  207,  206,  218,  210,   29,  211,   36,   36,  213,
+      219,  212,  214,   29,  170,   35,   35,   35,   35,  171,
+
+       35,   35,   36,  224,   36,  361,  223,  225,   36,  221,
+      231,   36,  222,   29,  227,  232,  220,   29,  229,  228,
+       36,   35,   35,  230,  233,  233,   67,  234,  233,   29,
+      190,  233,  236,  237,   36,  191,  238,   35,   29,  197,
+       29,  203,  240,   36,  198,  360,  204,   36,  239,   29,
+      209,  242,   36,   35,  247,  210,  255,  241,  248,   36,
+       35,   35,   36,   35,   35,   35,   35,  253,   36,   35,
+       35,   29,  227,  250,  269,  254,   36,  228,  249,  251,
+      252,   35,  258,   29,  260,   29,  262,  264,   36,  261,
+      265,  263,   35,   35,   36,   35,   35,   70,  271,  266,
+
+       35,   35,   35,   35,   35,   35,  274,   35,   35,  290,
+       36,  282,   35,  311,  278,   35,   35,   36,  277,  283,
+      284,  279,   35,   35,  280,   29,  260,  285,  288,   35,
+       35,  261,  301,  358,   35,   35,   35,   35,  303,   36,
+      356,   35,   35,  320,  289,  293,  293,   67,  294,  293,
+      298,  302,  293,  296,  304,  306,  306,   35,   35,  309,
+       35,   35,   29,  315,  307,  282,   35,   35,  316,  282,
+      308,   29,  317,   35,   35,  354,  310,  318,   35,   35,
+      351,  319,   35,   35,   35,   35,  333,  282,  326,   35,
+       35,  330,  329,  327,  282,  321,   29,  315,  328,   35,
+
+       35,  282,  316,  334,   36,  335,  325,  340,   35,   35,
+      341,  342,  343,   35,   35,   35,   35,   35,   35,  350,
+      352,   35,   35,  362,  365,  323,  349,  347,  345,  313,
+      339,  337,   35,   35,   27,   27,   27,   27,   29,   29,
+       29,   31,   31,   31,   31,   36,   36,   36,   36,   63,
+      332,   63,   63,   64,   64,   64,   64,   66,  282,   66,
+       66,   35,   35,   35,   35,   70,   70,  325,   70,   96,
+       96,   96,   96,   98,  323,   98,   98,  131,  131,  131,
+      131,  146,  146,  146,  146,  152,  152,  152,  152,  157,
+      157,  157,  157,  162,  162,  162,  162,  169,  169,  169,
+
+      169,  171,  276,  171,  171,  184,  184,  184,  184,  189,
+      189,  189,  189,  191,  268,  191,  191,  196,  196,  196,
+      196,  198,  313,  198,  198,  202,  202,  202,  202,  204,
+      257,  204,  204,  208,  208,  208,  208,  210,  306,  210,
+      210,  215,  215,  215,  215,  173,  300,  173,  173,  226,
+      226,  226,  226,  228,  246,  228,  228,  235,  235,  235,
+      235,  193,  297,  193,  193,  200,  292,  200,  200,  206,
+      287,  206,  206,  212,  276,  212,  212,  243,  243,  243,
+      243,  245,  245,  245,  245,  230,  273,  230,  230,  256,
+      256,  256,  256,  259,  259,  259,  259,  261,  216,  261,
+
+      261,  267,  267,  267,  267,  270,  270,  270,  270,  272,
+      272,  272,  272,  275,  275,  275,  275,  281,  281,  281,
+      281,  286,  286,  286,  286,  263,  268,  263,  263,  291,
+      291,  291,  291,  295,  295,  295,  295,  271,  257,  271,
+      271,  299,  299,  299,  299,  305,  305,  305,  305,  312,
+      312,  312,  312,  314,  314,  314,  314,  316,  246,  316,
+      316,  322,  322,  322,  322,  324,  324,  324,  324,  331,
+      331,  331,  331,  318,  244,  318,  318,  336,  336,  336,
+      336,  338,  338,  338,  338,  344,  344,  344,  344,  346,
+      346,  346,  346,  348,  348,  348,  348,  353,  353,  353,
+
+      353,  355,  355,  355,  355,  357,  357,  357,  357,  359,
+      359,  359,  359,  363,  363,  363,  363,  216,  141,  139,
+       99,   36,   30,   60,   58,   36,   30,  366,   28,   28,
+        5,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366
     } ;
 
-static const flex_int16_t yy_chk[940] =
+static const flex_int16_t yy_chk[966] =
     {   0,
         1,    1,    1,    1,    1,    1,    1,    1,    1,    1,
         1,    1,    1,    1,    1,    1,    1,    1,    1,    1,
@@ -927,101 +934,104 @@ static const flex_int16_t yy_chk[940] =
        18,   14,   11,   11,   13,   14,   11,   46,   46,   14,
        15,   16,   11,   12,   12,   12,   12,   12,   14,   16,
        12,   12,   12,   15,   19,   16,   20,   20,   21,   22,
-       24,   22,   24,   50,   26,   21,   50,   26,   19,  351,
-       20,   26,   19,   31,   31,   32,   32,   32,   39,   31,
-
-       39,   42,   32,   35,   35,   35,   35,   40,   44,   45,
-       35,   35,   37,   37,   37,   37,   37,   39,   42,   37,
-       37,   40,   41,   43,   41,   48,   45,   45,   49,   44,
-       47,   47,   53,   51,   43,   53,   48,   51,   52,   54,
-       52,   55,   56,   58,   54,   49,   57,   59,   60,   73,
-       61,   70,   60,   61,  347,   70,   56,   63,   63,   73,
-       58,   71,   59,   63,   59,   55,   66,   66,   57,   71,
-       74,   72,   66,   72,   75,   76,   77,   78,   79,   78,
-       77,   79,   80,   81,   74,   83,   80,   82,   75,   84,
-       82,   85,   88,   85,   76,   81,   87,   83,   87,   89,
-
-       92,   89,   93,  345,   90,  104,   92,   84,   86,   86,
-       86,   86,   90,   99,   88,   86,   86,   98,  102,   86,
-       86,   91,   91,   93,   91,   94,   94,   91,  101,  104,
-      102,   94,  101,  110,   99,   98,  100,  100,  100,  100,
-      100,  103,  103,  100,  100,  343,  105,  103,  105,  107,
-      109,  107,  111,  110,  109,  113,  113,  341,  121,  118,
-      111,  112,  112,  112,  112,  112,  121,  113,  112,  112,
-      114,  114,  116,  116,  118,  116,  114,  115,  115,  115,
-      115,  115,  123,  123,  115,  115,  117,  117,  117,  117,
-      117,  124,  122,  117,  117,  119,  122,  119,  120,  120,
-
-      120,  120,  120,  125,  130,  120,  120,  125,  131,  124,
-      126,  126,  128,  128,  131,  134,  126,  130,  128,  133,
-      133,  133,  135,  136,  133,  139,  164,  140,  138,  140,
-      134,  164,  133,  141,  141,  163,  163,  338,  139,  141,
-      136,  135,  137,  137,  137,  137,  137,  138,  336,  137,
-      137,  143,  143,  145,  145,  146,  146,  143,  147,  147,
-      149,  149,  145,  155,  147,  161,  149,  151,  151,  153,
-      153,  146,  160,  151,  270,  153,  176,  156,  156,  158,
-      158,  176,  155,  156,  161,  158,  165,  165,  170,  270,
-      160,  170,  165,  172,  172,  173,  173,  174,  174,  175,
-
-      208,  177,  220,  175,  177,  178,  178,  173,  220,  174,
-      208,  178,  180,  180,  172,  182,  182,  183,  180,  334,
-      190,  190,  183,  184,  184,  184,  184,  184,  185,  185,
-      184,  184,  190,  243,  185,  191,  191,  192,  192,  197,
-      197,  202,  202,  192,  332,  197,  203,  203,  209,  209,
-      213,  213,  203,  214,  214,  215,  215,  243,  216,  216,
-      217,  217,  218,  218,  219,  219,  221,  221,  215,  235,
-      219,  235,  221,  214,  216,  217,  227,  227,  228,  228,
-      230,  230,  232,  331,  228,  233,  230,  233,  233,  329,
-      232,  232,  236,  236,  241,  241,  244,  244,  245,  245,
-
-      241,  246,  246,  247,  248,  248,  267,  267,  244,  259,
-      259,  247,  247,  252,  252,  245,  248,  326,  246,  252,
-      253,  253,  267,  324,  259,  316,  253,  262,  262,  262,
-      262,  262,  271,  271,  262,  262,  272,  276,  273,  272,
-      272,  273,  273,  277,  278,  316,  276,  271,  281,  281,
-      299,  278,  278,  282,  282,  285,  285,  277,  300,  287,
-      287,  285,  290,  290,  281,  287,  323,  293,  294,  294,
-      290,  293,  303,  299,  301,  301,  302,  302,  310,  310,
-      303,  303,  300,  317,  302,  294,  304,  304,  322,  328,
-      301,  309,  304,  311,  309,  309,  311,  311,  318,  317,
-
-      318,  318,  319,  321,  314,  319,  319,  328,  330,  330,
-      350,  330,  340,  340,  340,  312,  297,  296,  350,  350,
-      355,  355,  355,  355,  356,  356,  356,  357,  357,  357,
-      357,  358,  358,  358,  358,  359,  295,  359,  359,  360,
-      360,  360,  360,  361,  291,  361,  361,  362,  362,  362,
-      362,  363,  363,  283,  363,  364,  364,  364,  364,  365,
-      279,  365,  365,  366,  366,  366,  366,  367,  367,  367,
-      367,  368,  368,  368,  368,  369,  369,  369,  369,  370,
-      370,  370,  370,  371,  371,  371,  371,  372,  274,  372,
-      372,  373,  373,  373,  373,  374,  374,  374,  374,  375,
-
-      268,  375,  375,  376,  376,  376,  376,  377,  265,  377,
-      377,  378,  378,  378,  378,  379,  263,  379,  379,  380,
-      380,  380,  380,  381,  260,  381,  381,  382,  382,  382,
-      382,  383,  250,  383,  383,  384,  384,  384,  384,  385,
-      242,  385,  385,  386,  386,  386,  386,  387,  239,  387,
-      387,  388,  237,  388,  388,  389,  234,  389,  389,  390,
-      226,  390,  390,  391,  391,  391,  391,  392,  392,  392,
-      392,  393,  212,  393,  393,  394,  394,  394,  394,  395,
-      395,  395,  395,  396,  210,  396,  396,  397,  397,  397,
-      397,  398,  398,  398,  398,  399,  399,  399,  399,  400,
-
-      400,  400,  400,  401,  401,  401,  401,  402,  402,  402,
-      402,  403,  162,  403,  403,  404,  404,  404,  404,  405,
-      405,  405,  405,  406,  108,  406,  406,  407,  407,  407,
-      407,  408,  408,  408,  408,  409,  409,  409,  409,  410,
-      106,  410,  410,  411,  411,  411,  411,  412,  412,  412,
-      412,  413,   69,  413,  413,  414,  414,  414,  414,  415,
-      415,  415,  415,  416,  416,  416,  416,  417,  417,  417,
-      417,  418,  418,  418,  418,  419,  419,  419,  419,  420,
-      420,  420,  420,  421,  421,  421,  421,  422,  422,  422,
-      422,  423,  423,  423,  423,   36,   29,   25,   23,   17,
-
-        6,    5,    4,    3,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354
+       24,   22,   24,   50,   26,   21,   50,   26,   19,   44,
+       20,   26,   19,   31,   31,   21,   32,   32,   32,   31,
+
+       39,   42,   39,   32,   35,   35,   35,   35,   40,   45,
+       44,   35,   35,   37,   37,   37,   37,   37,   42,   39,
+       37,   37,   40,   41,   43,   41,   45,   45,   47,   47,
+       48,   49,   51,   54,   55,   43,   51,   52,   54,   52,
+       53,   48,   56,   53,   58,   57,   59,   60,   49,   61,
+      363,   62,   72,   61,   62,   74,   56,   71,   55,   57,
+       72,   71,   60,   59,   60,   74,   58,   64,   64,   67,
+       67,   75,   73,   64,   73,   67,   76,   77,   78,   79,
+       80,   79,   78,   80,   81,   75,   82,   84,   81,   83,
+       76,   85,   83,   86,   95,   86,   77,   89,   82,   84,
+
+       88,   90,   88,   91,  103,   91,   92,  359,  103,   85,
+       87,   87,   87,   87,   92,   95,   89,   87,   87,  100,
+       94,   87,   87,   90,   93,   93,   94,   93,   96,   96,
+       93,  101,  104,  118,   96,  105,  105,  100,  106,  112,
+      107,  105,  107,  109,  104,  109,  111,  118,  119,  119,
+      111,  119,  101,  102,  102,  102,  102,  102,  113,  112,
+      102,  102,  106,  357,  115,  115,  113,  114,  114,  114,
+      114,  114,  116,  116,  114,  114,  115,  124,  116,  117,
+      117,  117,  117,  117,  121,  124,  117,  117,  120,  120,
+      120,  120,  120,  125,  127,  120,  120,  125,  122,  121,
+
+      122,  123,  123,  123,  123,  123,  126,  126,  123,  123,
+      128,  133,  127,  134,  128,  129,  129,  131,  131,  134,
+      137,  129,  138,  131,  133,  136,  136,  136,  139,  142,
+      136,  143,  141,  143,  154,  137,  154,  355,  136,  167,
+      167,  138,  142,  148,  148,  139,  140,  140,  140,  140,
+      140,  141,  148,  140,  140,  144,  144,  146,  146,  149,
+      149,  144,  159,  146,  150,  150,  152,  152,  155,  155,
+      150,  164,  152,  165,  155,  149,  157,  157,  160,  160,
+      353,  159,  157,  168,  160,  162,  162,  174,  168,  164,
+      174,  162,  165,  169,  169,  176,  176,  177,  177,  169,
+
+      178,  178,  179,  180,  181,  350,  179,  181,  180,  177,
+      186,  186,  178,  182,  182,  187,  176,  184,  184,  182,
+      187,  194,  194,  184,  188,  188,  188,  188,  188,  189,
+      189,  188,  188,  194,  201,  189,  195,  195,  196,  196,
+      202,  202,  207,  207,  196,  348,  202,  213,  201,  208,
+      208,  214,  214,  218,  218,  208,  225,  213,  219,  219,
+      220,  220,  225,  221,  221,  222,  222,  223,  223,  224,
+      224,  226,  226,  220,  241,  224,  241,  226,  219,  221,
+      222,  232,  232,  233,  233,  235,  235,  237,  239,  233,
+      238,  235,  238,  238,  249,  237,  237,  242,  242,  239,
+
+      247,  247,  250,  250,  251,  251,  247,  252,  252,  266,
+      266,  253,  289,  289,  250,  254,  254,  277,  249,  253,
+      253,  251,  258,  258,  252,  259,  259,  254,  258,  265,
+      265,  259,  277,  346,  274,  274,  278,  278,  279,  301,
+      344,  279,  279,  301,  265,  269,  269,  269,  269,  269,
+      274,  278,  269,  269,  280,  283,  284,  280,  280,  285,
+      288,  288,  293,  293,  283,  307,  285,  285,  293,  308,
+      284,  295,  295,  298,  298,  343,  288,  295,  302,  302,
+      341,  298,  309,  309,  310,  310,  319,  326,  307,  319,
+      319,  311,  310,  308,  327,  302,  314,  314,  309,  311,
+
+      311,  340,  314,  320,  320,  321,  338,  326,  321,  321,
+      327,  328,  329,  328,  328,  329,  329,  342,  342,  340,
+      342,  352,  352,  352,  362,  336,  335,  334,  333,  331,
+      324,  322,  362,  362,  367,  367,  367,  367,  368,  368,
+      368,  369,  369,  369,  369,  370,  370,  370,  370,  371,
+      312,  371,  371,  372,  372,  372,  372,  373,  305,  373,
+      373,  374,  374,  374,  374,  375,  375,  304,  375,  376,
+      376,  376,  376,  377,  303,  377,  377,  378,  378,  378,
+      378,  379,  379,  379,  379,  380,  380,  380,  380,  381,
+      381,  381,  381,  382,  382,  382,  382,  383,  383,  383,
+
+      383,  384,  299,  384,  384,  385,  385,  385,  385,  386,
+      386,  386,  386,  387,  291,  387,  387,  388,  388,  388,
+      388,  389,  290,  389,  389,  390,  390,  390,  390,  391,
+      286,  391,  391,  392,  392,  392,  392,  393,  281,  393,
+      393,  394,  394,  394,  394,  395,  275,  395,  395,  396,
+      396,  396,  396,  397,  272,  397,  397,  398,  398,  398,
+      398,  399,  270,  399,  399,  400,  267,  400,  400,  401,
+      256,  401,  401,  402,  248,  402,  402,  403,  403,  403,
+      403,  404,  404,  404,  404,  405,  245,  405,  405,  406,
+      406,  406,  406,  407,  407,  407,  407,  408,  243,  408,
+
+      408,  409,  409,  409,  409,  410,  410,  410,  410,  411,
+      411,  411,  411,  412,  412,  412,  412,  413,  413,  413,
+      413,  414,  414,  414,  414,  415,  240,  415,  415,  416,
+      416,  416,  416,  417,  417,  417,  417,  418,  231,  418,
+      418,  419,  419,  419,  419,  420,  420,  420,  420,  421,
+      421,  421,  421,  422,  422,  422,  422,  423,  217,  423,
+      423,  424,  424,  424,  424,  425,  425,  425,  425,  426,
+      426,  426,  426,  427,  215,  427,  427,  428,  428,  428,
+      428,  429,  429,  429,  429,  430,  430,  430,  430,  431,
+      431,  431,  431,  432,  432,  432,  432,  433,  433,  433,
+
+      433,  434,  434,  434,  434,  435,  435,  435,  435,  436,
+      436,  436,  436,  437,  437,  437,  437,  166,  110,  108,
+       70,   36,   29,   25,   23,   17,    6,    5,    4,    3,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366,  366,  366,  366,  366,  366,
+      366,  366,  366,  366,  366
     } ;
 
 #define YY_TRAILING_MASK 0x2000
@@ -1160,9 +1170,17 @@ static void setbackendtype(DiskParseContext *dpc, const char *str) {
     if (     !strcmp(str,"phy"))   DSET(dpc,backend,BACKEND,str,PHY);
     else if (!strcmp(str,"tap"))   DSET(dpc,backend,BACKEND,str,TAP);
     else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK);
+    else if (!strcmp(str,"other")) DSET(dpc,backend,BACKEND,str,OTHER);
     else xlu__disk_err(dpc,str,"unknown value for backendtype");
 }
 
+/* Sets ->protocol from the string.  IDL should provide something for this. */
+static void setprotocol(DiskParseContext *dpc, const char *str) {
+    if      (!strcmp(str,"xen"))         DSET(dpc,protocol,PROTOCOL,str,XEN);
+    else if (!strcmp(str,"virtio-mmio")) DSET(dpc,protocol,PROTOCOL,str,VIRTIO_MMIO);
+    else xlu__disk_err(dpc,str,"unknown value for protocol");
+}
+
 /* Sets ->colo-port from the string.  COLO need this. */
 static void setcoloport(DiskParseContext *dpc, const char *str) {
     int port = atoi(str);
@@ -1199,9 +1217,9 @@ static int vdev_and_devtype(DiskParseContext *dpc, char *str) {
 #undef DPC /* needs to be defined differently the actual lexer */
 #define DPC ((DiskParseContext*)yyextra)
 
-#line 1202 "libxlu_disk_l.c"
+#line 1220 "libxlu_disk_l.c"
 
-#line 1204 "libxlu_disk_l.c"
+#line 1222 "libxlu_disk_l.c"
 
 #define INITIAL 0
 #define LEXERR 1
@@ -1477,13 +1495,13 @@ YY_DECL
 		}
 
 	{
-#line 177 "libxlu_disk_l.l"
+#line 185 "libxlu_disk_l.l"
 
 
-#line 180 "libxlu_disk_l.l"
+#line 188 "libxlu_disk_l.l"
  /*----- the scanner rules which do the parsing -----*/
 
-#line 1486 "libxlu_disk_l.c"
+#line 1504 "libxlu_disk_l.c"
 
 	while ( /*CONSTCOND*/1 )		/* loops until end-of-file is reached */
 		{
@@ -1515,14 +1533,14 @@ yy_match:
 			while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 				{
 				yy_current_state = (int) yy_def[yy_current_state];
-				if ( yy_current_state >= 355 )
+				if ( yy_current_state >= 367 )
 					yy_c = yy_meta[yy_c];
 				}
 			yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c];
 			*yyg->yy_state_ptr++ = yy_current_state;
 			++yy_cp;
 			}
-		while ( yy_current_state != 354 );
+		while ( yy_current_state != 366 );
 
 yy_find_action:
 		yy_current_state = *--yyg->yy_state_ptr;
@@ -1572,152 +1590,158 @@ do_action:	/* This label is used only to access EOF actions. */
 case 1:
 /* rule 1 can match eol */
 YY_RULE_SETUP
-#line 182 "libxlu_disk_l.l"
+#line 190 "libxlu_disk_l.l"
 { /* ignore whitespace before parameters */ }
 	YY_BREAK
 /* ordinary parameters setting enums or strings */
 case 2:
 /* rule 2 can match eol */
 YY_RULE_SETUP
-#line 186 "libxlu_disk_l.l"
+#line 194 "libxlu_disk_l.l"
 { STRIP(','); setformat(DPC, FROMEQUALS); }
 	YY_BREAK
 case 3:
 YY_RULE_SETUP
-#line 188 "libxlu_disk_l.l"
+#line 196 "libxlu_disk_l.l"
 { DPC->disk->is_cdrom = 1; }
 	YY_BREAK
 case 4:
 YY_RULE_SETUP
-#line 189 "libxlu_disk_l.l"
+#line 197 "libxlu_disk_l.l"
 { DPC->disk->is_cdrom = 1; }
 	YY_BREAK
 case 5:
 YY_RULE_SETUP
-#line 190 "libxlu_disk_l.l"
+#line 198 "libxlu_disk_l.l"
 { DPC->disk->is_cdrom = 0; }
 	YY_BREAK
 case 6:
 /* rule 6 can match eol */
 YY_RULE_SETUP
-#line 191 "libxlu_disk_l.l"
+#line 199 "libxlu_disk_l.l"
 { xlu__disk_err(DPC,yytext,"unknown value for type"); }
 	YY_BREAK
 case 7:
 /* rule 7 can match eol */
 YY_RULE_SETUP
-#line 193 "libxlu_disk_l.l"
+#line 201 "libxlu_disk_l.l"
 { STRIP(','); setaccess(DPC, FROMEQUALS); }
 	YY_BREAK
 case 8:
 /* rule 8 can match eol */
 YY_RULE_SETUP
-#line 194 "libxlu_disk_l.l"
+#line 202 "libxlu_disk_l.l"
 { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); }
 	YY_BREAK
 case 9:
 /* rule 9 can match eol */
 YY_RULE_SETUP
-#line 195 "libxlu_disk_l.l"
+#line 203 "libxlu_disk_l.l"
 { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
 	YY_BREAK
 case 10:
 /* rule 10 can match eol */
 YY_RULE_SETUP
-#line 197 "libxlu_disk_l.l"
-{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); }
+#line 204 "libxlu_disk_l.l"
+{ STRIP(','); setprotocol(DPC,FROMEQUALS); }
 	YY_BREAK
 case 11:
 /* rule 11 can match eol */
 YY_RULE_SETUP
-#line 198 "libxlu_disk_l.l"
-{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); }
+#line 206 "libxlu_disk_l.l"
+{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); }
 	YY_BREAK
 case 12:
+/* rule 12 can match eol */
 YY_RULE_SETUP
-#line 199 "libxlu_disk_l.l"
-{ DPC->disk->direct_io_safe = 1; }
+#line 207 "libxlu_disk_l.l"
+{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); }
 	YY_BREAK
 case 13:
 YY_RULE_SETUP
-#line 200 "libxlu_disk_l.l"
-{ libxl_defbool_set(&DPC->disk->discard_enable, true); }
+#line 208 "libxlu_disk_l.l"
+{ DPC->disk->direct_io_safe = 1; }
 	YY_BREAK
 case 14:
 YY_RULE_SETUP
-#line 201 "libxlu_disk_l.l"
-{ libxl_defbool_set(&DPC->disk->discard_enable, false); }
+#line 209 "libxlu_disk_l.l"
+{ libxl_defbool_set(&DPC->disk->discard_enable, true); }
 	YY_BREAK
-/* Note that the COLO configuration settings should be considered unstable.
-  * They may change incompatibly in future versions of Xen. */
 case 15:
 YY_RULE_SETUP
-#line 204 "libxlu_disk_l.l"
-{ libxl_defbool_set(&DPC->disk->colo_enable, true); }
+#line 210 "libxlu_disk_l.l"
+{ libxl_defbool_set(&DPC->disk->discard_enable, false); }
 	YY_BREAK
+/* Note that the COLO configuration settings should be considered unstable.
+  * They may change incompatibly in future versions of Xen. */
 case 16:
 YY_RULE_SETUP
-#line 205 "libxlu_disk_l.l"
-{ libxl_defbool_set(&DPC->disk->colo_enable, false); }
+#line 213 "libxlu_disk_l.l"
+{ libxl_defbool_set(&DPC->disk->colo_enable, true); }
 	YY_BREAK
 case 17:
-/* rule 17 can match eol */
 YY_RULE_SETUP
-#line 206 "libxlu_disk_l.l"
-{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); }
+#line 214 "libxlu_disk_l.l"
+{ libxl_defbool_set(&DPC->disk->colo_enable, false); }
 	YY_BREAK
 case 18:
 /* rule 18 can match eol */
 YY_RULE_SETUP
-#line 207 "libxlu_disk_l.l"
-{ STRIP(','); setcoloport(DPC, FROMEQUALS); }
+#line 215 "libxlu_disk_l.l"
+{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); }
 	YY_BREAK
 case 19:
 /* rule 19 can match eol */
 YY_RULE_SETUP
-#line 208 "libxlu_disk_l.l"
-{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); }
+#line 216 "libxlu_disk_l.l"
+{ STRIP(','); setcoloport(DPC, FROMEQUALS); }
 	YY_BREAK
 case 20:
 /* rule 20 can match eol */
 YY_RULE_SETUP
-#line 209 "libxlu_disk_l.l"
-{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); }
+#line 217 "libxlu_disk_l.l"
+{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); }
 	YY_BREAK
 case 21:
 /* rule 21 can match eol */
 YY_RULE_SETUP
-#line 210 "libxlu_disk_l.l"
+#line 218 "libxlu_disk_l.l"
+{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); }
+	YY_BREAK
+case 22:
+/* rule 22 can match eol */
+YY_RULE_SETUP
+#line 219 "libxlu_disk_l.l"
 { STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); }
 	YY_BREAK
 /* the target magic parameter, eats the rest of the string */
-case 22:
+case 23:
 YY_RULE_SETUP
-#line 214 "libxlu_disk_l.l"
+#line 223 "libxlu_disk_l.l"
 { STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); }
 	YY_BREAK
 /* unknown parameters */
-case 23:
-/* rule 23 can match eol */
+case 24:
+/* rule 24 can match eol */
 YY_RULE_SETUP
-#line 218 "libxlu_disk_l.l"
+#line 227 "libxlu_disk_l.l"
 { xlu__disk_err(DPC,yytext,"unknown parameter"); }
 	YY_BREAK
 /* deprecated prefixes */
 /* the "/.*" in these patterns ensures that they count as if they
    * matched the whole string, so these patterns take precedence */
-case 24:
+case 25:
 YY_RULE_SETUP
-#line 225 "libxlu_disk_l.l"
+#line 234 "libxlu_disk_l.l"
 {
                     STRIP(':');
                     DPC->had_depr_prefix=1; DEPRECATE("use `[format=]...,'");
                     setformat(DPC, yytext);
                  }
 	YY_BREAK
-case 25:
+case 26:
 YY_RULE_SETUP
-#line 231 "libxlu_disk_l.l"
+#line 240 "libxlu_disk_l.l"
 {
                     char *newscript;
                     STRIP(':');
@@ -1731,65 +1755,65 @@ YY_RULE_SETUP
                     free(newscript);
                 }
 	YY_BREAK
-case 26:
+case 27:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
 yyg->yy_c_buf_p = yy_cp = yy_bp + 8;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
-#line 244 "libxlu_disk_l.l"
+#line 253 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
-case 27:
+case 28:
 YY_RULE_SETUP
-#line 245 "libxlu_disk_l.l"
+#line 254 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
-case 28:
+case 29:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
 yyg->yy_c_buf_p = yy_cp = yy_bp + 4;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
-#line 246 "libxlu_disk_l.l"
+#line 255 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
-case 29:
+case 30:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
 yyg->yy_c_buf_p = yy_cp = yy_bp + 6;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
-#line 247 "libxlu_disk_l.l"
+#line 256 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
-case 30:
+case 31:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
 yyg->yy_c_buf_p = yy_cp = yy_bp + 5;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
-#line 248 "libxlu_disk_l.l"
+#line 257 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
-case 31:
+case 32:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
 yyg->yy_c_buf_p = yy_cp = yy_bp + 4;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
-#line 249 "libxlu_disk_l.l"
+#line 258 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
-case 32:
-/* rule 32 can match eol */
+case 33:
+/* rule 33 can match eol */
 YY_RULE_SETUP
-#line 251 "libxlu_disk_l.l"
+#line 260 "libxlu_disk_l.l"
 {
 		  xlu__disk_err(DPC,yytext,"unknown deprecated disk prefix");
 		  return 0;
 		}
 	YY_BREAK
 /* positional parameters */
-case 33:
-/* rule 33 can match eol */
+case 34:
+/* rule 34 can match eol */
 YY_RULE_SETUP
-#line 258 "libxlu_disk_l.l"
+#line 267 "libxlu_disk_l.l"
 {
     STRIP(',');
 
@@ -1816,27 +1840,27 @@ YY_RULE_SETUP
     }
 }
 	YY_BREAK
-case 34:
+case 35:
 YY_RULE_SETUP
-#line 284 "libxlu_disk_l.l"
+#line 293 "libxlu_disk_l.l"
 {
     BEGIN(LEXERR);
     yymore();
 }
 	YY_BREAK
-case 35:
+case 36:
 YY_RULE_SETUP
-#line 288 "libxlu_disk_l.l"
+#line 297 "libxlu_disk_l.l"
 {
     xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0;
 }
 	YY_BREAK
-case 36:
+case 37:
 YY_RULE_SETUP
-#line 291 "libxlu_disk_l.l"
+#line 300 "libxlu_disk_l.l"
 YY_FATAL_ERROR( "flex scanner jammed" );
 	YY_BREAK
-#line 1839 "libxlu_disk_l.c"
+#line 1863 "libxlu_disk_l.c"
 			case YY_STATE_EOF(INITIAL):
 			case YY_STATE_EOF(LEXERR):
 				yyterminate();
@@ -2104,7 +2128,7 @@ static int yy_get_next_buffer (yyscan_t yyscanner)
 		while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 			{
 			yy_current_state = (int) yy_def[yy_current_state];
-			if ( yy_current_state >= 355 )
+			if ( yy_current_state >= 367 )
 				yy_c = yy_meta[yy_c];
 			}
 		yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c];
@@ -2128,11 +2152,11 @@ static int yy_get_next_buffer (yyscan_t yyscanner)
 	while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 		{
 		yy_current_state = (int) yy_def[yy_current_state];
-		if ( yy_current_state >= 355 )
+		if ( yy_current_state >= 367 )
 			yy_c = yy_meta[yy_c];
 		}
 	yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c];
-	yy_is_jam = (yy_current_state == 354);
+	yy_is_jam = (yy_current_state == 366);
 	if ( ! yy_is_jam )
 		*yyg->yy_state_ptr++ = yy_current_state;
 
@@ -2941,4 +2965,4 @@ void yyfree (void * ptr , yyscan_t yyscanner)
 
 #define YYTABLES_NAME "yytables"
 
-#line 291 "libxlu_disk_l.l"
+#line 300 "libxlu_disk_l.l"
diff --git a/tools/libs/util/libxlu_disk_l.h b/tools/libs/util/libxlu_disk_l.h
index 6abeecf..509aad6 100644
--- a/tools/libs/util/libxlu_disk_l.h
+++ b/tools/libs/util/libxlu_disk_l.h
@@ -694,7 +694,7 @@ extern int yylex (yyscan_t yyscanner);
 #undef yyTABLES_NAME
 #endif
 
-#line 291 "libxlu_disk_l.l"
+#line 300 "libxlu_disk_l.l"
 
 #line 699 "libxlu_disk_l.h"
 #undef xlu__disk_yyIN_HEADER
diff --git a/tools/libs/util/libxlu_disk_l.l b/tools/libs/util/libxlu_disk_l.l
index 3bd639a..bfd90ae 100644
--- a/tools/libs/util/libxlu_disk_l.l
+++ b/tools/libs/util/libxlu_disk_l.l
@@ -122,9 +122,17 @@ static void setbackendtype(DiskParseContext *dpc, const char *str) {
     if (     !strcmp(str,"phy"))   DSET(dpc,backend,BACKEND,str,PHY);
     else if (!strcmp(str,"tap"))   DSET(dpc,backend,BACKEND,str,TAP);
     else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK);
+    else if (!strcmp(str,"other")) DSET(dpc,backend,BACKEND,str,OTHER);
     else xlu__disk_err(dpc,str,"unknown value for backendtype");
 }
 
+/* Sets ->protocol from the string.  IDL should provide something for this. */
+static void setprotocol(DiskParseContext *dpc, const char *str) {
+    if      (!strcmp(str,"xen"))         DSET(dpc,protocol,PROTOCOL,str,XEN);
+    else if (!strcmp(str,"virtio-mmio")) DSET(dpc,protocol,PROTOCOL,str,VIRTIO_MMIO);
+    else xlu__disk_err(dpc,str,"unknown value for protocol");
+}
+
 /* Sets ->colo-port from the string.  COLO need this. */
 static void setcoloport(DiskParseContext *dpc, const char *str) {
     int port = atoi(str);
@@ -192,6 +200,7 @@ devtype=[^,]*,?	{ xlu__disk_err(DPC,yytext,"unknown value for type"); }
 access=[^,]*,?	{ STRIP(','); setaccess(DPC, FROMEQUALS); }
 backend=[^,]*,? { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); }
 backendtype=[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
+protocol=[^,]*,? { STRIP(','); setprotocol(DPC,FROMEQUALS); }
 
 vdev=[^,]*,?	{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); }
 script=[^,]*,?	{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); }
diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c
index 70eed43..7990035 100644
--- a/tools/xl/xl_block.c
+++ b/tools/xl/xl_block.c
@@ -50,6 +50,11 @@ int main_blockattach(int argc, char **argv)
         return 0;
     }
 
+    if (disk.protocol != LIBXL_DISK_PROTOCOL_XEN) {
+        fprintf(stderr, "block-attach is only supported for protocol xen\n");
+        return 1;
+    }
+
     if (libxl_device_disk_add(ctx, fe_domid, &disk, 0)) {
         fprintf(stderr, "libxl_device_disk_add failed.\n");
         return 1;
@@ -119,6 +124,12 @@ int main_blockdetach(int argc, char **argv)
         fprintf(stderr, "Error: Device %s not connected.\n", argv[optind+1]);
         return 1;
     }
+
+    if (disk.protocol != LIBXL_DISK_PROTOCOL_XEN) {
+        fprintf(stderr, "block-detach is only supported for protocol xen\n");
+        return 1;
+    }
+
     rc = !force ? libxl_device_disk_safe_remove(ctx, domid, &disk, 0) :
         libxl_device_disk_destroy(ctx, domid, &disk, 0);
     if (rc) {
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 18:21:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 18:21:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301744.515002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nctER-0004S4-Rh; Fri, 08 Apr 2022 18:21:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301744.515002; Fri, 08 Apr 2022 18:21:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nctER-0004Rx-Ow; Fri, 08 Apr 2022 18:21:15 +0000
Received: by outflank-mailman (input) for mailman id 301744;
 Fri, 08 Apr 2022 18:21:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cJw0=US=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nctEQ-0004Rr-El
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 18:21:14 +0000
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com
 [2a00:1450:4864:20::435])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab6f3b43-b768-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 20:21:12 +0200 (CEST)
Received: by mail-wr1-x435.google.com with SMTP id i20so1002387wrb.13
 for <xen-devel@lists.xenproject.org>; Fri, 08 Apr 2022 11:21:12 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 y15-20020a05600015cf00b00203e324347bsm24084701wry.102.2022.04.08.11.21.10
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 08 Apr 2022 11:21:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab6f3b43-b768-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=NuxJyRB5x0/heBY3jwDaB5SfCddesye7krGp4eE2q70=;
        b=m8Sh2gdK91QLmW/qg5fDhaYaWE7nJmFbmdgGdyx2kHrhJJR7JvYjZzmSnAp8iGuEVT
         zszSdw5Xc9DuI1PmNFisLwxl1l4AHU0aRBQSc7b875k8KaGrgY+cMKijb9JE3F2ZKpWU
         UuoGe1mlIV6B2E4W7PaQIB35616XskHBmNsnUmjAi5F1yOHXN4TyHZV7e0rxtLRDRpvr
         eXDOoea091l3JD0d2fjMGoswU8JldoLNEKKMTQFKKCzC5+9UyuWlTSbvlwfY2Wh5QLMx
         K3pqdqdp7woIgXJX+OiB9MLSifxPjl5w9uA949XXFVttn1auo+fTmhKiFfD+zqHbzr7T
         TjJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=NuxJyRB5x0/heBY3jwDaB5SfCddesye7krGp4eE2q70=;
        b=QfDMMUBWWjCTHvwn09rKF7A/iYFSbWgkGjLYIZF+xWMm1tqT3pKcGvTqcft0p38kSh
         8BMVlParQN8LvqJQtYwkPDVoZGP041XyM0xkKTe6DxojAoE2lOUyoEaDJH1JhiMvzVW2
         oh+9pGuvIjg1WzF5GQYrgfmU4CYIDND4o1XyTlPEv+iWPkFoX2uJLTp4KZxF5hwCfBoV
         kkP65Ol4vY2y3lVGMkbXC3JNlJdA1q++Ohxddaq8Yc/nJaz6+ZOMp43zzwRurHVY05Ug
         MU7fTy66esSKMHq5lYQJO+HVdJ2tnmaOb7PF7XrMYCQHm+5fCI9KyoD5XnpRx44wmtFk
         fClw==
X-Gm-Message-State: AOAM530K1Ve3AjmMNg9hOb0aPuju3nCvGDNSveQK9Kb2vfBoKW5Px+FA
	GzMczTLOu9MKOF99u0xxN9roQEw0InE=
X-Google-Smtp-Source: ABdhPJx2rctZNlDNgzi60tL2lH3tOr93x2gmGT4TX73qB0jnjaqycO+f217D+W+FIJPlxmfjAH1FYQ==
X-Received: by 2002:adf:f6c4:0:b0:206:1581:dabc with SMTP id y4-20020adff6c4000000b002061581dabcmr15961282wrp.375.1649442071547;
        Fri, 08 Apr 2022 11:21:11 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@gmail.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Chen <Wei.Chen@arm.com>,
	Kaly Xin <Kaly.Xin@arm.com>,
	Jiamei Xie <Jiamei.Xie@arm.com>,
	Henry Wang <Henry.Wang@arm.com>,
	=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
Subject: [PATCH V7 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm")
Date: Fri,  8 Apr 2022 21:21:03 +0300
Message-Id: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

The purpose of this patch series is to add missing virtio-mmio bits to Xen toolstack on Arm.
The Virtio support for toolstack [1] was postponed as the main target was to upstream IOREQ/DM
support on Arm in the first place. Now, we already have IOREQ support in, so we can resume Virtio
enabling work. You can find previous discussions at [2].

Patch series [3] is based on recent "staging" branch
(9120b5737f517fe9d2a3936c38d3a2211630323b livepatch: avoid relocations referencing ignored section symbols)
and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with virtio-mmio based virtio-disk backend [4]
running in Dom0 (or Driver domain) and unmodified Linux Guest running on existing virtio-blk driver (frontend).
No issues were observed. Guest domain 'reboot/destroy' use-cases work properly.

Any feedback/help would be highly appreciated.

[1]
https://lore.kernel.org/xen-devel/1610488352-18494-24-git-send-email-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/1610488352-18494-25-git-send-email-olekstysh@gmail.com/
[2]
https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02403.html
https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02536.html
https://lore.kernel.org/xen-devel/1621626361-29076-1-git-send-email-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/1638982784-14390-1-git-send-email-olekstysh@gmail.com/

[3] https://github.com/otyshchenko1/xen/commits/libxl_virtio2
[4] https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant


Julien Grall (1):
  libxl: Introduce basic virtio-mmio support on Arm

Oleksandr Tyshchenko (1):
  libxl: Add support for Virtio disk configuration

 docs/man/xl-disk-configuration.5.pod.in   |  37 +-
 tools/golang/xenlight/helpers.gen.go      |   6 +
 tools/golang/xenlight/types.gen.go        |  11 +
 tools/include/libxl.h                     |   6 +
 tools/libs/light/libxl_arm.c              | 131 +++-
 tools/libs/light/libxl_device.c           |  57 +-
 tools/libs/light/libxl_disk.c             | 111 +++-
 tools/libs/light/libxl_internal.h         |   1 +
 tools/libs/light/libxl_types.idl          |  10 +
 tools/libs/light/libxl_types_internal.idl |   1 +
 tools/libs/light/libxl_utils.c            |   2 +
 tools/libs/util/libxlu_disk_l.c           | 952 +++++++++++++++---------------
 tools/libs/util/libxlu_disk_l.h           |   2 +-
 tools/libs/util/libxlu_disk_l.l           |   9 +
 tools/xl/xl_block.c                       |  11 +
 xen/include/public/arch-arm.h             |   7 +
 16 files changed, 872 insertions(+), 482 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 08 19:35:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 19:35:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301762.515036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncuO0-0005qI-QE; Fri, 08 Apr 2022 19:35:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301762.515036; Fri, 08 Apr 2022 19:35:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncuO0-0005qB-MQ; Fri, 08 Apr 2022 19:35:12 +0000
Received: by outflank-mailman (input) for mailman id 301762;
 Fri, 08 Apr 2022 19:35:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K+qN=US=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ncuNz-0005q2-CC
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 19:35:11 +0000
Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com
 [2a00:1450:4864:20::12d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ffc1beb8-b772-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 21:35:08 +0200 (CEST)
Received: by mail-lf1-x12d.google.com with SMTP id bq30so3971042lfb.3
 for <xen-devel@lists.xenproject.org>; Fri, 08 Apr 2022 12:35:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffc1beb8-b772-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=e+Zs/fygwfY5AW0hm60Mi1+uIO7asaNlIHJq4/TS9t8=;
        b=iunr/26cun0ZMag9yzLRwb4PSZN+zZIaF1uGgDyiE83Sgr5YPsA+2IiT9kqWhOkU/+
         hkWxQKmCpTCq7rDPjFPczAnlSFqaNenSrKwJpVCLq3Ig9akH+y4C8HQAlftV3pUhdnJk
         6jfZhYTqoaWZvp10ovqqpvP5/Kugs1K2FiwCuU2t2FaZ2FzIFHYKqcRhXAHCQN1CeMpW
         /JEG/rFYReJcG42cx8EyEzcxKeX1npBWDFRtqG6yYs42//otZlJ3Ghnf6jfPQF4O3FOH
         U+aoUlkhR5EhKgJqjZ5W2HINxwFd6+e5CXdmMkqzuWztlBDpFsI2WVgzKSNUy346B1cO
         iYKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=e+Zs/fygwfY5AW0hm60Mi1+uIO7asaNlIHJq4/TS9t8=;
        b=YMJ087xmmIwWAqXT6ZDbh700r4X7KLSH0BSU2cH77wOKpwK5mGx1F4hKtk8A6kYnCo
         GC30fzlctKbuxzcaNRwTHG31El3Z1yo0JuTuiM0uFZeKE8o/94LoKJznXkYrjA7/elve
         aIuYhvR6394LihQgM6izflNH8J54BR8bTaRJayJNZHOtrPYWtZ861+V66nldLk9FU4HL
         uaRaJzIhEx+A2lSmL9ifNBohSj7EDiuHUFRArBf5wQ9J/NpRjbDceO5Ex5g7XDHDgFPf
         rGOHOh8XZpLxYpBFSb+yrI/sPhwFxGgR/BJYQ6UWqymsOskHWDjfoYVglgo0Jj2K5++C
         T95A==
X-Gm-Message-State: AOAM531y06FeF2qeyBaXZSx+pbhdglbSDkHMX12vU7SK00YWx6pOIcK7
	GsPr7RgzgTTZJuH1qtK3ds8A5W9xmAYb14ZD0xU=
X-Google-Smtp-Source: ABdhPJzR0CWmPnQrY0OZPD34pcR+T1eWU47AHJUZphi47OFxdy3jQs8qvUY/uvYT/Z772q07qmBr752sBbmj8qtI/Ic=
X-Received: by 2002:a19:520e:0:b0:464:f639:9d8b with SMTP id
 m14-20020a19520e000000b00464f6399d8bmr5903846lfb.388.1649446508133; Fri, 08
 Apr 2022 12:35:08 -0700 (PDT)
MIME-Version: 1.0
References: <20220330194656.39051-1-jandryuk@gmail.com> <YlBNGCXm+wh2v7Yr@perard.uk.xensource.com>
In-Reply-To: <YlBNGCXm+wh2v7Yr@perard.uk.xensource.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Fri, 8 Apr 2022 15:34:56 -0400
Message-ID: <CAKf6xpvnm5Qh4D3A7j4PiXhds2mymWhsDdrguuxZH3f+T_QEsw@mail.gmail.com>
Subject: Re: [PATCH] libxl: Retry QMP PCI device_add
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, 
	Juergen Gross <jgross@suse.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 8, 2022 at 10:56 AM Anthony PERARD
<anthony.perard@citrix.com> wrote:
>
> On Wed, Mar 30, 2022 at 03:46:56PM -0400, Jason Andryuk wrote:
> > PCI device assignment to an HVM with stubdom is potentially racy.  First
> > the PCI device is assigned to the stubdom via the PV PCI protocol.  Then
> > QEMU is sent a QMP command to attach the PCI device to QEMU running
> > within the stubdom.  However, the sysfs entries within the stubdom may
> > not have appeared by the time QEMU receives the device_add command
> > resulting in errors like:
> >
> > libxl_qmp.c:1838:qmp_ev_parse_error_messages:Domain 10:Could not open '/sys/bus/pci/devices/0000:00:1f.3/config': No such file or directory
> >
> > This patch retries the device assignment up to 10 times with a 1 second
> > delay between.  That roughly matches the overall hotplug timeout.
> >
> > The qmp_ev_parse_error_messages error is still printed since it happens
> > at a lower level than the pci code controlling the retries.  With that,
> > the "Retrying PCI add %d" message is also printed at ERROR level to
> > clarify what is happening.
> >
> > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> > ---
> > @@ -1252,10 +1258,22 @@ static void pci_add_qmp_device_add_cb(libxl__egc *egc,
> >                                        const libxl__json_object *response,
> >                                        int rc)
> >  {
> > -    EGC_GC;
> >      pci_add_state *pas = CONTAINER_OF(qmp, *pas, qmp);
> > +    STATE_AO_GC(pas->aodev->ao);
>
> I think this changes are wrong, what is the reason to use STATE_AO_GC
> instead of EGC_GC?
> I think in this case, it is fine to keep using EGC_GC, as there doesn't
> seems to be any allocation that needs to live after this function
> returns. And you could just pass `pas->aodev->ao` to
> libxl__ev_time_register_rel().

Yes, I think you are correct.  I think I made this change to use a
libxl macro to declare the local ao variable, but as you say that is
not needed.

> >
> > -    if (rc) goto out;
> > +    if (rc) {
> > +        if (pas->retries++ < 10) {
> > +            LOGD(ERROR, qmp->domid, "Retrying PCI add %d", pas->retries);
> > +            rc = libxl__ev_time_register_rel(ao, &pas->timeout_retries,
> > +                                             pci_add_qmp_device_add_retry,
> > +                                             1000);
> > +            if (rc) goto out;
> > +
> > +            return; /* wait for the timeout to then retry */
> > +        } else {
> > +            goto out;
> > +        }
> > +    }
>
> So this retry logic would be done regardless of whether stubdom is in
> use or not. It's not going to be useful in the non-stubdom case, is it?

Yes, it should not be applicable for non-stubdom since the sysfs
entries should already be present.

> When adding a pci device to a domain that has its device model in a
> stubdomain, there's a first call to do_pci_add() which works fine,
> right? Then there's a callback to device_pci_add_stubdom_wait(), which
> is supposed to wait for the stubdom to be ready, but the sysfs entry
> might still be missing at that time, right? Then, there is a second call
> to do_pci_add() for the guest, and it's the one that fail in your case,
> right?

Yes, I think that is all correct.

> If my reasoning is correct, could we enable the retry logic only for the
> second do_pci_add() call? So that guests without stubdom aren't impacted
> as I don't think retrying in this case would be useful and would just
> delay the error.

That should be possible.  Instead of differentiating between the
do_pci_add invocation, I'm thinking pci_add_qmp_device_add_cb would
gain a stubdom check:

if (rc) {
    /* Retry only applicable for HVM with stubdom. */
    if (libxl_get_stubdom_id(CTX, domid) == 0)
        goto out;
    /* retry logic */
}

I just noticed that pci_add_qmp_device_add() registers the
pci_add_timeout, and pci_add_qmp_device_add_retry() calls back into
pci_add_qmp_device_add().  I expected a single 10 second timeout
across all the entire add operation, but the retry logic is
re-registering it.  The duplicate registration may also be corrupting
lists?  I plan to move the pci_add_timeout registration into
do_pci_add()

I went with 10 retries of 1 second each since that matches the
sleep(1) loop patch coming out of OpenXT.  It seems like it could be
optimized, but trying for longer and succeeding seems better than
shorter and failing.

Thanks,
Jason


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 19:44:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 19:44:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301769.515054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncuWl-0007f0-Qx; Fri, 08 Apr 2022 19:44:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301769.515054; Fri, 08 Apr 2022 19:44:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncuWl-0007et-NW; Fri, 08 Apr 2022 19:44:15 +0000
Received: by outflank-mailman (input) for mailman id 301769;
 Fri, 08 Apr 2022 19:44:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncuWl-0007ed-11; Fri, 08 Apr 2022 19:44:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncuWk-0001aD-Uj; Fri, 08 Apr 2022 19:44:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncuWk-0000Wr-IH; Fri, 08 Apr 2022 19:44:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncuWk-0004Cc-FJ; Fri, 08 Apr 2022 19:44:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bz3ItfaWTKKCHC8UYzIyvx1uVYcZiPtpe6dV1jyAAb8=; b=1PmEZBs56aDH0R2Se5PAXuMOAv
	PsJvqTvsyo/mWXUx80wU54eRXQzUzAEcDjaeWy7kHNE8SWiFJAoYlp9tHBvx7FJ5GIwRcA87jKy41
	XxoBBKXOymfYLlZ96O51duuPYPl/RdJ959VbDj2hgEUYN0RrPT1UFeJsm6WQj95C9waY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169233-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169233: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d3f61beea4255e2d86ae82303384c57a3262435e
X-Osstest-Versions-That:
    xen=d4012d50082c2eae2f3cbe7770be13b9227fbc3f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 19:44:14 +0000

flight 169233 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169233/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169221
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169221
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169221
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169221
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169221
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169221
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169221
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169221
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169221
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169221
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169221
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169221
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  d3f61beea4255e2d86ae82303384c57a3262435e
baseline version:
 xen                  d4012d50082c2eae2f3cbe7770be13b9227fbc3f

Last test of basis   169221  2022-04-07 16:13:06 Z    1 days
Testing same since   169233  2022-04-08 10:02:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Ross Lagerwall <ross.lagerwall@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d4012d5008..d3f61beea4  d3f61beea4255e2d86ae82303384c57a3262435e -> master


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 20:19:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 20:19:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301783.515086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncv4C-00040g-Px; Fri, 08 Apr 2022 20:18:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301783.515086; Fri, 08 Apr 2022 20:18:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncv4C-00040Z-MK; Fri, 08 Apr 2022 20:18:48 +0000
Received: by outflank-mailman (input) for mailman id 301783;
 Fri, 08 Apr 2022 20:18:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncv4B-00040T-4F
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 20:18:47 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1689630b-b779-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 22:18:45 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 74ADF61E91;
 Fri,  8 Apr 2022 20:18:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36092C385A1;
 Fri,  8 Apr 2022 20:18:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1689630b-b779-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649449122;
	bh=PClxVwB7HItI2T9bK0m7ueMl12jSFstm3jelbM8EieA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dgNG46z2Fc+l6O6Mdcz/vRd3DUJKZmCxYPqtZB/Ak8Udc8cquOWgAUwZ0/QPCrMa6
	 rnNN9SLYpr9ItqGNFhL2dhZ2gHPmwVLos8koH/Vtai3sNdXrikJDN7PMrsAFJM8E0n
	 qAIl+eQjGJbpCeKZl93jOA84SQswUUzvnKjdx1O6ZJnRui72fuhlgYoa3//PM0HQd4
	 czAZXULX5n8zMZyRVWIQoxHJJRreaGQKXBjhIXSyNReWgbz2ouOLG/7ioxQ07P1qPG
	 jsz/gieEaUBwPypHYa95qxZqP/fpS0Z2FLK5b14ODNkQ4k+KAV/M0Q/h0F+4KQAsdN
	 22qzo3LKTd3Ag==
Date: Fri, 8 Apr 2022 13:18:26 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
In-Reply-To: <20220408084517.33082-5-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204081318130.3066615@ubuntu-linux-20-04-desktop>
References: <20220408084517.33082-1-luca.fancellu@arm.com> <20220408084517.33082-5-luca.fancellu@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Apr 2022, Luca Fancellu wrote:
> Introduce a way to create different cpupools at boot time, this is
> particularly useful on ARM big.LITTLE system where there might be the
> need to have different cpupools for each type of core, but also
> systems using NUMA can have different cpu pools for each node.
> 
> The feature on arm relies on a specification of the cpupools from the
> device tree to build pools and assign cpus to them.
> 
> ACPI is not supported for this feature.
> 
> Documentation is created to explain the feature.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v6:
> - Changed docs, return if booted with ACPI in btcpupools_dtb_parse,
>   panic if /chosen does not exists. Changed commit message (Julien)
> - Add Juergen R-by for the xen/common/sched part that didn't change
> Changes in v5:
> - Fixed wrong variable name, swapped schedulers, add scheduler info
>   in the printk (Stefano)
> - introduce assert in cpupool_init and btcpupools_get_cpupool_id to
>   harden the code
> Changes in v4:
> - modify Makefile to put in *.init.o, fixed stubs and macro (Jan)
> - fixed docs, fix brakets (Stefano)
> - keep cpu0 in Pool-0 (Julien)
> - moved printk from btcpupools_allocate_pools to
>   btcpupools_get_cpupool_id
> - Add to docs constraint about cpu0 and Pool-0
> Changes in v3:
> - Add newline to cpupools.txt and removed "default n" from Kconfig (Jan)
> - Fixed comment, moved defines, used global cpu_online_map, use
>   HAS_DEVICE_TREE instead of ARM and place arch specific code in header
>   (Juergen)
> - Fix brakets, x86 code only panic, get rid of scheduler dt node, don't
>   save pool pointer and look for it from the pool list (Stefano)
> - Changed data structures to allow modification to the code.
> Changes in v2:
> - Move feature to common code (Juergen)
> - Try to decouple dtb parse and cpupool creation to allow
>   more way to specify cpupools (for example command line)
> - Created standalone dt node for the scheduler so it can
>   be used in future work to set scheduler specific
>   parameters
> - Use only auto generated ids for cpupools
> ---
>  docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>  xen/arch/arm/include/asm/smp.h         |   3 +
>  xen/common/Kconfig                     |   7 +
>  xen/common/Makefile                    |   1 +
>  xen/common/boot_cpupools.c             | 207 +++++++++++++++++++++++++
>  xen/common/sched/cpupool.c             |  12 +-
>  xen/include/xen/sched.h                |  14 ++
>  7 files changed, 383 insertions(+), 1 deletion(-)
>  create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>  create mode 100644 xen/common/boot_cpupools.c
> 
> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
> new file mode 100644
> index 000000000000..40cc8135c66f
> --- /dev/null
> +++ b/docs/misc/arm/device-tree/cpupools.txt
> @@ -0,0 +1,140 @@
> +Boot time cpupools
> +==================
> +
> +When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
> +create cpupools during boot phase by specifying them in the device tree.
> +ACPI is not supported for this feature.
> +
> +Cpupools specification nodes shall be direct childs of /chosen node.
> +Each cpupool node contains the following properties:
> +
> +- compatible (mandatory)
> +
> +    Must always include the compatiblity string: "xen,cpupool".
> +
> +- cpupool-cpus (mandatory)
> +
> +    Must be a list of device tree phandle to nodes describing cpus (e.g. having
> +    device_type = "cpu"), it can't be empty.
> +
> +- cpupool-sched (optional)
> +
> +    Must be a string having the name of a Xen scheduler. Check the sched=<...>
> +    boot argument for allowed values [1]. When this property is omitted, the Xen
> +    default scheduler will be used.
> +
> +
> +Constraints
> +===========
> +
> +If no cpupools are specified, all cpus will be assigned to one cpupool
> +implicitly created (Pool-0).
> +
> +If cpupools node are specified, but not every cpu brought up by Xen is assigned,
> +all the not assigned cpu will be assigned to an additional cpupool.
> +
> +If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
> +stop.
> +
> +The boot cpu must be assigned to Pool-0, so the cpupool containing that core
> +will become Pool-0 automatically.
> +
> +
> +Examples
> +========
> +
> +A system having two types of core, the following device tree specification will
> +instruct Xen to have two cpupools:
> +
> +- The cpupool with id 0 will have 4 cpus assigned.
> +- The cpupool with id 1 will have 2 cpus assigned.
> +
> +The following example can work only if hmp-unsafe=1 is passed to Xen boot
> +arguments, otherwise not all cores will be brought up by Xen and the cpupool
> +creation process will stop Xen.
> +
> +
> +a72_1: cpu@0 {
> +        compatible = "arm,cortex-a72";
> +        reg = <0x0 0x0>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a72_2: cpu@1 {
> +        compatible = "arm,cortex-a72";
> +        reg = <0x0 0x1>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_1: cpu@100 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x100>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_2: cpu@101 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x101>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_3: cpu@102 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x102>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_4: cpu@103 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x103>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +chosen {
> +
> +    cpupool_a {
> +        compatible = "xen,cpupool";
> +        cpupool-cpus = <&a53_1 &a53_2 &a53_3 &a53_4>;
> +    };
> +    cpupool_b {
> +        compatible = "xen,cpupool";
> +        cpupool-cpus = <&a72_1 &a72_2>;
> +        cpupool-sched = "credit2";
> +    };
> +
> +    [...]
> +
> +};
> +
> +
> +A system having the cpupools specification below will instruct Xen to have three
> +cpupools:
> +
> +- The cpupool Pool-0 will have 2 cpus assigned.
> +- The cpupool Pool-1 will have 2 cpus assigned.
> +- The cpupool Pool-2 will have 2 cpus assigned (created by Xen with all the not
> +  assigned cpus a53_3 and a53_4).
> +
> +chosen {
> +
> +    cpupool_a {
> +        compatible = "xen,cpupool";
> +        cpupool-cpus = <&a53_1 &a53_2>;
> +    };
> +    cpupool_b {
> +        compatible = "xen,cpupool";
> +        cpupool-cpus = <&a72_1 &a72_2>;
> +        cpupool-sched = "null";
> +    };
> +
> +    [...]
> +
> +};
> +
> +[1] docs/misc/xen-command-line.pandoc
> diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h
> index af5a2fe65266..83c0cd69767b 100644
> --- a/xen/arch/arm/include/asm/smp.h
> +++ b/xen/arch/arm/include/asm/smp.h
> @@ -34,6 +34,9 @@ extern void init_secondary(void);
>  extern void smp_init_cpus(void);
>  extern void smp_clear_cpu_maps (void);
>  extern int smp_get_max_cpus (void);
> +
> +#define cpu_physical_id(cpu) cpu_logical_map(cpu)
> +
>  #endif
>  
>  /*
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index d921c74d615e..70aac5220e75 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -22,6 +22,13 @@ config GRANT_TABLE
>  
>  	  If unsure, say Y.
>  
> +config BOOT_TIME_CPUPOOLS
> +	bool "Create cpupools at boot time"
> +	depends on HAS_DEVICE_TREE
> +	help
> +	  Creates cpupools during boot time and assigns cpus to them. Cpupools
> +	  options can be specified in the device tree.
> +
>  config ALTERNATIVE_CALL
>  	bool
>  
> diff --git a/xen/common/Makefile b/xen/common/Makefile
> index b1e076c30b81..218174ca8b6b 100644
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -1,5 +1,6 @@
>  obj-$(CONFIG_ARGO) += argo.o
>  obj-y += bitmap.o
> +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot_cpupools.init.o
>  obj-$(CONFIG_HYPFS_CONFIG) += config_data.o
>  obj-$(CONFIG_CORE_PARKING) += core_parking.o
>  obj-y += cpu.o
> diff --git a/xen/common/boot_cpupools.c b/xen/common/boot_cpupools.c
> new file mode 100644
> index 000000000000..9429a5025fc4
> --- /dev/null
> +++ b/xen/common/boot_cpupools.c
> @@ -0,0 +1,207 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * xen/common/boot_cpupools.c
> + *
> + * Code to create cpupools at boot time.
> + *
> + * Copyright (C) 2022 Arm Ltd.
> + */
> +
> +#include <xen/sched.h>
> +#include <asm/acpi.h>
> +
> +/*
> + * pool_cpu_map:   Index is logical cpu number, content is cpupool id, (-1) for
> + *                 unassigned.
> + * pool_sched_map: Index is cpupool id, content is scheduler id, (-1) for
> + *                 unassigned.
> + */
> +static int __initdata pool_cpu_map[NR_CPUS]   = { [0 ... NR_CPUS-1] = -1 };
> +static int __initdata pool_sched_map[NR_CPUS] = { [0 ... NR_CPUS-1] = -1 };
> +static unsigned int __initdata next_pool_id;
> +
> +#define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
> +#define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
> +
> +static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
> +{
> +    unsigned int i;
> +
> +    for ( i = 0; i < nr_cpu_ids; i++ )
> +    {
> +        if ( cpu_physical_id(i) == hwid )
> +            return i;
> +    }
> +
> +    return -1;
> +}
> +
> +static int __init
> +get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
> +{
> +    int cpu_num;
> +    const __be32 *prop;
> +    unsigned int cpu_reg;
> +
> +    prop = dt_get_property(cpu_node, "reg", NULL);
> +    if ( !prop )
> +        return BTCPUPOOLS_DT_NODE_NO_REG;
> +
> +    cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node));
> +
> +    cpu_num = get_logical_cpu_from_hw_id(cpu_reg);
> +    if ( cpu_num < 0 )
> +        return BTCPUPOOLS_DT_NODE_NO_LOG_CPU;
> +
> +    return cpu_num;
> +}
> +
> +static int __init check_and_get_sched_id(const char* scheduler_name)
> +{
> +    int sched_id = sched_get_id_by_name(scheduler_name);
> +
> +    if ( sched_id < 0 )
> +        panic("Scheduler %s does not exists!\n", scheduler_name);
> +
> +    return sched_id;
> +}
> +
> +void __init btcpupools_dtb_parse(void)
> +{
> +    const struct dt_device_node *chosen, *node;
> +
> +    if ( !acpi_disabled )
> +        return;
> +
> +    chosen = dt_find_node_by_path("/chosen");
> +    if ( !chosen )
> +        panic("/chosen missing. Boot time cpupools can't be parsed from DT.\n");
> +
> +    dt_for_each_child_node(chosen, node)
> +    {
> +        const struct dt_device_node *phandle_node;
> +        int sched_id = -1;
> +        const char* scheduler_name;
> +        unsigned int i = 0;
> +
> +        if ( !dt_device_is_compatible(node, "xen,cpupool") )
> +            continue;
> +
> +        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) )
> +            sched_id = check_and_get_sched_id(scheduler_name);
> +
> +        phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
> +        if ( !phandle_node )
> +            panic("Missing or empty cpupool-cpus property!\n");
> +
> +        while ( phandle_node )
> +        {
> +            int cpu_num;
> +
> +            cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
> +
> +            if ( cpu_num < 0 )
> +                panic("Error retrieving logical cpu from node %s (%d)\n",
> +                      dt_node_name(node), cpu_num);
> +
> +            if ( pool_cpu_map[cpu_num] != -1 )
> +                panic("Logical cpu %d already added to a cpupool!\n", cpu_num);
> +
> +            pool_cpu_map[cpu_num] = next_pool_id;
> +
> +            phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
> +        }
> +
> +        /* Save scheduler choice for this cpupool id */
> +        pool_sched_map[next_pool_id] = sched_id;
> +
> +        /* Let Xen generate pool ids */
> +        next_pool_id++;
> +    }
> +}
> +
> +void __init btcpupools_allocate_pools(void)
> +{
> +    unsigned int i;
> +    bool add_extra_cpupool = false;
> +    int swap_id = -1;
> +
> +    /*
> +     * If there are no cpupools, the value of next_pool_id is zero, so the code
> +     * below will assign every cpu to cpupool0 as the default behavior.
> +     * When there are cpupools, the code below is assigning all the not
> +     * assigned cpu to a new pool (next_pool_id value is the last id + 1).
> +     * In the same loop we check if there is any assigned cpu that is not
> +     * online.
> +     */
> +    for ( i = 0; i < nr_cpu_ids; i++ )
> +    {
> +        if ( cpumask_test_cpu(i, &cpu_online_map) )
> +        {
> +            /* Unassigned cpu gets next_pool_id pool id value */
> +            if ( pool_cpu_map[i] < 0 )
> +            {
> +                pool_cpu_map[i] = next_pool_id;
> +                add_extra_cpupool = true;
> +            }
> +
> +            /*
> +             * Cpu0 must be in cpupool0, otherwise some operations like moving
> +             * cpus between cpupools, cpu hotplug, destroying cpupools, shutdown
> +             * of the host, might not work in a sane way.
> +             */
> +            if ( !i && (pool_cpu_map[0] != 0) )
> +                swap_id = pool_cpu_map[0];
> +
> +            if ( swap_id != -1 )
> +            {
> +                if ( pool_cpu_map[i] == swap_id )
> +                    pool_cpu_map[i] = 0;
> +                else if ( pool_cpu_map[i] == 0 )
> +                    pool_cpu_map[i] = swap_id;
> +            }
> +        }
> +        else
> +        {
> +            if ( pool_cpu_map[i] >= 0 )
> +                panic("Pool-%d contains cpu%u that is not online!\n",
> +                      pool_cpu_map[i], i);
> +        }
> +    }
> +
> +    /* A swap happened, swap schedulers between cpupool id 0 and the other */
> +    if ( swap_id != -1 )
> +    {
> +        int swap_sched = pool_sched_map[swap_id];
> +
> +        pool_sched_map[swap_id] = pool_sched_map[0];
> +        pool_sched_map[0] = swap_sched;
> +    }
> +
> +    if ( add_extra_cpupool )
> +        next_pool_id++;
> +
> +    /* Create cpupools with selected schedulers */
> +    for ( i = 0; i < next_pool_id; i++ )
> +        cpupool_create_pool(i, pool_sched_map[i]);
> +}
> +
> +unsigned int __init btcpupools_get_cpupool_id(unsigned int cpu)
> +{
> +    ASSERT((cpu < NR_CPUS) && (pool_cpu_map[cpu] >= 0));
> +
> +    printk(XENLOG_INFO "Logical CPU %u in Pool-%d (Scheduler id: %d).\n",
> +           cpu, pool_cpu_map[cpu], pool_sched_map[pool_cpu_map[cpu]]);
> +
> +    return pool_cpu_map[cpu];
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
> index 89a891af7076..86a175f99cd5 100644
> --- a/xen/common/sched/cpupool.c
> +++ b/xen/common/sched/cpupool.c
> @@ -1247,12 +1247,22 @@ static int __init cf_check cpupool_init(void)
>      cpupool_put(cpupool0);
>      register_cpu_notifier(&cpu_nfb);
>  
> +    btcpupools_dtb_parse();
> +
> +    btcpupools_allocate_pools();
> +
>      spin_lock(&cpupool_lock);
>  
>      cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
>  
>      for_each_cpu ( cpu, &cpupool_free_cpus )
> -        cpupool_assign_cpu_locked(cpupool0, cpu);
> +    {
> +        unsigned int pool_id = btcpupools_get_cpupool_id(cpu);
> +        struct cpupool *pool = cpupool_find_by_id(pool_id);
> +
> +        ASSERT(pool);
> +        cpupool_assign_cpu_locked(pool, cpu);
> +    }
>  
>      spin_unlock(&cpupool_lock);
>  
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index b527f141a1d3..453e98f1cba8 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -1178,6 +1178,20 @@ extern void cf_check dump_runq(unsigned char key);
>  
>  void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
>  
> +#ifdef CONFIG_BOOT_TIME_CPUPOOLS
> +void btcpupools_allocate_pools(void);
> +unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
> +void btcpupools_dtb_parse(void);
> +
> +#else /* !CONFIG_BOOT_TIME_CPUPOOLS */
> +static inline void btcpupools_allocate_pools(void) {}
> +static inline void btcpupools_dtb_parse(void) {}
> +static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
> +{
> +    return 0;
> +}
> +#endif
> +
>  #endif /* __SCHED_H__ */
>  
>  /*
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 20:25:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 20:25:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301789.515097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncvAS-0005Sr-KZ; Fri, 08 Apr 2022 20:25:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301789.515097; Fri, 08 Apr 2022 20:25:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncvAS-0005Sk-HP; Fri, 08 Apr 2022 20:25:16 +0000
Received: by outflank-mailman (input) for mailman id 301789;
 Fri, 08 Apr 2022 20:25:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncvAQ-0005Se-Sg
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 20:25:14 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fe66a0f2-b779-11ec-8fbc-03012f2f19d4;
 Fri, 08 Apr 2022 22:25:13 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8289861BFA;
 Fri,  8 Apr 2022 20:25:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DBC5C385A1;
 Fri,  8 Apr 2022 20:25:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe66a0f2-b779-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649449511;
	bh=UbNIF/ZuQqYIGCv0Q+ldkWlSsYlSMzNAGS6N7fOX2Iw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=VOJ89EMv6LlA21dGFsjy18ZC+t22oVs9C+kYlpf2vpVqCOO09qiP0a4hfZ6d8DcPl
	 qQVw1KoDmnNOtKLH5tX7E9DRu1UZsIzICz0cb8Z4Oiv8W9SeUuvhGo55gGEwFZJT/Q
	 lEBce/6qfo3oR5X+KYcC3pQ/hI77f5WYn5qHeJYMLaop3SEpYG64PepxADNrkqSAQA
	 q0IC2ti/FMxB4fjfuDNbyj5yU5miywmQ9IpqyA9u+gL8QbPuIMGRKfmhF+7+RPgJKN
	 zLgC6xxo98NoDOaO1PNxnk1GYPe4I1f9ZssaHKM4ueLCfh3fbsENUxr8QoR7NezLWY
	 nby8VS98AyTYA==
Date: Fri, 8 Apr 2022 13:25:10 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Jan Beulich <jbeulich@suse.com>
cc: Luca Fancellu <Luca.Fancellu@arm.com>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, 
    Juergen Gross <jgross@suse.com>, Dario Faggioli <dfaggioli@suse.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
In-Reply-To: <511b60be-c6c6-d13a-b9aa-40e67e5a1b1c@suse.com>
Message-ID: <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>
References: <20220408084517.33082-1-luca.fancellu@arm.com> <20220408084517.33082-5-luca.fancellu@arm.com> <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com> <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com> <511b60be-c6c6-d13a-b9aa-40e67e5a1b1c@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Apr 2022, Jan Beulich wrote:
> On 08.04.2022 13:37, Luca Fancellu wrote:
> > 
> > 
> >> On 8 Apr 2022, at 10:01, Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> On 08.04.2022 10:45, Luca Fancellu wrote:
> >>> ---
> >>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
> >>> xen/arch/arm/include/asm/smp.h         |   3 +
> >>> xen/common/Kconfig                     |   7 +
> >>> xen/common/Makefile                    |   1 +
> >>> xen/common/boot_cpupools.c             | 207 +++++++++++++++++++++++++
> >>> xen/common/sched/cpupool.c             |  12 +-
> >>> xen/include/xen/sched.h                |  14 ++
> >>> 7 files changed, 383 insertions(+), 1 deletion(-)
> >>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
> >>> create mode 100644 xen/common/boot_cpupools.c
> >>
> >> Under whose maintainership is the new file to fall? Without an
> >> addition to ./MAINTAINERS and without the file being placed in
> >> xen/common/sched/, it'll be REST maintainers, which I think would
> >> better be avoided. Would it perhaps make sense to have this as
> >> xen/common/sched/boot.c, allowing other boot-only code to
> >> potentially be moved there over time? This would then also avoid
> >> me asking about the underscore in the file name: Underscores are
> >> a somewhat artificial thing for use in places where dashes can't
> >> be used. Yet in the file system dashes are fine, and dashes are
> >> (slightly) easier to type.
> >>
> > 
> > Ok I can put the new file under xen/common/sched/ as boot.c, should this new
> > file be under this section?
> > 
> > CPU POOLS
> > M:  Juergen Gross <jgross@suse.com>
> > M:  Dario Faggioli <dfaggioli@suse.com>
> > S:  Supported
> > F:  xen/common/sched/cpupool.c
> > + F:  xen/common/sched/boot.c
> 
> If it's to hold general scheduler code (which this shorter name would
> suggest), it shouldn't need any change to ./MAINTAINERS as the
> scheduler section would already cover it then. If it was to remain
> CPU-pools-specific, then you'd need to stick to the longer name and
> put it in the section you have reproduced above.

In my opinion it is best if the maintenance of boot_cpupools.c falls
under "CPU POOLS". Luca, you can retain my reviewed-by when you add
the change to MAINTAINERS or rename the file.

I don't have an opinion if it should be called
xen/common/boot_cpupools.c or xen/common/boot-cpupools.c


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 22:19:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 22:19:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301796.515108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncwwX-000224-Kc; Fri, 08 Apr 2022 22:19:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301796.515108; Fri, 08 Apr 2022 22:19:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncwwX-00021x-He; Fri, 08 Apr 2022 22:19:01 +0000
Received: by outflank-mailman (input) for mailman id 301796;
 Fri, 08 Apr 2022 22:18:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncwwV-00021p-Mm
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 22:18:59 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e171128d-b789-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 00:18:57 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D017B60DED;
 Fri,  8 Apr 2022 22:18:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D559BC385A3;
 Fri,  8 Apr 2022 22:18:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e171128d-b789-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649456335;
	bh=P72IJTfyX5wTvkkZ91YmO4OIrFD4AplLOs/qTBkcNW0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=UU+N2DunvjyfDzXP1EQbtkjJj1H8ppNt2riqkNqybXU/MjVrkE7lXu+ayoFffQ2UP
	 nESomDbsTfB/q2DS0xwetv5F9OXLOqt1gLqgxfZbAXhJSUxpVTK+Ir3olDW/EIdtXi
	 uOiMLOi1RfgAbp4MFy964KQQn5ta6YPaEJFZTtuIcwWWiSObNUiBDs1YVqWEz68Jyt
	 IGZwW5uotLIJ0pGhhtxX15e2h9Nm6Oy+JGcpreUw7+fpJ6lUV2EDU0jsAbYrInjTPw
	 gaULCbsC6PVuazqTaqOX7lRZQOWeMJixUfo+MK7K5XN/F5UDh9QqYy+XsteDbBT8aS
	 bnTNIoJbz1u6A==
Date: Fri, 8 Apr 2022 15:18:54 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Penny Zheng <Penny.Zheng@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    nd <nd@arm.com>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
In-Reply-To: <DU2PR08MB732540A4196E8634B4D8A579F71E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2204081516400.3066615@ubuntu-linux-20-04-desktop>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com> <20220311061123.1883189-7-Penny.Zheng@arm.com> <alpine.DEB.2.22.394.2203171744190.3497@ubuntu-linux-20-04-desktop> <DU2PR08MB732540A4196E8634B4D8A579F71E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 29 Mar 2022, Penny Zheng wrote:
> Hi Stefano
> 
> Sorry for the late response, got sidetracked an emergency issue. ;/
> 
> > -----Original Message-----
> > From: Stefano Stabellini <sstabelliHini@kernel.org>
> > Sent: Friday, March 18, 2022 10:00 AM
> > To: Penny Zheng <Penny.Zheng@arm.com>
> > Cc: xen-devel@lists.xenproject.org; nd <nd@arm.com>; Stefano Stabellini
> > <sstabellini@kernel.org>; Julien Grall <julien@xen.org>; Bertrand Marquis
> > <Bertrand.Marquis@arm.com>; Volodymyr Babchuk
> > <Volodymyr_Babchuk@epam.com>
> > Subject: Re: [PATCH v1 06/13] xen/arm: set up shared memory foreign
> > mapping for borrower domain
> > 
> > On Fri, 11 Mar 2022, Penny Zheng wrote:
> > > From: Penny Zheng <penny.zheng@arm.com>
> > >
> > > This commits introduces a new helper guest_physmap_add_shm to set up
> > > shared memory foreign mapping for borrower domain.
> > >
> > > Firstly it should get and take reference of statically shared pages
> > > from owner dom_shared. Then it will setup P2M foreign memory map of
> > > these statically shared pages for borrower domain.
> > >
> > > This commits only considers owner domain is the default dom_shared,
> > > the other scenario will be covered in the following patches.
> > >
> > > Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> > > ---
> > >  xen/arch/arm/domain_build.c | 52
> > > +++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 52 insertions(+)
> > >
> > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > > index 984e70e5fc..8cee5ffbd1 100644
> > > --- a/xen/arch/arm/domain_build.c
> > > +++ b/xen/arch/arm/domain_build.c
> > > @@ -798,6 +798,48 @@ static int __init allocate_shared_memory(struct
> > domain *d,
> > >      return ret;
> > >  }
> > >
> > > +static int __init guest_physmap_add_shm(struct domain *od, struct domain
> > *bd,
> > > +                                        unsigned long o_gfn,
> > > +                                        unsigned long b_gfn,
> > > +                                        unsigned long nr_gfns)
> > 
> > They should probably be gfn_t type
> > 
> >
>  
> Sure, will do.
> 
> > > +{
> > > +    struct page_info **pages = NULL;
> > > +    p2m_type_t p2mt, t;
> > > +    int ret = 0;
> > > +
> > > +    pages = xmalloc_array(struct page_info *, nr_gfns);
> > > +    if ( !pages )
> > > +        return -ENOMEM;
> > > +
> > > +    /*
> > > +     * Take reference of statically shared pages from owner domain.
> > > +     * Reference will be released when destroying shared memory region.
> > > +     */
> > > +    ret = get_pages_from_gfn(od, o_gfn, nr_gfns, pages, &p2mt, P2M_ALLOC);
> > > +    if ( ret )
> > > +    {
> > > +        ret = -EINVAL;
> > > +        goto fail_pages;
> > > +    }
> > > +
> > > +    if ( p2m_is_ram(p2mt) )
> > > +        t = (p2mt == p2m_ram_rw) ? p2m_map_foreign_rw :
> > p2m_map_foreign_ro;
> > > +    else
> > > +    {
> > > +        ret = -EINVAL;
> > > +        goto fail_pages;
> > > +    }
> > 
> > One idea is to initialize p2mt = p2m_ram_rw and pass it to
> > get_pages_from_gfn. Then get_pages_from_gfn can return error immediately
> > if any of the pages are of different type.
> > 
> > This way there is no need for checking again here.
> >
> 
> Right now, the memory attribute of static shared memory is RW as default,
> What if we add memory attribute setting in device tree configuration, sometimes,
> Users want to specify that borrower domain only has RO right, hmm, then the
> Initialization for p2mt could be either p2m_ram_rw or p2m_ram_ro?
> In such case, we could add another parameter in guest_physmap_add_shm to
> show the p2m type...
> Hope I understand what you suggested here.

Yes, I think I understand. I think your suggestion is OK too. However,
your suggestion is much more work than mine: I was only suggesting a
small improvement limited to guest_physmap_add_shm and
get_pages_from_gfn. Your suggestion involves a device tree change that
would have a larger impact on the patch series. So if you are up for it,
I am happy to review it. I am also fine just to have a small improvement
on guest_physmap_add_shm/get_pages_from_gfn.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 22:47:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 22:47:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301801.515119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxNS-0005iW-R6; Fri, 08 Apr 2022 22:46:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301801.515119; Fri, 08 Apr 2022 22:46:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxNS-0005iP-Nq; Fri, 08 Apr 2022 22:46:50 +0000
Received: by outflank-mailman (input) for mailman id 301801;
 Fri, 08 Apr 2022 22:46:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncxNQ-0005iJ-I3
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 22:46:48 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c479111c-b78d-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 00:46:47 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 08BD6B82BFA;
 Fri,  8 Apr 2022 22:46:45 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 703E2C385A3;
 Fri,  8 Apr 2022 22:46:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c479111c-b78d-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649458003;
	bh=4aHfOaNyNQRjnkOEi1kEdQeYOXfCqpP1x4neRiU/2DQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dy4d4igpXnmjxw8H9RC6gzR5jk37ZgBhne0PbOiJi92AQQlh2tCzNZq7qJ6pt3hu0
	 3MlJE9sJAJbnTio2z734mgPuv2M2wBkTpgvpvP/wv7Uri1I8VQhP92YIpmxWbNzl/n
	 dWVs3yAo/InsgjDhUrn3fTlp89rszS4goxOoF4kAJrl4Bn7AcBemEbr/ejicUXVfxP
	 xvNiC4G1ouwiojvduzXZAD9ICMsRNtnKNR1KjXbZ9slUt0er5mG1ITgCO3pKFfOwUC
	 8EnV4XLtjM7hhjxDz7m7cXjB5vWDa1TmZFp6SZJQ2ACEjuT7RXSdWcbIQfim+bm72c
	 1cwAzUyitDnCw==
Date: Fri, 8 Apr 2022 15:46:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Penny Zheng <Penny.Zheng@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    nd <nd@arm.com>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v1 11/13] xen/arm: store shm-info for deferred foreign
 memory map
In-Reply-To: <DU2PR08MB732592AD40BAA48F390445AAF71E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2204081523110.3066615@ubuntu-linux-20-04-desktop>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com> <20220311061123.1883189-12-Penny.Zheng@arm.com> <alpine.DEB.2.22.394.2203171831410.3497@ubuntu-linux-20-04-desktop> <DU2PR08MB732592AD40BAA48F390445AAF71E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 29 Mar 2022, Penny Zheng wrote:
> > On Fri, 11 Mar 2022, Penny Zheng wrote:
> > > From: Penny Zheng <penny.zheng@arm.com>
> > >
> > > In a few scenarios where owner domain, is defined after borrower
> > > domain in device tree configuration, then statically shared pages
> > > haven't been properly allocated if borrower domain tries to do foreign
> > > memory map during domain construction.
> > >
> > > In order to cover such scenario, we defer all borrower domains'
> > > foreign memory map after all domain construction finished, then only
> > > need to store shm-info during domain construction.
> > >
> > > Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> > > ---
> > >  xen/arch/arm/domain.c             |  3 +++
> > >  xen/arch/arm/domain_build.c       | 34 ++++++++++++++++++++++++++++++-
> > >  xen/arch/arm/include/asm/domain.h | 25 +++++++++++++++++++++++
> > >  3 files changed, 61 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index
> > > f0bfd67fe5..73ffbfb918 100644
> > > --- a/xen/arch/arm/domain.c
> > > +++ b/xen/arch/arm/domain.c
> > > @@ -47,6 +47,9 @@ DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> > >
> > >  #ifdef CONFIG_STATIC_SHM
> > >  struct domain *__read_mostly dom_shared;
> > > +
> > > +shm_info_t shm_list[NR_MEM_BANKS];
> > 
> > Instead of adding shm_list, maybe we can we re-use mem->bank
> > (bootinfo.reserved_mem)?
> > 
> > It is already storing the physical address and size (added in patch #1 with
> > process_shm_node). We should be able to find the other info from the mfn:
> > mfn_to_page, page_get_owner, mfn_to_gfn. At most, we need to mark the
> > memory bank as shared and we could do that with another field in struct
> > membank.
> > 
> > 
> > > +DECLARE_BITMAP(shm_list_mask, NR_MEM_BANKS);
> > 
> > This is the third bitmask we introduce :-)
> > 
> > Can we narrow it down to a single bitmask? Maybe we don't need it at all if we
> > switch to using bootinfo.mem.bank.
> > 
> > 
> > >  #endif
> > >
> > >  static void do_idle(void)
> > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > > index 7ee4d33e0b..4b19160674 100644
> > > --- a/xen/arch/arm/domain_build.c
> > > +++ b/xen/arch/arm/domain_build.c
> > > @@ -771,7 +771,7 @@ static mfn_t __init
> > > acquire_shared_memory_bank(struct domain *d,
> > >
> > >  }
> > >
> > > -static int __init allocate_shared_memory(struct domain *d,
> > > +static int __init allocate_shared_memory(struct domain *d, u32
> > > +shm_id,
> > 
> > No need for it to be u32?
> > 
> > 
> > >                                           u32 addr_cells, u32 size_cells,
> > >                                           paddr_t pbase, paddr_t psize,
> > >                                           paddr_t gbase) @@ -795,6
> > > +795,18 @@ static int __init allocate_shared_memory(struct domain *d,
> > >          return ret;
> > >      }
> > >
> > > +    /*
> > > +     * If owner domain is not default dom_shared, shm-info of owner domain
> > > +     * shall also be recorded for later deferred foreign memory map.
> > > +     */
> > > +    if ( d != dom_shared )
> > > +    {
> > > +        shm_list[shm_id].owner_dom = d->domain_id;
> > > +        shm_list[shm_id].owner_gbase = gbase;
> > > +        shm_list[shm_id].size = psize;
> > > +        set_bit(shm_id, shm_list_mask);
> > > +    }
> > >      return ret;
> > >  }
> > >
> > > @@ -962,6 +974,26 @@ static int __init process_shm(struct domain *d,
> > >              if ( ret )
> > >                  return ret;
> > >          }
> > > +        else
> > > +        {
> > > +            if ( strcmp(role_str, "borrower") == 0 )
> > > +            {
> > > +                /*
> > > +                 * In a few scenarios where owner domain, is defined after
> > > +                 * borrower domain in device tree configuration, statically
> > > +                 * shared pages haven't been properly allocated if borrower
> > > +                 * domain here tries to do foreign memory map.
> > > +                 * In order to cover such scenario, we defer all borrower
> > > +                 * domains'foreign memory map after all domain construction
> > > +                 * finished, and only store shm-info here for later use.
> > > +                 */
> > > +                shm_list[shm_id].borrower_dom[shm_list[shm_id].nr_borrower] =
> > > +                                                                d->domain_id;
> > > +                shm_list[shm_id].borrower_gbase[shm_list[shm_id].nr_borrower] =
> > > +                                                                gbase;
> > > +                shm_list[shm_id].nr_borrower++;
> > > +            }
> > > +        }
> > 
> > Maybe we don't need to defer this at all. guest_physmap_add_shm does only
> > two things:
> > 
> > 1) get a page ref using the owner domain
> > 2) add page to borrower p2m
> > 
> > 
> > We can do 2) straight away even if the owner is not yet allocated.
> > 
> > For 1), we need to get the right amount of references when the owner is
> > allocated (which could be after the borrowers).
> > 
> > Keeping in mind that we have already parsed all the info in
> > xen/arch/arm/bootfdt.c:process_shm_node, I wonder if we can add a field to
> > mem->bank[mem->nr_banks] to keep a count of the number of borrowers.
> > 
> > Then when we allocate the page to the owner here, we just get as many
> > additional reference as the number of borrowers.
> > 
> > This would:
> > - add a field to bootinfo.reserved_mem
> > - remove the need for shm_list
> > - remove the need for shm_list_mask
> > - remove the need for the deferral
> > 
> > Just trying to make things simpler :-)
> > 
> 
> Thanks for the detailed comments.
> Here is what I thought and understood, PLZ correct me if I'm wrong. ;)
> '''
> > For 1), we need to get the right amount of references when the owner is
> > allocated (which could be after the borrowers).
> '''
> We could add another field `nr_shm_borrowers` in struct membank to
> keep a count of the number of borrowers, which is also the number of
> the reference count. 

Yes


> And like you said, it shall be done in xen/arch/arm/bootfdt.c:process_shm_node.
> The only shortcoming here is that we need to iterate the parsed shm
> mem banks each time to do the increment, since we used shm_mask
> at first to treat space with time, but it really could decrease the
> complexity here and remove all the defer codes.

Yes, that's true, but the number of elements in the array should be very
small. We can always optimized data structures later if needed. Also, we
would save one loop in shm_init_late.


> But here is another concern about the shm_list. Another reason why I
> created shm_list is that when destroyed domain is an owner domain, 
> we need to unmap shared memory for all borrower domains too. IMO,
> so that it fits the definition of owner and borrower. It is also
> what commit "xen/arm: unmap foreign memory mapping when
> destroyed domain is owner domain" is trying to solve.

Actually, I am not sure about this. I don't think that we need to unmap
the memory at the borrowers. We just decrease the ref count on the
pages. When the borrower domains die, the ref count goes to zero and the
pages are finally freed.

So I don't think that when the owner dies, we need to actively go and
unmap the pages at the borrowers. Also because it would likely cause
them to crash: from their point of view the memory was there, and
suddenly it is not there anymore.

But we don't need to do anything special to decrease the ref count on
the shared pages because it would happen automatically when the owner
domain is destroyed.


> we need a way to find all borrower domains info, when you
> only know the owner domain.
> Based on your suggestion, I suggest to add new field
> ` domid_t *shm_borrower_dom` and `paddr_t *shm_borrower_gbase`
> in struct membank. And both two fields are going to be allocated and set
> during domain construction phase xen/arch/arm/domain_build.c:process_shm.
> 
> Another thing is that maybe we could not store all above shared mem
> banks in bootinfo.reserved_mem, since it is only valid during boot time,
> and we need that info also for domain deconstruction at runtime.
> Another struct meminfo shm_list may still also be needed.
> 
> BTW, I suggest that the index of shm_list.bank is shm_id
> In case user abuse it in device tree configuration, we let xen to allocate.
> In xen/arch/arm/bootfdt.c:process_shm_node, each time parsing a new
> shm node, iterate the whole shm_list and only if the physical
> address and size of all entries are not matched, we allocate a new bank for the
> shm node.  
>  
> > 
> > >          /*
> > >           * Record static shared memory region info for later setting
> > > diff --git a/xen/arch/arm/include/asm/domain.h
> > > b/xen/arch/arm/include/asm/domain.h
> > > index 6df37d2c46..1c0f2e22ca 100644
> > > --- a/xen/arch/arm/include/asm/domain.h
> > > +++ b/xen/arch/arm/include/asm/domain.h
> > > @@ -10,6 +10,7 @@
> > >  #include <asm/gic.h>
> > >  #include <asm/vgic.h>
> > >  #include <asm/vpl011.h>
> > > +#include <asm/setup.h>
> > >  #include <public/hvm/params.h>
> > >
> > >  struct hvm_domain
> > > @@ -33,6 +34,30 @@ enum domain_type {
> > >
> > >  #ifdef CONFIG_STATIC_SHM
> > >  extern struct domain *dom_shared;
> > > +
> > > +/* Maximum number of borrower domains. */ #define NR_SHM_DOMAIN
> > 32
> > > +/*
> > > + * shm_list is indexed by unique identifier "xen,shm-id", but it only
> > > +stores
> > > + * a subset of static shared memory regions, of which owner domain is
> > > +not the
> > > + * default dom_shared.
> > > + * shm_list_mask bitmask is to record the position of these static
> > > +shared
> > > + * memory regions.
> > > + * Per bit represents a entry in shm_list, and setting it 1 means the
> > > + * static shared memory region here is owned by a specific domain,
> > > +then bit 0
> > > + * means the static shared memory region here is either owned by the
> > > +default
> > > + * dom_shared or no static shared memory region here at all.
> > > + */
> > > +typedef struct {
> > > +    domid_t owner_dom;
> > > +    paddr_t owner_gbase;
> > > +    paddr_t size;
> > > +    domid_t borrower_dom[NR_SHM_DOMAIN];
> > > +    paddr_t borrower_gbase[NR_SHM_DOMAIN];
> > > +    unsigned long nr_borrower;
> > > +} shm_info_t;
> > > +extern shm_info_t shm_list[NR_MEM_BANKS]; extern unsigned long
> > > +shm_list_mask[BITS_TO_LONGS(NR_MEM_BANKS)];
> > >  #else
> > >  #define dom_shared NULL
> > >  #endif
> > > --
> > > 2.25.1
> > >
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 22:50:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 22:50:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301806.515130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxRH-0007N4-DF; Fri, 08 Apr 2022 22:50:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301806.515130; Fri, 08 Apr 2022 22:50:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxRH-0007Mx-8N; Fri, 08 Apr 2022 22:50:47 +0000
Received: by outflank-mailman (input) for mailman id 301806;
 Fri, 08 Apr 2022 22:50:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncxRG-0007Mr-3O
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 22:50:46 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncxRF-0004m3-Qt; Fri, 08 Apr 2022 22:50:45 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncxRF-0005WE-LB; Fri, 08 Apr 2022 22:50:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=ju5Wtq+n2J4zrnhb+bLOe79KxVjb/Aq57b4UdXK/ujY=; b=iEBsgV5HGzFRc6G/GA8um3414+
	AqDMY+vK4g6v/FbKDU9L25vv7hYjN2VO6G/LZdQaZWvOvM4wWPaEaQRlDPzglPRPbvxtbUE/lp7Jv
	AH4Cmhz1Zj9xAuUkXVIWmDIoP5BWBBiD0B0Jy4HaKHgbsZUgdEsd7S5N1DYUgnOEU/2Q=;
Message-ID: <a9628233-5c2e-abb2-1df8-f45e4ac3280b@xen.org>
Date: Fri, 8 Apr 2022 23:50:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Stefano Stabellini <sstabellini@kernel.org>,
 Penny Zheng <Penny.Zheng@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 nd <nd@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-7-Penny.Zheng@arm.com>
 <alpine.DEB.2.22.394.2203171744190.3497@ubuntu-linux-20-04-desktop>
 <DU2PR08MB732540A4196E8634B4D8A579F71E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204081516400.3066615@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
In-Reply-To: <alpine.DEB.2.22.394.2204081516400.3066615@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 08/04/2022 23:18, Stefano Stabellini wrote:
> On Tue, 29 Mar 2022, Penny Zheng wrote:
>> Right now, the memory attribute of static shared memory is RW as default,
>> What if we add memory attribute setting in device tree configuration, sometimes,
>> Users want to specify that borrower domain only has RO right, hmm, then the
>> Initialization for p2mt could be either p2m_ram_rw or p2m_ram_ro?
>> In such case, we could add another parameter in guest_physmap_add_shm to
>> show the p2m type...
>> Hope I understand what you suggested here.
> 
> Yes, I think I understand. I think your suggestion is OK too. However,
> your suggestion is much more work than mine: I was only suggesting a
> small improvement limited to guest_physmap_add_shm and
> get_pages_from_gfn. Your suggestion involves a device tree change that
> would have a larger impact on the patch series. So if you are up for it,
> I am happy to review it. I am also fine just to have a small improvement
> on guest_physmap_add_shm/get_pages_from_gfn.

AFAIU, your proposal would mean that the behavior for 
get_pages_from_gfn() and get_page_from_gfn() will differ. This is not great.

I don't think we can easily change the behavior of get_page_from_gfn() 
because some callers can accept multiple types.

Furthermore, while today we only check p2m_ram_rw. It might be possible 
that we would want to check different type. For instance, if we want to 
use read-only mapping, it would be fine to accept p2m_ram_ro and p2m_ram_rw.

So overall, I am not in favor of initializing p2mt and let 
get_pages_from_gfn() to check the type.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 22:59:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 22:59:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301812.515140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxZd-0008MW-BL; Fri, 08 Apr 2022 22:59:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301812.515140; Fri, 08 Apr 2022 22:59:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxZd-0008MO-8F; Fri, 08 Apr 2022 22:59:25 +0000
Received: by outflank-mailman (input) for mailman id 301812;
 Fri, 08 Apr 2022 22:59:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ncxZb-0008MI-Ec
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 22:59:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncxZb-0004u2-5x; Fri, 08 Apr 2022 22:59:23 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ncxZb-00061e-0Q; Fri, 08 Apr 2022 22:59:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xRr6jVnmuDsCYZ0Gs6S3qyyO78LvdrHUQtzNTl+iX6c=; b=6z7KM6DLxOrlJxAFTPZIMKv2mg
	I1/XN6YLwsKbq6X+/ThaGC9wqBlfjUmw6jBwfXUeWE6mAqlN0eh3FCtPraKCAGS0yX5TJYl2Ff1Ew
	P0VZ7/oBWNHu8tyla49oLxSGIwwSBXY7SFaGVBrCsWGBfAdJOIbAzemH4NabrutKK/u8=;
Message-ID: <c4a3fb77-1cab-aacf-a2a5-3702f9c4ab97@xen.org>
Date: Fri, 8 Apr 2022 23:59:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: nd@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-7-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220311061123.1883189-7-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 11/03/2022 06:11, Penny Zheng wrote:
> From: Penny Zheng <penny.zheng@arm.com>
> 
> This commits introduces a new helper guest_physmap_add_shm to set up shared
> memory foreign mapping for borrower domain.
> 
> Firstly it should get and take reference of statically shared pages from
> owner dom_shared. Then it will setup P2M foreign memory map of these statically
> shared pages for borrower domain.
> 
> This commits only considers owner domain is the default dom_shared, the
> other scenario will be covered in the following patches.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   xen/arch/arm/domain_build.c | 52 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 52 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 984e70e5fc..8cee5ffbd1 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -798,6 +798,48 @@ static int __init allocate_shared_memory(struct domain *d,
>       return ret;
>   }
>   
> +static int __init guest_physmap_add_shm(struct domain *od, struct domain *bd,
> +                                        unsigned long o_gfn,
> +                                        unsigned long b_gfn,
> +                                        unsigned long nr_gfns)
> +{
> +    struct page_info **pages = NULL;
> +    p2m_type_t p2mt, t;
> +    int ret = 0;

You don't need to initialize ret.

> +
> +    pages = xmalloc_array(struct page_info *, nr_gfns);
> +    if ( !pages )
> +        return -ENOMEM;
> +
> +    /*
> +     * Take reference of statically shared pages from owner domain.
> +     * Reference will be released when destroying shared memory region.
> +     */
> +    ret = get_pages_from_gfn(od, o_gfn, nr_gfns, pages, &p2mt, P2M_ALLOC);
> +    if ( ret )
> +    {
> +        ret = -EINVAL;
> +        goto fail_pages;
> +    }
> +
> +    if ( p2m_is_ram(p2mt) )
> +        t = (p2mt == p2m_ram_rw) ? p2m_map_foreign_rw : p2m_map_foreign_ro;
> +    else
> +    {
> +        ret = -EINVAL;
> +        goto fail_pages;

Where would we release the references?

> +    }
> +
> +    /* Set up guest foreign map. */
> +    ret = guest_physmap_add_pages(bd, _gfn(b_gfn), page_to_mfn(pages[0]),
> +                                  nr_gfns, t);

A few things:
   - The beginning of the code assumes that the MFN may be discontiguous 
in the physical memory. But here, you are assuming they are contiguous. 
If you want the latter, then you should check the MFNs are contiguous. 
That said, I am not sure if this restriction is really necessary.

   - IIRC, guest_physmap_add_pages() doesn't revert the mappings. So you 
need to revert it in case of failure.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 23:16:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 23:16:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301818.515152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxpi-0002WL-Ms; Fri, 08 Apr 2022 23:16:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301818.515152; Fri, 08 Apr 2022 23:16:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxpi-0002WE-JD; Fri, 08 Apr 2022 23:16:02 +0000
Received: by outflank-mailman (input) for mailman id 301818;
 Fri, 08 Apr 2022 23:16:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncxph-0002W4-HT; Fri, 08 Apr 2022 23:16:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncxph-0005Da-Dz; Fri, 08 Apr 2022 23:16:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncxph-0005sd-3r; Fri, 08 Apr 2022 23:16:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncxph-0007h6-1g; Fri, 08 Apr 2022 23:16:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=L7+WJvIi1XU3JPqubon6Jb66MmtIvZNxEpRjaz6uFJQ=; b=eoLptW9p9N1ax6SVKd65nkL8FQ
	cV5uMIO/GmDdamLZDumXC4S64QEnBxtzKkFkXaGvvu4R4uvAcs6CgS32aUnkxmIyhPmLZf7wnxlFf
	Z/OSyhSiBdtesPGNRt5XU6Im6u1wdHvkTKknzA343Pc3VhJyxGzszaXcw8beb6OhfIGM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169250-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169250: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
X-Osstest-Versions-That:
    xen=2e6f95a942d1927a53f077c301db0b799c54c05a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 23:16:01 +0000

flight 169250 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169250/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
baseline version:
 xen                  2e6f95a942d1927a53f077c301db0b799c54c05a

Last test of basis   169236  2022-04-08 13:00:27 Z    0 days
Testing same since   169250  2022-04-08 20:03:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2e6f95a942..8847ec08fd  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 23:16:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 23:16:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301824.515163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxqL-00031n-1u; Fri, 08 Apr 2022 23:16:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301824.515163; Fri, 08 Apr 2022 23:16:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxqK-00031g-Tc; Fri, 08 Apr 2022 23:16:40 +0000
Received: by outflank-mailman (input) for mailman id 301824;
 Fri, 08 Apr 2022 23:16:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nBby=US=gmail.com=richard.weiyang@srs-se1.protection.inumbo.net>)
 id 1ncxqI-0002oa-Qd
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 23:16:38 +0000
Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com
 [2a00:1450:4864:20::629])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f0b41b88-b791-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 01:16:38 +0200 (CEST)
Received: by mail-ej1-x629.google.com with SMTP id l7so14658009ejn.2
 for <xen-devel@lists.xenproject.org>; Fri, 08 Apr 2022 16:16:37 -0700 (PDT)
Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id
 z21-20020a1709063a1500b006da6436819dsm9098147eje.173.2022.04.08.16.16.37
 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 08 Apr 2022 16:16:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0b41b88-b791-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:reply-to:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=A2ZrlgJ+VrtokqXnuamBEtt/J5VIyMuX+6kPQRag0BE=;
        b=N2tlbM5sjWAgO8qyd8xUS+x79WJ0ZseWclBiQ5Uph4APriR9kfGWaNYH2HjeaLpQbH
         UJTVvDMt590jDOrwUeY+B/Xumz4rFwoxMNKI+BRRbmPbBetC1zBSvfMBBv1Eotr4E00p
         roAu4eZNL5KzxxejvkI6WhuQ2ikCAunpCpNjNAu8uDwhxqremovJpTgAS6JsSCFfT3oh
         XTnA/4/mDkG8TrTLjxvngKVHTS6evew0i/L9g+eyUiKwIxFFLEsV9JXidIOfAJA2D32s
         nw8gj46C8yrXz0NA4Gwj7AqCOchIP5jp9nu3yM87aVy/eoDY0cH+6XOUTOTtBAaAr6Ts
         GXwg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to
         :references:mime-version:content-disposition:in-reply-to:user-agent;
        bh=A2ZrlgJ+VrtokqXnuamBEtt/J5VIyMuX+6kPQRag0BE=;
        b=Nxc94/OARbgN84zLaODIyArOW1Y/29yojMYrE76I35e0peiIAy5p+KfSeIY16cv0kZ
         ZlKTIBvz423BrfLELIPoU4nLRbDtAJnsoRqosOkWUTSYlJ2IoTNaNRBMfFAjqZ4D4Bff
         Afp6AuqRh9AqJGfvv4iZLCvw8SNeWZBbtUQUb/L7yjLd5/f36k0zFcWCnOxejwE/6Vvy
         23mpTGFtMDP4FLEyn2Qgiq7La4V23nEEtJAvC5IDVF8KhtVQ0v9qjSP/KLb32i8URb2a
         XwoLSg+FYhVXIab6fXfBQa2VpuE4L/OKYF4zRS92eMfHl2d/A7imdDkckFY27d4aW4rI
         MtFw==
X-Gm-Message-State: AOAM533mb8mru8zByYiPO6hpJzOSM/wtsenVZsr2ot+duYKd34gx4wT+
	G1AUL923iPM7kAdITSb560E=
X-Google-Smtp-Source: ABdhPJxxChRoxlprELOAqhnCawCzlD4GSAcZ0w3f3uVWj3UaU9JZ4tUDBqifGUtDHDOIU2hkiPJliA==
X-Received: by 2002:a17:906:2991:b0:6cf:6b24:e92f with SMTP id x17-20020a170906299100b006cf6b24e92fmr20192204eje.748.1649459797553;
        Fri, 08 Apr 2022 16:16:37 -0700 (PDT)
Date: Fri, 8 Apr 2022 23:16:36 +0000
From: Wei Yang <richard.weiyang@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
	Marek Marczykowski-G??recki <marmarek@invisiblethingslab.com>,
	Wei Yang <richard.weiyang@gmail.com>,
	Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone
Message-ID: <20220408231636.dz3spgicntflr7wu@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20220406133229.15979-1-jgross@suse.com>
 <89ad978d-e95e-d3ea-5c8f-acf4b28f992c@redhat.com>
 <4f1908b5-5674-a772-3cd9-78e4dc40f776@suse.com>
 <f423e210-3e28-73f8-1082-869ef680b9b0@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f423e210-3e28-73f8-1082-869ef680b9b0@redhat.com>
User-Agent: NeoMutt/20170113 (1.7.2)

On Thu, Apr 07, 2022 at 11:00:33AM +0200, David Hildenbrand wrote:
>On 07.04.22 10:50, Juergen Gross wrote:
>> On 07.04.22 10:23, David Hildenbrand wrote:
>>> On 06.04.22 15:32, Juergen Gross wrote:
>>>> When onlining a new memory page in a guest the Xen balloon driver is
>>>> adding it to the ballooned pages instead making it available to be
>>>> used immediately. This is meant to enable to add a new upper memory
>>>> limit to a guest via hotplugging memory, without having to assign the
>>>> new memory in one go.
>>>>
>>>> In case the upper memory limit will be raised above 4G, the new memory
>>>> will populate the ZONE_NORMAL memory zone, which wasn't populated
>>>> before. The newly populated zone won't be added to the list of zones
>>>> looked at by the page allocator though, as only zones with available
>>>> memory are being added, and the memory isn't yet available as it is
>>>> ballooned out.
>>>
>>> I think we just recently discussed these corner cases on the -mm list.
>> 
>> Indeed.
>> 
>>> The issue is having effectively populated zones without manages pages
>>> because everything is inflated in a balloon.
>> 
>> Correct.
>> 
>>> That can theoretically also happen when managing to fully inflate the
>>> balloon in one zone and then, somehow, the zones get rebuilt.
>> 
>> I think you are right. I didn't think of that scenario.
>> 
>>> build_zonerefs_node() documents "Add all populated zones of a node to
>>> the zonelist" but checks for managed zones, which is wrong.
>>>
>>> See https://lkml.kernel.org/r/20220201070044.zbm3obsoimhz3xd3@master
>> 
>> I found commit 6aa303defb7454 which introduced this test. I thought
>> it was needed due to the problem this commit tried to solve. Maybe I
>> was wrong and that commit shouldn't have changed the condition when
>> building the zonelist, but just the ones in the allocation paths.
>
>In regard to kswapd, that is currently being worked on via
>
>https://lkml.kernel.org/r/20220329010901.1654-2-richard.weiyang@gmail.com
>

Thanks, David

Do you think it is the right time to repost the original fix?

>-- 
>Thanks,
>
>David / dhildenb

-- 
Wei Yang
Help you, Help me


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 23:18:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 23:18:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301832.515174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxs6-0003xS-CW; Fri, 08 Apr 2022 23:18:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301832.515174; Fri, 08 Apr 2022 23:18:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxs6-0003xJ-96; Fri, 08 Apr 2022 23:18:30 +0000
Received: by outflank-mailman (input) for mailman id 301832;
 Fri, 08 Apr 2022 23:18:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5u+K=US=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ncxs5-0003w6-Dv
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 23:18:29 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 329182f1-b792-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 01:18:28 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 1347EB82D69;
 Fri,  8 Apr 2022 23:18:28 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 802B6C385A1;
 Fri,  8 Apr 2022 23:18:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 329182f1-b792-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649459906;
	bh=GzX4JEvBeis5zUcNVM4Cn8q3+ajY0d419M9BmlpjrY4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=oY/RFXOtMz5nSXkX1sbROidugRyslpcSA/67gIJWu21EjYgk5dHL1vNdoFa24w8qd
	 h6a0g7IJvyytc7WZmcxB5dZM1BWlgfoGW/q4KJWh78uiE/BQaeSUvfxNDpqkB2m1Yn
	 eBavAKdYcluwVYadrhyKlk039QDqJ0uKAhjceWp970CZ0uqXrr+Q99cPDjpn7d9BVB
	 WJ9jsbeMpV+XhEdXv4pu4XBySLEVZdv+YIF/pdFlmiAaAFn7kuxwOc6KMPDnCkAerX
	 00HTc9CvyYaBEq9aqeIndj5VkspwYjbFq7AxsDkvzSHgkQv+kmhqIiGjDMlnUda9Zc
	 zJW/DN9GebcCw==
Date: Fri, 8 Apr 2022 16:18:26 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Penny Zheng <Penny.Zheng@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    nd <nd@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
In-Reply-To: <a9628233-5c2e-abb2-1df8-f45e4ac3280b@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204081608420.3066615@ubuntu-linux-20-04-desktop>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com> <20220311061123.1883189-7-Penny.Zheng@arm.com> <alpine.DEB.2.22.394.2203171744190.3497@ubuntu-linux-20-04-desktop> <DU2PR08MB732540A4196E8634B4D8A579F71E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204081516400.3066615@ubuntu-linux-20-04-desktop> <a9628233-5c2e-abb2-1df8-f45e4ac3280b@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Apr 2022, Julien Grall wrote:
> On 08/04/2022 23:18, Stefano Stabellini wrote:
> > On Tue, 29 Mar 2022, Penny Zheng wrote:
> > > Right now, the memory attribute of static shared memory is RW as default,
> > > What if we add memory attribute setting in device tree configuration,
> > > sometimes,
> > > Users want to specify that borrower domain only has RO right, hmm, then
> > > the
> > > Initialization for p2mt could be either p2m_ram_rw or p2m_ram_ro?
> > > In such case, we could add another parameter in guest_physmap_add_shm to
> > > show the p2m type...
> > > Hope I understand what you suggested here.
> > 
> > Yes, I think I understand. I think your suggestion is OK too. However,
> > your suggestion is much more work than mine: I was only suggesting a
> > small improvement limited to guest_physmap_add_shm and
> > get_pages_from_gfn. Your suggestion involves a device tree change that
> > would have a larger impact on the patch series. So if you are up for it,
> > I am happy to review it. I am also fine just to have a small improvement
> > on guest_physmap_add_shm/get_pages_from_gfn.
> 
> AFAIU, your proposal would mean that the behavior for get_pages_from_gfn() and
> get_page_from_gfn() will differ. This is not great.
> 
> I don't think we can easily change the behavior of get_page_from_gfn() because
> some callers can accept multiple types.
> 
> Furthermore, while today we only check p2m_ram_rw. It might be possible that
> we would want to check different type. For instance, if we want to use
> read-only mapping, it would be fine to accept p2m_ram_ro and p2m_ram_rw.
> 
> So overall, I am not in favor of initializing p2mt and let
> get_pages_from_gfn() to check the type.

OK. In that case, I suggest to leave the code pretty much as is in
regards of how get_pages_from_gfn is called from guest_physmap_add_shm.


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 23:21:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 23:21:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301837.515185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxv3-0005LX-R2; Fri, 08 Apr 2022 23:21:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301837.515185; Fri, 08 Apr 2022 23:21:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncxv3-0005LQ-O3; Fri, 08 Apr 2022 23:21:33 +0000
Received: by outflank-mailman (input) for mailman id 301837;
 Fri, 08 Apr 2022 23:21:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nBby=US=gmail.com=richard.weiyang@srs-se1.protection.inumbo.net>)
 id 1ncxv2-0005LK-M3
 for xen-devel@lists.xenproject.org; Fri, 08 Apr 2022 23:21:32 +0000
Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com
 [2a00:1450:4864:20::634])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f17e6e5-b792-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 01:21:30 +0200 (CEST)
Received: by mail-ej1-x634.google.com with SMTP id bq8so20052190ejb.10
 for <xen-devel@lists.xenproject.org>; Fri, 08 Apr 2022 16:21:30 -0700 (PDT)
Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id
 v8-20020a50d848000000b0041cb912717asm8936807edj.91.2022.04.08.16.21.29
 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 08 Apr 2022 16:21:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f17e6e5-b792-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:reply-to:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=VeBo5MNmcNP8GgrnYnuxwD9C21s9NCSI0hQmRgeVZ2c=;
        b=SwUdCASoZsLrVzHwYE9Q2w7j8anHVyABwID7GJeaxGfrbLM5k0Ll9QikJqmhJzldK2
         DEhbbyAiFI6iSlauWF8t+jKysCy4/ituH373bOQYneDjgtlRMT6MU1S3YxRPtJMX4oX1
         xiqUnHmj8t0fgyqR+02CHlzq+jgHtUhjPECIh0Ks3TbRC2E9CvqftD/OWYrUdEqNpZjp
         3glxzcacU6WGhpBVaEXzCQ0oxQ8tSiZTZ4JCiNXATn1QSgRsiUvuhHZik+iIDX+IIXcf
         8J9iJvcV6FOxsjwd8QIAaWSAR31c/r5e3ajAJURaZ6AV3A29bWAbfjYHTsvDoGioJU0U
         luDQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to
         :references:mime-version:content-disposition:in-reply-to:user-agent;
        bh=VeBo5MNmcNP8GgrnYnuxwD9C21s9NCSI0hQmRgeVZ2c=;
        b=Q7pcVjbebdySi7jEak+8XdOTdRPyk0ERPd/DK1SZhC9Lu/+qr7685zSuHi7NSr3lvZ
         TH7AossrocMD3Sg+8iU1vl4/6O5NlqvKbN7eFDmbLyipJ7XFDm00UusiGoR6AXXvYws7
         ni6r/3l+Mse7YwRHmU1hO7u2r76bsRA4+mcs+PyhdmT8vsXemMu4nILF+WdWPL95Yw/a
         Zh+5lVtS5O9na/nRGOY3n8bMruy1le366pUPN7+VQae9ol7C5odvtcY2SS6t9IS/XjUf
         PO5Rd10UPUl9LN3u6FKMyodUya93IfnP6BIu+XpyfmKvfhRwxRbAJz6g2SUDY8nCdMrZ
         phlA==
X-Gm-Message-State: AOAM530uqtXan8WqZj0W3DIPp+YoNv2Wx3G+kgvKyFR6uN9L0VMo8Y4T
	5SbirCq0FHkRImtjeazi3Ow=
X-Google-Smtp-Source: ABdhPJw0QRTK6Xo+GwWqeZ539WFr3ViLkQZwB5m+GvauaxNMLcPszYUGFgrOGSqHLo80QDJyI0Moiw==
X-Received: by 2002:a17:907:7da8:b0:6e0:5b94:5ed8 with SMTP id oz40-20020a1709077da800b006e05b945ed8mr19652474ejc.312.1649460090158;
        Fri, 08 Apr 2022 16:21:30 -0700 (PDT)
Date: Fri, 8 Apr 2022 23:21:29 +0000
From: Wei Yang <richard.weiyang@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>, stable@vger.kernel.org,
	Marek Marczykowski-G??recki <marmarek@invisiblethingslab.com>,
	Michal Hocko <mhocko@kernel.org>,
	Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Message-ID: <20220408232129.caboqxtw6s4nmgde@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20220407093221.1090-1-jgross@suse.com>
 <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com>
User-Agent: NeoMutt/20170113 (1.7.2)

On Thu, Apr 07, 2022 at 11:46:13AM +0200, David Hildenbrand wrote:
>On 07.04.22 11:32, Juergen Gross wrote:
>> Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
>> initialization") only zones with free memory are included in a built
>> zonelist. This is problematic when e.g. all memory of a zone has been
>> ballooned out.
>> 
>> Use populated_zone() when building a zonelist as it has been done
>> before that commit.
>> 
>> Cc: stable@vger.kernel.org
>> Fixes: 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization")
>> Reported-by: Marek Marczykowski-G??recki <marmarek@invisiblethingslab.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>  mm/page_alloc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index bdc8f60ae462..3d0662af3289 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
>>  	do {
>>  		zone_type--;
>>  		zone = pgdat->node_zones + zone_type;
>> -		if (managed_zone(zone)) {
>> +		if (populated_zone(zone)) {
>>  			zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>>  			check_highest_zone(zone_type);
>>  		}
>
>Let's see if we have to find another way to properly handle fadump.
>
>Acked-by: David Hildenbrand <david@redhat.com>

Ok, I see the point.

Reviewed-by: Wei Yang <richard.weiyang@gmail.com>

>
>-- 
>Thanks,
>
>David / dhildenb

-- 
Wei Yang
Help you, Help me


From xen-devel-bounces@lists.xenproject.org Fri Apr 08 23:54:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Apr 2022 23:54:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301842.515195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncyQt-0000xn-C5; Fri, 08 Apr 2022 23:54:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301842.515195; Fri, 08 Apr 2022 23:54:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ncyQt-0000xg-9B; Fri, 08 Apr 2022 23:54:27 +0000
Received: by outflank-mailman (input) for mailman id 301842;
 Fri, 08 Apr 2022 23:54:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncyQs-0000xW-1H; Fri, 08 Apr 2022 23:54:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncyQr-0005pQ-Up; Fri, 08 Apr 2022 23:54:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ncyQq-0000et-V8; Fri, 08 Apr 2022 23:54:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ncyQq-0003yV-U1; Fri, 08 Apr 2022 23:54:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OhzwrtAQB9p+F9DO24tKwkykzNTu41v9E9sQ+OmiXuc=; b=v7A7pimbh8zZ/m7bSavO7YgAnX
	fHMCMxmIi9pEoBpjiuktA7mcNlGtOW5q10GF2f4ML1hxotEUxxsDfisU3GlIukgQfTnSoK4LKHQ3X
	DPYKnqvLCdL+FE9n6JP0fbIJwmy6MPid7mOj1qfVrXsImOTSCk0uSuyCLCra8N0PGVjs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169237-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 169237: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d9e73f6320b311d739546d6325e530f07392c100
X-Osstest-Versions-That:
    xen=10cd51d5bf5f2d9ebe5f36a1b428f65ff5efd115
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Apr 2022 23:54:24 +0000

flight 169237 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169237/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169193
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169193
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169193
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169193
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169193
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169193
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169193
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169193
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169193
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169193
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169193
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169193
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d9e73f6320b311d739546d6325e530f07392c100
baseline version:
 xen                  10cd51d5bf5f2d9ebe5f36a1b428f65ff5efd115

Last test of basis   169193  2022-04-06 08:39:21 Z    2 days
Testing same since   169237  2022-04-08 13:06:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   10cd51d5bf..d9e73f6320  d9e73f6320b311d739546d6325e530f07392c100 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 01:00:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 01:00:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301860.515235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nczST-0004NW-Ki; Sat, 09 Apr 2022 01:00:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301860.515235; Sat, 09 Apr 2022 01:00:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nczST-0004MR-Hc; Sat, 09 Apr 2022 01:00:09 +0000
Received: by outflank-mailman (input) for mailman id 301860;
 Sat, 09 Apr 2022 01:00:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1EL/=UT=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nczSS-0003Zz-0D
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 01:00:08 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 62f31d18-b7a0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 03:00:04 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 08EED621AC;
 Sat,  9 Apr 2022 01:00:02 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0104C385A1;
 Sat,  9 Apr 2022 01:00:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62f31d18-b7a0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649466001;
	bh=9fLYTT4Wem36dkRfFRxeiQLlzfXYxwhIj2O9JzmoZ+8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dAty1iVM/IUynNAC+pvfQkO3DALFCN95CvU8pziNR2vEt524RI3CUinZ0ciGwrMb3
	 c7PsExXztIjRF2pvAY8ZHzA8+uO5YBJ4EnG86BtSUb8kDR9b+NPkDGANkArWIIpWbZ
	 lmmi+BB/yLlMpHIxZoYrKXmS78kB9bbkm+Sdxl0HTS1k/DKvQ6CnQR92PesHkgpJMm
	 +3Tm80mqZXsMbNuEbyZlxniye4izqOJaNKJIaJK77aTQT0iZz6CLrmaef0YCmXnqBB
	 tx6otcdfSl9PkHULg/XrLgUWNXMj5BHR4Uy+JeglZyHVT2T//Sc0uAisbn+I/Vbb4P
	 a6gzcOoDX5JrA==
Date: Fri, 8 Apr 2022 18:00:00 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
In-Reply-To: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-423868291-1649462822=:3066615"
Content-ID: <alpine.DEB.2.22.394.2204081707160.3066615@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-423868291-1649462822=:3066615
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204081707161.3066615@ubuntu-linux-20-04-desktop>

On Wed, 23 Mar 2022, Rahul Singh wrote:
> in dom0less system. This patch introduce the new feature to support the
> signaling between two domUs in dom0less system.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>  docs/designs/dom0less-evtchn.md | 96 +++++++++++++++++++++++++++++++++
>  1 file changed, 96 insertions(+)
>  create mode 100644 docs/designs/dom0less-evtchn.md
> 
> diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md
> new file mode 100644
> index 0000000000..6a1b7e8c22
> --- /dev/null
> +++ b/docs/designs/dom0less-evtchn.md
> @@ -0,0 +1,96 @@
> +# Signaling support between two domUs on dom0less system
> +
> +## Current state: Draft version
> +
> +## Proposer(s): Rahul Singh, Bertrand Marquis
> +
> +## Problem Statement:
> +
> +The goal of this work is to define a simple signaling system between Xen guests
> +in dom0less systems.
> +
> +In dom0less system, we cannot make use of xenbus and xenstore that are used in
> +normal systems with dynamic VMs to communicate between domains by providing a
> +bus abstraction for paravirtualized drivers.
> +
> +One possible solution to implement the signaling system between domUs is based
> +on event channels.

I suggest to reword this as follows:

---
Dom0less guests would benefit from a statically-defined memory sharing
and signally system for communication. One that would be immediately
available at boot without any need for dynamic configurations.

In embedded a great variety of guest operating system kernels exist,
many of which don't have support for xenstore, grant table or other
complex drivers. Some of them are small kernel-space applications (often
called "baremetal", not to be confused with the term "baremetal" used in
datacenter which means "without hypervisors") or RTOSes.  Additionally,
for safety reasons, users often need to be able to configure the full
system statically so that it can be verified statically.

Event channels are very simple and can be added even to baremetal
applications. This proposal introduces a way to define them statically
to make them suitable to dom0less embedded deployments.
---


> +## Proposal:
> +
> +Event channels are the basic primitive provided by Xen for event notifications.
> +An event channel is a logical connection between 2 domains (more specifically
> +between dom1,port1 and dom2,port2). They essentially store one bit of
> +information, the event of interest is signalled by transitioning this bit from
> +0 to 1. An event is an equivalent of a hardware interrupt.
> +
> +Notifications are received by a guest via an interrupt from Xen to the guest,
> +indicating when an event arrives (setting the bit). Further notifications are
> +masked until the bit is cleared again. When a domain wants to wait for data it
> +will block until an event arrives, and then send an event to signal that data
> +has been consumed. Events are delivered asynchronously to guests and are
> +enqueued when the guest is not running.
> +
> +Event channel communication will be established statically between two domU
> +guests before unpausing the domains after domain creation. Event channel
> +connection information between domUs will be passed to XEN via device tree
> +node.
> +
> +Under the /chosen node, there needs to be sub nodes with compatible
> +"xen,evtchn" that descibes the event channel connection between two domUs.
> +
> +The event channel sub-node has the following properties:
> +
> +- compatible
> +
> +    "xen,evtchn"
> +
> +- xen,evtchn
> +
> +    The property is four numbers of tuples of
> +    (local-port-domU1,domU1-phandle,local-port-domU2,domU2-phandle) where:
> +
> +    local-port-domU1 is an integer value that will be used to allocte local
> +    port for domU1 to send an event notification to the remote domain.
> +
> +    domU1-phandle is a single phandle to an domain to which local-port-domU1
> +    will be allocated.
> +
> +    local-port-domU2 is an integer value that will be used to allocte local
> +    port for domU2 to send an event notification to the remote domain.
> +
> +    domU2-phandle is a single phandle to an domain to which local-port-domU2
> +    will be allocated.
> +
> +Example:
> +
> +    chosen {
> +        ....
> +
> +        domU1: domU1 {
> +            ......
> +        };
> +
> +        domU2: domU2 {
> +            ......
> +        };
> +
> +        evtchn@1 {
> +            compatible = "xen,evtchn";
> +            xen,evtchn = <0xa &domU1 0xb &domU2>;
> +        };
> +
> +        evtchn@2 {
> +            compatible = "xen,evtchn";
> +            xen,evtchn = <0xc &domU1 0xd &domU2>;
> +        };
> +    };

There is no need to use two evtchn nodes for this given that in device
tree it is entirely normal to have multiple tuplets in a property. Also,
it would be good to have a version number in the compatible string so
that we can change version in the future.

1)
    chosen {
        ....

        domU1: domU1 {
            ......
        };

        domU2: domU2 {
            ......
        };

        evtchn {
            compatible = "xen,evtchn-v1";
            xen,evtchn = <0xa &domU1 0xb &domU2 0xc &domU1 0xd &domU2>;
        };
    };


I should mention that it would be also possible to use sub-nodes to
express this information:

2)
        domU1: domU1 {
            ...
            /* one sub-node per local event channel */
            ec1: evtchn@a {
                compatible = "xen,evtchn-v1";
                /* local-evtchn link-to-foreign-evtchn */
                xen,evtchn = <0xa &ec3>
            };
            ec2: evtchn@c {
                compatible = "xen,evtchn-v1";
                xen,evtchn = <0xc &ec4>
            };
        };

        domU2: domU2 {
            ...
            ec3: evtchn@b {
                compatible = "xen,evtchn-v1";
                xen,evtchn = <0xb &ec1>
            };
            ec4: evtchn@d {
                compatible = "xen,evtchn-v1";
                xen,evtchn = <0xa &ec2>
            };
        };
    };

This format has the advantage that doesn't need a new top-level node
type under /chosen. That is desirable few a few reasons. Today we only
have domains (dom0 is legacy). In the future we might have nested
domains and non-Xen domains. With System Device Tree, domains are under
/domains instead of /chosen.

So normally I would argue to use the sub-node format because it doesn't
need a new top-level node under /chosen. However, in this case it looks
like the 1) format is simpler to write and also simpler to parse in Xen.

In 1), we would need to loop over xen,evtchn and for each tuplet we
would only need to fetch the foreign domid.

In 2), we would need to check the compatible string of every
"xen,evtchn-v1" node, and we would have to fetch from the phandle both
the remote event channel number but also the domain-id of the parent.

So it looks like 1) is better because it is much simpler to parse. Do
you agree?


> +In above example two event channel comunication will be established between
> +domU1 and domU2.
> +
> +    domU1 (port 0xa) <-----------------> domU2 (port 0xb)
> +    domU1 (port 0xc) <-----------------> domU2 (port 0xd)
> +
> +domU1 and domU2 can send the signal to remote domain via hypercall
> +EVTCHNOP_send(.) on local port.

I think this is fine in principle. Like Jan wrote, at some point we'll
need to specify the device tree binding to expose this information to
the guest.
--8323329-423868291-1649462822=:3066615--


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 01:45:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 01:45:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301865.515246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd09s-0008HL-3f; Sat, 09 Apr 2022 01:45:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301865.515246; Sat, 09 Apr 2022 01:45:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd09r-0008Gu-TA; Sat, 09 Apr 2022 01:44:59 +0000
Received: by outflank-mailman (input) for mailman id 301865;
 Sat, 09 Apr 2022 01:44:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1EL/=UT=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nd09r-0008Go-CG
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 01:44:59 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8d9bda8-b7a6-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 03:44:57 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 248EE62220;
 Sat,  9 Apr 2022 01:44:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 235E3C385A1;
 Sat,  9 Apr 2022 01:44:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8d9bda8-b7a6-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649468695;
	bh=JD7nwjtMwLwXZ61zCNVpq4UXjH4WCYCO9ccOzy7810I=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=O1kHKOEqwaAWnZi8E0kq52UiJWYRpWtlIaPyVs852PwYvrq/upnJtDPO4mleew0qT
	 1+9bCOyufjeTX+hcV6FHnYahTZg4T/sPNntVo7OIZCiOebgM//xKurrtS3CQfumk13
	 NjLnVFKtwLY7PQ2MtOtQSJzXxzFfL/YLIJ7ZZtXX7UUVJTSmkrhBiaBnpP6udK/hb+
	 mP0cWTTY/Eeuc4jeFvNIjt4yfQJdPISgkrAJRQciBgYkQSXYOCl5Cdcv0Ecy9EAUVM
	 tGruW0qlwuL+IF6TkokvTjfG4Zwajv3rSeXNssumezfXw7Rux2+4jQ7H4tg2jAxkV1
	 1TyLradaBH6tg==
Date: Fri, 8 Apr 2022 18:44:54 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org, 
    bertrand.marquis@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
In-Reply-To: <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
Message-ID: <alpine.DEB.2.22.394.2204081837410.3066615@ubuntu-linux-20-04-desktop>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com> <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1710515683-1649468696=:3066615"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1710515683-1649468696=:3066615
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Fri, 8 Apr 2022, Stefano Stabellini wrote:
> On Wed, 23 Mar 2022, Rahul Singh wrote:
> > in dom0less system. This patch introduce the new feature to support the
> > signaling between two domUs in dom0less system.
> > 
> > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> > ---
> >  docs/designs/dom0less-evtchn.md | 96 +++++++++++++++++++++++++++++++++
> >  1 file changed, 96 insertions(+)
> >  create mode 100644 docs/designs/dom0less-evtchn.md
> > 
> > diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md
> > new file mode 100644
> > index 0000000000..6a1b7e8c22
> > --- /dev/null
> > +++ b/docs/designs/dom0less-evtchn.md
> > @@ -0,0 +1,96 @@
> > +# Signaling support between two domUs on dom0less system
> > +
> > +## Current state: Draft version
> > +
> > +## Proposer(s): Rahul Singh, Bertrand Marquis
> > +
> > +## Problem Statement:
> > +
> > +The goal of this work is to define a simple signaling system between Xen guests
> > +in dom0less systems.
> > +
> > +In dom0less system, we cannot make use of xenbus and xenstore that are used in
> > +normal systems with dynamic VMs to communicate between domains by providing a
> > +bus abstraction for paravirtualized drivers.
> > +
> > +One possible solution to implement the signaling system between domUs is based
> > +on event channels.
> 
> I suggest to reword this as follows:
> 
> ---
> Dom0less guests would benefit from a statically-defined memory sharing
> and signally system for communication. One that would be immediately
> available at boot without any need for dynamic configurations.
> 
> In embedded a great variety of guest operating system kernels exist,
> many of which don't have support for xenstore, grant table or other
> complex drivers. Some of them are small kernel-space applications (often
> called "baremetal", not to be confused with the term "baremetal" used in
> datacenter which means "without hypervisors") or RTOSes.  Additionally,
> for safety reasons, users often need to be able to configure the full
> system statically so that it can be verified statically.
> 
> Event channels are very simple and can be added even to baremetal
> applications. This proposal introduces a way to define them statically
> to make them suitable to dom0less embedded deployments.
> ---
> 
> 
> > +## Proposal:
> > +
> > +Event channels are the basic primitive provided by Xen for event notifications.
> > +An event channel is a logical connection between 2 domains (more specifically
> > +between dom1,port1 and dom2,port2). They essentially store one bit of
> > +information, the event of interest is signalled by transitioning this bit from
> > +0 to 1. An event is an equivalent of a hardware interrupt.
> > +
> > +Notifications are received by a guest via an interrupt from Xen to the guest,
> > +indicating when an event arrives (setting the bit). Further notifications are
> > +masked until the bit is cleared again. When a domain wants to wait for data it
> > +will block until an event arrives, and then send an event to signal that data
> > +has been consumed. Events are delivered asynchronously to guests and are
> > +enqueued when the guest is not running.
> > +
> > +Event channel communication will be established statically between two domU
> > +guests before unpausing the domains after domain creation. Event channel
> > +connection information between domUs will be passed to XEN via device tree
> > +node.
> > +
> > +Under the /chosen node, there needs to be sub nodes with compatible
> > +"xen,evtchn" that descibes the event channel connection between two domUs.
> > +
> > +The event channel sub-node has the following properties:
> > +
> > +- compatible
> > +
> > +    "xen,evtchn"
> > +
> > +- xen,evtchn
> > +
> > +    The property is four numbers of tuples of
> > +    (local-port-domU1,domU1-phandle,local-port-domU2,domU2-phandle) where:
> > +
> > +    local-port-domU1 is an integer value that will be used to allocte local
> > +    port for domU1 to send an event notification to the remote domain.
> > +
> > +    domU1-phandle is a single phandle to an domain to which local-port-domU1
> > +    will be allocated.
> > +
> > +    local-port-domU2 is an integer value that will be used to allocte local
> > +    port for domU2 to send an event notification to the remote domain.
> > +
> > +    domU2-phandle is a single phandle to an domain to which local-port-domU2
> > +    will be allocated.
> > +
> > +Example:
> > +
> > +    chosen {
> > +        ....
> > +
> > +        domU1: domU1 {
> > +            ......
> > +        };
> > +
> > +        domU2: domU2 {
> > +            ......
> > +        };
> > +
> > +        evtchn@1 {
> > +            compatible = "xen,evtchn";
> > +            xen,evtchn = <0xa &domU1 0xb &domU2>;
> > +        };
> > +
> > +        evtchn@2 {
> > +            compatible = "xen,evtchn";
> > +            xen,evtchn = <0xc &domU1 0xd &domU2>;
> > +        };
> > +    };
> 
> There is no need to use two evtchn nodes for this given that in device
> tree it is entirely normal to have multiple tuplets in a property. Also,
> it would be good to have a version number in the compatible string so
> that we can change version in the future.
> 
> 1)
>     chosen {
>         ....
> 
>         domU1: domU1 {
>             ......
>         };
> 
>         domU2: domU2 {
>             ......
>         };
> 
>         evtchn {
>             compatible = "xen,evtchn-v1";
>             xen,evtchn = <0xa &domU1 0xb &domU2 0xc &domU1 0xd &domU2>;
>         };
>     };
> 
> 
> I should mention that it would be also possible to use sub-nodes to
> express this information:
> 
> 2)
>         domU1: domU1 {
>             ...
>             /* one sub-node per local event channel */
>             ec1: evtchn@a {
>                 compatible = "xen,evtchn-v1";
>                 /* local-evtchn link-to-foreign-evtchn */
>                 xen,evtchn = <0xa &ec3>
>             };
>             ec2: evtchn@c {
>                 compatible = "xen,evtchn-v1";
>                 xen,evtchn = <0xc &ec4>
>             };
>         };
> 
>         domU2: domU2 {
>             ...
>             ec3: evtchn@b {
>                 compatible = "xen,evtchn-v1";
>                 xen,evtchn = <0xb &ec1>
>             };
>             ec4: evtchn@d {
>                 compatible = "xen,evtchn-v1";
>                 xen,evtchn = <0xa &ec2>
>             };
>         };
>     };
> 
> This format has the advantage that doesn't need a new top-level node
> type under /chosen. That is desirable few a few reasons. Today we only
> have domains (dom0 is legacy). In the future we might have nested
> domains and non-Xen domains. With System Device Tree, domains are under
> /domains instead of /chosen.
> 
> So normally I would argue to use the sub-node format because it doesn't
> need a new top-level node under /chosen. However, in this case it looks
> like the 1) format is simpler to write and also simpler to parse in Xen.
> 
> In 1), we would need to loop over xen,evtchn and for each tuplet we
> would only need to fetch the foreign domid.
> 
> In 2), we would need to check the compatible string of every
> "xen,evtchn-v1" node, and we would have to fetch from the phandle both
> the remote event channel number but also the domain-id of the parent.
> 
> So it looks like 1) is better because it is much simpler to parse. Do
> you agree?

[...]
> 
> I think this is fine in principle. Like Jan wrote, at some point we'll
> need to specify the device tree binding to expose this information to
> the guest.

Actually, thinking more about it, I think it is likely that the guest
device tree bindings will include information about how it is supposed
to be used. For instance, the domU device tree might pair an event
channel with a shared memory region so that the domU knows that they are
expected to be used together.

If Xen is to generate such a device tree for guests, then we need that
information also on the host device tree too (the one given to Xen and
discussed here.)

So, I think it would be a good idea to discuss the domU device tree
bindings for this, as part of this design document, even if we don't
implement it straight away.
--8323329-1710515683-1649468696=:3066615--


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 02:07:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 02:07:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301870.515257 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd0Uu-00036l-Sb; Sat, 09 Apr 2022 02:06:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301870.515257; Sat, 09 Apr 2022 02:06:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd0Uu-00036e-Nj; Sat, 09 Apr 2022 02:06:44 +0000
Received: by outflank-mailman (input) for mailman id 301870;
 Sat, 09 Apr 2022 02:06:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd0Ut-00036U-GQ; Sat, 09 Apr 2022 02:06:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd0Ut-0001K2-Cu; Sat, 09 Apr 2022 02:06:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd0Us-0003RP-UR; Sat, 09 Apr 2022 02:06:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nd0Us-0007Ca-Qh; Sat, 09 Apr 2022 02:06:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OID8S6KntrD2IDDZ7XiAnLA7J4qL/vGnq5QKfr/rM10=; b=RJcg5TK/XlTk2bS6edKFc7I2DI
	ML7kaGZWuER9sLqzSvpo33fysVWErvMTjj6oMDobaI6etcnRO+I+lFqx4ZaIjk7LpAqgYS5ucVuNd
	+xIJHh5d4RtDOhbt8l5pFWZSdpWAZxQFzDEeuu5Ly/JcMJn0wM6Y+uaRpAlzesx0VeCc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169238-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 169238: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:build-arm64:xen-build:fail:regression
    xen-4.16-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.16-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b953760d0b564478e232e7e64823d2a1506e92b5
X-Osstest-Versions-That:
    xen=2c026fe1f159494b3ec05f19ddfb3d39ff901296
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 02:06:42 +0000

flight 169238 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169238/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 169194
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 169194

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169194
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169194
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169194
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169194
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169194
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169194
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169194
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169194
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169194
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169194
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169194
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169194
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  b953760d0b564478e232e7e64823d2a1506e92b5
baseline version:
 xen                  2c026fe1f159494b3ec05f19ddfb3d39ff901296

Last test of basis   169194  2022-04-06 08:39:21 Z    2 days
Testing same since   169238  2022-04-08 13:07:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  fail    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit b953760d0b564478e232e7e64823d2a1506e92b5
Author: Roger Pau Monné <roger.pau@citrix.com>
Date:   Fri Apr 8 14:59:27 2022 +0200

    livepatch: avoid relocations referencing ignored section symbols
    
    Track whether symbols belong to ignored sections in order to avoid
    applying relocations referencing those symbols. The address of such
    symbols won't be resolved and thus the relocation will likely fail or
    write garbage to the destination.
    
    Return an error in that case, as leaving unresolved relocations would
    lead to malfunctioning payload code.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Tested-by: Bjoern Doebel <doebel@amazon.de>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
    master commit: 9120b5737f517fe9d2a3936c38d3a2211630323b
    master date: 2022-04-08 10:27:11 +0200

commit 46d80ba371b20a5201b7168a4fee924ba3f80303
Author: Roger Pau Monné <roger.pau@citrix.com>
Date:   Fri Apr 8 14:58:57 2022 +0200

    livepatch: do not ignore sections with 0 size
    
    A side effect of ignoring such sections is that symbols belonging to
    them won't be resolved, and that could make relocations belonging to
    other sections that reference those symbols fail.
    
    For example it's likely to have an empty .altinstr_replacement with
    symbols pointing to it, and marking the section as ignored will
    prevent the symbols from being resolved, which in turn will cause any
    relocations against them to fail.
    
    In order to solve this do not ignore sections with 0 size, only ignore
    sections that don't have the SHF_ALLOC flag set.
    
    Special case such empty sections in move_payload so they are not taken
    into account in order to decide whether a livepatch can be safely
    re-applied after a revert.
    
    Fixes: 98b728a7b2 ('livepatch: Disallow applying after an revert')
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Tested-by: Bjoern Doebel <doebel@amazon.de>
    Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
    master commit: 0dc1f929e8fed681dec09ca3ea8de38202d5bf30
    master date: 2022-04-08 10:24:10 +0200

commit 44aae670cc28e0533cd893da408878c80a579876
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Apr 8 14:58:25 2022 +0200

    vPCI: fix MSI-X PBA read/write gprintk()s
    
    %pp wants the address of an SBDF, not that of a PCI device.
    
    Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    master commit: d3f61beea4255e2d86ae82303384c57a3262435e
    master date: 2022-04-07 18:01:24 +0200

commit 5a4935bff50d51cf26a4ae2a1c08663e853e47dc
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Fri Apr 8 14:57:54 2022 +0200

    x86/cpuid: Clobber CPUID leaves 0x800000{1d..20} in policies
    
    c/s 1a914256dca5 increased the AMD max leaf from 0x8000001c to 0x80000021, but
    did not adjust anything in the calculate_*_policy() chain.  As a result, on
    hardware supporting these leaves, we read the real hardware values into the
    raw policy, then copy into host, and all the way into the PV/HVM default
    policies.
    
    All 4 of these leaves have enable bits (first two by TopoExt, next by SEV,
    next by PQOS), so any software following the rules is fine and will leave them
    alone.  However, leaf 0x8000001d takes a subleaf input and at least two
    userspace utilities have been observed to loop indefinitely under Xen (clearly
    waiting for eax to report "no more cache levels").
    
    Such userspace is buggy, but Xen's behaviour isn't great either.
    
    In the short term, clobber all information in these leaves.  This is a giant
    bodge, but there are complexities with implementing all of these leaves
    properly.
    
    Fixes: 1a914256dca5 ("x86/cpuid: support LFENCE always serialising CPUID bit")
    Link: https://github.com/QubesOS/qubes-issues/issues/7392
    Reported-by: fosslinux <fosslinux@aussies.space>
    Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>
    master commit: d4012d50082c2eae2f3cbe7770be13b9227fbc3f
    master date: 2022-04-07 11:36:45 +0100

commit eedc5acfb32ec35c38e9b5fcaa3d28d8b0971855
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Apr 8 14:57:25 2022 +0200

    VT-d: avoid infinite recursion on domain_context_mapping_one() error path
    
    Despite the comment there infinite recursion was still possible, by
    flip-flopping between two domains. This is because prev_dom is derived
    from the DID found in the context entry, which was already updated by
    the time error recovery is invoked. Simply introduce yet another mode
    flag to prevent rolling back an in-progress roll-back of a prior
    mapping attempt.
    
    Also drop the existing recursion prevention for having been dead anyway:
    Earlier in the function we already bail when prev_dom == domain.
    
    Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    master commit: 99d829dba1390b98a3ca07b365713e62182ee7ca
    master date: 2022-04-07 12:31:16 +0200

commit 0497023ae57649a23cde211dd022522724f993b6
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Apr 8 14:56:54 2022 +0200

    VT-d: avoid NULL deref on domain_context_mapping_one() error paths
    
    First there's a printk() which actually wrongly uses pdev in the first
    place: We want to log the coordinates of the (perhaps fake) device
    acted upon, which may not be pdev.
    
    Then it was quite pointless for eb19326a328d ("VT-d: prepare for per-
    device quarantine page tables (part I)") to add a domid_t parameter to
    domain_context_unmap_one(): It's only used to pass back here via
    me_wifi_quirk() -> map_me_phantom_function(). Drop the parameter again.
    
    Finally there's the invocation of domain_context_mapping_one(), which
    needs to be passed the correct domain ID. Avoid taking that path when
    pdev is NULL and the quarantine state is what would need restoring to.
    This means we can't security-support non-PCI-Express devices with RMRRs
    (if such exist in practice) any longer; note that as of trhe 1st of the
    two commits referenced below assigning them to DomU-s is unsupported
    anyway.
    
    Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
    Fixes: 14dd241aad8a ("IOMMU/x86: use per-device page tables for quarantining")
    Coverity ID: 1503784
    Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    master commit: 608394b906e71587f02e6662597bc985bad33a5a
    master date: 2022-04-07 12:30:19 +0200

commit ab6f4a11629bd06b860c036f8ec604f7cd9fba68
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Apr 8 14:55:55 2022 +0200

    VT-d: don't needlessly look up DID
    
    If get_iommu_domid() in domain_context_unmap_one() fails, we better
    wouldn't clear the context entry in the first place, as we're then unable
    to issue the corresponding flush. However, we have no need to look up the
    DID in the first place: What needs flushing is very specifically the DID
    that was in the context entry before our clearing of it.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    master commit: 445ab9852d69d8957467f0036098ebec75fec092
    master date: 2022-04-07 12:29:03 +0200
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301889.515325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34B-00082x-9r; Sat, 09 Apr 2022 04:51:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301889.515325; Sat, 09 Apr 2022 04:51:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34B-00082o-6A; Sat, 09 Apr 2022 04:51:19 +0000
Received: by outflank-mailman (input) for mailman id 301889;
 Sat, 09 Apr 2022 04:51:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34A-0006gF-QB
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:18 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b0e44c40-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:51:18 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd33w-0020Yw-4P; Sat, 09 Apr 2022 04:51:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0e44c40-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=o0hivJC1zBmf2OLswEv2WeM9LwYiU39b8DIC3mFzVkc=; b=3F4Gy8p9Tvq+5pylL46uvOJn7h
	o2XZpRogXFQL3VJFZPE+ZZDtjrf9Pc2OTl5fZtGSYd57hTdFlYXIdIHOqaBXa/gwwIgNeTwpzh8E1
	QxRCn+KG2Muq11G9sBZPqcFJsQdF+RO1A1/vOYvAkvrZpiLwvpNlQupw5qXMvPBGR692SLA9Gc4O9
	+WQuMA5xQqJyH9AX6svLk38kVSqqX8kZssANUh1VF1n2HxXeQbt2B929yqhRSjrF5mSUtQQl9u3kF
	pbbIDtUGIe8ib42MP8DoNYMKEID8G4oja6vJ3M+Cjui+ZmorwUZF4pyM0UDyDdlGBMS8H8gcMK1Fa
	XnV5hFlQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>
Subject: [PATCH 05/27] drbd: use bdev based limit helpers in drbd_send_sizes
Date: Sat,  9 Apr 2022 06:50:21 +0200
Message-Id: <20220409045043.23593-6-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based limits helpers where they exist.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
 drivers/block/drbd/drbd_main.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 1262fe1c33618..aa2c21aeb747c 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -924,7 +924,9 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 
 	memset(p, 0, packet_size);
 	if (get_ldev_if_state(device, D_NEGOTIATING)) {
-		struct request_queue *q = bdev_get_queue(device->ldev->backing_bdev);
+		struct block_device *bdev = device->ldev->backing_bdev;
+		struct request_queue *q = bdev_get_queue(bdev);
+
 		d_size = drbd_get_max_capacity(device->ldev);
 		rcu_read_lock();
 		u_size = rcu_dereference(device->ldev->disk_conf)->disk_size;
@@ -933,13 +935,13 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		max_bio_size = queue_max_hw_sectors(q) << 9;
 		max_bio_size = min(max_bio_size, DRBD_MAX_BIO_SIZE);
 		p->qlim->physical_block_size =
-			cpu_to_be32(queue_physical_block_size(q));
+			cpu_to_be32(bdev_physical_block_size(bdev));
 		p->qlim->logical_block_size =
-			cpu_to_be32(queue_logical_block_size(q));
+			cpu_to_be32(bdev_logical_block_size(bdev));
 		p->qlim->alignment_offset =
 			cpu_to_be32(queue_alignment_offset(q));
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
+		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
 		p->qlim->discard_enabled = blk_queue_discard(q);
 		put_ldev(device);
 	} else {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301888.515315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd348-0007iI-RL; Sat, 09 Apr 2022 04:51:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301888.515315; Sat, 09 Apr 2022 04:51:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd348-0007iB-NL; Sat, 09 Apr 2022 04:51:16 +0000
Received: by outflank-mailman (input) for mailman id 301888;
 Sat, 09 Apr 2022 04:51:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd346-0006gL-KO
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:14 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id adcdccc6-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:13 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd33s-0020WM-ET; Sat, 09 Apr 2022 04:51:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adcdccc6-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=p7OacHYZtXHcRJcUjaO4g7N75FFwuFvyGKpz8CHLs7c=; b=Pzju2TytWziYGXeAIXOJqaZe7f
	7ZGvsguzecelJ4kpYHFs039peENwElmJJQkOSiGYs68Q+CTFipoeD0GlcVPwvTxb8xwBmaIekN2yU
	Rk4beWtSim6D708e6fSlV3YP5i7sNLfobnz5N1LWmB0773OmCuKgM8hPrOj00tHgKXSL2WCPSypp8
	ErKpc93xT55Q9MUWv2vmwsuaSUJfwgL8pm1UrjQ6JfcKYWVBii/A8RoyrVNpZCMb2NMWyLhn7ceWa
	xkvvl8VwB4N0A1xPbH8PCB21WFupHylrzncwQJ8sn/dqS6wML090d9Ks8PME8EXpA5KlHBwNJY9Qk
	zEahGH1Q==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 04/27] drbd: remove assign_p_sizes_qlim
Date: Sat,  9 Apr 2022 06:50:20 +0200
Message-Id: <20220409045043.23593-5-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Fold each branch into its only caller.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_main.c | 47 +++++++++++++++-------------------
 1 file changed, 20 insertions(+), 27 deletions(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 9676a1d214bc5..1262fe1c33618 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -903,31 +903,6 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device)
 	}
 }
 
-/* communicated if (agreed_features & DRBD_FF_WSAME) */
-static void
-assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p,
-					struct request_queue *q)
-{
-	if (q) {
-		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));
-		p->qlim->logical_block_size = cpu_to_be32(queue_logical_block_size(q));
-		p->qlim->alignment_offset = cpu_to_be32(queue_alignment_offset(q));
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
-		p->qlim->discard_enabled = blk_queue_discard(q);
-		p->qlim->write_same_capable = 0;
-	} else {
-		q = device->rq_queue;
-		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));
-		p->qlim->logical_block_size = cpu_to_be32(queue_logical_block_size(q));
-		p->qlim->alignment_offset = 0;
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
-		p->qlim->discard_enabled = 0;
-		p->qlim->write_same_capable = 0;
-	}
-}
-
 int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enum dds_flags flags)
 {
 	struct drbd_device *device = peer_device->device;
@@ -957,14 +932,32 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		q_order_type = drbd_queue_order_type(device);
 		max_bio_size = queue_max_hw_sectors(q) << 9;
 		max_bio_size = min(max_bio_size, DRBD_MAX_BIO_SIZE);
-		assign_p_sizes_qlim(device, p, q);
+		p->qlim->physical_block_size =
+			cpu_to_be32(queue_physical_block_size(q));
+		p->qlim->logical_block_size =
+			cpu_to_be32(queue_logical_block_size(q));
+		p->qlim->alignment_offset =
+			cpu_to_be32(queue_alignment_offset(q));
+		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
+		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->discard_enabled = blk_queue_discard(q);
 		put_ldev(device);
 	} else {
+		struct request_queue *q = device->rq_queue;
+
+		p->qlim->physical_block_size =
+			cpu_to_be32(queue_physical_block_size(q));
+		p->qlim->logical_block_size =
+			cpu_to_be32(queue_logical_block_size(q));
+		p->qlim->alignment_offset = 0;
+		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
+		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->discard_enabled = 0;
+
 		d_size = 0;
 		u_size = 0;
 		q_order_type = QUEUE_ORDERED_NONE;
 		max_bio_size = DRBD_MAX_BIO_SIZE; /* ... multiple BIOs per peer_request */
-		assign_p_sizes_qlim(device, p, NULL);
 	}
 
 	if (peer_device->connection->agreed_pro_version <= 94)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301886.515286 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd346-0006zB-4W; Sat, 09 Apr 2022 04:51:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301886.515286; Sat, 09 Apr 2022 04:51:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd345-0006y9-VY; Sat, 09 Apr 2022 04:51:13 +0000
Received: by outflank-mailman (input) for mailman id 301886;
 Sat, 09 Apr 2022 04:51:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd344-0006gL-Jm
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:12 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a76c8657-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:04 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd33i-0020Rz-3n; Sat, 09 Apr 2022 04:50:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a76c8657-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=UUS6y6SVPRCfJmQVPGCeD5o714qtaTT6EGogPxQdIy8=; b=f8MqUsBATs67rjabQ/6Q/DbIDx
	fgXqbEI8CyICa2zvZugiHMNhsGNdoL78CjqUFo+L85yRWnSp4bLnWw9UOZORPlbxKENuHDE3BMnvC
	nZh6ejqs8UuaxSAp6FEJQyIJYqxldvUdfoiHG+YGtE8JBRDE1ky/o2Z2BT/GFfYVa2U3YknfleDGZ
	YUmnMj5SSobEjQAm6BIb9bH1beFjSOm9lCoP9YbR6kwi/6uzgUKhayh1GCsU3aZjAHXXaEb3quZh4
	j3z6YIhUDIw06+z4r77/ODr1b2fFsOalGXJmTq9WKgX7hgCKnXAOCLs7dqVGI90UT6R50HzlB6hd5
	fgQRzOXw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction
Date: Sat,  9 Apr 2022 06:50:17 +0200
Message-Id: <20220409045043.23593-2-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

For block devices, the SCSI target drivers implements UNMAP as calls to
blkdev_issue_discard, which does not guarantee zeroing just because
Write Zeroes is supported.

Note that this does not affect the file backed path which uses
fallocate to punch holes.

Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/target/target_core_device.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 44bb380e7390c..fa866acef5bb2 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -850,7 +850,6 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
 	attrib->unmap_granularity_alignment = q->limits.discard_alignment /
 								block_size;
-	attrib->unmap_zeroes_data = !!(q->limits.max_write_zeroes_sectors);
 	return true;
 }
 EXPORT_SYMBOL(target_configure_unmap_from_queue);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301885.515282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd345-0006w9-S9; Sat, 09 Apr 2022 04:51:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301885.515282; Sat, 09 Apr 2022 04:51:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd345-0006w2-N7; Sat, 09 Apr 2022 04:51:13 +0000
Received: by outflank-mailman (input) for mailman id 301885;
 Sat, 09 Apr 2022 04:51:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd343-0006gL-R7
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:11 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8965c26-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:04 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd33l-0020TC-Pz; Sat, 09 Apr 2022 04:50:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8965c26-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=6JVZQz23Gg3oLV4oYc05UwmOH+nGeMd1Qpin5+I9KgM=; b=T+9t+qRVixcYOKTh1AUVT25z0M
	+SeVr5+q6XffdW1kFW64UkJe5HiR1JzBYZYydkfDGnhvPDwIWt1BqK0kdRpQlzNS/wUGgV0dz2FlC
	P9lWy4ngvRvWzpwNKC0K2fF5KsKRF9WdU7qIRMHjoHzTM+p/DmxnFS/6hYJwPtf1Atl9jbNqvHRbW
	tlOYlU8ufbWGBydt1bUmPAZA5D8zkMlkbBnkY22C2NT6vnnROSTB46+rpRyEX5lzOjlaPcp8DwJyC
	bbKS1PGTuIP4F/DHMFVbTCV/5B0d0tMWG8vDpg/SA6IBHxSKH9SXtm1xmXyImu30Ag6d2DwUVgBc6
	Y9GfxcxA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 02/27] target: pass a block_device to target_configure_unmap_from_queue
Date: Sat,  9 Apr 2022 06:50:18 +0200
Message-Id: <20220409045043.23593-3-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The SCSI target drivers is a consumer of the block layer and shoul
d generally work on struct block_device.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/target/target_core_device.c  | 5 +++--
 drivers/target/target_core_file.c    | 7 ++++---
 drivers/target/target_core_iblock.c  | 2 +-
 include/target/target_core_backend.h | 4 ++--
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index fa866acef5bb2..3a1ec705cd80b 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -834,9 +834,10 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
  * in ATA and we need to set TPE=1
  */
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
-				       struct request_queue *q)
+				       struct block_device *bdev)
 {
-	int block_size = queue_logical_block_size(q);
+	struct request_queue *q = bdev_get_queue(bdev);
+	int block_size = bdev_logical_block_size(bdev);
 
 	if (!blk_queue_discard(q))
 		return false;
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index 8190b840065f3..8d191fdc33217 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -134,10 +134,11 @@ static int fd_configure_device(struct se_device *dev)
 	 */
 	inode = file->f_mapping->host;
 	if (S_ISBLK(inode->i_mode)) {
-		struct request_queue *q = bdev_get_queue(I_BDEV(inode));
+		struct block_device *bdev = I_BDEV(inode);
+		struct request_queue *q = bdev_get_queue(bdev);
 		unsigned long long dev_size;
 
-		fd_dev->fd_block_size = bdev_logical_block_size(I_BDEV(inode));
+		fd_dev->fd_block_size = bdev_logical_block_size(bdev);
 		/*
 		 * Determine the number of bytes from i_size_read() minus
 		 * one (1) logical sector from underlying struct block_device
@@ -150,7 +151,7 @@ static int fd_configure_device(struct se_device *dev)
 			dev_size, div_u64(dev_size, fd_dev->fd_block_size),
 			fd_dev->fd_block_size);
 
-		if (target_configure_unmap_from_queue(&dev->dev_attrib, q))
+		if (target_configure_unmap_from_queue(&dev->dev_attrib, bdev))
 			pr_debug("IFILE: BLOCK Discard support available,"
 				 " disabled by default\n");
 		/*
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 87ede165ddba4..b886ce1770bfd 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -119,7 +119,7 @@ static int iblock_configure_device(struct se_device *dev)
 	dev->dev_attrib.hw_max_sectors = queue_max_hw_sectors(q);
 	dev->dev_attrib.hw_queue_depth = q->nr_requests;
 
-	if (target_configure_unmap_from_queue(&dev->dev_attrib, q))
+	if (target_configure_unmap_from_queue(&dev->dev_attrib, bd))
 		pr_debug("IBLOCK: BLOCK Discard support available,"
 			 " disabled by default\n");
 
diff --git a/include/target/target_core_backend.h b/include/target/target_core_backend.h
index 675f3a1fe6139..773963a1e0b53 100644
--- a/include/target/target_core_backend.h
+++ b/include/target/target_core_backend.h
@@ -14,7 +14,7 @@
 #define TRANSPORT_FLAG_PASSTHROUGH_ALUA		0x2
 #define TRANSPORT_FLAG_PASSTHROUGH_PGR          0x4
 
-struct request_queue;
+struct block_device;
 struct scatterlist;
 
 struct target_backend_ops {
@@ -117,7 +117,7 @@ sense_reason_t passthrough_parse_cdb(struct se_cmd *cmd,
 bool target_sense_desc_format(struct se_device *dev);
 sector_t target_to_linux_sector(struct se_device *dev, sector_t lb);
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
-				       struct request_queue *q);
+				       struct block_device *bdev);
 
 static inline bool target_dev_configured(struct se_device *se_dev)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301884.515271 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd344-0006gY-K4; Sat, 09 Apr 2022 04:51:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301884.515271; Sat, 09 Apr 2022 04:51:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd344-0006gR-Fu; Sat, 09 Apr 2022 04:51:12 +0000
Received: by outflank-mailman (input) for mailman id 301884;
 Sat, 09 Apr 2022 04:51:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd342-0006gF-Mx
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:11 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a6481986-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:51:02 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd33f-0020RM-19; Sat, 09 Apr 2022 04:50:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6481986-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=xqCE7mrNhx9Kh54A8pTQxucRKOOrbbHmaHFew3/JwbI=; b=eautlETAmAcOF4Rx+ajcsxqxAt
	K/gc85CxDlYY+s5RX+TP4qAcopFOJMKyRoUbJGCZqLzThYN44a81gHztvDtTQOXXVmstC/BiZza91
	+tK8A4YQHg+wud7jKaqcpT5eZw97ewGrhmTU8yf0v/D+yZnMWYW/4nRrMz5fe0RjHIwwo6UCcWnmG
	q/WhOest1iceY98x52QbO+Ryd19aUS/0aFt0A0VdCFkKu7+7IrcjV/rCpnun6L4B6SbhX7D4hKxqE
	vkbaC7lWGA+28JjJD9laatsN4l8Gz9BZIOD3BKi8HF53h/Wb9nBnpD0TIdhkMhGAybm9Za6sdmIlK
	tpLM1eWg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: use block_device based APIs in block layer consumers v2
Date: Sat,  9 Apr 2022 06:50:16 +0200
Message-Id: <20220409045043.23593-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Hi Jens,

this series cleanups up the block layer API so that APIs consumed
by file systems are (almost) only struct block_devic based, so that
file systems don't have to poke into block layer internals like the
request_queue.

I also found a bunch of existing bugs related to partition offsets
and discard so these are fixed while going along.


Changes since v1:
 - fix a bisection hazard
 - minor spelling fixes
 - reorder hunks between two patches to make the changes more obvious
 - reorder a patch to be earlier in the series to ease backporting


Diffstat:
 arch/um/drivers/ubd_kern.c           |    2 
 block/blk-core.c                     |    4 -
 block/blk-lib.c                      |  124 ++++++++++++++++++++---------------
 block/blk-mq-debugfs.c               |    2 
 block/blk-settings.c                 |   74 ++++++++++++++++++++
 block/blk.h                          |   14 ---
 block/fops.c                         |    2 
 block/genhd.c                        |    4 -
 block/ioctl.c                        |   48 ++++++++++---
 block/partitions/core.c              |   12 ---
 drivers/block/drbd/drbd_main.c       |   51 ++++++--------
 drivers/block/drbd/drbd_nl.c         |   94 +++++++++++---------------
 drivers/block/drbd/drbd_receiver.c   |   13 +--
 drivers/block/loop.c                 |   15 +---
 drivers/block/nbd.c                  |    5 -
 drivers/block/null_blk/main.c        |    1 
 drivers/block/rbd.c                  |    1 
 drivers/block/rnbd/rnbd-clt.c        |    6 -
 drivers/block/rnbd/rnbd-srv-dev.h    |    8 --
 drivers/block/rnbd/rnbd-srv.c        |    5 -
 drivers/block/virtio_blk.c           |    2 
 drivers/block/xen-blkback/blkback.c  |   15 ++--
 drivers/block/xen-blkback/xenbus.c   |    9 --
 drivers/block/xen-blkfront.c         |    7 -
 drivers/block/zram/zram_drv.c        |    1 
 drivers/md/bcache/alloc.c            |    2 
 drivers/md/bcache/request.c          |    4 -
 drivers/md/bcache/super.c            |    3 
 drivers/md/bcache/sysfs.c            |    2 
 drivers/md/dm-cache-target.c         |    9 --
 drivers/md/dm-clone-target.c         |    9 --
 drivers/md/dm-io.c                   |    2 
 drivers/md/dm-log-writes.c           |    3 
 drivers/md/dm-raid.c                 |    9 --
 drivers/md/dm-table.c                |   25 +------
 drivers/md/dm-thin.c                 |   15 ----
 drivers/md/dm.c                      |    3 
 drivers/md/md-linear.c               |   11 ---
 drivers/md/md.c                      |    5 -
 drivers/md/raid0.c                   |    7 -
 drivers/md/raid1.c                   |   18 -----
 drivers/md/raid10.c                  |   20 -----
 drivers/md/raid5-cache.c             |    8 +-
 drivers/md/raid5.c                   |   14 +--
 drivers/mmc/core/queue.c             |    3 
 drivers/mtd/mtd_blkdevs.c            |    1 
 drivers/nvme/host/core.c             |    6 -
 drivers/nvme/target/io-cmd-bdev.c    |    2 
 drivers/nvme/target/zns.c            |    3 
 drivers/s390/block/dasd_fba.c        |    1 
 drivers/scsi/sd.c                    |    2 
 drivers/target/target_core_device.c  |   20 ++---
 drivers/target/target_core_file.c    |   10 +-
 drivers/target/target_core_iblock.c  |   17 +---
 fs/btrfs/disk-io.c                   |    3 
 fs/btrfs/extent-tree.c               |    8 +-
 fs/btrfs/ioctl.c                     |   12 +--
 fs/btrfs/volumes.c                   |    4 -
 fs/btrfs/zoned.c                     |    3 
 fs/direct-io.c                       |   32 +--------
 fs/exfat/file.c                      |    5 -
 fs/exfat/super.c                     |   10 --
 fs/ext4/ioctl.c                      |   10 --
 fs/ext4/mballoc.c                    |   10 +-
 fs/ext4/super.c                      |   10 --
 fs/f2fs/f2fs.h                       |    3 
 fs/f2fs/file.c                       |   19 ++---
 fs/f2fs/segment.c                    |    8 --
 fs/fat/file.c                        |    5 -
 fs/fat/inode.c                       |   10 --
 fs/gfs2/rgrp.c                       |    7 -
 fs/iomap/direct-io.c                 |    3 
 fs/jbd2/journal.c                    |    9 --
 fs/jfs/ioctl.c                       |    5 -
 fs/jfs/super.c                       |    8 --
 fs/nilfs2/ioctl.c                    |    6 -
 fs/nilfs2/sufile.c                   |    4 -
 fs/nilfs2/the_nilfs.c                |    4 -
 fs/ntfs3/file.c                      |    6 -
 fs/ntfs3/super.c                     |   10 +-
 fs/ocfs2/ioctl.c                     |    5 -
 fs/super.c                           |    2 
 fs/xfs/xfs_discard.c                 |    8 +-
 fs/xfs/xfs_log_cil.c                 |    2 
 fs/xfs/xfs_super.c                   |   12 +--
 fs/zonefs/super.c                    |    3 
 include/linux/blkdev.h               |  112 +++++++++++--------------------
 include/target/target_core_backend.h |    4 -
 mm/swapfile.c                        |   31 ++------
 89 files changed, 493 insertions(+), 653 deletions(-)


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301887.515292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd346-00078M-HK; Sat, 09 Apr 2022 04:51:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301887.515292; Sat, 09 Apr 2022 04:51:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd346-00075m-Cb; Sat, 09 Apr 2022 04:51:14 +0000
Received: by outflank-mailman (input) for mailman id 301887;
 Sat, 09 Apr 2022 04:51:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd345-0006gL-K3
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:13 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab93d985-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:09 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd33p-0020Uf-5Z; Sat, 09 Apr 2022 04:50:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab93d985-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=OTIsP1OizukmDhxFkiULvJk6rKtH8rZ66Toc2zFZ06c=; b=UPj32NEZSs0CZXU66K8zWiAfa1
	xZi9mNnXgP+xDQL0eZfIz641yrgwphIK2vKHJq+DoAtDvElmNRgDbJUWiJ8LyL9xqUM2UWFY7Qyui
	tvbHWEmImnVRF7P5yMfrv6iT3Cq0iPs429cZILRmpjqQ1A5wLRB6v5agc1vr3+sykUaLRIBEx/Esx
	+L2whSVV5Udt9aHJm3N6VtcagVQ4jfmDqHnMwZyb9ChnAcwzA/ZypVRwhIc2odkVgg/54WmJlHYVp
	s6rib0l0pjoJtsNxoS/ADbx9+kWTDEWWDVpseZqy/qnwy7fqLCYKD3ouvwlL9wYpZg4OadMvweV7k
	BfVKIhsg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 03/27] target: fix discard alignment on partitions
Date: Sat,  9 Apr 2022 06:50:19 +0200
Message-Id: <20220409045043.23593-4-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the proper bdev_discard_alignment helper that accounts for partition
offsets.

Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/target/target_core_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 3a1ec705cd80b..16e775bcf4a7c 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -849,8 +849,8 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	 */
 	attrib->max_unmap_block_desc_count = 1;
 	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
-	attrib->unmap_granularity_alignment = q->limits.discard_alignment /
-								block_size;
+	attrib->unmap_granularity_alignment =
+		bdev_discard_alignment(bdev) / block_size;
 	return true;
 }
 EXPORT_SYMBOL(target_configure_unmap_from_queue);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301890.515336 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34F-0008SG-OT; Sat, 09 Apr 2022 04:51:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301890.515336; Sat, 09 Apr 2022 04:51:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34F-0008S7-KH; Sat, 09 Apr 2022 04:51:23 +0000
Received: by outflank-mailman (input) for mailman id 301890;
 Sat, 09 Apr 2022 04:51:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34E-0006gL-Cd
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:22 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b31ed9c4-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:21 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd33z-0020bF-0B; Sat, 09 Apr 2022 04:51:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b31ed9c4-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=mSb0+dwzgM6VKYFxP/SxijH+ZlgC/mCnwmCWElH9Px8=; b=GeHiEC33kqU3XVD5nL4JSSzw9j
	UuYbGyM2BXXR+stmsdf5DjhZy4DmQUWQMFN0vSfrL8aUhBe+6Ofrgbj+Dbx5uxEAqYOBhWREkppXD
	kdRzxDavbe8DbbMc6qyOhN2cA6i5obcc9Wc+hP+sVKryA1uBRUfBVDOlYnio24jRKSkCpFo+tSiXl
	6u0gF+2q2d7oaysxI+ClBO5UEjKSEG5mJBDObnDrEZKJSMP7hUVOwIlO/C7MDHMssw01IKDI4CTXp
	PRCDWE+Bw8zXMLtTw0QbfZSkAUMsYs8Kzz9wpJlJkYu9q6ou7iULbQ0RWrchfFLVlYlgnHKpBsjXJ
	gpZHWQ4w==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>
Subject: [PATCH 06/27] drbd: use bdev_alignment_offset instead of queue_alignment_offset
Date: Sat,  9 Apr 2022 06:50:22 +0200
Message-Id: <20220409045043.23593-7-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The bdev version does the right thing for partitions, so use that.

Fixes: 9104d31a759f ("drbd: introduce WRITE_SAME support")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
 drivers/block/drbd/drbd_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index aa2c21aeb747c..eae629c4f6eaf 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -939,7 +939,7 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		p->qlim->logical_block_size =
 			cpu_to_be32(bdev_logical_block_size(bdev));
 		p->qlim->alignment_offset =
-			cpu_to_be32(queue_alignment_offset(q));
+			cpu_to_be32(bdev_alignment_offset(bdev));
 		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
 		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
 		p->qlim->discard_enabled = blk_queue_discard(q);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301892.515348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34I-0000NO-68; Sat, 09 Apr 2022 04:51:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301892.515348; Sat, 09 Apr 2022 04:51:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34I-0000N6-1a; Sat, 09 Apr 2022 04:51:26 +0000
Received: by outflank-mailman (input) for mailman id 301892;
 Sat, 09 Apr 2022 04:51:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34G-0006gL-EZ
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:24 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b43699ff-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:23 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd341-0020d9-Mx; Sat, 09 Apr 2022 04:51:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b43699ff-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=fe1mhxHvUNcHX31X2/v6QhlWCpL7rHNmKlyfX6pAQx8=; b=Ln3yxSObowNxJM1FMrhr+K57R6
	b4hm67oQXj8QHYSsDtTeswkmQMzhTUbmcFXZ8wSKANWZ3f2uawh1SArLLQwyfG/9xFBJpY85CXdw2
	ds/PrbeW2qhvBxLbQUlZJnupwwXSwTpD5oVVdXoHNH+XQIFpfq6JutVFrQurNrlSwXfXPm8nAVF8g
	3O6uBqOGhFXMyQobgkP5h+IgaBO6+coY7mEesusFLc5Uf97qVgiCBrdqIzpOVhA93gJW7XwjtIRj9
	o9pUqGiB3fZ23DPiIOWZiMJonzuJNE4ezkBUWAzOu6pd1udnLd7cjlnkVEEt0MQfIsCBUce9aPyz9
	Bxbzzdhw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>
Subject: [PATCH 07/27] drbd: cleanup decide_on_discard_support
Date: Sat,  9 Apr 2022 06:50:23 +0200
Message-Id: <20220409045043.23593-8-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Sanitize the calling conventions and use a goto label to cleanup the
code flow.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
 drivers/block/drbd/drbd_nl.c | 68 +++++++++++++++++++-----------------
 1 file changed, 35 insertions(+), 33 deletions(-)

diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 02030c9c4d3b1..40bb0b356a6d6 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1204,38 +1204,42 @@ static unsigned int drbd_max_discard_sectors(struct drbd_connection *connection)
 }
 
 static void decide_on_discard_support(struct drbd_device *device,
-			struct request_queue *q,
-			struct request_queue *b,
-			bool discard_zeroes_if_aligned)
+		struct drbd_backing_dev *bdev)
 {
-	/* q = drbd device queue (device->rq_queue)
-	 * b = backing device queue (device->ldev->backing_bdev->bd_disk->queue),
-	 *     or NULL if diskless
-	 */
-	struct drbd_connection *connection = first_peer_device(device)->connection;
-	bool can_do = b ? blk_queue_discard(b) : true;
-
-	if (can_do && connection->cstate >= C_CONNECTED && !(connection->agreed_features & DRBD_FF_TRIM)) {
-		can_do = false;
-		drbd_info(connection, "peer DRBD too old, does not support TRIM: disabling discards\n");
-	}
-	if (can_do) {
-		/* We don't care for the granularity, really.
-		 * Stacking limits below should fix it for the local
-		 * device.  Whether or not it is a suitable granularity
-		 * on the remote device is not our problem, really. If
-		 * you care, you need to use devices with similar
-		 * topology on all peers. */
-		blk_queue_discard_granularity(q, 512);
-		q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
-		q->limits.max_write_zeroes_sectors = drbd_max_discard_sectors(connection);
-	} else {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
-		blk_queue_discard_granularity(q, 0);
-		q->limits.max_discard_sectors = 0;
-		q->limits.max_write_zeroes_sectors = 0;
+	struct drbd_connection *connection =
+		first_peer_device(device)->connection;
+	struct request_queue *q = device->rq_queue;
+
+	if (bdev && !blk_queue_discard(bdev->backing_bdev->bd_disk->queue))
+		goto not_supported;
+
+	if (connection->cstate >= C_CONNECTED &&
+	    !(connection->agreed_features & DRBD_FF_TRIM)) {
+		drbd_info(connection,
+			"peer DRBD too old, does not support TRIM: disabling discards\n");
+		goto not_supported;
 	}
+
+	/*
+	 * We don't care for the granularity, really.
+	 *
+	 * Stacking limits below should fix it for the local device.  Whether or
+	 * not it is a suitable granularity on the remote device is not our
+	 * problem, really. If you care, you need to use devices with similar
+	 * topology on all peers.
+	 */
+	blk_queue_discard_granularity(q, 512);
+	q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
+	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
+	q->limits.max_write_zeroes_sectors =
+		drbd_max_discard_sectors(connection);
+	return;
+
+not_supported:
+	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
+	blk_queue_discard_granularity(q, 0);
+	q->limits.max_discard_sectors = 0;
+	q->limits.max_write_zeroes_sectors = 0;
 }
 
 static void fixup_discard_if_not_supported(struct request_queue *q)
@@ -1273,7 +1277,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 	unsigned int max_segments = 0;
 	struct request_queue *b = NULL;
 	struct disk_conf *dc;
-	bool discard_zeroes_if_aligned = true;
 
 	if (bdev) {
 		b = bdev->backing_bdev->bd_disk->queue;
@@ -1282,7 +1285,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 		rcu_read_lock();
 		dc = rcu_dereference(device->ldev->disk_conf);
 		max_segments = dc->max_bio_bvecs;
-		discard_zeroes_if_aligned = dc->discard_zeroes_if_aligned;
 		rcu_read_unlock();
 
 		blk_set_stacking_limits(&q->limits);
@@ -1292,7 +1294,7 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 	/* This is the workaround for "bio would need to, but cannot, be split" */
 	blk_queue_max_segments(q, max_segments ? max_segments : BLK_MAX_SEGMENTS);
 	blk_queue_segment_boundary(q, PAGE_SIZE-1);
-	decide_on_discard_support(device, q, b, discard_zeroes_if_aligned);
+	decide_on_discard_support(device, bdev);
 
 	if (b) {
 		blk_stack_limits(&q->limits, &b->limits, 0);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301896.515369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34M-00018y-5k; Sat, 09 Apr 2022 04:51:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301896.515369; Sat, 09 Apr 2022 04:51:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34M-00018e-0m; Sat, 09 Apr 2022 04:51:30 +0000
Received: by outflank-mailman (input) for mailman id 301896;
 Sat, 09 Apr 2022 04:51:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34K-0006gL-5B
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:28 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b687bbf3-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:27 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd348-0020i9-Di; Sat, 09 Apr 2022 04:51:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b687bbf3-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=Bh+vV8H1PUD+w/3YWj6wMRz8JdOJ8okMcDjW6Mx/Fiw=; b=DWf7imoDvMSXJTtirA5ltk+rtE
	YeH7NxKahOANJaW3JeWmpEL0KWvrQ+sUioHsm0dQaUs7Tks6Ss/UVOXMhmulR7QEBLriQYI1KEMzQ
	aO9ISV0dwvPZErcNPFhlMeFi6wIDVT8NvUOYYMlUOKdrnhvM68xwDYg36srZ722XpvX8aIcmuYcaD
	sB1HtVb3yxckb8p+8Hs6srY4Fa9xc+Rr/tmxJaQIFCFAy3LRp9g0YB5fD3IXoh+PksnNKd9R9552Q
	DFKI2Il5Y+lOkByKWQ2YD6LETuE64wDq4THU/F5OZAcQu9U4H1sQRvyeZgS12iohkvkHfPdltFjhr
	Z+SPB7CA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 09/27] ntfs3: use bdev_logical_block_size instead of open coding it
Date: Sat,  9 Apr 2022 06:50:25 +0200
Message-Id: <20220409045043.23593-10-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/ntfs3/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 278dcf5024102..cd30e81abbce0 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -920,7 +920,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	}
 
 	/* Parse boot. */
-	err = ntfs_init_from_boot(sb, rq ? queue_logical_block_size(rq) : 512,
+	err = ntfs_init_from_boot(sb, bdev_logical_block_size(bdev),
 				  bdev_nr_bytes(bdev));
 	if (err)
 		goto out;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 04:51:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 04:51:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301893.515353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34I-0000R8-Lg; Sat, 09 Apr 2022 04:51:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301893.515353; Sat, 09 Apr 2022 04:51:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd34I-0000Q8-Et; Sat, 09 Apr 2022 04:51:26 +0000
Received: by outflank-mailman (input) for mailman id 301893;
 Sat, 09 Apr 2022 04:51:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34H-0006gF-Iy
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:25 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b4f05d66-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:51:24 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd345-0020fc-8h; Sat, 09 Apr 2022 04:51:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4f05d66-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=fGcL4rT6o55inYg+xD7k4NQPOksglZvB+PFSEP+xhA8=; b=x49SryV2SEOzb+YKli0UJZwys7
	Znb1rsPTkSfYcHPVo9D6b2U83E7uqw2G98XO8zYfl/hKwrvVhicKgqjDvuZYTEB489P843L//CwDT
	gqCbBf9JUwJ6J0Nu3a/lcC/IfwnnEVdVHN84pWvuhxzJiYH6crHhPnTIzf9dIWY5MLhKlVfzyM0Vq
	bwRuU6hgXkjUYp1qcxu8V6Fo824rSDUIbNTnNROyu48YrBGf3oVsysJ9CQPrqpevcWLNQdLnu2N4C
	4XspCM6we8vYPn8dRLL0TG98f118C88z+RALpryzLlARTzoVN3y6dQTJp4lOBr41BAbVo0sl+miwh
	a6JWWqsQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open coding it
Date: Sat,  9 Apr 2022 06:50:24 +0200
Message-Id: <20220409045043.23593-9-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/btrfs/zoned.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 1b1b310c3c510..f72cad7391a11 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -350,7 +350,6 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
 	struct btrfs_fs_info *fs_info = device->fs_info;
 	struct btrfs_zoned_device_info *zone_info = NULL;
 	struct block_device *bdev = device->bdev;
-	struct request_queue *queue = bdev_get_queue(bdev);
 	unsigned int max_active_zones;
 	unsigned int nactive;
 	sector_t nr_sectors;
@@ -410,7 +409,7 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
 	if (!IS_ALIGNED(nr_sectors, zone_sectors))
 		zone_info->nr_zones++;
 
-	max_active_zones = queue_max_active_zones(queue);
+	max_active_zones = bdev_max_active_zones(bdev);
 	if (max_active_zones && max_active_zones < BTRFS_MIN_ACTIVE_ZONES) {
 		btrfs_err_in_rcu(fs_info,
 "zoned: %s: max active zones %u is too small, need at least %u active zones",
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301924.515393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Co-0005U2-PM; Sat, 09 Apr 2022 05:00:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301924.515393; Sat, 09 Apr 2022 05:00:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Co-0005Ss-HW; Sat, 09 Apr 2022 05:00:14 +0000
Received: by outflank-mailman (input) for mailman id 301924;
 Sat, 09 Apr 2022 05:00:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34y-0006gF-QE
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:08 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce1ec427-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:52:07 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34h-0021HO-HS; Sat, 09 Apr 2022 04:51:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce1ec427-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=J+DlKJplDF1Q+uvJsRC9/x84m39e7OAPqS6lbIf59go=; b=Vg9G4nec7vlw9JzY8ZelhLqst6
	ucW6GkU1kL/cckjMXF2Ml7hSDWPk0eXkPWwiYReqkgU31v2L8/TZCAwJcIAknq29ONqcGwBOqoyy/
	WYEExBpIUNCaVoczlTCCzWmGmVmLb9sdCt2/KpA+J1RiElt3I5LUNJS6TppQaHanfTgucuVfWVEqw
	AMAgeT/+i8cp5mqhw5xpCWTsnxLqKYlbYbpVf9dEsk8jlTsF0YqgExniCnZNX5XEO12khG8E+nclP
	kStumcAwUmqAnzRWuX42XMeJAWn+kUo4gGpuhFKBWVbZUS0Ww7Py5+qQcuSTLhz9CYlA7wF2hyPxg
	ePGLsb7Q==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 19/27] block: remove queue_discard_alignment
Date: Sat,  9 Apr 2022 06:50:35 +0200
Message-Id: <20220409045043.23593-20-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Just use bdev_alignment_offset in disk_discard_alignment_show instead.
That helpers is the same except for an always false branch that doesn't
matter in this slow path.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/genhd.c          | 2 +-
 include/linux/blkdev.h | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index 712031ce19070..36532b9318419 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1019,7 +1019,7 @@ static ssize_t disk_discard_alignment_show(struct device *dev,
 {
 	struct gendisk *disk = dev_to_disk(dev);
 
-	return sprintf(buf, "%d\n", queue_discard_alignment(disk->queue));
+	return sprintf(buf, "%d\n", bdev_alignment_offset(disk->part0));
 }
 
 static ssize_t diskseq_show(struct device *dev,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 0a1795ac26275..5a9b7aeda010b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1253,14 +1253,6 @@ bdev_zone_write_granularity(struct block_device *bdev)
 
 int bdev_alignment_offset(struct block_device *bdev);
 
-static inline int queue_discard_alignment(const struct request_queue *q)
-{
-	if (q->limits.discard_misaligned)
-		return -1;
-
-	return q->limits.discard_alignment;
-}
-
 static inline int queue_limit_discard_alignment(struct queue_limits *lim, sector_t sector)
 {
 	unsigned int alignment, granularity, offset;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301922.515386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Co-0005N4-Du; Sat, 09 Apr 2022 05:00:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301922.515386; Sat, 09 Apr 2022 05:00:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Co-0005MS-8k; Sat, 09 Apr 2022 05:00:14 +0000
Received: by outflank-mailman (input) for mailman id 301922;
 Sat, 09 Apr 2022 05:00:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34y-0006gL-3d
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:08 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ce23a205-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:52:07 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34e-0021EZ-Bz; Sat, 09 Apr 2022 04:51:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce23a205-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=LA03+v2RMrt5LLwAfTBpcNFXpYhSXKyM/LEXrkZN1Tc=; b=TToQ+IG68ZTma6i9nDz6xx4LYK
	D0aw9uFluTWmoLPN8wS4Tw4ptzJ/n+LwG2AuHxcLmQEWYx1aZe+l+/EUb07HA13ebYd+zXWtHqs00
	wx9o5AAPH2KJPl0+jag4OLclg/JD37wQiqgJHq6T1H6FWx+UFz58+SDkab9YWBuWtwT6h/pIgt6FR
	AzrhjmPB8W4cd/F2sRVPHfKdDw0YBBrQTFPQ9a74BSKEWHHl6H0cqEhdUPbu4a8zWq2vD/QaSCtLv
	QCIx9f2iUsf6SUo5Q4SNMv/t99ukC9ZdAasasKnk54ghRUz188l1onQf3RFgK9e1sPw7Yo1mCiQup
	PdxOz5qQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line
Date: Sat,  9 Apr 2022 06:50:34 +0200
Message-Id: <20220409045043.23593-19-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

No need to inline these fairly larger helpers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/blk-settings.c   | 23 +++++++++++++++++++++++
 include/linux/blkdev.h | 21 +--------------------
 2 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index b83df3d2eebca..94410a13c0dee 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -468,6 +468,16 @@ void blk_queue_io_opt(struct request_queue *q, unsigned int opt)
 }
 EXPORT_SYMBOL(blk_queue_io_opt);
 
+static int queue_limit_alignment_offset(struct queue_limits *lim,
+		sector_t sector)
+{
+	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
+	unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
+		<< SECTOR_SHIFT;
+
+	return (granularity + lim->alignment_offset - alignment) % granularity;
+}
+
 static unsigned int blk_round_down_sectors(unsigned int sectors, unsigned int lbs)
 {
 	sectors = round_down(sectors, lbs >> SECTOR_SHIFT);
@@ -901,3 +911,16 @@ void blk_queue_set_zoned(struct gendisk *disk, enum blk_zoned_model model)
 	}
 }
 EXPORT_SYMBOL_GPL(blk_queue_set_zoned);
+
+int bdev_alignment_offset(struct block_device *bdev)
+{
+	struct request_queue *q = bdev_get_queue(bdev);
+
+	if (q->limits.misaligned)
+		return -1;
+	if (bdev_is_partition(bdev))
+		return queue_limit_alignment_offset(&q->limits,
+				bdev->bd_start_sect);
+	return q->limits.alignment_offset;
+}
+EXPORT_SYMBOL_GPL(bdev_alignment_offset);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index d5346e72e3645..0a1795ac26275 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1251,26 +1251,7 @@ bdev_zone_write_granularity(struct block_device *bdev)
 	return queue_zone_write_granularity(bdev_get_queue(bdev));
 }
 
-static inline int queue_limit_alignment_offset(struct queue_limits *lim, sector_t sector)
-{
-	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
-	unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
-		<< SECTOR_SHIFT;
-
-	return (granularity + lim->alignment_offset - alignment) % granularity;
-}
-
-static inline int bdev_alignment_offset(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	if (q->limits.misaligned)
-		return -1;
-	if (bdev_is_partition(bdev))
-		return queue_limit_alignment_offset(&q->limits,
-				bdev->bd_start_sect);
-	return q->limits.alignment_offset;
-}
+int bdev_alignment_offset(struct block_device *bdev);
 
 static inline int queue_discard_alignment(const struct request_queue *q)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301921.515381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Co-0005Ki-4L; Sat, 09 Apr 2022 05:00:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301921.515381; Sat, 09 Apr 2022 05:00:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Co-0005Kb-1A; Sat, 09 Apr 2022 05:00:14 +0000
Received: by outflank-mailman (input) for mailman id 301921;
 Sat, 09 Apr 2022 05:00:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd35L-0006gL-Md
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:31 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id db2b99aa-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:52:29 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd351-0021Yb-Ag; Sat, 09 Apr 2022 04:52:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db2b99aa-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=E3X6NUmqO/cjQfN4n5BXTr2WVRZ6M72tRrIVLi6Q30s=; b=dN2x6OP9dlhch8rjrCpbttgJ+F
	OwrM1Snw47PT56UEGvwWgmxti7upHZEyxHbuDWKBwjT+qk70bTnmVOcRcIKP2BWXYOIq+BAjXxHHe
	NQXXgoARAJttZjNcyWmTrXnknP5HljsTCYMmiCBUXQl+h4dinmh8pbEF37uFvR0D+0QpZFSn/PaRY
	NSTLgCA0OvIqKYxzVVU6UDEv7jhkaezdiXPBLaeQFxHd9DXawuHALHp6V9clakI1pWSfvOTxU5LQp
	+j45Q42EoThMPTplAKmVMPL7bzMmY7HHOy4nRM2NbLnTPx74TitfWJSadkZ53oYbmgiqqKIbWLW/I
	c326Jvkw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Coly Li <colyli@suse.de>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 23/27] block: add a bdev_max_discard_sectors helper
Date: Sat,  9 Apr 2022 06:50:39 +0200
Message-Id: <20220409045043.23593-24-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to query the number of sectors support per each discard bio
based on the block device and use this helper to stop various places from
poking into the request_queue to see if discard is supported and if so how
much.  This mirrors what is done e.g. for write zeroes as well.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
Acked-by: Coly Li <colyli@suse.de> [bcache]
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 drivers/block/drbd/drbd_nl.c        | 8 +++++---
 drivers/block/drbd/drbd_receiver.c  | 2 +-
 drivers/block/rnbd/rnbd-srv-dev.h   | 3 +--
 drivers/md/dm-io.c                  | 2 +-
 drivers/target/target_core_device.c | 7 +++----
 fs/f2fs/segment.c                   | 6 ++----
 include/linux/blkdev.h              | 5 +++++
 7 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 40bb0b356a6d6..d4dacc329ac2e 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1439,7 +1439,8 @@ static bool write_ordering_changed(struct disk_conf *a, struct disk_conf *b)
 static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *disk_conf,
 			       struct drbd_backing_dev *nbc)
 {
-	struct request_queue * const q = nbc->backing_bdev->bd_disk->queue;
+	struct block_device *bdev = nbc->backing_bdev;
+	struct request_queue *q = bdev->bd_disk->queue;
 
 	if (disk_conf->al_extents < DRBD_AL_EXTENTS_MIN)
 		disk_conf->al_extents = DRBD_AL_EXTENTS_MIN;
@@ -1455,6 +1456,7 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 
 	if (disk_conf->rs_discard_granularity) {
 		int orig_value = disk_conf->rs_discard_granularity;
+		sector_t discard_size = bdev_max_discard_sectors(bdev) << 9;
 		int remainder;
 
 		if (q->limits.discard_granularity > disk_conf->rs_discard_granularity)
@@ -1463,8 +1465,8 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 		remainder = disk_conf->rs_discard_granularity % q->limits.discard_granularity;
 		disk_conf->rs_discard_granularity += remainder;
 
-		if (disk_conf->rs_discard_granularity > q->limits.max_discard_sectors << 9)
-			disk_conf->rs_discard_granularity = q->limits.max_discard_sectors << 9;
+		if (disk_conf->rs_discard_granularity > discard_size)
+			disk_conf->rs_discard_granularity = discard_size;
 
 		if (disk_conf->rs_discard_granularity != orig_value)
 			drbd_info(device, "rs_discard_granularity changed to %d\n",
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 08da922f81d1d..0b4c7de463989 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1524,7 +1524,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 	granularity = max(q->limits.discard_granularity >> 9, 1U);
 	alignment = (bdev_discard_alignment(bdev) >> 9) % granularity;
 
-	max_discard_sectors = min(q->limits.max_discard_sectors, (1U << 22));
+	max_discard_sectors = min(bdev_max_discard_sectors(bdev), (1U << 22));
 	max_discard_sectors -= max_discard_sectors % granularity;
 	if (unlikely(!max_discard_sectors))
 		goto zero_out;
diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index 2c3df02b5e8ec..f82fbb4bbda8e 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -52,8 +52,7 @@ static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
 	if (!blk_queue_discard(bdev_get_queue(dev->bdev)))
 		return 0;
 
-	return blk_queue_get_max_sectors(bdev_get_queue(dev->bdev),
-					 REQ_OP_DISCARD);
+	return bdev_max_discard_sectors(dev->bdev);
 }
 
 static inline int rnbd_dev_get_discard_granularity(const struct rnbd_dev *dev)
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
index 5762366333a27..e4b95eaeec8c7 100644
--- a/drivers/md/dm-io.c
+++ b/drivers/md/dm-io.c
@@ -311,7 +311,7 @@ static void do_region(int op, int op_flags, unsigned region,
 	 * Reject unsupported discard and write same requests.
 	 */
 	if (op == REQ_OP_DISCARD)
-		special_cmd_max_sectors = q->limits.max_discard_sectors;
+		special_cmd_max_sectors = bdev_max_discard_sectors(where->bdev);
 	else if (op == REQ_OP_WRITE_ZEROES)
 		special_cmd_max_sectors = q->limits.max_write_zeroes_sectors;
 	if ((op == REQ_OP_DISCARD || op == REQ_OP_WRITE_ZEROES) &&
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 16e775bcf4a7c..c3e25bac90d59 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -829,9 +829,8 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
 }
 
 /*
- * Check if the underlying struct block_device request_queue supports
- * the QUEUE_FLAG_DISCARD bit for UNMAP/WRITE_SAME in SCSI + TRIM
- * in ATA and we need to set TPE=1
+ * Check if the underlying struct block_device supports discard and if yes
+ * configure the UNMAP parameters.
  */
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 				       struct block_device *bdev)
@@ -843,7 +842,7 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 		return false;
 
 	attrib->max_unmap_lba_count =
-		q->limits.max_discard_sectors >> (ilog2(block_size) - 9);
+		bdev_max_discard_sectors(bdev) >> (ilog2(block_size) - 9);
 	/*
 	 * Currently hardcoded to 1 in Linux/SCSI code..
 	 */
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 22dfeb9915290..71f09adbcba86 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1196,9 +1196,8 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
 						unsigned int *issued)
 {
 	struct block_device *bdev = dc->bdev;
-	struct request_queue *q = bdev_get_queue(bdev);
 	unsigned int max_discard_blocks =
-			SECTOR_TO_BLOCK(q->limits.max_discard_sectors);
+			SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
 	struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
 	struct list_head *wait_list = (dpolicy->type == DPOLICY_FSTRIM) ?
 					&(dcc->fstrim_list) : &(dcc->wait_list);
@@ -1375,9 +1374,8 @@ static void __update_discard_tree_range(struct f2fs_sb_info *sbi,
 	struct discard_cmd *dc;
 	struct discard_info di = {0};
 	struct rb_node **insert_p = NULL, *insert_parent = NULL;
-	struct request_queue *q = bdev_get_queue(bdev);
 	unsigned int max_discard_blocks =
-			SECTOR_TO_BLOCK(q->limits.max_discard_sectors);
+			SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
 	block_t end = lstart + len;
 
 	dc = (struct discard_cmd *)f2fs_lookup_rb_tree_ret(&dcc->root,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 34b1cfd067421..ce16247d3afab 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1254,6 +1254,11 @@ bdev_zone_write_granularity(struct block_device *bdev)
 int bdev_alignment_offset(struct block_device *bdev);
 unsigned int bdev_discard_alignment(struct block_device *bdev);
 
+static inline unsigned int bdev_max_discard_sectors(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.max_discard_sectors;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301928.515414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Cw-0006I0-4g; Sat, 09 Apr 2022 05:00:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301928.515414; Sat, 09 Apr 2022 05:00:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Cw-0006Hq-0v; Sat, 09 Apr 2022 05:00:22 +0000
Received: by outflank-mailman (input) for mailman id 301928;
 Sat, 09 Apr 2022 05:00:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34m-0006gL-8h
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:56 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c6eb2a0b-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:55 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34U-00213P-4I; Sat, 09 Apr 2022 04:51:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6eb2a0b-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=EfN09E7KgfFk5NOTogRSBSf7jTlM22RGe5+0+tCjcRA=; b=t0aAiQOAgYh2xfMXnvLterJAh6
	EsrOU2ANVhJA83bJAg/kUS0kihbC+selaMUlp7jnEi1JX3OTLxh72lWlfgaE8eU78RLO8Gy9T5ODC
	DXAWEXuEQHMseAneboagWBhh9B2fR1FSBtVZj64dvRfuKz7Nu5BpqV4PvqlHtda/o34eSgrHO53ve
	G63mK1qyCrWopUHxcEkJvB1wZJRMW+Ln5pkg0hEttKmUntLJOMDd4Pc2WSw2oow34+WQ73I+SrMDH
	pspOR3Jzv2D4uwcmOaSzyhOpaHWNXDogcxcYxeAfE3yQCJHDRmr3vOgYqDt08xFB0zD2acAHWyCU2
	Jy5+T74A==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 15/27] block: add a bdev_max_zone_append_sectors helper
Date: Sat,  9 Apr 2022 06:50:31 +0200
Message-Id: <20220409045043.23593-16-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the max supported sectors for zone append based on
the block_device instead of having to poke into the block layer internal
request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 drivers/nvme/target/zns.c | 3 +--
 fs/zonefs/super.c         | 3 +--
 include/linux/blkdev.h    | 6 ++++++
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
index e34718b095504..82b61acf7a72b 100644
--- a/drivers/nvme/target/zns.c
+++ b/drivers/nvme/target/zns.c
@@ -34,8 +34,7 @@ static int validate_conv_zones_cb(struct blk_zone *z,
 
 bool nvmet_bdev_zns_enable(struct nvmet_ns *ns)
 {
-	struct request_queue *q = ns->bdev->bd_disk->queue;
-	u8 zasl = nvmet_zasl(queue_max_zone_append_sectors(q));
+	u8 zasl = nvmet_zasl(bdev_max_zone_append_sectors(ns->bdev));
 	struct gendisk *bd_disk = ns->bdev->bd_disk;
 	int ret;
 
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index 3614c7834007d..7a63807b736c4 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -678,13 +678,12 @@ static ssize_t zonefs_file_dio_append(struct kiocb *iocb, struct iov_iter *from)
 	struct inode *inode = file_inode(iocb->ki_filp);
 	struct zonefs_inode_info *zi = ZONEFS_I(inode);
 	struct block_device *bdev = inode->i_sb->s_bdev;
-	unsigned int max;
+	unsigned int max = bdev_max_zone_append_sectors(bdev);
 	struct bio *bio;
 	ssize_t size;
 	int nr_pages;
 	ssize_t ret;
 
-	max = queue_max_zone_append_sectors(bdev_get_queue(bdev));
 	max = ALIGN_DOWN(max << SECTOR_SHIFT, inode->i_sb->s_blocksize);
 	iov_iter_truncate(from, max);
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index a433798c3343e..f8c50b77543eb 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1188,6 +1188,12 @@ static inline unsigned int queue_max_zone_append_sectors(const struct request_qu
 	return min(l->max_zone_append_sectors, l->max_sectors);
 }
 
+static inline unsigned int
+bdev_max_zone_append_sectors(struct block_device *bdev)
+{
+	return queue_max_zone_append_sectors(bdev_get_queue(bdev));
+}
+
 static inline unsigned queue_logical_block_size(const struct request_queue *q)
 {
 	int retval = 512;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301930.515418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Cw-0006ME-HS; Sat, 09 Apr 2022 05:00:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301930.515418; Sat, 09 Apr 2022 05:00:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Cw-0006Lf-At; Sat, 09 Apr 2022 05:00:22 +0000
Received: by outflank-mailman (input) for mailman id 301930;
 Sat, 09 Apr 2022 05:00:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd35H-0006gF-Uu
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:28 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d9c763f2-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:52:27 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34y-0021Vo-16; Sat, 09 Apr 2022 04:52:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9c763f2-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=lTB3LIlofJfzp5KujAOXuh07LxC0Nf6YEWOtuNxxhyY=; b=C0/EZiE5vXySiqiaR4lBvJuEun
	PCkY/ivUhVSq0xZoAuTVkd2q0WdTP70v6IpmHQ/nr8sL06I0WApI6WB4Nc+BbTwxAexvvl3o5Ltp3
	NtnBftYhjSPcpEVgAsuShaR7m9KbWMRIWCDXyDwu8QO3RK/4EmffFxBCB2g7UXEp1y2leacInCz+W
	UTrT+NDk4VRd1AMJLFu+mpvUpIkM7YRkxENQ4fhPoNiM5RKk5R/iGUTs4IdJSAgoOKNJMsH7MttHB
	e3x6X6lyJLvnR+0gfPxkVm1chSgZ4D2Gc+Jlqd61ZtPmRE05FoHvGDrQ/zbOvv7XIwtnu+Jwn9F73
	97nxUNyA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Coly Li <colyli@suse.de>
Subject: [PATCH 22/27] block: refactor discard bio size limiting
Date: Sat,  9 Apr 2022 06:50:38 +0200
Message-Id: <20220409045043.23593-23-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Coly Li <colyli@suse.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 8ccbc6e076369..1fdc1d28e6d60 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301931.515436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Cy-0006tD-RN; Sat, 09 Apr 2022 05:00:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301931.515436; Sat, 09 Apr 2022 05:00:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3Cy-0006sx-N7; Sat, 09 Apr 2022 05:00:24 +0000
Received: by outflank-mailman (input) for mailman id 301931;
 Sat, 09 Apr 2022 05:00:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd359-0006gF-JI
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:19 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d4ebc39c-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:52:18 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34o-0021Oq-Ko; Sat, 09 Apr 2022 04:52:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4ebc39c-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=6r328luNCDNaFOT33dRflffYOj2Ig+snh5CgwFTaxcw=; b=y5la5uK0xpIhSXtbBy/onPBwBU
	FwHrEP+WgCDZWr9RLCmtiWZSBy3JZlP6LxFpLTBM+Nd9/2cM4fDgGet2bc0H2JEDJaYCnGjCubDq2
	Hs9FWJmFBvCUS8AQuenxCnFR0cA41FyTmlSTltbkCVEHfSM9sSnD7oPEGCN8ZX07uJjnHoINaZAsZ
	npSJrgPfthjgK/j1zKU81zTY86HdQv5lyyod3YfTKkYVFRwo/gHNLmU33ucR809tSrrS9oMBFQRBz
	lw/QH9mmRBGuHmyXN8YuW/Z648JV/+xEquH5iy/QTyXSZMkqO0YMVV1cNnL6OuVpWP4hui/t8N1mQ
	LEn+3oVA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 21/27] block: move {bdev,queue_limit}_discard_alignment out of line
Date: Sat,  9 Apr 2022 06:50:37 +0200
Message-Id: <20220409045043.23593-22-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

No need to inline these fairly larger helpers.  Also fix the return value
to be unsigned, just like the field in struct queue_limits.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/blk-settings.c   | 35 +++++++++++++++++++++++++++++++++++
 include/linux/blkdev.h | 34 +---------------------------------
 2 files changed, 36 insertions(+), 33 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index 94410a13c0dee..fd83d674afd0a 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -478,6 +478,30 @@ static int queue_limit_alignment_offset(struct queue_limits *lim,
 	return (granularity + lim->alignment_offset - alignment) % granularity;
 }
 
+static unsigned int queue_limit_discard_alignment(struct queue_limits *lim,
+		sector_t sector)
+{
+	unsigned int alignment, granularity, offset;
+
+	if (!lim->max_discard_sectors)
+		return 0;
+
+	/* Why are these in bytes, not sectors? */
+	alignment = lim->discard_alignment >> SECTOR_SHIFT;
+	granularity = lim->discard_granularity >> SECTOR_SHIFT;
+	if (!granularity)
+		return 0;
+
+	/* Offset of the partition start in 'granularity' sectors */
+	offset = sector_div(sector, granularity);
+
+	/* And why do we do this modulus *again* in blkdev_issue_discard()? */
+	offset = (granularity + alignment - offset) % granularity;
+
+	/* Turn it back into bytes, gaah */
+	return offset << SECTOR_SHIFT;
+}
+
 static unsigned int blk_round_down_sectors(unsigned int sectors, unsigned int lbs)
 {
 	sectors = round_down(sectors, lbs >> SECTOR_SHIFT);
@@ -924,3 +948,14 @@ int bdev_alignment_offset(struct block_device *bdev)
 	return q->limits.alignment_offset;
 }
 EXPORT_SYMBOL_GPL(bdev_alignment_offset);
+
+unsigned int bdev_discard_alignment(struct block_device *bdev)
+{
+	struct request_queue *q = bdev_get_queue(bdev);
+
+	if (bdev_is_partition(bdev))
+		return queue_limit_discard_alignment(&q->limits,
+				bdev->bd_start_sect);
+	return q->limits.discard_alignment;
+}
+EXPORT_SYMBOL_GPL(bdev_discard_alignment);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 5a9b7aeda010b..34b1cfd067421 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1252,39 +1252,7 @@ bdev_zone_write_granularity(struct block_device *bdev)
 }
 
 int bdev_alignment_offset(struct block_device *bdev);
-
-static inline int queue_limit_discard_alignment(struct queue_limits *lim, sector_t sector)
-{
-	unsigned int alignment, granularity, offset;
-
-	if (!lim->max_discard_sectors)
-		return 0;
-
-	/* Why are these in bytes, not sectors? */
-	alignment = lim->discard_alignment >> SECTOR_SHIFT;
-	granularity = lim->discard_granularity >> SECTOR_SHIFT;
-	if (!granularity)
-		return 0;
-
-	/* Offset of the partition start in 'granularity' sectors */
-	offset = sector_div(sector, granularity);
-
-	/* And why do we do this modulus *again* in blkdev_issue_discard()? */
-	offset = (granularity + alignment - offset) % granularity;
-
-	/* Turn it back into bytes, gaah */
-	return offset << SECTOR_SHIFT;
-}
-
-static inline int bdev_discard_alignment(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	if (bdev_is_partition(bdev))
-		return queue_limit_discard_alignment(&q->limits,
-				bdev->bd_start_sect);
-	return q->limits.discard_alignment;
-}
+unsigned int bdev_discard_alignment(struct block_device *bdev);
 
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301939.515447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DB-00089w-Bj; Sat, 09 Apr 2022 05:00:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301939.515447; Sat, 09 Apr 2022 05:00:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DB-00088Y-7O; Sat, 09 Apr 2022 05:00:37 +0000
Received: by outflank-mailman (input) for mailman id 301939;
 Sat, 09 Apr 2022 05:00:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34x-0006gF-Py
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:07 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce07bf43-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:52:07 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34b-0021Bd-D3; Sat, 09 Apr 2022 04:51:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce07bf43-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=q2ranmlO4Nl6vweHnkN5W/lhAXFqjXPKY6W4cI6bGNw=; b=ZwXWqq27tMeyVdjCd9/fIV+62b
	YxoMIWLS5QBW9+N570g/a7MqnPHccUJQp/73S/ehTJ9VEsGu0nZXpLT2GsIb95dlGJnKSkFIT7WNJ
	Q2sY9of4Z8TkC7fc/FklkIOgdhls0Ao3F7MloWBwUhbTcUSp/MjOHIau/ybVaMror8iobGwcOp0AA
	+a4GNDWpu5gRhJyLqGbdZW5DNs6lIAJYj08W7f1olcpdRSmv2+7GaRf1xJ5QApQRYFU40mFosdlZy
	0ALRAEA3rIIwBWnBlj8QEgYL1eIM3It3IcCM+Tc/eC3LmnRLah4kAgVmx2WJTHuXLjilmSIpHNWrZ
	1FnhvyJg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 17/27] block: use bdev_alignment_offset in disk_alignment_offset_show
Date: Sat,  9 Apr 2022 06:50:33 +0200
Message-Id: <20220409045043.23593-18-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

This does the same as the open coded variant except for an extra branch,
and allows to remove queue_alignment_offset entirely.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/genhd.c          | 2 +-
 include/linux/blkdev.h | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index b8b6759d670f0..712031ce19070 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1010,7 +1010,7 @@ static ssize_t disk_alignment_offset_show(struct device *dev,
 {
 	struct gendisk *disk = dev_to_disk(dev);
 
-	return sprintf(buf, "%d\n", queue_alignment_offset(disk->queue));
+	return sprintf(buf, "%d\n", bdev_alignment_offset(disk->part0));
 }
 
 static ssize_t disk_discard_alignment_show(struct device *dev,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f8c50b77543eb..d5346e72e3645 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1251,14 +1251,6 @@ bdev_zone_write_granularity(struct block_device *bdev)
 	return queue_zone_write_granularity(bdev_get_queue(bdev));
 }
 
-static inline int queue_alignment_offset(const struct request_queue *q)
-{
-	if (q->limits.misaligned)
-		return -1;
-
-	return q->limits.alignment_offset;
-}
-
 static inline int queue_limit_alignment_offset(struct queue_limits *lim, sector_t sector)
 {
 	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301940.515452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DB-0008Dx-NP; Sat, 09 Apr 2022 05:00:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301940.515452; Sat, 09 Apr 2022 05:00:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DB-0008Cq-GI; Sat, 09 Apr 2022 05:00:37 +0000
Received: by outflank-mailman (input) for mailman id 301940;
 Sat, 09 Apr 2022 05:00:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34d-0006gL-Th
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:48 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2489b6d-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:47 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34M-0020w4-RN; Sat, 09 Apr 2022 04:51:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2489b6d-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=ZlX6tQSx9Ltba6eWidCjog7i9CmwA2DoDl+4xkJfBJs=; b=t0/VFWQlthrg9ygdtBQvibmrtw
	LuAylodlmYryYYUrMFw+2E7ZI5/Nq3RPLajmI/sJOOANuV/p8y8jXZN9h723Ey9aR6CP5rTxfbRrr
	HuAz3hVO1/AFxLmiM5Wzc1FzjN390iT78tp1sPhD61fljInCDQYIAXixGJQUZcGA9CdOLnoKsm4+1
	+bPP76gPoCLkZnj6nQKNpV2BXZ/SNnWDXNRm9L27BxTM3H51l1sJ/IJZihGZ7lk1wjRXmX+JN2rsw
	fyasqFUEgGEDqBdftLTs06VMMbXb+A4p+dlovB84cg6XaBod0TxhfjVz6byOWHzm9QbWUe2lXWUhy
	7thBMaGA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 13/27] block: add a bdev_fua helper
Date: Sat,  9 Apr 2022 06:50:29 +0200
Message-Id: <20220409045043.23593-14-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the FUA flag based on the block_device instead of
having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/block/rnbd/rnbd-srv.c       | 3 +--
 drivers/target/target_core_iblock.c | 3 +--
 fs/iomap/direct-io.c                | 3 +--
 include/linux/blkdev.h              | 6 +++++-
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index f8cc3c5fecb4b..beaef43a67b9d 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -533,7 +533,6 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 					struct rnbd_srv_sess_dev *sess_dev)
 {
 	struct rnbd_dev *rnbd_dev = sess_dev->rnbd_dev;
-	struct request_queue *q = bdev_get_queue(rnbd_dev->bdev);
 
 	rsp->hdr.type = cpu_to_le16(RNBD_MSG_OPEN_RSP);
 	rsp->device_id =
@@ -560,7 +559,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 	rsp->cache_policy = 0;
 	if (bdev_write_cache(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_WRITEBACK;
-	if (blk_queue_fua(q))
+	if (bdev_fua(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_FUA;
 }
 
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 03013e85ffc03..c4a903b8a47fc 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -727,14 +727,13 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
 
 	if (data_direction == DMA_TO_DEVICE) {
 		struct iblock_dev *ib_dev = IBLOCK_DEV(dev);
-		struct request_queue *q = bdev_get_queue(ib_dev->ibd_bd);
 		/*
 		 * Force writethrough using REQ_FUA if a volatile write cache
 		 * is not enabled, or if initiator set the Force Unit Access bit.
 		 */
 		opf = REQ_OP_WRITE;
 		miter_dir = SG_MITER_TO_SG;
-		if (test_bit(QUEUE_FLAG_FUA, &q->queue_flags)) {
+		if (bdev_fua(ib_dev->ibd_bd)) {
 			if (cmd->se_cmd_flags & SCF_FUA)
 				opf |= REQ_FUA;
 			else if (!bdev_write_cache(ib_dev->ibd_bd))
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index b08f5dc31780d..62da020d02a11 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -265,8 +265,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
 		 * cache flushes on IO completion.
 		 */
 		if (!(iomap->flags & (IOMAP_F_SHARED|IOMAP_F_DIRTY)) &&
-		    (dio->flags & IOMAP_DIO_WRITE_FUA) &&
-		    blk_queue_fua(bdev_get_queue(iomap->bdev)))
+		    (dio->flags & IOMAP_DIO_WRITE_FUA) && bdev_fua(iomap->bdev))
 			use_fua = true;
 	}
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 807a49aa5a27a..075b16d4560e7 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -602,7 +602,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 			     REQ_FAILFAST_DRIVER))
 #define blk_queue_quiesced(q)	test_bit(QUEUE_FLAG_QUIESCED, &(q)->queue_flags)
 #define blk_queue_pm_only(q)	atomic_read(&(q)->pm_only)
-#define blk_queue_fua(q)	test_bit(QUEUE_FLAG_FUA, &(q)->queue_flags)
 #define blk_queue_registered(q)	test_bit(QUEUE_FLAG_REGISTERED, &(q)->queue_flags)
 #define blk_queue_nowait(q)	test_bit(QUEUE_FLAG_NOWAIT, &(q)->queue_flags)
 
@@ -1336,6 +1335,11 @@ static inline bool bdev_write_cache(struct block_device *bdev)
 	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
 }
 
+static inline bool bdev_fua(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_FUA, &bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301941.515455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DC-0008LU-4K; Sat, 09 Apr 2022 05:00:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301941.515455; Sat, 09 Apr 2022 05:00:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DB-0008Jl-UG; Sat, 09 Apr 2022 05:00:37 +0000
Received: by outflank-mailman (input) for mailman id 301941;
 Sat, 09 Apr 2022 05:00:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd35V-0006gL-PC
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:42 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e15c4e77-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:52:39 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd35C-0021lf-95; Sat, 09 Apr 2022 04:52:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e15c4e77-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=MR1dBREWEzr7uhm77WcgVZfNn+irLPCXxWfbv0Y8Fx8=; b=g1JrWZZU7gXqi54KSSq2td5NGg
	JTv8uprg5injPH7nKkeNRWdn6oTNLWZZnzaHqHhPeHQKztSOiA4sj9FfMAEZJ7/a9B/nIKLTwqwGB
	PuDRNI4dm2AH1PLgWy6G6WT6g3S55JW0fBof3tJZn4+4Uz4tLd0IKxpSOJszbSZ5S5fhGHf6HQiq8
	tfOI2qhlZHSzdLNHIOgkox+DFYK8KmZY72c/I/6yjiFdBqWpjKEKpQemLV7RLvoqpLXmpYDnm9R+M
	6+YRTeKl4k0OAcFvjw1Z1NHUh/0kBaNpv9L8pEjsBLMomqJ9Ip1F1RfoaNm2SYWGY95WZH5q/4P5S
	xDXG8m/A==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>,
	Coly Li <colyli@suse.de>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD
Date: Sat,  9 Apr 2022 06:50:42 +0200
Message-Id: <20220409045043.23593-27-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Secure erase is a very different operation from discard in that it is
a data integrity operation vs hint.  Fully split the limits and helper
infrastructure to make the separation more clear.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> [nifs2]
Acked-by: Coly Li <colyli@suse.de> [drbd]
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 block/blk-core.c                    |  2 +-
 block/blk-lib.c                     | 64 ++++++++++++++++++++---------
 block/blk-mq-debugfs.c              |  1 -
 block/blk-settings.c                | 16 +++++++-
 block/fops.c                        |  2 +-
 block/ioctl.c                       | 43 +++++++++++++++----
 drivers/block/drbd/drbd_receiver.c  |  5 ++-
 drivers/block/rnbd/rnbd-clt.c       |  4 +-
 drivers/block/rnbd/rnbd-srv-dev.h   |  2 +-
 drivers/block/xen-blkback/blkback.c | 15 +++----
 drivers/block/xen-blkback/xenbus.c  |  5 +--
 drivers/block/xen-blkfront.c        |  5 ++-
 drivers/md/bcache/alloc.c           |  2 +-
 drivers/md/dm-table.c               |  8 ++--
 drivers/md/dm-thin.c                |  4 +-
 drivers/md/md.c                     |  2 +-
 drivers/md/raid5-cache.c            |  6 +--
 drivers/mmc/core/queue.c            |  2 +-
 drivers/nvme/target/io-cmd-bdev.c   |  2 +-
 drivers/target/target_core_file.c   |  2 +-
 drivers/target/target_core_iblock.c |  2 +-
 fs/btrfs/extent-tree.c              |  4 +-
 fs/ext4/mballoc.c                   |  2 +-
 fs/f2fs/file.c                      | 16 ++++----
 fs/f2fs/segment.c                   |  2 +-
 fs/jbd2/journal.c                   |  2 +-
 fs/nilfs2/sufile.c                  |  4 +-
 fs/nilfs2/the_nilfs.c               |  4 +-
 fs/ntfs3/super.c                    |  2 +-
 fs/xfs/xfs_discard.c                |  2 +-
 fs/xfs/xfs_log_cil.c                |  2 +-
 include/linux/blkdev.h              | 27 +++++++-----
 mm/swapfile.c                       |  6 +--
 33 files changed, 168 insertions(+), 99 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index b5c3a8049134c..ee18b6a699bdf 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -824,7 +824,7 @@ void submit_bio_noacct(struct bio *bio)
 			goto not_supported;
 		break;
 	case REQ_OP_SECURE_ERASE:
-		if (!blk_queue_secure_erase(q))
+		if (!bdev_max_secure_erase_sectors(bdev))
 			goto not_supported;
 		break;
 	case REQ_OP_ZONE_APPEND:
diff --git a/block/blk-lib.c b/block/blk-lib.c
index 43aa4d7fe859f..09b7e1200c0f4 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -36,26 +36,15 @@ static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
 }
 
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, int flags,
-		struct bio **biop)
+		sector_t nr_sects, gfp_t gfp_mask, struct bio **biop)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
-	unsigned int op;
 	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
-
-	if (flags & BLKDEV_DISCARD_SECURE) {
-		if (!blk_queue_secure_erase(q))
-			return -EOPNOTSUPP;
-		op = REQ_OP_SECURE_ERASE;
-	} else {
-		if (!bdev_max_discard_sectors(bdev))
-			return -EOPNOTSUPP;
-		op = REQ_OP_DISCARD;
-	}
+	if (!bdev_max_discard_sectors(bdev))
+		return -EOPNOTSUPP;
 
 	/* In case the discard granularity isn't set by buggy device driver */
 	if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
@@ -77,7 +66,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t req_sects =
 			min(nr_sects, bio_discard_limit(bdev, sector));
 
-		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
+		bio = blk_next_bio(bio, bdev, 0, REQ_OP_DISCARD, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
 		bio->bi_iter.bi_size = req_sects << 9;
 		sector += req_sects;
@@ -103,21 +92,19 @@ EXPORT_SYMBOL(__blkdev_issue_discard);
  * @sector:	start sector
  * @nr_sects:	number of sectors to discard
  * @gfp_mask:	memory allocation flags (for bio_alloc)
- * @flags:	BLKDEV_DISCARD_* flags to control behaviour
  *
  * Description:
  *    Issue a discard request for the sectors in question.
  */
 int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags)
+		sector_t nr_sects, gfp_t gfp_mask)
 {
 	struct bio *bio = NULL;
 	struct blk_plug plug;
 	int ret;
 
 	blk_start_plug(&plug);
-	ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, flags,
-			&bio);
+	ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, &bio);
 	if (!ret && bio) {
 		ret = submit_bio_wait(bio);
 		if (ret == -EOPNOTSUPP)
@@ -314,3 +301,42 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
 	return ret;
 }
 EXPORT_SYMBOL(blkdev_issue_zeroout);
+
+int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp)
+{
+	sector_t bs_mask = (bdev_logical_block_size(bdev) >> 9) - 1;
+	unsigned int max_sectors = bdev_max_secure_erase_sectors(bdev);
+	struct bio *bio = NULL;
+	struct blk_plug plug;
+	int ret = 0;
+
+	if (max_sectors == 0)
+		return -EOPNOTSUPP;
+	if ((sector | nr_sects) & bs_mask)
+		return -EINVAL;
+	if (bdev_read_only(bdev))
+		return -EPERM;
+
+	blk_start_plug(&plug);
+	for (;;) {
+		unsigned int len = min_t(sector_t, nr_sects, max_sectors);
+
+		bio = blk_next_bio(bio, bdev, 0, REQ_OP_SECURE_ERASE, gfp);
+		bio->bi_iter.bi_sector = sector;
+		bio->bi_iter.bi_size = len;
+
+		sector += len << SECTOR_SHIFT;
+		nr_sects -= len << SECTOR_SHIFT;
+		if (!nr_sects) {
+			ret = submit_bio_wait(bio);
+			bio_put(bio);
+			break;
+		}
+		cond_resched();
+	}
+	blk_finish_plug(&plug);
+
+	return ret;
+}
+EXPORT_SYMBOL(blkdev_issue_secure_erase);
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index fd111c5001256..7e4136a60e1cc 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -115,7 +115,6 @@ static const char *const blk_queue_flag_name[] = {
 	QUEUE_FLAG_NAME(IO_STAT),
 	QUEUE_FLAG_NAME(NOXMERGES),
 	QUEUE_FLAG_NAME(ADD_RANDOM),
-	QUEUE_FLAG_NAME(SECERASE),
 	QUEUE_FLAG_NAME(SAME_FORCE),
 	QUEUE_FLAG_NAME(DEAD),
 	QUEUE_FLAG_NAME(INIT_DONE),
diff --git a/block/blk-settings.c b/block/blk-settings.c
index fd83d674afd0a..6ccceb421ed2f 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -46,6 +46,7 @@ void blk_set_default_limits(struct queue_limits *lim)
 	lim->max_zone_append_sectors = 0;
 	lim->max_discard_sectors = 0;
 	lim->max_hw_discard_sectors = 0;
+	lim->max_secure_erase_sectors = 0;
 	lim->discard_granularity = 0;
 	lim->discard_alignment = 0;
 	lim->discard_misaligned = 0;
@@ -176,6 +177,18 @@ void blk_queue_max_discard_sectors(struct request_queue *q,
 }
 EXPORT_SYMBOL(blk_queue_max_discard_sectors);
 
+/**
+ * blk_queue_max_secure_erase_sectors - set max sectors for a secure erase
+ * @q:  the request queue for the device
+ * @max_sectors: maximum number of sectors to secure_erase
+ **/
+void blk_queue_max_secure_erase_sectors(struct request_queue *q,
+		unsigned int max_sectors)
+{
+	q->limits.max_secure_erase_sectors = max_sectors;
+}
+EXPORT_SYMBOL(blk_queue_max_secure_erase_sectors);
+
 /**
  * blk_queue_max_write_zeroes_sectors - set max sectors for a single
  *                                      write zeroes
@@ -661,7 +674,8 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
 		t->discard_alignment = lcm_not_zero(t->discard_alignment, alignment) %
 			t->discard_granularity;
 	}
-
+	t->max_secure_erase_sectors = min_not_zero(t->max_secure_erase_sectors,
+						   b->max_secure_erase_sectors);
 	t->zone_write_granularity = max(t->zone_write_granularity,
 					b->zone_write_granularity);
 	t->zoned = max(t->zoned, b->zoned);
diff --git a/block/fops.c b/block/fops.c
index 9f2ecec406b04..c0ca3254d38cf 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -672,7 +672,7 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
 		break;
 	case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE:
 		error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT,
-					     len >> SECTOR_SHIFT, GFP_KERNEL, 0);
+					     len >> SECTOR_SHIFT, GFP_KERNEL);
 		break;
 	default:
 		error = -EOPNOTSUPP;
diff --git a/block/ioctl.c b/block/ioctl.c
index c2cd3ba5290ce..5b5027fa78f7e 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -83,7 +83,7 @@ static int compat_blkpg_ioctl(struct block_device *bdev,
 #endif
 
 static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
-		unsigned long arg, unsigned long flags)
+		unsigned long arg)
 {
 	uint64_t range[2];
 	uint64_t start, len;
@@ -114,15 +114,43 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
 	err = truncate_bdev_range(bdev, mode, start, start + len - 1);
 	if (err)
 		goto fail;
-
-	err = blkdev_issue_discard(bdev, start >> 9, len >> 9,
-				   GFP_KERNEL, flags);
-
+	err = blkdev_issue_discard(bdev, start >> 9, len >> 9, GFP_KERNEL);
 fail:
 	filemap_invalidate_unlock(inode->i_mapping);
 	return err;
 }
 
+static int blk_ioctl_secure_erase(struct block_device *bdev, fmode_t mode,
+		void __user *argp)
+{
+	uint64_t start, len;
+	uint64_t range[2];
+	int err;
+
+	if (!(mode & FMODE_WRITE))
+		return -EBADF;
+	if (!bdev_max_secure_erase_sectors(bdev))
+		return -EOPNOTSUPP;
+	if (copy_from_user(range, argp, sizeof(range)))
+		return -EFAULT;
+
+	start = range[0];
+	len = range[1];
+	if ((start & 511) || (len & 511))
+		return -EINVAL;
+	if (start + len > bdev_nr_bytes(bdev))
+		return -EINVAL;
+
+	filemap_invalidate_lock(bdev->bd_inode->i_mapping);
+	err = truncate_bdev_range(bdev, mode, start, start + len - 1);
+	if (!err)
+		err = blkdev_issue_secure_erase(bdev, start >> 9, len >> 9,
+						GFP_KERNEL);
+	filemap_invalidate_unlock(bdev->bd_inode->i_mapping);
+	return err;
+}
+
+
 static int blk_ioctl_zeroout(struct block_device *bdev, fmode_t mode,
 		unsigned long arg)
 {
@@ -450,10 +478,9 @@ static int blkdev_common_ioctl(struct block_device *bdev, fmode_t mode,
 	case BLKROSET:
 		return blkdev_roset(bdev, mode, cmd, arg);
 	case BLKDISCARD:
-		return blk_ioctl_discard(bdev, mode, arg, 0);
+		return blk_ioctl_discard(bdev, mode, arg);
 	case BLKSECDISCARD:
-		return blk_ioctl_discard(bdev, mode, arg,
-				BLKDEV_DISCARD_SECURE);
+		return blk_ioctl_secure_erase(bdev, mode, argp);
 	case BLKZEROOUT:
 		return blk_ioctl_zeroout(bdev, mode, arg);
 	case BLKGETDISKSEQ:
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 275c53c7b629e..2957b0b68d600 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1547,7 +1547,8 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		start = tmp;
 	}
 	while (nr_sectors >= max_discard_sectors) {
-		err |= blkdev_issue_discard(bdev, start, max_discard_sectors, GFP_NOIO, 0);
+		err |= blkdev_issue_discard(bdev, start, max_discard_sectors,
+					    GFP_NOIO);
 		nr_sectors -= max_discard_sectors;
 		start += max_discard_sectors;
 	}
@@ -1559,7 +1560,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		nr = nr_sectors;
 		nr -= (unsigned int)nr % granularity;
 		if (nr) {
-			err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO, 0);
+			err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO);
 			nr_sectors -= nr;
 			start += nr;
 		}
diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index efa99a3884507..d178be175ad99 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1365,8 +1365,8 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
 	dev->queue->limits.discard_granularity	= dev->discard_granularity;
 	dev->queue->limits.discard_alignment	= dev->discard_alignment;
 	if (dev->secure_discard)
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, dev->queue);
-
+		blk_queue_max_secure_erase_sectors(dev->queue,
+				dev->max_discard_sectors);
 	blk_queue_flag_set(QUEUE_FLAG_SAME_COMP, dev->queue);
 	blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue);
 	blk_queue_max_segments(dev->queue, dev->max_segments);
diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index 1f7e1c8fd4d9b..d080a0de59225 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -44,7 +44,7 @@ static inline int rnbd_dev_get_max_hw_sects(const struct rnbd_dev *dev)
 
 static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
 {
-	return blk_queue_secure_erase(bdev_get_queue(dev->bdev));
+	return bdev_max_secure_erase_sectors(dev->bdev);
 }
 
 static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index de42458195bc1..a97f2bf5b01b9 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -970,7 +970,6 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
 	int status = BLKIF_RSP_OKAY;
 	struct xen_blkif *blkif = ring->blkif;
 	struct block_device *bdev = blkif->vbd.bdev;
-	unsigned long secure;
 	struct phys_req preq;
 
 	xen_blkif_get(blkif);
@@ -987,13 +986,15 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
 	}
 	ring->st_ds_req++;
 
-	secure = (blkif->vbd.discard_secure &&
-		 (req->u.discard.flag & BLKIF_DISCARD_SECURE)) ?
-		 BLKDEV_DISCARD_SECURE : 0;
+	if (blkif->vbd.discard_secure &&
+	    (req->u.discard.flag & BLKIF_DISCARD_SECURE))
+		err = blkdev_issue_secure_erase(bdev,
+				req->u.discard.sector_number,
+				req->u.discard.nr_sectors, GFP_KERNEL);
+	else
+		err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
+				req->u.discard.nr_sectors, GFP_KERNEL);
 
-	err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
-				   req->u.discard.nr_sectors,
-				   GFP_KERNEL, secure);
 fail_response:
 	if (err == -EOPNOTSUPP) {
 		pr_debug("discard op failed, not supported\n");
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 83cd08041e6b3..b21bffc9c50bc 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -484,7 +484,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 {
 	struct xen_vbd *vbd;
 	struct block_device *bdev;
-	struct request_queue *q;
 
 	vbd = &blkif->vbd;
 	vbd->handle   = handle;
@@ -516,11 +515,9 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 	if (vbd->bdev->bd_disk->flags & GENHD_FL_REMOVABLE)
 		vbd->type |= VDISK_REMOVABLE;
 
-	q = bdev_get_queue(bdev);
 	if (bdev_write_cache(bdev))
 		vbd->flush_support = true;
-
-	if (q && blk_queue_secure_erase(q))
+	if (bdev_max_secure_erase_sectors(bdev))
 		vbd->discard_secure = true;
 
 	vbd->feature_gnt_persistent = feature_persistent;
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 253bf835aca1f..9fb7c69f72b2d 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -949,7 +949,8 @@ static void blkif_set_queue_limits(struct blkfront_info *info)
 						 info->physical_sector_size;
 		rq->limits.discard_alignment = info->discard_alignment;
 		if (info->feature_secdiscard)
-			blk_queue_flag_set(QUEUE_FLAG_SECERASE, rq);
+			blk_queue_max_secure_erase_sectors(rq,
+							   get_capacity(gd));
 	}
 
 	/* Hard sector size and max sectors impersonate the equiv. hardware. */
@@ -1605,7 +1606,7 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
 				blkif_req(req)->error = BLK_STS_NOTSUPP;
 				info->feature_discard = 0;
 				info->feature_secdiscard = 0;
-				blk_queue_flag_clear(QUEUE_FLAG_SECERASE, rq);
+				blk_queue_max_secure_erase_sectors(rq, 0);
 			}
 			break;
 		case BLKIF_OP_FLUSH_DISKCACHE:
diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
index 097577ae3c471..ce13c272c3872 100644
--- a/drivers/md/bcache/alloc.c
+++ b/drivers/md/bcache/alloc.c
@@ -336,7 +336,7 @@ static int bch_allocator_thread(void *arg)
 				mutex_unlock(&ca->set->bucket_lock);
 				blkdev_issue_discard(ca->bdev,
 					bucket_to_sector(ca->set, bucket),
-					ca->sb.bucket_size, GFP_KERNEL, 0);
+					ca->sb.bucket_size, GFP_KERNEL);
 				mutex_lock(&ca->set->bucket_lock);
 			}
 
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 0dff6907fd00d..e7d42f6335a2a 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1920,9 +1920,7 @@ static int device_not_secure_erase_capable(struct dm_target *ti,
 					   struct dm_dev *dev, sector_t start,
 					   sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_secure_erase(q);
+	return !bdev_max_secure_erase_sectors(dev->bdev);
 }
 
 static bool dm_table_supports_secure_erase(struct dm_table *t)
@@ -1975,8 +1973,8 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
 		q->limits.discard_misaligned = 0;
 	}
 
-	if (dm_table_supports_secure_erase(t))
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
+	if (!dm_table_supports_secure_erase(t))
+		q->limits.max_secure_erase_sectors = 0;
 
 	if (dm_table_supports_flush(t, (1UL << QUEUE_FLAG_WC))) {
 		wc = true;
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index eded4bcc4545f..84c083f766736 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -398,8 +398,8 @@ static int issue_discard(struct discard_op *op, dm_block_t data_b, dm_block_t da
 	sector_t s = block_to_sectors(tc->pool, data_b);
 	sector_t len = block_to_sectors(tc->pool, data_e - data_b);
 
-	return __blkdev_issue_discard(tc->pool_dev->bdev, s, len,
-				      GFP_NOWAIT, 0, &op->bio);
+	return __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOWAIT,
+				      &op->bio);
 }
 
 static void end_discard(struct discard_op *op, int r)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 19636c2f2cda4..2587f872c0884 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8584,7 +8584,7 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
 {
 	struct bio *discard_bio = NULL;
 
-	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, 0,
+	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,
 			&discard_bio) || !discard_bio)
 		return;
 
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index c3cbf9a574a39..094a4042589eb 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1344,14 +1344,14 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
 	if (log->last_checkpoint < end) {
 		blkdev_issue_discard(bdev,
 				log->last_checkpoint + log->rdev->data_offset,
-				end - log->last_checkpoint, GFP_NOIO, 0);
+				end - log->last_checkpoint, GFP_NOIO);
 	} else {
 		blkdev_issue_discard(bdev,
 				log->last_checkpoint + log->rdev->data_offset,
 				log->device_size - log->last_checkpoint,
-				GFP_NOIO, 0);
+				GFP_NOIO);
 		blkdev_issue_discard(bdev, log->rdev->data_offset, end,
-				GFP_NOIO, 0);
+				GFP_NOIO);
 	}
 }
 
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index cac6315010a3d..a3d4460055716 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -189,7 +189,7 @@ static void mmc_queue_setup_discard(struct request_queue *q,
 	if (card->pref_erase > max_discard)
 		q->limits.discard_granularity = SECTOR_SIZE;
 	if (mmc_can_secure_erase_trim(card))
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
+		blk_queue_max_secure_erase_sectors(q, max_discard);
 }
 
 static unsigned short mmc_get_max_segments(struct mmc_host *host)
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
index d886c2c59554f..27a72504d31ce 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
+++ b/drivers/nvme/target/io-cmd-bdev.c
@@ -360,7 +360,7 @@ static u16 nvmet_bdev_discard_range(struct nvmet_req *req,
 	ret = __blkdev_issue_discard(ns->bdev,
 			nvmet_lba_to_sect(ns, range->slba),
 			le32_to_cpu(range->nlb) << (ns->blksize_shift - 9),
-			GFP_KERNEL, 0, bio);
+			GFP_KERNEL, bio);
 	if (ret && ret != -EOPNOTSUPP) {
 		req->error_slba = le64_to_cpu(range->slba);
 		return errno_to_nvme_status(req, ret);
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index b6ba582b06775..e68f1cc8ef98b 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -558,7 +558,7 @@ fd_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
 		ret = blkdev_issue_discard(bdev,
 					   target_to_linux_sector(dev, lba),
 					   target_to_linux_sector(dev,  nolb),
-					   GFP_KERNEL, 0);
+					   GFP_KERNEL);
 		if (ret < 0) {
 			pr_warn("FILEIO: blkdev_issue_discard() failed: %d\n",
 				ret);
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index c4a903b8a47fc..378c80313a0f2 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -434,7 +434,7 @@ iblock_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
 	ret = blkdev_issue_discard(bdev,
 				   target_to_linux_sector(dev, lba),
 				   target_to_linux_sector(dev,  nolb),
-				   GFP_KERNEL, 0);
+				   GFP_KERNEL);
 	if (ret < 0) {
 		pr_err("blkdev_issue_discard() failed: %d\n", ret);
 		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index efd8deb3ab7e8..5c1d3a564da5a 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1239,7 +1239,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
 
 		if (size) {
 			ret = blkdev_issue_discard(bdev, start >> 9, size >> 9,
-						   GFP_NOFS, 0);
+						   GFP_NOFS);
 			if (!ret)
 				*discarded_bytes += size;
 			else if (ret != -EOPNOTSUPP)
@@ -1256,7 +1256,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
 
 	if (bytes_left) {
 		ret = blkdev_issue_discard(bdev, start >> 9, bytes_left >> 9,
-					   GFP_NOFS, 0);
+					   GFP_NOFS);
 		if (!ret)
 			*discarded_bytes += bytes_left;
 	}
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 6d1820536d88d..ea653d19f9ec7 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3629,7 +3629,7 @@ static inline int ext4_issue_discard(struct super_block *sb,
 		return __blkdev_issue_discard(sb->s_bdev,
 			(sector_t)discard_block << (sb->s_blocksize_bits - 9),
 			(sector_t)count << (sb->s_blocksize_bits - 9),
-			GFP_NOFS, 0, biop);
+			GFP_NOFS, biop);
 	} else
 		return sb_issue_discard(sb, discard_block, count, GFP_NOFS, 0);
 }
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 8053d99f3920b..35b6c720c2bc1 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3685,18 +3685,18 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg)
 static int f2fs_secure_erase(struct block_device *bdev, struct inode *inode,
 		pgoff_t off, block_t block, block_t len, u32 flags)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	sector_t sector = SECTOR_FROM_BLOCK(block);
 	sector_t nr_sects = SECTOR_FROM_BLOCK(len);
 	int ret = 0;
 
-	if (!q)
-		return -ENXIO;
-
-	if (flags & F2FS_TRIM_FILE_DISCARD)
-		ret = blkdev_issue_discard(bdev, sector, nr_sects, GFP_NOFS,
-						blk_queue_secure_erase(q) ?
-						BLKDEV_DISCARD_SECURE : 0);
+	if (flags & F2FS_TRIM_FILE_DISCARD) {
+		if (bdev_max_secure_erase_sectors(bdev))
+			ret = blkdev_issue_secure_erase(bdev, sector, nr_sects,
+					GFP_NOFS);
+		else
+			ret = blkdev_issue_discard(bdev, sector, nr_sects,
+					GFP_NOFS);
+	}
 
 	if (!ret && (flags & F2FS_TRIM_FILE_ZEROOUT)) {
 		if (IS_ENCRYPTED(inode))
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 71f09adbcba86..e433c61e64b93 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1244,7 +1244,7 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
 		err = __blkdev_issue_discard(bdev,
 					SECTOR_FROM_BLOCK(start),
 					SECTOR_FROM_BLOCK(len),
-					GFP_NOFS, 0, &bio);
+					GFP_NOFS, &bio);
 submit:
 		if (err) {
 			spin_lock_irqsave(&dc->lock, flags);
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 19d226cd4ff4d..c0cbeeaec2d1a 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1825,7 +1825,7 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 			err = blkdev_issue_discard(journal->j_dev,
 					byte_start >> SECTOR_SHIFT,
 					byte_count >> SECTOR_SHIFT,
-					GFP_NOFS, 0);
+					GFP_NOFS);
 		} else if (flags & JBD2_JOURNAL_FLUSH_ZEROOUT) {
 			err = blkdev_issue_zeroout(journal->j_dev,
 					byte_start >> SECTOR_SHIFT,
diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c
index e385cca2004a7..77ff8e95421fa 100644
--- a/fs/nilfs2/sufile.c
+++ b/fs/nilfs2/sufile.c
@@ -1100,7 +1100,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
 				ret = blkdev_issue_discard(nilfs->ns_bdev,
 						start * sects_per_block,
 						nblocks * sects_per_block,
-						GFP_NOFS, 0);
+						GFP_NOFS);
 				if (ret < 0) {
 					put_bh(su_bh);
 					goto out_sem;
@@ -1134,7 +1134,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
 			ret = blkdev_issue_discard(nilfs->ns_bdev,
 					start * sects_per_block,
 					nblocks * sects_per_block,
-					GFP_NOFS, 0);
+					GFP_NOFS);
 			if (!ret)
 				ndiscarded += nblocks;
 		}
diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c
index dd48a8f74d577..3b4a079c9617c 100644
--- a/fs/nilfs2/the_nilfs.c
+++ b/fs/nilfs2/the_nilfs.c
@@ -672,7 +672,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
 			ret = blkdev_issue_discard(nilfs->ns_bdev,
 						   start * sects_per_block,
 						   nblocks * sects_per_block,
-						   GFP_NOFS, 0);
+						   GFP_NOFS);
 			if (ret < 0)
 				return ret;
 			nblocks = 0;
@@ -682,7 +682,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
 		ret = blkdev_issue_discard(nilfs->ns_bdev,
 					   start * sects_per_block,
 					   nblocks * sects_per_block,
-					   GFP_NOFS, 0);
+					   GFP_NOFS);
 	return ret;
 }
 
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 5f2e414cfa79b..5781b9e8e3d85 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1333,7 +1333,7 @@ int ntfs_discard(struct ntfs_sb_info *sbi, CLST lcn, CLST len)
 		return 0;
 
 	err = blkdev_issue_discard(sb->s_bdev, start >> 9, (end - start) >> 9,
-				   GFP_NOFS, 0);
+				   GFP_NOFS);
 
 	if (err == -EOPNOTSUPP)
 		sbi->flags |= NTFS_FLAGS_NODISCARD;
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index e2ada115c23f9..c6fe3f6ebb6b0 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -114,7 +114,7 @@ xfs_trim_extents(
 		}
 
 		trace_xfs_discard_extent(mp, agno, fbno, flen);
-		error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS, 0);
+		error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS);
 		if (error)
 			goto out_del_cursor;
 		*blocks_trimmed += flen;
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
index ba57323bfdcea..c9f55e4f09571 100644
--- a/fs/xfs/xfs_log_cil.c
+++ b/fs/xfs/xfs_log_cil.c
@@ -605,7 +605,7 @@ xlog_discard_busy_extents(
 		error = __blkdev_issue_discard(mp->m_ddev_targp->bt_bdev,
 				XFS_AGB_TO_DADDR(mp, busyp->agno, busyp->bno),
 				XFS_FSB_TO_BB(mp, busyp->length),
-				GFP_NOFS, 0, &bio);
+				GFP_NOFS, &bio);
 		if (error && error != -EOPNOTSUPP) {
 			xfs_info(mp,
 	 "discard failed for extent [0x%llx,%u], error %d",
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f1cf557ea20ef..c9b5925af5a3b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -248,6 +248,7 @@ struct queue_limits {
 	unsigned int		io_opt;
 	unsigned int		max_discard_sectors;
 	unsigned int		max_hw_discard_sectors;
+	unsigned int		max_secure_erase_sectors;
 	unsigned int		max_write_zeroes_sectors;
 	unsigned int		max_zone_append_sectors;
 	unsigned int		discard_granularity;
@@ -542,7 +543,6 @@ struct request_queue {
 #define QUEUE_FLAG_IO_STAT	7	/* do disk/partitions IO accounting */
 #define QUEUE_FLAG_NOXMERGES	9	/* No extended merges */
 #define QUEUE_FLAG_ADD_RANDOM	10	/* Contributes to random pool */
-#define QUEUE_FLAG_SECERASE	11	/* supports secure erase */
 #define QUEUE_FLAG_SAME_FORCE	12	/* force complete on same CPU */
 #define QUEUE_FLAG_DEAD		13	/* queue tear-down finished */
 #define QUEUE_FLAG_INIT_DONE	14	/* queue is initialized */
@@ -583,8 +583,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 #define blk_queue_add_random(q)	test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
 #define blk_queue_zone_resetall(q)	\
 	test_bit(QUEUE_FLAG_ZONE_RESETALL, &(q)->queue_flags)
-#define blk_queue_secure_erase(q) \
-	(test_bit(QUEUE_FLAG_SECERASE, &(q)->queue_flags))
 #define blk_queue_dax(q)	test_bit(QUEUE_FLAG_DAX, &(q)->queue_flags)
 #define blk_queue_pci_p2pdma(q)	\
 	test_bit(QUEUE_FLAG_PCI_P2PDMA, &(q)->queue_flags)
@@ -947,6 +945,8 @@ extern void blk_queue_chunk_sectors(struct request_queue *, unsigned int);
 extern void blk_queue_max_segments(struct request_queue *, unsigned short);
 extern void blk_queue_max_discard_segments(struct request_queue *,
 		unsigned short);
+void blk_queue_max_secure_erase_sectors(struct request_queue *q,
+		unsigned int max_sectors);
 extern void blk_queue_max_segment_size(struct request_queue *, unsigned int);
 extern void blk_queue_max_discard_sectors(struct request_queue *q,
 		unsigned int max_discard_sectors);
@@ -1087,13 +1087,12 @@ static inline long nr_blockdev_pages(void)
 
 extern void blk_io_schedule(void);
 
-#define BLKDEV_DISCARD_SECURE	(1 << 0)	/* issue a secure erase */
-
-extern int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags);
-extern int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, int flags,
-		struct bio **biop);
+int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp_mask);
+int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp_mask, struct bio **biop);
+int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp);
 
 #define BLKDEV_ZERO_NOUNMAP	(1 << 0)  /* do not free blocks */
 #define BLKDEV_ZERO_NOFALLBACK	(1 << 1)  /* don't write explicit zeroes */
@@ -1112,7 +1111,7 @@ static inline int sb_issue_discard(struct super_block *sb, sector_t block,
 					      SECTOR_SHIFT),
 				    nr_blocks << (sb->s_blocksize_bits -
 						  SECTOR_SHIFT),
-				    gfp_mask, flags);
+				    gfp_mask);
 }
 static inline int sb_issue_zeroout(struct super_block *sb, sector_t block,
 		sector_t nr_blocks, gfp_t gfp_mask)
@@ -1262,6 +1261,12 @@ static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
 	return bdev_get_queue(bdev)->limits.discard_granularity;
 }
 
+static inline unsigned int
+bdev_max_secure_erase_sectors(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.max_secure_erase_sectors;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 5d9cedf9e7b84..a2b31fea0c42e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -179,7 +179,7 @@ static int discard_swap(struct swap_info_struct *si)
 	nr_blocks = ((sector_t)se->nr_pages - 1) << (PAGE_SHIFT - 9);
 	if (nr_blocks) {
 		err = blkdev_issue_discard(si->bdev, start_block,
-				nr_blocks, GFP_KERNEL, 0);
+				nr_blocks, GFP_KERNEL);
 		if (err)
 			return err;
 		cond_resched();
@@ -190,7 +190,7 @@ static int discard_swap(struct swap_info_struct *si)
 		nr_blocks = (sector_t)se->nr_pages << (PAGE_SHIFT - 9);
 
 		err = blkdev_issue_discard(si->bdev, start_block,
-				nr_blocks, GFP_KERNEL, 0);
+				nr_blocks, GFP_KERNEL);
 		if (err)
 			break;
 
@@ -254,7 +254,7 @@ static void discard_swap_cluster(struct swap_info_struct *si,
 		start_block <<= PAGE_SHIFT - 9;
 		nr_blocks <<= PAGE_SHIFT - 9;
 		if (blkdev_issue_discard(si->bdev, start_block,
-					nr_blocks, GFP_NOIO, 0))
+					nr_blocks, GFP_NOIO))
 			break;
 
 		se = next_se(se);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301942.515465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DC-0008Tr-UB; Sat, 09 Apr 2022 05:00:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301942.515465; Sat, 09 Apr 2022 05:00:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DC-0008QY-Df; Sat, 09 Apr 2022 05:00:38 +0000
Received: by outflank-mailman (input) for mailman id 301942;
 Sat, 09 Apr 2022 05:00:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34Y-0006gL-76
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:42 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bedc21de-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:41 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34H-0020rG-Tc; Sat, 09 Apr 2022 04:51:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bedc21de-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=codmNOYfetDHLJxPogl163/OdD9N1JgIxrWdZCt0360=; b=3NoKNhDeSq9S0P9nMMbDbIrAeJ
	+QEZand4sjAkw+sDEzFUsm0WqJELhqryZtfcxyrLDrupUuuLjoND05T4WTINiqRUjqo+5Efsq5Qf7
	zePwe0fJlqe/9Scx23UnVl8E1E8mZU9ccHMKQ/tG4uXU16BLkGrbTdsMmme/ItC/yBINYTi0IVvDS
	euCK6TSOd2twj4wWKaEcEg0KRAOd/4ZUNfRoOCGYiYPz+sQJZ3dMQ7kgPa3ep8OA6763OSYfCbhod
	Vz3PYC15ZdzVW9ceDBCCgvFu1e1pGBKJqTg3/enz95H5r0c0lWdydglA1/DfOjLVKaKxh3Wdgn4wE
	L6Oi9ACQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 12/27] block: add a bdev_write_cache helper
Date: Sat,  9 Apr 2022 06:50:28 +0200
Message-Id: <20220409045043.23593-13-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the write cache flag based on the block_device
instead of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 drivers/block/rnbd/rnbd-srv.c       | 2 +-
 drivers/block/xen-blkback/xenbus.c  | 2 +-
 drivers/target/target_core_iblock.c | 8 ++------
 fs/btrfs/disk-io.c                  | 3 +--
 include/linux/blkdev.h              | 5 +++++
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index f04df6294650b..f8cc3c5fecb4b 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -558,7 +558,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 	rsp->secure_discard =
 		cpu_to_le16(rnbd_dev_get_secure_discard(rnbd_dev));
 	rsp->cache_policy = 0;
-	if (test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (bdev_write_cache(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_WRITEBACK;
 	if (blk_queue_fua(q))
 		rsp->cache_policy |= RNBD_FUA;
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index f09040435e2e5..8b691fe50475f 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -517,7 +517,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 		vbd->type |= VDISK_REMOVABLE;
 
 	q = bdev_get_queue(bdev);
-	if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (bdev_write_cache(bdev))
 		vbd->flush_support = true;
 
 	if (q && blk_queue_secure_erase(q))
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index b41ee5c3b5b82..03013e85ffc03 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -737,7 +737,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
 		if (test_bit(QUEUE_FLAG_FUA, &q->queue_flags)) {
 			if (cmd->se_cmd_flags & SCF_FUA)
 				opf |= REQ_FUA;
-			else if (!test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+			else if (!bdev_write_cache(ib_dev->ibd_bd))
 				opf |= REQ_FUA;
 		}
 	} else {
@@ -886,11 +886,7 @@ iblock_parse_cdb(struct se_cmd *cmd)
 
 static bool iblock_get_write_cache(struct se_device *dev)
 {
-	struct iblock_dev *ib_dev = IBLOCK_DEV(dev);
-	struct block_device *bd = ib_dev->ibd_bd;
-	struct request_queue *q = bdev_get_queue(bd);
-
-	return test_bit(QUEUE_FLAG_WC, &q->queue_flags);
+	return bdev_write_cache(IBLOCK_DEV(dev)->ibd_bd);
 }
 
 static const struct target_backend_ops iblock_ops = {
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index b30309f187cf0..d80adee32128d 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -4247,8 +4247,7 @@ static void write_dev_flush(struct btrfs_device *device)
 	 * of simplicity, since this is a debug tool and not meant for use in
 	 * non-debug builds.
 	 */
-	struct request_queue *q = bdev_get_queue(device->bdev);
-	if (!test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (bdev_write_cache(device->bdev))
 		return;
 #endif
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 3a9578e14a6b0..807a49aa5a27a 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1331,6 +1331,11 @@ static inline bool bdev_nonrot(struct block_device *bdev)
 	return blk_queue_nonrot(bdev_get_queue(bdev));
 }
 
+static inline bool bdev_write_cache(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301954.515491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DH-0001Hw-MD; Sat, 09 Apr 2022 05:00:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301954.515491; Sat, 09 Apr 2022 05:00:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DH-0001HI-FX; Sat, 09 Apr 2022 05:00:43 +0000
Received: by outflank-mailman (input) for mailman id 301954;
 Sat, 09 Apr 2022 05:00:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd35O-0006gL-4S
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:34 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc3e5d72-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:52:31 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd354-0021dK-Sw; Sat, 09 Apr 2022 04:52:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc3e5d72-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=lhrI7Npx42D1AuR/cMyqCoOjrZczBcvFSvpyDVoTBuM=; b=Sjapi7eI4Jh86xiPLIzL2g0V1J
	mjcOCE9buuik3xQceo12VbO7h4X1i/S8+EGUcf1u3xFqviUr0IXMxs/3Qij4rUA/BVYuftFH0B+QL
	15jKW5DOWLXn3fZpnfOdPjT+8sq7nSyHdBxT6coOufp9mqpgHjMXvI28DvNWovru926kmp5e+ex7c
	/jYKn9KuBgqzsQrl/W/fJF4dNs6aceGzPpdLj4fBSiNAx7tFXGHLE6PclN+/DWpkJQW8eCCHQlhYf
	t5bRpzLnnxe4LGnXML4qPk3asM8WCBUpA/jrjYRG0MkY4Dc8Ud6n31tOOsdykMc3zj9OSK9AysXdb
	fD5Kz47g==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Coly Li <colyli@suse.de>
Subject: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Date: Sat,  9 Apr 2022 06:50:40 +0200
Message-Id: <20220409045043.23593-25-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Just use a non-zero max_discard_sectors as an indicator for discard
support, similar to what is done for write zeroes.

The only places where needs special attention is the RAID5 driver,
which must clear discard support for security reasons by default,
even if the default stacking rules would allow for it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [btrfs]
Acked-by: Coly Li <colyli@suse.de> [bcache]
---
 arch/um/drivers/ubd_kern.c          |  2 --
 block/blk-core.c                    |  2 +-
 block/blk-lib.c                     |  2 +-
 block/blk-mq-debugfs.c              |  1 -
 block/ioctl.c                       |  3 +--
 drivers/block/drbd/drbd_main.c      |  2 +-
 drivers/block/drbd/drbd_nl.c        | 19 ++-----------------
 drivers/block/drbd/drbd_receiver.c  |  3 +--
 drivers/block/loop.c                | 11 +++--------
 drivers/block/nbd.c                 |  5 +----
 drivers/block/null_blk/main.c       |  1 -
 drivers/block/rbd.c                 |  1 -
 drivers/block/rnbd/rnbd-clt.c       |  2 --
 drivers/block/rnbd/rnbd-srv-dev.h   |  3 ---
 drivers/block/virtio_blk.c          |  2 --
 drivers/block/xen-blkback/xenbus.c  |  2 +-
 drivers/block/xen-blkfront.c        |  2 --
 drivers/block/zram/zram_drv.c       |  1 -
 drivers/md/bcache/request.c         |  4 ++--
 drivers/md/bcache/super.c           |  3 +--
 drivers/md/bcache/sysfs.c           |  2 +-
 drivers/md/dm-cache-target.c        |  9 +--------
 drivers/md/dm-clone-target.c        |  9 +--------
 drivers/md/dm-log-writes.c          |  3 +--
 drivers/md/dm-raid.c                |  9 ++-------
 drivers/md/dm-table.c               |  9 ++-------
 drivers/md/dm-thin.c                | 11 +----------
 drivers/md/dm.c                     |  3 +--
 drivers/md/md-linear.c              | 11 +----------
 drivers/md/raid0.c                  |  7 -------
 drivers/md/raid1.c                  | 16 +---------------
 drivers/md/raid10.c                 | 18 ++----------------
 drivers/md/raid5-cache.c            |  2 +-
 drivers/md/raid5.c                  | 12 ++++--------
 drivers/mmc/core/queue.c            |  1 -
 drivers/mtd/mtd_blkdevs.c           |  1 -
 drivers/nvme/host/core.c            |  6 ++----
 drivers/s390/block/dasd_fba.c       |  1 -
 drivers/scsi/sd.c                   |  2 --
 drivers/target/target_core_device.c |  2 +-
 fs/btrfs/extent-tree.c              |  4 ++--
 fs/btrfs/ioctl.c                    |  2 +-
 fs/exfat/file.c                     |  2 +-
 fs/exfat/super.c                    | 10 +++-------
 fs/ext4/ioctl.c                     | 10 +++-------
 fs/ext4/super.c                     | 10 +++-------
 fs/f2fs/f2fs.h                      |  3 +--
 fs/fat/file.c                       |  2 +-
 fs/fat/inode.c                      | 10 +++-------
 fs/gfs2/rgrp.c                      |  2 +-
 fs/jbd2/journal.c                   |  7 ++-----
 fs/jfs/ioctl.c                      |  2 +-
 fs/jfs/super.c                      |  8 ++------
 fs/nilfs2/ioctl.c                   |  2 +-
 fs/ntfs3/file.c                     |  2 +-
 fs/ntfs3/super.c                    |  2 +-
 fs/ocfs2/ioctl.c                    |  2 +-
 fs/xfs/xfs_discard.c                |  2 +-
 fs/xfs/xfs_super.c                  | 12 ++++--------
 include/linux/blkdev.h              |  2 --
 mm/swapfile.c                       | 17 ++---------------
 61 files changed, 72 insertions(+), 246 deletions(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index b03269faef714..085ffdf98e57e 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -483,7 +483,6 @@ static void ubd_handler(void)
 			if ((io_req->error == BLK_STS_NOTSUPP) && (req_op(io_req->req) == REQ_OP_DISCARD)) {
 				blk_queue_max_discard_sectors(io_req->req->q, 0);
 				blk_queue_max_write_zeroes_sectors(io_req->req->q, 0);
-				blk_queue_flag_clear(QUEUE_FLAG_DISCARD, io_req->req->q);
 			}
 			blk_mq_end_request(io_req->req, io_req->error);
 			kfree(io_req);
@@ -803,7 +802,6 @@ static int ubd_open_dev(struct ubd *ubd_dev)
 		ubd_dev->queue->limits.discard_alignment = SECTOR_SIZE;
 		blk_queue_max_discard_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
 		blk_queue_max_write_zeroes_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, ubd_dev->queue);
 	}
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, ubd_dev->queue);
 	return 0;
diff --git a/block/blk-core.c b/block/blk-core.c
index 937bb6b863317..b5c3a8049134c 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -820,7 +820,7 @@ void submit_bio_noacct(struct bio *bio)
 
 	switch (bio_op(bio)) {
 	case REQ_OP_DISCARD:
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(bdev))
 			goto not_supported;
 		break;
 	case REQ_OP_SECURE_ERASE:
diff --git a/block/blk-lib.c b/block/blk-lib.c
index 2ae32a722851c..8b4b66d3a9bfc 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -53,7 +53,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 			return -EOPNOTSUPP;
 		op = REQ_OP_SECURE_ERASE;
 	} else {
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(bdev))
 			return -EOPNOTSUPP;
 		op = REQ_OP_DISCARD;
 	}
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index aa0349e9f083b..fd111c5001256 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -113,7 +113,6 @@ static const char *const blk_queue_flag_name[] = {
 	QUEUE_FLAG_NAME(FAIL_IO),
 	QUEUE_FLAG_NAME(NONROT),
 	QUEUE_FLAG_NAME(IO_STAT),
-	QUEUE_FLAG_NAME(DISCARD),
 	QUEUE_FLAG_NAME(NOXMERGES),
 	QUEUE_FLAG_NAME(ADD_RANDOM),
 	QUEUE_FLAG_NAME(SECERASE),
diff --git a/block/ioctl.c b/block/ioctl.c
index ad3771b268b81..c2cd3ba5290ce 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -87,14 +87,13 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
 {
 	uint64_t range[2];
 	uint64_t start, len;
-	struct request_queue *q = bdev_get_queue(bdev);
 	struct inode *inode = bdev->bd_inode;
 	int err;
 
 	if (!(mode & FMODE_WRITE))
 		return -EBADF;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(range, (void __user *)arg, sizeof(range)))
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index eae629c4f6eaf..a69475e592822 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -942,7 +942,7 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 			cpu_to_be32(bdev_alignment_offset(bdev));
 		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
 		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
-		p->qlim->discard_enabled = blk_queue_discard(q);
+		p->qlim->discard_enabled = !!bdev_max_discard_sectors(bdev);
 		put_ldev(device);
 	} else {
 		struct request_queue *q = device->rq_queue;
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index d4dacc329ac2e..b55e5fcc21e1f 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1210,7 +1210,7 @@ static void decide_on_discard_support(struct drbd_device *device,
 		first_peer_device(device)->connection;
 	struct request_queue *q = device->rq_queue;
 
-	if (bdev && !blk_queue_discard(bdev->backing_bdev->bd_disk->queue))
+	if (bdev && !bdev_max_discard_sectors(bdev->backing_bdev))
 		goto not_supported;
 
 	if (connection->cstate >= C_CONNECTED &&
@@ -1230,30 +1230,16 @@ static void decide_on_discard_support(struct drbd_device *device,
 	 */
 	blk_queue_discard_granularity(q, 512);
 	q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	q->limits.max_write_zeroes_sectors =
 		drbd_max_discard_sectors(connection);
 	return;
 
 not_supported:
-	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 	blk_queue_discard_granularity(q, 0);
 	q->limits.max_discard_sectors = 0;
 	q->limits.max_write_zeroes_sectors = 0;
 }
 
-static void fixup_discard_if_not_supported(struct request_queue *q)
-{
-	/* To avoid confusion, if this queue does not support discard, clear
-	 * max_discard_sectors, which is what lsblk -D reports to the user.
-	 * Older kernels got this wrong in "stack limits".
-	 * */
-	if (!blk_queue_discard(q)) {
-		blk_queue_max_discard_sectors(q, 0);
-		blk_queue_discard_granularity(q, 0);
-	}
-}
-
 static void fixup_write_zeroes(struct drbd_device *device, struct request_queue *q)
 {
 	/* Fixup max_write_zeroes_sectors after blk_stack_limits():
@@ -1300,7 +1286,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 		blk_stack_limits(&q->limits, &b->limits, 0);
 		disk_update_readahead(device->vdisk);
 	}
-	fixup_discard_if_not_supported(q);
 	fixup_write_zeroes(device, q);
 }
 
@@ -1447,7 +1432,7 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 	if (disk_conf->al_extents > drbd_al_extents_max(nbc))
 		disk_conf->al_extents = drbd_al_extents_max(nbc);
 
-	if (!blk_queue_discard(q)) {
+	if (!bdev_max_discard_sectors(bdev)) {
 		if (disk_conf->rs_discard_granularity) {
 			disk_conf->rs_discard_granularity = 0; /* disable feature */
 			drbd_info(device, "rs_discard_granularity feature disabled\n");
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 0b4c7de463989..8a4a47da56fe9 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1575,11 +1575,10 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 
 static bool can_do_reliable_discards(struct drbd_device *device)
 {
-	struct request_queue *q = bdev_get_queue(device->ldev->backing_bdev);
 	struct disk_conf *dc;
 	bool can_do;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(device->ldev->backing_bdev))
 		return false;
 
 	rcu_read_lock();
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 8d800d46e4985..0e061c9896eff 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -314,15 +314,12 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
 
 	mode |= FALLOC_FL_KEEP_SIZE;
 
-	if (!blk_queue_discard(lo->lo_queue)) {
-		ret = -EOPNOTSUPP;
-		goto out;
-	}
+	if (!bdev_max_discard_sectors(lo->lo_device))
+		return -EOPNOTSUPP;
 
 	ret = file->f_op->fallocate(file, mode, pos, blk_rq_bytes(rq));
 	if (unlikely(ret && ret != -EINVAL && ret != -EOPNOTSUPP))
-		ret = -EIO;
- out:
+		return -EIO;
 	return ret;
 }
 
@@ -787,12 +784,10 @@ static void loop_config_discard(struct loop_device *lo)
 		q->limits.discard_granularity = granularity;
 		blk_queue_max_discard_sectors(q, max_discard_sectors);
 		blk_queue_max_write_zeroes_sectors(q, max_discard_sectors);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	} else {
 		q->limits.discard_granularity = 0;
 		blk_queue_max_discard_sectors(q, 0);
 		blk_queue_max_write_zeroes_sectors(q, 0);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 	}
 	q->limits.discard_alignment = 0;
 }
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 5a1f98494dddf..4729aef8c6462 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1231,8 +1231,6 @@ static void nbd_parse_flags(struct nbd_device *nbd)
 		set_disk_ro(nbd->disk, true);
 	else
 		set_disk_ro(nbd->disk, false);
-	if (config->flags & NBD_FLAG_SEND_TRIM)
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, nbd->disk->queue);
 	if (config->flags & NBD_FLAG_SEND_FLUSH) {
 		if (config->flags & NBD_FLAG_SEND_FUA)
 			blk_queue_write_cache(nbd->disk->queue, true, true);
@@ -1319,8 +1317,7 @@ static void nbd_config_put(struct nbd_device *nbd)
 		nbd->tag_set.timeout = 0;
 		nbd->disk->queue->limits.discard_granularity = 0;
 		nbd->disk->queue->limits.discard_alignment = 0;
-		blk_queue_max_discard_sectors(nbd->disk->queue, UINT_MAX);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, nbd->disk->queue);
+		blk_queue_max_discard_sectors(nbd->disk->queue, 0);
 
 		mutex_unlock(&nbd->config_lock);
 		nbd_put(nbd);
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 05b1120e66234..f6493a9e85ed3 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1767,7 +1767,6 @@ static void null_config_discard(struct nullb *nullb)
 	nullb->q->limits.discard_granularity = nullb->dev->blocksize;
 	nullb->q->limits.discard_alignment = nullb->dev->blocksize;
 	blk_queue_max_discard_sectors(nullb->q, UINT_MAX >> 9);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, nullb->q);
 }
 
 static const struct block_device_operations null_bio_ops = {
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index b844432bad20b..2b21f717cce1a 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -4942,7 +4942,6 @@ static int rbd_init_disk(struct rbd_device *rbd_dev)
 	blk_queue_io_opt(q, rbd_dev->opts->alloc_size);
 
 	if (rbd_dev->opts->trim) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 		q->limits.discard_granularity = rbd_dev->opts->alloc_size;
 		blk_queue_max_discard_sectors(q, objset_bytes >> SECTOR_SHIFT);
 		blk_queue_max_write_zeroes_sectors(q, objset_bytes >> SECTOR_SHIFT);
diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index b66e8840b94b8..efa99a3884507 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1364,8 +1364,6 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
 	blk_queue_max_discard_sectors(dev->queue, dev->max_discard_sectors);
 	dev->queue->limits.discard_granularity	= dev->discard_granularity;
 	dev->queue->limits.discard_alignment	= dev->discard_alignment;
-	if (dev->max_discard_sectors)
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, dev->queue);
 	if (dev->secure_discard)
 		blk_queue_flag_set(QUEUE_FLAG_SECERASE, dev->queue);
 
diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index f82fbb4bbda8e..1f7e1c8fd4d9b 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -49,9 +49,6 @@ static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
 
 static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
 {
-	if (!blk_queue_discard(bdev_get_queue(dev->bdev)))
-		return 0;
-
 	return bdev_max_discard_sectors(dev->bdev);
 }
 
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index a8bcf3f664af1..6ccf15253dee1 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -888,8 +888,6 @@ static int virtblk_probe(struct virtio_device *vdev)
 			v = sg_elems;
 		blk_queue_max_discard_segments(q,
 					       min(v, MAX_DISCARD_SEGMENTS));
-
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	}
 
 	if (virtio_has_feature(vdev, VIRTIO_BLK_F_WRITE_ZEROES)) {
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 8b691fe50475f..83cd08041e6b3 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -583,7 +583,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
 	if (!xenbus_read_unsigned(dev->nodename, "discard-enable", 1))
 		return;
 
-	if (blk_queue_discard(q)) {
+	if (bdev_max_discard_sectors(bdev)) {
 		err = xenbus_printf(xbt, dev->nodename,
 			"discard-granularity", "%u",
 			q->limits.discard_granularity);
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 003056d4f7f5f..253bf835aca1f 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -944,7 +944,6 @@ static void blkif_set_queue_limits(struct blkfront_info *info)
 	blk_queue_flag_set(QUEUE_FLAG_VIRT, rq);
 
 	if (info->feature_discard) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, rq);
 		blk_queue_max_discard_sectors(rq, get_capacity(gd));
 		rq->limits.discard_granularity = info->discard_granularity ?:
 						 info->physical_sector_size;
@@ -1606,7 +1605,6 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
 				blkif_req(req)->error = BLK_STS_NOTSUPP;
 				info->feature_discard = 0;
 				info->feature_secdiscard = 0;
-				blk_queue_flag_clear(QUEUE_FLAG_DISCARD, rq);
 				blk_queue_flag_clear(QUEUE_FLAG_SECERASE, rq);
 			}
 			break;
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index e9474b02012de..59ff444bf6c76 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1952,7 +1952,6 @@ static int zram_add(void)
 	blk_queue_io_opt(zram->disk->queue, PAGE_SIZE);
 	zram->disk->queue->limits.discard_granularity = PAGE_SIZE;
 	blk_queue_max_discard_sectors(zram->disk->queue, UINT_MAX);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, zram->disk->queue);
 
 	/*
 	 * zram_bio_discard() will clear all logical blocks if logical block
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index fdd0194f84dd0..e27f67f06a428 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1005,7 +1005,7 @@ static void cached_dev_write(struct cached_dev *dc, struct search *s)
 		bio_get(s->iop.bio);
 
 		if (bio_op(bio) == REQ_OP_DISCARD &&
-		    !blk_queue_discard(bdev_get_queue(dc->bdev)))
+		    !bdev_max_discard_sectors(dc->bdev))
 			goto insert_data;
 
 		/* I/O request sent to backing device */
@@ -1115,7 +1115,7 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
 	bio->bi_private = ddip;
 
 	if ((bio_op(bio) == REQ_OP_DISCARD) &&
-	    !blk_queue_discard(bdev_get_queue(dc->bdev)))
+	    !bdev_max_discard_sectors(dc->bdev))
 		bio->bi_end_io(bio);
 	else
 		submit_bio_noacct(bio);
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index bf3de149d3c9f..2f49e31142f62 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -973,7 +973,6 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
 
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, d->disk->queue);
 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, d->disk->queue);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, d->disk->queue);
 
 	blk_queue_write_cache(q, true, true);
 
@@ -2350,7 +2349,7 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
 	ca->bdev->bd_holder = ca;
 	ca->sb_disk = sb_disk;
 
-	if (blk_queue_discard(bdev_get_queue(bdev)))
+	if (bdev_max_discard_sectors((bdev)))
 		ca->discard = CACHE_DISCARD(&ca->sb);
 
 	ret = cache_alloc(ca);
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index d1029d71ff3bc..c6f677059214d 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -1151,7 +1151,7 @@ STORE(__bch_cache)
 	if (attr == &sysfs_discard) {
 		bool v = strtoul_or_return(buf);
 
-		if (blk_queue_discard(bdev_get_queue(ca->bdev)))
+		if (bdev_max_discard_sectors(ca->bdev))
 			ca->discard = v;
 
 		if (v != CACHE_DISCARD(&ca->sb)) {
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 780a61bc6cc03..28c5de8eca4a0 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -3329,13 +3329,6 @@ static int cache_iterate_devices(struct dm_target *ti,
 	return r;
 }
 
-static bool origin_dev_supports_discard(struct block_device *origin_bdev)
-{
-	struct request_queue *q = bdev_get_queue(origin_bdev);
-
-	return blk_queue_discard(q);
-}
-
 /*
  * If discard_passdown was enabled verify that the origin device
  * supports discards.  Disable discard_passdown if not.
@@ -3349,7 +3342,7 @@ static void disable_passdown_if_not_supported(struct cache *cache)
 	if (!cache->features.discard_passdown)
 		return;
 
-	if (!origin_dev_supports_discard(origin_bdev))
+	if (!bdev_max_discard_sectors(origin_bdev))
 		reason = "discard unsupported";
 
 	else if (origin_limits->max_discard_sectors < cache->sectors_per_block)
diff --git a/drivers/md/dm-clone-target.c b/drivers/md/dm-clone-target.c
index 128316a73d016..811b0a5379d03 100644
--- a/drivers/md/dm-clone-target.c
+++ b/drivers/md/dm-clone-target.c
@@ -2016,13 +2016,6 @@ static void clone_resume(struct dm_target *ti)
 	do_waker(&clone->waker.work);
 }
 
-static bool bdev_supports_discards(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	return (q && blk_queue_discard(q));
-}
-
 /*
  * If discard_passdown was enabled verify that the destination device supports
  * discards. Disable discard_passdown if not.
@@ -2036,7 +2029,7 @@ static void disable_passdown_if_not_supported(struct clone *clone)
 	if (!test_bit(DM_CLONE_DISCARD_PASSDOWN, &clone->flags))
 		return;
 
-	if (!bdev_supports_discards(dest_dev))
+	if (!bdev_max_discard_sectors(dest_dev))
 		reason = "discard unsupported";
 	else if (dest_limits->max_discard_sectors < clone->region_size)
 		reason = "max discard sectors smaller than a region";
diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
index c9d036d6bb2ee..e194226c89e54 100644
--- a/drivers/md/dm-log-writes.c
+++ b/drivers/md/dm-log-writes.c
@@ -866,9 +866,8 @@ static int log_writes_message(struct dm_target *ti, unsigned argc, char **argv,
 static void log_writes_io_hints(struct dm_target *ti, struct queue_limits *limits)
 {
 	struct log_writes_c *lc = ti->private;
-	struct request_queue *q = bdev_get_queue(lc->dev->bdev);
 
-	if (!q || !blk_queue_discard(q)) {
+	if (!bdev_max_discard_sectors(lc->dev->bdev)) {
 		lc->device_supports_discard = false;
 		limits->discard_granularity = lc->sectorsize;
 		limits->max_discard_sectors = (UINT_MAX >> SECTOR_SHIFT);
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 2b26435a6946e..9526ccbedafba 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2963,13 +2963,8 @@ static void configure_discard_support(struct raid_set *rs)
 	raid456 = rs_is_raid456(rs);
 
 	for (i = 0; i < rs->raid_disks; i++) {
-		struct request_queue *q;
-
-		if (!rs->dev[i].rdev.bdev)
-			continue;
-
-		q = bdev_get_queue(rs->dev[i].rdev.bdev);
-		if (!q || !blk_queue_discard(q))
+		if (!rs->dev[i].rdev.bdev ||
+		    !bdev_max_discard_sectors(rs->dev[i].rdev.bdev))
 			return;
 
 		if (raid456) {
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index d46839faa0ca5..0dff6907fd00d 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1888,9 +1888,7 @@ static bool dm_table_supports_nowait(struct dm_table *t)
 static int device_not_discard_capable(struct dm_target *ti, struct dm_dev *dev,
 				      sector_t start, sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_discard(q);
+	return !bdev_max_discard_sectors(dev->bdev);
 }
 
 static bool dm_table_supports_discards(struct dm_table *t)
@@ -1970,15 +1968,12 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
 		blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);
 
 	if (!dm_table_supports_discards(t)) {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
-		/* Must also clear discard limits... */
 		q->limits.max_discard_sectors = 0;
 		q->limits.max_hw_discard_sectors = 0;
 		q->limits.discard_granularity = 0;
 		q->limits.discard_alignment = 0;
 		q->limits.discard_misaligned = 0;
-	} else
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
+	}
 
 	if (dm_table_supports_secure_erase(t))
 		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index 4d25d0e270313..eded4bcc4545f 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -2802,13 +2802,6 @@ static void requeue_bios(struct pool *pool)
 /*----------------------------------------------------------------
  * Binding of control targets to a pool object
  *--------------------------------------------------------------*/
-static bool data_dev_supports_discard(struct pool_c *pt)
-{
-	struct request_queue *q = bdev_get_queue(pt->data_dev->bdev);
-
-	return blk_queue_discard(q);
-}
-
 static bool is_factor(sector_t block_size, uint32_t n)
 {
 	return !sector_div(block_size, n);
@@ -2828,7 +2821,7 @@ static void disable_passdown_if_not_supported(struct pool_c *pt)
 	if (!pt->adjusted_pf.discard_passdown)
 		return;
 
-	if (!data_dev_supports_discard(pt))
+	if (!bdev_max_discard_sectors(pt->data_dev->bdev))
 		reason = "discard unsupported";
 
 	else if (data_limits->max_discard_sectors < pool->sectors_per_block)
@@ -4057,8 +4050,6 @@ static void pool_io_hints(struct dm_target *ti, struct queue_limits *limits)
 		/*
 		 * Must explicitly disallow stacking discard limits otherwise the
 		 * block layer will stack them if pool's data device has support.
-		 * QUEUE_FLAG_DISCARD wouldn't be set but there is no way for the
-		 * user to see that, so make sure to set all discard limits to 0.
 		 */
 		limits->discard_granularity = 0;
 		return;
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 3c5fad7c4ee68..dbbf64ce7e927 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -955,7 +955,6 @@ void disable_discard(struct mapped_device *md)
 
 	/* device doesn't really support DISCARD, disable it */
 	limits->max_discard_sectors = 0;
-	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, md->queue);
 }
 
 void disable_write_zeroes(struct mapped_device *md)
@@ -982,7 +981,7 @@ static void clone_endio(struct bio *bio)
 
 	if (unlikely(error == BLK_STS_TARGET)) {
 		if (bio_op(bio) == REQ_OP_DISCARD &&
-		    !q->limits.max_discard_sectors)
+		    !bdev_max_discard_sectors(bio->bi_bdev))
 			disable_discard(md);
 		else if (bio_op(bio) == REQ_OP_WRITE_ZEROES &&
 			 !q->limits.max_write_zeroes_sectors)
diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
index 0f55b079371b1..138a3b25c5c82 100644
--- a/drivers/md/md-linear.c
+++ b/drivers/md/md-linear.c
@@ -64,7 +64,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 	struct linear_conf *conf;
 	struct md_rdev *rdev;
 	int i, cnt;
-	bool discard_supported = false;
 
 	conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL);
 	if (!conf)
@@ -96,9 +95,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 
 		conf->array_sectors += rdev->sectors;
 		cnt++;
-
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
-			discard_supported = true;
 	}
 	if (cnt != raid_disks) {
 		pr_warn("md/linear:%s: not enough drives present. Aborting!\n",
@@ -106,11 +102,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 		goto out;
 	}
 
-	if (!discard_supported)
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, mddev->queue);
-	else
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
-
 	/*
 	 * Here we calculate the device offsets.
 	 */
@@ -252,7 +243,7 @@ static bool linear_make_request(struct mddev *mddev, struct bio *bio)
 		start_sector + data_offset;
 
 	if (unlikely((bio_op(bio) == REQ_OP_DISCARD) &&
-		     !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) {
+		     !bdev_max_discard_sectors(bio->bi_bdev))) {
 		/* Just ignore it */
 		bio_endio(bio);
 	} else {
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index b21e101183f44..7231f5e1eaa73 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -399,7 +399,6 @@ static int raid0_run(struct mddev *mddev)
 	conf = mddev->private;
 	if (mddev->queue) {
 		struct md_rdev *rdev;
-		bool discard_supported = false;
 
 		blk_queue_max_hw_sectors(mddev->queue, mddev->chunk_sectors);
 		blk_queue_max_write_zeroes_sectors(mddev->queue, mddev->chunk_sectors);
@@ -412,13 +411,7 @@ static int raid0_run(struct mddev *mddev)
 		rdev_for_each(rdev, mddev) {
 			disk_stack_limits(mddev->gendisk, rdev->bdev,
 					  rdev->data_offset << 9);
-			if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
-				discard_supported = true;
 		}
-		if (!discard_supported)
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD, mddev->queue);
-		else
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 	}
 
 	/* calculate array device size */
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index d81b896855f9f..3da749d150a17 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -802,7 +802,7 @@ static void flush_bio_list(struct r1conf *conf, struct bio *bio)
 		if (test_bit(Faulty, &rdev->flags)) {
 			bio_io_error(bio);
 		} else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) &&
-				    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+				    !bdev_max_discard_sectors(bio->bi_bdev)))
 			/* Just ignore it */
 			bio_endio(bio);
 		else
@@ -1826,8 +1826,6 @@ static int raid1_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 			break;
 		}
 	}
-	if (mddev->queue && blk_queue_discard(bdev_get_queue(rdev->bdev)))
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 	print_conf(conf);
 	return err;
 }
@@ -3106,7 +3104,6 @@ static int raid1_run(struct mddev *mddev)
 	int i;
 	struct md_rdev *rdev;
 	int ret;
-	bool discard_supported = false;
 
 	if (mddev->level != 1) {
 		pr_warn("md/raid1:%s: raid level not set to mirroring (%d)\n",
@@ -3141,8 +3138,6 @@ static int raid1_run(struct mddev *mddev)
 			continue;
 		disk_stack_limits(mddev->gendisk, rdev->bdev,
 				  rdev->data_offset << 9);
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
-			discard_supported = true;
 	}
 
 	mddev->degraded = 0;
@@ -3179,15 +3174,6 @@ static int raid1_run(struct mddev *mddev)
 
 	md_set_array_sectors(mddev, raid1_size(mddev, 0, 0));
 
-	if (mddev->queue) {
-		if (discard_supported)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						  mddev->queue);
-	}
-
 	ret = md_integrity_register(mddev);
 	if (ret) {
 		md_unregister_thread(&mddev->thread);
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 7816c8b2e8087..36a460015cf58 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -888,7 +888,7 @@ static void flush_pending_writes(struct r10conf *conf)
 			if (test_bit(Faulty, &rdev->flags)) {
 				bio_io_error(bio);
 			} else if (unlikely((bio_op(bio) ==  REQ_OP_DISCARD) &&
-					    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+					    !bdev_max_discard_sectors(bio->bi_bdev)))
 				/* Just ignore it */
 				bio_endio(bio);
 			else
@@ -1083,7 +1083,7 @@ static void raid10_unplug(struct blk_plug_cb *cb, bool from_schedule)
 		if (test_bit(Faulty, &rdev->flags)) {
 			bio_io_error(bio);
 		} else if (unlikely((bio_op(bio) ==  REQ_OP_DISCARD) &&
-				    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+				    !bdev_max_discard_sectors(bio->bi_bdev)))
 			/* Just ignore it */
 			bio_endio(bio);
 		else
@@ -2144,8 +2144,6 @@ static int raid10_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 		rcu_assign_pointer(p->rdev, rdev);
 		break;
 	}
-	if (mddev->queue && blk_queue_discard(bdev_get_queue(rdev->bdev)))
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 
 	print_conf(conf);
 	return err;
@@ -4069,7 +4067,6 @@ static int raid10_run(struct mddev *mddev)
 	sector_t size;
 	sector_t min_offset_diff = 0;
 	int first = 1;
-	bool discard_supported = false;
 
 	if (mddev_init_writes_pending(mddev) < 0)
 		return -ENOMEM;
@@ -4140,20 +4137,9 @@ static int raid10_run(struct mddev *mddev)
 					  rdev->data_offset << 9);
 
 		disk->head_position = 0;
-
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
-			discard_supported = true;
 		first = 0;
 	}
 
-	if (mddev->queue) {
-		if (discard_supported)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						  mddev->queue);
-	}
 	/* need to check that every block has at least one working mirror */
 	if (!enough(conf, -1)) {
 		pr_err("md/raid10:%s: not enough operational mirrors.\n",
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index a7d50ff9020a8..c3cbf9a574a39 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1318,7 +1318,7 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
 
 	r5l_write_super(log, end);
 
-	if (!blk_queue_discard(bdev_get_queue(bdev)))
+	if (!bdev_max_discard_sectors(bdev))
 		return;
 
 	mddev = log->rdev->mddev;
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 0bbae0e638666..59f91e392a2ae 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7776,14 +7776,10 @@ static int raid5_run(struct mddev *mddev)
 		 * A better idea might be to turn DISCARD into WRITE_ZEROES
 		 * requests, as that is required to be safe.
 		 */
-		if (devices_handle_discard_safely &&
-		    mddev->queue->limits.max_discard_sectors >= (stripe >> 9) &&
-		    mddev->queue->limits.discard_granularity >= stripe)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						mddev->queue);
+		if (!devices_handle_discard_safely ||
+		    mddev->queue->limits.max_discard_sectors < (stripe >> 9) ||
+		    mddev->queue->limits.discard_granularity < stripe)
+			blk_queue_max_discard_sectors(mddev->queue, 0);
 
 		blk_queue_max_hw_sectors(mddev->queue, UINT_MAX);
 	}
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index c69b2d9df6f16..cac6315010a3d 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -183,7 +183,6 @@ static void mmc_queue_setup_discard(struct request_queue *q,
 	if (!max_discard)
 		return;
 
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	blk_queue_max_discard_sectors(q, max_discard);
 	q->limits.discard_granularity = card->pref_erase << 9;
 	/* granularity must not be greater than max. discard */
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 64d2b093f114b..f731721114655 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -377,7 +377,6 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, new->rq);
 
 	if (tr->discard) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, new->rq);
 		blk_queue_max_discard_sectors(new->rq, UINT_MAX);
 		new->rq->limits.discard_granularity = tr->blksize;
 	}
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index efb85c6d8e2d5..7e07dd69262a7 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1607,10 +1607,8 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
 	struct request_queue *queue = disk->queue;
 	u32 size = queue_logical_block_size(queue);
 
-	if (ctrl->max_discard_sectors == 0) {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, queue);
+	if (ctrl->max_discard_sectors == 0)
 		return;
-	}
 
 	BUILD_BUG_ON(PAGE_SIZE / sizeof(struct nvme_dsm_range) <
 			NVME_DSM_MAX_RANGES);
@@ -1619,7 +1617,7 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
 	queue->limits.discard_granularity = size;
 
 	/* If discard is already enabled, don't reset queue limits */
-	if (blk_queue_flag_test_and_set(QUEUE_FLAG_DISCARD, queue))
+	if (queue->limits.max_discard_sectors)
 		return;
 
 	blk_queue_max_discard_sectors(queue, ctrl->max_discard_sectors);
diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c
index e084f4deddddd..8bd5665db9198 100644
--- a/drivers/s390/block/dasd_fba.c
+++ b/drivers/s390/block/dasd_fba.c
@@ -791,7 +791,6 @@ static void dasd_fba_setup_blk_queue(struct dasd_block *block)
 
 	blk_queue_max_discard_sectors(q, max_discard_sectors);
 	blk_queue_max_write_zeroes_sectors(q, max_discard_sectors);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 }
 
 static int dasd_fba_pe_handler(struct dasd_device *device,
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index a390679cf4584..444479657b7fd 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -797,7 +797,6 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
 	case SD_LBP_FULL:
 	case SD_LBP_DISABLE:
 		blk_queue_max_discard_sectors(q, 0);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 		return;
 
 	case SD_LBP_UNMAP:
@@ -830,7 +829,6 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
 	}
 
 	blk_queue_max_discard_sectors(q, max_blocks * (logical_block_size >> 9));
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 }
 
 static blk_status_t sd_setup_unmap_cmnd(struct scsi_cmnd *cmd)
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index c3e25bac90d59..6cb9f87843278 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -838,7 +838,7 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	struct request_queue *q = bdev_get_queue(bdev);
 	int block_size = bdev_logical_block_size(bdev);
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(bdev))
 		return false;
 
 	attrib->max_unmap_lba_count =
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index f477035a2ac23..efd8deb3ab7e8 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1291,7 +1291,7 @@ static int do_discard_extent(struct btrfs_io_stripe *stripe, u64 *bytes)
 		ret = btrfs_reset_device_zone(dev_replace->tgtdev, phys, len,
 					      &discarded);
 		discarded += src_disc;
-	} else if (blk_queue_discard(bdev_get_queue(stripe->dev->bdev))) {
+	} else if (bdev_max_discard_sectors(stripe->dev->bdev)) {
 		ret = btrfs_issue_discard(dev->bdev, phys, len, &discarded);
 	} else {
 		ret = 0;
@@ -5987,7 +5987,7 @@ static int btrfs_trim_free_extents(struct btrfs_device *device, u64 *trimmed)
 	*trimmed = 0;
 
 	/* Discard not supported = nothing to do. */
-	if (!blk_queue_discard(bdev_get_queue(device->bdev)))
+	if (!bdev_max_discard_sectors(device->bdev))
 		return 0;
 
 	/* Not writable = nothing to do. */
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index f46e71061942d..096bb0da03f1c 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -501,7 +501,7 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 		if (!device->bdev)
 			continue;
 		q = bdev_get_queue(device->bdev);
-		if (blk_queue_discard(q)) {
+		if (bdev_max_discard_sectors(device->bdev)) {
 			num_devices++;
 			minlen = min_t(u64, q->limits.discard_granularity,
 				     minlen);
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 2f51300592366..765e4f63dd18d 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -358,7 +358,7 @@ static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(inode->i_sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&range, (struct fstrim_range __user *)arg, sizeof(range)))
diff --git a/fs/exfat/super.c b/fs/exfat/super.c
index 8ca21e7917d16..be0788ecaf20e 100644
--- a/fs/exfat/super.c
+++ b/fs/exfat/super.c
@@ -627,13 +627,9 @@ static int exfat_fill_super(struct super_block *sb, struct fs_context *fc)
 	if (opts->allow_utime == (unsigned short)-1)
 		opts->allow_utime = ~opts->fs_dmask & 0022;
 
-	if (opts->discard) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-
-		if (!blk_queue_discard(q)) {
-			exfat_warn(sb, "mounting with \"discard\" option, but the device does not support discard");
-			opts->discard = 0;
-		}
+	if (opts->discard && !bdev_max_discard_sectors(sb->s_bdev)) {
+		exfat_warn(sb, "mounting with \"discard\" option, but the device does not support discard");
+		opts->discard = 0;
 	}
 
 	sb->s_flags |= SB_NODIRATIME;
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 992229ca2d830..6e3b9eea126f4 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -1044,7 +1044,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
 	__u32 flags = 0;
 	unsigned int flush_flags = 0;
 	struct super_block *sb = file_inode(filp)->i_sb;
-	struct request_queue *q;
 
 	if (copy_from_user(&flags, (__u32 __user *)arg,
 				sizeof(__u32)))
@@ -1065,10 +1064,8 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
 	if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
 		return -EINVAL;
 
-	q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);
-	if (!q)
-		return -ENXIO;
-	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !blk_queue_discard(q))
+	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
+	    !bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev))
 		return -EOPNOTSUPP;
 
 	if (flags & EXT4_IOC_CHECKPOINT_FLAG_DRY_RUN)
@@ -1393,14 +1390,13 @@ static long __ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 
 	case FITRIM:
 	{
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		int ret = 0;
 
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(sb->s_bdev))
 			return -EOPNOTSUPP;
 
 		/*
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 81749eaddf4c1..93f4e4e9e2631 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5458,13 +5458,9 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
 			goto failed_mount9;
 	}
 
-	if (test_opt(sb, DISCARD)) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-		if (!blk_queue_discard(q))
-			ext4_msg(sb, KERN_WARNING,
-				 "mounting with \"discard\" option, but "
-				 "the device does not support discard");
-	}
+	if (test_opt(sb, DISCARD) && !bdev_max_discard_sectors(sb->s_bdev))
+		ext4_msg(sb, KERN_WARNING,
+			 "mounting with \"discard\" option, but the device does not support discard");
 
 	if (es->s_error_count)
 		mod_timer(&sbi->s_err_report, jiffies + 300*HZ); /* 5 minutes */
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index cd1e65bcf0b04..0ea9a5fa7c1dd 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4381,8 +4381,7 @@ static inline bool f2fs_hw_should_discard(struct f2fs_sb_info *sbi)
 
 static inline bool f2fs_bdev_support_discard(struct block_device *bdev)
 {
-	return blk_queue_discard(bdev_get_queue(bdev)) ||
-	       bdev_is_zoned(bdev);
+	return bdev_max_discard_sectors(bdev) || bdev_is_zoned(bdev);
 }
 
 static inline bool f2fs_hw_support_discard(struct f2fs_sb_info *sbi)
diff --git a/fs/fat/file.c b/fs/fat/file.c
index a5a309fcc7faf..e4c7d10e80129 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -133,7 +133,7 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	user_range = (struct fstrim_range __user *)arg;
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index bf6051bdf1d1d..3d1afb95a925a 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1872,13 +1872,9 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
 		goto out_fail;
 	}
 
-	if (sbi->options.discard) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-		if (!blk_queue_discard(q))
-			fat_msg(sb, KERN_WARNING,
-					"mounting with \"discard\" option, but "
-					"the device does not support discard");
-	}
+	if (sbi->options.discard && !bdev_max_discard_sectors(sb->s_bdev))
+		fat_msg(sb, KERN_WARNING,
+			"mounting with \"discard\" option, but the device does not support discard");
 
 	fat_set_state(sb, 1, 0);
 	return 0;
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 801ad9f4f2bef..7f20ac9133bc6 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1405,7 +1405,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
 		return -EROFS;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sdp->sd_vfs->s_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&r, argp, sizeof(r)))
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index fcacafa4510d1..19d226cd4ff4d 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1762,7 +1762,6 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 	unsigned long block, log_offset; /* logical */
 	unsigned long long phys_block, block_start, block_stop; /* physical */
 	loff_t byte_start, byte_stop, byte_count;
-	struct request_queue *q = bdev_get_queue(journal->j_dev);
 
 	/* flags must be set to either discard or zeroout */
 	if ((flags & ~JBD2_JOURNAL_FLUSH_VALID) || !flags ||
@@ -1770,10 +1769,8 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 			(flags & JBD2_JOURNAL_FLUSH_ZEROOUT)))
 		return -EINVAL;
 
-	if (!q)
-		return -ENXIO;
-
-	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !blk_queue_discard(q))
+	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
+	    !bdev_max_discard_sectors(journal->j_dev))
 		return -EOPNOTSUPP;
 
 	/*
diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
index 03a845ab4f009..357ae6e5c36ec 100644
--- a/fs/jfs/ioctl.c
+++ b/fs/jfs/ioctl.c
@@ -117,7 +117,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q)) {
+		if (!bdev_max_discard_sectors(sb->s_bdev)) {
 			jfs_warn("FITRIM not supported on device");
 			return -EOPNOTSUPP;
 		}
diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index f1a13a74cddf3..85d4f44f2ac4d 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -372,19 +372,16 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
 		}
 
 		case Opt_discard:
-		{
-			struct request_queue *q = bdev_get_queue(sb->s_bdev);
 			/* if set to 1, even copying files will cause
 			 * trimming :O
 			 * -> user has more control over the online trimming
 			 */
 			sbi->minblks_trim = 64;
-			if (blk_queue_discard(q))
+			if (bdev_max_discard_sectors(sb->s_bdev))
 				*flag |= JFS_DISCARD;
 			else
 				pr_err("JFS: discard option not supported on device\n");
 			break;
-		}
 
 		case Opt_nodiscard:
 			*flag &= ~JFS_DISCARD;
@@ -392,10 +389,9 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
 
 		case Opt_discard_minblk:
 		{
-			struct request_queue *q = bdev_get_queue(sb->s_bdev);
 			char *minblks_trim = args[0].from;
 			int rc;
-			if (blk_queue_discard(q)) {
+			if (bdev_max_discard_sectors(sb->s_bdev)) {
 				*flag |= JFS_DISCARD;
 				rc = kstrtouint(minblks_trim, 0,
 						&sbi->minblks_trim);
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
index fec194a666f4b..52b73f558fcb1 100644
--- a/fs/nilfs2/ioctl.c
+++ b/fs/nilfs2/ioctl.c
@@ -1059,7 +1059,7 @@ static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(nilfs->ns_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&range, argp, sizeof(range)))
diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index 787b53b984ee1..e763236169331 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -28,7 +28,7 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sbi->sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	user_range = (struct fstrim_range __user *)arg;
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index cd30e81abbce0..c734085bcce4a 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -913,7 +913,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	}
 
 	rq = bdev_get_queue(bdev);
-	if (blk_queue_discard(rq) && rq->limits.discard_granularity) {
+	if (bdev_max_discard_sectors(bdev) && rq->limits.discard_granularity) {
 		sbi->discard_granularity = rq->limits.discard_granularity;
 		sbi->discard_granularity_mask_inv =
 			~(u64)(sbi->discard_granularity - 1);
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index f59461d85da45..9b78ef103ada6 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -910,7 +910,7 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(sb->s_bdev))
 			return -EOPNOTSUPP;
 
 		if (copy_from_user(&range, argp, sizeof(range)))
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index 0191de8ce9ced..a4e6609d616b7 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -162,7 +162,7 @@ xfs_ioc_trim(
 
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(mp->m_ddev_targp->bt_bdev))
 		return -EOPNOTSUPP;
 
 	/*
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 54be9d64093ed..a276b8111f636 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1608,14 +1608,10 @@ xfs_fs_fill_super(
 			goto out_filestream_unmount;
 	}
 
-	if (xfs_has_discard(mp)) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-
-		if (!blk_queue_discard(q)) {
-			xfs_warn(mp, "mounting with \"discard\" option, but "
-					"the device does not support discard");
-			mp->m_features &= ~XFS_FEAT_DISCARD;
-		}
+	if (xfs_has_discard(mp) && !bdev_max_discard_sectors(sb->s_bdev)) {
+		xfs_warn(mp,
+	"mounting with \"discard\" option, but the device does not support discard");
+		mp->m_features &= ~XFS_FEAT_DISCARD;
 	}
 
 	if (xfs_has_reflink(mp)) {
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index ce16247d3afab..767ab22e1052a 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -540,7 +540,6 @@ struct request_queue {
 #define QUEUE_FLAG_NONROT	6	/* non-rotational device (SSD) */
 #define QUEUE_FLAG_VIRT		QUEUE_FLAG_NONROT /* paravirt device */
 #define QUEUE_FLAG_IO_STAT	7	/* do disk/partitions IO accounting */
-#define QUEUE_FLAG_DISCARD	8	/* supports DISCARD */
 #define QUEUE_FLAG_NOXMERGES	9	/* No extended merges */
 #define QUEUE_FLAG_ADD_RANDOM	10	/* Contributes to random pool */
 #define QUEUE_FLAG_SECERASE	11	/* supports secure erase */
@@ -582,7 +581,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 	test_bit(QUEUE_FLAG_STABLE_WRITES, &(q)->queue_flags)
 #define blk_queue_io_stat(q)	test_bit(QUEUE_FLAG_IO_STAT, &(q)->queue_flags)
 #define blk_queue_add_random(q)	test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
-#define blk_queue_discard(q)	test_bit(QUEUE_FLAG_DISCARD, &(q)->queue_flags)
 #define blk_queue_zone_resetall(q)	\
 	test_bit(QUEUE_FLAG_ZONE_RESETALL, &(q)->queue_flags)
 #define blk_queue_secure_erase(q) \
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 4069f17a82c8e..5d9cedf9e7b84 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2957,20 +2957,6 @@ static int setup_swap_map_and_extents(struct swap_info_struct *p,
 	return nr_extents;
 }
 
-/*
- * Helper to sys_swapon determining if a given swap
- * backing device queue supports DISCARD operations.
- */
-static bool swap_discardable(struct swap_info_struct *si)
-{
-	struct request_queue *q = bdev_get_queue(si->bdev);
-
-	if (!blk_queue_discard(q))
-		return false;
-
-	return true;
-}
-
 SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 {
 	struct swap_info_struct *p;
@@ -3132,7 +3118,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 					 sizeof(long),
 					 GFP_KERNEL);
 
-	if (p->bdev && (swap_flags & SWAP_FLAG_DISCARD) && swap_discardable(p)) {
+	if ((swap_flags & SWAP_FLAG_DISCARD) &&
+	    p->bdev && bdev_max_discard_sectors(p->bdev)) {
 		/*
 		 * When discard is enabled for swap with no particular
 		 * policy flagged, we set all swap discard flags here in
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301955.515497 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DI-0001NQ-D5; Sat, 09 Apr 2022 05:00:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301955.515497; Sat, 09 Apr 2022 05:00:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DH-0001MK-Vs; Sat, 09 Apr 2022 05:00:43 +0000
Received: by outflank-mailman (input) for mailman id 301955;
 Sat, 09 Apr 2022 05:00:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34k-0006gL-8H
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:54 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c6036906-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:53 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34Q-0020zD-BL; Sat, 09 Apr 2022 04:51:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6036906-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=2RG8/4DncVNJBVxiwRZlDWFw3of1TwdfVdHLgkB+Spw=; b=bHToJbTwXX9JeK0n0FFEHck7oK
	nA96qn4tsO9VvTxVN8oChK/ZngVrRM/0RF6G9ra3tv3c4LiSpAW93VdnTUb837bG7nj26lWP035AX
	+oB1LRxVd3o4RNZBzKIPVYYv/AqgqQH13jSTRjPJXLj+fHe3sQ7lQiOs0AqFOPiV0QvmbZSG1K8qh
	9AilEZ6nzAlZEnIp9Du8I20RfuJmhuvcocvyHX9G65n9qxdF8wS5MzRNFD9kn7Nula/Xd3cMLnifm
	ikockttcbAn2ou+cROly75gq/5PqLm1F2FPp9pVf438qn2667h4Aje3z8zrXhBCgwdMkGUyOJsCBu
	B0U5qlrw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 14/27] block: add a bdev_stable_writes helper
Date: Sat,  9 Apr 2022 06:50:30 +0200
Message-Id: <20220409045043.23593-15-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the stable writes flag based on the block_device
instead of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/md/dm-table.c  | 4 +---
 fs/super.c             | 2 +-
 include/linux/blkdev.h | 6 ++++++
 mm/swapfile.c          | 2 +-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 5e38d0dd009d5..d46839faa0ca5 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1950,9 +1950,7 @@ static int device_requires_stable_pages(struct dm_target *ti,
 					struct dm_dev *dev, sector_t start,
 					sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return blk_queue_stable_writes(q);
+	return bdev_stable_writes(dev->bdev);
 }
 
 int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
diff --git a/fs/super.c b/fs/super.c
index f1d4a193602d6..60f57c7bc0a69 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1204,7 +1204,7 @@ static int set_bdev_super(struct super_block *s, void *data)
 	s->s_dev = s->s_bdev->bd_dev;
 	s->s_bdi = bdi_get(s->s_bdev->bd_disk->bdi);
 
-	if (blk_queue_stable_writes(s->s_bdev->bd_disk->queue))
+	if (bdev_stable_writes(s->s_bdev))
 		s->s_iflags |= SB_I_STABLE_WRITES;
 	return 0;
 }
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 075b16d4560e7..a433798c3343e 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1330,6 +1330,12 @@ static inline bool bdev_nonrot(struct block_device *bdev)
 	return blk_queue_nonrot(bdev_get_queue(bdev));
 }
 
+static inline bool bdev_stable_writes(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_STABLE_WRITES,
+			&bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline bool bdev_write_cache(struct block_device *bdev)
 {
 	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index d5ab7ec4d92ca..4069f17a82c8e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -3065,7 +3065,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 		goto bad_swap_unlock_inode;
 	}
 
-	if (p->bdev && blk_queue_stable_writes(p->bdev->bd_disk->queue))
+	if (p->bdev && bdev_stable_writes(p->bdev))
 		p->flags |= SWP_STABLE_WRITES;
 
 	if (p->bdev && p->bdev->bd_disk->fops->rw_page)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301956.515501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DI-0001SN-SX; Sat, 09 Apr 2022 05:00:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301956.515501; Sat, 09 Apr 2022 05:00:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DI-0001QV-EC; Sat, 09 Apr 2022 05:00:44 +0000
Received: by outflank-mailman (input) for mailman id 301956;
 Sat, 09 Apr 2022 05:00:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd354-0006gF-Mr
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:14 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d22b6bce-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:52:14 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34k-0021Kt-TR; Sat, 09 Apr 2022 04:51:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d22b6bce-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=A3F4pzgWH2QQ0wtpIeTWEbWkE7zvp2Hf2SzUvBBV6uI=; b=eX3MLxgs7+LMLexFHqIdmiQ1Yi
	JdldSlm4poJNjPdmeRgScog9CyFDEOKE36j3Y8GOp25ZxOav5fY5REWK35ZSyRrUZZpvLOWxApha8
	AqMJ/MRcKr/CciLBe0jYueVDtJe90F1Pdg6qhOzgnLBHrJsW74l04GpKIl/5YuRS1FbaP4TBsToNP
	0GMgdPs2iWYbeYRMarbkSLZIEMdyAXHMZf+OWZlI5UmjWZF1rz7GghGKiiX6rIFIXD4QKrdrCfgbK
	fUs8lbnQ+FGDvl7FzdU6CQADQv8poqc/NeAD2tkAuI0L7ZIL5HeAN+izt/vpd0COwgfEQET8Ojz2e
	P5cDct/w==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 20/27] block: use bdev_discard_alignment in part_discard_alignment_show
Date: Sat,  9 Apr 2022 06:50:36 +0200
Message-Id: <20220409045043.23593-21-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based alignment helper instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/partitions/core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 240b3fff521e4..70dec1c78521d 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -206,11 +206,7 @@ static ssize_t part_alignment_offset_show(struct device *dev,
 static ssize_t part_discard_alignment_show(struct device *dev,
 					   struct device_attribute *attr, char *buf)
 {
-	struct block_device *bdev = dev_to_bdev(dev);
-
-	return sprintf(buf, "%u\n",
-		queue_limit_discard_alignment(&bdev_get_queue(bdev)->limits,
-				bdev->bd_start_sect));
+	return sprintf(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev)));
 }
 
 static DEVICE_ATTR(partition, 0444, part_partition_show, NULL);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301961.515516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DL-0001xl-4J; Sat, 09 Apr 2022 05:00:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301961.515516; Sat, 09 Apr 2022 05:00:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DK-0001wc-HX; Sat, 09 Apr 2022 05:00:46 +0000
Received: by outflank-mailman (input) for mailman id 301961;
 Sat, 09 Apr 2022 05:00:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd35Q-0006gL-QR
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:37 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id deaa5501-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:52:35 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd358-0021hI-T6; Sat, 09 Apr 2022 04:52:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: deaa5501-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=pVDwXB6PltgVZkC3rRdiaCUdLly1SPIvqpMIXjtbaqw=; b=jqUA+AmRXIWodbokKUQJY0RX0L
	3iRxTxojZgoAr0BJQ1ponT4HGyJF9P/dLKgG3mgDVBzT9ZC3GJ4VXksCd7CI4pp2deGOMuRnO4dJZ
	tYjvlBna5K+2SqqA4cHi6bHT3o1vwsbWhi8IrSk8cEbLbPYhU9Q1bHhBT4/6s3jRpSUTvMY8j6m9y
	ZXrNmSY5/qE17M860l2JtYPEp4Qs2IucObE64GZleGfFuLyLOimXHvRbrt+CUdmhLio0qwks9xvBt
	Vg5wC+6v6SCxOh06XmFFo2NPgfa5H4+lhNehhWJUBtAxZ5KuAcLte2n3q/5mzTUIyBnf71eMj2a2Y
	UapUGRFw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 25/27] block: add a bdev_discard_granularity helper
Date: Sat,  9 Apr 2022 06:50:41 +0200
Message-Id: <20220409045043.23593-26-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Abstract away implementation details from file systems by providing a
block_device based helper to retrieve the discard granularity.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [btrfs]
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 block/blk-lib.c                     |  5 ++---
 drivers/block/drbd/drbd_nl.c        |  9 +++++----
 drivers/block/drbd/drbd_receiver.c  |  3 +--
 drivers/block/loop.c                |  2 +-
 drivers/target/target_core_device.c |  3 +--
 fs/btrfs/ioctl.c                    | 12 ++++--------
 fs/exfat/file.c                     |  3 +--
 fs/ext4/mballoc.c                   |  6 +++---
 fs/f2fs/file.c                      |  3 +--
 fs/fat/file.c                       |  3 +--
 fs/gfs2/rgrp.c                      |  7 +++----
 fs/jfs/ioctl.c                      |  3 +--
 fs/nilfs2/ioctl.c                   |  4 ++--
 fs/ntfs3/file.c                     |  4 ++--
 fs/ntfs3/super.c                    |  6 ++----
 fs/ocfs2/ioctl.c                    |  3 +--
 fs/xfs/xfs_discard.c                |  4 ++--
 include/linux/blkdev.h              |  5 +++++
 18 files changed, 38 insertions(+), 47 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 8b4b66d3a9bfc..43aa4d7fe859f 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -12,8 +12,7 @@
 
 static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
 {
-	unsigned int discard_granularity =
-		bdev_get_queue(bdev)->limits.discard_granularity;
+	unsigned int discard_granularity = bdev_discard_granularity(bdev);
 	sector_t granularity_aligned_sector;
 
 	if (bdev_is_partition(bdev))
@@ -59,7 +58,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	}
 
 	/* In case the discard granularity isn't set by buggy device driver */
-	if (WARN_ON_ONCE(!q->limits.discard_granularity)) {
+	if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
 		char dev_name[BDEVNAME_SIZE];
 
 		bdevname(bdev, dev_name);
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index b55e5fcc21e1f..0b3e43be6414d 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1425,7 +1425,6 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 			       struct drbd_backing_dev *nbc)
 {
 	struct block_device *bdev = nbc->backing_bdev;
-	struct request_queue *q = bdev->bd_disk->queue;
 
 	if (disk_conf->al_extents < DRBD_AL_EXTENTS_MIN)
 		disk_conf->al_extents = DRBD_AL_EXTENTS_MIN;
@@ -1442,12 +1441,14 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 	if (disk_conf->rs_discard_granularity) {
 		int orig_value = disk_conf->rs_discard_granularity;
 		sector_t discard_size = bdev_max_discard_sectors(bdev) << 9;
+		unsigned int discard_granularity = bdev_discard_granularity(bdev);
 		int remainder;
 
-		if (q->limits.discard_granularity > disk_conf->rs_discard_granularity)
-			disk_conf->rs_discard_granularity = q->limits.discard_granularity;
+		if (discard_granularity > disk_conf->rs_discard_granularity)
+			disk_conf->rs_discard_granularity = discard_granularity;
 
-		remainder = disk_conf->rs_discard_granularity % q->limits.discard_granularity;
+		remainder = disk_conf->rs_discard_granularity %
+				discard_granularity;
 		disk_conf->rs_discard_granularity += remainder;
 
 		if (disk_conf->rs_discard_granularity > discard_size)
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 8a4a47da56fe9..275c53c7b629e 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1511,7 +1511,6 @@ void drbd_bump_write_ordering(struct drbd_resource *resource, struct drbd_backin
 int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, unsigned int nr_sectors, int flags)
 {
 	struct block_device *bdev = device->ldev->backing_bdev;
-	struct request_queue *q = bdev_get_queue(bdev);
 	sector_t tmp, nr;
 	unsigned int max_discard_sectors, granularity;
 	int alignment;
@@ -1521,7 +1520,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		goto zero_out;
 
 	/* Zero-sector (unknown) and one-sector granularities are the same.  */
-	granularity = max(q->limits.discard_granularity >> 9, 1U);
+	granularity = max(bdev_discard_granularity(bdev) >> 9, 1U);
 	alignment = (bdev_discard_alignment(bdev) >> 9) % granularity;
 
 	max_discard_sectors = min(bdev_max_discard_sectors(bdev), (1U << 22));
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 0e061c9896eff..976cf987b3920 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -759,7 +759,7 @@ static void loop_config_discard(struct loop_device *lo)
 		struct request_queue *backingq = bdev_get_queue(I_BDEV(inode));
 
 		max_discard_sectors = backingq->limits.max_write_zeroes_sectors;
-		granularity = backingq->limits.discard_granularity ?:
+		granularity = bdev_discard_granularity(I_BDEV(inode)) ?:
 			queue_physical_block_size(backingq);
 
 	/*
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 6cb9f87843278..25f33eb25337c 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -835,7 +835,6 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 				       struct block_device *bdev)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	int block_size = bdev_logical_block_size(bdev);
 
 	if (!bdev_max_discard_sectors(bdev))
@@ -847,7 +846,7 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	 * Currently hardcoded to 1 in Linux/SCSI code..
 	 */
 	attrib->max_unmap_block_desc_count = 1;
-	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
+	attrib->unmap_granularity = bdev_discard_granularity(bdev) / block_size;
 	attrib->unmap_granularity_alignment =
 		bdev_discard_alignment(bdev) / block_size;
 	return true;
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 096bb0da03f1c..70765d59616a5 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -468,7 +468,6 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 					void __user *arg)
 {
 	struct btrfs_device *device;
-	struct request_queue *q;
 	struct fstrim_range range;
 	u64 minlen = ULLONG_MAX;
 	u64 num_devices = 0;
@@ -498,14 +497,11 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 	rcu_read_lock();
 	list_for_each_entry_rcu(device, &fs_info->fs_devices->devices,
 				dev_list) {
-		if (!device->bdev)
+		if (!device->bdev || !bdev_max_discard_sectors(device->bdev))
 			continue;
-		q = bdev_get_queue(device->bdev);
-		if (bdev_max_discard_sectors(device->bdev)) {
-			num_devices++;
-			minlen = min_t(u64, q->limits.discard_granularity,
-				     minlen);
-		}
+		num_devices++;
+		minlen = min_t(u64, bdev_discard_granularity(device->bdev),
+				    minlen);
 	}
 	rcu_read_unlock();
 
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 765e4f63dd18d..20d4e47f57ab2 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -351,7 +351,6 @@ int exfat_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
 
 static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 {
-	struct request_queue *q = bdev_get_queue(inode->i_sb->s_bdev);
 	struct fstrim_range range;
 	int ret = 0;
 
@@ -365,7 +364,7 @@ static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 		return -EFAULT;
 
 	range.minlen = max_t(unsigned int, range.minlen,
-				q->limits.discard_granularity);
+				bdev_discard_granularity(inode->i_sb->s_bdev));
 
 	ret = exfat_trim_fs(inode, &range);
 	if (ret < 0)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index c3668c977cd99..6d1820536d88d 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -6455,7 +6455,7 @@ ext4_trim_all_free(struct super_block *sb, ext4_group_t group,
  */
 int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
 {
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
+	unsigned int discard_granularity = bdev_discard_granularity(sb->s_bdev);
 	struct ext4_group_info *grp;
 	ext4_group_t group, first_group, last_group;
 	ext4_grpblk_t cnt = 0, first_cluster, last_cluster;
@@ -6475,9 +6475,9 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
 	    range->len < sb->s_blocksize)
 		return -EINVAL;
 	/* No point to try to trim less than discard granularity */
-	if (range->minlen < q->limits.discard_granularity) {
+	if (range->minlen < discard_granularity) {
 		minlen = EXT4_NUM_B2C(EXT4_SB(sb),
-			q->limits.discard_granularity >> sb->s_blocksize_bits);
+				discard_granularity >> sb->s_blocksize_bits);
 		if (minlen > EXT4_CLUSTERS_PER_GROUP(sb))
 			goto out;
 	}
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 5b89af0f27f05..8053d99f3920b 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2285,7 +2285,6 @@ static int f2fs_ioc_fitrim(struct file *filp, unsigned long arg)
 {
 	struct inode *inode = file_inode(filp);
 	struct super_block *sb = inode->i_sb;
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
 	struct fstrim_range range;
 	int ret;
 
@@ -2304,7 +2303,7 @@ static int f2fs_ioc_fitrim(struct file *filp, unsigned long arg)
 		return ret;
 
 	range.minlen = max((unsigned int)range.minlen,
-				q->limits.discard_granularity);
+			   bdev_discard_granularity(sb->s_bdev));
 	ret = f2fs_trim_fs(F2FS_SB(sb), &range);
 	mnt_drop_write_file(filp);
 	if (ret < 0)
diff --git a/fs/fat/file.c b/fs/fat/file.c
index e4c7d10e80129..bf91f977debea 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -127,7 +127,6 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	struct super_block *sb = inode->i_sb;
 	struct fstrim_range __user *user_range;
 	struct fstrim_range range;
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
 	int err;
 
 	if (!capable(CAP_SYS_ADMIN))
@@ -141,7 +140,7 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 		return -EFAULT;
 
 	range.minlen = max_t(unsigned int, range.minlen,
-			     q->limits.discard_granularity);
+			     bdev_discard_granularity(sb->s_bdev));
 
 	err = fat_trim_fs(inode, &range);
 	if (err < 0)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 7f20ac9133bc6..6d26bb5254844 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1386,7 +1386,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 {
 	struct inode *inode = file_inode(filp);
 	struct gfs2_sbd *sdp = GFS2_SB(inode);
-	struct request_queue *q = bdev_get_queue(sdp->sd_vfs->s_bdev);
+	struct block_device *bdev = sdp->sd_vfs->s_bdev;
 	struct buffer_head *bh;
 	struct gfs2_rgrpd *rgd;
 	struct gfs2_rgrpd *rgd_end;
@@ -1405,7 +1405,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
 		return -EROFS;
 
-	if (!bdev_max_discard_sectors(sdp->sd_vfs->s_bdev))
+	if (!bdev_max_discard_sectors(bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&r, argp, sizeof(r)))
@@ -1418,8 +1418,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	start = r.start >> bs_shift;
 	end = start + (r.len >> bs_shift);
 	minlen = max_t(u64, r.minlen, sdp->sd_sb.sb_bsize);
-	minlen = max_t(u64, minlen,
-		       q->limits.discard_granularity) >> bs_shift;
+	minlen = max_t(u64, minlen, bdev_discard_granularity(bdev)) >> bs_shift;
 
 	if (end <= start || minlen > sdp->sd_max_rg_data)
 		return -EINVAL;
diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
index 357ae6e5c36ec..1e7b177ece605 100644
--- a/fs/jfs/ioctl.c
+++ b/fs/jfs/ioctl.c
@@ -110,7 +110,6 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	case FITRIM:
 	{
 		struct super_block *sb = inode->i_sb;
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		s64 ret = 0;
 
@@ -127,7 +126,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 			return -EFAULT;
 
 		range.minlen = max_t(unsigned int, range.minlen,
-			q->limits.discard_granularity);
+				     bdev_discard_granularity(sb->s_bdev));
 
 		ret = jfs_ioc_trim(inode, &range);
 		if (ret < 0)
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
index 52b73f558fcb1..87e1004b606d2 100644
--- a/fs/nilfs2/ioctl.c
+++ b/fs/nilfs2/ioctl.c
@@ -1052,7 +1052,6 @@ static int nilfs_ioctl_resize(struct inode *inode, struct file *filp,
 static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 {
 	struct the_nilfs *nilfs = inode->i_sb->s_fs_info;
-	struct request_queue *q = bdev_get_queue(nilfs->ns_bdev);
 	struct fstrim_range range;
 	int ret;
 
@@ -1065,7 +1064,8 @@ static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 	if (copy_from_user(&range, argp, sizeof(range)))
 		return -EFAULT;
 
-	range.minlen = max_t(u64, range.minlen, q->limits.discard_granularity);
+	range.minlen = max_t(u64, range.minlen,
+			     bdev_discard_granularity(nilfs->ns_bdev));
 
 	down_read(&nilfs->ns_segctor_sem);
 	ret = nilfs_sufile_trim_fs(nilfs->ns_sufile, &range);
diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index e763236169331..15806eeae217a 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -22,7 +22,6 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 {
 	struct fstrim_range __user *user_range;
 	struct fstrim_range range;
-	struct request_queue *q = bdev_get_queue(sbi->sb->s_bdev);
 	int err;
 
 	if (!capable(CAP_SYS_ADMIN))
@@ -35,7 +34,8 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 	if (copy_from_user(&range, user_range, sizeof(range)))
 		return -EFAULT;
 
-	range.minlen = max_t(u32, range.minlen, q->limits.discard_granularity);
+	range.minlen = max_t(u32, range.minlen,
+			     bdev_discard_granularity(sbi->sb->s_bdev));
 
 	err = ntfs_trim_fs(sbi, &range);
 	if (err < 0)
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index c734085bcce4a..5f2e414cfa79b 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -882,7 +882,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	int err;
 	struct ntfs_sb_info *sbi = sb->s_fs_info;
 	struct block_device *bdev = sb->s_bdev;
-	struct request_queue *rq;
 	struct inode *inode;
 	struct ntfs_inode *ni;
 	size_t i, tt;
@@ -912,9 +911,8 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 		goto out;
 	}
 
-	rq = bdev_get_queue(bdev);
-	if (bdev_max_discard_sectors(bdev) && rq->limits.discard_granularity) {
-		sbi->discard_granularity = rq->limits.discard_granularity;
+	if (bdev_max_discard_sectors(bdev) && bdev_discard_granularity(bdev)) {
+		sbi->discard_granularity = bdev_discard_granularity(bdev);
 		sbi->discard_granularity_mask_inv =
 			~(u64)(sbi->discard_granularity - 1);
 	}
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index 9b78ef103ada6..afd54ec661030 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -903,7 +903,6 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	case FITRIM:
 	{
 		struct super_block *sb = inode->i_sb;
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		int ret = 0;
 
@@ -916,7 +915,7 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (copy_from_user(&range, argp, sizeof(range)))
 			return -EFAULT;
 
-		range.minlen = max_t(u64, q->limits.discard_granularity,
+		range.minlen = max_t(u64, bdev_discard_granularity(sb->s_bdev),
 				     range.minlen);
 		ret = ocfs2_trim_fs(sb, &range);
 		if (ret < 0)
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index a4e6609d616b7..e2ada115c23f9 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -152,8 +152,8 @@ xfs_ioc_trim(
 	struct xfs_mount		*mp,
 	struct fstrim_range __user	*urange)
 {
-	struct request_queue	*q = bdev_get_queue(mp->m_ddev_targp->bt_bdev);
-	unsigned int		granularity = q->limits.discard_granularity;
+	unsigned int		granularity =
+		bdev_discard_granularity(mp->m_ddev_targp->bt_bdev);
 	struct fstrim_range	range;
 	xfs_daddr_t		start, end, minlen;
 	xfs_agnumber_t		start_agno, end_agno, agno;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 767ab22e1052a..f1cf557ea20ef 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1257,6 +1257,11 @@ static inline unsigned int bdev_max_discard_sectors(struct block_device *bdev)
 	return bdev_get_queue(bdev)->limits.max_discard_sectors;
 }
 
+static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.discard_granularity;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301962.515525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DN-0002F2-1z; Sat, 09 Apr 2022 05:00:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301962.515525; Sat, 09 Apr 2022 05:00:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DL-00029L-Rd; Sat, 09 Apr 2022 05:00:47 +0000
Received: by outflank-mailman (input) for mailman id 301962;
 Sat, 09 Apr 2022 05:00:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34n-0006gL-8x
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:57 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c77dfa74-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:56 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34X-00217H-QX; Sat, 09 Apr 2022 04:51:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c77dfa74-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=V+N3WPhcjqbqmVRPAoIxuBjo6dgh1f5KuPVQDpaEGEs=; b=tiIaiEVMWAbVYZUjb2lOkfyysx
	dbx49Qpm+lo+UUevAGrVDIkvKOBa+44snHlQ0a+KaxdGF8tKMoYuXWs/fvRv0ae96tcME++4ORVYu
	qYaC1vBwLvlzDvH7/c4A7h9mvUaVl8+MzbhpnW7kmDycYjo20v3XRILfplXYTrbZMX8JEk4N43tKH
	ZGQP+OitiIrdN0xV7JNnkLHd6fyLWakKMo7lxXmk9Yj+ODdh4QMMFZVM+vhTm4zDm7nCREr0fmSsA
	waBKGG0G7evAOkXMc1HpZXEoglbkXIOtFpSCT7RrqLEic0YOHBHXQ9EKk4JuDHcopl0LFeqmVS4RI
	X94UE+Ww==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 16/27] block: use bdev_alignment_offset in part_alignment_offset_show
Date: Sat,  9 Apr 2022 06:50:32 +0200
Message-Id: <20220409045043.23593-17-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Replace the open coded offset calculation with the proper helper.
This is an ABI change in that the -1 for a misaligned partition is
properly propagated, which can be considered a bug fix and matches
what is done on the whole device.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/partitions/core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 2ef8dfa1e5c85..240b3fff521e4 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -200,11 +200,7 @@ static ssize_t part_ro_show(struct device *dev,
 static ssize_t part_alignment_offset_show(struct device *dev,
 					  struct device_attribute *attr, char *buf)
 {
-	struct block_device *bdev = dev_to_bdev(dev);
-
-	return sprintf(buf, "%u\n",
-		queue_limit_alignment_offset(&bdev_get_queue(bdev)->limits,
-				bdev->bd_start_sect));
+	return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));
 }
 
 static ssize_t part_discard_alignment_show(struct device *dev,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301970.515546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DR-0003Zi-V9; Sat, 09 Apr 2022 05:00:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301970.515546; Sat, 09 Apr 2022 05:00:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DR-0003ZM-O5; Sat, 09 Apr 2022 05:00:53 +0000
Received: by outflank-mailman (input) for mailman id 301970;
 Sat, 09 Apr 2022 05:00:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34O-0006gL-65
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:32 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b8a0af61-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:31 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34C-0020kv-0d; Sat, 09 Apr 2022 04:51:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8a0af61-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=OGJvHxXgCvw9/l2/0Y6T0ivupEa5/VICLVgDi4pj6zk=; b=bvdxNtIBSK2e/CHWOJvjhJQ/pD
	ziWAaN1+H5rv0PFjwCtxUb32HQisXqhv0CfdNRRakGSvxS2SlGM7sa31KM+kznDnIR/AZLVb6CdU4
	vS8DuWDB+gUHx5md6g+mCQSqz3crMjKTJ6PsdykxY9osHuidQtFbDkq6qQ9nvfWGIgIk4Rkp02Mzl
	WCYI+BDG1gl4hW/mPoncA+V1yctBgiee9+ltyBfbzQvs00T9mPYBlaJ4i/TRsB0Z4Fkgt4oIU5qzV
	IXkEEPpdqsWu7ooiuyvMhxa14Ribw7Jyx9BT4vHhU8n59256QhhUPR6N/0aIFpZCRpJfpeccBNtOP
	uiV7Ifjw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile
Date: Sat,  9 Apr 2022 06:50:26 +0200
Message-Id: <20220409045043.23593-11-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based helper instead of poking into the queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 mm/swapfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/swapfile.c b/mm/swapfile.c
index 63c61f8b26118..4c7537162af5e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2761,7 +2761,7 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
 		 * write only restriction.  Hence zoned block devices are not
 		 * suitable for swapping.  Disallow them here.
 		 */
-		if (blk_queue_is_zoned(p->bdev->bd_disk->queue))
+		if (bdev_is_zoned(p->bdev))
 			return -EINVAL;
 		p->flags |= SWP_BLKDEV;
 	} else if (S_ISREG(inode->i_mode)) {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:00:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:00:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301974.515557 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DW-0004Vp-Ch; Sat, 09 Apr 2022 05:00:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301974.515557; Sat, 09 Apr 2022 05:00:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DW-0004TO-6p; Sat, 09 Apr 2022 05:00:58 +0000
Received: by outflank-mailman (input) for mailman id 301974;
 Sat, 09 Apr 2022 05:00:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd34W-0006gL-4D
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:51:40 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bd49534f-b7c0-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 06:51:39 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd34E-0020oX-PD; Sat, 09 Apr 2022 04:51:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd49534f-b7c0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=HrgNfnZXHjI7+oEfFDB5J5Uuocj6xy8pedsh1Yy5WG4=; b=JZn3/ma9EZNU+0AUx4JUCbkUtN
	1gVYrPS6nGU/IPVNAsMIwQdRVonqngYyJd/5mhM6maNoNh8obBvlUsS7xZb+5IUtAzAckVAhB18lZ
	+hrt4X59ZUCzvTl8qWpsGsw7hVsJEekVtl3RSG9SEZSyM3Dc6qTHcoJlxPY/bwd5cgRNy3jh2HOzR
	p+IuIpokNAkYT5clDeS8cbdmw/Ihai/S5xZiBqxQ1pZvQuDgw8Fcl5/kNcDb1PCUpcqc7zMLa6+0C
	d2fURrC8Mx6BC4ojaSxAuzEcsPTExC6oj9FsjDDX8JgFsv800gQEvMZCYj+50CSJny3gvo3JzP0lv
	0Zpon8ww==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 11/27] block: add a bdev_nonrot helper
Date: Sat,  9 Apr 2022 06:50:27 +0200
Message-Id: <20220409045043.23593-12-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the nonrot flag based on the block_device instead
of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 block/ioctl.c                       | 2 +-
 drivers/block/loop.c                | 2 +-
 drivers/md/dm-table.c               | 4 +---
 drivers/md/md.c                     | 3 +--
 drivers/md/raid1.c                  | 2 +-
 drivers/md/raid10.c                 | 2 +-
 drivers/md/raid5.c                  | 2 +-
 drivers/target/target_core_file.c   | 3 +--
 drivers/target/target_core_iblock.c | 2 +-
 fs/btrfs/volumes.c                  | 4 ++--
 fs/ext4/mballoc.c                   | 2 +-
 include/linux/blkdev.h              | 5 +++++
 mm/swapfile.c                       | 4 ++--
 13 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/block/ioctl.c b/block/ioctl.c
index 4a86340133e46..ad3771b268b81 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -489,7 +489,7 @@ static int blkdev_common_ioctl(struct block_device *bdev, fmode_t mode,
 				    queue_max_sectors(bdev_get_queue(bdev)));
 		return put_ushort(argp, max_sectors);
 	case BLKROTATIONAL:
-		return put_ushort(argp, !blk_queue_nonrot(bdev_get_queue(bdev)));
+		return put_ushort(argp, !bdev_nonrot(bdev));
 	case BLKRASET:
 	case BLKFRASET:
 		if(!capable(CAP_SYS_ADMIN))
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index a58595f5ee2c8..8d800d46e4985 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -903,7 +903,7 @@ static void loop_update_rotational(struct loop_device *lo)
 
 	/* not all filesystems (e.g. tmpfs) have a sb->s_bdev */
 	if (file_bdev)
-		nonrot = blk_queue_nonrot(bdev_get_queue(file_bdev));
+		nonrot = bdev_nonrot(file_bdev);
 
 	if (nonrot)
 		blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 03541cfc2317c..5e38d0dd009d5 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1820,9 +1820,7 @@ static int device_dax_write_cache_enabled(struct dm_target *ti,
 static int device_is_rotational(struct dm_target *ti, struct dm_dev *dev,
 				sector_t start, sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_nonrot(q);
+	return !bdev_nonrot(dev->bdev);
 }
 
 static int device_is_not_random(struct dm_target *ti, struct dm_dev *dev,
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 309b3af906ad3..19636c2f2cda4 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5991,8 +5991,7 @@ int md_run(struct mddev *mddev)
 		bool nonrot = true;
 
 		rdev_for_each(rdev, mddev) {
-			if (rdev->raid_disk >= 0 &&
-			    !blk_queue_nonrot(bdev_get_queue(rdev->bdev))) {
+			if (rdev->raid_disk >= 0 && !bdev_nonrot(rdev->bdev)) {
 				nonrot = false;
 				break;
 			}
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 99d5464a51f81..d81b896855f9f 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -704,7 +704,7 @@ static int read_balance(struct r1conf *conf, struct r1bio *r1_bio, int *max_sect
 			/* At least two disks to choose from so failfast is OK */
 			set_bit(R1BIO_FailFast, &r1_bio->state);
 
-		nonrot = blk_queue_nonrot(bdev_get_queue(rdev->bdev));
+		nonrot = bdev_nonrot(rdev->bdev);
 		has_nonrot_disk |= nonrot;
 		pending = atomic_read(&rdev->nr_pending);
 		dist = abs(this_sector - conf->mirrors[disk].head_position);
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index dfe7d62d3fbdd..7816c8b2e8087 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -796,7 +796,7 @@ static struct md_rdev *read_balance(struct r10conf *conf,
 		if (!do_balance)
 			break;
 
-		nonrot = blk_queue_nonrot(bdev_get_queue(rdev->bdev));
+		nonrot = bdev_nonrot(rdev->bdev);
 		has_nonrot_disk |= nonrot;
 		pending = atomic_read(&rdev->nr_pending);
 		if (min_pending > pending && nonrot) {
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 351d341a1ffa4..0bbae0e638666 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7242,7 +7242,7 @@ static struct r5conf *setup_conf(struct mddev *mddev)
 	rdev_for_each(rdev, mddev) {
 		if (test_bit(Journal, &rdev->flags))
 			continue;
-		if (blk_queue_nonrot(bdev_get_queue(rdev->bdev))) {
+		if (bdev_nonrot(rdev->bdev)) {
 			conf->batch_bio_dispatch = false;
 			break;
 		}
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index 8d191fdc33217..b6ba582b06775 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -135,7 +135,6 @@ static int fd_configure_device(struct se_device *dev)
 	inode = file->f_mapping->host;
 	if (S_ISBLK(inode->i_mode)) {
 		struct block_device *bdev = I_BDEV(inode);
-		struct request_queue *q = bdev_get_queue(bdev);
 		unsigned long long dev_size;
 
 		fd_dev->fd_block_size = bdev_logical_block_size(bdev);
@@ -160,7 +159,7 @@ static int fd_configure_device(struct se_device *dev)
 		 */
 		dev->dev_attrib.max_write_same_len = 0xFFFF;
 
-		if (blk_queue_nonrot(q))
+		if (bdev_nonrot(bdev))
 			dev->dev_attrib.is_nonrot = 1;
 	} else {
 		if (!(fd_dev->fbd_flags & FBDF_HAS_SIZE)) {
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index b886ce1770bfd..b41ee5c3b5b82 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -133,7 +133,7 @@ static int iblock_configure_device(struct se_device *dev)
 	else
 		dev->dev_attrib.max_write_same_len = 0xFFFF;
 
-	if (blk_queue_nonrot(q))
+	if (bdev_nonrot(bd))
 		dev->dev_attrib.is_nonrot = 1;
 
 	bi = bdev_get_integrity(bd);
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2cfbc74a3b4ee..77f1a5696842b 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -643,7 +643,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
 			set_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state);
 	}
 
-	if (!blk_queue_nonrot(bdev_get_queue(bdev)))
+	if (!bdev_nonrot(bdev))
 		fs_devices->rotating = true;
 
 	device->bdev = bdev;
@@ -2706,7 +2706,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
 
 	atomic64_add(device->total_bytes, &fs_info->free_chunk_space);
 
-	if (!blk_queue_nonrot(bdev_get_queue(bdev)))
+	if (!bdev_nonrot(bdev))
 		fs_devices->rotating = true;
 
 	orig_super_total_bytes = btrfs_super_total_bytes(fs_info->super_copy);
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 252c168454c7f..c3668c977cd99 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3498,7 +3498,7 @@ int ext4_mb_init(struct super_block *sb)
 		spin_lock_init(&lg->lg_prealloc_lock);
 	}
 
-	if (blk_queue_nonrot(bdev_get_queue(sb->s_bdev)))
+	if (bdev_nonrot(sb->s_bdev))
 		sbi->s_mb_max_linear_groups = 0;
 	else
 		sbi->s_mb_max_linear_groups = MB_DEFAULT_LINEAR_LIMIT;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 60d0161389971..3a9578e14a6b0 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1326,6 +1326,11 @@ static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 	return 0;
 }
 
+static inline bool bdev_nonrot(struct block_device *bdev)
+{
+	return blk_queue_nonrot(bdev_get_queue(bdev));
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 4c7537162af5e..d5ab7ec4d92ca 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2466,7 +2466,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile)
 	if (p->flags & SWP_CONTINUED)
 		free_swap_count_continuations(p);
 
-	if (!p->bdev || !blk_queue_nonrot(bdev_get_queue(p->bdev)))
+	if (!p->bdev || !bdev_nonrot(p->bdev))
 		atomic_dec(&nr_rotate_swap);
 
 	mutex_lock(&swapon_mutex);
@@ -3071,7 +3071,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 	if (p->bdev && p->bdev->bd_disk->fops->rw_page)
 		p->flags |= SWP_SYNCHRONOUS_IO;
 
-	if (p->bdev && blk_queue_nonrot(bdev_get_queue(p->bdev))) {
+	if (p->bdev && bdev_nonrot(p->bdev)) {
 		int cpu;
 		unsigned long ci, nr_cluster;
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 05:01:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 05:01:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.301976.515562 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DX-0004dc-3p; Sat, 09 Apr 2022 05:00:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 301976.515562; Sat, 09 Apr 2022 05:00:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd3DW-0004c6-PI; Sat, 09 Apr 2022 05:00:58 +0000
Received: by outflank-mailman (input) for mailman id 301976;
 Sat, 09 Apr 2022 05:00:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6m1B=UT=bombadil.srs.infradead.org=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nd35V-0006gF-OK
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 04:52:41 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e21fb432-b7c0-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 06:52:41 +0200 (CEST)
Received: from 213-147-167-116.nat.highway.webapn.at ([213.147.167.116]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nd35G-0021rI-Lh; Sat, 09 Apr 2022 04:52:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e21fb432-b7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=eypoqjBCbHteIGJMjEE77faduCfiNIsAQ0ydQeu7OQ0=; b=nqH1nBV8lOr2r5wyOjol3g7s8X
	NGopilIp147x4XNnQqzR5o2YWkY6IO58VVUojmV/ASvSDXVzRQHv+BqUNN8ISkIuVH5Huq+5W/+g6
	Fx9NKN7nsNjG6IaaR01B6x8gfqb84JVGaMt2Mch/XsNqmw38mh/kWIOczl1+aSfojYjwvPWnkVT0z
	zeBYxWSj02o09fDuqh1c1ftABUKI9QxyXU2GCBR2V2aNbgjbyvKcSUL75+QEIgn+hIxNaN3b6eMN+
	HQ75AhIB7YFYQ9KIFGF2dUiaHQ4ZLNQzEzLlTd1WzYc4Lz5oFphMfcUxRdKyObtKnqHpozib+pvzE
	Et/uKlCg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 27/27] direct-io: remove random prefetches
Date: Sat,  9 Apr 2022 06:50:43 +0200
Message-Id: <20220409045043.23593-28-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220409045043.23593-1-hch@lst.de>
References: <20220409045043.23593-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Randomly poking into block device internals for manual prefetches isn't
exactly a very maintainable thing to do.  And none of the performance
criticil direct I/O implementations still use this library function
anyway, so just drop it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/direct-io.c | 32 ++++----------------------------
 1 file changed, 4 insertions(+), 28 deletions(-)

diff --git a/fs/direct-io.c b/fs/direct-io.c
index aef06e607b405..840752006f601 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -1115,11 +1115,10 @@ static inline int drop_refcount(struct dio *dio)
  * individual fields and will generate much worse code. This is important
  * for the whole file.
  */
-static inline ssize_t
-do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
-		      struct block_device *bdev, struct iov_iter *iter,
-		      get_block_t get_block, dio_iodone_t end_io,
-		      dio_submit_t submit_io, int flags)
+ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
+		struct block_device *bdev, struct iov_iter *iter,
+		get_block_t get_block, dio_iodone_t end_io,
+		dio_submit_t submit_io, int flags)
 {
 	unsigned i_blkbits = READ_ONCE(inode->i_blkbits);
 	unsigned blkbits = i_blkbits;
@@ -1334,29 +1333,6 @@ do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
 	kmem_cache_free(dio_cache, dio);
 	return retval;
 }
-
-ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
-			     struct block_device *bdev, struct iov_iter *iter,
-			     get_block_t get_block,
-			     dio_iodone_t end_io, dio_submit_t submit_io,
-			     int flags)
-{
-	/*
-	 * The block device state is needed in the end to finally
-	 * submit everything.  Since it's likely to be cache cold
-	 * prefetch it here as first thing to hide some of the
-	 * latency.
-	 *
-	 * Attempt to prefetch the pieces we likely need later.
-	 */
-	prefetch(&bdev->bd_disk->part_tbl);
-	prefetch(bdev->bd_disk->queue);
-	prefetch((char *)bdev->bd_disk->queue + SMP_CACHE_BYTES);
-
-	return do_blockdev_direct_IO(iocb, inode, bdev, iter, get_block,
-				     end_io, submit_io, flags);
-}
-
 EXPORT_SYMBOL(__blockdev_direct_IO);
 
 static __init int dio_init(void)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 06:05:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 06:05:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302059.515591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd4E5-0006z1-9K; Sat, 09 Apr 2022 06:05:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302059.515591; Sat, 09 Apr 2022 06:05:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd4E5-0006yu-5n; Sat, 09 Apr 2022 06:05:37 +0000
Received: by outflank-mailman (input) for mailman id 302059;
 Sat, 09 Apr 2022 06:05:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd4E4-0006yk-AZ; Sat, 09 Apr 2022 06:05:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd4E4-0005vk-6s; Sat, 09 Apr 2022 06:05:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd4E3-00055E-Lw; Sat, 09 Apr 2022 06:05:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nd4E3-0006Xn-JR; Sat, 09 Apr 2022 06:05:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ovmW5GFqIyUy0W5XhAGAe/V2rphExbR0/k6NxfZ/B0g=; b=xdPvElFSiIHqIdzjdrXvSWwlJ6
	74aSpim1eoQgnUByY8wOSBGXiu/h+i7ii7xVblnSzebL9vydfcfRDteuMqvCJtO7H21c7gi4wRqqY
	H0SjvHyTjds52AxQyiFo8Cm7eCws/RHKRBAfQ4MIT1Mi1X/fIQ3lm7Cz/+GQg7KBIhl4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169239-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.12-testing test] 169239: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.12-testing:test-arm64-arm64-xl-credit1:xen-boot:fail:heisenbug
    xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-vhd:guest-localmigrate/x10:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=efea4bdbd183e1f1e3cbb2b33623680419199542
X-Osstest-Versions-That:
    xen=c633ec9451e76015c409bd5119ffcb0f2e61fe8b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 06:05:35 +0000

flight 169239 xen-4.12-testing real [real]
flight 169255 xen-4.12-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169239/
http://logs.test-lab.xenproject.org/osstest/logs/169255/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-credit1   8 xen-boot            fail pass in 169255-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 169255 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 169255 never pass
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 169199
 test-amd64-amd64-xl-qcow2    19 guest-localmigrate/x10       fail  like 169214
 test-amd64-i386-xl-vhd       19 guest-localmigrate/x10       fail  like 169214
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169214
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169214
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169214
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169214
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169214
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169214
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169214
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169214
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169214
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169214
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169214
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169214
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  efea4bdbd183e1f1e3cbb2b33623680419199542
baseline version:
 xen                  c633ec9451e76015c409bd5119ffcb0f2e61fe8b

Last test of basis   169214  2022-04-07 08:49:16 Z    1 days
Testing same since   169239  2022-04-08 13:36:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c633ec9451..efea4bdbd1  efea4bdbd183e1f1e3cbb2b33623680419199542 -> stable-4.12


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 08:33:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 08:33:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302086.515608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd6Wj-0000ci-A0; Sat, 09 Apr 2022 08:33:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302086.515608; Sat, 09 Apr 2022 08:33:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd6Wj-0000cb-6T; Sat, 09 Apr 2022 08:33:01 +0000
Received: by outflank-mailman (input) for mailman id 302086;
 Sat, 09 Apr 2022 08:33:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd6Wi-0000cR-KW; Sat, 09 Apr 2022 08:33:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd6Wi-0000gS-JL; Sat, 09 Apr 2022 08:33:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd6Wi-0005kW-4X; Sat, 09 Apr 2022 08:33:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nd6Wi-000235-47; Sat, 09 Apr 2022 08:33:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tc+7LOO32D3nd4MSz7vAEY+7TXfwA3jWcWpouRwKI2k=; b=nuywuc92p5ze0bb8B6VgEBXGP6
	j/Hjlaj0O+ZIDcx2WJgmQI9rljYQRhP45c+ZkuICPgQV7dfCmoWaB4kDgg8DMMYDCUUbV926HElwm
	qPAiD8GjmlEMksSmQ422ohCodZmrJ6mU/QmVV3GE3sO2mU4ycECldxBlMF9CgO4YxnTg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169248-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169248: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 08:33:00 +0000

flight 169248 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169248/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 94f905b3bf37af99cff0787c2f529ab3fe2e8fbb
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   39 days
Failing since        168258  2022-03-01 01:55:31 Z   39 days  295 attempts
Testing same since   169226  2022-04-08 06:27:24 Z    1 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4626 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 08:55:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 08:55:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302084.515628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd6s7-0003ac-DY; Sat, 09 Apr 2022 08:55:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302084.515628; Sat, 09 Apr 2022 08:55:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd6s7-0003ZZ-6l; Sat, 09 Apr 2022 08:55:07 +0000
Received: by outflank-mailman (input) for mailman id 302084;
 Sat, 09 Apr 2022 08:17:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FhEE=UT=linbit.com=christoph.boehmwalder@srs-se1.protection.inumbo.net>)
 id 1nd6HJ-0006oL-D9
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 08:17:05 +0000
Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com
 [2a00:1450:4864:20::432])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6ee64244-b7dd-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 10:17:02 +0200 (CEST)
Received: by mail-wr1-x432.google.com with SMTP id d29so16011450wra.10
 for <xen-devel@lists.xenproject.org>; Sat, 09 Apr 2022 01:17:01 -0700 (PDT)
Received: from [192.168.169.127] (178.115.52.210.wireless.dyn.drei.com.
 [178.115.52.210]) by smtp.gmail.com with ESMTPSA id
 r14-20020a05600c35ce00b0038c9f469979sm12169802wmq.40.2022.04.09.01.16.59
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 09 Apr 2022 01:17:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ee64244-b7dd-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linbit-com.20210112.gappssmtp.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=Ga61vN/TMGQoWv5pdVva9yHEVEk7JvDu8SvkqTkiHOU=;
        b=16VWXfTcecI6vKD89hlxEi4M1sM+lDWraPFKcdJek4zYvKgcUI+UTTfswq4WTG3pUA
         DwGdvejVPHmGbB6WxyxpG5RxCDgxrI8ELqeSKx9xnWZSuDqFsfTR7C0q23UBJ4NTUUke
         9rs/lGq9PScZMcSAS9SHkk+s8lIoFrVgzxTJ9NRLUES2XsBvbZXGJskPHSy0jdzHruaB
         iGqoe9YksSt5XleGcAhaVmv2OHki/8AO1/zdgDuyMqAmL6dyveVZDyPGB/rY+7+4UaaK
         b7o7nIN/SrEk1fy76OtZuySau99YX+Sryl6fYO8t+jUUvribl7KiF9nqytVWelfdH+Mk
         O4fQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=Ga61vN/TMGQoWv5pdVva9yHEVEk7JvDu8SvkqTkiHOU=;
        b=6CVTgH6fsGTu4MSkTOiLWzSj5avz+zddMwJheLKz3bDrWDNcKUqCfZpVD4Qw5aEAty
         7bhfpuCPI1qY/6TDySiwTZg+Z6Htmb81X9ho2KCxceofOiECWCq2EKV9pUytWoBl0Jr0
         4kHPeuqelgc0G7WvdM31uEgyCJf9erm9ZoatVQM0tJx630gObI5NKBK/dCBWxxC2bRpt
         mmlu1aaq4eECFrkdSZLIfrYAee8K1Za/eg/CBYFO6tZZw730bRHqo5b9i8hFnDiLqZkH
         rmhhKm5Ul5Or8xUJZRg8kwQkGeW8C8d9v5GuevKCjNyk/vCgqOJcb1TEUqZx+7YlIXRI
         Oakg==
X-Gm-Message-State: AOAM530fvBtEACWz9kGUUkP02iKvRiGoSUMq0HGHXKcrZdDiVUm1mji4
	h0w1pbQYEqCmA5ruIQQzWUB54A==
X-Google-Smtp-Source: ABdhPJyMl7hUdRWB67QUv24ZWK8mJRwBaxhnGq09ejE28bU5zjvkHivlidIC/JIf/EdWqVvIZNI6nA==
X-Received: by 2002:adf:9581:0:b0:1ed:c341:4ed1 with SMTP id p1-20020adf9581000000b001edc3414ed1mr16998132wrp.299.1649492221449;
        Sat, 09 Apr 2022 01:17:01 -0700 (PDT)
Message-ID: <5a26cdb1-b63b-8d35-640b-bc0e0f78a181@linbit.com>
Date: Sat, 9 Apr 2022 10:16:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [Drbd-dev] [PATCH 04/27] drbd: remove assign_p_sizes_qlim
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
 virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
 dm-devel@redhat.com, target-devel@vger.kernel.org,
 linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
 linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
 linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
 xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
 linux-um@lists.infradead.org, nbd@other.debian.org,
 linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
 ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
 linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
 linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
 linux-btrfs@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
References: <20220409045043.23593-1-hch@lst.de>
 <20220409045043.23593-5-hch@lst.de>
From: =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= <christoph.boehmwalder@linbit.com>
In-Reply-To: <20220409045043.23593-5-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 09.04.22 06:50, Christoph Hellwig wrote:
> Fold each branch into its only caller.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   drivers/block/drbd/drbd_main.c | 47 +++++++++++++++-------------------
>   1 file changed, 20 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
> index 9676a1d214bc5..1262fe1c33618 100644
> --- a/drivers/block/drbd/drbd_main.c
> +++ b/drivers/block/drbd/drbd_main.c
> @@ -903,31 +903,6 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device)
>   	}
>   }
>   
> -/* communicated if (agreed_features & DRBD_FF_WSAME) */
> -static void
> -assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p,
> -					struct request_queue *q)
> -{
> -	if (q) {
> -		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));
> -		p->qlim->logical_block_size = cpu_to_be32(queue_logical_block_size(q));
> -		p->qlim->alignment_offset = cpu_to_be32(queue_alignment_offset(q));
> -		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
> -		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
> -		p->qlim->discard_enabled = blk_queue_discard(q);
> -		p->qlim->write_same_capable = 0;
> -	} else {
> -		q = device->rq_queue;
> -		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));
> -		p->qlim->logical_block_size = cpu_to_be32(queue_logical_block_size(q));
> -		p->qlim->alignment_offset = 0;
> -		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
> -		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
> -		p->qlim->discard_enabled = 0;
> -		p->qlim->write_same_capable = 0;
> -	}
> -}
> -
>   int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enum dds_flags flags)
>   {
>   	struct drbd_device *device = peer_device->device;
> @@ -957,14 +932,32 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
>   		q_order_type = drbd_queue_order_type(device);
>   		max_bio_size = queue_max_hw_sectors(q) << 9;
>   		max_bio_size = min(max_bio_size, DRBD_MAX_BIO_SIZE);
> -		assign_p_sizes_qlim(device, p, q);
> +		p->qlim->physical_block_size =
> +			cpu_to_be32(queue_physical_block_size(q));
> +		p->qlim->logical_block_size =
> +			cpu_to_be32(queue_logical_block_size(q));
> +		p->qlim->alignment_offset =
> +			cpu_to_be32(queue_alignment_offset(q));
> +		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
> +		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
> +		p->qlim->discard_enabled = blk_queue_discard(q);
>   		put_ldev(device);
>   	} else {
> +		struct request_queue *q = device->rq_queue;
> +
> +		p->qlim->physical_block_size =
> +			cpu_to_be32(queue_physical_block_size(q));
> +		p->qlim->logical_block_size =
> +			cpu_to_be32(queue_logical_block_size(q));
> +		p->qlim->alignment_offset = 0;
> +		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
> +		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
> +		p->qlim->discard_enabled = 0;
> +
>   		d_size = 0;
>   		u_size = 0;
>   		q_order_type = QUEUE_ORDERED_NONE;
>   		max_bio_size = DRBD_MAX_BIO_SIZE; /* ... multiple BIOs per peer_request */
> -		assign_p_sizes_qlim(device, p, NULL);
>   	}
>   
>   	if (peer_device->connection->agreed_pro_version <= 94)

LGTM now, thanks.

Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 08:55:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 08:55:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302080.515622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd6s7-0003Xr-2C; Sat, 09 Apr 2022 08:55:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302080.515622; Sat, 09 Apr 2022 08:55:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd6s6-0003Xk-V4; Sat, 09 Apr 2022 08:55:06 +0000
Received: by outflank-mailman (input) for mailman id 302080;
 Sat, 09 Apr 2022 08:15:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FhEE=UT=linbit.com=christoph.boehmwalder@srs-se1.protection.inumbo.net>)
 id 1nd6Fv-0006k9-7L
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 08:15:39 +0000
Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com
 [2a00:1450:4864:20::429])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3cad9668-b7dd-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 10:15:37 +0200 (CEST)
Received: by mail-wr1-x429.google.com with SMTP id w4so15979226wrg.12
 for <xen-devel@lists.xenproject.org>; Sat, 09 Apr 2022 01:15:37 -0700 (PDT)
Received: from [192.168.169.127] (178.115.52.210.wireless.dyn.drei.com.
 [178.115.52.210]) by smtp.gmail.com with ESMTPSA id
 m20-20020a05600c4f5400b0038b5162260csm16809052wmq.23.2022.04.09.01.15.34
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 09 Apr 2022 01:15:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3cad9668-b7dd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linbit-com.20210112.gappssmtp.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=sw+fQbvS6SFTnotjqrxbhqCVHIPsenv7yxMzOYGId1I=;
        b=swx5mkkbJNix1TPl46oJjK+Fw0+J2z/XHhCyUPh+dcKkTNBekj88xkgZeDCIEgfzZd
         +FA0t7ckuNM4K4OwCilxgo/M+WNIfDm8hTC88nPXmxm39Wp7Y3PlmqfYEyysUU8hQUUf
         QcFmQYaxbOUrhMO1omCXZ8F/Rog5zixS+JPWEUQR0KkNkX4orlWG0JIiavrTh9qI4888
         PfuJYdextltFDNT3Q+47ZPQuPkokUbAa0jhifptu2z1GSQMaUF7eHMsw0ukFDymbedqA
         fJT7coHgReWy+GC/y+kW2UJS/DziuPPZTxFTP9KzlhdtF9p6DIhUJyZVoMiIdhtFkJM+
         cESQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=sw+fQbvS6SFTnotjqrxbhqCVHIPsenv7yxMzOYGId1I=;
        b=C4PmZqSjwSK3qYqITpTIG5EjddfB2BorJWWVYDb8uWIVcpUgjf7g+SM5+x6CELTyEd
         jFUwDap5i/hj5itkoIgogMDYDuzBG0/xvvDRRbpnoIsY3lx1UJwE7KpWbU61VW4Vm2iH
         FS2L1NY92fhKW7HE2lwWQ2sn7cI/tzp52NRfiIaznslwBmqLn6zYtdYnhKNFT/DL2lK0
         qoDM44Ow1t7mluekTq3DxXaDsKjmKDzS5wCEmiWX3ZMmej6+45I/8yA5I5N0Rq41KUjq
         1qToD7OEk1vz3xYqw2eUpxcZYN73OWbYLSiC3x8NmXC/Zx5khGQwQljkF6cdTjFQTX/M
         4w8Q==
X-Gm-Message-State: AOAM533l9GPoXvyXDlRUOH4HPjNgYrf4Li13blahsc59PErAF0iZNGh1
	X53VNTEBML64Wl5uKpgJXc7p7g==
X-Google-Smtp-Source: ABdhPJzQQyyFsXyXf3Tt03078VjcrkSv2k98fwj9oToPATRHlAVDyH773lIm4bEik17KjObuot5lIg==
X-Received: by 2002:a5d:6c6b:0:b0:1ea:77ea:dde8 with SMTP id r11-20020a5d6c6b000000b001ea77eadde8mr17920640wrz.690.1649492137216;
        Sat, 09 Apr 2022 01:15:37 -0700 (PDT)
Message-ID: <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com>
Date: Sat, 9 Apr 2022 10:15:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 nbd@other.debian.org, ceph-devel@vger.kernel.org,
 virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
 Jens Axboe <axboe@kernel.dk>, linux-bcache@vger.kernel.org,
 linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
 linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
 linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
 target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
 linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
 cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
 linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
 ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
 "Martin K . Petersen" <martin.petersen@oracle.com>, Coly Li <colyli@suse.de>
References: <20220409045043.23593-1-hch@lst.de>
 <20220409045043.23593-25-hch@lst.de>
From: =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= <christoph.boehmwalder@linbit.com>
In-Reply-To: <20220409045043.23593-25-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 09.04.22 06:50, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
> 
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [btrfs]

I think you may have a typo there: my ACK was for drbd, not btrfs.

> Acked-by: Coly Li <colyli@suse.de> [bcache]
> ---
>   arch/um/drivers/ubd_kern.c          |  2 --
>   block/blk-core.c                    |  2 +-


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 09:02:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 09:02:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302109.515659 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd6z9-00060V-9a; Sat, 09 Apr 2022 09:02:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302109.515659; Sat, 09 Apr 2022 09:02:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd6z9-00060O-6K; Sat, 09 Apr 2022 09:02:23 +0000
Received: by outflank-mailman (input) for mailman id 302109;
 Sat, 09 Apr 2022 09:02:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd6z7-00060E-SA; Sat, 09 Apr 2022 09:02:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd6z7-0001DX-Oj; Sat, 09 Apr 2022 09:02:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd6z6-0007DB-TV; Sat, 09 Apr 2022 09:02:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nd6z6-0000xd-Sd; Sat, 09 Apr 2022 09:02:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7+XiFpdv3SLvkKkMtEF5KrRli5QXb1FaZ3zHL/A6bJo=; b=xfEdJyCJNo6dU9W2w79g6ejfZ4
	965CB2iueKqxzNKKDAwF5SObmGUTbeKyAJw8xCih1Br7cmdGku5oV4emuOdBMZ3QIMtKbITXdZJwi
	5ydLntlxMZ0w7yxO+BLPgOkXyRc61fCLvw9wq0Q5KsnAI9vXcYRsG5WlGKkzQzTLCunY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169240-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 169240: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.13-testing:test-amd64-i386-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:heisenbug
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fe97133b5deef58bd1422f4d87821131c66b1d0e
X-Osstest-Versions-That:
    xen=169a2834ef5d723091f187a5d6493ae77825757a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 09:02:20 +0000

flight 169240 xen-4.13-testing real [real]
flight 169256 xen-4.13-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169240/
http://logs.test-lab.xenproject.org/osstest/logs/169256/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail pass in 169256-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169180
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169180
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169180
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169180
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169180
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169180
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169180
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169180
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169180
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169180
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169180
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169180
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  fe97133b5deef58bd1422f4d87821131c66b1d0e
baseline version:
 xen                  169a2834ef5d723091f187a5d6493ae77825757a

Last test of basis   169180  2022-04-05 13:37:39 Z    3 days
Testing same since   169240  2022-04-08 13:36:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   169a2834ef..fe97133b5d  fe97133b5deef58bd1422f4d87821131c66b1d0e -> stable-4.13


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 09:11:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 09:11:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302119.515669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd78D-0007oE-Bi; Sat, 09 Apr 2022 09:11:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302119.515669; Sat, 09 Apr 2022 09:11:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd78D-0007o7-8O; Sat, 09 Apr 2022 09:11:45 +0000
Received: by outflank-mailman (input) for mailman id 302119;
 Sat, 09 Apr 2022 09:11:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nd78C-0007o1-Dg
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 09:11:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd787-0001Nv-Sv; Sat, 09 Apr 2022 09:11:39 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd787-0003JL-LR; Sat, 09 Apr 2022 09:11:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=NyjRqjcjAzTV7LrhXX19rU681YKP+XHrm9dw2xBFycQ=; b=ZvU/ewVkm9qx8j9zc5vISGa6i4
	CsBLL96nA5+faz2nHEMkbWqtXSUYATFObuHUAPYSefFtnG0w3hvyOOhzP8F/bkX0RFCU4SKubfPjL
	hEd4RMkWTJ6evzJfFnFH8r/2SJYEeyRK5yUCP0XqmvOLeqJwiTkccUX4yLICnfrW3FoA=;
Message-ID: <f8627956-8b01-6a5d-d69a-d2da16d74726@xen.org>
Date: Sat, 9 Apr 2022 10:11:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v1 02/13] xen/arm: introduce a special domain DOMID_SHARED
To: Stefano Stabellini <sstabellini@kernel.org>,
 Jan Beulich <jbeulich@suse.com>
Cc: Penny Zheng <Penny.Zheng@arm.com>, nd@arm.com,
 Penny Zheng <penzhe01@a011292.shanghai.arm.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-3-Penny.Zheng@arm.com>
 <eefa9cf2-a04c-ba8d-74cb-0d2aaa35badb@suse.com>
 <alpine.DEB.2.22.394.2203181443440.2910984@ubuntu-linux-20-04-desktop>
 <30a6ef6f-d37c-b66c-d5af-be2208766057@suse.com>
 <alpine.DEB.2.22.394.2203211256370.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2203211256370.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 21/03/2022 20:03, Stefano Stabellini wrote:
> On Mon, 21 Mar 2022, Jan Beulich wrote:
>> On 18.03.2022 22:50, Stefano Stabellini wrote:
>>> On Fri, 18 Mar 2022, Jan Beulich wrote:
>>>> On 11.03.2022 07:11, Penny Zheng wrote:
>>>>> In case to own statically shared pages when owner domain is not
>>>>> explicitly defined, this commits propose a special domain DOMID_SHARED,
>>>>> and we assign it 0x7FF5, as one of the system domains.
>>>>>
>>>>> Statically shared memory reuses the same way of initialization with static
>>>>> memory, hence this commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap
>>>>> related codes, and this option depends on static memory(CONFIG_STATIC_MEMORY).
>>>>>
>>>>> We intends to do shared domain creation after setup_virt_paging so shared
>>>>> domain could successfully do p2m initialization.
>>>>
>>>> There's nothing said here, in the earlier patch, or in the cover letter
>>>> about the security aspects of this. There is a reason we haven't been
>>>> allowing arbitrary, un-supervised sharing of memory between domains. It
>>>> wants clarifying why e.g. grants aren't an option to achieve what you
>>>> need, and how you mean to establish which domains are / aren't permitted
>>>> to access any individual page owned by this domain.
>>>
>>>
>>> I'll let Penny write a full reply but I'll chime in to try to help with
>>> the explanation.
>>>
>>> This is not arbitrary un-supervised sharing of memory between domains,
>>> which indeed is concerning.
>>>
>>> This is statically-configured, supervised by the system configurator,
>>> sharing of memory between domains.
>>>
>>> And in fact safety (which is just a different aspect of security) is one
>>> of the primary goals for this work.
>>>
>>> In safety-critical environments, it is not considered safe to
>>> dynamically change important configurations at runtime. Everything
>>> should be statically defined and statically verified.
>>>
>>> In this case, if the system configuration knows a priori that there are
>>> only 2 VM and they need to communication over shared memory, it is safer
>>> to pre-configure the shared memory at build time rather than let the VMs
>>> attempt to share memory at runtime. It is faster too.
>>>
>>> The only way to trigger this static shared memory configuration should
>>> be via device tree, which is at the same level as the XSM rules
>>> themselves.
>>>
>>> Hopefully I made things clearer and not murkier :-)
>>
>> It adds some helpful background, yes, but at the same time it doesn't
>> address the security concern at all: How are access permissions
>> managed when the owning domain is a special one? I haven't spotted
>> any recording of the domains which are actually permitted to map /
>> access the pages in questions. (But of course I also only looked at
>> non-Arm-specific code. I'd expect such code not to live in arch-
>> specific files.)
> 
> All this static memory sharing is statically done at __init time only.
> It should not be possible to trigger any further memory sharing at
> runtime (if there is, that would be a bug). 

Looking at the code, get_pg_owner() will be able to handle DOMID_SHARED. 
So anyone that is permitted to access DOMID_SHARED will be able to map 
any memory region at runtime.

> There are no new interfaces for the guest to map this memory because it
> is already "pre-mapped".

It can via XENMAPSPACE_gmfn_foreign (assuming proper permission).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 09:14:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 09:14:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302124.515681 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7AY-0008OZ-R5; Sat, 09 Apr 2022 09:14:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302124.515681; Sat, 09 Apr 2022 09:14:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7AY-0008OS-ML; Sat, 09 Apr 2022 09:14:10 +0000
Received: by outflank-mailman (input) for mailman id 302124;
 Sat, 09 Apr 2022 09:14:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YAo9=UT=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nd7AX-0008OI-0F
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 09:14:09 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6874d6b7-b7e5-11ec-a405-831a346695d4;
 Sat, 09 Apr 2022 11:14:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id AEFE7210E6;
 Sat,  9 Apr 2022 09:14:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4DB9913A77;
 Sat,  9 Apr 2022 09:14:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id L3bkEF5OUWKJXAAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 09 Apr 2022 09:14:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6874d6b7-b7e5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1649495646; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=t4w53XSf5KLPSx/o1mAVdkKDvSYk1M+tQSf5nQtDeRY=;
	b=XSiJ/sSFUoZ7zdh1ZdhK5xmc6dwFoj9ucN6V068Xn/24XPa3HQIifLAMmfZDRKGmpMNcwd
	xPJL8hM3MC3KccndCfxPZBRomN1KMfAXsc3maou9HH5c5phQ4oURLF8QC6cYIUKwPBKDoi
	EIOr8lUQuAqn3zMebW2WvGJhnP/MlxA=
Message-ID: <8c4b7915-28c7-e0b8-6c13-17ca1f3bd4cf@suse.com>
Date: Sat, 9 Apr 2022 11:14:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
 Jan Beulich <jbeulich@suse.com>
Cc: Luca Fancellu <Luca.Fancellu@arm.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
 <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com>
 <511b60be-c6c6-d13a-b9aa-40e67e5a1b1c@suse.com>
 <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------tz4HOuIadS0hLCkm0GUPFcrU"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------tz4HOuIadS0hLCkm0GUPFcrU
Content-Type: multipart/mixed; boundary="------------jcDmYxOMg3ZQDow11SCUgYpr";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
 Jan Beulich <jbeulich@suse.com>
Cc: Luca Fancellu <Luca.Fancellu@arm.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <8c4b7915-28c7-e0b8-6c13-17ca1f3bd4cf@suse.com>
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
 <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com>
 <511b60be-c6c6-d13a-b9aa-40e67e5a1b1c@suse.com>
 <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>

--------------jcDmYxOMg3ZQDow11SCUgYpr
Content-Type: multipart/mixed; boundary="------------WiQXL9sFlfdX0ec9pD9ETKgw"

--------------WiQXL9sFlfdX0ec9pD9ETKgw
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDQuMjIgMjI6MjUsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gT24gRnJp
LCA4IEFwciAyMDIyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDA4LjA0LjIwMjIgMTM6
MzcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4NCj4+Pg0KPj4+PiBPbiA4IEFwciAyMDIy
LCBhdCAxMDowMSwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+
Pj4NCj4+Pj4gT24gMDguMDQuMjAyMiAxMDo0NSwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+
Pj4+IC0tLQ0KPj4+Pj4gZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9jcHVwb29scy50eHQg
fCAxNDAgKysrKysrKysrKysrKysrKysNCj4+Pj4+IHhlbi9hcmNoL2FybS9pbmNsdWRlL2Fz
bS9zbXAuaCAgICAgICAgIHwgICAzICsNCj4+Pj4+IHhlbi9jb21tb24vS2NvbmZpZyAgICAg
ICAgICAgICAgICAgICAgIHwgICA3ICsNCj4+Pj4+IHhlbi9jb21tb24vTWFrZWZpbGUgICAg
ICAgICAgICAgICAgICAgIHwgICAxICsNCj4+Pj4+IHhlbi9jb21tb24vYm9vdF9jcHVwb29s
cy5jICAgICAgICAgICAgIHwgMjA3ICsrKysrKysrKysrKysrKysrKysrKysrKysNCj4+Pj4+
IHhlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5jICAgICAgICAgICAgIHwgIDEyICstDQo+Pj4+
PiB4ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaCAgICAgICAgICAgICAgICB8ICAxNCArKw0KPj4+
Pj4gNyBmaWxlcyBjaGFuZ2VkLCAzODMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0K
Pj4+Pj4gY3JlYXRlIG1vZGUgMTAwNjQ0IGRvY3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvY3B1
cG9vbHMudHh0DQo+Pj4+PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2NvbW1vbi9ib290X2Nw
dXBvb2xzLmMNCj4+Pj4NCj4+Pj4gVW5kZXIgd2hvc2UgbWFpbnRhaW5lcnNoaXAgaXMgdGhl
IG5ldyBmaWxlIHRvIGZhbGw/IFdpdGhvdXQgYW4NCj4+Pj4gYWRkaXRpb24gdG8gLi9NQUlO
VEFJTkVSUyBhbmQgd2l0aG91dCB0aGUgZmlsZSBiZWluZyBwbGFjZWQgaW4NCj4+Pj4geGVu
L2NvbW1vbi9zY2hlZC8sIGl0J2xsIGJlIFJFU1QgbWFpbnRhaW5lcnMsIHdoaWNoIEkgdGhp
bmsgd291bGQNCj4+Pj4gYmV0dGVyIGJlIGF2b2lkZWQuIFdvdWxkIGl0IHBlcmhhcHMgbWFr
ZSBzZW5zZSB0byBoYXZlIHRoaXMgYXMNCj4+Pj4geGVuL2NvbW1vbi9zY2hlZC9ib290LmMs
IGFsbG93aW5nIG90aGVyIGJvb3Qtb25seSBjb2RlIHRvDQo+Pj4+IHBvdGVudGlhbGx5IGJl
IG1vdmVkIHRoZXJlIG92ZXIgdGltZT8gVGhpcyB3b3VsZCB0aGVuIGFsc28gYXZvaWQNCj4+
Pj4gbWUgYXNraW5nIGFib3V0IHRoZSB1bmRlcnNjb3JlIGluIHRoZSBmaWxlIG5hbWU6IFVu
ZGVyc2NvcmVzIGFyZQ0KPj4+PiBhIHNvbWV3aGF0IGFydGlmaWNpYWwgdGhpbmcgZm9yIHVz
ZSBpbiBwbGFjZXMgd2hlcmUgZGFzaGVzIGNhbid0DQo+Pj4+IGJlIHVzZWQuIFlldCBpbiB0
aGUgZmlsZSBzeXN0ZW0gZGFzaGVzIGFyZSBmaW5lLCBhbmQgZGFzaGVzIGFyZQ0KPj4+PiAo
c2xpZ2h0bHkpIGVhc2llciB0byB0eXBlLg0KPj4+Pg0KPj4+DQo+Pj4gT2sgSSBjYW4gcHV0
IHRoZSBuZXcgZmlsZSB1bmRlciB4ZW4vY29tbW9uL3NjaGVkLyBhcyBib290LmMsIHNob3Vs
ZCB0aGlzIG5ldw0KPj4+IGZpbGUgYmUgdW5kZXIgdGhpcyBzZWN0aW9uPw0KPj4+DQo+Pj4g
Q1BVIFBPT0xTDQo+Pj4gTTogIEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+
PiBNOiAgRGFyaW8gRmFnZ2lvbGkgPGRmYWdnaW9saUBzdXNlLmNvbT4NCj4+PiBTOiAgU3Vw
cG9ydGVkDQo+Pj4gRjogIHhlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5jDQo+Pj4gKyBGOiAg
eGVuL2NvbW1vbi9zY2hlZC9ib290LmMNCj4+DQo+PiBJZiBpdCdzIHRvIGhvbGQgZ2VuZXJh
bCBzY2hlZHVsZXIgY29kZSAod2hpY2ggdGhpcyBzaG9ydGVyIG5hbWUgd291bGQNCj4+IHN1
Z2dlc3QpLCBpdCBzaG91bGRuJ3QgbmVlZCBhbnkgY2hhbmdlIHRvIC4vTUFJTlRBSU5FUlMg
YXMgdGhlDQo+PiBzY2hlZHVsZXIgc2VjdGlvbiB3b3VsZCBhbHJlYWR5IGNvdmVyIGl0IHRo
ZW4uIElmIGl0IHdhcyB0byByZW1haW4NCj4+IENQVS1wb29scy1zcGVjaWZpYywgdGhlbiB5
b3UnZCBuZWVkIHRvIHN0aWNrIHRvIHRoZSBsb25nZXIgbmFtZSBhbmQNCj4+IHB1dCBpdCBp
biB0aGUgc2VjdGlvbiB5b3UgaGF2ZSByZXByb2R1Y2VkIGFib3ZlLg0KPiANCj4gSW4gbXkg
b3BpbmlvbiBpdCBpcyBiZXN0IGlmIHRoZSBtYWludGVuYW5jZSBvZiBib290X2NwdXBvb2xz
LmMgZmFsbHMNCj4gdW5kZXIgIkNQVSBQT09MUyIuIEx1Y2EsIHlvdSBjYW4gcmV0YWluIG15
IHJldmlld2VkLWJ5IHdoZW4geW91IGFkZA0KPiB0aGUgY2hhbmdlIHRvIE1BSU5UQUlORVJT
IG9yIHJlbmFtZSB0aGUgZmlsZS4NCj4gDQo+IEkgZG9uJ3QgaGF2ZSBhbiBvcGluaW9uIGlm
IGl0IHNob3VsZCBiZSBjYWxsZWQNCj4geGVuL2NvbW1vbi9ib290X2NwdXBvb2xzLmMgb3Ig
eGVuL2NvbW1vbi9ib290LWNwdXBvb2xzLmMNCj4gDQoNCkknZCBnbyB3aXRoIHhlbi9jb21t
b24vc2NoZWQvYm9vdC1jcHVwb29sLmMNCg0KDQpKdWVyZ2VuDQo=
--------------WiQXL9sFlfdX0ec9pD9ETKgw
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------WiQXL9sFlfdX0ec9pD9ETKgw--

--------------jcDmYxOMg3ZQDow11SCUgYpr--

--------------tz4HOuIadS0hLCkm0GUPFcrU
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJRTl0FAwAAAAAACgkQsN6d1ii/Ey99
lwf/XOIK7Yd5P0kDMlhZrJunwO5NCys0ynX/QQsJGplg3uGyT/WQfHbANgVMHZ9xdnOroJsf36Sq
QjMkMvTPw7ds+NbA4CghjGYBI1raKaq77IR5Kq95PmoA63Eck/NB19cfx34gY0E0NXCURKOWUEoW
SdspQXWt6xysoEJnzJ47SyDF9vZWpRgELH3GTVBAIzA5mA/CBh2LL+Ao1gBPmtaSh+0PnOHWXSIP
LrNOp8x4dAj8IZBS5wRgdITLgULqeHD/PuPDqdW3LhzfMiGGOa6HzkeVt2EBV76qTv15zKOIlbWP
SHtFA7WQksR9fIlDJ4hPawznfCLUTeE8q5/ZrkxVvw==
=x+7x
-----END PGP SIGNATURE-----

--------------tz4HOuIadS0hLCkm0GUPFcrU--


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 09:14:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 09:14:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302127.515692 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7BH-0000VW-3x; Sat, 09 Apr 2022 09:14:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302127.515692; Sat, 09 Apr 2022 09:14:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7BH-0000VN-0A; Sat, 09 Apr 2022 09:14:55 +0000
Received: by outflank-mailman (input) for mailman id 302127;
 Sat, 09 Apr 2022 09:14:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nd7BF-0000VF-Rt
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 09:14:53 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd7BE-0001Qa-On; Sat, 09 Apr 2022 09:14:52 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd7BE-0003SN-JV; Sat, 09 Apr 2022 09:14:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=WFAsVG1BZCYpAHsTF+WCOg3c33JqOuM8/oTwhWByfRo=; b=vjv8moD7j6OR9VagOROUHLAZSa
	RTK5xALnPQSODXPpigdZiMqSB8a9BTxWWRa0WqJ3hgIz6GzGYS8+1EgWca0TG44gfIIRNj0V38sFi
	NIRrjxD9WaR15jlpXMJXjAu79pVKDzNy5cXVD5df4VqElTi40EMK6NmzrQ/bWhT6sXHI=;
Message-ID: <adfb6995-b241-792c-51ef-59364a441976@xen.org>
Date: Sat, 9 Apr 2022 10:14:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v1 11/13] xen/arm: store shm-info for deferred foreign
 memory map
To: Stefano Stabellini <sstabellini@kernel.org>,
 Penny Zheng <Penny.Zheng@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 nd <nd@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-12-Penny.Zheng@arm.com>
 <alpine.DEB.2.22.394.2203171831410.3497@ubuntu-linux-20-04-desktop>
 <DU2PR08MB732592AD40BAA48F390445AAF71E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204081523110.3066615@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204081523110.3066615@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 08/04/2022 23:46, Stefano Stabellini wrote:
> So I don't think that when the owner dies, we need to actively go and
> unmap the pages at the borrowers. Also because it would likely cause
> them to crash: from their point of view the memory was there, and
> suddenly it is not there anymore.

I agree with that. Also, the code is likely going to be quite complex 
because there are a lot of things that can go wrong (e.g. the domain ID 
has been re-used). I will comment there directly.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 09:26:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 09:26:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302134.515702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7M2-0002K3-25; Sat, 09 Apr 2022 09:26:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302134.515702; Sat, 09 Apr 2022 09:26:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7M1-0002Jw-VR; Sat, 09 Apr 2022 09:26:01 +0000
Received: by outflank-mailman (input) for mailman id 302134;
 Sat, 09 Apr 2022 09:26:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nd7M0-0002Jq-Fe
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 09:26:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd7M0-0001dI-3r; Sat, 09 Apr 2022 09:26:00 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd7Lz-000475-Um; Sat, 09 Apr 2022 09:26:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=Peckepcy7UonTRhBMBevPoPjsLWpmUfXjHGWe8OanzU=; b=tJfUAQIgWqY3Q6Q3WVZiPEeL4x
	EX5mATbxSdjzZ20WOXT7gRFURctP5TYF4Cp41rNhJLmPE3YceP2iQuv8J7Lpcvb+/mJjcxlN8cWt/
	QkVvfXO/gtHF0gW815B8d9sZAEwUAO1V61iZV8x6P8QHN/RSf5ROlrln5CFmKMaXOanM=;
Message-ID: <7c6a3af7-6052-aab8-829c-bc2c2a5db341@xen.org>
Date: Sat, 9 Apr 2022 10:25:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: nd@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-9-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v1 08/13] xen/arm: destroy static shared memory when
 de-construct domain
In-Reply-To: <20220311061123.1883189-9-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 11/03/2022 06:11, Penny Zheng wrote:
> From: Penny Zheng <penny.zheng@arm.com>
> 
> This commit introduces a new helper destroy_domain_shm to destroy static
> shared memory at domain de-construction.
> 
> This patch only considers the scenario where the owner domain is the
> default dom_shared, for user-defined owner domain, it will be covered in
> the following patches.
> 
> Since all domains are borrower domains, we could simply remove guest P2M
> foreign mapping of statically shared memory region and drop the reference
> added at guest_physmap_add_shm.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   xen/arch/arm/domain.c | 48 +++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 48 insertions(+)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 1ff1df5d3f..f0bfd67fe5 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -34,6 +34,7 @@
>   #include <asm/platform.h>
>   #include <asm/procinfo.h>
>   #include <asm/regs.h>
> +#include <asm/setup.h>
>   #include <asm/tee/tee.h>
>   #include <asm/vfp.h>
>   #include <asm/vgic.h>
> @@ -993,6 +994,48 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list)
>       return ret;
>   }
>   
> +#ifdef CONFIG_STATIC_SHM
> +static int domain_destroy_shm(struct domain *d)
> +{
> +    int ret = 0;
> +    unsigned long i = 0UL, j;
> +
> +    if ( d->arch.shm_mem == NULL )
> +        return ret;

You already return the value here. So...

> +    else

... the else is pointless.

> +    {
> +        for ( ; i < d->arch.shm_mem->nr_banks; i++ )
> +        {
> +            unsigned long nr_gfns = PFN_DOWN(d->arch.shm_mem->bank[i].size);
> +            gfn_t gfn = gaddr_to_gfn(d->arch.shm_mem->bank[i].start);
> +
> +            for ( j = 0; j < nr_gfns; j++ )
> +            {
> +                mfn_t mfn;
> +
> +                mfn = gfn_to_mfn(d, gfn_add(gfn, j));

A domain is allowed to modify its P2M. So there are no guarantee that 
the GFN will still point to the shared memory. This will allow the guest...

> +                if ( !mfn_valid(mfn) )
> +                {
> +                    dprintk(XENLOG_ERR,
> +                            "Domain %pd page number %lx invalid.\n",
> +                            d, gfn_x(gfn) + i);
> +                    return -EINVAL;

... to actively prevent destruction.

> +                }


> +
> +                ret = guest_physmap_remove_page(d, gfn_add(gfn, j), mfn, 0);
> +                if ( ret )
> +                    return ret;
> +
> +                /* Drop the reference. */
> +                put_page(mfn_to_page(mfn));

guest_physmap_remove_page() will already drop the reference taken for 
the foreign mapping. I couldn't find any other reference taken, what is 
the put_page() for?

Also, as per above we don't know whether this is a page from the shared 
page. So we can't blindly call put_page().

However, I don't think we need any specific code here. We can rely on 
relinquish_p2m_mappings() to drop any reference. If there is an extra 
one for shared mappings, then we should update p2m_put_l3_page().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 09:30:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 09:30:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302139.515714 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7QP-0003yc-K3; Sat, 09 Apr 2022 09:30:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302139.515714; Sat, 09 Apr 2022 09:30:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7QP-0003yV-H2; Sat, 09 Apr 2022 09:30:33 +0000
Received: by outflank-mailman (input) for mailman id 302139;
 Sat, 09 Apr 2022 09:30:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nd7QO-0003yP-Vo
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 09:30:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd7QO-0001gy-QQ; Sat, 09 Apr 2022 09:30:32 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd7QO-0004MR-L2; Sat, 09 Apr 2022 09:30:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=0q9wc+dUtbtI/11yxD51N00qgvt9rlc7WiCMSXR84qM=; b=SRPcpJ5b/pDD13EblhKfuETSFr
	BapwVQGjdZnNiQdZLSX6OqjSFS0Dwr4v0fJLbjO/KeE/MPoxG5oFM/ebkiWNGaDJDsCy6RNVxVkxG
	3rj/BT6pbwJkAnqzS+dh1N8/ynsWjDYVsEKJxfDDYdHcaAWuF6wytKjRiUdAqIahK5ro=;
Message-ID: <b34727d4-1e8d-64fd-9d5e-84ed4255c320@xen.org>
Date: Sat, 9 Apr 2022 10:30:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
From: Julien Grall <julien@xen.org>
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: nd@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-7-Penny.Zheng@arm.com>
 <c4a3fb77-1cab-aacf-a2a5-3702f9c4ab97@xen.org>
In-Reply-To: <c4a3fb77-1cab-aacf-a2a5-3702f9c4ab97@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 08/04/2022 23:59, Julien Grall wrote:
> On 11/03/2022 06:11, Penny Zheng wrote:
>> From: Penny Zheng <penny.zheng@arm.com>
>>
>> This commits introduces a new helper guest_physmap_add_shm to set up 
>> shared
>> memory foreign mapping for borrower domain.
>>
>> Firstly it should get and take reference of statically shared pages from
>> owner dom_shared. Then it will setup P2M foreign memory map of these 
>> statically
>> shared pages for borrower domain.
>>
>> This commits only considers owner domain is the default dom_shared, the
>> other scenario will be covered in the following patches.
>>
>> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
>> ---
>>   xen/arch/arm/domain_build.c | 52 +++++++++++++++++++++++++++++++++++++
>>   1 file changed, 52 insertions(+)
>>
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 984e70e5fc..8cee5ffbd1 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -798,6 +798,48 @@ static int __init allocate_shared_memory(struct 
>> domain *d,
>>       return ret;
>>   }
>> +static int __init guest_physmap_add_shm(struct domain *od, struct 
>> domain *bd,
>> +                                        unsigned long o_gfn,
>> +                                        unsigned long b_gfn,
>> +                                        unsigned long nr_gfns)
>> +{
>> +    struct page_info **pages = NULL;
>> +    p2m_type_t p2mt, t;
>> +    int ret = 0;
> 
> You don't need to initialize ret.
> 
>> +
>> +    pages = xmalloc_array(struct page_info *, nr_gfns);
>> +    if ( !pages )
>> +        return -ENOMEM;
>> +
>> +    /*
>> +     * Take reference of statically shared pages from owner domain.
>> +     * Reference will be released when destroying shared memory region.
>> +     */
>> +    ret = get_pages_from_gfn(od, o_gfn, nr_gfns, pages, &p2mt, 
>> P2M_ALLOC);
>> +    if ( ret )
>> +    {
>> +        ret = -EINVAL;
>> +        goto fail_pages;
>> +    }
>> +
>> +    if ( p2m_is_ram(p2mt) )
>> +        t = (p2mt == p2m_ram_rw) ? p2m_map_foreign_rw : 
>> p2m_map_foreign_ro;
>> +    else
>> +    {
>> +        ret = -EINVAL;
>> +        goto fail_pages;
> 
> Where would we release the references?
> 
>> +    }
>> +
>> +    /* Set up guest foreign map. */
>> +    ret = guest_physmap_add_pages(bd, _gfn(b_gfn), 
>> page_to_mfn(pages[0]),
>> +                                  nr_gfns, t);
> 
> A few things:
>    - The beginning of the code assumes that the MFN may be discontiguous 
> in the physical memory. But here, you are assuming they are contiguous. 
> If you want the latter, then you should check the MFNs are contiguous. 
> That said, I am not sure if this restriction is really necessary.
> 
>    - IIRC, guest_physmap_add_pages() doesn't revert the mappings. So you 
> need to revert it in case of failure.


There is another issue here. guest_physmap_add_pages() may use superpage 
mapping. The P2M code is currently assuming the foreing mapping will be 
using L3 mapping (4KB).

Do you need to use superpage mapping here?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 09:44:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 09:44:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302145.515725 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7e4-0005pI-0N; Sat, 09 Apr 2022 09:44:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302145.515725; Sat, 09 Apr 2022 09:44:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd7e3-0005pB-TI; Sat, 09 Apr 2022 09:44:39 +0000
Received: by outflank-mailman (input) for mailman id 302145;
 Sat, 09 Apr 2022 09:44:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nd7e3-0005p5-7j
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 09:44:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd7e2-0001wH-VF; Sat, 09 Apr 2022 09:44:38 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nd7e2-0005Sn-Pm; Sat, 09 Apr 2022 09:44:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=fzERs1kviIvjjzyupRx/3OkO6phfvv6S3S9sSXlOZe4=; b=Z1SrrOBV4pi+g8OoOxPfBogfzF
	MTbKDj0EwKpPR0u+3S8K+Hit7cglj45GQl5tdboL4wuW2lsueRjd+032kmewU7KAiYGa2ihFX1kx7
	JMsFEgkrepoXZbsGn3+zO7XCLwfBi11KLdvmk0uV3E6GGi4cpY5C4XxpozM+BxuwxGRc=;
Message-ID: <8808802f-feca-bd21-8bbe-ba4f1b9ce5f1@xen.org>
Date: Sat, 9 Apr 2022 10:44:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: nd@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-14-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v1 13/13] xen/arm: unmap foreign memory mapping when
 destroyed domain is owner domain
In-Reply-To: <20220311061123.1883189-14-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 11/03/2022 06:11, Penny Zheng wrote:
> From: Penny Zheng <penny.zheng@arm.com>
> 
> When destroyed domain is an owner domain of a static shared memory
> region, then we need to ensure that all according borrower domains
> shall not have the access to this static shared memory region too.

As Stefano wrote, I don't think this is necessary. The page reference 
accounting will keep the page alive until everyone have released the page.

So can you explain why you want to do that?

> 
> This commit covers above scenario through unmapping all borrowers'
> according foreign memory mapping when destroyed domain is a owner
> domain of a static shared memory region.
> 
> NOTE: It will best for users to destroy all borrowers before the owner
> domain in case encountering data abort when accidentally accessing
> the static shared memory region.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   xen/arch/arm/domain.c | 88 ++++++++++++++++++++++++++++++++++---------
>   1 file changed, 71 insertions(+), 17 deletions(-)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 73ffbfb918..8f4a8dcbfc 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -998,10 +998,39 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list)
>   }
>   
>   #ifdef CONFIG_STATIC_SHM
> +static int destroy_shm(struct domain *d, gfn_t gfn, unsigned long nr_gfns)
If you still plan to go ahead with this approach, then I would prefer if 
this function is created in patch #8. This will help to reduce the churn 
in this patch.

[...]

> -            for ( j = 0; j < nr_gfns; j++ )
> +            if ( test_bit(shm_id, shm_list_mask) )
>               {
> -                mfn_t mfn;
> -
> -                mfn = gfn_to_mfn(d, gfn_add(gfn, j));
> -                if ( !mfn_valid(mfn) )
> +                domid_t od = shm_list[shm_id].owner_dom;
> +                unsigned long j;
> +                /*
> +                 * If it is a owner domain, then after it gets destroyed,
> +                 * static shared memory region shall be unaccessible to all
> +                 * borrower domains too.
> +                 */
> +                if ( d->domain_id == od )
>                   {
> -                    dprintk(XENLOG_ERR,
> -                            "Domain %pd page number %lx invalid.\n",
> -                            d, gfn_x(gfn) + i);
> -                    return -EINVAL;
> +                    struct domain *bd;
> +
> +                    for ( j = 0; j < shm_list[shm_id].nr_borrower; j++ )
> +                    {
> +                        bd = get_domain_by_id(shm_list[shm_id].borrower_dom[j]);
> +                        /*
> +                         * borrower domain could be dead already, in such case
> +                         * no need to do the unmapping.

The domain ID could have been re-used. So it is not enough to lookup for 
the ID.

> +                         */
> +                        if ( bd != NULL )
> +                        {
> +                            gfn_t b_gfn = gaddr_to_gfn(
> +                                          shm_list[shm_id].borrower_gbase[j]);
> +                            ret = destroy_shm(bd, b_gfn, nr_gfns);
> +                            if ( ret )
> +                                dprintk(XENLOG_ERR,
> +                                        "Domain %pd: failed to destroy static shared memory.\n",
> +                                        bd);

In the commit message, you wrote you want to remove the pages from the 
borrower. But here, you will ignore a failure and continue to destroy 
the owner like nothing happened.

If you are concerned that the borrower can still use the pages. Then we 
should make sure that they are removed in every cases.

However, I think the code is going to quite complex. So I think we 
should consider to do nothing here and let the borrower use the pages 
until they die.

Potentially, we could notify the borrowers that the owner died so they 
can decide to remove/shutdown themself. Of course, it would mean we are 
relying on the borrowers to be nice. An alternative would be to destroy 
them.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 11:34:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 11:34:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302157.515760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd9Lr-0002al-98; Sat, 09 Apr 2022 11:33:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302157.515760; Sat, 09 Apr 2022 11:33:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nd9Lr-0002ae-5x; Sat, 09 Apr 2022 11:33:59 +0000
Received: by outflank-mailman (input) for mailman id 302157;
 Sat, 09 Apr 2022 11:33:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd9Lq-0002aP-93; Sat, 09 Apr 2022 11:33:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd9Lq-0003rh-7O; Sat, 09 Apr 2022 11:33:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nd9Lp-0008QK-PY; Sat, 09 Apr 2022 11:33:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nd9Lp-0007QN-Oo; Sat, 09 Apr 2022 11:33:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UUyFRExey6OcJo70aELsdiyP0X37X0He1k5b4O5wRNc=; b=NLUV+XEaT6YSScRuk28ofoxUUn
	LjXm9yRsOJzjYvRZ7wQLcy1larpLUoSacMkvJQylh2Y4ypjFT1EB43VTAHd9d+O9oCqXzePZ9ea2p
	XSXdsMQ8hH/2TKs63cjQuR/ei1FUFuKOBAlVkMcvC+pUY/USMw4rSTuKWil2TUMBhr3k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169241-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169241: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=eeaf24ccedf79941a4d1511daca4966b4e03cb91
X-Osstest-Versions-That:
    xen=d7b22226b5172c86c0c19b23edc16a4432d04fb8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 11:33:57 +0000

flight 169241 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169241/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169212
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169212
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169212
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169212
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169212
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169212
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169212
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169212
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169212
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169212
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169212
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169212
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  eeaf24ccedf79941a4d1511daca4966b4e03cb91
baseline version:
 xen                  d7b22226b5172c86c0c19b23edc16a4432d04fb8

Last test of basis   169212  2022-04-07 07:36:23 Z    2 days
Testing same since   169241  2022-04-08 13:36:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d7b22226b5..eeaf24cced  eeaf24ccedf79941a4d1511daca4966b4e03cb91 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 14:33:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 14:33:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302192.515774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndC9I-0007Wi-GW; Sat, 09 Apr 2022 14:33:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302192.515774; Sat, 09 Apr 2022 14:33:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndC9I-0007Wb-Dh; Sat, 09 Apr 2022 14:33:12 +0000
Received: by outflank-mailman (input) for mailman id 302192;
 Sat, 09 Apr 2022 14:33:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a16u=UT=suse.de=colyli@srs-se1.protection.inumbo.net>)
 id 1ndC9G-0007WU-1f
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 14:33:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f88f25fa-b811-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 16:33:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 207A11F864;
 Sat,  9 Apr 2022 14:33:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F41913AA1;
 Sat,  9 Apr 2022 14:32:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id m2GpARiZUWLHIgAAMHmgww
 (envelope-from <colyli@suse.de>); Sat, 09 Apr 2022 14:32:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f88f25fa-b811-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1649514786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BmOfl4NqddautzOtQrZ0dLuhiQSp1fB0SDxF8v7gYBA=;
	b=SJlQufjnXjTQtqgkhM6MsOUPDPwOMZ6xGLQ76UNS6RR1cEGIg2CW/GZ7A0Nq9xE2LKzjCQ
	zm4gbJFRwGS5ZR58/OOlzltxzH57NlfDQ1MS9kgXiNk7elM8N3NSClk0AEwvrheO6NCJzw
	l51uuNG8cURr+Q1l6/il4XbIWcEO2Fg=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1649514786;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BmOfl4NqddautzOtQrZ0dLuhiQSp1fB0SDxF8v7gYBA=;
	b=yiH+qx8I6hbeCP31rtrhbZE5qxMo8OqYiXG+UWOpJ9wghAOQqadl62X34RS7V0fnDyonaX
	HzX10h1d2uotqQBQ==
Message-ID: <f01ac878-9b0d-972b-70dc-6f3f61b9947b@suse.de>
Date: Sat, 9 Apr 2022 22:32:52 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from
 REQ_OP_DISCARD
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 nbd@other.debian.org, ceph-devel@vger.kernel.org,
 virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
 Jens Axboe <axboe@kernel.dk>, linux-bcache@vger.kernel.org,
 linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
 linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
 linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
 target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
 linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
 cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
 linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
 ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
 "Martin K . Petersen" <martin.petersen@oracle.com>,
 =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= <christoph.boehmwalder@linbit.com>,
 Ryusuke Konishi <konishi.ryusuke@gmail.com>, David Sterba <dsterba@suse.com>
References: <20220409045043.23593-1-hch@lst.de>
 <20220409045043.23593-27-hch@lst.de>
From: Coly Li <colyli@suse.de>
In-Reply-To: <20220409045043.23593-27-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 4/9/22 12:50 PM, Christoph Hellwig wrote:
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint.  Fully split the limits and helper
> infrastructure to make the separation more clear.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
> Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> [nifs2]
> Acked-by: Coly Li <colyli@suse.de> [drbd]

Hi Christoph,

My ACK is for bcache, not drbd here.

Thanks.


Coly Li



> Acked-by: David Sterba <dsterba@suse.com> [btrfs]







From xen-devel-bounces@lists.xenproject.org Sat Apr 09 14:41:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 14:41:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302199.515786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndCGs-0000nl-9A; Sat, 09 Apr 2022 14:41:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302199.515786; Sat, 09 Apr 2022 14:41:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndCGs-0000ne-60; Sat, 09 Apr 2022 14:41:02 +0000
Received: by outflank-mailman (input) for mailman id 302199;
 Sat, 09 Apr 2022 14:41:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndCGr-0000nT-Mr; Sat, 09 Apr 2022 14:41:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndCGr-0007Aq-JU; Sat, 09 Apr 2022 14:41:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndCGr-0001p4-26; Sat, 09 Apr 2022 14:41:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndCGr-0003sV-1R; Sat, 09 Apr 2022 14:41:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qISomQut9xQCtszc0u4kldVT7E4FGGOSRPZLFO9ohQE=; b=mEjVlkOiW4uYvvLbH9U7S8Xmuu
	2UjTnlDRuVhLcOcHnkcv6Dh1jKQDJWux3GX5WKSwhAogCzlJiP+pPAOReWOEBTBY9C7HNNKWY0xXA
	9ocJT8KjPw/zZ81suxVVJUHQHyBVJUheDLogsomYzuBNxmKehJDbPHR7agvvTNlaCV2k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169243-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169243: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-credit1:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=dde8689d1fe82e295a278ba4bf1abd9be5c7bcab
X-Osstest-Versions-That:
    qemuu=95a3fcc7487e5bef262e1f937ed8636986764c4e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 14:41:01 +0000

flight 169243 qemu-mainline real [real]
flight 169260 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169243/
http://logs.test-lab.xenproject.org/osstest/logs/169260/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit1 20 guest-localmigrate/x10 fail pass in 169260-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169208
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169208
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169208
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169208
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169208
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169208
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169208
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169208
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                dde8689d1fe82e295a278ba4bf1abd9be5c7bcab
baseline version:
 qemuu                95a3fcc7487e5bef262e1f937ed8636986764c4e

Last test of basis   169208  2022-04-07 06:16:22 Z    2 days
Testing same since   169243  2022-04-08 14:38:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   95a3fcc748..dde8689d1f  dde8689d1fe82e295a278ba4bf1abd9be5c7bcab -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 16:32:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 16:32:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302212.515797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndE01-0006GX-I9; Sat, 09 Apr 2022 16:31:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302212.515797; Sat, 09 Apr 2022 16:31:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndE01-0006GQ-Ex; Sat, 09 Apr 2022 16:31:45 +0000
Received: by outflank-mailman (input) for mailman id 302212;
 Sat, 09 Apr 2022 16:31:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndE00-0006GG-2q; Sat, 09 Apr 2022 16:31:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndDzz-0001Ak-MU; Sat, 09 Apr 2022 16:31:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndDzz-00006x-4D; Sat, 09 Apr 2022 16:31:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndDzz-0005p1-2U; Sat, 09 Apr 2022 16:31:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kpFD7bRGT2Fvg5nRy+hCNvyuo/LQNTKURWcuGZafRtk=; b=IkJzyU2Y6vbbh2ZE7db0c6u9I1
	cSynP9JeH2jwHDPP5Cp8N+jiUxje/llDOdaBO3xTV6cw/pyKxjMzjO3a1FUqpHqwazgQgg+FztqFb
	2DYtwpxXnSXmxB8UqYCgLgRH42CfWU7cy6bumpTiRvJKXf0FaKqli2/v/jCkwaqfbI4Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169249-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169249: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1a3b1bba7c7a5eb8a11513cf88427cb9d77bc60a
X-Osstest-Versions-That:
    linux=3123109284176b1532874591f7c81f3837bbdc17
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 16:31:43 +0000

flight 169249 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169249/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 169174

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169174
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169174
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169174
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169174
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169174
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169174
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                1a3b1bba7c7a5eb8a11513cf88427cb9d77bc60a
baseline version:
 linux                3123109284176b1532874591f7c81f3837bbdc17

Last test of basis   169174  2022-04-05 08:27:06 Z    4 days
Failing since        169188  2022-04-05 21:41:40 Z    3 days    5 attempts
Testing same since   169249  2022-04-08 18:10:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Conole <aconole@redhat.com>
  Al Viro <viro@zeniv.linux.org.uk>
  Alan Liu <HaoPing.Liu@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alex Hung <alex.hung@amd.com>
  Alexander Lobakin <alexandr.lobakin@intel.com>
  Alexei Starovoitov <ast@kernel.org>
  Alice Michael <alice.michael@intel.com>
  Alok Prasad <palok@marvell.com>
  Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>
  Andrea Parri (Microsoft) <parri.andrea@gmail.com>
  Andrew Lunn <andrew@lunn.ch>
  Andy Chiu <andy.chiu@sifive.com>
  Andy Gospodarek <gospo@broadcom.com>
  Ariel Elior <aelior@marvell.com>
  Arthur Fabre <afabre@cloudflare.com>
  Aurabindo Pillai <aurabindo.pillai@amd.com>
  Axel Lin <axel.lin@ingics.com>
  Benjamin Marty <info@benjaminmarty.ch>
  Bjorn Helgaas <bhelgaas@google.com>
  Boqun Feng <boqun.feng@gmail.com>
  Borislav Petkov <bp@suse.de>
  Boyuan Zhang <boyuan.zhang@amd.com>
  Catalin Marinas <catalin.marinas@arm.com>
  CHANDAN VURDIGERE NATARAJ <chandan.vurdigerenataraj@amd.com>
  Chanho Park <chanho61.park@samsung.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Chen-Yu Tsai <wens@csie.org>
  ChenXiaoSong <chenxiaosong2@huawei.com>
  Chiawen Huang <chiawen.huang@amd.com>
  Chris Park <Chris.Park@amd.com>
  Christian König <christian.koenig@amd.com>
  Christian König <ckoenig.leichtzumerken@gmail.com>
  Christian Lamparter <chunkeey@gmail.com>
  Christian Loehle <cloehle@hyperstone.com>
  Christian Löhle <CLoehle@hyperstone.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Mack <daniel@zonque.org>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Airlie <airlied@redhat.com>
  David Ahern <dsahern@kernel.org>
  David Hildenbrand <david@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Delyan Kratunov <delyank@fb.com>
  Dietmar Eggemann <dietmar.eggemann@arm.com>
  Dimitris Michailidis <d.michailidis@fungible.com>
  Dimitris Michailidis <dmichail@fungible.com>
  Divya Shikre <DivyaUday.Shikre@amd.com>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Drew Fustini <dfustini@baylibre.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eli Cohen <elic@nvidia.com>
  Emily Deng <Emily.Deng@amd.com>
  Eric Bernstein <eric.bernstein@amd.com>
  Eric Dumazet <edumazet@google.com>
  Ethan Lien <ethanlien@synology.com>
  Eyal Birger <eyal.birger@gmail.com>
  Felix Kuehling <Felix.Kuehling@amd.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Gabe Teeger <gabe.teeger@amd.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Guchun Chen <guchun.chen@amd.com>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Guo Ren <guoren@kernel.org>
  Guo Ren <guoren@linux.alibaba.com>
  Haowen Bai <baihaowen@meizu.com>
  Harry Wentland <harry.wentland@amd.com>
  Horatiu Vultur <horatiu.vultur@microchip.com>
  Huang Rui <ray.huang@amd.com>
  Ilias Apalodimas <ilias.apalodimas@linaro.org>
  Ilya Maximets <i.maximets@ovn.org>
  Ivan Vecera <ivecera@redhat.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamie Bainbridge <jamie.bainbridge@gmail.com>
  Jan Varho <jan.varho@gmail.com>
  Jann Horn <jannh@google.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Ekstrand <jason@jlekstrand.net>
  Jason Wang <jasowang@redhat.com>
  Jean-Philippe Brucker <jean-philippe@linaro.org>
  Jeremy Sowden <jeremy@azazel.net>
  Jesper Dangaard Brouer <brouer@redhat.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jimmy Kizito <Jimmy.Kizito@amd.com>
  Jiri Olsa <jolsa@kernel.org>
  Joerg Roedel <jroedel@suse.de>
  Joey Gouly <joey.gouly@arm.com>
  Johannes Thumshirn <johannes.thumshirn@wdc.com>
  Jonathan Bakker <xc-racer2@live.ca>
  Josef Bacik <josef@toxicpanda.com>
  José Expósito <jose.exposito89@gmail.com>
  Julia Lawall <Julia.Lawall@inria.fr>
  Kaiwen Hu <kevinhu@synology.com>
  Kalle Valo <kvalo@kernel.org>
  Kamal Dasu <kdasu.kdev@gmail.com>
  Karol Herbst <kherbst@redhat.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Lang Yu <Lang.Yu@amd.com>
  Lee Jones <lee.jones@linaro.org>
  Leo (Hanghong) Ma <hanghong.ma@amd.com>
  Leo Ruan <tingquan.ruan@cn.bosch.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Ying <victor.liu@nxp.com>
  Luiz Angelo Daros de Luca <luizluca@gmail.com>
  Ma Jun <Jun.Ma2@amd.com>
  Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Manish Chopra <manishc@marvell.com>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marcin Kozlowski <marcinguy@gmail.com>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Mark Jonas <mark.jonas@de.bosch.com>
  Martin Habets <habetsm.xilinx@gmail.com>
  Martin KaFai Lau <kafai@fb.com>
  Martin Leung <Martin.Leung@amd.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Matt Johnston <matt@codeconstruct.com.au>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
  Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Maxime Ripard <maxime@cerno.tech>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Kelley <mikelley@microsoft.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Walle <michael@walle.cc>
  Michael Wu <michael@allwinnertech.com>
  Muchun Song <songmuchun@bytedance.com>
  Neelima Krishnan <neelima.krishnan@intel.com>
  NeilBrown <neilb@suse.de>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Nikolay Aleksandrov <razor@blackwall.org>
  Noralf Trønnes <noralf@tronnes.org>
  Oliver Logush <oliver.logush@amd.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Abeni <pabeni@redhat.com>
  Paul Kocialkowski <paul.kocialkowski@bootlin.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Paulo Alcantara <pc@cjr.nz>
  Pavan Chebbi <pavan.chebbi@broadcom.com>
  Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Phil Auld <pauld@redhat.com>
  Philipp Zabel <p.zabel@pengutronix.de>
  Prabhakar Kushwaha <pkushwaha@marvell.com>
  Prike Liang <Prike.Liang@amd.com>
  Qingqing Zhuo <qingqing.zhuo@amd.com>
  QintaoShen <unSimple1993@163.com>
  Qu Wenruo <wqu@suse.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ray Jui <ray.jui@broadcom.com>
  Rob Herring <robh@kernel.org>
  Robin Murphy <robin.murphy@arm.com>
  Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
  Roman Gushchin <roman.gushchin@linux.dev>
  Roman Li <Roman.Li@amd.com>
  Ruili Ji <ruiliji2@amd.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Shirish S <shirish.s@amd.com>
  Shwetha Nagaraju <shwetha.nagaraju@intel.com>
  Stanley.Yang <Stanley.Yang@amd.com>
  Steve Capper <steve.capper@arm.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Taehee Yoo <ap420073@gmail.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tianci Yin <tianci.yin@amd.com>
  tiancyin <tianci.yin@amd.com>
  Tom Chung <chiahsuan.chung@amd.com>
  Tom Rix <trix@redhat.com>
  Tony Lindgren <tony@atomide.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Tushar Patel <tushar.patel@amd.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Vasily Averin <vasily.averin@linux.dev>
  Vasily Averin <vvs@openvz.org>
  Vinod Koul <vkoul@kernel.org>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wei Liu <wei.liu@kernel.org>
  Will Deacon <will@kernel.org>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>
  Yann Gautier <yann.gautier@foss.st.com>
  Yifan Zhang <yifan1.zhang@amd.com>
  Yonghong Song <yhs@fb.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhiyuan Dai <daizhiyuan@phytium.com.cn>
  Ziyang Xuan <william.xuanziyang@huawei.com>
  Zorro Lang <zlang@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   312310928417..1a3b1bba7c7a  1a3b1bba7c7a5eb8a11513cf88427cb9d77bc60a -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 19:03:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 19:03:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302227.515807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndGMT-0007N7-Jg; Sat, 09 Apr 2022 19:03:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302227.515807; Sat, 09 Apr 2022 19:03:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndGMT-0007N0-Gn; Sat, 09 Apr 2022 19:03:05 +0000
Received: by outflank-mailman (input) for mailman id 302227;
 Sat, 09 Apr 2022 19:03:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndGMS-0007Mq-4F; Sat, 09 Apr 2022 19:03:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndGMS-0003rT-1R; Sat, 09 Apr 2022 19:03:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndGMR-0002sE-It; Sat, 09 Apr 2022 19:03:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndGMR-0008TG-IR; Sat, 09 Apr 2022 19:03:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HAJW2IMm6wFxcRAdYuGVgAiVdiTy93oNMCMp18eBZo8=; b=3u1Esmq6+6w+E7TXZNcT+a9Utc
	0fm6h6TXyPhBrVEQJemlc18Ge/0JVtmzf8gRjMgckzQU2KoAY1RMWEQ3LmJyScXbd9rzsDDgQq6u3
	58/NDQjAeS9VC2aQIJICuLiTsR1eysgS/z2IgPP0xy/gIIMPSdyLRHkNrXLnYev31IV4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169254-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169254: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=c11fb2132f313b9aa25ad7c57becc72923623874
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 19:03:03 +0000

flight 169254 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169254/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              c11fb2132f313b9aa25ad7c57becc72923623874
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  638 days
Failing since        151818  2020-07-11 04:18:52 Z  637 days  619 attempts
Testing same since   169254  2022-04-09 04:20:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104141 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 20:07:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 20:07:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302236.515818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndHMj-0006Vt-Et; Sat, 09 Apr 2022 20:07:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302236.515818; Sat, 09 Apr 2022 20:07:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndHMj-0006Vm-Bt; Sat, 09 Apr 2022 20:07:25 +0000
Received: by outflank-mailman (input) for mailman id 302236;
 Sat, 09 Apr 2022 20:07:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndHMh-0006Vc-P5; Sat, 09 Apr 2022 20:07:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndHMh-00052W-NM; Sat, 09 Apr 2022 20:07:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndHMh-0006bB-C6; Sat, 09 Apr 2022 20:07:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndHMh-0004oW-BY; Sat, 09 Apr 2022 20:07:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TWc5ZoyATxtaJo4fSTBwMp/mn0kt7HR2bDrrgjH8SCA=; b=e12pdrfUsV+fNMOpt7Uhq38tx9
	u3KJYz4L5bHELLInpYW64Gx0o5v+TnZZ7nU+6ihDnl8pmCjW4QXJNM6alkbE2aFDF0W5cmwUcvN41
	FDg+USHWLRSRS8oHa0QQfjMdDXfBUo5BNasnOHB3tlD0ExHXbmmBZ0dJz3meMAVVCk8U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169258-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169258: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 20:07:23 +0000

flight 169258 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169258/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   40 days
Failing since        168258  2022-03-01 01:55:31 Z   39 days  296 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 20:59:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 20:59:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302267.515885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndIAc-0005LR-Qq; Sat, 09 Apr 2022 20:58:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302267.515885; Sat, 09 Apr 2022 20:58:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndIAc-0005LK-Ni; Sat, 09 Apr 2022 20:58:58 +0000
Received: by outflank-mailman (input) for mailman id 302267;
 Sat, 09 Apr 2022 20:58:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndIAb-0005LA-5B; Sat, 09 Apr 2022 20:58:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndIAb-0005xd-2l; Sat, 09 Apr 2022 20:58:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndIAa-00004y-Lv; Sat, 09 Apr 2022 20:58:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndIAa-0005Yx-LR; Sat, 09 Apr 2022 20:58:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xnD4RYlbJQmavJtmpgSbXyE9DJ0nBqB49+Bcj2ChChY=; b=xus89RKzBqtrBZjpWZ97nTGWQG
	7xe42DRUiurJbUwl+QnFeKvqo9qLWn633YCuqigdoI1jPM4MwpXVehgk5NHcMeWKdGytIm8BS4d/0
	7ZDCkZ/Q3QofqmmD90SgKahjbN6iNLjdiot6/FQUdDVlDE06KO1uvw0hNY3Fx/ovioKc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169251-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169251: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2e6f95a942d1927a53f077c301db0b799c54c05a
X-Osstest-Versions-That:
    xen=d3f61beea4255e2d86ae82303384c57a3262435e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 20:58:56 +0000

flight 169251 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169251/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169233

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169233
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169233
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169233
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169233
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169233
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169233
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169233
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169233
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169233
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169233
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169233
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169233
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  2e6f95a942d1927a53f077c301db0b799c54c05a
baseline version:
 xen                  d3f61beea4255e2d86ae82303384c57a3262435e

Last test of basis   169233  2022-04-08 10:02:11 Z    1 days
Testing same since   169251  2022-04-08 20:07:05 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d3f61beea4..2e6f95a942  2e6f95a942d1927a53f077c301db0b799c54c05a -> master


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 21:22:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 21:22:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302279.515897 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndIWh-0000gh-S2; Sat, 09 Apr 2022 21:21:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302279.515897; Sat, 09 Apr 2022 21:21:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndIWh-0000ga-OI; Sat, 09 Apr 2022 21:21:47 +0000
Received: by outflank-mailman (input) for mailman id 302279;
 Sat, 09 Apr 2022 21:21:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7tuM=UT=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1ndIWf-0000gU-51
 for xen-devel@lists.xenproject.org; Sat, 09 Apr 2022 21:21:46 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0d14d6ff-b84b-11ec-8fbc-03012f2f19d4;
 Sat, 09 Apr 2022 23:21:43 +0200 (CEST)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 239FYCS0032238; 
 Sat, 9 Apr 2022 21:21:33 GMT
Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta02.appoci.oracle.com [147.154.114.232])
 by mx0b-00069f02.pphosted.com with ESMTP id 3fb0jd0tkj-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 09 Apr 2022 21:21:33 +0000
Received: from pps.filterd
 (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 239LBvrH021102; Sat, 9 Apr 2022 21:21:32 GMT
Received: from nam10-bn7-obe.outbound.protection.outlook.com
 (mail-bn7nam10lp2108.outbound.protection.outlook.com [104.47.70.108])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3fb0k0xjb5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 09 Apr 2022 21:21:32 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by CO1PR10MB4612.namprd10.prod.outlook.com (2603:10b6:303:9b::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.27; Sat, 9 Apr
 2022 21:21:24 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%9]) with mapi id 15.20.5144.028; Sat, 9 Apr 2022
 21:21:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d14d6ff-b84b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=kfzCGQd1Nq4aQYkJnXe92vORk9AoNiTf10+KM0SVb7k=;
 b=HxtqDu8AHURDIZ92JNEsLVBO7DOjXlHakdabRqmaTMWKYrDU5id2K/tJJh+8dCq3gjzj
 QtrctouMe+qCwRqOhTxhtAxDBw8nIrlanS2x4iF3Hm+Nq58X1S14snZM/u7DxWEDPu+D
 OwhEnNVr/xuH0bUmbkTEiiG5rlc82lg/fhhjkAOhhYhz9G6dnmNK8n4/9JgCAhoA6vFN
 k7T8doWDBkg0Tyj/CpkRPMYC1nOsAeMqOXnZbn3tkS/TKwcG608M9gH0N9NShfme7W7j
 W+fFC0E0eHARXbc9DR9P0nTk1pclUbTwZ5bXjzcDKT8emfCu1lsPBEv3HzQoDR6okuET ew== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GriJYa4TZtbHtGR8GbvSfXNlTZu7agBnWeGbNWb0YymyBE18yxWvoM1jlmYl8IR04oOmP2DA5Or+ENJInOx5e5oAcgSHp5oTrN/lmXldv2nzJSuK+eCVitNeIkt71IMzrwBJAwgQLnLKdOT1pgfmpo3BtV4ivx1eolwT8A2SNTP/3h9sF9t/5CI6ddIxXBvoGffYrzKNqtlYz2DjjX7J/RyKViEmVVrhvj+VXYTkYzr95ahZiq8lalZcYaV0+W1ajIo917kky6/dcxf1w0hTmhsp5p5ISZgzD8/1ghSgM7WFt06tkEfIHQQSzxap4jJiFzZ2FKzp0YnLTIXkf7kQ2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kfzCGQd1Nq4aQYkJnXe92vORk9AoNiTf10+KM0SVb7k=;
 b=WP6PtMlRGsaq5PTgfhPbIi3GDr98wUMAPa9lLbyGS5C0f8f7V/3EWeUaWVfMuxzgXtzWheqN267wG1yEX/Bek0gXxrldNBCoX5kpg9PVK45QZFQW4W4MYjFn1Ot5QslV3PUU6Iqu83nSP6HJlscAVIAkA4lQYxVZLl+mJx0jtgubdnbADA/Hf+9ndGmBdAanrSa1Z9yZW1kYW+riFrOZeyYL26loL4AWSHyfQmXvBmpwL7cYILFGKugRRv5C+V6leH5xvqEX361EJN0kmCYkOrHSMW4VdJg65Ozi1H2wZSEeUJtcfruO7JWsr2lld9ZkvlncLwd8G7TKd5S3PZnJhg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kfzCGQd1Nq4aQYkJnXe92vORk9AoNiTf10+KM0SVb7k=;
 b=nOfu6Sue+rJzhjyLRtuh/g1AO4QOF4oiE7eGilZLincqfggq+4WcXvOFn88i6y1aQljUg97XPn2SYrqfhyfn6E73/nhBO49yE17tKyTEjGn/W4OSKgIggBjrT9qRDpigb0Eu2o8WdEWCsEJAQSmXma0HP5AoGOTLJ+pO1Bp7poY=
Message-ID: <5a1aa65d-1abf-6489-867b-fb84de804de2@oracle.com>
Date: Sat, 9 Apr 2022 17:21:17 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] xen/balloon: don't use PV mode extra memory for zone
 device allocations
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20220407093857.1485-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220407093857.1485-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0PR05CA0038.namprd05.prod.outlook.com
 (2603:10b6:a03:33f::13) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ed109f35-c0a5-44e7-378a-08da1a6ee60f
X-MS-TrafficTypeDiagnostic: CO1PR10MB4612:EE_
X-Microsoft-Antispam-PRVS: 
	<CO1PR10MB46128D9E34F39E3B4776E74E8AE89@CO1PR10MB4612.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	zzNhnZakHQJ9mXH9meRrYNbmGdGlTOJa2HcioZuK/68SkhCk8nWEFEPiYMKpIH54v3LceqM0ns5I1pH0g+IVOsuBndts99fGrk15dndOJtANukPIfl59JpuulDuoAfvbaZHduZ2Yr45rPrIv3g2zIqnm5VBx8dq1Tpx2pEBMXG6vUXGhZj0c8FYTHQc4KIDc6vkEjXOm5vjcRkUC+UaBVdHRK1qK1cxg4g207BH5FVSkJGLFA1w14JKyLAJyxnky0Yiq557j5ZH2J0PmH0KjolaQJFQPahKODxqPFU+7lHlnZOkYpb9QQbw0OikzqxXp9aP6FLe2cnMlVuV0VNfSDUPFw2DZTTZsfxsvIQOdre+k0e9GmPnBlsWmEHGhjsczBGGXe2w0JQc0k9vb419koMlqw1vmO521oXuoSVp0mclBAXmppm8bxep/JkmwV6AftMpRAnjiR02YJ4071O7TqmAkI11RtydFOYgb83a/CGH8T71pCW+1fHPiWxlGAYW7QfElbx9dWX1i3C6jQQv2QomtkV5tKEjDhS1hyYITVVlrdKnWAdtXmYLuhU0wrnoYbBt3xdTnqM0KmEijnA/i52d6S6wpr6DM/a9DJgeepoDUH+7aS+jNGSvhuv6a7J5qYg0+DkpyU955loOliGART5xmX4J7oCLXKN9uHz+l7Mqnwd2617+jAFGAHsLl4tadR2y1ioNFPaNoCMDBIbWu/xcpfr9IMsw45wl+E5ntGBE=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(31696002)(6506007)(86362001)(6666004)(53546011)(31686004)(8676002)(44832011)(36756003)(38100700002)(5660300002)(66476007)(66946007)(66556008)(4744005)(8936002)(316002)(508600001)(4326008)(26005)(186003)(2906002)(6486002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dk53MnI0UkdaemZIbXI1TWFkYmlKZC9EU2xBU0JGRll4Z2NGZmYyUktCbytW?=
 =?utf-8?B?cmRrVkt3eHpBeGdJK25QUVJsUEhSWDg5RWl4VCtzZDBVQ3YwRGFGLzA4amhP?=
 =?utf-8?B?dkw4TmtLRmpMNHNsWGZwTWcvTFArWkgvU0N4MnFYc3VZcHdWRllwaHFocFds?=
 =?utf-8?B?Rk5XYytwVEtLSTEyekltbjVhZzk4Y29sWWtTbHZTbHhETDVEYTBXY09DYkFi?=
 =?utf-8?B?MFNjc2ptczFYVlVINWcxRUZPN2NPa3JUSXJLWlpOekNnNjlLUWJqTDFhWFRh?=
 =?utf-8?B?ejNtMWE4ckF1dTRCTjI4VHJJU3RIUUhhaTlQeGRTTHN3OUpNQ0lQR0JXYS9E?=
 =?utf-8?B?VlNUVFNSNmFxVUxyRC90dncxQTlpNkpLd2ltNmlFL2FBZjNVUFErSFFHWHFy?=
 =?utf-8?B?R3BiWEFvRWM3OGtXUk9FTXNMWGJiL1N6VHZoS25GWDZ1K0Y2eitlWVIrdkdo?=
 =?utf-8?B?aUJaUy9PeUtPQ2tuamZJT3pFVW42S1FQR0ZNVllLclR0OGdtMGFZRnVpZTVT?=
 =?utf-8?B?YUJ3ZnZybWVBN05xVEZQV09qZm5YU2RVZE5jb2VyZ2xPR1FoeTNielZoMGVr?=
 =?utf-8?B?WWVpTGkvSEpEMGJ4MzQzUUtlT2JHMnlzZzV4cXUzM05pRWdIZ0tTQXY5TkpQ?=
 =?utf-8?B?N1YwRkQ5SXZET0NoS0lSa1FvaFhUTTk2NEw3a1hVbUtYYThZUzlEbXpJeUNk?=
 =?utf-8?B?UmR1UGlyWThOQWRZeWlUamk1dTc5S2xUcHczbDNuM21ZSUw3VjFIRFZtS1JJ?=
 =?utf-8?B?aUo3NkFhMFg5OEsvQXpMb0t5eFN3ZU90NFR1WjNpcVBLUGhuQWZKemlPTWZu?=
 =?utf-8?B?YWJBdW5iSEViNmxMTU9qV2phWDY2dzZyTWVVUHlYdElQUFQ1WGdkNzBwM0E4?=
 =?utf-8?B?QiswMnhRMitYem9oaUZmcklxT0ovVFlSR1pYcDNSWUg0YjRkTkRFSGU5WmFp?=
 =?utf-8?B?S2txTFkyRUtRZERtOXpwa2VGL1RTT21ORVRYUzNkanBlaVI5c2d2WUprVmx1?=
 =?utf-8?B?RWtkcTh5MHRJci9FN3pSUGpFQ01aZGlaQWc0cDR5emJIbWN0bXJ6V2hEVTMz?=
 =?utf-8?B?MElKZkFWUzMwaFRXRmhRd05yVlFkV2lmMWxqdTZvYTNGaWFML3VybDZvTTJG?=
 =?utf-8?B?RXJTd213OXltY3JxTDdqZVAwRkFINUxScm9ZbDhmU2tlY3RBeUNuWEk5S0Zy?=
 =?utf-8?B?NElGYk55REVHTEZ5NStpbjBMK0QzWjVoaWFteVdsbkwwVUVNSkNwTVdzWjgy?=
 =?utf-8?B?eTFkMTRQUGJoMms4c3R3dzFNR3diUDkxSVZzcFhINlc2b2U4L1EyM01wK0NX?=
 =?utf-8?B?RkFmV05CaGdlVG9BT3RGeGlMazBXMGp5RmZvZHFoczNCUjBQT2lndnc3TzlM?=
 =?utf-8?B?MCtIS0lac2dVazJvVmNTV1ZVT0RqSnBZQlVWTFc4TmpIazFMajUrRng0dzNt?=
 =?utf-8?B?azVDWHlaaE9CVzlpakYxSzhnVjh4OFdPc0VOWDJLNVY1TVpmVVFnSkdEMTRE?=
 =?utf-8?B?SnFneGNGNlVoR3docWRvdGhkTXI5a0o4dlcrNndNRGRhYmRxTGF0Y1R5YUo3?=
 =?utf-8?B?ME82MHlJLzV4aWNoaFQ2d2RIT2NTMFFZcHNvYmpvOEtaYk4rMkplVnlTcUJs?=
 =?utf-8?B?RXZEOXZ2dk43ZGxObmpOQTdsWnZGOG12bWxYUS81THI0UzNhMDFoWElQSFFt?=
 =?utf-8?B?WEZqc0dtUDd4Y0pJN3lSbGJaMWlVVFlzMVIrMGR6R2xObnRycGFqSEZQRnJQ?=
 =?utf-8?B?bVJIWG5oTEdRSVJpc2prN1B3ZUdCdW1BV284T1Y4Z1B3UkVVSit5QUxvQ0xQ?=
 =?utf-8?B?L3ZDR1NzWFl3MkgvOXR5Um8vakNQdDBGN00xUldhNWZLRjEyT0NJMmUvVnNV?=
 =?utf-8?B?L29CY25EK05SUmxhM0kzUGp2aENXcXFLdHlVOTdLdGU3aFBTYUM3NEpUNjZp?=
 =?utf-8?B?VUZxd21SRFNpamhWaWsrQ0xXaUxtQnVzYkVRbXVlTDg4cno1c0pmRTU2QzFX?=
 =?utf-8?B?Z2ZhU2QySDhCbnBnekVZYUZKcmNTdE9ielUzVG00TituVERuS0hPRTFDd2Y0?=
 =?utf-8?B?bmtnMWIyYmlGZGdSRXdyZWNWMUtnS2Uxek83eXZNbjUxMTk0dThjTUlVdWRm?=
 =?utf-8?B?TzBaMWlZazZwajk5R0gwR0RTeHREMEh1MzI2dGdXM0RzRFYzT05XQ1Z6K3Fp?=
 =?utf-8?B?V2JLL0JHaUYwYk1wMUxNRVdHTGxBN0pnSnZES2xDL2dwUXdQZW9McTg3bXB6?=
 =?utf-8?B?M213eUNheEdjZmRST2dLSVhNamVhNy9Tb0V5bzJZWmQwWEVWMnpKZEo3eHBH?=
 =?utf-8?B?SGxJcVFhN1NBOEFNM0x2M2lBR0o0YmZVckhUKzFpMFdrRzI1STQ0eGRwdy94?=
 =?utf-8?Q?8OKW+GcDNoh7F44c=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed109f35-c0a5-44e7-378a-08da1a6ee60f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2022 21:21:24.1882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O+BM8asI0s3nAV3ufWVkwA6wOPVlJ0vYbpPOfh1hfmRAooElOndmlKXuhr9gJV8ImA+dvJv5kVDzWoR9d3YpUlyww8rQH80M1VzoY04HkhI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4612
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.858
 definitions=2022-04-09_25:2022-04-08,2022-04-09 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0
 suspectscore=0 spamscore=0 mlxlogscore=952 phishscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204090139
X-Proofpoint-ORIG-GUID: HnalseiX_rKz-v5OlGIQf8n0VZ2JDZxU
X-Proofpoint-GUID: HnalseiX_rKz-v5OlGIQf8n0VZ2JDZxU


On 4/7/22 5:38 AM, Juergen Gross wrote:
> When running as a Xen PV guest use the extra memory (memory which isn't
> allocated for the guest at boot time) only for ballooning purposes and
> not for zone device allocations. This will remove some code without any
> lack of functionality.
>
> While at it move some code to get rid of another #ifdef.
>
> Remove a comment which is stale since some time now.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>



Applied to for-linus-5.18


-boris



From xen-devel-bounces@lists.xenproject.org Sat Apr 09 22:12:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 22:12:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302286.515910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndJJa-00071f-LD; Sat, 09 Apr 2022 22:12:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302286.515910; Sat, 09 Apr 2022 22:12:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndJJa-00071Y-HV; Sat, 09 Apr 2022 22:12:18 +0000
Received: by outflank-mailman (input) for mailman id 302286;
 Sat, 09 Apr 2022 22:12:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndJJZ-00071O-3c; Sat, 09 Apr 2022 22:12:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndJJZ-0007JK-0a; Sat, 09 Apr 2022 22:12:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndJJY-0005Fn-A4; Sat, 09 Apr 2022 22:12:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndJJY-0007LL-9d; Sat, 09 Apr 2022 22:12:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pDJ/SijLf5VrlpfzwKPmpVKVvzCF2Jt9D+oupeFwpg0=; b=RaC3TGpsJzlY1vZ7mzxJfZeT7L
	egrqwVrHWsOEl7HPXRuM2+ht6DBaYe54kPG7rZxfs44mlhWKhN7P80xG+JmEuK/ACBzRZ5KuinijY
	WZUK/oIj7zOAdgDxc7zfMjGLcvPjecYzkJ5STgcIV3hZd7NmsX7UnDP8WpES0gbdgy0Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169263-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169263: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 22:12:16 +0000

flight 169263 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169263/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   40 days
Failing since        168258  2022-03-01 01:55:31 Z   39 days  297 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 09 23:25:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Apr 2022 23:25:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302303.515950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndKRo-0007XO-Cx; Sat, 09 Apr 2022 23:24:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302303.515950; Sat, 09 Apr 2022 23:24:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndKRo-0007XH-9E; Sat, 09 Apr 2022 23:24:52 +0000
Received: by outflank-mailman (input) for mailman id 302303;
 Sat, 09 Apr 2022 23:24:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndKRn-0007X7-HH; Sat, 09 Apr 2022 23:24:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndKRn-00005t-FX; Sat, 09 Apr 2022 23:24:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndKRn-0000KB-2m; Sat, 09 Apr 2022 23:24:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndKRn-0001BS-2H; Sat, 09 Apr 2022 23:24:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LUZtwpoipcHEExSIp8rnwysQ0YiPApn9vxSC5+33Hvo=; b=aAnjmj2s3PWGEJiRqEVVVgWmOM
	Vku+9M9lsW4Lr02IP7Ov6/TyM6SRCHeyScPu0BGqDsiD5hkfOO6PtrjhcUdTaFvnUQKEKdK0rAf1k
	aSHrdaG9h0Qf7UzeALP1icaYWNyj66tBgO6RYafDxwJ2vPSB9avAIzOrmwWIvLG3Uauc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169252-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 169252: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b953760d0b564478e232e7e64823d2a1506e92b5
X-Osstest-Versions-That:
    xen=2c026fe1f159494b3ec05f19ddfb3d39ff901296
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Apr 2022 23:24:51 +0000

flight 169252 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169252/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169194
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169194
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169194
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169194
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169194
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169194
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169194
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169194
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169194
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169194
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169194
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169194
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  b953760d0b564478e232e7e64823d2a1506e92b5
baseline version:
 xen                  2c026fe1f159494b3ec05f19ddfb3d39ff901296

Last test of basis   169194  2022-04-06 08:39:21 Z    3 days
Testing same since   169238  2022-04-08 13:07:07 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bjoern Doebel <doebel@amazon.de>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2c026fe1f1..b953760d0b  b953760d0b564478e232e7e64823d2a1506e92b5 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 00:36:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 00:36:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302315.515961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndLZ2-0008R5-S4; Sun, 10 Apr 2022 00:36:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302315.515961; Sun, 10 Apr 2022 00:36:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndLZ2-0008Qy-O4; Sun, 10 Apr 2022 00:36:24 +0000
Received: by outflank-mailman (input) for mailman id 302315;
 Sun, 10 Apr 2022 00:36:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndLZ1-0008Qo-7e; Sun, 10 Apr 2022 00:36:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndLZ1-0001w3-53; Sun, 10 Apr 2022 00:36:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndLZ0-0003as-TH; Sun, 10 Apr 2022 00:36:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndLZ0-00050W-So; Sun, 10 Apr 2022 00:36:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rTt2a6p9guGsRT8Q9RYV/0gcV+cjtXKFxZWTLokDQaU=; b=r47Go+QoZFZxKJ3hCTnUESHpSV
	fm8ipHvbqd60H/iDkqj57Y8BY7Ji74YMBoVtnQJhzzp3wx73Y1o8zhuK2XPXFptBQRKCUjgkL/AVQ
	E7qe2CJN0ymnYl83G57aVRoQQE3WZUSweCsW9ix7MoXOYwNnJwmSI+20wHlphiuYwzTc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169265-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169265: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 00:36:22 +0000

flight 169265 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169265/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   40 days
Failing since        168258  2022-03-01 01:55:31 Z   39 days  298 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 02:01:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 02:01:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302325.515972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndMtX-0003sU-8s; Sun, 10 Apr 2022 02:01:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302325.515972; Sun, 10 Apr 2022 02:01:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndMtX-0003sM-3U; Sun, 10 Apr 2022 02:01:39 +0000
Received: by outflank-mailman (input) for mailman id 302325;
 Sun, 10 Apr 2022 02:01:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndMtV-0003sC-Pa; Sun, 10 Apr 2022 02:01:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndMtV-0004XQ-M8; Sun, 10 Apr 2022 02:01:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndMtV-000817-1u; Sun, 10 Apr 2022 02:01:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndMtV-00040M-1R; Sun, 10 Apr 2022 02:01:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0ApTgplMU/CxmQ/XxepRNIPfbhcbZlcV89rSds9F3Qo=; b=wO95AnWMcYakcC1wFftitzMw5h
	cLZAI60Y0LW6TNRntun1SHY3I8ur7/uE3neTPWLoE6+wD7aKJcNF+zPx/FJ3ayAefT6+Cr1Q7bQVf
	00VgmguVShDyMAeOqXnq7BbHtFuQJbEfdzGcWU0HBEr0tz5oRwWjswLzcRBRyVUac1vo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169261-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169261: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=4bf58c7213b0ab03209a53731c71f0861c35ef91
X-Osstest-Versions-That:
    qemuu=dde8689d1fe82e295a278ba4bf1abd9be5c7bcab
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 02:01:37 +0000

flight 169261 qemu-mainline real [real]
flight 169267 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169261/
http://logs.test-lab.xenproject.org/osstest/logs/169267/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel 18 guest-localmigrate fail pass in 169267-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169243
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169243
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169243
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169243
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169243
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169243
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169243
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169243
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                4bf58c7213b0ab03209a53731c71f0861c35ef91
baseline version:
 qemuu                dde8689d1fe82e295a278ba4bf1abd9be5c7bcab

Last test of basis   169243  2022-04-08 14:38:44 Z    1 days
Testing same since   169261  2022-04-09 14:44:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Michael S. Tsirkin <mst@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Wentao Liang <Wentao_Liang_g@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   dde8689d1f..4bf58c7213  4bf58c7213b0ab03209a53731c71f0861c35ef91 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 04:16:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 04:16:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302336.515983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndP0A-0002d3-U2; Sun, 10 Apr 2022 04:16:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302336.515983; Sun, 10 Apr 2022 04:16:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndP0A-0002cw-QD; Sun, 10 Apr 2022 04:16:38 +0000
Received: by outflank-mailman (input) for mailman id 302336;
 Sun, 10 Apr 2022 04:16:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndP08-0002cm-Va; Sun, 10 Apr 2022 04:16:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndP08-0006xf-RH; Sun, 10 Apr 2022 04:16:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndP08-0007Fs-C3; Sun, 10 Apr 2022 04:16:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndP08-0001Dy-BZ; Sun, 10 Apr 2022 04:16:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uANKBe3RJzkPevuTa4M0nq96Sskjp6BVMAQyl05eHSw=; b=0hiN3uQmk5j2ZeUfYe9Cafm++c
	tLCd2iQKbyIgrSfn4u3LWMQTHzk8hGDgzOvrAmYKpCaQvDSgKoP25j4ydt0tYtxeXvDIBAzuXNDKh
	l53FAX7RU/QIJ4BYaulxmy9YcCwCGeIvwSUGMMOP930xwenBtq7AkFdKX8UT3dhbjQPY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169262-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169262: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-qcow2:host-ping-check-xen:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f1b45d8ccb9839b48e5884664470e54520e17f4c
X-Osstest-Versions-That:
    linux=1a3b1bba7c7a5eb8a11513cf88427cb9d77bc60a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 04:16:36 +0000

flight 169262 linux-linus real [real]
flight 169268 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169262/
http://logs.test-lab.xenproject.org/osstest/logs/169268/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-examine      8 reboot              fail pass in 169268-retest
 test-armhf-armhf-xl-vhd       8 xen-boot            fail pass in 169268-retest
 test-armhf-armhf-libvirt-qcow2 10 host-ping-check-xen fail pass in 169268-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169249

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 169268 like 169249
 test-armhf-armhf-xl-vhd     14 migrate-support-check fail in 169268 never pass
 test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 169268 never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 169268 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 169249
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169249
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169249
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169249
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169249
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169249
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169249
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169249
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f1b45d8ccb9839b48e5884664470e54520e17f4c
baseline version:
 linux                1a3b1bba7c7a5eb8a11513cf88427cb9d77bc60a

Last test of basis   169249  2022-04-08 18:10:39 Z    1 days
Testing same since   169262  2022-04-09 16:34:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aharon Landau <aharonl@nvidia.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Andrew Morton <akpm@linux-foundation.org>
  Axel Rasmussen <axelrasmussen@google.com>
  Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
  Christoph Böhmwalder <christoph@boehmwalder.at>
  Daniel Latypov <dlatypov@google.com>
  Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
  Douglas Miller <doug.miller@cornelisnetworks.com>
  Enze Li <lienze@kylinos.cn>
  Eugene Syromiatnikov <esyr@redhat.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geliang Tang <geliang.tang@suse.com>
  Guo Xuenan <guoxuenan@huawei.com>
  Guo Zhengkui <guozhengkui@vivo.com>
  Jason Gunthorpe <jgg@nvidia.com>
  Jens Axboe <axboe@kernel.dk>
  Kees Cook <keescook@chromium.org>
  Leon Romanovsky <leonro@nvidia.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lv Yunlong <lyl2019@mail.ustc.edu.cn>
  Mark Brown <broonie@kernel.org>
  Mark Zhang <markzhang@nvidia.com>
  Max Filippov <jcmvbkbc@gmail.com>
  Miaohe Lin <linmiaohe@huawei.com>
  Michal Hocko <mhocko@suse.com>
  Nathan Chancellor <nathan@kernel.org>
  Nick Desaulniers <ndesaulniers@google.com>
  Niels Dossche <dossche.niels@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Pavel Begunkov <asml.silence@gmail.com>
  Phillip Potter <phil@philpotter.co.uk>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Shakeel Butt <shakeelb@google.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Tom Rix <trix@redhat.com>
  Vasily Averin <vasily.averin@linux.dev>
  Waiman Long <longman@redhat.com>
  Willem de Bruijn <willemb@google.com>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>
  Zi Yan <ziy@nvidia.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   1a3b1bba7c7a..f1b45d8ccb98  f1b45d8ccb9839b48e5884664470e54520e17f4c -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 06:03:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 06:03:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302350.515994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndQf8-0007uF-Qe; Sun, 10 Apr 2022 06:03:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302350.515994; Sun, 10 Apr 2022 06:03:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndQf8-0007u8-Nh; Sun, 10 Apr 2022 06:03:02 +0000
Received: by outflank-mailman (input) for mailman id 302350;
 Sun, 10 Apr 2022 06:03:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndQf7-0007ty-Ik; Sun, 10 Apr 2022 06:03:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndQf7-0000v3-Fd; Sun, 10 Apr 2022 06:03:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndQf7-0002I0-5j; Sun, 10 Apr 2022 06:03:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndQf7-0006KJ-5H; Sun, 10 Apr 2022 06:03:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zSweBc2qegQErWxR6nFkLb35xCbfOA1SUUCw1o1sZq8=; b=rF8geh9wHGUsBpKY4eAz54Yozl
	aCBbQ8akhSdL2TQSn/5LX6ZtaQ5GND0p3GdpmgbOnj7QOexOt53xVvylwNQcYtq8906cxg8xqiH/9
	a751JK7/9KI+yuqEMyS7O/60zAfW6vVar9Zd2H64ijelvVdqMOOjKPpTZxTHYIv7/RSo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169266-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169266: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 06:03:01 +0000

flight 169266 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169266/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   40 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  299 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 06:26:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 06:26:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302359.516004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndR1m-0002OH-Jl; Sun, 10 Apr 2022 06:26:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302359.516004; Sun, 10 Apr 2022 06:26:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndR1m-0002OA-Gj; Sun, 10 Apr 2022 06:26:26 +0000
Received: by outflank-mailman (input) for mailman id 302359;
 Sun, 10 Apr 2022 06:26:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aDry=UU=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1ndR1l-0002O4-Eo
 for xen-devel@lists.xenproject.org; Sun, 10 Apr 2022 06:26:25 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 24c8be4f-b897-11ec-8fbc-03012f2f19d4;
 Sun, 10 Apr 2022 08:26:24 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id E057168AFE; Sun, 10 Apr 2022 08:26:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24c8be4f-b897-11ec-8fbc-03012f2f19d4
Date: Sun, 10 Apr 2022 08:26:20 +0200
From: Christoph Hellwig <hch@lst.de>
To: Christoph =?iso-8859-1?Q?B=F6hmwalder?= <christoph.boehmwalder@linbit.com>
Cc: Christoph Hellwig <hch@lst.de>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, Jens Axboe <axboe@kernel.dk>,
	linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Coly Li <colyli@suse.de>
Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Message-ID: <20220410062620.GA16234@lst.de>
References: <20220409045043.23593-1-hch@lst.de> <20220409045043.23593-25-hch@lst.de> <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Sat, Apr 09, 2022 at 10:15:33AM +0200, Christoph B�hmwalder wrote:
> On 09.04.22 06:50, Christoph Hellwig wrote:
>> Just use a non-zero max_discard_sectors as an indicator for discard
>> support, similar to what is done for write zeroes.
>>
>> The only places where needs special attention is the RAID5 driver,
>> which must clear discard support for security reasons by default,
>> even if the default stacking rules would allow for it.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>> Acked-by: Christoph B�hmwalder <christoph.boehmwalder@linbit.com> [btrfs]
>
> I think you may have a typo there: my ACK was for drbd, not btrfs.

Indeed, sorry.


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 06:27:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 06:27:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302362.516016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndR2o-0002vo-Ts; Sun, 10 Apr 2022 06:27:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302362.516016; Sun, 10 Apr 2022 06:27:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndR2o-0002vh-Qo; Sun, 10 Apr 2022 06:27:30 +0000
Received: by outflank-mailman (input) for mailman id 302362;
 Sun, 10 Apr 2022 06:27:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aDry=UU=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1ndR2n-0002vV-7C
 for xen-devel@lists.xenproject.org; Sun, 10 Apr 2022 06:27:29 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4b33726c-b897-11ec-8fbc-03012f2f19d4;
 Sun, 10 Apr 2022 08:27:28 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 95E2B68AFE; Sun, 10 Apr 2022 08:27:26 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b33726c-b897-11ec-8fbc-03012f2f19d4
Date: Sun, 10 Apr 2022 08:27:26 +0200
From: Christoph Hellwig <hch@lst.de>
To: Coly Li <colyli@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, Jens Axboe <axboe@kernel.dk>,
	linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph =?iso-8859-1?Q?B=F6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>,
	David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from
 REQ_OP_DISCARD
Message-ID: <20220410062726.GB16234@lst.de>
References: <20220409045043.23593-1-hch@lst.de> <20220409045043.23593-27-hch@lst.de> <f01ac878-9b0d-972b-70dc-6f3f61b9947b@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f01ac878-9b0d-972b-70dc-6f3f61b9947b@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Sat, Apr 09, 2022 at 10:32:52PM +0800, Coly Li wrote:
>> Acked-by: Coly Li <colyli@suse.de> [drbd]
>
> Hi Christoph,
>
> My ACK is for bcache, not drbd here.

Fixed.


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 06:51:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 06:51:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302370.516026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndRQK-0006w0-NE; Sun, 10 Apr 2022 06:51:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302370.516026; Sun, 10 Apr 2022 06:51:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndRQK-0006vt-Jh; Sun, 10 Apr 2022 06:51:48 +0000
Received: by outflank-mailman (input) for mailman id 302370;
 Sun, 10 Apr 2022 06:51:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndRQJ-0006vh-4b; Sun, 10 Apr 2022 06:51:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndRQJ-0001mL-21; Sun, 10 Apr 2022 06:51:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndRQI-0005LB-Jt; Sun, 10 Apr 2022 06:51:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndRQI-0002sN-JR; Sun, 10 Apr 2022 06:51:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PlJEzs1tACqya9KBJQJ6ZAvDsWBogOo4KBGcjhWSXw8=; b=YLXfohHnwqT//J16XltAPkkYhv
	EAFMI13Wu4kSUzTBgBDQCDJ3FXLo83+DqDPN6N3zQWjPFNoGgebUpY/wIeqt3WYQvRnTzwUAIqC0V
	XG/flzttTVSKgoJs67s7uUgRQUmDBtzYO94QzUhP6BN5g7u01tMaar2epfXaeQPgFbPM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169271-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169271: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 06:51:46 +0000

flight 169271 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169271/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   40 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  300 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 07:27:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 07:27:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302385.516042 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndRyh-0002hM-D4; Sun, 10 Apr 2022 07:27:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302385.516042; Sun, 10 Apr 2022 07:27:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndRyh-0002hF-AA; Sun, 10 Apr 2022 07:27:19 +0000
Received: by outflank-mailman (input) for mailman id 302385;
 Sun, 10 Apr 2022 07:27:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndRyf-0002h5-9N; Sun, 10 Apr 2022 07:27:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndRyf-0002Qw-5z; Sun, 10 Apr 2022 07:27:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndRyd-0006ra-QX; Sun, 10 Apr 2022 07:27:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndRyd-0001bj-Q4; Sun, 10 Apr 2022 07:27:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BFGmaxOB9qXw1cyQ5MN+3gdj8h8T4W5tUivNx0I4Cg4=; b=yatiyah07Y0+EqD6eOuaVz5wBN
	Cy3lqCKDV0b2FUkFtI0Wu435Oq3bqdVjnunZoXQODiX8sF92D+RNnuLb3tQ74i9D3AJ142BD6XXEZ
	vo4aO/QMut/ocz1mmF8hCauDGg85WcJN1nQCldogMpGsnShijpHOMSbfMpVt+/Ep+aNU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169264-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169264: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
X-Osstest-Versions-That:
    xen=2e6f95a942d1927a53f077c301db0b799c54c05a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 07:27:15 +0000

flight 169264 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169264/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169251
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169251
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169251
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169251
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169251
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169251
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169251
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169251
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169251
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169251
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169251
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169251
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
baseline version:
 xen                  2e6f95a942d1927a53f077c301db0b799c54c05a

Last test of basis   169251  2022-04-08 20:07:05 Z    1 days
Testing same since   169264  2022-04-09 21:01:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2e6f95a942..8847ec08fd  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf -> master


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 08:52:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 08:52:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302404.516052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndTIp-0005ip-8W; Sun, 10 Apr 2022 08:52:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302404.516052; Sun, 10 Apr 2022 08:52:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndTIp-0005ii-5a; Sun, 10 Apr 2022 08:52:11 +0000
Received: by outflank-mailman (input) for mailman id 302404;
 Sun, 10 Apr 2022 08:52:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndTIn-0005iY-PJ; Sun, 10 Apr 2022 08:52:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndTIn-0004UV-Nj; Sun, 10 Apr 2022 08:52:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndTIn-0001qR-CG; Sun, 10 Apr 2022 08:52:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndTIn-0001Wy-Bp; Sun, 10 Apr 2022 08:52:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=B0brO2fwgpwAOx1mPMzLNm/HqXHlM/cTnn31xIOzkvE=; b=NSypL/cTL4UBqHqe4H5mr0Zyo4
	ntgk8gxDyI8AG2+hfsi8ce/YM1ID1+yo2vpT8ly/L6pPstqDgH4F4HT0p5hpq62bO1GForNy+WQPi
	mBKBbAVhf08BavEPCkzQh1MXiWynXzpfRlDnJI+nB6adqgVsdRPOhEKMD5mPKQhbX2Yc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169272-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169272: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 08:52:09 +0000

flight 169272 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169272/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   40 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  301 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 10:11:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 10:11:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302415.516064 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndUXU-00079L-7n; Sun, 10 Apr 2022 10:11:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302415.516064; Sun, 10 Apr 2022 10:11:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndUXU-00079E-46; Sun, 10 Apr 2022 10:11:24 +0000
Received: by outflank-mailman (input) for mailman id 302415;
 Sun, 10 Apr 2022 10:11:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndUXS-000794-2Q; Sun, 10 Apr 2022 10:11:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndUXR-000625-UY; Sun, 10 Apr 2022 10:11:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndUXR-0006Hs-CF; Sun, 10 Apr 2022 10:11:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndUXR-0002qG-Bm; Sun, 10 Apr 2022 10:11:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GmHB5rEoiF882CxG7nyAnO1tieVTp9nKieZUYufom4s=; b=FxYtPfgzHo2JL2v8E+Oy2lprfD
	KySaf9TgSC4NCK16sKbix3JojeDm93ekdYR8RyTgDx7mZxqERuOKYDPzQS2IiAPuvomPNRrzfya9g
	/osjH0aUoC9wfF0t/5bk3JZWrGVpoe1NH+mB39FRcXUn+fz7WoXZP1xnn9Y+edKU+Tvs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169274-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169274: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 10:11:21 +0000

flight 169274 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169274/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   40 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  302 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 12:14:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 12:14:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302431.516075 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndWSU-0004jG-8h; Sun, 10 Apr 2022 12:14:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302431.516075; Sun, 10 Apr 2022 12:14:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndWSU-0004j9-5f; Sun, 10 Apr 2022 12:14:22 +0000
Received: by outflank-mailman (input) for mailman id 302431;
 Sun, 10 Apr 2022 12:14:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndWSS-0004iz-K8; Sun, 10 Apr 2022 12:14:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndWSS-0008HC-F1; Sun, 10 Apr 2022 12:14:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndWSS-0003lO-4j; Sun, 10 Apr 2022 12:14:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndWSS-00053U-4N; Sun, 10 Apr 2022 12:14:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7RkaIy2tFPJ1smEfRXCpOauKAFl8U+NDNKMiAZNdtxU=; b=aXWmWPERJpKDOzOjPsTiCvOcjz
	jKRD9u6Q55QYtAMu0nbc0tXv7b8DmCXcgaH4O44vqooLxMdHL8ibV/2xk3256W7EcgxexVmdYM3XZ
	/jIX0G36gLRj9Y9zs4hx9xeDGZDENp7WkSjGgW+p1U4Zr2y4bkda2uchscN1uVZAkqNM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169270-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169270: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=c11fb2132f313b9aa25ad7c57becc72923623874
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 12:14:20 +0000

flight 169270 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169270/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              c11fb2132f313b9aa25ad7c57becc72923623874
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  639 days
Failing since        151818  2020-07-11 04:18:52 Z  638 days  620 attempts
Testing same since   169254  2022-04-09 04:20:15 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104141 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 12:17:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 12:17:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302440.516086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndWVX-0005Ll-Qo; Sun, 10 Apr 2022 12:17:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302440.516086; Sun, 10 Apr 2022 12:17:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndWVX-0005Le-Mv; Sun, 10 Apr 2022 12:17:31 +0000
Received: by outflank-mailman (input) for mailman id 302440;
 Sun, 10 Apr 2022 12:17:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndWVW-0005LW-Jd
 for xen-devel@lists.xenproject.org; Sun, 10 Apr 2022 12:17:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndWVW-0008KX-4t; Sun, 10 Apr 2022 12:17:30 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndWVV-0008J9-VQ; Sun, 10 Apr 2022 12:17:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=5TUnIEqCtm/+qfQwVVSAfNXRXsBnwvcpWlryUSEXQGg=; b=vB2hVUOyxKt+EypUfvsmU8o8mP
	aE3ld+LWbbJ7QXynYAr5g6ZjEotfjv19QDT6MlZGgBE+wZT+KqSXBPfc5j+OSSegPr+j59bWtWRbf
	l156Vh9HgXSkTEKMouMHgSOdJNmeNf2rRtKqT/NxajaqVJUyWHXAP6gaeB5h5bqZT4Ts=;
Message-ID: <4701ade9-5786-e41f-e635-e9e655ef2865@xen.org>
Date: Sun, 10 Apr 2022 13:17:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v3 04/19] xen/arm: mm: Allow other mapping size in
 xen_pt_update_entry()
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Julien Grall <jgrall@amazon.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-5-julien@xen.org>
 <alpine.DEB.2.22.394.2204011605580.2910984@ubuntu-linux-20-04-desktop>
 <a2dafd9a-a0a9-b99d-9592-4f8e5fbb3f20@xen.org>
 <alpine.DEB.2.22.394.2204051345500.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204051345500.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 05/04/2022 21:46, Stefano Stabellini wrote:
> On Sat, 2 Apr 2022, Julien Grall wrote:
>> On 02/04/2022 00:35, Stefano Stabellini wrote:
>>>> +/* Return the level where mapping should be done */
>>>> +static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned
>>>> long nr,
>>>> +                                unsigned int flags)
>>>> +{
>>>> +    unsigned int level;
>>>> +    unsigned long mask;
>>>
>>> Shouldn't mask be 64-bit on aarch32?
>>
>> The 3 variables we will use (mfn, vfn, nr) are unsigned long. So it is fine to
>> define the mask as unsigned long.
> 
> Good point
> 
> 
>>>> +}
>>>> +
>>>>    static DEFINE_SPINLOCK(xen_pt_lock);
>>>>      static int xen_pt_update(unsigned long virt,
>>>>                             mfn_t mfn,
>>>> -                         unsigned long nr_mfns,
>>>> +                         const unsigned long nr_mfns,
>>>
>>> Why const? nr_mfns is an unsigned long so it is passed as value: it
>>> couldn't change the caller's parameter anyway. Just curious.
>>
>> Because nr_mfns is used to flush the TLBs. In the original I made the mistake
>> to decrement the variable and only discovered later on when the TLB contained
>> the wrong entry.
>>
>> Such bug tends to be very subtle and it is hard to find the root cause. So
>> better mark the variable const to avoid any surprise.
>>
>> The short version of what I wrote is in the commit message. I can write a
>> small comment in the code if you want.
> 
> No, that's fine. Thanks for the explanation.

I thought about it and decided to add a comment. This will avoid someone 
to remove the 'const'.

Cheers,
-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 12:30:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 12:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302445.516097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndWi5-00087t-Vf; Sun, 10 Apr 2022 12:30:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302445.516097; Sun, 10 Apr 2022 12:30:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndWi5-00087m-Sm; Sun, 10 Apr 2022 12:30:29 +0000
Received: by outflank-mailman (input) for mailman id 302445;
 Sun, 10 Apr 2022 12:30:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndWi5-00087g-43
 for xen-devel@lists.xenproject.org; Sun, 10 Apr 2022 12:30:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndWi4-00008y-P8; Sun, 10 Apr 2022 12:30:28 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndWi4-0000ee-JM; Sun, 10 Apr 2022 12:30:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Pd57Yesd3M1f9mU19uIPKiS1BYZpw2E5kDkZpnsqjxs=; b=Tel+3wKpy3jtPfjgAQxufSvGMT
	iv7VLbeJhirLS5MpQhqlbldfNmSg3rWLLNPAQgPJHoxidiOx1ACf05bdaaSOfkN3jPN3BDHnTfexv
	J6vLpwm6SttvV2rt75taF88q08TP+EdI9qQXIIX19YwFrooCPDRPR3mE5w2M+iMFruQM=;
Message-ID: <97f7a205-9dc0-53cf-2b90-bda3f9868686@xen.org>
Date: Sun, 10 Apr 2022 13:30:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v3 06/19] xen/arm: mm: Avoid flushing the TLBs when
 mapping are inserted
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-7-julien@xen.org>
 <alpine.DEB.2.22.394.2204011657080.2910984@ubuntu-linux-20-04-desktop>
 <f0d3ed02-450f-9bd1-e8ab-5594234a835d@xen.org>
 <alpine.DEB.2.22.394.2204051348200.2910984@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204051348200.2910984@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 05/04/2022 21:49, Stefano Stabellini wrote:
> On Sat, 2 Apr 2022, Julien Grall wrote:
>> Maybe it would be clearer if I write:
>>
>>   !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN))
> 
> It is not much a matter of clarity -- I just wanted to check with you
> the reasons for the if condition because, as you wrote, wrong tlb
> flushes can have catastrophic effects.
> 
> That said, actually I prefer your second version:
> 
>    !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN))

I have updated the patch to use this switch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 12:47:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 12:47:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302450.516108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndWyL-0001Wm-Eq; Sun, 10 Apr 2022 12:47:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302450.516108; Sun, 10 Apr 2022 12:47:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndWyL-0001Wf-9w; Sun, 10 Apr 2022 12:47:17 +0000
Received: by outflank-mailman (input) for mailman id 302450;
 Sun, 10 Apr 2022 12:47:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndWyK-0001WU-Eo; Sun, 10 Apr 2022 12:47:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndWyK-0000TL-8T; Sun, 10 Apr 2022 12:47:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndWyJ-0004sT-QM; Sun, 10 Apr 2022 12:47:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndWyJ-0007gY-Px; Sun, 10 Apr 2022 12:47:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YB+BSdLW/f1xJmG/lGSABt1p+lnQZUtGKQVeZYhxL3Q=; b=Qn/LbRxUC7Pc7Qnpgb6dZ/xqlJ
	xaZ+PWeTERIN+RVKf87uttvfMlRCmJhuhpQjfZ/ocWqvCNl8VYuYDaMtCD/DRAqTl5yq/fRXT8AcF
	uuENetpxszwMC2dVa6K7YZSzCd5F8hyy5YowSCsZOwqW4DIZjQJBdXFOXgXTmzSQgC10=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169269-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169269: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e1f700ebd6bea293abe3c7e2807b252018efde01
X-Osstest-Versions-That:
    linux=f1b45d8ccb9839b48e5884664470e54520e17f4c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 12:47:15 +0000

flight 169269 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169269/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 169262
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169262
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169262
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169262
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169262
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169262
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169262
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169262
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                e1f700ebd6bea293abe3c7e2807b252018efde01
baseline version:
 linux                f1b45d8ccb9839b48e5884664470e54520e17f4c

Last test of basis   169262  2022-04-09 16:34:38 Z    0 days
Testing same since   169269  2022-04-10 04:19:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Alexey Galakhov <agalakhov@gmail.com>
  Amit Pundir <amit.pundir@linaro.org>
  Avri Altman <avri.altman@wdc.com>
  Chandrakanth patil <chandrakanth.patil@broadcom.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Colin Ian King <colin.i.king@gmail.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dick Kennedy <dick.kennedy@broadcom.com>
  Douglas Gilbert <dgilbert@interlog.com>
  Finn Thain <fthain@linux-m68k.org>
  Jackie Liu <liuyun01@kylinos.cn>
  James Smart <jsmart2021@gmail.com>
  Jason Wang <jasowang@redhat.com>
  John Garry <john.garry@huawei.com>
  Justin Tee <justin.tee@broadcom.com>
  Keoseong Park <keosung.park@samsung.com>
  Kevin Groeneveld <kgroeneveld@lenbrook.com>
  Krzysztof Kozlowski <krzk@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Luca Weiss <luca.weiss@fairphone.com>
  Manish Rangankar <mrangankar@marvell.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael S. Tsirkin <mst@redhat.com>
  Randy Dunlap <rdunlap@infradead.org>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Tom Rix <trix@redhat.com>
  Tomas Henzl <thenzl@redhat.com>
  Tyrel Datwyler <tyreld@linux.ibm.com>
  Wenchao Hao <haowenchao@huawei.com>
  Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   f1b45d8ccb98..e1f700ebd6be  e1f700ebd6bea293abe3c7e2807b252018efde01 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 13:25:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 13:25:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302464.516119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndXYv-0006kW-C4; Sun, 10 Apr 2022 13:25:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302464.516119; Sun, 10 Apr 2022 13:25:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndXYv-0006kP-96; Sun, 10 Apr 2022 13:25:05 +0000
Received: by outflank-mailman (input) for mailman id 302464;
 Sun, 10 Apr 2022 13:25:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndXYt-0006kF-Ao; Sun, 10 Apr 2022 13:25:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndXYt-0001BU-88; Sun, 10 Apr 2022 13:25:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndXYs-0005wS-Vu; Sun, 10 Apr 2022 13:25:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndXYs-0004Dr-VS; Sun, 10 Apr 2022 13:25:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QabsW1qOCXAqx0mKIbFulx63Kmok9zU+NDoLQ6kkcLA=; b=XSUteIiy85sreZv5qLdEsFjP/D
	ET1qVYwoBol/rm7KFb6nPgRcThU1V2w2ZhCpbHgfxdeUamJMIGqYFD5VuDVXR0v/rQdnZ6wx5PgTH
	mN51U/m1BbU4KdGQqhpXXzS9noCfpadyOxRylzFXNuyADBN8qxvsxtzeutJLW0H1JuqI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169275-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169275: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 13:25:02 +0000

flight 169275 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169275/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  303 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 14:24:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 14:24:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302474.516130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndYU4-0005qc-O9; Sun, 10 Apr 2022 14:24:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302474.516130; Sun, 10 Apr 2022 14:24:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndYU4-0005qV-KX; Sun, 10 Apr 2022 14:24:08 +0000
Received: by outflank-mailman (input) for mailman id 302474;
 Sun, 10 Apr 2022 14:24:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndYU3-0005qL-KM; Sun, 10 Apr 2022 14:24:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndYU3-0002KR-Fo; Sun, 10 Apr 2022 14:24:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndYU3-0007bX-1s; Sun, 10 Apr 2022 14:24:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndYU2-0008Sy-Va; Sun, 10 Apr 2022 14:24:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=467Gfcdw12LjTpTB0lP8RcRYhgMbdLA7TLwG/Zjyvdc=; b=VDYjrOMnEipMJypH0+nJ55olXZ
	BYYeLxmbEZ/lOcfP18hLaD5odVjVlwkniJpqj/wUWLy5s+EvXGi9dcCosioVdL+mE9n7duigcoflD
	lIo86OjS8NdqvIe4Uuy8Uoxm4RsBunfTAVhYT+7tkzEljB21Je0kHHOTJtJ3Q/gEOEhQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169277-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169277: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 14:24:06 +0000

flight 169277 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169277/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  304 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 15:36:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 15:36:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302483.516140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndZc9-00065C-1O; Sun, 10 Apr 2022 15:36:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302483.516140; Sun, 10 Apr 2022 15:36:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndZc8-000655-Uc; Sun, 10 Apr 2022 15:36:32 +0000
Received: by outflank-mailman (input) for mailman id 302483;
 Sun, 10 Apr 2022 15:36:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndZc7-00064v-QX; Sun, 10 Apr 2022 15:36:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndZc7-0003cT-NT; Sun, 10 Apr 2022 15:36:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndZc7-00042n-7x; Sun, 10 Apr 2022 15:36:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndZc7-0007MX-7U; Sun, 10 Apr 2022 15:36:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wmnKdd5cp4uGxx8uM/nE+83R7NNsuIFn3SWnyBZ6YdI=; b=hiJnNbH/Sxwofd7yh6idv3+bDE
	94/RI+YYWb3u/obWPb86AE7MUlRntnFGDrg7ip5pY2wU+9kN42+0YZ03OXE0TY3poMvJhWKkPsye0
	2Bkj/f/TrLtDhAB5M6TaMP6XLascYHPka5SjnHkoRC21ZybIWzu+sbYbTMuSHSZJ9ES8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169278-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169278: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 15:36:31 +0000

flight 169278 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169278/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  305 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 16:04:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 16:04:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302493.516152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nda3J-0002BU-BS; Sun, 10 Apr 2022 16:04:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302493.516152; Sun, 10 Apr 2022 16:04:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nda3J-0002BN-8N; Sun, 10 Apr 2022 16:04:37 +0000
Received: by outflank-mailman (input) for mailman id 302493;
 Sun, 10 Apr 2022 16:04:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nda3H-0002BD-4h; Sun, 10 Apr 2022 16:04:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nda3H-0004h1-1A; Sun, 10 Apr 2022 16:04:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nda3G-00053o-Nr; Sun, 10 Apr 2022 16:04:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nda3G-0007aC-NA; Sun, 10 Apr 2022 16:04:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=P0TpomNgavOsga9/dt4uwdlJYW+ZqbwVkta28PebWUc=; b=xSv5/LdCu6VWSaznDm3X41e5hs
	2X/l0QbDhuGpvs2ak4/wiEi1GHCz+Eg4tz8nKH0K0sSqPMhdt+8psILQnFay75RxjiIJBCPhtR87s
	qcEsGVGoKueERN8d/gNQQywAXCP/sEgYBKLVdfIULGvU4p4PzY6yTBTnirWOzT6tQ4Iw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169273-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169273: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-multivcpu:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
X-Osstest-Versions-That:
    xen=8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 16:04:34 +0000

flight 169273 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169273/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-multivcpu 20 guest-localmigrate/x10    fail pass in 169264
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169264

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169264
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169264
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169264
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169264
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169264
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169264
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169264
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169264
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169264
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169264
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169264
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169264
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
baseline version:
 xen                  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf

Last test of basis   169273  2022-04-10 07:29:25 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Apr 10 16:33:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 16:33:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302504.516163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndaUl-0006HE-PQ; Sun, 10 Apr 2022 16:32:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302504.516163; Sun, 10 Apr 2022 16:32:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndaUl-0006H7-Lu; Sun, 10 Apr 2022 16:32:59 +0000
Received: by outflank-mailman (input) for mailman id 302504;
 Sun, 10 Apr 2022 16:32:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndaUk-0006Gx-Qc; Sun, 10 Apr 2022 16:32:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndaUk-0005BQ-NT; Sun, 10 Apr 2022 16:32:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndaUk-0005uW-5n; Sun, 10 Apr 2022 16:32:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndaUk-0001Vt-5N; Sun, 10 Apr 2022 16:32:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=75pOxdXGD9zCZN/lmCqLUN1zVAnRnozE3euJ9MYw46g=; b=PnStegLLk8EkF69S54GzpMkaHn
	83oe2YekpMSmPkYes2TprcfnjLVykwEZSrqS7cmZD794Y5eN1l4QT63IBgt0gpNnKdiOJoCzdYVDd
	kSztHlMd9Wlw6h9BU4XQGmlLbi55Ec92jIaq6qzrFUJsNUm0ZPqKcRnXJtgezeV+XjDY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169279-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169279: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 16:32:58 +0000

flight 169279 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169279/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  306 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 17:06:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 17:06:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302516.516174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndb0P-0001xL-CW; Sun, 10 Apr 2022 17:05:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302516.516174; Sun, 10 Apr 2022 17:05:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndb0P-0001xE-7m; Sun, 10 Apr 2022 17:05:41 +0000
Received: by outflank-mailman (input) for mailman id 302516;
 Sun, 10 Apr 2022 17:05:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndb0O-0001wR-Cc; Sun, 10 Apr 2022 17:05:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndb0O-0005nw-A1; Sun, 10 Apr 2022 17:05:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndb0O-0006vc-0D; Sun, 10 Apr 2022 17:05:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndb0N-0006mx-W1; Sun, 10 Apr 2022 17:05:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Nj5DwHoD5kvp/KIA68LCoH7J3k/zyBI3l2R4fk9mOR0=; b=RNwwdpRR2YyzMWI18LYHJoVUVB
	LUa4i4BPumv0zO0vP9VY+L9D+39W7FNCqjnofpDxQe74y1bZR5C/9KgjoZP6mF+d3r5OOhGFAotmY
	LHJ71LZmZrWBuMT1qEjnJ3E/+8gvEEk6DqSs2ONjsom8RaGhymY7uYNR5VQWE/FZf8iw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169280-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169280: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 17:05:39 +0000

flight 169280 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169280/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  307 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 17:36:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 17:36:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302526.516184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndbTc-00060H-OO; Sun, 10 Apr 2022 17:35:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302526.516184; Sun, 10 Apr 2022 17:35:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndbTc-00060A-LQ; Sun, 10 Apr 2022 17:35:52 +0000
Received: by outflank-mailman (input) for mailman id 302526;
 Sun, 10 Apr 2022 17:35:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndbTb-000600-Ka; Sun, 10 Apr 2022 17:35:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndbTb-0006Kz-GR; Sun, 10 Apr 2022 17:35:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndbTa-0007pL-VW; Sun, 10 Apr 2022 17:35:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndbTa-0001Gy-V3; Sun, 10 Apr 2022 17:35:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cpQDDpIbWH/4e9PH177nX71uSc4cGQB7iPw8vDAuN6Y=; b=QsIxKdByxAAR51aV9pDRIRAKTq
	DisCzMxI+XbnnW/eWxrBkG0oiJ9JbbMw1eOy8Jlo8ZmffN3ay9/ylIBn5CjcSoUvczKotlxFa+zKQ
	VXw7itIxgeAjpVE12UPTPCqew22YDxSrhjsQY19xrnys1n+3Zxwae90XWa1AYa4FxQNE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169281-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169281: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 17:35:50 +0000

flight 169281 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169281/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  308 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 18:46:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 18:46:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302536.516196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndcZg-0006Jd-TV; Sun, 10 Apr 2022 18:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302536.516196; Sun, 10 Apr 2022 18:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndcZg-0006JW-Po; Sun, 10 Apr 2022 18:46:12 +0000
Received: by outflank-mailman (input) for mailman id 302536;
 Sun, 10 Apr 2022 18:46:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndcZf-0006JM-Gk; Sun, 10 Apr 2022 18:46:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndcZf-0007j2-DV; Sun, 10 Apr 2022 18:46:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndcZf-0001Jb-0l; Sun, 10 Apr 2022 18:46:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndcZf-0001nA-0L; Sun, 10 Apr 2022 18:46:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9FKxKuQ+hKbEvOQKkoCS/ltQJmqBH3SbOQkOWOwUMOE=; b=XVMX04DaxOmvbIrUpYHrGZTqUm
	LzHf0m3uq9KnBXChfgaj2xbSdncAFMrwpzFz0mdZzPVb0h/+e0yVZv4L9m2MQNbaL7L7mobrkoFQh
	35UDYzepMvvFvjZwl/wBFSHjvb1KrHT28r6iZGYegaRDUTsCS1pH9GljhPFFaQZZUWoU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169282-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169282: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 18:46:11 +0000

flight 169282 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169282/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  309 attempts
Testing same since   169258  2022-04-09 08:33:35 Z    1 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4714 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 19:42:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 19:42:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302546.516206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nddRl-0005Si-AT; Sun, 10 Apr 2022 19:42:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302546.516206; Sun, 10 Apr 2022 19:42:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nddRl-0005Sb-7e; Sun, 10 Apr 2022 19:42:05 +0000
Received: by outflank-mailman (input) for mailman id 302546;
 Sun, 10 Apr 2022 19:42:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nddRj-0005SB-Th; Sun, 10 Apr 2022 19:42:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nddRj-0000Ko-KB; Sun, 10 Apr 2022 19:42:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nddRj-0002l2-4F; Sun, 10 Apr 2022 19:42:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nddRj-0008FQ-3o; Sun, 10 Apr 2022 19:42:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=V41W/uG7OHvcAZLcmxdwlilz4cf9F23itYd2B2zCMeY=; b=bKtTW5buU+jKCfK0Ac5IrKkJ3K
	jRMez3A37So0ThVZsbtARnhBb18uGinhIIFQiXfB4gQouhDQdCrRp5eNmQ+bdYGALAa2GUK2VsNhZ
	uuIHqKP2h9HVKSqZFfvCSFZWyA6LCYHSF9A4yAmrxGxsNOGdIDMP/F06sJ1utRcGdnAA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169283-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169283: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=bfefdc2c49ca9487b7aa0df196b2aca6c0c170a2
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 19:42:03 +0000

flight 169283 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169283/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 bfefdc2c49ca9487b7aa0df196b2aca6c0c170a2
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  310 attempts
Testing same since   169283  2022-04-10 19:10:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4739 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 20:55:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 20:55:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302556.516218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndeaM-0005t6-MW; Sun, 10 Apr 2022 20:55:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302556.516218; Sun, 10 Apr 2022 20:55:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndeaM-0005sz-Jb; Sun, 10 Apr 2022 20:55:02 +0000
Received: by outflank-mailman (input) for mailman id 302556;
 Sun, 10 Apr 2022 20:55:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndeaL-0005sp-7G; Sun, 10 Apr 2022 20:55:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndeaL-0001ko-1o; Sun, 10 Apr 2022 20:55:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndeaK-0004SG-G9; Sun, 10 Apr 2022 20:55:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndeaK-0008Pa-Fi; Sun, 10 Apr 2022 20:55:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/PfP7z7/2y1WJOeRYuMujHlCAFbaloZCwvgT9lnKcVU=; b=iZytIWowR1xDvY33A1eOCz1A22
	jCk/tpuDXG6VWyaRiVjAowNLboMksMBFwgH676KHz5frMDbLnAg0QpdcIW9Qtq/0xC7w/CSRydpAk
	waVN5Gmj2BdWsYmLyWMrwZe+U2gaenLomCuPiMloxlJytHi4e2RFvLGhcH7hAclXibuw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169276-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169276: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1862a69c917417142190bc18c8ce16680598664b
X-Osstest-Versions-That:
    linux=e1f700ebd6bea293abe3c7e2807b252018efde01
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 20:55:00 +0000

flight 169276 linux-linus real [real]
flight 169284 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169276/
http://logs.test-lab.xenproject.org/osstest/logs/169284/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 169284-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169269
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169269
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169269
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169269
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169269
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169269
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169269
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169269
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                1862a69c917417142190bc18c8ce16680598664b
baseline version:
 linux                e1f700ebd6bea293abe3c7e2807b252018efde01

Last test of basis   169269  2022-04-10 04:19:31 Z    0 days
Testing same since   169276  2022-04-10 13:09:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Athira Jajeev <atrajeev@linux.vnet.ibm.com>
  Athira Rajeev <atrajeev@linux.vnet.ibm.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Chengdong Li <chengdongli@tencent.com>
  Dan Williams <dan.j.williams@intel.com>
  Denis Nikitin <denik@chromium.org>
  Disha Goel <disgoel@linux.vnet.ibm.com>
  Ian Rogers <irogers@google.com>
  James Clark <james.clark@arm.com>
  Jiri Olsa <jolsa@kernel.org>
  John Garry <john.garry@huawei.com>
  Leo Yan <leo.yan@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michael Petlan <mpetlan@redhat.com>
  Namhyung Kim <namhyung@kernel.org>
  Randy Dunlap <rdunlap@infradead.org>
  Sedat Dilek <sedat.dilek@gmail.com> # Debian/Selfmade LLVM-14 (x86-64)
  Shreeya Patel <shreeya.patel@collabora.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e1f700ebd6be..1862a69c9174  1862a69c917417142190bc18c8ce16680598664b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 21:03:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 21:03:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302565.516228 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndeik-0007ed-K2; Sun, 10 Apr 2022 21:03:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302565.516228; Sun, 10 Apr 2022 21:03:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndeik-0007eW-HA; Sun, 10 Apr 2022 21:03:42 +0000
Received: by outflank-mailman (input) for mailman id 302565;
 Sun, 10 Apr 2022 21:03:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndeii-0007eM-Ty; Sun, 10 Apr 2022 21:03:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndeii-0001wD-RW; Sun, 10 Apr 2022 21:03:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndeii-0004eS-Gz; Sun, 10 Apr 2022 21:03:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndeii-0001sv-GW; Sun, 10 Apr 2022 21:03:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xMZapzMoPTiMQWKWAjp5u6J3r21ngAMu44jwSN7UmlU=; b=cE6P0Xf0s3fzYci1xeGboq42wK
	v3FM+cV7pCG6u5Xc7+KK/3fk3tVIvvBGw2KTDdqV04LyBjn9fyY9Luxb65BXuW/qdfE1RjU8pFbBq
	yW+pAHF3qBElv4yK8TWl+2tHDV7fEhtuyLI7oph+FDbMtcXTt50empwG89kYdzIpjgHU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169285-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169285: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=676084303d261cb1e4b9bfacea88284adc08d243
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 21:03:40 +0000

flight 169285 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169285/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 676084303d261cb1e4b9bfacea88284adc08d243
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  311 attempts
Testing same since   169285  2022-04-10 20:10:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4756 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 22:35:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 22:35:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302576.516240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndg98-0001wP-Ax; Sun, 10 Apr 2022 22:35:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302576.516240; Sun, 10 Apr 2022 22:35:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndg98-0001wI-7s; Sun, 10 Apr 2022 22:35:02 +0000
Received: by outflank-mailman (input) for mailman id 302576;
 Sun, 10 Apr 2022 22:35:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndg97-0001w8-Rc; Sun, 10 Apr 2022 22:35:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndg97-0003aB-PS; Sun, 10 Apr 2022 22:35:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndg97-0007MX-F9; Sun, 10 Apr 2022 22:35:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndg97-00052M-Eg; Sun, 10 Apr 2022 22:35:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OgUARLdpfdaYwf58acm6cWoUWUWnaYNHY29S28zN2Uc=; b=5tl2rty7Gav3B+sFxzFoXsC73b
	Ln+k0pTtb9vA/HBKe8IFsL0aSEBerpUpV68uMsf8B/N4sJn4WEubmkYs/+jd4mZPQf+zubOQSAyUb
	7OWB4T126bDxXZNN1WMoULti2o0Mf0z9ObwJWGfA7d594tNqNUh+wq+ZzOehl8sLRtbY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169287-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169287: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 22:35:01 +0000

flight 169287 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169287/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  312 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 10 23:38:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Apr 2022 23:38:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302587.516251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndh7n-00019P-1D; Sun, 10 Apr 2022 23:37:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302587.516251; Sun, 10 Apr 2022 23:37:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndh7m-00019I-U9; Sun, 10 Apr 2022 23:37:42 +0000
Received: by outflank-mailman (input) for mailman id 302587;
 Sun, 10 Apr 2022 23:37:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndh7l-000198-UA; Sun, 10 Apr 2022 23:37:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndh7l-0004m5-SK; Sun, 10 Apr 2022 23:37:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndh7l-0001UH-Ho; Sun, 10 Apr 2022 23:37:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndh7l-0007VO-HO; Sun, 10 Apr 2022 23:37:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9JYX78/wPenbFC6vhUnaLFIt1zlC3jI14XTnPqYGKgY=; b=PTZXRiCFMPzmKJ1ttaEunX6kmM
	+nUUL9UqRDmn4wBWK3PCd9d7YTcz3TvVEhr2+6AiZgDJ18w/LgFyWfs6700ZERgGBG5921pajxnJI
	HAjvv/T6398IdgD53lPwH25+3bSjVdrmKFznyJmX5HQgBpiRBKeJBUM8ECv5G8gRNGhg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169288-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169288: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Apr 2022 23:37:41 +0000

flight 169288 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169288/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  313 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 00:29:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 00:29:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302598.516261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndhw9-0008Vb-UP; Mon, 11 Apr 2022 00:29:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302598.516261; Mon, 11 Apr 2022 00:29:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndhw9-0008VU-RU; Mon, 11 Apr 2022 00:29:45 +0000
Received: by outflank-mailman (input) for mailman id 302598;
 Mon, 11 Apr 2022 00:29:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndhw7-0008VK-MA; Mon, 11 Apr 2022 00:29:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndhw7-0006QJ-Ii; Mon, 11 Apr 2022 00:29:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndhw6-0003Ty-Hv; Mon, 11 Apr 2022 00:29:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndhw6-0007ft-HS; Mon, 11 Apr 2022 00:29:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/pmIvMcL1CuYSvzxAiPwkLdyCqLZibFlQ0l5sFZWxnE=; b=3auPB6qVX2wCbkjGPxXRC7m3Pi
	zCnh7XErb7Vgnn6EkI/yoNUHOZrFRqFE6IrfMMl0qEJmFsYumFK8E1P+Y4cbx2wjIo1/JRXFzW7is
	RGlpIVE+65UtCf2saQo+35UqzXUZQeOaq8neof4JUDnH0e5yB7lRmLazses4hQqoJ6P8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169289-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169289: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 00:29:42 +0000

flight 169289 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169289/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  314 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 01:00:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 01:00:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302607.516273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndiPV-00060k-Cx; Mon, 11 Apr 2022 01:00:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302607.516273; Mon, 11 Apr 2022 01:00:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndiPV-0005za-9g; Mon, 11 Apr 2022 01:00:05 +0000
Received: by outflank-mailman (input) for mailman id 302607;
 Mon, 11 Apr 2022 01:00:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R/O6=UV=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ndiPT-0004Y3-V3
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 01:00:04 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20617.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::617])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b64f893a-b932-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 03:00:00 +0200 (CEST)
Received: from AS8PR05CA0011.eurprd05.prod.outlook.com (2603:10a6:20b:311::16)
 by DB9PR08MB6618.eurprd08.prod.outlook.com (2603:10a6:10:263::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 00:59:53 +0000
Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:311:cafe::4f) by AS8PR05CA0011.outlook.office365.com
 (2603:10a6:20b:311::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 00:59:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 00:59:52 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Mon, 11 Apr 2022 00:59:52 +0000
Received: from 62d5414d6b6d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 522EF18C-8B96-40A9-B15E-09D26E4A4C3E.1; 
 Mon, 11 Apr 2022 00:59:45 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 62d5414d6b6d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 00:59:45 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by DB8PR08MB4026.eurprd08.prod.outlook.com (2603:10a6:10:aa::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 00:59:43 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a%4]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 00:59:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b64f893a-b932-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/8kfpq6onMB9lqcbPBsinR+/NfAdKMM2NGVnDoowT5I=;
 b=w6cuHV53I22qva6wQuVmogMXL5l2Xcwe9fpUEWOLcqIJXQ6BpZFkToqW3WpLgYN6pgfY2Ai/ooIfJUjfzQn6uP8gNacndEh8RNnCT8Gys0b+EMyDI0Z/DSPsV8bXDW8G52pEwLZm7ORv413+mwAJrTgwImZdpj+vpK9Z6+2nJgg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H4gzpbYdFoVMMPdKdffXjslb+mOswSX7YAEuN+wVUSsGrBWN1bft/igMzaCVJjM9hOckahKK89emshj1xlZ46SeBBpxXVveP2mA5cMmXcjIFQ6cD6pf/cDn3kZwZ1EQwup0QVIIdul+INX1cAIsZSvzgn4UI1Te1wpMvGP3iHED2Pw26nwtMLzUso+BrZ28XdHbW4YMFZuoFqy7Gy25j/2CLbMqxjRxZU5b4uN46P/Ui63jLQP1gzfx3hu2K3RMRe/CrvMxiZ1MCzudStPt0bzM+Fq2EtcLqfXnAaozUWXY3x2qSREh5IbVJ82+wmDnjpZN6xSDyb08N3kP7ZV2mIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/8kfpq6onMB9lqcbPBsinR+/NfAdKMM2NGVnDoowT5I=;
 b=QfK/7j0tVM9Xo7HhH/q/Wo072kNGO8b2xiaAvhovSDokttjdSy71Tix0se3TELT1sWrxGXDkCK3juFI5Toy/yhSGZl7iwDvRhdt8P81Pki8LKCzV36ysQAc9ye1qv1nSDYPXRTv5i5t3E39ScreKcEp9WGOcHPW8A+l7b1KRLOAw/7H6qeqWMwP9tjHBd+/yF17FmCPxEN2mhrNhgedmOQDY7gBBKnQSkqFGHj0dP4BtsEuqvQeACSdukYhtYNwuf/mnyfMrwe2avEJFDOr+2Gv1gsuhoR6alrZoZfb5FCU4/lsJ0Li2S3Y9c9ZFBdDj2qjsFqh8F72HRlG6s67lRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/8kfpq6onMB9lqcbPBsinR+/NfAdKMM2NGVnDoowT5I=;
 b=w6cuHV53I22qva6wQuVmogMXL5l2Xcwe9fpUEWOLcqIJXQ6BpZFkToqW3WpLgYN6pgfY2Ai/ooIfJUjfzQn6uP8gNacndEh8RNnCT8Gys0b+EMyDI0Z/DSPsV8bXDW8G52pEwLZm7ORv413+mwAJrTgwImZdpj+vpK9Z6+2nJgg=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>
Subject: RE: [PATCH v3] SUPPORT.md: add Dom0less as Supported
Thread-Topic: [PATCH v3] SUPPORT.md: add Dom0less as Supported
Thread-Index: AQHYSt1CmA0pSQ994kax2RW1hM7xyKzlLkpggAEVkwCAA6T7IA==
Date: Mon, 11 Apr 2022 00:59:43 +0000
Message-ID:
 <PA4PR08MB62537A47CA97F799DD8D1E0492EA9@PA4PR08MB6253.eurprd08.prod.outlook.com>
References:
 <alpine.DEB.2.22.394.2204071706470.2910984@ubuntu-linux-20-04-desktop>
 <PA4PR08MB6253660FF724000CFCD7A8C192E99@PA4PR08MB6253.eurprd08.prod.outlook.com>
 <b8b62b5f-a643-2624-fa57-ad42d315b39e@xen.org>
In-Reply-To: <b8b62b5f-a643-2624-fa57-ad42d315b39e@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 3357F2201DCD424795B859B0716F8CF2.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 7b2348bc-68e5-435d-2299-08da1b569614
x-ms-traffictypediagnostic:
	DB8PR08MB4026:EE_|VE1EUR03FT004:EE_|DB9PR08MB6618:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB661851FCC7095E978E9A8ADC92EA9@DB9PR08MB6618.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 CwfE5ajXBkn8xuxCgTamgYYtjQuBaMa2twBzN8Z5wL9TUfmBjDLwSmMAvbpZwL5YNE2HauMC0gRmVf4PSkoXilE/TIJO62+o4a/zYXFSzq4Do3ltPC7Aqb8liFdRZ6Yzb3zjTHuw62dUTyR7cBJs/M1m+Kf/C3qnvC29AGbxWgV6ok5OwRtEVoYHY/jrXtQ648ScGWTTKLw8tFHXOIABpwEODWGpOjo+zXl6jQ6GM1Zqrc4e5HpuKWiB1Q+3f+IQpsVFG3fG5MIhqDS/Z+SB1YpUd8mWF8Cn2RCPQxN6+qnV41uRmZRq56NpAWKSUvXsFkINq6+9KzVg8rZxfane5f3+gjgN6yN0jW5HcjzHhA0eIYd0Roj4++JIOj6+9wcYpw3+uzTz1oim6cyzF/jyU8jTY4Ql8ObweP50qQpcOVb+8fbbVS1XMbhMCAOLzTlHh/EcPU/YT7x46wvKOklwXXJ1jP6LT1V3Id1CofxKyiQ0t/Zym6PgYdQMaCFkV5yvjyqaB26vfWUqgWAYDYbs4HiJhmTFkoe8A73JK4xZ8Uoz4lIrUfUuSvYNDgzi7swe6gBEmgpyHo+IuMSC1y4CLkjFRGor7gaAyrq0BstcGDy8mvpK9vKyx4Nk3jc7vGG821WTQ76MUy8LkoJz/6BsWOyWTNbpvpGz4YOtk399lFOaLR+vSoym61z4Zl7IetaAApt6BPdI6g6+RXr1ChEmcPPE0LPZW4rQT1lxJPXLyOk=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(5660300002)(8936002)(52536014)(508600001)(71200400001)(86362001)(55016003)(38070700005)(38100700002)(316002)(186003)(122000001)(110136005)(54906003)(26005)(9686003)(83380400001)(2906002)(4326008)(33656002)(66476007)(66446008)(8676002)(64756008)(66556008)(76116006)(66946007)(6506007)(7696005)(32563001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4026
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fdeb32cf-4eee-464f-b67b-08da1b569089
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YOq5NlRYahHfYGognQJXHOtM+W8CtkXx/GO6icXibalOv7vlmbKYCpxoJWuTxaeaL6e2j5Bip8pv7GS7VcF/c5JuCSwpsmrEv7vW3Kf4c3KEmPJ99OzKFfsf28/tGu1OSvIeGIl/TeFy9usLOViUNzBZs69tGNtcimCX+Ua+KZaFcIAdkB4B9sHCirtqVFTLemMYKXwTAsMQr8PSqv/QmfIH9YfBTDT2UePlj7/0rooSAL9DNxnmjoGqGMVZlgOo4NTgTXfrHgAoqxSPzp0vS1QVjiGRySmCg+mAkvoTsgFnDOJZWccGLUhNrozew2SW9BuTpJT/Q35t46DYUh2m3lBDK/+YbNxBsy5p7EFq3dEXzxkDdEqHZaM7zjPki5fJdtHyBT9Hhvt0IkWUAXGHXFaRNeB8VFlm+PvumSTg++8xP2FlgTJX7MsIlr+Q8VF8/LnFqEJlWwtTE3LaC1ZJNxWStMhTEhxvsJtH84HrvMjpUgj5MPD9KlKBmHWPnOKvsrgmMnUgMSHEmsKEXFbzYZ+MnmK7x1eqr6615/Nx/IdLJlHJRfLi6QpeHIAVYzGYpSjogZXreBadYJ16d6GKOy9q5IebY9LR5b5R+DnWKFDZNQ6jrrFqFSL17xNbvU3J/ynjiuM/j/bC/86erUvhDuEzRgoLzw4GqAlKJGLCZL4=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(5660300002)(356005)(4744005)(110136005)(54906003)(2906002)(508600001)(9686003)(33656002)(316002)(6506007)(7696005)(26005)(186003)(82310400005)(336012)(70206006)(70586007)(47076005)(8676002)(4326008)(86362001)(8936002)(52536014)(81166007)(83380400001)(36860700001)(55016003)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 00:59:52.4292
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b2348bc-68e5-435d-2299-08da1b569614
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6618

SGkgSnVsaWVuIGFuZCBTdGVmYW5vLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+
IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4NCj4gPiBGb3IgdGhlIHBh
dGNoIEkgZG9uJ3QgaGF2ZSBhbnkgY29tbWVudHMsIGJ1dCBJIHRoaW5rIGhlcmUgd2UndmUgZ290
DQo+ID4gYSB0eXBvOiBzL21lc3NhaGUvbWVzc2FnZS4gSSB0aGluayBpdCBpcyBvayB0byBmaXgg
d2hpbGUgY29tbWl0dGluZyB0aGlzDQo+ID4gcGF0Y2ggc28gdGhpcyBpcyBqdXN0IGEga2luZCBy
ZW1pbmRlciA6KSkNCj4gDQo+IEFueXRoaW5nIGFmdGVyIC0tLSB3aWxsIGJlIHN0cmlwcGVkIGJ5
IGdpdCBhbS4gU28gdGhlcmUgaXMgbm90aGluZyB0bw0KPiBmaXggaXQgb24gY29tbWl0Lg0KDQpB
Y2ssIHRoYW5rcyBmb3IgdGhlIHJlbWluZGVyLiBTb3JyeSB0byBTdGVmYW5vLg0KDQpLaW5kIHJl
Z2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwN
Cg==


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 01:13:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 01:13:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302613.516284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndicd-0007uv-Mu; Mon, 11 Apr 2022 01:13:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302613.516284; Mon, 11 Apr 2022 01:13:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndicd-0007uo-K0; Mon, 11 Apr 2022 01:13:39 +0000
Received: by outflank-mailman (input) for mailman id 302613;
 Mon, 11 Apr 2022 01:13:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndicc-0007ue-B9; Mon, 11 Apr 2022 01:13:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndicc-0007wn-8e; Mon, 11 Apr 2022 01:13:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndicb-0005Az-QN; Mon, 11 Apr 2022 01:13:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndicb-0007br-Px; Mon, 11 Apr 2022 01:13:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rGi+nCe868mciNPWLmuJRA/BXWD0yK8LNam6GsHPRKw=; b=svxNY13NqCAkcOV+0HcrSRksuK
	XbcnVJ5i+PBofyfwwvNs1sGDHEpTIO0S4l3hItBPdn4vXo4AJ9sP/ByZJkAIRTr8jyGrUiFEpgOSU
	gOJ5n+9dAuYefK0Nys507NQb4INRsC//SeQYsk7pnq5yjsbF0U6fGOJ19259o61/OEDE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169290-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169290: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 01:13:37 +0000

flight 169290 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169290/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   40 days  315 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 02:13:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 02:13:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302623.516295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndjXs-0007TE-2A; Mon, 11 Apr 2022 02:12:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302623.516295; Mon, 11 Apr 2022 02:12:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndjXr-0007T7-Un; Mon, 11 Apr 2022 02:12:47 +0000
Received: by outflank-mailman (input) for mailman id 302623;
 Mon, 11 Apr 2022 02:12:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndjXq-0007Sx-FN; Mon, 11 Apr 2022 02:12:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndjXq-00015U-77; Mon, 11 Apr 2022 02:12:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndjXp-00071X-Kr; Mon, 11 Apr 2022 02:12:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndjXp-0001OC-K3; Mon, 11 Apr 2022 02:12:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=l2rhHxm7ZVhz7+iILRb+6K9MVjPNBZbaDDQh2Qlx/rA=; b=P0YQebhDPPfkRnSGdpTEnXFgb1
	wLOnfttbswjsRYePZPgN232AbRTPAchEipfXVBGoxKiw7iFXQeythyowLc5lVaoUs3Dpo5eKEnQJq
	Nwb1UM4/KynJv/jxu+o1oW7g9iR/OgnlEJKNHXmbrbzGiI62yt5fgV4HVyVUoz4ybkQE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169291-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169291: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 02:12:45 +0000

flight 169291 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169291/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  316 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 03:15:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 03:15:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302632.516306 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndkW6-0007A5-Fz; Mon, 11 Apr 2022 03:15:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302632.516306; Mon, 11 Apr 2022 03:15:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndkW6-00079y-Cp; Mon, 11 Apr 2022 03:15:02 +0000
Received: by outflank-mailman (input) for mailman id 302632;
 Mon, 11 Apr 2022 03:15:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndkW5-00079o-0G; Mon, 11 Apr 2022 03:15:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndkW4-0002kX-UU; Mon, 11 Apr 2022 03:15:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndkW4-0000F6-KI; Mon, 11 Apr 2022 03:15:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndkW4-0007fd-Jq; Mon, 11 Apr 2022 03:15:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2k9izz8CuagTeXzVymbyS1OY4u9QF+Gb6BXYLkZ87zw=; b=BgsQO94+Ibth29QOrjqt2Tba7Y
	9IEax028d8oYM1NmPTuhiZQIgojlJY9AR0x43ALx8lD6EfGEB+goK83eBx1p4GOt97EnhrU3Ggs0m
	Tze13GO+a4yJqeS3Wv2DtZ96h4TWn0vsrwCWCG55KmBN2QjlsbPQOCUXPvraRe/DcIJ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169293-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169293: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 03:15:00 +0000

flight 169293 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169293/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  317 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 03:36:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 03:36:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302641.516317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndkqu-0001gr-BL; Mon, 11 Apr 2022 03:36:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302641.516317; Mon, 11 Apr 2022 03:36:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndkqu-0001gk-7n; Mon, 11 Apr 2022 03:36:32 +0000
Received: by outflank-mailman (input) for mailman id 302641;
 Mon, 11 Apr 2022 03:36:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndkqt-0001ga-In; Mon, 11 Apr 2022 03:36:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndkqt-00036F-FS; Mon, 11 Apr 2022 03:36:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndkqt-0001Ia-3c; Mon, 11 Apr 2022 03:36:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndkqt-0005OB-3D; Mon, 11 Apr 2022 03:36:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+O64iYmZ5OQ4Rhn3WcPhJvBZKyWEEaOX5QIuv49fiPI=; b=DUQzsLikKdJSh+IUzRAy4oFG+Y
	1VEUHCA3yFoVdAkZRK8YW4qjq3COmUrGW0wSRPJhnAUjwoY2tZg9egLlnCkKBg1W7dI9G8RnFu+g/
	MYOn5Y8dKjzXo4jlrqQhxWANRk2qdAfm+uPWV4JJbZCjDWV98r4B02PNGNIkexWiDiu0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169286-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169286: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=8b57b3046107b50ebecb65537a172ef3d6cec673
X-Osstest-Versions-That:
    linux=1862a69c917417142190bc18c8ce16680598664b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 03:36:31 +0000

flight 169286 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169286/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169276
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169276
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169276
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169276
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169276
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169276
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169276
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169276
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                8b57b3046107b50ebecb65537a172ef3d6cec673
baseline version:
 linux                1862a69c917417142190bc18c8ce16680598664b

Last test of basis   169276  2022-04-10 13:09:46 Z    0 days
Testing same since   169286  2022-04-10 21:09:47 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian-Ken Rueegsegger <ken@codelabs.ch>
  Alexei Starovoitov <ast@kernel.org>
  Andre Przywara <andre.przywara@arm.com>
  Borislav Petkov <bp@suse.de>
  Chengming Zhou <zhouchengming@bytedance.com>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Dave Hansen <dave.hansen@linux.intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jiri Slaby <jslaby@suse.cz>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Kan Liang <kan.liang@intel.com>
  Kan Liang <kan.liang@linux.intel.com>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marc Zyngier <maz@kernel.org>
  Michael Ellerman <mpe@ellerman.id.au>
  Michal Hocko <mhocko@suse.com>
  Nadav Amit <namit@vmware.com>
  Namhyung Kim <namhyung@kernel.org>
  Nathan Chancellor <nathan@kernel.org>
  Nianyao Tang <tangnianyao@huawei.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nick Desaulniers <ndesaulniers@google.com>
  Oscar Salvador <osalvador@suse.de>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Reto Buerki <reet@codelabs.ch>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  Shawn Guo <shawn.guo@linaro.org>
  Srikar Dronamraju <srikar@linux.vnet.ibm.com>
  Sven Schnelle <svens@linux.ibm.com>
  T.J. Alumbaugh <talumbau@chromium.org>
  Thomas Gleixner <tglx@linutronix.de>
  Vincent Mailhol <mailhol.vincent@wanadoo.fr>
  Yang Yingliang <yangyingliang@huawei.com>
  YueHaibing <yuehaibing@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   1862a69c9174..8b57b3046107  8b57b3046107b50ebecb65537a172ef3d6cec673 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 05:57:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 05:57:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302652.516328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndn2w-0002XV-M3; Mon, 11 Apr 2022 05:57:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302652.516328; Mon, 11 Apr 2022 05:57:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndn2w-0002XO-J3; Mon, 11 Apr 2022 05:57:06 +0000
Received: by outflank-mailman (input) for mailman id 302652;
 Mon, 11 Apr 2022 05:57:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndn2v-0002XE-0l; Mon, 11 Apr 2022 05:57:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndn2u-0006Fr-V0; Mon, 11 Apr 2022 05:57:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndn2u-00006z-K9; Mon, 11 Apr 2022 05:57:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndn2u-0002El-Je; Mon, 11 Apr 2022 05:57:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=L5grf6bNW2/JvahFUPceD9sKp6XZhDYH3urfKUgtwXY=; b=WInTN0yv6Y+zQfJssw+7crQWMf
	nCAJtKXgle+6pPAglxsj3Dnm+qibSYOxZYXfj608fAITKnTAX0ywWoUYh0Cb5rgZTkLEm0m3ZLxn7
	dZBOAXAfga+v5YBrodX8vVvcNH9F1sKFwP1SWslWwrjpDLjoHhws9yMFx6Mr/wEEiBiI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169295-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169295: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 05:57:04 +0000

flight 169295 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169295/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  318 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 06:13:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 06:13:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302662.516338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnIf-0005XQ-2J; Mon, 11 Apr 2022 06:13:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302662.516338; Mon, 11 Apr 2022 06:13:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnIe-0005XJ-Vj; Mon, 11 Apr 2022 06:13:20 +0000
Received: by outflank-mailman (input) for mailman id 302662;
 Mon, 11 Apr 2022 06:13:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndnIe-0005XD-0J
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 06:13:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7aa41de4-b95e-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 08:13:18 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-1N6I73H8MhCtm8w2nZXkew-1; Mon, 11 Apr 2022 08:13:14 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB6028.eurprd04.prod.outlook.com (2603:10a6:10:c1::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 06:13:13 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 06:13:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7aa41de4-b95e-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649657598;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ETHHPGadrGIBjS/7HRxDm2c4pKN8l04pwuOifkVBBuA=;
	b=JjtD7oS5ZmREEM/A9R3fUiWpjFAi69KcSiFrKfPMSWa3mplcZmpyZH9ZBcbWzQvIOhwAr0
	IV5nlnN1wI5S7Pplvei3//nSJY+lqb2g3NPFWdpHECBhkbJfRZQiTE8A2YxC3jqkE3zIhE
	iW6kkfoetG9qsbWNLIfAl+wBG5YApYo=
X-MC-Unique: 1N6I73H8MhCtm8w2nZXkew-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=drb5rZRqDxx3iWkHbAuRRZS+Xh2k7kc/PPNHFAGEEG594+pFsv86tixRhMYW/4PhMY/HTxIpkG5xBoQ7UJd8GUi4OM+mFuEVeCsf27IS0j9g6UtNxc/CisftuXu9Ndi4gaj5X0bXZeMe5iB9vEZAe7ACc+TrCyeuQVw/2cRLvY71PrpWN5A1fUmEcMTqm/PFGtNWluQHaRWxjis+bu4N1VMOj8GiabqorEiP6hi4QhZOu4zqKYlL8+5ofJ2+zfRKP6MSjJIuzl1Ew18hp3uF9fKnboUt11yDP6831VEaET2fGD2zWMeqlDyUdvtmj6eovD/N1iIFQbOrje/zotMhvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ETHHPGadrGIBjS/7HRxDm2c4pKN8l04pwuOifkVBBuA=;
 b=VD/UJfPNvnNsxUJ1RVB3oD3b44zwxokFIB7oImqcbcezpW2alajduNSnW+9riKjDnu3AyTEBJI8EieGx2vc+SVg7yiyaL68URrqdPk2pISREWh05TmBANNfBnkQJ+qOu26uSkIyrQbOW9Z2Xca8vGtP709UBIDlC86W3azoLkKcdPdsb+bcv36TVNvn7Hf5nq7KYfq3um+BgFZaexciqRY4EDf/72ieyAHY5PuRCmYOe89/NkMx792O6eN1yputbkt83+37+DJjuRXGLT0uZCeuu9plZPceWlfQkL2YQsqyitoiBgjSTr1NAfKCX4MdKRtH+S80VaxhY7JEm/1Bg+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <747017ab-9aa9-b958-8cbf-42c2cc3ffdb1@suse.com>
Date: Mon, 11 Apr 2022 08:13:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
 <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
 <3217803e-16d5-6e2a-bde7-ff9a1237dd39@suse.com>
 <decf721a-8062-a23f-a810-78fb86a42d1d@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <decf721a-8062-a23f-a810-78fb86a42d1d@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0111.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 884469cf-2f87-42c5-b53b-08da1b825c47
X-MS-TrafficTypeDiagnostic: DBBPR04MB6028:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB60280B629F33442EBF627C25B3EA9@DBBPR04MB6028.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IFhuAF6KRihPI9bWv+tE4FWosx33ScK5UBui2Y5lgQiJId/W74ZQ3eFxUvOBkIImaU0IWOMOhhaPQ6RA4+bqEodWHdPn4s7MJ3ShvQqc380A4obNK8LtdxcWACCFiT2TclkFCA7dScPod4rOUr+QRT2M2eXw7/nVj0DmBffvHOHyPCzCHE0zgFYexAxf64spJqtKYlP9jPQE4eHNesllq3C9bReZfL967jvAQM5cxr9uHvc4app0BLUnXQS+k7gC01yedTz93m+CEYdQJB89gMl0Uivacvn+IFaJgaEy7km6adeWw6pMBVfz7LKooGM5eOPNEUzTDoP7iunPLGAbxIAa17vgV2W1FbexSsDYTTKcsfE0CL8h68po2STERRTEIV7XG8tpXyg+EuoyqsZk6VhxsUnTDQQfPaAWodbEHFXK7BgwhxEo1ZqiKJLAkKr9Stp56Dqgb8deJGo/+SZRxTE1q0E6Hz4AwSww6uGw5/twv0eSfDxSA4yS/WGCGjLUmaePjlcoYgt3wOlhBKP2ORmm+eDTZf3uz/Bp3r/hteduPZIXXQ9ofKnh5Uf/c/IdP2qfXbuQqk6yCWhC9M5vmAnZ6UwiOz54xr1MVkmggdboanA1O8bF/NP/1L5SJME2x3dJFGaar2/qyIJCKB9MisWClKJHiQnvy4XSUsjVyQAOnnpW3/eASLltA3JSrx17+cnXXXVpYfSaG1ciHKYz/6kBUAC0a5pfb2hma5zDLE+kRpKzw91Kc/Cfbxl9Xtxh
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6506007)(316002)(31686004)(31696002)(86362001)(186003)(6512007)(83380400001)(36756003)(26005)(38100700002)(6916009)(54906003)(4326008)(8676002)(5660300002)(66476007)(66556008)(66946007)(2906002)(2616005)(508600001)(6486002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q2Fac0xuTUpZL3JvUk5FQWR4Vk9UOE9Yc0xHRWlrRXZmVlppU2w3SVlKaCta?=
 =?utf-8?B?bG9oTkRXaGJLVzlCaEU2WkRnWFBiNlVhZDF6ZGU1Y3VsNjJ6K2NBVFQzQmdB?=
 =?utf-8?B?QURGN1F5ekRGTFhvMGw2SXI3VWwzeVVSMWNFbGNLNklIckV6aFJDV0twSGdx?=
 =?utf-8?B?b0U2TS91SmxMelYxR0VMN0ZYcHY1NXppeW41TGI5SGFxdTBCbTBXS3M5K1c4?=
 =?utf-8?B?b0ZVSFRucTk2c09nQ1d0VHdIWUVLbFdkMnJhSXVSM2NQcEdjeUg4Mkpka1RX?=
 =?utf-8?B?TzhFR0lVMXNib09YWGovZHZ4NmtIdTFQMkF5RzJpS0dvaFRmb1BYLzEvODJM?=
 =?utf-8?B?K2VXNzR5VEl3SEsyTmIxcjBlVzFzSlBDZkt5STM5WHdEUUtJTGs5MjBSU1FG?=
 =?utf-8?B?eDJBM21IZEU5OHNJUTJZeDA0TFhFZmFEQzdsazhXVnZ1R0gxTm8wVkgvREZG?=
 =?utf-8?B?UXl4THIyc1VrTGNvajkyWFdRTlFNc2VwbFJuYm85Qi94Z3ZuRXVndjFEQ09S?=
 =?utf-8?B?T0huM3YxZXdxV1Jhd1IvL29TbFpJK2lTamoxdzI3YzVyNUtzckprdThUeVI3?=
 =?utf-8?B?YWNod0lGUGx3d1FPd0F3cUtXV1Y0bkk1VHRKSGhuVTdGT3RZWGdndUZCZndy?=
 =?utf-8?B?WXFRQzNFUzNxZXM0Nlp3M0hRYjh4YXhCbEtpLzhxelhRTTBpZ3pmUzdkaUtR?=
 =?utf-8?B?YTF3MldnQ2wxVkV3eEJjTUhBYTMyQlFVQzJ6VGs5MUJOUGRUN3huSEludkFO?=
 =?utf-8?B?VmpGbHZ0Uk1URmM2Ly9XQndwUmJpTXNhbHMxS1NGelordEhKNUN2ZUVobi9C?=
 =?utf-8?B?VnZ0UGZUMWpucjlCZTJZbm53Wk0zTHFxQWg1S2NUR0pvZGhnV1VlY0tub0Zm?=
 =?utf-8?B?ZU53R3J3OUZ3Qm1NRFhqTXBMSzl1S3M0bDRhb2M2TlQydnoyTlJ0NlVVUlFZ?=
 =?utf-8?B?UVVPZXNUbFdCSlJCSWZ2VVRXRUhCaExxZHF1K0Y0Q3RFU01NRU9qRmVUNSsv?=
 =?utf-8?B?V1JaZ0NSMW94OEhYRi9SbEgwTlZETVZmWDJuS25oaG5Welkwa2g5TkdYQ2JM?=
 =?utf-8?B?b2RuTjRZRENuM3FzT0dYMHV0L3cxMjVyZ1h1S0JHVzA4VXNJZHQ0V21hWTht?=
 =?utf-8?B?bzRndFZiajV5R2svbVQxRUFVUEJnbE9oVlU5RllpMmxqekRFTlFjeFMyWHBw?=
 =?utf-8?B?eWFVMlphQ0c2dThJeGdqNkJXTlNNeVZseG1QaTZtd1BvYUQxVFkwdUdOVlBZ?=
 =?utf-8?B?b1VaUVJUa1NOaEFaY2dLc0MwTnpGQlZOUFJRRFkrbFhhUWJ5M0lXbDlrcm1R?=
 =?utf-8?B?UXRXWXMreUNuOUFMSEVLKzdLY3pCcjRMSTU0T2FEK0J2Q0YyNDdUMDJpdTdo?=
 =?utf-8?B?MGNyVlJMRjhKaWd6RWZ1VUtQT2tuVlNxalV4QTkwenM0eGZOUVVBU041NVNo?=
 =?utf-8?B?QTl6N002cWgyT0x0S0d0NUV0ZUtOQit1blptOTBodjFab2ZvTndDdUljWWZ6?=
 =?utf-8?B?U3BoNlEyWDdxOXdZRndQYTlHQXMvSW0weHV2U001T3Yyb1dIUDdHcERJT3Qy?=
 =?utf-8?B?VjUrZHJpRGpzMmZFbHhCdEhtYjZhN2hvZVptK0tLMXNPekVtbUhxSnIzMm4z?=
 =?utf-8?B?MjFvWGNLdXNlRTZjZnU5K20zSFpRV2lGaWdWN1JVNnJvK1hRellvMXBiR0do?=
 =?utf-8?B?S1BhYVpGVUgraTdNRXFxOXl6YkpqbHIxNlJTU2xOaldVaVNkT1hpSEszODZL?=
 =?utf-8?B?TjNzS1oraG1DdGl4TDA3WnErbDk5ZWd2Y1NzOWd1a2FWR0diWm40S1o0V1cr?=
 =?utf-8?B?ZlhXUm5OMDhxOGI5U2VydGFSRGNGaU1jWVhUUXdhUHZyemRCQVg0OFU2blJz?=
 =?utf-8?B?NWF2T2p0RFFTek5HYTQzZS9Yd242TmFPV09uSFdpWXNNZG5NekpqS29VaDZz?=
 =?utf-8?B?S0d4L2VoVlQxbXc0L2lOSk9vR2MrQ015L3JkU2UzaFd4TG5HckVMUk9vemNW?=
 =?utf-8?B?L2lwOStINElxVTl5ZEUvc3hZYlVqQmdHWkhQSlErczdWU2UwNWpveFhYNGZ6?=
 =?utf-8?B?KzhPZ1RWZmZVekFzN0FPV1FwemFkUW1uWERiNDVKNDd2Rlc1Q1RuSTQzNUZN?=
 =?utf-8?B?OFRZTkVSNks3RlpyRnJMRzBuTXVTTDBDZStDbDJEanVnZGJXQWNpOXJuQVhh?=
 =?utf-8?B?V0kwZVRVb0lqdUdvWGFaSjdQcFgremhvSFNmQnFGdXNSc1dYNVZUOXFKWnhu?=
 =?utf-8?B?NVByS01BMkRIbVBIYWlTenNSdVh2bjJQWlpHT2ZYK280dmNYN2M5Z0FMbjhE?=
 =?utf-8?B?SFRld2lrdlNVc0hieDBNUkRvZEQzK21FYm1XRDhtNTh2OWhpL01Kdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 884469cf-2f87-42c5-b53b-08da1b825c47
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 06:13:13.5341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QDmOvRy/pa1x6GWXrGgDx1MUyQYawasBri9dFOPfbAQ3fP2rIgSYsjtEPAgnXIRqqA5EeUbAGfllTb+vHcN8Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6028

On 08.04.2022 19:17, Julien Grall wrote:
> On 08/04/2022 13:25, Jan Beulich wrote:
>> On 08.04.2022 13:02, Julien Grall wrote:
>>> On 08/04/2022 08:16, Jan Beulich wrote:
>>>> See the code comment. The higher the rate of vCPU-s migrating across
>>>> pCPU-s, the less useful this attempted optimization actually is. With
>>>> credit2 the migration rate looks to be unduly high even on mostly idle
>>>> systems, and hence on large systems lock contention here isn't very
>>>> difficult to observe.
>>>
>>> "high" and "large" is quite vague. Do you have more details on where you
>>> observed this issue and the improvement after this patch?
>>
>> I have no data beyond the observation on the failed 4.12 osstest flights,
>> where I mentioned I would make such a patch and send out as RFC.
> 
> Ok. I think a pointer to the failed 4.12 osstest would be good here.

Done, albeit personally I don't think that's overly helpful.

>>>> --- a/xen/common/event_channel.c
>>>> +++ b/xen/common/event_channel.c
>>>> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>>>>        unsigned int port;
>>>>        struct evtchn *chn;
>>>>    
>>>> +    /*
>>>> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
>>>> +     * vCPU-s they're to be delivered to run on. In order to limit lock
>>>> +     * contention, check for an empty list prior to acquiring the lock. In the
>>>> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
>>>> +     * until the vCPU is migrated (again) to another pCPU.
>>>> +     */
>>>
>>> AFAIU, the downside is another pCPU (and therefore vCPU) will get
>>> disturbed by the interrupt.
>>
>> But only rarely, i.e. in case a race would actually have occurred.
> 
> Maybe I am too paranoid here. The other side of race is controlled by a 
> domain. So wouldn't it be possible to increase how often the race is hit?

Yes, of course - just to harm itself. The important points are
- that correctness will be maintained, and
- that this is relevant for pass-through guests only (which are
  already not supposed to be entirely untrusted).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 06:15:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 06:15:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302667.516350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnL5-000698-H1; Mon, 11 Apr 2022 06:15:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302667.516350; Mon, 11 Apr 2022 06:15:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnL5-000691-Ce; Mon, 11 Apr 2022 06:15:51 +0000
Received: by outflank-mailman (input) for mailman id 302667;
 Mon, 11 Apr 2022 06:15:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndnL4-00068v-NC
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 06:15:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d408ee8e-b95e-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 08:15:49 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-0EpmkAz-O-OLElXlwJat7w-1; Mon, 11 Apr 2022 08:15:43 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB6028.eurprd04.prod.outlook.com (2603:10a6:10:c1::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 06:15:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 06:15:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d408ee8e-b95e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649657747;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IbcuE8hErk8FPmN2zoC2Xhidq+fToGy3rZu/qu2qBiY=;
	b=KZhv1TE0WJK7rT+bpJJ8JP9Cvu9hsvjAC4HD/k8+7UAqO1jFqpLUzupROU+kJiGPPb8reT
	63FDPufxTppLTTcJnHOD3z5Nh+mLbX5hkKsXmhUHdJLaMipLjHkuiR8/IOjO8Rxza2Nvk0
	5E+rIK09pCG8QuxnFsh19CxCVm6gOCk=
X-MC-Unique: 0EpmkAz-O-OLElXlwJat7w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hiW60APXS7x65nMRimkgTDHLFCR0BIn2sMbP+EGGfvaahgvK9rogF7aeZaYcygJGwMYAAAFsRUkZeBSXCStPQouNszh6OLwrstys2yXFI1r0Hxcmz+JJPNwOFitpZUFb/paeFGL38VkKVrtKvEXZK+ONfap7rP61HUt9HM4UxJLRnWMvAfCnkbvJi5+5g3BXBKe1omh/4v/KxbOhIUh2w2H0wgakq2DCqJrW8mrPx34dxdI+kY8v4nsKWREHETJeyXK9z+QpT9/4jwXDK3DAxfGD7xiHVtUmUfPTNvShV34FanJutYn+DOyBGZhmmO4c3JmdpCJoeeO9GgNdu7qsVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IbcuE8hErk8FPmN2zoC2Xhidq+fToGy3rZu/qu2qBiY=;
 b=n0UgBG1BMtw852P4VfuzIXkR9HRxxH2zatojTcrdkhD9TTee2NigGss92i7JCol2v/i4VkVuqxC/jDKE550hw5wQjj77vUKRfJMc9lsEqKbknuxMYRADEWgS0VR0I8/UOYRCtoYulFn0fGkFF5FeUQw6Pb813USREv4CnGsjR+FADsLbsu2JgZgoShUINUWTLdAK/Riv7GbABiRy9LZEArYAij9rPjH7zQdruSY/A50goRB49g9zn5u/3K6R/Kose2Z6+Zh/6ounciJXPQ2bqRxjwEj6bpfPrSLPTSKERHwl7TEvR2x2qo1ojDsrtOKFPtrYs/0YERXOICe4aQF2nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1be2f46c-700b-6af1-a74a-d090196c9f5f@suse.com>
Date: Mon, 11 Apr 2022 08:15:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Luca Fancellu <Luca.Fancellu@arm.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
 <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com>
 <511b60be-c6c6-d13a-b9aa-40e67e5a1b1c@suse.com>
 <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0015.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: af332d19-f588-4a3f-bd43-08da1b82b49f
X-MS-TrafficTypeDiagnostic: DBBPR04MB6028:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB602817368933F7A3D83EBAC4B3EA9@DBBPR04MB6028.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0v/BM498ddwcT9TdkXUc3q8sGFII5htTVBTwTURhynu8sCX1gqFmz6qUKDy1cdohmUxC/5jGDgJj8EBb66rdUMAlau7hPUl/JZZ0tCPGQGXcsQeZWgrTLOlH5cx4bdKf66fPLoMrgzteseq9A2EuKLwef+QaYbTDjwzueuT5xVIzEb+ghvEDSqrVasD3yFkiBJ6PAAQdU3PxxvM6G4z2q2ZLGyYD/x33jElFYdxIphsei4ohG5zhzdpQ3I0H//OwnPFh3GARmNVlxyDA4SLQgINkYEDv8U7mGx5REce7jZuTM7s4YaP47frUhtE0xYFysTlTyLdMa2skeic0vx+02o2BxhqjK1cgxZRqjiO8H5dL3/ShpdA03ziM0bWOnCGDBY7nwdYbJ0lX3cp/5ntc3Shlyrqnvbh+516ASUNVlQsIV6EwI/1Gwh3rsZ/ZKiNG8gYvO1OjjKapEpPJHhDZWIA9sSikz6FAGK6RV0pYFf4eC+xerkwDsJJhqMrvOIrTQk3sAercEXu+wbtnzTpFGHkcgCwIo6jBdZs8mRS1ArL/LJUuSQjvQr/nIudxNvF00lumvoky3phQ5/ssq4L4UjrJo/X7ukIobvgxzu88Yjdeg05yXNe26S7+Y+exca8G7TJUsjrBJeMI099SQMNsfQ6e3s1gMIvdqPBhVHw5chcw2qUmN0ErM5vNAwYurJtCPrcA0FIRovJFc0iiMy2uji6bOt4CGz1cZYdpkyAKhIxP4x/O7XvlQ5h+plbiidwj
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6506007)(316002)(31686004)(31696002)(86362001)(186003)(6512007)(83380400001)(36756003)(26005)(7416002)(38100700002)(6916009)(54906003)(4326008)(8676002)(5660300002)(66476007)(66556008)(66946007)(2906002)(2616005)(508600001)(6486002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MXVYMVQ1eUorbGxpMzJnOWZtc1ppS3d4aFVtbjNReHVBcjdKSmhiSmZYV1M0?=
 =?utf-8?B?OTVyMmlZZkJqYnUzcGJ5WHRXdTZuc2dpbis5cEZSczQ0SHcwWjM3OEpEcUla?=
 =?utf-8?B?eVAxdENtdWNBTVNMRURORDQ0MUc1cXp2blRhUzc5WS8rR0ZKZTlOMms1VUhs?=
 =?utf-8?B?TEpLbmJ5NFFwTk9QY1hydnV2Ujc5RDVrZUlicnRaaGt1NkI0R1N3MnZuRjhr?=
 =?utf-8?B?bUpVU2p5T3g2dWVPdkF6MThITlc2MTQ3aklmZ2xrMndPdWV3Y29Va3krTTJH?=
 =?utf-8?B?RzBaR2x3V0VKVEFYOE1DeTZBSnUralhLZW8zeTRGSzRuWGw2aWJWMElxaS9u?=
 =?utf-8?B?aHpRM2hhcTMzSVQ4Y08vUEw3RTc2S2JXUkFuSDNMVnJBREdOWlNqaG5zWXMz?=
 =?utf-8?B?QVlqZWViZnpMSHRKSlVvOTJvUjJWM0ZWS0E5YVZFT0EvUkcrZG5SeFBHU2M1?=
 =?utf-8?B?RzYyN2JhK3RtbElGMDkzbW1WUi9ObzdaeG1aSTY2S2xZMVNyZ2V6c1FpcGl6?=
 =?utf-8?B?VjNPcG9HREo4d1BOcGo2UnZNbE8vMzJIRjNoa08wRzg5WHNqQm1pUVhTNU1j?=
 =?utf-8?B?U3MxUEhjeFgzZmp2MWw1OW5RN0NlQitqRXNwQWg0MFdHWjZ2OWtlV2wvRmVE?=
 =?utf-8?B?TTkwV2YzdDFNRjhBNUg5VnpCZFJrbVV0TVhESThlQ0NaalZzcjR3S3d1Tk1Y?=
 =?utf-8?B?RWNLSlpUQjFSazM0RzVDUjc2Smh1YStaQ2lmSEsvVWFCY1NwMUhDTDFjM0ts?=
 =?utf-8?B?MkVuUXRrU1R2cGZpUjRnZkg3L2pXTVBDOERjVU15UUpKK1FVaW9ORGhSUnRO?=
 =?utf-8?B?RFFxdUw1bmd1cEQ2ZE9MQUVLZEZDYVZZU2xCcXZFWEJmaWc3bzFUdlhDNXd1?=
 =?utf-8?B?VEFCWVlHc09CczNVT0RjUlJHa2IvTWVMNVdaSlJxdTZ1V0UyeUN4RHA4RjBH?=
 =?utf-8?B?L3FBTm5ubURHNnRvbVJuSU9vVitoSHZ5dWFoRWVWMU9zUlRyZDNBZG9mNGlZ?=
 =?utf-8?B?OHRFVGxJSVc0VmtEYXFKZTBxcWY1WEVwbGRGbkVCUktrejFhNzdVaDhMdVBp?=
 =?utf-8?B?V1RLYmk5RzRpajlFWkpHVXBtWDdnTzhxWk9jVzhmNEhvUHVvdW8wL3YzbFNW?=
 =?utf-8?B?akpFUzhXWjRxRjMyRkJ3VVp6TnFDQ1FURS9Dc3NYU3dlNkxxN01aODUzSUVQ?=
 =?utf-8?B?ZFFKelZYZjJRdU4wc05SMEswRTRvN2dydExHLzk3ZUpzWVVmYStQOSsrRi9i?=
 =?utf-8?B?d0JqSC9McTdKVE1OVHlaK1hlcjF6VmVCMDhnUzN6Z2xMeHhpK0Uzd2ZiM3Ar?=
 =?utf-8?B?SmNtV290NFhIdmZWUTRDcVIrTFdEenBRZEZVWVNmTm9SL3A5d0VEc09GeCtY?=
 =?utf-8?B?K2NFRmxLRDVqMURKb1h4Q2Q2aWtxc3hUMjJwUlgyNlR6aVFFQnJTdWE1c0J3?=
 =?utf-8?B?dU5nRk1ocTJpZmNVd282VGlQcWhrNnE5bGp5ZHZSVnY4c09qTjh6K3dnZi96?=
 =?utf-8?B?dkZ3VmxoMk9qbmQvbEdLYmFKV2ZCUGJLdGZNV1dFRGtSb01vbCt4TkcxN1lj?=
 =?utf-8?B?MEI2ZmRuNEdvOXdBSkd6YzdUOGRpRndWNmdVSkJ4SzZnQjM3b0FnL0VWaUw0?=
 =?utf-8?B?WXRDT200TVFQRVY5UUJZOUtBZUJKUkpoMjczWGpnem5TNHl0YnZaK21BeU8w?=
 =?utf-8?B?Umd5MXhndGpieFJYSWpNd0dKZEdLTmpRdllxcXJocStzcy9ia1ZROHhTdEYy?=
 =?utf-8?B?SUVKL1g0cWdyVk5aUk9tM0NSWEowQWNaU1U0dWpQampPSWszZmxha0RuRmRO?=
 =?utf-8?B?WjZSRjk0YWRrbEVRdDA4SHVuL0JPUGVNeVJFaEtPZkFmMFZOYUFoSWIwVGhx?=
 =?utf-8?B?RlZBZ3JlMDhqTnJpYmhqSUIzYTRKMlE4bXlwK1NzUlZOK1E5VitiM241bTdt?=
 =?utf-8?B?YlZxTDUzMWRicnhtelpiOEhPT2hMYWdBSmFZUmdBY25LbndMelMvSXlkeXJP?=
 =?utf-8?B?RGxaQ2o5UEEwdnNGbG9CYnVCak1JNm85UE1qekNJREVXVHFUSGI2dmpZcVI4?=
 =?utf-8?B?R3ptSmhNVlY2UDMrTk9rVDMvWTh4MUJVN2ZrZlVSTEMrNDRWSi85Z2NWTGNT?=
 =?utf-8?B?bFc0UlBDekhBVzIyYUhtUGppVCtEQ1dXbzFYcDJMSnJhZHhMcXdFdG5GUjRl?=
 =?utf-8?B?bGprWmJiaFNoTkNJVzBlU2xGS3BZQ3lPSVhFU1RCNHplajVXbWYvdGdsaVZy?=
 =?utf-8?B?eGFZMzVKYzIrR2tXbmlzdUcxamw1NVdCS1BRVGhwYVBvQlB2MGd2VHNRSE1i?=
 =?utf-8?B?NWRNSHljdGhYMU10Q3M3TktVUGhXdnFjNlhHSWFqQWJXV2VBckRwdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af332d19-f588-4a3f-bd43-08da1b82b49f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 06:15:41.7662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2SRdU2or/dnCwDmDC4fFmzwD24HN5rnre2cQ/l2tz2PJ6FZPHkQFzwz19EQ14M6FporTcKgh7cX7EAbqt06DiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6028

On 08.04.2022 22:25, Stefano Stabellini wrote:
> On Fri, 8 Apr 2022, Jan Beulich wrote:
>> On 08.04.2022 13:37, Luca Fancellu wrote:
>>>
>>>
>>>> On 8 Apr 2022, at 10:01, Jan Beulich <jbeulich@suse.com> wrote:
>>>>
>>>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>>>> ---
>>>>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>>>>> xen/arch/arm/include/asm/smp.h         |   3 +
>>>>> xen/common/Kconfig                     |   7 +
>>>>> xen/common/Makefile                    |   1 +
>>>>> xen/common/boot_cpupools.c             | 207 +++++++++++++++++++++++++
>>>>> xen/common/sched/cpupool.c             |  12 +-
>>>>> xen/include/xen/sched.h                |  14 ++
>>>>> 7 files changed, 383 insertions(+), 1 deletion(-)
>>>>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>>>>> create mode 100644 xen/common/boot_cpupools.c
>>>>
>>>> Under whose maintainership is the new file to fall? Without an
>>>> addition to ./MAINTAINERS and without the file being placed in
>>>> xen/common/sched/, it'll be REST maintainers, which I think would
>>>> better be avoided. Would it perhaps make sense to have this as
>>>> xen/common/sched/boot.c, allowing other boot-only code to
>>>> potentially be moved there over time? This would then also avoid
>>>> me asking about the underscore in the file name: Underscores are
>>>> a somewhat artificial thing for use in places where dashes can't
>>>> be used. Yet in the file system dashes are fine, and dashes are
>>>> (slightly) easier to type.
>>>>
>>>
>>> Ok I can put the new file under xen/common/sched/ as boot.c, should this new
>>> file be under this section?
>>>
>>> CPU POOLS
>>> M:  Juergen Gross <jgross@suse.com>
>>> M:  Dario Faggioli <dfaggioli@suse.com>
>>> S:  Supported
>>> F:  xen/common/sched/cpupool.c
>>> + F:  xen/common/sched/boot.c
>>
>> If it's to hold general scheduler code (which this shorter name would
>> suggest), it shouldn't need any change to ./MAINTAINERS as the
>> scheduler section would already cover it then. If it was to remain
>> CPU-pools-specific, then you'd need to stick to the longer name and
>> put it in the section you have reproduced above.
> 
> In my opinion it is best if the maintenance of boot_cpupools.c falls
> under "CPU POOLS". Luca, you can retain my reviewed-by when you add
> the change to MAINTAINERS or rename the file.

Yet even then, with cpupools.c living in sched/, ...

> I don't have an opinion if it should be called
> xen/common/boot_cpupools.c or xen/common/boot-cpupools.c
> 

... this one may want living there are well.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 06:24:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 06:24:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302673.516361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnTj-0007xR-GM; Mon, 11 Apr 2022 06:24:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302673.516361; Mon, 11 Apr 2022 06:24:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnTj-0007xK-DK; Mon, 11 Apr 2022 06:24:47 +0000
Received: by outflank-mailman (input) for mailman id 302673;
 Mon, 11 Apr 2022 06:24:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3hqm=UV=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ndnTh-0007xE-UJ
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 06:24:45 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 135ecdbf-b960-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 08:24:44 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 06940ED1;
 Sun, 10 Apr 2022 23:24:43 -0700 (PDT)
Received: from [10.57.8.177] (unknown [10.57.8.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5719F3F70D;
 Sun, 10 Apr 2022 23:24:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 135ecdbf-b960-11ec-8fbc-03012f2f19d4
Message-ID: <62e62ea5-0286-7e34-efab-66f0e51afeda@arm.com>
Date: Mon, 11 Apr 2022 08:24:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V4 2/2] xen/arm: Add i.MX lpuart early printk support
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220408140932.17968-1-peng.fan@oss.nxp.com>
 <20220408140932.17968-3-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220408140932.17968-3-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Peng,

On 08.04.2022 16:09, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  xen/arch/arm/Kconfig.debug              | 14 +++++++
>  xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 +++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
>  create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
> 
> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
> index 35ccd13273..842d768280 100644
> --- a/xen/arch/arm/Kconfig.debug
> +++ b/xen/arch/arm/Kconfig.debug
> @@ -58,6 +58,16 @@ choice
>  			This option is preferred over the platform specific
>  			options; the platform specific options are deprecated
>  			and will soon be removed.
> +	config EARLY_UART_CHOICE_IMX_LPUART
> +		select EARLY_UART_IMX_LPUART
> +		depends on ARM_64
> +		bool "Early printk via i.MX LPUART"
> +		help
> +			Say Y here if you wish the early printk to direct their
> +			output to a i.MX LPUART. You can use this option to
> +			provide the parameters for the i.MX LPUART rather than
> +			selecting one of the platform specific options below if
> +			you know the parameters for the port.
>  	config EARLY_UART_CHOICE_MESON
>  		select EARLY_UART_MESON
>  		depends on ARM_64
> @@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
>  config EARLY_UART_EXYNOS4210
>  	select EARLY_PRINTK
>  	bool
> +config EARLY_UART_IMX_LPUART
> +	select EARLY_PRINTK
> +	bool
>  config EARLY_UART_MESON
>  	select EARLY_PRINTK
>  	bool
> @@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
>  	default "debug-8250.inc" if EARLY_UART_8250
>  	default "debug-cadence.inc" if EARLY_UART_CADENCE
>  	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
> +	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
>  	default "debug-meson.inc" if EARLY_UART_MESON
>  	default "debug-mvebu.inc" if EARLY_UART_MVEBU
>  	default "debug-pl011.inc" if EARLY_UART_PL011
> diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
> new file mode 100644
> index 0000000000..f68252da86
> --- /dev/null
> +++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
> @@ -0,0 +1,52 @@
> +/*
> + * xen/arch/arm/arm64/debug-imx-lpuart.inc
> + *
> + * i.MX8QM specific debug code
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <asm/imx-lpuart.h>
> +
> +.macro early_uart_init wb wc wd
> +/* Already initialized in bootloader */
> +.endm
> +
FWICS, early_uart_init call is protected with CONFIG_EARLY_UART_INIT that is set
only for PL011 UART. So I think there is no need to implement this empty macro,
unless we want to keep the same macros across the files no matter whether in use or not.
I think you need to ask Julien.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 06:26:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 06:26:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302677.516372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnV7-00006g-Rd; Mon, 11 Apr 2022 06:26:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302677.516372; Mon, 11 Apr 2022 06:26:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnV7-00006Z-OZ; Mon, 11 Apr 2022 06:26:13 +0000
Received: by outflank-mailman (input) for mailman id 302677;
 Mon, 11 Apr 2022 06:26:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3hqm=UV=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ndnV6-00006R-5f
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 06:26:12 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 477c9e08-b960-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 08:26:11 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7FABBED1;
 Sun, 10 Apr 2022 23:26:10 -0700 (PDT)
Received: from [10.57.8.177] (unknown [10.57.8.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D80A3F70D;
 Sun, 10 Apr 2022 23:26:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 477c9e08-b960-11ec-8fbc-03012f2f19d4
Message-ID: <d164f7a7-a219-63ad-580d-ead86ea79103@arm.com>
Date: Mon, 11 Apr 2022 08:26:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V4 1/2] xen/arm: Add i.MX lpuart driver
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>, Henry Wang <Henry.Wang@arm.com>
References: <20220408140932.17968-1-peng.fan@oss.nxp.com>
 <20220408140932.17968-2-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220408140932.17968-2-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Peng,

On 08.04.2022 16:09, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The i.MX LPUART Documentation:
> https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
> Chatper 13.6 Low Power Universal Asynchronous Receiver/
> Transmitter (LPUART)
> 
> Tested-by: Henry Wang <Henry.Wang@arm.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
>  xen/drivers/char/Kconfig              |   7 +
>  xen/drivers/char/Makefile             |   1 +
>  xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
>  4 files changed, 348 insertions(+)
>  create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
>  create mode 100644 xen/drivers/char/imx-lpuart.c
> 
> diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
> new file mode 100644
> index 0000000000..26e2cf0249
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/imx-lpuart.h
> @@ -0,0 +1,64 @@
> +/*
> + * xen/arch/arm/include/asm/imx-lpuart.h
> + *
> + * Common constant definition between early printk and the LPUART driver
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ASM_ARM_IMX_LPUART_H__
> +#define __ASM_ARM_IMX_LPUART_H__
> +
> +/* 32-bit register definition */
> +#define UARTBAUD          (0x10)
> +#define UARTSTAT          (0x14)
> +#define UARTCTRL          (0x18)
> +#define UARTDATA          (0x1C)
> +#define UARTMATCH         (0x20)
> +#define UARTMODIR         (0x24)
> +#define UARTFIFO          (0x28)
> +#define UARTWATER         (0x2c)
> +
> +#define UARTSTAT_TDRE     BIT(23, UL)
> +#define UARTSTAT_TC       BIT(22, UL)
> +#define UARTSTAT_RDRF     BIT(21, UL)
> +#define UARTSTAT_OR       BIT(19, UL)
> +
> +#define UARTBAUD_OSR_SHIFT (24)
> +#define UARTBAUD_OSR_MASK (0x1f)
> +#define UARTBAUD_SBR_MASK (0x1fff)
> +#define UARTBAUD_BOTHEDGE (0x00020000)
> +#define UARTBAUD_TDMAE    (0x00800000)
> +#define UARTBAUD_RDMAE    (0x00200000)It seems like you missed my comment about alignment from the previous patch version.
Please keep the same alignment of values within the same section.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 06:29:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 06:29:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302687.516383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnYZ-000143-Bk; Mon, 11 Apr 2022 06:29:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302687.516383; Mon, 11 Apr 2022 06:29:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndnYZ-00013w-8r; Mon, 11 Apr 2022 06:29:47 +0000
Received: by outflank-mailman (input) for mailman id 302687;
 Mon, 11 Apr 2022 06:29:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3hqm=UV=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ndnYY-00013q-UW
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 06:29:46 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id c76a47dc-b960-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 08:29:45 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B702ED1;
 Sun, 10 Apr 2022 23:29:45 -0700 (PDT)
Received: from [10.57.8.177] (unknown [10.57.8.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F72B3F70D;
 Sun, 10 Apr 2022 23:29:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c76a47dc-b960-11ec-8fbc-03012f2f19d4
Message-ID: <0a790014-a6c1-1012-664c-a7ae742ec82e@arm.com>
Date: Mon, 11 Apr 2022 08:29:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros
Content-Language: en-US
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220405091616.200270-1-michal.orzel@arm.com>
 <20220405091616.200270-3-michal.orzel@arm.com>
 <3c5a736d-3c38-a975-62d9-7c5623d89728@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <3c5a736d-3c38-a975-62d9-7c5623d89728@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Julien,

On 08.04.2022 19:58, Julien Grall wrote:
> Hi Michal,
> 
> On 05/04/2022 10:16, Michal Orzel wrote:
>>   #if defined(BUILD_ID)
>> @@ -109,12 +104,7 @@ SECTIONS
>>          *(.data.schedulers)
>>          __end_schedulers_array = .;
>>   -#ifdef CONFIG_HYPFS
>> -       . = ALIGN(8);
> 
> This will be replaced with POINTER_ALIGN which is 4-byte on Arm32. AFAICT, there are no 64-bit value used in struct param_hypfs. So it should be fine.
> 
> That said, I think this is worth mentioning in the commit message.
> 
> The rest of this patch looks good to me.
> 
> Cheers,
> 
Ok, I will update the commit and repush the series.

Thanks,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 07:03:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 07:03:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302692.516394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndo4t-00064A-W2; Mon, 11 Apr 2022 07:03:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302692.516394; Mon, 11 Apr 2022 07:03:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndo4t-000643-Si; Mon, 11 Apr 2022 07:03:11 +0000
Received: by outflank-mailman (input) for mailman id 302692;
 Mon, 11 Apr 2022 07:03:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3hqm=UV=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ndo4s-00063x-Re
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 07:03:10 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 7181cc25-b965-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 09:03:09 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C4F11FB;
 Mon, 11 Apr 2022 00:03:08 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.8.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3286F3F73B;
 Mon, 11 Apr 2022 00:03:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7181cc25-b965-11ec-8fbc-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v5 0/2] xen: Linker scripts synchronization
Date: Mon, 11 Apr 2022 09:02:58 +0200
Message-Id: <20220411070300.77380-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series aims to do the first step towards linker scripts
synchronization. Linker scripts for arm and x86 share a lot of common
sections and in order to make the process of changing/improving/syncing
them, these sections shall be defined in just one place.

The first patch creates an empty header file xen.lds.h to store the
constructs mutual to both x86 and arm linker scripts. It also includes
this header in the scripts.

The second patch populates xen.lds.h with the first portion of common
macros and replaces the original contructs with these helpers.

Michal Orzel (2):
  xen: Introduce a header to store common linker scripts content
  xen: Populate xen.lds.h and make use of its macros

 xen/arch/arm/xen.lds.S    |  45 +++----------
 xen/arch/x86/xen.lds.S    |  97 +++------------------------
 xen/include/xen/xen.lds.h | 137 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 157 insertions(+), 122 deletions(-)
 create mode 100644 xen/include/xen/xen.lds.h

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 07:03:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 07:03:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302694.516416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndo50-0006bO-G8; Mon, 11 Apr 2022 07:03:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302694.516416; Mon, 11 Apr 2022 07:03:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndo50-0006bH-CA; Mon, 11 Apr 2022 07:03:18 +0000
Received: by outflank-mailman (input) for mailman id 302694;
 Mon, 11 Apr 2022 07:03:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3hqm=UV=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ndo4y-00063x-JF
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 07:03:16 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 752c16ab-b965-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 09:03:15 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D9921FB;
 Mon, 11 Apr 2022 00:03:14 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.8.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC2A63F73B;
 Mon, 11 Apr 2022 00:03:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 752c16ab-b965-11ec-8fbc-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v5 2/2] xen: Populate xen.lds.h and make use of its macros
Date: Mon, 11 Apr 2022 09:03:00 +0200
Message-Id: <20220411070300.77380-3-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220411070300.77380-1-michal.orzel@arm.com>
References: <20220411070300.77380-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Populate header file xen.lds.h with the first portion of macros storing
constructs common to x86 and arm linker scripts. Replace the original
constructs with these helpers.

No functional improvements to x86 linker script.

Making use of common macros improves arm linker script with:
- explicit list of debug sections that otherwise are seen as "orphans"
  by the linker. This will allow to fix issues after enabling linker
  option --orphan-handling one day,
- extended list of discarded section to include: .discard, destructors
  related sections, .fini_array which can reference .text.exit,
- sections not related to debugging that are placed by ld.lld. Even
  though we do not support linking with LLD on Arm, these sections do
  not cause problem to GNU ld,

As we are replacing hardcoded boundary specified as an argument to ALIGN
function with POINTER_ALIGN, this changes the alignment in HYPFS_PARAM
construct for arm32 from 8 to 4. It is fine as there are no 64bit values
used in struct param_hypfs.

Please note that this patch does not aim to perform the full sync up
between the linker scripts. It creates a base for further work.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
Changes since v4:
-update commit msg with a note about changed alignment for HYPFS_PARAM on arm32
Changes since v3:
-use POINTER_ALIGN in debug sections when needed
-modify comment about ELF_DETAILS_SECTIONS
Changes since v2:
-refactor commit msg
-move constructs together with surrounding ifdefery
-list constructs other than *_SECTIONS in alphabetical order
-add comment about EFI vs EFI support
Changes since v1:
-merge x86 and arm changes into single patch
-do not propagate issues by generalizing CTORS
-extract sections not related to debugging into separate macro
-get rid of _SECTION suffix in favor of using more meaningful suffixes
---
 xen/arch/arm/xen.lds.S    |  44 +++----------
 xen/arch/x86/xen.lds.S    |  96 +++-------------------------
 xen/include/xen/xen.lds.h | 129 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 147 insertions(+), 122 deletions(-)

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index d20e5e94e4..1e986e211f 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -69,12 +69,7 @@ SECTIONS
        *(.proc.info)
        __proc_info_end = .;
 
-#ifdef CONFIG_HAS_VPCI
-       . = ALIGN(POINTER_ALIGN);
-       __start_vpci_array = .;
-       *(SORT(.data.vpci.*))
-       __end_vpci_array = .;
-#endif
+       VPCI_ARRAY
   } :text
 
 #if defined(BUILD_ID)
@@ -110,12 +105,7 @@ SECTIONS
        *(.data.schedulers)
        __end_schedulers_array = .;
 
-#ifdef CONFIG_HYPFS
-       . = ALIGN(8);
-       __paramhypfs_start = .;
-       *(.data.paramhypfs)
-       __paramhypfs_end = .;
-#endif
+       HYPFS_PARAM
 
        *(.data .data.*)
        CONSTRUCTORS
@@ -179,12 +169,7 @@ SECTIONS
        *(.altinstructions)
        __alt_instructions_end = .;
 
-#ifdef CONFIG_DEBUG_LOCK_PROFILE
-       . = ALIGN(POINTER_ALIGN);
-       __lock_profile_start = .;
-       *(.lockprofile.data)
-       __lock_profile_end = .;
-#endif
+       LOCK_PROFILE_DATA
 
        *(.init.data)
        *(.init.data.rel)
@@ -223,22 +208,13 @@ SECTIONS
   /* Section for the device tree blob (if any). */
   .dtb : { *(.dtb) } :text
 
-  /* Sections to be discarded */
-  /DISCARD/ : {
-       *(.exit.text)
-       *(.exit.data)
-       *(.exitcall.exit)
-       *(.eh_frame)
-  }
-
-  /* Stabs debugging sections.  */
-  .stab 0 : { *(.stab) }
-  .stabstr 0 : { *(.stabstr) }
-  .stab.excl 0 : { *(.stab.excl) }
-  .stab.exclstr 0 : { *(.stab.exclstr) }
-  .stab.index 0 : { *(.stab.index) }
-  .stab.indexstr 0 : { *(.stab.indexstr) }
-  .comment 0 : { *(.comment) }
+  DWARF2_DEBUG_SECTIONS
+
+  DISCARD_SECTIONS
+
+  STABS_DEBUG_SECTIONS
+
+  ELF_DETAILS_SECTIONS
 }
 
 /*
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 1fcd8ab7c5..68501c7186 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -14,13 +14,6 @@
 #undef __XEN_VIRT_START
 #define __XEN_VIRT_START __image_base__
 #define DECL_SECTION(x) x :
-/*
- * Use the NOLOAD directive, despite currently ignored by (at least) GNU ld
- * for PE output, in order to record that we'd prefer these sections to not
- * be loaded into memory.
- */
-#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) }
-#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) }
 
 ENTRY(efi_start)
 
@@ -28,8 +21,6 @@ ENTRY(efi_start)
 
 #define FORMAT "elf64-x86-64"
 #define DECL_SECTION(x) #x : AT(ADDR(#x) - __XEN_VIRT_START)
-#define DECL_DEBUG(x, a) #x 0 : { *(x) }
-#define DECL_DEBUG2(x, y, a) #x 0 : { *(x) *(y) }
 
 ENTRY(start_pa)
 
@@ -160,12 +151,7 @@ SECTIONS
        *(.note.gnu.build-id)
        __note_gnu_build_id_end = .;
 #endif
-#ifdef CONFIG_HAS_VPCI
-       . = ALIGN(POINTER_ALIGN);
-       __start_vpci_array = .;
-       *(SORT(.data.vpci.*))
-       __end_vpci_array = .;
-#endif
+       VPCI_ARRAY
   } PHDR(text)
 
 #if defined(CONFIG_PVH_GUEST) && !defined(EFI)
@@ -279,12 +265,7 @@ SECTIONS
         *(.altinstructions)
         __alt_instructions_end = .;
 
-#ifdef CONFIG_DEBUG_LOCK_PROFILE
-       . = ALIGN(POINTER_ALIGN);
-       __lock_profile_start = .;
-       *(.lockprofile.data)
-       __lock_profile_end = .;
-#endif
+       LOCK_PROFILE_DATA
 
        . = ALIGN(8);
        __ctors_start = .;
@@ -336,12 +317,7 @@ SECTIONS
        *(.data.schedulers)
        __end_schedulers_array = .;
 
-#ifdef CONFIG_HYPFS
-       . = ALIGN(8);
-       __paramhypfs_start = .;
-       *(.data.paramhypfs)
-       __paramhypfs_end = .;
-#endif
+       HYPFS_PARAM
   } PHDR(text)
 
   DECL_SECTION(.data) {
@@ -388,33 +364,7 @@ SECTIONS
   efi = .;
 #endif
 
-  /*
-   * Explicitly list debug sections, first of all to avoid these sections being
-   * viewed as "orphan" by the linker.
-   *
-   * For the PE output this is further necessary so that they don't end up at
-   * VA 0, which is below image base and thus invalid.  Note that we're past
-   * _end here, so if these sections get loaded they'll be discarded at runtime
-   * anyway.
-   */
-  DECL_DEBUG(.debug_abbrev, 1)
-  DECL_DEBUG2(.debug_info, .gnu.linkonce.wi.*, 1)
-  DECL_DEBUG(.debug_types, 1)
-  DECL_DEBUG(.debug_str, 1)
-  DECL_DEBUG2(.debug_line, .debug_line.*, 1)
-  DECL_DEBUG(.debug_line_str, 1)
-  DECL_DEBUG(.debug_names, 4)
-  DECL_DEBUG(.debug_frame, 4)
-  DECL_DEBUG(.debug_loc, 1)
-  DECL_DEBUG(.debug_loclists, 4)
-  DECL_DEBUG(.debug_macinfo, 1)
-  DECL_DEBUG(.debug_macro, 1)
-  DECL_DEBUG(.debug_ranges, 8)
-  DECL_DEBUG(.debug_rnglists, 4)
-  DECL_DEBUG(.debug_addr, 8)
-  DECL_DEBUG(.debug_aranges, 1)
-  DECL_DEBUG(.debug_pubnames, 1)
-  DECL_DEBUG(.debug_pubtypes, 1)
+  DWARF2_DEBUG_SECTIONS
 
 #ifdef EFI
   /* Trick the linker into setting the image size to no less than 16Mb. */
@@ -428,42 +378,12 @@ SECTIONS
   hv_hcall_page = ABSOLUTE(HV_HCALL_PAGE - XEN_VIRT_START + __XEN_VIRT_START);
 #endif
 
-  /* Sections to be discarded */
-  /DISCARD/ : {
-       *(.text.exit)
-       *(.exit.text)
-       *(.exit.data)
-       *(.exitcall.exit)
-       *(.discard)
-       *(.discard.*)
-       *(.eh_frame)
-       *(.dtors)
-       *(.dtors.*)
-       *(.fini_array)
-       *(.fini_array.*)
-#ifdef EFI
-       *(.comment)
-       *(.comment.*)
-       *(.note.*)
-#endif
-  }
+  DISCARD_SECTIONS
 
 #ifndef EFI
-  /* Stabs debugging sections.  */
-  .stab 0 : { *(.stab) }
-  .stabstr 0 : { *(.stabstr) }
-  .stab.excl 0 : { *(.stab.excl) }
-  .stab.exclstr 0 : { *(.stab.exclstr) }
-  .stab.index 0 : { *(.stab.index) }
-  .stab.indexstr 0 : { *(.stab.indexstr) }
-  .comment 0 : { *(.comment) *(.comment.*) }
-  /*
-   * LLVM ld also wants .symtab, .strtab, and .shstrtab placed. These look to
-   * be benign to GNU ld, so we can have them here unconditionally.
-   */
-  .symtab 0 : { *(.symtab) }
-  .strtab 0 : { *(.strtab) }
-  .shstrtab 0 : { *(.shstrtab) }
+  STABS_DEBUG_SECTIONS
+
+  ELF_DETAILS_SECTIONS
 #endif
 }
 
diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h
index dd292fa7dc..fc47bb1ccc 100644
--- a/xen/include/xen/xen.lds.h
+++ b/xen/include/xen/xen.lds.h
@@ -5,4 +5,133 @@
  * Common macros to be used in architecture specific linker scripts.
  */
 
+/*
+ * To avoid any confusion, please note that the EFI macro does not correspond
+ * to EFI support and is used when linking a native EFI (i.e. PE/COFF) binary,
+ * hence its usage in this header.
+ */
+
+/* Macros to declare debug sections. */
+#ifdef EFI
+/*
+ * Use the NOLOAD directive, despite currently ignored by (at least) GNU ld
+ * for PE output, in order to record that we'd prefer these sections to not
+ * be loaded into memory.
+ */
+#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) }
+#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) }
+#else
+#define DECL_DEBUG(x, a) #x 0 : { *(x) }
+#define DECL_DEBUG2(x, y, a) #x 0 : { *(x) *(y) }
+#endif
+
+/*
+ * DWARF2+ debug sections.
+ * Explicitly list debug sections, first of all to avoid these sections being
+ * viewed as "orphan" by the linker.
+ *
+ * For the PE output this is further necessary so that they don't end up at
+ * VA 0, which is below image base and thus invalid. Note that this macro is
+ * to be used after _end, so if these sections get loaded they'll be discarded
+ * at runtime anyway.
+ */
+#define DWARF2_DEBUG_SECTIONS                     \
+  DECL_DEBUG(.debug_abbrev, 1)                    \
+  DECL_DEBUG2(.debug_info, .gnu.linkonce.wi.*, 1) \
+  DECL_DEBUG(.debug_types, 1)                     \
+  DECL_DEBUG(.debug_str, 1)                       \
+  DECL_DEBUG2(.debug_line, .debug_line.*, 1)      \
+  DECL_DEBUG(.debug_line_str, 1)                  \
+  DECL_DEBUG(.debug_names, 4)                     \
+  DECL_DEBUG(.debug_frame, 4)                     \
+  DECL_DEBUG(.debug_loc, 1)                       \
+  DECL_DEBUG(.debug_loclists, 4)                  \
+  DECL_DEBUG(.debug_macinfo, 1)                   \
+  DECL_DEBUG(.debug_macro, 1)                     \
+  DECL_DEBUG(.debug_ranges, POINTER_ALIGN)        \
+  DECL_DEBUG(.debug_rnglists, 4)                  \
+  DECL_DEBUG(.debug_addr, POINTER_ALIGN)          \
+  DECL_DEBUG(.debug_aranges, 1)                   \
+  DECL_DEBUG(.debug_pubnames, 1)                  \
+  DECL_DEBUG(.debug_pubtypes, 1)
+
+/* Stabs debug sections. */
+#define STABS_DEBUG_SECTIONS                 \
+  .stab 0 : { *(.stab) }                     \
+  .stabstr 0 : { *(.stabstr) }               \
+  .stab.excl 0 : { *(.stab.excl) }           \
+  .stab.exclstr 0 : { *(.stab.exclstr) }     \
+  .stab.index 0 : { *(.stab.index) }         \
+  .stab.indexstr 0 : { *(.stab.indexstr) }
+
+/*
+ * ELF sections.
+ *
+ * LLVM ld also wants .symtab, .strtab, and .shstrtab placed. These look to
+ * be benign to GNU ld, so we can have them here unconditionally.
+ */
+#define ELF_DETAILS_SECTIONS                 \
+  .comment 0 : { *(.comment) *(.comment.*) } \
+  .symtab 0 : { *(.symtab) }                 \
+  .strtab 0 : { *(.strtab) }                 \
+  .shstrtab 0 : { *(.shstrtab) }
+
+#ifdef EFI
+#define DISCARD_EFI_SECTIONS \
+       *(.comment)   \
+       *(.comment.*) \
+       *(.note.*)
+#else
+#define DISCARD_EFI_SECTIONS
+#endif
+
+/* Sections to be discarded. */
+#define DISCARD_SECTIONS     \
+  /DISCARD/ : {              \
+       *(.text.exit)         \
+       *(.exit.text)         \
+       *(.exit.data)         \
+       *(.exitcall.exit)     \
+       *(.discard)           \
+       *(.discard.*)         \
+       *(.eh_frame)          \
+       *(.dtors)             \
+       *(.dtors.*)           \
+       *(.fini_array)        \
+       *(.fini_array.*)      \
+       DISCARD_EFI_SECTIONS  \
+  }
+
+/* List of constructs other than *_SECTIONS in alphabetical order. */
+
+#ifdef CONFIG_HYPFS
+#define HYPFS_PARAM              \
+       . = ALIGN(POINTER_ALIGN); \
+       __paramhypfs_start = .;   \
+       *(.data.paramhypfs)       \
+       __paramhypfs_end = .;
+#else
+#define HYPFS_PARAM
+#endif
+
+#ifdef CONFIG_DEBUG_LOCK_PROFILE
+#define LOCK_PROFILE_DATA        \
+       . = ALIGN(POINTER_ALIGN); \
+       __lock_profile_start = .; \
+       *(.lockprofile.data)      \
+       __lock_profile_end = .;
+#else
+#define LOCK_PROFILE_DATA
+#endif
+
+#ifdef CONFIG_HAS_VPCI
+#define VPCI_ARRAY               \
+       . = ALIGN(POINTER_ALIGN); \
+       __start_vpci_array = .;   \
+       *(SORT(.data.vpci.*))     \
+       __end_vpci_array = .;
+#else
+#define VPCI_ARRAY
+#endif
+
 #endif /* __XEN_LDS_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 07:03:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 07:03:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302693.516405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndo4w-0006K4-7h; Mon, 11 Apr 2022 07:03:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302693.516405; Mon, 11 Apr 2022 07:03:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndo4w-0006Jx-4C; Mon, 11 Apr 2022 07:03:14 +0000
Received: by outflank-mailman (input) for mailman id 302693;
 Mon, 11 Apr 2022 07:03:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3hqm=UV=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ndo4u-00063x-Ud
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 07:03:12 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 73509227-b965-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 09:03:12 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 897391FB;
 Mon, 11 Apr 2022 00:03:11 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.8.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DB4BC3F73B;
 Mon, 11 Apr 2022 00:03:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73509227-b965-11ec-8fbc-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v5 1/2] xen: Introduce a header to store common linker scripts content
Date: Mon, 11 Apr 2022 09:02:59 +0200
Message-Id: <20220411070300.77380-2-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220411070300.77380-1-michal.orzel@arm.com>
References: <20220411070300.77380-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Both x86 and arm linker scripts share quite a lot of common content.
It is difficult to keep syncing them up, thus introduce a new header
in include/xen called xen.lds.h to store the internals mutual to all
the linker scripts.

Include this header in linker scripts for x86 and arm.
This patch serves as an intermediate step before populating xen.lds.h
and making use of its content in the linker scripts later on.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
Changes since v4:
-rebased
Changes since v2,v3:
-none
Changes since v1:
-rename header to xen.lds.h to be coherent with Linux kernel
-include empty header in linker scripts
---
 xen/arch/arm/xen.lds.S    | 1 +
 xen/arch/x86/xen.lds.S    | 1 +
 xen/include/xen/xen.lds.h | 8 ++++++++
 3 files changed, 10 insertions(+)
 create mode 100644 xen/include/xen/xen.lds.h

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index ad7f966f0e..d20e5e94e4 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -4,6 +4,7 @@
 
 #include <xen/cache.h>
 #include <xen/lib.h>
+#include <xen/xen.lds.h>
 #include <asm/page.h>
 #undef ENTRY
 #undef ALIGN
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 6926e88e54..1fcd8ab7c5 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -3,6 +3,7 @@
 
 #include <xen/cache.h>
 #include <xen/lib.h>
+#include <xen/xen.lds.h>
 #include <asm/page.h>
 #undef ENTRY
 #undef ALIGN
diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h
new file mode 100644
index 0000000000..dd292fa7dc
--- /dev/null
+++ b/xen/include/xen/xen.lds.h
@@ -0,0 +1,8 @@
+#ifndef __XEN_LDS_H__
+#define __XEN_LDS_H__
+
+/*
+ * Common macros to be used in architecture specific linker scripts.
+ */
+
+#endif /* __XEN_LDS_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 07:45:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 07:45:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302708.516427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndojq-0004G3-Tp; Mon, 11 Apr 2022 07:45:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302708.516427; Mon, 11 Apr 2022 07:45:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndojq-0004Fw-Qt; Mon, 11 Apr 2022 07:45:30 +0000
Received: by outflank-mailman (input) for mailman id 302708;
 Mon, 11 Apr 2022 07:45:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndojp-0004Fm-Lm; Mon, 11 Apr 2022 07:45:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndojp-0008TA-De; Mon, 11 Apr 2022 07:45:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndojp-0006XL-0n; Mon, 11 Apr 2022 07:45:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndojp-0004mU-0H; Mon, 11 Apr 2022 07:45:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=92ScGxMkUX8jJ81I+2EvP4zs6KaZJ4SW405mQpwaqPc=; b=4kW+RFKyXoK1RqzfP4zTQXmJ6Y
	GmAJBhmLe9HCJR4+PZen6oIpUKWBRc5J/OWsGKFD7+1WqdtqcOFu/M2upkwIkYmmQOpnAB+heQxO9
	n1ErXG2Os+qkkVfmaKBhcZKBqnJ+lvvLVphepBrBkY24ioOViQlTinxAKn4NlfFfn1mY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169297-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169297: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 07:45:29 +0000

flight 169297 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169297/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  319 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 08:15:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 08:15:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302725.516438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpCe-0001FW-CT; Mon, 11 Apr 2022 08:15:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302725.516438; Mon, 11 Apr 2022 08:15:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpCe-0001F5-5K; Mon, 11 Apr 2022 08:15:16 +0000
Received: by outflank-mailman (input) for mailman id 302725;
 Mon, 11 Apr 2022 08:15:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MKM0=UV=citrix.com=prvs=09308b1b0=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ndpCc-0001Ez-6g
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 08:15:14 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 80b10bc9-b96f-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 10:15:11 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80b10bc9-b96f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649664911;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=zmM8WFB/94ESC5RxqZIJQAVaYI12SNQLWgWVfDpFSjU=;
  b=HlVtG/IS0nBn1x48TGLZABArwr5BeBI5tAdqsC9GHSHiclKQpO0qf5Bl
   VqFd2uB7VFaas4mHyGcgDsfQzefvSnvgm/I+YGWyrpDxgGH7KrUYRrv2E
   NIvPj/hXf1EM//WzX7iTwuAowxn/chfCVRpq2Y5VBZJpiZ20+A+Q50njh
   U=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67931007
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dkndcKju8UDjzZ4MnM9Phxq5X161chAKZh0ujC45NGQN5FlHY01je
 htvWWqBbvmKZzP8eYgna9jn/RlXvMODx4MySgdtrXozEH8b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1rU4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YTsJP67Apcgdbx9zKGYnEIBl6bX7f3fq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiBN
 pFAMWIwBPjGSxFjHAkKUqAhpvypo2X1cRNC9UrOipNitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoVD6ak++V2xVSfw20VIA0bU0Ohpvu0gVL4XMhQQ
 2QW8Cczqak59GSwU8LwGRa/pRa5UgU0AoQKVbdgsUfUl/SSs13x6nU4oiBpVPwnt8MLaTwW0
 HSy2IrEKB9+uoHLRifInluLlg+aNS8QJG4EQCYLSwoZ/tXuyL0OYgLzosVLS/Ds0ICscd3k6
 3XT9XVl2e1P5SIe///jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5XFhAztJcvU/MBofAnqNOv0j8tpyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS
 BaN5VIPvcEIYSL1PPUfj2eN5yMCl/aIKDgYfqqMMoomjmZZKWdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7cQhRfSdmX8ivwyGVH8baSjdb9KgaI6a56ZsqepB/nrQTkeHN/
 3qnXVRfxka5jnrCQThmoFg6AF8zdf6TdU4GABE=
IronPort-HdrOrdr: A9a23:6255i6PxdM/S28BcTy3155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080lKQFmrX5WI3NYOCIghrLEGgP1/qG/9SkIVyCygc/79
 YfT0EdMqyIMbESt6+Ti2PZYrUdKZu8gdiVbI/lvghQpGpRGsddBmlCe2Km+hocfng7OXN1Lu
 vU2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnS4j4uFxd0hZsy+2
 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUoZ5Sy+BQO5M2/4lcjl9
 fB5z8mIsRI8nvUOlq4pBP8sjOQpAoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L
 gj5RPUi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZMIMvD0vFoLA
 BSNrCc2B4PGmnqL0wx/1MfiuBEZ05DUStvGSM5y4+oOzs/pgEN86JX/r1cop46zuNMd3B13Z
 W0Dk1WrsA8ciY3V9MLOA5Te7rANoTyKSi8Ql56Z26XUZ06Bw==
X-IronPort-AV: E=Sophos;i="5.90,251,1643691600"; 
   d="scan'208";a="67931007"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nl0AjlMrnHR1jk/IVUAQxclH9hKGKe4Wt350kyUBAy15CokMjtaPMMxHE2XIR2OqelNXqodt9FKMhxUF1B+0C+zmTdo074gj0oUFS/olkRG8Wz3WKZi0VJ/tsmuI/CSYFkbEEOueVFg9dwCLNyldvErMIrV0jGxjh/XcAZfawem4ed3k4lgw19U5OP1lREy4OcmVe0p9TJksWm4Rc6fJfRMAnz3+mb0n58y2TMX2/fd9tD7oYA+tB+MRBGSzwAN3+eK7J1sGiX5hr5v3Sy+7iQzpkZ7EPPg5GLSkPix2oRULBt+ZXQ4rUASHG0IcnBFHR0bp9x4XOQb1nY7J9l4rdQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B6pmHdgCZoQmpVt3Nyf2kGVwFjtVIi5m7I/oNz7I8tg=;
 b=QmWg4XUmJRtszLrs0oxcGQnsV+LIA9tY1mA5idscZ6N9IkbLFZwNaIgvnCBYxyNAdSG5OaPX9Vmpy3mFBbnofjBD/fgoaXA6d4Mzg/haoMXde+Sc36fNx1du3vOkcTQJwJUadMFnVxonpfk1swRurQAFNhP33trO3u4xZthcRX+iqpfpzAcpvdPgukn3eSkAf/CjzTyJO5p6fbbVsfUa5RtC52+9yGOVdz6xhvSkJuViNGXmB6X0h3+0BMyzgu6Igvtoqx6aFl7RpFpWTR+2w1FQ7xoBQhDEyLDMHNO0mfB3bzTS46S8PMrAWmz4oZLgZeQXEf1A9tFZl5BtiXiV7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=B6pmHdgCZoQmpVt3Nyf2kGVwFjtVIi5m7I/oNz7I8tg=;
 b=IaGLkWdhyBExsLw4DzW7xJ5xj/l4EYhBO0o2M6Eh+y37JvZ+xM8Zp7Y//Ru6PPV2UD65H8s9/9ZEIUAvXahSgL9Oq5fR3CvjcpDlD+5Q8k1MOkiGm3WpDCfyHw21lGLVWOo24umJLvCvbWjI+oGTSv9naqPxrQ2iR0DlED5Gk14=
Date: Mon, 11 Apr 2022 10:15:02 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: osstest service owner <osstest-admin@xenproject.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [xen-unstable test] 169172: tolerable FAIL
Message-ID: <YlPjhj6mujR4u81u@Air-de-Roger>
References: <osstest-169172-mainreport@xen.org>
 <c01eacd1-cf2e-9258-f06b-5a0278fa0ce9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c01eacd1-cf2e-9258-f06b-5a0278fa0ce9@suse.com>
X-ClientProxiedBy: MR1P264CA0069.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4e7f1654-f3f9-4ad6-077d-08da1b936314
X-MS-TrafficTypeDiagnostic: BN6PR03MB2609:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB2609DB49A3E64CB3C70DEB0E8FEA9@BN6PR03MB2609.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ta/Ue7rfs+3wPgDRKrcR1tvZ8IljXy0SV+qtJn5F17IBE6NU4wphuT8t9+wUa3I5l1oApwNxl14OuCbbP51HyGO3eunNDE497SV35EOcLv4WOZYG3uvD5q5pG6H378QBJM2WkYi6Z61hVgHw95uWCq7hqUEoO1+WI8D7MwCOwL+eFjBmAUi0VjBq5/URfbl8ckmzeiqpzcJlgA6Pqp+B6MH9jOjOGdeo59QVEzHlHv/gCfhAJmeUfe9CiP3iUn0Wbdmgbn9AJ1W7UN9ra+RyzrLGm3QtZo6iqrjMyuc1P2tqAhp17QwhRqZ8ot8cEKtFd6cIBERkPaCorM2/QS6AahZ3unVLzWslP0xZ7DkSLZEqbMc63Ve+c+NnOyOXkyqGevNNQKqct4L5KyAe27MTTsbl9258Pxc3vvput4tXnB/eoMhnf4CIiRg1df+VxJLTwFM6kgeIg2cCWiWcNhzbcwa/hALXPYdz2XafgaMRHhdq5v5ajm/EV7SJHmdSDrIWlJ1A254PN11MDUk1ijm6ehmEEAjR7fKlCRhPBhAkMnd/6y+y0z0XdG0W40o5RFjY195IAsHuy3cGP0U5IEvDVtWfV4wJEECsibORs18iN3g66eOkcz6Yua6GYJHjzAJ1fCXqbR9oXjjMa4rvqWiBlbkBReIRc4kG6FuBJlHbGNfHP+IIwA7CnC7JKjhOpmgGIjpncFWc3DmCwsIzfA7hUewTFUzldLa7fGD7wPvWR1I=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(26005)(186003)(2906002)(83380400001)(33716001)(86362001)(4326008)(8676002)(82960400001)(66476007)(66556008)(508600001)(38100700002)(6916009)(316002)(8936002)(5660300002)(85182001)(6506007)(53546011)(6666004)(6512007)(9686003)(4744005)(966005)(66946007)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a21RaGFwLzdBOTZUd3hvblN2US9ndlFmdkZNR2xBbncwL1JZOC9rUWxPSzZO?=
 =?utf-8?B?cjdCSWZsVGRzaUFOczM2MnptZC9MaVRqVVVSQ2JvTFlCVG1GMXhBTlB3NVdX?=
 =?utf-8?B?eVg5ZEVmRmpNcHgrTWNoMXVvWXJOdWM5MDhtRlhLZ0Q3UUMwcW4zaHhJcnVB?=
 =?utf-8?B?L3F2NWdOVHBCRVZLakhraTcxQ3FCS2Q5dlFmQ2EwSlNUdGQzb0JvS2VvbnJW?=
 =?utf-8?B?VTk2RWpubFU2cHJWbk83SmNmSzRGa0JUbVBUMGVKWUZmTWx6RlN5bGRhSXVG?=
 =?utf-8?B?aWZodkJWZWxtVDJtQ2ZKQzlMTVBwS2lNMmRxMGxIMCtWT2RHdU9ENXpYOWNK?=
 =?utf-8?B?bDh5c2JQdkRUcitlczJGVmlxeEoxd1AremlkbzlveEpsVHhuaXJZVnJwa1pJ?=
 =?utf-8?B?QzdRRGZGSDFmY0QvZWdCbktMNGxhQ0s2andndjhQam9aSjh2SzFxblRmcHNQ?=
 =?utf-8?B?aDBNZ3Z0dEwyTVlXTWVuSzZlelhYL2RZWmJxblZxUXBpUzRIMzZZcHd0d3hC?=
 =?utf-8?B?bWNYdDBLbzNKS1JSekhPb2ZLZXUrK1gwVlRRSWpmL1hHNWNZSVQ1a0NyNG9n?=
 =?utf-8?B?bzJQaDVhOXU5eWw2eTFyK3RKcWN1b2NUTXMvT1h3RWxKcUZSMElPb05LT3Yw?=
 =?utf-8?B?eGJIbTZPbjIxSkxKdjBFQVdNZVJwY0p2WmVvODNTQW1CRUZDaGtCbE00TTdW?=
 =?utf-8?B?cUNrcUV5K2lvQnVBTHFjdU8wVnlXaWdBTGJFTysrTDBxOXdOM2p6K3p2NjZR?=
 =?utf-8?B?WXNUV1grRlNQemNOdDRFN0dqS0h5dTAwVFZEOGVIOENHZnhrOTU3emdoQmRm?=
 =?utf-8?B?M1k5WTdrTUdoV1VybnBmN0cvaHQvZ2xJM2diaGtsUlRDa243Znc1SkViVVBE?=
 =?utf-8?B?d25hOUtneXhESk5nNTQwUlhzdjc2REpZRVVFYlM4SHlNbXVIS2Y0eHJ2cy9u?=
 =?utf-8?B?bHpENFRHcVdYMzhvb2tkYWVsdE5MUTBmWE9LWVdhRHRqWThIRTRMWTJzWDZV?=
 =?utf-8?B?b1lEaFZ0ckwweXNuVlQ0elhYajZPN0krMDZ2S1Byay91Wjd5UjlSSnl4UWFv?=
 =?utf-8?B?Z1RaMm9Cam1Wcm5zNjluSSsvMldPSGo1Yy91RDFieSsxcEZqWmJ4Q2xqK1JW?=
 =?utf-8?B?ZnR4VERIN3VyTFU4T2RSNis2blZoNUh3R0dmRDB1WkJsSmhONjFnNlFoMVUz?=
 =?utf-8?B?TjNwRklmVStvWE9LL2dLWkhvQkNOa3V1SDZpbWFHV2RtMDRPY05LQnI2dDUv?=
 =?utf-8?B?MjRLbHp1VWZCbzYzd0s2czlKT0o4S2pLdTVlbVhhMDVCVzFGRTQxYXhCaUE1?=
 =?utf-8?B?ZTZlQnlQQWR0RTdDZXpMVlBBa0c1Skg4RWZQTjdSTUpnS3orNEpwaFd1aU5n?=
 =?utf-8?B?T3Zpdlg5enIxRlErVU9lc0hiV2RGbHUwSUdsVVZDZzZYQTF6MGZES2JldUcr?=
 =?utf-8?B?YVVzWE44dks2cFV4ZlFqQkRqTGtNcDBwUGhFRTJzVW96U2xiRW9MVXRzdjVG?=
 =?utf-8?B?QWo4aGxTZUY1RHVRVEc5TTVZMmJZREhibEJOcExoNzJQL243cnhCc0VOSERD?=
 =?utf-8?B?dFJJVVA1UGVaRUR1cldRbncrb2FoMzZGbmR1dFVIWWZyVzNqcUhyVDhTcloy?=
 =?utf-8?B?NTlDVW9BN0oxejFwQUVlNVM1dHh6TTZER0I5eVdvSkFaQzMvbVV0MDVwak03?=
 =?utf-8?B?Zkx6UE52TzF0SXo5cUFhaW9nNHdidnNjYlB3ZFEwRGdueU5yR2pTTndQdS94?=
 =?utf-8?B?WHNnZGZPcFhzYWpDeGVjSzg0Ym9lNHVGMXR3alFJOXlJWjJBU2FZeVRRN2Jp?=
 =?utf-8?B?WXQ4WENQclNwdGtpTDBxYldzNXh0dnRtcUluYU0xdUNPcDhOSVk3Wmo0dHhm?=
 =?utf-8?B?OFpFamtRK0NrUU5iYTRaU09RaUplaHdVWkNLYkQ3YitLN2hIRTY4eGVLcm1x?=
 =?utf-8?B?UGFydk1QdWQyKzBwajZXWmxITTIzQW52Mk5GMzBDQTR3b29SVklqMFdGZHRU?=
 =?utf-8?B?YnBpS0xiaTJTU0VWZFcwU3lTMUs3eWkyaTg4TXB5dkIvQzRUV2xBOFJZbXZI?=
 =?utf-8?B?eFM3WktIV0hXU3ZmSkRsbVlSYmRONGNMVU13Mk4rZDdZSXdhaWZ6WlgvYjdG?=
 =?utf-8?B?amJrTnFXRnVaSDJRdUQ5OUJBVG54NUU0aTRGaU5WNGVranVMUnBBZGpqaW5j?=
 =?utf-8?B?UGJlbXY3SmcyYy94bUtndFFSK2krQ2lqVmc2OUNIQkp3S0VHU0RZYnowRTZy?=
 =?utf-8?B?NkNCeUJFSTh5bGFCWTRxclh1UHVjUU9xQkJMWnZSZlhISlVwenpIOUxrb0hY?=
 =?utf-8?B?ZkNOVWtheEM3aXc2ZXpETzFtWlZ2WjhIem9iRFp4Y2VsZFFMMWZmdXpuT0JU?=
 =?utf-8?Q?knMmy6Uz7b7HLjgQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e7f1654-f3f9-4ad6-077d-08da1b936314
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 08:15:06.4152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SO0VI3yHBUla2+BkH1NZO4esVupnkjyCDSoMJJArBjY2fIgf4Hb4DWT1aH3Dpkicg4KSs/XWGT+K1nfFfUmD3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2609
X-OriginatorOrg: citrix.com

On Wed, Apr 06, 2022 at 09:00:01AM +0200, Jan Beulich wrote:
> On 06.04.2022 00:30, osstest service owner wrote:
> > flight 169172 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/169172/
> > 
> > Failures :-/ but no regressions.
> > [...]
> > version targeted for testing:
> >  xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
> > baseline version:
> >  xen                  e270af94280e6a9610705ebc1fdd1d7a9b1f8a98
> > 
> > Last test of basis   169172  2022-04-05 04:42:27 Z    0 days
> > Testing same since                          (not found)         0 attempts
> 
> I just happened to spot this. Perhaps not a big problem, but somewhat
> odd and present in earlier flight reports as well when those were
> simply re-testing an already tested (and pushed) revision.

Hm, indeed.  I will see if I can figure out what's wrong.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 08:18:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 08:18:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302730.516449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpG5-0001rT-Og; Mon, 11 Apr 2022 08:18:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302730.516449; Mon, 11 Apr 2022 08:18:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpG5-0001rM-LA; Mon, 11 Apr 2022 08:18:49 +0000
Received: by outflank-mailman (input) for mailman id 302730;
 Mon, 11 Apr 2022 08:18:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MKM0=UV=citrix.com=prvs=09308b1b0=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ndpG4-0001rE-9c
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 08:18:48 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 014e9b21-b970-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 10:18:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 014e9b21-b970-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649665126;
  h=date:from:to:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=EWPyjAd/csTCe9IycIIFxxGcKa4tb/P5sYycIvFQTPI=;
  b=Q9UesL1dVFOwsaeGmBjRF8pcJ+Opik/gGUQU12IkcXE6VJ8/xcjcn0lX
   CsKea1BN1k3lLQo5b3ZdzyICTAeZZBnTlDh0OFTvn0fmt6D+RToq5ARby
   Q0xQQK91xkzbhm8f9el1QbITINyiA9xO+ZlAYIK4gDmhfxzyj2VTQaPD6
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68518209
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XV3aPaKagKDK51eKFE+RspUlxSXFcZb7ZxGr2PjKsXjdYENShTFVx
 zAWWGzUOa6LZzf2edt3PIjipEpQu57VyYdrSwtlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tcx2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MRQid+cZCo0BLTzx/ojQid6NCRgJ5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glg25keR66PD
 yYfQQpoLzfscxhVBncWEJ0utreM2l3FSAQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7tIjhguiBthUTufhsKc33hvDnQT/FSH6S3OqvMX6pmOTRuhGF
 BMKxDsQj4836laSG4yVswKDnFaIuRsVWtx1GuI86R2Qxqe83zt1FlToXRYaNoV46ZZeqSgCk
 wbQwoi3XWAHXKi9Eyr1y1uCkd+l1cH5x0cmbDRMcwYK6sKLTGob3kOWFYYL/EJYY7TI9dDML
 9Ki8XNWa1Y715djO0CHEbfv2W/Em3QxZlRpjjg7p0r8hu+DWKarZpaz9X/Q5utaIYCSQzGp5
 SZYypbHsrtTVM7czkRhpdnh+5nzuZ643MD02wYzT/HNCRzwk5JcQWygyG4nfxo4Wir1UTTof
 FXSqWtsCGx7ZxOXgVtMS9vpUawClPG4ffy8D6y8RoceM/BZKV7clAkzNBH44owYuBV1+U3JE
 czAKpjE4LdzIfkP8QdasM9BieR7mX1knTq7qFKS503P7IdyrUW9EN8tGFCPcvo4/OWDpgDU+
 MxYLMyE11NUV+iWX8Ud2dV7wYwiRZTjOa3Llg==
IronPort-HdrOrdr: A9a23:Z5Lx0arjGRUa05wAfd0wJboaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2+
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LvEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqMq+SWnqLkwxg1MfgOBFBh8Ib1S7qwk5y4GoOgFt7T5EJxBy/r1cop8CnKhNP6Wsqd
 60d5iAr4s+PfP+XZgNdNvpfvHHeFAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.90,251,1643691600"; 
   d="scan'208";a="68518209"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aZTVzvzzn9PYc//+5PW6XndeMLgG6/DStnODFg9eSTbXL7q8WEBST4LewSSgX9I6tHf5VzVrnmNv5lgUJS9xHi7RD0DaNRwCMg+eDhq07wacEaM6wCOhTBhIL3AVwMWGXFzdm6iUw2kXz0TZIUte+EJD1+S9XsJbaaj54pu60WHf3OtPk/AkAUacN5pYEsIvYkzArHQkAElAN6/t8RM1c7QQRzWMTaZKjIwtaE8h8U/DG8P/WP7xtAA0BNq9yes0yfjwjz2f3G+R5qzs56OLKz8091yJpKN++4syscwf3hRadayTPaLnClxL5ra+grISup1EqGsUfEz7niSYr1ttCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FbmDmjgnkIOWPJs6I+8tVdX7E0ZlS5QQ0jQv6bvKLgk=;
 b=EMXRFpDbYg5NcWlOrxU8rBjzkyXkla3+FGCkDl+7qDAceKrDMY8fCuKtehga7X0TqYcVCfrlP/ISwqsOF2KSCN7SkOPJa1O5qsy8s3LWZcAIdiulMwuwq483QsPBjKougHX4jLD7KXbqSKxIfFXfhnnfIrBVqa9W16Bo+rq6jeyCLGq3J+t2BprixxIsYQSrJFjdkztfznfEr7ctNUIzGkLylMRruNvVeAPUTpu/KonGz2imVTPeBlypjVVr+3eOt58NwSQG9Y8/qfERL2Qt56NlhWLy7Ri5wkhvkoAL1c2Q9p+VLTAJfQASrNThldFmm3mGUj0MjqmhohbMnc48iA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FbmDmjgnkIOWPJs6I+8tVdX7E0ZlS5QQ0jQv6bvKLgk=;
 b=XmPLvkjB6ndNZyvzeem1CqWP3irAsC5lMlyVOKfF3ty0cc3SWPn7YuR3KeYnWagsZxacMIgtALgKG/bV3cL+qZ6EpCybervyveuQZN3ofKBinAdBxKAaGt+qolt1fFGGeLON1yqj/+CasFRBx+aOni+OGsoNx4oGKc7ffvn2B/A=
Date: Mon, 11 Apr 2022 10:18:34 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
Subject: Re: osstest: boxes pending comission
Message-ID: <YlPkWsYmGP3mOJP8@Air-de-Roger>
References: <YkrCkzWRW1xMvzSj@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YkrCkzWRW1xMvzSj@Air-de-Roger>
X-ClientProxiedBy: MR1P264CA0012.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2e::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 898bea07-2c1e-4bdf-5cef-08da1b93e1cb
X-MS-TrafficTypeDiagnostic: CY4PR03MB3144:EE_
X-Microsoft-Antispam-PRVS: <CY4PR03MB314451E32E82D47E35B765408FEA9@CY4PR03MB3144.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: p/ZTvJpiA5wHfa3xOwxcZE9sf08Y6O4rl4OlMPNKytJhgqI9L6ZrAa+hfuvumjBHhnx3Rzuunm36R+kLaXp5kCptDInL632uTs3nwC5adMOA9lY/Byxud8nDUyxB7EGKyIPVvke11BXzxaz5T9LwTyjQd9EXX/qeND2RQOJJJa+On7cReIn9pJGIHjU2bPoR6FqjNrOtOEuiEhv3VdlxHcW4KJahCbAf8b4AH8GzBeYwys5Xe4BDWPATmt6BYmpSunTNxWPEHs8K3SEDiysmzRx2+lzWwgm9SlIR2Ijn7/IWXzj0kKK1gFM+HyQ0hgn8OUt8X50IbpAKKT8sN2hnl5PwjZI5jHkaYrceq5vt8w43NJjCLQnd3BLYpMXIiTNwWW0WUudjs6aSjtH6nLtyI+2uKwRpLwZz4Un+Y8ytbR2l4gJdc5S72mTtONaVwa3qcq8Uh2NmP0M0LOrSCOHKudv+zF1WiK4Q+vQyLbl2PX4Qv0wSxjOjDkTB5eNjduPKICvtvODlVaAXummN01Hx1Oww4HrbqokRTWE9yxmnEfBySJTcUuf9i8gCZmhuIQafWeQvG6YFPfILyVavO4o8pDdlvjFdY9w1QZd9ikxn8huO1iSg8h4IH431QPPYPdvE+QKzOjZWXqr1u2Rdpu9JBzyg4PEhgEOKjdcpqxdYmRO3R8xtfxJcPE+81LeFfLKJKE7N2Gbb1RxDImgT9l7onBy9Tge4UhbkLQ9EQQe9ZOLjw8iNbb5g2QkT/UsYx7GZtERlMq3sVbn593fx0Sd29w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66476007)(8676002)(6486002)(6506007)(66946007)(82960400001)(66556008)(9686003)(316002)(6916009)(6666004)(6512007)(33716001)(508600001)(966005)(86362001)(2906002)(85182001)(26005)(186003)(8936002)(5660300002)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czJKc3RQTWxkcDdhSVhtUnl6UjdTdks2UWk4WWNGNVErWGhxNGlIY0RwTUNC?=
 =?utf-8?B?T2JOaVVwM2tIdlV3bEIvd0JDaUtJcUhnZXBLa3ZWS0tLM2czak1sU2tIL2M5?=
 =?utf-8?B?cW9aSVExbjhpV21KWURnSmN4SDhrMVZrNCt1WWdrRUVhRUdrSGVmRm9IK21W?=
 =?utf-8?B?Z3Z1dnRDd2tweXYwcGh0U2JQcVMza2ZKZ3FNMmZNeXY1Y013UXZSaktCNjFw?=
 =?utf-8?B?WjJteWxOeTJKMUUrc3Y0T3preHhNRVltVE5vTmdCQ3NaS2tsaHdwUDVtN05R?=
 =?utf-8?B?Z25vT1NFbWh6TDNPSFgzSXdsSlQzWW9pd1JrWlBoN0MvZFd2S0xVRmJZbUht?=
 =?utf-8?B?YkliQjdkY09OaWFnUlRUc3VRbk9ZUkFOeElESkdYU3FzWGloa0ZMMUJoN2Vi?=
 =?utf-8?B?OFZqQTFIWjUrdlhIL2ZWOHZ1UXdXODlPMnpUcGpoajQxQXBlZXMrdE1iQzlw?=
 =?utf-8?B?OFExeDZZZDJEVGV5L00vS0c2QWs4OUZMbnhLRm9xMGMyNCt1bzQ0c2toS3Nr?=
 =?utf-8?B?bHNZd29YRWFJMjQxcFdEM05oWnRRcjNpRWYvelpvRWg5YW5WMms1dlpLTUxR?=
 =?utf-8?B?cFM4UG5zVVprZ3dPczltNUt0Q3cvb254N3JadUNReE52eUw0blMzejZxdmFD?=
 =?utf-8?B?TFQ4T09IRm5pWWlKRlVxVmd5bWM5UGtmRWxXZ2xlVmRnNng4cHpxOFpDQ1hz?=
 =?utf-8?B?TnN3QUxic3hmRS9Yb1hMZWVyRnljd0tEbWc5aWdLT3kwSjBISlNuRzc4VnpI?=
 =?utf-8?B?eEhGa29hbE4vUW54MWdGMUFTWXhTcWNUZURQRWJYWHJzd2R0K2M3Y0lBUGNa?=
 =?utf-8?B?YnhhVzRhTzBrUkQ0eVN1b042dDBURGJQV2tXTWhoclRuQmI3ZUpWdVBScFUx?=
 =?utf-8?B?OUdkUDFJZHNWRHJyNWJhclo1MEVCa0xCWTJYdXRDd3lWR1oxTVZPc3VwUUxQ?=
 =?utf-8?B?cTk0UFJOazk3VnprTWJlamRHc0VxMndIUmlHYTlRcHhNbWVnN0dDNTZuTmNx?=
 =?utf-8?B?NGR4RWx0RjVjQWc1WjdKdXIvcy9ERkdYdXAvcXBLcFBnSW8rSDNTRmlUTGlh?=
 =?utf-8?B?cHZBT0pIbEZlRVhUNk00OFJDRGpKajhsUzFscHZ2KzdON2N6ZHd6bTgwZ2pa?=
 =?utf-8?B?WDNFUENUYWNzeUpNRk42QXIwclZScjI5bmVwTmVKelM1czlqYWdGVFFxVjlX?=
 =?utf-8?B?M3BqaTdGYnlYb1dnWFczb2RkODlTc3pmTUVQdFlJWG4zZDQ3UWZqUHdZMlR1?=
 =?utf-8?B?UWlLV09kTHFQZXUwTmQ3ZVVpQS9Ib1dZRXlERGNNZ3cwejVxWjRxMmQvTEtJ?=
 =?utf-8?B?U2VYRnlka0FmMDZJaHRVSXNVTmM4N01IUTExUVdONVdBSFBVN0I2cTErM0g2?=
 =?utf-8?B?bU9WY3ZWaVFnWWFYMThjZjFoRk5oSE5ReDBnRE1YS3NzSE1NU0pFWUl4WGlT?=
 =?utf-8?B?OWJqSGpqcWVNcGlMaGFvc3NHMFRUT2FCaUhVdnFVMHdMK2N1MWczekg5TGMz?=
 =?utf-8?B?aWJ4djZZU1o5Z0I2UkRwM3k1QmhoejVlaW5NLy8yaS8wTW8xVkRNeHdHZlU2?=
 =?utf-8?B?bkszck1vZW01b05kMWdYd3JaR1hVdzkrNlByQm0xb3pGOG9NMUZTL0p0UUVQ?=
 =?utf-8?B?OTl3c2hBeDUzSEJmUkNuaFkyUms5d3BEMUNiNkZHcGI0aHNpcWJjdVVqMzUx?=
 =?utf-8?B?bFh3L2JpRlU2M3ZJZ2dtWlZqU043TG5mS0RyZXZ5bFN4OFhDQ29hYnlWV3BU?=
 =?utf-8?B?RjdHZWh2L2FHRnN4RmViM3krVDNVOGFYZTdDeG9vUXVqSnF4bUJkMTBhOGtY?=
 =?utf-8?B?c2ppMm5Nd1RtanRNblpCOGtCK3VYcFJmdlhEQStwRGUrR2lreGxtclViY0hI?=
 =?utf-8?B?eHFDcEUrZWlzQmtZZFBpRXhoNmhyUzJZMWJ2cWdIeU14YmdYUW1OdDYrZ01X?=
 =?utf-8?B?YWRMUnNMSHpGbHN0S2ZKZ0ZpYXRBNVM4bS9MdWgwT0lhY0E0MkpIamF5dGI3?=
 =?utf-8?B?TitXUVpRN2pRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 898bea07-2c1e-4bdf-5cef-08da1b93e1cb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 08:18:38.9627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8hGYPafbN454W4f+qpSyVxj8SIo5za/ODM17w3tZZse4eG2MgLlNFcEN70nDa6J/oJCGYo0Uu23hM3R9IBjhjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3144
X-OriginatorOrg: citrix.com

On Mon, Apr 04, 2022 at 12:04:03PM +0200, Roger Pau Monné wrote:
> Hello,
> 
> We have the following boxes pending commission:
> 
> italias
>  * Commission flight at:
>    http://logs.test-lab.xenproject.org/osstest/logs/169015/
>  * Issues:
>    All fine except for the leak-check errors:
>      LEAKED [process 14559 run-parts] process: root     14559 14558  0 19:29 ?        00:00:00 run-parts --report /etc/cron.daily 
>      LEAKED [process 14558 /bin/sh] process: root     14558  2252  0 19:29 ?        00:00:00 /bin/sh -c run-parts --report /etc/cron.daily 
>      LEAKED [process 14564 /bin/sh] process: root     14564 14559  0 19:29 ?        00:00:00 /bin/sh /etc/cron.daily/apt-compat 
>      LEAKED [process 14571 sleep] process: root     14571 14564  0 19:29 ?        00:00:00 sleep 1091 
>    Those processes are from tasks started by cron. Disabling cron in
>    rc.d during the host install doesn't seem to be honored later on,
>    I'm looking into a fix for this.

This fix for this has been committed and passed pretest, so I'm going
to put the italias into service, the last flight LGTM and can be found
here:

http://logs.test-lab.xenproject.org/osstest/logs/169244/

Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 08:30:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 08:30:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302739.516459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpRP-0004Vy-TP; Mon, 11 Apr 2022 08:30:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302739.516459; Mon, 11 Apr 2022 08:30:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpRP-0004Vr-QI; Mon, 11 Apr 2022 08:30:31 +0000
Received: by outflank-mailman (input) for mailman id 302739;
 Mon, 11 Apr 2022 08:30:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ndpRO-0004Vl-S6
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 08:30:30 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20623.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::623])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4a8b4d5-b971-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 10:30:28 +0200 (CEST)
Received: from AS9PR06CA0044.eurprd06.prod.outlook.com (2603:10a6:20b:463::35)
 by PAXPR08MB7394.eurprd08.prod.outlook.com (2603:10a6:102:2bc::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.22; Mon, 11 Apr
 2022 08:30:18 +0000
Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:463:cafe::bd) by AS9PR06CA0044.outlook.office365.com
 (2603:10a6:20b:463::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 08:30:18 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 08:30:16 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Mon, 11 Apr 2022 08:30:16 +0000
Received: from b4f665cdc745.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5545757A-54E4-4A1B-950C-330A1203336B.1; 
 Mon, 11 Apr 2022 08:30:10 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b4f665cdc745.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 08:30:10 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AS4PR08MB8071.eurprd08.prod.outlook.com (2603:10a6:20b:58a::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.29; Mon, 11 Apr
 2022 08:30:00 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 08:29:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4a8b4d5-b971-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sYzB2WdYhMpuT0nWJ3euzQTltacZT0SP8w2JBh/xavI=;
 b=2fCiWLnhuK1O/10dar8WzL8XSgsnTYMir7KkYk9F0zjldWNbcz3nOVhqRrdsBs+HM2D92GcJ2RHEUqoggo4u4Q4pV1H/xI9PVQ8xjGjNuF5zPlLwYdOfXr57hW24/DUhhYWO7zsujyqI4Fxsw4GT0fskBlJq5QvUXuGNi6uYhaY=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=temperror action=none
 header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: e4c77bc69ba576d3
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lOJvrJ7JbuPZYQN0qJLHUWOjZZ64pYmcXqlVONFiaJZT56TOhM1EMELsgMVxATMUDUQgHu9MGnLdiIWNgp53vwxEzQKovds7NTjd6UVWdjeqwfZGPS8GLXvyevqm28Edun1DobVoqvQBy52ykNcMzqTx8tikSMRDQXdzshQHL9Y0HwRdHNI9zOzcwg8IyIXW48IXiodiLCr0MRHqI9O1Nm+Fe+q7lzm5dB13QpeWWsfnIoMN13Uo/G4FykVVpdAi6cNqRNlucA5QHDsVgGWEWW3nVSDzGyOoAl2QbUWZUDA4LXok1+6HWLK+AcOBeCeWOBV2CD8W2dMpM6PjD+cXVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sYzB2WdYhMpuT0nWJ3euzQTltacZT0SP8w2JBh/xavI=;
 b=brmBajrNYJNjaGLxhPiZxqJxjN5oObajvIkp6KD+rwpa/1NCYzCiSWl12jhjhz1mRdB93twS9c2VFhLvP5TQ9pMeA6U40fzjiURhaEBqLvlgx4t+Qdd3QfHybLvd0ifjXVeyo8hH1AoFKp/J3ZTolrT7qI1CjefOLLElvBoUrG7uTVpJMKQAZ/RgZwZUEJsmaApTL/C/mkiUTORPA9lQ1ZyO5OMIGZBM95bM3NpxxlWu0hc6BOxjD5AlV1TVAERmxrK4psRHjRu8EstXSGaBhHQEAiw+zFC+ciroKmhBw5JyjDifB/0Z9VhVSJ7I0M1O+aBCyP676VGBN9B206Z+GA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sYzB2WdYhMpuT0nWJ3euzQTltacZT0SP8w2JBh/xavI=;
 b=2fCiWLnhuK1O/10dar8WzL8XSgsnTYMir7KkYk9F0zjldWNbcz3nOVhqRrdsBs+HM2D92GcJ2RHEUqoggo4u4Q4pV1H/xI9PVQ8xjGjNuF5zPlLwYdOfXr57hW24/DUhhYWO7zsujyqI4Fxsw4GT0fskBlJq5QvUXuGNi6uYhaY=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, Dario Faggioli
	<dfaggioli@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Index:
 AQHYSyUg2T6WkJDiXECW3myZV3L//qzluEIAgAArbICAAAYSgIAAjXIAgAPJp4CAACWEAA==
Date: Mon, 11 Apr 2022 08:29:59 +0000
Message-ID: <CE2F688A-70F2-40C2-8B8F-A3694EF8F395@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
 <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com>
 <511b60be-c6c6-d13a-b9aa-40e67e5a1b1c@suse.com>
 <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>
 <1be2f46c-700b-6af1-a74a-d090196c9f5f@suse.com>
In-Reply-To: <1be2f46c-700b-6af1-a74a-d090196c9f5f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 298d36d9-77f1-4bd5-bdec-08da1b9581e2
x-ms-traffictypediagnostic:
	AS4PR08MB8071:EE_|AM5EUR03FT029:EE_|PAXPR08MB7394:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB7394F634DEC1883FEDB49700E4EA9@PAXPR08MB7394.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 IjyTCLrZLctADo3yQsLBfJenac/HCxec5Qo713ul7uzaj+TzhmNrKI5+jhAH4deGa59Rgu+F9bwPxY3WqWopamF6MJQn3N7YR8hniqf62Px1/TwN4+0iBzrrtexOHi0cbp6JkX6ov16AMT41abTk2zjyMfPssIx9IP4z7y++m87+Qyojn7DCyGkuePuh5AgxUf+76r75frjaPiC2ombpA5jj+ErnyfKHzU8w68Qviy8wiuDFOMmmWYZiVKDyV1jm+ACQ0L/vw0pCp+RfraabsSon5YzVrFpm4ptfcPZaAPWHQ74p0B6si3GpP+bn0S8Tfy/esknaWN7+6efMJ5l5jZZjiT9vq4YZPTFhC5+r3JKPz8OiClMkX7WgtpOkClngTTqD+Xr0GBUQt1o3G6SRUy3WSiyocibHBg/tL5nS3bqF3IDdzP52wP+n+MkkujYMY3FMPqwirv1xZGuTd84rfdLLSz3esxvANUECmN/XBPgMX+i2X02uCRa8Vg+dnteduMAH3oG2jEldfla0DA3msLZlbMckY3fSWH/3pI7VWOBz9WVAuaeZ6na4D6uPeBH4LBK1D7RJgM4yEg6AKH7x9cJ6rk5gyNL7Q8wX8bok9nW78VW/dX+1mE9dI3ayU3/aYvU+I9zl179aBUZI2FD6ITb7agujG+PYrrRveAq04BNqcIo8EYIXOvAyFeqgOC+smA2ejGXXZFitiMTQlAxZXRvS73TbqLx/cleiUOp65zY=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(6506007)(186003)(26005)(53546011)(8936002)(2906002)(36756003)(6512007)(38100700002)(2616005)(71200400001)(38070700005)(66446008)(64756008)(508600001)(6486002)(66946007)(66556008)(86362001)(33656002)(8676002)(316002)(76116006)(5660300002)(91956017)(4326008)(6916009)(83380400001)(55236004)(54906003)(66476007)(7416002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D9FDBE68A46B3149812ECAB38868194A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8071
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	99e7f68f-0a7b-4168-8e73-08da1b9577a3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IoxZwPMoRVO7+0OnvMICTbTLtLLCrRCpqA1VlH2qQfm4YhIOtkiN4wINWI1Z79MzD+brgVKcOUBvP2iZso532eCseqegZwWHu1r7GiHLGN+8UJJWGSkrsU80ZfEJg97WTB/3R66f1qmiTX6xM0uiL3vpdOJg5skWV8uNnsg/tDOpKsB85Dx1e1C1CEYxSCXjBx7PtDfX/qXkruSTzOXiigbhDh99CCiQDQcc07Bx1K58yohlEO/L1rE97Qy8KAiW5ctD22hovX/0aQPK+ZjmUaJxLOigDuY10CyFANhpsP/DXFYJnQDJyS6VD6opo7Xf8bsbwKSZp9p/NeHyAFaPdD6jyLHBzYqEx8k3WA0eZYfbpRByn1KZeeixIz+/4DDG780ex653nam8FYFG4j5uTGt0YGCD/yhLMLgY/O5Zxqt/WAmp3JcR0dAt0mrEuNc/7IQczSEEAUutyANdlJ9xJKFp9RqEpQLjC6t+0JNXnFsJZCgBGLRMO7HHNLM2rCHaNAl2/rR7h2A0/BZu6mLcPWVl0EOx9RMAc8i7OKCRZvJUExeEP1J4QZ0QkiO8Y1TdAYt/ccdFmTFPfLoOQPYWoCEqjOoB89MlCcc/+qe2cSONtX9Cfd9W6dcaOKyr6uClBh+5tcrrAPo8JJzneN4ROiFibUogwpuZyxWMp3x+VAAqSY7KGNZH/FMdvsymFCcnd71vBmxc9F9hVSuw0jTt3P4MltMALfV+zX45DeJf7Ec1aQ9aWQKoLS6xHpVlEkMv0KQd7RuRen89u5bX3/xw5A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(336012)(54906003)(8936002)(6862004)(6486002)(82310400005)(6506007)(36860700001)(316002)(2616005)(83380400001)(5660300002)(6512007)(508600001)(81166007)(26005)(63350400001)(53546011)(356005)(47076005)(63370400001)(186003)(36756003)(8676002)(86362001)(70206006)(40460700003)(2906002)(33656002)(70586007)(4326008)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 08:30:16.9075
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 298d36d9-77f1-4bd5-bdec-08da1b9581e2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7394



> On 11 Apr 2022, at 07:15, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 08.04.2022 22:25, Stefano Stabellini wrote:
>> On Fri, 8 Apr 2022, Jan Beulich wrote:
>>> On 08.04.2022 13:37, Luca Fancellu wrote:
>>>>=20
>>>>=20
>>>>> On 8 Apr 2022, at 10:01, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>=20
>>>>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>>>>> ---
>>>>>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>>>>>> xen/arch/arm/include/asm/smp.h | 3 +
>>>>>> xen/common/Kconfig | 7 +
>>>>>> xen/common/Makefile | 1 +
>>>>>> xen/common/boot_cpupools.c | 207 +++++++++++++++++++++++++
>>>>>> xen/common/sched/cpupool.c | 12 +-
>>>>>> xen/include/xen/sched.h | 14 ++
>>>>>> 7 files changed, 383 insertions(+), 1 deletion(-)
>>>>>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>>>>>> create mode 100644 xen/common/boot_cpupools.c
>>>>>=20
>>>>> Under whose maintainership is the new file to fall? Without an
>>>>> addition to ./MAINTAINERS and without the file being placed in
>>>>> xen/common/sched/, it'll be REST maintainers, which I think would
>>>>> better be avoided. Would it perhaps make sense to have this as
>>>>> xen/common/sched/boot.c, allowing other boot-only code to
>>>>> potentially be moved there over time? This would then also avoid
>>>>> me asking about the underscore in the file name: Underscores are
>>>>> a somewhat artificial thing for use in places where dashes can't
>>>>> be used. Yet in the file system dashes are fine, and dashes are
>>>>> (slightly) easier to type.
>>>>>=20
>>>>=20
>>>> Ok I can put the new file under xen/common/sched/ as boot.c, should th=
is new
>>>> file be under this section?
>>>>=20
>>>> CPU POOLS
>>>> M: Juergen Gross <jgross@suse.com>
>>>> M: Dario Faggioli <dfaggioli@suse.com>
>>>> S: Supported
>>>> F: xen/common/sched/cpupool.c
>>>> + F: xen/common/sched/boot.c
>>>=20
>>> If it's to hold general scheduler code (which this shorter name would
>>> suggest), it shouldn't need any change to ./MAINTAINERS as the
>>> scheduler section would already cover it then. If it was to remain
>>> CPU-pools-specific, then you'd need to stick to the longer name and
>>> put it in the section you have reproduced above.
>>=20
>> In my opinion it is best if the maintenance of boot_cpupools.c falls
>> under "CPU POOLS". Luca, you can retain my reviewed-by when you add
>> the change to MAINTAINERS or rename the file.
>=20
> Yet even then, with cpupools.c living in sched/, ...
>=20
>> I don't have an opinion if it should be called
>> xen/common/boot_cpupools.c or xen/common/boot-cpupools.c
>>=20
>=20
> ... this one may want living there are well.

Yes I agree with you all, I will rename it to xen/common/sched/boot-cpupool=
.c
and add it in MAINTAINERS.

>=20
> Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 08:54:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 08:54:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302745.516471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpop-0007sX-UN; Mon, 11 Apr 2022 08:54:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302745.516471; Mon, 11 Apr 2022 08:54:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpop-0007sQ-RM; Mon, 11 Apr 2022 08:54:43 +0000
Received: by outflank-mailman (input) for mailman id 302745;
 Mon, 11 Apr 2022 08:54:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ndpoo-0007sK-NH
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 08:54:42 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on060a.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::60a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06a519fb-b975-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 10:54:41 +0200 (CEST)
Received: from DU2PR04CA0290.eurprd04.prod.outlook.com (2603:10a6:10:28c::25)
 by DBBPR08MB4888.eurprd08.prod.outlook.com (2603:10a6:10:db::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 08:54:26 +0000
Received: from DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28c:cafe::63) by DU2PR04CA0290.outlook.office365.com
 (2603:10a6:10:28c::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 08:54:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT058.mail.protection.outlook.com (10.152.20.255) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 08:54:26 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Mon, 11 Apr 2022 08:54:26 +0000
Received: from cc78e266f94b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5807EA48-B95C-4E03-A570-D2CCE3E93A43.1; 
 Mon, 11 Apr 2022 08:54:16 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc78e266f94b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 08:54:16 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by HE1PR0801MB2011.eurprd08.prod.outlook.com (2603:10a6:3:49::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 08:54:12 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 08:54:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06a519fb-b975-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jnbKtJligJnRP+5Lj7UlTsJYXM05nvpkuqK7qPSGwYw=;
 b=i8PR6jMAWft4uvIDlAGoTkRVXfd4fBYZbeSPwGGpFEOfAKTTiZTQx2WC/xqGUuuOLD4aQcHhYS7SXgC6cgUvV7wrgb5OeT3CM68pokbiIkTgHqiHPyS4r2dWrjej1fP3x8tn6Zk/oBnNR7eoQNFUSI59yUiQi5b8Rrx7WiBg4UI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 64b73ced43ed90ff
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dF5Cs08mAifiaX3XDxf7VAxLaXvkg6So9pcAZI+l0KEFuBk+1bFs4NuqCgTTNbeMgS9Gy8GiNlquKEgFTrKPoQrF2C/U4m/TmXnkg3EjiAUAoNzuYUPl3Bjmycm6XLrfBQbScDLHBCP0N+iBeaCbwZ5QZaHtCEAd5HrGiRiSMUiZT4yzlCpTIViwa7dVYiwNXaKA1jqBju1MJBtkzL/ibQiYrVB+OP5xJ+MGvAVz5iF+3CwMM7OME3F6GaK/JnehbxbqQZc7GVWoCdItQE+mUUwnAnpGlE/18wUAq9QaUQ7SfRG8bbufW8RRtUwPuKzKdakTwkkyAeaeMtGQTvipig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jnbKtJligJnRP+5Lj7UlTsJYXM05nvpkuqK7qPSGwYw=;
 b=E/FK8cvdnKedKxBb3lPLG3IdDEWvFXWbDf8fHrfE2bNrpIr1Udvjy18/UzwzbNze5ApOOe6TLFerT+wLoOCFn4nufjkadRp7/MKQbL1niJbTTYMNUw+qAN/Sj79d+XB29Vc6dgca9fnPeSOqzZTS9wKRf9n/2rFxwASGViZzK3spCnRUNHEfPq/M7fuVqKFjn6dLMPkYGjAm/COM9Ysp+wsczaQf9ewrnLX1QGeFrQvzqqzXDbiG3HejnGGQZQbhPgJH+5/kTH6cHbyDQ955ohXand9c3AJWwx1D3Tsf8M7ySqAiXGQZojfCnHFxButQxpDH2F4A7QujL3KWRI9TTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jnbKtJligJnRP+5Lj7UlTsJYXM05nvpkuqK7qPSGwYw=;
 b=i8PR6jMAWft4uvIDlAGoTkRVXfd4fBYZbeSPwGGpFEOfAKTTiZTQx2WC/xqGUuuOLD4aQcHhYS7SXgC6cgUvV7wrgb5OeT3CM68pokbiIkTgHqiHPyS4r2dWrjej1fP3x8tn6Zk/oBnNR7eoQNFUSI59yUiQi5b8Rrx7WiBg4UI=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Thread-Topic: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Thread-Index:
 AQHYSyUS0CLVSvR2nk+ITbzc2Ry0wKzlusgAgAAH7oCAAAy5gIAADjGAgAAPS4CABIA3gA==
Date: Mon, 11 Apr 2022 08:54:12 +0000
Message-ID: <DC3522A8-ADA1-4F6A-A3CF-C8095C2F639D@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
 <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
 <cacbaa1c-8ae8-9314-9364-97e5a53d876b@suse.com>
 <61DEEA58-E570-4FEF-9B71-27316C7F8D7C@arm.com>
 <0a85f239-dbf8-2e06-0158-75a1c1c40a4c@suse.com>
In-Reply-To: <0a85f239-dbf8-2e06-0158-75a1c1c40a4c@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 12378a40-90fc-4ce9-6df5-08da1b98e1d1
x-ms-traffictypediagnostic:
	HE1PR0801MB2011:EE_|DB5EUR03FT058:EE_|DBBPR08MB4888:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB4888186D7D4054FE6903416BE4EA9@DBBPR08MB4888.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 lR6z9WrIE37VU8KW0IgYjIk1cX+IpDizXpqKITctyG01jzwL4oe5nyVjO8qH8N9ddAGZ8IgPloC3zzKBxFJf9ut7dfhxNm07n0vWJTCtrV8NYqSDW0HEqVeVF++7RfD57mAXQ1md+ZaWv+DnSsklHh2SHmhQow2JQXoW1mxCtcPIkoj9HsK4mY9Qf3W6DH+TD/FTZU6niIdECQhg/wuWpkQYXDnpIwXr1Fw10Ptj+jkkwg2pK/jGuUZOMs9gj2gwMuJjJbX7WTCUI5SZO96k4SmRY8C7XnrZzPUUgyf55g0prY8QPwk6O+8LUONY1xAthpe64q5fplUSBMFF9a0LlYITeYKtfTePF12/aJ8I57cDl04H15BuSa6oWVOGaZmovuzCcIdUEXu75JmuQYRnZmiiJXZ2xN7EfLJ9+Z5YxXTS0Eo9HH9ctV1pYk1Lf0PMoAdzEEKk3AavoP60PNwG576362aPcGIUYcw4ZVOf2uk6TKPYItGGNv5tvIcY/ekuKtOYEH6itbHbSn+SFD9recwWfdrV/9aEGeIJ5H0UzYUcKQmOXSK4ZNP2WPKcKU3Q5kA7bu2hBFei1q6y8Gq5FAlq7yFBiAaDoS+B+f0O7Y+nm9YVzx8ODeobfEAZMnqJn7i3Jmmjjm90ZFpM4M+XGF38j/3SxlkWJYfk4+TfN26c3UBpkvG7Ef4QoIpHgurNYohpDFi3juxVSS7nnEm3ASCVYxT0k9R5u7IzygAa5QrWDoXBx5nC2LkSXFBKLyw5GkY/QC08YIFJ841gjwQmCw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(26005)(186003)(91956017)(66574015)(6506007)(38070700005)(83380400001)(8936002)(86362001)(76116006)(64756008)(71200400001)(8676002)(4326008)(66476007)(66446008)(66556008)(66946007)(5660300002)(2616005)(122000001)(6486002)(38100700002)(508600001)(6512007)(33656002)(53546011)(316002)(55236004)(2906002)(54906003)(6916009)(32563001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <B3F9250C6BF41C4FAF741EB8BB592BD7@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2011
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5efc6448-1fa1-4c76-caf3-08da1b98d9a7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	M4cjj0u4JKBaVIQLKZq1BRbz+5vcaY4ge9XMoluwKnaD7mamMZ/Bzb6PgcGwR4g31xobrtCwmYiOgtH8TvzztXRNvrclRntmINHwkqCwMBFPGxZ4fo6XrXigRnpkOzaODG8eFs78ap0eG9esJLixRfLdiXbumHtrFgsbxWCvF37B/yv7et+aXQk2NrcB8JaUZ40ZUB7kGRy6Ji+6pu5qoUT+ocOxZGJmXALw8aRS33Hwx0qJOEGkdF8VkuCztcNMB9J+RgKGCC37QJpeJQ8MuVCx003nMMGZRnSM8VaSVmeF+oq9TWDmEezBuqd3XFqKRE9AJR5wYarq+1lVa0okKAAgEWnR6go6JIepbMHOWIaq0VNQQWubXi6/SHJwED2Sh0i6HpD6eeQ2/sbbZEAp82h4ag3+NB30UjtvfYb5r2ZwmSXyu15CjyJh45b+PYGgN24bEWjBoQF+rxnM7b6gnK21/kXmaKsdYyvKunp72AWiXYq5ePvZMaqCn3248Cdv+Jp29wZi+F9D5uRDyfbnxGCVSNT03v64B5GFBuT+4YtzOI/LTOiDYR5uweWfDqVvDj1EhR40R63sHr1/LPHwiv1ChiAEPKycgIByHXtlwGvzMso+euwNV4EVZMAO25/Y7B2KoRKFNVmtUIrnDoRO1jR+Yz6TTDYzq2hTWEZcJIBM6vfqeE7KlfbG4yvozI795i2TL4o8YC0NKHFqlB0P+g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(26005)(40460700003)(54906003)(66574015)(6486002)(186003)(2616005)(47076005)(82310400005)(33656002)(336012)(36756003)(36860700001)(508600001)(6862004)(8936002)(70206006)(70586007)(81166007)(2906002)(8676002)(5660300002)(356005)(4326008)(83380400001)(53546011)(6506007)(6512007)(316002)(86362001)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 08:54:26.3767
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 12378a40-90fc-4ce9-6df5-08da1b98e1d1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4888

DQoNCj4gT24gOCBBcHIgMjAyMiwgYXQgMTM6MTAsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl
LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOC4wNC4yMDIyIDEzOjE1LCBMdWNhIEZhbmNlbGx1IHdy
b3RlOg0KPj4gDQo+PiANCj4+PiBPbiA4IEFwciAyMDIyLCBhdCAxMToyNCwgSmFuIEJldWxpY2gg
PGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiAwOC4wNC4yMDIyIDExOjM5
LCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+PiANCj4+Pj4gDQo+Pj4+PiBPbiA4IEFwciAyMDIy
LCBhdCAxMDoxMCwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+
IA0KPj4+Pj4gT24gMDguMDQuMjAyMiAxMDo0NSwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+
PiBAQCAtMTA2LDYgKzEwNiw4IEBAIHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiB7DQo+
Pj4+Pj4gLyogUGVyLXZDUFUgYnVmZmVyIHNpemUgaW4gYnl0ZXMuIDAgdG8gZGlzYWJsZS4gKi8N
Cj4+Pj4+PiB1aW50MzJfdCB2bXRyYWNlX3NpemU7DQo+Pj4+Pj4gDQo+Pj4+Pj4gKyB1aW50MzJf
dCBjcHVwb29sX2lkOw0KPj4+Pj4gDQo+Pj4+PiBUaGlzIGNvdWxkIGRvIHdpdGggYSBjb21tZW50
IGV4cGxhaW5pbmcgZGVmYXVsdCBiZWhhdmlvci4gSW4gcGFydGljdWxhcg0KPj4+Pj4gSSB3b25k
ZXIgd2hhdCAwIG1lYW5zOiBMb29raW5nIGF0IGNwdXBvb2xfZGVzdHJveSgpIEkgY2FuJ3Qgc2Vl
IHRoYXQgaXQNCj4+Pj4+IHdvdWxkIGJlIGltcG9zc2libGUgdG8gZGVsZXRlIHBvb2wgMCAoYnV0
IHRoZXJlIG1heSBvZiBjb3Vyc2UgYmUNCj4+Pj4+IHJlYXNvbnMgZWxzZXdoZXJlLCBlLmcuIHBy
ZXZlbnRpbmcgcG9vbCAwIHRvIGV2ZXIgZ28gZW1wdHkpIC0gSsO8cmdlbj8NCj4+Pj4+IFlldCBp
ZiBwb29sIDAgY2FuIGJlIHJlbW92ZWQsIHplcm8gYmVpbmcgcGFzc2VkIGluIGhlcmUgc2hvdWxk
IGltbyBub3QNCj4+Pj4+IGxlYWQgdG8gZmFpbHVyZSBvZiBWTSBjcmVhdGlvbi4gT3RvaCBJIHVu
ZGVyc3RhbmQgdGhhdCB0aGlzIHdvdWxkDQo+Pj4+PiBhbHJlYWR5IGhhcHBlbiBhaGVhZCBvZiB5
b3VyIGNoYW5nZSwgcHJldmVudGluZyBvZiB3aGljaCB3b3VsZA0KPj4+Pj4gYXBwYXJlbnRseSBw
b3NzaWJsZSBvbmx5IHZpYSBwYXNzaW5nIENQVVBPT0xJRF9OT05FIGhlcmUuDQo+Pj4+IA0KPj4+
PiBQb29sLTAgY2Fu4oCZdCBiZSBlbXB0aWVkIGJlY2F1c2UgRG9tMCBpcyBzaXR0aW5nIHRoZXJl
ICh0aGUgcGF0Y2ggaXMgbW9kaWZ5aW5nDQo+Pj4+IGNwdXBvb2xfaWQgb25seSBmb3IgRG9tVXMp
Lg0KPj4+IA0KPj4+IEJ1dCB3ZSdyZSB0YWxraW5nIGFib3V0IGRvbTBsZXNzIGFzIHBlciB0aGUg
c3ViamVjdCBvZiB0aGUgcGF0Y2ggaGVyZS4NCj4+IA0KPj4gRG9tYWlucyBzdGFydGVkIHVzaW5n
IGRvbTBsZXNzIGZlYXR1cmUgYXJlIG5vdCBwcml2aWxlZ2VkIGFuZCBjYW7igJl0IGRvIGFueSBv
cGVyYXRpb24NCj4+IG9uIGNwdSBwb29scywgdGhhdOKAmXMgd2h5IEkgdGhvdWdodCBhYm91dCBE
b20wLg0KPiANCj4gSXQncyBhbGwgYSBtYXR0ZXIgb2YgWFNNIHBvbGljeSB3aGF0IGEgZG9tYWlu
IG1heSBvciBtYXkgbm90IGJlIGFibGUNCj4gdG8gY2Fycnkgb3V0Lg0KDQpZZXMgeW91IGFyZSBy
aWdodCwgaG93ZXZlciBJIGRpZG7igJl0IHNlZSBzbyBmYXIgdGhpcyB1c2UgY2FzZSB3aXRoIGEg
ZG9tVSBhbmQgdGhlIHRvb2wgc3RhY2ssDQpwcm9iYWJseSBiZWNhdXNlIGl0IHdvdWxkIG5lZWQg
YWxzbyB4ZW5zdG9yZSBldGPigKYgSeKAmW0gYXdhcmUgdGhhdCB0aGVyZSBpcyBzb21lIHdvcmsg
Z29pbmcNCm9uIHRvIGVuYWJsZSBpdCBhbHNvIGZvciBkb20wbGVzcyBkb21Vcywgc28gbXkgcXVl
c3Rpb24gaXM6DQoNCkRvIHlvdSBzZWUgdGhpcyBhcyBhIGJsb2NrZXIgZm9yIHRoaXMgcGF0Y2g/
IEFyZSB5b3Ugb2sgaWYgSSBzZW5kIHRoaXMgcGF0Y2ggd2l0aCBqdXN0IHRoZSBjb21tZW50DQpi
ZWxvdyBvciBpbiB5b3VyIG9waW5pb24gdGhpcyBwYXRjaCByZXF1aXJlcyBzb21lIG90aGVyIHdv
cms/DQoNCj4gDQo+Pj4+IEkgdGhvdWdodCB0aGUgbmFtZSB3YXMgc2VsZiBleHBsYW5hdG9yeSwg
YnV0IGlmIEkgaGF2ZSB0byBwdXQgYSBjb21tZW50LCB3b3VsZA0KPj4+PiBJdCB3b3JrIHNvbWV0
aGluZyBsaWtlIHRoYXQ6DQo+Pj4+IA0KPj4+PiAvKiBDcHVwb29sIGlkIHdoZXJlIHRoZSBkb21h
aW4gd2lsbCBiZSBhc3NpZ25lZCBvbiBjcmVhdGlvbiAqLw0KPj4+IA0KPj4+IEkgZG9uJ3Qgdmll
dyB0aGlzIGtpbmQgb2YgY29tbWVudCBhcyBuZWNlc3NhcnkuIEkgd2FzIHJlYWxseSBhZnRlcg0K
Pj4+IGNhbGxpbmcgb3V0IGRlZmF1bHQgYmVoYXZpb3IsIGFsb25nIHRoZSBsaW5lcyBvZiAiMCB0
byBkaXNhYmxlIiB0aGF0DQo+Pj4geW91IGNhbiBzZWUgaW4gcGF0Y2ggY29udGV4dC4NCj4+IA0K
Pj4gT2ssIGNvdWxkIHRoaXMgd29yaz8NCj4+IA0KPj4gLyogRG9tYWluIGNwdXBvb2wgaWQgb24g
Y3JlYXRpb24uIERlZmF1bHQgMCBhcyBQb29sLTAgaXMgYWx3YXlzIHByZXNlbnQuICovDQo+IA0K
PiBIbW0sIEkgbWF5IGhhdmUgbWlzZ3VpZGVkIHlvdSBieSB0YWxraW5nIGFib3V0ICJkZWZhdWx0
Ii4gVGhlcmUncyBubw0KPiBkZWZhdWx0IGhlcmUsIGFzIGl0J3MgdGhlIGNhbGxlcidzIHJlc3Bv
bnNpYmlsaXR5IHRvIHNldCB0aGUgZmllbGQsDQo+IGFuZCB3aGF0J3MgdGhlcmUgd2lsbCBiZSB1
c2VkLiBNYXliZSAiQ1BVIHBvb2wgdG8gdXNlOyBzcGVjaWZ5IDANCj4gdW5sZXNzIGEgc3BlY2lm
aWMgZXhpc3RpbmcgcG9vbCBpcyB0byBiZSB1c2VkIi4NCg0KVGhhbmsgeW91LCBJIHdpbGwgdXNl
IGl0IGFuZCB1cGRhdGUgdGhlIHBhdGNoLg0KDQo+IA0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 08:57:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 08:57:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302750.516482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpr1-0008T5-Ae; Mon, 11 Apr 2022 08:56:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302750.516482; Mon, 11 Apr 2022 08:56:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndpr1-0008Sy-7j; Mon, 11 Apr 2022 08:56:59 +0000
Received: by outflank-mailman (input) for mailman id 302750;
 Mon, 11 Apr 2022 08:56:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndpqz-0008So-Gt; Mon, 11 Apr 2022 08:56:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndpqz-0001gE-Fj; Mon, 11 Apr 2022 08:56:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndpqz-0001wS-5B; Mon, 11 Apr 2022 08:56:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndpqz-0000hd-4i; Mon, 11 Apr 2022 08:56:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CAHgMQiFCAaurLZP5Oq/nImBjDBNzwmhS19Auv90Aw4=; b=DWAXII/Omzj6h1mXWGPTU0oSSj
	ht8a+kLOFyucNF4yBcM1Flk1PJQmCr4CKMyCLk1vOMjXWAd5Ll0QzNdFms0zvp65AnBmHz62WLvvW
	XgupChrD7Epqpa+xMLhk0XP1dJdpJyhxfVBiZG2FRciRTXgw9Zvf+ycO8Ut4191JRlIo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169299-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169299: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 08:56:57 +0000

flight 169299 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169299/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  320 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:08:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:08:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302760.516492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndq2U-0001yy-Jy; Mon, 11 Apr 2022 09:08:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302760.516492; Mon, 11 Apr 2022 09:08:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndq2U-0001yr-H2; Mon, 11 Apr 2022 09:08:50 +0000
Received: by outflank-mailman (input) for mailman id 302760;
 Mon, 11 Apr 2022 09:08:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndq2T-0001yl-Cj
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:08:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ff0a3f50-b976-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:08:48 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-sFu5UVvZMKeXuAvNNX9M_Q-1; Mon, 11 Apr 2022 11:08:46 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB8352.eurprd04.prod.outlook.com (2603:10a6:102:1cd::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:08:44 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:08:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff0a3f50-b976-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649668127;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XIOv4TY8WNOI3O99L/i9OSRrC6IBUN87tkTH85j1bko=;
	b=dRcsAp2GZSUWOP7MuAaaxsGPfqyhccTZMonDkqFSrPFiZ1yaoWOoFWq9ovm58qA9BNJqVM
	VT4Z1fnpnKCtiSLSwIyD7d+le+Hf2KatYOQUkQuyXdKnjZfpLEBYGA/LnuynOSax+W4Z3S
	p2rqSq65GVC9AAQgKqT0YIMiIm1Xj3g=
X-MC-Unique: sFu5UVvZMKeXuAvNNX9M_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c4aAVnS+jWfZcJxJ845GzvUoEVcr9/FWljAcbjeOC1fRnMIOvWgx89CFISbGakhbUpZLgI3bqQlGtPUK++lrEsgb1XXtOFm73vlhkcxRVlIUYaXdZX0OoMRMgZ3idydFYunw9dllitdIrmwjcHy9QPZ/dCqi+SzSQlhbZDkZPlI3Ve5OyS932aj4FCFOuHBHmmFUImcZmUBsCL0+nJeDV/xS4HIKb5W+leXUcy62z0okPOZgMxJaZzz1eUxn1VhHWlc/2/Mko9YT0/zZhZePaGiC9c+V9omZnDAbPsYr3J4S3u81xpl6n2Fxa7v9Rvo0ht9zca4UgE3UuOjhrivKIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2YZ+PXvt0qCwoeQxUqlxz4RI7Y0nfk5NPP4ZAfM4xBA=;
 b=JDdLzjfjafk+rmLEwaasR5nC60GR2QPLJ2gfKhh1cJPhCjN0jgC4r+JXVzA314LxJP+cEP53neFqobjV4LViJjjJZ23K/OguYqvzY8MMbc98uiXnYzoQwrn4fr7hhdcXRmajEchRUX2Nh4HhrovpTULvcv9Z3dcIUwQHEQTk7SFuPF73IacHRAnNzmojgZGpXtXRNSX4ErlXjbSfJaOxu9+gpm00vaxgShkcoQ0nCIfZ5DyVUXLLyMZgERvr6bfx2sw3iermmvXeZY5ZVHeCSrPObT/PnsZXla1m6+R9y35sKGocGetZKpTXoAzgyhRMkc2UfNCRAxs6hQC+rIZAqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e6450fd4-662a-abaa-4b9e-1d8a4ff41962@suse.com>
Date: Mon, 11 Apr 2022 11:08:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: Juergen Gross <jgross@suse.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
 <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
 <cacbaa1c-8ae8-9314-9364-97e5a53d876b@suse.com>
 <61DEEA58-E570-4FEF-9B71-27316C7F8D7C@arm.com>
 <0a85f239-dbf8-2e06-0158-75a1c1c40a4c@suse.com>
 <DC3522A8-ADA1-4F6A-A3CF-C8095C2F639D@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DC3522A8-ADA1-4F6A-A3CF-C8095C2F639D@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR05CA0016.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::29) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d6cdbbd6-38a3-4e6e-b635-08da1b9ae0bd
X-MS-TrafficTypeDiagnostic: PAXPR04MB8352:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB8352C473A2900E3E5EE9069DB3EA9@PAXPR04MB8352.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uVF3giGG8fjApUNrPZgybxcVIGa5pVOqkyWiSv23vJaawajlu60+MN0u83pKXBL1Ujn6ekcfezONBCpQOWG9jaJblwBZwN4dGtDlht0fdd5mw5sxmj37BPC1xaEUOeUX4ujK+9UJg1w+BPGcbN3wumEssPqoIumELtB2MXpOA+wC9Y7jUq22wIp0WGoBh8CZP2i/YBoCABGXDnQj2CAv65hPfN+usT5MCQQRcy3uA4PdFtaoh6zF3j9qQFwC5KhnAEjpSUeZduHt9n6XhorpMmt3x0LTgK8PTAJvrsz2GZqwEvKftZtkDifnORHv3B6a0pCGED8aW68zwenHQiOQuL6/WQsi+jEzFmsTAuU3UHtiaZhnQNKfk/9KcFcJ2tCpNMiX79NC4n6PhxFVZ23zgyRZUnys4EWN+QVo35ku9htqI4pGrVKocoZ2ckXS6ux9r6sscA97tFUKkV2XBgRg6p7YApwKIbhMGo+4VeRbUoNBw41gYNTI9O8lIj/NWUpkAm3zqIzmy69kGzkmmayqPZEYjKBr8VLo2BXObRi1XkwfareslYOxbqyE0jHrOKoyi6loGqKCh9AgGmHyp24CzI/kB9fOOKja8IwYIbAipJIvmrqsgH5o4SNkuUSNqM/bgoAwRShXhwk1kJVbAg2ISaYUexqTvt9ZcP3Ut7uRGj1+UMnWX9sNndg84caOjokws6sm540Z8tv2+Oly31Z4sKxYWo0g8AcfQu40Zjkgne21bBhgGvcROUo3Ecmtaz5gKJsFSRT00UWXUd81eqTt/w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(508600001)(86362001)(6666004)(6486002)(66556008)(316002)(54906003)(6916009)(53546011)(6512007)(66476007)(31696002)(66946007)(4326008)(8676002)(5660300002)(8936002)(66574015)(38100700002)(31686004)(36756003)(83380400001)(186003)(2616005)(2906002)(26005)(7416002)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OoSUEkpYl9lXFumFhRxNyKxpyFt3WJcjCC55xSd2MyypcUAUI9vGPtMuDawf?=
 =?us-ascii?Q?U4POnVvK3TAj4h5rkNOcjKsg7Tv/axLSMcTe+nn2pn5MP78xGySNkB6iwUAW?=
 =?us-ascii?Q?z8qzMgoxtIssgAV3feQIAbJLgpXM3h+FOtV8J+lbKvBZuy5nVrpJuaHcG02Z?=
 =?us-ascii?Q?XQQvlTkUmK0QxU1CjhR1c6AoIMjP3myFrkBkOmAsAlFBHdLXtKnaWsK5rc4R?=
 =?us-ascii?Q?BJLoUWjTPAqDvWI5Swc9JWS8Elv6Dyk0vqyW021bXo4jX2sK9pO1YIRI1m/Y?=
 =?us-ascii?Q?bytCMTX4X8Dz0RDN9ZvJaQiY3qX8sXJAKt98tYEhOTLRWhIBe+ognYGzi5Px?=
 =?us-ascii?Q?xTkf2e6sh7g0n3Wx/UZDPhLE6zf5j/W30Q9Z1rEvg4TDeK6RwRFqPcOHAUPy?=
 =?us-ascii?Q?JDp9H55E8c18BsB1RjRm11FvBY4v2v3qyXt8lIupwiJLgfO7sDTGb8s7gyFm?=
 =?us-ascii?Q?VY71qFSr9mlXeMg87IcVGppx4kiZ8Y9nsBYxdsu1ZmK05xEFNz/+/egv5dlh?=
 =?us-ascii?Q?Iw9Bb0z7jqu/GI5ulUmyQJ0/6LrXGULEWeMqRj380VRTr0yWyl1jVxSDhypj?=
 =?us-ascii?Q?Am5i4pKXOeSPJZgb0gt04STnmkwS0otQQDDnvxj3Ggbh1R4iuVpaQadzDdvb?=
 =?us-ascii?Q?b5XMe/cRNr3TdBrXZYyc+N/XfPjD5VjIx6vUxjhGgYlSfkNRYjmLBsPzK48Z?=
 =?us-ascii?Q?UP/l1o0h+aqy/9OFVxVGHjT9Zh1+b3j7Mrb7TlhUj3BXfrFmNmz+QiF/07tn?=
 =?us-ascii?Q?hu74uKX/WanGiHhzriZEQZCcQvjQokK6ePp7KpVSJIvL9s3Xm8yOi/ctXy2D?=
 =?us-ascii?Q?c3d3QiRvWaOGa+2aymhqlMQRx9e+WbMEmqVPZPeX2V1zH92muaiKjJ6TS39V?=
 =?us-ascii?Q?Io6jd/kWqj+rQ0oNu/wJ1gf31+iIcePBklApkSbkbr+zPn8xEqYq4IK/kPP2?=
 =?us-ascii?Q?88Vy5nO+9gmx41xzB+1FHUSx/dzpmZjsMqqBzwcJ7ElEJ+ZbO3a8r5d1Gsgp?=
 =?us-ascii?Q?tFEKmgFe5XPAIm7+nvdx189qNKwdOg28q/a7b3E8TtQFOoLeltvb3QlnHgiz?=
 =?us-ascii?Q?WFuuDGHvH5dpdT9eXkSULKL8meBv2da1S/jwpoYzlaHSgmLWCU1OdC/mCE2b?=
 =?us-ascii?Q?GNpt3isD8zcZ7fyFgdR4aqIqJUqXo8vitWw4gl/WcBJJyOGP4Q28VKb6A50q?=
 =?us-ascii?Q?Pb/fFTQc2UX9rYgdyPyjlWBjuSmlGoCa5dZ0QETHoZ7BzoWLVgBfu2KQBzZi?=
 =?us-ascii?Q?RAf/VQfFqyl3hv+lAxAaIziJ92zBpWSNgR9dy/RSIzh76/HfrqAVMMxiZy2I?=
 =?us-ascii?Q?8yosNR/YdQanoQkB/l9hvjICx+4qFiTM6T55TjDH58fbIfGyUFM4ezQXBJ52?=
 =?us-ascii?Q?NVTNrXEumSHGLhAmqoshZ6VMCGc1AEANQEQTdYYvOvbH59t4IyqU5YqdDb1R?=
 =?us-ascii?Q?qtnJwbgsPZR0NJVtF9I557Xla8xi9jFDQbPr7zXVj+8pNZSKoK36MOl7fcfS?=
 =?us-ascii?Q?nxiSSMj2dvJDW7gtbeTEMCGlJsZkE+SDXDhXKN2NUvQm+uqLvB/9xdxtrsej?=
 =?us-ascii?Q?2MImSgfNKcK5F2ZmyJUmY8xaQNXoKPLXO0kN4yzTwsv0KmH97VHhZXiWn1VT?=
 =?us-ascii?Q?z7pldFj2UDphS01+t4DcHsFAv60zc3aml9wnsqA8ZvU+YVgE7KXXwF9+NTJ/?=
 =?us-ascii?Q?h1cPXA3OhQ6SdAhY4my6Z+ILN8Wc/aXWoUwkSg4uBePQQkZRF6S0ioWPBL2o?=
 =?us-ascii?Q?FR6uNsrFMQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6cdbbd6-38a3-4e6e-b635-08da1b9ae0bd
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:08:44.7388
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tgZ6s1SG7pi0mS/VUAy/S/9PkgwO1CudkvW39IZqsy+ojKLeiE4Hp7Zg5YKMFGSyQBnD8tso5hOw69mVLjA3IQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8352

On 11.04.2022 10:54, Luca Fancellu wrote:
>> On 8 Apr 2022, at 13:10, Jan Beulich <jbeulich@suse.com> wrote:
>> On 08.04.2022 13:15, Luca Fancellu wrote:
>>>> On 8 Apr 2022, at 11:24, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 08.04.2022 11:39, Luca Fancellu wrote:
>>>>>> On 8 Apr 2022, at 10:10, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>>>>>> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
>>>>>>> /* Per-vCPU buffer size in bytes. 0 to disable. */
>>>>>>> uint32_t vmtrace_size;
>>>>>>>
>>>>>>> + uint32_t cpupool_id;
>>>>>>
>>>>>> This could do with a comment explaining default behavior. In particu=
lar
>>>>>> I wonder what 0 means: Looking at cpupool_destroy() I can't see that=
 it
>>>>>> would be impossible to delete pool 0 (but there may of course be
>>>>>> reasons elsewhere, e.g. preventing pool 0 to ever go empty) - J=C3=
=BCrgen?
>>>>>> Yet if pool 0 can be removed, zero being passed in here should imo n=
ot
>>>>>> lead to failure of VM creation. Otoh I understand that this would
>>>>>> already happen ahead of your change, preventing of which would
>>>>>> apparently possible only via passing CPUPOOLID_NONE here.
>>>>>
>>>>> Pool-0 can=E2=80=99t be emptied because Dom0 is sitting there (the pa=
tch is modifying
>>>>> cpupool_id only for DomUs).
>>>>
>>>> But we're talking about dom0less as per the subject of the patch here.
>>>
>>> Domains started using dom0less feature are not privileged and can=E2=80=
=99t do any operation
>>> on cpu pools, that=E2=80=99s why I thought about Dom0.
>>
>> It's all a matter of XSM policy what a domain may or may not be able
>> to carry out.
>=20
> Yes you are right, however I didn=E2=80=99t see so far this use case with=
 a domU and the tool stack,
> probably because it would need also xenstore etc=E2=80=A6 I=E2=80=99m awa=
re that there is some work going
> on to enable it also for dom0less domUs, so my question is:
>=20
> Do you see this as a blocker for this patch? Are you ok if I send this pa=
tch with just the comment
> below or in your opinion this patch requires some other work?

Agreement looks to be that there should be precautionary code added
to prevent the deleting of pool 0. This imo wants to be a prereq
change to the one here.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:34:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:34:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302766.516504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqR0-00069X-Jn; Mon, 11 Apr 2022 09:34:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302766.516504; Mon, 11 Apr 2022 09:34:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqR0-00069Q-FQ; Mon, 11 Apr 2022 09:34:10 +0000
Received: by outflank-mailman (input) for mailman id 302766;
 Mon, 11 Apr 2022 09:34:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqQz-00069K-Ci
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:34:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 88adf788-b97a-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:34:07 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-Jc6-WFooMp6Fz4mFDX6aMA-1; Mon, 11 Apr 2022 11:34:05 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB4764.eurprd04.prod.outlook.com (2603:10a6:10:15::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:34:04 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:34:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88adf788-b97a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649669647;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=vL+0lAdAy+jFrgQqabteiiHQd+v0n6xUZT0vrkZ128o=;
	b=kvlxTNf0QXpGKVmr4jmFZfxPwt0JBGRYLjnyi2UJ1wOBAGF11vglRN5tkW4U5laRvlQZXU
	GfjuKVUFOkLBX/oUdOUo6Gij8vgBFEmtqT6LtJB5JqNq8I52EBFmRShR3nArfF4HsE9RPa
	B71EYRWcVyxh6UFPzBsz0or4o5euqfw=
X-MC-Unique: Jc6-WFooMp6Fz4mFDX6aMA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jIFr02GdJSiIq2zjPGGBcxbGQSXPQrVoRVDzNrgVMFzs+kri7ZTdFXDqpxnyc+Vb0DwZZ6eJ9Zs8aH2ReG9Xt2/UYhNsgb16PqPtT9VNmjCx9xOZgBvGtYV5HuUkUFmQ03GWxh1EOnD2yrGaXJKEtzJPz8/9cAfJtEE8MIGvqHDAJ3tF/w4kkDQt+9WeJsGHCFJlREYuHIQIQogrpgAxanJrsJ8utYHGm2xn9qc9KCplUevuOSrBFmgdjbxiI3pUjpSq+Uryny1AjstsOs8WrZDMZvfEI280TfCyGKWc0I1hmy+F3eWlcdcwfiOgwotbhFMHF3NRD2vLyuit+ChM3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vL+0lAdAy+jFrgQqabteiiHQd+v0n6xUZT0vrkZ128o=;
 b=cEfd7nlA9zmMBifiyco3Y52mX9kmeBPPHIt5xINOhOcgb+NtDnOAFFPFRIJGWdYim7joUhjhz4cm4dr70BDuTXbeQ5Y8iD+em/wbXkim/6vBj+zOqEZVq13dnxzs48X5HqM54MLYhT2EBRBTwoNLGy4a1VIMpXJBuK5c5gDs4lG/987c36XHJyt589xu7R1DxekHYtsnbQat1dSTl4/JvSx0yxQ3K35rVpW9JNcys/0PV0RJtqAawQS6PEHK+1tUfvVOACqh4KILHoZvEy4qN/rhqS4X9yPCVuU/AWp7F/padyvDgvZljHA3Uo69cz7yAYrY6bWN6dYjqc5VfsGF0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Date: Mon, 11 Apr 2022 11:34:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/8] IOMMU: assorted follow-on to XSA-400
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0077.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0a62e83a-81d7-4b46-1b28-08da1b9e6aef
X-MS-TrafficTypeDiagnostic: DB7PR04MB4764:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4764A8AEA37ED4EDE0DBE2AFB3EA9@DB7PR04MB4764.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uTQKii6+2FUFBb1/t6GLTyEfTusNGoIj3qHGnQ00iCiNLbFacOjW3FfO5cL6oo4NMyVt9j+grC+NrCCA9DHMz0XsJ40a76yIgdr07lSSMrrEjyCrqKQmDaSSR3Ye3vM++DRnIL9d23bwKaJScqy7tU3JWhAImbzvCYs9UNYZntnllq8SeZBH/fagvdMf50X3HHHqiOhhzGlg5Ia/YmrBiv/s/PQoUdryP8/hSpo8DnQKdTOoD+v93Dds2bso2rwhTm5QijAOgzhTgZGoByeZwJ6h8++VVR7MUkLal5N6UelAxb0IGXIElx+zkmBe8Q+gNsfObN6eNRCkJWrAfrxVbxk9QXqf0dtsHm88GbKBmAM4/zwQsh2uZPYxHwUArEU9Dl9IsYQMaFamSQXT6ga9XF5FynK208FPQ1c3WmfknmBRbYVFjFUcBaK+q+3Bhm9+AEbyjcCIxOMh4AkiTjCm8eN5Shax1N0Subjf+vejaAzuS96flASJ7DtUDAYQI99VvvkUsIumuB3//nY3y21MiyKZQ3iQB7Ut2Fa9eI5I2ynL/nmQFI3t9RodTj46wiWYFy7r2AjmAWRbx5CErcG5Dih3wC3WNvGxY5Xw3QC8pw15fVS/vYF3/pSuWu1hox0+EUEUxc0uNeDo/ptmdQcvGMOuKT3X+nnOO2wk6TzUB8pTnBVBHUV/600d45BqP/XQL5Qf30rSMUK+KC9qQANPutwrvDWhT2LAFevnANvLOIQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(8676002)(66556008)(66476007)(66946007)(31696002)(4326008)(8936002)(508600001)(2906002)(2616005)(4744005)(6486002)(86362001)(6512007)(6506007)(31686004)(316002)(38100700002)(6916009)(54906003)(26005)(36756003)(186003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eVhZanNOYzFZVGtUbHZUeCsxaENUdStSQUptY3FvdUt5UndBSHExNVJPaFNO?=
 =?utf-8?B?cHVvcmZicFExdXcvUTBadCtKU2hqc3R0SnZpLzgzZkNpVjlsRzltY205VGk2?=
 =?utf-8?B?RE1qMXpJcHZFUWEzUkN5aElSV2F3dHlCSVRxTXZRSWRZRlZ0SC9peGdGbFl0?=
 =?utf-8?B?UlZpaGlyQ2o3U2MvQldmQjhpWkRlWDlveGZMQUxGbDJyaHNieHdSZDNxRUEr?=
 =?utf-8?B?QS92bDMrTHZWaTNoM3RTbE83M0ljOEhPQXVGNEttamtXaFRpWjBUWjlRR0x3?=
 =?utf-8?B?clpQclNYeFJycHdNS2tXNSs3a0pUbHdwSjhFQXAxTmVXaEQ1S0N1K3hUbFA4?=
 =?utf-8?B?QXEzNW16Z3cvanAvdmdIUm5XNzc1SVdVZ2dpcWhEd0lCQlJTV0hzMVBjOVQw?=
 =?utf-8?B?YWdDNjlab00xc2RmMmIvRm94bWhRWGt4Rk5Lak90blBVK01ramVYc05JM2ZT?=
 =?utf-8?B?ckRmQ3ZkNDNFV2s0c0tXM2ZqYm5MOTRYOWhrLzVFc2RKTTFkT2sxWUxlNmhn?=
 =?utf-8?B?RklOUG5FZStrVWx5VlBJTDhIb2dLSTZWL25SMXBWQ3Z0Mm1qbS9VRTlGL2VB?=
 =?utf-8?B?ZU5pajM5WDQxaE9WTGxWU29jdExrTXppYXZiZ2wzZ3BCNlBOTC9xMGtQaHZt?=
 =?utf-8?B?NDV6OUdCaWJUUzNLajlsdnB2UTNLMU9waVQyNHd3T0g5Wjlrc2ZoT2lTM0la?=
 =?utf-8?B?UmNYWXFwWEMxV3EvWkpUNEQwWFcrNW92M2orU205NXpCbk8wN0UvMm5iTjNh?=
 =?utf-8?B?eGlQY1dlbTg2dko5b2RtclI3c3lpYlI1Y1pwbU1KSU5QWm45cWgrK09FYk82?=
 =?utf-8?B?U1ZGdkdRRU14Y3Bsbk9nbVpWeTRzVmc1MFBUTFlXZ21PdjVaYUFiTTM0TzdB?=
 =?utf-8?B?cWVYZ0NvSFNzZVliOXBHTDdzRjJCQnh4cGlST2N0ZjNqeWFsZUx5RmV1Y25u?=
 =?utf-8?B?dXFqeGFXcWdxSlMwd3ByRGE5NGMxQkpldzJVZzgrcklkRnprM2ZQc3djYzht?=
 =?utf-8?B?anFpY1NHaUJzNnVUbUZaWTRIcDkrWlkxRjVHSHE2QmxlWGtFNmx2NmJLMWpT?=
 =?utf-8?B?WmZ1Tms0WTd1eEo0bjFYUUp0R3RqKzdSbGpaY3FaeFoyc3RlZkFZN0c4ZjZZ?=
 =?utf-8?B?Ykh6Q1pGL0VjaW5Obm5aR1V3dEtXcGlYQUVEMHNldDNpRDZXU1B2bXd0ampm?=
 =?utf-8?B?T2lWOTJDdGt4azdvYlNOek9LVFdNUlFFb3pEelBEelpVTDBOeVU3TWFMRThP?=
 =?utf-8?B?YnNFR2tRSE1PeFl2R0NGMGdJbzZKTEZXeFFUcnJ3NFFUbmlOZEV2SnNhMlhZ?=
 =?utf-8?B?T09DV1lOaHJaa2R2M2J1UWRpalZpOXgrNnZ5RjVQZng2YlFBcEJkU2l0ZXhU?=
 =?utf-8?B?NmZSSitUZk9WVmJIY08vSXRCV0gvSS81NWU3cWZSd0Y5MW94TEJ2Y1FSb2I0?=
 =?utf-8?B?amdpMkFtYWhxZEJQSkVINEFCd3hpR3hKemdsZ0NpRWR0T0F0NzcwR0lXVERv?=
 =?utf-8?B?Y0NaNDdTZndmL09iMjlxZEdOZTlQSGhGOUVVL0E1em9XWmhFSHk5VDYwUEJU?=
 =?utf-8?B?ZUhuclBBKzBmWnlGUzlLcy8xNFJKMTF2MlVCNmtVRHBHM0dMbmhKK0VBTERo?=
 =?utf-8?B?UXNjZm1QL09tTE83bnU0V0NJTUFUWnhrbWt6dXdvY2VTUjlGODJrMFd5elAv?=
 =?utf-8?B?cXNmcmo3Z0pKVytnNTNSYzFzZmMrd0lFRFhrRm9EcXU5R2FxVFo0c1dVUDF4?=
 =?utf-8?B?T1N0aTJ5ZDR6R2k4T1hZemdacU5QRDRLOTRHUmZ0eWxFYzZOOUpiSXplT1Zk?=
 =?utf-8?B?WWMvelJOSG51SjJrSDN2MkJHQjVob21LS0JXaXlDVlZZTVlMbzdqM2dBRG1C?=
 =?utf-8?B?Nk5ZZUgzMmdWR1g2dkJabFhudjhGMUUweW1RM2R1MWQzallvdWhSdk9GenBn?=
 =?utf-8?B?ZUxoSnZxVTRVU0M5ZHFHam1zR3ZoRjYyTy9iS0hCcUhHUkNwZWhzSlVyVUg4?=
 =?utf-8?B?NEo4TTByNXBXRHZCTU96S2tod2xBblQ2Q1kxbXpPQjZkU0phQWgvdlljVmNl?=
 =?utf-8?B?d3cxekRGK3d2OStiU0JyQjNRT3dzZ0g2UXQwSFdFYi9QTG54VlM2MEs1TkZS?=
 =?utf-8?B?cVBmaUJaWjJBdDk5RXlIQ2VQOS9SZlphL0xBR0JHaGpWdXoyeTkrOXZyaU11?=
 =?utf-8?B?NFBtelU4RXlobEVPLzRQRFUrVWVxUmdsY3hLRG8zRXpyMUFVclpnQUo4UG1w?=
 =?utf-8?B?dnhvSEEvTXMweXlXb3YvbGxYZ1FrQmNHTFdGcTExeCtVcit6WTlSNHlKNmV1?=
 =?utf-8?B?ZFEyUjREc3IycFg0V1NQUEF0Umc2cGFQV1JIcG1lOG9mcGwxQlphdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a62e83a-81d7-4b46-1b28-08da1b9e6aef
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:34:04.0758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +HjWK3pcT5yKNO/T+y8ie7ZZZPk2Ykq9rgRvtTnnKJ5XxSEp0O5K7Jk2KcwiWy0px2MM/zfa/lgxjhS+yheAFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4764

Considering how long it took to get the XSA-400 series ready, it is
probably quite natural that in the course of doing so some further
items were found which want dealing with. There we go ...

1: IOMMU/x86: drop locking from quarantine_init() hooks
2: VT-d: drop ROOT_ENTRY_NR
3: VT-d: plug memory leaks in iommu_alloc()
4: VT-d: refuse to use IOMMU with reserved CAP.ND value
5: AMD/IOMMU: replace a few PCI_BDF2()
6: IOMMU: log appropriate SBDF
7: PCI: replace stray uses of PCI_{DEVFN,BDF}2()
8: PCI: replace "secondary" flavors of PCI_{DEVFN,BDF,SBDF}()

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:36:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:36:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302770.516515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqSm-0006iT-VK; Mon, 11 Apr 2022 09:36:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302770.516515; Mon, 11 Apr 2022 09:36:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqSm-0006iM-S6; Mon, 11 Apr 2022 09:36:00 +0000
Received: by outflank-mailman (input) for mailman id 302770;
 Mon, 11 Apr 2022 09:35:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqSl-0006iD-Ms
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:35:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb03b92b-b97a-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:35:58 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-z2s000aAO1ufW5CdwQdlfA-1; Mon, 11 Apr 2022 11:35:57 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:35:56 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:35:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb03b92b-b97a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649669758;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2I9BVFSj3uMESwf/DYdlBGh3Zmde/zF778cT9zilJi4=;
	b=NPtpcC/JNv7lD/uQJ42bsDO929J+3z+b1sGpY9Mq1Y7TPXRq0olEzPd4GvmgcAYxqfCq+Z
	Egn4f9RA5yZlTZ5LNIsReXvf45KTSTk0JXTIUke8FNbofytJ1MbWDJqQhQVF1+oMMoJZS/
	TvDRxKOuaDZzK/kUx1T/R2ruVm+EyhM=
X-MC-Unique: z2s000aAO1ufW5CdwQdlfA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h+uSVko+/BfXswIpZbkuk5xrFvG9G5Xf1E3mK9X9DDwXMlKw2x8fnQWOD3OEWRvk3dZN/tCJtmJmdStaLCUCI1FjmPIO50lLt0u0q3lrkQW7i8po5xZWu77K6L62aEGgwJspR3pIQMnlScLgxkXMr5l+RChada0CVZePlFukExvl4uDUUpxCT7Vv7QS0vsM1BsX6x0d2UsDFk9O6fpfry2Z/7S53htoUaH2pAzKzDszhX+k0jeBcrD4nKiJzTWxgHvMDrnquna8MAr7dij/a05q5lugbv2W1VIZXDN3r4WFUatPT+tKBFgU+dOC+Pl1YXEHsbmDwTlXKelsZn5jl5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2I9BVFSj3uMESwf/DYdlBGh3Zmde/zF778cT9zilJi4=;
 b=V6r32wYFX387ulMhJDXYbZQM/Zgt/TdIij3xBU7heFsvc+7gsmUiQ41K3jP3VvULrVJls9bwqphtY0XhVqMQli8Qw9044Vbcspi9QaMngHGKVEOioDuE26T6J2TqHVZZKQ4oHkkQ8APkJbB9oF0H4I0b0cRFIJeQ01SJSfJGs2KPwFK0VqCcWJC/4CBIM4RkxScnldVWO5GlDNy8IBmRfw24agVSuR5i1hu9/78Hv8v3yUqo8i8GJSHTqCiJ/vcQ8a0vX0x3M3DmcksNZ/z9kzVo7DMIjTJy1p0YmjZU5AG3tRb0iwY7wOQNHmUvWSxoJhFL+BTo4AwshR33xQ5CLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
Date: Mon, 11 Apr 2022 11:35:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0048.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75629b95-c6e4-400e-cf47-08da1b9eade3
X-MS-TrafficTypeDiagnostic: AS8PR04MB8609:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB860976A91AC57E006FF2958EB3EA9@AS8PR04MB8609.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	indCEcykcUve+DJh6IVeBg2ErQ1W9BtYlxR69aU0VYl68vxjXGlvLblMT5xmKouVHLELpoopHlLP9uHFAk9YMPvmIRE5s5ufv2f55fVWsXbi/WAjQvQq6CoYj/PUZJmGS3rxp2UyN7XpzyjU7aH1YnKRGuRKbEKzpwMeSLidkkWE5OuG8DFNqRwv0b/vDGTl33X5DgFqXuSU+KGqLf32IJI7P5QCDcAV1UujOcM9t/OQrLN+HYAAxC06s/KRX8IvSKjTon8yWVVNbs+tKulov7ht9BT6BTwhFke5OlYyzQQeMipDXRZs6jceH6+PVX/EbdCDLhigW2IHDnyKDuX8DSFWUSakHlGhcu55B+xTosmXVZU2iBWerKdAaiM5VMVcOyNXGnV1Pu65xw44fH3XQER+7C12OH3Pt8iD+yo9T9l3AEMESMA+CW31rWn0JF2e7tfaBGOyNb2VjSu0AmT1V0Ei//rB2L6OJbn8Ce9ZwD+fzNi29HTG7b5F3H2aRi/dBmSj/RzASv3lHvUkJf4keWG9ddvIykD6D9hkThWFQ2UWd/Lsmpy3pXWs3Gikd4l+q6LpEGan1Y+irl2p43QhR75HK05UvGQA0ojv6bV5P5GD1Oi3HEfqLXnm2AGzcr+3bhWfH9KYwd0WsjYLOQZGszj+Ma8CV/j1seKTPlQkN8WMf2pfnR1SNdaIyrooOl2RNIHZCwEVWvWw1HajaziH6cabDlAnpZUf9kASE68Zvgc+IXZkzsZ0DslLJEGi/e0H
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(8676002)(5660300002)(54906003)(66476007)(66556008)(508600001)(6916009)(38100700002)(4326008)(66946007)(316002)(2906002)(2616005)(83380400001)(186003)(86362001)(31686004)(31696002)(26005)(6506007)(6512007)(36756003)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SEhFamRKeWJlamNIU3l4aW56dlBETlBLcjJaOHNZQk5OREh5ZmJaZ3pIZ09S?=
 =?utf-8?B?d2NQV2pILy9EMlgyeGxxbmcxdFJoNHQ1alNUSkhIQlJnazlTSjBkT1hreTRZ?=
 =?utf-8?B?MGFNeU11dG9YaUFpZ2JDbHRuK2sxWU9ZdWpac1N5MDRBMVE0YzRxSFIwZXRH?=
 =?utf-8?B?b1lOV0VncGpncVlZZ3pmQ2V6R1MrYUt0NFA2WG5GSlVBWnRXMVRTZ212YTNM?=
 =?utf-8?B?bXcycnlPbVhmMmJkRWhtei9FWXhmZTZZSlBuN0xDY0w2WGwybWtjcmd3VjdB?=
 =?utf-8?B?SzArWldJcFI4T0xhNHdMMnBRM3RhQmllSVI5TWE0a292cVVOQTVHZXV1VkFF?=
 =?utf-8?B?R3hNaytkMTJ1WUNidkdHVHhRSDBlZXB0UXlZWWt6SFMzckM0Vlo3WmVOdmV4?=
 =?utf-8?B?em5FRTNXcFZCWi9VbUZoNjFGV2VXRVRiUTZINFhjTHVBQjdxMVlvWkc4THlo?=
 =?utf-8?B?M1lOTXVhTkEvVVdjRWVyUVNBSTlxa3BjcWxZTElMNXVXNjBLdUUrNWRIdWE5?=
 =?utf-8?B?WlNHbnNIa2h1N0M4aDgvbXB0WE0xalZGNk1QQlhjZEhSc0NtcGZCeEphV0RD?=
 =?utf-8?B?K05qaUdFYllnYVNSYU9vVWV2aTZuSlRkZmpRVE1HRk05SmdJcGxEcTJPUW9k?=
 =?utf-8?B?ZUFNcXgzL0JSTUZVSXF5Vm5iTGF5RWlPM2dEZUlZVVEzUnJUNTd5MjNLajZu?=
 =?utf-8?B?TGtVNXdWdG1qTmozb1FVVldOSVJWQ0FNbHEySVZQNGU1VVBnYVIzdUdydU0w?=
 =?utf-8?B?VUR5bm1xanFhSVJLYzVSUGs1UUdZS1ZIR0ovWjR5cXlSaVB0V00ydFE5Y0RH?=
 =?utf-8?B?VUFyN3hVUVBNRWdsSnl1SXI2UFR3VTNqK2dVeVlZKzJMK0JFdjJuRDhTdEMz?=
 =?utf-8?B?MzRNRm90S1JiRCtJOEE1QWVXMXB4am5oemFvV0lxZWplSjAxRGpTMzRpWEZQ?=
 =?utf-8?B?WTQ4eUJ5RFRyQTJSbkh0MEg3L09QSUxqSVFrNE8vZHR2UG1vUXo2dGdOMjNZ?=
 =?utf-8?B?Z1ludStBWktSQ3FVa3p0ZVZQdVBQdlRDWWhaSlY5MEVTL1hFNDVIN2VQK1lC?=
 =?utf-8?B?THFSSXZGWVN6UE50a1MzTUFMamkzdk4yUjFmV3hkZTZjNmk3MFAxMGc0UjdN?=
 =?utf-8?B?eDJpYmRmcS9OODhiVlBVQlpZSmxSN05jem1MSm1MNU03OEY2aXZQRmRkSG9o?=
 =?utf-8?B?aFJGdU1rZy9LbmtCVmQ3Y2ZNckFpOTZsNWl2OWxKNlk3TXNBcE80dHpMSVNK?=
 =?utf-8?B?ck5EVk16L1JBRTNsbllHVXowWnp1cWgwU2loTjJSTzlpK2wvQjVHVDNtdWZx?=
 =?utf-8?B?dGY1UytPY1A4dU92Q0poQVFJcC95MVg4Z0pqbDIrcXdDVXpRTHBid2JCcCtn?=
 =?utf-8?B?VkJSRzlqQm9vOWdJVXRKcE4vUlNxWG92SHJmcFBoTzZkSlRzcjlUNUsxbnhJ?=
 =?utf-8?B?N1B3a2xTckFWU0RBYzNwVldSQUkvZWdwK3VJQ2xPYW04c3dDS0tBaDlOckZh?=
 =?utf-8?B?aktrZkdZTmJFbHBidlNSSHdCS3ZaWjJ3UjlhM2tBanh0MkxIWXBYMVdzU0Ra?=
 =?utf-8?B?QmU2Ukc3bUtZd2ZmUXhCUUw1KzFlZ3YyT2ZBRWRaTnY2VmxHU2pXdUUzR2x2?=
 =?utf-8?B?a3FpTi8zSXhaV0hsSHRDOGkxYk1oU3hUTGlVNDlBbmJZSUZaR3RPcGRHQkVT?=
 =?utf-8?B?YmVDTFUzZXZrS3RFdXdDNzVtdGt4Q2txeUVPK2JPTjFoM3VpZWNQU1h4ZGdu?=
 =?utf-8?B?Q1Z6VVYzZ2Q5SCsyVXAwb3dFN055K1prdnR4ZDVGNFpsOHVIZTM3NkdKdGlH?=
 =?utf-8?B?VUFNallva2FvR2pUQTVnRVZvbnA2N0pRQ2M0dnIxOFdZUHlPM2V2Q0VKOGg1?=
 =?utf-8?B?REQ2VUtuWG5JaXZjdmhvYmNRRmtidzQ0ZnZ3WlkyajRRa2x6dnorQ0k0ckRZ?=
 =?utf-8?B?dlZ2cFVhQko5d094RFlnV3hpMXJtaGxmL0NucGpScThObXdOMzJWTGtxOXRH?=
 =?utf-8?B?Q0swaTFORmhvc0U4SjJmbTgzKzZQNk5ZUk5BUlJyMWJEVjV0MUNBWlN5K3RE?=
 =?utf-8?B?ZFJkR1RUbGs5TjdrYnZ1NlJ0ay81SWIxZk5JZjFWOWgvanZYcS9wU0xFTWFS?=
 =?utf-8?B?c1B2SCtJbGVaemxCTVpIWGRYM0w4RGZaS2V2RjArUnZJYk9uTndMV3lsbTky?=
 =?utf-8?B?ZDV2YTVQaTI1MlRlRFJpWVpyeG1NR04rRGFnRGlQZ21Oa2RNUGxLdXRUZFlY?=
 =?utf-8?B?MWRXY09paW50c3czQVhlNlNiTHl4RmZ4QTZpM3ZhNU9uMTlLbjU2RkRPR0ln?=
 =?utf-8?B?QlZaeElPYURnSXZiZEZsbDFweDRTcHlMT2VsVUxRUFM5YlJzaEZUdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75629b95-c6e4-400e-cf47-08da1b9eade3
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:35:56.3298
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1796AaLqMAXa+Omo6Pvs370fierqwpmmWJVtAmWfzxTQogaFuddFatWEt0IEQw/dPvbGrQtqvAWbNpNwoidMJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8609

Prior extension of these functions to enable per-device quarantine page
tables already didn't add more locking there, but merely left in place
what had been there before. But really locking is unnecessary here:
We're running with pcidevs_lock held (i.e. multiple invocations of the
same function [or their teardown equivalents] are impossible, and hence
there are no "local" races), while all consuming of the data being
populated here can't race anyway due to happening sequentially
afterwards. See also the comment in struct arch_pci_dev.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -699,15 +699,11 @@ int cf_check amd_iommu_quarantine_init(s
         union amd_iommu_pte *root;
         struct page_info *pgs[IOMMU_MAX_PT_LEVELS] = {};
 
-        spin_lock(&hd->arch.mapping_lock);
-
         root = __map_domain_page(pdev->arch.amd.root_table);
         rc = fill_qpt(root, level - 1, pgs);
         unmap_domain_page(root);
 
         pdev->arch.leaf_mfn = page_to_mfn(pgs[0]);
-
-        spin_unlock(&hd->arch.mapping_lock);
     }
 
     page_list_move(&pdev->arch.pgtables_list, &hd->arch.pgtables.list);
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -3054,15 +3054,11 @@ static int cf_check intel_iommu_quaranti
         struct dma_pte *root;
         struct page_info *pgs[6] = {};
 
-        spin_lock(&hd->arch.mapping_lock);
-
         root = map_vtd_domain_page(pdev->arch.vtd.pgd_maddr);
         rc = fill_qpt(root, level - 1, pgs);
         unmap_vtd_domain_page(root);
 
         pdev->arch.leaf_mfn = page_to_mfn(pgs[0]);
-
-        spin_unlock(&hd->arch.mapping_lock);
     }
 
     page_list_move(&pdev->arch.pgtables_list, &hd->arch.pgtables.list);



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:36:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:36:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302773.516526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqTE-0007DK-Co; Mon, 11 Apr 2022 09:36:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302773.516526; Mon, 11 Apr 2022 09:36:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqTE-0007DD-9R; Mon, 11 Apr 2022 09:36:28 +0000
Received: by outflank-mailman (input) for mailman id 302773;
 Mon, 11 Apr 2022 09:36:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqTD-0006iD-Tr
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:36:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dbe7b3b0-b97a-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:36:27 +0200 (CEST)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-i6JRZvgnPVO-5PC4T0Fx5g-1; Mon, 11 Apr 2022 11:36:25 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PA4PR04MB9639.eurprd04.prod.outlook.com (2603:10a6:102:260::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.26; Mon, 11 Apr
 2022 09:36:24 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:36:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dbe7b3b0-b97a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649669786;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XiXlRp8KAwreSj5L/XmU2xaUcy67hxd0OIDtCutKoAY=;
	b=IB73sCyy9Y8rl4eskM4wMIbuBbiKU6jnHpyg9BGiwdypq8ERuUyrEMpQgSuB2k01rg+3IZ
	rAb8ItcJQ30j+4wumiUWu1IB7u1LaOpxzzgArED+XfS0RWLMtBXKxuMfvpHhKlg7Czontl
	hmhjqt9GmJspgxTndg5/GwqUAevz92w=
X-MC-Unique: i6JRZvgnPVO-5PC4T0Fx5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a7EfJJrsByPSCYJnSK9bd1I3HAaWUpbVbi4B/UvPjPGZ0V2E1xUK7CtFKtCFNF7KM/DykFVISRruqhjRoWXmzWXS2ZN50nZ23B5kbqgCtKqctD4+u9OXGah+9brw6sKjtIFZj3Ykzsa+RVVx3FqQH2GMMZNMJXdR2qO42IaTedCd426vEDPbN95u2TqQhLFNoyPhukd79DOaiQ2RdyKYqnPhEnXFzrHaFhKlVKWnVp+UKoy4mnJNiucnNhlP4PSdAKL38IPd0efZLYcKqgyjvtXvISyTh7gYAeSOi6zwE2B+6Xgb5tG7jBUIwx2zZ/KQgcJitcydG91JfpbmM50d4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XiXlRp8KAwreSj5L/XmU2xaUcy67hxd0OIDtCutKoAY=;
 b=kmOSpa/UkF75vWDXm2tWFl88lgghOCxyQfAChE1htTjqQVDiTt4L9qZQOZ9bGrGWQmXCLkTXCs9Hm/+h9lepUyorhuktdo/u5+RQfVYeOTrQYD1S/XyboK2FobiYrNQKxyxfI/1FhrnPYpk257nL6gsqoYsyR2/sOv5MQ0eIc5FmB7s9VdrPRv+ILeZ+AC3QX67URQD+ETcNbbAF3pSdI2mJ8ltPCcExMAqPmCHnLr9TZ/pZMvODkNxTxBqwTsWjQ08rq3+ldoua3PhskQqRJGV1bnU8IWW28HV3i7J+HQizMyzEZUU0h3Ui8qaXxp33WTtD5/ILtfvdMVTlTYmLdQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ad944163-e8cb-6ecc-7e6f-400f9e8cd4bd@suse.com>
Date: Mon, 11 Apr 2022 11:36:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 2/8] VT-d: drop ROOT_ENTRY_NR
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0041.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f5823ed-a78f-4cf3-361a-08da1b9ebec8
X-MS-TrafficTypeDiagnostic: PA4PR04MB9639:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB9639C7D7B83F1DA40B9FEA8AB3EA9@PA4PR04MB9639.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bdHNKV9LAf9FsUcMkxqWWH+0rCP7H3FI+osryLp/n7jsy8vbeVSWcVli1wLGhp2oAa+yhaTsu8RUGT0dv+BpH195ra+8SNt5Tgp+t/S94p0JBOAJlgsagvslxbMShwXPikxLWGKHPaCJfHpqlDwkxLgKCla55KfCv/uZslIqnKD6aOiMK+VeH8W+atWx0ZoGYstQir92Eu8+UYO4mrGA/yUrimMSU0Qb+SOiJqs+B6V3cv9/U23UgRKTmst5KIgg2Wce5UByD5RrJtCi7jFzm3sw9iJlh92qjqOd1SeqheMJq+DR3Ac5C9CmOHemVOekj4A9pceB7zfOTUexU0Z521bVlG5/YKsmdA3USsNvAh8NpYq28iCc1ktK10b9tKd7h91gyD8u73wgu1/9/vBDFtakQ4v8mzwJYau+6eFNiDF0CgUGvusKnLBWjGBnNGb57dYMhXH3gVPTQ1+glZndLsfL1RRYPVcctCjAEMrRjz1XBUrhnnO+kZ3gihBFaNwsRmzagoNKzQ2Y/QJHTCfsNIXxQHGnLsag7Y/HQmMpbzpq78GnCWxzE5ryap5KevYewmkQw9aHTOINv4YH86KSqDIev+TXA05+oWQq+hke+E5h9VmPjbYXGpjXMzKbuEwxfR6f6sUtXkSBDI6LqMnEZxofovFGKbmQutJvnUrixofyu9lWW0JxY/nTTOSaXnvQVxgBq2SlHpSDHHa+HLEVPxNqiV8Zzo20syeq2LubnNyjjfbXRcPGdbcyvmNVwlSt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(54906003)(8676002)(66556008)(36756003)(26005)(2616005)(2906002)(31686004)(6512007)(186003)(316002)(31696002)(6916009)(508600001)(4744005)(4326008)(8936002)(6486002)(6506007)(66946007)(38100700002)(86362001)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dEEvc2JicGp0bkM2WEM4WDFMQ1BwSTRUSWx2eHF3c0o3RlN5RUtLVVhZZGVx?=
 =?utf-8?B?TVdBMGtmc21oa0c4ZGxNVkREbWsxNjdSV0lyZDhUbEgrU2VWUkc2b2treGJL?=
 =?utf-8?B?T0Jrd3NpQWgxLzBmSDE5bTlqcHlkbWYvS2l3UzdBakRLOHgyU1FPdUEwYnRk?=
 =?utf-8?B?WlJOVmFQZVFIYWVIbnU5UmRvMUg2SmdHeHBsN0dDL0VLZWxwSFg1Rnd4TTQ3?=
 =?utf-8?B?OE8yYkFsckxWRmZpZThBYmRxd29Db2Q5djVBUjBOUmhwNHRWYmowbFh6blRp?=
 =?utf-8?B?NFoxbHVXTFhaMHdRSFJ5WFh4UVlRU0lpK1daeUNTbjdodWhMWDRUbUNWZVpE?=
 =?utf-8?B?djhTMmFlV1pMWGRrWURsa01VcVpoOHdYWGxLcXpMR05vb255UmtveFBpamE0?=
 =?utf-8?B?Vmo0VmVqOW00Z0ljUWh1MGRxcE8yVlBRVjZoWGJESzRuWVo5Qmdad0ZwM2Za?=
 =?utf-8?B?NDBPZG5kY2VZdkExUmVURWRhcklVYjBYODlRVm5jRTY5a1pTMWxtcURRcTE1?=
 =?utf-8?B?bFR1SXZwYXIxUXd5dWdheUVqdHd6VWZWam1IRW10YWNRZFppS3labjRLeU8y?=
 =?utf-8?B?MXJYMjZiN3d3TDBVVXNqNmNvYmUrMGlnZTB6TDNwVkFjOTRFL2tzVVN4Q2lB?=
 =?utf-8?B?a3pPc3VReGdlTnNHV0JOb0oxbHZQMHh0QjlEUlFGc1dqeTd2MEx2WnV4WERh?=
 =?utf-8?B?YUU3S0k3S2VxNkQwczgzL29KdVRpZmlSUU0rajNaRlN6WmNWOVYveloyTjJh?=
 =?utf-8?B?VFBJYS9FVkJqbzlZRjEvOHB5VWgwaDRCc3cwVGloVHlwNkZCZEoyenpQeVNQ?=
 =?utf-8?B?R3QvYVpEcWRWUGFtWkx0RHc1aTU2cUhCR2cwTGl4ekdqZTMxWnNZZE5abDVz?=
 =?utf-8?B?V3J0c1JPQlA4TUIvM2NuTmE4WWpEcHAxU0FCUFlMaEJFRHE2N1hFVGdiczB6?=
 =?utf-8?B?U2VuNkh0Qkk5RENoS0R0QUdQeDdUUm9RSmZFN0tmeG5aZXZwZVF5Z2I0WUto?=
 =?utf-8?B?VUhDRStCMis1TE9RZWhYUHg5UEkvQXFEY1F5VEdlNXJUUjBCSENtZlZBeVpP?=
 =?utf-8?B?V2x5bDBOQUdyM1NTKzNaZ1ZzbHNZVGVwNlhWdUltTUNhdVB3T3lyZVNHd3B5?=
 =?utf-8?B?QU8wTjZOYjV6a0VvcStoYU9oU0tCcGMydnYyT1ZES2JBbitJejk1S2lVOG1K?=
 =?utf-8?B?dVY3Y21WSkZYcjc0WlEyT3FiM3l6Qm54UzVieW9ieTB0TGtUektJUGVkakdY?=
 =?utf-8?B?aytGSTNNWGNIQnRZWDdNTTBBRU1NcmpLcEoxOWNPWS80dms1cTRLZGpzODhq?=
 =?utf-8?B?anpRdEk3Tm0ycFZ4OGRXUVJVKy9rU09ZUmp3ZXpJNytNdS95ZEFGeUpzRkFu?=
 =?utf-8?B?ZnRtUXp0WGt4R2FRNk5aY3U5UEV3WGgyREpYVytHVnBXWTJGcDc5QlYvak5Q?=
 =?utf-8?B?R1JUK0g0WXlhVXFjcFEzWFB5eXFRRGhzbWtTaFlpU2VxbnN3WVJvRzBoaCsw?=
 =?utf-8?B?eG9ZY2Q2WUt6SmtIbWVSbGJFL3hia2E3SFJURkhpK3JDRWVuVVVpWW1rVkdh?=
 =?utf-8?B?NVI4OVNZQVp4cFdaSFNhU3ZOMkg5S0FYSFF3azZrTUtoWmxRWHBjSHJFeng5?=
 =?utf-8?B?Q25NVnNsVDFYV1ljZ2ZsTTNWa0hkZmZqVVpKSVNtQWNCS2x3N2tmOVh5NHFH?=
 =?utf-8?B?bFdUVXhWbEJOVnMyNnd4ZDdSNEViZ0RlSlZJV2FKeFB5aUlQeWZ4V1BXNU82?=
 =?utf-8?B?eTdzbnJyUnBNelZTRmt3MitBOFF2U05QYUtCc0tId29sdGpCWTRKb2F4bmRj?=
 =?utf-8?B?N0VyM2V4bkYwSVRDR3JITFkrYk45OGw2TlU2alFFbUxwaEllc1VPeVNxSlJo?=
 =?utf-8?B?MU04czNBN0kwTFVIeGlLemxDdFQvVlc3TW9hY3o2WXQrbU05Q0VsVHVoV09G?=
 =?utf-8?B?QUp1L3pTVmpORGNxU0pzejlSZmZnTUxJY3hkdCtiaWloNUdYbVVINCswZzlp?=
 =?utf-8?B?ZU1BMnVMUHJLb2l1U2J3R3V1MEdFQ0FQYnMrYUFsdXR1VHRvQzhPeFpRNjM3?=
 =?utf-8?B?c0xhWmxZeVgwOEV2UWNFWXl1cStlZjl2dlkvdkRlQnBXSVJ5M0RsaDdnWTZF?=
 =?utf-8?B?aE9uK2hHb0VLKzl4Uk9ITVUyb3I4SE5XZS9WZUZ5NTFER1I2dzluekZQdHgw?=
 =?utf-8?B?Um0wVHp1TXVRV2tPb3NqZVh3cjBkYjgzaDVDRlU0T0I3ZWhiVHMrYjdZdEhp?=
 =?utf-8?B?R2wwU0F3QVBXZ0NyMlFTTENQZHBUMjNUbXR5WGJBMThGRDhHYlE2QjNhM3FW?=
 =?utf-8?B?NmJDK002bm1WTStBdVpLUTRrbHBDTVdDSTVmbzAyQW02bWxBNHlyQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f5823ed-a78f-4cf3-361a-08da1b9ebec8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:36:24.7952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5LhjsT5Kxk95Y279pXdpxZHXhnbTh95djOtli2w7Ccg7ou/npL23oteRAK2TIRbvk7vCYquBbu07ImMuBnLiVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9639

It's not only misplaced, but entirely unused.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.h
+++ b/xen/drivers/passthrough/vtd/iommu.h
@@ -204,7 +204,6 @@ struct context_entry {
         __uint128_t full;
     };
 };
-#define ROOT_ENTRY_NR (PAGE_SIZE_4K/sizeof(struct root_entry))
 #define context_present(c) ((c).lo & 1)
 #define context_fault_disable(c) (((c).lo >> 1) & 1)
 #define context_translation_type(c) (((c).lo >> 2) & 3)



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:36:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:36:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302775.516537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqTd-0007lB-Ky; Mon, 11 Apr 2022 09:36:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302775.516537; Mon, 11 Apr 2022 09:36:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqTd-0007l2-Hl; Mon, 11 Apr 2022 09:36:53 +0000
Received: by outflank-mailman (input) for mailman id 302775;
 Mon, 11 Apr 2022 09:36:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqTc-0007jK-V3
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:36:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e47771de-b97a-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 11:36:41 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-tNEkerSfNjqnywlkASB9kA-2; Mon, 11 Apr 2022 11:36:47 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0401MB2457.eurprd04.prod.outlook.com (2603:10a6:3:7e::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:36:45 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:36:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e47771de-b97a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649669810;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JIOtB5hoGvxfTiBr5WkyK/emu3c33KdonytgCqOz8N4=;
	b=YSraPXG+NKJPKQV7XEbpBJSCUveMbHQ61KD2AwzOiOHZ46FeWXudkL1ogykJj84ASjv6b6
	W6A/AxrKGK3eYij+cd0JrRBfFcxnsMrsCtLGyli7wX9739GxgKHPYe2/8RDj22VvZWgsfh
	PlLpFiGBG8afqqO3RwARErCwp+hw7+Q=
X-MC-Unique: tNEkerSfNjqnywlkASB9kA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QKToGTdRtFQqfWWcuJbuadyybRdJuj5V94VWNj0rB/6eq88t74cT7QbVPd8ZUhQul/c3clXjgNNE/7As+2QaGpHqWnnDHqW1xClA0293YqUcS5l9b1SKM1W/F6peWFyTV6D3AKYsafWQI1xPMYuyoa/MLpGikoSyynivQaHj6cN6oRs5eQd8CdEeTOzo969XxCIZ+994yr8jPa2x2lPlcXkBXE1nxrqvq5fQdyZhoHIG1l0MNZA6yPLt0YV8Wfoi7v1TDkuakfpCpA8MFF4WhIuiiWsZqYvOP5QQhdXfxCy9Mp6G5FgsZ4TvJW6jw6mjQM70x5WnGhsZOxNzwKLdpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JIOtB5hoGvxfTiBr5WkyK/emu3c33KdonytgCqOz8N4=;
 b=EH86Tdakl5zMvOABjYeAHevrsu26w0tIVYhywTlDjI+gzQadw6YE5cK+QJQ4rstD+gcvEvz0bXidNWxtw5V3km9qWSKsc1w4xgtFZeIZszaQyGSoySoz4cdNDaE2QFHh0u48M9/pJ2T7O5ToEsO/a3SRTNgdTHGaneDn0Lrlqq/f6RUQjXvjLjhuRCELNhDWbFPd3Dmfo8GNJ02jjnY+S+YrVwt2b5S+ozpFD4bNKcqg4WV08V0VGnNvKzPKPF6NtuQjNfsGsc1qCGVnoRovsla2MFxKQB/ANHAtCfZuDGy+DQ8vg50UqoPkx52/MnQqNHCwsH6jk7zbcg73w6kdoQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <10f43cc4-7a09-9f4f-0a6b-fd7ffd88310d@suse.com>
Date: Mon, 11 Apr 2022 11:36:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 3/8] VT-d: plug memory leaks in iommu_alloc()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0040.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::17) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 950c6d75-ecac-4771-7c14-08da1b9ecad8
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2457:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB24574513F65C57BCCCAD40FEB3EA9@HE1PR0401MB2457.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	obY6t5IbgFK8u0LdxwRleVsbxyDuAAhLmLUvXt+wT/PQo4Kpvrotb8ux3+Gs1gpcCHWcrlQqGbflQUWD477CahsGbyEu2wU3Vv/4vPYy1rLon34Zy6HZIr+EZC9D3hyDihouuNej71+a2K+O0sjToypjlsuHZyvTvN0+1WEN++S7e2haspKzusu4m/RbguqnAL/W88Vk2Q1590dFaWQyhKrFc6Rc93zlEjh2STQgLmbRHEtXnZECu9y+xkGYCYXKqwCXfy58ur2rJO4N+9djJFqgBhDjAnQ8sNlnPryw322MfsK1G09df/qQiGxWlshPhROk/I8vyHmcRv8M14kochL5+pvUxrhctLWCi2nFWKuBXMN+jqKQFw84ijObl2pS5EOralmQvfblFsGakgn8BOXxGvLBgqNdmpqA/qSupV7sFEszEyW0uZrG8S0+WswrJ5kwQyC2J3D5HAc86Vvuu2411czLsq+fK3MCB66J2Y5L/k/WeQSoaBTre7bIZlPil7CpaC3kElYnOxr1+gP4iqy69USiy1AbvdyU/vonT1xRQmCoNSHsPhGjXFGkp3iB9wKdUvth4Z0UO6XuqqrWhuYHzSXmsGe8NCVogiCtbTxSWsJlMYvEBcw4XzgNbA/5h9AS8KkRJXC382+EQ7nPAVkOTrRhSakVXcqAoV4kinXS6clLcrUHf89XhNlzsSx+hXBJNXii2pa1/WUmlEVJnosc2CbHMDeCHP2gNr8sQSGcJD7uPGexww+8srIBEk6T
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(8676002)(31696002)(5660300002)(6916009)(66476007)(66556008)(4326008)(8936002)(316002)(86362001)(6512007)(6506007)(83380400001)(186003)(6486002)(38100700002)(2616005)(26005)(54906003)(508600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bm9BcFNqSDhqcEJuckpJYk1QWUxoT2hkbnBjQjk1NjhRb2luRkF4LzFUb2No?=
 =?utf-8?B?VUZXVyswTVlldElVRytPODBNMWxHK3YzUlNkUlNxc3BsT2tMRVlvVmo0ejVv?=
 =?utf-8?B?TUdvZHFrNHZrM3dEZUliaHRyc3pVUUNWcnU1WUpIK29GbTJMM0g1cGdwUm1H?=
 =?utf-8?B?dnJkcGJBRXpOek1meHpNYnE1dEhYSkg2cXZQNHdLMFk0YXdGTlFlbmZGOWR5?=
 =?utf-8?B?NUQ0ZkVYUm96Sy9QRVJ5UlpJaWNFakgyN25tOGlTeDg2aWtzTkMya1hldzV2?=
 =?utf-8?B?QWZ6dnFpMHdrdGpESXhpV2NBL0Z3R29icG52bXRib0pSZGNnenB2RFBILzVq?=
 =?utf-8?B?eS9PTmJmOUNuME52NWFKbld4VFJvV2hDV29wTEVrUGRaNlU5YmlLRW1IaVJw?=
 =?utf-8?B?ZzRmQU50YjdkbWdrSHc3TXRwVXhNbkgvNzlQblFhVmgvQ3E4aXJIcHNlRWU1?=
 =?utf-8?B?M1k0djJCMk5wdlJPa0RhL3NlVEd6c0MxOWRXMStsM29NWHdleTV6Mnk5VVZW?=
 =?utf-8?B?RG84bUtpY3NPd2Y2MGZVb1dQT2xYallsRm84ZkN1b3V4aFVhQjdPTDN4c1VU?=
 =?utf-8?B?ZHNXbHBpVnF2elYzdTV4MDFDN3BZT2dIUU5CdEFGdmdlWmRuYXRraW9oT0RZ?=
 =?utf-8?B?bW50VnBXTWxhT1pYMURKaUlCMGdGNm1OejBrUTllSXMyNHhrT3FGV3MrcWpV?=
 =?utf-8?B?V1pMVDRhYWRpYVpBTGFETzBmZkxqT0U0cVY2eWgvOFhycUZXWEdaQUdzTHlP?=
 =?utf-8?B?a1V2T1hlOXAvdWpxOEVsaXE3WGcxdVpMSncrMWkvSk5SMHM3eWM1d3d5dHU5?=
 =?utf-8?B?ZU5qMUlpTUpvZzlldEozL2FNYUxIZ25EVXlseEZjVVBObUtlZ1RwVGJpeGF5?=
 =?utf-8?B?OFU1ektrTlg5KzNUajBiS0NuMWdhdklzK1l0VDZGTlpXOXd1d3FSeUV6MW1k?=
 =?utf-8?B?Zzhud2NPS1ZwRjBzWGs1dmxFTDdUM2RkVml5T0w3cTVYa1BDeDZOOCs2Y0Ev?=
 =?utf-8?B?amxyai9GaW10a3NOaXByMWcrU3Z2enU4NllSRjVXRXNaYVpqeWQvRDZ5MkFB?=
 =?utf-8?B?TExqY2l6VEhpd3Z0WWtqNEdSNGkrZStuUjR1bW1reWlJdlBGQTZhZzdDVHhF?=
 =?utf-8?B?V2lPT1dEamprOUtMbnNsM2xvSG5UNTQzejFIak1NZWZBOTZMbUVUT1RMOWhi?=
 =?utf-8?B?N1d6SUZlY3hHMVRjYVNYOW5ucmN1VU5vL3U2WmZ1cWQvY1B4ZEF2Ujh5VHRC?=
 =?utf-8?B?S3lxQ0w3MjU4d0JVc3psTUtQT05uR2QwMWFoTVJPaG85aDk3SUZqNHF3OFQr?=
 =?utf-8?B?Z2kxWXpkeWxHOXZMUWFiU0tJdE1ra25oV3ZScTVOSnp0ZXBXcEs5dS9BYU15?=
 =?utf-8?B?QkxYNjM1WExKWGk2aTNMQUhpOUZzUSsvL0Q0anB3WC85ZGdJSWdBQVFyb3la?=
 =?utf-8?B?NHNZRmYzZEs3bk1Jdnc2a0hCYVA0Um1GODR5ZlpVdUpuSkVjZUNSNlZ2M1BD?=
 =?utf-8?B?NlFVT3pKTVpTK1M3QjNiZHh3UFVrcHQyTmcybmMwVmJPVDhkbjJSZTdNWFR3?=
 =?utf-8?B?ekRYc3NLKzFBM0VrMHVwTXNsNjBadEw2NEs2TWFMZCtTNEtCN3NMNDR2MExC?=
 =?utf-8?B?NWVnN0VSYTlta1I3dEtDeEhwSEJydGRBWkFhb2hoRVYvYVdEVUNTbkdUK21q?=
 =?utf-8?B?b1pRWXZ6ZVVEWU9PS3ZMVWdmOXlkZWg5dEJQMjh2T2Y0V3VsTm05dkdiQnNs?=
 =?utf-8?B?UThFZkpsZzBKOS9KM1RuN0Z0Qk05OGZscU9KN0ZlaFlMRGpBcGErSGNzQ3Z2?=
 =?utf-8?B?NDdGdTkzY0lNSk5ZUlUrYlVOMmsxOUNWMjg3U28wQSsxcHdWYzRFY09pZGdY?=
 =?utf-8?B?RFJkWXllSkVxWkYvVkVtVTQzNkJ4eWtYVXJJRG1WZWs5VVBRUzdNQ1AxQThC?=
 =?utf-8?B?d3d3VDNMVjZPaXFzWlp4NmtrYm9JSEQ4NEV1VUgzcWlQaWdZa0JwYkhTbzg4?=
 =?utf-8?B?Ym5tRnRKRDIya0hLTFRkNDJ3QURycGVsMy94R3QzZGZPdEpVcnRTN1J2OHBp?=
 =?utf-8?B?Wk1DWjJUa3RtTlArV3ptWVBsSk41NjJRdEtZWVNNeWRXeEc2T2hnOE1XZUhz?=
 =?utf-8?B?OUxWV09GTFBmQnc1TjFRbGdpQmJPNkV0SE5ic1lHbHU1ZkVuR3ZybTIzR3lr?=
 =?utf-8?B?d0pteXFGTDVmeDl4ME5rTnp2UUV4MCtSblhHVXFGbWxoVWtGWVNwbW55TUI0?=
 =?utf-8?B?R0h0bXNKbE9GbE1EMWp3YjJCOTdLak80WFRDSGtSWnlvZlVlL0w3Ym5hUW1U?=
 =?utf-8?B?Z242YVZuRzdDU0hOSnFDQllxZ0NMUlQ2bVRVRWhqTEJuZDBKTzB5Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 950c6d75-ecac-4771-7c14-08da1b9ecad8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:36:44.9385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BpIIM1C5pDpEjrlV0/H+9/SlOts+Wlj56MEf8UR5QJihAC/6i+r4DHUb2r3X12IzDAOXKguONI1BoU1JTT1l8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2457

While 97af062b89d5 ("IOMMU/x86: maintain a per-device pseudo domain ID")
took care of not making things worse, plugging pre-existing leaks wasn't
the purpose of that change; they're not security relevant after all.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1238,8 +1238,9 @@ int __init iommu_alloc(struct acpi_drhd_
     drhd->iommu = iommu;
 
     iommu->reg = ioremap(drhd->address, PAGE_SIZE);
+    rc = -ENOMEM;
     if ( !iommu->reg )
-        return -ENOMEM;
+        goto free;
     iommu->index = nr_iommus++;
 
     iommu->cap = dmar_readq(iommu->reg, DMAR_CAP_REG);
@@ -1260,8 +1261,9 @@ int __init iommu_alloc(struct acpi_drhd_
         printk(VTDPREFIX "cap = %"PRIx64" ecap = %"PRIx64"\n",
                iommu->cap, iommu->ecap);
     }
+    rc = -ENODEV;
     if ( !(iommu->cap + 1) || !(iommu->ecap + 1) )
-        return -ENODEV;
+        goto free;
 
     quirk_iommu_caps(iommu);
 
@@ -1272,7 +1274,8 @@ int __init iommu_alloc(struct acpi_drhd_
     {
         printk(XENLOG_ERR VTDPREFIX "IOMMU: unsupported\n");
         print_iommu_regs(drhd);
-        return -ENODEV;
+        rc = -ENODEV;
+        goto free;
     }
 
     /* Calculate number of pagetable levels: 3 or 4. */
@@ -1283,7 +1286,8 @@ int __init iommu_alloc(struct acpi_drhd_
     {
         printk(XENLOG_ERR VTDPREFIX "IOMMU: unsupported sagaw %x\n", sagaw);
         print_iommu_regs(drhd);
-        return -ENODEV;
+        rc = -ENODEV;
+        goto free;
     }
     iommu->nr_pt_levels = agaw_to_level(agaw);
 
@@ -1298,8 +1302,9 @@ int __init iommu_alloc(struct acpi_drhd_
         iommu->domid_bitmap = xzalloc_array(unsigned long,
                                             BITS_TO_LONGS(nr_dom));
         iommu->domid_map = xzalloc_array(domid_t, nr_dom);
+        rc = -ENOMEM;
         if ( !iommu->domid_bitmap || !iommu->domid_map )
-            return -ENOMEM;
+            goto free;
 
         /*
          * If Caching mode is set, then invalid translations are tagged



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:37:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:37:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302782.516548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqUJ-0008Qs-UQ; Mon, 11 Apr 2022 09:37:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302782.516548; Mon, 11 Apr 2022 09:37:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqUJ-0008Ql-RJ; Mon, 11 Apr 2022 09:37:35 +0000
Received: by outflank-mailman (input) for mailman id 302782;
 Mon, 11 Apr 2022 09:37:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqUI-0007jK-Jw
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:37:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fe4d3d03-b97a-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 11:37:24 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-9BhgKYcINt2V84FTkllM0Q-1; Mon, 11 Apr 2022 11:37:31 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0401MB2457.eurprd04.prod.outlook.com (2603:10a6:3:7e::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:37:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:37:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe4d3d03-b97a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649669853;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QrdD3qAeqW/aeTb5B3y1/J7DaT6w+fqGApWyQhpbnKk=;
	b=Nsv4TpZZr04QG1PdRx/z7EXlQMT263BHa6QTRvBR4muAEtoKPyRxjdQBNiz0Yb3pF4LBWA
	XbpfWnFF6n45yl4cACpQ+D1+UdgpVJ7l4jY+KuES3OclT1NoYD4sCN9Gj0a9yM4UdrpL9Z
	CaXDTecY+qsbAsXER+PEXaFQF0UlRsU=
X-MC-Unique: 9BhgKYcINt2V84FTkllM0Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QgTBgvpR63PNgKhgJ0nQKAd5MNxT7StX6ijlbl1NRG+6QIkeYLqhFfra5FH08k7x2bmvf0PGXfVCKXkz3pjoHkIb+zWY7ateUxnjA+ymQpVPHpbF9qufg4QckXstczQszcY8kqxfzpeLxHvVg+kGOipUkOLWlRRaEqkDYE1cBKSvkSehBBTiSn+TKIItllYUK0qcg2iQ2GR8zsrB87JQ9kq1EV5yq+MboqiuPJJEQn9NnEKCadIHpC9Z1dHErM0ejiTvSFXkjyk1qBSiD7lI/+RZTTZUc9xEYju5n5LDozp01AbCStk3ufDWMoQ+BVWJHtUwJoJt57NnLPFLxCzL/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QrdD3qAeqW/aeTb5B3y1/J7DaT6w+fqGApWyQhpbnKk=;
 b=VlYb5LIF8UwdTDCtiRgc1LPc2FbVRjVOylJ5KlfpT5RkDQ/SzFGPNZFArsexdwX+jas2xFwEWU+WAgW6U21geCeJyGojYMsBOftKG2pyE/MS7MEFSveVXj+kQJNZVbADyIQoMwrHTM3PJcBUAfrxOo45sKysxft9XiiQi311vFt5fT6gsBIsbJ8vspi9GQTz55yX1le7mO1oJ98uWbZjuyXW4CCsCIFKRk+8x7PuVQ63p0VLBhPx4WxdUqyrA8ffkVp1SAoL6HQ/tVti8mSalFf+9g0t9p6exe6eFx0+PAza1r78KBu2gRv0+i0rqbSNT76DTgeRaGXVPuFocoqWoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0f7136ae-0b52-431d-f789-4b7d5bbecb25@suse.com>
Date: Mon, 11 Apr 2022 11:37:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 4/8] VT-d: refuse to use IOMMU with reserved CAP.ND value
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0071.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::48) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7abd9412-85f7-45ca-ae8b-08da1b9ee57f
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2457:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB2457F5F6E91E8535589E73FEB3EA9@HE1PR0401MB2457.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SCt/YgoSKOkcgOM8H8+RLNmkPEZwpkNbY+RwjDd3CCqlkAEPRxR1MbznBlArG7Ck0khu19MmfxLYogLhUzLXuwaCA9GHFYwqFAVbZB5it5wIna1shzUUHAIsjNHw2a3dFRkd0wWKwdhtqCfuy8EEW3ynvheAVpeAf49eVEPCqzHHHgl+WhoeizHnqsPT0llSzXFeV75Cum4HsaePI/iy8r5bnHE3/10qFd4MhJ5SPCsxVdFcz6acvxhfJcCLJE7RrqMUImAo+PehD4ym1Q13HuTQNtnL+BzTmu/ZhCsT8Bzuhy+eR/vfpVDlvDPhX22jhgKLe8tZDwPOgUkNGbaN4VyiETnp1sZk0ZRr1QY9k89OG4FZPwAgl8Un6N++CYyCV+pob7NkMfiZWKyV6eCYn/9jiG++uLKh7YZJBALjbbfqJs3CMmdNbIMi/DMcYf/NzZtpov/zui0Xj3F79LIn8ammU3O3iXqMrhFFHA5okmZWYvxZgTml7Vg3vK9ZYB5GWcBIBwwS6jGgsmg9Pytu4kig0yEROdtDpFZqLSQVZnctAIyMs7VzYNC1bBlRCLiHOB4GqtUlUG+He6PgqXN6FmglKOTfJwNtfF1vm/G303fIea1pusvf+k3d2UU+rD54frGCAFe/II2zTX+iTpH5PKhqkTqrZ0PXMPPdsWOiTA8VitX19yyfAOyT/ZhSt1PmP97xLzVIG3VoMuPdcoKeu874RQMlGDOcA/o+2eFegHlUPy2kX8VnDFWQSyJy0HZz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(8676002)(31696002)(5660300002)(6916009)(66476007)(66556008)(4326008)(8936002)(316002)(86362001)(6512007)(6506007)(186003)(6486002)(38100700002)(2616005)(26005)(54906003)(508600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cG1jZkowN2JiQWdrdElkMm9KUVUwQzNMK3k2azFUaUJTNFdSTENJNHRZQnI2?=
 =?utf-8?B?VTBpeXlPRmprU0gyQmUyYStaTTlRL1UxOHJPa1puSjFZMFNReGs4YkdzUVR4?=
 =?utf-8?B?Q2twL0JpOGZkZzVVNWdFVCsrZDR6TFhUN0R3KzBYa3h4aDl0a3VBNkNBaHJ5?=
 =?utf-8?B?MUhMeTQraFNhUVVqYStCV29nVXFYMmFQVDRnaUs4VmFKeVMzRHgzd2oyVXp3?=
 =?utf-8?B?d2FNcVZWVGJ2L3lWUEQ2ME9jdFNOVXJnZVR5VFdUTXlZV0VZQ2lEcGQ2TzNQ?=
 =?utf-8?B?S1RCeXFUUXJBeHNQMGozdUF0UHpmaU9odkwrTnk4SlZzZ0hsdU9rU2tVSHky?=
 =?utf-8?B?RlBqNjlzM2tKb3Q4NGFyazl3NnNOUTNSKzV4N1YyU3dzSHNZTHlZNWJqWVp5?=
 =?utf-8?B?RlZ0QkpvRXVxOVQvYUhHY2p5SitHT3NSZFZ4S3ZRRlZnQ2NFSkx2ZHBiUUVl?=
 =?utf-8?B?QmhnMlpPSmVXUUdMcFpSOUJWWi9yN0wrVTZTTkZJVWw2QmJUT2JHOFlzRzh1?=
 =?utf-8?B?SC9SUkxiRnNiaDNBcGl1aVAwb1E3OWd3dTlwQ0lhWER2VzlQc2k2NWo5MExM?=
 =?utf-8?B?M2lsTlhySmVJOVl3eHpFK3RnZHdvK0FGeUdsMEgyQnlTK1I5YTBhTVdRekN3?=
 =?utf-8?B?V1RnaHp3RWVrVGN0KzhBaW1qMldZMjJ6UXYxUk93ZW4xd3NFa0xhUUFyQWRQ?=
 =?utf-8?B?dXI0OWtRZVU5MnR0dDBzMTVJTWlTTVJLdUNMQWl6d0FMNUY3b0FQL09jZXpn?=
 =?utf-8?B?NFdSYWhjcU1GOGZDcVVxb2FvUjd3YjB0Rk5vTytlR3pqa1M0a2h6SEtXUGpj?=
 =?utf-8?B?UGEzMHB5cE1LY0RtbzkwcEhvV3djaDg2bWx3UVhqQmtMN0pRM2cyMjEwbnBV?=
 =?utf-8?B?Z3NnNVlqMkVXM1psRzRmVGR1MTlOc1Y1VkVYbnRYN1JWVlhreXZQd0lFSmFW?=
 =?utf-8?B?RlBzTWtJNXpRenp6RmpSdnBiL3Z1dHp5WmlpTkVlZ3BybS9Ub2tBOE8rMkFP?=
 =?utf-8?B?UkNqcU1FbGl3Q1NrSStkQXMvcUVwSjNPY3FEY3VQek4zZWFkc2pFZ1g4K2Z0?=
 =?utf-8?B?U0tQdUxHU2d2V0lOVTc3MUFNRFVNNC9SUW1wOVpWVTFBWnlyOE1DRWxNeExv?=
 =?utf-8?B?V3VqaU5RTVBLemFQV2NLZk1LcjRwZ3h5T3dZRUtTQlV2RWowRXlTUVNKZ1VK?=
 =?utf-8?B?RFlDaWRqVGxidWxHakNKbVFYVUU3d05ZNUtlTDlNZEtkNU1sNEFycVBrTjdS?=
 =?utf-8?B?WElPaWlWQWRKT3Bpd0ZuNThVMW9TSTl0cHZzUEFRbjRBMCtWVVZmbzBhZldt?=
 =?utf-8?B?Y3p0ZXkwM3dqL1NjWU80a05Tcy9jS2tTVlVMTE40SXVVU2lpdU5McFFEcDA0?=
 =?utf-8?B?Y2oyVldlUFQrN3FwcmtTMkNTTmFyVmpXS2hya2R1WjdiY0Jsb2JTTWJBZmRK?=
 =?utf-8?B?SUpYRWQvaW5IRUl6N0NoSjhDQnJKdk1zY25CdHNlejNERUk5Q1kzMzFBR2R6?=
 =?utf-8?B?Q1pUM0xjQ2tlRElPYlpLdi9pUitMWUZVWko5WWwzOGFzV1VqR0ZJQURMZ3Zs?=
 =?utf-8?B?V0QvaUdJQXdIc0ZkUlFLbFdiK2FXQ3pyajBMVnRoMThSbnpWTVZ3VFlCeElJ?=
 =?utf-8?B?dkp3QlhwdmV5VXJkbXZJaCtOY1dqeEc4eG54T3EyWnNSUHViY2dIcEhzKzly?=
 =?utf-8?B?WE9FQ3gzdS9KVEQxM3NUMGs4QUFYSkRQZUowQzh6V09WY2dwR1JJNk0rZmVv?=
 =?utf-8?B?Z3FyT1BuTVdDR3JMNVZlQzNLSmphL3M3Z2kxUGFIczdQWm9xSFZIYklyOStQ?=
 =?utf-8?B?ei95VWJnaUVBSVZlQ2dnMFJFRCtKRjFMVVdLZnNNc2pCdk83VWpVTGJLU3l2?=
 =?utf-8?B?bExyMXo4a3pLd0tjS0IyRk9XZE1TQlpXd1JUQm9KNnI5bU9JclRpemRkSGFX?=
 =?utf-8?B?cU1oTHdxd05DZUNhUkhNek1LcHFuOFVNQ0xMeDFxOXd0VHJ5Q3cwZ2NLZk9M?=
 =?utf-8?B?VThFN3ErYW1kWCtzZmZWbzlJODh1aXIvenF1ZmY1RkVpQXZTZ0NqSmJxdncw?=
 =?utf-8?B?NzhlZ01Ucm9mc1RRcVJwa1JxTk1nRk1CL0dvOU15TGlpMzBQTWx1VDcwZS9k?=
 =?utf-8?B?L2Ztdk14THNLZTRhTGNHeEJmKzc0ZFYzYjJUdUJUalpRUTdqbkxDODF5Uy9J?=
 =?utf-8?B?VHRWdHF5dVpVcVVmSExZL2pTWEo1TkhKRzNianF3U3NudG5nUnhEV3JuWkxx?=
 =?utf-8?B?Q3ZOemFhTVJUbFlYNVV3RWR0RU9odFhRNkJSSk5hRUJlSi85TkVJclRYMk5k?=
 =?utf-8?B?Q3o1cHY4SnJYandxa2Y4dm05Ly9FUWRGTi90cWVLWFJvVmRPVkowZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7abd9412-85f7-45ca-ae8b-08da1b9ee57f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:37:29.6416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hr5IiKLGI3vwuvaSQiQlW+2mYDtoj7/YEruIeyH94txpuARHuldh2CqNVP+HBwsxN1f1BV0TqoMqXWtW+l+j1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2457

The field taking the value 7 (resulting in 18-bit DIDs when using the
calculation in cap_ndoms(), when the DID fields are only 16 bits wide)
is reserved. Instead of misbehaving in case we would encounter such an
IOMMU, refuse to use it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1267,8 +1267,11 @@ int __init iommu_alloc(struct acpi_drhd_
 
     quirk_iommu_caps(iommu);
 
+    nr_dom = cap_ndoms(iommu->cap);
+
     if ( cap_fault_reg_offset(iommu->cap) +
          cap_num_fault_regs(iommu->cap) * PRIMARY_FAULT_REG_LEN > PAGE_SIZE ||
+         ((nr_dom - 1) >> 16) /* I.e. cap.nd > 6 */ ||
          (has_register_based_invalidation(iommu) &&
           ecap_iotlb_offset(iommu->ecap) >= PAGE_SIZE) )
     {
@@ -1294,8 +1297,6 @@ int __init iommu_alloc(struct acpi_drhd_
     if ( !ecap_coherent(iommu->ecap) )
         iommu_non_coherent = true;
 
-    nr_dom = cap_ndoms(iommu->cap);
-
     if ( nr_dom <= DOMID_MASK * 2 + cap_caching_mode(iommu->cap) )
     {
         /* Allocate domain id (bit) maps. */



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:38:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302785.516559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqUi-0000cm-A7; Mon, 11 Apr 2022 09:38:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302785.516559; Mon, 11 Apr 2022 09:38:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqUi-0000ca-7A; Mon, 11 Apr 2022 09:38:00 +0000
Received: by outflank-mailman (input) for mailman id 302785;
 Mon, 11 Apr 2022 09:37:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqUg-0006iD-QX
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:37:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1213f83d-b97b-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:37:58 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2058.outbound.protection.outlook.com [104.47.5.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-uECLT-hvNZ2WoZAj196Xhw-1; Mon, 11 Apr 2022 11:37:55 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS4PR04MB9364.eurprd04.prod.outlook.com (2603:10a6:20b:4e9::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.21; Mon, 11 Apr
 2022 09:37:53 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:37:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1213f83d-b97b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649669877;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WsXEt03rYwGXma+YK8JHkDArPL/VDC+WUTJ5m0TRmbw=;
	b=hVIUVsmxdS5jqAn4HNVMxGTJRkbwTPw/UPcze9YBMJm555VTqYqzHv/d/JvTIitxf1XW4B
	Yxpj340bbDOpR9JI+SMs/1xMBH+/o76Sby0moB+Yitb2ybKwyeqdnCC61JELVJ7+vBPNjf
	0OCekjnTUoaeAyDVUe6y96YEBXz8Opc=
X-MC-Unique: uECLT-hvNZ2WoZAj196Xhw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VeVZYMkCRTlqNEVCML3EQNhnreit1Bdg7+jPFsz6D6k90y4uWHkzLigY/D6Ziry/NQVmdRq70Xyeu76UvgISGT4hm7t7vf0LIXWF77iztFDi1dgo5OS8/Coqy7tY5L3hjdxDW19gFY+A0ykZ3xNqEzTwTPwdqo9CMjMr71IbIVb+MBILOdV1aMDrbvp4DZxxo6ztJo6Enn5Ec25gxe9tAFo4CE4guDQssnaS1EdGB9Mf+PLJl1ROwZ8m7/5JXsRUkymvlBmFTYKJhEOVEQ0aBUZgmX2T/Lqk19EDNf/lbG+k41iym+lF7xcj9Gm2N6YUuSkFNWUnkev6iKz6eQVeyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WsXEt03rYwGXma+YK8JHkDArPL/VDC+WUTJ5m0TRmbw=;
 b=AVMymlQbaxdBSB9aqn2nSGcBw+9TyJrvGdwa/NDN1zPoeBLaSVu/08at62bOegrF6YMK23hHpzopdm7p5bEIFtp7FvN7WRcEvppq+LBbNwrG75hj01kzbGCZ/V5fS/borTlMAhdUYhvAy3GHnQ7RsghryT3iRzjMp7StlqRjDusMRY/4RLLk9ta3xHgWo4zgoDrq8UJe4pPiymKwroE4u4ypcdI0rrLfLS3qFbXO+gaJWfmNojOCLcDLNYekI+4EQ5sUKU4TMcmgNKVHLp9VwmBHM2GZ9OyoavDOnqAGi/MxJIM31ZW0Tjydpu1hq/rPa74m6TwW97DMoQ86YQLJKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <68a10516-7737-5bbe-e9e5-537031251fcc@suse.com>
Date: Mon, 11 Apr 2022 11:37:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 5/8] AMD/IOMMU: replace a few PCI_BDF2()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0012.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9b0986ff-aca0-4f27-bb23-08da1b9ef3d2
X-MS-TrafficTypeDiagnostic: AS4PR04MB9364:EE_
X-Microsoft-Antispam-PRVS:
	<AS4PR04MB9364B7BC1E5DA459670780B3B3EA9@AS4PR04MB9364.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dNKZiZNvjAZZe7HhoBg7ZhOyg2+UvUv56WtdWkXTyMR0Wrt3POpFWRespPN0HH2AlB7Z9N+yanLgw0qnK15BuSY5W05nmduYzt7j+8E3Dq5MffOetZoFOr/qXh6J/YCexELIHgQpOAJf5n6ooXqCvM2avzD7cK3EkNYy9u7FESiWbqOQ7GUaf4tCmtbLA/OPoHSm0si1Ylwc6W/skQR+fiAgYjKRL5ATizTk/APte0JHW0R/tIPAYDjAbhnncLwb4egHJQsO/SQheuiGvOxcknT1jLWXl5I4JYwck8SW/eo6l7G8ZpI+fSGj5RKfJuwC/91dLbap+LXxCITzUXx5+TyR15hpubtqDVpTRPtr82a2Vy2fUArRalGlFMqpHb4GDlWOV/M9CP4zwOHZYXNidJX/So8pY17cnSZsSI7qno0vKhFYCAh9L/EI/qPHRO5nlM7Ytv2XZ9XAvJrb+odtRA9GFU/Y0jKhUTMl7Kf5KNwodPsvBFSQrvMs+O/StB1koc5guNou3uuol680dF3bW/MohZ92Ag0k7VGelIcusloXDTJHPWKAoIRLe6EZGdK8fQhFYkpo9Y3JH6MOHJnFAy2lofKSCchq7fkOWzsfuOP5oICv0iNDsxQ6H8oMueiyJkvB1x2i8XY/MQILz9MGzcIrapV0JQS78xIU+UUlilkFCaoCiu6Ba4W6DW8idJQNZRqPYpCscKbPBq1Ocsngq9sM33NGBIWsCd8cCvW06ibj5HTIKX3jmZUbi6Chyl+C
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(66556008)(66946007)(66476007)(4326008)(2906002)(186003)(31686004)(8676002)(36756003)(83380400001)(6506007)(2616005)(5660300002)(6512007)(6486002)(508600001)(86362001)(31696002)(6916009)(316002)(54906003)(8936002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M0hpMlBOLzFGN29kaVhTMmlwR2s0UWtndVVXRUpidU92OHVVbVJhQWVCZkNS?=
 =?utf-8?B?SEdNU2xOcnF6UkVTSlFlRld3Z3M0UVR2RGVJYXVSSWV5VUhqN3kyU1l2WFhs?=
 =?utf-8?B?cENiZjdpMUY3VWZueG1uQzFFOTFHQzFRS1RSUS8xTzNGVVBqT0U0ZkIzZkEw?=
 =?utf-8?B?RDVpbURTbkV2VWd3MVZMTVhycDRnTmpBSWVGckppanNrdWdxdVBQOU5vNHlT?=
 =?utf-8?B?aWFHL24veFJYZ2ZCbVdGc1RDdVBWSGlzSUFrTk9nNFJycXRRWDUxbGw4VU9U?=
 =?utf-8?B?dGxuM25SUHJSM253cituVWdDSFBBczY3S2k2S29xR0FkWjVTZjRxM0M1UFBC?=
 =?utf-8?B?R0VITUdrN1dOaU1iSHJ2UDlRYit2K3NXbk9jWVMyZURoWWxNNnp0MjArZ1RC?=
 =?utf-8?B?eEh0cWplemRZN2JTNk03eWVlbVRXY2RyWlM2T1pIZXpRVlBkV28vS2Qyb3Ux?=
 =?utf-8?B?NmJNMU0xTHVrSlNseTRzbC9WcEd6MFBuODFjYnRZUFRXUTBuK1ZFcUxZWVBB?=
 =?utf-8?B?YTA3K2NFU3FJTHE5T1krYmMxZ1lxR05oOTIwbEUwV1hJV3Fvd1F3REhINWtJ?=
 =?utf-8?B?MmRwbURJWWk5dURqL0I5dUlHNjk2VXBMTXo5Z2FxOFJxbjU0TnZTYlBCOFNj?=
 =?utf-8?B?Ukh2OGpEdG5xTFo0U0IzRjNtL29hRElTL29CeVNaSVBTUFovMHBSb2xiYmFx?=
 =?utf-8?B?MU5CZHZIZjJLdjRLdkRYNEhaVE44QUt1WEF4MFZTbmhtaEIwa1ZUT0dFMHV6?=
 =?utf-8?B?a2xwMzlRMEpYNzYybE40d3FlNnU2NDY3a1NFa1ZaaE1Fcml3U1ljNDJ3U2x2?=
 =?utf-8?B?MjdmVmt1eklkWmJYQVV0RzV1WFFXbjFaUnE2dHE4NDAydy9lZTF0YjU2WXdu?=
 =?utf-8?B?cXUrSmU5OXJwdDdyeEdacHBET2lJWEpoYjVOaDRiOEd3L1hzdWlkVFdQTHpx?=
 =?utf-8?B?M0VVN0s1VnV2YTZMZFlHZkpvSThLdFlZNFZxRTN0WjkvamZzTVpuWXRLOWdN?=
 =?utf-8?B?WndmakFXS2FJRmNWOG1zKzZ3Sk1yUjd1Ty9vMXhpcnNraEpKVXdZdWpNY3B3?=
 =?utf-8?B?REMwMlU5WlJwNmtlUVR2Q1pPWEpjVkdUTjJ4TVR6cTZCQmZ5enhtcXVVWmlv?=
 =?utf-8?B?TWgzRkFNQXlCMjhmMm5zYndoOENWY1pqZVBMUTB3NTdFN2tSZHh0ZkplYzJn?=
 =?utf-8?B?RkhvSGpjcnlPbVBDT2wxZWVKNXNpNjk5VUM5SThrWklGdzRHVGxabVJLOEZm?=
 =?utf-8?B?RkYyZjZpOGU2VDd3ME4xd3RqMFB3Y2pCSkgrd1JPUUxUOXF6UjZaVEFTNmdT?=
 =?utf-8?B?K3l5NDdxdk04ekg3THdEeGtuQm5XdE9NM2VRcElpTXFYbTVYbnZRdVoxTWgy?=
 =?utf-8?B?cVJtVVFTenh3d3B5L1IySko5em1hTFdxanFUbDZ1cnd0TG1MbU1qcHZGMndF?=
 =?utf-8?B?T3FiRkw3bWRBR3ZNS3pVY1RUNVNOcHZmbFFacEUrc2hBM0thYlo0M1d2UEVG?=
 =?utf-8?B?Y3lyRTJ5SUdLbWgvd0xiUnFJaUxUaktFM3NCL3gra2d6bFhqczVacFhYOVdo?=
 =?utf-8?B?NzRVTTAvVmlHNDVnOUthOThOUGZVcmhzZmo4TnZraVNSWE9mYXdBbTFXYjNQ?=
 =?utf-8?B?T2pKVmRSeGZoV2dZa1l1QS9CQkpWR2toQWJQbXQ0KzZUMGJDbXlCRWxpeVJh?=
 =?utf-8?B?SVA3OHNMMUQ0TWxYcStDYUN5UGdUcmpvbnFlUE1ybWpxTUJadkxBUEZwR25o?=
 =?utf-8?B?UFlUUGprRHI0TGJQdTdJL2xWMkJtMUFnTStzci9LakVhZ0NLdjJFVXpJWURU?=
 =?utf-8?B?RnVkNDdYMVBPMFd6cUEvMTUzd3BEZjAyRFppUzM3SE9CZk51WXNqcjMwdHR0?=
 =?utf-8?B?ZUJFc25SbFUvdUxjTjF2M0NzQklCcXpiNnhNOGJMM21YKzB1SUNRYVRVZEpH?=
 =?utf-8?B?WFpFY3o1MzUwbkZtTllkZmRpVDJ2UEsyRHBlVW1uSlR2ZjRSanNzQ3B6RzZT?=
 =?utf-8?B?bFJRUUo4RGo0T0xqM1VuQWk1Z2dFbkxwS2NoK3phZER2bkVnWkN3aERUWVRB?=
 =?utf-8?B?aGZESVdhK2dMTVBDQXlwNWFoNGlmUUU2b0pZZ21lQXFzOGdvMFloNzFOY1FP?=
 =?utf-8?B?ZnBhTG5jK3VkcEprS05PeXZDSWlON1VJNGJERWovYlNnUU9rZXhURHdHbFh4?=
 =?utf-8?B?b2NoMFNZRTQrVzVqb0NTNVExUUFtbGlkamZkQzJjamE3aDhoWmE2VXFybnpx?=
 =?utf-8?B?M09RRTIvbHBQdXZjSGNoRVVyNnpIeCtqeTRLbkJ5RHVIMFI3Rlk5cmJlaTZh?=
 =?utf-8?B?cXQxRzVNMUNnYmt1RllDamltaW1jckY0MUdoUTNlcEVwWFJnVWl1Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b0986ff-aca0-4f27-bb23-08da1b9ef3d2
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:37:53.7052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b4Ep4COoCpr0Z4C4d1u2ZryXr055Q2+OdQcaT3SwebcdjhWIRRqgJLk+pz9hNzpvOJ0ZSYnKs8QYorREE7+azg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9364

struct pci_dev has the wanted value directly available; use it. Note
that this fixes a - imo benign - mistake in reassign_device(): The unity
map removal ought to be based on the passed in devfn (as is the case on
the establishing side). This is benign because the mappings would be
removed anyway a little later, when the "main" device gets processed.
While there also limit the scope of two variables in that function.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/amd/iommu_cmd.c
+++ b/xen/drivers/passthrough/amd/iommu_cmd.c
@@ -287,7 +287,7 @@ void amd_iommu_flush_iotlb(u8 devfn, con
     if ( !pci_ats_enabled(pdev->seg, pdev->bus, pdev->devfn) )
         return;
 
-    iommu = find_iommu_for_device(pdev->seg, PCI_BDF2(pdev->bus, pdev->devfn));
+    iommu = find_iommu_for_device(pdev->seg, pdev->sbdf.bdf);
 
     if ( !iommu )
     {
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -617,7 +617,7 @@ int cf_check amd_iommu_msi_msg_update_ir
     unsigned int i, nr = 1;
     u32 data;
 
-    bdf = pdev ? PCI_BDF2(pdev->bus, pdev->devfn) : hpet_sbdf.bdf;
+    bdf = pdev ? pdev->sbdf.bdf : hpet_sbdf.bdf;
     seg = pdev ? pdev->seg : hpet_sbdf.seg;
 
     iommu = _find_iommu_for_device(seg, bdf);
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -455,11 +455,9 @@ static int cf_check reassign_device(
     struct pci_dev *pdev)
 {
     struct amd_iommu *iommu;
-    int bdf, rc;
-    const struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(pdev->seg);
+    int rc;
 
-    bdf = PCI_BDF2(pdev->bus, pdev->devfn);
-    iommu = find_iommu_for_device(pdev->seg, bdf);
+    iommu = find_iommu_for_device(pdev->seg, pdev->sbdf.bdf);
     if ( !iommu )
     {
         AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be assigned to %pd\n",
@@ -489,6 +487,9 @@ static int cf_check reassign_device(
      */
     if ( !is_hardware_domain(source) )
     {
+        const struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(pdev->seg);
+        unsigned int bdf = PCI_BDF2(pdev->bus, devfn);
+
         rc = amd_iommu_reserve_domain_unity_unmap(
                  source,
                  ivrs_mappings[get_dma_requestor_id(pdev->seg, bdf)].unity_map);
@@ -558,13 +559,11 @@ static int cf_check amd_iommu_add_device
     if ( !pdev->domain )
         return -EINVAL;
 
-    bdf = PCI_BDF2(pdev->bus, pdev->devfn);
-
     for_each_amd_iommu(iommu)
-        if ( pdev->seg == iommu->seg && bdf == iommu->bdf )
+        if ( pdev->seg == iommu->seg && pdev->sbdf.bdf == iommu->bdf )
             return is_hardware_domain(pdev->domain) ? 0 : -ENODEV;
 
-    iommu = find_iommu_for_device(pdev->seg, bdf);
+    iommu = find_iommu_for_device(pdev->seg, pdev->sbdf.bdf);
     if ( unlikely(!iommu) )
     {
         /* Filter bridge devices. */
@@ -648,8 +647,7 @@ static int cf_check amd_iommu_remove_dev
     if ( !pdev->domain )
         return -EINVAL;
 
-    bdf = PCI_BDF2(pdev->bus, pdev->devfn);
-    iommu = find_iommu_for_device(pdev->seg, bdf);
+    iommu = find_iommu_for_device(pdev->seg, pdev->sbdf.bdf);
     if ( !iommu )
     {
         AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be removed from %pd\n",



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:40:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:40:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302797.516570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqXA-00029h-PC; Mon, 11 Apr 2022 09:40:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302797.516570; Mon, 11 Apr 2022 09:40:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqXA-00029a-M4; Mon, 11 Apr 2022 09:40:32 +0000
Received: by outflank-mailman (input) for mailman id 302797;
 Mon, 11 Apr 2022 09:40:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqX8-00029U-OG
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:40:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6c71e83e-b97b-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:40:29 +0200 (CEST)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2059.outbound.protection.outlook.com [104.47.4.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-c9mMjQfyOAqrDY-zPijx3w-1; Mon, 11 Apr 2022 11:40:28 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4255.eurprd04.prod.outlook.com (2603:10a6:803:3f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:40:25 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:40:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c71e83e-b97b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649670029;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uRgxPutiiXf/saj/uPcnRpqmyyUE+aGnEJJuikrPuyY=;
	b=boReclB7xzohkKsbguMNvdfBtD6ydU6AM3Ta2mygW9/xzHzyTipfza4CwKMG7lkFwRqmjr
	or32k2ep0j/IVkzCvFGXmPaWmq7KUn5Zwl/jMDdXD98hrYV91ge/kwxbf/ED7tJ/kuKIx3
	LP2auhQtuScgzKNTvaIwwe3WMguixzY=
X-MC-Unique: c9mMjQfyOAqrDY-zPijx3w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cj7XvMeYAotiN0cRAts3A3/X/fxFqCpO3A77Ueeylxp3ti7SZIAHoHk7JIF07kIffBBdAKUifSmEafLJ9UnDR9BPN7AVa8O2EAvR3UR9boq2lQB71YdYDVY4lmYqIeSe5xL/4AvWHM5Ep+SDTzGfWqJcXYyq2Eq8H1LLqprLzo8WjI+ZflQMnktVgV4LdH6gV2StBpJ6KvkqxKPuKLKigAwpQqRgXoEhBx5TzlWjRQXrIdW4jaVf+ZBkNReLaQutS3Wo/x0LFKilBK6dVf95fGhxXKDvM1b/CQeenHRxkefRGADz1JVSJ0xFqKMRY8d5KeQcm636x3kB7TKMcpGsQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uRgxPutiiXf/saj/uPcnRpqmyyUE+aGnEJJuikrPuyY=;
 b=aIKHyWPNH//hDystYO6BUpgaOVIUMXoLK712SjMlBuTndoSHCyWgaeFQtWmefNnYsSiMm2KOASReqe16Hh90abcf8Td0aGet714jP88YQocmEtBeI9iPpjRPFoD2DV3VtHEEwk2yKOn7wXnk7gPB3risP2g/293oxgXsBkvW5dH3nEgvNVba1ppqCHuXkyRE13Nv/1yRmnMWXk8eNjko72kfuo/qPK9Ur4HonFd/H+0s6vMRP/DelyPPAeg/9DtUHHMrR/OPM4rZFH+HHCKHEj1DDKGrDVzJxPpJkOv6ALvAnXjh6aeEVfMpnmg0J/WKMibWa6xhKbbGWneZTn6VwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
Date: Mon, 11 Apr 2022 11:40:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0067.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::44) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 200dc4f4-e19b-4789-641f-08da1b9f4e89
X-MS-TrafficTypeDiagnostic: VI1PR04MB4255:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB42559137A13CBDC62A1E9B0AB3EA9@VI1PR04MB4255.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NvkFD4KO5QOPvZAK6YRJN3ZgJ6X9LbusCnJGo8mIZUVh/ii4FQ4UktnlyYv7iLik+Cs2zKKGDOGw1yBQCXYWKWzIspXpDtGaVwpJ0D/cPlOnZM5/3XrSA5AmIWHfFyPO2QudY2EWoNsGCce3EI0u9Gifbe+cuTVKflmTinCAidpMVocuCWlHa/kaS8F6+ISIkb45mltR3uAgWVk1uPRkNcx+aJ0T7759shX7ekOdgECl2jIsynl1KIQnKJQ+fQVvhh725K8Hrg0CItGouEJBUBDDQMPI/H+QwXUNfsKPsOP6hyA/Qbt45nCQOv6TCFEZUvmkw2A+/N6tKscmd+9WgU7BOqZGRxsbjOcUbBTPkzq7Vl08kaT9R7KTJZtTOiuzJ/lIVwxoG5COCrXct0bSoeUOcSmUYriUJIFB419b3ua1YnHdPU0df6/8RwPSh5+o6qykE2EsFZjio8leouvQ3aY4vSeEESRo9jLSzCDn8sVFK3GgPink6n2n4rluAUk2J1dHUsjAyRPm/j0lz3BOnoJItpLQzAHh6cEm79cwnOXth7d+Tbkmsw0JdRIKCh4UrQ3xUOuVPfPTONPZHXXgvhVcwYgDWMIke1Kv0i+POu0wNO9o3brK3WIAROt0iBvCdXs+WzCUWtwjVqeP0Qn8alxlExlZirznG5LTqhbo2j3fgXtv+pJ8GgsLJHTDv8kOFzWklM7qAgFkwy/r1FfJc3/ff88gyNK9wpU3DzHb11NL7pvDG3Cr5UeGpY/VNmMM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(8936002)(7416002)(31696002)(38100700002)(2906002)(5660300002)(6512007)(66476007)(316002)(6506007)(26005)(54906003)(6916009)(2616005)(186003)(36756003)(508600001)(6486002)(66946007)(66556008)(4326008)(8676002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?alI3R2ZFMksyOCszdVJ5WEVpME4wek5iaFhubkErR1FUOXpVMlFqSVhybjB5?=
 =?utf-8?B?dHl1V3Z5NjdUQTJnV0pqYjg5T2N4WXkvY2dGQmxrRXVoN2hNSEtLOU1FYWFm?=
 =?utf-8?B?bUNCaFhlUjhLKzNydnhjOHBFN0l0bCs2Zk9ZSktaNW81Ui9QcjhJWUNscG82?=
 =?utf-8?B?dzNET2hHTDJPRVYvUVJJQmJVK3BmeHI3U0xTU1hmOVJiUzBuK0N6aUNPSnNj?=
 =?utf-8?B?TkNkSUR5c0hSV1IvaE9wcGFUcGJLbEhzVUFhcUdwYnhScXRod0x5eUROMjRx?=
 =?utf-8?B?OWJkeEI3YXNaeUtxamQvNFhWdUxCbzNWeTdxbXZaRW5mMGtWdmFkbzlDTER1?=
 =?utf-8?B?bmhURDJ6MGxtMFFKQjJudXVobHRheFpmS0dxNWFxUFB5T2NsSE8xZ0F0TkNt?=
 =?utf-8?B?WmRBV1BQZTdGbkFFaDJsU3hSUkhsbzRBTUpGUklpS2dYeHI0MTBJWGFJam55?=
 =?utf-8?B?elNjbmc0aDhoYTkrK1FHdE41K21XUDIzRXRpNGxvWm9jNWZBQVE0OHArZVhL?=
 =?utf-8?B?QmhjdmdGTEFlZkUzbG5uOTRUcUdYS0dXd0wwdjc0azU3NXhqOFowdXhEMDlV?=
 =?utf-8?B?YmxybWErWnplOHpxVFo1MGFCZkFpMCthUWVUNjNrcXZXN3BUeXp2emxJMmJr?=
 =?utf-8?B?MEo2Nmt0U2tjb1hMemxNbDRFU3BsYS9yWm1aS3VqanlVSDh6NldxbFNEdG4z?=
 =?utf-8?B?ZkZJdThGWEpZMFdoaGpyZFVqTkZJRkhTT1ZMY0dSVDJuaWp5VEcxQjVmZWh2?=
 =?utf-8?B?bEtzYUtWOUdKWDV6OGNYRld6T3N6K0ZjNGl2MUpBOWZjODBLM2hMUStlNWR3?=
 =?utf-8?B?RERLdWhUYXhnNjh4L3M5SzdaNTNlaXZ6eU9KVmNLN2RZOW01UCtCMTQxMjRT?=
 =?utf-8?B?aHBlUjVacVF6aTdtUWdheUt0ankyRjhSYlhxZVJGL3hyejgrbWtFbDh3Q3hw?=
 =?utf-8?B?aU4rckx5d0plOXlSY0ZVdkVoTUhRZXdjaWpKSDZwc2hzTDhYcU1PMm1qa2Yv?=
 =?utf-8?B?aHkvbkwrK1Vib1M1N1RIV01TeUZDZmJMZ1JtRnFmWWIzVlZTNVBkSFJYOWpL?=
 =?utf-8?B?cnd6SHhYNFVlZ252T0Qzd242OElwUjB5eXJ5ZEYzdmNzREd3dVdlM2FQWGJv?=
 =?utf-8?B?eml6T1pEMlpzbWZSbk0ycXZOdG9BTzA0MjhtNllLWUl3YlJsaUl2YUExQ0dF?=
 =?utf-8?B?ZjhBazZXeVc4RTZlVE5PaWdjVmdqVnUxNzFUNDRQS3N3T1duRjlIQUtPMTlr?=
 =?utf-8?B?eDcwbGhxNGJSLzNPNVRPdmMrMG1ZWUpmU3c2TnIyZHRXTXVPOVkvcGFXTkJa?=
 =?utf-8?B?bEt5VnVDUzczcXB6VzBZblZ5R1pDMERST2pENUdxaUE2bVRNVTlsUVQvLzUy?=
 =?utf-8?B?YzFianpsdG5aOUVpdittKzJtU0c0VUhINTFkTEs3aUxmQVZON2tQNTNTMVVm?=
 =?utf-8?B?VHpQd0U3dTJMVXFlL3BmZExtajl5cHRmdVF6OTFWZmR1S2ZHYXlmK29mQ3N4?=
 =?utf-8?B?RG95QWQxQTVja0cvb0dLK1prcEVsOEZYWTJ6bEswWTluUUs5cm1YU0x3OXl0?=
 =?utf-8?B?cnRWb1A0dWUwbERLMFRLZzQwcTBvdWhVcytUd2I2TER0dW56WEcxaHZsajBk?=
 =?utf-8?B?QjlLT1ZON3VZQ2lpUlhHWUJsUDcwa1RGNm8wc1NNODBkVDZGcnhEL2xQMHBm?=
 =?utf-8?B?RnpGQ256RXU1VWxXNHVLRFRjQnliYzRTOERIQ29OL3lhSVBBK253Z01sdmRw?=
 =?utf-8?B?UTJQTnhreEFNV1g2eXlETk1iakdSSGErdDNsWTVXcGF5Q09UTjV1ZHhRYjRy?=
 =?utf-8?B?empXNWJXS2tjMWZ3RUVVbWY2WmthVXl3SVRTSUxNcU1iZE1FMXpldE9HUGM3?=
 =?utf-8?B?QVd1QVBlUFN0c2JzQVk0cGhkRkdGWGNoZXpxUVJXTU13MnV2STVSK1JTSisy?=
 =?utf-8?B?TThNWEpLR0hrd296eUxuTmZOcGR3QjY3N3VSZnl4dVAxVC9uSm43NjIzN3Bt?=
 =?utf-8?B?R2QwRjlHenZDcWQ4MlF0QXhSenhMUCsvTzdrckhXMmNLUHg5ckRQT0R1NjY5?=
 =?utf-8?B?QUpTeDJWa2JOb1NrQ1JDd0FRUzNUS1FzV0Q2YXhJUkpyS3ExZEFRVmw1aXRT?=
 =?utf-8?B?SStiTUNvSVZyTjVaWnBYa2dNS1VTRlpyVDBNaGpJUjVscW1ab3JtNDlDUkFo?=
 =?utf-8?B?YWNLMEFPU3NFWTVLR1JhamROWUs5VlJ0bnQwMzNiR01hVnVqbXhVRnFOUFhk?=
 =?utf-8?B?U2VWSlJDSUN2SWJTejJtdVJiaVZvVmtKYnhlQlp2Zy9MMU5qV1I0WFFyTHlN?=
 =?utf-8?B?bHhuQVRnZWVvVW94Z3JQd1RoZ1NhbXJESXdwd2ZxUTNHdm5NV1BFZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 200dc4f4-e19b-4789-641f-08da1b9f4e89
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:40:25.8816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u9iOVVYnU3u5MogYqurO8HqxYoN6UhHKXvtwQEukx0Qv3tnbHdLIlU71b4d/qgTzLZEcnBobTKIGPH9vXrfm4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4255

There's no good reason to use these when we already have a pci_sbdf_t
type object available. This extends to the use of PCI_BUS() in
pci_ecam_map_bus() as well.

No change to generated code (with gcc11 at least, and I have to admit
that I didn't expect compilers to necessarily be able to spot the
optimization potential on the original code).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Note that the Arm changes are "blind": I haven't been able to spot a way
to at least compile test the changes there; the code looks to be
entirely dead.

--- a/xen/arch/arm/pci/ecam.c
+++ b/xen/arch/arm/pci/ecam.c
@@ -28,8 +28,7 @@ void __iomem *pci_ecam_map_bus(struct pc
         container_of(bridge->ops, const struct pci_ecam_ops, pci_ops);
     unsigned int devfn_shift = ops->bus_shift - 8;
     void __iomem *base;
-
-    unsigned int busn = PCI_BUS(sbdf.bdf);
+    unsigned int busn = sbdf.bus;
 
     if ( busn < cfg->busn_start || busn > cfg->busn_end )
         return NULL;
@@ -37,7 +36,7 @@ void __iomem *pci_ecam_map_bus(struct pc
     busn -= cfg->busn_start;
     base = cfg->win + (busn << ops->bus_shift);
 
-    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
+    return base + (sbdf.df << devfn_shift) + where;
 }
 
 bool __init pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -839,7 +839,7 @@ static int msix_capability_init(struct p
             pbus = dev->info.physfn.bus;
             pslot = PCI_SLOT(dev->info.physfn.devfn);
             pfunc = PCI_FUNC(dev->info.physfn.devfn);
-            vf = PCI_BDF2(dev->bus, dev->devfn);
+            vf = dev->sbdf.bdf;
         }
 
         table_paddr = read_pci_mem_bar(seg, pbus, pslot, pfunc, bir, vf);
--- a/xen/drivers/passthrough/vtd/qinval.c
+++ b/xen/drivers/passthrough/vtd/qinval.c
@@ -267,7 +267,7 @@ int qinval_device_iotlb_sync(struct vtd_
     qinval_entry->q.dev_iotlb_inv_dsc.lo.res_1 = 0;
     qinval_entry->q.dev_iotlb_inv_dsc.lo.max_invs_pend = pdev->ats.queue_depth;
     qinval_entry->q.dev_iotlb_inv_dsc.lo.res_2 = 0;
-    qinval_entry->q.dev_iotlb_inv_dsc.lo.sid = PCI_BDF2(pdev->bus, pdev->devfn);
+    qinval_entry->q.dev_iotlb_inv_dsc.lo.sid = pdev->sbdf.bdf;
     qinval_entry->q.dev_iotlb_inv_dsc.lo.res_3 = 0;
 
     qinval_entry->q.dev_iotlb_inv_dsc.hi.size = size;



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:42:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:42:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302802.516581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqYY-00034v-3X; Mon, 11 Apr 2022 09:41:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302802.516581; Mon, 11 Apr 2022 09:41:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqYY-00034o-0U; Mon, 11 Apr 2022 09:41:58 +0000
Received: by outflank-mailman (input) for mailman id 302802;
 Mon, 11 Apr 2022 09:41:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqVJ-0006iD-82
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:38:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 28fa19fa-b97b-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:38:36 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-JxMcKwvpPn6rrxgyZM2EnQ-1; Mon, 11 Apr 2022 11:38:32 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM8PR04MB7844.eurprd04.prod.outlook.com (2603:10a6:20b:236::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:38:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:38:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28fa19fa-b97b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649669916;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GkoN9nC2qKwsSR3K+jJcseHwKHnMuECbT9MIWY/ddtQ=;
	b=HH46MiA0N6XHSw+LxS0jQjPkZXr9/clNme5gION92xoTUu/7OaOAcNR/9IVP9u2T1QLVS3
	iQU3kCYGg5gAqYKDjy7AQcA+AAMaC3872T9o+dUi/K1DBO1OlR8dbIutJS7/QPGTJdevvj
	mPwZlKTejT5sCUWqqw6cvCXJw1iJPjg=
X-MC-Unique: JxMcKwvpPn6rrxgyZM2EnQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bLY7ig+OCUvnW3I9U1ntzLJ+nxC7MMuf5Kw3YGiVtz1P1447uPHQVOKf/PXaP+cVcVhl9dzyWUxqN1LJBz/sLCAYXLz5HTM+T1snX/yQHX4OnwdZL2gpY0Hfzosg9i64g9R9JWMzH+VzWpl+DlWD652ZP2n0BEQQnimKQSiT9V6zN+m+vio/KsRaE9dzjsHW2UO4GyinUCTuqFRWZod+t2LW/x1vAGFPk1B9QnCHIq+FgqHGZnyGzO4lyqN464NoR0fWpZ5EpnzUW9gA9WFSFUcaPgRi0Nkf6gdWjvPCI8Dk+RgXu1U788KelQ/tFtsnkeeXwYxCTacZfdVuLzSYxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GkoN9nC2qKwsSR3K+jJcseHwKHnMuECbT9MIWY/ddtQ=;
 b=JJ3O7w+a3NxvPuN+lmTMZejaeDRcqABN+SM8kpb0qZxGCMw9VB6WzQ68w9LCTWevAAxudWbJm06i8usj+4ZV8mPpUELmdXTqLKhYIaLD/WR58ferg+/wbY2MWxZ1U/XFuTsJRSKyBiV1mh2mrKHsj4qCol+uzvxKmQ9mCbdh4jVuZ2Fzpr4+zlDWDyVIp+z9dxv/SkHtbi9ZpLPZp+jciE2uGykU3Ejyr1cQI3owB71rijf7SmEZP/6kn6l3OSKGYAhEVAZSO3xN5b9GluVd3zZ9+x8PoV8L5IPbUKLHEOpdV+v3vuTh0pTdAF191gkaqnV1bqPH8pPRfBWcgBGuNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e8780667-2307-fa7f-0768-753a83e00082@suse.com>
Date: Mon, 11 Apr 2022 11:38:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 6/8] IOMMU: log appropriate SBDF
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR0301CA0042.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::10) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 62c1f672-32b9-42f3-bd26-08da1b9f0906
X-MS-TrafficTypeDiagnostic: AM8PR04MB7844:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB784451B406F58A74A39BFD26B3EA9@AM8PR04MB7844.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FyqBRN7a4kn0xF/KgOFk9+i5OEHShGlSIBNXzF/cFWZw5V/RMR6d50ZfmroqWQonvrUg6kzzcNebyuVFkxXmPRTnZlCsTYe/AKwTgtXDKJanUXSj44eNcEFxfQmxvYFmpJMok+7z/uvgKkwNrz0V76iCMwEL0+ytKMOXkmiDr4HpwBelFHCwOYNYnFctO6F9UBPkI9Cp52zHFFHqnXmL7S6kA+biUzgD6rUFeNUMmopf6Sv0NO4Ge/spgguOTKVusROx45q4kjty0DPi8IjlDOaXydFRYrEwfRqyx9gKorAxhZHTY4/jok4WMgV3WXX7IuCTTwVrU4EHSu1OJipaDrXYchW0W8iLNq9mzWAZAGtvAf1+2zuV0rjfoXuovBbUvwuMWAIHehch8mlEoaCgCq78A+baEYCBjRFKGLclVkkP4gMTKADrCmQW3sJA/HBWokPYpf3eZhmN+c22vqGALAf6iCZrRyFpZe6q/vYsFAzyBglWyIjHDoaKwW6SrZ3wl/IiRRV5r3BcP70Ypn9oan5qqCoWFMWeuA/aI9o2D4gdN1+O5q2Kskuwvhn2aPzkrv69mdA4GW315jbTXjYAQEtK3Q22ZkUDiAn9BfzFeVhSMW1w4ksX0ncsJO0K/c6fVa3OzrLbDPcoSSG7oRXZQV/jS7afjqnsVO28+EmGk9Pp5nvwdeEpKbAJU5e+rGcgH0uwghTTe8JtyDIaWKP5IVc14ZglT+oC5kW0xXtaSpTmMFT5cN/NWx5baiqrXzWB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(8676002)(31696002)(5660300002)(6916009)(66476007)(66556008)(4326008)(8936002)(316002)(86362001)(6512007)(6506007)(83380400001)(186003)(6486002)(38100700002)(2616005)(26005)(54906003)(508600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3VkT0o4Qks0SWN2Sm1LYXJleDVSTllSSTFsYmtuN00xZ3hLZXRXV3kxN1lx?=
 =?utf-8?B?Rjl5bE9BaHNrMkFjTU0xaDVza2JiM1Z3RkV0Zk5LUGkxdDFHWXZFaDA1RE9s?=
 =?utf-8?B?eVQwYzVBUTk0VVpsNUZJMlB6bUVINjBBRHpIVUdRT0JnY0dzZUVUUjQxOGJZ?=
 =?utf-8?B?bzZxUXFJKzBMMitJRXBnaWJhUlBUQ0lGbDUwVlNiaTdXU3pMWmIvdFNiWkU2?=
 =?utf-8?B?Y1lENXB3aEY3RmZ3S0w2YjJEZVN2NWoxdWc5QTBUZGc3a3hrU2dQc1IwQ1ZZ?=
 =?utf-8?B?WWdjNTI2YW9JRHg4ak5NVUlMdG1pOVVYdGdZTysySTczWUpNTXlWbDBSOE8y?=
 =?utf-8?B?VWhvVmJ2MW5HaStPL01mcm85eDdTaVdKSU95SElYLzYwekJLRFRka3RodlZl?=
 =?utf-8?B?azIzZnhQL2tZSjArbEFRY0cxSVRkaERVbWNDR0ZjeHdET0F3MGQzSkxJeE5H?=
 =?utf-8?B?VHJacW9iOEt1Q1hwbWgzakFjazFBU0gvekM1MjBNRE1BOHVmbFF0aDMxNmF2?=
 =?utf-8?B?VlgyTUxtODR4Wkh5enRLeS93WkZ0WXhBa3lpMjhjeEkvWXB5VExHcVVxZ0ZF?=
 =?utf-8?B?NmFPU3RuZjNCc25GOFJZOGtyRXpvQ04ySjhYQ1p1a0V2Ni9vbWRlQ1l0RUNM?=
 =?utf-8?B?TGdwWVFjUlZScFBmRmdHZHdIMEdCZ3d4RWlZdU5EV0I4K3Q4NjV6NUtsSllj?=
 =?utf-8?B?Wm4xSVdZTU84RnlPaWJMbjVqcFNqNDN0UXJRVEVGeGluZmxiWWYxV04rZlFn?=
 =?utf-8?B?OUFjeGtFLytrbWtWUy91QlByZU01aW9Dd0JjREZEcE1GVHNyemgxSDFoMk01?=
 =?utf-8?B?SzRqYldKcFUxR2NBVzk3Z2pVOUs3REZzTUpXelVNNEFTVmp6bHU4Y1pLK0Qy?=
 =?utf-8?B?R29aMTJ5WUIvV1NWaFhFbTJVZjhBY2R3OXllcmRDRmx2Y054UDYzQWlPSm81?=
 =?utf-8?B?VVNBN2lqbXc2STl6NDZjNGY0RUZSU1dQTXdxNlpSbFBISTU5VnhUK0NuSi9R?=
 =?utf-8?B?bS9NOGh5a3RxTEkvV3RXYjJNcGJPWTBQSDlpWVBEUkFBYVIwKy81WFN6eTZU?=
 =?utf-8?B?ZUpEQmtYeGJ1MTJkT3F4YlhyUVNGRllJYzVkTmZPL0dmZkkyelpEbFJuWmdM?=
 =?utf-8?B?ZDZyaTRGVkpTUnA0Wk15YzdNRno5ZkVzWWtzSjNJS0YzbTNzYXB6NW9EWi9P?=
 =?utf-8?B?TElGanFxMUVwV2svTGhMMVJUM3lHM1ZJdzduQ2NYajA2RGEzUFBac1ZLVlFQ?=
 =?utf-8?B?WkZ2MEZ3bU9pUHEyQkM5RjJpZnRjZEhTNVRkUzFZMHFvak1FUlQwT2VxdUla?=
 =?utf-8?B?QTVIcU5xeitVTUcyZFJkL1hPT2U1ZUhTQ2VBSlRSVjBiQ2xYUzVFR0N5eVhH?=
 =?utf-8?B?ak5Za1BwRnVlcG5PcFg5bUNZeHVrSno5WUdOSEE2SVpaTTlVSUR0aEFnRDR3?=
 =?utf-8?B?emh0TEh4WEdLTEV3WnkzQnRvT29PSitrV3IrLytXaWtRemE1WGt0S1RncklU?=
 =?utf-8?B?eU15a0lLbno2NzF1RUg1Y05zMnBqbFBpalZ1a0hzS252RFVuSjJpRHRUUzlw?=
 =?utf-8?B?cHU5bkc3VmFXSkQ4VUsyRXdWMjdGRTk2Q1dKOHlMb09wUkpLdWRQT1VsU3Z6?=
 =?utf-8?B?Vm1SZkVsL081cG9XOUI2N1JuMVI1OXU0UzI2QnZkS292aEJjN1pJWk1IQTFW?=
 =?utf-8?B?N1YzQlowS3FNbXpuTU1JS0pQSVVpRURCRGxSVHJyZ0NxQ3diUGtqRFFDSjlO?=
 =?utf-8?B?Q1lnWnpGRXZCSUQzNFB4U0pKdVZFMDZHY2ZEVnZIT2VFTWhMaGdNL3RVa1pu?=
 =?utf-8?B?ci91TDgwZ1VwZ1JpZDBFU3JsSmNVaVV6cldPRDh5U296TU5xWG1sWE5uYTJM?=
 =?utf-8?B?S0NnbXJhKzhiV2gvNGQ5NmJ2dXYvOTQvM3dwdEVkSklXb0ZCVTZ1cUlRMHBF?=
 =?utf-8?B?bHdiQzEwTmZDUWJtbCticDB1MTVlOTJCT1FORmU3MVhUYjNPWDRkRW5kUXpD?=
 =?utf-8?B?RFkrR092VmFXTVZQUUs4bUtGVjVoWUhqejJ1NE1NZVNYNmJqN3UzUk0ycTlM?=
 =?utf-8?B?K3ljMmMwTWthZ29EejhEYWVvQVg0ekRhcGZNR0ladkdQZHR6ekFKTFZhazZO?=
 =?utf-8?B?Q21UOGtZQzZSRGJrVjlhSjBqMk05aFE2Q0lzd3RXb0hLNDdFaEFUTU9oL1dI?=
 =?utf-8?B?Qm0vUFNXdWV2RVJIR2ZqWURtMXQwQVVhc0FEWFU2WlpVM0l5NzJnRFdHWTB3?=
 =?utf-8?B?ZGpYQnAxMVFZVHphTHJHSUhhRmpPTmxNaTZkR2xxMDhTTHFQN29XQTV2OFlX?=
 =?utf-8?B?YURibFY3QWFFNjRCNkV5dmt0MXEzcDd3RW8wbk82RnJhNEFYdmltdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62c1f672-32b9-42f3-bd26-08da1b9f0906
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:38:29.2157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: csmPmRu9IfhsmFRAiiupboI+d5QlhJnhbeom7yBAKFqwq8wiOMpFo+/azqILBlx+Ouiu2JrK3fRuh7OQJ0BxDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7844

To handle phantom devices, several functions are passed separate "devfn"
arguments besides a PCI device. In such cases we want to log the phantom
device's coordinates instead of the main one's. (Note that not all of
the instances being changed are fallout from the referenced commit.)

Fixes: 1ee1441835f4 ("print: introduce a format specifier for pci_sbdf_t")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/amd/iommu_cmd.c
+++ b/xen/drivers/passthrough/amd/iommu_cmd.c
@@ -291,7 +291,8 @@ void amd_iommu_flush_iotlb(u8 devfn, con
 
     if ( !iommu )
     {
-        AMD_IOMMU_WARN("can't find IOMMU for %pp\n", &pdev->sbdf);
+        AMD_IOMMU_WARN("can't find IOMMU for %pp\n",
+                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn));
         return;
     }
 
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -461,7 +461,7 @@ static int cf_check reassign_device(
     if ( !iommu )
     {
         AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be assigned to %pd\n",
-                       &pdev->sbdf, target);
+                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn), target);
         return -ENODEV;
     }
 
@@ -497,8 +497,8 @@ static int cf_check reassign_device(
             return rc;
     }
 
-    AMD_IOMMU_DEBUG("Re-assign %pp from dom%d to dom%d\n",
-                    &pdev->sbdf, source->domain_id, target->domain_id);
+    AMD_IOMMU_DEBUG("Re-assign %pp from %pd to %pd\n",
+                    &PCI_SBDF3(pdev->seg, pdev->bus, devfn), source, target);
 
     return 0;
 }
@@ -575,7 +575,7 @@ static int cf_check amd_iommu_add_device
         }
 
         AMD_IOMMU_WARN("no IOMMU for %pp; cannot be handed to %pd\n",
-                        &pdev->sbdf, pdev->domain);
+                        &PCI_SBDF3(pdev->seg, pdev->bus, devfn), pdev->domain);
         return -ENODEV;
     }
 
@@ -618,7 +618,7 @@ static int cf_check amd_iommu_add_device
              ivrs_mappings[ivrs_mappings[bdf].dte_requestor_id].unity_map,
              0) )
         AMD_IOMMU_WARN("%pd: unity mapping failed for %pp\n",
-                       pdev->domain, &pdev->sbdf);
+                       pdev->domain, &PCI_SBDF2(pdev->seg, bdf));
 
     if ( iommu_quarantine && pdev->arch.pseudo_domid == DOMID_INVALID )
     {
@@ -651,7 +651,7 @@ static int cf_check amd_iommu_remove_dev
     if ( !iommu )
     {
         AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be removed from %pd\n",
-                        &pdev->sbdf, pdev->domain);
+                        &PCI_SBDF3(pdev->seg, pdev->bus, devfn), pdev->domain);
         return -ENODEV;
     }
 
@@ -664,7 +664,7 @@ static int cf_check amd_iommu_remove_dev
              pdev->domain,
              ivrs_mappings[ivrs_mappings[bdf].dte_requestor_id].unity_map) )
         AMD_IOMMU_WARN("%pd: unity unmapping failed for %pp\n",
-                       pdev->domain, &pdev->sbdf);
+                       pdev->domain, &PCI_SBDF2(pdev->seg, bdf));
 
     amd_iommu_quarantine_teardown(pdev);
 
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1406,7 +1406,7 @@ static int iommu_add_device(struct pci_d
         rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev));
         if ( rc )
             printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n",
-                   &pdev->sbdf, rc);
+                   &PCI_SBDF3(pdev->seg, pdev->bus, devfn), rc);
     }
 }
 
@@ -1451,7 +1451,8 @@ static int iommu_remove_device(struct pc
         if ( !rc )
             continue;
 
-        printk(XENLOG_ERR "IOMMU: remove %pp failed (%d)\n", &pdev->sbdf, rc);
+        printk(XENLOG_ERR "IOMMU: remove %pp failed (%d)\n",
+               &PCI_SBDF3(pdev->seg, pdev->bus, devfn), rc);
         return rc;
     }
 



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:42:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:42:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302803.516592 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqYo-0003SB-GT; Mon, 11 Apr 2022 09:42:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302803.516592; Mon, 11 Apr 2022 09:42:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqYo-0003Rv-Cm; Mon, 11 Apr 2022 09:42:14 +0000
Received: by outflank-mailman (input) for mailman id 302803;
 Mon, 11 Apr 2022 09:42:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqYn-0003RQ-Bq
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:42:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a8cf1c46-b97b-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:42:10 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-M7Rhd22AM-Sav96TeFIefA-1; Mon, 11 Apr 2022 11:42:08 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB7200.eurprd04.prod.outlook.com (2603:10a6:800:12d::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:42:07 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:42:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8cf1c46-b97b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649670130;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Py/JyO0vBJGMqJ1hK6JAceWT1qoE+ikG7idy1ZPeUKY=;
	b=NYub578PPk5wapht32R3PQA981h+Puak3kqwoYMmP1bbzfY8wQA458HQwDucDlKp4cEU0l
	9H8A0hX+TZKPL7FO4BZa+DBw4mVscMLNYhpPbkvETBmf3WjhcREIOnpgGkMGSjrLNfy6aq
	fmZA0R1PudVV+BCGgxeKVyhqsASKyOM=
X-MC-Unique: M7Rhd22AM-Sav96TeFIefA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i4oO1TU9cLr9A1SzCLek/somh+uMZmcGvyc95S4sCb6gmCUwigxrZLaignKG18SLpgHNARii8IujxIkGdaTegdr358i+Ythqd1KffDuTaDlETMFfRZ6/WnaUbw7YDpJutTWneExBd5V9ZowJOtZ0ifgean0Ovf/o9T0zjCrCdHVKzYVcpvO7Ji6kyHcvNDLYbsfI68RbvmzPCh0GC1+sRW036S4n8ozUFYIKLYiJnGG0vFMa4ITeVP/GHexJlEbrtg1yMqvkmnDKKk5UI5jd893tc9DBE58IIU5FEw9l0v7+t5YTjTnNKD2IsT7h4h4+FJLwnFzGapqZvAbbiMs9Kw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Py/JyO0vBJGMqJ1hK6JAceWT1qoE+ikG7idy1ZPeUKY=;
 b=DVxHwhDQSfZMCLztif2w++TgoXsl1rYhjlGStbGpvTQbzakUS4AT6vb47bWH9vDlrtz3ayCl3cCG2QFRDiMpWRLsh5k8yN3aSg8BFUTvWVoxoDK4DDQr2tAva7k0na/cPRkF/c4dAbUa/KqhInOkVedIXsWjr84Pncp+PEOI0Eycm4OROs1pjieihMNWqzFrB9DV7X8J6WtiHBJ4DLodT39se9lufSBq2xmu7tkz7Kma7XQ9iXk59ehD0dXPvf035YYSkWshF3fC0OfpcttCzGHSUeSwJqRnC0JtgqYBlOvJ9RdiFITFTiwrZzShCe9J8xPTeS1gd+fmGq6jRjP7Lg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <75623ef8-5aa1-b864-7398-b7980accaf32@suse.com>
Date: Mon, 11 Apr 2022 11:42:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 8/8] PCI: replace "secondary" flavors of
 PCI_{DEVFN,BDF,SBDF}()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0014.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 006a9268-5c50-435b-e8e7-08da1b9f8ad2
X-MS-TrafficTypeDiagnostic: VI1PR04MB7200:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB72006DD2032D114FBBDCDB70B3EA9@VI1PR04MB7200.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qzmvTXfiWQn48xzDWlxhu0x3gMKygw4pXKaEyJOlfLwQHotRVGNClmV1XoLBscS9RO5qBui1Gis5x/ao+w0ADQsMH9RQjYvlNrmsLw6MVCFfb0OqspNZMKpPGAkRDesAId0+R1kmbJrXm/v9MLezxK+3Txow8I1I1HARVfo543SxpqDO0I8iERhcFuEMruKKS7pRnNSMRA55jG+8YDJmDsnPdPJwBTh9CkRP4UrzgEXnqiQOmj93GzqU24ZtGavWedM7f/E7OfdmOS4LOxhBdWU6wrrhi8Lhz0BvhcarKukUpfOXCJDk8K8ljByJ7FAM2uBb5h9u7M1CcVDvWvCFEzyCI0FbFP60g3MWdVCv5vDIWUo0GirUNMun0TVYb10GLSmdWcbm0CoV69RNE7VWDSINe0o2fphZVwinwbbHns1dvcg6JrSg0hdo4E+xr1DhMYgUzaVqQOvixzxnxoDEwYzSz2AwJmUQRenuLS/YMMB6FoesnMs3lhziCV3eootoHAg3B2eABB3MjulEkleonyhwh3fZg/SYuqrIY/RojTQHzd3K2eMVhedE1VGkpSZ9L2j84fd8CCTW3hL0aFSBU7UHUXuA1jmQoPSrm4/FazvZL3tJOL9qflfKASEy3Y7xNIA8DfzbnjDlI60jUMgPNIJFVr5CAKYOdtFoJ1aDpPaWzKGkx/HQ15CBNEuT+T1ADRUs5sKBzZz8bYiFa0qExCKKshyUoFq8av4MUrXufyxxJzXOBObud9w+NGmUVYyfWUvmvpbjY6XuZuPbdVjFSw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(4326008)(8676002)(66946007)(6512007)(66556008)(186003)(31696002)(86362001)(38100700002)(2906002)(8936002)(5660300002)(30864003)(83380400001)(26005)(2616005)(6506007)(54906003)(6916009)(316002)(508600001)(31686004)(36756003)(6486002)(43740500002)(45980500001)(579004)(309714004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dk9Cc3ltWmFpYXJSRDVvcjJRZWZZZGtENGlCRTNQMzFCSGkxZDN3ZmVSZVdt?=
 =?utf-8?B?ek1QOVFRYmhsQTRCVWZxcUdLZ2NlZktabGF3SSsxM1ZnYWpraUdsaExUMFda?=
 =?utf-8?B?TTg0ckJQR0hKY2lJa2hLNDYxcUZUcTVBL1pXMzd3ZTRnNzIzT2VvYUlGd0N1?=
 =?utf-8?B?TkJseFdWcTAxKzNadlp5ZUNwa1hYTVlVUm5rN1Zncit4T1F5ZUxIRW9vSmlh?=
 =?utf-8?B?M2d6aVVBUHNXSWFaYWZQcElTNHJOSFVvNXIra3FxaktESXRyTWtoS1pSVjBp?=
 =?utf-8?B?cmh3RjhjNnFiNEpWM1hWemJLbEVHaEJ1Q0ppdFpoTTJ5Zk82b1NGMEhFR3Zs?=
 =?utf-8?B?eTBnN3ptTWNEdWNSOFROTnNzVm5YWXhvbU4xeThJMWFsbldPR3V6cmQ2TWtR?=
 =?utf-8?B?KytXYVhJcm9tSmxRQjdEa2ZpSUJoVFJnc1FCTEtQZ3hpUENKUWc0bnFycEJj?=
 =?utf-8?B?amlId3ZqSEgxYWtlSGFHMm54dFFNZVBsYnpPZ2YyMEE3V01JbFpiOXhFZnc4?=
 =?utf-8?B?L0Nyc1pYbzJXVWhVU2tyUTgvZU0wRlNjQjBOOTgwNVdZcUEvMmN1bHNJQzZN?=
 =?utf-8?B?NU50ejB4RW1CSzFUSkoxNkZFSXB4Zm01aVpUSFoxV00rMG0way9zcCt5UTFh?=
 =?utf-8?B?bDd4NTdiS3NVME1LeURMZmdnTGNzSXZoNUpLN2ZOZ0x0RkJzbzlyVHlVbEFh?=
 =?utf-8?B?dm1tS2hIUkR4cDZVeEJCeGpEWlhTZnJkTUxmZmIwTmppVXljNHNLZmIxaWhr?=
 =?utf-8?B?VmNvVCtwMFpxeE5XcjBLOTRUeEF3T0p5WklFMlVDb21LNHAwOXIzWi9LNFNn?=
 =?utf-8?B?bnVuS3NkNG9NUmZYTlBRcCtSZmwzU3RLd2ZDcHRpOXJaQTlpL3owNWFCOXBW?=
 =?utf-8?B?TnJtd05DamxXcGdldFRDZHhBQkwvSjJhVVlhcmI1MWd2VFRMdTZibm5Wa3ZM?=
 =?utf-8?B?cXZsVHJLRHBaM1FSNzliMTdXMW9PNUlRSGM0dW9Sa0RCRWE3clAyU0pXRGUv?=
 =?utf-8?B?bjZPVmFhWCtFcUs3TU5BcHpmSW5VejZzSlphaFpjWW5SWVJlVURzYjBEbG5U?=
 =?utf-8?B?cEFKMEhRdzgwd1U5RTZMOWNESUZrTVNBZDVDMFg3NTZ1aVFtaU9xSFNGTTFl?=
 =?utf-8?B?K3FXWGtnbythK2hPMlR5WjRZdmtLbGVtb093UFhOZlNzRkx3VEx1b1lEalY2?=
 =?utf-8?B?amJlRnphamg3ZW1COHBFZWhjbjlnSEVrTU5YNjJaODlmNnBTVVJJM3Z5NW9Q?=
 =?utf-8?B?QzBhbjJScE5wcUQ0aU1wMEhuUFBLZFhEQ0JoOTlkUHhtY1l4OE1IOTZlMUl3?=
 =?utf-8?B?YXlTUmJNNlZaNkc0R1NaTVZvK3lKTXpKZEw0dnF4M0FsZ1ZlT3E0NGlFazJJ?=
 =?utf-8?B?NzYvbnZjN01oQURnSUcvdnN2NldacGRyalcrVlNvQmE5WVJkRVM4alFuQ0t2?=
 =?utf-8?B?c0FFZzAxTVJ3Wjd5disrdjd3QzVxWWZXWS8wbXJsL3JQSU16bWNvTXBlaFU3?=
 =?utf-8?B?VVdZeThTZStHOFBUM2lPWFZ4ZUh6MGRYOUI2ZHljMVlQM3pWaHpLdmJJQmN0?=
 =?utf-8?B?dVhhL0NZT3J1WkhZeGxndXRkVW1URmVNNnlmY2JPNzlnbHlVbGEvaWxqdUNa?=
 =?utf-8?B?TjRGSWRQa0dTMzJyTzNtR09IUk04VEJjQXgxK1YzSzQ4SFlvVHFFWUhRQURk?=
 =?utf-8?B?akNYUlIxazh5dS8xeWVkcXFYMUtKdUsxT2E1cXhPK1F0MzBxSURreHBXTVRa?=
 =?utf-8?B?UG4rOXlUK1FhMmVjeU5SOW5zdEJPZFlNWk9TQ04xOUVYcVdJcStBZ2ladG5t?=
 =?utf-8?B?VDcxd3ZiaEFmSldMNHdLNENNNHF2RU9qcWxpTkVMVDlFNUdReGpaMXdNMWdZ?=
 =?utf-8?B?eUF4UWZ6NjMvdnZnTW9WekJTR010S3lnWXBZWXVNeHNERERaZ2xVRTZBSk5s?=
 =?utf-8?B?VWNrSXE0VW1BWEIycDd2V2hLeVFDV0w1OWxQN0srWW9Ba0dLZDMyRlI5M1Q1?=
 =?utf-8?B?SkVtL25ZczZCM1Q3QTloNSszdmFLU1BkcFU2RCtlazZseEs2Z3RycVFaRDRE?=
 =?utf-8?B?VTNTWW52WVN6ZW9COXlDSXRaS05aVFdyVzlXZnk4eVJJMFFtbG00bXBnWTNo?=
 =?utf-8?B?Qk9mOHU4S2NCZWczZ1BRNTIxRTl6YjZ1a1NIaHF4REdPT1h5ZVVuRlYzc2RS?=
 =?utf-8?B?TkFBVnR0WklIdS85M3ExUHBNbldKWU56c3c0OTJySUswNzhkRjEzZFBDa0dS?=
 =?utf-8?B?d3VQNU81akFPRFlqZ1ZrdEZBSUI2cDBDdG94QWxHbkhYL0JtUWZFMEpGNFBS?=
 =?utf-8?B?SWhsa1F5UURJT3hXT0k0QnRKc3M5WUhXdTVDWHc1enNQQkt1T2NtUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 006a9268-5c50-435b-e8e7-08da1b9f8ad2
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:42:07.0268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G7L8Snq/6eXwDOnsaZId8uQXJ1CMnsRbuJVuaBtuFGgQbuT5FBZCRScykeaHFNvX7VjK4xW7D0wiLXLizCcLZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7200

At their use sites the numeric suffixes are at least odd to read, first
and foremost for PCI_DEVFN2() where the suffix doesn't even match the
number of arguments. Make use of count_args() such that a single flavor
each suffices (leaving aside helper macros, which aren't supposed to be
used from the outside).

In parse_ppr_log_entry() take the opportunity and drop two local
variables and convert an assignment to an initializer.

In VT-d code fold a number of bus+devfn comparison pairs into a single
BDF comparison.

No change to generated code for the vast majority of the adjustments.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4902,7 +4902,7 @@ int cf_check mmcfg_intercept_write(
     if ( pci_conf_write_intercept(mmio_ctxt->seg, mmio_ctxt->bdf,
                                   offset, bytes, p_data) >= 0 )
         pci_mmcfg_write(mmio_ctxt->seg, PCI_BUS(mmio_ctxt->bdf),
-                        PCI_DEVFN2(mmio_ctxt->bdf), offset, bytes,
+                        PCI_DEVFN(mmio_ctxt->bdf), offset, bytes,
                         *(uint32_t *)p_data);
 
     return X86EMUL_OKAY;
--- a/xen/arch/x86/pci.c
+++ b/xen/arch/x86/pci.c
@@ -90,7 +90,7 @@ int pci_conf_write_intercept(unsigned in
 
     pcidevs_lock();
 
-    pdev = pci_get_pdev(seg, PCI_BUS(bdf), PCI_DEVFN2(bdf));
+    pdev = pci_get_pdev(seg, PCI_BUS(bdf), PCI_DEVFN(bdf));
     if ( pdev )
         rc = pci_msi_conf_write_intercept(pdev, reg, size, data);
 
--- a/xen/arch/x86/x86_64/mmconfig-shared.c
+++ b/xen/arch/x86/x86_64/mmconfig-shared.c
@@ -313,7 +313,7 @@ static int __init pci_mmcfg_check_hostbr
     for (i = 0; !name && i < ARRAY_SIZE(pci_mmcfg_probes); i++) {
         bus =  pci_mmcfg_probes[i].bus;
         devfn = pci_mmcfg_probes[i].devfn;
-        l = pci_conf_read32(PCI_SBDF3(0, bus, devfn), 0);
+        l = pci_conf_read32(PCI_SBDF(0, bus, devfn), 0);
         vendor = l & 0xffff;
         device = (l >> 16) & 0xffff;
 
--- a/xen/common/compat/memory.c
+++ b/xen/common/compat/memory.c
@@ -27,8 +27,8 @@ static int cf_check get_reserved_device_
     xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt)
 {
     struct get_reserved_device_memory *grdm = ctxt;
-    uint32_t sbdf = PCI_SBDF3(grdm->map.dev.pci.seg, grdm->map.dev.pci.bus,
-                              grdm->map.dev.pci.devfn).sbdf;
+    uint32_t sbdf = PCI_SBDF(grdm->map.dev.pci.seg, grdm->map.dev.pci.bus,
+                             grdm->map.dev.pci.devfn).sbdf;
 
     if ( !(grdm->map.flags & XENMEM_RDM_ALL) && (sbdf != id) )
         return 0;
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1055,8 +1055,8 @@ static int cf_check get_reserved_device_
     xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt)
 {
     struct get_reserved_device_memory *grdm = ctxt;
-    uint32_t sbdf = PCI_SBDF3(grdm->map.dev.pci.seg, grdm->map.dev.pci.bus,
-                              grdm->map.dev.pci.devfn).sbdf;
+    uint32_t sbdf = PCI_SBDF(grdm->map.dev.pci.seg, grdm->map.dev.pci.bus,
+                             grdm->map.dev.pci.devfn).sbdf;
 
     if ( !(grdm->map.flags & XENMEM_RDM_ALL) && (sbdf != id) )
         return 0;
--- a/xen/drivers/passthrough/amd/iommu_acpi.c
+++ b/xen/drivers/passthrough/amd/iommu_acpi.c
@@ -96,7 +96,7 @@ static void __init add_ivrs_mapping_entr
 
             if ( !ivrs_mappings[alias_id].intremap_table )
                 panic("No memory for %pp's IRT\n",
-                      &PCI_SBDF2(iommu->seg, alias_id));
+                      &PCI_SBDF(iommu->seg, alias_id));
         }
     }
 
@@ -790,7 +790,7 @@ static u16 __init parse_ivhd_device_spec
     }
 
     AMD_IOMMU_DEBUG("IVHD Special: %pp variety %#x handle %#x\n",
-                    &PCI_SBDF2(seg, bdf), special->variety, special->handle);
+                    &PCI_SBDF(seg, bdf), special->variety, special->handle);
     add_ivrs_mapping_entry(bdf, bdf, special->header.data_setting, 0, true,
                            iommu);
 
@@ -816,7 +816,7 @@ static u16 __init parse_ivhd_device_spec
             AMD_IOMMU_DEBUG("IVHD: Command line override present for IO-APIC %#x"
                             "(IVRS: %#x devID %pp)\n",
                             ioapic_sbdf[idx].id, special->handle,
-                            &PCI_SBDF2(seg, bdf));
+                            &PCI_SBDF(seg, bdf));
             break;
         }
 
@@ -888,7 +888,7 @@ static u16 __init parse_ivhd_device_spec
             AMD_IOMMU_DEBUG("IVHD: Command line override present for HPET %#x "
                             "(IVRS: %#x devID %pp)\n",
                             hpet_sbdf.id, special->handle,
-                            &PCI_SBDF2(seg, bdf));
+                            &PCI_SBDF(seg, bdf));
             break;
         case HPET_NONE:
             /* set device id of hpet */
--- a/xen/drivers/passthrough/amd/iommu_cmd.c
+++ b/xen/drivers/passthrough/amd/iommu_cmd.c
@@ -40,7 +40,7 @@ static void send_iommu_command(struct am
                      IOMMU_RING_BUFFER_PTR_MASK) )
     {
         printk_once(XENLOG_ERR "AMD IOMMU %pp: no cmd slot available\n",
-                    &PCI_SBDF2(iommu->seg, iommu->bdf));
+                    &PCI_SBDF(iommu->seg, iommu->bdf));
         cpu_relax();
     }
 
@@ -84,7 +84,7 @@ static void flush_command_buffer(struct
             threshold |= threshold << 1;
             printk(XENLOG_WARNING
                    "AMD IOMMU %pp: %scompletion wait taking too long\n",
-                   &PCI_SBDF2(iommu->seg, iommu->bdf),
+                   &PCI_SBDF(iommu->seg, iommu->bdf),
                    timeout_base ? "iotlb " : "");
             timeout = 0;
         }
@@ -94,7 +94,7 @@ static void flush_command_buffer(struct
     if ( !timeout )
         printk(XENLOG_WARNING
                "AMD IOMMU %pp: %scompletion wait took %lums\n",
-               &PCI_SBDF2(iommu->seg, iommu->bdf),
+               &PCI_SBDF(iommu->seg, iommu->bdf),
                timeout_base ? "iotlb " : "",
                (NOW() - start) / 10000000);
 }
@@ -292,14 +292,14 @@ void amd_iommu_flush_iotlb(u8 devfn, con
     if ( !iommu )
     {
         AMD_IOMMU_WARN("can't find IOMMU for %pp\n",
-                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn));
+                       &PCI_SBDF(pdev->seg, pdev->bus, devfn));
         return;
     }
 
     if ( !iommu_has_cap(iommu, PCI_CAP_IOTLB_SHIFT) )
         return;
 
-    req_id = get_dma_requestor_id(iommu->seg, PCI_BDF2(pdev->bus, devfn));
+    req_id = get_dma_requestor_id(iommu->seg, PCI_BDF(pdev->bus, devfn));
     queueid = req_id;
     maxpend = pdev->ats.queue_depth & 0xff;
 
--- a/xen/drivers/passthrough/amd/iommu_detect.c
+++ b/xen/drivers/passthrough/amd/iommu_detect.c
@@ -231,7 +231,7 @@ int __init amd_iommu_detect_one_acpi(
     rt = pci_ro_device(iommu->seg, bus, PCI_DEVFN(dev, func));
     if ( rt )
         printk(XENLOG_ERR "Could not mark config space of %pp read-only (%d)\n",
-               &PCI_SBDF2(iommu->seg, iommu->bdf), rt);
+               &PCI_SBDF(iommu->seg, iommu->bdf), rt);
 
     list_add_tail(&iommu->list, &amd_iommu_head);
     rt = 0;
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -562,7 +562,7 @@ static void cf_check parse_event_log_ent
 
         printk(XENLOG_ERR "AMD-Vi: %s: %pp d%u addr %016"PRIx64
                " flags %#x%s%s%s%s%s%s%s%s%s%s\n",
-               code_str, &PCI_SBDF2(iommu->seg, device_id),
+               code_str, &PCI_SBDF(iommu->seg, device_id),
                domain_id, addr, flags,
                (flags & 0xe00) ? " ??" : "",
                (flags & 0x100) ? " TR" : "",
@@ -578,7 +578,7 @@ static void cf_check parse_event_log_ent
         for ( bdf = 0; bdf < ivrs_bdf_entries; bdf++ )
             if ( get_dma_requestor_id(iommu->seg, bdf) == device_id )
                 pci_check_disable_device(iommu->seg, PCI_BUS(bdf),
-                                         PCI_DEVFN2(bdf));
+                                         PCI_DEVFN(bdf));
     }
     else
         printk(XENLOG_ERR "%s %08x %08x %08x %08x\n",
@@ -631,18 +631,13 @@ static void iommu_check_event_log(struct
 
 static void cf_check parse_ppr_log_entry(struct amd_iommu *iommu, u32 entry[])
 {
-
-    u16 device_id;
-    u8 bus, devfn;
-    struct pci_dev *pdev;
-
     /* here device_id is physical value */
-    device_id = iommu_get_devid_from_cmd(entry[0]);
-    bus = PCI_BUS(device_id);
-    devfn = PCI_DEVFN2(device_id);
+    uint16_t device_id = iommu_get_devid_from_cmd(entry[0]);
+    struct pci_dev *pdev;
 
     pcidevs_lock();
-    pdev = pci_get_real_pdev(iommu->seg, bus, devfn);
+    pdev = pci_get_real_pdev(iommu->seg, PCI_BUS(device_id),
+                             PCI_DEVFN(device_id));
     pcidevs_unlock();
 
     if ( pdev )
@@ -751,12 +746,12 @@ static bool_t __init set_iommu_interrupt
 
     pcidevs_lock();
     iommu->msi.dev = pci_get_pdev(iommu->seg, PCI_BUS(iommu->bdf),
-                                  PCI_DEVFN2(iommu->bdf));
+                                  PCI_DEVFN(iommu->bdf));
     pcidevs_unlock();
     if ( !iommu->msi.dev )
     {
         AMD_IOMMU_WARN("no pdev for %pp\n",
-                       &PCI_SBDF2(iommu->seg, iommu->bdf));
+                       &PCI_SBDF(iommu->seg, iommu->bdf));
         return 0;
     }
 
@@ -778,7 +773,7 @@ static bool_t __init set_iommu_interrupt
         hw_irq_controller *handler;
         u16 control;
 
-        control = pci_conf_read16(PCI_SBDF2(iommu->seg, iommu->bdf),
+        control = pci_conf_read16(PCI_SBDF(iommu->seg, iommu->bdf),
                                   iommu->msi.msi_attrib.pos + PCI_MSI_FLAGS);
 
         iommu->msi.msi.nvec = 1;
@@ -842,22 +837,22 @@ static void amd_iommu_erratum_746_workar
          (boot_cpu_data.x86_model > 0x1f) )
         return;
 
-    pci_conf_write32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf0, 0x90);
-    value = pci_conf_read32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf4);
+    pci_conf_write32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf0, 0x90);
+    value = pci_conf_read32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf4);
 
     if ( value & (1 << 2) )
         return;
 
     /* Select NB indirect register 0x90 and enable writing */
-    pci_conf_write32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf0, 0x90 | (1 << 8));
+    pci_conf_write32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf0, 0x90 | (1 << 8));
 
-    pci_conf_write32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf4, value | (1 << 2));
+    pci_conf_write32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf4, value | (1 << 2));
     printk(XENLOG_INFO
            "AMD-Vi: Applying erratum 746 workaround for IOMMU at %pp\n",
-           &PCI_SBDF2(iommu->seg, iommu->bdf));
+           &PCI_SBDF(iommu->seg, iommu->bdf));
 
     /* Clear the enable writing bit */
-    pci_conf_write32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf0, 0x90);
+    pci_conf_write32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf0, 0x90);
 }
 
 static void enable_iommu(struct amd_iommu *iommu)
@@ -1288,7 +1283,7 @@ static int __init cf_check amd_iommu_set
                 if ( !pci_init )
                     continue;
                 pcidevs_lock();
-                pdev = pci_get_pdev(seg, PCI_BUS(bdf), PCI_DEVFN2(bdf));
+                pdev = pci_get_pdev(seg, PCI_BUS(bdf), PCI_DEVFN(bdf));
                 pcidevs_unlock();
             }
 
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -604,7 +604,7 @@ static struct amd_iommu *_find_iommu_for
     if ( iommu )
         return iommu;
 
-    AMD_IOMMU_DEBUG("No IOMMU for MSI dev = %pp\n", &PCI_SBDF2(seg, bdf));
+    AMD_IOMMU_DEBUG("No IOMMU for MSI dev = %pp\n", &PCI_SBDF(seg, bdf));
     return ERR_PTR(-EINVAL);
 }
 
@@ -814,7 +814,7 @@ static void dump_intremap_table(const st
         if ( ivrs_mapping )
         {
             printk("  %pp:\n",
-                   &PCI_SBDF2(iommu->seg, ivrs_mapping->dte_requestor_id));
+                   &PCI_SBDF(iommu->seg, ivrs_mapping->dte_requestor_id));
             ivrs_mapping = NULL;
         }
 
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -534,7 +534,7 @@ int cf_check amd_iommu_get_reserved_devi
 
     for ( bdf = 0; bdf < ivrs_bdf_entries; ++bdf )
     {
-        pci_sbdf_t sbdf = PCI_SBDF2(seg, bdf);
+        pci_sbdf_t sbdf = PCI_SBDF(seg, bdf);
         const struct ivrs_unity_map *um = ivrs_mappings[bdf].unity_map;
         unsigned int req = ivrs_mappings[bdf].dte_requestor_id;
         const struct amd_iommu *iommu = ivrs_mappings[bdf].iommu;
@@ -563,7 +563,7 @@ int cf_check amd_iommu_get_reserved_devi
              * the same alias ID.
              */
             if ( bdf != req && ivrs_mappings[req].iommu &&
-                 func(0, 0, PCI_SBDF2(seg, req).sbdf, ctxt) )
+                 func(0, 0, PCI_SBDF(seg, req).sbdf, ctxt) )
                 continue;
 
             if ( global == pending )
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -53,7 +53,7 @@ struct amd_iommu *find_iommu_for_device(
             ivrs_mappings[bdf] = tmp;
 
             printk(XENLOG_WARNING "%pp not found in ACPI tables;"
-                   " using same IOMMU as function 0\n", &PCI_SBDF2(seg, bdf));
+                   " using same IOMMU as function 0\n", &PCI_SBDF(seg, bdf));
 
             /* write iommu field last */
             ivrs_mappings[bdf].iommu = ivrs_mappings[bd0].iommu;
@@ -144,7 +144,7 @@ static int __must_check amd_iommu_setup_
                | (ivrs_dev->unity_map ? SET_ROOT_WITH_UNITY_MAP : 0);
 
     /* get device-table entry */
-    req_id = get_dma_requestor_id(iommu->seg, PCI_BDF2(bus, devfn));
+    req_id = get_dma_requestor_id(iommu->seg, PCI_BDF(bus, devfn));
     table = iommu->dev_table.buffer;
     dte = &table[req_id];
     ivrs_dev = &get_ivrs_mappings(iommu->seg)[req_id];
@@ -202,7 +202,7 @@ static int __must_check amd_iommu_setup_
          * presence.  But let's deal with that case only if it is actually
          * found in the wild.
          */
-        if ( req_id != PCI_BDF2(bus, devfn) &&
+        if ( req_id != PCI_BDF(bus, devfn) &&
              (sr_flags & SET_ROOT_WITH_UNITY_MAP) )
             rc = -EOPNOTSUPP;
         else
@@ -231,7 +231,7 @@ static int __must_check amd_iommu_setup_
              (any_pdev_behind_iommu(pdev->domain, pdev, iommu) ||
               pdev->phantom_stride) )
             AMD_IOMMU_WARN(" %pp: reassignment may cause %pd data corruption\n",
-                           &PCI_SBDF3(pdev->seg, bus, devfn), pdev->domain);
+                           &PCI_SBDF(pdev->seg, bus, devfn), pdev->domain);
 
         /*
          * Check remaining settings are still in place from an earlier call
@@ -414,7 +414,7 @@ static void amd_iommu_disable_domain_dev
         disable_ats_device(pdev);
 
     BUG_ON ( iommu->dev_table.buffer == NULL );
-    req_id = get_dma_requestor_id(iommu->seg, PCI_BDF2(bus, devfn));
+    req_id = get_dma_requestor_id(iommu->seg, PCI_BDF(bus, devfn));
     table = iommu->dev_table.buffer;
     dte = &table[req_id];
 
@@ -461,7 +461,7 @@ static int cf_check reassign_device(
     if ( !iommu )
     {
         AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be assigned to %pd\n",
-                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn), target);
+                       &PCI_SBDF(pdev->seg, pdev->bus, devfn), target);
         return -ENODEV;
     }
 
@@ -488,7 +488,7 @@ static int cf_check reassign_device(
     if ( !is_hardware_domain(source) )
     {
         const struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(pdev->seg);
-        unsigned int bdf = PCI_BDF2(pdev->bus, devfn);
+        unsigned int bdf = PCI_BDF(pdev->bus, devfn);
 
         rc = amd_iommu_reserve_domain_unity_unmap(
                  source,
@@ -498,7 +498,7 @@ static int cf_check reassign_device(
     }
 
     AMD_IOMMU_DEBUG("Re-assign %pp from %pd to %pd\n",
-                    &PCI_SBDF3(pdev->seg, pdev->bus, devfn), source, target);
+                    &PCI_SBDF(pdev->seg, pdev->bus, devfn), source, target);
 
     return 0;
 }
@@ -507,7 +507,7 @@ static int cf_check amd_iommu_assign_dev
     struct domain *d, u8 devfn, struct pci_dev *pdev, u32 flag)
 {
     struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(pdev->seg);
-    int bdf = PCI_BDF2(pdev->bus, devfn);
+    unsigned int bdf = PCI_BDF(pdev->bus, devfn);
     int req_id = get_dma_requestor_id(pdev->seg, bdf);
     int rc = amd_iommu_reserve_domain_unity_map(
                  d, ivrs_mappings[req_id].unity_map, flag);
@@ -575,12 +575,12 @@ static int cf_check amd_iommu_add_device
         }
 
         AMD_IOMMU_WARN("no IOMMU for %pp; cannot be handed to %pd\n",
-                        &PCI_SBDF3(pdev->seg, pdev->bus, devfn), pdev->domain);
+                        &PCI_SBDF(pdev->seg, pdev->bus, devfn), pdev->domain);
         return -ENODEV;
     }
 
     ivrs_mappings = get_ivrs_mappings(pdev->seg);
-    bdf = PCI_BDF2(pdev->bus, devfn);
+    bdf = PCI_BDF(pdev->bus, devfn);
     if ( !ivrs_mappings ||
          !ivrs_mappings[ivrs_mappings[bdf].dte_requestor_id].valid )
         return -EPERM;
@@ -618,7 +618,7 @@ static int cf_check amd_iommu_add_device
              ivrs_mappings[ivrs_mappings[bdf].dte_requestor_id].unity_map,
              0) )
         AMD_IOMMU_WARN("%pd: unity mapping failed for %pp\n",
-                       pdev->domain, &PCI_SBDF2(pdev->seg, bdf));
+                       pdev->domain, &PCI_SBDF(pdev->seg, bdf));
 
     if ( iommu_quarantine && pdev->arch.pseudo_domid == DOMID_INVALID )
     {
@@ -651,20 +651,20 @@ static int cf_check amd_iommu_remove_dev
     if ( !iommu )
     {
         AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be removed from %pd\n",
-                        &PCI_SBDF3(pdev->seg, pdev->bus, devfn), pdev->domain);
+                        &PCI_SBDF(pdev->seg, pdev->bus, devfn), pdev->domain);
         return -ENODEV;
     }
 
     amd_iommu_disable_domain_device(pdev->domain, iommu, devfn, pdev);
 
     ivrs_mappings = get_ivrs_mappings(pdev->seg);
-    bdf = PCI_BDF2(pdev->bus, devfn);
+    bdf = PCI_BDF(pdev->bus, devfn);
 
     if ( amd_iommu_reserve_domain_unity_unmap(
              pdev->domain,
              ivrs_mappings[ivrs_mappings[bdf].dte_requestor_id].unity_map) )
         AMD_IOMMU_WARN("%pd: unity unmapping failed for %pp\n",
-                       pdev->domain, &PCI_SBDF2(pdev->seg, bdf));
+                       pdev->domain, &PCI_SBDF(pdev->seg, bdf));
 
     amd_iommu_quarantine_teardown(pdev);
 
@@ -681,7 +681,7 @@ static int cf_check amd_iommu_remove_dev
 
 static int cf_check amd_iommu_group_id(u16 seg, u8 bus, u8 devfn)
 {
-    int bdf = PCI_BDF2(bus, devfn);
+    unsigned int bdf = PCI_BDF(bus, devfn);
 
     return (bdf < ivrs_bdf_entries) ? get_dma_requestor_id(seg, bdf) : bdf;
 }
--- a/xen/drivers/passthrough/ats.h
+++ b/xen/drivers/passthrough/ats.h
@@ -35,7 +35,7 @@ static inline int pci_ats_enabled(int se
     pos = pci_find_ext_capability(seg, bus, devfn, PCI_EXT_CAP_ID_ATS);
     BUG_ON(!pos);
 
-    value = pci_conf_read16(PCI_SBDF3(seg, bus, devfn), pos + ATS_REG_CTL);
+    value = pci_conf_read16(PCI_SBDF(seg, bus, devfn), pos + ATS_REG_CTL);
 
     return value & ATS_ENABLE;
 }
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -553,7 +553,7 @@ int __init pci_ro_device(int seg, int bu
         memset(pseg->ro_map, 0, sz);
     }
 
-    __set_bit(PCI_BDF2(bus, devfn), pseg->ro_map);
+    __set_bit(PCI_BDF(bus, devfn), pseg->ro_map);
     _pci_hide_device(pdev);
 
     return 0;
@@ -957,7 +957,7 @@ static int deassign_device(struct domain
  out:
     if ( ret )
         printk(XENLOG_G_ERR "%pd: deassign (%pp) failed (%d)\n",
-               d, &PCI_SBDF3(seg, bus, devfn), ret);
+               d, &PCI_SBDF(seg, bus, devfn), ret);
 
     return ret;
 }
@@ -1406,7 +1406,7 @@ static int iommu_add_device(struct pci_d
         rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev));
         if ( rc )
             printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n",
-                   &PCI_SBDF3(pdev->seg, pdev->bus, devfn), rc);
+                   &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc);
     }
 }
 
@@ -1452,7 +1452,7 @@ static int iommu_remove_device(struct pc
             continue;
 
         printk(XENLOG_ERR "IOMMU: remove %pp failed (%d)\n",
-               &PCI_SBDF3(pdev->seg, pdev->bus, devfn), rc);
+               &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc);
         return rc;
     }
 
@@ -1536,7 +1536,7 @@ static int assign_device(struct domain *
  done:
     if ( rc )
         printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n",
-               d, &PCI_SBDF3(seg, bus, devfn), rc);
+               d, &PCI_SBDF(seg, bus, devfn), rc);
     /* The device is assigned to dom_io so mark it as quarantined */
     else if ( d == dom_io )
         pdev->quarantine = true;
@@ -1647,7 +1647,7 @@ int iommu_do_pci_domctl(
 
         seg = domctl->u.get_device_group.machine_sbdf >> 16;
         bus = PCI_BUS(domctl->u.get_device_group.machine_sbdf);
-        devfn = PCI_DEVFN2(domctl->u.get_device_group.machine_sbdf);
+        devfn = PCI_DEVFN(domctl->u.get_device_group.machine_sbdf);
         max_sdevs = domctl->u.get_device_group.max_sdevs;
         sdevs = domctl->u.get_device_group.sdev_array;
 
@@ -1697,7 +1697,7 @@ int iommu_do_pci_domctl(
 
         seg = machine_sbdf >> 16;
         bus = PCI_BUS(machine_sbdf);
-        devfn = PCI_DEVFN2(machine_sbdf);
+        devfn = PCI_DEVFN(machine_sbdf);
 
         pcidevs_lock();
         ret = device_assigned(seg, bus, devfn);
@@ -1706,7 +1706,7 @@ int iommu_do_pci_domctl(
             if ( ret )
             {
                 printk(XENLOG_G_INFO "%pp already assigned, or non-existent\n",
-                       &PCI_SBDF3(seg, bus, devfn));
+                       &PCI_SBDF(seg, bus, devfn));
                 ret = -EINVAL;
             }
         }
@@ -1742,7 +1742,7 @@ int iommu_do_pci_domctl(
 
         seg = machine_sbdf >> 16;
         bus = PCI_BUS(machine_sbdf);
-        devfn = PCI_DEVFN2(machine_sbdf);
+        devfn = PCI_DEVFN(machine_sbdf);
 
         pcidevs_lock();
         ret = deassign_device(d, seg, bus, devfn);
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -222,7 +222,7 @@ struct acpi_drhd_unit *acpi_find_matched
             continue;
 
         for (i = 0; i < drhd->scope.devices_cnt; i++)
-            if ( drhd->scope.devices[i] == PCI_BDF2(bus, devfn) )
+            if ( drhd->scope.devices[i] == PCI_BDF(bus, devfn) )
                 return drhd;
 
         if ( test_bit(bus, drhd->scope.buses) )
@@ -1062,7 +1062,7 @@ int cf_check intel_iommu_get_reserved_de
 
         rc = func(PFN_DOWN(rmrr->base_address),
                   PFN_UP(rmrr->end_address) - PFN_DOWN(rmrr->base_address),
-                  PCI_SBDF2(rmrr->segment, bdf).sbdf, ctxt);
+                  PCI_SBDF(rmrr->segment, bdf).sbdf, ctxt);
 
         if ( unlikely(rc < 0) )
             return rc;
--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -498,7 +498,7 @@ static void set_msi_source_id(struct pci
         case 4: sq = SQ_13_IGNORE_1; break;
         default: sq = SQ_ALL_16; break;
         }
-        set_ire_sid(ire, SVT_VERIFY_SID_SQ, sq, PCI_BDF2(bus, devfn));
+        set_ire_sid(ire, SVT_VERIFY_SID_SQ, sq, PCI_BDF(bus, devfn));
         break;
 
     case DEV_TYPE_PCI:
@@ -508,7 +508,7 @@ static void set_msi_source_id(struct pci
         if ( ret == 0 ) /* integrated PCI device */
         {
             set_ire_sid(ire, SVT_VERIFY_SID_SQ, SQ_ALL_16,
-                        PCI_BDF2(bus, devfn));
+                        PCI_BDF(bus, devfn));
         }
         else if ( ret == 1 ) /* find upstream bridge */
         {
@@ -517,7 +517,7 @@ static void set_msi_source_id(struct pci
                             (bus << 8) | pdev->bus);
             else
                 set_ire_sid(ire, SVT_VERIFY_SID_SQ, SQ_ALL_16,
-                            PCI_BDF2(bus, devfn));
+                            PCI_BDF(bus, devfn));
         }
         else
             dprintk(XENLOG_WARNING VTDPREFIX,
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -938,21 +938,21 @@ static int iommu_page_fault_do_one(struc
                "DMAR:[%s] Request device [%pp] "
                "fault addr %"PRIx64"\n",
                (type ? "DMA Read" : "DMA Write"),
-               &PCI_SBDF2(seg, source_id), addr);
+               &PCI_SBDF(seg, source_id), addr);
         kind = "DMAR";
         break;
     case INTR_REMAP:
         printk(XENLOG_G_WARNING VTDPREFIX
                "INTR-REMAP: Request device [%pp] "
                "fault index %"PRIx64"\n",
-               &PCI_SBDF2(seg, source_id), addr >> 48);
+               &PCI_SBDF(seg, source_id), addr >> 48);
         kind = "INTR-REMAP";
         break;
     default:
         printk(XENLOG_G_WARNING VTDPREFIX
                "UNKNOWN: Request device [%pp] "
                "fault addr %"PRIx64"\n",
-               &PCI_SBDF2(seg, source_id), addr);
+               &PCI_SBDF(seg, source_id), addr);
         kind = "UNKNOWN";
         break;
     }
@@ -961,7 +961,7 @@ static int iommu_page_fault_do_one(struc
            kind, fault_reason, reason);
 
     if ( iommu_verbose && fault_type == DMA_REMAP )
-        print_vtd_entries(iommu, PCI_BUS(source_id), PCI_DEVFN2(source_id),
+        print_vtd_entries(iommu, PCI_BUS(source_id), PCI_DEVFN(source_id),
                           addr >> PAGE_SHIFT);
 
     return 0;
@@ -1039,7 +1039,7 @@ static void __do_iommu_page_fault(struct
                                 source_id, guest_addr);
 
         pci_check_disable_device(iommu->drhd->segment,
-                                 PCI_BUS(source_id), PCI_DEVFN2(source_id));
+                                 PCI_BUS(source_id), PCI_DEVFN(source_id));
 
         fault_index++;
         if ( fault_index > cap_num_fault_regs(iommu->cap) )
@@ -1541,7 +1541,7 @@ int domain_context_mapping_one(
                 check_cleanup_domid_map(domain, pdev, iommu);
             printk(XENLOG_ERR
                    "%pp: unexpected context entry %016lx_%016lx (expected %016lx_%016lx)\n",
-                   &PCI_SBDF3(seg, bus, devfn),
+                   &PCI_SBDF(seg, bus, devfn),
                    (uint64_t)(res >> 64), (uint64_t)res,
                    (uint64_t)(old >> 64), (uint64_t)old);
             rc = -EILSEQ;
@@ -1571,7 +1571,7 @@ int domain_context_mapping_one(
         if ( !(mode & (MAP_OWNER_DYING | MAP_SINGLE_DEVICE)) )
             printk(XENLOG_WARNING VTDPREFIX
                    " %pp: reassignment may cause %pd data corruption\n",
-                   &PCI_SBDF3(seg, bus, devfn), prev_dom);
+                   &PCI_SBDF(seg, bus, devfn), prev_dom);
 
         write_atomic(&context->lo, lctxt.lo);
         /* No barrier should be needed between these two. */
@@ -1581,7 +1581,7 @@ int domain_context_mapping_one(
     iommu_sync_cache(context, sizeof(struct context_entry));
     spin_unlock(&iommu->lock);
 
-    rc = iommu_flush_context_device(iommu, prev_did, PCI_BDF2(bus, devfn),
+    rc = iommu_flush_context_device(iommu, prev_did, PCI_BDF(bus, devfn),
                                     DMA_CCMD_MASK_NOBIT, !prev_dom);
     flush_dev_iotlb = !!find_ats_dev_drhd(iommu);
     ret = iommu_flush_iotlb_dsi(iommu, prev_did, !prev_dom, flush_dev_iotlb);
@@ -1688,7 +1688,7 @@ static int domain_context_mapping(struct
     case DEV_TYPE_PCI_HOST_BRIDGE:
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:Hostbridge: skip %pp map\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         if ( !is_hardware_domain(domain) )
             return -EPERM;
         break;
@@ -1712,7 +1712,7 @@ static int domain_context_mapping(struct
 
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCIe: map %pp\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         ret = domain_context_mapping_one(domain, drhd->iommu, bus, devfn, pdev,
                                          DEVICE_DOMID(domain, pdev), pgd_maddr,
                                          mode);
@@ -1737,7 +1737,7 @@ static int domain_context_mapping(struct
 
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCI: map %pp\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
 
         ret = domain_context_mapping_one(domain, drhd->iommu, bus, devfn,
                                          pdev, DEVICE_DOMID(domain, pdev),
@@ -1802,7 +1802,7 @@ static int domain_context_mapping(struct
 
     default:
         dprintk(XENLOG_ERR VTDPREFIX, "%pd:unknown(%u): %pp\n",
-                domain, pdev->type, &PCI_SBDF3(seg, bus, devfn));
+                domain, pdev->type, &PCI_SBDF(seg, bus, devfn));
         ret = -EINVAL;
         break;
     }
@@ -1851,7 +1851,7 @@ int domain_context_unmap_one(
     iommu_sync_cache(context, sizeof(struct context_entry));
 
     rc = iommu_flush_context_device(iommu, iommu_domid,
-                                    PCI_BDF2(bus, devfn),
+                                    PCI_BDF(bus, devfn),
                                     DMA_CCMD_MASK_NOBIT, 0);
 
     flush_dev_iotlb = !!find_ats_dev_drhd(iommu);
@@ -1910,7 +1910,7 @@ static const struct acpi_drhd_unit *doma
     case DEV_TYPE_PCI_HOST_BRIDGE:
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:Hostbridge: skip %pp unmap\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         return ERR_PTR(is_hardware_domain(domain) ? 0 : -EPERM);
 
     case DEV_TYPE_PCIe_BRIDGE:
@@ -1924,7 +1924,7 @@ static const struct acpi_drhd_unit *doma
 
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCIe: unmap %pp\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         ret = domain_context_unmap_one(domain, iommu, bus, devfn);
         if ( !ret && devfn == pdev->devfn && ats_device(pdev, drhd) > 0 )
             disable_ats_device(pdev);
@@ -1937,7 +1937,7 @@ static const struct acpi_drhd_unit *doma
 
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCI: unmap %pp\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         ret = domain_context_unmap_one(domain, iommu, bus, devfn);
         if ( ret )
             break;
@@ -1970,7 +1970,7 @@ static const struct acpi_drhd_unit *doma
 
     default:
         dprintk(XENLOG_ERR VTDPREFIX, "%pd:unknown(%u): %pp\n",
-                domain, pdev->type, &PCI_SBDF3(seg, bus, devfn));
+                domain, pdev->type, &PCI_SBDF(seg, bus, devfn));
         return ERR_PTR(-EINVAL);
     }
 
@@ -2181,9 +2181,7 @@ static int cf_check intel_iommu_add_devi
 
     for_each_rmrr_device ( rmrr, bdf, i )
     {
-        if ( rmrr->segment == pdev->seg &&
-             PCI_BUS(bdf) == pdev->bus &&
-             PCI_DEVFN2(bdf) == devfn )
+        if ( rmrr->segment == pdev->seg && bdf == PCI_BDF(pdev->bus, devfn) )
         {
             /*
              * iommu_add_device() is only called for the hardware
@@ -2239,9 +2237,7 @@ static int cf_check intel_iommu_remove_d
 
     for_each_rmrr_device ( rmrr, bdf, i )
     {
-        if ( rmrr->segment != pdev->seg ||
-             PCI_BUS(bdf) != pdev->bus ||
-             PCI_DEVFN2(bdf) != devfn )
+        if ( rmrr->segment != pdev->seg || bdf != PCI_BDF(pdev->bus, devfn) )
             continue;
 
         /*
@@ -2668,8 +2664,7 @@ static int cf_check reassign_device_owne
 
         for_each_rmrr_device( rmrr, bdf, i )
             if ( rmrr->segment == pdev->seg &&
-                 PCI_BUS(bdf) == pdev->bus &&
-                 PCI_DEVFN2(bdf) == devfn )
+                 bdf == PCI_BDF(pdev->bus, devfn) )
             {
                 /*
                  * Any RMRR flag is always ignored when remove a device,
@@ -2713,9 +2708,7 @@ static int cf_check intel_iommu_assign_d
      */
     for_each_rmrr_device( rmrr, bdf, i )
     {
-        if ( rmrr->segment == seg &&
-             PCI_BUS(bdf) == bus &&
-             PCI_DEVFN2(bdf) == devfn &&
+        if ( rmrr->segment == seg && bdf == PCI_BDF(bus, devfn) &&
              rmrr->scope.devices_cnt > 1 )
         {
             bool_t relaxed = !!(flag & XEN_DOMCTL_DEV_RDM_RELAXED);
@@ -2725,7 +2718,7 @@ static int cf_check intel_iommu_assign_d
                    " with shared RMRR at %"PRIx64" for %pd.\n",
                    relaxed ? XENLOG_WARNING : XENLOG_ERR,
                    relaxed ? "risky" : "disallowed",
-                   &PCI_SBDF3(seg, bus, devfn), rmrr->base_address, d);
+                   &PCI_SBDF(seg, bus, devfn), rmrr->base_address, d);
             if ( !relaxed )
                 return -EPERM;
         }
@@ -2737,9 +2730,7 @@ static int cf_check intel_iommu_assign_d
     /* Setup rmrr identity mapping */
     for_each_rmrr_device( rmrr, bdf, i )
     {
-        if ( rmrr->segment == seg &&
-             PCI_BUS(bdf) == bus &&
-             PCI_DEVFN2(bdf) == devfn )
+        if ( rmrr->segment == seg && bdf == PCI_BDF(bus, devfn) )
         {
             ret = iommu_identity_mapping(d, p2m_access_rw, rmrr->base_address,
                                          rmrr->end_address, flag);
@@ -2762,9 +2753,7 @@ static int cf_check intel_iommu_assign_d
 
     for_each_rmrr_device( rmrr, bdf, i )
     {
-        if ( rmrr->segment == seg &&
-             PCI_BUS(bdf) == bus &&
-             PCI_DEVFN2(bdf) == devfn )
+        if ( rmrr->segment == seg && bdf == PCI_BDF(bus, devfn) )
         {
             int rc = iommu_identity_mapping(d, p2m_access_x,
                                             rmrr->base_address,
@@ -2791,7 +2780,7 @@ static int cf_check intel_iommu_group_id
     if ( find_upstream_bridge(seg, &bus, &devfn, &secbus) < 0 )
         return -ENODEV;
 
-    return PCI_BDF2(bus, devfn);
+    return PCI_BDF(bus, devfn);
 }
 
 static int __must_check cf_check vtd_suspend(void)
--- a/xen/drivers/passthrough/vtd/quirks.c
+++ b/xen/drivers/passthrough/vtd/quirks.c
@@ -115,7 +115,7 @@ bool is_azalia_tlb_enabled(const struct
         return true;
 
     /* Check for the specific device. */
-    sbdf = PCI_SBDF2(drhd->segment, drhd->scope.devices[0]);
+    sbdf = PCI_SBDF(drhd->segment, drhd->scope.devices[0]);
     if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_INTEL ||
          pci_conf_read16(sbdf, PCI_DEVICE_ID) != 0x3a3e )
         return true;
@@ -446,7 +446,7 @@ int me_wifi_quirk(struct domain *domain,
             return 0;
 
         /* if device is WLAN device, map ME phantom device 0:3.7 */
-        id = pci_conf_read32(PCI_SBDF3(0, bus, devfn), 0);
+        id = pci_conf_read32(PCI_SBDF(0, bus, devfn), 0);
         switch (id)
         {
             case 0x42328086:
@@ -470,7 +470,7 @@ int me_wifi_quirk(struct domain *domain,
             return 0;
 
         /* if device is WLAN device, map ME phantom device 0:22.7 */
-        id = pci_conf_read32(PCI_SBDF3(0, bus, devfn), 0);
+        id = pci_conf_read32(PCI_SBDF(0, bus, devfn), 0);
         switch (id)
         {
             case 0x00878086:        /* Kilmer Peak */
--- a/xen/drivers/passthrough/vtd/utils.c
+++ b/xen/drivers/passthrough/vtd/utils.c
@@ -96,7 +96,7 @@ void print_vtd_entries(struct vtd_iommu
     u32 l_index, level;
 
     printk("print_vtd_entries: iommu #%u dev %pp gmfn %"PRI_gfn"\n",
-           iommu->index, &PCI_SBDF3(iommu->drhd->segment, bus, devfn),
+           iommu->index, &PCI_SBDF(iommu->drhd->segment, bus, devfn),
            gmfn);
 
     if ( iommu->root_maddr == 0 )
--- a/xen/drivers/pci/pci.c
+++ b/xen/drivers/pci/pci.c
@@ -46,12 +46,12 @@ int pci_find_next_cap(u16 seg, u8 bus, u
 
     while ( ttl-- )
     {
-        pos = pci_conf_read8(PCI_SBDF3(seg, bus, devfn), pos);
+        pos = pci_conf_read8(PCI_SBDF(seg, bus, devfn), pos);
         if ( pos < 0x40 )
             break;
 
         pos &= ~3;
-        id = pci_conf_read8(PCI_SBDF3(seg, bus, devfn), pos + PCI_CAP_LIST_ID);
+        id = pci_conf_read8(PCI_SBDF(seg, bus, devfn), pos + PCI_CAP_LIST_ID);
 
         if ( id == 0xff )
             break;
@@ -93,7 +93,7 @@ int pci_find_next_ext_capability(int seg
     int ttl = 480; /* 3840 bytes, minimum 8 bytes per capability */
     int pos = max(start, 0x100);
 
-    header = pci_conf_read32(PCI_SBDF3(seg, bus, devfn), pos);
+    header = pci_conf_read32(PCI_SBDF(seg, bus, devfn), pos);
 
     /*
      * If we have no capabilities, this is indicated by cap ID,
@@ -109,7 +109,7 @@ int pci_find_next_ext_capability(int seg
         pos = PCI_EXT_CAP_NEXT(header);
         if ( pos < 0x100 )
             break;
-        header = pci_conf_read32(PCI_SBDF3(seg, bus, devfn), pos);
+        header = pci_conf_read32(PCI_SBDF(seg, bus, devfn), pos);
     }
     return 0;
 }
@@ -162,7 +162,7 @@ const char *__init parse_pci_seg(const c
     else
         func = 0;
     if ( seg != (seg_p ? (u16)seg : 0) ||
-         bus != PCI_BUS(PCI_BDF2(bus, 0)) ||
+         bus != PCI_BUS(PCI_BDF(bus, 0)) ||
          dev != PCI_SLOT(PCI_DEVFN(dev, 0)) ||
          func != PCI_FUNC(PCI_DEVFN(0, func)) )
         return NULL;
--- a/xen/drivers/video/vga.c
+++ b/xen/drivers/video/vga.c
@@ -122,9 +122,9 @@ void __init video_endboot(void)
                 pcidevs_unlock();
 
                 if ( !pdev ||
-                     pci_conf_read16(PCI_SBDF3(0, bus, devfn),
+                     pci_conf_read16(PCI_SBDF(0, bus, devfn),
                                      PCI_CLASS_DEVICE) != 0x0300 ||
-                     !(pci_conf_read16(PCI_SBDF3(0, bus, devfn), PCI_COMMAND) &
+                     !(pci_conf_read16(PCI_SBDF(0, bus, devfn), PCI_COMMAND) &
                        (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) )
                     continue;
 
@@ -136,12 +136,12 @@ void __init video_endboot(void)
                         b = 0;
                         break;
                     case 1:
-                        switch ( pci_conf_read8(PCI_SBDF3(0, b, df),
+                        switch ( pci_conf_read8(PCI_SBDF(0, b, df),
                                                 PCI_HEADER_TYPE) )
                         {
                         case PCI_HEADER_TYPE_BRIDGE:
                         case PCI_HEADER_TYPE_CARDBUS:
-                            if ( pci_conf_read16(PCI_SBDF3(0, b, df),
+                            if ( pci_conf_read16(PCI_SBDF(0, b, df),
                                                  PCI_BRIDGE_CONTROL) &
                                  PCI_BRIDGE_CTL_VGA )
                                 continue;
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -29,16 +29,21 @@
 #define PCI_BUS(bdf)    (((bdf) >> 8) & 0xff)
 #define PCI_SLOT(bdf)   (((bdf) >> 3) & 0x1f)
 #define PCI_FUNC(bdf)   ((bdf) & 0x07)
-#define PCI_DEVFN(d,f)  ((((d) & 0x1f) << 3) | ((f) & 0x07))
-#define PCI_DEVFN2(bdf) ((bdf) & 0xff)
-#define PCI_BDF(b,d,f)  ((((b) & 0xff) << 8) | PCI_DEVFN(d,f))
-#define PCI_BDF2(b,df)  ((((b) & 0xff) << 8) | ((df) & 0xff))
-#define PCI_SBDF(s,b,d,f) \
-    ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF(b, d, f) })
-#define PCI_SBDF2(s,bdf) \
+
+#define PCI_DEVFN1_(df)   ((df) & 0xff)
+#define PCI_DEVFN2_(d, f) ((((d) & 0x1f) << 3) | ((f) & 7))
+#define PCI_SBDF4_(s, b, d, f...) \
+    ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF(b, d, ##f) })
+#define PCI_SBDF3_ PCI_SBDF4_
+#define PCI_SBDF2_(s, bdf) \
     ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | ((bdf) & 0xffff) })
-#define PCI_SBDF3(s,b,df) \
-    ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
+
+#define PCI__(what, nr) PCI_##what##nr##_
+#define PCI_(what, nr)  PCI__(what, nr)
+
+#define PCI_DEVFN(d, f...)   PCI_(DEVFN, count_args(d, ##f))(d, ##f)
+#define PCI_BDF(b, d, f...)  ((((b) & 0xff) << 8) | PCI_DEVFN(d, ##f))
+#define PCI_SBDF(s, b, d...) PCI_(SBDF, count_args(s, b, ##d))(s, b, ##d)
 
 #define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
 



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:48:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:48:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302815.516603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqeK-0004S7-BU; Mon, 11 Apr 2022 09:47:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302815.516603; Mon, 11 Apr 2022 09:47:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqeK-0004S0-8G; Mon, 11 Apr 2022 09:47:56 +0000
Received: by outflank-mailman (input) for mailman id 302815;
 Mon, 11 Apr 2022 09:47:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqeI-0004Ru-VN
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:47:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 74f37bfb-b97c-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:47:53 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-IN5cOqAmMjy2Q-dFv1vueg-1; Mon, 11 Apr 2022 11:47:49 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4344.eurprd04.prod.outlook.com (2603:10a6:209:3f::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:47:48 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:47:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 74f37bfb-b97c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649670473;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/zQjR5DK4NpJpp9HOOVnWEC0s4IqMWdnpI2ohv4rQYY=;
	b=DS96yOLmxW6xDwPwIEWEN8VV9srOCXp3q3MXGCfwzmvSYG2TBxQeiujrnebRz2BGrpmm9F
	Npr2YDydt+H649KLNZicflMH98tqbhEZocQJY7yXPMkINuatEA233yBbSqwUUpbcpucyGF
	YrzQ//ZMXISoL7jaL67JfdSXY4Jgff4=
X-MC-Unique: IN5cOqAmMjy2Q-dFv1vueg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bdfv6GjlGmen2kmkcl1a8eLdAju90s5TIJjCc1dVeTJzQoJMqI4T9465hUqOrsuUgPcyDuigiNyNo3o3D8XeEE/V2UkWIYb1nDpobJ73j66ej75ZnRB46kXPUDtVaY+RqU0Z+aRQmKVAQKMNTapN9QA9sM/z98yiuYGA6ewDQlud1mEQGU4UkCQDIadwiVK/x5XcH1XIFOjsvAge7Jf9pvgWYrOQ/Q/SbMxwYV3v91VTbd8JDLLEHDnPyXv/ykFjvh1RIxplHW6CPVgVmKiJjEUmBV7X0RGO98wC5LJ6SopuMaNddYKphGzjjaove8PGg84BGc+rgCOKqPgLs4bWRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/zQjR5DK4NpJpp9HOOVnWEC0s4IqMWdnpI2ohv4rQYY=;
 b=g3Y9Cyvi9fPZatHO6l/TmxaZ9olv2u3YUpNdeEQi15HKA6MSv/B2LSMUaWqZt18J7OHu9yY8Lgrc9yZjKzSG19dikT2cBpfXbYhA5ZybVUbpVgNdOV9NCVCcrqUwKiLPpO1VFe3g5RIzHOp8ZowDy/6DkslYLK1GEGycG1FapqAD3u5xO1xQbLwqLiGXyGRM5M4aw3MWTp+wP6nnfJt/7heJYyB7dOIa9J32Zxgsqv4czCvySPf9T3dlhlNAp30Fv7XOr6ZuHnHXJf82cKMhHkq4o0CPZQOnP3BbAupOR3/Lp5BsYOOqEXhBQwATfEmUN/t4U9jbf02u5PsbMVtthw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <db695753-718d-7bc9-3b1a-efd75b0166f9@suse.com>
Date: Mon, 11 Apr 2022 11:47:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v4] IOMMU/x86: disallow device assignment to PoD guests
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
Content-Language: en-US
In-Reply-To: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0017.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::30) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f4562962-5dc6-4466-6ad0-08da1ba0561b
X-MS-TrafficTypeDiagnostic: AM6PR04MB4344:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4344A6F33E6AD706EAF63342B3EA9@AM6PR04MB4344.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	slBClve9IgrCZBX+LHNx9ZB0J2uFnYYzh5yJ1OC2XGmhNdUAQXqGpwCdZ1SsOmoCbVYrKM24/0qmyKkPDcvbQnan5NwY19uHJm+xGIbd0AnR5Y1ohHydWRyNdRWnd/gK2RQCXg780mjaS23bu2cUFr+nJeZQwYMsYqqoZ3D69wrceC4CgiTbjOZBLrSKu3J8mFaSK+U8ec6M2WaocrY1tEOQjEDetHnDyemNJTcHNSSzBzpij69LJgvdbLE7sDcQN9Sl3A8Yi9RydE2vjmtyy2QTyFkhFceTjensS7c1ZTJZBKKPMWQ8kxGqQaqiTALKo4C/Lsb6+BYvedPxTztfLMO5oiS10PbEIJmwrU1qidjmcj1044cbJzMEFoh4iO3UpTopbCxWDvt/vBW5QXXnRmzFn6bDpFLm+lYPpIEi+1A7hETMjQNNk64xf+FhxZecY7xyx377yZ1AxucHYkjoqFeBPLwwLf1DAbmknhyJ75vj/0Zt6/FzaWBnJylzpyboDL3ARCcFiNIGP3X+Zh/gpx7+kqPKQFho+77i8y+Te072GRchSJW6o2oewkC6FFcI0hJQCBoikM7T0XGyqgNtKURuLH0Kil8eJ63vFnSIReke2+02XCTQtj+EyThG+LubZtMJ/F9WkkT5lZvbaePx6Tmv9JVtbNwaQddAibiVNW06RKUuA2NV+bq16SYvKmCvS5GORzwJ1KNCdNl6Te9Fh802cpK+Tvii5EiK4G0/HPrDJrzxBhP4XX6AeI5hWu8T
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(5660300002)(8676002)(66946007)(83380400001)(54906003)(6916009)(316002)(6486002)(31686004)(36756003)(8936002)(4326008)(508600001)(86362001)(31696002)(2906002)(38100700002)(6512007)(6506007)(26005)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RG8zaVFEQ2YwOENsdmRWbVp5UHhjWlNZamhqL2tGNUlDMURHNjlkNnNQRFhj?=
 =?utf-8?B?Y005QVErbFZndWpSOHNUY3UvU0F4OXFDNkdheHA2dDFUUXh6ZFppQnRpeUVh?=
 =?utf-8?B?T21YUDRaQVliVnQwVkNScXZ1aW9zOWpYQXVta2l2VmlOL0JjaGxEZTBqR25S?=
 =?utf-8?B?UDBnU2QrOFJUbzYrc3FncjNzeWNoZTA4dVhtRjlqcmpCdkRkZktKVDRHbk16?=
 =?utf-8?B?YlBPSForNGxBVHNxaVpoenhWNlB6bTZXOHBsYzUyN01ac3NkVS94RmFza2xo?=
 =?utf-8?B?dWFLVDVvbVdSbHVWQVR0TnFNVWJlMnlndVFCOTM4UGRpVzBGSktGN0xMOTM3?=
 =?utf-8?B?bys2NFYvMnphVkxzRFFXUnNCa2ZBZlhvbGcwZUUwZEpHZW1DY2lBS3libGVo?=
 =?utf-8?B?bng2R3JObUU5RnRIODJYYkxxZkRiUXZkOXFnYm4veXdkaWo1cy9CTkxLbjY3?=
 =?utf-8?B?cjZLTng4NUNFZWcxUW9zcGNSM2JDdTlHb3VQbnZaZGE0Wll0UWQwRlVKN2xE?=
 =?utf-8?B?MGNYcXUvQlpCcWUvYnJBT1VXMDlNNFE4UlYyS2FRRSswWHlQQTkzZ3JPRUNw?=
 =?utf-8?B?TGtJaldKU3NKWG9zU0MzU1d6cnNiemE2SFk3OStxSkYyc0RHcWR1ZGE5eDFx?=
 =?utf-8?B?b2FjeFYyd2VuN29UaWtCMXpSbHhXcFZqdmZwQ0wyZWprZ0ZTVWZzYlBmaTRy?=
 =?utf-8?B?aCsrNGRkajlVWWdVWm1Db05Xd25QMEJINWR2ZG9hdGFwSWhmRngzU0tZSlVk?=
 =?utf-8?B?eWpKT2JCZzRlNmhzRUdhNlVOWkxVbnNKZ3BMZUdzTXlweGpNWnlKWUZlRE5x?=
 =?utf-8?B?ZWhZdVJMZUlUVG91OFZYVVNzMVpUYmQ1RUJmdHNCcFV4MkZLM1E0a2p2dXZD?=
 =?utf-8?B?MWc2ek5xS3FJWDZHZDhiS2JnN21WeU56cUlBZEZDVnNXQXEwS1hlQ2tkYkgw?=
 =?utf-8?B?cmlicnU2OFQ0ZDJsVHYwT2M2c0c4Q2s2THRnV3pJbElzOVpqUlA1aS9YUUgy?=
 =?utf-8?B?K2s5cTlGSUlTdVhESFdybEpzYzdHMnVHWk5CYjJpcHVwZHFBQkhIMGxtWHd4?=
 =?utf-8?B?Rk5OMEpVMWxWMi9YQWtVUjNUdEhlWHdqRVlBNmhlQm9kNjJSQUk0WkJ0VWFG?=
 =?utf-8?B?UklhVlI3MEVTMGo2dkwrZVROeW52UnhHNHkveThzcVUrazZXd0RkQW9aVEJU?=
 =?utf-8?B?bHZnWXdwbmhEc0FUekF1bDhsa2Q2WjMra08zSEpLWWdyekplTVV4R1NvcGRk?=
 =?utf-8?B?dWVzKzJhSlFqbTRSREd0MFplVWNkL2Q3SmgzR01WdEtLMHNjUUdjQ2QxR01W?=
 =?utf-8?B?UUdPZDd6UGk5TFdhQzRadmdhZ0tLdHFvcTVDV1ZnTTl5cVNWQklYQ2NUTUFO?=
 =?utf-8?B?VWlJQW5rRzRNcEFKdG5yK0pWTUpOdjk3Q0tUMXFCS2NBM1MzZFk4ZjFZelNO?=
 =?utf-8?B?KzJ0VWJsS3BEaEVXWlJlNTlFbU94UkVEVkdlMUhmUThxUlJxcVJ6akI5dUJs?=
 =?utf-8?B?SFFtTWNia0lUdlZYWHVpOGc3d0FDZ216cHhWZUdtdlczWXp6MDc5T0JzQzNi?=
 =?utf-8?B?YVFKbERDUVFiRnZRVDg4cFRDUGpHY3RwbDFiQkJBdG1RalNtYWpRcjhsZGd5?=
 =?utf-8?B?Mi90SlpGaEllOXlhTC9qQm5samRqZXZiWnZDcDN4UVRGMzJHN3QwMHBqdmNV?=
 =?utf-8?B?N2w1S3VqNFc5emQwcHRsUjh3V3poUFlLeExoNHNKSVZCbm56TnhDZlVaOXZI?=
 =?utf-8?B?ai9CYTZMYkFPY2VIVjVydlhtbk10Wi8yMHhhQVdydzlpdGU4UllvQTViYnlG?=
 =?utf-8?B?QWxra1FLYWRoa0dMdUtTMktBbmg3L2hFLytnd1JUUTRIWkViN2t0SXJCaWg2?=
 =?utf-8?B?c1pzVlN5aXFISWRCY0lqeHgwdUZYbDJOYURIM1k2U3IvME9qN3UzVlVUbk9I?=
 =?utf-8?B?elloY2xnbGxtdDE4emJLWmN4MjNEdm8rMUhQMjI5OW9sZzNvQnhaZ3IyQTFN?=
 =?utf-8?B?bFR4ZDFEenVoM2Y1UXRrS2NuV2lpWk1hQkJZYldmbWh5OG9WUFp6amJIUER5?=
 =?utf-8?B?MjVLNlpSbEVuajhqSzNZa2dPd1p4VHkrbnZ4N2lVdXRwR1RVZlFxS3pDUlB1?=
 =?utf-8?B?aEFtb3pBVitHcmluTXBWckJFMkVCTjBwcFN3MWhyVE5JN3dJOUVoalBNMFVH?=
 =?utf-8?B?b2RReVVFU1k4Y1loUlBYTU5ST3phS2RQaTFlNk1ubjQ1UTZwWVBoV3pvZTQ2?=
 =?utf-8?B?NGlCYURzakJIM25DWlFnLy9aVFFIMHZSWXRRazlxemdwNjVLbmk2QnR3MFRu?=
 =?utf-8?B?RENJUVl1N3k2dFROb0s1ZVVBb1ZCbms3M1Rzc3c4N3R1Nks0dzZQUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4562962-5dc6-4466-6ad0-08da1ba0561b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:47:48.1107
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5/kJ9tvtbjfaN3OP1n+92fTlo8bSccdVqw1/ZJvTVHjJ8c8yu9yZD2L1lwqVlTSFghgWH8PY9mNpP5KS8Bu/kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4344

While it is okay for IOMMU page tables to be set up for guests starting
in PoD mode, actual device assignment may only occur once all PoD
entries have been removed from the P2M. So far this was enforced only
for boot-time assignment, and only in the tool stack.

Also use the new function to replace p2m_pod_entry_count(): Its unlocked
access to p2m->pod.entry_count wasn't really okay (irrespective of the
result being stale by the time the caller gets to see it). Nor was the
use of that function in line with the immediately preceding comment: A
PoD guest isn't just one with a non-zero entry count, but also one with
a non-empty cache (e.g. prior to actually launching the guest).

To allow the tool stack to see a consistent snapshot of PoD state, move
the tail of XENMEM_{get,set}_pod_target handling into a function, adding
proper locking there.

In libxl take the liberty to use the new local variable r also for a
pre-existing call into libxc.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
If p2m->pod.entry_count == p2m->pod.count it is in principle possible to
permit device assignment by actively resolving all remaining PoD entries.

Initially I thought this was introduced by f89f555827a6 ("remove late
(on-demand) construction of IOMMU page tables"), but without
arch_iommu_use_permitted() checking for PoD I think the issue has been
there before that.
---
v4: Drop tool stack side change (superseded by 07449ecfa425). Extend VM
    event related paragraph of description.
v3: In p2m_pod_set_mem_target() move check down.
v2: New.

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -20,6 +20,7 @@
  */
 
 #include <xen/event.h>
+#include <xen/iocap.h>
 #include <xen/ioreq.h>
 #include <xen/mm.h>
 #include <xen/sched.h>
@@ -360,7 +361,10 @@ p2m_pod_set_mem_target(struct domain *d,
 
     ASSERT( pod_target >= p2m->pod.count );
 
-    ret = p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/);
+    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
+        ret = -ENOTEMPTY;
+    else
+        ret = p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/);
 
 out:
     pod_unlock(p2m);
@@ -368,6 +372,23 @@ out:
     return ret;
 }
 
+void p2m_pod_get_mem_target(const struct domain *d, xen_pod_target_t *target)
+{
+    struct p2m_domain *p2m = p2m_get_hostp2m(d);
+
+    ASSERT(is_hvm_domain(d));
+
+    pod_lock(p2m);
+    lock_page_alloc(p2m);
+
+    target->tot_pages       = domain_tot_pages(d);
+    target->pod_cache_pages = p2m->pod.count;
+    target->pod_entries     = p2m->pod.entry_count;
+
+    unlock_page_alloc(p2m);
+    pod_unlock(p2m);
+}
+
 int p2m_pod_empty_cache(struct domain *d)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
@@ -1391,6 +1412,9 @@ guest_physmap_mark_populate_on_demand(st
     if ( !paging_mode_translate(d) )
         return -EINVAL;
 
+    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
+        return -ENOTEMPTY;
+
     do {
         rc = mark_populate_on_demand(d, gfn, chunk_order);
 
@@ -1412,3 +1436,20 @@ void p2m_pod_init(struct p2m_domain *p2m
     for ( i = 0; i < ARRAY_SIZE(p2m->pod.mrp.list); ++i )
         p2m->pod.mrp.list[i] = gfn_x(INVALID_GFN);
 }
+
+bool p2m_pod_active(const struct domain *d)
+{
+    struct p2m_domain *p2m;
+    bool res;
+
+    if ( !is_hvm_domain(d) )
+        return false;
+
+    p2m = p2m_get_hostp2m(d);
+
+    pod_lock(p2m);
+    res = p2m->pod.entry_count | p2m->pod.count;
+    pod_unlock(p2m);
+
+    return res;
+}
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4804,7 +4804,6 @@ long arch_memory_op(unsigned long cmd, X
     {
         xen_pod_target_t target;
         struct domain *d;
-        struct p2m_domain *p2m;
 
         if ( copy_from_guest(&target, arg, 1) )
             return -EFAULT;
@@ -4835,10 +4834,7 @@ long arch_memory_op(unsigned long cmd, X
         }
         else if ( rc >= 0 )
         {
-            p2m = p2m_get_hostp2m(d);
-            target.tot_pages       = domain_tot_pages(d);
-            target.pod_cache_pages = p2m->pod.count;
-            target.pod_entries     = p2m->pod.entry_count;
+            p2m_pod_get_mem_target(d, &target);
 
             if ( __copy_to_guest(arg, &target, 1) )
                 rc = -EFAULT;
--- a/xen/common/vm_event.c
+++ b/xen/common/vm_event.c
@@ -639,7 +639,7 @@ int vm_event_domctl(struct domain *d, st
 
             rc = -EXDEV;
             /* Disallow paging in a PoD guest */
-            if ( p2m_pod_entry_count(p2m_get_hostp2m(d)) )
+            if ( p2m_pod_active(d) )
                 break;
 
             /* domain_pause() not required here, see XSA-99 */
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -513,11 +513,12 @@ bool arch_iommu_use_permitted(const stru
 {
     /*
      * Prevent device assign if mem paging, mem sharing or log-dirty
-     * have been enabled for this domain.
+     * have been enabled for this domain, or if PoD is still in active use.
      */
     return d == dom_io ||
            (likely(!mem_sharing_enabled(d)) &&
             likely(!mem_paging_enabled(d)) &&
+            likely(!p2m_pod_active(d)) &&
             likely(!p2m_is_global_logdirty(d)));
 }
 
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -701,6 +701,12 @@ int p2m_pod_empty_cache(struct domain *d
  * domain matches target */
 int p2m_pod_set_mem_target(struct domain *d, unsigned long target);
 
+/* Obtain a consistent snapshot of PoD related domain state. */
+void p2m_pod_get_mem_target(const struct domain *d, xen_pod_target_t *target);
+
+/* Check whether PoD is (still) active in a domain. */
+bool p2m_pod_active(const struct domain *d);
+
 /* Scan pod cache when offline/broken page triggered */
 int
 p2m_pod_offline_or_broken_hit(struct page_info *p);
@@ -709,11 +715,6 @@ p2m_pod_offline_or_broken_hit(struct pag
 void
 p2m_pod_offline_or_broken_replace(struct page_info *p);
 
-static inline long p2m_pod_entry_count(const struct p2m_domain *p2m)
-{
-    return p2m->pod.entry_count;
-}
-
 #else
 
 static inline bool
@@ -727,6 +728,11 @@ static inline int p2m_pod_empty_cache(st
     return 0;
 }
 
+static inline bool p2m_pod_active(const struct domain *d)
+{
+    return false;
+}
+
 static inline int p2m_pod_offline_or_broken_hit(struct page_info *p)
 {
     return 0;
@@ -737,11 +743,6 @@ static inline void p2m_pod_offline_or_br
     ASSERT_UNREACHABLE();
 }
 
-static inline long p2m_pod_entry_count(const struct p2m_domain *p2m)
-{
-    return 0;
-}
-
 #endif
 
 



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:50:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:50:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302820.516613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqh4-0005ox-PY; Mon, 11 Apr 2022 09:50:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302820.516613; Mon, 11 Apr 2022 09:50:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqh4-0005oq-Mj; Mon, 11 Apr 2022 09:50:46 +0000
Received: by outflank-mailman (input) for mailman id 302820;
 Mon, 11 Apr 2022 09:50:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndqh3-0005oQ-Qq
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:50:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id db25d050-b97c-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 11:50:44 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-x0lK-gd_NQ-61aPWmggmNw-1; Mon, 11 Apr 2022 11:50:36 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8280.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 09:50:35 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 09:50:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db25d050-b97c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649670644;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1VlCDlrrXerBqUA2dNYSUlN8BCdQEZkeb8vSjqzfzVo=;
	b=IIqFodNIGflIrvcHZN1fQ/gqJ42YOrYWgMMl2wkDr/8XKJzNHHp3gctnS7p8Kl5T0zEe+i
	aAKcRgksAZSRa5eGt38SWQEk60dYftAnrROwXu0+54zjsPV51+SG1vu50xdyX+oCkFNbIq
	8jAK2bsvmKW0HxDEPRy+7UBQyW4anNU=
X-MC-Unique: x0lK-gd_NQ-61aPWmggmNw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S+m/T0A20YuZn0QbnlWho/pxMZLuhf8kWa3PpXacOtzLGGWqYBL7C5Iyvuq8ShP68+LhAcbwq0pYV1Ggqa/HK61xfNMTs7QXteChdc2UA9H9eZB0EQmJcQTH+UAucZbSHz4n4zTCwUsLVrZmnwgGfQDv+Ls8qPijLzGC31HNWQeeb83fzbBEspFb9E465aKf0zrcST8FzTvkIy/Mf9pZ21dNB49Dv6tmNw87qi9T/IFncSLhK+SbhlX0ICQ8/Ch+GXRJ0PmXDRPpMcO5iMrkzd4gthWQRM0hyGWjtoJOmje5VB0pthQf7mpLAY/wkkKCzs9r9d99rVElk+7VuU0xwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F+goW0bkyqT+ZqMe57EdXFktRdr40TADb1pr34628B0=;
 b=dFKxCo44QPnEILNwzdEsfknfelyRc2fJlBw9O/b0m1/sDfP8zLNkXiw7C4t2CFgl5oxORanBBfUPRt5cK3HFvXYQ57QoX5WXBOj9VrRX5iocQ0NMwuodBfa7670aB5mXMpP2+RSRnAPOVZHIp+DsGkY4KDRdCAK2BLBCFAyc1KZaftIFfWYYKFqjK3LFTGQz1+hQXuYw1fjor87EsMF5sa0T2LQcCM6Z5QEXrGy5kf2F0IX+ROjygfVuzx0Cwi3ZA9XgcLi+lb26/Ya9URbCaTT9TwRyX3XU0bc9wLQNS2E7Gj6JqbSDx3PuCCz+Yt+/o7ZPtj/pk6+k3h6/TdUdEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <01992254-1a4d-850d-78c5-7e4ee738cffe@suse.com>
Date: Mon, 11 Apr 2022 11:50:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Ping: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics
 modes
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Henry Wang <Henry.Wang@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 "community.manager@xenproject.org" <community.manager@xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
 <YkwBpKcyrnuXyNPa@Air-de-Roger>
 <65d3068b-fde5-951b-9a60-4ba1dcd89a49@suse.com>
In-Reply-To: <65d3068b-fde5-951b-9a60-4ba1dcd89a49@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P250CA0007.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::12) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e8b9ef77-3be8-4ac6-267e-08da1ba0b9f8
X-MS-TrafficTypeDiagnostic: AS8PR04MB8280:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB82800492CCAAAD590AB0564CB3EA9@AS8PR04MB8280.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9DNCM+T6JLdzFP6+XPc0HcjIrytMYW7P3PIJAA3ec4ydjI3Xa8kSj1LToSnTDY8od+wwMJFasicgKINRteKPbbQsG1QFrJ2rf241sZnulJ1QTX3LFaz2DPoVqRKt9sA7ORcBmevZeeIsFAm359T9rLyACX2QiYzydd0VO0oRQZYxv7zw8eR6fQ73s24/xwFT4D4zF6lFwqd7CXMTBzJgfuXcqWp0rsZ+T3apHHqAGB5dMec8ifIccn0Yft3X/jFkJeiZUvjiyfL1HUOKfFGysAUTYE7wVy8tTYWyaawpdilx7aM9f7FcbgDVvVV4julf9hyJIW6EeRhAmXi9fWe8xuxi2ouI+ewaxwn8VittSOvDl+gOAtUcA7ZLNgoY9lqmWeHs6m4eWgih1Jd4JY0JZiX6ZIcRM6WyLrZLfXH7KsyRcti8vdLhyrp9DFRudeIBM336P0bWYzZB0PuqZXRDmdG0Jy7mB1onlndKrgK0j6CMkngcryahxiypHbkC4P6/q44UMdZhgZlprxXsEUhjGBGGP73+MV+tyrSLe7pEC5J72j0kMJh+8kj09IUnoUIr5Mwwl4SsHypAhxbmMkzzoZ0rzCMNQRs+4RARy8EvwwgWsa/1wUWfzxXlcLf89DglGa8yseLQRcT5DQMvSC2yS7oW87PNMj428oqZx/b2savbRoCDyp25rwpJmt24h5okueTpzYzKFlktFame2LomelgO12X1zmgVHws+MWEGPRXRym7b2M0qj+4V71PGqyYn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(8676002)(31696002)(5660300002)(6916009)(66476007)(66556008)(4326008)(8936002)(316002)(86362001)(6512007)(53546011)(6506007)(83380400001)(186003)(6486002)(38100700002)(2616005)(26005)(54906003)(508600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OZYsBOpkXEknDyXBPm3S/LSqdktFtu7qaebLeBuQ9skWs87s6qSJNI54MWEY?=
 =?us-ascii?Q?EDNwSXtt5NfGVkrH/skrMUaVi//hwqpc7d6AwX1GhUy2DFSUKG62Q7936qei?=
 =?us-ascii?Q?2c8LuJsRHpFldHP4IqOgekYyQPPElkOiNUlW4e9/7u9utX0TAUBlM3BrI9Te?=
 =?us-ascii?Q?wxOwiVLmX5PzgCwkmet8E8pVbAH0mfQ/KIacusRFp8+9AOqG18zl043Fu5dQ?=
 =?us-ascii?Q?H+vXyONe7yrfaDrxp4pZaADNFByqsFFGRr3PVh35FEdTNHPRvW6rzcN7mwMC?=
 =?us-ascii?Q?eHw+QE/T774xakFnu+42qkzSsUvdqYk2KRawDE7hLKLwZq33kj+em2t7Bad7?=
 =?us-ascii?Q?F/7632CMyYqX7U0h44ZkOA+iR497RgWwOE5OvgHoo91AmSlYshkln1r60lQo?=
 =?us-ascii?Q?lMW/Cm+h1bnYuxLGklEZtjJn+fruRl6Gm1zHs2vEwHKHzl60mQkfFCzHvkP9?=
 =?us-ascii?Q?i1eotGVMxIC5BLZjzfgMhPq3eI7v7EEYxlxb6P868bm6NOkUFQtTdyHK2Tbm?=
 =?us-ascii?Q?xhsxNd7cT3OBC/lahW6r7NG/7L0zh91i42AQMBPYTriNaBnMsWpL/b49YhMT?=
 =?us-ascii?Q?BtvbvkADy2m1qRNmBj+Xy4ckkvxZ3//5hIxYhUPiqHQb+/jMXuHZOVBxD3ex?=
 =?us-ascii?Q?Xhg+Zc6YSos0iZOwVrfIlqrBhMafzetuKAkh20pH6vWMRS+O86/PXkRwXtAP?=
 =?us-ascii?Q?Og6xVU2GZIBvB8Eti/lA25DnDnMgFWFcboAUSKcNgixt2csXZi6EK1yLKMxQ?=
 =?us-ascii?Q?e7Loz+ccEfjtVeW+pfMhzoxOhxD/bWLSAcJG39MhzkTEZmOnq1acZutmdlFo?=
 =?us-ascii?Q?yUng43LJ1WRSaIazXxhCDlyG69merMmZTyjrjYuL6v2y4pI35egvOtHutABS?=
 =?us-ascii?Q?8Y/hxLNoWwJWR1wZk9SHXR7M46DKupcROrhAlLlL4l8crobVjvGuCOvkFo6B?=
 =?us-ascii?Q?wdTB/B7FihM9sMjZN0iIqG+6WZJ2WfIC1pPPxWP6B8kzQSt+LlK2O+okakLr?=
 =?us-ascii?Q?S3tlQEV8C5weJ57ifSPAfBlDmJQ98zfmvu87cnieCKKSD4ow/MvxonNCrXfw?=
 =?us-ascii?Q?oEfMlwptDJroJ8feOfgryNJQL1awcK4z4TwIq8u8nB7OSFp3+pw9kgdSBKbg?=
 =?us-ascii?Q?uUxvbKsoxbGfJfyjyegenmXirAF4w7LxlVuOxgsaoeb4Cb9eaZUHKKSvx/vZ?=
 =?us-ascii?Q?WJGGOMllQnAmIO3oMaITGckmuEztRlgTLoOUazXSvYbVLpwHkR6IxcklVU4g?=
 =?us-ascii?Q?8q0wIvLqzCfiaf3LqwV4zbtOcVTz2HAr+z0wPrare2nz8iZQNaXaadikm8UX?=
 =?us-ascii?Q?16ZSUS5Vt8KvybL8llwxANrW8toPso/Was5NjRGcGHGIoF/MnVZ1Cru3vE+L?=
 =?us-ascii?Q?t9Aw+DV1+woQwL/nrC+sx2cPiWJYsxbbJEPbupsRsddg2f77h9mQZC90aofZ?=
 =?us-ascii?Q?s87UsLTniJyzqpxGHbnceAfBssqUK/4WCLe2ODzu8C8zMGTdTj2ABgCQrKJo?=
 =?us-ascii?Q?jFCu8+xNEtplCoigS1DZU+S4ZfX1NjQP6vTO52LTfmtw0in2yFvR7womSvoa?=
 =?us-ascii?Q?Y42dZACkVsI9CwZdWGqzxKNpAI1ePn5cEzd27J2ZIta+gj1hcoiRqlUxE/my?=
 =?us-ascii?Q?eWk8hqg2tLY2vzrl0j+Mpio3yyGDnbnkK/vKTP0GVtXUPX6+kmHrUw5eR2Z7?=
 =?us-ascii?Q?way9xuFAMAkvWDYsS6uVE7yXZAMHQ3529iAxkyYf+WmD2kQkXapOwKihS9dX?=
 =?us-ascii?Q?G2XVSbrlNA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8b9ef77-3be8-4ac6-267e-08da1ba0b9f8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:50:35.7142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WV1T5eJQEiyJoFzlASdZ4xJLAMaTFfdoMmab5LDWIUaKzwi7ilmRBavu3bQ5CvXaMatr9FJc6cH5oASSegPbFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8280

On 06.04.2022 16:23, Jan Beulich wrote:
> On 05.04.2022 10:45, Roger Pau Monn=C3=A9 wrote:
>> On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote:
>>> GrUB2 can be told to leave the screen in the graphics mode it has been
>>> using (or any other one), via "set gfxpayload=3Dkeep" (or suitable
>>> variants thereof). In this case we can avoid doing another mode switch
>>> ourselves. This in particular avoids possibly setting the screen to a
>>> less desirable mode: On one of my test systems the set of modes
>>> reported available by the VESA BIOS depends on whether the interposed
>>> KVM switch has that machine set as the active one. If it's not active,
>>> only modes up to 1024x768 get reported, while when active 1280x1024
>>> modes are also included. For things to always work with an explicitly
>>> specified mode (via the "vga=3D" option), that mode therefore needs be =
a
>>> 1024x768 one.
>>>
>>> For some reason this only works for me with "multiboot2" (and
>>> "module2"); "multiboot" (and "module") still forces the screen into tex=
t
>>> mode, despite my reading of the sources suggesting otherwise.
>>>
>>> For starters I'm limiting this to graphics modes; I do think this ought
>>> to also work for text modes, but
>>> - I can't tell whether GrUB2 can set any text mode other than 80x25
>>>   (I've only found plain "text" to be valid as a "gfxpayload" setting),
>>> - I'm uncertain whether supporting that is worth it, since I'm uncertai=
n
>>>   how many people would be running their systems/screens in text mode,
>>> - I'd like to limit the amount of code added to the realmode trampoline=
.
>>>
>>> For starters I'm also limiting mode information retrieval to raw BIOS
>>> accesses. This will allow things to work (in principle) also with other
>>> boot environments where a graphics mode can be left in place. The
>>> downside is that this then still is dependent upon switching back to
>>> real mode, so retrieving the needed information from multiboot info is
>>> likely going to be desirable down the road.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>=20
> May I ask for an ack or otherwise for the changelog entry, please?

Ping? This is the only thing missing for me to commit the remaining
parts of this series.

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 09:57:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 09:57:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302826.516624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqmz-0006pU-F9; Mon, 11 Apr 2022 09:56:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302826.516624; Mon, 11 Apr 2022 09:56:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqmz-0006pN-CB; Mon, 11 Apr 2022 09:56:53 +0000
Received: by outflank-mailman (input) for mailman id 302826;
 Mon, 11 Apr 2022 09:56:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndqmy-0006pD-Jm; Mon, 11 Apr 2022 09:56:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndqmy-0002sI-Hn; Mon, 11 Apr 2022 09:56:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndqmy-0003yF-45; Mon, 11 Apr 2022 09:56:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndqmy-00037R-3Z; Mon, 11 Apr 2022 09:56:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=W8LxnOIatGvn4UzVwrlQhVrKgmhcEBac2dE6zfEUcWc=; b=W32TNerI5JOCg8AwiXhM6c6ll7
	LRiJ6qTrEs9CRDLSSmrQFuDUWNBzN5vwqW/paei5JlXRqx1oah/sCbHnSz3EmJkfTZviMLON3ShZB
	xhPMZQWXST4A1DlSfINXQJSUq3qvcn833j9HvNsVx0xhqWYgZEMQxSOYQXr0j+2r4azE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169300-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169300: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 09:56:52 +0000

flight 169300 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169300/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   41 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  321 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:01:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:01:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302836.516636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqrl-0000B0-7K; Mon, 11 Apr 2022 10:01:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302836.516636; Mon, 11 Apr 2022 10:01:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndqrl-0000AK-3o; Mon, 11 Apr 2022 10:01:49 +0000
Received: by outflank-mailman (input) for mailman id 302836;
 Mon, 11 Apr 2022 10:01:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2GIa=UV=citrix.com=prvs=093d97d34=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ndqrj-0008Mf-Qx
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:01:47 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 648c446b-b97e-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 12:01:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 648c446b-b97e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649671306;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=wzJSTetHpqccLFsLDjNzAZ2vuqpeH4DeQ/6f42uP5x8=;
  b=CkyW5vBLT/iEjRF+VTAxxTuNVB1aaXFvxEJRu0PdeAo/RVTu5+fTc8Pz
   bunMJOK9FUL8R7U62D5s6uKEOW9qap3NLgx2kBjpckWYv0mhlJD+WiRD8
   egvrvRBpzgzytIeOUT8GLio3FPryU3A76oBZXu8zOygBVlE7dqBpDBrdR
   A=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68543525
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:39yw9awOi1f2G37Wc1p6t+cQxirEfRIJ4+MujC+fZmUNrF6WrkVVy
 2sZXmDQaPvfMTPyedknaoSz9kwO7J7Tz4UySFY6+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02IHhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpltqWRaFYwMZT3seU5CAFpTWImI+p09+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AN
 5dFMmc1MXwsZTVoGkYOBbgFhNuKjyT2SG1D73+eobootj27IAtZj+G2bYu9lsaxbcZYgEee4
 H7H9mLRAxcGOdjZwj2Amlq0j/LLtTP2XsQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684mauVtQaJ
 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobT8T9
 37YhtzQPhVulOaNeCzerqnTnzznbED5MlQ+TSMDSAIE5fzqr4cykg/DQ75fLUKlsjHmMWqum
 m7X9UDSk51W1JdWjPvjoTgrlhr2/vD0ohgJChI7t45Pxidwf8abaoOh8jA3Bt4Qfd/CHjFtU
 JXp8vVyDdzi77nQz0Rho81XRdlFAspp1xWG3DZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif
 VXevwhcjLcKYif7M/YpON/oVJVwpUQFKTgCfqqKBuein7ArLFPXlM2QTRP4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcyu8JwIK7Tbe2KL2ggJUpfs/F/oQKQ894x9nebU5
 HCtHEhezVv0n3rcLguWLHtkbdvSsVxX8hrX4QRE0Y6U5kUe
IronPort-HdrOrdr: A9a23:7dyT2KzpsZmstuHp7u+fKrPxiOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9IYgBcpTiBUJPwJE81bfZOkMcs1MSZLXXbUQyTXcBfBOrZsnLd8kjFmNK1up
 0QCpSWZOeAbmSSyPyKmjVQcOxQgOVvkprY/ds2pk0FJWoBCsFdBkVCe32m+yVNNVN77PECZf
 6hD7981lydkAMsH6OG7xc+Lor+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF
 K10DDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/gzd4dvfrWrCou
 O85CvIDP4DrU85uVvF+CcF7jOQlArGLUWSkWNwz0GT+vARDwhKdPapzbgpDCcxrXBQ4e2UmZ
 g7r15w/fBsfGL9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQlo+Tg7bVbHAa0cYa
 FT5fvnlb1rmJKhHgfkl3gqxMbpUmU4Hx+ATERHssuJ0yJOlHQ8y0cD3sQQknoJ6Zp4EvB/lq
 j5G7UtkKsLQt4dbKp7CutEScyrCnbVSRaJNG6JO1zoGKwOJnqIoZ/q57c+4v2sZfUzvdYPsY
 WEVEkduX85ekroB8HL1JpX8grVSGH4RjjpwtE23ekxhlQ9fsucDcSuciFdryL7mYRtPiTyYY
 fHBK5r
X-IronPort-AV: E=Sophos;i="5.90,251,1643691600"; 
   d="scan'208";a="68543525"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X9HtQoHkhDvljKqVbAoZNwD/zOxshwSRVaRally+UjqbmNGxCSuQ9WpfCRgMwqKequudj8tD/rUqK+lMOeSG/jiJdq43FKXuzLmTbcfTV4CJygtavk23KPz+CyS0hNBHRfSFRRuac+r17xUEnUn6FMxDByfiPPVOVDgH785sgi3hwO0ltZaa0ZYpavE2QAXo1uWq6jTRCb8rca+g0BAsmBgAWd75kAW2mLQ4vNu3O1wKDgkTky57llt9wdHSc9EYwoCaqoeT+ex9hHjH6oqk9x84uX36o9yapw9efIaVMjgM3yb0CbOj+mUvNkvSmAm6uGKCNq2EOAnmXueUqoVm0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wzJSTetHpqccLFsLDjNzAZ2vuqpeH4DeQ/6f42uP5x8=;
 b=P0rwD1XBa48GKiubKU1e9EkyWhl/u63fflEIHk78+347xDU3+MuOc1xUw/lAwmiU7WUt3uKBU+4LT1/QdEoZo25E0o0ZuY075HZJSBY0UPGPZ46GtjGSquzYcN4qEwU8lQmGa/GddgBgoBv+2DrGo358/yzVKJ+8X/Xy73BqSqzO21+bHL/mLd9xJvhlz2XjKMyVartGBXlERnHDXvdgxg5N71lb+XLTiW9ot1X+mrEJ8YfIu1Wl5ez/4hH96vrXzyo5pugDy3yq5G6nnOwUGlh0iYo2/wQLakfIN1hnesOEe217Nm7VnZwRiDrsfaVwYPLgFAN0iSIPLqAPTs7Y+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wzJSTetHpqccLFsLDjNzAZ2vuqpeH4DeQ/6f42uP5x8=;
 b=T2eQivAzW+Szu1Wl5L1D4W5PDlcDzqrwmrl+nHxmJEyokhy4ZugR7FWP1moBBFWWBcm9SknEHUXDkaPL9u8nwofH/MiB6BWu0bgV1s/dlLw4c8bCiPGRVOFT9L5xi6A79SFx1CgH1welEnunmCl2zNcn+9QiFmqaPuLDHK7TkMA=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>, "Roger Pau
 Monne" <roger.pau@citrix.com>
Subject: Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Thread-Topic: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Thread-Index: AQHYTYeuJ+is9Rj/YESzKfVlQCNZoKzqezGA
Date: Mon, 11 Apr 2022 10:01:35 +0000
Message-ID: <7b79d293-80c3-d368-1abf-581f57dd2f82@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
In-Reply-To: <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2f1f522c-d8ce-437e-98af-08da1ba2439b
x-ms-traffictypediagnostic: SJ0PR03MB5885:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <SJ0PR03MB5885816A04EF96805047A0ACBAEA9@SJ0PR03MB5885.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: F7PSXAVTjjVHMrMltXPt8Mh3wgwKezlq9zYMJJehkRUKzpZEANb9JNUDn9CPtQYzP3q7CVW+5SJ9UyM0iN1l0opd38PuTrViA+KkFqqEecaBUKDQm0f98+XJfnWkZiV7pcN+OBZZ+9Qb5HYshQ4F40g08FXf/1M2XhsoB4XgnI9BXG5YAATyuj0D9plWZPT/dnx8IBD2p2p8enc2DlSpCuekkcbUFVj/L8bAqLgWa5zxBGvs2/hJfcB371i26jI6GzXt8aGkPMmqh6rOJOgVdlY3I2EI40sI71vdmSmoKaSZ/bkn6ehE6lBB5YWu797N4ESMCA2cCWL2xhairEbC8CtE41hRIILHBnVRY4VVP19s95rwq+LD0QFWef7xCAnsfmolWsGEpvxtSZ1fb2WyQr8RoyFWNHy2igwWG6C8aEIiF15rQgm1Nh0BEkwR1753e5Evd27D5cqLn6jrH5/doxJgm3PjWh1OPh6KuOWu1BGkGfkJxRY6I/srE8WoZDlk2JWDmj/OzqudujBmGd5FOk5Ha+u560IqqWJ787hyf5JGzZed7TqXJOZ/QBI1bNUnoyoR/HIALQdW2eLZopTHVjkeisZ7I6Anhg/Q7YAdBibflcCzjUZwJ7b56QTAgKr8mwi7sTdVUemwhkPSCwq+C66sTX0HE2o9m7pk6aduh9HCtaaCOv3My/VX7XPR/WeMCwlNmpqZzeh+U617krqaogkqDNrpiB06wklOxeulkUhNt5Wcr2vBwTacQ5k94ElsX0DZ+XYHSoUilwfnUrUYeA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(83380400001)(26005)(107886003)(86362001)(31686004)(31696002)(2906002)(2616005)(8936002)(36756003)(53546011)(6506007)(6512007)(8676002)(5660300002)(71200400001)(6486002)(38070700005)(66446008)(76116006)(91956017)(66946007)(4326008)(316002)(122000001)(38100700002)(64756008)(66476007)(66556008)(110136005)(54906003)(82960400001)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SmhhQktyWXY2amFsaUZZSHQySW9KNDhRREMvMjRPZ1IvTjFLVzh3bjBKc3No?=
 =?utf-8?B?ZUZrMWZNUU1ZUWxEVXdCQnJBSkF1N0FkOWJaUTlTWlZQMUxSTWtMOU1MdjRW?=
 =?utf-8?B?L0x4STVEUXNJeS91cGFNYnJXZVlMeTZhKzNTa2VndlZiaTJVNHIvdnVkRTV2?=
 =?utf-8?B?ekpsVEpiaGs4TG11TENkNDJySmhYeTFrcGV3MXBUNk1La2JpNEcyOUZSVEQ3?=
 =?utf-8?B?bVo1ZWVjYitubklTbWJ4WHdaR0NkZlU2Tmh3WGhZL3JnU3c5Yi9ET1lmeUpJ?=
 =?utf-8?B?bmZ3a0lWcW5GNzhxc0NZWEdvN05IQ04zRFEyc2NxWXMxc1BQU01HT25ZUDdM?=
 =?utf-8?B?b1hpOXYwSm4xT2NXVDVNa3kyTUNkaWZQL3BsR3VkNmVma2sxejZTRjBzdTBM?=
 =?utf-8?B?bm1zeWFTVG1tVzNFczBXVHRzWG5IZ0FLOWlWV0pucjJsMkpoMDdUeXI5dW9M?=
 =?utf-8?B?akdMMHk1RmJORVhrVFlSZlFPTFRaZjM2c3haN1ZYUTNZVW5wanptemtLNzRK?=
 =?utf-8?B?NXM2alR5QmdsUEJlSDFwRFpUQnJOTmJjK0hVbDhHbERuT09VWnQ0ejQwNVlF?=
 =?utf-8?B?M0ZDd29lMTcvd0R0MlNuMUZ6NEtlaXMzVlVBcSs2Zmd6cWtucEdjRFJjT2x2?=
 =?utf-8?B?by9HWER2QWRJYW9FOHlYR2l2UnFGQU1kelI0SlpkOTRCZ2ZiNzJCTFBBZzBs?=
 =?utf-8?B?ZUdyaEUzMzRkWWRNODBsbEVSZDY2bHUwQWNody9xVUdRQzB6RXkzbFJhM2xK?=
 =?utf-8?B?VWNlUHEwZkpCY2ZIMXNhdkFRYWJrbWV2eEMwT1hIeU5Dc3VCL0N4cTE1TDBI?=
 =?utf-8?B?Z2g2c0swb3VFOENqRk9wSXVQUmp2aGNkZDJTbmhLRUJJYVJmT0l0aGRWdXhs?=
 =?utf-8?B?Y0pnakpvV1BwRnVSa0Mrc0pUam0vbC8zQXkxd0VFSC9UNUdTa2diUklITisy?=
 =?utf-8?B?UmwzcnlrSElBMXJyUjdlMXU1Q0dFUk5Ka29pRUtvTTQ5cjBuandSOXdOUFJR?=
 =?utf-8?B?U1pOZU1FQ0VwQ1l0NVI2OG00TTlQOUNReS9KeEx5elRCbDM4VEs5dU5ydEJT?=
 =?utf-8?B?V1JFMmp5eG9wNzUzOXhaU3pLWndUVC8rdFVKblJqeXpyd1g3QUtXdVZNZjNy?=
 =?utf-8?B?YmIzejZmem4renBETTl2U2hEVmZzM3JIYlRZSkpBYkE2ZUZkR1l3UFhyV3BI?=
 =?utf-8?B?bkVhYm1aemtPc2RUZ1NOSkhaL2swMG5vRVh3QVk2bmdLcDdtWFFOYXZjVjBQ?=
 =?utf-8?B?YkZsQ1FubDB4UkwvSFhuRmpwZ3RkdHBJdXdXQktRRlZ5dFFpNHdrSGYwd2U5?=
 =?utf-8?B?YUNDSDArRVNDaU5IWDZPTFJMeUxVZkdlTGIrUFBDWEd1SFhHc0xIM2VhY0xH?=
 =?utf-8?B?SnNPb3ROcHNQdnFUVGE4aEVkbUpLcWV0QXZNOFE5VXk4ZTNLYjhFZWRKdko5?=
 =?utf-8?B?TTdyZ3VXUGxkUzIyaDJ5ZnZqc0lyOStCSHBySlNoUXcyVEpZc0JoN2l6L2c3?=
 =?utf-8?B?NXVURzQ0WHVVekRYUVdpQ2VuYnhZUEtPVDl2VE5XQXlOTEd0ZE81bmZMQVlX?=
 =?utf-8?B?dm1yWngxa2RZdzJmMlppemtSa0lPLzZVSFpFaDN5Z0pCQk1kTS9SeWF1WWdH?=
 =?utf-8?B?Rjd2RXJqVnpreGp4YndwWTFvZjFpRkpDdnJEbHlYakNIWlhIU3FLR3RxUGZ2?=
 =?utf-8?B?eExqcnpJZk9vZm44bDRKanhXM2t6L0pyZ0xDTHpoSXcxMWszbWVFbXZtSFpU?=
 =?utf-8?B?M2RjUlBRYkt3b3pveGRJcE9GNFVIYVVPZWVQS1luZnFBMFpSUmFWcUxTNzVk?=
 =?utf-8?B?M0lFbGlHNy9PNXY4ek5FYUhvS1k5bTBxUnN6QklZelMyWHBDSWVra0Q5ZWVU?=
 =?utf-8?B?NWxoM2tnaWdHMWZzbTBFUWdsZEhDMHFPMDA3VFozVkp2WU56QjRLMlBBR09T?=
 =?utf-8?B?TjJobGErRjZ5RWRTTldXNlUwdlF3dnd3ZHZpWDJvS3JDcERkd3hrSVVJMkFy?=
 =?utf-8?B?bHFhdGlBOVkzYzNRQWhIdG9TTXVnUG0valZMcG5uSk42UGtFVUlKbS91TXhN?=
 =?utf-8?B?RDNxbXIxeHRQOXJpb3gvczlaVC80WnBZcURlUDJNamVWejc4ZXJMb3NnVitq?=
 =?utf-8?B?ZzVrSTgybmRPRzJBVkVxYkVVN2N1ZHRmcGFGTEJ5N2s2elFlRHhOWFF0V3Rv?=
 =?utf-8?B?TzdyeWpPa0hJdE9iTUdVeDJNd3RUdDNlZklTYkZtMkhJT1ZEWE9SV3BDK0JH?=
 =?utf-8?B?a3p3emtOQjZ2Tm4zQkFiN0RiNEtmUDVRa0tIWkZ5WFdNUHVMTVczQjFyUW1H?=
 =?utf-8?B?TVdadVBTUHE4SXhJUlJYZDJLcktBRTBKKzlNNlpxQmVGeTRhby94Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <78DDD22459DB4F469768B21333AA93F1@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f1f522c-d8ce-437e-98af-08da1ba2439b
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 10:01:35.8644
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: u+winZnDtivI+nAhIE89LxQwLJHLZ/o8awmruFmFgwqNKLC1qWeD53wdfdvZF7kQi4FOjupXZBVqWuXOuDOEpEdKOfEWUE9heYVRXd4UHj8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5885
X-OriginatorOrg: citrix.com

T24gMTEvMDQvMjAyMiAxMDozNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFByaW9yIGV4dGVuc2lv
biBvZiB0aGVzZSBmdW5jdGlvbnMgdG8gZW5hYmxlIHBlci1kZXZpY2UgcXVhcmFudGluZSBwYWdl
DQo+IHRhYmxlcyBhbHJlYWR5IGRpZG4ndCBhZGQgbW9yZSBsb2NraW5nIHRoZXJlLCBidXQgbWVy
ZWx5IGxlZnQgaW4gcGxhY2UNCj4gd2hhdCBoYWQgYmVlbiB0aGVyZSBiZWZvcmUuIEJ1dCByZWFs
bHkgbG9ja2luZyBpcyB1bm5lY2Vzc2FyeSBoZXJlOg0KPiBXZSdyZSBydW5uaW5nIHdpdGggcGNp
ZGV2c19sb2NrIGhlbGQgKGkuZS4gbXVsdGlwbGUgaW52b2NhdGlvbnMgb2YgdGhlDQo+IHNhbWUg
ZnVuY3Rpb24gW29yIHRoZWlyIHRlYXJkb3duIGVxdWl2YWxlbnRzXSBhcmUgaW1wb3NzaWJsZSwg
YW5kIGhlbmNlDQo+IHRoZXJlIGFyZSBubyAibG9jYWwiIHJhY2VzKSwgd2hpbGUgYWxsIGNvbnN1
bWluZyBvZiB0aGUgZGF0YSBiZWluZw0KPiBwb3B1bGF0ZWQgaGVyZSBjYW4ndCByYWNlIGFueXdh
eSBkdWUgdG8gaGFwcGVuaW5nIHNlcXVlbnRpYWxseQ0KPiBhZnRlcndhcmRzLiBTZWUgYWxzbyB0
aGUgY29tbWVudCBpbiBzdHJ1Y3QgYXJjaF9wY2lfZGV2Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBK
YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNCkl0IGlzIG9ubHkgbGVnaXRpbWF0ZSB0
byBkcm9wIHRoZXNlIGNhbGxzIGlmIHlvdSBkZWxldGUgdGhlIG1hcHBpbmdfbG9jaw0KZW50aXJl
bHkuwqAgT3RoZXJ3aXNlIHlvdSdyZSBicmVha2luZyB0aGUgc2VtYW50aWNzIG9mIG1hcHBpbmdf
bG9jay4NCg0KWW91ciBhcmd1bWVudCBvZiAid2VsbCB0aGlzIGlzIGFscmVhZHkgZ3VhcmRlZCBi
eSB0aGUgcGNpIGxvY2siIG1lYW5zDQp0aGF0IHRoZXNlIGFyZSB1bmNvbnRlbmRlZCBsb2NrL3Vu
bG9jayBvcGVyYXRpb25zLCBhbmQgdGhlcmVmb3JlIG5vdA0KaW50ZXJlc3RpbmcgdG8gZHJvcCBp
biB0aGUgZmlyc3QgcGxhY2UuDQoNClRoaXMgcGF0Y2ggaXMgc3BlY2lmaWNhbGx5IHNldHRpbmcg
dXMgdXAgZm9yIGFuIFhTQSBpbiB0aGUgZnV0dXJlIHdoZW4NCnRoZSBiZWhhdmlvdXIgb2YgdGhl
IHRoZSBQQ0kgbG9jayBjaGFuZ2VzLCB0aGUgZml4IGZvciB3aGljaCB3aWxsIGJlDQpyZXZlcnQg
dGhpcyBwYXRjaC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:12:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:12:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302842.516647 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr1u-0001oM-5H; Mon, 11 Apr 2022 10:12:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302842.516647; Mon, 11 Apr 2022 10:12:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr1u-0001oF-24; Mon, 11 Apr 2022 10:12:18 +0000
Received: by outflank-mailman (input) for mailman id 302842;
 Mon, 11 Apr 2022 10:12:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R/O6=UV=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ndr1s-0001o7-Cz
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:12:16 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on061b.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::61b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dbe3a658-b97f-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 12:12:15 +0200 (CEST)
Received: from AM6PR10CA0070.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::47)
 by DBBPR08MB5932.eurprd08.prod.outlook.com (2603:10a6:10:207::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:12:04 +0000
Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:80:cafe::5f) by AM6PR10CA0070.outlook.office365.com
 (2603:10a6:209:80::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 10:12:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 10:12:03 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Mon, 11 Apr 2022 10:12:03 +0000
Received: from 4a34785b19db.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DE7D4445-11BC-45D1-A049-9AA54ED90413.1; 
 Mon, 11 Apr 2022 10:11:57 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4a34785b19db.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 10:11:57 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by DB7PR08MB3787.eurprd08.prod.outlook.com (2603:10a6:10:33::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:11:52 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a%4]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:11:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dbe3a658-b97f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=95Za7DXyJDyr0M7icnH5tSUyWpZ1opisSjOuPbZBLK4=;
 b=7e4Dpe9jM8T+xKLKhHeIWnEg4+d33uaZjOP3Ccpk0Rv2rDzy5p+p/CdG/MDm3ZVLobdZhw9KA1XVU9dyPpxlpqVT5GxMiAidYrFGKqJiJzIjR5Svqqy8H0C1NalmCTdj/piUyLAEWT26z5k5g5H90TB/vtJsEDQwGxGi0RUuqoY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VnA8nMyANYmp93IyGf8UOiD2BO+XyU4xQByvLhq8fn0C3I3J1xa+wTsyzZfgOxNH7Bt6aG5XSLrYzx4XV7tlx6oPbggc8HOSUlecZ4+bqHleO+XjnWuEJqfOkxj5D9keTJN7j3uHJRwtxW2KIWC/D0IFrCEFMOW3zGZTPNZ/xVUFYRQZN9G6KQa4MwGBEGOXb8xCvfORdgSpU34L7Z+aZGiNyZqh9Pf7BSc2Ge6AwU1UeP40rlyMhjE9AppE7sYn/blTH2u8ttxxj3hHgmrD69vYpbz8I/mbdo3dM46mWEPLzVc0P1jpy00FlPwC9suLe76aEoCIv/w6UOazxdX9xg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=95Za7DXyJDyr0M7icnH5tSUyWpZ1opisSjOuPbZBLK4=;
 b=kJUgmR7a2DqI18KyjPOUv+1FTzc8NBIcG4o8T1rFTM7wJjKSbltSxQ8h1jUFRwtAIbt1o7sqQ4DUUGz2PnyRsf+9rT8DnP6MXVM+Jqj0ca7fUHW60CjcnL7D9iUTRa8hyfzBxAth5yFaydJYvOwtpQ8YTZjuittbxldnkt6zrpcqhdHbjToNyIVvd1TDA3uek774FxhcZHUlQlns9t7QRbth3OkLaQ5boEAEwVHBr/x05NT+fuo8fxbOwQUP+KQMBo/egZk1IoeyF0ka7X6LUPWf29/4MbVh/m/BF8bxn8ofuNsXoa7Ky1AkyH+q+UYlDbShpYSVDQkmJbSs/a7x5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=95Za7DXyJDyr0M7icnH5tSUyWpZ1opisSjOuPbZBLK4=;
 b=7e4Dpe9jM8T+xKLKhHeIWnEg4+d33uaZjOP3Ccpk0Rv2rDzy5p+p/CdG/MDm3ZVLobdZhw9KA1XVU9dyPpxlpqVT5GxMiAidYrFGKqJiJzIjR5Svqqy8H0C1NalmCTdj/piUyLAEWT26z5k5g5H90TB/vtJsEDQwGxGi0RUuqoY=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	"community.manager@xenproject.org" <community.manager@xenproject.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: RE: Ping: [PATCH v4 1/8] x86/boot: make "vga=current" work with
 graphics modes
Thread-Topic: Ping: [PATCH v4 1/8] x86/boot: make "vga=current" work with
 graphics modes
Thread-Index: AQHYROPtcJBl4i95okO8HDmAStvYzazhCTMAgAHwwACAB49yAIAAA21A
Date: Mon, 11 Apr 2022 10:11:51 +0000
Message-ID:
 <PA4PR08MB6253CEB380333171F2829F7492EA9@PA4PR08MB6253.eurprd08.prod.outlook.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
 <YkwBpKcyrnuXyNPa@Air-de-Roger>
 <65d3068b-fde5-951b-9a60-4ba1dcd89a49@suse.com>
 <01992254-1a4d-850d-78c5-7e4ee738cffe@suse.com>
In-Reply-To: <01992254-1a4d-850d-78c5-7e4ee738cffe@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: D9511BF12FBA8347A58F6D33DD6B77E7.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 3911d7bb-c9a0-4cc5-4f5d-08da1ba3b9f1
x-ms-traffictypediagnostic:
	DB7PR08MB3787:EE_|VE1EUR03FT048:EE_|DBBPR08MB5932:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB5932FCF2BA3D2FDE9C89EEF992EA9@DBBPR08MB5932.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 4G4esZGMiejuIYW/Q4nFzwb4lFPRjTrosJhPEkTju8Z3jTskDAX9PXp5yQG3DPQueO/REw0N18nwPkOZo8ll9LIgYiGtz/XYrvmi1GjiCwF8ADTpuqcrwesx7pFw0i3xDa3OY/CRa2XqH8wfU8PpJALhQKn96kAqG7AzeXMOpMHu61KC8zlr6h5vXfrwM+rjsc9WYq7Qw/jTMQpPrcY050buHQU4pxdO0AENcKqQJ7Z9OXHY+6jyFCa2JBvxqOb1C/G/gOb7EiH4Ks/I14+tr9OHfPHTp/v6rAwP/cu6V80ZTSfQXMZxE3uk03sudSlnQWtt5qNeop99jDL1ua4LFAu/oNBTVL2UuOWIEue0wwx5V6vJbHtvOW9rWWPsRj4qi6LuQ91aiR2hrmYcwZs8+z85telNho7D18GdoRSMZEzMQSbjAahrYpiedjgTzQ+j7cYDIcA5VZTkKHlJDHjs1eXFeVLH2Q36lRnzd6WsQY2/fwePyONfy7+UDm77fp04goujMibPFW2wVNM0VT9579pd+lkqoYgf4NJYI74LIpdVp4BRJeXtf+3WB5u/3/gfHalGDWats/shBhvXkplf0yLBDc19uTJbxF0znOwZKMFMrWm6YNrTigDDxT+2DcaCLfLMkRyjPl8Sv1bimriv5X6L45XZX2ZcDD+0Mv4c24LikE1cugY5LVfKTSQzZgfPMcU4aVtmw3B5z9PitLXkAA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(38070700005)(55016003)(2906002)(186003)(122000001)(38100700002)(33656002)(71200400001)(9686003)(4326008)(6916009)(54906003)(52536014)(7696005)(508600001)(6506007)(316002)(5660300002)(66446008)(66946007)(8936002)(66556008)(66476007)(76116006)(64756008)(4744005)(8676002)(86362001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3787
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ed919a6d-6729-4a76-04d6-08da1ba3b2d1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	j0BGm94kQO5WPuXFZjA93JbrHWn2y3f4q7Ag+r1M0KgzR808MoTR31lHNedNJC9rCZdlF2GefzS/X+2TpUGDXZ/SsLObmH26gm3tvkvu17+I3qvcEkEX7OS7emXJrscxcnLZ39r7UVlZv8HaM7KbfQLERVcMENjSEgwC88x5tWQn3NFJrOeK7wURtD1gvoXh7ux2VmO5+H9DrDrPyL86oOEGAkjj4Mv9P7lSxWCe1JkjBMPbIgfL6q5XfJpZGxwIv2Cz5dUZzoRSev1Lj4+oZcaWmIGzNNs1NDbYJnoorXhag5GvyJh0hmdVeFF88Zqrl1Gc7DoGEmXdFpmvP4pDGRGOWFJ/y3nJtaPdTZ9h9EvVNldPeLO/fniqNr7ZnGl04DV35uyKlweB48FrXPpq9Jo7OfZzaFpEyK9vuFYpHgSfBAH8o5l/SMCxepnw+Iqdpn0pdXDctIuDTZE1yRGxEPMv1Xa0diOCgB13TY8KGvEiPNgy5nmZqg7PimI8EeK+gaP+lf3sE0QGtnahCb+voZWOeZ0zfSvjMgBKNGLWUKNXh6d8yJ4wUSRLy5l6B4aBnazHJO8FI1jzNES2QxBpqLmWl75NUGDVPiPcar0FEu9+PAFTCU9ya8jK4nthds1SAMNDO7XeJ9IV1ZQDla8OPBLTnyKUeJTkZxCC96IvLkJEFgPbia5KRgo83BYyCMvZ
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(54906003)(508600001)(40460700003)(86362001)(2906002)(316002)(52536014)(6862004)(8676002)(81166007)(4326008)(356005)(4744005)(70206006)(47076005)(36860700001)(70586007)(5660300002)(8936002)(7696005)(6506007)(26005)(33656002)(186003)(336012)(9686003)(82310400005)(55016003)(107886003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:12:03.8471
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3911d7bb-c9a0-4cc5-4f5d-08da1ba3b9f1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5932

SGkgSmFuLA0KDQo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+DQo+ID4+DQo+ID4+IEFja2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVA
Y2l0cml4LmNvbT4NCj4gPg0KPiA+IE1heSBJIGFzayBmb3IgYW4gYWNrIG9yIG90aGVyd2lzZSBm
b3IgdGhlIGNoYW5nZWxvZyBlbnRyeSwgcGxlYXNlPw0KPiANCj4gUGluZz8gVGhpcyBpcyB0aGUg
b25seSB0aGluZyBtaXNzaW5nIGZvciBtZSB0byBjb21taXQgdGhlIHJlbWFpbmluZw0KPiBwYXJ0
cyBvZiB0aGlzIHNlcmllcy4NCg0KU29ycnkgZm9yIHRoZSBsYXRlIHJlc3BvbnNlLCB0aGUgcHJl
dmlvdXMgZS1tYWlsIHRoYXQgeW91IGRpcmVjdGx5DQoidG8iZWQgbWUgZmVsbCB0aHJvdWdoIHRo
ZSBjcmFja3Mgc29tZWhvdy4NCg0KQWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt
LmNvbT4NCg0KU2luY2UgeW91IGFsc28gbWVudGlvbmVkIHRoZSBjaGFuZ2Vsb2cgZW50cnksIEkg
d2lsbCB0YWtlIGEgbm90ZSBvZiB0aGlzDQpzZXJpZXMgYW5kIHdlIGNhbiBoYXZlIGEgZGlzY3Vz
c2lvbiBhYm91dCBhZGRpbmcgaXQgd2hlbiB3ZSBkbyB0aGUNCm5leHQgWGVuIHJlbGVhc2UgKDQu
MTcpLiBXb3VsZCB0aGF0IHNvdW5kIG9rIHdpdGggeW91Pw0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5y
eQ0KDQo+IA0KPiBUaGFua3MsIEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:13:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:13:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302845.516658 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr37-0002Ne-H2; Mon, 11 Apr 2022 10:13:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302845.516658; Mon, 11 Apr 2022 10:13:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr37-0002NX-DS; Mon, 11 Apr 2022 10:13:33 +0000
Received: by outflank-mailman (input) for mailman id 302845;
 Mon, 11 Apr 2022 10:13:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndr36-0002NJ-7Y; Mon, 11 Apr 2022 10:13:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndr36-0003Lr-4w; Mon, 11 Apr 2022 10:13:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndr35-0004MP-J5; Mon, 11 Apr 2022 10:13:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndr35-0000LW-If; Mon, 11 Apr 2022 10:13:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hkP1JwLz7FbZVGcR/gRZb1bF+Tec1VdZgiuYB81zGL0=; b=4wN0RwgRWCIIP6f7ywfjHD7Nlp
	hIzyyAv5Eaae34Q/jHNdEirpqqC+29Prze9jO1Fm92RrmVBJ7S2mUBJosm29plrA3nIlJH6Tq9k7x
	dB94e8/BbyV6c3Bctu2KaQq/rUce7+jX/kU2cI6cWdsDS57m3obheinG0E6KzNX9ISXk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169292-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169292: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:build-arm64:xen-build:fail:regression
    xen-unstable:test-amd64-amd64-xl-multivcpu:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl:debian-fixup:fail:heisenbug
    xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-unstable:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
X-Osstest-Versions-That:
    xen=8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 10:13:31 +0000

flight 169292 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169292/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 169273

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-multivcpu 20 guest-localmigrate/x10 fail in 169273 pass in 169292
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 169273 pass in 169292
 test-armhf-armhf-xl          13 debian-fixup               fail pass in 169273

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 169273 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 169273 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 169273 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 169273 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 169273 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 169273 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 169273 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 169273 never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 169273 never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 169273 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 169273 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 169273 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 169273 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 169273 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 169273 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 169273 never pass
 test-armhf-armhf-xl         15 migrate-support-check fail in 169273 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 169273 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169273
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169273
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169273
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169273
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169273
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169273
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169273
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169273
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169273
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169273
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169273
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169273
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
baseline version:
 xen                  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf

Last test of basis   169292  2022-04-11 01:51:53 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  fail    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:14:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:14:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302855.516669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr3o-000310-Vi; Mon, 11 Apr 2022 10:14:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302855.516669; Mon, 11 Apr 2022 10:14:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr3o-00030t-SR; Mon, 11 Apr 2022 10:14:16 +0000
Received: by outflank-mailman (input) for mailman id 302855;
 Mon, 11 Apr 2022 10:14:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndr3n-0002jB-B6
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:14:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1e137617-b980-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 12:14:05 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-BBAP4GEQMKiglsMqO2SObQ-1; Mon, 11 Apr 2022 12:14:12 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB8751.eurprd04.prod.outlook.com (2603:10a6:102:20d::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:14:10 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:14:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e137617-b980-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649672054;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cgBrnlbHbE94Dz2W5x+JupnQlSRJao/RXKVbaSgnKLI=;
	b=GZ5XVGipxms8lyL20B5xgMBvqTKw8LJSdVj/qp7iftaX+UbsfKtsjqmgWipcjBBBjXKHpV
	7oAUkwk4zFPzriOTq9nLyEJB1nBX6Qh53vbk+3sRUPK03T45T6Zhsed9v9x4FxDqOHZCJq
	i2U+hmPAC/19on6xjgHlUCkrDgateGM=
X-MC-Unique: BBAP4GEQMKiglsMqO2SObQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n6lA+UH47g/cJRJapzyCVfdXRtlYbHhuXe2rEULESejmkyJRu5d1QKCRFSE2UP8F+l3/O02KBJXpo5JDxp9YB+noD8zETaE/21GBCPaK8E17pHbonN+6HsPpCeUj5pGGM7P/i5o+Z8vY7kiRosLWTybJTNNUyvE0G1jbWdEY7pjS9/ok6XPelo3ersd2Bd4Exwlr7E1t1az022DoQGQGO4+OEeNHtUY28OcL6905pATHW9W8i5libqalFFiuubW9kn1uyyHQ78XVJxFelo7s4vPrpDO4Gbbzz1qRbuZaCGwepRW7RdHJJTzEpTeewMCKIfIaW8vf8DejCwObdST/XQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HsbicQS0HX6tFXGhI53aC6PdMclvFfXjvfs7N5vWcQE=;
 b=hEFa+hch1aZUMqAjphqa59DTRS2Wb874FolxgEaNcMs87j9UYiuyfCGCr5IY5AJGkVXutpsOyl17DTkZiK62TyGerz5nhK47ndOh/kO6x399XypLSC01oOZc2H7YKNmkTERSV0cSHO4Wgvm03QrIXhrj3QlWcSyiLWXIDvaQ5AtPpX6rdugrI8oL2r81adwFgHDf0sGgyECQiDEv9qckxuNoua0An6wvGn/k8C2joNGymIS8Lys7SAI0gNkHqDJOf5x9JzF5SrnHPaZuETu2LfEG2vTSbYlHK2JvND4JcxOwqr3+HcjIFDdMc4swEJI8sKbcPGSYg5Ld2rhOtZxqaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c940dfcc-322d-afa6-7f30-bc0a1b981581@suse.com>
Date: Mon, 11 Apr 2022 12:14:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: Ping: [PATCH v4 1/8] x86/boot: make "vga=current" work with
 graphics modes
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 "community.manager@xenproject.org" <community.manager@xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
 <YkwBpKcyrnuXyNPa@Air-de-Roger>
 <65d3068b-fde5-951b-9a60-4ba1dcd89a49@suse.com>
 <01992254-1a4d-850d-78c5-7e4ee738cffe@suse.com>
 <PA4PR08MB6253CEB380333171F2829F7492EA9@PA4PR08MB6253.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <PA4PR08MB6253CEB380333171F2829F7492EA9@PA4PR08MB6253.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR0301CA0012.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa7fec71-677e-45b3-bf94-08da1ba40552
X-MS-TrafficTypeDiagnostic: PAXPR04MB8751:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB8751C315B89917B5EE8AF670B3EA9@PAXPR04MB8751.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	enDBV1fsR7fKEI4E+Z+ndujMK4nNUOEA5W5kikbKEXO5BgpjWrnDv3RVLPwfRbi4c7AL4eORWB8s06iwqm1nine9cxzLp+pISvk5Qe/gsGizlsJWzo3cu/0yOTPfaJDIVlWUmvEXsXvTCCm+BKhj/yiqX8IrJMjJEm8QtgfEHuWaIMkZKCY/1VK7k6i6FgjpZGTTVre5CSdZl0CdrF8uY1liF6+pHxgk32rQf9vyWP0WKDuWjEMhbFmdKbRPX7ffDHZRC/Ic4tJNdQLyshY2H/fR4P8Zo31Q6nvMu0MVC2HRmgar6Wy0WXtt9OyjKwVQbWkCjjRGq3M4z0W64ImO/lwfZDVyZyQEHlYQrHv6SMtxEq1zrea4SzlF6fjQEa+DnhvNIPGt0lqYg5DObJg8EQYdTHy9YdoEKIJkz2e20xVhUaWy/r3oA1zTncNbTZ/dSmCxPXMelRQVObf/MukSu3FtZ3TmlD8zDYVwXlOeSeKe9dfksJgqo5MWfVAS17eA5MCHK7fFsDD52g766nI7k60fag0PV8E/soTnm32iSHBgT+HoybG1FUebyq3fqaFp1gaJiPcY4ztHaQVuifWwP0lohHNMpA/x4/bJAg0Pux7pMZbce6fUYHgzsiZLEcpoRl9mWsT49sK3AIRYbhGujT2XLDjH8gvBFvsIhi9X+8bamQoU2MfxLUkAL9EJlbDPdbNrF/FKIMqnRwTI3XZjT35dVMlcVLnPjRSA+5CkBoc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6486002)(26005)(5660300002)(4744005)(186003)(2906002)(36756003)(31686004)(316002)(508600001)(2616005)(4326008)(66946007)(6916009)(86362001)(8676002)(31696002)(66556008)(66476007)(54906003)(53546011)(6506007)(6512007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?SBfLaEklyXk/1tnGx1/mV3j/0oyh+OOQp3f5qE4HbV/cP6DzAfcQSppaguNG?=
 =?us-ascii?Q?LXjhdlgrN2ecIM3Np2BIlRzWg6cIQ6Rb7R2hjWDIt0Dn6bQpf1d0enJOMddb?=
 =?us-ascii?Q?t1Nj3pvV/JjMUrAAEiRNPAhYzFx130vrk7cTh2d1XaXKcbIuxF0J4z1/Rnkb?=
 =?us-ascii?Q?jglw7Qw/UhuzAni3W8L9fgfUZyadf+nUuHrnMeJdoOTO+BbF8k/eLL6vieX/?=
 =?us-ascii?Q?pdqk8a2Nm0pMmkZzpy2twr/m978p+rfORQi2UgpN3HXZI2lK+Gp02WhJBCEu?=
 =?us-ascii?Q?bj3cnMhXPOrpm3YMbXKdK85xK242c8VzkWuY9MZwkzjertBko5we4hDTMLYf?=
 =?us-ascii?Q?yRxzKKq/iLxMUctaE2Ulv596s7OgWs7COw+DEvXcF1uucgkmvqaA9yIK1QiC?=
 =?us-ascii?Q?eJVV1aDwM4fmNwbpBqkoDBcMmXY8a35XoQwK9Fa2adOR31cvs/ObGuWpbbro?=
 =?us-ascii?Q?rzJ615MdNB8iFyY8Z9f0DcupF9sJLf4+Mj6KJaxLQi4S8cvY1Shy7FkWy78u?=
 =?us-ascii?Q?J/Q0HsIdz4C1a96dILT29Ro0vyvvDBmZpZupixbtfn/Ds36abMaaH9QmAcy9?=
 =?us-ascii?Q?+t4nZk0VPXRF1UNLBSFlP8FuVlu66uC2BS4CbbCDyfz5GrwMqWs/uYEfGMw7?=
 =?us-ascii?Q?dR5aPtVTkvdaO55jyuvJlipG+N5G34YLyaM27fMBOdd4X3Vee4tuCFDwvSgV?=
 =?us-ascii?Q?SLryDWy5dxrf9A8AbcjBXuSoJqaEYlxYcw9FFdP/sSqryGZ/5JVOWj/d+qU2?=
 =?us-ascii?Q?DkSB1q2OVz0WKgXYhBh0b6tA/FYo+f/kHHEFE0h00ryqzZyQ7VopOzajKy93?=
 =?us-ascii?Q?w/ZamLncpIydgGszRsbuga24Lq7jIrQPq8ksekYj7+i5zf5HNffGQHr9lq7Y?=
 =?us-ascii?Q?WzuA/d4J43QzD0edvC8FRKAZH8kmF5+HskDe41eQS4T6qOJSb+XQFzt2shIC?=
 =?us-ascii?Q?iEAwvEHqZdX71hMc7fIg9OBRY5jXBnMDZ7635JyS6htUFTPdkDRaNkBXxR2p?=
 =?us-ascii?Q?vOiA5jnRbq0gbCVKBMbKYbQpbq4zMKdMN26UlfPWpCKR80kDifV/W+BIgoNs?=
 =?us-ascii?Q?R3wKPW02x6NuXLzRuUfvmEP5qUyAUaT7Gaq8o0Pwfs9yBMQ6733J5EyrJ5YE?=
 =?us-ascii?Q?DsO79ntiIE4b86YrKQB7X6+uIkRNuIG45OqxHARbJGrFy8ObyxZ3OMEeDeye?=
 =?us-ascii?Q?dLICEw+HC/Yf9regeKRRbGpDpPGilIek2tmt+NurwW4bbDu32u7iYjyAJuTD?=
 =?us-ascii?Q?pmNI88oDJzgdLQD1EgjKvTNL3YWQp69BqhVFXw7XKCQLOq8cr1IiM0dEVhdm?=
 =?us-ascii?Q?CaRBl+6CpbJ0Al6tpoYHCRP4j9qUI0YrK+Ew0+IwVfC7vDfsbUhKCdsREut0?=
 =?us-ascii?Q?sZNOnmz+NdLadDykxGKSmSbn3CRdyc+E23DdQ3j+X1/iNq+jX1v7sWFd5ch1?=
 =?us-ascii?Q?neyLI1PygSGaNRVBVIjQeMURLdI55+pe5IjxKMcAdIBHmXG69cc1fHOVikjT?=
 =?us-ascii?Q?8rymjIJ7Gueh4uAuEysYlbME1vYCp/KcilTOYcU2+AFsmwt9cf+H5TO080th?=
 =?us-ascii?Q?Zs7bJu6LlqYj4K0352DR8/2Iv5hFtKrAaVr6gK0lJiLHeHjXAbfFi9EtGQD/?=
 =?us-ascii?Q?CgjsITIZZzaQVRCyi+Je1hMP+uxIaklAzR17KePKcJvquulIDDBlTzZ9+ace?=
 =?us-ascii?Q?RbwtuWq4ZhIhClBllkVkAH9eZjBjOuvdBtliVGE5+lgFeGRJZNvVRURZK2aA?=
 =?us-ascii?Q?JeM5/c76gg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa7fec71-677e-45b3-bf94-08da1ba40552
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:14:10.5648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QvwI/XSFyZovjk9RCSAIXKyL9luET45YSiehRT9wji1BgJTvr8MLiI+eXg5V6QabIkYtOhRETsO1Dl/EUuPuWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8751

On 11.04.2022 12:11, Henry Wang wrote:
>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>
>>>> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>>
>>> May I ask for an ack or otherwise for the changelog entry, please?
>>
>> Ping? This is the only thing missing for me to commit the remaining
>> parts of this series.
>=20
> Sorry for the late response, the previous e-mail that you directly
> "to"ed me fell through the cracks somehow.
>=20
> Acked-by: Henry Wang <Henry.Wang@arm.com>

Thanks.

> Since you also mentioned the changelog entry, I will take a note of this
> series and we can have a discussion about adding it when we do the
> next Xen release (4.17). Would that sound ok with you?

"Adding it" where? Maybe you mean to the release notes, but that's not
entirely clear.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:17:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:17:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302862.516679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr6b-0003hT-D8; Mon, 11 Apr 2022 10:17:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302862.516679; Mon, 11 Apr 2022 10:17:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr6b-0003hM-9y; Mon, 11 Apr 2022 10:17:09 +0000
Received: by outflank-mailman (input) for mailman id 302862;
 Mon, 11 Apr 2022 10:17:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndr6Z-0003hG-Tf
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:17:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndr6Z-0003Ph-IR; Mon, 11 Apr 2022 10:17:07 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndr6Z-0001ku-C0; Mon, 11 Apr 2022 10:17:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=qVWqunGoZj/aDI/LIxAsvTFRgLk5BX3gdptBgLHmoGg=; b=sm6DV5spcRUmUqyHlW7hVx2NpV
	x9/DTUa67msgtpMv/12lsgq9tN1atIvT3L+Cof7Te/W9PaKtIlg2ibmFvrHEpS+nReOwyd2xSI9M+
	ZmOi6lCPnG6Okt3hFlZt7Of6lFAjX3kxrZ0IjClJwjvrYMGV0HPIhUHOb3oo5r+fqdt0=;
Message-ID: <72c25f35-0e1f-bc5a-c486-0d5ad676032f@xen.org>
Date: Mon, 11 Apr 2022 11:17:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v5 1/2] xen: Introduce a header to store common linker
 scripts content
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220411070300.77380-1-michal.orzel@arm.com>
 <20220411070300.77380-2-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220411070300.77380-2-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 11/04/2022 08:02, Michal Orzel wrote:
> Both x86 and arm linker scripts share quite a lot of common content.
> It is difficult to keep syncing them up, thus introduce a new header
> in include/xen called xen.lds.h to store the internals mutual to all
> the linker scripts.
> 
> Include this header in linker scripts for x86 and arm.
> This patch serves as an intermediate step before populating xen.lds.h
> and making use of its content in the linker scripts later on.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:18:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:18:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302865.516691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr7Q-0004IC-ML; Mon, 11 Apr 2022 10:18:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302865.516691; Mon, 11 Apr 2022 10:18:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr7Q-0004I5-In; Mon, 11 Apr 2022 10:18:00 +0000
Received: by outflank-mailman (input) for mailman id 302865;
 Mon, 11 Apr 2022 10:17:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndr7P-0004Hr-AQ
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:17:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndr7O-0003Qa-Tx; Mon, 11 Apr 2022 10:17:58 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndr7O-0001nH-O6; Mon, 11 Apr 2022 10:17:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=RZic369XXvhlfp1WwuJOseUM5biGA0c+lrGuAwVTkdo=; b=Dr5QIiKVeua3HeTT3klJNTv1PZ
	Rih3FDsodVraX82G609cP7jtUtdQVjntZt0srBVREW/gm9g1AXEiQuh1P+v0l9VIBCQdhBimPe2Tv
	00iNcuYMkdJy+eGqQaqxZYRAOBzT8USLN0JOJWQY5l8Ta/sQ1eTBaCmRfSUH2clt66yk=;
Message-ID: <a732b01e-0656-0795-466f-0c2a27b40325@xen.org>
Date: Mon, 11 Apr 2022 11:17:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v5 2/2] xen: Populate xen.lds.h and make use of its macros
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220411070300.77380-1-michal.orzel@arm.com>
 <20220411070300.77380-3-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220411070300.77380-3-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 11/04/2022 08:03, Michal Orzel wrote:
> Populate header file xen.lds.h with the first portion of macros storing
> constructs common to x86 and arm linker scripts. Replace the original
> constructs with these helpers.
> 
> No functional improvements to x86 linker script.
> 
> Making use of common macros improves arm linker script with:
> - explicit list of debug sections that otherwise are seen as "orphans"
>    by the linker. This will allow to fix issues after enabling linker
>    option --orphan-handling one day,
> - extended list of discarded section to include: .discard, destructors
>    related sections, .fini_array which can reference .text.exit,
> - sections not related to debugging that are placed by ld.lld. Even
>    though we do not support linking with LLD on Arm, these sections do
>    not cause problem to GNU ld,
> 
> As we are replacing hardcoded boundary specified as an argument to ALIGN
> function with POINTER_ALIGN, this changes the alignment in HYPFS_PARAM
> construct for arm32 from 8 to 4. It is fine as there are no 64bit values
> used in struct param_hypfs.
> 
> Please note that this patch does not aim to perform the full sync up
> between the linker scripts. It creates a base for further work.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:18:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:18:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302867.516702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr7n-0004ns-Ul; Mon, 11 Apr 2022 10:18:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302867.516702; Mon, 11 Apr 2022 10:18:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndr7n-0004nl-RX; Mon, 11 Apr 2022 10:18:23 +0000
Received: by outflank-mailman (input) for mailman id 302867;
 Mon, 11 Apr 2022 10:18:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndr7m-0004mG-E2
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:18:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b1340247-b980-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 12:18:12 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-Q_NBAtiMPTGcY7CetEUpyA-1; Mon, 11 Apr 2022 12:18:17 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:18:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:18:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1340247-b980-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649672301;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YUuHfxSN9yVgyp+MdEinxD3HIgk5+2q2xNMXiI7Ii2I=;
	b=l0eFtiYahHnO/+lpfeF6DrfXE3Di9pcKUcKr3OLTX3C2DKH0OjSRnNSiYn/7o2xsaKhaL7
	ZkQUmzM7QKcrq8DgdKNEVwnNdf7xU+lwp3pq5o/3OwWb9/+grMmN55ExZS8cykhvinN3Gq
	+MUrMDMLR3B24fvM8w/I+Kl9BOlqxac=
X-MC-Unique: Q_NBAtiMPTGcY7CetEUpyA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LdWIi1dNOsgQpmxsW/6NGoQbeM6I5AFHde32T8r1Q7xCwHV71m1jCWI4vYvNYpkDiHdtrtZPrj+wowPNhhHkGfDqknZ67enzoi9CTqhiNaQbuxAxZQmZkWvWBOi8YWdRLFOEYG0D05AYlaBZbKcgZLVLIjHLJq0kreP7iTwV/bzTZ9lAHOSvRoVjJLSMtXE0AMtAUiM0sOx+61A5McOoJ7OoAEnpWeyeud9DnXUTXVPeV62StmWBMcwbNXFhFeFXdAQ3VwweAOBy5pL/SLhQCyFJMM8rDHcuT+t0OzCL64HrNg0cIp7+f02a9STYTT1/cvKf3b+Oa2mOvE6pQAsJ3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FUbQDo9Kb3I9PKZFWq4LglkV3RQY7wo+HxS/U2Ly0qk=;
 b=nO851Hi2g9TlPsPgfS7tGkfpw6T2DS7AZmYA6lOwuTy0kkonqu/iqQIJaTaw67hf7lOrpK/1CgsipDiFCGikecKXra7gmo0/GVHR+uU7CJHUFglvKjUweloXTzRQ1JlKyBkT3KJoFxGN/Npzj1ueRh7h9uuyrOCG/XUmEHzgyAWZpZflSo82FRFXiCvrTH3/lM5pBbJw8CkA1Q0rWElmywaJa9pXU9XvsC94W2/t2LgIKuJze9ErTc38YvVwOgdEFlhZeUXTdoxQnieXpfUAvs5Uc3EgoPWhcOXpuUsmBtCO7eXt9JRNKwtxjgJBco7kn+4T/Tg78TW0fIQYH5Vt2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ae59d52f-7a4c-a4da-275a-a3cc419b94e3@suse.com>
Date: Mon, 11 Apr 2022 12:18:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
 <7b79d293-80c3-d368-1abf-581f57dd2f82@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7b79d293-80c3-d368-1abf-581f57dd2f82@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0301CA0015.eurprd03.prod.outlook.com
 (2603:10a6:206:14::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d52fff5a-07f9-4f6e-0e52-08da1ba49763
X-MS-TrafficTypeDiagnostic: DU2PR04MB8551:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8551162BB84052CF4D5DBD3EB3EA9@DU2PR04MB8551.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OfjB10rit5SlUIL3WRx9ViOhBt/XBk0Hl//6HIKpU1bTpIu523Wis5vPy22C+8Rhflc/kvaghF4lctSSB5SL0jgVbU20PES1p4LC+hup0TcGmmICCKHBOk8NiskbvCNkUDCtQMLxjtFJvFmGDnLM8UXGcQ6q+HLt7UVp74kPdmTt2RBTKywQYSCUzJ5A6nyKS5n5xqVRTSt6+1Vg6I3mGGp3RcCq6orZ9LeazBMNeSJCcWzLu/KtjNAf1vchNYqEsDxDHfJKLY4M06u36A6Sp8lzLPrnifZ3ApPcOLMxZ1ygRasm1razPxNFAi+iHmDN/DZZtdsguBVJEkSOAVmH8drXWP3uBOooxWk8WDwM4a1mOl20WX8U4ALG9i/Y+EnQcTE20AR8JT8LXu8y1jxWC9Kz/+BRwOSDrlkM/qtl4u9MegN101aHKoG1tFcRDnK6mDjLDLGTbCVXmAkmk1d6uHPJeOFPD35QgzA+2XbDO8cidVaXncFIhgSBR2c22uOgJNyO5F55ccXF1xwQj1BIUM7JV9S4Bc43BZQMLpAp/m0vTGkGk1M37CuF+EYd4EyifjIjmj+mJ4FU1dYkeHXyb3gBdg4Z5+kWGx8y02qmcj84qO0aA6dGZzFe62qRek6qOybD5H2FJZ3vm0LAq0eNO0f/FfjdguPiBscMYdLvYuKZaJqB6X1SOvmzeK7gZWNtrGNOC784JIi785K+CKzDVJrpawiHWMpdZE5CkXlPzIU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(5660300002)(6916009)(8676002)(31696002)(66476007)(66556008)(4326008)(8936002)(316002)(86362001)(6512007)(53546011)(6506007)(83380400001)(186003)(6486002)(38100700002)(2616005)(26005)(54906003)(508600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?e0nvDutkHmh/gaizLQEsLVel3paH+eyO9fqNJ6/bH7DPhKNd76unJwQQ+7sF?=
 =?us-ascii?Q?9tmGOAh02oyzqxG+s0aDRDnOsjpXhSnWybE0mw5gexl0G8JpnQJMMP5Tu7M1?=
 =?us-ascii?Q?/FqAeEzrB21PxtO9vyyahYcQ68DzL1sKrjv93rkXtEEt1kYIr+LpE/PcWX9v?=
 =?us-ascii?Q?cP+mMIt0+s0QwLWCrxA3JQ2MEbglwXBuSNETFDuWpLeQ8zF5O8toA9yAES5H?=
 =?us-ascii?Q?Vf1OfQujAh4NgvdpCe5pccHnaEIWAJJFyXnHOK4LDJZP90TN1ahAqPt3Nt3B?=
 =?us-ascii?Q?f7GhWCyC0qvjkVZZsNeZV3FQ+d6zwtCulUkgWrYDQLuhoNHt3crUDPP+YOyY?=
 =?us-ascii?Q?U+Cy2SQb1T8UQuhSjSPoIrxVxnACVoGY8TiyvLD0jVoUG6zC6CNt42kMbaq7?=
 =?us-ascii?Q?NWWYIif03cTT/HT0RIDNWgkN2mGUwiV8IKzi16z6aRaFevgDcVMDP/SEWtcQ?=
 =?us-ascii?Q?9jqqae3nbFgmtOLrlN2V1uBaP+yd26/JxuLZjJgURiNl8SmodylqdqZNMiv3?=
 =?us-ascii?Q?oadgtd5X8RiOXB1+AxTbPKEv/z2N066GmxGb0bCekD33y23B3eob0S7c95R0?=
 =?us-ascii?Q?YWPE855kT8GH3uU3GeV29vzZNDoZLxRF+IdzQrxvXHFD7/5zk+OdDGMJAemg?=
 =?us-ascii?Q?TP2MSyzO90HPTwceKLMDXQ47ueKqjh8cjmEZnVcSL2+oGUZo6A0xu7NPVwut?=
 =?us-ascii?Q?ev5AP0t5MyTQLhXP1bza9TSBAWKpM/MtWqnDG5M2vRjeQBNx2gNUNzz2IheU?=
 =?us-ascii?Q?8uk0672boyEJi2Gxj0U5xzddJktzqhQjUblBzbIWVPl10W9P17SHWQUtznq7?=
 =?us-ascii?Q?NaZbxqnBGqhozE0t6NEDalkIQCDQLTHSZlBPyDHxacfjPBaFumI6ynZfxry1?=
 =?us-ascii?Q?a4u5MN1yWIX+wAHoc7e12AR2sANS72Tdl5tdi2gp1xZeX2mo5KMvZzbFgDfn?=
 =?us-ascii?Q?efzpFRMt4eDAEKpEYbRpQSuixroSTTaPsjIHklOF/G+nESOfUTcpD2lu2BrS?=
 =?us-ascii?Q?5VZQrPQzZ3wN4xLzkIRvAf5bbfh8+hpywJrp4zVzhkPlMSO8G19CLg1J74ED?=
 =?us-ascii?Q?ak0KGQ/eP/zXOXxUiPiG6AEiVWaPTUSqo8TmxlaDYo60H8yEgf7tjvHpMXbF?=
 =?us-ascii?Q?03UoRWPuCHJaKqcK+FEEtJ/ZxNkl2tcEowscAamfjq69sKqCgDbAByUqIbj+?=
 =?us-ascii?Q?UKisobgIe3C0/8bn7kM0/yG4mP+5ptcfnhnMnWWrJ2S9lA+mACuJ0D9zqVq2?=
 =?us-ascii?Q?gq0oBXBLQ2ZeV++M4akzITcoe33ehOQomy6bD0i4nsMnS9mKlRv7zuJ+QDnE?=
 =?us-ascii?Q?mrfWrkb0viJuecGkkKbJqaDkPCXzLUx9dwnvaiCn1yLhqMjQCXA1At73MFTY?=
 =?us-ascii?Q?kwHqXViEsWmfh6jVoDbIbqLK9BaGPMbB9Ye2QSqJUeL2L/uI8e96YMoPn4Gc?=
 =?us-ascii?Q?2VkBfWjGduotBRV/nPymn9yBtHHuIYRwnFqKcqwviNCK+CjIKPW+7flqMhi3?=
 =?us-ascii?Q?k22s2+T8UIxp25Em950oYwhl7mLs9RIp3nti4M+qTO76EBq52TNaSlSHPaGC?=
 =?us-ascii?Q?cGIo4b2ZpmMhbDIOcsWOQDf6pMSGM6YGIRDsmu/CLf6jMgF/wmX4Sp++uXun?=
 =?us-ascii?Q?CpTuCh32l8yKULVwddpgxEu8ESDdUxerTSGys4HE6hj6sR+w+tPmd4uee59E?=
 =?us-ascii?Q?oY0hKzMFsb+bs6Q7da+W8W8v6B9+CyqlN6GRgvjqrZ0jbqp0uNahz8duX7pi?=
 =?us-ascii?Q?m//OySnuFw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d52fff5a-07f9-4f6e-0e52-08da1ba49763
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:18:15.5878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yC7cRExoOXs05VPRoUuDFNzoFVJZWHxxjaPlpPmKtmFxgA/KrlHftBUrEi0EVr7am1I7tXSfo9gBRzYTyxpwFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551

On 11.04.2022 12:01, Andrew Cooper wrote:
> On 11/04/2022 10:35, Jan Beulich wrote:
>> Prior extension of these functions to enable per-device quarantine page
>> tables already didn't add more locking there, but merely left in place
>> what had been there before. But really locking is unnecessary here:
>> We're running with pcidevs_lock held (i.e. multiple invocations of the
>> same function [or their teardown equivalents] are impossible, and hence
>> there are no "local" races), while all consuming of the data being
>> populated here can't race anyway due to happening sequentially
>> afterwards. See also the comment in struct arch_pci_dev.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> It is only legitimate to drop these calls if you delete the mapping_lock
> entirely.=C2=A0 Otherwise you're breaking the semantics of mapping_lock.

Not for all domains other than DomIO. And DomIO is, well, special. As
is at what times quarantine_init() is actually being invoked.

> Your argument of "well this is already guarded by the pci lock" means
> that these are uncontended lock/unlock operations, and therefore not
> interesting to drop in the first place.
>=20
> This patch is specifically setting us up for an XSA in the future when
> the behaviour of the the PCI lock changes, the fix for which will be
> revert this patch.

That wouldn't suffice then. As said in the description, and as discussed
during the development of the XSA-400 series, further locking would need
adding then.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:20:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:20:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302877.516713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrA2-0006Jq-B3; Mon, 11 Apr 2022 10:20:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302877.516713; Mon, 11 Apr 2022 10:20:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrA2-0006Jj-86; Mon, 11 Apr 2022 10:20:42 +0000
Received: by outflank-mailman (input) for mailman id 302877;
 Mon, 11 Apr 2022 10:20:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndrA1-0006Ja-0Z
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:20:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndr9x-0003VN-8U; Mon, 11 Apr 2022 10:20:37 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndr9x-0001vT-28; Mon, 11 Apr 2022 10:20:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Fx8e/BCmEIGVcEn/oDxkMpqfG8K0VZr74epy7XlS7XA=; b=co5oRw9aE+iGuAIeyUBZZckMvc
	AkUvy0XkqcdVtSEHvcrvsOZ6ndtfY0sK8MICpBUyft0rDIP5g7Fti4qntZOmuF1lDkiZL/KTlK72J
	jfzumxL5AcgdpvxhLjiorRzmYHW7DMu5FR3S/28WhMYrgCkDwlt0mO9CZcV5XeUM88zs=;
Message-ID: <f0179c9c-e268-7858-2956-c3433a4e19cb@xen.org>
Date: Mon, 11 Apr 2022 11:20:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH V4 1/2] xen/arm: Add i.MX lpuart driver
To: Michal Orzel <michal.orzel@arm.com>, "Peng Fan (OSS)"
 <peng.fan@oss.nxp.com>, sstabellini@kernel.org, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>, Henry Wang <Henry.Wang@arm.com>
References: <20220408140932.17968-1-peng.fan@oss.nxp.com>
 <20220408140932.17968-2-peng.fan@oss.nxp.com>
 <d164f7a7-a219-63ad-580d-ead86ea79103@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <d164f7a7-a219-63ad-580d-ead86ea79103@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 11/04/2022 07:26, Michal Orzel wrote:
> On 08.04.2022 16:09, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> The i.MX LPUART Documentation:
>> https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
>> Chatper 13.6 Low Power Universal Asynchronous Receiver/
>> Transmitter (LPUART)
>>
>> Tested-by: Henry Wang <Henry.Wang@arm.com>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>   xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
>>   xen/drivers/char/Kconfig              |   7 +
>>   xen/drivers/char/Makefile             |   1 +
>>   xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
>>   4 files changed, 348 insertions(+)
>>   create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
>>   create mode 100644 xen/drivers/char/imx-lpuart.c
>>
>> diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
>> new file mode 100644
>> index 0000000000..26e2cf0249
>> --- /dev/null
>> +++ b/xen/arch/arm/include/asm/imx-lpuart.h
>> @@ -0,0 +1,64 @@
>> +/*
>> + * xen/arch/arm/include/asm/imx-lpuart.h
>> + *
>> + * Common constant definition between early printk and the LPUART driver
>> + *
>> + * Peng Fan <peng.fan@nxp.com>
>> + * Copyright 2022 NXP
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#ifndef __ASM_ARM_IMX_LPUART_H__
>> +#define __ASM_ARM_IMX_LPUART_H__
>> +
>> +/* 32-bit register definition */
>> +#define UARTBAUD          (0x10)
>> +#define UARTSTAT          (0x14)
>> +#define UARTCTRL          (0x18)
>> +#define UARTDATA          (0x1C)
>> +#define UARTMATCH         (0x20)
>> +#define UARTMODIR         (0x24)
>> +#define UARTFIFO          (0x28)
>> +#define UARTWATER         (0x2c)
>> +
>> +#define UARTSTAT_TDRE     BIT(23, UL)
>> +#define UARTSTAT_TC       BIT(22, UL)
>> +#define UARTSTAT_RDRF     BIT(21, UL)
>> +#define UARTSTAT_OR       BIT(19, UL)
>> +
>> +#define UARTBAUD_OSR_SHIFT (24)
>> +#define UARTBAUD_OSR_MASK (0x1f)
>> +#define UARTBAUD_SBR_MASK (0x1fff)
>> +#define UARTBAUD_BOTHEDGE (0x00020000)
>> +#define UARTBAUD_TDMAE    (0x00800000)
>> +#define UARTBAUD_RDMAE    (0x00200000)It seems like you missed my comment about alignment from the previous patch version.
> Please keep the same alignment of values within the same section.

I haven't yet reviewed this patch. But if this is the only comment, then 
I can update the alignment on commit.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:21:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:21:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302880.516724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrAK-0006oB-MT; Mon, 11 Apr 2022 10:21:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302880.516724; Mon, 11 Apr 2022 10:21:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrAK-0006o4-JK; Mon, 11 Apr 2022 10:21:00 +0000
Received: by outflank-mailman (input) for mailman id 302880;
 Mon, 11 Apr 2022 10:20:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ndrAJ-0006nS-NT
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:20:59 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0617.outbound.protection.outlook.com
 [2a01:111:f400:fe02::617])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1434ae47-b981-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 12:20:58 +0200 (CEST)
Received: from AM0PR01CA0173.eurprd01.prod.exchangelabs.com
 (2603:10a6:208:aa::42) by AM6PR08MB4738.eurprd08.prod.outlook.com
 (2603:10a6:20b:cf::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:20:47 +0000
Received: from VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:208:aa:cafe::c5) by AM0PR01CA0173.outlook.office365.com
 (2603:10a6:208:aa::42) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 10:20:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT050.mail.protection.outlook.com (10.152.19.209) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 10:20:46 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Mon, 11 Apr 2022 10:20:46 +0000
Received: from c60e5316a7df.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1C2275A6-06B0-462F-BA64-AD1447F17FBE.1; 
 Mon, 11 Apr 2022 10:20:39 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c60e5316a7df.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 10:20:39 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM0PR08MB4531.eurprd08.prod.outlook.com (2603:10a6:208:13f::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:20:38 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:20:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1434ae47-b981-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DR5PaOqzj/Cf7hb3h8Wg8jBz1qeMrTRFTsrD9AD/eJQ=;
 b=aNWrxvar6qvYX6HhiRzwuEf4ezNieTBkuz3rKMZNmj5DMVf/yL+31CqHUt8kI82crNqGjtSdMF1Sa1En1FwJmMRpm3nMbptxPP29mLwDwTdrBHT9uARaN4D1FWX0028fGGDALLT6RiREpMi82+NS77iGqUjltTZomFx8DntIOvs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a4e9601e69a0dee9
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HplSikpbF3BcjxeIqaWt7dZVpleQLtt+4k6Tn7xybURawGNauL1zSnJwB5svz+GQITnqIo3fH/6HZeDux35BjLc475tTj8+r6B6E3V5QRFpnt1vV3u3VJ9nXIBu6+mbuZPxOd81WbiS8hVwhImW3lX/OKRFsXhny3ma/t36n20z4ZHBPugi+srjpg1Geb5TI7FgQ/wxN7or8XZogUv1x0N9Ia4ljDFczCqsj+JIoCd/7A5qLuAmrBkYTdcyYdXMVFtJUyJnwlJg3XSPPKnJkSGYH6EQc0PrdDEBBt2DWGDj3yOwtZc56KB5d/rTjG5wEgmg+TVsBrc7viZQdmAPCcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DR5PaOqzj/Cf7hb3h8Wg8jBz1qeMrTRFTsrD9AD/eJQ=;
 b=TffWfUYHv1GhcWW3QVLRnm6AB6OcyKcYNKjZtHlz1zQRl2SMx4nHv7HvFVakH66BjL+DwZvRi2CsE1wsoVJODy1BwzcVFxmFM4pfFDg7Wq8mTvf85yrfuweAW00aqBv/BaWCn9rkZD66egwS1xv2uEDHUTxM2jeLeG/CpqRSp6DqgxcEnV0CSRLaShSdEIDxMFuFqABjBKjro9tssgMkauGy86P6TFyNjGwjpp/fggv4AlGfd0cIND/UlrmLwrgYb2ynMwnknNzKI+HBeKxb6VmDwmUiZpDPQysPsARWe/KZ1Ah6/hxS4xsANvpICPBNT66dDhn5b7KgFX5ZwwOB5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DR5PaOqzj/Cf7hb3h8Wg8jBz1qeMrTRFTsrD9AD/eJQ=;
 b=aNWrxvar6qvYX6HhiRzwuEf4ezNieTBkuz3rKMZNmj5DMVf/yL+31CqHUt8kI82crNqGjtSdMF1Sa1En1FwJmMRpm3nMbptxPP29mLwDwTdrBHT9uARaN4D1FWX0028fGGDALLT6RiREpMi82+NS77iGqUjltTZomFx8DntIOvs=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Thread-Topic: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Thread-Index:
 AQHYSyUS0CLVSvR2nk+ITbzc2Ry0wKzlusgAgAAH7oCAAAy5gIAADjGAgAAPS4CABIA3gIAABA2AgAAUGYA=
Date: Mon, 11 Apr 2022 10:20:38 +0000
Message-ID: <74450613-4B05-4FB7-84F7-A26EAC3CEA20@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
 <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
 <cacbaa1c-8ae8-9314-9364-97e5a53d876b@suse.com>
 <61DEEA58-E570-4FEF-9B71-27316C7F8D7C@arm.com>
 <0a85f239-dbf8-2e06-0158-75a1c1c40a4c@suse.com>
 <DC3522A8-ADA1-4F6A-A3CF-C8095C2F639D@arm.com>
 <e6450fd4-662a-abaa-4b9e-1d8a4ff41962@suse.com>
In-Reply-To: <e6450fd4-662a-abaa-4b9e-1d8a4ff41962@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 7c8454cf-d8dd-4d5d-f4c1-08da1ba4f1b2
x-ms-traffictypediagnostic:
	AM0PR08MB4531:EE_|VE1EUR03FT050:EE_|AM6PR08MB4738:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB47384EDBC8DA80DDBB00BC2FE4EA9@AM6PR08MB4738.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6ZHTw8qW6wiXam7uEl638zFVkGfIstDGZ/0FjiGbgKKwCMkqf6/ZPSji/NU8d+AzguPNe5A68Z+eZ263eyAWvgFEj/d5fLM3CkEnvVWKCLVATHgljDljj+kqnduCohv/jIhVrm8zCmbmlt5eZ5raGY7IqLBhiTdGeARWnii/17PtZ067cOsjq160V7tW2HAaWeTmVAeTFRVRYkU1TSTxSyS1uQk6M314tdenjoUTu6H54she716yVSVXzHJd9K/EZOHSCU4w3LfRM8ui99GaV/WQR8LiiqrOILGcpDYBpwDlWrPu6Xz4LdT9uinpGwpsZ+H89n4dmQpewkKH2WHCFcjMh5KktJ/ZxeWk8r0RDNDTNEIkeBhrn5jJuBFuBBWgYPCictqiM/TvQa4wGAp7sG1sFVT43XG80HpuMPJJyII2JDJCyozxK5TQ3w7Vxt6wU2fhJu81ZGcs+tqoZ0yAJYDi6ctbTiu5Ot4HppU57QGYTcLMDXBKZOSw3DHcFIoegurAZoeB+6o4XTXtIV13gMenYKMxEOelaoey1Xwk5h7ETB6t5WL2CEORLx0qo0Z9V3TPPD6IbYTRD8Eiw3H7K9D5K8yRX+OfrD/QenqdR6+vS5WIRE7g/1xKiGlQHhZdqUSwe7E8f+82tbdlXLmAeNDLbAsMkNNVyQMk4nM8xxj2ZAxFmEgnD5rnK3QNqtSpG6ISC+Yhzl4C1si86WH0Dh1WjCajEXpFkvRHnXN6tHmreqCkgXTIPcB0gZVDjzvJW2FsETjvdn3rlF8hYrTjVQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(5660300002)(66946007)(6916009)(66574015)(76116006)(66556008)(8676002)(6506007)(53546011)(4326008)(186003)(122000001)(66476007)(64756008)(6512007)(66446008)(86362001)(71200400001)(2906002)(508600001)(36756003)(2616005)(8936002)(55236004)(26005)(83380400001)(6486002)(38100700002)(91956017)(33656002)(316002)(38070700005)(32563001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <6270428FC0A4114A96C0BD60E1B456F4@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4531
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f65b708c-a387-480f-7faf-08da1ba4ec89
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZEmyudcQKacyaevtg0bmme8e3O38ZIv8Hom8vK3pyzUQxR0Y+WNjIhB7Y5fB36h6SU6FOk2nqXsWvuGY49aca2GOmOeeC2ZRDWRuPvuctirQhuosaKuC93m5g8rqN2+8OoAVijhnhYhjT/kFGo60aeVFbNLlNI7bOHwmW9kKmU35RCUh5sQog/lJ3tM4r/gsR1rmvjK3sOsqL/NDCKEoDiF9b0prZ07kGx+L66RnxrlwmPbnz3X/Ggk94goVd7/K4X1EBOAh2togY25sFq/p4skYrFVWKZ3A4gfI3yLRfwDPFxTz73WSynfnUW9RIOhlJjv8ef/KUxC9q5Bf2bcVa/pCm0KorHivLWPDtYU+O0RvbouwvnqAqXc+GxhaNh9FZhxVxVwZxB+Yr38vOBOcCuiCN8O5HtdZRnlOs985eEcyJmG9C85eU3U92f2p3UWjKWnoZKaFONZ7UFtgmRF+geTLh68plbdBDrUun5uqdGa9eqjP8Waso2pkuDmR8/eA07L/+deXCqkK5z8JA7Mq4XiYZ8FvWONmjtdgTpG+77x8z8XZfU+K5uEQr6ufSmLy459uCLqm4UkMChxodoaXJpMhUpkysGeRM5W8EoSmN6CKDAcuYfrUt4t94N0ISYyS+wjubt8tNYJujXabwPGD5aL+JoD0rgb4EDFUScV2ZhHy2g13t6gRqVORFUoiqdbBG4BboQDTx/62HlPybIrRTQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(86362001)(54906003)(36756003)(508600001)(82310400005)(40460700003)(47076005)(2616005)(356005)(81166007)(316002)(6486002)(70206006)(70586007)(8676002)(4326008)(6862004)(8936002)(53546011)(5660300002)(6506007)(2906002)(186003)(66574015)(6512007)(36860700001)(26005)(336012)(83380400001)(33656002)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:20:46.8876
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c8454cf-d8dd-4d5d-f4c1-08da1ba4f1b2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4738

DQoNCj4gT24gMTEgQXByIDIwMjIsIGF0IDEwOjA4LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTEuMDQuMjAyMiAxMDo1NCwgTHVjYSBGYW5jZWxsdSB3
cm90ZToNCj4+PiBPbiA4IEFwciAyMDIyLCBhdCAxMzoxMCwgSmFuIEJldWxpY2ggPGpiZXVsaWNo
QHN1c2UuY29tPiB3cm90ZToNCj4+PiBPbiAwOC4wNC4yMDIyIDEzOjE1LCBMdWNhIEZhbmNlbGx1
IHdyb3RlOg0KPj4+Pj4gT24gOCBBcHIgMjAyMiwgYXQgMTE6MjQsIEphbiBCZXVsaWNoIDxqYmV1
bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4+PiBPbiAwOC4wNC4yMDIyIDExOjM5LCBMdWNhIEZh
bmNlbGx1IHdyb3RlOg0KPj4+Pj4+PiBPbiA4IEFwciAyMDIyLCBhdCAxMDoxMCwgSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+Pj4gT24gMDguMDQuMjAyMiAxMDo0
NSwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+Pj4+IEBAIC0xMDYsNiArMTA2LDggQEAgc3Ry
dWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluIHsNCj4+Pj4+Pj4+IC8qIFBlci12Q1BVIGJ1ZmZl
ciBzaXplIGluIGJ5dGVzLiAwIHRvIGRpc2FibGUuICovDQo+Pj4+Pj4+PiB1aW50MzJfdCB2bXRy
YWNlX3NpemU7DQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+ICsgdWludDMyX3QgY3B1cG9vbF9pZDsNCj4+
Pj4+Pj4gDQo+Pj4+Pj4+IFRoaXMgY291bGQgZG8gd2l0aCBhIGNvbW1lbnQgZXhwbGFpbmluZyBk
ZWZhdWx0IGJlaGF2aW9yLiBJbiBwYXJ0aWN1bGFyDQo+Pj4+Pj4+IEkgd29uZGVyIHdoYXQgMCBt
ZWFuczogTG9va2luZyBhdCBjcHVwb29sX2Rlc3Ryb3koKSBJIGNhbid0IHNlZSB0aGF0IGl0DQo+
Pj4+Pj4+IHdvdWxkIGJlIGltcG9zc2libGUgdG8gZGVsZXRlIHBvb2wgMCAoYnV0IHRoZXJlIG1h
eSBvZiBjb3Vyc2UgYmUNCj4+Pj4+Pj4gcmVhc29ucyBlbHNld2hlcmUsIGUuZy4gcHJldmVudGlu
ZyBwb29sIDAgdG8gZXZlciBnbyBlbXB0eSkgLSBKw7xyZ2VuPw0KPj4+Pj4+PiBZZXQgaWYgcG9v
bCAwIGNhbiBiZSByZW1vdmVkLCB6ZXJvIGJlaW5nIHBhc3NlZCBpbiBoZXJlIHNob3VsZCBpbW8g
bm90DQo+Pj4+Pj4+IGxlYWQgdG8gZmFpbHVyZSBvZiBWTSBjcmVhdGlvbi4gT3RvaCBJIHVuZGVy
c3RhbmQgdGhhdCB0aGlzIHdvdWxkDQo+Pj4+Pj4+IGFscmVhZHkgaGFwcGVuIGFoZWFkIG9mIHlv
dXIgY2hhbmdlLCBwcmV2ZW50aW5nIG9mIHdoaWNoIHdvdWxkDQo+Pj4+Pj4+IGFwcGFyZW50bHkg
cG9zc2libGUgb25seSB2aWEgcGFzc2luZyBDUFVQT09MSURfTk9ORSBoZXJlLg0KPj4+Pj4+IA0K
Pj4+Pj4+IFBvb2wtMCBjYW7igJl0IGJlIGVtcHRpZWQgYmVjYXVzZSBEb20wIGlzIHNpdHRpbmcg
dGhlcmUgKHRoZSBwYXRjaCBpcyBtb2RpZnlpbmcNCj4+Pj4+PiBjcHVwb29sX2lkIG9ubHkgZm9y
IERvbVVzKS4NCj4+Pj4+IA0KPj4+Pj4gQnV0IHdlJ3JlIHRhbGtpbmcgYWJvdXQgZG9tMGxlc3Mg
YXMgcGVyIHRoZSBzdWJqZWN0IG9mIHRoZSBwYXRjaCBoZXJlLg0KPj4+PiANCj4+Pj4gRG9tYWlu
cyBzdGFydGVkIHVzaW5nIGRvbTBsZXNzIGZlYXR1cmUgYXJlIG5vdCBwcml2aWxlZ2VkIGFuZCBj
YW7igJl0IGRvIGFueSBvcGVyYXRpb24NCj4+Pj4gb24gY3B1IHBvb2xzLCB0aGF04oCZcyB3aHkg
SSB0aG91Z2h0IGFib3V0IERvbTAuDQo+Pj4gDQo+Pj4gSXQncyBhbGwgYSBtYXR0ZXIgb2YgWFNN
IHBvbGljeSB3aGF0IGEgZG9tYWluIG1heSBvciBtYXkgbm90IGJlIGFibGUNCj4+PiB0byBjYXJy
eSBvdXQuDQo+PiANCj4+IFllcyB5b3UgYXJlIHJpZ2h0LCBob3dldmVyIEkgZGlkbuKAmXQgc2Vl
IHNvIGZhciB0aGlzIHVzZSBjYXNlIHdpdGggYSBkb21VIGFuZCB0aGUgdG9vbCBzdGFjaywNCj4+
IHByb2JhYmx5IGJlY2F1c2UgaXQgd291bGQgbmVlZCBhbHNvIHhlbnN0b3JlIGV0Y+KApiBJ4oCZ
bSBhd2FyZSB0aGF0IHRoZXJlIGlzIHNvbWUgd29yayBnb2luZw0KPj4gb24gdG8gZW5hYmxlIGl0
IGFsc28gZm9yIGRvbTBsZXNzIGRvbVVzLCBzbyBteSBxdWVzdGlvbiBpczoNCj4+IA0KPj4gRG8g
eW91IHNlZSB0aGlzIGFzIGEgYmxvY2tlciBmb3IgdGhpcyBwYXRjaD8gQXJlIHlvdSBvayBpZiBJ
IHNlbmQgdGhpcyBwYXRjaCB3aXRoIGp1c3QgdGhlIGNvbW1lbnQNCj4+IGJlbG93IG9yIGluIHlv
dXIgb3BpbmlvbiB0aGlzIHBhdGNoIHJlcXVpcmVzIHNvbWUgb3RoZXIgd29yaz8NCj4gDQo+IEFn
cmVlbWVudCBsb29rcyB0byBiZSB0aGF0IHRoZXJlIHNob3VsZCBiZSBwcmVjYXV0aW9uYXJ5IGNv
ZGUgYWRkZWQNCj4gdG8gcHJldmVudCB0aGUgZGVsZXRpbmcgb2YgcG9vbCAwLiBUaGlzIGltbyB3
YW50cyB0byBiZSBhIHByZXJlcQ0KPiBjaGFuZ2UgdG8gdGhlIG9uZSBoZXJlLg0KDQpTaW5jZSB3
ZSBoYXZlIHRoZSByZXF1aXJlbWVudCBvZiBoYXZpbmcgY3B1MCBpbiBwb29sLTAsIEnigJltIHRo
aW5raW5nIGFib3V0IGEgY2hlY2sgdG8gZG9u4oCZdCBhbGxvdw0KQ3B1MCB0byBiZSByZW1vdmVk
IGZyb20gcG9vbC0wLCB0aGF0IHdpbGwgY292ZXIgYWxzbyB0aGUgZGVzdHJveSBjYXNlIGJlY2F1
c2Ugd2UgY2Fu4oCZdCBkZXN0cm95DQphIGNwdXBvb2wgdGhhdCBpcyBub3QgZW1wdHkuDQoNCklu
IHlvdXIgb3BpbmlvbiBpcyBpdCBvayB0byBwcm9jZWVkIHdpdGggYSBzZXBhcmF0ZSBwYXRjaCBh
cyBwcmVyZXEgd29yayBoYXZpbmcgdGhpcyBjaGFuZ2U/DQoNCj4gDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:23:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:23:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302889.516735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrCr-0007jA-51; Mon, 11 Apr 2022 10:23:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302889.516735; Mon, 11 Apr 2022 10:23:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrCr-0007j3-1P; Mon, 11 Apr 2022 10:23:37 +0000
Received: by outflank-mailman (input) for mailman id 302889;
 Mon, 11 Apr 2022 10:23:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndrCp-0007ir-Ho
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:23:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6bc17148-b981-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 12:23:25 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-ebh3nIGuPvO9ZW-iGzLKmw-2; Mon, 11 Apr 2022 12:23:31 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4851.eurprd04.prod.outlook.com (2603:10a6:208:c2::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:23:28 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:23:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bc17148-b981-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649672614;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zpXqXZUbFL8JOfNoy5WxYpsQYl1Fv+JfKonl7GsOyes=;
	b=hp9aAFwKpJ8VCrWRZG8q6wIG1yOuByrscpcxjiRJpghi6PoIzyC3EHiLPrZiskmntMgxcS
	gVO4OfQDJJI/wimK56BSMh2FyJbbQU/Kq4ByOkIePNEiPxJWfQ/s3YVUdp7CWyCvtHw4Lz
	Nm+jJngKKEoYQ81a4flmSnR7z7if+Rw=
X-MC-Unique: ebh3nIGuPvO9ZW-iGzLKmw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PcwCxT01+BKyvaZnVso2ePyh9BrosT3RFRmSoyJp4Jl2Y7waCAVzhXLACEQ3Mjc4ZRQ9h6ahRg2iv86JCHcFm7k8R8Bff6BnyKuX1tbkY2zxTp+w4ljY5gsBZdoLl7KmmErt6cna/Z13q6BnmgFyaPRk21ORrhbjJoIPjKDaiQy+S2cul5mGGpiw4maDrg42d8y5XZ3zt/nXGk7lk8kkli1uxaDKxCF4QzzD/i+CjWpxl/hbwA4GNs+qWJOvXJczkJZ5DeSm5sLWM0HHDe8awljqR9sD0THIpHZNh+41Wpa4HHra0ZVuu7CVBLN/eLwd0ts5PqPbPq561Wfn/55joA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BRcR77ZdeaZbb43bpHs36xIw0hS9pFgZRJLZeUUUBXw=;
 b=ZdpQEaYxZXRgD4rRHwr+8xdtohAU6124bbCS1fA4/1rpU/0jJk2YwO0xT0krc9rUBn+87TSNwYxHwwnNdx02G+gTLWH6esm1qAyFOmkuQPZWZ0mh7Ar/4yZdq87V0pGd3Ri82ytxAGDHhwktseBijlI5eZR6Xzhy1DmLi3dprmtoo30KiMieBcFLYUzUTOafr3OlpJeTh1fxY9XVGlK+N0Om5Z+n3huZwRpoCst7xCwe90x2PP4gjjx5MNI+6Lr68pacR9oqoS7x3sfsstwNGzJSKTnlSL0Ka2gls2teMIgdgntWo9W7nKq+jkX/2YaAw6GoAqZp3fXMXPaM7K5OxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5255b107-24d7-eb88-24b6-d8ea86b20e87@suse.com>
Date: Mon, 11 Apr 2022 12:23:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: Juergen Gross <jgross@suse.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-6-luca.fancellu@arm.com>
 <d8c2e194-be59-f7d7-fcc6-9ef7a06ffd1c@suse.com>
 <16C482BB-BC45-4BD3-8357-87AA942F4D14@arm.com>
 <cacbaa1c-8ae8-9314-9364-97e5a53d876b@suse.com>
 <61DEEA58-E570-4FEF-9B71-27316C7F8D7C@arm.com>
 <0a85f239-dbf8-2e06-0158-75a1c1c40a4c@suse.com>
 <DC3522A8-ADA1-4F6A-A3CF-C8095C2F639D@arm.com>
 <e6450fd4-662a-abaa-4b9e-1d8a4ff41962@suse.com>
 <74450613-4B05-4FB7-84F7-A26EAC3CEA20@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <74450613-4B05-4FB7-84F7-A26EAC3CEA20@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0087.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b20e1bd6-6c43-426f-90cd-08da1ba55218
X-MS-TrafficTypeDiagnostic: AM0PR04MB4851:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB48516AA3DB295B0DE07976FCB3EA9@AM0PR04MB4851.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kXWCfjf/Wx8Buo3j2XG8oY+2qe5aW1BsrcwN4i/DqH4rJfFlwP7R5f5Du+tRXqkJy0rw6b3nWKFDlA4vXZYPcCpK1ZLFUPYzKHuxEbQYSemUB4fFekJANhBtUNfMRJDluAI5VGcZ7rBlJsGMYlflczaoifH0tYimtwAfACjnyAXW/nw+R/+LY7ekLfNaEQ/T+T8YK14y0OzfoqlRcnSryP5TBPBKUkz4xOBgQVnhRJNUSO/fH8+iMGy+tTkRwPXE6QzFmiOxKJ3npUyFMaTsgbbFUcrLI/13qVz4YwEoLmGJwMwSo74Qx9SxuXJcEot6GFvlsqhR2ILs5rask36hCWWNjcrzQBzcRkl57drVZaPkkFzGOK5WHsq8KudqUcPbsg8uL4Vtvrlm+3B567h49BOXfDw1XXusl2MRrgMtipun20DRXt3GHOdBKdX24QOSZ+s2FNMP44rhHgedQFpN0m7MqcEvqM9WDJh9t9HgoQxmcOpAj85xnq7OVZWa4vUm9MLBJUsXivAjvcV0QXB4+l3DIFTfsPGMZ4g+PJoZaewYFyPkYkMoAhDnO/MuVn3O0AQnzc+egAUn7M7L3iRGPFXhZAiSfN6vPVt/8BEcqP2kgIvRJu6cGMWfS093IxyQhCxb1XXRRwdPw9RDxYZ5xVvwMN9rnNcn9zDsHGAU48MOnkjAOLZ99fCTa0gB5zVe53s9MfJeKfaMzWNTLu0MjxXFy/y6koSmrpZKTJGrDAWUVJ2gmI57GusH03Ov+/HYlvvXa2Hbz4xQtRFqDmAAAA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(8936002)(6486002)(26005)(7416002)(66574015)(5660300002)(186003)(2906002)(36756003)(31686004)(316002)(508600001)(2616005)(4326008)(66946007)(6916009)(86362001)(8676002)(31696002)(66476007)(66556008)(54906003)(53546011)(6512007)(6506007)(38100700002)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?nHCi+SFjkcM3PySApRWsgckPOF10a6uF9aU3APwUKXKseWTHTMWjf6nUz48m?=
 =?us-ascii?Q?Kd/xZpON904lu/LprIHPt10qkZ4/Bai6mPY4EmATSV+91De7JkARRrK8D5Tk?=
 =?us-ascii?Q?iJH8DUhylAUhYyhax6Ye/0QAnNktgLSwXIna4sp9IjdWgVpCRSr9p5kuvy0R?=
 =?us-ascii?Q?K4Sb4coVHMXQcxM9cymPffKDtKfVyKsB6x0jqkB//FrLTjXo9HJLZ97s6vDj?=
 =?us-ascii?Q?dOqw+rSlJ64JGJ8J7tJC0zOou0G3k5eZ+eZY593EU1aGB2C0nsSy3S8SEgXz?=
 =?us-ascii?Q?vY2jrp41MQFrFqulEhvSMW0Pe6w2tPWbWQ6/C/2/XopOfdOceKV4n7Ujgl6O?=
 =?us-ascii?Q?uExvhrWo2gm2EIcJ6E1guxLlGMLCOka/Wl++/YQW65bu0yWOQLFiQFWZcJUV?=
 =?us-ascii?Q?Yh7fMJPttkZvAJBSkwprtL5Dli2TNGBpxGcArzFEFUvHo94I76IBv8C3IVKC?=
 =?us-ascii?Q?upMLDu36c4nkCaBE67DIzgEp8fDOS1Nfd6t6gYcBMF6bBnwFF8mBbc9l2QVP?=
 =?us-ascii?Q?jolc/qvUR+M+9qhAJrMkXNfTxYML+ttvNeRHa5IYLLdomOl8hRIFey4yOm0E?=
 =?us-ascii?Q?CCo2Qj7p9QguOvgO1d0B5YBrTxQDVk6mUidw/ea0VAL7X4RTuiR+kuuKmH43?=
 =?us-ascii?Q?uI6AbY3z0IEyt8WAUVgv76MMDF+ZOQ92A2v3Jof1USYoNEFtYW3NR1MeK6rk?=
 =?us-ascii?Q?BU0ij9IioW4DtpRxCIOtmB5T1wOzZqFvH1D3iDEGi68Lu8w7AdeMuhPLgder?=
 =?us-ascii?Q?qGNRlEHnqkC0Cj45TCeY7aEUNqbpm+/yu50mPyt/wi/llDP1ADN7ePta1keY?=
 =?us-ascii?Q?i9Y6RgSS95r3qYsVq/c/kzV46iMK0YGUGhhzEp+ooVBdkwV+ryF+6dfKE+zD?=
 =?us-ascii?Q?Q6lhJCE5Iw1QcMA7M5u8LJcatrB430Vhaz/7ItjpHgtR3oNCVkgz5nvYFy4w?=
 =?us-ascii?Q?TNMPelYpGMVLYXWy3ThLBw86H38qyQLZlcuLl4gClJ2m2ljVn4TvWfL/+aRl?=
 =?us-ascii?Q?0JSKf/0h27YWolCv4BZs7Rdhncm96diiimCIwg8f/VuSJUjgbHq+dBD4uSR9?=
 =?us-ascii?Q?rj4u4pp/DHJcIsjicDH5IRTvRKKyUEACTbG1LNUcdB7JBWhWksmY6X9xOkWQ?=
 =?us-ascii?Q?luunwA9KC66ranCo9RsMuLQw+UfTL/F9LH3lRpAsaKBqW01zDDQsUnXriIae?=
 =?us-ascii?Q?sdsz1AOildTN4GaRz5upMFMwNRvrS6o/dh/mVnL/HtLh54bQxUJkcDAZ8rKC?=
 =?us-ascii?Q?34KiZl5DaPDlUlp01xCYaXOhF8Zo+0ZDu7jG1JiyMpmrgqV9Ilh9DklvlbK4?=
 =?us-ascii?Q?KwHL8k279hk4y4gn4xydo98YM5sZUWN1Q3pdZVYCB/0FjWUdt1EX7xovHVsl?=
 =?us-ascii?Q?LtKp0O9z3CbCVMC2I4wjj8HJFHpQl1CYFhtlcWhe9nkBlIeH+M179peM5uaU?=
 =?us-ascii?Q?AKOxH1TcaqwIhMppHsNUYWqc99VKk1IF6IwRFfpAKQqrf35TCStCmNk0jeh6?=
 =?us-ascii?Q?TYSyvljCR75tTMRSnQc3dpLn1cWnNoo7nTJANISC+JiOI9bu9sKQHfyX9FWX?=
 =?us-ascii?Q?uiuUQKclFgCoZ4sWkfkbQ7qL08D9j1IKhOnIieAIfvgUKrLEW6u24msBQV9K?=
 =?us-ascii?Q?hl/FIXN1afluxwFfHkWkrRR9/3B6hhDB7akvt/j6zkulp4IKo/0+bz0qt1tf?=
 =?us-ascii?Q?lca2WhvuOKSWLVk941gubVWfrc6OXFwJGovsSocsynRCh8iWCo26GK7HgMiW?=
 =?us-ascii?Q?RWKxlTe5hA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b20e1bd6-6c43-426f-90cd-08da1ba55218
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:23:28.8023
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z6p4LxrH//9xDkItoaPBpIJ3zcHDCkVIhYV0GpORLDMjBUUEn4DPOCAHPTd8Rk4sbpuEQkeq7it8BPwrP59zbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4851

On 11.04.2022 12:20, Luca Fancellu wrote:
>=20
>=20
>> On 11 Apr 2022, at 10:08, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 11.04.2022 10:54, Luca Fancellu wrote:
>>>> On 8 Apr 2022, at 13:10, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 08.04.2022 13:15, Luca Fancellu wrote:
>>>>>> On 8 Apr 2022, at 11:24, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> On 08.04.2022 11:39, Luca Fancellu wrote:
>>>>>>>> On 8 Apr 2022, at 10:10, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>>>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>>>>>>>> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
>>>>>>>>> /* Per-vCPU buffer size in bytes. 0 to disable. */
>>>>>>>>> uint32_t vmtrace_size;
>>>>>>>>>
>>>>>>>>> + uint32_t cpupool_id;
>>>>>>>>
>>>>>>>> This could do with a comment explaining default behavior. In parti=
cular
>>>>>>>> I wonder what 0 means: Looking at cpupool_destroy() I can't see th=
at it
>>>>>>>> would be impossible to delete pool 0 (but there may of course be
>>>>>>>> reasons elsewhere, e.g. preventing pool 0 to ever go empty) - J=C3=
=BCrgen?
>>>>>>>> Yet if pool 0 can be removed, zero being passed in here should imo=
 not
>>>>>>>> lead to failure of VM creation. Otoh I understand that this would
>>>>>>>> already happen ahead of your change, preventing of which would
>>>>>>>> apparently possible only via passing CPUPOOLID_NONE here.
>>>>>>>
>>>>>>> Pool-0 can=E2=80=99t be emptied because Dom0 is sitting there (the =
patch is modifying
>>>>>>> cpupool_id only for DomUs).
>>>>>>
>>>>>> But we're talking about dom0less as per the subject of the patch her=
e.
>>>>>
>>>>> Domains started using dom0less feature are not privileged and can=E2=
=80=99t do any operation
>>>>> on cpu pools, that=E2=80=99s why I thought about Dom0.
>>>>
>>>> It's all a matter of XSM policy what a domain may or may not be able
>>>> to carry out.
>>>
>>> Yes you are right, however I didn=E2=80=99t see so far this use case wi=
th a domU and the tool stack,
>>> probably because it would need also xenstore etc=E2=80=A6 I=E2=80=99m a=
ware that there is some work going
>>> on to enable it also for dom0less domUs, so my question is:
>>>
>>> Do you see this as a blocker for this patch? Are you ok if I send this =
patch with just the comment
>>> below or in your opinion this patch requires some other work?
>>
>> Agreement looks to be that there should be precautionary code added
>> to prevent the deleting of pool 0. This imo wants to be a prereq
>> change to the one here.
>=20
> Since we have the requirement of having cpu0 in pool-0, I=E2=80=99m think=
ing about a check to don=E2=80=99t allow
> Cpu0 to be removed from pool-0, that will cover also the destroy case bec=
ause we can=E2=80=99t destroy
> a cpupool that is not empty.
>=20
> In your opinion is it ok to proceed with a separate patch as prereq work =
having this change?

Well, I did already say so (see context above).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:23:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:23:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302890.516745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrCy-00081n-Cu; Mon, 11 Apr 2022 10:23:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302890.516745; Mon, 11 Apr 2022 10:23:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrCy-00081g-9y; Mon, 11 Apr 2022 10:23:44 +0000
Received: by outflank-mailman (input) for mailman id 302890;
 Mon, 11 Apr 2022 10:23:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndrCw-00080q-Qb
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:23:42 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrCt-0003af-2y; Mon, 11 Apr 2022 10:23:39 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrCs-0002GI-SS; Mon, 11 Apr 2022 10:23:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=WRbReHH2w9ECMqT3skvkpWAjllZtnyCzBY68JBN2Esk=; b=xIxV4Vv9EsOdUEjbpMg8qSWom+
	ZKD5wkctr6xIGWrVPC7GbdnCA6L2e2tgEhMBmN1kjoriAb4mqUPBXUQN9EnOtN2fHK9uT/WLODyDd
	lVutkSUqs0g4JJWPlJioXnjWSpptTtS3qsxVXxQ86vkPaviV8PadWnvBs/uqKyYq/WXk=;
Message-ID: <dea7a276-867a-df02-8584-0433fd5f3910@xen.org>
Date: Mon, 11 Apr 2022 11:23:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH V4 2/2] xen/arm: Add i.MX lpuart early printk support
To: Michal Orzel <michal.orzel@arm.com>, "Peng Fan (OSS)"
 <peng.fan@oss.nxp.com>, sstabellini@kernel.org, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220408140932.17968-1-peng.fan@oss.nxp.com>
 <20220408140932.17968-3-peng.fan@oss.nxp.com>
 <62e62ea5-0286-7e34-efab-66f0e51afeda@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <62e62ea5-0286-7e34-efab-66f0e51afeda@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 11/04/2022 07:24, Michal Orzel wrote:
> On 08.04.2022 16:09, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>   xen/arch/arm/Kconfig.debug              | 14 +++++++
>>   xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 +++++++++++++++++++++++++
>>   2 files changed, 66 insertions(+)
>>   create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
>>
>> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
>> index 35ccd13273..842d768280 100644
>> --- a/xen/arch/arm/Kconfig.debug
>> +++ b/xen/arch/arm/Kconfig.debug
>> @@ -58,6 +58,16 @@ choice
>>   			This option is preferred over the platform specific
>>   			options; the platform specific options are deprecated
>>   			and will soon be removed.
>> +	config EARLY_UART_CHOICE_IMX_LPUART
>> +		select EARLY_UART_IMX_LPUART
>> +		depends on ARM_64
>> +		bool "Early printk via i.MX LPUART"
>> +		help
>> +			Say Y here if you wish the early printk to direct their
>> +			output to a i.MX LPUART. You can use this option to
>> +			provide the parameters for the i.MX LPUART rather than
>> +			selecting one of the platform specific options below if
>> +			you know the parameters for the port.
>>   	config EARLY_UART_CHOICE_MESON
>>   		select EARLY_UART_MESON
>>   		depends on ARM_64
>> @@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
>>   config EARLY_UART_EXYNOS4210
>>   	select EARLY_PRINTK
>>   	bool
>> +config EARLY_UART_IMX_LPUART
>> +	select EARLY_PRINTK
>> +	bool
>>   config EARLY_UART_MESON
>>   	select EARLY_PRINTK
>>   	bool
>> @@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
>>   	default "debug-8250.inc" if EARLY_UART_8250
>>   	default "debug-cadence.inc" if EARLY_UART_CADENCE
>>   	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
>> +	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
>>   	default "debug-meson.inc" if EARLY_UART_MESON
>>   	default "debug-mvebu.inc" if EARLY_UART_MVEBU
>>   	default "debug-pl011.inc" if EARLY_UART_PL011
>> diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
>> new file mode 100644
>> index 0000000000..f68252da86
>> --- /dev/null
>> +++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
>> @@ -0,0 +1,52 @@
>> +/*
>> + * xen/arch/arm/arm64/debug-imx-lpuart.inc
>> + *
>> + * i.MX8QM specific debug code
>> + *
>> + * Peng Fan <peng.fan@nxp.com>
>> + * Copyright 2022 NXP
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#include <asm/imx-lpuart.h>
>> +
>> +.macro early_uart_init wb wc wd
>> +/* Already initialized in bootloader */
>> +.endm
>> +
> FWICS, early_uart_init call is protected with CONFIG_EARLY_UART_INIT that is set
> only for PL011 UART. So I think there is no need to implement this empty macro,
> unless we want to keep the same macros across the files no matter whether in use or not.
> I think you need to ask Julien.

The call to early_uart_init is indeed protected by #ifdef 
CONFIG_EARLY_UART_INIT. The goal was to avoid having all debug-*.inc to 
implement dummy helper.

So I would prefer if early_uart_init is not implemented for 
debug-imx-lpuart.inc.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:25:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:25:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302902.516759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrEr-0000fR-UF; Mon, 11 Apr 2022 10:25:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302902.516759; Mon, 11 Apr 2022 10:25:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrEr-0000fK-RJ; Mon, 11 Apr 2022 10:25:41 +0000
Received: by outflank-mailman (input) for mailman id 302902;
 Mon, 11 Apr 2022 10:25:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndrEq-0000f4-L5
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:25:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrEo-0003cy-Py; Mon, 11 Apr 2022 10:25:38 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrEo-0002LE-KL; Mon, 11 Apr 2022 10:25:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=XWy0/t4mdQWRKrhAfnIjD/ACRxiFx8Fo3zGHU+yDS5c=; b=MPsEsz8UhmiDr8iZ7qfsejdN0c
	6+zEfFwQsmQO87H4RfhHTibCuTcKWOGY3jYqHtEDzxlbTTlU6OjrGY/LdQ9OCerutBEojLTbE5zHm
	iw/brWKCqS+Jf9eQGx//4vymG0Q1b4WiAwINAwIFJpOuqIr7RkTphs08Z9cmZtiwC+M4=;
Message-ID: <0f18eb04-7b39-da75-fcf4-f765d8ea28b1@xen.org>
Date: Mon, 11 Apr 2022 11:25:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
 <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
 <3217803e-16d5-6e2a-bde7-ff9a1237dd39@suse.com>
 <decf721a-8062-a23f-a810-78fb86a42d1d@xen.org>
 <747017ab-9aa9-b958-8cbf-42c2cc3ffdb1@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <747017ab-9aa9-b958-8cbf-42c2cc3ffdb1@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 11/04/2022 07:13, Jan Beulich wrote:
>>>>> --- a/xen/common/event_channel.c
>>>>> +++ b/xen/common/event_channel.c
>>>>> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>>>>>         unsigned int port;
>>>>>         struct evtchn *chn;
>>>>>     
>>>>> +    /*
>>>>> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
>>>>> +     * vCPU-s they're to be delivered to run on. In order to limit lock
>>>>> +     * contention, check for an empty list prior to acquiring the lock. In the
>>>>> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
>>>>> +     * until the vCPU is migrated (again) to another pCPU.
>>>>> +     */
>>>>
>>>> AFAIU, the downside is another pCPU (and therefore vCPU) will get
>>>> disturbed by the interrupt.
>>>
>>> But only rarely, i.e. in case a race would actually have occurred.
>>
>> Maybe I am too paranoid here. The other side of race is controlled by a
>> domain. So wouldn't it be possible to increase how often the race is hit?
> 
> Yes, of course - just to harm itself.

Are you sure? Wouldn't this also harm the next vCPU running on the pCPU 
because it will get interrupted more often?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:29:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:29:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302906.516770 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrIN-0001bW-D0; Mon, 11 Apr 2022 10:29:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302906.516770; Mon, 11 Apr 2022 10:29:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrIN-0001bP-9y; Mon, 11 Apr 2022 10:29:19 +0000
Received: by outflank-mailman (input) for mailman id 302906;
 Mon, 11 Apr 2022 10:29:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ETZj=UV=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1ndrIM-0001bJ-6V
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:29:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 37ff999a-b982-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 12:29:08 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-6YUzrs5MMLCEGA5iNRMSsQ-1; Mon, 11 Apr 2022 12:29:15 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by DBBPR04MB7676.eurprd04.prod.outlook.com (2603:10a6:10:20e::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:29:13 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa%4]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:29:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37ff999a-b982-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649672956;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=yfThRfML+hr4ye7efofyzOVXZzB8YhPFE89Du6Ougic=;
	b=V9nTPaagE5JfqjWBpKxnSb6LVl/zMFOUYNlKFf92DNx4T3+td304FORQR0rM/Jo5iX5tdL
	RvOZ0q+HTCGICrkwHJqxrI1KumNRBcrRZ6I0ARdvYMMebGnfJjPm3TvSplVApiZiTPcz93
	VTQPsbzv+QiinYVkZpS9wvBPp9yhKdc=
X-MC-Unique: 6YUzrs5MMLCEGA5iNRMSsQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a2X962yLzcbeDF1qYRlTWWAPi0hoGdYtcuong23hc6QgD92DP+Hg2HaMmH9ZNf26Pa5WGvnGJpX/HeWxJLF7o95BkPHxPWSlw8fJ1vor1GljcA708yOMba+ohsDF6Vi+MyPzyPZYeCEfY2JeoDSMD6x64CBw3Q+grByokwRYiE958F3giTpWKdrUl/i0taMdmxTboJW1fZeOlDeFev8XqFIfZtUGd9XDavddP8G3nJLC501nuOvz5z0MjxOexDUXohwybZo/bh65T9Mfy+OUUn6oNu5oJAvYw/1TdXzGAK9GcJq0ubhyKIdy3WcniELNWxGG/PNWJn0xjv35C0R4Lw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yfThRfML+hr4ye7efofyzOVXZzB8YhPFE89Du6Ougic=;
 b=gSV9p529un9FrFomrp/jSYcG7m1feoZuaQaoB4N7eVzp0WXZE9PXSlpf8a6tnX76u/EGry2wQHmvCSWm2x306/arAwMaYNZ3r0LiMpP0ZC1VAZEZjz1+uPvYwv9Oy1IseX56koX59CDEWWagkp8WAqWahjZFFHgfuRm09fH04lQJiFidXisZV6dip9NiOf6hGOE4rbnmfWU/7Kg7SCF0NGnNHlPYWWb9WowgsqhcayoeXU2HyUiN+ArqKB5Gg97ayctIqIZayo71y8FITeBpMvL8LCOl/7rkdu0sU+EKUAfhjyfqHWAV0WjR7HKjNXdJ+zSliZtyVvjtLwrj/KU1kw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: "Luca.Fancellu@arm.com" <Luca.Fancellu@arm.com>, Jan Beulich
	<JBeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>, Juergen Gross <JGross@suse.com>,
	"Bertrand.Marquis@arm.com" <Bertrand.Marquis@arm.com>, "wl@xen.org"
	<wl@xen.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, "Wei.Chen@arm.com"
	<Wei.Chen@arm.com>, "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Index:
 AQHYSyUF7vKDj5+7J0Gv64nYja1AHazluEIAgAArboCAAAYQgIAAjXIAgAPJp4CAACWGgIAAIU6A
Date: Mon, 11 Apr 2022 10:29:12 +0000
Message-ID: <48f1e07cde7001967657b8bc7cc89406a72972e5.camel@suse.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
	 <20220408084517.33082-5-luca.fancellu@arm.com>
	 <93aac581-8105-c8e5-f7c9-fca850667f33@suse.com>
	 <4F1CCE02-DC8C-478C-AFFC-A67290188ECB@arm.com>
	 <511b60be-c6c6-d13a-b9aa-40e67e5a1b1c@suse.com>
	 <alpine.DEB.2.22.394.2204081320210.3066615@ubuntu-linux-20-04-desktop>
	 <1be2f46c-700b-6af1-a74a-d090196c9f5f@suse.com>
	 <CE2F688A-70F2-40C2-8B8F-A3694EF8F395@arm.com>
In-Reply-To: <CE2F688A-70F2-40C2-8B8F-A3694EF8F395@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ba741202-3e6f-4067-6c4a-08da1ba61f49
x-ms-traffictypediagnostic: DBBPR04MB7676:EE_
x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
x-microsoft-antispam-prvs:
 <DBBPR04MB7676686319466BB2D53C10E7C5EA9@DBBPR04MB7676.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 c7qro2BLzbrNNEOXXVvOX3wneCNkxIAPIHBdA744iU8HNclgJuKwa41UzO/WkOLEbYyzjDZc+2gVaXxZ9jBH+ZY/e58/qB1Dmtfpl5uTc8S5Fx3ioFaN6MlYPbEpMewDUWSc0m6KuCTTfx1VpungwvDK/9XcZqA6g0TTWu3C0t3Mol55tSSGDl/giTSJOEKZR673hYRwrQ4c+hQ0qbq9zCRSBzl2dUdiI1BoULBZBcXE3c2mV4BCD+GM0h/FwVdEtReUqvgC+45a1CDngsm89CVPDitvareHdcTKCfkwn56+5RXl5RxowKU3I7mV0oFiCKhZjk/TLIJ3BDzCGCwi/lwVBZrQT46RBxOxcJYP6iLAuKjqk2NQKX5tSFBA2sA1f8AKha+sx52/F+ew9mKduS25+tJHZhQtH0N6c+nCudnVnTDD1Rt4h0qIUcM+lxmP5jiIlXCSJbuuR10YdARVNJfD7f+BPMgzUmt4lP92N8wXKRtfrKF/ZOyR4Q5tGBpKNEbDv1y4bYPzKsPyiPnzSVRxgnRZyvWKON/nMsCPjgFTf0E0HUpCT9sXnGuyJUkJ8hpfY7lwR4vdXbIWl4ex9CMc8kj8MwyioGBwHFQ9t62KlWeMflzq2Ov7B+C+p3z2brBRR3lYfkwHi+SB+k3A05m5vH/IZE2davQouWmodDKSnWNRlLSRhqUQN2GKKjcL348A2hVG1tTVtCntKS3lhpZuWN3UHQX++IaCoCyk3ep/A5mJ0c5esFwyJvoojo4PwJtCcvkdAT6Pm8Tq2XmwPaKHNLB+TFTAUuvSrEVoy6xHQChd8OUl42a0K2Mdr+19
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(71200400001)(54906003)(110136005)(316002)(6486002)(966005)(26005)(38100700002)(2616005)(36756003)(508600001)(2906002)(5660300002)(66446008)(66556008)(76116006)(66476007)(122000001)(64756008)(91956017)(8936002)(8676002)(6636002)(4326008)(99936003)(53546011)(6506007)(6512007)(38070700005)(86362001)(7416002)(66946007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?TzZvRmR4NC8rd0srNFNMTmtXTnJTQks2Mk1WUURFQ1pnWThRYnFhWElWOVVu?=
 =?utf-8?B?L2E1bUYrb01uOEE1akRLUTkrWTg4cy9IaVduSTAwRTROQ3U0RW9MQjdRM3Zi?=
 =?utf-8?B?eVVyQ2dIbkVLbXlRalVBQkEwK3JiaVZFN1FmaUI2NVFHcm5MZGJqZVdJbXdo?=
 =?utf-8?B?UTVQVURybTM0TFRBS2FvK1FKeFl4Y09nV0ZOc0F0RGtEM0V3ZUVlS01ITUdE?=
 =?utf-8?B?ekpkNS9FUi92MmMzWXRGMFdBblZFS0cxMWRFMXYrcVNCbHFXc3k2ZEhUMUpY?=
 =?utf-8?B?QkxScVRXUU9MOTBaY3k5OEk0M2ZuYkZONmRDcG5uc0pGNXRwNDdoOUQzZUdP?=
 =?utf-8?B?UmRuMHpUdWhlZnc5VGlScXFtd1JaTE1sYmtKN0xmekFVMUJnZzdHRVg1NkNq?=
 =?utf-8?B?ZUlUUXIrSklPVEVBRFZNU1NSSEp3TFBHQnpTTHZFRGZibUhZQmhKMkhaYmo4?=
 =?utf-8?B?ejV1cmxMVk4yT2RPcy9YSDd0VkRhNk9WdGRiOG1LbEhQT1NaeFdmblJLbHJR?=
 =?utf-8?B?MDVwbnI4ZVhYYjhoU09DYnBCVlFDVGtGZ2RyVFNMUVU5dmRPNm4wQ1RrcDll?=
 =?utf-8?B?ODJnVnY5M0V4ZW8wMUtxNzBxMnM3U2MybDc1NjZKcWZVdmxRVUljbUYyb0FH?=
 =?utf-8?B?a0RsNmNKWlBqY044VUNjRGtPbGtqbk1tWlczWm5zeFUrRTN6ZHFyaitzVlAx?=
 =?utf-8?B?RnJOSWdKZitkeEx5ejVBSExpdEFQbklmMDIwTGJ3eVpMYjAyRFl3ektSTjZD?=
 =?utf-8?B?d2k2dDJoeXdEbEN3eHhKTlY0N3FtYmtEUGR0dDcxYkVEQ09ubHV2bFNqT2lE?=
 =?utf-8?B?OGpaQ0tCditERFlvZ3VzL3ZNOGtMU3FnY25lUFBMUVF5NS9NMkNyZ3lHODN2?=
 =?utf-8?B?M1lwVkw0WDdwV3JtTXY4ZWtvUm9xbTl2M1hEZHYySDlzdzZuMG1wdmhCY3Rq?=
 =?utf-8?B?d1I5NnhJVFpsOHhCdFFmd2lCRXBza2xLOEZBTlp5bDFEYzVMdkpqWE5IS0Ra?=
 =?utf-8?B?OUFnemhobjlBMFpLZE11dE1rczdTdCtJSXlsOGdmUnhZaEtUSWE0U2x3d29Y?=
 =?utf-8?B?VjVFS09sczJETXkzS1BkUVhMVkpWWnhvSi9adk9LNzczb2MvaVBlbGdNMUdq?=
 =?utf-8?B?MU5XbjNQa2ltSjU3R2tRWm5iTG45YlRHUys4NzExeFFWVnhCODJEdzRFWXM4?=
 =?utf-8?B?R2FHWmhRMGh3aHF5SGRJdUx4ejZ5bFdRd1N1cXFxZXNrNEhseHFVNVRodUtu?=
 =?utf-8?B?Q3ZXQkxZTUEwTkV2OThDZXdzd3ZaUUw2K2k4LzYzN1pVSDFEUXM5Z0tjMlBK?=
 =?utf-8?B?cnFvazF2VkhJdDFRcXA0dmVqekZvV2JwWnRiV1NjeUg0T2R3TllQL2Vkc3lr?=
 =?utf-8?B?KzkxVDVPNGcyR1JtM252U1VkSDI1MHRqeU5Zenp6a2JRUW1uakpxTWhPWWdo?=
 =?utf-8?B?UjIzUTlycGZnV1M2aGpWaXlaOEhMWHdPeVlKL3Uzd3NaS21xUWlPTDUwVXpQ?=
 =?utf-8?B?ZER4OFJWVEVYdHJ0TjBtK1FUZUJDTU56eVE5SVRBd0M0RGNoTTRsNjZpRUtR?=
 =?utf-8?B?VUVGWUZIbSsyamgxYnVENFRwWjIvdTk5V1U0YWhjMnVWOXdHNEtHb1pMbzh6?=
 =?utf-8?B?ZGRoYmRrSVlnZUNTN2JwUFhJY2x1cTAvZDJrM2tUMFY0M3JBcjZJNDhtWVVn?=
 =?utf-8?B?UjkvVmJrVFR3di9DT0RrUHVHUEZOVExCdk9TL04vTDVWeEx0SFNJSDY1ejZj?=
 =?utf-8?B?T05zV0hSMXlVUkdYdzZxOHJSMFQwakdFK2JSNXNuMjN2MCt3TFB3Mzh3QWZY?=
 =?utf-8?B?NnhQRHhhUkJwYmY3bEFVNEhmZ3ppYlp6UXVtSkcrWnFOSWtpR2lmb1NrN2Fo?=
 =?utf-8?B?bUFFSHErSjl0M2ZZbmx1QlppRUhxSzVxTWdwZU9kRXN3UFk5YmQvVjlYTGJX?=
 =?utf-8?B?RmpEZG1rSUdSeHRhV1Z2bTJDRHBib3c4ZHp6M3gxSE80RGNVaW9xcVJDa2Vo?=
 =?utf-8?B?Y29sWHEybXVJRHVRQTM2WkRsQlVYSm8rSmRnMjlkMWg1VTNWOXYwVkt0emRD?=
 =?utf-8?B?UlhURlUrMzFwWWtIUW13S1BtdGxEQUNWMmFRUGJlMkY0NzRBakVjSnJzb0pp?=
 =?utf-8?B?REtFYmNCcTZUTms5dVVzUHVvbWM3WkdhVEpnQlAveTdmSmdzaDVXeUt2RXRC?=
 =?utf-8?B?WFljZGkrakNSZE1YZlZDRFMyVjllQi90dDNQeHFnTVRpTmV6cUxhYjhNcHNG?=
 =?utf-8?B?NTZsOVNDK1BjbjZCOE52RS9uakZpVDlzSFN4MEJkME54KzhFbHAwS0FENHR3?=
 =?utf-8?B?WVdjMTVrUHNCRit6dUdrcVhpdG9GNXg5VGVsRzQ2QUZyMzBLVEd0dz09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-extpEdLskcwa37ps4Brb"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba741202-3e6f-4067-6c4a-08da1ba61f49
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 10:29:12.7429
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YW+RfT4bV09naFEchoL0gWB2LDTKgybW80wEBcm63Qv7XGNkoGawr4+OvOtZidPaE0jgk8DlVfxI5YdTtQE5ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7676

--=-extpEdLskcwa37ps4Brb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2022-04-11 at 08:29 +0000, Luca Fancellu wrote:
> > On 11 Apr 2022, at 07:15, Jan Beulich <jbeulich@suse.com> wrote:
> > On 08.04.2022 22:25, Stefano Stabellini wrote:
> > > In my opinion it is best if the maintenance of boot_cpupools.c
> > > falls
> > > under "CPU POOLS". Luca, you can retain my reviewed-by when you
> > > add
> > > the change to MAINTAINERS or rename the file.
> >=20
> > Yet even then, with cpupools.c living in sched/, ...
> >=20
> > > I don't have an opinion if it should be called
> > > xen/common/boot_cpupools.c or xen/common/boot-cpupools.c
> > >=20
> >=20
> > ... this one may want living there are well.
>=20
> Yes I agree with you all, I will rename it to xen/common/sched/boot-
> cpupool.c
> and add it in MAINTAINERS.
>=20
FWIW, I agree as well. With something like this, IMO:

CPU POOLS
M:      Juergen Gross <jgross@suse.com>
M:      Dario Faggioli <dfaggioli@suse.com>
S:      Supported
F:      xen/common/sched/*cpupool.c

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-extpEdLskcwa37ps4Brb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJUAvcACgkQFkJ4iaW4
c+60PBAA6eZq/y3cul+tPOjn79ntoQdxX0CZRF46XT6E6JYhnm7aHDfo/wf2QDnG
EYst389FnCtOM9SwJeBKvW7S8zNGsBKzF9YkxDY3C/R9gq+sL4HToHzJPni06XHG
4x2/YVBf+TbR1MasjvmXni6cD6lxD+78KPp/+GulLIZpL6T2MbQqLgIL1/Qz2Hey
O6u4FHZ7U3vuPNHU1d/MkjyCr/1IUis29sn40krWi419ra2Kwoo3mN6ze/9tfP+7
HZXNGZ5VipAGMtMgNAyizyL1bIw5kV936zBDuywA4CIs93TKLZJ+Nn4X3fdqJv0f
juP6CCEejaJU1EDRCkH9arDM/A3huosybrg5DalyAeCqt9NRFTZmhg/TQkGXV1wB
8mcduGxcAQEVnwzJMb5uXh3HjDvVgFSnzeAFNZk1x63LpQyyGZJdsaH9Ki83oV2W
VuuE8wGcmBMZjGmGwf4i5EaAB/DhA4//eY02SuhSfMTQgXfOKFhzJm4Wz6aXWC6B
LXPDev8XzWe7Hp4219esd7RgXAQ5pqNJHl93ODDkyWDNJppznTxTpt2aMqodNOAK
dMGrTJxhAS4xuKmX/lNc468rdqOUHNwfU2+m4/mcN7GWqmQ5hIv6Fzgygtssf/eb
mivscvjWCcY789G9AT+xDnq2pXL8kheZPpW+ZQAvT8yRy7hLhiU=
=upll
-----END PGP SIGNATURE-----

--=-extpEdLskcwa37ps4Brb--



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:30:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:30:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302909.516781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrJ3-00028F-ME; Mon, 11 Apr 2022 10:30:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302909.516781; Mon, 11 Apr 2022 10:30:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrJ3-000288-JH; Mon, 11 Apr 2022 10:30:01 +0000
Received: by outflank-mailman (input) for mailman id 302909;
 Mon, 11 Apr 2022 10:30:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MKM0=UV=citrix.com=prvs=09308b1b0=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ndrJ2-0001w4-6F
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:30:00 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 555efc93-b982-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 12:29:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 555efc93-b982-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649672998;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=6gaFlHue2/Ijap0jNc6Qz5qymc4QPOqXBkBeWhmpr4c=;
  b=EFvMPmd2sWUpphTg2Aeu+TfFRcm5KA1MeTLW/pCcvYYuMQ2uZ8j9x9Im
   cvVIPrqPK0eLHmb52TCjvnnvDZZru+Y1QdCkCniTEQkBwULx22a/GpBeb
   cRtn+m+Rc7xzrQ6QPy/c6/9bWmgPRWv0BOq1fJcKBkBkXtiK3vT/u659f
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68527943
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2E8KRazggUAg5iM37nd6t+fvxirEfRIJ4+MujC+fZmUNrF6WrkUHz
 2cZWDqFM/6MYGKjeYh2atm29U8A7JHRxoUxQQFvqSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02IHhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplkbHqbgYkI6n2uuElCAEHFWZUMatdweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JATR6mPO
 5FxhTxHfk3dcw8TFwgrS61lmum1jXX5dgR6twfAzUYwyzeKl1EguFT3C/LJc9mDXu1JnUKVo
 G3X8mC/CRYfXPSH0Tuf+Xuoj+XStSn6RI4fGrC++vNwxlaUwwQ7ARwNXFq/qNGzi1KyVtxSL
 UAZ4Gwlqq1a3FSiU93VTxC+5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sZi5MbpkqudE7QRQu1
 0SVhJX5CDp3qrqXRHmBsLCOoluaJiw9PWIEIygeQmM4D8LL+d9pyEiVF5A6TfDz3oad9SzML
 y6iiAVkoLQekMox9aCDpkiYhXWGqp7Sd1tgjunIZV6N4gR8bY+jQoWn71nH8PpNRLqkokm9U
 GsswJbHsr1XZX2ZvGnUGbhWQun1jxqQGGeE6WODCaXN4NhEF5SLWYlLqA9zK05yWirvUW+4O
 RSD0e+9CXI6AZdLUUOVS9/qYyjJ5fK5fTgAahwzRoATCqWdjCfdoElTibe4hggBanQEn6AlI
 ou8es2xF3scAqkP5GPoG7ZDiOFwm3lhlDm7qXXHI/OPi+T2WZJoYe1dbAvmgh4RsctoXzk5A
 /4AbpDXmn2zocX1YzXN8J57ELz5BSNTOHwCkOQOLrTrClM/QAkJUqaNqZt8K90Nt/kEzY/go
 yDiMnK0PXKi3BUr3y3RMSs9AF4uNL4ixU8G0dsEYQ7ziyd+O972hErdHrNuFYQaGCVY5accZ
 9EOetmaA+QJTTLC+j8HaoL6opAkfxOu7T9i9QL8CNTjV/aMnzD0x+I=
IronPort-HdrOrdr: A9a23:w07TgqMX8GBUWcBcTu6jsMiBIKoaSvp037By7TEVdfRUGvb2qy
 ncpoV+6faUskdoZJhOo6HiBEDtex7hHP1OkPIs1NWZLWvbUQKTRekIh7cKqAePJ8SKzI5gPN
 BbEpSWZuedMbAk5vyKmjVQWOxQp+VvuJrY49s2ZU0dMD2CRZsQljtENg==
X-IronPort-AV: E=Sophos;i="5.90,251,1643691600"; 
   d="scan'208";a="68527943"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e6pmUTyy3jgcQyA1nmlPi2QZUNjynYv4LssEdB3/hsDmMyCbiqvLnq10RM3AOquaJaFsBnmoNu/F2A4XwqKHSgDSFiXel2XS+T2Lc3T6E1GZAmE7RgtCTz//RwmeBCKiqs0Bn20UhE3OBrlgWVHuzkf8nsGOoK4+2am022rx8zeoSa3yBkosngTLMlmTGCsuCeXUyere/5S7x5aTAe3TObvODYYJLqkIpX8dOht9egFfmjXAuWH+2Q1zDOmosY/CJC+1kL2F4JVVyP9VcRq1w0BXy/0iQ1mgOoMsFCZ/coawR/7K8V7gVzPMdxgPeHlekZrxaFT9L1yDS1dV/ZvdiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q6CTnpQSp1wplXGnglhNQpxSpwnXmSn+VgzCt05rRGs=;
 b=nq36FRpSbxyrKVASzbOHlNUJahbo9CkmYDp7Dio8AMvtB38gbyXIPSdA6SE0fYLZbecOsLAtWtpjLKYLGN93DqsGuuy3Fvxw+1qxmgrWItHtE4DvbuINRYfpj2idhDMuxtQN1LVnPH0+PFKYdEOVDSqjH43Xm6QIIzgW+qFeaSn+RizHd/JzQmzTeybMaBbcLGjwUa0838nea7t5+Id1PAxpUz1ZIekgkeDidOALHhzdJbF+Jwt7wQinRtkAbEd3VAvyj6itZlKTgZ7dQLcgZ/05d1q02uByNmDx06+a+4uzR/CPXsENu6/85ioFO7hRVzmlMrmPDfDkiLO4m4laug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=q6CTnpQSp1wplXGnglhNQpxSpwnXmSn+VgzCt05rRGs=;
 b=DwGlbM11FF/lvUz2BAwUgGgY+LIvM/v+aE5iPhQrGQBbTS9WkFYxf3e/aTkfWrXKgnB2lqp4IM3nP6UvV28K8gDUVSrGAi/8Arb8ZWXSr//XRP02B5oQ3LEzQ3zT5dYuLgtSgCpkvji3bg04eVYqYius6UkrUY3j7tQjUez92Eo=
Date: Mon, 11 Apr 2022 12:29:48 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>, Tamas K Lengyel
	<tamas@tklengyel.com>, Petre Pircalabu <ppircalabu@bitdefender.com>,
	Alexandru Isaila <aisaila@bitdefender.com>
Subject: Re: [PATCH v4] IOMMU/x86: disallow device assignment to PoD guests
Message-ID: <YlQDHONozx9KYnFo@Air-de-Roger>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <db695753-718d-7bc9-3b1a-efd75b0166f9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <db695753-718d-7bc9-3b1a-efd75b0166f9@suse.com>
X-ClientProxiedBy: LO4P265CA0001.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1b92a0a9-8dd1-48be-c7f6-08da1ba63723
X-MS-TrafficTypeDiagnostic: BN6PR03MB2722:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB272213B380307CCD9766DF0E8FEA9@BN6PR03MB2722.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LnEOPkksXU1hZj0PiIfuQwE66n/KOiZmKzOUOlr0QnHCXChMFwuWey92U1htgKonPuAhrMB7/DEiALT1ZdcJeFH6S0+Nq44RyuIOmigGRlfDo9r6owKUHMdbOvMc9AakoUhOSZvzjokWOwFQMDsJWKDrxJLw9jOqyo/aWZsL5RzD/Rsr2ndp7Z8q6VnxiCv9dNTx4nxfpRdmpc1mDA6EaugOH4pPKXddku65507XnEnf72Waja3XFLhavuwk4NU8vk22elmuSa2iHA6y5QWpKib9ghITpi6OjcLTbL8S1BKgGpzKBR8c9JjJYYMtQ03Ha6ZBHbZV+VmGu5a4V4LF3FXMwfN8NCo7ZKnnxChd6WV5X9UnfkiPovwFkgbvSNpvES6nT9hTC2j8zoGEX+KdgtxmKDr7mmewCeYH8wk/mJXKvahwNwiUOjD5sW0XhukmBIwc/1ZlHyEqLSEKbuETHC3E8turCM08cPRRFKE+I0H0UaPCTYd/wOow6MlWC+u2IBgAcbDAcrbQRVgO3u5o0iXdbAgfTjqiUPffvbMCRKVXuWho+mp0khRyk78IGCiO2qgbkpUTwDM+SCqZso/a76jm+3ZowJCWamGfBO8KEvaQ4sZwiYU67a06epJWB0971t+wXPzVsn88BQaWUk7RSQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6916009)(6666004)(9686003)(6506007)(6512007)(86362001)(33716001)(54906003)(6486002)(316002)(508600001)(38100700002)(186003)(26005)(82960400001)(83380400001)(66556008)(66946007)(66476007)(5660300002)(8676002)(4326008)(8936002)(85182001)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGxjcjVrUVVLNWI1SlNSSWx4TUNDYnArMWduNHlqWDRFRmFweCtoNzArNkUx?=
 =?utf-8?B?NXRiZ3VScUJ5ZHVoMEFVRmFOcXA4MmVxWFVkMDcxRnp5SE9BNVBGRHE5L24w?=
 =?utf-8?B?SDlFaVV2R3hhcVJwTUNIV016OU9MMlR4R0YyMnh0YkZINjVHYzluNUJqWFd1?=
 =?utf-8?B?KzNYK1JmbHNiS3N3MVdHLzMrc282S2QxRXowcXNMMEdTbXI3aXZsZWtEUnNC?=
 =?utf-8?B?TElCeGRpWkpML0hQeW1UM0hzaWZEN09FK2hvNmhLdlBQVVJ6dkZMdHc0bmR5?=
 =?utf-8?B?L3lCU2ltSW8wT1VhTlhxZno1YkR0ZWhaL0dpYWl1L0VIdGcyYzAxUTZFcU5q?=
 =?utf-8?B?bFhFblFyWEk5MjZQQUpPQzFYODZiaVJyelcrcnpOa0NhK0tqelMyQTloU2pR?=
 =?utf-8?B?cGxIYXdRVDk4anQ0QzhqTmpLd2RaWXZrSnQzZE9iYW13TmhXRHhWdHZ4S3ZY?=
 =?utf-8?B?b1lnVExsdTQ0eTlkWUZadkhtZzU2OG8wcDdibFJBYnozd3lLbEJSaGlOZit4?=
 =?utf-8?B?TTlmN2ZEVmpCd1g2Q1NWSDdSMXE4S3ExN0FBV0x0cWhQL24yYk5NN25wZVls?=
 =?utf-8?B?cCt6NVdZd1NJT3FKWEhCU1NET2djVWZkbXZJd2RNNmdTREN0RVlzdTR5TUI3?=
 =?utf-8?B?aEdRRlNTQktUNjdXa1I4N2xWSlRVZFlBM20wRGw4aW9oNHhDUEtmVWQxUWEw?=
 =?utf-8?B?Wlh2SU9oazM4S3JtaU44eWMxWVJVZnA4NDNQN2JKZks3SnUxVWFvaUpGVFU1?=
 =?utf-8?B?VmFiZkdyajROY0lUU1o3VFUyRk5yanBlRTBrcXdPTGlUQTlScXJsVjdEeWQ4?=
 =?utf-8?B?Uy9lTlJwSGsyTGNVaGpraFJDeHBFWlhkcm9Ob05LeHNVNHg2WXFlTkV1TU00?=
 =?utf-8?B?UndoVGRvZm9iTDBqbkxodHFBNXpuVUx2VjBzNnE4Q3RGWnQwZmhXK1ZvKzM2?=
 =?utf-8?B?MzdrSzkwS2tKUkNFV0pYSmYzdGt3dng0Zmtvd1AzZGllbmRkNVZkNGVMajc4?=
 =?utf-8?B?aTVmc3RaajM3aTFyeVdVV1I5MUs1S0VLQUkvZkt1VWd0OHFmcHZFaVFnWmI1?=
 =?utf-8?B?TlRHaUpjNEtnY0pkcUluZGdYN2JiaStYRmNYanFDYy9lSGt2NTdUV2VXdk1S?=
 =?utf-8?B?eHBwZlR5bGt1dXNRZW9rTzR0VWxWODl1TnM1aEJZc0FWcDlNYVlKTThpeS9H?=
 =?utf-8?B?TElnbUZXbDc2RGNHSk5YWHhEM3FHanZ5Slo2N1JvK2pKdFJWOUNxMlBKVk5G?=
 =?utf-8?B?a3pYSEV4NWk2QlJyZ0dlb2o3bFNUdERBSzFheGZYcmN3VVp6REE3T1lDL080?=
 =?utf-8?B?VGpkMzhmaUtqTXNHODFKcGxvMk9GZFROelJEdTQzNmx1NjcxdFEzc3VxTHdm?=
 =?utf-8?B?WGRJRC9IVnB1a0YyMXp6cmhYbFRkbnBzekhmY1YzK2tzbmdvMFZUbnYzM1dK?=
 =?utf-8?B?VnM3Y0xESjBBN2ZBQ0ZybjZHTnRaUHhmRDZJY200bXpFLzBkb0JTbjlxOFVu?=
 =?utf-8?B?bmluQy9Ta0VwaS9UVGErT0JFMlI5dEd0b2dKSnRCZ1pFUDcrMThxejYzSDFl?=
 =?utf-8?B?R0dOcUJqWHNJN0l3eklGZ3pGTWpaYmpha3FudzFFQ1g1Q01VQWJwcUdFLzl6?=
 =?utf-8?B?MUJWYkhJdGh3dy9lSE1kVXJPNUhYQ01kQk5CblpRTTdzV09UK2M3MXFoQ2J0?=
 =?utf-8?B?UExwVnc5U0RYR0RvSnJLVDlGZFZveXNTZ2FOZ1VmYzI4S3dxYjlodFQ0RUNk?=
 =?utf-8?B?WVZvd2ZQQnorcnI0OXdFZUpGYmV1RlJNS09YUTljM1J0YVNIc1l4Q3RTWHpG?=
 =?utf-8?B?T2x2dTdPSzBTalFMMDhkKzVrSVNDdU8rU0diQWI0bzFSVmkyMVRTM2ZGMDRw?=
 =?utf-8?B?UVlHUzBqN0NXV25ldHpHV0o3RCtXcTJMb0ZhRmw5YkxZWHZjL29RRHVuejdQ?=
 =?utf-8?B?VmQ2S0E1NWpQMGNrd3BMT3cvRlhnbmJrV0ZPNjR1MHBNNWI5S1FlWDRXelZ0?=
 =?utf-8?B?S2N0NnB5L2F5cEoxMEZzZTFZWXNvWXN6dnNwVWp3T05yK2JTelJQUGM1RGZ6?=
 =?utf-8?B?NTlLdFAvQXZHOW5nTHVpN0xRMUNONVVvd1lYQm01Y2pTeDZtZWNZQXpuRytp?=
 =?utf-8?B?bjB5Q3MvZklCNklZMFA4Uy83OW52WXcwaGVsQXlKQWFPYjJPRUFKT2hxYkRz?=
 =?utf-8?B?RmU3MlBQSmlCN1cramFmVjV3L3dENjFiVTI3ZTRQeEFNTGk3MjZXS2w0eHY0?=
 =?utf-8?B?NG9oQzNUanNHMkpsZE5YdDdCb3NtL2UvbDVobnBaWHFmd3liYzBlYUJzaWRx?=
 =?utf-8?B?UFJHcmw2R1VPL3d1dm1vQ2svTkNoK1ZyUHprUmdsdWlkUis0dndUVDNFa1Nu?=
 =?utf-8?Q?QcPSNzCOtmIJlXEM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b92a0a9-8dd1-48be-c7f6-08da1ba63723
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:29:53.2783
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EjTDS9m5wwsdSVFlCj822rwWMyftQJbP3JYSi6vUN1p41mqhoxrGIiFpH2XGUdudzOrS8QM/4GeTcwOskQ1j9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2722
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:47:46AM +0200, Jan Beulich wrote:
> While it is okay for IOMMU page tables to be set up for guests starting
> in PoD mode, actual device assignment may only occur once all PoD
> entries have been removed from the P2M. So far this was enforced only
> for boot-time assignment, and only in the tool stack.
> 
> Also use the new function to replace p2m_pod_entry_count(): Its unlocked
> access to p2m->pod.entry_count wasn't really okay (irrespective of the
> result being stale by the time the caller gets to see it). Nor was the
> use of that function in line with the immediately preceding comment: A
> PoD guest isn't just one with a non-zero entry count, but also one with
> a non-empty cache (e.g. prior to actually launching the guest).
> 
> To allow the tool stack to see a consistent snapshot of PoD state, move
> the tail of XENMEM_{get,set}_pod_target handling into a function, adding
> proper locking there.
> 
> In libxl take the liberty to use the new local variable r also for a
> pre-existing call into libxc.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Just one comment below.

> ---
> If p2m->pod.entry_count == p2m->pod.count it is in principle possible to
> permit device assignment by actively resolving all remaining PoD entries.
> 
> Initially I thought this was introduced by f89f555827a6 ("remove late
> (on-demand) construction of IOMMU page tables"), but without
> arch_iommu_use_permitted() checking for PoD I think the issue has been
> there before that.
> ---
> v4: Drop tool stack side change (superseded by 07449ecfa425). Extend VM
>     event related paragraph of description.
> v3: In p2m_pod_set_mem_target() move check down.
> v2: New.
> 
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -20,6 +20,7 @@
>   */
>  
>  #include <xen/event.h>
> +#include <xen/iocap.h>
>  #include <xen/ioreq.h>
>  #include <xen/mm.h>
>  #include <xen/sched.h>
> @@ -360,7 +361,10 @@ p2m_pod_set_mem_target(struct domain *d,
>  
>      ASSERT( pod_target >= p2m->pod.count );
>  
> -    ret = p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/);
> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
> +        ret = -ENOTEMPTY;

ENOTEMPTY seems weird here.  I think the reasoning is that the set of
passthrough devices is not empty? IMO it's confusing as the function
itself is related to buffer management, so returning ENOTEMPTY could
be confused with some other condition.

Might be less ambiguous to use EXDEV.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:30:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:30:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302912.516793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrJW-0003RH-4j; Mon, 11 Apr 2022 10:30:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302912.516793; Mon, 11 Apr 2022 10:30:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrJW-0003RA-0c; Mon, 11 Apr 2022 10:30:30 +0000
Received: by outflank-mailman (input) for mailman id 302912;
 Mon, 11 Apr 2022 10:30:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R/O6=UV=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ndrJU-0001w4-Be
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:30:28 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on060c.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::60c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 66bf093a-b982-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 12:30:26 +0200 (CEST)
Received: from AS9PR0301CA0033.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::20) by PAXPR08MB7645.eurprd08.prod.outlook.com
 (2603:10a6:102:240::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 11 Apr
 2022 10:30:20 +0000
Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:469:cafe::28) by AS9PR0301CA0033.outlook.office365.com
 (2603:10a6:20b:469::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 10:30:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 10:30:19 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Mon, 11 Apr 2022 10:30:18 +0000
Received: from 2b38f63b04e9.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F52459F0-C8B3-4E88-86A1-A7F01B4DE102.1; 
 Mon, 11 Apr 2022 10:30:12 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b38f63b04e9.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 10:30:12 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by HE1PR08MB2794.eurprd08.prod.outlook.com (2603:10a6:7:31::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:30:08 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::8cab:4b29:9cb1:580a%4]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:30:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66bf093a-b982-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fAyjsZx5cmju+dituP6BVFgtIbgbazbp+jdCt1AZX04=;
 b=yGS8qwBIwGEkSIsB/DHjEGW7OA3hs5+Uazl6dIaIUWtTTVB8o4uMXNBo/EkNSJgxyyk0MZVUL7LAsz90DN7JpykgjaVt1pu7y0pxa1A9ydIDg2RdFbPIGldym6E7J0TKnjALDetctPWN5I+AkD/OUbAnnp5eyJfFp94qijYnyGs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XuiZUlfueD5MP8XYQWU3QMllTY7DiKEEhbzIQwphQ1pcCkaIHVSQWpwC3DxbddkRUD929vX0A/Sp6F4bVnX1vPEwfJ2sZD9I3CeL929U3E0bSRgPTD25KMXgYcalh/FsQEJv9jrBWA+4JO8xPTU8E7bw8y0YQYxh/udN4BC3wSJ6ooPDaaMq5ZliD6R0j2/8wx03/MFh5Ayylr98xPSOrEaUTLJxUov2ZzVm1kDbqXodjYar9Z5hzXQeKL+h0ynQQopGZBcEcDvUpluWyInIM4WyL9iqgPbaL2u3gnwI5h73LTe1NEODW3BwcjYbJZJBjlS3n8axbg5P4vUQz3mRQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fAyjsZx5cmju+dituP6BVFgtIbgbazbp+jdCt1AZX04=;
 b=QldxOjqShHHyzjIYl4nwXBZI5Xp43xZE8UcZ5N3KGWOUM7SITP5XwAU3XY2Orf6NxIUgx12/t5XUTdYmCV3NWEvwf3aGlOLoTJ062YEdgsbI1uDaTyLKPnp9lsfIgjbj2Y653uzIobJ/D8sPanehYjBCW9rY+7CDQxB7mA6q/RAdKM3tcB3cdg2D4wl3qAsq5nkPYc7pl6gL7eAwDLuO6+HQOrFw19hGhdkSEaEdN9gENgqDaabXCLUsn3ORtxjvlG+opBEAeWOclAMB+R+CJQy0idtxbtFVM/Mkwj7koDSaV5B7AWBAB9looiEKIXf0b3I3yPhUe8ohG2sc7U7jBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fAyjsZx5cmju+dituP6BVFgtIbgbazbp+jdCt1AZX04=;
 b=yGS8qwBIwGEkSIsB/DHjEGW7OA3hs5+Uazl6dIaIUWtTTVB8o4uMXNBo/EkNSJgxyyk0MZVUL7LAsz90DN7JpykgjaVt1pu7y0pxa1A9ydIDg2RdFbPIGldym6E7J0TKnjALDetctPWN5I+AkD/OUbAnnp5eyJfFp94qijYnyGs=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	"community.manager@xenproject.org" <community.manager@xenproject.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: RE: Ping: [PATCH v4 1/8] x86/boot: make "vga=current" work with
 graphics modes
Thread-Topic: Ping: [PATCH v4 1/8] x86/boot: make "vga=current" work with
 graphics modes
Thread-Index:
 AQHYROPtcJBl4i95okO8HDmAStvYzazhCTMAgAHwwACAB49yAIAAA21AgAADKoCAAABk4A==
Date: Mon, 11 Apr 2022 10:30:07 +0000
Message-ID:
 <PA4PR08MB6253B284F858ABC28613E98E92EA9@PA4PR08MB6253.eurprd08.prod.outlook.com>
References: <819eb552-d49d-e98a-9524-8d30c1b93908@suse.com>
 <3fb7f3e9-a6cf-4f8e-1141-100848b1bdd0@suse.com>
 <YkwBpKcyrnuXyNPa@Air-de-Roger>
 <65d3068b-fde5-951b-9a60-4ba1dcd89a49@suse.com>
 <01992254-1a4d-850d-78c5-7e4ee738cffe@suse.com>
 <PA4PR08MB6253CEB380333171F2829F7492EA9@PA4PR08MB6253.eurprd08.prod.outlook.com>
 <c940dfcc-322d-afa6-7f30-bc0a1b981581@suse.com>
In-Reply-To: <c940dfcc-322d-afa6-7f30-bc0a1b981581@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 99F60CF210479742A28BE1764F929C3A.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 0c82e923-02e0-474f-0acc-08da1ba646e6
x-ms-traffictypediagnostic:
	HE1PR08MB2794:EE_|VE1EUR03FT007:EE_|PAXPR08MB7645:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB76457501E333158E3CD4DD0D92EA9@PAXPR08MB7645.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 BRVRVl3teQzDlKBY/B9ky/wfXU4O6M+aiH/fCaN4qX+BuySgluKllZxiY96qCdlUKgoiZuddPkfMS+RcpqCAmhDT/zRuH32xogjfqBb00G7Ok/+Lxi4XoD5b9wBpV6SwvePGrsW9DFcje/SsECv/9rI2GrkBTEj73pgpwVvCEsGJsXqS4rt/SkfTOQDbd/BOMPUUZSFo4ndnO43qrJ2Kg84E8UmP+kFOA8HTq62RjODbLeluNPlr5wBP1RrFz+skktPLHwAZXmlBOkV8Nc7Upa+AfS8PRjqx37nkfuaKN2MuzWLrpaYSwhyZ7eQm3PTXbhb9KZ0+/6J79ID8qQEYADlCysgC9EQRBOyMzqCybaVWGAk8wOOLi+HcjxAlmpgUhxmRm7Ynjm0rQzdBXoyitH4m4rSiLegsfgKuL0zdcT0GyPyjyWcjL56wL1TAkMexO0y/r442ELdPAvaddG8aq8++sahQ3yBJK+uuB/RRDaKC5uSqxRQDT9zz/VTjH6vkPvj96cUaDehrsVIfI6sSTQVrKgfW0WWIRmvLfCbHtQuufDDdEgAp4JbgdRxkrgm0P1tdIjZ3DMfo5p6QEZPZJQjyXgBgT/q0ldYDb7pEuGdkb5G4MoYP6znHxg7SCiEWkwQYREIo77t+MExgjqJmXOtbYT41ZakW/IEkrtqbt5/d2SorFm6Jp90x5vwwcjvENMTwPYZ7RIaRZEqpLRWUKQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(66946007)(5660300002)(55016003)(122000001)(4744005)(8936002)(52536014)(66446008)(64756008)(86362001)(2906002)(38100700002)(38070700005)(7696005)(26005)(66556008)(4326008)(66476007)(186003)(8676002)(83380400001)(9686003)(6506007)(316002)(508600001)(54906003)(6916009)(71200400001)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2794
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f897e951-9568-4932-f71a-08da1ba64070
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	y1KYsFEFA8bCknmAA1cbrDnhMA+dIJLGz+A0AcHyN7ig4cU3IkicJdkAJt5NwpZmfDgUrLLsqYP5OmK3JW805itkfxYmU6thRN8MZmXa+rKIonbIOuVd6j1MAr8YQFwy+Hyknd9kaWjRD1JQ/n1v9IgQWyeBfsz7W5j8aYBr+a/rmr4tuDMAwiezKzHYolXtez9CxN25ZZSdGzxZAuq6CXVocQh9KVRTl3SnF4EnvEqj+iCoIcoOOkdsK+1JhzLUhWC86YFkTER+K7RquZLadwHpHcsp6n8y4bIo+YVGVi4ahT82uX+InANCFddk+h8gyAUfUy+TfueJKPqKcuwnmHqTac9IxqRHhwc7yBLoi8PzvdbR8GblYW3yFKC8Zf2vorrDPONmyCNxz7dJJ6+CmyvG9pRGM1VlGgFjCnmitqHWLGjDpO0PVWLRZiqicbiJVZ4fcaVD5Di49/AlX7Td5+FD4ncTjV4Tn4rYc5x8S3E1xiPvql4ArGxaKqmY1/T9f5kkVfvC+DiGkvmUhyMIGWt2MH4A20lOMxaJ9ogffLqEXYvHSocRBj4A35ZN/gX6OwdbMpf05T7j5+nQd+tPEGLJDG6dzw1acEc7C0DH9uf6FRjmme3LXkGbSL2qLZQi68oefcLX0XT1+GmLyQeoiTrZcBthqqqckTd4W+ryP/OwytuhbuLXmGXUbOucpMdb
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(47076005)(8676002)(336012)(508600001)(2906002)(83380400001)(33656002)(5660300002)(107886003)(356005)(86362001)(7696005)(6506007)(52536014)(26005)(82310400005)(186003)(8936002)(54906003)(4744005)(9686003)(40460700003)(6862004)(55016003)(36860700001)(81166007)(316002)(70586007)(4326008)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:30:19.3411
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c82e923-02e0-474f-0acc-08da1ba646e6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7645

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPiBTaW5jZSB5b3UgYWxzbyBtZW50aW9uZWQgdGhl
IGNoYW5nZWxvZyBlbnRyeSwgSSB3aWxsIHRha2UgYSBub3RlIG9mIHRoaXMNCj4gPiBzZXJpZXMg
YW5kIHdlIGNhbiBoYXZlIGEgZGlzY3Vzc2lvbiBhYm91dCBhZGRpbmcgaXQgd2hlbiB3ZSBkbyB0
aGUNCj4gPiBuZXh0IFhlbiByZWxlYXNlICg0LjE3KS4gV291bGQgdGhhdCBzb3VuZCBvayB3aXRo
IHlvdT8NCj4gDQo+ICJBZGRpbmcgaXQiIHdoZXJlPyBNYXliZSB5b3UgbWVhbiB0byB0aGUgcmVs
ZWFzZSBub3RlcywgYnV0IHRoYXQncyBub3QNCj4gZW50aXJlbHkgY2xlYXIuDQoNClllYWgsIEkg
bWVhbnQgdGhlIHJlbGVhc2Ugbm90ZXMuIFRoYW5rcyBmb3IgcG9pbnRpbmcgb3V0IHRoYXQgSSBk
aWQgbm90IHVzZQ0KYWNjdXJhdGUgd29yZGluZy4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0K
PiANCj4gSmFuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:31:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:31:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302917.516804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrK4-00043y-Dj; Mon, 11 Apr 2022 10:31:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302917.516804; Mon, 11 Apr 2022 10:31:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrK4-00043r-A9; Mon, 11 Apr 2022 10:31:04 +0000
Received: by outflank-mailman (input) for mailman id 302917;
 Mon, 11 Apr 2022 10:31:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndrK3-00043K-Pe; Mon, 11 Apr 2022 10:31:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndrK3-0003jf-MK; Mon, 11 Apr 2022 10:31:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndrK3-0004iz-BH; Mon, 11 Apr 2022 10:31:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndrK3-0006NL-As; Mon, 11 Apr 2022 10:31:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OQV25BSQnmLVsNB7K5FIRVxhSP+AOwFsb8pLBMtxWyo=; b=asOGj2xf+sfnciTPrh+qDOBusH
	2qgEXKf0rUFaQ7vlsCraN9OGlTmMdqofN/FL1F+umg5tTeGAFrmBmOKutQkk9zCPBO+onWglje7pE
	Y239yGwEcsfodilerDK8MSpB2QeBZmJ/WwUfKoQakB5ptB3whfqJHYIw35wD2DmwD1R8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169296-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169296: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=c11fb2132f313b9aa25ad7c57becc72923623874
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 10:31:03 +0000

flight 169296 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169296/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              c11fb2132f313b9aa25ad7c57becc72923623874
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  640 days
Failing since        151818  2020-07-11 04:18:52 Z  639 days  621 attempts
Testing same since   169254  2022-04-09 04:20:15 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104141 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:31:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:31:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302920.516815 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrK5-0004KG-MC; Mon, 11 Apr 2022 10:31:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302920.516815; Mon, 11 Apr 2022 10:31:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrK5-0004K7-Ix; Mon, 11 Apr 2022 10:31:05 +0000
Received: by outflank-mailman (input) for mailman id 302920;
 Mon, 11 Apr 2022 10:31:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndrK4-00043h-39
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:31:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrK3-0003ji-Nx; Mon, 11 Apr 2022 10:31:03 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrK3-0002d5-HH; Mon, 11 Apr 2022 10:31:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=wS/mm9pvmGnWCtk8wJsZENRQAA/10j4l8KJLd4hTllY=; b=UayqfZmTCQwMlqNehx5RlL+12h
	VoyvUXeL76uUrjPYm8QPsqtvRx8TBNiIzmBUnPJ4860Bf39P5WN7n3dum9QtjIZ4AqII/rjEDZDRz
	EXrUOL8igTbCnNFw2n80za2bFKpfFqElUWlhlbWqTKyqYSLKYWfkBbgWQgh/3g7lHZHA=;
Message-ID: <346f23d6-14e1-17b8-dc7d-d378ff77f28b@xen.org>
Date: Mon, 11 Apr 2022 11:31:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v5 0/2] xen: Linker scripts synchronization
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220411070300.77380-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220411070300.77380-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 11/04/2022 08:02, Michal Orzel wrote:
> This patch series aims to do the first step towards linker scripts
> synchronization. Linker scripts for arm and x86 share a lot of common
> sections and in order to make the process of changing/improving/syncing
> them, these sections shall be defined in just one place.
> 
> The first patch creates an empty header file xen.lds.h to store the
> constructs mutual to both x86 and arm linker scripts. It also includes
> this header in the scripts.
> 
> The second patch populates xen.lds.h with the first portion of common
> macros and replaces the original contructs with these helpers.
> 
> Michal Orzel (2):
>    xen: Introduce a header to store common linker scripts content
>    xen: Populate xen.lds.h and make use of its macros

I have committed the two patches.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:43:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:43:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302941.516834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrW4-0006e5-3Q; Mon, 11 Apr 2022 10:43:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302941.516834; Mon, 11 Apr 2022 10:43:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrW4-0006dy-0O; Mon, 11 Apr 2022 10:43:28 +0000
Received: by outflank-mailman (input) for mailman id 302941;
 Mon, 11 Apr 2022 10:43:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndrW2-0006dq-69
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:43:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 36783c60-b984-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 12:43:24 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-OE5xciMROK6ADsM-jihbIg-1; Mon, 11 Apr 2022 12:43:21 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8855.eurprd04.prod.outlook.com (2603:10a6:10:2e2::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:43:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:43:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36783c60-b984-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649673804;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XpMN5faIBDdoTZ+N2AnDDAxfrqiZT2hxFN/QcKjovtk=;
	b=CFpG5jQH0bSMcuW3oj5GsycYjtrFnaQ/N31uhOwiLufut9Y6QRjpojqY/SplMhzRjfn+0i
	d9bt/egp08/6NrHdiwyIVQNnUTpA62AsUvH/4RJvgjhtE0ksOsaPtbA+XWvIW2qXm4BMB0
	JWAzpzOhzSSKOzmtqQnQA+1H/HXS8bU=
X-MC-Unique: OE5xciMROK6ADsM-jihbIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=odE8mcuVeF11tO7m6VXv2CSf8tKSXwzLFSxNiUJIDDV7GZdvZ6qliJbvqRN7oCpM7+zZ64oT1AvstA/FN4MDWgJ6WJ7RTSqWGKB6vkbemv5XGCwnxwDw1jIZ3Dj+Cpgf0KE+88Hhg5awItdsvHXkDkzO0xrO5XZ74HEIEwSv7A1dD4pZ2qQLSizUPzbXVhiwtvQaJ4Fxk5+V1mvT1x2KOiJDpD2QCXoUMTCFoGaVLXljlYG+lV+CdGy1GvN7tB8HkrmKrbwR5f4hVK8czQi8uqNTA/U2vmV+ANayLlAbEXlgS21S9yvVMu52vAe4ULg3mEUdCnUQSx/FUMbRoYJTlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iAxyiVj8LVywmrEPgCwuwNZvY6So3i6UhSSuXp9jBKU=;
 b=Y5/SmrSMMyk1E7rrIsBqvLbnBi1yQTEwTXa/fEnyrgDnsxTa6n/ZRwsdg/4aWTW0RIGG1wtITp5RLCTtOAzW9DtN92zyeIN3SZ7QIhd5Wr6HU9ZsjKKY6l1Zvn0m0IWdVNs710r4iLbHiKs3t0XE7An9HSEcfXvFhuWCannR0pKGbehyPQ1oEP6uscG3u73gqzZKkJ/XCOvBrOk8SiprtJS8XLuzPymVtKKDgyUv+qi1NZdu9ZZtxr/LpN3Pn2fVBya5VdUT0wGsCzz5wQZ4JwXlys/iFUMrUlq6SWikw1bAflWvYvGySrh50A2UtFuGU39uCH8t/3ePF4jLw5olGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <538ae31a-85d8-6a3f-6d4d-d11e92b3ce70@suse.com>
Date: Mon, 11 Apr 2022 12:43:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v4] IOMMU/x86: disallow device assignment to PoD guests
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <db695753-718d-7bc9-3b1a-efd75b0166f9@suse.com>
 <YlQDHONozx9KYnFo@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlQDHONozx9KYnFo@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0568.eurprd06.prod.outlook.com
 (2603:10a6:20b:485::30) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f1cd5cf1-6f1e-47b1-9a23-08da1ba817b8
X-MS-TrafficTypeDiagnostic: DU2PR04MB8855:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8855C3619304AF16D910778DB3EA9@DU2PR04MB8855.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZcPkhzei8YgbAC0SaVtOfCB4RFDOPPLk7S/LMWYrrOV16OgIw7hoZpANEAk8E1sPvYhBAUDTFcUHvT7nCEaw18HMRftkhbLq7HXma5FCVILrlQ8JJzx5ufRAyc1brt8sJ9U2e6IDZVu0xpFU0xySAjHN+FQBjzmxVcKmDUA+dRLXeQaI0BUEVyPeq9Gt3zR+26n0VtHVM+gd3sIHrUphXmMJ6gbEsS8qHB3Ch5Xk5ru3JIbqU4IItbsGfzXkuVRmYvbnGRhlpEmxLRdjDdTDha+EEJMThODctDFkPekpw6kX6Ipqmecab4gqtLCum+VX0ejLuHE7TewNcGpYd4i2fNiP04/CdGX9iA8Y+9w7qoHx7VsHMWh5h7mqtniDlrSXuduExNiuVMDKZNgWVOxAu4vhb8z70usn2JZT41Z4hcJtQy/NrLQ8WQ9p8kMi5t7IB+SjNBQdnDnEhZCqJzoRWdHfmczcI633ox2XRaBnjBHpwTTU96hk7jPahuocvq7Ul/uAKzN+G0UAGSsuq0GO17dxy1cBXhAccoHtHVgeuGPQbcGuhjmKP1euYxX4V/NILTcbNF3ye3cs0BxB1jCi8me3i+7QV0HcRz55Rrl/I0HOEiRMEhjZaOqlLOjW1kXmpBeemL0Blg3f0DkEgJfEc9s+kseB/9nh1/77KTJSfOgYV9qzXM6i0z1tnPYILUuPFkdJmCI5+cw86mlEU5E6Q8e5zNaj4aJk6yMhD9xu8Tc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(86362001)(83380400001)(6916009)(54906003)(38100700002)(316002)(2616005)(66556008)(66946007)(31696002)(8676002)(4326008)(186003)(508600001)(66476007)(6486002)(6512007)(53546011)(6506007)(8936002)(5660300002)(2906002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3d3j9p9L5Bq4cLJ2AYs8xBnEodqgHFTqbdP750CTceOwyZIGVusESsyGnY2Q?=
 =?us-ascii?Q?7va3Rl0lrhw/AElwh1n18mvueqBY1W6Ye8+pVlR+q57Zpao+/pQh1AvUi+qT?=
 =?us-ascii?Q?fDCXupYGYxlKUqSizQgI/U5Q9uObxrE8ZN5eGq9Oixbrpo+kOjK+acpxei+7?=
 =?us-ascii?Q?drs+n07/QoH7bVT3XlZuPcvOcFupqbkGSqLVdROWd0kUtwJuwg0iyc/RzWlZ?=
 =?us-ascii?Q?BQDATl8ve6fn0SqnJJqQ/mHNCvjMXbwC5clVRpAPRrZue6E9Mqt7AxY1Gq0Q?=
 =?us-ascii?Q?1h6zp6BZ9IE/r5nSpfN1zK2+h05O2wTsxSeh4y7veQuF/FE82r01x7+z4JgF?=
 =?us-ascii?Q?XT9Sx6h2xPYvLFDp8IaDieA8sbKcNetJLG380NTgEvSeur93AkRn1FJGPy9T?=
 =?us-ascii?Q?5egsUwRelAOrUVepibEujJu5tm/brvxlS2UTEtm3IxB+WHizjpj9bKq+IWCd?=
 =?us-ascii?Q?JSYFCQx4ZB8q0nYSh3AtZ0i7bblUGdlRIaY5uLWnM/1krWggGMFEejhoZUzM?=
 =?us-ascii?Q?7IrNdSaMjmGDS/6IcB2dBTp3ufni7nA4VAywmz7xN6luvs0bcGgF44Pqi0BZ?=
 =?us-ascii?Q?ndETWDzEclGwyDYHp6/crpb1XqpbI63NphGVnyiWbY9ejEYgyJufrhMZOUw1?=
 =?us-ascii?Q?A3r4U/g62YhCP7vzup2jIJwxt309dfgD9WzRcv1MzdxinKkZczY8kClyCsPu?=
 =?us-ascii?Q?8M32K5s/nCTJnfcZUmMBOOtg9UhAxFwFNlKC+ygLe3JZeLF+P+yvhRQaiZC1?=
 =?us-ascii?Q?Og74DW5KC5jPMXEttRFCtaWIdBI9Ao8CyGAm8zSDPjMfqKPTrKlKAdfj1tw7?=
 =?us-ascii?Q?k+I2mB9k6JNHl/nvnRTo1YNME+HdRfvSmUiN7576ELcLo/iSGb4MELBVOka+?=
 =?us-ascii?Q?tOJKive4enJ8VAqPzNEwbdG1wRXbGcE2S9jodS2OBjfvVp8CyV4N6DhC2E4B?=
 =?us-ascii?Q?57vQmEalZIV6VvScIDQ0pzhEjCChH9finioCX5TT7ICwy6wOw+b23kRRHJFK?=
 =?us-ascii?Q?TwZnIBWvDJkDKnDGN1Fik31Ktp8PyTPc5sgd1G/kmDvCL6tyP1wTdlC4JP7Y?=
 =?us-ascii?Q?eyju3QSijZrpU0EBdbkWENWOkUGjjWSW+mzfWucuNmIjWpRve0yzL3iwY+Rl?=
 =?us-ascii?Q?FPXMhGb2qwx6eVYGGDCBQNVQ5nG4CaeBMtOkHdB2ItCq+eRivR2mwkRhLqCT?=
 =?us-ascii?Q?WNqAn4sTo0aBZLNUzKBgdBqJfiGwbbbtYF4yf8W2NH9lHm4Eom9Y91baK6vb?=
 =?us-ascii?Q?T9czmKBQkB+6sMoHcUkKNFZc1kJGHQbE3uE/l2B7tRMNqzYhELXTQT1o028H?=
 =?us-ascii?Q?Ke/xdQbvE0A4mqmD0qYg9FjIvPlfv1TxBZ8YJEpdnCx1HuHgPgnlJi+qbTl/?=
 =?us-ascii?Q?dpWVyVMod1pueqCzu5gEUCH+wUWx67+AQNWRuD9gvIcvpkRIV8ycIv1Qvx2J?=
 =?us-ascii?Q?E4jXD+D/c6tPJgvj/quwvI0hpx5SGsyi7BXSis8W25nNZDdG96rYO29Jw4nC?=
 =?us-ascii?Q?nic1FlIZ2g6RECbEN8DOpU1PtBTSa5eyXcXF9E0uEoDFwSlctKHMVSdsq0Qh?=
 =?us-ascii?Q?cZtrillYaJKPKlzPdx2COlpZO5Yt3q2hhUTwf8tbnRMtvJH31M7H3PvbDN1q?=
 =?us-ascii?Q?QUEfd0tHxaoGDkC3FWwBHVUq4WcWKyt1uIJzA+P6/GgY6jZrPvDsB7tD+n3B?=
 =?us-ascii?Q?vhpcldvz/W7ryBpjKC9aaiNdKJV3+6vOA3sj8elUlgKTI/kOnH5PQaeVi2lg?=
 =?us-ascii?Q?xk49MBb/Ig=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1cd5cf1-6f1e-47b1-9a23-08da1ba817b8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:43:19.3713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z8yXh37KvJ2YtihYq9tWCpPMLwp+o7H8CDEKk1TOGQZNLnUHqPYOUA8Ro5mUCZpS++i2Gi33qyLeFxACFmgFUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8855

On 11.04.2022 12:29, Roger Pau Monn=C3=A9 wrote:
> On Mon, Apr 11, 2022 at 11:47:46AM +0200, Jan Beulich wrote:
>> While it is okay for IOMMU page tables to be set up for guests starting
>> in PoD mode, actual device assignment may only occur once all PoD
>> entries have been removed from the P2M. So far this was enforced only
>> for boot-time assignment, and only in the tool stack.
>>
>> Also use the new function to replace p2m_pod_entry_count(): Its unlocked
>> access to p2m->pod.entry_count wasn't really okay (irrespective of the
>> result being stale by the time the caller gets to see it). Nor was the
>> use of that function in line with the immediately preceding comment: A
>> PoD guest isn't just one with a non-zero entry count, but also one with
>> a non-empty cache (e.g. prior to actually launching the guest).
>>
>> To allow the tool stack to see a consistent snapshot of PoD state, move
>> the tail of XENMEM_{get,set}_pod_target handling into a function, adding
>> proper locking there.
>>
>> In libxl take the liberty to use the new local variable r also for a
>> pre-existing call into libxc.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> --- a/xen/arch/x86/mm/p2m-pod.c
>> +++ b/xen/arch/x86/mm/p2m-pod.c
>> @@ -20,6 +20,7 @@
>>   */
>> =20
>>  #include <xen/event.h>
>> +#include <xen/iocap.h>
>>  #include <xen/ioreq.h>
>>  #include <xen/mm.h>
>>  #include <xen/sched.h>
>> @@ -360,7 +361,10 @@ p2m_pod_set_mem_target(struct domain *d,
>> =20
>>      ASSERT( pod_target >=3D p2m->pod.count );
>> =20
>> -    ret =3D p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/)=
;
>> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
>> +        ret =3D -ENOTEMPTY;
>=20
> ENOTEMPTY seems weird here.  I think the reasoning is that the set of
> passthrough devices is not empty?

Yes.

> IMO it's confusing as the function
> itself is related to buffer management, so returning ENOTEMPTY could
> be confused with some other condition.
>=20
> Might be less ambiguous to use EXDEV.

I don't think there's any particularly good error code to use here.
Hence I've tried to pick one that makes some sense, and which isn't
widely used (this latter aspect would be EXDEV slightly less desirable).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:44:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:44:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302948.516861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrXG-0007MO-M5; Mon, 11 Apr 2022 10:44:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302948.516861; Mon, 11 Apr 2022 10:44:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrXG-0007MH-IO; Mon, 11 Apr 2022 10:44:42 +0000
Received: by outflank-mailman (input) for mailman id 302948;
 Mon, 11 Apr 2022 10:44:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/Ogr=UV=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ndrXF-0007M0-Kx
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:44:41 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on0608.outbound.protection.outlook.com
 [2a01:111:f400:fe05::608])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 638e49c4-b984-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 12:44:40 +0200 (CEST)
Received: from AM6P194CA0084.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::25)
 by AM9PR08MB7149.eurprd08.prod.outlook.com (2603:10a6:20b:41e::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:44:33 +0000
Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8f:cafe::a) by AM6P194CA0084.outlook.office365.com
 (2603:10a6:209:8f::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 10:44:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 10:44:32 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Mon, 11 Apr 2022 10:44:32 +0000
Received: from 83ecee2cfd9b.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A4772C56-389D-4C8B-9D2B-E7E948B9D7E5.1; 
 Mon, 11 Apr 2022 10:44:21 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 83ecee2cfd9b.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 10:44:21 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DB8PR08MB5129.eurprd08.prod.outlook.com (2603:10a6:10:ec::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:44:10 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6%4]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:44:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 638e49c4-b984-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=riLwVD1yRfbCuIrn1UcgOF/H503cWqQ0JCUHjRrHc0w=;
 b=ekkzks2wyh/m3IK1yHeoPqVaqgk/BMnBusoQXY54cMRaqrj+yNCk0Ivrx+8r3lcBTcBw3ZPt6mpP5BwVtSptU6zcZ/VmQEs027OP0MOOe9q+BrkjJTW4GWqX880oKoGjQog4xhs01nkP5nZCmo3cXeThX2k9HZUdwu2LKEMh6Uw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fd5c5877aa86e459
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rk8t7pzGemqh82C88xtYwgHVs9167+U2ISeDJkYGSj+xLdwz/v4GLuICJFcrnNKUfISNJiInOVkawzBYAI/nZP3Gq1cb+pkT3L8E0Y3Yjiilfg0z7ruwnNj/w0lxO/zpzCah77wPrg9Qd3KdltLpqhcF+X9QS01+NLxv6Q2WojcZ/W2k8N1qplxw9avwVIw5nHCfDiGueVPI8nGfqWgCDBRDXoR+/ETVEZ2MR2ZFyDRKuCtNo3xHoKM0E7HEWBYZoYzzkd05fEbTAjJllCZOhL43QJ4TiZ8SB38X2UJANG4aSn6MJCR0pJTmvCvAbKcJfejLbRDHNzDme08eapFywA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=riLwVD1yRfbCuIrn1UcgOF/H503cWqQ0JCUHjRrHc0w=;
 b=cP/rbu4W6DvwgLCsu53mlcWbsBMS3AlcZ+K9e1QhLy7cuQ0pMGrc9oe3mWe8MO4A4CQ8fL1JR7+1AF5a2HgYUYO2/ZaXbXb2BWpIq8wZZCJTx3b8EqDKRtCHY2k3eQjGJGs39a54u0IViejgI3SDhmSrQggvdabWQ9OjtG2PeKLFw8CVxm92tU+eoLaB/YGv57Gh1n/o9rmcqRhty4QwwE27vD1FXigQqCW2/0EVkoTBka0mMYRwjALfy1neAYeQmvPp5EB5iuR4xhNm5XH9DyDeUGp0/afotyBgygh54hFNj4gbGJ1+r5opqig/BpwjJeP7ebo6aSaO3niEiSgGCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=riLwVD1yRfbCuIrn1UcgOF/H503cWqQ0JCUHjRrHc0w=;
 b=ekkzks2wyh/m3IK1yHeoPqVaqgk/BMnBusoQXY54cMRaqrj+yNCk0Ivrx+8r3lcBTcBw3ZPt6mpP5BwVtSptU6zcZ/VmQEs027OP0MOOe9q+BrkjJTW4GWqX880oKoGjQog4xhs01nkP5nZCmo3cXeThX2k9HZUdwu2LKEMh6Uw=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
Thread-Topic: [PATCH] xen/evtchn: Add design for static event channel
 signaling for domUs..
Thread-Index: AQHYPsy9JkZghYSHXUuV0Y0fm4T+9azm3KwAgAAMjACAA7tTAA==
Date: Mon, 11 Apr 2022 10:44:09 +0000
Message-ID: <D24074F6-E6CF-440A-9E9B-A10783C273D7@arm.com>
References:
 <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2204081837410.3066615@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204081837410.3066615@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 34e8695c-0728-4f11-5be2-08da1ba8438a
x-ms-traffictypediagnostic:
	DB8PR08MB5129:EE_|AM5EUR03FT029:EE_|AM9PR08MB7149:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB71498433867F1AC3D924459C9DEA9@AM9PR08MB7149.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 GCitnr4dvVFF+41vGhUw4p738G8LxPRMYJYvLNcqaz7p4QM1t7NFwju0du+v1UwumObgfDMCKbB6xv1gAz3FTv8P36w51xGSmq6cZImUJuhPJtcDYN85EOX9tEG8PMM14mVdv4RktT/NU5cOShqo4PobfXUH2+hHdUNHw9lIqMoh1XgZPKtZKxos7/gW8xBT241xOKLKKgvlubm9qFxnquBxWQswdEw4cWZuAIzRYanwwSSD0016zLg/Mla6JG89GDfhqKRwvip5S9rZI7RlTxSZZohDKb7lsELWCqZep3qwI5EXMpn+r38y+LDczLzlZPtSD3byVS5+xpJABVzFCJ+UE4HzH0302PEaEBWP/1Pnu//c6RiyYXkj9U3OCp+dsrHTj4d66AI6Puzaw0dzcLSEkdBC/ZV2tWV2DfWXcIB/eFU9qtTuAB67dookUaXrHtSU82QFU+jJbjLmZ5CPKOWgWJWlVS89qwS5qScrTA/woQUMIewK0Rhxy0Qewh1G8mlHPF/iugmnLOC5tXmwGZCbE+jZIPW5Pv1lpaCVeY7g5mQQg/FjBPXlTHJr+N6d21UvLdJ9OKktNfmRh1UAr73+PS8P+Iu5VBA4gHmW3LvT2StGxpRiSTIcjZ//I3FNe02gppiQbRfnm7P8F4I1FsPK4qUKhH1XCWMYX5dY//IG5w252nYGl1CC7R8x/8UjyRJTD2WZ8r73VSiK4+J7TeXS5w9IhKHCSLQkOsfYB8xN61+gztMqFF27UGM1ouDP
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(64756008)(66556008)(66946007)(66476007)(91956017)(8676002)(26005)(186003)(66446008)(38100700002)(8936002)(5660300002)(2906002)(76116006)(38070700005)(122000001)(83380400001)(6506007)(6512007)(53546011)(86362001)(2616005)(316002)(6486002)(54906003)(6916009)(71200400001)(33656002)(508600001)(36756003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <EF3D983899CA114693D77CE8B4B530E4@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5129
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a2b575a1-410b-4c30-18cf-08da1ba835b1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ppu8W+aB0PFaF1jZbLnTk4TPFv5rHsSa7QLqH883P8H1JWYRX9eM0m6IZnj3vAkdxyTyeSnXrHBH45O9mlglXHgHktD+aX9Tokzr1HR1vyMmVK0z2JkkX8q+/oznHuMa4HcSpHsvK/23Ow7HLbipwHo0GiJbQRSQlny4gYQ4c4ytkGBn4xMz0xlMtdbTpSbSinrW4qPj7w5I6z6Gk2uPaEQYzJU+Wjm/Uf85tqVjWUwkYAhyyeoklIz/F+RjpIyWQ76GRZzJujLL9OTY6vq2dxXk/Ezft57cyQWKsGEw1afLw9eJSx5Fg+0c2duS7vPdvxflVY2kQwYQ4N1Sc4WUso0qfWXaPhnvlE8bTNukwurKIf/nkVSXlnm+H62BhRa9A1qQXkkqo0ydcLWVn7D0MJ2+yBYsOcu0P2BeESU9UeR73KEoWDqRLYc8zPXqFP9fqb+bb91VB4YU9pMEaDymvBP5oZBVdViitULEfr/Z3AVyl3eXkAMkc5tiTLOfPQsP+EaWXfOSH+V4Ss42QMedVXYaEHI2H6XnUketUfaJdnhoY6yaDF95lp4PNAnk7JLlIzCUoo2Jylnc6AYeSXvkG0xI/Pt+osxB6/1vVmpyPHChdEWmhgbsk0MVOo0O2sO9HBf1ST2Ousx6v8pIwJRlvpONTQe9PF0Yf07ncnDJwV3LwLVJWP5umiDro6sOVUa4
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(70206006)(70586007)(40460700003)(4326008)(6486002)(36860700001)(47076005)(6862004)(8676002)(86362001)(2616005)(81166007)(356005)(33656002)(8936002)(54906003)(53546011)(2906002)(508600001)(6506007)(336012)(82310400005)(316002)(6512007)(186003)(26005)(83380400001)(36756003)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:44:32.7161
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 34e8695c-0728-4f11-5be2-08da1ba8438a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7149

SGkgU3RlZmFubywNCg0KPiBPbiA5IEFwciAyMDIyLCBhdCAwMjo0NCwgU3RlZmFubyBTdGFiZWxs
aW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4gDQo+IE9uIEZyaSwgOCBBcHIg
MjAyMiwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4gT24gV2VkLCAyMyBNYXIgMjAyMiwg
UmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4gaW4gZG9tMGxlc3Mgc3lzdGVtLiBUaGlzIHBhdGNoIGlu
dHJvZHVjZSB0aGUgbmV3IGZlYXR1cmUgdG8gc3VwcG9ydCB0aGUNCj4+PiBzaWduYWxpbmcgYmV0
d2VlbiB0d28gZG9tVXMgaW4gZG9tMGxlc3Mgc3lzdGVtLg0KPj4+IA0KPj4+IFNpZ25lZC1vZmYt
Ynk6IFJhaHVsIFNpbmdoIDxyYWh1bC5zaW5naEBhcm0uY29tPg0KPj4+IC0tLQ0KPj4+IGRvY3Mv
ZGVzaWducy9kb20wbGVzcy1ldnRjaG4ubWQgfCA5NiArKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysNCj4+PiAxIGZpbGUgY2hhbmdlZCwgOTYgaW5zZXJ0aW9ucygrKQ0KPj4+IGNyZWF0
ZSBtb2RlIDEwMDY0NCBkb2NzL2Rlc2lnbnMvZG9tMGxlc3MtZXZ0Y2huLm1kDQo+Pj4gDQo+Pj4g
ZGlmZiAtLWdpdCBhL2RvY3MvZGVzaWducy9kb20wbGVzcy1ldnRjaG4ubWQgYi9kb2NzL2Rlc2ln
bnMvZG9tMGxlc3MtZXZ0Y2huLm1kDQo+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+PiBpbmRl
eCAwMDAwMDAwMDAwLi42YTFiN2U4YzIyDQo+Pj4gLS0tIC9kZXYvbnVsbA0KPj4+ICsrKyBiL2Rv
Y3MvZGVzaWducy9kb20wbGVzcy1ldnRjaG4ubWQNCj4+PiBAQCAtMCwwICsxLDk2IEBADQo+Pj4g
KyMgU2lnbmFsaW5nIHN1cHBvcnQgYmV0d2VlbiB0d28gZG9tVXMgb24gZG9tMGxlc3Mgc3lzdGVt
DQo+Pj4gKw0KPj4+ICsjIyBDdXJyZW50IHN0YXRlOuKAr0RyYWZ0IHZlcnNpb24NCj4+PiArDQo+
Pj4gKyMjIFByb3Bvc2VyKHMpOiBSYWh1bCBTaW5naCwgQmVydHJhbmQgTWFycXVpcw0KPj4+ICsN
Cj4+PiArIyMgUHJvYmxlbSBTdGF0ZW1lbnQ6DQo+Pj4gKw0KPj4+ICtUaGUgZ29hbCBvZiB0aGlz
IHdvcmsgaXMgdG8gZGVmaW5lIGEgc2ltcGxlIHNpZ25hbGluZyBzeXN0ZW0gYmV0d2VlbiBYZW4g
Z3Vlc3RzDQo+Pj4gK2luIGRvbTBsZXNzIHN5c3RlbXMuDQo+Pj4gKw0KPj4+ICtJbiBkb20wbGVz
cyBzeXN0ZW0sIHdlIGNhbm5vdCBtYWtlIHVzZSBvZiB4ZW5idXMgYW5kIHhlbnN0b3JlIHRoYXQg
YXJlIHVzZWQgaW4NCj4+PiArbm9ybWFsIHN5c3RlbXMgd2l0aCBkeW5hbWljIFZNcyB0byBjb21t
dW5pY2F0ZSBiZXR3ZWVuIGRvbWFpbnMgYnkgcHJvdmlkaW5nIGENCj4+PiArYnVzIGFic3RyYWN0
aW9uIGZvciBwYXJhdmlydHVhbGl6ZWQgZHJpdmVycy4NCj4+PiArDQo+Pj4gK09uZSBwb3NzaWJs
ZSBzb2x1dGlvbiB0byBpbXBsZW1lbnQgdGhlIHNpZ25hbGluZyBzeXN0ZW0gYmV0d2VlbiBkb21V
cyBpcyBiYXNlZA0KPj4+ICtvbiBldmVudCBjaGFubmVscy4NCj4+IA0KPj4gSSBzdWdnZXN0IHRv
IHJld29yZCB0aGlzIGFzIGZvbGxvd3M6DQo+PiANCj4+IC0tLQ0KPj4gRG9tMGxlc3MgZ3Vlc3Rz
IHdvdWxkIGJlbmVmaXQgZnJvbSBhIHN0YXRpY2FsbHktZGVmaW5lZCBtZW1vcnkgc2hhcmluZw0K
Pj4gYW5kIHNpZ25hbGx5IHN5c3RlbSBmb3IgY29tbXVuaWNhdGlvbi4gT25lIHRoYXQgd291bGQg
YmUgaW1tZWRpYXRlbHkNCj4+IGF2YWlsYWJsZSBhdCBib290IHdpdGhvdXQgYW55IG5lZWQgZm9y
IGR5bmFtaWMgY29uZmlndXJhdGlvbnMuDQo+PiANCj4+IEluIGVtYmVkZGVkIGEgZ3JlYXQgdmFy
aWV0eSBvZiBndWVzdCBvcGVyYXRpbmcgc3lzdGVtIGtlcm5lbHMgZXhpc3QsDQo+PiBtYW55IG9m
IHdoaWNoIGRvbid0IGhhdmUgc3VwcG9ydCBmb3IgeGVuc3RvcmUsIGdyYW50IHRhYmxlIG9yIG90
aGVyDQo+PiBjb21wbGV4IGRyaXZlcnMuIFNvbWUgb2YgdGhlbSBhcmUgc21hbGwga2VybmVsLXNw
YWNlIGFwcGxpY2F0aW9ucyAob2Z0ZW4NCj4+IGNhbGxlZCAiYmFyZW1ldGFsIiwgbm90IHRvIGJl
IGNvbmZ1c2VkIHdpdGggdGhlIHRlcm0gImJhcmVtZXRhbCIgdXNlZCBpbg0KPj4gZGF0YWNlbnRl
ciB3aGljaCBtZWFucyAid2l0aG91dCBoeXBlcnZpc29ycyIpIG9yIFJUT1Nlcy4gIEFkZGl0aW9u
YWxseSwNCj4+IGZvciBzYWZldHkgcmVhc29ucywgdXNlcnMgb2Z0ZW4gbmVlZCB0byBiZSBhYmxl
IHRvIGNvbmZpZ3VyZSB0aGUgZnVsbA0KPj4gc3lzdGVtIHN0YXRpY2FsbHkgc28gdGhhdCBpdCBj
YW4gYmUgdmVyaWZpZWQgc3RhdGljYWxseS4NCj4+IA0KPj4gRXZlbnQgY2hhbm5lbHMgYXJlIHZl
cnkgc2ltcGxlIGFuZCBjYW4gYmUgYWRkZWQgZXZlbiB0byBiYXJlbWV0YWwNCj4+IGFwcGxpY2F0
aW9ucy4gVGhpcyBwcm9wb3NhbCBpbnRyb2R1Y2VzIGEgd2F5IHRvIGRlZmluZSB0aGVtIHN0YXRp
Y2FsbHkNCj4+IHRvIG1ha2UgdGhlbSBzdWl0YWJsZSB0byBkb20wbGVzcyBlbWJlZGRlZCBkZXBs
b3ltZW50cy4NCj4+IC0tLQ0KPj4gDQo+PiANCj4+PiArIyMgUHJvcG9zYWw6DQo+Pj4gKw0KPj4+
ICtFdmVudCBjaGFubmVscyBhcmUgdGhlIGJhc2ljIHByaW1pdGl2ZSBwcm92aWRlZCBieSBYZW4g
Zm9yIGV2ZW50IG5vdGlmaWNhdGlvbnMuDQo+Pj4gK0FuIGV2ZW50IGNoYW5uZWwgaXMgYSBsb2dp
Y2FsIGNvbm5lY3Rpb24gYmV0d2VlbiAyIGRvbWFpbnMgKG1vcmUgc3BlY2lmaWNhbGx5DQo+Pj4g
K2JldHdlZW4gZG9tMSxwb3J0MSBhbmQgZG9tMixwb3J0MikuIFRoZXkgZXNzZW50aWFsbHkgc3Rv
cmUgb25lIGJpdCBvZg0KPj4+ICtpbmZvcm1hdGlvbiwgdGhlIGV2ZW50IG9mIGludGVyZXN0IGlz
IHNpZ25hbGxlZCBieSB0cmFuc2l0aW9uaW5nIHRoaXMgYml0IGZyb20NCj4+PiArMCB0byAxLiBB
biBldmVudCBpcyBhbiBlcXVpdmFsZW50IG9mIGEgaGFyZHdhcmUgaW50ZXJydXB0Lg0KPj4+ICsN
Cj4+PiArTm90aWZpY2F0aW9ucyBhcmUgcmVjZWl2ZWQgYnkgYSBndWVzdCB2aWEgYW4gaW50ZXJy
dXB0IGZyb20gWGVuIHRvIHRoZSBndWVzdCwNCj4+PiAraW5kaWNhdGluZyB3aGVuIGFuIGV2ZW50
IGFycml2ZXMgKHNldHRpbmcgdGhlIGJpdCkuIEZ1cnRoZXIgbm90aWZpY2F0aW9ucyBhcmUNCj4+
PiArbWFza2VkIHVudGlsIHRoZSBiaXQgaXMgY2xlYXJlZCBhZ2Fpbi4gV2hlbiBhIGRvbWFpbiB3
YW50cyB0byB3YWl0IGZvciBkYXRhIGl0DQo+Pj4gK3dpbGwgYmxvY2sgdW50aWwgYW4gZXZlbnQg
YXJyaXZlcywgYW5kIHRoZW4gc2VuZCBhbiBldmVudCB0byBzaWduYWwgdGhhdCBkYXRhDQo+Pj4g
K2hhcyBiZWVuIGNvbnN1bWVkLiBFdmVudHMgYXJlIGRlbGl2ZXJlZCBhc3luY2hyb25vdXNseSB0
byBndWVzdHMgYW5kIGFyZQ0KPj4+ICtlbnF1ZXVlZCB3aGVuIHRoZSBndWVzdCBpcyBub3QgcnVu
bmluZy4NCj4+PiArDQo+Pj4gK0V2ZW50IGNoYW5uZWwgY29tbXVuaWNhdGlvbiB3aWxsIGJlIGVz
dGFibGlzaGVkIHN0YXRpY2FsbHkgYmV0d2VlbiB0d28gZG9tVQ0KPj4+ICtndWVzdHMgYmVmb3Jl
IHVucGF1c2luZyB0aGUgZG9tYWlucyBhZnRlciBkb21haW4gY3JlYXRpb24uIEV2ZW50IGNoYW5u
ZWwNCj4+PiArY29ubmVjdGlvbiBpbmZvcm1hdGlvbiBiZXR3ZWVuIGRvbVVzIHdpbGwgYmUgcGFz
c2VkIHRvIFhFTiB2aWEgZGV2aWNlIHRyZWUNCj4+PiArbm9kZS4NCj4+PiArDQo+Pj4gK1VuZGVy
IHRoZSAvY2hvc2VuIG5vZGUsIHRoZXJlIG5lZWRzIHRvIGJlIHN1YiBub2RlcyB3aXRoIGNvbXBh
dGlibGUNCj4+PiArInhlbixldnRjaG4iIHRoYXQgZGVzY2liZXMgdGhlIGV2ZW50IGNoYW5uZWwg
Y29ubmVjdGlvbiBiZXR3ZWVuIHR3byBkb21Vcy4NCj4+PiArDQo+Pj4gK1RoZSBldmVudCBjaGFu
bmVsIHN1Yi1ub2RlIGhhcyB0aGUgZm9sbG93aW5nIHByb3BlcnRpZXM6DQo+Pj4gKw0KPj4+ICst
IGNvbXBhdGlibGUNCj4+PiArDQo+Pj4gKyAgICAieGVuLGV2dGNobiINCj4+PiArDQo+Pj4gKy0g
eGVuLGV2dGNobg0KPj4+ICsNCj4+PiArICAgIFRoZSBwcm9wZXJ0eSBpcyBmb3VyIG51bWJlcnMg
b2YgdHVwbGVzIG9mDQo+Pj4gKyAgICAobG9jYWwtcG9ydC1kb21VMSxkb21VMS1waGFuZGxlLGxv
Y2FsLXBvcnQtZG9tVTIsZG9tVTItcGhhbmRsZSkgd2hlcmU6DQo+Pj4gKw0KPj4+ICsgICAgbG9j
YWwtcG9ydC1kb21VMSBpcyBhbiBpbnRlZ2VyIHZhbHVlIHRoYXQgd2lsbCBiZSB1c2VkIHRvIGFs
bG9jdGUgbG9jYWwNCj4+PiArICAgIHBvcnQgZm9yIGRvbVUxIHRvIHNlbmQgYW4gZXZlbnQgbm90
aWZpY2F0aW9uIHRvIHRoZSByZW1vdGUgZG9tYWluLg0KPj4+ICsNCj4+PiArICAgIGRvbVUxLXBo
YW5kbGUgaXMgYSBzaW5nbGUgcGhhbmRsZSB0byBhbiBkb21haW4gdG8gd2hpY2ggbG9jYWwtcG9y
dC1kb21VMQ0KPj4+ICsgICAgd2lsbCBiZSBhbGxvY2F0ZWQuDQo+Pj4gKw0KPj4+ICsgICAgbG9j
YWwtcG9ydC1kb21VMiBpcyBhbiBpbnRlZ2VyIHZhbHVlIHRoYXQgd2lsbCBiZSB1c2VkIHRvIGFs
bG9jdGUgbG9jYWwNCj4+PiArICAgIHBvcnQgZm9yIGRvbVUyIHRvIHNlbmQgYW4gZXZlbnQgbm90
aWZpY2F0aW9uIHRvIHRoZSByZW1vdGUgZG9tYWluLg0KPj4+ICsNCj4+PiArICAgIGRvbVUyLXBo
YW5kbGUgaXMgYSBzaW5nbGUgcGhhbmRsZSB0byBhbiBkb21haW4gdG8gd2hpY2ggbG9jYWwtcG9y
dC1kb21VMg0KPj4+ICsgICAgd2lsbCBiZSBhbGxvY2F0ZWQuDQo+Pj4gKw0KPj4+ICtFeGFtcGxl
Og0KPj4+ICsNCj4+PiArICAgIGNob3NlbiB7DQo+Pj4gKyAgICAgICAgLi4uLg0KPj4+ICsNCj4+
PiArICAgICAgICBkb21VMTogZG9tVTEgew0KPj4+ICsgICAgICAgICAgICAuLi4uLi4NCj4+PiAr
ICAgICAgICB9Ow0KPj4+ICsNCj4+PiArICAgICAgICBkb21VMjogZG9tVTIgew0KPj4+ICsgICAg
ICAgICAgICAuLi4uLi4NCj4+PiArICAgICAgICB9Ow0KPj4+ICsNCj4+PiArICAgICAgICBldnRj
aG5AMSB7DQo+Pj4gKyAgICAgICAgICAgIGNvbXBhdGlibGUgPSAieGVuLGV2dGNobiI7DQo+Pj4g
KyAgICAgICAgICAgIHhlbixldnRjaG4gPSA8MHhhICZkb21VMSAweGIgJmRvbVUyPjsNCj4+PiAr
ICAgICAgICB9Ow0KPj4+ICsNCj4+PiArICAgICAgICBldnRjaG5AMiB7DQo+Pj4gKyAgICAgICAg
ICAgIGNvbXBhdGlibGUgPSAieGVuLGV2dGNobiI7DQo+Pj4gKyAgICAgICAgICAgIHhlbixldnRj
aG4gPSA8MHhjICZkb21VMSAweGQgJmRvbVUyPjsNCj4+PiArICAgICAgICB9Ow0KPj4+ICsgICAg
fTsNCj4+IA0KPj4gVGhlcmUgaXMgbm8gbmVlZCB0byB1c2UgdHdvIGV2dGNobiBub2RlcyBmb3Ig
dGhpcyBnaXZlbiB0aGF0IGluIGRldmljZQ0KPj4gdHJlZSBpdCBpcyBlbnRpcmVseSBub3JtYWwg
dG8gaGF2ZSBtdWx0aXBsZSB0dXBsZXRzIGluIGEgcHJvcGVydHkuIEFsc28sDQo+PiBpdCB3b3Vs
ZCBiZSBnb29kIHRvIGhhdmUgYSB2ZXJzaW9uIG51bWJlciBpbiB0aGUgY29tcGF0aWJsZSBzdHJp
bmcgc28NCj4+IHRoYXQgd2UgY2FuIGNoYW5nZSB2ZXJzaW9uIGluIHRoZSBmdXR1cmUuDQo+PiAN
Cj4+IDEpDQo+PiAgICBjaG9zZW4gew0KPj4gICAgICAgIC4uLi4NCj4+IA0KPj4gICAgICAgIGRv
bVUxOiBkb21VMSB7DQo+PiAgICAgICAgICAgIC4uLi4uLg0KPj4gICAgICAgIH07DQo+PiANCj4+
ICAgICAgICBkb21VMjogZG9tVTIgew0KPj4gICAgICAgICAgICAuLi4uLi4NCj4+ICAgICAgICB9
Ow0KPj4gDQo+PiAgICAgICAgZXZ0Y2huIHsNCj4+ICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ4
ZW4sZXZ0Y2huLXYxIjsNCj4+ICAgICAgICAgICAgeGVuLGV2dGNobiA9IDwweGEgJmRvbVUxIDB4
YiAmZG9tVTIgMHhjICZkb21VMSAweGQgJmRvbVUyPjsNCj4+ICAgICAgICB9Ow0KPj4gICAgfTsN
Cj4+IA0KPj4gDQo+PiBJIHNob3VsZCBtZW50aW9uIHRoYXQgaXQgd291bGQgYmUgYWxzbyBwb3Nz
aWJsZSB0byB1c2Ugc3ViLW5vZGVzIHRvDQo+PiBleHByZXNzIHRoaXMgaW5mb3JtYXRpb246DQo+
PiANCj4+IDIpDQo+PiAgICAgICAgZG9tVTE6IGRvbVUxIHsNCj4+ICAgICAgICAgICAgLi4uDQo+
PiAgICAgICAgICAgIC8qIG9uZSBzdWItbm9kZSBwZXIgbG9jYWwgZXZlbnQgY2hhbm5lbCAqLw0K
Pj4gICAgICAgICAgICBlYzE6IGV2dGNobkBhIHsNCj4+ICAgICAgICAgICAgICAgIGNvbXBhdGli
bGUgPSAieGVuLGV2dGNobi12MSI7DQo+PiAgICAgICAgICAgICAgICAvKiBsb2NhbC1ldnRjaG4g
bGluay10by1mb3JlaWduLWV2dGNobiAqLw0KPj4gICAgICAgICAgICAgICAgeGVuLGV2dGNobiA9
IDwweGEgJmVjMz4NCj4+ICAgICAgICAgICAgfTsNCj4+ICAgICAgICAgICAgZWMyOiBldnRjaG5A
YyB7DQo+PiAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInhlbixldnRjaG4tdjEiOw0KPj4g
ICAgICAgICAgICAgICAgeGVuLGV2dGNobiA9IDwweGMgJmVjND4NCj4+ICAgICAgICAgICAgfTsN
Cj4+ICAgICAgICB9Ow0KPj4gDQo+PiAgICAgICAgZG9tVTI6IGRvbVUyIHsNCj4+ICAgICAgICAg
ICAgLi4uDQo+PiAgICAgICAgICAgIGVjMzogZXZ0Y2huQGIgew0KPj4gICAgICAgICAgICAgICAg
Y29tcGF0aWJsZSA9ICJ4ZW4sZXZ0Y2huLXYxIjsNCj4+ICAgICAgICAgICAgICAgIHhlbixldnRj
aG4gPSA8MHhiICZlYzE+DQo+PiAgICAgICAgICAgIH07DQo+PiAgICAgICAgICAgIGVjNDogZXZ0
Y2huQGQgew0KPj4gICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sZXZ0Y2huLXYxIjsN
Cj4+ICAgICAgICAgICAgICAgIHhlbixldnRjaG4gPSA8MHhhICZlYzI+DQo+PiAgICAgICAgICAg
IH07DQo+PiAgICAgICAgfTsNCj4+ICAgIH07DQo+PiANCj4+IFRoaXMgZm9ybWF0IGhhcyB0aGUg
YWR2YW50YWdlIHRoYXQgZG9lc24ndCBuZWVkIGEgbmV3IHRvcC1sZXZlbCBub2RlDQo+PiB0eXBl
IHVuZGVyIC9jaG9zZW4uIFRoYXQgaXMgZGVzaXJhYmxlIGZldyBhIGZldyByZWFzb25zLiBUb2Rh
eSB3ZSBvbmx5DQo+PiBoYXZlIGRvbWFpbnMgKGRvbTAgaXMgbGVnYWN5KS4gSW4gdGhlIGZ1dHVy
ZSB3ZSBtaWdodCBoYXZlIG5lc3RlZA0KPj4gZG9tYWlucyBhbmQgbm9uLVhlbiBkb21haW5zLiBX
aXRoIFN5c3RlbSBEZXZpY2UgVHJlZSwgZG9tYWlucyBhcmUgdW5kZXINCj4+IC9kb21haW5zIGlu
c3RlYWQgb2YgL2Nob3Nlbi4NCj4+IA0KPj4gU28gbm9ybWFsbHkgSSB3b3VsZCBhcmd1ZSB0byB1
c2UgdGhlIHN1Yi1ub2RlIGZvcm1hdCBiZWNhdXNlIGl0IGRvZXNuJ3QNCj4+IG5lZWQgYSBuZXcg
dG9wLWxldmVsIG5vZGUgdW5kZXIgL2Nob3Nlbi4gSG93ZXZlciwgaW4gdGhpcyBjYXNlIGl0IGxv
b2tzDQo+PiBsaWtlIHRoZSAxKSBmb3JtYXQgaXMgc2ltcGxlciB0byB3cml0ZSBhbmQgYWxzbyBz
aW1wbGVyIHRvIHBhcnNlIGluIFhlbi4NCj4+IA0KPj4gSW4gMSksIHdlIHdvdWxkIG5lZWQgdG8g
bG9vcCBvdmVyIHhlbixldnRjaG4gYW5kIGZvciBlYWNoIHR1cGxldCB3ZQ0KPj4gd291bGQgb25s
eSBuZWVkIHRvIGZldGNoIHRoZSBmb3JlaWduIGRvbWlkLg0KPj4gDQo+PiBJbiAyKSwgd2Ugd291
bGQgbmVlZCB0byBjaGVjayB0aGUgY29tcGF0aWJsZSBzdHJpbmcgb2YgZXZlcnkNCj4+ICJ4ZW4s
ZXZ0Y2huLXYxIiBub2RlLCBhbmQgd2Ugd291bGQgaGF2ZSB0byBmZXRjaCBmcm9tIHRoZSBwaGFu
ZGxlIGJvdGgNCj4+IHRoZSByZW1vdGUgZXZlbnQgY2hhbm5lbCBudW1iZXIgYnV0IGFsc28gdGhl
IGRvbWFpbi1pZCBvZiB0aGUgcGFyZW50Lg0KPj4gDQo+PiBTbyBpdCBsb29rcyBsaWtlIDEpIGlz
IGJldHRlciBiZWNhdXNlIGl0IGlzIG11Y2ggc2ltcGxlciB0byBwYXJzZS4gRG8NCj4+IHlvdSBh
Z3JlZT8NCj4gDQo+IFsuLi5dDQo+PiANCj4+IEkgdGhpbmsgdGhpcyBpcyBmaW5lIGluIHByaW5j
aXBsZS4gTGlrZSBKYW4gd3JvdGUsIGF0IHNvbWUgcG9pbnQgd2UnbGwNCj4+IG5lZWQgdG8gc3Bl
Y2lmeSB0aGUgZGV2aWNlIHRyZWUgYmluZGluZyB0byBleHBvc2UgdGhpcyBpbmZvcm1hdGlvbiB0
bw0KPj4gdGhlIGd1ZXN0Lg0KPiANCj4gQWN0dWFsbHksIHRoaW5raW5nIG1vcmUgYWJvdXQgaXQs
IEkgdGhpbmsgaXQgaXMgbGlrZWx5IHRoYXQgdGhlIGd1ZXN0DQo+IGRldmljZSB0cmVlIGJpbmRp
bmdzIHdpbGwgaW5jbHVkZSBpbmZvcm1hdGlvbiBhYm91dCBob3cgaXQgaXMgc3VwcG9zZWQNCj4g
dG8gYmUgdXNlZC4gRm9yIGluc3RhbmNlLCB0aGUgZG9tVSBkZXZpY2UgdHJlZSBtaWdodCBwYWly
IGFuIGV2ZW50DQo+IGNoYW5uZWwgd2l0aCBhIHNoYXJlZCBtZW1vcnkgcmVnaW9uIHNvIHRoYXQg
dGhlIGRvbVUga25vd3MgdGhhdCB0aGV5IGFyZQ0KPiBleHBlY3RlZCB0byBiZSB1c2VkIHRvZ2V0
aGVyLg0KPiANCj4gSWYgWGVuIGlzIHRvIGdlbmVyYXRlIHN1Y2ggYSBkZXZpY2UgdHJlZSBmb3Ig
Z3Vlc3RzLCB0aGVuIHdlIG5lZWQgdGhhdA0KPiBpbmZvcm1hdGlvbiBhbHNvIG9uIHRoZSBob3N0
IGRldmljZSB0cmVlIHRvbyAodGhlIG9uZSBnaXZlbiB0byBYZW4gYW5kDQo+IGRpc2N1c3NlZCBo
ZXJlLikNCj4gDQo+IFNvLCBJIHRoaW5rIGl0IHdvdWxkIGJlIGEgZ29vZCBpZGVhIHRvIGRpc2N1
c3MgdGhlIGRvbVUgZGV2aWNlIHRyZWUNCj4gYmluZGluZ3MgZm9yIHRoaXMsIGFzIHBhcnQgb2Yg
dGhpcyBkZXNpZ24gZG9jdW1lbnQsIGV2ZW4gaWYgd2UgZG9uJ3QNCj4gaW1wbGVtZW50IGl0IHN0
cmFpZ2h0IGF3YXkuDQoNCldoYXQgeW91IG1lbnRpb24gaGVyZSBpcyBhY3R1YWxseSBjb21iaW5p
bmcgMiBkaWZmZXJlbnQgc29sdXRpb25zIGluc2lkZQ0KWGVuIHRvIGJ1aWxkIGEgY3VzdG9tIGNv
bW11bmljYXRpb24gc29sdXRpb24uDQpNeSBhc3N1bXB0aW9uIGhlcmUgaXMgdGhhdCB0aGUgdXNl
ciB3aWxsIGFjdHVhbGx5IGNyZWF0ZSB0aGUgZGV2aWNlIHRyZWUNCm5vZGVzIGhlIHdhbnRzIHRv
IGRvIHRoYXQgYW5kIHdlIHNob3VsZCBub3QgY3JlYXRlIGd1ZXN0IG5vZGUgZW50cmllcw0KYXMg
aXQgd291bGQgZW5mb3JjZSBzb21lIGRlc2lnbi4NCg0KSWYgZXZlcnl0aGluZyBjYW4gYmUgc3Rh
dGljYWxseSBkZWZpbmVkIGZvciBYZW4gdGhlbiB0aGUgdXNlciBjYW4gYWxzbw0Kc3RhdGljYWxs
eSBkZWZpbmUgbm9kZSBlbnRyaWVzIGluc2lkZSBoaXMgZ3Vlc3QgdG8gbWFrZSB1c2Ugb2YgdGhl
IGV2ZW50cw0KYW5kIHRoZSBzaGFyZWQgbWVtb3JpZXMuDQoNCkZvciBleGFtcGxlIG9uZSBtaWdo
dCBuZWVkIG1vcmUgdGhhbiBvbmUgZXZlbnQgdG8gYnVpbGQgYSBjb21tdW5pY2F0aW9uDQpzeXN0
ZW0sIG9yIG1vcmUgdGhhbiBvbmUgc2hhcmVkIG1lbW9yeSBvciBjb3VsZCBidWlsZCBzb21ldGhp
bmcNCmNvbW11bmljYXRpbmcgd2l0aCBtdWx0aXBsZSBndWVzdCB0aHVzIHJlcXVpcmluZyBldmVu
IG1vcmUgZXZlbnRzIGFuZA0Kc2hhcmVkIG1lbW9yaWVzLg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoN
Cg==


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:45:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:45:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302955.516876 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrYU-00084P-6Z; Mon, 11 Apr 2022 10:45:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302955.516876; Mon, 11 Apr 2022 10:45:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrYU-00084I-2l; Mon, 11 Apr 2022 10:45:58 +0000
Received: by outflank-mailman (input) for mailman id 302955;
 Mon, 11 Apr 2022 10:45:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndrYT-0007mG-1b
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:45:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b6f2ec7-b984-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 12:45:47 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-r32M0Kt_PCSPt0Vz4hAA8Q-1; Mon, 11 Apr 2022 12:45:54 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR0401MB2629.eurprd04.prod.outlook.com (2603:10a6:4:3b::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 10:45:52 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 10:45:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b6f2ec7-b984-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649673955;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JQIt2KH/LPlOVO/K1JQ2W6WZuAzLqxdu/AirvMUWfP0=;
	b=K2+mYz9hiyPIwgzAa+usPorBv1fGcRoprtWGEoM3S/rDUiZaedAGRavw43dJgKn9gXOuSr
	/JoAr89fCBIdlxxFGDlAvuUMu+yjsQFLoIZ0SbeKg6FeIg8dWaglfFte22Sd6knpMgFtv2
	6LY/veXl3TlSKGOXrJYFgYnrY8D3i4o=
X-MC-Unique: r32M0Kt_PCSPt0Vz4hAA8Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Mc5GdXunLuFx407oxI/gB1jy1g9YMumaWhx3YnmdKvS4E+3UBwPT0dRYc8C0xhhLNcdfbbqElLLrfC5xeoJdwqt4xBHHO+T20oPEBwupWvvBQgYmuqA/lPn62th6a1NRmj/FDExW0j5diZM7rwrwtkKAaP87XRFbmf98FmPFptK3LX0eOCbb496vrqccIcs6r/qVOyFTdsU0psxSZKE3Gr1hvwhNKBv6+TjGoV4wtDNTIe7ZkAczrh1IUfNOO1pqIFNIpVEp0Tr/ND2tYVCnBiu9YNeS/Csf0yVxXPWyjD3R0JhLv1yeIc9DHESbD8embfRvTAMFuQlvsx717byxcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JQIt2KH/LPlOVO/K1JQ2W6WZuAzLqxdu/AirvMUWfP0=;
 b=muUUJG/ih9WNTjzx8k5/fn/CgfZ1J5Bv9jwJ9+E5UTcILr3Ftbn4bnQPVN7s6onamxoHsWSIeAnc4HKA8wzA7Sel5wQSw64fXR+IwQZrENlEXfGXHicecGc3JrvSRU5UatzQuSdfGeSRT8CAs4zdMiM+fGFCN9ekf7oT5C06/O8sKEDL5/rHnBEUnqsf61tbdiOhjihZItbdHwSS/51/yUXsQxBb7DAwlQOTBZf3doueHkdg8s2O1n0jDXErTeT2Du8nm6Sb6TTFUhnzV3xkTOIxkC27c3vRfzP+hhdfulKNxikr3hBQx4iUliRG7bjFaclR8lYx7QQzINNqGtiXdA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e41da164-7aeb-3d99-ef4d-17c591af7e37@suse.com>
Date: Mon, 11 Apr 2022 12:45:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
 <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
 <3217803e-16d5-6e2a-bde7-ff9a1237dd39@suse.com>
 <decf721a-8062-a23f-a810-78fb86a42d1d@xen.org>
 <747017ab-9aa9-b958-8cbf-42c2cc3ffdb1@suse.com>
 <0f18eb04-7b39-da75-fcf4-f765d8ea28b1@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0f18eb04-7b39-da75-fcf4-f765d8ea28b1@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0091.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::32) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 57aa1ca9-61e3-482b-50b4-08da1ba871da
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2629:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB26292D97C9BF1FF9FF4A2EABB3EA9@DB6PR0401MB2629.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XJe9YfMpMax7E0FdWzRiUCdYl2NeEzu8YqtAqRoBx/YfHG74YgHf4N9JjKVBYnXBLP/UNxyVX9U9xjZ/XsmXzDtBMvedJNssUw0bHAQHsbLVt4lUC3VyK/plSm1K7/5vtBHpCHyZg9DwCg1nPBCC8NtwmTVcpnAg7cDpFvxh5ySTOxP2vUMx15ICZAnHy3TkgNFvhbcMogELMHd1fJt+vlE3iNn8OEviNdDr13Cs2BL3M0Tkb3oUTxwxUn49Psofx6faIQy4Zb51TarzCcD4pK3sfWxYUyMcYMdC74d6kg+Zy0MBFXJwSlg1igq4qN7rY0FCl7inucIqKxIVCDvITgJXHa4FIe4MZWLovVNCLGtcXK+xMRwlEFAkcyTj/Ae0yN6yCtm43Y/b0hpB1a4AcF9L9cDxyOGkJrkI4ezB9rCymqPRYbJUmzTXzWPDrBq5r3MhU+w5NSyAGMXjbERB/KdcX2B4NKomS06B5QlKES1WDwEParOz+XSP9oW41EeDs+KpciCpHmbuu0TFE0x6g3ZN/0DIf5uEXr8cc5gxNMsUlrKNsm7Or4j8dSgScEl7NFo5MRUnbuuAqpxlhjITRz0H/hyHed+wqebZhnqF4R54vl0O9aa1p8BotjXn+IIYPiYwRApF7hX4ohWerwePdgkJ8pvSuV3SuY3jyE+oarq4mjYXHsvRsVFBjDne9GLGnnpf1fHTbztwKlfqLrmnVWQw/INjk6yQpo7Qq1McXbn1I6tkHlRV4OGWjVqoSVzM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(6916009)(86362001)(66946007)(66556008)(66476007)(54906003)(508600001)(2616005)(4326008)(8676002)(31696002)(53546011)(6512007)(6506007)(8936002)(6486002)(83380400001)(38100700002)(2906002)(36756003)(31686004)(26005)(5660300002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TFgzVlBiZHBocGkzQlRISzNXOXhQRlVwQnc4RnQzeUhvWmsyRW8wdzlya1dq?=
 =?utf-8?B?UmxXcklHWHJ5ZVg4ZXhMcHVTRHhzVi9kdG92M2M1VFFOYy85ZFU2SkhEQ0My?=
 =?utf-8?B?WVl2ZzA1QlFidzhvcnE1anUvV1RoMEtYOWgwaEZkRTJBWW1KbWZLQTFndGJN?=
 =?utf-8?B?VDY2ams1alVRemwrdHArMm9XMEZsSk9ONkxYbWIzaWVCQTNtVnBtbEpOYVBM?=
 =?utf-8?B?cWxjbG03bnlUdW0zMlVaMm03NTRjMVBxd1VKZlpLQk54Yk9lSHVFQ2JUbzM4?=
 =?utf-8?B?cjY1OGFGVVA2OFlkL29mR29hWElhQlM5NXpNbGljVnVNbElKY2FoWGJtbWVo?=
 =?utf-8?B?dWgyT0E5YmhqRXZVa3d3cDdqLzZiSnpNVEtheSs2TDV6WWNoTzFEalpGWnN4?=
 =?utf-8?B?aVBBa3QwSWNvQUlOOW5DMFhFcUY0bVUvUkFiR2w5TzZBWFIxWHQvaXYzbG1C?=
 =?utf-8?B?cDN1cytRci9XbTF4VEVRbTBjZ1JxRFQxbjFERm1jVFU4ZEc4SURLdHNRRitp?=
 =?utf-8?B?enV5WTRER3NuT2c3Yjd3bElkSzdISDN2cVdhQ3U0a3pPekErR3RSbkorZisw?=
 =?utf-8?B?dWdUWVRITkFYaHB2SXZzdndRYVllbVZnRzMwQlRYUGZXTmF4cnB3Q1VzRy85?=
 =?utf-8?B?V1pnQ01IcGdVU0ZSbVExY1VIRGJlV0hCNWtYVDZOdGIvSXp1eVZDd1Rwa1lN?=
 =?utf-8?B?cjRqeVIwUDRrL1MrT2lReXZRRHA2S25FdkFMN3hYaWtpOHNmOFZscnh0cGkz?=
 =?utf-8?B?QjVGdHZPTWkzbndDb0xDaWdQR043encxRFkwdTZ2UGp3cWdDQ0g0MFN4cTdF?=
 =?utf-8?B?Ykk5WkF1WUFHYjZYYlp0aXJ1ajkwNCtwNEMrVGRScWVjWTJWUklxYXA5T2U0?=
 =?utf-8?B?YW11OTFkaGpTRDg4NlJNOE42UTZXejV1NVBuczFLRXAyWjdXZzBCWW9McFli?=
 =?utf-8?B?cS9GV1JWcmI2bHcvbWtzUy9sektwbEk1YmlQUW1mLzJRaDJXbEhWRWZYcXox?=
 =?utf-8?B?SlJzNFNSUFY2VmU4ZkhXWTRzTGFTbnlSVXphMy9peFJxenVRWWYrcWFrUU5s?=
 =?utf-8?B?WFk1UWRuOUh2dmZCWExUbEtrdkNSa3hOVVhwR3dGMXpGazFGa01UT3hxZjla?=
 =?utf-8?B?L2pjZVlISGlqR0NQdEp2bGlkbFhONE02NDkvNFViK1FYazdrSHVSWEMrTkdN?=
 =?utf-8?B?eVJ4NzRWcXhRNHFhRFB4TEVHbk5QZ3dWU3pDWjFMZ0dWb09Jb2VjbWZsOVBV?=
 =?utf-8?B?ZzcvTHpaRll3SzhBRDhYSnBvS1c4VHBDNk5mYS9ONGhmenVzMmY1eHVMM25S?=
 =?utf-8?B?cThGeCtHRnpsN25mQkk2aTV4a0hZNlBiS2JGNTFsc29uV0VFUDN1cmFjcG1I?=
 =?utf-8?B?bmw5TnlkNExQb0NRQldpWTJzTTc0UnhSaEx2eVJMY3pVMWtDVDFIQzlRMjAy?=
 =?utf-8?B?bVBKN3Ayb2ZMOHFrR3hMMGRTeXpvalFXV2NHQm1zNW82S3VycmYxOXlhMHFI?=
 =?utf-8?B?VzlJU01OKy80V0ErakE5QmlvYlNCZHFXRk5Ndi9ZcThSQVNiTzRTbklTNEIz?=
 =?utf-8?B?aWJOSG1VQmM5MVlVMnh1UGdPYzBoZkEwTHpMQTN6ZmRzTU5YcmtlVTFUZ2hF?=
 =?utf-8?B?YWF3Qm1XVmkxT2tvYVQ0Z0RYQ2FTT1JuZDZjMFJEUmZjYUhMdjlzaDZPN21w?=
 =?utf-8?B?OEZ5SlhGYTAwL3hCdHhXZGJVRk9VWFZiU2IrOUpjcXNHOGk1ZnJZdUlOUjlH?=
 =?utf-8?B?SVZIbzVxR3NFRC96L3huT0V0OG45SGJYcVc3WHJENHVxRmh2dE03MGRqbnVx?=
 =?utf-8?B?OXg0Wno0bzBVdlIwem5hZ2RsRlFjbEEwUjg5R0d0eGRZYmp6UGhiN3Ivc0dm?=
 =?utf-8?B?TXRYZytPaTFwbkQ2WmlkNCtGa3VBSTZ0WGZ3SVdpTDNMeVpzQjNoTmNtK2ht?=
 =?utf-8?B?M2pham9EblpCK2hpSW5oVTRKVGpsSG1CSGtqTXlaeVRFMmUzQTFzN2k4dmhN?=
 =?utf-8?B?SC9RTkFkRW03QTV5aDZpY3B4TVYvVDdNU2lkUWFkYVQxT3l6OURYbjJoRVBX?=
 =?utf-8?B?TjhZSTdZVlRDUG4yRyt5SG43dlo0TlpvWTR3QzlydWtEQUROMTVuOXJsM3Yx?=
 =?utf-8?B?cXVWVEdtbHJOTzBmUzJyR0F5ZWt0K2E2d3JTUkFLb3RDWVRnZC93NGV0cDht?=
 =?utf-8?B?bTNvbldXMkxZY29QSno3dXdzRlVaN2JCMEdHaVZpcENFZnI5WlkzUGhDbEZq?=
 =?utf-8?B?V1dvZlR0NmxKOEpGQXkyTXZSdndncmhnWTRZdlM3N0s1Z0Z6Rk5PdjlXZXpR?=
 =?utf-8?B?R2tsbTNLNzBQK2dienU0OWsyN3FqakEwVDZET1k5Q21JVGh5N3ZGQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57aa1ca9-61e3-482b-50b4-08da1ba871da
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:45:50.6028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UW6/41Szyi3KJ/MxEwadB8+8HyeguRUthWN5IvW9aiIRbA7c3nZNyGky6MhRzweR0Mr8Vv/weRVi+JroNEKQEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2629

On 11.04.2022 12:25, Julien Grall wrote:
> On 11/04/2022 07:13, Jan Beulich wrote:
>>>>>> --- a/xen/common/event_channel.c
>>>>>> +++ b/xen/common/event_channel.c
>>>>>> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>>>>>>         unsigned int port;
>>>>>>         struct evtchn *chn;
>>>>>>     
>>>>>> +    /*
>>>>>> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
>>>>>> +     * vCPU-s they're to be delivered to run on. In order to limit lock
>>>>>> +     * contention, check for an empty list prior to acquiring the lock. In the
>>>>>> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
>>>>>> +     * until the vCPU is migrated (again) to another pCPU.
>>>>>> +     */
>>>>>
>>>>> AFAIU, the downside is another pCPU (and therefore vCPU) will get
>>>>> disturbed by the interrupt.
>>>>
>>>> But only rarely, i.e. in case a race would actually have occurred.
>>>
>>> Maybe I am too paranoid here. The other side of race is controlled by a
>>> domain. So wouldn't it be possible to increase how often the race is hit?
>>
>> Yes, of course - just to harm itself.
> 
> Are you sure? Wouldn't this also harm the next vCPU running on the pCPU 
> because it will get interrupted more often?

Possibly, sure. But we don't make any promises here. And recall that
this optimization as a whole has been put under question in the past.
If we'd drop it, we'd also impact various vCPU-s in not really
predictable ways.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:48:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:48:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302962.516887 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrbE-0000KR-M6; Mon, 11 Apr 2022 10:48:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302962.516887; Mon, 11 Apr 2022 10:48:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrbE-0000KK-I5; Mon, 11 Apr 2022 10:48:48 +0000
Received: by outflank-mailman (input) for mailman id 302962;
 Mon, 11 Apr 2022 10:48:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndrbD-0000KA-Di; Mon, 11 Apr 2022 10:48:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndrbD-0004Ah-Cs; Mon, 11 Apr 2022 10:48:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndrbD-00057c-6O; Mon, 11 Apr 2022 10:48:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndrbD-0001TT-61; Mon, 11 Apr 2022 10:48:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tl09PHFPAdfhdcWR0K+g1MOnr6rESs/Izzo/Y3t9FAc=; b=SoAaAGLbpYW38f47d9CMuqdrMo
	fp8dI2rZ+VVrNPy5GuczP+KgQKpLRntBuaG8tGob0gtEYBCU0oClJL4vtaQDqBfPQ31+qCqN474Ub
	jKD9sofYqZCutRrNnwTiIbZTHMDg5wj+orpPWCVSDzqsLsbABCi5nWKfrvQCH0pp3RVE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169302-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169302: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 10:48:47 +0000

flight 169302 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169302/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  322 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:58:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:58:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302973.516898 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrkk-0001uE-JN; Mon, 11 Apr 2022 10:58:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302973.516898; Mon, 11 Apr 2022 10:58:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrkk-0001u7-GD; Mon, 11 Apr 2022 10:58:38 +0000
Received: by outflank-mailman (input) for mailman id 302973;
 Mon, 11 Apr 2022 10:58:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndrkj-0001u1-4x
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:58:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrki-0004L8-FT; Mon, 11 Apr 2022 10:58:36 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrki-0004k1-8k; Mon, 11 Apr 2022 10:58:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ribuK56o4egzHboNH7gsIvacwzqN9X5h/7ibu9ACjwI=; b=4QV/zRkxypODTMN8Qhk3Y6Hmwe
	nXxIP3Go/OH//T+oFyrZ+xAJBo4za13hPa8xrGddO51pgvJQxO2HS+jaOK/3zLoC6ouJj2AnWFNbv
	EGbqzwu5c0yFrBYhISml1J4qQJow8lg2v9c5xpU95NcZjpLFnglrFDWAgMAa51rxzOJM=;
Message-ID: <a052e26c-2142-bf51-bc80-449476ed0854@xen.org>
Date: Mon, 11 Apr 2022 11:58:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Dario Faggioli <dfaggioli@suse.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220408084517.33082-5-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 08/04/2022 09:45, Luca Fancellu wrote:
> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
> new file mode 100644
> index 000000000000..40cc8135c66f
> --- /dev/null
> +++ b/docs/misc/arm/device-tree/cpupools.txt
> @@ -0,0 +1,140 @@
> +Boot time cpupools
> +==================
> +
> +When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
> +create cpupools during boot phase by specifying them in the device tree.
> +ACPI is not supported for this feature.
> +
> +Cpupools specification nodes shall be direct childs of /chosen node.
> +Each cpupool node contains the following properties:
> +
> +- compatible (mandatory)
> +
> +    Must always include the compatiblity string: "xen,cpupool".
> +
> +- cpupool-cpus (mandatory)
> +
> +    Must be a list of device tree phandle to nodes describing cpus (e.g. having
> +    device_type = "cpu"), it can't be empty.
> +
> +- cpupool-sched (optional)
> +
> +    Must be a string having the name of a Xen scheduler. Check the sched=<...>
> +    boot argument for allowed values [1]. When this property is omitted, the Xen
> +    default scheduler will be used.
> +
> +
> +Constraints
> +===========
> +
> +If no cpupools are specified, all cpus will be assigned to one cpupool
> +implicitly created (Pool-0).
> +
> +If cpupools node are specified, but not every cpu brought up by Xen is assigned,
> +all the not assigned cpu will be assigned to an additional cpupool.
> +
> +If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
> +stop.
> +
> +The boot cpu must be assigned to Pool-0, so the cpupool containing that core
> +will become Pool-0 automatically.
> +
> +
> +Examples
> +========
> +
> +A system having two types of core, the following device tree specification will
> +instruct Xen to have two cpupools:
> +
> +- The cpupool with id 0 will have 4 cpus assigned.
> +- The cpupool with id 1 will have 2 cpus assigned.

AFAIK, there are no guarantee that Xen will parse cpupool_a first. So it 
would be possible that the ID are inverted here.

This could happen if you want to keep the boot CPU in pool 0 and it is 
not cpu@0 (some bootloaders allows you to change the boot CPU).

Also, here you write "The cpupool with id X" but ...

> +A system having the cpupools specification below will instruct Xen to have three
> +cpupools:
> +
> +- The cpupool Pool-0 will have 2 cpus assigned.
> +- The cpupool Pool-1 will have 2 cpus assigned.
> +- The cpupool Pool-2 will have 2 cpus assigned (created by Xen with all the not
> +  assigned cpus a53_3 and a53_4).

here you write "The cpupool Pool-X". Can you be consistent?

On a separate topic, I think dom0_max_vcpus() needs to be updated to by 
default (i.e when opt_dom0_max_vcpus == 0) the number of vCPUs match the 
number of vCPUs in the cpupool (I think 0) used to created dom0.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 10:59:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 10:59:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302976.516908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrly-0002TF-TV; Mon, 11 Apr 2022 10:59:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302976.516908; Mon, 11 Apr 2022 10:59:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrly-0002T8-Qd; Mon, 11 Apr 2022 10:59:54 +0000
Received: by outflank-mailman (input) for mailman id 302976;
 Mon, 11 Apr 2022 10:59:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndrly-0002T2-By
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 10:59:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrlw-0004MK-Kp; Mon, 11 Apr 2022 10:59:52 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrlw-0004mL-F0; Mon, 11 Apr 2022 10:59:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=fq3qWzRuKmfh3iIzAxhArmlWL9Wdtpn9u3fQlAMUS9I=; b=673a2quflBcaYnsXLSRv7mPIrU
	erI6DvkgZ6HtVseySSirXAjueM4fkVLHW7KLyZNMkXKft27EZ0noPWVnPged4RnhIRX903+Zu+ErA
	R8dQbOvPRotTyKlDCR+zuG4Y2N3+y3a4xkjSMF28GhgFH/U+GRbeOp7ClPo1fkxYwBmU=;
Message-ID: <e0efebc8-cda1-8235-888f-c9048155eb29@xen.org>
Date: Mon, 11 Apr 2022 11:59:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [xen-4.12-testing test] 169199: regressions - FAIL
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
 osstest service owner <osstest-admin@xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <osstest-169199-mainreport@xen.org>
 <43ad1e8c-dacc-9b7a-7250-9348e7e52580@suse.com>
 <Yk/tzuKq4D3mFEQu@Air-de-Roger>
 <a6c6901d-0f6f-f4f6-eba9-c3d169c30433@suse.com>
 <YlAWBom8O8d1lCpQ@Air-de-Roger>
 <ab27a3c3-a85d-b9aa-de0c-ca96f3e2a3fc@xen.org>
 <YlAZhWVFziwoL0rb@Air-de-Roger>
 <41fe950e-cbc8-1da9-02d2-733c6fe4bb7a@xen.org>
 <YlBUF0j8HEpRX8Hs@Air-de-Roger>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YlBUF0j8HEpRX8Hs@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 08/04/2022 16:26, Roger Pau Monné wrote:
> On Fri, Apr 08, 2022 at 12:24:27PM +0100, Julien Grall wrote:
>> Hi Roger,
>>
>> On 08/04/2022 12:16, Roger Pau Monné wrote:
>>> On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> On 08/04/2022 12:01, Roger Pau Monné wrote:
>>>>>>> I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer
>>>>>>> uses 16 for example.
>>>>>>
>>>>>> I'm afraid a fixed number won't do, the more that iirc there are
>>>>>> systems with just a few cores in the pool (and you don't want to
>>>>>> over-commit by default).
>>>>>
>>>>> But this won't over commit, it would just assign dom0 16 vCPUs at
>>>>> most, if the system has less than 16 vCPUs that's what would be
>>>>> assigned to dom0.
>>>>
>>>> AFAICT, this is not the case on Arm. If you ask 16 vCPUs, then you will get
>>>> that number even if there are 8 pCPUs.
>>>>
>>>> In fact, the documentation of dom0_max_vcpus suggests that the numbers of
>>>> vCPUs can be more than the number of pCPUs.
>>>
>>> It was my understanding that you could only achieve that by using the
>>> min-max nomenclature, so in order to force 16 vCPUs always you would
>>> have to use:
>>>
>>> dom0_max_vcpus=16-16
>>>
>>> Otherwise the usage of '_max_' in the option name is pointless, and it
>>> should instead be dom0_vcpus.
>>>
>>> Anyway, I could use:
>>>
>>> dom0_max_vcpus=1-16
>>>
>>> Which is unambiguous and should get us 1 vCPU at least, or 16vCPUs at
>>> most.
>>
>> Unfortunately, Arm doesn't support the min-max nomenclature.
> 
> Hm, can we update the command line document then?
> 
> There's no mention that the min-max nomenclature is only available to
> x86. I assume it's not possible to share the logic here so that both
> Arm and x86 parse the option in the same way?

Looking at the x86 implementation, I think we can re-use everything but 
the pv_shim and NUMA bits.

> We don't need to store this information anywhere I think. Since we
> first install plain Debian and then install Xen we can always fetch
> the number of physical CPUs when running plain Linux and use that to
> calculate the amount to give to dom0?

You will need to check how that works with U-boot. I can't remember 
whether the script is loaded via tftp or stored on the local disk.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 11:01:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 11:01:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302982.516920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrn2-0003tg-B4; Mon, 11 Apr 2022 11:01:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302982.516920; Mon, 11 Apr 2022 11:01:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrn2-0003tZ-7Y; Mon, 11 Apr 2022 11:01:00 +0000
Received: by outflank-mailman (input) for mailman id 302982;
 Mon, 11 Apr 2022 11:00:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndrn1-0003tI-EE
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 11:00:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrmz-0004PE-8o; Mon, 11 Apr 2022 11:00:57 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndrmz-00054C-27; Mon, 11 Apr 2022 11:00:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=FOX8GuNpCUj/15E/7UyVQl9Ogngec06088pAumUE6tM=; b=AM+/PUg3DDa5hJO0xVVmJT9UIY
	d0FTQnu4cT/6gjBGK3zIDCoF/zb4QqzLkiILNw96gH+P/BZNiMGeFqAKAQJ66ibkF2TKM1TtXn/Og
	Rneac+nBboyho/NJrVzCcBTlnRaxyHUdRGvPd6826qgK5ll5+GZb9NsazlxgNHzQglh8=;
Message-ID: <afea970d-fe71-5f28-edda-c51e80d6e3d3@xen.org>
Date: Mon, 11 Apr 2022 12:00:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
 <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
 <3217803e-16d5-6e2a-bde7-ff9a1237dd39@suse.com>
 <decf721a-8062-a23f-a810-78fb86a42d1d@xen.org>
 <747017ab-9aa9-b958-8cbf-42c2cc3ffdb1@suse.com>
 <0f18eb04-7b39-da75-fcf4-f765d8ea28b1@xen.org>
 <e41da164-7aeb-3d99-ef4d-17c591af7e37@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e41da164-7aeb-3d99-ef4d-17c591af7e37@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 11/04/2022 11:45, Jan Beulich wrote:
> On 11.04.2022 12:25, Julien Grall wrote:
>> On 11/04/2022 07:13, Jan Beulich wrote:
>>>>>>> --- a/xen/common/event_channel.c
>>>>>>> +++ b/xen/common/event_channel.c
>>>>>>> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>>>>>>>          unsigned int port;
>>>>>>>          struct evtchn *chn;
>>>>>>>      
>>>>>>> +    /*
>>>>>>> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
>>>>>>> +     * vCPU-s they're to be delivered to run on. In order to limit lock
>>>>>>> +     * contention, check for an empty list prior to acquiring the lock. In the
>>>>>>> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
>>>>>>> +     * until the vCPU is migrated (again) to another pCPU.
>>>>>>> +     */
>>>>>>
>>>>>> AFAIU, the downside is another pCPU (and therefore vCPU) will get
>>>>>> disturbed by the interrupt.
>>>>>
>>>>> But only rarely, i.e. in case a race would actually have occurred.
>>>>
>>>> Maybe I am too paranoid here. The other side of race is controlled by a
>>>> domain. So wouldn't it be possible to increase how often the race is hit?
>>>
>>> Yes, of course - just to harm itself.
>>
>> Are you sure? Wouldn't this also harm the next vCPU running on the pCPU
>> because it will get interrupted more often?
> 
> Possibly, sure. But we don't make any promises here. And recall that
> this optimization as a whole has been put under question in the past.

I don't remember this discussion. Do you have a pointer?

> If we'd drop it, we'd also impact various vCPU-s in not really
> predictable ways.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 11:13:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 11:13:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302990.516931 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrzI-0005cN-FL; Mon, 11 Apr 2022 11:13:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302990.516931; Mon, 11 Apr 2022 11:13:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndrzI-0005cG-Bi; Mon, 11 Apr 2022 11:13:40 +0000
Received: by outflank-mailman (input) for mailman id 302990;
 Mon, 11 Apr 2022 11:13:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3hqm=UV=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1ndrzH-0005c8-3m
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 11:13:39 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 6eaa55d5-b988-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 13:13:37 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15633169E;
 Mon, 11 Apr 2022 04:13:36 -0700 (PDT)
Received: from [10.57.8.177] (unknown [10.57.8.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 652643F5A1;
 Mon, 11 Apr 2022 04:13:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6eaa55d5-b988-11ec-a405-831a346695d4
Message-ID: <bb60e700-c89e-60ba-74ee-6ad66b04988e@arm.com>
Date: Mon, 11 Apr 2022 13:13:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V4 1/2] xen/arm: Add i.MX lpuart driver
Content-Language: en-US
To: Julien Grall <julien@xen.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
 sstabellini@kernel.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>, Henry Wang <Henry.Wang@arm.com>
References: <20220408140932.17968-1-peng.fan@oss.nxp.com>
 <20220408140932.17968-2-peng.fan@oss.nxp.com>
 <d164f7a7-a219-63ad-580d-ead86ea79103@arm.com>
 <f0179c9c-e268-7858-2956-c3433a4e19cb@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <f0179c9c-e268-7858-2956-c3433a4e19cb@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Julien,

On 11.04.2022 12:20, Julien Grall wrote:
> Hi,
> 
> On 11/04/2022 07:26, Michal Orzel wrote:
>> On 08.04.2022 16:09, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> The i.MX LPUART Documentation:
>>> https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
>>> Chatper 13.6 Low Power Universal Asynchronous Receiver/
>>> Transmitter (LPUART)
>>>
>>> Tested-by: Henry Wang <Henry.Wang@arm.com>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>>   xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
>>>   xen/drivers/char/Kconfig              |   7 +
>>>   xen/drivers/char/Makefile             |   1 +
>>>   xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
>>>   4 files changed, 348 insertions(+)
>>>   create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
>>>   create mode 100644 xen/drivers/char/imx-lpuart.c
>>>
>>> diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
>>> new file mode 100644
>>> index 0000000000..26e2cf0249
>>> --- /dev/null
>>> +++ b/xen/arch/arm/include/asm/imx-lpuart.h
>>> @@ -0,0 +1,64 @@
>>> +/*
>>> + * xen/arch/arm/include/asm/imx-lpuart.h
>>> + *
>>> + * Common constant definition between early printk and the LPUART driver
>>> + *
>>> + * Peng Fan <peng.fan@nxp.com>
>>> + * Copyright 2022 NXP
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +
>>> +#ifndef __ASM_ARM_IMX_LPUART_H__
>>> +#define __ASM_ARM_IMX_LPUART_H__
>>> +
>>> +/* 32-bit register definition */
>>> +#define UARTBAUD          (0x10)
>>> +#define UARTSTAT          (0x14)
>>> +#define UARTCTRL          (0x18)
>>> +#define UARTDATA          (0x1C)
>>> +#define UARTMATCH         (0x20)
>>> +#define UARTMODIR         (0x24)
>>> +#define UARTFIFO          (0x28)
>>> +#define UARTWATER         (0x2c)
>>> +
>>> +#define UARTSTAT_TDRE     BIT(23, UL)
>>> +#define UARTSTAT_TC       BIT(22, UL)
>>> +#define UARTSTAT_RDRF     BIT(21, UL)
>>> +#define UARTSTAT_OR       BIT(19, UL)
>>> +
>>> +#define UARTBAUD_OSR_SHIFT (24)
>>> +#define UARTBAUD_OSR_MASK (0x1f)
>>> +#define UARTBAUD_SBR_MASK (0x1fff)
>>> +#define UARTBAUD_BOTHEDGE (0x00020000)
>>> +#define UARTBAUD_TDMAE    (0x00800000)
>>> +#define UARTBAUD_RDMAE    (0x00200000)It seems like you missed my comment about alignment from the previous patch version.
>> Please keep the same alignment of values within the same section.
> 
> I haven't yet reviewed this patch. But if this is the only comment, then I can update the alignment on commit.
> 
> Cheers,
> 

All my other findings have already been fixed by Peng. This is the last one as it was forgotten.
Patch 2/2 still has sth to be fixed so the alignment can be fixed in the same shot as well.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 11:21:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 11:21:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.302995.516942 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nds7A-00073d-81; Mon, 11 Apr 2022 11:21:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 302995.516942; Mon, 11 Apr 2022 11:21:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nds7A-00073W-56; Mon, 11 Apr 2022 11:21:48 +0000
Received: by outflank-mailman (input) for mailman id 302995;
 Mon, 11 Apr 2022 11:21:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XbSP=UV=bounce.vates.fr=bounce-md_30504962.62540f47.v1-ee643d67f5814913871557baab52452d@srs-se1.protection.inumbo.net>)
 id 1nds78-000737-CU
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 11:21:46 +0000
Received: from mail179-16.suw41.mandrillapp.com
 (mail179-16.suw41.mandrillapp.com [198.2.179.16])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9140c372-b989-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 13:21:44 +0200 (CEST)
Received: from pmta12.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1])
 by mail179-16.suw41.mandrillapp.com (Mailchimp) with ESMTP id
 4KcRJR4ZcCzB5p71B
 for <xen-devel@lists.xenproject.org>; Mon, 11 Apr 2022 11:21:43 +0000 (GMT)
Received: from [37.26.189.201] by mandrillapp.com id
 ee643d67f5814913871557baab52452d; Mon, 11 Apr 2022 11:21:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9140c372-b989-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr;
	s=mandrill; t=1649676103; x=1649978503; i=olivier.lambert@vates.fr;
	bh=9XSFacDXMSgMk90Yj8+tzVlXGPBp3aLXJn0GHa/++W8=;
	h=From:Subject:In-Reply-To:References:Message-Id:To:Cc:Feedback-ID:
	 Date:MIME-Version:Content-Type:CC:Date:Subject;
	b=KCoRDBpWYvrhYyljVQxbFwi5jofMAOzXT1i+ePYcLRikBckvMTydao25epdht7KLQ
	 9iae0mZPFGhhZO9bQ29afDXT6Fk5GcPlomf4aflX3YgjRMnbeqcLNcfIPIho9DaHdP
	 BNyJJSc4NVGOptKC6Ln14wTEZoeLWZuq4vOr4Vg8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; 
 i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1649676103; h=From : 
 Subject : In-Reply-To : References : Message-Id : To : Cc : Date : 
 MIME-Version : Content-Type : From : Subject : Date : X-Mandrill-User : 
 List-Unsubscribe; bh=9XSFacDXMSgMk90Yj8+tzVlXGPBp3aLXJn0GHa/++W8=; 
 b=Ibz6l7Y429o7O/q5v+GAUhMyCiS3wJJyGNyjQWzPGnX/qvIGbbxyWDu5+y+gw7bGS282ET
 cm6PZg8htg7/9jmoSPv8jtGvazgaZILzF1IYLs1+fyATo7/k4GNeh+Vps+SRkM0PEMa903NZ
 h1xu8JtC2aOnMAjf5GNQmUjAzii1c=
From: Olivier Lambert <olivier.lambert@vates.fr>
Subject: Re: Xen Project management working group
X-Bm-Draft-Info: {"type":"REPLY-ALL","messageInternalId":709122,"folderUid":"0c209865-5aa4-48c5-9a6e-86a91fc495c4"}
X-Bm-Draft-Refresh-Date: 1649676101481
X-Bm-Internal-Id: 51E2DD5C-2A80-4022-B0C6-3DE883716B7A#bluemind-4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2:712866
X-Bm-Previous-Body: f6fe3ff2da8f32ad5b434c1d0869677770aa066c
X-Bm-Disclaimer: Yes
X-Bm-Milter-Handled: a64b4288-bd64-474a-a5b2-2e97a97aa872
X-Bm-Transport-Timestamp: 1649676101991
In-Reply-To: <l1oyquzo.rukzku9wc9og@vates.fr>
References: <l1oyquzo.rukzku9wc9og@vates.fr>
Message-Id: <l1um9z4x.3tc1vn5jnueio@vates.fr>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, george.dunlap@citrix.com, Marc Ungeschikts <marc.ungeschikts@vates.fr>
X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com
X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.ee643d67f5814913871557baab52452d
X-Mandrill-User: md_30504962
Feedback-ID: 30504962:30504962.20220411:md
Date: Mon, 11 Apr 2022 11:21:43 +0000
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="_av-Wn4-HBU4NEOJIpFTAZy3sA"

--_av-Wn4-HBU4NEOJIpFTAZy3sA
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


https://doodle.com/meeting/participate/id/b822G1ge


I will probably leave the Doodle opened for few days (like up to Monday evening) until we can decide the best schedule without waiting too long. When I'll have the validated time slot, I'll communicate about it here.



So, as planned, here is the selected date. I picked this Thursday, April the 14th, at 4PM UTC (5PM London time, 6PM Paris time). Don't forget to add this to your calendar :)


Meeting place will be:

https://meet.vates.fr/xenmgmt


See you soon!




Regards,


Olivier Lambert | Vates CEO
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com

--_av-Wn4-HBU4NEOJIpFTAZy3sA
Content-Type: multipart/related; boundary="_av-fNQMrDGMxCVo0tfXUaPOPw"

--_av-fNQMrDGMxCVo0tfXUaPOPw
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
 <head></head>
 <body>
  <div id="bm-composer-content-wrapper">
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <blockquote style="margin-left: 1rem; padding-left: 1rem; border-left: 2px solid black;">
    <p style="margin-bottom: 0; margin-top: 0;">https://doodle.com/meeting/participate/id/b822G1ge</p>
    <p style="margin-bottom: 0; margin-top: 0;"><br></p>
    <p style="margin-bottom: 0; margin-top: 0;">I will probably leave the Doodle opened for few days (like up to Monday evening) until we can decide the best schedule without waiting too long. When I'll have the validated time slot, I'll communicate about it here.</p>
    <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   </blockquote>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">So, as planned, here is the selected date. I picked this Thursday, April the 14th, at 4PM UTC (5PM London time, 6PM Paris time). Don't forget to add this to your calendar :)</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Meeting place will be:</p>
   <p style="margin-bottom: 0; margin-top: 0;">https://meet.vates.fr/xenmgmt</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">See you soon!</p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;"><br></p>
   <p style="margin-bottom: 0; margin-top: 0;">Regards,</p>
   <style></style>
  </div>
  <div class="x-disclaimer995950824">
   <div>
     &nbsp;
   </div>
   <div>
     &nbsp;
   </div>
   <div>
    <div>
     <br>
     <table>
      <tbody>
       <tr>
        <td style="font-size: 10pt;">&nbsp;</td>
        <td style="font-size: 10pt; padding-left: 20px; border-left-color: #b42626; border-left-style: solid; border-left-width: 1px;">
         <div> <strong> <span>Olivier Lambert</span> | Vates CEO</strong>
          <br><strong>XCP-ng &amp; Xen Orchestra - </strong>Vates solutions
         </div>
         <div> <strong>w:</strong>&nbsp;vates.fr&nbsp;| xcp-ng.org | xen-orchestra.com
         </div>
         <div>
          <img style="width: 187px;" src="cid:x-disclaimer995950824-1649676101988.png@bm-disclaimer">
         </div> </td>
       </tr>
      </tbody>
     </table>
    </div>
   </div>
  </div>
 <img src="https://mandrillapp.com/track/open.php?u=30504962&id=ee643d67f5814913871557baab52452d" height="1" width="1"></body>
</html>

--_av-fNQMrDGMxCVo0tfXUaPOPw
Content-Type: image/png
Content-Transfer-Encoding: base64
Content-Id: <x-disclaimer995950824-1649676101988.png@bm-disclaimer>
Content-Disposition: inline

/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB
AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/
2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB
AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA
HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF
BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK
FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1
dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG
x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB
AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC
AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom
JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE
hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU
1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA
CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo
AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR
8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0
nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7
9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq
rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8
F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+
Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5
+GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS
b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL
iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m
J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/
4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B
axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8
Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W
0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+
7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4
S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM
fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN
iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+
JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL
QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3
aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8
M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm
sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e
Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/
j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/
hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f
Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL
hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8
HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI
/wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt
y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r
7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3
hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia
2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT
jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW
KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x
D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9
/p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP
DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx
XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT
6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A
BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F
tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt
X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI
re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb
9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv
F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ
pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88
KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf
izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM
77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8
e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7
i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4
ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4
P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD
4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4
ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01
8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet
R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq
/wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n
dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M
vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8
SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y
+NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67
SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW
krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI
Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n
/Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP
A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX
uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d
yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa
fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm
8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt
Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D
fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN
PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD
vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc
oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf
EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg
uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS
0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K
U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if
xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60
qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A
wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj
BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z
B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z
3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5
Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz
AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx
7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8
vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44
+IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v
+/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb
AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3
uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq
XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx
fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0
Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr
W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340
fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4
Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn
/BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G
o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38
KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/
jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2
mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr
HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm
3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh
h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U
YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD
adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun
RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF
43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt
4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7
G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH
ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP
2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju
FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94
uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr
IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+
J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21
OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3
/g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0
r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ
D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox
8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w
dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T
vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A
g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe
0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v
14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S
8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+
BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/
AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/
sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X
WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G
n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T
wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4
M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW
iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy
/wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr
S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd
+wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv
CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E
T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i
Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e
aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR
8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg
v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp
YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/
BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT
NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b
jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk
0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf
oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua
VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ
88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS
tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr
5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6
Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6
RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx
mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC
EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/
Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F
PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT
w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc
PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7
sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU
qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD
GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU
AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF
0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF
Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+
GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo
0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv
tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740
xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a
eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT
zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n
XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h
ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl
Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4
YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k
P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK
HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez
wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl
0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH
x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd
oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u
0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc
pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i
C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm
qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV
v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u
WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2
fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x
A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT
i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5
rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD
xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP
X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l
/q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6
WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL
EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw
fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB
p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin
JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU
62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF
AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7
694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY
vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k
Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv
jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH
XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el
OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/
BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L
+E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt
L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW
8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw
2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+
HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G
0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad
pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD
e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If
GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP
4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh
qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4
NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2
/wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0
1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI
8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+
Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy
3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy
2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8
RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW
SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp
ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv
FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv
ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz
B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe
NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74
meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r
Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR
oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl
kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0
nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ
JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO
nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI
pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT
lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K
Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un
jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q
jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J
wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV
cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1
W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs
8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY
PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx
mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay
NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i
gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N
ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX
rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0
H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p
1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj
MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy
OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx
/tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM
n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/
2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn
LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH
/wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd
5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun
XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ
uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9
6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf
C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c
yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A
qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM
SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr
8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV
lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL
/wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W
G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz
ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b
+GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w
9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B
ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k
mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS
qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf
XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815
60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr
xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl
nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft
RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3
s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE
jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690
H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM
NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj
7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs
ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1
ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4
nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG
4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD
3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A
HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd
anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ
hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj
TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm
IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS
P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh
6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q
Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8
T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj
G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw
mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr
xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v
VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC
61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+
ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR
OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5
TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf
8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v
wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh
Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM
2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44
YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3
KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e
PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx
Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf
gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg
AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu
PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+
WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G
/CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr
CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y
RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze
Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+
TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt
Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+
WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP
ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If
iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng
sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/
B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1
JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV
8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P
4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9
u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ
8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u
eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1
K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO
eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB
ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK
FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL
8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj
5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg
oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0
FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7
f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX
PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km
22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/
sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL
L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND
COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ
qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+
wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp
6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm
ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy
n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj
Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB
Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/
AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7
fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u
1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu
XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR
1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0
n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd
8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS
lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV
ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU
j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O
I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw
0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN
3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k
z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1
tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY
B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj
KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s
XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN
bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7
rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w
R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr
9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl
UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG
NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm
FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc
/tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy
zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+
ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U
3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl
gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE
ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt
WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi
Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9
bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl
ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR
pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh
2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z
NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo
3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp
utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj
Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB
ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST
gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N
PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0
7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0
cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa
jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA
CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV
5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV
xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq
5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx
A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl
B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/
FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I
7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC
m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/
4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli
x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP
tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8
PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K
3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6
nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs
1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA
FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej
7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm
eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+
D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi
lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf
Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs
6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z
1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP
2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r
T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp
q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M
XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3
HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7
u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT
ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP
rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf
i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh
a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O
pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp
08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj
XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG
MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q
ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2
R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+
P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i
xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax
vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF
Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk
Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP
82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb
LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA
CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo
AKACgD//2Q==

--_av-fNQMrDGMxCVo0tfXUaPOPw--

--_av-Wn4-HBU4NEOJIpFTAZy3sA--



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 11:24:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 11:24:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303001.516953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nds9X-0007mH-P1; Mon, 11 Apr 2022 11:24:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303001.516953; Mon, 11 Apr 2022 11:24:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nds9X-0007mA-M2; Mon, 11 Apr 2022 11:24:15 +0000
Received: by outflank-mailman (input) for mailman id 303001;
 Mon, 11 Apr 2022 11:24:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3hqm=UV=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nds9W-0007m2-EX
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 11:24:14 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id e9b48e87-b989-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 13:24:12 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 140A9150C;
 Mon, 11 Apr 2022 04:24:12 -0700 (PDT)
Received: from [10.57.8.177] (unknown [10.57.8.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6406C3F5A1;
 Mon, 11 Apr 2022 04:24:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9b48e87-b989-11ec-a405-831a346695d4
Message-ID: <d5965b70-a7da-a22a-2977-15445187d3ff@arm.com>
Date: Mon, 11 Apr 2022 13:24:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V4 2/2] xen/arm: Add i.MX lpuart early printk support
Content-Language: en-US
To: Julien Grall <julien@xen.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
 sstabellini@kernel.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220408140932.17968-1-peng.fan@oss.nxp.com>
 <20220408140932.17968-3-peng.fan@oss.nxp.com>
 <62e62ea5-0286-7e34-efab-66f0e51afeda@arm.com>
 <dea7a276-867a-df02-8584-0433fd5f3910@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <dea7a276-867a-df02-8584-0433fd5f3910@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Julien,

On 11.04.2022 12:23, Julien Grall wrote:
> Hi,
> 
> On 11/04/2022 07:24, Michal Orzel wrote:
>> On 08.04.2022 16:09, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>>   xen/arch/arm/Kconfig.debug              | 14 +++++++
>>>   xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 +++++++++++++++++++++++++
>>>   2 files changed, 66 insertions(+)
>>>   create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
>>>
>>> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
>>> index 35ccd13273..842d768280 100644
>>> --- a/xen/arch/arm/Kconfig.debug
>>> +++ b/xen/arch/arm/Kconfig.debug
>>> @@ -58,6 +58,16 @@ choice
>>>               This option is preferred over the platform specific
>>>               options; the platform specific options are deprecated
>>>               and will soon be removed.
>>> +    config EARLY_UART_CHOICE_IMX_LPUART
>>> +        select EARLY_UART_IMX_LPUART
>>> +        depends on ARM_64
>>> +        bool "Early printk via i.MX LPUART"
>>> +        help
>>> +            Say Y here if you wish the early printk to direct their
>>> +            output to a i.MX LPUART. You can use this option to
>>> +            provide the parameters for the i.MX LPUART rather than
>>> +            selecting one of the platform specific options below if
>>> +            you know the parameters for the port.
>>>       config EARLY_UART_CHOICE_MESON
>>>           select EARLY_UART_MESON
>>>           depends on ARM_64
>>> @@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
>>>   config EARLY_UART_EXYNOS4210
>>>       select EARLY_PRINTK
>>>       bool
>>> +config EARLY_UART_IMX_LPUART
>>> +    select EARLY_PRINTK
>>> +    bool
>>>   config EARLY_UART_MESON
>>>       select EARLY_PRINTK
>>>       bool
>>> @@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
>>>       default "debug-8250.inc" if EARLY_UART_8250
>>>       default "debug-cadence.inc" if EARLY_UART_CADENCE
>>>       default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
>>> +    default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
>>>       default "debug-meson.inc" if EARLY_UART_MESON
>>>       default "debug-mvebu.inc" if EARLY_UART_MVEBU
>>>       default "debug-pl011.inc" if EARLY_UART_PL011
>>> diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
>>> new file mode 100644
>>> index 0000000000..f68252da86
>>> --- /dev/null
>>> +++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
>>> @@ -0,0 +1,52 @@
>>> +/*
>>> + * xen/arch/arm/arm64/debug-imx-lpuart.inc
>>> + *
>>> + * i.MX8QM specific debug code
>>> + *
>>> + * Peng Fan <peng.fan@nxp.com>
>>> + * Copyright 2022 NXP
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +
>>> +#include <asm/imx-lpuart.h>
>>> +
>>> +.macro early_uart_init wb wc wd
>>> +/* Already initialized in bootloader */
>>> +.endm
>>> +
>> FWICS, early_uart_init call is protected with CONFIG_EARLY_UART_INIT that is set
>> only for PL011 UART. So I think there is no need to implement this empty macro,
>> unless we want to keep the same macros across the files no matter whether in use or not.
>> I think you need to ask Julien.
> 
> The call to early_uart_init is indeed protected by #ifdef CONFIG_EARLY_UART_INIT. The goal was to avoid having all debug-*.inc to implement dummy helper.
> 
> So I would prefer if early_uart_init is not implemented for debug-imx-lpuart.inc.
> 
> Cheers,
> 

I agree.
As a side note, do we still need to support platform specific options for early printk?
If not, I am happy to send a patch removing them.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 11:31:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 11:31:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303006.516964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsGH-0000pr-FV; Mon, 11 Apr 2022 11:31:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303006.516964; Mon, 11 Apr 2022 11:31:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsGH-0000pk-CY; Mon, 11 Apr 2022 11:31:13 +0000
Received: by outflank-mailman (input) for mailman id 303006;
 Mon, 11 Apr 2022 11:31:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ndsGF-0000pe-Lc
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 11:31:11 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2061f.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::61f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d9eea6e3-b98a-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 13:30:55 +0200 (CEST)
Received: from AM5PR0601CA0078.eurprd06.prod.outlook.com (2603:10a6:206::43)
 by AS8PR08MB6725.eurprd08.prod.outlook.com (2603:10a6:20b:394::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 11:30:59 +0000
Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:0:cafe::44) by AM5PR0601CA0078.outlook.office365.com
 (2603:10a6:206::43) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 11:30:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 11:30:58 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Mon, 11 Apr 2022 11:30:58 +0000
Received: from ef06a58dce58.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C952D9AF-0FBD-4819-8F38-F04FD74C3114.1; 
 Mon, 11 Apr 2022 11:30:47 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ef06a58dce58.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 11:30:47 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by DB6PR0801MB2085.eurprd08.prod.outlook.com (2603:10a6:4:79::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 11:30:44 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 11:30:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9eea6e3-b98a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FTDKUHAUpe+/waBVD5kYEvtJYo45vb9UncZiq8/VLcM=;
 b=Gi7QP5CrQMtZ2Au3m+3JKwagYAAu5IJtfu1S6vGaJ4clyx9TYto8cQbG62a6fqeJWfdqv4as0Z6SxtrBItk3RQ7FYdzwitV7jlhgx83pCnAk+V6QmzI/pS1RHccKZOVRH0TPXkssMxjxcFjQd2uPzbyxL7QTD1ZXFnKCoTxfhuo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 63ff32b3a0a88684
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NyCUH3MZhZkY9graTjH/SoAFTORIJ0PjeCWG/8BmTid0bt26AB4pkUoVhO1c/EZ84nbQVJxgw64CbXQS0DNrbuAE1RJLOzHW8qZopQ2GOpD9RqFSpKmAwVEFL38IJcVoWLDHoFP7oF56xT/fB61AVljEZIToUg9vKRz9etJDJCdWiu31v+U1wJjZktyuA9L46XntJbMfN3TMD/NNlGvSLEV1PELqHae+zPtLG1lwFbxKmfdKRMDL5bv4ZKx8/pi00ghZoQMJ/kM7e3EjosKtR9UNJ/kGPdEhxL97EvCD9womsZQHrzx96O4+wIAVNTw/AuN9DnFb0gLVxho9ViB2mQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FTDKUHAUpe+/waBVD5kYEvtJYo45vb9UncZiq8/VLcM=;
 b=Vvw6yLzw034r39HtwzESRCfsPHznAeYZz22Ewkx+twGZTzKivTpR3b/Zzz1zUSvgHiTkmzfkC6uBnlrcKqm+vEfrB609U+fyV3WMLr6N0VsY863QckhAonMMZwNUsfbUVeOq9h28w03TW64mDbPjU0427DgFnmWuXZBie5wy8jcOpSoq4hwzbXbAzZdFtrFWGeylpIpgoKViu6+gwFB7bskVfpH9/oOyyvd9fsq/vfOqoNdsf+z9MEePk4/Kyj+JPBvg/DwpVhL7G3z1PHB3sunDUnRbv0NSv/RpsHh2ZOEz9123UegZv9AHGF3YY9J3eUHF7lVmig5BAW5mG8oNtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FTDKUHAUpe+/waBVD5kYEvtJYo45vb9UncZiq8/VLcM=;
 b=Gi7QP5CrQMtZ2Au3m+3JKwagYAAu5IJtfu1S6vGaJ4clyx9TYto8cQbG62a6fqeJWfdqv4as0Z6SxtrBItk3RQ7FYdzwitV7jlhgx83pCnAk+V6QmzI/pS1RHccKZOVRH0TPXkssMxjxcFjQd2uPzbyxL7QTD1ZXFnKCoTxfhuo=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, Dario Faggioli
	<dfaggioli@suse.com>
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
Thread-Index: AQHYSyUg2T6WkJDiXECW3myZV3L//qzqj+GAgAAI/AA=
Date: Mon, 11 Apr 2022 11:30:42 +0000
Message-ID: <16C126D9-18EF-440E-BD84-6D5028BFE879@arm.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <a052e26c-2142-bf51-bc80-449476ed0854@xen.org>
In-Reply-To: <a052e26c-2142-bf51-bc80-449476ed0854@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: dd8bf365-b364-4bbd-eea5-08da1baebffc
x-ms-traffictypediagnostic:
	DB6PR0801MB2085:EE_|VE1EUR03FT022:EE_|AS8PR08MB6725:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB672597B57CFF24C424A6523AE4EA9@AS8PR08MB6725.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5rg7XSuNyQ5vkKcrveuPJzsBfdnYj/AJHULJiyktrdaEoX3CK3VsluszViIpLF97XLvr+3YT8Z8T4fDBOscljFCCpibcZatyOKdftpqlDxbid0x5IR9bdjZSjlaAhFiNeydSHuuxZq4KSm/JeF7juQqm6njE0q7/1AAgiBVRwSq0kNamC/sJ5Wa+Uy9lSIsZusQBta5FCyb47Asp7/hfXqR8cCkZh2r7ivxIKPWPgGYmHKARBaoQszaZljhNDU+D9ozJ3E4u08kYOYg2KhXa38WSqBsEHnScuYne9ybWcmwbGUd2u0+yJN0dXVH+xSo/Lo0LJGAOqjHrQeWDv6ZWXsiWASqZPGkgLj/OMdpjBUJ25zQEGfbDjetabBWW9ZnEXAN07LwPt8i0Qvxxgm/r60qKX/vN9OpD6DXX2jvD7fMb4CUWQWQuZrtpTjw73ml/ISVt0CR2ih2Uig+od+hI6+dwlmXYQKeiXaoPXoRXm7Mhktucmp2Quxa2Yg87JS3KZhsXDHoDqWUjErsjfy/H5Khr31Ij2Kvl7aHNVdHOGGP2xrPH+u9Yl9NTzCG4hzH/sofEimkFVItiDuGFtFA1UfWX2N7Bv+HmJMaD6andEkTcuikizgxtzmFhCjBbMiUPnUo94kzkFkka7BkIO35e+qk4AaOF9J5U6nbhZ3Vc/N8c6i65nuTIqbEY+EwSbZD3MF77zwA3Htg5dcSB1q/fHehrOFeNP5qYp1IGC3eT628g6ZaQrRc7o7op6eMBhQss
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(55236004)(6506007)(53546011)(5660300002)(7416002)(26005)(33656002)(83380400001)(8936002)(186003)(6512007)(2616005)(36756003)(6916009)(54906003)(86362001)(508600001)(66556008)(76116006)(66446008)(66946007)(64756008)(66476007)(91956017)(4326008)(6486002)(8676002)(38070700005)(71200400001)(38100700002)(122000001)(316002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <6F08BFEDB51A7B49B91442FE628F69C2@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2085
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2c64d040-ee15-464e-7ce0-08da1baeb6e0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3+6yE7jZAGWUZZpanqzxpaBkJ7nOiMZOw8apDIg8I2JObbkd0fLw4WQTXJ+Uk2+JCouJRt7ggB29lvCkW+fxgGq9ZBa4FKt3ladXH2TtChIZvhPhDYUyPRzBZ9A21UPBEBD1KDP33zHhOlGZchJVT493W0IQ9T4Y6gos+ualvUxXU8kSYrfCJ/eMUtfAtEI3OC2KYygptSgGqOkVbzhg5wcadycuqkqnTnM6B7L1ltUwhkWuxeISm5l9LBsNqOZYGMDxxQ//GBGIwRy92fin7Uz0X5ILKC7DDh25aNvoEi2RR2Z3aH8tbUGR1u3AQfHZLyiLjrskfp8BJkJK8IgRWumR8Qhurhsy7m431TZ8zQq6zceQn6khV7esHol3HLyzXX3OiTm/38zC9zorTvmdx7TGlI4DJjAFWqPg8JPdc/dbGJEP60yAqWAuHp2PioGm31kWLgsKm8evYbJTRfQq6ku8WZoh7pwuhnqyNaoywU8rD0ea2I/ofhBh8TgcjvFE+66QL1mP5hIH/0us8ezdhs290pLo2E1GKvoV/F2gPc+SU0dzWTQObDH/xS6V5RRxXYAR0+5Unn/zoVd0xsRKeFX2ADTArUtnZLiFVAB/lIAM0vUn0n0mjMhEkD6CTvY3hdHJIPNwLOYPN2BzMsaGMPseec19bfAMhL/OrBZrdnOh/MLdj75OlqS6L8knwcuS
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(8676002)(81166007)(70206006)(70586007)(2906002)(356005)(5660300002)(8936002)(316002)(4326008)(2616005)(6506007)(6862004)(86362001)(53546011)(6512007)(83380400001)(47076005)(6486002)(336012)(186003)(40460700003)(54906003)(508600001)(107886003)(36860700001)(33656002)(82310400005)(36756003)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 11:30:58.4187
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dd8bf365-b364-4bbd-eea5-08da1baebffc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6725

DQoNCj4gT24gMTEgQXByIDIwMjIsIGF0IDExOjU4LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u
b3JnPiB3cm90ZToNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPiBPbiAwOC8wNC8yMDIyIDA5OjQ1LCBM
dWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4gZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy9hcm0vZGV2aWNl
LXRyZWUvY3B1cG9vbHMudHh0IGIvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9jcHVwb29scy50
eHQNCj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAwMDAwMDAwMDAwMDAuLjQwY2M4
MTM1YzY2Zg0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIvZG9jcy9taXNjL2FybS9kZXZpY2Ut
dHJlZS9jcHVwb29scy50eHQNCj4+IEBAIC0wLDAgKzEsMTQwIEBADQo+PiArQm9vdCB0aW1lIGNw
dXBvb2xzDQo+PiArPT09PT09PT09PT09PT09PT09DQo+PiArDQo+PiArV2hlbiBCT09UX1RJTUVf
Q1BVUE9PTFMgaXMgZW5hYmxlZCBpbiB0aGUgWGVuIGNvbmZpZ3VyYXRpb24sIGl0IGlzIHBvc3Np
YmxlIHRvDQo+PiArY3JlYXRlIGNwdXBvb2xzIGR1cmluZyBib290IHBoYXNlIGJ5IHNwZWNpZnlp
bmcgdGhlbSBpbiB0aGUgZGV2aWNlIHRyZWUuDQo+PiArQUNQSSBpcyBub3Qgc3VwcG9ydGVkIGZv
ciB0aGlzIGZlYXR1cmUuDQo+PiArDQo+PiArQ3B1cG9vbHMgc3BlY2lmaWNhdGlvbiBub2RlcyBz
aGFsbCBiZSBkaXJlY3QgY2hpbGRzIG9mIC9jaG9zZW4gbm9kZS4NCj4+ICtFYWNoIGNwdXBvb2wg
bm9kZSBjb250YWlucyB0aGUgZm9sbG93aW5nIHByb3BlcnRpZXM6DQo+PiArDQo+PiArLSBjb21w
YXRpYmxlIChtYW5kYXRvcnkpDQo+PiArDQo+PiArICAgIE11c3QgYWx3YXlzIGluY2x1ZGUgdGhl
IGNvbXBhdGlibGl0eSBzdHJpbmc6ICJ4ZW4sY3B1cG9vbCIuDQo+PiArDQo+PiArLSBjcHVwb29s
LWNwdXMgKG1hbmRhdG9yeSkNCj4+ICsNCj4+ICsgICAgTXVzdCBiZSBhIGxpc3Qgb2YgZGV2aWNl
IHRyZWUgcGhhbmRsZSB0byBub2RlcyBkZXNjcmliaW5nIGNwdXMgKGUuZy4gaGF2aW5nDQo+PiAr
ICAgIGRldmljZV90eXBlID0gImNwdSIpLCBpdCBjYW4ndCBiZSBlbXB0eS4NCj4+ICsNCj4+ICst
IGNwdXBvb2wtc2NoZWQgKG9wdGlvbmFsKQ0KPj4gKw0KPj4gKyAgICBNdXN0IGJlIGEgc3RyaW5n
IGhhdmluZyB0aGUgbmFtZSBvZiBhIFhlbiBzY2hlZHVsZXIuIENoZWNrIHRoZSBzY2hlZD08Li4u
Pg0KPj4gKyAgICBib290IGFyZ3VtZW50IGZvciBhbGxvd2VkIHZhbHVlcyBbMV0uIFdoZW4gdGhp
cyBwcm9wZXJ0eSBpcyBvbWl0dGVkLCB0aGUgWGVuDQo+PiArICAgIGRlZmF1bHQgc2NoZWR1bGVy
IHdpbGwgYmUgdXNlZC4NCj4+ICsNCj4+ICsNCj4+ICtDb25zdHJhaW50cw0KPj4gKz09PT09PT09
PT09DQo+PiArDQo+PiArSWYgbm8gY3B1cG9vbHMgYXJlIHNwZWNpZmllZCwgYWxsIGNwdXMgd2ls
bCBiZSBhc3NpZ25lZCB0byBvbmUgY3B1cG9vbA0KPj4gK2ltcGxpY2l0bHkgY3JlYXRlZCAoUG9v
bC0wKS4NCj4+ICsNCj4+ICtJZiBjcHVwb29scyBub2RlIGFyZSBzcGVjaWZpZWQsIGJ1dCBub3Qg
ZXZlcnkgY3B1IGJyb3VnaHQgdXAgYnkgWGVuIGlzIGFzc2lnbmVkLA0KPj4gK2FsbCB0aGUgbm90
IGFzc2lnbmVkIGNwdSB3aWxsIGJlIGFzc2lnbmVkIHRvIGFuIGFkZGl0aW9uYWwgY3B1cG9vbC4N
Cj4+ICsNCj4+ICtJZiBhIGNwdSBpcyBhc3NpZ25lZCB0byBhIGNwdXBvb2wsIGJ1dCBpdCdzIG5v
dCBicm91Z2h0IHVwIGNvcnJlY3RseSwgWGVuIHdpbGwNCj4+ICtzdG9wLg0KPj4gKw0KPj4gK1Ro
ZSBib290IGNwdSBtdXN0IGJlIGFzc2lnbmVkIHRvIFBvb2wtMCwgc28gdGhlIGNwdXBvb2wgY29u
dGFpbmluZyB0aGF0IGNvcmUNCj4+ICt3aWxsIGJlY29tZSBQb29sLTAgYXV0b21hdGljYWxseS4N
Cj4+ICsNCj4+ICsNCj4+ICtFeGFtcGxlcw0KPj4gKz09PT09PT09DQo+PiArDQo+PiArQSBzeXN0
ZW0gaGF2aW5nIHR3byB0eXBlcyBvZiBjb3JlLCB0aGUgZm9sbG93aW5nIGRldmljZSB0cmVlIHNw
ZWNpZmljYXRpb24gd2lsbA0KPj4gK2luc3RydWN0IFhlbiB0byBoYXZlIHR3byBjcHVwb29sczoN
Cj4+ICsNCj4+ICstIFRoZSBjcHVwb29sIHdpdGggaWQgMCB3aWxsIGhhdmUgNCBjcHVzIGFzc2ln
bmVkLg0KPj4gKy0gVGhlIGNwdXBvb2wgd2l0aCBpZCAxIHdpbGwgaGF2ZSAyIGNwdXMgYXNzaWdu
ZWQuDQo+IA0KPiBBRkFJSywgdGhlcmUgYXJlIG5vIGd1YXJhbnRlZSB0aGF0IFhlbiB3aWxsIHBh
cnNlIGNwdXBvb2xfYSBmaXJzdC4gU28gaXQgd291bGQgYmUgcG9zc2libGUgdGhhdCB0aGUgSUQg
YXJlIGludmVydGVkIGhlcmUuDQo+IA0KPiBUaGlzIGNvdWxkIGhhcHBlbiBpZiB5b3Ugd2FudCB0
byBrZWVwIHRoZSBib290IENQVSBpbiBwb29sIDAgYW5kIGl0IGlzIG5vdCBjcHVAMCAoc29tZSBi
b290bG9hZGVycyBhbGxvd3MgeW91IHRvIGNoYW5nZSB0aGUgYm9vdCBDUFUpLg0KDQpIaSBKdWxp
ZW4sDQoNClllcyBJIHdpbGwgc3BlY2lmeSB0aGF0IHRoZSBib290IGNwdSBpcyBsaXN0ZWQgaW4g
Y3B1cG9vbF9hLCBzbyB0aGF0IGNwdXBvb2wgd2lsbCBoYXZlIGlkIDAgcmVnYXJkbGVzcyBvZiB0
aGUgcGFyc2luZyBvcmRlci4NCg0KPiANCj4gQWxzbywgaGVyZSB5b3Ugd3JpdGUgIlRoZSBjcHVw
b29sIHdpdGggaWQgWCIgYnV0IC4uLg0KPiANCj4+ICtBIHN5c3RlbSBoYXZpbmcgdGhlIGNwdXBv
b2xzIHNwZWNpZmljYXRpb24gYmVsb3cgd2lsbCBpbnN0cnVjdCBYZW4gdG8gaGF2ZSB0aHJlZQ0K
Pj4gK2NwdXBvb2xzOg0KPj4gKw0KPj4gKy0gVGhlIGNwdXBvb2wgUG9vbC0wIHdpbGwgaGF2ZSAy
IGNwdXMgYXNzaWduZWQuDQo+PiArLSBUaGUgY3B1cG9vbCBQb29sLTEgd2lsbCBoYXZlIDIgY3B1
cyBhc3NpZ25lZC4NCj4+ICstIFRoZSBjcHVwb29sIFBvb2wtMiB3aWxsIGhhdmUgMiBjcHVzIGFz
c2lnbmVkIChjcmVhdGVkIGJ5IFhlbiB3aXRoIGFsbCB0aGUgbm90DQo+PiArICBhc3NpZ25lZCBj
cHVzIGE1M18zIGFuZCBhNTNfNCkuDQo+IA0KPiBoZXJlIHlvdSB3cml0ZSAiVGhlIGNwdXBvb2wg
UG9vbC1YIi4gQ2FuIHlvdSBiZSBjb25zaXN0ZW50Pw0KDQpTdXJlLCBkbyB5b3UgaGF2ZSBhIHBy
ZWZlcmVuY2UgYmV0d2VlbiDigJxUaGUgY3B1cG9vbCB3aXRoIGlkIFjigJ0gYW5kIOKAnFBvb2wt
WOKAnT8gT3RoZXJ3aXNlIEkgd291bGQgZ28gZm9yIFBvb2wtWCBldmVyeXdoZXJlLg0KDQo+IA0K
PiBPbiBhIHNlcGFyYXRlIHRvcGljLCBJIHRoaW5rIGRvbTBfbWF4X3ZjcHVzKCkgbmVlZHMgdG8g
YmUgdXBkYXRlZCB0byBieSBkZWZhdWx0IChpLmUgd2hlbiBvcHRfZG9tMF9tYXhfdmNwdXMgPT0g
MCkgdGhlIG51bWJlciBvZiB2Q1BVcyBtYXRjaCB0aGUgbnVtYmVyIG9mIHZDUFVzIGluIHRoZSBj
cHVwb29sIChJIHRoaW5rIDApIHVzZWQgdG8gY3JlYXRlZCBkb20wLg0KDQpZZXMgcmlnaHQsIEkg
ZGlkbuKAmXQgdGhpbmsgYWJvdXQgdGhhdCwgSSB0aGluayB0aGUgY2hhbmdlIGNvdWxkIGJlIHNv
bWV0aGluZyBsaWtlIHRoYXQ6DQoNCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1
aWxkLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCmluZGV4IDljNjdhNDgzZDRhNC4u
OTc4NzEwNGMzZDMxIDEwMDY0NA0KLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQor
KysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCkBAIC03Myw3ICs3MywxMCBAQCBjdXN0
b21fcGFyYW0oImRvbTBfbWVtIiwgcGFyc2VfZG9tMF9tZW0pOw0KIHVuc2lnbmVkIGludCBfX2lu
aXQgZG9tMF9tYXhfdmNwdXModm9pZCkNCiB7DQogICAgIGlmICggb3B0X2RvbTBfbWF4X3ZjcHVz
ID09IDAgKQ0KLSAgICAgICAgb3B0X2RvbTBfbWF4X3ZjcHVzID0gbnVtX29ubGluZV9jcHVzKCk7
DQorICAgIHsNCisgICAgICAgIEFTU0VSVChjcHVwb29sMCk7DQorICAgICAgICBvcHRfZG9tMF9t
YXhfdmNwdXMgPSBjcHVtYXNrX3dlaWdodChjcHVwb29sX3ZhbGlkX2NwdXMoY3B1cG9vbDApKTsN
CisgICAgfQ0KICAgICBpZiAoIG9wdF9kb20wX21heF92Y3B1cyA+IE1BWF9WSVJUX0NQVVMgKQ0K
ICAgICAgICAgb3B0X2RvbTBfbWF4X3ZjcHVzID0gTUFYX1ZJUlRfQ1BVUzsNCg0KQW5kIGlmIHlv
dSBhZ3JlZSBJIHdpbGwgaW5jbHVkZSB0aGUgY2hhbmdlcyBmb3IgdGhlIHY3Lg0KDQpDaGVlcnMs
DQpMdWNhDQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 11:31:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 11:31:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303007.516974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsGZ-0001Dy-NW; Mon, 11 Apr 2022 11:31:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303007.516974; Mon, 11 Apr 2022 11:31:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsGZ-0001Dr-KY; Mon, 11 Apr 2022 11:31:31 +0000
Received: by outflank-mailman (input) for mailman id 303007;
 Mon, 11 Apr 2022 11:31:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndsGX-0001Bz-O4; Mon, 11 Apr 2022 11:31:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndsGX-0004zY-Kk; Mon, 11 Apr 2022 11:31:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndsGX-00068i-9n; Mon, 11 Apr 2022 11:31:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndsGX-0007zm-9N; Mon, 11 Apr 2022 11:31:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t4H3s9IEvoWTQG2kWUfEPuU3oGMu7IKwqYRyY4GkLxE=; b=Pv/nMappCT5l+buBZTAiT6nZle
	6mY03kywj/nOV4tIZCL4LuUUp1C50FWlj+p2TuW9vOdHf79pekIz8+WiV/xuucb/lNgoAotQwQfRx
	3/0S2Xs7vYVRGRx2RE8TNuYDGBuRuUCUhG6e7132lxmmec56i5RK4uP254No0u6JxHVE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169294-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169294: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
X-Osstest-Versions-That:
    linux=8b57b3046107b50ebecb65537a172ef3d6cec673
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 11:31:29 +0000

flight 169294 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169294/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169286
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169286
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169286
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169286
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169286
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169286
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169286
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169286
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
baseline version:
 linux                8b57b3046107b50ebecb65537a172ef3d6cec673

Last test of basis   169286  2022-04-10 21:09:47 Z    0 days
Testing same since   169294  2022-04-11 03:37:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   8b57b3046107..ce522ba9ef7e  ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 11:40:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 11:40:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303021.516986 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsPW-0002zN-PS; Mon, 11 Apr 2022 11:40:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303021.516986; Mon, 11 Apr 2022 11:40:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsPW-0002z0-L9; Mon, 11 Apr 2022 11:40:46 +0000
Received: by outflank-mailman (input) for mailman id 303021;
 Mon, 11 Apr 2022 11:40:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndsPV-0002yp-Cm; Mon, 11 Apr 2022 11:40:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndsPV-00059E-B0; Mon, 11 Apr 2022 11:40:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndsPU-0006Lj-Rs; Mon, 11 Apr 2022 11:40:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndsPU-0001rQ-RQ; Mon, 11 Apr 2022 11:40:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=89uOy8Su9SQnaNL2GVKI22/geDA2LBFT07BxRL6qEbk=; b=DJdTQaORloZTeBqP8aJDwJ/3Uf
	DUpvSLL5eTEGJq1VtZogDOcMfihU1+V6o9a8qs04ECnJvn6b/Qht+mHwbgg9q87KgKybm7edLHD2f
	oQUu3Ntge0b6zOX4kWVDVJIXHEZl6rnMmYN83Pe1doMXt2NbCiCtPgv1JYnYGILV0tN4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169305-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169305: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 11:40:44 +0000

flight 169305 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169305/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  323 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 11:42:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 11:42:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303031.516996 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsRR-0003gH-4d; Mon, 11 Apr 2022 11:42:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303031.516996; Mon, 11 Apr 2022 11:42:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsRR-0003gA-1m; Mon, 11 Apr 2022 11:42:45 +0000
Received: by outflank-mailman (input) for mailman id 303031;
 Mon, 11 Apr 2022 11:42:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndsRP-0003g4-Nw
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 11:42:43 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndsRP-0005B5-EB; Mon, 11 Apr 2022 11:42:43 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndsRP-0007a4-7e; Mon, 11 Apr 2022 11:42:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=oVb6dRkYhQlrClg75ZYhW/lxErBNYymBP+O4sMApSus=; b=eCHDCkjUMuEFdd8OHzWwKvk0SO
	rva+AQrNIlvqGf1cO4IT8IHeMp5DHMVbJdvvnwUTf1ButPhSflfyEOeg9oLXrt1jzYjcpGsV++sD4
	/1sZMBtRAV7v2rRBUbUXdengZaDdX2AaIWeGfAiSReIQp6UUjwR6U7yKqg4JGwkq7LIs=;
Message-ID: <201915c1-7f2a-1c75-ccd0-f096cb3ad2ad@xen.org>
Date: Mon, 11 Apr 2022 12:42:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot
 time
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Dario Faggioli <dfaggioli@suse.com>
References: <20220408084517.33082-1-luca.fancellu@arm.com>
 <20220408084517.33082-5-luca.fancellu@arm.com>
 <a052e26c-2142-bf51-bc80-449476ed0854@xen.org>
 <16C126D9-18EF-440E-BD84-6D5028BFE879@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <16C126D9-18EF-440E-BD84-6D5028BFE879@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Luca,

On 11/04/2022 12:30, Luca Fancellu wrote:
>> On 11 Apr 2022, at 11:58, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Luca,
>>
>> On 08/04/2022 09:45, Luca Fancellu wrote:
>>> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
>>> new file mode 100644
>>> index 000000000000..40cc8135c66f
>>> --- /dev/null
>>> +++ b/docs/misc/arm/device-tree/cpupools.txt
>>> @@ -0,0 +1,140 @@
>>> +Boot time cpupools
>>> +==================
>>> +
>>> +When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
>>> +create cpupools during boot phase by specifying them in the device tree.
>>> +ACPI is not supported for this feature.
>>> +
>>> +Cpupools specification nodes shall be direct childs of /chosen node.
>>> +Each cpupool node contains the following properties:
>>> +
>>> +- compatible (mandatory)
>>> +
>>> +    Must always include the compatiblity string: "xen,cpupool".
>>> +
>>> +- cpupool-cpus (mandatory)
>>> +
>>> +    Must be a list of device tree phandle to nodes describing cpus (e.g. having
>>> +    device_type = "cpu"), it can't be empty.
>>> +
>>> +- cpupool-sched (optional)
>>> +
>>> +    Must be a string having the name of a Xen scheduler. Check the sched=<...>
>>> +    boot argument for allowed values [1]. When this property is omitted, the Xen
>>> +    default scheduler will be used.
>>> +
>>> +
>>> +Constraints
>>> +===========
>>> +
>>> +If no cpupools are specified, all cpus will be assigned to one cpupool
>>> +implicitly created (Pool-0).
>>> +
>>> +If cpupools node are specified, but not every cpu brought up by Xen is assigned,
>>> +all the not assigned cpu will be assigned to an additional cpupool.
>>> +
>>> +If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
>>> +stop.
>>> +
>>> +The boot cpu must be assigned to Pool-0, so the cpupool containing that core
>>> +will become Pool-0 automatically.
>>> +
>>> +
>>> +Examples
>>> +========
>>> +
>>> +A system having two types of core, the following device tree specification will
>>> +instruct Xen to have two cpupools:
>>> +
>>> +- The cpupool with id 0 will have 4 cpus assigned.
>>> +- The cpupool with id 1 will have 2 cpus assigned.
>>
>> AFAIK, there are no guarantee that Xen will parse cpupool_a first. So it would be possible that the ID are inverted here.
>>
>> This could happen if you want to keep the boot CPU in pool 0 and it is not cpu@0 (some bootloaders allows you to change the boot CPU).
> Yes I will specify that the boot cpu is listed in cpupool_a, so that cpupool will have id 0 regardless of the parsing order.

This only covers the case where are two cpupools.

AFAIK, there are no guarantee that Xen will parse the DT or the compiler 
will generate the DT the way you want. So for three cpupools, we still 
don't know which pool will be ID 1/2.

See more below.

> 
>>
>> Also, here you write "The cpupool with id X" but ...
>>
>>> +A system having the cpupools specification below will instruct Xen to have three
>>> +cpupools:
>>> +
>>> +- The cpupool Pool-0 will have 2 cpus assigned.
>>> +- The cpupool Pool-1 will have 2 cpus assigned.
>>> +- The cpupool Pool-2 will have 2 cpus assigned (created by Xen with all the not
>>> +  assigned cpus a53_3 and a53_4).
>>
>> here you write "The cpupool Pool-X". Can you be consistent?
> 
> Sure, do you have a preference between “The cpupool with id X” and “Pool-X”? Otherwise I would go for Pool-X everywhere.

Using "cpupool with ID 0" is definitely wrong. Pool-X is marginally 
better because an admin may think that this name will match what we have 
in Xen.

So I think it would be better to use the node name and mention that 
there are no guarantee in which ID will used by Xen.

> 
>>
>> On a separate topic, I think dom0_max_vcpus() needs to be updated to by default (i.e when opt_dom0_max_vcpus == 0) the number of vCPUs match the number of vCPUs in the cpupool (I think 0) used to created dom0.
> 
> Yes right, I didn’t think about that, I think the change could be something like that:
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 9c67a483d4a4..9787104c3d31 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -73,7 +73,10 @@ custom_param("dom0_mem", parse_dom0_mem);
>   unsigned int __init dom0_max_vcpus(void)
>   {
>       if ( opt_dom0_max_vcpus == 0 )
> -        opt_dom0_max_vcpus = num_online_cpus();
> +    {
> +        ASSERT(cpupool0);
> +        opt_dom0_max_vcpus = cpumask_weight(cpupool_valid_cpus(cpupool0));
> +    }
>       if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
>           opt_dom0_max_vcpus = MAX_VIRT_CPUS;
> 
> And if you agree I will include the changes for the v7.

This should work.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 12:14:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 12:14:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303039.517007 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsvW-0007Eg-NP; Mon, 11 Apr 2022 12:13:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303039.517007; Mon, 11 Apr 2022 12:13:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndsvW-0007EZ-KR; Mon, 11 Apr 2022 12:13:50 +0000
Received: by outflank-mailman (input) for mailman id 303039;
 Mon, 11 Apr 2022 12:13:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndsvV-0007ET-Li
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 12:13:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d7351ba9-b990-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 14:13:48 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-M85w8Hk4NZyAD8B56b1zeg-1; Mon, 11 Apr 2022 14:13:46 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4656.eurprd04.prod.outlook.com (2603:10a6:803:6c::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 12:13:44 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 12:13:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7351ba9-b990-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649679227;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pfltAWvtqebYL/YjpIbHeXdHvY76RQY6YsBcpCchCIU=;
	b=Y73wMxcYGXO5rQo4S+RrCPkn0zKjN0LRgij4sYNChH+iq2zSdv+baNImOGUPki/zPugiX8
	YHNSBYP/JoMlL9TLbroeF8ywq+UKWb6vyNXStMTcLlPctogmjmlfa4F7zBIFE9eqkaaN5M
	D+LKfxVdA0VLDPHsDRccMA+o17M6YOM=
X-MC-Unique: M85w8Hk4NZyAD8B56b1zeg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jYc2t9Ps1dmAe3YeKDPoj4WcLkLvwppHS+1oKwPTS1xzAZVhM/st3VszAtzEHVBoFED2de/RkPRkH4zVM98dohCN+TewVPJy+ZvzRHD1DBHyz0hpugWBMEYw8VcH3vD93524Y69LQhpzT5jCS9oU4iaGw6HZLcoKuXxqHSBIeKdd8YGuyaGVqb0/KdmY/NSwmZKV8XRUDk5aRHoSZJnigyikqe6knVx3bJQs0t0+iJW2qVID8QPzUZBKhFmws1+b30TJ6/SsGvTtODWe58KP8tendR5NQ1S+PY/AarZlCZ5yu+jM0PqkXxgIO4/eCIzRsIhc2VmQAcXJ0/3CurKchA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pfltAWvtqebYL/YjpIbHeXdHvY76RQY6YsBcpCchCIU=;
 b=Dc05SpZpXQtv1Dk5E/XTwNBlyUXUYQq6sCCj6R90rHwJybdsx/pU5gHT7Br1s62EeANLMSRTz/a6YfMVvN11kzmWjRkyCi2fDfwiU0VAPtThYPBRKaT6VxyPIhCRa6OF448MgujYcMWTF2BDMb/nLxfkjDfm5WpDINZ59Y88y43vj5RLnz13Ls286ozqOK+zQmLRJo7fWhXsUM5j3zmxAIHfK05VE4bXcBsByJqH6qjUfP/Xk6iFw2ZtZeTRmw6VNSX0m71OsesOIISyQNTbmL8UJlyo/GmJuN3uXO6HIUSUKQSzf1QMWhPYNnl8zfKrTdvxrgKYPfjiiFP7hNbqqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <87d451fa-b8fa-05fb-1f97-c30a28aaa890@suse.com>
Date: Mon, 11 Apr 2022 14:13:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0fbf06a-be3c-37bd-2abf-599912ad9bf5@suse.com>
 <42d16ff2-725d-ae10-ba6b-561487252125@xen.org>
 <3217803e-16d5-6e2a-bde7-ff9a1237dd39@suse.com>
 <decf721a-8062-a23f-a810-78fb86a42d1d@xen.org>
 <747017ab-9aa9-b958-8cbf-42c2cc3ffdb1@suse.com>
 <0f18eb04-7b39-da75-fcf4-f765d8ea28b1@xen.org>
 <e41da164-7aeb-3d99-ef4d-17c591af7e37@suse.com>
 <afea970d-fe71-5f28-edda-c51e80d6e3d3@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <afea970d-fe71-5f28-edda-c51e80d6e3d3@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0201CA0021.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 147b8760-1ea2-4176-d59b-08da1bb4b912
X-MS-TrafficTypeDiagnostic: VI1PR04MB4656:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB465606D4399A5D372118FF7EB3EA9@VI1PR04MB4656.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4UGlWOJ9ImIMfN31VL9DM4jBiDErVUPaU8cO/axK0lHAS0IvYczvg2Uirlmt0qyL4DDSp8SQtlh2Wa6GQXlxhTDDWVzL2uPZyHafXuQQ73moEXZotJlKc7rzEkotNYZYnWQywIbod6LfIZMJTHlzPqnUExBiyqQaT5rj4yiWv4cSDCJAEVWwIfJsfTXnZ7xCZqix3nhhgb8BBFhJ1QxvMK88QQqpkQKfGSljPD9H1SdUYmHJZYkxp2J4QaRKgNpr+Bh4gAqCEcuJ+J29UwzdWL2j1c5xgGMrUX7MvEifuv58Rd7rYT2chAPRJMxP+wPLLPT8g5boISRuoiBiwNFThWYx6ly6IVlEHjtZ0s+TxRsjlVvopvkpfeop5v2tlSF+3TvKjpFidXvJUUxh90pjmfmPcufb6kkO78D//0viZSi8jhmdgZ0HRp2tTWiWauPGCf6CD4zq5NgAAlYcaJsB03pGOPwCy41rKotmRPTEWgO9mGs6eGN68aETRpYPJqZQVBeS+4DcQI3AKZcGlqHM5x+iSPEktTL4UiW7eXeYO8s1D4NAPJ3D+r1WI/rBgeKCgHUY46teyDIjSXWrilJaxZHStzc3LiNu756XmERLHLrGBTGhcPGqvTJfJgYWhW/h8744fiXFspbJJWyjfMxfNpdlMLhEdO+tfKpD1haCLeJGOoiRfANTCfD6Y81wa4yoU2EG3qivNfuudYZgdK1FfpYdmwh5OU5TVE1053Msr2j+DD6Q55Upe63cmcURH4Tz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(4326008)(8676002)(66476007)(508600001)(2616005)(8936002)(66946007)(6486002)(54906003)(316002)(31696002)(86362001)(6506007)(6916009)(53546011)(6512007)(83380400001)(26005)(186003)(31686004)(2906002)(5660300002)(38100700002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dzZzNGFGR1IxODZMRHBuT29GOEFIQ0RKY0FMR0dZeTZUSUtId1pqUUoxY3dH?=
 =?utf-8?B?bkNBM2RUbjVVN3VCNmR3a2hETFVGaFNmL2dsVlNocVZOWFUxNWhsYmpZZVRw?=
 =?utf-8?B?VW5EU2UzRjREZk1YTzZ1emN0Z0VmODg1ZlI0TmRYM0ZMNUVGVm15RzdGYzY1?=
 =?utf-8?B?VGFUK0toaE1KSkpuR3JKLzhHVytLOTVBK3k4WG9acjg2ZncyVThzRUtkdUhE?=
 =?utf-8?B?ZnVHVWNHbEd1UG1mYlpHZ2c5aXl4Wjgyb25wbnBwbURkaCtISUFzdWVPcElO?=
 =?utf-8?B?L055NTZ1WFdaTmFXb1ZpNXc2TWxabWNHUDRkWWN2V2xLRjhLanJvcEJmekdu?=
 =?utf-8?B?ck9mMVRPWk1MMVVlb3pIV0F0WXplN0lHd0JPeHVTVEg3ZFFKeWhDRWJlZjl5?=
 =?utf-8?B?TlllRUV1eTN6ZXdyUVl6S282VGlkZnhtVzJhUEVhNWxlcDdlY05WVmoxaUEz?=
 =?utf-8?B?VXAwb2s1T09hWmp6eDFVeU5SbEhwQ3VNejhLMnNxdURENjBad2ZqdmhpaTg3?=
 =?utf-8?B?MmpKWlBaYVJMSThTcVMyTDh1ZGQrMDJlTHZFSjdVYTVZb0RaZ1diSHRPU3By?=
 =?utf-8?B?RDBEc2E3cENaRm9RK3k1QThrTWtuZmZDKzRQY0JkMVJFNEkvTkJUamVkNHFw?=
 =?utf-8?B?WnFQaTZZUU10SWlUSU5qN2xzU1pSODV5QmNKa2FFN2N6TGgxS0RyUXRKWHFz?=
 =?utf-8?B?TjhQdm1FUVJkT0xQZ3lGSzFzdU5YeWpXNEhQN1YrR0xxeVNFY2YxYXYzQm9Y?=
 =?utf-8?B?M09TZkh5UmpJa0hzWnc0ME5UVkkwTG56VE83Zi9rU0VmUTNoc0pmRGwxUVlt?=
 =?utf-8?B?OFZEQy9LdDYvSDBwclBRTHRvT0ZvZGg2QnM2ZDQzbHhkQmY3K05nQUtUdjhl?=
 =?utf-8?B?cWY2T1RTSlJzVHlYYXVrTmxHMWh0aDU0bmpUeWRCQ3BCN1JKZXpFRkZpZ1d6?=
 =?utf-8?B?STY5bVFqQWliREI5cExXNU8xSVgwSWFIRzh2bkNBY0MwaS9ERjFFQ2pqeGt1?=
 =?utf-8?B?ZnZsdnRMQVlpZDU5Y1FXRUZtdmZLelFxTERSN3dQdVBQY1JCVlJzZnhIZGhB?=
 =?utf-8?B?akZydWhBN0NWM0VIQWVsMERNZmdvOGRBVnlDdG94QThicWR3cU1tekxwTTlG?=
 =?utf-8?B?dFF3RTNmSnJvak1LOHZsdHp1eEszTktxcW5selFkQ3RSMExjYjFEaCtIdXJu?=
 =?utf-8?B?VHlEZU00UFQyVlkvWHdYNHpXdHVxWGxRdjZBc25nYUZ0QTdud24zSlVYMW5V?=
 =?utf-8?B?NThINjdwT2FkeitNSlVvSmNjZnJpVDdJc0M2VlZ2WURuMjhnalZCWTBIai9l?=
 =?utf-8?B?QW9tZFJHa1hMcnRXejZzZDRJRDQ2ZkJKbld3VEltclBoUjFBQWdlaWhyaGQw?=
 =?utf-8?B?Z3NTRVlFVW4rMWYyZ1RFcUpnek9oYlE3bTA4ZzRxdGRQSmM3ZFVWNThlUUNt?=
 =?utf-8?B?SGJwZ2xFQVFSdWlpejRjQUVESGw1Zk9QenFVVW82a2NKZlAxS3ZiSW85c01a?=
 =?utf-8?B?RlJUNHhUM293WWtMbXdGaVVwQmU2S1hxRlNPMUxYWEZCZkhscEx5RmtmN3ZY?=
 =?utf-8?B?L1J4MUVzQlE3elI2c3VCSDV5RngzOGE3M0c0bWFXU2JYR1pFenRlaUZLK3ZZ?=
 =?utf-8?B?ZVJ5NHVRZHFjU2twZmpVc01qT1dKcjN2aTg2WUI1YVhMTHhlT0p2cTF3WFRk?=
 =?utf-8?B?SnIrVXRPSWdrYkdZN0lUWjhSZlJuTHJTSXh3TGVPUjlVU2RSSjNnNDhOUGlq?=
 =?utf-8?B?eExEcnUwYUtreTZiVStBZzlrdXdHcmtSZHFNNGRjU1N6TkVreVVIZ1ZhcWtr?=
 =?utf-8?B?SUh4L0I3c3NDRk5NVW1qcW03Zkx6NWIwQ0N5RjIrVjdmTGVJS0NiZUc5N2h3?=
 =?utf-8?B?eDREY3NDeGJKbDhuL0lqcW5raGFmaHBnWWYrVGU5RlJwbTdZZXUzQlJyK3pa?=
 =?utf-8?B?M2kvT3FXZGVXMzVCU0ZPNndwY29qQ3ZTdTdpZUszMi9obDBqUjRrd21raU9Z?=
 =?utf-8?B?RTJlcWhleklEYjBZMXBXRXJzem1NSkh4SDNpVmxKdys4cDlkZjJjUER2VnUw?=
 =?utf-8?B?M2owaHJLQ1BmbUgxQklzR2d5ZWlIUnBjSGEvS0hRbEN5ZngxeGlnKzFOdjZR?=
 =?utf-8?B?T0ljcEQ0QVEycTkzR3loVm43WUhYSmM1UmR1RTdHTStwUGdmL2ljOVRSUitn?=
 =?utf-8?B?c3J5N2RnSTRkeEhxLzJJKyt1ZDFjaDgxR0ZRbitaNEx2bDBRQi9OSnFvcnR6?=
 =?utf-8?B?ZTlpeDl6Qm5SQmg4YTNzL1VNZ0VVVDliM1N3MjRhYUVselhyQVlnUEVQTjY2?=
 =?utf-8?B?ODZ5THVwK2dXNW9aWEhOTFpmSkxzUC9VUTh3a0dKL0VNNit3OVlqdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 147b8760-1ea2-4176-d59b-08da1bb4b912
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 12:13:44.1784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XzNBeWA4UkF9XQHIXTxnRdcDZs3vYK/5asL+cViWSxxcWb+wEQ5G43P7GQQyS6X87mIzpvscdzv/AwBHs+enbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4656

On 11.04.2022 13:00, Julien Grall wrote:
> On 11/04/2022 11:45, Jan Beulich wrote:
>> On 11.04.2022 12:25, Julien Grall wrote:
>>> On 11/04/2022 07:13, Jan Beulich wrote:
>>>>>>>> --- a/xen/common/event_channel.c
>>>>>>>> +++ b/xen/common/event_channel.c
>>>>>>>> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>>>>>>>>          unsigned int port;
>>>>>>>>          struct evtchn *chn;
>>>>>>>>      
>>>>>>>> +    /*
>>>>>>>> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
>>>>>>>> +     * vCPU-s they're to be delivered to run on. In order to limit lock
>>>>>>>> +     * contention, check for an empty list prior to acquiring the lock. In the
>>>>>>>> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
>>>>>>>> +     * until the vCPU is migrated (again) to another pCPU.
>>>>>>>> +     */
>>>>>>>
>>>>>>> AFAIU, the downside is another pCPU (and therefore vCPU) will get
>>>>>>> disturbed by the interrupt.
>>>>>>
>>>>>> But only rarely, i.e. in case a race would actually have occurred.
>>>>>
>>>>> Maybe I am too paranoid here. The other side of race is controlled by a
>>>>> domain. So wouldn't it be possible to increase how often the race is hit?
>>>>
>>>> Yes, of course - just to harm itself.
>>>
>>> Are you sure? Wouldn't this also harm the next vCPU running on the pCPU
>>> because it will get interrupted more often?
>>
>> Possibly, sure. But we don't make any promises here. And recall that
>> this optimization as a whole has been put under question in the past.
> 
> I don't remember this discussion. Do you have a pointer?

I'm sorry, but no, I don't have a pointer. This may even have been on irc.
All I recall (or at least I think I do) is that it was Andrew who raised
the concern.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 12:15:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 12:15:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303037.517018 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndswy-0007lu-2F; Mon, 11 Apr 2022 12:15:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303037.517018; Mon, 11 Apr 2022 12:15:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndswx-0007ln-Vg; Mon, 11 Apr 2022 12:15:19 +0000
Received: by outflank-mailman (input) for mailman id 303037;
 Mon, 11 Apr 2022 12:04:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uyKy=UV=linux.ibm.com=hoeppner@srs-se1.protection.inumbo.net>)
 id 1ndsmV-0006HD-El
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 12:04:31 +0000
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
 [148.163.156.1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 89104190-b98f-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 14:04:28 +0200 (CEST)
Received: from pps.filterd (m0187473.ppops.net [127.0.0.1])
 by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23B9NnvU025178; 
 Mon, 11 Apr 2022 12:03:59 GMT
Received: from pps.reinject (localhost [127.0.0.1])
 by mx0a-001b2d01.pphosted.com with ESMTP id 3fchnqtx4t-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 11 Apr 2022 12:03:59 +0000
Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1])
 by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 23BAmtcM013717;
 Mon, 11 Apr 2022 12:03:58 GMT
Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com
 [169.51.49.99])
 by mx0a-001b2d01.pphosted.com with ESMTP id 3fchnqtx39-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 11 Apr 2022 12:03:58 +0000
Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1])
 by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23BC3gZm003276;
 Mon, 11 Apr 2022 12:03:54 GMT
Received: from b06avi18878370.portsmouth.uk.ibm.com
 (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194])
 by ppma04ams.nl.ibm.com with ESMTP id 3fb1s8u242-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 11 Apr 2022 12:03:54 +0000
Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com
 [9.149.105.59])
 by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP
 id 23BC40Q146596476
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 11 Apr 2022 12:04:01 GMT
Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id 1327BA4065;
 Mon, 11 Apr 2022 12:03:52 +0000 (GMT)
Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id C9DE7A404D;
 Mon, 11 Apr 2022 12:03:50 +0000 (GMT)
Received: from [9.145.81.78] (unknown [9.145.81.78])
 by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP;
 Mon, 11 Apr 2022 12:03:50 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89104190-b98f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date :
 mime-version : subject : to : cc : references : from : in-reply-to :
 content-type : content-transfer-encoding; s=pp1;
 bh=gYNUMVwDP13qlMS4+UHaJJ3PaCFPgROQJTYtqXnOX7M=;
 b=RDqgcHKph8Jm2BhrynHRzlAqx8nGWKQVGDEreK7n+J6njlw2fY/eROIb0LG1Go0keNpO
 U7B7ao4FH0/uzQKEPYrHVhNG/pJ2E7Z6UBEEa2SxZlUdVDQJZ6TEFr72vPR9TSXOEBKG
 MqlChSHpWchCsB0wZHoGw70dgQSIwe1Dr/3iyUd7QHcinyuGvNuFdGbEFCrbqw9Rsc9z
 JkcowV5iFVIqo42z4/eOag4ZGEVEYQqZe/457g+H8egdMxH/HXBM9/jRkB0BPaAeZihE
 GFX1OIArRJYPFHkICDQZB90KgaeOXTtU3/g2gqArNZA/NmuhAbDjv3WPLEAFQ6zGE6gp Sw== 
Message-ID: <e971095e-1015-c348-3c24-114193ee5ff0@linux.ibm.com>
Date: Mon, 11 Apr 2022 14:03:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
        linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
        nbd@other.debian.org, ceph-devel@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
        linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
        linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
        linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
        linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
        ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= <christoph.boehmwalder@linbit.com>,
        Coly Li <colyli@suse.de>
References: <20220409045043.23593-1-hch@lst.de>
 <20220409045043.23593-25-hch@lst.de>
From: =?UTF-8?Q?Jan_H=c3=b6ppner?= <hoeppner@linux.ibm.com>
In-Reply-To: <20220409045043.23593-25-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-TM-AS-GCONF: 00
X-Proofpoint-GUID: fq1U6p5RSJi3IUi0XnNkXpRDl0Ogb6A0
X-Proofpoint-ORIG-GUID: D9QlKI8GujOSuLx30db3fYGBx6ksQFZ5
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-04-11_04,2022-04-11_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501
 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0
 adultscore=0 clxscore=1011 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204110067

On 09/04/2022 06:50, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
> 
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [btrfs]
> Acked-by: Coly Li <colyli@suse.de> [bcache]
> ---

For 

>  drivers/s390/block/dasd_fba.c       |  1 -

Acked-by: Jan Höppner <hoeppner@linux.ibm.com>


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 12:49:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 12:49:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303048.517030 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndtTq-0002ry-JD; Mon, 11 Apr 2022 12:49:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303048.517030; Mon, 11 Apr 2022 12:49:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndtTq-0002rr-GA; Mon, 11 Apr 2022 12:49:18 +0000
Received: by outflank-mailman (input) for mailman id 303048;
 Mon, 11 Apr 2022 12:49:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndtTo-0002rh-Nt; Mon, 11 Apr 2022 12:49:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndtTo-0006Tz-L7; Mon, 11 Apr 2022 12:49:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndtTo-00081T-Bl; Mon, 11 Apr 2022 12:49:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndtTo-0004lU-BN; Mon, 11 Apr 2022 12:49:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=frPyWPOKQP0MkNmw6qH/IoMYHOBfzIEoDjq8l68wi34=; b=MgDjWWWIKbT4fEvaAGEHGslW0J
	BSHERDbIsw+8SvipYqiO8YpmPVnqYWxDQ1ztdp3QBAtueFTKF11NQiDaNxTb5WhXDoVI7OezUxQl7
	4MmDVL9RzQX99fmlygRYKfoxu7/HhIhp7DqfsOOfT9+TX9rxeGfmUuT7cAPUZ6kBVUdM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169306-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169306: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 12:49:16 +0000

flight 169306 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169306/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  324 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 13:36:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 13:36:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303057.517041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nduCz-0008A4-6u; Mon, 11 Apr 2022 13:35:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303057.517041; Mon, 11 Apr 2022 13:35:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nduCz-00089x-3T; Mon, 11 Apr 2022 13:35:57 +0000
Received: by outflank-mailman (input) for mailman id 303057;
 Mon, 11 Apr 2022 13:35:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nduCy-00089n-7K; Mon, 11 Apr 2022 13:35:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nduCy-0007L8-5a; Mon, 11 Apr 2022 13:35:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nduCx-0000bV-KD; Mon, 11 Apr 2022 13:35:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nduCx-0003ma-Jj; Mon, 11 Apr 2022 13:35:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=otQfLbezBzXOJxUp0GwIecRWqAiDG/ORecMviLcI3i8=; b=RRm7o1U0pF8G4qyFIADDiJU7XE
	yV+RBzfx/+MN01mMyOG1c9Ae6amUdmzdX5hriTCW/lm3Gq90ZdPoT1Jerdx/5Q6Y1lQSdCOz/JKZg
	MrKXg6GXeD/F4ouAjfO1vvaCCfLVpSk0GT34r7L0hVVvtRGq/K/a7HnaBmV5d5mv6t8g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169307-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169307: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 13:35:55 +0000

flight 169307 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169307/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  325 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 13:57:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 13:57:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303067.517052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nduXW-0002IJ-3N; Mon, 11 Apr 2022 13:57:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303067.517052; Mon, 11 Apr 2022 13:57:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nduXW-0002IC-0Z; Mon, 11 Apr 2022 13:57:10 +0000
Received: by outflank-mailman (input) for mailman id 303067;
 Mon, 11 Apr 2022 13:57:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nduXV-0002I2-72; Mon, 11 Apr 2022 13:57:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nduXV-0007kz-3j; Mon, 11 Apr 2022 13:57:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nduXU-00019g-OR; Mon, 11 Apr 2022 13:57:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nduXU-00019H-O0; Mon, 11 Apr 2022 13:57:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gR+ybp7PbLjEmBfOVHqP/6W0lDqJKbK7tFtcuaTScJc=; b=r3NJN94iXuEaq9LjWG+GVbJHGz
	2Uluo0o1Q4jrMC/6oDindln2fbpe0sXaMyTLkIyxh9cTtB9USVihXS0972/hHaVk/CrDcPWbgkBWR
	RFGl4bAiAdkeUJw/ZJVETWElaVrvji7V/ZccgDgGjtED2WLPpn/cXCmDVlV5VCORf4eU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169304-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169304: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f44201124e8713f6eff80f349351b5740001c6fc
X-Osstest-Versions-That:
    xen=8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 13:57:08 +0000

flight 169304 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169304/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f44201124e8713f6eff80f349351b5740001c6fc
baseline version:
 xen                  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf

Last test of basis   169250  2022-04-08 20:03:24 Z    2 days
Testing same since   169304  2022-04-11 11:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8847ec08fd..f44201124e  f44201124e8713f6eff80f349351b5740001c6fc -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 14:01:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 14:01:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303076.517063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nduc3-0003qf-N5; Mon, 11 Apr 2022 14:01:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303076.517063; Mon, 11 Apr 2022 14:01:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nduc3-0003qY-KB; Mon, 11 Apr 2022 14:01:51 +0000
Received: by outflank-mailman (input) for mailman id 303076;
 Mon, 11 Apr 2022 14:01:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIii=UV=kernel.org=kbusch@srs-se1.protection.inumbo.net>)
 id 1nduc2-0003qS-7Z
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 14:01:50 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eda9112d-b99f-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 16:01:48 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 3B15B6125C;
 Mon, 11 Apr 2022 14:01:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E77C385A4;
 Mon, 11 Apr 2022 14:01:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eda9112d-b99f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649685706;
	bh=aoF5JI4oA+WPgt/y0IgsxtsbxAXaCuGafPntNOloKP4=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Z3DJooO+lpgxb0V7M65iVrqmxI0PEssCJPh+vJ1dEw1YBTDUO4k0Ftowa06gEpR83
	 S1WtT+TAlqYOA3SV5oPOUKBv5r5Czq1jXlmgnBC2vlAsKUSP12Z7m3WPk2IIXa7ddE
	 7+rat37phwTAQkXhdDcOfyIkaP50hX9uWu9MCv3Yv354dhMqhNyhEKK5VIXvkcNSo/
	 Yw75O5ZXcRgYxwAIHqrZej/c3adf+HQOwXoAdC34I68eRF5zbda1Ysdnlbmc/q5KXa
	 +yAvml8INLRMKi4FRTZn17313igwH9BKq1x7zfZpQGp7kDf9WzbZnpQOZP3oofxBEN
	 wCj97MUpv05qA==
Date: Mon, 11 Apr 2022 08:01:41 -0600
From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph =?iso-8859-1?Q?B=F6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Coly Li <colyli@suse.de>
Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Message-ID: <YlQ0xbtIcf8gti43@kbusch-mbp.dhcp.thefacebook.com>
References: <20220409045043.23593-1-hch@lst.de>
 <20220409045043.23593-25-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220409045043.23593-25-hch@lst.de>

On Sat, Apr 09, 2022 at 06:50:40AM +0200, Christoph Hellwig wrote:
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index efb85c6d8e2d5..7e07dd69262a7 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1607,10 +1607,8 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
>  	struct request_queue *queue = disk->queue;
>  	u32 size = queue_logical_block_size(queue);
>  
> -	if (ctrl->max_discard_sectors == 0) {
> -		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, queue);
> +	if (ctrl->max_discard_sectors == 0)
>  		return;
> -	}

I think we need to update the queue limit in this condition. While unlikley,
the flag was cleared here in case the device changed support for discard from
the previous reset. 


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 14:05:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 14:05:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303081.517073 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndufn-0004Tq-6F; Mon, 11 Apr 2022 14:05:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303081.517073; Mon, 11 Apr 2022 14:05:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndufn-0004Tj-2w; Mon, 11 Apr 2022 14:05:43 +0000
Received: by outflank-mailman (input) for mailman id 303081;
 Mon, 11 Apr 2022 14:05:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndufl-0004TZ-RL; Mon, 11 Apr 2022 14:05:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndufl-00080N-Ol; Mon, 11 Apr 2022 14:05:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndufl-0001Kg-DI; Mon, 11 Apr 2022 14:05:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndufl-0004Ok-Cp; Mon, 11 Apr 2022 14:05:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hOzX5icXv++V6rC4GvHukzhNuCQ5svV5WH/DMALh+bE=; b=tXyILjb51l5XOxxBQiUajrYSrx
	j+iJz9aKciSTyMP+j663ufOtY6WxL8OaIXBMc586z2MGXRYksTO5uTOEER30v9o+ABH0Hgy0X5O2m
	EqcH3vrFbWh/XCY20yfjF1OYITnudwTRpiKsZo/J8Fw17ElkIXaoNqZvjvmO+tj0GqIs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169308-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169308: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 14:05:41 +0000

flight 169308 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169308/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  326 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 14:33:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 14:33:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303090.517085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndv6j-0007tG-A7; Mon, 11 Apr 2022 14:33:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303090.517085; Mon, 11 Apr 2022 14:33:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndv6j-0007t9-6y; Mon, 11 Apr 2022 14:33:33 +0000
Received: by outflank-mailman (input) for mailman id 303090;
 Mon, 11 Apr 2022 14:33:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ETZj=UV=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1ndv6h-0007t3-1U
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 14:33:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5afc76c0-b9a4-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 16:33:29 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-SfV6kcHjPDG0BF30OWitog-1; Mon, 11 Apr 2022 16:33:28 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by DB8PR04MB6698.eurprd04.prod.outlook.com (2603:10a6:10:10c::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 14:33:26 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::a4bc:f02c:559e:8afa%4]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 14:33:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5afc76c0-b9a4-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649687609;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vDt+o5xfyAKPhXbyAOXsIp4kFCRyVSeCOtKAiPRC2kE=;
	b=NGeqnx3TlCVEh/RVNWSKHfbKsGUphNVSaX4xGrRn2wFi980X3dAvUyigGTFWQYAi08YtY5
	G0nx0PaOsJ21mYuyDAJNvctgODNevcD7IuFryO8+sABHCehwXo3QQGUzh4vCDEBsCxSCqm
	faa1Qu4GH22XuNUALglQy87p06WTC+Y=
X-MC-Unique: SfV6kcHjPDG0BF30OWitog-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BQCFozCfhJV7uZS4IpRM57Co2oFToiiglg1fPW77BriZiWScLO4wUCazi086ri8YeY8LCrGgjByk25gnNUb1vqSYLsM2ubQV3uEiDMFYJN/Q5fZkNOqPxb+dvxV4OrXY4p/71l9iRNBePEE+HEWu5E1awAggyHNo3oiiy0LNYPjrGSgafNszudYEn/KV+iihtS/rEB/s2kGMN1uy1C/gKioKHnR+Ft332DQ9CP/N1vPZ3I2km+trNwLXm4cjaanhnVpxihSPEqKvd1t5P8Gjj/DN6evPiD50B24jO/2qU5OssLX2jWE2LhJkue6/wpLQyvba5P4X3T2tv36RFLOv7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vDt+o5xfyAKPhXbyAOXsIp4kFCRyVSeCOtKAiPRC2kE=;
 b=Za4MbYroo0PTrm/NAvyPXmCefdaAeC55AZiH1a17WCcO4gVP7i9MTvtPjfo73U+kEOt4MQvaWrmPQmIazwz9KEasX7Ya8uDQoopR3eXdOjdbf5JwqGPb5QrkmLKmWIvjZoDJzXqtFkPkqeoj2qVsSfwZKrPKpCU5DZdjfafRT/omkM7HnZ0bvdl9OdHYym1xHJPVt93GJOcWGiiJXHWcbb12AdBZKrePEjU5ZPi2OzeBSzDFFzKtHFczHRocx87Tye1NL8JMz5TkZALotnFXIok9EhJuhXzPX48YRvg+cr3LfZQCx2e39uN/ZEj6+g1Z3tAltXeN+buzYuOQ/6sRZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "ohering@suse.de" <ohering@suse.de>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Topic: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Index: AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgATtAIA=
Date: Mon, 11 Apr 2022 14:33:26 +0000
Message-ID: <6078ed329696878570b0167952cdd7c8d040f9e0.camel@suse.com>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
	 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
In-Reply-To: <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f98f8111-96fe-4934-aa41-08da1bc83d81
x-ms-traffictypediagnostic: DB8PR04MB6698:EE_
x-microsoft-antispam-prvs:
 <DB8PR04MB6698DA888E5458A539E124BFC5EA9@DB8PR04MB6698.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 YJygIxSdUHIs86w7vUQb+sQdztbwSHAL53q1xglHN3bUVMFuxbkWtmlZtq9t7lq85xXr//x624gnVqUQzwonRhH/jnigkvQ9w5Z5XEszA2bFREFtey50Gz0YXzo/mGzBHnDT/UH1Ik+YxbdogHAPmyWtLnJddXRcVD3t4sDiidQbytqwt3frrjDdwEoSaThRM3ZVeeayq0K3Pv6hSaFvN3VMgYf0lWPcbzZQFbAVIW8CcwQJkK6ainB2nsGi40sMbzoZTco3V8SuM00d16Y4iqS7edYaAgfY0pnD+18tttOsujVvFjA9StpVA6ooIXZ75ZuCSoNwNG/7JDSQyVo7i2IM9txjR/9TuskoYVtcYsyLIq9rvimi7LrI4/n/6FVGTbqcJXid3TtOFLepcsye8SzbE8AdfhgOKXjNVPBdqSJVIgmN26wNuylZc4rWaXp3ZkjfaRWVS4Ev8BlJ1KPIRqcj7hOlVDbP02Abytm7YrqkVOW9Kt1nmU83HtTKpzug6E7uRzLckcfrbbxwvfdV98qvDEcCeueyaSliOVvoJnWrkwK4jIcFe5BZztZ8lgUDsf343jBVZJjjCeuJnSHs0KwIaDjx8Fj+3mfJbXm7jFnh7XEPVaZQy8UKE84ycGdjov5PvDwzdky2x0RVD58nV5wpXy/fnDyqxpy2CEMl0WDgEqUkND4abjMeww/j7jfVDwTzigFVO2UVc+rpuk+4Jdv1tcbiYs8B5sRK9HsLKa5fmXkqDUgqe13KDVGzEDABBkMzg7mQI0XQCkkwCbLPGgh5G2162NfmlGtAEphvDWsPDSWZQNrXKNAB7OOCCFzx
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(2616005)(122000001)(64756008)(6486002)(4326008)(8676002)(966005)(38100700002)(99936003)(76116006)(66446008)(71200400001)(8936002)(66476007)(38070700005)(91956017)(54906003)(110136005)(66556008)(508600001)(6506007)(2906002)(316002)(6512007)(26005)(186003)(5660300002)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?UkFKRW5rcG5Vajc5NlU4ZXhrYmZ2UmxEK1R4MXpuUnp6ZmVUVFZsTUtVT3ow?=
 =?utf-8?B?RFlwSlVoMDN6Q1dkQjl1QjJMNUFkSnJJeEJ2V3VJUTBocFovem9KdzFWSDdW?=
 =?utf-8?B?aU5oUjVFbkNrZjI0RTExQzNpYk1UcUpZaGZiME43U01OZGM4NWNjRC9sc294?=
 =?utf-8?B?MVltcGpxdk1aYnF6ZVJGRUFMa2NpSyt3TXZPa0hUa2lEOG9pR25kQjFiRXZh?=
 =?utf-8?B?bWlXRU0wNG4wYzNSQS9YdjNKR2xhMUYyVk4vS3d1R3FrMTFwMnVkU0RjTW1j?=
 =?utf-8?B?ZUp6MDNXZ1NQank4SDVCYklIMTgveXM3Rlpla0E2ak8ybXBBWWVBUUYveUR3?=
 =?utf-8?B?VU51eWdsMFpXVW8vTTEwd1NKNnF0eWVyWU1VdnBHcXlhbWJrSGJNTGxBRVVt?=
 =?utf-8?B?UEl0d3B5eG9EZy9NclJZYWcyU3U1QVdac3AramZqc1NIMG5lck9Ma2xGZ0VB?=
 =?utf-8?B?a012aExaYjI5NWpZMGxQMjUwRExUcXZEUndWbDl4RUlhL2xDMEovMXJ3TkpE?=
 =?utf-8?B?N1k0aURsWnVDUFluNzRBRjNycmZsaWJSbXpBTVJ6akY2dUtuTk1vblNkYXBu?=
 =?utf-8?B?amNzZFY3Q0tucWZqV2Noc2dtd1J4c3VBVnNkTGRnN2JuS2l1OFVES291SDhM?=
 =?utf-8?B?ZGJ1ampsUWlRblJEUStxMWdFbjhEMzBFQ1lNUmdiU0RPVWRsZTdncmxIVkdt?=
 =?utf-8?B?Q21RTHUxSm1pQUszZnRVeVlNQTdGSVZlUGtnSGJTOHlSamtxc0ZzcTN3bDNh?=
 =?utf-8?B?SE5PNHVpeW4zWmxDOXp4VGtncEhlVnJ6V0U1SU9QVW9oakxwQit2SndZZkw3?=
 =?utf-8?B?bTZOTWpkNHhNb0VnQWdPejhvQVVvUldjQWNLT0JxekUxTHExVVVBejg3NlA1?=
 =?utf-8?B?UVlxZzhPZ2s1Sml0aE1SY3F6amx2L2pZNGF0QUxPSmk0ekFudkRaRW8zY3dW?=
 =?utf-8?B?eVBRcWwvalVHYzdDNFZkVTRiRTBIb3JabEE3T1V4Ulo3UG1sUTViQUMwWXdU?=
 =?utf-8?B?TWYzVHF6ZlhScXVkZTNVRmtlWEdtb1dGbjBsUExjVHpjS1Vycjk2YS9uS1NO?=
 =?utf-8?B?MjlwbWp6dG4wL05JSGhSRTd0OWN0VUFKNWZkTHVkaWZRYldzU1hHMzFZbHFy?=
 =?utf-8?B?VlA5N1RHLzVRdFVwZDJXdFV0cGtmNzN4K0t0ZHhIdDVrdVErRUZmMm1BMVhm?=
 =?utf-8?B?VFEyUTdQb2xCMEVkRjVBWlBmWFZkaU1PVmZQak1Sc1NOc0xOZlgyVDlKbmxv?=
 =?utf-8?B?bzVmRzlQOEpLZ2NsUW5mMUFUSkcvZCtHZklETjM5ZkcrRTJhc3VYNDdzSFNj?=
 =?utf-8?B?enlUQXlLZEdEOXhWdXZaSC82Ykc0Z2h6QzZJbW14S2FkYzFaaVpTRmk2dDA3?=
 =?utf-8?B?bkFYRkFjSlhuM2lDVG9nYlJFbWVKZnJPWWpiUDhSOFBPSmd6Qzd3MjJVVmNG?=
 =?utf-8?B?bWFQVFd4SEhPWENUdk14a09tc00xQURUZXBOL0tVblpKRWJoOFFtdlEyNTBz?=
 =?utf-8?B?YlZLTnRMcVl1aHl5SFoybGN4MVdhWk5mdmNRR3hOVTFCaWhUUGFQWG9qSFdN?=
 =?utf-8?B?WkFTMW5VZTBQMVJDeGNodXM0YUEvUllWU3FvTzRwclI0cDUrR0w1cGxrd3k0?=
 =?utf-8?B?ZXRHK2ZMRHY4UTJYc2dzU2FNUXM3QjdvYUwvVW9CNDdZRXJMN3REV2lSMHVo?=
 =?utf-8?B?di92TFI4MG9hYVoyYWxmNXNyZG5LTDB6OElrd0x4cERid25peGRoaGQvWFlu?=
 =?utf-8?B?MVpOSXpUb0dvdVJwUW94SXdLeG4zQkRDR0swc3dydEtxVk5IVUdzb3dtK0NJ?=
 =?utf-8?B?eWJsMFdzRy9kR05mVFA5ZkpmSkl1S1gxSkhJV3UxaGlIQWxkRDRHZ0NsUld1?=
 =?utf-8?B?RitCdm8rS1RGT28zc1JYUFRYRi9aV2pKRzZhclRQU2M4TDIwRm4zaVdRYlk0?=
 =?utf-8?B?MndYS21uS1FiRTd0K1p2cGRFVG01TXhSUVZKRnRUUWJ1T25Qaks1b29Nbkht?=
 =?utf-8?B?OHhNeEVEQW1ReUpNSzhXYThIT2hPWkJYbkhFVVA4SUpPaitBVW4yd2NSSjlk?=
 =?utf-8?B?V0dvL24vWVkwd25seVBSWkZtVmVEVW9GSFFIZlB0endSSUYvUjhtOGtXbllT?=
 =?utf-8?B?cWtrUGRpanRVNVVXSm8rNndIUzBmdWxVVldpUnpjRjJBVGx2L29CN3IySENB?=
 =?utf-8?B?WjZjR0ZNdkVUcTBPcEhWa0VXUmM1VnUxYy9CUzFweEZyN2JyVG9tQStxN0Zv?=
 =?utf-8?B?UG1mOWFBV0JlanJKN2RMZGphd0FnQ2ZEUmh4YlhydGFXdXJUS3A0OW1HQW5n?=
 =?utf-8?B?Vlp2NXVTSXdYeUIwRVNjekpCMUNFd2lhSnVVK0dRSWo4U09vSDZyQT09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-hPWrsB6BOHbV5On1BZy7"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f98f8111-96fe-4934-aa41-08da1bc83d81
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 14:33:26.4570
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N6gENSzkl625b17SFOnLclaGbixNq9x1qonCQlNTZrvfsSrG+t0zBSD5OWKXXXc6vYqjLqVXk094wCayrcE+wQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6698

--=-hPWrsB6BOHbV5On1BZy7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2022-04-08 at 11:20 +0000, Dario Faggioli wrote:
> On Thu, 2022-04-07 at 15:27 +0200, Jan Beulich wrote:
> >=20
> > Credit2 moving the vCPU-s off of their initially assigned ones
> > right
> > away of course renders sched_select_initial_cpu()'s use of
> > cpu_cycle()
> > pretty useless.
> >=20
> Mmm... you mean that Credit2 is moving the vCPUs off they're assigned
> ones _right_now_, or that it will, with this patch?
>=20
> If you mean the former, I'm not sure it is. In fact, when
> sched_select_initial_cpu() is called for dom0, dom0's node affinity
> is
> just all nodes, isn't it?=C2=A0
>
Actually, it's what results from dom0_nodes. I was forgetting that we
set d->node_affinity while parsing the parameter.

That said, I've added some logging, to better understand what is going
on, and there are some not obvious (at least, not to me) things that
are happening, and it seems that what is causing problems is the call
to sched_insert_unit(), within sched_init_vcpu().

I have to leave now, but I will report what I've found ASAP (probably
tomorrow, though).

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-hPWrsB6BOHbV5On1BZy7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJUPDUACgkQFkJ4iaW4
c+7/uBAA68ySvw3cqr0SxCaa5Qa4EE3TtOpBuV7F3xq+UqsInKo3gcdEtV2jZp3L
QjCoruc6OyV9Bg6KmRp5taU6d1FwgqcGqsgrBYohpXehOy01jmJ/bE/fmtLymY3A
U43EYhVqWoAiXPbFwLkZ+svjcEya3UpUc9RHeIcfBesn5ub5QhIvoe+bup9boCrW
l0hvv7vgQcsL2p8bKv0ukvHBCAddf8x1KLCLBlEvbqJsaa87IoNJph7bd9G0i6QW
/ao6WU7RQ0Zzd54wDYfQAhRGYy5uTcWsrKmv5mg/mp/UAlY0QePViircdAkamMON
rBbuU4j4l9tL7rpgKqKycNZbnxPhZZpu8dztPGZc8l6glI4/dXEuruLIunReQGAE
S4DS697yDRFH1aqC8Ipq5Ga9TJdo9JDA3E0ajaVWk0Ok7CbcHF+y/g3ktZH7ge9h
6joRs+ZzfWKtZgurggip8y/u+n0N17GBVS5tG0wIXyrVSkVOm9zxc/U66PzuUyJV
8b3M/fv1yWrZGzGggwS282WgNxzS6YxRiIg6VA0LhSUolOzKZAgX//jvWiVxhnoH
xzIJgiAENsrknfi8FuF1ckFgCcNzNerJoqTUFiLDOk93yVrhi4ZP6rVi5kLJPpPW
16vFuKOtvnWV47dt4yuehavE751dneERIvdCQYj2snqXxSJ9ppc=
=McUr
-----END PGP SIGNATURE-----

--=-hPWrsB6BOHbV5On1BZy7--



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:06:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:06:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303097.517096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvc9-00031O-SS; Mon, 11 Apr 2022 15:06:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303097.517096; Mon, 11 Apr 2022 15:06:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvc9-00031H-O7; Mon, 11 Apr 2022 15:06:01 +0000
Received: by outflank-mailman (input) for mailman id 303097;
 Mon, 11 Apr 2022 15:06:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GlEk=UV=citrix.com=prvs=093d95784=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ndvc8-00031B-3M
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:06:00 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e309dc65-b9a8-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 17:05:57 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e309dc65-b9a8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649689557;
  h=from:to:subject:date:message-id:mime-version;
  bh=tX4LrDZf9URSNHgMCuu0Ch2bal4s8kfhZMu1XyNujho=;
  b=T3VtuZFbHF/9NIbgWRYBKrzzhb+IaZo761a6LMwqXlESvfcZ20JW8QyD
   epiuGTv96Ewy7CZxM4namPTg2kbopnH6p9QJHXzTG59v/0pOEBkEjsiH7
   1v+lYOie3k3M9ccp0WDKiSjBoHhOQxp6WhgBX3fI+Bv0aZJmiAfhnl9ff
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67970421
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yDdGn6AKGt/8NhVW//bjw5YqxClBgxIJ4kV8jC+esDiIYAhSlGxQk
 DNbHCvTJK7JMVJBSKklb4Xn/UkB6sDSnNY3TABtqXpnES8X8JPLXNjJIEuqNimYI8edQBM8t
 ZUXM4OedJxlFSWBqkr9beO7oXNw2avULlaQ5JYoHwgoLeMzYHtx2XqP4tIEv7OEoeRVIivV4
 9qq/ZyCaQX00WZ6Ym8etK/Y8Us/7P2psmsU5QNlaaEXsAfSmUdOAcNEL8ldDZdZrqq4vAKeb
 7yepF1s1jqBp3/BMvv8zvCjNBdirof6ZWBisFIPM0SZqkUE93RaPpoTbqJGMx8L0mzRxbid9
 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy
 BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii
 8UxRR1+dzfyRg11O15QB40fu96Zi1nESmgNwL6VjfJfD2n7yQVw1P7mMcbPe8zMTsJQ9qqaj
 juYpSKjWEhcbYHBj2remp6vrrancSfTd48VDrK1sNJ3hlma3kQYCQEMVEv9qv684qK7c4wAe
 hNMpnB3xUQ03BORRNf/QFqEnGXagQUhXJlSLLEDyB7Yn8I45C7GXzNZH1atcucOpMIwADAny
 FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRVLufgddE1FDuYO65thu0FSfFb6PDZJZkPXZPiDr4
 AKvvBI/jvIcku8s7pS23Wv+1mfESofyciY54QDeX2SA5wx/ZZK4a4HA1WU3/cqsP67CEADf4
 SFsd9y2qblXUMrTzHDlrPAlRunB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj
 SbuVeJtCH17YSDCgUxfOdvZ5yEWIU/IT4mNaxwsRoASCqWdjSfelM2UWWae3nr2jG8nmrwlN
 JGQfK6EVChGWPo+kmHrHrhMi9fHIxzSIkuJG/jGI+mPi+LCNBZ5t59YWLdxUgzJxPzd+1iEm
 zquH8CL1w9eQIXDjtr/quYuwaQxBSFjX/je8pUPHsbae1YOMDxxWpf5nOJ6E6Q4zvs9qws91
 izkMqOu4AGk3iOvxMTjQi0LVY4Dqr4j9SlrYnF2ZQ/ANrpKSd/H0ZrzvqAfINEP3Odi0eR1X
 78CfcCBCe5IUTPJ53IWapyVkWCoXE7Dad6mV8Z9XAUCQg==
IronPort-HdrOrdr: A9a23:glst1q5Zv60YkZ3rwgPXwMzXdLJyesId70hD6qkXc20zTiX4rb
 HLoB1/73TJYVkqNE3I9eruBEDiexPhHPxOj7X5VI3KNGOKhILCFuBfxLqn7zr8GzDvss5xvJ
 0QFpSW0eeAbmSSW/yKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.90,252,1643691600"; 
   d="asc'?scan'208";a="67970421"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b7R8C3HYJk9QJdOu94WVT9Fmh704GOM7p+XzXTZYRDd538txSBLcJjPzBejLOBj0NNKVLHICC7j/LencSOCrz6VAutMi6pcsWuoERe5nJQGILv7qN0cG7gpHWZFl47LciTaXePGbOmMLAVG4uMhSV16p20a9Eukr/Itmp0c3vhc+hiv4Rek9J+SNIOlNWuyqfh5cx3A9SsK6eaO3yoaRheHBZK4pUWZwweTaaem7t2V1CjzRi3KEnvwQ8MGFpWxAQsr1k2uYNo86a8bBTpWCvGCH7x8kkEAy8xEmOdVgRmTdvxpE2XLYI6wk7BxoqV80iICaCwcJRHGA6fLIW+v8wA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u2zAjHPIXAfdv6ROPQaLV/ElIIHhLZtWGtwgkdBv1fQ=;
 b=P5ChPWoREWKNUBxGQ06PxYEExxVLp+TLqI2t5gh4C8h1VNkACb+9BkXLN0464uT6bbX+ny0mGQ4dQMZ3eNsARionF3Y0xhI9zxSMkVi05mQuxwUCMQd3Bds0ifAHD4GzeOQMS4j2p1+oDPG90To1Kt2gWvKrG3JgponqAnzP1d7WvxwlYoq/bW0CnLiL+ZpaOecitsVf/UHpPNmuTDsswyEKnGNbScnV+DconR56AaxTcE+ZwUAtnuhZA1RrUlO/8ZSt5NGLrIUNOsPdyUPs6pJh1e+tD/rO540tCWYznaIvz54fh1gV89aQuEOzDD2EbAGntHILwHiPPvWShfBRvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u2zAjHPIXAfdv6ROPQaLV/ElIIHhLZtWGtwgkdBv1fQ=;
 b=GA4jCuwM6goSvhGvSjWQKdb8+lO6IUnYtJ3p7h8B9R4wKQwzkD/nR/k3MC63gmN7pYbRJIREX007qu6iVWmY0zQoTqf26wQjvc3oTgDDlbB0X9zyh3gifLZ/UawPRe2JMEKyQ6VdWt/SR191HVDMRLMvfU6oDhCRt4UQecoUiqg=
From: George Dunlap <George.Dunlap@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Subject: POLL: Would you attend a Xen Summit in Cambridge UK in September?
Thread-Topic: POLL: Would you attend a Xen Summit in Cambridge UK in
 September?
Thread-Index: AQHYTbWggfwIEBqtTEiM1SeiAv50KA==
Date: Mon, 11 Apr 2022 15:05:48 +0000
Message-ID: <E5C4E167-B471-4E0D-A042-CE90CA432A9D@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 92437120-c7ff-4c6c-34d7-08da1bccc30e
x-ms-traffictypediagnostic: BYAPR03MB4824:EE_
x-microsoft-antispam-prvs: <BYAPR03MB48243A7E565753A1BC02703999EA9@BYAPR03MB4824.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +/mRYFB3gxbCd0B88+1ASgT+dhp72wJft32Ice1zJEvDPQL7yADsU/BB2AaKByrwp4G67dAptLW70fWQ2aDfdwOQU9ZuvBUbdk9CuWkbA5dO9loeJ1AeTwQ3J2QWSjdgZEIwWsbVDeAk2/Q4lgfYnOjW3XiiITQ+JTGKnDhx+I13uBZ/Q8HvgpeH8zppdp8n2TvCkPwdcQuHWYzhrr2myHEaBsg37z6PjJ4sLTDprVNm/nYpQGEA41P5RsH7EVZNz7wj9SOZoSfQCyZRJqdKNpm20oy1+JHYBGt9R6wpbk+aU4NO8QNWk2NeXeq0pv2izyUqWt5G9v/fPnpUAJWiQsFwH5ZBBE0FOH1trLLBuYbFvaKr85pf16HBwJHHxDm/pGPdR9x7yvQHW+LtMWKgg8JB98gPQ/gQlCvBTu3SzqqfZDawoaaJRmfTO3ywlYQVmMOYHnkRFsaN09t/BxSQCsWkCS8/3+OJzgfydpzQ2azEIpK/zau15Gmc2JHCGm4lG4UlnqxRhuel80BZ8O9kdWKiXRwM1dd1M8TC8TCEumNIn4aYsqDM4LASl8kdUNYlY2oIdZVQ6FiGyz6eaHBCJYRg1RGFH6ybavcB5U7GTFgEiucFWoH702HQcN9LeM1ZrPiLpjW4m2La73U+QyA5DYy75uPa/9Qa4oFp8NLmas1Jq6L+s9JS/jFe2KS+OO0Yy8PaVvGuAXSrb3CKcSe//3z4mk3aJfkazg4SAaqINKq70MqPfFZUQsGcghL5OIQroXf509DK8NtnmM5pGYfCU4BMqxTj+uGyczNrYg4kX1qdgGhP6GUtIaj+w+eNZAqf
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(5660300002)(8936002)(91956017)(76116006)(66946007)(66556008)(38070700005)(122000001)(6486002)(66476007)(6512007)(2616005)(186003)(26005)(33656002)(6506007)(36756003)(38100700002)(966005)(2906002)(86362001)(64756008)(66446008)(99936003)(8676002)(82960400001)(6916009)(316002)(508600001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bDlpelIwUHcwaUxzbTdFZlhPVnpLRXJVRW9TK05QOXVyQzUvNjZYZHhiYUI2?=
 =?utf-8?B?VkN5K0tCeE10QTA0b2VYWjFGeXZWaEdNWUtkcXNUc2tmSkNoeHBqRWZNek9z?=
 =?utf-8?B?VVNFUFF2emhiWVdWVU05dkxHNTloZlFkNjJXbVVkOFlmOU1WWFN2bDVwNXRC?=
 =?utf-8?B?SGZSQ25lSElJbTQ4cmZnOHZhYXF0UndWMjZKL25YQktTQTk2azYyR1U4Yzht?=
 =?utf-8?B?MHBST2VpKzBsMUFOZlAzelBpRWtDZ0E1QVFVcDVCeE5lMDhZNllaSTJpS2Vp?=
 =?utf-8?B?eTgxVDBHeEVFSk1qK3dmdUYvek1keWM3ZzFoQUlYSzI1OHhLSS9qZk4vOHp6?=
 =?utf-8?B?QUU2QnZyMnB6ejF2ZDVnTzU0TmduT09hd0pmMitVMjNaNlNBQTNsMGc1NWlX?=
 =?utf-8?B?dG45STBjSWloNWVUcWR1QmU5cWJTbGFsYmt2OGc5eXFscmJVbzFyR0xNbzlu?=
 =?utf-8?B?VVowbUFKSnBtQnN6bzB2eTBuUGRuOVphWkRUclJ1RzhxV3c1VXFiMGNndzds?=
 =?utf-8?B?Z3EycjVsNERKUjdUVzNYSzQ5dGVXLzl5cFlQMXVjYXQ4U0I3STViakU2bDlP?=
 =?utf-8?B?NUNoS3Q0REgrRXFQZ1gwS3V6WCtUSUNoV3YyaU9md0J0cWZ6MkZZNk1EdVV4?=
 =?utf-8?B?RVdvMFMzWkh1emtMTnBWNldjSkszbzJEQmNBVloyeGpYWDBZTDgyY0hrVmZM?=
 =?utf-8?B?Qi9MT3JEWjY3YVNmc2MxN0FYMXExd0N3cGRkSU1jVW15MkYwOG9PY2h0OXJo?=
 =?utf-8?B?UjBXblJMMEhYdTJVV05sYXM0L0pZWDhTWFF3WS9LZzFwM1RqRktNcFo2NG4w?=
 =?utf-8?B?czEyTkdsbVpqK3VkUlhSYjlQcWp6K1FITlZaNzZMMkdhTkgzeG5VckxZbVdP?=
 =?utf-8?B?ZzkyUmVWWmlGY0RMK1l0LzNJSXlMV2xvczhCVVU0dGFQSGE2MUVJRXcvNkpW?=
 =?utf-8?B?ZUdJVWtGRFFVakJieS8wcFA5RWUvbFB0VXcwaVpVYXJIV0c5QmNjRnpFRUd6?=
 =?utf-8?B?S1NlOExoUHEyampDMEI3VkgwbVRGbFVUWEhSaFAwazd6b3U0cEJtZFRuQzFZ?=
 =?utf-8?B?MlBZQmsvZGNhQXFXU3ZBSWI4Y2JuOUdEd3EyeW5hUEhBczE1YUtEM0pXM1do?=
 =?utf-8?B?bHZUYmRLNEtjOStRYUd3VW9nSHpGMW11RGYyY0M0U1VVWEtrRFVEa0xSczFR?=
 =?utf-8?B?a2hhRmhYVEpmOS9HQjJ3ZWpFWktjR0hJRU83TGR2VERCUG81UTlCSFcrNXFU?=
 =?utf-8?B?UU8rZVNWVXJEUFByNkl2b1RtMm0rdFhMTHdOTzZ5R2NwSGgxRDJ0MzZLeldN?=
 =?utf-8?B?NXJCVWFqU0ZtVWprSGFwVmxXMU03anpuZkRqYVNXMlZyTE14MlJ0dHZkYkpK?=
 =?utf-8?B?ODBsYUhaTGhheVR0SXFWbmcyWEVIZmdaM1NYd09odUpMbUFpQ1R0eGF4d2xL?=
 =?utf-8?B?QzNsY1hVSkZlSUJ3SG1NMmxIVkFYMXprVk1xOFpEM2RMdEZKaVloSkFHSDZz?=
 =?utf-8?B?REp2aXQyaGZlaXJJQ3g5Q3FLM3VMak1zYVNUNHhzUklKUkF6b1pYdldmY09k?=
 =?utf-8?B?Z0lvMHl4MnF2MzVWNUNIZ0o3RVJQOVhDelhIdUtMZzNLNllRRXp3Z0ZGSE5N?=
 =?utf-8?B?VU1ncVpxSTZVSXE0V1pGNnRCQkJLeWpzRVpUSkxOZzRaRDBFRCtqRTJxSjlU?=
 =?utf-8?B?UEVNa09HeUZQRWI5TEFTY3JpQ2NoZHA1R3BMNmZFMjJLR3dwY1JudXFSRVIx?=
 =?utf-8?B?WThJV0pNK3JENldFWjdncUt4U3JHUXRnUndiZ3o2WmFZU2wrUzJCNE1xUHZU?=
 =?utf-8?B?Q0JtQURjdkVRbCtFY21uN3MvU0x6NERxRHpoUmtRQnRJVHRNenhyZytmc2hj?=
 =?utf-8?B?YWtTRXJvc2JSNlpwQVBseHhMTENYR0R2UHNWRzhYNkN2SGg2M2hla3JFV0tT?=
 =?utf-8?B?Q3h5NE5GLzZFZDROTFZrT2lKQ3ZWYloyKzdVWVB4VmxUVVRCZWRtLzNYVFp5?=
 =?utf-8?B?NUUvS0NUU0p0MGg5amxyWDFlOE53NDdCNW8rWkFlN3RGUGNlVU13SVZyZ2dM?=
 =?utf-8?B?UHpwVlllZkpYM1FnRGsxcFhhemlRWnpKTExnNngweHc0dVBKaXNvQlJMcnVJ?=
 =?utf-8?B?enlmYnpYd0taQk13aVdZZm0reFN0dVBVVFdrNTdlUXF4UG9xQ3R6d3lLMTBz?=
 =?utf-8?B?MzRKVmNPYUdQblNxbmYyc09Gakp6UW5HLzRUN0VPbXh4LzlQYTlUV3pQVTV6?=
 =?utf-8?B?cWVMZkQwSWNqbmpzSFRkM3pjUjVpVFNseFpOYU1CdnRjQW1Ha2VzQU9tSEwv?=
 =?utf-8?B?NFVPeE1sbFIzc1MwbHlONjYyeU1UNGw3S1k0b2pWaDRxNlpqcHdYdzQ3UkVE?=
 =?utf-8?Q?iTnz501g3R5H++0k=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_0A438884-E377-4976-8AA7-AA98F887DE73";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92437120-c7ff-4c6c-34d7-08da1bccc30e
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 15:05:48.5175
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GxlIqeyc+EJy5V5sXXHItd1waMAARA68ZOz2DKvN/3ruscHF3QtoGBxcZlhgsyortIG65XBy0PtPgj3JRnORJvV4VnFgfwJHmCLeoc91Pqs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4824
X-OriginatorOrg: citrix.com

--Apple-Mail=_0A438884-E377-4976-8AA7-AA98F887DE73
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hello all,

EXECUTIVE SUMMARY

The current form of the Xen Summit this year we=E2=80=99re considering =
is as follows:

1. Two days of =E2=80=9Cprimarily virtual=E2=80=9D talks, with a =
physical add-on for those in the Cambridge UK area, or willing to fly =
there.  This would be relatively low-key, probably hosted on a company =
premesis; listening to the talks in some conference rooms, with catered =
food / coffee provided, and pub / meal sessions in the evening.

2. Two days of =E2=80=9Cprimarily physical=E2=80=9D discussion sessions, =
at the same location.

To help with location planning, please fill out the following survey:

=
https://cryptpad.fr/form/#/2/form/view/93hTkvOnhFQhmzydZ4fONMTr8AABMPAEEou=
-SIS1hww/

BACKGROUND

We had initially planned to have a =E2=80=9Cprimarily physical summit =
with a virtual add-on=E2=80=9D, similar to the summits we=E2=80=99ve had =
in the past, in Romania this year.  We have decided to do something else =
this year for a number of reasons:

1. Difficulties in scheduling with the originally intended venue

2. A war going on in the neighboring country

3. One of the important contributor companies (based in Cambridge) =
unlikely to be able to send anyone outside the country this year.

My original idea was to flip from =E2=80=9Cprimarily physical with a =
virtual add-on=E2=80=9D to =E2=80=9Cprimarily virtual with a physical =
add-on=E2=80=9D: have the talks primarily on Big Blue Button as with the =
last two years, but have some locations where people could watch the =
talks together in some conference rooms, and have evening pub sessions / =
meals for those on-site. This would allow people living within driving =
distance of Cambridge =E2=80=94 and anyone willing to come to Cambridge =
for a few days =E2=80=94 to get the face-to-face interaction which is so =
helpful for a project like ours, while not requiring us to find and pay =
for a full-blown conference venue.

At the last community call, however, it was pointed out that the design =
sessions are significantly reduced in effectiveness when they aren=E2=80=99=
t being done in person with a whiteboard.  Hence the proposal to make =
the design sessions primarily physical, and somewhat separate from the =
virtual part of the summit.

It=E2=80=99s still a work in progress; feedback is welcome.  But your =
response regarding the probability that you=E2=80=99ll be able to =
participate will help us plan.

Thanks,
 -George Dunlap

--Apple-Mail=_0A438884-E377-4976-8AA7-AA98F887DE73
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJUQ8QACgkQshXHp8eE
G+06yQf/UbiwUcLPWCVqksaed10Nh1nOGhwg1jBmZKarQ6D4zNu1P/zmusYQw4Er
LYn0+dYsTy+vNOzW+6K24KWzVXYGE9J3vrwkH2qn5ejTLGuL3yD8WUqOUVjJM/kZ
3p47+AJvcfoblb0nuoGM+3QwhQPf8nHtC9su1aSnFho6S9gUtC0HDWbJqTayXHZT
irJV+ZFzfnrBB+Kjdd/tEgcjwWEyjJ1UxNKXK0i3tde9rNb4jMeBp91JlmRI9kFO
fEFY69VmcE1h/Jl+Wf1fZ4wAnO/YzJ+xZO8Y06NCI71YXahGdq2AWCzpc7oH75XP
oW8/PMAKtic7DlfkGhff1gIWvO6xRA==
=4HUC
-----END PGP SIGNATURE-----

--Apple-Mail=_0A438884-E377-4976-8AA7-AA98F887DE73--


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:21:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:21:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303104.517112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqu-0005Or-Fp; Mon, 11 Apr 2022 15:21:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303104.517112; Mon, 11 Apr 2022 15:21:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqu-0005ON-9x; Mon, 11 Apr 2022 15:21:16 +0000
Received: by outflank-mailman (input) for mailman id 303104;
 Mon, 11 Apr 2022 15:21:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1ndvqs-0005MA-RN
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:21:14 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 0611c4df-b9ab-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 17:21:13 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B12C169E;
 Mon, 11 Apr 2022 08:21:13 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A78F83F73B;
 Mon, 11 Apr 2022 08:21:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0611c4df-b9ab-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v7 2/7] xen/sched: create public function for cpupools creation
Date: Mon, 11 Apr 2022 16:20:56 +0100
Message-Id: <20220411152101.17539-3-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220411152101.17539-1-luca.fancellu@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>

Create new public function to create cpupools, can take as parameter
the scheduler id or a negative value that means the default Xen
scheduler will be used.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v7:
- no changes
Changes in v6:
- add R-by
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- Fixed comment (Andrew)
Changes in v2:
- cpupool_create_pool doesn't check anymore for pool id uniqueness
  before calling cpupool_create. Modified commit message accordingly
---
 xen/common/sched/cpupool.c | 15 +++++++++++++++
 xen/include/xen/sched.h    | 16 ++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index a6da4970506a..89a891af7076 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1219,6 +1219,21 @@ static void cpupool_hypfs_init(void)
 
 #endif /* CONFIG_HYPFS */
 
+struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id)
+{
+    struct cpupool *pool;
+
+    if ( sched_id < 0 )
+        sched_id = scheduler_get_default()->sched_id;
+
+    pool = cpupool_create(pool_id, sched_id);
+
+    BUG_ON(IS_ERR(pool));
+    cpupool_put(pool);
+
+    return pool;
+}
+
 static int __init cf_check cpupool_init(void)
 {
     unsigned int cpu;
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index ed8539f6d297..0164db996b8b 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1153,6 +1153,22 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c);
 int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op);
 unsigned int cpupool_get_id(const struct domain *d);
 const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool);
+
+/*
+ * cpupool_create_pool - Creates a cpupool
+ * @pool_id: id of the pool to be created
+ * @sched_id: id of the scheduler to be used for the pool
+ *
+ * Creates a cpupool with pool_id id.
+ * The sched_id parameter identifies the scheduler to be used, if it is
+ * negative, the default scheduler of Xen will be used.
+ *
+ * returns:
+ *     pointer to the struct cpupool just created, or Xen will panic in case of
+ *     error
+ */
+struct cpupool *cpupool_create_pool(unsigned int pool_id, int sched_id);
+
 extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:21:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:21:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303107.517151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqy-0006Qo-Ew; Mon, 11 Apr 2022 15:21:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303107.517151; Mon, 11 Apr 2022 15:21:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqy-0006QX-B9; Mon, 11 Apr 2022 15:21:20 +0000
Received: by outflank-mailman (input) for mailman id 303107;
 Mon, 11 Apr 2022 15:21:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1ndvqw-0005M5-Kk
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:21:18 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 0818163d-b9ab-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 17:21:17 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7FFBA169C;
 Mon, 11 Apr 2022 08:21:16 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D76E93F73B;
 Mon, 11 Apr 2022 08:21:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0818163d-b9ab-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time
Date: Mon, 11 Apr 2022 16:20:58 +0100
Message-Id: <20220411152101.17539-5-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220411152101.17539-1-luca.fancellu@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>

Introduce a way to create different cpupools at boot time, this is
particularly useful on ARM big.LITTLE system where there might be the
need to have different cpupools for each type of core, but also
systems using NUMA can have different cpu pools for each node.

The feature on arm relies on a specification of the cpupools from the
device tree to build pools and assign cpus to them.

ACPI is not supported for this feature.

With this patch, cpupool0 can now have less cpus than the number of
online ones, so update the default case for opt_dom0_max_vcpus.

Documentation is created to explain the feature.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Changes in v7:
- rename xen/common/boot_cpupools.c to xen/common/sched/boot-cpupool.c (Jan)
- reverted xen/common/Makefile, add entry in xen/common/sched/Makefile
- changed line in MAINTAINERS under CPU POOLS section (Dario)
- Fix documentation, update opt_dom0_max_vcpus to the number of cpu in
  cpupool0 (Julien)
Changes in v6:
- Changed docs, return if booted with ACPI in btcpupools_dtb_parse,
  panic if /chosen does not exists. Changed commit message (Julien)
- Add Juergen R-by for the xen/common/sched part that didn't change
Changes in v5:
- Fixed wrong variable name, swapped schedulers, add scheduler info
  in the printk (Stefano)
- introduce assert in cpupool_init and btcpupools_get_cpupool_id to
  harden the code
Changes in v4:
- modify Makefile to put in *.init.o, fixed stubs and macro (Jan)
- fixed docs, fix brakets (Stefano)
- keep cpu0 in Pool-0 (Julien)
- moved printk from btcpupools_allocate_pools to
  btcpupools_get_cpupool_id
- Add to docs constraint about cpu0 and Pool-0
Changes in v3:
- Add newline to cpupools.txt and removed "default n" from Kconfig (Jan)
- Fixed comment, moved defines, used global cpu_online_map, use
  HAS_DEVICE_TREE instead of ARM and place arch specific code in header
  (Juergen)
- Fix brakets, x86 code only panic, get rid of scheduler dt node, don't
  save pool pointer and look for it from the pool list (Stefano)
- Changed data structures to allow modification to the code.
Changes in v2:
- Move feature to common code (Juergen)
- Try to decouple dtb parse and cpupool creation to allow
  more way to specify cpupools (for example command line)
- Created standalone dt node for the scheduler so it can
  be used in future work to set scheduler specific
  parameters
- Use only auto generated ids for cpupools
---
 MAINTAINERS                            |   2 +-
 docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
 xen/arch/arm/domain_build.c            |   5 +-
 xen/arch/arm/include/asm/smp.h         |   3 +
 xen/common/Kconfig                     |   7 +
 xen/common/sched/Makefile              |   1 +
 xen/common/sched/boot-cpupool.c        | 207 +++++++++++++++++++++++++
 xen/common/sched/cpupool.c             |  12 +-
 xen/include/xen/sched.h                |  14 ++
 9 files changed, 388 insertions(+), 3 deletions(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/common/sched/boot-cpupool.c

diff --git a/MAINTAINERS b/MAINTAINERS
index 6a097b43eb9a..7963c9232c07 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -274,7 +274,7 @@ CPU POOLS
 M:	Juergen Gross <jgross@suse.com>
 M:	Dario Faggioli <dfaggioli@suse.com>
 S:	Supported
-F:	xen/common/sched/cpupool.c
+F:	xen/common/sched/*cpupool.c
 
 DEVICE TREE
 M:	Stefano Stabellini <sstabellini@kernel.org>
diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
new file mode 100644
index 000000000000..1f640d680317
--- /dev/null
+++ b/docs/misc/arm/device-tree/cpupools.txt
@@ -0,0 +1,140 @@
+Boot time cpupools
+==================
+
+When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
+create cpupools during boot phase by specifying them in the device tree.
+ACPI is not supported for this feature.
+
+Cpupools specification nodes shall be direct childs of /chosen node.
+Each cpupool node contains the following properties:
+
+- compatible (mandatory)
+
+    Must always include the compatiblity string: "xen,cpupool".
+
+- cpupool-cpus (mandatory)
+
+    Must be a list of device tree phandle to nodes describing cpus (e.g. having
+    device_type = "cpu"), it can't be empty.
+
+- cpupool-sched (optional)
+
+    Must be a string having the name of a Xen scheduler. Check the sched=<...>
+    boot argument for allowed values [1]. When this property is omitted, the Xen
+    default scheduler will be used.
+
+
+Constraints
+===========
+
+If no cpupools are specified, all cpus will be assigned to one cpupool
+implicitly created (Pool-0).
+
+If cpupools node are specified, but not every cpu brought up by Xen is assigned,
+all the not assigned cpu will be assigned to an additional cpupool.
+
+If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
+stop.
+
+The boot cpu must be assigned to Pool-0, so the cpupool containing that core
+will become Pool-0 automatically.
+
+
+Examples
+========
+
+A system having two types of core, the following device tree specification will
+instruct Xen to have two cpupools:
+
+- The cpupool described by node cpupool_a will have 4 cpus assigned.
+- The cpupool described by node cpupool_b will have 2 cpus assigned.
+
+The following example can work only if hmp-unsafe=1 is passed to Xen boot
+arguments, otherwise not all cores will be brought up by Xen and the cpupool
+creation process will stop Xen.
+
+
+a72_1: cpu@0 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x0>;
+        device_type = "cpu";
+        [...]
+};
+
+a72_2: cpu@1 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x1>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_1: cpu@100 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x100>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_2: cpu@101 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x101>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_3: cpu@102 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x102>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_4: cpu@103 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x103>;
+        device_type = "cpu";
+        [...]
+};
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a53_1 &a53_2 &a53_3 &a53_4>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "credit2";
+    };
+
+    [...]
+
+};
+
+
+A system having the cpupools specification below will instruct Xen to have three
+cpupools:
+
+- The cpupool described by node cpupool_a will have 2 cpus assigned.
+- The cpupool described by node cpupool_b will have 2 cpus assigned.
+- An additional cpupool will be created, having 2 cpus assigned (created by Xen
+  with all the unassigned cpus a53_3 and a53_4).
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a53_1 &a53_2>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "null";
+    };
+
+    [...]
+
+};
+
+[1] docs/misc/xen-command-line.pandoc
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8be01678de05..9aa6ae27c40f 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -73,7 +73,10 @@ custom_param("dom0_mem", parse_dom0_mem);
 unsigned int __init dom0_max_vcpus(void)
 {
     if ( opt_dom0_max_vcpus == 0 )
-        opt_dom0_max_vcpus = num_online_cpus();
+    {
+        ASSERT(cpupool0);
+        opt_dom0_max_vcpus = cpumask_weight(cpupool_valid_cpus(cpupool0));
+    }
     if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
         opt_dom0_max_vcpus = MAX_VIRT_CPUS;
 
diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h
index af5a2fe65266..83c0cd69767b 100644
--- a/xen/arch/arm/include/asm/smp.h
+++ b/xen/arch/arm/include/asm/smp.h
@@ -34,6 +34,9 @@ extern void init_secondary(void);
 extern void smp_init_cpus(void);
 extern void smp_clear_cpu_maps (void);
 extern int smp_get_max_cpus (void);
+
+#define cpu_physical_id(cpu) cpu_logical_map(cpu)
+
 #endif
 
 /*
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index d921c74d615e..70aac5220e75 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -22,6 +22,13 @@ config GRANT_TABLE
 
 	  If unsure, say Y.
 
+config BOOT_TIME_CPUPOOLS
+	bool "Create cpupools at boot time"
+	depends on HAS_DEVICE_TREE
+	help
+	  Creates cpupools during boot time and assigns cpus to them. Cpupools
+	  options can be specified in the device tree.
+
 config ALTERNATIVE_CALL
 	bool
 
diff --git a/xen/common/sched/Makefile b/xen/common/sched/Makefile
index 3537f2a68d69..697bd54bfe93 100644
--- a/xen/common/sched/Makefile
+++ b/xen/common/sched/Makefile
@@ -1,3 +1,4 @@
+obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot-cpupool.init.o
 obj-y += cpupool.o
 obj-$(CONFIG_SCHED_ARINC653) += arinc653.o
 obj-$(CONFIG_SCHED_CREDIT) += credit.o
diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c
new file mode 100644
index 000000000000..9429a5025fc4
--- /dev/null
+++ b/xen/common/sched/boot-cpupool.c
@@ -0,0 +1,207 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * xen/common/boot_cpupools.c
+ *
+ * Code to create cpupools at boot time.
+ *
+ * Copyright (C) 2022 Arm Ltd.
+ */
+
+#include <xen/sched.h>
+#include <asm/acpi.h>
+
+/*
+ * pool_cpu_map:   Index is logical cpu number, content is cpupool id, (-1) for
+ *                 unassigned.
+ * pool_sched_map: Index is cpupool id, content is scheduler id, (-1) for
+ *                 unassigned.
+ */
+static int __initdata pool_cpu_map[NR_CPUS]   = { [0 ... NR_CPUS-1] = -1 };
+static int __initdata pool_sched_map[NR_CPUS] = { [0 ... NR_CPUS-1] = -1 };
+static unsigned int __initdata next_pool_id;
+
+#define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
+#define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
+
+static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
+{
+    unsigned int i;
+
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpu_physical_id(i) == hwid )
+            return i;
+    }
+
+    return -1;
+}
+
+static int __init
+get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
+{
+    int cpu_num;
+    const __be32 *prop;
+    unsigned int cpu_reg;
+
+    prop = dt_get_property(cpu_node, "reg", NULL);
+    if ( !prop )
+        return BTCPUPOOLS_DT_NODE_NO_REG;
+
+    cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node));
+
+    cpu_num = get_logical_cpu_from_hw_id(cpu_reg);
+    if ( cpu_num < 0 )
+        return BTCPUPOOLS_DT_NODE_NO_LOG_CPU;
+
+    return cpu_num;
+}
+
+static int __init check_and_get_sched_id(const char* scheduler_name)
+{
+    int sched_id = sched_get_id_by_name(scheduler_name);
+
+    if ( sched_id < 0 )
+        panic("Scheduler %s does not exists!\n", scheduler_name);
+
+    return sched_id;
+}
+
+void __init btcpupools_dtb_parse(void)
+{
+    const struct dt_device_node *chosen, *node;
+
+    if ( !acpi_disabled )
+        return;
+
+    chosen = dt_find_node_by_path("/chosen");
+    if ( !chosen )
+        panic("/chosen missing. Boot time cpupools can't be parsed from DT.\n");
+
+    dt_for_each_child_node(chosen, node)
+    {
+        const struct dt_device_node *phandle_node;
+        int sched_id = -1;
+        const char* scheduler_name;
+        unsigned int i = 0;
+
+        if ( !dt_device_is_compatible(node, "xen,cpupool") )
+            continue;
+
+        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) )
+            sched_id = check_and_get_sched_id(scheduler_name);
+
+        phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
+        if ( !phandle_node )
+            panic("Missing or empty cpupool-cpus property!\n");
+
+        while ( phandle_node )
+        {
+            int cpu_num;
+
+            cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
+
+            if ( cpu_num < 0 )
+                panic("Error retrieving logical cpu from node %s (%d)\n",
+                      dt_node_name(node), cpu_num);
+
+            if ( pool_cpu_map[cpu_num] != -1 )
+                panic("Logical cpu %d already added to a cpupool!\n", cpu_num);
+
+            pool_cpu_map[cpu_num] = next_pool_id;
+
+            phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
+        }
+
+        /* Save scheduler choice for this cpupool id */
+        pool_sched_map[next_pool_id] = sched_id;
+
+        /* Let Xen generate pool ids */
+        next_pool_id++;
+    }
+}
+
+void __init btcpupools_allocate_pools(void)
+{
+    unsigned int i;
+    bool add_extra_cpupool = false;
+    int swap_id = -1;
+
+    /*
+     * If there are no cpupools, the value of next_pool_id is zero, so the code
+     * below will assign every cpu to cpupool0 as the default behavior.
+     * When there are cpupools, the code below is assigning all the not
+     * assigned cpu to a new pool (next_pool_id value is the last id + 1).
+     * In the same loop we check if there is any assigned cpu that is not
+     * online.
+     */
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpumask_test_cpu(i, &cpu_online_map) )
+        {
+            /* Unassigned cpu gets next_pool_id pool id value */
+            if ( pool_cpu_map[i] < 0 )
+            {
+                pool_cpu_map[i] = next_pool_id;
+                add_extra_cpupool = true;
+            }
+
+            /*
+             * Cpu0 must be in cpupool0, otherwise some operations like moving
+             * cpus between cpupools, cpu hotplug, destroying cpupools, shutdown
+             * of the host, might not work in a sane way.
+             */
+            if ( !i && (pool_cpu_map[0] != 0) )
+                swap_id = pool_cpu_map[0];
+
+            if ( swap_id != -1 )
+            {
+                if ( pool_cpu_map[i] == swap_id )
+                    pool_cpu_map[i] = 0;
+                else if ( pool_cpu_map[i] == 0 )
+                    pool_cpu_map[i] = swap_id;
+            }
+        }
+        else
+        {
+            if ( pool_cpu_map[i] >= 0 )
+                panic("Pool-%d contains cpu%u that is not online!\n",
+                      pool_cpu_map[i], i);
+        }
+    }
+
+    /* A swap happened, swap schedulers between cpupool id 0 and the other */
+    if ( swap_id != -1 )
+    {
+        int swap_sched = pool_sched_map[swap_id];
+
+        pool_sched_map[swap_id] = pool_sched_map[0];
+        pool_sched_map[0] = swap_sched;
+    }
+
+    if ( add_extra_cpupool )
+        next_pool_id++;
+
+    /* Create cpupools with selected schedulers */
+    for ( i = 0; i < next_pool_id; i++ )
+        cpupool_create_pool(i, pool_sched_map[i]);
+}
+
+unsigned int __init btcpupools_get_cpupool_id(unsigned int cpu)
+{
+    ASSERT((cpu < NR_CPUS) && (pool_cpu_map[cpu] >= 0));
+
+    printk(XENLOG_INFO "Logical CPU %u in Pool-%d (Scheduler id: %d).\n",
+           cpu, pool_cpu_map[cpu], pool_sched_map[pool_cpu_map[cpu]]);
+
+    return pool_cpu_map[cpu];
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 89a891af7076..86a175f99cd5 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1247,12 +1247,22 @@ static int __init cf_check cpupool_init(void)
     cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
+    btcpupools_dtb_parse();
+
+    btcpupools_allocate_pools();
+
     spin_lock(&cpupool_lock);
 
     cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
 
     for_each_cpu ( cpu, &cpupool_free_cpus )
-        cpupool_assign_cpu_locked(cpupool0, cpu);
+    {
+        unsigned int pool_id = btcpupools_get_cpupool_id(cpu);
+        struct cpupool *pool = cpupool_find_by_id(pool_id);
+
+        ASSERT(pool);
+        cpupool_assign_cpu_locked(pool, cpu);
+    }
 
     spin_unlock(&cpupool_lock);
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 4442a1940c25..74b3aae10b94 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1184,6 +1184,20 @@ extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 
+#ifdef CONFIG_BOOT_TIME_CPUPOOLS
+void btcpupools_allocate_pools(void);
+unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
+void btcpupools_dtb_parse(void);
+
+#else /* !CONFIG_BOOT_TIME_CPUPOOLS */
+static inline void btcpupools_allocate_pools(void) {}
+static inline void btcpupools_dtb_parse(void) {}
+static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
+{
+    return 0;
+}
+#endif
+
 #endif /* __SCHED_H__ */
 
 /*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:21:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:21:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303105.517116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqu-0005U0-O9; Mon, 11 Apr 2022 15:21:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303105.517116; Mon, 11 Apr 2022 15:21:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqu-0005Sa-IC; Mon, 11 Apr 2022 15:21:16 +0000
Received: by outflank-mailman (input) for mailman id 303105;
 Mon, 11 Apr 2022 15:21:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1ndvqs-0005M5-V7
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:21:15 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 052d3d00-b9ab-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 17:21:12 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FFEC169C;
 Mon, 11 Apr 2022 08:21:11 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8BA183F73B;
 Mon, 11 Apr 2022 08:21:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 052d3d00-b9ab-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v7 1/7] tools/cpupools: Give a name to unnamed cpupools
Date: Mon, 11 Apr 2022 16:20:55 +0100
Message-Id: <20220411152101.17539-2-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220411152101.17539-1-luca.fancellu@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>

With the introduction of boot time cpupools, Xen can create many
different cpupools at boot time other than cpupool with id 0.

Since these newly created cpupools can't have an
entry in Xenstore, create the entry using xen-init-dom0
helper with the usual convention: Pool-<cpupool id>.

Given the change, remove the check for poolid == 0 from
libxl_cpupoolid_to_name(...).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
---
Changes in v7:
- Add R-by from Anthony
Changes in v6:
- Reworked loop to have only one error path (Anthony)
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- no changes, add R-by
Changes in v2:
 - Remove unused variable, moved xc_cpupool_infofree
   ahead to simplify the code, use asprintf (Juergen)
---
 tools/helpers/xen-init-dom0.c  | 37 +++++++++++++++++++++++++++++++++-
 tools/libs/light/libxl_utils.c |  3 +--
 2 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
index c99224a4b607..37eff8868f25 100644
--- a/tools/helpers/xen-init-dom0.c
+++ b/tools/helpers/xen-init-dom0.c
@@ -43,7 +43,10 @@ int main(int argc, char **argv)
     int rc;
     struct xs_handle *xsh = NULL;
     xc_interface *xch = NULL;
-    char *domname_string = NULL, *domid_string = NULL;
+    char *domname_string = NULL, *domid_string = NULL,
+         *pool_path = NULL, *pool_name = NULL;
+    xc_cpupoolinfo_t *xcinfo;
+    unsigned int pool_id = 0;
     libxl_uuid uuid;
 
     /* Accept 0 or 1 argument */
@@ -114,9 +117,41 @@ int main(int argc, char **argv)
         goto out;
     }
 
+    /* Create an entry in xenstore for each cpupool on the system */
+    do {
+        xcinfo = xc_cpupool_getinfo(xch, pool_id);
+        if (xcinfo != NULL) {
+            if (xcinfo->cpupool_id != pool_id)
+                pool_id = xcinfo->cpupool_id;
+            xc_cpupool_infofree(xch, xcinfo);
+            if (asprintf(&pool_path, "/local/pool/%d/name", pool_id) <= 0) {
+                fprintf(stderr, "cannot allocate memory for pool path\n");
+                rc = 1;
+                goto out;
+            }
+            if (asprintf(&pool_name, "Pool-%d", pool_id) <= 0) {
+                fprintf(stderr, "cannot allocate memory for pool name\n");
+                rc = 1;
+                goto out;
+            }
+            pool_id++;
+            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
+                          strlen(pool_name))) {
+                fprintf(stderr, "cannot set pool name\n");
+                rc = 1;
+                goto out;
+            }
+            free(pool_name);
+            free(pool_path);
+            pool_path = pool_name = NULL;
+        }
+    } while(xcinfo != NULL);
+
     printf("Done setting up Dom0\n");
 
 out:
+    free(pool_path);
+    free(pool_name);
     free(domid_string);
     free(domname_string);
     xs_close(xsh);
diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c
index b91c2cafa223..81780da3ff40 100644
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -151,8 +151,7 @@ char *libxl_cpupoolid_to_name(libxl_ctx *ctx, uint32_t poolid)
 
     snprintf(path, sizeof(path), "/local/pool/%d/name", poolid);
     s = xs_read(ctx->xsh, XBT_NULL, path, &len);
-    if (!s && (poolid == 0))
-        return strdup("Pool-0");
+
     return s;
 }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:21:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:21:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303103.517107 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqu-0005MT-6p; Mon, 11 Apr 2022 15:21:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303103.517107; Mon, 11 Apr 2022 15:21:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqu-0005MM-2u; Mon, 11 Apr 2022 15:21:16 +0000
Received: by outflank-mailman (input) for mailman id 303103;
 Mon, 11 Apr 2022 15:21:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1ndvqs-0005M5-8P
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:21:14 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 04876fb6-b9ab-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 17:21:12 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 555DF1570;
 Mon, 11 Apr 2022 08:21:10 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AACE23F73B;
 Mon, 11 Apr 2022 08:21:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04876fb6-b9ab-11ec-8fbc-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v7 0/7] Boot time cpupools
Date: Mon, 11 Apr 2022 16:20:54 +0100
Message-Id: <20220411152101.17539-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

This serie introduces a feature for Xen to create cpu pools at boot time, the
feature is enabled using a configurable that is disabled by default.
The boot time cpupool feature relies on the device tree to describe the cpu
pools.
Another feature is introduced by the serie, the possibility to assign a
dom0less guest to a cpupool at boot time.

Here follows an example, Xen is built with CONFIG_BOOT_TIME_CPUPOOLS=y.

>From the DT:

  [...]

  a72_0: cpu@0 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x0>;
    device_type = "cpu";
    [...]
  };

  a72_1: cpu@1 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x1>;
    device_type = "cpu";
    [...]
  };

  a53_0: cpu@100 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x100>;
    device_type = "cpu";
    [...]
  };

  a53_1: cpu@101 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x101>;
    device_type = "cpu";
    [...]
  };

  a53_2: cpu@102 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x102>;
    device_type = "cpu";
    [...]
  };

  a53_3: cpu@103 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x103>;
    device_type = "cpu";
    [...]
  };

  chosen {
    #size-cells = <0x1>;
    #address-cells = <0x1>;
    xen,dom0-bootargs = "...";
    xen,xen-bootargs = "...";

    cpupool0 {
      compatible = "xen,cpupool";
      cpupool-cpus = <&a72_0 &a72_1>;
      cpupool-sched = "credit2";
    };

    cp1: cpupool1 {
      compatible = "xen,cpupool";
      cpupool-cpus = <&a53_0 &a53_1 &a53_2 &a53_3>;
      cpupool-sched = "null";
    };

    module@0 {
      reg = <0x80080000 0x1300000>;
      compatible = "multiboot,module";
    };

    domU1 {
      #size-cells = <0x1>;
      #address-cells = <0x1>;
      compatible = "xen,domain";
      cpus = <1>;
      memory = <0 0xC0000>;
      vpl011;
      domain-cpupool = <&cp1>;

      module@92000000 {
        compatible = "multiboot,kernel", "multiboot,module";
        reg = <0x92000000 0x1ffffff>;
        bootargs = "...";
      };
    };
  };

  [...]

The example DT is instructing Xen to have two cpu pools, one having two phisical
cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the
null scheduler and from the /chosen node we can see that a dom0less guest will
be started on that cpu pool.

In this particular case Xen must boot with different type of cpus, so the
boot argument hmp_unsafe must be enabled.

Luca Fancellu (7):
  tools/cpupools: Give a name to unnamed cpupools
  xen/sched: create public function for cpupools creation
  xen/sched: retrieve scheduler id by name
  xen/cpupool: Create different cpupools at boot time
  xen/cpupool: Don't allow removing cpu0 from cpupool0
  arm/dom0less: assign dom0less guests to cpupools
  xen/cpupool: Allow cpupool0 to use different scheduler

 MAINTAINERS                            |   2 +-
 docs/misc/arm/device-tree/booting.txt  |   5 +
 docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++
 tools/helpers/xen-init-dom0.c          |  37 +++-
 tools/libs/light/libxl_utils.c         |   3 +-
 xen/arch/arm/domain_build.c            |  19 +-
 xen/arch/arm/include/asm/smp.h         |   3 +
 xen/common/Kconfig                     |   7 +
 xen/common/domain.c                    |   2 +-
 xen/common/sched/Makefile              |   1 +
 xen/common/sched/boot-cpupool.c        | 234 +++++++++++++++++++++++++
 xen/common/sched/core.c                |  40 +++--
 xen/common/sched/cpupool.c             |  43 ++++-
 xen/include/public/domctl.h            |   5 +-
 xen/include/xen/sched.h                |  53 ++++++
 15 files changed, 563 insertions(+), 31 deletions(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/common/sched/boot-cpupool.c

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:21:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:21:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303108.517155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqy-0006V0-RW; Mon, 11 Apr 2022 15:21:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303108.517155; Mon, 11 Apr 2022 15:21:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqy-0006TN-LR; Mon, 11 Apr 2022 15:21:20 +0000
Received: by outflank-mailman (input) for mailman id 303108;
 Mon, 11 Apr 2022 15:21:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1ndvqx-0005MA-0K
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:21:19 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 08cf3f02-b9ab-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 17:21:18 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98C0B1570;
 Mon, 11 Apr 2022 08:21:17 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B66953F73B;
 Mon, 11 Apr 2022 08:21:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08cf3f02-b9ab-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH v7 5/7] xen/cpupool: Don't allow removing cpu0 from cpupool0
Date: Mon, 11 Apr 2022 16:20:59 +0100
Message-Id: <20220411152101.17539-6-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220411152101.17539-1-luca.fancellu@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>

Cpu0 must remain in cpupool0, otherwise some operations like moving cpus
between cpupools, cpu hotplug, destroying cpupools, shutdown of the host,
might not work in a sane way.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Changes in v7:
- new patch
---
 xen/common/sched/cpupool.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 86a175f99cd5..0a93bcc631bf 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -572,6 +572,7 @@ static long cf_check cpupool_unassign_cpu_helper(void *info)
  * possible failures:
  * - last cpu and still active domains in cpupool
  * - cpu just being unplugged
+ * - Attempt to remove boot cpu from cpupool0
  */
 static int cpupool_unassign_cpu(struct cpupool *c, unsigned int cpu)
 {
@@ -582,7 +583,12 @@ static int cpupool_unassign_cpu(struct cpupool *c, unsigned int cpu)
     debugtrace_printk("cpupool_unassign_cpu(pool=%u,cpu=%d)\n",
                       c->cpupool_id, cpu);
 
-    if ( !cpu_online(cpu) )
+    /*
+     * Cpu0 must remain in cpupool0, otherwise some operations like moving cpus
+     * between cpupools, cpu hotplug, destroying cpupools, shutdown of the host,
+     * might not work in a sane way.
+     */
+    if ( (!c->cpupool_id && !cpu) || !cpu_online(cpu) )
         return -EINVAL;
 
     master_cpu = sched_get_resource_cpu(cpu);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:21:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:21:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303106.517140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqw-00067Z-6K; Mon, 11 Apr 2022 15:21:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303106.517140; Mon, 11 Apr 2022 15:21:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvqw-000677-2G; Mon, 11 Apr 2022 15:21:18 +0000
Received: by outflank-mailman (input) for mailman id 303106;
 Mon, 11 Apr 2022 15:21:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1ndvqu-0005MA-Bg
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:21:16 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 0712cfd2-b9ab-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 17:21:15 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9F7491570;
 Mon, 11 Apr 2022 08:21:14 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5257E3F73B;
 Mon, 11 Apr 2022 08:21:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0712cfd2-b9ab-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v7 3/7] xen/sched: retrieve scheduler id by name
Date: Mon, 11 Apr 2022 16:20:57 +0100
Message-Id: <20220411152101.17539-4-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220411152101.17539-1-luca.fancellu@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>

Add a static function to retrieve the scheduler pointer using the
scheduler name.

Add a public function to retrieve the scheduler id by the scheduler
name that makes use of the new static function.

Take the occasion to replace open coded scheduler search with the
new static function in scheduler_init.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
---
Changes in v7:
- Add R-by (Dario)
Changes in v6:
- no changes
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- add R-by
Changes in v2:
- replace open coded scheduler search in scheduler_init (Juergen)
---
 xen/common/sched/core.c | 40 ++++++++++++++++++++++++++--------------
 xen/include/xen/sched.h | 11 +++++++++++
 2 files changed, 37 insertions(+), 14 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab67818106..48ee01420fb8 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2947,10 +2947,30 @@ void scheduler_enable(void)
     scheduler_active = true;
 }
 
+static inline
+const struct scheduler *__init sched_get_by_name(const char *sched_name)
+{
+    unsigned int i;
+
+    for ( i = 0; i < NUM_SCHEDULERS; i++ )
+        if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) )
+            return schedulers[i];
+
+    return NULL;
+}
+
+int __init sched_get_id_by_name(const char *sched_name)
+{
+    const struct scheduler *scheduler = sched_get_by_name(sched_name);
+
+    return scheduler ? scheduler->sched_id : -1;
+}
+
 /* Initialise the data structures. */
 void __init scheduler_init(void)
 {
     struct domain *idle_domain;
+    const struct scheduler *scheduler;
     int i;
 
     scheduler_enable();
@@ -2981,25 +3001,17 @@ void __init scheduler_init(void)
                    schedulers[i]->opt_name);
             schedulers[i] = NULL;
         }
-
-        if ( schedulers[i] && !ops.name &&
-             !strcmp(schedulers[i]->opt_name, opt_sched) )
-            ops = *schedulers[i];
     }
 
-    if ( !ops.name )
+    scheduler = sched_get_by_name(opt_sched);
+    if ( !scheduler )
     {
         printk("Could not find scheduler: %s\n", opt_sched);
-        for ( i = 0; i < NUM_SCHEDULERS; i++ )
-            if ( schedulers[i] &&
-                 !strcmp(schedulers[i]->opt_name, CONFIG_SCHED_DEFAULT) )
-            {
-                ops = *schedulers[i];
-                break;
-            }
-        BUG_ON(!ops.name);
-        printk("Using '%s' (%s)\n", ops.name, ops.opt_name);
+        scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT);
+        BUG_ON(!scheduler);
+        printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name);
     }
+    ops = *scheduler;
 
     if ( cpu_schedule_up(0) )
         BUG();
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 0164db996b8b..4442a1940c25 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -764,6 +764,17 @@ void sched_destroy_domain(struct domain *d);
 long sched_adjust(struct domain *, struct xen_domctl_scheduler_op *);
 long sched_adjust_global(struct xen_sysctl_scheduler_op *);
 int  sched_id(void);
+
+/*
+ * sched_get_id_by_name - retrieves a scheduler id given a scheduler name
+ * @sched_name: scheduler name as a string
+ *
+ * returns:
+ *     positive value being the scheduler id, on success
+ *     negative value if the scheduler name is not found.
+ */
+int sched_get_id_by_name(const char *sched_name);
+
 void vcpu_wake(struct vcpu *v);
 long vcpu_yield(void);
 void vcpu_sleep_nosync(struct vcpu *v);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:21:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:21:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303109.517173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvr1-000746-8P; Mon, 11 Apr 2022 15:21:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303109.517173; Mon, 11 Apr 2022 15:21:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvr1-00073h-2B; Mon, 11 Apr 2022 15:21:23 +0000
Received: by outflank-mailman (input) for mailman id 303109;
 Mon, 11 Apr 2022 15:21:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1ndvqz-0005MA-6x
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:21:21 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 09e84cbe-b9ab-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 17:21:20 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E95D1570;
 Mon, 11 Apr 2022 08:21:19 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D0B783F73B;
 Mon, 11 Apr 2022 08:21:17 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09e84cbe-b9ab-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH v7 6/7] arm/dom0less: assign dom0less guests to cpupools
Date: Mon, 11 Apr 2022 16:21:00 +0100
Message-Id: <20220411152101.17539-7-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220411152101.17539-1-luca.fancellu@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>

Introduce domain-cpupool property of a xen,domain device tree node,
that specifies the cpupool device tree handle of a xen,cpupool node
that identifies a cpupool created at boot time where the guest will
be assigned on creation.

Add member to the xen_domctl_createdomain public interface so the
XEN_DOMCTL_INTERFACE_VERSION version is bumped.

Add public function to retrieve a pool id from the device tree
cpupool node.

Update documentation about the property.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes in v7:
- Add comment for cpupool_id struct member. (Jan)
Changes in v6:
- no changes
Changes in v5:
- no changes
Changes in v4:
- no changes
- add R-by
Changes in v3:
- Use explicitely sized integer for struct xen_domctl_createdomain
  cpupool_id member. (Stefano)
- Changed code due to previous commit code changes
Changes in v2:
- Moved cpupool_id from arch specific to common part (Juergen)
- Implemented functions to retrieve the cpupool id from the
  cpupool dtb node.
---
 docs/misc/arm/device-tree/booting.txt |  5 +++++
 xen/arch/arm/domain_build.c           | 14 +++++++++++++-
 xen/common/domain.c                   |  2 +-
 xen/common/sched/boot-cpupool.c       | 24 ++++++++++++++++++++++++
 xen/include/public/domctl.h           |  5 ++++-
 xen/include/xen/sched.h               |  9 +++++++++
 6 files changed, 56 insertions(+), 3 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index a94125394e35..7b4a29a2c293 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -188,6 +188,11 @@ with the following properties:
     An empty property to request the memory of the domain to be
     direct-map (guest physical address == physical address).
 
+- domain-cpupool
+
+    Optional. Handle to a xen,cpupool device tree node that identifies the
+    cpupool where the guest will be started at boot.
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 9aa6ae27c40f..9787104c3d31 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3175,7 +3175,8 @@ static int __init construct_domU(struct domain *d,
 void __init create_domUs(void)
 {
     struct dt_device_node *node;
-    const struct dt_device_node *chosen = dt_find_node_by_path("/chosen");
+    const struct dt_device_node *cpupool_node,
+                                *chosen = dt_find_node_by_path("/chosen");
 
     BUG_ON(chosen == NULL);
     dt_for_each_child_node(chosen, node)
@@ -3244,6 +3245,17 @@ void __init create_domUs(void)
                                          vpl011_virq - 32 + 1);
         }
 
+        /* Get the optional property domain-cpupool */
+        cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0);
+        if ( cpupool_node )
+        {
+            int pool_id = btcpupools_get_domain_pool_id(cpupool_node);
+            if ( pool_id < 0 )
+                panic("Error getting cpupool id from domain-cpupool (%d)\n",
+                      pool_id);
+            d_cfg.cpupool_id = pool_id;
+        }
+
         /*
          * The variable max_init_domid is initialized with zero, so here it's
          * very important to use the pre-increment operator to call
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 351029f8b239..0827400f4f49 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -698,7 +698,7 @@ struct domain *domain_create(domid_t domid,
         if ( !d->pbuf )
             goto fail;
 
-        if ( (err = sched_init_domain(d, 0)) != 0 )
+        if ( (err = sched_init_domain(d, config->cpupool_id)) != 0 )
             goto fail;
 
         if ( (err = late_hwdom_init(d)) != 0 )
diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c
index 9429a5025fc4..240bae4cebb8 100644
--- a/xen/common/sched/boot-cpupool.c
+++ b/xen/common/sched/boot-cpupool.c
@@ -22,6 +22,8 @@ static unsigned int __initdata next_pool_id;
 
 #define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
 #define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
+#define BTCPUPOOLS_DT_WRONG_NODE      (-3)
+#define BTCPUPOOLS_DT_CORRUPTED_NODE  (-4)
 
 static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
 {
@@ -56,6 +58,28 @@ get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
     return cpu_num;
 }
 
+int __init btcpupools_get_domain_pool_id(const struct dt_device_node *node)
+{
+    const struct dt_device_node *phandle_node;
+    int cpu_num;
+
+    if ( !dt_device_is_compatible(node, "xen,cpupool") )
+        return BTCPUPOOLS_DT_WRONG_NODE;
+    /*
+     * Get first cpu listed in the cpupool, from its reg it's possible to
+     * retrieve the cpupool id.
+     */
+    phandle_node = dt_parse_phandle(node, "cpupool-cpus", 0);
+    if ( !phandle_node )
+        return BTCPUPOOLS_DT_CORRUPTED_NODE;
+
+    cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
+    if ( cpu_num < 0 )
+        return cpu_num;
+
+    return pool_cpu_map[cpu_num];
+}
+
 static int __init check_and_get_sched_id(const char* scheduler_name)
 {
     int sched_id = sched_get_id_by_name(scheduler_name);
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0aa..84e75829b980 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
@@ -106,6 +106,9 @@ struct xen_domctl_createdomain {
     /* Per-vCPU buffer size in bytes.  0 to disable. */
     uint32_t vmtrace_size;
 
+    /* CPU pool to use; specify 0 or a specific existing pool */
+    uint32_t cpupool_id;
+
     struct xen_arch_domainconfig arch;
 };
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 74b3aae10b94..32d2a6294b6d 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1188,6 +1188,7 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 void btcpupools_allocate_pools(void);
 unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
 void btcpupools_dtb_parse(void);
+int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
 
 #else /* !CONFIG_BOOT_TIME_CPUPOOLS */
 static inline void btcpupools_allocate_pools(void) {}
@@ -1196,6 +1197,14 @@ static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
 {
     return 0;
 }
+#ifdef CONFIG_HAS_DEVICE_TREE
+static inline int
+btcpupools_get_domain_pool_id(const struct dt_device_node *node)
+{
+    return 0;
+}
+#endif
+
 #endif
 
 #endif /* __SCHED_H__ */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:21:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:21:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303110.517184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvr3-0007S5-RA; Mon, 11 Apr 2022 15:21:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303110.517184; Mon, 11 Apr 2022 15:21:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvr3-0007Rd-M6; Mon, 11 Apr 2022 15:21:25 +0000
Received: by outflank-mailman (input) for mailman id 303110;
 Mon, 11 Apr 2022 15:21:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dfOQ=UV=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1ndvr0-0005MA-Je
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:21:22 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 0acacead-b9ab-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 17:21:21 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09A45169C;
 Mon, 11 Apr 2022 08:21:21 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 95F053F73B;
 Mon, 11 Apr 2022 08:21:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0acacead-b9ab-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v7 7/7] xen/cpupool: Allow cpupool0 to use different scheduler
Date: Mon, 11 Apr 2022 16:21:01 +0100
Message-Id: <20220411152101.17539-8-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220411152101.17539-1-luca.fancellu@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>

Currently cpupool0 can use only the default scheduler, and
cpupool_create has an hardcoded behavior when creating the pool 0
that doesn't allocate new memory for the scheduler, but uses the
default scheduler structure in memory.

With this commit it is possible to allocate a different scheduler for
the cpupool0 when using the boot time cpupool.
To achieve this the hardcoded behavior in cpupool_create is removed
and the cpupool0 creation is moved.

When compiling without boot time cpupools enabled, the current
behavior is maintained (except that cpupool0 scheduler memory will be
allocated).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v7:
- no changes
Changes in v6:
- Add R-by
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- fix typo in commit message (Juergen)
- rebase changes
Changes in v2:
- new patch
---
 xen/common/sched/boot-cpupool.c | 5 ++++-
 xen/common/sched/cpupool.c      | 8 +-------
 xen/include/xen/sched.h         | 5 ++++-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c
index 240bae4cebb8..5955e6f9a98b 100644
--- a/xen/common/sched/boot-cpupool.c
+++ b/xen/common/sched/boot-cpupool.c
@@ -205,8 +205,11 @@ void __init btcpupools_allocate_pools(void)
     if ( add_extra_cpupool )
         next_pool_id++;
 
+    /* Keep track of cpupool id 0 with the global cpupool0 */
+    cpupool0 = cpupool_create_pool(0, pool_sched_map[0]);
+
     /* Create cpupools with selected schedulers */
-    for ( i = 0; i < next_pool_id; i++ )
+    for ( i = 1; i < next_pool_id; i++ )
         cpupool_create_pool(i, pool_sched_map[i]);
 }
 
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 0a93bcc631bf..f6e3d97e5288 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -312,10 +312,7 @@ static struct cpupool *cpupool_create(unsigned int poolid,
         c->cpupool_id = q->cpupool_id + 1;
     }
 
-    if ( poolid == 0 )
-        c->sched = scheduler_get_default();
-    else
-        c->sched = scheduler_alloc(sched_id);
+    c->sched = scheduler_alloc(sched_id);
     if ( IS_ERR(c->sched) )
     {
         ret = PTR_ERR(c->sched);
@@ -1248,9 +1245,6 @@ static int __init cf_check cpupool_init(void)
 
     cpupool_hypfs_init();
 
-    cpupool0 = cpupool_create(0, 0);
-    BUG_ON(IS_ERR(cpupool0));
-    cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
     btcpupools_dtb_parse();
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 32d2a6294b6d..6040fa3b3830 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1191,7 +1191,10 @@ void btcpupools_dtb_parse(void);
 int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
 
 #else /* !CONFIG_BOOT_TIME_CPUPOOLS */
-static inline void btcpupools_allocate_pools(void) {}
+static inline void btcpupools_allocate_pools(void)
+{
+    cpupool0 = cpupool_create_pool(0, -1);
+}
 static inline void btcpupools_dtb_parse(void) {}
 static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
 {
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:28:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:28:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303144.517195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvy4-0001tZ-Mf; Mon, 11 Apr 2022 15:28:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303144.517195; Mon, 11 Apr 2022 15:28:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndvy4-0001tS-J6; Mon, 11 Apr 2022 15:28:40 +0000
Received: by outflank-mailman (input) for mailman id 303144;
 Mon, 11 Apr 2022 15:28:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=as7e=UV=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1ndvy3-0001tM-Hu
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:28:39 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2060d.outbound.protection.outlook.com
 [2a01:111:f400:7d00::60d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0debb30f-b9ac-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 17:28:37 +0200 (CEST)
Received: from DB6P18901CA0002.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::12)
 by DB8PR08MB5066.eurprd08.prod.outlook.com (2603:10a6:10:e4::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 15:28:25 +0000
Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:16:cafe::80) by DB6P18901CA0002.outlook.office365.com
 (2603:10a6:4:16::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 15:28:25 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 15:28:24 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Mon, 11 Apr 2022 15:28:24 +0000
Received: from 039ddf7bd700.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4229D09E-3367-45F0-9289-BBFA6D3D4032.1; 
 Mon, 11 Apr 2022 15:28:15 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 039ddf7bd700.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 15:28:15 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by HE1PR0801MB1867.eurprd08.prod.outlook.com
 (2603:10a6:3:53::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 15:28:10 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0%11]) with mapi id 15.20.5144.029; Mon, 11 Apr
 2022 15:28:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0debb30f-b9ac-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gt5jAdlLFKn2FKYVejnnvArgY2fNHKot2ohec1+lUUQ=;
 b=3Q7vncL0bET78Yp47Zr5FLUkdPDlCEox9gE/7j0BeAAdUVAowW5K4zRukwrpjK23rzgG+uFI69MzxtMMgEGg/XhTd7/6KF9vi9Qn1RW01rVWt1iORP7TNCjtSqdhPlvOTpQGFyFBmuPB7odF5dQOBTSnmuR2zYzVj1noZNZ+ygI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 21b5160bac740deb
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EyPJ2tUUFlWKDhLAVZ/n0lfwiFJfMKBXf/PDpMn7OO7PngBy+e2Jkg61EpITU0nzyTZnFxxwx0355ZJy8JCQX+f0IZSC5QHTGuOizcylpKejlQDJeXmIJCc9NUbiU1xanvyzSSENb/gLSllAgDFNqyAUJl5S2l/iPG9Me5CujuifQ5zGgCfGbw+XiQUlj3Mg8lYXf6dXGUMAsOMnAX9cR7T8daNbP5zK4EZpgjatExnEDVIJJYmXNheOuOqjHyuhjCGhQds3zrGzPyyShR+now5Et0N3ODsQbkXvZS66q/bTSr8Kvrfzek3lkYeg8sKoI6co2PL5bsVwSaUGL910LQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gt5jAdlLFKn2FKYVejnnvArgY2fNHKot2ohec1+lUUQ=;
 b=b5e6ygkph/iW8cUmPzdVfY6rxa5d5iF/nmOUyHsPF59Io7xM5RdqPcnDXqSM6XIWMWntPGRDVWl/P5ZpmqnTo4vHtCgO+syDB3ASivB7LWMLin870rZDDgmL+ZEY3uOhj3busCfDEhz6f5qRxxzKd+//nsdOF5lNpCLmCiZgeYQasJlNDNxncfzDP8vAXWyXtWziG/DmZzMk6J5Am7QkIYFcGzGE7aKUOVISsQAAb4+sNIOJFFCHbCIjzJJ/GkFTeNCplGOlLe/tTdCAD6J9EQ50NaPdZxMk2NZi7eHqUWwzCkbBmHinvYzdwbWZpY69KF8jlGFJapCRRXOHPk9S4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gt5jAdlLFKn2FKYVejnnvArgY2fNHKot2ohec1+lUUQ=;
 b=3Q7vncL0bET78Yp47Zr5FLUkdPDlCEox9gE/7j0BeAAdUVAowW5K4zRukwrpjK23rzgG+uFI69MzxtMMgEGg/XhTd7/6KF9vi9Qn1RW01rVWt1iORP7TNCjtSqdhPlvOTpQGFyFBmuPB7odF5dQOBTSnmuR2zYzVj1noZNZ+ygI=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien
 Grall <julien@xen.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
Thread-Topic: [PATCH] xen/evtchn: Add design for static event channel
 signaling for domUs..
Thread-Index: AQHYPsy9MfyfmFhecEGJuSNYyusIgKzm3KwAgAQXOAA=
Date: Mon, 11 Apr 2022 15:28:09 +0000
Message-ID: <D0911130-8E46-478D-86C1-EF8EE67B3CDA@arm.com>
References:
 <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 9a9783e6-500e-4dc9-d83b-08da1bcfeb48
x-ms-traffictypediagnostic:
	HE1PR0801MB1867:EE_|DB5EUR03FT046:EE_|DB8PR08MB5066:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB506661296608973766437101FCEA9@DB8PR08MB5066.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 L42a37pB8LU8HR5wxIoNo4cl/3iLJa3ylvG5hoInWkIeVXoJvPQjrZ8gwW8JPXkwlElR6kXEVoatSsYPZ4/vdVW2+/ZBk9Pb/+jIVLpPtuCUtDSxAnwBvcJhe6fxozHYQOEwvju8HsaUEBXqSwI8292AvPzdjoFsbKKYI1g4JFOenzcS+NO2RMjARJ3sJbmrGk3M1LfEsvrD2BReu3OTfizR4misS+ACQ9oRJSQL3cbXB+QdUvAoO0daAHdeXcnQtc5yu/Q1bgCBWCF+OBaG6QgEVlNSIL/5I6y+P4Qp71Rlnt16VJBgcYYlXikAeh6EfKtYfoFlg41snFrxsMrbmJny0v8vLMP86s7YPqDXfpHH8GWXeInDmCq8b8NKIkkJUgXeI/PEp+hojT+Lchkb58+G/9VV86QhfnZEYlFoA0AwZtLZzSKRxge17F5rVcF7LKdD/L3myTla9UTtxQAMUU3qOdrZdsABMVeo8q3AjKAXmkZeZk19msji+4KQp7da6Nf8Wu2JIDY1Oi9nlXR/jbGtBY+YbqXNlPmNGTqmPSXL0m8hpnB6J4OQ5N1LaeWP/3M7S5USOo4T/K7Q11nDzksxwr41VvDoqWWGrdabzML+ge0QBXJ6fgeIZcVL9AqDvXdbOf6C3OKSKDVbflX1FVhb0K7/24GXesj17iXdbmtxRTUdXb8RrTsGgAS0gjIwgT2PeU5tWySsfrRaPyrO//GKBC3rGhdSdR8ju4iOo8M=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(26005)(186003)(66946007)(66556008)(508600001)(8676002)(64756008)(6486002)(83380400001)(86362001)(66476007)(66446008)(71200400001)(76116006)(91956017)(4326008)(5660300002)(6916009)(53546011)(33656002)(38070700005)(6506007)(36756003)(316002)(38100700002)(54906003)(122000001)(8936002)(2906002)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <4B3737BEFBD5BF46BA57E77B3C344B24@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1867
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	55ef9268-7c76-4601-4cfd-08da1bcfe272
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Hbq0S58CZGJSR7F3qwFJ+261Tqcq42N1azP0R+hxCmrmyrU94GHR6e+1YEFuh8XJ6OhPd6C+A5Mju06Yyx+7Qop9CuCnC5lyqm6IS1lFVfUnYcm5kScGSFMuttzbfSt7cnJl+OFo7E5tKVeBDmzNVLSOQULboMVLZWGIbZq14y1hGt/4rUb80vmda+T4+FA+oBhnBGCDEeilyPGReDbMX08Esejh5F3eu58wK7h6SSLuitUQKts1lfGScwjKzW3jeAbV6tjHCoXUgWG1gsyfKF7B5IjJ6NrcL4Tj6rkmLIQjNkbpw0AZHlUdRglGVll0023Rs0UVFe1LyXxLl5KpIsvIfF4uR9+j/0zjq7GFIsj0x/ttDa429PfwS8aT2I9LhaRVFF5wFoaLMAFNT0pn4Cb/192N7cg6VHpgKTz1iXHrj7z/e9Sw2vIYg68l8w4UhHbaH/Gi0OjTlBhgxk4PrvHCcswvnDM0ehIbseF39B9vSnaqmoD41wTES9dfSwCXFRNa8RX85h+i/0ZHoFRIwr0KNX8vwPolmiE1wu8cbhI0R2UZlkmXw0Tt0+zgltmcnuL/d5A8my08ASEmxeab4PRheEi6cq4Q27giIoAewxKcMfh2jsbJzGg5W41qc6OYpziWs8/cAZakg8k7Zc1MRi8oYhKUNocI6GW0bqjmGCVgWeu7MPQFuwFjr2nT1DQR
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(83380400001)(26005)(86362001)(336012)(82310400005)(356005)(40460700003)(54906003)(33656002)(316002)(47076005)(186003)(70586007)(8676002)(4326008)(70206006)(508600001)(6862004)(2616005)(6486002)(53546011)(6512007)(81166007)(36860700001)(6506007)(8936002)(5660300002)(2906002)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 15:28:24.5946
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a9783e6-500e-4dc9-d83b-08da1bcfeb48
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5066

SGkgU3RlZmFubywNCg0KVGhhbmtzIGZvciByZXZpZXdpbmcgdGhlIGRlc2lnbi4NCg0KPiBPbiA5
IEFwciAyMDIyLCBhdCAyOjAwIGFtLCBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtl
cm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gT24gV2VkLCAyMyBNYXIgMjAyMiwgUmFodWwgU2luZ2gg
d3JvdGU6DQo+PiBpbiBkb20wbGVzcyBzeXN0ZW0uIFRoaXMgcGF0Y2ggaW50cm9kdWNlIHRoZSBu
ZXcgZmVhdHVyZSB0byBzdXBwb3J0IHRoZQ0KPj4gc2lnbmFsaW5nIGJldHdlZW4gdHdvIGRvbVVz
IGluIGRvbTBsZXNzIHN5c3RlbS4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2gg
PHJhaHVsLnNpbmdoQGFybS5jb20+DQo+PiAtLS0NCj4+IGRvY3MvZGVzaWducy9kb20wbGVzcy1l
dnRjaG4ubWQgfCA5NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4+IDEgZmls
ZSBjaGFuZ2VkLCA5NiBpbnNlcnRpb25zKCspDQo+PiBjcmVhdGUgbW9kZSAxMDA2NDQgZG9jcy9k
ZXNpZ25zL2RvbTBsZXNzLWV2dGNobi5tZA0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEvZG9jcy9kZXNp
Z25zL2RvbTBsZXNzLWV2dGNobi5tZCBiL2RvY3MvZGVzaWducy9kb20wbGVzcy1ldnRjaG4ubWQN
Cj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAwMDAwMDAwMDAwLi42YTFiN2U4YzIy
DQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi9kb2NzL2Rlc2lnbnMvZG9tMGxlc3MtZXZ0Y2hu
Lm1kDQo+PiBAQCAtMCwwICsxLDk2IEBADQo+PiArIyBTaWduYWxpbmcgc3VwcG9ydCBiZXR3ZWVu
IHR3byBkb21VcyBvbiBkb20wbGVzcyBzeXN0ZW0NCj4+ICsNCj4+ICsjIyBDdXJyZW50IHN0YXRl
OuKAr0RyYWZ0IHZlcnNpb24NCj4+ICsNCj4+ICsjIyBQcm9wb3NlcihzKTogUmFodWwgU2luZ2gs
IEJlcnRyYW5kIE1hcnF1aXMNCj4+ICsNCj4+ICsjIyBQcm9ibGVtIFN0YXRlbWVudDoNCj4+ICsN
Cj4+ICtUaGUgZ29hbCBvZiB0aGlzIHdvcmsgaXMgdG8gZGVmaW5lIGEgc2ltcGxlIHNpZ25hbGlu
ZyBzeXN0ZW0gYmV0d2VlbiBYZW4gZ3Vlc3RzDQo+PiAraW4gZG9tMGxlc3Mgc3lzdGVtcy4NCj4+
ICsNCj4+ICtJbiBkb20wbGVzcyBzeXN0ZW0sIHdlIGNhbm5vdCBtYWtlIHVzZSBvZiB4ZW5idXMg
YW5kIHhlbnN0b3JlIHRoYXQgYXJlIHVzZWQgaW4NCj4+ICtub3JtYWwgc3lzdGVtcyB3aXRoIGR5
bmFtaWMgVk1zIHRvIGNvbW11bmljYXRlIGJldHdlZW4gZG9tYWlucyBieSBwcm92aWRpbmcgYQ0K
Pj4gK2J1cyBhYnN0cmFjdGlvbiBmb3IgcGFyYXZpcnR1YWxpemVkIGRyaXZlcnMuDQo+PiArDQo+
PiArT25lIHBvc3NpYmxlIHNvbHV0aW9uIHRvIGltcGxlbWVudCB0aGUgc2lnbmFsaW5nIHN5c3Rl
bSBiZXR3ZWVuIGRvbVVzIGlzIGJhc2VkDQo+PiArb24gZXZlbnQgY2hhbm5lbHMuDQo+IA0KPiBJ
IHN1Z2dlc3QgdG8gcmV3b3JkIHRoaXMgYXMgZm9sbG93czoNCj4gDQo+IC0tLQ0KPiBEb20wbGVz
cyBndWVzdHMgd291bGQgYmVuZWZpdCBmcm9tIGEgc3RhdGljYWxseS1kZWZpbmVkIG1lbW9yeSBz
aGFyaW5nDQo+IGFuZCBzaWduYWxseSBzeXN0ZW0gZm9yIGNvbW11bmljYXRpb24uIE9uZSB0aGF0
IHdvdWxkIGJlIGltbWVkaWF0ZWx5DQo+IGF2YWlsYWJsZSBhdCBib290IHdpdGhvdXQgYW55IG5l
ZWQgZm9yIGR5bmFtaWMgY29uZmlndXJhdGlvbnMuDQo+IA0KPiBJbiBlbWJlZGRlZCBhIGdyZWF0
IHZhcmlldHkgb2YgZ3Vlc3Qgb3BlcmF0aW5nIHN5c3RlbSBrZXJuZWxzIGV4aXN0LA0KPiBtYW55
IG9mIHdoaWNoIGRvbid0IGhhdmUgc3VwcG9ydCBmb3IgeGVuc3RvcmUsIGdyYW50IHRhYmxlIG9y
IG90aGVyDQo+IGNvbXBsZXggZHJpdmVycy4gU29tZSBvZiB0aGVtIGFyZSBzbWFsbCBrZXJuZWwt
c3BhY2UgYXBwbGljYXRpb25zIChvZnRlbg0KPiBjYWxsZWQgImJhcmVtZXRhbCIsIG5vdCB0byBi
ZSBjb25mdXNlZCB3aXRoIHRoZSB0ZXJtICJiYXJlbWV0YWwiIHVzZWQgaW4NCj4gZGF0YWNlbnRl
ciB3aGljaCBtZWFucyAid2l0aG91dCBoeXBlcnZpc29ycyIpIG9yIFJUT1Nlcy4gQWRkaXRpb25h
bGx5LA0KPiBmb3Igc2FmZXR5IHJlYXNvbnMsIHVzZXJzIG9mdGVuIG5lZWQgdG8gYmUgYWJsZSB0
byBjb25maWd1cmUgdGhlIGZ1bGwNCj4gc3lzdGVtIHN0YXRpY2FsbHkgc28gdGhhdCBpdCBjYW4g
YmUgdmVyaWZpZWQgc3RhdGljYWxseS4NCj4gDQo+IEV2ZW50IGNoYW5uZWxzIGFyZSB2ZXJ5IHNp
bXBsZSBhbmQgY2FuIGJlIGFkZGVkIGV2ZW4gdG8gYmFyZW1ldGFsDQo+IGFwcGxpY2F0aW9ucy4g
VGhpcyBwcm9wb3NhbCBpbnRyb2R1Y2VzIGEgd2F5IHRvIGRlZmluZSB0aGVtIHN0YXRpY2FsbHkN
Cj4gdG8gbWFrZSB0aGVtIHN1aXRhYmxlIHRvIGRvbTBsZXNzIGVtYmVkZGVkIGRlcGxveW1lbnRz
Lg0KPiAtLS0NCj4gDQoNCk9rLiBUaGlzIGlzIHJlYWxseSBhIGdvb2QgZXhwbGFuYXRpb24gSSB3
aWxsIGFkZCB0aGlzIGluIG5leHQgdmVyc2lvbi4NCj4gDQo+PiArIyMgUHJvcG9zYWw6DQo+PiAr
DQo+PiArRXZlbnQgY2hhbm5lbHMgYXJlIHRoZSBiYXNpYyBwcmltaXRpdmUgcHJvdmlkZWQgYnkg
WGVuIGZvciBldmVudCBub3RpZmljYXRpb25zLg0KPj4gK0FuIGV2ZW50IGNoYW5uZWwgaXMgYSBs
b2dpY2FsIGNvbm5lY3Rpb24gYmV0d2VlbiAyIGRvbWFpbnMgKG1vcmUgc3BlY2lmaWNhbGx5DQo+
PiArYmV0d2VlbiBkb20xLHBvcnQxIGFuZCBkb20yLHBvcnQyKS4gVGhleSBlc3NlbnRpYWxseSBz
dG9yZSBvbmUgYml0IG9mDQo+PiAraW5mb3JtYXRpb24sIHRoZSBldmVudCBvZiBpbnRlcmVzdCBp
cyBzaWduYWxsZWQgYnkgdHJhbnNpdGlvbmluZyB0aGlzIGJpdCBmcm9tDQo+PiArMCB0byAxLiBB
biBldmVudCBpcyBhbiBlcXVpdmFsZW50IG9mIGEgaGFyZHdhcmUgaW50ZXJydXB0Lg0KPj4gKw0K
Pj4gK05vdGlmaWNhdGlvbnMgYXJlIHJlY2VpdmVkIGJ5IGEgZ3Vlc3QgdmlhIGFuIGludGVycnVw
dCBmcm9tIFhlbiB0byB0aGUgZ3Vlc3QsDQo+PiAraW5kaWNhdGluZyB3aGVuIGFuIGV2ZW50IGFy
cml2ZXMgKHNldHRpbmcgdGhlIGJpdCkuIEZ1cnRoZXIgbm90aWZpY2F0aW9ucyBhcmUNCj4+ICtt
YXNrZWQgdW50aWwgdGhlIGJpdCBpcyBjbGVhcmVkIGFnYWluLiBXaGVuIGEgZG9tYWluIHdhbnRz
IHRvIHdhaXQgZm9yIGRhdGEgaXQNCj4+ICt3aWxsIGJsb2NrIHVudGlsIGFuIGV2ZW50IGFycml2
ZXMsIGFuZCB0aGVuIHNlbmQgYW4gZXZlbnQgdG8gc2lnbmFsIHRoYXQgZGF0YQ0KPj4gK2hhcyBi
ZWVuIGNvbnN1bWVkLiBFdmVudHMgYXJlIGRlbGl2ZXJlZCBhc3luY2hyb25vdXNseSB0byBndWVz
dHMgYW5kIGFyZQ0KPj4gK2VucXVldWVkIHdoZW4gdGhlIGd1ZXN0IGlzIG5vdCBydW5uaW5nLg0K
Pj4gKw0KPj4gK0V2ZW50IGNoYW5uZWwgY29tbXVuaWNhdGlvbiB3aWxsIGJlIGVzdGFibGlzaGVk
IHN0YXRpY2FsbHkgYmV0d2VlbiB0d28gZG9tVQ0KPj4gK2d1ZXN0cyBiZWZvcmUgdW5wYXVzaW5n
IHRoZSBkb21haW5zIGFmdGVyIGRvbWFpbiBjcmVhdGlvbi4gRXZlbnQgY2hhbm5lbA0KPj4gK2Nv
bm5lY3Rpb24gaW5mb3JtYXRpb24gYmV0d2VlbiBkb21VcyB3aWxsIGJlIHBhc3NlZCB0byBYRU4g
dmlhIGRldmljZSB0cmVlDQo+PiArbm9kZS4NCj4+ICsNCj4+ICtVbmRlciB0aGUgL2Nob3NlbiBu
b2RlLCB0aGVyZSBuZWVkcyB0byBiZSBzdWIgbm9kZXMgd2l0aCBjb21wYXRpYmxlDQo+PiArInhl
bixldnRjaG4iIHRoYXQgZGVzY2liZXMgdGhlIGV2ZW50IGNoYW5uZWwgY29ubmVjdGlvbiBiZXR3
ZWVuIHR3byBkb21Vcy4NCj4+ICsNCj4+ICtUaGUgZXZlbnQgY2hhbm5lbCBzdWItbm9kZSBoYXMg
dGhlIGZvbGxvd2luZyBwcm9wZXJ0aWVzOg0KPj4gKw0KPj4gKy0gY29tcGF0aWJsZQ0KPj4gKw0K
Pj4gKyAieGVuLGV2dGNobiINCj4+ICsNCj4+ICstIHhlbixldnRjaG4NCj4+ICsNCj4+ICsgVGhl
IHByb3BlcnR5IGlzIGZvdXIgbnVtYmVycyBvZiB0dXBsZXMgb2YNCj4+ICsgKGxvY2FsLXBvcnQt
ZG9tVTEsZG9tVTEtcGhhbmRsZSxsb2NhbC1wb3J0LWRvbVUyLGRvbVUyLXBoYW5kbGUpIHdoZXJl
Og0KPj4gKw0KPj4gKyBsb2NhbC1wb3J0LWRvbVUxIGlzIGFuIGludGVnZXIgdmFsdWUgdGhhdCB3
aWxsIGJlIHVzZWQgdG8gYWxsb2N0ZSBsb2NhbA0KPj4gKyBwb3J0IGZvciBkb21VMSB0byBzZW5k
IGFuIGV2ZW50IG5vdGlmaWNhdGlvbiB0byB0aGUgcmVtb3RlIGRvbWFpbi4NCj4+ICsNCj4+ICsg
ZG9tVTEtcGhhbmRsZSBpcyBhIHNpbmdsZSBwaGFuZGxlIHRvIGFuIGRvbWFpbiB0byB3aGljaCBs
b2NhbC1wb3J0LWRvbVUxDQo+PiArIHdpbGwgYmUgYWxsb2NhdGVkLg0KPj4gKw0KPj4gKyBsb2Nh
bC1wb3J0LWRvbVUyIGlzIGFuIGludGVnZXIgdmFsdWUgdGhhdCB3aWxsIGJlIHVzZWQgdG8gYWxs
b2N0ZSBsb2NhbA0KPj4gKyBwb3J0IGZvciBkb21VMiB0byBzZW5kIGFuIGV2ZW50IG5vdGlmaWNh
dGlvbiB0byB0aGUgcmVtb3RlIGRvbWFpbi4NCj4+ICsNCj4+ICsgZG9tVTItcGhhbmRsZSBpcyBh
IHNpbmdsZSBwaGFuZGxlIHRvIGFuIGRvbWFpbiB0byB3aGljaCBsb2NhbC1wb3J0LWRvbVUyDQo+
PiArIHdpbGwgYmUgYWxsb2NhdGVkLg0KPj4gKw0KPj4gK0V4YW1wbGU6DQo+PiArDQo+PiArIGNo
b3NlbiB7DQo+PiArIC4uLi4NCj4+ICsNCj4+ICsgZG9tVTE6IGRvbVUxIHsNCj4+ICsgLi4uLi4u
DQo+PiArIH07DQo+PiArDQo+PiArIGRvbVUyOiBkb21VMiB7DQo+PiArIC4uLi4uLg0KPj4gKyB9
Ow0KPj4gKw0KPj4gKyBldnRjaG5AMSB7DQo+PiArIGNvbXBhdGlibGUgPSAieGVuLGV2dGNobiI7
DQo+PiArIHhlbixldnRjaG4gPSA8MHhhICZkb21VMSAweGIgJmRvbVUyPjsNCj4+ICsgfTsNCj4+
ICsNCj4+ICsgZXZ0Y2huQDIgew0KPj4gKyBjb21wYXRpYmxlID0gInhlbixldnRjaG4iOw0KPj4g
KyB4ZW4sZXZ0Y2huID0gPDB4YyAmZG9tVTEgMHhkICZkb21VMj47DQo+PiArIH07DQo+PiArIH07
DQo+IA0KPiBUaGVyZSBpcyBubyBuZWVkIHRvIHVzZSB0d28gZXZ0Y2huIG5vZGVzIGZvciB0aGlz
IGdpdmVuIHRoYXQgaW4gZGV2aWNlDQo+IHRyZWUgaXQgaXMgZW50aXJlbHkgbm9ybWFsIHRvIGhh
dmUgbXVsdGlwbGUgdHVwbGV0cyBpbiBhIHByb3BlcnR5LiBBbHNvLA0KPiBpdCB3b3VsZCBiZSBn
b29kIHRvIGhhdmUgYSB2ZXJzaW9uIG51bWJlciBpbiB0aGUgY29tcGF0aWJsZSBzdHJpbmcgc28N
Cj4gdGhhdCB3ZSBjYW4gY2hhbmdlIHZlcnNpb24gaW4gdGhlIGZ1dHVyZS4NCj4gDQo+IDEpDQo+
IGNob3NlbiB7DQo+IC4uLi4NCj4gDQo+IGRvbVUxOiBkb21VMSB7DQo+IC4uLi4uLg0KPiB9Ow0K
PiANCj4gZG9tVTI6IGRvbVUyIHsNCj4gLi4uLi4uDQo+IH07DQo+IA0KPiBldnRjaG4gew0KPiBj
b21wYXRpYmxlID0gInhlbixldnRjaG4tdjEiOw0KPiB4ZW4sZXZ0Y2huID0gPDB4YSAmZG9tVTEg
MHhiICZkb21VMiAweGMgJmRvbVUxIDB4ZCAmZG9tVTI+Ow0KPiB9Ow0KPiB9Ow0KPiANCg0KSSBh
Z3JlZSBpZiB3ZSBjYW4gaGF2ZSBtdWx0aXBsZSB0dXBsZXMgaW4gYSBwcm9wZXJ0eS4gSSB3aWxs
IG1vZGlmeSB0aGUgZGVzaWduIGluIG5leHQgdmVyc2lvbg0KdG8gaGF2ZSBtdWx0aXBsZSB0dXBs
ZXMgaW4gYSBwcm9wZXJ0eS4gDQo+IA0KPiBJIHNob3VsZCBtZW50aW9uIHRoYXQgaXQgd291bGQg
YmUgYWxzbyBwb3NzaWJsZSB0byB1c2Ugc3ViLW5vZGVzIHRvDQo+IGV4cHJlc3MgdGhpcyBpbmZv
cm1hdGlvbjoNCj4gDQo+IDIpDQo+IGRvbVUxOiBkb21VMSB7DQo+IC4uLg0KPiAvKiBvbmUgc3Vi
LW5vZGUgcGVyIGxvY2FsIGV2ZW50IGNoYW5uZWwgKi8NCj4gZWMxOiBldnRjaG5AYSB7DQo+IGNv
bXBhdGlibGUgPSAieGVuLGV2dGNobi12MSI7DQo+IC8qIGxvY2FsLWV2dGNobiBsaW5rLXRvLWZv
cmVpZ24tZXZ0Y2huICovDQo+IHhlbixldnRjaG4gPSA8MHhhICZlYzM+DQo+IH07DQo+IGVjMjog
ZXZ0Y2huQGMgew0KPiBjb21wYXRpYmxlID0gInhlbixldnRjaG4tdjEiOw0KPiB4ZW4sZXZ0Y2hu
ID0gPDB4YyAmZWM0Pg0KPiB9Ow0KPiB9Ow0KPiANCj4gZG9tVTI6IGRvbVUyIHsNCj4gLi4uDQo+
IGVjMzogZXZ0Y2huQGIgew0KPiBjb21wYXRpYmxlID0gInhlbixldnRjaG4tdjEiOw0KPiB4ZW4s
ZXZ0Y2huID0gPDB4YiAmZWMxPg0KPiB9Ow0KPiBlYzQ6IGV2dGNobkBkIHsNCj4gY29tcGF0aWJs
ZSA9ICJ4ZW4sZXZ0Y2huLXYxIjsNCj4geGVuLGV2dGNobiA9IDwweGEgJmVjMj4NCj4gfTsNCj4g
fTsNCj4gfTsNCj4gDQo+IFRoaXMgZm9ybWF0IGhhcyB0aGUgYWR2YW50YWdlIHRoYXQgZG9lc24n
dCBuZWVkIGEgbmV3IHRvcC1sZXZlbCBub2RlDQo+IHR5cGUgdW5kZXIgL2Nob3Nlbi4gVGhhdCBp
cyBkZXNpcmFibGUgZmV3IGEgZmV3IHJlYXNvbnMuIFRvZGF5IHdlIG9ubHkNCj4gaGF2ZSBkb21h
aW5zIChkb20wIGlzIGxlZ2FjeSkuIEluIHRoZSBmdXR1cmUgd2UgbWlnaHQgaGF2ZSBuZXN0ZWQN
Cj4gZG9tYWlucyBhbmQgbm9uLVhlbiBkb21haW5zLiBXaXRoIFN5c3RlbSBEZXZpY2UgVHJlZSwg
ZG9tYWlucyBhcmUgdW5kZXINCj4gL2RvbWFpbnMgaW5zdGVhZCBvZiAvY2hvc2VuLg0KPiANCj4g
U28gbm9ybWFsbHkgSSB3b3VsZCBhcmd1ZSB0byB1c2UgdGhlIHN1Yi1ub2RlIGZvcm1hdCBiZWNh
dXNlIGl0IGRvZXNuJ3QNCj4gbmVlZCBhIG5ldyB0b3AtbGV2ZWwgbm9kZSB1bmRlciAvY2hvc2Vu
LiBIb3dldmVyLCBpbiB0aGlzIGNhc2UgaXQgbG9va3MNCj4gbGlrZSB0aGUgMSkgZm9ybWF0IGlz
IHNpbXBsZXIgdG8gd3JpdGUgYW5kIGFsc28gc2ltcGxlciB0byBwYXJzZSBpbiBYZW4uDQo+IA0K
PiBJbiAxKSwgd2Ugd291bGQgbmVlZCB0byBsb29wIG92ZXIgeGVuLGV2dGNobiBhbmQgZm9yIGVh
Y2ggdHVwbGV0IHdlDQo+IHdvdWxkIG9ubHkgbmVlZCB0byBmZXRjaCB0aGUgZm9yZWlnbiBkb21p
ZC4NCj4gDQo+IEluIDIpLCB3ZSB3b3VsZCBuZWVkIHRvIGNoZWNrIHRoZSBjb21wYXRpYmxlIHN0
cmluZyBvZiBldmVyeQ0KPiAieGVuLGV2dGNobi12MSIgbm9kZSwgYW5kIHdlIHdvdWxkIGhhdmUg
dG8gZmV0Y2ggZnJvbSB0aGUgcGhhbmRsZSBib3RoDQo+IHRoZSByZW1vdGUgZXZlbnQgY2hhbm5l
bCBudW1iZXIgYnV0IGFsc28gdGhlIGRvbWFpbi1pZCBvZiB0aGUgcGFyZW50Lg0KDQo+IA0KPiBT
byBpdCBsb29rcyBsaWtlIDEpIGlzIGJldHRlciBiZWNhdXNlIGl0IGlzIG11Y2ggc2ltcGxlciB0
byBwYXJzZS4gRG8NCj4geW91IGFncmVlPw0KDQpZZXMgSSBhZ3JlZSB3aXRoIHlvdSwgZm9yIHRo
aXMgY2FzZSB3ZSBuZWVkIHRvIHBhcnNlIGFsbCB0aGUgInhlbixldnRjaG4tdjHigJ0gY29tcGF0
aWJsZSBub2RlDQphbmQgZnJvbSB0aGF0IG5vZGUsIHdlIG5lZWQgdG8gZmluZCB0aGUgcmVtb3Rl
IGV2ZW50IGNoYW5uZWwgYW5kIGRvbS1pZCBmcm9tIHRoZSBwaGFuZGxlLg0KDQpJIHN0YXJ0ZWQg
ZnJvbSB0aGlzIGNvbmZpZ3VyYXRpb24gYW5kIGxhdGVyIHJlYWxpemUgdGhhdCBpZiB3ZSB1c2Ug
dGhpcyBjb25maWd1cmF0aW9uIGNvZGUgd2lsbCBiZWNvbWUNCm1vcmUgY29tcGxleCBhbmQgZGVm
aW5pbmcgdGhlIGV2ZW50LWNoYW5uZWwgY29ubmVjdGlvbiBpbiBEVCB3aWxsIGFsc28gbm90IGJl
IHNpbXBsZS4NCj4gDQo+PiArSW4gYWJvdmUgZXhhbXBsZSB0d28gZXZlbnQgY2hhbm5lbCBjb211
bmljYXRpb24gd2lsbCBiZSBlc3RhYmxpc2hlZCBiZXR3ZWVuDQo+PiArZG9tVTEgYW5kIGRvbVUy
Lg0KPj4gKw0KPj4gKyBkb21VMSAocG9ydCAweGEpIDwtLS0tLS0tLS0tLS0tLS0tLT4gZG9tVTIg
KHBvcnQgMHhiKQ0KPj4gKyBkb21VMSAocG9ydCAweGMpIDwtLS0tLS0tLS0tLS0tLS0tLT4gZG9t
VTIgKHBvcnQgMHhkKQ0KPj4gKw0KPj4gK2RvbVUxIGFuZCBkb21VMiBjYW4gc2VuZCB0aGUgc2ln
bmFsIHRvIHJlbW90ZSBkb21haW4gdmlhIGh5cGVyY2FsbA0KPj4gK0VWVENITk9QX3NlbmQoLikg
b24gbG9jYWwgcG9ydC4NCj4gDQo+IEkgdGhpbmsgdGhpcyBpcyBmaW5lIGluIHByaW5jaXBsZS4g
TGlrZSBKYW4gd3JvdGUsIGF0IHNvbWUgcG9pbnQgd2UnbGwNCj4gbmVlZCB0byBzcGVjaWZ5IHRo
ZSBkZXZpY2UgdHJlZSBiaW5kaW5nIHRvIGV4cG9zZSB0aGlzIGluZm9ybWF0aW9uIHRvDQo+IHRo
ZSBndWVzdC4NCg0KUmVnYXJkcywNClJhaHVsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:38:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:38:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303154.517205 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndw7W-0003PQ-JA; Mon, 11 Apr 2022 15:38:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303154.517205; Mon, 11 Apr 2022 15:38:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndw7W-0003PJ-Fh; Mon, 11 Apr 2022 15:38:26 +0000
Received: by outflank-mailman (input) for mailman id 303154;
 Mon, 11 Apr 2022 15:38:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndw7V-0003P9-7A; Mon, 11 Apr 2022 15:38:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndw7V-0001Lf-4A; Mon, 11 Apr 2022 15:38:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndw7U-0004t1-J7; Mon, 11 Apr 2022 15:38:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndw7U-0004gL-Ia; Mon, 11 Apr 2022 15:38:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=A/jjdgGIal+2wRQrp6oDBmyh+9Lk9TC2fmd/HDG1+Ho=; b=5N5ei7iKz8nxcCdu3E6rZuBcdk
	0ruHy6Pb/heM+hcsztCgjehGL4IAYX/i3ezO6C7tAaomgNlvR2+0N2gQyPE6QhGnxUatgbgz0XuQP
	dTa4D2SkzfHyHAwOfbFdAFTqaJoX2z49rU9WQkeUNRPbKpBX6Uir5AiRz5ujCr85s0f4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169310-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169310: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=dab96cf02e3be378310dd1bce119b0fac6fac958
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 15:38:24 +0000

flight 169310 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169310/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 dab96cf02e3be378310dd1bce119b0fac6fac958
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  327 attempts
Testing same since   169287  2022-04-10 21:10:35 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4791 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 15:40:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 15:40:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303164.517217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndw9p-0004p1-66; Mon, 11 Apr 2022 15:40:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303164.517217; Mon, 11 Apr 2022 15:40:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndw9p-0004ou-2t; Mon, 11 Apr 2022 15:40:49 +0000
Received: by outflank-mailman (input) for mailman id 303164;
 Mon, 11 Apr 2022 15:40:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1peA=UV=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ndw9n-0004om-4N
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 15:40:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c0b56f8c-b9ad-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 17:40:45 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-31FY59WmNXOLbUOeWfdFgg-1; Mon, 11 Apr 2022 17:40:44 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB6154.eurprd04.prod.outlook.com (2603:10a6:10:c8::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 15:40:42 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022
 15:40:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0b56f8c-b9ad-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649691645;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Kb+DhhD+9SUxowGZBzjTz5FW1HqJximSLjpwkMACALg=;
	b=TBXIWXV85WWW3DCrvNKCrOnybanMJ+v1iHveWc876j41LQBfHryDbM+cOm82orXRJ5CK5x
	/7UEqOSjQhFFVyZj9VaDi4Ahx5JnK9EnUiLAXvcWfUjxuMTOB6DfUDxosZy7ibBX0jxOQN
	UwpGNJlNUrKwHhmEDB7mQsGaEbEAdR4=
X-MC-Unique: 31FY59WmNXOLbUOeWfdFgg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JNmZgLOKd0Qi68mzBeHCxtz38ubDNa7RVyM2P1rLap5WBMcXu1epAf+a3wD6lUZy3DdTyJGkDBp0u1dM/NL0iagJPQyer/gOjA83ZYsieLJI3a9Z8JF6/EnMWk7dZ/r9MCpX9Ov2zlXVKI6xqN1aERwb+PymegB1uWZ95ewc0EHNnwYphVtx9faQrRe0xqbTgrPNSZaL9QuUClaA3b/33lRQTcCbIt43ptWlXfm4hgsg5tPBpZnkzaGKFoswGIQa4DqRmyeBruEQ0stlsI+A7S4emJNJ2fzweladjRoNzwPjL/rl7fk1sQ29ZYoxFNpXMqh3n0KKCKTaiKe1NN1gsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kb+DhhD+9SUxowGZBzjTz5FW1HqJximSLjpwkMACALg=;
 b=WLjp3ShpuDQLqyI/WlD6P18Jt+uKdjY9RJ0CTvF8DOaU8QnDtRKhbRV3C3FgG5SJSw6Uyg2z69WD/HSt4b3IpE9A8p6NlUaKQO8RGizxXLtJhxMHyYoXTTi2DXsND+NBhV/GLdcFSxbkxyTEa9176LrE45HQRdTcopETvWpSccIwLDlXulmYsRTZEKCWkxn+Bk/+VBfDi8uGMh/Uc8whAdsDjOEdKxbiCWfwBaMfZcLqjlkzcwyvaluTETAbMEyVfRS2ezvjoFqRgYrvMDWECIx9B0FO4jIayhwkIlodhTzWdJCVLuPsnITUxzFTCrazfW+qSHmcgmLIavTgWDYCeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
Date: Mon, 11 Apr 2022 17:40:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Dario Faggioli <dfaggioli@suse.com>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-5-luca.fancellu@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220411152101.17539-5-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0101CA0013.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 82c65f67-5fcd-4049-204e-08da1bd1a2b4
X-MS-TrafficTypeDiagnostic: DBBPR04MB6154:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB6154EA0FC170B36C6A90B856B3EA9@DBBPR04MB6154.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UIBhFzzuwxGn8gQCT9x1n19v3P6ajSGrKChST7cEFB+vFQY9qMWmrSKcknaWeSJYam0K+49MjIczgdkZLSMfGYze8HTchqkKE7plZs9IqPi8jXNGpc8Yd5JSybeMu5wh/BFsXgCqxxuBDivmVq9zAGYr9laIzh7hoGthzhWS+TkOxjuwc8TyXkF9QGP7w0cpN9dJaM7otp5NWutmahJruZ2Eo8Bv30iiYfj7xowfmTe/g3bm/ZRmfJ3mj0tRYXhyKAEbJStLlUstjsqCZZSNq/fKLMI5Fek+iiq9QPdYjeKG/1V8zzy1PHaHVc6ph/FFsCal/ZKiWH86ufExZyI06h5VZ1YE3sVFQBoLDG3THa0SpiZUSu5F3HPTV3+5Y82SwbJQPRqZyv7t8ECCb9rbdPDNi8nOrpdB1E8HHLRFe3c8gCA0FeoGiwLDq9Soj+s0NB1HHu0LAlizENPtg9wLDNFQXCauPbFBtkXnaUwyjb2LLs51+D7QO9jJHh2vqNe6OzIwgaWIU0iEOJZ7XBURxwNZ0AY/s8UlDCq3enEY0Pi2fclu8mnCsczUykBYaFavj2o+ubNXdtM6YeTTHp4x9vSJJala62xJknCMJZKctxIvmijDAEmsQkkDsPPFAIozInPFLuiTtTI/I0O+VufdNtY9G3ppP35USBQ1Uwf5ZxKSQp6NO87Jk7n8jBZVs+6aBJXtop41e/HmkQ1SUCYI/g9eYT5cYNhceypXqm01Ub8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(4326008)(7416002)(66556008)(8676002)(66476007)(6486002)(53546011)(36756003)(6916009)(508600001)(2616005)(186003)(26005)(54906003)(6512007)(31686004)(316002)(8936002)(6506007)(2906002)(38100700002)(5660300002)(83380400001)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eWhmT3YyYnV5NFBkMCtQZ3c4L0hiZDUwbFZBdFR6cnR4SjQ0NEhpT0Q3S1V0?=
 =?utf-8?B?T2tBaWNTaXc3VzBoN3pveEhiK3FSZnN6Nk9uQnhNTGQvcjl0YVBZMllWQU1Q?=
 =?utf-8?B?OXMvQi9oMHptNTNpV3RiU3lsZHpFb2VXM2tLZUVmZDZqWTlOM1h5MGhodmsw?=
 =?utf-8?B?OUY0TllUSXpQOFdrR2o0YkpGcGRVaWdNM1BUOUdyaTQzZThzZTY4R3hidmk2?=
 =?utf-8?B?QjdYU09MREFaYjRBVStOYW5kZTAvZUVkWnFnZkxmcjJTVVNmeFpnczFqR3Z5?=
 =?utf-8?B?dysvQzIxc1NVTUoyK3RQZFlSNVUxcTM1Z3dxd3FlaElPdm9QMHFDbnRTN1lu?=
 =?utf-8?B?QmUxY2VveCtvYm5reW55ZUd4YzdjZzV5S00zOUJDSWVObDF2czZndUE2cjFm?=
 =?utf-8?B?UlVWOFpsN2EwS3RFM3RCZUtKb2JBY2pKcnZTa1FrMWtGTlN3b0RubGNHVlBR?=
 =?utf-8?B?eVQ0blV2ekM0MzhXSm9ib2VUOHBLVjRKRjhHNVREQ2xLNmJsdHFCNzBFYWxW?=
 =?utf-8?B?UVZCbUozZjhxODMrdjlFcVh0ZkxxK2pabDF6VWZXTHI5RHhHWjVrRDNaU1V0?=
 =?utf-8?B?RmVENzZpdkVKQVlmWUcxRW5LZlpXRDdKalh0Zk0wbjMwUDhDekVzeGF0ajJq?=
 =?utf-8?B?ZkNwa1B3QWhRd2U5dUpYdmxZdEVrNloxdXZrTU1NQjVTT0tpOFhGS0lCdFdk?=
 =?utf-8?B?VTc4TmpKbUxuaittbEduVmZhZThmMHI1ZkVMb0RYSU15U3RGY012V1pEaUww?=
 =?utf-8?B?SGJvb1NCeHQvQmp2QXRUSDlRS09zZFlNL2tHVVFGQVlzcU5lSWhNbnJ6aUNZ?=
 =?utf-8?B?WVhzNjkrSzhlMXBqeTh0WVFSQUhkYnp3L3VlRGNEb1RlWHpaUVI5YkRDQlhL?=
 =?utf-8?B?Q1hLMDNZK0xlYkFDZHZCZU5QYzVPazdBYldZdzB5dTh0bWh6eWRpR2dnbEE5?=
 =?utf-8?B?WUpFaEdyNnRvY2g0VDJmaFBOMDhMOXNCRUY1YlczK2c5Y0dLeWRsU0U5NTY0?=
 =?utf-8?B?KzZneGE0WUNZNHBjZUNZYmhML3FldXVTOUxINEtBTTlKV3pnN0pGcGJTcERF?=
 =?utf-8?B?b0VZRVgzYllMcTN0UTVBaExYTzJwMlJLbk94V21PV1FmOE1VRlZpd2VzR3Na?=
 =?utf-8?B?NUR3cUpvVVgvOGlXRk83RFNQOWd0cFFUeE5xaEJmVnVRb3U3MG13N3RhTVJN?=
 =?utf-8?B?SnZWVXE5YUlqM2liVndVQlA5OVRwUDJNa3dKZ0h6cDBMb3dzMS8yYjRPenJM?=
 =?utf-8?B?amIyT091T3BxR1J5Y200bGhlT0x5SzJHQ1FhRFN4eXFmSkJIQTIyNVFXbUFp?=
 =?utf-8?B?WUNOMlI4d3ZIUERWamR1K21WbW1tMWZkWmlhSmpBallDQmxDSm9RMklkSUo4?=
 =?utf-8?B?M3RYVlZUVGVTYTQ3NGd6NFdHVHhhSlc2M1B0YmhnMGVnVk1mRTlzTVpIRW1U?=
 =?utf-8?B?YkRqWnpycUUrWExBblJZdllTVFJQZjJTMnROYzlxK0dBTVRwUk8rQkR2QUEz?=
 =?utf-8?B?elR0NVUydTVXNEpuNWhodkx4K0JqRFBmODRxV1NzcFhCT0hWN2p4Vms0cFdo?=
 =?utf-8?B?L1NPaWZDNVMzcGFzN1hXYmhJSDQ2dUs3MnN0U1REVnFxZEdGVkZJQkVLNjFU?=
 =?utf-8?B?N3NyMnFRd2dTRDZFT3N5TDZkTWhFSzByK3hmZG9XUEhmQ1hPN0NrR2tnQWVq?=
 =?utf-8?B?dmxMSXMrU2dkZ09SelZ6d1U3ZStIWlFjQ3VaMWVwM0dLeDZPcWZmWGt5SnJC?=
 =?utf-8?B?U015L2VaVHZ3emdCenZyRmF0ZGNic01lakFQOW92RWNDV0x2NTV3dlRyQ3BB?=
 =?utf-8?B?TFpMaTJFZWh3TnhMY085dGVmQmt5YzFqTEliaWF2cVJyYmxzeUhRVEI5UGd3?=
 =?utf-8?B?WHJDeDdTRTRVejhwa0U1MU5icTJ2dEtFK3hlOTZXUFVEaE9EV0J4TG9rc0tE?=
 =?utf-8?B?Y283R3RxeitibmV0bDgrTDhuTFB5S3VTbUJoRDVKYnB4bnc0N1pMcWFaUVli?=
 =?utf-8?B?NndERU53WEViQWhLSElmMVJlYi9nZG41Vnd5emtMcVZiK3d1eE1ZcWl4ZGtW?=
 =?utf-8?B?aC9IVG5QRk5kQWUySFNzWkJhWFByQU80a1pMMEhLaDdZWThLSTU2QWlZd0lz?=
 =?utf-8?B?RUdmd0dXVlJwaGpsYklpL3lSd1BuRmMvd0pmVnBPeDkycWE0UXRwR2RVenRt?=
 =?utf-8?B?UkN4bUJSd3pRMWdBMUtJMVR0bkJmNkh2YW85dmVnZHNWd1YwTjhzY0ZhQ3Bw?=
 =?utf-8?B?cElDOGgwM25mUlBBZVJWbVZSU0pRYUlvZndMdys5MHBJcGJ2MFRvV25Xbyt0?=
 =?utf-8?B?UFM2Q3hhUkNMbkpYNlFqYllVaXpqNCtLWmtQclJqSG9PSGxJZVZmZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82c65f67-5fcd-4049-204e-08da1bd1a2b4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 15:40:41.9424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nNvVUt5vFZlrO94lnU9+QxHRM474ZKD7/3hv7KSK0L/EKe/glSfmrm6pDpRGlHBTcUTncTiPZ6o2DzoArZL6Yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6154

On 11.04.2022 17:20, Luca Fancellu wrote:
> Introduce a way to create different cpupools at boot time, this is
> particularly useful on ARM big.LITTLE system where there might be the
> need to have different cpupools for each type of core, but also
> systems using NUMA can have different cpu pools for each node.
> 
> The feature on arm relies on a specification of the cpupools from the
> device tree to build pools and assign cpus to them.
> 
> ACPI is not supported for this feature.
> 
> With this patch, cpupool0 can now have less cpus than the number of
> online ones, so update the default case for opt_dom0_max_vcpus.
> 
> Documentation is created to explain the feature.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> ---
> Changes in v7:
> - rename xen/common/boot_cpupools.c to xen/common/sched/boot-cpupool.c (Jan)
> - reverted xen/common/Makefile, add entry in xen/common/sched/Makefile
> - changed line in MAINTAINERS under CPU POOLS section (Dario)
> - Fix documentation, update opt_dom0_max_vcpus to the number of cpu in
>   cpupool0 (Julien)
> Changes in v6:
> - Changed docs, return if booted with ACPI in btcpupools_dtb_parse,
>   panic if /chosen does not exists. Changed commit message (Julien)
> - Add Juergen R-by for the xen/common/sched part that didn't change
> Changes in v5:
> - Fixed wrong variable name, swapped schedulers, add scheduler info
>   in the printk (Stefano)
> - introduce assert in cpupool_init and btcpupools_get_cpupool_id to
>   harden the code
> Changes in v4:
> - modify Makefile to put in *.init.o, fixed stubs and macro (Jan)
> - fixed docs, fix brakets (Stefano)
> - keep cpu0 in Pool-0 (Julien)
> - moved printk from btcpupools_allocate_pools to
>   btcpupools_get_cpupool_id
> - Add to docs constraint about cpu0 and Pool-0
> Changes in v3:
> - Add newline to cpupools.txt and removed "default n" from Kconfig (Jan)
> - Fixed comment, moved defines, used global cpu_online_map, use
>   HAS_DEVICE_TREE instead of ARM and place arch specific code in header
>   (Juergen)
> - Fix brakets, x86 code only panic, get rid of scheduler dt node, don't
>   save pool pointer and look for it from the pool list (Stefano)
> - Changed data structures to allow modification to the code.
> Changes in v2:
> - Move feature to common code (Juergen)
> - Try to decouple dtb parse and cpupool creation to allow
>   more way to specify cpupools (for example command line)
> - Created standalone dt node for the scheduler so it can
>   be used in future work to set scheduler specific
>   parameters
> - Use only auto generated ids for cpupools
> ---
>  MAINTAINERS                            |   2 +-
>  docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>  xen/arch/arm/domain_build.c            |   5 +-
>  xen/arch/arm/include/asm/smp.h         |   3 +
>  xen/common/Kconfig                     |   7 +

For consistency, should the addition here - with ...

>  xen/common/sched/Makefile              |   1 +
>  xen/common/sched/boot-cpupool.c        | 207 +++++++++++++++++++++++++
>  xen/common/sched/cpupool.c             |  12 +-

... the new file now under sched/, also be put in sched/Kconfig?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 11 16:02:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 16:02:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303169.517228 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndwUX-0007q5-Us; Mon, 11 Apr 2022 16:02:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303169.517228; Mon, 11 Apr 2022 16:02:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndwUX-0007py-Rt; Mon, 11 Apr 2022 16:02:13 +0000
Received: by outflank-mailman (input) for mailman id 303169;
 Mon, 11 Apr 2022 16:02:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=as7e=UV=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1ndwUX-0007ps-5K
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 16:02:13 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on062a.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::62a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf59bb36-b9b0-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 18:02:11 +0200 (CEST)
Received: from DU2PR04CA0266.eurprd04.prod.outlook.com (2603:10a6:10:28e::31)
 by AM6PR08MB4935.eurprd08.prod.outlook.com (2603:10a6:20b:d5::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 16:02:01 +0000
Received: from DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28e:cafe::a1) by DU2PR04CA0266.outlook.office365.com
 (2603:10a6:10:28e::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend
 Transport; Mon, 11 Apr 2022 16:02:01 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT012.mail.protection.outlook.com (10.152.20.161) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Mon, 11 Apr 2022 16:02:00 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Mon, 11 Apr 2022 16:02:00 +0000
Received: from ae95cf4c58a1.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 11395AC2-EF66-47CF-BF3E-AB8C5816725B.1; 
 Mon, 11 Apr 2022 16:01:49 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ae95cf4c58a1.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Apr 2022 16:01:49 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM0PR08MB3347.eurprd08.prod.outlook.com
 (2603:10a6:208:5f::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr
 2022 16:01:46 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0%11]) with mapi id 15.20.5144.029; Mon, 11 Apr
 2022 16:01:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf59bb36-b9b0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OIO6EzaPgN5Wx9Dx6ReWJ5NqmFLU9C89nzEVqcF4ays=;
 b=CJH+VzjAtwm79j4YCnsOS0ZccNW10swJQk9IezpHAM1tEdm6o6tE/Ov7RHC6PFXJL4B0QAGD3ac82u91MOjqVwkZ6vD1DbxwqIWIOP6uXHSM7MraUxx/uWek48TrHWLItuDBi3nxZSOLl+UBEiZrzyOlkxBWhwkb7Xl7cbwypQI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ca765066d095575e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BJOUw7aTcZUPekfdhW9OgrnId1XDmjPJmAAcHhr3LxcP2ZvixPc0MqXCQVpyA5i8Qu1b4q5UFHYsJ80F9SL04emWDT6PSP1YF0NUPyEwhjzrryDH85Ik/UnoeRdHJagry8fZ/bq2XoKNRJBpbpx2IjAGTeUFt8q5RVqeJ7Kiq0anc/V+4PS1U50PPmKpN4DXaf1ibH6Dkec01w2EwwgIrfMVI1sptFTmcbjD7NFuvwiXGuDqvvVvwuSkFQY71rZ28Cvdn21VSAbJ/IEDIzRAYsG53HHGEpF/k9vj7ctmv7Ru727ejAsjFZYhjRMa99VY7k1tpKEYmx1nE/D/oMVkZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OIO6EzaPgN5Wx9Dx6ReWJ5NqmFLU9C89nzEVqcF4ays=;
 b=izP5UexVHDY1n7Y0Jhv1Gteb8n+AKlHTt3O+ghHoKnDTr4UhQSZf3pGaBgqMBIJCZ5+8ohc6Gf1RyzqwnVh3BLwpg7w/JjQiakTvZhcmggOCmkLcnKRAmb+/RZxLqfGLnC6U2LRL2Syhc4MBj4s7tt+ksA4/hXmgHcznv/vMnF26AdQAQx14DYc8G5qjVFV5FOsy7bsPmC0oG0jZS+iKgiSVATRKKu1eP4z5EPJv5OP/mgUl4cY3C5GLx9GxlEFcclBHLU4Kh88RTMlh89XHBvr5CNXkQfhroWG7uerqWVmLtfTx+mjPp/hIh06aTSb6kf7BfEwRpxO/6PxczTdcHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OIO6EzaPgN5Wx9Dx6ReWJ5NqmFLU9C89nzEVqcF4ays=;
 b=CJH+VzjAtwm79j4YCnsOS0ZccNW10swJQk9IezpHAM1tEdm6o6tE/Ov7RHC6PFXJL4B0QAGD3ac82u91MOjqVwkZ6vD1DbxwqIWIOP6uXHSM7MraUxx/uWek48TrHWLItuDBi3nxZSOLl+UBEiZrzyOlkxBWhwkb7Xl7cbwypQI=
From: Rahul Singh <Rahul.Singh@arm.com>
To: David Vrabel <dvrabel@cantab.net>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
Thread-Topic: [PATCH] xen/evtchn: Add design for static event channel
 signaling for domUs..
Thread-Index: AQHYPsy9MfyfmFhecEGJuSNYyusIgKzOdqoAgByGnQA=
Date: Mon, 11 Apr 2022 16:01:45 +0000
Message-ID: <3A5B600D-9251-4424-800F-AD5B910A78BD@arm.com>
References:
 <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <35700440-4614-cbd3-361c-3a82cb3d37a9@cantab.net>
In-Reply-To: <35700440-4614-cbd3-361c-3a82cb3d37a9@cantab.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 0f353282-a9a7-4b03-c342-08da1bd49d13
x-ms-traffictypediagnostic:
	AM0PR08MB3347:EE_|DB5EUR03FT012:EE_|AM6PR08MB4935:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB493501909CE95BF960DD6A0CFCEA9@AM6PR08MB4935.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 rfHVSIxQF2I2zymC3fEtdtmYTRxy1tv0pnT67/D+RD9vyfKlsYj5CEIf9BF+MwnrWu6XfH+F2ghUzQiSYcs6TPJZll6TG2I9zrpP5nLCWjJAIMeSWWJ1fe+t5yp2mTjkaIxu8latZLeKV+6THVcRPy20i2gDyhtsPzmaJbeVHTtK0kki/1/vY7ITM+kMHnJifpZSwNHLA8gD8Zf4HHdfYw/Fyf0aolok0mS9bmNSFG7aClmm8Th2GnoEwp2K2Kc/5oJBuK2rMetrCknSJ3XNLcwfydhoQOeC51WPbQpnmtGAdyskEXw/l1FmEf4/HNJ3wHoNf532QsVTxesaB+otPQLa3FH3Hg+W4WfS63B+oM5LcQJuD8ElTMEmzJpFv5Bz1Wa/zunsynAPL9a06PJeCpDnkmzEMyc9R8HLxcF6meQ7ovtINRyhOlyi+/1hsjOljSJetDkEwYkGoxMnktslJ/9A7+4xhtilHjMAz/eSBuxWJZdU/qHomx0+kyOFVm4U6MugxuaxDpltAakA80ENW0lSVyyrUtyuT4F/qUDw9nYFGnv2MBJxqPd9Sqt2Gy55LcBD2hPOoY8Xc7VeK8I2myizd3PPyQlDwpGAbe/m1uvQdnKMgAQjpxmIh8nINvrKQgXFg/ieVgfcSN7Ngv98bfaxJr4HdGVkkvSBpXu7op7haUVgG10lz1YXyDSSIvM1L5wo/QlY8Fjyxc4XveNiF9/Kchb7Nns28+mZ9z0subegJKOaFEQ+Sd5JW4IzEaMm
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(33656002)(6486002)(38100700002)(8936002)(26005)(186003)(5660300002)(36756003)(2906002)(508600001)(8676002)(76116006)(66946007)(6916009)(64756008)(86362001)(316002)(54906003)(66476007)(66556008)(66446008)(2616005)(4326008)(6506007)(53546011)(6512007)(71200400001)(122000001)(91956017)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <DE9C5DDE1F206B4EB22338FBFCBC9323@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3347
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b503ff3b-fee9-40ba-3628-08da1bd49484
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0u/yh0xIoouuiWdJFKZIYFWCXD0xICXaxrdJTxfguK5eg697jY6kupM7xJFMZ/0/nyuZYEjk2K6Kyi2rBqkIDBgFIOxCxOMuhHn3wVCKs10NZLYo9qm0f/pT+Gu46PWxPVBgihAx72wWtDxlp3glzPiNLdvqj/tOsjeuz839HbRc5WYAiq9+e6k+ETKCCsLA3nB3x01IDiYDTw07WpfdVdvkPkTi0nZOYO243zjuuxXHdw2RWliakD4ydljzQaDPo/TYK7yIU2zpob2LSL8RqToMc3ncjoA1KEcI/LrYAb1x2YxnB8Hs0q8CL90GA7Wu7hnaJf/m/kS0c1dB09BvBtPA3QDm369OTnf84u19Rax2Gn1IqCToVb67Swil62q0sWt4PjXLna8dWwmNblJPudeSmmsmO1kHZa7d6bYMmEeTOTxlGpqS0+4j1xhKPGPSG8Y7NdpiSXVfBCbU+P0febQJrPzol5/HznAlMNyUieUC7pJpXWU3WFKxzu5+0IZaeNSMQSYXPaQl7XK8bkDYUGT6isKWbTxCyLfkGH3uo65/FVkLZJXgS5/qIfU5whERlSBRXS1/2S0cUGFeZPXfY7gQiYu/s1zXK+YF4ScxPqcW7182nQiaHS3MWeqSXu6LnSM+jp+YYJ1O4l9DGya3l86aQhQlzE6jq5tZYxPcWkDTQE7qwyfeIaG9QcKqJbj9
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(8676002)(5660300002)(4326008)(81166007)(70206006)(2906002)(70586007)(6486002)(8936002)(356005)(2616005)(186003)(316002)(6862004)(86362001)(6506007)(53546011)(6512007)(47076005)(40460700003)(54906003)(336012)(26005)(508600001)(36860700001)(82310400005)(36756003)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 16:02:00.8525
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f353282-a9a7-4b03-c342-08da1bd49d13
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4935

SGVsbG8gRGF2aWQsDQoNClRoYW5rcyBmb3IgcmV2aWV3aW5nIHRoZSBkZXNpZ24gYW5kIHNvcnJ5
IGZvciB0aGUgbGF0ZSByZXBseS4gDQoNCj4gT24gMjQgTWFyIDIwMjIsIGF0IDEyOjI0IHBtLCBE
YXZpZCBWcmFiZWwgPGR2cmFiZWxAY2FudGFiLm5ldD4gd3JvdGU6DQo+IA0KPiANCj4gDQo+IE9u
IDIzLzAzLzIwMjIgMTU6NDMsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4gaW4gZG9tMGxlc3Mgc3lz
dGVtLiBUaGlzIHBhdGNoIGludHJvZHVjZSB0aGUgbmV3IGZlYXR1cmUgdG8gc3VwcG9ydCB0aGUN
Cj4+IHNpZ25hbGluZyBiZXR3ZWVuIHR3byBkb21VcyBpbiBkb20wbGVzcyBzeXN0ZW0uDQo+PiBT
aWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+IC0tLQ0K
Pj4gZG9jcy9kZXNpZ25zL2RvbTBsZXNzLWV2dGNobi5tZCB8IDk2ICsrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKw0KPj4gMSBmaWxlIGNoYW5nZWQsIDk2IGluc2VydGlvbnMoKykNCj4+
IGNyZWF0ZSBtb2RlIDEwMDY0NCBkb2NzL2Rlc2lnbnMvZG9tMGxlc3MtZXZ0Y2huLm1kDQo+PiBk
aWZmIC0tZ2l0IGEvZG9jcy9kZXNpZ25zL2RvbTBsZXNzLWV2dGNobi5tZCBiL2RvY3MvZGVzaWdu
cy9kb20wbGVzcy1ldnRjaG4ubWQNCj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAw
MDAwMDAwMDAwLi42YTFiN2U4YzIyDQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi9kb2NzL2Rl
c2lnbnMvZG9tMGxlc3MtZXZ0Y2huLm1kDQo+PiBAQCAtMCwwICsxLDk2IEBADQo+PiArIyBTaWdu
YWxpbmcgc3VwcG9ydCBiZXR3ZWVuIHR3byBkb21VcyBvbiBkb20wbGVzcyBzeXN0ZW0NCj4+ICsN
Cj4+ICsjIyBDdXJyZW50IHN0YXRlOuKAr0RyYWZ0IHZlcnNpb24NCj4+ICsNCj4+ICsjIyBQcm9w
b3NlcihzKTogUmFodWwgU2luZ2gsIEJlcnRyYW5kIE1hcnF1aXMNCj4+ICsNCj4+ICsjIyBQcm9i
bGVtIFN0YXRlbWVudDoNCj4+ICsNCj4+ICtUaGUgZ29hbCBvZiB0aGlzIHdvcmsgaXMgdG8gZGVm
aW5lIGEgc2ltcGxlIHNpZ25hbGluZyBzeXN0ZW0gYmV0d2VlbiBYZW4gZ3Vlc3RzDQo+PiAraW4g
ZG9tMGxlc3Mgc3lzdGVtcy4NCj4+ICsNCj4+ICtJbiBkb20wbGVzcyBzeXN0ZW0sIHdlIGNhbm5v
dCBtYWtlIHVzZSBvZiB4ZW5idXMgYW5kIHhlbnN0b3JlIHRoYXQgYXJlIHVzZWQgaW4NCj4+ICtu
b3JtYWwgc3lzdGVtcyB3aXRoIGR5bmFtaWMgVk1zIHRvIGNvbW11bmljYXRlIGJldHdlZW4gZG9t
YWlucyBieSBwcm92aWRpbmcgYQ0KPj4gK2J1cyBhYnN0cmFjdGlvbiBmb3IgcGFyYXZpcnR1YWxp
emVkIGRyaXZlcnMuDQo+PiArDQo+PiArT25lIHBvc3NpYmxlIHNvbHV0aW9uIHRvIGltcGxlbWVu
dCB0aGUgc2lnbmFsaW5nIHN5c3RlbSBiZXR3ZWVuIGRvbVVzIGlzIGJhc2VkDQo+PiArb24gZXZl
bnQgY2hhbm5lbHMuDQo+IA0KPiBUaGlzIHByb2JsZW0gc3RhdGVtZW50IGNvdWxkIGRvIHdpdGgg
c29tZSBleGFtcGxlIHVzZSBjYXNlcyB0aGF0IGFyZSB1c2VmdWxseSBzb2x2ZWQgYnkgdGhpcyBw
cm9wb3NlZCBzb2x1dGlvbi4NCj4gDQo+ICJXZSBkb24ndCBoYXZlIHhlbnN0b3JlIHNvIGNhbid0
IHNldCB1cCBzaGFyZWQgcmluZ3MsIGJ1dCBoZXJlJ3MgYSByZXBsYWNlbWVudCBjb21tcyBtZWNo
YW5pc20gdGhhdCBjYW4gZG8gYSBzaW5nbGUgYml0LiIgRG9lc24ndCBzZWVtIHZlcnkgY29tcGVs
bGluZyB0byBtZS4NCg0KT2suIExldCBtZSBhZGQgbW9yZSBpbmZvcm1hdGlvbiBpbiBuZXh0IHZl
cnNpb24uDQo+IA0KPj4gKyBjaG9zZW4gew0KPj4gKyAuLi4uDQo+PiArDQo+PiArIGRvbVUxOiBk
b21VMSB7DQo+PiArIC4uLi4uLg0KPj4gKyB9Ow0KPj4gKw0KPj4gKyBkb21VMjogZG9tVTIgew0K
Pj4gKyAuLi4uLi4NCj4+ICsgfTsNCj4+ICsNCj4+ICsgZXZ0Y2huQDEgew0KPj4gKyBjb21wYXRp
YmxlID0gInhlbixldnRjaG4iOw0KPj4gKyB4ZW4sZXZ0Y2huID0gPDB4YSAmZG9tVTEgMHhiICZk
b21VMj47DQo+PiArIH07DQo+PiArDQo+PiArIGV2dGNobkAyIHsNCj4+ICsgY29tcGF0aWJsZSA9
ICJ4ZW4sZXZ0Y2huIjsNCj4+ICsgeGVuLGV2dGNobiA9IDwweGMgJmRvbVUxIDB4ZCAmZG9tVTI+
Ow0KPj4gKyB9Ow0KPiANCj4gSG93IGlzIHRoZSBkb21haW4gc3VwcG9zZWQgdG8ga25vdyB3aGF0
IHRoZXNlIGV2ZW50IGNoYW5uZWxzIGFyZSBmb3I/DQoNCkFzIHdlIGFyZSBzdGF0aWNhbGx5IGRl
ZmluaW5nIHRoZSBldmVudCBjaGFubmVsIGluIFhFTiwgd2UgY2FuIGRvY3VtZW50IHRoZSBldmVu
dA0KY2hhbm5lbCBjb25uZWN0aW9uIGluZm9ybWF0aW9uIGZvciB0aGUgZW5kLXVzZXIgaW4gdGhl
IGVuZC11c2VyIGRvY3VtZW50YXRpb24gYW5kDQpsZXQgdGhlIHVzZXIgZGVjaWRlIGhvdyBoZSBp
cyBnb2luZyB0byB1c2UgaXQuICANCg0KPiANCj4gSSdtIG5vdCB0aGF0IGZhbWlsaWFyIHdpdGgg
ZGV2aWNlIHRyZWUuIElzIGl0IHBvc3NpYmxlIHRvIGdpdmUgdGhlc2UgZW50cmllcyBuYW1lPw0K
DQpBcyBwZXIgdGhlIGRldmljZS10cmVlIHNwZWNpZmljYXRpb24sIGVhY2ggbm9kZSBpbiB0aGUg
ZGV2aWNlIHRyZWUgaXMgbmFtZWQgYWNjb3JkaW5nIHRvIHRoZSBmb2xsb3dpbmcgY29udmVudGlv
bg0KCW5vZGUtbmFtZUB1bml0LWFkZHJlc3MNCg0KV2UgY2FuIGdpdmUgdGhlIG5hbWUgdG8gdGhl
c2UgZW50cmllcyBidXQgaW4gYW5vdGhlciBlbWFpbCwgd2UgYXJlIGRpc2N1c3NpbmcgaGF2aW5n
IHNpbmdlIG5vZGUsIGluIHRoYXQNCmNhc2UgdGhlcmUgaXMgbm8gbmVlZCB0byBnaXZlIGEgbmFt
ZS4NCg0KZXZ0Y2huIHsNCgljb21wYXRpYmxlID0gInhlbixldnRjaG4tdjHigJ07DQoJeGVuLGV2
dGNobiA9IDwweGEgJmRvbVUxIDB4YiAmZG9tVTIgMHhjICZkb21VMSAweGQgJmRvbVUyPjsNCn07
DQoNClJlZ2FyZHMuDQpSYWh1bA0KPiANCj4gRGF2aWQNCg0K


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 16:14:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 16:14:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303174.517239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndwfw-0000vF-UJ; Mon, 11 Apr 2022 16:14:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303174.517239; Mon, 11 Apr 2022 16:14:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndwfw-0000v8-RQ; Mon, 11 Apr 2022 16:14:00 +0000
Received: by outflank-mailman (input) for mailman id 303174;
 Mon, 11 Apr 2022 16:13:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/fGF=UV=citrix.com=prvs=09352fbbd=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ndwfv-0000v1-QA
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 16:13:59 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 623a465c-b9b2-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 18:13:56 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 623a465c-b9b2-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649693636;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=g3Dfwn4w1/xGuwF2gVmGTQVILZVa/GsBPT2QW5sT/NI=;
  b=HWaGd53sIOpF2RveROThUFizX1Ye+uDCvyahravW6aXaCe/molpKqiSv
   zoTD9bpufuznXMcB61iSAPu5dGgz06nI/XZdDlJxJ4A26W9wjBxverxxG
   sC5uB24xtvWa++dYoJdR783LE0SpwgtaKrCy4cR98UuL+e3qdwlQNQQAz
   A=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68583968
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TiE/yqKkjUhbZrtvFE+RL5UlxSXFcZb7ZxGr2PjKsXjdYENS0mYBm
 mdKWm2DMvnYZGLxeYp1O9y+pEIBvpSAxoc2GQFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tcx2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 N50rrCsRQQKApLNydQPY15HSzNPB5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ6aDN
 5FIN2oHgBLobkwWCFY2GcgCpsDrr2W4fTNg9XWFnP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0ziGQ0TPtGbzTuD81qvi/XJkCe9X5gdfJW0+fJnj0ea7nACAx0RE12gqL+2jVDWc9FYL
 VYd9mwxrKwx3EuxR9L5Uluzp3vslhwBX9tdFcUq5QfLzbDbiy6bDGUZSj9KaPQ9qdQ7Azct0
 zehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi/Hhr5s6ihbnR9NqAqmzyNbyHFnYz
 yiRqSkih50alcMRy7ig5lfDni6toZ7SCAUy423qsnmNt10jItT/PsrxtAadva0owJulokept
 0Eft9SS78MyMpDcpD69B/pVDoCT3qPQWNHDumJHE54k/jWr3nese4FM/T1zTHtU3tY4lSzBO
 xGK514IjHNHFD7zNPIsPdrtYyg/5fK4fekJQMw4eTanjnJZUAactB9jakeLt4wGuBh9yPpvU
 Xt3nCvFMJr7NUiF5GftLwv++eVyrszb+Y80bcqmpylLKZLEOBaopU4taTNilNwR4qKeuxny+
 N1CLcaMwBg3eLSgPniJqNBIcAlVfCJT6XXKRyt/LLDrH+abMDt5V6+5LU0JJuSJYJi5Zs+Xp
 yrgCye0OXL0hGHdKBXiV5yQQOiHYHqLllpiZXZEFQ/xgxALON/zhI9CJ8pfVeR2r4RLkK8rJ
 8Tpju3dW5yjvBycoG9DBXQ8xaQ/HCmWafWmY3L+MGdiJcY5L+ELk/e9FjbSGOA1JnLfnaMDT
 3eIi2s3nbJrq9xeMfvr
IronPort-HdrOrdr: A9a23:XpQEq6DIItmfwxTlHemu55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P
 xG/c5rsSMc5wx8ZJhNo7+90ey7MBXhHP1OkOws1NWZLWrbUQKTRekIh+bfKn/bak/DH4ZmpN
 5dmsNFaOEYY2IVsfrH
X-IronPort-AV: E=Sophos;i="5.90,252,1643691600"; 
   d="scan'208";a="68583968"
Date: Mon, 11 Apr 2022 17:13:47 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>, Ross Lagerwall
	<ross.lagerwall@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "Daniel P . Smith"
	<dpsmith@apertussolutions.com>, Julien Grall <jgrall@amazon.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Konrad Rzeszutek Wilk
	<konrad.wilk@oracle.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Ping: [XEN PATCH v10 7/7] build: adding out-of-tree support to the
 xen build
Message-ID: <YlRTu/5yIaxJF9Z3@perard.uk.xensource.com>
References: <20220322112238.1117737-1-anthony.perard@citrix.com>
 <20220322112238.1117737-8-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220322112238.1117737-8-anthony.perard@citrix.com>

Hi Ross,

Could you also ack this livpatch change?

Thanks.

On Tue, Mar 22, 2022 at 11:22:38AM +0000, Anthony PERARD wrote:
> This implement out-of-tree support, there's two ways to create an
> out-of-tree build tree (after that, `make` in that new directory
> works):
>     make O=build
>     mkdir build; cd build; make -f ../Makefile
> also works with an absolute path for both.
> 
> This implementation only works if the source tree is clean, as we use
> VPATH.
> 
> This patch copies most new code with handling out-of-tree build from
> Linux v5.12.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> Acked-by: Julien Grall <jgrall@amazon.com>
> Tested-by: Julien Grall <jgrall@amazon.com>
> ---
[...]
> diff --git a/xen/test/livepatch/Makefile b/xen/test/livepatch/Makefile
> index ddb07371315e..c258ab0b5940 100644
> --- a/xen/test/livepatch/Makefile
> +++ b/xen/test/livepatch/Makefile
> @@ -11,6 +11,8 @@ endif
>  CODE_ADDR=$(shell nm --defined $(1) | grep $(2) | awk '{print "0x"$$1}')
>  CODE_SZ=$(shell nm --defined -S $(1) | grep $(2) | awk '{ print "0x"$$2}')
>  
> +CFLAGS-y += -iquote $(obj)
> +
>  extra-y += xen_hello_world.livepatch
>  xen_hello_world-objs := xen_hello_world_func.o xen_hello_world.o note.o xen_note.o modinfo.o
>  $(obj)/xen_hello_world.o: $(obj)/config.h

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 16:37:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 16:37:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303181.517249 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndx2T-0003QF-So; Mon, 11 Apr 2022 16:37:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303181.517249; Mon, 11 Apr 2022 16:37:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndx2T-0003Q8-Po; Mon, 11 Apr 2022 16:37:17 +0000
Received: by outflank-mailman (input) for mailman id 303181;
 Mon, 11 Apr 2022 16:37:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HKFE=UV=citrix.com=prvs=093f373ac=ross.lagerwall@srs-se1.protection.inumbo.net>)
 id 1ndx2R-0003Q2-TC
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 16:37:16 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a316256c-b9b5-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 18:37:13 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a316256c-b9b5-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649695034;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=PXnKRUiEu3flkVGZJuSE892mOyZnkhJ96C6PfmmXlqw=;
  b=U2kt6+ope0PxyhFfFMh1Ee/PmHgJauS4z7cKonXZbQAqvwJDKKkYODfk
   hJCnqT62weunWZtsiP3TK3oxDFefevOzKKQNnXLWhCWP1XzxGh1HV08qK
   z8D7TG+Pg54QEzAtHMy2smmrPFX/tqmV9Ktn7l8Xy/KWHGazBoNAR3wO7
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68569806
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aQahEKoG3iUdlWSWGVviAwcGWYZeBmKPZRIvgKrLsJaIsI4StFCzt
 garIBnSMq6PY2L8c49zbI2x8x4P78eEndIxHgI/+yo1FSgQ9puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 Iqq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBFIneqd89dyliHShBFJEf34TsHXiQmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbCFrAiSJ/OWbrD4dtw1zYsnMFeW/3ZY
 qL1bBIxPEmeMk0XZD/7DrpkwOiZviOhTwEfrU2njrI242rrxytuhe2F3N39JYXRGJQ9clyjj
 n3C13T0BFcdLtP34SGe7numi+vLnCX6cIEfDru18rhtmlL77mAcBBAZT1KTveiyikn4XclWb
 UMT5EIGrq807kWnCMb8Wx6Qp2SNtRoRHdFXFoUS6hyJy6fSyxaUAC4DVDEpQN4sudIyRDcq/
 kSUhN6vDjtq2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nZtRsCqexivX8HDjix
 DbMpy87750fldUO1rm71Vnfjiiwu4PSSQoo+gTQWHnj5QR8DLNJfKTxtwKdt6wZat/EEB/R5
 xDohvRy8sgkKYO8rwypcN8DFY6A26+iCxbggXFGSsxJGyuWx1aveoVZ4TdbLUhvM9oZdTKBX
 HI/qT+997cIYiL0MPYfj5aZTp1zkPO+TYiNuuX8NIImX3RnSOOQEMiCj2a01nulrkUjmLpX1
 XyzIZf1ViZy5UiKIVOLqwYhPV0Dm3tWKYD7H8mTI/GbPV22PiP9dFv9GAHSBt3VFYvdyOkvz
 /5RNtGR1zJUW/Dkby/c/OY7dA5WfCZiW8ur8pMGLIZvxzaK/0l7VZfsLU4JIdQ5z8y5aM+Vl
 p1CZqOo4AWm3iCWQel7QntidKnuTf5CQYETZkQR0aKT8yF7O+6Htf5HH7NuJOVP3LEznJZcE
 qheE+3dU6snd9gy02lEBXULhNc5L0rDaMPnF3fNXQXTiLY8H1eZpYK+JlKHGetnJnPfiPbSa
 oaIj2vzaZECWx5jHIDRbveuxEm2pn8ThKR5WE6gHzWZUB6EHFRCQ8ApssIKHg==
IronPort-HdrOrdr: A9a23:Dqd/GKg7Nl8PN20xwaTQCxQA9nBQX2113DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3IwerwRZVpQRvnhPtICPoqTMuftW7dySSVxeBZnMffKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIXerIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxVLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1SsF
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RG4Fq/QpF491H2mxa1e
 UkkC1Qe/ibLEmhOV1dlCGdmTUIFgxerUMKh2Xo2EcL6vaJOw7SQ/Ax+76xNCGpsHbI9esMoJ
 6i0w+ixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MciFW5uYd499RjBmcga+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zo93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkf8IzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehTKYd0s8LAo23FUgMyPeFOwC1zxdLkHqbrUn8ki
X-IronPort-AV: E=Sophos;i="5.90,252,1643691600"; 
   d="scan'208";a="68569806"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U39HrjAhtuIfIF/eVRxVaYYLfUi7wrk/Asw47QhWomtB0ArzUSLYld6Sy81r8rKhVhREXkJrF8g1oJe8ouCL+yr8V9eneFyMk4i7zPnXoyQpxZHPhzxE68DKb5mlY7o3uX4EeHVSwDE4OKJVdeYVXYl5E/9LOp8XmrDLWEPUN+wW1BeXUCwj7JF3ArQLEZ3Zy2gCHAYz0zrfdpgBKG+kd98Yi1gSc44nOZnUPj8ZTR5pyENfQCSmXGS5+Yb9fbms+cf1mwFj2+0/htVcMzpu+rbYCuT/mCw2zAE9YkWh49oGGw3NNOWK3UJaowIQJGlTqz7Gv0bdFtHQt557364zJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0gTF0zyo30UUWmfs8XexpK7uJLFU6+Ul5g3Eh9tnMqc=;
 b=ge8sEiamLRnEu6r02GL6BbruCvWH5JugdrAkkCjs14kXAyIkLmV/1egzIy5xdZvrovUe2v6vMVzvPaWyQ0krbvgwVvC3S34ivCI/EJQTb930K0vHHjJt293E6IOEPCArBoCMibYsOYqsg2noeDmqtFO/vA/aveTdB5j9MOjNE7DxD+jdB0AsVBABhjLkz1qsMBZTe0Jg80L56f67QIfgjHC4xY9BbhiYIxlgCb0N2J84OlZDbMqB2LIcu9Uk2/bQcDZMPApqMJ/GDcnJTNqyWFEeMqeb/25DPWeQwScX4X/hXCxOSSDVx4hEDy6CukfmVO2gFsd7oqBO0Ta2jZ3vVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0gTF0zyo30UUWmfs8XexpK7uJLFU6+Ul5g3Eh9tnMqc=;
 b=O3dNQqqjpffrF/3pMh0tCWErzEHOL8MUVAZLRm5ixzrfVwGnWT5YOAP3tai5+8POVNnNt0K7QaAv/m1P0gJ5LmXldZoSj3BIdKlPlLj0DdTumvT0rgPhZum93OZYKpDAiYqCOAKhEJpWCybbbgTYozmzpeyJYuRUAu7x60AcAi8=
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, "Daniel P . Smith"
	<dpsmith@apertussolutions.com>, Julien Grall <jgrall@amazon.com>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [XEN PATCH v10 7/7] build: adding out-of-tree support to the xen
 build
Thread-Topic: [XEN PATCH v10 7/7] build: adding out-of-tree support to the xen
 build
Thread-Index: AQHYPd9LOZzBp6Umj0ytv6m2JZ6hrazrCFex
Date: Mon, 11 Apr 2022 16:37:03 +0000
Message-ID: <PH0PR03MB6382A643B6F610CC13C227A0F0EA9@PH0PR03MB6382.namprd03.prod.outlook.com>
References: <20220322112238.1117737-1-anthony.perard@citrix.com>
 <20220322112238.1117737-8-anthony.perard@citrix.com>
In-Reply-To: <20220322112238.1117737-8-anthony.perard@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 63731587-e5df-48c0-3dcb-08da1bd9824f
x-ms-traffictypediagnostic: DM5PR03MB2985:EE_
x-microsoft-antispam-prvs: <DM5PR03MB2985A01CBA7351F583DDD997F0EA9@DM5PR03MB2985.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: /JMZzTAGFZVOIGdQFomSCacm7sNZZPWR3xyIuMXwmqh3jsBQHXSSkLXXAksEfFKyrq+KDVHvxP6dLsgh2JcEXRbYi9btYgCL2abTSMrXsuwzscCVsRd4Q+X4FUHl3taQCqRNOvGJofnhXcWO1PE7EepSmyuDMcYKt3ERYXjS+u/JJrgGcedfl2dkoaLxzwRglGTU3WdN0sJfYa0vU+HI6Fnx49N924a500rqPs5pKxrCLpJ2yhnxBa2s69lelsONb/G0iLiFW77zaPYgpr+2fa0iACA0bW0+h5oJAVNQBTvlcj3RcU/083/4B7NtisPn/dKgV2jw7Jarln5TbPAzptkzhF8unxnlHelMBEYRM3RIEGnDE4swPDblihDjVLIzxpEkvJpQZi8IfAcZT3qg03rGoe+ml52A9U+CU5XA/Co4brXDIAeD60NH7etlOE74edrtBcLaQCmtJhf+xuE6J4IIioNOa5e4hek72kW4BCmj6b+Zt+i4dR8T9qYmrvRNwy5zC2ySIVF3kd621rOliT1edq8mC8gSrJWtrsIGrslDnuL13c3Fs1BBgOXkG0CmNX4HRQUN6WefOzdD0kQdmTV/1B5CJFPqL5DlHut9TqNS/pfY+xh7IXoaIWf5h8VHg9orsuREdlGlx4XZHgAoXpUNqTHFQYtnFsLWUHTfgbNWTTAuMerskt99xr1ELWfaOM4oKkrffMB5asl3bsQfLg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(55016003)(33656002)(38070700005)(71200400001)(54906003)(110136005)(82960400001)(66556008)(64756008)(508600001)(8676002)(91956017)(76116006)(66946007)(4326008)(66446008)(66476007)(122000001)(38100700002)(44832011)(316002)(2906002)(186003)(26005)(86362001)(52536014)(7696005)(53546011)(6506007)(9686003)(8936002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?aXGAFMkcDEd8fQmV277Vzk4x7IHxvAxob+Z+dD6NENyeeKp1442MJlvVHU?=
 =?iso-8859-1?Q?C9vLLySffg/w+UY/SA031Bsyvw8l9VJj/fpki4DQasH5dcYQUOknp7BbVd?=
 =?iso-8859-1?Q?cj89WOmAD0e6cJnFHRWU5nGIbpEDyARS+edB0Q6vYGwTpoG+sGHi6mDp9W?=
 =?iso-8859-1?Q?hjo27T2EXJ7MZ+lJ3mabUQwCeOEw4hJjVqfoPckkKDrPAuR5BjjAYz/GRL?=
 =?iso-8859-1?Q?Ct7/z26S86AKbBS6nQzwy+z3F7VBet/JfSr4oVYlZcBMelKK6oQMkFH6k+?=
 =?iso-8859-1?Q?4kGHTzvxyN2NDyY6KNZRViXboppzUvlDVivhK7Wm4BpixCj5NqJgsIpNpH?=
 =?iso-8859-1?Q?r2+03JPCtgAOPQndxh/3zwH8UYQnB5e3wOTDQd4S4nxmOK1tfsT1mYmHum?=
 =?iso-8859-1?Q?Bp2XG4avuaTJ7ealkaL2nNs+61AeF+0J23U0b5oK/wgpUC7bo+ibMPWGY6?=
 =?iso-8859-1?Q?Wo334s6fxxK4De/c4syO4rm8qbeXmA3BhPLEUF8ppaH+LeCugBbGdJA8TF?=
 =?iso-8859-1?Q?2WPvmUJfUiNBcu2BhL6pTpyW0R2fMy+4mGLuRSswWlhSs51W3N7GNto+8y?=
 =?iso-8859-1?Q?TqzHChBRhZGd5bLG3ssCbDffcOotXwFEXaiWKgwxmAYx8Gq/526m/BrcZF?=
 =?iso-8859-1?Q?kuAcNOFioUzyg9Hg/JbuIgNsTXnGZAOTJVIyiyLuQSGyIibRwaC11weHtd?=
 =?iso-8859-1?Q?LnpifEcE6Bu/FtowKQtslbEtxWqqsKgXHLcg+tSRC0NvXnMqVh27gqYmGN?=
 =?iso-8859-1?Q?FjXScu1MJZ3O6462nMn4SnnfP0oYcZlOx8nxCiSrRnXLLQ3GRzNvE1q1+K?=
 =?iso-8859-1?Q?OY9pAupaivmqcBv96W58fmWKfrgOQ75tcJdmi74G+xcOHGVonO6WT8nzUH?=
 =?iso-8859-1?Q?LYN3ZEIG8NR7+oFO6rtOFEel/VyiQFxplyGMv8BWqglIWEfdsqIxUnqH8M?=
 =?iso-8859-1?Q?Dn7zR2yHDTZlTV9vD42iAlnnu7gsU/OcYccuAEfhVP9AL0KbBASIHgFXcE?=
 =?iso-8859-1?Q?CiWL++BXfkOhp+B6/Ps6rFjUWM3o8pSglvc5hjvQJFUNCKA16ir+wyZXIe?=
 =?iso-8859-1?Q?0VVw9Dw0XV2S6kmFEcrgrxt/yguzJ7cSUYnsS+EtxViJT/nF55EHcoFTYo?=
 =?iso-8859-1?Q?W5VkgDfZZ+qiqMXcb7hfSw8r4mKyJIHMpzr9QToyLHXIzx28nLE+DhLP8E?=
 =?iso-8859-1?Q?Sgbg9mhhE2dp72642Q7JRkVOcc0tkx0VR2lSEue6HlWKhHNY4tD1V2hpOd?=
 =?iso-8859-1?Q?ZgBO2BjjhBb+Q85aXLCUsLESSj64qXRxwFd1Vewz2G2cGieK6ZyAWnfnXo?=
 =?iso-8859-1?Q?amSX/Jxncxl28mAGOSTnloJUxjvyroza7DxJDubp6OC+sepB7ZMDBeluoH?=
 =?iso-8859-1?Q?1qpLWfeHzgcSvOrC0sUGFFKLBPb3X70AgV5u1ca/7GGwI8QPAf78LvjdUr?=
 =?iso-8859-1?Q?863Y52GkuKWvZOUZPofB9DRCT63WEzf4whOAwiyzXahBWoUiOx81BDbGpy?=
 =?iso-8859-1?Q?bL9OujCOInFxJtDWxT+zvJ3hh+u9E2wlEy28/uPCIpd9rQw33fgmDt2xA6?=
 =?iso-8859-1?Q?Hra6e/8sTeOiUNFTqQ0l4XioMiElhHx7wHZZgpCz7+xMyvmgTXIC5pyo7j?=
 =?iso-8859-1?Q?ExKrmDf+vVJl/rp7J3jkgTobQRRaoMGI4d3AiXa1nV1Hi7LsG3Z+lfKOK0?=
 =?iso-8859-1?Q?yfQ0VOPi5hfMhARz5xc0E7WgBkCUfa9MGe7wLx2VWjP2QoSOkLXSJmtdLM?=
 =?iso-8859-1?Q?GKytRP8eaJjluMrxQmweZmrgt0wI5776Ex4mafeKLiV8whJihyU7+VLb/l?=
 =?iso-8859-1?Q?FY2LQ8b0fQ=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63731587-e5df-48c0-3dcb-08da1bd9824f
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 16:37:03.2868
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5os2C46c7pTE5FkvDN2kgmqwV2DnX5RmVFeYS+a4bFqTFEfg1BXgWWkZ+7r13FWgedrY9Pq/Vrd0BlkzTEp/b6p5vRVwohAQairD+YG97EQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2985
X-OriginatorOrg: citrix.com

> From: Anthony PERARD <anthony.perard@citrix.com>=0A=
> Sent: Tuesday, March 22, 2022 11:22 AM=0A=
> To: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>=0A=
> Cc: Anthony Perard <anthony.perard@citrix.com>; Jan Beulich <jbeulich@sus=
e.com>; Daniel P . Smith <dpsmith@apertussolutions.com>; Julien Grall <jgra=
ll@amazon.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; George Dunlap <G=
eorge.Dunlap@citrix.com>; Julien Grall <julien@xen.org>; Stefano Stabellini=
 <sstabellini@kernel.org>; Wei Liu <wl@xen.org>; Roger Pau Monne <roger.pau=
@citrix.com>; Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; Ross Lagerwal=
l <ross.lagerwall@citrix.com>; Daniel De Graaf <dgdegra@tycho.nsa.gov>=0A=
> Subject: [XEN PATCH v10 7/7] build: adding out-of-tree support to the xen=
 build =0A=
>  =0A=
> This implement out-of-tree support, there's two ways to create an=0A=
> out-of-tree build tree (after that, `make` in that new directory=0A=
> works):=0A=
>     make O=3Dbuild=0A=
>     mkdir build; cd build; make -f ../Makefile=0A=
> also works with an absolute path for both.=0A=
> =0A=
> This implementation only works if the source tree is clean, as we use=0A=
> VPATH.=0A=
> =0A=
> This patch copies most new code with handling out-of-tree build from=0A=
> Linux v5.12.=0A=
> =0A=
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>=0A=
> Acked-by: Jan Beulich <jbeulich@suse.com>=0A=
> Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>=0A=
> Acked-by: Julien Grall <jgrall@amazon.com>=0A=
> Tested-by: Julien Grall <jgrall@amazon.com>=0A=
> =0A=
=0A=
Acked-by: Ross Lagerwall <ross.lagerwall@citrix.com> (livepatch parts)=


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 16:40:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 16:40:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303187.517260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndx5s-0004mi-Bw; Mon, 11 Apr 2022 16:40:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303187.517260; Mon, 11 Apr 2022 16:40:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndx5s-0004mb-99; Mon, 11 Apr 2022 16:40:48 +0000
Received: by outflank-mailman (input) for mailman id 303187;
 Mon, 11 Apr 2022 16:40:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndx5q-0004mR-NY; Mon, 11 Apr 2022 16:40:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndx5q-00038K-L8; Mon, 11 Apr 2022 16:40:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ndx5q-0001WL-A7; Mon, 11 Apr 2022 16:40:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ndx5q-00055O-9f; Mon, 11 Apr 2022 16:40:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ffnNNm8qe6TzAXI43txdWHcakXwgJZn5bJGjvab4MuQ=; b=YaiKir2PUGVu0v0oLfUmkPPpRy
	ndXzZsxOCMGCKPr1HUclBQtjOSfam02tPNbJgAgMUTC7hgN9Kl4D++NyuIhD7cAEopG0MQwqRw76D
	YSNVWHofiVmnmWn/E2RoiupOY/CULCm4HYnt83ZCrwh3frBYxkpdRjBcPMI/3WVTJDS4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169311-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169311: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 16:40:46 +0000

flight 169311 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169311/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  328 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 17:26:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 17:26:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303204.517273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndxo3-0000k1-SU; Mon, 11 Apr 2022 17:26:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303204.517273; Mon, 11 Apr 2022 17:26:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndxo3-0000ju-Nf; Mon, 11 Apr 2022 17:26:27 +0000
Received: by outflank-mailman (input) for mailman id 303204;
 Mon, 11 Apr 2022 17:26:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iPrP=UV=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ndxo2-0000jo-Fh
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 17:26:26 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 825b5018-b9bc-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 19:26:23 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id 80BF421606;
 Mon, 11 Apr 2022 17:26:23 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id 1C7B9A3B83;
 Mon, 11 Apr 2022 17:26:23 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 7FF53DA7F7; Mon, 11 Apr 2022 19:22:18 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 825b5018-b9bc-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649697983;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ojOMmoWG3Vi82iwkKmDthce/DTUxrqsrVMcEPPdM3So=;
	b=QZwWZVQwC0bnchneRkqJ/+jzsU6T9BsE/QwjE1iflJ8e+QPH7qzL+AxcI+atiGlV8qm9Lo
	u8oIaWSdY7hbFlYvzT8ENcrgX9LIGNQj4Ik1HCmhtpjbfJ75vgExpzBPpp974aNYAtu6v8
	bf5VKoGfQqIUb3Ou/OOGio4KxiUFZwg=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649697983;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ojOMmoWG3Vi82iwkKmDthce/DTUxrqsrVMcEPPdM3So=;
	b=98et+OqtZl3DiPU61ep6rcrI2VbwKFWZL1iuQ8dNt7YkOb55uCdVju/GMJmDyvRi7cAHwR
	HPLi3jycKdDWeJCw==
Date: Mon, 11 Apr 2022 19:22:18 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open
 coding it
Message-ID: <20220411172218.GT15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
References: <20220409045043.23593-1-hch@lst.de>
 <20220409045043.23593-9-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220409045043.23593-9-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Sat, Apr 09, 2022 at 06:50:24AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Acked-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 17:28:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 17:28:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303208.517283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndxq1-0001JO-6a; Mon, 11 Apr 2022 17:28:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303208.517283; Mon, 11 Apr 2022 17:28:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndxq1-0001JH-3O; Mon, 11 Apr 2022 17:28:29 +0000
Received: by outflank-mailman (input) for mailman id 303208;
 Mon, 11 Apr 2022 17:28:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iPrP=UV=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ndxpz-0001J9-VR
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 17:28:27 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cba465f7-b9bc-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 19:28:26 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id ABD701F7AD;
 Mon, 11 Apr 2022 17:28:26 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id 775CCA3B82;
 Mon, 11 Apr 2022 17:28:26 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 0F66CDA7F7; Mon, 11 Apr 2022 19:24:22 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cba465f7-b9bc-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649698106;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0RiNf7uoJjg1rRFObzVZQSCMAd1nof/h0vLpUgMcwvY=;
	b=tfXHkMaj5kpUcLtvBYnwRGxDxcXmodIyKTVNxARm8whPlAkOVHL3pBXy48YlCR99uput93
	ek64inXcfBYSt9NuV9MWohA/Liu5eXfW+58ujnwevThluScwhFajBAp+/PR+hCYJW8ogrY
	iu/7/TOOXGQ1NMcWDFWaoeOCSwaX7H0=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649698106;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0RiNf7uoJjg1rRFObzVZQSCMAd1nof/h0vLpUgMcwvY=;
	b=y/QeT70zXSjm5PP3weiVBlhCkwkEL69tQO+HTTi+7j+oI3RtiZJDs5egZuujl2LcaWZ24F
	apjvnh1HQMyDZeAA==
Date: Mon, 11 Apr 2022 19:24:21 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph =?iso-8859-1?Q?B=F6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Coly Li <colyli@suse.de>
Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Message-ID: <20220411172421.GU15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph =?iso-8859-1?Q?B=F6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Coly Li <colyli@suse.de>
References: <20220409045043.23593-1-hch@lst.de>
 <20220409045043.23593-25-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220409045043.23593-25-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Sat, Apr 09, 2022 at 06:50:40AM +0200, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
> 
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph B�hmwalder <christoph.boehmwalder@linbit.com> [btrfs]
> Acked-by: Coly Li <colyli@suse.de> [bcache]
> ---
>  arch/um/drivers/ubd_kern.c          |  2 --
>  block/blk-core.c                    |  2 +-
>  block/blk-lib.c                     |  2 +-
>  block/blk-mq-debugfs.c              |  1 -
>  block/ioctl.c                       |  3 +--
>  drivers/block/drbd/drbd_main.c      |  2 +-
>  drivers/block/drbd/drbd_nl.c        | 19 ++-----------------
>  drivers/block/drbd/drbd_receiver.c  |  3 +--
>  drivers/block/loop.c                | 11 +++--------
>  drivers/block/nbd.c                 |  5 +----
>  drivers/block/null_blk/main.c       |  1 -
>  drivers/block/rbd.c                 |  1 -
>  drivers/block/rnbd/rnbd-clt.c       |  2 --
>  drivers/block/rnbd/rnbd-srv-dev.h   |  3 ---
>  drivers/block/virtio_blk.c          |  2 --
>  drivers/block/xen-blkback/xenbus.c  |  2 +-
>  drivers/block/xen-blkfront.c        |  2 --
>  drivers/block/zram/zram_drv.c       |  1 -
>  drivers/md/bcache/request.c         |  4 ++--
>  drivers/md/bcache/super.c           |  3 +--
>  drivers/md/bcache/sysfs.c           |  2 +-
>  drivers/md/dm-cache-target.c        |  9 +--------
>  drivers/md/dm-clone-target.c        |  9 +--------
>  drivers/md/dm-log-writes.c          |  3 +--
>  drivers/md/dm-raid.c                |  9 ++-------
>  drivers/md/dm-table.c               |  9 ++-------
>  drivers/md/dm-thin.c                | 11 +----------
>  drivers/md/dm.c                     |  3 +--
>  drivers/md/md-linear.c              | 11 +----------
>  drivers/md/raid0.c                  |  7 -------
>  drivers/md/raid1.c                  | 16 +---------------
>  drivers/md/raid10.c                 | 18 ++----------------
>  drivers/md/raid5-cache.c            |  2 +-
>  drivers/md/raid5.c                  | 12 ++++--------
>  drivers/mmc/core/queue.c            |  1 -
>  drivers/mtd/mtd_blkdevs.c           |  1 -
>  drivers/nvme/host/core.c            |  6 ++----
>  drivers/s390/block/dasd_fba.c       |  1 -
>  drivers/scsi/sd.c                   |  2 --
>  drivers/target/target_core_device.c |  2 +-

For

>  fs/btrfs/extent-tree.c              |  4 ++--
>  fs/btrfs/ioctl.c                    |  2 +-

Acked-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 17:29:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 17:29:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303212.517293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndxrD-0001xL-L6; Mon, 11 Apr 2022 17:29:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303212.517293; Mon, 11 Apr 2022 17:29:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndxrD-0001xE-Hb; Mon, 11 Apr 2022 17:29:43 +0000
Received: by outflank-mailman (input) for mailman id 303212;
 Mon, 11 Apr 2022 17:29:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iPrP=UV=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ndxrB-0001x0-TL
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 17:29:41 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7d03b9f-b9bc-11ec-8fbc-03012f2f19d4;
 Mon, 11 Apr 2022 19:29:40 +0200 (CEST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id CB2971F38D;
 Mon, 11 Apr 2022 17:29:40 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id B0827A3B87;
 Mon, 11 Apr 2022 17:29:40 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 47973DA7F7; Mon, 11 Apr 2022 19:25:36 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7d03b9f-b9bc-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1649698180;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=y9/RDfYGC6K6KRC0KdrprIVWfIX/zpdTiz9ROrz551U=;
	b=I9nwx9hrwiLBwY8Cn2rQGBPnpBriJmDMs1b8oNISqOpk754k7ib2Xve0iYAZqqPcSD2SgP
	oZEA90HfyQ7ya+rehSXEh9k5AQbwstldp6HDVnl/WGBpQS17mVXtCGXXbsCypPUDUyaMdU
	y+Peaf55gboQyV27R4kCRTuYgY7wFX4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1649698180;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=y9/RDfYGC6K6KRC0KdrprIVWfIX/zpdTiz9ROrz551U=;
	b=AzkdKu96rYkAsjhpJavWNTiZGL3Agdt16W1llO8/BhnjKgsTeGvgPw66Q+CklEVPEpPHBk
	JsD+WnrQfAy3whCQ==
Date: Mon, 11 Apr 2022 19:25:36 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph =?iso-8859-1?Q?B=F6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>,
	David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 25/27] block: add a bdev_discard_granularity helper
Message-ID: <20220411172536.GV15609@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph =?iso-8859-1?Q?B=F6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>,
	David Sterba <dsterba@suse.com>
References: <20220409045043.23593-1-hch@lst.de>
 <20220409045043.23593-26-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220409045043.23593-26-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Sat, Apr 09, 2022 at 06:50:41AM +0200, Christoph Hellwig wrote:
> Abstract away implementation details from file systems by providing a
> block_device based helper to retrieve the discard granularity.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph B�hmwalder <christoph.boehmwalder@linbit.com> [btrfs]

This ^^^^ is for drbd

> Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
> Acked-by: David Sterba <dsterba@suse.com> [btrfs]


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 18:01:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 18:01:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303217.517305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndyLr-00068n-0H; Mon, 11 Apr 2022 18:01:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303217.517305; Mon, 11 Apr 2022 18:01:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndyLq-00068g-TU; Mon, 11 Apr 2022 18:01:22 +0000
Received: by outflank-mailman (input) for mailman id 303217;
 Mon, 11 Apr 2022 18:01:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndyLp-00068a-1t
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 18:01:21 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndyLo-0004lq-IM; Mon, 11 Apr 2022 18:01:20 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndyLo-00062S-Bp; Mon, 11 Apr 2022 18:01:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=91/dfoNzZ29hQpRnrxvAje+IzY3s4RmxOTU9AKneQGk=; b=0rhH2V7SPqgpxU6+/QmiWAeTjT
	CXckwcFOftpH7ZzJNg+Jmx3ET0c6qG7r7HyB8QBmJjssbSEP/35jeJstPhDsrm96KBBjItsONUo38
	l+w3XxmgKfYSDjOA4PvhJKetririIpjbQOBAfGnFqy1McKAILKzUeVSMwHpw0CgKUUkw=;
Message-ID: <0ecf69d2-c496-d18e-1309-f896ec6bbf4c@xen.org>
Date: Mon, 11 Apr 2022 19:01:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Rahul,

Title: s/../.../

On 23/03/2022 15:43, Rahul Singh wrote:
> in dom0less system. This patch introduce the new feature to support the

s/introduce/introduces/
s/the new/a/

> signaling between two domUs in dom0less system.
Did you intend to add a newline before the second sentence?

> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>   docs/designs/dom0less-evtchn.md | 96 +++++++++++++++++++++++++++++++++
>   1 file changed, 96 insertions(+)
>   create mode 100644 docs/designs/dom0less-evtchn.md
> 
> diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md
> new file mode 100644
> index 0000000000..6a1b7e8c22
> --- /dev/null
> +++ b/docs/designs/dom0less-evtchn.md
> @@ -0,0 +1,96 @@
> +# Signaling support between two domUs on dom0less system
> +
> +## Current state: Draft version
> +
> +## Proposer(s): Rahul Singh, Bertrand Marquis
> +
> +## Problem Statement:
> +
> +The goal of this work is to define a simple signaling system between Xen guests
> +in dom0less systems.
> +
> +In dom0less system, we cannot make use of xenbus and xenstore that are used in
> +normal systems with dynamic VMs to communicate between domains by providing a
> +bus abstraction for paravirtualized drivers.
> +
> +One possible solution to implement the signaling system between domUs is based
> +on event channels.
> +
> +## Proposal:
> +
> +Event channels are the basic primitive provided by Xen for event notifications.
> +An event channel is a logical connection between 2 domains (more specifically
> +between dom1,port1 and dom2,port2). They essentially store one bit of
> +information, the event of interest is signalled by transitioning this bit from
> +0 to 1. An event is an equivalent of a hardware interrupt.
> +
> +Notifications are received by a guest via an interrupt from Xen to the guest,
> +indicating when an event arrives (setting the bit). 

I am a bit confused with the description. Are you trying to explain the 
event channel in layman term? If not, then event channel protocol is 
more complicated than that (in particular for fifo).

> Further notifications are
> +masked until the bit is cleared again.

I think "masked" is confusing here.

The event channel differentiate "mask" vs "pending". When sending an 
event, the pending bit will be set to 1. If it wasn't already pending 
and the mask bit is clear, then we will notify the guest.

If the pending bit is already set, then we will ignore.

In fact, the event channel is acting similarly to an edge interrupt. I 
wrote similarly, because IIRC they are behaving slightly differently 
(see [1] for more details).

> When a domain wants to wait for data it
> +will block until an event arrives, and then send an event to signal that data
> +has been consumed.
> Events are delivered asynchronously to guests and are
> +enqueued when the guest is not running.

s/guest/domain/ to stay consistent and also include dom0/hardware domain.

> +
> +Event channel communication will be established statically between two domU
> +guests before unpausing the domains after domain creation. Event channel
> +connection information between domUs will be passed to XEN via device tree
> +node.

Why are we limiting ourself to domUs?

> +
> +Under the /chosen node, there needs to be sub nodes with compatible
> +"xen,evtchn" that descibes the event channel connection between two domUs.

s/descibes/describes/

> +
> +The event channel sub-node has the following properties:
> +
> +- compatible
> +
> +    "xen,evtchn"
> +
> +- xen,evtchn
> +
> +    The property is four numbers of tuples of
> +    (local-port-domU1,domU1-phandle,local-port-domU2,domU2-phandle) where:

This is quite difficult to read. Can we add some space before/after each 
comma?

> +
> +    local-port-domU1 is an integer value that will be used to allocte local

s/allocte/allocate/

> +    port for domU1 to send an event notification to the remote domain.

The port will be used for sending but also receiving event notification.

Also, I would suggest to replace "remote domain" with "domU2". So it is 
more explicit.

> +
> +    domU1-phandle is a single phandle to an domain to which local-port-domU1

s/an domain/a domain/ I think.

> +    will be allocated.
> +
> +    local-port-domU2 is an integer value that will be used to allocte local

s/allocte/allocate/

> +    port for domU2 to send an event notification to the remote domain.

Same as above for "remote domain".

> +
> +    domU2-phandle is a single phandle to an domain to which local-port-domU2
> +    will be allocated.
> +
> +Example:
> +
> +    chosen {
> +        ....
> +
> +        domU1: domU1 {
> +            ......
> +        };
> +
> +        domU2: domU2 {
> +            ......
> +        };
> +
> +        evtchn@1 {
> +            compatible = "xen,evtchn";
> +            xen,evtchn = <0xa &domU1 0xb &domU2>;
> +        };
> +
> +        evtchn@2 {
> +            compatible = "xen,evtchn";
> +            xen,evtchn = <0xc &domU1 0xd &domU2>;
> +        };
> +    };
> +
> +In above example two event channel comunication will be established between
> +domU1 and domU2.
> +
> +    domU1 (port 0xa) <-----------------> domU2 (port 0xb)
> +    domU1 (port 0xc) <-----------------> domU2 (port 0xd)
> +
> +domU1 and domU2 can send the signal to remote domain via hypercall
> +EVTCHNOP_send(.) on local port.

Cheers,

[1] 
https://lore.kernel.org/lkml/dbfd87e9-48fc-f641-9e24-ddb6c4f61135@arm.com/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 18:17:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 18:17:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303221.517316 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndyb0-0007jh-6V; Mon, 11 Apr 2022 18:17:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303221.517316; Mon, 11 Apr 2022 18:17:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ndyb0-0007ja-3a; Mon, 11 Apr 2022 18:17:02 +0000
Received: by outflank-mailman (input) for mailman id 303221;
 Mon, 11 Apr 2022 18:17:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ndyaz-0007jU-3B
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 18:17:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndyax-00056d-TS; Mon, 11 Apr 2022 18:16:59 +0000
Received: from [54.239.6.185] (helo=[192.168.17.122])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ndyax-00076Z-Mu; Mon, 11 Apr 2022 18:16:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+hHmId337KFi3wMWdY1+FntArzPNcwmgCzWrzNnpxuU=; b=5GD1AmPys+2Sz94K4jTm2g8hWL
	KWA6nTnqRtgDYu8sDe77S0LIWR6LBKZYNDW5LQ8FQBVQDdWVAhMLkeq2PwRED5iR3NUbGtqDxFZCM
	lOP2yEinv9k6T7L330QLjYr9nUjnqfq4jluUCUNxRrhWouZ8BEY8rbqzEUll83r9Tqy4=;
Message-ID: <0210f3c6-0f06-4ff5-9f66-8410fd540171@xen.org>
Date: Mon, 11 Apr 2022 19:16:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
To: Stefano Stabellini <sstabellini@kernel.org>,
 Rahul Singh <rahul.singh@arm.com>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 09/04/2022 02:00, Stefano Stabellini wrote:
> On Wed, 23 Mar 2022, Rahul Singh wrote:
>> in dom0less system. This patch introduce the new feature to support the
>> signaling between two domUs in dom0less system.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> ---
>>   docs/designs/dom0less-evtchn.md | 96 +++++++++++++++++++++++++++++++++
>>   1 file changed, 96 insertions(+)
>>   create mode 100644 docs/designs/dom0less-evtchn.md
>>
>> diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md
>> new file mode 100644
>> index 0000000000..6a1b7e8c22
>> --- /dev/null
>> +++ b/docs/designs/dom0less-evtchn.md
>> @@ -0,0 +1,96 @@
>> +# Signaling support between two domUs on dom0less system
>> +
>> +## Current state: Draft version
>> +
>> +## Proposer(s): Rahul Singh, Bertrand Marquis
>> +
>> +## Problem Statement:
>> +
>> +The goal of this work is to define a simple signaling system between Xen guests
>> +in dom0less systems.
>> +
>> +In dom0less system, we cannot make use of xenbus and xenstore that are used in
>> +normal systems with dynamic VMs to communicate between domains by providing a
>> +bus abstraction for paravirtualized drivers.
>> +
>> +One possible solution to implement the signaling system between domUs is based
>> +on event channels.
> 
> I suggest to reword this as follows:
> 
> ---
> Dom0less guests would benefit from a statically-defined memory sharing
> and signally system for communication. One that would be immediately
> available at boot without any need for dynamic configurations.
> 
> In embedded a great variety of guest operating system kernels exist,
> many of which don't have support for xenstore, grant table or other
> complex drivers. Some of them are small kernel-space applications (often
> called "baremetal", not to be confused with the term "baremetal" used in
> datacenter which means "without hypervisors") or RTOSes.  Additionally,
> for safety reasons, users often need to be able to configure the full
> system statically so that it can be verified statically.
> 
> Event channels are very simple and can be added even to baremetal
> applications. This proposal introduces a way to define them statically
> to make them suitable to dom0less embedded deployments.
> ---
> 
> 
>> +## Proposal:
>> +
>> +Event channels are the basic primitive provided by Xen for event notifications.
>> +An event channel is a logical connection between 2 domains (more specifically
>> +between dom1,port1 and dom2,port2). They essentially store one bit of
>> +information, the event of interest is signalled by transitioning this bit from
>> +0 to 1. An event is an equivalent of a hardware interrupt.
>> +
>> +Notifications are received by a guest via an interrupt from Xen to the guest,
>> +indicating when an event arrives (setting the bit). Further notifications are
>> +masked until the bit is cleared again. When a domain wants to wait for data it
>> +will block until an event arrives, and then send an event to signal that data
>> +has been consumed. Events are delivered asynchronously to guests and are
>> +enqueued when the guest is not running.
>> +
>> +Event channel communication will be established statically between two domU
>> +guests before unpausing the domains after domain creation. Event channel
>> +connection information between domUs will be passed to XEN via device tree
>> +node.
>> +
>> +Under the /chosen node, there needs to be sub nodes with compatible
>> +"xen,evtchn" that descibes the event channel connection between two domUs.
>> +
>> +The event channel sub-node has the following properties:
>> +
>> +- compatible
>> +
>> +    "xen,evtchn"
>> +
>> +- xen,evtchn
>> +
>> +    The property is four numbers of tuples of
>> +    (local-port-domU1,domU1-phandle,local-port-domU2,domU2-phandle) where:
>> +
>> +    local-port-domU1 is an integer value that will be used to allocte local
>> +    port for domU1 to send an event notification to the remote domain.
>> +
>> +    domU1-phandle is a single phandle to an domain to which local-port-domU1
>> +    will be allocated.
>> +
>> +    local-port-domU2 is an integer value that will be used to allocte local
>> +    port for domU2 to send an event notification to the remote domain.
>> +
>> +    domU2-phandle is a single phandle to an domain to which local-port-domU2
>> +    will be allocated.
>> +
>> +Example:
>> +
>> +    chosen {
>> +        ....
>> +
>> +        domU1: domU1 {
>> +            ......
>> +        };
>> +
>> +        domU2: domU2 {
>> +            ......
>> +        };
>> +
>> +        evtchn@1 {
>> +            compatible = "xen,evtchn";
>> +            xen,evtchn = <0xa &domU1 0xb &domU2>;
>> +        };
>> +
>> +        evtchn@2 {
>> +            compatible = "xen,evtchn";
>> +            xen,evtchn = <0xc &domU1 0xd &domU2>;
>> +        };
>> +    };
> 
> There is no need to use two evtchn nodes for this given that in device
> tree it is entirely normal to have multiple tuplets in a property. Also,
> it would be good to have a version number in the compatible string so
> that we can change version in the future.
> 
> 1)
>      chosen {
>          ....
> 
>          domU1: domU1 {
>              ......
>          };
> 
>          domU2: domU2 {
>              ......
>          };
> 
>          evtchn {
>              compatible = "xen,evtchn-v1";
>              xen,evtchn = <0xa &domU1 0xb &domU2 0xc &domU1 0xd &domU2>;
>          };
>      };
> 
> 
> I should mention that it would be also possible to use sub-nodes to
> express this information:
> 
> 2)
>          domU1: domU1 {
>              ...
>              /* one sub-node per local event channel */
>              ec1: evtchn@a {
>                  compatible = "xen,evtchn-v1";
>                  /* local-evtchn link-to-foreign-evtchn */
>                  xen,evtchn = <0xa &ec3>
>              };
>              ec2: evtchn@c {
>                  compatible = "xen,evtchn-v1";
>                  xen,evtchn = <0xc &ec4>
>              };
>          };
> 
>          domU2: domU2 {
>              ...
>              ec3: evtchn@b {
>                  compatible = "xen,evtchn-v1";
>                  xen,evtchn = <0xb &ec1>
>              };
>              ec4: evtchn@d {
>                  compatible = "xen,evtchn-v1";
>                  xen,evtchn = <0xa &ec2>
>              };
>          };
>      };

As for 1), you could combine all the ports in one node.

> 
> This format has the advantage that doesn't need a new top-level node
> type under /chosen. That is desirable few a few reasons. Today we only
> have domains (dom0 is legacy). In the future we might have nested
> domains and non-Xen domains. With System Device Tree, domains are under
> /domains instead of /chosen.
> 
> So normally I would argue to use the sub-node format because it doesn't
> need a new top-level node under /chosen. However, in this case it looks
> like the 1) format is simpler to write and also simpler to parse in Xen.

I am not sure for both. For the writing part: In one hand, it is nice to 
have all the event channels defined in one place. One the other hand, it 
is more messy if you want to visually check that you don't duplicate the 
event channels.

It may also end up to be complex to read if you have many events 
channels. So if we go with 1), I think we would want to allow multiple 
nodes to help the user to keep a clean/readable DT.

> 
> In 1), we would need to loop over xen,evtchn and for each tuplet we
> would only need to fetch the foreign domid.

You will need to loop over all the nodes in chosen to find "xen,evtchn" 
and also fetch two phandles.

> 
> In 2), we would need to check the compatible string of every
> "xen,evtchn-v1" node, and we would have to fetch from the phandle both
> the remote event channel number but also the domain-id of the parent.
> 
> So it looks like 1) is better because it is much simpler to parse. Do
> you agree?

See above, I am not sure the code to parse will end up to be much bigger 
because we would still need to loop on the nodes in chosen and fetch two 
phandles.

That said, we are potentially going to need to loop on more nodes.

So overall, I am 50/50 on which one to chose.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 20:12:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 20:12:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303229.517327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne0OL-0002Ow-Fv; Mon, 11 Apr 2022 20:12:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303229.517327; Mon, 11 Apr 2022 20:12:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne0OL-0002Op-Bp; Mon, 11 Apr 2022 20:12:05 +0000
Received: by outflank-mailman (input) for mailman id 303229;
 Mon, 11 Apr 2022 20:12:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne0OJ-0002Of-Ea; Mon, 11 Apr 2022 20:12:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne0OJ-0007Lh-DR; Mon, 11 Apr 2022 20:12:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne0OJ-00039g-2g; Mon, 11 Apr 2022 20:12:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne0OJ-0000cr-2E; Mon, 11 Apr 2022 20:12:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pyHOc68p+2RBzcT2MhHlEzATaQ40rQiKAM5NInQpeq8=; b=KteNUsZZgbDUOVapVEw6aEZSPx
	pO/X4y1SpRucKXzhK2ApLismKz+DDFj3jl7OlPZDwBXOuVu7bAJ9ieF9APoCeM65Rg9aKbN91QxX8
	GKLWixjCEwz138ZhElZiWm/IfgPWI96VJS6x9LaQMwdSpILcUEiM0Zue+lKQ9VwJeweI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169312-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169312: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 20:12:03 +0000

flight 169312 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169312/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  329 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 21:14:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 21:14:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303239.517338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne1Mv-00009l-BJ; Mon, 11 Apr 2022 21:14:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303239.517338; Mon, 11 Apr 2022 21:14:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne1Mv-00009c-8A; Mon, 11 Apr 2022 21:14:41 +0000
Received: by outflank-mailman (input) for mailman id 303239;
 Mon, 11 Apr 2022 21:14:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne1Mt-00009S-RX; Mon, 11 Apr 2022 21:14:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne1Mt-0000G3-NY; Mon, 11 Apr 2022 21:14:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne1Mt-0004jG-7U; Mon, 11 Apr 2022 21:14:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne1Mt-00021C-72; Mon, 11 Apr 2022 21:14:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9pCNhndY/u+wEyQ1YMIhAfYlwP1f10keTZhBpyPfiJ0=; b=mMk+oTcDgC8Pj36ZkpYR8MnDw0
	9sH0Hb5Zs0DtQkvRTWyyPjtdoDhp2VMcHYxdZg52j+MMRgfUjYgI0eZ1cyqXeZ1aE9069UCatyPIV
	8qGdHXDrahWUbUidUa/dZX96RFrZK5RW7ZfIvTIEk6FIi9e53/w9Zq98GPw6+EyGXflk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169313-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169313: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 21:14:39 +0000

flight 169313 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169313/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  330 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 21:58:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 21:58:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303254.517376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne22v-0004mO-TX; Mon, 11 Apr 2022 21:58:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303254.517376; Mon, 11 Apr 2022 21:58:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne22v-0004mH-QZ; Mon, 11 Apr 2022 21:58:05 +0000
Received: by outflank-mailman (input) for mailman id 303254;
 Mon, 11 Apr 2022 21:58:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne22u-0004lr-Hs; Mon, 11 Apr 2022 21:58:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne22u-00014w-FN; Mon, 11 Apr 2022 21:58:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne22t-0005m3-Tl; Mon, 11 Apr 2022 21:58:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne22t-0006S7-TJ; Mon, 11 Apr 2022 21:58:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JK8GjPTqJ2sigqUvKAHMuR3M/HGRRHA8PBHtsiYg5eA=; b=dHl4iQhmtgPRNT2xW2dEKVVPlQ
	Mb5QHODxN3TjjpduiL892Ir53IwvzsHi1qfJncHf7f44sOaEdF/TQ4/rgBP3jU4FwXoybvQKbMcig
	VtG37VN3TZG3aAS9Kj03MJ1WSlasZdHJ4XWB96j6des2zwxdM0K5XVxuQNvBQA3hSLiI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169309-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169309: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f44201124e8713f6eff80f349351b5740001c6fc
X-Osstest-Versions-That:
    xen=8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 21:58:03 +0000

flight 169309 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169309/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169292

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169292
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169292
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169292
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169292
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169292
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169292
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169292
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169292
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169292
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169292
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169292
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169292
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  f44201124e8713f6eff80f349351b5740001c6fc
baseline version:
 xen                  8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf

Last test of basis   169292  2022-04-11 01:51:53 Z    0 days
Testing same since   169309  2022-04-11 14:07:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8847ec08fd..f44201124e  f44201124e8713f6eff80f349351b5740001c6fc -> master


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 22:29:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 22:29:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303263.517387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne2XN-00086n-9S; Mon, 11 Apr 2022 22:29:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303263.517387; Mon, 11 Apr 2022 22:29:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne2XN-00086g-6W; Mon, 11 Apr 2022 22:29:33 +0000
Received: by outflank-mailman (input) for mailman id 303263;
 Mon, 11 Apr 2022 22:29:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne2XL-00086W-Io; Mon, 11 Apr 2022 22:29:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne2XL-0001hV-Fi; Mon, 11 Apr 2022 22:29:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne2XK-0006Wj-W7; Mon, 11 Apr 2022 22:29:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne2XK-0005zV-Vg; Mon, 11 Apr 2022 22:29:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=o8Ia/WH/ctbCzFConxxiXtdUh9KwupFMFXWQqerRWzk=; b=RTMbd1DuW4s/DAMLfVN/gQy2br
	lNvPiNKoJ+zHaaOSzWx/eYxx32m/dlNsHGMT619NxzQ+v8vPfdV2HkLuAcEaJ5E/d25PomSim0ste
	FikIB9Ga5vfrzkkeeN4+l1WFNWBGYBCt5AI7ESmmUPnhJaboGKbadrSYXObVQ5rfyI0U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169314-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169314: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 22:29:30 +0000

flight 169314 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169314/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  331 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 11 23:44:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Apr 2022 23:44:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303323.517398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne3hj-0007ta-9R; Mon, 11 Apr 2022 23:44:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303323.517398; Mon, 11 Apr 2022 23:44:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne3hj-0007tT-6O; Mon, 11 Apr 2022 23:44:19 +0000
Received: by outflank-mailman (input) for mailman id 303323;
 Mon, 11 Apr 2022 23:44:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne3hi-0007tJ-BG; Mon, 11 Apr 2022 23:44:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne3hi-00034m-7s; Mon, 11 Apr 2022 23:44:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne3hh-0008ED-Vv; Mon, 11 Apr 2022 23:44:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne3hh-00075r-VT; Mon, 11 Apr 2022 23:44:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TKQAGdxQjUc6iXoIRRdoRvvwvpnP8/qeXBt1TsLh/3Y=; b=Q7RCzxP6rflGwVY34I+pEbT+Bm
	X8inB1LhBImV/Qi2d89iH7uVfVWjZ2cBaGlZZWbRqHkhHdpKUlR3H6MWSuhZ8r7ax1lt42c3RecXN
	oF2KOmPuFAhLzFZgfxpgesLexIY1paC919hkCOOm4+P4+/Kw8J3BG7wl7ILYEavrZwX0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169315-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169315: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Apr 2022 23:44:17 +0000

flight 169315 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169315/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  332 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 00:42:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 00:42:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303332.517410 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne4bc-00063f-Hm; Tue, 12 Apr 2022 00:42:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303332.517410; Tue, 12 Apr 2022 00:42:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne4bc-00063Y-EU; Tue, 12 Apr 2022 00:42:04 +0000
Received: by outflank-mailman (input) for mailman id 303332;
 Tue, 12 Apr 2022 00:42:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne4bb-00063O-F1; Tue, 12 Apr 2022 00:42:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne4bb-0004j9-BY; Tue, 12 Apr 2022 00:42:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne4bb-00018J-48; Tue, 12 Apr 2022 00:42:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne4bb-0005TA-3g; Tue, 12 Apr 2022 00:42:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XCX+oV93pdYHX5pj5eINFE4Za2asMRQUnOUzd0xa7z0=; b=fhQrZdQYR4oB/lREptD3iJCO12
	1HbpWvHrGVutdq07ZcehqdoyE9clUZ3ML9elQmVXSzZsH7UbX58sMByfNCodasUaXbrWkUvLJIzTM
	qJrko6fyIYZma7vLkrsVL2f+IIJ3ebBKPUDYVCNcyrvNPqN2u6qIBP6c5vOICP0n3PdQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169316-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169316: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 00:42:03 +0000

flight 169316 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169316/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   41 days  333 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 01:58:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 01:58:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303341.517424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne5nI-000323-8P; Tue, 12 Apr 2022 01:58:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303341.517424; Tue, 12 Apr 2022 01:58:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne5nI-00031w-4f; Tue, 12 Apr 2022 01:58:12 +0000
Received: by outflank-mailman (input) for mailman id 303341;
 Tue, 12 Apr 2022 01:58:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne5nH-00031m-9F; Tue, 12 Apr 2022 01:58:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne5nH-00044r-6t; Tue, 12 Apr 2022 01:58:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne5nG-0002x5-PX; Tue, 12 Apr 2022 01:58:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne5nG-0008Vs-P5; Tue, 12 Apr 2022 01:58:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3+2WW3lTGqAkdRxWvZNLAXGq4AAV+MbV5bk01VpWS8g=; b=vak4wAGuG/6gVk0rSB9VfJvuWT
	Ik5fRYFHQmvHS99W3BEEp8tCiQ6xMFnTng9F9o4VXwz8bJE6kzEhojDq2whoogd7v+gPFtbqouJGT
	iOYAcQy35jRb4BR05kRlQVGHO/gzjOQkqq7usYwKis2UkNPGdM/0AGKlgzRCOieFDwDY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169317-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169317: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 01:58:10 +0000

flight 169317 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169317/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  334 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 03:20:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 03:20:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303350.517436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne74u-0003ae-7g; Tue, 12 Apr 2022 03:20:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303350.517436; Tue, 12 Apr 2022 03:20:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne74u-0003aX-4X; Tue, 12 Apr 2022 03:20:28 +0000
Received: by outflank-mailman (input) for mailman id 303350;
 Tue, 12 Apr 2022 03:20:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne74s-0003aN-Eq; Tue, 12 Apr 2022 03:20:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne74s-000679-CB; Tue, 12 Apr 2022 03:20:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne74s-0007Sg-15; Tue, 12 Apr 2022 03:20:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne74r-0008Fq-Uq; Tue, 12 Apr 2022 03:20:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/VuNYCKm/nG8/cHph3TkPOMDP/13Gr5XtUh7xXHe+CQ=; b=yESZCVlV9WuzaNcuCEqNqJ50Qj
	K/kHyBn/oCV3udkwC8LWWkHI2lgRJ1ntZ/oJ2UnAf5HgS6DySlZljrV5odDaHMwYx9hT5oMBD8qO1
	5IdvVMr1cwR4Wp8XCzrwy/2Ff6NstAzJWQd7F64ROQUu9y8jBlLcnrMV9M3XWDpYFWZw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169319-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169319: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 03:20:25 +0000

flight 169319 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169319/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  335 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:08:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:08:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303360.517447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8lh-0005VK-9S; Tue, 12 Apr 2022 05:08:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303360.517447; Tue, 12 Apr 2022 05:08:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8lh-0005VD-6A; Tue, 12 Apr 2022 05:08:45 +0000
Received: by outflank-mailman (input) for mailman id 303360;
 Tue, 12 Apr 2022 05:08:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne8lg-0005V3-34; Tue, 12 Apr 2022 05:08:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne8lg-0000Al-1C; Tue, 12 Apr 2022 05:08:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ne8lf-0004ha-LM; Tue, 12 Apr 2022 05:08:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ne8lf-0002AV-Kt; Tue, 12 Apr 2022 05:08:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=w2uTuOWyFfPckzmRUZgBUCNEUaYRGkRjzoej3lxHQbk=; b=bYFYSbwXuguHIdMgGjslvjzR+M
	Zcad7qACUTnAhw+64+jF+W27XeSkpvIfS5/QnxwhsRgMH+xFptZINz5bFi7tBUACybvItip4Pi9hq
	Kh5/GkeyB8X1DjryCZRGQ2KPOpRDbt/6kOZAV2tJ/5OWmgT/iE4Iq/UTeuFURoDMGZyc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169321-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169321: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 05:08:43 +0000

flight 169321 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169321/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  336 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:11:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:11:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303285.517467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8om-00070H-FH; Tue, 12 Apr 2022 05:11:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303285.517467; Tue, 12 Apr 2022 05:11:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8om-0006z7-8S; Tue, 12 Apr 2022 05:11:56 +0000
Received: by outflank-mailman (input) for mailman id 303285;
 Mon, 11 Apr 2022 23:39:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3ce-0006oE-SS
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:04 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92301096-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:03 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id C52711F42D8A
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92301096-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720343;
	bh=vZl2ZWhj3ebII6Fu4HXosJY7ElBNxPQBVC6ByCiZ1BY=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=JviWvIvL43QfXlelzChv/e65G8pQVStHm/cjt8S+palR7BBcwJ28HEV3zpH6iZZTv
	 TAwdfm98zB2JhkW2hCsPJU++kmtM1VV3c4q/FAbp1kMxQV66wX4eOP2dzPpxKzrKBh
	 r/GZxCh68qnq8qhz28d+ivGoVY9SXlXFmaOMiSdDnfRi1xFRVYkWEqZNi0hbs2vHRd
	 Dcs5ywFB53D3180fJ8zfDiYmWEkxlPJhV6Jj84tKq7D3RzpHX7l0fPdorLAO9CU7xa
	 bri2qC1nbypivw49u7/3CmwoCU41LCltEdGxoZKNd3lvbfE0eFlmxhLRCcCz+OsT9r
	 V/pa36+mViA/w==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 02/20] notifier: Add atomic/blocking_notifier_chain_register_unique_prio()
Date: Tue, 12 Apr 2022 02:38:14 +0300
Message-Id: <20220411233832.391817-3-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add variant of atomic/blocking_notifier_chain_register() functions that
doesn't allow to register notifier using a duplicated priority. The -EBUSY
error code is returned in this case by the new API functions.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 include/linux/notifier.h |  5 +++
 kernel/notifier.c        | 88 +++++++++++++++++++++++++++++++---------
 2 files changed, 74 insertions(+), 19 deletions(-)

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index d4717bc0ab85..ccce26197dd2 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -150,6 +150,11 @@ extern int raw_notifier_chain_register(struct raw_notifier_head *nh,
 extern int srcu_notifier_chain_register(struct srcu_notifier_head *nh,
 		struct notifier_block *nb);
 
+extern int atomic_notifier_chain_register_unique_prio(
+		struct atomic_notifier_head *nh, struct notifier_block *nb);
+extern int blocking_notifier_chain_register_unique_prio(
+		struct blocking_notifier_head *nh, struct notifier_block *nb);
+
 extern int atomic_notifier_chain_unregister(struct atomic_notifier_head *nh,
 		struct notifier_block *nb);
 extern int blocking_notifier_chain_unregister(struct blocking_notifier_head *nh,
diff --git a/kernel/notifier.c b/kernel/notifier.c
index 4ed6bda8f127..4fc32b1e6cbb 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -20,7 +20,8 @@ BLOCKING_NOTIFIER_HEAD(reboot_notifier_list);
  */
 
 static int notifier_chain_register(struct notifier_block **nl,
-				   struct notifier_block *n)
+				   struct notifier_block *n,
+				   bool unique_priority)
 {
 	while ((*nl) != NULL) {
 		if (unlikely((*nl) == n)) {
@@ -30,6 +31,8 @@ static int notifier_chain_register(struct notifier_block **nl,
 		}
 		if (n->priority > (*nl)->priority)
 			break;
+		if (n->priority == (*nl)->priority && unique_priority)
+			return -EBUSY;
 		nl = &((*nl)->next);
 	}
 	n->next = *nl;
@@ -144,12 +147,35 @@ int atomic_notifier_chain_register(struct atomic_notifier_head *nh,
 	int ret;
 
 	spin_lock_irqsave(&nh->lock, flags);
-	ret = notifier_chain_register(&nh->head, n);
+	ret = notifier_chain_register(&nh->head, n, false);
 	spin_unlock_irqrestore(&nh->lock, flags);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(atomic_notifier_chain_register);
 
+/**
+ *	atomic_notifier_chain_register_unique_prio - Add notifier to an atomic notifier chain
+ *	@nh: Pointer to head of the atomic notifier chain
+ *	@n: New entry in notifier chain
+ *
+ *	Adds a notifier to an atomic notifier chain if there is no other
+ *	notifier registered using the same priority.
+ *
+ *	Returns 0 on success, %-EEXIST or %-EBUSY on error.
+ */
+int atomic_notifier_chain_register_unique_prio(struct atomic_notifier_head *nh,
+					       struct notifier_block *n)
+{
+	unsigned long flags;
+	int ret;
+
+	spin_lock_irqsave(&nh->lock, flags);
+	ret = notifier_chain_register(&nh->head, n, true);
+	spin_unlock_irqrestore(&nh->lock, flags);
+	return ret;
+}
+EXPORT_SYMBOL_GPL(atomic_notifier_chain_register_unique_prio);
+
 /**
  *	atomic_notifier_chain_unregister - Remove notifier from an atomic notifier chain
  *	@nh: Pointer to head of the atomic notifier chain
@@ -209,18 +235,9 @@ NOKPROBE_SYMBOL(atomic_notifier_call_chain);
  *	synchronized by an rwsem.
  */
 
-/**
- *	blocking_notifier_chain_register - Add notifier to a blocking notifier chain
- *	@nh: Pointer to head of the blocking notifier chain
- *	@n: New entry in notifier chain
- *
- *	Adds a notifier to a blocking notifier chain.
- *	Must be called in process context.
- *
- *	Returns 0 on success, %-EEXIST on error.
- */
-int blocking_notifier_chain_register(struct blocking_notifier_head *nh,
-		struct notifier_block *n)
+static int __blocking_notifier_chain_register(struct blocking_notifier_head *nh,
+					      struct notifier_block *n,
+					      bool unique_priority)
 {
 	int ret;
 
@@ -230,15 +247,48 @@ int blocking_notifier_chain_register(struct blocking_notifier_head *nh,
 	 * such times we must not call down_write().
 	 */
 	if (unlikely(system_state == SYSTEM_BOOTING))
-		return notifier_chain_register(&nh->head, n);
+		return notifier_chain_register(&nh->head, n, unique_priority);
 
 	down_write(&nh->rwsem);
-	ret = notifier_chain_register(&nh->head, n);
+	ret = notifier_chain_register(&nh->head, n, unique_priority);
 	up_write(&nh->rwsem);
 	return ret;
 }
+
+/**
+ *	blocking_notifier_chain_register - Add notifier to a blocking notifier chain
+ *	@nh: Pointer to head of the blocking notifier chain
+ *	@n: New entry in notifier chain
+ *
+ *	Adds a notifier to a blocking notifier chain.
+ *	Must be called in process context.
+ *
+ *	Returns 0 on success, %-EEXIST on error.
+ */
+int blocking_notifier_chain_register(struct blocking_notifier_head *nh,
+		struct notifier_block *n)
+{
+	return __blocking_notifier_chain_register(nh, n, false);
+}
 EXPORT_SYMBOL_GPL(blocking_notifier_chain_register);
 
+/**
+ *	blocking_notifier_chain_register_unique_prio - Add notifier to a blocking notifier chain
+ *	@nh: Pointer to head of the blocking notifier chain
+ *	@n: New entry in notifier chain
+ *
+ *	Adds a notifier to an blocking notifier chain if there is no other
+ *	notifier registered using the same priority.
+ *
+ *	Returns 0 on success, %-EEXIST or %-EBUSY on error.
+ */
+int blocking_notifier_chain_register_unique_prio(struct blocking_notifier_head *nh,
+						 struct notifier_block *n)
+{
+	return __blocking_notifier_chain_register(nh, n, true);
+}
+EXPORT_SYMBOL_GPL(blocking_notifier_chain_register_unique_prio);
+
 /**
  *	blocking_notifier_chain_unregister - Remove notifier from a blocking notifier chain
  *	@nh: Pointer to head of the blocking notifier chain
@@ -354,7 +404,7 @@ bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh)
 int raw_notifier_chain_register(struct raw_notifier_head *nh,
 		struct notifier_block *n)
 {
-	return notifier_chain_register(&nh->head, n);
+	return notifier_chain_register(&nh->head, n, false);
 }
 EXPORT_SYMBOL_GPL(raw_notifier_chain_register);
 
@@ -433,10 +483,10 @@ int srcu_notifier_chain_register(struct srcu_notifier_head *nh,
 	 * such times we must not call mutex_lock().
 	 */
 	if (unlikely(system_state == SYSTEM_BOOTING))
-		return notifier_chain_register(&nh->head, n);
+		return notifier_chain_register(&nh->head, n, false);
 
 	mutex_lock(&nh->mutex);
-	ret = notifier_chain_register(&nh->head, n);
+	ret = notifier_chain_register(&nh->head, n, false);
 	mutex_unlock(&nh->mutex);
 	return ret;
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:11:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:11:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303282.517464 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8om-0006wL-7b; Tue, 12 Apr 2022 05:11:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303282.517464; Tue, 12 Apr 2022 05:11:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8ol-0006v0-Un; Tue, 12 Apr 2022 05:11:55 +0000
Received: by outflank-mailman (input) for mailman id 303282;
 Mon, 11 Apr 2022 23:39:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3ca-0006oE-RE
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:00 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8fca62c7-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:00 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id ADD321F42D86
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8fca62c7-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720339;
	bh=kCYEDdovCVMqMqsKDmHApZZjAvEttkamvjOxDRb8Y/s=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=nx08HokVCqLuQkUWX3rv2fv4uikfMucJnDiwNH7NGzpcW8362/JzsFA+T8pnB9rNP
	 Nh2tUIEYoUm4h2VGRFzMQLXuy7mgTy+c0khut3jaDscDSqMMvUMEsukDJLG8tD4MDL
	 vj4ggPnYxoa3v867GyElYDQzvBgZSBXa3mIdsCHhXm+tguMql+U+E5xj8wPXMcK7A6
	 0uh9uoi/rCbMu8A/I2IZxr0lSB4su90p49BTCC/554FnGngEacX7JTRv7MVDZF7lqU
	 cVn2/2/romM/vCOmLU+jii/LndRccn1z1q7pRnyFpKcq7XTRFlJuAGp/K99F3f919c
	 C0mZWcTbiCkjQ==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 01/20] notifier: Add blocking_notifier_call_chain_is_empty()
Date: Tue, 12 Apr 2022 02:38:13 +0300
Message-Id: <20220411233832.391817-2-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add blocking_notifier_call_chain_is_empty() that returns true if call
chain is empty.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 include/linux/notifier.h |  2 ++
 kernel/notifier.c        | 13 +++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index 87069b8459af..d4717bc0ab85 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -173,6 +173,8 @@ extern int blocking_notifier_call_chain_robust(struct blocking_notifier_head *nh
 extern int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
 		unsigned long val_up, unsigned long val_down, void *v);
 
+extern bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh);
+
 #define NOTIFY_DONE		0x0000		/* Don't care */
 #define NOTIFY_OK		0x0001		/* Suits me */
 #define NOTIFY_STOP_MASK	0x8000		/* Don't call further */
diff --git a/kernel/notifier.c b/kernel/notifier.c
index ba005ebf4730..4ed6bda8f127 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -323,6 +323,19 @@ int blocking_notifier_call_chain(struct blocking_notifier_head *nh,
 }
 EXPORT_SYMBOL_GPL(blocking_notifier_call_chain);
 
+/**
+ *	blocking_notifier_call_chain_is_empty - Check whether notifier chain is empty
+ *	@nh: Pointer to head of the blocking notifier chain
+ *
+ *	Checks whether notifier chain is empty.
+ *
+ *	Returns true is notifier chain is empty, false otherwise.
+ */
+bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh)
+{
+	return !rcu_access_pointer(nh->head);
+}
+
 /*
  *	Raw notifier chain routines.  There is no protection;
  *	the caller must provide it.  Use at your own risk!
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:11:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:11:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303281.517458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8ol-0006uQ-S9; Tue, 12 Apr 2022 05:11:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303281.517458; Tue, 12 Apr 2022 05:11:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8ol-0006uJ-Mu; Tue, 12 Apr 2022 05:11:55 +0000
Received: by outflank-mailman (input) for mailman id 303281;
 Mon, 11 Apr 2022 23:39:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3cZ-0006oE-Ro
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:00 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk
 [2a00:1098:0:82:1000:25:2eeb:e3e3])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8d8ea0fb-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:38:57 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 503051F4028B
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d8ea0fb-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720335;
	bh=FlE6aXeklkCK/AI2WoLzbfUrvXlLcjuPO9lE+MlTmGY=;
	h=From:To:Cc:Subject:Date:From;
	b=j+6DZIwJdleyULy9bYi7IIrtEan9CdcwksRYcm5h8cT0CGnytw+oY1GsbHra8+mo7
	 WAj0RfHgJkhRuYgUcWavGMh9E1Hhu+tKsgei/htxQ+qjIqGrCN6t2+bWVHjWjj1Qpq
	 7b+zsXRmKixDrhr9fCidfruuyuPRyVyxJhbdKz2yHpOMugsFgMbuhM965aXmnaRDE+
	 LTiAdSCP8Lzw70g2GfuLwtuRh9M1mRUkgyo7Hnx1qgsL3EUKjP743t0hBs1pOf8lsU
	 zcikwcJL0GUjlp2ni/qBTGHc6jdc3APJ62532Pu4lcn3EW1rST4jSFE9stwZof/GVv
	 U1VMzfHvk+aag==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 00/20] Introduce power-off+restart call chain API
Date: Tue, 12 Apr 2022 02:38:12 +0300
Message-Id: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Problem
-------

SoC devices require power-off call chaining functionality from kernel.
We have a widely used restart chaining provided by restart notifier API,
but nothing for power-off.

Solution
--------

Introduce new API that provides both restart and power-off call chains.

Why combine restart with power-off? Because drivers often do both.
More practical to have API that provides both under the same roof.

The new API is designed with simplicity and extensibility in mind.
It's built upon the existing restart and reboot APIs. The simplicity
is in new helper functions that are convenient for drivers. The
extensibility is in the design that doesn't hardcode callback
arguments, making easy to add new parameters and remove old.

This is a third attempt to introduce the new API. First was made by
Guenter Roeck back in 2014, second was made by Thierry Reding in 2017.
In fact the work didn't stop and recently arm_pm_restart() was removed
from v5.14 kernel, which was a part of preparatory work started by
Guenter Roeck. I took into account experience and ideas from the
previous attempts, extended and polished them.

Adoption plan
-------------

This patchset introduces the new API. It also converts multiple drivers
and arch code to the new API to demonstrate how it all looks in practice.

The plan is:

1. Merge the new API and convert arch code to use do_kernel_power_off().
   For now the new API will co-exist with the older API.

2. Convert all drivers and platform code to the new API.

3. Remove obsoleted pm_power_off and pm_power_off_prepare variables.

4. Make restart-notifier API private to kernel/reboot.c once no users left.

5. Make unique-priority of the handlers' a mandatory requirement in the
   new API.

The plan is fully implemented here:

[1] https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commits/sys-off-handler

For now I'm sending the first 20 base patches out of ~180.
Majority of drivers and platform patches depend on the base patches,
hence the rest will come later on, once base will land.

All [1] patches are compile-tested. Tegra, Rockchip and x86 ACPI patches
are tested on hardware.

Results
-------

1. Devices can be powered off properly.

2. Global variables are removed from drivers.

3. Global pm_power_off and pm_power_off_prepare callback variables are
removed once all users are converted to the new API. The latter callback
is removed by patch #25 of this series.

4. Ambiguous call chain ordering is prohibited. See patch #4 which adds
verification of restart handlers priorities, ensuring that they are unique.

Changelog:

v7: - Rebased on a recent linux-next. Dropped the recently removed
      NDS32 architecture. Only SH and x86 arches left un-acked.

    - Added acks from Thomas Bogendoerfer and Krzysztof Kozlowski
      to the MIPS and memory/emif patches respectively.

    - Made couple minor cosmetic improvements to the new API.

    - A month ago I joined Collabora and continuing to work on this series
      on the company's time, so changed my email address to collabora.com

v6: - Rebased on a recent linux-next.

    - Made minor couple cosmetic changes.

v5: - Dropped patches which cleaned up notifier/reboot headers, as was
      requested by Rafael Wysocki.

    - Dropped WARN_ON() from the code, as was requested by Rafael Wysocki.
      Replaced it with pr_err() appropriately.

    - Dropped *_notifier_has_unique_priority() functions and added
      *_notifier_chain_register_unique_prio() instead, as was suggested
      by Michał Mirosław and Rafael Wysocki.

    - Dropped export of blocking_notifier_call_chain_is_empty() symbol,
      as was suggested by Rafael Wysocki.

    - Michał Mirosław suggested that will be better to split up patch
      that adds the new API to ease reviewing, but Rafael Wysocki asked
      not add more patches, so I kept it as a single patch.

    - Added temporary "weak" stub for pm_power_off() which fixes linkage
      failure once symbol is removed from arch/* code. Previously I missed
      this problem because was only compile-testing object files.

v4: - Made a very minor improvement to doc comments, clarifying couple
      default values.

    - Corrected list of emails recipient by adding Linus, Sebastian,
      Philipp and more NDS people. Removed bouncing emails.

    - Added acks that were given to v3.

v3: - Renamed power_handler to sys_off_handler as was suggested by
      Rafael Wysocki.

    - Improved doc-comments as was suggested by Rafael Wysocki. Added more
      doc-comments.

    - Implemented full set of 180 patches which convert whole kernel in
      accordance to the plan, see link [1] above. Slightly adjusted API to
      better suit for the remaining converted drivers.

      * Added unregister_sys_off_handler() that is handy for a couple old
        platform drivers.

      * Dropped devm_register_trivial_restart_handler(), 'simple' variant
        is enough to have.

    - Improved "Add atomic/blocking_notifier_has_unique_priority()" patch,
      as was suggested by Andy Shevchenko. Also replaced down_write() with
      down_read() and factored out common notifier_has_unique_priority().

    - Added stop_chain field to struct restart_data and reboot_prep_data
      after discovering couple drivers wanting that feature.

    - Added acks that were given to v2.

v2: - Replaced standalone power-off call chain demo-API with the combined
      power-off+restart API because this is what drivers want. It's a more
      comprehensive solution.

    - Converted multiple drivers and arch code to the new API. Suggested by
      Andy Shevchenko. I skimmed through the rest of drivers, verifying that
      new API suits them. The rest of the drivers will be converted once we
      will settle on the new API, otherwise will be too many patches here.

    - v2 API doesn't expose notifier to users and require handlers to
      have unique priority. Suggested by Guenter Roeck.

    - v2 API has power-off chaining disabled by default and require
      drivers to explicitly opt-in to the chaining. This preserves old
      behaviour for existing drivers once they are converted to the new
      API.

Dmitry Osipenko (20):
  notifier: Add blocking_notifier_call_chain_is_empty()
  notifier: Add atomic/blocking_notifier_chain_register_unique_prio()
  reboot: Print error message if restart handler has duplicated priority
  kernel: Add combined power-off+restart handler call chain API
  ARM: Use do_kernel_power_off()
  csky: Use do_kernel_power_off()
  riscv: Use do_kernel_power_off()
  arm64: Use do_kernel_power_off()
  parisc: Use do_kernel_power_off()
  xen/x86: Use do_kernel_power_off()
  powerpc: Use do_kernel_power_off()
  m68k: Switch to new sys-off handler API
  sh: Use do_kernel_power_off()
  x86: Use do_kernel_power_off()
  ia64: Use do_kernel_power_off()
  mips: Use do_kernel_power_off()
  memory: emif: Use kernel_can_power_off()
  ACPI: power: Switch to sys-off handler API
  regulator: pfuze100: Use devm_register_sys_off_handler()
  reboot: Remove pm_power_off_prepare()

 arch/arm/kernel/reboot.c               |   4 +-
 arch/arm64/kernel/process.c            |   3 +-
 arch/csky/kernel/power.c               |   6 +-
 arch/ia64/kernel/process.c             |   4 +-
 arch/m68k/emu/natfeat.c                |   3 +-
 arch/m68k/include/asm/machdep.h        |   1 -
 arch/m68k/kernel/process.c             |   5 +-
 arch/m68k/kernel/setup_mm.c            |   1 -
 arch/m68k/kernel/setup_no.c            |   1 -
 arch/m68k/mac/config.c                 |   4 +-
 arch/mips/kernel/reset.c               |   3 +-
 arch/parisc/kernel/process.c           |   4 +-
 arch/powerpc/kernel/setup-common.c     |   4 +-
 arch/powerpc/xmon/xmon.c               |   3 +-
 arch/riscv/kernel/reset.c              |  12 +-
 arch/sh/kernel/reboot.c                |   3 +-
 arch/x86/kernel/reboot.c               |   4 +-
 arch/x86/xen/enlighten_pv.c            |   4 +-
 drivers/acpi/sleep.c                   |  25 +-
 drivers/memory/emif.c                  |   2 +-
 drivers/regulator/pfuze100-regulator.c |  38 +-
 include/linux/notifier.h               |   7 +
 include/linux/pm.h                     |   1 -
 include/linux/reboot.h                 | 229 ++++++++-
 kernel/notifier.c                      | 101 +++-
 kernel/power/hibernate.c               |   2 +-
 kernel/reboot.c                        | 622 ++++++++++++++++++++++++-
 27 files changed, 980 insertions(+), 116 deletions(-)

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:11:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:11:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303287.517475 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8om-000798-UL; Tue, 12 Apr 2022 05:11:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303287.517475; Tue, 12 Apr 2022 05:11:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8om-00075h-KF; Tue, 12 Apr 2022 05:11:56 +0000
Received: by outflank-mailman (input) for mailman id 303287;
 Mon, 11 Apr 2022 23:39:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3ci-0006oE-Jx
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:08 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 94958423-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:08 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id C95061F42D8E
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94958423-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720347;
	bh=rE0gdUKO6u30HOCK7SRHP3k8mtmvbpif5A95yZ2p3PY=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=SJSmU6oKbkFC6qk9sybOhccgA1atA5HyHj9VJAk88lQAsecmxdmA17ulTzp9683gp
	 3vvsylERM3jM7PfChQeyikquTNyomgu9L0dM6z5jWDLf7AkJde6s6TIy7519BeSnHm
	 vWXb0a9E/FmK1dCJ+iVzrWJQVpDkGXV6OZj6kwjzy0WpVHQGVPdlJ0erRQKcEEVLzZ
	 NMX8OnKdNZXojrijEe5Kotjsc4Lw48okU7YRg9wdcDqBKaKTiihn+rofo2Thu68Mgf
	 h+j91GOmW1cnm2aInltn36l/ppfnQj/Gy1giIPmB2j1gIxRgkUPlkMmqWU4NySu1Bf
	 8/zXD+vGFWRdQ==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 03/20] reboot: Print error message if restart handler has duplicated priority
Date: Tue, 12 Apr 2022 02:38:15 +0300
Message-Id: <20220411233832.391817-4-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add sanity check which ensures that there are no two restart handlers
registered using the same priority. This requirement will become mandatory
once all drivers will be converted to the new API and such errors will be
fixed.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 kernel/reboot.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/kernel/reboot.c b/kernel/reboot.c
index ed4e6dfb7d44..acdae4e95061 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -182,6 +182,21 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
  */
 int register_restart_handler(struct notifier_block *nb)
 {
+	int ret;
+
+	ret = atomic_notifier_chain_register_unique_prio(&restart_handler_list, nb);
+	if (ret != -EBUSY)
+		return ret;
+
+	/*
+	 * Handler must have unique priority. Otherwise call order is
+	 * determined by registration order, which is unreliable.
+	 *
+	 * This requirement will become mandatory once all drivers
+	 * will be converted to use new sys-off API.
+	 */
+	pr_err("failed to register restart handler using unique priority\n");
+
 	return atomic_notifier_chain_register(&restart_handler_list, nb);
 }
 EXPORT_SYMBOL(register_restart_handler);
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:11:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:11:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303289.517485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8on-0007JM-KR; Tue, 12 Apr 2022 05:11:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303289.517485; Tue, 12 Apr 2022 05:11:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8on-0007GW-5H; Tue, 12 Apr 2022 05:11:57 +0000
Received: by outflank-mailman (input) for mailman id 303289;
 Mon, 11 Apr 2022 23:39:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3cn-0006oE-V8
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:14 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 970a7ead-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:12 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id D20BC1F42D93
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 970a7ead-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720351;
	bh=cEm24PbdQ0IIbbsko1wFl+5ehCte8gJZp+snaKAZD7o=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=Gf0edlvPzfoI74sGnmeo+bvPBSv3XkKD6tYCtX8NVtOhgwI+kinGS3mYoEDPAmTym
	 sDzB0lK7BCqoNcjMu/YNkJHCYmniCa/loFWKPN8SyVdKqH00yfb2eTakWk8s7Nq8A+
	 erb7FoO2DG3I0oGznM7OOySA2qqydBYLCEuC2A0Lr/yyObBlaKKDH7rtasxhG/XajD
	 dsazA/gSTho54ApErwyRNa25fS7WgsSzGf9jVeIVlHwIrvtRKEaJ2+cC6R+h7OyqRV
	 z33tb7/CmJPI8L+sZXtzoV2y09o6uLhRHqrC/SQcStPr2lxuBIoXvUt3f+pvi7FIqF
	 3FuitayDfmAMw==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API
Date: Tue, 12 Apr 2022 02:38:16 +0300
Message-Id: <20220411233832.391817-5-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

SoC platforms often have multiple ways of how to perform system's
power-off and restart operations. Meanwhile today's kernel is limited to
a single option. Add combined power-off+restart handler call chain API,
which is inspired by the restart API. The new API provides both power-off
and restart functionality.

The old pm_power_off method will be kept around till all users are
converted to the new API.

Current restart API will be replaced by the new unified API since
new API is its superset. The restart functionality of the sys-off handler
API is built upon the existing restart-notifier APIs.

In order to ease conversion to the new API, convenient helpers are added
for the common use-cases. They will reduce amount of boilerplate code and
remove global variables. These helpers preserve old behaviour for cases
where only one power-off handler is expected, this is what all existing
drivers want, and thus, they could be easily converted to the new API.
Users of the new API should explicitly enable power-off chaining by
setting corresponding flag of the power_handler structure.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 include/linux/reboot.h   | 229 ++++++++++++++-
 kernel/power/hibernate.c |   2 +-
 kernel/reboot.c          | 604 ++++++++++++++++++++++++++++++++++++++-
 3 files changed, 827 insertions(+), 8 deletions(-)

diff --git a/include/linux/reboot.h b/include/linux/reboot.h
index a2429648d831..ba5e5dddcfcd 100644
--- a/include/linux/reboot.h
+++ b/include/linux/reboot.h
@@ -8,10 +8,35 @@
 
 struct device;
 
-#define SYS_DOWN	0x0001	/* Notify of system down */
-#define SYS_RESTART	SYS_DOWN
-#define SYS_HALT	0x0002	/* Notify of system halt */
-#define SYS_POWER_OFF	0x0003	/* Notify of system power off */
+enum reboot_prepare_mode {
+	SYS_DOWN = 1,		/* Notify of system down */
+	SYS_RESTART = SYS_DOWN,
+	SYS_HALT,		/* Notify of system halt */
+	SYS_POWER_OFF,		/* Notify of system power off */
+};
+
+/*
+ * Standard restart priority levels. Intended to be set in the
+ * sys_off_handler.restart_priority field.
+ *
+ * Use `RESTART_PRIO_ABC +- prio` style for additional levels.
+ *
+ * RESTART_PRIO_RESERVED:	Falls back to RESTART_PRIO_DEFAULT.
+ *				Drivers may leave priority initialized
+ *				to zero, to auto-set it to the default level.
+ *
+ * RESTART_PRIO_LOW:		Use this for handler of last resort.
+ *
+ * RESTART_PRIO_DEFAULT:	Use this for default/generic handler.
+ *
+ * RESTART_PRIO_HIGH:		Use this if you have multiple handlers and
+ *				this handler has higher priority than the
+ *				default handler.
+ */
+#define RESTART_PRIO_RESERVED		0
+#define RESTART_PRIO_LOW		8
+#define RESTART_PRIO_DEFAULT		128
+#define RESTART_PRIO_HIGH		192
 
 enum reboot_mode {
 	REBOOT_UNDEFINED = -1,
@@ -49,6 +74,201 @@ extern int register_restart_handler(struct notifier_block *);
 extern int unregister_restart_handler(struct notifier_block *);
 extern void do_kernel_restart(char *cmd);
 
+/*
+ * System power-off and restart API.
+ */
+
+/*
+ * Standard power-off priority levels. Intended to be set in the
+ * sys_off_handler.power_off_priority field.
+ *
+ * Use `POWEROFF_PRIO_ABC +- prio` style for additional levels.
+ *
+ * POWEROFF_PRIO_RESERVED:	Falls back to POWEROFF_PRIO_DEFAULT.
+ *				Drivers may leave priority initialized
+ *				to zero, to auto-set it to the default level.
+ *
+ * POWEROFF_PRIO_PLATFORM:	Intended to be used by platform-level handler.
+ *				Has lowest priority since device drivers are
+ *				expected to take over platform handler which
+ *				doesn't allow further callback chaining.
+ *
+ * POWEROFF_PRIO_DEFAULT:	Use this for default/generic handler.
+ *
+ * POWEROFF_PRIO_FIRMWARE:	Use this if handler uses firmware call.
+ *				Has highest priority since firmware is expected
+ *				to know best how to power-off hardware properly.
+ */
+#define POWEROFF_PRIO_RESERVED		0
+#define POWEROFF_PRIO_PLATFORM		1
+#define POWEROFF_PRIO_DEFAULT		128
+#define POWEROFF_PRIO_HIGH		192
+#define POWEROFF_PRIO_FIRMWARE		224
+
+enum poweroff_mode {
+	POWEROFF_NORMAL = 0,
+	POWEROFF_PREPARE,
+};
+
+/**
+ * struct power_off_data - Power-off callback argument
+ *
+ * @cb_data: Callback data.
+ */
+struct power_off_data {
+	void *cb_data;
+};
+
+/**
+ * struct power_off_prep_data - Power-off preparation callback argument
+ *
+ * @cb_data: Callback data.
+ */
+struct power_off_prep_data {
+	void *cb_data;
+};
+
+/**
+ * struct restart_data - Restart callback argument
+ *
+ * @cb_data: Callback data.
+ * @cmd: Restart command string.
+ * @stop_chain: Further lower priority callbacks won't be executed if set to
+ *		true. Can be changed within callback. Default is false.
+ * @mode: Reboot mode ID.
+ */
+struct restart_data {
+	void *cb_data;
+	const char *cmd;
+	bool stop_chain;
+	enum reboot_mode mode;
+};
+
+/**
+ * struct reboot_prep_data - Reboot and shutdown preparation callback argument
+ *
+ * @cb_data: Callback data.
+ * @cmd: Restart command string.
+ * @stop_chain: Further lower priority callbacks won't be executed if set to
+ *		true. Can be changed within callback. Default is false.
+ * @mode: Preparation mode ID.
+ */
+struct reboot_prep_data {
+	void *cb_data;
+	const char *cmd;
+	bool stop_chain;
+	enum reboot_prepare_mode mode;
+};
+
+struct sys_off_handler_private_data {
+	struct notifier_block power_off_nb;
+	struct notifier_block restart_nb;
+	struct notifier_block reboot_nb;
+	void (*platform_power_off_cb)(void);
+	void (*simple_power_off_cb)(void *data);
+	void *simple_power_off_cb_data;
+	bool registered;
+};
+
+/**
+ * struct sys_off_handler - System power-off and restart handler
+ *
+ * @cb_data: Pointer to user's data.
+ *
+ * @power_off_cb: Callback that powers off this machine. Inactive if NULL.
+ *
+ * @power_off_prepare_cb: Power-off preparation callback. All power-off
+ * preparation callbacks are invoked after @reboot_prepare_cb and before
+ * @power_off_cb. Inactive if NULL.
+ *
+ * @power_off_priority: Power-off callback priority, must be unique.
+ * Zero value is reserved and auto-reassigned to POWEROFF_PRIO_DEFAULT.
+ * Inactive if @power_off_cb is NULL.
+ *
+ * @power_off_chaining_allowed: Set to false if callback's execution should
+ * stop when @power_off_cb fails to power off this machine. True if further
+ * lower priority power-off callback should be executed. False is default
+ * value.
+ *
+ * @restart_cb: Callback that reboots this machine. Inactive if NULL.
+ *
+ * @restart_priority: Restart callback priority, must be unique. Zero value
+ * is reserved and auto-reassigned to RESTART_PRIO_DEFAULT. Inactive if
+ * @restart_cb is NULL.
+ *
+ * @restart_chaining_disallowed: Set to true if callback's execution should
+ * stop when @restart_cb fails to restart this machine. False if further
+ * lower priority restart callback should be executed. False is default
+ * value.
+ *
+ * @reboot_prepare_cb: Reboot/shutdown preparation callback. All reboot
+ * preparation callbacks are invoked before @restart_cb or @power_off_cb,
+ * depending on the mode. It's registered with register_reboot_notifier().
+ * The point is to remove boilerplate code from drivers which use this
+ * callback in conjunction with the restart/power-off callbacks.
+ *
+ * @reboot_priority: Reboot/shutdown preparation callback priority, doesn't
+ * need to be unique. Zero is default value. Inactive if @reboot_prepare_cb
+ * is NULL.
+ *
+ * @priv: Internal data. Shouldn't be touched.
+ *
+ * Describes power-off and restart handlers which are invoked by kernel
+ * to power off or restart this machine. Supports prioritized chaining for
+ * both restart and power-off handlers.
+ *
+ * Struct sys_off_handler can be static. Members of this structure must not be
+ * altered while handler is registered.
+ *
+ * Fill the structure members and pass it to @register_sys_off_handler().
+ */
+struct sys_off_handler {
+	void *cb_data;
+
+	void (*power_off_cb)(struct power_off_data *data);
+	void (*power_off_prepare_cb)(struct power_off_prep_data *data);
+	int power_off_priority;
+	bool power_off_chaining_allowed;
+
+	void (*restart_cb)(struct restart_data *data);
+	int restart_priority;
+	bool restart_chaining_disallowed;
+
+	void (*reboot_prepare_cb)(struct reboot_prep_data *data);
+	int reboot_priority;
+
+	const struct sys_off_handler_private_data priv;
+};
+
+int register_sys_off_handler(struct sys_off_handler *handler);
+int unregister_sys_off_handler(struct sys_off_handler *handler);
+
+int devm_register_sys_off_handler(struct device *dev,
+				  struct sys_off_handler *handler);
+
+int devm_register_prioritized_power_off_handler(struct device *dev,
+						int priority,
+						void (*callback)(void *data),
+						void *cb_data);
+
+int devm_register_simple_power_off_handler(struct device *dev,
+					   void (*callback)(void *data),
+					   void *cb_data);
+
+int register_platform_power_off(void (*power_off)(void));
+int unregister_platform_power_off(void (*power_off)(void));
+
+int devm_register_prioritized_restart_handler(struct device *dev,
+					      int priority,
+					      void (*callback)(struct restart_data *data),
+					      void *cb_data);
+
+int devm_register_simple_restart_handler(struct device *dev,
+					 void (*callback)(struct restart_data *data),
+					 void *cb_data);
+
+void do_kernel_power_off(void);
+
 /*
  * Architecture-specific implementations of sys_reboot commands.
  */
@@ -70,6 +290,7 @@ extern void kernel_restart_prepare(char *cmd);
 extern void kernel_restart(char *cmd);
 extern void kernel_halt(void);
 extern void kernel_power_off(void);
+extern bool kernel_can_power_off(void);
 
 void ctrl_alt_del(void);
 
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index 938d5c78b421..a9464b4a3209 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -665,7 +665,7 @@ static void power_down(void)
 		hibernation_platform_enter();
 		fallthrough;
 	case HIBERNATION_SHUTDOWN:
-		if (pm_power_off)
+		if (kernel_can_power_off())
 			kernel_power_off();
 		break;
 	}
diff --git a/kernel/reboot.c b/kernel/reboot.c
index acdae4e95061..e76e2570dcf5 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -296,6 +296,595 @@ void kernel_halt(void)
 }
 EXPORT_SYMBOL_GPL(kernel_halt);
 
+/*
+ *	Notifier list for kernel code which wants to be called
+ *	to power off the system.
+ */
+static BLOCKING_NOTIFIER_HEAD(power_off_handler_list);
+
+/*
+ * Temporary stub that prevents linkage failure while we're in process
+ * of removing all uses of legacy pm_power_off() around the kernel.
+ */
+void __weak (*pm_power_off)(void);
+
+static void dummy_pm_power_off(void)
+{
+	/* temporary stub until pm_power_off() is gone, see more below */
+}
+
+static struct notifier_block *pm_power_off_nb;
+
+/**
+ *	register_power_off_handler - Register function to be called to power off
+ *				     the system
+ *	@nb: Info about handler function to be called
+ *	@nb->priority:	Handler priority. Handlers should follow the
+ *			following guidelines for setting priorities.
+ *			0:	Reserved
+ *			1:	Power-off handler of last resort,
+ *				with limited power-off capabilities
+ *			128:	Default power-off handler; use if no other
+ *				power-off handler is expected to be available,
+ *				and/or if power-off functionality is
+ *				sufficient to power-off the entire system
+ *			255:	Highest priority power-off handler, will
+ *				preempt all other power-off handlers
+ *
+ *	Registers a function with code to be called to power off the
+ *	system.
+ *
+ *	Registered functions will be called as last step of the power-off
+ *	sequence.
+ *
+ *	Registered functions are expected to power off the system immediately.
+ *	If more than one function is registered, the power-off handler priority
+ *	selects which function will be called first.
+ *
+ *	Power-off handlers are expected to be registered from non-architecture
+ *	code, typically from drivers. A typical use case would be a system
+ *	where power-off functionality is provided through a PMIC. Multiple
+ *	power-off handlers may exist; for example, one power-off handler might
+ *	turn off the entire system, while another only turns off part of
+ *	system. In such cases, the power-off handler which only disables part
+ *	of the hardware is expected to register with low priority to ensure
+ *	that it only runs if no other means to power off the system is
+ *	available.
+ *
+ *	Currently always returns zero, as blocking_notifier_chain_register()
+ *	always returns zero.
+ */
+static int register_power_off_handler(struct notifier_block *nb)
+{
+	int ret;
+
+	ret = blocking_notifier_chain_register_unique_prio(&power_off_handler_list, nb);
+	if (ret && ret != -EBUSY)
+		return ret;
+
+	if (!ret)
+		goto set_pm_power_off;
+
+	/*
+	 * Handler must have unique priority. Otherwise call order is
+	 * determined by registration order, which is unreliable.
+	 *
+	 * This requirement will become mandatory once all drivers
+	 * will be converted to use new sys-off API.
+	 */
+	pr_err("failed to register power-off handler using unique priority\n");
+
+	ret = blocking_notifier_chain_register(&power_off_handler_list, nb);
+	if (ret)
+		return ret;
+
+	/*
+	 * Some drivers check whether pm_power_off was already installed.
+	 * Install dummy callback using new API to preserve old behaviour
+	 * for those drivers during period of transition to the new API.
+	 */
+set_pm_power_off:
+	if (!pm_power_off) {
+		pm_power_off = dummy_pm_power_off;
+		pm_power_off_nb = nb;
+	}
+
+	return 0;
+}
+
+static int unregister_power_off_handler(struct notifier_block *nb)
+{
+	if (nb == pm_power_off_nb) {
+		if (pm_power_off == dummy_pm_power_off)
+			pm_power_off = NULL;
+
+		pm_power_off_nb = NULL;
+	}
+
+	return blocking_notifier_chain_unregister(&power_off_handler_list, nb);
+}
+
+static void devm_unregister_power_off_handler(void *data)
+{
+	struct notifier_block *nb = data;
+
+	unregister_power_off_handler(nb);
+}
+
+static int devm_register_power_off_handler(struct device *dev,
+					   struct notifier_block *nb)
+{
+	int err;
+
+	err = register_power_off_handler(nb);
+	if (err)
+		return err;
+
+	return devm_add_action_or_reset(dev, devm_unregister_power_off_handler,
+					nb);
+}
+
+static int sys_off_handler_power_off(struct notifier_block *nb,
+				     unsigned long mode, void *unused)
+{
+	struct power_off_prep_data prep_data = {};
+	struct sys_off_handler_private_data *priv;
+	struct power_off_data data = {};
+	struct sys_off_handler *h;
+	int ret = NOTIFY_DONE;
+
+	priv = container_of(nb, struct sys_off_handler_private_data, power_off_nb);
+	h = container_of(priv, struct sys_off_handler, priv);
+	prep_data.cb_data = h->cb_data;
+	data.cb_data = h->cb_data;
+
+	switch (mode) {
+	case POWEROFF_NORMAL:
+		if (h->power_off_cb)
+			h->power_off_cb(&data);
+
+		if (priv->simple_power_off_cb)
+			priv->simple_power_off_cb(priv->simple_power_off_cb_data);
+
+		if (priv->platform_power_off_cb)
+			priv->platform_power_off_cb();
+
+		if (!h->power_off_chaining_allowed)
+			ret = NOTIFY_STOP;
+
+		break;
+
+	case POWEROFF_PREPARE:
+		if (h->power_off_prepare_cb)
+			h->power_off_prepare_cb(&prep_data);
+
+		break;
+
+	default:
+		unreachable();
+	}
+
+	return ret;
+}
+
+static int sys_off_handler_restart(struct notifier_block *nb,
+				   unsigned long mode, void *cmd)
+{
+	struct sys_off_handler_private_data *priv;
+	struct restart_data data = {};
+	struct sys_off_handler *h;
+
+	priv = container_of(nb, struct sys_off_handler_private_data, restart_nb);
+	h = container_of(priv, struct sys_off_handler, priv);
+
+	data.stop_chain = h->restart_chaining_disallowed;
+	data.cb_data = h->cb_data;
+	data.mode = mode;
+	data.cmd = cmd;
+
+	h->restart_cb(&data);
+
+	return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;
+}
+
+static int sys_off_handler_reboot(struct notifier_block *nb,
+				  unsigned long mode, void *cmd)
+{
+	struct sys_off_handler_private_data *priv;
+	struct reboot_prep_data data = {};
+	struct sys_off_handler *h;
+
+	priv = container_of(nb, struct sys_off_handler_private_data, reboot_nb);
+	h = container_of(priv, struct sys_off_handler, priv);
+
+	data.cb_data = h->cb_data;
+	data.stop_chain = false;
+	data.mode = mode;
+	data.cmd = cmd;
+
+	h->reboot_prepare_cb(&data);
+
+	return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;
+}
+
+static struct sys_off_handler_private_data *
+sys_off_handler_private_data(struct sys_off_handler *handler)
+{
+	return (struct sys_off_handler_private_data *)&handler->priv;
+}
+
+/**
+ *	devm_register_sys_off_handler - Register system power-off/restart handler
+ *	@dev: Device that registers handler
+ *	@handler: System-off handler
+ *
+ *	Registers handler that will be called as last step of the power-off
+ *	and restart sequences.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int register_sys_off_handler(struct sys_off_handler *handler)
+{
+	struct sys_off_handler_private_data *priv;
+	int err, priority;
+
+	priv = sys_off_handler_private_data(handler);
+
+	/* sanity-check whether handler is registered twice */
+	if (priv->registered)
+		return -EBUSY;
+
+	if (handler->power_off_cb || handler->power_off_prepare_cb) {
+		if (handler->power_off_priority == POWEROFF_PRIO_RESERVED)
+			priority = POWEROFF_PRIO_DEFAULT;
+		else
+			priority = handler->power_off_priority;
+
+		priv->power_off_nb.notifier_call = sys_off_handler_power_off;
+		priv->power_off_nb.priority = priority;
+
+		err = register_power_off_handler(&priv->power_off_nb);
+		if (err)
+			goto reset_sys_off_handler;
+	}
+
+	if (handler->restart_cb) {
+		if (handler->restart_priority == RESTART_PRIO_RESERVED)
+			priority = RESTART_PRIO_DEFAULT;
+		else
+			priority = handler->restart_priority;
+
+		priv->restart_nb.notifier_call = sys_off_handler_restart;
+		priv->restart_nb.priority = priority;
+
+		err = register_restart_handler(&priv->restart_nb);
+		if (err)
+			goto unreg_power_off_handler;
+	}
+
+	if (handler->reboot_prepare_cb) {
+		priv->reboot_nb.notifier_call = sys_off_handler_reboot;
+		priv->reboot_nb.priority = handler->reboot_priority;
+
+		err = register_reboot_notifier(&priv->reboot_nb);
+		if (err)
+			goto unreg_restart_handler;
+	}
+
+	priv->registered = true;
+
+	return 0;
+
+unreg_restart_handler:
+	if (handler->restart_cb)
+		unregister_restart_handler(&priv->restart_nb);
+
+unreg_power_off_handler:
+	if (handler->power_off_cb)
+		unregister_power_off_handler(&priv->power_off_nb);
+
+reset_sys_off_handler:
+	memset(priv, 0, sizeof(*priv));
+
+	return err;
+}
+EXPORT_SYMBOL(register_sys_off_handler);
+
+/**
+ *	unregister_sys_off_handler - Unregister system power-off/restart handler
+ *	@handler: System-off handler
+ *
+ *	Unregisters sys-off handler. Does nothing and returns zero if handler
+ *	is NULL.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int unregister_sys_off_handler(struct sys_off_handler *handler)
+{
+	struct sys_off_handler_private_data *priv;
+
+	if (!handler)
+		return 0;
+
+	priv = sys_off_handler_private_data(handler);
+
+	/* sanity-check whether handler is unregistered twice */
+	if (!priv->registered)
+		return -EINVAL;
+
+	if (handler->reboot_prepare_cb)
+		unregister_reboot_notifier(&priv->reboot_nb);
+
+	if (handler->restart_cb)
+		unregister_restart_handler(&priv->restart_nb);
+
+	if (handler->power_off_cb)
+		unregister_power_off_handler(&priv->power_off_nb);
+
+	memset(priv, 0, sizeof(*priv));
+
+	return 0;
+}
+EXPORT_SYMBOL(unregister_sys_off_handler);
+
+static void devm_unregister_sys_off_handler(void *data)
+{
+	struct sys_off_handler *handler = data;
+
+	unregister_sys_off_handler(handler);
+}
+
+/**
+ *	devm_register_sys_off_handler - Register system power-off/restart handler
+ *	@dev: Device that registers handler
+ *	@handler: System-off handler
+ *
+ *	Resource-managed variant of register_sys_off_handler().
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_sys_off_handler(struct device *dev,
+				  struct sys_off_handler *handler)
+{
+	int err;
+
+	err = register_sys_off_handler(handler);
+	if (err)
+		return err;
+
+	return devm_add_action_or_reset(dev, devm_unregister_sys_off_handler,
+					handler);
+}
+EXPORT_SYMBOL(devm_register_sys_off_handler);
+
+/**
+ *	devm_register_prioritized_power_off_handler - Register prioritized power-off callback
+ *	@dev: Device that registers callback
+ *	@priority: Callback's priority
+ *	@callback: Callback function
+ *	@cb_data: Callback's argument
+ *
+ *	Registers resource-managed power-off callback with a given priority.
+ *	It will be called as last step of the power-off sequence. Callbacks
+ *	chaining is disabled, i.e. further lower priority callbacks won't
+ *	be executed if this @callback will fail to execute.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_prioritized_power_off_handler(struct device *dev,
+						int priority,
+						void (*callback)(void *data),
+						void *cb_data)
+{
+	struct sys_off_handler_private_data *priv;
+	struct sys_off_handler *handler;
+
+	handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
+	if (!handler)
+		return -ENOMEM;
+
+	if (priority == POWEROFF_PRIO_RESERVED)
+		priority = POWEROFF_PRIO_DEFAULT;
+
+	priv = sys_off_handler_private_data(handler);
+
+	priv->power_off_nb.notifier_call = sys_off_handler_power_off;
+	priv->power_off_nb.priority = priority;
+	priv->simple_power_off_cb_data = cb_data;
+	priv->simple_power_off_cb = callback;
+
+	return devm_register_power_off_handler(dev, &priv->power_off_nb);
+}
+EXPORT_SYMBOL(devm_register_prioritized_power_off_handler);
+
+int devm_register_prioritized_power_off_handler(struct device *dev,
+						int priority,
+						void (*callback)(void *data),
+						void *cb_data);
+
+/**
+ *	devm_register_simple_power_off_handler - Register simple power-off callback
+ *	@dev: Device that registers callback
+ *	@callback: Callback function
+ *	@cb_data: Callback's argument
+ *
+ *	Registers resource-managed power-off callback with default priority.
+ *	It will be invoked as last step of the power-off sequence. Further
+ *	lower priority callbacks won't be executed if this @callback fails.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_simple_power_off_handler(struct device *dev,
+					   void (*callback)(void *data),
+					   void *cb_data)
+{
+	return devm_register_prioritized_power_off_handler(dev,
+							   POWEROFF_PRIO_DEFAULT,
+							   callback, cb_data);
+}
+EXPORT_SYMBOL(devm_register_simple_power_off_handler);
+
+/**
+ *	devm_register_prioritized_restart_handler - Register prioritized restart callback
+ *	@dev: Device that registers callback
+ *	@priority: Callback's priority
+ *	@callback: Callback function
+ *	@cb_data: Callback's argument
+ *
+ *	Registers resource-managed restart callback with a given priority.
+ *	It will be called as a part of the restart sequence. Callbacks
+ *	chaining is disabled, i.e. further lower priority callbacks won't
+ *	be executed if this @callback will fail to execute.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_prioritized_restart_handler(struct device *dev,
+					      int priority,
+					      void (*callback)(struct restart_data *data),
+					      void *cb_data)
+{
+	struct sys_off_handler *handler;
+
+	handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
+	if (!handler)
+		return -ENOMEM;
+
+	if (priority == RESTART_PRIO_RESERVED)
+		priority = RESTART_PRIO_DEFAULT;
+
+	handler->restart_priority = priority;
+	handler->restart_cb = callback;
+	handler->cb_data = cb_data;
+
+	return devm_register_sys_off_handler(dev, handler);
+}
+EXPORT_SYMBOL(devm_register_prioritized_restart_handler);
+
+/**
+ *	devm_register_simple_restart_handler - Register simple restart callback
+ *	@dev: Device that registers callback
+ *	@callback: Callback function
+ *	@cb_data: Callback's argument
+ *
+ *	Registers resource-managed restart callback with default priority.
+ *	It will be invoked as a part of the restart sequence. Further
+ *	lower priority callback will be executed if this @callback fails.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_simple_restart_handler(struct device *dev,
+					 void (*callback)(struct restart_data *data),
+					 void *cb_data)
+{
+	return devm_register_prioritized_restart_handler(dev,
+							 RESTART_PRIO_DEFAULT,
+							 callback, cb_data);
+}
+EXPORT_SYMBOL(devm_register_simple_restart_handler);
+
+static struct sys_off_handler platform_power_off_handler = {
+	.priv = {
+		.power_off_nb = {
+			.notifier_call = sys_off_handler_power_off,
+			.priority = POWEROFF_PRIO_PLATFORM,
+		},
+	},
+};
+
+static DEFINE_SPINLOCK(platform_power_off_lock);
+
+/**
+ *	register_platform_power_off - Register platform-level power-off callback
+ *	@power_off: Power-off callback
+ *
+ *	Registers power-off callback that will be called as last step
+ *	of the power-off sequence. This callback is expected to be invoked
+ *	for the last resort. Further lower priority callbacks won't be
+ *	executed if @power_off fails. Only one platform power-off callback
+ *	is allowed to be registered at a time.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int register_platform_power_off(void (*power_off)(void))
+{
+	struct sys_off_handler_private_data *priv;
+	int ret = 0;
+
+	priv = sys_off_handler_private_data(&platform_power_off_handler);
+
+	spin_lock(&platform_power_off_lock);
+	if (priv->platform_power_off_cb)
+		ret = -EBUSY;
+	else
+		priv->platform_power_off_cb = power_off;
+	spin_unlock(&platform_power_off_lock);
+
+	if (ret)
+		return ret;
+
+	ret = register_power_off_handler(&priv->power_off_nb);
+	if (ret)
+		priv->platform_power_off_cb = NULL;
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(register_platform_power_off);
+
+/**
+ *	unregister_platform_power_off - Unregister platform-level power-off callback
+ *	@power_off: Power-off callback
+ *
+ *	Unregisters previously registered platform power-off callback.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int unregister_platform_power_off(void (*power_off)(void))
+{
+	struct sys_off_handler_private_data *priv;
+	int ret;
+
+	priv = sys_off_handler_private_data(&platform_power_off_handler);
+
+	if (priv->platform_power_off_cb != power_off)
+		return -EINVAL;
+
+	ret = unregister_power_off_handler(&priv->power_off_nb);
+	priv->platform_power_off_cb = NULL;
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(unregister_platform_power_off);
+
+/**
+ *	do_kernel_power_off - Execute kernel power-off handler call chain
+ *
+ *	Calls functions registered with register_power_off_handler.
+ *
+ *	Expected to be called as last step of the power-off sequence.
+ *
+ *	Powers off the system immediately if a power-off handler function has
+ *	been registered. Otherwise does nothing.
+ */
+void do_kernel_power_off(void)
+{
+	/* legacy pm_power_off() is unchained and has highest priority */
+	if (pm_power_off && pm_power_off != dummy_pm_power_off)
+		return pm_power_off();
+
+	blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_NORMAL,
+				     NULL);
+}
+
+static void do_kernel_power_off_prepare(void)
+{
+	/* legacy pm_power_off_prepare() is unchained and has highest priority */
+	if (pm_power_off_prepare)
+		return pm_power_off_prepare();
+
+	blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE,
+				     NULL);
+}
+
 /**
  *	kernel_power_off - power_off the system
  *
@@ -304,8 +893,7 @@ EXPORT_SYMBOL_GPL(kernel_halt);
 void kernel_power_off(void)
 {
 	kernel_shutdown_prepare(SYSTEM_POWER_OFF);
-	if (pm_power_off_prepare)
-		pm_power_off_prepare();
+	do_kernel_power_off_prepare();
 	migrate_to_reboot_cpu();
 	syscore_shutdown();
 	pr_emerg("Power down\n");
@@ -314,6 +902,16 @@ void kernel_power_off(void)
 }
 EXPORT_SYMBOL_GPL(kernel_power_off);
 
+bool kernel_can_power_off(void)
+{
+	if (!pm_power_off &&
+	    blocking_notifier_call_chain_is_empty(&power_off_handler_list))
+		return false;
+
+	return true;
+}
+EXPORT_SYMBOL_GPL(kernel_can_power_off);
+
 DEFINE_MUTEX(system_transition_mutex);
 
 /*
@@ -355,7 +953,7 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd,
 	/* Instead of trying to make the power_off code look like
 	 * halt when pm_power_off is not set do it the easy way.
 	 */
-	if ((cmd == LINUX_REBOOT_CMD_POWER_OFF) && !pm_power_off)
+	if (cmd == LINUX_REBOOT_CMD_POWER_OFF && !kernel_can_power_off())
 		cmd = LINUX_REBOOT_CMD_HALT;
 
 	mutex_lock(&system_transition_mutex);
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:11:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:11:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303291.517493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8oo-0007Ul-7u; Tue, 12 Apr 2022 05:11:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303291.517493; Tue, 12 Apr 2022 05:11:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8on-0007Ry-Q2; Tue, 12 Apr 2022 05:11:57 +0000
Received: by outflank-mailman (input) for mailman id 303291;
 Mon, 11 Apr 2022 23:39:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3ct-0006ro-2t
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:19 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 997c33c4-b9f0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 01:39:16 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id E770D1F42D9B
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 997c33c4-b9f0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720355;
	bh=mEAWfgvUjdysskEF8iUlWGlMBnbi4YXkTD4z8bx8CSo=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=CLcZhZRBWYJWbqJVmUxp15zxW0q/47vnJq5zqdKCdWSfI8BjhPTI8rQduGKbaYVf7
	 ekIErWAI5Ds7RFtcDJx/9duCmtfVtRtFNfWebrgEsGntH8B+62ayRj1qtloX62b2Y7
	 e5drX4YJBwokz0ivwDzvWnKWVszh7mY/nmp4Q59rt6ZObClIPHtBt+3CvQtdlKxJs1
	 /8glZivtyjTKrLQHs275F+aL6dM9AkMz782odCsOfKwT5sWiLaCxFDCfh1V6F1Ilms
	 e1kdfRu9fxShLXjk1wGnDzf/fXiNStZ8Ay/kj1e5lF8RRn/6TsULivZlCRSo+fpQjJ
	 ZActkWfOYFyKQ==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 05/20] ARM: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:17 +0300
Message-Id: <20220411233832.391817-6-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/arm/kernel/reboot.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
index 3044fcb8d073..2cb943422554 100644
--- a/arch/arm/kernel/reboot.c
+++ b/arch/arm/kernel/reboot.c
@@ -116,9 +116,7 @@ void machine_power_off(void)
 {
 	local_irq_disable();
 	smp_send_stop();
-
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 /*
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:11:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:11:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303293.517501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8oo-0007cz-Ux; Tue, 12 Apr 2022 05:11:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303293.517501; Tue, 12 Apr 2022 05:11:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8oo-0007Ze-8t; Tue, 12 Apr 2022 05:11:58 +0000
Received: by outflank-mailman (input) for mailman id 303293;
 Mon, 11 Apr 2022 23:39:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3cu-0006ro-VG
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:21 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9bf4426f-b9f0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 01:39:20 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 0E2FC1F42DB1
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bf4426f-b9f0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720360;
	bh=pRtQqsaYfvoJzmisEka7OPXajhyNLIAv+QAu0QyZDnc=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=ZfHrkdNRBQ8J2hkiBY4/dHsQzt/m7SysRdtrvIMp09xuqkvYIJnMbbf70/j5ltuED
	 2XUiE7IC0pQeOlkFJh1HxIjoldBG+V+5aKdjx28DerDyXXvDXqKthN6m+1kctJFJOJ
	 a0XSMZZcTjZQz2xyBAunrmTbFxvU4giIVvM9vOqGQt0zA42VeqBT8iuiLdSW9YJLE/
	 h06w6159Zl1BE6jWsyxGHdKkD6oQ4z0ZrepwVFG52gqDGW+j8+Hk2TWeg51QkITTEh
	 asdSeYQV9i9jrB1/CrqHBVvpg4IH8lVkzL9yoQRGBNrw80R84lPhA2NCUWicE4H3e1
	 0OGEUHzRUW6Rw==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 06/20] csky: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:18 +0300
Message-Id: <20220411233832.391817-7-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Guo Ren <guoren@kernel.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/csky/kernel/power.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/csky/kernel/power.c b/arch/csky/kernel/power.c
index 923ee4e381b8..86ee202906f8 100644
--- a/arch/csky/kernel/power.c
+++ b/arch/csky/kernel/power.c
@@ -9,16 +9,14 @@ EXPORT_SYMBOL(pm_power_off);
 void machine_power_off(void)
 {
 	local_irq_disable();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	asm volatile ("bkpt");
 }
 
 void machine_halt(void)
 {
 	local_irq_disable();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	asm volatile ("bkpt");
 }
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:11:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:11:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303295.517507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8op-0007oY-JL; Tue, 12 Apr 2022 05:11:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303295.517507; Tue, 12 Apr 2022 05:11:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8oo-0007jf-TL; Tue, 12 Apr 2022 05:11:58 +0000
Received: by outflank-mailman (input) for mailman id 303295;
 Mon, 11 Apr 2022 23:39:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3cz-0006ro-O8
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:25 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk
 [2a00:1098:0:82:1000:25:2eeb:e3e3])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9e6325d9-b9f0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 01:39:25 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 364501F42DB6
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e6325d9-b9f0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720364;
	bh=4rdbLD2+Iag77JMwmchrPYamych2367V1MeouFpjB0E=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=WrJUgpTL2mz0b1tdWs+lbZHp4sOmPNiAkwDR5byRZ/kPUsqROAg+WnoC5wo3UwSA9
	 he3WggK2Db9XGe0m3cnXP4wqgvFZ5RxXFLPP7ysL4VVRXmA+1VzIhk0tnONuLD9Hk0
	 oIfdUC4QinyWbAv9M6Fb9K0d9xMo7zMuZxdgFPU73e8EMh+hwR/NoQjJwKd+ps+mD6
	 1raKm3fvYtzK7w7vIsIFJ5wwOqDnth413yqDdNteedrYUgskO9lJ7+yeTYwNSWnc8d
	 kOFPQB6PLs2P7T4PDuqwUxE99sUZoWWJRfixny2gvzijMd3lw/0qSUxi9UuueN4qPA
	 2Sw8FUE8ZkpNQ==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 07/20] riscv: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:19 +0300
Message-Id: <20220411233832.391817-8-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/riscv/kernel/reset.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c
index 9c842c41684a..912288572226 100644
--- a/arch/riscv/kernel/reset.c
+++ b/arch/riscv/kernel/reset.c
@@ -23,16 +23,12 @@ void machine_restart(char *cmd)
 
 void machine_halt(void)
 {
-	if (pm_power_off != NULL)
-		pm_power_off();
-	else
-		default_power_off();
+	do_kernel_power_off();
+	default_power_off();
 }
 
 void machine_power_off(void)
 {
-	if (pm_power_off != NULL)
-		pm_power_off();
-	else
-		default_power_off();
+	do_kernel_power_off();
+	default_power_off();
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303297.517513 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8oq-00083H-7A; Tue, 12 Apr 2022 05:12:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303297.517513; Tue, 12 Apr 2022 05:12:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8op-0007yW-OF; Tue, 12 Apr 2022 05:11:59 +0000
Received: by outflank-mailman (input) for mailman id 303297;
 Mon, 11 Apr 2022 23:39:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3d3-0006oE-6I
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:29 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a0d64cc9-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:28 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 4951B1F43AED
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0d64cc9-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720368;
	bh=OM3Edh5ei8PPhfOzgq1DQOJZnmNFXz0QDZstiZwMgss=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=eR1V7YO4JiaZSZMv3eZYlIpEUuUXjf21t+dvWtRjQf6T5Gxu1B6+nqlmc3aIC8C1u
	 FTuhGsjmx3UOLCwau+wmuP7tVw92HREgB4lUkQAIF7SuLhUnddwvPIECdC6PNwUpQv
	 yOYER5E9xlmRzW6LvzA5fm7uQg9QcsDjzpsRSlw+PtUEF+Rt/pbWBDvnfy/My61fny
	 k7p7330Nf8JbpcM8NVf/iD54I18oOGaYH3oXM0vVb2DCV8HdIzp3CrK/TPOz76BB0r
	 TCV55Kh/0CrBvHEwPXUdTDUgVuVkScp+Ntja5VWo+K8YlzCu+ZmIKHO6ha1kFwr5j/
	 QT0evUqt+/l5A==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 08/20] arm64: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:20 +0300
Message-Id: <20220411233832.391817-9-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/arm64/kernel/process.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 7fa97df55e3a..26d1b0a4329a 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -111,8 +111,7 @@ void machine_power_off(void)
 {
 	local_irq_disable();
 	smp_send_stop();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 /*
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303299.517528 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8or-0008GU-K7; Tue, 12 Apr 2022 05:12:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303299.517528; Tue, 12 Apr 2022 05:12:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8oq-0008A9-M6; Tue, 12 Apr 2022 05:12:00 +0000
Received: by outflank-mailman (input) for mailman id 303299;
 Mon, 11 Apr 2022 23:39:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3d7-0006ro-CJ
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:33 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk
 [2a00:1098:0:82:1000:25:2eeb:e3e3])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a3565950-b9f0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 01:39:32 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 6295A1F43D17
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3565950-b9f0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720372;
	bh=SXdQ9+3ZNp9SJwX0lrMJ1vhpvKSj1tt3zF1mvSxRlFU=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=n6hRSKlZnLN3htvFR6EvjIJdAujT9TSW8cxEcD0RZ7sF0YHbjnd4oyQRxsOhYkMzu
	 u3wNpzu3o4CHDNt/+CwxpRUeqL1AwjnGxYgajWyiIP02taeMmrbmomyq7LxxfhZzFc
	 zXyp9HcMoxL9Rzw0/ARRO1lwxKJFQCad9CnHfzRA1IK3JOWz6H+rljb09BRQ9Difx9
	 j/2K4nMonxy1ck0Gw21YsKpKK4nOd1Ue2Ws03uqm8NNnMet0oXM7v3ei6drEo8Q5cg
	 3V7NLaq0v+/Sp+mksC2CwvedKsXZSKE83wJoq67yAYMCN8Wbkm9OdSUwtfkkCfHNAK
	 v8/AR0uPzoeBA==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 09/20] parisc: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:21 +0300
Message-Id: <20220411233832.391817-10-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Helge Deller <deller@gmx.de> # parisc
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/parisc/kernel/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c
index 28b6a2a5574c..d145184696ea 100644
--- a/arch/parisc/kernel/process.c
+++ b/arch/parisc/kernel/process.c
@@ -26,6 +26,7 @@
 #include <linux/module.h>
 #include <linux/personality.h>
 #include <linux/ptrace.h>
+#include <linux/reboot.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/task.h>
@@ -116,8 +117,7 @@ void machine_power_off(void)
 	pdc_chassis_send_status(PDC_CHASSIS_DIRECT_SHUTDOWN);
 
 	/* ipmi_poweroff may have been installed. */
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 		
 	/* It seems we have no way to power the system off via
 	 * software. The user has to press the button himself. */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303301.517540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8os-0000D1-Pm; Tue, 12 Apr 2022 05:12:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303301.517540; Tue, 12 Apr 2022 05:12:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8or-00006k-Vy; Tue, 12 Apr 2022 05:12:01 +0000
Received: by outflank-mailman (input) for mailman id 303301;
 Mon, 11 Apr 2022 23:39:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dB-0006oE-D0
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:37 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a5b9ace5-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:36 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 915191F43D1A
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5b9ace5-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720376;
	bh=/6N1NqWTzjqffsr0MYGq4IYVUQskqSynn6Y334kzapg=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=mQsjTJIn+P3/qMm6CgQ+bPQ7EleJ40FaGcgtLTxE/ao4KfvFaQYrjidT8XaGySRfW
	 LtMhTqRxWtDelluYdNNnvCF2SHtqFrhbTq6SQjR/wYerXvArxXHqIe46wUNgoMmR75
	 e5GuMQ+FN0MnaxSGFHmBAxERZcEN6zLzn9MNxkwOchkm5cUvhvFF3WsvMyY+Wvj/Bf
	 FZ61MdojqgQMFK3VHKf9XPK7pidFdgqxhl15dckSHVqGqULXhOrHjm1H0/aTJSki+S
	 2lHLWe0gcmF+BXemoi+m6zGClffgIvI5J5rTM647heG7g0c1/HMiTMFnNnbbpJz5I+
	 S9piQ2GTV7bFg==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 10/20] xen/x86: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:22 +0300
Message-Id: <20220411233832.391817-11-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/x86/xen/enlighten_pv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 5038edb79ad5..af1f6e886225 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -31,6 +31,7 @@
 #include <linux/gfp.h>
 #include <linux/edd.h>
 #include <linux/objtool.h>
+#include <linux/reboot.h>
 
 #include <xen/xen.h>
 #include <xen/events.h>
@@ -1071,8 +1072,7 @@ static void xen_machine_halt(void)
 
 static void xen_machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	xen_reboot(SHUTDOWN_poweroff);
 }
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303303.517556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8ou-0000bf-N2; Tue, 12 Apr 2022 05:12:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303303.517556; Tue, 12 Apr 2022 05:12:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8ot-0000Ws-Ee; Tue, 12 Apr 2022 05:12:03 +0000
Received: by outflank-mailman (input) for mailman id 303303;
 Mon, 11 Apr 2022 23:39:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dF-0006oE-Hl
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:41 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk
 [2a00:1098:0:82:1000:25:2eeb:e3e3])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a828cf33-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:40 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 909861F43D1D
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a828cf33-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720380;
	bh=AnjrhaHENsX+9TktlKasoiUkGDZC8u25pvM/oDIQuBM=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=mCs0xXKXBGwKhSNizz+CrsN6ijBgTwnfXqn6tYSvyJZmHSD5olRTei4LE/G7coxYf
	 CdB+dreJDhlfyN9XCDD4SviS0SmWim/cg7mtN04vs2oHnCtGBVPT6ckS3CZtoWmbEA
	 I/gc8aKseKuzeqxAjIsqUT+GOOhAiTI3UhnDIbn6WTaQ5HgsqbEwXHY1aJyLFAveRz
	 nKPagL8xhkJk3dLCpGc+JnYLWLB19jnsaWShwat50U3lRK/VSm8lo8REWhKYt0uv5+
	 WvePNPqDKrlZanfab8M+cTo/qPdH4ci3OwDczmWuAhAKwJRpU2wR8ZAyEQyeG2SlI6
	 aILbZj82gIeeQ==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 11/20] powerpc: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:23 +0300
Message-Id: <20220411233832.391817-12-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/powerpc/kernel/setup-common.c | 4 +---
 arch/powerpc/xmon/xmon.c           | 3 +--
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 518ae5aa9410..1b586577e75b 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -161,9 +161,7 @@ void machine_restart(char *cmd)
 void machine_power_off(void)
 {
 	machine_shutdown();
-	if (pm_power_off)
-		pm_power_off();
-
+	do_kernel_power_off();
 	smp_send_stop();
 	machine_hang();
 }
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index fd72753e8ad5..c916bf250796 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1243,8 +1243,7 @@ static void bootcmds(void)
 	} else if (cmd == 'h') {
 		ppc_md.halt();
 	} else if (cmd == 'p') {
-		if (pm_power_off)
-			pm_power_off();
+		do_kernel_power_off();
 	}
 }
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303305.517564 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8ow-0000y3-5M; Tue, 12 Apr 2022 05:12:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303305.517564; Tue, 12 Apr 2022 05:12:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8ou-0000rC-SL; Tue, 12 Apr 2022 05:12:04 +0000
Received: by outflank-mailman (input) for mailman id 303305;
 Mon, 11 Apr 2022 23:39:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dJ-0006oE-NE
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:45 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk
 [2a00:1098:0:82:1000:25:2eeb:e3e3])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aa902122-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:44 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id A8ED81F43D21
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa902122-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720384;
	bh=3jxNCr50hXMiuQKPY6aSTyDwgW9MB8tpZKXxC2xIhis=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=R6Pz+NW8C1nY5ThJ2I8cAwEUAIBn3TF8sggu7KSDpBA2Ut/0exz6Xps+3/DnVgwBN
	 qp6Lqyx7CPyAYk+qZkUxz2KCm7SnCRJ4eOYnawabjYhGt6nRnQa9Y02z/Ytkv2jXpZ
	 wEcsyt2MDHlC1WX/nw52J0c857HvVJOhLeDrY7yRKznEzlbGj2ZC8hDBsKt1V+pZeP
	 zbdktiCEBi99v8s5+GasfGckA5YJsjqZH0zL18RDx2s4TE9tXf9pP/XNP1Ahm7vU8u
	 u3DSr1rfrTs/d19jgQcujhTQ+xjiQHnAYsKAqXTDcAVEVHrQCWORpLx/uihf64AFFO
	 sfXLGACDgXMIg==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 12/20] m68k: Switch to new sys-off handler API
Date: Tue, 12 Apr 2022 02:38:24 +0300
Message-Id: <20220411233832.391817-13-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use
register_power_off_handler() that registers power-off handlers and
do_kernel_power_off() that invokes chained power-off handlers. Legacy
pm_power_off() will be removed once all drivers will be converted to
the new power-off API.

Normally arch code should adopt only the do_kernel_power_off() at first,
but m68k is a special case because it uses pm_power_off() "inside out",
i.e. pm_power_off() invokes machine_power_off() [in fact it does nothing],
while it's machine_power_off() that should invoke the pm_power_off(), and
thus, we can't convert platforms to the new API separately. There are only
two platforms changed here, so it's not a big deal.

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/m68k/emu/natfeat.c         | 3 ++-
 arch/m68k/include/asm/machdep.h | 1 -
 arch/m68k/kernel/process.c      | 5 ++---
 arch/m68k/kernel/setup_mm.c     | 1 -
 arch/m68k/kernel/setup_no.c     | 1 -
 arch/m68k/mac/config.c          | 4 +++-
 6 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/m68k/emu/natfeat.c b/arch/m68k/emu/natfeat.c
index 71b78ecee75c..b19dc00026d9 100644
--- a/arch/m68k/emu/natfeat.c
+++ b/arch/m68k/emu/natfeat.c
@@ -15,6 +15,7 @@
 #include <linux/string.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/reboot.h>
 #include <linux/io.h>
 #include <asm/machdep.h>
 #include <asm/natfeat.h>
@@ -90,5 +91,5 @@ void __init nf_init(void)
 	pr_info("NatFeats found (%s, %lu.%lu)\n", buf, version >> 16,
 		version & 0xffff);
 
-	mach_power_off = nf_poweroff;
+	register_platform_power_off(nf_poweroff);
 }
diff --git a/arch/m68k/include/asm/machdep.h b/arch/m68k/include/asm/machdep.h
index 8fd80ef1b77e..8d8c3ee2069f 100644
--- a/arch/m68k/include/asm/machdep.h
+++ b/arch/m68k/include/asm/machdep.h
@@ -24,7 +24,6 @@ extern int (*mach_get_rtc_pll)(struct rtc_pll_info *);
 extern int (*mach_set_rtc_pll)(struct rtc_pll_info *);
 extern void (*mach_reset)( void );
 extern void (*mach_halt)( void );
-extern void (*mach_power_off)( void );
 extern unsigned long (*mach_hd_init) (unsigned long, unsigned long);
 extern void (*mach_hd_setup)(char *, int *);
 extern void (*mach_heartbeat) (int);
diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c
index a6030dbaa089..e160a7c57bd3 100644
--- a/arch/m68k/kernel/process.c
+++ b/arch/m68k/kernel/process.c
@@ -67,12 +67,11 @@ void machine_halt(void)
 
 void machine_power_off(void)
 {
-	if (mach_power_off)
-		mach_power_off();
+	do_kernel_power_off();
 	for (;;);
 }
 
-void (*pm_power_off)(void) = machine_power_off;
+void (*pm_power_off)(void);
 EXPORT_SYMBOL(pm_power_off);
 
 void show_regs(struct pt_regs * regs)
diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
index 8f94feed969c..47d55541612f 100644
--- a/arch/m68k/kernel/setup_mm.c
+++ b/arch/m68k/kernel/setup_mm.c
@@ -98,7 +98,6 @@ EXPORT_SYMBOL(mach_get_rtc_pll);
 EXPORT_SYMBOL(mach_set_rtc_pll);
 void (*mach_reset)( void );
 void (*mach_halt)( void );
-void (*mach_power_off)( void );
 #ifdef CONFIG_HEARTBEAT
 void (*mach_heartbeat) (int);
 EXPORT_SYMBOL(mach_heartbeat);
diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
index 5e4104f07a44..00bf82258233 100644
--- a/arch/m68k/kernel/setup_no.c
+++ b/arch/m68k/kernel/setup_no.c
@@ -55,7 +55,6 @@ int (*mach_hwclk) (int, struct rtc_time*);
 /* machine dependent reboot functions */
 void (*mach_reset)(void);
 void (*mach_halt)(void);
-void (*mach_power_off)(void);
 
 #ifdef CONFIG_M68000
 #if defined(CONFIG_M68328)
diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
index 65d124ec80bb..382f656c29ea 100644
--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -12,6 +12,7 @@
 
 #include <linux/errno.h>
 #include <linux/module.h>
+#include <linux/reboot.h>
 #include <linux/types.h>
 #include <linux/mm.h>
 #include <linux/tty.h>
@@ -140,7 +141,6 @@ void __init config_mac(void)
 	mach_hwclk = mac_hwclk;
 	mach_reset = mac_reset;
 	mach_halt = mac_poweroff;
-	mach_power_off = mac_poweroff;
 #if IS_ENABLED(CONFIG_INPUT_M68K_BEEP)
 	mach_beep = mac_mksound;
 #endif
@@ -160,6 +160,8 @@ void __init config_mac(void)
 
 	if (macintosh_config->ident == MAC_MODEL_IICI)
 		mach_l2_flush = via_l2_flush;
+
+	register_platform_power_off(mac_poweroff);
 }
 
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303307.517576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8oy-0001Qe-Fv; Tue, 12 Apr 2022 05:12:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303307.517576; Tue, 12 Apr 2022 05:12:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8ox-0001K5-8K; Tue, 12 Apr 2022 05:12:07 +0000
Received: by outflank-mailman (input) for mailman id 303307;
 Mon, 11 Apr 2022 23:39:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dN-0006oE-JJ
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:49 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id acfcb2e2-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:39:48 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id AD56B1F43D26
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: acfcb2e2-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720388;
	bh=GqegTH1d3tMqHPbUQWr88cV7jN0COVH27sIz9pT1gAo=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=oNiifi7dKhRBJqlGqEGJN6kAbfl8D4gCFwyVEi2cbtQeDKacFGHrwrDqFrDieN4wA
	 WhU41Hw3FPE2AYgfpN+3OIBTLyDM6SATFLFgianFO+wlHnAZJ7DQGXWLQfkL9dJkaT
	 mB39pfoWli1fA81DJ8zLGK9wjZabPOgGwSSryJ+aE2QaqRXwuzGuq7Z1JX90KJJAAn
	 BKO/88PeAen8MwGhUWEcBs8eDaefezxNcymSAruqMCHCNlKwOD7WTRW6jTC+W8qLzu
	 ZDQ/PYjaYqEgi+LYSYEmG3SZyxk7xquxfA6vSz5KC0WdP1SUt4TzNPONt3aIqIrOCj
	 2bJE2XBftWM2g==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 13/20] sh: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:25 +0300
Message-Id: <20220411233832.391817-14-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/sh/kernel/reboot.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/kernel/reboot.c b/arch/sh/kernel/reboot.c
index 5c33f036418b..e8eeedc9b182 100644
--- a/arch/sh/kernel/reboot.c
+++ b/arch/sh/kernel/reboot.c
@@ -46,8 +46,7 @@ static void native_machine_shutdown(void)
 
 static void native_machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 static void native_machine_halt(void)
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303309.517587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p0-0001qL-RZ; Tue, 12 Apr 2022 05:12:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303309.517587; Tue, 12 Apr 2022 05:12:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8oz-0001kP-AR; Tue, 12 Apr 2022 05:12:09 +0000
Received: by outflank-mailman (input) for mailman id 303309;
 Mon, 11 Apr 2022 23:39:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dR-0006ro-IH
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:53 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af60c11c-b9f0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 01:39:52 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id BFDD81F43D2C
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af60c11c-b9f0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720392;
	bh=8DI/pNc1jm1iacYnzYdS4F0mtDCAezqY1CKyhFh83pw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=fS0vsdoKA3qVdtkvxx6egdlyVBefRJJa46jHeytiuTAjNPQUBJMF62vPUdGtisFwS
	 qjzC5P4vm9t5HPl6XIK606FQTz2W1iczXe2hK1eUx5sJ8oPsz2i0llPMjwphKSznxD
	 yf+DUB+FsRolLvqURjnT0+EqjmQmrEN7Ddzm8dBJLMnAlTFqfSJBAq6HbPOxu03hKS
	 kVHAfsAgZcO/GIyeo95AaDCgaJEyINKOFXU5yKVE69NHRt4KmyfIjKBeZVC+A88xMt
	 6sOQ55lrq1POSM6qN3Jpff5rofgLRYh8EMxCe8D5kB1qjKD/WlIBuBKk37qrnk6rxr
	 AS5GTvCeO4CqA==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 14/20] x86: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:26 +0300
Message-Id: <20220411233832.391817-15-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/x86/kernel/reboot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index fa700b46588e..c3636ea4aa71 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -739,10 +739,10 @@ static void native_machine_halt(void)
 
 static void native_machine_power_off(void)
 {
-	if (pm_power_off) {
+	if (kernel_can_power_off()) {
 		if (!reboot_force)
 			machine_shutdown();
-		pm_power_off();
+		do_kernel_power_off();
 	}
 	/* A fallback in case there is no PM info available */
 	tboot_shutdown(TB_SHUTDOWN_HALT);
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303311.517598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p2-0002FL-D7; Tue, 12 Apr 2022 05:12:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303311.517598; Tue, 12 Apr 2022 05:12:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p0-000281-VG; Tue, 12 Apr 2022 05:12:11 +0000
Received: by outflank-mailman (input) for mailman id 303311;
 Mon, 11 Apr 2022 23:39:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dV-0006ro-KA
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:39:57 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b1c34ebe-b9f0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 01:39:56 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id C22131F43D41
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1c34ebe-b9f0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720396;
	bh=q9Yf4GNWQPgB4nxS09DeBdyHcEPdoAJWJbky4/Jndjk=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=je3kexK773qB+4WpfzyIaOS9CgDMJs107rHeLhbbXQaPz+2ZNqz8DsKQWs23dL/6w
	 aALYOeT9nixOO/CUWFE4fEDW+ZmLW8gn6Gfh+8qf8jH4kvav4N+gd3WoBnAsSrBfgz
	 HYoq1pOUkrElMMer+9+6WC8VG0ArCBAo4YPZjenknw80lsJRT8UeuUar7vprf/dtrc
	 2Juz+3EjLXTLUe8kIITLEyVn267yLf+8ZWtzKhly8RHfHmQK/b/owv6jZ5Y2HirTYT
	 s6amgwxvVYqfsPq9HkmgzjL/JhQgStFmW7KxiCeVTc56Fip0EJ8iqlHMojz/ZZWJWe
	 TvR0bqk4J0+yQ==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 15/20] ia64: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:27 +0300
Message-Id: <20220411233832.391817-16-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/ia64/kernel/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c
index d7a256bd9d6b..89025e3b3f61 100644
--- a/arch/ia64/kernel/process.c
+++ b/arch/ia64/kernel/process.c
@@ -19,6 +19,7 @@
 #include <linux/module.h>
 #include <linux/notifier.h>
 #include <linux/personality.h>
+#include <linux/reboot.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/hotplug.h>
@@ -599,8 +600,7 @@ machine_halt (void)
 void
 machine_power_off (void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	machine_halt();
 }
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303313.517607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p4-0002d7-RL; Tue, 12 Apr 2022 05:12:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303313.517607; Tue, 12 Apr 2022 05:12:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p3-0002VG-5d; Tue, 12 Apr 2022 05:12:13 +0000
Received: by outflank-mailman (input) for mailman id 303313;
 Mon, 11 Apr 2022 23:40:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dd-0006ro-Jf
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:40:05 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b69553ab-b9f0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 01:40:05 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id C54481F43D47
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b69553ab-b9f0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720404;
	bh=cnHjDAfLjeN/AIsHQIAOeHk5PbeJoiUi4VLInc7k0yc=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=N3hDoAur/4R+Ao3qbUrQ9sph7VfA2pPJkO49+7pzUDxKozw+TJHr9twtA1owBoHaK
	 jeJ6B07npfM+SylxlSqnME8JfVE2vevyxKZ9lTn4s9Qw9vx+X6hhDoouVhYJDq5apc
	 y7lsoKFIkiE0/+667mmNFPBQQ/5lfxEeBIQEc7C2QBX4hmq+L87GQYAfi2gzcxAGio
	 u+zbvkNur7jarlv+OuyEU/CSCUrFclTe1l/ZXiNfPE9aKi/UUzKTU/f1AmCalNxuAo
	 3xfp4XM4wHtnjC3ixsxh5HNKTfwCEN6VEvSBB5gq5BRCqg81jXfmgQzP5Ib+l0LREw
	 E3JVhJaC/Ac2Q==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 17/20] memory: emif: Use kernel_can_power_off()
Date: Tue, 12 Apr 2022 02:38:29 +0300
Message-Id: <20220411233832.391817-18-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Replace legacy pm_power_off with kernel_can_power_off() helper that
is aware about chained power-off handlers.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 drivers/memory/emif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index edf3ba7447ed..fa6845313a43 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
 		dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
 
 		/* If we have Power OFF ability, use it, else try restarting */
-		if (pm_power_off) {
+		if (kernel_can_power_off()) {
 			kernel_power_off();
 		} else {
 			WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303315.517618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p7-0003Db-Ai; Tue, 12 Apr 2022 05:12:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303315.517618; Tue, 12 Apr 2022 05:12:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p5-000339-GP; Tue, 12 Apr 2022 05:12:15 +0000
Received: by outflank-mailman (input) for mailman id 303315;
 Mon, 11 Apr 2022 23:40:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dh-0006ro-Qp
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:40:09 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b8fa5224-b9f0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 01:40:09 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id D94721F43D51
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8fa5224-b9f0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720408;
	bh=V6K3csETbdRArqsU2lL0TyRBTq4S5S8aBxupwY5Jatg=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=CMftO839VRrr32eH+lZu8ZOi1NbjfZFjDzrNLUXRDkPyP58z3IRG10vfZMM6I9C8p
	 837TKvbg42S+mJzZ0uqaB5Oc/1UA2hTbm5a8+rijfOJ+FIh/HPSjO05Hjo6b3xxoAW
	 lGvmRtC0fqPRPy2WlJd7rY0wK6gtLSVUfLBjC2jTcnF0w0W/A+IVqaNMQoQAZT4LDr
	 fQD0e+x43OZ7oZHP69IKlJDfA9+eXZHghwfPSfEIWkZPLn6n64VRF+szOOv/b5UQWx
	 6IVYXyx9++XM4pGMzqLsaonRUXt6Cwbeq6xKoRpIunoIcqWqnYG2rytrpY3Qp3f0bg
	 YaW5hzU2YodEA==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 18/20] ACPI: power: Switch to sys-off handler API
Date: Tue, 12 Apr 2022 02:38:30 +0300
Message-Id: <20220411233832.391817-19-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Switch to sys-off API that replaces legacy pm_power_off callbacks.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 drivers/acpi/sleep.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index c992e57b2c79..426297258e26 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -47,19 +47,11 @@ static void acpi_sleep_tts_switch(u32 acpi_state)
 	}
 }
 
-static int tts_notify_reboot(struct notifier_block *this,
-			unsigned long code, void *x)
+static void tts_reboot_prepare(struct reboot_prep_data *data)
 {
 	acpi_sleep_tts_switch(ACPI_STATE_S5);
-	return NOTIFY_DONE;
 }
 
-static struct notifier_block tts_notifier = {
-	.notifier_call	= tts_notify_reboot,
-	.next		= NULL,
-	.priority	= 0,
-};
-
 static int acpi_sleep_prepare(u32 acpi_state)
 {
 #ifdef CONFIG_ACPI_SLEEP
@@ -1023,7 +1015,7 @@ static void acpi_sleep_hibernate_setup(void)
 static inline void acpi_sleep_hibernate_setup(void) {}
 #endif /* !CONFIG_HIBERNATION */
 
-static void acpi_power_off_prepare(void)
+static void acpi_power_off_prepare(struct power_off_prep_data *data)
 {
 	/* Prepare to power off the system */
 	acpi_sleep_prepare(ACPI_STATE_S5);
@@ -1031,7 +1023,7 @@ static void acpi_power_off_prepare(void)
 	acpi_os_wait_events_complete();
 }
 
-static void acpi_power_off(void)
+static void acpi_power_off(struct power_off_data *data)
 {
 	/* acpi_sleep_prepare(ACPI_STATE_S5) should have already been called */
 	pr_debug("%s called\n", __func__);
@@ -1039,6 +1031,11 @@ static void acpi_power_off(void)
 	acpi_enter_sleep_state(ACPI_STATE_S5);
 }
 
+static struct sys_off_handler acpi_sys_off_handler = {
+	.power_off_priority = POWEROFF_PRIO_FIRMWARE,
+	.reboot_prepare_cb = tts_reboot_prepare,
+};
+
 int __init acpi_sleep_init(void)
 {
 	char supported[ACPI_S_STATE_COUNT * 3 + 1];
@@ -1055,8 +1052,8 @@ int __init acpi_sleep_init(void)
 
 	if (acpi_sleep_state_supported(ACPI_STATE_S5)) {
 		sleep_states[ACPI_STATE_S5] = 1;
-		pm_power_off_prepare = acpi_power_off_prepare;
-		pm_power_off = acpi_power_off;
+		acpi_sys_off_handler.power_off_cb = acpi_power_off;
+		acpi_sys_off_handler.power_off_prepare_cb = acpi_power_off_prepare;
 	} else {
 		acpi_no_s5 = true;
 	}
@@ -1072,6 +1069,6 @@ int __init acpi_sleep_init(void)
 	 * Register the tts_notifier to reboot notifier list so that the _TTS
 	 * object can also be evaluated when the system enters S5.
 	 */
-	register_reboot_notifier(&tts_notifier);
+	register_sys_off_handler(&acpi_sys_off_handler);
 	return 0;
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303317.517628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p9-0003mU-KH; Tue, 12 Apr 2022 05:12:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303317.517628; Tue, 12 Apr 2022 05:12:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8p7-0003dq-Ry; Tue, 12 Apr 2022 05:12:17 +0000
Received: by outflank-mailman (input) for mailman id 303317;
 Mon, 11 Apr 2022 23:41:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dZ-0006oE-LR
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:40:01 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk
 [2a00:1098:0:82:1000:25:2eeb:e3e3])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b429abee-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:40:01 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id C16F31F43D44
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b429abee-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720400;
	bh=tQBjrLc8wxDM/i52bUpXMeBe/Yyvxo9TnWn/cLTHgHQ=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=UkG7tcSwL+91g3dVfqEnPY3BuC71fVJElMqsfljBoKbyZADM1aklFPTybo4Yg/Sho
	 m1H9ejpSdOkWGU0WDyo+ejDP0+AWN8iLlx8aej6TjaLlhbeRjZhKn+mVxDsF00AdT6
	 GD71LDlNuOaEQ6Wg2bej41JN04RfNu1qafGZPu3z6U9Zy7WYCYx/OYXC4l6NzDw8fG
	 8JXkmUCmD6p9tsYvRq7TkB5WLA2gvNzOyALTkP3xqccJvx3C6460dShM7i36zJi1HJ
	 58I+BhUvpRHeCZfqxub8dMNc4jeg83wgps+KIWLm/iUHIlPtZWOlYdTWDl/M4yVzZN
	 k83/KXiUv8lzQ==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 16/20] mips: Use do_kernel_power_off()
Date: Tue, 12 Apr 2022 02:38:28 +0300
Message-Id: <20220411233832.391817-17-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 arch/mips/kernel/reset.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
index 6288780b779e..e7ce07b3e79b 100644
--- a/arch/mips/kernel/reset.c
+++ b/arch/mips/kernel/reset.c
@@ -114,8 +114,7 @@ void machine_halt(void)
 
 void machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 
 #ifdef CONFIG_SMP
 	preempt_disable();
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303318.517636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8pB-0004Hx-Ag; Tue, 12 Apr 2022 05:12:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303318.517636; Tue, 12 Apr 2022 05:12:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8pA-00047F-0B; Tue, 12 Apr 2022 05:12:20 +0000
Received: by outflank-mailman (input) for mailman id 303318;
 Mon, 11 Apr 2022 23:41:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dp-0006oE-QW
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:40:17 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bdd3f8ce-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:40:17 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id ECBE41F43D65
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bdd3f8ce-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720416;
	bh=iYfrEabh/hAGujUdJ+A/I+DmpedLWQ8gHOkzzfFNwA8=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=c1svoiAR7m0K6n7FtQj4RQRVEfLDNf+rwLT3neRX08SjGxKJYiC6HyM61WH9D/o3y
	 vAJO3f/Ys3tCCGTE9bmhQwmmHvzdi+chCvJXp1Npd/GlWrZMZHyViOEgNhsLyOJzTk
	 WaypFbLIoOXzHL4B5nWZOTZInVtzuAgZL1HRm6zaAYZPbJVUGS8V4EJ2Mc0SPMy0Sw
	 qJHgIWiLSIgASKFu7wMg0n4w6xwajTCa/N/m8HFcI9swRLPhXyd9bPMTdXw6j07VZa
	 h6Rg8HGTvAD0gX8doiBfJ8Letk7TvBw7eZK4sZ4E0EPUScPBbaZsR1J8aceqd22he4
	 YaYXWDOj7297Q==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 20/20] reboot: Remove pm_power_off_prepare()
Date: Tue, 12 Apr 2022 02:38:32 +0300
Message-Id: <20220411233832.391817-21-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

All pm_power_off_prepare() users were converted to sys-off handler API.
Remove the obsolete callback.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 include/linux/pm.h |  1 -
 kernel/reboot.c    | 11 -----------
 2 files changed, 12 deletions(-)

diff --git a/include/linux/pm.h b/include/linux/pm.h
index ffe941958501..6cdf279c7f2f 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -21,7 +21,6 @@
  * Callbacks for platform drivers to implement.
  */
 extern void (*pm_power_off)(void);
-extern void (*pm_power_off_prepare)(void);
 
 struct device; /* we have a circular dep with device.h */
 #ifdef CONFIG_VT_CONSOLE_SLEEP
diff --git a/kernel/reboot.c b/kernel/reboot.c
index e76e2570dcf5..f2f5c9d7caa0 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -48,13 +48,6 @@ int reboot_cpu;
 enum reboot_type reboot_type = BOOT_ACPI;
 int reboot_force;
 
-/*
- * If set, this is used for preparing the system to power off.
- */
-
-void (*pm_power_off_prepare)(void);
-EXPORT_SYMBOL_GPL(pm_power_off_prepare);
-
 /**
  *	emergency_restart - reboot the system
  *
@@ -877,10 +870,6 @@ void do_kernel_power_off(void)
 
 static void do_kernel_power_off_prepare(void)
 {
-	/* legacy pm_power_off_prepare() is unchained and has highest priority */
-	if (pm_power_off_prepare)
-		return pm_power_off_prepare();
-
 	blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE,
 				     NULL);
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303319.517648 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8pE-0004uk-3V; Tue, 12 Apr 2022 05:12:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303319.517648; Tue, 12 Apr 2022 05:12:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8pC-0004j4-Ec; Tue, 12 Apr 2022 05:12:22 +0000
Received: by outflank-mailman (input) for mailman id 303319;
 Mon, 11 Apr 2022 23:41:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9GfR=UV=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ne3dl-0006oE-Te
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 23:40:14 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb662b09-b9f0-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 01:40:13 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id D86491F43D58
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb662b09-b9f0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649720412;
	bh=hM34PKEn71kZ4xmXtCUPFr55eHz3/O1kuCmTOESUU4Y=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=PtPUJQlDJJ5rFuzVrYc+ESusSLLSHjZpdI9VFKwDgE+S5NJFGesj4Fc4uzYDZNjFE
	 Ocf1F6B6cNDijXJ8/rU+1itKUTFbA5k0hlMvClUxNU3r93u9bbCIlECnb3oK0D92VE
	 SmO2ItGQR3u4t4yU6MknssGmHsTeCAjU2I3E+avkHq/MTRdeRZ/rxlf8APJXUO/7bK
	 r60HG7usRXR0WITVJVWyXlqP8LliCU+Qfwy3xYSMvysUlHTbP4wCXc3foDBH00lfIw
	 n1XLBbyjWeLabI4Y6zfSOi7mGOmoxPMX56wdx1OGzy6vufi46SxqVuIBGfFcqihN3w
	 Oo5Wc9WAPzgqQ==
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v7 19/20] regulator: pfuze100: Use devm_register_sys_off_handler()
Date: Tue, 12 Apr 2022 02:38:31 +0300
Message-Id: <20220411233832.391817-20-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_sys_off_handler() that replaces global
pm_power_off_prepare variable and allows to register multiple
power-off handlers.

Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 drivers/regulator/pfuze100-regulator.c | 38 ++++++++++----------------
 1 file changed, 14 insertions(+), 24 deletions(-)

diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index d60d7d1b7fa2..2eca8d43a097 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -10,6 +10,7 @@
 #include <linux/of_device.h>
 #include <linux/regulator/of_regulator.h>
 #include <linux/platform_device.h>
+#include <linux/reboot.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
 #include <linux/regulator/pfuze100.h>
@@ -76,6 +77,7 @@ struct pfuze_chip {
 	struct pfuze_regulator regulator_descs[PFUZE100_MAX_REGULATOR];
 	struct regulator_dev *regulators[PFUZE100_MAX_REGULATOR];
 	struct pfuze_regulator *pfuze_regulators;
+	struct sys_off_handler sys_off;
 };
 
 static const int pfuze100_swbst[] = {
@@ -569,10 +571,10 @@ static inline struct device_node *match_of_node(int index)
 	return pfuze_matches[index].of_node;
 }
 
-static struct pfuze_chip *syspm_pfuze_chip;
-
-static void pfuze_power_off_prepare(void)
+static void pfuze_power_off_prepare(struct power_off_prep_data *data)
 {
+	struct pfuze_chip *syspm_pfuze_chip = data->cb_data;
+
 	dev_info(syspm_pfuze_chip->dev, "Configure standby mode for power off");
 
 	/* Switch from default mode: APS/APS to APS/Off */
@@ -611,24 +613,23 @@ static void pfuze_power_off_prepare(void)
 
 static int pfuze_power_off_prepare_init(struct pfuze_chip *pfuze_chip)
 {
+	int err;
+
 	if (pfuze_chip->chip_id != PFUZE100) {
 		dev_warn(pfuze_chip->dev, "Requested pm_power_off_prepare handler for not supported chip\n");
 		return -ENODEV;
 	}
 
-	if (pm_power_off_prepare) {
-		dev_warn(pfuze_chip->dev, "pm_power_off_prepare is already registered.\n");
-		return -EBUSY;
-	}
+	pfuze_chip->sys_off.power_off_prepare_cb = pfuze_power_off_prepare;
+	pfuze_chip->sys_off.cb_data = pfuze_chip;
 
-	if (syspm_pfuze_chip) {
-		dev_warn(pfuze_chip->dev, "syspm_pfuze_chip is already set.\n");
-		return -EBUSY;
+	err = devm_register_sys_off_handler(pfuze_chip->dev, &pfuze_chip->sys_off);
+	if (err) {
+		dev_err(pfuze_chip->dev,
+			"failed to register sys-off handler: %d\n", err);
+		return err;
 	}
 
-	syspm_pfuze_chip = pfuze_chip;
-	pm_power_off_prepare = pfuze_power_off_prepare;
-
 	return 0;
 }
 
@@ -837,23 +838,12 @@ static int pfuze100_regulator_probe(struct i2c_client *client,
 	return 0;
 }
 
-static int pfuze100_regulator_remove(struct i2c_client *client)
-{
-	if (syspm_pfuze_chip) {
-		syspm_pfuze_chip = NULL;
-		pm_power_off_prepare = NULL;
-	}
-
-	return 0;
-}
-
 static struct i2c_driver pfuze_driver = {
 	.driver = {
 		.name = "pfuze100-regulator",
 		.of_match_table = pfuze_dt_ids,
 	},
 	.probe = pfuze100_regulator_probe,
-	.remove = pfuze100_regulator_remove,
 };
 module_i2c_driver(pfuze_driver);
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 05:12:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 05:12:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303225.517689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8pP-0008Cz-75; Tue, 12 Apr 2022 05:12:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303225.517689; Tue, 12 Apr 2022 05:12:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne8pP-0008CG-0k; Tue, 12 Apr 2022 05:12:35 +0000
Received: by outflank-mailman (input) for mailman id 303225;
 Mon, 11 Apr 2022 18:24:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fphr=UV=kernel.org=jaegeuk@srs-se1.protection.inumbo.net>)
 id 1ndyiM-0000kr-Rt
 for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 18:24:39 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a43b0717-b9c4-11ec-a405-831a346695d4;
 Mon, 11 Apr 2022 20:24:36 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 5ED7AB81837;
 Mon, 11 Apr 2022 18:24:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F1E8C385A3;
 Mon, 11 Apr 2022 18:24:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a43b0717-b9c4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649701474;
	bh=iljW5HaH5C1aX67GTeOn1F4JvJ4Oh3yZRImg0BiUl6o=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=g9iOKa2O0vWv/OZ/uW5VtoGqPLyzE7Z/fUZ19V97FIq90sSFXrBCEZxSyrUHPbWrc
	 AfwyyjrkINZAGrVCEViKzvvXoBtu+BYFhM03vBASISH3kQ0KBzl6p8HK8eQIYldSb4
	 wr6/RWocuGrQ7HL8lSsop+TfbRVYcl9oFVdQNVTMuOq3534+aiIvnN6pbDzz3h2SsP
	 KhoRsxcPNz3BR8CJHLLdAupEbb4531mQ+HYUE2hJit5Pshq5fC5Ls7a51VxgojFkG1
	 naenyRWLDuTHOc/ksD+XFBqda+wlXww3amnGVZmU0KFBsTXkwzrxV81ZRIwexbThEP
	 PQBjzfRLRBxzw==
Date: Mon, 11 Apr 2022 11:24:31 -0700
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, jfs-discussion@lists.sourceforge.net,
	linux-nvme@lists.infradead.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	dm-devel@redhat.com, target-devel@vger.kernel.org,
	linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
	linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
	linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
	xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
	linux-um@lists.infradead.org, nbd@other.debian.org,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
	linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE
 from REQ_OP_DISCARD
Message-ID: <YlRyX6nFldat+VSH@google.com>
References: <20220406060516.409838-1-hch@lst.de>
 <20220406060516.409838-27-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220406060516.409838-27-hch@lst.de>

On 04/06, Christoph Hellwig wrote:
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint.  Fully split the limits and helper
> infrastructure to make the separation more clear.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/blk-core.c                    |  2 +-
>  block/blk-lib.c                     | 64 ++++++++++++++++++++---------
>  block/blk-mq-debugfs.c              |  1 -
>  block/blk-settings.c                | 16 +++++++-
>  block/fops.c                        |  2 +-
>  block/ioctl.c                       | 43 +++++++++++++++----
>  drivers/block/drbd/drbd_receiver.c  |  5 ++-
>  drivers/block/rnbd/rnbd-clt.c       |  4 +-
>  drivers/block/rnbd/rnbd-srv-dev.h   |  2 +-
>  drivers/block/xen-blkback/blkback.c | 15 +++----
>  drivers/block/xen-blkback/xenbus.c  |  5 +--
>  drivers/block/xen-blkfront.c        |  5 ++-
>  drivers/md/bcache/alloc.c           |  2 +-
>  drivers/md/dm-table.c               |  8 ++--
>  drivers/md/dm-thin.c                |  4 +-
>  drivers/md/md.c                     |  2 +-
>  drivers/md/raid5-cache.c            |  6 +--
>  drivers/mmc/core/queue.c            |  2 +-
>  drivers/nvme/target/io-cmd-bdev.c   |  2 +-
>  drivers/target/target_core_file.c   |  2 +-
>  drivers/target/target_core_iblock.c |  2 +-
>  fs/btrfs/extent-tree.c              |  4 +-
>  fs/ext4/mballoc.c                   |  2 +-
>  fs/f2fs/file.c                      | 16 ++++----
>  fs/f2fs/segment.c                   |  2 +-

For f2fs,

Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>

Thank you,

>  fs/jbd2/journal.c                   |  2 +-
>  fs/nilfs2/sufile.c                  |  4 +-
>  fs/nilfs2/the_nilfs.c               |  4 +-
>  fs/ntfs3/super.c                    |  2 +-
>  fs/xfs/xfs_discard.c                |  2 +-
>  fs/xfs/xfs_log_cil.c                |  2 +-
>  include/linux/blkdev.h              | 27 +++++++-----
>  mm/swapfile.c                       |  6 +--
>  33 files changed, 168 insertions(+), 99 deletions(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index b5c3a8049134c..ee18b6a699bdf 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -824,7 +824,7 @@ void submit_bio_noacct(struct bio *bio)
>  			goto not_supported;
>  		break;
>  	case REQ_OP_SECURE_ERASE:
> -		if (!blk_queue_secure_erase(q))
> +		if (!bdev_max_secure_erase_sectors(bdev))
>  			goto not_supported;
>  		break;
>  	case REQ_OP_ZONE_APPEND:
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 43aa4d7fe859f..09b7e1200c0f4 100644
> --- a/block/blk-lib.c
> +++ b/block/blk-lib.c
> @@ -36,26 +36,15 @@ static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
>  }
>  
>  int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -		sector_t nr_sects, gfp_t gfp_mask, int flags,
> -		struct bio **biop)
> +		sector_t nr_sects, gfp_t gfp_mask, struct bio **biop)
>  {
> -	struct request_queue *q = bdev_get_queue(bdev);
>  	struct bio *bio = *biop;
> -	unsigned int op;
>  	sector_t bs_mask;
>  
>  	if (bdev_read_only(bdev))
>  		return -EPERM;
> -
> -	if (flags & BLKDEV_DISCARD_SECURE) {
> -		if (!blk_queue_secure_erase(q))
> -			return -EOPNOTSUPP;
> -		op = REQ_OP_SECURE_ERASE;
> -	} else {
> -		if (!bdev_max_discard_sectors(bdev))
> -			return -EOPNOTSUPP;
> -		op = REQ_OP_DISCARD;
> -	}
> +	if (!bdev_max_discard_sectors(bdev))
> +		return -EOPNOTSUPP;
>  
>  	/* In case the discard granularity isn't set by buggy device driver */
>  	if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
> @@ -77,7 +66,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
>  		sector_t req_sects =
>  			min(nr_sects, bio_discard_limit(bdev, sector));
>  
> -		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
> +		bio = blk_next_bio(bio, bdev, 0, REQ_OP_DISCARD, gfp_mask);
>  		bio->bi_iter.bi_sector = sector;
>  		bio->bi_iter.bi_size = req_sects << 9;
>  		sector += req_sects;
> @@ -103,21 +92,19 @@ EXPORT_SYMBOL(__blkdev_issue_discard);
>   * @sector:	start sector
>   * @nr_sects:	number of sectors to discard
>   * @gfp_mask:	memory allocation flags (for bio_alloc)
> - * @flags:	BLKDEV_DISCARD_* flags to control behaviour
>   *
>   * Description:
>   *    Issue a discard request for the sectors in question.
>   */
>  int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags)
> +		sector_t nr_sects, gfp_t gfp_mask)
>  {
>  	struct bio *bio = NULL;
>  	struct blk_plug plug;
>  	int ret;
>  
>  	blk_start_plug(&plug);
> -	ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, flags,
> -			&bio);
> +	ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, &bio);
>  	if (!ret && bio) {
>  		ret = submit_bio_wait(bio);
>  		if (ret == -EOPNOTSUPP)
> @@ -314,3 +301,42 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
>  	return ret;
>  }
>  EXPORT_SYMBOL(blkdev_issue_zeroout);
> +
> +int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
> +		sector_t nr_sects, gfp_t gfp)
> +{
> +	sector_t bs_mask = (bdev_logical_block_size(bdev) >> 9) - 1;
> +	unsigned int max_sectors = bdev_max_secure_erase_sectors(bdev);
> +	struct bio *bio = NULL;
> +	struct blk_plug plug;
> +	int ret = 0;
> +
> +	if (max_sectors == 0)
> +		return -EOPNOTSUPP;
> +	if ((sector | nr_sects) & bs_mask)
> +		return -EINVAL;
> +	if (bdev_read_only(bdev))
> +		return -EPERM;
> +
> +	blk_start_plug(&plug);
> +	for (;;) {
> +		unsigned int len = min_t(sector_t, nr_sects, max_sectors);
> +
> +		bio = blk_next_bio(bio, bdev, 0, REQ_OP_SECURE_ERASE, gfp);
> +		bio->bi_iter.bi_sector = sector;
> +		bio->bi_iter.bi_size = len;
> +
> +		sector += len << SECTOR_SHIFT;
> +		nr_sects -= len << SECTOR_SHIFT;
> +		if (!nr_sects) {
> +			ret = submit_bio_wait(bio);
> +			bio_put(bio);
> +			break;
> +		}
> +		cond_resched();
> +	}
> +	blk_finish_plug(&plug);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL(blkdev_issue_secure_erase);
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index fd111c5001256..7e4136a60e1cc 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -115,7 +115,6 @@ static const char *const blk_queue_flag_name[] = {
>  	QUEUE_FLAG_NAME(IO_STAT),
>  	QUEUE_FLAG_NAME(NOXMERGES),
>  	QUEUE_FLAG_NAME(ADD_RANDOM),
> -	QUEUE_FLAG_NAME(SECERASE),
>  	QUEUE_FLAG_NAME(SAME_FORCE),
>  	QUEUE_FLAG_NAME(DEAD),
>  	QUEUE_FLAG_NAME(INIT_DONE),
> diff --git a/block/blk-settings.c b/block/blk-settings.c
> index fd83d674afd0a..6ccceb421ed2f 100644
> --- a/block/blk-settings.c
> +++ b/block/blk-settings.c
> @@ -46,6 +46,7 @@ void blk_set_default_limits(struct queue_limits *lim)
>  	lim->max_zone_append_sectors = 0;
>  	lim->max_discard_sectors = 0;
>  	lim->max_hw_discard_sectors = 0;
> +	lim->max_secure_erase_sectors = 0;
>  	lim->discard_granularity = 0;
>  	lim->discard_alignment = 0;
>  	lim->discard_misaligned = 0;
> @@ -176,6 +177,18 @@ void blk_queue_max_discard_sectors(struct request_queue *q,
>  }
>  EXPORT_SYMBOL(blk_queue_max_discard_sectors);
>  
> +/**
> + * blk_queue_max_secure_erase_sectors - set max sectors for a secure erase
> + * @q:  the request queue for the device
> + * @max_sectors: maximum number of sectors to secure_erase
> + **/
> +void blk_queue_max_secure_erase_sectors(struct request_queue *q,
> +		unsigned int max_sectors)
> +{
> +	q->limits.max_secure_erase_sectors = max_sectors;
> +}
> +EXPORT_SYMBOL(blk_queue_max_secure_erase_sectors);
> +
>  /**
>   * blk_queue_max_write_zeroes_sectors - set max sectors for a single
>   *                                      write zeroes
> @@ -661,7 +674,8 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
>  		t->discard_alignment = lcm_not_zero(t->discard_alignment, alignment) %
>  			t->discard_granularity;
>  	}
> -
> +	t->max_secure_erase_sectors = min_not_zero(t->max_secure_erase_sectors,
> +						   b->max_secure_erase_sectors);
>  	t->zone_write_granularity = max(t->zone_write_granularity,
>  					b->zone_write_granularity);
>  	t->zoned = max(t->zoned, b->zoned);
> diff --git a/block/fops.c b/block/fops.c
> index 9f2ecec406b04..c0ca3254d38cf 100644
> --- a/block/fops.c
> +++ b/block/fops.c
> @@ -672,7 +672,7 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
>  		break;
>  	case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE:
>  		error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT,
> -					     len >> SECTOR_SHIFT, GFP_KERNEL, 0);
> +					     len >> SECTOR_SHIFT, GFP_KERNEL);
>  		break;
>  	default:
>  		error = -EOPNOTSUPP;
> diff --git a/block/ioctl.c b/block/ioctl.c
> index c2cd3ba5290ce..5b5027fa78f7e 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -83,7 +83,7 @@ static int compat_blkpg_ioctl(struct block_device *bdev,
>  #endif
>  
>  static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
> -		unsigned long arg, unsigned long flags)
> +		unsigned long arg)
>  {
>  	uint64_t range[2];
>  	uint64_t start, len;
> @@ -114,15 +114,43 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
>  	err = truncate_bdev_range(bdev, mode, start, start + len - 1);
>  	if (err)
>  		goto fail;
> -
> -	err = blkdev_issue_discard(bdev, start >> 9, len >> 9,
> -				   GFP_KERNEL, flags);
> -
> +	err = blkdev_issue_discard(bdev, start >> 9, len >> 9, GFP_KERNEL);
>  fail:
>  	filemap_invalidate_unlock(inode->i_mapping);
>  	return err;
>  }
>  
> +static int blk_ioctl_secure_erase(struct block_device *bdev, fmode_t mode,
> +		void __user *argp)
> +{
> +	uint64_t start, len;
> +	uint64_t range[2];
> +	int err;
> +
> +	if (!(mode & FMODE_WRITE))
> +		return -EBADF;
> +	if (!bdev_max_secure_erase_sectors(bdev))
> +		return -EOPNOTSUPP;
> +	if (copy_from_user(range, argp, sizeof(range)))
> +		return -EFAULT;
> +
> +	start = range[0];
> +	len = range[1];
> +	if ((start & 511) || (len & 511))
> +		return -EINVAL;
> +	if (start + len > bdev_nr_bytes(bdev))
> +		return -EINVAL;
> +
> +	filemap_invalidate_lock(bdev->bd_inode->i_mapping);
> +	err = truncate_bdev_range(bdev, mode, start, start + len - 1);
> +	if (!err)
> +		err = blkdev_issue_secure_erase(bdev, start >> 9, len >> 9,
> +						GFP_KERNEL);
> +	filemap_invalidate_unlock(bdev->bd_inode->i_mapping);
> +	return err;
> +}
> +
> +
>  static int blk_ioctl_zeroout(struct block_device *bdev, fmode_t mode,
>  		unsigned long arg)
>  {
> @@ -450,10 +478,9 @@ static int blkdev_common_ioctl(struct block_device *bdev, fmode_t mode,
>  	case BLKROSET:
>  		return blkdev_roset(bdev, mode, cmd, arg);
>  	case BLKDISCARD:
> -		return blk_ioctl_discard(bdev, mode, arg, 0);
> +		return blk_ioctl_discard(bdev, mode, arg);
>  	case BLKSECDISCARD:
> -		return blk_ioctl_discard(bdev, mode, arg,
> -				BLKDEV_DISCARD_SECURE);
> +		return blk_ioctl_secure_erase(bdev, mode, argp);
>  	case BLKZEROOUT:
>  		return blk_ioctl_zeroout(bdev, mode, arg);
>  	case BLKGETDISKSEQ:
> diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
> index 275c53c7b629e..2957b0b68d600 100644
> --- a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -1547,7 +1547,8 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
>  		start = tmp;
>  	}
>  	while (nr_sectors >= max_discard_sectors) {
> -		err |= blkdev_issue_discard(bdev, start, max_discard_sectors, GFP_NOIO, 0);
> +		err |= blkdev_issue_discard(bdev, start, max_discard_sectors,
> +					    GFP_NOIO);
>  		nr_sectors -= max_discard_sectors;
>  		start += max_discard_sectors;
>  	}
> @@ -1559,7 +1560,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
>  		nr = nr_sectors;
>  		nr -= (unsigned int)nr % granularity;
>  		if (nr) {
> -			err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO, 0);
> +			err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO);
>  			nr_sectors -= nr;
>  			start += nr;
>  		}
> diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
> index efa99a3884507..d178be175ad99 100644
> --- a/drivers/block/rnbd/rnbd-clt.c
> +++ b/drivers/block/rnbd/rnbd-clt.c
> @@ -1365,8 +1365,8 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
>  	dev->queue->limits.discard_granularity	= dev->discard_granularity;
>  	dev->queue->limits.discard_alignment	= dev->discard_alignment;
>  	if (dev->secure_discard)
> -		blk_queue_flag_set(QUEUE_FLAG_SECERASE, dev->queue);
> -
> +		blk_queue_max_secure_erase_sectors(dev->queue,
> +				dev->max_discard_sectors);
>  	blk_queue_flag_set(QUEUE_FLAG_SAME_COMP, dev->queue);
>  	blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue);
>  	blk_queue_max_segments(dev->queue, dev->max_segments);
> diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
> index 1f7e1c8fd4d9b..d080a0de59225 100644
> --- a/drivers/block/rnbd/rnbd-srv-dev.h
> +++ b/drivers/block/rnbd/rnbd-srv-dev.h
> @@ -44,7 +44,7 @@ static inline int rnbd_dev_get_max_hw_sects(const struct rnbd_dev *dev)
>  
>  static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
>  {
> -	return blk_queue_secure_erase(bdev_get_queue(dev->bdev));
> +	return bdev_max_secure_erase_sectors(dev->bdev);
>  }
>  
>  static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
> diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
> index de42458195bc1..a97f2bf5b01b9 100644
> --- a/drivers/block/xen-blkback/blkback.c
> +++ b/drivers/block/xen-blkback/blkback.c
> @@ -970,7 +970,6 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
>  	int status = BLKIF_RSP_OKAY;
>  	struct xen_blkif *blkif = ring->blkif;
>  	struct block_device *bdev = blkif->vbd.bdev;
> -	unsigned long secure;
>  	struct phys_req preq;
>  
>  	xen_blkif_get(blkif);
> @@ -987,13 +986,15 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
>  	}
>  	ring->st_ds_req++;
>  
> -	secure = (blkif->vbd.discard_secure &&
> -		 (req->u.discard.flag & BLKIF_DISCARD_SECURE)) ?
> -		 BLKDEV_DISCARD_SECURE : 0;
> +	if (blkif->vbd.discard_secure &&
> +	    (req->u.discard.flag & BLKIF_DISCARD_SECURE))
> +		err = blkdev_issue_secure_erase(bdev,
> +				req->u.discard.sector_number,
> +				req->u.discard.nr_sectors, GFP_KERNEL);
> +	else
> +		err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
> +				req->u.discard.nr_sectors, GFP_KERNEL);
>  
> -	err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
> -				   req->u.discard.nr_sectors,
> -				   GFP_KERNEL, secure);
>  fail_response:
>  	if (err == -EOPNOTSUPP) {
>  		pr_debug("discard op failed, not supported\n");
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index 83cd08041e6b3..b21bffc9c50bc 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -484,7 +484,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
>  {
>  	struct xen_vbd *vbd;
>  	struct block_device *bdev;
> -	struct request_queue *q;
>  
>  	vbd = &blkif->vbd;
>  	vbd->handle   = handle;
> @@ -516,11 +515,9 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
>  	if (vbd->bdev->bd_disk->flags & GENHD_FL_REMOVABLE)
>  		vbd->type |= VDISK_REMOVABLE;
>  
> -	q = bdev_get_queue(bdev);
>  	if (bdev_write_cache(bdev))
>  		vbd->flush_support = true;
> -
> -	if (q && blk_queue_secure_erase(q))
> +	if (bdev_max_secure_erase_sectors(bdev))
>  		vbd->discard_secure = true;
>  
>  	vbd->feature_gnt_persistent = feature_persistent;
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 253bf835aca1f..9fb7c69f72b2d 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -949,7 +949,8 @@ static void blkif_set_queue_limits(struct blkfront_info *info)
>  						 info->physical_sector_size;
>  		rq->limits.discard_alignment = info->discard_alignment;
>  		if (info->feature_secdiscard)
> -			blk_queue_flag_set(QUEUE_FLAG_SECERASE, rq);
> +			blk_queue_max_secure_erase_sectors(rq,
> +							   get_capacity(gd));
>  	}
>  
>  	/* Hard sector size and max sectors impersonate the equiv. hardware. */
> @@ -1605,7 +1606,7 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
>  				blkif_req(req)->error = BLK_STS_NOTSUPP;
>  				info->feature_discard = 0;
>  				info->feature_secdiscard = 0;
> -				blk_queue_flag_clear(QUEUE_FLAG_SECERASE, rq);
> +				blk_queue_max_secure_erase_sectors(rq, 0);
>  			}
>  			break;
>  		case BLKIF_OP_FLUSH_DISKCACHE:
> diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
> index 097577ae3c471..ce13c272c3872 100644
> --- a/drivers/md/bcache/alloc.c
> +++ b/drivers/md/bcache/alloc.c
> @@ -336,7 +336,7 @@ static int bch_allocator_thread(void *arg)
>  				mutex_unlock(&ca->set->bucket_lock);
>  				blkdev_issue_discard(ca->bdev,
>  					bucket_to_sector(ca->set, bucket),
> -					ca->sb.bucket_size, GFP_KERNEL, 0);
> +					ca->sb.bucket_size, GFP_KERNEL);
>  				mutex_lock(&ca->set->bucket_lock);
>  			}
>  
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index 0dff6907fd00d..e7d42f6335a2a 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -1920,9 +1920,7 @@ static int device_not_secure_erase_capable(struct dm_target *ti,
>  					   struct dm_dev *dev, sector_t start,
>  					   sector_t len, void *data)
>  {
> -	struct request_queue *q = bdev_get_queue(dev->bdev);
> -
> -	return !blk_queue_secure_erase(q);
> +	return !bdev_max_secure_erase_sectors(dev->bdev);
>  }
>  
>  static bool dm_table_supports_secure_erase(struct dm_table *t)
> @@ -1975,8 +1973,8 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
>  		q->limits.discard_misaligned = 0;
>  	}
>  
> -	if (dm_table_supports_secure_erase(t))
> -		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
> +	if (!dm_table_supports_secure_erase(t))
> +		q->limits.max_secure_erase_sectors = 0;
>  
>  	if (dm_table_supports_flush(t, (1UL << QUEUE_FLAG_WC))) {
>  		wc = true;
> diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
> index eded4bcc4545f..84c083f766736 100644
> --- a/drivers/md/dm-thin.c
> +++ b/drivers/md/dm-thin.c
> @@ -398,8 +398,8 @@ static int issue_discard(struct discard_op *op, dm_block_t data_b, dm_block_t da
>  	sector_t s = block_to_sectors(tc->pool, data_b);
>  	sector_t len = block_to_sectors(tc->pool, data_e - data_b);
>  
> -	return __blkdev_issue_discard(tc->pool_dev->bdev, s, len,
> -				      GFP_NOWAIT, 0, &op->bio);
> +	return __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOWAIT,
> +				      &op->bio);
>  }
>  
>  static void end_discard(struct discard_op *op, int r)
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 19636c2f2cda4..2587f872c0884 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -8584,7 +8584,7 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
>  {
>  	struct bio *discard_bio = NULL;
>  
> -	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, 0,
> +	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,
>  			&discard_bio) || !discard_bio)
>  		return;
>  
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index c3cbf9a574a39..094a4042589eb 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1344,14 +1344,14 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
>  	if (log->last_checkpoint < end) {
>  		blkdev_issue_discard(bdev,
>  				log->last_checkpoint + log->rdev->data_offset,
> -				end - log->last_checkpoint, GFP_NOIO, 0);
> +				end - log->last_checkpoint, GFP_NOIO);
>  	} else {
>  		blkdev_issue_discard(bdev,
>  				log->last_checkpoint + log->rdev->data_offset,
>  				log->device_size - log->last_checkpoint,
> -				GFP_NOIO, 0);
> +				GFP_NOIO);
>  		blkdev_issue_discard(bdev, log->rdev->data_offset, end,
> -				GFP_NOIO, 0);
> +				GFP_NOIO);
>  	}
>  }
>  
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index cac6315010a3d..a3d4460055716 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -189,7 +189,7 @@ static void mmc_queue_setup_discard(struct request_queue *q,
>  	if (card->pref_erase > max_discard)
>  		q->limits.discard_granularity = SECTOR_SIZE;
>  	if (mmc_can_secure_erase_trim(card))
> -		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
> +		blk_queue_max_secure_erase_sectors(q, max_discard);
>  }
>  
>  static unsigned short mmc_get_max_segments(struct mmc_host *host)
> diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
> index d886c2c59554f..27a72504d31ce 100644
> --- a/drivers/nvme/target/io-cmd-bdev.c
> +++ b/drivers/nvme/target/io-cmd-bdev.c
> @@ -360,7 +360,7 @@ static u16 nvmet_bdev_discard_range(struct nvmet_req *req,
>  	ret = __blkdev_issue_discard(ns->bdev,
>  			nvmet_lba_to_sect(ns, range->slba),
>  			le32_to_cpu(range->nlb) << (ns->blksize_shift - 9),
> -			GFP_KERNEL, 0, bio);
> +			GFP_KERNEL, bio);
>  	if (ret && ret != -EOPNOTSUPP) {
>  		req->error_slba = le64_to_cpu(range->slba);
>  		return errno_to_nvme_status(req, ret);
> diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
> index b6ba582b06775..e68f1cc8ef98b 100644
> --- a/drivers/target/target_core_file.c
> +++ b/drivers/target/target_core_file.c
> @@ -558,7 +558,7 @@ fd_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
>  		ret = blkdev_issue_discard(bdev,
>  					   target_to_linux_sector(dev, lba),
>  					   target_to_linux_sector(dev,  nolb),
> -					   GFP_KERNEL, 0);
> +					   GFP_KERNEL);
>  		if (ret < 0) {
>  			pr_warn("FILEIO: blkdev_issue_discard() failed: %d\n",
>  				ret);
> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index c4a903b8a47fc..378c80313a0f2 100644
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -434,7 +434,7 @@ iblock_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
>  	ret = blkdev_issue_discard(bdev,
>  				   target_to_linux_sector(dev, lba),
>  				   target_to_linux_sector(dev,  nolb),
> -				   GFP_KERNEL, 0);
> +				   GFP_KERNEL);
>  	if (ret < 0) {
>  		pr_err("blkdev_issue_discard() failed: %d\n", ret);
>  		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index efd8deb3ab7e8..5c1d3a564da5a 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -1239,7 +1239,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
>  
>  		if (size) {
>  			ret = blkdev_issue_discard(bdev, start >> 9, size >> 9,
> -						   GFP_NOFS, 0);
> +						   GFP_NOFS);
>  			if (!ret)
>  				*discarded_bytes += size;
>  			else if (ret != -EOPNOTSUPP)
> @@ -1256,7 +1256,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
>  
>  	if (bytes_left) {
>  		ret = blkdev_issue_discard(bdev, start >> 9, bytes_left >> 9,
> -					   GFP_NOFS, 0);
> +					   GFP_NOFS);
>  		if (!ret)
>  			*discarded_bytes += bytes_left;
>  	}
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 6d1820536d88d..ea653d19f9ec7 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -3629,7 +3629,7 @@ static inline int ext4_issue_discard(struct super_block *sb,
>  		return __blkdev_issue_discard(sb->s_bdev,
>  			(sector_t)discard_block << (sb->s_blocksize_bits - 9),
>  			(sector_t)count << (sb->s_blocksize_bits - 9),
> -			GFP_NOFS, 0, biop);
> +			GFP_NOFS, biop);
>  	} else
>  		return sb_issue_discard(sb, discard_block, count, GFP_NOFS, 0);
>  }
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 8053d99f3920b..35b6c720c2bc1 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -3685,18 +3685,18 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg)
>  static int f2fs_secure_erase(struct block_device *bdev, struct inode *inode,
>  		pgoff_t off, block_t block, block_t len, u32 flags)
>  {
> -	struct request_queue *q = bdev_get_queue(bdev);
>  	sector_t sector = SECTOR_FROM_BLOCK(block);
>  	sector_t nr_sects = SECTOR_FROM_BLOCK(len);
>  	int ret = 0;
>  
> -	if (!q)
> -		return -ENXIO;
> -
> -	if (flags & F2FS_TRIM_FILE_DISCARD)
> -		ret = blkdev_issue_discard(bdev, sector, nr_sects, GFP_NOFS,
> -						blk_queue_secure_erase(q) ?
> -						BLKDEV_DISCARD_SECURE : 0);
> +	if (flags & F2FS_TRIM_FILE_DISCARD) {
> +		if (bdev_max_secure_erase_sectors(bdev))
> +			ret = blkdev_issue_secure_erase(bdev, sector, nr_sects,
> +					GFP_NOFS);
> +		else
> +			ret = blkdev_issue_discard(bdev, sector, nr_sects,
> +					GFP_NOFS);
> +	}
>  
>  	if (!ret && (flags & F2FS_TRIM_FILE_ZEROOUT)) {
>  		if (IS_ENCRYPTED(inode))
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 71f09adbcba86..e433c61e64b93 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1244,7 +1244,7 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
>  		err = __blkdev_issue_discard(bdev,
>  					SECTOR_FROM_BLOCK(start),
>  					SECTOR_FROM_BLOCK(len),
> -					GFP_NOFS, 0, &bio);
> +					GFP_NOFS, &bio);
>  submit:
>  		if (err) {
>  			spin_lock_irqsave(&dc->lock, flags);
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 19d226cd4ff4d..c0cbeeaec2d1a 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1825,7 +1825,7 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
>  			err = blkdev_issue_discard(journal->j_dev,
>  					byte_start >> SECTOR_SHIFT,
>  					byte_count >> SECTOR_SHIFT,
> -					GFP_NOFS, 0);
> +					GFP_NOFS);
>  		} else if (flags & JBD2_JOURNAL_FLUSH_ZEROOUT) {
>  			err = blkdev_issue_zeroout(journal->j_dev,
>  					byte_start >> SECTOR_SHIFT,
> diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c
> index e385cca2004a7..77ff8e95421fa 100644
> --- a/fs/nilfs2/sufile.c
> +++ b/fs/nilfs2/sufile.c
> @@ -1100,7 +1100,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
>  				ret = blkdev_issue_discard(nilfs->ns_bdev,
>  						start * sects_per_block,
>  						nblocks * sects_per_block,
> -						GFP_NOFS, 0);
> +						GFP_NOFS);
>  				if (ret < 0) {
>  					put_bh(su_bh);
>  					goto out_sem;
> @@ -1134,7 +1134,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
>  			ret = blkdev_issue_discard(nilfs->ns_bdev,
>  					start * sects_per_block,
>  					nblocks * sects_per_block,
> -					GFP_NOFS, 0);
> +					GFP_NOFS);
>  			if (!ret)
>  				ndiscarded += nblocks;
>  		}
> diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c
> index dd48a8f74d577..3b4a079c9617c 100644
> --- a/fs/nilfs2/the_nilfs.c
> +++ b/fs/nilfs2/the_nilfs.c
> @@ -672,7 +672,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
>  			ret = blkdev_issue_discard(nilfs->ns_bdev,
>  						   start * sects_per_block,
>  						   nblocks * sects_per_block,
> -						   GFP_NOFS, 0);
> +						   GFP_NOFS);
>  			if (ret < 0)
>  				return ret;
>  			nblocks = 0;
> @@ -682,7 +682,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
>  		ret = blkdev_issue_discard(nilfs->ns_bdev,
>  					   start * sects_per_block,
>  					   nblocks * sects_per_block,
> -					   GFP_NOFS, 0);
> +					   GFP_NOFS);
>  	return ret;
>  }
>  
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index 5f2e414cfa79b..5781b9e8e3d85 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -1333,7 +1333,7 @@ int ntfs_discard(struct ntfs_sb_info *sbi, CLST lcn, CLST len)
>  		return 0;
>  
>  	err = blkdev_issue_discard(sb->s_bdev, start >> 9, (end - start) >> 9,
> -				   GFP_NOFS, 0);
> +				   GFP_NOFS);
>  
>  	if (err == -EOPNOTSUPP)
>  		sbi->flags |= NTFS_FLAGS_NODISCARD;
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index e2ada115c23f9..c6fe3f6ebb6b0 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -114,7 +114,7 @@ xfs_trim_extents(
>  		}
>  
>  		trace_xfs_discard_extent(mp, agno, fbno, flen);
> -		error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS, 0);
> +		error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS);
>  		if (error)
>  			goto out_del_cursor;
>  		*blocks_trimmed += flen;
> diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
> index ba57323bfdcea..c9f55e4f09571 100644
> --- a/fs/xfs/xfs_log_cil.c
> +++ b/fs/xfs/xfs_log_cil.c
> @@ -605,7 +605,7 @@ xlog_discard_busy_extents(
>  		error = __blkdev_issue_discard(mp->m_ddev_targp->bt_bdev,
>  				XFS_AGB_TO_DADDR(mp, busyp->agno, busyp->bno),
>  				XFS_FSB_TO_BB(mp, busyp->length),
> -				GFP_NOFS, 0, &bio);
> +				GFP_NOFS, &bio);
>  		if (error && error != -EOPNOTSUPP) {
>  			xfs_info(mp,
>  	 "discard failed for extent [0x%llx,%u], error %d",
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index f1cf557ea20ef..c9b5925af5a3b 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -248,6 +248,7 @@ struct queue_limits {
>  	unsigned int		io_opt;
>  	unsigned int		max_discard_sectors;
>  	unsigned int		max_hw_discard_sectors;
> +	unsigned int		max_secure_erase_sectors;
>  	unsigned int		max_write_zeroes_sectors;
>  	unsigned int		max_zone_append_sectors;
>  	unsigned int		discard_granularity;
> @@ -542,7 +543,6 @@ struct request_queue {
>  #define QUEUE_FLAG_IO_STAT	7	/* do disk/partitions IO accounting */
>  #define QUEUE_FLAG_NOXMERGES	9	/* No extended merges */
>  #define QUEUE_FLAG_ADD_RANDOM	10	/* Contributes to random pool */
> -#define QUEUE_FLAG_SECERASE	11	/* supports secure erase */
>  #define QUEUE_FLAG_SAME_FORCE	12	/* force complete on same CPU */
>  #define QUEUE_FLAG_DEAD		13	/* queue tear-down finished */
>  #define QUEUE_FLAG_INIT_DONE	14	/* queue is initialized */
> @@ -583,8 +583,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
>  #define blk_queue_add_random(q)	test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
>  #define blk_queue_zone_resetall(q)	\
>  	test_bit(QUEUE_FLAG_ZONE_RESETALL, &(q)->queue_flags)
> -#define blk_queue_secure_erase(q) \
> -	(test_bit(QUEUE_FLAG_SECERASE, &(q)->queue_flags))
>  #define blk_queue_dax(q)	test_bit(QUEUE_FLAG_DAX, &(q)->queue_flags)
>  #define blk_queue_pci_p2pdma(q)	\
>  	test_bit(QUEUE_FLAG_PCI_P2PDMA, &(q)->queue_flags)
> @@ -947,6 +945,8 @@ extern void blk_queue_chunk_sectors(struct request_queue *, unsigned int);
>  extern void blk_queue_max_segments(struct request_queue *, unsigned short);
>  extern void blk_queue_max_discard_segments(struct request_queue *,
>  		unsigned short);
> +void blk_queue_max_secure_erase_sectors(struct request_queue *q,
> +		unsigned int max_sectors);
>  extern void blk_queue_max_segment_size(struct request_queue *, unsigned int);
>  extern void blk_queue_max_discard_sectors(struct request_queue *q,
>  		unsigned int max_discard_sectors);
> @@ -1087,13 +1087,12 @@ static inline long nr_blockdev_pages(void)
>  
>  extern void blk_io_schedule(void);
>  
> -#define BLKDEV_DISCARD_SECURE	(1 << 0)	/* issue a secure erase */
> -
> -extern int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags);
> -extern int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -		sector_t nr_sects, gfp_t gfp_mask, int flags,
> -		struct bio **biop);
> +int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> +		sector_t nr_sects, gfp_t gfp_mask);
> +int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> +		sector_t nr_sects, gfp_t gfp_mask, struct bio **biop);
> +int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
> +		sector_t nr_sects, gfp_t gfp);
>  
>  #define BLKDEV_ZERO_NOUNMAP	(1 << 0)  /* do not free blocks */
>  #define BLKDEV_ZERO_NOFALLBACK	(1 << 1)  /* don't write explicit zeroes */
> @@ -1112,7 +1111,7 @@ static inline int sb_issue_discard(struct super_block *sb, sector_t block,
>  					      SECTOR_SHIFT),
>  				    nr_blocks << (sb->s_blocksize_bits -
>  						  SECTOR_SHIFT),
> -				    gfp_mask, flags);
> +				    gfp_mask);
>  }
>  static inline int sb_issue_zeroout(struct super_block *sb, sector_t block,
>  		sector_t nr_blocks, gfp_t gfp_mask)
> @@ -1262,6 +1261,12 @@ static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
>  	return bdev_get_queue(bdev)->limits.discard_granularity;
>  }
>  
> +static inline unsigned int
> +bdev_max_secure_erase_sectors(struct block_device *bdev)
> +{
> +	return bdev_get_queue(bdev)->limits.max_secure_erase_sectors;
> +}
> +
>  static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
>  {
>  	struct request_queue *q = bdev_get_queue(bdev);
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 5d9cedf9e7b84..a2b31fea0c42e 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -179,7 +179,7 @@ static int discard_swap(struct swap_info_struct *si)
>  	nr_blocks = ((sector_t)se->nr_pages - 1) << (PAGE_SHIFT - 9);
>  	if (nr_blocks) {
>  		err = blkdev_issue_discard(si->bdev, start_block,
> -				nr_blocks, GFP_KERNEL, 0);
> +				nr_blocks, GFP_KERNEL);
>  		if (err)
>  			return err;
>  		cond_resched();
> @@ -190,7 +190,7 @@ static int discard_swap(struct swap_info_struct *si)
>  		nr_blocks = (sector_t)se->nr_pages << (PAGE_SHIFT - 9);
>  
>  		err = blkdev_issue_discard(si->bdev, start_block,
> -				nr_blocks, GFP_KERNEL, 0);
> +				nr_blocks, GFP_KERNEL);
>  		if (err)
>  			break;
>  
> @@ -254,7 +254,7 @@ static void discard_swap_cluster(struct swap_info_struct *si,
>  		start_block <<= PAGE_SHIFT - 9;
>  		nr_blocks <<= PAGE_SHIFT - 9;
>  		if (blkdev_issue_discard(si->bdev, start_block,
> -					nr_blocks, GFP_NOIO, 0))
> +					nr_blocks, GFP_NOIO))
>  			break;
>  
>  		se = next_se(se);
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 06:21:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 06:21:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303442.517700 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne9u4-0001NF-Nf; Tue, 12 Apr 2022 06:21:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303442.517700; Tue, 12 Apr 2022 06:21:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ne9u4-0001N8-KR; Tue, 12 Apr 2022 06:21:28 +0000
Received: by outflank-mailman (input) for mailman id 303442;
 Tue, 12 Apr 2022 06:21:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KbYP=UW=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1ne9u2-0001N0-VR
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 06:21:26 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c69e12f9-ba28-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 08:21:24 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id CD9FC68AA6; Tue, 12 Apr 2022 08:21:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c69e12f9-ba28-11ec-8fbc-03012f2f19d4
Date: Tue, 12 Apr 2022 08:21:20 +0200
From: Christoph Hellwig <hch@lst.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org,
	x86@kernel.org, Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low
 memory restriction
Message-ID: <20220412062120.GA7796@lst.de>
References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-11-hch@lst.de> <Yk4vfAd0J5u+wUsq@char.us.oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yk4vfAd0J5u+wUsq@char.us.oracle.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Wed, Apr 06, 2022 at 08:25:32PM -0400, Konrad Rzeszutek Wilk wrote:
> > diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c
> > index c5228f4969eb2..3b4045d508ec8 100644
> > --- a/arch/powerpc/platforms/pseries/svm.c
> > +++ b/arch/powerpc/platforms/pseries/svm.c
> > @@ -28,7 +28,7 @@ static int __init init_svm(void)
> >  	 * need to use the SWIOTLB buffer for DMA even if dma_capable() says
> >  	 * otherwise.
> >  	 */
> > -	swiotlb_force = SWIOTLB_FORCE;
> > +	ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE;
> 
> This is the only place you set the ppc_swiotlb_flags.. so I wonder why
> the '|=' instead of just '=' ?

Preparing for setting others and not clobbering the value.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 06:46:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 06:46:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303446.517711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neAI3-0003tW-Nu; Tue, 12 Apr 2022 06:46:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303446.517711; Tue, 12 Apr 2022 06:46:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neAI3-0003tP-Kq; Tue, 12 Apr 2022 06:46:15 +0000
Received: by outflank-mailman (input) for mailman id 303446;
 Tue, 12 Apr 2022 06:46:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAI1-0003tF-TH; Tue, 12 Apr 2022 06:46:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAI1-0002CM-RX; Tue, 12 Apr 2022 06:46:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAI1-0008LQ-AK; Tue, 12 Apr 2022 06:46:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neAI1-00041B-9u; Tue, 12 Apr 2022 06:46:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hmN+itrTAAnsAJmBD/OhSuWjYWvEInRHwBCzZoL3qxE=; b=cGhmu9C9dGp7vbMzP+gVj8nhSu
	oc+hlES8XByFv8+/V0+4Eue6BfETl2Y9fmRTFBW2AjxaKkYAjU57S3mzXd85hXQC0o4d6EnNUW0Wl
	maEnQTZnkFNhYPP07Tw5CUbILQiucwawI7hSKmJyD9tX4rrWgYHqeY7xRS5I9VrhgZPk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169323-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169323: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=12a50c9ce117b6106c92bb965799e709547d8494
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 06:46:13 +0000

flight 169323 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169323/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 12a50c9ce117b6106c92bb965799e709547d8494
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  337 attempts
Testing same since   169311  2022-04-11 15:43:02 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4890 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 07:07:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 07:07:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303455.517721 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neAcJ-0006MZ-Dr; Tue, 12 Apr 2022 07:07:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303455.517721; Tue, 12 Apr 2022 07:07:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neAcJ-0006MS-Au; Tue, 12 Apr 2022 07:07:11 +0000
Received: by outflank-mailman (input) for mailman id 303455;
 Tue, 12 Apr 2022 07:07:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hHcz=UW=gmail.com=geert.uytterhoeven@srs-se1.protection.inumbo.net>)
 id 1neAcI-0006MM-2R
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 07:07:10 +0000
Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com
 [209.85.219.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2a1925d6-ba2f-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 09:07:08 +0200 (CEST)
Received: by mail-qv1-f41.google.com with SMTP id kd21so15487048qvb.6
 for <xen-devel@lists.xenproject.org>; Tue, 12 Apr 2022 00:07:08 -0700 (PDT)
Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com.
 [209.85.219.177]) by smtp.gmail.com with ESMTPSA id
 140-20020a370892000000b0069c1c277c58sm3727767qki.109.2022.04.12.00.07.05
 for <xen-devel@lists.xenproject.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Apr 2022 00:07:05 -0700 (PDT)
Received: by mail-yb1-f177.google.com with SMTP id z33so31532302ybh.5
 for <xen-devel@lists.xenproject.org>; Tue, 12 Apr 2022 00:07:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a1925d6-ba2f-11ec-a405-831a346695d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=G5mglcYZA42FcZWexfT//Na3N8U+QShWNDx9HhSMVxo=;
        b=Mx3nK3cU0R3yQKcQghWdLlubcbh5UGw7a1HeOLF+JeblpDRG6IMmTX2swWOgrDkK3z
         NWHy9OJFUlENAe82Tty+MlGai0hL1/N9t7DVTOjTkKo9bEH/NogYLpOLmM1iupTesQCX
         fhbdcT0CqNPKdZupM9QT5qVeBIxRZzkyLPCfX0XCrDMJsrOLL4k3vZ7dHFDL6kT2RppS
         1m6/VT1cCNDCk2e3X5GivsxROpk1FHHHYywW/txp6js6cygFBIfsRIzixDqhIgecrnCz
         +fLbawDLChJvPFT8XEhSnX4ADO4sP53es6JG/+b0xFBGEQbdWTCrAxAYUT3GXvaXyntZ
         2HoQ==
X-Gm-Message-State: AOAM533BvFcnC1dtQX4Q8FwAD6+EBoRmJtVfGsmgFjifYKYXuQUNCKah
	QgsI7E4vVvzHzyXU8W53x47DYOwVg0b9vLau
X-Google-Smtp-Source: ABdhPJy53YN6PMXFkSGTKM06ABQW2SkR5j9U3k9RxOa8ieLB5b9MGOfEBpBmxQWlNRekeDVM7bNnsQ==
X-Received: by 2002:a0c:c684:0:b0:444:3a32:e96e with SMTP id d4-20020a0cc684000000b004443a32e96emr10652595qvj.124.1649747226782;
        Tue, 12 Apr 2022 00:07:06 -0700 (PDT)
X-Received: by 2002:a25:c049:0:b0:634:6751:e8d2 with SMTP id
 c70-20020a25c049000000b006346751e8d2mr25945732ybf.6.1649747214062; Tue, 12
 Apr 2022 00:06:54 -0700 (PDT)
MIME-Version: 1.0
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 12 Apr 2022 09:06:42 +0200
X-Gmail-Original-Message-ID: <CAMuHMdVfOpGvF5FR6vFD-3a1h-7Kc_yAKQzWV71PD6mDy6BmZw@mail.gmail.com>
Message-ID: <CAMuHMdVfOpGvF5FR6vFD-3a1h-7Kc_yAKQzWV71PD6mDy6BmZw@mail.gmail.com>
Subject: Re: [PATCH v7 00/20] Introduce power-off+restart call chain API
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, 
	Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	=?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>, linux-m68k <linux-m68k@lists.linux-m68k.org>, 
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>, Parisc List <linux-parisc@vger.kernel.org>, 
	linux-riscv <linux-riscv@lists.infradead.org>, Linux-sh list <linux-sh@vger.kernel.org>, 
	xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM list <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

Hi Dmitry,

On Tue, Apr 12, 2022 at 1:38 AM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
> Problem
> -------
>
> SoC devices require power-off call chaining functionality from kernel.
> We have a widely used restart chaining provided by restart notifier API,
> but nothing for power-off.

> Changelog:
>
> v7: - Rebased on a recent linux-next. Dropped the recently removed
>       NDS32 architecture. Only SH and x86 arches left un-acked.
>
>     - Added acks from Thomas Bogendoerfer and Krzysztof Kozlowski
>       to the MIPS and memory/emif patches respectively.

Looks like you forgot to add the actual acks?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 07:19:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 07:19:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303466.517737 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neAo9-00082Q-K8; Tue, 12 Apr 2022 07:19:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303466.517737; Tue, 12 Apr 2022 07:19:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neAo9-00082J-GB; Tue, 12 Apr 2022 07:19:25 +0000
Received: by outflank-mailman (input) for mailman id 303466;
 Tue, 12 Apr 2022 07:19:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAo7-000829-Ud; Tue, 12 Apr 2022 07:19:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAo7-0002qq-TU; Tue, 12 Apr 2022 07:19:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAo7-0000sW-MW; Tue, 12 Apr 2022 07:19:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neAo7-00060K-M2; Tue, 12 Apr 2022 07:19:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PMjVLysPH6iIg+qnkdJ+I1fd4LxO7a566p2AOE96oRs=; b=RewGxYDZeUUOtuyThQAs5RfmIW
	P3dK5nTLMfw1e/UdYoOzwFoVTF0dBzyQtdKMo2u8cdvPvgz0kDwZjpXOBmbnCrxMJ9juvn7hxnWIx
	VbJTTg09PCfh0uXg8KlQlbZ2cih6stx6wyNKdqSz1OOI8sKXhFsZJhtYn8DI/OJMuJLU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169320-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169320: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5b752808ff37b7c819a26fd76329ef329c42774f
X-Osstest-Versions-That:
    xen=f44201124e8713f6eff80f349351b5740001c6fc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 07:19:23 +0000

flight 169320 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169320/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  5b752808ff37b7c819a26fd76329ef329c42774f
baseline version:
 xen                  f44201124e8713f6eff80f349351b5740001c6fc

Last test of basis   169304  2022-04-11 11:00:27 Z    0 days
Testing same since   169320  2022-04-12 02:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Doug Goldstein <cardoe@cardoe.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f44201124e..5b752808ff  5b752808ff37b7c819a26fd76329ef329c42774f -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 07:29:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 07:29:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303474.517748 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neAxt-000172-JG; Tue, 12 Apr 2022 07:29:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303474.517748; Tue, 12 Apr 2022 07:29:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neAxt-00016v-FZ; Tue, 12 Apr 2022 07:29:29 +0000
Received: by outflank-mailman (input) for mailman id 303474;
 Tue, 12 Apr 2022 07:29:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAxs-00016k-CB; Tue, 12 Apr 2022 07:29:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAxs-0003AT-AP; Tue, 12 Apr 2022 07:29:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neAxr-000181-TW; Tue, 12 Apr 2022 07:29:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neAxr-0002Qx-T5; Tue, 12 Apr 2022 07:29:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iwfb1ELnkAN5h1Ru+3reKdu13wzl/II65c7uhJz1rmE=; b=AVb602LLw1dhdERSzw0uXsW4Xj
	mjNKJ8kO0s8Yju229sMm1F64B6cqr+HBSy3nk/bo2MtjTcsZ3PbWLk9leTfJ9do8toI62YTgz20WI
	QoTAEjzy98GknJX3xC7ZpqBBXGejFEziuEzHI46CVgBcBuMd2nV6njD9lJIjjiz3WhIM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169324-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169324: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=5576b17363e92ce07e9707478061d5ce38bf7d06
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 07:29:27 +0000

flight 169324 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169324/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 5576b17363e92ce07e9707478061d5ce38bf7d06
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  338 attempts
Testing same since   169324  2022-04-12 07:10:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4911 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 08:02:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 08:02:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303492.517758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neBTi-0005ye-LP; Tue, 12 Apr 2022 08:02:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303492.517758; Tue, 12 Apr 2022 08:02:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neBTi-0005yX-IR; Tue, 12 Apr 2022 08:02:22 +0000
Received: by outflank-mailman (input) for mailman id 303492;
 Tue, 12 Apr 2022 08:02:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neBTh-0005yN-JR; Tue, 12 Apr 2022 08:02:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neBTh-0004Oc-FA; Tue, 12 Apr 2022 08:02:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neBTh-0002YD-2r; Tue, 12 Apr 2022 08:02:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neBTh-0003Lg-2S; Tue, 12 Apr 2022 08:02:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=35tUcwpEqturV5CcglygBB+XPmr3bskmRRYac7u+I9s=; b=sI99F38rPCKENh+vg/jBkUt5W4
	9G5alw4FB/TY7bcmO4uUNlcMlytSbmGu9YOMetMs82NbhSZpbUe3sn2qgyUdGzBeIKh16lfi1QTfH
	Kv75jXyUP0OVFL8ewFwXxYPcTQK7fNKl4lAO47JJZRmcM7LUWfEds+9Vv9bGOM5tzCVA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169325-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169325: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=5576b17363e92ce07e9707478061d5ce38bf7d06
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 08:02:21 +0000

flight 169325 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169325/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 5576b17363e92ce07e9707478061d5ce38bf7d06
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  339 attempts
Testing same since   169324  2022-04-12 07:10:23 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4911 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 08:21:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 08:21:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303500.517770 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neBlw-0008Jz-9p; Tue, 12 Apr 2022 08:21:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303500.517770; Tue, 12 Apr 2022 08:21:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neBlw-0008Js-6F; Tue, 12 Apr 2022 08:21:12 +0000
Received: by outflank-mailman (input) for mailman id 303500;
 Tue, 12 Apr 2022 08:21:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neBlv-0008Jm-8a
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 08:21:11 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7c2e1a01-ba39-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 10:21:02 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c2e1a01-ba39-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649751662;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=HX+0BXw59w9MMWUggtUoOxn2iv1W+tdLpsPP5ulacIo=;
  b=PkQDFoMgSvq15wY+vrkI0z3BIOxyUYJTBZgfk2y1lQlDRTDSg5u2CjF4
   qr3iuBy66GCxZDzpeKAr9utixsZDeyzBLNsL74SQPJz1NEre4wSip014r
   u+MLZxnnNsOoBTyhWgTIfDh2iNzcHZVhOkgYj2itf0dDWo2yLbrMIFsLa
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 69055900
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WH1gVan1xDY17bfmC3REomjo5gytJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKWWrTb6ncN2X0Ltt3bI+x8EhU6sPcmNUySQJlrHsyQiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWlnV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYQgx0Me7XseImUiJ3DjhRJYQe5qH1GC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6eGO
 pdIMWIHgBLoODwQZl0UKMMCpvanuHTDdD5x9VvPnP9ii4TU5FMoi+W8WDbPQfSJSNtUmACEp
 2vA12X/HhwecteYzFKt6nuxgsffkCW9X5gdfJW6/PN3hFyYxkQIFQYbE1C8pJGRmkO4Ht5SN
 UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM+e8CMVjtlvLkPCNpV/EWC5UFVatdeDKquc9TmEll
 USgmejoPhNyqZKNYCqD6IWt+Gba1TcuEUcOYioNTA0g6tbloZ0ugh+ncuuPAJJZnfWuR2iun
 mniQDwWwuxK0JVVj/nTEUXv2WrEm3TfcuIiCuw7tEqB5xgxWoOqbpfABbPzvacZd9bxorVsU
 RE5dymiAAImUMnleM+lGrxl8FSVCxCtamO0bblHRcRJythV0yT/Fb28GRknTKuTDu4KeCXyf
 GjYsh5L6ZlYMROCNPErMt3pWpR6lPW6SLwJs8w4iPIUPfCdkyfdoklTibO4hTixwCDAb4liU
 XtkTSpcJSlDUvk2pNZHb+wczaUq1kgDKZD7HvjGI+Cc+ePGPha9EO5dWHPXN7xRxP7U8W39r
 ocEX+PXmko3bQELSnSOmWLlBQtRdiZT6FGfg5E/S9Nv1SI6QDpxVKKLmepJlk4Mt/09q9okN
 0qVAydw4FH+mWfGOUONbHViY6noRpFxsTQwOilEALpi8yJLjVqHhEvHS6YKQA==
IronPort-HdrOrdr: A9a23:k5b+wqPVLgYZkMBcTqKjsMiBIKoaSvp037BL7SBMoHluGfBw+P
 rCoB1273XJYVUqOU3I5+ruBEDoexq1yXcf2+Us1NmZMjXbhA==
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="69055900"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f4DWs21IBPKA8leOB3CfDkXRHEnSq/vDEysexurnJBzOb9t69Hzn0krwLaINMdgtXFBAkdo4aJe8r9oEUyzBoS60Cu8Mdea/hWTKk414mehIGG65kVBmhjnKHZ0MgJ7KcJXRqOqZicVRxV7I42Z6h7IL74Vt5VwF1HrUmrNIplELlvSpor7NNYnXcLoN0S8anc+LCHjq4GUVL0+AfNqyo6ITusl0GVc90qlEXSXwDL+n/kUrjtcBlxfyDKbxGYWCraJaamX/bVGVelwlmEI2gKeaiORt2gntcIBA6xgC0rKceSPdbg3WGuRTnFDD0IS8e57TOVaFd38LnnlGwiMM3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RF55FxR8w3EPl9TKIwZBkM0HACdcA+tdbUN0mYxhYJg=;
 b=nVdIoO9eAMwqLLA5FOaTtJX6BHYKh71ItNqPUORfO7M/TYBtVlz3FB7y7M6gG16FKDTIZ35QTxE33RG8cRVCmGik5VR0yvzFIcn/oWIUaC6VuWG4flmyB38lbrKgRUsHFyZbu8WIg08Q+h2p6y4xtyU5hCokvtiVZlHXMJEB/WNnFQnS7o+JzxYz/0JeQksPvwiGbzrRCtZHFbKK4fYJOrVtGAeNdxAY7CC8O9pJVg1JrppJjG3e+vcZzPDYbt+vHjEmtPHKb1+BhvSBRIqGnHCjzGSCUw7ECCxBw8qpHdugfkfCu57Q/7b20ckbyMdDQd6+zUT/stHxzYNygbn0AQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RF55FxR8w3EPl9TKIwZBkM0HACdcA+tdbUN0mYxhYJg=;
 b=Q/7Gl78Y2pvNMQV8+fG9heO9gAKwD5qREgStHSHyzQrnvlLSJIFrT39vE6K20hmhGU8FEYXRyZLfCokGVvI/QqFx6jlF0hhEznRpEknDdf/gElnTvgoHP8Gh37k8xRchTaBMxTgdB0dVEWHXuix9Qrgn6FuSBPyIjIRyd5D2PNc=
Date: Tue, 12 Apr 2022 10:20:49 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Kevin
 Tian" <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 2/8] VT-d: drop ROOT_ENTRY_NR
Message-ID: <YlU2YRC75sQJciSK@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <ad944163-e8cb-6ecc-7e6f-400f9e8cd4bd@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ad944163-e8cb-6ecc-7e6f-400f9e8cd4bd@suse.com>
X-ClientProxiedBy: LO2P265CA0314.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a4::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf0b286e-d4c4-4c7c-756e-08da1c5d5dbd
X-MS-TrafficTypeDiagnostic: BN6PR03MB2657:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <BN6PR03MB26573A28E7730515A488FF668FED9@BN6PR03MB2657.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: M5RjSRW/xZUvZHZfQzvmVCN2c6TX08VORowxLmJlOIYv9as2iDFnahtHONrh0uEO1p3I4A67yHQWDqn54VfZEfnV71LurttI0iltvsv1AXnpEzfht3Jpzq1Yg36sJO8KRDOF723vg4VyO06FzTHpc5XeO9cEJS/lyTdN55XvFIQvG+pNKVQYFCk9B9Y9tQFoOso9Nd05zEfGGilWcA5uUL85InzHxWFQI77UTwmhRXfAEH7yLRi8k2Yw6A25LYP3PvH/HkIjQeB8ynE0dwX05TbFr5FH5/RrLyWrskHVMTYrabO/F9B+01NWDnssCOpLvbx+ykySfVoSwn2cXuT2sJAP/dFZoLSLv4RB9FFDW7jFRteEXfkhBmjoyqgiZ9RX2RUUuz4bOSExXd69E6ycvgIofPkq4cG3DegRjKLnUJLPZZNILmc1ChDiUuoz2D3NMuXLXiVla6u544NInTXDDeS14j3BpOk2+jyg0/Maa9xbRnnryGCdoTbNmncc8KUq12Lfg4wGSBDQ3Rl7tmZVgSBNH9ZwQu3w4suoOAqN2KoqqpafTdRukz4LpOq1DmSVQg4xn4c7Uo5ozDJ2/t0PAd1AlmTNmwYc/RwXXdrosnKwvSO9CWD8zqBjnlqZEYwB64Z8A3b19MpnRXxUPfS4ig==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(85182001)(2906002)(82960400001)(8936002)(66946007)(66556008)(33716001)(66476007)(26005)(186003)(5660300002)(6512007)(38100700002)(9686003)(558084003)(8676002)(508600001)(6506007)(6486002)(6666004)(316002)(4326008)(86362001)(6916009)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nms1OUhlTTlHTENmYmRPNEJKbW5JS1FxdEtJeFRZKzB4cWlUV2Z3dU5saWd6?=
 =?utf-8?B?WG1NL3kzaVhOdlBwcVhVOXljdlpHNUFDSGZ0dUpZYXQwQU44MklLNkI4ZzZl?=
 =?utf-8?B?UEYrTFZqREZrMllVeEc2V1hyV3VKN3lCWkxZN3ZJMkJxSFdONDdYZDd0dmpz?=
 =?utf-8?B?aVIvUDZWMzhvR0RINzU4RXp5d2NycUFNMGlrcHNzM1JiWHBUa0NUbXlJd1h6?=
 =?utf-8?B?akFQQWRITVNzeTA3TWN4M3N2NngwSHlIR01CMTRubG9uREJ1OTluaktZeDhR?=
 =?utf-8?B?TUE1emdUckFjRTFJQXNTYUZLajNGc2JRaHdGTTl3RnhKYzBqR1RQQnptQWtH?=
 =?utf-8?B?VmlVNUtyTTMwU3NYVFBtMGM2QkZ6OHZuZW5vQUh2dWtxekxVZFgwRDRpUCs0?=
 =?utf-8?B?elIvRzBYM2N2UWhsOU1VZ3Z3Y3dNMEFXRTR5SGg4Vmc0TVowZGtVdzU2VEc0?=
 =?utf-8?B?SlBPRnQ5b3VseEVKNlVya3Ixb3psQW1ZNVVxT2tsbkx6M1VvcUxoWWxmSHht?=
 =?utf-8?B?Syt2c0NPTWY0eDZMUkJOdzl6cnh4ZkZTR3JwYUhWTU1haG9YeDVMRnFBZFEx?=
 =?utf-8?B?QzR2UjlRNGtCelNIeWY4bEx3Mi9hd3MzV04vRmJlZXhlQXhZVkNFNW56dkpD?=
 =?utf-8?B?YXhva1FWNU12V2xKTDdDWWFYdG1JZnBlMXJLTW01MXhpTWpGMFp6c0pUY0N2?=
 =?utf-8?B?ZFFIRGwyeTYzL1FyZGx5REhoVmhpSjV2SmtocVhYaWJiT2RqWkdGVUVuR29M?=
 =?utf-8?B?Z2VxVHNDdWVSTGZ5WWNiZzA3NjE0MFM5VTdySnRCbEJEdnBvZ0xhV1ZadE80?=
 =?utf-8?B?NTFqMGUyV1paRzRqNWZUekd4RjdhL1gzVTdFS3V4cHlXM3FOTERYZlF6Unhv?=
 =?utf-8?B?MzJkNUlxQmNtSGZESzZvUmwwanY3bmtCYSs4a0syUFhac3J3NGxsVlNJTVUr?=
 =?utf-8?B?QzdVR3ZuMXFtZUQ5YU9xQVpXeXRyaWhGRUk3bnZSZGVNVnp1TmMxem9rTkNv?=
 =?utf-8?B?UlgrdUh4MU5HZDhkL3dHUHdROXhJWEc4b29Ga1RPV0ZUc3RnQ0hhRURaYUNG?=
 =?utf-8?B?V0ROZXlidHBZekw2cDZyV2tHbU5JOGlHMlBOV3doY3Nqa00zMldKZDQ3THpt?=
 =?utf-8?B?V3AwUmZ1dW9vRjBadmxqUkhCcEtBQWdyVlFneFlhOFlVM0hBWStMVERSUHR6?=
 =?utf-8?B?UmdPcmpvYis0Rkl6Z01LWitHeG5BWEJJLzBlVFlsN3BjMmZrcUloTU5pMDRQ?=
 =?utf-8?B?UERwamNtdkxkUkRwVkJ4OTRDRFB3NUVsSXozdDJsdi90YzMwVEhwbEdwZGdX?=
 =?utf-8?B?alJTbDZrVmdFVEZQU2FCb0NjbVRVaVg3NHhIRDJsMzkrQWJmR1ArNHZmR0la?=
 =?utf-8?B?aFhlbC84NGh0ZElCV3NYZnk5a1kxVHN0ZVhBc0FIV3JoVU9Zb0hvYWpYWm51?=
 =?utf-8?B?a0VHUHdTTC9GZUg1eUwxTzBWV3FuaEJLQVVJOHU2M2cvTmNqNWVsZXFyODNv?=
 =?utf-8?B?cW9PbFN2cWVRLzZjeEI1cVpxM2paYXVhTVlUaHpsdjNPVDhwOGJrT29ORWdX?=
 =?utf-8?B?NUJSOVZUbXk3T2xlVk9sY1h0Wm5VbjRBcG5IMU8vb3BOaU43dEZqd2RGWWth?=
 =?utf-8?B?UThCVlhNd1QyRW1nQVFqZWt3YWJSZThGS3FpaWs2dUd4V2pKN0ZyclBPQ050?=
 =?utf-8?B?VlFxcHVXMEdpbEtpQXdONzRSdWxlL0czbEsyb1pncVpIZ3JqYUUyWVowWklM?=
 =?utf-8?B?ZElCVSsxN0xzWHNvYno1TTJSVE5zOXY5UmN5Sm9jb1ZzSTlHdFhEZmhLcTlD?=
 =?utf-8?B?NlFFU04zejUzblo3c3FFeWYxM0VSL1JFNTBuSG8vN0o0NDdNdDNYejBkb3g5?=
 =?utf-8?B?ZDhDYnNqdWtoM3ppeDZ3SUFIdmxkZFFidVZqVGd3cWRCOXRWYnc4V21JWE5L?=
 =?utf-8?B?UkdWTXJMLzdZcXRLYnpsNkhkM0VEMjc5V3dIWE00WERmbTVaS2ZQdE9VbTlK?=
 =?utf-8?B?ZlhOS3EvUUUrMUdkNkxjSFJnSThudlhnSHBTZFVjdHRvTnFzL1VPWFJlVFRj?=
 =?utf-8?B?MnpublVLVUpGTTdOamt5dmZZRlMwbWN1K3RBbWI3ZkFKZC9hYVRNQ0daMUhn?=
 =?utf-8?B?ckpGTEJkVzhEenZxT1hiZ2hROU52eTEwWjZkWXBRL1hhZmxncEJBK1doM3Jn?=
 =?utf-8?B?dHRQV09uUXQvR1dpY3EzbHR3Q1JQRDJEMVVPWDNYK1JhL25UU3RLL3dRYWlt?=
 =?utf-8?B?MjF0WmNyMGcwWmQzb3ZNOUJPRGd0M1RjU29yRVJNYVBYSG9QdXpTa3lNVytX?=
 =?utf-8?B?MkN1WllJMXhqNHFMRlpoT1VEeWFVb3h3ampxUFIva2cydXc3WWhaQT09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf0b286e-d4c4-4c7c-756e-08da1c5d5dbd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 08:20:55.7986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6IrSoEyLdbnvIXlOWjSjxt072Oqww2KEb6TOrB4+UIh0ocmVUolDkR/1CkueO6Py8eFLqY0Tndi6YMhIG9Jt+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2657
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:36:23AM +0200, Jan Beulich wrote:
> It's not only misplaced, but entirely unused.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 08:30:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 08:30:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303505.517781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neBuc-0001Lc-7J; Tue, 12 Apr 2022 08:30:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303505.517781; Tue, 12 Apr 2022 08:30:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neBuc-0001LV-32; Tue, 12 Apr 2022 08:30:10 +0000
Received: by outflank-mailman (input) for mailman id 303505;
 Tue, 12 Apr 2022 08:30:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neBub-0001KL-2a
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 08:30:09 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bffc1c67-ba3a-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 10:30:05 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bffc1c67-ba3a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649752205;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=arp2Tlo/m+L53NGaLVXRpbp4QHzFp41ENqIQ7B2ih6w=;
  b=Z96/DnsbCmgUtaEpGwSdGRWeMpKXrvWHLg8w7C5cCwabeQb0pNA85ZRO
   5zVyrxbg70R4jpUSp63M3zTGy/hvlUHlaBjasuxdj2nNKkdQ1H31Me5kh
   sS+2OfNRkpgSGd+8Gfm4l9T9oZdChMRlqkddjJer1++XWaNlY5exlT8yD
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68059461
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7Xni0KwJK7l7KvUb1e16t+cbxirEfRIJ4+MujC+fZmUNrF6WrkVUx
 mIWX2mGbquJNmHyLop0adu/oB4G7ZbTyNFnQQU5qSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02ILhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl8qevEQMAAb/2v6cmdzN/CnhwGLZb9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JAWQKeCO
 ZNxhTxHbE6cOhkSBUguS5c0m8WwgmTjSRljkQfAzUYwyzeKl1EguFT3C/LWd8KLQ4NJn0+ej
 mPA42n9RBodMbS30TOY9lq8i+mJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1iPwQPIJTbd8slvUjPOJvUDJXQDoUwKtdvRhj9BuQRUVx
 GWu3OjNLxt26bOwUm+So+L8QSyJBQAZKmoLZCkhRAQD4sX+rIxbsi8jXuqPA4bu0ISrRGiYL
 ySi6XFn2u5N1ZJjO7CTpwivvt66mnTeoufZDC3zV3nt0A52bZXNi2eAuQmCtqYowGp0ozC8U
 Jk4dyq2sbhm4XKlznXlrAAx8FeBvajt3Nr02wMHInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia
 1LJtAVa6fd7ZSX2PPAvMtLhUplwkMAM8OgJsNiOMbKihbArKme6ENxGPxbMjwgBbmBx+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWngvuqWTA503/i9K2PSfNIZ9caQfmRr1pvcus/VSOm
 /4CZpTi9vmqeLCnCsUh2dVIdg5iwLlSLc2elvG7gcbfelE2Rzx7U6a5LHFIU9UNopm5X9zgp
 xmVckRZ1ED+lTvALwCLYWpkc7ThQdB0qndTAMDmFQ3AN6QLCWp30JoiSg==
IronPort-HdrOrdr: A9a23:6nWvxKDekWLXfuDlHeg1sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMkj+Ka+Adww4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJJGdZc8qPSMex7wqDL3QSuvyAfcZek600ykke+C3Fxy3pDsRKA1
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68059461"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nuZ538R4dI25jfi/9Z0dyD9iUiNDX6swru4oqa2Wqxb4g8I30z/xCCt8B8pKI1d7LKxOVw0lrllx6NdHoC2w6ITvNscUml+YR55HZhMDKizYpSS2RJFuy9rLWXBM/46EqWVlRwjyHo49sUYmzc5D5BJHReJJmKsywXWhPipFF7Fj1C1Cy63tNwfeTN9xMRc053F92cmHewNiUoQo7YcM0b5YsSJvxSQC7u+532rrou1LSG+Qu3dTp8bsbx8PvBhL0rNSzW4kSWvIQ7+pyeg7XccEqRnIBDm6qv5utLllQ/9ULBZ01ecafyvw1D/lqdZaTnJmzVFAW4oQUXW9+0fxXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VVW7ZGom+EaatdGl5qs+wFIX/34LEudnS43g77e4Wu0=;
 b=FuaqbIHM+IL68wFW9TP+DmP+XwCDQ0Jexavf/1wO2wAiaqM8R0kNn95/CXDvA6B5xBqf+ZjWgjU26doE8UEGwQpLVMVq5hEKdunhs23Dkfo2urxJZ028ObcOmYGm455IiF+hJvpAyWFLLTsxTTCB7uoVe/OF7zMrqQOhjWxtL19wjikNPW1w7T1HDQoUgD7Sx/MZGCg/8+QZTzbX+V91KyLufuiz/Qsr9Ky4XmUdSZEpN3gskoCkcFEfkK+20MCZPBqIxXckxcyQ+0h6Rmb2Qnq3+jECd30E7/k5WY2DREJXb1QscF+4Yvs66U8tZ5F0Lc6IOgiGMKOXEiidJWpuFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VVW7ZGom+EaatdGl5qs+wFIX/34LEudnS43g77e4Wu0=;
 b=VhRVXV1JcwIRFl+ZvYzuOiIZxKfnorCkm8zASU93iB/Ff5RRIVVlJi9UyXfdhZ6DQvexOpalK104uDdLbXZ8vEuEwco1xdAB5bPtze52gsGDfeRtP1obmN4fqj9NFCQg//+YRRJNrBkMsjROV3lo+4tHNRmX6WPWbvEscEX/3mY=
Date: Tue, 12 Apr 2022 10:29:51 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 3/8] VT-d: plug memory leaks in iommu_alloc()
Message-ID: <YlU4f8W1a/fBz1e2@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <10f43cc4-7a09-9f4f-0a6b-fd7ffd88310d@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <10f43cc4-7a09-9f4f-0a6b-fd7ffd88310d@suse.com>
X-ClientProxiedBy: LO2P265CA0047.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::35) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f1b1feb5-bd5e-47b0-30dd-08da1c5e9fa4
X-MS-TrafficTypeDiagnostic: BYAPR03MB3718:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <BYAPR03MB3718154F41FE4141B909E29C8FED9@BYAPR03MB3718.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7qfq0ZT5ZNZKRXTWLzT6h5g6y5rB822hlpwJ0PUmJP1kEhvVq/zK+Lj/tahoOPWjK37EYuhM07fC89jxN1gP1sGJWHFfGAxRwvi78I5KzmDLa/nZ8TRt7LSUsTMxlxdR9HVAoRUMsPxYBG4bf7CKUfpdvChrwjgSti+s15Ngynm8IYIxxZHq6isROAabSW0Vt9UmBALDvpI9VK88eaxD3AsIW1P7/0tkn+SIIGXDadvKnT6m9qe7Jv2SONk72UZ2SrGpUwjAruWEdbUsNjC3eg9fu1ioHxj4wyTf3MqOH9x76mHOj5HIwHrQAYhddCyTSyKVs1bIruCD/TZZTtwCC+K6IqwXhKNowPYgRSfvhsmctYKt7mri4V58Jf9F1VkFac8DSwi2p68xIyG0Qdj4bgGY+JUsoudKe63yq2JHD51EjjP9vVMCBE3IizRuYocZA39G/7gZps23XwCpDyn259zLApiScMFhQ8j/KR10Aer/qOvLIT1m5xDWZTOU4RyafCN/bNylOeY6spVVhx42EYyiRAJNYbL5lPxG1A3Jv26TVG8BNM/hmERmspBvHQa7DvF9N/Z0Lv/2OoOPmM12Qt8dFVwhpzSgBdShu0XQEZRE+hPDeNqKUG2e+uB3OQ6czwnoZuyvcD/j+PwRLP21mw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(83380400001)(66476007)(8676002)(4326008)(66556008)(508600001)(86362001)(26005)(6512007)(9686003)(66946007)(2906002)(186003)(6666004)(8936002)(6506007)(4744005)(54906003)(6916009)(5660300002)(38100700002)(85182001)(316002)(33716001)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGkxY3g0THpEdmNFY1FycUVLTU93OVVmMVhydDFXcER4RWFBZ2ZqOElzR3c3?=
 =?utf-8?B?ZmJVYUcxWWJ6Y3h0N1lUSzVhY29JaFRIR0hvbmUzRlBYbitUcjZpdXhYRXJk?=
 =?utf-8?B?QXFQd0RnWjZ2T2dkN29uSWRXM2NIUHQrcGRUUTdyZG5lTFI0VGttSExwcFAy?=
 =?utf-8?B?OEFZeEZ6dXJIaCtybUlWa2E1dDNPd2N3SlR3c3dJNzBzdnBZZnZMZHVyRDY4?=
 =?utf-8?B?V3JEZUhEL3ZPWlRqaEdsY1JLcTlIdVAzMWcya09BdDc3ODZMVjZkYzJxRDBl?=
 =?utf-8?B?VGgxQkZ6WVNFYzRJYnJBMVVFbmVVbm1vZWZhWlEzSnRmQk03RWRNNTVZL2xa?=
 =?utf-8?B?ajlVbmFrYVVnVERrRE5iMG0yZGRLQndKaCtpRVVnUE1OUDZKMEp5N1crUkJn?=
 =?utf-8?B?OTBrQUZpckIyUXhQbEhIbVVKcjVzdUJUdGVBNENyeFgvc2tuNVVJbkNwQWs1?=
 =?utf-8?B?T1FTMExSSXZkS1phN1NjWk0vNHRKRU9iQjhENFZ6M01lRGY0U2V0WmhVZjdX?=
 =?utf-8?B?U1VVWjBPRWhNak9FQVNBaTRGa2M2ZmVvaERpdWVQWnRtRzFLbkhONUNGSWZa?=
 =?utf-8?B?aDdMcHcrUEczaVI2WmVTYUllcFloWWhCVlUweUNqYzN5djNYZEpzdG9rc2Fu?=
 =?utf-8?B?cTlveW11dGptVWxrbDNCWUptbkgrNGwydTIydHExYXRuMnI2WitTZGhOdkdh?=
 =?utf-8?B?a2l5MjArajdHeFlVdmJpQjNkYkJmMXNON2g4NGZRSWg5bVBEUkwxWVE3WFh3?=
 =?utf-8?B?RnV5TWNmMFVBOUVkaFZWNUxHMDFwRHQxOTA4VkR6UWRZNVl0bUxLUFFBZkhn?=
 =?utf-8?B?RGRhbVZyanFzNTJzYmRSaEg5dXJibXUwV1UvR0hjVXEydjA1SjFuUHdUZFhH?=
 =?utf-8?B?UHd6WDIrZHRBZERUVmJRakR4UXUvekVnWEovUytySFhqOGZKbHBLRGc3N3VF?=
 =?utf-8?B?ZHY2UGdNZWJoWG9GU2JEUTJ1RG5sMWQ2MjhTZXcxa3AyZ0VHTHJWTzg4aGRG?=
 =?utf-8?B?cWo4czFjZUFlQTBoOGQxbkpCbmxreFBLMStXTEZCVnNNSkU2ZFhpV1QxYXFk?=
 =?utf-8?B?aHdlTXNqcXpkb3Y4SXRyNW92S0FraGtxb013K2xYNEYycEFrelovc205ZnRR?=
 =?utf-8?B?VVVoWW5pcW5jUGp1WGdTYitpQmRxOERLaUV1RWh2ckhMWmJSU0lqWm52MzFP?=
 =?utf-8?B?QnpHMzJLVkZWS3pUckVlWVN6a1dlSVo4Z0xPVGhzNVloN25JejdKZFJLVk5r?=
 =?utf-8?B?ZFhYTWgrVW9QMWlXSTZpakZyaDVIVnhMNTVGMGl5dWV6RmkwUmhHcTBZRUY1?=
 =?utf-8?B?R3paMEd3M1BRMitIR0xiYnJTdWRiVjBBOVpsUHh0U2UvaWx5c0JFeER4UHpW?=
 =?utf-8?B?a05tbFNBMWlKVDZZSGx6RjRML25xdEpuRElaVzRyZGlFRTZaNzlxRXg0MENI?=
 =?utf-8?B?T1IwcjFsWFV1dklKZjZRcEtKRFdtVXl6TktlY0hEUitWY2ZMN3Foa01aUWVx?=
 =?utf-8?B?aWh1YUdNZGNEejZ2SkgzNnlaOFZvbGtYRWllVjJCOENXVVBGZFRNVDlIRGc3?=
 =?utf-8?B?dHZHZFMxTDZESTMrS0Y5SU9aZ2lGRHB5bzBaRG40NmRIMHdsUENsejN6Q1Iw?=
 =?utf-8?B?cUJLb1lCbW02bVZnZHU2SEtFUVVGeVBSZjczam5UVDB1TGhFVVFycTEyWGZ1?=
 =?utf-8?B?SWg4SStNVlNmNzVSRlVZcVRSY0dQVWtQYWN6VDJEUnJPWDFwU2RqOGoxWTFr?=
 =?utf-8?B?NHZxaUhuWksxaXJzbEVDRmVOK2dsNktiVElxa05GVHo1NE14c1ZwdHdOZWNq?=
 =?utf-8?B?ZWE5V1NTSTlXb3JhN2J4elVETkpDUVdZRzNGY0J0RGNQRXZHVng0aHU3eVRr?=
 =?utf-8?B?U3g4cHg2R0pRQlJqNW9ONDM0dGFRdWZtZXZnajJDNTlxQjc1YmNGUVVkOG4r?=
 =?utf-8?B?M0xDR3FLa2R1RXFOSE91SU11SkJZOHdPZnFERm5QOEFQQmlMOW5uc1h4N0M2?=
 =?utf-8?B?eEhmYlUwNEh2M29jQUM1dDljNit2QzhUSlhNSmMwZUxaTEpYaFZCbG1aTGtl?=
 =?utf-8?B?Tm1pWnd6dmtTQmU0RmtqaWp2eTExK0tFWmRTRmxDSjl5V2xqdkIwRFIvMVZW?=
 =?utf-8?B?Y1M0RnloTzRQbFMrU2NxTVNKKzFMQ2x1NWVjK29paVNiNE82SEF5QkJBL1dt?=
 =?utf-8?B?YjlLTnlpcWsyZitIaEF3eWpwUEJ2SHV0b2dQb1RrcFVXYmhaOW1zMkxQRzZl?=
 =?utf-8?B?VHJHdFBnV05mY0xoOWlxRWttRXMyUU5aMjUwMmtKNWRkbTJMVUQ2Z040NExr?=
 =?utf-8?B?eVJ3MkJlQkowZTY2SVAvb2M3MFNVTGNBL2RtN0pjOGVCUnp3djg1ZFpwRm9Q?=
 =?utf-8?Q?WZa8KxvZHF5a7Xlk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f1b1feb5-bd5e-47b0-30dd-08da1c5e9fa4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 08:29:55.8437
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8gZjfUvrTO8U0wB7Brnl2SNjKj/hW9KDOGj2sXEZiR3Dh16+iQvGd5g8M7nzSJOdQEGzNhHwbSy4M6xVVYVNpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3718
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:36:43AM +0200, Jan Beulich wrote:
> While 97af062b89d5 ("IOMMU/x86: maintain a per-device pseudo domain ID")
> took care of not making things worse, plugging pre-existing leaks wasn't
> the purpose of that change; they're not security relevant after all.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 08:46:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 08:46:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303511.517792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neC9v-00030x-N5; Tue, 12 Apr 2022 08:45:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303511.517792; Tue, 12 Apr 2022 08:45:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neC9v-00030q-Jl; Tue, 12 Apr 2022 08:45:59 +0000
Received: by outflank-mailman (input) for mailman id 303511;
 Tue, 12 Apr 2022 08:45:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neC9u-00030g-8O; Tue, 12 Apr 2022 08:45:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neC9u-0005Fp-3h; Tue, 12 Apr 2022 08:45:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neC9t-0003eq-PH; Tue, 12 Apr 2022 08:45:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neC9t-0006pS-Op; Tue, 12 Apr 2022 08:45:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LmFG8hcHNuP59GIO47qjbZ0u2ofJBBBilOq6OrNLs0I=; b=V28fDe5cuN92NCAmesOEXl1zvD
	ZVFUA7jZqDHeXWmWWzItXAlCZDTw1s6Ht1WihEWxMgKqSqOkyNHNfWcW7SWu8izcj83WHOH/1dRTg
	dDY1XtV+gvUMqBIP5kwEXr2dyPl5Hr76kahmEW5xpNliFl+zQfjINP8isVx8Q0z74BVM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169326-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169326: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=5576b17363e92ce07e9707478061d5ce38bf7d06
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 08:45:57 +0000

flight 169326 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169326/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 5576b17363e92ce07e9707478061d5ce38bf7d06
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  340 attempts
Testing same since   169324  2022-04-12 07:10:23 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4911 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:10:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:10:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303520.517803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neCXT-0006KM-Ol; Tue, 12 Apr 2022 09:10:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303520.517803; Tue, 12 Apr 2022 09:10:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neCXT-0006KF-Lf; Tue, 12 Apr 2022 09:10:19 +0000
Received: by outflank-mailman (input) for mailman id 303520;
 Tue, 12 Apr 2022 09:10:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neCXT-0006K5-31; Tue, 12 Apr 2022 09:10:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neCXS-0005gL-Vu; Tue, 12 Apr 2022 09:10:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neCXS-0004FJ-JM; Tue, 12 Apr 2022 09:10:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neCXS-00049e-It; Tue, 12 Apr 2022 09:10:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KO+LVtHwpuqlsKkmFQlzOlcC1bsAYmkLQXNt0DglZi4=; b=7MTYy0j4KvlqZeWX8paojXQpVD
	FcC+vxDzORFQwbdV2SW6DiN32QAawkgt8iaIrot+UoCJKu3wlix+2i5RjXCG1MS8jyrnAHfW7p70X
	KvPHo4RPuWtONmTXqPiVDeqfJPsyy8Vh6nMAq9BLSvrLTjngJ1/rHu4MJLHivi/iaQGw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169322-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169322: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=df757e88fdb26e64e6b5a5c786e6f59d1d9b130a
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 09:10:18 +0000

flight 169322 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169322/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              df757e88fdb26e64e6b5a5c786e6f59d1d9b130a
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  641 days
Failing since        151818  2020-07-11 04:18:52 Z  640 days  622 attempts
Testing same since   169322  2022-04-12 04:19:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104159 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:20:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:20:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303528.517813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neChN-0007p7-M0; Tue, 12 Apr 2022 09:20:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303528.517813; Tue, 12 Apr 2022 09:20:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neChN-0007p0-J5; Tue, 12 Apr 2022 09:20:33 +0000
Received: by outflank-mailman (input) for mailman id 303528;
 Tue, 12 Apr 2022 09:20:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neChM-0007op-Aq; Tue, 12 Apr 2022 09:20:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neChM-0005uo-1O; Tue, 12 Apr 2022 09:20:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neChL-0004TD-Ii; Tue, 12 Apr 2022 09:20:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neChL-0006I5-ID; Tue, 12 Apr 2022 09:20:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OncJ7CRgT8wSbaqw0WoC++6HfQkac80XTJ9Iv5CCrQo=; b=5mVHjzbXUTLEF44+SrYBam42ar
	gw9cPq75Z2BrOIrCvHq6+D+3jd1Rk1sgoFZzbQKX4w+rTuEb4ugDyHT0gUWXBpW9xJu6mdKGIv7uH
	4+M2TlzmCZhLieU1Y/SrtLCFnBbqQg7t87MWzrYU01YizKMqJDzUeSTIwPtmoXyvvAVc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169318-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169318: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f44201124e8713f6eff80f349351b5740001c6fc
X-Osstest-Versions-That:
    xen=f44201124e8713f6eff80f349351b5740001c6fc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 09:20:31 +0000

flight 169318 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169318/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat  fail pass in 169309

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169309
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169309
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169309
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169309
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169309
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 169309
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169309
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169309
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169309
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169309
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169309
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169309
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169309
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  f44201124e8713f6eff80f349351b5740001c6fc
baseline version:
 xen                  f44201124e8713f6eff80f349351b5740001c6fc

Last test of basis   169318  2022-04-12 01:51:50 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:23:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:23:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303537.517825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neCju-00006d-9M; Tue, 12 Apr 2022 09:23:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303537.517825; Tue, 12 Apr 2022 09:23:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neCju-00006W-6E; Tue, 12 Apr 2022 09:23:10 +0000
Received: by outflank-mailman (input) for mailman id 303537;
 Tue, 12 Apr 2022 09:23:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neCjs-00006Q-Ng
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 09:23:08 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 28af536b-ba42-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 11:23:07 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28af536b-ba42-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649755387;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=/Gnjo/xY88ob8Hx229+4Bgq36VKYmqSc/6gVO/nOMLk=;
  b=bYwJ0XjCHXV5vR+rHhXpzxfv7K0L21gd/0Mp5bTDevyoqqnS+ecNuZ4T
   4p/v3H/FSDSJzBy3nIKLo9qID47OpcvB+7ueN4KoSMf/xWK+Xrx8kYd6J
   F89FQAD/Gk6w8mztEVTzdmDK7tL2w2d68uN4YXLRUfuC3RrMTLtbR4/w3
   w=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68655857
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ABB1a66D4FRFo7wuL3kVygxRtBTHchMFZxGqfqrLsTDasY5as4F+v
 mYZWG+DOqnbZ2f3fY9+O4y19UNQ7ZXczNFlGlA/pHthHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTgWVvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurS+Wwl2JKPvgdgnThxKN3ojHJBcouDIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQTaiDO
 ppENlKDajzFb1oIJU43M6gnxuqL33b4QWx8iAua8P9fD2/7k1UqjemF3MDuUt+HW8RT2FqZr
 2Tu/mLlDxVcP9uaoRKd+2+orv/Cm2X8Qo16PL+y++NugVaT7ncOExBQXly+ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nMEkS2Mw2
 HyQo+n0AC5L6+C0dGjHqbjB+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm
 lhmuAB73uxO1pBTi81X6Hid21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshTVflhdwTXGY3h+Y1FAd7fblUwZnY1QvEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/MmPNrgW5RzkPK9fTgAahwyRoARCnSWXFXZlByCmGbKhzy9+KTSufxX1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClY+QzF+VqWJmNvMueVNxsxoqwsBx
 VnkMmdww1vjn3zXbwKMb3FocrT0Wphj63k8OEQR0ZyAgRDPva7HAH8jSqYK
IronPort-HdrOrdr: A9a23:xtf53K0ai+EH6RGba6THAAqjBStyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79
 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhRQpENRGtldBm9Ce3im+yZNNW977PQCZf
 6hDp0tnUveRZ1bVLXxOpFDNNKz0uHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G
 DZm0ihj5/T/s2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN
 7Qyi1Qdfhb2jf0RCWYsBHt0w7v3HIH7GLj80aRhT/ZrcnwVFsBerx8rLMcViGcx1srvdl63q
 4O9XmerYBrARTJmzm4z8TUVjlx/3DE70YKoKo2tThyQIEeYLheocg050VOCqoNGyr89cQODP
 RuNsfB//xbGGnqIEwxhlMfgOBEY05DXStvGiM5y46oOnlt7TxEJnIjtY0idixqzuN5d3FGj9
 60RZiA2os+CvP+VpgNd9vpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZWXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68655857"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H3Vi7gEbs7KByGdpO49C2Re+d72J+3tFIzg49SpNXO8xTx3gjCWGQO8OckTaQoOmKSN6SGF7YdNf8uin2GbD5VJQl5f5WQiLPClc+eK2sY4iLi9kaoTuYpAch5n7jzVsP2jrPIJJBpOc7OcaVisTOCAcUIZQdrqc7+06k+/DU4LXsaJMc9ewq7cFxjTq62SiNxEe0pNzMMGx/REi5NnwNMgrrktidgpc8J2Z2ZYqkMEfQxl/H53aMZz/3X6vOptb6iqMOCc2l0qJ9mFWwjWp4oseiAutj+DD3/eQnQUH84G32P0TXYK2DZAOXxeQeOaiKwchP4A2dOaRaVB9nC4ECA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j1xvT0fQk+N1z2+I1Q0QHhEkltRtiJLLoSK7wbUdhcQ=;
 b=nwy1qLV7BlWOdtz6MBeHeXhHwkSER3fgl3XwgfoHv4hB43a7hBXQGeuBqj4Gd8BpYvah57KWvU5+iPDdiaU+va0tRHMHCP7JX77ux3hO3F+U8Q9ee0B0RSn1fPofLH2BSvaM/7VU/7fUrzJizmf5PDGVNWV63YqNgb0ipLeG1qzzOYddk544j4gAXFZEjKxUkuRBqInHkyPWNDudMsXU32EyS/u6h6wcKhvjU9VakDEepYzB6pfMdOvxS5VmyHuZEPrmo43qqcmyMSUV++G7DEIoIfNbcJvhe2UB25RstiNk3No0sGTlPgxpYZqaOh1RPqRWLGgq+5RiZPe59LTDmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j1xvT0fQk+N1z2+I1Q0QHhEkltRtiJLLoSK7wbUdhcQ=;
 b=QeqP4eB4bUnauX+1ZB6I2Lg4cn6hj/Vte5jyaI7i/OfAQUNQOCAr5+goacU//+hlvnjAwx1FL1gXYcChQrSn4Y5elQO7p1ZuOuCsotdILYGJ4ICTTSoGb0yKGMEMbThJmXwUmBQBviKfiDBH+M1uqy/UBu2oUHSV1gh0lEd6634=
Date: Tue, 12 Apr 2022 11:22:56 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 4/8] VT-d: refuse to use IOMMU with reserved CAP.ND value
Message-ID: <YlVE8ImYfQUPEPxn@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <0f7136ae-0b52-431d-f789-4b7d5bbecb25@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0f7136ae-0b52-431d-f789-4b7d5bbecb25@suse.com>
X-ClientProxiedBy: LO4P265CA0076.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2bd::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c820fe70-a521-4512-871c-08da1c660a65
X-MS-TrafficTypeDiagnostic: BN6PR03MB2979:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <BN6PR03MB2979417B5DE5261D981B424E8FED9@BN6PR03MB2979.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cPeb3vvUOAOV2xVwjT8H79ev9V4g1BDCf9/NX1LjqFckf4viVkr3SpJxdGkVoHocQdt5ABMiIWGiQl7U7PjUu/6kftXhRfygJAvAoOB9X14CVVxWmlPFAuOrddXLZ/iOo1lk0DpUwq8Co7gjgl/0kJK2+hs0g9HNapKYSOTkh5So1eMOzm4PaGMaES+73QSOMmvZRvUksGoKR/dl7x8DSkxiv+2/jL2r/CySylaslsCTsirC5UkKDqryPMc+D4/2bNLVDpUNfN3xmKJ1UZmePydtibvy3u+oE/KOTpwQmNJbeA1xroff08V3DcvE8CKNL84CMQ9APyytR77XLZUgjWwfayWdL+Ke0yYScT9F3rqOlB5sDZiUEqVF6srIj1kGJHgBln1ARClV6YGw+zLmTeZ9aIcvwbaWz59jLshP43lozo81XMeKdjzfIBec6yxAudDFMTKm31xDDbx5baypM11VpiJ+27rZ3oYvULe/mSs4XzC6LSAl4DWy6BK0TX+3U9AeFGaKineeBqfhDbu0jXOR/fRpxerr9wh05jjHiSrze4smGlu6CgIIYuYCBJAPU/OVUWqBCEnpKPZdSkjHBicvfwHcHBZGREfZHqEHSCQU19lA+bXGHWi96uUe/2b3mhXNIyiJOLBvncVoVk2dSg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(6486002)(4744005)(85182001)(2906002)(8936002)(4326008)(8676002)(38100700002)(66556008)(66476007)(83380400001)(6916009)(66946007)(54906003)(316002)(33716001)(508600001)(6666004)(9686003)(86362001)(26005)(186003)(82960400001)(6506007)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDN6ejJCUGk0dFlVTXVGZUFYU0t5ZnFhVXRVSXdPejhsRUFWcU9vaHUyNDlP?=
 =?utf-8?B?VVNKQnUrTzlEbjJ5SU9rdjkyY2dtZGd0aHJOcVp2TnhtM2pyeTg1TnZtSFRZ?=
 =?utf-8?B?VGJjZWRPblB6eEp5QlhsQ0pnNzBONW5CTVdqTUp4MjFBbFFXU1J3WC9LWlNt?=
 =?utf-8?B?Y3ArSVQ4eDZPZlBRcHZ0NThNV2lKTGVNSTZRK29LNFJKdWppMXVLZ2wyTnl3?=
 =?utf-8?B?dXAzQm9hNjlCWU4xRXFZdUg5TjJ2Y2VwNFg0UkVMeUlGYWZMRWFZZnVyMXhw?=
 =?utf-8?B?Tyt5MzROa1V5WldFVGVUR3hIUkVoWkVTUURaTmU0K0Zaa3FtZWxHUjdVZTBs?=
 =?utf-8?B?N0pLRU1hLzU2eDhLU2F3U1Brd2RqVHdKQmFlb3AzYUEzZVNlc1AwZnpvRXQ5?=
 =?utf-8?B?d3lOVkxxUmNOT1dna0gveGJtb05jMWZ5NWZva2VZaWVhRDVVZVhyYysrcW5r?=
 =?utf-8?B?Sy9ZUVZOT0ZJUlBTWDNLMlAyZ2YydUNDQit1disxZlNiS2h3UDBzSGtQUExr?=
 =?utf-8?B?U1lqOVJDNmRUTDVGcTRTa1dNbzhyTVF3Tnk1N2FOYURNWWg0dHFpcjcvOXJh?=
 =?utf-8?B?NDlwb2ZaRUhYREpjMFVEZUpYR0ZCYVVmbEdiVTNBbzR3N3d2MHBoYnA2emNQ?=
 =?utf-8?B?QU0yUHo1RDYyUmNrWHNnbWNKSW5rUVpZYmt1ZVdQUjcyR3VZQThBWnhva2pN?=
 =?utf-8?B?V0ZHNnJ6QlE2eEF2U245NXo0NWk3QTNzQWJCREVQQlIwMlVMRnN5Sm43YjU2?=
 =?utf-8?B?T01wSndXNTk0MmkweDFHbCtVdmp3aVlRY01MRXI5Q0VtMmlWNjRXTkpSNXFB?=
 =?utf-8?B?SWJvRnFIWE8vV0VKZjZGL2s2UjArM1QyVWFQSk9tbWNoTnBJWVo0bmh4MnBn?=
 =?utf-8?B?U3dIOGl5T1N1QWM2bE1EQU1DRGVaYnZudElwS0xkaVhGVlVmOWtjWnh2N2Jp?=
 =?utf-8?B?RHVCUDBxQVVtcmhWaWR5Y3Qza3Vha0RPcXF1Wm1FSDJKRTZjZ3RTTHVZSnFq?=
 =?utf-8?B?Zm5RWk5uaEVZRWNPdXVBNjdmSGRwcDRXWmt2UGZ4WTJQTmpBWUpicEFYQU5v?=
 =?utf-8?B?UzJMOUc4MlpsY2JJczRZdThWY3lueXRjaXA4akFCSEtJblNPeFgvVy9sbzRE?=
 =?utf-8?B?VVlWakUzSEFYcFVqOW1iRVNMQkpGRm1WMG0xRE9ySE9Xc3lwSlRENDVGSlVI?=
 =?utf-8?B?cWY2MnZmazVXS1gwdGpEd1ZyOFViTHQ3WXdKS2RmRUpYOXR0UWNNZGRLbmo2?=
 =?utf-8?B?UXJuYVFiQmZFT1dLTkdyUjVrWkd4RjJpa3VOQzR3Qy9Nc1AybVNaSzBzSC9k?=
 =?utf-8?B?bjRWQUZKeGROQXViT3IyN0hNSHdCbW0xeWIyREJnTC9wM3R4c29FaVVDZHg4?=
 =?utf-8?B?aFNla3FhU05vc0hlY1dibCtrcENMRDljYlhOWFhkZ21STGJ0Qyt4TUwvcTlv?=
 =?utf-8?B?cU5kMUNTVXNrSUxVanA3RmE0cHRidFZMNHo5YSszOWhoQXFJN2E2WXdoR05u?=
 =?utf-8?B?NU5RUjJrelNJRG9pTlBJd2V3cEN4UkE4SUJPQURmcGF5MjFLaHhVVSs0OGtr?=
 =?utf-8?B?UUNtUzVySmJMdFI2TlUyQmRTcWQ5bFo1YWtzZlJ4UGp2ZXVvQ3FWSE9QRFBz?=
 =?utf-8?B?MFZmcmNMS1lXaVJrREFITDRvN05lalhrZTdNWXJ3NWE4dEs2Rm9DM0FKWjVh?=
 =?utf-8?B?WGlpd0tCSTdCZC9hTlhaZCtxM3d5K2FSZG82cGV5WHZIQnlienJySTJNRFBw?=
 =?utf-8?B?djREMjZaVUFsSXZnVzQrTTcvMmQwQXhVbFdlam04ZXFmWkcwRExFTWRpdlZr?=
 =?utf-8?B?Z0liR0ZDR045Unk5SEtyVFJoV21mU21iMlpacWdvRmRxUU1nc21Gdmh5cWdh?=
 =?utf-8?B?WEtCeW9SQjNoOU52aElheDQyM3NqMmZmMkt6N2xONDUyaGprUkl1S0hEUVN6?=
 =?utf-8?B?SmRvdk1LbXV5MHdGSnV2aWxKV0VmTFplQkp6aFF4clYrdFpkby9ndWFyMUFK?=
 =?utf-8?B?RnVNNnd5UUhjMnR3OUdtMHVkTThXVm9QQTVVY0VLNXNxbW9zRGwyQzE3Uzln?=
 =?utf-8?B?V3hBZ2FtNlFXU2puRmxzSCs1cFYzalBIaWNsU0xRVEV5QU5IWVRZUFFTeHYy?=
 =?utf-8?B?OFRKWWs0VmJYbHhVVVh2VXVWWTdwRms2cHdsU1dDdThIUnp6ZlZmWkZ1allC?=
 =?utf-8?B?UkNUYVR2UDdYbnNsRnFrU1I5SWoybmpzUk5GVlR5MzR0TmZiNDdkMk83Sy9E?=
 =?utf-8?B?YmhQM2hVanEvT0VBZktVS0c1VXhCMlZ0b3BnR2NoQ1ZZMkZ2c05YQ25JdTJQ?=
 =?utf-8?B?WEM5dXQ1WGVrL2N6cnRhZFhwVm8zZHNXNUY0QmpMazJBcmUvNGwvbHAzdXZU?=
 =?utf-8?Q?wtVQfDih+QJ9Xkts=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c820fe70-a521-4512-871c-08da1c660a65
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 09:23:01.4431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +5ewk/f7DI0HxDgP63WC/DbPEOs5/VSeLBxP6TSLdmK2QGeMiP7cCFDaiMGVWwvyvE48Vniv3mY3Yo9ataVsAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2979
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:37:28AM +0200, Jan Beulich wrote:
> The field taking the value 7 (resulting in 18-bit DIDs when using the
> calculation in cap_ndoms(), when the DID fields are only 16 bits wide)
> is reserved. Instead of misbehaving in case we would encounter such an
> IOMMU, refuse to use it.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I would maybe prefer to get more specific error message rather than
"IOMMU: unsupported" and a dump of the iommu registers.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:29:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:29:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303542.517837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neCqF-0000mT-2h; Tue, 12 Apr 2022 09:29:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303542.517837; Tue, 12 Apr 2022 09:29:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neCqE-0000mM-Tr; Tue, 12 Apr 2022 09:29:42 +0000
Received: by outflank-mailman (input) for mailman id 303542;
 Tue, 12 Apr 2022 09:29:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neCqD-0000mC-Iv; Tue, 12 Apr 2022 09:29:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neCqD-00065I-Gm; Tue, 12 Apr 2022 09:29:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neCqD-0004fu-8S; Tue, 12 Apr 2022 09:29:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neCqD-00025c-7y; Tue, 12 Apr 2022 09:29:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qyg5DTOSgKXlsK6KBGUdcQBOkOaZeEUNynQI9Ftxr50=; b=miE6qRApRMRaAfm5kXBpuD6o8w
	rbv4X8hR51WuCzaKZ3NAXdQw+CxP8sETnp6wxwNNlhq7pHYDMyXb6eezi6tmP7QfmILPrqnXmhgfS
	5N3l+oUxCytM85wXcpKUZLB0tpCwUjoBjrjilaVkojPRi8EJcmMmaASNMaYHqIuNvngU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169327-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169327: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=5576b17363e92ce07e9707478061d5ce38bf7d06
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 09:29:41 +0000

flight 169327 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169327/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 5576b17363e92ce07e9707478061d5ce38bf7d06
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   42 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  341 attempts
Testing same since   169324  2022-04-12 07:10:23 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4911 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:38:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:38:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303550.517847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neCyE-0002H2-T5; Tue, 12 Apr 2022 09:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303550.517847; Tue, 12 Apr 2022 09:37:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neCyE-0002Gv-Q1; Tue, 12 Apr 2022 09:37:58 +0000
Received: by outflank-mailman (input) for mailman id 303550;
 Tue, 12 Apr 2022 09:37:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neCyC-0002Gn-Vn
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 09:37:56 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 394876a6-ba44-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 11:37:54 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 394876a6-ba44-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649756273;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=VGAE9LuMndY8zJe3XtxHZm2gQveeVOvEOwO//HrQdAE=;
  b=BpeAwPN4m/Ja+wXVcqLyRLcd1KH1Le9dgDOaFEqCtj1jtIDojqhf4isp
   aKtEM/hCXaYjzByn8hgUCki37Flry6Zr/fMTuMCMLk6Qs5vpkV3d/ADSr
   HhsrTQ6GSm28YAt//TvWKrnOyyY9GRJw28YUaQjO7+gd7UF4H7rkwtlan
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68063990
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:g0AJqKhcTYS7RuVYqhNjFaFeX161dhAKZh0ujC45NGQN5FlHY01je
 htvWG/TO/fcNzP1coonO4i0/RxX6JHdz9JlGVFs/3wwEH4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1rX4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YUQrPoLGgcYSaCVVNXsmGYhp9oTAGXfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiOP
 5RCOGs3BPjGSwBEfXQpGb0doMGt2nTDWDpipECom4NitgA/yyQuieOwYbI5YOeiXcxImm6Iq
 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcV56gGiwLP27D2lC05eFhpkR9Ids/c5EGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdQ2mY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J4swZb2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1Y5lcKG+5O
 RKJ5Gu9AaO/2lPwMsebhKrrVawXIVXIT4y5Bpg4kPITCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGLqdVDcg1QdSFT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5
 XazRglTz1+XuJENAV/ihqxLAF83YatCkA==
IronPort-HdrOrdr: A9a23:GNNIdaqJ98iegwV6yNgAOqoaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2+
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LvEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqMq+SWnqLkwxg1MfgOBFBh8Ib1S7qwk5y4GoOgFt7T5EJxBy/r1cop8CnKhNP6Wsqd
 60d5iAr4s+PfP+XZgNdNvpfvHHeFAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68063990"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N0y0v55D6fhx9qYPAeldAmaNpNppc5cwh/NYuBAxPwh14eJpFztHPRhJyn3BtMjwMnaOCKb/7ZcG/U+w0WVNiFWIh2vEPrw8Yu/ypekDxBqUYWOAs+xBlIYjbLwLPYYotdZ9Wy/0fpWD1GYkApQehrhpOABHAAj34Az/GFBBNn6MuLMWDvjZdjxH2nvkn6XqeeCwLEuZEnajHt/Q66CZGd0zMHQLQGg51B5Wshb+MK2JWFhCTPmbpITH+hNClp4j2h+hH5BsObM6f1fvQh97JlishM6zBE16srS425IMwJNaO/n95aU2F/GdkO0Jl5T09sXlrfYhXJ4T2HlAtkg9EQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o/T0vPYmoer4+e0tl/wDRTRTIttKBw2hVazDdcDYM4w=;
 b=IJmbcKu2Rc3yhweb+Nv6hujAQLqz1HTjIXrwkWO2vxfRG++CeGE88d8mT/gEc3yjz7mR5zEZT7RXwEuBA/+cSDfpZ+vHsbicK9BkVqCMxHTdPMso1Op+CgE5ap0zDRTpfkSWDAdxV6hz+b58bqzkoUJ+98pt/s/q1rTYuevPeaJAXnaFcdzKhS2keSw+rwlXKWX3UMDTjc1exKCqy+6qndUs9chET471RmuiY4FzkTZo1nsuamldTLXSii23Jm4zV0Oqhm949sZR4mR/Wljpjh0vs6+DE8vehtxJyTKCKmB1xNl2fp4E9B8Gyh5hzQq/FSlVP7fjXkLBw4ntomZejQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=o/T0vPYmoer4+e0tl/wDRTRTIttKBw2hVazDdcDYM4w=;
 b=ALiA1S+h8x2+RPJtNifsHaUdNlnKFEtSoaPEF8mug6Dy64CK3Upbi/V3So4dY6JzNwP6cnJSX/0yicAZP4dYLhU4JEovHnxPrLO7X9S1X4VfLFFI2u3+T6akcpHBF0SrC95pAQW2XDGTea6KbKUluRX9WYyiLt40poKAUawsHxw=
Date: Tue, 12 Apr 2022 11:37:40 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Paul
 Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 5/8] AMD/IOMMU: replace a few PCI_BDF2()
Message-ID: <YlVIZHMSgmMvhMyO@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <68a10516-7737-5bbe-e9e5-537031251fcc@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <68a10516-7737-5bbe-e9e5-537031251fcc@suse.com>
X-ClientProxiedBy: LO4P123CA0059.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: addb4a6b-80a8-4dd3-016e-08da1c68194c
X-MS-TrafficTypeDiagnostic: DM6PR03MB4922:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB4922230268C4665643A1FA0D8FED9@DM6PR03MB4922.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ykI4Y5eeJc7w4baFd3nWml9xwtu00wpbfAPhJ1+Nun2mfVrJb8GAGgjQtf0N5zmuWSn7RL9Vdf4lbRTifZfiejiVFss08CToj/9yz9XkDGZT4VyJQnKi0HL880J8W103NiuHVWRbBSyxqv9h96N5r33/zEvDZKSTfuFBMGWRSI2kMmw2+z2Su+j4py5nz5qHD+hqKg7DBDEIIRbzlIi47ZCkzE94kKrWCu9RkY088VqMch7uLBLTAQGpJLvv8rdm9T0LaNhqV1eSCopsugGGBry/70Sr6jKAuMkWqgPnGahjBoESAzVyedxVgmioxrG9bpG/GbNR0E/6VN4qyPNSZXVmvJR65KQWX1UTFD3VmQsp8Fnddomph4IUxpTd6PlZKkNmsjBEUoE/jaZse59K8Fpt/+IoD6Ez2TVV2qvwtkg6cSXWZTPx4V1jDZtRi6+J3tET1iC5DDyZhtYLJL4f3teypgSdCq/hliRsD9G8+DE0MlUe0XX9J7aErin20J7Wqa8lT6gqjJVBEFiRNW2vViHoIRSjsOGYjWnY82oc8t09yKWyMTnrOym5ylyTHQsu2kk0Im/pLoWCWpNHX1RXdLyCEtsPOgKPbTqCwnhxrFrO4nawdgqBdRVBlEhlPcf+O7RQVMwycSz5BqyKfEJjnQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(85182001)(6512007)(26005)(9686003)(83380400001)(6666004)(107886003)(186003)(6506007)(508600001)(5660300002)(8936002)(33716001)(2906002)(86362001)(38100700002)(4744005)(6486002)(6916009)(54906003)(316002)(66946007)(82960400001)(66556008)(8676002)(4326008)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjVVandRNmI0TGhPZzduekRKdXQzM0FEUnArMHNyVlF3ZUdtRklUejA0M0ln?=
 =?utf-8?B?WVFVVW9qOWFmK2xPSlg3Ym5qR0liR3hCbFl2ZFBtblVGakl4YldlRUpQcE8w?=
 =?utf-8?B?N2RLUXJaN1BSYkhKVURNSDUxMlVaTDlkdkVhc0ZteTM1d0V6UU12ZkVzSzlm?=
 =?utf-8?B?V3BOWmNDSnYrVzVVT21mcnNEd1FSUjU0QVBTTXQwRzNIQ0hBZC8rQ1NpcVhZ?=
 =?utf-8?B?UDdPdHdVaDFqY3FLSmUvS3FKdkRYbXlsSWJJRkY3aGg4RCtyUlNtTkNCNUdn?=
 =?utf-8?B?TEkwNTZMQStFVVZoQ01Qa3lpS3RQdm5jUDM0YVNSWkk0UEJkS3VUeXNXOHJk?=
 =?utf-8?B?NEpwc0Uyeko5WnlJdFJLbFRhVXBuK1c5SnF3OFpJOHdlT0d4eWozSm53ZWVS?=
 =?utf-8?B?M05BLzc5Q0pISWs4cllJdUVMR0ViVzRyVEJ0Mll5VUdOSDArcDRKN1loWXRh?=
 =?utf-8?B?U051TU9QL0wydzM3VEw1clFhTGJmSzQzYkI2WDFDMHRqOE9RZjhsYTRkQUlS?=
 =?utf-8?B?bm5qK1l1RmFrMFQ3R045OWs3WVVHSUlTYitHcy9ubGsvL0xTTkpYL2l0RC9Q?=
 =?utf-8?B?V3lFZGVkNnJqS3V2b2hXK1Vkd3ZnaGFaaDZMbGNidndVVUFVTU13SEwzSjY5?=
 =?utf-8?B?WGhYa21CMWhOSXpoTnBmU3d3M3k4UXBocS9YL1h1d0xZRWYyQ2x6ejNBaGNG?=
 =?utf-8?B?MTJzazluajc1NlJyUGdyVXJ3UWw4eHQ3SkgyazlseUJyeG05Z0VHdnkvL1A0?=
 =?utf-8?B?Ym1DVlNFbDBmc05oKzV4YUtHSExZcHlNVWh0OUgzcDV4YjArY0NMM0Y5Sk4x?=
 =?utf-8?B?MDdUMENrbnAzQjl6YmdyQ3FsakhJNzNpKzZSckRuTy81VmJuZ0VpRUwzMENC?=
 =?utf-8?B?OWVFM0hDa2lvL0d4RFhUTk1FNUR4STI3UytDc2Q4N3ljay9xd1ZUNVJENmN0?=
 =?utf-8?B?dEx1bzA1SWVrRTJ0amRxTHVmdmdIQkZKUUwrSTZpQWhnK3B0bm9BbmFuS0Jv?=
 =?utf-8?B?YkN3clpyWDNOUjFsSjA5WVhRdXNOdnRKVEFHN2VBUWl5MkZtZ2d4aWNrUGZY?=
 =?utf-8?B?WUhqT2JNWmQrMkxucWxuanlGbEZqbWM5aXNSbnFmV0NYUGlNblJWY3JERlhV?=
 =?utf-8?B?OWpPRTBnZ2VUS1phdkJvaCsxMkZwWW1XSFFkdG41a2ova3JiZXpzZFFzT0pk?=
 =?utf-8?B?VkFxVmVEOXNtdDVVNEhYTExTVlJsUkNIZERCMzN2RDhSR2dhWEs0aVJIRytw?=
 =?utf-8?B?eXI4TFhHcEh3QnJ2dkxlaE15andVdXpnNmx1T2hpYkppZ1VGNEV1ZGpsdFVj?=
 =?utf-8?B?YzdielRHa2hOK1pWUjNSZGNUM2J3d1ZTeUdWaG5QR2FIbDhXcUVCZUVPa3hF?=
 =?utf-8?B?OHBoWVpobVNtTTdMTmNGTlBFVDgyT0pGdldMWWU1dElSZ1B4RXhYOGpZbHhp?=
 =?utf-8?B?S3FPMGw5UmdMMGlSVjNDWDJkOVpFTWdOdlhGYWRCaG00L0E2aXVRVDVkQXRO?=
 =?utf-8?B?YU9ieXpWL0MxbmpSc2xhVW5TeCtvNm9KNUN1U0p1OHh2cjZDeFVnTmhZZjZx?=
 =?utf-8?B?cGZ1Um4yTEZ3OStWQUozSU9MS3N6blFCVm54NnhoOGN1WnM5LzdyVG9Pd1o1?=
 =?utf-8?B?RWxhTDh3UmRMeUhvZUNCSDFIT2RCbXlBRHlEZTd6cVY0M0NMT3hDOVVpRmc0?=
 =?utf-8?B?S0hjNjgxSDBIcUdjQVpCd0k1TGVwaC95YTZUN0VLa3lXSjdrYzZaM1BJZkJX?=
 =?utf-8?B?eUppanI1YUxkVGNIRHI1TWZndjJsMTA0R2tGMWpIWmlGUDFWclBrUmM1QjAz?=
 =?utf-8?B?NGpOMk4vQ0NaVnNUVDM4Vy81a2owOEQ0akdiNFFiOWJBM3JqaGZQcXF0N0dr?=
 =?utf-8?B?aCtGWFZQTU5KQWV1dEpVRmJwakR6aVFFOGdVZkg5VjcwUTRWVElxYjhOV3No?=
 =?utf-8?B?NlA2Y3BWNnloRjdFcW1nSWNrVlE1d1BOUVQ5WTlTdGl4RVBxdWthQ0dtSi91?=
 =?utf-8?B?WDNndjBTSXU0MzJ6dnpNajRFV3dvOWlpMlJ2b3FiR1J3U08vamlRSU9Xay94?=
 =?utf-8?B?TFdzNUZxVnhMcmtyQ3JOeHhua3hEM3NCSStUWFZuWldVanJNSmtVaCtQV3BU?=
 =?utf-8?B?RFFjcVZ1SjFiSC9RNVQxMmliTlNmV1NaSWZTOGVUQXJIS0FJRDlCb2w4d0Qw?=
 =?utf-8?B?OHJ6YnhmWXVYTTlFQ0R4QVp4RldjSlprcUd2eWtYdUt5THc4UElOVVlwQlU5?=
 =?utf-8?B?aW5NQndxSEJaV2UyRm1BVVV6NGo0OVViVFk3WS9GNXJweUxORU5xcjZ1bmZl?=
 =?utf-8?B?cU84QVpweTZrRTlIQWk1Rm5qSjc1enhIcTRKVHRUbVRnL2ZJNzlZeFZoQjJM?=
 =?utf-8?Q?yvLYA0hGOlKfAyOA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: addb4a6b-80a8-4dd3-016e-08da1c68194c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 09:37:45.4028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2t9PLsSmHJGdogZElTt4SuqfaY1mLLNvOP3CjjVCKvCsfN89bCpU6I7HrQW/CthrbuNfn1aUaTPYMfT9fKUNyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4922
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:37:52AM +0200, Jan Beulich wrote:
> struct pci_dev has the wanted value directly available; use it. Note
> that this fixes a - imo benign - mistake in reassign_device(): The unity
> map removal ought to be based on the passed in devfn (as is the case on
> the establishing side). This is benign because the mappings would be
> removed anyway a little later, when the "main" device gets processed.
> While there also limit the scope of two variables in that function.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:51:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:51:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303556.517857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDBZ-0004cF-9L; Tue, 12 Apr 2022 09:51:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303556.517857; Tue, 12 Apr 2022 09:51:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDBZ-0004c8-6O; Tue, 12 Apr 2022 09:51:45 +0000
Received: by outflank-mailman (input) for mailman id 303556;
 Tue, 12 Apr 2022 09:51:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a6AI=UW=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1neDBX-0004c2-IK
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 09:51:43 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20617.outbound.protection.outlook.com
 [2a01:111:f400:7d00::617])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 27677fdf-ba46-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 11:51:41 +0200 (CEST)
Received: from AS8PR04CA0163.eurprd04.prod.outlook.com (2603:10a6:20b:331::18)
 by AM4PR08MB2899.eurprd08.prod.outlook.com (2603:10a6:205:c::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.28; Tue, 12 Apr
 2022 09:50:35 +0000
Received: from AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:331:cafe::d) by AS8PR04CA0163.outlook.office365.com
 (2603:10a6:20b:331::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30 via Frontend
 Transport; Tue, 12 Apr 2022 09:50:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT020.mail.protection.outlook.com (10.152.16.116) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.21 via Frontend Transport; Tue, 12 Apr 2022 09:50:34 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Tue, 12 Apr 2022 09:50:34 +0000
Received: from 7ec17d0f6e68.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1EEDF5F5-73E6-40F4-A10C-40BA31EC59A8.1; 
 Tue, 12 Apr 2022 09:50:24 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7ec17d0f6e68.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Apr 2022 09:50:24 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM5PR0802MB2579.eurprd08.prod.outlook.com (2603:10a6:203:98::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr
 2022 09:50:20 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5164.018; Tue, 12 Apr 2022
 09:50:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27677fdf-ba46-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=asu0CyeScnBHv5f5vIkVFLQ6qpUK4+P2qZSyeGjOI/E=;
 b=pMCLBuzvURIEAxm9VzjaeUkHe3fsynCON3i6Y+DhAQfuVlK/sc5DVsrZToHM6Q+JWIx+bInEYQ03z0F94LCTVCncm5fO8UnepB4zHFV2nq81FbODTzH+3+0uQNl3oV/WrLRRRwo12fK82HfiJ9jVVTSpT6UItAUxWcgEb3H6tqo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0e8512fa307914e7
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EDzT6W9lAgX5/+nu4O9pVwSAb0PzLu6j474SRxNqm2A1f1sEoMSqj7v2YJsRqTD6SQ2cbhBoHIU0VS4AJTnFUcS9cw76L/azC/gPl504FrBMI0PTG2aFh68Q0J2cu6wKWSfs/656tFdQU+Na+wSqpXsQtLe42ekq7pPdotGJ7jym6ckPBFtZV4nUFL0NaafXoVihc8bDPkVF+DRR4jsphL79XLGoLxl7AkhK8zvzQdFEdbgy8mnpMJWRpD9Gxikfvsc3T1nOU27PuACsr9UVHTtR/reGAoCdBG0Gxq5ITWp9tvFC1HegQZC8ZhIn66W15YOENR149ZHhGRL6CZKh/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=asu0CyeScnBHv5f5vIkVFLQ6qpUK4+P2qZSyeGjOI/E=;
 b=Z6jdYKs1IQQIPF79BLd2aDhTkBzfrstLXH6t7xOxbecwtfYfoODuBMxyDJVGDd+fc/yuQLRw2gkDSSfgGtVP72Bb9gsLSRCDkGFhuzEqXRVAob5LPXkup1nnlE5AUJwIQS/yMaU+9PaKRmjw+9YvI9uVeh0yh3icL3ytd4XhChrsskumeE75x/SN4TdLHI1OPMJnCPaEYS2bHwpqyiD3P3WwdB+vhKVDETFeItgtYKpj6v1fmFkPJt4AN7jg8rtsmYnQ3hCvhVnV0ahimjarDTE8TCJjGmMmT7lYxvCJDTS23t4DrthZ/v+LweY4GZbVTVBfhSg27aduhGUe9FMFbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=asu0CyeScnBHv5f5vIkVFLQ6qpUK4+P2qZSyeGjOI/E=;
 b=pMCLBuzvURIEAxm9VzjaeUkHe3fsynCON3i6Y+DhAQfuVlK/sc5DVsrZToHM6Q+JWIx+bInEYQ03z0F94LCTVCncm5fO8UnepB4zHFV2nq81FbODTzH+3+0uQNl3oV/WrLRRRwo12fK82HfiJ9jVVTSpT6UItAUxWcgEb3H6tqo=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Dario Faggioli <dfaggioli@suse.com>, Juergen
 Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Thread-Index: AQHYTbfiNTg+IXy/G0GwaoqGDOL0yazq2Y4AgAEwcQA=
Date: Tue, 12 Apr 2022 09:50:19 +0000
Message-ID: <86F93995-5CFD-4A43-A928-E9053B027722@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-5-luca.fancellu@arm.com>
 <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
In-Reply-To: <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 9aadea08-b703-4674-c7ae-08da1c69e3ea
x-ms-traffictypediagnostic:
	AM5PR0802MB2579:EE_|AM5EUR03FT020:EE_|AM4PR08MB2899:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR08MB28995636B91803F93A70BC92E4ED9@AM4PR08MB2899.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 OxOZv1BX6WT8KS8vhdUb5mZb2pK0q637o4eIsIwvpP3yDLIGXbLTd2rDETk4kuta66A3J6PPmRmP3ADEbfTOiSphenrLebup2ixv27lYQxxBlqkIRNKHuM6I1EybmjEIWhVYT2CGURVcbu9d2kyI8cUxTmwXPWs40D6L/itbY9oEkaOVNX/Z2EFenrTvHYztuF78xFjz/nfQ1rFkkDzMLxMoG8eG75pp5pTQJT9m4naBZkJzIV6oeW1aX2vEeM28e66g0+T1Xdm2PrnK65eNjvY5tcVRnReMMgyGFJnpLfWrfPVTa48UNTZ23IrwI2kJqSTPTVG1Rgt8zRgybdtHvdeounEX/MBVKQJw5V4jTt7LAe1hLDEpVAKq8+9bd/FjDQgJefviUOgZJ3Q1a3qT0qgx9gel28BCXKvzq8NgyEyCQTisQRzJJyePYpjLehtNepeE+awfO+N0KwoLqpwQdIthUeVCe45cLuTBCE0PsWWxKCiHzTf3DBwNqAwiWrWxXc2I7Xj84H8f+Y35XFREjlnouq+eiwCte+MSiL0GDtdBRwKIBcxRM97rAMlgQmKfKxVMaRZjyp3jojpnLbLKzlEsm28dlTxxClgY0Dv4TRda3xw4Bf8AzRzigEeKs7Qs2GrG4KITHxumGat5pM9a7HHrFhueiA3AGerW/Mxv0fQ87Mo+O5UWz1oah/T39BcE5rFDgDBBgL2RdtobbP0bSv8t6AG2xu/ZaFITbsFJhGtDl86d7mY/NZJiqRVVKIjf
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(71200400001)(6486002)(36756003)(91956017)(86362001)(7416002)(4744005)(5660300002)(6506007)(66946007)(6916009)(2906002)(508600001)(316002)(64756008)(66476007)(76116006)(4326008)(8676002)(66446008)(66556008)(186003)(54906003)(33656002)(6512007)(26005)(122000001)(2616005)(38070700005)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <7378AD8B2CF547468F0127F618F95353@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2579
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	afd4bdf6-098c-45e9-4d0a-08da1c69db34
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qqjKytd5WbqCSdMcqugfVDAtjEyBnYkkr6uLmHY4wCdXMPd/WlTKYOl2YvEU4B6I9cBe4FxsYZTGTyyhsXIYbS4C36z+Tlo5vqbXca+zucJ75rzC7WYYOe7tNfxgpMUqaKH9UZOLslUD5BMaKmQYlqXzN3LQg3DhPo8q8ANghYbTrA8MZKpE4p2y/oDeW8SMTmd8Afi4Cv40RZ9bep03jJYItFmxzgOgdF0Hvw3nEOyCl8Z7snQoBohP9kcXxSweyiVNTdLTGy/R7WF0vsyC0t27Ms+atYrys/8pE4X15y+oLEViQk70h1NBCjuiJi2H+1GcIZaFxJ5xZ0hwvX+6bMylXkargWPpKOZUv+dTfU2T7ipCnSZIA6XrpvuNoIS3HyxvONLftsoNJ6x/37OGrdqkgY50G4CmLLMS+LG/4NwoJpXb8SmlLEGr3ZT6i6CEWP6dPcDJKFmrWOmxF+/OVix5e2DjorRUsOzlvfpMtrUUqHLljXyPbWWYl/IkGTuoMDIem1JjFMRNXvIOUeukn4dKFlHY83Tsm/ZSq5tZaeLe2bY8Bd40i+Znm95MED0LLiMTv2K+B+mAFS+uwztw2yOYjRl4viGtDFw1niXrUvFhDmF5ENZAw/EOxuHSowu2U2798SbwOs68CUS/LnyoyiipbdTOHvt6klxfFxF0OZwsP1xOIp/su2+sd2B2gz9A
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(186003)(26005)(508600001)(86362001)(316002)(54906003)(6512007)(6506007)(4326008)(2616005)(6862004)(8676002)(70206006)(70586007)(8936002)(33656002)(36756003)(336012)(356005)(81166007)(6486002)(40460700003)(82310400005)(4744005)(5660300002)(47076005)(36860700001)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 09:50:34.6836
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9aadea08-b703-4674-c7ae-08da1c69e3ea
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2899

DQo+PiAtLS0NCj4+IE1BSU5UQUlORVJTIHwgMiArLQ0KPj4gZG9jcy9taXNjL2FybS9kZXZpY2Ut
dHJlZS9jcHVwb29scy50eHQgfCAxNDAgKysrKysrKysrKysrKysrKysNCj4+IHhlbi9hcmNoL2Fy
bS9kb21haW5fYnVpbGQuYyB8IDUgKy0NCj4+IHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zbXAu
aCB8IDMgKw0KPj4geGVuL2NvbW1vbi9LY29uZmlnIHwgNyArDQo+IA0KPiBGb3IgY29uc2lzdGVu
Y3ksIHNob3VsZCB0aGUgYWRkaXRpb24gaGVyZSAtIHdpdGggLi4uDQo+IA0KPj4geGVuL2NvbW1v
bi9zY2hlZC9NYWtlZmlsZSB8IDEgKw0KPj4geGVuL2NvbW1vbi9zY2hlZC9ib290LWNwdXBvb2wu
YyB8IDIwNyArKysrKysrKysrKysrKysrKysrKysrKysrDQo+PiB4ZW4vY29tbW9uL3NjaGVkL2Nw
dXBvb2wuYyB8IDEyICstDQo+IA0KPiAuLi4gdGhlIG5ldyBmaWxlIG5vdyB1bmRlciBzY2hlZC8s
IGFsc28gYmUgcHV0IGluIHNjaGVkL0tjb25maWc/DQoNCkhpIEphbiwNCg0KSSB3YXMgbG9va2lu
ZyBmb3IgdGhpcyBjaGFuZ2UsIEkgc2VlIHhlbi9jb21tb24vS2NvbmZpZyBvZmZlcnMgdGhlIG1l
bnUg4oCcQ29tbW9uIEZlYXR1cmVz4oCdDQphbmQgdGhlIHhlbi9jb21tb24vc2NoZWQvS2NvbmZp
ZyBvZmZlcnMgdGhlIOKAnFNjaGVkdWxlcuKAnSBtZW51ICh2aXNpYmxlIHdpdGggRVhQRVJUKSwg
c28NCkkgdGhvdWdodCBpdCB3YXMgYmV0dGVyIHRvIGxlYXZlIGl0IGluIOKAnENvbW1vbiBGZWF0
dXJlc+KAnS4NCg0KQXJlIHlvdSBzdWdnZXN0aW5nIGFub3RoZXIgbWVudSB1bmRlciDigJxDb21t
b24gRmVhdHVyZXPigJ0/IA0KDQpDaGVlcnMsDQpMdWNhDQoNCj4gDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:55:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:55:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303560.517869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDFM-0005G8-Qe; Tue, 12 Apr 2022 09:55:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303560.517869; Tue, 12 Apr 2022 09:55:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDFM-0005G1-NT; Tue, 12 Apr 2022 09:55:40 +0000
Received: by outflank-mailman (input) for mailman id 303560;
 Tue, 12 Apr 2022 09:55:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hmqi=UW=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1neDFL-0005Fv-Na
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 09:55:39 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b4486e7a-ba46-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 11:55:38 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 1E1521F43F0C
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4486e7a-ba46-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649757337;
	bh=L7sIocVMVJFFf6pt5kvonBwHJBi8ufG5aawNMHgSOk0=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=S7aa0qukIEifv3VA3CuUR35b2mrfJnR/HsoJXzpmjRJMCbhxox8PyYd3y4yAh2cci
	 fkdP6WhWpX2fTNoSalTPD6PO9LosH8R/uIddoXqmSbAGkyMpOv7gtxoyhkm7Vdt7Po
	 VE+FMV4P/sBi8qGDGbVNV7G1cE0QQC1Psgi2NgDN4gF7AuPhmOvrPWztAg0OKxrhYx
	 ZY0kqCMPGfjI965JP3tWKRvKNwoFqex5VZBw8ei+llxHp+CnMQUlR0C0Mb9omyZuyR
	 pQwj21iO0qbnTtEuCeKQh+DA2pdqBpS/Tpsp0jFVlk3igIjJYKAd36t5EZ0tHXKfa6
	 Nz+EAW2F2/bCw==
Message-ID: <24a38d79-b52e-387b-5ef2-954aef05a49d@collabora.com>
Date: Tue, 12 Apr 2022 12:55:30 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v7 00/20] Introduce power-off+restart call chain API
Content-Language: en-US
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzk@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
 Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org,
 "linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
 linux-m68k <linux-m68k@lists.linux-m68k.org>,
 "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
 Parisc List <linux-parisc@vger.kernel.org>,
 linux-riscv <linux-riscv@lists.infradead.org>,
 Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM list <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <CAMuHMdVfOpGvF5FR6vFD-3a1h-7Kc_yAKQzWV71PD6mDy6BmZw@mail.gmail.com>
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
In-Reply-To: <CAMuHMdVfOpGvF5FR6vFD-3a1h-7Kc_yAKQzWV71PD6mDy6BmZw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/12/22 10:06, Geert Uytterhoeven wrote:
> Hi Dmitry,
> 
> On Tue, Apr 12, 2022 at 1:38 AM Dmitry Osipenko
> <dmitry.osipenko@collabora.com> wrote:
>> Problem
>> -------
>>
>> SoC devices require power-off call chaining functionality from kernel.
>> We have a widely used restart chaining provided by restart notifier API,
>> but nothing for power-off.
> 
>> Changelog:
>>
>> v7: - Rebased on a recent linux-next. Dropped the recently removed
>>       NDS32 architecture. Only SH and x86 arches left un-acked.
>>
>>     - Added acks from Thomas Bogendoerfer and Krzysztof Kozlowski
>>       to the MIPS and memory/emif patches respectively.
> 
> Looks like you forgot to add the actual acks?

Good catch, thank you! Indeed, I sent out the version without the acks,
but luckily it's only the acks that are missing, the code is fine.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:56:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:56:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303563.517880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDFr-0005mo-5m; Tue, 12 Apr 2022 09:56:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303563.517880; Tue, 12 Apr 2022 09:56:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDFr-0005mh-1N; Tue, 12 Apr 2022 09:56:11 +0000
Received: by outflank-mailman (input) for mailman id 303563;
 Tue, 12 Apr 2022 09:56:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hmqi=UW=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1neDFp-0005lC-GZ
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 09:56:09 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c55e6f13-ba46-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 11:56:06 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id CA7361F44465
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c55e6f13-ba46-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649757366;
	bh=zGnnxmSlqh0YJeepd6leEtd3OpvyuoG43h8kmGFF2wc=;
	h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
	b=P61L93uCY2BzkAlZkIa7DkNYhLesoazkWjHR45+XoCKZ8ns44JwAXtKwQtsKB5IWu
	 LBnshgET/1to4NkH52cenj6AcmR1fzToetNSgDLXX18/JYkgkQQSwZdaXlqZHCnpKj
	 1GBxRjPOedK74qEOQrXw+d5AInCvSk+FnCDQJJggENcP/eOVY2//qX2NkpjVfzBsqa
	 1dFmWcLJ7EUVzhKFegMKqxZGBg1v/mwnu50TrXhdgNf6aMdvdkZzAOzeVFn7EFF2vi
	 bG+4SHDoaE6xdqEupYSgMD2ed1PrE/GTXU258Xq63ayijsB2BJhDrJNAYUxYDRgOkh
	 gETvkTIe02RWg==
Message-ID: <1b95163a-4b4d-3c0d-440d-0b6dd608b393@collabora.com>
Date: Tue, 12 Apr 2022 12:55:59 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v7 16/20] mips: Use do_kernel_power_off()
Content-Language: en-US
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzk@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
 Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org,
 xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
 linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <20220411233832.391817-17-dmitry.osipenko@collabora.com>
In-Reply-To: <20220411233832.391817-17-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/12/22 02:38, Dmitry Osipenko wrote:
> Kernel now supports chained power-off handlers. Use do_kernel_power_off()
> that invokes chained power-off handlers. It also invokes legacy
> pm_power_off() for now, which will be removed once all drivers will
> be converted to the new power-off API.
> 
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>  arch/mips/kernel/reset.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
> index 6288780b779e..e7ce07b3e79b 100644
> --- a/arch/mips/kernel/reset.c
> +++ b/arch/mips/kernel/reset.c
> @@ -114,8 +114,7 @@ void machine_halt(void)
>  
>  void machine_power_off(void)
>  {
> -	if (pm_power_off)
> -		pm_power_off();
> +	do_kernel_power_off();
>  
>  #ifdef CONFIG_SMP
>  	preempt_disable();

Adding ack from Thomas that he gave to v6. It's missing in v7 by accident.

Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 09:57:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 09:57:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303566.517891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDGa-0006N2-EA; Tue, 12 Apr 2022 09:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303566.517891; Tue, 12 Apr 2022 09:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDGa-0006Mv-BB; Tue, 12 Apr 2022 09:56:56 +0000
Received: by outflank-mailman (input) for mailman id 303566;
 Tue, 12 Apr 2022 09:56:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hmqi=UW=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1neDGY-0006Me-44
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 09:56:54 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e12c19e6-ba46-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 11:56:53 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id B9CA61F444DB
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e12c19e6-ba46-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649757412;
	bh=ta29d4wnkNjIs8vxiW+spXtMVlKSVX42O2OgeMWUE4M=;
	h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
	b=kvhz7L+WR7F9HsP7+DAE1iJ09kPWZRmi5f2q6+wTFMWAjrPkNWY3Jzpgqp30kF162
	 9ej87DkBRElok2belFURZJE+6KAffcONlx+uSragUy+EKLYmrLe+OmnInaVU38Utnj
	 oGDfaSbiVVHQL6Yf2olT656ydNf9P6W4M76WukTbNC94PbuWprXpn8hcs1neMp19bi
	 iNzDzyCfCh2mIdCCNxP2XuZopGSbEx58bF1q1D3kWpmOuMeUlqToTVLTBXzlWDyGYS
	 beMdM6XO+lz1xQI7S8U0f+hcwzSbrlRYbQ5mvoaXJTg3bPRXH5hIYNcxpGgH7YbXoc
	 9fEZqqnyfRE+w==
Message-ID: <2b603d3d-c6c1-13d7-8f77-042317a41d00@collabora.com>
Date: Tue, 12 Apr 2022 12:56:46 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v7 17/20] memory: emif: Use kernel_can_power_off()
Content-Language: en-US
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzk@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
 Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org,
 xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
 linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <20220411233832.391817-18-dmitry.osipenko@collabora.com>
In-Reply-To: <20220411233832.391817-18-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/12/22 02:38, Dmitry Osipenko wrote:
> Replace legacy pm_power_off with kernel_can_power_off() helper that
> is aware about chained power-off handlers.
> 
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>  drivers/memory/emif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
> index edf3ba7447ed..fa6845313a43 100644
> --- a/drivers/memory/emif.c
> +++ b/drivers/memory/emif.c
> @@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
>  		dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
>  
>  		/* If we have Power OFF ability, use it, else try restarting */
> -		if (pm_power_off) {
> +		if (kernel_can_power_off()) {
>  			kernel_power_off();
>  		} else {
>  			WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");

Adding ack from Krzysztof that he gave to v6. It's missing in v7 by
accident.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:06:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:06:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303573.517902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDPH-00084D-EG; Tue, 12 Apr 2022 10:05:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303573.517902; Tue, 12 Apr 2022 10:05:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDPH-000846-Aj; Tue, 12 Apr 2022 10:05:55 +0000
Received: by outflank-mailman (input) for mailman id 303573;
 Tue, 12 Apr 2022 10:05:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neDPF-00083x-W0
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:05:53 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 21355f88-ba48-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 12:05:51 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21355f88-ba48-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649757951;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fomlEUlckjX3TNuc9540z65qkWJl+7ZgtSW/3GqjuXM=;
  b=A5ARRNbXI4zdTdEBNVsd5d7PXI5daCEVLALyZH+YXK2tz5sboHqHGXlw
   5IJh0azLyTijIaOwb6XNiH1MjXmb8+zTTefXKanCdpUYSGvvmTfJGYVY2
   sLx/BG8pyBjnbsEFs76bR+TD5ssmsmg6pQ/r1vLAVT2NkyIcM33SSqvjS
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68674986
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uQUeNK2xt4AKiJpSIvbD5cVxkn2cJEfYwER7XKvMYLTBsI5bp2QFz
 TYbDz2PP66KMWb9c94ibo20o0xXvsWDzd43QQc6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIx24Dga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1qmoO3cBYJB5GTt7sAUjdeFANULZNZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u1p4RQaeOO
 aL1bxJzMzPsZjJuIWwsGb4Fv8v1o0fZdGNH/Qf9Sa0fvDGIkV0ZPKLWGMLcZ9iiVchT2EGCq
 Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0fPVPFNQryDixlYWL/ge3AG8mZC5/d4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPTt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPf1
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGAhfBY5Yp9ZI2KBj
 KrvVeV5vsA70JyCN/EfXm5MI55ykfiI+SrNC5g4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3DLWlMnaKq9ZKRb3IRFBiba3LRwVsXrfrCiJtGX07Cu+XxrUkeod/mL9SmPuO9
 Xa4MnK0AnKl7ZEbAW1mskxeVY4=
IronPort-HdrOrdr: A9a23:TRnfEavEbU0qhTSDcsbbOs7U7skCkoMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN
 gsfJ4Y0I2mdfVmH56VNN1xMvdfNVa9NC4kEFjiaGgPR5t3c04klfbMkcEIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68674986"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IZ/rP3dlNREj++wfG8XPjjPD9nzUKo698Fa0FDbDSJlcANnyz72HPasos8GcQCyKgHDZIEepmvhP9nXgVlV56QUt6QX4XKqSR10NKCL/njXx+i1rWKheNxz3QKRuTnQmOs1xoY4+Dfw6dw0Zw/9HKOkeGkpJFBIWHPhBlzyMuuiVS6DOqJofnpO4Gx60XyzTOyr0ncIZhY4XVZE+zOSJ6lUq7Ovi/GayhCGMqsg95SgDRuErAUGKcdo5K3wnRNfYWO6Nf0EHe68DIdcGJ9wGIYnU/aEc6ZUyQh4An3sUk9aw9dG8iaCGuw/l+oh5X8cOlZXQxjUlgm49jKmWeGK8SQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UyGdbvd5XN7XcjCzQ2srCi8QDDeO0xX4ZiQGX7jhEE0=;
 b=hq0cMgKupozCF2AhugeCmDQCllXf2ZX84StGeRQUma4bF+92yFH801OBZZVYAC4waJyxT2NttfcsoXh7YwAS30riKskD59ML68eyBeWnieQjddiQwAmt2ggdM6vx02yyZVZuTJiYkKDM4xcisAKQwfsjdcjJHBDFilPAPJOclYIT8HD5/gXBgdTZ9OEiRBiTMSr9tMIYEQGlJtkd5kmzgTY80ZF6QoH5iAfMhDWBQIoDptGX1hDjXppS0PoznPpHudYJ9GsmAUh0kY8I2+sdHbsiPk4hO+O16J85cbOJOUgRbZAKhj42cr5PJ48rf3BtHC/DMmZwZShzzjVZCdROug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UyGdbvd5XN7XcjCzQ2srCi8QDDeO0xX4ZiQGX7jhEE0=;
 b=XQHWHjHjmBJ5BzvMZ49rfuLhMm3kln1ToCcTUvXfLx9rRel4HZGFMC++7SVirumi5Uikj8uMhIInvU558vCDhSvUx6AiuMUCMjMeQqk6LbZxf39vYB67r5/9Z+j4kyPse74jcwPipRIBAmJnShOARoCwno8gIALILNoQ80NlSa8=
Date: Tue, 12 Apr 2022 12:05:39 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Paul
 Durrant" <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 6/8] IOMMU: log appropriate SBDF
Message-ID: <YlVO86RI3J9+qI+k@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <e8780667-2307-fa7f-0768-753a83e00082@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e8780667-2307-fa7f-0768-753a83e00082@suse.com>
X-ClientProxiedBy: LO4P123CA0512.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0ecc4c44-b241-4d2e-4e35-08da1c6c0207
X-MS-TrafficTypeDiagnostic: SN6PR03MB3536:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB3536B36FB9C672325E57AD7F8FED9@SN6PR03MB3536.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: IJghTE9FV6rIfJXHq6GO6Zvv0Cd+YFP9cazdr47xLfy+QG1AOopfwQRE16u3RM0mkM9W3OXP5L3R2ZA5FwgsODSC48LiRu+wVKOrTflHu8zuYs4kDLJPRo41wOoqXLTUjY0KTW7fvO0SEGjiHUgWhC1YsHAB4K57SSJQoOCSROZuAV9RNG2LaknupaxC/IBnpBXQnliiHCCGNJk7SdgrwFtVIGvPOLHuR7i7akYOOTg1lgGKKCRkRr/nulGDiSwAw6dVbB1avGvl9kCUiF0vqO0vHZEQYQ8gzOIZR6Q0xeSuXzSjndVvhWMFBgOXKEFiQlds/gR832Vf+UvZ4M/8e7RaMWjykJVJEeM9AlI0WRLtXi7vJ5vVr1w0XwyhUD5Hgaodh0vHSF59jTq3x4LgVxUJp4h8tBP3oORsqiiDpPRjB2G1wEcVSNPasNg4PQptkERKAV+FFNMJFIh6dl/07jIEyvS1PvaDhT74FN+OJo3yl2cm/r7bJzOLcaO2zr2r1d16E2d4GjMcCibt8cLLk3JA6vwcryDKPGqHPwanjHLgrJhYjXfneXaB5jYjv6Hr4/V8zANk+ow3RahoflZixvLWngx8NWfoxjCIlZxlQpYLn7WL1jjjuXNYJmn6ZpPw26q3UK4cU6+j/QqTlMdu5g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66556008)(66476007)(33716001)(66946007)(86362001)(8936002)(82960400001)(4326008)(8676002)(107886003)(508600001)(6486002)(5660300002)(2906002)(54906003)(85182001)(316002)(6916009)(6506007)(6512007)(38100700002)(6666004)(9686003)(26005)(186003)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bENNeEUyV0V0TFdtbWVsSngrb2FOd1pOVHZ2T1k1VFF5akpTVEgxZWZxRlBp?=
 =?utf-8?B?aXgxUlhCMlRhRStmSWlRb0V1ZU9tSktoWU1RdG1VY3IyVzZyZUwxcFpMWmZw?=
 =?utf-8?B?L0xZL3hIMVcvSHNpcHp2K2tmck5keG5vbjU2Z2hwQVF0dU9jT2puM1VRSGlt?=
 =?utf-8?B?VUltdkpReWQ2WmJkMHFXZWlzYWdSWE1uYkxoWjNoTW5jdm9zbkwvRW9UQTN6?=
 =?utf-8?B?WWFZeGlPVnJuTnhtSWVPbEpCSy9lOCt2R0VIQlhZYkJTMis0eTl1L1R1Z0hE?=
 =?utf-8?B?ekdaWEFkR2FCR3RsS0hXNiswNDhZM0pIN0pkbk10SElhK2dYTEJhek1WclVv?=
 =?utf-8?B?U2RGT2lxTnEzTXduZDRkTnY0bDg2KzY4M3N3MDBuNUpDOS9NUVZReXVMakI0?=
 =?utf-8?B?S09FbjVZYTJ2S2JBU1AvbmlMWkFlM3VENkZlUUQyS0ludmIrbFk3MjNMaTVy?=
 =?utf-8?B?SDl4anZOT1FCdVozOFZTL0NLVitOcU5QRUo2d3pJVUxRSnNuNUNFUWphUE5E?=
 =?utf-8?B?blBoc2RyT3ZyenlIUTUrTVhnbkU3R3VHVHFDODR2VWgzdDI0Z3N5TkFGYjNF?=
 =?utf-8?B?OGxZZlVJRGNsYzhybm4vOEo3OGZuN2sxT1ZVT0VTd24xcGUvZnhjMjl4SjY5?=
 =?utf-8?B?WkxWYjQ0dm50cFA4Vjk3cUlpQmhieVFUMkdNUHM5NjY5ZXBjMXd3Sk5hUEhO?=
 =?utf-8?B?eE5lTk9ITmdGWklKbHhaeWN1am04YUJNMVk1dFJGUjM1M3phcUN2OTFEUVBr?=
 =?utf-8?B?enI1Z0FsSTZHdS80eVY3R0dBZVNlQmFSbHBsc1NSUzVvQ1NGaGIveXBhTEh3?=
 =?utf-8?B?bmFwby9GVE0zbFlGRFFQdWtjbFpMZEJvbmtnVjFjTWE3cXpkbHc4djRXSTly?=
 =?utf-8?B?SzRxWC95WHkxVDhRNm5pQTlPbEFwNFpNRnRSbmdQTnFCRG03VDdQMHNsanp2?=
 =?utf-8?B?SXBESDBpSVhkRU8wT1k1SkttVGFkL0xZbTdZOHJUVFprMG00UVBqTnR5ZEx4?=
 =?utf-8?B?MjIvQzY1NXd5SVFXMTRyQ2xodHg0S1p3Mko5OEM3cHRlQmFtT3BzQnh1am1V?=
 =?utf-8?B?TUtZMkd5ekk4ZmxJTEhDdTByek1oR0sySE01d3FLV2RmNm5uZFZDMDM3VlBp?=
 =?utf-8?B?dlZKZ0JyRytCclRkbnduN0YrS2JKMTZDMTdCMDkzMUpnVXF5Nkt4cFV4UkJB?=
 =?utf-8?B?WmJYRmVPTHdLOVRvMzdGdGhES2hMRmxmQk54ZVZXa1RlSzN3clNsV0hqdTNH?=
 =?utf-8?B?ZGNlS3FaNExUQ3FpMVdVbFRteXJDWHRXbTVGdEpNd2RkR0dwb3YvQmV5Vi82?=
 =?utf-8?B?dVh1UEM0OFJyU2w3U0VFQU5aazExbStnR21NWEhmbTdUalJWWjFObUVjWEI3?=
 =?utf-8?B?SjYzNTFaVzlqUkZtMWNjT215NW5YOSt2aTUwaGxrWHZYNFpETkNOVHJFZ3NK?=
 =?utf-8?B?OUxyd3FzV1ZzSTlHbnBjcHMzMDhYWDlaWDNGNlZFM0t4d2J3VklBSU5IVnFs?=
 =?utf-8?B?UEUycWg0ZE5GWGFaeXhvT0tSdVRjRUd2UXlzSUlRVEszc1hHeTJKYXd5aWRZ?=
 =?utf-8?B?aDdpbFpWNXlFdHJFS00yTFoxVDVQK0JhM09sOTdDVFM2TmNmcDJ3RlVvS2FU?=
 =?utf-8?B?RnlWTmRsT2xQMkJBcHVMeGJFOUUyWmt2N01UM1NYNjgzOVZZWEZYUmdJUlNC?=
 =?utf-8?B?SS9wRXVQQ3hodHlnaDhtaFg1TGM3WmtnYlJzdTVZTG1Cd2FwYnNvSkNRcklp?=
 =?utf-8?B?Z0JQcnhOVkdUNjdRemV4Y0N5a2tWVzNScUxaUFJsMXhRbCtEYUJEeThmajFW?=
 =?utf-8?B?bm5IUzFDUGMwSUk4MlhnRitqcW9HS3NmZmdGSS9GWlcyUlVnOVROTm9sVDZq?=
 =?utf-8?B?cjJ6L1locUNCTzQ1VXZXaGViZ3dSTEljYTRBWTNtdThLdTlBQVhnM0tkYkov?=
 =?utf-8?B?Y3A4VWE5RUVMMU5HeUF1RVVXcnhkQSs1V3FYdjFMdlQyTi9OcUFFNkRsTk9M?=
 =?utf-8?B?VVY4dWFKWVhLdDdmckJuOEtROTEwWFFlZ0hQcXkvYW5VMzNmeWRhVWE1VXVJ?=
 =?utf-8?B?OXZ5OURGTi9lcHdSY0hteWNqNjZpWTE4QmoyenpMRDlNVlV5TlMycUU4N1g5?=
 =?utf-8?B?YmZjU3N6cWcwWXlzd2MzQXdSNlVxWnV3MEVaVFpJdE00cDlWdmRRNEdBaFJJ?=
 =?utf-8?B?MkpCaElxS1ZjaTdSMUZLQ2x1SWFIMFBFRXc4d1BvaVdmS3hIdmZHZmJsNGlE?=
 =?utf-8?B?REo3V1U3RkZGYjJPeE1ZT0ZPUnFTNk1ETGt1VFVmbFZ6ZmFMdDdBc3pUQ2lO?=
 =?utf-8?B?ODFtM1VIQXBBUkpCUWczUUNlaE01VnRnRDdIRSt4NUFtZFlFS1VMRmNnSzN6?=
 =?utf-8?Q?YyLhYqiDUTRMnY70=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ecc4c44-b241-4d2e-4e35-08da1c6c0207
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:05:44.4469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dqo4Ge2q985Js+Xjk2olx94DUeaqKBMALn5YaJjIo620SHayg4JYC+SirFMJoSEv6Ayadk79vAo9pVE/UlZNrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3536
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:38:28AM +0200, Jan Beulich wrote:
> To handle phantom devices, several functions are passed separate "devfn"
> arguments besides a PCI device. In such cases we want to log the phantom
> device's coordinates instead of the main one's. (Note that not all of
> the instances being changed are fallout from the referenced commit.)
> 
> Fixes: 1ee1441835f4 ("print: introduce a format specifier for pci_sbdf_t")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I'm unsure it matters much to have the logs from failures to find an
IOMMU using pdev->sbdf or devfn, as the parent device should have been
added before attempting to add any phantom functions, and hence would
have already failed to find an IOMMU.

> 
> --- a/xen/drivers/passthrough/amd/iommu_cmd.c
> +++ b/xen/drivers/passthrough/amd/iommu_cmd.c
> @@ -291,7 +291,8 @@ void amd_iommu_flush_iotlb(u8 devfn, con
>  
>      if ( !iommu )
>      {
> -        AMD_IOMMU_WARN("can't find IOMMU for %pp\n", &pdev->sbdf);
> +        AMD_IOMMU_WARN("can't find IOMMU for %pp\n",
> +                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn));

Hm, the call to find_iommu_for_device() is explicitly using
pdev->devfn, so while the iommu of the phantom function is tied to
it's parent, it's unclear to me that logging the SBDF of the phantom
function will make this clearer for a user reading the logs.

>          return;
>      }
>  
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -461,7 +461,7 @@ static int cf_check reassign_device(
>      if ( !iommu )
>      {
>          AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be assigned to %pd\n",
> -                       &pdev->sbdf, target);
> +                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn), target);

IIRC we would first reassign the parent, and then the phantom
functions, so we would always hit this error first with devfn ==
pdev->sbdf.bdf.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:08:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:08:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303577.517913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDRG-0000DW-QO; Tue, 12 Apr 2022 10:07:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303577.517913; Tue, 12 Apr 2022 10:07:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDRG-0000DP-NR; Tue, 12 Apr 2022 10:07:58 +0000
Received: by outflank-mailman (input) for mailman id 303577;
 Tue, 12 Apr 2022 10:07:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neDRF-0000DF-5p
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:07:57 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b627086-ba48-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 12:07:55 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b627086-ba48-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649758075;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=kbu6kM8SIKbLzGynWPAbXCPVFWBLIQ9H+zKtmhQC/FE=;
  b=E1Jv502MUV8CnXzQs23spNT/A8BEoyEJ3P91Dux+4cAOwpIRtL5x5Out
   cVNWA1IYrACGeRN7yF2qbZXKJZKak4t9YChuWy6ClAheVAxCBtn2nYiXK
   b/pOw8jaX26J2jk5BnwMbH1ck4okF32OUEuYxkDuDFOHg3v1RD2f/43Ke
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68658941
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:J5AHxqDikxVpMBVW/7/jw5YqxClBgxIJ4kV8jS/XYbTApDohgWBSx
 moeXmHUbPbZYTHyLY90aYq2pB5UuJOBm9EyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jg2NYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgul
 v5qjdu8RD4JGbLupstBCRheVC9haPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGjGlt1pESRJ4yY
 eJERxhifhfsUSZGN1QtNs4uod23vUbWJmgwRFW9+vNsvjm7IBZK+KbqNN3Za9mbX/Jfl0yTp
 n/F12nhCxRcP9uaoRKe6W6ljOLLmSL9WaoRGae++/osh0ecrkQMDDUGWF39puO24ma0VshDM
 UUS9mwrpLIr6U2wZtDnWluzp3vslhwBX9tdFcUq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/H7qZw3pgLCSJBkCqHdpt74BzD2h
 SyLpS4WhrMPgMpN3KK+lW0rmBr1+MKPFFRsoFyKACT1tWuVebJJeaT3t3P81bFMIb+5aUajg
 ldYwcmYq+4RWMTleDO2fM0BG7Sg5vCgOTLagEJyE5RJywlB60JPbqgLvmggeR4B3tIsPGawP
 RSN4V85CIp7ZiPCUENhX26m5y3GJ4DEHM+taP3bZ8EmjnNZJF7ep3EGiaJ9MgnQfKkQfUMXZ
 M/znSWEVy9y5UFbINyeHbl1PVgDnH1W+I8rbcqnpylLKJLHDJJvdZ8LMUGVcscy576erQPe/
 r53bpXWmkoHAb2uO3SNrOb/yGzmy1BhWvgaTOQNKIa+zvdOQjl9W5c9P5t8E2Cao0ilvriRp
 SzsMqOp4FH+mWfGOW23hoNLM9vSsWJEhStjZ0QEZA/ws1B6ONrHxPpPJvMfIOh8nMQ+nKEcc
 hXwU5jZahi5Ym+coGp1gFiUhNEKSSlHcirSZ3H1P2VlJ8cIqs6g0oaMQzYDPRImV0KfncA/v
 6ehxkXcR58CTB5lF8HYdLSkyFbZgJTXsLgas5fgSjWLRHjRzQ==
IronPort-HdrOrdr: A9a23:qSTfn6nJAPm9e6MIY6ByE2w6cVbpDfO3imdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftW7dyReVxeBZnPHfKljbehEWmdQtsJ
 uIH5IObOEYSGIK8voSgzPIY+rIouP3iJxA7N22pxwGIHAIGsNdBkVCe32m+yVNNXh77PECZe
 OhD6R81l2dkSN9VLXEOpBJZZmImzWN/6iWFSIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X
 LemwL0y62/u7XjoyWsm1P73tBzop/M29FDDMuDhow8LSjtsB+hYMBEV6eZtD44jemz4BIBkc
 XKoT0nI8NvgkmhM12dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYAB89IletiA1LkwntlmOs5/L
 NA3mqfuZYSJwjHhj7B69/BUAwvvlaooFI5+NRjzkB3YM87Uvt8vIYf9ERaHNMrByTh8r0qF+
 FoEYX1+OtWS1WHdHrU11MfjuBEZk5DXStuf3Jy+PB8i1Nt7TVEJgojtYMid047hdIAo8Iu3Z
 WBDkxq/Is+OPP+I5gNQ9vpevHHeFAlcSi8Q156Hm6XYZ3vG0i946Ifs49Fr91DRvQzvewPcd
 L6IRVliVI=
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68658941"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ko98hMhPUVaXXfp49u63VnWfv5C5+GT2ro6jiREQ9muubSZlRjbF8LBr0sYPKQouZAEf0qYqy1gZ7DBWvxi3B2DyTYc+/H5RP7S38EKpaAm+KVqrToOZxkSuIvcGmYzJodx9mMJ/LiL6NxAMhcOi5v+EyKwQymm9CBEIk3g5nadleckeV2TSyRYUkl2cUbLlW1f9j9c6vqLouxAYTdUM1BFpGgh0lbJXmKUF5vwBtIqFbjHAWgWs+Rgxrc36a6cG4/mTNcydjHPM5Oa2db8BxOVkcSxLBi29tQ2/gqyfEeS99Op9SAPN9+irUnXzdiR9S1t+s5fBYoAN0GqbFVomeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cRRVvVk2095zWUu31BvnUuwIFmTFrkNfsk8pcpax5rE=;
 b=AxXXgEKDsVpoioqTdPJSMV3hiA2Zq5NFTJM4XBrIVP+qnR6f/Fn7+veeU2PlwKzdhmj9/VMRCrVqAzsnlAp4B9vo5p4Bs0fHfN9osKnt+ohRidn0SGX3XsWKwDKbK26Tp4ah4LDM3Tl6eBvdVmVQNhnnDq9EW0zoEXVqEWlqjQpLIAdWi6GpAJ984HDsgNLy36Ck07S13/JXWOMYwYq3L6wtL04ylhSyg5/dI8qgi9El6MR+qPhO0QzYg0wr1899WgPrkWilCc9gJ623iYG8YUoKGvMo9Ly/8f4rXSJHPFvCYIS2pz2tAXvkaP+Ag4aa8fPISq5R/HGiXuZ054Cy+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cRRVvVk2095zWUu31BvnUuwIFmTFrkNfsk8pcpax5rE=;
 b=U+Mm+xDrpd8zM3KGgsC7zyhLUIkbhSBL9JxR7O9r6Qd4HdnmDd2hvHHMniq9WPOApkiuNrrTKm8MlHeFtpEl2/m1GH73r/+64VWduNO/QLp4VJCbNoOPXJGC14ttRl0W9vFO7RzbI8xQZDjT9pkhaWpV+ljJp4rOhhzD7f0dhTc=
Date: Tue, 12 Apr 2022 12:07:45 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Kevin
 Tian" <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <volodymyr_babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "Wei
 Liu" <wl@xen.org>
Subject: Re: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Message-ID: <YlVPcb036UtuJ9TI@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
X-ClientProxiedBy: LO4P123CA0104.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:191::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 13d82cc4-197e-45b2-f4b3-08da1c6c4d5f
X-MS-TrafficTypeDiagnostic: PH0PR03MB6872:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <PH0PR03MB687208EE0F7C95C02A241DBF8FED9@PH0PR03MB6872.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ru2SR9p9pfQQv0h1Dus2R72GWDIpjLZ3zxIT/qctOYnVJtVv2z7YVts+Ld7RlWpZlqcg9LMXrq91XSRJ0Ar+4fhqUaKUgP0WfGXZ0bX1E9YhDiGI3ildtjlWbx64B5W92Nr+ZpFBoCkpznkKR5mzeNR3SBX6Z9Mb0v/PJqqq6Dp0brQ2Ims6/5Bz21mWWIQGLA8YTp+R+xCDzMHBCQfZMp9/1EQQkBGDO1Ge2/xhikPX5pQRGPqfh7cFDnqz5lt29vu9OXoq2xQ44RqgpRN2daFWnCWBjal6Otyko9rzO2knW80jisDQC5DQlnuRLgLO7etdg7bDzDIAssie6DMrUC4B9IEpalUHW4AJqU7jGTSF95eCYz4ufKJsbEhizsdw83LsavIPatCb1h1WbZMXG2IuW1fLH5ZFi0NyOR6fVRsdow33iQXKWd1ihu1PmDphJ1JYsDNy2mu8JUEWtvyptpErnkGs/lDeY8kr7zV7l2hFEZEVB4GMCkPYQeoJZ+r7FXrnWKnhTKVzP3fIB5tSCMoANJX9M/sCUcRCIEjmVhnejgNiyfgbb8KO16ZoRg0N0FB2JW7KowooaNtYBNvZy2yHfZSoGLgqQ1XYH10L745tgO84JWEhTIqig7tsXmE3B1nSCvfBd46q3ei/7gY/QQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6512007)(186003)(6916009)(54906003)(26005)(9686003)(6506007)(82960400001)(508600001)(6486002)(4326008)(5660300002)(4744005)(2906002)(85182001)(33716001)(66946007)(66556008)(66476007)(8676002)(86362001)(316002)(38100700002)(8936002)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tm1KNjViRXR4aVZyVVdJNWdJWEV5SWpOcHVYdXh3QVZWT3BxYUM4K3cwVU5h?=
 =?utf-8?B?cDBsSGlLb1JXdFB0TWJxdjBvWjNkTmk4T2djamZYUnNDOXNKSzk0bnpGNkFx?=
 =?utf-8?B?QXpUeTU1Zy9nTERtZTZNakQ3S2lXb0VMRGI3VzlEbzlqaGY1WVdVVkdRS25a?=
 =?utf-8?B?MTA0enUyZGdha0JkTk43TjFiKzFweFRNYVV4OUp3aDd2b1RLdTJVd3NabjdF?=
 =?utf-8?B?VmFaSStqZ0tjd0d3K1FORnByTlNtRS9OeUNSM1NLY2Y4dEtZV0RHcU81RmR3?=
 =?utf-8?B?YlY5eVdUWjFzT2xLSS9IUVgrUXNSdDZLNVluMXhjMm03ZEtoWmxWcWJDNjh5?=
 =?utf-8?B?czVDWlNSWkNxZVliUWlybXpyV0xPY3JTWGtsdmpaaC9GYXF3eTVBR2t5QUs4?=
 =?utf-8?B?MjJ3UU5ZZmFVbUhIbmlxTlBZV25Tcmx2WlhuSjVnRTNHNkpBRFNxajdDdlo3?=
 =?utf-8?B?dlY0c3VncFV3dmpmQ29ReWNlVCtuQ2tUcWQ0VnhjMTduRlRQQXNpay9oTHps?=
 =?utf-8?B?REt2YmtXbGoybWtuVGdpMWlXd2Z1Y1o2T2tiVXdvTnd6WFkzRFZJekwvWVZQ?=
 =?utf-8?B?Z3hSTWxPWkFEUG4vSGQxVHhVd2xKZkwzOGUvRGFvd2tCQ1lLK3FIdGR3TGR3?=
 =?utf-8?B?ekpTWVAxR3Q1SkVaaDlrRGs5WmlTZTF4YXpmTUFVVndJTGtpbXRiV3F4SW1v?=
 =?utf-8?B?U241dm16TGpWM3NOamZpTG8yWDluaEprOW8wSVVSRE1JWU13T0VHUzBKMEZU?=
 =?utf-8?B?bmZYditXQW5YOENCenVRTEtlNDRHRnhCbDhKQmZ3bmVZUis0dXEzSE1EeEg2?=
 =?utf-8?B?T1MxRmFHaW9peGo0UDFBNm9FMlNENkZOWkFGT0R0Q3RDKzg0Z3hmekJvTmZu?=
 =?utf-8?B?cVBIbXkwSVVjTithSnpBbExHNEpac25jUmE1bk1kbm1UZW12UG44eWUyWmVL?=
 =?utf-8?B?SUhDSUlZaWtpUXpITGdodUdkNmpSLzI3a3ZKaGlIb0FGMStrWFFMZlZ2TFpR?=
 =?utf-8?B?cUxvaXhYTWh6dzNkd0h2YUJhS0VScXNGTi9ZbVpVd1VqMVdGbXdTY2dSTFN2?=
 =?utf-8?B?Wk9IdjVCWWhpcndMem5jZGY0cnYwOFNnRnE1WEVqTGhBN2g0T1gzRFo4K0JK?=
 =?utf-8?B?ZE9TWDRQY3QrWE8raXN2UjNSVmZNVzJhRnlXd3QrTE56aC9WNERxM0RXWmVm?=
 =?utf-8?B?SWE0WmlZWVJxS3B3VGtJRkhpY0xLU2VaZ2QzYTRCb1BpTEJVdHFoS0EzT1JI?=
 =?utf-8?B?azNGaWFOQzZGb3FIelNCZG9FL05XNVdISzliVW1CMjVWZmdXU2VDbHdOV3Zo?=
 =?utf-8?B?bXg5SzV0TTNscTJvaTVUTG5lWUgydzVMTi96SnoyL0NUMHh1U293VzBWOVFW?=
 =?utf-8?B?T3gyZU5ZNjRXK2ZtMmdFa2k5RS9CMnVoT3lON3JTczlvQzlaK2ZZR2JjTmlz?=
 =?utf-8?B?M0JmS08xVEt5UnMvS1pyS3plU2RFdXR1Q1ovbUEzT1BEZlFvZHJTRGZ6TThz?=
 =?utf-8?B?aDZqdkQxckZ1WEZJMHliVlBCMWZNNU1IWTFUTEtVbnFMVzhNczZCLytveWhJ?=
 =?utf-8?B?dEVORUNGZ2lhRittcnl2TGRHQ09iVnl0L0c3TzNjUEwyWTNLWmVpdi9MZVNU?=
 =?utf-8?B?QllpekVCSmx2RzJIT1BoOFAvUGN4S3RmWmE0T05qZk9MdEkzcTdCRzJlbUVU?=
 =?utf-8?B?SGxIYm9HMWcvemQrTjlYS1V2ZGMvanJSOFcwZTlqMy9OOHBjSUsrM0JGM0J2?=
 =?utf-8?B?Sy9yRU0wZlN4SGsxbW9xVmI5c3gybElBY1pnQ1p0Q1h5ck1OY05pVkZGdG05?=
 =?utf-8?B?dG5hTlhzZ3laUU8xVXdwaW1SaDhEVG4vcUhzMEFlVnQ0cEJXWUowN3pPVGhF?=
 =?utf-8?B?bDhySWJSd2Iya3dWVUw0ZFVVTFV2T05acm04ZzltUzZaOVhEQzJ0TW0vMVN0?=
 =?utf-8?B?SFppNHpTcWZsYVlqaTJ4N1hiMVlnQXJ6aVlrVmRHQWtzd1dCa0FsR2YzRFBC?=
 =?utf-8?B?U0RiSUtqMEZvRVR4cFhkU2JyaTZlWU83bFJFUlhEZEFMOHd6OW5wOTEzcENQ?=
 =?utf-8?B?cUJwb3JyeFhGNHpSL2FsOVRsemd6OHFrdnFtbWllOGhadnU0T3k1ejZTcTVB?=
 =?utf-8?B?NWNmUmszdTdhbkRrd0VMMXJCL25xaXhnSXRjQUYxRmRvNzlHSDkvN3pYK0NO?=
 =?utf-8?B?M0UvRS9HbWVjeHUyOHFUaktGU1kxRGpDcWFTK1ozQzVUdDZBUWJTb1FJbXNG?=
 =?utf-8?B?NUh4OXNWMGRxaVQrU3JDMVBRWTFCWWtTSWg5blRmN3pqeTI3M08yVDQvdnk5?=
 =?utf-8?B?M3poSllNNVNQVDRQdmpST0VWUjJudlBVajlDMFhLL2FFdFpGREdzQ05iL21U?=
 =?utf-8?Q?x+pxrtUP0+qTegBo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13d82cc4-197e-45b2-f4b3-08da1c6c4d5f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:07:50.7789
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dqWxsJxrCJeqB/2tW+rK+nbdk/5gEYBvlAPRa+I6b2A27btAgKYmHGSfVUbhd0tDV3IcShsmFJVspa20+ZDdmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6872
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:40:24AM +0200, Jan Beulich wrote:
> There's no good reason to use these when we already have a pci_sbdf_t
> type object available. This extends to the use of PCI_BUS() in
> pci_ecam_map_bus() as well.
> 
> No change to generated code (with gcc11 at least, and I have to admit
> that I didn't expect compilers to necessarily be able to spot the
> optimization potential on the original code).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:21:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:21:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303584.517923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDeR-0002X7-22; Tue, 12 Apr 2022 10:21:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303584.517923; Tue, 12 Apr 2022 10:21:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDeQ-0002X0-Um; Tue, 12 Apr 2022 10:21:34 +0000
Received: by outflank-mailman (input) for mailman id 303584;
 Tue, 12 Apr 2022 10:21:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neDeP-0002Wu-Pk
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:21:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 530fca5b-ba4a-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 12:21:32 +0200 (CEST)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-qQ3JCvmnN5eakqTWB1hMnw-1; Tue, 12 Apr 2022 12:21:28 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB7522.eurprd04.prod.outlook.com (2603:10a6:20b:282::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Tue, 12 Apr
 2022 10:21:26 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 10:21:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 530fca5b-ba4a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649758892;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=AKLiZbDifpDyhlrfPH2x1M3O4noG8w8xleOqT2J5miM=;
	b=cGr90iLV3ZwSwXbvf0JUlGLQl9iHN/XPLLMXmqSsJ9hCuJyT43H8lNUR0MIMM740uZc7OL
	iX/PGtlq425SSmrhfvS4pOOPRAi/kWl2XN5kZn+DjDPiYm88ZSUoikxz2gSaoRMB7umxte
	04BdvmvEx1OpZEPtROc8HXq66pEs/sg=
X-MC-Unique: qQ3JCvmnN5eakqTWB1hMnw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q0ZFvFs+3bN6FWa3iPen9A9uW+f2ro3S/srAbW6/ovvqxQYld21EbLpqC8dLvx1GU884dUr6guJT/ef3GR5SllKCCNc91SChD2HxiuQSDVu7PFS2P44X9D2a3yfTidiF82fOoOM1Cz9UX+vlnD+vzv4Ajg7XQKjNcgoQVdqd6b8fvcko/teoN0/ymlSBhtTlN3WvOlP7mp3o9NkEsIfhLLO6acF//uV9Un1/FAWY8kjtevba0VSsM1sOYZE895mXnEb/Y6pHKoSX11Dvo+NFzYYAnFTPEJ6WAfMAUQtq9Ek3ONbaZWe4f5B0BNAH89LmNLXkSy8Ljb2ig2IrWAy+3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PGy37weZUhBtgIr26CxolnrLWmEJ12AYaVwAdKGp6Fo=;
 b=ZDvk03R0B+ZlUfpfoVB57oJ3sUCyxMf9tpx3VqmVZ+slbAEqaNx/BUyQFrv4dTi+4ul48WZ4TimJS8NcJhfG1mkahcpP6PEtnbPOJlbfGnO0QfeASDuhaa0k8vIFGKkuA53JTe0PqJ8dIbxGUZjeoDuXheQJLZE1pZljoHrubo2YstEooKOYyMFeInXXFcsQ0UAV/FR6xsgh38vZUYh7sclfxeWUX8w3AXua+ele9hJOtO1/HLthmYECOtzLykmEG6hD6g791OfZbEjvDcqsBjCZvvLbSqjEcmj6pFfTkpMNQKX1kd4L9M8jcDslD82tif1RA4mo1xXgKS0jhSgagw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <50dc64e6-1a89-59aa-e087-d80aad1c653d@suse.com>
Date: Tue, 12 Apr 2022 12:21:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Dario Faggioli <dfaggioli@suse.com>, Juergen Gross <jgross@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-5-luca.fancellu@arm.com>
 <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
 <86F93995-5CFD-4A43-A928-E9053B027722@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <86F93995-5CFD-4A43-A928-E9053B027722@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0008.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::14) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 484c2e46-e730-439f-7658-08da1c6e32e6
X-MS-TrafficTypeDiagnostic: AM9PR04MB7522:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB752248912E47CB3450553EC5B3ED9@AM9PR04MB7522.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aZkvmWcTXLnNs1gb8qS6pCZ1wxgAvLIhACrslhWebthMGIUlzzTYCECe49Ttpuvh3JGaymwWbmaoIqrVfTttP6BvTQEMvM+upaphGDhQrqP/zTlBHGwBdTM2QFm9pX6fNYhdr0JUdEGu629ZI2D2MG7t63vxTVo/++1AwRZQ992MF319r/gUpcmCmnI2kkzXa4J99tdH8xevj5CDHW3FwrysgPE67h12RIUWVwggBpX3w9s7avI84ovG/1xY/noeZXXZz50yhjjtcEWQvAX8lSfetPjBmj6h4iUmOBpnXgWmc+hOJJLmcKzDLHKlLrVRafNFjFw4g3PsZ/jE3QYmVJLo2hZFtBQYn8RtwYrMhDmP3FlDZ7fuhxWW2sje5Rzf+nH/EbAowwxBY0yKK/u6mtBpK3OVTHOxn3O2Uu5HClSrJFieAaGQWN3GuQmxaZl3lC9XvjPqMXgECJOZjnyTxmNochrHbmmBb9NzH4RHMlDuXf+4Y9YSNx8MP4GoVPTkMl67Yag/QvrYgmnPE8I6641idwdNh5bVEGSRQ4Hze4brFqh6+/eytdSqExGyxzmePy3TUfXFfmOJaWQ0jpMfnm8O9OW+5SL7yhyk1pLNwxrojNiHccSppzk+bPEhw9EYJshrhpIhc/ykIaRuyCFmMQNLWPHRKOAiVocHuF0y/uxHrRvqnB6lmxfUbQDMHYw49P3kdJzrTFXb9GHe6Jd8SSRkwUo24wan5DZNnjAmP1M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(186003)(26005)(31686004)(2616005)(36756003)(7416002)(316002)(6512007)(2906002)(6666004)(6506007)(53546011)(6916009)(38100700002)(54906003)(8936002)(66946007)(31696002)(86362001)(6486002)(66556008)(66476007)(508600001)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?dqknk49MZMBiUUHai+VaHNsVsuopiXdHRBlLfHsWwrzq3JZhUfm3P8X7JvtH?=
 =?us-ascii?Q?juAVPIBjLo4QZtZw9F8EKOxXC/ER+EYL8KMpwpT9vcjgns6bZuaPmdjg85LM?=
 =?us-ascii?Q?SzGXgGJyUdo9cFf6/eLXV2ITBo3QIyaZhmgXKgvLMlmIAHLi8VxTlcGHGW85?=
 =?us-ascii?Q?GGXvrNL5LhY+gJZURXDbt30LZVyo0XMpyyUikSREn1D+2rFkOX2U1ypuDNn0?=
 =?us-ascii?Q?Krw9lxKHkWZeKCVWvocLGcUA2iOl2CTYWtwwxdNmfREGcMCZHket75d6aZre?=
 =?us-ascii?Q?8H2n3UGK2eb5jBseERLpssBPRqmYOGZoOBjBpnq+mqnUkDoRIsrTkTAoL5bH?=
 =?us-ascii?Q?5U0ddtqSBEaCODBs/G7heMI9dTpqQWZ2V7lv/xSeogUIrK4BiQnjeeOa194m?=
 =?us-ascii?Q?l7uhnYElNasnbO4eW5OJtPpJiVly025rtNqU8su/3mSnFO1JI9GGtFgWF85c?=
 =?us-ascii?Q?Yr4S3E0hFlUQiKeopi75F5YCDt7sv5R4FwV6+14YuloeikOYi2RJZL607KSZ?=
 =?us-ascii?Q?UvNT9KsoQdvZfw4iWg2wI71PbHvYPS4WIAs0eJVgTrW1YloY5UWk7Gs5XJ0r?=
 =?us-ascii?Q?NReneCbjSwpvOFtAXpuTEcNrwYX1tRfe9/m+weGEKCOCroeU/DFFY0kVYPS2?=
 =?us-ascii?Q?ziO8uJIOTpfSKZcfLEb0oZQnX+L6iVADGSbTmNf7RrUw6b+CSnn4D1Ug1dyy?=
 =?us-ascii?Q?5xBGCi1FaN8AOiheTpVp5ZiP0F241/SvCqojQHO2pZ1r3mDNC+EJz7vREN5l?=
 =?us-ascii?Q?HOOF8hwKcuZN3RhHb6aWKb7OckLV3VLB2Lgla/KQ0SJTg0pUZFkr51thC1h8?=
 =?us-ascii?Q?lxvYo0irIj77rYBvBcKqTOJdPlRGNBQVssYu8Hc1SLuYM2twv5EfR/6k9Y0t?=
 =?us-ascii?Q?Z+AboH6/CbW3wRQNJRwtsr6cAek0S20vctwV3v5iQFxhVAZEY6ojdXNvO2s+?=
 =?us-ascii?Q?0Ne+lgn6Bo8kzIVExUNhZOQBpTkl8ODSlS7X6sn/FaE7CsoFwHCEpU6PMd4c?=
 =?us-ascii?Q?5WNGjNmYY2u4ccAucYrMUmrjBIOP5pv7rXX++fBfpMrGe1Owd0M7eVUdJ8U3?=
 =?us-ascii?Q?3gJODse+Aa/b8pRrUNuIICAOo8RF7c9v8O0gW70gmeIwzV7B/W8ei8+uUeac?=
 =?us-ascii?Q?tVzKe0eZbBSLgD7DtaxpVW1srJdZhA09Ad7z1A8JAsKh4h/UqZb5xOdJeWRU?=
 =?us-ascii?Q?hD93/YvYXP83LArEL4fYY/OMhdNSBfJyybTQHKf82IjU25iJzlHPr74OaqyR?=
 =?us-ascii?Q?RWXaRxVEdNmGHBvH1ierht/1unXCGY2VQfKLQiSaU499gav1aN+TwLWWEKEG?=
 =?us-ascii?Q?UToLoqq2tlRYzRhIG4CBajZIKqk5bipaKGjyC5d4F4N/eGVh+1rHXtxTIsbO?=
 =?us-ascii?Q?rti5dBBoAusg1GBnDQJsalZ1Z21lgP2K7k/vYbzTtUnx7LcmJCTwhThvFnmg?=
 =?us-ascii?Q?XNkdGMDgb1vGrZXaX+8QDuHJApL5g3IT63/bN3K8dD27qtmUADO7y9AV/+YX?=
 =?us-ascii?Q?AfyJ5iv0puFIvZlizswuOq6MHO57CzOuCAMvcXdeVgr5v46lTSiyNg0mr2ql?=
 =?us-ascii?Q?JPlKNSFbzj5AZOEw7zTj3bUT965XcMmhUa8osyTSMiNxt//gid7v6cFIwcrq?=
 =?us-ascii?Q?Q4Ut0EyeY6SM3IyRtrVtiIUs51ZdqbpZrlr0RZGE/lNZT/uMRRbkcKAEBJOq?=
 =?us-ascii?Q?+fZaBkBuR3vFYD6SAmwqRzqNgEsNQFOLe2C+KAxlzBrDlWRTRAgZjGw0RjRR?=
 =?us-ascii?Q?akbx/mS3gA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 484c2e46-e730-439f-7658-08da1c6e32e6
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:21:26.2002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lq8Vowitq0i2U9CIisymb/lJAEA4cf1BJJ1gTMJ8YR1K1iuX2BjgX98Enf/pzh/tNgc6llewytgf+P92pUezvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7522

On 12.04.2022 11:50, Luca Fancellu wrote:
>=20
>>> ---
>>> MAINTAINERS | 2 +-
>>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>>> xen/arch/arm/domain_build.c | 5 +-
>>> xen/arch/arm/include/asm/smp.h | 3 +
>>> xen/common/Kconfig | 7 +
>>
>> For consistency, should the addition here - with ...
>>
>>> xen/common/sched/Makefile | 1 +
>>> xen/common/sched/boot-cpupool.c | 207 +++++++++++++++++++++++++
>>> xen/common/sched/cpupool.c | 12 +-
>>
>> ... the new file now under sched/, also be put in sched/Kconfig?
>=20
> Hi Jan,
>=20
> I was looking for this change, I see xen/common/Kconfig offers the menu =
=E2=80=9CCommon Features=E2=80=9D
> and the xen/common/sched/Kconfig offers the =E2=80=9CScheduler=E2=80=9D m=
enu (visible with EXPERT), so
> I thought it was better to leave it in =E2=80=9CCommon Features=E2=80=9D.
>=20
> Are you suggesting another menu under =E2=80=9CCommon Features=E2=80=9D?=
=20

No, I'm not suggesting a new menu. I was merely wondering whether the
Kconfig contents wouldn't location-wise better match where the
respective source file lives.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:25:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:25:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303589.517935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDiX-0003Eo-Ns; Tue, 12 Apr 2022 10:25:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303589.517935; Tue, 12 Apr 2022 10:25:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDiX-0003Eh-Kh; Tue, 12 Apr 2022 10:25:49 +0000
Received: by outflank-mailman (input) for mailman id 303589;
 Tue, 12 Apr 2022 10:25:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neDiW-0003Eb-SE
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:25:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb2aedbd-ba4a-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 12:25:47 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-w3_gBEIGMmaEkfjQcpXgCA-1; Tue, 12 Apr 2022 12:25:46 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB8688.eurprd04.prod.outlook.com (2603:10a6:102:21f::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr
 2022 10:25:45 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 10:25:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb2aedbd-ba4a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649759147;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=PtBvzg8Hif6iiUuiNnK/wboRD62zX+WXGhgns3pTYTQ=;
	b=GC/HY3RUBwhUvgUqjFwDSeCTNz0eK2Pd8iO07oIFOhAP0D9+12jqMds86IH4MRlBRvfZMP
	e73/pgRiDZWaa28UZsTctoJOXPEeSQUjio8Cy7Gsh2g0iiVNtYbr6LpyNKhlxsZslqDTu8
	D6eOhCRn+VbG6KBEcg7psFE9jRCFpFM=
X-MC-Unique: w3_gBEIGMmaEkfjQcpXgCA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yy0NYUXkhbuHvZsyW6CF1IN5jeyX/cTXOlK1jQLC/CAaEWmxiTf9aYnyz6mD6OMG9HuY3qC5LYQMfFMFrkDKMRxxpTWjWxSiuYR6BnA4MWtn0uqzD1ZnJj0uSiYAmjd6rC+XlFsBAvsvRp15HASR8REPtHnhDHd3yKQZXCDT1M2VgUaYYeD60XyV4c95aXkJyrU3taS5suIUUUo6FRFi07vRPYOA/HGR29VSpVlTZ5srMeq9PSyKaIumEYz5640ZMb5n6oXblPinMfGF1PBvIsWdUsxYm6kYhAqLTLGvKLmeBTFrmlvuGQNMArQBVoXhV83u/KKx8Hf/8OyOAFCXEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PtBvzg8Hif6iiUuiNnK/wboRD62zX+WXGhgns3pTYTQ=;
 b=SoG9L731X6PmSnO2BxgRoUgzMODFcSfo235W+9KanF9MDFEoHTxvMWA5bZ98TMT1wioSUna9CjqmOn2YPdIv9seTdH8KX99MkKEtv9BHrB3oAgmYWGl7i/izEZeCr5Z3UXVc9F34DpzebbwpFsysR8xMeZufWvc8mJ81spkr5caLWYNzGDonerjn32rLOVprJTX0M00Vd49aTyGuzMFve92kJ4OxImvB26EZznFCK4dZLU5SlJjv0uqFz0LZCvMj69nxnKmAHkJwB+hW4Rw98kdRDCaL+zYR5jkttxddKFmhVUkKsLk1ZZy6Ndi63dRMO7W1xhz0r6aldO+B69P9hA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
Date: Tue, 12 Apr 2022 12:25:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] x86: aid debug info generation in assembly files
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::12)
 To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 25e2032d-4ac8-4781-28d3-08da1c6ece10
X-MS-TrafficTypeDiagnostic: PAXPR04MB8688:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB8688E404FB06D73CB198FC8DB3ED9@PAXPR04MB8688.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1N+mw4AuwLYk3V9n7wCSemRx0tEDrZE10Ll4eNdc5fZa3mKu1N1/GzCl/o1tfjYEbAft9IMX+/LOzdiRZ1N4w2NLgBHHTYdgyq1CmbBMVnlV0odVlH8g8n8sbtjznwrBzA/2hvYx3KFdq00ttW+RV6QdkW8fXv5wkIj/Wb5UOlAUtzWf+7gcFYFJV20eXIH2QTrxTdAJ9ILzudWu9yonCUoAKbV7emzGYRAscFNDv++rK9kgJtpkZJhd9AC0GxXPzpXpMevbdTX0fJDllFCw8rB1mjI1Ru49SrRkUWq6r2geTRObjoLs4/adRzcWyRVmnbD9vH7pLw2JIuPaRb7vGnFRbHUA8iQvT5jdTYQwFsJyvwdKEooZuSI4mLdFSb5sEaAEJOmJQB07JC94HlL26E4eR+DgVERwNaQlVcMhkgDhCeS1VrzMupr0Q4U7D2l8AfK9pURdN2dZEjN4Zxnfp2ZzyW380o6lXN0TzilMGxokBZ4NfWTzFIbsOWtYT9xevcg4V9tjAcOL5YPYUlOZ66nMwwekcGXVTGjWZDNIO/t0dcZ8GfbD4soXQ77k4Sl8BUXaT4WN2Qoin0uL3SkRTrwI5f2noKGoB5mV729wws01bFtBHJfBsGBCv2ZQwQd2MrCHA+Hk3Rh9ZNWagnFP/lolH28FPvxcq+0M0t8Cy17Gp0LXlpgdHuW2jty75OcEAjhCST2ZeWA19A4ru7JQ0KqxaYTHK9R+IWA0pgIFpwdhBd6ViW9fYhzIoQEh8i9t
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(36756003)(2906002)(4744005)(6512007)(31696002)(66946007)(54906003)(31686004)(8936002)(6486002)(508600001)(38100700002)(6506007)(26005)(2616005)(66556008)(186003)(316002)(66476007)(5660300002)(83380400001)(6916009)(4326008)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Zk50SkZGbkZ2cXl3dFZuMGovdnROMW04THNBeDRGMkxOM1c5cjlEMXA5OFpt?=
 =?utf-8?B?OFNSc001TEVEUENtNCtBVFl0Qk1qaXB4TFR4T3JvdHdkbXdEajZpYU5ZRVor?=
 =?utf-8?B?aTlLejNSeklyTS8yb0ZTR0krbHBQY0xvSVFlYTJMV2RpcURyUHJSL0FLMVZ0?=
 =?utf-8?B?Mis3WTloQk5xZjNvVjBIdEF3cWtrZWNhMFZPRnY5WTUzQmVINUxBeEtqRjNt?=
 =?utf-8?B?UlJPRzBoMlBIbW1Tb0Qxdnp2aXpiM3VXZU1PUXA4YVlVcTlVc1pDamt4enNN?=
 =?utf-8?B?cnVBU2ZJaXN4QXBOdDI4bHAzVjlEaDdFc1NRN1FxTHFMdkZEMGtLaTVmZDky?=
 =?utf-8?B?aWp2dmIwYm1VL2NLTEJmVG42QjltdllKV0tsVVZvSU8ybjNXVW5ZTXZBZ1pD?=
 =?utf-8?B?dFBrMU9JZ0RTeXBINlhwc0p2emhiOUZma2hhOG5MZTIxdmV2Ujc1V3pKNFN3?=
 =?utf-8?B?TFUrUE8xZDQ1R0YwSTZjelgxVkwxdG83RjVUd0NPWHhMeW5CT3RwT3VtN2V4?=
 =?utf-8?B?Zi93TXhaWFNVcEdaeEhLUFhuci9Hb1htTGRuMW9NYUFyNzRoLzQybUp1c0Yy?=
 =?utf-8?B?U2VTekl3anpWSDZsQmcxejlURlFIYkdsOG9PdUsxUmNDa3pWSnhRT3ZWME9O?=
 =?utf-8?B?U3ljUVR4RHVsRlJ4MlpPZFgyUGx3YkJQU3hUVUZmaFZPcE9DZDlGNUd3VWtr?=
 =?utf-8?B?TjFXbTB4dmJ3VG01TXhNdlErOG1WZVhxeXFUQXpSL2Q3djBrSWNRUnI2SUYy?=
 =?utf-8?B?ekNBbTVJMWlsdUg4UFZybHorRmRrSWpQcnpjdnFXaEE5RHU3cTBNUTNKZmdw?=
 =?utf-8?B?WWtIekkzZmQwMUZyMW1HU0JHenl2ZTd0NzBGWFB2Zk9aSTZRcUZlQ2NRUmo3?=
 =?utf-8?B?OU5xVjJnSFNwWmdHa2hoczRYRm9sR0VRUXRMV3Uvb1VxcGM2VnFFYTZtRnVp?=
 =?utf-8?B?UngwTFBsODJ2TnorUE1CdGVNOGhpSDZTK29VaFVjMlBOZ0tFdHdsTU8zOVhp?=
 =?utf-8?B?Q1Q3TC8vek9HUUZVbHZHVjdYWVJhMUNyT3lIQkZoTFZYM1MwRTZtMnJJZFd2?=
 =?utf-8?B?b3ZVTzNvUEJ3UTdUOTdzSTRuQ2RYSEI5cUUyM21Xa1o3Yk5ERTg2UW5WVFN5?=
 =?utf-8?B?YTNrQVNYQzVsOXJQSXhMbGdWVEdlZENaS0luc0FtTm1qNUZiNk1CQjN4NTU1?=
 =?utf-8?B?U2lVb2dxYWlBUENRbUljdkExZGNXRWQvN1ViZmFzNzliNnljakNuYlk0YnND?=
 =?utf-8?B?R2lLOGJ1cmNhMFJWYndwR1NISnpSN3ZYdG1CTEY2SGxKeXJ6eXNqRkZNUVAz?=
 =?utf-8?B?eDNiQk10SnM3WDhDcUE3WDR0akpuUFZwKy9iVGwrUFE2amFpd1kyUEVIZ2V4?=
 =?utf-8?B?bEU3cUU5ak1ZQ3NkMlNySlJaWEI2ZVZxMWlXMHdzMnRhbXhPejVvWVlnQUNp?=
 =?utf-8?B?Y3UxNjJlSG1UNWc2RXQyNE5kYlJQckFyS3ozOW9ub2s2UW1uYzdJWHZuY2hW?=
 =?utf-8?B?MHBQWWlXWlROa1NjaW90OVE0Tno2RVpBUDdKcjRNOUl6TXA1czVwV2VlYUgx?=
 =?utf-8?B?enlxUHVFb080amRYblcxQ0VWMC9nbFo1K0tQWEZVV0tQTkJLWGhBTlkxMjd2?=
 =?utf-8?B?eE1la2JmNVpHK0wzVzZrc04vZXVybCtLYmVweVpEZEFBcHljUlVJcjhNb1B3?=
 =?utf-8?B?Y3czL2pwc243WmtXalovdm81b29uWUVqMVpUWWpWRWxvWC9YeFNlQ0JjbWZN?=
 =?utf-8?B?d2VZeFl1UnJjZitaMU1id2pZSDdHWWZDc3U0K25NZDBaYUZxNHhXbXBsRFNk?=
 =?utf-8?B?OEQ3Y2VraHQ0Y082TnkrT2YxYTNvODhLNEN2NlU2SDBua0w1Q0pzYVNqbjcx?=
 =?utf-8?B?Y01vRWk3S05oeWJmK1FCRDBERnhBNHJhTG56bG9sNEdrWHlBQ2VBZmVROWp5?=
 =?utf-8?B?NDlNMVZJR0VqZS83TzBHM25uY0hNcE93NWNuSGFjVTBWT05nNW4rNXcyWFE4?=
 =?utf-8?B?TVZvQWdBSFBhT0VXTU9mWUw4U0loaEhQQ3hiZVpEWmxEeFNZWENHTStiVFFY?=
 =?utf-8?B?aXlOdXVPbzB3N2Ixek9wL09JRExvNE9mQVIvSXFua1A2UHNFYWtmMDNsOGJT?=
 =?utf-8?B?U0o0NFBnMGg5cGU0RGE1eW42WllJUC81b1J5NjYycjNBVjJWU1RkTUN3Q2hT?=
 =?utf-8?B?a1FMeEdCY3ZRM3YxZzc0K0I1bXd6RGptYVdHSEl1cEU0YzhTNHdqUG1sRUFT?=
 =?utf-8?B?cXJhbDRzTmdEclBXcnZvZjV5U2JVdENLMi8zQ2NnaUZkczBYV09xcHIvV2tN?=
 =?utf-8?B?WWREa1BEYVAweVZGem90QkdONXJKaC9QaS9EM2liVGJUNXVqZ0ROQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25e2032d-4ac8-4781-28d3-08da1c6ece10
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:25:45.7366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZjqcPKsMWsuPrBKLxsxiYq9z8jlsYBvL1AVv65K3OD3I3nvbH+4IC1Bmj9PD3J25A1sW4hLpuyq7ri/T0MoZqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8688

While not immediately useful - a new binutils release would first need
cutting - I thought I'd post early the patches utilizing new functionality
there. The changes made are largely benign with gas 2.38 or older.

1: improve .debug_line contents for assembly sources
2: annotate entry points with type and size

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:27:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:27:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303593.517945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDkL-0003qE-46; Tue, 12 Apr 2022 10:27:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303593.517945; Tue, 12 Apr 2022 10:27:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDkL-0003q7-14; Tue, 12 Apr 2022 10:27:41 +0000
Received: by outflank-mailman (input) for mailman id 303593;
 Tue, 12 Apr 2022 10:27:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neDkK-0003py-7I
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:27:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2d733252-ba4b-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 12:27:39 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-iA43Ylw9MhGFfjsVmbShfQ-1; Tue, 12 Apr 2022 12:27:37 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB6315.eurprd04.prod.outlook.com (2603:10a6:10:d0::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr
 2022 10:27:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 10:27:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d733252-ba4b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649759258;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pjldoVbWk4dOoIvq/Xe9YOBnGVbnNaI2DQunigbNhnw=;
	b=S5iuABdzAuPduQJ1a4zdjtE/SEPlZL0WjmvP2ZaYli0L0ozr9T1nxYAX9RiYPUM8KG67MB
	yMj/Or8ZMDWtpMLk1ljyAp0PfE+S6To2tgeUv8naDEqCnDeWhgJQEZ/XgeBnTZw5EZwPyJ
	UK5WEJsnStb8cApumn1kUEkqZd5XWGM=
X-MC-Unique: iA43Ylw9MhGFfjsVmbShfQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nLd7WcPhzCqHZ5EC+x1II3oUv4hDAeYSjf/1gLBcgWZ5SX0urld8vq5kDaqfDdHQJvtkSDd3rsVwyaludxlVuxBv9Lj5TZREGv9aLJ5utugrNQGvJS/P1aRn83bPNU8SsmGDzbYXo9AQ1sKXBwdcfTTdLYGeemOHl17AsuYplepCtWNahnW3FTT/vOZgSj9B5zs8gqnNjgZsUjXt+p/vYfjYixFpJpAQ1RO5n/jaSlCIDzY94vqiz+xxYzsnoYglXh0vwJYl73nZijDsiYKberCVNsdx+YoyE1nhTunf17n/61nGYb8Urzuh7jd4pJ1kaVv0qieOHTCKnx4jZ2Pvng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pjldoVbWk4dOoIvq/Xe9YOBnGVbnNaI2DQunigbNhnw=;
 b=NB7uN0u/S2p4uLXyb4L68sZqtmZfpc2Bja0To7DY2xzoTKNV0Np7DnYrJ8j+XywiTGl1/GeRMQvEpS9mPJXvkeSvWinFZk5gjX2L0njf7CIRCosLHDVBP+PM1gOvyJlu+AzFhrMQ00Au8C4i7jgrwdI7fFOoKydFeE4AAKYz11TKOE1svHLa57YkRWK2C8D9z9HRFBJUJ6v0OPh02bPrqp14Quu5Fkx0rCeAQqenpzh4d8Cg5THo8DXEB0pX+WmsAIVczTpQxfFoZwbbHv2SjyNWcnpHM2sPepiGLS5BWNf71+ttUmdugmCYvvLIuVb1A9IHAu+d0/1PE9YEap8S9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
Date: Tue, 12 Apr 2022 12:27:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
In-Reply-To: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0070.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::47) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 14b6ecd3-3354-43f6-3356-08da1c6f0ff0
X-MS-TrafficTypeDiagnostic: DBBPR04MB6315:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB63154A8E0409A8E2FE905B41B3ED9@DBBPR04MB6315.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kufnx0Qp1M6aE8YATIyKc0ticivtTRk++PCkcmk3nwqKZosYMfj4jL/lX1f1RyRqmtN6RPfBjo3Gp1NmfN5qVQxUiao59SmVEdkI1yyjmJlHzzw/8A2UMhc+s/HwRZSvXS2/Bqx9O0a90HCCxwXX1k8yB/kPr2ruXZurhNNqLkV115p7UW36Ef8IVJnScCUZZWpSZHlgff+jTaXSvSCsa5BPnkiv2C2oEStbeM5T9r/k3eN+K17D7265w/dVp5y6HSSjsON2HyEfdkxI9Vjq345+vcsX6oqj2dOpqQQWPHGn4zHF+jAwyZK0NFZCISQTIDO3jNS1HX06ie59RI8/ijCzotJIJklRfkrNM5/OUe56dMfvwuATDTnQZjqUcS4dmJXVrIAuaIvIEwMQJXxT3Kxgs2cZMw4SrKs3IVMzgX+aTbFZ6Qdk4Qxek162GNwxBtNtd7iU8xSfDut7HCrpjg+TNTX1gbLEuMw0TpJFXeQ1a5ZVbwGxdSOCy2BRFccMH+T6mKiJlJYM3wDn4E48WR8F6rDsSvuVHKgvtQ1GbH3PadNLVhPqh36iCPnr6jnDVnxcYUFV4npcszOVkczmSrxPYqTmaplMA5uKOHVxXcLGrAZY7wrgrJObZm7LaDs4CDl7gue/2rBX2jbIaFgyy63b5526notbnZVWCIrOmPRqZMMXJ5RcXdjdAtjANy3ctfoNrt33UIkg5/wI5gh2jJrMPGDLf2TtQaC6vuBFkVPsa/XywcV72V4T+DYv56HSwBgFcaz9AqLx31wDOonWze+ZvwaRUV1IOlmHV3YX8LZEhi6Jaq81fWdPUSa2LDoMwiBTYOaC6F8ZQ2IacF/H6pcyyIpbyjMBOtfA/D+kz63viyQaaEqSrcBUEvVFp+7tviW86ni+XEK7yHkPCGkRNg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(5660300002)(8676002)(86362001)(54906003)(6916009)(316002)(6486002)(966005)(36756003)(8936002)(4326008)(508600001)(6512007)(66946007)(31696002)(31686004)(66476007)(66556008)(38100700002)(2906002)(6506007)(186003)(26005)(2616005)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1Y2RVBDRWJ0WlFmWWc0WWt0UlFvTmtXMmFudlR2VVZYYnBkSmNXeExxbUVq?=
 =?utf-8?B?dnRHdERTQ3gyczBLWnhWRU5lWUx6bEFwVVh4Z2FJQWoyN0hrQ3BQc1hCTGdk?=
 =?utf-8?B?ZENTRmhFVi9FWVJtNy9NZDlMbTlVekZEZzJZWEV5TU5NajJEak5aaXI0S3pF?=
 =?utf-8?B?dU1URGV6UXBjbm9jQmc0aTFaWVprZGlwM1Vzd3RleXJ6UTFCMXJmejM5clZs?=
 =?utf-8?B?UklmSktzTzZIZ0pSTE5vYkdWaDhra0xQTTV1MGJ5c01tbUd4Z3FtTGl1enZP?=
 =?utf-8?B?Y1ZNMW1TNG0xTmFaNDUyWXIycU52YXdtTFBYSFRXU2N6b2QzZUs5THhKMThY?=
 =?utf-8?B?aURMVjRtSjNqaFpHUSt6YnFlYjFOYlpib2hHbk0xYXIxQ3BmYzNod2cvRENx?=
 =?utf-8?B?ZjdUdzM4cnJ0YXBQODEzdnlXRThnUFdLYS8xR1VlNkYzZ0VNdUswSWVKWU96?=
 =?utf-8?B?VlRIZGpaS3I4Z3RkNE5ndW1xNEpOTUJ4cmFVa1c3NDRTb3hFamxRa0ZpUFBV?=
 =?utf-8?B?UU01cFQwelBSK3JKU0s3dW9FaG05VjBKUzRyNmkxZWR6RHByaVpTckNvRFNL?=
 =?utf-8?B?YTlmbWpJaFhDMUdaTUMxd0FIOGt1dUNJL29KaTJhK1p2VUFMOGFWSU5OUisy?=
 =?utf-8?B?M0FwcnVlem9wTDMrMnlIREt2TGlvNzZJaUFod1ZWSmhTS3RkcGFXY0tyNGZ5?=
 =?utf-8?B?azB2NmdHd2hlRk00cEdFNlBzUm5Qb0NSUnNZLzBwUWkzZWl6UkY3aHFib0ZB?=
 =?utf-8?B?Ny8rZUVyMGQ5emdnbUZrNkdoODE1TlYvRWh6eEhVQkgrNnBXV3ZEeUdpZi9l?=
 =?utf-8?B?c0lwTThtRmE2Q1ZIQkhMaitBUTliYSs3S05sTlArWGlMdkt0dEN5aURlUzFS?=
 =?utf-8?B?WXgrUGNLNndpTU1TSjFMaDJYMUhEVnlVZkkzWDZOM0dtOElqNWNtVXRiVGF4?=
 =?utf-8?B?TlNkZHJEdHJNZTdTd085R1F6c3VmSTdFUkJQTUtZZ1h3ckc4VXNyV2hla1pa?=
 =?utf-8?B?WVBVZTRrMWk2MlR0TEw5bFlGQnE0ZXdXR0cxUlBGVnhGQ3V2WENZbjVqNUpm?=
 =?utf-8?B?QzVzT0xJbnN3dHpITVRxanJqVE0vVlhiLy9qOEdycnlTVkJmK1ZkUmt3QUJH?=
 =?utf-8?B?ZnZ2UjljV0ZicGFhQ3RtRVg5YWhTUUxHc3RTazNkNlVnbHJxYUUvaHFSWDlI?=
 =?utf-8?B?bzFqUE9NZ0VTM0s0SHlDMVN1VGJ4RzZHWjdyWms4OVA2MmxsVGp1U3VRbEEx?=
 =?utf-8?B?djd4dCtYRkEyWEtTOVNpS1dCVE4zTjNDT0FrRjFHbHFCbi9UaWtQb0FtZ25n?=
 =?utf-8?B?UFFSMUdocXNTYm9Ia21jSmdJbUc5ZEVYbVAwMVlwdGkzU1gycWEwVEZDVVBo?=
 =?utf-8?B?clJsRVBkNUExYnkxUHVlTEVaS3ZpVFdCcDNyWmRVb2xrUTBKOEtBMktNL0Mw?=
 =?utf-8?B?ajd3VStRd0xzUTJFTmVPcE1reWhLM3dwcVZJdjNuNExLR3NFNmdvY0FlR0g2?=
 =?utf-8?B?a1JuSXlaTS9IaVp5Njhkby9CTDI3T3UxUXV4VTJVbVVLT3FWRWVvSm5MUnVq?=
 =?utf-8?B?YlE5TGNlV1c5R0JWUGIvUlZ5cE5lQ0IvWkh0MEY3QXV6VjNzQzVQN2pWN0JD?=
 =?utf-8?B?dERwZ3dJSGpxSnJjWFU4d2tBYVpPMjViU09ZWFRxdm5zMlppOWFvVGZGbEdZ?=
 =?utf-8?B?anJYMklIdDg1Uy9NMTN6NGpxdkliNXdoUUpSa2VGb1VxWm5PYU0xMDRaMStF?=
 =?utf-8?B?elR3NGcyMGk2ZjRSdmJmOEJyT0t4Vzg5amxJSEUyZUYza1hveG04d0F1bmY4?=
 =?utf-8?B?bmJaSzhUSGpReit6VUxpSWFHekwrbFV6TUR2NTV3UlRoTmwrb0hhSzNtNjNY?=
 =?utf-8?B?dlpwWFVtTFlqMGs1NFdiTXh1ZkduL0gwa1psSTNRT3dTMmthemcwTytVVy9j?=
 =?utf-8?B?dTEwWEd1VG5QQWtIYXU1NTZncXlHd3NtazFuRnVzRGhzeXhCRU5pRlhMcG5z?=
 =?utf-8?B?RFpQUVZqcE5YemNXbHpHaVpmYlRRczNkUmF5VUd3cUpUV21yRTJ3UlRiei9C?=
 =?utf-8?B?M1ZFVFl5b0xYeXdlU3plWDNkelE5ZDFTUytvbGx6TjJKVVZ4amxZL25LQ0JX?=
 =?utf-8?B?UUZHSU1HRUlONnQrQlRBUWZuYlEzR0NFZ3oyaTJGTnVpZytQYytLc1FzWHpY?=
 =?utf-8?B?LzJ4eVpraXd3UEVZSGVWK3Q3d2VSNHRVdDB0aVhaU1gzM3B5N2tJUHNGMWUr?=
 =?utf-8?B?WEVVSUFWcnMvWjJySDdLNkcwT3ArZUVMMGJMakkwRnlhVFJ5UFRORVEveUZn?=
 =?utf-8?B?TjFHL2NHZnBCVVFvdW8yVzRhUGhFa2ZZekxlV01QY1E5cUxTUWRsUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14b6ecd3-3354-43f6-3356-08da1c6f0ff0
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:27:36.1787
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /uwwEmx6lON2cv5Nme+0DQaTjxyio6v44rD1CyMkncCIIKoUHWMO/BoEDzDSSfbr21XZCe1A62J4Lhp8H6fWMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6315

While future gas versions will allow line number information to be
generated for all instances of .irp and alike [1][2], the same isn't
true (nor immediately intended) for .macro [3]. Hence macros, when they
do more than just invoke another macro or issue an individual insn, want
to have .line directives (in header files also .file ones) in place.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical) STT_FILE entries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also
internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].

[4] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=c39e89c3aaa3a6790f85e80f2da5022bc4bce38b

--- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
+++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
@@ -24,6 +24,8 @@
 #include <asm/msr-index.h>
 #include <asm/spec_ctrl.h>
 
+#define FILE_AND_LINE .file __FILE__; .line __LINE__
+
 /*
  * Saving and restoring MSR_SPEC_CTRL state is a little tricky.
  *
@@ -89,6 +91,7 @@
  */
 
 .macro DO_OVERWRITE_RSB tmp=rax
+    FILE_AND_LINE
 /*
  * Requires nothing
  * Clobbers \tmp (%rax by default), %rcx
@@ -137,6 +140,7 @@
 .endm
 
 .macro DO_SPEC_CTRL_ENTRY maybexen:req
+    FILE_AND_LINE
 /*
  * Requires %rsp=regs (also cpuinfo if !maybexen)
  * Requires %r14=stack_end (if maybexen)
@@ -171,6 +175,7 @@
 .endm
 
 .macro DO_SPEC_CTRL_EXIT_TO_XEN
+    FILE_AND_LINE
 /*
  * Requires %rbx=stack_end
  * Clobbers %rax, %rcx, %rdx
@@ -192,6 +197,7 @@
 .endm
 
 .macro DO_SPEC_CTRL_EXIT_TO_GUEST
+    FILE_AND_LINE
 /*
  * Requires %eax=spec_ctrl, %rsp=regs/cpuinfo
  * Clobbers %rcx, %rdx
@@ -241,6 +247,7 @@
  * been reloaded.
  */
 .macro SPEC_CTRL_ENTRY_FROM_INTR_IST
+    FILE_AND_LINE
 /*
  * Requires %rsp=regs, %r14=stack_end
  * Clobbers %rax, %rcx, %rdx
@@ -288,6 +295,7 @@ UNLIKELY_DISPATCH_LABEL(\@_serialise):
 
 /* Use when exiting to Xen in IST context. */
 .macro SPEC_CTRL_EXIT_TO_XEN_IST
+    FILE_AND_LINE
 /*
  * Requires %rbx=stack_end
  * Clobbers %rax, %rcx, %rdx
--- a/xen/arch/x86/indirect-thunk.S
+++ b/xen/arch/x86/indirect-thunk.S
@@ -12,6 +12,7 @@
 #include <asm/asm_defns.h>
 
 .macro IND_THUNK_RETPOLINE reg:req
+        .line __LINE__
         call 2f
 1:
         lfence



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:28:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:28:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303596.517957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDku-0004NY-EI; Tue, 12 Apr 2022 10:28:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303596.517957; Tue, 12 Apr 2022 10:28:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDku-0004NR-AG; Tue, 12 Apr 2022 10:28:16 +0000
Received: by outflank-mailman (input) for mailman id 303596;
 Tue, 12 Apr 2022 10:28:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neDkt-0004Hl-6N
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:28:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 42447106-ba4b-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 12:28:14 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-LrgdbbHaNCaZ7pPxBlKXAw-1; Tue, 12 Apr 2022 12:28:12 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4181.eurprd04.prod.outlook.com (2603:10a6:209:4c::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Tue, 12 Apr
 2022 10:28:11 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 10:28:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42447106-ba4b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649759293;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7hkQxPfO69f3ADg5a3PalCKGxVvlVBa32J4aqnLZzYs=;
	b=ToAZfHWfnIIuLkBnYTLN1XAHwv5WjLKYOqHPCyqDxusqh1A8NliRfie1IvBFpQa9irMSHB
	QdKvBZtcRiVL3KLE01tDMnNf9XXtfK8Z3EeBIPQOq1rXPmcBcF3fPx6JnzyLb7rfEqx1o4
	N7k1t6h9VN7H27Gi913GUj457C2fVos=
X-MC-Unique: LrgdbbHaNCaZ7pPxBlKXAw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=naitpdP60afQ9W4uXaTqCu2u+IUvv25b97of08TnyGP7s/uOjP+H9PiVf0GcU6A+oKjlRaY0VZNF6R/oGWHNcVwcd9VoYhrrQ67io6lyDEO6vK1gMSS+gegwDRVakivCyARKDy2mM51+9e0zVotW+sqc24fFBAIx+efNYj5abatoLt/Mbj9scHCBthj8v+tRbFlFgb8k6UIZhg/13kXwJkZ3zRIk8vRWAetTDpWfWmmuN7jGNcVWMJOLYNZ4/ucpXcMSD7iEO2awNfXtzGtZxfLwTMNRV1U8L4vI38Qw39MpUQvOSd7JuHaeSRjSNFVd4+FQHyY279kJLzNjxzpY3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7hkQxPfO69f3ADg5a3PalCKGxVvlVBa32J4aqnLZzYs=;
 b=AOJAtWB6Kji/B6PII2CxMrLu1fxW8DyQxUxyh8eqTgWHNR5KCSb15aTi4oWXbgpBhzpQsile3RjYH241yxn9UafO7MaGDCcfpsJbg0mcmEzDu7GVmhHEmr/ZWuZLpaPmEDY1BroDggB8bM0tBFaPtAqigEOEDKDl0mMS80+Ea8jbqqdxm98TTaby+kbDmUIPBUSqnhlPEUMvvG33/BFPY4T3SkHmVaWTJf8Q2DvudYEsl6ea+QzJMiwCI8k7t6UeYB1YW/OCov8CmSJ92kBTnaHyz/KcD5n74Bw4iXq86J5N2F3ikhJam6xA0DW+yeiAk8Vf4u6HdbAR0jqwBjLEdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <531ab7f7-ce5a-12b2-e7e7-528c26f9ff7f@suse.com>
Date: Tue, 12 Apr 2022 12:28:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH 2/2] x86: annotate entry points with type and size
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
In-Reply-To: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0059.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::36) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c7e56a4-bdc0-43df-fdfa-08da1c6f2501
X-MS-TrafficTypeDiagnostic: AM6PR04MB4181:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4181BF600A93DD170DE98E40B3ED9@AM6PR04MB4181.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7lXFI0CxYBkwEMZJKSwHUM07X1tz4Hek4DKKWzVThgCFKFuPohMEA9qxTqIlxqMjyxHjWu9cCDC6ZIWK0WmgqKhjQEuFFRLf5lsDn9tqRuos7P5herCThcXC63iY7CAeFKkWn0bMWnDy5TbZUZNMuV9TnfhMXpww1+9dE8ApH2pzBUdwuk2d/o4fENtnepxM9D69JRmRykMDwtS/hjffkO/6xfC3m63OBdYXeGiSA10IoopRxRFMXfdU2umYlymAW7uhYRxT7zXHlpe2pDiaMg0tUy07Pq5WV0x66HgCdSD8c+CTe9uGXh9eQxZTbumLanO9WarE/PdygIJRkvF6kjBNsivfAdrufqtYYpcOpYt4x0NoX6fiotfIJPbVnN8roMBpbnT1lImsAofHa//GoSbscmNbG9wrVYX/xSC8ruk34kJjbmujwMXEYZhnYnBA+fEdq0oocGIh37QyvW7c/AI+SRkxCZNadJVnXNfdbokvm42ElZVSXvD03Jni7FczwMZF+PVs5e7Ur7mrr0ptdmOLTJqC3UqHB2oahMnssqAwVSKZhIPIqUX/NhStog7SFoK8pLSr9sUBITzyCPmk/JbQBFzHgnkkUxTeMyv4PiVUAEZGowxEiVud0H88uZvSdN8DriuC8lUlvIp3pRivMvK/iv1r8rVauPt8HKJ9hG1ZZhFuQqELsLQ+lM+R9TPRqSjLZ8KdWwSs92qRez9j43sUwPka9fwcWHOhZVbTSKL86wUmXJOjiLZHy6PdB4RJWUmfHbawVsx5ZCvjS1j1kilp2N8UkNg8OcHNlc7n1+ah8HmpWLiaTYJKCyDkGniJ8BrVxV8H0JLFpRo68MVz1w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(83380400001)(6506007)(66476007)(66556008)(2616005)(508600001)(6486002)(31696002)(6666004)(26005)(186003)(5660300002)(86362001)(66946007)(36756003)(2906002)(8676002)(31686004)(6512007)(966005)(6916009)(4326008)(54906003)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cjVvb1pDR2VleWppamVTS0tjL204Nk9NNjlaUmwyd0NCUG9sOWtVR1RFb2hN?=
 =?utf-8?B?Z3c2dUZWQnNPWVpJRW9aY1d4SmJHLzdueS9JTnpCRk5WTlFPZFVrYk5RUDNp?=
 =?utf-8?B?Y1h4U1ltcVRHaWFHS2NVUkVObkpXc2xSdUZuOHNyeE5oWmJoeE5lQmtJcmNn?=
 =?utf-8?B?REIweS9GV3pHQkxCdVJzRjJaK09Jb09QcFZxSDhHYms3aTZRWGREK1FmdjA0?=
 =?utf-8?B?eWQrRjlta2s4Q2FyQ0Z1dm1tK2Mzc3AxQUNoQXUwSnhPaXBHQWhpVzNhK2VC?=
 =?utf-8?B?K1JuZ3Z3MnFwR3BEVmdlVG5iUkZOV3cyRWtiYVptemFod3QwMXNtNUd4Z2th?=
 =?utf-8?B?aW5SR0lGQkxUSlF2YVhuRko3bmt4TVpxSjNySWgzWnNVZ2Q1UkRiNmk0RndO?=
 =?utf-8?B?UXZPZkdJdityVEdqWHFOVFcxT2VCaGNnZTBLN3lmM0x5Z1JhSndrQ3RKLzdh?=
 =?utf-8?B?SkJCMnJuMG81Q3lIeFErSy85WGJ4UDJkRTMycWU4YXp2V044TktSMDY3WnlM?=
 =?utf-8?B?OTZLNUdNM3pDR0laTjJyN1A2QUV6NWwzdnYvdFJQeXUyNFhCTkNob2ZCYWZh?=
 =?utf-8?B?Q3lUaXFQZzFmSDViSnBUZzZydy9JY2hEMDYzSkJZUko3eVpkRDlXeDdXSUVI?=
 =?utf-8?B?V3BrU1ZCZGRZdnJrUlRDdklUeEl2V2xjWTlFanBnbGJ6K2tWazdWclNRTkJk?=
 =?utf-8?B?K2FuRU9PRC9sWkhUUGU0b3Z6b0pSdEpJRldpdndmdE10b3hXbWxDdmdHVkFG?=
 =?utf-8?B?OGd3UjIyM0tRS2FnOFBzZUlZTWxvUlpvd0RnWFZnVmRwbGlJcFgzM2lVTm1q?=
 =?utf-8?B?YnlpdytwNlUwdHpSMlJVMVZUWUc5bHBRTFkrRmxQbjUvcU9tS3plSllwVUoz?=
 =?utf-8?B?MzFmblV1ZWRzQnc3Y25ic3B5UEc0b2NBWXBjSnBEdFRSbEZBVXlpV1ZsVGgx?=
 =?utf-8?B?cUNIVFFDZ0lXMEtIZ3daWElPUHl0NG1GMk1Ha1FHdFBLZVYwejVDRkFjYWRy?=
 =?utf-8?B?cU5FK3htUFg3dWlnVVI0SWRJSUdTWDNlMzBsSnRjdUtvTTA3V1BXeE0xNGlV?=
 =?utf-8?B?TnJxQ1pVTzl5b3VHT3Z2b0J6VlYyL3NRcFJRcXd0cG4rMnRITjJsS0pOQXY0?=
 =?utf-8?B?V3dURU1QQzRUQ0xUSERpUVJ2dVFUNitXTXpxSjVjUHgvbXd0SU54T3NJREN1?=
 =?utf-8?B?dHJaV2dQaFhGVGJkeFhEanhOYVhpQUk2ZkRwelNka1Y0TVBZc3FpM24wcXpV?=
 =?utf-8?B?NWhKMVBTQ0NHTkJFRU96NERZc25Ka2VaNnpPVjRCeHFWVnNieUpyS2F1eGJT?=
 =?utf-8?B?MTRpRTFBWmxnYnVnTW55UWYvSTI1UmlPYnhiWGg1My9ZMHh0aVkrSnVCSFVs?=
 =?utf-8?B?MTduWkhXTTQ4WVhURjFad2ZyREQ0OFIvOE14dGJOcjJSZTIzQWgzcXQwQWFz?=
 =?utf-8?B?UHBtYWVybWZHZHk2UW14UDM3MWZpSzJNbS9FamJuZUtieEI1eDFMbU1CUWx1?=
 =?utf-8?B?SU5PWFB5eElTZHNmOW5Ud1RQdjY0Zzh4VnhxOHhCU1phQUV1S0twaFByb0U2?=
 =?utf-8?B?aDY1LzVSSFI2d2VENGtDT0VBTE9HY2dOdENpb0VhLzQ5YkZ6N2NHSDRwazFB?=
 =?utf-8?B?VldVZjFFai9EVjRJQlEvT2FZOHNIRlRvS3NKS1ZnNnRwTW5FK3FFVGV0WWJn?=
 =?utf-8?B?ZE0xUXNtSGRnUk9SUThaS3BKWEY3R1JNNnVWRzdSV1ltVW0vUUdlRlVKVTBX?=
 =?utf-8?B?TVR1OUVuMVFGNTdsZ0dxWEdGdFBocGQzalRXUWZndXRHQzY0d2xzSUNOWFVK?=
 =?utf-8?B?c29FV1hZdVN3WEEzMFdCb3poNkY1K01WOFphOGlRUzN5SGNQaE5KMjhxVUdB?=
 =?utf-8?B?VEhERSs1aHdJT3RCM0xzcDhHUVE1dmhNd085OUg1ZjZLV2xWVjRUdnJHMkNW?=
 =?utf-8?B?UHZ4RGlGSnpxSGVkMDlrQVU1Y2xVNmlvUFVrMkpJMUlsY0wxUERaS3FMRVBO?=
 =?utf-8?B?eXMrZ3pqYmIxKy85UmR1b0hhWDJOZktneXZoKzdXODE1eXYzZk9tQ0pVb2U0?=
 =?utf-8?B?M2F1dk90OFJzU1I5dEhNMmc5UDBEeENRNkF1MFdpR0VQUUJyeWhlYVZaa1JW?=
 =?utf-8?B?SXBOdXlPa1U2YWR0dUU5cENiSUpVRW01U0o0OVMwUGgyQVlnZlQwOHAwYWhB?=
 =?utf-8?B?YWtCNnAraENOY1l6dlV3Q1poeGpRYVArYXNTUS9PZVJiMFQrTHUyYWN0YUZ5?=
 =?utf-8?B?eHNoREtkeXhHL1hCb2NOWEVtRE5CODgvTUVIYzhBby9BbHdpd2w2aGlhVldJ?=
 =?utf-8?B?anh2RDFqRHpiNVRBOFJjWUt6d2NodHFRMkdtcEsxQTBmQzBsQi94UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c7e56a4-bdc0-43df-fdfa-08da1c6f2501
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:28:11.4962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PrvREJ2x0VTq+NyyeFby8VXhIvqNmTr8+qZ9xUzkB6fepNSPV18nc5TYWy7ezxsCvZGJiXmQQy7Aw/0rqlOeOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4181

Future gas versions will generate minimalistic Dwarf debug info for
items annotated as functions and having their sizes specified [1].
"Borrow" Arm's END() and ENDPROC() to avoid open-coding (and perhaps
typo-ing) the respective directives.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28

--- a/xen/arch/x86/include/asm/config.h
+++ b/xen/arch/x86/include/asm/config.h
@@ -53,6 +53,11 @@
 #define GLOBAL(name)                            \
   .globl name;                                  \
   name:
+#define END(name)                               \
+  .size name, . - name
+#define ENDPROC(name)                           \
+  .type name, @function;                        \
+  END(name)
 #endif
 
 #define NR_hypercalls 64
--- a/xen/arch/x86/x86_64/compat/entry.S
+++ b/xen/arch/x86/x86_64/compat/entry.S
@@ -27,6 +27,7 @@ ENTRY(entry_int82)
 
         mov   %rsp, %rdi
         call  do_entry_int82
+ENDPROC(entry_int82)
 
 /* %rbx: struct vcpu */
 ENTRY(compat_test_all_events)
@@ -116,6 +117,7 @@ compat_process_trap:
         leaq  VCPU_trap_bounce(%rbx),%rdx
         call  compat_create_bounce_frame
         jmp   compat_test_all_events
+ENDPROC(compat_test_all_events)
 
 /* %rbx: struct vcpu, interrupts disabled */
 ENTRY(compat_restore_all_guest)
@@ -161,6 +163,7 @@ ENTRY(compat_restore_all_guest)
         RESTORE_ALL adj=8 compat=1
 .Lft0:  iretq
         _ASM_PRE_EXTABLE(.Lft0, handle_exception)
+ENDPROC(compat_restore_all_guest)
 
 /* This mustn't modify registers other than %rax. */
 ENTRY(cr4_pv32_restore)
@@ -193,6 +196,7 @@ ENTRY(cr4_pv32_restore)
         pop   %rdx
         xor   %eax, %eax
         ret
+ENDPROC(cr4_pv32_restore)
 
 ENTRY(compat_syscall)
         /* Fix up reported %cs/%ss for compat domains. */
@@ -222,6 +226,7 @@ UNLIKELY_END(compat_syscall_gpf)
         movw  %si,TRAPBOUNCE_cs(%rdx)
         movb  %cl,TRAPBOUNCE_flags(%rdx)
         jmp   .Lcompat_bounce_exception
+ENDPROC(compat_syscall)
 
 ENTRY(compat_sysenter)
         CR4_PV32_RESTORE
@@ -236,11 +241,13 @@ ENTRY(compat_sysenter)
         movw  %ax,TRAPBOUNCE_cs(%rdx)
         call  compat_create_bounce_frame
         jmp   compat_test_all_events
+ENDPROC(compat_sysenter)
 
 ENTRY(compat_int80_direct_trap)
         CR4_PV32_RESTORE
         call  compat_create_bounce_frame
         jmp   compat_test_all_events
+ENDPROC(compat_int80_direct_trap)
 
 /* CREATE A BASIC EXCEPTION FRAME ON GUEST OS (RING-1) STACK:            */
 /*   {[ERRCODE,] EIP, CS, EFLAGS, [ESP, SS]}                             */
@@ -352,3 +359,4 @@ compat_crash_page_fault:
         jmp   .Lft14
 .previous
         _ASM_EXTABLE(.Lft14, .Lfx14)
+ENDPROC(compat_create_bounce_frame)
--- a/xen/arch/x86/x86_64/entry.S
+++ b/xen/arch/x86/x86_64/entry.S
@@ -139,6 +139,7 @@ process_trap:
         leaq VCPU_trap_bounce(%rbx), %rdx
         call create_bounce_frame
         jmp  test_all_events
+ENDPROC(switch_to_kernel)
 
         .section .text.entry, "ax", @progbits
 
@@ -230,6 +231,7 @@ iret_exit_to_guest:
         addq  $8,%rsp
 .Lft0:  iretq
         _ASM_PRE_EXTABLE(.Lft0, handle_exception)
+ENDPROC(restore_all_guest)
 
 /*
  * When entering SYSCALL from kernel mode:
@@ -281,6 +283,7 @@ ENTRY(lstar_enter)
         mov   %rsp, %rdi
         call  pv_hypercall
         jmp   test_all_events
+ENDPROC(lstar_enter)
 
 /* See lstar_enter for entry register state. */
 ENTRY(cstar_enter)
@@ -320,6 +323,7 @@ ENTRY(cstar_enter)
         jne   compat_syscall
 #endif
         jmp   switch_to_kernel
+ENDPROC(cstar_enter)
 
 ENTRY(sysenter_entry)
         ENDBR64
@@ -384,6 +388,7 @@ UNLIKELY_END(sysenter_gpf)
         jne   compat_sysenter
 #endif
         jmp   .Lbounce_exception
+ENDPROC(sysenter_entry)
 
 ENTRY(int80_direct_trap)
         ENDBR64
@@ -473,6 +478,7 @@ int80_slow_path:
          */
         GET_STACK_END(14)
         jmp   handle_exception_saved
+ENDPROC(int80_direct_trap)
 
         /* create_bounce_frame & helpers don't need to be in .text.entry */
         .text
@@ -617,6 +623,7 @@ ENTRY(dom_crash_sync_extable)
         xorl  %edi,%edi
         jmp   asm_domain_crash_synchronous /* Does not return */
         .popsection
+ENDPROC(create_bounce_frame)
 #endif /* CONFIG_PV */
 
 /* --- CODE BELOW THIS LINE (MOSTLY) NOT GUEST RELATED --- */
@@ -640,10 +647,12 @@ ret_from_intr:
 #else
         jmp   test_all_events
 #endif
+ENDPROC(continue_pv_domain)
 #else
 ret_from_intr:
         ASSERT_CONTEXT_IS_XEN
         jmp   restore_all_xen
+ENDPROC(ret_from_intr)
 #endif
 
         .section .text.entry, "ax", @progbits
@@ -667,6 +676,7 @@ UNLIKELY_END(exit_cr3)
 
         RESTORE_ALL adj=8
         iretq
+ENDPROC(restore_all_xen)
 
 ENTRY(common_interrupt)
         ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP
@@ -697,10 +707,12 @@ ENTRY(common_interrupt)
         mov   %r15, STACK_CPUINFO_FIELD(xen_cr3)(%r14)
         mov   %bl, STACK_CPUINFO_FIELD(use_pv_cr3)(%r14)
         jmp ret_from_intr
+ENDPROC(common_interrupt)
 
 ENTRY(page_fault)
         ENDBR64
         movl  $TRAP_page_fault,4(%rsp)
+ENDPROC(page_fault)
 /* No special register assumptions. */
 GLOBAL(handle_exception)
         ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP
@@ -872,12 +884,14 @@ FATAL_exception_with_ints_disabled:
         movq  %rsp,%rdi
         call  fatal_trap
         BUG   /* fatal_trap() shouldn't return. */
+ENDPROC(handle_exception)
 
 ENTRY(divide_error)
         ENDBR64
         pushq $0
         movl  $TRAP_divide_error,4(%rsp)
         jmp   handle_exception
+ENDPROC(divide_error)
 
 ENTRY(coprocessor_error)
         ENDBR64
@@ -890,72 +904,85 @@ ENTRY(simd_coprocessor_error)
         pushq $0
         movl  $TRAP_simd_error,4(%rsp)
         jmp   handle_exception
+ENDPROC(coprocessor_error)
 
 ENTRY(device_not_available)
         ENDBR64
         pushq $0
         movl  $TRAP_no_device,4(%rsp)
         jmp   handle_exception
+ENDPROC(device_not_available)
 
 ENTRY(debug)
         ENDBR64
         pushq $0
         movl  $TRAP_debug,4(%rsp)
         jmp   handle_ist_exception
+ENDPROC(debug)
 
 ENTRY(int3)
         ENDBR64
         pushq $0
         movl  $TRAP_int3,4(%rsp)
         jmp   handle_exception
+ENDPROC(int3)
 
 ENTRY(overflow)
         ENDBR64
         pushq $0
         movl  $TRAP_overflow,4(%rsp)
         jmp   handle_exception
+ENDPROC(overflow)
 
 ENTRY(bounds)
         ENDBR64
         pushq $0
         movl  $TRAP_bounds,4(%rsp)
         jmp   handle_exception
+ENDPROC(bounds)
 
 ENTRY(invalid_op)
         ENDBR64
         pushq $0
         movl  $TRAP_invalid_op,4(%rsp)
         jmp   handle_exception
+ENDPROC(invalid_op)
 
 ENTRY(invalid_TSS)
         ENDBR64
         movl  $TRAP_invalid_tss,4(%rsp)
         jmp   handle_exception
+ENDPROC(invalid_TSS)
 
 ENTRY(segment_not_present)
         ENDBR64
         movl  $TRAP_no_segment,4(%rsp)
         jmp   handle_exception
+ENDPROC(segment_not_present)
 
 ENTRY(stack_segment)
         ENDBR64
         movl  $TRAP_stack_error,4(%rsp)
         jmp   handle_exception
+ENDPROC(stack_segment)
 
 ENTRY(general_protection)
         ENDBR64
         movl  $TRAP_gp_fault,4(%rsp)
         jmp   handle_exception
+ENDPROC(general_protection)
 
 ENTRY(alignment_check)
         ENDBR64
         movl  $TRAP_alignment_check,4(%rsp)
         jmp   handle_exception
+ENDPROC(alignment_check)
 
 ENTRY(entry_CP)
         ENDBR64
         movl  $X86_EXC_CP, 4(%rsp)
         jmp   handle_exception
+ENDPROC(entry_CP)
 
 ENTRY(double_fault)
         ENDBR64
@@ -981,6 +1008,7 @@ ENTRY(double_fault)
         movq  %rsp,%rdi
         call  do_double_fault
         BUG   /* do_double_fault() shouldn't return. */
+ENDPROC(double_fault)
 
         .pushsection .init.text, "ax", @progbits
 ENTRY(early_page_fault)
@@ -990,6 +1018,7 @@ ENTRY(early_page_fault)
         movq  %rsp,%rdi
         call  do_early_page_fault
         jmp   restore_all_xen
+ENDPROC(early_page_fault)
         .popsection
 
 ENTRY(nmi)
@@ -1120,17 +1149,20 @@ handle_ist_exception:
         ASSERT_CONTEXT_IS_XEN
         jmp   restore_all_xen
 #endif
+ENDPROC(nmi)
 
 ENTRY(machine_check)
         ENDBR64
         pushq $0
         movl  $TRAP_machine_check,4(%rsp)
         jmp   handle_ist_exception
+ENDPROC(machine_check)
 
 /* No op trap handler.  Required for kexec crash path. */
 GLOBAL(trap_nop)
         ENDBR64
         iretq
+ENDPROC(trap_nop)
 
 /* Table of automatically generated entry points.  One per vector. */
         .pushsection .init.rodata, "a", @progbits
@@ -1187,6 +1219,7 @@ autogen_stubs: /* Automatically generate
 
         vec = vec + 1
         .endr
+ENDPROC(autogen_stubs)
 
         .section .init.rodata, "a", @progbits
-        .size autogen_entrypoints, . - autogen_entrypoints
+        END(autogen_entrypoints)



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:36:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:36:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303603.517972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDsQ-00060h-Bh; Tue, 12 Apr 2022 10:36:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303603.517972; Tue, 12 Apr 2022 10:36:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDsQ-00060a-8k; Tue, 12 Apr 2022 10:36:02 +0000
Received: by outflank-mailman (input) for mailman id 303603;
 Tue, 12 Apr 2022 10:36:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neDsO-00060B-DZ
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:36:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 579d8f5b-ba4c-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 12:35:59 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2059.outbound.protection.outlook.com [104.47.0.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-3LH67ZJJNuCnf_FstZfXMA-1; Tue, 12 Apr 2022 12:35:58 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PR3PR04MB7449.eurprd04.prod.outlook.com (2603:10a6:102:86::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Tue, 12 Apr
 2022 10:35:56 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 10:35:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 579d8f5b-ba4c-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649759759;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IiZw/xKH1YvRWQhrvlS9anyN+AZzc+uATdIDjuIab1E=;
	b=YlIxa1gvRCeXHz0C9XpDUU2MoTGEx8y1eM1b813OopyVhgwUjp7kjucIz/702TEIPaZeD8
	Fxu45WbyFahHaZJknotGOius6iSp56GLz6QP3AkO74z1P52gS6e2V2DKwywxKoPA2GbAhJ
	JsSlH64BYsnMzmFz1347jQ8aqIBcZ8Q=
X-MC-Unique: 3LH67ZJJNuCnf_FstZfXMA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=luRPLNHCiL8kgv1vAo/TIqVP/djujOpY+mntta9pcLUnHvKH3x+5mWbU4Lcs1JrAiRuQzpAe0o0cUqwtNaPSjujgKcZ7MLcXwy19tLbNmwB5wX9uLzwAx00WHpx+tCqKyvp9Z5OiQduTkaSjNmQ+8r3/UqVCsj4Ex6m+bOgO4MHPLXHLooog9y+3K2uNfXrhdsNSv5QMO5q9jBpDeTFbbwYx5IAALZ+lldzkmxzNgE6pE29cJ4OeM6OVmPFLPckyTgQz5P5ffavXk6DQ6MN4ek5CHBgGflfAG/sNJcYyHU95VFCo6wRQu3Sd04BBy9jiGDsX2oH5O3n5GCeYKm2x5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f71msdOqqBAgXBkZWxPjrJDYt9BvK8zXaPfKjRtojEo=;
 b=WN5p7Z0LHzt3h808LntcdLLZ8lzpQNGsnD5Co0OhMH4/xHOBN33LujOqln4HEA+RnsXlomP9GnIfuBaBlpXfTv1Ymnw97UnBbt0ELH6OZQldXQn3D6Xzsxdt58SiviVVqR8p3Citz+3DOKh9YyzSOBVX9kkLKAwLe6BURa6LocVjCxK5IyAGS1QNRvpLuI0O7F0D/vbsxIjmH+9Y57dN+cK8Zj2oL7DztlzBd4dTqMKSW2z3gGOofmk+X/x3kb7gF0PICH0GyhT/mWqhDWZJqFXXk8jveAfwHqGVeZsCHP0+/4nsushO+4sGijR8bhFbiYWBwyUD5hpdB+D3rm5auA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b2294fcf-025f-7688-25ed-4d6ffa1f0a7c@suse.com>
Date: Tue, 12 Apr 2022 12:35:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 4/8] VT-d: refuse to use IOMMU with reserved CAP.ND value
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <0f7136ae-0b52-431d-f789-4b7d5bbecb25@suse.com>
 <YlVE8ImYfQUPEPxn@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlVE8ImYfQUPEPxn@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0099.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::40) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2db673a3-114a-476d-a9de-08da1c703a08
X-MS-TrafficTypeDiagnostic: PR3PR04MB7449:EE_
X-Microsoft-Antispam-PRVS:
	<PR3PR04MB744925CA1E3D2B81440BF371B3ED9@PR3PR04MB7449.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Tf3GJpxOcl+LfFpM411iPwnAX2lc5kpXR0nuSDbhfb0veHtX6B213idAYvLNjLH/GDnyIuM2clKwPFVj1zOl0+z6MEJvB/x9bVtATaHr9T6NVt5337qN3Pz+ThdCdV1biKIC5mWPaQNx7ZupzzzDq+3Ws5QwxcumPKJY1hFMvf2/DLnxmU8To3zvTZtRWGMGDkR+HieUZdHknp306UTnuBSVQHEwMDXRFbsZAPlVH0lJDGaXt2/ATo+R9ZtnpG9ME/aUKdeEn+S1be/mdKMuPa5qjwO9mePYggrEmIemWrtkpBZYN3l02fDgrL9TuC1V4FOgM9ZztdrA1gbAWd4BhSWDxSADpKIUkR/Okkap1cwd/Vj+FnVH/B2tsPOY4Ibwm3Q2tPgmEWQYzMQEyohWQ3PrBf9KQ26YswAgYSmbWfSpev+JgNVcVGas4WRu5/nwk3lYOd35PRR9NaWhvu3C/0K5du8YVmAylDqyOjdxgprcfLUmH5vqNv9ECJ6VdGFA8IytOhQiqGR0Xn/7CvM5lDP8/LC72VCaPNx/I0JR/7oBSOqbLSuOkOpcD+Vr0FMcOJwqQxu6897BL4y/GCDSTzfUk6DgaSxXne8+bSX3/AblxOpAb+9UAcYBKZzP3UhKOqhfnFD+eqDjDQHwbV+yF7wzRVlD4AwKOMXL7Hq4pLjtJfIhxAymWLaxXsJB6mDl/nesX0xqeTpcuRQn6TftlY7Sx94rFoUwKjo5dGObwEs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66476007)(66946007)(86362001)(8936002)(2616005)(31696002)(4326008)(4744005)(8676002)(6486002)(5660300002)(508600001)(2906002)(54906003)(36756003)(31686004)(316002)(6916009)(6506007)(53546011)(6512007)(38100700002)(186003)(26005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/2TcfFGsQ4R1DLmm/N2OpA7UgJQahLP6y6vs99zf//K2xc14uiYGaEnWGnf4?=
 =?us-ascii?Q?9u1d9LVqknqO/Q/gWxHQtYPe8RK0aJsMQhC61xYg5xfSBxtOcr5dCuEryPPt?=
 =?us-ascii?Q?nqBNma1Gfc67kV/zWjqlxtH8FdaRcn7/TEVcS6kw/rVh9/FbxxIcjgtwZ8LV?=
 =?us-ascii?Q?iqIFekkdfE+V+aRpcEy40la8g09cEgzZaYSpO5IFcKvZEckncuf8tuiVvSDF?=
 =?us-ascii?Q?hVjIL1umlA4Ri6qGkvl7lNYL5iv3NynTEqEHQsC12vJVpmdhG1H6FmFYU8JQ?=
 =?us-ascii?Q?BqLPGDJyMs8M+1Dawt8wCjTBsCuCZYdb9cOdLh8tgQ+sLiueGVAB68KwvCiR?=
 =?us-ascii?Q?djOgPFVfozZ9d2HSxkX6GZ8pVh1GxUh+r2OHQPXdLX2hjmoU8e6gIN7W4PCM?=
 =?us-ascii?Q?WinVPoDPtjVriWL5xFQGXK8YubtCXCWltyaCH3Hkqpzclcai8P7AJAY+V+oe?=
 =?us-ascii?Q?qUNy2oxZ6mn5G0CNZaiztbn5O5Z5hL0jCBpTV2lSvbCsqs4LSQgh9VrR6nAR?=
 =?us-ascii?Q?jf6GHi+YYzzz0fUeuEgNFdOtsZBnMk/6QcFzOEF/n9UvoZrE2b4gldzXgBrS?=
 =?us-ascii?Q?tA/vyKzein2MNTCbZ1lnYqogT+VWYNTTm959dPVtmzK2N3ZnZD8BejdfP4cO?=
 =?us-ascii?Q?PYSHR/EwLXHAw4IsS/Jex0iPjCC3C5DodD+ARsvC1i8J6pDvFOCUxj1fCSWy?=
 =?us-ascii?Q?d5ifEb0z9omL2pQarjfevS/Ut7+9vZrTBXTlabT+oM6PkSpAModGoWsAXLbx?=
 =?us-ascii?Q?takGf7U4Z7Z3eublOX8QFvFSTjOMsFttr5dmdZGkc1OChd+6U+7vRqXDEAcr?=
 =?us-ascii?Q?IPcyDl3u9ZIl3bu0nIXU8jbzN7ZPFMmxkRvBNdtvlsgFz7aL+6MeuEO88ANV?=
 =?us-ascii?Q?xLRmiQdpsKucItqpKXkRvqg5ZKiPF1lKtbSdQkSThmDHDrqMV3wmnN0bViIO?=
 =?us-ascii?Q?S6gcEIsFeTqajQGHviqHHq4Oba/wokBmfTMHLWGgNTP0SoZcAxdS9d5cX40X?=
 =?us-ascii?Q?q7VD7vObSuehSvT/Clbr2Uob5duCx73ihp8trMNtHNhxjH7voC19Ui0OvSDt?=
 =?us-ascii?Q?euVgPB7P3fzN3LSJaJkhWTyTzspwWfxq79uT3/fAccrf0u5z4tmRVuSWn6QR?=
 =?us-ascii?Q?nmjKYW+v6WgTrFoBIN4Om50nlcII/3UGTLWfWeMU40K6JfcZ631/wkpzOu3f?=
 =?us-ascii?Q?jFAt/f6+w7E1Z9HztDqWPyCOMdqWQaovOb3+XHBuoCidN+1bIpfv4wB0BswG?=
 =?us-ascii?Q?Ei+8NHm68qqKMZ/A7Je8SvTOk/WFb5REoy7M3jfQ6tgVMxBw+N5qwhEw5lCB?=
 =?us-ascii?Q?LfufVxm0CCLX8N1Q+yEh053LwxKNxD1H8XBLWddWaWWResDzVpj1oBqL0qYp?=
 =?us-ascii?Q?D5m4nhRf0Z2BHHhIsd/Ls0mhVEbHrdrjIeKhlt5L6vCWO70IAgmI5+dlYXWa?=
 =?us-ascii?Q?sLP43O5jevJLuGbsLscih5wHrZ4yAGKKwXVAwFpcFEzoit4crJxtWUTCvoq+?=
 =?us-ascii?Q?CZddGHICu3YTUv+QeC3HeUVsBNaIADAQ7C5vaFqfFK5vPY5vC1Zp/fJeBeFN?=
 =?us-ascii?Q?QCFr/HCB5ZpFSFoRa0OkyEhV5SYLLEOMVT4aD9aNmoPwtbAcSlMfWLaskxNT?=
 =?us-ascii?Q?yZZrB5Xjgays9DGh4oRRKY75zr9WoNrOMKYRwulY2HfNHmmeBq8TWOpw+nzQ?=
 =?us-ascii?Q?qFHqWDb7tQ+jZ1hD/8xprsQTwQfTw+rsXJtfkAZ3wAiVEzn3vYax8VWONDvJ?=
 =?us-ascii?Q?4lzKcMxK0Q=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2db673a3-114a-476d-a9de-08da1c703a08
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:35:56.5983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VHYdLb20yglIWhmAqZJ+l5oMpw6wCQJsX8tJxwATpr0ZEvTQyeWXCbE21fqPt6GQK6jLvCMW2FS0cNDjCFHp+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7449

On 12.04.2022 11:22, Roger Pau Monn=C3=A9 wrote:
> On Mon, Apr 11, 2022 at 11:37:28AM +0200, Jan Beulich wrote:
>> The field taking the value 7 (resulting in 18-bit DIDs when using the
>> calculation in cap_ndoms(), when the DID fields are only 16 bits wide)
>> is reserved. Instead of misbehaving in case we would encounter such an
>> IOMMU, refuse to use it.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

> I would maybe prefer to get more specific error message rather than
> "IOMMU: unsupported" and a dump of the iommu registers.

Perhaps, but this extends to other properties being checked as well then,
I would say, and hence may want to be the subject of yet another patch.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:40:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:40:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303607.517983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDwI-0006sX-U5; Tue, 12 Apr 2022 10:40:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303607.517983; Tue, 12 Apr 2022 10:40:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neDwI-0006sQ-Qi; Tue, 12 Apr 2022 10:40:02 +0000
Received: by outflank-mailman (input) for mailman id 303607;
 Tue, 12 Apr 2022 10:40:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neDwI-0006ht-An
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:40:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7b539a6-ba4c-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 12:40:01 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-6qmswOYgOYKdaqI5EdpbMg-1; Tue, 12 Apr 2022 12:39:58 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5183.eurprd04.prod.outlook.com (2603:10a6:803:5e::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Tue, 12 Apr
 2022 10:39:56 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 10:39:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7b539a6-ba4c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649760000;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1ge9fD1xAJATkerYkJ62MQJlk0FuheONF0CxDxSRIc0=;
	b=G62JZxdhgHWRRHOdfsOCCLrKrFxaYrD6e1ODejFtgk61cNN1fMv7jYEF/hLTxK7b5SWhr2
	FLFnyH444HKd91/ktDCJiSAU9Sjmo2wDmeRP8vdd6TNUxDBNNJK9T8dV85XmsF0nijT4bG
	7BghUv4H4Nt1602aUGopwijeZKwO8MU=
X-MC-Unique: 6qmswOYgOYKdaqI5EdpbMg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kl+Onlq5loTM8HP5P6wqX3MHTr+jDt6qssWCbtjQ+4NZeyXlFcMLAYDuoaAsUp7esXnTf4sFsExK7hhlOuMaPQVhgceQnlwgFPaRcdSh8uE4SPSb/TViQ4rAObfQ+o/OC4dhuT4d5bgjr2HxZCHF4SfNp0Rfg1NWfXhSdMCWhR+IENUYRtPO82RUy3sbw2GwPe6kifyeD45JsgM1NPEXKaUaGMIzUJIiLjzVd2MQKTKqPdmLeQiwnQGBPDliOH9H3jt0aR38sDUukt5BQm9LiV4hFoe1gKdbyVRmGWBkaiYnmZWJbInyTNw2HUQT+wBuYL8+5AZvuye7v9KBaQ0+Ww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+V0mm3AtA+oYQawZcP0/2IPXDmXLlxlbVEw+qDbVSrE=;
 b=EV/loya8QfAPPLH1mNjKp03lu60SfzxT1w0QM94OHbfL45iMr+zAq1C/k12Cv66DvhwIk3iU71xhY0qBtwd5f7CyKM+lU/oV/TxK6arkBXdyLP448kgs6c8abWlQ8MqXwONk19LStRWdU1xfG+w0B7DLtYzUvWCopWzcYwRPT0ZvJ+H6o3Qcr2y2nihJjDt/Y3pUalz/NQ5s3nNOBdDh6SVQXTr2FIm0Et+2Kb4rdp8DQ93qU+ksp0gVF+T9YoyDUa10uoye8QbhWInSZGXeunWgRU1kL1RSlOQnQjrZv0WLdJYwYeKsuS0HFe9qf/svAX6VqSXjr4+Zi6tKbz6tyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c5181a41-74bf-3895-e311-d7777bee5d2b@suse.com>
Date: Tue, 12 Apr 2022 12:39:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 6/8] IOMMU: log appropriate SBDF
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <e8780667-2307-fa7f-0768-753a83e00082@suse.com>
 <YlVO86RI3J9+qI+k@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlVO86RI3J9+qI+k@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0601CA0034.eurprd06.prod.outlook.com
 (2603:10a6:203:68::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2d1b0a0-85a6-4b93-2d33-08da1c70c94a
X-MS-TrafficTypeDiagnostic: VI1PR04MB5183:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB51833A7C46D2C5C9C4CA86BDB3ED9@VI1PR04MB5183.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HUWxL3XHOugZJlbyOSV/Jq72wqn3s3qoUvve1IIC71JjTzJk5prSCi2yzaNMknvDx17/Y2X+wTY9f3W2EUH2kH5yVwNuvZeXfJMwSLkA/AV9oZN9XUTrdaR9wq68UXz+d/LGX7mXz1eYDCgJpAmAGK0Z3LfLFk5p4B/n/mV1NbHms6ccOYbcs9nJ58UPMfhhNl0yoRqi4ci2k4JSqUbqBBxl8z9+0Wm+zctFyc+bD8apCUHB49B86bZYI88VYnw3ivFnvOm5h75BQezQtRb4N7D/gmj31BhsI3FupeNtjLaZ5hKsFwApQnR2XoYBqZ7/xlUlh6/pD42x9zyAUiqOpQjqkPT7pPNXBNu5u5J22hS2DB0qL4Yh1t70ZA0NVDcNN/7ERTOJRiwrKxy9BdlsHtx7Lfpt2g9e/zTMWUEflVvaqJJrx3APf5pUi9mWZTY5fa0paJNheqC4oQ7ssVyYlXubchVNPhw0ggqUy6XgxpU7+I7xIkfrhn/Y/j1b/3OVJz4af5SSFjC+cBlHJZfaVRBIwyVczHnnpasMA50FdtjuSh1l7F3XIIzL4aIVGlzT06Hgr2q1VRkYui+6GY1JK2gv3g/HQFIUzbSanm0uuTWjJVXkfPXg6/uwtmy3K7oWfxiSORjUiXLtlqsIXPAavuTi4BAHigVXIAs+eAp23PD7AZ2iVhcMKVqi27aX1HKK6J877zMYaWffiS5mfk1SH+SUvOP9a1LCVvwvQuvqHbRZ0ZHYsBc72kNLMs/KLpOt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(6506007)(2616005)(53546011)(86362001)(2906002)(6512007)(186003)(83380400001)(38100700002)(36756003)(54906003)(6916009)(8936002)(4326008)(316002)(8676002)(66946007)(508600001)(66476007)(66556008)(6486002)(31686004)(5660300002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mUBPOKqqDvK2ZUbNwsBFGeLtmLXZVDPQhwhmG2hprDh3CDdh4awouQZugQuN?=
 =?us-ascii?Q?uTKOceI+0KL+lHolEs3IToe44h6zwxgiQfoBGY2k6KLiFaYIgRtSPKFS7dB6?=
 =?us-ascii?Q?ZSi6uMNuPl/lTYtDGkK/JTYGuCBP/S2L3DtJhJ4BJfA2alqGheOmAZMKVUCB?=
 =?us-ascii?Q?xryRwMpF5u3wAw5otwU/pGOlUkyGQNHzDFca3w/YBeVsw06RjVz0PAyAZA3Z?=
 =?us-ascii?Q?P3DH/tA8XBtypljyS9QKAuM2E00v7Y1s31WcY/V5PG9T1hn+sX1NauIqUchs?=
 =?us-ascii?Q?5UVMLufHpRQxo2YF9l3e9087Hz6jF9/wAcn9xMbB4kKpnkCWzv56cwv3kcEP?=
 =?us-ascii?Q?X8FUWTyJOBaTcs0KQfAwEUobXmDdfHrSC5m54DlQmTZcQSNeR2ELX+ulA3QC?=
 =?us-ascii?Q?Ht5wPF0Fof7B/01/0Nfi7EiJ1bxsI74rGWdShx2wIKCCzhWPHdmDRq8fP9iN?=
 =?us-ascii?Q?6Ta9m0z24H+rkpC5MXslCXXux2z7qta6FxAZeUO5Hgx00Jyyo/gW7NcL1uRo?=
 =?us-ascii?Q?2+7e9N4C5IjXHW8JueEF6Dj90hZGLEtHr6uLvoN8KyDWlmzE1G0NwTL33wF7?=
 =?us-ascii?Q?xNLETkiRMZ4oBz2vOyI6qITwBHkfoBqldDTmIie0Jg9IPbLmBu8T305wpaMC?=
 =?us-ascii?Q?++scja6RPVSMJbOBqByyrVVKObmKuLA+BNtGhSCXRa5pKqUyJw8cZUBymMpU?=
 =?us-ascii?Q?YqQdx4RNggBHotfSuyZQ3BgGN1ycIp8sIt/ouscS4gUuf3+EE8/4ky+cNguR?=
 =?us-ascii?Q?pdV9Qmksg4QxgRRKqqZXEH3GMIVanHy2cvISErxndmMPO3iCNdIPUnEu23Nv?=
 =?us-ascii?Q?lxU5Dyb3j06Oj5sIphaRqE9gVvcd2aJhsKLvciTldRiZ6PnOPcK4dZM56JSq?=
 =?us-ascii?Q?hLq295//nCUgAEYXOa9t7HaYE6YCb2MGhqRdRDX86Y9NssG+eWJgF101eIdh?=
 =?us-ascii?Q?gf32jysPQfzACEkQ1VKTdEwUKw7O0MrOnZlKTeWEqV8kg+IsWkklSR+3lY3W?=
 =?us-ascii?Q?aJT3ed13+spF2NN4yn/k/aCDuJFN3OGNuspXijJQ23kIe854iimQwq4qxciS?=
 =?us-ascii?Q?yU26Fl4uzMWB8OIye+Y+AlWsjWmXm30o5pFMdiYQuidKbl7nL1rOHEwMw5g9?=
 =?us-ascii?Q?IWyy/joINQ2aXket+S88bzhfdDdnGJWsRetcInwJcDgqj3/DK7kiE/zoh/+w?=
 =?us-ascii?Q?iRRiRA51Tvf4xAssppvKByV4RoOUgAHFRRKZfF8O1VFfYiU9YPZb90QEEty8?=
 =?us-ascii?Q?/wkbvW1tEsrJYFyNxtm5Y+veJudsSdvhjx+qh5YDsI01r1tCa3HU0n6unlfO?=
 =?us-ascii?Q?buboOl6rZ6ft2jcyNdCmdufT1vpNNsBgwXOxnrUYTvi6k8W9kJ81/oZcw+Yq?=
 =?us-ascii?Q?MnP6DBGAyV8pK6QllB14+gr1+wuw3Vi+4JhCxVQVHlTpvrqT/bS/h00GsTeV?=
 =?us-ascii?Q?KIBOHBgM3fZb1Ecurgh3mj0Ip0MJEzeyt5hWEBtn812hQtd3BoN9afir8Ow2?=
 =?us-ascii?Q?bCfyjjH4qPhJR15a0g7nBFC3fapJCFlaDl7nRT+XN1czRcIgoJ9jqS8URk8V?=
 =?us-ascii?Q?LoJ9eX9yR+SRK5Q0bloqI87TnOUf0BBBAs8GpwNL4dkvmJTs1hhRm8TM+XB0?=
 =?us-ascii?Q?OIugkh6XCWNEhNxn6S+itaRWh3DUiOkjWC9Yz1wJun6FjDVvOwZrMNeE0fJn?=
 =?us-ascii?Q?1Mne8ZdAQsc4N49HWgGdcXrniaKTnxdjjhy6ehQynKeMNEgqnJqbTHl1amlv?=
 =?us-ascii?Q?tKIdypT0Gw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2d1b0a0-85a6-4b93-2d33-08da1c70c94a
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:39:56.6436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r7r0lU9iZcF5IFfs+JcN4p5RTrfDQxCQGMJ12/P5wl8UvoHzpCIHibW2yADXeYQ7B2dt4BycM5p5mt1q4vGM+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5183

On 12.04.2022 12:05, Roger Pau Monn=C3=A9 wrote:
> On Mon, Apr 11, 2022 at 11:38:28AM +0200, Jan Beulich wrote:
>> To handle phantom devices, several functions are passed separate "devfn"
>> arguments besides a PCI device. In such cases we want to log the phantom
>> device's coordinates instead of the main one's. (Note that not all of
>> the instances being changed are fallout from the referenced commit.)
>>
>> Fixes: 1ee1441835f4 ("print: introduce a format specifier for pci_sbdf_t=
")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

> I'm unsure it matters much to have the logs from failures to find an
> IOMMU using pdev->sbdf or devfn, as the parent device should have been
> added before attempting to add any phantom functions, and hence would
> have already failed to find an IOMMU.

That's the expectation, unless something unexpected is going on. Hence
better have precise information in the log.

>> --- a/xen/drivers/passthrough/amd/iommu_cmd.c
>> +++ b/xen/drivers/passthrough/amd/iommu_cmd.c
>> @@ -291,7 +291,8 @@ void amd_iommu_flush_iotlb(u8 devfn, con
>> =20
>>      if ( !iommu )
>>      {
>> -        AMD_IOMMU_WARN("can't find IOMMU for %pp\n", &pdev->sbdf);
>> +        AMD_IOMMU_WARN("can't find IOMMU for %pp\n",
>> +                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn));
>=20
> Hm, the call to find_iommu_for_device() is explicitly using
> pdev->devfn, so while the iommu of the phantom function is tied to
> it's parent, it's unclear to me that logging the SBDF of the phantom
> function will make this clearer for a user reading the logs.

The phantom function may not be possible to find an IOMMU for, so
using the base device for the lookup is unavoidable. For the message
here and ...

>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
>> @@ -461,7 +461,7 @@ static int cf_check reassign_device(
>>      if ( !iommu )
>>      {
>>          AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be assigned to=
 %pd\n",
>> -                       &pdev->sbdf, target);
>> +                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn), target)=
;
>=20
> IIRC we would first reassign the parent, and then the phantom
> functions, so we would always hit this error first with devfn =3D=3D
> pdev->sbdf.bdf.

... here what I said further up applies.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:50:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:50:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303611.517993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neE6M-0000QK-TJ; Tue, 12 Apr 2022 10:50:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303611.517993; Tue, 12 Apr 2022 10:50:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neE6M-0000QD-QD; Tue, 12 Apr 2022 10:50:26 +0000
Received: by outflank-mailman (input) for mailman id 303611;
 Tue, 12 Apr 2022 10:50:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neE6L-0000Q7-8W
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 10:50:25 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 599b0f90-ba4e-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 12:50:23 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 599b0f90-ba4e-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649760623;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=xkgtlKDUlbn6rIvY8DrdI2zgvRHYxje6xjIFZQM4Z2g=;
  b=gCQM9/qz+j+v+2PxMIxzEpVgAqVa8+5zqmUQ0lrACBkIIxaEfuBw6q2g
   qXTEQ5k4fvBU8Eifhy9FaFlBLaez0vNWUkqLj2poYRwM7r5jlCxwewXZP
   hUT75Mtyfx/fAxrOkUyE/07sgD3kR55t9utEF0mI6frdoTR3ulysP4DpR
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68068565
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gJvCOqLpnslod5gkFE+RG5UlxSXFcZb7ZxGr2PjKsXjdYENSg2EEx
 zBJXjqBaf/YazP1foh+PIW09xkPsZbWztNgQQdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tcy2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PV17p+iYyZ1Ap3jqNYGXzhbEx1RP5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glg3p4eQKiDD
 yYfQRZpUk/xTg9fAwoWFpxmvdq4r2v9fhQN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv
 G2u13/iHhgQOdibyDyE2nGhnOnCmWX8Qo16PKK83u5nhhuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8ywWUGGkCCCJAYdoOtckqSDhs3
 ViM9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewckdVAG8fPC/L0DoSL9VdpCE66Jod/MTGSYL
 y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxFAHpg
 ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4vWkWyKRBaJ9sldrVj
 Kn74105CHh7ZibCUEOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj6xwRd0wPFvY
 MrBLK5A6Er274w9k1JaoM9Hj9cWKt0WnzuPFfgXMTz6uVZhWJJlYehcawbfBgzIxKiFvB/U4
 75i2ziikH1ivBnFSnCPq+Y7dAlSRVBiXMyeg5EHJ4arf1s9cEl8WqC5/F/UU9E890ijvryTp
 S/Vt44x4AeXuEAr3i3WMiszN+61Bc8XQLBSFXVEAGtEEkMLOO6HxKwea4E2bf8g8ulixuRzV
 P4LZ4OLBfEnd9gN02V1gUXVxGC6SCmWuA==
IronPort-HdrOrdr: A9a23:OeyKsqD4jiviz0PlHeg1sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMkj+Ka+Adww4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJJGdZc8qPSMex7wqDL3QSuvyAfcZek600ykke+C3Fxy3pDsRKA1
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68068565"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DnZq6RXpt4Z2XQpFH9DPnuP5oNsRHFmY4Q5Yo9HrV0TedUzmjm/y41j757Mm1wxjeaYyGpYWtT0ipDoiscMTYWm3REWXeQEHg7w5W2taNEZjYavuAooNMjjhIGlAfDW+Pzq7UiFVOjCsc448e9tfpjc3vHdbTrDvt9nXouzrIakExU0fkt0eFojbyBIESgr6Lhh9QCcKTl6R9BFjs8tMUBjDP7ZfJMCRHYHoUAKIA47quDDwKqbPJn/DdKA4RU88KfWPA4tvqbZBISqZLhDqSfriO/wQ8/SEYL0MoGDIrwXfNrT/xNLmgqwTpNpFeoblr/Er7wi0+hQ63NdO19BTLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XZidaaqWsBZw+HSoEiwUZExyB7+RrDa+U4o0PoOfqZE=;
 b=gXPm63DDpWGk0tAhw42bX02OfUrXGs3t4CpqhHYoDMaqDQcoAmpAk5HKflVub9yj5/moB7ZQMdmRSCUBaaP2xJbvva7E8stlfY157HC6Lwy5H0AStbm5Xlg0Qzr+TzCXUhMeDk291Xu+Wi7ELzsWnZI5c08AdM48d2Ifv6gPDFvElZ9HwoV9EKAm276cLC53nViLBESNOKKiYq5Y6Cq2NF0CG5FS+YGh4QXwW+KV+5ZzjjWzMe4XvI8Z2Mc7YscD3P8H+L/+coiglGpX/SyVX5mfse+q6kYbhpndabYNHboUB7csh7Mq0IXHIOraXh/9/u5dTgzyLfNzLfvdlJxtYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XZidaaqWsBZw+HSoEiwUZExyB7+RrDa+U4o0PoOfqZE=;
 b=dB2DXy9p0+d27I2/kndcLg+/0tYrzpstX4N5cxTu5R5zRyn/Lf/E0UdxKk9OEfbVjInBtBKFXcMGyqSN8bCxIps3E7UB/mvaDGnnKd/bdLoOnKa03IzzcyxxAuoQsOrlhAQBIM0hz3iC4scK4iFEqLeqxpeUUCHA1a9JF7b4p6A=
Date: Tue, 12 Apr 2022 12:49:45 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 8/8] PCI: replace "secondary" flavors of
 PCI_{DEVFN,BDF,SBDF}()
Message-ID: <YlVZSR4zWGy9mLbY@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <75623ef8-5aa1-b864-7398-b7980accaf32@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <75623ef8-5aa1-b864-7398-b7980accaf32@suse.com>
X-ClientProxiedBy: LO2P265CA0410.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a0::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 07ca06f1-8a0c-4393-3a64-08da1c722aef
X-MS-TrafficTypeDiagnostic: MW4PR03MB6537:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <MW4PR03MB6537C4430A897F938795C2908FED9@MW4PR03MB6537.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ucTe6eBiw0+SPrwd8Agocf5MmC6UoY/c2hxdkarqvwh84Ubj+i2d3F14emgIZD+tBsv2ojuFIXQInRJU5ChB47W7E7/mzj6hYfcYlM4hTYbNweD6T/t0bNmdApqI+F8ep+/r+Sl7C6bL+VkECtD3tqG9mTjejJzbPkH5NdZBdUVdblGAaDUAgzfyPp01iaVck8gglfqEY/Y5S4qeNpICwGNNF35DfNBe08GM++RHeAZNXP9xMr4U9HRAS+26fWkX7gthrorfUJSj0dxX8A9DPJYxS/DnHJqfGLcZYpK8qezwEa0eNZdZqucc5W1BLq8MTkw5eJnybsHmzuy9SMjQo9qLVWNdc26bEbqzto1oXcd97t2/sdOowAK+oGgXjRAPnCMvFXxMQCWTw3KBA8XZI6da1qw4u6g93R3+o7qIlqrujaolDBwFTsgajd950m8hp4IXZgLxmzvcLMwz60zXFUvyPZVowV51s8gBH2Pu0vkrAV8HpsRXxLMZB69evFUS+ym3eX12c6jvRIkrhmz1TDuGEyHvry+snd8aNRbzSnf5WlIBKkL7zLOiPpzD6LC+K2ohzWJA+yrwtREXHPJtdDLQ7TR3mSiRnX4IxjyCG7MHxDh1/BhF5nm73ezw7IbqpOLU3TYaMYW0T5okd9q5lA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8936002)(85182001)(54906003)(2906002)(82960400001)(5660300002)(316002)(6512007)(66476007)(9686003)(6506007)(26005)(508600001)(86362001)(38100700002)(186003)(33716001)(6666004)(6916009)(66946007)(4326008)(8676002)(66556008)(4744005)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkN6OWNCdXk2RTdBdXhsRWt6eXBZUEZML0t5VW1JOEd5WnpDQ0JGdHRtblJx?=
 =?utf-8?B?ckZJL0FvMVBSRjZQajUrNFRqbEtINy8vVjM3bVBzN3pvK2NWMWtmNVBhOHVv?=
 =?utf-8?B?TlVuWDRhUXAvVlczRHUxQWVHLzAxRjdhNlBjdWgwZG1JZTUxTkxXSkR3Yi9S?=
 =?utf-8?B?S2trSEJybjdPb0JZb2c5QTQ0QUlzRFBUL3piSGdzS012VGZUZmVEQTNOTnpo?=
 =?utf-8?B?NWRCcWtxRnhNeUo4SmJBSlB5d2U1dXZTUXJvNXBRNWtGYkdCZmFvZEdYSkN6?=
 =?utf-8?B?MWlGVmY2WWtMVEZaTUk0NkhwTWVPOXJxOXVuUDNGZUhjVTkrVG1Ca3E4bTMr?=
 =?utf-8?B?VXl4cGhBSlA4YVBNU01VeWI3RktKV2JqYnd4ZFBuQktXbnlVcW0yVlhUU1BD?=
 =?utf-8?B?d0FNRkN3ajJFRjN1K1lhNGxQZTRVQTZ5bGVGM0FHWFpiTVZBaFUrMWFQUWVr?=
 =?utf-8?B?SklVMk9IU054RjExRytNc2drbHNXbHd5VTllTjBMT29DYng2THJLNHRPTnFP?=
 =?utf-8?B?SFlPdk0yL3c5UjNMUEgwTG9zd0tpMnUrUnZNd09RcUpKWkV4Zyt6QXJuaWxU?=
 =?utf-8?B?aldlbUtEdnFOQkFzQmhGMnkybTBjeU9RYmc0cTR6dlI2V1NlbEp3akpJUEUz?=
 =?utf-8?B?ekhReFdIK3ZDTnNoRm5qY0RiMDRocUlpM3FvQW85YXI1NDl3U0tVUkhzN0gy?=
 =?utf-8?B?RWhVdjlkbmlyTitRTFBzTEZEaGtJUS9yaDJ5SndmMjhEN25LK1BzUks1TGdn?=
 =?utf-8?B?cE8rb3krSEZma1FCc09zdFMzT0xuUC9CbVpuYmdXUTgyMjBibUo3cVhaYnJK?=
 =?utf-8?B?WXcrYWs4WHRaY3BxWEk2dFlpaXRaMGVnVWgwS2lmMXpmeXhRRWZFOEtuVEVt?=
 =?utf-8?B?TFN4ODdZQ2RhS2RWQlQzbXlLQTBkVnI0KzZjbkJGMldQREhQZ3BaVDZOdUt4?=
 =?utf-8?B?RU9IUmVaYmJuTG42RWJadnhCVFNZd0RmUERxeWNYVXI3dnFWd3VqWTBZK0FB?=
 =?utf-8?B?eFZ0WjZaazFCcXVPN3dwTjY4Wk9XelFISDV5NlV4T3EzdGdUSkQ5dnM2V3M2?=
 =?utf-8?B?OElBZEpDRFVYTmxtVEFsSk53SlZBdTRGb1NPWEJ2ZitBT1dZSkxOdzdOT0dV?=
 =?utf-8?B?blZMeXpvMmdjUWhUQ2YwUDVxbXoyNjE0dzByL0RFSHNrckV0UXBkM0VXa2Yw?=
 =?utf-8?B?R2VzR0ZoZERmV2d2eDNkS2d2MEYzUHpWUHZ1YUZNRkI4VlViVlpCMmx3K2ZT?=
 =?utf-8?B?UW81KzBFNzkzczFwSFhBeFRqZTE1Wjl6ZXM0UzVESXpBc3ZkQ1NUSHY1NWVS?=
 =?utf-8?B?aG13MHpoUDhtbGVjVnpwUzJ4NHJpRU12N2U1WmNPNHE1WXF2eU9wMXEwZEg1?=
 =?utf-8?B?dmpWbDZlblArWlgxbzdiTGpVVkRDN1d2dWQrUW9xeVIvUW1NaWtVSlhicU15?=
 =?utf-8?B?S3R0cGxyNkdLVWxrYkZ6Y0ZMZGhTODZtYnhycy9MZGNybG5RSnBiT0xNY0p6?=
 =?utf-8?B?TWxOVWJtR3NUZFJ5YkJpL0FDamRta3hnMVR4REFGMEd3TCtJa2Y2anA0OWlv?=
 =?utf-8?B?dkRPME5ZVFhEZG9vV3NTREFsMHhyM2JES1F4ME92RUxRRDI1SXZUMDAyUDNS?=
 =?utf-8?B?d3RmVkduelV4cmhyMnQyL2VNbjlKZklsS1NBZGVkZ2xEcHNwd2doTkw3M2Nt?=
 =?utf-8?B?eTUyUTl6a01iTE95bnhXRVJ4Y0NJelIvWEVGVnBwOVd6TUlBcWNNTHZqMGVC?=
 =?utf-8?B?aVhsZEZOWXFUNXgvNXdXVEpJRjVJVU5aNlkzSU1CY29hMk9hZ0Q2S0EvSnFT?=
 =?utf-8?B?NTZVOGpBTUhCd2pMbTBJWUsxR2UyWnFrNHBaU1Btb2FGczh2MTl2MktvWkxw?=
 =?utf-8?B?M1puS2Y1RWNVN3JFUVpvYWNTcEdUZU9JYy9xUFJhZkgvWmlBTm9kd240cVR4?=
 =?utf-8?B?ZEhkckh3TmFuNEZxdTVpZTh2UURNVkcxMEJrMDVpRHZUaVNxRkZCeUErRUhQ?=
 =?utf-8?B?TkhBVS90cG9RWlVsZWl5TTZaWUdnWHk3Z0F1WnRUcDlpZm9QbmJMOE1uQWhX?=
 =?utf-8?B?N3pTY3U4Ukgwa25nWTFDbGZML2xKNS9Ja3FSQThUVEVFNXNaQlRhbEV0anNU?=
 =?utf-8?B?RmtuaVYzU0Q2Z3F2b2lHR24rZWNNL0ZJL255SVFkQVVNLzVyV0dmblYvSWlJ?=
 =?utf-8?B?RGQ3N3prdjZWbjVlQ0EzQzVpQkUxSGdoSTdlNmdnYkhHN2wrdzl2YVI5UEd6?=
 =?utf-8?B?ME9NUzh0bk1oTEM2VEpJLzZwcTFaTExmdWdQS1NFT1FLUDJCaTlJSUNrZEl5?=
 =?utf-8?B?SUxDd1VmN1hyMC80MTBaTkxWSkRnWmM1TUFpNkVUQk41UXJXcGczUXhJdk5I?=
 =?utf-8?Q?EMQvyNvoJBVbu7JE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 07ca06f1-8a0c-4393-3a64-08da1c722aef
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 10:49:49.9297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0FKqzp8i5QlOEGohxI5wm5IjoM6sD3ssZlclXWAvJyXpGjcpdV04Az//IckolJYBBDQmC3BIg/8VEvnOEVwXNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6537
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:42:05AM +0200, Jan Beulich wrote:
> At their use sites the numeric suffixes are at least odd to read, first
> and foremost for PCI_DEVFN2() where the suffix doesn't even match the
> number of arguments. Make use of count_args() such that a single flavor
> each suffices (leaving aside helper macros, which aren't supposed to be
> used from the outside).
> 
> In parse_ppr_log_entry() take the opportunity and drop two local
> variables and convert an assignment to an initializer.
> 
> In VT-d code fold a number of bus+devfn comparison pairs into a single
> BDF comparison.
> 
> No change to generated code for the vast majority of the adjustments.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Nice.

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 10:54:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 10:54:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303617.518005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neEA9-00019f-Hd; Tue, 12 Apr 2022 10:54:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303617.518005; Tue, 12 Apr 2022 10:54:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neEA9-00019Y-EB; Tue, 12 Apr 2022 10:54:21 +0000
Received: by outflank-mailman (input) for mailman id 303617;
 Tue, 12 Apr 2022 10:54:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neEA7-00019O-GY; Tue, 12 Apr 2022 10:54:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neEA7-0007w8-Ee; Tue, 12 Apr 2022 10:54:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neEA7-000815-1u; Tue, 12 Apr 2022 10:54:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neEA7-0003Ps-1Q; Tue, 12 Apr 2022 10:54:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=j8oEJRWGNYcYYmeb1j3KPc397+PPstFu2hLkU7lQ+7g=; b=OipuwkNgP5lW+9LSIpl059nUvc
	2lFANzvpmqfAiejQw59FSQrC2YztYHW6ddwH3p4qx+JTomTlGLtXyg8NY3FSpQrK+oJd+ncTmYgBC
	9CICBCRVvBz0UIbZZbuk/v42v1/I0LnPG5WTqu08N9G3k4IEKuEcpBNz1BKojAtau+n4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169329-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169329: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=5576b17363e92ce07e9707478061d5ce38bf7d06
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 10:54:19 +0000

flight 169329 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169329/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 5576b17363e92ce07e9707478061d5ce38bf7d06
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  342 attempts
Testing same since   169324  2022-04-12 07:10:23 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4911 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 11:05:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 11:05:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303625.518016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neEL5-0002hI-KE; Tue, 12 Apr 2022 11:05:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303625.518016; Tue, 12 Apr 2022 11:05:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neEL5-0002hB-HA; Tue, 12 Apr 2022 11:05:39 +0000
Received: by outflank-mailman (input) for mailman id 303625;
 Tue, 12 Apr 2022 11:05:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neEL3-0002h5-Rn
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 11:05:37 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7964c44c-ba50-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 13:05:35 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7964c44c-ba50-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649761535;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fLeE0h/jlJ2RrWdRqIQ9awMFFc5vDJaEyk2zlWllMGQ=;
  b=Z0oPwOLxAAT79JkiybvlZ4jSuj8D1joO3OVzJeD9Fz3jctIFSFVfmLlO
   XvMVko9jtsP3a2LTvpycsYsUzSHI6B4+73NrNL3Qevpc5/WN8Ew6ogtiq
   o9EFsf6A0ZEabPTWslwWxomJN9Tk24hqBdk3t8XYSyNvJACA/F7uYF8rw
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68544982
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:33vJk6J882zBa439FE+R/ZUlxSXFcZb7ZxGr2PjKsXjdYENS0mEPm
 jcYXGmDMvnfMGemfIhxYInl9BgC6JLRy4dmTABlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tcy2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NNWmLy7dVwJBK/FwLQyTQkfT310E6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glg25wSTKaED
 yYfQSJjNwvYWjdCAWsKJ8olg8OpjFqvURQN/Tp5ooJoujOOnWSdyoPFM9fLe9rMWcRcmG6Zo
 H7L+yLyBRRyHMSW1D6t4n+qwOjVkkvTWogfCbm5/f5Cm0CIyyoYDxh+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxa5UgU0AoQKVbdgsUfUl/SSs13x6nU4oiBpbscLlMQKHhwQ1
 FbRz/z3FXsz7Le7RifInluLlg+aNS8QJG4EQCYLSwoZ/tXuyL0OYgLzosVLS/Ds0ICscd3k6
 3XT9XVl2e1P5SIe///jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5XGhAztJcvU/MBofAnrNOv3jxpiGGeB6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNYCr1Nf4nM9vsUZlCIU3c+TLNDK+8gj1mOMYZSeN61Hs2OR74M57FzSDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r
 ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/KrbYclU7Qjl4YxITqJt4E7FYc21uvr6g1
 lm2W1NCyUq5gnvCKA6QbWtkZq+pVpF6xU/X9wRwVbp08xDPubqS0Zo=
IronPort-HdrOrdr: A9a23:y5nLuqwqA9V/P4gdV0LHKrPxteskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4+G7j5vZZm3m/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X
 XM11WR3NTvj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8
 SkmWZrA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKffZptMZ8SF/0+kAgtNZz3O
 ZgxGSCradaChvGgWDU+8XIfwsCrDv7nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De
 hVCt3G7vo+SyLUU5nghBgu/DWQZAVxIv/fKXJy+PB9kgIm0EyR9nFohfD2xRw7hdcAo5ot3Z
 WyDk0nrsALciYsV9MPOA4we7rGNoXze2O/DIuzGyWvKEhVAQOEl3bIiI9FkN1CPqZ4i6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68544982"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mzzC0dVa0iiDyiZ2U0wz5T2mnA+BN51o/xIpZDmHaORUsOtoF9TRYbZl9T9O+DOPBsD/kMgJd4LZAA87yJhxwAtyUnexce6RIVrgBn3Yo3wpxD/B2gD0TVPuQQ89THUoPLVoUsmvdlX8/WH4DxpZHZlbLcEi9l5mmy2AwCH+lpdmHZx1mgSpeK6z1zPy0//nehicDPVI75qg0cK4NBc7az/itHfjQeXRAsuSFg0TspXPG4jk2ZeMHrNoawjDuYT0V4vC5nJesKK0pN4sRcSZtOnMbYa6tOm+CAxq+RdZHPYy8vUtv2RnDv9FtLngQNlZsPjt39d27nREZooUdGwCCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Idj5G4HzMqeRporWfc47xozFuzLW8B0S46K7qXnsnQE=;
 b=eOHAXz9U5XfcflGIEnD64Z36AssvuhsSINP2ytmA5PggRrsvK9QTeCbrVG/UBT2LS5NlXp5qzmzBtbIUKIMwJwUQf2UDPRXkE5tk/yUgNwHrp9Uz5KAgXW0rtITwr0pSF4dN8JZKEb788FQZW4cN4IaZc2V118Q+l0uX97gi+DljxkOLtZ+csm7Z2H+5EBOu+20KbMlCypBIzs61kLMjEPin4vmssW1iTf7TNiBMwimoPdo4N7eslnaFYXRJdzEeTa0Zclr2Q4gJyuCaqo0ULjM3Z7o+17j2eYCwODGv3lRH34E8SJX9vs/zeSmja5aBHLZRksmExRgZhdGEbEsz9A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Idj5G4HzMqeRporWfc47xozFuzLW8B0S46K7qXnsnQE=;
 b=N1ax8QSDx3hcTzncSv3PxUzW2uNtipxUSonn7yeqiWDHiQDh79jm797/uZ3EEdIDKkx8deBVBQyst582yyROVpDQ5TwTV1JgooAbH0dhnZh4Fgl87Olj6LM0pfNW27pVsEEXfF2BApcxqHVRVOXpN9CH2TVY4rAiDZj3faFsqIk=
Date: Tue, 12 Apr 2022 13:05:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Message-ID: <YlVc9shnBYKShLiP@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
X-ClientProxiedBy: LO4P265CA0088.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2bc::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0132d274-285c-43a0-87ae-08da1c745bb2
X-MS-TrafficTypeDiagnostic: BN9PR03MB5978:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <BN9PR03MB59783A550F59BB212B7A4E2A8FED9@BN9PR03MB5978.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: G+DGcLBOXmVl3cExmg5rRBawNlTNJ4XpRVdtGdua4nEuabjOSwG78clfVMb+YaTLoQY8lKHrJKbpzqeG3T2Uzs8CKDu+j2qBtxetPkXbD76H5zawBpzerxDSBHBSnOai6HK8VtUxtCBUqeZ8utfzAP4BeoZnWLsKXEm2Fy7flFgyFC2c0dQXbT1fpfA0RLdP+142chHp1hievZ7asLZihr9V53iWTYmsBU8Dv6ZEyd1/Y/eG3a5ZxNaLTwOB1WQiAOEqWcrLAtatjv8BEapQBLmnsUwZRo3VN8u2RW4PoC+HtvBzMKEYlIZf+W9WbI+Wl+RNPGCL9st5YobuZurtn9ASifrUHWOY9GjLLI9/elPwGkza45e3gkjIqVEFNGoWRj4kaT5zU5SV6HRWAkTXgy2zpuBNSHIFDfjYv2oZESP3/+cI1ZUm4xUNI/jMxv5jAczlAjp+/HGMySpw9Ihn3QWhfGqjtenP6Qh8YVKv2htu+NfJWaXbt+fiaI76uzgNKVlIcknmBdIaYYRbzd+83w5yuQLfMp9bhe6Tm/fGRTOuzZmi8LCzt71E5tVPm6bFnIMcwLiG1T5KtfhPS9IfuoSqILSCZMckgllfb3uexl5Gu/mfbgCbgXKSMZ0ILhmQEKfgwi67iy7Fb6C/ReJweA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(8936002)(85182001)(107886003)(6666004)(86362001)(6486002)(4326008)(66556008)(8676002)(33716001)(66476007)(5660300002)(66946007)(6512007)(316002)(82960400001)(54906003)(2906002)(6916009)(508600001)(186003)(38100700002)(26005)(9686003)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXE5eGM2NytkNFRUSnFLeHhKb0Z0RXFPdEN1cnd4WUhzRzdRQSt6L09kSjVL?=
 =?utf-8?B?RVo2QW1PYzdkQWFvWXArUks4SmRIdFI4bGNhSVkrU0Voc2ZodXJ3blNWR1hY?=
 =?utf-8?B?U25VS0ovOVFSMVg5bm81VG4xVkk2ZkRHYTc2QTNuMDZ5bS9oV3ExSjJFZkRI?=
 =?utf-8?B?eWRHWlhQdDhEN2Yyem9oSG5SQmVENDFGNWp6WjVTZ0diSlFKNVNmSUFzWVM0?=
 =?utf-8?B?R2lwdmIvVU1tZHZudnpxd3AyR3pDbndmdUwxcUlReXpHQ3hSSE1GN1JZVGFw?=
 =?utf-8?B?Y1ZvTTBRbk93OUlEQXlqcVFpNmNzL3YrNnlTWXZYRTZOWGZDZE1tSlIrZ3Bo?=
 =?utf-8?B?R29VRzJ6TkdJU1hhbDRHWitiKzdHbVhYTG9SV05LQlhoNW9VV3lPWFFld1Br?=
 =?utf-8?B?a1NzVkVsWEYxbHQvQzN3cFc2SkxKWi9sRkg0Qmd0a1pqZzN4ejNLZlA5RG5M?=
 =?utf-8?B?VTJxZGdzOGUvRnZGWThKM0ZLZDl4MFBNQWZUZ3lmQktNdGtIMzBTdFBHelRE?=
 =?utf-8?B?SjJZa0M0UnVQcU5GZDFHNncvZ1QrRllHZjBhTnlYdWM4ays5VENLYlc3MDhX?=
 =?utf-8?B?T1FMWGZoTkRBTkdhYXpQYUdITjRHWkdKSk5pN3Y5UUk5WCt6ZkFuVVkwcDJQ?=
 =?utf-8?B?WDBTaGpJeDJJQVJGaUtnQnpkaXpORnZRaEJUcmdFNXltSWl5N2VlM2UvZGZt?=
 =?utf-8?B?TktNVWp5MHNHaWg2UUdWRTl1cnI0cHYrcGlZL1QwV2pSVGdqQzFFZGJJZUFr?=
 =?utf-8?B?ZzgvbFovMy9EUlh5Z2NuZVZOZG81eEJoZWMrUFdQZFl6US9MbFlJdUdNZHp5?=
 =?utf-8?B?Q3R2bGpXdVhadDlmQ3h6dGx0SllFemlBWlNrd2JsVng3MloxVk9hSEpTZDQr?=
 =?utf-8?B?UWlTT0I1WkwyOTh2RDQ0VG1QQ05HNGJRaVQ0RnR4a3RQOTRPQTZuY2tCU1B3?=
 =?utf-8?B?bWI4OE5tYnZBTG1MYkVZblNobEROSDVIRXY5NHRlYS9MTzFrVDVWV0hnNlBh?=
 =?utf-8?B?V0FtMlUra2lCbzlEMHZ3bmVIN2dDRGdsU3l2RURxc1FUeHh5S0lZdlA3QzJ4?=
 =?utf-8?B?LzFsQ2tLc005alk5bkZ5N1o4OU5wY3d0OXl3c1dCWlplVytvdzdBQVJ6WXpr?=
 =?utf-8?B?TWZxeHhJVlpxMHYrVWtmQ3E3MEJJRXlVNUQ2UXhQelVOVVg4Q0tyNEVUK2NN?=
 =?utf-8?B?QkM0cEszRmNWMWlHR2kyblJFdHpCZ2JlZmF1TUlrempRUG9UU0ltZ0FCZitn?=
 =?utf-8?B?ZUFySk5SZFhZeGNvUDJPdDZQdDhjYlVHSmJLNGh1UlJ1azQ2THBsbTlHUCtB?=
 =?utf-8?B?ejJPRk14SWlCVHBVbkN2aVF0NGU3WUdDR0hFZnp2dXQ0eDY1cCsvUVVpWDBO?=
 =?utf-8?B?ZnI5NjM3YUZyWVBEVkd5dDdURFNvc3QvY2hmOWNvaGY1dGo5TkFXQVhDL2ox?=
 =?utf-8?B?aFNuVnlIWFpsKzFHc1BSRlp6ajdjMVdNbU5nZkt4T1ZjRU1OTzY4OWo4MGhn?=
 =?utf-8?B?MUI5V3h5TzFibHBBUUVaYmJDUm9PMm1HSnBLejFaUmxFNkYramsvY0xjNDRX?=
 =?utf-8?B?RmlWRHlrT0F0Q1R0dnV4ckxGNHRWREtPcnNkc0ZtTE9vYWNZWFJ3NjZGZkZa?=
 =?utf-8?B?Q1Y3dnU3Z3hvb0lhUW81ZXBYdXRwNVpRa1B5eFFJSFpRSmF2azFUZlZHZ3NU?=
 =?utf-8?B?UUM2d1JrSEVYMzhjTnlXZHloRVZGYzBKZUpnKzMrNTBSTmpOYVE2dG1mSWpU?=
 =?utf-8?B?bXBhUUFwQ2FlcjZtcHF5WENIRm5BQUVTenh5ek96KzZnbUVLdS9xcXh2Q1dm?=
 =?utf-8?B?RVVXTWZ6bWlvcVVwcTNBMWFXTUFQUVN3aXhQeHRSM051QUQyR3JGMzcyQkhZ?=
 =?utf-8?B?UFN4WjFnU2ZjZHoxZjRaNVFlT2twdlRoQTdCS3hWZGRxQ0JMbXJtVktSRkJM?=
 =?utf-8?B?TXE4cml4K09wRWkwNWx3RUdHRldkdDhhOWo3NUZnck5LdWljQTkyeTZIajVY?=
 =?utf-8?B?YnlBamhWYWZTMHc3OUFkYWl3a2g0NTNTT2h2ZTM4Ulhoa1ZQeGs5ZkJTNWMv?=
 =?utf-8?B?NmFvRVNyYzY2TjFhN0FWNnh3TzZ1SzNPVWp1NDlvRkhaRy8xblNpNU8wLzBG?=
 =?utf-8?B?RGd4ZWI1VnQwUGplOUVyN1IyWFhVeDFWSlZxM1hPUHpScWpucXBmREpvTlRs?=
 =?utf-8?B?Q1kwQkJPbUVpQVg5NU5KUTE5V01KajNOTTZPekl2UFZPZ2RQVFJnTE5KVmdE?=
 =?utf-8?B?OFZDZ1VVWDUzRUlBU3F2NWdaNXRVcTZLYkVlbEhxaTBuUndEbUp6aEovc2tF?=
 =?utf-8?B?T0FZQWlqSFBuVmFHSlgxVnkvZkZIYlE4UFZIbzdTT2hFQjAxd2JKRGhkQ05z?=
 =?utf-8?Q?T2m/ZK3CE1YCmrEU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0132d274-285c-43a0-87ae-08da1c745bb2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 11:05:30.7338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uHmaCylaiV1xx8bHpsFHWbB0hdztg5+pjexmyYFTUm1cLf72RUWeGFYBAUELJ0L3gha+unlHcxoBWkNIRIwfaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5978
X-OriginatorOrg: citrix.com

On Mon, Apr 11, 2022 at 11:35:54AM +0200, Jan Beulich wrote:
> Prior extension of these functions to enable per-device quarantine page
> tables already didn't add more locking there, but merely left in place
> what had been there before. But really locking is unnecessary here:
> We're running with pcidevs_lock held (i.e. multiple invocations of the
> same function [or their teardown equivalents] are impossible, and hence
> there are no "local" races), while all consuming of the data being
> populated here can't race anyway due to happening sequentially
> afterwards. See also the comment in struct arch_pci_dev.

I would explicitly say that none of the code in the locked region
touches any data in the domain_iommu struct, so taking the
mapping_lock is unneeded.

Long term we might wish to implemented a per-device lock that could be
used here, instead of relying on the pcidevs lock.

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 11:29:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 11:29:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303630.518026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neEiV-00057v-Ej; Tue, 12 Apr 2022 11:29:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303630.518026; Tue, 12 Apr 2022 11:29:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neEiV-00057o-Bc; Tue, 12 Apr 2022 11:29:51 +0000
Received: by outflank-mailman (input) for mailman id 303630;
 Tue, 12 Apr 2022 11:29:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neEiT-00057i-QX
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 11:29:49 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d870b517-ba53-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 13:29:43 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d870b517-ba53-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649762988;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=CBYkyJJKZNzuhVI4ZkpcSTFQKT18PoR44cU2WLcV6L4=;
  b=GDJYAuR0wuJScgOdkHmsQoS1m8OfIz+U+Bi7eOnC4G4YLA4byS1DpAXJ
   EyLa7UeB7gl0gYTHmsC4+oGQgCKmoRnKCyFtFln2DpityKmktGGr7ye8T
   D5HFydQkc0DBUhoEG+r1akF1l2sSdsbshuHk594z1pas/pEqRdLwnjK0h
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68663814
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3H+Fh69GJTgY//OrinYNDrUDn36TJUtcMsCJ2f8bNWPcYEJGY0x3m
 mobCjzSM/aNZWH1etl3PNy3/UwDu5Pdx9VqHVc6pSs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YHjW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYGIETkCDKTSorU6aihqCTNzFIwf/6CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4eQ6iFN
 5NFAdZpRCiQfi9VG3gTM7w3lsi0tyP4Vjh0i03A8MLb5ECMlVcsgdABKuH9eNaHWMFUlUawv
 X/d8iLyBRRyHN2AyxKV/3S0nOjNkCjnHoUIG9WQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI
 FBS/TAhxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9imQ8vLqyDSQGFJVaQdwWsY0ueYXHDs1g
 wrhc8zSORRjt7icSHS4/7iSrC+vNSV9EVLudRPoXiNevYC9/dhbYgbnC486TfXr1oGd9STYm
 WjikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsK4owGWxFADpU
 J04dy62tr5m4XalznHlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYKGCxM
 R+D4F4Lufe/2UdGi4ctPOpd7Oxwk8Dd+SnNDKiIPrKinLAsHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZPdQtaciVhXcmeRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9
 Wu6QUhW1Bz0gnivFOlAQio6AF8zdf6TdU4GABE=
IronPort-HdrOrdr: A9a23:1vDVyK1EvgtBaMvRS7pDDAqjBURyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJU80kqQFm7X5XI3SJzUO3VHHEGgM1/qF/9SNIVydygc/79
 YeT0EdMqyIMbESt6+Ti2PZYrUdKbG8gdyVbIzlvhBQpG9RGsRdB1ATMHfnLqQ6fngxObMJUL
 6nouZXrTupfnoaKuy9G3k+RuDG4/nGjojvbxIqDwMurFDmt0Lh1JfKVzyjmjsOWTJGxrkvtU
 DDjgzC/62m99W20AXV2WP/54lf3PHh1txALsqRjdV9EESkti+YIKBaH5GStjE8p++irH4sjd
 n3uh8le/9+7nvAF1vF1CfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqAw7I
 t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1UwKpsKuZOIMvG0vFoLA
 E3Z/uspcq+MGnqJEwxh1MfjOBFBR8Ib1e7qktrgL3m79EZpgE786Ii/r1vop4xzuNCd3B63Z
 W1Dk0RrsA3ciY3V9MIOA5Te7rBNoTyKSi8Q156Z26XVp06Bw==
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68663814"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vv9qcO76/FHdf94e82A65+nH/YecezlRZ9sMXOf2zn0XwJ3F0nE0lI2J7EYnI/P0mJfEG5vGYNX3je4411pK0clQ9ciBXS1qx+gr1n6r+0OE8Ja3Wraz9HZ4mHTShWatb+N/OYqaymiC4orqUqR4fCJqe1ivbsrBL63rTqP7oLPhMMxjd7ca5AJBk2i4lmot2lt6se5mKMIZ1hc7Z2wHEmrxBUoUZIbEc/Q6RoRQwUMS8D3LBFHRF4HLBftBl9YgBlaAPk+A2VKj8RUZpI9N/unTVrncMdoppPVtfNQD8oEW3PwclbQx2JvmwKfX61Jvy7GU3xcZ0vElJo2TGS7ykg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bngOjZX9TjFtUO1OIs/aDJJxn47SxW4y9qiyFqNZ0Hk=;
 b=biNDQ4vFQ5r3mH4LX0dNFhMYV1oNsliDP6cLrn7dDDoiqhhqWsCmEe7RCbxxXzVoIiNffWhIhbibDqmS+UwyuWbki0J3VJYvyZIF6bNVZU2fNXHIn4fNOnhA8IWjM+sO8EtJSvI3q5a7kYSNWcraQOwcxzSNPRx/F5S2ig8tehpwMjS+E8Y/19D6Tb63xc37EiI7vpLAuuhxaqNNQQG+o/MTLzRYtzGYvwIX5jMGdOZK0I4ZMUsUK9xNSQ2vIMW/z5E39pGzC5rdFcpma2w7/Q3qjo6ErJJFMzHvW0vgE5gWpLEYhbz+E3c0UbjP9dH68rKyio959zURKlEVWIDzqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bngOjZX9TjFtUO1OIs/aDJJxn47SxW4y9qiyFqNZ0Hk=;
 b=gbYATFRVCtCOAHr8ExDXwW9gAOMz4aCYgUcesWXCnrNPOeN8TVsnvXpEO1Q41kJZ0hdV6abPvzThHA0vk7/bhrEYKZ8txHB+e67KGkO24gTVEugNK+mtyo14QQCFAXgBKQFcdsc5GkIguyXyhQ9ZF7JzGnK2RgIkjePWRX2I2wE=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] osstest: install irqbalance
Date: Tue, 12 Apr 2022 13:28:59 +0200
Message-ID: <20220412112859.73330-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0480.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1bfe4824-f79b-43ff-f848-08da1c77aff5
X-MS-TrafficTypeDiagnostic: MWHPR03MB3038:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB30381C832304EB749F296D0D8FED9@MWHPR03MB3038.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GRTnEstcH7f9VMJbnkg0xxEXiBlCWfMEETdILvU/Q5cL5h9kBdUJQig4xP8qInGl8FLKIjL0mUrXu/ei/p6J4GydN0bzJ7tcjJWqNp6F9mRzQs55BTFXQuPIYe1+rSUD2/QG7H5NUBCywrHAUF0vtzoTMTpM6j/pkzaz6aGyxMX2wSFoA+eDeaECAmjYckIoOF1LXmog0Mlj03AJVD019sNQ2SHssBNKb45L4ABLyg3mdwvNfjN/9+iPeWiOO3Zdy32KmNM+Fut9Y6+L6gKnF+nIZKsdgNcaKUX9BCoGx0TeawMWUYh2HeDF2fzQza8VPv/i8kkEhEYtJdCEKX19zuWzjzpZg9KdWb0HUyz8OnypigcURuUxu0RUXa0bT+RvS+Uob1tgm70VjoSA4H3Tz95ROpgZaMWuOHKyyAOFryPramr8tE4e71zVcD8ftzBHVzRMK8ZD0FWTdoEnMmecvy9D8jdjCsFIbdgowbaKDebUIf6VYJg5oMV3rLpEgV8PZ/lZFMp7hcvl/tnutBaDAu/D6Niv1jskY0Yqe9DC8S9dD5Np/mDl0qU6BzNnxmolwFXI/6ji+II6z1ftQQB12SQRj67P8JWgQmIHPUC6TxrSB3pfbjq7dMuBgZHcDdCc4BV+LJNwgJU6zj5My011iA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(66556008)(66476007)(26005)(66946007)(6512007)(316002)(6506007)(54906003)(83380400001)(6486002)(508600001)(8676002)(186003)(6666004)(4326008)(86362001)(5660300002)(8936002)(82960400001)(1076003)(36756003)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bndvRnhJbUp4Mk4rMnA0Y3lYdnc5YS9FblEzOHRLNTZBZ0RtTFV6Vk5JRGZa?=
 =?utf-8?B?RWdhdFpCcmt6SjcyWEV2ODVlaUR6TGxDNU9KOVRxSnpZRnhaNG1rRy9rYW0v?=
 =?utf-8?B?emthc3BYZTFPUW1INHVINFNkbFVYUDY5ajFMSGtlSzJzcWo4REQvU1R0RmFN?=
 =?utf-8?B?Y3hjUnJJTDJEc1JiV1VvUmRkSENHTGxKcnVCUHpkUGFhd0FLYS9ualp1ODBU?=
 =?utf-8?B?L3BvWjBlVEdqSGVybUJpU0VJSDd1TDk3eU5SZzE3ai9hSFpDZURMTyt3WVN5?=
 =?utf-8?B?RndvdzFGNFA5cXQ5WWZqekkxQ1ZySVU1VlkvVFN0d1c2WVhhcDk2RFlpWHpY?=
 =?utf-8?B?K3RqZjAraFJaRnhHcDFRM1YyVllvc2dvYUlMVWtHNkdYbG50QUwvZ3g1aDhl?=
 =?utf-8?B?TXZ0aURDMEVBVXN6VG9XVG15bmpTQ3dMblhIZ2VnTnVmOFQ4Q1Vla3N1TlZL?=
 =?utf-8?B?dDZMUUprNkh2UWRDdXRZRWZXUjBqUWplTkhKVVN3RGc4UkJxVXFEVHM2NmFr?=
 =?utf-8?B?eFc1NHFkY0toZmdwdmZESWZsQ2RZcXQ0cW5kTE9DZjBNK2l6Y1YrMExHYjhI?=
 =?utf-8?B?bGxmVjRjV2hTNlRYNk83c3h5cUZkUkRta09GOFl4eENrUiszMDBGcFhuVFl4?=
 =?utf-8?B?REdBVUZSMVFxZW4zdlVwMlNIbGdaNWsxQ0dQSjlFYXRadnM3QUtTWDBaQjdU?=
 =?utf-8?B?M1Q2N2ZhRWdUdU5ndWRRdjJYZHcwSWhLTjBnWlhKdFU2eGNNM0NFSU1wVjhO?=
 =?utf-8?B?RmxianI4cGNBVC9zTlJaUVVEYzVSa3BhMVFmTithSTZnS1E0dTlhNVhxdktV?=
 =?utf-8?B?UnZ5cXdIaXRWd29kOER4RTRQenN5U1kzbVdydmlOVHEzdHNkRlVHdllVMGRl?=
 =?utf-8?B?Q2RGTm5MZ0Z2RTA1L00zY2VsdDlPTTdIUzRxU09BS21tbG14bmhWeHdjSTNE?=
 =?utf-8?B?dzJ6VENSRFUvaXNDa2FFdWtxUUwwbVhtQUhIOGJ1ajZJYm9Na2FYdjV0WmQr?=
 =?utf-8?B?QkdJMFZhcm1KcERra3ZpNEVRakxnY2lrQm5WdlZzdWhiTndTcm5NVFVaZjl3?=
 =?utf-8?B?WGlSR0VWNmJRQ2J2Tlp1b3VtUFpFbmt0ckZKaUx2Qnc5YXpJcFdLMWVZSTFl?=
 =?utf-8?B?YWhwWkpVYUhlRVN6OFhLclc0STJsTkQyb2FXVm5jNnhBS2ozWGYvQlJqTWxH?=
 =?utf-8?B?NG9OY0RIMGpadEdzWUpkTEkyTldKOGZNeWE3d29HR09KQU8wVDJ6RVlUMlRG?=
 =?utf-8?B?RUNYQ3I5dko4MCt4TGdYRHpzYURYNU1ZYzBmNmMzWm9wbWhGZDNzeTI2WS9k?=
 =?utf-8?B?OVVlVjJTangvU3Uzc1BaTXJjdlQzdUtZR2ladzNBaGRQNEE4Zy9vcGk1bUkz?=
 =?utf-8?B?S1dwSk96d0VvYU91c3BwV0paeVlZRjRzNVVrM3JIY09ITzBzcCt5UXhrc1Bm?=
 =?utf-8?B?cHNUdGNCMWpMTmJpMVRtS0lvZlJWYnQxdHY5U1E5SnVXVnFjM0RmMlRsSGxw?=
 =?utf-8?B?T3hOUTdNVUJHRE9hYWZNY2lmbXIrcTM1OVRLZW16MDdxNjl0VEdEbTFhU3FS?=
 =?utf-8?B?dk5TMDVvbUJaWFoyMVhmUm9LVjhobFdRN3dvZmNWbnRhVUlSakhtS1ptSmc5?=
 =?utf-8?B?Z3BCYldUaDV3N3NVamVBNlg4VTN2MysrT2h0Q2RYL3ZJa0dHVk5CdEV0bWpp?=
 =?utf-8?B?YWRVSXpPQllLQkRtNnIyTEY1WGc5bDh2M3ZKUnVUbVFwVnJROG5WWFB2R1BZ?=
 =?utf-8?B?dVlQK2FYTFVDVWgrTTlidHdSQXY4elB5OVV5WmZwZXRJUWI1TGV6ZHZweDdm?=
 =?utf-8?B?YkVpM1VFaVdGMXVCTzJwU3haNDkyY0JwdWcyeVRlT3ZHam45Y3BlbG5JVm1w?=
 =?utf-8?B?N3BrUFhWRjFuNXVFTXk1aFlpZVJJam1hdG5hVHZvS25lMHhsM1c4Q2VUVUV0?=
 =?utf-8?B?VFdQSFNHaFJXRW85a1JoZVRBVEZFcXJzbHVSY1F2dE5PT3FlSjFFVzBUQmJy?=
 =?utf-8?B?Y3A0T2hQY1REYnFkWDJIYWgySUlRM25wSW1qWkcyci9OTGRITzloRndHU1M2?=
 =?utf-8?B?U2IwMkVrWDdnNTVGdFNWSUJ2cnlGV0dLTSs0N1VXNHFUVFg3WTRsd3I0KzA0?=
 =?utf-8?B?V0luT0JtSkxuZm9DdG8rc2VrYnRRcmJRaTFFcU9HQzk0aFdzMFV3M2MyYWpX?=
 =?utf-8?B?eXBrTWl0VVh2Sk8xcW10Wi9sQTJOcVhSUlZxeXRzM3BLTHJsQ1dHd0RDUURK?=
 =?utf-8?B?S25hZWRTZXNYb2FsVFdYSXBCQUYydkh5MGV0ZzVRV2lmb1dJRjhYckdPQUVC?=
 =?utf-8?B?Z3ltYU0rNkFNcmFTVHAvYzNNbnNiQk5qcHdLRjkyTjFSRmRReStrcUVsZEF1?=
 =?utf-8?Q?iHipZRdREyls/Y50=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bfe4824-f79b-43ff-f848-08da1c77aff5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 11:29:21.0632
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aEeC0j59Hk17Ib3MM8sFMaRIEvV0bBHvSJfz2jnXHllunNGPbNqJxxpVckYF6GhebGLjaBn9CVq/aKzoLFwNew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3038
X-OriginatorOrg: citrix.com

Or else all interrupts will get bound to (v)CPU 0.

This doesn't cause issues on small boxes, but boxes with a non-trivial
amount of CPUs can struggle without interrupts being balanced across
available vCPUs, as the number of vCPUs offered to dom0 matches the
number of physical CPUs.

For example sabro boxes (Xeon Silver 4114 x 2 sockets) would sometimes
report timeouts which seem to be solved by using irqbalance in dom0.

irqbalance is also available on Arm, so install unconditionally.

Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 ts-host-install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-host-install b/ts-host-install
index 276c6af8..f79a1beb 100755
--- a/ts-host-install
+++ b/ts-host-install
@@ -139,7 +139,7 @@ END
 
     target_cmd_root($ho, "chmod 2775 /root");
 
-    target_install_packages($ho, qw(ed));
+    target_install_packages($ho, qw(ed irqbalance));
     if ($ho->{Arch} =~ m/^(?:i386|amd64)$/) {
 	# We don't necessarily know the CPU vendor, but the Debian
 	# packaged microcode doesn't mind us installing both.
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 12:17:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 12:17:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303638.518038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neFSV-0001tI-9H; Tue, 12 Apr 2022 12:17:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303638.518038; Tue, 12 Apr 2022 12:17:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neFSV-0001tB-66; Tue, 12 Apr 2022 12:17:23 +0000
Received: by outflank-mailman (input) for mailman id 303638;
 Tue, 12 Apr 2022 12:17:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neFSU-0001t5-04
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 12:17:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80297aad-ba5a-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 14:17:20 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2057.outbound.protection.outlook.com [104.47.8.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-5Hsgjue7MTqTeA65cjYT7A-1; Tue, 12 Apr 2022 14:17:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8453.eurprd04.prod.outlook.com (2603:10a6:20b:410::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Tue, 12 Apr
 2022 12:17:18 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 12:17:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80297aad-ba5a-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649765840;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=K7iSEzImljEO7PShfpS9/gmeYUd9c05wZhln2dpwd4Y=;
	b=IMVZ3a04QQG589dY10DGWjl4iiqkoSGt8XHNnyJWb6XW92aKGNL2BZO8SEuBl7VO4buFdI
	W/8fZOzkqIsS7tiPkbpd7QiaURXXIyyF6TqQusLfcQBwfhfHbX5EBd6MzdWuaVzj1R+Dtb
	n5zukuM0lSoKIf2DVbtDB2/6vX2MkNk=
X-MC-Unique: 5Hsgjue7MTqTeA65cjYT7A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k84pVLPmP1E1Is+tFPCtAdWH9m86B/RQToi+ZEIcuozsCQNhdan5ycNUcFRhBd9giO4vPn4yQZ0pDnOB+EZ3XD5n2sQcKdUDiEfY7+GoocHRgt+FP75LtDyPLXnrEGoFtpl7KTA5wqjpQ9xLRbYR1hPvNyz3jYHSM7/wvru5lg9rsTxPZ/WAA7pbhbQ8Jm3IEBmniD/8ySD00EouhAILDUxWYXPJlewLd4az2hlh7zHQHF3N66bS1WrWRpsjAF2QBLUoBhg06XBExkyRONkDzoZWmCrQTiXlV8VVYlrue6wGtRYE4Y8dmY0N91Yp2tUMsbbqdSPjZJE/HhYE4fy08g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I0bbBtWWSE9c+Jrhd3uPxpdOIXBy9jgJsEvB3lTQxl8=;
 b=Ez5psYSacCmjgrffmy6KDyi/ejbiitsppTvFFx3Mu+uS1J8sNR+OtpOqOcxb6hyZQ2yCYB/Sc0ONMeFYwWZxChgZd6e+SXxFxbepUekzWRLsxIFC7suizpKBq8mfqcB7jCB12j/ZpbOxRWNLQmyVxvE7nQ/dujTBvsAmKAg0fApPBZQs52TwEifekN2xte4C+uLeOmbMtwKbA9nt9AlBQikxcjS0eI91JQ/1Hj7vvTtzJc6wIjIRit65l/5ksaWhRVadwhDGELhqYErhVgNnfSb/q0dbvyGYBDiEvsXyAjGkhJfa+fVZ0Lw1FJvcJ0Vx14cbebfLDVNFKbdurwuT+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5c09c09c-01b5-c020-5a8e-c0453e3b8fbe@suse.com>
Date: Tue, 12 Apr 2022 14:17:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
 <YlVc9shnBYKShLiP@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlVc9shnBYKShLiP@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0029.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::42) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2ce873fd-1547-47d6-703c-08da1c7e6315
X-MS-TrafficTypeDiagnostic: AM9PR04MB8453:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8453C068C87B1A73B849AFB2B3ED9@AM9PR04MB8453.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bj2/WXVKi6tOpQ/bEuonkcYpidnXlZnmujzyTw4+GM4soGVLnU1r85zf2ODoMLWuypFsollbfT/o9iR49WlOz4QdnzHx0ydxbqWGlkEu8CDpoYhPKI62Tiv+zw/b8VtvL5Z5rrcYaIZZ8NLzaUPIE93beS7sFEwiDH66w3yyF26pXBTCzFRJmyxS2Uy99/CJBKRr8h1I27Zx0To39ZgCfWRYbshxy5S/migBNu35yq1ZF6Ngqz7RCUUoDdKP75wVlQjbebnF5ab4js6NasH0D4B4KEZ2zQ7+37121aqgJU33IMxsq31nlAVqt2XXD6eIHcG5vAjpQ2GLzhRldFJxTO1crKQCtjdj/R51P54+h8vfh7Uq6hBTKYVGQeMfaCsophg5ptFWrYzyWgUiEVSToV0yMfdOPVWePMUk9Lhs6VPxB6a8c+u/CefJVX0f9ezqe7CZdHcAfZD2F3xn2ygzolvpS30u8KoMZW6Wx9AYxDdFqAwOx3Ruxcnge/EkdgRlpf2fzeLGdTDwpGrcdcYHAWN1UYKPlZEGh+7NmN4BJ825l5M0zX9F3rlAPl37Rd+W5VcMaBOYYS1343q5lZxW4Je1O8SZFS+6Ke7mxvwuy9g5DlP2cYiTpBpB72szLZW5/BBdYz4UNYDYXy/KTqPZLrNg+ll0EZND5bDHABQUnl4fQJ3bXP3KIqb/8YsInz+P1GG9rmf8lzgzvgV8w0WFZy+W8B/ukNzrPg/YbQOqkD4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(54906003)(186003)(2616005)(86362001)(31696002)(26005)(8676002)(508600001)(316002)(6486002)(6506007)(6512007)(53546011)(38100700002)(83380400001)(8936002)(2906002)(31686004)(66556008)(36756003)(4326008)(5660300002)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?W2v75f5/0NZNSeZNX/wM/v9ShU0IUBBhex1Cs+8C02dXvdIeGenigPVVzQfK?=
 =?us-ascii?Q?LAdZO/IXXFo0cXRKDd5OcMqfZRps+XcamZgHaFaIyxgfZDzXTeDh2Fa3ErLC?=
 =?us-ascii?Q?p4V7YoBeXQ13/wE1f8SF6CuQaHU8zpX6HWG3jFEFdFlMD7DRkvIZJaN89qpq?=
 =?us-ascii?Q?1TIv9e8XSQBae9iJlVbpCyHzniAzDBaIVfWBKj0NwGZBYfu59gIjWEmIa0FA?=
 =?us-ascii?Q?YnUi8SNAYkb4dGLy6UtCxIXrhPHwl0XqccDgzWBPxJynTSvSIlb4OTJ+OfDD?=
 =?us-ascii?Q?hVn9+GQoDNF800MiNbOHgbg9UvdbP/hcXPrVF82XWto1kXNx2VI22kRilj/B?=
 =?us-ascii?Q?DGfUqwhUWNOgcXGGAQkkF/TfwBwFBS0UjVuQcY/qs2AX1/BwW254zJLEQrDq?=
 =?us-ascii?Q?VC7065haQOxbi2oTn6Tz5wHicSr0jKJmiS2JBX1tKodWAqHD1jzxj8xWW3GV?=
 =?us-ascii?Q?/GmK2GYSq4+xjSO9FBj7TsZnL8nqIitMNvhnMyRcsj1voaSntAIp8orQ0kAA?=
 =?us-ascii?Q?MkfoC5mEeNCBalGCwjSq7/YqEPScD6q4Nobn4QMb3AcBR05fzQ1f350XpDx0?=
 =?us-ascii?Q?nbBkZYtwuP3ktaRd2npVyOUGvg4NDre/IGP+JAusw4KI9nyOZhAZHBVR5hjb?=
 =?us-ascii?Q?7MifrAxZJmFrkAolMa5Hkol/Ftc4vKlNugYXecltNL5hBpjpmZovTzVLCmEb?=
 =?us-ascii?Q?FWyrQT83/Q5chiHHGvtjGDdZG78SdVmqNgpwV24Dw/SJZCVqXlgPMDb/IE4Y?=
 =?us-ascii?Q?0jVhlWgMAgr+BUUHGsM35JxSrMBGe7xEfsqNGMvJRnb/UCkTTxzVVlUhEmIE?=
 =?us-ascii?Q?nEm7OP4x0hRSCZXub3CUHdygb/EiFonA5vqDFNVrKYz6ro5m519gDX+k15/w?=
 =?us-ascii?Q?E2qj0mYDfkQjlC/r2y5hoXBbrYxn/8hRPNvZAOu3J61kUyXh/JhGUIBCufET?=
 =?us-ascii?Q?04dM+82ZHmY+suZtG5+0XdrH80R8FlwANNR9yX91P7KirE+6fYRATk1fhUZ/?=
 =?us-ascii?Q?TCoocpBHj8RKyiK9Cfw5RoQn90b1KC9a2RLjg419o237GRBel1boah1LYvGG?=
 =?us-ascii?Q?ZZjZfBpIB8/oCVrDxNmORa39YYSkYgCWDV8UlPe3Eda77IAbw6Aq17GbG5oy?=
 =?us-ascii?Q?DX3/D4oiJWmS8mY/KSIgbVMew2hcDZOZkPOqP+Acx4774aFiUIkW40bZO76A?=
 =?us-ascii?Q?RTrM4lb81MNK9DAu6GOw32ki4mGPOK1FTRjlLzVlsgmTVLoAVA7sdMkPJmF+?=
 =?us-ascii?Q?bTfuCB4gqEMZSHkeCWxLTCebcisOyZ64fFdTFc7HHUEaVHhQFlnqlkKxBInU?=
 =?us-ascii?Q?+nHHAuqi+Pp4OJEkvFzs7p9aDnxV0zxdiu1gfly9Ptx8hHWbKIyNGtwymST2?=
 =?us-ascii?Q?f1qSZkzJgGrmi1ZSSwK6hEm8U8Tgev5VDXfr/ef+hs+PHVaxAj0SfLuGCRZN?=
 =?us-ascii?Q?Fic4jH9dx6lXBfsvakf7DyTNhiIEaQAPpk8HkKZ7mgPywXjobjlw1CbUSblB?=
 =?us-ascii?Q?jyf4ogeBiMKHzhxWZTtVlwcqyvU5t3M2Mb1YgfV9Ym49IDBqzmXPAcPpmnqT?=
 =?us-ascii?Q?bDd8m5W7iceHxWrneWRQS+VV6Qcf2ocHQ3gjIioR3hixliMpx81VtiQlAdbB?=
 =?us-ascii?Q?oFsKXZGUXlAJdvK9RpvfRcvydL5Qur+NEpWDl3w0Omx9o3qEt+eq8ziINgIO?=
 =?us-ascii?Q?ZBd6JPaIKweQ3/lYU6ntkHjtNRYhLlQFZAIBs3xzQTsT7TRVohc4iwCSpsWV?=
 =?us-ascii?Q?+M9fKVI9Qg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ce873fd-1547-47d6-703c-08da1c7e6315
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 12:17:18.1246
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 82ZC7qAOgzg8oMAKrXB3TrJGj/DAmI4k/1dYtMduzHpv90bs4lmLwyYvWAyriK5kIvjHc56CfH+6MNGp1RjFag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8453

On 12.04.2022 13:05, Roger Pau Monn=C3=A9 wrote:
> On Mon, Apr 11, 2022 at 11:35:54AM +0200, Jan Beulich wrote:
>> Prior extension of these functions to enable per-device quarantine page
>> tables already didn't add more locking there, but merely left in place
>> what had been there before. But really locking is unnecessary here:
>> We're running with pcidevs_lock held (i.e. multiple invocations of the
>> same function [or their teardown equivalents] are impossible, and hence
>> there are no "local" races), while all consuming of the data being
>> populated here can't race anyway due to happening sequentially
>> afterwards. See also the comment in struct arch_pci_dev.
>=20
> I would explicitly say that none of the code in the locked region
> touches any data in the domain_iommu struct, so taking the
> mapping_lock is unneeded.

But that would limit what the mapping_lock protects more than it actually
does: The entire page tables hanging off of the root table are also
protected by that lock. It's just that for a pdev, after having
installed identity mappings, the root doesn't hang off of hd. But in
principle - i.e. if the per-device mappings weren't static once created -
the lock would be the one to hold whenever any of these page tables was
modified.

> Long term we might wish to implemented a per-device lock that could be
> used here, instead of relying on the pcidevs lock.

Well, I would want to avoid this unless a need arises to not hold the
pcidevs lock here. Or, of course, if a need arose to dynamically alter
these page tables.

>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 12:34:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 12:34:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303644.518053 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neFiy-0004Iy-OU; Tue, 12 Apr 2022 12:34:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303644.518053; Tue, 12 Apr 2022 12:34:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neFiy-0004Ir-LR; Tue, 12 Apr 2022 12:34:24 +0000
Received: by outflank-mailman (input) for mailman id 303644;
 Tue, 12 Apr 2022 12:34:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neFix-0004Ih-H4; Tue, 12 Apr 2022 12:34:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neFix-0001Qy-FK; Tue, 12 Apr 2022 12:34:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neFiw-0005Un-W9; Tue, 12 Apr 2022 12:34:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neFiw-0003zR-Vf; Tue, 12 Apr 2022 12:34:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mOgbq82I81MDHOFFm+CWqzZSxK+0NPtal6Es9y4UIjg=; b=KYRuKOQMATpQE40nf62LjTS5NT
	JZZ2xWg86db2lFdLUAwPOSlscBcQwqw4Zg6z8ahO4kO838Hbtoo5WCZT9nS3TYbl7p0pqcADgCxuh
	sy2iF6n9Kid4HDx2mTU2ILgxEeV2tGEbEvPlCjdkrrptS8tRT5LNE8ziY6q5dL6VRlgE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169331-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169331: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=5576b17363e92ce07e9707478061d5ce38bf7d06
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 12:34:22 +0000

flight 169331 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169331/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 5576b17363e92ce07e9707478061d5ce38bf7d06
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  343 attempts
Testing same since   169324  2022-04-12 07:10:23 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4911 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 12:54:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 12:54:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303653.518063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neG2e-0006jO-GE; Tue, 12 Apr 2022 12:54:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303653.518063; Tue, 12 Apr 2022 12:54:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neG2e-0006jH-DE; Tue, 12 Apr 2022 12:54:44 +0000
Received: by outflank-mailman (input) for mailman id 303653;
 Tue, 12 Apr 2022 12:54:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=to5A=UW=citrix.com=prvs=094341a74=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neG2c-0006j5-Kt
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 12:54:42 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b69fee4b-ba5f-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 14:54:40 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b69fee4b-ba5f-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649768080;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=tNxdZv/RzBK/Jxwr5m15VHsp0Bxq8FqxjkZQi4iKLi8=;
  b=aojLXRIbkcaW+NcnfzqV8f1JdlnUFLUFGxdWj18ytQ5QY/t+mp95lt9o
   GqO6sbz/RuDx7vTDXqP9Y3fkCJ23agyb92lAYoWIwYgFP4QrlOXrUwmFo
   JeH/XWl/Be7JjeBavsx9ukB+sEvhutgnnWEdHX+diH5fuVNGbh0Sea4eO
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68079374
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:V5H0nq+IJRW0Cq+RalWXDrUDrH6TJUtcMsCJ2f8bNWPcYEJGY0x3z
 WQYDTyBP/rcMWr0KIp0YY7j9UhSvpSDnd8wQFBuq3o8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YHjW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZibE0AoEobUodZeEBBWDjhHMKwdopaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4eRamPP
 JVFAdZpRE7dbhlPKGcSM50nocDwuHffWWIHpHvA8MLb5ECMlVcsgdABKuH9edGURMMTgkeRo
 ErH+Xj0BlcRM9n34SKM73aEluLJ2yThV+o6Fre16/pri1273XEIBVsdUl7Tiem0jAuyVsxSL
 2QQ+zEytu4i+UqzVN7/Uhak5nmesXYht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIOsORsAj0G/
 UewrZCqDDJyqYSYSCnH3+LBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq
 9yehG1n3uhI05ZXv0mu1Qqf6w9AsKQlWeLcCu//emu+pj10a4e+D2BDwQiKtK0QRGp1o7Tog
 ZTlpyR8xL1WZX1uvHbUKAnoIF1Pz6zbWNE7qQQyd6TNDxz3pxaekXl4uVmS3ntBPMceYiPOa
 0TOow5X75I7FCL0Mf4oO9PhW513l/WI+THZuhb8NIUmjn9ZLlHvwc2TTRTIgzCFfLYEzMnTx
 qt3ge7zVC1HWMyLPRK9RvsH0K9D+8zN7Ti7eHwP9Dz+ieD2TCfMEd8taQLSBshkvPLsiFiEq
 L53aprVoyizpcWjO0E7B6ZIdgtURZX6bLirw/FqmhmrflI9SD58UaeIqV7jEqQ895loei7z1
 ijVcmdTyUblhG2BLgOPa3t5b6joU4o5pnU+VRHA937zs5T/Se5DNJsiSqY=
IronPort-HdrOrdr: A9a23:x6R/Lqt5UlF8hBadjyMfqqI47skC7YMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1FdQq4Lbw5ebbSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562
 DKnyHw+63m6piAu1Ph/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9
 vnpQsmIq1Imj7sV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8fz4+A9opv/MRTjLpr24b+P1s2q
 NC2GyU87BNCwnboSj779/UEzl3i0uduxMZ4K8upk0adbFbRK5arIQZ8k8QOowHBjjG5IcuF/
 QrJN3A5cxRbUiRYxnizydSKeSXLzcO9yq9Mwo/UpT/6UkSoJk59TpW+CUnpAZByHpnIKM0o9
 gtMcxT5cdzp4EtHOVA7dw6MLmK41z2MGHx2V2pUCHa/YE8SjrwQs3Mkf4IDN/DQu1+8HJ1ou
 WGbG9l
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="68079374"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AZVezfxhlRRiVo8t4cIP9uYMmFpaaMZ7VvxRQQVqstZHodNjmJcxc70axbDVfpb7UX3m9hW3tdRRNT++jpCE5r7BAwZzu6erDxH2NoN3u1M9PmHSHTIrGNXc5d2aoC3xYYKavbU/8bDFWYHHPWbA3wqn6384zIs3HuxghFP4BPsp1pV+ig1zM1xLvtYw7GEWqagmAv1dTj0z4yDpiJ3XGi6cD5wiutlnkWm2KORaFOEMZDvcR+KNm6mCIDvPk+iG6VkPBvOUL3JHcBfc1F4OQ/cC7Mmg34Kc/gKhPLvW2alwyTs6sEW6xR4fXF6tJzm6b4SKTv1CA9pUnEgxoY6lhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iaQhTp+sXFwpQEa/WVO2RYvzfHchL021zmBFtm3MSAU=;
 b=drJ8JB2O+z+xj5Usv6x9RRjn83uFlUF2i/g0U04ObmZ3ecuRWEfPqP21lSd5pnwoIYQ/YhLTDCUPuLNqKmriShEKO5uSnKAjhsbhXC53mjZ6wX9/4TQ3zziCcU1buJjYtsMkYv5/a/ZnJ49GLzZJM6O1+lqusGhji8sliijtfkJB3NX6FCCM1F33jVvepsOZJ3q8vjLzqlMXA1do14mcGHkQ7NOwtxzjqKKwaqJhzUV70BE2aphAelTjl/V8+Sar01x9dnekdgYZOr9jgYL/2vwWqdetG1CiFz6PAeGTq17JQF3zfZW0yUKMTqK34+TfACV2YcdVYOmw03y7C9V2/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iaQhTp+sXFwpQEa/WVO2RYvzfHchL021zmBFtm3MSAU=;
 b=lLp+AykT0ikwWEOsUOB5oK6ajV8DMloZteXvliwFnQ7aFC3sNBWka+c91D10JeVjcr4+yJEezq6Vh4KHFAP4LoL5je6ZfKoVi5nBctC8Q9x7ZtJqN6zDOJeu3zoO6pggokDQ4/njJ1b3vc62sXXIo7dDWbm2bXUgA8o/ImN5LAs=
Date: Tue, 12 Apr 2022 14:54:22 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Kevin
 Tian" <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Message-ID: <YlV2fseUZ6ss6bcS@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
 <YlVc9shnBYKShLiP@Air-de-Roger>
 <5c09c09c-01b5-c020-5a8e-c0453e3b8fbe@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5c09c09c-01b5-c020-5a8e-c0453e3b8fbe@suse.com>
X-ClientProxiedBy: LO2P265CA0214.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9e::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 358bffa8-e93b-418a-d92d-08da1c83940f
X-MS-TrafficTypeDiagnostic: SA1PR03MB6625:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <SA1PR03MB6625C1A043043D8A889F02458FED9@SA1PR03MB6625.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ntiVdJ7JhkDTWyY2kljjgi4MhisQhfWwayc0ubFiKb1l4QL+0Yxp87vSUX0MQ/V1VfnxaAstCOYTCGT0P5Qvpc5U2My9kStFGF2RmO+69e66Zsl7jhOcacee0k7CHqKBhDtrg+COmq0NhqWLCKY1hN+jq+r6wyeKA8EPx7P0cHnDv2SKZefBvSX5YHyiGSWajuxvepuZjthKbtywcHqB+4/olXM7KFSpZss2Sgni8NqGH9xtZuhxJNcx4bbWzerLJkqWlzJzStJ03YNqUM13fFqcUCZzOCnjqBZDlybw5/Z9ETRVvmvfXX+Aymad9NUgOUVQB6gdaq5W/Su5U3Rr8rbe9ejFtGOCjt9rZcxcnM0WQiQ/D9MsaEhM2f2+tTsG7YhrwMd1oqD39P/sZATz7qbSM7FjUTthKo33Seq6YJhbkefCiFEm+UHK+rybL63L0LqKRdo7UlHiRxsZZiQtNdFNMTXiQgXTfQQ0XK8JKgAwWaREC6KKq9L+63gj19tUfPYgMkwVZ9s3+TTzx2S6/wKupTUnMJV0wejBYqIA4q4FEtt7uUlPGVmrRY6WxzakUTP1zYqecZ/SC9IWLg8IG8SB3HvC6qhGf9LvMgPLs+9az/eEEdtTsTa263ZDDTRzAtkfpJqL6ok0Glhu/HXb/g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(86362001)(316002)(53546011)(9686003)(66946007)(6512007)(8676002)(4326008)(26005)(186003)(66476007)(66556008)(107886003)(508600001)(6486002)(33716001)(6666004)(54906003)(6916009)(83380400001)(6506007)(38100700002)(8936002)(5660300002)(82960400001)(2906002)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amRnbWJQUW9yNGJiWFN3c2twcHhkYVB2YjJWTnVHOEVjUzI4R2xHN0xJcnpx?=
 =?utf-8?B?SDJIK3phYjdLcWp6L2N3bkxaWS9RYUhqQW96Um4xdDdrZDVGUVNCUDBnMWcr?=
 =?utf-8?B?SjRZeU9NdWNwaHN1c010MnNqaUVxSEZUSDNFaHF2bUt6czhMcGR5RU1qLzZP?=
 =?utf-8?B?RmNqc0Zjc3JjcHdlU2kwd2hJTE5VdXFqb2hJeklnNHp6ZHl1SFYwTlhZSFBv?=
 =?utf-8?B?NUdGREVKK0VBaXJvZklxR2Q5K0lybEpOUXQ0OXhaMzRpZGJtaWU4Tk8zejFa?=
 =?utf-8?B?ODkzYXlpRjEzOFVHTTkrOUdzSW9lcGJqNzZ0MnRVM1VkNUdDREdIR0NDa2NG?=
 =?utf-8?B?SkZ3QU91MW1OVkgzaHhGclBYVGxJZUZPWjdRaEprekQ5VUU2S1E5aGdDUzZU?=
 =?utf-8?B?cVRwWTluYVZtcC85T0RYNSt5STNQZUpGWjVQMThlb29IVVF0N3IzRWNjZmVw?=
 =?utf-8?B?NUp0Qk94UEF6SXJXb2swYVNPQ3JxcTAxSCtRYTZQbUZTQXE1TDVFYWQrbmZR?=
 =?utf-8?B?T09mOExkWFM1emttSlpEMkhRREppODFWMFVVbTFYVXRyK08wUFVUL1BKUWNW?=
 =?utf-8?B?NVMxaUhDTjFIaEdvNE5TdTY0dHNlOFphQU1GNnJzVkFYSjVKTE1KS2s0OHJL?=
 =?utf-8?B?WFhkM0NkTGRVQ3ZCSXA1Qk1pbFZHOWZRYlZKKzVOVTJweVdnWG55UkRvaEpy?=
 =?utf-8?B?ZmM1LzRCOERPVUowbGhxSnRjYWxaT05nLzVlb2dDUllISGhXVXJjb2FQd0dP?=
 =?utf-8?B?T0VLT1ZBM1p4d1JCbTdpWDk0VTladS9vSStRVFk0UmhPZWFvWWVXRE9kVVVn?=
 =?utf-8?B?RktMSFJPWHBvYWZPRkRFb1d1WWhjVGZ3bTI1UUxWbk9hb3paTzgxWVlaSHVt?=
 =?utf-8?B?OXpOb3c5QWRWckxpaU5mKzFiT3lRZUVHV3VGRXc4M0U0MVRTTXA0a1VoUGlE?=
 =?utf-8?B?bUIxSGVYRkZuSk4zMmk2VVNxUlUzRzJhNzV2RU1CVW1pc21QRzE3NjFnTUNo?=
 =?utf-8?B?SGRaaGUwVmw4WWhtWEM2cDdrQmhYeEVYWUxhdmd3MmNNUHlPc1Q3b1A4SERo?=
 =?utf-8?B?ZTgvbkpSZEVWM2JKazA2bnBDYVZpS0dkTnVTYmtnS1ZnUGx6K0o3SGxDaDlw?=
 =?utf-8?B?YVRVZzdJMWFWVEU3MVNvUXhiY2RJNFR1bzFHU1FkMDZYRE5TendiQnQxaTJm?=
 =?utf-8?B?Ui9QYVRqT2MzdWp5WHh3L2NxWVNqenBZaDhGWVUzUkZEWTVPVFIrRjZvb1R6?=
 =?utf-8?B?clpqcHQ4ZVJrT1NMaU43QkxhQnhaNVowM1dzR1VJeDhCdk4zblpYRG9iTE5T?=
 =?utf-8?B?ZXVaQVNOTHRzQzFRb3hzckpTV2wxdG0rNmV2aGdXUkNTU2NzZVF6VmtzL2hm?=
 =?utf-8?B?MUpHeWFiODNKMnJsREs3Q1N4OElyTUdzUjg5UHNmV1RtbFpOeXppcjhSVFRv?=
 =?utf-8?B?Q1NFeFRRVEZBdC9vUmNpVWk3cUljVjdXQ25nbEMxb2xLT2g4VU5VaHpsWVRV?=
 =?utf-8?B?WU11WTN3MXpIM0E0RGtjNy9BdmZpYXNtcXQzN1daUUkvWm94d3NUVnJ2UjIr?=
 =?utf-8?B?UTg4QTd3eVA5K21MeEZnUWxJYWJxYTZ6Y0U3VmxiM1ZhQWNkWVYrVW0wV2hY?=
 =?utf-8?B?Z2prdTd0dmNSMHdLTHNxdElwaGxNVk5qM1hlRG9QVS9QcTh1T1N1SkZlWHdj?=
 =?utf-8?B?OCtSSUU2Q1k0bU5TdjFkWXdpaGRlRXBDb3JhT1poZVRRR1ZzRGlBcnhMWmph?=
 =?utf-8?B?OXNzcUMxZ3BpQURpOStWQXJBYk9kb3ZsZ0lFUlBzZVdDSmVDWkcwNlZlRVRC?=
 =?utf-8?B?Mms0Y1JCK2g3dXdaVHlFcXhwSzFERVkzZXlmaXZ2bGZVNjcwMCtCSXpwdEVU?=
 =?utf-8?B?OUFRNlBScXNCaUQxKzlOT25hZjl5bFFBUDRkd0xhREhRV3FGUnVYZGdTekhN?=
 =?utf-8?B?c3dHQ1pmZEQwZlFlZUZxTGk3YVFLUkNZekRPdVRKcWlXMGhsaGdBY3VLUm1U?=
 =?utf-8?B?WndSNlRGN2d2eVhPK1FHcW9HYjFqc2R3cXRyV01vbytveHhUQ0JTbm1oSkRQ?=
 =?utf-8?B?WEEzcU9EY0tIN3h3OEczVjJKTDV2VW9nNzVxZGVuNUVDVWY3TndsL3N0YmtB?=
 =?utf-8?B?aFZUTGxXQ1IreUxOVVduTnUrQm9xSjUyUDNZZjBnNVdYRFVyYXROQ3NUcTRv?=
 =?utf-8?B?VVNhTXZobHNlT091UmRydnVkSjdoYlZTdUJhTW1XTGdqRkVIaHdIaWZDOWZT?=
 =?utf-8?B?RFV2RTI2WWFLandmL25aNDRRdm8wOC84a2hIdzU2TXhNbVI5N3pKQ0Q2bVE3?=
 =?utf-8?B?QWdITGIzbmdrVWREa3BkR01obFZlYk9Rdk5CWmdsM3B6V2FaZ0dicEtxS2tw?=
 =?utf-8?Q?n9qw5TD7lcQMOhwY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 358bffa8-e93b-418a-d92d-08da1c83940f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 12:54:27.8112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aHDEj3lc8eRr2/uBA9YbVq9zBI0exB4MyNqPlq15z6gmZeiZrc4nUBrRinpsACtJ6bwRW/EZUoh/JCtYugkgsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6625
X-OriginatorOrg: citrix.com

On Tue, Apr 12, 2022 at 02:17:16PM +0200, Jan Beulich wrote:
> On 12.04.2022 13:05, Roger Pau Monné wrote:
> > On Mon, Apr 11, 2022 at 11:35:54AM +0200, Jan Beulich wrote:
> >> Prior extension of these functions to enable per-device quarantine page
> >> tables already didn't add more locking there, but merely left in place
> >> what had been there before. But really locking is unnecessary here:
> >> We're running with pcidevs_lock held (i.e. multiple invocations of the
> >> same function [or their teardown equivalents] are impossible, and hence
> >> there are no "local" races), while all consuming of the data being
> >> populated here can't race anyway due to happening sequentially
> >> afterwards. See also the comment in struct arch_pci_dev.
> > 
> > I would explicitly say that none of the code in the locked region
> > touches any data in the domain_iommu struct, so taking the
> > mapping_lock is unneeded.
> 
> But that would limit what the mapping_lock protects more than it actually
> does: The entire page tables hanging off of the root table are also
> protected by that lock.

Right, but at the point where fill_qpt() gets called
hd->arch.amd.root_table == NULL, and hence it seems completely
pointless to wrap this in a mapping_lock locked region.

> It's just that for a pdev, after having
> installed identity mappings, the root doesn't hang off of hd. But in
> principle - i.e. if the per-device mappings weren't static once created -
> the lock would be the one to hold whenever any of these page tables was
> modified.

The lock would need to be held if pages tables are modified while
being set in hd->arch.amd.root_table, or at least that's my
understanding.

This is a special case anyway, as the page tables are not per-domain
but per-device, but it seems clear to me that if the page tables are
not set in hd->arch.amd.root_table the lock in hd->arch.mapping_lock
is not supposed to be protecting them.

> > Long term we might wish to implemented a per-device lock that could be
> > used here, instead of relying on the pcidevs lock.
> 
> Well, I would want to avoid this unless a need arises to not hold the
> pcidevs lock here. Or, of course, if a need arose to dynamically alter
> these page tables.

I think it's likely we will need such lock for other purposes if we
ever manage to convert the pcidevs lock into a rwlock, so my comment
was not so much as it's required for the use case here, but a side
effect if we ever manage to change pcidevs lock.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 13:03:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 13:03:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303659.518075 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neGB4-0008KO-HQ; Tue, 12 Apr 2022 13:03:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303659.518075; Tue, 12 Apr 2022 13:03:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neGB4-0008KH-E8; Tue, 12 Apr 2022 13:03:26 +0000
Received: by outflank-mailman (input) for mailman id 303659;
 Tue, 12 Apr 2022 13:03:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=STjZ=UW=citrix.com=prvs=0948eeb7d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1neGB3-0008KB-4a
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 13:03:25 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee394c75-ba60-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 15:03:23 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee394c75-ba60-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649768603;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=ZdxWGk9LDezXWFQKKUr3RfB5DrzVD5Cn5rosDt6PUno=;
  b=giangBCgLwZJ93Rxav65DvCMnN8CzzcCbylCf59xDq2fzkirfe71DeYz
   vA3ddpqQ0CicY9GIJIwHl5b0RstQHP909WOR/X3c4y2AIITRXkgCzZ96+
   FFYKndX5pabZsNjU4zvkDdEiz7xuQ4DpqP7IXL56GWO4DNk+h/VkFu9jf
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 71077468
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pRTezaN1uc+OGs/vrR2vl8FynXyQoLVcMsEvi/4bfWQNrUp31TQFm
 DQdDWGCMq3eMGH1L41yOtngpkgEuJ6AzIA3Swto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl29Qw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z8
 8gKiKWreBkVN5LXqOQdbhlaHiRcFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gRRK6BO
 JZHOVKDajzmfAVjAF0SGasSxuv0vFvaXi9doW+s8P9fD2/7k1UqjemF3MDuUsSGWN9Pl0CEj
 mvD9nb+BFcRM9n34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/C8h1X7S99ZA
 0AV/CUxpKw2skmmCMT+NyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEA/U3l8UccXqvM/eica1
 l+0n9HkAB5G5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn
 mvU9HRWa6A715Zj6kmtwbzQb9tATLDtRxV92AjYV3nNAuhRNN/8PNzABbQ2AJ99wGelorup4
 SBsdyu2trlm4XSxeMqlGrtl8FaBvavtDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib
 Sf74F0NtcALbSv6NPItPupd7vjGK4C6SrwJsdiOMLJzjmVZLlfbrEmCm2bNt4wSrKTcuf5mY
 srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepVYTOmM7FihIvZ8Vq9z
 jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8riq85cHKbPZelMO9aNII6a5/I7NsrdNx8x9/tokN
 FnkMqOE4DITXUH6FDg=
IronPort-HdrOrdr: A9a23:bqOYkqtagIVe7T7VYmndbVvA7skDdNV00zEX/kB9WHVpmszxra
 GTddAgpHjJYVcqKRUdcL+7VJVoLUmyyXcx2/h2AV7AZniChILLFvAA0WKK+VSJcEeSygce79
 YDT0EXMqyIMbEQt6bHCWeDfeod/A==
X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; 
   d="scan'208";a="71077468"
Date: Tue, 12 Apr 2022 14:03:17 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: James Dingwall <james-xen@dingwall.me.uk>
CC: <xen-devel@lists.xenproject.org>, <pdurrant@amazon.com>
Subject: Re: [PATCH] fix invalid frontend path for set_mtu
Message-ID: <YlV4lXZHz52xPBzt@perard.uk.xensource.com>
References: <20220301093513.GA3187840@dingwall.me.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220301093513.GA3187840@dingwall.me.uk>

Hi James,

On Tue, Mar 01, 2022 at 09:35:13AM +0000, James Dingwall wrote:
> The set_mtu() function of xen-network-common.sh currently has this code:
> 
>         if [ ${type_if} = vif ]
>         then
>             local dev_=${dev#vif}
>             local domid=${dev_%.*}
>             local devid=${dev_#*.}
> 
>             local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid"
> 
>             xenstore_write "$FRONTEND_PATH/mtu" ${mtu}
>         fi
> 
> This works fine if the device has its default name but if the xen config
> defines the vifname parameter the FRONTEND_PATH is incorrectly constructed.
> Learn the frontend path by reading the appropriate value from the backend.

The patch looks fine, thanks. It is only missing a line
"Signed-off-by: your_name <your_email>" at the end of the description.
The meaning of this line is described in the file CONTRIBUTING, section
"Developer's Certificate of Origin".

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 13:12:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 13:12:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303664.518085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neGJq-0001PR-Cd; Tue, 12 Apr 2022 13:12:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303664.518085; Tue, 12 Apr 2022 13:12:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neGJq-0001PK-9n; Tue, 12 Apr 2022 13:12:30 +0000
Received: by outflank-mailman (input) for mailman id 303664;
 Tue, 12 Apr 2022 13:12:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neGJo-0001PE-Kd
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 13:12:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 334d2890-ba62-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 15:12:27 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-_HsYMhHlN0SMy2uKImnpxg-1; Tue, 12 Apr 2022 15:12:26 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4961.eurprd04.prod.outlook.com (2603:10a6:208:cf::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Tue, 12 Apr
 2022 13:12:24 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 13:12:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 334d2890-ba62-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649769147;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jKTdfBG7Fe/6AZ6CUAJbatAk7RiDaP8MjwpSBVzOHJo=;
	b=P+cjks2puymgSB45ykeuhuWuwXF7M1jujw9KXge3ATAAdu7KIi3t+PD5jBMsHiHv609xmr
	fBvtBI4h0VhssnBNkK8mYuYP7dud1JemqdzBk4CpVqVyZryxJ9kA808EpNTynTn03c7SWr
	jW3MksHU+bycmaxaMqYTjIu2h6j+f+g=
X-MC-Unique: _HsYMhHlN0SMy2uKImnpxg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eEURyzd1PJHOnz5n0K/4j+N2l2zPAJq8FtrWrMxMvHFvS4YVLjD9lwSrla99o8udWe0HfKpnPSNwNkly6zQgoW7z+f9QrBM2TQ9+hRYsN6Lj1H1i7lWv6X9biNMYe43rV9UbzWNSL7GcxwvvSbowN4VR8ynIa+y6iY0N3D9Q4KxoiPNuONctvXFg7aCJxNKI2yb30GBRbx2i19s9jG0vfMaeI3G9dsnsBNfS3ks4ZOUJFilAJmNpaa/ge3f5lyGjTYcuU99eUpx8dTN2vmIRFj57FK/hFw1Ddy0qv+/7FmYC0E4gRJgXEwcdl+9u8a/1gJGcftD7WdK3hPIAKLUBGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aCsHGJ7V8/qU6bvyFl869Gyb23Z8GCfuOIRJqhydqA8=;
 b=hPmXBUZ0cEodzftBQg2YtrehLU0tqkytV5C68BOZpP0eb9Jv9eBTu9UqjI1OohzSY1Xu+lBuBDItsJnD1aKkZA5LbV5cC764a6y6RD5utCPnW7M75OtS1zQoc7VqKGoighQBFX3N0WNy9xrk73Cs0mWC0Irjj8uYuZHkiB/2/PBjDZT3Qs3bQYHwDeezp/vRKOsfo6IT7gk/tyv4xuFFJKyfEXCNj4R9/5njuh4kaTYiWuy40phv5OEjr8EpTKnyuVChET+4i5hA3caz8JEwTD5AuHYsNrirCIa3C+1lx21HA8ilUWMhB5Wml0UjyX8XpKG1PoRE8Mo1kYShsLXehA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8d3d19e8-cdeb-fb7a-1d7c-d57e372bff9a@suse.com>
Date: Tue, 12 Apr 2022 15:12:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
 <YlVc9shnBYKShLiP@Air-de-Roger>
 <5c09c09c-01b5-c020-5a8e-c0453e3b8fbe@suse.com>
 <YlV2fseUZ6ss6bcS@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlV2fseUZ6ss6bcS@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR04CA0015.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99f3ccd3-554a-43c4-e015-08da1c861593
X-MS-TrafficTypeDiagnostic: AM0PR04MB4961:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4961A9957D63D9F5711CD9A9B3ED9@AM0PR04MB4961.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zumbwQ/PoKbTlYN5AjptvHRc8jGE2XEiV6lkgd6r4oL5fegNxp2+jdfgTGYH3c58E18RBtI8MBDhYxNXOvdFtiZajGBI+4R1TK9SYOpUXOEsZPdCKd8bv/+dteZvjPC0mt5gysV5FHBLoio8r57qBtTcCTcONjkQFRNkkJgIsMSxUKpzSC7L5j54h/yzekMmaP1cIcQyahziXm9b0mb4JAb/DO2VLubL1Wz/0YHoUIzv/jfoH+Zy1jchfmupYVunwuL/m2RT5CvY4M29yRMGW+RjSdf5a3saQ3shd8hEYIxgjcgciYd13ZIdPFnfnbR4wR9tqfgszfJ/IKqL0fgQzCgtLIbgjm6FEUSrSphsm6UcQB9U88fThvZST0EDVBpirRb93UoN6VST9BoX1TMhzFG38ICj03618rMRDRiI+gQckTUxl70YjET8PHbb8H83llsKFeIkJaTcNx0wsLGCUM3T9sQ/USpl92VoIP3rgl/mHdwDkVQhpPcwNt4+jfcyC04iWDkTGtTxKXvKN1FSQSvBETV6gFIZjX2DtJNVEWjJKsqgRSof/J3kwP6IkKA+ARo9u5L5AsAbwrSTZHS5lat8Ci8n4fK5djDiCu7DJfkSFIiT6+7v7kvuamIytyNsWFqtE9k8aAYSVuj8yHyHiHQGYb8iW6ECWoxaH/N/pzqDU8fXALN9Sd7WNIgQNqgD318zYHZeCDPPNCbhbiHXmXnruc5gUT5vzk3tlYjtR0r8Hpch+snklWbvCB37cII+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(53546011)(498600001)(186003)(26005)(38100700002)(2616005)(8936002)(31686004)(5660300002)(6486002)(36756003)(31696002)(6916009)(86362001)(54906003)(2906002)(66476007)(66556008)(66946007)(8676002)(4326008)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PojGgbtOmsYLqdJ1/e2KvwYw+I61A8CBnyndhipgX1qplHiGWCnXyAzpazni?=
 =?us-ascii?Q?yPniq6/pD/7wwNXSMd84pB2ezS27/f2f97eY5hoOi5KRssvXJ343PNYDnvCz?=
 =?us-ascii?Q?dzVR5W0jp0ZCX8fNirE3VYYIuZBmK1oxenM/tx+SEBeEScQuafNqigghlUG8?=
 =?us-ascii?Q?xer8STJDSDi9VZyrwmoxWJ98FiPwlJuc3Tb7FmBqeWuz3xb7V98xuE2rLhnY?=
 =?us-ascii?Q?+P0ARm/DfkSpIF6I/yFuhNMD1Uj/lU694uYZq1IPPv+j5Okfrb7b2AO+GGFy?=
 =?us-ascii?Q?93zet59Mja75lUA/5v+WL+DajaejTWYnGqS3O4zXtg45SePYqzIanGpEh2+j?=
 =?us-ascii?Q?QzdT44kMs8kUIRWTqXv9DwQGI4KSxIJSiQyIHH/NpCqCLJRAvftkxPl1UJ9k?=
 =?us-ascii?Q?RMlNEAlZnzgFWbnxFNmZ/ytAa0EiTlW7TGMHba7frPzbCofSJobhAX448dsO?=
 =?us-ascii?Q?QU33fQzLrpdVLrOpH/O5wtRCUGWPICFXgr7NXPTMflI/x8i+Olj9NCX7dUug?=
 =?us-ascii?Q?AM9yadvVUAernyizRDfCKcVnUHOeSyNMMuKlbjh6hfZv81xlG7gHXRnglM+M?=
 =?us-ascii?Q?/gERWyBXr7n6z4jnC//jiQhBP7Zbf1cLFHX+DkIA1/F+iVYgwMo7GP6J+3UJ?=
 =?us-ascii?Q?dwN0+G3McX9Z0iYYN2xWUkcJqJGfS1uzVBWiyfwFmnt2WvxLaf0ApHt5jCCP?=
 =?us-ascii?Q?GZZX2DdxslXQmrAJSCN7SUpZN8p+6QkBrGHxuyAyu5uCCQA54Cjw59GZaEXf?=
 =?us-ascii?Q?ql4KMknYbgQJe+86axJ/bwDGvuxKfLHLWibZ8DVgNHOpEtqVY6SU/R31nZkT?=
 =?us-ascii?Q?5hkwSkGIJq0YRJqPFES25J8qOFQPdNOkcuLL+po/PqRc+Lwn98Q6+qho0AGf?=
 =?us-ascii?Q?HC7QuYH/XvgFD72WuyjM5iBYsJ0XgvEr655FbpJY+Mg5pdS/Q6JCYBlYFo7X?=
 =?us-ascii?Q?WhKkY1khRTf/Sw6ZMW+D9A25z5SGhVqBM4ZtOLvF575djZueWXTtOjVsDvnr?=
 =?us-ascii?Q?IJbdihaUj2RSu/hJPciKkdpXzGsTZAQdaXomb+Y+j7kWbABUmDMlz3N/6DEf?=
 =?us-ascii?Q?7Wwa8/DbDCeh2LhIF1e+FTHdlLsG+WBSYTJi0ZHfagjxiwC3nzqB9Gm0nUhy?=
 =?us-ascii?Q?xlO8Njsh5oqdJ5rVFtVwiUaR0HNXlyMYmlQc9cocNXbvKZFVSrwKn/WaFpVq?=
 =?us-ascii?Q?xBGaOjCFLjxLNxett4pXyS19re1hGYgQ2LLk05oum3aMg8WrrzqXarDK6Ms/?=
 =?us-ascii?Q?4Jp8f4i3IG1M+6+R/XiSU2BEwt46bGx4QRkj6kwnc/hphx8JcHnXYlactYZx?=
 =?us-ascii?Q?Um3wm6rWM9ZIKQ4KE4jJ2yKkm6TrQA0zUYvL0765Xh1dwmZQr3pN1/O7Atqv?=
 =?us-ascii?Q?pH7gXkNh5X7q2RbhqG0E41//KN3BvhCKyfKUoVCG4qF5/9YapCvztU2iSCUy?=
 =?us-ascii?Q?2EqlQSCiFh4tVPSzju+ax4G7sqZTuevsR78jasMCxZbQoisglFuoilIWFax6?=
 =?us-ascii?Q?Ri1HLbmVEIAr0hvBRLGrh0a3Rm3UN5FBxQ9suGo2z5qWpVn3R5/NfVyDt55P?=
 =?us-ascii?Q?n4d8O0vcD6mwGafXGWW2LgX+wSLqlzAUGWBWFZb+hvBGm9F2BEG0me0y9Qby?=
 =?us-ascii?Q?IfpMelnhAWowCPcecxbvjUEGhg75gAq8RGf31GaJffZFCYJfEK7F7jLYBTzU?=
 =?us-ascii?Q?6bQqlo/JYtApVuQPFb0Hi3tBJdfTmg2U2nGUL8XtCbcVsK+CITq9cyMD3jY7?=
 =?us-ascii?Q?/BKGyGxqXQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99f3ccd3-554a-43c4-e015-08da1c861593
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 13:12:24.2366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DDA2U/lof5jmIQsdqXAHokQZ++NxfcGDSHVxdV8mE2w5UDY5oC9yO5Iz79sH7pD2PVkukkn858Wbu5A4j0zLaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4961

On 12.04.2022 14:54, Roger Pau Monn=C3=A9 wrote:
> On Tue, Apr 12, 2022 at 02:17:16PM +0200, Jan Beulich wrote:
>> On 12.04.2022 13:05, Roger Pau Monn=C3=A9 wrote:
>>> On Mon, Apr 11, 2022 at 11:35:54AM +0200, Jan Beulich wrote:
>>>> Prior extension of these functions to enable per-device quarantine pag=
e
>>>> tables already didn't add more locking there, but merely left in place
>>>> what had been there before. But really locking is unnecessary here:
>>>> We're running with pcidevs_lock held (i.e. multiple invocations of the
>>>> same function [or their teardown equivalents] are impossible, and henc=
e
>>>> there are no "local" races), while all consuming of the data being
>>>> populated here can't race anyway due to happening sequentially
>>>> afterwards. See also the comment in struct arch_pci_dev.
>>>
>>> I would explicitly say that none of the code in the locked region
>>> touches any data in the domain_iommu struct, so taking the
>>> mapping_lock is unneeded.
>>
>> But that would limit what the mapping_lock protects more than it actuall=
y
>> does: The entire page tables hanging off of the root table are also
>> protected by that lock.
>=20
> Right, but at the point where fill_qpt() gets called
> hd->arch.amd.root_table =3D=3D NULL, and hence it seems completely
> pointless to wrap this in a mapping_lock locked region.
>=20
>> It's just that for a pdev, after having
>> installed identity mappings, the root doesn't hang off of hd. But in
>> principle - i.e. if the per-device mappings weren't static once created =
-
>> the lock would be the one to hold whenever any of these page tables was
>> modified.
>=20
> The lock would need to be held if pages tables are modified while
> being set in hd->arch.amd.root_table, or at least that's my
> understanding.
>=20
> This is a special case anyway, as the page tables are not per-domain
> but per-device, but it seems clear to me that if the page tables are
> not set in hd->arch.amd.root_table the lock in hd->arch.mapping_lock
> is not supposed to be protecting them.

There are multiple models possible, one being that for per-device
page tables DomIO's lock protects all of them. Hence my hesitance to
say something along these lines in the description.

>>> Long term we might wish to implemented a per-device lock that could be
>>> used here, instead of relying on the pcidevs lock.
>>
>> Well, I would want to avoid this unless a need arises to not hold the
>> pcidevs lock here. Or, of course, if a need arose to dynamically alter
>> these page tables.
>=20
> I think it's likely we will need such lock for other purposes if we
> ever manage to convert the pcidevs lock into a rwlock, so my comment
> was not so much as it's required for the use case here, but a side
> effect if we ever manage to change pcidevs lock.

Such a need would further depend on whether the code paths leading here
would hold the lock in read or write mode. But yes, it is reasonable to
expect that it would only be read mode.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 13:15:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 13:15:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303668.518097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neGMG-00020h-Qk; Tue, 12 Apr 2022 13:15:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303668.518097; Tue, 12 Apr 2022 13:15:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neGMG-00020a-Na; Tue, 12 Apr 2022 13:15:00 +0000
Received: by outflank-mailman (input) for mailman id 303668;
 Tue, 12 Apr 2022 13:15:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zr8Z=UW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neGMG-00020U-5t
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 13:15:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8db96aff-ba62-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 15:14:59 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-jZ4IJJJzMSmqqjsumEholg-1; Tue, 12 Apr 2022 15:14:55 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3742.eurprd04.prod.outlook.com (2603:10a6:803:1f::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Tue, 12 Apr
 2022 13:14:54 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022
 13:14:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8db96aff-ba62-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649769298;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=N3ppk8XyJhwi8FSdtWt0sOX31crdVW93WwTaDONC7Mk=;
	b=RofJb0NghxQahZYIbkBOT9yiEGl2wYPekWF603ulWZb1uTbtLyJrQRcrF7vbrVeK/qMTMa
	9AvkdrT8mQ/y9OwiT111nrzVpX/PNHyYHYXOIWdp+d187qlJLw3PmGhYxxOwPUQPq6RfIc
	5avD7AquCCQWfaWtpIlyU+1h2fDlzws=
X-MC-Unique: jZ4IJJJzMSmqqjsumEholg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y1s1JEu/Rh3TnvmNo/Nlpx/6FLizba+HKhOW9LrR0wOAHGrGfvX5czviY3Lo6nEjBsl2kWOyLB25ca73IInR0zN6O7FpqbH8l/tD2DNZB9fJebTkfWKqIrZ+teuGJmwSBE6QTJRhWHsSbmybNc7FLqD0b1DQKEK8Ks5goL5D2INsjcDjzAIMXZCjhrmWg4kJYgWSSEc/sNwXyWNqm3E73AELJqMYdfF7MvieCR1nj4wXG8FNGpEmW6L/rWTYGz8DjMXHYAF5iWJD6LNKIuS99crHFmtbnf5ROjSDGbiO9oHq7GsHLwp67Ce3RdKLZSfFurOHOBoyC6Kd0YfpuK+KYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mrXLvynpQtfJ1BHM6+6H2L3/h6HhE7FyYSNJwGux3i4=;
 b=Xy14g7X4QKFBAYFOZZ4gnZrKAx0ysK7MHaYDI0QKolDGxZ0wdAd7cdVt7EjVGAOoddYDPVyozoZpPCPSDKTO16EVrL2UeFl+eXWBRiU0EaWzx0JNEESar6kFdp4SABpQ4PQTIryTT4wTI1kOxGr1qB4hNdJWrBI5MAsbESovrvKDhE6qI2DAQ+KEPi2kz35gRf77Q2IdX1h979D1HiHiivAmPxIeTQBtv0Sd5cZvgmb5AYd61uIEBRNMffTqg3mNEUcDfspHG34kk4ftgNJ7kjyoBkKA9q8615n8fPUVx8W1k2dcdx+bcUNyF/+cNcv/1CnAU0r+rNIkmaJIljxcFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4b0eeba2-0012-5a9f-27f5-5f85f039ef06@suse.com>
Date: Tue, 12 Apr 2022 15:14:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
 <7b79d293-80c3-d368-1abf-581f57dd2f82@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7b79d293-80c3-d368-1abf-581f57dd2f82@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0195.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2dc3add3-c5c9-4ee4-76b8-08da1c866f13
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3742:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB374220FF221E3DE4C29DD0C5B3ED9@VI1PR0402MB3742.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	r1UwJZtEsv/VacTAEOup+TPslbnoHJnW4VmBooS2p8qgB/5q9oY4eCQ4BWnIKjwsK9/CDHpPmc/R9WrOezhJ4S35VNw7I8YBdR9/NPBT3riEAYAg6kpuGaR/Vxs3CB/2bwEmqXbRt2iPK5Bzu3uH5wT+hgE4VH4DPfan/W7LPsNNZ3sXMk3OEx4G/Pbf4LDenfMgE0W3Wj1kUbuqlf0LTbDmror07ScmZFGy7Ohf2bUnWmtTgZSt32t965lqf+wru8EZrb0T3xcMxRNagwmAXSF0x3bgg24DATLRj2UK82aHQPhqiu6ns2t1BhSTAP+efVCbO0TNzdZNc/yhr/NbWbF45EIxiRK1slqhywZxqX8EgNs9Uu1ocCtk/Y392f+t3Z+vxUkRO1M7nj7jK37tpsN0JfruIKvnNwkXCVlZXKjTcKR+jNMc+E4HCtp51g4VER8UoSjAmZrVAfzwqZPAk2wM9liV2NyY5wsxrm8IBs5n9V9oEmxK5yYU+oSHVoxF8DmACbsQKKV/IR3bqtoh4EFyxahcdeO4PBYhyVn0hvI29XW+hPeUwNxQnSWzXZG3UZC0ju0D9BUznHDH1g6IrkIoajUrmFS7lBhj0Vj/kfS77yQ0MEhpfclf2f7NcKQu5Ri35kP8JI6AQUwN0rwYb6WvynX4UWpUG3BXCv5Om8EQt7G/EZzuQDosUYf73px/p0dR74sY+6t3R3Q+Fu2uGM9VkmUkkOgxtQt1bwnQyEgWkB4EVerz+V6ktT8Llktu
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66476007)(86362001)(4326008)(66556008)(8676002)(31696002)(53546011)(8936002)(6486002)(6512007)(2906002)(38100700002)(6506007)(54906003)(6916009)(5660300002)(498600001)(83380400001)(186003)(2616005)(36756003)(31686004)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ElCrIM6XCAh9qn8ufdqHGhoqauy0m4L/RWcacOfXvEN1ibJBdqw+wA9O1hKo?=
 =?us-ascii?Q?bt9KqIDVK00qqfh89yl4xGBgwVAooom2rbEXNhozvVURtgtHoy1YJgyBX5Z4?=
 =?us-ascii?Q?tiy949/RqPKwpDNkq001eS8T2o0cTc7PPwu8p7xtcbdUH5tn9VLU0ddkmFAv?=
 =?us-ascii?Q?ZkajD/Vt2FhrhtefgJ1QShnAMmadUYsHOthY13CLix6Ppq/bgHoFBzR/O8KQ?=
 =?us-ascii?Q?Gs8ULpjSZdF2WGngr7GI2CYtzyz4niMlvr3gQBm6IdejNvuV8hzqF9Vv0NeU?=
 =?us-ascii?Q?W/tE4Egy7G6axeI2jwXxIOreeHrfCk1200h+OriaKZzRO0xkf51tjWajb7v7?=
 =?us-ascii?Q?5GJPN+433Ejvl5CsrAES/mtJuXB/psKe/JalNLntDJRf/UbAvwySwjmWtzC6?=
 =?us-ascii?Q?kZNLq6ZK3WbbC5LmSWuSBpEuMvI38gvfp7N6xErPSDGeHOkdP/seBTtqQYxJ?=
 =?us-ascii?Q?OJMCAoLQZ/tAbEGPUZNKpebqYu+rbeP3I69G2kPW/3CZsHYUF4P/T8n2YPME?=
 =?us-ascii?Q?UxNztZLdGzR6KKuXBE0AsWWgZSsTmrb5VhEuG5yo+CdknAcwTrrbLBP07vLn?=
 =?us-ascii?Q?VRCtc28nIjP+vCkRb8StSIXZzB+JlaryzqbHq9EoT80/cOf1Jz32JplOQdi4?=
 =?us-ascii?Q?+ZNKyNCmDnaalDBWiT9fKwTSmNiiYR6i+b06dt6w0Qi/yiQY/Za2tJ/GAJsU?=
 =?us-ascii?Q?cu0aI6LOMpUayVzpeYOISr9HL3Fh64KnCBE9cCYvpfuuV5fMxglDkOCg2mWn?=
 =?us-ascii?Q?VLiQXZV+8D8RY59fC3zuuywJVrX6w07ErxxTKaIW+QV/eJ94QjVVyTNeG+mg?=
 =?us-ascii?Q?k1kXWdPlVkUwf5Ew7PCCLTEuKBipmq2zaii5LwlDO8oPVL7FvUEXHgxlisoQ?=
 =?us-ascii?Q?aWAhrIls3yUb6FhGEx7e4L7zJl3h0nmRZlfRJGpyM84fur1E1qAoE8iOEHBj?=
 =?us-ascii?Q?US3cmrj4B4C5oXnubcgHU48Uf6brQfYNRm0plgiq8D23MoAZHZkZxhJjY4tV?=
 =?us-ascii?Q?8GgS5IuYlMrRx54t1QS/c+zlJmMKX8USDFQrS5Yaq1RNmxuZJPxmEU5wqH3g?=
 =?us-ascii?Q?0GCzS0nVe4nj9Lj+2V/pop6/wJgDCnm91wjZSdsdnvyEJv59HgENDJ3v8D69?=
 =?us-ascii?Q?7D46p1VKdtNmwSRMUxWRs2x0GSEr5kkiJ1kjW6FhlM5n/vg6VZde/XKJcJ2s?=
 =?us-ascii?Q?1WKGh6GlP7ivmF7McZFjPkiow4ll4M1kVH8SRIOFCmcNWJGW3HCJo4uwPuaA?=
 =?us-ascii?Q?OJAznudGTKuoWu22kZzp6E3FGqTxlSCH3T6QX8mRqHGANdMwiOxTQDLZ21a1?=
 =?us-ascii?Q?ck9OSQaLuGkUr+ZuRvw/JDbYChtZFiLEYyaC5ZPkZqteX2vFQwJZ4ffWX6pW?=
 =?us-ascii?Q?/72a7fxcuDNTnNtRQEEJhJnjYW+EQrOYTLnq77zAHKmDCm4K+cHXqtQ2x+kg?=
 =?us-ascii?Q?tZiipKflqTZRimLRdFX/s1QFU/ugWX1D7lA21c9R2jvqfWIAa8oNtKBBb4xQ?=
 =?us-ascii?Q?8LqshEE0PHCepvAe+P3paGOzZz+qSC63f2O0sdkUGxRf2Uuw24GUAO+qdQ5v?=
 =?us-ascii?Q?OsIZR25C7zgHV3M2kBnByN0LrbAowdB5wzWZviNNPZu/r8TzqcBESqCa/CMy?=
 =?us-ascii?Q?+5aJOMfs8lUyJEFik0rOtXui7z/qs+ohwKVoLimLRIX44Yc3ONsq1yDifbSE?=
 =?us-ascii?Q?/yDYa/SR5PWS/wxtniHIFocWydTWq4aifGA43qFThBT97IVt0wkfDx8Jetr3?=
 =?us-ascii?Q?3Irqj4JuNA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc3add3-c5c9-4ee4-76b8-08da1c866f13
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 13:14:54.2338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 686kansDUfzHmIoBMsRb/qLVpLu73djh14Is078p42hKH+8yiG7O29IU/CtgymzoUIcLU5eVlnbM1b25FMV3Ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3742

On 11.04.2022 12:01, Andrew Cooper wrote:
> On 11/04/2022 10:35, Jan Beulich wrote:
>> Prior extension of these functions to enable per-device quarantine page
>> tables already didn't add more locking there, but merely left in place
>> what had been there before. But really locking is unnecessary here:
>> We're running with pcidevs_lock held (i.e. multiple invocations of the
>> same function [or their teardown equivalents] are impossible, and hence
>> there are no "local" races), while all consuming of the data being
>> populated here can't race anyway due to happening sequentially
>> afterwards. See also the comment in struct arch_pci_dev.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> It is only legitimate to drop these calls if you delete the mapping_lock
> entirely.=C2=A0 Otherwise you're breaking the semantics of mapping_lock.
>=20
> Your argument of "well this is already guarded by the pci lock" means
> that these are uncontended lock/unlock operations, and therefore not
> interesting to drop in the first place.
>=20
> This patch is specifically setting us up for an XSA in the future when
> the behaviour of the the PCI lock changes, the fix for which will be
> revert this patch.

Further to my earlier reply, may I remind you that changes to the PCI
lock won't go unnoticed here, as there are respective ASSERT()s in
place.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 14:20:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 14:20:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303673.518108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neHNF-0000KO-Me; Tue, 12 Apr 2022 14:20:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303673.518108; Tue, 12 Apr 2022 14:20:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neHNF-0000KH-II; Tue, 12 Apr 2022 14:20:05 +0000
Received: by outflank-mailman (input) for mailman id 303673;
 Tue, 12 Apr 2022 14:20:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P3wJ=UW=chiark.greenend.org.uk=ijackson@srs-se1.protection.inumbo.net>)
 id 1neHNE-0008Pe-8a
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 14:20:04 +0000
Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk
 [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a2b4aee8-ba6b-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 16:20:02 +0200 (CEST)
Received: by chiark.greenend.org.uk (Debian Exim 4.89 #1) with local
 (return-path ijackson@chiark.greenend.org.uk)
 id 1neHN9-00049g-9B; Tue, 12 Apr 2022 15:19:59 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2b4aee8-ba6b-11ec-8fbc-03012f2f19d4
From: Ian Jackson <ijackson@chiark.greenend.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25173.35471.207443.559232@chiark.greenend.org.uk>
Date: Tue, 12 Apr 2022 15:19:59 +0100
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
    Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] osstest: install irqbalance
In-Reply-To: <20220412112859.73330-1-roger.pau@citrix.com>
References: <20220412112859.73330-1-roger.pau@citrix.com>
X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu)

Roger Pau Monne writes ("[PATCH] osstest: install irqbalance"):
> Or else all interrupts will get bound to (v)CPU 0.
> 
> This doesn't cause issues on small boxes, but boxes with a non-trivial
> amount of CPUs can struggle without interrupts being balanced across
> available vCPUs, as the number of vCPUs offered to dom0 matches the
> number of physical CPUs.

Wow.  This was missing all this time!  I wonder if it was in the
default install in some previous Debian release...

Acked-by: Ian Jackson <ijackson@chiark.greenend.org.uk>


-- 
Ian Jackson <ijackson@chiark.greenend.org.uk>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 14:28:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 14:28:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303680.518118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neHVE-0001Fj-Km; Tue, 12 Apr 2022 14:28:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303680.518118; Tue, 12 Apr 2022 14:28:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neHVE-0001Fc-Hn; Tue, 12 Apr 2022 14:28:20 +0000
Received: by outflank-mailman (input) for mailman id 303680;
 Tue, 12 Apr 2022 14:28:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neHVD-0001FS-6M; Tue, 12 Apr 2022 14:28:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neHVD-0007Qz-0K; Tue, 12 Apr 2022 14:28:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neHVC-00032u-Ee; Tue, 12 Apr 2022 14:28:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neHVC-00040a-Dw; Tue, 12 Apr 2022 14:28:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sKw0JCtDOylVDMi1Q/pytlbfUUaFYk9Ub3K+YHU5ONQ=; b=edB92yRYRP60pW4bHVaJJFP9T4
	NHljazss1OZGkBNiDP8XZLLJc2GzckpDU/LYDajN87E9VaWPiyUIqgGia3jhEcmjAGZy6U/+11WsI
	rOJ5e93MzgQhNl7TbhEfonl+j6C8efyLpAXCyErM5rFnaDfJ6/nrSTBss05J3UA/6v+s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169334-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169334: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=5576b17363e92ce07e9707478061d5ce38bf7d06
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 14:28:18 +0000

flight 169334 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169334/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 5576b17363e92ce07e9707478061d5ce38bf7d06
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  344 attempts
Testing same since   169324  2022-04-12 07:10:23 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4911 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 15:48:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 15:48:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303709.518141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neIkd-0000s0-AP; Tue, 12 Apr 2022 15:48:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303709.518141; Tue, 12 Apr 2022 15:48:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neIkd-0000rt-7G; Tue, 12 Apr 2022 15:48:19 +0000
Received: by outflank-mailman (input) for mailman id 303709;
 Tue, 12 Apr 2022 15:48:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vUK/=UW=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1neIkb-0000pk-6b
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 15:48:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f754883e-ba77-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 17:48:16 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-c2aBBBbsNhuOTx-P_80g0Q-1; Tue, 12 Apr 2022 17:48:13 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by DB7PR04MB4154.eurprd04.prod.outlook.com (2603:10a6:5:26::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr
 2022 15:48:11 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748%6]) with mapi id 15.20.5144.030; Tue, 12 Apr 2022
 15:48:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f754883e-ba77-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649778495;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=zK5aaapFFOun7/nhGJMeTfIBh3GoMdwRavkUl00sQFg=;
	b=FO1h9rPGPswHfTT/aFcaEN5OP+B6/x2vUOA+uXbO2h9KFwXbKzrfFHVQRvGQ7TilORsYrL
	wMGTla7qP3Yde53IG4ffmJ68pRxdIPXHGPjqqP5XBsZQVeNyq0vWT28iV51joMsvCRM6/k
	RlABlTnZyuPnJRucTRucMKHx6yPYplk=
X-MC-Unique: c2aBBBbsNhuOTx-P_80g0Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ebkzoKF7/dfpruK4DK1jJq84vj0VPSRFXeEkwKX759b2QbiK6mViXwY7jowkpkTFV+q0Me/xdj5O4EeuwgZVBQQDpNcmDhbnxaM8rOkkKX/G5leaBLmGfnwrdF2qFCv0URoBiR/H6X4RTAuiL4DDNMaNR6X3O+RzQG2uSKN/Z8ubx1dQmCIskeWAhfoC12/YqsBGu6AM57KVrpHsr2WSYfqhOp3JpqFGMTIPPElYcCnbVZS1e6aVj//DwDHlHgqTnW30aYmT4XRZ12lNlv2MNKIVVfe89HqHJKmZYIAhWwT9cG4K9TezyWbJ3QDeEM2u+NtIloUc31huxXsGVW7HMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zK5aaapFFOun7/nhGJMeTfIBh3GoMdwRavkUl00sQFg=;
 b=nyAw6bYEIxaq7pVRtHTvy6kygBO4KFjTka6vY+tATNiqzHbKRXbzWSpuaynMZHfo6GbvGz0HyCfzsg+gY2QZfDmLO/hlu0Pd7dY2ynKa92DUJeifptU4m0uAk66F8w6hmDIaEc6bB8f+bIMZjdvl+ghqZhrc260cAgEVxqBcozmaAT65jcuqNsYm0cGzqT0WIhXzvAQKt60ekN2ITtvy5tganxSLleZmExcGuh0ttOwlahub2cizlWugAowMQgxkHZOrMdGxyhiknIW07Ytsy0GLwfsf8YS1fUxY4AWLCpR2Ea/NbdB2grPqOAnn8e5R0Z4YK5VTKNPsBKvWc14MNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "ohering@suse.de" <ohering@suse.de>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Topic: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Index: AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgAAVUwCABn7lAA==
Date: Tue, 12 Apr 2022 15:48:11 +0000
Message-ID: <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
	 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
	 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
In-Reply-To: <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 943e9f1b-6e3b-4d68-bdbc-08da1c9bd925
x-ms-traffictypediagnostic: DB7PR04MB4154:EE_
x-microsoft-antispam-prvs:
 <DB7PR04MB4154DE11AD427B094FB759DCC5ED9@DB7PR04MB4154.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 BdejaI46zJlasc+gO/qLs3hgDk8aNQ+p3cs1b9jdZBlr9znseaNmB4PVmIixyFB9CLNzRcSK6ySRUGfLrpbyOb3ygwnHdT1HnfOhrrZh+ovOis349im28X7dOhEk+fSA7GCrgYuAhAWIgjMctbcteLNHbzchr3d//oaePj1AVzWGjd61vr8oRiF/gXUcSsjPDmOqR+FIBKZ+n0EGqz9cD2US5rgVRPNYVhsSYEMZp9EuFKL36RUfimQCbP546W45sauu7dU7l+EhyAcYAQd6Q2a3CfmwzdxFERT+pqDBYQeh2h+asgtBMWxxj4Di4YGpdLh7KmZfXFT6ilDPWVJAO/gF1MLL1FHTj1Bx5pd5e6Uo9Z+CKgCSBY4ur5rUb/z7qAMcqH3ctqH1Ah6zBleqJDPJMadQ7P1J2O1bPilqJYXo66tjYE9JeTZr2kcVPEfxQEI7YlUsQU94wqxWgqEV4Uh32YeggOZejP8XVvTB8hVCrEQBNLUJla+Cy2glnS5oXd+SmcZKwoqEVcH5DRsN5gP7c0kvARoLfoFZCviDffNHbqVvc/R0LJDN87gl3fEVlXFr6Qo26eP37G/vilI6A+PvNXaRISYg8zI9nmF0/d0SubPNIhZ/UmUd0BD8N3itD5/JaUxJyKU3edSsAALf0n8f7onVAwnEAzATcgg9o6FvHR6TtzdxY0cVgGTm3Nu4c4u6c2MH/t52ZjwqTdSLyKXwoH6GgUCsxn3NU1lxc07C0tbmxbvmOwLS/O4kYt6ww2PSQEAlAnOueHndgoGwQkjcQdohiXWsRvwQrbEnbrl+OB/MqFhJw/+R8bcVClwE
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(8936002)(6636002)(99936003)(5660300002)(6862004)(26005)(2616005)(186003)(86362001)(38100700002)(4326008)(38070700005)(6512007)(6506007)(83380400001)(53546011)(76116006)(66446008)(66476007)(66556008)(2906002)(122000001)(71200400001)(37006003)(66946007)(64756008)(316002)(91956017)(6486002)(966005)(54906003)(508600001)(36756003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Wml0Q3N0bUpRTUl2MGxLell3SGRnUkRmVGtOS0pXdWUvdkJjQnhBOGFSRHF0?=
 =?utf-8?B?eC91K1JnVk9uR0tCM2dMZ25pOENzOUEva3AvWFRNSDArVk03R0F5N0RaRitx?=
 =?utf-8?B?SFNYSllFeGpwVmFpTGVzU1JXMUw5b1dZbEpLeW5YN3JIWlY5WUZvaGt6Uytu?=
 =?utf-8?B?TEtVeGNSTjV6WjQwUzNUbmNqNVZSU3ZQZW9pK05BVDZBL1RyczFsQjRncy9H?=
 =?utf-8?B?Y3czNk1DcVQwK2dYb2cxMlhiTlZIemE0UDVPZHBSUHlrRWhKd09kVy9xNXF1?=
 =?utf-8?B?UDQ2VUZCUEN6clNVTVZKRzVxRTU4MWxHdktob253NGhzRVNoMjd0QlRJSVdp?=
 =?utf-8?B?dm4yelFpeU41TkFBandJZFB0V2hnSFVDb0tCUWFLSzNMYWNpQ2w0anB3UGRM?=
 =?utf-8?B?MTRleUlBKzc5Umg3STRvV0pMUG0zZjczWloydjhPb0hLNDFWaEZlK2lpc1ZR?=
 =?utf-8?B?UVVseis4aEJSeDVOT0Y4elhWd2diaTlqYU5IejkyTmVRUm9BY2s3amR5Tlo2?=
 =?utf-8?B?T3pVZEV4VngxRW5ZS2wvS3cyVC9wTEJhcVpPMlN5TGNycGhkY3VmZjJ5Qk9k?=
 =?utf-8?B?L3A4T2lnaXJ4SFFPUDhMdkR2ZUozLzFqVTdQZXBtekN4Y2tqSnRmWTJsdnJ1?=
 =?utf-8?B?dHZmTktDWG16eVVyQXJvUCtpYXZNMWZqQk85UUk1Z05KL1FJUXNjaG1YTUhS?=
 =?utf-8?B?S0RSbGZ3VEdLZDZUb1J1WGc3NVpoczhVVVd5ZlZPQklCUEJlWDhjWTA3RWlT?=
 =?utf-8?B?OUJ3U2FtK2dHdFJqQWxaNGNaNHFoUWhpeklEdTZhMHcvVkZxMUN5b1Z6UnZj?=
 =?utf-8?B?Ly8ycFZpU0FiREhXVDVDTUxuRUVKZGVUbE5KNTVJQ05zdnBkOXU1QmM5STJW?=
 =?utf-8?B?bjlMR2I5cCtEQVhUQ0xwWFR6UjlEVnhyNzB3TEUrQ1FFQWJrQjRRUmFqZzBU?=
 =?utf-8?B?MXpuVWZWWjgyQjh3dGNaeVhMRDlWQ1kzNTIzNk43UjBua3BCdGZyRDJENy9l?=
 =?utf-8?B?cmRRb1lqeHdxanEyWDNuK2IwSjhuV0VZcVRaQ0hFVFhVWGVmM0ZvR2t4R0g2?=
 =?utf-8?B?UWM1dEMxQ3V6ZDh2R0JxeUY1dUFCYW5adUpGc3pPSm5ZdHc3MTVhZU1SbGlm?=
 =?utf-8?B?a044Y21TdkFpQURwd0J6YmNqZnRUYnRRbGdwdUh1KzA1YmV5NGZ1YXI1SGo2?=
 =?utf-8?B?WHhmTjRFN1ZJbkpQNmgxTXRjNkFBVlBBNzVENjVwNFdocWlCNEtyU3hMRU4y?=
 =?utf-8?B?MVMzSHlkczN4TTkzekpnOGFpbzRVTW1qcEIrU3Z1WlU1R3hvOFROL2hPSERm?=
 =?utf-8?B?YTVLWkpvU28wQTRYRHNlMlRidTdtWXNGWTZnYzE4UHlOMExaNkI2MGdpUlNG?=
 =?utf-8?B?R2k0Zm9Eclp1eE9rSUVZaFh4SndlSGlVTWZmUU8vaDRHMG1Cb1VzWEg4alYx?=
 =?utf-8?B?bTV6OFh4RzEvV2JJbnhNYWNsNVBFU0QyTExyZjhMdXpHcUljZjJITTZJOTZK?=
 =?utf-8?B?MW9UdnQwVjhIZmtZK3E5dEJ6azRNWk5DUE93RzZUUXBvc1RMM2IzZ0VKbTZv?=
 =?utf-8?B?VUplWWhIYUluVW9hSGRrY3IxdkhwbVpHSHRhQS9uaXhUY0ZXSUQ0bWg2bm9n?=
 =?utf-8?B?V2dBSktXcmxQRGFWWWdvMi8wRzFXa2RhUVJYUWVMRTVXRm9VbnVmQXpqZ2tP?=
 =?utf-8?B?RjVweDVxckdraDBLVnRwc3RCYmduWGVabm9XVDJvd2xZTjR0Ymw4WGhxVGgy?=
 =?utf-8?B?SVRoQkt3TXYxZ29FcTVVdzZGbUwzQVpIUmZubE5RWHBXR2VuT08vNWhTRjRM?=
 =?utf-8?B?c0N1amxsYmloTnQ0bjJscVIzakg3OVgrOTMySUZvZGtSVmthMGhnaTFRbm1z?=
 =?utf-8?B?YnpGRW5zdzRwRGlLNVpkbUZ0NmNLNzJTN3hTZXhiRjV0WWx3MXNmRjYyNFhl?=
 =?utf-8?B?YmlTcGU0RE9yWGVBU0s3ak5nbWpxOGJiV1JIWjNldk1rUlpKSmlJZDhKV3dS?=
 =?utf-8?B?RktZWnpPaTgraHI2R3U0MENvNWM5OC9wU1hDQUR2VDZPTFZqQU5JUlQrUFJ1?=
 =?utf-8?B?MmFxSlhJRzlTa2RFQWhCdW4rQlV5eUV2QmswTGkzMXFYd0xwSGFmQ2lCbHhy?=
 =?utf-8?B?VWx6Y1p4QkRKS0xvRDRTRUFCams0TmlkVCtRR25JK25MSFBSZmFDTjR0NExz?=
 =?utf-8?B?WVhpTGlsekRVZnRzUW42eFFSaU1FNnJXREcwOUJ3WUJ4RXR6RDZ3ODlEZ1VY?=
 =?utf-8?B?bjNYVmVZWUJ2anFtMk1rY2k2dkwrbnRJeUtQSVhWRGI0YlF6ZVIvRGlsWEFq?=
 =?utf-8?B?Q0VoNTR3ZnIrdWpVZkcyejdodEpGdHN5Zk1GcUNsQUNOMDRmcDRVZz09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-d93xAvfylIYqUOBVwxUm"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 943e9f1b-6e3b-4d68-bdbc-08da1c9bd925
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 15:48:11.3734
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZzqHnFfKHPHvxG7sGu7uUwOeaAwDKekSIn2lx2G9vXDY4gOkXuyylhqBGbZjrgKOijnIUb/hAY+IRYbIekJ2pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4154

--=-d93xAvfylIYqUOBVwxUm
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2022-04-08 at 14:36 +0200, Jan Beulich wrote:
> On 08.04.2022 13:20, Dario Faggioli wrote:
> > On Thu, 2022-04-07 at 15:27 +0200, Jan Beulich wrote:
> > > Credit2 moving the vCPU-s off of their initially assigned ones
> > > right
> > > away of course renders sched_select_initial_cpu()'s use of
> > > cpu_cycle()
> > > pretty useless.
> > >=20
> > Mmm... you mean that Credit2 is moving the vCPUs off they're
> > assigned
> > ones _right_now_, or that it will, with this patch?
>=20
> Right now. On a 4-node (6 cores each) system with "dom0_nodes=3D0" I've
> observed the 6 vCPU-s to reliably be put on CPUs 13, 14, etc. The
> patch is actually undoing that questionable movement.
>=20
So, yes, as said, I was wrong here, because I was forgetting that we
update dom0's node-affinity according to what we find in dom0_nodes,
while we parse dom0_nodes itself (and it was stupid of me to forget
that, because of course we do it! :-/).

And in fact, since node-affinity is already set to something different
than "all", sched_select_initial_cpu() picks up a CPU from it.

And it is also the case that we could, basically, use that later, in
sched_init_vcpu(), which is kind of what I'm proposing we do.

> Since I have a large amount of other patches in place (none of which
> I would assume to have such an effect) - Olaf has meanwhile confirmed
> that the change helps for him as well.
>=20
> > If you mean the former, I'm not sure it is. In fact, when
> > sched_select_initial_cpu() is called for dom0, dom0's node affinity
> > is
> > just all nodes, isn't it? So, the we can pick any CPU in the
> > cpupool,
> > and we use cycle to try to spread the vCPUs kind of evenly.
>=20
> The CPU mask used in the function is 0x3f for the example given
> above.
> I did not check which of the constituent parts of the calculation
> have
> this effect. But the result is that all CPUs will be put on CPU 0
> first, as cpumask_cycle(..., 13) for a mask of 0x3f produces 0.
>=20
Right. For instance, on my 16 CPUs, 2 nodes test box, where I tried
using dom0_nodes=3D0 (mask {0-7}), I saw the following:
- for d0v0, sched_select_initial_cpu() selects CPU _0_
- later in sched_init_vcpu() affinity is set to all
- later^2 in sched_init_vcpu(), Credit2's implementation of=C2=A0
 sched_insert_unit() does a "CPU pick", assuming it can use any CPU,=C2=A0
 as the affinity is "all". It ends up picking CPU _9_

We move on in the boot process, and we get to create the other dom0
vcpus, e.g., d0v1:
- d0v0->processor is _9_, so the cpumask_cycle() in=C2=A0
 sched_select_initial_cpu(), done from 9, with a mask of {0-7},=C2=A0
 brings=C2=A0us to _0_
- that does not matter much, as the CPU pick inside of the specific=C2=A0
 scheduler has its own logic, which also involves a cpumask_cycle().
 And since we picked _9_ before, and the affinity has again been set=C2=A0
 to "all", we pick _10_ and, for what we know, that is fine.

This goes on and happens for all vCPUs, with the result that (in the
worst case) all of them are placed on CPUs where they can't run.

Once can think that this comes from the fact that we do CPU selection
twice (once in sched_select_initial_cpu() and another one, inside the
specific scheduler). However, this is necessary, for two reasons:
- a scheduler may not have its own "CPU pick logic", as that is not=C2=A0
  required
- even for the schedulers that do, we need to have something in
  v->processor, when it runs. And sched_select_initial_cpu() is  =C2=A0
  something that is (should be?) simple enough, but at the same time
  it puts something sensible there.

> > That's because, by default, affinity is just "all cpus", when we
> > create
> > the vCPUs, and we change that later, if they have one already (due
> > to
> > it being present in the config file, or in the dom0_nodes
> > parameter).
>=20
> But that's what I'm talking about a little further down, where you
> reply that you don't think using the more narrow set would hide the
> issue.
>=20
Sure, as said, I was missing a piece when replied.

> > This should make sched_select_initial_cpu() pick one of the
> > "correct"
> > CPUs in the first place. But I don't know if it's worth, neither if
> > we'll still need this patch anyway (I have to check more
> > thoroughly).
>=20
> As per above - sched_select_initial_cpu() behaves as I would expect
> it. It's credit2 which subsequently overrides that decision.
>=20
Right, and it overrides it, because we set the affinity to "all", so
it's in its own right to do so. And the point here is that it is indeed
not right to do that.

So, as you said yourself, we should really change the fact that we're
setting "all" as an affinity for dom0 vCPUs, there in
sched_init_vcpu(), while we know it's not the case.

And while doing that, I think we should consolidate touching the
affinity only there, avoiding altering it twice. After all, we already
know how it should look like, so let's go for it.

I'll send a patch to that effect, to show what I mean with this. And...

> > > =C2=A0But I guess that's still useful for other schedulers.
>
...Yes, I'll rebase your patch on top of mine. In fact, although
tecnically no longer necessary, for _this_specific_ issue (I tested
without it, and things work), I think it still makes sense.

Thanks and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-d93xAvfylIYqUOBVwxUm
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJVnzoACgkQFkJ4iaW4
c+5ihhAA7eKe8Dk2555pLYHgBOvVJJkP+/ccii0VzuZFvUT37CQ1u31R3ja1JIBB
K540sSEpoOX9VPKH9iIX6k1iBO3vn1pYLcU7NUj7ptlQvjnNvgxtwGcHbZRCgLyS
lY35ZSevdM+IliJND8oIjAzBPrnF7gMsHZtJ8NwBEGDneqdr1Gcrr0ahfCujHER+
9dJg+2oaVXfkQlqVlUI5gpTNz4mBDDN6QktjFHsRBY8SOPEDWbpVlZhdr/vdb0jF
UNDYXyQGm8z+rlNxzH77pJIbLeHELLdV47g1/GMdHlZ8Fwr3p3azCqeg/1Pwr9ij
q4oxFRQbVtbVIOqrPZefoZS3jmfzQ3pCe1ne0HEvg1Zf2i8HgkjxBPyFlPNP3XA5
021xcScaYS+beKu7ExKRiBCkQFY/hXlzaIP4sGoTDewWl+55MjiWcgw9EdZ3SLVC
3MMJbMTtgfPhlwj0OCNJGLuNvUYk0Nh2IRE1yydvSyf9nXTJQ2z/LR0G655pIyZY
uft3YOZq3szBKJr4w22oIt2smXhloPiwIsOXZCUXUNkbmqqVkZ3YsLB6HRWaPgEO
CNW/lheXbJkAnArJLr2myWSdhzZX3I3W/34Z2XU356EAf/M6RrsAY5O0q53PWN6q
loTzhtpX75ewVgBeBhxctSB6B7Zfjw25b8N4slomlKx/WZOA/Dw=
=3uoD
-----END PGP SIGNATURE-----

--=-d93xAvfylIYqUOBVwxUm--



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 16:11:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 16:11:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303724.518157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neJ7R-0004iB-AG; Tue, 12 Apr 2022 16:11:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303724.518157; Tue, 12 Apr 2022 16:11:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neJ7R-0004i4-7E; Tue, 12 Apr 2022 16:11:53 +0000
Received: by outflank-mailman (input) for mailman id 303724;
 Tue, 12 Apr 2022 16:11:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vUK/=UW=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1neJ7Q-0004hy-HI
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 16:11:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 430b29b7-ba7b-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 18:11:51 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-a_Y94KaaPUyL243ah4gZ6Q-1; Tue, 12 Apr 2022 18:11:49 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by DB8PR04MB5817.eurprd04.prod.outlook.com (2603:10a6:10:a3::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Tue, 12 Apr
 2022 16:11:47 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748%6]) with mapi id 15.20.5144.030; Tue, 12 Apr 2022
 16:11:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 430b29b7-ba7b-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649779910;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ngNkXe9ZAZvV8eAIl13VX/nZiyJuRCXIKxcAeBaVggg=;
	b=BVSbP/0cebO80XALAwK+S07A/Rnk9sdKqoCs/A1pN7ABEf9D26AdBVSGyhf/ay4dyZMn2j
	LxGaqtuCzKrPfdUBXCJf9QpQRB9r5sumdotQPkloSHYNhNKqR/5G9Q0AO2+cAgoFg0HL8G
	3EnFoVdPJ54lpwkDhnXlejfZlx6jMIQ=
X-MC-Unique: a_Y94KaaPUyL243ah4gZ6Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OxqVN3+phbfgp1ydfnyTnoThUh6eWkiTfKLvhlWCw7SiMAxlGm4u90mQL/QUkU1pGlHGiGF3rgG07I3UxvPTBDk7WsULPBZIkpdEtqvjlagloq8jWCT7DuvQtGpb+Lm931x2dzElo8tBcQ4528+ZQujhWy8+nppKh6MsZ2mhQT1xDBVKWggl/9mdCn68Ic4OBVwp27aEe2Ayz2ODYTFfWUKxFMFDZlZqOPc6lA2GlSe5lO9HOUjQxQbKdlt1Ji/B+333nOuERtXb+Xc9mPFVJihYnrvt545mriMbYXb1o65BztadGmqEFTq0iyipSd0kUViAXPESMchVa8yghKZnKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ngNkXe9ZAZvV8eAIl13VX/nZiyJuRCXIKxcAeBaVggg=;
 b=dbcv0DwvLUFiqrcYG8kAjkORMY2cnF0esZQNBRnV8aUWgtES0RfHYA/IBCLWl2AqnULPBe4ffbfx2lrTa4kOsdez5Vt6wHYyLkw8Vh8xtqpkA8Nd42lNy2crag8oRvSp1oDa7IyjTizOzW2r4VEmNAiOgisXISDhDnpqHgby1f4lIVy7vKSeeOPJ+FqrxgSsjGDbjOVQdzThO884WED/JaDcNopS4ue+Zk/nu8prv1Y5e8cF7j/CyV3rTx/YfohTcC229sz/FWvS02e77U5YSdXImLSgpp2aFSby6b9zt72TRQzPdmTySu8tSJrD7rdE+GSGvJkKz+n9o9Q9crVQ8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>, "ohering@suse.de"
	<ohering@suse.de>, "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Topic: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Index: AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgAAVUwCABn7lAIAABpgA
Date: Tue, 12 Apr 2022 16:11:47 +0000
Message-ID: <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
	 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
	 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
	 <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
In-Reply-To: <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2b89f8c8-b379-4f60-725c-08da1c9f24f1
x-ms-traffictypediagnostic: DB8PR04MB5817:EE_
x-microsoft-antispam-prvs:
 <DB8PR04MB58178FFF95188D127AF15A1CC5ED9@DB8PR04MB5817.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 lYIehLY5fSKDylWzt1y05J9CdHVApFKVx6VPMoApYuuEqZ5xucpE/K7SdGCEVXvUkCtdDm6j2YH6aTS5oG3XzZleEsUei3ewRLH7tlJpUunrXQLvp/N9L3BD0g2eWLaQETxx48O0HaM/DY3Nz49DKI7+IgzhlOR+p3Bv2mxAqb11pZb2rwMmOwlAlEK5CAgUdNPdsLNSgrz+X/3blHeP/H6yflvNaTgPM363pZQ5YKGn/Lk1Hyed0+yWq4FH+hZqr4jJN/TADnpaZcdoVYl6w1bd/TL3IDaHjPaHJMK3gWPYn5g7yI55sGs4achw7t0lcBC9i5yd5lLor+uAFq0c1t5HRm0vbDdmIQhFHqVEZssZhuMyKyDhsI3iGb8MOoRX2K7Bhd/m6aHZuyflSoRTnm98BVG85X2uUW4Vsp5LmZCMsCExqlpOioAxAk4oA3p/mvyQfx8L+3nP9Sj2QkVwQtnyuSYZH3VMdUt2vLEaL8/kBo1s7mDnRoPOjeV9NyuAXqycm32fdleEgy/d8nnJOF9N8bMU3YitEHj27is4yevOk+0ZUms8ZEj35+nFht7feJIAC4Q7n6P5KuNCAVeJWtMoAc3yGHV603SrG4/P2p37eiwqqrCfH+8PYGMVBL6BXTGzDJKs8YB8e36WfLVf/HhBl+D49HtSGPezuzCG47CuUhufHmyim1c/CUX3mHfT1G+Xi1XKGTnqiAl7+Mv0qmQa+cy9OqzwHoqv5Noq0zXXYjGErJlQdAXv+j/zVOTHyuIRwo9lLLeroOZnfCZwZ174r0ZrAGjbZ8TFhCbC9hLIeEWhs972VR2iphjeNA0Um1a4NXW3vWpT5DK0DvSimQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(37006003)(54906003)(6636002)(6512007)(316002)(36756003)(508600001)(186003)(38100700002)(122000001)(26005)(38070700005)(2616005)(83380400001)(6506007)(8936002)(4326008)(6862004)(8676002)(64756008)(66476007)(66446008)(66556008)(76116006)(99936003)(5660300002)(66946007)(91956017)(86362001)(71200400001)(966005)(6486002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dUlGUURFY28zSzhERUFVMWNzUElFN25VcTREK0g4Rk0vQTRhVVJqTzUwV1Js?=
 =?utf-8?B?RVk4R3U2ck5nZDROV1JmTUlxVVlxZmk4Umc3bk5IUERSMW1CR2VVWm1QeDZU?=
 =?utf-8?B?dDA3TFJ3N3NVZ05zOHErK2EzSENTcmxINExUbEg5YXdRNldoNEdwU2xlcG1U?=
 =?utf-8?B?WWhLemJieFIzZllGWi9lVWw1VFc5NlRxN1hnbXNNZVdKRUNVQ3cxUVdIajlN?=
 =?utf-8?B?bTF2U1hUZ1h4RXI3d0RZdmJCa0VNbnJJUWtNazNUUENEdW5qZVpzRjVGVTMw?=
 =?utf-8?B?WFdncUNvN2ZnaTdNTytKTWNwbDlkc1IvTW5qZTlTK0d4bEs5MlFLWU1YeWJ4?=
 =?utf-8?B?WnVWK2R2OXBCc1MrNjN3eUZSV0plMktXZEdwWW52aWNYUDBJcFMrZkNEZEpT?=
 =?utf-8?B?ZENtQ3pnc0Z4cVRoOWd6WFRMVTVaMVVsQll0QmdsK2pzbDZJc0IzMWU3RFVQ?=
 =?utf-8?B?Rk8yNWNkTkEyZGN2aml6YWYxL0tOajREWnkrTE8rWU9CR0ZVWVFoUUc0Tnla?=
 =?utf-8?B?NnI2cG1xWVJNSk1lSTBvNlhrVkY2SmR1N1VLcFhzYTVaT2lLR2U2Um1UM05r?=
 =?utf-8?B?aHVmWTI0V3FBTkp0R0RkMGR3eU9kcVJZdS9mMHA5dmVRSng3cHpGZjQyVFVY?=
 =?utf-8?B?akxaZ3FXYVV5RGROMVlWU3RMWkc4ZDlWYXcrTVd4czc0cmZ5YTFTd0tMdm03?=
 =?utf-8?B?ZXcvODhaUzZHQU13ME9hOGVZdHNNTlhWQWlSWlo3ano1M1ZQNkUvS25EZFJV?=
 =?utf-8?B?Nks0VGwrUmtRQ3pqRkdDVXJ6ZU56eDhoVzUrK1p3cnpyK1A2akFTK3FZdElu?=
 =?utf-8?B?YlNRbFFQS0RIQ3dJUDE3c3pyTHVQNzNBSXNBTUg0RER5QXgrcUhEMUxabHYy?=
 =?utf-8?B?SGRhYXhPdUFkcC81eTJjZ3owTzFvbzE2ajlTT3BpRkFQQnNHQUtlTXRjOHhj?=
 =?utf-8?B?TDJHcmJ5SkpuU0JqeGJaM1JkLzJtTDU2S3pJelkxSjFHU0pQR2kzM1dDTkdU?=
 =?utf-8?B?ak5xL0tzQmVmaVpUc2dsVjRFYTRpZWhGOE1FaTJvbVFwUmFOYmJ5NlBReWJz?=
 =?utf-8?B?Z3EvN3RnQkhXVDI5NUFJbExkbzB2d2lzaTlIenE3UUUxZ09NR2xaSmJyUkg3?=
 =?utf-8?B?cGtkQTRybWFjd3I4QlEyOUc0SHFUbkNJNUwrcU9DK1cxSzlVYmMyRWoxdDZL?=
 =?utf-8?B?VnEyVGRYVUpJN01mWUoycVdubDlWQkhjQjhsTEg1em5hdFh4czJjU3dKVDRE?=
 =?utf-8?B?Nkd5dDlaejZ3Rno4V0pxV3owMlBaeExISjZTQlBGVnNRK0hweWVreGZCUGxI?=
 =?utf-8?B?OWhFeDYzWU1iWDF5Q2FDc1FDekdQaHd4bHRlS2FBenVSeENsZmNZR2s1RFhQ?=
 =?utf-8?B?VlhYNWY0RStKdnh2ejNka21zNkFPekh0QS9Zdzd4ZldKMHNtUmZJWisxSEo0?=
 =?utf-8?B?TUpob0Q5U2NWVlRWTlA4NVJrYm1DUUpYVm4ybHRKSkRnZVA2T0JEQ3FBTTM1?=
 =?utf-8?B?L0VaM3NRNnZ5cVFkVnR2OUc2UFJiMTVvc09RTnRwS2VIZHhUR0kxTFRLam51?=
 =?utf-8?B?cXgrNkpaV2cySExIZWtpbVRaOWE2OVdYZGpGSXJTRHlleUFndnNSOUE4MWwv?=
 =?utf-8?B?NzNEMTdZazVkbm9tV0FuUEFnYTFMdGhpb1VVSDMvTERUMHNwcjNiRHJaa3Y2?=
 =?utf-8?B?MVhZeDk1bTQwMnRLU1B3a0tlUVo4bU40MEJ1dUNrS0ptc1l1cEE2MWJYeTJP?=
 =?utf-8?B?Q2p1aFRIT0dWWFhJQUE3Qzg5aTNyZkRscEZLR3puSkg4b3hkdXpHOG0yMndZ?=
 =?utf-8?B?TzU4aWw5WVVob1JGTXRxb29lVjEvTTBtU2JvMkRRWCtHTjRrbVpUZGU2ZEo4?=
 =?utf-8?B?Q1ZucE5sbmU4K0YzaFRJbjg5TmlrUEdKM091ZEhHTEZaaDM3V0M5VWszODda?=
 =?utf-8?B?Nm5tWWMwTks3REY0bkswdXhwMnBwU29sMnE5Q083SHFmczVwK29CeGwyWWY3?=
 =?utf-8?B?SFBVeTVsTzYvUnVLamU4L2dQNThKYitmSW01aHJVejNqbzNiSFBqR3YrQjJQ?=
 =?utf-8?B?Z3pjNmg5S3lHS3UwTmpTR1o3Q204NytVRVd5MTN1MWVLa2c5eWlDOG02Qmoy?=
 =?utf-8?B?ZVhmeVEzcG9PWmdXaW9IbzJZS3VseHZGQUdXbGkxYVE2SUF1ZFR4QkJwclFr?=
 =?utf-8?B?R3hIWEl6Q1FaUzNLcWRIQ1llYWc4SUMreUFVMHNMRTdPMFlKZWp1WGVpSGlI?=
 =?utf-8?B?dEFxSTFNOVFscnNTRk5EUWVURTJPMFpUUnpyUUVkVURqYmdPWDk0OU9QV0U3?=
 =?utf-8?B?TVRFaDBaYlpFZnlWWVo2d1BNNlhXZ05oblMvdnZNbzg1MXhKdXkxdz09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-B2+MTmvZU1CvTA2Hu5uY"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b89f8c8-b379-4f60-725c-08da1c9f24f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 16:11:47.0433
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BqqkCHLH6IfUzNlx6t8UVIZ63LFLxhuyi0/sCm2I4VHA16nU+h8YQMvqzJru2Zne+hJnzg5X9FLWYAzfrKqMJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5817

--=-B2+MTmvZU1CvTA2Hu5uY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2022-04-12 at 15:48 +0000, Dario Faggioli wrote:
> On Fri, 2022-04-08 at 14:36 +0200, Jan Beulich wrote:
>=20
>=20
> And while doing that, I think we should consolidate touching the
> affinity only there, avoiding altering it twice. After all, we
> already
> know how it should look like, so let's go for it.
>=20
> I'll send a patch to that effect, to show what I mean with this.=20
>=20
Here it is.

It's tested, with a few combinations of dom0_nodes and dom0_vcpus_pin
being there or not, and it survived (and behave as I would expect it
too) all of them :-)

I haven't tested yet (and can't test easily) the pv_shim case. I think
it's fine, but I'm adding Roger, to see if he can confirm that...
---
From: Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH 1/2] xen/sched: setup dom0 vCPUs affinity only once

Right now, affinity for dom0 vCPUs is setup in two steps. This is a
problem as, at least in Credit2, unit_insert() sees and uses the
"intermediate" affinity, and place the vCPUs on CPUs where they cannot
be run, resulting in the boot to hang, if the "dom0_nodes" parameter
is used.

Fix this by setting up the affinity properly once and for all, in
sched_init_vcpu(), called by create_vcpu().

Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
---
* Changelog is RFC!
---
 xen/common/sched/core.c    | 59 +++++++++++++++++++++++++-------------
 xen/common/sched/credit2.c |  8 ++++--
 2 files changed, 44 insertions(+), 23 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab678181..dc2ed890e0 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -572,11 +572,41 @@ int sched_init_vcpu(struct vcpu *v)
     }
=20
     /*
-     * Initialize affinity settings. The idler, and potentially
-     * domain-0 VCPUs, are pinned onto their respective physical CPUs.
+     * Initialize affinity settings. By doing this before the unit is
+     * inserted in the scheduler runqueues (by the call to sched_insert_un=
it(),
+     * at the end of the function, we are sure that it will be put on an
+     * appropriate CPU.
      */
-    if ( is_idle_domain(d) || (is_hardware_domain(d) && opt_dom0_vcpus_pin=
) )
+    if ( pv_shim && v->vcpu_id =3D=3D 0 )
+    {
+        /*
+         * PV-shim: vcpus are pinned 1:1. Initially only 1 cpu is online,
+         * others will be dealt with when onlining them. This avoids pinni=
ng
+         * a vcpu to a not yet online cpu here.
+         */
+        sched_set_affinity(unit, cpumask_of(0), cpumask_of(0));
+    }
+    else if ( is_idle_domain(d) || (is_hardware_domain(d) && opt_dom0_vcpu=
s_pin) )
+    {
+        /*
+         * The idler, and potentially domain-0 VCPUs, are pinned onto thei=
r
+         * respective physical CPUs.
+         */
         sched_set_affinity(unit, cpumask_of(processor), &cpumask_all);
+    }
+    else if ( is_hardware_domain(d) )
+    {
+        /*
+         * In absence of dom0_vcpus_pin, the hard and soft affinity of
+         * domain-0 is controlled by the dom0_nodes parameter. At this poi=
nt
+         * it has been parsed and decoded, and we have the result of that
+         * in the dom0_cpus mask.
+         */
+        if ( !dom0_affinity_relaxed )
+            sched_set_affinity(unit, &dom0_cpus, &cpumask_all);
+        else
+            sched_set_affinity(unit, &cpumask_all, &dom0_cpus);
+    }
     else
         sched_set_affinity(unit, &cpumask_all, &cpumask_all);
=20
@@ -3386,29 +3416,18 @@ void wait(void)
 void __init sched_setup_dom0_vcpus(struct domain *d)
 {
     unsigned int i;
-    struct sched_unit *unit;
=20
     for ( i =3D 1; i < d->max_vcpus; i++ )
         vcpu_create(d, i);
=20
     /*
-     * PV-shim: vcpus are pinned 1:1.
-     * Initially only 1 cpu is online, others will be dealt with when
-     * onlining them. This avoids pinning a vcpu to a not yet online cpu h=
ere.
+     * sched_vcpu_init(), called by vcpu_create(), will setup the hard and
+     * soft affinity of all the vCPUs, by calling sched_set_affinity() on =
each
+     * one of them. We can now make sure that the domain's node affinity i=
s
+     * also updated accordingly, and we can do that here, once and for all
+     * (which is more efficient than calling domain_update_node_affinity()
+     * on all the vCPUs).
      */
-    if ( pv_shim )
-        sched_set_affinity(d->vcpu[0]->sched_unit,
-                           cpumask_of(0), cpumask_of(0));
-    else
-    {
-        for_each_sched_unit ( d, unit )
-        {
-            if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed )
-                sched_set_affinity(unit, &dom0_cpus, NULL);
-            sched_set_affinity(unit, NULL, &dom0_cpus);
-        }
-    }
-
     domain_update_node_affinity(d);
 }
 #endif
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 0e3f89e537..ac5f8b8820 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -749,10 +749,12 @@ static int get_fallback_cpu(struct csched2_unit *svc)
=20
         /*
          * This is cases 2 or 4 (depending on bs): v->processor isn't ther=
e
-         * any longer, check if we at least can stay in our current runq.
+         * any longer, check if we at least can stay in our current runq,
+	 * if we have any (e.g., we don't yet, if we get here when a unit
+	 * is inserted for the very first time).
          */
-        if ( likely(cpumask_intersects(cpumask_scratch_cpu(cpu),
-                                       &svc->rqd->active)) )
+        if ( likely(svc->rqd && cpumask_intersects(cpumask_scratch_cpu(cpu=
),
+                                                   &svc->rqd->active)) )
         {
             cpumask_and(cpumask_scratch_cpu(cpu), cpumask_scratch_cpu(cpu)=
,
                         &svc->rqd->active);
--=20
2.35.1
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-B2+MTmvZU1CvTA2Hu5uY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJVpMIACgkQFkJ4iaW4
c+7jqxAAmHr6nXFy1JoGLBFR1v5eoU3mk5Sp8A9lSat1Wjn2AVykse4W7VabJjKL
cdFA26FNzjw4v2CqTDxrhcIMFhNYrDkrCsp+hqUH5E8hM8tZ+iDkeARVVzxqw5BO
lX8GzAi/sZ56R4YBRRkGByrUrgxljgqlVZFLvUWUjTMUxgvCCSOXyO/PRKXMlTa4
LetP125vZhemFbd31QduxLi17e/fqdAiABJniLgL5Fccn+wkmMgd82Wz7HNS/MzE
e1zT4T+zCcZKcVGqhVwmZWQPhYkT0Ym7DbKZMUOWUWkS86DzmVeX9eLeYkxKkkvT
O5HNldYNkcFL15s3CQoOg/h38BvZjEeOUKEa5P14ZqFMXztp7OoMpZXzOsLyl9wP
HxzICXoEYI/6eaqsBHwKMAeug6y/6EvGunC7qQ54YvsYq0UOPsS2uBy+v0vuS08A
GG8/okYkUTr9UobcXa5PqaAvP4xJek78zzNZm7YvfOgCQf4wErsyHyMxFIzaIPgU
JJoH67JnaBRCV767laGfJBTXDDV4z/Evff5ZOrQBBY+E2I/irnhLbiygTo/3fXRV
CkBnYT6nEfEJprdQJ1PPnl7kPj6QSTzsRcQR6jFajVWGpwQJoxY2Jmh6AgoOgp9f
YRs5Mhgf7nCM8A1Su1PmpOb+z9pPM1ttXNF1HPgzrDoqwrfZrWw=
=wJk6
-----END PGP SIGNATURE-----

--=-B2+MTmvZU1CvTA2Hu5uY--



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 16:14:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 16:14:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303730.518168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neJAP-0005MZ-TI; Tue, 12 Apr 2022 16:14:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303730.518168; Tue, 12 Apr 2022 16:14:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neJAP-0005MS-P6; Tue, 12 Apr 2022 16:14:57 +0000
Received: by outflank-mailman (input) for mailman id 303730;
 Tue, 12 Apr 2022 16:14:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vUK/=UW=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1neJAO-0005MM-4m
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 16:14:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b05cc9b9-ba7b-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 18:14:54 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-3EryQONNMhOiboyN2Wu0Pw-1; Tue, 12 Apr 2022 18:14:53 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by AM0PR04MB5810.eurprd04.prod.outlook.com (2603:10a6:208:125::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.28; Tue, 12 Apr
 2022 16:14:51 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748%6]) with mapi id 15.20.5144.030; Tue, 12 Apr 2022
 16:14:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b05cc9b9-ba7b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649780094;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=IIrKmEUjX6Eol6BqaFjqIGGwrzSg8BGGyIv99BLINxo=;
	b=XU6ZpneK/BhyPcFKtIxgdnscE//8Du0H3ts+YCA2F3sCoDeS8cXkxMFIEfPNBRx2h9zxys
	4Y4eZKyJ6+sLXmtqYFBvDiK0HEd5MPEY3TC629AtanGr6Qw8bvGJ4ZmLI8WVTFDKg+FlCi
	EVdkFigP53BzKMj4z1W3z/7CuWz8rQQ=
X-MC-Unique: 3EryQONNMhOiboyN2Wu0Pw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iQu62mF9/NL4F4EiB4DdO/fOvt1/qHeHmXutAqaQjQ/tOmBAdh4DgVGV1JSpE+OMItwt+I4+h6HKaZUDAsau+1ScpLgKuCPOe4YXdpZW8OA6sJ6/Qy6yIavq3M1Y7xpua62hHkbmzZwOhPGz+k4sSvlFHABN0UDHXHa7Qc+g3c2SeJIuszOuTLnrTxJVZcAoIMMDFYPVYPxGJ2YfN+3TunSBtt046W1tM66QtuGJc/VlCCHxCsn+g3ti/106Kcdp/SZxHVDpTvAMugWfhJ6xe6vfFA7S+6PZNk+iKr3NkXRoMcnD/69oiD2LNiXxVdwtQ5/GoFkmy8DXbdNsLY/C7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IIrKmEUjX6Eol6BqaFjqIGGwrzSg8BGGyIv99BLINxo=;
 b=ERYpfqlPyyzUC+yqisMjspAkvxS9y+qrQvXLpTaw5ktPv7i0WiyX75PFwyqY9NFcEvRxpzODfm4Z3AjeBTfUQyCKLyskF4L1GYJjBRa5i3HoSCREVA7KJCmie8BCF/7CdpKxMG6qxfMYH9G1J/WA4oPSpU0z7T7u11YEeUiX1Kmi6KQUYF/gQSK/2JulMAbNaymav+spiaih0PE2bOWKzwVWr3BWGfmdbNQ83M+C7x2O6kPu9W0NQ7Kgo6L2AdSqvi3ufJDWZ1RPsa8vKq/T82urkabxVvqIxVOiivlKd3jHzzxX6Or5xG5lPi/RD9I6gmkpUywpTY2R+K7LxWF3Pg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>, "ohering@suse.de"
	<ohering@suse.de>, "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Topic: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Index: AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgAAVUwCABn7lAIAABpgAgAAA2wA=
Date: Tue, 12 Apr 2022 16:14:50 +0000
Message-ID: <46feb71a14c70d24e894311e7ef9390064d6f437.camel@suse.com>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
	 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
	 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
	 <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
	 <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
In-Reply-To: <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ba8b8b73-cd1d-48fa-4acb-08da1c9f9285
x-ms-traffictypediagnostic: AM0PR04MB5810:EE_
x-microsoft-antispam-prvs:
 <AM0PR04MB58107D57FF45D987BE6C7236C5ED9@AM0PR04MB5810.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 fxEaXSweP/jWZjdPCqzKhKjJtKP/+5ogRuH4uU3kIk56J3pYy0TbWdX7tQy0wIT6P2VOxCFWwwsrct8eoMlJL8MUbD6nI0PEJLZUtYmTmXgC7Jb2qiYKBFKErzPm4mAm7ttq8Zdb6tdPMEJ2sgwQDQ6sFCc3w2LChbY4mikcsC3rOJCucSTVaQtb4QfI5sUOdUx9FwWzrveOQDw5XparWHmCi5RFNu8qrrRZq/k07RurSMsdQ8tzmHJkyEN5ANVakHfhoHqFz2/r/VVR0DiJbDqnBUvkpYMlwV9nhZBZKDfJ6D1aWCaGgRQnuG0oeR+jfbzTAXoxsHnsdOA5hDZB6eroNALxKFopipRTwV/EUS3KS68c2cV0s+b/gIcBFfRSbr6JsQk/wXzo8SAKc1plCQphlUakqZXJOmJHzKR1i9VV2L8NJep100Nmdo7IxtkN7ZV2trC3qMribxkRu2L1CzlI4f9tvOhAW95BcCZaqeHK/9H088boSOoGieZqoOfMrbbFl93AHiCqNC09xkvzUjuTBGxICGRSMa8hltjHNfU3P0262YB7mW7fqoJiv9REGMNMJQ0wE3nAOnpbpZIh0DVm8ZvHGvqFnM2rvWlv4JWYdPei0i+WOi5KV4iLGg5sWgkONUldyfCJPNKfRN8pFIgARcbpqWD1RN1gVAKr6i7K3YSKNlLguROT7CXigMNu8VLoXTstgV8ewmOFxZYE3bSfzPRK5sc+W761oUr5AsxXMQ1dx8fBMySown6yHFR3cnvJzexMT8PNNKX0hfNErHStSMEprbBNAWvNYSeLDl4q0SZ/PECqgxf9XVMfz3KY+DZ7LNEG89QDo6RMLzR6Pw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(966005)(6486002)(76116006)(66446008)(186003)(2616005)(36756003)(498600001)(6636002)(37006003)(54906003)(71200400001)(38100700002)(99936003)(91956017)(26005)(86362001)(64756008)(66556008)(8936002)(66476007)(8676002)(6862004)(66946007)(83380400001)(6506007)(6512007)(2906002)(5660300002)(38070700005)(122000001)(4326008);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Q2t0WjBIWkJrKzlxQ3JydE9RUk1OWm5BZFlkN01IbEtiUDJ5SXBiVC9aeTIv?=
 =?utf-8?B?eXBYZG9EN210ZVpqS2Y0MjQ4Qjl3WFk5YW9ZNjVQdWNrcGNDT2ROVkZOUm1H?=
 =?utf-8?B?WHZZMjRRcWZMeGt0TU9VRjhqVjFqYnNNdjc4ZDBZUU42eXAxc25pODVPUHNO?=
 =?utf-8?B?NnEzaHNXTlB4VUMvd21GVWtJWlRoZUZHOWZYaDNJc0Q3ZUNTaEwzeStqbmZT?=
 =?utf-8?B?VHFGMTIySjBXRW9MRUkrRmFTZm50Rml0bHo0MDBpMDZVWk1XejdKQXlHYVRv?=
 =?utf-8?B?Qm5tWlZlODNCVEpYWXNzR2Y5Z2c3azB1QmZHQ1d4dVR2UGZyd1B6akhOZm44?=
 =?utf-8?B?MnRHOVB3NlM0NERkQjE0Q0J1Y2pLQm5OK0E4TWhZL0ZHd0daZkR5bjYxYmZ4?=
 =?utf-8?B?OU1mOFZTVTd6eUlLaEZWaVh1ZHRjNUtvYnJERGhzQ2ozR0ZBdHcrbVRWU05s?=
 =?utf-8?B?UHVwaE42RXdoVlRoOUt1ZzdYbmZEWG84OWRpc3JsbG5MUlZUdEFRQ0cxRm5K?=
 =?utf-8?B?cmgyRkNHanpMNlFtcmxkQTdmM1hUZzBDVnJyNFNLekJrb0JrTnRqOHYvTGd2?=
 =?utf-8?B?NWNRRkl2WmZ5a3NCNHBsNXhJNlRMTnh0eUdnTFJxdjFISHZtVTBJQ2FmeHM0?=
 =?utf-8?B?VWlYUkgwNW1TRjRuQkg1d3Vsc3lUM2hkaU1haUxrNEdxWGg2dllkSkJoeGE3?=
 =?utf-8?B?emRpaHFqaVcyaXRZeXdOeDlFeUszWWF3OXpTeVJIQ3ozNmpVQ0gyc3hOUXFZ?=
 =?utf-8?B?ekxoSmZOTU1LS2lscUdCcEltNnFRV09RcGpkZTZrWlQ2bVpyd1lWdUdGZEMy?=
 =?utf-8?B?bHplSVFaamMzZnAyY2NvZDJWbEsybWY0elZGeFB2ajV5azd0bEhHQmNTUGhE?=
 =?utf-8?B?WUcwejFsaG5QSlNYRjlYZ1RXZXRCUXVSRVo4cG5ZTWd1aThyMkYzaTBRM2Rh?=
 =?utf-8?B?dzBuM1c0QmhTQ0VrWkhHSGh6Y1ZGS2p3RkhLUTZYY3hxT0xmeElWdmYyUTBw?=
 =?utf-8?B?RmFOOXBxeDRZakdKY0pnSDJReXY1SG5DdUJmVjAxVFZUUHVyUEVqSDE1OTI5?=
 =?utf-8?B?V0psV2JoVFA2cU9QZldqd0cvNUxsd2dMVVd0L2lOTkUrK1JHS2pzSUZZaDdu?=
 =?utf-8?B?bjB1UlV6Y3FHQnRsdFM1cHZLOUlkSVk1Und5M3NEL2VJbjAyTVQ2Z3J2NzAz?=
 =?utf-8?B?aG1JRTVyWFZpbGhDVmxhNWZzeFVQS29Qb2JSbFFFcUVqRzFIZnFYemtlM2dk?=
 =?utf-8?B?RWljTXNnVkMxaFZGR0VwOEdyUEFoTjFtNDNhYW5kRTFLWEM3MDRONGFHOHpy?=
 =?utf-8?B?bk85M0tJSUNrMUJ4UlI3U2dYc2pmRlVmT2YrOHd6MlVFTnNHK0xHd0kvdkdD?=
 =?utf-8?B?UHhySVdFMG0zVUMwYWVYOEd3STk0U1VDVHV3VE1YSkRtTUM1Vlh3T1h4UXVE?=
 =?utf-8?B?azJFVk5zdm5aU2FWVjVBWWh2QS8vZnVBWDBYWkhSdEEvc0tLMmc4TjhLREJL?=
 =?utf-8?B?bm1Yc3FacG9MS0xuNnliZm15bXphYWhDWkZPOVc1WjNTbEFOcHlONlpwYUty?=
 =?utf-8?B?SzlrU0tMWGpoYTNnWVNNZUsxRjlHQ2R3SnI2N2xxQVpCY0V6YUlTeU1FS1JJ?=
 =?utf-8?B?OWliVktCTEl6a3g1NDVuYUNYaDVCV1JncVBlWWZLSEhUTGRUckFWNjEvSGZy?=
 =?utf-8?B?amNWWFdtd3FjTnBaR1ZEK2p2dVAxbWg2bU42bEV3L3F5dmVTTUlkK1V2SHlP?=
 =?utf-8?B?V2hCRS8zSS9pUHo5TXpiT2FoMG80UXB0MjZRT2x0cTExV1dmTVUyUEQxZzZq?=
 =?utf-8?B?QTBKMEFObERpT2xROEFKMy85K3JmK21wMUVIWFB2NWRQbG9CR1hhMjB6VXZk?=
 =?utf-8?B?ZDBQN0wrWDFxM0tJeXBiNUpvYjJLTzNGZjc0T1BRYXVlM3F0Z1FEeHU5dk8v?=
 =?utf-8?B?Q0tNcThUVldXRkNBdUo2NjJVcEpnYS9qcmFUTjJFaHlyNHpNQ291amdxQlBw?=
 =?utf-8?B?RmJtNDFuM1N3VjJZT1pKMWszZ2FuT1J5V3pDeEtPYWpaV2FMNDlCbkRpV0du?=
 =?utf-8?B?ZEpQeldQK2RuZ1lueGxZaXpMbk1IMVMrOTRERTZkdTRJcEdQSkNDZ0N3S3Zx?=
 =?utf-8?B?T1JxSkNCeW9tMmFYWEU1VUI5Y285Y1NuSkhwZXd5ZDBrNHpQTXJkSVB6WlRR?=
 =?utf-8?B?c2VPVHpBQWhaQWdWYUQ3TmdWZjUvdUllQmQzL3RGMTY1OENJNkt5Snpwcmpz?=
 =?utf-8?B?ck8wdXFYY0xQZXJzeTZYc2plZ04xNDF0SkJmS3Y2NmZTZWVBMHplZ0RaN0Fo?=
 =?utf-8?B?OEJ2ckdkV2NoKzRyVm1HYVJWNUxvY29TUzBxWGsyK1pKUWxzSVROQT09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-uUlL9OzGyMEhyAQEl215"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba8b8b73-cd1d-48fa-4acb-08da1c9f9285
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 16:14:50.8527
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /HpG6WAG9Qdo9kvcMtsKWsgNJJ5RKIvEd6Spwxgb4bX1cslYc6/1l44vnk3NxlKvzoIwO7YRdeYcoKj4asxo0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5810

--=-uUlL9OzGyMEhyAQEl215
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2022-04-12 at 16:11 +0000, Dario Faggioli wrote:
> On Tue, 2022-04-12 at 15:48 +0000, Dario Faggioli wrote:
> > On Fri, 2022-04-08 at 14:36 +0200, Jan Beulich wrote:
> >=20
> >=20
> > And while doing that, I think we should consolidate touching the
> > affinity only there, avoiding altering it twice. After all, we
> > already
> > know how it should look like, so let's go for it.
> >=20
> > I'll send a patch to that effect, to show what I mean with this.=20
> >=20
> Here it is.
>=20
And here's Jan's patch, ported on top of it.

As for the one before, let me know what you think.
---
From: Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH 2/2] (Kind of) rebase of "x86: make "dom0_nodes=3D" work wi=
th credit2"

i.e., Jan's patch, on top of the commit that unifies the affinity
handling for dom0 vCPUs.

Although not technically necessary any longer, for fixing the issue
at hand, I think it still makes sense to have it in the code.

Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
---
* Changelog is so much RFC that is not even a changelog... Jan, if we go
  ahead with this approach, let me know how you prefer to handle the
  authorship, the S-o-b, etc, of this patch.

  I believe it should be From: you, with my S-o-b added after yours, but
  I'm fine being the author, if you don't want to.
---
 xen/common/sched/core.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index dc2ed890e0..e11acd7b88 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3416,6 +3416,7 @@ void wait(void)
 void __init sched_setup_dom0_vcpus(struct domain *d)
 {
     unsigned int i;
+    struct sched_unit *unit;
=20
     for ( i =3D 1; i < d->max_vcpus; i++ )
         vcpu_create(d, i);
@@ -3423,11 +3424,20 @@ void __init sched_setup_dom0_vcpus(struct domain *d=
)
     /*
      * sched_vcpu_init(), called by vcpu_create(), will setup the hard and
      * soft affinity of all the vCPUs, by calling sched_set_affinity() on =
each
-     * one of them. We can now make sure that the domain's node affinity i=
s
-     * also updated accordingly, and we can do that here, once and for all
-     * (which is more efficient than calling domain_update_node_affinity()
-     * on all the vCPUs).
+     * one of them. What's remaining for us to do here is:
+     * - make sure that the vCPUs are actually migrated to suitable CPUs
+     * - update the domain's node affinity (and we can do that here, once =
and
+     *   for all, as it's more efficient than calling domain_update_node_a=
ffinity()
+     *   on all the vCPUs).
      */
+    for_each_sched_unit ( d, unit )
+    {
+	spinlock_t *lock =3D unit_schedule_lock_irq(unit);
+        sched_unit_migrate_start(unit);
+        unit_schedule_unlock_irq(lock, unit);
+        sched_unit_migrate_finish(unit);
+    }
+
     domain_update_node_affinity(d);
 }
 #endif
--=20
2.35.1
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-uUlL9OzGyMEhyAQEl215
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJVpXoACgkQFkJ4iaW4
c+4ZSw/+JH8ZtZN+e0Fc8Wb8upIBWThFSmfTbgrYKuQdAhDCAuPZz114lNxGVzNY
B+4y7ZHqsNk0ZjChcLbr2x6RUcu6NooQt32JKmr4kBpaGdclb1E/T/bYVW3Hhkd0
/OPJEGLuqPxQ4sVZqK0VEkASketFhfP+UFn65Y1KeLsRub63n4QpWaEojr19X2Dg
kgGJlwl8+w6C7Qeu8W5oBUu3xh7kJ9lVobtZ9YkPflOcUQBnZjpM7xENoO8qTVxK
HM5erz0WkiOSjPMcXI6h65GnHAubg6EiUpZ4lpDwesIkCnT3yCG9lWrBcAvpO+S1
ik3iUxFGpdLEx5YEg7pUSAALulEiudXIL3cDdJFX81nQ+b9IggCfVGYfGIJ/+L+w
Np5bnY3Hkmw7ALxvdsWTH18Zpey66yXlZrm+GtEv6m1Z6Nd1FPIlvPXJz1Z6pVII
hLLCRQBVLJ5OcGD7msyBz2Ej8a8rpFyEDM69KdS1eO7yd768Ty0etXEjNEfTYFvy
UtOgqL3T1SxnVwUhiDi3sRFm7ETXeyM1t6X9vTGeM/tiqVPnUytRR/asPiFIU+TX
pwmZVM5LiFaI6oD5CrSO0aMaNbmvoYREN6SqsMh9nDrwIs3jXAm9MhZqMmlzVWKg
kPILtfzk01di+Xie30xantNawHh16XL5gge2XsmdKo6bnoQcZL0=
=wtkS
-----END PGP SIGNATURE-----

--=-uUlL9OzGyMEhyAQEl215--



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 16:17:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 16:17:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303735.518178 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neJDE-0005zX-9t; Tue, 12 Apr 2022 16:17:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303735.518178; Tue, 12 Apr 2022 16:17:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neJDE-0005zQ-6u; Tue, 12 Apr 2022 16:17:52 +0000
Received: by outflank-mailman (input) for mailman id 303735;
 Tue, 12 Apr 2022 16:17:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vUK/=UW=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1neJDC-0005zD-Ls
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 16:17:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18960467-ba7c-11ec-a405-831a346695d4;
 Tue, 12 Apr 2022 18:17:49 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-VUkk-cx7MHy8dJXosEnCxQ-1; Tue, 12 Apr 2022 18:17:47 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by PAXPR04MB8176.eurprd04.prod.outlook.com (2603:10a6:102:1c9::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr
 2022 16:17:46 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748%6]) with mapi id 15.20.5144.030; Tue, 12 Apr 2022
 16:17:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18960467-ba7c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649780269;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=sWERHgfV9sV13JTJfNMZxFStRVYvJ2bYXVFtyWmir/E=;
	b=nwYRPngWPxN4yCEY1PXcg5gE9Fy7Q35h44Ox9PXLSPkBJHg0kYJb27Zqs2bf2VbfYE4CHd
	fC5WlvXM2btZ80ZuUhbsslV4D8D4UA/LiIK4sRtquq4RV7ZkGmWDrch2oRgJCpXdpmDLvF
	8GBMtyI78OBpvvMGEEt0jyj/le5bBvQ=
X-MC-Unique: VUkk-cx7MHy8dJXosEnCxQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h1i6+C9WuFsN30dfmLZzyBu09FxnImpOF2EC/UTyaEujtCE2dJz5yoEXPmN6t5/lW9A75ZKKsTfD/ruMoOBoq7t5G1Fy+9EacPOEbR9yLLBsXAQaWa7CF+uv+qyDkVk5BD7kez3fDxSzCgPxP4c4oqer2Ih2ZXAIUge+b8ykx9QbzZJguhyx0Uha+UtwLHVEALLeSN2Wdk7/Ikb72JbLNtlTvsFwlxBbbRm0Q7Op09y3TP8IyJXgchmk5SBtONhKpqbMR16PnDOBrH8RMZ16tHwr1sEY59F7JQ2PdGQhTN/YZBGzP57HjFWWaavAsWlrLJ3y71+mFRGxnnfZqUndSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sWERHgfV9sV13JTJfNMZxFStRVYvJ2bYXVFtyWmir/E=;
 b=YTbzatTFok7GR5aJNFPFlTfjLcW2AdiKUcyiRFEQMLcabBlLdo4DqdHzv/4lbfyqMGtFArS1DliaW7kXtIlra2iKhEUOFMz/3ElZsCS2sD254y9emiGMka6Vzfue/JItJfxvwejYjEalW9/hxL0n7lVPd7L5ir7SJAiT3oiqvOJP3oT6gdZpjK6q8twWL6k20o+w29GYM2qnCI8Y/Kg/kJTCoTBFCzkio0RtJVEOSBgv+sDpmdGb1AEl1nwxqzYmkvdyi3dsg6ZCdbjZa0gNBoYhu195pFcCGJsyRvddmLrIJOuFlk9S7FWBG4sJjThJSTudjYUrPVvSKzXczLHBAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>, "ohering@suse.de"
	<ohering@suse.de>, "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Topic: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Index: AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgAAVUwCABn7lAIAABpgAgAABqgA=
Date: Tue, 12 Apr 2022 16:17:45 +0000
Message-ID: <6b17c74ff6112a6b165ffeeabc2d9b29f5697583.camel@suse.com>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
	 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
	 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
	 <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
	 <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
In-Reply-To: <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b7707c1b-7d85-463c-7533-08da1c9ffac1
x-ms-traffictypediagnostic: PAXPR04MB8176:EE_
x-microsoft-antispam-prvs:
 <PAXPR04MB8176F911208AE1B710A7E3A2C5ED9@PAXPR04MB8176.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 YEubphEMa6J14+m6rDMcCW+eW8YYWSHciWUEPa7crG8zC4X5qIR31heQtiR3n231SxltaYUwEOfHNbGZN4CfWYlV/akY0zH/yalZnvOoGwypBkNXd3EqrxC5gm7nhhjhDoiPwqoixOes862fqtwtw86BLMUbRkuos+Lqn53vPpTVpkjoD1CT0+/eUBLCbQ6Y6ACpVcxz20gCHBCWAnpJn2dB+gN/U78yCD02myVDZWMet+xt6dgPCBiVUfWqdoGZ4pelP4v2ZLGoK+oBpR5ecPgrlOzB0nbjC+C5TmCr/qOSRlHJKk7RhQkfk1UpevqUfdJqN7Ia1EgdwbRNbS2Y/NFtGUeSK8IKzMzGJ5ywVHYnEyHQs7b1fxLpH/G7timTCkVbErME0SK9NsiW9WHifYFh+qqc0FcCiMk23ORcSvqb+e9eOTw1QNVve7SC/ICKdyt4IbVafS8aEoGydRXbQFaFw4/3lCDabAgMGVhBUDfvomWAj4tvHKrRnOVTIfe/YsakWLK1A/g/VEne5vzqiuk6KB8P4QDg316QwHZP47AJfHh2Dj9xRWtmWAESsdfSt9JSCZCK0StCDYtkpe9QDHnv2Q9nllyhnwBtXsnxFBrrGSVuUJ7nTT3UkT+InF/bAkP5Yjfk2mqHtNrYuMFCs8UJ83Ojr1D74YMSzYppmD/Vb1lvWuRc1rQepg12M3100zMzMl5lx/9HlgY60gN0lVfjGZXzwWzTuK3LooxJnZZZ+3jWQzyXP1zj6RxCTVSQWOXjGO8L+4lHsmkxAOQ+hmaZpUJcoHECVFtGbhHdCU4Agjj22rLWE3YQl+56MRVF2N8bOPMttuU5w/B3WKJGSg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(2616005)(54906003)(71200400001)(6862004)(66946007)(2906002)(66446008)(37006003)(316002)(8676002)(4744005)(4326008)(66476007)(66556008)(76116006)(38100700002)(36756003)(508600001)(6486002)(966005)(122000001)(186003)(64756008)(6636002)(91956017)(5660300002)(8936002)(99936003)(6506007)(6512007)(38070700005)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dkJxVkprS2JiaHlwd280TUQrMHF2VHl2ZHFiT09RbHFQZXdzTFJtSy8vN2hL?=
 =?utf-8?B?M04zclI4eXZDNkFIOUx2dzNUNmprcVoxWHZ3Wno1Y3NteHJCd3ZzVHh3dDJN?=
 =?utf-8?B?N3E4bTN1a09pSURETGJrUURsbGljSFZLNzZRbHpzT2R4aFBIUWNTWnc5dity?=
 =?utf-8?B?b3JybVo1MFU1U3RaZnVCMU5pWm1pM0JIVjNvQy9wR1ZROXpxSHczTFBmWEl1?=
 =?utf-8?B?MUZGaHp6Skp5LzdpUDh6d29NQ0tRS1VYWXdoL25hQ0ZTN1hzYXlicDhwbyt3?=
 =?utf-8?B?akFQZkFvK2VlZWxKS0RIZ1FpRktBSlhyVy9HYXdoNzFHdWpWaFEzMlN3Qk1m?=
 =?utf-8?B?YXY5QTErblJaQmxDOHhUQ1g1Q2lxaExWOXBqdEFLVmxNeGN6SW5HN0J3Tzdv?=
 =?utf-8?B?Z3VlS1MzQWZEY3NTNWFNQ3pYV2V3UkdNSUZKRXlkS0pNSXFPc2NnVTFrTTJH?=
 =?utf-8?B?WmU4aUczN2liRDBVYitQWVpkNTI2ekI3Q0NuSDBnTks4REVmVjhWeG5WMXR2?=
 =?utf-8?B?cHBManpzUGJiWkozbkxlcVY5MzJkaWpqZTF5QTJ3NkJIM053cm9XbGdmNkVB?=
 =?utf-8?B?WFdURU1WZ1NTVVVlM2NtM010SUk1Ry90VVo0dWYwZEczeFpxMVpJU09PTXlS?=
 =?utf-8?B?eThEaFRmK2piSWZENVFJVjhJYXhVbndmZnd1ZHp2dE15czVvOUJIdmRSaEoy?=
 =?utf-8?B?UzVwdTZudjI4V09RcEJIbXFRa3hzZVhvcGZ2bzRCVVFEcUY1elNraStEcU9y?=
 =?utf-8?B?bVVTYjZLc2ovUnRmTHRhYitjVnlVZlRqVXI2emhFRHQyczRvS2lNWHRRcC9t?=
 =?utf-8?B?WUhPSTFJcWtiUEpKdW9EWDBZU0JxU3cyTWVVZ1NCTi9LUjE4VjVyM1R3Y2hD?=
 =?utf-8?B?VlZyYnVCVFdYMkNycWE4bzI5azlKQVl2M1hsTUFja0JMdGlhano3ZWQybEU4?=
 =?utf-8?B?UHVQOHYrUWNnRTRGbUcxTmN0S3haMFlLc1ZlenJrVVlUbjNVRTRibk93bDZi?=
 =?utf-8?B?MjIzTTk5bkdUZ3c2WE96c3VrdW8yYnNjdXlnS2lvSXV5bi9zS0RtOG1TMXlP?=
 =?utf-8?B?ZXRlSHJ1amdsczhTUFVjQjBDZUdxYTJyVG92VENtclc5b1d4L0lTQ1ZwMjlh?=
 =?utf-8?B?SmlNQVVwRzFkc1lTRGJLbjhhUVNJU1JQY3lGSktvcXRGOTRrb2xBK1BKVEVr?=
 =?utf-8?B?VXF3cE5OZ25kTXdpVDFuMWJXTFV2NUF5Z0UzQnBuK3VGMFZ3ZnRiUE4yMlhX?=
 =?utf-8?B?REJsenFSSG8ybHdRYkY1aDdzemI4ci9ETzBabjRzVldmYUlkVU1oQk9JVnlB?=
 =?utf-8?B?T1A1YU5zTUIzU3lrYStlSVVnNEF5bWlKdHBNY3lMakxiRkgxcmMzRlZPaFg0?=
 =?utf-8?B?dDRqd0tNSDJZTDd0WWFZY2hINmtUbjFhWUU5WUk4SmRuQUdpV1YxRG1mUkY1?=
 =?utf-8?B?K3lraWZ5SE1STms3SklpaU0xTlNYTFNPZDdMTmpYd3FBNHV1NXcxM0V1SUJy?=
 =?utf-8?B?eEl2azdUV1drR0J4eW5GSk1FTFZCcEdSVlF3ZC9SYzMyMXZjMFZTZU9WSEN2?=
 =?utf-8?B?YkNmb1FQM3hkZVB3R2hNVm52djVuaXUvTVhabWszUjlXT1RuaUtsVXdwbGQx?=
 =?utf-8?B?bFNwZlEwZjFCOE5EV3ZWK1ZGMFRwaW40RXlGTVhpTnBXQjlPUnlHS3dRWkdm?=
 =?utf-8?B?YmZ2QXRoaTFzbFZoZm9POHZ0K0IzOTRUM05BbHdUTEE5WnBraGZRWjRQeEZh?=
 =?utf-8?B?SnY0dzRPOHhxb3dJWXFQdVhBTFd3ZGY2SFVQejZmd1pxNVppazhyV3dSNCs5?=
 =?utf-8?B?M2JHTm8wbWN3OSt3NG9YZWM0QWFoVEV5Si9WWTVBRWZaYlRwckd4Mjh2Tmt3?=
 =?utf-8?B?YXdybEYzS2poUnY1UndwVGZFcEtwQXVqTGFvbWVKYUtiVjVIeGNpcXdZRk13?=
 =?utf-8?B?YWR3UEozMHFqZXVqZHRjK3RxNldkZGpxdlJEbjNWd2FyZnVIRDBhQ2NZa2xr?=
 =?utf-8?B?Zlp5ZWpDaUtqQjc4OFpiU2V3TWQ2ajU3R0p0SVQ1ZGliMEhLVGZjTHdRMm9v?=
 =?utf-8?B?cGVzTFhsSldTSFNUbWFlU1pUY0ZZUk5idWJjeHB5NHlUbkw5RHpBU3NBMnUw?=
 =?utf-8?B?cDNXVUQ0elBISVJRR3FVUmVaN3BOb2RDTjdzc1Z6MGlPQXBoNExlUGVuSHF5?=
 =?utf-8?B?Y3VIaFhBZ0ZzYnZoZVRid2xkSWFBMVhGVnp3aEtyMFJTdWhiRWZJSXNpeWdj?=
 =?utf-8?B?b2lHRmpEVStrWnA1NVl0cW1ReEdScGgvVzR6T3BPNHdxRkwxaFdhZUdWSUp4?=
 =?utf-8?B?OFltVWJpUU5iSE5YRzRENk1nYjhrdVZ0WjJZT0tUMitoVHJmYjhOdz09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-aZUWLzv26yiAiYaA7vcC"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7707c1b-7d85-463c-7533-08da1c9ffac1
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 16:17:45.7613
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TVQQxqrpQQJ/S6nOzLmQ0yER4ejV7CD8+M26oKbnh9NfxsOt++2x560rFoEJW18aNLY0jPo1pZLOsjXXKj7MVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8176

--=-aZUWLzv26yiAiYaA7vcC
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2022-04-12 at 16:11 +0000, Dario Faggioli wrote:
> +=C2=A0=C2=A0=C2=A0 else if ( is_hardware_domain(d) )
> +=C2=A0=C2=A0=C2=A0 {
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * In absence of dom0_vc=
pus_pin, the hard and soft affinity
> of
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * domain-0 is controlle=
d by the dom0_nodes parameter. At
> this point
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * it has been parsed an=
d decoded, and we have the result of
> that
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * in the dom0_cpus mask=
.
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( !dom0_affinity_relaxed )
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sched=
_set_affinity(unit, &dom0_cpus, &cpumask_all);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sched=
_set_affinity(unit, &cpumask_all, &dom0_cpus);
> +=C2=A0=C2=A0=C2=A0 }
>
Oh, one thing: AFAICT, it's fine to use, e.g., dom0_affinity_relaxed
(that iis __initdata) here.

But I'm never too sure whenever I touch stuff like that... Is it
actually fine?

If no, I think we can drop the annotation, or add non initdata-
variables.

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-aZUWLzv26yiAiYaA7vcC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJVpikACgkQFkJ4iaW4
c+6E1xAAsl66dPandQ1rBeuHy2wgiXKEiURGrDREbJOeRKSYl8sX3GuF0+t5HG3J
nvnsJnP6NDgZPjPW66tet9ZfbIEOT3JQkyQeiZ+hBZp+vr8RAEsso0Z+hW3i8oSe
5HUwXOaBmcOn1UvHWXfqw1fAE6iZ6oTYHNOA3U/cGRIk8mB/jCr+2REhwYwm2EEN
H4l5/gDbH90AU1LseBBAVyQYWQxudpu2o+VfBQKW/+i4P0fWRPbqxyMERW1R09zn
4RyoAzZNyIZkpyVVqixmqc2B361oCBcvnLfowOG7SPoy/VjTzAXtPT5SrRT6et90
VxsQu9/zShD6JC+NK+JGq18xboA+TPvTOX3hsFVPRWHkIcGnPC2hxIwCHnx/X7bh
19QuZPqhNGSUzjZcQciQHHU33sjaI3SFQ0VvxXtHRxRjF5xHXhG/JJwacQ0kHQRl
+Rex1EqBx5992KHeiTqyXg5vRgtOuyDZhULiJ2Km5sJBZFZ1fLwyFfqfz+0s5vBb
NZ5DX3Kb2H4F117GgIjFgKBgF5nNtoRnlhUPmdDM+10n42RDKBDnqfGopJjh0IvV
J+odRW5EcfYS4kF8wzGMrJ4f4Dp8S7b2RSsT55i6SwkfkOlJ6n383k4t0ma1JpHx
YMr78rK2YpPzhIXYT7CaQ20nN5qwLBfi08l7E04gkD7ZN1iGL3s=
=xdJZ
-----END PGP SIGNATURE-----

--=-aZUWLzv26yiAiYaA7vcC--



From xen-devel-bounces@lists.xenproject.org Tue Apr 12 18:03:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 18:03:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303759.518198 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neKrY-0008Fd-AJ; Tue, 12 Apr 2022 18:03:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303759.518198; Tue, 12 Apr 2022 18:03:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neKrY-0008FW-6B; Tue, 12 Apr 2022 18:03:36 +0000
Received: by outflank-mailman (input) for mailman id 303759;
 Tue, 12 Apr 2022 18:03:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neKrX-0008FM-DG; Tue, 12 Apr 2022 18:03:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neKrX-0005XR-AD; Tue, 12 Apr 2022 18:03:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neKrW-0000V4-MV; Tue, 12 Apr 2022 18:03:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neKrW-000409-Iu; Tue, 12 Apr 2022 18:03:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=68yafnlXWbVyuV02r4mWzHDh6QZlWAp/e/udn3gXS/8=; b=RQRXglyLAPVsLFEhox1PxIA3Fi
	tjMhrd+SmNm53ouyWhx9gTTJdaLDoWBHIV2StSQ3ZMtwnxJtQ+/7aymIYM1Uzs3udgtJbbA1hetiQ
	3ZvqyD53GPnAPw3l6jyU79uWl5eTw4IiLPeB55WbLq6eCXhF8zwt/tROqb+ooX1Z2gyc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169335-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169335: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f5508a91e306dd183ab971be438b9667c9890a1d
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 18:03:34 +0000

flight 169335 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169335/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f5508a91e306dd183ab971be438b9667c9890a1d
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  345 attempts
Testing same since   169335  2022-04-12 14:41:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5009 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 18:44:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 18:44:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303770.518214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neLV4-00048Q-LL; Tue, 12 Apr 2022 18:44:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303770.518214; Tue, 12 Apr 2022 18:44:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neLV4-00048J-GL; Tue, 12 Apr 2022 18:44:26 +0000
Received: by outflank-mailman (input) for mailman id 303770;
 Tue, 12 Apr 2022 18:44:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neLV3-000487-0Y; Tue, 12 Apr 2022 18:44:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neLV2-0006MQ-UJ; Tue, 12 Apr 2022 18:44:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neLV2-0002XS-Hr; Tue, 12 Apr 2022 18:44:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neLV2-00061K-HQ; Tue, 12 Apr 2022 18:44:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=E5YtqrHlYDofiAlU/JoqkPZ3sYZOVU9Jc6Ul8Ql2KKI=; b=tvTOQJLE52QovEyEkckx0pWMVv
	MeY9FY33DiypUc4wFWm51oUMQR22gYx90ECXFV3KQTiUJSP1DR6cJOX4AEuncgycTBJgqzibpFlKY
	EWCD1WsXyPQmv7AJk3SaojG4qMM1yMfFS846Nvp7SyaSG9hRlTIn4Bhast3q90YWe2G8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169328-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169328: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5b752808ff37b7c819a26fd76329ef329c42774f
X-Osstest-Versions-That:
    xen=f44201124e8713f6eff80f349351b5740001c6fc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 18:44:24 +0000

flight 169328 xen-unstable real [real]
flight 169337 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169328/
http://logs.test-lab.xenproject.org/osstest/logs/169337/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169337-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169318
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169318
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169318
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169318
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169318
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 169318
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169318
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169318
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169318
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169318
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169318
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169318
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169318
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  5b752808ff37b7c819a26fd76329ef329c42774f
baseline version:
 xen                  f44201124e8713f6eff80f349351b5740001c6fc

Last test of basis   169318  2022-04-12 01:51:50 Z    0 days
Testing same since   169328  2022-04-12 09:38:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Doug Goldstein <cardoe@cardoe.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f44201124e..5b752808ff  5b752808ff37b7c819a26fd76329ef329c42774f -> master


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 18:50:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 18:50:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303779.518224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neLb8-0005Xp-At; Tue, 12 Apr 2022 18:50:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303779.518224; Tue, 12 Apr 2022 18:50:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neLb8-0005Xi-7f; Tue, 12 Apr 2022 18:50:42 +0000
Received: by outflank-mailman (input) for mailman id 303779;
 Tue, 12 Apr 2022 18:50:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neLb7-0005XY-0t; Tue, 12 Apr 2022 18:50:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neLb6-0006UN-PS; Tue, 12 Apr 2022 18:50:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neLb5-0003Bt-NV; Tue, 12 Apr 2022 18:50:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neLb5-0008Dq-N0; Tue, 12 Apr 2022 18:50:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hMoVoTbS3YJZIBTUSby9CdC8eMpfXLbZKoeCQ8hDfbA=; b=SEvGBJDEUIZdrI3JRm4noA8jhp
	JXbB6/hVBJ1mJIPuLoPAUq8mZkgJbqp3q43bN5yanagRA/0xX0vs/Tk1gL/jDLqgNLUIE1+jL/j9h
	KE6X410GL3M6XSx1OWaZN4p91LV8WlsheNTgT+PzWFofvqACrJkPgt0BrvRv/6HlZGYA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169330-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 169330: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=17848dfed47f52b479c4e7eb412671aec5757329
X-Osstest-Versions-That:
    xen=eeaf24ccedf79941a4d1511daca4966b4e03cb91
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 18:50:39 +0000

flight 169330 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169330/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169241
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169241
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169241
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169241
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169241
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169241
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169241
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169241
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169241
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169241
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169241
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169241
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  17848dfed47f52b479c4e7eb412671aec5757329
baseline version:
 xen                  eeaf24ccedf79941a4d1511daca4966b4e03cb91

Last test of basis   169241  2022-04-08 13:36:36 Z    4 days
Testing same since   169330  2022-04-12 10:36:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   eeaf24cced..17848dfed4  17848dfed47f52b479c4e7eb412671aec5757329 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 20:14:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 20:14:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303792.518238 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neMtz-0005DE-FT; Tue, 12 Apr 2022 20:14:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303792.518238; Tue, 12 Apr 2022 20:14:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neMtz-0005D7-CY; Tue, 12 Apr 2022 20:14:15 +0000
Received: by outflank-mailman (input) for mailman id 303792;
 Tue, 12 Apr 2022 20:14:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neMtx-0005Cw-Mt; Tue, 12 Apr 2022 20:14:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neMtx-0008Jp-Ku; Tue, 12 Apr 2022 20:14:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neMtx-0007zV-8D; Tue, 12 Apr 2022 20:14:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neMtx-0000jp-7O; Tue, 12 Apr 2022 20:14:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7yQcsTqoBqTWhKyPpjfkb3wtMo0IwA2uIoXfDevUO4s=; b=BwtUGVZ8vQ0NQ7jeLQKRyliggP
	d03bQY/yCTcuAisbheAWst94UC1jwopytZ8hkoYQ66lvOg/r5iIquBhGR6gkfjhBaD2Gg+l2xZEPu
	BdxV9Zjt3e6/Tpl6m7Lnu57BLRWbGr/VRlJNkegUmMheTKftxWcNwwCq8VHbWGp6MLXM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169338-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169338: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f5508a91e306dd183ab971be438b9667c9890a1d
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 20:14:13 +0000

flight 169338 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169338/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f5508a91e306dd183ab971be438b9667c9890a1d
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  346 attempts
Testing same since   169335  2022-04-12 14:41:55 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5009 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 20:40:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 20:40:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303801.518250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neNIv-0007eK-K4; Tue, 12 Apr 2022 20:40:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303801.518250; Tue, 12 Apr 2022 20:40:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neNIv-0007eD-Fl; Tue, 12 Apr 2022 20:40:01 +0000
Received: by outflank-mailman (input) for mailman id 303801;
 Tue, 12 Apr 2022 20:40:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=URkf=UW=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1neNIu-0007e7-LI
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 20:40:00 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7849043-baa0-11ec-8fbc-03012f2f19d4;
 Tue, 12 Apr 2022 22:39:59 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 38EE761C14;
 Tue, 12 Apr 2022 20:39:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37BC2C385A5;
 Tue, 12 Apr 2022 20:39:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7849043-baa0-11ec-8fbc-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649795996;
	bh=/igA5A7Qbzc8ri3xw14JcLzQM47CuuY/Zi/uRXf2ehg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=pvZ97SCPpg678+TeoezCN3WkkfwvpzSZLH1d+H28Wu2K5cLgum8q9MOyCCvag2cs9
	 jLOMjJ5sLn1XO48nm4820qdXvju/FRAt+EZKo5g0zq6tyxXcz6dOjjF2U9PWzqRGVh
	 fvxVvslnT9OHdlmol0wGo0Yro2tIiJvFqvm/TVFq469cJOYOy8ciXDAeXMTgSkgE5Y
	 JF2E9AGVjx8Sd3RKWOeOBcTp4HsbMEB/gcq2jp41XNx49biLgyyQb4GBh5C8tDMHKP
	 I0u8NaMtwfAN+rPsS42HG9F3tUVyAo8nnBLf5m0etSrT+E6H54joPl1sHkV58sE3lr
	 +HbqTNwQXYp5g==
Date: Tue, 12 Apr 2022 13:39:56 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org, 
    bertrand.marquis@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
In-Reply-To: <0210f3c6-0f06-4ff5-9f66-8410fd540171@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204121332460.3066615@ubuntu-linux-20-04-desktop>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com> <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop> <0210f3c6-0f06-4ff5-9f66-8410fd540171@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1475397912-1649795812=:3066615"
Content-ID: <alpine.DEB.2.22.394.2204121336580.3066615@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1475397912-1649795812=:3066615
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204121336581.3066615@ubuntu-linux-20-04-desktop>

On Mon, 11 Apr 2022, Julien Grall wrote:
> On 09/04/2022 02:00, Stefano Stabellini wrote:
> > On Wed, 23 Mar 2022, Rahul Singh wrote:
> > > in dom0less system. This patch introduce the new feature to support the
> > > signaling between two domUs in dom0less system.
> > > 
> > > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> > > ---
> > >   docs/designs/dom0less-evtchn.md | 96 +++++++++++++++++++++++++++++++++
> > >   1 file changed, 96 insertions(+)
> > >   create mode 100644 docs/designs/dom0less-evtchn.md
> > > 
> > > diff --git a/docs/designs/dom0less-evtchn.md
> > > b/docs/designs/dom0less-evtchn.md
> > > new file mode 100644
> > > index 0000000000..6a1b7e8c22
> > > --- /dev/null
> > > +++ b/docs/designs/dom0less-evtchn.md
> > > @@ -0,0 +1,96 @@
> > > +# Signaling support between two domUs on dom0less system
> > > +
> > > +## Current state: Draft version
> > > +
> > > +## Proposer(s): Rahul Singh, Bertrand Marquis
> > > +
> > > +## Problem Statement:
> > > +
> > > +The goal of this work is to define a simple signaling system between Xen
> > > guests
> > > +in dom0less systems.
> > > +
> > > +In dom0less system, we cannot make use of xenbus and xenstore that are
> > > used in
> > > +normal systems with dynamic VMs to communicate between domains by
> > > providing a
> > > +bus abstraction for paravirtualized drivers.
> > > +
> > > +One possible solution to implement the signaling system between domUs is
> > > based
> > > +on event channels.
> > 
> > I suggest to reword this as follows:
> > 
> > ---
> > Dom0less guests would benefit from a statically-defined memory sharing
> > and signally system for communication. One that would be immediately
> > available at boot without any need for dynamic configurations.
> > 
> > In embedded a great variety of guest operating system kernels exist,
> > many of which don't have support for xenstore, grant table or other
> > complex drivers. Some of them are small kernel-space applications (often
> > called "baremetal", not to be confused with the term "baremetal" used in
> > datacenter which means "without hypervisors") or RTOSes.  Additionally,
> > for safety reasons, users often need to be able to configure the full
> > system statically so that it can be verified statically.
> > 
> > Event channels are very simple and can be added even to baremetal
> > applications. This proposal introduces a way to define them statically
> > to make them suitable to dom0less embedded deployments.
> > ---
> > 
> > 
> > > +## Proposal:
> > > +
> > > +Event channels are the basic primitive provided by Xen for event
> > > notifications.
> > > +An event channel is a logical connection between 2 domains (more
> > > specifically
> > > +between dom1,port1 and dom2,port2). They essentially store one bit of
> > > +information, the event of interest is signalled by transitioning this bit
> > > from
> > > +0 to 1. An event is an equivalent of a hardware interrupt.
> > > +
> > > +Notifications are received by a guest via an interrupt from Xen to the
> > > guest,
> > > +indicating when an event arrives (setting the bit). Further notifications
> > > are
> > > +masked until the bit is cleared again. When a domain wants to wait for
> > > data it
> > > +will block until an event arrives, and then send an event to signal that
> > > data
> > > +has been consumed. Events are delivered asynchronously to guests and are
> > > +enqueued when the guest is not running.
> > > +
> > > +Event channel communication will be established statically between two
> > > domU
> > > +guests before unpausing the domains after domain creation. Event channel
> > > +connection information between domUs will be passed to XEN via device
> > > tree
> > > +node.
> > > +
> > > +Under the /chosen node, there needs to be sub nodes with compatible
> > > +"xen,evtchn" that descibes the event channel connection between two
> > > domUs.
> > > +
> > > +The event channel sub-node has the following properties:
> > > +
> > > +- compatible
> > > +
> > > +    "xen,evtchn"
> > > +
> > > +- xen,evtchn
> > > +
> > > +    The property is four numbers of tuples of
> > > +    (local-port-domU1,domU1-phandle,local-port-domU2,domU2-phandle)
> > > where:
> > > +
> > > +    local-port-domU1 is an integer value that will be used to allocte
> > > local
> > > +    port for domU1 to send an event notification to the remote domain.
> > > +
> > > +    domU1-phandle is a single phandle to an domain to which
> > > local-port-domU1
> > > +    will be allocated.
> > > +
> > > +    local-port-domU2 is an integer value that will be used to allocte
> > > local
> > > +    port for domU2 to send an event notification to the remote domain.
> > > +
> > > +    domU2-phandle is a single phandle to an domain to which
> > > local-port-domU2
> > > +    will be allocated.
> > > +
> > > +Example:
> > > +
> > > +    chosen {
> > > +        ....
> > > +
> > > +        domU1: domU1 {
> > > +            ......
> > > +        };
> > > +
> > > +        domU2: domU2 {
> > > +            ......
> > > +        };
> > > +
> > > +        evtchn@1 {
> > > +            compatible = "xen,evtchn";
> > > +            xen,evtchn = <0xa &domU1 0xb &domU2>;
> > > +        };
> > > +
> > > +        evtchn@2 {
> > > +            compatible = "xen,evtchn";
> > > +            xen,evtchn = <0xc &domU1 0xd &domU2>;
> > > +        };
> > > +    };
> > 
> > There is no need to use two evtchn nodes for this given that in device
> > tree it is entirely normal to have multiple tuplets in a property. Also,
> > it would be good to have a version number in the compatible string so
> > that we can change version in the future.
> > 
> > 1)
> >      chosen {
> >          ....
> > 
> >          domU1: domU1 {
> >              ......
> >          };
> > 
> >          domU2: domU2 {
> >              ......
> >          };
> > 
> >          evtchn {
> >              compatible = "xen,evtchn-v1";
> >              xen,evtchn = <0xa &domU1 0xb &domU2 0xc &domU1 0xd &domU2>;
> >          };
> >      };
> > 
> > 
> > I should mention that it would be also possible to use sub-nodes to
> > express this information:
> > 
> > 2)
> >          domU1: domU1 {
> >              ...
> >              /* one sub-node per local event channel */
> >              ec1: evtchn@a {
> >                  compatible = "xen,evtchn-v1";
> >                  /* local-evtchn link-to-foreign-evtchn */
> >                  xen,evtchn = <0xa &ec3>
> >              };
> >              ec2: evtchn@c {
> >                  compatible = "xen,evtchn-v1";
> >                  xen,evtchn = <0xc &ec4>
> >              };
> >          };
> > 
> >          domU2: domU2 {
> >              ...
> >              ec3: evtchn@b {
> >                  compatible = "xen,evtchn-v1";
> >                  xen,evtchn = <0xb &ec1>
> >              };
> >              ec4: evtchn@d {
> >                  compatible = "xen,evtchn-v1";
> >                  xen,evtchn = <0xd &ec2>
> >              };
> >          };
> >      };
> 
> As for 1), you could combine all the ports in one node.

I thought about it but I couldn't come up with a way to do that which
retains the simplicity of this example. The problem is that in device
tree you can only link to nodes, not to individual properties. So I
think we would have to have separate nodes for each event channel so
that we could separately link to them. 

Otherwise, we would have to add the foreign event channel number in
addition to the link to be able to distinguish them. And that would
result in duplicated information. E.g.:

       domU1: domU1 {
           ...
           /* one sub-node per local event channel */
           ec1: evtchn@a {
               compatible = "xen,evtchn-v1";
               /* local-evtchn link-to-foreign foreign-evtchn */
               xen,evtchn = <0xa &ec2 0xa 0xc &ec2 0xd>
           };
       };

       domU2: domU2 {
           ...
           ec2: evtchn@b {
               compatible = "xen,evtchn-v1";
               xen,evtchn = <0xb &ec1 0xa 0xd &ec1 0xc>
           };
       };
--8323329-1475397912-1649795812=:3066615--


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 22:37:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 22:37:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303810.518261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neP83-0002Bv-UD; Tue, 12 Apr 2022 22:36:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303810.518261; Tue, 12 Apr 2022 22:36:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neP83-0002Bo-R3; Tue, 12 Apr 2022 22:36:55 +0000
Received: by outflank-mailman (input) for mailman id 303810;
 Tue, 12 Apr 2022 22:36:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neP82-0002Be-SY; Tue, 12 Apr 2022 22:36:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neP82-0002tc-Qt; Tue, 12 Apr 2022 22:36:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neP82-0000wD-6H; Tue, 12 Apr 2022 22:36:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neP82-0000ST-5k; Tue, 12 Apr 2022 22:36:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=w4Snm4TfyBcAN3AiGgHChXITvZr4o5q/CHflNTT5e9k=; b=0/H9aS54+mkBhskMk+Vaqdq4zl
	AF+RHJYa2BRAt4yZaexx2ikn0ZgGKtMAHYUYL9rKcQDIzASL7W3yS6SUd0jSeCbCm7wpjP8dE4B9m
	tbXrW0ElwjiICxi4FMmKy4xyle9fHo7K4EWW8nhsAKQIvXFH2smf2+3VCwjrHr8rQf3c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169339-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169339: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f5508a91e306dd183ab971be438b9667c9890a1d
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 22:36:54 +0000

flight 169339 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169339/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f5508a91e306dd183ab971be438b9667c9890a1d
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  347 attempts
Testing same since   169335  2022-04-12 14:41:55 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5009 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 23:04:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 23:04:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303821.518276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nePZ5-0005V8-8U; Tue, 12 Apr 2022 23:04:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303821.518276; Tue, 12 Apr 2022 23:04:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nePZ5-0005V1-5L; Tue, 12 Apr 2022 23:04:51 +0000
Received: by outflank-mailman (input) for mailman id 303821;
 Tue, 12 Apr 2022 23:04:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nePZ3-0005Ur-KZ; Tue, 12 Apr 2022 23:04:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nePZ3-0003WY-I4; Tue, 12 Apr 2022 23:04:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nePZ3-0001nr-3w; Tue, 12 Apr 2022 23:04:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nePZ3-00009h-3F; Tue, 12 Apr 2022 23:04:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=M9zEcux3yvAgYPk3niE9ig3QgzaFy91EedEmhujy5Ak=; b=IuErRtTB2s/dQ9D0R9qPZI1dPT
	GRmb5LDc4zLkN53UwIjYtcG04iGXuN6ilE/loc/kGoRRbWwy2OJH2aKCwto/UFsCkjyN/IWeaJQUH
	ZTbW0UeuTiYcpJwMXNs3zHdMjUY9JFTKkrQnkR62QBhKfWR46tsD3DMzVT9wo6dCLmPY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169333-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 169333: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f26544492298cb82d66f9bf36e29d2f75b3133f2
X-Osstest-Versions-That:
    xen=b953760d0b564478e232e7e64823d2a1506e92b5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 23:04:49 +0000

flight 169333 xen-4.16-testing real [real]
flight 169340 xen-4.16-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169333/
http://logs.test-lab.xenproject.org/osstest/logs/169340/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169340-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169252
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169252
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169252
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169252
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169252
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169252
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169252
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169252
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169252
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169252
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169252
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169252
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  f26544492298cb82d66f9bf36e29d2f75b3133f2
baseline version:
 xen                  b953760d0b564478e232e7e64823d2a1506e92b5

Last test of basis   169252  2022-04-09 02:11:08 Z    3 days
Testing same since   169333  2022-04-12 12:36:49 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b953760d0b..f265444922  f26544492298cb82d66f9bf36e29d2f75b3133f2 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 23:05:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 23:05:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303827.518287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nePZP-0005uj-Kb; Tue, 12 Apr 2022 23:05:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303827.518287; Tue, 12 Apr 2022 23:05:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nePZP-0005uc-HR; Tue, 12 Apr 2022 23:05:11 +0000
Received: by outflank-mailman (input) for mailman id 303827;
 Tue, 12 Apr 2022 23:05:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nePZO-0005sf-3n; Tue, 12 Apr 2022 23:05:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nePZO-0003Wz-1J; Tue, 12 Apr 2022 23:05:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nePZN-0001oK-Jz; Tue, 12 Apr 2022 23:05:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nePZN-0000b3-JW; Tue, 12 Apr 2022 23:05:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xgaqzxu6huT69UkBOVkLF8opKzM1wdttg+Lx6uHivGU=; b=sz0nBbbddUt5xh9SpUETEwiKkq
	TCHMGpoHs+m5tYGRj+ECPdrDjRdPpxjoLC1+1m1KDkFs6XqI+h/PBWk+ZtEY4osgg2KbI8fE09P7i
	bFQBtk+vCckosH5e6TgAMF4DpSUVYBgX1sDQmEfdJXsa/+lNHzHPJXrMhHdwOSjFsVec=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169341-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169341: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f5508a91e306dd183ab971be438b9667c9890a1d
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Apr 2022 23:05:09 +0000

flight 169341 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169341/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f5508a91e306dd183ab971be438b9667c9890a1d
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  348 attempts
Testing same since   169335  2022-04-12 14:41:55 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5009 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 12 23:17:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Apr 2022 23:17:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303840.518298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nePlG-0007g9-PH; Tue, 12 Apr 2022 23:17:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303840.518298; Tue, 12 Apr 2022 23:17:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nePlG-0007g2-MP; Tue, 12 Apr 2022 23:17:26 +0000
Received: by outflank-mailman (input) for mailman id 303840;
 Tue, 12 Apr 2022 23:17:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=URkf=UW=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nePlF-0007fw-N9
 for xen-devel@lists.xenproject.org; Tue, 12 Apr 2022 23:17:25 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b505c1be-bab6-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 01:17:23 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 7E5C860B10;
 Tue, 12 Apr 2022 23:17:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 639F2C385A1;
 Tue, 12 Apr 2022 23:17:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b505c1be-bab6-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649805442;
	bh=wOa3STNJePWnzwzX/tYwSD4/1l95Y8NsSHWGWS7eJsg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=AvSUNdNULOCuqjhOZBXQjSuQsVzY9jCwTQcNXNNi0cCzUe02qWDBrCidwBpOGaKHp
	 +aILXfu3J598yw3uR+Pmtm29VMoyhGEE9tu0VenPqqFZmguy1/uP4WdZ7WDj+5pT7j
	 zM9DrjJcdHxlzSEWGZ/XwrFkRhJcMdgk479KCGFse4EJd2BHn//YjpJM9Dm95h2/M8
	 3yPEp4Qur0BqI204CSasLMgFRP8kGUewfMjSR458FIdzPbZKjV9UMtpME3MOPRTYGG
	 ao/QQnpOemB6L1pYLSd9lx/tpytwK+M9SHa0MMUDl7peLxOsOoMMagPlD3+LBnSGnv
	 pMH0aDFBPU5aw==
Date: Tue, 12 Apr 2022 16:17:20 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Jan Beulich <jbeulich@suse.com>
cc: Luca Fancellu <Luca.Fancellu@arm.com>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Dario Faggioli <dfaggioli@suse.com>, Juergen Gross <jgross@suse.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
In-Reply-To: <50dc64e6-1a89-59aa-e087-d80aad1c653d@suse.com>
Message-ID: <alpine.DEB.2.22.394.2204121616030.3066615@ubuntu-linux-20-04-desktop>
References: <20220411152101.17539-1-luca.fancellu@arm.com> <20220411152101.17539-5-luca.fancellu@arm.com> <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com> <86F93995-5CFD-4A43-A928-E9053B027722@arm.com> <50dc64e6-1a89-59aa-e087-d80aad1c653d@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-560354341-1649805441=:3066615"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-560354341-1649805441=:3066615
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Tue, 12 Apr 2022, Jan Beulich wrote:
> On 12.04.2022 11:50, Luca Fancellu wrote:
> >>> ---
> >>> MAINTAINERS | 2 +-
> >>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
> >>> xen/arch/arm/domain_build.c | 5 +-
> >>> xen/arch/arm/include/asm/smp.h | 3 +
> >>> xen/common/Kconfig | 7 +
> >>
> >> For consistency, should the addition here - with ...
> >>
> >>> xen/common/sched/Makefile | 1 +
> >>> xen/common/sched/boot-cpupool.c | 207 +++++++++++++++++++++++++
> >>> xen/common/sched/cpupool.c | 12 +-
> >>
> >> ... the new file now under sched/, also be put in sched/Kconfig?
> > 
> > Hi Jan,
> > 
> > I was looking for this change, I see xen/common/Kconfig offers the menu “Common Features”
> > and the xen/common/sched/Kconfig offers the “Scheduler” menu (visible with EXPERT), so
> > I thought it was better to leave it in “Common Features”.
> > 
> > Are you suggesting another menu under “Common Features”? 
> 
> No, I'm not suggesting a new menu. I was merely wondering whether the
> Kconfig contents wouldn't location-wise better match where the
> respective source file lives.

It could be in xen/common/sched/Kconfig at the beginning of the file
before creating the new "Schedulers" menu, e.g.:

diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
index 3d9f9214b8..f6545f4e9b 100644
--- a/xen/common/sched/Kconfig
+++ b/xen/common/sched/Kconfig
@@ -1,3 +1,10 @@
+config BOOT_TIME_CPUPOOLS
+       bool "Create cpupools at boot time"
+       depends on HAS_DEVICE_TREE
+       help
+         Creates cpupools during boot time and assigns cpus to them. Cpupools
+         options can be specified in the device tree.
+
 menu "Schedulers"
 	visible if EXPERT
 

I think it is fine either way, so:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
--8323329-560354341-1649805441=:3066615--


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 00:01:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 00:01:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303846.518309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neQRB-0004pA-LI; Wed, 13 Apr 2022 00:00:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303846.518309; Wed, 13 Apr 2022 00:00:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neQRB-0004p3-I3; Wed, 13 Apr 2022 00:00:45 +0000
Received: by outflank-mailman (input) for mailman id 303846;
 Wed, 13 Apr 2022 00:00:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neQR9-0004ot-Im; Wed, 13 Apr 2022 00:00:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neQR9-0005IV-9C; Wed, 13 Apr 2022 00:00:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neQR8-0003ha-UI; Wed, 13 Apr 2022 00:00:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neQR8-000115-To; Wed, 13 Apr 2022 00:00:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+UHGlKkK8lWTMLsA7Fv0lyjsBBk/LtDsBk0PCfvjDZU=; b=EwU1tvd4xiTPKT0r7mtbBzK1ZL
	rXNz6qZwCLAHjssi6f/AYCClLVk6u7yh715kSmYhdfYyXiBfnYUaUeHD6TU7v6TdkczG+K6IWenc5
	XFEQXGIgNekhrL9LAIEl8X28F/V4JKgtFlqzNGijyifpapLgFSA7GuiYDLAXe9Q41VrE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169342-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169342: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f5508a91e306dd183ab971be438b9667c9890a1d
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 00:00:42 +0000

flight 169342 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169342/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f5508a91e306dd183ab971be438b9667c9890a1d
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  349 attempts
Testing same since   169335  2022-04-12 14:41:55 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5009 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 00:29:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 00:29:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303855.518319 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neQt7-0007LI-VY; Wed, 13 Apr 2022 00:29:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303855.518319; Wed, 13 Apr 2022 00:29:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neQt7-0007LB-SW; Wed, 13 Apr 2022 00:29:37 +0000
Received: by outflank-mailman (input) for mailman id 303855;
 Wed, 13 Apr 2022 00:29:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neQt6-0007L1-Tr; Wed, 13 Apr 2022 00:29:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neQt6-0005rr-S4; Wed, 13 Apr 2022 00:29:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neQt6-0004QM-HN; Wed, 13 Apr 2022 00:29:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neQt6-0001eW-Gx; Wed, 13 Apr 2022 00:29:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yDZPLhVhMfzKN1KRrIQMfVc406Evrx1g6wguTPldRVs=; b=uZLwCx3iKTAj81Dnvx4ZboPfPw
	72zfZdQ3qwLna5mxcfuHiZMi8KKd7sQ5MakwOJHhrPHFY4ftMw857hpNLOhaJVjPfLSsEzSPnLHYH
	s6TJ79Un3Hs2tTEpcic8qpr9va5yYuF2IGmPBjt3gn6Cr43p0l5VFe2SRdNHQGWJgnFM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169343-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169343: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 00:29:36 +0000

flight 169343 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169343/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  350 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 01:00:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 01:00:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303865.518331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neRNE-0001x3-D3; Wed, 13 Apr 2022 01:00:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303865.518331; Wed, 13 Apr 2022 01:00:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neRNE-0001vz-9k; Wed, 13 Apr 2022 01:00:44 +0000
Received: by outflank-mailman (input) for mailman id 303865;
 Wed, 13 Apr 2022 01:00:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neRNC-0001N6-QZ; Wed, 13 Apr 2022 01:00:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neRNC-0006RZ-M1; Wed, 13 Apr 2022 01:00:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neRNC-0005Ba-A8; Wed, 13 Apr 2022 01:00:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neRNC-0002eD-9i; Wed, 13 Apr 2022 01:00:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=nDtJ+AUrO9/dlTnHlEt93xjhD7PVO05i56BoKz4X0/g=; b=Ui6M4ftxmhx1xCxLu+4fobHDrY
	SU6ueJSg/Twas7kCnZCZdo5pdiXlHcX19cAqWUZ/Vu37/P1gjMr+ZOSH4Jx5dz8icj/BgH+rmndlN
	S9GRV3avoRRAsJ2Th2D9HIemzIs0kyqR8rnCuxms1od7Z6rrx5QCZsk9Va3A73dVSEJI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169344-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169344: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 01:00:42 +0000

flight 169344 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169344/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  351 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 01:22:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 01:22:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303876.518342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neRiW-0003sF-C7; Wed, 13 Apr 2022 01:22:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303876.518342; Wed, 13 Apr 2022 01:22:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neRiW-0003s8-7f; Wed, 13 Apr 2022 01:22:44 +0000
Received: by outflank-mailman (input) for mailman id 303876;
 Wed, 13 Apr 2022 01:22:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aqKT=UX=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1neRiV-0003s2-3n
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 01:22:43 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3696f393-bac8-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 03:22:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id EEAABB82083;
 Wed, 13 Apr 2022 01:22:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36A9DC385A8;
 Wed, 13 Apr 2022 01:22:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3696f393-bac8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649812959;
	bh=6l+CGf4T8Rw73qOnntCeY3bk40iIH1mPAe8On5wwcls=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=XZR4+w4qJfrfsnvKWx/SkENFxau7Dli3kNTC+MOKSMYjVn6ItEpVWaSbTs8oEzpOD
	 KiYBFU41p/cVoduPIPs1barf6KNzbTXM20BaY3kGrjvdrvjzBpPzwf3A9RvXRyJuMH
	 71xZ7FGryI1g3rYQ1UbMVvFLPm5IhhrarIIRuZWUJH2Q5u7XToJctE2A9JRGV2tq9L
	 si9E2R2xnh89giVzlDNlyPcqmeWXvCODNTc+AL4qD1C1+ToV+SjiQArQaJg8+qqc5l
	 VP618r3INe/Wfq4gsHkWld+UntMq1aXU46HIX069X+GAPpm7arFqxCl23jyL6i1YAd
	 wYnStx7gW9FtQ==
Date: Tue, 12 Apr 2022 18:22:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org, 
    Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, 
    Luca Miccio <lucmiccio@gmail.com>, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v4 8/9] tools: add example application to initialize
 dom0less PV drivers
In-Reply-To: <7dc5887a-461d-506d-ce4e-fbcb7e5cb43e@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204121819410.3066615@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203311735380.2910984@ubuntu-linux-20-04-desktop> <20220401003847.38393-8-sstabellini@kernel.org> <e71ad6f6-f920-1e7b-9f4b-dd2e133a23c5@xen.org> <39fc312c-cf0b-d7ff-c560-7c6b96809416@suse.com>
 <alpine.DEB.2.22.394.2204051758250.2910984@ubuntu-linux-20-04-desktop> <7dc5887a-461d-506d-ce4e-fbcb7e5cb43e@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1031791000-1649812894=:3066615"
Content-ID: <alpine.DEB.2.22.394.2204121821570.3066615@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1031791000-1649812894=:3066615
Content-Type: text/plain; CHARSET=US-ASCII
Content-ID: <alpine.DEB.2.22.394.2204121821571.3066615@ubuntu-linux-20-04-desktop>

On Wed, 6 Apr 2022, Julien Grall wrote:
> But if we use the 'connection status' field, then you could just delay the
> initialization until you receive an event and the connection status is
> connected.

I prototyped this approach and I managed to validate it successfully.
See attached patches for xen and linux (on top of existing patches). I
allocated the page from init-dom0less (instead of Xen) to achieve best
compatibility with older kernels.

There are some rough edges in the two patches but let me know if you
have any comments on the overall approach.
--8323329-1031791000-1649812894=:3066615
Content-Type: text/x-diff; NAME=xen.patch
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.DEB.2.22.394.2204121821340.3066615@ubuntu-linux-20-04-desktop>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME=xen.patch

ZGlmZiAtLWdpdCBhL3Rvb2xzL2hlbHBlcnMvTWFrZWZpbGUgYi90b29scy9o
ZWxwZXJzL01ha2VmaWxlDQppbmRleCA4ZTQyOTk3MDUyLi44ZDc4YWIxZTkw
IDEwMDY0NA0KLS0tIGEvdG9vbHMvaGVscGVycy9NYWtlZmlsZQ0KKysrIGIv
dG9vbHMvaGVscGVycy9NYWtlZmlsZQ0KQEAgLTQ2LDcgKzQ2LDcgQEAgaW5p
dC14ZW5zdG9yZS1kb21haW46ICQoSU5JVF9YRU5TVE9SRV9ET01BSU5fT0JK
UykNCiAJJChDQykgJChMREZMQUdTKSAtbyAkQCAkKElOSVRfWEVOU1RPUkVf
RE9NQUlOX09CSlMpICQoTERMSUJTX2xpYnhlbnRvb2xsb2cpICQoTERMSUJT
X2xpYnhlbnN0b3JlKSAkKExETElCU19saWJ4ZW5jdHJsKSAkKExETElCU19s
aWJ4ZW5ndWVzdCkgJChMRExJQlNfbGlieGVubGlnaHQpICQoQVBQRU5EX0xE
RkxBR1MpDQogDQogaW5pdC1kb20wbGVzczogJChJTklUX0RPTTBMRVNTX09C
SlMpDQotCSQoQ0MpICQoTERGTEFHUykgLW8gJEAgJChJTklUX0RPTTBMRVNT
X09CSlMpICQoTERMSUJTX2xpYnhlbmN0cmwpICQoTERMSUJTX2xpYnhlbmV2
dGNobikgJChMRExJQlNfbGlieGVudG9vbGxvZykgJChMRExJQlNfbGlieGVu
c3RvcmUpICQoTERMSUJTX2xpYnhlbmxpZ2h0KSAkKExETElCU19saWJ4ZW5n
dWVzdCkgICQoQVBQRU5EX0xERkxBR1MpDQorCSQoQ0MpICQoTERGTEFHUykg
LW8gJEAgJChJTklUX0RPTTBMRVNTX09CSlMpICQoTERMSUJTX2xpYnhlbmN0
cmwpICQoTERMSUJTX2xpYnhlbmV2dGNobikgJChMRExJQlNfbGlieGVudG9v
bGxvZykgJChMRExJQlNfbGlieGVuc3RvcmUpICQoTERMSUJTX2xpYnhlbmxp
Z2h0KSAkKExETElCU19saWJ4ZW5ndWVzdCkgJChMRExJQlNfbGlieGVuZm9y
ZWlnbm1lbW9yeSkgJChBUFBFTkRfTERGTEFHUykNCiANCiAuUEhPTlk6IGlu
c3RhbGwNCiBpbnN0YWxsOiBhbGwNCmRpZmYgLS1naXQgYS90b29scy9oZWxw
ZXJzL2luaXQtZG9tMGxlc3MuYyBiL3Rvb2xzL2hlbHBlcnMvaW5pdC1kb20w
bGVzcy5jDQppbmRleCBkYzljY2VlODY4Li4zMjlhYTQ0ZGE2IDEwMDY0NA0K
LS0tIGEvdG9vbHMvaGVscGVycy9pbml0LWRvbTBsZXNzLmMNCisrKyBiL3Rv
b2xzL2hlbHBlcnMvaW5pdC1kb20wbGVzcy5jDQpAQCAtOSw5ICs5LDEyIEBA
DQogI2luY2x1ZGUgPHhlbmd1ZXN0Lmg+DQogI2luY2x1ZGUgPGxpYnhsLmg+
DQogI2luY2x1ZGUgPHhlbmV2dGNobi5oPg0KKyNpbmNsdWRlIDx4ZW5mb3Jl
aWdubWVtb3J5Lmg+DQogDQogI2luY2x1ZGUgImluaXQtZG9tLWpzb24uaCIN
CiANCisjZGVmaW5lIFhTX0NPTk5FQ1RJT05fU1RBVEVfT0ZGU0VUICAgICAg
ICgyMDY4LzQpDQorI2RlZmluZSBYU19DT05ORUNUSU9OX1NUQVRFX1JFQ09O
TkVDVElORyAweDENCiAjZGVmaW5lIFhFTlNUT1JFX1BGTl9PRkZTRVQgMQ0K
ICNkZWZpbmUgU1RSX01BWF9MRU5HVEggNjQNCiANCkBAIC0yMTUsMTIgKzIx
OCwxOCBAQCBlcnI6DQogc3RhdGljIGludCBpbml0X2RvbWFpbihzdHJ1Y3Qg
eHNfaGFuZGxlICp4c2gsIGxpYnhsX2RvbWluZm8gKmluZm8pDQogew0KICAg
ICBzdHJ1Y3QgeGNfaW50ZXJmYWNlX2NvcmUgKnhjaDsNCisgICAgeGVuZm9y
ZWlnbm1lbW9yeV9oYW5kbGUgKnhmaDsNCiAgICAgbGlieGxfdXVpZCB1dWlk
Ow0KICAgICB1aW50NjRfdCB4ZW5zdG9yZV9ldnRjaG4sIHhlbnN0b3JlX3Bm
bjsNCiAgICAgaW50IHJjOw0KKyAgICB1aW50MzJfdCAqcGFnZTsNCiANCiAg
ICAgcHJpbnRmKCJJbml0IGRvbTBsZXNzIGRvbWFpbjogJXVcbiIsIGluZm8t
PmRvbWlkKTsNCiAgICAgeGNoID0geGNfaW50ZXJmYWNlX29wZW4oMCwgMCwg
MCk7DQorICAgIHhmaCA9IHhlbmZvcmVpZ25tZW1vcnlfb3BlbigwLCAwKTsN
CisNCisgICAgaWYgKHhjaCA9PSBOVUxMIHx8IHhmaCA9PSBOVUxMKQ0KKyAg
ICAgICAgZXJyKDEsICJDYW5ub3Qgb3BlbiB4Yy94ZW5mb3JlaWdubWVtb3J5
IGludGVyZmFjZXNcbiIpOw0KIA0KICAgICByYyA9IHhjX2h2bV9wYXJhbV9n
ZXQoeGNoLCBpbmZvLT5kb21pZCwgSFZNX1BBUkFNX1NUT1JFX0VWVENITiwN
CiAgICAgICAgICAgICAgICAgICAgICAgICAgICZ4ZW5zdG9yZV9ldnRjaG4p
Ow0KQEAgLTIzNSw2ICsyNDQsMTQgQEAgc3RhdGljIGludCBpbml0X2RvbWFp
bihzdHJ1Y3QgeHNfaGFuZGxlICp4c2gsIGxpYnhsX2RvbWluZm8gKmluZm8p
DQogICAgICAgICByZXR1cm4gMTsNCiAgICAgfQ0KIA0KKyAgICBwYWdlID0g
eGVuZm9yZWlnbm1lbW9yeV9tYXAoeGZoLCBpbmZvLT5kb21pZCwgWFNfUkVB
RCB8IFhTX1dSSVRFLCAxLCAmeGVuc3RvcmVfcGZuLCBOVUxMKTsNCisgICAg
aWYgKCFwYWdlKSB7DQorICAgICAgICBwcmludGYoIkVycm9yIG1hcHBpbmcg
eGVuc3RvcmUgcGFnZVxuIik7DQorICAgICAgICByZXR1cm4gMTsNCisgICAg
fQ0KKyAgICBwYWdlW1hTX0NPTk5FQ1RJT05fU1RBVEVfT0ZGU0VUXSA9IFhT
X0NPTk5FQ1RJT05fU1RBVEVfUkVDT05ORUNUSU5HOw0KKyAgICB4ZW5mb3Jl
aWdubWVtb3J5X3VubWFwKHhmaCwgcGFnZSwgMSk7DQorDQogICAgIHJjID0g
eGNfZG9tX2dudHRhYl9zZWVkKHhjaCwgaW5mby0+ZG9taWQsIHRydWUsDQog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICh4ZW5fcGZuX3QpLTEsIHhl
bnN0b3JlX3BmbiwgMCwgMCk7DQogICAgIGlmIChyYykNCmRpZmYgLS1naXQg
YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgYi90b29scy94
ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMNCmluZGV4IDA1NDNmNDk2NzAu
LjdiYjhjNjRkMzMgMTAwNjQ0DQotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z
dG9yZWRfZG9tYWluLmMNCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl
ZF9kb21haW4uYw0KQEAgLTQ5NCw2ICs0OTQsNyBAQCBzdGF0aWMgc3RydWN0
IGRvbWFpbiAqaW50cm9kdWNlX2RvbWFpbihjb25zdCB2b2lkICpjdHgsDQog
CQl0YWxsb2Nfc3RlYWwoZG9tYWluLT5jb25uLCBkb21haW4pOw0KIA0KIAkJ
LyogTm90aWZ5IHRoZSBkb21haW4gdGhhdCB4ZW5zdG9yZSBpcyBhdmFpbGFi
bGUgKi8NCisJCWludGVyZmFjZS0+Y29ubmVjdGlvbiA9IDB4MDsNCiAJCXhl
bmV2dGNobl9ub3RpZnkoeGNlX2hhbmRsZSwgZG9tYWluLT5wb3J0KTsNCiAN
CiAJCWlmICghaXNfbWFzdGVyX2RvbWFpbiAmJiAhcmVzdG9yZSkNCg==

--8323329-1031791000-1649812894=:3066615
Content-Type: text/x-diff; NAME=linux.patch
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.DEB.2.22.394.2204121821341.3066615@ubuntu-linux-20-04-desktop>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME=linux.patch

ZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUu
YyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUuYw0KaW5kZXgg
NTFlNTJlMTc1ODkyLi5kYzA0NmQyNTc4OWUgMTAwNjQ0DQotLS0gYS9kcml2
ZXJzL3hlbi94ZW5idXMveGVuYnVzX3Byb2JlLmMNCisrKyBiL2RyaXZlcnMv
eGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUuYw0KQEAgLTkzOSw2ICs5MzksNyBA
QCBzdGF0aWMgaW50IF9faW5pdCB4ZW5idXNfaW5pdCh2b2lkKQ0KIHsNCiAJ
aW50IGVycjsNCiAJdWludDY0X3QgdiA9IDA7DQorCWJvb2wgd2FpdCA9IGZh
bHNlOw0KIAl4ZW5fc3RvcmVfZG9tYWluX3R5cGUgPSBYU19VTktOT1dOOw0K
IA0KIAlpZiAoIXhlbl9kb21haW4oKSkNCkBAIC05OTIsMTcgKzk5Myw3IEBA
IHN0YXRpYyBpbnQgX19pbml0IHhlbmJ1c19pbml0KHZvaWQpDQogCQkJZ290
byBvdXRfZXJyb3I7DQogCQl9DQogCQlpZiAodiA9PSB+MFVMTCkgew0KLQkJ
CWVyciA9IGJpbmRfZXZ0Y2huX3RvX2lycWhhbmRsZXIoeGVuX3N0b3JlX2V2
dGNobiwNCi0JCQkJCQkJeGVuYnVzX2xhdGVfaW5pdCwNCi0JCQkJCQkJMCwg
InhlbnN0b3JlX2xhdGVfaW5pdCIsDQotCQkJCQkJCSZ4Yl93YWl0cSk7DQot
CQkJaWYgKGVyciA8IDApIHsNCi0JCQkJcHJfZXJyKCJ4ZW5zdG9yZV9sYXRl
X2luaXQgY291bGRuJ3QgYmluZCBpcnEgZXJyPSVkXG4iLA0KLQkJCQkgICAg
ICAgZXJyKTsNCi0JCQkJcmV0dXJuIGVycjsNCi0JCQl9DQotDQotCQkJeHNf
aW5pdF9pcnEgPSBlcnI7DQorCQkJd2FpdCA9IHRydWU7DQogCQl9IGVsc2Ug
ew0KIAkJCS8qIEF2b2lkIHRydW5jYXRpb24gb24gMzItYml0LiAqLw0KICNp
ZiBCSVRTX1BFUl9MT05HID09IDMyDQpAQCAtMTAxNyw2ICsxMDA4LDIxIEBA
IHN0YXRpYyBpbnQgX19pbml0IHhlbmJ1c19pbml0KHZvaWQpDQogCQkJeGVu
X3N0b3JlX2ludGVyZmFjZSA9DQogCQkJCXhlbl9yZW1hcCh4ZW5fc3RvcmVf
Z2ZuIDw8IFhFTl9QQUdFX1NISUZULA0KIAkJCQkJICBYRU5fUEFHRV9TSVpF
KTsNCisJCQlpZiAoeGVuX3N0b3JlX2ludGVyZmFjZS0+Y29ubmVjdGlvbiAh
PSAwKQ0KKwkJCQl3YWl0ID0gdHJ1ZTsNCisJCX0NCisJCWlmICh3YWl0KSB7
DQorCQkJZXJyID0gYmluZF9ldnRjaG5fdG9faXJxaGFuZGxlcih4ZW5fc3Rv
cmVfZXZ0Y2huLA0KKwkJCQkJCQl4ZW5idXNfbGF0ZV9pbml0LA0KKwkJCQkJ
CQkwLCAieGVuc3RvcmVfbGF0ZV9pbml0IiwNCisJCQkJCQkJJnhiX3dhaXRx
KTsNCisJCQlpZiAoZXJyIDwgMCkgew0KKwkJCQlwcl9lcnIoInhlbnN0b3Jl
X2xhdGVfaW5pdCBjb3VsZG4ndCBiaW5kIGlycSBlcnI9JWRcbiIsDQorCQkJ
CSAgICAgICBlcnIpOw0KKwkJCQlyZXR1cm4gZXJyOw0KKwkJCX0NCisNCisJ
CQl4c19pbml0X2lycSA9IGVycjsNCiAJCX0NCiAJCWJyZWFrOw0KIAlkZWZh
dWx0Og0KZGlmZiAtLWdpdCBhL2luY2x1ZGUveGVuL2ludGVyZmFjZS9pby94
c193aXJlLmggYi9pbmNsdWRlL3hlbi9pbnRlcmZhY2UvaW8veHNfd2lyZS5o
DQppbmRleCBkNDBhNDRmMDliMTYuLmNkN2FlNWViYjEzMyAxMDA2NDQNCi0t
LSBhL2luY2x1ZGUveGVuL2ludGVyZmFjZS9pby94c193aXJlLmgNCisrKyBi
L2luY2x1ZGUveGVuL2ludGVyZmFjZS9pby94c193aXJlLmgNCkBAIC04Nyw2
ICs4Nyw5IEBAIHN0cnVjdCB4ZW5zdG9yZV9kb21haW5faW50ZXJmYWNlIHsN
CiAgICAgY2hhciByc3BbWEVOU1RPUkVfUklOR19TSVpFXTsgLyogUmVwbGll
cyBhbmQgYXN5bmMgd2F0Y2ggZXZlbnRzLiAqLw0KICAgICBYRU5TVE9SRV9S
SU5HX0lEWCByZXFfY29ucywgcmVxX3Byb2Q7DQogICAgIFhFTlNUT1JFX1JJ
TkdfSURYIHJzcF9jb25zLCByc3BfcHJvZDsNCisgICAgdWludDMyX3Qgc2Vy
dmVyX2ZlYXR1cmVzOyAvKiBCaXRtYXAgb2YgZmVhdHVyZXMgc3VwcG9ydGVk
IGJ5IHRoZSBzZXJ2ZXIgKi8NCisgICAgdWludDMyX3QgY29ubmVjdGlvbjsN
CisgICAgdWludDMyX3QgZXJyb3I7DQogfTsNCiANCiAvKiBWaW9sYXRpbmcg
dGhpcyBpcyB2ZXJ5IGJhZC4gIFNlZSBkb2NzL21pc2MveGVuc3RvcmUudHh0
LiAqLw0K

--8323329-1031791000-1649812894=:3066615--


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 01:46:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 01:46:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303881.518353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neS5I-0006IG-AA; Wed, 13 Apr 2022 01:46:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303881.518353; Wed, 13 Apr 2022 01:46:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neS5I-0006I9-6O; Wed, 13 Apr 2022 01:46:16 +0000
Received: by outflank-mailman (input) for mailman id 303881;
 Wed, 13 Apr 2022 01:46:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neS5H-0006Hz-PX; Wed, 13 Apr 2022 01:46:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neS5H-0005GE-M1; Wed, 13 Apr 2022 01:46:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neS5H-0006Es-5t; Wed, 13 Apr 2022 01:46:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neS5H-00067R-5T; Wed, 13 Apr 2022 01:46:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=L7Qq2RAeEZ4Ygh5D9gFUgPSmAhr5NcnC0nYOT53TO54=; b=aWCwQhn4ltP71Sjzq/Gavh6tpp
	BOoqXZiKZjQHR/cXtG62WIxOGSb4B5433ZhzLz/sAzGwm8ZPiPSTKtj1CcGDkd9jWxhIjINhfLsDS
	9C6tcK55DivytpvRb/k9rhqslfO4DuW6wdNxkYwLwmKgSxQMI002v2aDV72d7XxLXLd4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169345-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169345: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 01:46:15 +0000

flight 169345 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169345/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   42 days  352 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 03:16:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 03:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303892.518367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neTUQ-0006zU-TJ; Wed, 13 Apr 2022 03:16:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303892.518367; Wed, 13 Apr 2022 03:16:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neTUQ-0006zN-Pm; Wed, 13 Apr 2022 03:16:18 +0000
Received: by outflank-mailman (input) for mailman id 303892;
 Wed, 13 Apr 2022 03:16:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neTUP-0006zD-RP; Wed, 13 Apr 2022 03:16:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neTUP-0007Xj-P7; Wed, 13 Apr 2022 03:16:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neTUP-0000vz-AI; Wed, 13 Apr 2022 03:16:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neTUP-0005PG-9o; Wed, 13 Apr 2022 03:16:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GFZwqhTZlqvF+gHkxMNY2PdIuL7otshbboPsLExVQb8=; b=rLyBMx0MUH7f2s44kXOk0GszCK
	UNZ1oaOK/CBqw5T5wTSpVs8TUjzpUCbw0vikzBbiY2b+qcKOOEORwalRi674M4tPz4nUXHHs4v9ad
	C2x/qsnTVw458S35sOKQ7wk46DPuaKXH3qMnmEhpvT8E8U6S//sGLeiZvHl81+U27X5I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169349-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169349: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 03:16:17 +0000

flight 169349 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169349/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  353 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 05:10:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 05:10:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303910.518382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neVGF-0001ND-BX; Wed, 13 Apr 2022 05:09:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303910.518382; Wed, 13 Apr 2022 05:09:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neVGF-0001N6-8K; Wed, 13 Apr 2022 05:09:47 +0000
Received: by outflank-mailman (input) for mailman id 303910;
 Wed, 13 Apr 2022 05:09:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neVGE-0001Mw-9U; Wed, 13 Apr 2022 05:09:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neVGE-0001en-6F; Wed, 13 Apr 2022 05:09:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neVGD-0007JP-RR; Wed, 13 Apr 2022 05:09:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neVGD-0002xL-Qt; Wed, 13 Apr 2022 05:09:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=nfgTBoG0HmD8lBmAonRGuRTJom861Y8Mff5LORPZ1qg=; b=wjQGDrAb0ZqtVI0WRdLRMVeWv4
	sCfxzinxB0S+CtO4IJ2EorO7mK2kpTalj/LdWIh+YByx7WxvNb6fV0WSt630KV7wR0vK30grBlLL3
	hAwtl3HWN0KU1kodWhwX9mI75MLZz2GMnk8/eK/UL90eVqBv1jwN81Lcvn/QwGhf84EI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169350-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169350: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 05:09:45 +0000

flight 169350 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169350/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  354 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 06:21:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 06:21:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303921.518393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neWMv-0000io-7O; Wed, 13 Apr 2022 06:20:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303921.518393; Wed, 13 Apr 2022 06:20:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neWMv-0000ih-4O; Wed, 13 Apr 2022 06:20:45 +0000
Received: by outflank-mailman (input) for mailman id 303921;
 Wed, 13 Apr 2022 06:20:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PqJl=UX=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1neWMt-0000ib-0E
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 06:20:43 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d7b9f507-baf1-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 08:20:41 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 5281E68B05; Wed, 13 Apr 2022 08:20:37 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7b9f507-baf1-11ec-8fbd-03012f2f19d4
Date: Wed, 13 Apr 2022 08:20:37 +0200
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: Re: cleanup swiotlb initialization v8
Message-ID: <20220413062037.GA450@lst.de>
References: <20220404050559.132378-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220404050559.132378-1-hch@lst.de>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Mon, Apr 04, 2022 at 07:05:44AM +0200, Christoph Hellwig wrote:
> Hi all,
> 
> this series tries to clean up the swiotlb initialization, including
> that of swiotlb-xen.  To get there is also removes the x86 iommu table
> infrastructure that massively obsfucates the initialization path.
> 
> Git tree:
> 
>     git://git.infradead.org/users/hch/misc.git swiotlb-init-cleanup
> 
> Gitweb:
> 
>     http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/swiotlb-init-cleanup

I've updated the git tree above with the commit message nitpicks and
received reviews.  I plan to pull the patches into the dma-mapping
tree after -rc3 is released, so if any involved maintainer is not happy
with the result, please speak up now.


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 07:16:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 07:16:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303931.518404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neXEk-0005yp-Fk; Wed, 13 Apr 2022 07:16:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303931.518404; Wed, 13 Apr 2022 07:16:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neXEk-0005yi-C8; Wed, 13 Apr 2022 07:16:22 +0000
Received: by outflank-mailman (input) for mailman id 303931;
 Wed, 13 Apr 2022 07:16:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hWwI=UX=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1neXEi-0005yb-LQ
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 07:16:20 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2062b.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::62b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9ccc6250-baf9-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 09:16:19 +0200 (CEST)
Received: from AS9PR0301CA0019.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::29) by VI1PR0802MB2368.eurprd08.prod.outlook.com
 (2603:10a6:800:9d::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 07:16:07 +0000
Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:468:cafe::32) by AS9PR0301CA0019.outlook.office365.com
 (2603:10a6:20b:468::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Wed, 13 Apr 2022 07:16:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 07:16:06 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Wed, 13 Apr 2022 07:16:06 +0000
Received: from 9c5eafcb9bdf.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D92ED076-2BF0-44A7-881B-CA56B0ED75EA.1; 
 Wed, 13 Apr 2022 07:16:00 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9c5eafcb9bdf.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Apr 2022 07:16:00 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by DB6PR08MB2758.eurprd08.prod.outlook.com (2603:10a6:6:1c::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 07:15:48 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5164.018; Wed, 13 Apr 2022
 07:15:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ccc6250-baf9-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MKI1JzWv4PwhPpDA4a5jLbM2DVtyJbD9Pn7kdTckDJA=;
 b=JeArvsTLJQzy7M3A+yxJNYLNHPjHNtqJNfX+fmxfPtSoqz3vUPrkuwNhS+YH6w9DGItmSnqacd12vw8o2rxb+CV2sprIrHfV3hYYSpfBnJeDZWHQE3QIpMDTnAPLNorgH+TEodB9l76tKTanP9WRNDlpdhScOrMLJyy5UhHZmP4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8deef940288bc036
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c7QwyhZh4S+mtmHEVJ/9stEd/c3tGuM13e9ksyMvBuL6R/yFCxyqODVhm+eZQ4WhQmB6OOgoV0yrZPiSiwRG56lKcuj4dgRSxMCBuWprR6Q9S5SQj9MDWuo1YvAHJdmIX25rRY45/9FrdjUVEW03+7AORmm2JbUFo30oz5tuR5SG8efp0Y7pMbCNVFBeas9tCTJHilebwQhHzNpuGILh02Zm0M2sQYNKXb/BQU1gITfBWzVeMBWRmw14dtEU9raLZeK2dYsUP6bjXoSYM7k/EbUnbpEYoyEbc0+tTv4G+DNEiVk8hNJGxYWPEZEoPGOI/t3sG+11HgaXH676kY3NwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MKI1JzWv4PwhPpDA4a5jLbM2DVtyJbD9Pn7kdTckDJA=;
 b=ccF5aH+nA2I2GQgbbBnWgoh37Ls5QnwR919/t3E3zwtCttNkobEGPHg9KsQcSgGM1rjdYXL1EOxXDmQ9kKa79RBQ1HhVAu9DC7g2UAOlVVFu+QJRw6FCLwes2X4J+ykyQvwlUe4IGj2QsQIKmH7I9TGDokfFhb0/rImE/iiUYp4Apohe0FOjjEzKHCv0+By9AMCmb3a3flD1NXVahVcqI42Feb9DWD8b1tF/rkj5GCXHi0O/cGMz3yRe+iM44Q1dV/rcWyNcf0IK3ANk6XAnyc8CS9CA3LBPAPPMYcGjTPDlVCPeifYU4rEaEIXP6QfnOa8Bfggg4jYVc3VXk4MRSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MKI1JzWv4PwhPpDA4a5jLbM2DVtyJbD9Pn7kdTckDJA=;
 b=JeArvsTLJQzy7M3A+yxJNYLNHPjHNtqJNfX+fmxfPtSoqz3vUPrkuwNhS+YH6w9DGItmSnqacd12vw8o2rxb+CV2sprIrHfV3hYYSpfBnJeDZWHQE3QIpMDTnAPLNorgH+TEodB9l76tKTanP9WRNDlpdhScOrMLJyy5UhHZmP4=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>, Jan Beulich
	<jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Dario Faggioli
	<dfaggioli@suse.com>, Juergen Gross <jgross@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Thread-Index: AQHYTbfiNTg+IXy/G0GwaoqGDOL0yazq2Y4AgAEwcQCAAAivgIAA2MwAgACFroA=
Date: Wed, 13 Apr 2022 07:15:47 +0000
Message-ID: <39D59E80-A4B5-4587-9A2A-1D5F06C8C33E@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-5-luca.fancellu@arm.com>
 <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
 <86F93995-5CFD-4A43-A928-E9053B027722@arm.com>
 <50dc64e6-1a89-59aa-e087-d80aad1c653d@suse.com>
 <alpine.DEB.2.22.394.2204121616030.3066615@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204121616030.3066615@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 9d9d09eb-3ce0-42d7-c370-08da1d1d7a66
x-ms-traffictypediagnostic:
	DB6PR08MB2758:EE_|VE1EUR03FT054:EE_|VI1PR0802MB2368:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB236819663F75E47ADEF6037FE4EC9@VI1PR0802MB2368.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 m6IQeEqCgEGTKVX9gqFC2D357mG6b1z5AZjl58IVo0VUaIypoi+HVVN2NPhQYUacuycCG18yia3QGQe7WGa84sggUX+0ndiM6AaviJCKutIrePIml+ARZmk4wcF1Yn6YprocajTNjzgoePIxI7A17/pPWnBJDs8zxbROaB0zE501Jh/7k9drtspl8xtp1qqGsdUXR8ZxmWJlN9F7FQLp3yiA2+N3ZZQjHE8qqELEJepd66Mu7c+nNu9+iKcT48/dkHYONgnOemPaxo5Lew65yv6PqjgGegsjidxi+9xOyjawOVsgJZlbCiqgQyXoAZnmBSHvEaelRvMfVE2BGrgqElFSpBIQrFP1bSpLZRddHwAviEjVTZDc2UkShGl6UHW/490gkPcr1DA8E4TL3lorqB2brEesUVvfhvaMLEzPKFXvcTU/85MK3lZaX3I5C7+RlmzFx2oEm0cY+sPamly+m9zP+PuCxpVe2mbmkSTfBRa/yZleYWJI8S4Z1jVOQ/MjC261vCpG1h0YybZu1auPfWY/fiikPKTySXy+feSdE6he7DANeuYJ0eg7tkG63TZ7xzBYp/f6GtXppJi8/Ssx7iiiWDXcAGr0V1tWou1DZzhdJcIhgLbGKK8yMxdFg+4j/9wBiy9aG0ts9WVaMEM5rLYrqicrFbGLId1b1ZxFN1zSOe6JIyfVt3D4GGA298MlfDjT+x+fKUNm0rSPPihAlLFF3DEHBqwJ2fHr/meQ4XftEb3GkhzkxiIE0nIUVLJb
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(508600001)(122000001)(316002)(2616005)(26005)(38100700002)(36756003)(110136005)(6486002)(54906003)(186003)(86362001)(4326008)(66556008)(8676002)(38070700005)(64756008)(66946007)(66476007)(91956017)(66446008)(76116006)(2906002)(33656002)(5660300002)(8936002)(7416002)(71200400001)(6512007)(55236004)(6506007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5EF9E5A80C7DE548BB7C6B2A3E6B1057@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2758
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	04d7228c-e68b-4a4c-4506-08da1d1d6f1b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mse3j8e+bx/yA11feyOLhNFh1KMct8WQTuvJs0aK1/8mSm10F1Ax2G02IDuHT3kJjqIoG9yuHoFGhU5QJ8NWqzyycrVbu6us0nbu85tkm2kshv20S8HtsuSbi+BwJaKJc9kaFzKQe0OK5DTY6V4de26dti9pKdCfxxJt7nnoFnYHf8Bn241vuIaovxhPBuCiQsyrxB6g75sOd86N6vy+fsfPqlGgNcI+pTrdrijXZHXR00f3/B0bNIVFfNxvWPLpPSJiIWcZl2bmu78jONMFi1qhidGfRXG+1iydYZg/BQI8JhMaVpoD8basYAVnGZfBInDDMUgwXKvdUyt2it7POyBoK7zijeHtfYASMGVivhTyl3JqoDVULLm6456ouZmSWYtg1mlq59UeApQ1uxqlVVn1PC9HBbGDWmW4stQk3799exmhlqgMLdlrQzEGd3EQxRBAUdBGEvU+jyqFLBysam0l+BgfaaWi7YdXhZKlscsf9elAAqbglwFmvGkPRCHtZ07uhiVF7izo+SxS4iyGavQft1CYFOjKhzNmVhhpO5OJd7lwordN6I8Ob1xg2jY0Y+bVxM4UE1atWJ7GMw/gr1d/LYppXnbvyrBJwTVimcFlY84mQ1D5EkIx4eXRPIgVRbjEBa4lhIFHOYkO1YLAp+5uY6N5zckspv+cQS4eUfh8yVxBkdLut0VglGPMZOE+
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(356005)(81166007)(6512007)(82310400005)(47076005)(36756003)(5660300002)(33656002)(40460700003)(2906002)(2616005)(508600001)(4744005)(6486002)(36860700001)(86362001)(316002)(8936002)(336012)(70206006)(70586007)(6506007)(110136005)(4326008)(8676002)(54906003)(26005)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 07:16:06.8857
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d9d09eb-3ce0-42d7-c370-08da1d1d7a66
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2368


>>=20
>> No, I'm not suggesting a new menu. I was merely wondering whether the
>> Kconfig contents wouldn't location-wise better match where the
>> respective source file lives.
>=20
> It could be in xen/common/sched/Kconfig at the beginning of the file
> before creating the new "Schedulers" menu, e.g.:
>=20
> diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
> index 3d9f9214b8..f6545f4e9b 100644
> --- a/xen/common/sched/Kconfig
> +++ b/xen/common/sched/Kconfig
> @@ -1,3 +1,10 @@
> +config BOOT_TIME_CPUPOOLS
> + bool "Create cpupools at boot time"
> + depends on HAS_DEVICE_TREE
> + help
> + Creates cpupools during boot time and assigns cpus to them. Cpupools
> + options can be specified in the device tree.
> +
> menu "Schedulers"
> 	visible if EXPERT
>=20
>=20
> I think it is fine either way, so:
>=20
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Thank you Stefano,

Jan for you is it ok at the beginning like Stefano said?

Cheers,
Luca



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 07:23:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 07:23:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303936.518415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neXL4-0007Ou-6n; Wed, 13 Apr 2022 07:22:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303936.518415; Wed, 13 Apr 2022 07:22:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neXL4-0007On-29; Wed, 13 Apr 2022 07:22:54 +0000
Received: by outflank-mailman (input) for mailman id 303936;
 Wed, 13 Apr 2022 07:22:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aogm=UX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neXL2-0007Oe-4P
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 07:22:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 865dff32-bafa-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 09:22:50 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-e2_FnyIDM0qbHJXqIv41Xg-1; Wed, 13 Apr 2022 09:22:47 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR0402MB3827.eurprd04.prod.outlook.com (2603:10a6:208:3::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Wed, 13 Apr
 2022 07:22:44 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Wed, 13 Apr 2022
 07:22:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 865dff32-bafa-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649834570;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jUYyNzsxVhsXxldtt1i9Kgkz6AJi3M9+vK2OYehpZcQ=;
	b=i0rbP59d/TkRI/YMUA1/CtnSJ22cEZcMrqHDCH9apez5AIZKsCoPdlBYzRYkMeV7692wWu
	pKqu2gtwvRYwerWU6nZP1dGYyrhmyQB+0W048gm5HwxxFGd4909s26aw6iV16YxkPb1DRo
	xIUpkNpAcMYaok+OF1s84uDnHI/h8qA=
X-MC-Unique: e2_FnyIDM0qbHJXqIv41Xg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YSLkRzqVgY6KSY+sGjc/ZklS7Ta3RUfg5O1G1C2RNCdzEoilxB7+ocoA+hGHvHfnmfOTyJ5M0Cs/eOyDEsDMdw90JnjQfHRmhm4hLiD4Ib3MFfz0e9HTWCg5MqAFJqpTYiaaZZIYEgGJvwhLvYXcQvjcvl7oVZbG4iCmZVghvpirlph1iO65I0GoEh+pkTSRrZXexmQ43OnjHoGRq3He7fzn2ZpeZI+ip0o6Jk9l7Payuer6xwvbi3kBrXix1Qpcjla6up/9hc385z/I1qEHoO+k5hF8Uz30v7iVLWMx7cUD+2iK7OrmrebmkGbH88/0+qqgQV3Og0Eo7vBRmhyyYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jUYyNzsxVhsXxldtt1i9Kgkz6AJi3M9+vK2OYehpZcQ=;
 b=hNRIf493KU9nkLhFDVN7+Ddg8t5M2zPPfBgMlYPyxUebO/9tKL4bdMjBy8PMca64Wn7gtb2FQEVmP4HF+cXrDUHzStOWRzztXzokOgyql396u7Gdw2ejwa+tsyMOve6hEBZH9DlS9YqrcTPWTZ3bfI0kx/q+byNFtUM+t9hHDK8cGIizrSoA9iEtc6HwzAGGmE5Z9qxI4gjMyKsDMnlybnXDlka7X7kqVCb1vLFveNXzxFh9NhFLMSRz2Xm0dyoyFMPYXZMHoRfhV/kfUDKoZaOhiKselyC90vysUodVGTTSzW7Ea0XoDpKJi4vUUzRsac1uDWbXrKINfKJgtbeIKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <13f077b9-6b61-5737-1c94-b17da0fd6ecc@suse.com>
Date: Wed, 13 Apr 2022 09:22:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Dario Faggioli <dfaggioli@suse.com>, Juergen Gross <jgross@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-5-luca.fancellu@arm.com>
 <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
 <86F93995-5CFD-4A43-A928-E9053B027722@arm.com>
 <50dc64e6-1a89-59aa-e087-d80aad1c653d@suse.com>
 <alpine.DEB.2.22.394.2204121616030.3066615@ubuntu-linux-20-04-desktop>
 <39D59E80-A4B5-4587-9A2A-1D5F06C8C33E@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <39D59E80-A4B5-4587-9A2A-1D5F06C8C33E@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0177.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::32) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c386d6f-f27d-4e11-4c1f-08da1d1e66ec
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3827:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB382781FC1C6F8AD524331B36B3EC9@AM0PR0402MB3827.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aW82+BKXjGXBP113US9L5r0NRDRkAmSSehZhwl/srZiFv5xFXqVvognB7McZeKFBxK7L2LHHnGP71lE7t9VySzTq/u4RNtjRckqXFN42wKnZdUDQVNDIKq3TsQuIHti9IQjYShA/43VA9Oh+dBOKv5bVAsFzIMqWTPHA9SPNjr6kQCKhSiz5wH1uuQq8Xw57/FITvTX/6Dp0x7wVlyw2OSbw35tgq+gjXeGYgvnwXWce+ge7/EiRiALGophvCDOcPL0GeD6qrMQMdqnOyK7PJPKdDMJkoJfgTXdru7Prg6pKR3qUlplnhyzr4BBvCj6f8KQzF+3zuwUIg0iaGdY27RUoIoDbP+a7feFOmeZJgX10ZGHKr7oSFGOBqopcLAwHzTX8iRMhJTWY55symTTOt0Mm9Y1rZIoh9dBC0a7TU/aSK1X/Gevq/QPX9fLBs8PTelos6N2rM94lfl8VpEtlCJFqZ0nW/JNGnc11gD87Fw1b2MWM7sBS9ONcbXT6HzFfM3tOYuXQvWLbUBPfTQ+kBq58JxpjIy6zgxMyQv4zbxvf+TNU5H2dob5eROm0fjPfgNvTa66S6B+H+pmRi/NiuJdh0svsoY6cKWkK2G9Zak7I9/pYC8aIYPg87fo/yebv9WYKeBgf7aPl7RUIMXNbN90o7w5aNmEL3hC8j7ZyZsVp2Oa1nCdDYOEK7m5R81fH7rgTO6Fo77VWZuGZTVqSEGaWKfBOY1yJXgMBJ2xe8d6glKiFFryBkIy7X6qzkner
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(6512007)(86362001)(31696002)(53546011)(316002)(2616005)(26005)(6916009)(54906003)(5660300002)(66476007)(8676002)(7416002)(66556008)(186003)(4326008)(508600001)(8936002)(66946007)(38100700002)(6486002)(2906002)(6666004)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MzkyVmFqM21OSjl1YXo4T0lyeHprMElPMmJJRlJQS2QvT2ZIR0MwblJXTUF3?=
 =?utf-8?B?MytINkZpMkhHWGpJeER0MEdra0RuV2U3UjJzZWh3alJ2ZzZ5ZCtyQzNVckdB?=
 =?utf-8?B?U283KytmRUUzdWQvWnFtWjg2UUk5ZjRiME43ZVpXVFNMTS81SllLTWVRMXhU?=
 =?utf-8?B?T20wSUd6NWNoQkxHVE12L0JZenhsckxhNXFvcVNwS0JjaGVzMkZWei9BOW9V?=
 =?utf-8?B?U0xFTlM1eEUwQ2doSmRpelUvc1RsTGhReStKSEdySzRZd2dZc0VQRmwvSVBT?=
 =?utf-8?B?YisyQmVZcEZydVZRMnFEZVhrTzdCUGZJK2RoNkNwQjErcUZPcXpnSkd1YXow?=
 =?utf-8?B?Y2pzc1AvUGlwcTNPUGhqQllvc3VST1lNS2UzWitQRi9BSUZJMi81TmlPZHNK?=
 =?utf-8?B?L2tOZkZlSTVOMDA5UzBvM1NMMFF5c3ZmNE9tSUdmdGFkWnNXaG5IRUxuc1Fz?=
 =?utf-8?B?VUN4Z1dkU05hVCtQNDlabEwvK2owS2RBcnd1MEtzYVB0L2pha25ZUFV0ajBk?=
 =?utf-8?B?R1JkNWRNNW1FL24wRUg1Z0pkcjROSEpvKzFObEJnb25GVDV1cVNpYVZ3VDli?=
 =?utf-8?B?bXVQWjBlNkpHdjlUOGUvQ1ZvNXE4MlNuSVlocmxZSmNzZkprU2lnMVdVMEpG?=
 =?utf-8?B?YU5JMTRMSjF0MEM0RjFySUhJYXFBSllrd3NtbXo4NmJVWVhMRlJibXFoaCtM?=
 =?utf-8?B?YWcvL05EOHZjNjN0S1kzd1BEQ3l5REFtczk5SVVGRkZTQVBtT01zRUNCYkRL?=
 =?utf-8?B?WnBIa2VzRVd5ZGNRRG9wY20xMTM5dTdab3IwYmVBWERvUzN1bzROc2E0VlVj?=
 =?utf-8?B?ZWdmNFVodWFaVlVuZTlrOWVGeVdabDBwaVpqa3B3RnQ5emx0cHZzdWhwMXds?=
 =?utf-8?B?Q0NzSUIxU3pObFpVODR5b0R2bFZhTWV3anJFdE5YK2NLTzBVWEMwWmJJcFNC?=
 =?utf-8?B?T1FjWUhWRVlhbU0ydTI2UVRDVDlwSG5DVzEwSXVzN1ZmbHJuMHg2OERwYVVr?=
 =?utf-8?B?TEFDWU9ROVJ0Y2xyandZSVdBdGM2Uis0YWowVmdMWklac1JycnFBTitmYjFp?=
 =?utf-8?B?TXRMcGZNVHgralplSWp2OHRzNEIrYnI4dGxwbG9iSmxveEJ4SnNDcFUvOHdM?=
 =?utf-8?B?ZWhKVGtYVTZYSnZYQng0NEFsR1I1cHI5dERQOWI0T3lGbXdQbmNTeklmUU1D?=
 =?utf-8?B?TzcvSGszWTNFL3M4MStqYkUvc0VsY2JlL2N5SVZFYU5Kb2czL2MzVW5uRG16?=
 =?utf-8?B?VXNZV29PRWlGbGZEcHNpU3hESW9xM05sU3N0aWo3dzhkTFQrSUVnaTJiejZ0?=
 =?utf-8?B?RUhRUUlqRi92QXpVazlzWkFNZEE3LzZhcVdLWWN1bENxOGFRcExGb1lNblpY?=
 =?utf-8?B?VjMyblZBbjJLaDd3a1hZcHYxR2Fic0ZDcmN5bkRGZTlzSG11SHhRQVFXcitJ?=
 =?utf-8?B?Ly8rdTM3ajF2YjhqaGZKbWZ5UFU0VHhBVkVncU14Z0RwM0FIUjZoZSszT3Yw?=
 =?utf-8?B?MjdEMkxaZEhIUlFmcXkzWmduLzBic3VOVlE2TGh0VGNWRUdNVFl2ZFpPTTlC?=
 =?utf-8?B?NlBWZHNjUGdLV0JvWWxVVDNSZk1TZG5ZcTZBRC83VnNhZHVTaHpMaTF3NjZp?=
 =?utf-8?B?bFZURG4vaDJrTWx1UnVaV0d6QXFoQlpZRnVBSHNzTjZMakpBSjZ6bFZ1R3N6?=
 =?utf-8?B?cHhoNTRvNDM5S2pQSWhadmhncUhTZ2NDeXVGRldqVGZjSTg3czZEK1BVVzFa?=
 =?utf-8?B?V1QrbTVmMmtIWmd1bEVtOE1SNytUVjRXcWhkYU05SERwZy9LV0NJaXV6enpo?=
 =?utf-8?B?Y0EwRitwZWtNTy9MY09rczhsMHJoaGRPOHB3QklERnJHOFNkU3N2QXZQZ1lp?=
 =?utf-8?B?ZGszNmtQdVBjYUJRNE5JcGVVKzM0elJOa3FXeVFLOGVWY0tOVEg2QWVwUVRZ?=
 =?utf-8?B?TTV4MnFCb2Z6MUlocDNiTmhyWXQ1RDJ4c1JmcmVlV2ZhOE1KK0JWaVBEenhL?=
 =?utf-8?B?YThvSVB6VXFOTm0vWUFKNnFBeit5anRxeVRDU2lPczVjdnY3b2x1MFRpQXF4?=
 =?utf-8?B?ZnZmV2JzVEVwdVJJOVByZ1JLeUZQWndxWmxuVFpjWU5vdzcvQlhYd0JLR3JW?=
 =?utf-8?B?M3ZNVmw0NjBtaDBzZVRlWkNXK3I0dGtMckJCb0E4eGZJMmdjYWZSU3N0UG8y?=
 =?utf-8?B?cXJZSHFibWxVOWZ1cGtUTmVVbWl5UXFUakdmNXpGdExSZEFweFE3cDVERGt6?=
 =?utf-8?B?SjRCdDF5RGtnMGRRQ1k1RC92YzNhNXp2RUFSUGhMSUVnNW96blhjZ0V0ZjJQ?=
 =?utf-8?B?QVl6Nld4SmRoOFp2aCtoNi9mRWJGQkRoamZWamJ3UDhzbklSVEtUQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c386d6f-f27d-4e11-4c1f-08da1d1e66ec
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 07:22:44.3226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i/OxM6wdXuAqydOgLu8AYU8A9jTfhw2PrD1kSPNUYk7DT1P2Ky706+KvsPcXopxhmAKkBflc/CF5V/s7t2jLfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3827

On 13.04.2022 09:15, Luca Fancellu wrote:
> 
>>>
>>> No, I'm not suggesting a new menu. I was merely wondering whether the
>>> Kconfig contents wouldn't location-wise better match where the
>>> respective source file lives.
>>
>> It could be in xen/common/sched/Kconfig at the beginning of the file
>> before creating the new "Schedulers" menu, e.g.:
>>
>> diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
>> index 3d9f9214b8..f6545f4e9b 100644
>> --- a/xen/common/sched/Kconfig
>> +++ b/xen/common/sched/Kconfig
>> @@ -1,3 +1,10 @@
>> +config BOOT_TIME_CPUPOOLS
>> + bool "Create cpupools at boot time"
>> + depends on HAS_DEVICE_TREE
>> + help
>> + Creates cpupools during boot time and assigns cpus to them. Cpupools
>> + options can be specified in the device tree.
>> +
>> menu "Schedulers"
>> 	visible if EXPERT
>>
>>
>> I think it is fine either way, so:
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> Thank you Stefano,
> 
> Jan for you is it ok at the beginning like Stefano said?

Personally I'd prefer it at the end (still outside the menu), but
really the scheduler maintainers are going to have the final say.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 07:23:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 07:23:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303938.518426 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neXLO-0007nS-DY; Wed, 13 Apr 2022 07:23:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303938.518426; Wed, 13 Apr 2022 07:23:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neXLO-0007nJ-A5; Wed, 13 Apr 2022 07:23:14 +0000
Received: by outflank-mailman (input) for mailman id 303938;
 Wed, 13 Apr 2022 07:23:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neXLN-0007mw-5c; Wed, 13 Apr 2022 07:23:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neXLN-00040K-30; Wed, 13 Apr 2022 07:23:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neXLM-0008Nx-MO; Wed, 13 Apr 2022 07:23:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neXLM-0006Iw-Lt; Wed, 13 Apr 2022 07:23:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kfymgEapZMkp0PCXGlhtfkC7o7Ov7ys5/dwyvp1jehY=; b=6gMLyqlDcRYp3DP2apnnETZm9L
	/N9l0UtozTVmFVOb254oJ4rqUo9ujuOirJPWfvv3cLtGhxWYJvWRpx14q4+LYE7JvewmIW7xZzZ9V
	68Cdxwr5dUM+ephuxgmACQx/jzeJOEsrVNfNDQ7XAeRj2abFOjTYf7CaXM0/50ykgWDw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169346-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169346: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a19944809fe9942e6a96292490717904d0690c21
X-Osstest-Versions-That:
    linux=ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 07:23:12 +0000

flight 169346 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169346/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169294

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169294
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169294
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169294
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169294
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169294
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169294
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169294
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169294
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                a19944809fe9942e6a96292490717904d0690c21
baseline version:
 linux                ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e

Last test of basis   169294  2022-04-11 03:37:59 Z    2 days
Testing same since   169346  2022-04-13 01:40:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Jones <drjones@redhat.com>
  Anup Patel <anup@brainfault.org>
  Anup Patel <apatel@ventanamicro.com>
  Bagas Sanjaya <bagasdotme@gmail.com>
  Chuck Lever <chuck.lever@oracle.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Haowen Bai <baihaowen@meizu.com>
  Heiko Stuebner <heiko@sntech.de>
  Jan Kara <jack@suse.cz>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Kees Cook <keescook@chromium.org>
  Kyle Copperfield <kmcopper@danwin1210.me>
  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  Like Xu <like.xu.linux@gmail.com>
  Like Xu <likexu@tencent.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Marc Zyngier <maz@kernel.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Pearson <markpearson@lenovo.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Mayuresh Chitale <mchitale@ventanamicro.com>
  Mikulas Patocka <mpatocka@redhat.com>
  Oliver Upton <oupton@google.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Gonda <pgonda@google.com>
  Peter Korsgaard <peter.korsgaard@barco.com>
  Peter Kästle <peter@piie.net>
  Piotr Chmura <chmooreck@gmail.com>
  Randy Dunlap <rdunlap@infradead.org>
  Reiji Watanabe <reijiw@google.com>
  Robert Schlabbach <robert_s@gmx.net>
  Sean Christopherson <seanjc@google.com>
  Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Wei Li <liwei391@huawei.com>
  Will Deacon <will@kernel.org>
  Yu Zhe <yuzhe@nfschina.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   ce522ba9ef7e..a19944809fe9  a19944809fe9942e6a96292490717904d0690c21 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 07:50:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 07:50:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303951.518436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neXlL-0002Rk-MT; Wed, 13 Apr 2022 07:50:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303951.518436; Wed, 13 Apr 2022 07:50:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neXlL-0002Qv-Iu; Wed, 13 Apr 2022 07:50:03 +0000
Received: by outflank-mailman (input) for mailman id 303951;
 Wed, 13 Apr 2022 07:50:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neXlK-0002Du-Eb; Wed, 13 Apr 2022 07:50:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neXlK-0004Sd-B2; Wed, 13 Apr 2022 07:50:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neXlJ-0000x6-VZ; Wed, 13 Apr 2022 07:50:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neXlJ-0001OZ-V8; Wed, 13 Apr 2022 07:50:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=a9y4BRrCSfMN7v5XfLhV3a3HJ3OuaimWC2JQgr329hw=; b=BxMLNdKSOoZtorx4VwhzYRWL3C
	wz/vaQqcq6EF2w7NULq3bWkbdebMXei0rc85KuMbxKyTs/GK/PVaNTmuvK21kuJN7CL5EZJWOPWxO
	qzbBjK5yePUXIB0J0a90SFR3Colg+GvSvXIB2qNQj9551cdTwNTSu5zoMfGse79U4Nqs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169351-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169351: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=a89b17c2a75cfbaeb9e430f88e0f8a7475eb4f54
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 07:50:01 +0000

flight 169351 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169351/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              a89b17c2a75cfbaeb9e430f88e0f8a7475eb4f54
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  642 days
Failing since        151818  2020-07-11 04:18:52 Z  641 days  623 attempts
Testing same since   169351  2022-04-13 04:18:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104312 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 08:26:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 08:26:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303970.518448 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neYKS-0006rG-U4; Wed, 13 Apr 2022 08:26:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303970.518448; Wed, 13 Apr 2022 08:26:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neYKS-0006r9-Qs; Wed, 13 Apr 2022 08:26:20 +0000
Received: by outflank-mailman (input) for mailman id 303970;
 Wed, 13 Apr 2022 08:26:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VMZD=UX=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1neYKQ-0006r3-RB
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 08:26:19 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20614.outbound.protection.outlook.com
 [2a01:111:f400:7d00::614])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 622a1624-bb03-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 10:26:15 +0200 (CEST)
Received: from AM6PR04CA0031.eurprd04.prod.outlook.com (2603:10a6:20b:92::44)
 by VI1PR08MB5453.eurprd08.prod.outlook.com (2603:10a6:803:132::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 08:26:02 +0000
Received: from VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:92:cafe::21) by AM6PR04CA0031.outlook.office365.com
 (2603:10a6:20b:92::44) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Wed, 13 Apr 2022 08:26:02 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT060.mail.protection.outlook.com (10.152.19.187) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 08:26:01 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Wed, 13 Apr 2022 08:26:01 +0000
Received: from 839c66ce5aae.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1B9EC368-7F73-4BC7-A4BC-6CF18C9F691A.1; 
 Wed, 13 Apr 2022 08:25:50 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 839c66ce5aae.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Apr 2022 08:25:50 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by DB7PR08MB3564.eurprd08.prod.outlook.com
 (2603:10a6:10:4f::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 08:25:48 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0%11]) with mapi id 15.20.5164.020; Wed, 13 Apr
 2022 08:25:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 622a1624-bb03-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D7nhm16zvpEznUQS8UGJAuenc1laUi2B+9iJ9ATqBwY=;
 b=LRiGF4O5ZuwG+4Wx0yCPfYvYO6UxhWxDnyi7CjB8/UeDn7pfNTYasfVcbg/PP+YZy5m4K2nAEjADenlGJCIM63zmd92lWrtp5Bj3Lxok2iEPmPs58WcvELH6P7aC9yYh0Cups2GFCGC8yEFeyHp1JDKhiVuQEX7zjT+bMrAetUg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5659e721c9ca2d37
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l9Xb2OAuOo1s2m/hDccjAQ2epOgLSm2fb29csUbrqmXa8Mg4n6jn5zXYReGIghrKzQrtvybLiV018ZoI/Kb05gQztogixeLnWYy6M9tSp3myMOp+jZTmE+zq8QI9H6f4e6xG5DeC4pPJ9bopKtWALP+P4OmoOlB9MqDEK8aP+RgXDl5sgdJO9+tltE5D7NOcDPF5sWNilpDi6TFqW5mohSkz4i/810c9pVYQ3rhBt/OduQWEfsx+e6VBQBGARcfgZ45X6FCWkHHmG/HNNDQ/Iu0+PSjJVe3OxRZt+qwDXxTYkLV8jCH0vahiEXrk+rVy/h4trzulqSvhs+bkccwxtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D7nhm16zvpEznUQS8UGJAuenc1laUi2B+9iJ9ATqBwY=;
 b=H7C6pN83GC66H1fxKnGLyTsIygVd8vsZ2pEGJVAqnNnUNAkybeU6SEhHSBFOigvUEDTPkf2x++kWNpB5LcFnq/z7MJrTjgv19p+khLyD+HDXlHgQjHJpp2412JDVS+DEYsaW5NdvvnoMuvflN0rPxIx6dx9ni9l8X5TtK8Tbb1CRPDxqUa6B3Bu/X5ZoYw4r/fBnb3jGvPR8Jr4/k7M9R8MKzXJjCFqo22nLFM2fsakyqZvaco43M0OZNLUm1gKoA83Rs2zwV3PojW08jeLCw8MYYXK3dbol7iREiqOWPa9H7xrFwonK5LMtN9GGL0RPl8E93/CRnirdSZG6W9CmWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D7nhm16zvpEznUQS8UGJAuenc1laUi2B+9iJ9ATqBwY=;
 b=LRiGF4O5ZuwG+4Wx0yCPfYvYO6UxhWxDnyi7CjB8/UeDn7pfNTYasfVcbg/PP+YZy5m4K2nAEjADenlGJCIM63zmd92lWrtp5Bj3Lxok2iEPmPs58WcvELH6P7aC9yYh0Cups2GFCGC8yEFeyHp1JDKhiVuQEX7zjT+bMrAetUg=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
Thread-Topic: [PATCH] xen/evtchn: Add design for static event channel
 signaling for domUs..
Thread-Index: AQHYPsy9MfyfmFhecEGJuSNYyusIgKzrHq6AgAKD34A=
Date: Wed, 13 Apr 2022 08:25:48 +0000
Message-ID: <3622A5B1-D64C-43D9-9AA3-2E781C2310B9@arm.com>
References:
 <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <0ecf69d2-c496-d18e-1309-f896ec6bbf4c@xen.org>
In-Reply-To: <0ecf69d2-c496-d18e-1309-f896ec6bbf4c@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 6c84e02e-14e1-42f4-8279-08da1d273eaf
x-ms-traffictypediagnostic:
	DB7PR08MB3564:EE_|VE1EUR03FT060:EE_|VI1PR08MB5453:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB5453B88E300DF0CE18ADCAF8FCEC9@VI1PR08MB5453.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KMxaHbVELO7gADIWJhMXuVIsiQb/3TL7kqUlFkKaP7SpHIIPIA1cGkWzd7jxIt1XE0my5x3Wqz6Pf9O2x/MgycBh6XKfp185HkIFZEjuMoLtSE/JkH+om+GvnmDRfreFKIftr6i8bDhMQpAmdMartWW97KhZPQseObjWcm8H0aKagd6eEd2YioLex48RI/rHnprHWlPPP+7mK/jzLpvzYUR6s0sS0wmx4p0xX6Fr35scb2fCp4ltHq6sgPrBwkyWQb4Sk3aTn/lEOQ9v1e16ikXHMUO9QmXJ/5GKGgbsZvmpsPoBNFE1k1AkWQ64JQ44QTOux12Tm/436FHdn0nTqoTD7xKjVbVBkoEY/dVgMS9Ygvigkpf6aOUKjkoHHZqPEPZA3HvV+vqZApf3F7XCKsnrO1rRz62UdNbKqUZUeTbCdf4bofGHg/W7ZkCkXjy4sGt4pcxHmjMglvbCO30+N8aAK3stY+UDDIbodq05qQXqqZ1rUqWaLAUJfGKSFkXPGEFRBCJcovdAGVtnzGE+ycxmzYeXoidTPBpef6OwEnXc/Uzr12BIFms701gHMgVAN9ngROlcPhrZaRFymfjiU9TrdJhJAlapcXu29Sq5mpX1SB2hkAAyNUa1THlHlQ1on0qfCQ/4o+zCf4qDNkMX27DdQSysVag/DvTn9tyMnp7Xfll6Xtb1B7/2JIfkZmOm4R6B+ZgVQ9FQvsrxWYDBhtOLx6TvcBhUoELskl7UZN/XhU2MEi1xSPwmIlz96W52
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(38100700002)(122000001)(6512007)(316002)(64756008)(8676002)(66446008)(4326008)(66476007)(66556008)(86362001)(8936002)(508600001)(6486002)(66946007)(53546011)(5660300002)(91956017)(2906002)(76116006)(33656002)(38070700005)(71200400001)(6506007)(2616005)(26005)(54906003)(186003)(6916009)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <4547F090560C104AAF075CD3850C5942@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3564
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	38866b00-7c4a-409e-42fb-08da1d273680
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UHnPozUeWg+wNPBvAV1KDv5Qo/S6M3ZCadnLJPWIIfXoOeG232r0w6qJXgrvh7Dy6/NIqZt95R7Sj2niFlEQhACNNypR5fde+ntObh5P+057d/pYocZLqb+WggvW7Sc/WqrVUWVmc8RXqPX5mQhcfiJaHfvRBMkho5vOiobnJGSnIaC8OIxPus2fBMhlMUJpWWpV5n1XHkO4pPgnbdRcDI6hL9LFgwJ34XGEnSk4Cf93yq/Ev1THu9YCJkuvNx4vMM+qbKyrh1krCO/DZsJNv8ksXGlFY2gonnuqTj8Ec3u4FGSL5Fdtg4pGCpivp+zoISz63fc6zac8vBL9Euyj5EzueEn3lGl8CwfEQNNTSKoGAHCf3vFzxHoGRJQpvHNBsQ/9J2oXlwE15uqoa2RpwzPfX98hQc+MftX3Nkl55gPng/G6GOy/Qwk6wYmT0Q7Is+FEiDtfIYQz1YaLX9taGk4z3h0xZE/t+8Onmgy2V6ramtOvIh8DSH+iO3ADlta49oW2AKlOjLJYFPitUpfXXt4D2fNa9CsqMWeNLBpveJk61UuIoVV3nfOmEW+mXErIl41xwjrIadtjFuPu1IsUbRewIVXUuLosGZfISXynenf/SC3gezHdpcJdCevtzC9j8qlGT7LAhzWubpROR6RggzW7n7Yq7vO83ljjxVgAN/ABY2mH6zpSJoWxefe4lEIq
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(2616005)(8676002)(6862004)(6486002)(36860700001)(316002)(2906002)(86362001)(47076005)(6506007)(336012)(82310400005)(33656002)(8936002)(81166007)(356005)(54906003)(4326008)(70206006)(70586007)(40460700003)(53546011)(508600001)(6512007)(186003)(26005)(83380400001)(36756003)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 08:26:01.7559
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c84e02e-14e1-42f4-8279-08da1d273eaf
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5453

SGVsbG8gSnVsaWVuLA0KDQpUaGFua3MgZm9yIHJldmlld2luZyB0aGUgZGVzaWduLg0KDQo+IE9u
IDExIEFwciAyMDIyLCBhdCA3OjAxIHBtLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3
cm90ZToNCj4gDQo+IEhpIFJhaHVsLA0KPiANCj4gVGl0bGU6IHMvLi4vLi4uLw0KPiANCj4gT24g
MjMvMDMvMjAyMiAxNTo0MywgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiBpbiBkb20wbGVzcyBzeXN0
ZW0uIFRoaXMgcGF0Y2ggaW50cm9kdWNlIHRoZSBuZXcgZmVhdHVyZSB0byBzdXBwb3J0IHRoZQ0K
PiANCj4gcy9pbnRyb2R1Y2UvaW50cm9kdWNlcy8NCj4gcy90aGUgbmV3L2EvDQoNCkFjay4gDQo+
IA0KPj4gc2lnbmFsaW5nIGJldHdlZW4gdHdvIGRvbVVzIGluIGRvbTBsZXNzIHN5c3RlbS4NCj4g
RGlkIHlvdSBpbnRlbmQgdG8gYWRkIGEgbmV3bGluZSBiZWZvcmUgdGhlIHNlY29uZCBzZW50ZW5j
ZT8NCg0KTm8uIEkgd2lsbCBmaXggdGhpcy4NCg0KPiANCj4+IFNpZ25lZC1vZmYtYnk6IFJhaHVs
IFNpbmdoIDxyYWh1bC5zaW5naEBhcm0uY29tPg0KPj4gLS0tDQo+PiBkb2NzL2Rlc2lnbnMvZG9t
MGxlc3MtZXZ0Y2huLm1kIHwgOTYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+
PiAxIGZpbGUgY2hhbmdlZCwgOTYgaW5zZXJ0aW9ucygrKQ0KPj4gY3JlYXRlIG1vZGUgMTAwNjQ0
IGRvY3MvZGVzaWducy9kb20wbGVzcy1ldnRjaG4ubWQNCj4+IGRpZmYgLS1naXQgYS9kb2NzL2Rl
c2lnbnMvZG9tMGxlc3MtZXZ0Y2huLm1kIGIvZG9jcy9kZXNpZ25zL2RvbTBsZXNzLWV2dGNobi5t
ZA0KPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+IGluZGV4IDAwMDAwMDAwMDAuLjZhMWI3ZThj
MjINCj4+IC0tLSAvZGV2L251bGwNCj4+ICsrKyBiL2RvY3MvZGVzaWducy9kb20wbGVzcy1ldnRj
aG4ubWQNCj4+IEBAIC0wLDAgKzEsOTYgQEANCj4+ICsjIFNpZ25hbGluZyBzdXBwb3J0IGJldHdl
ZW4gdHdvIGRvbVVzIG9uIGRvbTBsZXNzIHN5c3RlbQ0KPj4gKw0KPj4gKyMjIEN1cnJlbnQgc3Rh
dGU64oCvRHJhZnQgdmVyc2lvbg0KPj4gKw0KPj4gKyMjIFByb3Bvc2VyKHMpOiBSYWh1bCBTaW5n
aCwgQmVydHJhbmQgTWFycXVpcw0KPj4gKw0KPj4gKyMjIFByb2JsZW0gU3RhdGVtZW50Og0KPj4g
Kw0KPj4gK1RoZSBnb2FsIG9mIHRoaXMgd29yayBpcyB0byBkZWZpbmUgYSBzaW1wbGUgc2lnbmFs
aW5nIHN5c3RlbSBiZXR3ZWVuIFhlbiBndWVzdHMNCj4+ICtpbiBkb20wbGVzcyBzeXN0ZW1zLg0K
Pj4gKw0KPj4gK0luIGRvbTBsZXNzIHN5c3RlbSwgd2UgY2Fubm90IG1ha2UgdXNlIG9mIHhlbmJ1
cyBhbmQgeGVuc3RvcmUgdGhhdCBhcmUgdXNlZCBpbg0KPj4gK25vcm1hbCBzeXN0ZW1zIHdpdGgg
ZHluYW1pYyBWTXMgdG8gY29tbXVuaWNhdGUgYmV0d2VlbiBkb21haW5zIGJ5IHByb3ZpZGluZyBh
DQo+PiArYnVzIGFic3RyYWN0aW9uIGZvciBwYXJhdmlydHVhbGl6ZWQgZHJpdmVycy4NCj4+ICsN
Cj4+ICtPbmUgcG9zc2libGUgc29sdXRpb24gdG8gaW1wbGVtZW50IHRoZSBzaWduYWxpbmcgc3lz
dGVtIGJldHdlZW4gZG9tVXMgaXMgYmFzZWQNCj4+ICtvbiBldmVudCBjaGFubmVscy4NCj4+ICsN
Cj4+ICsjIyBQcm9wb3NhbDoNCj4+ICsNCj4+ICtFdmVudCBjaGFubmVscyBhcmUgdGhlIGJhc2lj
IHByaW1pdGl2ZSBwcm92aWRlZCBieSBYZW4gZm9yIGV2ZW50IG5vdGlmaWNhdGlvbnMuDQo+PiAr
QW4gZXZlbnQgY2hhbm5lbCBpcyBhIGxvZ2ljYWwgY29ubmVjdGlvbiBiZXR3ZWVuIDIgZG9tYWlu
cyAobW9yZSBzcGVjaWZpY2FsbHkNCj4+ICtiZXR3ZWVuIGRvbTEscG9ydDEgYW5kIGRvbTIscG9y
dDIpLiBUaGV5IGVzc2VudGlhbGx5IHN0b3JlIG9uZSBiaXQgb2YNCj4+ICtpbmZvcm1hdGlvbiwg
dGhlIGV2ZW50IG9mIGludGVyZXN0IGlzIHNpZ25hbGxlZCBieSB0cmFuc2l0aW9uaW5nIHRoaXMg
Yml0IGZyb20NCj4+ICswIHRvIDEuIEFuIGV2ZW50IGlzIGFuIGVxdWl2YWxlbnQgb2YgYSBoYXJk
d2FyZSBpbnRlcnJ1cHQuDQo+PiArDQo+PiArTm90aWZpY2F0aW9ucyBhcmUgcmVjZWl2ZWQgYnkg
YSBndWVzdCB2aWEgYW4gaW50ZXJydXB0IGZyb20gWGVuIHRvIHRoZSBndWVzdCwNCj4+ICtpbmRp
Y2F0aW5nIHdoZW4gYW4gZXZlbnQgYXJyaXZlcyAoc2V0dGluZyB0aGUgYml0KS4gDQo+IA0KPiBJ
IGFtIGEgYml0IGNvbmZ1c2VkIHdpdGggdGhlIGRlc2NyaXB0aW9uLiBBcmUgeW91IHRyeWluZyB0
byBleHBsYWluIHRoZSBldmVudCBjaGFubmVsIGluIGxheW1hbiB0ZXJtPyBJZiBub3QsIHRoZW4g
ZXZlbnQgY2hhbm5lbCBwcm90b2NvbCBpcyBtb3JlIGNvbXBsaWNhdGVkIHRoYW4gdGhhdCAoaW4g
cGFydGljdWxhciBmb3IgZmlmbykuDQoNClllcyBJIGFtIHRyeWluZyB0byBleHBsYWluIHRoZSBl
dmVudC1jaGFubmVsIGluIHNpbXBsZSB0ZXJtLiANCj4gDQo+PiBGdXJ0aGVyIG5vdGlmaWNhdGlv
bnMgYXJlDQo+PiArbWFza2VkIHVudGlsIHRoZSBiaXQgaXMgY2xlYXJlZCBhZ2Fpbi4NCj4gDQo+
IEkgdGhpbmsgIm1hc2tlZCIgaXMgY29uZnVzaW5nIGhlcmUuDQo+IA0KPiBUaGUgZXZlbnQgY2hh
bm5lbCBkaWZmZXJlbnRpYXRlICJtYXNrIiB2cyAicGVuZGluZyIuIFdoZW4gc2VuZGluZyBhbiBl
dmVudCwgdGhlIHBlbmRpbmcgYml0IHdpbGwgYmUgc2V0IHRvIDEuIElmIGl0IHdhc24ndCBhbHJl
YWR5IHBlbmRpbmcgYW5kIHRoZSBtYXNrIGJpdCBpcyBjbGVhciwgdGhlbiB3ZSB3aWxsIG5vdGlm
eSB0aGUgZ3Vlc3QuDQo+IA0KPiBJZiB0aGUgcGVuZGluZyBiaXQgaXMgYWxyZWFkeSBzZXQsIHRo
ZW4gd2Ugd2lsbCBpZ25vcmUuDQo+IA0KPiBJbiBmYWN0LCB0aGUgZXZlbnQgY2hhbm5lbCBpcyBh
Y3Rpbmcgc2ltaWxhcmx5IHRvIGFuIGVkZ2UgaW50ZXJydXB0LiBJIHdyb3RlIHNpbWlsYXJseSwg
YmVjYXVzZSBJSVJDIHRoZXkgYXJlIGJlaGF2aW5nIHNsaWdodGx5IGRpZmZlcmVudGx5IChzZWUg
WzFdIGZvciBtb3JlIGRldGFpbHMpLg0KDQpPay4gTGV0IG1lIG1vZGlmeSB0aGUgc2VudGVuY2Ug
aW4gbmV4dCB2ZXJzaW9uLg0KPiANCj4+IFdoZW4gYSBkb21haW4gd2FudHMgdG8gd2FpdCBmb3Ig
ZGF0YSBpdA0KPj4gK3dpbGwgYmxvY2sgdW50aWwgYW4gZXZlbnQgYXJyaXZlcywgYW5kIHRoZW4g
c2VuZCBhbiBldmVudCB0byBzaWduYWwgdGhhdCBkYXRhDQo+PiAraGFzIGJlZW4gY29uc3VtZWQu
DQo+PiBFdmVudHMgYXJlIGRlbGl2ZXJlZCBhc3luY2hyb25vdXNseSB0byBndWVzdHMgYW5kIGFy
ZQ0KPj4gK2VucXVldWVkIHdoZW4gdGhlIGd1ZXN0IGlzIG5vdCBydW5uaW5nLg0KPiANCj4gcy9n
dWVzdC9kb21haW4vIHRvIHN0YXkgY29uc2lzdGVudCBhbmQgYWxzbyBpbmNsdWRlIGRvbTAvaGFy
ZHdhcmUgZG9tYWluLg0KQWNrLg0KPiANCj4+ICsNCj4+ICtFdmVudCBjaGFubmVsIGNvbW11bmlj
YXRpb24gd2lsbCBiZSBlc3RhYmxpc2hlZCBzdGF0aWNhbGx5IGJldHdlZW4gdHdvIGRvbVUNCj4+
ICtndWVzdHMgYmVmb3JlIHVucGF1c2luZyB0aGUgZG9tYWlucyBhZnRlciBkb21haW4gY3JlYXRp
b24uIEV2ZW50IGNoYW5uZWwNCj4+ICtjb25uZWN0aW9uIGluZm9ybWF0aW9uIGJldHdlZW4gZG9t
VXMgd2lsbCBiZSBwYXNzZWQgdG8gWEVOIHZpYSBkZXZpY2UgdHJlZQ0KPj4gK25vZGUuDQo+IA0K
PiBXaHkgYXJlIHdlIGxpbWl0aW5nIG91cnNlbGYgdG8gZG9tVXM/DQoNCkFzIHRoaXMgZGVzaWdu
IGlzIGZvciBhIGRvbTBsZXNzIHN5c3RlbSBJIG1lYW4gaGVyZSB0byBhbGwgdGhlIGRvbWFpbnMg
b24gdGhlIGRvbTBsZXNzIHN5c3RlbS4NCldoYXQgSSB1bmRlcnN0YW5kIGlzIHRoYXQgYWxsIGRv
bWFpbnMgaW4gdGhlIGRvbTBsZXNzIHN5c3RlbSBhcmUgY2FsbGVkIGFzIGRvbVVzLg0KUGxlYXNl
IGNvcnJlY3QgbWUgaWYgSSBhbSB3cm9uZy4NCg0KPiANCj4+ICsNCj4+ICtVbmRlciB0aGUgL2No
b3NlbiBub2RlLCB0aGVyZSBuZWVkcyB0byBiZSBzdWIgbm9kZXMgd2l0aCBjb21wYXRpYmxlDQo+
PiArInhlbixldnRjaG4iIHRoYXQgZGVzY2liZXMgdGhlIGV2ZW50IGNoYW5uZWwgY29ubmVjdGlv
biBiZXR3ZWVuIHR3byBkb21Vcy4NCj4gDQo+IHMvZGVzY2liZXMvZGVzY3JpYmVzLw0KDQpBY2su
IA0KDQo+IA0KPj4gKw0KPj4gK1RoZSBldmVudCBjaGFubmVsIHN1Yi1ub2RlIGhhcyB0aGUgZm9s
bG93aW5nIHByb3BlcnRpZXM6DQo+PiArDQo+PiArLSBjb21wYXRpYmxlDQo+PiArDQo+PiArICJ4
ZW4sZXZ0Y2huIg0KPj4gKw0KPj4gKy0geGVuLGV2dGNobg0KPj4gKw0KPj4gKyBUaGUgcHJvcGVy
dHkgaXMgZm91ciBudW1iZXJzIG9mIHR1cGxlcyBvZg0KPj4gKyAobG9jYWwtcG9ydC1kb21VMSxk
b21VMS1waGFuZGxlLGxvY2FsLXBvcnQtZG9tVTIsZG9tVTItcGhhbmRsZSkgd2hlcmU6DQoNCj4g
VGhpcyBpcyBxdWl0ZSBkaWZmaWN1bHQgdG8gcmVhZC4gQ2FuIHdlIGFkZCBzb21lIHNwYWNlIGJl
Zm9yZS9hZnRlciBlYWNoIGNvbW1hPw0KDQpBY2suIA0KPiANCj4+ICsNCj4+ICsgbG9jYWwtcG9y
dC1kb21VMSBpcyBhbiBpbnRlZ2VyIHZhbHVlIHRoYXQgd2lsbCBiZSB1c2VkIHRvIGFsbG9jdGUg
bG9jYWwNCj4gDQo+IHMvYWxsb2N0ZS9hbGxvY2F0ZS8NCg0KQWNrLiANCj4gDQo+PiArIHBvcnQg
Zm9yIGRvbVUxIHRvIHNlbmQgYW4gZXZlbnQgbm90aWZpY2F0aW9uIHRvIHRoZSByZW1vdGUgZG9t
YWluLg0KPiANCj4gVGhlIHBvcnQgd2lsbCBiZSB1c2VkIGZvciBzZW5kaW5nIGJ1dCBhbHNvIHJl
Y2VpdmluZyBldmVudCBub3RpZmljYXRpb24uDQoNClllcy4gSSB3aWxsIG1vZGlmeS4NCj4gDQo+
IEFsc28sIEkgd291bGQgc3VnZ2VzdCB0byByZXBsYWNlICJyZW1vdGUgZG9tYWluIiB3aXRoICJk
b21VMiIuIFNvIGl0IGlzIG1vcmUgZXhwbGljaXQuDQoNCkFjay4gDQo+IA0KPj4gKw0KPj4gKyBk
b21VMS1waGFuZGxlIGlzIGEgc2luZ2xlIHBoYW5kbGUgdG8gYW4gZG9tYWluIHRvIHdoaWNoIGxv
Y2FsLXBvcnQtZG9tVTENCj4gDQo+IHMvYW4gZG9tYWluL2EgZG9tYWluLyBJIHRoaW5rLg0KDQpB
Y2suIA0KPiANCj4+ICsgd2lsbCBiZSBhbGxvY2F0ZWQuDQo+PiArDQo+PiArIGxvY2FsLXBvcnQt
ZG9tVTIgaXMgYW4gaW50ZWdlciB2YWx1ZSB0aGF0IHdpbGwgYmUgdXNlZCB0byBhbGxvY3RlIGxv
Y2FsDQo+IA0KPiBzL2FsbG9jdGUvYWxsb2NhdGUvDQoNCkFjay4gDQo+IA0KPj4gKyBwb3J0IGZv
ciBkb21VMiB0byBzZW5kIGFuIGV2ZW50IG5vdGlmaWNhdGlvbiB0byB0aGUgcmVtb3RlIGRvbWFp
bi4NCj4gDQo+IFNhbWUgYXMgYWJvdmUgZm9yICJyZW1vdGUgZG9tYWluIi4NCg0KQWNrLiAgDQoN
ClJlZ2FyZHMsDQpSYWh1bA0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 08:31:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 08:31:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303976.518459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neYPS-0008J6-Ke; Wed, 13 Apr 2022 08:31:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303976.518459; Wed, 13 Apr 2022 08:31:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neYPS-0008Iz-H9; Wed, 13 Apr 2022 08:31:30 +0000
Received: by outflank-mailman (input) for mailman id 303976;
 Wed, 13 Apr 2022 08:31:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neYPQ-0008Ip-Jb; Wed, 13 Apr 2022 08:31:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neYPQ-0005hj-FZ; Wed, 13 Apr 2022 08:31:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neYPQ-0002TD-9F; Wed, 13 Apr 2022 08:31:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neYPQ-0006m8-8r; Wed, 13 Apr 2022 08:31:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HynKpEpmMxXcgQTD6+Ocj00D+pJIGluG5wEJAHu4BXg=; b=C4tth+tKxKvXWGeki4IfKedHE/
	21ZrTYyDzdzhe9GJmcOoWsGQ5ahhz1WpPKMRFomPOdOT94t+CVSUzbLmqRrB6iBuIHrB+FM42krZQ
	jLXPQQKpkxNVnInsUM+UzrmKC48j7/IPl5DSvEmbN4pGeKdSov7y20E04MNTapTivlWY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169352-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169352: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 08:31:28 +0000

flight 169352 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169352/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  355 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 09:03:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 09:03:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303986.518470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neYu6-0003E2-6g; Wed, 13 Apr 2022 09:03:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303986.518470; Wed, 13 Apr 2022 09:03:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neYu6-0003Dv-3q; Wed, 13 Apr 2022 09:03:10 +0000
Received: by outflank-mailman (input) for mailman id 303986;
 Wed, 13 Apr 2022 09:03:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neYu5-0003Dl-Km; Wed, 13 Apr 2022 09:03:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neYu5-0006Gg-IG; Wed, 13 Apr 2022 09:03:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neYu5-0003Td-6Z; Wed, 13 Apr 2022 09:03:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neYu5-0003QJ-67; Wed, 13 Apr 2022 09:03:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CZ22fl6NdDD35n2U13UITR78MJqQpjmPGQZ+fVU9FRo=; b=xmgk9ufD041GLPvYBWuZ5muXKz
	gVfmhiM1CF/5YmkEcnIUV/A991aHVSAEJ/B8CT1scT1R3Oe7b0XshEc+ROvS9zvXgKMzaaRzieS9L
	jN6L7xaZS6HJd4rEE5liLuvuXpH9+sstM3fJQzS8PUkuEUIYoZOFfqGM6IpjNP1431gg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169357-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169357: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 09:03:09 +0000

flight 169357 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169357/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  356 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 09:30:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 09:30:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.303995.518481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZKD-0006Rf-GK; Wed, 13 Apr 2022 09:30:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 303995.518481; Wed, 13 Apr 2022 09:30:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZKD-0006RY-D4; Wed, 13 Apr 2022 09:30:09 +0000
Received: by outflank-mailman (input) for mailman id 303995;
 Wed, 13 Apr 2022 09:30:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZKC-0006RO-2F; Wed, 13 Apr 2022 09:30:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZKC-0006lO-17; Wed, 13 Apr 2022 09:30:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZKB-0004eC-Px; Wed, 13 Apr 2022 09:30:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neZKB-00052r-PC; Wed, 13 Apr 2022 09:30:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YDH4DcBp4g+kjZE4wGqjjBBZZuBXYUQJuRsl/SQoLKM=; b=eoajrS+3KfvhvGdk3d2XRnmRKC
	PfdCUCWWb97+hayTgFARolPvf1GmCrBZrBb8WQP/WgRYvw3tFlO10p62yByTRFcDsx0827L9tyRTD
	10AmEZuWzK0w0UIQpdK7BWfjlQ4R+xqd5duUgZ3KG5JlQivxzLphEwDpTVwDZZvYBn4o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169358-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169358: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 09:30:07 +0000

flight 169358 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169358/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  357 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 09:44:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 09:44:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304004.518492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZXw-00081v-Oy; Wed, 13 Apr 2022 09:44:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304004.518492; Wed, 13 Apr 2022 09:44:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZXw-00081o-LI; Wed, 13 Apr 2022 09:44:20 +0000
Received: by outflank-mailman (input) for mailman id 304004;
 Wed, 13 Apr 2022 09:44:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1neZXv-00081i-EM
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 09:44:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1neZXu-00070w-Nt; Wed, 13 Apr 2022 09:44:18 +0000
Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.7.236.29])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1neZXu-0006JW-EC; Wed, 13 Apr 2022 09:44:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=nR05iQlcVJ2C0VE1rgsjETinv2ZWE8ZVxdL572g6vr8=; b=pPUoLtzRlZ/U6d0NZGy7DpA0mi
	myk6YAPSwUApXFr60XrwmE8b1yV3+yEa4PvZWRW916/73BlsqqmsbQ5Ibz4UqUtuQaOTCV8OgOXV/
	WJsU9XN62UGQhIUfTH45u3l61jC6ixUwV+uF9nmMmWfH3R4ChkdlQxZkghIK9GyeDjc0=;
Message-ID: <4f8ae917-d5d6-d93b-b31a-d46b55fa66cd@xen.org>
Date: Wed, 13 Apr 2022 10:44:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <0ecf69d2-c496-d18e-1309-f896ec6bbf4c@xen.org>
 <3622A5B1-D64C-43D9-9AA3-2E781C2310B9@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <3622A5B1-D64C-43D9-9AA3-2E781C2310B9@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Rahul,

On 13/04/2022 09:25, Rahul Singh wrote:
>> On 11 Apr 2022, at 7:01 pm, Julien Grall <julien@xen.org> wrote:
>>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>>> ---
>>> docs/designs/dom0less-evtchn.md | 96 +++++++++++++++++++++++++++++++++
>>> 1 file changed, 96 insertions(+)
>>> create mode 100644 docs/designs/dom0less-evtchn.md
>>> diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md
>>> new file mode 100644
>>> index 0000000000..6a1b7e8c22
>>> --- /dev/null
>>> +++ b/docs/designs/dom0less-evtchn.md
>>> @@ -0,0 +1,96 @@
>>> +# Signaling support between two domUs on dom0less system
>>> +
>>> +## Current state: Draft version
>>> +
>>> +## Proposer(s): Rahul Singh, Bertrand Marquis
>>> +
>>> +## Problem Statement:
>>> +
>>> +The goal of this work is to define a simple signaling system between Xen guests
>>> +in dom0less systems.
>>> +
>>> +In dom0less system, we cannot make use of xenbus and xenstore that are used in
>>> +normal systems with dynamic VMs to communicate between domains by providing a
>>> +bus abstraction for paravirtualized drivers.
>>> +
>>> +One possible solution to implement the signaling system between domUs is based
>>> +on event channels.
>>> +
>>> +## Proposal:
>>> +
>>> +Event channels are the basic primitive provided by Xen for event notifications.
>>> +An event channel is a logical connection between 2 domains (more specifically
>>> +between dom1,port1 and dom2,port2). They essentially store one bit of
>>> +information, the event of interest is signalled by transitioning this bit from
>>> +0 to 1. An event is an equivalent of a hardware interrupt.
>>> +
>>> +Notifications are received by a guest via an interrupt from Xen to the guest,
>>> +indicating when an event arrives (setting the bit).
>>
>> I am a bit confused with the description. Are you trying to explain the event channel in layman term? If not, then event channel protocol is more complicated than that (in particular for fifo).
> 
> Yes I am trying to explain the event-channel in simple term.

I would suggest to make that clear and also point to the documentation 
for the Event Channel ABI (we have a doc for fifo at least).

>>> +
>>> +Event channel communication will be established statically between two domU
>>> +guests before unpausing the domains after domain creation. Event channel
>>> +connection information between domUs will be passed to XEN via device tree
>>> +node.
>>
>> Why are we limiting ourself to domUs?
> 
> As this design is for a dom0less system I mean here to all the domains on the dom0less system.
> What I understand is that all domains in the dom0less system are called as domUs.

It depends on whether an admin may have specific a dom0 kernel. Looking 
at Penny series to handle shared memory, it will be possible to create a 
shared region between dom0 and a dom0less domU. Most likely the user 
will also want to provide a notification communication.

So shouldn't we also provide a way to create an event channel between 
dom0 and another domU?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 09:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 09:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304009.518503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZf4-00012I-HJ; Wed, 13 Apr 2022 09:51:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304009.518503; Wed, 13 Apr 2022 09:51:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZf4-00012B-DR; Wed, 13 Apr 2022 09:51:42 +0000
Received: by outflank-mailman (input) for mailman id 304009;
 Wed, 13 Apr 2022 09:51:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1neZf3-000125-BV
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 09:51:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1neZf2-00077i-Ba; Wed, 13 Apr 2022 09:51:40 +0000
Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.7.236.29])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1neZf2-0006ji-5C; Wed, 13 Apr 2022 09:51:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=0JT6rkxBRasIQr52TMS506loTlmaQnKyglnW//h1bvo=; b=PcNuxt+3Gs8Y1LrBppE0CCT819
	XZXR/Trn0NTJbSZirC7kXSH5Fmrl2jqsMdwRaPxO2EOqcPsnWgjd6WM+lHqM3/JZrwJGr/B9ZVYbd
	KvgAzTyrTtKIfY4NM96E9hFrLqjmYA8XQIopuf2ai8cUqqHkoijAt7lkTV73XGSVC8PY=;
Message-ID: <77630661-9ce1-9dff-b050-4676f4845ce7@xen.org>
Date: Wed, 13 Apr 2022 10:51:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org,
 bertrand.marquis@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
 <0210f3c6-0f06-4ff5-9f66-8410fd540171@xen.org>
 <alpine.DEB.2.22.394.2204121332460.3066615@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204121332460.3066615@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 12/04/2022 21:39, Stefano Stabellini wrote:
>>> I should mention that it would be also possible to use sub-nodes to
>>> express this information:
>>>
>>> 2)
>>>           domU1: domU1 {
>>>               ...
>>>               /* one sub-node per local event channel */
>>>               ec1: evtchn@a {
>>>                   compatible = "xen,evtchn-v1";
>>>                   /* local-evtchn link-to-foreign-evtchn */
>>>                   xen,evtchn = <0xa &ec3>
>>>               };
>>>               ec2: evtchn@c {
>>>                   compatible = "xen,evtchn-v1";
>>>                   xen,evtchn = <0xc &ec4>
>>>               };
>>>           };
>>>
>>>           domU2: domU2 {
>>>               ...
>>>               ec3: evtchn@b {
>>>                   compatible = "xen,evtchn-v1";
>>>                   xen,evtchn = <0xb &ec1>
>>>               };
>>>               ec4: evtchn@d {
>>>                   compatible = "xen,evtchn-v1";
>>>                   xen,evtchn = <0xd &ec2>
>>>               };
>>>           };
>>>       };
>>
>> As for 1), you could combine all the ports in one node.
> 
> I thought about it but I couldn't come up with a way to do that which
> retains the simplicity of this example. The problem is that in device
> tree you can only link to nodes, not to individual properties. So I
> think we would have to have separate nodes for each event channel so
> that we could separately link to them.

Ah yes. I overlooked it when making the suggestion. That said, I think 
my point in my previous e-mail stands.

If this is too verbose, then we could provide macro to generate the 
event channel node.

> 
> Otherwise, we would have to add the foreign event channel number in
> addition to the link to be able to distinguish them. And that would
> result in duplicated information. E.g.:

This is not indeed not great.

> 
>         domU1: domU1 {
>             ...
>             /* one sub-node per local event channel */
>             ec1: evtchn@a {
>                 compatible = "xen,evtchn-v1";
>                 /* local-evtchn link-to-foreign foreign-evtchn */
>                 xen,evtchn = <0xa &ec2 0xa 0xc &ec2 0xd>
>             };
>         };
> 
>         domU2: domU2 {
>             ...
>             ec2: evtchn@b {
>                 compatible = "xen,evtchn-v1";
>                 xen,evtchn = <0xb &ec1 0xa 0xd &ec1 0xc>
>             };
>         };

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 10:00:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 10:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304015.518514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZnS-0002cr-Fy; Wed, 13 Apr 2022 10:00:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304015.518514; Wed, 13 Apr 2022 10:00:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZnS-0002ck-Cn; Wed, 13 Apr 2022 10:00:22 +0000
Received: by outflank-mailman (input) for mailman id 304015;
 Wed, 13 Apr 2022 10:00:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aogm=UX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neZnR-0002ce-MI
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 10:00:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8675d293-bb10-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 12:00:20 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-AQ0Do4-CMFWWyUUxaY1jEA-1; Wed, 13 Apr 2022 12:00:16 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM8PR04MB7316.eurprd04.prod.outlook.com (2603:10a6:20b:1c7::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 13 Apr
 2022 10:00:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Wed, 13 Apr 2022
 10:00:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8675d293-bb10-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649844019;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PQMIrFcPmVtolBh282r4JMvHWMIA/wsKbfYGuxCseDA=;
	b=CJ0Og0c6P/QBQe3IC0Vt+mefm9x3QmMoKBA7x08pM3V/gpJkLFnc5TQ0ruePB4Me79+UG8
	8O4XWKFw07wod+6KbuPghr4E3skY4NFEmRabzz7WaNj7oSd0CeaifRETfujVAQ5tjpeWwe
	ngz9gGx0D0/ucqKLaTEs1N8riBzTGaM=
X-MC-Unique: AQ0Do4-CMFWWyUUxaY1jEA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K3+8la/G5k8tnqLg3GDbwB0AdHlzGr7wDYluMoG2l5wDsMGZaYKtEDLFOV4LdhSgZ/AuPjFbtEB0oBcGhJ2qixf7PlsYEoanu6kBGkXzOFTKgskWglF/rA5Cni5J7r89AqAVDquKkpQPQDJsIC+66WXmaU5Chp47VArCYvNCadmc3b0ieq6bF3d5Frz6lPDesrT+SZ2ZY/Bt28HbynQwC2OqvlLgXsc7wyJxwGSaHMUBndj0WMfeoRjVi0m/2bnszCUf9RtNIFh/0zybzERw7//iw251Y07TlYICT9mLkNPykpTr8HdsNkUSoryQOInC8oBYzvJmWej4iQc+HYsSgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PQMIrFcPmVtolBh282r4JMvHWMIA/wsKbfYGuxCseDA=;
 b=L4WbSYuoTM4mjabzeH6P8yddNItiZIY5XkT40WYTxN+lW7RgaHoKMvGn5t9zYUg+wXSs2jHNU2ZUufO8lKG85WhZWjNIfTLVqRpXpiqw+dtVIu8idE1lR9Cbp5uHrYOVsbGdS5mWSOLTJ0Om86PXC9BpJBdFo+qPdLDgbEsLDt1c6qhRMaeH8ljGthZPunjpJp28BCeAWsHiktm6tcKPX6ohkAqsDcULamFRox1RPwWysSDeGVE8BAJvkEhyBMe76swUoWCd6K6eKTYdR1LmoGmVTNZ2ZB7Sxqhs+Sdbk57Ld89dDaN53xrkgMEs0AfjbI+B+88Z2Y7Y/0Li4pTDeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <35599105-b441-96cf-7537-ccf9dfac0934@suse.com>
Date: Wed, 13 Apr 2022 12:00:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Content-Language: en-US
To: Dario Faggioli <dfaggioli@suse.com>
Cc: "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "ohering@suse.de" <ohering@suse.de>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
 <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
 <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0090.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 17f89781-78b6-479c-9db4-08da1d34682a
X-MS-TrafficTypeDiagnostic: AM8PR04MB7316:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7316C0E3E1C516AF358C00DBB3EC9@AM8PR04MB7316.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c6jww2sYmBPQRl2zxDsr3qqarkl8M5uGXc515uAGFOnWSKDoOjJrEPN/dwp41CWFqJuVR2HG6cnt/bUATfaRKsBybRuHKUUh0DFU+cb7ooHA4yA6hsRDgoNwZZafJV9eA0sr3Sn5eu9yX4uHoM9AdwDez2O6ML5VAyhVUwlfjpjuAxBeK2BlbAzl5HggO/CWOh+7W6Wp2tQzLcCvBZdR3W69EPjWUvkyM/UPSC2qTxpzGK2YIlyZ20UKDk+SiQeSxAUUsd7HhFlv3W0+5nZbxsewMjG+wOsGwH5Ta9YdnkeOQKpMhVmQBVdE4HS4kIm1Nw83eC4BMx8y+FuGQFkOyRj8fGNtFv/5EfV3wA6Q2VBR5y+KTOvHIljgzfHvj7v9AUJMmAAx2F1aozlvzPOWbEmXFLgndnfC7GUvzGgsNjZ75GnF8nVNp2p1JiBXZipleUGkh0iH0kGy39FSfZ+xKR2jLHQiBBmM/Sa1qGZTYdkHdnBLd7U/sZyQ1KFSzY+gKSWhVNujPuL3q7SYsZHp+6/r25eV+/CKxEmuwb579VLS4i4WjuiW73z1d1qw/gHbLYQPy/alwPsTzVlAPZehKEGc0GtoFokkkVgikyktEau2pNcesPlYf1zGjIlUvQrE4V1TBGHyBdVfhKJn6//fzJlTXXujz2ISyLtlJealGeRI2gjhfLGMS/xS0HGYoR6RpXsB3on1sRr9kVFE5UQv+nvJR61ovavslAaLBdS/LX0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66946007)(66556008)(6486002)(83380400001)(26005)(36756003)(508600001)(2906002)(6506007)(31686004)(186003)(8676002)(31696002)(6862004)(4326008)(8936002)(316002)(54906003)(6512007)(37006003)(86362001)(6636002)(5660300002)(53546011)(6666004)(2616005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RnE0cUl5T0lNSUlvM2RWMjlVU1pPMzlRRkR0WWY3djlIWWlXZmhUSG5obnFJ?=
 =?utf-8?B?anVvb2dxZnpPdlVYYUVFdi8vSmkyR3UwRDJyc1IyS2hacnpVZm9MblJ5ZlRh?=
 =?utf-8?B?R3JNSWhseEZSV1EzUEtoS1JYbTFnUXRGeGR4aDBRQmhic3A2ejFHbkRyQ2dk?=
 =?utf-8?B?Y0ZQbnRqRFlHdG9CZEMzb1Q1WE1YRTBmVTZHRkwzczNuL1R1dkZNdk1wYlBE?=
 =?utf-8?B?NTRrYkNaQjVkR003L05WMUFaOG9kYlZjQmNvdGZaRzMyQ21NZ3hYRzBETThB?=
 =?utf-8?B?S1VmNnlCcG9JY1ZBWnc5azdwSjAzKzlsVzc5QjhKalFUMFMxU2pzSFNyakdq?=
 =?utf-8?B?OGFnMStJaHg5NjkvYTVWYU1FWnlaQ3VIajVXZU1EaWV3dlBESmVjOVZaNytw?=
 =?utf-8?B?L1B5SFVOQzRyT0RtcmNjVFV5Nm8yeFVzc0FXcXdkVnVJblh2SjdCRE5YMk5Z?=
 =?utf-8?B?NzgrWEVwVlFIWlQwb3dWclRucXVPOE83c3NlQzBKWkZQUUY3anM2dmxpYWFq?=
 =?utf-8?B?TUJhOUx3eFdYTmZsVVNqaG5HWi8ya3pseDI5K1lRQWJXc2ltOEJQZmtkZ3dT?=
 =?utf-8?B?SEZjZnNwU1J0M0VFajduQWhLV1hrTnVIZ09lOGtpa3VHNFdkQ2VUcDg2eVJr?=
 =?utf-8?B?MXFYaXRXT0xvT1dEVjZGamQzZnBLc0VOKzFLejJ3N0oza3MzUStmOUNXd2Zu?=
 =?utf-8?B?RHhqUk1tdHNHU25hY2dWMlF4OHBFVURNaEw5M01mZTQ3bWs3aEh6OUN1Q042?=
 =?utf-8?B?V3hHMitWbkRLSHVsTDAvdFRSZ2pCeHFOOGFzdFBMVlp5WU4ySjNOK0c1L0ZW?=
 =?utf-8?B?bzFMK2dSQi9aYnJVUXY1NHRjMTJBOERWbWxqRVQ3S00wSDZaNFRQOU91WW9O?=
 =?utf-8?B?UkFCSy8zUXJDUE5YaWJpZ0RmZ3h6Nkl2WkdyQlhMTlBDRnBRUXcxYjk0L0M4?=
 =?utf-8?B?MG4vQlREVzFTdmdITkhETHFLd0NkTnpaZllMaDRvTVZTR21DYzZSYmg4dFlZ?=
 =?utf-8?B?TXpRQnBTQ1VXRkQvUVNCSWIwY2Z5UHIybVpEV1Z2cWp0RzdxS01HYmRvcmt4?=
 =?utf-8?B?dkw5ekxtWlpNckdTRTk4TG1HdU8zOXVVZzlVN2xpTS85SFZ0U2kwUm1iVjNa?=
 =?utf-8?B?ZTBGTVR4azNHZEZBczdpRENrWjBGcmFSOUVKNmxYaW5RRFBTaVYzVGdTc2Jn?=
 =?utf-8?B?eTQ3Uk9RWG1mZWtWZ0xIVjArTzZxMnpnVTBWNnpYZFVaN0g1NjlqNkRZY0Yv?=
 =?utf-8?B?OFg0cGprZkdxMG1vSFluYWw1MUJrd1VVSzd6bXdKM05sVmFwRHhnRmN5Q0cw?=
 =?utf-8?B?RXJ6M0ZnQ3M1ZW1za1NPTDZ6bW51QjNyZjEwTURGSGtvS29FSnBLbEpTd3R1?=
 =?utf-8?B?SkR2ZW0yKzRhL0FWUTFtMEpkcXN1UDRaanJTSnlZZFFjYjBaQjBhbGxaK0wz?=
 =?utf-8?B?cnJXVHR0UVhzRGRWMHhPT05DQUduYytQMTBHeDBXcDJsallFaFVXMTBVVkxT?=
 =?utf-8?B?UDNHNStXL0VwYXdvRlMzT1MvYUFZMnZ4aHcxV3FKQmtHVUs2TmdKZ2FlVjZK?=
 =?utf-8?B?WElQWDlqY2JyWDB0K1AzWFJRV3ZCWC9oQy8zY3FUWjJObUVWN3dQSm84eXNa?=
 =?utf-8?B?TytBZ3FDSmEwNFdjL0phOTVScEZlRHl1UURiKzJwZldhWWZjWW5icytDRTVa?=
 =?utf-8?B?YjBUUnZDbGhrQmMvbjZ5Z1Q2V0x1d1laSmNmQWJoZWFINk9qUzIrMTZrSEhI?=
 =?utf-8?B?QTRCSWYrZ05RUElNYmI0L1czVUtuYzNUQThaejVZam1ZM2pIaG96cWdXNHZY?=
 =?utf-8?B?alppT290akg4SWt6QnJVaTZXUm0wZEFzT1Y4SE5MU2pVMWFpTEJEenpoOVFw?=
 =?utf-8?B?NlhyVWlrcmQydkNIVlhIL3NNOWJjc1BRclNuTzBMNzZ3WVovQ3U5VnpYdEVO?=
 =?utf-8?B?NkV6ZUVzOGxVcElvWDNjcnh4ZnVoNXVsSk5YQ0xJQjR1cC8wcmFVVm1EaGZY?=
 =?utf-8?B?UzJ1MDRJVXdUTGhoTDNLVG8wY0U3b3lvTnlnNnAwZStGbFhxMnp1V1FhUWJ1?=
 =?utf-8?B?a2Yxb1NQVkYrbHZ0Zi9SaTZXTStRZ3V0cDl0YVpEZUYxTU1KelhnVmVNd2lV?=
 =?utf-8?B?RU9LQnVIU09BcjNmNytaeERyR3dObGc4ZFZmREp3TXA5NEJsVTFNSTd4WkZH?=
 =?utf-8?B?YnFNNTR6UTNUQkVMUnBjeG13MGYwT3N4T3RhdEhaMisycFpreW01SXNKV0lh?=
 =?utf-8?B?eU4rR2UwaklkRldvelZxU0J3azFYRHlCbVo1b2hKc2JHdkp6bEJSRU41VlRL?=
 =?utf-8?B?a2grd2U0eGZWUGVnNUdNa1FWNzZvM3I1UnJRakRSZlVlQUxUOTVmUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17f89781-78b6-479c-9db4-08da1d34682a
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 10:00:15.1361
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xDEdjtmcaTsxgOujygb+QiuXRv+xCBOPAdnD5lg9G8E5fRK2VV9lf2vgrg+VPEgd7FDAvSrjsAyV9uM8Zm5GEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7316

On 12.04.2022 18:11, Dario Faggioli wrote:
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -572,11 +572,41 @@ int sched_init_vcpu(struct vcpu *v)
>      }
>  
>      /*
> -     * Initialize affinity settings. The idler, and potentially
> -     * domain-0 VCPUs, are pinned onto their respective physical CPUs.
> +     * Initialize affinity settings. By doing this before the unit is
> +     * inserted in the scheduler runqueues (by the call to sched_insert_unit(),
> +     * at the end of the function, we are sure that it will be put on an
> +     * appropriate CPU.
>       */
> -    if ( is_idle_domain(d) || (is_hardware_domain(d) && opt_dom0_vcpus_pin) )
> +    if ( pv_shim && v->vcpu_id == 0 )

I don't think you can handle the shim case first, as then you'd also have
its CPU0 idle vCPU take this path. The difference _may_ only be cosmetic,
but I think it would be odd for CPU0's idle vCPU to have a soft affinity
of just CPU0, while all others use cpumask_all.

> +    {
> +        /*
> +         * PV-shim: vcpus are pinned 1:1. Initially only 1 cpu is online,
> +         * others will be dealt with when onlining them. This avoids pinning
> +         * a vcpu to a not yet online cpu here.
> +         */
> +        sched_set_affinity(unit, cpumask_of(0), cpumask_of(0));
> +    }
> +    else if ( is_idle_domain(d) || (is_hardware_domain(d) && opt_dom0_vcpus_pin) )

Here (pre-existing) as well as ...

> +    {
> +        /*
> +         * The idler, and potentially domain-0 VCPUs, are pinned onto their
> +         * respective physical CPUs.
> +         */
>          sched_set_affinity(unit, cpumask_of(processor), &cpumask_all);
> +    }
> +    else if ( is_hardware_domain(d) )

... here I wonder: Shouldn't this be limited to Dom0 (for the purposes here
!= hwdom)? Any special affinity for a late hwdom ought to be specified by
the logic creating that domain imo, not by command line options concerning
Dom0 only.

This then also determines where the involved variables (opt_dom0_vcpus_pin,
dom0_affinity_relaxed, and dom0_cpus) are to be placed (answering your
question in a subsequent reply): If it's strictly Dom0 only (and knowing
there's no way to add vCPU-s to a domain post-construction), then
__initdata is fine for all of them. If late hwdom was to also be covered,
__hwdom_initdata would need to be used.

> +    {
> +        /*
> +         * In absence of dom0_vcpus_pin, the hard and soft affinity of
> +         * domain-0 is controlled by the dom0_nodes parameter. At this point
> +         * it has been parsed and decoded, and we have the result of that
> +         * in the dom0_cpus mask.
> +         */
> +        if ( !dom0_affinity_relaxed )
> +            sched_set_affinity(unit, &dom0_cpus, &cpumask_all);
> +        else
> +            sched_set_affinity(unit, &cpumask_all, &dom0_cpus);

I guess by referencing dom0_affinity_relaxed and dom0_cpus outside of
CONFIG_X86 section you're breaking the Arm build.

I also have a more general question here: sched.h says "Bitmask of CPUs
on which this VCPU may run" for hard affinity and "Bitmask of CPUs on
which this VCPU prefers to run" for soft affinity. Additionally there's
soft_aff_effective. Does it make sense in the first place for one to be
a proper subset of the of the other in _both_ directions? Is that mainly
to have a way to record preferences even when all preferred CPUs are
offline, to be able to go back to the preferences once CPUs come back
online?

Then a follow-on question is: Why do you use cpumask_all for soft
affinity in the first of the two calls above? Is this to cover for the
case where all CPUs in dom0_cpus would go offline?

> +    }
>      else
>          sched_set_affinity(unit, &cpumask_all, &cpumask_all);

Hmm, you leave this alone. Wouldn't it be better to further generalize
things, in case domain affinity was set already? I was referring to
the mask calculated by sched_select_initial_cpu() also in this regard.
And when I did suggest to re-use the result, I did mean this literally.

> @@ -3386,29 +3416,18 @@ void wait(void)
>  void __init sched_setup_dom0_vcpus(struct domain *d)
>  {
>      unsigned int i;
> -    struct sched_unit *unit;
>  
>      for ( i = 1; i < d->max_vcpus; i++ )
>          vcpu_create(d, i);
>  
>      /*
> -     * PV-shim: vcpus are pinned 1:1.
> -     * Initially only 1 cpu is online, others will be dealt with when
> -     * onlining them. This avoids pinning a vcpu to a not yet online cpu here.
> +     * sched_vcpu_init(), called by vcpu_create(), will setup the hard and
> +     * soft affinity of all the vCPUs, by calling sched_set_affinity() on each
> +     * one of them. We can now make sure that the domain's node affinity is
> +     * also updated accordingly, and we can do that here, once and for all
> +     * (which is more efficient than calling domain_update_node_affinity()
> +     * on all the vCPUs).
>       */
> -    if ( pv_shim )
> -        sched_set_affinity(d->vcpu[0]->sched_unit,
> -                           cpumask_of(0), cpumask_of(0));
> -    else
> -    {
> -        for_each_sched_unit ( d, unit )
> -        {
> -            if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed )
> -                sched_set_affinity(unit, &dom0_cpus, NULL);
> -            sched_set_affinity(unit, NULL, &dom0_cpus);
> -        }
> -    }
> -
>      domain_update_node_affinity(d);
>  }

I consider the comment somewhat misleading, and hence I wonder if a comment
is needed here in the first place. domain_update_node_affinity() acts on a
domain, not on individual vCPU-s. Hence it's not clear what "calling
domain_update_node_affinity() on all the vCPUs" would be referring to. I
don't think anyone would consider calling vcpu_set_affinity() here just for
the purpose of updating domain affinity, with all other (vCPU) affinity
setting now happening elsewhere.

> --- a/xen/common/sched/credit2.c
> +++ b/xen/common/sched/credit2.c
> @@ -749,10 +749,12 @@ static int get_fallback_cpu(struct csched2_unit *svc)
>  
>          /*
>           * This is cases 2 or 4 (depending on bs): v->processor isn't there
> -         * any longer, check if we at least can stay in our current runq.
> +         * any longer, check if we at least can stay in our current runq,
> +	 * if we have any (e.g., we don't yet, if we get here when a unit
> +	 * is inserted for the very first time).
>           */
> -        if ( likely(cpumask_intersects(cpumask_scratch_cpu(cpu),
> -                                       &svc->rqd->active)) )
> +        if ( likely(svc->rqd && cpumask_intersects(cpumask_scratch_cpu(cpu),
> +                                                   &svc->rqd->active)) )
>          {
>              cpumask_and(cpumask_scratch_cpu(cpu), cpumask_scratch_cpu(cpu),
>                          &svc->rqd->active);

This change is not covered by anything in the description, and I wonder why
you're making the code adjustment. If svc->rqd was NULL, wouldn't Xen have
crashed prior to the adjustment? I can't spot how it being NULL here could
be the effect of any of the other changes you're making.

If the comment adjustment is to be retained, please take care of the hard
tabs which have slipped in.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 10:00:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 10:00:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304018.518525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZnr-000318-Pl; Wed, 13 Apr 2022 10:00:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304018.518525; Wed, 13 Apr 2022 10:00:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZnr-000311-M9; Wed, 13 Apr 2022 10:00:47 +0000
Received: by outflank-mailman (input) for mailman id 304018;
 Wed, 13 Apr 2022 10:00:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZnq-00030a-Pg; Wed, 13 Apr 2022 10:00:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZnq-0007Mw-O1; Wed, 13 Apr 2022 10:00:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZnq-0005TZ-Ed; Wed, 13 Apr 2022 10:00:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neZnq-0006Dt-ED; Wed, 13 Apr 2022 10:00:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4+oClHVJKSx0tF/Nj3M1zXSrKHVF71Swp4vLy/zVqYE=; b=UVw2TRHr9ScQj0cT4OUu0QnQAF
	9pUTjm84QBz71l2k3BJ88QbajOZJ1Tl25+8GhxX5tQHPG76nevDWHYoagqnMliNv2GM0C8ruRBiKR
	PyGZLnr4DD/tDmlHMS78Lu34OWy+1F82PxqhdU/Leu/8f7oSM5RJMvdWH3TnN9SxhdRg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169359-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169359: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 10:00:46 +0000

flight 169359 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169359/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   43 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  358 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 10:06:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 10:06:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304030.518536 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZt7-0003vW-EA; Wed, 13 Apr 2022 10:06:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304030.518536; Wed, 13 Apr 2022 10:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZt7-0003vP-Av; Wed, 13 Apr 2022 10:06:13 +0000
Received: by outflank-mailman (input) for mailman id 304030;
 Wed, 13 Apr 2022 10:06:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aogm=UX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neZt5-0003vJ-SB
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 10:06:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 57e10aa5-bb11-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 12:06:10 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-fFAnIoFoPLqj9DPn8_m1sw-1; Wed, 13 Apr 2022 12:06:08 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB3967.eurprd04.prod.outlook.com (2603:10a6:803:4c::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 10:06:05 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Wed, 13 Apr 2022
 10:06:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57e10aa5-bb11-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649844370;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ScROnMGFOghzfgaHul/WGZVWFYTuMy3CnbAr0Y5DRmE=;
	b=dtNgnNS7smJKiDStqNlR5quFCEsZ5ecnuYISWctYq7lb/MJe0G3OgM16F18z+ZuSthaqjb
	JYvlKxCus77NjFQ9UYtvaRKYcJbFXLEX4ZsJMOpIMIPX2kwg/A/tyzEMqmGInGOgaTztLg
	UFYfOtvefSDzSolcopexUmwkqcFsvPA=
X-MC-Unique: fFAnIoFoPLqj9DPn8_m1sw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gg+3McMnlA7+JOEYjXazYkwuDGGRHgthW+ryw0eCOusKjlUAE33N80vWI7P7bLvhle24IjGW9AngAOlzt6ipSpj1dtgs9Fy2218R+vVUlEz/6BpbGVixyoJZ8tXBlzswDFCDoPD4eNnxWrXFj7I6+C6iIdxOxFs2PQfe6AEjJJhkUkU305HV+no+vSgVXEDgVWIRA32NjxE9suEr5vbUklDilBKYUp6w+r6+6hpl92UWSvH7DeoqOpfpkHTJuVsTEOwUKrg7fW+X+4KsbARCAGCSlOrBhoQAMGV02ANyfVKg0GNO6sTPrvkLXVlNIRk+xiiol+yemxu6FYvV733HjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ScROnMGFOghzfgaHul/WGZVWFYTuMy3CnbAr0Y5DRmE=;
 b=frsl41Ffbgz1DpOOR3CUgM4TDt4ugwI4bOtX6pH6sh7g0iBbaeg4bwZY0LB6LpNkAKQbnWVJ8VOWsYkvQhUpZzCcESVHfphA9GAypxZxds+aUZhIOwdijULYknW31unf6Y5+mqD42Y1k6N4WtrZQKdmjLy73Zr2yfDCsktbnvrBpOIQL/gWhBvqvOrtjwKooKM3RZjdinZkBKiSQqlvIjlcKgdX1yLhNq2JCkxM2sVPCeulkdc/8UyUu6H7jvguM/eTztexlJGZE7p4TvbAo8Y0ebP73zHRQwV1DAD3pYufSaMk9j1730o9BQwLV9V6gHgneolp4K2toqHYFSaXfTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <047a60f4-5737-4bb8-ad83-aff3e56be213@suse.com>
Date: Wed, 13 Apr 2022 12:06:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Content-Language: en-US
To: Dario Faggioli <dfaggioli@suse.com>
Cc: "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "ohering@suse.de" <ohering@suse.de>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
 <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
 <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
 <46feb71a14c70d24e894311e7ef9390064d6f437.camel@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <46feb71a14c70d24e894311e7ef9390064d6f437.camel@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0038.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1f2b08cd-e716-4e31-cb1f-08da1d3538a3
X-MS-TrafficTypeDiagnostic: VI1PR04MB3967:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB39676272AE1D4F83848A0612B3EC9@VI1PR04MB3967.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Cfh5yPHkq63X7Vh47kwbIiqjjH8SlZcb9yD90Dtn0+646WO4Coy2htRBBa82StcE7WwkPRp2+7UYZAsE8TxbBt4qLOMunXG0BZtJv6xSGK3NT5jQg8E25P+VuOmg/bidY1dqeeIsS/yjDPLZwoU5eGNpd59iXjQpOOAiIdLb4tB+JeshAlM6sbah16LXeC4BsC9wMCZj/mBU24MtbEK1UL8CDV6GxZkggeHNHCgBnsKhibo8oDuqnUVyhVxqr+/VKw0jjw3N7AjRqHTSdCjwkLaBfF/q+iNfp6O9HDAbzFWCKL8OxtChjwFDD5bFxVUAXchKxPv4F5qRnt2aXMrPJXvy3u5FGaxSqWAp1igf5EbfxW1rrygpCvq+e0JWUSypYKMaODMCPzdXYKg16AhIif9xsr7FsHujCt21nigKGwT3fbpHEqhxsID3CIwhd9DAvBUzdG2T/PqTUTy9VCoJ7nQhD2abhm+WeskL3OrM0+jS1yHKB8+dT5xDSCsiCCF9tQo+1x3h+By7HbG/T/RYkFaPEKm1qCuUS9oWL5JT5WYT2RC3wzmAauZxLuFKwCw+ylVsMWxmrWeiygiyeWQElq429cBP1Sdvb7ozNqsTkXmJ834jId4b9O8jEoRrmi0q3VP57V/pSl3v65XmjOPU+pq7/REInkP5l9gNi1bbvNtirjeKoE4TQhkA4I+/4nJoIXd83Hwwquitx6VM5LLgDQjzs6EqvlNZah6PV2XNyjA6re9hHWYVSGTGNPR2p61y
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(66556008)(4326008)(66946007)(54906003)(31696002)(6636002)(37006003)(6512007)(6666004)(53546011)(36756003)(86362001)(83380400001)(31686004)(66476007)(8676002)(6506007)(6486002)(2616005)(38100700002)(316002)(2906002)(5660300002)(26005)(8936002)(6862004)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Um1VKytBT2NTVm8vVmdZUWxtc2JpZDVNRTltNjZWMGduVUY3VDRNRk9ScXhS?=
 =?utf-8?B?K3RBS1IrSHh3bXF6eHgwZklQQ1oyUWdTL0duSldqR2RDeHF4bU5vMkVuQ2g5?=
 =?utf-8?B?bExTVUIzdHVXZmtZWjE4aUVMRk1VeFFRcjRYelBWL0VGRmRvcmI4enQ2ZmpD?=
 =?utf-8?B?NkQxNzFYYmMvQzVtZXBZR2pMVFNOTldLbzllQktjVnB2RkplNXhRN2UxUFZE?=
 =?utf-8?B?SVowWUh6c2xURjRlUzlFYzB4K0RkSGFqdUZscGhVNVlabGpCUk9EdkpjTytv?=
 =?utf-8?B?Y3FRRGNxMlpHMGRKOXp3cXF2ZEJDZnNYRmJKWVlXcWRJOUlTNzcxRGFBdERv?=
 =?utf-8?B?UXA3MTZUWXVzV29oM1JrOU1GWnZSU3BoZ3ZGc0JOd2FFZERIbmNJTGNPbVlG?=
 =?utf-8?B?TFhEVUpWQTBlS2loNG8rbEJnTHo2STZGSSt3b011SkkvbU9NZDU2VVN3bzdG?=
 =?utf-8?B?aE1DaVE3aXpTYjFSUjRQVDVQRFhqYXRVNlpqeVk0cjF2aDVPdEhkN1o4b2NL?=
 =?utf-8?B?bmxXL29ycDNoS0ptOVNOdWdraXo3ZHlxazdWZmZaRjY3TGo2c3JqbFdKOXVl?=
 =?utf-8?B?djJVT1VQR3h4d2l3WFVEV2dQYWxzS3FxaGtVQUZWeXlTSStGQTFjdzlRYTBY?=
 =?utf-8?B?NEg2eGVjaVlyMWM4NjhKMW1OaWJISHJMK0FzVC9DcjJpdVhBRUdzWk1JN0Q2?=
 =?utf-8?B?Rm1jZDJOUkdmdGlZUnlLNjVCdEVEVHJaQ2MxbEMrdjVJNkg5a1hnemdkMGNF?=
 =?utf-8?B?ZU4zZnp5dTFsV3ZkaW9CSDdhdzEvVXNJYnNLcS9iQkhRQmtSZUdadS9LYzZY?=
 =?utf-8?B?OTJWWlJhNXZVNDVOZCt0TEFzOVZ3UkxRMHVHYWlYTyswcHIwV0t6dWc0Ymt1?=
 =?utf-8?B?Um52b01xSkFhY3NOR2k4UGpBM3lTU21IMG8xTDZheTBkR2xVOUliQUZFYndE?=
 =?utf-8?B?ZUlDVlJFd0toaXVuN0NqWnBIbUZpcXRIVWNBN1UwU2N1V0M0Y3BCNkVOTGl6?=
 =?utf-8?B?TVo4TmpXWEhCZlZONnk5WWRwODdIZlJCS29QVjdzV1JwdmlqTUF6UHpsQTQx?=
 =?utf-8?B?UmtTWFV0cDkyR1dMNnBOYVBXR2xVUlU2T2YvT3BBVWNRMWp6RWh2OHFTYmNu?=
 =?utf-8?B?UngrbklvQWtaWjFzN0xDSDBraVBkWkNJUzFNQ3RlaUZxN0JNVFRPV1VLZXhM?=
 =?utf-8?B?UkpLbFIrdWg4L3prT0VlNmpKallXdHo0Ni9XcVpRUGk2S2ljYWlyV3plUktS?=
 =?utf-8?B?VytDK0xZQ0FCckRPZzVaRTNONUhhVFlGdk9uODA0cVZxc1dSWVJLYTlmRnFz?=
 =?utf-8?B?WFZIQ3I0Wjloa0xBRVZlTzNDeis1K2p1NzRTZXpNa1dxaEFvSzdKY0oycWcz?=
 =?utf-8?B?Tjh6QXpVajh6T2VWWjU2THFTTlliU2RUT2sxM0xCbWRJTVJqT203YlgxakM0?=
 =?utf-8?B?T1hybkhBVi9kM0FCTjgrbEZMNWlqNVp2OXpEVDlmTGQzOHB6dXJhNDhGaWdB?=
 =?utf-8?B?Mi91R1lpRkV2OEtUdERZMklaeExiSFB4UktxQ2crYkVKSHN2YUphUVlmWnlK?=
 =?utf-8?B?cTFvWEJVRTU2aEN4d090M1M5bHdHSU1uSnk2VkFSMk95NUZpY0NzYzlKZU0y?=
 =?utf-8?B?YmhrQ3E1R1dPV21vTitwcTYwMUJweUFWVGRvQlE2YWRGcVN3VU8zZ1BBUzhY?=
 =?utf-8?B?T2dXZUpNcjdZSGkwdzRBUWtNSC9PV3NvTFdzUGVkMUZPVnlsSlp1N2xuR2FI?=
 =?utf-8?B?NjB0QUgvb0ZJVUJSaXJhNWZCMFZJZDl2TjB2bnlVVms5M2RKaUN5K0NvSWc5?=
 =?utf-8?B?M1VabWc4TWttYTZpLzdmVytVbE9zNEY1T3VXZjlPa3IvMWpteUp6N3lZSUxZ?=
 =?utf-8?B?ZGZubm9SaDlRZGkzdUdCY0dxU1UzL3M0MTgrTno1MmNvWlFUbkFkbW5YdXly?=
 =?utf-8?B?cDEzYklpbDZmTjNFaU1sdEtDaFRobzZaNlRnK0tPcG9pNUJ6NkNSK201RzR2?=
 =?utf-8?B?VW5aNjZIbXRvcTBJcU5wcDF6cExKVW8waHlvQ2hxeGFyYldFc3Q2dTZmUGhw?=
 =?utf-8?B?MXlTOU8xUG9WTW1yb3pHb0x2QUZFVTQ0eDZQKzdEbHFWejk0aHVOMlZ5V09k?=
 =?utf-8?B?bWF5cUdNbm9vdi9FdjNFTTVobTVNT3REMW1WT3QvMndNODRtVmVuQXdIa3ZF?=
 =?utf-8?B?OS9mVTVCNnpPbW8yaXhTN1FtR3dhWHo3YnVLV2hCK09sQUoxczduLytid20y?=
 =?utf-8?B?dllIQVc2L0ZwblpNZDd0NnR5blNMVlVNV2VsY3hkOEdtQjNKeTluOWk1Z1E0?=
 =?utf-8?B?NXdyZkNKVGt5aTlVbllPbXBGci8xdVJJanRXYnBGMWYyU1VUOFVxQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f2b08cd-e716-4e31-cb1f-08da1d3538a3
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 10:06:05.0045
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lZ7tEkj/4M06WVZ2mdMeLjsw441IcbGpVxqovxYryxV6g1dxvQB647DbiWr2oB+P8MRArlCvlC7tt6lvPYvE8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3967

On 12.04.2022 18:14, Dario Faggioli wrote:
> On Tue, 2022-04-12 at 16:11 +0000, Dario Faggioli wrote:
>> On Tue, 2022-04-12 at 15:48 +0000, Dario Faggioli wrote:
>>> On Fri, 2022-04-08 at 14:36 +0200, Jan Beulich wrote:
>>>
>>>
>>> And while doing that, I think we should consolidate touching the
>>> affinity only there, avoiding altering it twice. After all, we
>>> already
>>> know how it should look like, so let's go for it.
>>>
>>> I'll send a patch to that effect, to show what I mean with this. 
>>>
>> Here it is.
>>
> And here's Jan's patch, ported on top of it.
> 
> As for the one before, let me know what you think.
> ---
> From: Dario Faggioli <dfaggioli@suse.com>
> Subject: [PATCH 2/2] (Kind of) rebase of "x86: make "dom0_nodes=" work with credit2"
> 
> i.e., Jan's patch, on top of the commit that unifies the affinity
> handling for dom0 vCPUs.
> 
> Although not technically necessary any longer, for fixing the issue
> at hand, I think it still makes sense to have it in the code.

I don't think so. My suggestion in this regard was only since with my
patch adjustments to affinity remained in sched_setup_dom0_vcpus().
With them all gone, I don't see why vCPU-s might still need migrating.
In fact I would consider making such "adjustment" here would be
papering over issues elsewhere.

As a result, if you think it's still wanted, ...

> Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
> ---
> * Changelog is so much RFC that is not even a changelog... Jan, if we go
>   ahead with this approach, let me know how you prefer to handle the
>   authorship, the S-o-b, etc, of this patch.
> 
>   I believe it should be From: you, with my S-o-b added after yours, but
>   I'm fine being the author, if you don't want to.

... I think you should be considered the author. It would make sense
for me to be the author only if affinity adjustments remained in the
function after your earlier patch.

Jan

> ---
>  xen/common/sched/core.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index dc2ed890e0..e11acd7b88 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -3416,6 +3416,7 @@ void wait(void)
>  void __init sched_setup_dom0_vcpus(struct domain *d)
>  {
>      unsigned int i;
> +    struct sched_unit *unit;
>  
>      for ( i = 1; i < d->max_vcpus; i++ )
>          vcpu_create(d, i);
> @@ -3423,11 +3424,20 @@ void __init sched_setup_dom0_vcpus(struct domain *d)
>      /*
>       * sched_vcpu_init(), called by vcpu_create(), will setup the hard and
>       * soft affinity of all the vCPUs, by calling sched_set_affinity() on each
> -     * one of them. We can now make sure that the domain's node affinity is
> -     * also updated accordingly, and we can do that here, once and for all
> -     * (which is more efficient than calling domain_update_node_affinity()
> -     * on all the vCPUs).
> +     * one of them. What's remaining for us to do here is:
> +     * - make sure that the vCPUs are actually migrated to suitable CPUs
> +     * - update the domain's node affinity (and we can do that here, once and
> +     *   for all, as it's more efficient than calling domain_update_node_affinity()
> +     *   on all the vCPUs).
>       */
> +    for_each_sched_unit ( d, unit )
> +    {
> +	spinlock_t *lock = unit_schedule_lock_irq(unit);
> +        sched_unit_migrate_start(unit);
> +        unit_schedule_unlock_irq(lock, unit);
> +        sched_unit_migrate_finish(unit);
> +    }
> +
>      domain_update_node_affinity(d);
>  }
>  #endif



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 10:10:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 10:10:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304036.518547 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZwm-0004at-3P; Wed, 13 Apr 2022 10:10:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304036.518547; Wed, 13 Apr 2022 10:10:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZwl-0004am-VU; Wed, 13 Apr 2022 10:09:59 +0000
Received: by outflank-mailman (input) for mailman id 304036;
 Wed, 13 Apr 2022 10:09:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VMZD=UX=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1neZwk-0004ag-5M
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 10:09:58 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03on0602.outbound.protection.outlook.com
 [2a01:111:f400:fe08::602])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de0376cd-bb11-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 12:09:56 +0200 (CEST)
Received: from DB9PR02CA0028.eurprd02.prod.outlook.com (2603:10a6:10:1d9::33)
 by AS8PR08MB7144.eurprd08.prod.outlook.com (2603:10a6:20b:404::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 10:09:53 +0000
Received: from DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d9:cafe::6) by DB9PR02CA0028.outlook.office365.com
 (2603:10a6:10:1d9::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Wed, 13 Apr 2022 10:09:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT059.mail.protection.outlook.com (10.152.21.175) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 10:09:52 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Wed, 13 Apr 2022 10:09:52 +0000
Received: from e19387a17f8a.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 203815F5-64B8-46C7-B69D-BB56B5AE0F84.1; 
 Wed, 13 Apr 2022 10:09:41 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e19387a17f8a.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Apr 2022 10:09:41 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by PA4PR08MB5981.eurprd08.prod.outlook.com
 (2603:10a6:102:e2::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 10:09:39 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0%11]) with mapi id 15.20.5164.020; Wed, 13 Apr
 2022 10:09:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de0376cd-bb11-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fZJR5Xmt0cfoBLY7bLnm+UBlr6Y4NafBIQQpOJxvzZc=;
 b=ANgw+7Wqf8FW44RqSxwSbgz4RPp/zE0U21x6pezctJap8jecFvRYQO1Hii2mnZVyjTk+IHGhna2EIymT7o7+/cpB6IvsNYoJwLdFb5aOVX+uHdJHgPFSml9pTDOqUDGbNwqnXtwGRlizK7yIX8EFNUe0KNbvVpIfYCUrdDNXz+E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 498893f2b231f21c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WxOF+/cc4fdonXLYnkPBYpyoGXvrk6vCnBGufEYXUtpoGUvpxAEq2Jsy8Z3hTrtiEcVACPJwsRpFNkJGfiG/OT7NYicG3I0FhbKOjB17b2XogriZBfUD7KhjHk5SRGhfTauAvj/Zv7EE6XaTHYPs/0Jq9j/hAjw2bFdtoNxCsmHOVjqfaOucsIXVtCW2Os9AUUZzrmICW700mSDmgPhgUUFF9GDTiK+/pZrt9b30tMxe4351Qxi/acp9EDNgpV81eSyXqGgueX79muAoJnMVR/N/g4HlCGg4e6wehoAgaAlc2nup3cAiMGVj9twMdZrpr5W1q6zfnefFtqaA9ZDpAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fZJR5Xmt0cfoBLY7bLnm+UBlr6Y4NafBIQQpOJxvzZc=;
 b=UvJ5t9bAH5sHT5PGgW2ocLJFyQbYTVsksB4LwtybfWrU4/2tlNJpsSCO7noQV/+TB8AHmKCoYmXOlNa4JLnCJDT4tiWCAGBuG7vmQ96F+6Ai1ahFE7egoIML8+P6zwHMIEj2E/Q777jlxgu/GjOK3PdaZ90IvkEyRfSrlDOXyr/CIwECd/rWycCtudNFlPMDhCCxrEeGONJLWb+hI7QJsdupgvF3pw4Cx5R3DF6t9QIxoV5cKsYYx18sbSPc/arOzrmXrDUIMZ/i8qqLBTrlOn0kO0ycHbtgh0rmQ98dlXoXhhsHnoT++an+2KiBnOEz6jWdT7Gri7qZz6JCmtzDHQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fZJR5Xmt0cfoBLY7bLnm+UBlr6Y4NafBIQQpOJxvzZc=;
 b=ANgw+7Wqf8FW44RqSxwSbgz4RPp/zE0U21x6pezctJap8jecFvRYQO1Hii2mnZVyjTk+IHGhna2EIymT7o7+/cpB6IvsNYoJwLdFb5aOVX+uHdJHgPFSml9pTDOqUDGbNwqnXtwGRlizK7yIX8EFNUe0KNbvVpIfYCUrdDNXz+E=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
Thread-Topic: [PATCH] xen/evtchn: Add design for static event channel
 signaling for domUs..
Thread-Index: AQHYPsy9MfyfmFhecEGJuSNYyusIgKzrHq6AgAKD34CAABXsgIAABxUA
Date: Wed, 13 Apr 2022 10:09:37 +0000
Message-ID: <8D312C7F-DF7D-4961-BF9A-4D76C8EA91CD@arm.com>
References:
 <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <0ecf69d2-c496-d18e-1309-f896ec6bbf4c@xen.org>
 <3622A5B1-D64C-43D9-9AA3-2E781C2310B9@arm.com>
 <4f8ae917-d5d6-d93b-b31a-d46b55fa66cd@xen.org>
In-Reply-To: <4f8ae917-d5d6-d93b-b31a-d46b55fa66cd@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 92e3aabf-2312-481c-9e35-08da1d35c05c
x-ms-traffictypediagnostic:
	PA4PR08MB5981:EE_|DB5EUR03FT059:EE_|AS8PR08MB7144:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB7144604288C4960C003522DDFCEC9@AS8PR08MB7144.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 kopzkQSCIWRyq5QQEUQXXO5DOVicyN8rsu0+swdzEruLL/Q1mTivajcGVsgZFpajuybla2LIDzEyDw8Tly+q9d24w3j5SMz/GgcgMiN3Om96FBuD9UGb3JsDkyIncGAG4ah9ebC9pRCiqtJd7KawIvw1gk0YazRpT72BVAtnYHtxGdG4pZW5+zJY2tNejkci0Uz4mwmS4IWAIRpvzcbb+3CtMxCTJAaK5BwIptPVTzxxUUDn+GxVAxweWXTPY+hD2f/ZLlq7TQoSzN1weuyO2jZIhZl6GmDPxGKwyIE4Ijyx8o9ZH+Cr2wejDVK76e6bMOqs3Yas9EFwezxOnwhMgGfNMsXpTfNJ8nZuRBLAGEfU5uqYU3PFIN52afwi45P1dkMqhwYcqBIGoAJzk/QakmbuZx7W23N3+uJ7ClFPzJ1HHsATFJ/RA805yRaEspfYwytOtnpyvWvDb6xpfmkkK+eZt56Eu9uDXa98K/qGR5sb5EFiTu3qpMg5Jl40rym8QeaiUHbrVi2cXcTQ8A7/M0dTk/nuvrpEgLwkrSy8uoePFtxQaOikhmmX79E+qDvqn3vnjNPE18u4YCTbLr8G0lGJnB9kXZegF9gsXtSXMMnI4n9Prp0K736Li/Zg665t1R9fv+Fh+EaHmX2Uiga+ABdLNSNwU/hpyUSdheAMgWGIWPODl368xWcc1pQaqyFxGGG9g8dY8sN8wXms4baIAHpUAFH/ucBdzvU2IVXmErlBrZINTE3hjhR7c6tskTwg
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(33656002)(54906003)(6916009)(508600001)(38100700002)(8676002)(71200400001)(66476007)(76116006)(64756008)(66556008)(4326008)(91956017)(66946007)(66446008)(6512007)(5660300002)(6506007)(6486002)(36756003)(53546011)(316002)(186003)(122000001)(2616005)(26005)(83380400001)(8936002)(86362001)(2906002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <2E6E57EEE5894A469830A949A30F7748@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5981
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d08e01b5-eea5-4034-0445-08da1d35b823
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	V0t5BkfAW6XTA7YfjyKLRfCLnZNP1oGaRacP5+CenbKRCwq8SmnD7cBjz0+m+Cbv5fn0GVj5l6oWhpQZAo1S3lo/KbaECnUAt6zwN//KQlQWIDRHtL9Wae3rii/wiHaxd9CR2jCqcPaMGCJgDo0xNM97QTutxSFWB4mLGBhfIM4FeSOKHrcTdNpThhoGrgNFs1osrjTBP47jjRuQeGGS8UH0JB54QCJYTq13PV8Lc5D+PVpCbOZijQS8hgWFkUH4Zki7vUZNeybFj+ihcHG+vxLDMJK+DKL1+20lyCTovo2D0AY8+uDOHvC47z35n1SCKcx0nUoZWoS4u+l8shC4bBFhbkvByprQRDPbIlxJOfYEQBPyCVFaEx51jK5pOhA5dTfMLg0DGjW3j5YL8kgNWPpRPiIhj5G5/AAAeTzAlqbifxC3JxvRgfzDRNaK4Q7tDxXISo/U4U4ZWPuq5LXeTjq61eO39uJ9B0UEzuYm21q0ruHyFWskmXcVKQf4gwz09htxACNi/9SX2PgBzFDEzSzG7k/HTolviG5oCgZByERp58aaYIaYZgYFS6AiL9CThFk99aRI0VQRyaOI4moz5vYXhJMPJSwcPEluEusOAZ1RBwVZBb7iNdI5o8HbbCBN0vP8W232vllnAlBO8xD4s7R5UIvbk/M6dN8HC6oVjXZyIX/1VrCv10wq6qIddnIy
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(53546011)(6506007)(47076005)(26005)(6512007)(508600001)(6862004)(86362001)(8676002)(316002)(70586007)(54906003)(4326008)(83380400001)(40460700003)(8936002)(6486002)(70206006)(2616005)(186003)(336012)(81166007)(356005)(36860700001)(36756003)(82310400005)(33656002)(2906002)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 10:09:52.4009
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 92e3aabf-2312-481c-9e35-08da1d35c05c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7144

SGVsbG8gSnVsaWVuLA0KDQo+IE9uIDEzIEFwciAyMDIyLCBhdCAxMDo0NCBhbSwgSnVsaWVuIEdy
YWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBSYWh1bCwNCj4gDQo+IE9uIDEz
LzA0LzIwMjIgMDk6MjUsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+IE9uIDExIEFwciAyMDIyLCBh
dCA3OjAxIHBtLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4gU2ln
bmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+DQo+Pj4+IC0tLQ0K
Pj4+PiBkb2NzL2Rlc2lnbnMvZG9tMGxlc3MtZXZ0Y2huLm1kIHwgOTYgKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrDQo+Pj4+IDEgZmlsZSBjaGFuZ2VkLCA5NiBpbnNlcnRpb25zKCsp
DQo+Pj4+IGNyZWF0ZSBtb2RlIDEwMDY0NCBkb2NzL2Rlc2lnbnMvZG9tMGxlc3MtZXZ0Y2huLm1k
DQo+Pj4+IGRpZmYgLS1naXQgYS9kb2NzL2Rlc2lnbnMvZG9tMGxlc3MtZXZ0Y2huLm1kIGIvZG9j
cy9kZXNpZ25zL2RvbTBsZXNzLWV2dGNobi5tZA0KPj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0K
Pj4+PiBpbmRleCAwMDAwMDAwMDAwLi42YTFiN2U4YzIyDQo+Pj4+IC0tLSAvZGV2L251bGwNCj4+
Pj4gKysrIGIvZG9jcy9kZXNpZ25zL2RvbTBsZXNzLWV2dGNobi5tZA0KPj4+PiBAQCAtMCwwICsx
LDk2IEBADQo+Pj4+ICsjIFNpZ25hbGluZyBzdXBwb3J0IGJldHdlZW4gdHdvIGRvbVVzIG9uIGRv
bTBsZXNzIHN5c3RlbQ0KPj4+PiArDQo+Pj4+ICsjIyBDdXJyZW50IHN0YXRlOuKAr0RyYWZ0IHZl
cnNpb24NCj4+Pj4gKw0KPj4+PiArIyMgUHJvcG9zZXIocyk6IFJhaHVsIFNpbmdoLCBCZXJ0cmFu
ZCBNYXJxdWlzDQo+Pj4+ICsNCj4+Pj4gKyMjIFByb2JsZW0gU3RhdGVtZW50Og0KPj4+PiArDQo+
Pj4+ICtUaGUgZ29hbCBvZiB0aGlzIHdvcmsgaXMgdG8gZGVmaW5lIGEgc2ltcGxlIHNpZ25hbGlu
ZyBzeXN0ZW0gYmV0d2VlbiBYZW4gZ3Vlc3RzDQo+Pj4+ICtpbiBkb20wbGVzcyBzeXN0ZW1zLg0K
Pj4+PiArDQo+Pj4+ICtJbiBkb20wbGVzcyBzeXN0ZW0sIHdlIGNhbm5vdCBtYWtlIHVzZSBvZiB4
ZW5idXMgYW5kIHhlbnN0b3JlIHRoYXQgYXJlIHVzZWQgaW4NCj4+Pj4gK25vcm1hbCBzeXN0ZW1z
IHdpdGggZHluYW1pYyBWTXMgdG8gY29tbXVuaWNhdGUgYmV0d2VlbiBkb21haW5zIGJ5IHByb3Zp
ZGluZyBhDQo+Pj4+ICtidXMgYWJzdHJhY3Rpb24gZm9yIHBhcmF2aXJ0dWFsaXplZCBkcml2ZXJz
Lg0KPj4+PiArDQo+Pj4+ICtPbmUgcG9zc2libGUgc29sdXRpb24gdG8gaW1wbGVtZW50IHRoZSBz
aWduYWxpbmcgc3lzdGVtIGJldHdlZW4gZG9tVXMgaXMgYmFzZWQNCj4+Pj4gK29uIGV2ZW50IGNo
YW5uZWxzLg0KPj4+PiArDQo+Pj4+ICsjIyBQcm9wb3NhbDoNCj4+Pj4gKw0KPj4+PiArRXZlbnQg
Y2hhbm5lbHMgYXJlIHRoZSBiYXNpYyBwcmltaXRpdmUgcHJvdmlkZWQgYnkgWGVuIGZvciBldmVu
dCBub3RpZmljYXRpb25zLg0KPj4+PiArQW4gZXZlbnQgY2hhbm5lbCBpcyBhIGxvZ2ljYWwgY29u
bmVjdGlvbiBiZXR3ZWVuIDIgZG9tYWlucyAobW9yZSBzcGVjaWZpY2FsbHkNCj4+Pj4gK2JldHdl
ZW4gZG9tMSxwb3J0MSBhbmQgZG9tMixwb3J0MikuIFRoZXkgZXNzZW50aWFsbHkgc3RvcmUgb25l
IGJpdCBvZg0KPj4+PiAraW5mb3JtYXRpb24sIHRoZSBldmVudCBvZiBpbnRlcmVzdCBpcyBzaWdu
YWxsZWQgYnkgdHJhbnNpdGlvbmluZyB0aGlzIGJpdCBmcm9tDQo+Pj4+ICswIHRvIDEuIEFuIGV2
ZW50IGlzIGFuIGVxdWl2YWxlbnQgb2YgYSBoYXJkd2FyZSBpbnRlcnJ1cHQuDQo+Pj4+ICsNCj4+
Pj4gK05vdGlmaWNhdGlvbnMgYXJlIHJlY2VpdmVkIGJ5IGEgZ3Vlc3QgdmlhIGFuIGludGVycnVw
dCBmcm9tIFhlbiB0byB0aGUgZ3Vlc3QsDQo+Pj4+ICtpbmRpY2F0aW5nIHdoZW4gYW4gZXZlbnQg
YXJyaXZlcyAoc2V0dGluZyB0aGUgYml0KS4NCj4+PiANCj4+PiBJIGFtIGEgYml0IGNvbmZ1c2Vk
IHdpdGggdGhlIGRlc2NyaXB0aW9uLiBBcmUgeW91IHRyeWluZyB0byBleHBsYWluIHRoZSBldmVu
dCBjaGFubmVsIGluIGxheW1hbiB0ZXJtPyBJZiBub3QsIHRoZW4gZXZlbnQgY2hhbm5lbCBwcm90
b2NvbCBpcyBtb3JlIGNvbXBsaWNhdGVkIHRoYW4gdGhhdCAoaW4gcGFydGljdWxhciBmb3IgZmlm
bykuDQo+PiBZZXMgSSBhbSB0cnlpbmcgdG8gZXhwbGFpbiB0aGUgZXZlbnQtY2hhbm5lbCBpbiBz
aW1wbGUgdGVybS4NCj4gDQo+IEkgd291bGQgc3VnZ2VzdCB0byBtYWtlIHRoYXQgY2xlYXIgYW5k
IGFsc28gcG9pbnQgdG8gdGhlIGRvY3VtZW50YXRpb24gZm9yIHRoZSBFdmVudCBDaGFubmVsIEFC
SSAod2UgaGF2ZSBhIGRvYyBmb3IgZmlmbyBhdCBsZWFzdCkuDQoNCkFjay4gDQo+IA0KPj4+PiAr
DQo+Pj4+ICtFdmVudCBjaGFubmVsIGNvbW11bmljYXRpb24gd2lsbCBiZSBlc3RhYmxpc2hlZCBz
dGF0aWNhbGx5IGJldHdlZW4gdHdvIGRvbVUNCj4+Pj4gK2d1ZXN0cyBiZWZvcmUgdW5wYXVzaW5n
IHRoZSBkb21haW5zIGFmdGVyIGRvbWFpbiBjcmVhdGlvbi4gRXZlbnQgY2hhbm5lbA0KPj4+PiAr
Y29ubmVjdGlvbiBpbmZvcm1hdGlvbiBiZXR3ZWVuIGRvbVVzIHdpbGwgYmUgcGFzc2VkIHRvIFhF
TiB2aWEgZGV2aWNlIHRyZWUNCj4+Pj4gK25vZGUuDQo+Pj4gDQo+Pj4gV2h5IGFyZSB3ZSBsaW1p
dGluZyBvdXJzZWxmIHRvIGRvbVVzPw0KPj4gQXMgdGhpcyBkZXNpZ24gaXMgZm9yIGEgZG9tMGxl
c3Mgc3lzdGVtIEkgbWVhbiBoZXJlIHRvIGFsbCB0aGUgZG9tYWlucyBvbiB0aGUgZG9tMGxlc3Mg
c3lzdGVtLg0KPj4gV2hhdCBJIHVuZGVyc3RhbmQgaXMgdGhhdCBhbGwgZG9tYWlucyBpbiB0aGUg
ZG9tMGxlc3Mgc3lzdGVtIGFyZSBjYWxsZWQgYXMgZG9tVXMuDQo+IA0KPiBJdCBkZXBlbmRzIG9u
IHdoZXRoZXIgYW4gYWRtaW4gbWF5IGhhdmUgc3BlY2lmaWMgYSBkb20wIGtlcm5lbC4gTG9va2lu
ZyBhdCBQZW5ueSBzZXJpZXMgdG8gaGFuZGxlIHNoYXJlZCBtZW1vcnksIGl0IHdpbGwgYmUgcG9z
c2libGUgdG8gY3JlYXRlIGEgc2hhcmVkIHJlZ2lvbiBiZXR3ZWVuIGRvbTAgYW5kIGEgZG9tMGxl
c3MgZG9tVS4gTW9zdCBsaWtlbHkgdGhlIHVzZXIgd2lsbCBhbHNvIHdhbnQgdG8gcHJvdmlkZSBh
IG5vdGlmaWNhdGlvbiBjb21tdW5pY2F0aW9uLg0KPiANCj4gU28gc2hvdWxkbid0IHdlIGFsc28g
cHJvdmlkZSBhIHdheSB0byBjcmVhdGUgYW4gZXZlbnQgY2hhbm5lbCBiZXR3ZWVuIGRvbTAgYW5k
IGFub3RoZXIgZG9tVT8NCg0KWWVzLCB3ZSBjYW4gY3JlYXRlIHRoZSBldmVudCBjaGFubmVsIGJl
dHdlZW4gZG9tMCBhbmQgZG9tMGxlc3MgZG9tVS4gSSB3aWxsIGFkZCB0aGlzIGluIHRoZSBuZXh0
IGRlc2lnbiBkb2MuDQoNClNvcnJ5IGZvciBub3QgZXhwbGFpbmluZyBpdCBjb3JyZWN0bHkgZWFy
bGllciBJIG1lYW4gdG8gc2F5IHRoYXQgYWxsIGRvbWFpbnMgKCBpbmNsdWRpbmcgdGhlIGRvbTAg
KSBpbiB0aGUgZG9tMGxlc3Mgc3lzdGVtIGNhbg0KaGF2ZSB0aGUgc3RhdGljIGV2ZW50IGNoYW5u
ZWwuICANCg0KUmVnYXJkcywNClJhaHVsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 10:13:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 10:13:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304041.518558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZzl-000608-Gk; Wed, 13 Apr 2022 10:13:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304041.518558; Wed, 13 Apr 2022 10:13:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neZzl-000601-Dl; Wed, 13 Apr 2022 10:13:05 +0000
Received: by outflank-mailman (input) for mailman id 304041;
 Wed, 13 Apr 2022 10:13:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZzj-0005zq-GZ; Wed, 13 Apr 2022 10:13:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZzj-0007ZP-Av; Wed, 13 Apr 2022 10:13:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neZzi-0005kN-P6; Wed, 13 Apr 2022 10:13:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neZzi-0001Id-Oe; Wed, 13 Apr 2022 10:13:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wVhiYx0ruPRgW32hiXNg/iXWDbcpaBwgThubraScEpk=; b=BY6G8XCdZmalXHz7YGMVDuyokT
	YyidllN5Gz5Gs9iO7vVayynt5sWvQE9776T5z3L7KtzTYuFxIdMOXtO1eNiwh9G1nJHAl2xCAGBHN
	iO6Z51ekbpqnn++VxGZWlrJubiToCudbrOHaVW7z7UNATFZLl3AsVp3PE+Hg+lYCs3dQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169348-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169348: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5b752808ff37b7c819a26fd76329ef329c42774f
X-Osstest-Versions-That:
    xen=5b752808ff37b7c819a26fd76329ef329c42774f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 10:13:02 +0000

flight 169348 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169348/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169328
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169328
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169328
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169328
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169328
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 169328
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169328
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169328
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169328
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169328
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169328
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169328
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169328
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  5b752808ff37b7c819a26fd76329ef329c42774f
baseline version:
 xen                  5b752808ff37b7c819a26fd76329ef329c42774f

Last test of basis   169348  2022-04-13 01:51:50 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 10:50:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 10:50:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304056.518581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neaa4-0001tA-Jw; Wed, 13 Apr 2022 10:50:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304056.518581; Wed, 13 Apr 2022 10:50:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neaa4-0001t3-Gy; Wed, 13 Apr 2022 10:50:36 +0000
Received: by outflank-mailman (input) for mailman id 304056;
 Wed, 13 Apr 2022 10:50:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neaa3-0001st-Q9; Wed, 13 Apr 2022 10:50:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neaa3-0008Cf-Nw; Wed, 13 Apr 2022 10:50:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neaa3-0006bp-Br; Wed, 13 Apr 2022 10:50:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neaa3-0001Vi-BO; Wed, 13 Apr 2022 10:50:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ro96tAzxoFbxDG62Yxw6aW0cyWxMmT6dd6Z2P5CVn18=; b=Y27NiopvOPgv0WeLzWIu370xTg
	h5Nn7KhthnuIOFgkKHJ7mjhk7BTOL+KmfIhAa/l12xG8iawpyTIZoGrLPTQa9YkZqtBy56/J/9dFi
	rQUIl+6IWi66XCVQIjoZWvMkxaHKUfzPGDsK3tzxKvtKo4BGlO0yM/Awca3EjT7BakvQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169360-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169360: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 10:50:35 +0000

flight 169360 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169360/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  359 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 11:18:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 11:18:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304066.518591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neb0X-0004RU-ER; Wed, 13 Apr 2022 11:17:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304066.518591; Wed, 13 Apr 2022 11:17:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neb0X-0004RN-Bd; Wed, 13 Apr 2022 11:17:57 +0000
Received: by outflank-mailman (input) for mailman id 304066;
 Wed, 13 Apr 2022 11:17:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aOZT=UX=citrix.com=prvs=09565da51=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1neb0W-0004RH-3Q
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 11:17:56 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5b105d99-bb1b-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 13:17:54 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b105d99-bb1b-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649848673;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Rmd25FRYhiMXvH/h5Hs0Qs7C4JzTG1vgqGmz0TqdzfI=;
  b=GgttyBMKaOQVh6kKG3mT/X1EYecSvqvuUKbJc/9hu6Rd0sUlAhQfibYP
   l1ZdtBb0KKDiSnx8J4Au9Ye8ePgZtklsBec9UnBcyVaOg9ajZhnbXzIHG
   OBGq9nflx1xHZM5MImNAmVOhzh8rEb84WeMIjuqMHCoXDuC6ZtqexS2Q4
   8=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 69195662
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:J0+DxagOj3ZPdiAr/vmSPyOpX161bxAKZh0ujC45NGQN5FlHY01je
 htvDGDSafuOYzejKdola4y1oEpUscDTyd82Gldkqio3RS0b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1rW4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQsYJ/30pdQbbyFVIQZDbJJYoIOZBnfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklNpyzyfKP8iSJTKRaji7t5ExjYgwMtJGJ4yY
 uJHOGM+MUqeOXWjPH8+S70MtaSGuELteiwFr3O/uJom6VLMmVkZPL/Fb4OOJ43iqd9utlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiHK1p04kZupWL9U32iawm5XKuzrHIWdRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqVFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tmuVh6b/PuREDGQ3C94afe51qXHb4
 hA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSLyLdoIuW8ifxw0WirhRdMPS
 BWC0e+2zMUNVEZGkIctO97hYyjU5fWI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5LTlU4OAbGkP3G/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chYwJIbX7ZEfFTi3Vw==
IronPort-HdrOrdr: A9a23:Y26Fn6AZQs0OFU3lHegbsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPEfP+UsssHFJo6HkBEEZKUmsuaKdkrNhQYtKOzOW91dATbsSoLcKpgePJ8SQzJ8l6U
 4NSdkcNDS0NykBsS+Y2nj3Lz9D+qj+zEnAv463pB0NLT2CKZsQlDuRYjzrSnGeLzM2YabRYa
 DsgPav0ADQHkj/AP7LZEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZizU
 H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUgZ1TChkF3nAic0idurD
 D+mWZlAy210QKXQoiBm2qu5+An6kdp15at8y7AvZKpm72HeNtzMbs+uWseSGqD16NohqAM7I
 tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOO1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duf22vaIJyoEUbICbQxG+dA==
X-IronPort-AV: E=Sophos;i="5.90,256,1643691600"; 
   d="scan'208";a="69195662"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bceHiGZtz97y36lkV8NpvbEOzjERHM558eWJJGgFCeZ/WLmK7LswcLC3CxgsE/GETg3XzlJ1H3aBaDpUVhOd72sM2YuXcAMWGTZv5iFS+wjicVFxu1I7na+9QFRibJwNkZIkvYElJUBEjR5kImZIXM8/G3olWHZdVL6Vkxcu2DcBMbr6CrTsQg3JCU6MlO8IC8w/087EECikL7FFJTI/TLfls8HZfi1q2JEMpnmJrCZ7ELk33ENh4jhn/Fa5DX6PR/OPW4nE7vVqDNxYpEuu1PXnZ1XMEiqPbPnh0L6fLO5BsD6oHe6yCCTpYewfWUA+laC0sdLGsneSVPeCZKo2+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Rmd25FRYhiMXvH/h5Hs0Qs7C4JzTG1vgqGmz0TqdzfI=;
 b=LSXxCF+aaLC3WOezQU8IK9s+vbtViOP6KEOcvOTwuBafph2CgkfwnuzsPQgLlAeByR15G7i7RQ4EWNcLqU1zaDDgB3XGc9QYFaUDEfdvC47duT1RmY2iFKJgSnKU08uIosJ7TK0a1k66JAy13YQV/RNsRJ9rtbU7VPvFJC9AnhTGTMzmxg/auLIp2Lwl8f0H+1XVw+VmXe6QS0/4Z8cxpyMs7SAZrr+iD6X+M/LtR4l9KNHK6023rLziT48AhzMUTNtIT6q3EbujfrhzDjNqbhuDJUM3bros0n2/MWb5zZYwbXrGD+8jeqHE63KV/YmG6z6IbRB6jDlIGMj90x71oA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Rmd25FRYhiMXvH/h5Hs0Qs7C4JzTG1vgqGmz0TqdzfI=;
 b=RR0LERYVUfHpNEskvfezCuPruauD6AlgQ/Kb5oE/STwPn1RW2FHBOFv1zwDiWiz2DWG0P2ofbMyWnRgn4c+IQkdbNU66cmbbgj56tcELx01MjEEj+emBSPCyQZ2POaRjdV8ePykHPyPCQAv+Lkq4z/RwkC6Z171mLx5b7hwZdaI=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v9 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH v9 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYRbX2vSR7T5dCNEuUO7vV8Qproqzi7YYAgArXPwA=
Date: Wed, 13 Apr 2022 11:17:46 +0000
Message-ID: <619dc3d9-42d1-0c85-020e-50af3a2a8626@citrix.com>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-3-jane.malalane@citrix.com>
 <a389ee0d-6b2c-22bd-1004-99f79ad5f301@suse.com>
In-Reply-To: <a389ee0d-6b2c-22bd-1004-99f79ad5f301@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 236184d8-8779-4053-482c-08da1d3f3cec
x-ms-traffictypediagnostic: MW4PR03MB6965:EE_
x-microsoft-antispam-prvs: <MW4PR03MB69656484E41C81DCC0A8B49D81EC9@MW4PR03MB6965.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: VNqQ6SeMHccqNAk/tp0+FlOD0sUG9RLMR1e/1isW5GiIGiovkNGYk4h3/zXazPuB8R2yY4A8IQlrIC/q7pa8RktVNsLyZ7clyKbvoYXKrFVxhYhEJOtZJD+ntH+Wl7Pcz5+/IM1rAc6+DeCB/GauapRxVPXFLsdhAvIAKiMHF/PyRine80AIKY1fDWpwQpGyXWltULBtUKJAbbm5tQkrMfsiyFCfqpnseFHssUosghRNoWCnzzKJmTsFN6Ucglm29/WK9ySvsuoqmbiiEZN7L8I5NHSeJMoJ8vd2Fh13s38pew2x8TxQe90FTvv6lEuy1EO2mWMsUE/wmpc0WF6iaUkUMQEmUsHF9ZGBtK91kxOTrIPkvwkPkv17FElhnkFJ8iKaYSDG0uaTVOzWHz1BaETcAMzqrEZ4IJgBrPMV1gQn5W2zzMTgl4rDK2liZX3rplqMWwd1MBMDZ/AuTCAiJ39/oSdi4p2M5ZNd6Gh2XQhB/A7HbncHPv+VQXB3d2hy9fFKG9nXuysPqSJvbN3zKqGcSn4m+YfOG/AbSJ+GX5A10hMFLq9gPStUhcIePpueGZbspKbYt6Qk1oeuIiiMfE6yDfJaU0szdAbFFhLWhCdgxV5cpvMxLBhkJMZ55wktG6+6+IjicTs8DrBgsonHMkvL1Z7ZZcX04t4sOxKLuZbhUmBHOQBxtEuKdQDPYh1kSy6ohmv58QxrmhNL1Jpa0PtAWohYV3gTaN+xGK7gzeo=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(66946007)(91956017)(2616005)(316002)(26005)(186003)(6916009)(122000001)(76116006)(82960400001)(8936002)(86362001)(38100700002)(83380400001)(31686004)(38070700005)(36756003)(508600001)(71200400001)(8676002)(6512007)(6506007)(66556008)(64756008)(66446008)(66476007)(5660300002)(53546011)(6486002)(4326008)(2906002)(55236004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TnY2b1B2cUlQM0NRcHlKSlU3a0Q4aWtBa3JUeUtlNE54bnRudEEzRy9Oblho?=
 =?utf-8?B?WHU1cC9jZjlOUHI1OTZQM0VPdWR4Q2pZTnFqbFNuT0Z3b0J3NzcxSlJFRGFl?=
 =?utf-8?B?Y21kU3FldUJqazcyUE0xSExRMnhKVm5EMVQzYm5QTktYQjdhZlViMzROVTB5?=
 =?utf-8?B?bGhwMWNzUnNRdnBGckwyaHNUNDVEekhUTGg1Rmg2ZkVNVXNaUThwaGV2WmZj?=
 =?utf-8?B?SE9KNzFuRE5HT1hsSHk4b01vaHFkWEtOdWMvYncyM1V0cU1SYm04R0VVVk9R?=
 =?utf-8?B?VExqajBuOHZPbkJYNlAwWjZKcVIrcEFSRCtWNXZMU1QvZW1NQktoaWc2NVFX?=
 =?utf-8?B?cHovNHVpb2NudWVMdTM4WC8vMnhPNmZabktXU2MyZWpHM29mdzV5aC9sVlpm?=
 =?utf-8?B?NUNsaENqdkdCb0dRWm4xamNQSjl6dHErM2J1MFZJcC85N09FaXI2U0pZclg5?=
 =?utf-8?B?QmJmdGR4cDNRbkxxVVVqejFlQ0dwVUovVHFkcENKTUdWdFd2aWNZcUo5TkxL?=
 =?utf-8?B?dkkwY0YzcmNBTzU0ZjIrUlhHcDEwcjVKZjBPNVQrNGFYMyswMkZXdUVUTGxI?=
 =?utf-8?B?UDEwTkhuUDA4SDdQVU1TaW9OeWR1bWZxUmxLeW9zUEpYVEY3TWFJVFI1R2xh?=
 =?utf-8?B?Sk5qYWRCZnBVanMxdW5waS9Yb0pHQ2pkT2lYS05xMHZmU2tNT0hWc3FRZWlv?=
 =?utf-8?B?Qml0aEs2R2VhQStuaFh1UnlrWUVnSktadnlPTkRLMUR5MkU3RHpNUTlKMXpU?=
 =?utf-8?B?UXBOUWQvb2R5ckw5M1dWOGxFNFYyWm56OTJCMnJOc0ZXVHJodFBleXRQZ0s5?=
 =?utf-8?B?UzB0Y0twRkNUd00xWW1yV2lQZ242ZVQwNXBqaXAvcjNHN3hWV1RGanRHTENl?=
 =?utf-8?B?VWNCanIxeUlQcUxKcVA5VGJmbmF0VGVvdW93RGFiaDJCVW5uNTNaZmZMcUY1?=
 =?utf-8?B?U2JkMFdyREtyaVVCV2hWMTlPS2lyeU1POWZVMzdrNlo5aWc5SW9JRWF3YjEy?=
 =?utf-8?B?OG9uSGNKeSt4alEycUl2dzJVbjBsNGRtRUw4c0lyQTZqK05INVVSa2hCK0JO?=
 =?utf-8?B?OFNHV1U3anlDQlk1Q3hYMGtORmRvcElXVGM3WTBZdElxOGIxR29jVFptZnZJ?=
 =?utf-8?B?UjU5djRPei8rVHcyS3JSSnVUaytybC9HMWdtWlZvdkpaTDRtMVk5RWF3L00z?=
 =?utf-8?B?eUNvNCtYUHVlQWVpNUZoRW8rSGlLS0Vib2I1VGNwNlF2a09OYWtSNVR3QU1j?=
 =?utf-8?B?R2hsQ0lRSTloak1vT0xUc3lUOXdHQ0xEenFSRkpSdmRyNTdDVVJ4N1ZseC9Q?=
 =?utf-8?B?VnJINlphSlpkZThhWGh1MWZRS1lvaUtyVndndUxackxNR1dOODZaZ1A3T3hE?=
 =?utf-8?B?UG55anZkRGFmWHI3RTZoUURqTjBMemFLeEw4aXFTTW9STEFGTFpMSlRBb1B0?=
 =?utf-8?B?ZjVzY3BxWmpJT3llWkJWVFF4cW9xSGo1b3hMTXl2VHFGNmxyM1plOEljRFpk?=
 =?utf-8?B?YVRGdWNRVWQ1NlR2d1hhS2ZzWTJpWjZEMklXM1dOMzFkU0VPVndVclRjTWFM?=
 =?utf-8?B?S3BTTzYwME50d0R4dzFvZHBBeFhKZ2tJVFVuSFErUXVEak83ajdlOEk0Zkxz?=
 =?utf-8?B?R2Q0bEpFVTMxOXhic0hTZkN6dFFSaHFmRG5qSTRjUmE5WStkSlcwSHI5eWFV?=
 =?utf-8?B?YVRaV3lwekJIZExjUURiOTZXb2lrU1dPdUZxUUM0bmpSR3RzYmNaRlpQajV3?=
 =?utf-8?B?bjgrV0NVTnhyU0dEUXhxbWZYMCtBb2RqSS9uWU8rSWpkcnA0Q2I1NUVyQ0d5?=
 =?utf-8?B?NmIxOEtUZlI4VUc0bE92RXA3MmRxa0lMTE9qYVVTeFcwQmJrQnZHYlFBd1RM?=
 =?utf-8?B?bFp3bjJXSFphQlo2WHBJbkJoV081M0NmRS85SzRTK1k3eXkwRXhoQ3BWSnBF?=
 =?utf-8?B?N2xiT3lROW0xY05xVCtmSnFtbjB5a0gwZGdiWENrenZXV05FWnhkRVV3ZXAr?=
 =?utf-8?B?eE56NjRNK1ZRMDMyYk9iTWNUdm9RUmd6cjlIZnFzRThTbWdyNkdMKzRmQzBH?=
 =?utf-8?B?bGlxc0hMbWdoYUdpV0FhaU9wVXNXTDRBMWpKV1VSMTJxM3lwOVBXd1lYVHVn?=
 =?utf-8?B?emZ4VGRQUkNQR1lZVm5zVDgrNVZUVzVKVGlScTh4QmE1Wm5acXlSa2Voc3hQ?=
 =?utf-8?B?NmNYdi9YcnY2ZW9sSnBlOEliR3FKVjcwYnk4dkZCY3ZZSEdTQy9NTDJybXd2?=
 =?utf-8?B?TGNRc1RyVk1LSU0rSEl4bkF2dFRWRk9IVTEvYnJEUE1RNVB6c1FJd0JzakJH?=
 =?utf-8?B?MUdTdmxYK043T3JQVmo4TWc2TEpzUUlEcGJIdWxIcFZpNUgwTTV3bFFHbHkz?=
 =?utf-8?Q?OUfOdXJP2Q3A7aDk=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7A018F914E79424B8FD3D359B23155CB@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 236184d8-8779-4053-482c-08da1d3f3cec
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 11:17:46.7828
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CBun9aqT601tIQ1V1pgMa5lSh/ZI5NhIr54dJe1ny96ST74PHjqUbDVs5ojOiFhZQt4PzLib40XI0hLs/KgV7nhTafX0/ssFdfWoAqrhXsA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6965
X-OriginatorOrg: citrix.com

T24gMDYvMDQvMjAyMiAxNDo0NCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDAxLjA0LjIwMjIgMTI6NDcsIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBJbnRyb2R1Y2UgYSBuZXcgcGVyLWRvbWFpbiBjcmVhdGlvbiB4ODYgc3BlY2lmaWMg
ZmxhZyB0bw0KPj4gc2VsZWN0IHdoZXRoZXIgaGFyZHdhcmUgYXNzaXN0ZWQgdmlydHVhbGl6YXRp
b24gc2hvdWxkIGJlIHVzZWQgZm9yDQo+PiB4ezJ9QVBJQy4NCj4+DQo+PiBBIHBlci1kb21haW4g
b3B0aW9uIGlzIGFkZGVkIHRvIHhsIGluIG9yZGVyIHRvIHNlbGVjdCB0aGUgdXNhZ2Ugb2YNCj4+
IHh7Mn1BUElDIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uLCBhcyB3ZWxsIGFzIGEg
Z2xvYmFsDQo+PiBjb25maWd1cmF0aW9uIG9wdGlvbi4NCj4+DQo+PiBIYXZpbmcgYWxsIEFQSUMg
aW50ZXJhY3Rpb24gZXhpdCB0byBYZW4gZm9yIGVtdWxhdGlvbiBpcyBzbG93IGFuZCBjYW4NCj4+
IGluZHVjZSBtdWNoIG92ZXJoZWFkLiBIYXJkd2FyZSBjYW4gc3BlZWQgdXAgeHsyfUFQSUMgYnkg
ZGVjb2RpbmcgdGhlDQo+PiBBUElDIGFjY2VzcyBhbmQgcHJvdmlkaW5nIGEgVk0gZXhpdCB3aXRo
IGEgbW9yZSBzcGVjaWZpYyBleGl0IHJlYXNvbg0KPj4gdGhhbiBhIHJlZ3VsYXIgRVBUIGZhdWx0
IG9yIGJ5IGFsdG9nZXRoZXIgYXZvaWRpbmcgYSBWTSBleGl0Lg0KPj4NCj4+IE9uIHRoZSBvdGhl
ciBoYW5kLCBiZWluZyBhYmxlIHRvIGRpc2FibGUgeHsyfUFQSUMgaGFyZHdhcmUgYXNzaXN0ZWQN
Cj4+IHZpcnR1YWxpemF0aW9uIGNhbiBiZSB1c2VmdWwgZm9yIHRlc3RpbmcgYW5kIGRlYnVnZ2lu
ZyBwdXJwb3Nlcy4NCj4+DQo+PiBOb3RlOg0KPj4NCj4+IC0gdm14X2luc3RhbGxfdmxhcGljX21h
cHBpbmcgZG9lc24ndCByZXF1aXJlIG1vZGlmaWNhdGlvbnMgcmVnYXJkbGVzcw0KPj4gb2Ygd2hl
dGhlciB0aGUgZ3Vlc3QgaGFzICJWaXJ0dWFsaXplIEFQSUMgYWNjZXNzZXMiIGVuYWJsZWQgb3Ig
bm90LA0KPj4gaS5lLiwgc2V0dGluZyB0aGUgQVBJQ19BQ0NFU1NfQUREUiBWTUNTIGZpZWxkIGlz
IGZpbmUgc28gbG9uZyBhcw0KPj4gdmlydHVhbGl6ZV9hcGljX2FjY2Vzc2VzIGlzIHN1cHBvcnRl
ZCBieSB0aGUgQ1BVLg0KPj4NCj4+IC0gQm90aCBwZXItZG9tYWluIGFuZCBnbG9iYWwgYXNzaXN0
ZWRfeHsyfWFwaWMgb3B0aW9ucyBhcmUgbm90IHBhcnQgb2YNCj4+IHRoZSBtaWdyYXRpb24gc3Ry
ZWFtLCB1bmxlc3MgZXhwbGljaXRseSBzZXQgaW4gdGhlIGNvbmZpZ3VyYXRpb24gZmlsZSwNCj4+
IHNvIGl0IGlzIHNhZmUgdG8gbWlncmF0ZSBhIGd1ZXN0IHRoYXQgZG9lc24ndCBoYXZlIGFzc2lz
dGVkX3h7Mn1hcGljDQo+PiBzZXQgaW4gaXRzIGNvbmZpZyBmaWxlIGJldHdlZW4gaG9zdHMgdGhh
dCBoYXZlIGRpZmZlcmVudCBzdXBwb3J0IGZvcg0KPj4gaGFyZHdhcmUgYXNzaXN0ZWQgeHsyfUFQ
SUMgdmlydHVhbGl6YXRpb24uDQo+IA0KPiBXaGlsZSBJIGNhbiBhZ3JlZSB0aGlzIGlzIHRoZSBj
YXNlIGFzIGZhciBhcyB5b3VyIGNoYW5nZXMgYXJlIGNvbmNlcm5lZCwNCj4gaXQgcmVhZHMgYXMg
aWYgdGhpcyB3YXMgYSBicm9hZGVyIHN0YXRlbWVudC4gU2luY2UgaHlwZXJ2aXNvciBDUFVJRCBs
ZWFmDQo+IGNvbnRlbnRzIGNhbiBjaGFuZ2UgYWNyb3NzIHN1Y2ggYSBtaWdyYXRpb24gKHdoaWNo
IGlzIHByZS1leGlzdGluZw0KPiBiZWhhdmlvciksIEknbSBub3QgY29udmluY2VkIHRoZSBzdGF0
ZW1lbnQgaXMgZ2VuZXJhbGx5IGFwcGxpY2FibGUuDQpJIHNlZSwgSSB3aWxsIG1ha2UgdGhpcyBj
bGVhcmVyIHRvIG9ubHkgcmVmZXJlbmNlIHRoZSB0b29sc3RhY2sgc2V0dGluZy4NCg0KVGhhbmtz
LA0KDQpKYW5lLg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 11:22:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 11:22:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304072.518603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neb4U-0005qs-Uq; Wed, 13 Apr 2022 11:22:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304072.518603; Wed, 13 Apr 2022 11:22:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neb4U-0005ql-Re; Wed, 13 Apr 2022 11:22:02 +0000
Received: by outflank-mailman (input) for mailman id 304072;
 Wed, 13 Apr 2022 11:22:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aOZT=UX=citrix.com=prvs=09565da51=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1neb4T-0005qf-OU
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 11:22:01 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee85e154-bb1b-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 13:22:00 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee85e154-bb1b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649848919;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=aenH0fD8UqySU1/PrIlq9KObEtNkts4LZGVHnoFy7D0=;
  b=XmqLQQRCDC4gCiDhx2uKGFG8VDDg9XFQmHNas05wpYlGzTWIMDkb80K+
   JJPALSe4/whWkmarrkmb8J7nWppzyLNZ/6n/T4vrsd46ivVTPOshKFpLI
   MHWgXoHkES4fseG3u2DRzpTQvTQ9JObvpKAweR4wMEZDzMQOqOJxs8R59
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68194872
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SXScTKN/qDaByU3vrR3Al8FynXyQoLVcMsEvi/4bfWQNrUpz32QBy
 zZMW2vXaKzcazSmKIgiadvj/U0H68XTy99kHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl29Uw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9
 JJHjYDrcjcSZpbUsfosChhYCBxkBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALDsDtMcU6s3VpyTjfAN4tQIzZQrWM7thdtNs1rp4eRKeCN
 5VDAdZpRAbkZUx9A1ERNLAvmPyzplTUcnp6j13A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9GFzUSGR4lkG
 3dMwTIHs5lr9Uywc8PECkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1rO/8kN+kBcQCwYbujwcgRBBN3dTsqZpbYvnnHoc6S/7dYjEY9FjNL
 9G2QMoW2u17YS0jjfzTEbX7b9SE/MmhoukdvFu/Y45dxlklDLNJnqTxgbQh0d5OLZyCUn6Kt
 2Uels6V4YgmVM/RxXzXGLxTQOryup5p1QEwZ3Y1TvHNEBz3pRaekX14umkidC+FzO5ZEdMWX
 KMjkVwIv8ICVJdbRaR2f5iwG6wXIVvITrzYugTvRoMWOPBZLVbflAk3PBL49z29wSAEzPBkU
 b/GIJnEMJrvIfk+pNZAb7xGiuFDK+FX7T67eK0XODz+iOTFNS/JE+pdWLZMB8hghJ65TMzu2
 443H6O3J993C4USvgG/HVYvEG03
IronPort-HdrOrdr: A9a23:WyvAwKAjlzFvhSHlHemg55DYdb4zR+YMi2TC1yhKJyC9Ffbo8P
 xG/c5rsSMc5wxwZJhNo7y90cq7MBbhHPxOkOos1N6ZNWGM0gaVxelZnO3fKlbbehEWmNQz6U
 4ZSdkdNOHN
X-IronPort-AV: E=Sophos;i="5.90,256,1643691600"; 
   d="scan'208";a="68194872"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>
Subject: [PATCH v10 0/2] xen: Report and use hardware APIC virtualization capabilities
Date: Wed, 13 Apr 2022 12:21:09 +0100
Message-ID: <20220413112111.30675-1-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Jane Malalane (2):
  xen+tools: Report Interrupt Controller Virtualization capabilities on
    x86
  x86/xen: Allow per-domain usage of hardware virtualized APIC

 docs/man/xl.cfg.5.pod.in              | 15 ++++++++++++++
 docs/man/xl.conf.5.pod.in             | 12 +++++++++++
 tools/golang/xenlight/helpers.gen.go  | 16 ++++++++++++++
 tools/golang/xenlight/types.gen.go    |  4 ++++
 tools/include/libxl.h                 | 14 +++++++++++++
 tools/libs/light/libxl.c              |  3 +++
 tools/libs/light/libxl_arch.h         |  9 ++++++--
 tools/libs/light/libxl_arm.c          | 14 ++++++++++---
 tools/libs/light/libxl_create.c       | 22 ++++++++++++--------
 tools/libs/light/libxl_types.idl      |  4 ++++
 tools/libs/light/libxl_x86.c          | 39 +++++++++++++++++++++++++++++++++--
 tools/ocaml/libs/xc/xenctrl.ml        |  7 +++++++
 tools/ocaml/libs/xc/xenctrl.mli       |  7 +++++++
 tools/ocaml/libs/xc/xenctrl_stubs.c   | 17 ++++++++++++---
 tools/xl/xl.c                         |  8 +++++++
 tools/xl/xl.h                         |  2 ++
 tools/xl/xl_info.c                    |  6 ++++--
 tools/xl/xl_parse.c                   | 19 +++++++++++++++++
 xen/arch/x86/domain.c                 | 29 +++++++++++++++++++++++++-
 xen/arch/x86/hvm/hvm.c                |  3 +++
 xen/arch/x86/hvm/vmx/vmcs.c           | 11 ++++++++++
 xen/arch/x86/hvm/vmx/vmx.c            | 13 ++++--------
 xen/arch/x86/include/asm/hvm/domain.h |  6 ++++++
 xen/arch/x86/include/asm/hvm/hvm.h    | 10 +++++++++
 xen/arch/x86/sysctl.c                 |  4 ++++
 xen/arch/x86/traps.c                  |  5 +++--
 xen/include/public/arch-x86/xen.h     |  5 +++++
 xen/include/public/sysctl.h           | 11 +++++++++-
 28 files changed, 281 insertions(+), 34 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 11:22:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 11:22:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304073.518613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neb4X-000672-6P; Wed, 13 Apr 2022 11:22:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304073.518613; Wed, 13 Apr 2022 11:22:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neb4X-00066v-3R; Wed, 13 Apr 2022 11:22:05 +0000
Received: by outflank-mailman (input) for mailman id 304073;
 Wed, 13 Apr 2022 11:22:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aOZT=UX=citrix.com=prvs=09565da51=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1neb4V-0005qf-88
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 11:22:03 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f0627f75-bb1b-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 13:22:01 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0627f75-bb1b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649848921;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=8UpXh7NbCwiHWyB+MxSv+0mCYIC9Jns1SqfrgRUjYSY=;
  b=Gs6f9jdXgnWvOWU29nJYyLmqCg7H6jnhpOu3nSnwJTApByb9baHTF3eD
   ZRGFTWnyiDAIbvN5sGHCM3ln35uYFqpXRblodaJiO19Iqle9NXXNNko/I
   tEH2YKZa2UyhfxCQ9FAO1nZFTgBkcMMQcC56jLeF06d70bY9yPvhm3L08
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68194871
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IF+h/6kZK77GhDYOpGlfjVno5gwYJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZCGCEOayCamPxKdBxYI6/9BgA756HzdRjSQM/rXhnEiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWljV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYdUAjBrGXo9QmCyJAOj9PZKxG44LdGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3mHhmwHf8BPIvRZnFTo3B5MNC3Sd2jcdLdRrbT
 5RJMGszPEuZC/FJEnExEs0Cofe1vFXyfRhahQ2rjrIJ72eGmWSd15CyaYGIK7RmX/59oEGco
 W7X+nXjNTsTPtef1Dmt/2qlg6nEmiaTcJkJCLSy+/pugVuS7m8eEhsbUR28u/bRokSzQc5FI
 koYvC8nt7Ev9VeDR8P4GRa/pRasvRMCWtwWD+wz7imMzLbZ50CSAW1sZjxcbpogvcw/Rz0v3
 3eImc/kAXpkt7j9YXCS7LCPthupJDMYa2QFYEcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y
 CzMqzIx750Rh8MW06Sw/Xjcnimh4JPOS2Yd5BjTX2+jxhN0YsiifYPAwUffxeZNKsCeVFbpg
 ZQfs5HAtqZUV8jLzXHTBrVWdF202xqbGAGbi2ZzRKIRzGyW41e9TNlR4CpDPn48Z67oZgTVS
 EPUvApQ4rpaM32rcbJ7buqNNig68UTzPY+7D66JN7KidrA0LVbap382OSZ8yki3yCARfbcD1
 YB3mCpGJVITEuxZwTW/XI/xOpd7l3lllQs/qX0WpilLMIZyhlbIEd/p03PUN4jVCZ9oRi2Po
 r6z0OPQlX1ivBXWOHW/zGLqBQliwYIHLZ73sddLUeWIPxBrHmosY9eIn+9wK9Y9xvoJzbyVl
 p1YZqO+4ACu7ZEgAV/UAk2PlZu1BcovxZ7FFXFE0amUN4gLPt/0sfZ3m2ofdrg77u1zpcOYv
 NFeE/hs9s9nE2ydkxxENMGVhNU7KHyD2FLfVwL4MWNXV8MxGGT0FirMI1KHGN8mVXHs66PTY
 tSIi2vmfHb0b107Up2HOa71kgvZULp0sLsaYnYk6+J7IC3EmLWG4QSq5hPrC6ng8Sn++wY=
IronPort-HdrOrdr: A9a23:SP3Igq9nZNrGQydecp1uk+DiI+orL9Y04lQ7vn2YSXRuE/Bw8P
 re5MjztCWE8Qr5N0tQ+uxoVJPufZqYz+8Q3WBzB8bFYOCFghrLEGgK1+KLqFeMdxEWtNQtsp
 uIG5IOc+EYZmIbsS+V2meF+q4bsby6zJw=
X-IronPort-AV: E=Sophos;i="5.90,256,1643691600"; 
   d="scan'208";a="68194871"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>
Subject: [PATCH v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
Date: Wed, 13 Apr 2022 12:21:10 +0100
Message-ID: <20220413112111.30675-2-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220413112111.30675-1-jane.malalane@citrix.com>
References: <20220413112111.30675-1-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and
XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and
x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization
can subsequently be enabled on a per-domain basis.
No such features are currently implemented on AMD hardware.

HW assisted xAPIC virtualization will be reported if HW, at the
minimum, supports virtualize_apic_accesses as this feature alone means
that an access to the APIC page will cause an APIC-access VM exit. An
APIC-access VM exit provides a VMM with information about the access
causing the VM exit, unlike a regular EPT fault, thus simplifying some
internal handling.

HW assisted x2APIC virtualization will be reported if HW supports
virtualize_x2apic_mode and, at least, either apic_reg_virt or
virtual_intr_delivery. This also means that
sysctl follows the conditionals in vmx_vlapic_msr_changed().

For that purpose, also add an arch-specific "capabilities" parameter
to struct xen_sysctl_physinfo.

Note that this interface is intended to be compatible with AMD so that
AVIC support can be introduced in a future patch. Unlike Intel that
has multiple controls for APIC Virtualization, AMD has one global
'AVIC Enable' control bit, so fine-graining of APIC virtualization
control cannot be done on a common interface.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
Reviewed-by: "Roger Pau Monné" <roger.pau@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>

v10:
 * Make assisted_x{2}apic_available conditional upon _vmx_cpu_up()

v9:
 * Move assisted_x{2}apic_available to vmx_vmcs_init() so they get
   declared at boot time, after vmx_secondary_exec_control is set

v8:
 * Improve commit message

v7:
 * Make sure assisted_x{2}apic_available evaluates to false, to ensure
   Xen builds, when !CONFIG_HVM
 * Fix coding style issues

v6:
 * Limit abi check to x86
 * Fix coding style issue

v5:
 * Have assisted_xapic_available solely depend on
   cpu_has_vmx_virtualize_apic_accesses and assisted_x2apic_available
   depend on cpu_has_vmx_virtualize_x2apic_mode and
   cpu_has_vmx_apic_reg_virt OR cpu_has_vmx_virtual_intr_delivery

v4:
 * Fallback to the original v2/v1 conditions for setting
   assisted_xapic_available and assisted_x2apic_available so that in
   the future APIC virtualization can be exposed on AMD hardware
   since fine-graining of "AVIC" is not supported, i.e., AMD solely
   uses "AVIC Enable". This also means that sysctl mimics what's
   exposed in CPUID

v3:
 * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
   set "arch_capbilities", via a call to c_bitmap_to_ocaml_list()
 * Have assisted_x2apic_available only depend on
   cpu_has_vmx_virtualize_x2apic_mode

v2:
 * Use one macro LIBXL_HAVE_PHYSINFO_ASSISTED_APIC instead of two
 * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
 * Set assisted_x{2}apic_available to be conditional upon "bsp" and
   annotate it with __ro_after_init
 * Change XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_X{2}APIC to
   _X86_ASSISTED_X{2}APIC
 * Keep XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X{2}APIC contained within
   sysctl.h
 * Fix padding introduced in struct xen_sysctl_physinfo and bump
   XEN_SYSCTL_INTERFACE_VERSION
---
 tools/golang/xenlight/helpers.gen.go |  4 ++++
 tools/golang/xenlight/types.gen.go   |  2 ++
 tools/include/libxl.h                |  7 +++++++
 tools/libs/light/libxl.c             |  3 +++
 tools/libs/light/libxl_arch.h        |  4 ++++
 tools/libs/light/libxl_arm.c         |  5 +++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/libs/light/libxl_x86.c         | 11 +++++++++++
 tools/ocaml/libs/xc/xenctrl.ml       |  5 +++++
 tools/ocaml/libs/xc/xenctrl.mli      |  5 +++++
 tools/ocaml/libs/xc/xenctrl_stubs.c  | 15 +++++++++++++--
 tools/xl/xl_info.c                   |  6 ++++--
 xen/arch/x86/hvm/hvm.c               |  3 +++
 xen/arch/x86/hvm/vmx/vmcs.c          |  7 +++++++
 xen/arch/x86/include/asm/hvm/hvm.h   |  5 +++++
 xen/arch/x86/sysctl.c                |  4 ++++
 xen/include/public/sysctl.h          | 11 ++++++++++-
 17 files changed, 94 insertions(+), 5 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index b746ff1081..dd4e6c9f14 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3373,6 +3373,8 @@ x.CapVmtrace = bool(xc.cap_vmtrace)
 x.CapVpmu = bool(xc.cap_vpmu)
 x.CapGnttabV1 = bool(xc.cap_gnttab_v1)
 x.CapGnttabV2 = bool(xc.cap_gnttab_v2)
+x.CapAssistedXapic = bool(xc.cap_assisted_xapic)
+x.CapAssistedX2Apic = bool(xc.cap_assisted_x2apic)
 
  return nil}
 
@@ -3407,6 +3409,8 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace)
 xc.cap_vpmu = C.bool(x.CapVpmu)
 xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1)
 xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2)
+xc.cap_assisted_xapic = C.bool(x.CapAssistedXapic)
+xc.cap_assisted_x2apic = C.bool(x.CapAssistedX2Apic)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index b1e84d5258..87be46c745 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -1014,6 +1014,8 @@ CapVmtrace bool
 CapVpmu bool
 CapGnttabV1 bool
 CapGnttabV2 bool
+CapAssistedXapic bool
+CapAssistedX2Apic bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 51a9b6cfac..94e6355822 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -528,6 +528,13 @@
 #define LIBXL_HAVE_MAX_GRANT_VERSION 1
 
 /*
+ * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has
+ * cap_assisted_xapic and cap_assisted_x2apic fields, which indicates
+ * the availability of x{2}APIC hardware assisted virtualization.
+ */
+#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index a0bf7d186f..6d699951e2 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -15,6 +15,7 @@
 #include "libxl_osdeps.h"
 
 #include "libxl_internal.h"
+#include "libxl_arch.h"
 
 int libxl_ctx_alloc(libxl_ctx **pctx, int version,
                     unsigned flags, xentoollog_logger * lg)
@@ -410,6 +411,8 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
     physinfo->cap_gnttab_v2 =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2);
 
+    libxl__arch_get_physinfo(physinfo, &xcphysinfo);
+
     GC_FREE;
     return 0;
 }
diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 1522ecb97f..207ceac6a1 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -86,6 +86,10 @@ int libxl__arch_extra_memory(libxl__gc *gc,
                              uint64_t *out);
 
 _hidden
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo);
+
+_hidden
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src);
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index eef1de0939..39fdca1b49 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1431,6 +1431,11 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
     return rc;
 }
 
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo)
+{
+}
+
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src)
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 2a42da2f7d..42ac6c357b 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1068,6 +1068,8 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_vpmu", bool),
     ("cap_gnttab_v1", bool),
     ("cap_gnttab_v2", bool),
+    ("cap_assisted_xapic", bool),
+    ("cap_assisted_x2apic", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index 1feadebb18..e0a06ecfe3 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
     return rc;
 }
 
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo)
+{
+    physinfo->cap_assisted_xapic =
+        !!(xcphysinfo->arch_capabilities &
+           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC);
+    physinfo->cap_assisted_x2apic =
+        !!(xcphysinfo->arch_capabilities &
+           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC);
+}
+
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src)
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7503031d8f..712456e098 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -127,6 +127,10 @@ type physinfo_cap_flag =
 	| CAP_Gnttab_v1
 	| CAP_Gnttab_v2
 
+type physinfo_arch_cap_flag =
+	| CAP_X86_ASSISTED_XAPIC
+	| CAP_X86_ASSISTED_X2APIC
+
 type physinfo =
 {
 	threads_per_core : int;
@@ -140,6 +144,7 @@ type physinfo =
 	(* XXX hw_cap *)
 	capabilities     : physinfo_cap_flag list;
 	max_nr_cpus      : int;
+	arch_capabilities : physinfo_arch_cap_flag list;
 }
 
 type version =
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index d1d9c9247a..b034434f68 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -112,6 +112,10 @@ type physinfo_cap_flag =
   | CAP_Gnttab_v1
   | CAP_Gnttab_v2
 
+type physinfo_arch_cap_flag =
+  | CAP_X86_ASSISTED_XAPIC
+  | CAP_X86_ASSISTED_X2APIC
+
 type physinfo = {
   threads_per_core : int;
   cores_per_socket : int;
@@ -123,6 +127,7 @@ type physinfo = {
   scrub_pages      : nativeint;
   capabilities     : physinfo_cap_flag list;
   max_nr_cpus      : int; (** compile-time max possible number of nr_cpus *)
+  arch_capabilities : physinfo_arch_cap_flag list;
 }
 type version = { major : int; minor : int; extra : string; }
 type compile_info = {
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 5b4fe72c8d..7e9c32ad1b 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -712,7 +712,7 @@ CAMLprim value stub_xc_send_debug_keys(value xch, value keys)
 CAMLprim value stub_xc_physinfo(value xch)
 {
 	CAMLparam1(xch);
-	CAMLlocal2(physinfo, cap_list);
+	CAMLlocal3(physinfo, cap_list, arch_cap_list);
 	xc_physinfo_t c_physinfo;
 	int r;
 
@@ -731,7 +731,7 @@ CAMLprim value stub_xc_physinfo(value xch)
 		/* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_MAX max */
 		(c_physinfo.capabilities);
 
-	physinfo = caml_alloc_tuple(10);
+	physinfo = caml_alloc_tuple(11);
 	Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core));
 	Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket));
 	Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus));
@@ -743,6 +743,17 @@ CAMLprim value stub_xc_physinfo(value xch)
 	Store_field(physinfo, 8, cap_list);
 	Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1));
 
+#if defined(__i386__) || defined(__x86_64__)
+	/*
+	 * arch_capabilities: physinfo_arch_cap_flag list;
+	 */
+	arch_cap_list = c_bitmap_to_ocaml_list
+		/* ! physinfo_arch_cap_flag CAP_ none */
+		/* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_X86_MAX max */
+		(c_physinfo.arch_capabilities);
+	Store_field(physinfo, 10, arch_cap_list);
+#endif
+
 	CAMLreturn(physinfo);
 }
 
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 712b7638b0..3205270754 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -221,7 +221,9 @@ static void output_physinfo(void)
          info.cap_vmtrace ? " vmtrace" : "",
          info.cap_vpmu ? " vpmu" : "",
          info.cap_gnttab_v1 ? " gnttab-v1" : "",
-         info.cap_gnttab_v2 ? " gnttab-v2" : ""
+         info.cap_gnttab_v2 ? " gnttab-v2" : "",
+         info.cap_assisted_xapic ? " assisted_xapic" : "",
+         info.cap_assisted_x2apic ? " assisted_x2apic" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 5b16fb4cd8..0a32a948db 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -117,6 +117,9 @@ static const char __initconst warning_hvm_fep[] =
 static bool_t __initdata opt_altp2m_enabled = 0;
 boolean_param("altp2m", opt_altp2m_enabled);
 
+bool __ro_after_init assisted_xapic_available;
+bool __ro_after_init assisted_x2apic_available;
+
 static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 56fed2db03..7329622dd4 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -2146,7 +2146,14 @@ int __init vmx_vmcs_init(void)
     ret = _vmx_cpu_up(true);
 
     if ( !ret )
+    {
+        /* Check whether hardware supports accelerated xapic and x2apic. */
+        assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
+        assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode &&
+                                    (cpu_has_vmx_apic_reg_virt ||
+                                     cpu_has_vmx_virtual_intr_delivery);
         register_keyhandler('v', vmcs_dump, "dump VT-x VMCSs", 1);
+    }
 
     return ret;
 }
diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h
index 5b7ec0cf69..e0d9348878 100644
--- a/xen/arch/x86/include/asm/hvm/hvm.h
+++ b/xen/arch/x86/include/asm/hvm/hvm.h
@@ -373,6 +373,9 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value);
 #define hvm_tsc_scaling_ratio(d) \
     ((d)->arch.hvm.tsc_scaling_ratio)
 
+extern bool assisted_xapic_available;
+extern bool assisted_x2apic_available;
+
 #define hvm_get_guest_time(v) hvm_get_guest_time_fixed(v, 0)
 
 #define hvm_paging_enabled(v) \
@@ -872,6 +875,8 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
 #define hvm_tsc_scaling_supported false
 #define hap_has_1gb false
 #define hap_has_2mb false
+#define assisted_xapic_available false
+#define assisted_x2apic_available false
 
 #define hvm_paging_enabled(v) ((void)(v), false)
 #define hvm_wp_enabled(v) ((void)(v), false)
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index f82abc2488..716525f72f 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -135,6 +135,10 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap;
     if ( IS_ENABLED(CONFIG_SHADOW_PAGING) )
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow;
+    if ( assisted_xapic_available )
+        pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC;
+    if ( assisted_x2apic_available )
+        pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC;
 }
 
 long arch_do_sysctl(
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index b0a4af8789..7f521b3beb 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -35,7 +35,7 @@
 #include "domctl.h"
 #include "physdev.h"
 
-#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014
+#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * Read console content from Xen buffer ring.
@@ -111,6 +111,13 @@ struct xen_sysctl_tbuf_op {
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
 #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2
 
+/* The platform supports x{2}apic hardware assisted emulation. */
+#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC  (1u << 0)
+#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC (1u << 1)
+
+/* Max XEN_SYSCTL_PHYSCAP_X86__* constant. Used for ABI checking. */
+#define XEN_SYSCTL_PHYSCAP_X86_MAX XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC
+
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
     uint32_t cores_per_socket;
@@ -120,6 +127,8 @@ struct xen_sysctl_physinfo {
     uint32_t max_node_id; /* Largest possible node ID on this host */
     uint32_t cpu_khz;
     uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */
+    uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_{X86,ARM,...}_??? */
+    uint32_t pad;
     uint64_aligned_t total_pages;
     uint64_aligned_t free_pages;
     uint64_aligned_t scrub_pages;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 11:22:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 11:22:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304074.518625 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neb4d-0006TJ-KZ; Wed, 13 Apr 2022 11:22:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304074.518625; Wed, 13 Apr 2022 11:22:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neb4d-0006T9-Fz; Wed, 13 Apr 2022 11:22:11 +0000
Received: by outflank-mailman (input) for mailman id 304074;
 Wed, 13 Apr 2022 11:22:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aOZT=UX=citrix.com=prvs=09565da51=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1neb4c-0006R9-02
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 11:22:10 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f324d91f-bb1b-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 13:22:07 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f324d91f-bb1b-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649848927;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=wbyb7Wq+N6JL1ki4M/KYMw7YuezFDu+1cHSBTyIgMDM=;
  b=M2gsvU8AXiV1s1lCY3y97LIvru7BRzL6/R1HV1u3tQdxbUcW8M0qVImC
   bPQ7PT5sg1qzNeXyjkHA2Qk4A+VRF0GDpumQIJUg5OAVVQP8XWGJvTMTh
   pANfex9gKv9wVsRx9JZAWaq0TcrXu9rCGVQXnM/SRM2v2qi+wwdvuI13J
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 71195700
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KjAKqq41cRZMv7RdCklaaQxRtNvHchMFZxGqfqrLsTDasY5as4F+v
 jQcUD2HbvqNYWP3c9p0aomxoEIB6JCAz4VqTQVt/ylkHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTgWFvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurS3YicIZqPwwd08dFpaVH8mepd8ppnYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs9s3dtixTQCf8iSJbOa67L+cVZzHE7gcUm8fP2O
 JNAOGcwNEyojxtnNg4zI8MUsNqTqjrgXjcEklWstbgvyj2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sfNgCf6VYQ6BLC+sPlwjzW7+GsXDxEHUEqhltOwgEW+RtF3J
 lQd/2wlqq1a3ECiUNTVRRCzp3+A+BkGVLJ4EeIg7xqW4rHJ+AvfDW8BJhZRZdpjuMIoSDgC0
 l6Sg8ivFTFpqKeSS3+W6vGTtzzaETcRBX8PY2kDVwRty9vprZw3jxnPZs1+C6PzhdrwcQwc2
 BjT8nJ43e9Ky5dWiePrpjgrng5AuLDOZS4UvgvrB1uEyUB7I9D9ILaSt37EuKMowJmicnGNu
 30Nms675e8IDI2QmCHlfNjhDI1F9N7ebmSC3AcH840Jsm30piX9Jdw4DCRWfh8BDyoSRdP+j
 KY/Uyt17YQbAnalZLQfj2mZW5VzlviI+TgIu5npgjtyjnpZKVfvEMJGPxf4M4XRfK4Ey/BX1
 XCzK5jEMJriIf47pAdavs9EuVPR+ggwxHnIWbfwxAm93LyVaRa9EOlZYQvUNrlnsPjf/W05F
 uqz0ePQmn2zt8WkPEHqHXM7dwhWfRDX+7irwyCoSgJzClU/QzxwYxMg6bggZ5Zkj8xoehTgp
 RmAtrtj4AOn3xXvcFzSAlg6Me+Hdcsv/BoTYH13VX71iidLXGpaxPpGH3fBVeJ8r7ILID8dZ
 6RtRvhs9dwWE2qcqmVBN8SlxGGgHTzy7T+z0+OeSGBXV/Zdq8bho4CMktfHnMXWMheKiA==
IronPort-HdrOrdr: A9a23:phnv2q4VxTDGsmAzQgPXwPLXdLJyesId70hD6qhwISY1TiX+rb
 HXoB17726MtN9/YgBCpTntAsa9qDbnhPpICOoqTNGftWvdyQmVxehZhOOIqVCNJ8S9zJ876U
 4JSdkENDSaNzhHZKjBjjVQa+xQpeW6zA==
X-IronPort-AV: E=Sophos;i="5.90,256,1643691600"; 
   d="scan'208";a="71195700"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
Date: Wed, 13 Apr 2022 12:21:11 +0100
Message-ID: <20220413112111.30675-3-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220413112111.30675-1-jane.malalane@citrix.com>
References: <20220413112111.30675-1-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Introduce a new per-domain creation x86 specific flag to
select whether hardware assisted virtualization should be used for
x{2}APIC.

A per-domain option is added to xl in order to select the usage of
x{2}APIC hardware assisted virtualization, as well as a global
configuration option.

Having all APIC interaction exit to Xen for emulation is slow and can
induce much overhead. Hardware can speed up x{2}APIC by decoding the
APIC access and providing a VM exit with a more specific exit reason
than a regular EPT fault or by altogether avoiding a VM exit.

On the other hand, being able to disable x{2}APIC hardware assisted
virtualization can be useful for testing and debugging purposes.

Note:

- vmx_install_vlapic_mapping doesn't require modifications regardless
of whether the guest has "Virtualize APIC accesses" enabled or not,
i.e., setting the APIC_ACCESS_ADDR VMCS field is fine so long as
virtualize_apic_accesses is supported by the CPU.

- Both per-domain and global assisted_x{2}apic options are not part of
the migration stream, unless explicitly set in the respective
configuration files. Default settings of assisted_x{2}apic done
internally by the toolstack, based on host capabilities at create
time, are not migrated.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
Reviewed-by: "Roger Pau Monné" <roger.pau@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Christian Lindig <christian.lindig@citrix.com>
CC: David Scott <dave@recoil.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>

v10:
 * Improve commit message note on migration

v9:
 * Fix style issues
 * Fix exit() logic for assisted_x{2}apic parsing
 * Add and use XEN_X86_MISC_FLAGS_MAX for ABI checking instead of
   using XEN_X86_ASSISTED_X2APIC directly
 * Expand commit message to mention migration is safe

v8:
 * Widen assisted_x{2}apic parsing to PVH guests in
   parse_config_data()

v7:
 * Fix void return in libxl__arch_domain_build_info_setdefault
 * Fix style issues
 * Use EINVAL when rejecting assisted_x{2}apic for PV guests and
   ENODEV otherwise, when assisted_x{2}apic isn't supported
 * Define has_assisted_x{2}apic macros for when !CONFIG_HVM
 * Replace "EPT" fault reference with "p2m" fault since the former is
   Intel-specific

v6:
 * Use ENODEV instead of EINVAL when rejecting assisted_x{2}apic
   for PV guests
 * Move has_assisted_x{2}apic macros out of an Intel specific header
 * Remove references to Intel specific features in documentation

v5:
 * Revert v4 changes in vmx_vlapic_msr_changed(), preserving the use of
   the has_assisted_x{2}apic macros
 * Following changes in assisted_x{2}apic_available definitions in
   patch 1, retighten conditionals for setting
   XEN_HVM_CPUID_APIC_ACCESS_VIRT and XEN_HVM_CPUID_X2APIC_VIRT in
   cpuid_hypervisor_leaves()

v4:
 * Add has_assisted_x{2}apic macros and use them where appropriate
 * Replace CPU checks with per-domain assisted_x{2}apic control
   options in vmx_vlapic_msr_changed() and cpuid_hypervisor_leaves(),
   following edits to assisted_x{2}apic_available definitions in
   patch 1
   Note: new assisted_x{2}apic_available definitions make later
   cpu_has_vmx_apic_reg_virt and cpu_has_vmx_virtual_intr_delivery
   checks redundant in vmx_vlapic_msr_changed()

v3:
 * Change info in xl.cfg to better express reality and fix
   capitalization of x{2}apic
 * Move "physinfo" variable definition to the beggining of
   libxl__domain_build_info_setdefault()
 * Reposition brackets in if statement to match libxl coding style
 * Shorten logic in libxl__arch_domain_build_info_setdefault()
 * Correct dprintk message in arch_sanitise_domain_config()
 * Make appropriate changes in vmx_vlapic_msr_changed() and
   cpuid_hypervisor_leaves() for amended "assisted_x2apic" bit
 * Remove unneeded parantheses

v2:
 * Add a LIBXL_HAVE_ASSISTED_APIC macro
 * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
 * Add a return statement in now "int"
   libxl__arch_domain_build_info_setdefault()
 * Preserve libxl__arch_domain_build_info_setdefault 's location in
   libxl_create.c
 * Correct x{2}apic default setting logic in
   libxl__arch_domain_prepare_config()
 * Correct logic for parsing assisted_x{2}apic host/guest options in
   xl_parse.c and initialize them to -1 in xl.c
 * Use guest options directly in vmx_vlapic_msr_changed
 * Fix indentation of bool assisted_x{2}apic in struct hvm_domain
 * Add a change in xenctrl_stubs.c to pass xenctrl ABI checks
---
 docs/man/xl.cfg.5.pod.in              | 15 +++++++++++++++
 docs/man/xl.conf.5.pod.in             | 12 ++++++++++++
 tools/golang/xenlight/helpers.gen.go  | 12 ++++++++++++
 tools/golang/xenlight/types.gen.go    |  2 ++
 tools/include/libxl.h                 |  7 +++++++
 tools/libs/light/libxl_arch.h         |  5 +++--
 tools/libs/light/libxl_arm.c          |  9 ++++++---
 tools/libs/light/libxl_create.c       | 22 +++++++++++++---------
 tools/libs/light/libxl_types.idl      |  2 ++
 tools/libs/light/libxl_x86.c          | 28 ++++++++++++++++++++++++++--
 tools/ocaml/libs/xc/xenctrl.ml        |  2 ++
 tools/ocaml/libs/xc/xenctrl.mli       |  2 ++
 tools/ocaml/libs/xc/xenctrl_stubs.c   |  2 +-
 tools/xl/xl.c                         |  8 ++++++++
 tools/xl/xl.h                         |  2 ++
 tools/xl/xl_parse.c                   | 19 +++++++++++++++++++
 xen/arch/x86/domain.c                 | 29 ++++++++++++++++++++++++++++-
 xen/arch/x86/hvm/vmx/vmcs.c           |  4 ++++
 xen/arch/x86/hvm/vmx/vmx.c            | 13 ++++---------
 xen/arch/x86/include/asm/hvm/domain.h |  6 ++++++
 xen/arch/x86/include/asm/hvm/hvm.h    |  5 +++++
 xen/arch/x86/traps.c                  |  5 +++--
 xen/include/public/arch-x86/xen.h     |  5 +++++
 23 files changed, 187 insertions(+), 29 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index b98d161398..6d98d73d76 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1862,6 +1862,21 @@ firmware tables when using certain older guest Operating
 Systems. These tables have been superseded by newer constructs within
 the ACPI tables.
 
+=item B<assisted_xapic=BOOLEAN>
+
+B<(x86 only)> Enables or disables hardware assisted virtualization for
+xAPIC. With this option enabled, a memory-mapped APIC access will be
+decoded by hardware and either issue a more specific VM exit than just
+a p2m fault, or altogether avoid a VM exit. The
+default is settable via L<xl.conf(5)>.
+
+=item B<assisted_x2apic=BOOLEAN>
+
+B<(x86 only)> Enables or disables hardware assisted virtualization for
+x2APIC. With this option enabled, certain accesses to MSR APIC
+registers will avoid a VM exit into the hypervisor. The default is
+settable via L<xl.conf(5)>.
+
 =item B<nx=BOOLEAN>
 
 B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest
diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
index df20c08137..95d136d1ea 100644
--- a/docs/man/xl.conf.5.pod.in
+++ b/docs/man/xl.conf.5.pod.in
@@ -107,6 +107,18 @@ Sets the default value for the C<max_grant_version> domain config value.
 
 Default: maximum grant version supported by the hypervisor.
 
+=item B<assisted_xapic=BOOLEAN>
+
+If enabled, domains will use xAPIC hardware assisted virtualization by default.
+
+Default: enabled if supported.
+
+=item B<assisted_x2apic=BOOLEAN>
+
+If enabled, domains will use x2APIC hardware assisted virtualization by default.
+
+Default: enabled if supported.
+
 =item B<vif.default.script="PATH">
 
 Configures the default hotplug script used by virtual network devices.
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index dd4e6c9f14..dece545ee0 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1120,6 +1120,12 @@ x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart)
 if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil {
 return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
+if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
+}
+if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
+}
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
 if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
@@ -1605,6 +1611,12 @@ xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart)
 if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil {
 return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
+if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
+}
+if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
+}
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
 if err := x.Vpmu.toC(&xc.vpmu); err != nil {
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 87be46c745..253c9ad93d 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -520,6 +520,8 @@ Vuart VuartType
 }
 ArchX86 struct {
 MsrRelaxed Defbool
+AssistedXapic Defbool
+AssistedX2Apic Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 94e6355822..cdcccd6d01 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -535,6 +535,13 @@
 #define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
 
 /*
+ * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has
+ * assisted_xapic and assisted_x2apic fields for enabling hardware
+ * assisted virtualization for x{2}apic per domain.
+ */
+#define LIBXL_HAVE_ASSISTED_APIC 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 207ceac6a1..03b89929e6 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -71,8 +71,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
                                                libxl_domain_create_info *c_info);
 
 _hidden
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info);
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo);
 
 _hidden
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 39fdca1b49..7dee2afd4b 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1384,14 +1384,15 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
     }
 }
 
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info)
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo)
 {
     /* ACPI is disabled by default */
     libxl_defbool_setdefault(&b_info->acpi, false);
 
     if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
-        return;
+        return 0;
 
     LOG(DEBUG, "Converting build_info to PVH");
 
@@ -1399,6 +1400,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
     memset(&b_info->u, '\0', sizeof(b_info->u));
     b_info->type = LIBXL_DOMAIN_TYPE_INVALID;
     libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH);
+
+    return 0;
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 885675591f..bbb358bf87 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -75,6 +75,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
                                         libxl_domain_build_info *b_info)
 {
     int i, rc;
+    libxl_physinfo info;
 
     if (b_info->type != LIBXL_DOMAIN_TYPE_HVM &&
         b_info->type != LIBXL_DOMAIN_TYPE_PV &&
@@ -264,7 +265,18 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     if (!b_info->event_channels)
         b_info->event_channels = 1023;
 
-    libxl__arch_domain_build_info_setdefault(gc, b_info);
+    rc = libxl_get_physinfo(CTX, &info);
+    if (rc) {
+        LOG(ERROR, "failed to get hypervisor info");
+        return rc;
+    }
+
+    rc = libxl__arch_domain_build_info_setdefault(gc, b_info, &info);
+    if (rc) {
+        LOG(ERROR, "unable to set domain arch build info defaults");
+        return rc;
+    }
+
     libxl_defbool_setdefault(&b_info->dm_restrict, false);
 
     if (b_info->iommu_memkb == LIBXL_MEMKB_DEFAULT)
@@ -457,14 +469,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) {
-        libxl_physinfo info;
-
-        rc = libxl_get_physinfo(CTX, &info);
-        if (rc) {
-            LOG(ERROR, "failed to get hypervisor info");
-            return rc;
-        }
-
         if (info.cap_gnttab_v2)
             b_info->max_grant_version = 2;
         else if (info.cap_gnttab_v1)
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 42ac6c357b..db5eb0a0b3 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -648,6 +648,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
                                ("vuart", libxl_vuart_type),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
+                               ("assisted_xapic", libxl_defbool),
+                               ("assisted_x2apic", libxl_defbool),
                               ])),
     # Alternate p2m is not bound to any architecture or guest type, as it is
     # supported by x86 HVM and ARM support is planned.
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index e0a06ecfe3..7c5ee74443 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -23,6 +23,15 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
     if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed))
         config->arch.misc_flags |= XEN_X86_MSR_RELAXED;
 
+    if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV)
+    {
+        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic))
+            config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC;
+
+        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic))
+            config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC;
+    }
+
     return 0;
 }
 
@@ -819,11 +828,26 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
 {
 }
 
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info)
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo)
 {
     libxl_defbool_setdefault(&b_info->acpi, true);
     libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
+
+    if (b_info->type != LIBXL_DOMAIN_TYPE_PV) {
+        libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
+                                 physinfo->cap_assisted_xapic);
+        libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
+                                 physinfo->cap_assisted_x2apic);
+    }
+    else if (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) ||
+             !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)) {
+        LOG(ERROR, "Interrupt Controller Virtualization not supported for PV");
+        return ERROR_INVAL;
+    }
+
+    return 0;
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 712456e098..32f3028828 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -50,6 +50,8 @@ type x86_arch_emulation_flags =
 
 type x86_arch_misc_flags =
 	| X86_MSR_RELAXED
+	| X86_ASSISTED_XAPIC
+	| X86_ASSISTED_X2APIC
 
 type xen_x86_arch_domainconfig =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index b034434f68..d0fcbc8866 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -44,6 +44,8 @@ type x86_arch_emulation_flags =
 
 type x86_arch_misc_flags =
   | X86_MSR_RELAXED
+  | X86_ASSISTED_XAPIC
+  | X86_ASSISTED_X2APIC
 
 type xen_x86_arch_domainconfig = {
   emulation_flags: x86_arch_emulation_flags list;
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 7e9c32ad1b..2033d20eab 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -239,7 +239,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 
 		cfg.arch.misc_flags = ocaml_list_to_c_bitmap
 			/* ! x86_arch_misc_flags X86_ none */
-			/* ! XEN_X86_ XEN_X86_MSR_RELAXED all */
+			/* ! XEN_X86_ XEN_X86_MISC_FLAGS_MAX max */
 			(VAL_MISC_FLAGS);
 
 #undef VAL_MISC_FLAGS
diff --git a/tools/xl/xl.c b/tools/xl/xl.c
index 2d1ec18ea3..31eb223309 100644
--- a/tools/xl/xl.c
+++ b/tools/xl/xl.c
@@ -57,6 +57,8 @@ int max_grant_frames = -1;
 int max_maptrack_frames = -1;
 int max_grant_version = LIBXL_MAX_GRANT_DEFAULT;
 libxl_domid domid_policy = INVALID_DOMID;
+int assisted_xapic = -1;
+int assisted_x2apic = -1;
 
 xentoollog_level minmsglevel = minmsglevel_default;
 
@@ -201,6 +203,12 @@ static void parse_global_config(const char *configfile,
     if (!xlu_cfg_get_long (config, "claim_mode", &l, 0))
         claim_mode = l;
 
+    if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0))
+        assisted_xapic = l;
+
+    if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0))
+        assisted_x2apic = l;
+
     xlu_cfg_replace_string (config, "remus.default.netbufscript",
         &default_remus_netbufscript, 0);
     xlu_cfg_replace_string (config, "colo.default.proxyscript",
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index c5c4bedbdd..528deb3feb 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -286,6 +286,8 @@ extern libxl_bitmap global_vm_affinity_mask;
 extern libxl_bitmap global_hvm_affinity_mask;
 extern libxl_bitmap global_pv_affinity_mask;
 extern libxl_domid domid_policy;
+extern int assisted_xapic;
+extern int assisted_x2apic;
 
 enum output_format {
     OUTPUT_FORMAT_JSON,
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index b98c0de378..6080f8154d 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2761,6 +2761,25 @@ skip_usbdev:
 
     xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
 
+    if (b_info->type != LIBXL_DOMAIN_TYPE_PV) {
+        e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0);
+        if (!e)
+            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l);
+        else if (e != ESRCH)
+            exit(1);
+        else if (assisted_xapic != -1) /* use global default if present */
+            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic);
+
+        e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0);
+        if (!e)
+            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l);
+        else if (e != ESRCH)
+            exit(1);
+        else if (assisted_x2apic != -1) /* use global default if present */
+            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic,
+                              assisted_x2apic);
+    }
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index a5048ed654..279936a016 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -50,6 +50,7 @@
 #include <asm/cpuidle.h>
 #include <asm/mpspec.h>
 #include <asm/ldt.h>
+#include <asm/hvm/domain.h>
 #include <asm/hvm/hvm.h>
 #include <asm/hvm/nestedhvm.h>
 #include <asm/hvm/support.h>
@@ -619,6 +620,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt;
+    bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
+    bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
     unsigned int max_vcpus;
 
     if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) )
@@ -685,13 +688,31 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         }
     }
 
-    if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
+    if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED |
+                                     XEN_X86_ASSISTED_XAPIC |
+                                     XEN_X86_ASSISTED_X2APIC) )
     {
         dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
                 config->arch.misc_flags);
         return -EINVAL;
     }
 
+    if ( (assisted_xapic || assisted_x2apic) && !hvm )
+    {
+        dprintk(XENLOG_INFO,
+                "Interrupt Controller Virtualization not supported for PV\n");
+        return -EINVAL;
+    }
+
+    if ( (assisted_xapic && !assisted_xapic_available) ||
+         (assisted_x2apic && !assisted_x2apic_available) )
+    {
+        dprintk(XENLOG_INFO,
+                "Hardware assisted x%sAPIC requested but not available\n",
+                assisted_xapic && !assisted_xapic_available ? "" : "2");
+        return -ENODEV;
+    }
+
     return 0;
 }
 
@@ -864,6 +885,12 @@ int arch_domain_create(struct domain *d,
 
     d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED;
 
+    d->arch.hvm.assisted_xapic =
+        config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
+
+    d->arch.hvm.assisted_x2apic =
+        config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
+
     return 0;
 
  fail:
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 7329622dd4..683c650d77 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1134,6 +1134,10 @@ static int construct_vmcs(struct vcpu *v)
         __vmwrite(PLE_WINDOW, ple_window);
     }
 
+    if ( !has_assisted_xapic(d) )
+        v->arch.hvm.vmx.secondary_exec_control &=
+            ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
+
     if ( cpu_has_vmx_secondary_exec_control )
         __vmwrite(SECONDARY_VM_EXEC_CONTROL,
                   v->arch.hvm.vmx.secondary_exec_control);
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index af9ee7cebb..9048688860 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3344,16 +3344,11 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
 
 void vmx_vlapic_msr_changed(struct vcpu *v)
 {
-    int virtualize_x2apic_mode;
     struct vlapic *vlapic = vcpu_vlapic(v);
     unsigned int msr;
 
-    virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
-                                cpu_has_vmx_virtual_intr_delivery) &&
-                               cpu_has_vmx_virtualize_x2apic_mode );
-
-    if ( !cpu_has_vmx_virtualize_apic_accesses &&
-         !virtualize_x2apic_mode )
+    if ( !has_assisted_xapic(v->domain) &&
+         !has_assisted_x2apic(v->domain) )
         return;
 
     vmx_vmcs_enter(v);
@@ -3363,7 +3358,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
     if ( !vlapic_hw_disabled(vlapic) &&
          (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) )
     {
-        if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) )
+        if ( has_assisted_x2apic(v->domain) && vlapic_x2apic_mode(vlapic) )
         {
             v->arch.hvm.vmx.secondary_exec_control |=
                 SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE;
@@ -3384,7 +3379,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
                 vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W);
             }
         }
-        else
+        else if ( has_assisted_xapic(v->domain) )
             v->arch.hvm.vmx.secondary_exec_control |=
                 SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
     }
diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h
index 698455444e..92bf53483c 100644
--- a/xen/arch/x86/include/asm/hvm/domain.h
+++ b/xen/arch/x86/include/asm/hvm/domain.h
@@ -117,6 +117,12 @@ struct hvm_domain {
 
     bool                   is_s3_suspended;
 
+    /* xAPIC hardware assisted virtualization. */
+    bool                   assisted_xapic;
+
+    /* x2APIC hardware assisted virtualization. */
+    bool                   assisted_x2apic;
+
     /* hypervisor intercepted msix table */
     struct list_head       msixtbl_list;
 
diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h
index e0d9348878..6ecbe22cc9 100644
--- a/xen/arch/x86/include/asm/hvm/hvm.h
+++ b/xen/arch/x86/include/asm/hvm/hvm.h
@@ -376,6 +376,9 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value);
 extern bool assisted_xapic_available;
 extern bool assisted_x2apic_available;
 
+#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic)
+#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic)
+
 #define hvm_get_guest_time(v) hvm_get_guest_time_fixed(v, 0)
 
 #define hvm_paging_enabled(v) \
@@ -878,6 +881,8 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
 #define assisted_xapic_available false
 #define assisted_x2apic_available false
 
+#define has_assisted_xapic(d) ((void)(d), false)
+#define has_assisted_x2apic(d) ((void)(d), false)
 #define hvm_paging_enabled(v) ((void)(v), false)
 #define hvm_wp_enabled(v) ((void)(v), false)
 #define hvm_pcid_enabled(v) ((void)(v), false)
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 4c38f6c015..74ebae48f0 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -1119,7 +1119,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
         if ( !is_hvm_domain(d) || subleaf != 0 )
             break;
 
-        if ( cpu_has_vmx_apic_reg_virt )
+        if ( cpu_has_vmx_apic_reg_virt &&
+             has_assisted_xapic(d) )
             res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT;
 
         /*
@@ -1128,7 +1129,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
          * and wrmsr in the guest will run without VMEXITs (see
          * vmx_vlapic_msr_changed()).
          */
-        if ( cpu_has_vmx_virtualize_x2apic_mode &&
+        if ( has_assisted_x2apic(d) &&
              cpu_has_vmx_apic_reg_virt &&
              cpu_has_vmx_virtual_intr_delivery )
             res->a |= XEN_HVM_CPUID_X2APIC_VIRT;
diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
index 7acd94c8eb..58a1e87ee9 100644
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -317,9 +317,14 @@ struct xen_arch_domainconfig {
  * doesn't allow the guest to read or write to the underlying MSR.
  */
 #define XEN_X86_MSR_RELAXED (1u << 0)
+#define XEN_X86_ASSISTED_XAPIC (1u << 1)
+#define XEN_X86_ASSISTED_X2APIC (1u << 2)
     uint32_t misc_flags;
 };
 
+/* Max  XEN_X86_* constant. Used for ABI checking. */
+#define XEN_X86_MISC_FLAGS_MAX XEN_X86_ASSISTED_X2APIC
+
 /* Location of online VCPU bitmap. */
 #define XEN_ACPI_CPU_MAP             0xaf00
 #define XEN_ACPI_CPU_MAP_LEN         ((HVM_MAX_VCPUS + 7) / 8)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 11:45:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 11:45:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304095.518638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nebR0-00017v-Nw; Wed, 13 Apr 2022 11:45:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304095.518638; Wed, 13 Apr 2022 11:45:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nebR0-00017o-L7; Wed, 13 Apr 2022 11:45:18 +0000
Received: by outflank-mailman (input) for mailman id 304095;
 Wed, 13 Apr 2022 11:45:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nebQz-00017O-OS; Wed, 13 Apr 2022 11:45:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nebQz-0000hn-Hv; Wed, 13 Apr 2022 11:45:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nebQz-0007nC-60; Wed, 13 Apr 2022 11:45:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nebQz-0001dL-5Y; Wed, 13 Apr 2022 11:45:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BDdZOLZRpKjH+mwPXGvN6grh2DEYhY4/BU4ieKQeqzE=; b=b0XWWnXABKII2lf377S6kowAbN
	G5gSPD2uHQ2rdsOkY8WxqH08e0UI5KtqJjkMxVWRPpzwV/9VRuA3HGDHxnbjFq33b155KCF7ttgty
	ilbnJdoydt7dlQl/xHr+XEk9SMmC+0AiXhT1LmCm5PFEqml3Iy7lmphwV00Urzs/CLg0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169362-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169362: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 11:45:17 +0000

flight 169362 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169362/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  360 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 12:58:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 12:58:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304108.518649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1necZe-00089x-EK; Wed, 13 Apr 2022 12:58:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304108.518649; Wed, 13 Apr 2022 12:58:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1necZe-00089q-B8; Wed, 13 Apr 2022 12:58:18 +0000
Received: by outflank-mailman (input) for mailman id 304108;
 Wed, 13 Apr 2022 12:58:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1necZd-00089g-Kl; Wed, 13 Apr 2022 12:58:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1necZd-0001sf-E5; Wed, 13 Apr 2022 12:58:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1necZc-00011x-SK; Wed, 13 Apr 2022 12:58:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1necZc-00066C-Ru; Wed, 13 Apr 2022 12:58:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GxGH/51JxXBk7KuX5XtzEeKKecuemEWEkw6gxE84WDQ=; b=4hJ2zODm4CP29g66BmTkCnuNgz
	RSKD3Ca/ow0BfobCycAgFmU/rprM/NouPWyTlRaOAhbaIVtpFCdDzpOqn5XUOYFs11erC7N/P2wvS
	kpCg0b+AKQDHdHRjLi/nui9LF7tAESPAxs6pRNdk7aPpJYZbjPTs0FfNeHv8ai0jv2lM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169363-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169363: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 12:58:16 +0000

flight 169363 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169363/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  361 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 13:05:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 13:05:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304116.518661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1necgX-0001Cl-7z; Wed, 13 Apr 2022 13:05:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304116.518661; Wed, 13 Apr 2022 13:05:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1necgX-0001Ce-4N; Wed, 13 Apr 2022 13:05:25 +0000
Received: by outflank-mailman (input) for mailman id 304116;
 Wed, 13 Apr 2022 13:05:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VMZD=UX=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1necgV-0001CW-E5
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 13:05:24 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0626.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::626])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e1bf31b-bb2a-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 15:05:18 +0200 (CEST)
Received: from DBBPR09CA0016.eurprd09.prod.outlook.com (2603:10a6:10:c0::28)
 by VE1PR08MB5853.eurprd08.prod.outlook.com (2603:10a6:800:1a5::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 13:05:16 +0000
Received: from DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:c0:cafe::37) by DBBPR09CA0016.outlook.office365.com
 (2603:10a6:10:c0::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Wed, 13 Apr 2022 13:05:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT038.mail.protection.outlook.com (10.152.21.84) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 13:05:16 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Wed, 13 Apr 2022 13:05:15 +0000
Received: from d72cee239e49.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E52DB89D-E805-4C04-9EFE-210FEBC89EE3.1; 
 Wed, 13 Apr 2022 13:05:02 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d72cee239e49.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Apr 2022 13:05:02 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM0PR08MB3681.eurprd08.prod.outlook.com
 (2603:10a6:208:fd::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 13:04:59 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0%11]) with mapi id 15.20.5164.020; Wed, 13 Apr
 2022 13:04:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e1bf31b-bb2a-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mI5x62sG5rnlFzxUbJhAgVnJ9Wy/BgeGWl04Wnm4h0o=;
 b=feRQx4eFQr+5g4tEQBkT1UQZ9/cKsm5vpY5EVcRKfpiZVnuCgGEIoLqXGUIduLqiTsmZvK+ucJHxKoycJRuuyjn/md85rB9yWY1K8Fr9hFtdvyGf0Wemeql3yK/O+syspxmxpt7XoI6otwn8x0Z5tD4V0SOsw5y5Xp0TfjNhTME=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c6fc9485e574078f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Sbz+S3J/iY6FvI1yqDlE/ueUHCAqWSPnIHDJwm+Q7GUilsfC8l68IVXI4lC3jDlSlQS6eoar1A1VkVsyzDbbjJVR1OLmmWGY5rc5gc84hRl7rRkhouBTVNmncYoLiV/G5Cj1Km1vJO224FPWtxbo8q8tOGKu7ektcfvB+7gxC49idGeCr269Te51UAAlMuN0uLcS/RblPMEKGwZq5AyCzd3Xzz40npq2fFobChMiEl4anHv8qd9nGiVcXDRlM83omrzoOyYJAku3KyS2BoY1JjcmAbqIG/ggBXwIV5Rd1EdwuZ4trLiFhE6ethqNodoBJg9q3ZKfTQLOf4xMuYLzZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mI5x62sG5rnlFzxUbJhAgVnJ9Wy/BgeGWl04Wnm4h0o=;
 b=ZcCPqWWMsZ9wfpn+kvg5Y3JoURW3TDNO58FbJZd9tf2tYjKWD+RjOpd9lgSQZnIFQbRHgFg9s9Ssmzp5Jx/JnBbAZmpn++lo/QosLSaiA21Kvv4vyj5df/+adRCQXYE0amKf4s58YYRSoX75wvUVq7Omqd8uyL8SLrmkPC89RS0BIR7CZ1Opo7xDfoo7Egj3zIY034mnUv7OJdzzRuNCS67+cg0RghTXiPvKg/MfBKyyF8gP2YMohe9uOD63mPHPUH4o1SjV8vM7n2JPJQKHLRs6+gaEAkgar61hOzoXnOOReV++NwQU0gVLN6wIao7qxkO/dGVPdJox0ijf6/+cOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mI5x62sG5rnlFzxUbJhAgVnJ9Wy/BgeGWl04Wnm4h0o=;
 b=feRQx4eFQr+5g4tEQBkT1UQZ9/cKsm5vpY5EVcRKfpiZVnuCgGEIoLqXGUIduLqiTsmZvK+ucJHxKoycJRuuyjn/md85rB9yWY1K8Fr9hFtdvyGf0Wemeql3yK/O+syspxmxpt7XoI6otwn8x0Z5tD4V0SOsw5y5Xp0TfjNhTME=
From: Rahul Singh <Rahul.Singh@arm.com>
To: xen-devel <xen-devel@lists.xenproject.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Jan Beulich
	<jbeulich@suse.com>
Subject: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Topic: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Index: AQHYTzcU8ajhGbP8IkOxb7sffXDxrA==
Date: Wed, 13 Apr 2022 13:04:58 +0000
Message-ID: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 0b1e2c4b-3aab-4d3a-b263-08da1d4e40ec
x-ms-traffictypediagnostic:
	AM0PR08MB3681:EE_|DB5EUR03FT038:EE_|VE1PR08MB5853:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB5853D52C1C2D5169020FC96DFCEC9@VE1PR08MB5853.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 opGEvNFfSiFq00h8a7qUYBV5B3regqNNUpvqsRTLQSN1/LAwYIXoXwnvc243RONDQfueqClUTmqwSj4i9Oy+Qo/eKiaqbBo5GGqmHqkyAgRA5IzvU37UwHE7HDNOpGHrnuJCJ1GEWPVAIZBUpp1FqsG75GvbZSEhif4sggW6zWrT9UF9r9IbKI/QuumDKS7cKeBWOz8FcKuHzC3dGxpN5A3/DgwDSnlvUSQ7AbaOTJAWVSiUM01CkE/8V/K30abxHFjaMF7GqK9TDsIAkx/jt07aaB82wnA9TT/1OCC7K6sbUDfUb3yGVNGSPFhayaH+Ey53prqPrQUpYWiuYS6HX2fZ6NdwD+D/+f5422YF0m4rtzgHmfIdA68BwY+LaMXLnEBu1HiId5vmu+GaoK21ljvaxi01hRXTDj8tFnyMO/eFU3qGDQzZeU1hyx28MC92Z60WgkClN6KaXeaTxlJLQXGvKBWzPOcauNOLTtohK+N3gORgPiQlZDY9TYDpKRWcjeD02KQeQHE5NHDcfRVDcvk1Sl+mnHKWbWYmUURUyxUia6i6Fsq5IsqMW61yL7JWMmsPrl9RQU/U4y9sWnYkrjSPBWyN7IHGObnXg1+M7lqrtR05MD9Ad3s7B69CUkDbX0IahjhXy75etofVz/aq3t+xJx1+GwjZRmfkdhxBO0M8JvjJtXf9gHOGxIZCGcTfz388KJGO3vUtOrCaQwjDnTjZLafUeTMhtDu05XaROkczA8m3kexA6VsxsFpT2uikjNfeSECoXQGlfDsJwqLDQd3yt7wIC1bBASIFLNeu9hoPxVD3CEBGXWOrZHuLBk1oQG01Si7UwF7wTtOO6fdjn3JboK4qNOaBOdfW2xFCBRI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(8936002)(2906002)(45080400002)(186003)(26005)(38070700005)(64756008)(91956017)(8676002)(76116006)(6512007)(66946007)(4326008)(966005)(2616005)(66446008)(498600001)(36756003)(6916009)(54906003)(66476007)(6486002)(38100700002)(66556008)(5660300002)(122000001)(83380400001)(86362001)(99936003)(71200400001)(166002)(33656002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: multipart/mixed;
	boundary="_004_C82612B1FED541399B87FB33DD81F01Aarmcom_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3681
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4467ed10-9ab8-4ba3-d352-08da1d4e36cf
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	f0YCQS6Y1wj+2BqJ9vpEriaeXwS3Aq02MrwcrGV06oKzy6hrchT8pWCO7Xlce4JUI3aG6ZD8z1E4vmI1RXLIChs7tBQt+YELwq/aALoQr8Bzk47iFRzg5j1tGgLX/qL5wk39GhXZV8BfX5MwKA2yGiPd5AYZBT9bb2MsYzOtTYHc2vtH55aGUj42qr1bRoVHgRdXR1xlvNdblNADrHEc1cEnxbnkB0Il9fZXfyFIZWA85kJb1BTrmW/spTHs/Ts8W78rS4hqMIu/OhTAeGWj/61QvdKzzBOzFu/1hWr+HVOMiklzYopTXodY8xiwtlEc/Yl3+yNV0j1j8fiuv+ipgP7uJFdcUy7JCdDV9Pu2Hu9qikd6kn6V0dvBbUpPZeItwfNJ1l6bnti+WN3ZQ7wfhB37Hz9x9UX3ujWc5Knoth4WolxnrUd/qAGZ1Fmm2fv9Px0fTKeoqEqFc8FKc7pbBqTSzy7PLTg4fPl6p9yoComXCzEmNo9QSAFsdbXj3Yp2cDvW6xf9jyjovvC55fGMQwUwkOa/JRvCGlkRJwYfD/OKu6Lw0R1MTjq3cKETg3eijByprMpjH+HZIx0db8snXOrXyPmAL/w5KO/IHN8KvF/ZO2tJ4ODGTn+aLt5hS7+F0mUTENgw2OIhLZSG3D5tLGB7YPuMNgjWlRIuhBlbqTpAStOgrwIUypPwnXTr/eWS73Hu/OTMUfCa4HkTVplpTrFqQPWeit5H2BTbGwz8xodzI/9IreXBYbq4NqSUAcwTEfSLahObqhJDoS8C2gN/ly4KONB33P+15VWcV41aQJE=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(54906003)(8676002)(21480400003)(498600001)(6916009)(8936002)(30864003)(186003)(33656002)(99936003)(166002)(356005)(336012)(70206006)(81166007)(70586007)(33964004)(107886003)(45080400002)(83380400001)(40460700003)(6506007)(6512007)(5660300002)(4326008)(235185007)(26005)(82310400005)(36756003)(36860700001)(47076005)(2906002)(6486002)(966005)(2616005)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 13:05:16.0098
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1e2c4b-3aab-4d3a-b263-08da1d4e40ec
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5853

--_004_C82612B1FED541399B87FB33DD81F01Aarmcom_
Content-Type: multipart/alternative;
	boundary="_000_C82612B1FED541399B87FB33DD81F01Aarmcom_"

--_000_C82612B1FED541399B87FB33DD81F01Aarmcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

SGVsbG8gQWxsLA0KDQpXZSBhcmUgdHJ5aW5nIHRvIGJvb3QgdGhlIFhlbiA0LjE1LjEgYW5kIGRv
bTAgTGludXggS2VybmVsICg1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQgZnJvbSBbMV0gKSBv
biBBbXBlcmUgQWx0cmEgLyBBVkEgRGV2ZWxvcGVyIFBsYXRmb3JtIFsyXSB3aXRoIEFDUEkuDQoN
Ck5WTWUgc3RvcmFnZSBpcyBjb25uZWN0ZWQgdG8gUENJZS4gTmF0aXZlIExpbnV4IGtlcm5lbCBi
b290IGZpbmUgYW5kIGFsc28gSSBhbSBhYmxlIHRvIGRldGVjdCBhbmQgYWNjZXNzIE5WTWUgc3Rv
cmFnZS4NCkhvd2V2ZXIsIGR1cmluZyBYRU4gYm9vdCB3aGVuIE5WTUUgZHJpdmVyIGlzIHJlcXVl
c3RpbmcgdGhlIERNQSBidWZmZXIgd2UgYXJlIG9ic2VydmluZyB0aGUgT29wcyB3aXRoIFhFTi4N
Cg0KUGxlYXNlIGZpbmQgdGhlIGF0dGFjaGVkIGRldGFpbCBsb2dzIGZvciBYZW4gYW5kIGRvbTAg
Ym9vdGluZy4NCg0KU25pcCBmcm9tIGxvZ3M6DQooWEVOKSBkMHYwOiB2R0lDUjogU0dJOiB1bmhh
bmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANClsgICAgMC4w
MDAwMDBdIEJvb3RpbmcgTGludXggb24gcGh5c2ljYWwgQ1BVIDB4MDAwMDAwMDAwMCBbMHg0MTNm
ZDBjMV0NClsgICAgMC4wMDAwMDBdIExpbnV4IHZlcnNpb24gNS4xMC4yNy1hbXBlcmUtbHRzLXN0
YW5kYXJkIChvZS11c2VyQG9lLWhvc3QpIChhYXJjaDY0LXBva3ktbGludXgtZ2NjIChHQ0MpIDEx
LjIuMCwgR05VIGxkIChHTlUgQmludXRpbHMpIDIuMzcuMjAyMTA3MjEpICMxIFNNUCBQUkVFTVBU
IFNhdCBTZXAgMTggMDY6MDE6NTkgVVRDIDIwMjENClsgICAgMC4wMDAwMDBdIFhlbiBYRU5fVkVS
U0lPTi5YRU5fU1VCVkVSU0lPTiBzdXBwb3J0IGZvdW5kDQpbICAgIDAuMDAwMDAwXSBlZmk6IEVG
SSB2Mi41MCBieSBYZW4NClsgICAgMC4wMDAwMDBdIGVmaTogQUNQSSAyLjA9MHg4MDdmNjZjZWNl
OA0KWyAgICAwLjAwMDAwMF0gQUNQSTogRWFybHkgdGFibGUgY2hlY2tzdW0gdmVyaWZpY2F0aW9u
IGRpc2FibGVkDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBSU0RQIDB4MDAwMDA4MDdGNjZDRUNFOCAw
MDAwMjQgKHYwMiBBbXBlcmUpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBYU0RUIDB4MDAwMDA4MDdG
NjZDRUMzOCAwMDAwQUMgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAx
MykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEZBQ1AgMHgwMDAwMDgwN0Y2NkNFMDAwIDAwMDExNCAo
djA2IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAw
MF0gQUNQSTogRFNEVCAweDAwMDAwODA3RjhEQjAwMTggMDJDMTlFICh2MDIgQW1wZXJlIEphZGUg
ICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBCRVJUIDB4
MDAwMDA4MDdGQTBERkY5OCAwMDAwMzAgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1Q
LiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IERCRzIgMHgwMDAwMDgwN0ZBMERGQTk4
IDAwMDA1QyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAg
ICAwLjAwMDAwMF0gQUNQSTogR1REVCAweDAwMDAwODA3RkEwREU5OTggMDAwMTEwICh2MDMgQW1w
ZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBTUENSIDB4MDAwMDA4MDdGQTBERkUxOCAwMDAwNTAgKHYwMiBBbXBlcmUgQWx0cmEgICAgMDAw
MDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEVJTkogMHgwMDAwMDgw
N0ZBMERGNTk4IDAwMDE1MCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAx
MjE3KQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogSEVTVCAweDAwMDAwODA3RkEwREVCMTggMDAwMUY0
ICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQpbICAgIDAuMDAw
MDAwXSBBQ1BJOiBTU0RUIDB4MDAwMDA4MDdGQTBERkExOCAwMDAwMkQgKHYwMiBBbXBlcmUgQWx0
cmEgICAgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFRQTTIg
MHgwMDAwMDgwN0ZBMERGRDE4IDAwMDA0QyAodjA0IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBB
TVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogTUNGRyAweDAwMDAwODA3RkEwREY3
MTggMDAwMDdDICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIEFNUC4gMDEwMDAwMTMpDQpb
ICAgIDAuMDAwMDAwXSBBQ1BJOiBJT1JUIDB4MDAwMDA4MDdGQTBERUYxOCAwMDAzREMgKHYwMCBB
bXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFD
UEk6IEFQSUMgMHgwMDAwMDgwN0Y2NkNFMTE4IDAwMEFGNCAodjA1IEFtcGVyZSBBbHRyYSAgICAw
MDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogUFBUVCAweDAwMDAw
ODA3RkEwRDg2MTggMDA0NTIwICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEw
MDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTTElUIDB4MDAwMDA4MDdGQTBERkQ5OCAwMDAw
MkQgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4w
MDAwMDBdIEFDUEk6IFNSQVQgMHgwMDAwMDgwN0ZBMERDRTE4IDAwMDM3MCAodjAzIEFtcGVyZSBB
bHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogUEND
VCAweDAwMDAwODA3RkEwREUzMTggMDAwNTc2ICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAy
IEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTVEFPIDB4MDAwMDA4MDdGNjZD
RUMxMCAwMDAwMjUgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykN
ClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1I6IGNvbnNvbGU6IHBsMDExLG1taW8zMiwweDEwMDAw
MjYwMDAwMCwxMTUyMDANClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBb
bWVtIDB4ODgzMDAwMDAtMHg4ODNmZmZmZl0NClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5v
ZGUgMCBQWE0gMCBbbWVtIDB4OTAwMDAwMDAtMHhmZmZmZmZmZl0NClsgICAgMC4wMDAwMDBdIEFD
UEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODAwMDAwMDAwMDAtMHg4MDA3ZmZmZmZmZl0N
ClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODAxMDAwMDAw
MDAtMHg4MDdmZmZmZmZmZl0NClsgICAgMC4wMDAwMDBdIE5VTUE6IE5PREVfREFUQSBbbWVtIDB4
ODA3OWZiZjVlMDAtMHg4MDc5ZmJmN2ZmZl0NClsgICAgMC4wMDAwMDBdIFpvbmUgcmFuZ2VzOg0K
WyAgICAwLjAwMDAwMF0gICBETUEgICAgICBbbWVtIDB4MDAwMDAwMDA5ODAwMDAwMC0weDAwMDAw
MDAwZmZmZmZmZmZdDQpbICAgIDAuMDAwMDAwXSAgIERNQTMyICAgIGVtcHR5DQpbICAgIDAuMDAw
MDAwXSAgIE5vcm1hbCAgIFttZW0gMHgwMDAwMDAwMTAwMDAwMDAwLTB4MDAwMDA4MDdmYTBkZmZm
Zl0NClsgICAgMC4wMDAwMDBdIE1vdmFibGUgem9uZSBzdGFydCBmb3IgZWFjaCBub2RlDQpbICAg
IDAuMDAwMDAwXSBFYXJseSBtZW1vcnkgbm9kZSByYW5nZXMNCuKApi4NCg0KWyAgICAwLjAwMDAw
MF0gRGVudHJ5IGNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMjYyMTQ0IChvcmRlcjogOSwgMjA5
NzE1MiBieXRlcywgbGluZWFyKQ0KWyAgICAwLjAwMDAwMF0gSW5vZGUtY2FjaGUgaGFzaCB0YWJs
ZSBlbnRyaWVzOiAxMzEwNzIgKG9yZGVyOiA4LCAxMDQ4NTc2IGJ5dGVzLCBsaW5lYXIpDQpbICAg
IDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBzdGFjazpvZmYsIGhlYXAgYWxsb2M6b2ZmLCBoZWFw
IGZyZWU6b2ZmDQpbICAgIDAuMDAwMDAwXSBzb2Z0d2FyZSBJTyBUTEI6IG1hcHBlZCBbbWVtIDB4
MDAwMDAwMDBmNDAwMDAwMC0weDAwMDAwMDAwZjgwMDAwMDBdICg2NE1CKQ0KWyAgICAwLjAwMDAw
MF0gTWVtb3J5OiAxOTI5MTUySy8yMDk3NDEySyBhdmFpbGFibGUgKDEzNTY4SyBrZXJuZWwgY29k
ZSwgMTk5NksgcndkYXRhLCAzNDc2SyByb2RhdGEsIDQxNjBLIGluaXQsIDgyMksgYnNzLCAxNjgy
NjBLIHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2ZWQpDQpbICAgIDAuMDAwMDAwXSBTTFVCOiBIV2Fs
aWduPTY0LCBPcmRlcj0wLTMsIE1pbk9iamVjdHM9MCwgQ1BVcz0zMiwgTm9kZXM9MQ0KWyAgICAw
LjAwMDAwMF0gZnRyYWNlOiBhbGxvY2F0aW5nIDQxMzA2IGVudHJpZXMgaW4gMTYyIHBhZ2VzDQri
gKYuDQoNCuKApi4NClsgICAxMi41OTk0ODRdIGxvb3A6IG1vZHVsZSBsb2FkZWQNClsgICAxMi42
MDMxNjBdIG52bWUgbnZtZTA6IHBjaSBmdW5jdGlvbiAwMDA1OjA0OjAwLjANClsgICAxMi42MDgx
MjldIGlnYjogSW50ZWwoUikgR2lnYWJpdCBFdGhlcm5ldCBOZXR3b3JrIERyaXZlcg0KWyAgIDEy
LjYxMzQ5NV0gaWdiOiBDb3B5cmlnaHQgKGMpIDIwMDctMjAxNCBJbnRlbCBDb3Jwb3JhdGlvbi4N
ClsgICAxMi42MTM2MzZdIG52bWUgbnZtZTA6IG1pc3Npbmcgb3IgaW52YWxpZCBTVUJOUU4gZmll
bGQuDQpbICAgMTIuNjI1OTQxXSBVbmFibGUgdG8gaGFuZGxlIGtlcm5lbCBOVUxMIHBvaW50ZXIg
ZGVyZWZlcmVuY2UgYXQgdmlydHVhbCBhZGRyZXNzIDAwMDAwMDAwMDAwMDAwMDgNClsgICAxMi42
MzQ3MjZdIE1lbSBhYm9ydCBpbmZvOg0KWyAgIDEyLjYzNzUyMF0gICBFU1IgPSAweDk2MDAwMDQ0
DQpbICAgMTIuNjQwNjQ2XSAgIEVDID0gMHgyNTogREFCVCAoY3VycmVudCBFTCksIElMID0gMzIg
Yml0cw0KWyAgIDEyLjY0NjA1NV0gICBTRVQgPSAwLCBGblYgPSAwDQpbICAgMTIuNjQ5MTUzXSAg
IEVBID0gMCwgUzFQVFcgPSAwDQpbICAgMTIuNjUyMzY1XSBEYXRhIGFib3J0IGluZm86DQpbICAg
MTIuNjU1MzE0XSAgIElTViA9IDAsIElTUyA9IDB4MDAwMDAwNDQNClsgICAxMi42NTkyMzFdICAg
Q00gPSAwLCBXblIgPSAxDQpbICAgMTIuNjYyMjYwXSBbMDAwMDAwMDAwMDAwMDAwOF0gdXNlciBh
ZGRyZXNzIGJ1dCBhY3RpdmVfbW0gaXMgc3dhcHBlcg0KWyAgIDEyLjY2ODcyNF0gSW50ZXJuYWwg
ZXJyb3I6IE9vcHM6IDk2MDAwMDQ0IFsjMV0gUFJFRU1QVCBTTVANClsgICAxMi42NzQzNThdIE1v
ZHVsZXMgbGlua2VkIGluOg0KWyAgIDEyLjY3NzQ1NV0gQ1BVOiAwIFBJRDogNyBDb21tOiBrd29y
a2VyL3U2NDowIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMt
c3RhbmRhcmQgIzENClsgICAxMi42ODcwODNdIFdvcmtxdWV1ZTogbnZtZS1yZXNldC13cSBudm1l
X3Jlc2V0X3dvcmsNClsgICAxMi42OTIwNTldIHBzdGF0ZTogNjBjMDAwODUgKG5aQ3YgZGFJZiAr
UEFOICtVQU8gLVRDTyBCVFlQRT0tLSkNClsgICAxMi42OTgxNDldIHBjIDogc3RlYWxfc3VpdGFi
bGVfZmFsbGJhY2srMHgxMzgvMHgyZjANClsgICAxMi43MDMxNzBdIGxyIDogc3RlYWxfc3VpdGFi
bGVfZmFsbGJhY2srMHgxYmMvMHgyZjANClsgICAxMi43MDgyMDNdIHNwIDogZmZmZjgwMDAxMTk2
YjgyMA0KWyAgIDEyLjcxMTU2OV0geDI5OiBmZmZmODAwMDExOTZiODIwIHgyODogMDAwMDAwMDAw
MDAwMDAwMA0KWyAgIDEyLjcxNjk3NV0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgw
MDAxMTRkYmNiMA0KWyAgIDEyLjcyMjM1N10geDI1OiBmZmZmZmRmZmZmZTAwMDAwIHgyNDogMDAw
MDAwMDAwMDAwMDAwMQ0KWyAgIDEyLjcyNzc0MF0geDIzOiAwMDAwMDAwMDAwMDAwMDAwIHgyMjog
ZmZmZmZlMjAxYmY2MDAwMA0KWyAgIDEyLjczMzEyMF0geDIxOiBmZmZmMDgwNzFmYmY2OTgwIHgy
MDogMDAwMDAwMDAwMDAwMDkwMQ0KWyAgIDEyLjczODUwMl0geDE5OiAwMDAwMDAwMDAwMDgwMDAw
IHgxODogZmZmZmZmZmZmZmZmZmZmZg0KWyAgIDEyLjc0Mzg4NF0geDE3OiAwMDAwMDAwMDAwMDAw
MDAwIHgxNjogMDAwMDAwMDAwMDAwMDAxMg0KWyAgIDEyLjc0OTI2Nl0geDE1OiBmZmZmMDgwNzA1
MDhjNjgzIHgxNDogMDAwMDAwMDAwMDAwMDA1OA0KWyAgIDEyLjc1NDY0OF0geDEzOiAwMDAwMDAw
MDAwMDAwMGMwIHgxMjogMDAwMDAwMDAwMDAwMDAwMA0KWyAgIDEyLjc2MDAzMF0geDExOiAwMDAw
MDAwMDAwMDAwNDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwYw0KWyAgIDEyLjc2NTQxMl0geDkgOiBm
ZmZmODAwMDEwMDM5ZDU4IHg4IDogMDAwMDAwMDAyMDAwMDAwMA0KWyAgIDEyLjc3MDc5NF0geDcg
OiAwMDAwMDAwMDAwMDAwMDE4IHg2IDogZmZmZjgwMDAxMTc1MDg5MA0KWyAgIDEyLjc3NjE3Nl0g
eDUgOiBmZmZmODAwMDExNzUwODc4IHg0IDogMDAwMDAwMDAwMDAwMDAwMA0KWyAgIDEyLjc4MTU1
OF0geDMgOiAwMDAwMDAwMDAwMDAwMDAwIHgyIDogMDAwMDAwMDAwMDAwMDAwMA0KWyAgIDEyLjc4
Njk0MF0geDEgOiAwMDAwMDAwMDAwMDAwMjAwIHgwIDogMDAwMDAwMDAwMDAwMDAwMA0KWyAgIDEy
Ljc5MjMyMl0gQ2FsbCB0cmFjZToNClsgICAxMi43OTQ4MDZdICBzdGVhbF9zdWl0YWJsZV9mYWxs
YmFjaysweDEzOC8weDJmMA0KWyAgIDEyLjc5OTUyMF0gIGdldF9wYWdlX2Zyb21fZnJlZWxpc3Qr
MHhlMzAvMHgxMmEwDQpbICAgMTIuODA0MjA3XSAgX19hbGxvY19wYWdlc19ub2RlbWFzaysweDE0
OC8weGUwMA0KWyAgIDEyLjgwODgwOV0gIF9fZG1hX2RpcmVjdF9hbGxvY19wYWdlcysweGE0LzB4
MWQwDQpbICAgMTIuODEzNDk2XSAgZG1hX2RpcmVjdF9hbGxvYysweDFkOC8weDM0MA0KWyAgIDEy
LjgxNzU3MV0gIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50KzB4NjgvMHgzNzANClsgICAxMi44
MjI0MzldICBkbWFfYWxsb2NfYXR0cnMrMHhlOC8weGYwDQpbICAgMTIuODI2MjQ2XSAgbnZtZV9y
ZXNldF93b3JrKzB4MTAzMC8weDE1MjANClsgICAxMi44MzA0MTddICBwcm9jZXNzX29uZV93b3Jr
KzB4MWRjLzB4NGJjDQpbICAgMTIuODM0NDk1XSAgd29ya2VyX3RocmVhZCsweDE0NC8weDQ3MA0K
WyAgIDEyLjgzODMxM10gIGt0aHJlYWQrMHgxNGMvMHgxNjANClsgICAxMi44NDE2MDRdICByZXRf
ZnJvbV9mb3JrKzB4MTAvMHgzOA0KWyAgIDEyLjg0NTI1NV0gQ29kZTogYTk0MDgyYzQgZDM3ZWY0
NjMgY2IzYzQwNjMgOGIzYzQwNDIgKGY5MDAwNDgwKQ0KWyAgIDEyLjg1MTQ0N10gLS0tWyBlbmQg
dHJhY2UgZjY4NzI4YTBkMzA1M2I3MiBdLS0tDQpbICAgMTIuODU2MTE3XSBub3RlOiBrd29ya2Vy
L3U2NDowWzddIGV4aXRlZCB3aXRoIHByZWVtcHRfY291bnQNCg0K4oCmLg0KDQoNClsxXSBodHRw
czovL2dpdGh1Yi5jb20vQW1wZXJlQ29tcHV0aW5nL2FtcGVyZS1sdHMta2VybmVsDQpbMl0gaHR0
cHM6Ly93d3cuaXBpLndpa2kvcGFnZXMvY29tLWhwYy1hbHRyYQ0KDQoNCg0KUmVnYXJkcywNClJh
aHVsDQo=

--_000_C82612B1FED541399B87FB33DD81F01Aarmcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <EE16A1E058D01848B0EA0ACBB15EC006@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i
Qm9keUZyYWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQ7
Ij4NCjxkaXYgY2xhc3M9IlBsYWluVGV4dCI+SGVsbG8gQWxsLDxicj4NCjxicj4NCldlIGFyZSB0
cnlpbmcgdG8gYm9vdCB0aGUgWGVuIDQuMTUuMSBhbmQgZG9tMCBMaW51eCBLZXJuZWwgKDUuMTAu
MjctYW1wZXJlLWx0cy1zdGFuZGFyZCBmcm9tIFsxXSApIG9uIEFtcGVyZSBBbHRyYSAvIEFWQSBE
ZXZlbG9wZXIgUGxhdGZvcm0gWzJdIHdpdGggQUNQSS48YnI+DQo8YnI+DQpOVk1lIHN0b3JhZ2Ug
aXMgY29ubmVjdGVkIHRvIFBDSWUuIE5hdGl2ZSBMaW51eCBrZXJuZWwgYm9vdCBmaW5lIGFuZCBh
bHNvIEkgYW0gYWJsZSB0byBkZXRlY3QgYW5kIGFjY2VzcyBOVk1lIHN0b3JhZ2UuPGJyPg0KSG93
ZXZlciwgZHVyaW5nIFhFTiBib290IHdoZW4gTlZNRSBkcml2ZXIgaXMgcmVxdWVzdGluZyB0aGUg
RE1BIGJ1ZmZlciB3ZSBhcmUgb2JzZXJ2aW5nIHRoZSBPb3BzIHdpdGggWEVOLjxicj4NCjxicj4N
ClBsZWFzZSBmaW5kIHRoZSBhdHRhY2hlZCBkZXRhaWwgbG9ncyBmb3IgWGVuIGFuZCBkb20wIGJv
b3RpbmcuPGJyPg0KPGJyPg0KU25pcCBmcm9tIGxvZ3M6PGJyPg0KKFhFTikgZDB2MDogdkdJQ1I6
IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIw
PGJyPg0KWyZuYnNwOyZuYnNwOyZuYnNwOyAwLjAwMDAwMF0gQm9vdGluZyBMaW51eCBvbiBwaHlz
aWNhbCBDUFUgMHgwMDAwMDAwMDAwIFsweDQxM2ZkMGMxXTxicj4NClsmbmJzcDsmbmJzcDsmbmJz
cDsgMC4wMDAwMDBdIExpbnV4IHZlcnNpb24gNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkIChv
ZS11c2VyQG9lLWhvc3QpIChhYXJjaDY0LXBva3ktbGludXgtZ2NjIChHQ0MpIDExLjIuMCwgR05V
IGxkIChHTlUgQmludXRpbHMpIDIuMzcuMjAyMTA3MjEpICMxIFNNUCBQUkVFTVBUIFNhdCBTZXAg
MTggMDY6MDE6NTkgVVRDIDIwMjE8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBY
ZW4gWEVOX1ZFUlNJT04uWEVOX1NVQlZFUlNJT04gc3VwcG9ydCBmb3VuZDxicj4NClsmbmJzcDsm
bmJzcDsmbmJzcDsgMC4wMDAwMDBdIGVmaTogRUZJIHYyLjUwIGJ5IFhlbjxicj4NClsmbmJzcDsm
bmJzcDsmbmJzcDsgMC4wMDAwMDBdIGVmaTogQUNQSSAyLjA9MHg4MDdmNjZjZWNlOCA8YnI+DQpb
Jm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBFYXJseSB0YWJsZSBjaGVja3N1bSB2
ZXJpZmljYXRpb24gZGlzYWJsZWQ8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBB
Q1BJOiBSU0RQIDB4MDAwMDA4MDdGNjZDRUNFOCAwMDAwMjQgKHYwMiBBbXBlcmUpPGJyPg0KWyZu
YnNwOyZuYnNwOyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogWFNEVCAweDAwMDAwODA3RjY2Q0VDMzgg
MDAwMEFDICh2MDEgQW1wZXJlIEFsdHJhJm5ic3A7Jm5ic3A7Jm5ic3A7IDAwMDAwMDAyIEFNUC4g
MDEwMDAwMTMpPGJyPg0KWyZuYnNwOyZuYnNwOyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogRkFDUCAw
eDAwMDAwODA3RjY2Q0UwMDAgMDAwMTE0ICh2MDYgQW1wZXJlIEFsdHJhJm5ic3A7Jm5ic3A7Jm5i
c3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0KWyZuYnNwOyZuYnNwOyZuYnNwOyAwLjAw
MDAwMF0gQUNQSTogRFNEVCAweDAwMDAwODA3RjhEQjAwMTggMDJDMTlFICh2MDIgQW1wZXJlIEph
ZGUmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNyk8YnI+DQpb
Jm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBCRVJUIDB4MDAwMDA4MDdGQTBERkY5
OCAwMDAwMzAgKHYwMSBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDIgQU1Q
LiAwMTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBEQkcy
IDB4MDAwMDA4MDdGQTBERkE5OCAwMDAwNUMgKHYwMCBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsm
bmJzcDsgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAu
MDAwMDAwXSBBQ1BJOiBHVERUIDB4MDAwMDA4MDdGQTBERTk5OCAwMDAxMTAgKHYwMyBBbXBlcmUg
QWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMyk8YnI+DQpbJm5i
c3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBTUENSIDB4MDAwMDA4MDdGQTBERkUxOCAw
MDAwNTAgKHYwMiBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDIgQU1QLiAw
MTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBFSU5KIDB4
MDAwMDA4MDdGQTBERjU5OCAwMDAxNTAgKHYwMSBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJz
cDsgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAw
MDAwXSBBQ1BJOiBIRVNUIDB4MDAwMDA4MDdGQTBERUIxOCAwMDAxRjQgKHYwMSBBbXBlcmUgQWx0
cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNyk8YnI+DQpbJm5ic3A7
Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBTU0RUIDB4MDAwMDA4MDdGQTBERkExOCAwMDAw
MkQgKHYwMiBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDEgSU5UTCAyMDIw
MTIxNyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBUUE0yIDB4MDAw
MDA4MDdGQTBERkQxOCAwMDAwNEMgKHYwNCBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsg
MDAwMDAwMDIgQU1QLiAwMTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAw
XSBBQ1BJOiBNQ0ZHIDB4MDAwMDA4MDdGQTBERjcxOCAwMDAwN0MgKHYwMSBBbXBlcmUgQWx0cmEm
bmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDEgQU1QLiAwMTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5i
c3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBJT1JUIDB4MDAwMDA4MDdGQTBERUYxOCAwMDAzREMg
KHYwMCBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDIgQU1QLiAwMTAwMDAx
Myk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBBUElDIDB4MDAwMDA4
MDdGNjZDRTExOCAwMDBBRjQgKHYwNSBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAw
MDAwMDIgQU1QLiAwMTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBB
Q1BJOiBQUFRUIDB4MDAwMDA4MDdGQTBEODYxOCAwMDQ1MjAgKHYwMiBBbXBlcmUgQWx0cmEmbmJz
cDsmbmJzcDsmbmJzcDsgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5ic3A7
Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBTTElUIDB4MDAwMDA4MDdGQTBERkQ5OCAwMDAwMkQgKHYw
MSBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMyk8
YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBTUkFUIDB4MDAwMDA4MDdG
QTBEQ0UxOCAwMDAzNzAgKHYwMyBBbXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAw
MDIgQU1QLiAwMTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJ
OiBQQ0NUIDB4MDAwMDA4MDdGQTBERTMxOCAwMDA1NzYgKHYwMiBBbXBlcmUgQWx0cmEmbmJzcDsm
bmJzcDsmbmJzcDsgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMyk8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5i
c3A7IDAuMDAwMDAwXSBBQ1BJOiBTVEFPIDB4MDAwMDA4MDdGNjZDRUMxMCAwMDAwMjUgKHYwMSBB
bXBlcmUgQWx0cmEmbmJzcDsmbmJzcDsmbmJzcDsgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMyk8YnI+
DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBTUENSOiBjb25zb2xlOiBwbDAx
MSxtbWlvMzIsMHgxMDAwMDI2MDAwMDAsMTE1MjAwPGJyPg0KWyZuYnNwOyZuYnNwOyZuYnNwOyAw
LjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4ODMwMDAwMC0weDg4M2Zm
ZmZmXTxicj4NClsmbmJzcDsmbmJzcDsmbmJzcDsgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUg
MCBQWE0gMCBbbWVtIDB4OTAwMDAwMDAtMHhmZmZmZmZmZl08YnI+DQpbJm5ic3A7Jm5ic3A7Jm5i
c3A7IDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDgwMDAwMDAwMDAw
LTB4ODAwN2ZmZmZmZmZdPGJyPg0KWyZuYnNwOyZuYnNwOyZuYnNwOyAwLjAwMDAwMF0gQUNQSTog
U1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4MDEwMDAwMDAwMC0weDgwN2ZmZmZmZmZmXTxicj4N
ClsmbmJzcDsmbmJzcDsmbmJzcDsgMC4wMDAwMDBdIE5VTUE6IE5PREVfREFUQSBbbWVtIDB4ODA3
OWZiZjVlMDAtMHg4MDc5ZmJmN2ZmZl08YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAw
XSBab25lIHJhbmdlczo8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSZuYnNwOyZu
YnNwOyBETUEmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgW21lbSAweDAwMDAwMDAwOTgw
MDAwMDAtMHgwMDAwMDAwMGZmZmZmZmZmXTxicj4NClsmbmJzcDsmbmJzcDsmbmJzcDsgMC4wMDAw
MDBdJm5ic3A7Jm5ic3A7IERNQTMyJm5ic3A7Jm5ic3A7Jm5ic3A7IGVtcHR5PGJyPg0KWyZuYnNw
OyZuYnNwOyZuYnNwOyAwLjAwMDAwMF0mbmJzcDsmbmJzcDsgTm9ybWFsJm5ic3A7Jm5ic3A7IFtt
ZW0gMHgwMDAwMDAwMTAwMDAwMDAwLTB4MDAwMDA4MDdmYTBkZmZmZl08YnI+DQpbJm5ic3A7Jm5i
c3A7Jm5ic3A7IDAuMDAwMDAwXSBNb3ZhYmxlIHpvbmUgc3RhcnQgZm9yIGVhY2ggbm9kZTxicj4N
ClsmbmJzcDsmbmJzcDsmbmJzcDsgMC4wMDAwMDBdIEVhcmx5IG1lbW9yeSBub2RlIHJhbmdlczxi
cj4NCuKApi48YnI+DQo8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBEZW50cnkg
Y2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAyNjIxNDQgKG9yZGVyOiA5LCAyMDk3MTUyIGJ5dGVz
LCBsaW5lYXIpPGJyPg0KWyZuYnNwOyZuYnNwOyZuYnNwOyAwLjAwMDAwMF0gSW5vZGUtY2FjaGUg
aGFzaCB0YWJsZSBlbnRyaWVzOiAxMzEwNzIgKG9yZGVyOiA4LCAxMDQ4NTc2IGJ5dGVzLCBsaW5l
YXIpPGJyPg0KWyZuYnNwOyZuYnNwOyZuYnNwOyAwLjAwMDAwMF0gbWVtIGF1dG8taW5pdDogc3Rh
Y2s6b2ZmLCBoZWFwIGFsbG9jOm9mZiwgaGVhcCBmcmVlOm9mZjxicj4NClsmbmJzcDsmbmJzcDsm
bmJzcDsgMC4wMDAwMDBdIHNvZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgwMDAwMDAwMGY0
MDAwMDAwLTB4MDAwMDAwMDBmODAwMDAwMF0gKDY0TUIpPGJyPg0KWyZuYnNwOyZuYnNwOyZuYnNw
OyAwLjAwMDAwMF0gTWVtb3J5OiAxOTI5MTUySy8yMDk3NDEySyBhdmFpbGFibGUgKDEzNTY4SyBr
ZXJuZWwgY29kZSwgMTk5NksgcndkYXRhLCAzNDc2SyByb2RhdGEsIDQxNjBLIGluaXQsIDgyMksg
YnNzLCAxNjgyNjBLIHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2ZWQpPGJyPg0KWyZuYnNwOyZuYnNw
OyZuYnNwOyAwLjAwMDAwMF0gU0xVQjogSFdhbGlnbj02NCwgT3JkZXI9MC0zLCBNaW5PYmplY3Rz
PTAsIENQVXM9MzIsIE5vZGVzPTE8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBm
dHJhY2U6IGFsbG9jYXRpbmcgNDEzMDYgZW50cmllcyBpbiAxNjIgcGFnZXM8YnI+DQrigKYuPGJy
Pg0KPGJyPg0K4oCmLjxicj4NClsmbmJzcDsmbmJzcDsgMTIuNTk5NDg0XSBsb29wOiBtb2R1bGUg
bG9hZGVkPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi42MDMxNjBdIG52bWUgbnZtZTA6IHBjaSBmdW5j
dGlvbiAwMDA1OjA0OjAwLjA8YnI+DQpbJm5ic3A7Jm5ic3A7IDEyLjYwODEyOV0gaWdiOiBJbnRl
bChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgRHJpdmVyPGJyPg0KWyZuYnNwOyZuYnNwOyAx
Mi42MTM0OTVdIGlnYjogQ29weXJpZ2h0IChjKSAyMDA3LTIwMTQgSW50ZWwgQ29ycG9yYXRpb24u
PGJyPg0KWyZuYnNwOyZuYnNwOyAxMi42MTM2MzZdIG52bWUgbnZtZTA6IG1pc3Npbmcgb3IgaW52
YWxpZCBTVUJOUU4gZmllbGQuPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi42MjU5NDFdIFVuYWJsZSB0
byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdCB2aXJ0dWFsIGFkZHJl
c3MgMDAwMDAwMDAwMDAwMDAwODxicj4NClsmbmJzcDsmbmJzcDsgMTIuNjM0NzI2XSBNZW0gYWJv
cnQgaW5mbzo8YnI+DQpbJm5ic3A7Jm5ic3A7IDEyLjYzNzUyMF0mbmJzcDsmbmJzcDsgRVNSID0g
MHg5NjAwMDA0NDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNjQwNjQ2XSZuYnNwOyZuYnNwOyBFQyA9
IDB4MjU6IERBQlQgKGN1cnJlbnQgRUwpLCBJTCA9IDMyIGJpdHM8YnI+DQpbJm5ic3A7Jm5ic3A7
IDEyLjY0NjA1NV0mbmJzcDsmbmJzcDsgU0VUID0gMCwgRm5WID0gMDxicj4NClsmbmJzcDsmbmJz
cDsgMTIuNjQ5MTUzXSZuYnNwOyZuYnNwOyBFQSA9IDAsIFMxUFRXID0gMDxicj4NClsmbmJzcDsm
bmJzcDsgMTIuNjUyMzY1XSBEYXRhIGFib3J0IGluZm86PGJyPg0KWyZuYnNwOyZuYnNwOyAxMi42
NTUzMTRdJm5ic3A7Jm5ic3A7IElTViA9IDAsIElTUyA9IDB4MDAwMDAwNDQ8YnI+DQpbJm5ic3A7
Jm5ic3A7IDEyLjY1OTIzMV0mbmJzcDsmbmJzcDsgQ00gPSAwLCBXblIgPSAxPGJyPg0KWyZuYnNw
OyZuYnNwOyAxMi42NjIyNjBdIFswMDAwMDAwMDAwMDAwMDA4XSB1c2VyIGFkZHJlc3MgYnV0IGFj
dGl2ZV9tbSBpcyBzd2FwcGVyPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi42Njg3MjRdIEludGVybmFs
IGVycm9yOiBPb3BzOiA5NjAwMDA0NCBbIzFdIFBSRUVNUFQgU01QPGJyPg0KWyZuYnNwOyZuYnNw
OyAxMi42NzQzNThdIE1vZHVsZXMgbGlua2VkIGluOjxicj4NClsmbmJzcDsmbmJzcDsgMTIuNjc3
NDU1XSBDUFU6IDAgUElEOiA3IENvbW06IGt3b3JrZXIvdTY0OjAgVGFpbnRlZDogRyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBXJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAj
MTxicj4NClsmbmJzcDsmbmJzcDsgMTIuNjg3MDgzXSBXb3JrcXVldWU6IG52bWUtcmVzZXQtd3Eg
bnZtZV9yZXNldF93b3JrPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi42OTIwNTldIHBzdGF0ZTogNjBj
MDAwODUgKG5aQ3YgZGFJZiArUEFOICtVQU8gLVRDTyBCVFlQRT0tLSk8YnI+DQpbJm5ic3A7Jm5i
c3A7IDEyLjY5ODE0OV0gcGMgOiBzdGVhbF9zdWl0YWJsZV9mYWxsYmFjaysweDEzOC8weDJmMDxi
cj4NClsmbmJzcDsmbmJzcDsgMTIuNzAzMTcwXSBsciA6IHN0ZWFsX3N1aXRhYmxlX2ZhbGxiYWNr
KzB4MWJjLzB4MmYwPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi43MDgyMDNdIHNwIDogZmZmZjgwMDAx
MTk2YjgyMDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzExNTY5XSB4Mjk6IGZmZmY4MDAwMTE5NmI4
MjAgeDI4OiAwMDAwMDAwMDAwMDAwMDAwIDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzE2OTc1XSB4
Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDExNGRiY2IwIDxicj4NClsmbmJzcDsm
bmJzcDsgMTIuNzIyMzU3XSB4MjU6IGZmZmZmZGZmZmZlMDAwMDAgeDI0OiAwMDAwMDAwMDAwMDAw
MDAxIDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzI3NzQwXSB4MjM6IDAwMDAwMDAwMDAwMDAwMDAg
eDIyOiBmZmZmZmUyMDFiZjYwMDAwIDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzMzMTIwXSB4MjE6
IGZmZmYwODA3MWZiZjY5ODAgeDIwOiAwMDAwMDAwMDAwMDAwOTAxIDxicj4NClsmbmJzcDsmbmJz
cDsgMTIuNzM4NTAyXSB4MTk6IDAwMDAwMDAwMDAwODAwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZm
IDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzQzODg0XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2
OiAwMDAwMDAwMDAwMDAwMDEyIDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzQ5MjY2XSB4MTU6IGZm
ZmYwODA3MDUwOGM2ODMgeDE0OiAwMDAwMDAwMDAwMDAwMDU4IDxicj4NClsmbmJzcDsmbmJzcDsg
MTIuNzU0NjQ4XSB4MTM6IDAwMDAwMDAwMDAwMDAwYzAgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIDxi
cj4NClsmbmJzcDsmbmJzcDsgMTIuNzYwMDMwXSB4MTE6IDAwMDAwMDAwMDAwMDA0MDAgeDEwOiAw
MDAwMDAwMDAwMDAwMDBjIDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzY1NDEyXSB4OSA6IGZmZmY4
MDAwMTAwMzlkNTggeDggOiAwMDAwMDAwMDIwMDAwMDAwIDxicj4NClsmbmJzcDsmbmJzcDsgMTIu
NzcwNzk0XSB4NyA6IDAwMDAwMDAwMDAwMDAwMTggeDYgOiBmZmZmODAwMDExNzUwODkwIDxicj4N
ClsmbmJzcDsmbmJzcDsgMTIuNzc2MTc2XSB4NSA6IGZmZmY4MDAwMTE3NTA4NzggeDQgOiAwMDAw
MDAwMDAwMDAwMDAwIDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzgxNTU4XSB4MyA6IDAwMDAwMDAw
MDAwMDAwMDAgeDIgOiAwMDAwMDAwMDAwMDAwMDAwIDxicj4NClsmbmJzcDsmbmJzcDsgMTIuNzg2
OTQwXSB4MSA6IDAwMDAwMDAwMDAwMDAyMDAgeDAgOiAwMDAwMDAwMDAwMDAwMDAwIDxicj4NClsm
bmJzcDsmbmJzcDsgMTIuNzkyMzIyXSBDYWxsIHRyYWNlOjxicj4NClsmbmJzcDsmbmJzcDsgMTIu
Nzk0ODA2XSZuYnNwOyBzdGVhbF9zdWl0YWJsZV9mYWxsYmFjaysweDEzOC8weDJmMDxicj4NClsm
bmJzcDsmbmJzcDsgMTIuNzk5NTIwXSZuYnNwOyBnZXRfcGFnZV9mcm9tX2ZyZWVsaXN0KzB4ZTMw
LzB4MTJhMDxicj4NClsmbmJzcDsmbmJzcDsgMTIuODA0MjA3XSZuYnNwOyBfX2FsbG9jX3BhZ2Vz
X25vZGVtYXNrKzB4MTQ4LzB4ZTAwPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi44MDg4MDldJm5ic3A7
IF9fZG1hX2RpcmVjdF9hbGxvY19wYWdlcysweGE0LzB4MWQwPGJyPg0KWyZuYnNwOyZuYnNwOyAx
Mi44MTM0OTZdJm5ic3A7IGRtYV9kaXJlY3RfYWxsb2MrMHgxZDgvMHgzNDA8YnI+DQpbJm5ic3A7
Jm5ic3A7IDEyLjgxNzU3MV0mbmJzcDsgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQrMHg2OC8w
eDM3MDxicj4NClsmbmJzcDsmbmJzcDsgMTIuODIyNDM5XSZuYnNwOyBkbWFfYWxsb2NfYXR0cnMr
MHhlOC8weGYwPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi44MjYyNDZdJm5ic3A7IG52bWVfcmVzZXRf
d29yaysweDEwMzAvMHgxNTIwPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi44MzA0MTddJm5ic3A7IHBy
b2Nlc3Nfb25lX3dvcmsrMHgxZGMvMHg0YmM8YnI+DQpbJm5ic3A7Jm5ic3A7IDEyLjgzNDQ5NV0m
bmJzcDsgd29ya2VyX3RocmVhZCsweDE0NC8weDQ3MDxicj4NClsmbmJzcDsmbmJzcDsgMTIuODM4
MzEzXSZuYnNwOyBrdGhyZWFkKzB4MTRjLzB4MTYwPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi44NDE2
MDRdJm5ic3A7IHJldF9mcm9tX2ZvcmsrMHgxMC8weDM4PGJyPg0KWyZuYnNwOyZuYnNwOyAxMi44
NDUyNTVdIENvZGU6IGE5NDA4MmM0IGQzN2VmNDYzIGNiM2M0MDYzIDhiM2M0MDQyIChmOTAwMDQ4
MCkgPGJyPg0KWyZuYnNwOyZuYnNwOyAxMi44NTE0NDddIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEw
ZDMwNTNiNzIgXS0tLTxicj4NClsmbmJzcDsmbmJzcDsgMTIuODU2MTE3XSBub3RlOiBrd29ya2Vy
L3U2NDowWzddIGV4aXRlZCB3aXRoIHByZWVtcHRfY291bnQ8YnI+DQo8YnI+DQrigKYuPGJyPg0K
PGJyPg0KPGJyPg0KWzFdIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9BbXBlcmVDb21wdXRp
bmcvYW1wZXJlLWx0cy1rZXJuZWwiPmh0dHBzOi8vZ2l0aHViLmNvbS9BbXBlcmVDb21wdXRpbmcv
YW1wZXJlLWx0cy1rZXJuZWw8L2E+PGJyPg0KWzJdIDxhIGhyZWY9Imh0dHBzOi8vd3d3LmlwaS53
aWtpL3BhZ2VzL2NvbS1ocGMtYWx0cmEiPmh0dHBzOi8vd3d3LmlwaS53aWtpL3BhZ2VzL2NvbS1o
cGMtYWx0cmE8L2E+PGJyPg0KPGJyPg0KPC9kaXY+DQo8L3NwYW4+PC9mb250PjwvZGl2Pg0KPGRp
diBjbGFzcz0iQm9keUZyYWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1z
aXplOjExcHQ7Ij4NCjxkaXYgY2xhc3M9IlBsYWluVGV4dCI+PGJyPg0KPGJyPg0KUmVnYXJkcyw8
YnI+DQpSYWh1bDwvZGl2Pg0KPC9zcGFuPjwvZm9udD48L2Rpdj4NCjwvYm9keT4NCjwvaHRtbD4N
Cg==

--_000_C82612B1FED541399B87FB33DD81F01Aarmcom_--

--_004_C82612B1FED541399B87FB33DD81F01Aarmcom_
Content-Type: application/octet-stream; name="xen-dom0-boot-failue.log"
Content-Description: xen-dom0-boot-failue.log
Content-Disposition: attachment; filename="xen-dom0-boot-failue.log";
	size=148664; creation-date="Wed, 13 Apr 2022 13:04:58 GMT";
	modification-date="Wed, 13 Apr 2022 13:04:58 GMT"
Content-ID: <9552750361026C499D22A189239CB6A9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

Ly0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLVwNCnwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IEJvb3QgTWFuYWdlciAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8DQpcLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLw0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERldmljZSBQYXRoIDog
ICAgICAgICAgDQogICBCb290IE1hbmFnZXIgTWVudSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBGdig1QzYwRjM2Ny1BNTA1LTQxOUEtIA0KICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgODU5RS0yQTRGRjZDQTZGRTUpL0Z2
RiANCiAgIFVFRkkgVVNCIERldmljZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIGlsZSg3QzA0QTU4My05RTNFLTRGMUMgDQogICBVRUZJIFVTQiBEZXZpY2UgMiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtQUQ2NS1FMDUyNjhEMEI0RDEpICAgIA0KICAg
VUVGSSBVU0IgRGV2aWNlIDMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICANCiAgIFVFRkkgVVNCIERldmljZSA0ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgDQogICBVRUZJIFVT
QiBEZXZpY2UgNSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIA0KICAgVUVGSSBTaGVsbCAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCiAgIFVFRkkgQURBVEFfSU0y
UDMzRjgtMTI4R0NUQjQgMkwzNTJMQTlFSExSIDEgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgDQogICBVRUZJIFVTQiBEZXZpY2UgNiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgVUVGSSBVU0IgRGV2aWNlIDcgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAN
CiAgIFVFRkkgVVNCIERldmljZSA4ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgDQogICBVRUZJIFVTQiBEZXZpY2UgOSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgVUVG
SSBVU0IgU2FuRGlzayAzLjJHZW4xICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICANCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB2ICAgICAgICAgICAgICAgICAgICAgICAgDQovLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tXA0KfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwNCnwgXnY9TW92ZSBIaWdobGlnaHQg
ICAgICAgPEVudGVyPj1TZWxlY3QgRW50cnkgICAgICBFc2M9RXhpdCAgICAgICAgICAgICAgICAg
ICB8DQpcLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLw0KICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCg0KDQoNCg0K
DQoNCg0KDQoNCg0KDQoNClBST0dSRVNTIENPREU6IFYwMzA1MDAwMCBJMA0KUFJPR1JFU1MgQ09E
RTogVjAzMDUxMDAxIEkwDQpQUk9HUkVTUyBDT0RFOiBWMDMwNTgwMDAgSTANClBST0dSRVNTIENP
REU6IFYwMzA1ODAwMSBJMA0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQpVRUZJIEludGVyYWN0aXZlIFNoZWxs
IHYyLjINCkVESyBJSQ0KVUVGSSB2Mi43MCAoRURLIElJLCAweDAwMDEwMDAwKQ0KTWFwcGluZyB0
YWJsZQ0KICAgICAgRlMwOiBBbGlhcyhzKTpIRDFhMGI6O0JMSzEwOg0KICAgICAgICAgIFBjaWVS
b290KDB4NzAwMDApL1BjaSgweDMsMHgwKS9QY2koMHgwLDB4MCkvVVNCKDB4MCwweDApL0hEKDEs
R1BULEVGNzMNCjk2MjYtMjQ0Qi00RkM1LThEQzItRDc4MEVFNzUxQTNELDB4ODAwLDB4MjAwMDAw
KQ0KICAgICAgRlMxOiBBbGlhcyhzKTpIRDJiOjtCTEsxMzoNCiAgICAgICAgICBQY2llUm9vdCgw
eDcwMDAwKS9QY2koMHg3LDB4MCkvUGNpKDB4MCwweDApL05WTWUoMHgxLDAxLTAwLTAwLTAwLTAw
LTAwDQotMDAtMDApL0hEKDEsR1BULDUxQTI3NjA5LTNFMTAtNDJEOS04NzQ3LUYwNjU2ODFFMEVC
QSwweDgwMCwweDEwMDAwMCkNCiAgICAgQkxLMDogQWxpYXMocyk6DQogICAgICAgICAgUGNpZVJv
b3QoMHg2MDAwMCkvUGNpKDB4MywweDApL1BjaSgweDAsMHgwKS9VU0IoMHg3LDB4MCkvVVNCKDB4
MCwweDApLw0KVW5pdCgweDApDQogICAgIEJMSzE6IEFsaWFzKHMpOg0KICAgICAgICAgIFBjaWVS
b290KDB4NjAwMDApL1BjaSgweDMsMHgwKS9QY2koMHgwLDB4MCkvVVNCKDB4NywweDApL1VTQigw
eDAsMHgwKS8NClVuaXQoMHgxKQ0KICAgICBCTEsyOiBBbGlhcyhzKToNCiAgICAgICAgICBQY2ll
Um9vdCgweDYwMDAwKS9QY2koMHgzLDB4MCkvUGNpKDB4MCwweDApL1VTQigweDcsMHgwKS9VU0Io
MHgwLDB4MCkvDQpVbml0KDB4MikNCiAgICAgQkxLMzogQWxpYXMocyk6DQogICAgICAgICAgUGNp
ZVJvb3QoMHg2MDAwMCkvUGNpKDB4MywweDApL1BjaSgweDAsMHgwKS9VU0IoMHg3LDB4MCkvVVNC
KDB4MCwweDApLw0KVW5pdCgweDMpDQogICAgIEJMSzQ6IEFsaWFzKHMpOg0KICAgICAgICAgIFBj
aWVSb290KDB4NjAwMDApL1BjaSgweDMsMHgwKS9QY2koMHgwLDB4MCkvVVNCKDB4NywweDApL1VT
QigweDEsMHgwKS8NClVuaXQoMHgwKQ0KICAgICBCTEs1OiBBbGlhcyhzKToNCiAgICAgICAgICBQ
Y2llUm9vdCgweDYwMDAwKS9QY2koMHgzLDB4MCkvUGNpKDB4MCwweDApL1VTQigweDcsMHgwKS9V
U0IoMHgxLDB4MCkvDQpVbml0KDB4MSkNCiAgICAgQkxLNjogQWxpYXMocyk6DQogICAgICAgICAg
UGNpZVJvb3QoMHg2MDAwMCkvUGNpKDB4MywweDApL1BjaSgweDAsMHgwKS9VU0IoMHg3LDB4MCkv
VVNCKDB4MSwweDApLw0KVW5pdCgweDIpDQogICAgIEJMSzc6IEFsaWFzKHMpOg0KICAgICAgICAg
IFBjaWVSb290KDB4NjAwMDApL1BjaSgweDMsMHgwKS9QY2koMHgwLDB4MCkvVVNCKDB4NywweDAp
L1VTQigweDEsMHgwKS8NClVuaXQoMHgzKQ0KICAgICBCTEs4OiBBbGlhcyhzKToNCiAgICAgICAg
ICBQY2llUm9vdCgweDYwMDAwKS9QY2koMHgzLDB4MCkvUGNpKDB4MCwweDApL1VTQigweDcsMHgw
KS9VU0IoMHgxLDB4MCkvDQpVbml0KDB4NCkNCiAgICAgQkxLOTogQWxpYXMocyk6DQogICAgICAg
ICAgUGNpZVJvb3QoMHg3MDAwMCkvUGNpKDB4MywweDApL1BjaSgweDAsMHgwKS9VU0IoMHgwLDB4
MCkNCiAgICBCTEsxMTogQWxpYXMocyk6DQogICAgICAgICAgUGNpZVJvb3QoMHg3MDAwMCkvUGNp
KDB4MywweDApL1BjaSgweDAsMHgwKS9VU0IoMHgwLDB4MCkvSEQoMixHUFQsNkE2MA0KNTI0RC0w
NjFELTQ1NEEtQkZEMS0zODk4OTkxMEVDQ0QsMHgyMDA4MDAsMHhFNjI0REUpDQogICAgQkxLMTI6
IEFsaWFzKHMpOg0KICAgICAgICAgIFBjaWVSb290KDB4NzAwMDApL1BjaSgweDcsMHgwKS9QY2ko
MHgwLDB4MCkvTlZNZSgweDEsMDEtMDAtMDAtMDAtMDAtMDANCi0wMC0wMCkNCiAgICBCTEsxNDog
QWxpYXMocyk6DQogICAgICAgICAgUGNpZVJvb3QoMHg3MDAwMCkvUGNpKDB4NywweDApL1BjaSgw
eDAsMHgwKS9OVk1lKDB4MSwwMS0wMC0wMC0wMC0wMC0wMA0KLTAwLTAwKS9IRCgyLEdQVCwwQTlF
NjY0Mi00QjJFLTQ3QjUtQjIzMS1EQTJEOUU3Mjk3RjIsMHgxMDA4MDAsMHgyMDAwMDApDQogICAg
QkxLMTU6IEFsaWFzKHMpOg0KICAgICAgICAgIFBjaWVSb290KDB4NzAwMDApL1BjaSgweDcsMHgw
KS9QY2koMHgwLDB4MCkvTlZNZSgweDEsMDEtMDAtMDAtMDAtMDAtMDANCi0wMC0wMCkvSEQoMyxH
UFQsNURDMTlENjQtQjY4My00ODRGLTg0MDctNDg2OUQwOUI0MzBGLDB4MzAwODAwLDB4RUI3QjAw
MCkNClByZXNzIEVTQyBpbiA1IHNlY29uZHMgdG8gc2tpcCBzdGFydHVwLm5zaCBvciBhbnkgb3Ro
ZXIga2V5IHRvIGNvbnRpbnVlLg0KU2hlbGw+IGZzMDoNCkZTMDpcPiB4ZW4uZWZpDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0K
DQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQpYZW4gNC4xNS4xIChjL3MgRnJpIFNlcCAxMCAw
OTowMzoyNCAyMDIxICswMjAwIGdpdDo4NGZhOTkwOTliLWRpcnR5KSBFRkkgbG9hZGVyDQpVc2lu
ZyBjb25maWd1cmF0aW9uIGZpbGUgJ3hlbi5jZmcnDQpJbWFnZS14ZW46IDB4MDAwMDAwMDBmZTQ3
YzAwMC0weDAwMDAwMDAwZmZiM2YyMDANClBST0dSRVNTIENPREU6IFYwMzEwMTAxOSBJMA0KIFhl
biA0LjE1LjENCihYRU4pIFhlbiB2ZXJzaW9uIDQuMTUuMSAoeGVuLTQuMTUrc3RhYmxlQVVUT0lO
Qys4NGZhOTkwOTliLXIwQGV3YW9sKSAoYWFyY2g2NC1wb2t5LWxpbnV4LWdjYyAoR0NDKSAxMS4y
LjApIGRlYnVnPW4gMjAyMS0wOS0xMA0KKFhFTikgTGF0ZXN0IENoYW5nZVNldDogRnJpIFNlcCAx
MCAwOTowMzoyNCAyMDIxICswMjAwIGdpdDo4NGZhOTkwOTliLWRpcnR5DQooWEVOKSBidWlsZC1p
ZDogNzgzNDQ4YzM4YWE2ZmY0NjVlNmI0NjMxODUzYmM3MzA3NmJjZjdlNA0KKFhFTikgUHJvY2Vz
c29yOiA0MTNmZDBjMTogIkFSTSBMaW1pdGVkIiwgdmFyaWFudDogMHgzLCBwYXJ0IDB4ZDBjLCBy
ZXYgMHgxDQooWEVOKSA2NC1iaXQgRXhlY3V0aW9uOg0KKFhFTikgICBQcm9jZXNzb3IgRmVhdHVy
ZXM6IDExMDAwMDAwMTExMTExMTIgMDAwMDAwMDAwMDAwMDAyMA0KKFhFTikgICAgIEV4Y2VwdGlv
biBMZXZlbHM6IEVMMzo2NCBFTDI6NjQgRUwxOjY0IEVMMDo2NCszMg0KKFhFTikgICAgIEV4dGVu
c2lvbnM6IEZsb2F0aW5nUG9pbnQgQWR2YW5jZWRTSU1EIEdJQ3YzLVN5c1JlZw0KKFhFTikgICBE
ZWJ1ZyBGZWF0dXJlczogMDAwMDAwMDExMDMwNTQwOCAwMDAwMDAwMDAwMDAwMDAwDQooWEVOKSAg
IEF1eGlsaWFyeSBGZWF0dXJlczogMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAwDQoo
WEVOKSAgIE1lbW9yeSBNb2RlbCBGZWF0dXJlczogMDAwMDAwMDAwMDEwMTEyNSAwMDAwMDAwMDEw
MjEyMTIyDQooWEVOKSAgIElTQSBGZWF0dXJlczogIDAwMDAxMDAwMTAyMTExMjAgMDAwMDAwMDAw
MDEwMDAwMQ0KKFhFTikgMzItYml0IEV4ZWN1dGlvbjoNCihYRU4pICAgUHJvY2Vzc29yIEZlYXR1
cmVzOiAxMDAxMDEzMToxMDAxMDAwMA0KKFhFTikgICAgIEluc3RydWN0aW9uIFNldHM6IEFBcmNo
MzIgQTMyIFRodW1iIFRodW1iLTIgSmF6ZWxsZQ0KKFhFTikgICAgIEV4dGVuc2lvbnM6IEdlbmVy
aWNUaW1lcg0KKFhFTikgICBEZWJ1ZyBGZWF0dXJlczogMDQwMTAwODgNCihYRU4pICAgQXV4aWxp
YXJ5IEZlYXR1cmVzOiAwMDAwMDAwMA0KKFhFTikgICBNZW1vcnkgTW9kZWwgRmVhdHVyZXM6IDEw
MjAxMTA1IDQwMDAwMDAwIDAxMjYwMDAwIDAyMTIyMjExDQooWEVOKSAgSVNBIEZlYXR1cmVzOiAw
MjEwMTExMCAxMzExMjExMSAyMTIzMjA0MiAwMTExMjEzMSAwMDAxMDE0MiAwMTAxMTEyMQ0KKFhF
TikgVXNpbmcgU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4yDQooWEVOKSBVc2luZyBQU0NJIHYx
LjENCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxMDAwXSBhZGRyZXNzWzB4MF0gTVBJRFJb
MHgxMDAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTgwMF0gYWRk
cmVzc1sweDBdIE1QSURSWzB4MTgwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNw
aV9pZFsweDE2MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDE2MDAwMF0gZW5hYmxlZCkNCihYRU4p
IEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxZTAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxZTAwMDBd
IGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MDgwMF0gYWRkcmVzc1sweDBd
IE1QSURSWzB4ODAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MjAw
MF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjAwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lD
QyAoYWNwaV9pZFsweDBlMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweGUwMDAwXSBlbmFibGVkKQ0K
KFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDI2MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDI2
MDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxMTAwXSBhZGRyZXNz
WzB4MF0gTVBJRFJbMHgxMTAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lk
WzB4MTkwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTkwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQ
STogR0lDQyAoYWNwaV9pZFsweDE3MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDE3MDAwMF0gZW5h
YmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxZjAwXSBhZGRyZXNzWzB4MF0gTVBJ
RFJbMHgxZjAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MDkwMF0g
YWRkcmVzc1sweDBdIE1QSURSWzB4OTAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChh
Y3BpX2lkWzB4MjEwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjEwMDAwXSBlbmFibGVkKQ0KKFhF
TikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDBmMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweGYwMDAw
XSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDI3MDBdIGFkZHJlc3NbMHgw
XSBNUElEUlsweDI3MDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgx
MDAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxMDAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBH
SUNDIChhY3BpX2lkWzB4MTgwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTgwMTAwXSBlbmFibGVk
KQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDE2MDFdIGFkZHJlc3NbMHgwXSBNUElEUlsw
eDE2MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxZTAxXSBhZGRy
ZXNzWzB4MF0gTVBJRFJbMHgxZTAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3Bp
X2lkWzB4MDgwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4ODAxMDBdIGVuYWJsZWQpDQooWEVOKSBB
Q1BJOiBHSUNDIChhY3BpX2lkWzB4MjAwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjAwMTAwXSBl
bmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDBlMDFdIGFkZHJlc3NbMHgwXSBN
UElEUlsweGUwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDI2MDFd
IGFkZHJlc3NbMHgwXSBNUElEUlsweDI2MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0Mg
KGFjcGlfaWRbMHgxMTAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxMTAxMDBdIGVuYWJsZWQpDQoo
WEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTkwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTkw
MTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDE3MDFdIGFkZHJlc3Nb
MHgwXSBNUElEUlsweDE3MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRb
MHgxZjAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxZjAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJ
OiBHSUNDIChhY3BpX2lkWzB4MDkwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4OTAxMDBdIGVuYWJs
ZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MjEwMV0gYWRkcmVzc1sweDBdIE1QSURS
WzB4MjEwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDBmMDFdIGFk
ZHJlc3NbMHgwXSBNUElEUlsweGYwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNw
aV9pZFsweDI3MDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDI3MDEwMF0gZW5hYmxlZCkNCihYRU4p
IDMyIENQVXMgZW5hYmxlZCwgMzIgQ1BVcyB0b3RhbA0KKFhFTikgU01QOiBBbGxvd2luZyAzMiBD
UFVzDQooWEVOKSBHZW5lcmljIFRpbWVyIElSUTogcGh5cz0zMCBoeXA9MjYgdmlydD0yNyBGcmVx
OiAyNTAwMCBLSHoNCihYRU4pIEdJQ3YzIGluaXRpYWxpemF0aW9uOg0KKFhFTikgICAgICAgZ2lj
X2Rpc3RfYWRkcj0weDAwMTAwMTAwMDAwMDAwDQooWEVOKSAgICAgICBnaWNfbWFpbnRlbmFuY2Vf
aXJxPTI1DQooWEVOKSAgICAgICBnaWNfcmRpc3Rfc3RyaWRlPTANCihYRU4pICAgICAgIGdpY19y
ZGlzdF9yZWdpb25zPTENCihYRU4pICAgICAgIHJlZGlzdHJpYnV0b3IgcmVnaW9uczoNCihYRU4p
ICAgICAgICAgLSByZWdpb24gMDogMHgwMDEwMDEwMDE0MDAwMCAtIDB4MDAxMDAxMDExNDAwMDAN
CihYRU4pIEdJQ3YzOiB1c2luZyBhdCBtb3N0IDU3MzQ0IExQSXMgb24gdGhlIGhvc3QuDQooWEVO
KSBHSUN2MzogNzA0IGxpbmVzLCAoSUlEIDAyMDE3NDNiKS4NCihYRU4pIEdJQ3YzOiBGb3VuZCBJ
VFMgQDB4MTAwMTAwMDQwMDAwDQooWEVOKSBHSUN2MzogRm91bmQgSVRTIEAweDEwMDEwMDA2MDAw
MA0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBAMHgxMDAxMDAwODAwMDANCihYRU4pIEdJQ3YzOiBG
b3VuZCBJVFMgQDB4MTAwMTAwMGEwMDAwDQooWEVOKSBHSUN2MzogRm91bmQgSVRTIEAweDEwMDEw
MDBjMDAwMA0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBAMHgxMDAxMDAwZTAwMDANCihYRU4pIEdJ
Q3YzOiBGb3VuZCBJVFMgQDB4MTAwMTAwMTAwMDAwDQooWEVOKSBHSUN2MzogRm91bmQgSVRTIEAw
eDEwMDEwMDEyMDAwMA0KKFhFTikgR0lDdjM6IENQVTA6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4g
cmVnaW9uIDAgQDAwMDAwMDAwNDA0MzQwMDANCihYRU4pIFhTTSBGcmFtZXdvcmsgdjEuMC4wIGlu
aXRpYWxpemVkDQooWEVOKSBJbml0aWFsaXNpbmcgWFNNIFNJTE8gbW9kZQ0KKFhFTikgVXNpbmcg
c2NoZWR1bGVyOiBTTVAgQ3JlZGl0IFNjaGVkdWxlciByZXYyIChjcmVkaXQyKQ0KKFhFTikgSW5p
dGlhbGl6aW5nIENyZWRpdDIgc2NoZWR1bGVyDQooWEVOKSAgbG9hZF9wcmVjaXNpb25fc2hpZnQ6
IDE4DQooWEVOKSAgbG9hZF93aW5kb3dfc2hpZnQ6IDMwDQooWEVOKSAgdW5kZXJsb2FkX2JhbGFu
Y2VfdG9sZXJhbmNlOiAwDQooWEVOKSAgb3ZlcmxvYWRfYmFsYW5jZV90b2xlcmFuY2U6IC0zDQoo
WEVOKSAgcnVucXVldWVzIGFycmFuZ2VtZW50OiBzb2NrZXQNCihYRU4pICBjYXAgZW5mb3JjZW1l
bnQgZ3JhbnVsYXJpdHk6IDEwbXMNCihYRU4pIGxvYWQgdHJhY2tpbmcgd2luZG93IGxlbmd0aCAx
MDczNzQxODI0IG5zDQooWEVOKSBEZWZhdWx0aW5nIHRvIGFsdGVybmF0aXZlIGtleSBoYW5kbGlu
Zzsgc2VuZCAnQScgdG8gc3dpdGNoIHRvIG5vcm1hbCBtb2RlLg0KKFhFTikgQWxsb2NhdGVkIGNv
bnNvbGUgcmluZyBvZiAyNTYgS2lCLg0KKFhFTikgQ1BVMDogR3Vlc3QgYXRvbWljcyB3aWxsIHRy
eSAxNyB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBCcmluZ2luZyB1cCBD
UFUxDQooWEVOKSBHSUN2MzogQ1BVMTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBA
MDAwMDAwMDA0MDYzNDAwMA0KKFhFTikgQ1BVMTogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0
aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMSBib290ZWQuDQooWEVO
KSBCcmluZ2luZyB1cCBDUFUyDQooWEVOKSBHSUN2MzogQ1BVMjogRm91bmQgcmVkaXN0cmlidXRv
ciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDViNDAwMA0KKFhFTikgQ1BVMjogR3Vlc3QgYXRvbWlj
cyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg
MiBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFUzDQooWEVOKSBHSUN2MzogQ1BVMzogRm91
bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDdiNDAwMA0KKFhFTikgQ1BV
MzogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9t
YWluDQooWEVOKSBDUFUgMyBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFU0DQooWEVOKSBH
SUN2MzogQ1BVNDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDIz
NDAwMA0KKFhFTikgQ1BVNDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUg
cGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgNCBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1
cCBDUFU1DQooWEVOKSBHSUN2MzogQ1BVNTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24g
MCBAMDAwMDAwMDA0MDgzNDAwMA0KKFhFTikgQ1BVNTogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx
OCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgNSBib290ZWQuDQoo
WEVOKSBCcmluZ2luZyB1cCBDUFU2DQooWEVOKSBHSUN2MzogQ1BVNjogRm91bmQgcmVkaXN0cmli
dXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDNiNDAwMA0KKFhFTikgQ1BVNjogR3Vlc3QgYXRv
bWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBD
UFUgNiBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFU3DQooWEVOKSBHSUN2MzogQ1BVNzog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDliNDAwMA0KKFhFTikg
Q1BVNzogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUg
ZG9tYWluDQooWEVOKSBDUFUgNyBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFU4DQooWEVO
KSBHSUN2MzogQ1BVODogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0
MDQ3NDAwMA0KKFhFTikgQ1BVODogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZv
cmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgOCBib290ZWQuDQooWEVOKSBCcmluZ2lu
ZyB1cCBDUFU5DQooWEVOKSBHSUN2MzogQ1BVOTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdp
b24gMCBAMDAwMDAwMDA0MDY3NDAwMA0KKFhFTikgQ1BVOTogR3Vlc3QgYXRvbWljcyB3aWxsIHRy
eSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgOSBib290ZWQu
DQooWEVOKSBCcmluZ2luZyB1cCBDUFUxMA0KKFhFTikgR0lDdjM6IENQVTEwOiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNWY0MDAwDQooWEVOKSBDUFUxMDogR3Vl
c3QgYXRvbWljcyB3aWxsIHRyeSAxNyB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQoo
WEVOKSBDUFUgMTAgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTENCihYRU4pIEdJQ3Yz
OiBDUFUxMTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDdmNDAw
MA0KKFhFTikgQ1BVMTE6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBh
dXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDExIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVw
IENQVTEyDQooWEVOKSBHSUN2MzogQ1BVMTI6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9u
IDAgQDAwMDAwMDAwNDAyNzQwMDANCihYRU4pIENQVTEyOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxMiBib290ZWQu
DQooWEVOKSBCcmluZ2luZyB1cCBDUFUxMw0KKFhFTikgR0lDdjM6IENQVTEzOiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwODc0MDAwDQooWEVOKSBDUFUxMzogR3Vl
c3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQoo
WEVOKSBDUFUgMTMgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTQNCihYRU4pIEdJQ3Yz
OiBDUFUxNDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDNmNDAw
MA0KKFhFTikgQ1BVMTQ6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBh
dXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDE0IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVw
IENQVTE1DQooWEVOKSBHSUN2MzogQ1BVMTU6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9u
IDAgQDAwMDAwMDAwNDA5ZjQwMDANCihYRU4pIENQVTE1OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxNSBib290ZWQu
DQooWEVOKSBCcmluZ2luZyB1cCBDUFUxNg0KKFhFTikgR0lDdjM6IENQVTE2OiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNDU0MDAwDQooWEVOKSBDUFUxNjogR3Vl
c3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQoo
WEVOKSBDUFUgMTYgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTcNCihYRU4pIEdJQ3Yz
OiBDUFUxNzogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDY1NDAw
MA0KKFhFTikgQ1BVMTc6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBh
dXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDE3IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVw
IENQVTE4DQooWEVOKSBHSUN2MzogQ1BVMTg6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9u
IDAgQDAwMDAwMDAwNDA1ZDQwMDANCihYRU4pIENQVTE4OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxOCBib290ZWQu
DQooWEVOKSBCcmluZ2luZyB1cCBDUFUxOQ0KKFhFTikgR0lDdjM6IENQVTE5OiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwN2Q0MDAwDQooWEVOKSBDUFUxOTogR3Vl
c3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQoo
WEVOKSBDUFUgMTkgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjANCihYRU4pIEdJQ3Yz
OiBDUFUyMDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDI1NDAw
MA0KKFhFTikgQ1BVMjA6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBh
dXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDIwIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVw
IENQVTIxDQooWEVOKSBHSUN2MzogQ1BVMjE6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9u
IDAgQDAwMDAwMDAwNDA4NTQwMDANCihYRU4pIENQVTIxOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyMSBib290ZWQu
DQooWEVOKSBCcmluZ2luZyB1cCBDUFUyMg0KKFhFTikgR0lDdjM6IENQVTIyOiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwM2Q0MDAwDQooWEVOKSBDUFUyMjogR3Vl
c3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQoo
WEVOKSBDUFUgMjIgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjMNCihYRU4pIEdJQ3Yz
OiBDUFUyMzogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDlkNDAw
MA0KKFhFTikgQ1BVMjM6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTcgdGltZXMgYmVmb3JlIHBh
dXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDIzIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVw
IENQVTI0DQooWEVOKSBHSUN2MzogQ1BVMjQ6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9u
IDAgQDAwMDAwMDAwNDA0OTQwMDANCihYRU4pIENQVTI0OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyNCBib290ZWQu
DQooWEVOKSBCcmluZ2luZyB1cCBDUFUyNQ0KKFhFTikgR0lDdjM6IENQVTI1OiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjk0MDAwDQooWEVOKSBDUFUyNTogR3Vl
c3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQoo
WEVOKSBDUFUgMjUgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjYNCihYRU4pIEdJQ3Yz
OiBDUFUyNjogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDYxNDAw
MA0KKFhFTikgQ1BVMjY6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBh
dXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDI2IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVw
IENQVTI3DQooWEVOKSBHSUN2MzogQ1BVMjc6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9u
IDAgQDAwMDAwMDAwNDA4MTQwMDANCihYRU4pIENQVTI3OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyNyBib290ZWQu
DQooWEVOKSBCcmluZ2luZyB1cCBDUFUyOA0KKFhFTikgR0lDdjM6IENQVTI4OiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwMjk0MDAwDQooWEVOKSBDUFUyODogR3Vl
c3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQoo
WEVOKSBDUFUgMjggYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjkNCihYRU4pIEdJQ3Yz
OiBDUFUyOTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDg5NDAw
MA0KKFhFTikgQ1BVMjk6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBh
dXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDI5IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVw
IENQVTMwDQooWEVOKSBHSUN2MzogQ1BVMzA6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9u
IDAgQDAwMDAwMDAwNDA0MTQwMDANCihYRU4pIENQVTMwOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAzMCBib290ZWQu
DQooWEVOKSBCcmluZ2luZyB1cCBDUFUzMQ0KKFhFTikgR0lDdjM6IENQVTMxOiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwYTE0MDAwDQooWEVOKSBDUFUzMTogR3Vl
c3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQoo
WEVOKSBCcm91Z2h0IHVwIDMyIENQVXMNCihYRU4pIENQVSAzMSBib290ZWQuDQooWEVOKSBJL08g
dmlydHVhbGlzYXRpb24gZGlzYWJsZWQNCihYRU4pIFAyTTogNDgtYml0IElQQSB3aXRoIDQ4LWJp
dCBQQSBhbmQgMTYtYml0IFZNSUQNCihYRU4pIFAyTTogNCBsZXZlbHMgd2l0aCBvcmRlci0wIHJv
b3QsIFZUQ1IgMHg4MDBkMzU5MA0KKFhFTikgU2NoZWR1bGluZyBncmFudWxhcml0eTogY3B1LCAx
IENQVSBwZXIgc2NoZWQtcmVzb3VyY2UNCihYRU4pIEFkZGluZyBjcHUgMCB0byBydW5xdWV1ZSAw
DQooWEVOKSAgRmlyc3QgY3B1IG9uIHJ1bnF1ZXVlLCBhY3RpdmF0aW5nDQooWEVOKSBBZGRpbmcg
Y3B1IDEgdG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSAyIHRvIHJ1bnF1ZXVlIDANCihY
RU4pIEFkZGluZyBjcHUgMyB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDQgdG8gcnVu
cXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSA1IHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBj
cHUgNiB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDcgdG8gcnVucXVldWUgMA0KKFhF
TikgQWRkaW5nIGNwdSA4IHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgOSB0byBydW5x
dWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDEwIHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBj
cHUgMTEgdG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSAxMiB0byBydW5xdWV1ZSAwDQoo
WEVOKSBBZGRpbmcgY3B1IDEzIHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMTQgdG8g
cnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSAxNSB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRp
bmcgY3B1IDE2IHRvIHJ1bnF1ZXVlIDENCihYRU4pICBGaXJzdCBjcHUgb24gcnVucXVldWUsIGFj
dGl2YXRpbmcNCihYRU4pIEFkZGluZyBjcHUgMTcgdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5n
IGNwdSAxOCB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDE5IHRvIHJ1bnF1ZXVlIDEN
CihYRU4pIEFkZGluZyBjcHUgMjAgdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyMSB0
byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDIyIHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFk
ZGluZyBjcHUgMjMgdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyNCB0byBydW5xdWV1
ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDI1IHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUg
MjYgdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyNyB0byBydW5xdWV1ZSAxDQooWEVO
KSBBZGRpbmcgY3B1IDI4IHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjkgdG8gcnVu
cXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAzMCB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcg
Y3B1IDMxIHRvIHJ1bnF1ZXVlIDENCihYRU4pIGFsdGVybmF0aXZlczogUGF0Y2hpbmcgd2l0aCBh
bHQgdGFibGUgMDAwMDAwMDAwMDJjZDBiMCAtPiAwMDAwMDAwMDAwMmNkOWUwDQooWEVOKSAqKiog
TE9BRElORyBET01BSU4gMCAqKioNCihYRU4pIExvYWRpbmcgZDAga2VybmVsIGZyb20gYm9vdCBt
b2R1bGUgQCAwMDAwMDAwMGZlNDdjMDAwDQooWEVOKSBBbGxvY2F0aW5nIDE6MSBtYXBwaW5ncyB0
b3RhbGxpbmcgMjA0OE1CIGZvciBkb20wOg0KKFhFTikgQkFOS1swXSAweDAwMDAwMDk4MDAwMDAw
LTB4MDAwMDAwZjgwMDAwMDAgKDE1MzZNQikNCihYRU4pIEJBTktbMV0gMHgwMDA4MDc4MDAwMDAw
MC0weDAwMDgwN2EwMDAwMDAwICg1MTJNQikNCihYRU4pIEdyYW50IHRhYmxlIHJhbmdlOiAweDAw
MDgwN2Y2NmNlMDAwLTB4MDAwODA3ZjY3MGUwMDANCihYRU4pIEFsbG9jYXRpbmcgUFBJIDE2IGZv
ciBldmVudCBjaGFubmVsIGludGVycnVwdA0KKFhFTikgTG9hZGluZyB6SW1hZ2UgZnJvbSAwMDAw
MDAwMGZlNDdjMDAwIHRvIDAwMDAwMDAwOTgwMDAwMDAtMDAwMDAwMDA5OTZjMzIwMA0KKFhFTikg
TG9hZGluZyBkMCBEVEIgdG8gMHgwMDAwMDAwMGEwMDAwMDAwLTB4MDAwMDAwMDBhMDAwMDI4Mw0K
KFhFTikgSW5pdGlhbCBsb3cgbWVtb3J5IHZpcnEgdGhyZXNob2xkIHNldCBhdCAweDQwMDAgcGFn
ZXMuDQooWEVOKSBTdGQuIExvZ2xldmVsOiBBbGwNCihYRU4pIEd1ZXN0IExvZ2xldmVsOiBFcnJv
cnMNCihYRU4pICoqKiBTZXJpYWwgaW5wdXQgdG8gRE9NMCAodHlwZSAnQ1RSTC1hJyB0aHJlZSB0
aW1lcyB0byBzd2l0Y2ggaW5wdXQpDQooWEVOKSBGcmVlZCAzNjBrQiBpbml0IG1lbW9yeS4NCihY
RU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRv
IElDQUNUSVZFUjQNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAw
MDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjgNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQg
d29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjEyDQooWEVOKSBkMHYwOiB2
R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIx
Ng0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZm
ZmYgdG8gSUNBQ1RJVkVSMjANCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0
ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjI0DQooWEVOKSBkMHYwOiB2R0lDRDogdW5o
YW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIyOA0KKFhFTikg
ZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNB
Q1RJVkVSMzINCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAw
MGZmZmZmZmZmIHRvIElDQUNUSVZFUjM2DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdv
cmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0MA0KKFhFTikgZDB2MDogdkdJ
Q0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNDQN
CihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZm
IHRvIElDQUNUSVZFUjQ4DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUg
MHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI1Mg0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFu
ZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNTYNCihYRU4pIGQw
djA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNU
SVZFUjYwDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBm
ZmZmZmZmZiB0byBJQ0FDVElWRVI2NA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3Jk
IHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNjgNCihYRU4pIGQwdjA6IHZHSUNE
OiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjcyDQoo
WEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0
byBJQ0FDVElWRVI3Ng0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4
MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSODANCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRs
ZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjg0DQooWEVOKSBkMHYw
OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElD
QUNUSVZFUjANClsgICAgMC4wMDAwMDBdIEJvb3RpbmcgTGludXggb24gcGh5c2ljYWwgQ1BVIDB4
MDAwMDAwMDAwMCBbMHg0MTNmZDBjMV0NClsgICAgMC4wMDAwMDBdIExpbnV4IHZlcnNpb24gNS4x
MC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkIChvZS11c2VyQG9lLWhvc3QpIChhYXJjaDY0LXBva3kt
bGludXgtZ2NjIChHQ0MpIDExLjIuMCwgR05VIGxkIChHTlUgQmludXRpbHMpIDIuMzcuMjAyMTA3
MjEpICMxIFNNUCBQUkVFTVBUIFNhdCBTZXAgMTggMDY6MDE6NTkgVVRDIDIwMjENClsgICAgMC4w
MDAwMDBdIFhlbiBYRU5fVkVSU0lPTi5YRU5fU1VCVkVSU0lPTiBzdXBwb3J0IGZvdW5kDQpbICAg
IDAuMDAwMDAwXSBlZmk6IEVGSSB2Mi41MCBieSBYZW4NClsgICAgMC4wMDAwMDBdIGVmaTogQUNQ
SSAyLjA9MHg4MDdmNjZjZWNlOCANClsgICAgMC4wMDAwMDBdIEFDUEk6IEVhcmx5IHRhYmxlIGNo
ZWNrc3VtIHZlcmlmaWNhdGlvbiBkaXNhYmxlZA0KWyAgICAwLjAwMDAwMF0gQUNQSTogUlNEUCAw
eDAwMDAwODA3RjY2Q0VDRTggMDAwMDI0ICh2MDIgQW1wZXJlKQ0KWyAgICAwLjAwMDAwMF0gQUNQ
STogWFNEVCAweDAwMDAwODA3RjY2Q0VDMzggMDAwMEFDICh2MDEgQW1wZXJlIEFsdHJhICAgIDAw
MDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBGQUNQIDB4MDAwMDA4
MDdGNjZDRTAwMCAwMDAxMTQgKHYwNiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAw
MDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IERTRFQgMHgwMDAwMDgwN0Y4REIwMDE4IDAyQzE5
RSAodjAyIEFtcGVyZSBKYWRlICAgICAwMDAwMDAwMSBJTlRMIDIwMjAxMjE3KQ0KWyAgICAwLjAw
MDAwMF0gQUNQSTogQkVSVCAweDAwMDAwODA3RkEwREZGOTggMDAwMDMwICh2MDEgQW1wZXJlIEFs
dHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBEQkcy
IDB4MDAwMDA4MDdGQTBERkE5OCAwMDAwNUMgKHYwMCBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIg
QU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEdURFQgMHgwMDAwMDgwN0ZBMERF
OTk4IDAwMDExMCAodjAzIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0K
WyAgICAwLjAwMDAwMF0gQUNQSTogU1BDUiAweDAwMDAwODA3RkEwREZFMTggMDAwMDUwICh2MDIg
QW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBB
Q1BJOiBFSU5KIDB4MDAwMDA4MDdGQTBERjU5OCAwMDAxNTAgKHYwMSBBbXBlcmUgQWx0cmEgICAg
MDAwMDAwMDEgSU5UTCAyMDIwMTIxNykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEhFU1QgMHgwMDAw
MDgwN0ZBMERFQjE4IDAwMDFGNCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIw
MjAxMjE3KQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1NEVCAweDAwMDAwODA3RkEwREZBMTggMDAw
MDJEICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBUUE0yIDB4MDAwMDA4MDdGQTBERkQxOCAwMDAwNEMgKHYwNCBBbXBlcmUg
QWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IE1D
RkcgMHgwMDAwMDgwN0ZBMERGNzE4IDAwMDA3QyAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAw
MSBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogSU9SVCAweDAwMDAwODA3RkEw
REVGMTggMDAwM0RDICh2MDAgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMp
DQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBBUElDIDB4MDAwMDA4MDdGNjZDRTExOCAwMDBBRjQgKHYw
NSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBd
IEFDUEk6IFBQVFQgMHgwMDAwMDgwN0ZBMEQ4NjE4IDAwNDUyMCAodjAyIEFtcGVyZSBBbHRyYSAg
ICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU0xJVCAweDAw
MDAwODA3RkEwREZEOTggMDAwMDJEICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4g
MDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUIDB4MDAwMDA4MDdGQTBEQ0UxOCAw
MDAzNzAgKHYwMyBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAg
MC4wMDAwMDBdIEFDUEk6IFBDQ1QgMHgwMDAwMDgwN0ZBMERFMzE4IDAwMDU3NiAodjAyIEFtcGVy
ZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTog
U1RBTyAweDAwMDAwODA3RjY2Q0VDMTAgMDAwMDI1ICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAw
MDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUENSOiBjb25zb2xlOiBw
bDAxMSxtbWlvMzIsMHgxMDAwMDI2MDAwMDAsMTE1MjAwDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBT
UkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDg4MzAwMDAwLTB4ODgzZmZmZmZdDQpbICAgIDAuMDAw
MDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDkwMDAwMDAwLTB4ZmZmZmZmZmZd
DQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDgwMDAwMDAw
MDAwLTB4ODAwN2ZmZmZmZmZdDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhN
IDAgW21lbSAweDgwMTAwMDAwMDAwLTB4ODA3ZmZmZmZmZmZdDQpbICAgIDAuMDAwMDAwXSBOVU1B
OiBOT0RFX0RBVEEgW21lbSAweDgwNzlmYmY1ZTAwLTB4ODA3OWZiZjdmZmZdDQpbICAgIDAuMDAw
MDAwXSBab25lIHJhbmdlczoNClsgICAgMC4wMDAwMDBdICAgRE1BICAgICAgW21lbSAweDAwMDAw
MDAwOTgwMDAwMDAtMHgwMDAwMDAwMGZmZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBETUEzMiAg
ICBlbXB0eQ0KWyAgICAwLjAwMDAwMF0gICBOb3JtYWwgICBbbWVtIDB4MDAwMDAwMDEwMDAwMDAw
MC0weDAwMDAwODA3ZmEwZGZmZmZdDQpbICAgIDAuMDAwMDAwXSBNb3ZhYmxlIHpvbmUgc3RhcnQg
Zm9yIGVhY2ggbm9kZQ0KWyAgICAwLjAwMDAwMF0gRWFybHkgbWVtb3J5IG5vZGUgcmFuZ2VzDQpb
ICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAwMDA5ODAwMDAwMC0weDAwMDAw
MDAwZjdmZmZmZmZdDQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDc4
MDAwMDAwMC0weDAwMDAwODA3OWZmZmZmZmZdDQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBb
bWVtIDB4MDAwMDA4MDdmNjZjZTAwMC0weDAwMDAwODA3ZjY2Y2VmZmZdDQpbICAgIDAuMDAwMDAw
XSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOGRiMDAwMC0weDAwMDAwODA3ZjhkZGZmZmZd
DQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTBkMDAwMC0weDAw
MDAwODA3ZmEwZGZmZmZdDQpbICAgIDAuMDAwMDAwXSBJbml0bWVtIHNldHVwIG5vZGUgMCBbbWVt
IDB4MDAwMDAwMDA5ODAwMDAwMC0weDAwMDAwODA3ZmEwZGZmZmZdDQpbICAgIDAuMDAwMDAwXSBw
c2NpOiBwcm9iaW5nIGZvciBjb25kdWl0IG1ldGhvZCBmcm9tIEFDUEkuDQpbICAgIDAuMDAwMDAw
XSBwc2NpOiBQU0NJdjEuMSBkZXRlY3RlZCBpbiBmaXJtd2FyZS4NClsgICAgMC4wMDAwMDBdIHBz
Y2k6IFVzaW5nIHN0YW5kYXJkIFBTQ0kgdjAuMiBmdW5jdGlvbiBJRHMNClsgICAgMC4wMDAwMDBd
IHBzY2k6IFRydXN0ZWQgT1MgbWlncmF0aW9uIG5vdCByZXF1aXJlZA0KWyAgICAwLjAwMDAwMF0g
cHNjaTogU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4xDQpbICAgIDAuMDAwMDAwXSBwZXJjcHU6
IEVtYmVkZGVkIDMxIHBhZ2VzL2NwdSBzODkyNDAgcjgxOTIgZDI5NTQ0IHUxMjY5NzYNClsgICAg
MC4wMDAwMDBdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUwDQpbICAgIDAuMDAwMDAwXSBD
UFUgZmVhdHVyZXM6IGRldGVjdGVkOiBHSUMgc3lzdGVtIHJlZ2lzdGVyIENQVSBpbnRlcmZhY2UN
ClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEhhcmR3YXJlIGRpcnR5IGJp
dCBtYW5hZ2VtZW50DQpbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBTcGVj
dHJlLXY0DQpbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBBUk0gZXJyYXR1
bSAxNDE4MDQwDQpbICAgIDAuMDAwMDAwXSBCdWlsdCAxIHpvbmVsaXN0cywgbW9iaWxpdHkgZ3Jv
dXBpbmcgb24uICBUb3RhbCBwYWdlczogNTE2MTU5DQpbICAgIDAuMDAwMDAwXSBQb2xpY3kgem9u
ZTogTm9ybWFsDQpbICAgIDAuMDAwMDAwXSBLZXJuZWwgY29tbWFuZCBsaW5lOiBub21zaSBjb25z
b2xlPWh2YzAgZWFybHljb249eGVuIHJvb3R3YWl0IHJvb3Q9UEFSVFVVSUQ9NmE2MDUyNGQtMDYx
ZC00NTRhLWJmZDEtMzg5ODk5MTBlY2NkDQpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZf
bGVuIGluZGl2aWR1YWwgbWF4IGNwdSBjb250cmlidXRpb246IDQwOTYgYnl0ZXMNClsgICAgMC4w
MDAwMDBdIHByaW50azogbG9nX2J1Zl9sZW4gdG90YWwgY3B1X2V4dHJhIGNvbnRyaWJ1dGlvbnM6
IDEyNjk3NiBieXRlcw0KWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbiBtaW4gc2l6
ZTogMTMxMDcyIGJ5dGVzDQpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVuOiAyNjIx
NDQgYnl0ZXMNClsgICAgMC4wMDAwMDBdIHByaW50azogZWFybHkgbG9nIGJ1ZiBmcmVlOiAxMjYw
MDAoOTYlKQ0KWyAgICAwLjAwMDAwMF0gRGVudHJ5IGNhY2hlIGhhc2ggdGFibGUgZW50cmllczog
MjYyMTQ0IChvcmRlcjogOSwgMjA5NzE1MiBieXRlcywgbGluZWFyKQ0KWyAgICAwLjAwMDAwMF0g
SW5vZGUtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAxMzEwNzIgKG9yZGVyOiA4LCAxMDQ4NTc2
IGJ5dGVzLCBsaW5lYXIpDQpbICAgIDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBzdGFjazpvZmYs
IGhlYXAgYWxsb2M6b2ZmLCBoZWFwIGZyZWU6b2ZmDQpbICAgIDAuMDAwMDAwXSBzb2Z0d2FyZSBJ
TyBUTEI6IG1hcHBlZCBbbWVtIDB4MDAwMDAwMDBmNDAwMDAwMC0weDAwMDAwMDAwZjgwMDAwMDBd
ICg2NE1CKQ0KWyAgICAwLjAwMDAwMF0gTWVtb3J5OiAxOTI5MTUySy8yMDk3NDEySyBhdmFpbGFi
bGUgKDEzNTY4SyBrZXJuZWwgY29kZSwgMTk5NksgcndkYXRhLCAzNDc2SyByb2RhdGEsIDQxNjBL
IGluaXQsIDgyMksgYnNzLCAxNjgyNjBLIHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2ZWQpDQpbICAg
IDAuMDAwMDAwXSBTTFVCOiBIV2FsaWduPTY0LCBPcmRlcj0wLTMsIE1pbk9iamVjdHM9MCwgQ1BV
cz0zMiwgTm9kZXM9MQ0KWyAgICAwLjAwMDAwMF0gZnRyYWNlOiBhbGxvY2F0aW5nIDQxMzA2IGVu
dHJpZXMgaW4gMTYyIHBhZ2VzDQpbICAgIDAuMDAwMDAwXSBmdHJhY2U6IGFsbG9jYXRlZCAxNjIg
cGFnZXMgd2l0aCAzIGdyb3Vwcw0KWyAgICAwLjAwMDAwMF0gcmN1OiBQcmVlbXB0aWJsZSBoaWVy
YXJjaGljYWwgUkNVIGltcGxlbWVudGF0aW9uLg0KWyAgICAwLjAwMDAwMF0gcmN1OiAJUkNVIGV2
ZW50IHRyYWNpbmcgaXMgZW5hYmxlZC4NClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSByZXN0cmlj
dGluZyBDUFVzIGZyb20gTlJfQ1BVUz0yNTYgdG8gbnJfY3B1X2lkcz0zMi4NClsgICAgMC4wMDAw
MDBdIAlUcmFtcG9saW5lIHZhcmlhbnQgb2YgVGFza3MgUkNVIGVuYWJsZWQuDQpbICAgIDAuMDAw
MDAwXSAJUnVkZSB2YXJpYW50IG9mIFRhc2tzIFJDVSBlbmFibGVkLg0KWyAgICAwLjAwMDAwMF0g
CVRyYWNpbmcgdmFyaWFudCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4NClsgICAgMC4wMDAwMDBdIHJj
dTogUkNVIGNhbGN1bGF0ZWQgdmFsdWUgb2Ygc2NoZWR1bGVyLWVubGlzdG1lbnQgZGVsYXkgaXMg
MjUgamlmZmllcy4NClsgICAgMC4wMDAwMDBdIHJjdTogQWRqdXN0aW5nIGdlb21ldHJ5IGZvciBy
Y3VfZmFub3V0X2xlYWY9MTYsIG5yX2NwdV9pZHM9MzINClsgICAgMC4wMDAwMDBdIE5SX0lSUVM6
IDY0LCBucl9pcnFzOiA2NCwgcHJlYWxsb2NhdGVkIGlycXM6IDANClsgICAgMC4wMDAwMDBdIEdJ
Q3YzOiA2NzIgU1BJcyBpbXBsZW1lbnRlZA0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IDAgRXh0ZW5k
ZWQgU1BJcyBpbXBsZW1lbnRlZA0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IERpc3RyaWJ1dG9yIGhh
cyBubyBSYW5nZSBTZWxlY3RvciBzdXBwb3J0DQpbICAgIDAuMDAwMDAwXSBHSUN2MzogMTYgUFBJ
cyBpbXBsZW1lbnRlZA0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IENQVTA6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMCByZWdpb24gMDoweDAwMDAxMDAxMDAxNDAwMDANClsgICAgMC4wMDAwMDBdIFNSQVQ6
IFBYTSAwIC0+IElUUyAwIC0+IE5vZGUgMA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4g
SVRTIDEgLT4gTm9kZSAwDQpbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMiAtPiBO
b2RlIDANClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyAzIC0+IE5vZGUgMA0KWyAg
ICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDQgLT4gTm9kZSAwDQpbICAgIDAuMDAwMDAw
XSBTUkFUOiBQWE0gMCAtPiBJVFMgNSAtPiBOb2RlIDANClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBY
TSAwIC0+IElUUyA2IC0+IE5vZGUgMA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRT
IDcgLT4gTm9kZSAwDQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDA0MDAwMC0weDEw
MDEwMDA1ZmZmZl0NClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwNDAwMDA6IERldmlj
ZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRzIDIwLT4xOQ0KWyAgICAwLjAwMDAwMF0gSVRT
QDB4MDAwMDEwMDEwMDA0MDAwMDogYWxsb2NhdGVkIDUyNDI4OCBEZXZpY2VzIEA4MDc4MDgwMDAw
MCAoZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAw
MDEwMDEwMDA0MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODA3
ODAyMjAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElU
UyBbbWVtIDB4MTAwMTAwMDYwMDAwLTB4MTAwMTAwMDdmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRT
QDB4MDAwMDEwMDEwMDA2MDAwMDogRGV2aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMg
MjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDYwMDAwOiBhbGxvY2F0ZWQg
NTI0Mjg4IERldmljZXMgQDgwNzgwYzAwMDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEp
DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDYwMDAwOiBhbGxvY2F0ZWQgMzI3Njgg
SW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDc4MDI0MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEss
IHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwODAwMDAtMHgxMDAxMDAw
OWZmZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDgwMDAwOiBEZXZpY2VzIFRh
YmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAyMC0+MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAwODAwMDA6IGFsbG9jYXRlZCA1MjQyODggRGV2aWNlcyBAODA3ODEwMDAwMDAgKGZs
YXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAx
MDAwODAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwNzgwMjYw
MDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFMgW21l
bSAweDEwMDEwMDBhMDAwMC0weDEwMDEwMDBiZmZmZl0NClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAwYTAwMDA6IERldmljZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRzIDIwLT4x
OQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBhMDAwMDogYWxsb2NhdGVkIDUyNDI4
OCBEZXZpY2VzIEA4MDc4MTQwMDAwMCAoZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQ0KWyAg
ICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBhMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVy
cnVwdCBDb2xsZWN0aW9ucyBAODA3ODAyODAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIg
MSkNClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMGMwMDAwLTB4MTAwMTAwMGRmZmZm
XQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBjMDAwMDogRGV2aWNlcyBUYWJsZSB0
b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMGMwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMgQDgwNzgxODAwMDAwIChmbGF0LCBl
c3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGMw
MDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDc4MDJhMDAwMCAo
ZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgx
MDAxMDAwZTAwMDAtMHgxMDAxMDAwZmZmZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMGUwMDAwOiBEZXZpY2VzIFRhYmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAyMC0+MTkNClsg
ICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwZTAwMDA6IGFsbG9jYXRlZCA1MjQyODggRGV2
aWNlcyBAODA3ODFjMDAwMDAgKGZsYXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4w
MDAwMDBdIElUU0AweDAwMDAxMDAxMDAwZTAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQg
Q29sbGVjdGlvbnMgQDgwNzgwMmMwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpDQpb
ICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDEwMDAwMC0weDEwMDEwMDExZmZmZl0NClsg
ICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMDAwMDA6IERldmljZXMgVGFibGUgdG9vIGxh
cmdlLCByZWR1Y2UgaWRzIDIwLT4xOQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEw
MDAwMDogYWxsb2NhdGVkIDUyNDI4OCBEZXZpY2VzIEA4MDc4MjAwMDAwMCAoZmxhdCwgZXN6IDgs
IHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEwMDAwMDog
YWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODA3ODAyZTAwMDAgKGZsYXQs
IGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAw
MTIwMDAwLTB4MTAwMTAwMTNmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEy
MDAwMDogRGV2aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAu
MDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMTIwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMg
QDgwNzgyNDAwMDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAw
XSBJVFNAMHgwMDAwMTAwMTAwMTIwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxl
Y3Rpb25zIEA4MDc4MDMwMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAw
LjAwMDAwMF0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDAuMDAw
MDAwXSBXQVJOSU5HOiBDUFU6IDAgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYz
LWl0cy5jOjIyNDcgaXRzX2luaXQrMHgzOTgvMHg2OTANClsgICAgMC4wMDAwMDBdIE1vZHVsZXMg
bGlua2VkIGluOg0KWyAgICAwLjAwMDAwMF0gQ1BVOiAwIFBJRDogMCBDb21tOiBzd2FwcGVyLzAg
Tm90IHRhaW50ZWQgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkICMxDQpbICAgIDAuMDAwMDAw
XSBwc3RhdGU6IDYwMDAwMDg1IChuWkN2IGRhSWYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpb
ICAgIDAuMDAwMDAwXSBwYyA6IGl0c19pbml0KzB4Mzk4LzB4NjkwDQpbICAgIDAuMDAwMDAwXSBs
ciA6IGl0c19pbml0KzB4Mzk0LzB4NjkwDQpbICAgIDAuMDAwMDAwXSBzcCA6IGZmZmY4MDAwMTE0
ZDNjNTANClsgICAgMC4wMDAwMDBdIHgyOTogZmZmZjgwMDAxMTRkM2M1MCB4Mjg6IDAwMDAwMDAw
MDAwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4Mjc6IGZmZmY4MDAwMTE0ZGM5YzAgeDI2OiBmZmZm
MDgwNzAwMWU1NTAwIA0KWyAgICAwLjAwMDAwMF0geDI1OiAwMDAwMDAwMDAwMDAwMDAwIHgyNDog
ZmZmZjA4MDcxZjgyNDBjMCANClsgICAgMC4wMDAwMDBdIHgyMzogZmZmZjgwMDAxMTYyMjM1MCB4
MjI6IGZmZmYwODA3MDAxMWI2MDAgDQpbICAgIDAuMDAwMDAwXSB4MjE6IGZmZmY4MDAwMTE0ZGM5
YzAgeDIwOiBmZmZmODAwMDExNjIyMDAwIA0KWyAgICAwLjAwMDAwMF0geDE5OiBmZmZmODAwMDEx
NzY4OWY4IHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMC4wMDAwMDBdIHgxNzogMDAwMDAw
MDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMWYgDQpbICAgIDAuMDAwMDAwXSB4MTU6IGZm
ZmYwODA3MDAyMDQ3MWQgeDE0OiAwMDAwMDAwMDAwMDAwMDU4IA0KWyAgICAwLjAwMDAwMF0geDEz
OiAwMDAwMDAwMDAwMDAwMGMwIHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMC4wMDAwMDBd
IHgxMTogMDAwMDAwMDAwMDAwMDAxMCB4MTA6IGZmZmYwODA3MWY2ZWMwMDAgDQpbICAgIDAuMDAw
MDAwXSB4OSA6IGZmZmY4MDAwMTBkMzNjODAgeDggOiBmZmZmMDgwNzAwMzIwMDAwIA0KWyAgICAw
LjAwMDAwMF0geDcgOiBhMmEyYTJhMmEyYTJhMmEyIHg2IDogZmZmZjAwMDAwMDAwMDAwMCANClsg
ICAgMC4wMDAwMDBdIHg1IDogZmZmZmZkZmZmZmUwMDAwMCB4NCA6IGZmZmY4MDAwMTE0ZGM5YzAg
DQpbICAgIDAuMDAwMDAwXSB4MyA6IGZmZmY4MDAwMTE0ZGRhZjAgeDIgOiAwMDAwMDAwMDAwMDAw
MDNkIA0KWyAgICAwLjAwMDAwMF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBm
ZmZmZmZlZCANClsgICAgMC4wMDAwMDBdIENhbGwgdHJhY2U6DQpbICAgIDAuMDAwMDAwXSAgaXRz
X2luaXQrMHgzOTgvMHg2OTANClsgICAgMC4wMDAwMDBdICBnaWNfaW5pdF9iYXNlcysweDUyNC8w
eDU4NA0KWyAgICAwLjAwMDAwMF0gIGdpY19hY3BpX2luaXQrMHgxMzQvMHgyNzgNClsgICAgMC4w
MDAwMDBdICBhY3BpX21hdGNoX21hZHQrMHg1MC8weDg4DQpbICAgIDAuMDAwMDAwXSAgYWNwaV90
YWJsZV9wYXJzZV9lbnRyaWVzX2FycmF5KzB4MTY0LzB4MjRjDQpbICAgIDAuMDAwMDAwXSAgYWNw
aV90YWJsZV9wYXJzZV9lbnRyaWVzKzB4NDgvMHg3MA0KWyAgICAwLjAwMDAwMF0gIGFjcGlfdGFi
bGVfcGFyc2VfbWFkdCsweDM0LzB4NDANClsgICAgMC4wMDAwMDBdICBfX2FjcGlfcHJvYmVfZGV2
aWNlX3RhYmxlKzB4OTAvMHhlYw0KWyAgICAwLjAwMDAwMF0gIGlycWNoaXBfaW5pdCsweDQwLzB4
NGMNClsgICAgMC4wMDAwMDBdICBpbml0X0lSUSsweGQwLzB4MTA0DQpbICAgIDAuMDAwMDAwXSAg
c3RhcnRfa2VybmVsKzB4MzU0LzB4NTU0DQpbICAgIDAuMDAwMDAwXSByYW5kb206IGdldF9yYW5k
b21fYnl0ZXMgY2FsbGVkIGZyb20gX193YXJuKzB4MTI4LzB4MWMwIHdpdGggY3JuZ19pbml0PTAN
ClsgICAgMC4wMDAwMDBdIC0tLVsgZW5kIHRyYWNlIDAwMDAwMDAwMDAwMDAwMDAgXS0tLQ0KWyAg
ICAwLjAwMDAwMF0gR0lDdjM6IHVzaW5nIExQSSBwcm9wZXJ0eSB0YWJsZSBAMHgwMDAwMDgwNzgw
MzEwMDAwDQpbICAgIDAuMDAwMDAwXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0t
LS0NClsgICAgMC4wMDAwMDBdIFdBUk5JTkc6IENQVTogMCBQSUQ6IDAgYXQgZHJpdmVycy9pcnFj
aGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MC4wMDAwMDBdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAwLjAwMDAwMF0gQ1BVOiAwIFBJRDog
MCBDb21tOiBzd2FwcGVyLzAgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1w
ZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAwLjAwMDAwMF0gcHN0YXRlOiA2MDAwMDA4NSAoblpD
diBkYUlmIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAwLjAwMDAwMF0gcGMgOiBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMC4wMDAwMDBdIGxyIDogaXRzX2NwdV9pbml0KzB4
ODIwLzB4YjIwDQpbICAgIDAuMDAwMDAwXSBzcCA6IGZmZmY4MDAwMTE0ZDNjODANClsgICAgMC4w
MDAwMDBdIHgyOTogZmZmZjgwMDAxMTRkM2M4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAg
IDAuMDAwMDAwXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDEgeDI2OiBmZmZmODAwMDEyMDAwMDcwIA0K
WyAgICAwLjAwMDAwMF0geDI1OiBmZmZmZmUyMDFiZTBjODAwIHgyNDogZmZmZjgwMDAxMjAwMDAw
MCANClsgICAgMC4wMDAwMDBdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBm
ZjkwMDAgDQpbICAgIDAuMDAwMDAwXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAw
MDExNjIyMzUwIA0KWyAgICAwLjAwMDAwMF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZm
ZmZmZmZmZmZmZmZmZiANClsgICAgMC4wMDAwMDBdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6
IDAwMDAwMDAwMDAwMDAwMWYgDQpbICAgIDAuMDAwMDAwXSB4MTU6IGZmZmY4MDAwOTE0ZDM5Njcg
eDE0OiAwMDAwMDAwMDAwMDAwMDU4IA0KWyAgICAwLjAwMDAwMF0geDEzOiAwMDAwMDAwMDAwMDAw
MGMwIHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMC4wMDAwMDBdIHgxMTogMDAwMDAwMDAw
MDAwMDAxMCB4MTA6IDAwMDAwMDAwMDAwMDAwMGMgDQpbICAgIDAuMDAwMDAwXSB4OSA6IGZmZmY4
MDAwMTBkMzNjODAgeDggOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDcgOiBm
ZmZmMDgwNzFmYmY2YmMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMC4wMDAwMDBdIHg1
IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDAuMDAwMDAw
XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAwLjAw
MDAwMF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAg
MC4wMDAwMDBdIENhbGwgdHJhY2U6DQpbICAgIDAuMDAwMDAwXSAgaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDAuMDAwMDAwXSAgZ2ljX2luaXRfYmFzZXMrMHg1MjgvMHg1ODQNClsgICAg
MC4wMDAwMDBdICBnaWNfYWNwaV9pbml0KzB4MTM0LzB4Mjc4DQpbICAgIDAuMDAwMDAwXSAgYWNw
aV9tYXRjaF9tYWR0KzB4NTAvMHg4OA0KWyAgICAwLjAwMDAwMF0gIGFjcGlfdGFibGVfcGFyc2Vf
ZW50cmllc19hcnJheSsweDE2NC8weDI0Yw0KWyAgICAwLjAwMDAwMF0gIGFjcGlfdGFibGVfcGFy
c2VfZW50cmllcysweDQ4LzB4NzANClsgICAgMC4wMDAwMDBdICBhY3BpX3RhYmxlX3BhcnNlX21h
ZHQrMHgzNC8weDQwDQpbICAgIDAuMDAwMDAwXSAgX19hY3BpX3Byb2JlX2RldmljZV90YWJsZSsw
eDkwLzB4ZWMNClsgICAgMC4wMDAwMDBdICBpcnFjaGlwX2luaXQrMHg0MC8weDRjDQpbICAgIDAu
MDAwMDAwXSAgaW5pdF9JUlErMHhkMC8weDEwNA0KWyAgICAwLjAwMDAwMF0gIHN0YXJ0X2tlcm5l
bCsweDM1NC8weDU1NA0KWyAgICAwLjAwMDAwMF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1
M2I1MiBdLS0tDQpbICAgIDAuMDAwMDAwXSBHSUN2MzogQ1BVMDogdXNpbmcgYWxsb2NhdGVkIExQ
SSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODA3ODAzMjAwMDANClsgICAgMC4wMDAwMDBdIGFyY2hf
dGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAN
ClsgICAgMC4wMDAwMDBdIEFDUEkgR1REVDogZm91bmQgMSBtZW1vcnktbWFwcGVkIHRpbWVyIGJs
b2NrKHMpLg0KWyAgICAwLjAwMDAwMF0gYXJjaF90aW1lcjogY3AxNSBhbmQgbW1pbyB0aW1lcihz
KSBydW5uaW5nIGF0IDI1LjAwTUh6ICh2aXJ0L3BoeXMpLg0KWyAgICAwLjAwMDAwMF0gY2xvY2tz
b3VyY2U6IGFyY2hfc3lzX2NvdW50ZXI6IG1hc2s6IDB4ZmZmZmZmZmZmZmZmZmYgbWF4X2N5Y2xl
czogMHg1YzQwOTM5YjUsIG1heF9pZGxlX25zOiA0NDA3OTUyMDI2NDYgbnMNClsgICAgMC4wMDAw
MDFdIHNjaGVkX2Nsb2NrOiA1NiBiaXRzIGF0IDI1TUh6LCByZXNvbHV0aW9uIDQwbnMsIHdyYXBz
IGV2ZXJ5IDQzOTgwNDY1MTExMDBucw0KWyAgICAwLjAwMDA1N10gQ29uc29sZTogY29sb3VyIGR1
bW15IGRldmljZSA4MHgyNQ0KWyAgICAxLjI2NTM0Ml0gcHJpbnRrOiBjb25zb2xlIFtodmMwXSBl
bmFibGVkDQpbICAgIDEuMjY5NTI3XSBBQ1BJOiBDb3JlIHJldmlzaW9uIDIwMjAwOTI1DQpbICAg
IDEuMjczODM3XSBBQ1BJIEJJT1MgV2FybmluZyAoYnVnKTogSW5jb3JyZWN0IGNoZWNrc3VtIGlu
IHRhYmxlIFtJT1JUXSAtIDB4RjIsIHNob3VsZCBiZSAweDBCICgyMDIwMDkyNS90YnByaW50LTE3
MykNClsgICAgMS4yODQ0MjFdIENhbGlicmF0aW5nIGRlbGF5IGxvb3AgKHNraXBwZWQpLCB2YWx1
ZSBjYWxjdWxhdGVkIHVzaW5nIHRpbWVyIGZyZXF1ZW5jeS4uIDUwLjAwIEJvZ29NSVBTIChscGo9
MTAwMDAwKQ0KWyAgICAxLjI5NDc2MV0gcGlkX21heDogZGVmYXVsdDogMzI3NjggbWluaW11bTog
MzAxDQpbICAgIDEuMjk5NDc1XSBMU006IFNlY3VyaXR5IEZyYW1ld29yayBpbml0aWFsaXppbmcN
ClsgICAgMS4zMDQxODVdIE1vdW50LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogNDA5NiAob3Jk
ZXI6IDMsIDMyNzY4IGJ5dGVzLCBsaW5lYXIpDQpbICAgIDEuMzExNjA2XSBNb3VudHBvaW50LWNh
Y2hlIGhhc2ggdGFibGUgZW50cmllczogNDA5NiAob3JkZXI6IDMsIDMyNzY4IGJ5dGVzLCBsaW5l
YXIpDQpbICAgIDEuMzE5ODM3XSBBQ1BJIFBQVFQ6IFBQVFQgdGFibGUgZm91bmQsIGJ1dCB1bmFi
bGUgdG8gbG9jYXRlIGNvcmUgMiAoMikNClsgICAgMS4zMjY4MzBdIHhlbjpncmFudF90YWJsZTog
R3JhbnQgdGFibGVzIHVzaW5nIHZlcnNpb24gMSBsYXlvdXQNClsgICAgMS4zMzI3NTBdIEdyYW50
IHRhYmxlIGluaXRpYWxpemVkDQpbICAgIDEuMzM2MzE0XSB4ZW46ZXZlbnRzOiBVc2luZyBGSUZP
LWJhc2VkIEFCSQ0KWyAgICAxLjM0MDY0N10gWGVuOiBpbml0aWFsaXppbmcgY3B1MA0KWyAgICAx
LjM0NDEzOV0gcmN1OiBIaWVyYXJjaGljYWwgU1JDVSBpbXBsZW1lbnRhdGlvbi4NClsgICAgMS4z
NDkxMDZdIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkDQpb
ICAgIDEuMzU0NjE3XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDA2MDAwMCBkb21haW4gY3Jl
YXRlZA0KWyAgICAxLjM2MDI3OF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9t
YWluIGNyZWF0ZWQNClsgICAgMS4zNjU5MDZdIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAwMGEw
MDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzcxNTM5XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEw
MDEwMDBjMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjM3NzE4MV0gUGxhdGZvcm0gTVNJOiBJ
VFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS4zODI4MjFdIFBsYXRmb3Jt
IE1TSTogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzg4NDYzXSBQ
bGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDEyMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjM5
NDEwOF0gUENJL01TSTogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEu
Mzk5MzE0XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwNjAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAg
MS40MDQ1MjJdIFBDSS9NU0k6IElUU0AweDEwMDEwMDA4MDAwMCBkb21haW4gY3JlYXRlZA0KWyAg
ICAxLjQwOTczMV0gUENJL01TSTogSVRTQDB4MTAwMTAwMGEwMDAwIGRvbWFpbiBjcmVhdGVkDQpb
ICAgIDEuNDE0OTM5XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwYzAwMDAgZG9tYWluIGNyZWF0ZWQN
ClsgICAgMS40MjAxNDhdIFBDSS9NU0k6IElUU0AweDEwMDEwMDBlMDAwMCBkb21haW4gY3JlYXRl
ZA0KWyAgICAxLjQyNTM1NV0gUENJL01TSTogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBjcmVh
dGVkDQpbICAgIDEuNDMwNTY0XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAxMjAwMDAgZG9tYWluIGNy
ZWF0ZWQNClsgICAgMS40MzU3NzRdIEVGSSBydW50aW1lIHNlcnZpY2VzIGFjY2VzcyB2aWEgcGFy
YXZpcnQuDQpbICAgIDEuNDQxMjMzXSBzbXA6IEJyaW5naW5nIHVwIHNlY29uZGFyeSBDUFVzIC4u
Lg0KKFhFTikgZDB2MTogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBm
ZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYyOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQg
d29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjM6IHZH
SUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJ
VkVSMA0KKFhFTikgZDB2NDogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAw
MDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHY1OiB2R0lDUjogU0dJOiB1bmhhbmRs
ZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjY6
IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNB
Q1RJVkVSMA0KKFhFTikgZDB2NzogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgw
MDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHY4OiB2R0lDUjogU0dJOiB1bmhh
bmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQw
djk6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8g
SUNBQ1RJVkVSMA0KKFhFTikgZDB2MTA6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRl
IDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTE6IHZHSUNSOiBTR0k6
IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhF
TikgZDB2MTI6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZm
ZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTM6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3Jk
IHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTQ6IHZHSUNS
OiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVS
MA0KKFhFTikgZDB2MTU6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAw
ZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTY6IHZHSUNSOiBTR0k6IHVuaGFuZGxl
ZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTc6
IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNB
Q1RJVkVSMA0KKFhFTikgZDB2MTg6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4
MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTk6IHZHSUNSOiBTR0k6IHVu
aGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikg
ZDB2MjA6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYg
dG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjE6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdy
aXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjI6IHZHSUNSOiBT
R0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0K
KFhFTikgZDB2MjM6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZm
ZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjQ6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3
b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjU6IHZH
SUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJ
VkVSMA0KKFhFTikgZDB2MjY6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAw
MDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2Mjc6IHZHSUNSOiBTR0k6IHVuaGFu
ZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2
Mjg6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8g
SUNBQ1RJVkVSMA0KKFhFTikgZDB2Mjk6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRl
IDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MzA6IHZHSUNSOiBTR0k6
IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhF
TikgZDB2MzE6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZm
ZmYgdG8gSUNBQ1RJVkVSMA0KWyAgICAxLjQ0NTg1OF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9u
IENQVTENClsgICAgMS40NDU4ODNdIEdJQ3YzOiBDUFUxOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEg
cmVnaW9uIDA6MHgwMDAwMTAwMTAwMTYwMDAwDQpbICAgIDEuNDUyNDE1XSAtLS0tLS0tLS0tLS1b
IGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS40NTI0MjBdIFdBUk5JTkc6IENQVTogMSBQ
SUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2lu
aXQrMHg4MjQvMHhiMjANClsgICAgMS40NTI0MjFdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAx
LjQ1MjQyNV0gQ1BVOiAxIFBJRDogMCBDb21tOiBzd2FwcGVyLzEgVGFpbnRlZDogRyAgICAgICAg
VyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjQ1MjQyN10g
cHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAg
ICAxLjQ1MjQyOV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NTI0MzFd
IGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNDUyNDMyXSBzcCA6IGZmZmY4
MDAwMTFhM2JlODANClsgICAgMS40NTI0MzNdIHgyOTogZmZmZjgwMDAxMWEzYmU4MCB4Mjg6IDAw
MDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNDUyNDM1XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2
OiBmZmZmODAwMDEyMDIwMDcwIA0KWyAgICAxLjQ1MjQzN10geDI1OiBmZmZmZmUyMDFiZTBjYzAw
IHgyNDogZmZmZjgwMDAxMjAyMDAwMCANClsgICAgMS40NTI0MzldIHgyMzogZmZmZjgwMDAxMTRk
YzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNDUyNDQxXSB4MjE6IGZmZmY4MDAw
MTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjQ1MjQ0M10geDE5OiBmZmZm
ODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS40NTI0NDVdIHgxNzog
MDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDUyNDQ3XSB4
MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjQ1MjQ0
OV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40
NTI0NTFdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAg
IDEuNDUyNDUzXSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDMwMzAzMDM2MzEzMDMwIA0K
WyAgICAxLjQ1MjQ1NV0geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAw
MyANClsgICAgMS40NTI0NTZdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZl
MDAwMDAgDQpbICAgIDEuNDUyNDU4XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAw
MDAwMDBmZmZmIA0KWyAgICAxLjQ1MjQ2MF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAw
MDAwMDBmZmZmZmZlZCANClsgICAgMS40NTI0NjJdIENhbGwgdHJhY2U6DQpbICAgIDEuNDUyNDY0
XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDUyNDY3XSAgZ2ljX3N0YXJ0aW5n
X2NwdSsweDQ4LzB4OTANClsgICAgMS40NTI0NzBdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhh
NC8weDQ2MA0KWyAgICAxLjQ1MjQ3Ml0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpb
ICAgIDEuNDUyNDc1XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEu
NDUyNDc2XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjUzIF0tLS0NClsgICAgMS40NTI0
ODFdIEdJQ3YzOiBDUFUxOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAw
MDA4MDc4MDMzMDAwMA0KWyAgICAxLjQ1MjUzOF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwg
d29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjQ1MjU0Nl0gWGVuOiBp
bml0aWFsaXppbmcgY3B1MQ0KWyAgICAxLjQ1MjU2N10gQ1BVMTogQm9vdGVkIHNlY29uZGFyeSBw
cm9jZXNzb3IgMHgwMDAwMDAwMDAxIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjQ1Mjg2MF0gRGV0ZWN0
ZWQgUElQVCBJLWNhY2hlIG9uIENQVTINClsgICAgMS40NTI4ODldIEdJQ3YzOiBDUFUyOiBmb3Vu
ZCByZWRpc3RyaWJ1dG9yIDIgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMTgwMDAwDQpbICAgIDEuNDU5
NDI0XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS40NTk0MzFd
IFdBUk5JTkc6IENQVTogMiBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRz
LmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NTk0MzJdIE1vZHVsZXMg
bGlua2VkIGluOg0KWyAgICAxLjQ1OTQzN10gQ1BVOiAyIFBJRDogMCBDb21tOiBzd2FwcGVyLzIg
VGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAj
MQ0KWyAgICAxLjQ1OTQ0MF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAt
VENPIEJUWVBFPS0tKQ0KWyAgICAxLjQ1OTQ0MV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhi
MjANClsgICAgMS40NTk0NDNdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEu
NDU5NDQ0XSBzcCA6IGZmZmY4MDAwMTFhNDNlODANClsgICAgMS40NTk0NDVdIHgyOTogZmZmZjgw
MDAxMWE0M2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDIgDQpbICAgIDEuNDU5NDQ3XSB4Mjc6IDAw
MDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMDQwMDcwIA0KWyAgICAxLjQ1OTQ0OV0geDI1
OiBmZmZmZmUyMDFiZTBkMDAwIHgyNDogZmZmZjgwMDAxMjA0MDAwMCANClsgICAgMS40NTk0NTFd
IHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNDU5
NDUzXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAx
LjQ1OTQ1NV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsg
ICAgMS40NTk0NTddIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAg
DQpbICAgIDEuNDU5NDU5XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAw
MDEwIA0KWyAgICAxLjQ1OTQ2MV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAw
MDAwMDAwMCANClsgICAgMS40NTk0NjNdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAw
MDAwMDAwMDAwMDEgDQpbICAgIDEuNDU5NDY1XSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAz
MDMwMzAzMDM4MzEzMDMwIA0KWyAgICAxLjQ1OTQ2N10geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2
IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40NTk0NjldIHg1IDogMDAwMDAwMDAwMDAwMDAw
MCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDU5NDcwXSB4MyA6IDAwMDAwMDAwMDAw
MDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ1OTQ3M10geDEgOiAwMDAwMDAw
MDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40NTk0NzVdIENhbGwgdHJh
Y2U6DQpbICAgIDEuNDU5NDc2XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDU5
NDgwXSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40NTk0ODNdICBjcHVocF9p
bnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ1OTQ4Nl0gIG5vdGlmeV9jcHVfc3Rh
cnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNDU5NDg5XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsw
eGU4LzB4MTkwDQpbICAgIDEuNDU5NDkwXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjU0
IF0tLS0NClsgICAgMS40NTk0OTZdIEdJQ3YzOiBDUFUyOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDc4MDM0MDAwMA0KWyAgICAxLjQ1OTU2M10gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAg
ICAxLjQ1OTU3NV0gWGVuOiBpbml0aWFsaXppbmcgY3B1Mg0KWyAgICAxLjQ1OTU5OF0gQ1BVMjog
Qm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDAyIFsweDQxM2ZkMGMxXQ0KWyAg
ICAxLjQ1OTg3Nl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTMNClsgICAgMS40NTk5MDJd
IEdJQ3YzOiBDUFUzOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDMgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
MWEwMDAwDQpbICAgIDEuNDY2NDM0XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0t
LS0NClsgICAgMS40NjY0MzldIFdBUk5JTkc6IENQVTogMyBQSUQ6IDAgYXQgZHJpdmVycy9pcnFj
aGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS40NjY0NDBdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ2NjQ0NF0gQ1BVOiAzIFBJRDog
MCBDb21tOiBzd2FwcGVyLzMgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1w
ZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjQ2NjQ0Nl0gcHN0YXRlOiA2MDAwMDFjNSAoblpD
diBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjQ2NjQ0OF0gcGMgOiBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NjY0NTBdIGxyIDogaXRzX2NwdV9pbml0KzB4
ODIwLzB4YjIwDQpbICAgIDEuNDY2NDUxXSBzcCA6IGZmZmY4MDAwMTFhNGJlODANClsgICAgMS40
NjY0NTJdIHgyOTogZmZmZjgwMDAxMWE0YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAg
IDEuNDY2NDU0XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMDYwMDcwIA0K
WyAgICAxLjQ2NjQ1Nl0geDI1OiBmZmZmZmUyMDFiZTBkNDAwIHgyNDogZmZmZjgwMDAxMjA2MDAw
MCANClsgICAgMS40NjY0NThdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBm
ZjkwMDAgDQpbICAgIDEuNDY2NDYwXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAw
MDExNjIyMzUwIA0KWyAgICAxLjQ2NjQ2Ml0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZm
ZmZmZmZmZmZmZmZmZiANClsgICAgMS40NjY0NjRdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6
IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDY2NDY2XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAg
eDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjQ2NjQ2OF0geDEzOiBmZmZmODAwMDExNmQ0
Y2Y0IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40NjY0NzBdIHgxMTogMDAwMDAwMDAw
MDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNDY2NDcyXSB4OSA6IGZmZmY4
MDAwMTA2ZDU3YjAgeDggOiAzMDMwMzAzMDYxMzEzMDMwIA0KWyAgICAxLjQ2NjQ3M10geDcgOiAz
MTMwMzAzMTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40NjY0NzVdIHg1
IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDY2NDc3
XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ2
NjQ3OV0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAg
MS40NjY0ODFdIENhbGwgdHJhY2U6DQpbICAgIDEuNDY2NDgzXSAgaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDEuNDY2NDg2XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAg
MS40NjY0ODhdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ2NjQ5
MF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNDY2NDkzXSAgc2Vjb25k
YXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNDY2NDk0XSAtLS1bIGVuZCB0cmFj
ZSBmNjg3MjhhMGQzMDUzYjU1IF0tLS0NClsgICAgMS40NjY1MDBdIEdJQ3YzOiBDUFUzOiB1c2lu
ZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDc4MDM1MDAwMA0KWyAgICAx
LjQ2NjU1OV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVy
cmF0dW0gMTQxODA0MA0KWyAgICAxLjQ2NjU2N10gWGVuOiBpbml0aWFsaXppbmcgY3B1Mw0KWyAg
ICAxLjQ2NjU4N10gQ1BVMzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDAz
IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjQ2Njg0M10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQ
VTQNClsgICAgMS40NjY4NzJdIEdJQ3YzOiBDUFU0OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDQgcmVn
aW9uIDA6MHgwMDAwMTAwMTAwMWMwMDAwDQpbICAgIDEuNDczNDA0XSAtLS0tLS0tLS0tLS1bIGN1
dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS40NzM0MDhdIFdBUk5JTkc6IENQVTogNCBQSUQ6
IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQr
MHg4MjQvMHhiMjANClsgICAgMS40NzM0MDldIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ3
MzQxM10gQ1BVOiA0IFBJRDogMCBDb21tOiBzd2FwcGVyLzQgVGFpbnRlZDogRyAgICAgICAgVyAg
ICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjQ3MzQxNV0gcHN0
YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAx
LjQ3MzQxN10gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NzM0MThdIGxy
IDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNDczNDE5XSBzcCA6IGZmZmY4MDAw
MTFhNTNlODANClsgICAgMS40NzM0MjBdIHgyOTogZmZmZjgwMDAxMWE1M2U4MCB4Mjg6IDAwMDAw
MDAwMDAwMDAwMDQgDQpbICAgIDEuNDczNDIzXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBm
ZmZmODAwMDEyMDgwMDcwIA0KWyAgICAxLjQ3MzQyNV0geDI1OiBmZmZmZmUyMDFiZTBkODAwIHgy
NDogZmZmZjgwMDAxMjA4MDAwMCANClsgICAgMS40NzM0MjddIHgyMzogZmZmZjgwMDAxMTRkYzlj
MCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNDczNDI5XSB4MjE6IGZmZmY4MDAwMTE3
Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjQ3MzQzMV0geDE5OiBmZmZmODAw
MDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS40NzM0MzNdIHgxNzogMDAw
MDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDczNDM1XSB4MTU6
IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjQ3MzQzNl0g
eDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40NzM0
MzhdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEu
NDczNDQwXSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDMwMzAzMDYzMzEzMDMwIA0KWyAg
ICAxLjQ3MzQ0Ml0geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyAN
ClsgICAgMS40NzM0NDRdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAw
MDAgDQpbICAgIDEuNDczNDQ2XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAw
MDBmZmZmIA0KWyAgICAxLjQ3MzQ0OF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAw
MDBmZmZmZmZlZCANClsgICAgMS40NzM0NTBdIENhbGwgdHJhY2U6DQpbICAgIDEuNDczNDUyXSAg
aXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDczNDU1XSAgZ2ljX3N0YXJ0aW5nX2Nw
dSsweDQ4LzB4OTANClsgICAgMS40NzM0NTddICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8w
eDQ2MA0KWyAgICAxLjQ3MzQ1OV0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAg
IDEuNDczNDYyXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNDcz
NDYzXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjU2IF0tLS0NClsgICAgMS40NzM0Njld
IEdJQ3YzOiBDUFU0OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4
MDc4MDM2MDAwMA0KWyAgICAxLjQ3MzUzNF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29y
a2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjQ3MzU0Ml0gWGVuOiBpbml0
aWFsaXppbmcgY3B1NA0KWyAgICAxLjQ3MzU2M10gQ1BVNDogQm9vdGVkIHNlY29uZGFyeSBwcm9j
ZXNzb3IgMHgwMDAwMDAwMDA0IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjQ3MzkxNF0gRGV0ZWN0ZWQg
UElQVCBJLWNhY2hlIG9uIENQVTUNClsgICAgMS40NzM5NDRdIEdJQ3YzOiBDUFU1OiBmb3VuZCBy
ZWRpc3RyaWJ1dG9yIDUgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMWUwMDAwDQpbICAgIDEuNDgwNDc2
XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS40ODA0ODFdIFdB
Uk5JTkc6IENQVTogNSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6
MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40ODA0ODJdIE1vZHVsZXMgbGlu
a2VkIGluOg0KWyAgICAxLjQ4MDQ4Nl0gQ1BVOiA1IFBJRDogMCBDb21tOiBzd2FwcGVyLzUgVGFp
bnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0K
WyAgICAxLjQ4MDQ4OF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENP
IEJUWVBFPS0tKQ0KWyAgICAxLjQ4MDQ5MF0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjAN
ClsgICAgMS40ODA0OTFdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNDgw
NDkyXSBzcCA6IGZmZmY4MDAwMTFhNWJlODANClsgICAgMS40ODA0OTNdIHgyOTogZmZmZjgwMDAx
MWE1YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDUgDQpbICAgIDEuNDgwNDk1XSB4Mjc6IDAwMDAw
MDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMGEwMDcwIA0KWyAgICAxLjQ4MDQ5N10geDI1OiBm
ZmZmZmUyMDFiZTBkYzAwIHgyNDogZmZmZjgwMDAxMjBhMDAwMCANClsgICAgMS40ODA0OTldIHgy
MzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNDgwNTAx
XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjQ4
MDUwNF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAg
MS40ODA1MDZdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpb
ICAgIDEuNDgwNTA3XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEw
IA0KWyAgICAxLjQ4MDUwOV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAwMDAw
MDAwMCANClsgICAgMS40ODA1MTFdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAw
MDAwMDAwMDEgDQpbICAgIDEuNDgwNTEzXSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDMw
MzAzMDY1MzEzMDMwIA0KWyAgICAxLjQ4MDUxNV0geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2IDog
MDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40ODA1MTddIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4
NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDgwNTE5XSB4MyA6IDAwMDAwMDAwMDAwMDAw
MTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ4MDUyMV0geDEgOiAwMDAwMDAwMDAw
MDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40ODA1MjNdIENhbGwgdHJhY2U6
DQpbICAgIDEuNDgwNTI1XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDgwNTI3
XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40ODA1MzBdICBjcHVocF9pbnZv
a2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ4MDUzMl0gIG5vdGlmeV9jcHVfc3RhcnRp
bmcrMHhhMC8weGUwDQpbICAgIDEuNDgwNTM1XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4
LzB4MTkwDQpbICAgIDEuNDgwNTM2XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjU3IF0t
LS0NClsgICAgMS40ODA1NDJdIEdJQ3YzOiBDUFU1OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRp
bmcgdGFibGUgQDB4MDAwMDA4MDc4MDM3MDAwMA0KWyAgICAxLjQ4MDYwMV0gYXJjaF90aW1lcjog
RW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAx
LjQ4MDYwOV0gWGVuOiBpbml0aWFsaXppbmcgY3B1NQ0KWyAgICAxLjQ4MDYzMF0gQ1BVNTogQm9v
dGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA1IFsweDQxM2ZkMGMxXQ0KWyAgICAx
LjQ4MDk3OV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTYNClsgICAgMS40ODEwMTJdIEdJ
Q3YzOiBDUFU2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDYgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMjAw
MDAwDQpbICAgIDEuNDg3NTQ1XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0N
ClsgICAgMS40ODc1NDldIFdBUk5JTkc6IENQVTogNiBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlw
L2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40
ODc1NTBdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ4NzU1NF0gQ1BVOiA2IFBJRDogMCBD
b21tOiBzd2FwcGVyLzYgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJl
LWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjQ4NzU1Nl0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBk
QUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjQ4NzU1OF0gcGMgOiBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40ODc1NjBdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIw
LzB4YjIwDQpbICAgIDEuNDg3NTYwXSBzcCA6IGZmZmY4MDAwMTFhNjNlODANClsgICAgMS40ODc1
NjJdIHgyOTogZmZmZjgwMDAxMWE2M2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDYgDQpbICAgIDEu
NDg3NTY0XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMGMwMDcwIA0KWyAg
ICAxLjQ4NzU2N10geDI1OiBmZmZmZmUyMDFiZTBlMDAwIHgyNDogZmZmZjgwMDAxMjBjMDAwMCAN
ClsgICAgMS40ODc1NjldIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkw
MDAgDQpbICAgIDEuNDg3NTcxXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDEx
NjIyMzUwIA0KWyAgICAxLjQ4NzU3M10geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZm
ZmZmZmZmZmZmZiANClsgICAgMS40ODc1NzVdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAw
MDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDg3NTc2XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0
OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjQ4NzU3OF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0
IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40ODc1ODBdIHgxMTogMDAwMDAwMDAwMDAw
MDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNDg3NTgyXSB4OSA6IGZmZmY4MDAw
MTA2ZDU3YjAgeDggOiAzMDMwMzAzMDMwMzIzMDMwIA0KWyAgICAxLjQ4NzU4NF0geDcgOiAzMTMw
MzAzMTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40ODc1ODZdIHg1IDog
MDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDg3NTg4XSB4
MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ4NzU5
MF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40
ODc1OTJdIENhbGwgdHJhY2U6DQpbICAgIDEuNDg3NTkzXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNDg3NTk2XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40
ODc1OTldICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ4NzYwMV0g
IG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNDg3NjA0XSAgc2Vjb25kYXJ5
X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNDg3NjA1XSAtLS1bIGVuZCB0cmFjZSBm
Njg3MjhhMGQzMDUzYjU4IF0tLS0NClsgICAgMS40ODc2MTBdIEdJQ3YzOiBDUFU2OiB1c2luZyBh
bGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDc4MDM4MDAwMA0KWyAgICAxLjQ4
NzY3OF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0
dW0gMTQxODA0MA0KWyAgICAxLjQ4NzY4N10gWGVuOiBpbml0aWFsaXppbmcgY3B1Ng0KWyAgICAx
LjQ4NzcwOF0gQ1BVNjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA2IFsw
eDQxM2ZkMGMxXQ0KWyAgICAxLjQ4ODAyNV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTcN
ClsgICAgMS40ODgwNTldIEdJQ3YzOiBDUFU3OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDcgcmVnaW9u
IDA6MHgwMDAwMTAwMTAwMjIwMDAwDQpbICAgIDEuNDk0NTkxXSAtLS0tLS0tLS0tLS1bIGN1dCBo
ZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS40OTQ1OTZdIFdBUk5JTkc6IENQVTogNyBQSUQ6IDAg
YXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS40OTQ1OTddIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ5NDYw
MV0gQ1BVOiA3IFBJRDogMCBDb21tOiBzd2FwcGVyLzcgVGFpbnRlZDogRyAgICAgICAgVyAgICAg
ICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjQ5NDYwM10gcHN0YXRl
OiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjQ5
NDYwNV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40OTQ2MDddIGxyIDog
aXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNDk0NjA4XSBzcCA6IGZmZmY4MDAwMTFh
NmJlODANClsgICAgMS40OTQ2MDldIHgyOTogZmZmZjgwMDAxMWE2YmU4MCB4Mjg6IDAwMDAwMDAw
MDAwMDAwMDcgDQpbICAgIDEuNDk0NjExXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZm
ODAwMDEyMGUwMDcwIA0KWyAgICAxLjQ5NDYxM10geDI1OiBmZmZmZmUyMDFiZTBlNDAwIHgyNDog
ZmZmZjgwMDAxMjBlMDAwMCANClsgICAgMS40OTQ2MTVdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4
MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNDk0NjE3XSB4MjE6IGZmZmY4MDAwMTE3Njg5
ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjQ5NDYxOV0geDE5OiBmZmZmODAwMDEx
NjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS40OTQ2MjFdIHgxNzogMDAwMDAw
MDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDk0NjIzXSB4MTU6IGZm
ZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjQ5NDYyNV0geDEz
OiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40OTQ2Mjdd
IHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNDk0
NjI5XSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDMwMzAzMDMyMzIzMDMwIA0KWyAgICAx
LjQ5NDYzMV0geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsg
ICAgMS40OTQ2MzNdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAg
DQpbICAgIDEuNDk0NjM1XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBm
ZmZmIA0KWyAgICAxLjQ5NDYzN10geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBm
ZmZmZmZlZCANClsgICAgMS40OTQ2MzldIENhbGwgdHJhY2U6DQpbICAgIDEuNDk0NjQwXSAgaXRz
X2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDk0NjQzXSAgZ2ljX3N0YXJ0aW5nX2NwdSsw
eDQ4LzB4OTANClsgICAgMS40OTQ2NDZdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2
MA0KWyAgICAxLjQ5NDY0OF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEu
NDk0NjUwXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNDk0NjUy
XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjU5IF0tLS0NClsgICAgMS40OTQ2NThdIEdJ
Q3YzOiBDUFU3OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDc4
MDM5MDAwMA0KWyAgICAxLjQ5NDcxN10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fy
b3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjQ5NDcyNl0gWGVuOiBpbml0aWFs
aXppbmcgY3B1Nw0KWyAgICAxLjQ5NDc0N10gQ1BVNzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNz
b3IgMHgwMDAwMDAwMDA3IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjQ5NDk5N10gRGV0ZWN0ZWQgUElQ
VCBJLWNhY2hlIG9uIENQVTgNClsgICAgMS40OTUwMzRdIEdJQ3YzOiBDUFU4OiBmb3VuZCByZWRp
c3RyaWJ1dG9yIDggcmVnaW9uIDA6MHgwMDAwMTAwMTAwMjQwMDAwDQpbICAgIDEuNTAxNTY2XSAt
LS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41MDE1NzFdIFdBUk5J
Tkc6IENQVTogOCBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2
OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MDE1NzJdIE1vZHVsZXMgbGlua2Vk
IGluOg0KWyAgICAxLjUwMTU3Nl0gQ1BVOiA4IFBJRDogMCBDb21tOiBzd2FwcGVyLzggVGFpbnRl
ZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAg
ICAxLjUwMTU3OF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJU
WVBFPS0tKQ0KWyAgICAxLjUwMTU4MF0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS41MDE1ODJdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTAxNTgy
XSBzcCA6IGZmZmY4MDAwMTFhNzNlODANClsgICAgMS41MDE1ODRdIHgyOTogZmZmZjgwMDAxMWE3
M2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDggDQpbICAgIDEuNTAxNTg2XSB4Mjc6IDAwMDAwMDAw
MDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMTAwMDcwIA0KWyAgICAxLjUwMTU4OF0geDI1OiBmZmZm
ZmUyMDFiZTBlODAwIHgyNDogZmZmZjgwMDAxMjEwMDAwMCANClsgICAgMS41MDE1OTBdIHgyMzog
ZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTAxNTkyXSB4
MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjUwMTU5
NF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41
MDE1OTZdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAg
IDEuNTAxNTk4XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0K
WyAgICAxLjUwMTYwMF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAwMDAwMDAw
MCANClsgICAgMS41MDE2MDJdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAw
MDAwMDEgDQpbICAgIDEuNTAxNjA0XSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDMwMzAz
MDM0MzIzMDMwIA0KWyAgICAxLjUwMTYwNl0geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2IDogMDAw
MDAwMDAwMDAwMDAwMyANClsgICAgMS41MDE2MDhdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6
IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTAxNjA5XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAg
eDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjUwMTYxMV0geDEgOiAwMDAwMDAwMDAwMDEw
MDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41MDE2MTRdIENhbGwgdHJhY2U6DQpb
ICAgIDEuNTAxNjE1XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTAxNjE4XSAg
Z2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41MDE2MjBdICBjcHVocF9pbnZva2Vf
Y2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjUwMTYyM10gIG5vdGlmeV9jcHVfc3RhcnRpbmcr
MHhhMC8weGUwDQpbICAgIDEuNTAxNjI1XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4
MTkwDQpbICAgIDEuNTAxNjI3XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjVhIF0tLS0N
ClsgICAgMS41MDE2MzJdIEdJQ3YzOiBDUFU4OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcg
dGFibGUgQDB4MDAwMDA4MDc4MDNhMDAwMA0KWyAgICAxLjUwMTcwMF0gYXJjaF90aW1lcjogRW5h
YmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjUw
MTcwOV0gWGVuOiBpbml0aWFsaXppbmcgY3B1OA0KWyAgICAxLjUwMTczMV0gQ1BVODogQm9vdGVk
IHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA4IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjUw
MjA5MV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTkNClsgICAgMS41MDIxMjldIEdJQ3Yz
OiBDUFU5OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDkgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMjYwMDAw
DQpbICAgIDEuNTA4NjYxXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsg
ICAgMS41MDg2NjZdIFdBUk5JTkc6IENQVTogOSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2ly
cS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MDg2
NjddIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjUwODY3MV0gQ1BVOiA5IFBJRDogMCBDb21t
OiBzd2FwcGVyLzkgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0
cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjUwODY3M10gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlG
IC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjUwODY3NV0gcGMgOiBpdHNfY3B1X2lu
aXQrMHg4MjQvMHhiMjANClsgICAgMS41MDg2NzZdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4
YjIwDQpbICAgIDEuNTA4Njc3XSBzcCA6IGZmZmY4MDAwMTFhN2JlODANClsgICAgMS41MDg2Nzhd
IHgyOTogZmZmZjgwMDAxMWE3YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDkgDQpbICAgIDEuNTA4
NjgwXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMTIwMDcwIA0KWyAgICAx
LjUwODY4M10geDI1OiBmZmZmZmUyMDFiZTBlYzAwIHgyNDogZmZmZjgwMDAxMjEyMDAwMCANClsg
ICAgMS41MDg2ODVdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAg
DQpbICAgIDEuNTA4Njg2XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIy
MzUwIA0KWyAgICAxLjUwODY4OF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZm
ZmZmZmZmZiANClsgICAgMS41MDg2OTBdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAw
MDAwMDAwMDAwMDAgDQpbICAgIDEuNTA4NjkyXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAw
MDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjUwODY5NF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgx
MjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MDg2OTZdIHgxMTogMDAwMDAwMDAwMDAwMDAw
MCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTA4Njk4XSB4OSA6IGZmZmY4MDAwMTA2
ZDU3YjAgeDggOiAzMDMwMzAzMDM2MzIzMDMwIA0KWyAgICAxLjUwODcwMF0geDcgOiAzMTMwMzAz
MTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41MDg3MDJdIHg1IDogMDAw
MDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTA4NzA0XSB4MyA6
IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjUwODcwNl0g
eDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41MDg3
MDhdIENhbGwgdHJhY2U6DQpbICAgIDEuNTA4NzEwXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIw
DQpbICAgIDEuNTA4NzEzXSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41MDg3
MTVdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjUwODcxN10gIG5v
dGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTA4NzIwXSAgc2Vjb25kYXJ5X3N0
YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTA4NzIxXSAtLS1bIGVuZCB0cmFjZSBmNjg3
MjhhMGQzMDUzYjViIF0tLS0NClsgICAgMS41MDg3MjddIEdJQ3YzOiBDUFU5OiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDc4MDNiMDAwMA0KWyAgICAxLjUwODc4
N10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0g
MTQxODA0MA0KWyAgICAxLjUwODc5NV0gWGVuOiBpbml0aWFsaXppbmcgY3B1OQ0KWyAgICAxLjUw
ODgxNl0gQ1BVOTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA5IFsweDQx
M2ZkMGMxXQ0KWyAgICAxLjUwOTE2OV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEwDQpb
ICAgIDEuNTA5MjExXSBHSUN2MzogQ1BVMTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgYSByZWdpb24g
MDoweDAwMDAxMDAxMDAyODAwMDANClsgICAgMS41MTU4MzFdIC0tLS0tLS0tLS0tLVsgY3V0IGhl
cmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjUxNTgzNl0gV0FSTklORzogQ1BVOiAxMCBQSUQ6IDAg
YXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS41MTU4MzZdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjUxNTg0
MV0gQ1BVOiAxMCBQSUQ6IDAgQ29tbTogc3dhcHBlci8xMCBUYWludGVkOiBHICAgICAgICBXICAg
ICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkICMxDQpbICAgIDEuNTE1ODQzXSBwc3Rh
dGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEu
NTE1ODQ1XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUxNTg0Nl0gbHIg
OiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41MTU4NDddIHNwIDogZmZmZjgwMDAx
MWE4M2U4MA0KWyAgICAxLjUxNTg0OF0geDI5OiBmZmZmODAwMDExYTgzZTgwIHgyODogMDAwMDAw
MDAwMDAwMDAwYSANClsgICAgMS41MTU4NTBdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZm
ZmY4MDAwMTIxNDAwNzAgDQpbICAgIDEuNTE1ODUyXSB4MjU6IGZmZmZmZTIwMWJlMGYwMDAgeDI0
OiBmZmZmODAwMDEyMTQwMDAwIA0KWyAgICAxLjUxNTg1NF0geDIzOiBmZmZmODAwMDExNGRjOWMw
IHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41MTU4NTZdIHgyMTogZmZmZjgwMDAxMTc2
ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTE1ODU4XSB4MTk6IGZmZmY4MDAw
MTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjUxNTg2MF0geDE3OiAwMDAw
MDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MTU4NjJdIHgxNTog
ZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTE1ODY0XSB4
MTM6IGZmZmY4MDAwMTE2ZDRjZjUgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjUxNTg2
Nl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41
MTU4NjhdIHg5IDogZmZmZjgwMDAxMDZkNTdiMCB4OCA6IDMwMzAzMDM4MzIzMDMwMzEgDQpbICAg
IDEuNTE1ODcwXSB4NyA6IDMwMzAzMTMwMzAzMDMwNzggeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0K
WyAgICAxLjUxNTg3Ml0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAw
MCANClsgICAgMS41MTU4NzRdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAw
MGZmZmYgDQpbICAgIDEuNTE1ODc2XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAw
MGZmZmZmZmVkIA0KWyAgICAxLjUxNTg3OF0gQ2FsbCB0cmFjZToNClsgICAgMS41MTU4ODBdICBp
dHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MTU4ODJdICBnaWNfc3RhcnRpbmdfY3B1
KzB4NDgvMHg5MA0KWyAgICAxLjUxNTg4NV0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4
NDYwDQpbICAgIDEuNTE1ODg3XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAg
MS41MTU4OTBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41MTU4
OTFdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNWMgXS0tLQ0KWyAgICAxLjUxNTg5N10g
R0lDdjM6IENQVTEwOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4
MDc4MDNjMDAwMA0KWyAgICAxLjUxNTk2M10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29y
a2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjUxNTk3Ml0gWGVuOiBpbml0
aWFsaXppbmcgY3B1MTANClsgICAgMS41MTU5OTRdIENQVTEwOiBCb290ZWQgc2Vjb25kYXJ5IHBy
b2Nlc3NvciAweDAwMDAwMDAwMGEgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTE2MzQ5XSBEZXRlY3Rl
ZCBQSVBUIEktY2FjaGUgb24gQ1BVMTENClsgICAgMS41MTYzOTFdIEdJQ3YzOiBDUFUxMTogZm91
bmQgcmVkaXN0cmlidXRvciBiIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDJhMDAwMA0KWyAgICAxLjUy
MzAxMV0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTIzMDE1
XSBXQVJOSU5HOiBDUFU6IDExIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1p
dHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUyMzAxN10gTW9kdWxl
cyBsaW5rZWQgaW46DQpbICAgIDEuNTIzMDIxXSBDUFU6IDExIFBJRDogMCBDb21tOiBzd2FwcGVy
LzExIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRh
cmQgIzENClsgICAgMS41MjMwMjNdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1V
QU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41MjMwMjVdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDEuNTIzMDI2XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAg
ICAxLjUyMzAyN10gc3AgOiBmZmZmODAwMDExYThiZTgwDQpbICAgIDEuNTIzMDI4XSB4Mjk6IGZm
ZmY4MDAwMTFhOGJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDBiIA0KWyAgICAxLjUyMzAzMV0geDI3
OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjE2MDA3MCANClsgICAgMS41MjMwMzNd
IHgyNTogZmZmZmZlMjAxYmUwZjQwMCB4MjQ6IGZmZmY4MDAwMTIxNjAwMDAgDQpbICAgIDEuNTIz
MDM1XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAx
LjUyMzAzN10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsg
ICAgMS41MjMwMzldIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYg
DQpbICAgIDEuNTIzMDQxXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAw
MDAwIA0KWyAgICAxLjUyMzA0M10geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAw
MDAwMDAxMCANClsgICAgMS41MjMwNDVdIHgxMzogZmZmZjgwMDAxMTZkNGNmNSB4MTI6IDAwMDAw
MDAwMDAwMDAwMDAgDQpbICAgIDEuNTIzMDQ3XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAw
MDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjUyMzA0OF0geDkgOiBmZmZmODAwMDEwNmQ1N2IwIHg4
IDogMzAzMDMwNjEzMjMwMzAzMSANClsgICAgMS41MjMwNTBdIHg3IDogMzAzMDMxMzAzMDMwMzA3
OCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTIzMDUyXSB4NSA6IDAwMDAwMDAwMDAw
MDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjUyMzA1NF0geDMgOiAwMDAwMDAw
MDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS41MjMwNTZdIHgxIDogMDAw
MDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTIzMDU4XSBDYWxs
IHRyYWNlOg0KWyAgICAxLjUyMzA2MF0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjUyMzA2M10gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTIzMDY1XSAgY3B1
aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41MjMwNjhdICBub3RpZnlfY3B1
X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjUyMzA3MF0gIHNlY29uZGFyeV9zdGFydF9rZXJu
ZWwrMHhlOC8weDE5MA0KWyAgICAxLjUyMzA3MV0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1
M2I1ZCBdLS0tDQpbICAgIDEuNTIzMDc3XSBHSUN2MzogQ1BVMTE6IHVzaW5nIGFsbG9jYXRlZCBM
UEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwNzgwM2QwMDAwDQpbICAgIDEuNTIzMTM3XSBhcmNo
X3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQw
DQpbICAgIDEuNTIzMTQ1XSBYZW46IGluaXRpYWxpemluZyBjcHUxMQ0KWyAgICAxLjUyMzE2Nl0g
Q1BVMTE6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDAwYiBbMHg0MTNmZDBj
MV0NClsgICAgMS41MjM0NDNdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxMg0KWyAgICAx
LjUyMzQ4OF0gR0lDdjM6IENQVTEyOiBmb3VuZCByZWRpc3RyaWJ1dG9yIGMgcmVnaW9uIDA6MHgw
MDAwMTAwMTAwMmMwMDAwDQpbICAgIDEuNTMwMTA4XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0t
LS0tLS0tLS0tLS0NClsgICAgMS41MzAxMTJdIFdBUk5JTkc6IENQVTogMTIgUElEOiAwIGF0IGRy
aXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNTMwMTEzXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41MzAxMTddIENQ
VTogMTIgUElEOiAwIENvbW06IHN3YXBwZXIvMTIgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAg
IDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjUzMDExOV0gcHN0YXRlOiA2
MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjUzMDEy
MV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MzAxMjJdIGxyIDogaXRz
X2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTMwMTIzXSBzcCA6IGZmZmY4MDAwMTFhOTNl
ODANClsgICAgMS41MzAxMjRdIHgyOTogZmZmZjgwMDAxMWE5M2U4MCB4Mjg6IDAwMDAwMDAwMDAw
MDAwMGMgDQpbICAgIDEuNTMwMTI3XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAw
MDEyMTgwMDcwIA0KWyAgICAxLjUzMDEyOV0geDI1OiBmZmZmZmUyMDFiZTBmODAwIHgyNDogZmZm
ZjgwMDAxMjE4MDAwMCANClsgICAgMS41MzAxMzFdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6
IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTMwMTMzXSB4MjE6IGZmZmY4MDAwMTE3Njg5Zjgg
eDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjUzMDEzNV0geDE5OiBmZmZmODAwMDExNjIy
MDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41MzAxMzddIHgxNzogMDAwMDAwMDAw
MDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTMwMTM5XSB4MTU6IGZmZmY4
MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjUzMDE0MV0geDEzOiBm
ZmZmODAwMDExNmQ0Y2Y1IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MzAxNDNdIHgx
MTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTMwMTQ1
XSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDMwMzA2MzMyMzAzMDMxIA0KWyAgICAxLjUz
MDE0N10geDcgOiAzMDMwMzEzMDMwMzAzMDc4IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAg
MS41MzAxNDhdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpb
ICAgIDEuNTMwMTUwXSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZm
IA0KWyAgICAxLjUzMDE1Ml0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZm
ZmZlZCANClsgICAgMS41MzAxNTRdIENhbGwgdHJhY2U6DQpbICAgIDEuNTMwMTU2XSAgaXRzX2Nw
dV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTMwMTU5XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4
LzB4OTANClsgICAgMS41MzAxNjJdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0K
WyAgICAxLjUzMDE2NF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTMw
MTY2XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTMwMTY3XSAt
LS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjVlIF0tLS0NClsgICAgMS41MzAxNzNdIEdJQ3Yz
OiBDUFUxMjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODA3ODAz
ZTAwMDANClsgICAgMS41MzAyMzhdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91
bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41MzAyNDddIFhlbjogaW5pdGlhbGl6
aW5nIGNwdTEyDQpbICAgIDEuNTMwMjcwXSBDUFUxMjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNz
b3IgMHgwMDAwMDAwMDBjIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjUzMDUxN10gRGV0ZWN0ZWQgUElQ
VCBJLWNhY2hlIG9uIENQVTEzDQpbICAgIDEuNTMwNTYzXSBHSUN2MzogQ1BVMTM6IGZvdW5kIHJl
ZGlzdHJpYnV0b3IgZCByZWdpb24gMDoweDAwMDAxMDAxMDAyZTAwMDANClsgICAgMS41MzcxODNd
IC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjUzNzE4OF0gV0FS
TklORzogQ1BVOiAxMyBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6
MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MzcxODldIE1vZHVsZXMgbGlu
a2VkIGluOg0KWyAgICAxLjUzNzE5M10gQ1BVOiAxMyBQSUQ6IDAgQ29tbTogc3dhcHBlci8xMyBU
YWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkICMx
DQpbICAgIDEuNTM3MTk1XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1U
Q08gQlRZUEU9LS0pDQpbICAgIDEuNTM3MTk3XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIy
MA0KWyAgICAxLjUzNzE5OF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41
MzcxOTldIHNwIDogZmZmZjgwMDAxMWE5YmU4MA0KWyAgICAxLjUzNzIwMF0geDI5OiBmZmZmODAw
MDExYTliZTgwIHgyODogMDAwMDAwMDAwMDAwMDAwZCANClsgICAgMS41MzcyMDJdIHgyNzogMDAw
MDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIxYTAwNzAgDQpbICAgIDEuNTM3MjA1XSB4MjU6
IGZmZmZmZTIwMWJlMGZjMDAgeDI0OiBmZmZmODAwMDEyMWEwMDAwIA0KWyAgICAxLjUzNzIwN10g
eDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41Mzcy
MDldIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEu
NTM3MjExXSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAg
ICAxLjUzNzIxM10geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS41MzcyMTVdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAw
MTAgDQpbICAgIDEuNTM3MjE3XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjUgeDEyOiAwMDAwMDAwMDAw
MDAwMDAwIA0KWyAgICAxLjUzNzIxOV0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAw
MDAwMDAwMDAwMSANClsgICAgMS41MzcyMjFdIHg5IDogZmZmZjgwMDAxMDZkNTdiMCB4OCA6IDMw
MzAzMDY1MzIzMDMwMzEgDQpbICAgIDEuNTM3MjIzXSB4NyA6IDMwMzAzMTMwMzAzMDMwNzggeDYg
OiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjUzNzIyNF0geDUgOiAwMDAwMDAwMDAwMDAwMDAw
IHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41MzcyMjZdIHgzIDogMDAwMDAwMDAwMDAw
MDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTM3MjI4XSB4MSA6IDAwMDAwMDAw
MDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjUzNzIzMV0gQ2FsbCB0cmFj
ZToNClsgICAgMS41MzcyMzJdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41Mzcy
MzVdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjUzNzIzOF0gIGNwdWhwX2lu
dm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTM3MjQwXSAgbm90aWZ5X2NwdV9zdGFy
dGluZysweGEwLzB4ZTANClsgICAgMS41MzcyNDJdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4
ZTgvMHgxOTANClsgICAgMS41MzcyNDRdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNWYg
XS0tLQ0KWyAgICAxLjUzNzI1MF0gR0lDdjM6IENQVTEzOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDc4MDNmMDAwMA0KWyAgICAxLjUzNzMwOV0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAg
ICAxLjUzNzMxOF0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTMNClsgICAgMS41MzczMzldIENQVTEz
OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMGQgWzB4NDEzZmQwYzFdDQpb
ICAgIDEuNTM3NjQ0XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTQNClsgICAgMS41Mzc2
OTNdIEdJQ3YzOiBDUFUxNDogZm91bmQgcmVkaXN0cmlidXRvciBlIHJlZ2lvbiAwOjB4MDAwMDEw
MDEwMDMwMDAwMA0KWyAgICAxLjU0NDMxNF0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0t
LS0tLS0tDQpbICAgIDEuNTQ0MzE4XSBXQVJOSU5HOiBDUFU6IDE0IFBJRDogMCBhdCBkcml2ZXJz
L2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjU0NDMxOV0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTQ0MzIzXSBDUFU6IDE0
IFBJRDogMCBDb21tOiBzd2FwcGVyLzE0IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEw
LjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQgIzENClsgICAgMS41NDQzMjVdIHBzdGF0ZTogNjAwMDAx
YzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41NDQzMjddIHBj
IDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTQ0MzI5XSBsciA6IGl0c19jcHVf
aW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjU0NDMyOV0gc3AgOiBmZmZmODAwMDExYWEzZTgwDQpb
ICAgIDEuNTQ0MzMwXSB4Mjk6IGZmZmY4MDAwMTFhYTNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDBl
IA0KWyAgICAxLjU0NDMzM10geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjFj
MDA3MCANClsgICAgMS41NDQzMzVdIHgyNTogZmZmZmZlMjAxYmVhMDAwMCB4MjQ6IGZmZmY4MDAw
MTIxYzAwMDAgDQpbICAgIDEuNTQ0MzM3XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZm
ODAwMDEwZmY5MDAwIA0KWyAgICAxLjU0NDMzOV0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDog
ZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41NDQzNDFdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4
MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTQ0MzQzXSB4MTc6IDAwMDAwMDAwMDAwMDAw
MDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU0NDM0NV0geDE1OiBmZmZmODAwMDEx
NmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41NDQzNDddIHgxMzogZmZmZjgw
MDAxMTZkNGNmNSB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTQ0MzQ5XSB4MTE6IDAw
MDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjU0NDM1MV0geDkg
OiBmZmZmODAwMDEwNmQ1N2IwIHg4IDogMzAzMDMwMzAzMzMwMzAzMSANClsgICAgMS41NDQzNTNd
IHg3IDogMzAzMDMxMzAzMDMwMzA3OCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTQ0
MzU1XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAx
LjU0NDM1N10geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsg
ICAgMS41NDQzNThdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQg
DQpbICAgIDEuNTQ0MzYxXSBDYWxsIHRyYWNlOg0KWyAgICAxLjU0NDM2Ml0gIGl0c19jcHVfaW5p
dCsweDgyNC8weGIyMA0KWyAgICAxLjU0NDM2NV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkw
DQpbICAgIDEuNTQ0MzY4XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAg
MS41NDQzNzBdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjU0NDM3Ml0g
IHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjU0NDM3M10gLS0tWyBl
bmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2MCBdLS0tDQpbICAgIDEuNTQ0Mzc5XSBHSUN2MzogQ1BV
MTQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwNzgyODAwMDAw
DQpbICAgIDEuNTQ0NDQ1XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZv
ciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTQ0NDU0XSBYZW46IGluaXRpYWxpemluZyBj
cHUxNA0KWyAgICAxLjU0NDQ3N10gQ1BVMTQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4
MDAwMDAwMDAwZSBbMHg0MTNmZDBjMV0NClsgICAgMS41NDQ4MDddIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUxNQ0KWyAgICAxLjU0NDg1N10gR0lDdjM6IENQVTE1OiBmb3VuZCByZWRpc3Ry
aWJ1dG9yIGYgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMzIwMDAwDQpbICAgIDEuNTUxNDc2XSAtLS0t
LS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41NTE0ODFdIFdBUk5JTkc6
IENQVTogMTUgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkg
aXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTUxNDgyXSBNb2R1bGVzIGxpbmtlZCBp
bjoNClsgICAgMS41NTE0ODZdIENQVTogMTUgUElEOiAwIENvbW06IHN3YXBwZXIvMTUgVGFpbnRl
ZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAg
ICAxLjU1MTQ4OF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJU
WVBFPS0tKQ0KWyAgICAxLjU1MTQ5MF0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS41NTE0OTFdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTUxNDky
XSBzcCA6IGZmZmY4MDAwMTFhYWJlODANClsgICAgMS41NTE0OTNdIHgyOTogZmZmZjgwMDAxMWFh
YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMGYgDQpbICAgIDEuNTUxNDk1XSB4Mjc6IDAwMDAwMDAw
MDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMWUwMDcwIA0KWyAgICAxLjU1MTQ5OF0geDI1OiBmZmZm
ZmUyMDFiZWEwNDAwIHgyNDogZmZmZjgwMDAxMjFlMDAwMCANClsgICAgMS41NTE0OTldIHgyMzog
ZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTUxNTAxXSB4
MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjU1MTUw
NF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41
NTE1MDVdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAg
IDEuNTUxNTA3XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0K
WyAgICAxLjU1MTUwOV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y1IHgxMjogMDAwMDAwMDAwMDAwMDAw
MCANClsgICAgMS41NTE1MTFdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAw
MDAwMDEgDQpbICAgIDEuNTUxNTEzXSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDMwMzAz
MjMzMzAzMDMxIA0KWyAgICAxLjU1MTUxNV0geDcgOiAzMDMwMzEzMDMwMzAzMDc4IHg2IDogMDAw
MDAwMDAwMDAwMDAwMyANClsgICAgMS41NTE1MTddIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6
IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTUxNTE5XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAg
eDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjU1MTUyMV0geDEgOiAwMDAwMDAwMDAwMDEw
MDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41NTE1MjNdIENhbGwgdHJhY2U6DQpb
ICAgIDEuNTUxNTI1XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTUxNTI4XSAg
Z2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41NTE1MzBdICBjcHVocF9pbnZva2Vf
Y2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU1MTUzMl0gIG5vdGlmeV9jcHVfc3RhcnRpbmcr
MHhhMC8weGUwDQpbICAgIDEuNTUxNTM1XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4
MTkwDQpbICAgIDEuNTUxNTM2XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjYxIF0tLS0N
ClsgICAgMS41NTE1NDJdIEdJQ3YzOiBDUFUxNTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5n
IHRhYmxlIEAweDAwMDAwODA3ODI4MTAwMDANClsgICAgMS41NTE2MDFdIGFyY2hfdGltZXI6IEVu
YWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41
NTE2MDldIFhlbjogaW5pdGlhbGl6aW5nIGNwdTE1DQpbICAgIDEuNTUxNjMxXSBDUFUxNTogQm9v
dGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDBmIFsweDQxM2ZkMGMxXQ0KWyAgICAx
LjU1MTk4Ml0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE2DQpbICAgIDEuNTUyMDM1XSBH
SUN2MzogQ1BVMTY6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDM0MDAwMA0KWyAgICAxLjU1ODY1NF0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0t
LS0tDQpbICAgIDEuNTU4NjU5XSBXQVJOSU5HOiBDUFU6IDE2IFBJRDogMCBhdCBkcml2ZXJzL2ly
cWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAg
ICAxLjU1ODY2MF0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTU4NjY0XSBDUFU6IDE2IFBJ
RDogMCBDb21tOiBzd2FwcGVyLzE2IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3
LWFtcGVyZS1sdHMtc3RhbmRhcmQgIzENClsgICAgMS41NTg2NjZdIHBzdGF0ZTogNjAwMDAxYzUg
KG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41NTg2NjhdIHBjIDog
aXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTU4NjY5XSBsciA6IGl0c19jcHVfaW5p
dCsweDgyMC8weGIyMA0KWyAgICAxLjU1ODY3MF0gc3AgOiBmZmZmODAwMDExYWIzZTgwDQpbICAg
IDEuNTU4NjcxXSB4Mjk6IGZmZmY4MDAwMTFhYjNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDEwIA0K
WyAgICAxLjU1ODY3NF0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjIwMDA3
MCANClsgICAgMS41NTg2NzZdIHgyNTogZmZmZmZlMjAxYmVhMDgwMCB4MjQ6IGZmZmY4MDAwMTIy
MDAwMDAgDQpbICAgIDEuNTU4Njc4XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAw
MDEwZmY5MDAwIA0KWyAgICAxLjU1ODY4MF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZm
ZjgwMDAxMTYyMjM1MCANClsgICAgMS41NTg2ODJdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6
IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTU4Njg0XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAg
eDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU1ODY4Nl0geDE1OiBmZmZmODAwMDExNmQ1
MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41NTg2ODhdIHgxMzogZmZmZjgwMDAx
MTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTU4Njg5XSB4MTE6IDAwMDAw
MDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjU1ODY5MV0geDkgOiBm
ZmZmODAwMDEwNmQ1N2IwIHg4IDogMzAzNDMzMzAzMDMxMzAzMCANClsgICAgMS41NTg2OTNdIHg3
IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTU4Njk1
XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjU1
ODY5N10geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAg
MS41NTg2OTldIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpb
ICAgIDEuNTU4NzAxXSBDYWxsIHRyYWNlOg0KWyAgICAxLjU1ODcwMl0gIGl0c19jcHVfaW5pdCsw
eDgyNC8weGIyMA0KWyAgICAxLjU1ODcwNV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpb
ICAgIDEuNTU4NzA3XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41
NTg3MDldICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjU1ODcxMl0gIHNl
Y29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjU1ODcxM10gLS0tWyBlbmQg
dHJhY2UgZjY4NzI4YTBkMzA1M2I2MiBdLS0tDQpbICAgIDEuNTU4NzE5XSBHSUN2MzogQ1BVMTY6
IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwNzgyODIwMDAwDQpb
ICAgIDEuNTU4Nzg1XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTU4Nzk0XSBYZW46IGluaXRpYWxpemluZyBjcHUx
Ng0KWyAgICAxLjU1ODgxN10gQ1BVMTY6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAw
MDAwMDEwMCBbMHg0MTNmZDBjMV0NClsgICAgMS41NTkwNjZdIERldGVjdGVkIFBJUFQgSS1jYWNo
ZSBvbiBDUFUxNw0KWyAgICAxLjU1OTEyMV0gR0lDdjM6IENQVTE3OiBmb3VuZCByZWRpc3RyaWJ1
dG9yIDEwMSByZWdpb24gMDoweDAwMDAxMDAxMDAzNjAwMDANClsgICAgMS41NjU3NDFdIC0tLS0t
LS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjU2NTc0NV0gV0FSTklORzog
Q1BVOiAxNyBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBp
dHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NjU3NDZdIE1vZHVsZXMgbGlua2VkIGlu
Og0KWyAgICAxLjU2NTc1MF0gQ1BVOiAxNyBQSUQ6IDAgQ29tbTogc3dhcHBlci8xNyBUYWludGVk
OiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkICMxDQpbICAg
IDEuNTY1NzUzXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZ
UEU9LS0pDQpbICAgIDEuNTY1NzU0XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAg
ICAxLjU2NTc1Nl0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41NjU3NTdd
IHNwIDogZmZmZjgwMDAxMWFiYmU4MA0KWyAgICAxLjU2NTc1OF0geDI5OiBmZmZmODAwMDExYWJi
ZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxMSANClsgICAgMS41NjU3NjFdIHgyNzogMDAwMDAwMDAw
MDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIyMjAwNzAgDQpbICAgIDEuNTY1NzYzXSB4MjU6IGZmZmZm
ZTIwMWJlYTBjMDAgeDI0OiBmZmZmODAwMDEyMjIwMDAwIA0KWyAgICAxLjU2NTc2NV0geDIzOiBm
ZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41NjU3NjddIHgy
MTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTY1NzY5
XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjU2
NTc3MV0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAg
MS41NjU3NzNdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpb
ICAgIDEuNTY1Nzc1XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAw
IA0KWyAgICAxLjU2NTc3Nl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAw
MDAwMSANClsgICAgMS41NjU3NzhdIHg5IDogZmZmZjgwMDAxMDZkNTdiMCB4OCA6IDMwMzYzMzMw
MzAzMTMwMzAgDQpbICAgIDEuNTY1NzgwXSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAw
MDAwMDAwMDAwMDAzIA0KWyAgICAxLjU2NTc4Ml0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDog
ZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41NjU3ODRdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4
MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTY1Nzg2XSB4MSA6IDAwMDAwMDAwMDAwMTAw
MDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjU2NTc4OF0gQ2FsbCB0cmFjZToNClsg
ICAgMS41NjU3OTBdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NjU3OTNdICBn
aWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjU2NTc5NV0gIGNwdWhwX2ludm9rZV9j
YWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTY1Nzk4XSAgbm90aWZ5X2NwdV9zdGFydGluZysw
eGEwLzB4ZTANClsgICAgMS41NjU4MDBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgx
OTANClsgICAgMS41NjU4MDFdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNjMgXS0tLQ0K
WyAgICAxLjU2NTgwOF0gR0lDdjM6IENQVTE3OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcg
dGFibGUgQDB4MDAwMDA4MDc4MjgzMDAwMA0KWyAgICAxLjU2NTg2N10gYXJjaF90aW1lcjogRW5h
YmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjU2
NTg3Nl0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTcNClsgICAgMS41NjU4OThdIENQVTE3OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMDEgWzB4NDEzZmQwYzFdDQpbICAgIDEu
NTY2MjI3XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTgNClsgICAgMS41NjYyODNdIEdJ
Q3YzOiBDUFUxODogZm91bmQgcmVkaXN0cmlidXRvciAxMDIgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
MzgwMDAwDQpbICAgIDEuNTcyOTA0XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0t
LS0NClsgICAgMS41NzI5MDldIFdBUk5JTkc6IENQVTogMTggUElEOiAwIGF0IGRyaXZlcnMvaXJx
Y2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAg
IDEuNTcyOTA5XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41NzI5MTNdIENQVTogMTggUElE
OiAwIENvbW06IHN3YXBwZXIvMTggVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjct
YW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjU3MjkxNV0gcHN0YXRlOiA2MDAwMDFjNSAo
blpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjU3MjkxN10gcGMgOiBp
dHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NzI5MTldIGxyIDogaXRzX2NwdV9pbml0
KzB4ODIwLzB4YjIwDQpbICAgIDEuNTcyOTE5XSBzcCA6IGZmZmY4MDAwMTFhYzNlODANClsgICAg
MS41NzI5MjBdIHgyOTogZmZmZjgwMDAxMWFjM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTIgDQpb
ICAgIDEuNTcyOTIyXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMjQwMDcw
IA0KWyAgICAxLjU3MjkyNV0geDI1OiBmZmZmZmUyMDFiZWExMDAwIHgyNDogZmZmZjgwMDAxMjI0
MDAwMCANClsgICAgMS41NzI5MjZdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAw
MTBmZjkwMDAgDQpbICAgIDEuNTcyOTI4XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZm
ODAwMDExNjIyMzUwIA0KWyAgICAxLjU3MjkzMF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODog
ZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41NzI5MzJdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4
MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTcyOTM0XSB4MTU6IGZmZmY4MDAwMTE2ZDUw
YTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjU3MjkzNl0geDEzOiBmZmZmODAwMDEx
NmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41NzI5MzhdIHgxMTogMDAwMDAw
MDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTcyOTQwXSB4OSA6IGZm
ZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDM4MzMzMDMwMzEzMDMwIA0KWyAgICAxLjU3Mjk0Ml0geDcg
OiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41NzI5NDNd
IHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTcy
OTQ1XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAx
LjU3Mjk0N10geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsg
ICAgMS41NzI5NDldIENhbGwgdHJhY2U6DQpbICAgIDEuNTcyOTUxXSAgaXRzX2NwdV9pbml0KzB4
ODI0LzB4YjIwDQpbICAgIDEuNTcyOTUzXSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsg
ICAgMS41NzI5NTZdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU3
Mjk1OF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTcyOTYwXSAgc2Vj
b25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTcyOTYyXSAtLS1bIGVuZCB0
cmFjZSBmNjg3MjhhMGQzMDUzYjY0IF0tLS0NClsgICAgMS41NzI5NjhdIEdJQ3YzOiBDUFUxODog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODA3ODI4NDAwMDANClsg
ICAgMS41NzMwMzVdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41NzMwNDNdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTE4
DQpbICAgIDEuNTczMDY4XSBDUFUxODogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAw
MDAwMTAyIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjU3MzQwNl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hl
IG9uIENQVTE5DQpbICAgIDEuNTczNDY0XSBHSUN2MzogQ1BVMTk6IGZvdW5kIHJlZGlzdHJpYnV0
b3IgMTAzIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDNhMDAwMA0KWyAgICAxLjU4MDA4NF0gLS0tLS0t
LS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTgwMDg5XSBXQVJOSU5HOiBD
UFU6IDE5IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU4MDA4OV0gTW9kdWxlcyBsaW5rZWQgaW46
DQpbICAgIDEuNTgwMDk0XSBDUFU6IDE5IFBJRDogMCBDb21tOiBzd2FwcGVyLzE5IFRhaW50ZWQ6
IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQgIzENClsgICAg
MS41ODAwOTZdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQ
RT0tLSkNClsgICAgMS41ODAwOTddIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAg
IDEuNTgwMDk5XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjU4MDEwMF0g
c3AgOiBmZmZmODAwMDExYWNiZTgwDQpbICAgIDEuNTgwMTAxXSB4Mjk6IGZmZmY4MDAwMTFhY2Jl
ODAgeDI4OiAwMDAwMDAwMDAwMDAwMDEzIA0KWyAgICAxLjU4MDEwM10geDI3OiAwMDAwMDAwMDAw
MDAwMDAwIHgyNjogZmZmZjgwMDAxMjI2MDA3MCANClsgICAgMS41ODAxMDVdIHgyNTogZmZmZmZl
MjAxYmVhMTQwMCB4MjQ6IGZmZmY4MDAwMTIyNjAwMDAgDQpbICAgIDEuNTgwMTA3XSB4MjM6IGZm
ZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjU4MDEwOV0geDIx
OiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41ODAxMTFd
IHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTgw
MTEzXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAx
LjU4MDExNV0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsg
ICAgMS41ODAxMTddIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAg
DQpbICAgIDEuNTgwMTE5XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAw
MDAxIA0KWyAgICAxLjU4MDEyMF0geDkgOiBmZmZmODAwMDEwNmQ1N2IwIHg4IDogMzA2MTMzMzAz
MDMxMzAzMCANClsgICAgMS41ODAxMjJdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAw
MDAwMDAwMDAwMDMgDQpbICAgIDEuNTgwMTI0XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBm
ZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjU4MDEyNl0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgy
IDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS41ODAxMjhdIHgxIDogMDAwMDAwMDAwMDAxMDAw
MCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTgwMTMwXSBDYWxsIHRyYWNlOg0KWyAg
ICAxLjU4MDEzMl0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU4MDEzNV0gIGdp
Y19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTgwMTM3XSAgY3B1aHBfaW52b2tlX2Nh
bGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41ODAxNDBdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4
YTAvMHhlMA0KWyAgICAxLjU4MDE0Ml0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5
MA0KWyAgICAxLjU4MDE0NF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2NSBdLS0tDQpb
ICAgIDEuNTgwMTUwXSBHSUN2MzogQ1BVMTk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0
YWJsZSBAMHgwMDAwMDgwNzgyODUwMDAwDQpbICAgIDEuNTgwMjA5XSBhcmNoX3RpbWVyOiBFbmFi
bGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTgw
MjE3XSBYZW46IGluaXRpYWxpemluZyBjcHUxOQ0KWyAgICAxLjU4MDI0MF0gQ1BVMTk6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwMyBbMHg0MTNmZDBjMV0NClsgICAgMS41
ODA1ODldIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMA0KWyAgICAxLjU4MDY1MF0gR0lD
djM6IENQVTIwOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwNCByZWdpb24gMDoweDAwMDAxMDAxMDAz
YzAwMDANClsgICAgMS41ODcyNzBdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0t
LQ0KWyAgICAxLjU4NzI3NV0gV0FSTklORzogQ1BVOiAyMCBQSUQ6IDAgYXQgZHJpdmVycy9pcnFj
aGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS41ODcyNzZdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjU4NzI4MF0gQ1BVOiAyMCBQSUQ6
IDAgQ29tbTogc3dhcHBlci8yMCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1h
bXBlcmUtbHRzLXN0YW5kYXJkICMxDQpbICAgIDEuNTg3MjgyXSBwc3RhdGU6IDYwMDAwMWM1IChu
WkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNTg3Mjg0XSBwYyA6IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU4NzI4NV0gbHIgOiBpdHNfY3B1X2luaXQr
MHg4MjAvMHhiMjANClsgICAgMS41ODcyODZdIHNwIDogZmZmZjgwMDAxMWFkM2U4MA0KWyAgICAx
LjU4NzI4N10geDI5OiBmZmZmODAwMDExYWQzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxNCANClsg
ICAgMS41ODcyODldIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIyODAwNzAg
DQpbICAgIDEuNTg3MjkxXSB4MjU6IGZmZmZmZTIwMWJlYTE4MDAgeDI0OiBmZmZmODAwMDEyMjgw
MDAwIA0KWyAgICAxLjU4NzI5M10geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAx
MGZmOTAwMCANClsgICAgMS41ODcyOTVdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4
MDAwMTE2MjIzNTAgDQpbICAgIDEuNTg3Mjk3XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBm
ZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjU4NzI5OV0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgx
NjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41ODczMDFdIHgxNTogZmZmZjgwMDAxMTZkNTBh
MCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTg3MzAzXSB4MTM6IGZmZmY4MDAwMTE2
ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU4NzMwNF0geDExOiAwMDAwMDAw
MDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41ODczMDZdIHg5IDogZmZm
ZjgwMDAxMDZkNTdiMCB4OCA6IDMwNjMzMzMwMzAzMTMwMzAgDQpbICAgIDEuNTg3MzA4XSB4NyA6
IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjU4NzMxMF0g
eDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41ODcz
MTJdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEu
NTg3MzE0XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAg
ICAxLjU4NzMxNl0gQ2FsbCB0cmFjZToNClsgICAgMS41ODczMThdICBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS41ODczMjBdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAg
ICAxLjU4NzMyM10gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTg3
MzI1XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS41ODczMjddICBzZWNv
bmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41ODczMjldIC0tLVsgZW5kIHRy
YWNlIGY2ODcyOGEwZDMwNTNiNjYgXS0tLQ0KWyAgICAxLjU4NzMzNF0gR0lDdjM6IENQVTIwOiB1
c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDc4Mjg2MDAwMA0KWyAg
ICAxLjU4NzM5OV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjU4NzQwOF0gWGVuOiBpbml0aWFsaXppbmcgY3B1MjAN
ClsgICAgMS41ODc0MzNdIENQVTIwOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAw
MDAxMDQgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTg3NzU1XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUg
b24gQ1BVMjENClsgICAgMS41ODc4MTddIEdJQ3YzOiBDUFUyMTogZm91bmQgcmVkaXN0cmlidXRv
ciAxMDUgcmVnaW9uIDA6MHgwMDAwMTAwMTAwM2UwMDAwDQpbICAgIDEuNTk0NDM4XSAtLS0tLS0t
LS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41OTQ0NDNdIFdBUk5JTkc6IENQ
VTogMjEgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRz
X2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTk0NDQ0XSBNb2R1bGVzIGxpbmtlZCBpbjoN
ClsgICAgMS41OTQ0NDhdIENQVTogMjEgUElEOiAwIENvbW06IHN3YXBwZXIvMjEgVGFpbnRlZDog
RyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAx
LjU5NDQ1MF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBF
PS0tKQ0KWyAgICAxLjU5NDQ1Ml0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS41OTQ0NTNdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTk0NDU0XSBz
cCA6IGZmZmY4MDAwMTFhZGJlODANClsgICAgMS41OTQ0NTVdIHgyOTogZmZmZjgwMDAxMWFkYmU4
MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTUgDQpbICAgIDEuNTk0NDU4XSB4Mjc6IDAwMDAwMDAwMDAw
MDAwMDAgeDI2OiBmZmZmODAwMDEyMmEwMDcwIA0KWyAgICAxLjU5NDQ2MF0geDI1OiBmZmZmZmUy
MDFiZWExYzAwIHgyNDogZmZmZjgwMDAxMjJhMDAwMCANClsgICAgMS41OTQ0NjJdIHgyMzogZmZm
ZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTk0NDY0XSB4MjE6
IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjU5NDQ2Nl0g
eDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41OTQ0
NjhdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEu
NTk0NDcwXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAg
ICAxLjU5NDQ3MV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS41OTQ0NzNdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAw
MDEgDQpbICAgIDEuNTk0NDc1XSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDY1MzMzMDMw
MzEzMDMwIA0KWyAgICAxLjU5NDQ3N10geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAw
MDAwMDAwMDAwMyANClsgICAgMS41OTQ0NzldIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZm
ZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTk0NDgxXSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIg
OiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjU5NDQ4M10geDEgOiAwMDAwMDAwMDAwMDEwMDAw
IHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41OTQ0ODVdIENhbGwgdHJhY2U6DQpbICAg
IDEuNTk0NDg3XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTk0NDkwXSAgZ2lj
X3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41OTQ0OTJdICBjcHVocF9pbnZva2VfY2Fs
bGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU5NDQ5NF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhh
MC8weGUwDQpbICAgIDEuNTk0NDk3XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkw
DQpbICAgIDEuNTk0NDk4XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjY3IF0tLS0NClsg
ICAgMS41OTQ1MDRdIEdJQ3YzOiBDUFUyMTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRh
YmxlIEAweDAwMDAwODA3ODI4NzAwMDANClsgICAgMS41OTQ1NjNdIGFyY2hfdGltZXI6IEVuYWJs
aW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41OTQ1
NzFdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTIxDQpbICAgIDEuNTk0NTkzXSBDUFUyMTogQm9vdGVk
IHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTA1IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjU5
NDg0M10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTIyDQpbICAgIDEuNTk0OTA5XSBHSUN2
MzogQ1BVMjI6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTA2IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDQw
MDAwMA0KWyAgICAxLjYwMTUzMV0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0t
DQpbICAgIDEuNjAxNTM1XSBXQVJOSU5HOiBDUFU6IDIyIFBJRDogMCBhdCBkcml2ZXJzL2lycWNo
aXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjYwMTUzNl0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNjAxNTQwXSBDUFU6IDIyIFBJRDog
MCBDb21tOiBzd2FwcGVyLzIyIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFt
cGVyZS1sdHMtc3RhbmRhcmQgIzENClsgICAgMS42MDE1NDJdIHBzdGF0ZTogNjAwMDAxYzUgKG5a
Q3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS42MDE1NDVdIHBjIDogaXRz
X2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjAxNTQ2XSBsciA6IGl0c19jcHVfaW5pdCsw
eDgyMC8weGIyMA0KWyAgICAxLjYwMTU0N10gc3AgOiBmZmZmODAwMDExYWUzZTgwDQpbICAgIDEu
NjAxNTQ4XSB4Mjk6IGZmZmY4MDAwMTFhZTNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDE2IA0KWyAg
ICAxLjYwMTU1MF0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjJjMDA3MCAN
ClsgICAgMS42MDE1NTNdIHgyNTogZmZmZmZlMjAxYmVhMjAwMCB4MjQ6IGZmZmY4MDAwMTIyYzAw
MDAgDQpbICAgIDEuNjAxNTU1XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEw
ZmY5MDAwIA0KWyAgICAxLjYwMTU1N10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgw
MDAxMTYyMjM1MCANClsgICAgMS42MDE1NTldIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZm
ZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjAxNTYwXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2
OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYwMTU2Ml0geDE1OiBmZmZmODAwMDExNmQ1MGEw
IHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS42MDE1NjRdIHgxMzogZmZmZjgwMDAxMTZk
NGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjAxNTY2XSB4MTE6IDAwMDAwMDAw
MDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjYwMTU2OF0geDkgOiBmZmZm
ODAwMDEwNmQ1N2IwIHg4IDogMzAzMDM0MzAzMDMxMzAzMCANClsgICAgMS42MDE1NzBdIHg3IDog
MzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjAxNTcyXSB4
NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjYwMTU3
NF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42
MDE1NzZdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAg
IDEuNjAxNTc4XSBDYWxsIHRyYWNlOg0KWyAgICAxLjYwMTU4MF0gIGl0c19jcHVfaW5pdCsweDgy
NC8weGIyMA0KWyAgICAxLjYwMTU4Ml0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAg
IDEuNjAxNTg1XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42MDE1
ODddICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjYwMTU4OV0gIHNlY29u
ZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjYwMTU5MV0gLS0tWyBlbmQgdHJh
Y2UgZjY4NzI4YTBkMzA1M2I2OCBdLS0tDQpbICAgIDEuNjAxNTk2XSBHSUN2MzogQ1BVMjI6IHVz
aW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwNzgyODgwMDAwDQpbICAg
IDEuNjAxNjY0XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0g
ZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjAxNjczXSBYZW46IGluaXRpYWxpemluZyBjcHUyMg0K
WyAgICAxLjYwMTY5OV0gQ1BVMjI6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAw
MDEwNiBbMHg0MTNmZDBjMV0NClsgICAgMS42MDIwMjVdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBv
biBDUFUyMw0KWyAgICAxLjYwMjA5MF0gR0lDdjM6IENQVTIzOiBmb3VuZCByZWRpc3RyaWJ1dG9y
IDEwNyByZWdpb24gMDoweDAwMDAxMDAxMDA0MjAwMDANClsgICAgMS42MDg3MTFdIC0tLS0tLS0t
LS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjYwODcxNl0gV0FSTklORzogQ1BV
OiAyMyBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MDg3MTddIE1vZHVsZXMgbGlua2VkIGluOg0K
WyAgICAxLjYwODcyMV0gQ1BVOiAyMyBQSUQ6IDAgQ29tbTogc3dhcHBlci8yMyBUYWludGVkOiBH
ICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkICMxDQpbICAgIDEu
NjA4NzIzXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9
LS0pDQpbICAgIDEuNjA4NzI1XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjYwODcyN10gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS42MDg3MjddIHNw
IDogZmZmZjgwMDAxMWFlYmU4MA0KWyAgICAxLjYwODcyOF0geDI5OiBmZmZmODAwMDExYWViZTgw
IHgyODogMDAwMDAwMDAwMDAwMDAxNyANClsgICAgMS42MDg3MzFdIHgyNzogMDAwMDAwMDAwMDAw
MDAwMCB4MjY6IGZmZmY4MDAwMTIyZTAwNzAgDQpbICAgIDEuNjA4NzMzXSB4MjU6IGZmZmZmZTIw
MWJlYTI0MDAgeDI0OiBmZmZmODAwMDEyMmUwMDAwIA0KWyAgICAxLjYwODczNV0geDIzOiBmZmZm
ODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS42MDg3MzddIHgyMTog
ZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNjA4NzM5XSB4
MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjYwODc0
MV0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42
MDg3NDJdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAg
IDEuNjA4NzQ0XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0K
WyAgICAxLjYwODc0Nl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAw
MSANClsgICAgMS42MDg3NDhdIHg5IDogZmZmZjgwMDAxMDZkNTdiMCB4OCA6IDMwMzIzNDMwMzAz
MTMwMzAgDQpbICAgIDEuNjA4NzUwXSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAw
MDAwMDAwMDAzIA0KWyAgICAxLjYwODc1Ml0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZm
ZmZkZmZmZmUwMDAwMCANClsgICAgMS42MDg3NTRdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6
IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjA4NzU2XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAg
eDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjYwODc1OF0gQ2FsbCB0cmFjZToNClsgICAg
MS42MDg3NjBdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MDg3NjNdICBnaWNf
c3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjYwODc2Nl0gIGNwdWhwX2ludm9rZV9jYWxs
YmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjA4NzY4XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEw
LzB4ZTANClsgICAgMS42MDg3NzBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTAN
ClsgICAgMS42MDg3NzJdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNjkgXS0tLQ0KWyAg
ICAxLjYwODc3N10gR0lDdjM6IENQVTIzOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFi
bGUgQDB4MDAwMDA4MDc4Mjg5MDAwMA0KWyAgICAxLjYwODgzN10gYXJjaF90aW1lcjogRW5hYmxp
bmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjYwODg0
NV0gWGVuOiBpbml0aWFsaXppbmcgY3B1MjMNClsgICAgMS42MDg4NjhdIENQVTIzOiBCb290ZWQg
c2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMDcgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjA5
MjA3XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjQNClsgICAgMS42MDkyNzZdIEdJQ3Yz
OiBDUFUyNDogZm91bmQgcmVkaXN0cmlidXRvciAxMDggcmVnaW9uIDA6MHgwMDAwMTAwMTAwNDQw
MDAwDQpbICAgIDEuNjE1ODk3XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0N
ClsgICAgMS42MTU5MDJdIFdBUk5JTkc6IENQVTogMjQgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hp
cC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEu
NjE1OTAzXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS42MTU5MDddIENQVTogMjQgUElEOiAw
IENvbW06IHN3YXBwZXIvMjQgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1w
ZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjYxNTkwOV0gcHN0YXRlOiA2MDAwMDFjNSAoblpD
diBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjYxNTkxMF0gcGMgOiBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MTU5MTJdIGxyIDogaXRzX2NwdV9pbml0KzB4
ODIwLzB4YjIwDQpbICAgIDEuNjE1OTEzXSBzcCA6IGZmZmY4MDAwMTFhZjNlODANClsgICAgMS42
MTU5MTRdIHgyOTogZmZmZjgwMDAxMWFmM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTggDQpbICAg
IDEuNjE1OTE2XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMzAwMDcwIA0K
WyAgICAxLjYxNTkxOF0geDI1OiBmZmZmZmUyMDFiZWEyODAwIHgyNDogZmZmZjgwMDAxMjMwMDAw
MCANClsgICAgMS42MTU5MjBdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBm
ZjkwMDAgDQpbICAgIDEuNjE1OTIyXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAw
MDExNjIyMzUwIA0KWyAgICAxLjYxNTkyNF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZm
ZmZmZmZmZmZmZmZmZiANClsgICAgMS42MTU5MjZdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6
IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjE1OTI4XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAg
eDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjYxNTkzMF0geDEzOiBmZmZmODAwMDExNmQ0
Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42MTU5MzJdIHgxMTogMDAwMDAwMDAw
MDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjE1OTM0XSB4OSA6IGZmZmY4
MDAwMTA2ZDU3YjAgeDggOiAzMDM0MzQzMDMwMzEzMDMwIA0KWyAgICAxLjYxNTkzNl0geDcgOiAz
MTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS42MTU5MzhdIHg1
IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNjE1OTQw
XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjYx
NTk0Ml0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAg
MS42MTU5NDRdIENhbGwgdHJhY2U6DQpbICAgIDEuNjE1OTQ2XSAgaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDEuNjE1OTQ4XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAg
MS42MTU5NTFdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjYxNTk1
M10gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNjE1OTU1XSAgc2Vjb25k
YXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNjE1OTU2XSAtLS1bIGVuZCB0cmFj
ZSBmNjg3MjhhMGQzMDUzYjZhIF0tLS0NClsgICAgMS42MTU5NjJdIEdJQ3YzOiBDUFUyNDogdXNp
bmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODA3ODI4YTAwMDANClsgICAg
MS42MTYwMzBdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBl
cnJhdHVtIDE0MTgwNDANClsgICAgMS42MTYwMzhdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTI0DQpb
ICAgIDEuNjE2MDY1XSBDUFUyNDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAw
MTA4IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjYxNjQwM10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9u
IENQVTI1DQpbICAgIDEuNjE2NDczXSBHSUN2MzogQ1BVMjU6IGZvdW5kIHJlZGlzdHJpYnV0b3Ig
MTA5IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDQ2MDAwMA0KWyAgICAxLjYyMzA5NF0gLS0tLS0tLS0t
LS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNjIzMDk5XSBXQVJOSU5HOiBDUFU6
IDI1IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYyMzEwMF0gTW9kdWxlcyBsaW5rZWQgaW46DQpb
ICAgIDEuNjIzMTA0XSBDUFU6IDI1IFBJRDogMCBDb21tOiBzd2FwcGVyLzI1IFRhaW50ZWQ6IEcg
ICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQgIzENClsgICAgMS42
MjMxMDZdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0t
LSkNClsgICAgMS42MjMxMDhdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEu
NjIzMTA5XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjYyMzExMF0gc3Ag
OiBmZmZmODAwMDExYWZiZTgwDQpbICAgIDEuNjIzMTExXSB4Mjk6IGZmZmY4MDAwMTFhZmJlODAg
eDI4OiAwMDAwMDAwMDAwMDAwMDE5IA0KWyAgICAxLjYyMzExNF0geDI3OiAwMDAwMDAwMDAwMDAw
MDAwIHgyNjogZmZmZjgwMDAxMjMyMDA3MCANClsgICAgMS42MjMxMTZdIHgyNTogZmZmZmZlMjAx
YmVhMmMwMCB4MjQ6IGZmZmY4MDAwMTIzMjAwMDAgDQpbICAgIDEuNjIzMTE4XSB4MjM6IGZmZmY4
MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjYyMzEyMF0geDIxOiBm
ZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42MjMxMjJdIHgx
OTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjIzMTI0
XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYy
MzEyNl0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAg
MS42MjMxMjhdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpb
ICAgIDEuNjIzMTMwXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAx
IA0KWyAgICAxLjYyMzEzMl0geDkgOiBmZmZmODAwMDEwNmQ1N2IwIHg4IDogMzAzNjM0MzAzMDMx
MzAzMCANClsgICAgMS42MjMxMzRdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAw
MDAwMDAwMDMgDQpbICAgIDEuNjIzMTM2XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZm
ZmRmZmZmZTAwMDAwIA0KWyAgICAxLjYyMzEzN10geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDog
MDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42MjMxMzldIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4
MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNjIzMTQxXSBDYWxsIHRyYWNlOg0KWyAgICAx
LjYyMzE0M10gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYyMzE0Nl0gIGdpY19z
dGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNjIzMTQ5XSAgY3B1aHBfaW52b2tlX2NhbGxi
YWNrKzB4YTQvMHg0NjANClsgICAgMS42MjMxNTFdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAv
MHhlMA0KWyAgICAxLjYyMzE1M10gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0K
WyAgICAxLjYyMzE1NV0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2YiBdLS0tDQpbICAg
IDEuNjIzMTYxXSBHSUN2MzogQ1BVMjU6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwNzgyOGIwMDAwDQpbICAgIDEuNjIzMjIwXSBhcmNoX3RpbWVyOiBFbmFibGlu
ZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjIzMjI4
XSBYZW46IGluaXRpYWxpemluZyBjcHUyNQ0KWyAgICAxLjYyMzI1MV0gQ1BVMjU6IEJvb3RlZCBz
ZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwOSBbMHg0MTNmZDBjMV0NClsgICAgMS42MjM1
MDFdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyNg0KWyAgICAxLjYyMzU3M10gR0lDdjM6
IENQVTI2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwYSByZWdpb24gMDoweDAwMDAxMDAxMDA0ODAw
MDANClsgICAgMS42MzAxOTVdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0K
WyAgICAxLjYzMDIwMF0gV0FSTklORzogQ1BVOiAyNiBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlw
L2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42
MzAyMDFdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjYzMDIwNV0gQ1BVOiAyNiBQSUQ6IDAg
Q29tbTogc3dhcHBlci8yNiBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBl
cmUtbHRzLXN0YW5kYXJkICMxDQpbICAgIDEuNjMwMjA3XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2
IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNjMwMjA5XSBwYyA6IGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYzMDIxMF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4
MjAvMHhiMjANClsgICAgMS42MzAyMTFdIHNwIDogZmZmZjgwMDAxMWIwM2U4MA0KWyAgICAxLjYz
MDIxMl0geDI5OiBmZmZmODAwMDExYjAzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxYSANClsgICAg
MS42MzAyMTVdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIzNDAwNzAgDQpb
ICAgIDEuNjMwMjE3XSB4MjU6IGZmZmZmZTIwMWJlYTMwMDAgeDI0OiBmZmZmODAwMDEyMzQwMDAw
IA0KWyAgICAxLjYzMDIxOV0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZm
OTAwMCANClsgICAgMS42MzAyMjFdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAw
MTE2MjIzNTAgDQpbICAgIDEuNjMwMjIzXSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZm
ZmZmZmZmZmZmZmZmIA0KWyAgICAxLjYzMDIyNV0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjog
MDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42MzAyMjddIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4
MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNjMwMjI4XSB4MTM6IGZmZmY4MDAwMTE2ZDRj
ZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYzMDIzMF0geDExOiAwMDAwMDAwMDAw
MDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS42MzAyMzJdIHg5IDogZmZmZjgw
MDAxMDZkNTdiMCB4OCA6IDMwMzgzNDMwMzAzMTMwMzAgDQpbICAgIDEuNjMwMjM0XSB4NyA6IDMx
MzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjYzMDIzNl0geDUg
OiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS42MzAyMzhd
IHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjMw
MjQwXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAx
LjYzMDI0Ml0gQ2FsbCB0cmFjZToNClsgICAgMS42MzAyNDRdICBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMS42MzAyNDZdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAx
LjYzMDI0OV0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjMwMjUx
XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS42MzAyNTRdICBzZWNvbmRh
cnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS42MzAyNTVdIC0tLVsgZW5kIHRyYWNl
IGY2ODcyOGEwZDMwNTNiNmMgXS0tLQ0KWyAgICAxLjYzMDI2MV0gR0lDdjM6IENQVTI2OiB1c2lu
ZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDc4MjhjMDAwMA0KWyAgICAx
LjYzMDMyN10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVy
cmF0dW0gMTQxODA0MA0KWyAgICAxLjYzMDMzN10gWGVuOiBpbml0aWFsaXppbmcgY3B1MjYNClsg
ICAgMS42MzAzNjNdIENQVTI2OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAx
MGEgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjMwNjYyXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24g
Q1BVMjcNClsgICAgMS42MzA3MzZdIEdJQ3YzOiBDUFUyNzogZm91bmQgcmVkaXN0cmlidXRvciAx
MGIgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNGEwMDAwDQpbICAgIDEuNjM3MzU4XSAtLS0tLS0tLS0t
LS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS42MzczNjNdIFdBUk5JTkc6IENQVTog
MjcgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2Nw
dV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjM3MzY0XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsg
ICAgMS42MzczNjhdIENQVTogMjcgUElEOiAwIENvbW06IHN3YXBwZXIvMjcgVGFpbnRlZDogRyAg
ICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjYz
NzM3MF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0t
KQ0KWyAgICAxLjYzNzM3Ml0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42
MzczNzRdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjM3Mzc1XSBzcCA6
IGZmZmY4MDAwMTFiMGJlODANClsgICAgMS42MzczNzZdIHgyOTogZmZmZjgwMDAxMWIwYmU4MCB4
Mjg6IDAwMDAwMDAwMDAwMDAwMWIgDQpbICAgIDEuNjM3Mzc4XSB4Mjc6IDAwMDAwMDAwMDAwMDAw
MDAgeDI2OiBmZmZmODAwMDEyMzYwMDcwIA0KWyAgICAxLjYzNzM4MF0geDI1OiBmZmZmZmUyMDFi
ZWEzNDAwIHgyNDogZmZmZjgwMDAxMjM2MDAwMCANClsgICAgMS42MzczODJdIHgyMzogZmZmZjgw
MDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNjM3Mzg0XSB4MjE6IGZm
ZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjYzNzM4Nl0geDE5
OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS42MzczODhd
IHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjM3
MzkwXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAx
LjYzNzM5Ml0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsg
ICAgMS42MzczOTRdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEg
DQpbICAgIDEuNjM3Mzk2XSB4OSA6IGZmZmY4MDAwMTA2ZDU3YjAgeDggOiAzMDYxMzQzMDMwMzEz
MDMwIA0KWyAgICAxLjYzNzM5OF0geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAw
MDAwMDAwMyANClsgICAgMS42MzczOTldIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZm
ZGZmZmZlMDAwMDAgDQpbICAgIDEuNjM3NDAxXSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAw
MDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjYzNzQwM10geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgw
IDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS42Mzc0MDZdIENhbGwgdHJhY2U6DQpbICAgIDEu
NjM3NDA3XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjM3NDEwXSAgZ2ljX3N0
YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS42Mzc0MTNdICBjcHVocF9pbnZva2VfY2FsbGJh
Y2srMHhhNC8weDQ2MA0KWyAgICAxLjYzNzQxNV0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8w
eGUwDQpbICAgIDEuNjM3NDE3XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpb
ICAgIDEuNjM3NDE5XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjZkIF0tLS0NClsgICAg
MS42Mzc0MjVdIEdJQ3YzOiBDUFUyNzogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODA3ODI4ZDAwMDANClsgICAgMS42Mzc0ODRdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS42Mzc0OTJd
IFhlbjogaW5pdGlhbGl6aW5nIGNwdTI3DQpbICAgIDEuNjM3NTE1XSBDUFUyNzogQm9vdGVkIHNl
Y29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTBiIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjYzNzgz
Nl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI4DQpbICAgIDEuNjM3OTEyXSBHSUN2Mzog
Q1BVMjg6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTBjIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDRjMDAw
MA0KWyAgICAxLjY0NDUzNF0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpb
ICAgIDEuNjQ0NTM5XSBXQVJOSU5HOiBDUFU6IDI4IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAv
aXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY0
NDUzOV0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNjQ0NTQzXSBDUFU6IDI4IFBJRDogMCBD
b21tOiBzd2FwcGVyLzI4IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVy
ZS1sdHMtc3RhbmRhcmQgIzENClsgICAgMS42NDQ1NDVdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3Yg
ZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS42NDQ1NDddIHBjIDogaXRzX2Nw
dV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjQ0NTQ5XSBsciA6IGl0c19jcHVfaW5pdCsweDgy
MC8weGIyMA0KWyAgICAxLjY0NDU1MF0gc3AgOiBmZmZmODAwMDExYjEzZTgwDQpbICAgIDEuNjQ0
NTUxXSB4Mjk6IGZmZmY4MDAwMTFiMTNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDFjIA0KWyAgICAx
LjY0NDU1M10geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjM4MDA3MCANClsg
ICAgMS42NDQ1NTVdIHgyNTogZmZmZmZlMjAxYmVhMzgwMCB4MjQ6IGZmZmY4MDAwMTIzODAwMDAg
DQpbICAgIDEuNjQ0NTU3XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5
MDAwIA0KWyAgICAxLjY0NDU2MF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAx
MTYyMjM1MCANClsgICAgMS42NDQ1NjJdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZm
ZmZmZmZmZmZmZmYgDQpbICAgIDEuNjQ0NTY0XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAw
MDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjY0NDU2Nl0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgx
NDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS42NDQ1NjhdIHgxMzogZmZmZjgwMDAxMTZkNGNm
NyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjQ0NTY5XSB4MTE6IDAwMDAwMDAwMDAw
MDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjY0NDU3Ml0geDkgOiBmZmZmODAw
MDEwNmQ1N2IwIHg4IDogMzA2MzM0MzAzMDMxMzAzMCANClsgICAgMS42NDQ1NzRdIHg3IDogMzEz
MDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjQ0NTc1XSB4NSA6
IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjY0NDU3N10g
eDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42NDQ1
NzldIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEu
NjQ0NTgyXSBDYWxsIHRyYWNlOg0KWyAgICAxLjY0NDU4M10gIGl0c19jcHVfaW5pdCsweDgyNC8w
eGIyMA0KWyAgICAxLjY0NDU4Nl0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEu
NjQ0NTg4XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42NDQ1OTFd
ICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjY0NDU5NF0gIHNlY29uZGFy
eV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjY0NDU5NV0gLS0tWyBlbmQgdHJhY2Ug
ZjY4NzI4YTBkMzA1M2I2ZSBdLS0tDQpbICAgIDEuNjQ0NjAxXSBHSUN2MzogQ1BVMjg6IHVzaW5n
IGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwNzgyOGUwMDAwDQpbICAgIDEu
NjQ0NjY3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJy
YXR1bSAxNDE4MDQwDQpbICAgIDEuNjQ0Njc2XSBYZW46IGluaXRpYWxpemluZyBjcHUyOA0KWyAg
ICAxLjY0NDcwNF0gQ1BVMjg6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEw
YyBbMHg0MTNmZDBjMV0NClsgICAgMS42NDUwMzFdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBD
UFUyOQ0KWyAgICAxLjY0NTExMF0gR0lDdjM6IENQVTI5OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEw
ZCByZWdpb24gMDoweDAwMDAxMDAxMDA0ZTAwMDANClsgICAgMS42NTE3MzJdIC0tLS0tLS0tLS0t
LVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjY1MTczNl0gV0FSTklORzogQ1BVOiAy
OSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NTE3MzddIE1vZHVsZXMgbGlua2VkIGluOg0KWyAg
ICAxLjY1MTc0MV0gQ1BVOiAyOSBQSUQ6IDAgQ29tbTogc3dhcHBlci8yOSBUYWludGVkOiBHICAg
ICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkICMxDQpbICAgIDEuNjUx
NzQzXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0p
DQpbICAgIDEuNjUxNzQ1XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY1
MTc0Nl0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS42NTE3NDhdIHNwIDog
ZmZmZjgwMDAxMWIxYmU4MA0KWyAgICAxLjY1MTc0OV0geDI5OiBmZmZmODAwMDExYjFiZTgwIHgy
ODogMDAwMDAwMDAwMDAwMDAxZCANClsgICAgMS42NTE3NTFdIHgyNzogMDAwMDAwMDAwMDAwMDAw
MCB4MjY6IGZmZmY4MDAwMTIzYTAwNzAgDQpbICAgIDEuNjUxNzUzXSB4MjU6IGZmZmZmZTIwMWJl
YTNjMDAgeDI0OiBmZmZmODAwMDEyM2EwMDAwIA0KWyAgICAxLjY1MTc1NV0geDIzOiBmZmZmODAw
MDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS42NTE3NTddIHgyMTogZmZm
ZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNjUxNzYwXSB4MTk6
IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjY1MTc2MV0g
eDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42NTE3
NjNdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEu
NjUxNzY1XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAg
ICAxLjY1MTc2N10geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSAN
ClsgICAgMS42NTE3NjldIHg5IDogZmZmZjgwMDAxMDZkNTdiMCB4OCA6IDMwNjUzNDMwMzAzMTMw
MzAgDQpbICAgIDEuNjUxNzcxXSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAw
MDAwMDAzIA0KWyAgICAxLjY1MTc3M10geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZk
ZmZmZmUwMDAwMCANClsgICAgMS42NTE3NzVdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAw
MDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjUxNzc3XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAg
OiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjY1MTc3OV0gQ2FsbCB0cmFjZToNClsgICAgMS42
NTE3ODFdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NTE3ODNdICBnaWNfc3Rh
cnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjY1MTc4Nl0gIGNwdWhwX2ludm9rZV9jYWxsYmFj
aysweGE0LzB4NDYwDQpbICAgIDEuNjUxNzg4XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4
ZTANClsgICAgMS42NTE3OTBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsg
ICAgMS42NTE3OTJdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNmYgXS0tLQ0KWyAgICAx
LjY1MTc5N10gR0lDdjM6IENQVTI5OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUg
QDB4MDAwMDA4MDc4MjhmMDAwMA0KWyAgICAxLjY1MTg2M10gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjY1MTg3Ml0g
WGVuOiBpbml0aWFsaXppbmcgY3B1MjkNClsgICAgMS42NTE5MDFdIENQVTI5OiBCb290ZWQgc2Vj
b25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMGQgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjUyMjIy
XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMzANClsgICAgMS42NTIzMDJdIEdJQ3YzOiBD
UFUzMDogZm91bmQgcmVkaXN0cmlidXRvciAxMGUgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNTAwMDAw
DQpbICAgIDEuNjU4OTI0XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsg
ICAgMS42NTg5MjldIFdBUk5JTkc6IENQVTogMzAgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9p
cnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjU4
OTMwXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS42NTg5MzRdIENQVTogMzAgUElEOiAwIENv
bW06IHN3YXBwZXIvMzAgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJl
LWx0cy1zdGFuZGFyZCAjMQ0KWyAgICAxLjY1ODkzNl0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBk
QUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjY1ODkzOF0gcGMgOiBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NTg5MzldIGxyIDogaXRzX2NwdV9pbml0KzB4ODIw
LzB4YjIwDQpbICAgIDEuNjU4OTQwXSBzcCA6IGZmZmY4MDAwMTFiMjNlODANClsgICAgMS42NTg5
NDFdIHgyOTogZmZmZjgwMDAxMWIyM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMWUgDQpbICAgIDEu
NjU4OTQ0XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyM2MwMDcwIA0KWyAg
ICAxLjY1ODk0Nl0geDI1OiBmZmZmZmUyMDFiZWE0MDAwIHgyNDogZmZmZjgwMDAxMjNjMDAwMCAN
ClsgICAgMS42NTg5NDhdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkw
MDAgDQpbICAgIDEuNjU4OTUwXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDEx
NjIyMzUwIA0KWyAgICAxLjY1ODk1Ml0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZm
ZmZmZmZmZmZmZiANClsgICAgMS42NTg5NTRdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAw
MDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjU4OTU1XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0
OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjY1ODk1N10geDEzOiBmZmZmODAwMDExNmQ0Y2Y3
IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42NTg5NTldIHgxMTogMDAwMDAwMDAwMDAw
MDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjU4OTYxXSB4OSA6IGZmZmY4MDAw
MTA2ZDU3YjAgeDggOiAzMDMwMzUzMDMwMzEzMDMwIA0KWyAgICAxLjY1ODk2M10geDcgOiAzMTMw
MzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS42NTg5NjVdIHg1IDog
MDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNjU4OTY3XSB4
MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjY1ODk2
OV0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS42
NTg5NzFdIENhbGwgdHJhY2U6DQpbICAgIDEuNjU4OTcyXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNjU4OTc1XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS42
NTg5NzhdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjY1ODk4MF0g
IG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNjU4OTgyXSAgc2Vjb25kYXJ5
X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNjU4OTgzXSAtLS1bIGVuZCB0cmFjZSBm
Njg3MjhhMGQzMDUzYjcwIF0tLS0NClsgICAgMS42NTg5ODldIEdJQ3YzOiBDUFUzMDogdXNpbmcg
YWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODA3ODI5MDAwMDANClsgICAgMS42
NTkwNTZdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJh
dHVtIDE0MTgwNDANClsgICAgMS42NTkwNjVdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTMwDQpbICAg
IDEuNjU5MDkyXSBDUFUzMDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTBl
IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjY1OTM0N10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQ
VTMxDQpbICAgIDEuNjU5NDI5XSBHSUN2MzogQ1BVMzE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTBm
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDUyMDAwMA0KWyAgICAxLjY2NjA1MV0gLS0tLS0tLS0tLS0t
WyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNjY2MDU2XSBXQVJOSU5HOiBDUFU6IDMx
IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVf
aW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY2NjA1N10gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAg
IDEuNjY2MDYxXSBDUFU6IDMxIFBJRDogMCBDb21tOiBzd2FwcGVyLzMxIFRhaW50ZWQ6IEcgICAg
ICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQgIzENClsgICAgMS42NjYw
NjNdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkN
ClsgICAgMS42NjYwNjVdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjY2
MDY3XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjY2NjA2N10gc3AgOiBm
ZmZmODAwMDExYjJiZTgwDQpbICAgIDEuNjY2MDY5XSB4Mjk6IGZmZmY4MDAwMTFiMmJlODAgeDI4
OiAwMDAwMDAwMDAwMDAwMDFmIA0KWyAgICAxLjY2NjA3MV0geDI3OiAwMDAwMDAwMDAwMDAwMDAw
IHgyNjogZmZmZjgwMDAxMjNlMDA3MCANClsgICAgMS42NjYwNzNdIHgyNTogZmZmZmZlMjAxYmVh
NDQwMCB4MjQ6IGZmZmY4MDAwMTIzZTAwMDAgDQpbICAgIDEuNjY2MDc1XSB4MjM6IGZmZmY4MDAw
MTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjY2NjA3N10geDIxOiBmZmZm
ODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42NjYwNzldIHgxOTog
ZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjY2MDgxXSB4
MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjY2NjA4
M10geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS42
NjYwODVdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAg
IDEuNjY2MDg3XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0K
WyAgICAxLjY2NjA4OF0geDkgOiBmZmZmODAwMDEwNmQ1N2IwIHg4IDogMzAzMjM1MzAzMDMxMzAz
MCANClsgICAgMS42NjYwOTBdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAw
MDAwMDMgDQpbICAgIDEuNjY2MDkyXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRm
ZmZmZTAwMDAwIA0KWyAgICAxLjY2NjA5NF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAw
MDAwMDAwMDAwZmZmZiANClsgICAgMS42NjYwOTZdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6
IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNjY2MDk4XSBDYWxsIHRyYWNlOg0KWyAgICAxLjY2
NjEwMF0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY2NjEwM10gIGdpY19zdGFy
dGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNjY2MTA1XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNr
KzB4YTQvMHg0NjANClsgICAgMS42NjYxMDddICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhl
MA0KWyAgICAxLjY2NjExMF0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAg
ICAxLjY2NjExMV0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I3MSBdLS0tDQpbICAgIDEu
NjY2MTE3XSBHSUN2MzogQ1BVMzE6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBA
MHgwMDAwMDgwNzgyOTEwMDAwDQpbICAgIDEuNjY2MTg2XSBhcmNoX3RpbWVyOiBFbmFibGluZyBs
b2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjY2MTk1XSBY
ZW46IGluaXRpYWxpemluZyBjcHUzMQ0KWyAgICAxLjY2NjIyM10gQ1BVMzE6IEJvb3RlZCBzZWNv
bmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwZiBbMHg0MTNmZDBjMV0NClsgICAgMS42NjYzMjJd
IHNtcDogQnJvdWdodCB1cCAxIG5vZGUsIDMyIENQVXMNClsgICAgNy41MDkxOTldIFNNUDogVG90
YWwgb2YgMzIgcHJvY2Vzc29ycyBhY3RpdmF0ZWQuDQpbICAgIDcuNTE0MDMwXSBDUFUgZmVhdHVy
ZXM6IGRldGVjdGVkOiBQcml2aWxlZ2VkIEFjY2VzcyBOZXZlcg0KWyAgICA3LjUxOTY4Nl0gQ1BV
IGZlYXR1cmVzOiBkZXRlY3RlZDogTFNFIGF0b21pYyBpbnN0cnVjdGlvbnMNClsgICAgNy41MjUz
MTVdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFVzZXIgQWNjZXNzIE92ZXJyaWRlDQpbICAgIDcu
NTMwNjk2XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiAzMi1iaXQgRUwwIFN1cHBvcnQNClsgICAg
Ny41MzU5MDRdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IENvbW1vbiBub3QgUHJpdmF0ZSB0cmFu
c2xhdGlvbnMNClsgICAgNy41NDIyNDFdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IERhdGEgY2Fj
aGUgY2xlYW4gdG8gdGhlIFBvVSBub3QgcmVxdWlyZWQgZm9yIEkvRCBjb2hlcmVuY2UNClsgICAg
Ny41NTA5MjFdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IENSQzMyIGluc3RydWN0aW9ucw0KWyAg
ICA3LjU1NjEzMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3VsYXRpdmUgU3RvcmUgQnlw
YXNzaW5nIFNhZmUgKFNTQlMpDQpbICAgIDcuNTkzODI3XSBDUFU6IEFsbCBDUFUocykgc3RhcnRl
ZCBhdCBFTDENClsgICAgNy41OTc5NzJdIGFsdGVybmF0aXZlczogcGF0Y2hpbmcga2VybmVsIGNv
ZGUNClsgICAgNy42MDMyOTldIGRldnRtcGZzOiBpbml0aWFsaXplZA0KWyAgICA3LjYwNjg0NV0g
Y2xvY2tzb3VyY2U6IGppZmZpZXM6IG1hc2s6IDB4ZmZmZmZmZmYgbWF4X2N5Y2xlczogMHhmZmZm
ZmZmZiwgbWF4X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnMNClsgICAgNy42MTY0ODhdIGZ1
dGV4IGhhc2ggdGFibGUgZW50cmllczogODE5MiAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGlu
ZWFyKQ0KWyAgICA3LjYyMzY4OV0gRE1JIG5vdCBwcmVzZW50IG9yIGludmFsaWQuDQpbICAgIDcu
NjI3Njk2XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDE2DQpbICAgIDcuNjMzMTI4
XSBETUE6IHByZWFsbG9jYXRlZCAyNTYgS2lCIEdGUF9LRVJORUwgcG9vbCBmb3IgYXRvbWljIGFs
bG9jYXRpb25zDQpbICAgIDcuNjQwMDkxXSBETUE6IHByZWFsbG9jYXRlZCAyNTYgS2lCIEdGUF9L
RVJORUx8R0ZQX0RNQSBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMNClsgICAgNy42NDc5MDBd
IERNQTogcHJlYWxsb2NhdGVkIDI1NiBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BMzIgcG9vbCBmb3Ig
YXRvbWljIGFsbG9jYXRpb25zDQpbICAgIDcuNjU2MTIwXSB0aGVybWFsX3N5czogUmVnaXN0ZXJl
ZCB0aGVybWFsIGdvdmVybm9yICdzdGVwX3dpc2UnDQpbICAgIDcuNjU2MjUyXSBEZXRlY3RlZCAx
NSBQQ0MgU3Vic3BhY2VzDQpbICAgIDcuNjY1OTA4XSBSZWdpc3RlcmluZyBQQ0MgZHJpdmVyIGFz
IE1haWxib3ggY29udHJvbGxlcg0KWyAgICA3LjY3MTI5OF0gaHctYnJlYWtwb2ludDogZm91bmQg
NiBicmVha3BvaW50IGFuZCA0IHdhdGNocG9pbnQgcmVnaXN0ZXJzLg0KWyAgICA3LjY3OTQ1Nl0g
QVNJRCBhbGxvY2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVzDQpbICAgIDcuNjg0
NzU5XSBBQ1BJOiBidXMgdHlwZSBQQ0kgcmVnaXN0ZXJlZA0KWyAgICA3LjY4ODgzMl0gU2VyaWFs
OiBBTUJBIFBMMDExIFVBUlQgZHJpdmVyDQpbICAgIDcuNjk1MzMyXSBIdWdlVExCIHJlZ2lzdGVy
ZWQgMS4wMCBHaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMNClsgICAgNy43MDE5
NDBdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAzMi4wIE1pQiBwYWdlIHNpemUsIHByZS1hbGxvY2F0ZWQg
MCBwYWdlcw0KWyAgICA3LjcwODcwMV0gSHVnZVRMQiByZWdpc3RlcmVkIDIuMDAgTWlCIHBhZ2Ug
c2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzDQpbICAgIDcuNzE1NDgyXSBIdWdlVExCIHJlZ2lz
dGVyZWQgNjQuMCBLaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMNClsgICAgNy43
MjM1NjZdIGNyeXB0ZDogbWF4X2NwdV9xbGVuIHNldCB0byAxMDAwDQpbICAgIDcuNzk1Nzk0XSBy
YWlkNjogbmVvbng4ICAgZ2VuKCkgIDc3NzIgTUIvcw0KWyAgICA3Ljg2ODAxOF0gcmFpZDY6IG5l
b254OCAgIHhvcigpICA2MDU4IE1CL3MNClsgICAgNy45NDAyMzldIHJhaWQ2OiBuZW9ueDQgICBn
ZW4oKSAgNzYzMyBNQi9zDQpbICAgIDguMDEyNDY1XSByYWlkNjogbmVvbng0ICAgeG9yKCkgIDYz
MjEgTUIvcw0KWyAgICA4LjA4NDY4N10gcmFpZDY6IG5lb254MiAgIGdlbigpICA3Mjc1IE1CL3MN
ClsgICAgOC4xNTY5MTZdIHJhaWQ2OiBuZW9ueDIgICB4b3IoKSAgNTcwNSBNQi9zDQpbICAgIDgu
MjI5MTM3XSByYWlkNjogbmVvbngxICAgZ2VuKCkgIDU5NzIgTUIvcw0KWyAgICA4LjMwMTM1NV0g
cmFpZDY6IG5lb254MSAgIHhvcigpICA0OTIwIE1CL3MNClsgICAgOC4zNzM1NzVdIHJhaWQ2OiBp
bnQ2NHg4ICBnZW4oKSAgMzYwMCBNQi9zDQpbICAgIDguNDQ1Nzk1XSByYWlkNjogaW50NjR4OCAg
eG9yKCkgIDIwMTcgTUIvcw0KWyAgICA4LjUxODI2M10gcmFpZDY6IGludDY0eDQgIGdlbigpICA0
MTI1IE1CL3MNClsgICAgOC41OTA0ODRdIHJhaWQ2OiBpbnQ2NHg0ICB4b3IoKSAgMjE5MyBNQi9z
DQpbICAgIDguNjYyNzA0XSByYWlkNjogaW50NjR4MiAgZ2VuKCkgIDM1MDEgTUIvcw0KWyAgICA4
LjczNDkyNF0gcmFpZDY6IGludDY0eDIgIHhvcigpICAxODg5IE1CL3MNClsgICAgOC44MDcxNDNd
IHJhaWQ2OiBpbnQ2NHgxICBnZW4oKSAgMjg3MyBNQi9zDQpbICAgIDguODc5MzY4XSByYWlkNjog
aW50NjR4MSAgeG9yKCkgIDE1MDcgTUIvcw0KWyAgICA4Ljg4MzUzOF0gcmFpZDY6IHVzaW5nIGFs
Z29yaXRobSBuZW9ueDggZ2VuKCkgNzc3MiBNQi9zDQpbICAgIDguODg5MDA1XSByYWlkNjogLi4u
LiB4b3IoKSA2MDU4IE1CL3MsIHJtdyBlbmFibGVkDQpbICAgIDguODk0MDQxXSByYWlkNjogdXNp
bmcgbmVvbiByZWNvdmVyeSBhbGdvcml0aG0NClsgICAgOC44OTg4MDhdIEFDUEk6IEFkZGVkIF9P
U0koTW9kdWxlIERldmljZSkNClsgICAgOC45MDI5ODRdIEFDUEk6IEFkZGVkIF9PU0koUHJvY2Vz
c29yIERldmljZSkNClsgICAgOC45MDc0OTVdIEFDUEk6IEFkZGVkIF9PU0koMy4wIF9TQ1AgRXh0
ZW5zaW9ucykNClsgICAgOC45MTIyNzBdIEFDUEk6IEFkZGVkIF9PU0koUHJvY2Vzc29yIEFnZ3Jl
Z2F0b3IgRGV2aWNlKQ0KWyAgICA4LjkxNzczOV0gQUNQSTogQWRkZWQgX09TSShMaW51eC1EZWxs
LVZpZGVvKQ0KWyAgICA4LjkyMjI1Ml0gQUNQSTogQWRkZWQgX09TSShMaW51eC1MZW5vdm8tTlYt
SERNSS1BdWRpbykNClsgICAgOC45Mjc2MzVdIEFDUEk6IEFkZGVkIF9PU0koTGludXgtSFBJLUh5
YnJpZC1HcmFwaGljcykNClsgICAgOC45NTMxNDddIEFDUEk6IDIgQUNQSSBBTUwgdGFibGVzIHN1
Y2Nlc3NmdWxseSBhY3F1aXJlZCBhbmQgbG9hZGVkDQpbICAgIDguOTY1Njg5XSBBQ1BJOiBJbnRl
cnByZXRlciBlbmFibGVkDQpbICAgIDguOTY5MjUzXSBBQ1BJOiBVc2luZyBHSUMgZm9yIGludGVy
cnVwdCByb3V0aW5nDQpbICAgIDguOTc0MDM4XSBBQ1BJOiBNQ0ZHIHRhYmxlIGRldGVjdGVkLCA1
IGVudHJpZXMNClsgICAgOC45Nzg4MDRdIEhFU1Q6IFRhYmxlIHBhcnNpbmcgaGFzIGJlZW4gaW5p
dGlhbGl6ZWQuDQpbICAgIDkuMDMxNTMzXSBBUk1IMDAxMTowMDogdHR5QU1BMCBhdCBNTUlPIDB4
MTAwMDAyNjAwMDAwIChpcnEgPSA3OSwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBDQpbICAgIDku
MTIzNDU0XSBwcmludGs6IGNvbnNvbGUgW3R0eUFNQTBdIGVuYWJsZWQNClsgICAgOS4xMjk1MTJd
IEFSTUgwMDExOjAxOiB0dHlBTUExIGF0IE1NSU8gMHgxMDAwMDI2MjAwMDAgKGlycSA9IDgwLCBi
YXNlX2JhdWQgPSAwKSBpcyBhIFNCU0ENClsgICAgOS4xMzk4NzRdIEFDUEk6IFBDSSBSb290IEJy
aWRnZSBbUENJMF0gKGRvbWFpbiAwMDBjIFtidXMgMDAtZmZdKQ0KWyAgICA5LjE0NjA0MV0gYWNw
aSBQTlAwQTA4OjAwOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9j
a1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgIDkuMTU1MjQ4XSBhY3BpIFBOUDBBMDg6
MDA6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250
cm9sDQpbICAgIDkuMTYzMDczXSBhY3BpIFBOUDBBMDg6MDA6IE1DRkcgcXVpcms6IEVDQU0gYXQg
W21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGgg
MHhmZmZmODAwMDEwZGUwZmMwDQpbICAgIDkuMTc1OTk4XSBhY3BpIFBOUDBBMDg6MDA6IEVDQU0g
YXJlYSBbbWVtIDB4MzNmZmYwMDAwMDAwLTB4MzNmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAw
QzAyOjAwDQpbICAgIDkuMTg0ODkwXSBhY3BpIFBOUDBBMDg6MDA6IEVDQU0gYXQgW21lbSAweDMz
ZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpbICAgIDkuMTkzMTA1
XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGM6MDANClsgICAgOS4xOTcxNTBdIHBjaV9idXMg
MDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDQwMDAwMDAwLTB4NGZmZmZmZmYgd2lu
ZG93XQ0KWyAgICA5LjIwNDc0Nl0gcGNpX2J1cyAwMDBjOjAwOiByb290IGJ1cyByZXNvdXJjZSBb
bWVtIDB4MzAwMDAwMDAwMDAwLTB4MzNmZmRmZmZmZmZmIHdpbmRvd10NClsgICAgOS4yMTI5OTVd
IHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0NClsgICAgOS4y
MTg1NjNdIHBjaSAwMDBjOjAwOjAwLjA6IFsxZGVmOmUxMDBdIHR5cGUgMDAgY2xhc3MgMHgwNjAw
MDANClsgICAgOS4yMjQ2NzddIHBjaSAwMDBjOjAwOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNz
dGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS4yMzIyODFdIHBjaSAwMDBj
OjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAgOS4yMzgz
NjZdIHBjaSAwMDBjOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgIDkuMjQyNjM2XSBwY2kg
MDAwYzowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgIDkuMjQ4
NTA1XSBwY2kgMDAwYzowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJ
L01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuMjU3MjQxXSBwY2kgMDAwYzowMDowMS4wOiBicmlk
Z2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMTAwMA0K
WyAgICA5LjI2NTQxOV0gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAx
MDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAg
YWRkX2FsaWduIDEwMDAwMA0KWyAgICA5LjI3Njk5OF0gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUg
MjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAgOS4yODc1ODBdIHBjaSAwMDBjOjAwOjAxLjA6
IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0NClsgICAgOS4yOTQz
OTldIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MzAwMDAwMDAwMDAw
LTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuMzAyOTE2XSBwY2kgMDAwYzowMDow
MS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDkuMzA5MjI1
XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgx
MDAwXQ0KWyAgICA5LjMxNTkxNF0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZv
ciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA5LjMyMjI0Nl0gcGNpIDAwMGM6MDA6MDEuMDogQkFS
IDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAgOS4zMjg5MzVdIHBj
aSAwMDBjOjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMV0NClsgICAgOS4zMzM5NTFdIHBj
aSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZm
Zl0NClsgICAgOS4zNDA4MzFdIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVt
IDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuMzQ5MzU3
XSBwY2lfYnVzIDAwMGM6MDA6IHJlc291cmNlIDQgW21lbSAweDQwMDAwMDAwLTB4NGZmZmZmZmYg
d2luZG93XQ0KWyAgICA5LjM1NjI4Ml0gcGNpX2J1cyAwMDBjOjAwOiByZXNvdXJjZSA1IFttZW0g
MHgzMDAwMDAwMDAwMDAtMHgzM2ZmZGZmZmZmZmYgd2luZG93XQ0KWyAgICA5LjM2MzkyOV0gcGNp
X2J1cyAwMDBjOjAxOiByZXNvdXJjZSAxIFttZW0gMHg0MDAwMDAwMC0weDQwMWZmZmZmXQ0KWyAg
ICA5LjM3MDI1MF0gcGNpX2J1cyAwMDBjOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzMDAwMDAwMDAw
MDAtMHgzMDAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS4zNzgyOThdIEFDUEk6IFBDSSBS
b290IEJyaWRnZSBbUENJMV0gKGRvbWFpbiAwMDBkIFtidXMgMDAtZmZdKQ0KWyAgICA5LjM4NDQ5
NF0gYWNwaSBQTlAwQTA4OjAxOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQ
TSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgIDkuMzkzNzAxXSBhY3BpIFBO
UDBBMDg6MDE6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09T
QyBjb250cm9sDQpbICAgIDkuNDAxNTIzXSBhY3BpIFBOUDBBMDg6MDE6IE1DRkcgcXVpcms6IEVD
QU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZd
IHdpdGggMHhmZmZmODAwMDEwZGUwZmMwDQpbICAgIDkuNDE0NDM0XSBhY3BpIFBOUDBBMDg6MDE6
IEVDQU0gYXJlYSBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZmXSByZXNlcnZlZCBi
eSBQTlAwQzAyOjAwDQpbICAgIDkuNDIzMzIzXSBhY3BpIFBOUDBBMDg6MDE6IEVDQU0gYXQgW21l
bSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpbICAgIDku
NDMxNTM5XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGQ6MDANClsgICAgOS40MzU1ODldIHBj
aV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDUwMDAwMDAwLTB4NWZmZmZm
ZmYgd2luZG93XQ0KWyAgICA5LjQ0MzE3NF0gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1cyByZXNv
dXJjZSBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzdmZmRmZmZmZmZmIHdpbmRvd10NClsgICAgOS40
NTE0MjldIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0NClsg
ICAgOS40NTY5OTVdIHBjaSAwMDBkOjAwOjAwLjA6IFsxZGVmOmUxMDBdIHR5cGUgMDAgY2xhc3Mg
MHgwNjAwMDANClsgICAgOS40NjMwODldIHBjaSAwMDBkOjAwOjAwLjA6IEZhaWxlZCB0byBhZGQg
LSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS40NzA3MDldIHBj
aSAwMDBkOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAg
OS40NzY3ODZdIHBjaSAwMDBkOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgIDkuNDgxMDY5
XSBwY2kgMDAwZDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAg
IDkuNDg2OTM2XSBwY2kgMDAwZDowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2gg
b3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuNDk0NjQwXSBwY2kgMDAwZDowMTowMC4w
OiBbMTBkZToxZTg5XSB0eXBlIDAwIGNsYXNzIDB4MDMwMDAwDQpbICAgIDkuNTAwNjMzXSBwY2kg
MDAwZDowMTowMC4wOiByZWcgMHgxMDogW21lbSAweDUwMDAwMDAwLTB4NTBmZmZmZmZdDQpbICAg
IDkuNTA2OTcwXSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxNDogW21lbSAweDM0MDAwMDAwMDAw
MC0weDM0MDAwZmZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjUxNDk4MV0gcGNpIDAwMGQ6MDE6
MDAuMDogcmVnIDB4MWM6IFttZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAwMTFmZmZmZmYgNjRiaXQg
cHJlZl0NClsgICAgOS41MjI5NTddIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDI0OiBbaW8gIDB4
NTdmZmUwMDAtMHg1N2ZmZTA3Zl0NClsgICAgOS41MjkyNzZdIHBjaSAwMDBkOjAxOjAwLjA6IHJl
ZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQ0KWyAgICA5LjUzNjEwOF0g
cGNpIDAwMGQ6MDE6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsg
ICAgOS41NDIyNTJdIHBjaSAwMDBkOjAxOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3Vn
aCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS41NDk4ODBdIHBjaSAwMDBkOjAxOjAw
LjE6IFsxMGRlOjEwZjhdIHR5cGUgMDAgY2xhc3MgMHgwNDAzMDANClsgICAgOS41NTU5MjddIHBj
aSAwMDBkOjAxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4NTEwMDAwMDAtMHg1MTAwM2ZmZl0NClsg
ICAgOS41NjIzNTZdIHBjaSAwMDBkOjAxOjAwLjE6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3Vn
aCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS41Njk5MzFdIHBjaSAwMDBkOjAxOjAw
LjI6IFsxMGRlOjFhZDhdIHR5cGUgMDAgY2xhc3MgMHgwYzAzMzANClsgICAgOS41NzU5ODRdIHBj
aSAwMDBkOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4MzQwMDEyMDAwMDAwLTB4MzQwMDEyMDNm
ZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuNTgzOTkyXSBwY2kgMDAwZDowMTowMC4yOiByZWcgMHgx
YzogW21lbSAweDM0MDAxMjA0MDAwMC0weDM0MDAxMjA0ZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5
LjU5MjAxNV0gcGNpIDAwMGQ6MDE6MDAuMjogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBE
M2NvbGQNClsgICAgOS41OTgxNDJdIHBjaSAwMDBkOjAxOjAwLjI6IEZhaWxlZCB0byBhZGQgLSBw
YXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS42MDU4NDhdIHBjaSAw
MDBkOjAxOjAwLjM6IFsxMGRlOjFhZDldIHR5cGUgMDAgY2xhc3MgMHgwYzgwMDANClsgICAgOS42
MTE4NzVdIHBjaSAwMDBkOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVtIDB4NTEwMDQwMDAtMHg1MTAw
NGZmZl0NClsgICAgOS42MTgyODBdIHBjaSAwMDBkOjAxOjAwLjM6IFBNRSMgc3VwcG9ydGVkIGZy
b20gRDAgRDNob3QgRDNjb2xkDQpbICAgIDkuNjI0NDIzXSBwY2kgMDAwZDowMTowMC4zOiBGYWls
ZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDku
NjMyMDQyXSBwY2kgMDAwZDowMDowMS4wOiBBU1BNOiBjdXJyZW50IGNvbW1vbiBjbG9jayBjb25m
aWd1cmF0aW9uIGlzIGluY29uc2lzdGVudCwgcmVjb25maWd1cmluZw0KWyAgICA5LjY1MzQzM10g
cGNpIDAwMGQ6MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgz
NDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS42NjE4NjldIHBjaSAwMDBkOjAwOjAxLjA6
IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0NClsgICAgOS42Njg3
MDZdIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAw
MF0NClsgICAgOS42NzUwMzddIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNz
aWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDkuNjgxNzI5XSBwY2kgMDAwZDowMTowMC4wOiBC
QVIgMTogYXNzaWduZWQgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAwZmZmZmZmZiA2NGJpdCBw
cmVmXQ0KWyAgICA5LjY5MDI2MF0gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFtt
ZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAwMTFmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS42OTg3
NjddIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4NTAwMDAwMDAtMHg1
MGZmZmZmZl0NClsgICAgOS43MDU2MDNdIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiA2OiBhc3NpZ25l
ZCBbbWVtIDB4NTEwMDAwMDAtMHg1MTA3ZmZmZiBwcmVmXQ0KWyAgICA5LjcxMjg5N10gcGNpIDAw
MGQ6MDE6MDAuMjogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTIwMDAwMDAtMHgzNDAwMTIw
M2ZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS43MjE0MjRdIHBjaSAwMDBkOjAxOjAwLjI6IEJBUiAz
OiBhc3NpZ25lZCBbbWVtIDB4MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRmZmZmIDY0Yml0IHByZWZd
DQpbICAgIDkuNzI5OTMxXSBwY2kgMDAwZDowMTowMC4xOiBCQVIgMDogYXNzaWduZWQgW21lbSAw
eDUxMDgwMDAwLTB4NTEwODNmZmZdDQpbICAgIDkuNzM2NzY0XSBwY2kgMDAwZDowMTowMC4zOiBC
QVIgMDogYXNzaWduZWQgW21lbSAweDUxMDg0MDAwLTB4NTEwODRmZmZdDQpbICAgIDkuNzQzNjIy
XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNTogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDAwODBd
DQpbICAgIDkuNzQ5OTUxXSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNTogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgwMDgwXQ0KWyAgICA5Ljc1NjY0MV0gcGNpIDAwMGQ6MDA6MDEuMDogUENJ
IGJyaWRnZSB0byBbYnVzIDAxXQ0KWyAgICA5Ljc2MTY1Nl0gcGNpIDAwMGQ6MDA6MDEuMDogICBi
cmlkZ2Ugd2luZG93IFttZW0gMHg1MDAwMDAwMC0weDUxN2ZmZmZmXQ0KWyAgICA5Ljc2ODUzNF0g
cGNpIDAwMGQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzNDAwMDAwMDAwMDAtMHgz
NDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS43NzcwNjVdIHBjaV9idXMgMDAwZDowMDog
U29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5IGJvb3Rpbmcgd2l0
aCBwY2k9cmVhbGxvYw0KWyAgICA5Ljc4NjE4Ml0gcGNpX2J1cyAwMDBkOjAwOiByZXNvdXJjZSA0
IFttZW0gMHg1MDAwMDAwMC0weDVmZmZmZmZmIHdpbmRvd10NClsgICAgOS43OTMxMDBdIHBjaV9i
dXMgMDAwZDowMDogcmVzb3VyY2UgNSBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzdmZmRmZmZmZmZm
IHdpbmRvd10NClsgICAgOS44MDA3NDddIHBjaV9idXMgMDAwZDowMTogcmVzb3VyY2UgMSBbbWVt
IDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0NClsgICAgOS44MDcwNzNdIHBjaV9idXMgMDAwZDowMTog
cmVzb3VyY2UgMiBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0Yml0IHByZWZd
DQpbICAgIDkuODE1MTU5XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTNdIChkb21haW4gMDAw
MCBbYnVzIDAwLWZmXSkNClsgICAgOS44MjEzMjFdIGFjcGkgUE5QMEEwODowMzogX09TQzogT1Mg
c3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5
cGUzXQ0KWyAgICA5LjgzMDU0M10gYWNwaSBQTlAwQTA4OjAzOiBQQ0llIHBvcnQgc2VydmljZXMg
ZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbA0KWyAgICA5LjgzODM2N10gYWNw
aSBQTlAwQTA4OjAzOiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgz
ZmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMA0KWyAg
ICA5Ljg1MTM1Ml0gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGFyZWEgW21lbSAweDNmZmZmMDAwMDAw
MC0weDNmZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMA0KWyAgICA5Ljg2MDI0NV0g
YWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGF0IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZm
ZmZdIGZvciBbYnVzIDAwLWZmXQ0KWyAgICA5Ljg2ODQ2M10gUENJIGhvc3QgYnJpZGdlIHRvIGJ1
cyAwMDAwOjAwDQpbICAgIDkuODcyNTA4XSBwY2lfYnVzIDAwMDA6MDA6IHJvb3QgYnVzIHJlc291
cmNlIFttZW0gMHg3MDAwMDAwMC0weDdmZmZmZmZmIHdpbmRvd10NClsgICAgOS44ODAxMTldIHBj
aV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDNjMDAwMDAwMDAwMC0weDNm
ZmZkZmZmZmZmZiB3aW5kb3ddDQpbICAgIDkuODg4MzU0XSBwY2lfYnVzIDAwMDA6MDA6IHJvb3Qg
YnVzIHJlc291cmNlIFtidXMgMDAtZmZdDQpbICAgIDkuODkzOTIxXSBwY2kgMDAwMDowMDowMC4w
OiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwDQpbICAgIDkuOTAwMDIyXSBwY2kg
MDAwMDowMDowMC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1p
Z2h0IGZhaWwhDQpbICAgIDkuOTA3NjQwXSBwY2kgMDAwMDowMDowMS4wOiBbMWRlZjplMTAxXSB0
eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgIDkuOTEzNzEyXSBwY2kgMDAwMDowMDowMS4wOiBz
dXBwb3J0cyBEMSBEMg0KWyAgICA5LjkxNzk5NF0gcGNpIDAwMDA6MDA6MDEuMDogUE1FIyBzdXBw
b3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgICA5LjkyMzg2Ml0gcGNpIDAwMDA6MDA6MDEuMDog
RmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAg
ICA5LjkzMTU2M10gcGNpIDAwMDA6MDE6MDAuMDogWzgwODY6MTU4OV0gdHlwZSAwMCBjbGFzcyAw
eDAyMDAwMA0KWyAgICA5LjkzNzU1OV0gcGNpIDAwMDA6MDE6MDAuMDogcmVnIDB4MTA6IFttZW0g
MHgzYzAwMDMwMDAwMDAtMHgzYzAwMDNmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS45NDU1NjZd
IHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODE4MDAwLTB4M2MwMDA0
ODFmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuOTUzNTQ5XSBwY2kgMDAwMDowMTowMC4wOiByZWcg
MHgzMDogW21lbSAweGZmZjgwMDAwLTB4ZmZmZmZmZmYgcHJlZl0NClsgICAgOS45NjAzNzBdIHBj
aSAwMDAwOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAg
IDkuOTY2NTAxXSBwY2kgMDAwMDowMTowMC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2gg
b3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuOTc0MTM5XSBwY2kgMDAwMDowMTowMC4x
OiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwDQpbICAgIDkuOTgwMTgxXSBwY2kg
MDAwMDowMTowMC4xOiByZWcgMHgxMDogW21lbSAweDNjMDAwMjAwMDAwMC0weDNjMDAwMmZmZmZm
ZiA2NGJpdCBwcmVmXQ0KWyAgICA5Ljk4ODE5MV0gcGNpIDAwMDA6MDE6MDAuMTogcmVnIDB4MWM6
IFttZW0gMHgzYzAwMDQ4MTAwMDAtMHgzYzAwMDQ4MTdmZmYgNjRiaXQgcHJlZl0NClsgICAgOS45
OTYxNzNdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZm
ZmZmZiBwcmVmXQ0KWyAgIDEwLjAwMjk4Nl0gcGNpIDAwMDA6MDE6MDAuMTogUE1FIyBzdXBwb3J0
ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMC4wMDkxMTJdIHBjaSAwMDAwOjAxOjAwLjE6
IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsg
ICAxMC4wMTY3NTldIHBjaSAwMDAwOjAxOjAwLjI6IFs4MDg2OjE1ODldIHR5cGUgMDAgY2xhc3Mg
MHgwMjAwMDANClsgICAxMC4wMjI4MDJdIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVt
IDB4M2MwMDAxMDAwMDAwLTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMDMwODA5
XSBwY2kgMDAwMDowMTowMC4yOiByZWcgMHgxYzogW21lbSAweDNjMDAwNDgwODAwMC0weDNjMDAw
NDgwZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjAzODc5Ml0gcGNpIDAwMDA6MDE6MDAuMjogcmVn
IDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdDQpbICAgMTAuMDQ1NjA3XSBw
Y2kgMDAwMDowMTowMC4yOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZA0KWyAg
IDEwLjA1MTczNV0gcGNpIDAwMDA6MDE6MDAuMjogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdo
IG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjA1OTM4MF0gcGNpIDAwMDA6MDE6MDAu
MzogWzgwODY6MTU4OV0gdHlwZSAwMCBjbGFzcyAweDAyMDAwMA0KWyAgIDEwLjA2NTQyNF0gcGNp
IDAwMDA6MDE6MDAuMzogcmVnIDB4MTA6IFttZW0gMHgzYzAwMDAwMDAwMDAtMHgzYzAwMDBmZmZm
ZmYgNjRiaXQgcHJlZl0NClsgICAxMC4wNzM0MzJdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDFj
OiBbbWVtIDB4M2MwMDA0ODAwMDAwLTB4M2MwMDA0ODA3ZmZmIDY0Yml0IHByZWZdDQpbICAgMTAu
MDgxNDE0XSBwY2kgMDAwMDowMTowMC4zOiByZWcgMHgzMDogW21lbSAweGZmZjgwMDAwLTB4ZmZm
ZmZmZmYgcHJlZl0NClsgICAxMC4wODgyMjldIHBjaSAwMDAwOjAxOjAwLjM6IFBNRSMgc3VwcG9y
dGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAgMTAuMDk0MzU3XSBwY2kgMDAwMDowMTowMC4z
OiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpb
ICAgMTAuMTAyMDE4XSBwY2kgMDAwMDowMDowMS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAw
LTB4MGZmZl0gdG8gW2J1cyAwMS0wMl0gYWRkX3NpemUgMTAwMA0KWyAgIDEwLjExMDQ5Nl0gcGNp
IDAwMDA6MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDAwMDAwMDAtMHgzYzAw
MDQ3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4xMTg5OTldIHBjaSAwMDAwOjAwOjAxLjA6IEJB
UiA4OiBhc3NpZ25lZCBbbWVtIDB4NzAwMDAwMDAtMHg3MDFmZmZmZl0NClsgICAxMC4xMjU4MzZd
IHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0N
ClsgICAxMC4xMzIxNjddIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWdu
IFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuMTM4ODU2XSBwY2kgMDAwMDowMDowMS4wOiBCQVIg
Nzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuMTQ1MTg5XSBwY2kgMDAw
MDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAg
IDEwLjE1MTg3OF0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgzYzAw
MDAwMDAwMDAtMHgzYzAwMDBmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4xNjA0MTFdIHBjaSAw
MDAwOjAxOjAwLjE6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAxMDAwMDAwLTB4M2MwMDAx
ZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMTY4OTE4XSBwY2kgMDAwMDowMTowMC4yOiBCQVIg
MDogYXNzaWduZWQgW21lbSAweDNjMDAwMjAwMDAwMC0weDNjMDAwMmZmZmZmZiA2NGJpdCBwcmVm
XQ0KWyAgIDEwLjE3NzQyNV0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDA6IGFzc2lnbmVkIFttZW0g
MHgzYzAwMDMwMDAwMDAtMHgzYzAwMDNmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4xODU5MzJd
IHBjaSAwMDAwOjAxOjAwLjA6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4NzAwMDAwMDAtMHg3MDA3
ZmZmZiBwcmVmXQ0KWyAgIDEwLjE5MzIwM10gcGNpIDAwMDA6MDE6MDAuMTogQkFSIDY6IGFzc2ln
bmVkIFttZW0gMHg3MDA4MDAwMC0weDcwMGZmZmZmIHByZWZdDQpbICAgMTAuMjAwNDk1XSBwY2kg
MDAwMDowMTowMC4yOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMTAwMDAwLTB4NzAxN2ZmZmYg
cHJlZl0NClsgICAxMC4yMDc3ODddIHBjaSAwMDAwOjAxOjAwLjM6IEJBUiA2OiBhc3NpZ25lZCBb
bWVtIDB4NzAxODAwMDAtMHg3MDFmZmZmZiBwcmVmXQ0KWyAgIDEwLjIxNTA3OV0gcGNpIDAwMDA6
MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDAwMDAtMHgzYzAwMDQwMDdm
ZmYgNjRiaXQgcHJlZl0NClsgICAxMC4yMjM2MDZdIHBjaSAwMDAwOjAxOjAwLjE6IEJBUiAzOiBh
c3NpZ25lZCBbbWVtIDB4M2MwMDA0MDA4MDAwLTB4M2MwMDA0MDBmZmZmIDY0Yml0IHByZWZdDQpb
ICAgMTAuMjMyMTEzXSBwY2kgMDAwMDowMTowMC4yOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDNj
MDAwNDAxMDAwMC0weDNjMDAwNDAxN2ZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjI0MDYxOV0gcGNp
IDAwMDA6MDE6MDAuMzogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMTgwMDAtMHgzYzAw
MDQwMWZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4yNDkxMjZdIHBjaSAwMDAwOjAwOjAxLjA6IFBD
SSBicmlkZ2UgdG8gW2J1cyAwMS0wMl0NClsgICAxMC4yNTQzNzldIHBjaSAwMDAwOjAwOjAxLjA6
ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NzAwMDAwMDAtMHg3MDFmZmZmZl0NClsgICAxMC4yNjEy
NTZdIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4M2MwMDAwMDAwMDAw
LTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMjY5NzgxXSBwY2lfYnVzIDAwMDA6
MDA6IHJlc291cmNlIDQgW21lbSAweDcwMDAwMDAwLTB4N2ZmZmZmZmYgd2luZG93XQ0KWyAgIDEw
LjI3NjcwNl0gcGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSA1IFttZW0gMHgzYzAwMDAwMDAwMDAt
MHgzZmZmZGZmZmZmZmYgd2luZG93XQ0KWyAgIDEwLjI4NDM1NF0gcGNpX2J1cyAwMDAwOjAxOiBy
ZXNvdXJjZSAxIFttZW0gMHg3MDAwMDAwMC0weDcwMWZmZmZmXQ0KWyAgIDEwLjI5MDY3Nl0gcGNp
X2J1cyAwMDAwOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzYzAwMDAwMDAwMDAtMHgzYzAwMDQ3ZmZm
ZmYgNjRiaXQgcHJlZl0NClsgICAxMC4yOTg3NDNdIEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJ
Nl0gKGRvbWFpbiAwMDA0IFtidXMgMDAtZmZdKQ0KWyAgIDEwLjMwNDkyMF0gYWNwaSBQTlAwQTA4
OjA2OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9ja1BNIFNlZ21l
bnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgMTAuMzE0MTI2XSBhY3BpIFBOUDBBMDg6MDY6IFBDSWUg
cG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sDQpbICAg
MTAuMzIxOTQ4XSBhY3BpIFBOUDBBMDg6MDY6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAweDJi
ZmZmMDAwMDAwMC0weDJiZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZmODAw
MDEwZGUwZmMwDQpbICAgMTAuMzM0ODcyXSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0gYXJlYSBbbWVt
IDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAwQzAyOjAwDQpb
ICAgMTAuMzQzNzYwXSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0gYXQgW21lbSAweDJiZmZmMDAwMDAw
MC0weDJiZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpbICAgMTAuMzUxOTc1XSBQQ0kgaG9z
dCBicmlkZ2UgdG8gYnVzIDAwMDQ6MDANClsgICAxMC4zNTYwMjBdIHBjaV9idXMgMDAwNDowMDog
cm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQ0KWyAg
IDEwLjM2MzYxMF0gcGNpX2J1cyAwMDA0OjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4Mjgw
MDAwMDAwMDAwLTB4MmJmZmRmZmZmZmZmIHdpbmRvd10NClsgICAxMC4zNzE4NjVdIHBjaV9idXMg
MDAwNDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0NClsgICAxMC4zNzc0MzZdIHBj
aSAwMDA0OjAwOjAwLjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDANClsgICAx
MC4zODM1MjhdIHBjaSAwMDA0OjAwOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBv
ciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC4zOTExNDRdIHBjaSAwMDA0OjAwOjAxLjA6
IFsxZGVmOmUxMTFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAxMC4zOTcyMzBdIHBjaSAw
MDA0OjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTAuNDAxNTA2XSBwY2kgMDAwNDowMDow
MS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgMTAuNDA3Mzc2XSBwY2kg
MDAwNDowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1p
Z2h0IGZhaWwhDQpbICAgMTAuNDE1MDE2XSBwY2kgMDAwNDowMDowMy4wOiBbMWRlZjplMTEzXSB0
eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgMTAuNDIxMDk3XSBwY2kgMDAwNDowMDowMy4wOiBz
dXBwb3J0cyBEMSBEMg0KWyAgIDEwLjQyNTM3OF0gcGNpIDAwMDQ6MDA6MDMuMDogUE1FIyBzdXBw
b3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgIDEwLjQzMTI0NV0gcGNpIDAwMDQ6MDA6MDMuMDog
RmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAg
IDEwLjQzODg5MV0gcGNpIDAwMDQ6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlwZSAwMSBjbGFzcyAw
eDA2MDQwMA0KWyAgIDEwLjQ0NDk3Nl0gcGNpIDAwMDQ6MDA6MDUuMDogc3VwcG9ydHMgRDEgRDIN
ClsgICAxMC40NDkyNDldIHBjaSAwMDA0OjAwOjA1LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAg
RDEgRDNob3QNClsgICAxMC40NTUxMTddIHBjaSAwMDA0OjAwOjA1LjA6IEZhaWxlZCB0byBhZGQg
LSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC40NjI4MTVdIHBj
aSAwMDA0OjAxOjAwLjA6IFsxYTAzOjExNTBdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAx
MC40Njg4NTFdIHBjaSAwMDA0OjAxOjAwLjA6IGVuYWJsaW5nIEV4dGVuZGVkIFRhZ3MNClsgICAx
MC40NzM4ODNdIHBjaSAwMDA0OjAxOjAwLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTAuNDc4MTU1
XSBwY2kgMDAwNDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQyIEQzaG90IEQz
Y29sZA0KWyAgIDEwLjQ4NDkxNV0gcGNpIDAwMDQ6MDE6MDAuMDogRmFpbGVkIHRvIGFkZCAtIHBh
c3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjQ5MjU3Ml0gcGNpX2J1
cyAwMDA0OjAyOiBleHRlbmRlZCBjb25maWcgc3BhY2Ugbm90IGFjY2Vzc2libGUNClsgICAxMC40
OTg2ODldIHBjaSAwMDA0OjAyOjAwLjA6IFsxYTAzOjIwMDBdIHR5cGUgMDAgY2xhc3MgMHgwMzAw
MDANClsgICAxMC41MDQ3NTZdIHBjaSAwMDA0OjAyOjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4MjAw
MDAwMDAtMHgyMGZmZmZmZl0NClsgICAxMC41MTEwODldIHBjaSAwMDA0OjAyOjAwLjA6IHJlZyAw
eDE0OiBbbWVtIDB4MjEwMDAwMDAtMHgyMTAxZmZmZl0NClsgICAxMC41MTc0MzJdIHBjaSAwMDA0
OjAyOjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmYwMDAtMHgyN2ZmZjA3Zl0NClsgICAxMC41
MjM4MzVdIHBjaSAwMDA0OjAyOjAwLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTAuNTI4MDY5XSBw
Y2kgMDAwNDowMjowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQyIEQzaG90IEQzY29s
ZA0KWyAgIDEwLjUzNDgyMF0gcGNpIDAwMDQ6MDI6MDAuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0
aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjU0MjU1NV0gcGNpIDAwMDQ6
MDM6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBjbGFzcyAweDBjMDMzMA0KWyAgIDEwLjU0ODU0
OV0gcGNpIDAwMDQ6MDM6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMTIwMDAwMC0weDIxMjAxZmZm
IDY0Yml0XQ0KWyAgIDEwLjU1NTUwMl0gcGNpIDAwMDQ6MDM6MDAuMDogUE1FIyBzdXBwb3J0ZWQg
ZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMC41NjE2MjZdIHBjaSAwMDA0OjAzOjAwLjA6IEZh
aWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAx
MC41NjkzMDldIHBjaSAwMDA0OjA0OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUgMDAgY2xhc3MgMHgw
MjAwMDANClsgICAxMC41NzUzMTNdIHBjaSAwMDA0OjA0OjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4
MjExMDAwMDAtMHgyMTE3ZmZmZl0NClsgICAxMC41ODE2NTVdIHBjaSAwMDA0OjA0OjAwLjA6IHJl
ZyAweDE4OiBbaW8gIDB4MjdmZmUwMDAtMHgyN2ZmZTAxZl0NClsgICAxMC41ODc5NzZdIHBjaSAw
MDA0OjA0OjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MjExODAwMDAtMHgyMTE4M2ZmZl0NClsgICAx
MC41OTQ0NzRdIHBjaSAwMDA0OjA0OjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3Qg
RDNjb2xkDQpbICAgMTAuNjAwNjA4XSBwY2kgMDAwNDowNDowMC4wOiBGYWlsZWQgdG8gYWRkIC0g
cGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTAuNjA4MjM3XSBwY2kg
MDAwNDowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0
Yml0IHByZWZdIHRvIFtidXMgMDEtMDJdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAw
DQpbICAgMTAuNjIwMDUxXSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgx
MDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMA0KWyAgIDEwLjYyODI2MF0gcGNp
IDAwMDQ6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2
NGJpdCBwcmVmXSB0byBbYnVzIDAzXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0K
WyAgIDEwLjYzOTg0MF0gcGNpIDAwMDQ6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAx
MDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAx
MDAwMDANClsgICAxMC42NTA0MTddIHBjaSAwMDA0OjAwOjA1LjA6IGJyaWRnZSB3aW5kb3cgW21l
bSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUg
MjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMC42NjE5NzZdIHBjaSAwMDA0OjAwOjA1LjA6
IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDRdIGFk
ZF9zaXplIDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTAuNjcyNTU3XSBwY2kgMDAwNDow
MDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZmZmZdDQpbICAg
MTAuNjc5NDEwXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDI4MDAw
MDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjY4NzkyNF0gcGNpIDAw
MDQ6MDA6MDMuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMTgwMDAwMC0weDIxOWZmZmZmXQ0K
WyAgIDEwLjY5NDc2Ml0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgy
ODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC43MDMyODhdIHBj
aSAwMDA0OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjFhMDAwMDAtMHgyMWJmZmZm
Zl0NClsgICAxMC43MTAxMjddIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVt
IDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuNzE4NjUy
XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBd
DQpbICAgMTAuNzI0OTYzXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjczMTY1M10gcGNpIDAwMDQ6MDA6MDMuMDogQkFS
IDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjczNzk4NV0gcGNpIDAw
MDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsg
ICAxMC43NDQ2NzJdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBz
aXplIDB4MTAwMF0NClsgICAxMC43NTEwMDZdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuNzU3NzAzXSBwY2kgMDAwNDow
MDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuNzY0
MDI2XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUg
MHgxMDAwXQ0KWyAgIDEwLjc3MDcxNF0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNl
IGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjc3NzA1M10gcGNpIDAwMDQ6MDA6MDUuMDog
QkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC43ODM3MzZd
IHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0N
ClsgICAxMC43OTAwNjhdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWdu
IFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuNzk2NzU4XSBwY2kgMDAwNDowMTowMC4wOiBCQVIg
ODogYXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZmZmZdDQpbICAgMTAuODAzNjE2XSBw
Y2kgMDAwNDowMTowMC4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpb
ICAgMTAuODA5OTQ2XSBwY2kgMDAwNDowMTowMC4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjgxNjYzNl0gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDA6
IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIwZmZmZmZmXQ0KWyAgIDEwLjgyMzUwMF0gcGNp
IDAwMDQ6MDI6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFttZW0gMHgyMTAwMDAwMC0weDIxMDFmZmZm
XQ0KWyAgIDEwLjgzMDM1NF0gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDI6IG5vIHNwYWNlIGZvciBb
aW8gIHNpemUgMHgwMDgwXQ0KWyAgIDEwLjgzNjY4Ml0gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDI6
IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0NClsgICAxMC44NDMzNzFdIHBjaSAw
MDA0OjAxOjAwLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMl0NClsgICAxMC44NDgzODhdIHBjaSAw
MDA0OjAxOjAwLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0N
ClsgICAxMC44NTUyNzJdIHBjaSAwMDA0OjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMS0w
Ml0NClsgICAxMC44NjA1NDNdIHBjaSAwMDA0OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVt
IDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0NClsgICAxMC44Njc0MjNdIHBjaSAwMDA0OjAwOjAxLjA6
ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MjgwMDAwMWZmZmZmIDY0Yml0
IHByZWZdDQpbICAgMTAuODc1OTQ3XSBwY2kgMDAwNDowMzowMC4wOiBCQVIgMDogYXNzaWduZWQg
W21lbSAweDIxODAwMDAwLTB4MjE4MDFmZmYgNjRiaXRdDQpbICAgMTAuODgzMzE5XSBwY2kgMDAw
NDowMDowMy4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDNdDQpbICAgMTAuODg4MzE3XSBwY2kgMDAw
NDowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIxODAwMDAwLTB4MjE5ZmZmZmZdDQpb
ICAgMTAuODk1MTk3XSBwY2kgMDAwNDowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDI4
MDAwMDIwMDAwMC0weDI4MDAwMDNmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjkwMzcyNF0gcGNp
IDAwMDQ6MDQ6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMWEwMDAwMC0weDIxYTdmZmZm
XQ0KWyAgIDEwLjkxMDU2Nl0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0g
MHgyMWE4MDAwMC0weDIxYTgzZmZmXQ0KWyAgIDEwLjkxNzQyN10gcGNpIDAwMDQ6MDQ6MDAuMDog
QkFSIDI6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgwMDIwXQ0KWyAgIDEwLjkyMzc0OF0gcGNp
IDAwMDQ6MDQ6MDAuMDogQkFSIDI6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDAyMF0N
ClsgICAxMC45MzA0MzZdIHBjaSAwMDA0OjAwOjA1LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwNF0N
ClsgICAxMC45MzU0NTNdIHBjaSAwMDA0OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4
MjFhMDAwMDAtMHgyMWJmZmZmZl0NClsgICAxMC45NDIzMzJdIHBjaSAwMDA0OjAwOjA1LjA6ICAg
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHBy
ZWZdDQpbICAgMTAuOTUwODU5XSBwY2lfYnVzIDAwMDQ6MDA6IFNvbWUgUENJIGRldmljZSByZXNv
dXJjZXMgYXJlIHVuYXNzaWduZWQsIHRyeSBib290aW5nIHdpdGggcGNpPXJlYWxsb2MNClsgICAx
MC45NTk5NzldIHBjaV9idXMgMDAwNDowMDogcmVzb3VyY2UgNCBbbWVtIDB4MjAwMDAwMDAtMHgy
ZmZmZmZmZiB3aW5kb3ddDQpbICAgMTAuOTY2ODk5XSBwY2lfYnVzIDAwMDQ6MDA6IHJlc291cmNl
IDUgW21lbSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZmZmZmZiB3aW5kb3ddDQpbICAgMTAuOTc0
NTQ2XSBwY2lfYnVzIDAwMDQ6MDE6IHJlc291cmNlIDEgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZm
ZmZdDQpbICAgMTAuOTgwODY3XSBwY2lfYnVzIDAwMDQ6MDE6IHJlc291cmNlIDIgW21lbSAweDI4
MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjk4ODg3M10gcGNp
X2J1cyAwMDA0OjAyOiByZXNvdXJjZSAxIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQ0KWyAg
IDEwLjk5NTE4OV0gcGNpX2J1cyAwMDA0OjAzOiByZXNvdXJjZSAxIFttZW0gMHgyMTgwMDAwMC0w
eDIxOWZmZmZmXQ0KWyAgIDExLjAwMTUyNl0gcGNpX2J1cyAwMDA0OjAzOiByZXNvdXJjZSAyIFtt
ZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS4wMDk1
MzFdIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMSBbbWVtIDB4MjFhMDAwMDAtMHgyMWJmZmZm
Zl0NClsgICAxMS4wMTU4NDldIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMiBbbWVtIDB4Mjgw
MDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuMDIzOTQ0XSBBQ1BJ
OiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTddIChkb21haW4gMDAwNSBbYnVzIDAwLWZmXSkNClsgICAx
MS4wMzAxMDhdIGFjcGkgUE5QMEEwODowNzogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29u
ZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQ0KWyAgIDExLjAzOTMyM10g
YWNwaSBQTlAwQTA4OjA3OiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0
aW5nIF9PU0MgY29udHJvbA0KWyAgIDExLjA0NzE1Ml0gYWNwaSBQTlAwQTA4OjA3OiBNQ0ZHIHF1
aXJrOiBFQ0FNIGF0IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZmZmZmZmZmZmZdIGZvciBbYnVz
IDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMA0KWyAgIDExLjA2MDEyMl0gYWNwaSBQTlAw
QTA4OjA3OiBFQ0FNIGFyZWEgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZmZmZmZl0gcmVz
ZXJ2ZWQgYnkgUE5QMEMwMjowMA0KWyAgIDExLjA2OTAxNl0gYWNwaSBQTlAwQTA4OjA3OiBFQ0FN
IGF0IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQ0K
WyAgIDExLjA3NzIzOV0gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDA1OjAwDQpbICAgMTEuMDgx
Mjg0XSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgzMDAwMDAwMC0w
eDNmZmZmZmZmIHdpbmRvd10NClsgICAxMS4wODg4NzVdIHBjaV9idXMgMDAwNTowMDogcm9vdCBi
dXMgcmVzb3VyY2UgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3aW5kb3ddDQpb
ICAgMTEuMDk3MTM1XSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAt
ZmZdDQpbICAgMTEuMTAyNjk2XSBwY2kgMDAwNTowMDowMC4wOiBbMWRlZjplMTEwXSB0eXBlIDAw
IGNsYXNzIDB4MDYwMDAwDQpbICAgMTEuMTA4ODAwXSBwY2kgMDAwNTowMDowMC4wOiBGYWlsZWQg
dG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTEuMTE2
NDEyXSBwY2kgMDAwNTowMDowMS4wOiBbMWRlZjplMTExXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAw
DQpbICAgMTEuMTIyNDk3XSBwY2kgMDAwNTowMDowMS4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgIDEx
LjEyNjc3MF0gcGNpIDAwMDU6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hv
dA0KWyAgIDExLjEzMjY0M10gcGNpIDAwMDU6MDA6MDEuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0
aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDExLjE0MDI4M10gcGNpIDAwMDU6
MDA6MDMuMDogWzFkZWY6ZTExM10gdHlwZSAwMSBjbGFzcyAweDA2MDQwMA0KWyAgIDExLjE0NjM1
OV0gcGNpIDAwMDU6MDA6MDMuMDogc3VwcG9ydHMgRDEgRDINClsgICAxMS4xNTA2NDNdIHBjaSAw
MDA1OjAwOjAzLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QNClsgICAxMS4xNTY1
MTFdIHBjaSAwMDA1OjAwOjAzLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kv
TVNJLVggbWlnaHQgZmFpbCENClsgICAxMS4xNjQxNTRdIHBjaSAwMDA1OjAwOjA1LjA6IFsxZGVm
OmUxMTVdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAxMS4xNzAyMzldIHBjaSAwMDA1OjAw
OjA1LjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTEuMTc0NTE0XSBwY2kgMDAwNTowMDowNS4wOiBQ
TUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgMTEuMTgwMzgzXSBwY2kgMDAwNTow
MDowNS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZh
aWwhDQpbICAgMTEuMTg4MDIzXSBwY2kgMDAwNTowMDowNy4wOiBbMWRlZjplMTE3XSB0eXBlIDAx
IGNsYXNzIDB4MDYwNDAwDQpbICAgMTEuMTk0MDk4XSBwY2kgMDAwNTowMDowNy4wOiBzdXBwb3J0
cyBEMSBEMg0KWyAgIDExLjE5ODM4NV0gcGNpIDAwMDU6MDA6MDcuMDogUE1FIyBzdXBwb3J0ZWQg
ZnJvbSBEMCBEMSBEM2hvdA0KWyAgIDExLjIwNDI1Ml0gcGNpIDAwMDU6MDA6MDcuMDogRmFpbGVk
IHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDExLjIx
MzAyMF0gcGNpIDAwMDU6MDI6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBjbGFzcyAweDBjMDMz
MA0KWyAgIDExLjIxOTAxNl0gcGNpIDAwMDU6MDI6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgzMDEw
MDAwMC0weDMwMTAxZmZmIDY0Yml0XQ0KWyAgIDExLjIyNTk2NV0gcGNpIDAwMDU6MDI6MDAuMDog
UE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMS4yMzIwODZdIHBjaSAw
MDA1OjAyOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWln
aHQgZmFpbCENClsgICAxMS4yNDA4MTVdIHBjaSAwMDA1OjA0OjAwLjA6IFsxMjZmOjIyNjNdIHR5
cGUgMDAgY2xhc3MgMHgwMTA4MDINClsgICAxMS4yNDY4MDddIHBjaSAwMDA1OjA0OjAwLjA6IHJl
ZyAweDEwOiBbbWVtIDB4MzAwMDAwMDAtMHgzMDAwM2ZmZiA2NGJpdF0NClsgICAxMS4yNTM4MDNd
IHBjaSAwMDA1OjA0OjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJ
LVggbWlnaHQgZmFpbCENClsgICAxMS4yNjEzOTRdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRnZSB3
aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAxMDAwDQpbICAg
MTEuMjY5NjE1XSBwY2kgMDAwNTowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAw
MC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDIwMDAwMCBhZGRf
YWxpZ24gMTAwMDAwDQpbICAgMTEuMjgxMTk4XSBwY2kgMDAwNTowMDowMS4wOiBicmlkZ2Ugd2lu
ZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAw
MDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjI5MTc3N10gcGNpIDAwMDU6MDA6MDMuMDogYnJp
ZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDJdIGFkZF9zaXplIDEwMDAN
ClsgICAxMS4yOTk5OTddIHBjaSAwMDA1OjAwOjAzLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAw
MTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMl0gYWRkX3NpemUgMjAwMDAw
IGFkZF9hbGlnbiAxMDAwMDANClsgICAxMS4zMTE1ODFdIHBjaSAwMDA1OjAwOjAzLjA6IGJyaWRn
ZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDJdIGFkZF9zaXpl
IDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMzIyMTU4XSBwY2kgMDAwNTowMDowNS4w
OiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUg
MTAwMA0KWyAgIDExLjMzMDM3N10gcGNpIDAwMDU6MDA6MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVt
IDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAzXSBhZGRfc2l6ZSAy
MDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjM0MTk2Ml0gcGNpIDAwMDU6MDA6MDUuMDog
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAwM10gYWRk
X3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMS4zNTI1NDJdIHBjaSAwMDA1OjAw
OjA3LjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDA0XSBhZGRf
c2l6ZSAxMDAwDQpbICAgMTEuMzYwNzYwXSBwY2kgMDAwNTowMDowNy4wOiBicmlkZ2Ugd2luZG93
IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDRdIGFkZF9z
aXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMzcyMzQ1XSBwY2kgMDAwNTowMDow
Ny4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBbYnVzIDA0
XSBhZGRfc2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjM4MjkyOF0gcGNpIDAw
MDU6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMC0weDMwMWZmZmZmXQ0K
WyAgIDExLjM4OTczN10gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgy
YzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS4zOTgyNjNdIHBj
aSAwMDA1OjAwOjAzLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzAyMDAwMDAtMHgzMDNmZmZm
Zl0NClsgICAxMS40MDUxMDBdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVt
IDB4MmMwMDAwMjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuNDEzNjI3
XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwNDAwMDAwLTB4MzA1
ZmZmZmZdDQpbICAgMTEuNDIwNDY1XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgOTogYXNzaWduZWQg
W21lbSAweDJjMDAwMDQwMDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjQy
ODk5Ml0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAwMC0w
eDMwN2ZmZmZmXQ0KWyAgIDExLjQzNTgyOV0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDk6IGFzc2ln
bmVkIFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAx
MS40NDQzNTZdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0NClsgICAxMS40NTA2NjhdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNDU3MzYxXSBwY2kgMDAwNTowMDow
My4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNDYzNjg3
XSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgx
MDAwXQ0KWyAgIDExLjQ3MDM3OF0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZv
ciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjQ3NjcwOV0gcGNpIDAwMDU6MDA6MDUuMDogQkFS
IDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS40ODM0MDhdIHBj
aSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsg
ICAxMS40ODk3MjldIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtp
byAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNDk2NDIxXSBwY2kgMDAwNTowMDowNy4wOiBCQVIgNzog
bm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTAyNzUyXSBwY2kgMDAwNTow
MDowNy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEx
LjUwOTQzOF0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUg
MHgxMDAwXQ0KWyAgIDExLjUxNTc3MV0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IGZhaWxlZCB0
byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS41MjI0NjFdIHBjaSAwMDA1OjAwOjAz
LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS41Mjg3OTJd
IHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEw
MDBdDQpbICAgMTEuNTM1NDgxXSBwY2kgMDAwNTowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9y
IFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTQxODEyXSBwY2kgMDAwNTowMDowMS4wOiBCQVIg
NzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjU0ODUwMl0gcGNp
IDAwMDU6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQ0KWyAgIDExLjU1MzUxNl0gcGNp
IDAwMDU6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAwMC0weDMwMWZmZmZm
XQ0KWyAgIDExLjU2MDM5N10gcGNpIDAwMDU6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0g
MHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS41Njg5MjRd
IHBjaSAwMDA1OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MzAyMDAwMDAtMHgzMDIw
MWZmZiA2NGJpdF0NClsgICAxMS41NzYyOTZdIHBjaSAwMDA1OjAwOjAzLjA6IFBDSSBicmlkZ2Ug
dG8gW2J1cyAwMl0NClsgICAxMS41ODEyOTVdIHBjaSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MzAyMDAwMDAtMHgzMDNmZmZmZl0NClsgICAxMS41ODgxNzldIHBjaSAwMDA1
OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMjAwMDAwLTB4MmMwMDAwM2Zm
ZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuNTk2NzAyXSBwY2kgMDAwNTowMDowNS4wOiBQQ0kgYnJp
ZGdlIHRvIFtidXMgMDNdDQpbICAgMTEuNjAxNzQ5XSBwY2kgMDAwNTowMDowNS4wOiAgIGJyaWRn
ZSB3aW5kb3cgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZmZmZdDQpbICAgMTEuNjA4NjE2XSBwY2kg
MDAwNTowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDQwMDAwMC0weDJjMDAw
MDVmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjYxNzE0NV0gcGNpIDAwMDU6MDQ6MDAuMDogQkFS
IDA6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAwMC0weDMwNjAzZmZmIDY0Yml0XQ0KWyAgIDExLjYy
NDUxNV0gcGNpIDAwMDU6MDA6MDcuMDogUENJIGJyaWRnZSB0byBbYnVzIDA0XQ0KWyAgIDExLjYy
OTUxM10gcGNpIDAwMDU6MDA6MDcuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDYwMDAwMC0w
eDMwN2ZmZmZmXQ0KWyAgIDExLjYzNjM5Ml0gcGNpIDAwMDU6MDA6MDcuMDogICBicmlkZ2Ugd2lu
ZG93IFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAx
MS42NDQ5MjBdIHBjaV9idXMgMDAwNTowMDogcmVzb3VyY2UgNCBbbWVtIDB4MzAwMDAwMDAtMHgz
ZmZmZmZmZiB3aW5kb3ddDQpbICAgMTEuNjUxODYyXSBwY2lfYnVzIDAwMDU6MDA6IHJlc291cmNl
IDUgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3aW5kb3ddDQpbICAgMTEuNjU5
NDkyXSBwY2lfYnVzIDAwMDU6MDE6IHJlc291cmNlIDEgW21lbSAweDMwMDAwMDAwLTB4MzAxZmZm
ZmZdDQpbICAgMTEuNjY1ODEyXSBwY2lfYnVzIDAwMDU6MDE6IHJlc291cmNlIDIgW21lbSAweDJj
MDAwMDAwMDAwMC0weDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjY3MzgxOV0gcGNp
X2J1cyAwMDA1OjAyOiByZXNvdXJjZSAxIFttZW0gMHgzMDIwMDAwMC0weDMwM2ZmZmZmXQ0KWyAg
IDExLjY4MDEzNV0gcGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDAyMDAw
MDAtMHgyYzAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS42ODgxNDddIHBjaV9idXMgMDAw
NTowMzogcmVzb3VyY2UgMSBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0NClsgICAxMS42OTQ0
NTldIHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMiBbbWVtIDB4MmMwMDAwNDAwMDAwLTB4MmMw
MDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuNzAyNDY1XSBwY2lfYnVzIDAwMDU6MDQ6IHJl
c291cmNlIDEgW21lbSAweDMwNjAwMDAwLTB4MzA3ZmZmZmZdDQpbICAgMTEuNzA4NzgzXSBwY2lf
YnVzIDAwMDU6MDQ6IHJlc291cmNlIDIgW21lbSAweDJjMDAwMDYwMDAwMC0weDJjMDAwMDdmZmZm
ZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjcxNzA0Ml0geGVuOmJhbGxvb246IEluaXRpYWxpc2luZyBi
YWxsb29uIGRyaXZlcg0KWyAgIDExLjcyMjAxOV0gaW9tbXU6IERlZmF1bHQgZG9tYWluIHR5cGU6
IFRyYW5zbGF0ZWQgDQpbICAgMTEuNzI2OTkwXSBwY2kgMDAwZDowMTowMC4wOiB2Z2FhcmI6IFZH
QSBkZXZpY2UgYWRkZWQ6IGRlY29kZXM9aW8rbWVtLG93bnM9bm9uZSxsb2Nrcz1ub25lDQpbICAg
MTEuNzM1Mzg2XSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IFZHQSBkZXZpY2UgYWRkZWQ6IGRl
Y29kZXM9aW8rbWVtLG93bnM9bm9uZSxsb2Nrcz1ub25lDQpbICAgMTEuNzQzNzk3XSBwY2kgMDAw
ZDowMTowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxlDQpbICAgMTEuNzQ5NTc4
XSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxlDQpbICAg
MTEuNzU1Mzk3XSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IHNldHRpbmcgYXMgYm9vdCBkZXZp
Y2UgKFZHQSBsZWdhY3kgcmVzb3VyY2VzIG5vdCBhdmFpbGFibGUpDQpbICAgMTEuNzY0MzcyXSB2
Z2FhcmI6IGxvYWRlZA0KWyAgIDExLjc2NzE3MV0gU0NTSSBzdWJzeXN0ZW0gaW5pdGlhbGl6ZWQN
ClsgICAxMS43NzA5MTZdIEFDUEk6IGJ1cyB0eXBlIFVTQiByZWdpc3RlcmVkDQpbICAgMTEuNzc1
MDEwXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmZzDQpbICAg
MTEuNzgwNTczXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIGh1Yg0K
WyAgIDExLjc4NTk2MV0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgZGV2aWNlIGRyaXZlciB1c2IN
ClsgICAxMS43OTEwODFdIHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAxIHJlZ2lzdGVyZWQN
ClsgICAxMS43OTYwOTddIHBwc19jb3JlOiBTb2Z0d2FyZSB2ZXIuIDUuMy42IC0gQ29weXJpZ2h0
IDIwMDUtMjAwNyBSb2RvbGZvIEdpb21ldHRpIDxnaW9tZXR0aUBsaW51eC5pdD4NClsgICAxMS44
MDUzNDldIFBUUCBjbG9jayBzdXBwb3J0IHJlZ2lzdGVyZWQNClsgICAxMS44MDk0NThdIFJlZ2lz
dGVyZWQgZWZpdmFycyBvcGVyYXRpb25zDQpbICAgMTEuODEzNDM4XSBObyBBQ1BJIFBNVSBJUlEg
Zm9yIENQVTANClsgICAxMS44MTcwNDhdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMQ0KWyAgIDEx
LjgyMDcwMF0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUyDQpbICAgMTEuODI0MzM5XSBObyBBQ1BJ
IFBNVSBJUlEgZm9yIENQVTMNClsgICAxMS44Mjc5OTddIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BV
NA0KWyAgIDExLjgzMTYzMF0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFU1DQpbICAgMTEuODM1Mjgz
XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTYNClsgICAxMS44Mzg5MjJdIE5vIEFDUEkgUE1VIElS
USBmb3IgQ1BVNw0KWyAgIDExLjg0MjU3NF0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFU4DQpbICAg
MTEuODQ2MjE0XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTkNClsgICAxMS44NDk4NjZdIE5vIEFD
UEkgUE1VIElSUSBmb3IgQ1BVMTANClsgICAxMS44NTM1OTNdIE5vIEFDUEkgUE1VIElSUSBmb3Ig
Q1BVMTENClsgICAxMS44NTczMzNdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTINClsgICAxMS44
NjEwNTldIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTMNClsgICAxMS44NjQ3OThdIE5vIEFDUEkg
UE1VIElSUSBmb3IgQ1BVMTQNClsgICAxMS44Njg1MjRdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BV
MTUNClsgICAxMS44NzIyNjNdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTYNClsgICAxMS44NzU5
ODldIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTcNClsgICAxMS44Nzk3MjhdIE5vIEFDUEkgUE1V
IElSUSBmb3IgQ1BVMTgNClsgICAxMS44ODM0NTRdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTkN
ClsgICAxMS44ODcxOTRdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjANClsgICAxMS44OTA5MjBd
IE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjENClsgICAxMS44OTQ2NTldIE5vIEFDUEkgUE1VIElS
USBmb3IgQ1BVMjINClsgICAxMS44OTgzODVdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjMNClsg
ICAxMS45MDIxMjRdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjQNClsgICAxMS45MDU4NTFdIE5v
IEFDUEkgUE1VIElSUSBmb3IgQ1BVMjUNClsgICAxMS45MDk1OTBdIE5vIEFDUEkgUE1VIElSUSBm
b3IgQ1BVMjYNClsgICAxMS45MTMzMTVdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjcNClsgICAx
MS45MTcwNTZdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjgNClsgICAxMS45MjA3ODFdIE5vIEFD
UEkgUE1VIElSUSBmb3IgQ1BVMjkNClsgICAxMS45MjQ1MjFdIE5vIEFDUEkgUE1VIElSUSBmb3Ig
Q1BVMzANClsgICAxMS45MjgyNTJdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMzENClsgICAxMS45
MzMyODRdIGNsb2Nrc291cmNlOiBTd2l0Y2hlZCB0byBjbG9ja3NvdXJjZSBhcmNoX3N5c19jb3Vu
dGVyDQpbICAgMTIuMTExNTMzXSBwbnA6IFBuUCBBQ1BJIGluaXQNClsgICAxMi4xMTU5MjddIHN5
c3RlbSAwMDowMDogW21lbSAweDNiZmZmMDAwMDAwMC0weDNiZmZmZmZmZmZmZiB3aW5kb3ddIGhh
cyBiZWVuIHJlc2VydmVkDQpbICAgMTIuMTIzODQ3XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzZmZm
ZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQNClsg
ICAxMi4xMzIxNzVdIHN5c3RlbSAwMDowMDogW21lbSAweDIzZmZmMDAwMDAwMC0weDIzZmZmZmZm
ZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgMTIuMTQwMTU2XSBzeXN0ZW0gMDA6
MDA6IFttZW0gMHgyN2ZmZjAwMDAwMDAtMHgyN2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiBy
ZXNlcnZlZA0KWyAgIDEyLjE0ODE0NF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MmJmZmYwMDAwMDAw
LTB4MmJmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkDQpbICAgMTIuMTU2
NDc4XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZmZmZmZmZmZmYgd2lu
ZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQNClsgICAxMi4xNjQ4MTVdIHN5c3RlbSAwMDowMDog
W21lbSAweDdiZmZmMDAwMDAwMC0weDdiZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2Vy
dmVkDQpbICAgMTIuMTcyNzk1XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg3ZmZmZjAwMDAwMDAtMHg3
ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjE4MDc4MF0gc3lz
dGVtIDAwOjAwOiBbbWVtIDB4NjNmZmYwMDAwMDAwLTB4NjNmZmZmZmZmZmZmIHdpbmRvd10gaGFz
IGJlZW4gcmVzZXJ2ZWQNClsgICAxMi4xODg3NjldIHN5c3RlbSAwMDowMDogW21lbSAweDY3ZmZm
MDAwMDAwMC0weDY3ZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgMTIu
MTk2NzUyXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2YmZmZjAwMDAwMDAtMHg2YmZmZmZmZmZmZmYg
d2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjIwNDc0Ml0gc3lzdGVtIDAwOjAwOiBb
bWVtIDB4NmZmZmYwMDAwMDAwLTB4NmZmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2
ZWQNClsgICAxMi4yMTI3MjZdIHN5c3RlbSAwMDowMDogW21lbSAweDMzZmZmMDAwMDAwMC0weDMz
ZmZmZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZA0KWyAgIDEyLjIyMTA2Ml0g
c3lzdGVtIDAwOjAwOiBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZmIHdpbmRvd10g
Y291bGQgbm90IGJlIHJlc2VydmVkDQpbICAgMTIuMjI5NDA2XSBwbnA6IFBuUCBBQ1BJOiBmb3Vu
ZCAxIGRldmljZXMNClsgICAxMi4yMzY3NjBdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1p
bHkgMg0KWyAgIDEyLjI0MTI3Ml0gdGNwX2xpc3Rlbl9wb3J0YWRkcl9oYXNoIGhhc2ggdGFibGUg
ZW50cmllczogMTAyNCAob3JkZXI6IDIsIDE2Mzg0IGJ5dGVzLCBsaW5lYXIpDQpbICAgMTIuMjQ5
ODQ1XSBUQ1AgZXN0YWJsaXNoZWQgaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAob3JkZXI6IDUs
IDEzMTA3MiBieXRlcywgbGluZWFyKQ0KWyAgIDEyLjI1Nzg0M10gVENQIGJpbmQgaGFzaCB0YWJs
ZSBlbnRyaWVzOiAxNjM4NCAob3JkZXI6IDYsIDI2MjE0NCBieXRlcywgbGluZWFyKQ0KWyAgIDEy
LjI2NTI4NV0gVENQOiBIYXNoIHRhYmxlcyBjb25maWd1cmVkIChlc3RhYmxpc2hlZCAxNjM4NCBi
aW5kIDE2Mzg0KQ0KWyAgIDEyLjI3MTg1Nl0gVURQIGhhc2ggdGFibGUgZW50cmllczogMTAyNCAo
b3JkZXI6IDMsIDMyNzY4IGJ5dGVzLCBsaW5lYXIpDQpbICAgMTIuMjc4NTg2XSBVRFAtTGl0ZSBo
YXNoIHRhYmxlIGVudHJpZXM6IDEwMjQgKG9yZGVyOiAzLCAzMjc2OCBieXRlcywgbGluZWFyKQ0K
WyAgIDEyLjI4NTkyMl0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZhbWlseSAxDQpbICAgMTIu
MjkwNDc4XSBSUEM6IFJlZ2lzdGVyZWQgbmFtZWQgVU5JWCBzb2NrZXQgdHJhbnNwb3J0IG1vZHVs
ZS4NClsgICAxMi4yOTYzNzVdIFJQQzogUmVnaXN0ZXJlZCB1ZHAgdHJhbnNwb3J0IG1vZHVsZS4N
ClsgICAxMi4zMDExMjZdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgdHJhbnNwb3J0IG1vZHVsZS4NClsg
ICAxMi4zMDU5MDBdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgTkZTdjQuMSBiYWNrY2hhbm5lbCB0cmFu
c3BvcnQgbW9kdWxlLg0KWyAgIDEyLjMxMjQ3OV0gcGNpIDAwMGQ6MDE6MDAuMTogRDAgcG93ZXIg
c3RhdGUgZGVwZW5kcyBvbiAwMDBkOjAxOjAwLjANClsgICAxMi4zMTg5MTJdIHBjaSAwMDBkOjAx
OjAwLjI6IEQwIHBvd2VyIHN0YXRlIGRlcGVuZHMgb24gMDAwZDowMTowMC4wDQpbICAgMTIuMzI1
MzE3XSBwY2kgMDAwZDowMTowMC4yOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikNClsg
ICAxMi4zMzEwNjFdIHBjaSAwMDBkOjAxOjAwLjM6IEQwIHBvd2VyIHN0YXRlIGRlcGVuZHMgb24g
MDAwZDowMTowMC4wDQpbICAgMTIuMzM3NDkyXSBwY2kgMDAwNDowMzowMC4wOiBlbmFibGluZyBk
ZXZpY2UgKDAwMDAgLT4gMDAwMikNClsgICAxMi4zNDMxOThdIHBjaSAwMDA1OjAyOjAwLjA6IGVu
YWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQ0KWyAgIDEyLjM0ODkxMF0gUENJOiBDTFMgMTI4
IGJ5dGVzLCBkZWZhdWx0IDY0DQpbICAgMTIuMzU1NTU1XSBodyBwZXJmZXZlbnRzOiBlbmFibGVk
IHdpdGggYXJtdjhfcG11djNfMCBQTVUgZHJpdmVyLCAxIGNvdW50ZXJzIGF2YWlsYWJsZQ0KWyAg
IDEyLjM2NTg2NV0gd29ya2luZ3NldDogdGltZXN0YW1wX2JpdHM9NDIgbWF4X29yZGVyPTE5IGJ1
Y2tldF9vcmRlcj0wDQpbICAgMTIuMzc0MDU5XSBORlM6IFJlZ2lzdGVyaW5nIHRoZSBpZF9yZXNv
bHZlciBrZXkgdHlwZQ0KWyAgIDEyLjM3OTA4MV0gS2V5IHR5cGUgaWRfcmVzb2x2ZXIgcmVnaXN0
ZXJlZA0KWyAgIDEyLjM4MzMxM10gS2V5IHR5cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQNClsgICAx
Mi4zODc4MDddIEtleSB0eXBlIGNpZnMuaWRtYXAgcmVnaXN0ZXJlZA0KWyAgIDEyLjQwNjQzMF0g
eG9yOiBtZWFzdXJpbmcgc29mdHdhcmUgY2hlY2tzdW0gc3BlZWQNClsgICAxMi40MTIxODNdICAg
IDhyZWdzICAgICAgICAgICA6ICA5Nzg5IE1CL3NlYw0KWyAgIDEyLjQxNzMzMl0gICAgMzJyZWdz
ICAgICAgICAgIDogMTE3NTggTUIvc2VjDQpbICAgMTIuNDIyMzQxXSAgICBhcm02NF9uZW9uICAg
ICAgOiAxMzk3OSBNQi9zZWMNClsgICAxMi40MjY2NTBdIHhvcjogdXNpbmcgZnVuY3Rpb246IGFy
bTY0X25lb24gKDEzOTc5IE1CL3NlYykNClsgICAxMi40MzIyMjRdIEJsb2NrIGxheWVyIFNDU0kg
Z2VuZXJpYyAoYnNnKSBkcml2ZXIgdmVyc2lvbiAwLjQgbG9hZGVkIChtYWpvciAyNDkpDQpbICAg
MTIuNDM5NzA1XSBpbyBzY2hlZHVsZXIgbXEtZGVhZGxpbmUgcmVnaXN0ZXJlZA0KWyAgIDEyLjQ0
NDI3MF0gaW8gc2NoZWR1bGVyIGt5YmVyIHJlZ2lzdGVyZWQNClsgICAxMi40NDk2OTZdIGdwaW8t
ZHdhcGIgQVBNQzBEMDc6MDI6IG5vIElSUSBmb3IgcG9ydDANClsgICAxMi40NTU2MTNdIGlucHV0
OiBQb3dlciBCdXR0b24gYXMgL2RldmljZXMvTE5YU1lTVE06MDAvTE5YU1lCVVM6MDAvUE5QMEMw
QzowMC9pbnB1dC9pbnB1dDANClsgICAxMi40NjM5OTddIEFDUEk6IFBvd2VyIEJ1dHRvbiBbUFdS
Ql0NClsgICAxMi40Njg0MThdIEdIRVM6IEFQRUkgZmlybXdhcmUgZmlyc3QgbW9kZSBpcyBlbmFi
bGVkIGJ5IEFQRUkgYml0Lg0KWyAgIDEyLjQ3NDYxOF0gRUlOSjogRXJyb3IgSU5KZWN0aW9uIGlz
IGluaXRpYWxpemVkLg0KWyAgIDEyLjQ3OTM3MF0gQUNQSSBHVERUOiBmb3VuZCAxIFNCU0EgZ2Vu
ZXJpYyBXYXRjaGRvZyhzKS4NClsgICAxMi40ODUyMTNdIHhlbjp4ZW5fZXZ0Y2huOiBFdmVudC1j
aGFubmVsIGRldmljZSBpbnN0YWxsZWQNClsgICAxMi40OTEzNzhdIGFzdCAwMDA0OjAyOjAwLjA6
IFtkcm1dIHBsYXRmb3JtIGhhcyBubyBJTyBzcGFjZSwgdHJ5aW5nIE1NSU8NClsgICAxMi40OTgx
NjVdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIFVzaW5nIFAyQSBicmlkZ2UgZm9yIGNvbmZpZ3Vy
YXRpb24NClsgICAxMi41MDQ3NDRdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIEFTVCAyNTAwIGRl
dGVjdGVkDQpbICAgMTIuNTA5ODQ4XSBhc3QgMDAwNDowMjowMC4wOiBbZHJtXSBBbmFsb2cgVkdB
IG9ubHkNClsgICAxMi41MTQ3OTddIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIGRyYW0gTUNMSz04
MDAgTWh6IHR5cGU9OCBidXNfd2lkdGg9MTYNClsgICAxMi41MjE3NTldIFtUVE1dIFpvbmUgIGtl
cm5lbDogQXZhaWxhYmxlIGdyYXBoaWNzIG1lbW9yeTogOTY0NDQ4IEtpQg0KWyAgIDEyLjUyODE4
M10gW1RUTV0gSW5pdGlhbGl6aW5nIHBvb2wgYWxsb2NhdG9yDQpbICAgMTIuNTMyNTgzXSBbVFRN
XSBJbml0aWFsaXppbmcgRE1BIHBvb2wgYWxsb2NhdG9yDQpbICAgMTIuNTM3NjU4XSBbZHJtXSBJ
bml0aWFsaXplZCBhc3QgMC4xLjAgMjAxMjAyMjggZm9yIDAwMDQ6MDI6MDAuMCBvbiBtaW5vciAw
DQpbICAgMTIuNTYyNjA5XSBDb25zb2xlOiBzd2l0Y2hpbmcgdG8gY29sb3VyIGZyYW1lIGJ1ZmZl
ciBkZXZpY2UgMTI4eDQ4DQpbICAgMTIuNTcxMDQ0XSBhc3QgMDAwNDowMjowMC4wOiBbZHJtXSBm
YjA6IGFzdGRybWZiIGZyYW1lIGJ1ZmZlciBkZXZpY2UNClsgICAxMi41OTIwNTVdIGJyZDogbW9k
dWxlIGxvYWRlZA0KWyAgIDEyLjU5OTQ4NF0gbG9vcDogbW9kdWxlIGxvYWRlZA0KWyAgIDEyLjYw
MzE2MF0gbnZtZSBudm1lMDogcGNpIGZ1bmN0aW9uIDAwMDU6MDQ6MDAuMA0KWyAgIDEyLjYwODEy
OV0gaWdiOiBJbnRlbChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgRHJpdmVyDQpbICAgMTIu
NjEzNDk1XSBpZ2I6IENvcHlyaWdodCAoYykgMjAwNy0yMDE0IEludGVsIENvcnBvcmF0aW9uLg0K
WyAgIDEyLjYxMzYzNl0gbnZtZSBudm1lMDogbWlzc2luZyBvciBpbnZhbGlkIFNVQk5RTiBmaWVs
ZC4NClsgICAxMi42MjU5NDFdIFVuYWJsZSB0byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBk
ZXJlZmVyZW5jZSBhdCB2aXJ0dWFsIGFkZHJlc3MgMDAwMDAwMDAwMDAwMDAwOA0KWyAgIDEyLjYz
NDcyNl0gTWVtIGFib3J0IGluZm86DQpbICAgMTIuNjM3NTIwXSAgIEVTUiA9IDB4OTYwMDAwNDQN
ClsgICAxMi42NDA2NDZdICAgRUMgPSAweDI1OiBEQUJUIChjdXJyZW50IEVMKSwgSUwgPSAzMiBi
aXRzDQpbICAgMTIuNjQ2MDU1XSAgIFNFVCA9IDAsIEZuViA9IDANClsgICAxMi42NDkxNTNdICAg
RUEgPSAwLCBTMVBUVyA9IDANClsgICAxMi42NTIzNjVdIERhdGEgYWJvcnQgaW5mbzoNClsgICAx
Mi42NTUzMTRdICAgSVNWID0gMCwgSVNTID0gMHgwMDAwMDA0NA0KWyAgIDEyLjY1OTIzMV0gICBD
TSA9IDAsIFduUiA9IDENClsgICAxMi42NjIyNjBdIFswMDAwMDAwMDAwMDAwMDA4XSB1c2VyIGFk
ZHJlc3MgYnV0IGFjdGl2ZV9tbSBpcyBzd2FwcGVyDQpbICAgMTIuNjY4NzI0XSBJbnRlcm5hbCBl
cnJvcjogT29wczogOTYwMDAwNDQgWyMxXSBQUkVFTVBUIFNNUA0KWyAgIDEyLjY3NDM1OF0gTW9k
dWxlcyBsaW5rZWQgaW46DQpbICAgMTIuNjc3NDU1XSBDUFU6IDAgUElEOiA3IENvbW06IGt3b3Jr
ZXIvdTY0OjAgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1z
dGFuZGFyZCAjMQ0KWyAgIDEyLjY4NzA4M10gV29ya3F1ZXVlOiBudm1lLXJlc2V0LXdxIG52bWVf
cmVzZXRfd29yaw0KWyAgIDEyLjY5MjA1OV0gcHN0YXRlOiA2MGMwMDA4NSAoblpDdiBkYUlmICtQ
QU4gK1VBTyAtVENPIEJUWVBFPS0tKQ0KWyAgIDEyLjY5ODE0OV0gcGMgOiBzdGVhbF9zdWl0YWJs
ZV9mYWxsYmFjaysweDEzOC8weDJmMA0KWyAgIDEyLjcwMzE3MF0gbHIgOiBzdGVhbF9zdWl0YWJs
ZV9mYWxsYmFjaysweDFiYy8weDJmMA0KWyAgIDEyLjcwODIwM10gc3AgOiBmZmZmODAwMDExOTZi
ODIwDQpbICAgMTIuNzExNTY5XSB4Mjk6IGZmZmY4MDAwMTE5NmI4MjAgeDI4OiAwMDAwMDAwMDAw
MDAwMDAwIA0KWyAgIDEyLjcxNjk3NV0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgw
MDAxMTRkYmNiMCANClsgICAxMi43MjIzNTddIHgyNTogZmZmZmZkZmZmZmUwMDAwMCB4MjQ6IDAw
MDAwMDAwMDAwMDAwMDEgDQpbICAgMTIuNzI3NzQwXSB4MjM6IDAwMDAwMDAwMDAwMDAwMDAgeDIy
OiBmZmZmZmUyMDFiZjYwMDAwIA0KWyAgIDEyLjczMzEyMF0geDIxOiBmZmZmMDgwNzFmYmY2OTgw
IHgyMDogMDAwMDAwMDAwMDAwMDkwMSANClsgICAxMi43Mzg1MDJdIHgxOTogMDAwMDAwMDAwMDA4
MDAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgMTIuNzQzODg0XSB4MTc6IDAwMDAwMDAw
MDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDEyIA0KWyAgIDEyLjc0OTI2Nl0geDE1OiBmZmZm
MDgwNzA1MDhjNjgzIHgxNDogMDAwMDAwMDAwMDAwMDA1OCANClsgICAxMi43NTQ2NDhdIHgxMzog
MDAwMDAwMDAwMDAwMDBjMCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgMTIuNzYwMDMwXSB4
MTE6IDAwMDAwMDAwMDAwMDA0MDAgeDEwOiAwMDAwMDAwMDAwMDAwMDBjIA0KWyAgIDEyLjc2NTQx
Ml0geDkgOiBmZmZmODAwMDEwMDM5ZDU4IHg4IDogMDAwMDAwMDAyMDAwMDAwMCANClsgICAxMi43
NzA3OTRdIHg3IDogMDAwMDAwMDAwMDAwMDAxOCB4NiA6IGZmZmY4MDAwMTE3NTA4OTAgDQpbICAg
MTIuNzc2MTc2XSB4NSA6IGZmZmY4MDAwMTE3NTA4NzggeDQgOiAwMDAwMDAwMDAwMDAwMDAwIA0K
WyAgIDEyLjc4MTU1OF0geDMgOiAwMDAwMDAwMDAwMDAwMDAwIHgyIDogMDAwMDAwMDAwMDAwMDAw
MCANClsgICAxMi43ODY5NDBdIHgxIDogMDAwMDAwMDAwMDAwMDIwMCB4MCA6IDAwMDAwMDAwMDAw
MDAwMDAgDQpbICAgMTIuNzkyMzIyXSBDYWxsIHRyYWNlOg0KWyAgIDEyLjc5NDgwNl0gIHN0ZWFs
X3N1aXRhYmxlX2ZhbGxiYWNrKzB4MTM4LzB4MmYwDQpbICAgMTIuNzk5NTIwXSAgZ2V0X3BhZ2Vf
ZnJvbV9mcmVlbGlzdCsweGUzMC8weDEyYTANClsgICAxMi44MDQyMDddICBfX2FsbG9jX3BhZ2Vz
X25vZGVtYXNrKzB4MTQ4LzB4ZTAwDQpbICAgMTIuODA4ODA5XSAgX19kbWFfZGlyZWN0X2FsbG9j
X3BhZ2VzKzB4YTQvMHgxZDANClsgICAxMi44MTM0OTZdICBkbWFfZGlyZWN0X2FsbG9jKzB4MWQ4
LzB4MzQwDQpbICAgMTIuODE3NTcxXSAgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQrMHg2OC8w
eDM3MA0KWyAgIDEyLjgyMjQzOV0gIGRtYV9hbGxvY19hdHRycysweGU4LzB4ZjANClsgICAxMi44
MjYyNDZdICBudm1lX3Jlc2V0X3dvcmsrMHgxMDMwLzB4MTUyMA0KWyAgIDEyLjgzMDQxN10gIHBy
b2Nlc3Nfb25lX3dvcmsrMHgxZGMvMHg0YmMNClsgICAxMi44MzQ0OTVdICB3b3JrZXJfdGhyZWFk
KzB4MTQ0LzB4NDcwDQpbICAgMTIuODM4MzEzXSAga3RocmVhZCsweDE0Yy8weDE2MA0KWyAgIDEy
Ljg0MTYwNF0gIHJldF9mcm9tX2ZvcmsrMHgxMC8weDM4DQpbICAgMTIuODQ1MjU1XSBDb2RlOiBh
OTQwODJjNCBkMzdlZjQ2MyBjYjNjNDA2MyA4YjNjNDA0MiAoZjkwMDA0ODApIA0KWyAgIDEyLjg1
MTQ0N10gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I3MiBdLS0tDQpbICAgMTIuODU2MTE3
XSBub3RlOiBrd29ya2VyL3U2NDowWzddIGV4aXRlZCB3aXRoIHByZWVtcHRfY291bnQgMQ0KWyAg
IDEyLjg3OTg0NF0gcHBzIHBwczA6IG5ldyBQUFMgc291cmNlIHB0cDANClsgICAxMi44ODM4Njhd
IGlnYiAwMDA0OjA0OjAwLjA6IGFkZGVkIFBIQyBvbiBldGgwDQpbICAgMTIuODg4NDEwXSBpZ2Ig
MDAwNDowNDowMC4wOiBJbnRlbChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgQ29ubmVjdGlv
bg0KWyAgIDEyLjg5NTM4Ml0gaWdiIDAwMDQ6MDQ6MDAuMDogZXRoMDogKFBDSWU6Mi41R2IvczpX
aWR0aCB4MSkgMDA6MzA6NjQ6M2I6NTA6NTINClsgICAxMi45MDI2NDddIGlnYiAwMDA0OjA0OjAw
LjA6IGV0aDA6IFBCQSBObzogMDAwMzAwLTAwMA0KWyAgIDEyLjkwNzc3NF0gaWdiIDAwMDQ6MDQ6
MDAuMDogVXNpbmcgTVNJLVggaW50ZXJydXB0cy4gNCByeCBxdWV1ZShzKSwgNCB0eCBxdWV1ZShz
KQ0KWyAgIDEyLjkxNTUwMl0gaWdidmY6IEludGVsKFIpIEdpZ2FiaXQgVmlydHVhbCBGdW5jdGlv
biBOZXR3b3JrIERyaXZlcg0KWyAgIDEyLjkyMTc3Nl0gaWdidmY6IENvcHlyaWdodCAoYykgMjAw
OSAtIDIwMTIgSW50ZWwgQ29ycG9yYXRpb24uDQpbICAgMTIuOTI3NzY5XSBpNDBlOiBJbnRlbChS
KSBFdGhlcm5ldCBDb25uZWN0aW9uIFhMNzEwIE5ldHdvcmsgRHJpdmVyDQpbICAgMTIuOTM0MDk5
XSBpNDBlOiBDb3B5cmlnaHQgKGMpIDIwMTMgLSAyMDE5IEludGVsIENvcnBvcmF0aW9uLg0KWyAg
IDEyLjk0MDE3Nl0gaTQwZSAwMDAwOjAxOjAwLjA6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAw
MDAyKQ0KDQo=

--_004_C82612B1FED541399B87FB33DD81F01Aarmcom_--


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 13:11:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 13:11:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304122.518672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1necmF-0002gf-2F; Wed, 13 Apr 2022 13:11:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304122.518672; Wed, 13 Apr 2022 13:11:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1necmE-0002gY-VR; Wed, 13 Apr 2022 13:11:18 +0000
Received: by outflank-mailman (input) for mailman id 304122;
 Wed, 13 Apr 2022 13:11:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0JnL=UX=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1necmD-0002gS-47
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 13:11:17 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 329ba94b-bb2b-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 15:11:15 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 780D712FC;
 Wed, 13 Apr 2022 06:11:14 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 28B383F73B;
 Wed, 13 Apr 2022 06:11:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 329ba94b-bb2b-11ec-a405-831a346695d4
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Michal Orzel <michal.orzel@arm.com>
Subject: [PATCH v2] xen/build: Add cppcheck and cppcheck-html make rules
Date: Wed, 13 Apr 2022 14:11:03 +0100
Message-Id: <74b35aab0706fc977a3c5c3dfa20b52fda6f4698.1649855186.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

cppcheck can be used to check Xen code quality.

To create a report do "make cppcheck" on a built tree adding any options
you added during the process you used to build xen (like CROSS_COMPILE
or XEN_TARGET_ARCH). This will generate an xml report xen-cppcheck.xml.

To create a html report do "make cppcheck-html" in the same way and a
full report to be seen in a browser will be generated in
cppcheck-htmlreport/index.html.

For better results it is recommended to build your own cppcheck from the
latest sources that you can find at [1].
Development and result analysis has been done with cppcheck 2.7.

The Makefile rule is searching for all C files which have been compiled
(ie which have a generated .o file) and is running cppcheck on all of
them using the current configuration of xen so only the code actually
compiled is checked.

A new tool is introduced to merge all cppcheck reports into one global
report including all findings and removing duplicates.

Some extra variables can be used to customize the report:
- CPPCHECK can be used to give the full path to the cppcheck binary to
use (default is to use the one from the standard path).
- CPPCHECK_HTMLREPORT can be used to give the full path to
cppcheck-htmlreport (default is to use the one from the standard path).

This has been tested on several arm configurations (x86 should work but
has not been tested).

[1] https://cppcheck.sourceforge.io/

Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes in v2:
- catch parsing errors during merge and tell the user to update cppcheck
- fix alignments in Makefile
- use srctree and objtree instead of BASEDIR
- remove SCTLR invalid change
- add a check of cppcheck version and mandate version 2.7 or greater
- rework the merge script to make it faster and display progress
---
 .gitignore                           |  3 +
 xen/Makefile                         | 84 +++++++++++++++++++++++++++-
 xen/arch/arm/include/asm/processor.h |  2 +
 xen/include/xen/config.h             |  4 ++
 xen/include/xen/kconfig.h            |  5 ++
 xen/tools/merge_cppcheck_reports.py  | 83 +++++++++++++++++++++++++++
 6 files changed, 179 insertions(+), 2 deletions(-)
 create mode 100755 xen/tools/merge_cppcheck_reports.py

diff --git a/.gitignore b/.gitignore
index d425be4bd9..0d2d60b8f1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,7 @@
 *.o
 *.d
 *.d2
+*.c.cppcheck
 *.opic
 *.a
 *.so
@@ -296,6 +297,7 @@ xen/.banner
 xen/.config
 xen/.config.old
 xen/.xen.elf32
+xen/xen-cppcheck.xml
 xen/System.map
 xen/arch/x86/boot/mkelf32
 xen/arch/x86/boot/cmdline.S
@@ -316,6 +318,7 @@ xen/arch/*/efi/runtime.c
 xen/arch/*/include/asm/asm-offsets.h
 xen/common/config_data.S
 xen/common/config.gz
+xen/cppcheck-htmlreport
 xen/include/headers*.chk
 xen/include/compat/*
 xen/include/config/
diff --git a/xen/Makefile b/xen/Makefile
index ebc7854c08..734f9f2b4f 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -335,7 +335,7 @@ export CFLAGS_UBSAN
 
 endif # need-config
 
-main-targets := build install uninstall clean distclean MAP
+main-targets := build install uninstall clean distclean MAP cppcheck cppcheck-html
 .PHONY: $(main-targets)
 ifneq ($(XEN_TARGET_ARCH),x86_32)
 $(main-targets): %: _% ;
@@ -423,15 +423,17 @@ _clean:
 	$(Q)$(MAKE) $(clean)=tools/kconfig
 	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
 		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
-		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
+		-o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \
 		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
 	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map
 	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
 	rm -f .banner .allconfig.tmp include/xen/compile.h
+	rm -f xen-cppcheck.xml
 
 .PHONY: _distclean
 _distclean: clean
 	rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS .config
+	rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR)
 
 $(TARGET).gz: $(TARGET)
 	gzip -n -f -9 < $< > $@.new
@@ -505,6 +507,84 @@ cloc:
 	    done; \
 	done | cloc --list-file=-
 
+# What cppcheck command to use.
+# To get proper results, it is recommended to build cppcheck manually from the
+# latest source and use CPPCHECK to give the full path to the built version.
+CPPCHECK ?= cppcheck
+
+# What cppcheck-htmlreport to use.
+# If you give the full path to a self compiled cppcheck, this should be set
+# to the full path to cppcheck-html in the htmlreport directory of cppcheck.
+# On recent distribution, this is available in the standard path.
+CPPCHECK_HTMLREPORT ?= cppcheck-htmlreport
+
+# By default we generate the report in cppcheck-htmlreport directory in the
+# build directory. This can be changed by giving a directory in this variable.
+CPPCHECK_HTMLREPORT_OUTDIR ?= cppcheck-htmlreport
+
+# Compile flags to pass to cppcheck:
+# - include directories and defines Xen Makefile is passing (from CFLAGS)
+# - include config.h as this is passed directly to the compiler.
+# - define CPPCHECK as we use to disable or enable some specific part of the
+#   code to solve some cppcheck issues.
+# - explicitely enable some cppcheck checks as we do not want to use "all"
+#   which includes unusedFunction which gives wrong positives as we check file
+#   per file.
+#
+# Compiler defines are in compiler-def.h which is included in config.h
+#
+CPPCHECKFLAGS := -DCPPCHECK --max-ctu-depth=10 \
+                 --enable=style,information,missingInclude \
+                 --include=$(srctree)/include/xen/config.h \
+                 -I $(srctree)/xsm/flask/include \
+                 -I $(srctree)/include/xen/libfdt \
+                 $(filter -D% -I%,$(CFLAGS))
+
+# We need to find all C files (as we are not checking assembly files) so
+# we find all generated .o files which have a .c corresponding file.
+CPPCHECKFILES := $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c, \
+                 $(filter-out $(objtree)/tools/%, \
+                 $(shell find $(objtree) -name "*.o"))))
+
+quiet_cmd_cppcheck_xml = CPPCHECK $(patsubst $(srctree)/%,%,$<)
+cmd_cppcheck_xml = $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \
+                   --output-file=$@ $<
+
+quiet_cmd_merge_cppcheck_reports = CPPCHECK-MERGE $@
+cmd_merge_cppcheck_reports = $(srctree)/tools/merge_cppcheck_reports.py $^ $@
+
+quiet_cmd_cppcheck_html = CPPCHECK-HTML $<
+cmd_cppcheck_html = $(CPPCHECK_HTMLREPORT) --file=$< --source-dir=$(srctree) \
+                    --report-dir=$(CPPCHECK_HTMLREPORT_OUTDIR) --title=Xen
+
+PHONY += _cppcheck _cppcheck-html cppcheck-version
+
+_cppcheck-html: xen-cppcheck.xml
+	$(call if_changed,cppcheck_html)
+
+_cppcheck: xen-cppcheck.xml
+
+xen-cppcheck.xml: $(patsubst $(srctree)/%.c,$(objtree)/%.c.cppcheck,$(CPPCHECKFILES))
+ifeq ($(CPPCHECKFILES),)
+	$(error Please build Xen before running cppcheck)
+endif
+	$(call if_changed,merge_cppcheck_reports)
+
+$(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h $(objtree)/include/generated/compiler-def.h | cppcheck-version
+	$(call if_changed,cppcheck_xml)
+
+cppcheck-version:
+ifeq ($(shell which $(CPPCHECK)),)
+	$(error Cannot find cppcheck executable: $(CPPCHECK))
+endif
+ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1)
+	$(error Please upgrade your cppcheck to version 2.7 or greater)
+endif
+
+# Put this in generated headers this way it is cleaned by include/Makefile
+$(objtree)/include/generated/compiler-def.h:
+	$(Q)$(CC) -dM -E -o $@ - < /dev/null
+
 endif #config-build
 
 PHONY += FORCE
diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
index 852b5f3c24..ef37cfa16f 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -219,9 +219,11 @@
                          SCTLR_Axx_ELx_A    | SCTLR_Axx_ELx_C   |\
                          SCTLR_Axx_ELx_WXN  | SCTLR_Axx_ELx_EE)
 
+#ifndef CPPCHECK
 #if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xffffffffffffffffUL
 #error "Inconsistent SCTLR_EL2 set/clear bits"
 #endif
+#endif
 
 #endif
 
diff --git a/xen/include/xen/config.h b/xen/include/xen/config.h
index 85c6f59be9..d888b2314d 100644
--- a/xen/include/xen/config.h
+++ b/xen/include/xen/config.h
@@ -7,6 +7,10 @@
 #ifndef __XEN_CONFIG_H__
 #define __XEN_CONFIG_H__
 
+#ifdef CPPCHECK
+#include <generated/compiler-def.h>
+#endif
+
 #include <xen/kconfig.h>
 
 #ifndef __ASSEMBLY__
diff --git a/xen/include/xen/kconfig.h b/xen/include/xen/kconfig.h
index 4d58c5bb3c..a717b0819c 100644
--- a/xen/include/xen/kconfig.h
+++ b/xen/include/xen/kconfig.h
@@ -8,6 +8,10 @@
  * these only work with boolean option.
  */
 
+/* cppcheck is failing to parse the macro so use a dummy one */
+#ifdef CPPCHECK
+#define IS_ENABLED(option) option
+#else
 /*
  * Getting something that works in C and CPP for an arg that may or may
  * not be defined is tricky.  Here, if we have "#define CONFIG_BOOGER 1"
@@ -27,5 +31,6 @@
  * otherwise.
  */
 #define IS_ENABLED(option) config_enabled(option)
+#endif
 
 #endif /* __XEN_KCONFIG_H */
diff --git a/xen/tools/merge_cppcheck_reports.py b/xen/tools/merge_cppcheck_reports.py
new file mode 100755
index 0000000000..eabf558768
--- /dev/null
+++ b/xen/tools/merge_cppcheck_reports.py
@@ -0,0 +1,83 @@
+#!/usr/bin/env python
+
+"""
+This script acts as a tool to merge XML files created by cppcheck.
+Usage:
+    merge_cppcheck_reports.py [FILES] [OUTPUT]
+
+    FILES  - list of XML files with extension .cppcheck
+    OUTPUT - file to store results (with .xml extension).
+             If not specified, the script will print results to stdout.
+"""
+
+import sys
+from xml.etree import ElementTree
+
+def elements_equal(el1, el2):
+    if type(el1) != type(el2): return False
+
+    el1_location = str(el1.find('location').attrib)
+    el2_location = str(el2.find('location').attrib)
+
+    if el1_location != el2_location: return False
+
+    return True
+
+def contain_element(new, lst):
+    for elem in lst:
+        if elements_equal(new, elem):
+            return True
+    return False
+
+def merge(files):
+    try:
+        result_xml_root = ElementTree.parse(files[0]).getroot()
+    except ParseError:
+        print("Xml parsing error in %s\n" % (files[0]))
+        print("Please upgrade your cppcheck to version 2.7 or greater")
+        sys.exit(1)
+    insert_point = result_xml_root.findall("errors")[0]
+    curr = 1
+    total = len(files)
+    numelem = len(insert_point)
+    for xml_file in files[1:]:
+        try:
+            xml_root = ElementTree.parse(xml_file).getroot()
+        except ParseError:
+            print("Xml parsing error in %s\n" % (xml_file))
+            print("Please upgrade your cppcheck to version 2.7 or greater")
+            sys.exit(1)
+        curr_elem_list = list(insert_point)
+        new_elem_list = list(xml_root.findall("errors")[0])
+        for xml_error_elem in new_elem_list:
+            if not contain_element(xml_error_elem, curr_elem_list):
+                insert_point.insert(1,xml_error_elem)
+                numelem = numelem + 1
+        curr = curr + 1
+        sys.stdout.write('\r')
+        sys.stdout.write(" %d / %d" % (curr,total))
+        sys.stdout.flush()
+
+    sys.stdout.write('\r\n')
+    print("Done: %d elements" % (numelem))
+    return result_xml_root
+
+def run():
+    files = []
+    output = None
+    for i in sys.argv[1:]:
+        output = i if '.xml' in i else None
+        files.append(i) if '.cppcheck' in i else None
+
+    result = merge(files)
+
+    if result is None:
+        return
+
+    if output is not None:
+        ElementTree.ElementTree(result).write(output)
+    else:
+        print(ElementTree.tostring(result).decode('utf-8'))
+
+if __name__ == '__main__':
+    run()
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 13:31:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 13:31:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304132.518682 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ned5J-00055v-MU; Wed, 13 Apr 2022 13:31:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304132.518682; Wed, 13 Apr 2022 13:31:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ned5J-00055o-Ja; Wed, 13 Apr 2022 13:31:01 +0000
Received: by outflank-mailman (input) for mailman id 304132;
 Wed, 13 Apr 2022 13:31:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ned5H-00055e-VZ; Wed, 13 Apr 2022 13:30:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ned5H-0002SX-Op; Wed, 13 Apr 2022 13:30:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ned5H-0001lq-DQ; Wed, 13 Apr 2022 13:30:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ned5H-0006Ac-Cy; Wed, 13 Apr 2022 13:30:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Yh0TSirVI7hifZG1B3vkyvkHYLmTPZC4sXq1Jkb+rUk=; b=mlpU3g+g+iKGcazaznX1ahhpxR
	zDS1lex6j4jYo1f43N6t3fkwaKmK2+t8pFAHiiMeaQ+5uuBRiBYFpAx/2myi6WL3oxooBPQw5s3cF
	/JOHyVshzX3J1VNVtuR6RnLG5k8Ss3fv/HtlbqbAPsiwCGm7SNaqqCnK6RixL85T3m08=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169364-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169364: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 13:30:59 +0000

flight 169364 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169364/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  362 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 13:43:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 13:43:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304143.518705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedHE-0006sv-7D; Wed, 13 Apr 2022 13:43:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304143.518705; Wed, 13 Apr 2022 13:43:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedHE-0006sm-4G; Wed, 13 Apr 2022 13:43:20 +0000
Received: by outflank-mailman (input) for mailman id 304143;
 Wed, 13 Apr 2022 13:43:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4VvB=UX=intel.com=tamas.lengyel@srs-se1.protection.inumbo.net>)
 id 1nedHB-0006cb-N9
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 13:43:17 +0000
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa34d9a4-bb2f-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 15:43:15 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Apr 2022 06:43:13 -0700
Received: from samarths-mobl.amr.corp.intel.com (HELO localhost.localdomain)
 ([10.209.182.24])
 by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Apr 2022 06:43:11 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa34d9a4-bb2f-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649857395; x=1681393395;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=PLdEcqDhyOxXQ/AEnQEPq0e1K208cDWXzs3wCvIHm+s=;
  b=eUs56WROeSSY8pNR/EDvv2/BCquPVnN2nWkfrMv+f0YjpN/w8zT/NB2x
   gN902hzJBbLh6VXhBBxC+TqgG/vM1RBDQeU5lsQzZBjRUfr/af630Hxqu
   uAZtjhjekoVUfR/O/X95J/tJtep7XNdV8aN4UU9U0TONncd3hKD5cqrO0
   1oTAfi8GNGimJBwpFnNLYgmGLm71GjNxgFwLTz3qh742s4fbZdzkcOSWI
   BH80MYpUaAeFToCUugpUA9QcSisFuYBVEZPhyhZNkgO/ollrVAhGhpJq4
   bDux+eoI7g6QrXiNvy71guluKFm/AqNXDcFuEQ86s3msSGG7MMiLozxsa
   A==;
X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="287691116"
X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; 
   d="scan'208";a="287691116"
X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; 
   d="scan'208";a="623686077"
From: Tamas K Lengyel <tamas.lengyel@intel.com>
To: xen-devel@lists.xenproject.org
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: [PATCH v4 2/2] x86/monitor: Add new monitor event to catch all vmexits
Date: Wed, 13 Apr 2022 09:41:52 -0400
Message-Id: <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add monitor event that hooks the vmexit handler allowing for both sync and
async monitoring of events. With async monitoring an event is placed on the
monitor ring for each exit and the rest of the vmexit handler resumes normally.
If there are additional monitor events configured those will also place their
respective events on the monitor ring.

With the sync version an event is placed on the monitor ring but the handler
does not get resumed, thus the sync version is only useful when the VM is not
expected to resume normally after the vmexit. Our use-case is primarily with
the sync version with VM forks where the fork gets reset after sync vmexit
event, thus the rest of the vmexit handler can be safely skipped. This is
very useful when we want to avoid Xen crashing the VM under any circumstance,
for example during fuzzing. Collecting all vmexit information regardless of
the root cause makes it easier to reason about the state of the VM on the
monitor side, hence we opt to receive all events, even for external interrupt
and NMI exits and let the monitor agent decide how to proceed.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
---
v4: Minor tweaks and more verbose patch description.

Note: making the sync version resume-friendly is specifically out-of-scope as
it would require significant rearrangement of the vmexit handler. As this
feature is not required for our use-case we opt for the version that minimizes
impact on the existing code.
---
 tools/include/xenctrl.h                |  2 ++
 tools/libs/ctrl/xc_monitor.c           | 15 +++++++++++++++
 xen/arch/x86/hvm/monitor.c             | 18 ++++++++++++++++++
 xen/arch/x86/hvm/vmx/vmx.c             | 12 ++++++++++++
 xen/arch/x86/include/asm/domain.h      |  2 ++
 xen/arch/x86/include/asm/hvm/monitor.h |  2 ++
 xen/arch/x86/include/asm/monitor.h     |  3 ++-
 xen/arch/x86/monitor.c                 | 14 ++++++++++++++
 xen/include/public/domctl.h            |  6 ++++++
 xen/include/public/vm_event.h          |  8 ++++++++
 10 files changed, 81 insertions(+), 1 deletion(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 1b089a2c02..159eaac050 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -2096,6 +2096,8 @@ int xc_monitor_privileged_call(xc_interface *xch, uint32_t domain_id,
                                bool enable);
 int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
                                   bool enable);
+int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
+                      bool sync);
 /**
  * This function enables / disables emulation for each REP for a
  * REP-compatible instruction.
diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.c
index 4ac823e775..c5fa62ff30 100644
--- a/tools/libs/ctrl/xc_monitor.c
+++ b/tools/libs/ctrl/xc_monitor.c
@@ -246,6 +246,21 @@ int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
     return do_domctl(xch, &domctl);
 }
 
+int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
+                      bool sync)
+{
+    DECLARE_DOMCTL;
+
+    domctl.cmd = XEN_DOMCTL_monitor_op;
+    domctl.domain = domain_id;
+    domctl.u.monitor_op.op = enable ? XEN_DOMCTL_MONITOR_OP_ENABLE
+                                    : XEN_DOMCTL_MONITOR_OP_DISABLE;
+    domctl.u.monitor_op.event = XEN_DOMCTL_MONITOR_EVENT_VMEXIT;
+    domctl.u.monitor_op.u.vmexit.sync = sync;
+
+    return do_domctl(xch, &domctl);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
index b44a1e1dfe..64a38e8fa7 100644
--- a/xen/arch/x86/hvm/monitor.c
+++ b/xen/arch/x86/hvm/monitor.c
@@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
     return monitor_traps(curr, true, &req) >= 0;
 }
 
+int hvm_monitor_vmexit(unsigned long exit_reason,
+                       unsigned long exit_qualification)
+{
+    struct vcpu *curr = current;
+    struct arch_domain *ad = &curr->domain->arch;
+    vm_event_request_t req = {};
+
+    ASSERT(ad->monitor.vmexit_enabled);
+
+    req.reason = VM_EVENT_REASON_VMEXIT;
+    req.u.vmexit.reason = exit_reason;
+    req.u.vmexit.qualification = exit_qualification;
+
+    set_npt_base(curr, &req);
+
+    return monitor_traps(curr, ad->monitor.vmexit_sync, &req);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index c075370f64..2794db46f9 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
         }
     }
 
+    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
+    {
+        int rc;
+
+        __vmread(EXIT_QUALIFICATION, &exit_qualification);
+        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
+        if ( rc < 0 )
+            goto exit_and_crash;
+        if ( rc )
+            return;
+    }
+
     /* XXX: This looks ugly, but we need a mechanism to ensure
      * any pending vmresume has really happened
      */
diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
index e62e109598..855db352c0 100644
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -430,6 +430,8 @@ struct arch_domain
          */
         unsigned int inguest_pagefault_disabled                            : 1;
         unsigned int control_register_values                               : 1;
+        unsigned int vmexit_enabled                                        : 1;
+        unsigned int vmexit_sync                                           : 1;
         struct monitor_msr_bitmap *msr_bitmap;
         uint64_t write_ctrlreg_mask[4];
     } monitor;
diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h
index a75cd8545c..639f6dfa37 100644
--- a/xen/arch/x86/include/asm/hvm/monitor.h
+++ b/xen/arch/x86/include/asm/hvm/monitor.h
@@ -51,6 +51,8 @@ bool hvm_monitor_emul_unimplemented(void);
 
 bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
                            uint16_t kind);
+int hvm_monitor_vmexit(unsigned long exit_reason,
+                       unsigned long exit_qualification);
 
 #endif /* __ASM_X86_HVM_MONITOR_H__ */
 
diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/asm/monitor.h
index 01c6d63bb9..d8d54c5f23 100644
--- a/xen/arch/x86/include/asm/monitor.h
+++ b/xen/arch/x86/include/asm/monitor.h
@@ -89,7 +89,8 @@ static inline uint32_t arch_monitor_get_capabilities(struct domain *d)
                     (1U << XEN_DOMCTL_MONITOR_EVENT_DEBUG_EXCEPTION) |
                     (1U << XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG) |
                     (1U << XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED) |
-                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT));
+                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT) |
+                    (1U << XEN_DOMCTL_MONITOR_EVENT_VMEXIT));
 
     if ( hvm_is_singlestep_supported() )
         capabilities |= (1U << XEN_DOMCTL_MONITOR_EVENT_SINGLESTEP);
diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
index 3079726a8b..30ca71432c 100644
--- a/xen/arch/x86/monitor.c
+++ b/xen/arch/x86/monitor.c
@@ -332,6 +332,20 @@ int arch_monitor_domctl_event(struct domain *d,
         break;
     }
 
+    case XEN_DOMCTL_MONITOR_EVENT_VMEXIT:
+    {
+        bool old_status = ad->monitor.vmexit_enabled;
+
+        if ( unlikely(old_status == requested_status) )
+            return -EEXIST;
+
+        domain_pause(d);
+        ad->monitor.vmexit_enabled = requested_status;
+        ad->monitor.vmexit_sync = mop->u.vmexit.sync;
+        domain_unpause(d);
+        break;
+    }
+
     default:
         /*
          * Should not be reached unless arch_monitor_get_capabilities() is
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0..4803ed7afc 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -1057,6 +1057,7 @@ struct xen_domctl_psr_cmt_op {
 #define XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED    10
 /* Enabled by default */
 #define XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT     11
+#define XEN_DOMCTL_MONITOR_EVENT_VMEXIT                12
 
 struct xen_domctl_monitor_op {
     uint32_t op; /* XEN_DOMCTL_MONITOR_OP_* */
@@ -1107,6 +1108,11 @@ struct xen_domctl_monitor_op {
             /* Pause vCPU until response */
             uint8_t sync;
         } debug_exception;
+
+        struct {
+            /* Send event and don't process vmexit */
+            uint8_t sync;
+        } vmexit;
     } u;
 };
 
diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
index 81c2ee28cc..07f106f811 100644
--- a/xen/include/public/vm_event.h
+++ b/xen/include/public/vm_event.h
@@ -175,6 +175,8 @@
 #define VM_EVENT_REASON_DESCRIPTOR_ACCESS       13
 /* Current instruction is not implemented by the emulator */
 #define VM_EVENT_REASON_EMUL_UNIMPLEMENTED      14
+/* VMEXIT */
+#define VM_EVENT_REASON_VMEXIT                  15
 
 /* Supported values for the vm_event_write_ctrlreg index. */
 #define VM_EVENT_X86_CR0    0
@@ -394,6 +396,11 @@ struct vm_event_emul_insn_data {
     uint8_t data[16]; /* Has to be completely filled */
 };
 
+struct vm_event_vmexit {
+    uint64_t reason;
+    uint64_t qualification;
+};
+
 typedef struct vm_event_st {
     uint32_t version;   /* VM_EVENT_INTERFACE_VERSION */
     uint32_t flags;     /* VM_EVENT_FLAG_* */
@@ -414,6 +421,7 @@ typedef struct vm_event_st {
         struct vm_event_debug                 software_breakpoint;
         struct vm_event_debug                 debug_exception;
         struct vm_event_cpuid                 cpuid;
+        struct vm_event_vmexit                vmexit;
         union {
             struct vm_event_interrupt_x86     x86;
         } interrupt;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 13:43:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 13:43:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304142.518695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedHC-0006cp-TO; Wed, 13 Apr 2022 13:43:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304142.518695; Wed, 13 Apr 2022 13:43:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedHC-0006ci-OT; Wed, 13 Apr 2022 13:43:18 +0000
Received: by outflank-mailman (input) for mailman id 304142;
 Wed, 13 Apr 2022 13:43:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4VvB=UX=intel.com=tamas.lengyel@srs-se1.protection.inumbo.net>)
 id 1nedHA-0006cW-Ss
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 13:43:17 +0000
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a93264bc-bb2f-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 15:43:13 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Apr 2022 06:43:11 -0700
Received: from samarths-mobl.amr.corp.intel.com (HELO localhost.localdomain)
 ([10.209.182.24])
 by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Apr 2022 06:43:09 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a93264bc-bb2f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649857393; x=1681393393;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=i4gihqpzw3HZhfTflQfrH5igRej8DiYlrOqYPsiESEs=;
  b=B6+2fZ72twXiNjUF6UfhAHeS+i4RXCsv1Fg7BnB4bLFUtgiWOOyNoqEe
   psCC13T8KomiMOSzYMFWH0RKv9F5R32Mzzmq1QVrZpWhGGwpqyIZRJW32
   sJBI18vW/LE7ej4n6DgWbwWTam5OysbpQl3MangSCbD5T/Ihl8BixQKrg
   jEbPapzBpfoGo1eFD8+OJYg4i0oXhPpUBd8wvrT94gzHQpV57UcfXXQCb
   z70OXiNTYviXWh9awsdMALNGeYSt/qDfV0iu91hipkpm5PfoThVTfqwNQ
   R82554gLFdCwpUR4zAV2k7XCiZISGcalPzyw1t6ultd52A6FO/zXJdTO5
   w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="287691102"
X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; 
   d="scan'208";a="287691102"
X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; 
   d="scan'208";a="623686056"
From: Tamas K Lengyel <tamas.lengyel@intel.com>
To: xen-devel@lists.xenproject.org
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>
Subject: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
Date: Wed, 13 Apr 2022 09:41:51 -0400
Message-Id: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Allow specify distinct parts of the fork VM to be reset. This is useful when a
fuzzing operation involves mapping in only a handful of pages that are known
ahead of time. Throwing these pages away just to be re-copied immediately is
expensive, thus allowing to specify partial resets can speed things up.

Also allow resetting to be initiated from vm_event responses as an
optiomization.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
---
v4: No change
v3: Rebase on simpler approach after dropping empty_p2m feature
v2: address review comments and add more sanity checking
---
 tools/include/xenctrl.h                |  3 ++-
 tools/libs/ctrl/xc_memshr.c            |  7 ++++++-
 xen/arch/x86/include/asm/mem_sharing.h |  9 +++++++++
 xen/arch/x86/mm/mem_sharing.c          | 24 +++++++++++++++++++-----
 xen/common/vm_event.c                  | 15 +++++++++++++++
 xen/include/public/memory.h            |  4 +++-
 xen/include/public/vm_event.h          |  8 ++++++++
 7 files changed, 62 insertions(+), 8 deletions(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 95bd5eca67..1b089a2c02 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -2290,7 +2290,8 @@ int xc_memshr_fork(xc_interface *xch,
  *
  * With VMs that have a lot of memory this call may block for a long time.
  */
-int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain);
+int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain,
+                         bool reset_state, bool reset_memory);
 
 /* Debug calls: return the number of pages referencing the shared frame backing
  * the input argument. Should be one or greater.
diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c
index a6cfd7dccf..a0d0b894e2 100644
--- a/tools/libs/ctrl/xc_memshr.c
+++ b/tools/libs/ctrl/xc_memshr.c
@@ -257,12 +257,17 @@ int xc_memshr_fork(xc_interface *xch, uint32_t pdomid, uint32_t domid,
     return xc_memshr_memop(xch, domid, &mso);
 }
 
-int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid)
+int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid, bool reset_state,
+                         bool reset_memory)
 {
     xen_mem_sharing_op_t mso;
 
     memset(&mso, 0, sizeof(mso));
     mso.op = XENMEM_sharing_op_fork_reset;
+    if ( reset_state )
+        mso.u.fork.flags |= XENMEM_FORK_RESET_STATE;
+    if ( reset_memory )
+        mso.u.fork.flags |= XENMEM_FORK_RESET_MEMORY;
 
     return xc_memshr_memop(xch, domid, &mso);
 }
diff --git a/xen/arch/x86/include/asm/mem_sharing.h b/xen/arch/x86/include/asm/mem_sharing.h
index cf7a12f4d2..2c00069bc9 100644
--- a/xen/arch/x86/include/asm/mem_sharing.h
+++ b/xen/arch/x86/include/asm/mem_sharing.h
@@ -85,6 +85,9 @@ static inline bool mem_sharing_is_fork(const struct domain *d)
 int mem_sharing_fork_page(struct domain *d, gfn_t gfn,
                           bool unsharing);
 
+int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                           bool reset_memory);
+
 /*
  * If called by a foreign domain, possible errors are
  *   -EBUSY -> ring full
@@ -148,6 +151,12 @@ static inline int mem_sharing_fork_page(struct domain *d, gfn_t gfn, bool lock)
     return -EOPNOTSUPP;
 }
 
+static inline int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                                         bool reset_memory)
+{
+    return -EOPNOTSUPP;
+}
+
 #endif
 
 #endif /* __MEM_SHARING_H__ */
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index 15e6a7ed81..2f447d94ab 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1879,15 +1879,21 @@ static int fork(struct domain *cd, struct domain *d)
  * footprints the hypercall continuation should be implemented (or if this
  * feature needs to be become "stable").
  */
-static int mem_sharing_fork_reset(struct domain *d)
+int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                           bool reset_memory)
 {
-    int rc;
+    int rc = 0;
     struct domain *pd = d->parent;
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     struct page_info *page, *tmp;
 
+    ASSERT(reset_state || reset_memory);
+
     domain_pause(d);
 
+    if ( !reset_memory )
+        goto state;
+
     /* need recursive lock because we will free pages */
     spin_lock_recursive(&d->page_alloc_lock);
     page_list_for_each_safe(page, tmp, &d->page_list)
@@ -1920,7 +1926,9 @@ static int mem_sharing_fork_reset(struct domain *d)
     }
     spin_unlock_recursive(&d->page_alloc_lock);
 
-    rc = copy_settings(d, pd);
+ state:
+    if ( reset_state )
+        rc = copy_settings(d, pd);
 
     domain_unpause(d);
 
@@ -2227,15 +2235,21 @@ int mem_sharing_memop(XEN_GUEST_HANDLE_PARAM(xen_mem_sharing_op_t) arg)
 
     case XENMEM_sharing_op_fork_reset:
     {
+        bool reset_state = mso.u.fork.flags & XENMEM_FORK_RESET_STATE;
+        bool reset_memory = mso.u.fork.flags & XENMEM_FORK_RESET_MEMORY;
+
         rc = -EINVAL;
-        if ( mso.u.fork.pad || mso.u.fork.flags )
+        if ( mso.u.fork.pad || (!reset_state && !reset_memory) )
+            goto out;
+        if ( mso.u.fork.flags &
+             ~(XENMEM_FORK_RESET_STATE | XENMEM_FORK_RESET_MEMORY) )
             goto out;
 
         rc = -ENOSYS;
         if ( !d->parent )
             goto out;
 
-        rc = mem_sharing_fork_reset(d);
+        rc = mem_sharing_fork_reset(d, reset_state, reset_memory);
         break;
     }
 
diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
index 84cf52636b..d26a6699fc 100644
--- a/xen/common/vm_event.c
+++ b/xen/common/vm_event.c
@@ -28,6 +28,11 @@
 #include <asm/p2m.h>
 #include <asm/monitor.h>
 #include <asm/vm_event.h>
+
+#ifdef CONFIG_MEM_SHARING
+#include <asm/mem_sharing.h>
+#endif
+
 #include <xsm/xsm.h>
 #include <public/hvm/params.h>
 
@@ -394,6 +399,16 @@ static int vm_event_resume(struct domain *d, struct vm_event_domain *ved)
             if ( rsp.reason == VM_EVENT_REASON_MEM_PAGING )
                 p2m_mem_paging_resume(d, &rsp);
 #endif
+#ifdef CONFIG_MEM_SHARING
+            if ( mem_sharing_is_fork(d) )
+            {
+                bool reset_state = rsp.flags & VM_EVENT_FLAG_RESET_FORK_STATE;
+                bool reset_mem = rsp.flags & VM_EVENT_FLAG_RESET_FORK_MEMORY;
+
+                if ( reset_state || reset_mem )
+                    ASSERT(!mem_sharing_fork_reset(d, reset_state, reset_mem));
+            }
+#endif
 
             /*
              * Check emulation flags in the arch-specific handler only, as it
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index a1a0f0233a..f8d26fb77d 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -541,12 +541,14 @@ struct xen_mem_sharing_op {
                 uint32_t gref;     /* IN: gref to debug         */
             } u;
         } debug;
-        struct mem_sharing_op_fork {      /* OP_FORK */
+        struct mem_sharing_op_fork {      /* OP_FORK{,_RESET} */
             domid_t parent_domain;        /* IN: parent's domain id */
 /* Only makes sense for short-lived forks */
 #define XENMEM_FORK_WITH_IOMMU_ALLOWED (1u << 0)
 /* Only makes sense for short-lived forks */
 #define XENMEM_FORK_BLOCK_INTERRUPTS   (1u << 1)
+#define XENMEM_FORK_RESET_STATE        (1u << 2)
+#define XENMEM_FORK_RESET_MEMORY       (1u << 3)
             uint16_t flags;               /* IN: optional settings */
             uint32_t pad;                 /* Must be set to 0 */
         } fork;
diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
index bb003d21d0..81c2ee28cc 100644
--- a/xen/include/public/vm_event.h
+++ b/xen/include/public/vm_event.h
@@ -127,6 +127,14 @@
  * Reset the vmtrace buffer (if vmtrace is enabled)
  */
 #define VM_EVENT_FLAG_RESET_VMTRACE      (1 << 13)
+/*
+ * Reset the VM state (if VM is fork)
+ */
+#define VM_EVENT_FLAG_RESET_FORK_STATE   (1 << 14)
+/*
+ * Remove unshared entried from physmap (if VM is fork)
+ */
+#define VM_EVENT_FLAG_RESET_FORK_MEMORY  (1 << 15)
 
 /*
  * Reasons for the vm event request
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 13:48:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 13:48:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304153.518716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedMC-0007uA-Qp; Wed, 13 Apr 2022 13:48:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304153.518716; Wed, 13 Apr 2022 13:48:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedMC-0007u3-Np; Wed, 13 Apr 2022 13:48:28 +0000
Received: by outflank-mailman (input) for mailman id 304153;
 Wed, 13 Apr 2022 13:48:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0JnL=UX=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nedMB-0007tx-SW
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 13:48:27 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20606.outbound.protection.outlook.com
 [2a01:111:f400:7d00::606])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 64299f15-bb30-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 15:48:26 +0200 (CEST)
Received: from AM6PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:20b:f0::48)
 by AM9PR08MB7244.eurprd08.prod.outlook.com (2603:10a6:20b:433::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Wed, 13 Apr
 2022 13:48:23 +0000
Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:f0:cafe::13) by AM6PR04CA0071.outlook.office365.com
 (2603:10a6:20b:f0::48) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30 via Frontend
 Transport; Wed, 13 Apr 2022 13:48:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 13:48:22 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Wed, 13 Apr 2022 13:48:22 +0000
Received: from e3cd7df54723.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E9780A3A-7A70-487F-95BF-81B364D830CB.1; 
 Wed, 13 Apr 2022 13:48:15 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e3cd7df54723.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Apr 2022 13:48:15 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PR2PR08MB4746.eurprd08.prod.outlook.com (2603:10a6:101:23::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 13:48:14 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6%4]) with mapi id 15.20.5144.030; Wed, 13 Apr 2022
 13:48:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64299f15-bb30-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vV4IBIpBa4dX2xqjgatPHaXMPaAyCwe4ek7jEDdMCIk=;
 b=cLCyNt7fktz15TOobdqlTlwCxC56kCWvl8q8Ym8c3eJ8yWWeEC+29Q9uTtSwzPgTj/Xz3xhmBnBMjRIQGqL/qwBZLLUaGaf1OQ881rgcHa2ee2Bu3f1Xghm9vCw1h25VWd+HF2tOCni6Fo+1n3p23DFefUJ0+GPSMChSr2lmAlI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3144488bbe50a734
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gM+5onBvvTKLzFwFyVpfDDHRfTNh29jT8VTkhzG4kXvf4Bt54Hc2ddmhHGiktVzZ++SzGqW/Dg9BSocRcXeNVMV8wgBMPpbpSCdjwqccacTAdMUkKciMJqtsuwEKGkK2kRK3eEGtFh50KxNqWg1XLkRpyqxTWu4TMu5dcWerG3uUwdI6dSz+TZwjWRqX55mhwlNniGmhjh0spQNorHLz8U1njkA3kO9rKd26d20mHpuBCxE3haO58SMzGcNuDxLd38CmYXYdIxuxpyD7+qEHgj+9PT2bRvTGDpyibnJIQwdKsBXzMWbmrYjbDajEgajSpC9tOX/Bek33J9lGCRX17Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vV4IBIpBa4dX2xqjgatPHaXMPaAyCwe4ek7jEDdMCIk=;
 b=ci3eX5Rz2fc/wQbLnW20ZBn1rAcCchJBCtE1FDPFtP7ZA0F63XdJhyg0tDfYdUDhOG3lWXjNfBh9MuG+1+C2b1I62Afr3axOQ4sOseEv6QDq3d6YVkcY41XJdrLcMDTRrbly5PjEcfE2ukAxM0yZ9V1m+4A4cBDlqWl830fqcx5TatbfvmbC1iV/sH91K61Nw0PHEp4tdRSOpwhDqykbD221yUVVlL4yXuPZMnsuSBBWYtHHd+E5SatNlUvVF355A05acKrR1BA0F/uIUTEdF71GE8FL9W7ndC4WCI2ERUTjHwu/JUY6Zv9u9TD/tKKU/ziZXHlsezT3McEZJinzLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vV4IBIpBa4dX2xqjgatPHaXMPaAyCwe4ek7jEDdMCIk=;
 b=cLCyNt7fktz15TOobdqlTlwCxC56kCWvl8q8Ym8c3eJ8yWWeEC+29Q9uTtSwzPgTj/Xz3xhmBnBMjRIQGqL/qwBZLLUaGaf1OQ881rgcHa2ee2Bu3f1Xghm9vCw1h25VWd+HF2tOCni6Fo+1n3p23DFefUJ0+GPSMChSr2lmAlI=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <volodymyr_babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Thread-Topic: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Thread-Index: AQHYTYhA4nLWVzOAC0uoUDkBvluxmqzt3yyA
Date: Wed, 13 Apr 2022 13:48:14 +0000
Message-ID: <6F9FAAD4-59FF-4D52-B08D-13E3920B3925@arm.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
In-Reply-To: <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 77ec27f8-225a-4bec-f82a-08da1d5446dd
x-ms-traffictypediagnostic:
	PR2PR08MB4746:EE_|AM5EUR03FT024:EE_|AM9PR08MB7244:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB72446173F174227583ACDF469DEC9@AM9PR08MB7244.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 8JLPoaktotRm/DMyaq+dJx1amcxQ/WPOVPyQ/mlkk9NUxUNep7uepWbfYcPz0Oogvt/7/VB45ZFRhLpPo2Pi4My3Nk6cs6jIsnzMRb+RCHhdrt0gprwAP+/PaXJmL5HwSGwD2jSI2V++IJnrVJEUyYxLfjhJ7EcEsJEb60xuSmPUpYodEcdv+xXNa3cr4e2HuhGl12sJPsRutajhYW2LsTw7qYgOMrGSk3Yjr2CSKsQssrp0FKzdBIt0i7ciG8qLeZ6oUt0tA4yPyfNM+rx8EcwuIL30S5r7R4ISAbwqW5ZFCgPMebIpFxDWWwfeqxwRdTzOGy5n6G1dg6+B+Vn5FTy/oEzv25zY2DtxtuSJVa1jHqW6q+ZtBgq40Lg7mCwL8ifZXVYjB64vLEBkAuwklGoZSPMr2KS1s+veeDwMwbcLCVwVWweMXn6jMlPe3/tymlQb6v4EzKzUiuKaxWmyCxrdswnqU2saVBBW6VLnTJwykx8IG35BtWobXBfzqpF9FS0raWjjS5Cw5KQVeu0CVO+EG6Us2zj9kc9dDwPn1AViTtmx8wr9XVi7Zjpu0TRRmaPUadO7P5pO/3iawVOlwjTsWAszCpfPgKGWoAmMJYUaT1NrDzaFdBXF+hkUD9xJETTuVKkPZPUjoZs9gOksWd1YC3SNIIshUld5xUDs3chVbzpAINqIBsi/bql3YODOv4+iB5bODHC+6uVCCVYYNv3Lj+ZNDD5TrLBmdgaS5lHR8ZrNW3ZE3EqeoIGdKPKH
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(6506007)(38100700002)(6512007)(2906002)(8936002)(71200400001)(53546011)(7416002)(6916009)(36756003)(2616005)(186003)(6486002)(26005)(54906003)(5660300002)(498600001)(64756008)(66946007)(76116006)(33656002)(66446008)(66556008)(8676002)(66476007)(4326008)(86362001)(91956017)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <6E72DF8707022A48ADF7DCF4DF948A33@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4746
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a1ae2358-a2d2-4949-3271-08da1d5441a4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	R9M+AAiNgt81mY7WFNLjG/O19jWrOYgkbpVc8Q/LkGlJ3M6a0rNh+r9VheTMsHtffC20jgbLZXanApPq2VIFQpittrf0dcGxDZD3I9fc/c7m1cVPhzylhCkfHz5to5ip95kzq5QLIA/52zlKvKlR6QPFY2kLH8DMxgcrjsm4zf9ukwEc188HwFNfjgXqXZEUdeNuWTHibDVyx3iqq9MNfULEA7OyMmvb7eBhmk9YBHn6iNT33Ya8Oyzb9RLYVw4Apctm+fzz3ttDZ/75eGy4zP0NpAWoRHhnn14IMymcgigVvASv11tfyjm5smd+502eEsdzGbycbCJ8whQBJNlzp+VJzKldnwoFmlmG8g4WQcDuQfEnqloUNxlHtitM9lpmeMI/0WlCDsa6lOLU4o/S+Y7SMweN4u8jphYHsf2Dx36P1mZdyxbzCgQ3SVetP7LUTYj5we7WCl9ssDdxCk8vzVI/102YYmjo2+zLXnFa20O9K+9Fn1UOqjm6X0B9mhMM+TBsZUCIehRQiFMrwEYYFlanZCXGK8CEj8qPW6wu5jajJzAlvGx9uELU1DnkwDZrUKr4M7f6CCEg7995zq+0ndvWGKBDk9DGAHFy0xtenDU/osgbMo7xrdubDXjEhRmPzrCles/NnDIIY/ASWA7DVCVGAN6MutXS//4UfGGrW2uX6+UYFiHHERRKAbg7Q6MU
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(498600001)(86362001)(2906002)(70586007)(6486002)(8936002)(40460700003)(33656002)(8676002)(4326008)(6862004)(36860700001)(70206006)(5660300002)(54906003)(82310400005)(107886003)(6512007)(356005)(6506007)(26005)(53546011)(36756003)(81166007)(2616005)(186003)(336012)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 13:48:22.9132
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 77ec27f8-225a-4bec-f82a-08da1d5446dd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7244

Hi Jan,

> On 11 Apr 2022, at 10:40, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> There's no good reason to use these when we already have a pci_sbdf_t
> type object available. This extends to the use of PCI_BUS() in
> pci_ecam_map_bus() as well.
>=20
> No change to generated code (with gcc11 at least, and I have to admit
> that I didn't expect compilers to necessarily be able to spot the
> optimization potential on the original code).
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Note that the Arm changes are "blind": I haven't been able to spot a way
> to at least compile test the changes there; the code looks to be
> entirely dead.
>=20
> --- a/xen/arch/arm/pci/ecam.c
> +++ b/xen/arch/arm/pci/ecam.c
> @@ -28,8 +28,7 @@ void __iomem *pci_ecam_map_bus(struct pc
>         container_of(bridge->ops, const struct pci_ecam_ops, pci_ops);
>     unsigned int devfn_shift =3D ops->bus_shift - 8;
>     void __iomem *base;
> -
> -    unsigned int busn =3D PCI_BUS(sbdf.bdf);
> +    unsigned int busn =3D sbdf.bus;
>=20
>     if ( busn < cfg->busn_start || busn > cfg->busn_end )
>         return NULL;
> @@ -37,7 +36,7 @@ void __iomem *pci_ecam_map_bus(struct pc
>     busn -=3D cfg->busn_start;
>     base =3D cfg->win + (busn << ops->bus_shift);
>=20
> -    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
> +    return base + (sbdf.df << devfn_shift) + where;

I think this should be sbdf.bdf instead (typo you removed the b).

Cheers
Bertrand



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 13:55:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 13:55:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304158.518727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedSn-0000w0-I3; Wed, 13 Apr 2022 13:55:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304158.518727; Wed, 13 Apr 2022 13:55:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedSn-0000vt-F5; Wed, 13 Apr 2022 13:55:17 +0000
Received: by outflank-mailman (input) for mailman id 304158;
 Wed, 13 Apr 2022 13:55:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aogm=UX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nedSm-0000vn-4Y
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 13:55:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 580b451c-bb31-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 15:55:15 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2058.outbound.protection.outlook.com [104.47.6.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-4TlGO2E9Pxq5mbLgewC7Ag-1; Wed, 13 Apr 2022 15:55:12 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB3071.eurprd04.prod.outlook.com (2603:10a6:802:3::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Wed, 13 Apr
 2022 13:55:10 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Wed, 13 Apr 2022
 13:55:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 580b451c-bb31-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649858114;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=17rpDyXkFfWd1OjpghRAvtVU4eiNvVJPNBhED5n+AYc=;
	b=W0rcSuUL1wgppg7d6QgWEG07agoB6KnpZgrS/Y1KN23H85XzvFIKI6k3plnYpW5D6qJHSk
	lquv5J3z2gEYOi9TVK1l1wwliETZPA4kEUk0soUXF4pmRqJ5hF6rtNMGslqpPGGwUM9pmt
	JQLUopcmx1fQiGe18F2yPaiMwXpVwRw=
X-MC-Unique: 4TlGO2E9Pxq5mbLgewC7Ag-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OJQUup1F/vEvClCRK3w2Y06pE7Go6eya4w4tNjKnljr4BnjgOnTflPZKnzp0mUrPL5rI4SgV9kX6CPDv/SLUttboQ/q6FH7ODgFPV2VVMk5vfLpvMTDjNJGztk1ZXO7q7flRF+sqz/Wi3d3b5+N/zUnSr7J/3lo7eGx09x+OP0Q2NLODaXSS8imLwWsxNLaMgtBOtcwLpKDpGHRFv57hYiefM5zgovnTysTzGY/OAoooy1AdYGucz7EWKws3usFjdbUtlB3LuiKmmKl1byAP0ETRX/EVlIlUq6cNqDk7yIKSZLj3emIu4r/b90Q7QJHMrz1ycSKXGL1PE215SrcepA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=17rpDyXkFfWd1OjpghRAvtVU4eiNvVJPNBhED5n+AYc=;
 b=RFaghzKXQNMBPCBBkMbzKoalvc8lJcOFKEsS2go7fQIKfbPxGFo/X1EkM6jMOYP71Gj7kb6g2CpGHYtNQVkyhKdT4r1Y5gXPLzqCYp1FBXgGka4uXCJmZCAsFO+27gxjW7GHmm55P1E3CQWQKe+v4BXdNY3lUUnW64/o8QiFw5D8ExGxoCPyBAxEf8ayMOg0aXTrAQIgxxm4M95cE3O4zj1OMD3ECT/pnW6vW+UnmdNIK0g71O5MV+hkhIIUkwV9kgo5GXMC+hI2CHix/iT0aEHuTE1pw1tj8VUmaTcNIlbfxoCzINJ+KX2r5vRnYZ7C0ICAsRj4bDnVpeTlvV9Hcg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <00731823-a353-21e8-81ed-a8af74b8d1dc@suse.com>
Date: Wed, 13 Apr 2022 15:55:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
 <6F9FAAD4-59FF-4D52-B08D-13E3920B3925@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6F9FAAD4-59FF-4D52-B08D-13E3920B3925@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P250CA0022.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::27) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e06bae03-4dfe-4337-9544-08da1d5539b1
X-MS-TrafficTypeDiagnostic: VI1PR04MB3071:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB30711C099B3D02BC5AAA84DEB3EC9@VI1PR04MB3071.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zDZ4r5F3m7Bd2odxxtO2Jt/bprIpn0eq65GYzDrmR7jp8+9U4ScbPYAWR8kQfyhyjjJQwqB8vbRKoYiWMESAe7w1j/VhZuGXvhzEA99TSw6nogouK4IKHpB14Rfth5DPglRcrn7QqONSMOuEzF0XhbM9G9venv1LyB89IL/Y/HN46fMBYfmqwOmOniikTVxjOgDeL87guZQuL31FNGgEHl9s3q9AINHFRTYfHng0vSQEw1tP20KyZgkUM+WoEGVN5c8NHrHIRpjAM2D99KBWWYb13X/YLY3z0DqiFTlSweKccxRta8zu0YZ4BRAAEEAB1yANCDnSwNf3HYxDM3Rg8BjR7HE+jwNgzju94yvcrXRVF6KUbtbTuzR+9Tr76oCwgIy9eyWVUnxN5CG5ShKz1wihabJBMT+wO2T3oBcVwJLew3A9j3lN2uP7p9Zokod54fnLm8sTehybcJCYfuwe4Ukux4k6V0wuL9aD8mcdbMwRVvwYdGIMnugnPirGhWzqp3J6KVkmFPNqOjTnIpFBwFOu5XoM3GKejNtGlv8aUIs7wI7+uTDs0KYhr1aeyozxn0/j4DZgxtofu8VxGGztB+QhchPIDjljBtZNXUVR8dB7o4Ri5pzqKDp2eeZxudrv6SpANDoKCvt0llyg9W1p9ncDk4BSA6iBVllL9t11u1N7/eCbjnSbRoiVhq1SEt3TI6/XzTOpjWTPy0mg0oTgjBb4TeeS3ZZDpRYod9HztPU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(54906003)(31686004)(36756003)(316002)(38100700002)(508600001)(6486002)(6512007)(2906002)(7416002)(5660300002)(8936002)(2616005)(26005)(186003)(66476007)(66556008)(6506007)(66946007)(4326008)(8676002)(53546011)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eU9aMVZUT01FaWdwc2NNZDZVa0h4VGtYc0k4S3dBdUl4K0p3dkdNcytqdnJq?=
 =?utf-8?B?U1NGS3NCTjV3T1dkblJJOTk0ZDVpSng4YWdxSWhYckNjVVhhcndLZjlBc2hv?=
 =?utf-8?B?djZ0RW1IOFhCL1l0YjJuVHlIa2Zodk1UMXViMlI4SGFrQXBCOC9uc2wxS0xj?=
 =?utf-8?B?TVE4bWkwQjY3amppcldVVVNsRUdCV2dUSWRTdldkazVIMFM2NU5WMDVKb052?=
 =?utf-8?B?UmU2enhnVE42bVFZUkJuUjc1cmVOTEdlSmY5NVRjTlAwVE81dE9WTjRmblhu?=
 =?utf-8?B?OFVCcjJBbDNaRDV5Z3BJSjl2d2hjNE5MbFVWSzhJQXR1SmtxalNRN3ZpS05q?=
 =?utf-8?B?Q0tnejFQcGs4MGxwMFM4SDBmWEdxN0sxYnZheDM4MFJFOGlCT1pwaWJ1Zkpt?=
 =?utf-8?B?OEVUOU8yV2M5VVIrWnFObU5oRWJPME1GL0liQzNIbWhReExWdHNpVGJNNTdh?=
 =?utf-8?B?cERMbVVVUmtUZzdSdytUNXFwZkZIWFFaR2RPY0NrbGVNMzFJOWwza1pHMUlt?=
 =?utf-8?B?TjFhaGRsZittSGJQY0JXMG1KN0JLTWhwc0RVaG1QcmUrMHczRm9ZMTRldWNH?=
 =?utf-8?B?UlZKS0tOaU1BR2RmYTVmTjMvb0ZhR2hmQ085aXp5R3lybHA5M21mVFYvQnhY?=
 =?utf-8?B?cDBodVNHaGlvK3lxYk4rdE43RWtseGxoakR2b1FRaUZvall3YjdaRmowSmdj?=
 =?utf-8?B?NTA2UjBZYWt3R2J3azJEZVBVSytQbXI0MDJDbDFOMXdCWlJQN2orandkb0tm?=
 =?utf-8?B?QnlISUJVdjFpWElXTUtkSCtyTmNhOWFPVDJkbWNmMUpqWFVNRUJmUFR5T0xC?=
 =?utf-8?B?VzM3RnhJYXVFcEI5Z2lka1lMQUNmbVkxWTJWTlFWbTFRdjJFWGdoQnFjam9O?=
 =?utf-8?B?SkdFblV1YVV6a2lsL284b3J0RFVmOXB3VUY5MzBvUXQzT0IzQTVNeUZzTUdh?=
 =?utf-8?B?Mjk0eWJEWS9ZWWlJZ3ljNGN2U1VRWmJjTEpUejE1aHY4MHd6dlZ4YzNmR3Zm?=
 =?utf-8?B?YXhvSlV2a0JlY2N5L0F2WFAxRlUydXZ0cnAxeVRqMVNlM1BxNStIbEgzUXJJ?=
 =?utf-8?B?U2ZwTUhoeFZDU0tIL1hJQVFRbm5JdzJtM2hXWjNBTHdrTVl5UlNJNGR2NFU4?=
 =?utf-8?B?UDMvNXEvK0xsTjdUeGhMcGZ0U1l0ZXZBTFY3dDVvRllVbHdLYVhUSjRtbnpo?=
 =?utf-8?B?cW1McUF1amFqeTlGZ0VRTFlzYUJpemRETlhOYUVZWlBza2ZmTWkxaHhRL3JV?=
 =?utf-8?B?SVZTQTY5V0RTWnZZN1c1SjhPbzlYUE15alk0dENiRFVIREZrN2NCY0FRajFL?=
 =?utf-8?B?aUtQcFJSeGFSMCtFKytoclFCTk1RTk9sK0J1MFJVbFUvZHBFVkZUR2NPZi9n?=
 =?utf-8?B?dHdhcGdiRGdCY3FmSVQwc2MxNFdSK2F6MWYzUGlCOUdsaWdmQWYxeGtVVFp3?=
 =?utf-8?B?UUNLM0Evc0tnYjU0S0pJbUd1MFFjem1mWUFwcWY5WXRPdTc2QW1hTmVTT0g0?=
 =?utf-8?B?Ky9xUFBlMS9BWUVWQzc5eFZxTXhnMUpYV2wxV3FCME1PQzNQeFZ0UGZGVElW?=
 =?utf-8?B?UGZheFR3SGdvUnlYbklUZHBVT2lRSDNiWk9ScGxwdVJqRmJGV3lUWEI1SCtF?=
 =?utf-8?B?TDVTTitJWTJSYWtheTRmUlN2Uzd5c2h2WkJpN3VXMmhBeUU1SldUWmZiK25E?=
 =?utf-8?B?bVo1OTdRSnRLT213YU1GczZ1R3hYcjQwYS9VeFU5QmVkR3g0SmJLczdyMWxM?=
 =?utf-8?B?S3VMSUtrSzJEMFpNSTh3dmdLaFpBbFJMaUYvbU56SDN3QVJhSDBza3ZuTEN5?=
 =?utf-8?B?dnJYS0hxNVdpUUlnOWJpZzc5V0pBa283TFBqR2Y3YXBDVndLeXB2KzFqU05D?=
 =?utf-8?B?WWo3UjNDT2ZQdG8zdnFxbzNLQVlBNnpZbVBxbytTam5kZXk0aUFSNEVtVzdv?=
 =?utf-8?B?UXdHcVV2dXdONk9oVVozMkdZQTJ2UjI5eHp2dmJoZ2p4QVhvR2k1U3grazZv?=
 =?utf-8?B?aXEvbVAvNlNTU2ppMzMxd2tOVjc3Z3krNkNRVm4wUVgrYjF4ZHREZGtpcUla?=
 =?utf-8?B?WU5yQ3NHSzRjbGx5bEFoenhEWTZ3NXpVNlJBKzBFMFh3SmNvcVhSR1FJSUJm?=
 =?utf-8?B?VTMyN0Q2dC9lbmkwZUtSaDhpdUdGZ0VoS04yZlJ6S2FCdTB6aE9aVDhmTE1C?=
 =?utf-8?B?RlNocDNMQUN6TTAzUUZoUy81dG80WVJQbGFmM3dPSzkxTUJZbjFoV1VRQUs4?=
 =?utf-8?B?OFNqTVBJd3MxSW9LdWFjbDZodVJoZ1lVMzJMYmJZd1lWNndGUVJ0QS9QdDRY?=
 =?utf-8?B?Ylg2cXJua05yUzAvc0UrWTlwRFUxSEtJai9EOW84SWpoa25sdnZVUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e06bae03-4dfe-4337-9544-08da1d5539b1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 13:55:10.5742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OB6Ls+6CSHpQXAvvp2OiJjc2fMVPrlvOH2eMGQxQ58Z6uBDZlAe4CvTsKcHGaxWxuIqeZY9JOhHr4KEdBiCXhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3071

On 13.04.2022 15:48, Bertrand Marquis wrote:
>> On 11 Apr 2022, at 10:40, Jan Beulich <jbeulich@suse.com> wrote:
>> --- a/xen/arch/arm/pci/ecam.c
>> +++ b/xen/arch/arm/pci/ecam.c
>> @@ -28,8 +28,7 @@ void __iomem *pci_ecam_map_bus(struct pc
>>         container_of(bridge->ops, const struct pci_ecam_ops, pci_ops);
>>     unsigned int devfn_shift = ops->bus_shift - 8;
>>     void __iomem *base;
>> -
>> -    unsigned int busn = PCI_BUS(sbdf.bdf);
>> +    unsigned int busn = sbdf.bus;
>>
>>     if ( busn < cfg->busn_start || busn > cfg->busn_end )
>>         return NULL;
>> @@ -37,7 +36,7 @@ void __iomem *pci_ecam_map_bus(struct pc
>>     busn -= cfg->busn_start;
>>     base = cfg->win + (busn << ops->bus_shift);
>>
>> -    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
>> +    return base + (sbdf.df << devfn_shift) + where;
> 
> I think this should be sbdf.bdf instead (typo you removed the b).

I don't think so, no - the transformation is to remove the PCI_DEVFN2(),
which was another way to drop the bus part of the coordinates. Patch
context also shows that the bus part if taken care of by other means.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 13:58:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 13:58:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304164.518738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedVy-0001cp-4t; Wed, 13 Apr 2022 13:58:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304164.518738; Wed, 13 Apr 2022 13:58:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedVy-0001ci-1b; Wed, 13 Apr 2022 13:58:34 +0000
Received: by outflank-mailman (input) for mailman id 304164;
 Wed, 13 Apr 2022 13:58:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zxri=UX=citrix.com=prvs=095d3edda=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nedVw-0001ca-2w
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 13:58:32 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cc002758-bb31-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 15:58:30 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc002758-bb31-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649858310;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=CByQ9muaD65LqCjjKGHJMLaPvxP5hjEItaC7vwN6cXY=;
  b=at7nKIPtpYk9W+i8NULyXHFltfLSz0Z9a5NdmpiwaCfWJgmzn3fGWwPh
   jhrnh4AVKYzsJjG87xDSBkz6RYQY8yM+mnZvaKy2tsxTdqrI5Tps3HTcT
   wNWsx/LGEruKJ31h7IXdPQ1bEzHZMc+LlCziuKice3YcfrsxkvLvv7n4I
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68803426
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ErJ3aKisk0RzBldDEj363ANMX1618RAKZh0ujC45NGQN5FlHY01je
 htvWj/XPKqMajSjeNskOYWwpEkP657XmoI2TQE6pSw9Figb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1rW4
 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQN5NZPtsvgBajgGLApxJotGyZGYG1Hq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiON
 5JCNWAxBPjGS0BmPwwrBJYFpcihwWPwSSNKqlDSpJNitgA/yyQuieOwYbI5YOeiXt5Jl0yVo
 mbH+WXRARwAMtGbjz2f/RqEhPLLnC79cJIfEvu/7PECqEKX7nweDlsRT1TTiee+jkmyStdOM
 Xse8yAlrbUx3EGzR9y7VBq9yFactwMYc8pdFas98g7l4qje7hudB2MEZiVcc9Fgv8gzLRQA2
 0WVhdrvCXpKuaeMVHOG3r6OqHW5Pi19BWwPey4CCxcE6t/LoYcvgxaJRdFmeIalg9uwFTzuz
 jSiqCklm65VncMNz7+8/13Mn3SrvJehc+IuzlyJBCT/tFo/PdP7IdzzgbTG0RpeBILJRWegl
 mQYounA08sBFreNpQLSesxYSdlF+M25GDHbhFduGbwo+DKs52OvcOhs3d1uGKt6Gp1aIGG0O
 Sc/rSsUvcYOZyXyMcebdqrrU6wXIb7c+cMJvxw+Rv5HedBPeQCO50mCjmbAjjm2wCDAfUzSU
 Kp3kPpA715HUcyLLxLsHo/xNIPHIAhklAs/orihkXyaPUK2PiL9dFv8GALmghoFxK2Fuh7J1
 N1UKtGHzR5SOMWnPHWGodRLdA5WdiNmbXwTlyCxXrTSSuaBMDt/Y8I9PJt7I9A190irvrqgE
 o6Btr9wlwOk2CyvxfSiYXF/crL/NauTXlpgVRHAyW2AgiB5Ca72tf93X8JuIdEPqbwypdYpH
 qJtU5jRXZxypsHvpm11gW/V99c5KnxGRGumYkKYXdTIV8c5GVeYq4O+I1OHGetnJnPfiPbSa
 oaIj2vzaZECWx5jHIDRbveuxEm2pn8ThKR5WE6gHzWZUBSEHFRCQ8ApssIKHg==
IronPort-HdrOrdr: A9a23:BYsV2qNE5xOSMsBcTqKjsMiBIKoaSvp037BL7SBMoHluGfBw+P
 rCoB1273XJYVUqOU3I5+ruBEDoexq1yXcf2+Us1NmZMjXbhA==
X-IronPort-AV: E=Sophos;i="5.90,257,1643691600"; 
   d="scan'208";a="68803426"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BGQn8F9qbQKAWQOXmwg8Mt1ZjFsVHkou1kXraSgQ0UF6VFgGhDvu8MnEcuBo1tzlqQK+w8uKA0NVfd/DQa9SI2kXOBMhPVC09tsyhtl4VHkhbJwqZxF5v2d0XAbHt3PbsRysUz4pLBAtSJSE0RNG1Qx4l3Oe3emYDokYCWo6fCUa04Wo/Xd8t+XAMDyAOPLqo0M7a/AZ46uMvOsEHTT3M8dgJZKoTE1MZ6YkUo3YmZcRZBuAAfpte0sYpT5w+BVZVlpMH3C+eeH6FXxbfqD26jjEeItvaVE9C8ODdbRmI2Pz+t8GsQEsFNdYCMMZyLr78kt4A6tE9zMBOWSKsb9WmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yijyodCYhp0irwzOqbT7mgex0fM4CkDeesh7WA4yTkU=;
 b=NpxF7BKoqD+/sTKLDcTFlPyC4rdkQp9hlYkfCdrpuxLVocCqmfQ+xQMsxQwW5Q0loOtmn1gvPsV7DT/qcMap5S2nU6pxc89dmRWZd4tRO94DxQVOZKhjlDxtz25LG8/wdOcLXPkk452G5ODdUgE9pVcFXhrL/+dnGVUPVEU2bcu/byF8aMRx2iQY22qKmImzeUYwHT6vKS8lXVBBvKEKF+lonR8s1IRTPTjzRVMtdnNg80QPf1E/tznDnfpo4izI1SQJnCCs3TvsmJLg7Ce6HyJEA3FFobOMQY5Hr5olXYb+//diYlXmFIBuA6ZuWN09zapAlPwDqjwT2RhTA3ux8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yijyodCYhp0irwzOqbT7mgex0fM4CkDeesh7WA4yTkU=;
 b=xQcDny9/dF9nslaVKOxKJP602ZRqgUr2s8DnC/ZrX+HR91cgtfJbHd30zEHqJdHGRcyyW9CYBBp7/9AjuLSV5URxoAPw7+9eV4lBymzBlpiQgBY+JqVB9QzMVBHGara0XSeO41E1e2BGTzx3fSvhEe+d6HnGObS7+EuBiaPBOZ0=
Date: Wed, 13 Apr 2022 15:58:13 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Kevin Tian <kevin.tian@intel.com>, Paul
 Durrant <paul@xen.org>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Message-ID: <YlbW9dKU8MEeHlfz@Air-de-Roger>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
 <6F9FAAD4-59FF-4D52-B08D-13E3920B3925@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6F9FAAD4-59FF-4D52-B08D-13E3920B3925@arm.com>
X-ClientProxiedBy: LO4P123CA0141.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 93533928-bb6d-4998-f31c-08da1d55a9c8
X-MS-TrafficTypeDiagnostic: BY5PR03MB4981:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <BY5PR03MB4981900365874144ABEC95208FEC9@BY5PR03MB4981.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5xfAZhROJZcXgcsJH4G99Dg7a5hFSG77rdbvBl0X3ZPQsZUhZ+TTiqZWotKG7XseqJFyHPN6IsnXn6GJy3Obp8JOMMq/tjfwvKfqEU4nIr9G1HePyg8WbIxQnMTEWvqo6jgRdyhnmsaW0NihukqcYSFsPynxrOwNTbYQJIrAx/ZPzhfXcsg3DaQOx2Zg+1yVTmLhgQvlZvugI7A6VgLhKuRYgEEpV1qpblB3QIwe9C+TRc+X1TMN604qDIfmefAv/oxuYgHTE8+x8Nzxc2LBdB8GOifpdLlT65amlGD61BlbM4Wbe0t4x6YwR+RCBa8kAiEDD5m+T3mK0cR2r0n7J9c/snpLWK2VSPynuQp+XI24KXGXUbQWOyWsPIU0oGZ2EzX0uvDjy3AN0SPeRnbyioqsL1PSv7NaT2warZGzkYBbXeHOgWVqLHNpdNPEhLj0q5o8gEqTipfbLOQ0X8iBwLQEseEkvTIcW/TL2WbHC7CqbtOhX43XofRMPJrQwy+MzeCLGOLWRnj79ktslyVvqBK5sT4kfoldMI/vu2H917CAUZkCV1/SqAMgRtBao+yiutCpPHgg3s7qQfQGogdskUlW9Ci36+u//XeWSpQC+67lfuWUhmp7mNzE+y5cumKTGAA6pz2u+uz85Tw94PUCMA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66476007)(66556008)(186003)(4326008)(8676002)(5660300002)(2906002)(6916009)(53546011)(66946007)(26005)(54906003)(33716001)(85182001)(316002)(6486002)(6512007)(9686003)(86362001)(38100700002)(83380400001)(82960400001)(508600001)(6666004)(8936002)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0xPbThldVRzNWE4QjhzTWY5enFydzM1NVN3OVhydndPWGxEOXp4akhpbGlY?=
 =?utf-8?B?SzVCZ1NpNG5lK0tiR0kxTUVaZFEzSndiRU90SXJka1dzQmJaRDU0Y2h6N0hw?=
 =?utf-8?B?UG9FaHhlMmY1Nm9EN1lyY2UxWUJ3QU12aEFGVFA5VHh1YVlZODF4MmZGMnlt?=
 =?utf-8?B?Wjc1cXA3dXhQQUFSSUxWNUxMbFBxRFI2QlFYMy91ak9acDA2WEJVeUZtUlhy?=
 =?utf-8?B?WlhWOWNEOVpjRmtrMXhYeXc5L1ZDOGZVZWpiWXZpcDN0bWg1NHNvNFJWSEdV?=
 =?utf-8?B?aWJqcVhDUW14enVVaEg2QWVhMk1BMi9DdVB1MVNHTjlOOFpNOFRJQVFhNXVE?=
 =?utf-8?B?N1c4WmxoWFhXTWUzQVJlT1VrYWxoQVo0N05MSUtQRzA5Ym5oTmN1L2RVdWtR?=
 =?utf-8?B?YTB1Mjk4THYyM0VlVXFObHd5UFVPdk1GUmRWOUtLcHhWaG9JWG0zWUJFOW5D?=
 =?utf-8?B?QkJGczNEZDJOc2pkSjVkdmdHUExQdElucmFSY1oxT08wMkZSV0JwL01Ddm1K?=
 =?utf-8?B?TlNDTGI1eS8xV2lWSHkzY042cFNRNmxuV3ZVa1hYdW5neUsyaVRVc0x4ZTlT?=
 =?utf-8?B?dDU4UWxOZ3l6eFhsVGZQc2NFY1EvSG9sUWJNa0R5U3VHaWRpYmtzSDAySkdl?=
 =?utf-8?B?OTFkZHVrK25vMHpsZGV5VU9vaWxST3ZWUXVJOUQ4cHhvUW9rSHdsM3ZwL3Az?=
 =?utf-8?B?NmpJSWVNemU2N1h1c1FWQ2VIbVRIZFpadzV4QXA5bjN5dktrSmdEWVBkeEtX?=
 =?utf-8?B?UUYrSnVUK0oySWJRSnZVTHlwVEpvNTIvcTErNjBWcHpVNHFBUTAydWFRL0lh?=
 =?utf-8?B?RUJKUGdZc0hFck1aVUwzbjA4U0lSV3RHVCtJVkozRGdMZ1VWOUZaWDlMdjE4?=
 =?utf-8?B?WlV5V2M2Z3pKOTU2aXdqY3A5aitqWVJCeUtEYk9hQ3dYMzVHRGRseXVmNHVj?=
 =?utf-8?B?VVcxWG5ZOERlcVd6Qjd0N2ZWV1V3eCsyOUtvekJObEhIazhuajlhblpuQ0Vh?=
 =?utf-8?B?cmIyUHlrcDFIeFV1VHoySmtQaDVYMngwcWtoY0ozbFlPZ2trSTF6NWpoUlVt?=
 =?utf-8?B?Mmt5em9hTVpBRnk4Qnk5eEF1R0Izc3BtcUtGd2ladmhXaTEyK2k4aUpobW5j?=
 =?utf-8?B?bW5rTEREMEJzQVFRTWIyQk42dkhHbVI5V0hjQ3RKdzJtbzBmQzdRR3hTd2ps?=
 =?utf-8?B?YU5nbHdaS1FnSGo2TjBjUjdjN2RiS3Byd3BjSGNSOFR1MDJVb1FXR0xUYW02?=
 =?utf-8?B?RWVOYUZSUVM1MytFWXBBbWdsUmRLN3VEQ0JOUkdTZmorVFlOM2ErRXJUUkwv?=
 =?utf-8?B?aDZzcFVUalppeFV2RktRRlRWalJkd29TVzRhR0lRL3Bpc2VEL1J2ZnlrbnFG?=
 =?utf-8?B?RVJVYUxVbVVESnovaWlZT0NSd3lhZWFYSkwrZHpqVGRtRGtTRnQxWjA3T3d3?=
 =?utf-8?B?SXJNT1NBOEY4VElFdVY0SEpQeGVuUVRxelZsRmdXRVUwZERNc3NLRDFiemJr?=
 =?utf-8?B?UWVzVEF4VDdWQ1ZybkNQdVhpMk03eVFDdjlaaFpmSXZQbzFWWTJRTmhVNFJq?=
 =?utf-8?B?T0dWOGFXZUpBK25PQ3VuaDRXUThMUG5Mc1BGcHE4S2JISXBkMUZpVE9zakY0?=
 =?utf-8?B?Q1IvYmV3SlJXazErNVVtaHJMWU5pQ1NYOWVFdysxTDZyMXVuc1pyOWxnNDg0?=
 =?utf-8?B?d0R2WGJUdzdJWDE0aUREbnkzZDhZdHFFKzBIVjlTN2JsV2pQaFF5akFxK1NC?=
 =?utf-8?B?MnJ0Z3VXdm0zUUY3ajEwMzZrMW1KdUZiNStyQ3dncFM2SDE2enFzYkdqRjlj?=
 =?utf-8?B?bm5aSmF2bWo1Mkx2R1RhZFBuZlhSWHRXbmlMTWh5a29oUDBRWDVkWlpyZWJa?=
 =?utf-8?B?MUJNTEpwd1JsUUNTdGUvemFLODVsa21MNUlpYnYzSGRBRForajlPZWxtRGkv?=
 =?utf-8?B?cXRmWEtrOTY5S0dnQXBmeW1abmJvdi9ESzZLRTBmeFd0QXJOTE5QNXJ3bk9Q?=
 =?utf-8?B?VXZLRW5GK0FXd1JKVFFNc1V3QlU0bUtXenRYempSZkh5czZPYmdYSU5kMXEz?=
 =?utf-8?B?bTIyb3A0blh2MDJaTHFEdnJzbEFwK2c0bFU3dVZ3SlpQMkFGTEphSDZsTTAx?=
 =?utf-8?B?S2VpYVZick9TNXBzNmYyRkhPSFdXQWFBdm5rd0s0Vk1QY083UjdDcHQ1RlBy?=
 =?utf-8?B?Ty9wR2RLbDViVW5RbEVWcWRUbW9abGtDRlVEMFQxaFRCVnVMbXlNeXpYRERN?=
 =?utf-8?B?RnNacUVwZjNadmw0bHMySE1VV01OUGdXeWNEdHZiTXhUYU5uM0dLdWJsR25o?=
 =?utf-8?B?L0lwVHpXUWF1QXBIekgrU1BjYTZGNVNSOWZXZDBEdmZCNjZ6bUg4a3BybGxM?=
 =?utf-8?Q?ERUj51eF/IKbm1nE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 93533928-bb6d-4998-f31c-08da1d55a9c8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 13:58:18.7884
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IdBnww+oZGlcLxI1q9RWUWQRdo81xoBR8V3wgHlOhkTG9UbmeeaRA9kwVIa3bTj5jcTn6YSX9jYdJNL4IDIqoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4981
X-OriginatorOrg: citrix.com

On Wed, Apr 13, 2022 at 01:48:14PM +0000, Bertrand Marquis wrote:
> Hi Jan,
> 
> > On 11 Apr 2022, at 10:40, Jan Beulich <jbeulich@suse.com> wrote:
> > 
> > There's no good reason to use these when we already have a pci_sbdf_t
> > type object available. This extends to the use of PCI_BUS() in
> > pci_ecam_map_bus() as well.
> > 
> > No change to generated code (with gcc11 at least, and I have to admit
> > that I didn't expect compilers to necessarily be able to spot the
> > optimization potential on the original code).
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > ---
> > Note that the Arm changes are "blind": I haven't been able to spot a way
> > to at least compile test the changes there; the code looks to be
> > entirely dead.
> > 
> > --- a/xen/arch/arm/pci/ecam.c
> > +++ b/xen/arch/arm/pci/ecam.c
> > @@ -28,8 +28,7 @@ void __iomem *pci_ecam_map_bus(struct pc
> >         container_of(bridge->ops, const struct pci_ecam_ops, pci_ops);
> >     unsigned int devfn_shift = ops->bus_shift - 8;
> >     void __iomem *base;
> > -
> > -    unsigned int busn = PCI_BUS(sbdf.bdf);
> > +    unsigned int busn = sbdf.bus;
> > 
> >     if ( busn < cfg->busn_start || busn > cfg->busn_end )
> >         return NULL;
> > @@ -37,7 +36,7 @@ void __iomem *pci_ecam_map_bus(struct pc
> >     busn -= cfg->busn_start;
> >     base = cfg->win + (busn << ops->bus_shift);
> > 
> > -    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
> > +    return base + (sbdf.df << devfn_shift) + where;
> 
> I think this should be sbdf.bdf instead (typo you removed the b).

I don't think so, notice PCI_DEVFN2(sbdf.bdf) which is extracting the
devfn from sbdf.bdf. That's not needed, as you can just get the devfn
directly from sbdf.df.

Or else the original code is wrong, and the PCI_DEVFN2 shouldn't be
there.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 14:00:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 14:00:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304169.518750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedY9-00032U-JG; Wed, 13 Apr 2022 14:00:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304169.518750; Wed, 13 Apr 2022 14:00:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedY9-00032N-EE; Wed, 13 Apr 2022 14:00:49 +0000
Received: by outflank-mailman (input) for mailman id 304169;
 Wed, 13 Apr 2022 14:00:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nedY8-00032D-W9; Wed, 13 Apr 2022 14:00:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nedY8-00034K-S4; Wed, 13 Apr 2022 14:00:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nedY8-0002TK-G3; Wed, 13 Apr 2022 14:00:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nedY8-0006dc-Fa; Wed, 13 Apr 2022 14:00:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2szSO+lvOLD459rNQgscRWQsa60pRsLSTwfkS18IG0g=; b=oj2vzsvHo/Vta1wFpthmN+fh8k
	sYNxgWB4UEGwGGn/KnRg7ayPBXd/F/gN7yNf2x0u3E7viwfBC12YnyPVd89mI9foDwHu0wYkkkcJX
	s3+VFpRYEHKXXZGdtuXpL1I2RfS7Dv0vA+m49OU2gkNpyN1axAmFwgX/st2WOMpJYhvE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169365-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169365: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 14:00:48 +0000

flight 169365 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169365/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  363 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 14:02:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 14:02:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304179.518759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedZw-0003gW-Tm; Wed, 13 Apr 2022 14:02:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304179.518759; Wed, 13 Apr 2022 14:02:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedZw-0003gP-Qt; Wed, 13 Apr 2022 14:02:40 +0000
Received: by outflank-mailman (input) for mailman id 304179;
 Wed, 13 Apr 2022 14:02:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0JnL=UX=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nedZv-0003gA-A8
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 14:02:39 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on061d.outbound.protection.outlook.com
 [2a01:111:f400:fe07::61d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6029024c-bb32-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 16:02:38 +0200 (CEST)
Received: from DB6PR0301CA0086.eurprd03.prod.outlook.com (2603:10a6:6:30::33)
 by AM6PR08MB3063.eurprd08.prod.outlook.com (2603:10a6:209:46::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 14:02:35 +0000
Received: from DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:30:cafe::60) by DB6PR0301CA0086.outlook.office365.com
 (2603:10a6:6:30::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30 via Frontend
 Transport; Wed, 13 Apr 2022 14:02:34 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT025.mail.protection.outlook.com (10.152.20.104) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 14:02:34 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Wed, 13 Apr 2022 14:02:34 +0000
Received: from bca559506bb5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8B406407-B2EF-4E6B-A886-47741C2E89D1.1; 
 Wed, 13 Apr 2022 14:02:27 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bca559506bb5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Apr 2022 14:02:27 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DB6PR08MB2838.eurprd08.prod.outlook.com (2603:10a6:6:23::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr
 2022 14:02:25 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6%4]) with mapi id 15.20.5144.030; Wed, 13 Apr 2022
 14:02:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6029024c-bb32-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SlaXcmPF2Jq7FkbqtO6VrKeWGtKMPoFB6D4/Mr4ZmJ8=;
 b=kBj52NaeXEVDpc93zt4EB6vJ5WMjkVHNIIU6RHoCuVACgBv99brTBWR1/FafvdAW6FigxCSagIMad916iiIdll2U9Fk3Knq6IAyEvpuGBl2LDjLk/QC7x+rjg0vfA2w5/o/sKaG965N+6aryrzZT0BMvin95XZLVJTr41Fl/8sU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1679c511e32461d9
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gcb3ex33roGbLtvXPA1ApFvgcleMcjoWIfOFTXXwF4/dpi1IyswmP3lyik9X3oeVR6fEDbBjlOAGZV7Uj/sN8y/knGQdIrOfmqpS7o8b2oKGu2DA8PbtxMlzMqDm7LrYFKFokeBdwJFrcBVC5sSyQMO7suvmxNEEtC4m3xqH9XCHxjRdckXlBikScLwv/OPKRzoFes7Ezn0yEHX0+0t1bzPyxb7Za1AbvxXg0Mc004DKQUZPwwmK6vN8lmr4g/cuI7rDEGQ9+KYxua5NYbRXNH7uSZoUsvMb4qclSVNFY6lCji3YE5opZLhuvuqJBbiNfG3G3vw42izdv/e3e7rNdA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SlaXcmPF2Jq7FkbqtO6VrKeWGtKMPoFB6D4/Mr4ZmJ8=;
 b=NlM5r0j6Z9RaSWTYGl7U94glBtXHZrr8dftGFcopCGErOrEs9j+F7faJDGJs/NYRiQ7Aty2UWN/w3Ms404HYspbdfTfiEJHQSwyN3eshmA92PALHJbau7R+YUATx60bkoCs2smzgdta/DuMxaRp/XBlTF/6E0igu0bpQcELYh/tWsxgGPbup31U2RAWedA83WccV+PwgWpKP+VqsovUU+ecAnx1GyabcR+cf7XrsZ9LHjMXXJcqepiXMfCilNt9VPEqGzc1hSpZzZXsYqW7AMdf5gRaiTr8fr46RszMkqjWYA63UWHjnhG9XzaycqhcChGI1/KyIVS/Rvwf4DkoYTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SlaXcmPF2Jq7FkbqtO6VrKeWGtKMPoFB6D4/Mr4ZmJ8=;
 b=kBj52NaeXEVDpc93zt4EB6vJ5WMjkVHNIIU6RHoCuVACgBv99brTBWR1/FafvdAW6FigxCSagIMad916iiIdll2U9Fk3Knq6IAyEvpuGBl2LDjLk/QC7x+rjg0vfA2w5/o/sKaG965N+6aryrzZT0BMvin95XZLVJTr41Fl/8sU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"marco.solieri@minervasys.tech" <marco.solieri@minervasys.tech>,
	"lucmiccio@gmail.com" <lucmiccio@gmail.com>, Julien Grall
	<jgrall@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH early-RFC 4/5] xen/arm: mm: Rework switch_ttbr()
Thread-Topic: [PATCH early-RFC 4/5] xen/arm: mm: Rework switch_ttbr()
Thread-Index:
 AQHYM6fbReeSkSu3okSScrrMlkjRu6zQNoyAgAAKUgCAAAMDAIAAAf4AgAABeACAFHxvgIAJUxsA
Date: Wed, 13 Apr 2022 14:02:24 +0000
Message-ID: <B0A4B2C7-D63F-4796-9C4A-7DD7FD688698@arm.com>
References: <20220309112048.17377-1-julien@xen.org>
 <20220309112048.17377-5-julien@xen.org>
 <140E78FF-8281-48BA-BE13-C4B3E12F34A5@arm.com>
 <9673f201-080b-8800-65a2-144d21b030fd@xen.org>
 <7069C935-A275-4D1A-80EF-C20DE1D3103C@arm.com>
 <284b300e-d400-4bd7-0b0e-aa53983d6ee8@xen.org>
 <099CD8F1-C92A-4402-897F-538821AD66EE@arm.com>
 <7ff80bc6-5937-43aa-784b-fbba016bcfe3@xen.org>
In-Reply-To: <7ff80bc6-5937-43aa-784b-fbba016bcfe3@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 8b0269bb-0429-419e-3bd3-08da1d564276
x-ms-traffictypediagnostic:
	DB6PR08MB2838:EE_|DB5EUR03FT025:EE_|AM6PR08MB3063:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB30631E7FC53FD33B73B559339DEC9@AM6PR08MB3063.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jPPMrlpMmvrUhYTqlRDmsptuaXF9SxoAQzuFRBiNo1D43Ao/44NdUe2m/nJz9mDlYwl63Jw8HVzS770FLTxH87t8G+ePlxqab2GAbiAFQTEFphg7MofsXXgDp+WjTqHCjaUI5+l9hG5PS8M0EHKn9DsjjkYASLfeRI2xHNv4ENZmEiA9JwX3xKi++hZ7WNIxpwsLwuTul+UJFyKmvn8nr8nCd2bgVZf45r3pbYuL5joLWxcJbVYZp9etGhKNiTJuEenSyQCNE58f8r/SHB5wss/ZjILEE85IXPg+wAf+trid+ncjv2JHYhzKIarQYSzEraYi5rWZIkG6tI3djIBId8EDbdPfEh+JyO+oITtlqPTOoGcXrkmmb9s8dzf+evqWP2ASkQsQLaz9L8CqX3OYqFNZ81LTELi912BPjn8CM32AHqDiZaV+kIr0SjdoHNenT+Xk9dvm5w4HmLkH9fKhbCgHc4AW/te58wJfymXUlezMLD1D/GmrPeK4ETFxwz9SWifE9Drzup055cMCLwRCLc5OLEJPi+XbeAvy36SdphrgJOE7bQF29Zin4nAoMfkQgXh6iXjHNfAg78Bo0GjDgJ09RJEUk7IgkggBO4b51pbNfQyX+j3o8nZvAT3X6v0IPfNr9umu4t+HufIG9yPP6ABf4wAvIMAJu+6Ph45uTAh6RPNYHEHxMe8l+ryPnqBFwN5Iuoivg6YxLPATye0463FgazERcK2YfMVfIyROPS+ejpL3/CwaMo1lMfbXfi1pwPuOW2j6EImOH0kvwfj/tg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(38100700002)(66476007)(66446008)(66556008)(83380400001)(76116006)(66946007)(6512007)(53546011)(498600001)(2616005)(26005)(5660300002)(4326008)(6486002)(186003)(2906002)(8676002)(36756003)(8936002)(91956017)(38070700005)(33656002)(64756008)(122000001)(6506007)(6916009)(54906003)(86362001)(21314003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <4EA2764CEFAA324887413FD22981D123@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2838
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7be172d7-9667-4076-4ea7-08da1d563cad
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	msueOpJd8pbO3K+jUKqfvDIuKoWqQ3u7pRQvIiJ+attMwmVYd0jmDf4v7/Ld9lYzmFC7G2oTUU7YrK9GM+YmHXwW97OKv+7GZTvRVEov2BjSZhd28TXLQlu8bBdKBEjxD0hImTLHWFEsLnpxixZDrs4ROuXqsGKKpjQlAhi1xuY2uwykefokJFT7YlfqKVOPhwIboXr8INze9vRxzbWT25UnCZCdHunrNDfujyBR8KwQ15ABEu2HvlhnM3ilMFqdrCewEVHVe4CspLKcb2wBXr/5iXdOT6gWZkOfa4U7N9M4CO3KxkxJ9QoDYtVtLZfn7D/AKJdZ79N9zSeU/3IS+D9w9WcLmflaIV+t0MU/ytid6H6v55IjYBpxee5tTjEDhIZW+TRsMTHqvpNhkHEWJ6z9mYYFn8HVJw+dXWsCM2HYAjLc6dbQvdTf5+xuBuYmTNOSupZJ9Rw/KgAkH8ASzfc2OS+mf8ZKMQ3329JGK55nhYPsPGNfKgHrM214Xc9/g+iCdNjv/4aLxE7zcnbG1NoqFTXCmGqsI7INU5lolks4lj8coDTcXzwI3BA/adM+2oMDdkcS03KJaxJSiOAa5jJjf10v30/Q555sjRwQbhjKlisaYhJORGslTz59HkYk/Q6s9MSCWWsIiHoKk2523lAeLk73mjMZkueE5wEzUDqdpQsFJtXx/GnYtXZaYbbyWFD4G+oAiPhWTQCnhUOyjg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(107886003)(2906002)(82310400005)(2616005)(498600001)(6486002)(70206006)(70586007)(53546011)(8676002)(33656002)(83380400001)(4326008)(6862004)(54906003)(8936002)(336012)(26005)(186003)(36756003)(6512007)(40460700003)(356005)(81166007)(5660300002)(47076005)(6506007)(86362001)(36860700001)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 14:02:34.5784
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b0269bb-0429-419e-3bd3-08da1d564276
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3063

SGkgSnVsaWVuLA0KDQo+IE9uIDcgQXByIDIwMjIsIGF0IDE2OjM4LCBKdWxpZW4gR3JhbGwgPGp1
bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpLA0KPiANCj4gT24gMjUvMDMvMjAyMiAxNDo0
OCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+PiBPbiAyNSBNYXIgMjAyMiwgYXQgMTU6NDIs
IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+IA0KPj4+IEhpIEJlcnRy
YW5kLA0KPj4+IA0KPj4+IE9uIDI1LzAzLzIwMjIgMTQ6MzUsIEJlcnRyYW5kIE1hcnF1aXMgd3Jv
dGU6DQo+Pj4+PiBPbiAyNSBNYXIgMjAyMiwgYXQgMTU6MjQsIEp1bGllbiBHcmFsbCA8anVsaWVu
QHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4gT24gMjUvMDMvMjAyMiAxMzo0NywgQmVydHJhbmQgTWFy
cXVpcyB3cm90ZToNCj4+Pj4+PiBIaSBKdWxpZW4sDQo+Pj4+PiANCj4+Pj4+IEhpIEJlcnRyYW5k
LA0KPj4+Pj4gDQo+Pj4+Pj4+IE9uIDkgTWFyIDIwMjIsIGF0IDEyOjIwLCBKdWxpZW4gR3JhbGwg
PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4+Pj4gDQo+Pj4+Pj4+IEZyb206IEp1bGllbiBH
cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+Pj4+Pj4+IA0KPj4+Pj4+PiBBdCB0aGUgbW9tZW50
LCBzd2l0Y2hfdHRicigpIGlzIHN3aXRjaGluZyB0aGUgVFRCUiB3aGlsc3QgdGhlIE1NVSBpcw0K
Pj4+Pj4+PiBzdGlsbCBvbi4NCj4+Pj4+Pj4gDQo+Pj4+Pj4+IFN3aXRjaGluZyBUVEJSIGlzIGxp
a2UgcmVwbGFjaW5nIGV4aXN0aW5nIG1hcHBpbmdzIHdpdGggbmV3IG9uZXMuIFNvDQo+Pj4+Pj4+
IHdlIG5lZWQgdG8gZm9sbG93IHRoZSBicmVhay1iZWZvcmUtbWFrZSBzZXF1ZW5jZS4NCj4+Pj4+
Pj4gDQo+Pj4+Pj4+IEluIHRoaXMgY2FzZSwgaXQgbWVhbnMgdGhlIE1NVSBuZWVkcyB0byBiZSBz
d2l0Y2hlZCBvZmYgd2hpbGUgdGhlDQo+Pj4+Pj4+IFRUQlIgaXMgdXBkYXRlZC4gSW4gb3JkZXIg
dG8gZGlzYWJsZSB0aGUgTU1VLCB3ZSBuZWVkIHRvIGZpcnN0DQo+Pj4+Pj4+IGp1bXAgdG8gYW4g
aWRlbnRpdHkgbWFwcGluZy4NCj4+Pj4+Pj4gDQo+Pj4+Pj4+IFJlbmFtZSBzd2l0Y2hfdHRicigp
IHRvIHN3aXRjaF90dGJyX2lkKCkgYW5kIGNyZWF0ZSBhbiBoZWxwZXIgb24NCj4+Pj4+Pj4gdG9w
IHRvIHRlbXBvcmFyeSBtYXAgdGhlIGlkZW50aXR5IG1hcHBpbmcgYW5kIGNhbGwgc3dpdGNoX3R0
YnIoKQ0KPj4+Pj4+PiB2aWEgdGhlIGlkZW50aXR5IGFkZHJlc3MuDQo+Pj4+Pj4+IA0KPj4+Pj4+
PiBzd2l0Y2hfdHRicl9pZCgpIGlzIG5vdyByZXdvcmtlZCB0byB0ZW1wb3JhcmlseSB0dXJuIG9m
ZiB0aGUgTU1VDQo+Pj4+Pj4+IGJlZm9yZSB1cGRhdGluZyB0aGUgVFRCUi4NCj4+Pj4+Pj4gDQo+
Pj4+Pj4+IFdlIGFsc28gbmVlZCB0byBtYWtlIHN1cmUgdGhlIGhlbHBlciBzd2l0Y2hfdHRicigp
IGlzIHBhcnQgb2YgdGhlDQo+Pj4+Pj4+IGlkZW50aXR5IG1hcHBpbmcuIFNvIG1vdmUgX2VuZF9i
b290IHBhc3QgaXQuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBUYWtlIHRoZSBvcHBvcnR1bml0eSB0byBp
bnN0cnVjdGlvbiBjYWNoZSBmbHVzaCBhcyB0aGUgb3BlcmF0aW9uIGlzDQo+Pj4+Pj4+IG9ubHkg
bmVjZXNzYXJ5IHdoZW4gdGhlIG1lbW9yeSBpcyB1cGRhdGVkLg0KPj4+Pj4+IFlvdXIgY29kZSBp
cyBhY3R1YWxseSByZW1vdmUgdGhlIGluc3RydWN0aW9uIGNhY2hlIGludmFsaWRhdGlvbiBzbw0K
Pj4+Pj4+IHRoaXMgc2VudGVuY2UgaXMgYSBiaXQgbWlzbGVhZGluZy4NCj4+Pj4+IA0KPj4+Pj4g
SSBmb3Jnb3QgdG8gYWRkIHRoZSB3b3JkICJyZW1vdmUiIGluIHRoZSBzZW50ZW5jZS4NCj4+Pj4g
T2sgKG15IHNlbnRlbmNlIHdhcyBhbHNvIHdyb25nIGJ5IHRoZSB3YXkpDQo+Pj4+PiANCj4+Pj4+
PiBBbHNvIGFuIG9wZW4gcXVlc3Rpb246IHNob3VsZG7igJl0IHdlIGZsdXNoIHRoZSBkYXRhIGNh
Y2hlID8NCj4+Pj4+IERvIHlvdSBtZWFuIGNsZWFuL2ludmFsaWRhdGUgdG8gUG9DL1BvVT8gU29t
ZXRoaW5nIGVsc2U/DQo+Pj4+IFllcywgcHJvYmFibHkgdG8gUG9VLg0KPj4+Pj4gDQo+Pj4+Pj4g
QXMgd2Ugc3dpdGNoIGZyb20gb25lIFRUQlIgdG8gYW4gb3RoZXIsIHRoZXJlIG1pZ2h0IGJlIHNv
bWUgZGF0YQ0KPj4+Pj4+IGluIHRoZSBjYWNoZSBkZXBlbmRlbnQgdGhhdCBjb3VsZCBiZSBmbHVz
aGVkIHdoaWxlIHRoZSBNTVUgaXMgb2ZmDQo+Pj4+PiANCj4+Pj4+IEkgYW0gYSBiaXQgY29uZnVz
ZWQuIFRob3NlIGZsdXNoIGNvdWxkIGFsc28gaGFwcGVuIHdpdGggdGhlIE1NVSBvbi4gU28gaG93
IHR1cm5pbmcgb2ZmIHRoZSBNTVUgd291bGQgcmVzdWx0IHRvIGEgcHJvYmxlbT8gTm90ZSB0aGF0
IHRoZSBkYXRhIGNhY2hlIGlzIHN0aWxsIGVuYWJsZWQgZHVyaW5nIHRoZSBzd2l0Y2guDQo+Pj4+
IElmIHRoZSBmaXJzdCBsZXZlbCBvZiBjYWNoZSBpcyBWSVBUIGFuZCB3ZSB0dXJuIG9mZiB0aGUg
TU1VLCBJIGFtIHdvbmRlcmluZyBpZiB0aGlzIGNvdWxkIG5vdCBjcmVhdGUgdHJvdWJsZXMgYW5k
IGNvdWxkIHJlcXVpcmUgdGhlIGNhY2hlIHRvIGJlIGZsdXNoZWQgYmVmb3JlIHR1cm5pbmcgdGhl
IE1NVSBvZmYuDQo+Pj4gTXkgcmVhZGluZyBvZiB0aGUgQXJtIEFybSAoRDUuMTEuMSAiRGF0YSBh
bmQgdW5pZmllZCBjYWNoZXMiIEFSTSBEREkgMDQ4N0YuYykgc3VnZ2VzdHMgdGhlIGRhdGEgY2Fj
aGUgaXMgYWx3YXlzIFBJUFQuDQo+PiBZb3UgYXJlIHJpZ2h0LCBvbmx5IHRoZSBpbnN0cnVjdGlv
biBjYWNoZSBpcyBWSVBULg0KPj4gU28gdGhlIHByb2JsZW0gbW9zdCBwcm9iYWJseSBkb2VzIG5v
dCBleGlzdC4NCj4gDQo+IEFzIGRpc2N1c3NlZCB5ZXN0ZXJkYSwgSSB0d2Vha2VkIGEgYml0IHN3
aXRjaF90dGJyKCkuIEJlbG93IHRoZSB2ZXJzaW9uIEkgcGxhbiB0byB1c2U6DQo+IA0KPiAgICAg
ICAgLyogMSkgRW5zdXJlIGFueSBwcmV2aW91cyByZWFkL3dyaXRlIGhhdmUgY29tcGxldGVkICov
DQo+ICAgICAgICBkc2IgICBzeSAvKiBYWFg6IENhbiB0aGlzIGJlIGEgaXNoPyAqLw0KDQpJIHRo
aW5rIGhlcmUg4oCcaXNo4oCdIGlzIGVub3VnaCBhcyB3ZSBvbmx5IG5lZWQgdGhlIGRvbWFpbiBp
bXBhY3RlZCBieSB0aGUgTU1VIG9mZiBvcGVyYXRpb24gdG8gaGF2ZSBoaXMgb3BlcmF0aW9ucyBk
b25lLg0KDQpGb3IgcmVmZXJlbmNlIHRoaXMgaXMgYW4gZXh0cmFjdCBmcm9tIHRoZSBjb2RlIG9m
IHRydXN0ZWQgZmlybXdhcmUgYmVmb3JlIGVuYWJsaW5nIE1NVToNCg0KICAgICAgICAvKg0KICAg
ICAgICAgKiBFbnN1cmUgYWxsIHRyYW5zbGF0aW9uIHRhYmxlIHdyaXRlcyBoYXZlIGRyYWluZWQg
aW50byBtZW1vcnksIHRoZSBUTEINCiAgICAgICAgICogaW52YWxpZGF0aW9uIGlzIGNvbXBsZXRl
LCBhbmQgdHJhbnNsYXRpb24gcmVnaXN0ZXIgd3JpdGVzIGFyZQ0KICAgICAgICAgKiBjb21taXR0
ZWQgYmVmb3JlIGVuYWJsaW5nIHRoZSBNTVUNCiAgICAgICAgICovDQogICAgICAgIGRzYiBpc2gN
CiAgICAgICAgaXNiDQoNCg0KPiAgICAgICAgaXNiDQo+IA0KPiAgICAgICAgLyogMikgVHVybiBv
ZmYgTU1VICovDQo+ICAgICAgICBtcnMgICAgeDEsIFNDVExSX0VMMg0KPiAgICAgICAgYmljICAg
IHgxLCB4MSwgI1NDVExSX0F4eF9FTHhfTQ0KPiAgICAgICAgbXNyICAgIFNDVExSX0VMMiwgeDEN
Cj4gICAgICAgIGlzYg0KPiANCj4gICAgICAgIC8qDQo+ICAgICAgICAgKiAzKSBGbHVzaCB0aGUg
VExCcy4NCj4gICAgICAgICAqIFNlZSBhc20vYXJtNjQvZmx1c2h0bGIuaCBmb3IgdGhlIGV4cGxh
bmF0aW9uIG9mIHRoZSBzZXF1ZW5jZS4NCj4gICAgICAgICAqLw0KPiAgICAgICAgZHNiICAgbnNo
c3QNCj4gICAgICAgIHRsYmkgIGFsbGUyDQo+ICAgICAgICBkc2IgICBuc2gNCj4gICAgICAgIGlz
Yg0KPiANCj4gICAgICAgIC8qIDQpIFVwZGF0ZSB0aGUgVFRCUiAqLw0KPiAgICAgICAgbXNyICAg
VFRCUjBfRUwyLCB4MA0KPiAgICAgICAgaXNiDQo+IA0KPiAgICAgICAgLyogNSkgVHVybiBvbiB0
aGUgTU1VICovDQo+ICAgICAgICBtcnMgICB4MSwgU0NUTFJfRUwyDQo+ICAgICAgICBvcnIgICB4
MSwgeDEsICNTQ1RMUl9BeHhfRUx4X00gIC8qIEVuYWJsZSBNTVUgKi8NCj4gICAgICAgIG1zciAg
IFNDVExSX0VMMiwgeDENCj4gICAgICAgIGlzYg0KDQpSZXN0IGhlcmUgc291bmRzIG9rIHRvIG1l
Lg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+ICAgICAgICByZXQNCj4gDQo+IENoZWVycywN
Cj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 14:14:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 14:14:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304187.518770 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedkt-0005J6-2a; Wed, 13 Apr 2022 14:13:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304187.518770; Wed, 13 Apr 2022 14:13:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nedks-0005Iz-Vz; Wed, 13 Apr 2022 14:13:58 +0000
Received: by outflank-mailman (input) for mailman id 304187;
 Wed, 13 Apr 2022 14:13:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0JnL=UX=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nedkr-0005It-C7
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 14:13:57 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0628.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::628])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f39cc85f-bb33-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 16:13:55 +0200 (CEST)
Received: from DB6P193CA0008.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::18) by
 AM0PR08MB3555.eurprd08.prod.outlook.com (2603:10a6:208:da::15) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5144.29; Wed, 13 Apr 2022 14:13:52 +0000
Received: from DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:29:cafe::32) by DB6P193CA0008.outlook.office365.com
 (2603:10a6:6:29::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Wed, 13 Apr 2022 14:13:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT023.mail.protection.outlook.com (10.152.20.68) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 14:13:52 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Wed, 13 Apr 2022 14:13:52 +0000
Received: from a6b25b1d9058.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E6A876D6-A8AD-46F5-A3A0-0E48363FC5C7.1; 
 Wed, 13 Apr 2022 14:13:45 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a6b25b1d9058.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Apr 2022 14:13:45 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB5943.eurprd08.prod.outlook.com (2603:10a6:20b:23e::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19; Wed, 13 Apr
 2022 14:13:42 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c521:b750:b0a9:54a6%4]) with mapi id 15.20.5144.030; Wed, 13 Apr 2022
 14:13:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f39cc85f-bb33-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vE/lAdxhqN300wP/pN5KO/QFNf2oijdeHaLrHNbMz8c=;
 b=u85eemjJU7SWhX6uVDN2cqaMLPGpUGDe+s0CPDLI3HBqQkyv5klHSKJBwp+GXL1+LoM/0Zj+rdKidZfZeKfAzEdvFCjTCN2QMD64o15mLgnqfboqlNpC5VqLPff1wtRhVrB53TxuZ9rQMac49nXvpq35lmRPNJhPONt0NQd5CJQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: de09945c0924b19e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ikzCp8LL3H5Yf1KCJnSOH+fHzD6miUFdGT60x4UI/Gnr+RceA/KJh7jlh6CTmz9Quqj62d9o7r4QfCvBw1PJqOvt0USY987iZyqalrSEJVR61khyetVpU72wfOMHY0qkheRjRx2VKLWvxH7ojmE3zzivKzk7bVFOpa0sRLi/QjJ9y/wmKyHxcJP2aUHMi9JK8DuXasvEk++rjwUiO7yB+bfeJ8YIVSr3j/VH5TuMUttRSaWK2FWx0e9lQmizBpnAtyTEioOlsAodFHjmTcovSBjKmhatier0dim30sLhDPZ0zb6CMZmoute/KDWOUJXtiVlIdIDMpUcZHq4SfAVcig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vE/lAdxhqN300wP/pN5KO/QFNf2oijdeHaLrHNbMz8c=;
 b=TgBdCHF8n4cDkEZ39o0qwrc+sTkQc+5Cp7c2GIzuWf/xbgJPIzqvwe/pN1ybdPoNmJ+7O1mrIOebMME8igfG3BlTTvmzAAnyWJharKndLacekEfiGvmV/GZ1nNh5aZsv8xNdWaRsZte7h7ys24/Lq10TdG/C0wY4dew4OanUB+KUfxb5SNcNVOMqyK+wjrLIACoDrThg+Pvny5cQ9rR7hgRr4EpUquXBLz1aQGQ/sabcpsFVSkgIBo6zJkgHCn99gboGRwM0U6Pm0F46r4d85xq6FDxsjp+6bA6i6oUcVJmN8mTGUmFxgPsttpMKOSDw80ZCoT7+WqkGZiAXBH6ujQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vE/lAdxhqN300wP/pN5KO/QFNf2oijdeHaLrHNbMz8c=;
 b=u85eemjJU7SWhX6uVDN2cqaMLPGpUGDe+s0CPDLI3HBqQkyv5klHSKJBwp+GXL1+LoM/0Zj+rdKidZfZeKfAzEdvFCjTCN2QMD64o15mLgnqfboqlNpC5VqLPff1wtRhVrB53TxuZ9rQMac49nXvpq35lmRPNJhPONt0NQd5CJQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Kevin Tian <kevin.tian@intel.com>, Paul
 Durrant <paul@xen.org>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Thread-Topic: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Thread-Index: AQHYTYhA4nLWVzOAC0uoUDkBvluxmqzt3yyAgAACy4CAAARSgA==
Date: Wed, 13 Apr 2022 14:13:41 +0000
Message-ID: <578D3D3C-AF6F-467E-9A9E-269220B5CCDB@arm.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
 <6F9FAAD4-59FF-4D52-B08D-13E3920B3925@arm.com>
 <YlbW9dKU8MEeHlfz@Air-de-Roger>
In-Reply-To: <YlbW9dKU8MEeHlfz@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 35266d93-52c8-475b-1735-08da1d57d66e
x-ms-traffictypediagnostic:
	AS8PR08MB5943:EE_|DB5EUR03FT023:EE_|AM0PR08MB3555:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB35557DBEA62FD2C573927F089DEC9@AM0PR08MB3555.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 MOWu/mSoafyYg0dg/FQaNcaVDZ4zQTVLXdwgcuco6TK07z9L7FHew2lSvaNYxCY8K8W8p0Zycu9qSPG3dgozpM7sNy5cyJTErvLKe1ucr9rg1+cvw+BbiziMp8feWZDQvg0n86v5mRkfCMuF51PeI6Oz/dt0belKckfhVERlv/3VNxGmzOXtg/W9tgGp4CTiMDoZXjOblVMtb0jEZGFm3Dwq4JQhFCjKZYKqbK3Fd0g1KpOAlPRGsVEJ7V4HTjw1R7+iggfBV4d40sjZdc+eQcBuhSJru4GVsi6YYhwR6r4tvOaToSIOMFFs/LZv78h74WaYHGvIG82/OwXEt3wtPMMddH796aZpvEaF+EzWR51fvto+4ds67IVNBkaCiZ9lt37SJOAwEiiqHOMAFH2BFeutARq+uZ1lrN6zdExzwUKrCEi3fkzsXZursp3WNYaMsYjzv4atwK5PzPOtvrFRHvJsn8PkCApriQmPhQgPoGiOUDzP+dxvRw3E92oCXb6zKDDBJnvr/E/DWQBgSf48r3g+f9pfilhphv5X7V8dY6fyUsDt7T1AUSz7g+JS9j57HvGqHSwHKrFZW+ZEF5eeJwoYdt57PykF33zaL69CqKObCobGcGVG7Ovy3ijeDPRf8XjNl1tlEOBJIzQjo2n1LZaShAh0SJNcXMpOix5Mp6rr51www68RNAzVp9hq2qQ+Cd6j3D7z2wtL+GY8Sc50k/2mnH4tocaQTvdoocQj/AK6mSI9FfEbrRKAOYuTFzlN
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(6916009)(38100700002)(71200400001)(54906003)(8936002)(36756003)(86362001)(91956017)(26005)(76116006)(6512007)(2616005)(33656002)(8676002)(66476007)(4326008)(66446008)(66946007)(64756008)(66556008)(122000001)(498600001)(83380400001)(53546011)(2906002)(186003)(38070700005)(6506007)(5660300002)(7416002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <C2ECB331C8C3D444AEC3472022FA434D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5943
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3fd4127a-942a-4fde-41f5-08da1d57d04b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vYoafapWqvIOwwpeY7/cOANqwOy2G7oEJVZlSDeK9uDUIDS9Y/SV0JSnCpSTrCi6U99WT4kvqumA4oj0vwXZeKd+teKq/Wzyqo9S9ywh0mgRWMw0S0p/7qtknIEoDfkf5/9ntP2K8b1rDvIIH4+ZZHWygu0iQRUnROQM1ezJHomzZ1h9Wyfszfk3uwBA8wmpwuxzao+tozywensT3nUcliD1TrsitDR6n2xYzcht7EsDMujCVeUzw1EhFzthRZNZCkUT3yXoNiqKj9DPqgTXRO+1dLM5rruMisLJVxRAbG6YDCa2nLRyvaeHk9rOMKE+tAH0XMab0OEZLBWQ5ZJ8eImW/uyATiUuh77kZHvUhbSUdSKtRzD7uIYKVNSt25nsyurnqmxkhZK8rszVq3rBng9vBxFkhfe24SrEfU6MrVkzZZSm5buekP8zslzOBN1Tt3UgVkMJyGCBDTFWwrxyXuaMXD2syQn3/QcW6yIRanUqemE5oS6fPsNf2LATytaXJaupZjPCZZERlUrcGZvt5J9zyCWXK17o++nB2IxGLAxKC9NoAHTtlSFgioa6iQNF66YSe+dNHc3k3Fvxx+Rg/TB9tW+nHbPzSOfvaDn0SYQrFC9EjNdh4pX8uGSuLT7gK32UFHF0tPvaYFRVAXRAucYj+12qV1Z8n4XodADTXtxVGKJJ6lDHC0hIhE0gjt3A
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(336012)(53546011)(6486002)(8936002)(70586007)(4326008)(82310400005)(36860700001)(498600001)(26005)(33656002)(36756003)(54906003)(47076005)(186003)(40460700003)(2616005)(70206006)(8676002)(6862004)(83380400001)(6506007)(6512007)(81166007)(2906002)(5660300002)(356005)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 14:13:52.3245
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 35266d93-52c8-475b-1735-08da1d57d66e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3555

SGksDQoNCj4gT24gMTMgQXByIDIwMjIsIGF0IDE0OjU4LCBSb2dlciBQYXUgTW9ubsOpIDxyb2dl
ci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIEFwciAxMywgMjAyMiBhdCAw
MTo0ODoxNFBNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgSmFuLA0KPj4g
DQo+Pj4gT24gMTEgQXByIDIwMjIsIGF0IDEwOjQwLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IFRoZXJlJ3Mgbm8gZ29vZCByZWFzb24gdG8gdXNlIHRo
ZXNlIHdoZW4gd2UgYWxyZWFkeSBoYXZlIGEgcGNpX3NiZGZfdA0KPj4+IHR5cGUgb2JqZWN0IGF2
YWlsYWJsZS4gVGhpcyBleHRlbmRzIHRvIHRoZSB1c2Ugb2YgUENJX0JVUygpIGluDQo+Pj4gcGNp
X2VjYW1fbWFwX2J1cygpIGFzIHdlbGwuDQo+Pj4gDQo+Pj4gTm8gY2hhbmdlIHRvIGdlbmVyYXRl
ZCBjb2RlICh3aXRoIGdjYzExIGF0IGxlYXN0LCBhbmQgSSBoYXZlIHRvIGFkbWl0DQo+Pj4gdGhh
dCBJIGRpZG4ndCBleHBlY3QgY29tcGlsZXJzIHRvIG5lY2Vzc2FyaWx5IGJlIGFibGUgdG8gc3Bv
dCB0aGUNCj4+PiBvcHRpbWl6YXRpb24gcG90ZW50aWFsIG9uIHRoZSBvcmlnaW5hbCBjb2RlKS4N
Cj4+PiANCj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+
DQo+Pj4gLS0tDQo+Pj4gTm90ZSB0aGF0IHRoZSBBcm0gY2hhbmdlcyBhcmUgImJsaW5kIjogSSBo
YXZlbid0IGJlZW4gYWJsZSB0byBzcG90IGEgd2F5DQo+Pj4gdG8gYXQgbGVhc3QgY29tcGlsZSB0
ZXN0IHRoZSBjaGFuZ2VzIHRoZXJlOyB0aGUgY29kZSBsb29rcyB0byBiZQ0KPj4+IGVudGlyZWx5
IGRlYWQuDQo+Pj4gDQo+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL3BjaS9lY2FtLmMNCj4+PiArKysg
Yi94ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYw0KPj4+IEBAIC0yOCw4ICsyOCw3IEBAIHZvaWQgX19p
b21lbSAqcGNpX2VjYW1fbWFwX2J1cyhzdHJ1Y3QgcGMNCj4+PiAgICAgICAgY29udGFpbmVyX29m
KGJyaWRnZS0+b3BzLCBjb25zdCBzdHJ1Y3QgcGNpX2VjYW1fb3BzLCBwY2lfb3BzKTsNCj4+PiAg
ICB1bnNpZ25lZCBpbnQgZGV2Zm5fc2hpZnQgPSBvcHMtPmJ1c19zaGlmdCAtIDg7DQo+Pj4gICAg
dm9pZCBfX2lvbWVtICpiYXNlOw0KPj4+IC0NCj4+PiAtICAgIHVuc2lnbmVkIGludCBidXNuID0g
UENJX0JVUyhzYmRmLmJkZik7DQo+Pj4gKyAgICB1bnNpZ25lZCBpbnQgYnVzbiA9IHNiZGYuYnVz
Ow0KPj4+IA0KPj4+ICAgIGlmICggYnVzbiA8IGNmZy0+YnVzbl9zdGFydCB8fCBidXNuID4gY2Zn
LT5idXNuX2VuZCApDQo+Pj4gICAgICAgIHJldHVybiBOVUxMOw0KPj4+IEBAIC0zNyw3ICszNiw3
IEBAIHZvaWQgX19pb21lbSAqcGNpX2VjYW1fbWFwX2J1cyhzdHJ1Y3QgcGMNCj4+PiAgICBidXNu
IC09IGNmZy0+YnVzbl9zdGFydDsNCj4+PiAgICBiYXNlID0gY2ZnLT53aW4gKyAoYnVzbiA8PCBv
cHMtPmJ1c19zaGlmdCk7DQo+Pj4gDQo+Pj4gLSAgICByZXR1cm4gYmFzZSArIChQQ0lfREVWRk4y
KHNiZGYuYmRmKSA8PCBkZXZmbl9zaGlmdCkgKyB3aGVyZTsNCj4+PiArICAgIHJldHVybiBiYXNl
ICsgKHNiZGYuZGYgPDwgZGV2Zm5fc2hpZnQpICsgd2hlcmU7DQo+PiANCj4+IEkgdGhpbmsgdGhp
cyBzaG91bGQgYmUgc2JkZi5iZGYgaW5zdGVhZCAodHlwbyB5b3UgcmVtb3ZlZCB0aGUgYikuDQo+
IA0KPiBJIGRvbid0IHRoaW5rIHNvLCBub3RpY2UgUENJX0RFVkZOMihzYmRmLmJkZikgd2hpY2gg
aXMgZXh0cmFjdGluZyB0aGUNCj4gZGV2Zm4gZnJvbSBzYmRmLmJkZi4gVGhhdCdzIG5vdCBuZWVk
ZWQsIGFzIHlvdSBjYW4ganVzdCBnZXQgdGhlIGRldmZuDQo+IGRpcmVjdGx5IGZyb20gc2JkZi5k
Zi4NCj4gDQo+IE9yIGVsc2UgdGhlIG9yaWdpbmFsIGNvZGUgaXMgd3JvbmcsIGFuZCB0aGUgUENJ
X0RFVkZOMiBzaG91bGRuJ3QgYmUNCj4gdGhlcmUuDQoNClRoZXJlIGlzIG5vdCBkZiBmaWVsZCBp
biB0aGUgc2JkZiBzdHJ1Y3R1cmUgc28gaXQgc2hvdWxkIGJlIGRldmZuIGluc3RlYWQuDQoNCkNo
ZWVycw0KQmVydHJhbmQNCg0KPiANCj4gVGhhbmtzLCBSb2dlci4NCg0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 14:38:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 14:38:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304192.518781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nee8o-0007k4-0s; Wed, 13 Apr 2022 14:38:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304192.518781; Wed, 13 Apr 2022 14:38:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nee8n-0007jx-UG; Wed, 13 Apr 2022 14:38:41 +0000
Received: by outflank-mailman (input) for mailman id 304192;
 Wed, 13 Apr 2022 14:38:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aogm=UX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nee8m-0007jp-Mv
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 14:38:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 68525647-bb37-11ec-8fbd-03012f2f19d4;
 Wed, 13 Apr 2022 16:38:39 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-jwi7R8wOMWa-dvOawoAiEg-1; Wed, 13 Apr 2022 16:38:38 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB7513.eurprd04.prod.outlook.com (2603:10a6:10:20a::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 13 Apr
 2022 14:38:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Wed, 13 Apr 2022
 14:38:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68525647-bb37-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649860719;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eSVIiK33FVoBMHHZevdik4y2mlGqmiAwgIYEYpixucA=;
	b=Ybj2GT/GTGJRX/BAE8CiavauchhZd7mzmPkSzgRliEiCKtzarXTjPNalJ5GJHV/PFepWVY
	Mni9DMzl0pb37htsZQNb2anjpO8UQ0uW/ODb7rEAPBLP/ojMFoAL/ziVYd/8LdhfL0Qe1j
	OzTdGAN/FU0iFL+o56b0c2/+Dot/cUc=
X-MC-Unique: jwi7R8wOMWa-dvOawoAiEg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TNaPrV99O7JNY+hqAKwXJ6d6MWL9mcqHakmcRh8LUVySHl70FcwTOcCq7VETixrOqz6nwCr8g73G8QchR/Lw775TopqCxQuzLWQRPP4XEi/YrO01n6IaaoxDN9n1z79OmMauGT1FbnQg6kSrcL2jFuEesVRZWy4TsQ/o+KTPmhhjuPn0MGwxDF6dStxVlsOwAZfMbOa4uP371VVTIbJ1Sst7n9YV6AyBUS2LC0WLR4erYqE5ewS+KA+C4Y3aEeOUU3u+WqGwK9Fe9YcW96a1+8BQaddHDf1G4s+R+yuNttaoG5vJJQ0XOCt6Q7G49ac8lKP6DfcyI9EOWDhClFkUcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oNqWMVK/EfeWBO9+j68KQ/QnC6HF84wcYB2Emgq32gI=;
 b=eEjFbbiGS24Op3Gw0L3Dihgp6TZrxusZEJWVa7IdvoOsFcFXJh2wNO8+Ur82SE7RMA0NCjWg7mCwGMdtSpNSgT3PBiJe51LYlYOAT9j5wdNDqg2uhVMcfFFqAL1S8E9IsbTB2a4wfp9Qqab8or32QBfFWF8i+YRQ54xGhNc0GE8q4V6ngq2EPUTeykGmji4n4deV5nqz3K4vUuCWmijq2MyMgXT4V0Gyg3FXZbuAeJVGqsIEffPOBtD6TgEhMJKRajc1N3vsGP/j+VPx+ctmiaxAd65jI+RLtdGuQtVEQbDy3bNMjn9TUjy2QGnWOVWp6UKy+HFOfFK9vNtoHvbxxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5c750104-c947-7eb2-15a2-b67dd760f7c9@suse.com>
Date: Wed, 13 Apr 2022 16:38:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
 <6F9FAAD4-59FF-4D52-B08D-13E3920B3925@arm.com>
 <YlbW9dKU8MEeHlfz@Air-de-Roger>
 <578D3D3C-AF6F-467E-9A9E-269220B5CCDB@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <578D3D3C-AF6F-467E-9A9E-269220B5CCDB@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0192.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::8) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 21b23fef-8ad2-46e6-a924-08da1d5b4ace
X-MS-TrafficTypeDiagnostic: DBBPR04MB7513:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7513DA2BDBEAF7A5077314AAB3EC9@DBBPR04MB7513.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Hm9E+2Poc6VdisE7Qi/t9jkE7dtKpkDKcL5n2PwYRYi1UoFwSuKLf+Nb8qqP+ErgRDKNgi4YcYh5adlkNVjUiU1ngOhScANhPitnSON9dU7A+mr5gipqvLzVbO9VzqsMTm7kaaDVZm7NVSV2p+8g1qe0bNd2g3SlV6SRRjAsNy0msfptSnfUXnjQEiDKrZYStyua1qzI4DeOq/qp/NoHdE0J+g8m5zBi8XFHCmtw0PINTlUKlRes4+N0b1X3y0UwXqal4YT0b93TRROYRNqVnWe50MlQv9eDNHIRC/B76c0o8G5kdBIJ/tEUOCC5O1hZz9BrUyQv7tZ1LzSYiKkKXx5DtIn8Oa2pazotUVI5dMP6mfHCdTF7qnSx+I4oEN/SSW96edO6KoorSy8hX+44DLZxYC8jHu76NrinugfFFWqoJFWx5LGDAhBpSonEU7ajZQy44sSk8auO1OWq1B3SY/I19MSUJvUUsLfdHuFgIflqivDXJsp/78XeGJmyj8FOEmNWyPBm4aZZdCEbUQxUFEkumHvMy1ADOV/ANkvN6c5NPuZ6IkVPXk0L2t4afL9RYTHGoPSF5XhY+ewAgrDOjVmGIgMgUwmHb7iwSWfVvzU2moKPXvjvx043UWghDYb3Jp6wKy4+s2aBJInjl5HAYpG+U0cihNbHvAErOsRjDy7MlI2iKM5yrXTRQ2c2q53gl69F0RYiZGBSK/Y5L3+1VPwOBBYZlD3WBauwezx5RQevYBvq8z/RJKBOXOhffnxU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(5660300002)(508600001)(8676002)(2616005)(4326008)(6506007)(6666004)(53546011)(2906002)(86362001)(6512007)(36756003)(316002)(31696002)(38100700002)(83380400001)(66556008)(31686004)(186003)(26005)(66946007)(6916009)(66476007)(54906003)(7416002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?i/GxVvrumSggEItcA62ZHXz6mUIKDq0y6mtCOZiWCFb+Ue6BlVjBl/rm21va?=
 =?us-ascii?Q?/SzNnNrhO219iFNS+pjj7tRyuK4fbtU0ZY/yMwC5dvwz22Sxwr/fRqhGQjYV?=
 =?us-ascii?Q?f0rQ8vcz0I/cy6UM/CebczUjsjUmyyok3Wy5GM2mj4juOzLmraZcvPmpv1ed?=
 =?us-ascii?Q?An+SRLu5o4cdwrKi6UABMgC0g5ENy4nJBy0qnR5cyGkqLSq6y0C9gFpJAMiy?=
 =?us-ascii?Q?aWxww6FluBOG002qwxLam41A5+so+u1EjM7BerytF/gm3Y45zeV5EZUUT0Xr?=
 =?us-ascii?Q?/bvQgmYYYemo8uMQVr4F7VEmm43VPswRXYE8H6cRvtvV6IIsYIftBaWTiTK0?=
 =?us-ascii?Q?qGaD3zDMWgqSiFQ9LCwdaAewGXshpFNJJe+CyKstxuI4eAyLYe+PlFymoIvh?=
 =?us-ascii?Q?BkuVk/vB0OXw/9QYQ98v8sHbKvOeNhqv0sn1LuwwiZ9Svd6wsAnbbvd6TnXN?=
 =?us-ascii?Q?lei5+i9Newupk4CQ8onarweNcJJ0pOfc+9wMkee1IMDS4wr7XT1amiFkXBGD?=
 =?us-ascii?Q?qUUt+Ik51p2ARpAjlEM6/+8FeR0poVwmqKJFtpvcFsT+RQfYlN0B4dqyzru2?=
 =?us-ascii?Q?aLZ3TLRf4JFxPV4clXhXXngyU+hsqQMakb6njV3niQaFmU+T9qFJ9qp/TPAY?=
 =?us-ascii?Q?25fqxR56q80i0QUKX7nGWyPe7akjRue4qWA24drjfkSJHjZDm0/GZyzKzKAu?=
 =?us-ascii?Q?FLpht9EJSlsoQQ+qz/xQXhDcRsr/SimZ1xQNzVCTZISjRrvVmzZ64T47Ue3b?=
 =?us-ascii?Q?ohQq9kiyyvSTx4x2VP4MqbP7iDyQpRrjBM8KFXxBy/NtA//HqFICcNs7fmHZ?=
 =?us-ascii?Q?mscJid0pqU255f+kUdRK9lbQaVxpjKjsS8qDIVe2FY3fDN2vKA3q7lInkKqn?=
 =?us-ascii?Q?BUkmitlTvwpYi9GVbC6H+H/ih8EsMwkRgCK9uj77Yc+gZl+gzhNYgwFpksym?=
 =?us-ascii?Q?vJcb/jPGuz8S0tiwQfG012/McYs6IdgqeZ22jJfL4ajpHUuEM+25Xd5bbnJR?=
 =?us-ascii?Q?Yw7ntSbptuQT9JYN0k8DrmVD1JhSHvQ2mHr6DCCv5UFwdc0V+NAzsnJksA61?=
 =?us-ascii?Q?NsUNe+1gx5FuNne3UAGelXGERium4RnTfh4lNwaZomMwLFI8LXmIokMWjPNC?=
 =?us-ascii?Q?xtJ7ErEhwclIUP6Lg4wK8RTGkrLClBPDOQJga30pK4gZ6XVt+7VJEDxxzjjS?=
 =?us-ascii?Q?VcKbyjsCMP3fXZahG3cZW9+YUrCD8sO6IApXxvoQ0YsvlVGGgDznqRVxoNG0?=
 =?us-ascii?Q?7W4MfjGd3p7TYg/620g7CJTveSEUtE7tv5EjKF0eUq10axnZ7PzU7xSeDGAP?=
 =?us-ascii?Q?FyiV7ok9MZWS8/8NCuid9s2Xp/F3pd8EwkkRWDHt+SrJzk+vj7Ou76EnuQaO?=
 =?us-ascii?Q?PPtiTlRQnBbhdyQ/N6Uhs7qPzRuhR8xpBPCy9BOJXYE2plDU9k+YTboO2KaP?=
 =?us-ascii?Q?79a+3yf7LU4PQ9rwGmbRFl559HeOxBZSU2cIA8YjL5xn5WEol4k2QmhqKC0l?=
 =?us-ascii?Q?LlmNnF8UII07Gq/DlqiKwHTeFb6yjeQ/2LFjg0aiDThM543ldU9LT+rL3XR6?=
 =?us-ascii?Q?SjZgixzfLpDVOGfIx0bVGz65O7+KvtBkSetCnQJ6BsaNPUJzOgmUA773g0WW?=
 =?us-ascii?Q?8xl8EE5D4bi7Pzw3/4l6KYSkrUcdLXd4ZMwWX7Q0yQatbw7Xwen0ftMHgTnX?=
 =?us-ascii?Q?dWDhPYR4czlawWr5JCJPUvoDgrWldE/auXwrjHqKOudXXNmkhx+lxo7MCRWV?=
 =?us-ascii?Q?V8lKNWgyCw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21b23fef-8ad2-46e6-a924-08da1d5b4ace
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 14:38:36.2039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ukjA/yDe1rLNKyFOU4BLqFltMxKV+ipQoK9yUvaS1X/4/g8emezPz4EiMPpgclKvP4JfN2w8baCiwwo/E+7j6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7513

On 13.04.2022 16:13, Bertrand Marquis wrote:
>> On 13 Apr 2022, at 14:58, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> wr=
ote:
>> On Wed, Apr 13, 2022 at 01:48:14PM +0000, Bertrand Marquis wrote:
>>>> On 11 Apr 2022, at 10:40, Jan Beulich <jbeulich@suse.com> wrote:
>>>>
>>>> There's no good reason to use these when we already have a pci_sbdf_t
>>>> type object available. This extends to the use of PCI_BUS() in
>>>> pci_ecam_map_bus() as well.
>>>>
>>>> No change to generated code (with gcc11 at least, and I have to admit
>>>> that I didn't expect compilers to necessarily be able to spot the
>>>> optimization potential on the original code).
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>> ---
>>>> Note that the Arm changes are "blind": I haven't been able to spot a w=
ay
>>>> to at least compile test the changes there; the code looks to be
>>>> entirely dead.

Note this remark.

>>>> --- a/xen/arch/arm/pci/ecam.c
>>>> +++ b/xen/arch/arm/pci/ecam.c
>>>> @@ -28,8 +28,7 @@ void __iomem *pci_ecam_map_bus(struct pc
>>>>        container_of(bridge->ops, const struct pci_ecam_ops, pci_ops);
>>>>    unsigned int devfn_shift =3D ops->bus_shift - 8;
>>>>    void __iomem *base;
>>>> -
>>>> -    unsigned int busn =3D PCI_BUS(sbdf.bdf);
>>>> +    unsigned int busn =3D sbdf.bus;
>>>>
>>>>    if ( busn < cfg->busn_start || busn > cfg->busn_end )
>>>>        return NULL;
>>>> @@ -37,7 +36,7 @@ void __iomem *pci_ecam_map_bus(struct pc
>>>>    busn -=3D cfg->busn_start;
>>>>    base =3D cfg->win + (busn << ops->bus_shift);
>>>>
>>>> -    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
>>>> +    return base + (sbdf.df << devfn_shift) + where;
>>>
>>> I think this should be sbdf.bdf instead (typo you removed the b).
>>
>> I don't think so, notice PCI_DEVFN2(sbdf.bdf) which is extracting the
>> devfn from sbdf.bdf. That's not needed, as you can just get the devfn
>> directly from sbdf.df.
>>
>> Or else the original code is wrong, and the PCI_DEVFN2 shouldn't be
>> there.
>=20
> There is not df field in the sbdf structure so it should be devfn instead=
.

Yes indeed, thanks for noticing. But really (see the remark further up)
this is what happens if code in the tree can't even be built-tested.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 13 14:48:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 14:48:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304197.518793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neeIY-0000mo-WA; Wed, 13 Apr 2022 14:48:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304197.518793; Wed, 13 Apr 2022 14:48:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neeIY-0000mh-TC; Wed, 13 Apr 2022 14:48:46 +0000
Received: by outflank-mailman (input) for mailman id 304197;
 Wed, 13 Apr 2022 14:48:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neeIX-0000mX-CE; Wed, 13 Apr 2022 14:48:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neeIX-0003z0-9g; Wed, 13 Apr 2022 14:48:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neeIW-0003ca-UF; Wed, 13 Apr 2022 14:48:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neeIW-0001uh-Tm; Wed, 13 Apr 2022 14:48:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=onCljo/lN+86LB1EUfNOEZe3Zwz1UapJtFTfmbMjHgk=; b=hzkuSGPClJg+dMy4R1rzMXOF3+
	aoQHKBbrIEOKv8aCNMsdVVEavUjXBajqh9lKBaBe/CHQzVkV2LuPvPmXm/PRcZm07Rrix0QMZtx5R
	2CLQKDUcOmqViWABn5suBof4oCs0Qvl5juwvX/shZmsja0EbUYlHX9n/aELlfURJRXPQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169361-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169361: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-arm64-xsm:xen-build:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=5b752808ff37b7c819a26fd76329ef329c42774f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 14:48:44 +0000

flight 169361 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169361/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-xsm               6 xen-build                fail REGR. vs. 169320

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  5b752808ff37b7c819a26fd76329ef329c42774f

Last test of basis   169320  2022-04-12 02:00:26 Z    1 days
Testing same since   169361  2022-04-13 11:01:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Ross Lagerwall <ross.lagerwall@citrix.com> # livepatch

jobs:
 build-arm64-xsm                                              fail    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit e509b5f932608e74deac96048b28a5e9b210c647
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Apr 13 12:36:03 2022 +0200

    IOMMU: log appropriate SBDF
    
    To handle phantom devices, several functions are passed separate "devfn"
    arguments besides a PCI device. In such cases we want to log the phantom
    device's coordinates instead of the main one's. (Note that not all of
    the instances being changed are fallout from the referenced commit.)
    
    Fixes: 1ee1441835f4 ("print: introduce a format specifier for pci_sbdf_t")
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit e687e72174b73bb1d23ff79f9ef580201243d35f
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Apr 13 12:35:17 2022 +0200

    AMD/IOMMU: replace a few PCI_BDF2()
    
    struct pci_dev has the wanted value directly available; use it. Note
    that this fixes a - imo benign - mistake in reassign_device(): The unity
    map removal ought to be based on the passed in devfn (as is the case on
    the establishing side). This is benign because the mappings would be
    removed anyway a little later, when the "main" device gets processed.
    While there also limit the scope of two variables in that function.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit 7115fa562fe79c8a8733f6b821d4eea62ed56516
Author: Anthony PERARD <anthony.perard@citrix.com>
Date:   Wed Apr 13 12:33:21 2022 +0200

    build: adding out-of-tree support to the xen build
    
    This implement out-of-tree support, there's two ways to create an
    out-of-tree build tree (after that, `make` in that new directory
    works):
        make O=build
        mkdir build; cd build; make -f ../Makefile
    also works with an absolute path for both.
    
    This implementation only works if the source tree is clean, as we use
    VPATH.
    
    This patch copies most new code with handling out-of-tree build from
    Linux v5.12.
    
    Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>
    Acked-by: Julien Grall <jgrall@amazon.com>
    Tested-by: Julien Grall <jgrall@amazon.com>
    Acked-by: Ross Lagerwall <ross.lagerwall@citrix.com> # livepatch
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 15:10:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 15:10:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304208.518807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neecz-0003HV-Se; Wed, 13 Apr 2022 15:09:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304208.518807; Wed, 13 Apr 2022 15:09:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neecz-0003HO-Pg; Wed, 13 Apr 2022 15:09:53 +0000
Received: by outflank-mailman (input) for mailman id 304208;
 Wed, 13 Apr 2022 15:09:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neecy-0003HE-U4; Wed, 13 Apr 2022 15:09:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neecy-0004Lp-Ru; Wed, 13 Apr 2022 15:09:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neecy-00046u-Cu; Wed, 13 Apr 2022 15:09:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neecy-0007mj-CQ; Wed, 13 Apr 2022 15:09:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=g04byKpt1IEIEgBChqqmMzrdrSdg8k+ODKiy3s6l8ok=; b=e8THbrvz51/ea/Q3OXBp67KuoR
	Rtc3hK8GPwDIYYhBZ7/fVYbBRbH8k2x0TMIArSG0wGy4fv8BekpkaKiWujDCuiqGdCJPaD4vI7qZL
	KIh3P8hAJoMN/ylxLtpg9g2KUedq5qxCnQJVlbIF1hSSLg531zjiU5ycv7usr8Rtbx8w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169366-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169366: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 15:09:52 +0000

flight 169366 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169366/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  364 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 15:26:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 15:26:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304220.518826 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neetG-0005ge-Cs; Wed, 13 Apr 2022 15:26:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304220.518826; Wed, 13 Apr 2022 15:26:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neetG-0005gX-A3; Wed, 13 Apr 2022 15:26:42 +0000
Received: by outflank-mailman (input) for mailman id 304220;
 Wed, 13 Apr 2022 15:26:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1neetE-0005gR-MM
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 15:26:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1neetD-0004dI-QV; Wed, 13 Apr 2022 15:26:39 +0000
Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.7.236.29])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1neetD-0007EJ-Kp; Wed, 13 Apr 2022 15:26:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:To:Subject:MIME-Version:Date:Message-ID;
	bh=L4dYL0a/ulyEmdUE8rKKVi2O351Wz5eo0sBy29tIeKI=; b=HG694bQvGyKDmt+9zuSF1P8X7M
	XsAw5ysMhb/XvG6wI39DSnX2BZocRvTShMezclN7YBfagsjz6k717FA9jy31EorQLSM3a39smKa7M
	McnQQ4MvydYxfqsooSU7MJCK3k6o1bgi9nT77lG9AS9Z+mgl6Q9PgZBJ6Tjh8jzULY7U=;
Message-ID: <9107705b-f34b-9cc2-83f5-24c254f53cbb@xen.org>
Date: Wed, 13 Apr 2022 16:26:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [xen-unstable-smoke test] 169361: regressions - FAIL
To: osstest service owner <osstest-admin@xenproject.org>,
 xen-devel@lists.xenproject.org
References: <osstest-169361-mainreport@xen.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <osstest-169361-mainreport@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 13/04/2022 15:48, osstest service owner wrote:
> flight 169361 xen-unstable-smoke real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/169361/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>   build-arm64-xsm               6 xen-build                fail REGR. vs. 169320

I think this is a transient network issue:

fatal: remote error: git-cache-proxy: git remote died with error exit 
code 1 // Fetching origin // remote: The git server, Gitaly, is not 
available at this time. Please contact your administrator. // fatal: 
unable to access 'https://gitlab.com/qemu-project/meson.git/': The 
requested URL returned error: 503 // error: Could not fetch origin
fatal: clone of 'https://gitlab.com/qemu-project/meson.git' into 
submodule path 
'/home/osstest/build.169361.build-arm64-xsm/xen/tools/qemu-xen-dir-remote/meson' 
failed
Failed to clone 'meson' a second time, aborting
/home/osstest/build.169361.build-arm64-xsm/xen/tools/qemu-xen-dir/scripts/git-submodule.sh: 
failed to update modules

Unable to automatically checkout GIT submodules ' ui/keycodemapdb meson 
tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc capstone 
slirp'.
If you require use of an alternative GIT binary (for example to
enable use of a transparent proxy), then please specify it by
running configure by with the '--with-git' argument. e.g.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 16:32:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 16:32:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304226.518837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nefv6-0004di-A1; Wed, 13 Apr 2022 16:32:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304226.518837; Wed, 13 Apr 2022 16:32:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nefv6-0004db-79; Wed, 13 Apr 2022 16:32:40 +0000
Received: by outflank-mailman (input) for mailman id 304226;
 Wed, 13 Apr 2022 16:32:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nefv4-0004dO-Iq; Wed, 13 Apr 2022 16:32:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nefv4-0006Gj-GR; Wed, 13 Apr 2022 16:32:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nefv4-0006fW-44; Wed, 13 Apr 2022 16:32:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nefv4-0007q3-3Z; Wed, 13 Apr 2022 16:32:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LvKTrPUj4H9Ro2W7xpbubExFEeEyWPCD+yTDE7OX+6s=; b=ExHAWw7XCIvv8zwiYa/fP1/GrP
	2rsV7x1qCcSbOHBNDW92Xa9ATDTYzGVtc4P4LqBx2/YAAnMpiXT7nGScMZOYhLUXNWg4nUYmpo+U5
	HpgK+nxe2+PSGepGm7yEpZniioIX9z26RoC1sTmyDIGEwZrPwr1HomBvBhN3UrJqGzhI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169370-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169370: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 16:32:38 +0000

flight 169370 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169370/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  365 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 17:12:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 17:12:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304265.518867 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1negXN-0001T3-Od; Wed, 13 Apr 2022 17:12:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304265.518867; Wed, 13 Apr 2022 17:12:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1negXN-0001Sw-Jz; Wed, 13 Apr 2022 17:12:13 +0000
Received: by outflank-mailman (input) for mailman id 304265;
 Wed, 13 Apr 2022 17:12:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1negXL-0001Sm-OX; Wed, 13 Apr 2022 17:12:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1negXL-0006wP-KL; Wed, 13 Apr 2022 17:12:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1negXL-0007ho-9F; Wed, 13 Apr 2022 17:12:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1negXL-0001uH-8m; Wed, 13 Apr 2022 17:12:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rW4G3BJjmXAQtL0Z9DYOJGiHVJ1DQlnbVseTrLab1jI=; b=ZN3t1AYTToNTrhiysaKGqjWyeX
	d442yvscGwZvF5PIsiYGQErq6QNiq80g9op8st8Uad+PL+KVsRut+IfV03bsTxGc3nnDdvQs1NDbi
	fy0uOhn5fonuNH73LJWPDmnPSNnxDsN7WpjZXVQkgg/9ZEJ7kZXZkqy2raGUWQQWAPPs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169371-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169371: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 17:12:11 +0000

flight 169371 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169371/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  366 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 17:57:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 17:57:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304274.518877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nehFP-0005jV-7T; Wed, 13 Apr 2022 17:57:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304274.518877; Wed, 13 Apr 2022 17:57:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nehFP-0005jO-4g; Wed, 13 Apr 2022 17:57:43 +0000
Received: by outflank-mailman (input) for mailman id 304274;
 Wed, 13 Apr 2022 17:57:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nehFO-0005jE-2T; Wed, 13 Apr 2022 17:57:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nehFO-0007fZ-0b; Wed, 13 Apr 2022 17:57:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nehFN-0000Kx-PE; Wed, 13 Apr 2022 17:57:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nehFN-0006yi-Oi; Wed, 13 Apr 2022 17:57:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=G3pQHkvsGK6BogFUwxW5ur5q/ITqxi7GfDoU0T6HFQs=; b=g2HFuhS6wVouwQERQluL5zpxTE
	tuPlOHCO85TrVMxm/ZnEPkzk5D+celPUCdsR8gz/2SfvGPrvk5iqiP/UMOkHbPxJNryPHH36WpTKl
	sadLvRywFsy66PrB36Gt+XF6lnk/fNc76pVKpoZz+/yWN19/Oa2D7qO1DYd36Hld+grE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169368-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169368: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=5b752808ff37b7c819a26fd76329ef329c42774f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 17:57:41 +0000

flight 169368 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169368/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  5b752808ff37b7c819a26fd76329ef329c42774f

Last test of basis   169320  2022-04-12 02:00:26 Z    1 days
Testing same since   169361  2022-04-13 11:01:35 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Ross Lagerwall <ross.lagerwall@citrix.com> # livepatch

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   5b752808ff..e509b5f932  e509b5f932608e74deac96048b28a5e9b210c647 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 18:28:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 18:28:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304287.518895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nehjW-0000oB-SM; Wed, 13 Apr 2022 18:28:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304287.518895; Wed, 13 Apr 2022 18:28:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nehjW-0000o4-P5; Wed, 13 Apr 2022 18:28:50 +0000
Received: by outflank-mailman (input) for mailman id 304287;
 Wed, 13 Apr 2022 18:28:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nehjV-0000nu-Kz; Wed, 13 Apr 2022 18:28:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nehjV-0008JA-JC; Wed, 13 Apr 2022 18:28:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nehjV-000144-7N; Wed, 13 Apr 2022 18:28:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nehjV-0007im-6v; Wed, 13 Apr 2022 18:28:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=e3zt8NRNOI+gzoVdnceR+cUOZWSiyJowVLsEV/ygyRY=; b=w0v7AAS6vcDvWLFAVm63A89qtC
	Wp+S1QKeuC08rl3j4nzHNuN6rGicyAnDl/WXPPkgdNLM8Nr2Q/t2rjVUoAI+7gV3XFcCOUB3vllbS
	5MEQO54r78BMQLQ9qG6NLMp3nXdgvZ8svHLuhs6gW+uLd1pMPC4ymSU/77yiIzjsQzpY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169372-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169372: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 18:28:49 +0000

flight 169372 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169372/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  367 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 18:48:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 18:48:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304296.518905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nei2d-0003CE-Ht; Wed, 13 Apr 2022 18:48:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304296.518905; Wed, 13 Apr 2022 18:48:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nei2d-0003C7-F9; Wed, 13 Apr 2022 18:48:35 +0000
Received: by outflank-mailman (input) for mailman id 304296;
 Wed, 13 Apr 2022 18:48:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c/QC=UX=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1nei2c-0003C1-GD
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 18:48:34 +0000
Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com
 [209.85.128.169]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 51125bf8-bb5a-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 20:48:33 +0200 (CEST)
Received: by mail-yw1-f169.google.com with SMTP id
 00721157ae682-2ec04a2ebadso32319047b3.12
 for <xen-devel@lists.xenproject.org>; Wed, 13 Apr 2022 11:48:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51125bf8-bb5a-11ec-a405-831a346695d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=J1rErWVySlUxlEFN2u18NGS5Qm0qvXYHGlMsYpGhhEY=;
        b=xhMvKPzvCfc+XWaG1FFR5FVrQVBBptLTt/56JXYPvreiyt3YtwjXUSkGwFKiybboZP
         3U40GqG8HgmWaxRLkhG7q+Hyeqk18kP+UuCsroUHZFTH3UwdpsRGn91G52fxaFxPOkHL
         /J8O4cDJNGyCWndFtmKACRCa7qBmcoruvxMzz0jCzdQdbknLF6/zGct7f/Vsy4PWw+NX
         5YOZdvhq9BsAtx3BCiyHoXemHgLBeXerVbeErSoChOz7K+Ei8yVOrOi6jpi1yJS2qrSx
         xsZfmsVI4kDlNh6MSC4UdsWPNnhpdDzTTkUJKYq+UNFBtrP5CVJAW7DUZPc+HPiy9yb/
         iEpQ==
X-Gm-Message-State: AOAM530RWrSwbHibTVJ41vjgXf1luFGABzI++NME2lZ2isc8A2Kl8u4O
	zxeF01cxWwVjv2kyJX/CW1gZcbrdLa74l+XUyS8=
X-Google-Smtp-Source: ABdhPJz9BfsA7QIGi43YRDlzzrWhVjbeGEMJOs01j9nA3vXXWXOOPKhq5d8EhdtGHqqQ5dYXQmK91VGL/RQnfnI1jKs=
X-Received: by 2002:a81:7c45:0:b0:2eb:4759:cc32 with SMTP id
 x66-20020a817c45000000b002eb4759cc32mr224284ywc.515.1649875711933; Wed, 13
 Apr 2022 11:48:31 -0700 (PDT)
MIME-Version: 1.0
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com> <20220411233832.391817-4-dmitry.osipenko@collabora.com>
In-Reply-To: <20220411233832.391817-4-dmitry.osipenko@collabora.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 13 Apr 2022 20:48:20 +0200
Message-ID: <CAJZ5v0gf1J+yPW14TAdLGLGfO+-2s=r0DDP7d+Rgop3=dB0gaQ@mail.gmail.com>
Subject: Re: [PATCH v7 03/20] reboot: Print error message if restart handler
 has duplicated priority
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, 
	Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	=?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>, linux-parisc@vger.kernel.org, 
	linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>, 
	xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
>
> Add sanity check which ensures that there are no two restart handlers
> registered using the same priority. This requirement will become mandatory
> once all drivers will be converted to the new API and such errors will be
> fixed.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

The first two patches in the series are fine with me and there's only
one minor nit regarding this one (below).

> ---
>  kernel/reboot.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index ed4e6dfb7d44..acdae4e95061 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -182,6 +182,21 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
>   */
>  int register_restart_handler(struct notifier_block *nb)
>  {
> +       int ret;
> +
> +       ret = atomic_notifier_chain_register_unique_prio(&restart_handler_list, nb);
> +       if (ret != -EBUSY)
> +               return ret;
> +
> +       /*
> +        * Handler must have unique priority. Otherwise call order is
> +        * determined by registration order, which is unreliable.
> +        *
> +        * This requirement will become mandatory once all drivers
> +        * will be converted to use new sys-off API.
> +        */
> +       pr_err("failed to register restart handler using unique priority\n");

I would use pr_info() here, because this is not a substantial error AFAICS.

> +
>         return atomic_notifier_chain_register(&restart_handler_list, nb);
>  }
>  EXPORT_SYMBOL(register_restart_handler);
> --


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 19:37:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 19:37:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304301.518917 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neinK-0008JI-7q; Wed, 13 Apr 2022 19:36:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304301.518917; Wed, 13 Apr 2022 19:36:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neinK-0008JB-3l; Wed, 13 Apr 2022 19:36:50 +0000
Received: by outflank-mailman (input) for mailman id 304301;
 Wed, 13 Apr 2022 19:36:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neinJ-0008J1-7j; Wed, 13 Apr 2022 19:36:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neinJ-000107-5w; Wed, 13 Apr 2022 19:36:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neinI-0003e5-PR; Wed, 13 Apr 2022 19:36:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neinI-0006xD-P3; Wed, 13 Apr 2022 19:36:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yEIAEqGgBm9ZIMn83ZTbmXSBETTp2B5fu5SaFWXzVsY=; b=A3aC4YEfMrWwyArNoCKSHTe3h7
	zzcPty18IVmMbf637j0o0gkJ8w+alJ3Li0axui5xSV+5TVgmkDBgr0mWhWEmTj6O9jLbr/dJ3FwQD
	ZN3p83U0t8Z8EHWS5hPTdhg9In4v/oGWdJGiB/ZsMjIu6a2/3yh9ZGguvCA92VYyLxTg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169374-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169374: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 19:36:48 +0000

flight 169374 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169374/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  368 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 20:37:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 20:37:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304311.518927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nejjr-000649-QJ; Wed, 13 Apr 2022 20:37:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304311.518927; Wed, 13 Apr 2022 20:37:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nejjr-000642-Mm; Wed, 13 Apr 2022 20:37:19 +0000
Received: by outflank-mailman (input) for mailman id 304311;
 Wed, 13 Apr 2022 20:37:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nejjp-00063s-KW; Wed, 13 Apr 2022 20:37:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nejjp-00025k-I0; Wed, 13 Apr 2022 20:37:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nejjp-0006hG-9y; Wed, 13 Apr 2022 20:37:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nejjp-0002Da-9S; Wed, 13 Apr 2022 20:37:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WIFWZiIHmFaBtgHugvv/ucU53qyLeUYIChyFYKKIXeM=; b=ANpeYKfzWTErDl/1nakVYTtUJV
	xeAwdja/z/5w4kNUh0/P2xtoSDfmFcqxzZ/9C0slUCrbqRTduPGf6LDg9GEeV7OLg2Xdr1rF82q8E
	ZWWEfaX9IGZHptjwdFAein0SegwebjDW485qSYfz+bVIM1Z0Swh6zAZmn/I7SNfsB7G4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169375-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169375: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 20:37:17 +0000

flight 169375 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169375/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  369 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 21:24:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 21:24:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304322.518938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nekTc-0002oe-GW; Wed, 13 Apr 2022 21:24:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304322.518938; Wed, 13 Apr 2022 21:24:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nekTc-0002oX-DK; Wed, 13 Apr 2022 21:24:36 +0000
Received: by outflank-mailman (input) for mailman id 304322;
 Wed, 13 Apr 2022 21:24:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aqKT=UX=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nekTb-0002oR-Bu
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 21:24:35 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1c0e9db2-bb70-11ec-a405-831a346695d4;
 Wed, 13 Apr 2022 23:24:33 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8AA0C61E9E;
 Wed, 13 Apr 2022 21:24:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87D61C385A3;
 Wed, 13 Apr 2022 21:24:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c0e9db2-bb70-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649885071;
	bh=WB/lD2jHIvvQgr8ggEfqJ614aG5XvkFNca7xisIutu0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dlP+h3PN/ReOe9wb4iEt3/8Qw10mIbIlkHnMrwk1I1T/jQoBbjTnkuBOoxT1Wd7ST
	 t/yUKp8v5IN5Eg46XkpeN0L+hZAIXaJNzqMlZKKrgKN7+MLsSjK/Yx4Z6KK9lABEqa
	 Hfxosma6DQZTyKGFZVkXVISUEPusDSuhhSRSq7zg8jGZ8/oTgs5VH+6S06c7CE4bCt
	 V/6Fx3z/dknj6aoSY+2wkSKLzSVZ+BifR6OAJNGiPfKlaLhlO0OPF2NwcdeqCNYN9J
	 kq+SXZrUC8BOfcrqzFYI3FtFfdbSxBsI9rBUgbw3VwyKq18CxqZC0x82jaWJIfvVig
	 rnKPxzvZ4pr2Q==
Date: Wed, 13 Apr 2022 14:24:30 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <Rahul.Singh@arm.com>
cc: xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Jan Beulich <jbeulich@suse.com>, jgross@suse.com, 
    boris.ostrovsky@oracle.com
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
In-Reply-To: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1451968002-1649883768=:3066615"
Content-ID: <alpine.DEB.2.22.394.2204131402540.3066615@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1451968002-1649883768=:3066615
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204131402541.3066615@ubuntu-linux-20-04-desktop>

On Wed, 13 Apr 2022, Rahul Singh wrote:
> Hello All,
> 
> We are trying to boot the Xen 4.15.1 and dom0 Linux Kernel (5.10.27-ampere-lts-standard from [1] ) on Ampere Altra / AVA Developer Platform
> [2] with ACPI.
> 
> NVMe storage is connected to PCIe. Native Linux kernel boot fine and also I am able to detect and access NVMe storage.
> However, during XEN boot when NVME driver is requesting the DMA buffer we are observing the Oops with XEN.

Hi Rahul,

Thanks for the bug report. More comments below.



> Please find the attached detail logs for Xen and dom0 booting.
> 
> Snip from logs:
> (XEN) d0v0: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0
> [    0.000000] Booting Linux on physical CPU 0x0000000000 [0x413fd0c1]
> [    0.000000] Linux version 5.10.27-ampere-lts-standard (oe-user@oe-host) (aarch64-poky-linux-gcc (GCC) 11.2.0, GNU ld (GNU Binutils)
> 2.37.20210721) #1 SMP PREEMPT Sat Sep 18 06:01:59 UTC 2021
> [    0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found
> [    0.000000] efi: EFI v2.50 by Xen
> [    0.000000] efi: ACPI 2.0=0x807f66cece8
> [    0.000000] ACPI: Early table checksum verification disabled
> [    0.000000] ACPI: RSDP 0x00000807F66CECE8 000024 (v02 Ampere)
> [    0.000000] ACPI: XSDT 0x00000807F66CEC38 0000AC (v01 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: FACP 0x00000807F66CE000 000114 (v06 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: DSDT 0x00000807F8DB0018 02C19E (v02 Ampere Jade     00000001 INTL 20201217)
> [    0.000000] ACPI: BERT 0x00000807FA0DFF98 000030 (v01 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: DBG2 0x00000807FA0DFA98 00005C (v00 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: GTDT 0x00000807FA0DE998 000110 (v03 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: SPCR 0x00000807FA0DFE18 000050 (v02 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: EINJ 0x00000807FA0DF598 000150 (v01 Ampere Altra    00000001 INTL 20201217)
> [    0.000000] ACPI: HEST 0x00000807FA0DEB18 0001F4 (v01 Ampere Altra    00000001 INTL 20201217)
> [    0.000000] ACPI: SSDT 0x00000807FA0DFA18 00002D (v02 Ampere Altra    00000001 INTL 20201217)
> [    0.000000] ACPI: TPM2 0x00000807FA0DFD18 00004C (v04 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: MCFG 0x00000807FA0DF718 00007C (v01 Ampere Altra    00000001 AMP. 01000013)
> [    0.000000] ACPI: IORT 0x00000807FA0DEF18 0003DC (v00 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: APIC 0x00000807F66CE118 000AF4 (v05 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: PPTT 0x00000807FA0D8618 004520 (v02 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: SLIT 0x00000807FA0DFD98 00002D (v01 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: SRAT 0x00000807FA0DCE18 000370 (v03 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: PCCT 0x00000807FA0DE318 000576 (v02 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: STAO 0x00000807F66CEC10 000025 (v01 Ampere Altra    00000002 AMP. 01000013)
> [    0.000000] ACPI: SPCR: console: pl011,mmio32,0x100002600000,115200
> [    0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x88300000-0x883fffff]
> [    0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x90000000-0xffffffff]
> [    0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x80000000000-0x8007fffffff]
> [    0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x80100000000-0x807ffffffff]
> [    0.000000] NUMA: NODE_DATA [mem 0x8079fbf5e00-0x8079fbf7fff]
> [    0.000000] Zone ranges:
> [    0.000000]   DMA      [mem 0x0000000098000000-0x00000000ffffffff]
> [    0.000000]   DMA32    empty
> [    0.000000]   Normal   [mem 0x0000000100000000-0x00000807fa0dffff]
> [    0.000000] Movable zone start for each node
> [    0.000000] Early memory node ranges
> ….
> 
> [    0.000000] Dentry cache hash table entries: 262144 (order: 9, 2097152 bytes, linear)
> [    0.000000] Inode-cache hash table entries: 131072 (order: 8, 1048576 bytes, linear)
> [    0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off
> [    0.000000] software IO TLB: mapped [mem 0x00000000f4000000-0x00000000f8000000] (64MB)
> [    0.000000] Memory: 1929152K/2097412K available (13568K kernel code, 1996K rwdata, 3476K rodata, 4160K init, 822K bss, 168260K reserved,
> 0K cma-reserved)
> [    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=32, Nodes=1
> [    0.000000] ftrace: allocating 41306 entries in 162 pages
> ….
> 
> ….
> [   12.599484] loop: module loaded
> [   12.603160] nvme nvme0: pci function 0005:04:00.0
> [   12.608129] igb: Intel(R) Gigabit Ethernet Network Driver
> [   12.613495] igb: Copyright (c) 2007-2014 Intel Corporation.
> [   12.613636] nvme nvme0: missing or invalid SUBNQN field.
> [   12.625941] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008
> [   12.634726] Mem abort info:
> [   12.637520]   ESR = 0x96000044
> [   12.640646]   EC = 0x25: DABT (current EL), IL = 32 bits
> [   12.646055]   SET = 0, FnV = 0
> [   12.649153]   EA = 0, S1PTW = 0
> [   12.652365] Data abort info:
> [   12.655314]   ISV = 0, ISS = 0x00000044
> [   12.659231]   CM = 0, WnR = 1
> [   12.662260] [0000000000000008] user address but active_mm is swapper
> [   12.668724] Internal error: Oops: 96000044 [#1] PREEMPT SMP
> [   12.674358] Modules linked in:
> [   12.677455] CPU: 0 PID: 7 Comm: kworker/u64:0 Tainted: G        W         5.10.27-ampere-lts-standard #1
> [   12.687083] Workqueue: nvme-reset-wq nvme_reset_work
> [   12.692059] pstate: 60c00085 (nZCv daIf +PAN +UAO -TCO BTYPE=--)
> [   12.698149] pc : steal_suitable_fallback+0x138/0x2f0
> [   12.703170] lr : steal_suitable_fallback+0x1bc/0x2f0
> [   12.708203] sp : ffff80001196b820
> [   12.711569] x29: ffff80001196b820 x28: 0000000000000000
> [   12.716975] x27: 0000000000000000 x26: ffff8000114dbcb0
> [   12.722357] x25: fffffdffffe00000 x24: 0000000000000001
> [   12.727740] x23: 0000000000000000 x22: fffffe201bf60000
> [   12.733120] x21: ffff08071fbf6980 x20: 0000000000000901
> [   12.738502] x19: 0000000000080000 x18: ffffffffffffffff
> [   12.743884] x17: 0000000000000000 x16: 0000000000000012
> [   12.749266] x15: ffff08070508c683 x14: 0000000000000058
> [   12.754648] x13: 00000000000000c0 x12: 0000000000000000
> [   12.760030] x11: 0000000000000400 x10: 000000000000000c
> [   12.765412] x9 : ffff800010039d58 x8 : 0000000020000000
> [   12.770794] x7 : 0000000000000018 x6 : ffff800011750890
> [   12.776176] x5 : ffff800011750878 x4 : 0000000000000000
> [   12.781558] x3 : 0000000000000000 x2 : 0000000000000000
> [   12.786940] x1 : 0000000000000200 x0 : 0000000000000000
> [   12.792322] Call trace:
> [   12.794806]  steal_suitable_fallback+0x138/0x2f0
> [   12.799520]  get_page_from_freelist+0xe30/0x12a0
> [   12.804207]  __alloc_pages_nodemask+0x148/0xe00
> [   12.808809]  __dma_direct_alloc_pages+0xa4/0x1d0
> [   12.813496]  dma_direct_alloc+0x1d8/0x340
> [   12.817571]  xen_swiotlb_alloc_coherent+0x68/0x370
> [   12.822439]  dma_alloc_attrs+0xe8/0xf0
> [   12.826246]  nvme_reset_work+0x1030/0x1520
> [   12.830417]  process_one_work+0x1dc/0x4bc
> [   12.834495]  worker_thread+0x144/0x470
> [   12.838313]  kthread+0x14c/0x160
> [   12.841604]  ret_from_fork+0x10/0x38
> [   12.845255] Code: a94082c4 d37ef463 cb3c4063 8b3c4042 (f9000480)
> [   12.851447] ---[ end trace f68728a0d3053b72 ]---
> [   12.856117] note: kworker/u64:0[7] exited with preempt_count
 
xen_swiotlb_alloc_coherent calls dma_direct_alloc which fails for the
device.

Without swiotlb_xen, dma_alloc_attrs would do:

	if (dma_alloc_direct(dev, ops))
		cpu_addr = dma_direct_alloc(dev, size, dma_handle, flag, attrs);
	else if (ops->alloc)
		cpu_addr = ops->alloc(dev, size, dma_handle, flag, attrs);

dma_alloc_direct is the very same call that fails when called from
xen_swiotlb_alloc_coherent. So it must be that the path meant to be
taken is ops->alloc instead.

ops->alloc is the dma_ops function to allocate a coherent buffer.
When swiotlb-xen is enabled, it points to xen_swiotlb_alloc_coherent.
Often dma_ops is NULL when Xen is disabled.

I think the most likely explanation is that the nvme device require a
specific dma_ops. When swiotlb-xen is enabled, it gets overwritten by
arch/arm64/mm/dma-mapping.c:arch_setup_dma_ops.

Can you double-check this theory by adding a few printks in
arch/arm64/mm/dma-mapping.c:arch_setup_dma_ops, to check the dma_ops
used when !CONFIG_XEN, and also in kernel/dma/mapping.c:dma_alloc_attrs
to check the code path taken when !CONFIG_XEN?

>From there we should be able to understand quickly the difference
between the non-swiotlb-xen and the swiotlb-xen cases.

Thanks!
--8323329-1451968002-1649883768=:3066615--


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 21:38:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 21:38:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304327.518949 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nekgv-0004MO-Oi; Wed, 13 Apr 2022 21:38:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304327.518949; Wed, 13 Apr 2022 21:38:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nekgv-0004MH-Ls; Wed, 13 Apr 2022 21:38:21 +0000
Received: by outflank-mailman (input) for mailman id 304327;
 Wed, 13 Apr 2022 21:38:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nekgu-0004M7-2T; Wed, 13 Apr 2022 21:38:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nekgt-00035h-VF; Wed, 13 Apr 2022 21:38:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nekgt-0002NN-Ew; Wed, 13 Apr 2022 21:38:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nekgt-0000Ej-EV; Wed, 13 Apr 2022 21:38:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rNWwEXNWIzFzTtSUqWyZAXUc8P6C7IWnBGoNH1QLh+U=; b=sXuUtyHLaMbsYz2sIs4pzHyxM0
	Z30ZatEB5IL/JdqmArSXheylc7nWoSiOJlg65ewgrHD4qfIsyEnPZrn1MjqEb/nCd6ITv6qmcMPhs
	5uD3Br3utQjsAh2YmGf4gel4M377uv+93U3hCIJ0tfzvSuU/pH518WCB4tsI8h7qEeZ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169376-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169376: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 21:38:19 +0000

flight 169376 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169376/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  370 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   21 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 22:24:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 22:24:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304337.518961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nelPA-00010w-Bd; Wed, 13 Apr 2022 22:24:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304337.518961; Wed, 13 Apr 2022 22:24:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nelPA-00010p-8s; Wed, 13 Apr 2022 22:24:04 +0000
Received: by outflank-mailman (input) for mailman id 304337;
 Wed, 13 Apr 2022 22:24:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VmS/=UX=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1nelP8-00010j-Nr
 for xen-devel@lists.xenproject.org; Wed, 13 Apr 2022 22:24:02 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a65f72e-bb78-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 00:24:00 +0200 (CEST)
Received: from [IPV6:2a00:5f00:102:0:10b3:10ff:fe5d:4ec1] (unknown
 [IPv6:2a00:5f00:102:0:10b3:10ff:fe5d:4ec1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 (Authenticated sender: dmitry.osipenko)
 by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 16B2A1F47620;
 Wed, 13 Apr 2022 23:23:55 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a65f72e-bb78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1649888639;
	bh=EkR5aP9YXjDV++4Mm3vdM0ntQFHoUFn8du5hNEWzcVU=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=j1A1c0tVlfMHwkO7ph7+BXecjl3zjCSCuFY4mjDRsMmEMUiSRn2BdhdRX28bqNwRd
	 0kArRjhlR3IJGzxnsIsIV55CLgmFFI2NSRANmlAgGh9kCXVIhjheVEf98HAY8hRICr
	 de+NRfs0/E1u09npw7AvIBnHJ1RV4t8z84ccFmlq2rh+QRMZrOxIOsnFLQ8+zt1Kd4
	 qKUl7Umpny+Mkmr77FYSLFjlQUix00R1aWWELoW4IA9Fdi4ygNsJKyHTTDcHL21FER
	 5mHsl6TGS0ii5K5AIMCobu3OluHXcov5Vb4ZmIfOFm8YTbDv+QPwuKnXvhZ8Xql3Cd
	 iLKh0vklwzMtQ==
Message-ID: <af51d9d0-26ba-fc66-05f1-d92ef7172730@collabora.com>
Date: Thu, 14 Apr 2022 01:23:52 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v7 03/20] reboot: Print error message if restart handler
 has duplicated priority
Content-Language: en-US
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzk@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
 Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org,
 "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
 linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
 Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <20220411233832.391817-4-dmitry.osipenko@collabora.com>
 <CAJZ5v0gf1J+yPW14TAdLGLGfO+-2s=r0DDP7d+Rgop3=dB0gaQ@mail.gmail.com>
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
In-Reply-To: <CAJZ5v0gf1J+yPW14TAdLGLGfO+-2s=r0DDP7d+Rgop3=dB0gaQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/13/22 21:48, Rafael J. Wysocki wrote:
> On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
> <dmitry.osipenko@collabora.com> wrote:
>>
>> Add sanity check which ensures that there are no two restart handlers
>> registered using the same priority. This requirement will become mandatory
>> once all drivers will be converted to the new API and such errors will be
>> fixed.
>>
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> 
> The first two patches in the series are fine with me and there's only
> one minor nit regarding this one (below).
> 
>> ---
>>  kernel/reboot.c | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/kernel/reboot.c b/kernel/reboot.c
>> index ed4e6dfb7d44..acdae4e95061 100644
>> --- a/kernel/reboot.c
>> +++ b/kernel/reboot.c
>> @@ -182,6 +182,21 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
>>   */
>>  int register_restart_handler(struct notifier_block *nb)
>>  {
>> +       int ret;
>> +
>> +       ret = atomic_notifier_chain_register_unique_prio(&restart_handler_list, nb);
>> +       if (ret != -EBUSY)
>> +               return ret;
>> +
>> +       /*
>> +        * Handler must have unique priority. Otherwise call order is
>> +        * determined by registration order, which is unreliable.
>> +        *
>> +        * This requirement will become mandatory once all drivers
>> +        * will be converted to use new sys-off API.
>> +        */
>> +       pr_err("failed to register restart handler using unique priority\n");
> 
> I would use pr_info() here, because this is not a substantial error AFAICS.

It's indeed not a substantial error so far, but it will become
substantial later on once only unique priorities will be allowed. The
pr_warn() could be a good compromise here, pr_info() is too mild, IMO.


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 22:35:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 22:35:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304343.518972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nelaE-0002VT-CZ; Wed, 13 Apr 2022 22:35:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304343.518972; Wed, 13 Apr 2022 22:35:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nelaE-0002VM-9c; Wed, 13 Apr 2022 22:35:30 +0000
Received: by outflank-mailman (input) for mailman id 304343;
 Wed, 13 Apr 2022 22:35:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nelaD-0002VC-Df; Wed, 13 Apr 2022 22:35:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nelaD-000447-Br; Wed, 13 Apr 2022 22:35:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nelaD-0005Id-0G; Wed, 13 Apr 2022 22:35:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nelaC-0004Q1-W3; Wed, 13 Apr 2022 22:35:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lqLz8yF3yXpXCibXfsJY083qxnDSp61g9GISfufpHKs=; b=BjssvcCgXpK4XraDgpLlecc+TO
	aalEIw+B9yb/scfr6+Mgjzp4JPICNby6Cs745a8jxXopnXwwiBMlocrALVV01dnuNB+++mJrU8VtN
	qFv07jCkJEVGUNykUFxAK+mcUZcic3XaxipP0kvpu0npgaeJmRoYV+/K0WZ+gBbxfEO0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169377-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169377: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 22:35:28 +0000

flight 169377 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169377/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  371 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   22 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 23:14:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 23:14:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304386.519001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nemC5-0007tc-Se; Wed, 13 Apr 2022 23:14:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304386.519001; Wed, 13 Apr 2022 23:14:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nemC5-0007tV-Pn; Wed, 13 Apr 2022 23:14:37 +0000
Received: by outflank-mailman (input) for mailman id 304386;
 Wed, 13 Apr 2022 23:14:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nemC4-0007tL-IN; Wed, 13 Apr 2022 23:14:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nemC4-0004l1-GU; Wed, 13 Apr 2022 23:14:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nemC4-0007BA-0t; Wed, 13 Apr 2022 23:14:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nemC3-0000bg-Vp; Wed, 13 Apr 2022 23:14:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+E/7QDG2hldvlh1TvHBjivco6ba17nZRZPS579wLh2w=; b=suP7HqRoh2NCt0/AP40q3upr2r
	cIB9O8MX6yYiWSmrfcXMMx+bT0mV/1epjx/xbK/335QQHgWFzBWXdBpkoP2qd6U7wdnmV8lc7LYhc
	DjPhIwtSbddNtBIXDQ0Ig9AhoVY+hlrXuLNzhbiXyIBX12ZGLl71EFNwacFp1ffrEoMc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169378-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169378: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 23:14:35 +0000

flight 169378 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169378/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  372 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   23 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 13 23:59:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Apr 2022 23:59:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304397.519012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nemtV-0003oP-A9; Wed, 13 Apr 2022 23:59:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304397.519012; Wed, 13 Apr 2022 23:59:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nemtV-0003oI-6c; Wed, 13 Apr 2022 23:59:29 +0000
Received: by outflank-mailman (input) for mailman id 304397;
 Wed, 13 Apr 2022 23:59:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nemtT-0003o8-OK; Wed, 13 Apr 2022 23:59:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nemtT-0005Tx-M1; Wed, 13 Apr 2022 23:59:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nemtT-0001FV-A8; Wed, 13 Apr 2022 23:59:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nemtT-000649-9f; Wed, 13 Apr 2022 23:59:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oPH1KftFgsAQmtXmhNUQ8DYhLM4Ga3WPAen0yRhERKE=; b=eOd8OuLKGTvhcLNvQ2evYQV6I4
	gBjmX5mvXkw9gC9Rnn4T4kRf7/BbmoY3sWZfDRSQOfv00OJiwa42VNQsFOztDrU4J/uBFmllH6ivR
	v3acl7Y/M28N9rKSIggA4HvZy1JbV6c14dz5CPffIipzURZXA+bTBRPNZkZ+WU8booLE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169379-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169379: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=c411566fad3d6d61a97edfa6e97a91688b175201
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Apr 2022 23:59:27 +0000

flight 169379 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169379/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 c411566fad3d6d61a97edfa6e97a91688b175201
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  373 attempts
Testing same since   169343  2022-04-13 00:10:23 Z    0 days   24 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5022 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 00:30:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 00:30:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304406.519023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nenNk-0008Vu-Gh; Thu, 14 Apr 2022 00:30:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304406.519023; Thu, 14 Apr 2022 00:30:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nenNk-0008Vn-Do; Thu, 14 Apr 2022 00:30:44 +0000
Received: by outflank-mailman (input) for mailman id 304406;
 Thu, 14 Apr 2022 00:30:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nenNj-0008Vd-94; Thu, 14 Apr 2022 00:30:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nenNj-0006cL-66; Thu, 14 Apr 2022 00:30:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nenNi-00027A-My; Thu, 14 Apr 2022 00:30:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nenNi-0006Ve-MT; Thu, 14 Apr 2022 00:30:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oF9nC75P1YPKUVp06DdQB3twjJOcnnbnx0we0lMYVsA=; b=wXBUIz4n2d1r+jslzYvGk93sI+
	31ncRnNah1FdtjdPZ2fx605KMeY98tXrnPTuQLe8w8NM5YJ6DFZSw43Iaq2BWnbEiTIyMX2Eg8mW+
	AUl6QiMmM9KrtqwTrqnUtcYfnS3yIMsnMksKgWT2wjNH8sQtNNu/L/+JL+sEFIRdai0I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169380-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169380: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=8a5727c7a82a371649419daddc2c52554ff29b16
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 00:30:42 +0000

flight 169380 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169380/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 8a5727c7a82a371649419daddc2c52554ff29b16
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  374 attempts
Testing same since   169380  2022-04-14 00:11:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5032 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 01:10:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 01:10:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304417.519033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nenzv-0002YS-Eu; Thu, 14 Apr 2022 01:10:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304417.519033; Thu, 14 Apr 2022 01:10:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nenzv-0002YL-C1; Thu, 14 Apr 2022 01:10:11 +0000
Received: by outflank-mailman (input) for mailman id 304417;
 Thu, 14 Apr 2022 01:10:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nenzt-0002YB-PM; Thu, 14 Apr 2022 01:10:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nenzt-00057N-Mf; Thu, 14 Apr 2022 01:10:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nenzt-00032F-6o; Thu, 14 Apr 2022 01:10:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nenzt-0007Ci-6K; Thu, 14 Apr 2022 01:10:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vqEaaXSc9FxjgdOdt4b0i0TQaCJLyYdpgac38lAyY+o=; b=E7KzRc6CSIQ/A5MHBNG+APLts/
	sgfDI3/HjkPmecNbzk7AVlLmiI1uaWOBhI8ysNhGrZTNc9eL7NIFevAkDnOnc4xPnrXt1hXR1exdA
	KqLsDz8MClMZ4f8/7KP9p/AqNJpR3d9XswKHgT39BBO2lyJAWHtdW5cDe0Tl24tGZcag=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169373-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169373: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=5b752808ff37b7c819a26fd76329ef329c42774f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 01:10:09 +0000

flight 169373 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169373/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169348
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169348
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169348
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169348
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169348
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 169348
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169348
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169348
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169348
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169348
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169348
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169348
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169348
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  5b752808ff37b7c819a26fd76329ef329c42774f

Last test of basis   169348  2022-04-13 01:51:50 Z    0 days
Testing same since   169373  2022-04-13 18:06:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Ross Lagerwall <ross.lagerwall@citrix.com> # livepatch

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   5b752808ff..e509b5f932  e509b5f932608e74deac96048b28a5e9b210c647 -> master


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 01:14:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 01:14:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304430.519056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neo40-0003RG-AY; Thu, 14 Apr 2022 01:14:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304430.519056; Thu, 14 Apr 2022 01:14:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neo40-0003R9-76; Thu, 14 Apr 2022 01:14:24 +0000
Received: by outflank-mailman (input) for mailman id 304430;
 Thu, 14 Apr 2022 01:14:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qEdm=UY=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1neo3y-0003R3-LQ
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 01:14:22 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 36cad9d1-bb90-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 03:14:21 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 85911B827AC;
 Thu, 14 Apr 2022 01:14:20 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1FC6C385A6;
 Thu, 14 Apr 2022 01:14:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36cad9d1-bb90-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649898859;
	bh=Vw563it+aBA2EdVmayXOdyTgaYtBCPeL5gs0nBXc4Tc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=RYaq58NtD1y2GeeqAXkVRK0y4nni43Tc+kNF2NlZcyAA8VfyX8KTrxOC0JqXRNC4v
	 GNvzFEA01IDyAvb8GSDgS4TTuWoDYiFpHoH4BJVNg8qMKDYJnEuD3MOnZAdD973zrt
	 tcoG1wGltAsMx0YJRiGQRWmMNBGeY24FCoZDyc5q4k/qYIQIowrfP+ha+avW5K5RTq
	 hPrIBqnCuZRF11WZKTPRZVGs02rOP7w7h2EmdC8i0DulHxEwcdjGAhXfFLPJZMnt2w
	 VLy7CaDDEE/8OJMZZ0cFwufsz8yrlo4RWXKAIQu0bE6b8TXvg+J4GtNVrHuDiDOZHM
	 pToByN5rQHi1A==
Date: Wed, 13 Apr 2022 18:14:18 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Rahul Singh <Rahul.Singh@arm.com>, xen-devel@lists.xenproject.org, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
In-Reply-To: <D24074F6-E6CF-440A-9E9B-A10783C273D7@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204131657200.3066615@ubuntu-linux-20-04-desktop>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com> <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop> <alpine.DEB.2.22.394.2204081837410.3066615@ubuntu-linux-20-04-desktop>
 <D24074F6-E6CF-440A-9E9B-A10783C273D7@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Apr 2022, Bertrand Marquis wrote:
> What you mention here is actually combining 2 different solutions inside
> Xen to build a custom communication solution.
> My assumption here is that the user will actually create the device tree
> nodes he wants to do that and we should not create guest node entries
> as it would enforce some design.
> 
> If everything can be statically defined for Xen then the user can also
> statically define node entries inside his guest to make use of the events
> and the shared memories.
> 
> For example one might need more than one event to build a communication
> system, or more than one shared memory or could build something
> communicating with multiple guest thus requiring even more events and
> shared memories.

Hi Bertrand, Rahul,

If the guests are allowed some level of dynamic discovery, this feature
is not needed. They can discover the shared memory location from the
domU device tree, then proceed to allocate evtchns as needed and tell
the other end the evtchn numbers over shared memory. I already have an
example of it here:

https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/2251030537/Xen+Shared+Memory+and+Interrupts+Between+VMs

What if the guest doesn't support device tree at runtime, like baremetal
or Zephyr? The shared memory address can be hardcoded or generated from
device tree at build time. That's no problem. Then, the event channels
can still be allocated at runtime and passed to the other end over
shared memory. That's what the example on the wikipage does.


When are static event channels actually useful? When the application
cannot allocate the event channels at runtime at all. The reason for the
restriction could be related to safety (no dynamic allocations at
runtime) or convenience (everything else is fully static, why should the
event channel numbers be dynamic?)

Given the above, I can see why there is no need to describe the static
event channel info in the domU device tree: static event channels are
only useful in fully static configurations, and in those configurations
the domU device tree dynamically generated by Xen is not needed. I can
see where you are coming from.


The workflow that we have been trying to enable with the System Device
Tree effort (System Device Tree is similar to a normal Device Tree plus
the xen,domains nodes) is the following:

S-DT ---[lopper]---> Linux DT
                L--> Zephyr DT ---[Zephyr build]---> Zephyr .h files

S-DT contains all the needed information for both the regular Linux DT
generation and also the Zephyr/RTOS/baremetal header files generation,
that happens at build time.

S-DT is not the same as the Xen device tree, but so far it has been
conceptually and practically similar. I always imagine that the bindings
we have in Xen we'll also have corresponding bindings in System Device
Tree.

For this workflow to work S-DT needs all the info so that both Linux DT
and Zephyr DT and Zephyr .h files can be generated.

Does this proposal contain enough information so that Zephyr .h files
could be statically generated with the event channel numbers and static
shared memory regions addresses?

I am not sure. Maybe not?


It is possible that the shared memory usage is so application specific
that there is no point in even talking about it. But I think that
introducing a simple bundle of both event channels and shared memory
would help a lot.

Something like the following in the Xen device tree would be enough to
specify an arbitrary number of event channels connected with the same
domains sharing the memory region.

It looks like that if we did the below, we would carry a lot more useful
information compared to the original proposal alone. We could add a
similar xen,notificaiton property to the domU reserved-memory region in
device tree generated by Xen for consistency, so that everything
available to the domU is described fully in device tree.


    domU1 {
        compatible = "xen,domain";

        /* one sub-node per local event channel */
        ec1: evtchn@1 {
            compatible = "xen,evtchn-v1";
            /* local-evtchn link-to-foreign-evtchn */
            xen,evtchn = <0x1 &ec3>
        };
        ec2: evtchn@2 {
            compatible = "xen,evtchn-v1";
            xen,evtchn = <0x2 &ec4>
        };
        /*
         * shared memory region between DomU1 and DomU2.
         */
        domU1-shared-mem@50000000 {
            compatible = "xen,domain-shared-memory-v1";
            xen,shm-id = <0x1>;
            xen,shared-mem = <0x50000000 0x20000000 0x60000000>;
            /* this is new */
            xen,notification = <&ec1 &ec2>;
        }
    };

    domU2 {
        compatible = "xen,domain";

        /* one sub-node per local event channel */
        ec3: evtchn@3 {
            compatible = "xen,evtchn-v1";
            /* local-evtchn link-to-foreign-evtchn */
            xen,evtchn = <0x3 &ec1>
        };
        ec4: evtchn@4 {
            compatible = "xen,evtchn-v1";
            xen,evtchn = <0x4 &ec2>
        };
        /*
         * shared memory region between domU1 and domU2.
         */
        domU2-shared-mem@50000000 {
            compatible = "xen,domain-shared-memory-v1";
            xen,shm-id = <0x1>;
            xen,shared-mem = <0x50000000 0x20000000 0x70000000>;
            /* this is new */
            xen,notification = <&ec3 &ec4>;
        }
    };



The good thing about this is that:

- it is very flexible
- nothing to do in this series, except switching to the
  one-subnode-per-evtchn model, which we called 2) in the previous email
- there were good reasons to use the one-subnode-per-evtchn model anyway
- the xen,notification property can be added later without issues, after Penny's series

There are a couple of ways to implement the xen,notification property
but we don't need to discuss them now.


Short Summary
------------
I think it is fine to only introduce the Xen device tree binding for
static event channels without domU binding, but I prefer if we switched
to using proposal 2) "one subnode per event channel".


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 01:26:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 01:26:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304435.519068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neoFD-0004xE-AV; Thu, 14 Apr 2022 01:25:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304435.519068; Thu, 14 Apr 2022 01:25:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neoFD-0004x7-7N; Thu, 14 Apr 2022 01:25:59 +0000
Received: by outflank-mailman (input) for mailman id 304435;
 Thu, 14 Apr 2022 01:25:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neoFC-0004wx-BH; Thu, 14 Apr 2022 01:25:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neoFC-0005O6-9b; Thu, 14 Apr 2022 01:25:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neoFC-0003Ng-0a; Thu, 14 Apr 2022 01:25:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neoFC-0003X5-0A; Thu, 14 Apr 2022 01:25:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MSPj2h/V45LK4Z+SH0ZxKkyFFIXq5kONIG7lAUhFUaU=; b=mP46Cngwxb1/g58pYHbAYnQvJ6
	eSCyf3jhgGBa0MDj46aP2FnsNY7y4J/HZ48BPaYDHf5T9NGgc2iMMR1MA1NRRkBQxJJpOkSo0tPUO
	zZxLLduyBs6YR9yXh7vIJ2/DXj/RmceS833og0hOTH02VdX4RM0Bujf9xCGte4BsfZ1Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169381-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169381: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=8a5727c7a82a371649419daddc2c52554ff29b16
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 01:25:58 +0000

flight 169381 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169381/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 8a5727c7a82a371649419daddc2c52554ff29b16
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   43 days  375 attempts
Testing same since   169380  2022-04-14 00:11:38 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5032 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 02:19:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 02:19:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304445.519079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nep5E-00022W-95; Thu, 14 Apr 2022 02:19:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304445.519079; Thu, 14 Apr 2022 02:19:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nep5E-00022P-5R; Thu, 14 Apr 2022 02:19:44 +0000
Received: by outflank-mailman (input) for mailman id 304445;
 Thu, 14 Apr 2022 02:19:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nep5C-00022F-Oz; Thu, 14 Apr 2022 02:19:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nep5C-0006jN-NB; Thu, 14 Apr 2022 02:19:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nep5C-0004dx-5t; Thu, 14 Apr 2022 02:19:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nep5C-00012q-5R; Thu, 14 Apr 2022 02:19:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RdzUjbVUWaZdk6XGnYSw+n8mDBwl7PsJop8SG005aVg=; b=nou5IwslzDPpKRulGL4EjbM7HT
	50XEo+n3cFFkVcig7nZ2ESelii7hltrQnXO8UVt8ElPWujjXAyo0sSPb0sesSAYqyAv1AdwZ3nQaH
	CKtlvttpDL+S/jyvjcEYDgdlzFDO0Dl6imgKL86xAO6dwgwZRLlki0Y+YSLpUAvu1+Mo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169382-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169382: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=8a5727c7a82a371649419daddc2c52554ff29b16
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 02:19:42 +0000

flight 169382 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169382/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 8a5727c7a82a371649419daddc2c52554ff29b16
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  376 attempts
Testing same since   169380  2022-04-14 00:11:38 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5032 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 03:14:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 03:14:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304454.519090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nepwN-00081D-CT; Thu, 14 Apr 2022 03:14:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304454.519090; Thu, 14 Apr 2022 03:14:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nepwN-000816-8o; Thu, 14 Apr 2022 03:14:39 +0000
Received: by outflank-mailman (input) for mailman id 304454;
 Thu, 14 Apr 2022 03:14:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nepwL-00080w-N8; Thu, 14 Apr 2022 03:14:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nepwL-0007ed-Ku; Thu, 14 Apr 2022 03:14:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nepwL-0007xg-C0; Thu, 14 Apr 2022 03:14:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nepwL-0000rN-Bb; Thu, 14 Apr 2022 03:14:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mhYd/DlD8B5XjXjL6drn2qol6NgOv1GM2lbyxX+IJgQ=; b=RHddy7xY8okjKSpOHpy+Q8aj9t
	0thK6BrKadrgB5yrSB5yqlLHbecee2Xo92FW4eSdGro8OmcXAp9P6Hn/c+4hXS0gyacfXYETmWfms
	k2AiVda20aEuOtLHa9+RKbDZ76sR5vB03Iq6kuIx0f1lVUMUgiJE8BZviZh87yW/FLH8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169384-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169384: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=8a5727c7a82a371649419daddc2c52554ff29b16
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 03:14:37 +0000

flight 169384 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169384/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 8a5727c7a82a371649419daddc2c52554ff29b16
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  377 attempts
Testing same since   169380  2022-04-14 00:11:38 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5032 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 04:28:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 04:28:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304467.519101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ner5R-0006rx-RD; Thu, 14 Apr 2022 04:28:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304467.519101; Thu, 14 Apr 2022 04:28:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ner5R-0006rq-Ns; Thu, 14 Apr 2022 04:28:05 +0000
Received: by outflank-mailman (input) for mailman id 304467;
 Thu, 14 Apr 2022 04:28:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ner5P-0006rg-VJ; Thu, 14 Apr 2022 04:28:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ner5P-0000Su-Sv; Thu, 14 Apr 2022 04:28:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ner5P-0003Ie-K8; Thu, 14 Apr 2022 04:28:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ner5P-0001Gu-Jl; Thu, 14 Apr 2022 04:28:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=nmAzkspxXYB4NpvhUnYC+d58M5b9jcqTr4PN/K0RRsQ=; b=BBIGSDrXiboY/tECFJyuogi0fe
	8UDdZsypGsi9j5/9lFNimqF9Tqm2P0pLCLoDSweaODMgaXqWf4bnhEESH6qmt+OM+JtsAI4KqngSk
	FpCi/nH+h0dHq6BGnFpZpHrvOoyaX+3bc/NiK+mg1h2viGkJ+wQXpTfCjPZcyglFb0Nc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169385-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169385: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 04:28:03 +0000

flight 169385 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169385/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  378 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 06:53:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 06:53:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304478.519112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1netLy-0004gn-L0; Thu, 14 Apr 2022 06:53:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304478.519112; Thu, 14 Apr 2022 06:53:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1netLy-0004gg-GC; Thu, 14 Apr 2022 06:53:18 +0000
Received: by outflank-mailman (input) for mailman id 304478;
 Thu, 14 Apr 2022 06:53:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1netLx-0004gW-Rp; Thu, 14 Apr 2022 06:53:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1netLx-0003Lq-Oi; Thu, 14 Apr 2022 06:53:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1netLx-0001o4-Gd; Thu, 14 Apr 2022 06:53:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1netLx-0000mT-G8; Thu, 14 Apr 2022 06:53:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qaFJebskQkPOG4yMPd47I1yfp0c3eOyL/WPneubF/pE=; b=nlZh1QykFP3V8fx/cSEPpcFgU7
	029UPELktuvtNjBoEo3MI3r235RjXHzb2WR66ZIH6Ot6TxiwmrZveROxf3qv3abJHPLRFZOTd6D1d
	7RAXAMFH9RlYYreXHLBBtZACyGkBi3AO2V31IkQx8f9vGI722hh8h1+UShLaDL1ExErU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169386-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169386: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=f647a4b8ddd2f6155c7ec1bc95c200747b72903a
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 06:53:17 +0000

flight 169386 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169386/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              f647a4b8ddd2f6155c7ec1bc95c200747b72903a
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  643 days
Failing since        151818  2020-07-11 04:18:52 Z  642 days  624 attempts
Testing same since   169386  2022-04-14 04:20:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104493 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 07:03:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 07:03:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304488.519134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1netWA-0006WM-00; Thu, 14 Apr 2022 07:03:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304488.519134; Thu, 14 Apr 2022 07:03:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1netW9-0006WD-TE; Thu, 14 Apr 2022 07:03:49 +0000
Received: by outflank-mailman (input) for mailman id 304488;
 Thu, 14 Apr 2022 07:03:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8iUY=UY=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1netW8-0006VS-8f
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 07:03:48 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20606.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::606])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06b19387-bbc1-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 09:03:46 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB7PR04MB5994.eurprd04.prod.outlook.com (2603:10a6:10:89::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr
 2022 07:03:44 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5144.029; Thu, 14 Apr 2022
 07:03:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06b19387-bbc1-11ec-8fbd-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CfSk5RxEJd3SkmXddp4DyhmPCAelp4i9khrA68yhrw/qOf/xCFpe4O1bNKcM/lAI17V+9136G8K3lWOcAIIlUlK6AiRqGs3G1ejoxa9YkB22KFRmWy5HUHN70+YEgUnYhVgFvnqZ2hg/gkdwTi6moTTOJpHMQgCqGLG7duyqFMqtTX2IlfI4xXGvZX3gL+l1UbRvQplLeTtqpfQsrfgjab22JOYcGzaduyjRV6fiaqbkS2DiqDSGfMGDUmlsbKxj7KcHLySGSAmza6jBHEVugQb/2vkn5L5uAtKdAaZbLwgGvGJr+bYEDFB3LwitnexwA3klLNtQ0/hq7tLMXfPTxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8ASfelA1sgwddq6HCVN8ZQ6DUvJaEq/At9EOCkA2Mlo=;
 b=mKLfnVr1XV24JM3IIeiorG0QL4SXvSrdVSrNNfyDKXx1GH+lyMJINaA6rONkAuqD52pOBu7XyuadzIt4EQuV2A/z6/fE4pCoGE8ZAtYZshVttY8QreLQ/088l4HDhlDM7KwGf2Jz/SZ+nOrbafY19f0szjhrLtoLkbHx6p7jnM6eNOoArGmWe90kJM2dUMsDeWj8VgIGON6PSVL1x7CDoek+hy3rHE0RgEEbiRpT/D2LIMNaClQjvwW5MWDun644Oo4aZPy5l8RfdL69zm0hpUs9++P5TyEMxXXJ+O2WNGpZTxKcYhsL5Gs8Wju9gDn9jmKJlxVFCs61+jxoTRjdYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8ASfelA1sgwddq6HCVN8ZQ6DUvJaEq/At9EOCkA2Mlo=;
 b=eAs9PFVlma4gspzZ4CiCxDD/i0Tf4j3cWpmU0VXcdBRe/L16CKfS2wlLHvjsII7wUSRNmGaXVbMCyeLS5B5FaiRSIbuetZRJ2g+ROPuWaz8IvbcFyvDRtWQK46YJB3+6PCKcPr5ipwpOAnFRpAgRqzomJZyEPtAqeaUsCk0p13M=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
Date: Thu, 14 Apr 2022 15:44:51 +0800
Message-Id: <20220414074452.14419-2-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220414074452.14419-1-peng.fan@oss.nxp.com>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SGAP274CA0023.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::35)
 To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5bbcb948-a8ae-468a-f340-08da1de4e9d5
X-MS-TrafficTypeDiagnostic: DB7PR04MB5994:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB5994148EC5F81AF17ECFB4EDC9EF9@DB7PR04MB5994.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2RBThJ6qUDBu39h1toBHLcFPcI1R1pQCYns3HPjOH5Iet792zIrhq7LdehqceIn92Sh8tmDpO+aMI22K2W0TRpwICXDlck63J0SUK91mwWcA1IYztZ+m3uQdbmA/GLhL40jgZ7Iu1f3y84Ds6+G1+sra8vC9IUOFFM1xAiqn3kkpfIB5BB4tcEPpa0iscunpiKitLbTkTNtqkiedZjhq07Xx4CoZ+IQnUumMsu3dpe12BnAtaYubS7Eilw4pUQkav5XA/gqyuucQyDyPsPVmg5Vky8lY48h9+P3bZsqoNKLBQ1068GssIVo4OEhxV15BIMmdi/nTrCYS6vCHNu74PD30XEOitaHUTSDOE7LN2Yl6fYZHOVak5PgEcWxY0kZ9I0y+0sf592pvnedGrRk+8wcga5NssKCijH15xHMOfqEVC0N6IcmHBx7+AbkR2iqGBTQ8YlGKVMQI32sS0JFzlbtJT0IAjiTP8U1fGKPF+M/LoW13m/mIUVsBw3r3ebjJxelkLSwG38V5fakLdt9naFfRH5THojlxjiJ44CMOYR1jPmbdMSx2YxvU9zCWzmEoj30wkGF7pxeQegCOOXBWnwRR+EOwD/THk5iLi/MjCGCRlZ285usFZAXekvQ2jR5lnS99azEtdrS4yIfTC6iF6g2vVu3ExDNWLLYBsmqdcY7/knL1PQ/6neu6OMXwkq47MQyrlOKoM46D9hYWTOD5W9aSGpM9+9RF2gmZzrUZd9xGCKWgqAnpE213rDeUWsULXTelY7wvGET1r700Rn5RBFprUEMy31ACYo08xynE/f4zWKDlvnwHOm1A7Mc9UKTb
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66556008)(66476007)(4326008)(8676002)(83380400001)(54906003)(6666004)(6486002)(966005)(8936002)(7416002)(30864003)(2906002)(186003)(5660300002)(2616005)(1076003)(86362001)(508600001)(26005)(6512007)(316002)(6506007)(52116002)(38350700002)(38100700002)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?USRQa78oUqJNAl1CpTTUfkrTGHzoENgnTMkpROMpsIbOe/B1i9UnUNpttbRO?=
 =?us-ascii?Q?pzb0r8Wv4wX84buxD+n8PeaiAV6r380Y+6nEtwx+pmimTQ/CLCkJetMwbIeH?=
 =?us-ascii?Q?Dc5DOPYS/9jv0ctICt9HXNRglRo0W75ricldbfpaqPeiloGJa19vBIwwXffK?=
 =?us-ascii?Q?idjQc2ZWT1TjVS5B8SfkvcVnBwuazwo7u4mEa7kvmHGQdcKOs14HH5itx2Vc?=
 =?us-ascii?Q?+F7y0o8o/zTTD/v4lC8EcDedATaJOBJ2G6pc2MkyCBHzXYtv6ibNn0mBLZSC?=
 =?us-ascii?Q?lqcURZedBsBGQeWFHK0uCMKKt/QQyncbhAy0q9IRRFo+zOwPZaZt+A8mwjIV?=
 =?us-ascii?Q?L9mF20jz+CeHDSUzv5ymwAptfPO5LFafWsYqOg4w30EeLjPzzV3k2MOKHg9T?=
 =?us-ascii?Q?pSuT40+hViggC5PUKNw/EIqvXBCRJyIWVCLi/UgH9scMuqPN/b2OHMQjD3Kc?=
 =?us-ascii?Q?fd4tZAZC+G3rtwOCbirAAqF3DxiZr3vKoKZo7eQaXuX83IxoEii1qdbU9RH4?=
 =?us-ascii?Q?2PLquCh793dT3AerYQZNhj2Id1WmdpvV1O7P5hTrPfIeBYBU3SxIjPzHjTWl?=
 =?us-ascii?Q?Mq3D/ynoS6zFpUTrQgeJO+vK457dxrmnGs1GPLZgXdvnOMqE2e9VAQOWttAR?=
 =?us-ascii?Q?K3gd4xu4hgxiem3GYQOcV/oSKXBpja+UoLWuBekyPU+VwPEV41UKfkCdVbKh?=
 =?us-ascii?Q?igPZVrvKGRuRP2/hY+Ooc+UlZRZ9EkItrO4un0tv7l2Uyc9QIzZYTFHlpZ9c?=
 =?us-ascii?Q?g/0qwEywzgVnZ4FlovrTiqcGHOWsnLrwAXoYfal6zRPMINqA3eKT4kbX5mnJ?=
 =?us-ascii?Q?G86slc4565CHMZ3kRnwiLrqWeY8iw3f9WUzJLnyhHiJ9UV2l+l/5xENgqPme?=
 =?us-ascii?Q?I8pGZeDNFYmmwj0jheoHdJS5ObSf7YB0DOLN9jNxAZqD//+lysnrOrSpgmqi?=
 =?us-ascii?Q?d/3i0cV6z/byUAwEMv7WYL3xB+beoDZN6ofcEUr3KxkrWJaBPcHm1/QKI0sj?=
 =?us-ascii?Q?e0yVMp8vYIS7QIeK3A6g8takp72VO1P6B85DDjhEfILMetdKjfQkaLM7r38Y?=
 =?us-ascii?Q?oL3kl8vkKDS3mZgUUw4nHwkW6IE28zSAjZchincOn5dgnUNAPA8pfKQloOX5?=
 =?us-ascii?Q?KdjuPntQoGNnyaU4BjXZN6cE8N3lawR+ABbZWypt3rOmBiSQnamnWrP6IcYY?=
 =?us-ascii?Q?ATVy21TVUTbcasRS0IBDp4LXw6bigsfC7r6HJs52O5IRG+bIvZetvqA950ps?=
 =?us-ascii?Q?0vLaormpdupLmnceC1qmvmjaTE87FO0ZkBft27gFNdO4FmHNFDJ9NI4eNuZX?=
 =?us-ascii?Q?k94ycf+oIe1PoUojOLsOunWP31mu34Y+KGWtMzV2mtHFij6nXPZz7SGWfHIN?=
 =?us-ascii?Q?Rmph4rfjxi+bpSyQvHQrw8WTIwpgCs2wtwdl6RfIy9r7MZ9RdqqkU8hqkZF1?=
 =?us-ascii?Q?ILG+v+rIEaOOdRmKlFnarYz39E4rH0XyvcOQpi35lOOEWuMZ2EdllC6ZK/Sk?=
 =?us-ascii?Q?9Cf5JKlwy8V5tCNJ9E710qGv8J4BFMbs6PUzHgqX/RNAVpXHvXRKTgLrEtok?=
 =?us-ascii?Q?vqIYUUi6qsGt2UvY0PwQkI6JNNXc2CBiwXlrtADhvX+ePj1lU55QgT2FOeju?=
 =?us-ascii?Q?fe1CSNoOdp3SN0TkChW6q42hrIwueyEnJSGPRCHZafb9B1ZqWDqkeYLn6Hy9?=
 =?us-ascii?Q?r1Dvb0qMQgUUEbeMAowKm9a+5I4aYwz2wTSk3brNbXnahPmkG95z1iJiHk9z?=
 =?us-ascii?Q?DSkXLu/WdQ=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bbcb948-a8ae-468a-f340-08da1de4e9d5
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 07:03:44.2032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VR/zJf7ZSwh02LH+W1+4r0jTkeK4vLbmFv5AWWd1QafioAS05PrBtrnzuQqLbYURj6EQlx3njx9cenmW1XpAog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5994

From: Peng Fan <peng.fan@nxp.com>

The i.MX LPUART Documentation:
https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
Chatper 13.6 Low Power Universal Asynchronous Receiver/
Transmitter (LPUART)

Tested-by: Henry Wang <Henry.Wang@arm.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
 xen/drivers/char/Kconfig              |   7 +
 xen/drivers/char/Makefile             |   1 +
 xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
 4 files changed, 348 insertions(+)
 create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
 create mode 100644 xen/drivers/char/imx-lpuart.c

diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
new file mode 100644
index 0000000000..fe859045dc
--- /dev/null
+++ b/xen/arch/arm/include/asm/imx-lpuart.h
@@ -0,0 +1,64 @@
+/*
+ * xen/arch/arm/include/asm/imx-lpuart.h
+ *
+ * Common constant definition between early printk and the LPUART driver
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ASM_ARM_IMX_LPUART_H__
+#define __ASM_ARM_IMX_LPUART_H__
+
+/* 32-bit register definition */
+#define UARTBAUD          (0x10)
+#define UARTSTAT          (0x14)
+#define UARTCTRL          (0x18)
+#define UARTDATA          (0x1C)
+#define UARTMATCH         (0x20)
+#define UARTMODIR         (0x24)
+#define UARTFIFO          (0x28)
+#define UARTWATER         (0x2c)
+
+#define UARTSTAT_TDRE     BIT(23, UL)
+#define UARTSTAT_TC       BIT(22, UL)
+#define UARTSTAT_RDRF     BIT(21, UL)
+#define UARTSTAT_OR       BIT(19, UL)
+
+#define UARTBAUD_OSR_SHIFT    (24)
+#define UARTBAUD_OSR_MASK     (0x1f)
+#define UARTBAUD_SBR_MASK     (0x1fff)
+#define UARTBAUD_BOTHEDGE     (0x00020000)
+#define UARTBAUD_TDMAE        (0x00800000)
+#define UARTBAUD_RDMAE        (0x00200000)
+
+#define UARTCTRL_TIE      BIT(23, UL)
+#define UARTCTRL_TCIE     BIT(22, UL)
+#define UARTCTRL_RIE      BIT(21, UL)
+#define UARTCTRL_ILIE     BIT(20, UL)
+#define UARTCTRL_TE       BIT(19, UL)
+#define UARTCTRL_RE       BIT(18, UL)
+#define UARTCTRL_M        BIT(4, UL)
+
+#define UARTWATER_RXCNT_OFF     24
+
+#endif /* __ASM_ARM_IMX_LPUART_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index 2ff5b288e2..e5f7b1d8eb 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -13,6 +13,13 @@ config HAS_CADENCE_UART
 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
 	  based board, say Y.
 
+config HAS_IMX_LPUART
+	bool "i.MX LPUART driver"
+	default y
+	depends on ARM_64
+	help
+	  This selects the i.MX LPUART. If you have i.MX8QM based board, say Y.
+
 config HAS_MVEBU
 	bool "Marvell MVEBU UART driver"
 	default y
diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
index 7c646d771c..14e67cf072 100644
--- a/xen/drivers/char/Makefile
+++ b/xen/drivers/char/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o
 obj-$(CONFIG_HAS_OMAP) += omap-uart.o
 obj-$(CONFIG_HAS_SCIF) += scif-uart.o
 obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o
+obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o
 obj-$(CONFIG_ARM) += arm-uart.o
 obj-y += serial.o
 obj-$(CONFIG_XEN_GUEST) += xen_pv_console.o
diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
new file mode 100644
index 0000000000..df44f91e5d
--- /dev/null
+++ b/xen/drivers/char/imx-lpuart.c
@@ -0,0 +1,276 @@
+/*
+ * xen/drivers/char/imx-lpuart.c
+ *
+ * Driver for i.MX LPUART.
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/errno.h>
+#include <xen/init.h>
+#include <xen/irq.h>
+#include <xen/mm.h>
+#include <xen/serial.h>
+#include <asm/device.h>
+#include <asm/imx-lpuart.h>
+#include <asm/io.h>
+
+#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
+#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
+
+static struct imx_lpuart {
+    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
+    uint32_t irq;
+    char __iomem *regs;
+    struct irqaction irqaction;
+    struct vuart_info vuart;
+} imx8_com;
+
+static void imx_lpuart_interrupt(int irq, void *data,
+                                 struct cpu_user_regs *regs)
+{
+    struct serial_port *port = data;
+    struct imx_lpuart *uart = port->uart;
+    uint32_t sts, rxcnt;
+
+    sts = imx_lpuart_read(uart, UARTSTAT);
+    rxcnt = imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
+
+    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
+	    serial_rx_interrupt(port, regs);
+
+    if ( sts & UARTSTAT_TDRE )
+	    serial_tx_interrupt(port, regs);
+
+    imx_lpuart_write(uart, UARTSTAT, sts);
+}
+
+static void __init imx_lpuart_init_preirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t ctrl, old_ctrl, bd;
+
+    old_ctrl = imx_lpuart_read(uart, UARTCTRL);
+    ctrl = (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
+    bd = imx_lpuart_read(uart, UARTBAUD);
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
+	    cpu_relax();
+
+    /* Disable transmit and receive */
+    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL_RE));
+
+    /* Reuse firmware baudrate settings, only disable DMA here */
+    bd &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+
+    imx_lpuart_write(uart, UARTMODIR, 0);
+    imx_lpuart_write(uart, UARTBAUD, bd);
+    imx_lpuart_write(uart, UARTCTRL, ctrl);
+}
+
+static void __init imx_lpuart_init_postirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    uart->irqaction.handler = imx_lpuart_interrupt;
+    uart->irqaction.name = "imx_lpuart";
+    uart->irqaction.dev_id = port;
+
+    if ( setup_irq(uart->irq, 0, &uart->irqaction) != 0 )
+    {
+        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
+                uart->irq);
+        return;
+    }
+
+    /* Enable interrupts */
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp |= (UARTCTRL_RIE | UARTCTRL_TIE);
+    temp |= UARTCTRL_ILIE;
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static void imx_lpuart_suspend(struct serial_port *port)
+{
+    BUG();
+}
+
+static void imx_lpuart_resume(struct serial_port *port)
+{
+    BUG();
+}
+
+static int imx_lpuart_tx_ready(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
+}
+
+static void imx_lpuart_putc(struct serial_port *port, char c)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
+        cpu_relax();
+
+    imx_lpuart_write(uart, UARTDATA, c);
+}
+
+static int imx_lpuart_getc(struct serial_port *port, char *pc)
+{
+    struct imx_lpuart *uart = port->uart;
+    int ch;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
+	    return 0;
+
+    ch = imx_lpuart_read(uart, UARTDATA);
+    *pc = ch & 0xff;
+
+    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
+        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
+
+    return 1;
+}
+
+static int __init imx_lpuart_irq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return ((uart->irq > 0) ? uart->irq : -1);
+}
+
+static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return &uart->vuart;
+}
+
+static void imx_lpuart_start_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTSTAT);
+    /* Wait until empty */
+    while ( !(temp & UARTSTAT_TDRE) )
+	    cpu_relax();
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
+}
+
+static void imx_lpuart_stop_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp &= ~(UARTCTRL_TIE | UARTCTRL_TCIE);
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static struct uart_driver __read_mostly imx_lpuart_driver = {
+    .init_preirq = imx_lpuart_init_preirq,
+    .init_postirq = imx_lpuart_init_postirq,
+    .endboot = NULL,
+    .suspend = imx_lpuart_suspend,
+    .resume = imx_lpuart_resume,
+    .tx_ready = imx_lpuart_tx_ready,
+    .putc = imx_lpuart_putc,
+    .getc = imx_lpuart_getc,
+    .irq = imx_lpuart_irq,
+    .start_tx = imx_lpuart_start_tx,
+    .stop_tx = imx_lpuart_stop_tx,
+    .vuart_info = imx_lpuart_vuart_info,
+};
+
+static int __init imx_lpuart_init(struct dt_device_node *dev,
+                                  const void *data)
+{
+    const char *config = data;
+    struct imx_lpuart *uart;
+    int res;
+    u64 addr, size;
+
+    if ( strcmp(config, "") )
+        printk("WARNING: UART configuration is not supported\n");
+
+    uart = &imx8_com;
+
+    uart->baud = 115200;
+    uart->data_bits = 8;
+    uart->parity = 0;
+    uart->stop_bits = 1;
+
+    res = dt_device_get_address(dev, 0, &addr, &size);
+    if ( res )
+    {
+        printk("imx8-lpuart: Unable to retrieve the base"
+               " address of the UART\n");
+        return res;
+    }
+
+    res = platform_get_irq(dev, 0);
+    if ( res < 0 )
+    {
+        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
+        return -EINVAL;
+    }
+    uart->irq = res;
+
+    uart->regs = ioremap_nocache(addr, size);
+    if ( !uart->regs )
+    {
+        printk("imx8-lpuart: Unable to map the UART memory\n");
+        return -ENOMEM;
+    }
+
+    uart->vuart.base_addr = addr;
+    uart->vuart.size = size;
+    uart->vuart.data_off = UARTDATA;
+    /* tmp from uboot */
+    uart->vuart.status_off = UARTSTAT;
+    uart->vuart.status = UARTSTAT_TDRE;
+
+    /* Register with generic serial driver */
+    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
+
+    dt_device_set_used_by(dev, DOMID_XEN);
+
+    return 0;
+}
+
+static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
+{
+    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
+    { /* sentinel */ },
+};
+
+DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
+    .dt_match = imx_lpuart_dt_compat,
+    .init = imx_lpuart_init,
+DT_DEVICE_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 07:03:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 07:03:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304487.519123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1netW5-0006FX-KJ; Thu, 14 Apr 2022 07:03:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304487.519123; Thu, 14 Apr 2022 07:03:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1netW5-0006FQ-HB; Thu, 14 Apr 2022 07:03:45 +0000
Received: by outflank-mailman (input) for mailman id 304487;
 Thu, 14 Apr 2022 07:03:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8iUY=UY=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1netW3-0006FK-Mo
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 07:03:43 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2060a.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::60a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 044107ec-bbc1-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 09:03:42 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB7PR04MB5994.eurprd04.prod.outlook.com (2603:10a6:10:89::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr
 2022 07:03:39 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5144.029; Thu, 14 Apr 2022
 07:03:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 044107ec-bbc1-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nDjml8HlNc2QmUS484OkRShGsDVbKlijdbGKi+gFE9WwvbuGA74WVh6swiqSfdQMgnnMNeBcw9Q9HEr/n0UABAt7wuwa8TiNmQQZkBCkXdgwpAcYCE3+5eMFcEeVJ54XjwM76EQ+PMICkVkjVT6ZpZGqCU0T1Vy76opPFXCZynvOGEmt0Rn4slEEOsuZmhBDkemu31skpIBhH8FClKIa4vJNIo+Hz6qXIGdkJ9KJ7p+fQ5+NV5p4DEOEDQL2UT33nlI/J6UAJ8ltA9cfkpspkBO+17Ej3X4PqfkcaULl5kRIK7SrmFy83264GgfJagE3deBAJiKNSgzkq3jaw9RkqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SeH0WJvPHx8xXkKGkPt9WDGrUtOayTZIRZa7m1vrAa0=;
 b=Q/CecqEcJboauitMNUwL+gBtNrEDYAPaPxEpjOrDOOydJ3nvQ9jGRseG8HyAdI+Ke0ab1VC6aZYRIB82oSWZNeU4XfYVcbbNRWWPGj3FAIhsGVlXPR0SbS2vSIOPl1OZ3t6oVrENlbobdhYu7PG1N1Cd8g4Rzp/VkcCOVnOimI1EjheCJWb5Ci4H8zkhe6eABC1ntzHCzcA18lkgChAtSOoZ1KlZRw7OYRCdvaENJiXqHAV7PwEPKzBndxTx/MWQea4MxU/9hccFJL40b2WpvHvQ5Qd6l20uxGQ9k2mQUutIM2TJ2VSHLoHkRkNnqFwOnFhe7/oBYyl79gl2gIYtwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SeH0WJvPHx8xXkKGkPt9WDGrUtOayTZIRZa7m1vrAa0=;
 b=LUO5jfnhW44M5tu89OmwlpjXmVikGsFfDNmYmzYrwXqP5MfNmW7I8aljzMKRNnOyqWFnQvT6Nou0U7OBNzCqZ0+Hp36F8LFbniFb5g7rRFBqn3PWz1hjLwOIQWTtQQ90qq+EMQ5b8oIPTeY49aUJvU6akPs+kB+xyzkw2voDUuQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V5 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial support
Date: Thu, 14 Apr 2022 15:44:50 +0800
Message-Id: <20220414074452.14419-1-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SGAP274CA0023.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::35)
 To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5c6679b3-028b-47f4-8ba9-08da1de4e6d3
X-MS-TrafficTypeDiagnostic: DB7PR04MB5994:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB59946077A161D6886476FD69C9EF9@DB7PR04MB5994.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uQQWf5BAVUZGnZ2OCgaDe0CJdEwiLPJEdnSTRjy33/MaSD+R1iJU9co7AL6QwSxuEtZAAzz2CNk/W9t2dokY3/x55M5fFi/9QibCTg+JE8dmnrLBvY65m/8sVW8zNNhrxDeuRMnMW3Vb0OPXUAXCm2EDCazosL5N065+vfQpOVhv69vjGeu5KEWtD6N9F/BtbZ/GNQNuLnwSec3zqRuhFQZDnaLq4FaioeYxsMHoQnRFWxBN9Szw1npE89Pf2xIcfJ11RsibOtTANhK64MxgPDkl0WATd/1W+5i/FsfvdYTdcLUAbYv8FFin9PfbGPV5vI5zqUvdr2oQTrmMONFwhc8WDjrjh0ULC7wmzteZ02GHSNp7hknnz0WEC9gYSgnOJhN/TfQmXLOMrndFim5VZ1YsaEhy18obvxTNkRBRlspTgF3PiXIiko/r6iHc/V85JEp/1APDxsYSn+8fQsOQ1LHUYsUgo6mQNPWh0byeSCKIdIfvX/12BQ3KKxFZKfXnBmDQsKJExWlPISFzX7oHQ1FGn9WnohXW8y1sRdiwsYJFxV5Fcuw4vqAwSGXae45n1lIzZw1YNZysmLWbYoBVANYkjHe9jxH79KPF+zpQQznV/GaecCg3XqN2AoCbMg++XLcCZq8qcojKXgXvYyMNkWAycfXR8e9HlSdUx+iKRfk+mKvKSsgwHz4iL+gzgizSuiv2Dyyxdk0/GNtMZ7Rqgg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66556008)(66476007)(4326008)(8676002)(6666004)(6486002)(8936002)(7416002)(2906002)(4744005)(186003)(5660300002)(2616005)(1076003)(86362001)(508600001)(26005)(6512007)(316002)(6506007)(52116002)(38350700002)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JPpD17BOWJ7ZlNbG8fjJ5nCk1acR8GuL3A7Vbhg+gmct+p7kt0dgctC0clzP?=
 =?us-ascii?Q?Wg2MxUp0/FzKwh53CUUmU7kRFHMjdrHOsAogQcb7HAj/gVQ2I0B6qQ7K0GCw?=
 =?us-ascii?Q?HVqAouacbzI2pjheXWxNB6/VyPXFIzq7+j+0Ko1OdF9rs3DjlSAZDHo2SHcJ?=
 =?us-ascii?Q?x8e/6rF4DjFgcI6W73lAtmXwgvABs+D2zmzQ2x1J5ImuA39V9fITDnlO0NPK?=
 =?us-ascii?Q?Ux3YHDi/p6qqZ0FZNCpxlbJONzVIyS8NrfLtVtDLlOsgqqB8PoKISL4sfbdp?=
 =?us-ascii?Q?IiWR3zuoXxx+pLvbMpKVeGe1e6aick2cONDvnvKHrr8Ln2PTc96A7tG6R5K4?=
 =?us-ascii?Q?0WvhSz4WK+DNR+h5YoxHgoKwddjdWt04zGzS1PbuFweL4tG5m4x+mewnbnbs?=
 =?us-ascii?Q?vt1zv+b+HzEqxKzuXjBepAhIPJLcSgtA+GdJX8zB5vvpFB/bo6IHUdxtpPkj?=
 =?us-ascii?Q?bbqfz2RjFLSTGzPIyHKp6SMH/lJOcC0rnrwltuzLsh/2qn6fEib8qLQ4xxl0?=
 =?us-ascii?Q?m835caIzDKzLuq2GtA+GE9V8TJYgLD6J3iZn1f06KrDtqar8zbOUSa/1ZnuY?=
 =?us-ascii?Q?Er7IaPUnj5qTSRq9B70E6FCofrHWrz82WkONECRKXWrjVdmggD8ZGNR09tnn?=
 =?us-ascii?Q?c0RfrXTtEMQwY52oeppYHMUoKYm3EUCan4djIfZGXUPwXqxs3CF6+uR4YiCg?=
 =?us-ascii?Q?MOlqEbALR9S06AbQLYAV6Xzz53Qq/xzYUwTiR/qb74A7m/gJKTUM4lWseZ7/?=
 =?us-ascii?Q?XpwjXoDg7ACsxgHy2ZBLgwcqPYz4iE1SmZvbk0vAcyIn3LVUjIdaWZKduMx4?=
 =?us-ascii?Q?NV11dg3f0aD+ztMD4X8GcXSQM7ZbGKYYJNRQ1n5C5hKXQ4WiC8a5kWgEJmDQ?=
 =?us-ascii?Q?qGq/wQ502+Xub8JQq9ZR68kt1K3q3HWuPG4b49GIvLEnHWt+pRc2LlHKYCb+?=
 =?us-ascii?Q?xc9OQnhhFQ0c6L+jU9ZKw+mXclT5AgHGdHqpmH6TwhYvJKydKJjqsDnqIcsR?=
 =?us-ascii?Q?PWXSjD8cY61aTeeNH97VG5yYB4t41UdfHcvHJj8MlkcXOqh8fitDD7YDEIiI?=
 =?us-ascii?Q?WNYHCG0fCWVVJYvKyPA3I+XGB61HzCHkMy1l86uOW+eRgh3f9CizwhbgJrxI?=
 =?us-ascii?Q?/SftGmhSBe5N7Duep1fYLeZ3G4Z06JdcUfunI2jH9cthqXWITgKQU23DfPK6?=
 =?us-ascii?Q?huvGiquBBpTa07JEowHGV+elvRERyKsgIbSRrp1vQBzajVdhFwyZhsi3MDGo?=
 =?us-ascii?Q?hXyn0qgKpgFALR5evqQeLM5MM8BnEfjstVJK5oOYc0YWaqTOlHB/w+vn+RlU?=
 =?us-ascii?Q?fj52T5vjIwIUEH/IbCT5YKDMyOcLAMTAG2t/7cqmJwa5mNlo9PKZ1MwnxPXO?=
 =?us-ascii?Q?XDfytkNQLEpIEPm3lvMtfVyr85RvQ8X4Gu/L3SWeuPsvW9QW4D4QWfF5U9Yl?=
 =?us-ascii?Q?T/x/+LZM8Glhuvot0TWpWNWghF984IcqNcR8motgXH1BGFJwGs0T3ug8Wpdw?=
 =?us-ascii?Q?zA1elblh/9+e1RDydtjyMrxda3QmlPJZG1wAKmCFNzJkblWIJtz4nGMArskl?=
 =?us-ascii?Q?DtqwgxywX7FLTrxtJH7PqH/kOvzp4rGbjP5Mw9jfd1eeOuxW4L1m6XuVLWQt?=
 =?us-ascii?Q?2HXC5rcy+op8ekC5hUJDBD6Q9ocHHcis2IpfL6SCw6IYpdEvHh5DOzyVsMSA?=
 =?us-ascii?Q?M/dLRw4QvR9sH1l67goLdJB5/mDR03vxkl+JIt1we5roKWTX4sL1f9kdG3VZ?=
 =?us-ascii?Q?vHws3k0hzA=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6679b3-028b-47f4-8ba9-08da1de4e6d3
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 07:03:39.1842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MwspO5hWVEjBpyo+v2RVN1oITBuPbYetJwliGrpX7EKd56S1RslK7h66NFkptORuzU4Lu9NwoRSXhm9mwMUobw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5994

From: Peng Fan <peng.fan@nxp.com>

V5:
 Align code
 drop early_uart_init

V4:
 Wrong v3 version, some BIT definition are mixed in patch 1,2. 

V3:
 Addressed Michal's comments.
 Add Henry's T-b

V2:
 Per Julien's comments, fix coding style issue, drop unneeded code

Add i.MX lpuart driver and i.MX8QM platform support.
 - lpuart is the uart IP used in i.MX8QM/QXP/93.
 - Very basic i.MX8QM platform support.



Peng Fan (2):
  xen/arm: Add i.MX lpuart driver
  xen/arm: Add i.MX lpuart early printk support

 xen/arch/arm/Kconfig.debug              |  14 ++
 xen/arch/arm/arm64/debug-imx-lpuart.inc |  48 +++++
 xen/arch/arm/include/asm/imx-lpuart.h   |  64 ++++++
 xen/drivers/char/Kconfig                |   7 +
 xen/drivers/char/Makefile               |   1 +
 xen/drivers/char/imx-lpuart.c           | 276 ++++++++++++++++++++++++
 6 files changed, 410 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
 create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
 create mode 100644 xen/drivers/char/imx-lpuart.c

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 07:03:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 07:03:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304489.519144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1netWC-0006oE-8r; Thu, 14 Apr 2022 07:03:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304489.519144; Thu, 14 Apr 2022 07:03:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1netWC-0006o5-5Y; Thu, 14 Apr 2022 07:03:52 +0000
Received: by outflank-mailman (input) for mailman id 304489;
 Thu, 14 Apr 2022 07:03:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8iUY=UY=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1netWB-0006VS-37
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 07:03:51 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20615.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::615])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 08ea643f-bbc1-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 09:03:50 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB7PR04MB5994.eurprd04.prod.outlook.com (2603:10a6:10:89::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr
 2022 07:03:48 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5144.029; Thu, 14 Apr 2022
 07:03:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08ea643f-bbc1-11ec-8fbd-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HbrH7OaqsrFG0o/X7Al8N2xz5pcLLub5KXjMINnyq25AdIcxDUqp1Ag0rbjYu5hMAQlF9SEmHcVMfzWBg+PJixuQKvxC8lrWW8SA8xWlXSdFa4mJUniROm75XJ58WRD8DTpue5XvSgPA7TrW/KFB1QQv45pxen9pSLHy5ps510oKHWle1YZ1FvVrdFsGHpgp2zRgLFFBJK4rfVZOv/N+cdc6pQlSKiM78ewTdOWqdkUzYVQS42dCd4VtTj8PZMhODHTWwb6V16srcSXo1pThjp4paU3xl3dA/RtVOJmsDNH3SkZB7g75CouQdEIbq9b176XMApUdA5vs8xca2D3Vkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1QqFMtw5JqTtw6Jd6dkBHTwFJGE0lWl5lR8Rfrbsrcs=;
 b=SLueyst1PJO0rqagpWhOIakYeQGgHtwFM63E2pPwiiIWF5GWVLNkwOKNpK8QChosg5CvkcS+Y3/OZvHk+ohF6PJJ9GuTstumVs5n7tRSt+uLEvemr28Z8sSPWbxmAiBv3ystC1L5O/IItKTHHHlXJdj+ZqLzOMibgI4hOllCsdbnfmK9TaGX2gYz7OBAgJZ+KI1heRdwu2bKeI2S7+jfYuIdpdROEFLuvoQxWNqjqGMyPj6IOQcWmwdqBP4iVaKT+E1aGcWu42sXjy8aQCGYt4B+T+Gyo68EtV51zenVBr0ReM7PjWnlxjKoP0SVcjFyK5ZjtCjEYDdFMJNITjp/6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1QqFMtw5JqTtw6Jd6dkBHTwFJGE0lWl5lR8Rfrbsrcs=;
 b=SmY7+QstiGAtEs++2QreX2LsXwmUbC9Qt50o37YZEGVR+pGcQuP8y5ZzcONuCuIlkAg8Cj+gCEUS2iZPwxBpDLn2B5ZS7KPyU1+BceEWt55faSZDOnRYf9VR5TVlw49g9Q52cPgLo4y0CSbRmbim+RpPA8/d1w+b6RbzcdLKxyk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V5 2/2] xen/arm: Add i.MX lpuart early printk support
Date: Thu, 14 Apr 2022 15:44:52 +0800
Message-Id: <20220414074452.14419-3-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220414074452.14419-1-peng.fan@oss.nxp.com>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SGAP274CA0023.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::35)
 To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe9acfc4-2831-41cd-9379-08da1de4ec4f
X-MS-TrafficTypeDiagnostic: DB7PR04MB5994:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB5994644DE0B20E6A38336BE4C9EF9@DB7PR04MB5994.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NTEv4/ag4FjNZqNHaYM/h3aI1AAFj4uij1+cAhFSYFFxd9Hy7vPQLXPDNEAfzxjALtnJ4wy7G2EkT0pTW2Zf2tysIIsrI4HMVuvKalkrUEqjW+ic5hEWJ333hbJq35p3Q8mIHaKuAsXEGoxJ5FufinKiEHOqWD2RtV5wi987B6KuAtRfCDcdcJp5hFCsDttn6Fswpwh4ZkkFMUp5erTZ5y5T5Ug0oZL+qr331cYW+ArvUduYwD1gKQwAJA3wxxbjBeh9WQLXesCOHIQikVDDjNmYHKpqizC1/8A8tMpOiDOU3UaVkv09fccsIen84uaAYEc86OkPON6clvWSGacpUzXgd1KuesDylZWiq2DJFFEo8dUFO9Hl68CeozvJcltvHMlyoUZws50/XDI+W3pd/Bqz2CmDIqbwQbB36O1MZAy43e/izJfxorLWX5cMc94NgG1UnO/UJiinhcs0UJRnvjkJj4pyQMpC/kV0NUaeQUpVZUHUsyNbjO38TTJvrAVnlQW+pyTUK+etSVo5FP3oMB97kh+QoHPV9TkRy6tGA+TAmHRSKGXkVmhJBXMQ3HIkP72yN5F9OYFgOoGxS1R6x7wZYppcuMRBfYZ3lCERl7s/89KlXraTuL4HOeA/TzhHguAE2OlWW3o/WUf5/LqwBeVcK7SQZTR9LOf6GeCyVGJPLYKvCN3q1WXkzjv/KLQ8mIrw8+tWRFzLE8xGc32NwylpdKB3KHnTJh9ERounHnc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66556008)(66476007)(4326008)(8676002)(6666004)(6486002)(8936002)(7416002)(2906002)(186003)(5660300002)(2616005)(1076003)(86362001)(508600001)(26005)(6512007)(316002)(6506007)(52116002)(38350700002)(38100700002)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?buxSw9NqhwoSCcETGcCJbTi1Uy8SO+XW7qrXovuzrmCPtwYvT15zOYf7oFrV?=
 =?us-ascii?Q?tA6WczSrUbf56HmSkGfUNQNPBo5iuVqs/Krym2rmqsnsmOSbqStEBqAMspKg?=
 =?us-ascii?Q?sVokzsIqSeCuOfL0QoVOYeEzovWg48RYrDMowYZ6Cau0VU0S2krYy4AjGcmt?=
 =?us-ascii?Q?RueJXLTjqDyPqUUHjbuyiI+iwU0pMe5kZG0HA4T7/9werVj74ptqtWvSqAMp?=
 =?us-ascii?Q?UXzEI+vPFmqshiS+JvpLH2WASjJLfkC33hUjNixui8AfVzknLadah5772uml?=
 =?us-ascii?Q?gLWwWE4ZRG5BkNKfBBQTOIbg6D7mnR9/Ngs+2/xeAnWcYzZxDhpGURWupItS?=
 =?us-ascii?Q?k/whi+535wQLKFfJvGYiU3vaQpCnn4C6cHYSXy6Fvyf/0o9YTK88UO5BnVSz?=
 =?us-ascii?Q?WvvpI2pEvgwMTSpnf6DtopPfQ9uIxV5ljRYg66j9bOjmCYUA8Rg88wmYlRA6?=
 =?us-ascii?Q?Scvk1OOckn4voIR9+pctblq91RBKHttfLbiO8DYdQaWN9SbWWNyAzeGCpDMt?=
 =?us-ascii?Q?RJ0EeXb++YHziYprGp2en1Md62zJrCSjgQ18MEUdbKc8SWGW+in+UR3q8Yem?=
 =?us-ascii?Q?Qi278cDfU1UDIo0/ptuCvZDLuOOACLqsg7WAZyLcF6YIchLRBNqHCDZd6FvE?=
 =?us-ascii?Q?Hv9mFoYzErj6Fffu/zRmLBj3xnl9SRYmqFt/a54cRpVDeRZ5fKiH+7PEZ/rm?=
 =?us-ascii?Q?DLO+7zqUvA+6Iu0o/0rj/Hi8Cgxa89Vf9aNugs5qzAzZ3hawEXfXV8qglgrf?=
 =?us-ascii?Q?bA6IgRedP2YEGsMXlvjQwf+mFEFQcg4Td7I2a4mUNpfSDBuUJC1NrvYb3qzk?=
 =?us-ascii?Q?HN9m+CRcxtOzElDn/NatZG6VjmjijyL+hbhsAG1oVeKQJ2FBLHSuYbvpsG59?=
 =?us-ascii?Q?39S70tCb5JYVUmhXTsTpScy5JMr2dUmLn4oz6dYnGLI8j2dBWRyQIs7EeEih?=
 =?us-ascii?Q?dSYWR/sAgTL042yUCQrB9fNg3A+B0Okc6GcBNqnhatBwrX/nl+z1ldWfo7cs?=
 =?us-ascii?Q?3oYOShUfxP2byGEIZDXw4X7Abiyb7YNA5wL7uSqMbSAcrrnalbLE/0Q7HMr7?=
 =?us-ascii?Q?VAUyMHv20l9u6W1xDx7iWt8f1Jy06XsqyWv+qXRA0YBm1NGV+PCzpV2+S06S?=
 =?us-ascii?Q?7MBDNPJLstr7uUMghJCTa3gIdYjt9zB8Chp3rjSeE5PAWN0Tc+rShbS/mwjf?=
 =?us-ascii?Q?HrJ/2v88QO62tEyI8Gkr12CGXehJ+bH4ELJ7aAyaF/d11FmN72gpOopvPro/?=
 =?us-ascii?Q?luW1xLhRIf+IAYynTU3WyIXMTL1wZ8KJrMjd1KvxqyGwOQzUyx0WkcgK+6Ke?=
 =?us-ascii?Q?/LzwZOUmZV205NO7iJCjPZuGvRFbYFmMh5wkaLaY+FDGIdocrmMHlv0/NyIL?=
 =?us-ascii?Q?oosqHsvmAzGNGpZG5R1slnSkf7HJw1DtJ1j1O4eabkjPMGhUpwqPq9Bm2TwC?=
 =?us-ascii?Q?qaul/avZQtizRnzLriG/RH65uZ246g6YXp7Btp9nyRCVoxevtUs3t0zaVZo3?=
 =?us-ascii?Q?GvYO90jBtCUJt2BSPMRvdplr4XTr5kdyGbrZNTFx1jLZhkQ48Hd2aiBj0fPj?=
 =?us-ascii?Q?GmosBW9v3IvURGqXuOPy8q1mPDQWvJ92T19oHik15WmQlr3FKFMHnH05BQ06?=
 =?us-ascii?Q?jdd5nJsquBD+XFS5+8tM+lYUuYnhrZukxEjXT+MVuJ40CR7U7Lun57lTD0t4?=
 =?us-ascii?Q?QW9zRtPBwaEPoRKlH9iZ4Ifvibzt9woyFxkoKzecBYkP83PeKby3rkFX9YMk?=
 =?us-ascii?Q?gvhDiXlTYA=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe9acfc4-2831-41cd-9379-08da1de4ec4f
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 07:03:48.2296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0HcuT775ZzjvfOZNtDFKAnpvQrJ4AFPhWh+ghdyX9K6jkS/M8MoJg+VNd1gtSJBxb/mSoTNOhDiUBucD7tkDxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5994

From: Peng Fan <peng.fan@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/Kconfig.debug              | 14 ++++++++
 xen/arch/arm/arm64/debug-imx-lpuart.inc | 48 +++++++++++++++++++++++++
 2 files changed, 62 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index 35ccd13273..842d768280 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -58,6 +58,16 @@ choice
 			This option is preferred over the platform specific
 			options; the platform specific options are deprecated
 			and will soon be removed.
+	config EARLY_UART_CHOICE_IMX_LPUART
+		select EARLY_UART_IMX_LPUART
+		depends on ARM_64
+		bool "Early printk via i.MX LPUART"
+		help
+			Say Y here if you wish the early printk to direct their
+			output to a i.MX LPUART. You can use this option to
+			provide the parameters for the i.MX LPUART rather than
+			selecting one of the platform specific options below if
+			you know the parameters for the port.
 	config EARLY_UART_CHOICE_MESON
 		select EARLY_UART_MESON
 		depends on ARM_64
@@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
 config EARLY_UART_EXYNOS4210
 	select EARLY_PRINTK
 	bool
+config EARLY_UART_IMX_LPUART
+	select EARLY_PRINTK
+	bool
 config EARLY_UART_MESON
 	select EARLY_PRINTK
 	bool
@@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
 	default "debug-8250.inc" if EARLY_UART_8250
 	default "debug-cadence.inc" if EARLY_UART_CADENCE
 	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
+	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
 	default "debug-meson.inc" if EARLY_UART_MESON
 	default "debug-mvebu.inc" if EARLY_UART_MVEBU
 	default "debug-pl011.inc" if EARLY_UART_PL011
diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
new file mode 100644
index 0000000000..b169332932
--- /dev/null
+++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
@@ -0,0 +1,48 @@
+/*
+ * xen/arch/arm/arm64/debug-imx-lpuart.inc
+ *
+ * i.MX8QM specific debug code
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <asm/imx-lpuart.h>
+
+/*
+ * Wait LPUART to be ready to transmit
+ * rb: register which contains the UART base address
+ * rc: scratch register
+ */
+.macro early_uart_ready xb, c
+1:
+        ldr   w\c, [\xb, #UARTSTAT]   /* <- Flag register */
+        tst   w\c, #UARTSTAT_TDRE     /* Check FIFO EMPTY bit */
+        beq   1b                      /* Wait for the UART to be ready */
+.endm
+
+/*
+ * LPUART transmit character
+ * rb: register which contains the UART base address
+ * rt: register which contains the character to transmit
+ */
+.macro early_uart_transmit xb, wt
+        str   \wt, [\xb, #UARTDATA]  /* -> Data Register */
+.endm
+
+/*
+ * Local variables:
+ * mode: ASM
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 07:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 07:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304509.519156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neuFi-0004Ae-On; Thu, 14 Apr 2022 07:50:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304509.519156; Thu, 14 Apr 2022 07:50:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neuFi-0004AX-Ku; Thu, 14 Apr 2022 07:50:54 +0000
Received: by outflank-mailman (input) for mailman id 304509;
 Thu, 14 Apr 2022 07:50:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iU0v=UY=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1neuFh-0004AD-J6
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 07:50:53 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 9adf488b-bbc7-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 09:50:51 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D7DCF11FB;
 Thu, 14 Apr 2022 00:50:50 -0700 (PDT)
Received: from [10.57.9.215] (unknown [10.57.9.215])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 32B233F73B;
 Thu, 14 Apr 2022 00:50:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9adf488b-bbc7-11ec-a405-831a346695d4
Message-ID: <dafeba94-1443-f6b4-6aab-684fd1d6f7e4@arm.com>
Date: Thu, 14 Apr 2022 09:50:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>, Henry Wang <Henry.Wang@arm.com>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com>
 <20220414074452.14419-2-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220414074452.14419-2-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 14.04.2022 09:44, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The i.MX LPUART Documentation:
> https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
> Chatper 13.6 Low Power Universal Asynchronous Receiver/
> Transmitter (LPUART)
> 
> Tested-by: Henry Wang <Henry.Wang@arm.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 07:52:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 07:52:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304516.519167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neuHH-0004lh-3F; Thu, 14 Apr 2022 07:52:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304516.519167; Thu, 14 Apr 2022 07:52:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neuHG-0004la-WD; Thu, 14 Apr 2022 07:52:31 +0000
Received: by outflank-mailman (input) for mailman id 304516;
 Thu, 14 Apr 2022 07:52:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iU0v=UY=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1neuHF-0004lO-Rb
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 07:52:29 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id d4eecd6e-bbc7-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 09:52:28 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3FBA5139F;
 Thu, 14 Apr 2022 00:52:28 -0700 (PDT)
Received: from [10.57.9.215] (unknown [10.57.9.215])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DB9E3F73B;
 Thu, 14 Apr 2022 00:52:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4eecd6e-bbc7-11ec-a405-831a346695d4
Message-ID: <8fd66fe7-e5ea-7aab-50ed-f95ab3ccd8fc@arm.com>
Date: Thu, 14 Apr 2022 09:52:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V5 2/2] xen/arm: Add i.MX lpuart early printk support
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com>
 <20220414074452.14419-3-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220414074452.14419-3-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 14.04.2022 09:44, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 08:14:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 08:14:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304532.519178 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neucI-0007m7-9R; Thu, 14 Apr 2022 08:14:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304532.519178; Thu, 14 Apr 2022 08:14:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neucI-0007m0-5V; Thu, 14 Apr 2022 08:14:14 +0000
Received: by outflank-mailman (input) for mailman id 304532;
 Thu, 14 Apr 2022 08:14:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neucG-0007lq-JZ; Thu, 14 Apr 2022 08:14:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neucG-0005Ko-HJ; Thu, 14 Apr 2022 08:14:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neucG-00040k-5W; Thu, 14 Apr 2022 08:14:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neucG-0005hI-52; Thu, 14 Apr 2022 08:14:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jeCzSGyirsP8KCj/i4J0+Uu4wXbb2klBY5igEuMvW/E=; b=dTTDIGTnqdyQ3m5j++xAGr4Rw0
	Nk9AZhgxSqcuL2scx/e1eVj+6V/ntUmZCNerRpLLyU3wi7LSPR+jKRJIasrm3InmIUKT+5rJljw2z
	FWMkxZoNFI7rGEC+FMcc0qNohwQ5KC5OZyz8vPFTwJyezVBSZX6o7cUjfho9WrP7RRqg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169387-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169387: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 08:14:12 +0000

flight 169387 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169387/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  379 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 08:19:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 08:19:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304541.519189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neuhZ-0008Qe-UO; Thu, 14 Apr 2022 08:19:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304541.519189; Thu, 14 Apr 2022 08:19:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neuhZ-0008QX-R9; Thu, 14 Apr 2022 08:19:41 +0000
Received: by outflank-mailman (input) for mailman id 304541;
 Thu, 14 Apr 2022 08:19:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neuhZ-0008QN-Dx; Thu, 14 Apr 2022 08:19:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neuhZ-0005Q6-8D; Thu, 14 Apr 2022 08:19:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neuhY-00048d-MD; Thu, 14 Apr 2022 08:19:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neuhY-0005pX-Lj; Thu, 14 Apr 2022 08:19:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kMBkZg8glYow9yem8kYxKzOSMhC51MOidkeVs9JTGz4=; b=nrfAvL6QuK6TSXz501yrhIfn3G
	cYsJctsoFYG0abrqpaauvdRZTFNl7f9kJBFFCRRUde06LvcL+iYXST7MzQEASMRFx9digwfhdy5we
	q2MkxiBfTHluxgFHXDzDCixPZ9Lwpb9aLJ6+GQlva48QgKRUsxPZVRQ+04YiFv16Gf+Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169383-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169383: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-examine:reboot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 08:19:40 +0000

flight 169383 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169383/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-examine      8 reboot                     fail pass in 169373

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169373
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169373
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169373
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169373
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169373
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 169373
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169373
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169373
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169373
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169373
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169373
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169373
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169373
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647

Last test of basis   169383  2022-04-14 01:51:49 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     fail    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 09:01:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 09:01:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304552.519199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nevLx-00056k-Bb; Thu, 14 Apr 2022 09:01:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304552.519199; Thu, 14 Apr 2022 09:01:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nevLx-00056d-8N; Thu, 14 Apr 2022 09:01:25 +0000
Received: by outflank-mailman (input) for mailman id 304552;
 Thu, 14 Apr 2022 09:01:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nevLw-00056T-BD; Thu, 14 Apr 2022 09:01:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nevLw-00069W-96; Thu, 14 Apr 2022 09:01:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nevLv-00051Y-UG; Thu, 14 Apr 2022 09:01:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nevLv-00010m-Tn; Thu, 14 Apr 2022 09:01:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=SaWQCisA8RgGABzspp3QJO6FNABnKq4yRg54qS2bF34=; b=QFL/WPKeu0F4A0LFU8/hG/JkJo
	TkhRP7Z9b9B2QadsToQmWg8EeYq6i9XUCmmX7uNV2ujkY8nEcac+SPYEIsg/7s+dGsBahvnuCTEVb
	BB/7CjfZ8S1B1F9/UyJ9IS0jmMWJDmTKDe0RKzsgp39ZW7p3iWSxV7FXbIyIs2asXnJw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169388-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169388: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 09:01:23 +0000

flight 169388 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169388/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  380 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 09:05:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 09:05:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304560.519210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nevPa-0005kg-Tu; Thu, 14 Apr 2022 09:05:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304560.519210; Thu, 14 Apr 2022 09:05:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nevPa-0005kZ-QA; Thu, 14 Apr 2022 09:05:10 +0000
Received: by outflank-mailman (input) for mailman id 304560;
 Thu, 14 Apr 2022 09:05:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nevPZ-0005kR-NH
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 09:05:09 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f9ee07ad-bbd1-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 11:05:08 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9ee07ad-bbd1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649927108;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=yzod/7steHfeWcaKgLP3jqGVaacdsKwxS8qllhLhHzw=;
  b=KZ9ZtK6yYNmZ287fdevWpjcFxKwORpQ6ZO6burzDbm+lHIV03ufoTn2+
   78J7xDI+gIUCH69kYmMt76KrIK9gfSaz28gYcTDd8bQ/ZdmviEEjGGQ+8
   s4tMYXlJ69oAJ6M0xtdMNnpfyudCKZBu2w1F5snoZRcMz6ticHMF3sfpb
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68342880
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Vl++FKBitjXQ9xVW/yzjw5YqxClBgxIJ4kV8jS/XYbTApD8k3jZVz
 DRODW3SOv2NMGWkL9p0YNu+8BkHuJSDn4VjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhu0
 8p1q5qoTDw5N4SWo8gjA0EFDn1HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4eRqqEN
 5pBAdZpRAXsYhRmZ2ssM6p9vduQi2e4SG1XmV3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru3U70HxUbP9y30iee/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0RMFPK/M88AS22qP9uT21ODhcEyMdUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPTt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPQ1
 JTjs5LAhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGAufh8wbJpfImKBj
 KrvVeV5vs470JyCN/EfXm5MI55ykfiI+SrNC5g4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3CbSgOXiGrdROdTjn7xETXPjLliCeTcbbSiIOJY3rI6W5LW8JE2C9o5loqw==
IronPort-HdrOrdr: A9a23:+Z4KDKp31CE47tFumba4hbIaV5pIeYIsimQD101hICG9E/b5qy
 nKpp8mPHDP5Qr5NEtLpTniAsi9qA3nmqKdiLN5VYtKNzOLhILHFu9f0bc=
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="68342880"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/debug: Drop unnecessary include of compile.h
Date: Thu, 14 Apr 2022 10:04:56 +0100
Message-ID: <20220414090456.10965-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

compile.h changes across incremental builds, but nothing in debug.c uses it.
This avoids debug.c getting rebuilt on every incremental build.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/debug.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/arch/x86/debug.c b/xen/arch/x86/debug.c
index d90dc9305697..d16f6e6f8d5d 100644
--- a/xen/arch/x86/debug.c
+++ b/xen/arch/x86/debug.c
@@ -15,7 +15,6 @@
  */
 
 #include <xen/sched.h>
-#include <xen/compile.h>
 #include <xen/mm.h>
 #include <xen/domain_page.h>
 #include <xen/guest_access.h>
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 09:24:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 09:24:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304571.519222 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nevht-00088s-JD; Thu, 14 Apr 2022 09:24:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304571.519222; Thu, 14 Apr 2022 09:24:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nevht-00088l-FK; Thu, 14 Apr 2022 09:24:05 +0000
Received: by outflank-mailman (input) for mailman id 304571;
 Thu, 14 Apr 2022 09:24:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EpVF=UY=linaro.org=viresh.kumar@srs-se1.protection.inumbo.net>)
 id 1nevhr-00088f-MS
 for xen-devel@lists.xen.org; Thu, 14 Apr 2022 09:24:03 +0000
Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com
 [2607:f8b0:4864:20::42f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9ec2f26c-bbd4-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 11:24:02 +0200 (CEST)
Received: by mail-pf1-x42f.google.com with SMTP id n43so330955pfv.10
 for <xen-devel@lists.xen.org>; Thu, 14 Apr 2022 02:24:02 -0700 (PDT)
Received: from localhost ([223.184.83.228]) by smtp.gmail.com with ESMTPSA id
 mq6-20020a17090b380600b001c6357f146csm6283019pjb.12.2022.04.14.02.23.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 14 Apr 2022 02:24:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ec2f26c-bbd4-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=VilTKdHaAZDU2bXvzNDhMOT2Sg7lsFXIVJMvVgOiCqs=;
        b=L42l2g0wRoYss1s/odJ9W/8ynR+QhUmHYFwPXuj6AIQP2FtTtJRi/s8MvVqDrjJngD
         n1n9G17E7VeMuW2guQz8jdIpb2RmktMLTakPys5bNcx6lkYaK02/ejcuA3fSqx8lEGjJ
         xlsdWV+5pwS7GJ+yOTf3Gd/lw9XIX8iPLITqWuEAHAgKTFNx2RI6G80/UDaO5156WDj4
         CHu/9/WgvXoN1iGQb+X7QoVoEzDZUASWcP8PaO9uW18HmB9q3WTg7/ER66dVjEQju4uJ
         gIWfpuESKyCVkHRjPVLrKo1VGH5XaL1qy+zDKrEXfn/hQ5BYp091VBJ8arZWoZm26Am4
         i2Ww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=VilTKdHaAZDU2bXvzNDhMOT2Sg7lsFXIVJMvVgOiCqs=;
        b=Vvt8YVyurWfNRqovYzsscB6gww7ZtVjjEMpSNyLqGMPGLoecPqgqa7mv6QQrYIKSQV
         pcebo9+yKTNMompU6aO5X1BH9m4WAyk4ar+2aqhgEkfnCcgdVp1HuLMvN5ntIIk/B7J/
         hT7Tyb36oF/YFzVpd2GfaxI570HXPBwXxNfb4PP+veVekFeOsqOzs42DiM0TDdcJufY6
         wvsyynM5QLq57mKUC6N3pFDhPYqOsBuKUhnMA5nKU8eGjgzQbDMiJhK+t/h1q8cJ5YBV
         dbGkhod426xhSd0CrnA61FoYB5xCQeF4dLjTQxhpBtq4NYgyvYNUMMctnCBTEx75S/ND
         W6sw==
X-Gm-Message-State: AOAM531/WM19zhmobTNfTstk4xaIIwKEHowMOcdPSShsGdV9BLuU3JDS
	Wyx4LRvFMhX8mnYAbC3QR6B2Dg==
X-Google-Smtp-Source: ABdhPJyY6SytSpBAcGvhYVRZHx/N+7L9IKWJKKClZ9oBUO5jzYp8a4AMNc4pwwLOuX4gts+rR5XMVg==
X-Received: by 2002:a05:6a00:22c7:b0:505:9c6e:de39 with SMTP id f7-20020a056a0022c700b005059c6ede39mr2999800pfj.79.1649928240713;
        Thu, 14 Apr 2022 02:24:00 -0700 (PDT)
Date: Thu, 14 Apr 2022 14:53:58 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: stratos-dev@op-lists.linaro.org, xen-devel@lists.xen.org
Cc: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Mathieu Poirier <mathieu.poirier@linaro.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Mike Holmes <mike.holmes@linaro.org>,
	Oleksandr Tyshchenko <olekstysh@gmail.com>, Wei Liu <wl@xen.org>
Subject: Re: Virtio on Xen with Rust
Message-ID: <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
User-Agent: NeoMutt/20180716-391-311a52

+xen-devel

On 14-04-22, 14:45, Viresh Kumar wrote:
> Hello,
> 
> We verified our hypervisor-agnostic Rust based vhost-user backends with Qemu
> based setup earlier, and there was growing concern if they were truly
> hypervisor-agnostic.
> 
> In order to prove that, we decided to give it a try with Xen, a type-1
> bare-metal hypervisor.
> 
> We are happy to announce that we were able to make progress on that front and
> have a working setup where we can test our existing Rust based backends, like
> I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.
> 
> Key components:
> --------------
> 
> - Xen: https://github.com/vireshk/xen
> 
>   Xen requires MMIO and device specific support in order to populate the
>   required devices at the guest. This tree contains four patches on the top of
>   mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C).
> 
> - libxen-sys: https://github.com/vireshk/libxen-sys
> 
>   We currently depend on the userspace tools/libraries provided by Xen, like
>   xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates provides Rust
>   wrappers over those calls, generated automatically with help of bindgen
>   utility in Rust, that allow us to use the installed Xen libraries. Though we
>   plan to replace this with Rust based "oxerun" (find below) in longer run.
> 
> - oxerun (WIP): https://gitlab.com/mathieupoirier/oxerun/-/tree/xen-ioctls
> 
>   This is Rust based implementations for Ioctl and hypercalls to Xen. This is WIP
>   and should eventually replace "libxen-sys" crate entirely (which are C based
>   implementation of the same).
> 
> - vhost-device: https://github.com/vireshk/vhost-device
> 
>   These are Rust based vhost-user backends, maintained inside the rust-vmm
>   project. This already contain support for I2C and RNG, while GPIO is under
>   review. These are not required to be modified based on hypervisor and are
>   truly hypervisor-agnostic.
> 
>   Ideally the backends are hypervisor agnostic, as explained earlier, but
>   because of the way Xen maps the guest memory currently, we need a minor update
>   for the backends to work. Xen maps the memory via a kernel file
>   /dev/xen/privcmd, which needs calls to mmap() followed by an ioctl() to make
>   it work. For this a hack has been added to one of the rust-vmm crates,
>   vm-virtio, which is used by vhost-user.
> 
>   https://github.com/vireshk/vm-memory/commit/54b56c4dd7293428edbd7731c4dbe5739a288abd
> 
>   The update to vm-memory is responsible to do ioctl() after the already present
>   mmap().
> 
> - vhost-user-master (WIP): https://github.com/vireshk/vhost-user-master
> 
>   This implements the master side interface of the vhost protocol, and is like
>   the vhost-user-backend (https://github.com/rust-vmm/vhost-user-backend) crate
>   maintained inside the rust-vmm project, which provides similar infrastructure
>   for the backends to use. This shall be hypervisor independent and provide APIs
>   for the hypervisor specific implementations. This will eventually be
>   maintained inside the rust-vmm project and used by all Rust based hypervisors.
> 
> - xen-vhost-master (WIP): https://github.com/vireshk/xen-vhost-master
> 
>   This is the Xen specific implementation and uses the APIs provided by
>   "vhost-user-master", "oxerun" and "libxen-sys" crates for its functioning.
> 
>   This is designed based on the EPAM's "virtio-disk" repository
>   (https://github.com/xen-troops/virtio-disk/) and is pretty much similar to it.
> 
>   One can see the analogy as:
> 
>   Virtio-disk == "Xen-vhost-master" + "vhost-user-master" + "oxerun" + "libxen-sys" + "vhost-device".
> 
> 
> 
> Test setup:
> ----------
> 
> 1. Build Xen:
> 
>   $ ./configure --libdir=/usr/lib --build=x86_64-unknown-linux-gnu --host=aarch64-linux-gnu --disable-docs --disable-golang --disable-ocamltools --with-system-qemu=/root/qemu/build/i386-softmmu/qemu-system-i386;
>   $ make -j9 debball CROSS_COMPILE=aarch64-linux-gnu- XEN_TARGET_ARCH=arm64
> 
> 2. Run Xen via Qemu on X86 machine:
> 
>   $ qemu-system-aarch64 -machine virt,virtualization=on -cpu cortex-a57 -serial mon:stdio \
>         -device virtio-net-pci,netdev=net0 -netdev user,id=net0,hostfwd=tcp::8022-:22 \
>         -device virtio-scsi-pci -drive file=/home/vireshk/virtio/debian-bullseye-arm64.qcow2,index=0,id=hd0,if=none,format=qcow2 -device scsi-hd,drive=hd0 \
>         -display none -m 8192 -smp 8 -kernel /home/vireshk/virtio/xen/xen \
>         -append "dom0_mem=5G,max:5G dom0_max_vcpus=7 loglvl=all guest_loglvl=all" \
>         -device guest-loader,addr=0x46000000,kernel=/home/vireshk/kernel/barm64/arch/arm64/boot/Image,bootargs="root=/dev/sda2 console=hvc0 earlyprintk=xen" \
>         -device ds1338,address=0x20     # This is required to create a virtual I2C based RTC device on Dom0.
> 
>   This should get Dom0 up and running.
> 
> 3. Build rust crates:
> 
>   $ cd /root/
>   $ git clone https://github.com/vireshk/xen-vhost-master
>   $ cd xen-vhost-master
>   $ cargo build
> 
>   $ cd ../
>   $ git clone https://github.com/vireshk/vhost-device
>   $ cd vhost-device
>   $ cargo build
> 
> 4. Setup I2C based RTC device
> 
>   $ echo ds1338 0x20 > /sys/bus/i2c/devices/i2c-0/new_device; echo 0-0020 > /sys/bus/i2c/devices/0-0020/driver/unbind
> 
> 5. Lets run everything now
> 
>   # Start the I2C backend in one terminal (open new terminal with "ssh
>   # root@localhost -p8022"). This tells the I2C backend to hook up to
>   # "/root/vi2c.sock0" socket and wait for the master to start transacting.
>   $ /root/vhost-device/target/debug/vhost-device-i2c -s /root/vi2c.sock -c 1 -l 0:32
> 
>   # Start the xen-vhost-master in another terminal. This provides the path of
>   # the socket to the master side and the device to look from Xen, which is I2C
>   # here.
>   $ /root/xen-vhost-master/target/debug/xen-vhost-master --socket-path /root/vi2c.sock0 --name i2c
> 
>   # Start guest in another terminal, i2c_domu.conf is attached. The guest kernel
>   # should have Virtio related config options enabled, along with i2c-virtio
>   # driver.
>   $ xl create -c  i2c_domu.conf
> 
>   # The guest should boot fine now. Once the guest is up, you can create the I2C
>   # RTC device and use it. Following will create /dev/rtc0 in the guest, which
>   # you can configure with 'hwclock' utility.
> 
>   $ echo ds1338 0x20 > /sys/bus/i2c/devices/i2c-0/new_device
> 
> 
> Hope this helps.
> 
> -- 
> viresh

i2c_domu.conf

> kernel="/root/Image"
> memory=512
> vcpus=2
> command="console=hvc0 earlycon=xenboot"
> name="domu"
> i2c = [ "virtio=true, irq=1, base=1" ]

-- 
viresh


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 09:26:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 09:26:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304576.519233 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nevkd-0000K8-0u; Thu, 14 Apr 2022 09:26:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304576.519233; Thu, 14 Apr 2022 09:26:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nevkc-0000K1-U3; Thu, 14 Apr 2022 09:26:54 +0000
Received: by outflank-mailman (input) for mailman id 304576;
 Thu, 14 Apr 2022 09:26:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xfxB=UY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nevkc-0000Js-4W
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 09:26:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04a5a826-bbd5-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 11:26:53 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-CY5Ucz6PO1WLUdOVCshIZw-1; Thu, 14 Apr 2022 11:26:51 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS1PR04MB9384.eurprd04.prod.outlook.com (2603:10a6:20b:4d8::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr
 2022 09:26:49 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 09:26:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04a5a826-bbd5-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649928412;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=68DWobKimP9q7ZONaTMYa8j1VPPw+5WKo8zrFkW58vA=;
	b=mCqxNSoCvdQqn0wAHEHljpGkw2BE6JMNGwxy5TKT5DdGcJ///t8btqxKbXVjsUfYJii3Re
	TvDGea9aaXJOStl2uEdyTEiczlvog5e/4Ev36cswrLl57JSv8lGaOJcVvEE7+cK4wfZ3nN
	gJbMYtztoSv6QL9HYR4Qjw/6J2MEnoE=
X-MC-Unique: CY5Ucz6PO1WLUdOVCshIZw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nnnU+Z87LLiXmKpCym0zt6DiS6i7XCFIS/BAO7HkwX3ouvqHXdnS1IpPFp7AByVFpjUCpIxian4isfYctSzM7bNiSrZPnuLMzCiWaQ6Tk2OgDiygaLHVGTiC8NDOaBzlS6PG+3ynPfs6UW6XYdd1/HbR3kTNpqxIOkZhJInnIQ1ZEhQTZdSacpFEEbS7TIWJdeAjump3k0bZZfe12JLO18lPK1YD/uRYOCA3gc4CKPKjc0qNBieaOKusbJDNcSeB4ljajGEykJt0sqCYmhQiNcYUNqkdgUKYMQtOpT1e3XgbdyWI00WsevydhFEIErlFvaC9j+8bKZ7p/vqhjcgyGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=68DWobKimP9q7ZONaTMYa8j1VPPw+5WKo8zrFkW58vA=;
 b=KMw1FA1N3kv3uKBbcrk0TIO4kT/rj0KJcZB9oTbDJPh2gV55DLSnNfiw7+kDrfLkQbcllfpyZ8bwL/CO9zPAcVn7P1ShTaEt2KlaZJ230/Yatr2Q5PkVxcVEyvISTBAeYSFQh8iS06fvMkweBq+PKOdc7UDOPlend8142Eva7F7FPLU9DhMOfZ6CHObBV51YOpKGl9pexZyc6/kW7Ih9ZEdWa3Bg/F8hZt8hpZiC5Cc7BhIRz3fy1sXgsAvPKmDG6/pLBtOwhc7VIQr7rqOFKrPWPuibL0uHHI8P/knGVBZydHrFCBMYDiHYPSdFbNts+y8sjuGcWXrUwHubU5xvUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <674c4cbb-0e2f-a12a-986b-393b9cc4f970@suse.com>
Date: Thu, 14 Apr 2022 11:26:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] x86/debug: Drop unnecessary include of compile.h
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220414090456.10965-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220414090456.10965-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0004.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::9) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2ba24e1-4ea2-496b-bb02-08da1df8e73a
X-MS-TrafficTypeDiagnostic: AS1PR04MB9384:EE_
X-Microsoft-Antispam-PRVS:
	<AS1PR04MB9384BE19C95B48EC8DDC205BB3EF9@AS1PR04MB9384.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZW4VQECHzlwaMrbkfZh26lc4EdMkxRl4kYRdXWv6qAl0isn6TLvedXtXKv/duUiLxUv0MkOdDJqzXYGfZwKJzGuDfdFYC3MvIT+NdPeN/+n2yUzLEf+sNO5qzySOEVwRvrWcbU331CW2ADxh2BERJeAuBAiOH30H1ZEtIGxfcVMubVnhvhLcvLK7IxhNMApxtWqnKVhkqFkygbD+zBg5zSYQMeJ3kbz7hw6n148ErQPtQm3UlQgOotXIPTIMeBqW63PZWOnJtHZD8F2mJRlerpuS95L0uvxlvE6un5r1Prs8E1NbujwIoNmtk8w8Qy4/ehwnhWjYSJafZvaqkhrATf19CqY1kGfgj/W7ZZxZXpjTAaSPT3hErM+fqka8DOqOocd8dsFdy+wUghMwTHP9V/23g7AmVlB6ChL+pUTKTHtskq1sUpCdAezsPzMUI4L+T32a1zrfnjspUffRGk7uZn6F45k9RHp/pY6+sVkLOeumF3wloOjhL6mcwJEo4MHBIrlsMll6hDKO+tsXHRoG/TVYZJ9eSnBnszEYfKUS8u7Uchd+eO+x3FzhKFhetS7peQLX1f3Bxvt//E4Q6ZFSoMnDQ1PgwOp7w3XGs2LJ753IqHeygOZK/CvF6rR5mWipb3s82eUTufxuR2F0B5c4OocnFCcjpvLwbmyUtW9J8YcjYleAi6kwGltSbxyLYtZruQ42nCyfGmHw1e6w7SkWpa575Yo/aszVtRnVtpJBHjE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(66946007)(6486002)(66556008)(36756003)(66476007)(316002)(31696002)(8676002)(4326008)(6916009)(38100700002)(2906002)(86362001)(508600001)(8936002)(5660300002)(53546011)(186003)(26005)(6506007)(558084003)(6512007)(31686004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q2l5bFA0ZUh6Z014UnIrSlN6RkFqOGxkTFZTUEhuMGdOTmpZeEh6OWRjQldn?=
 =?utf-8?B?TXVHODc4bSsweHRSeGFIdjNFVDNFajJnNWFWNC9uREl5UTRBU1ZsWEJmaG1M?=
 =?utf-8?B?WUprUlhHOSt0U2hUNnZPQkNBV1RDcGh1YVZISWlYY0NHSDI5WUhEd3BoWWJ0?=
 =?utf-8?B?VkxEcW41Z0tybTVoK3NoWi8vYmRKbUNNTGdkUWpxdWx6YnJJVTVRbzNVUWc5?=
 =?utf-8?B?RmN0alpJSDZvcGpmZ2o4WE9hVkdTdGtNTVVPTmNUZXdyRnovYlE5NXdzaFRT?=
 =?utf-8?B?NGFjTTdyTTcySlhyN1NLR25vMUU0SUUzS3BVNFIxQkVkTlFPMnVrc2RHWXhx?=
 =?utf-8?B?OXJJQXRkMHh3THVvTS9WQmRDaTM3aFVOdmluZzZ0VVMyZmlGRmJSMEFpaHBK?=
 =?utf-8?B?Tk5lc2ZRR1lCZnBxU1VwSVprR2Vka2cxakJMWU5XRlNuM3d6ZUVEeHhvM0Fy?=
 =?utf-8?B?VDM2VFRteS9XVllCejVDWUVDZ0V2VkorT0tpek1kdGJsSFJUbmFLZTdUcEFO?=
 =?utf-8?B?ekJWaXB5TkFyMEF6OUdoVDhXWlUydVViRnlLVWtMRzQ4QXZ2YWRvTzdHb2hH?=
 =?utf-8?B?UlFLUm1tWXlGbDNyak5ZSmk2Mnh6Q2dVempKckR5V0lBZGwxYllSTTdVTTV0?=
 =?utf-8?B?WU5mQlh4dzFzZjRZQ1BBMnBLc1FXS2lrc3JScXZhaTBRUjVtRmJ4bFRUYTM5?=
 =?utf-8?B?MldPU3JoS2l0TWJhNGtWT2VvSk5xRHF2akVndEJNbHdkQnVhTEtpUUdNa2Ns?=
 =?utf-8?B?eURIVDhMTXd4enRPTkRadlBnSWJuV2NPVjQwUE5zd1o0TFBjWjFtNmZiemRV?=
 =?utf-8?B?TEF0dTNEVG14bUdpWVBabkkrYVZCSStWOTNYMW5JRUtSeUJSYzFBVWdSTlc1?=
 =?utf-8?B?dVBybG9lRzR6bklrKzdkL0l2NDlMY2gzN1ZMQXl0QldsZnIwVnQ3dWRITUcw?=
 =?utf-8?B?WEZ3VVhlTnRkUkdjYllQcnRnOFBNTnB0TjhEdXMzNk44MTVoeng2d3ZPMzlB?=
 =?utf-8?B?TXgzR0JFSUdiV3F2ZHo5YXRYWVVaL042WVdML0xZNm4wN0g5eUJYbUd6OVov?=
 =?utf-8?B?RUVqMC9DTjZ3NTdJSjNMSGNId285am9FMUovQkxka2g0T1kxeHQ3QlV0STNP?=
 =?utf-8?B?LytENkhXSCtlZjl1dlNNU2RaNitoaVFTWDhOUUpQLzZXVDRsKzF3Y3dWR2VZ?=
 =?utf-8?B?aEVadlhYYWd2NEJSNGFpa2QxQVJXemZOdVZxS0dQdDM3dDdmYzg3bFFGVCsx?=
 =?utf-8?B?ZzU1RnZQL0VabVpUQWNGalVJQnV5ZmZNb2plMEU3UW9lckJZY2FIWGJ4Tk9Q?=
 =?utf-8?B?M1NVT0Z2R05aM1lYZ3M4RUpRN09LakhNVVU0Ukl5KzV6ZDlqSUg0cFFQaDF2?=
 =?utf-8?B?bmJJZUJLV2FqaXg2TEpBWlpDcWZ3bTNFcmNHMGgxenh4bHkrdnU2aXBKd3pq?=
 =?utf-8?B?alZFOHNJQ2dkbW5wekprV3pPRU8vbzBua1pNcFlkZ0hTUkg4TVZQMHJwS3Ja?=
 =?utf-8?B?cUF6SCtjRFhmY1JMUnpmQzZ2SHNBK0xNemhoL2wxZ2J4NG0wUUtkTGQxU2R5?=
 =?utf-8?B?MjRKaXlWaDFsQlB4UFd4SThiSysyTDlLbHpyN21reEdzSTJ5Z2MzV0JZaGZQ?=
 =?utf-8?B?RUNOZWxQWHhNR2Y5WWFuaGVUUkRpRXlneUFaNFk4YzlkcEVybzdYVjV6UGhi?=
 =?utf-8?B?UEhvd2FVcmgrelhaY29reSttRG8xcFJpZEpBM0k3UkRQK2NlNm04TUxDWVB6?=
 =?utf-8?B?dVpMWlFjODBlRWVndlJrYlJJQyt3VjYvU3BZcExnTFd2aWJuem9DdGQ1cDJT?=
 =?utf-8?B?OEg0L2pRTXY3L05qR0hLUzVNYXg3a3k1YlJJRFg4emRDZ0RxQWRtVEZ5L1Vm?=
 =?utf-8?B?ekVXb01GcCsybU1ibXhnNGdvREl6aUdCQzE4RnoxU0E2UExsQUgvbnI4c2FM?=
 =?utf-8?B?NTdoWVZqS3A4QjNTSEFWcGlJdWxVU1VzeEdJUm5WSk5HYVlkNE5BWXFLWisv?=
 =?utf-8?B?UXFJQUZ1Z1E1b0xtaWpPcE9KL3NsdXM0UEtRTm43OUN1UDk5Z2NyT3BLUUk5?=
 =?utf-8?B?ZTJtSmRMNTJFOXlUVzhCdUFEUjB0Mk50OHVaUlEvTHU4OHFWa1loOUZUUDd4?=
 =?utf-8?B?TWwyY2hubnVoSE1nTEVkYTBYUmtoeFNEOTZRdUZaWnRSd0g4ZWF0MWdzNGRH?=
 =?utf-8?B?ZnMyb1VhUVZyK0FkM3Z1TndOd2s3dkVjTWY0ZWRaY2J0MHRINGN0QzdhV0d1?=
 =?utf-8?B?YkJMYzY5c2hiaHAzSjJkcm42cUhnbWw2NTJGOEJQN2ZjLzUvTGNXejlHbG5q?=
 =?utf-8?B?S0tEcmhFZlpLdW05RFNvY3Jrd1ZYMzcwQTlkS2lmbmxaNTFHblRkdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2ba24e1-4ea2-496b-bb02-08da1df8e73a
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 09:26:49.6858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nrF6w2X86voyJe1rF8GW9glt7657UB5NnmIn+NH4VOqR1TnAjyCWz6gPA1d6f18COD6r3n7nxFqKz/kYi5YsAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9384

On 14.04.2022 11:04, Andrew Cooper wrote:
> compile.h changes across incremental builds, but nothing in debug.c uses it.
> This avoids debug.c getting rebuilt on every incremental build.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 09:55:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 09:55:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304583.519244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1newCC-0003kf-Cu; Thu, 14 Apr 2022 09:55:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304583.519244; Thu, 14 Apr 2022 09:55:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1newCC-0003kY-9T; Thu, 14 Apr 2022 09:55:24 +0000
Received: by outflank-mailman (input) for mailman id 304583;
 Thu, 14 Apr 2022 09:55:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1newCB-0003kO-Cz; Thu, 14 Apr 2022 09:55:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1newCB-00072c-Ae; Thu, 14 Apr 2022 09:55:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1newCA-0006Cb-TA; Thu, 14 Apr 2022 09:55:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1newCA-0004nc-Sg; Thu, 14 Apr 2022 09:55:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TqBaa/ixJVzZv5Udle7p+PhZzf0HLm1bnR0VeZwZeWo=; b=EFQ0FpRI3qG1QbTNNCjFyAzWT3
	N6S3n/qJzKg9hvGZS+997ZWKebaPCmvYX9KepDxTuQYDAOhAxNEgz6sB6BH0XZ7N2TjmW10AgDZj6
	Uq2Kgm6hm050z8epkdJtBUOIIRsjX5U+mfmKVH2MzEMlA1sP+joFPAl1KcUJU6oMmM64=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169389-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169389: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 09:55:22 +0000

flight 169389 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169389/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  381 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 09:58:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 09:58:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304592.519254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1newFe-0004O7-T9; Thu, 14 Apr 2022 09:58:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304592.519254; Thu, 14 Apr 2022 09:58:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1newFe-0004O0-QA; Thu, 14 Apr 2022 09:58:58 +0000
Received: by outflank-mailman (input) for mailman id 304592;
 Thu, 14 Apr 2022 09:58:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iU0v=UY=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1newFd-0004Ns-8s
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 09:58:57 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 7e9ec656-bbd9-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 11:58:55 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 94956139F;
 Thu, 14 Apr 2022 02:58:54 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.9.215])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 81E763F5A1;
 Thu, 14 Apr 2022 02:58:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e9ec656-bbd9-11ec-8fbd-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: Make use of DT_MATCH_TIMER in make_timer_node
Date: Thu, 14 Apr 2022 11:58:43 +0200
Message-Id: <20220414095843.102305-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

DT_MATCH_TIMER stores the compatible timer ids and as such should be
used in all the places where we need to refer to them. make_timer_node
explicitly lists the same ids as the ones defined in DT_MATCH_TIMER so
make use of this macro instead.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/domain_build.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8be01678de..1472ca4972 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1672,8 +1672,7 @@ static int __init make_timer_node(const struct kernel_info *kinfo)
     void *fdt = kinfo->fdt;
     static const struct dt_device_match timer_ids[] __initconst =
     {
-        DT_MATCH_COMPATIBLE("arm,armv7-timer"),
-        DT_MATCH_COMPATIBLE("arm,armv8-timer"),
+        DT_MATCH_TIMER,
         { /* sentinel */ },
     };
     struct dt_device_node *dev;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 10:31:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 10:31:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304604.519269 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1newkL-00009R-GS; Thu, 14 Apr 2022 10:30:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304604.519269; Thu, 14 Apr 2022 10:30:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1newkL-00009K-Dc; Thu, 14 Apr 2022 10:30:41 +0000
Received: by outflank-mailman (input) for mailman id 304604;
 Thu, 14 Apr 2022 10:30:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1newkJ-00009A-PI; Thu, 14 Apr 2022 10:30:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1newkJ-0007kr-Nd; Thu, 14 Apr 2022 10:30:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1newkJ-0006xi-GW; Thu, 14 Apr 2022 10:30:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1newkJ-0005CD-G5; Thu, 14 Apr 2022 10:30:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xMadjhMrbDDMPn6HYVvMWLEV49aOWXTdTvvdTp6TGC4=; b=mI6iKR0hBsSzqRx9aKz3Gn/aB1
	4aVvDXT4u5YGBDIqTtXsvuarXTsZesIu+9duvVIglqcO8PAB8+Y4WkQRoDd3174A8LF4Ob81ZRPZb
	o5OmpUmsjaUxbry6iytdZozXnqnqm+8UlgzMIzOlxjNPaUdIS7xgNy18v1xWtDbRiip8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169390-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169390: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 10:30:39 +0000

flight 169390 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169390/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   44 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  382 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 10:59:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 10:59:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304620.519284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexCG-0002nk-SX; Thu, 14 Apr 2022 10:59:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304620.519284; Thu, 14 Apr 2022 10:59:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexCG-0002nd-Pf; Thu, 14 Apr 2022 10:59:32 +0000
Received: by outflank-mailman (input) for mailman id 304620;
 Thu, 14 Apr 2022 10:59:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nexCE-0002nT-Px; Thu, 14 Apr 2022 10:59:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nexCE-0008Ff-OE; Thu, 14 Apr 2022 10:59:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nexCE-0007a8-9S; Thu, 14 Apr 2022 10:59:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nexCE-00043v-91; Thu, 14 Apr 2022 10:59:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QJ+VhdWKV6soZ+L704szwS1mya+cE+MAH71HY9OEqio=; b=yiK6s1XvTboPMTGiuqZOqZdb6E
	/5aevBIYjaJgfzAgLm67UPD/yFHTmqhafV3Ji+yW5aeuzkwXwidssaKrQlSJPGpDVrL/akuKGu6Yc
	pb5mblemN1S9lpkfAIdzeG9Lkg/yMKA7TaQwf4DeVuV+Kr/TqVJ+uvn350AqaSapak9I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169391-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169391: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 10:59:30 +0000

flight 169391 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169391/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  383 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 11:19:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 11:19:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304630.519295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexVr-0005ML-FE; Thu, 14 Apr 2022 11:19:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304630.519295; Thu, 14 Apr 2022 11:19:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexVr-0005ME-CP; Thu, 14 Apr 2022 11:19:47 +0000
Received: by outflank-mailman (input) for mailman id 304630;
 Thu, 14 Apr 2022 11:19:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VXCz=UY=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1nexVq-0005M8-EZ
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 11:19:46 +0000
Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com
 [209.85.219.176]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c9114dda-bbe4-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 13:19:45 +0200 (CEST)
Received: by mail-yb1-f176.google.com with SMTP id p65so8763093ybp.9
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 04:19:45 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9114dda-bbe4-11ec-8fbd-03012f2f19d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=dY83H0aPEfDTdUo23MndvBRZZwuNuwRYnVKAWx3MFcc=;
        b=ekSzx/xXLgvqUpIF9mre7cp8kG+ohfbir08qF94n5B5lGR0YPSy0pISRR1aNuSEreW
         Dfig0Euc3JxdEPBmoyNqr56ydLeZEOx0yHvPJi6rutBMXc/qRRoVZbV9IDV2XLzYb4FF
         IQXRJJPqg9zgY7SMzDi+w/ooAWqHn/ExVGI/5Uvv0fchCSy6sHP89EWos1KyKRaUuVpO
         xaNkPddXzBXgW/3VoENKZCwON/D2bmmM5ZdDCcOkzl61qb0xZaEXtmRSHUzsCTalOQZE
         m5Ay4agJdI6uEqap0rwYtMSbs1QqTn9+0m63aMnfZhNMMRLDldA4VF4whsUOosjSj5SY
         SMdw==
X-Gm-Message-State: AOAM530N5pO3t4VGdhUg4cOXUZLkUcqWkluuDEMpnHnChTFI243r6KNG
	V+7DMXaRwgdj1rq11xS7HHZizkAZB/UYnpW9Zcw=
X-Google-Smtp-Source: ABdhPJyXV07maZap62IutTg/mwVDj/CfiQiLME5IwIFkAJnTY85PIrUap0WcF7eity1wAkpRDD0UVobPG71n48VtbjA=
X-Received: by 2002:a05:6902:187:b0:63d:9c95:edca with SMTP id
 t7-20020a056902018700b0063d9c95edcamr1246534ybh.81.1649935183962; Thu, 14 Apr
 2022 04:19:43 -0700 (PDT)
MIME-Version: 1.0
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <20220411233832.391817-4-dmitry.osipenko@collabora.com> <CAJZ5v0gf1J+yPW14TAdLGLGfO+-2s=r0DDP7d+Rgop3=dB0gaQ@mail.gmail.com>
 <af51d9d0-26ba-fc66-05f1-d92ef7172730@collabora.com>
In-Reply-To: <af51d9d0-26ba-fc66-05f1-d92ef7172730@collabora.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 14 Apr 2022 13:19:32 +0200
Message-ID: <CAJZ5v0jFQi1x1Fnfk04n+HTTirz19-_xW2NgJtpOYyPgVh3Afw@mail.gmail.com>
Subject: Re: [PATCH v7 03/20] reboot: Print error message if restart handler
 has duplicated priority
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, 
	Jonathan Hunter <jonathanh@nvidia.com>, Russell King <linux@armlinux.org.uk>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, 
	Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	=?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>, linux-parisc@vger.kernel.org, 
	linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>, 
	xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Thu, Apr 14, 2022 at 12:24 AM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
>
> On 4/13/22 21:48, Rafael J. Wysocki wrote:
> > On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
> > <dmitry.osipenko@collabora.com> wrote:
> >>
> >> Add sanity check which ensures that there are no two restart handlers
> >> registered using the same priority. This requirement will become mandatory
> >> once all drivers will be converted to the new API and such errors will be
> >> fixed.
> >>
> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >
> > The first two patches in the series are fine with me and there's only
> > one minor nit regarding this one (below).
> >
> >> ---
> >>  kernel/reboot.c | 15 +++++++++++++++
> >>  1 file changed, 15 insertions(+)
> >>
> >> diff --git a/kernel/reboot.c b/kernel/reboot.c
> >> index ed4e6dfb7d44..acdae4e95061 100644
> >> --- a/kernel/reboot.c
> >> +++ b/kernel/reboot.c
> >> @@ -182,6 +182,21 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
> >>   */
> >>  int register_restart_handler(struct notifier_block *nb)
> >>  {
> >> +       int ret;
> >> +
> >> +       ret = atomic_notifier_chain_register_unique_prio(&restart_handler_list, nb);
> >> +       if (ret != -EBUSY)
> >> +               return ret;
> >> +
> >> +       /*
> >> +        * Handler must have unique priority. Otherwise call order is
> >> +        * determined by registration order, which is unreliable.
> >> +        *
> >> +        * This requirement will become mandatory once all drivers
> >> +        * will be converted to use new sys-off API.
> >> +        */
> >> +       pr_err("failed to register restart handler using unique priority\n");
> >
> > I would use pr_info() here, because this is not a substantial error AFAICS.
>
> It's indeed not a substantial error so far, but it will become
> substantial later on once only unique priorities will be allowed. The
> pr_warn() could be a good compromise here, pr_info() is too mild, IMO.

Well, I'm still unconvinced about requiring all of the users of this
interface to use unique priorities.

Arguably, there are some of them who don't really care about the
ordering, so could there be an option for them to specify the lack of
care by, say, passing 0 as the priority that would be regarded as a
special case?

IOW, if you pass 0, you'll be run along the others who've also passed
0, but if you pass anything different from 0, it must be unique.  What
do you think?


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 11:46:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 11:46:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304640.519307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexvI-0000Hk-NM; Thu, 14 Apr 2022 11:46:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304640.519307; Thu, 14 Apr 2022 11:46:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexvI-0000Hd-KR; Thu, 14 Apr 2022 11:46:04 +0000
Received: by outflank-mailman (input) for mailman id 304640;
 Thu, 14 Apr 2022 11:46:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jucj=UY=gmail.com=wei.liu.xen@srs-se1.protection.inumbo.net>)
 id 1nexvH-0000HT-9m
 for xen-devel@lists.xen.org; Thu, 14 Apr 2022 11:46:03 +0000
Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com
 [209.85.128.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7437ef14-bbe8-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 13:46:01 +0200 (CEST)
Received: by mail-wm1-f42.google.com with SMTP id y21so1420643wmi.2
 for <xen-devel@lists.xen.org>; Thu, 14 Apr 2022 04:46:00 -0700 (PDT)
Received: from liuwe-devbox-debian-v2 ([51.145.34.42])
 by smtp.gmail.com with ESMTPSA id
 r9-20020a05600c320900b0038f0894d80csm1770117wmp.7.2022.04.14.04.45.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 14 Apr 2022 04:45:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7437ef14-bbe8-11ec-8fbd-03012f2f19d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=PVzyUM7iNoGJ5SSni/XTNml7nDZX+rlSKGqhlCFjxjU=;
        b=P6G2dOkM+Dibe6+EWqcnKU53oYj+aNoOISN7uREPibTvVCvpd10WERcpOWv1++0bVk
         /2YI0JtVi1H6pbSQLzuCJ3mIWBRlAgKdXic/B9sKv7xan62yWbWYvoAMR1YuPDpHtH9s
         wd4IxNp+ekHyr+9jmaMdNpKRtTMnosh4yN0AE3AqkNiyPdHSYnlQqxOwyk2aSFNaaKfA
         123nLr+gqsn21CPUJncdRTn/W8z7A8vGlgzTQD/2LGncKg5rEXJu0fraRWrCUSmcB6xk
         oVL9OQEzRAWFWP6g+5DwykaYcMTqRBUy1i0f3cwwx/baS47VNP05XC2oip7LxejEVJmz
         Gvjg==
X-Gm-Message-State: AOAM530MIxfFN5qWewKjfZQGy/NgtyauDt+8DVHRcU9Agypd+Rcks5Fa
	fVrq/JgolMeXght6bapTxZI=
X-Google-Smtp-Source: ABdhPJz6fP7TTZHLDM884OoKS4qXU+NFam69j4sX2Utqeknm4TqBmSvlL2xsheHOJQrhYsDYtSRvww==
X-Received: by 2002:a7b:c5d1:0:b0:37f:a8a3:9e17 with SMTP id n17-20020a7bc5d1000000b0037fa8a39e17mr3145450wmk.109.1649936759393;
        Thu, 14 Apr 2022 04:45:59 -0700 (PDT)
Date: Thu, 14 Apr 2022 11:45:57 +0000
From: Wei Liu <wl@xen.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: stratos-dev@op-lists.linaro.org, xen-devel@lists.xen.org,
	Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Mathieu Poirier <mathieu.poirier@linaro.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Mike Holmes <mike.holmes@linaro.org>,
	Oleksandr Tyshchenko <olekstysh@gmail.com>, Wei Liu <wl@xen.org>
Subject: Re: Virtio on Xen with Rust
Message-ID: <20220414114557.4myrs4ud4qi2hnrz@liuwe-devbox-debian-v2>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>

Hi Viresh

This is very cool.

On Thu, Apr 14, 2022 at 02:53:58PM +0530, Viresh Kumar wrote:
> +xen-devel
> 
> On 14-04-22, 14:45, Viresh Kumar wrote:
> > Hello,
> > 
> > We verified our hypervisor-agnostic Rust based vhost-user backends with Qemu
> > based setup earlier, and there was growing concern if they were truly
> > hypervisor-agnostic.
> > 
> > In order to prove that, we decided to give it a try with Xen, a type-1
> > bare-metal hypervisor.
> > 
> > We are happy to announce that we were able to make progress on that front and
> > have a working setup where we can test our existing Rust based backends, like
> > I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.
> > 
> > Key components:
> > --------------
> > 
> > - Xen: https://github.com/vireshk/xen
> > 
> >   Xen requires MMIO and device specific support in order to populate the
> >   required devices at the guest. This tree contains four patches on the top of
> >   mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C).
> > 
> > - libxen-sys: https://github.com/vireshk/libxen-sys
> > 
> >   We currently depend on the userspace tools/libraries provided by Xen, like
> >   xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates provides Rust
> >   wrappers over those calls, generated automatically with help of bindgen
> >   utility in Rust, that allow us to use the installed Xen libraries. Though we
> >   plan to replace this with Rust based "oxerun" (find below) in longer run.
> > 
> > - oxerun (WIP): https://gitlab.com/mathieupoirier/oxerun/-/tree/xen-ioctls
> > 

> >   This is Rust based implementations for Ioctl and hypercalls to Xen. This is WIP
> >   and should eventually replace "libxen-sys" crate entirely (which are C based
> >   implementation of the same).
> > 

I'm curious to learn why there is a need to replace libxen-sys with the
pure Rust implementation. Those libraries (xendevicemodel, xenevtchn,
xenforeignmemory) are very stable and battle tested. Their interfaces
are stable.

Thanks,
Wei.


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 11:47:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 11:47:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304645.519318 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexwY-0000pO-1c; Thu, 14 Apr 2022 11:47:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304645.519318; Thu, 14 Apr 2022 11:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexwX-0000pF-UZ; Thu, 14 Apr 2022 11:47:21 +0000
Received: by outflank-mailman (input) for mailman id 304645;
 Thu, 14 Apr 2022 11:47:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nexwW-0000HT-R1
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 11:47:20 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a2bf2525-bbe8-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 13:47:19 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2bf2525-bbe8-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649936839;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=CH3WALc2pdQJlbn3pdA2593xBH2ZikyRFSuJJBSgE9k=;
  b=ClVBkZloSLfB2XV/cGhqVzwObiiFZ39YnXsqnaRowqF95unwoxoSwkZN
   UaE8PWt6SY693HUMnPJPU0DmQ8jZc3zg2/ME5RrAx8KyOLaWD2n89TnTq
   pXaGO9I3yE4ZNoMI/+0h3Xr7EUpeiQfafbYsJkMKtNldEXY4leHKR8wld
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68353099
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xxZC3aPTxzDrpPvvrR2gl8FynXyQoLVcMsEvi/4bfWQNrUpw3zZRm
 jAaWzuCPPaNYWGmKIxzbduw8UsCsZKBnN5kTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1
 I9tjo2rTSMTebTxn8oETENHTSR5BPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTa2DP
 JJIOFKDajyacT1MM0gnL6kXp9qVj0jlMG0fun2a8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u10bTDwweNdef4SGY6X/qjejK9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc8YKM9Yr8wWp8O3N3gG3H3deUWBEb+Vz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODEsogz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vdB0xa5hYImS0C
 KM2he+3zMUCVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSnPHKGoNJJcAhiwLpSLcmelvG7v9WremJOcFzNwdeLqV/9U+SJR5hoq9o=
IronPort-HdrOrdr: A9a23:z5x6xaogfuQxnulyfK6EOtAaV5oneYIsimQD101hICG8cqSj+f
 xG+85rsiMc6QxhPE3I9urhBEDtex/hHP1OkOws1NWZLWrbUQKTRekIh+bfKlXbakvDH4VmtJ
 uIHZIQNDSJNykZsfrH
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="68353099"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH 0/3] x86/build: Clean up 32bit boot objects
Date: Thu, 14 Apr 2022 12:47:05 +0100
Message-ID: <20220414114708.4788-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Removes several unnecessary steps from the build.

Andrew Cooper (3):
  x86/build: Rework binary conversion for boot/{cmdline,reloc}.c
  x86/build: Don't convert boot/{cmdline,head}.bin back to .S
  x86/build: Clean up boot/Makefile

 xen/arch/x86/boot/Makefile    | 39 +++++++++++------------------
 xen/arch/x86/boot/build32.lds | 58 +++++++++++++++++++------------------------
 xen/arch/x86/boot/head.S      | 10 ++++++--
 3 files changed, 47 insertions(+), 60 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 11:47:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 11:47:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304646.519329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexwZ-00015Y-8v; Thu, 14 Apr 2022 11:47:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304646.519329; Thu, 14 Apr 2022 11:47:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexwZ-00015R-5W; Thu, 14 Apr 2022 11:47:23 +0000
Received: by outflank-mailman (input) for mailman id 304646;
 Thu, 14 Apr 2022 11:47:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nexwX-0000HT-R1
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 11:47:21 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a35e2510-bbe8-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 13:47:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a35e2510-bbe8-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649936840;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=0s1yCBflD3p2q66QNUN1vJ9nlrel+PCFiTRjaDEozt8=;
  b=T+WRhVlZtU0wpD4hPfsk4Vn9w23aA/V+riqBYqR/7Yas3c55iBHI3AGG
   +kw3RY1PWAV7zZNMGzLTF5Sw4pSIMY4vMb4jbtCu2JkASj7hRjra92VdS
   tCKuMp6n3Rm+6ZkQkRkZbOQ5Rfg6JAuF7DEvpI8FIi3loKy2cLxYNoGb+
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68829284
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0Ks8dq4J9j4PxqPoJoan2gxRtDTHchMFZxGqfqrLsTDasY5as4F+v
 mAbDG+Ob/yMZDPwLo9+YN+x9kkOu8TUz9RhQQpurHxgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTgX1vU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSRYFsiNKjnsd4dXklBNRlaHrZA6Zv+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RJOWA+NkScC/FJEgsrDZgUp8K3ulXAQydHlF6vp/M6xXeGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyFvaS1D6E+XKEnfLUkGXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MSySjRwaDRyC+jBmVUVxh5TP89st4SfGl/v
 rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWuoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg
 JTis5LPhAzpJcvT/BFhuM1XQNmUCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vdB0xa5hYImS0C
 KM2he+3zMUCVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmRvon95mNvAi92
 48Zb6NmPT0EC7agCsQWmKZORW03wY8TXMmo8J0GKrTeemKL2ggJUpfs/F/oQKQ994w9qwsC1
 ivVtpNwoLYnuUD6FA==
IronPort-HdrOrdr: A9a23:xLfyg6OVQ0I0hcBcTvujsMiBIKoaSvp037Eqv3oRdfUzSL3hqy
 nOpoVj6faaskdzZJhNo7+90ey7MBfhHP1OkO8s1NWZLWvbUQKTRekIh+aP/9SjIVyYygc079
 YaT0EUMr3N5DZB4/oSmDPIduod/A==
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="68829284"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH 3/3] x86/build: Clean up boot/Makefile
Date: Thu, 14 Apr 2022 12:47:08 +0100
Message-ID: <20220414114708.4788-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220414114708.4788-1-andrew.cooper3@citrix.com>
References: <20220414114708.4788-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

There are no .S intermediate files, so rework in terms of head-bin-objs.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>

I'm slightly -1 on this, because

  head-bin-objs := $(addprefix $(obj)/,$(head-bin-objs))

is substantial obfuscation which I'd prefer to bin.

Anthony: Why does dropping the targets += line interfere with incremental
builds?  With it gone, *.bin are regenerated unconditionally, but I can't see
what would cause that, nor why the normal dependencies on head.o don't work.
---
 xen/arch/x86/boot/Makefile | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
index 294ac2418583..527f3e393037 100644
--- a/xen/arch/x86/boot/Makefile
+++ b/xen/arch/x86/boot/Makefile
@@ -1,16 +1,17 @@
 obj-bin-y += head.o
-head-srcs := cmdline.S reloc.S
 
-nocov-y += $(head-srcs:.S=.o)
-noubsan-y += $(head-srcs:.S=.o)
-targets += $(head-srcs:.S=.o)
+head-bin-objs := cmdline.o reloc.o
 
-head-srcs := $(addprefix $(obj)/, $(head-srcs))
+nocov-y += $(head-bin-objs)
+noubsan-y += $(head-bin-objs)
+targets += $(head-bin-objs)
+
+head-bin-objs := $(addprefix $(obj)/,$(head-bin-objs))
 
 # For .incbin - add $(obj) to the include path and add the dependencies
 # manually as they're not included in .d
 $(obj)/head.o: AFLAGS-y += -Wa$(comma)-I$(obj)
-$(obj)/head.o: $(head-srcs:.S=.bin)
+$(obj)/head.o: $(head-bin-objs:.o=.bin)
 
 CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS))
 $(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS))
@@ -18,8 +19,8 @@ CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float
 CFLAGS_x86_32 += -I$(srctree)/include
 
 # override for 32bit binaries
-$(head-srcs:.S=.o): CFLAGS_stack_boundary :=
-$(head-srcs:.S=.o): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic
+$(head-bin-objs): CFLAGS_stack_boundary :=
+$(head-bin-objs): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic
 
 %.bin: %.lnk
 	$(OBJCOPY) -j .text -O binary $< $@
@@ -27,4 +28,4 @@ $(head-srcs:.S=.o): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic
 %.lnk: %.o $(src)/build32.lds
 	$(LD) $(subst x86_64,i386,$(LDFLAGS_DIRECT)) -N -T $(filter %.lds,$^) -o $@ $<
 
-clean-files := cmdline.S reloc.S *.lnk *.bin
+clean-files := *.lnk *.bin
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 11:47:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 11:47:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304647.519335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexwZ-00019Q-L1; Thu, 14 Apr 2022 11:47:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304647.519335; Thu, 14 Apr 2022 11:47:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexwZ-00018Q-E7; Thu, 14 Apr 2022 11:47:23 +0000
Received: by outflank-mailman (input) for mailman id 304647;
 Thu, 14 Apr 2022 11:47:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nexwY-0000HT-RA
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 11:47:22 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a45c59e1-bbe8-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 13:47:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a45c59e1-bbe8-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649936840;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=+qQkIV3HBke5CTXRiQlZD/OE4VAVlxsLpbZwbQuQSMI=;
  b=etLfSynhN03yGbY9uIPgHJZQJ2puM2qnUmpcPmupTeQRyzxbciyNvsvj
   Yy3rqdMOPHHNSQggM2evJxgI1+WOnc/FvnhuzqKiz/b+mTUOCnCJMR+vn
   Oum8foclr3dir3M7TU17kTWK01yehk2OcZuzSC1pix1EDAgayjWsFfr2B
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68353100
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vODzhq1sn9LzIsIItPbD5dZxkn2cJEfYwER7XKvMYLTBsI5bpzVRn
 WQaXD+CM/zZNDSjc4xyPYzipEwBsZWHzt82TwY+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIx3YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1E7peObjgJJ5bilcBNVhAIAhxVMapvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiOP
 JdCMGI3BPjGSxtwIAwoT7kYoMOXiXXuch9mhwLKtJNitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRIDsXKdiewjqt6W+3i6nEmiaTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4GrYx1iay6rPvzQu9Vm0NHi98Q9AhnZpjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoetcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HwgbQ4xawZRGp8crVnl
 CJV8yR5xLpQZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBY5aJ5dJ2OyO
 xK7VeZtCHl7ZirCgUhfOdzZNijX5fK4SYSNug78M7KinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWO3CJqt9CcQpXdRDWx/ne8qRqSwJKGSI+cElJNhMb6elJl1BN90iNqtr1w
 w==
IronPort-HdrOrdr: A9a23:YdKSUaPGy+HEEcBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3gqy
 nOpoV86faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrZ
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="68353100"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH 2/3] x86/build: Don't convert boot/{cmdline,head}.bin back to .S
Date: Thu, 14 Apr 2022 12:47:07 +0100
Message-ID: <20220414114708.4788-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220414114708.4788-1-andrew.cooper3@citrix.com>
References: <20220414114708.4788-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

There's no point wasting time converting binaries back to asm source.  Just
use .incbin directly.  Explain in head.S what these binaries are.

Also, align the blobs.  While there's very little static data in the blobs,
they should have at least 4 byte alignment.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>

Cleanup to $(head-srcs) deferred to the subsequent patch to make the change
legible.
---
 xen/arch/x86/boot/Makefile |  9 ++++-----
 xen/arch/x86/boot/head.S   | 10 ++++++++--
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
index 09d1f9f75394..294ac2418583 100644
--- a/xen/arch/x86/boot/Makefile
+++ b/xen/arch/x86/boot/Makefile
@@ -7,7 +7,10 @@ targets += $(head-srcs:.S=.o)
 
 head-srcs := $(addprefix $(obj)/, $(head-srcs))
 
-$(obj)/head.o: $(head-srcs)
+# For .incbin - add $(obj) to the include path and add the dependencies
+# manually as they're not included in .d
+$(obj)/head.o: AFLAGS-y += -Wa$(comma)-I$(obj)
+$(obj)/head.o: $(head-srcs:.S=.bin)
 
 CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS))
 $(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS))
@@ -18,10 +21,6 @@ CFLAGS_x86_32 += -I$(srctree)/include
 $(head-srcs:.S=.o): CFLAGS_stack_boundary :=
 $(head-srcs:.S=.o): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic
 
-$(head-srcs): %.S: %.bin
-	(od -v -t x $< | tr -s ' ' | awk 'NR > 1 {print s} {s=$$0}' | \
-	sed 's/ /,0x/g' | sed 's/,0x$$//' | sed 's/^[0-9]*,/ .long /') >$@
-
 %.bin: %.lnk
 	$(OBJCOPY) -j .text -O binary $< $@
 
diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
index 3db47197b841..0fb7dd3029f2 100644
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -777,11 +777,17 @@ trampoline_setup:
         /* Jump into the relocated trampoline. */
         lret
 
+        /*
+         * cmdline and reloc are written in C, and linked to be 32bit PIC with
+         * entrypoints at 0 and using the stdcall convention.
+         */
+        ALIGN
 cmdline_parse_early:
-#include "cmdline.S"
+        .incbin "cmdline.bin"
 
+        ALIGN
 reloc:
-#include "reloc.S"
+        .incbin "reloc.bin"
 
 ENTRY(trampoline_start)
 #include "trampoline.S"
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 11:47:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 11:47:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304648.519352 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexwb-0001ak-1k; Thu, 14 Apr 2022 11:47:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304648.519352; Thu, 14 Apr 2022 11:47:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nexwa-0001YU-Qr; Thu, 14 Apr 2022 11:47:24 +0000
Received: by outflank-mailman (input) for mailman id 304648;
 Thu, 14 Apr 2022 11:47:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nexwZ-0000HT-RL
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 11:47:23 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4aed2f9-bbe8-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 13:47:21 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4aed2f9-bbe8-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649936841;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=8Uae8bFBeN10HyzNO9f3vkE192c+nPR4Tmdy4ORjMWo=;
  b=QyJKBNfETaZFBx9x6flcsKxBzets1VirHoH5WuarCncq1qpo94KkGg7T
   ibb9bMLZ0Gjt57Hh/gbzoCdmQjLwT7d9tsUhWgkl8/bNsBWkk0rQz/A2M
   flskMcKFzp/h9BwRcqQo0+ZZViLBJyCTG5qA6ubsa+fkthgebE87DqCiA
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68829285
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3qtVSaxbzqvftlcWBCt6t+c7xirEfRIJ4+MujC+fZmUNrF6WrkVSm
 jRKD27Xb//ZYDeheYgjPI2xo0IE78SAydZiSlM5/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpllLXsQg0sFYT2mOlNSj9gNwJlO7xiweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AN
 5pDOGA/MXwsZTVXFXY3U80+w9yRuSL6fz1GpWyRnfYotj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO8wTtAqHz4H92QaUVnEidhpic9o3kPZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WvQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW
 lBeyqByC8hUU/mweNSlGrllIV1T296LMSfHnXlkFIQ7+jKm9haLJN4MsWEkfB43bp1fJFcFh
 XM/XysLtfe/21PwM8dKj3+ZUZx2ncAM6/y4PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2WZJgYepcWHOUcPsD5b+JyC2Mt
 Y432z2ikE4EDoUTo0D/rOYuELz9BSFiW8un+pANK7brz8gPMDhJNsI9CIgJI+RN95m5XM+Rl
 p1hcie0EGbCuEA=
IronPort-HdrOrdr: A9a23:bW9B1KxCe+7/0kMB+zqiKrPwFr1zdoMgy1knxilNoRw8SK2lfq
 eV7YwmPH7P+U8ssR4b6LO90cW7Lk80sKQFhbX5Xo3SOjUO2lHYTr2KhLGKq1aLdkHDH6xmpM
 BdmsBFeabN5DNB7foSjjPXLz9Z+qjjzJyV
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="68829285"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH 1/3] x86/build: Rework binary conversion for boot/{cmdline,reloc}.c
Date: Thu, 14 Apr 2022 12:47:06 +0100
Message-ID: <20220414114708.4788-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220414114708.4788-1-andrew.cooper3@citrix.com>
References: <20220414114708.4788-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

There is no need to opencode .got.plt size check; it can be done with linker
asserts instead.  Extend the checking to all dynamic linkage sections, and
drop the $(OBJDUMP) pass.

Furthermore, instead of removing .got.plt specifically, take only .text when
converting to a flat binary.  This makes the process invariant of .text's
position relative to the start of the binary, which avoids needing to discard
all sections, and removes the need to work around sections that certain
linkers are unhappy discarding.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
---
 xen/arch/x86/boot/Makefile    | 13 +---------
 xen/arch/x86/boot/build32.lds | 58 +++++++++++++++++++------------------------
 2 files changed, 26 insertions(+), 45 deletions(-)

diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
index ca8001c72b23..09d1f9f75394 100644
--- a/xen/arch/x86/boot/Makefile
+++ b/xen/arch/x86/boot/Makefile
@@ -22,19 +22,8 @@ $(head-srcs): %.S: %.bin
 	(od -v -t x $< | tr -s ' ' | awk 'NR > 1 {print s} {s=$$0}' | \
 	sed 's/ /,0x/g' | sed 's/,0x$$//' | sed 's/^[0-9]*,/ .long /') >$@
 
-# Drop .got.plt during conversion to plain binary format.
-# Please check build32.lds for more details.
 %.bin: %.lnk
-	$(OBJDUMP) -h $< | sed -n '/[0-9]/{s,00*,0,g;p;}' | \
-		while read idx name sz rest; do \
-			case "$$name" in \
-			.got.plt) \
-				test $$sz != 0c || continue; \
-				echo "Error: non-empty $$name: 0x$$sz" >&2; \
-				exit $$(expr $$idx + 1);; \
-			esac; \
-		done
-	$(OBJCOPY) -O binary -R .got.plt $< $@
+	$(OBJCOPY) -j .text -O binary $< $@
 
 %.lnk: %.o $(src)/build32.lds
 	$(LD) $(subst x86_64,i386,$(LDFLAGS_DIRECT)) -N -T $(filter %.lds,$^) -o $@ $<
diff --git a/xen/arch/x86/boot/build32.lds b/xen/arch/x86/boot/build32.lds
index 1ab941879312..d8fb9170ca40 100644
--- a/xen/arch/x86/boot/build32.lds
+++ b/xen/arch/x86/boot/build32.lds
@@ -31,44 +31,36 @@ SECTIONS
         *(.bss.*)
   }
 
+  /* Dynamic linkage sections.  Collected simply so we can check they're empty. */
+  .got : {
+        *(.got)
+  }
   .got.plt : {
-        /*
-         * PIC/PIE executable contains .got.plt section even if it is not linked
-         * with dynamic libraries. In such case it is just placeholder for
-         * _GLOBAL_OFFSET_TABLE_ symbol and .PLT0. .PLT0 is filled by dynamic
-         * linker and our code is not supposed to be loaded by dynamic linker.
-         * So, from our point of view .PLT0 is unused. This means that there is
-         * pretty good chance that we can safely drop .got.plt as a whole here.
-         * Sadly this is not true. _GLOBAL_OFFSET_TABLE_ is used as a reference
-         * for relative addressing (and only for that thing) and ld complains if
-         * we remove .got.plt section here because it cannot find required symbol.
-         * However, _GLOBAL_OFFSET_TABLE_ is no longer needed in final output.
-         * So, drop .got.plt section during conversion to plain binary format.
-         *
-         * Please check build32.mk for more details.
-         */
         *(.got.plt)
   }
-
-  /*
-   * Discarding .shstrtab is not supported by LLD (LLVM LD) and will trigger an
-   * error. Also keep the rest of the control sections to match GNU LD behavior.
-   */
-  .shstrtab : {
-        *(.shstrtab)
+  .igot.plt : {
+        *(.igot.plt)
   }
-  .strtab : {
-        *(.strtab)
+  .iplt : {
+        *(.iplt)
   }
-  .symtab : {
-        *(.symtab)
+  .plt : {
+        *(.plt)
   }
-
-  /DISCARD/ : {
-        /*
-         * Discard everything else, to prevent linkers from putting
-         * orphaned sections ahead of .text, which needs to be first.
-         */
-        *(*)
+  .rela : {
+        *(.rela.*)
   }
 }
+
+ASSERT(SIZEOF(.got) == 0,         ".got non-empty")
+/*
+ * At least GNU ld 2.30 and earlier fail to discard the generic part of
+ * .got.plt when no actual entries were allocated. Permit this case alongside
+ * the section being empty.
+ */
+ASSERT(SIZEOF(.got.plt) == 0 ||
+       SIZEOF(.got.plt) == 3 * 4, "unexpected .got.plt size")
+ASSERT(SIZEOF(.igot.plt) == 0,    ".igot.plt non-empty")
+ASSERT(SIZEOF(.iplt) == 0,        ".iplt non-empty")
+ASSERT(SIZEOF(.plt) == 0,         ".plt non-empty")
+ASSERT(SIZEOF(.rela) == 0,        "leftover relocations")
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 11:58:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 11:58:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304671.519361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ney7E-0004Aw-69; Thu, 14 Apr 2022 11:58:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304671.519361; Thu, 14 Apr 2022 11:58:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ney7E-0004Ap-39; Thu, 14 Apr 2022 11:58:24 +0000
Received: by outflank-mailman (input) for mailman id 304671;
 Thu, 14 Apr 2022 11:58:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ney7C-0004Af-Tf; Thu, 14 Apr 2022 11:58:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ney7C-0000ql-Qz; Thu, 14 Apr 2022 11:58:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ney7C-0000Pp-DO; Thu, 14 Apr 2022 11:58:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ney7C-00010J-Cx; Thu, 14 Apr 2022 11:58:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bSS7rIr3CH3YfMW5uk6l7YHHVI0XR5YIqPG7yloDaF8=; b=5KrpGFo50AfVUCdGftfA9k+s72
	8wX78cncpF+PFFytihac1kOb7920j1Ir6eqtqZQlk56II7Zl0ThrONGTHqM3U2DkG3GSpXpJWey8e
	mCVYPD8gu5q15e30Zj9ZfI1dqQgfXVzx2rP64DH84iIG5sjiAZfjqyFpPnvzDm5I2kC4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169392-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169392: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 11:58:22 +0000

flight 169392 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169392/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  384 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 12:07:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 12:07:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304688.519373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyFv-0005wC-D3; Thu, 14 Apr 2022 12:07:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304688.519373; Thu, 14 Apr 2022 12:07:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyFv-0005w5-9u; Thu, 14 Apr 2022 12:07:23 +0000
Received: by outflank-mailman (input) for mailman id 304688;
 Thu, 14 Apr 2022 12:07:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1neyFt-0005vz-LH
 for xen-devel@lists.xen.org; Thu, 14 Apr 2022 12:07:21 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6cc2a718-bbeb-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 14:07:19 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cc2a718-bbeb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649938039;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=KmiJwyoJOj/Acz81QFt4uoGVDQVACfz8D5fVFYKwPfg=;
  b=IyGFn//GZ1TJeitC20/wu444ugTIBhsDyC3AzW/YtEdnHouSVXJRlXtk
   jU6yW2/yCCrfhaKbCLRHLLbTyJAGfvvfgw0gf4/vUSCaaVUyLFJI94JTO
   E0cIWclcl9QLM3Z78vTWhbR5KIu5mevvs6ogx3BttykIC3Q9a3sqcrgI1
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68354730
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:bqZgsqwxisRDw3S6s+Z6t+dUwSrEfRIJ4+MujC+fZmUNrF6WrkUCz
 zZJDW7QOPzYYGHxL4gjYIi2/BhQuJfSydc3TFM5+SAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpllqHvdxkAD6L3pvkUDQRCGHo5Oaka9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AN
 5FENWU0NHwsZTVxOnYFLL4anN6RhyPGVi1m722b/oketj27IAtZj+G2bYu9lsaxbdtUmE2Vo
 H6A8Hn4Hg0dKPSbyDyM6HXqgfXA9Qv+UZ4SFbClsOZtgUeSy3Y7DBwQXEG85/K+jyaWXtNcJ
 goU/S4roLMa8E2tR8P6GRqirxastRcGV91dO+Yz8g2Kx+zf5APxLm8AQz1adM09tOc5QDUr0
 hmCmNaBLSdzvbOcT3Xb7audpz62PSkTLEcSZCsFSxtD6N7myKktjwjCVdYlE7Owh8fdHTD2y
 iqN6i8kiN07ksojx6i9u1fdjFqEvYTTRxIy/UDbU3yN6Rs8YI++e5fu7Vnd5OxHaoGDQTGpt
 XwJi46U4eYIAJylkC2LSf8KWraz6J6tIDDaxFJiAZQl3zCs4GK4O5Bd5nd5PkgBDyofUWa3O
 gmJ41oXvcINeivxBUNqX26vI+cXkpb+POXqbc7JZ4RTeJMqMwuDoC47MCZ8wFvRuEQrlKg+P
 7KSfsCtEWsWBMxb8damewsO+eR1n35jnAs/Ubi+lk36iuTGOBZ5XJ9faDOzgvYFALRoSek/2
 /JWLIO0xhpWS4USiQGHoNdIfTjmwZXWbK0aSvC7lMbeemKK+0l7Upc9JI/NnaQ/zsy5cc+So
 BmAtrdwkgaXuJE+AVzihopfQL3uR41jinkwIDYhO12ls1B6P9r+vP1HLsVrJuJ6nACG8RKSZ
 6NUEylnKq4RIgkrBhxHNcWtxGCcXEnDaf2y09qNP2FkIs8Iq/3h8d74ZAr/nBTi/QLs3fbSV
 4aIj1uBKbJaHlwKJJ+PNJqHkgPg1VBAybkadxaZfbFulLDErdECx9rZ1aRsfanh6Hzrm1On6
 uphKU5B+7Kc8tNvrYGhaGLth97BLtaS13FyRgHzxb23KTPb7iykx4pBW/yPZjfTSCX//6DKW
 Amf56iU3CEv9LqSj7dBLg==
IronPort-HdrOrdr: A9a23:AQf41q6wOiXNpT8XwwPXwMzXdLJyesId70hD6qkXc20zTiX4rb
 HLoB1/73TJYVkqNE3I9eruBEDiexPhHPxOj7X5VI3KNGOKhILCFuBfxLqn7zr8GzDvss5xvJ
 0QFpSW0eeAbmSSW/yKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="68354730"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vynw71iQchQxbG4KSRbi97GCUzSmI8joHsJ8n3N/bleS47BBIVZRFVR/CdnrkLNCkDqML3yaB49ulvv+NQ41EH2CnP2WrVNIBw0jnG5FL1Wqbjrkiv6zkzQ6isXjpqV1OPCHD5FvLnoy2PpiLApWgB/JoTsW7BWrfX2CzH73hXdr8pPxQwstBDLKg64HqM2YSZTMgHOs89Cu3Lx8jbCgDXq7G5nY7OS5zzKvEgGgnOnzBA4OrX9KPoXnIZlKblR/Tdk5nYPozx8BoFRg3O8KtPkvFDVA/CRjsWS0fX7apw6JYycpNWhIw1tGanzZE134+8+K8X2QrywoA9S2I1g8Uw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KmiJwyoJOj/Acz81QFt4uoGVDQVACfz8D5fVFYKwPfg=;
 b=QDTCmUGXhw6ihZzoj57nP48BQFVs1RueTnzr9PRJ7dZmrqiubhzbI8zpY0p32D7Vhi94ghhQhxruB9fsWcN1DqPm+x8t+rIkrrVK1973sjxO9JgLMqbqvzzDBuqtHvaYRQvujjmOfJbyEpQdnJzbBx11f5ogdmOT2BiY0qKGhiOmOa0FQcTiJfiQL7TSoj6veb+2fqHMpf+OhjPhlaOA3lCA9nyJ+IJAmZNQKVGFFxfSI+AZ+A37S+A/e53C4gbknIZTKNMO3L5NAS2klTVARBN6Sc0yEpWrFR2cjJqzjE8UOpM78gC+6TZoktYyfEygXIWNLhKbqzoxe7c0YOXijg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KmiJwyoJOj/Acz81QFt4uoGVDQVACfz8D5fVFYKwPfg=;
 b=TO2CKPGFaqidQk7DwpexIuLh2MFkcvFitvVVem7wYMsOdjMzG+qpnHpL+S0DXCVjzHFJufd0TU3ojVKvoEcxXhgCCgGFGQyfqaiYejg4j2vElTV7gYa+Do+YoIE3kAA5eaH8lh/SWqk0xvam3UvEJx2V4RG7/Y3C7zveBJQR39Y=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Wei Liu <wl@xen.org>, Viresh Kumar <viresh.kumar@linaro.org>
CC: "stratos-dev@op-lists.linaro.org" <stratos-dev@op-lists.linaro.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	=?utf-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Stefano Stabellini
	<stefano.stabellini@xilinx.com>, Mathieu Poirier
	<mathieu.poirier@linaro.com>, Vincent Guittot <vincent.guittot@linaro.org>,
	Mike Holmes <mike.holmes@linaro.org>, Oleksandr Tyshchenko
	<olekstysh@gmail.com>, Doug Goldstein <cardoe@cardoe.com>
Subject: Re: Virtio on Xen with Rust
Thread-Topic: Virtio on Xen with Rust
Thread-Index: AQHYT+F3VJeAyJ3qtUWdcwuAq4aFpazvSqWAgAAF7gA=
Date: Thu, 14 Apr 2022 12:07:10 +0000
Message-ID: <2a735486-a464-3997-642a-3b0660b11b9e@citrix.com>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>
 <20220414114557.4myrs4ud4qi2hnrz@liuwe-devbox-debian-v2>
In-Reply-To: <20220414114557.4myrs4ud4qi2hnrz@liuwe-devbox-debian-v2>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0c1ab664-787a-4419-6643-08da1e0f4e51
x-ms-traffictypediagnostic: MN2PR03MB5070:EE_
x-microsoft-antispam-prvs: <MN2PR03MB50704E91003BB40DA57F4209BAEF9@MN2PR03MB5070.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: skQIHsY9izbfinBfH2LkhbQs/4eU3ly/qFA0FFjxLwxU1fooGVtSp8PZn40AcTBlVjIbK+f3PYx7GZRY55zfkgjHSPQvbgUvbdyGVyX6cXeqGLudZILiI7T09iPSohfOHl+vbL/vgvOgclfQ49jm+UfVujtz2hxp4IYwUcLZQtnP80LOygUYOVorqYAC1Gzy5+yI9P9ud152e4mKl1Vtct7/ywC72OToz+BX38/HJTE1MJM6IHUEujL2NNs3GDFNm71b0BcranPihNjvnlxuVVPwkuguKI3J/tFTXo8Emr5TZXkFYf1SNwzhBfGipaOSX4t2dHDuTirn//SEHQZUh1ganepAIGePNUnTA9vNOJJiM6hBi7NTH0ODaixhDh/eyhfg4PENpPb45xe9PhCZtkJlLDkWWhHRcfytaA1SK06uecvaJAWqh7k6xXw8P03OKldUldFzQUr1EpW3IGCxe9vjPhwyaSfc/VS27kX/krdpsA82ET4kE3LS+Cy2aR+1Rv2zN1aJU98X+sZPiy8eT0lPO0fmzdCAgqxFCJPwf8Ei4unGrMBxKOYpEKSbuYfdZBkz+TOnCr3ADDo4cAQYDAupyXfO1VMPKtnpkf8oEZQVIYJLwNLCv11xfTlGdYUEbfA77ZQevQP0oaLtliZ8dUQtIWtrBysSeKM2zSXn3C506K1ODeILwe49oiXRbFjyjSEAp9yR5a/1JD3ee+MFpAhmUX3a6Xf+KmFFITzjq0as4paaWwY/A4hodc7/iWj3E1+gpqlIlczSiwhYJ7n7hm9l8jcHlGz3oGHHf2BerQuv8ci9K1RhDxrzYs5mOjgbCf5y3GGwVTeBZXBjbt6dFk6yyDZ0mUtexyLZ/PrH8o2lFof/6qRYWMWoBP+MZD9cY7j0/0b5gt7/CzHjumcZUQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(31696002)(122000001)(82960400001)(38070700005)(38100700002)(8936002)(6486002)(966005)(508600001)(5660300002)(7416002)(316002)(54906003)(110136005)(66946007)(8676002)(64756008)(4326008)(66446008)(66476007)(66556008)(71200400001)(76116006)(91956017)(83380400001)(186003)(26005)(6512007)(6506007)(2906002)(53546011)(2616005)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d2FNcGd2R3ZpdlVubWFndjVjU2pGNFA0SGFaQXFSMTlzeFdyUkxyaHErWWhM?=
 =?utf-8?B?SjM1Y3RzUTVEbmYxV3dtdmxYNlhzcTViRmNZNkRoeXV2MFUwK1BSNFJVWUFJ?=
 =?utf-8?B?SVdzVVU0WlBvZzBGV1pyVDNEWExVeGNBT1hLZ2FjbkQyZkhGUFdYdWthWm44?=
 =?utf-8?B?WVVTR1Rrbm1maUNBRDFxcHJDQndrT2lJZXZxT1RnYmZQRTdjT2FPbkM4ZGdL?=
 =?utf-8?B?b3o4UiszeUZPWmowY1JNUnhtL1BvM2lSRmRiQitzZmg4RkRSOUFBKy9FdGdj?=
 =?utf-8?B?dkZzWjVUSEdTcENNbWl2enB2MjF3YTZZMmdmS29IOEhYSGxZZXRCOVVyVGh3?=
 =?utf-8?B?SkhHd1lHaXdremI2QTEyVnJSbThCdWZTTXUxZ2d2YTFCUnFFd080L2pvSzNl?=
 =?utf-8?B?ZlhiUWgzdUg2cExscTM5QjE0bnZlbWJ1QU1GRFpJbDlDK0lGMTlqWTFJcDN1?=
 =?utf-8?B?NFZBcUFLZWN4d1AvaU04cGdoRjM2V1I5bUF2bzk4Y25lOFBxWll4Y0FmM3Zh?=
 =?utf-8?B?R0hpTnR2MnV4SGxZZFhNTkNNc3ZDOW9XNHZ6SWxpZmFmekZEQ3llZjlKaWEx?=
 =?utf-8?B?RGY1WEZTZjVoUkdpVGhXaHFkYXZmeTFQVnA5d1FOTHdBd1FISjdkVjR6RWdX?=
 =?utf-8?B?bzF3U28wandMZ1FFaXo5a1J1c2FJMzM0RFFWZGNVV1hxc1BEU3BNYUIycmlv?=
 =?utf-8?B?VG1mWUUrMy9RWHhTK0VwRk9oRjVVM3IyTDdROTNaWnc5OFo3cXFOWUllZm1Y?=
 =?utf-8?B?VXlEUUIxUDdZMFo0d3UyRTM3K0w4bFEvdWJZZUNsdHQvLyszQ0NuU1FITzZ5?=
 =?utf-8?B?NHZiUU1ROXRIdzZ6NUhWNW9kalNFMlg5eGprZDF1YmtsRGkzcVArZTBVRzJa?=
 =?utf-8?B?YjdGdnZJYXh6aTJNbG80czFqbzZCUy9aYXNrVEJaZGlvUm1pdGJVeStGeGM1?=
 =?utf-8?B?UEVNTUprSVpEemUzSnNjTjl1bWcyb3hDb0FEUEtLQzZmS0wzQmdzNXBuNE96?=
 =?utf-8?B?eFZVSnlIc0VsVDJueGhtUURxR3BFSUs5R1VrWWl4UFVFbGhjeGM2bHMzWng1?=
 =?utf-8?B?OWtLZFhlQnZPb1VCZkk4MUdDUEZlTDV2Tkt3UkFGUTNWdWdXekVmbHBZRHB1?=
 =?utf-8?B?emJuU280TEQ1UDVlSkUxeFpuaFNVYzhYRk1YRS8waDM3QVJiRURZemJtbWNH?=
 =?utf-8?B?T3liTWZFVkcvMFhpMFZUZ24zYmU4TklGcTVDMEx3ZUtwS0prRXpaNW9TREVo?=
 =?utf-8?B?b2tUd2QybEd0eDMrZkpKWGI1S3ZBVi9kc0o3N0VHOGEyK2VzemxZYU5NNUlO?=
 =?utf-8?B?RCtHbUVxbGNtOWswbFBlRDhEZCtJYTArbDNSOGNwMTlHKy9xRlNnL0w3OFlx?=
 =?utf-8?B?YTFMZkhTUGFHWmp3bFFlMEo2UHZTOE5CNmY0VVV1TGVnMXdMVDlabklJSHBj?=
 =?utf-8?B?Zmg4Z2JwVTIvU1ptNFBPWVdtaTA5UHk1SW5GUHg1U1d6RHBHcW1ENjFuMHRZ?=
 =?utf-8?B?SlR0c1BBK3orK3c5eDJUVHJCNkFiU2dtR2pSUWtaV09ucGtJMjBuc2QyRUlt?=
 =?utf-8?B?aUVabFlmeFZQU1ArUUM2L2FWQ0hrUnAvNks0ZnB6cGZSV205dmRGRlY2dkdE?=
 =?utf-8?B?NmJOSmU3ejBaZUwvRm03cml1VTZZM0h0dEM1bWRuMnhiYlIwenczRktrTTgz?=
 =?utf-8?B?Zkh5SThhVVFoSEhrSEhyTHJaSXJPak1pSnBmQUdWc3ljUEdtYXRBa0w1SWN5?=
 =?utf-8?B?RWVKVUtGZzNZV28zY3pPbWhlTmJQZncrYUZOOFFlSENsYXZ5dUFqRHJ5djVI?=
 =?utf-8?B?OXRaUEQyTC9vQWFHbDBhb1RYSGNBcDF5S1FJRkI2VTRvTGkyN1B1MEk4aEhY?=
 =?utf-8?B?bXI3czVHWHc2aThOTGFPUGpBdDgvemZPMXRrSTlvL1VsMFpKdU9XdTl3cjIy?=
 =?utf-8?B?cmE2bVZ4RE9KNDlRSnJwbndGek43bkRDT3pqQXoxZ2lPMDlacXpsL0Vod0Yy?=
 =?utf-8?B?dWZQZmlpZTNXbWlaOEx2UUZ3bVlFdW11UXdZM2g2ZWtUakM0Tm0vdkRxdnd6?=
 =?utf-8?B?WjIxOVNSV0FyUVVXcHBUMGcrdW1GM0pDb1RsNCs1cWtmZnZjckxYWnRJZnRj?=
 =?utf-8?B?SFRBdW5GRldFcDZoeklSMVF3UW40VDZ1M2N2ZnY2NXFWeUxPQWdWOER5czFU?=
 =?utf-8?B?NXFPS1FFM3lLOXQ2VVI3Y3RpQmpDdjJibmFDZ05XMkxCeEtpQjdqc0JQcmt1?=
 =?utf-8?B?OElTTlpQa0V2eDBiUVhiK1p0UFkvZ2dtUDJMNTJTQWl1Qk9yWUdVL3Rka3FR?=
 =?utf-8?B?QTVwUHZvZXd5dEt0SlRHWU1DSlNDUzhXZC9pS3I4QVlXMDNkczJSUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DF8E202673C5EB4CBEBA6E67B9C0D1FE@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c1ab664-787a-4419-6643-08da1e0f4e51
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 12:07:11.0209
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RjVq9eKmH4RgYAAu6pfSTGO1sg58Nqw63HdWtM0+SlI4MSbWjsEy5RADwu7nA2HDG/56bQKTbx6x+cY6ZSNRUvqWXqR6HBeQSywt976VZKQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5070
X-OriginatorOrg: citrix.com

T24gMTQvMDQvMjAyMiAxMjo0NSwgV2VpIExpdSB3cm90ZToNCj4gSGkgVmlyZXNoDQo+DQo+IFRo
aXMgaXMgdmVyeSBjb29sLg0KPg0KPiBPbiBUaHUsIEFwciAxNCwgMjAyMiBhdCAwMjo1Mzo1OFBN
ICswNTMwLCBWaXJlc2ggS3VtYXIgd3JvdGU6DQo+PiAreGVuLWRldmVsDQo+Pg0KPj4gT24gMTQt
MDQtMjIsIDE0OjQ1LCBWaXJlc2ggS3VtYXIgd3JvdGU6DQo+Pj4gSGVsbG8sDQo+Pj4NCj4+PiBX
ZSB2ZXJpZmllZCBvdXIgaHlwZXJ2aXNvci1hZ25vc3RpYyBSdXN0IGJhc2VkIHZob3N0LXVzZXIg
YmFja2VuZHMgd2l0aCBRZW11DQo+Pj4gYmFzZWQgc2V0dXAgZWFybGllciwgYW5kIHRoZXJlIHdh
cyBncm93aW5nIGNvbmNlcm4gaWYgdGhleSB3ZXJlIHRydWx5DQo+Pj4gaHlwZXJ2aXNvci1hZ25v
c3RpYy4NCj4+Pg0KPj4+IEluIG9yZGVyIHRvIHByb3ZlIHRoYXQsIHdlIGRlY2lkZWQgdG8gZ2l2
ZSBpdCBhIHRyeSB3aXRoIFhlbiwgYSB0eXBlLTENCj4+PiBiYXJlLW1ldGFsIGh5cGVydmlzb3Iu
DQo+Pj4NCj4+PiBXZSBhcmUgaGFwcHkgdG8gYW5ub3VuY2UgdGhhdCB3ZSB3ZXJlIGFibGUgdG8g
bWFrZSBwcm9ncmVzcyBvbiB0aGF0IGZyb250IGFuZA0KPj4+IGhhdmUgYSB3b3JraW5nIHNldHVw
IHdoZXJlIHdlIGNhbiB0ZXN0IG91ciBleGlzdGluZyBSdXN0IGJhc2VkIGJhY2tlbmRzLCBsaWtl
DQo+Pj4gSTJDLCBHUElPLCBSTkcgKHRob3VnaCBvbmx5IEkyQyBpcyB0ZXN0ZWQgYXMgb2Ygbm93
KSBvdmVyIFhlbi4NCj4+Pg0KPj4+IEtleSBjb21wb25lbnRzOg0KPj4+IC0tLS0tLS0tLS0tLS0t
DQo+Pj4NCj4+PiAtIFhlbjogaHR0cHM6Ly9naXRodWIuY29tL3ZpcmVzaGsveGVuDQo+Pj4NCj4+
PiAgIFhlbiByZXF1aXJlcyBNTUlPIGFuZCBkZXZpY2Ugc3BlY2lmaWMgc3VwcG9ydCBpbiBvcmRl
ciB0byBwb3B1bGF0ZSB0aGUNCj4+PiAgIHJlcXVpcmVkIGRldmljZXMgYXQgdGhlIGd1ZXN0LiBU
aGlzIHRyZWUgY29udGFpbnMgZm91ciBwYXRjaGVzIG9uIHRoZSB0b3Agb2YNCj4+PiAgIG1haW5s
aW5lIFhlbiwgdHdvIGZyb20gT2xla3NhbmRyIChtbWlvL2Rpc2spIGFuZCB0d28gZnJvbSBtZSAo
STJDKS4NCj4+Pg0KPj4+IC0gbGlieGVuLXN5czogaHR0cHM6Ly9naXRodWIuY29tL3ZpcmVzaGsv
bGlieGVuLXN5cw0KPj4+DQo+Pj4gICBXZSBjdXJyZW50bHkgZGVwZW5kIG9uIHRoZSB1c2Vyc3Bh
Y2UgdG9vbHMvbGlicmFyaWVzIHByb3ZpZGVkIGJ5IFhlbiwgbGlrZQ0KPj4+ICAgeGVuZGV2aWNl
bW9kZWwsIHhlbmV2dGNobiwgeGVuZm9yZWlnbm1lbW9yeSwgZXRjLiBUaGlzIGNyYXRlcyBwcm92
aWRlcyBSdXN0DQo+Pj4gICB3cmFwcGVycyBvdmVyIHRob3NlIGNhbGxzLCBnZW5lcmF0ZWQgYXV0
b21hdGljYWxseSB3aXRoIGhlbHAgb2YgYmluZGdlbg0KPj4+ICAgdXRpbGl0eSBpbiBSdXN0LCB0
aGF0IGFsbG93IHVzIHRvIHVzZSB0aGUgaW5zdGFsbGVkIFhlbiBsaWJyYXJpZXMuIFRob3VnaCB3
ZQ0KPj4+ICAgcGxhbiB0byByZXBsYWNlIHRoaXMgd2l0aCBSdXN0IGJhc2VkICJveGVydW4iIChm
aW5kIGJlbG93KSBpbiBsb25nZXIgcnVuLg0KPj4+DQo+Pj4gLSBveGVydW4gKFdJUCk6IGh0dHBz
Oi8vZ2l0bGFiLmNvbS9tYXRoaWV1cG9pcmllci9veGVydW4vLS90cmVlL3hlbi1pb2N0bHMNCj4+
Pg0KPj4+ICAgVGhpcyBpcyBSdXN0IGJhc2VkIGltcGxlbWVudGF0aW9ucyBmb3IgSW9jdGwgYW5k
IGh5cGVyY2FsbHMgdG8gWGVuLiBUaGlzIGlzIFdJUA0KPj4+ICAgYW5kIHNob3VsZCBldmVudHVh
bGx5IHJlcGxhY2UgImxpYnhlbi1zeXMiIGNyYXRlIGVudGlyZWx5ICh3aGljaCBhcmUgQyBiYXNl
ZA0KPj4+ICAgaW1wbGVtZW50YXRpb24gb2YgdGhlIHNhbWUpLg0KPj4+DQo+IEknbSBjdXJpb3Vz
IHRvIGxlYXJuIHdoeSB0aGVyZSBpcyBhIG5lZWQgdG8gcmVwbGFjZSBsaWJ4ZW4tc3lzIHdpdGgg
dGhlDQo+IHB1cmUgUnVzdCBpbXBsZW1lbnRhdGlvbi4gVGhvc2UgbGlicmFyaWVzICh4ZW5kZXZp
Y2Vtb2RlbCwgeGVuZXZ0Y2huLA0KPiB4ZW5mb3JlaWdubWVtb3J5KSBhcmUgdmVyeSBzdGFibGUg
YW5kIGJhdHRsZSB0ZXN0ZWQuIFRoZWlyIGludGVyZmFjZXMNCj4gYXJlIHN0YWJsZS4NCg0KVmVy
eSBlYXN5LsKgIFRoZSBsaWJyYXJ5IEFQSXMgYXJlIG1lc3MgZXZlbiBpZiB0aGV5IGFyZSB0ZWNo
bmljYWxseQ0Kc3RhYmxlLCBhbmQgdmlvbGF0ZSB2YXJpb3VzIGNvbW1vbmx5LWFncmVlZCBydWxl
cyBvZiBiZWluZyBhIGxpYmFyeSBzdWNoDQphcyBub3QgbWVzc2luZyB3aXRoIHN0ZG91dC9zdGRl
cnIgYmVoaW5kIHRoZSBhcHBsaWNhdGlvbnMgYmFjaywgYW5kDQpldmVyeXRoaW5nIGdldHMgbW9y
ZSBzaW1wbGUgd2hlbiB5b3UgcmVtb3ZlIGFuIHVubmVjZXNzYXJ5IGxldmVsIG9mIEMNCmluZGly
ZWN0aW9uLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 12:30:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 12:30:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304695.519384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neycc-0000ff-6b; Thu, 14 Apr 2022 12:30:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304695.519384; Thu, 14 Apr 2022 12:30:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neycc-0000fY-3g; Thu, 14 Apr 2022 12:30:50 +0000
Received: by outflank-mailman (input) for mailman id 304695;
 Thu, 14 Apr 2022 12:30:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neycb-0000fO-6a; Thu, 14 Apr 2022 12:30:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neycb-0001Qj-2I; Thu, 14 Apr 2022 12:30:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1neyca-000189-My; Thu, 14 Apr 2022 12:30:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1neyca-0008Uv-MX; Thu, 14 Apr 2022 12:30:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XT18XkNxnTycZlM/Ho7ESsPKdYSsod4e7dZvx9IxMuU=; b=Flss1Lw0F2/aLGCRqx2Z3CKv1w
	qc+7hz2TqfuVTZK4C+oZoVZJzZZ/E98QKgtPpAvEepnCd7j0+RLwA2EXa6z8iZlU7ZE5VRfAIJQW/
	Ns8o6hGudTtqn5PmjrAhww7CTThWqk7dnQRFa5uDHI1mPSmrMvxCzN3ZApnquL7rN2Vg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169393-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169393: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 12:30:48 +0000

flight 169393 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169393/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  385 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 12:40:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 12:40:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304704.519395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyls-0002AQ-3l; Thu, 14 Apr 2022 12:40:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304704.519395; Thu, 14 Apr 2022 12:40:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neylr-0002AJ-VI; Thu, 14 Apr 2022 12:40:23 +0000
Received: by outflank-mailman (input) for mailman id 304704;
 Thu, 14 Apr 2022 12:40:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f0xO=UY=citrix.com=prvs=09619e58f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1neylq-0002AD-Kn
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 12:40:22 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0b19d0c4-bbf0-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 14:40:21 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b19d0c4-bbf0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649940021;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=X/brzmAE/DpTLNxow1schrZSCxklrnjQ/FytNaW7ZTQ=;
  b=gc6vpSxwSeD54EmDfgLTUURJGPVkaplZUHfjJVU1NyWKTrJjz3qZOReQ
   ukTJgR1IhJHi2KImjvJCnnCgmaDugRqoT3W75O8hzuDOIXfz2RzTlpVT1
   8+R9VWdLcv6+qBEMobxnzLkaDMDlU2RVfRp/zJdfwGUfdDEMpv9+C0+0O
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68951733
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RVo8VK55wJQeuY3Icfjd2wxRtC/HchMFZxGqfqrLsTDasY5as4F+v
 mdNUTrSM6nfZmT1Ko10a9jj80sCu5bUzYRqTlA6rihjHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTgX1vU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSwRBkGB6zqndgAVh5HQzBlMvNv95XYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQTaeDP
 pVCMlKDajzMbRcWI2o3BqsCp+eJp3zzMDxxlnma8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc9pdDcID6SeI9rfR5BnJF3MLEBdOQsNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODEsogz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vdB0xa5hYImS0C
 KM2he+3zMUCVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSnPHKGoNJJcAhiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSSvxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:uoGx16DoERTMVp/lHehCsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHP9OkPMs1NKZPTUO11HYSb2KgbGSpwEIXheOitK1tp
 0QApSWaueAdWSS5PySiGLTfqdCsbu6GeKT9JzjJh9WPH9Xgspbnn5E42igYypLrF4sP+tHKH
 PQ3LsOmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZVbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczIgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxenEPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tpt+CVQpAZEyHsHceg22w
 31CNUZqFhwdL5lUUtcPpZ2fSLlMB2FffrzWFjiVGgPUpt3f07wlw==
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="68951733"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H14Qr6BO+J/wBzDi69dO53Gl1uP26BtEE1ZELPCCTSHuFGyPFJXo9OW5MVjnVwntKFhakDD9TpOPdMFBPMvVH6g15ZGKEuWYp8+wm7bZUbdoD8c6YyPStOt6vY/1HDUANfLAtxkmanhoAXmnnND4y5VT0ir1XU+Xw0Ezr2Ox4di2p8r2AXKJlJ6XbMjxBq5EcsiJkFwyjAAEritdRE3Oj7iqaSdbI0ygkWGt06BsuiiGZHABoTFmlxCDfTNN8j4JitldcTrleWfGv6anusoobG9G593y11OV0LwkgGyzmR9FKqYiErBl7lYYZmZdBpu7uUAVCIS+MOhg3jtXO0LS/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zzXlpB20U4qtIGwny9tQ/KffctDeZlpyzaQOOpVpUKI=;
 b=KHBI3dLjXoB33jSQeVxH7hmTQ2XTiXF+be8nmDdAknfuLCmel2HSklpZguo3l9mgYkgljKTgK43NNjf/yw5gRhFkVf4MC8TSOjpM/Hm6SPEjRhytB6ix3gY+GVrrIZyqTJX59xtZImzhgkyTrkzKQZUJd4ghZoJxjS/Ol9FxqFusj5FypyENxiSt/7XSrbDCF+9ltYyxgvCDG7aHcnXB4lKYSDxi9qMTzBqe5HliSOps2cu906RtOO1efin8gVmaAZPA118RcBtCo+5vcxNWLX9pNnq3oe6SOS6+IHXj0lsqD89ZB8L03n0SkPxXkuc4Vyh/YQPUANh3Zx1zmB7SGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zzXlpB20U4qtIGwny9tQ/KffctDeZlpyzaQOOpVpUKI=;
 b=R8IBCZcwEgwKITeQIer4W2w0tEysIUeUot+eeXJoRaHdu9C2ZQzTB1gfPBiZs8GmIguep700XWar2lpviXPGqCXWRdrQiMzpz8Fq51N8aIz27rQSBkF39BLjIWFASznh7Gp/loHXKzgTY0N0TrmVZ/XsYI+Hm+q65/uDkNhiN/c=
Date: Thu, 14 Apr 2022 14:40:08 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] x86: improve .debug_line contents for assembly
 sources
Message-ID: <YlgWKGmR+u41zSsw@Air-de-Roger>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
X-ClientProxiedBy: LO2P123CA0082.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:138::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 13b24931-ccca-4c1c-80c1-08da1e13ebbe
X-MS-TrafficTypeDiagnostic: CY1PR03MB2171:EE_
X-Microsoft-Antispam-PRVS: <CY1PR03MB2171C126514DD3C6FF9707F68FEF9@CY1PR03MB2171.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5pGzExSKZJ+ngZHl5KOfvz+K23RlTJAmX55p6VksmwqdGC6QlNoxF/cb5pImNbBne/b9wPcT5/hIxfh66EQ9VKjBy1HkukHSoWlILwVOXhbo83bRTbaxje3Pa8y5gA/Pv61+TqUEM4EtBjwLug9dyGueLZ09jzbyVw3MX0b25rPcNUyI2PVgi5GcsEnu8cxU51mGrux3O6aG0qJBEMX8brI96khx+MYyJcYu1ELdIWt+K6nR/7BmbXpu6q5AHsONzdJcQySmGquPoJKi7Qwleyqmkc1+09pjhLDHUYILYq5LRhTUzTXrnFE1DsPzsHOK3oErclpgbhWb+Nbh8JNciTSA6BPTwNj1NX4472n8Hh9oRjtkGGkzFwyJOfg3s9QjMTYZNEwgTtOZ5fMFlbERWn97BG8nJEDP5RheXVhJKdjFNYIm6CMisYdTuxCVQ5rX+6A8nHGkqkjLAzuGlb3luhhnZI0x3fWje8V8aSYueVOwAdheU2l5lF3ynRVC+KnDT8emjalOg1xwUXjbZQmEmTa5sIQMxcLiV9wRkXMBjUKAJDT7r/Q58pcCrVh3lbCgRFAyI3NXur0vRAJDghPNWZ0NBEvpHckKauVTGaSxoDjzI7ZcAJsXNzKxL1Erkt1yXDveaR+rOJnr7K1lEmUPSAMSotmrzT42BJ/kq2yphwOOO7dYmemYv/9VJDYxoUiq5/mEOMlnE8nRuwL5AL8NHWZRb72N17C9dfShZOBXI4eRCxOxjUxmuMWM0V7B+NnMYfJXUW4SY7NQ8ibjfzv93oTdDz2XgdThw/aDeG+FXJtE0iBrJAD7A2fbWtXVSSPWJOZd9udBWAeYHpCzOoE2tvCc0ibt+ex7AXY62Yvx3Mc=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(5660300002)(26005)(6506007)(6512007)(6666004)(4326008)(9686003)(2906002)(66946007)(66556008)(66476007)(966005)(6486002)(508600001)(85182001)(86362001)(54906003)(316002)(6916009)(83380400001)(38100700002)(8936002)(186003)(33716001)(82960400001)(142923001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mk5pa08relJSOG04RDZZRUtmcnByMGVkckRNVmg4QmdDZkFrRHY5TWcwL3VC?=
 =?utf-8?B?OTdKVHF1bEZ4L3c5R1NnZVdOb1M1VlNIbGtscVlGUTZHcjZnaDAwelJFUzBU?=
 =?utf-8?B?N09WVTFrWTFMZzZVVFhSWXVaUkF1eEQrdCsxN2ZQSThqaGl3dFNvaHR0Y1dG?=
 =?utf-8?B?L0RJL1dzVElFNVNoWVJLTE03UEhNczA4VG5HRU8yeHVCekVXMUNQZEFNVGpW?=
 =?utf-8?B?dmg4eWxmVGdkZDJ2T0owUjNueTNVUjM5S1FVNXlXRFVQbjh5SXZjMWplbnp4?=
 =?utf-8?B?b0h4UGNaaW1mWWNEekw4SU5TSjdTWUl4SUlLOVFRTjZrVUxFTGtQQnRNYTNw?=
 =?utf-8?B?b3JaUGJISFRpRWpPdHVQQ3Uycm4vTEcvcW10dU9ycDJnMHB6MEI2TWVCNitI?=
 =?utf-8?B?MnBYeHVpdEVhZFF3dEhyU0ZDYjFBWS9hWXovcXFyWW9iQlpkTzFnTDRuRUY2?=
 =?utf-8?B?T3BOOXp6TTdqT2F1eVl1WU8xdGE5YVhVYVY2R01QK29reDBWME0yQXJtc1lC?=
 =?utf-8?B?dUdVdmNjK0syTFlIS2FRZmJCWWdIMFBmbHVsUjZMUVdQdS95MnVEVERnVi90?=
 =?utf-8?B?TEIxZE5CdU95OWZ5Qmo4OHprdHdzblZKeUNQU3RUZ3BnYWw2RUdFQ3RETFQ1?=
 =?utf-8?B?R0V3akVESEUxdEI5UElKcVRGN0ozL3hLaGhVY0FUZnBoWk5xS0ljUERDeUtp?=
 =?utf-8?B?ZmlHelR5SXdIM0VwRTNUZ0hLbHZ4bWxzUXhCaHpRSmttQVh1M2wybnZ2QXJa?=
 =?utf-8?B?ZTkyYVIwYzkzM05jQ1NPQWJOQjY1R0hUTUlhSTZjdFR3UzVVNldpTnZya3BS?=
 =?utf-8?B?K2JlR1NiN2xnVDAwNUlZNHdJNnN3VUxyTXFzU1craWRRR25DUWVPWTVGbnB2?=
 =?utf-8?B?UlEvUjR6WW9XbnoyR0tzWk5DeTAvcFlSOC85a1d0eHVxYk5FKzFYVmpGUFhI?=
 =?utf-8?B?NjRkTmd4SFBvUFh2Sm1nYkpKaDhTZXBkTnRPNXZEakptRVJGSkdWUVgrQjVq?=
 =?utf-8?B?c3pIYUxEbGFQbko5N0laUTl2akpXNFp5NjdGcEdIajRaWE02ZnRZN1ZpVHRT?=
 =?utf-8?B?L285WS91dEt6NHlNeEducEZtdFRjdlJpeld4VzdZeDBOa0VmNnZ3TmQ4S3Fs?=
 =?utf-8?B?TWE1bmxWZGFTNW9BMTd3K2cvLzlUdnBPNDZNeWdSNkQ3MXJWOVJyRSsyd3FM?=
 =?utf-8?B?Z1RnbHZoanlPaXRXYlk0aEJFbVVVVDB2UGVVMWhRVEpEMjdyRFBjUHFMWStJ?=
 =?utf-8?B?VFowZGo2T3NoVmRvK05Pd2R1VjRqdnZyU3pWUXNmRitWdWJCbURObmxxbElo?=
 =?utf-8?B?cEs0d3RkakF4K3NCM0x2dlYySnNjTWlUeEZBUWdDNkdhN0VjQmsySkpHa2Jx?=
 =?utf-8?B?OU5nM3REbDNIN2VCL1kyRWgyQmh0NUdIU0tNNkx0cjROSDFMZXUzQ3g2cDBh?=
 =?utf-8?B?bVYrSHIvOWQ1NkNQemF0bGdidFhVa3RhNUw2UnhiVDdSajhxNCt5cmdwTk9C?=
 =?utf-8?B?THJaaDM5VVk4UGxrWnU0enhPZEtUd2ZScE1rbTNVQmVKVDFPZVpLUXdtUnJ0?=
 =?utf-8?B?Q0Qwd2pISW03c0JxOUdnTFNMcWlTWlVWYkVRN0F1RlBWdk1WUi92ajNIcVNS?=
 =?utf-8?B?RjFVa2lkQStRZHNYN0c1RFJic0FDUFZMZTJ1WEMxYlJkeS82Vi9xUTVBT1Jy?=
 =?utf-8?B?Uzc1ZmhZN2V2RG5Bc3ZqOEF5VVdkRkp2eWd4d2hBL21SZy9CZTdGTnNRMFJG?=
 =?utf-8?B?MmIyRTBLY1pyS1hFODI4TGZJUDVjUWY5dHRoNE4wTk8rWG95aU9LenJ6dXFB?=
 =?utf-8?B?VXRtM29yQVdqQ2dQVFZkTzZRR3l5N1hQUFRoSWpFYlJPRm1kOFliTkZpajhh?=
 =?utf-8?B?bjR3M214MGZyWjhBWHM5SHhSaGgyaFVjV1I4TlV2UnJBUG9xaCtOaklJVXA5?=
 =?utf-8?B?dlZXRUhXT0NvYnNyc2VYb2tJbVJyeHVQTDJuZ0pZT2RBNkoyZFhKdE5FVDlJ?=
 =?utf-8?B?ckVrR1RxU0pkWkI1RFcrbFF3eUprZWdoQ21ES0NJVUErRWMybVBBV0syOEps?=
 =?utf-8?B?Q2RGODIwY0JIbUF0WWpMUWJmc1Q4RVpjVXJiQ2tVcmNUMGZ5WGJycXNmWkZL?=
 =?utf-8?B?L3F5aTR4RW9sOWdKODdydk5qVVJCOFdpQzYyaXkrOWs2WkduakU5WDBYR3NI?=
 =?utf-8?B?ZWQzWUx4S3ljRE1UVEYxNngzbSt2QlhwOGd2eHAxSStmM0t4dE1YRTRXc0tN?=
 =?utf-8?B?L0ZZNm0xaVNWUWgwQmxmRkNadDJrL1JwSDNOWWhOSUtOeU9DQ3RuUGZnWm4w?=
 =?utf-8?B?SStjaldyYldncWhyVUFtTWRDc2NWMHpXRHYyY1RMZ0pRNWwrdFE0ZTNDWVNM?=
 =?utf-8?Q?imOmT/R5rvNWbN/w=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13b24931-ccca-4c1c-80c1-08da1e13ebbe
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 12:40:13.7188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sSzu10fUehjzMiix2GNHJVheFqBTFNnum39KLEUSi7VwLTHRs2wHl+8CcNgFT9sbqI7k+WySW+M9F/KNXJO9uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2171
X-OriginatorOrg: citrix.com

On Tue, Apr 12, 2022 at 12:27:34PM +0200, Jan Beulich wrote:
> While future gas versions will allow line number information to be
> generated for all instances of .irp and alike [1][2], the same isn't
> true (nor immediately intended) for .macro [3]. Hence macros, when they
> do more than just invoke another macro or issue an individual insn, want
> to have .line directives (in header files also .file ones) in place.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> [1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
> [2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
> [3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
> ---
> Using .file has the perhaps undesirable side effect of generating a fair
> amount of (all identical) STT_FILE entries in the symbol table. We also
> can't use the supposedly assembler-internal (and hence undocumented)
> .appfile anymore, as it was removed [4]. Note that .linefile (also
> internal/undocumented) as well as the "# <line> <file>" constructs the
> compiler emits, leading to .linefile insertion by the assembler, aren't
> of use anyway as these are processed and purged when processing .macro
> [3].
> 
> [4] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=c39e89c3aaa3a6790f85e80f2da5022bc4bce38b
> 
> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
> @@ -24,6 +24,8 @@
>  #include <asm/msr-index.h>
>  #include <asm/spec_ctrl.h>
>  
> +#define FILE_AND_LINE .file __FILE__; .line __LINE__

Seeing as this seems to get added to all macros below, I guess you did
consider (and discarded) introducing a preprocessor macro do to the
asm macro definitons:

#define DECLARE_MACRO(n, ...) \
.macro n __VA_ARGS__ \
    .file __FILE__; .line __LINE__

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 12:50:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 12:50:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304712.519406 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyv4-000302-2z; Thu, 14 Apr 2022 12:49:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304712.519406; Thu, 14 Apr 2022 12:49:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyv3-0002zv-W7; Thu, 14 Apr 2022 12:49:53 +0000
Received: by outflank-mailman (input) for mailman id 304712;
 Thu, 14 Apr 2022 12:49:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1neyv2-0002zo-1p
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 12:49:52 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d7abc09-bbf1-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 14:49:48 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d7abc09-bbf1-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649940588;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=goVjhoezmMM/lzaEE1nqYIA3qkDPeua07aTbsfAYscM=;
  b=XB0BXLIZDsMWPwzhJHGpEgcQEuDMu99eXRX3XbGYATORiGA1iBkRDPn+
   wrGSOzUkEtJZ2Tj6H6fMD0vPtvTKFdFXYA/TN++VypmkL515wcXiXDkDP
   hBdRTt8DOMzVdiyRqlkoiBJk/G+9ertMMX6smG2qfhJpwJ5sALtY5YB0T
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68972264
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:GC9rnqM/Y6zpTvvvrR23l8FynXyQoLVcMsEvi/4bfWQNrUoi1jYCz
 2cYXW7VafbcYjP8fY9wOYni/E0Cu8LRnNNhSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 cQVp7CcUgsTLqziw9ofAhAIAiNEMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTaeBP
 ZBHNVKDajzqOxJMFno5K6l9v/+L3nPhbR19uVWa8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc4dBS/8WxBqB8LrVzV2nBDkNHi9DUtNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODEsogz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vdB0xa5hYImS0C
 KM2he+3zMUCVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSnPHKGoNJJcAhiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSevxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:kuMamKH+OBAZVnNVpLqFRpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVp2RvnhNFICPoqTMuftW7dySWVxeBZnMffKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIUurIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxZLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1SsV
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGIFq/QpF4t1H2mxa1O
 UkkC1QePibLEmhOF1dlCGdnjUIFgxeskMKh2Xo2UcL6vaJOw7SQ/Ax+76xNCGpsXbI9esMoJ
 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MciFW5uYd499RjBmcga+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zo93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkf8IzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehTKYd0s8LAo23FUgMyPeFOwC1zxdLkHqbrUn8ki
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="68972264"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W+r02wADecD2uPDd7TmH3GpLYbqcGfCD3kBwwVrV4blDgTV4A/8djAdJTiAQZbPlDgznAzToT6vYx5PgZb0/rtWzm0dCABkjvR7JPYfsgAW9V0t6Ux+sv1ZtR60y6DbrNHnbXwhA82eiFjMud3Ev6uEEkYOtXdYxXr0AaRuBZCuJvMWKII/DiA+zfCUUXR0rjDoXyI0lYveg1eJ2g1wk90anRSBW/GWzUIGExrN1kpLNqNhKokcL2eo7z0InB2++/j3ebtJedsP41rG1MEvBtdHjMpQyFh+AUuGpNtLtwcvRXH7KvRi2mOzBGpmpLiVh6U9DJpBPmNBjtTEOZdrj8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=goVjhoezmMM/lzaEE1nqYIA3qkDPeua07aTbsfAYscM=;
 b=by5p1NFIV9c03UEzX07C6tQId2CG8irp20b4pOFXewBfIxAYBBvwb1pi4TblqPcFnewQAOC9mDAkBUVCJtDyvQK4SPYUu1xmcwifuzE2GZJZw1QdUFLoeyni8tqaBjDaAEt30oZaWpo4WwSZN5gCkNh3aU9bLLNitU8Z8qZx9nD/ttRSl6NsS610uZue4ATWh5Vmt4r3o14Ji+GmXs/Ry92qj38eqTkqgeEkflZp0aZHBUlBJK3mJqkJIu72uZRqbQOV2evUBLrL1/y3dP+kVRZDD7J4paDBQpSOIeJGSBw+z06QO4qzGMfuj8WBc7Bad8LokC8n+TKWCANZHyGLuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=goVjhoezmMM/lzaEE1nqYIA3qkDPeua07aTbsfAYscM=;
 b=PlccM82GJpune9d9GJdRZVmDL2feWt+9hFb16K9wesjBawiIp4mX5gmeg/DItL+7OFcDg5e6LtbD/zlm4L1dZcqsRJA8OR/WUOucilpumAxcb3kAmHe+6rk8QaKjLZ4nphgWHSPkcuSXq+5NLeiQA/bFTlvzWLsYQUohRoCgrHY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 2/2] x86: annotate entry points with type and size
Thread-Topic: [PATCH 2/2] x86: annotate entry points with type and size
Thread-Index: AQHYTlgbnWM+kMHK9kCx34LnXQv6tqzvX4gA
Date: Thu, 14 Apr 2022 12:49:43 +0000
Message-ID: <22df182a-762d-711e-5191-d4b628904085@citrix.com>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <531ab7f7-ce5a-12b2-e7e7-528c26f9ff7f@suse.com>
In-Reply-To: <531ab7f7-ce5a-12b2-e7e7-528c26f9ff7f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9ed15123-3dad-4fe7-8a19-08da1e153f58
x-ms-traffictypediagnostic: BYAPR03MB3766:EE_
x-microsoft-antispam-prvs: <BYAPR03MB37662527C974A7DB313E3225BAEF9@BYAPR03MB3766.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QAauubV2qo9BWr+EhAZ6zq6ImY/IdgGJBQut7QO1fyk6e/J8rvAL75fUSLhDnZD7uoWGHa+Ai0+cgpHE0G1FyKiM3iB0Lr14T446ix0ta1PLtq57FMcEqO4xx4rSjRfPWhD/eQzhkXNAMd4D9UJbthCf0/6o5f4zL3bM0aTI64qZIjN9VJeePPFYCEH5uNVgvRcrb1PVHKPPR9+Q6tIHtCYFbuGF/gRcmOZtOh4HZU9+a8icv0XaH19gudC4s4EF2c5XZPl8iTYiSZOU/ol8eOK5xTW3h5Q6wj98dnyXlG7MrwlV5rVrOBZu+6lYRtHuyyEOaLFUXctioGbSl39EphWFBKfFAS/sneXM8lY4A6ekwM2bT4o/flTFMjkHrszZAveKcP60pAGDYOQ50kFFPVxoP2RaRgg+H/uR5+1ZzpYEY6d8A6JwFrpOJCpSQiT2CcPnYAm2lXmp/BJHvORM1OO5Op6E8QtksEhGUXYUR+XIvlB+ox2mYlirXTLhSWZzQmAWcnyl0waqOE0jl7SFHDflFMrhzaVVNgFgC3Nt5+F5/ThSG3Pxt9fJpAsMxf5aFRxcLOeJL1vQXAMIbZw/U28llC2HjFB87te/Aqfdu/wiTsNYCRvTM59rVy1W4Id5szdhJq79Jf8GuEAQWoZ4VzqwPUqNNjB0ySfrQ+5tMTOZuIYah2iIIcU38ReRMBSi/3uE/R7PQw5EKqfW1Ib7FQzSs6fLC3GjMv5s+YGlWnKVHUZGSk5xwumumpHxD0tCpFjUjm0rD4Jar5Fm/Cq8+pnZieqDDadpgfrkFYz035SVx0IKMOmVtN9xkYDlhc2484H5up7jMxQKfYf5dFN8ngkn1057m31JZyWWQWPoY2c=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(8936002)(38070700005)(66556008)(4326008)(6486002)(66446008)(64756008)(8676002)(66476007)(4744005)(316002)(82960400001)(38100700002)(110136005)(53546011)(6512007)(54906003)(2906002)(186003)(26005)(6506007)(122000001)(5660300002)(508600001)(2616005)(107886003)(71200400001)(76116006)(91956017)(66946007)(86362001)(31686004)(36756003)(966005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bFdzOG82am5lRU56SkUrNlNJM1JhQkcxRFJLajJwYmRFV3c5OUVKek5CWWRx?=
 =?utf-8?B?ZS9GVmdYdUpNajJzWkJGSC9iZ25wWk1RNGd6aTNYNEtXb20xRWx0QkkwZnRO?=
 =?utf-8?B?ZCtOWUk2Ym5PT3NDa1N1VGQvQTJJRWxWc2tzSTN6eEE1VUJFWGRaYXZGZ2Nt?=
 =?utf-8?B?VytlQ1RaZFJ2b0Y5TVJlY1grbFMzMVdqdllhVzgxUHJKaDdkNUVIajFmVysw?=
 =?utf-8?B?dEhiWEpna2Y0VlhZaGlUV3VnYjlLWDZ5cFFFV2lwUzU0clJTOFp5T1VZQ1pC?=
 =?utf-8?B?eUFmaUxLelYremtuZ3BUWSs3SXdyTzdZNzNDZ2lYMlN2bU9zRndwZ3k0MFVT?=
 =?utf-8?B?cGZOc3l2OUdkODg4Um9yOEhJTWplSVFqTU8xWXM0ellTNzRwOGdINDhBeER2?=
 =?utf-8?B?VDlacU82azBRTmg3a3NmZDdSSVRzY1MvRGxLMjZ3cTQrUTF0dlp6WmxuVU0v?=
 =?utf-8?B?cVpDS1Y4eVBPWGZkRk9nbUZ0cjNMc2pIQU91NUtqWU5YUElJY3FsYVF1YjdU?=
 =?utf-8?B?RSttcGdKNS9oZG5RK2hzMXBTOCthZnpQT1k0UzI4UjRpMjF5bFZaUW5WYXVN?=
 =?utf-8?B?MzJ6UEhnSGd0U3ZTbzJrd1JEemszLyt2Z2VtK2VZemN1eGRwMTJudlFsS3J4?=
 =?utf-8?B?SEVxRzJOdWlqTGVIeDdUcThLZjJWZDdEL1ZyZTc4US9Pa2t2NFI2Qi9kRHNV?=
 =?utf-8?B?U1NwQ21ZSS9DaDJGRWljY2lPYWxXdlZ4bjNZZXhKTHpkMDFocGN4NjdyR1pI?=
 =?utf-8?B?T1VobzdTaHdQTnUwbVNTOVJnY1cyaFZTNnUyOTRwMEs4d2tUV05XRGJha3FO?=
 =?utf-8?B?N1BxK2VaUXdwczVkRTYydjNMUU5yazR5YU5hWGQ2aW1nZWpkVTVXUEV0MHJO?=
 =?utf-8?B?U0FNREhOT1lGWWV0U3lTWllvZkVBenJJeHJRYk1yYmpMckczSWdxbElkcEty?=
 =?utf-8?B?N1h4QVVURHdyMGhHcVpWZytoOWo5WTRZNjUwQVFqKzc3M0tFb25zV0R0RWJ3?=
 =?utf-8?B?VXdUeFY0a3pocm9tMXNDWDlYaEdURVF0MWpLNjZKcFJxVkNYTFZkZW1GSVUw?=
 =?utf-8?B?R3V4TnV6aWxzN05HelRSR3dZanRNRnlwd2NKbXFNcU5WalVsVkNtY28rbUZ6?=
 =?utf-8?B?Zm1wWmJIcVNra1BSVFY2YzFCZ1NtZ214LzBBQXpYT1RUSitPWDNmVnhiK3ox?=
 =?utf-8?B?NzQxcnJQa0VGTDlaOE03eGhqSFNHQnNBcjZzenFuOXI1aTAxMU0xY004d0JH?=
 =?utf-8?B?Y3l6ZEVNK1JSWi9NUFRZNlgvS0hQWXZHUmRqdlRzTXFSQkJ0VThVYi9odnBO?=
 =?utf-8?B?dGVkYmQ2Wmcza1ppN2grMExteXlrTW15aE5Nem55ZS9OQ1RoMWFTbzhHSTE4?=
 =?utf-8?B?a3N2Qmx3OHhPS3RtM244TlAyajZuRmxUZ3lVeEowQmpRZW9pU2RpaGZtTHRn?=
 =?utf-8?B?Y1ppUVAzSVZ6T1RUTHVRam5HOGRrYUp5YitrMVFmSTV4RnBNTVdnN21RbFFR?=
 =?utf-8?B?Yk03OFlpbnRBN2dXb0dVZytsazc1ZlNKa2hnTll3MVpYemVUSW1tV3ByT2dv?=
 =?utf-8?B?K0Rlb3Z6bGo3SDg0VlhER29pRjcxSXFERnhmWU8raUtFZVV6cnFMbUszRGxG?=
 =?utf-8?B?NFl3QmY5VjE2eEVGbWhNd0lsRjVpWDVITm56NzhLaHU4cGtWS2xvaVB2bGVR?=
 =?utf-8?B?RE9nNmFuS3RPcjd5Y0pjTnl5YkkyVDcreGFkQ1dVSkliZmdIa2hKd0ZDVk5G?=
 =?utf-8?B?cEtBS3o4MDU2UmxCWktkaVJUU3pBQzVUTlFRSmF6QUJLNk82VmxtNW1iWXY0?=
 =?utf-8?B?SFVPU1lrZVg3R0VKZy9KSTBRejdwS1NlN3lKaXUyeWg4eElZUFpJaFdBbS9x?=
 =?utf-8?B?dWZJSjhnL1NGRXRJdXNKaFFDZWRoc2dtUk9BZHRPYlJOdU1FOXpOdjM3Q0E0?=
 =?utf-8?B?MkthWTY2RDBNMzhIakN2TkxLZlAya3dSWVAvV3hRS0RnQzZZZGxGcEtNSUcw?=
 =?utf-8?B?Uk9NM05LMzQrWDZ1Ukx3KzMyRVlJN3RhOXR5cnNYZUxtSWR6SDVQVEZ2TldH?=
 =?utf-8?B?UWNVN25OZWt3eFNyWHdNdzdQVitWRzhqcnZOVXpuZFYzWmlBczlkbHZIMTdL?=
 =?utf-8?B?ZHBuK2F3aFlsVlQ4TVB6QmFQemlGUS9FQWVaa0JsT1lhMHZsTVVOYVlIN2Zj?=
 =?utf-8?B?MVBMUHFBUVRpOERSbW9LV3EwZm5oNzhWU1hpTDF5bDhLODVBQVZ5TEs2bEdC?=
 =?utf-8?B?a05wQ0p5ekV6cVZlU1c5Y2I3UXNaOHJBZHBCMWM3MnpUMFZyMDJHM2JBYkFC?=
 =?utf-8?B?aUpHc3lpVFlWcjVreDFUNlp2L3c0c3V3akVSVVdhTmw0a2MrUjBOQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CB442EC6FA086F49BBBBD1B8955935BF@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ed15123-3dad-4fe7-8a19-08da1e153f58
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 12:49:43.1166
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3CQlMueOCtpfL7Kxp9prs+a+yxUiHt67XuK24/+qUy9TyHlkFZRIae/UkTVIYaU4atbOfF+oYFMoOiI2SUzhvPZ/i5d9kYS9W7AmN0uCbFU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3766
X-OriginatorOrg: citrix.com

T24gMTIvMDQvMjAyMiAxMToyOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEZ1dHVyZSBnYXMgdmVy
c2lvbnMgd2lsbCBnZW5lcmF0ZSBtaW5pbWFsaXN0aWMgRHdhcmYgZGVidWcgaW5mbyBmb3INCj4g
aXRlbXMgYW5ub3RhdGVkIGFzIGZ1bmN0aW9ucyBhbmQgaGF2aW5nIHRoZWlyIHNpemVzIHNwZWNp
ZmllZCBbMV0uDQo+ICJCb3Jyb3ciIEFybSdzIEVORCgpIGFuZCBFTkRQUk9DKCkgdG8gYXZvaWQg
b3Blbi1jb2RpbmcgKGFuZCBwZXJoYXBzDQo+IHR5cG8taW5nKSB0aGUgcmVzcGVjdGl2ZSBkaXJl
Y3RpdmVzLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5j
b20+DQo+DQo+IFsxXSBodHRwczovL3NvdXJjZXdhcmUub3JnL2dpdD9wPWJpbnV0aWxzLWdkYi5n
aXQ7YT1jb21taXRkaWZmO2g9NTkxY2M5ZmJiZmQ2ZDUxMTMxYzBmMWQ0YTkyZTc4OTNlZGNjN2Ey
OA0KDQpJJ20gY29uZmxpY3RlZCBieSB0aGlzIGNoYW5nZS4NCg0KWW91J3ZlIGNsZWFybHkgY2hh
bmdlZCB5b3VyIG1pbmQgc2luY2UgeW91IHJlamVjdGVkIG15IHBhdGNoIGludHJvZHVjaW5nDQp0
aGlzIGluZnJhc3RydWN0dXJlIGFuZCBzdGFydGluZyB0byB1c2UgaXQuDQoNCkdpdmVuIHRoYXQg
aXQgaXMgYSByZW9jY3VycmluZyBidWcgd2l0aCBsaXZlcGF0Y2hpbmcgd2hpY2ggaGFzIGJlZW4g
aW4NCm5lZWQgb2YgZml4aW5nIHNpbmNlIDIwMTgsIEknZCBvcmdhbmlzZWQgc29tZSB3b3JrIHRv
IHBvcnQgTGludXgncw0KbGlua2FnZS5oIGFzIHNvbWV0aGluZyBtb3JlIGxpa2VseSB0byBoYXZl
IGJlZW4gYWNjZXB0YWJsZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 12:52:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 12:52:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304717.519416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyxQ-0004OA-IK; Thu, 14 Apr 2022 12:52:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304717.519416; Thu, 14 Apr 2022 12:52:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyxQ-0004O2-FT; Thu, 14 Apr 2022 12:52:20 +0000
Received: by outflank-mailman (input) for mailman id 304717;
 Thu, 14 Apr 2022 12:52:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jucj=UY=gmail.com=wei.liu.xen@srs-se1.protection.inumbo.net>)
 id 1neyxP-0004Nu-JM
 for xen-devel@lists.xen.org; Thu, 14 Apr 2022 12:52:19 +0000
Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com
 [209.85.128.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b65fef44-bbf1-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 14:52:16 +0200 (CEST)
Received: by mail-wm1-f42.google.com with SMTP id
 m15-20020a7bca4f000000b0038fdc1394b1so2369738wml.2
 for <xen-devel@lists.xen.org>; Thu, 14 Apr 2022 05:52:16 -0700 (PDT)
Received: from liuwe-devbox-debian-v2 ([51.145.34.42])
 by smtp.gmail.com with ESMTPSA id
 f13-20020a5d64cd000000b0020787751295sm1927597wri.35.2022.04.14.05.52.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 14 Apr 2022 05:52:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b65fef44-bbf1-11ec-8fbd-03012f2f19d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:content-transfer-encoding
         :in-reply-to;
        bh=2NIdeOW9T8yLTPuKGR+tbh8GRu0Fo0tWpAOfcknAD7I=;
        b=lzAmUf7yrAPiKdmetSDKLbPY8KBka0Jc8YO0p62qnge1yytoJRs6pmqO1M8C5LNmBd
         poPNorUXMaN+pSCD+GXP/xbQYEZcvia/D28xEmRzpnxM4arnVUG7q0RhLx4Oy05pmd2y
         zAx9hj6gszZNSCqOIGkfNpXNi4WAnOP8H4SjBdcr6QLhrWze9n5jUIxfbMP6ziILznSR
         +F9IFyNJ0xJ/PGQDYfHaagAAIQ2aJh97NgNBZgzIYwn/SBrg2ZM7BG6XA5lhATx0DFdC
         F+HsSv/39KSeyhsoqB/VKMEctjl4rbB5TwtsJxlnvzf8kZg4KDRxDiNEoSlo5ZHv3diR
         4Npw==
X-Gm-Message-State: AOAM531J89hQnemClvJIXN/gSmt9avnqQAjHfvFPyRYqKwgA3XrWH+cQ
	OiIZTC69IOVX90cT9DLq23Q=
X-Google-Smtp-Source: ABdhPJxdwymHp0jGOsyF/8sRvp0aasCjeW1pDDo5yCYB8lkbiVsa2f9OJk/BbDodfJek9ZLvN2AKxg==
X-Received: by 2002:a05:600c:1e1e:b0:38e:baaa:aae0 with SMTP id ay30-20020a05600c1e1e00b0038ebaaaaae0mr2949022wmb.157.1649940736051;
        Thu, 14 Apr 2022 05:52:16 -0700 (PDT)
Date: Thu, 14 Apr 2022 12:52:13 +0000
From: Wei Liu <wl@xen.org>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, Viresh Kumar <viresh.kumar@linaro.org>,
	"stratos-dev@op-lists.linaro.org" <stratos-dev@op-lists.linaro.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Mathieu Poirier <mathieu.poirier@linaro.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Mike Holmes <mike.holmes@linaro.org>,
	Oleksandr Tyshchenko <olekstysh@gmail.com>,
	Doug Goldstein <cardoe@cardoe.com>
Subject: Re: Virtio on Xen with Rust
Message-ID: <20220414125213.6qqn5wcphau5j3i3@liuwe-devbox-debian-v2>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>
 <20220414114557.4myrs4ud4qi2hnrz@liuwe-devbox-debian-v2>
 <2a735486-a464-3997-642a-3b0660b11b9e@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2a735486-a464-3997-642a-3b0660b11b9e@citrix.com>

On Thu, Apr 14, 2022 at 12:07:10PM +0000, Andrew Cooper wrote:
> On 14/04/2022 12:45, Wei Liu wrote:
> > Hi Viresh
> >
> > This is very cool.
> >
> > On Thu, Apr 14, 2022 at 02:53:58PM +0530, Viresh Kumar wrote:
> >> +xen-devel
> >>
> >> On 14-04-22, 14:45, Viresh Kumar wrote:
> >>> Hello,
> >>>
> >>> We verified our hypervisor-agnostic Rust based vhost-user backends with Qemu
> >>> based setup earlier, and there was growing concern if they were truly
> >>> hypervisor-agnostic.
> >>>
> >>> In order to prove that, we decided to give it a try with Xen, a type-1
> >>> bare-metal hypervisor.
> >>>
> >>> We are happy to announce that we were able to make progress on that front and
> >>> have a working setup where we can test our existing Rust based backends, like
> >>> I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.
> >>>
> >>> Key components:
> >>> --------------
> >>>
> >>> - Xen: https://github.com/vireshk/xen
> >>>
> >>>   Xen requires MMIO and device specific support in order to populate the
> >>>   required devices at the guest. This tree contains four patches on the top of
> >>>   mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C).
> >>>
> >>> - libxen-sys: https://github.com/vireshk/libxen-sys
> >>>
> >>>   We currently depend on the userspace tools/libraries provided by Xen, like
> >>>   xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates provides Rust
> >>>   wrappers over those calls, generated automatically with help of bindgen
> >>>   utility in Rust, that allow us to use the installed Xen libraries. Though we
> >>>   plan to replace this with Rust based "oxerun" (find below) in longer run.
> >>>
> >>> - oxerun (WIP): https://gitlab.com/mathieupoirier/oxerun/-/tree/xen-ioctls
> >>>
> >>>   This is Rust based implementations for Ioctl and hypercalls to Xen. This is WIP
> >>>   and should eventually replace "libxen-sys" crate entirely (which are C based
> >>>   implementation of the same).
> >>>
> > I'm curious to learn why there is a need to replace libxen-sys with the
> > pure Rust implementation. Those libraries (xendevicemodel, xenevtchn,
> > xenforeignmemory) are very stable and battle tested. Their interfaces
> > are stable.
> 
> Very easy.� The library APIs are mess even if they are technically
> stable, and violate various commonly-agreed rules of being a libary such
> as not messing with stdout/stderr behind the applications back, and
> everything gets more simple when you remove an unnecessary level of C
> indirection.

You don't have to use the stdio logger FWIW. I don't disagree things can
be simpler though.

Wei.

> 
> ~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 12:52:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 12:52:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304720.519428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyxy-0004vn-TO; Thu, 14 Apr 2022 12:52:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304720.519428; Thu, 14 Apr 2022 12:52:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1neyxy-0004vg-Pb; Thu, 14 Apr 2022 12:52:54 +0000
Received: by outflank-mailman (input) for mailman id 304720;
 Thu, 14 Apr 2022 12:52:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xfxB=UY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1neyxy-0004Nu-3A
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 12:52:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cc1cb5e7-bbf1-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 14:52:53 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-ukyQhNmIMnqAFAlHaiW6cA-1; Thu, 14 Apr 2022 14:52:51 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB6228.eurprd04.prod.outlook.com (2603:10a6:208:142::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr
 2022 12:52:49 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 12:52:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc1cb5e7-bbf1-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649940772;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iG03g41ap4phssauvE68l94oKQ5bkip1aCgJZF72X78=;
	b=WQF34+PfHXxO407P/0xrx6ADsv8POt8tGALL2p4L7tofHQFb/TFHyqrCzu7eLgjlZeVBxj
	/2zJzmTh+3wucYHnS+d75xy9Xa+GGXwOWgg+UKY4dFyVWGgYuUyNwV52Cbnh3DYnFkDSz0
	dH7fJ3TQDXTnpxBS7GN02sLtENuBDS0=
X-MC-Unique: ukyQhNmIMnqAFAlHaiW6cA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HSY2dA9wasFULBg6SnzcXh/XpEWm7/4XEClfpppvrA5tEkNBwkayCNNXXC030lMZ9hIFJEAIb1JINj7sbJvDBpzvJbXfoj6CS70e0uoYPqOI5wMnGuFcIdQ+om7NqL8cNQP+d6byH/bYPqLiqITnmXKW/7uDigBm/VX1YL6xKE/Ya7FFzBChqhW21xM079nsK6qbsiD8iRPJd0u0Y+RkS2KjqN1r/HibdUhB9moznwQFUF+BS1ZXoGLh/HbHtfCTQBO7vGIXGmjIq34bskOkGkphB+6GTsG807wR6mBCthyIaaNFZ0gpJL9oAu2lu788GtqRQA5uOOKlQFPEQWh3Eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7KWP01lNvpF59J6Of1jzl/vhPMK3P3XrLhG0Ma26yVg=;
 b=HyWu41S3zmzKObbk0alSZ+iVmVE5aC2X+iXFQ4dvL8V5Glu5WL2m8NlXAJz+KhIoBFHPdfCQyUrwZrEu87rWpypr8u11rl1g5nydrv5iYZGEFMQNB6sSWKMgOXq0PP9IiVkBynHgFhQ1oPdLI9c/SxAAAEmTsUTQ1n4OwWYK7jfynTRF55wOtgqQVufwH3gTmxmx7FwqZzqIIRPH1I6aWsMG/axSBQgTwCsyoRO5RyhZyUJnV8s4sw//YFTh5WAv9sMFit2Nxui6jSyqIWGmxBLN57PdrVnOO6OMBDfdANXwDBluQ1wPalF00VzPQJnrUeAwhNEfuzcFfLbECuT7Cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <04f9bd9c-70da-0966-afa6-96f81e290204@suse.com>
Date: Thu, 14 Apr 2022 14:52:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/2] x86: improve .debug_line contents for assembly
 sources
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
 <YlgWKGmR+u41zSsw@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlgWKGmR+u41zSsw@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0013.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 61f1c1b2-ee7a-42d3-310a-08da1e15ae7b
X-MS-TrafficTypeDiagnostic: AM0PR04MB6228:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB622848E30B81E974AB39734FB3EF9@AM0PR04MB6228.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bPm8GgGITvgDXmTduZ/ISL+AKPCzIzHoHJhaIbXW8j4wCA4GSKLzo7qggcinA6EZEHbCixSTzWoFi8R/z9k7Ip7XXYq0O0xTEfUUdeTAgJr8xWD+fIS2EB35L/PfSxSfKuJ6CA4SGrKHQyfhlRLTLKHvIZDssSl9Ugj/3iG9kNsY9baXY9L8RUWK/Da6nfemsHP/h25vqu8kQotbr5UZHMajo7Ux/RqD9dXal5Xm2hKHMa3h5le3e/xXOFVOGvToEWWNDpPKLxcYyLp/4mKn7x6WYQKlt3uQAyP9qtinuQrDx6KRLBbCTx7pePAMFQsYfj7/dDasSOBAJT+pe3v1VBPBmDfcYLfQdnc/7gEMqggpw6y0U/Hu4kNAvi9PaOf3dC4WkAotkNINvnXmznKroupDl+OtfvPIXMYaM3jsNR4QKmPDTyKJnvyh8+0ACTbGSnRMkAgNdoLOkZvYHsjJbilsPhBZpmyRddZlycwW77vRWCOn800qCwvGWGBE/jb/VUw3j4PjbyjG7DenDtsOqaufwLbO3Rj/8xFhkmKauxmTOLI98XgXtc3cC3qDRb24aOf8mFLMqxolnBacFj3L2zOeDvk+Ib8jOEsBWhgHLKqvfIO41F/YnFw7v4Ld78mdWbNIgCV77pzihdwcs+BmCOVhU8ZGpdJjDq9FLcJ3NeqsS5vubJnUAZ8yaQ718mLXMGz/ROnMbgBuAwPIb1JgN9ySD2xxmA0vzQgzUoXbu9ScmGUP1UMwOn9/gSMMmM/JAbeq+6RbRdVKZ/yz9qvMbvmjpnq3QrOhtgRmCaP0B/hbGLetcOBJXZveKHcuabnPjXyP8oOlXuNlgFIkyIQQL3j5weH/Mnfb4Lj3FfP6VqeBgdZJX08mgvKukDmAQ58b50Nd/tmfxvgF6GOqv8nUXg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2616005)(26005)(508600001)(316002)(31696002)(54906003)(5660300002)(6916009)(86362001)(83380400001)(38100700002)(966005)(6486002)(53546011)(6506007)(2906002)(36756003)(31686004)(4326008)(8676002)(66556008)(66946007)(6512007)(66476007)(8936002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?yxvSWkoAYQr0wsoUaT5kbCvN1zN6QMLWsMUsyMaQOxXkv0hy+RHTX7x2NtcR?=
 =?us-ascii?Q?bFmHVTdi6Hlf9qRm89jagmmF5V8YAXENVA6Z3Ou7xfZcDYYHVZ+8joQtSxkr?=
 =?us-ascii?Q?DrIqfMVdwEf93OXZ5c9nHOMOHwsVCjyaR3iYsA64bmjFnJAHJc4D1E3zqxHH?=
 =?us-ascii?Q?sVgwqZDeqBtVeNZ+8XICAr+npAijUIduIQSV97NLma3XaLVAW+VSbtSDz7X8?=
 =?us-ascii?Q?NwtMzD6RcZE+p38K1VIGkfgNWjwLXz8M+axykjsRfV/T/bEfeSMai9Z6Rr9e?=
 =?us-ascii?Q?sOr7kqEkASeD/o4k5B4kazf7sj32VM5cl0L8NVDeKbBosZzoem7xkqu0ycas?=
 =?us-ascii?Q?frsCJR+WJMeHxq2FWdG7kJBoiyNwhlVGaWzCutyo01lSRPlhI3XgCQc9+uI8?=
 =?us-ascii?Q?U03jn1QbHkx6NKd1wfgNQ/K07d3yZxHkAHKrZPeheJTCt/KTO0JVOsrCDuKl?=
 =?us-ascii?Q?onGNx90V9rriBaCK34hmva6PiFJa9HMesjfZ3s0C2qaCnG/u3US/D+mUt3Gp?=
 =?us-ascii?Q?QTZXiPeXY07mTIX2gq3QgqM1yuJwpeweKiuXVryKXpX8bJBd864AWpik1wED?=
 =?us-ascii?Q?s8em0W3WDwD6whzhP3Bgiok1gl1ENR9h46iaTyqLUrx9UmYjBc/NqS/CRasc?=
 =?us-ascii?Q?CfX2swVi+9SDqxYoGMa3McHncJ4HSCeeir742qESySZi/LIeTRAuCbD9F6u2?=
 =?us-ascii?Q?5RT9makSCDRyu1Z67h6AayYHSk4JMITTrCs0FFrePEhtDLroIfsx4wSF7PTq?=
 =?us-ascii?Q?dj4Byx5BRlbqEIVs9tGMXtrUz3dxsVNN/45iaUVNrHLhvePqToe2KIomBlqY?=
 =?us-ascii?Q?j7mIjpyTYPx5e+4vAGArTR0k5RdQ1rGSl+84rGkpBMpqOSrH39LbV9aLH6Ri?=
 =?us-ascii?Q?zcwoOYToo7PeE+VvcwT2dcPmLwk82mXbjq+pDbKPz72uAuPGFi8kQEyoZdUz?=
 =?us-ascii?Q?9rftRSrsmyMZgrtgJvbPYydrMzQcudIgvuM2K/q410jzARifeJQM4e7yu0mm?=
 =?us-ascii?Q?7YZOjw/pqIZ/ytvEAa1q+9tAb2lGhB+8gk5xQs5PPb0Nj/xN4IPQpADxCJ9u?=
 =?us-ascii?Q?+6q+vn4es16WEh4RWHtVcwkq3qbTc3lMfzIP7U/ifk11F/FEaQeFe6c8GqoI?=
 =?us-ascii?Q?9fikerqt0qqUX0CPldsG3Q2SYp3vZ9CkiN3nPfX2LUPF6NXOFeITnbqlqssZ?=
 =?us-ascii?Q?KnCVnejFECt6sqKFFycRy7/Z2pwlFbnCGo3RhF7m62LmHC++dZ4b0qL+4kbn?=
 =?us-ascii?Q?6YDIpDZmMASbc84f1p1U8+NKNlDS6q2TdOh6G74ulR2ts6OZLqZbpvuzfkw+?=
 =?us-ascii?Q?SYbxI4AQ2dfeUeH1aVplIjrG7CU9cAdujIqd4o6IIoc7t5lqxSXyKMtfSGsF?=
 =?us-ascii?Q?gEK1QQzsf89f6/p2U0XZjb7n3HGB68kM85TgSEytFrP/TPmdWXf2g4D/ddtY?=
 =?us-ascii?Q?ojfBwPycnNdhzTvrnXNP9z5g4b1tU6nJ44dz4DBllM1ufBJNj93F58NultRU?=
 =?us-ascii?Q?j9qT4ky87GTH23Tz0e0EUkcF+spYJ563iBSFdve9UPBnUooi77l0mRqILgyc?=
 =?us-ascii?Q?eD9T+zgt+BnaY1K1aIBkcdbOsrgVe0MswxyySuln5bTU4WNhLydsippqHqM1?=
 =?us-ascii?Q?EiOHJ+nOPCfwKaUjSVEzr1HESo4YonHtWbQw+huunj/HHNnZCHNBoGwG9lRx?=
 =?us-ascii?Q?k0mO0b+4umCRuudz6GOhlQJlyEDRJWxGXPO5ELNUCGDVmWrJrOweeKJZsAM4?=
 =?us-ascii?Q?pIG7uFW+qg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61f1c1b2-ee7a-42d3-310a-08da1e15ae7b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 12:52:49.8364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mITBBLKSguAvgfs4ib0PJIK6ir4I7DENh4CTc0TSclfaXxAjDnOw3S6dCcXOi4dimiY+JzGu+DeZRc0cUEYQ+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6228

On 14.04.2022 14:40, Roger Pau Monn=C3=A9 wrote:
> On Tue, Apr 12, 2022 at 12:27:34PM +0200, Jan Beulich wrote:
>> While future gas versions will allow line number information to be
>> generated for all instances of .irp and alike [1][2], the same isn't
>> true (nor immediately intended) for .macro [3]. Hence macros, when they
>> do more than just invoke another macro or issue an individual insn, want
>> to have .line directives (in header files also .file ones) in place.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> [1] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=3D7=
992631e8c0b0e711fbaba991348ef6f6e583725
>> [2] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=3D2=
ee1792bec225ea19c71095cee5a3a9ae6df7c59
>> [3] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=3D6=
d1ace6861e999361b30d1bc27459ab8094e0d4a
>> ---
>> Using .file has the perhaps undesirable side effect of generating a fair
>> amount of (all identical) STT_FILE entries in the symbol table. We also
>> can't use the supposedly assembler-internal (and hence undocumented)
>> .appfile anymore, as it was removed [4]. Note that .linefile (also
>> internal/undocumented) as well as the "# <line> <file>" constructs the
>> compiler emits, leading to .linefile insertion by the assembler, aren't
>> of use anyway as these are processed and purged when processing .macro
>> [3].
>>
>> [4] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=3Dc=
39e89c3aaa3a6790f85e80f2da5022bc4bce38b
>>
>> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
>> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
>> @@ -24,6 +24,8 @@
>>  #include <asm/msr-index.h>
>>  #include <asm/spec_ctrl.h>
>> =20
>> +#define FILE_AND_LINE .file __FILE__; .line __LINE__
>=20
> Seeing as this seems to get added to all macros below, I guess you did
> consider (and discarded) introducing a preprocessor macro do to the
> asm macro definitons:
>=20
> #define DECLARE_MACRO(n, ...) \
> .macro n __VA_ARGS__ \
>     .file __FILE__; .line __LINE__

No, I didn't even consider that. I view such as too obfuscating - there's
then e.g. no visual match with the .endm. Furthermore, as outlined in the
description, I don't think this wants applying uniformly. There are
macros which better don't have this added. Yet I also would prefer to not
end up with a mix of .macro and DECLARE_MACRO().

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 12:59:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 12:59:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304729.519438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez4Z-0005j3-NF; Thu, 14 Apr 2022 12:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304729.519438; Thu, 14 Apr 2022 12:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez4Z-0005iw-KP; Thu, 14 Apr 2022 12:59:43 +0000
Received: by outflank-mailman (input) for mailman id 304729;
 Thu, 14 Apr 2022 12:59:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xfxB=UY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nez4Y-0005iq-19
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 12:59:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf3e9636-bbf2-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 14:59:40 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-AXqV1K0GMI2CBTIzD8fnbw-1; Thu, 14 Apr 2022 14:59:39 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB7931.eurprd04.prod.outlook.com (2603:10a6:10:1eb::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 14 Apr
 2022 12:59:37 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 12:59:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf3e9636-bbf2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649941180;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=b5uNq+bMf/0KXclaV12fWHRa6rfIrh4+xcGNYdN0tNk=;
	b=hT8XIRaBvhCDMjW0WCntQsIZN1u98Qq8OtJDOI+WEKLCc66gDyaC28UFrPlZrTjKRNVnNY
	DE8t/M4w/6dknUDtmZicfWYCVKKCUdMY31A5oiNDO7RWfPfw/xOxtJlY+3SjxjhgrLKq2F
	5nxb4px1talD2lkVVIRICLem8A8fMLE=
X-MC-Unique: AXqV1K0GMI2CBTIzD8fnbw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gPsagwSQ4JBQJpwMqf0caw2n/zlxDvqmMb8Yotiwcg4V6LM7HaAxG9zHmn+HI0f+QMS8HOHv9RCxmylweS4YJ5lPl7qkx+wJmkD3cvKYvo9VvYl6vuD7feu64Uk7tT1i6T1M1uopGggpdv7HjPRBDGtNQBKs+v5rW76Fm8VgPfCdEeK61YW7cyd2eB4dH0cmECXeZnRWSI7Qxuki1fp33vCjT4XXSbIRlYqbndUJgiJP/wgzahcgC9X4a4lUFgSvJAN7mHnEDb3vUnOslqFd3tKPIptibd0H19OD+cPVz+gzU/zwLiB3+BgyCgffql/UD4zowFphg5OOiargzdhpbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b5uNq+bMf/0KXclaV12fWHRa6rfIrh4+xcGNYdN0tNk=;
 b=OVkyLS3M55iyUx49koU7UndC1wdvP2GXiFUlER9Zd2nGdNHsnKD16ADbBh8mqtVjcBvLcO5vASg/E3T1cTIwpZyQZpk9WBGx1WYXwHhMmbRj/3wWFFQfHyZXTPOXnHln33PQ67Vr8GOCDhwyCOuVHiLvaISayNTulFuCzz/FMCG98tmTYho1B/wOZffQ5HylfTeog2w4rI8b2JLr9XOD2b+RAlilluq3mFifhKqszaFVJD6zrqjJrYeN9ImDYcAsFrupNt+kevYEJcU7VdlhJkj/fIEACch4BHxqZr/Y70WCHO+dlj5ERsnySjc/t+HxEg7ErhCFlrdLPrpcnwJp0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <44589528-2655-a949-0fd9-f30b6f2fa09d@suse.com>
Date: Thu, 14 Apr 2022 14:59:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 2/2] x86: annotate entry points with type and size
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <531ab7f7-ce5a-12b2-e7e7-528c26f9ff7f@suse.com>
 <22df182a-762d-711e-5191-d4b628904085@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <22df182a-762d-711e-5191-d4b628904085@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR0301CA0047.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::27) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a95bfea2-a3f0-4929-50af-08da1e16a177
X-MS-TrafficTypeDiagnostic: DBBPR04MB7931:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7931B3E0D215FD0E47729855B3EF9@DBBPR04MB7931.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bQjQA74OMugbZVxQNHSe6eTTVpLh5fnBjfFeuqvomnEyyXKivGoH7tX1xr4RqO5E3tu8Tb8Zc1ZJmXF2mn0huQG+x+TL8hsOxUunkG+5ilIe5ztJST6rhON8HPhdw5iVyBojb0IotsIt3QS3pc9d8/8WrSJeUSEHOUvLi6nFjmzvHM190e4yN6wtaugAo9LgisECNFTynMCYwBD7Gx94SOf0fIXFOVuWbCfFE1zrjYynR+9/1SecQBQWdXHZqKoPgooUUoWGHpW3zZndkmX4IXmIgeGoX2NxEUhh5fEcLbWb7yg99OE3C3NKxHFAsyFW70SZGnrfDLTr3/L1/iPECwh51go//tp0G8coe74Z7dpnB87jcPGscUE0ncZMvGo3H1zRRtiDlEtlmKd1Apj0PvFkLA3SUd9VmEvahuQkBEbW77ea5Xb28ys91KjbgdArwauVSZRFy55PHzG2WGT+Ta9SKToGiH2uKEtMSK34lIgG32AXoeIg5V6ubG4Vl184i72s5TFjtelrpT43OS9I0cZrj7SVIi0wURXvwaVE5QopXBWI0L7a6qJxT3rkXLHenOh9HYQ/Wlfmeic6scmzMaf6OA0OiDX5+plZeasFHYMuM5iGP/jRfmUPq1qiJ6CewAASv3ApeHaeNY29GH1SbZCRl3ohp326uJmcPsicoumshUH3jnG+IniQ3LCI0LOPc34ZXaszyn5oskPhqJZ5V2dd4vZFQzUxtQ5y1guXjLqgs2JN8yiL0nxt3zo/p4SVIsGzorr+wIloxksSIspmpuVnI50eW5GZ+M3LtY79tj+4OqqLLG8qza758PnvgA7yE1zZFbTkV1D/jSQb/OXhww==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(6512007)(5660300002)(2616005)(86362001)(54906003)(31686004)(31696002)(83380400001)(316002)(6916009)(6486002)(36756003)(966005)(508600001)(66946007)(6506007)(8676002)(4326008)(186003)(38100700002)(8936002)(26005)(6666004)(53546011)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eGE3aVZ3QnJWTGxiajVxQ1hMbFUxRFZtN0diM05XTVVjL3dxTGtuZ1FqRi81?=
 =?utf-8?B?eGxHa2RMMGV2bUhWeGZtU2Q3QWtxaVRyUWpQdGVua3Vuanc2WUNweDBLelhE?=
 =?utf-8?B?Y1h6c0V5d3VVRDB5YTFRUnB0U0tLZGxJRnhLR2p6ZDQ2dU9iUjkvSnE0eVo0?=
 =?utf-8?B?VU1yMmxyd0YzOU9GMitHN0lFc2hUWkh2SFFvWmV5NnRHaUJMdDhFUnF5RVBW?=
 =?utf-8?B?WkplL3RCSHdHdzZQbU00d1lsSUxQRTI3UVZuUDhqWnBEWmU1SkRyOE8rVVJO?=
 =?utf-8?B?L0NwZGE1dGFJbWkrOXBLQzhDZnVWdmltaHJseHI3WVFQRC9JeTExdVRtZTdP?=
 =?utf-8?B?ZzJHSDZ4bVpPVCtCQnN5Y0RqOGs5Zy9FNlduZzA0YVhSTjNNNmRHR1Zac3kw?=
 =?utf-8?B?SUk2VkdqL1Y1Q2Q5Uk0weERRRXVRVHJ2ZGE2RXBTbXV1NkJWcjQxeXhDUDE5?=
 =?utf-8?B?WkFCeXplNkh2MUMzc2c2VDdKeEFqd3QrM0RoVjB6QXJpRmF3bFY4anhZVVls?=
 =?utf-8?B?UUFIa3RjUi8wNTR0Wmt3UFpPM0FsRnFOVFBCN1ErZkJXazFuSC9STzJWN0Ux?=
 =?utf-8?B?amNySStjQ2ZGcjBxdmFKbC9nKzVXK0Q0ck5rLzF5QjM1MkkrakcrUlRnNnJB?=
 =?utf-8?B?Q0xxNWorbG4zdXJpaDFBamU5bkdXWHVTcHg5VTFQRXBITjJMUWVhS0ZXYnJj?=
 =?utf-8?B?aHR2ckh4WXBRcHJVaVRINm5Kb2FDWFJqSGQyU3VpSXJjbjNPbkhKOXdYNFhO?=
 =?utf-8?B?aHIyd1Z5K2svTDlyRnYyb3BZVXlOZE44eithejZKOFlXNE1XR2pzdFdEM3d5?=
 =?utf-8?B?VFgvY3FNWjhCK1ZPVlFEdkppVDd0M2l2ZTdjODVCOXdKOU5KQVpGK1lUSUtW?=
 =?utf-8?B?VUNJL29Zb21UR3N0eFh4cnoxWkJjaVpzdEkzQ1UrUDF1bWo3YVMxZnVQMW9y?=
 =?utf-8?B?OUdlT0dORkVVNGhZN3hYQzhSTDZYWjQ4cVMrNjVGVHE5WHZlT1dhL2dTYU1I?=
 =?utf-8?B?aVZCMTFuZGVRUm9FOFpDaW5aVXBEK1dJcDNYTE00NjBYZkR2VWpBUDJ0OXpL?=
 =?utf-8?B?UHF1bEVLcHJKVjIwd09rRUNqQkt0NW85b09OcWdlb0tIK0RibjhPUzBoVjk5?=
 =?utf-8?B?VTBVTEtVWlRmRFF2d1V2MzZVU2tvY2VhT3NlSStMQTVJOWdBcmlyaGx0SWpT?=
 =?utf-8?B?KzVMcDBML2NQSUtkVWdIK2lxVUpCNWR4eVpyM2FsVGZSZk1hK0MwcW9uV2g1?=
 =?utf-8?B?TnNUVks4Z2VjK1JqNldMalQwNm0wL3FXRnp5SWRBalZ2UHdQMDBqZ2ErU3Rt?=
 =?utf-8?B?MDlhWDBDTUl3czk4QXBHR04vU05TRk1Ib2lGQkFYLzRybCtwbVRGTzgraXV3?=
 =?utf-8?B?RzczZFRHUkRUeEhCNkYwV2J1cGsrZEdwUEQxaXVRdVduTHU2NlBIOExVeGtV?=
 =?utf-8?B?MHFld2JrV1h4aWRNQlIwemI5V2RuRGx6UkFsS21Uc1gyV2M2Q3hDODBNYjdm?=
 =?utf-8?B?WWhQTFZSWmJlZ29IMlEyTWtVZGlmdE9SMUJsRktvb0JDeDhYKzVmd3RiUzhl?=
 =?utf-8?B?MmtXRFpYd3o4b0FSN3hKSGp5eVhhRzYzSjU4b1VSTXovZk5PWTMzNm5ibURB?=
 =?utf-8?B?OG95R01iVnBwejNJRlp2ZlJGSDBwaWVySHJDc3J1bURWQ3NEQ2xydFBFMHZo?=
 =?utf-8?B?Y3dMS0VXSmg3bEt3NU03OEpsVU9oZG9qN2RvVE40cnhnL2xWUndxOEF5QTFk?=
 =?utf-8?B?aWgySjI1U3ZSVUE3dG9kZ2kzQWRqYmpQM3g0UHFBQ0k3dytyenY0VnFtbkkr?=
 =?utf-8?B?a0NsRi9za09UdU9tVWNpZWdTa3hjWEc4S1VJSHZNencvNE1uRDVxWUMzdXFa?=
 =?utf-8?B?N3pwd1pXcWEwTkg2c2x0UlNXRm40TkFrRThJTUU0RFk4OW5EYlRad05MVVRa?=
 =?utf-8?B?ZklEMGxBRlI3UU5haWM5dnE1ME1VQnFFU0JVM0hPd21kdjJSTEY4VlpwSnBm?=
 =?utf-8?B?L1VDb0txdVZFM0JqcDF2OFpPYTA5UzhNQkR1YXlEZGVCbFNtOW1hU0U2WGtO?=
 =?utf-8?B?bXhQQ3RkQW5LNnd5MzE5TzVoMnpIUG5FVXN5VHVtbnhtaUxEMi9GejlUUEEr?=
 =?utf-8?B?R2pJWjN5OW56eTdVdHNQSldBUXo4amZ5L1EzcVUvdEVuVUFycnhqZURhMlg2?=
 =?utf-8?B?akxnTEF4Wnd1OFJ3N1JuSmlCY3F5ZXNGUkhOdnVmRCttS3BoZTJRYVNXd3Z6?=
 =?utf-8?B?VmZxSUU5NExINHhpUDl0enhVem91TjdrUTl3alE4MEprbmVvd2U3SjJNNVBk?=
 =?utf-8?B?d0NsVUpzTGhOaVc0U0F4ZUE5c1hiRCtJa2xQTUtQYkN0aHFsK25hdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a95bfea2-a3f0-4929-50af-08da1e16a177
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 12:59:37.4505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yl1eLjuep0D67yruPLUT8VA5QhsNV81sOEUXYEwdKBP1Dc+HwNTnB56i/YjxOIYYoriRSzSPEojPN7biPj3F4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7931

On 14.04.2022 14:49, Andrew Cooper wrote:
> On 12/04/2022 11:28, Jan Beulich wrote:
>> Future gas versions will generate minimalistic Dwarf debug info for
>> items annotated as functions and having their sizes specified [1].
>> "Borrow" Arm's END() and ENDPROC() to avoid open-coding (and perhaps
>> typo-ing) the respective directives.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> [1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
> 
> I'm conflicted by this change.
> 
> You've clearly changed your mind since you rejected my patch introducing
> this infrastructure and starting to use it.

Hmm, to be honest I don't recall me rejecting such work of yours.
In fact I have always been in favor of properly typing symbols,
where sensible and possible. I would therefore assume it was more
the "how" than the "that" which I wasn't happy with. If you have
a reference to the old thread to hand, I'd be interested in
looking up what made me oppose back at the time.

> Given that it is a reoccurring bug with livepatching which has been in
> need of fixing since 2018, I'd organised some work to port Linux's
> linkage.h as something more likely to have been acceptable.

Taking what they've got would likely be fine as well. At least in
a suitably stripped down manner (looking at their header they may
have gone a little overboard with this).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:00:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:00:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304733.519451 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez5d-00073B-4z; Thu, 14 Apr 2022 13:00:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304733.519451; Thu, 14 Apr 2022 13:00:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez5c-000734-VS; Thu, 14 Apr 2022 13:00:48 +0000
Received: by outflank-mailman (input) for mailman id 304733;
 Thu, 14 Apr 2022 13:00:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nez5b-00072q-0S; Thu, 14 Apr 2022 13:00:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nez5a-0001yP-U7; Thu, 14 Apr 2022 13:00:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nez5a-0001mC-JJ; Thu, 14 Apr 2022 13:00:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nez5a-0007Yn-In; Thu, 14 Apr 2022 13:00:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=u5s52leYR+SmxC0YfS1uQApWDWSEei03yHG4yB9rPSU=; b=EGc1W5CLhxUHs3H8+dc+G0AwaO
	hfhMRwLq//i8+XhIp/t6rBlEvZelaFgKbtuwS90wiLsLEd3uemvjOc1cibYD2rU4RUCTxd80KuD5O
	kCQBTz0uiL8A7njqCqzGMtpdb2i83i9Fw+FLjqdIjb3rl2bk/ocpWrtxyVLrY+qwqF1Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169394-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169394: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 13:00:46 +0000

flight 169394 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169394/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  386 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:03:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:03:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304743.519461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez7y-0007kf-HG; Thu, 14 Apr 2022 13:03:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304743.519461; Thu, 14 Apr 2022 13:03:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez7y-0007kY-Db; Thu, 14 Apr 2022 13:03:14 +0000
Received: by outflank-mailman (input) for mailman id 304743;
 Thu, 14 Apr 2022 13:03:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gNLD=UY=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nez7x-0007kS-Ey
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 13:03:13 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0612.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::612])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3d6cb100-bbf3-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 15:03:12 +0200 (CEST)
Received: from AS8P189CA0010.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::9)
 by DB8PR08MB5308.eurprd08.prod.outlook.com (2603:10a6:10:f9::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 14 Apr
 2022 13:03:11 +0000
Received: from AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:31f:cafe::cd) by AS8P189CA0010.outlook.office365.com
 (2603:10a6:20b:31f::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Thu, 14 Apr 2022 13:03:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT057.mail.protection.outlook.com (10.152.17.44) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 13:03:10 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Thu, 14 Apr 2022 13:03:10 +0000
Received: from 0ad73b1eb205.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E4206359-1138-441E-A8C5-532AFE73C547.1; 
 Thu, 14 Apr 2022 13:03:04 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0ad73b1eb205.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Apr 2022 13:03:04 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24)
 by DB7PR08MB3609.eurprd08.prod.outlook.com (2603:10a6:10:42::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr
 2022 13:03:02 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::e05d:b3fc:609a:df20]) by AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::e05d:b3fc:609a:df20%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 13:03:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d6cb100-bbf3-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oUdA959nXskSGsrMqif2eNyPZW+CXka7xyoOctDgAh0=;
 b=PriuQlYbmzHbEntgvvdM8F2ul8cTecjjuJoUOse9xWjc2E+Y6ZB20fLZqRNSqla4bV3R2uDmXql/+HL54TBur203iYucTZ3/viJzJ0hmSumAd+Joxvu+qQbIH0fF2QSqwKEfY9XbAi4uJf2Q0pGDL4Cg+FlllpU9PbWWw3WHGQ0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f8c15194ae5b27af
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rxk/dCDqyg/PIiq0jMgWQJwxnJcADml8s33yw6TfTFfHOI958jhOEdH8vzRF+R5F1YZNjY/cQC42noAr/FSqPyEkaCQ3epZjt1mpgQwk9+5P/KwG36d8yigaJiXX+kjN3uGUiENFCyIOy3ItA3QtIxOqlLQteP0J609WDTHr06b6v7U3BVg586qpBsiYkNVzAzA6/ObHvz9ZkjCdUZNfQvSpNn+2HXpuHiBnzG1JqiB2Bau4c33CKyqbyAFt18cde/GN5rYNFetyOe8GuCr5aIFl2b9iyo49Ej/r92xh0sPdIBfLZCUNAGtumC9rKKIHn2L2B6b0UP8JNuU8YP1Heg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oUdA959nXskSGsrMqif2eNyPZW+CXka7xyoOctDgAh0=;
 b=LvKX2B69wWDbLcGXRu2+vzhy7LhOCK/y6vs2QXryRZf4g8C8K2zkleYp3J/0TySg3Mx3pFf88W5/3T/P5QOTbl4YUXI/oX9B/WcrtHiTtYUzbk7mF/Z6yOVRxpJhHY+8DY8lOQJdq0VbyI0bDuz5Q9qg/qDLDZFzjUEYAlSJK+L4okGQnPyZrx+hSbOsZqkg9iZx9tI3Kh4cJLnPHUjlMs0vCaibJMsjapWqihq2RfzQYS1ShHn2xoMV5EqXmnqrbXG33nX+P4arLi6srzl8Yontvj9TMsioAecCApJDJlJo0B9j0kdy2Lw9LoF5SHwb3h7+LM46h8fqxaiwYfv8zA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oUdA959nXskSGsrMqif2eNyPZW+CXka7xyoOctDgAh0=;
 b=PriuQlYbmzHbEntgvvdM8F2ul8cTecjjuJoUOse9xWjc2E+Y6ZB20fLZqRNSqla4bV3R2uDmXql/+HL54TBur203iYucTZ3/viJzJ0hmSumAd+Joxvu+qQbIH0fF2QSqwKEfY9XbAi4uJf2Q0pGDL4Cg+FlllpU9PbWWw3WHGQ0=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, "julien@xen.org"
	<julien@xen.org>, "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"van.freenix@gmail.com" <van.freenix@gmail.com>, Michal Orzel
	<Michal.Orzel@arm.com>, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V5 2/2] xen/arm: Add i.MX lpuart early printk support
Thread-Topic: [PATCH V5 2/2] xen/arm: Add i.MX lpuart early printk support
Thread-Index: AQHYT83RPYD4QIXhgkG5U0C1k6a0XqzvYFWA
Date: Thu, 14 Apr 2022 13:03:02 +0000
Message-ID: <E7F69DC4-59E5-40DF-8630-B4A22448C4D8@arm.com>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com>
 <20220414074452.14419-3-peng.fan@oss.nxp.com>
In-Reply-To: <20220414074452.14419-3-peng.fan@oss.nxp.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 9f9526bc-c4ae-44a2-03ba-08da1e1720c2
x-ms-traffictypediagnostic:
	DB7PR08MB3609:EE_|AM5EUR03FT057:EE_|DB8PR08MB5308:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB53080965C371B393F14CC8FA9DEF9@DB8PR08MB5308.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 G3xiymwoyWLWREtABEaTg4c5ZdGnwsIGxFHfHIq6uea7cIWQ8f97IeH63MjlauZwf6644kaAb9jyJo5BvbIcz2mxZv8mSGOkz60vsKteO/M/RodRSqsF7cdqSsx8d9Luoj2AUFvDmWG+51biNevNx5o2MK8mSdliUzWGcG2d3h/MEWP9zUElODmxzgF5q1G6sixe2koseU5IRTjTMKLqgFm6kVTM5wh7x0y8MuckoFQzrA/VSpFx0EidoGKwYfUD9tQh3XDdgdAcjlDm4/Koy3ryiKDPqTwNxRG6muh5KEatH/q/sQTF5o20Qtf+BrjL8TOYz/GWKHEtEgqyJ70wcWFE5sAeQ68h+G02tlICaU48QUCNETaIc++TcSf8UdoZ0ZjMvKcacLA+BkjZy93c/gwrZljgHMzArzO+2onXQXwZvfXrCD1RvySiIjW95XMu8zsLnYi1l6TmK7oz7eju0tRmyHGGQdmQq/ECczZobSBgYBbjoOFLe+86Q0fz+z8LFgulxz/ZOfL1FV1XoDjZptyqYJY9VT60g6QbZOt+3M2j3WlRjoQCGMV3bKPuwDtSKQiViSQmFbYrBFjjGS5/bHaDBr9ktteNvfOUxejsjujUA6pgbP0SH2gKbVkihZFD623P3Fk7xX95qx1FxMc8V7E7AWhrbAakFQI4B67pU/95iUZdiX7tYwHNQLaEalj8nxe/TsTV+L03i0KwUncB8q3qsJKXQfVyTXiFw0Szs9XSB7bej6G/q+PYb5HL84M1LGwhWFAVebk4mlNMhoy8sg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(186003)(5660300002)(38070700005)(122000001)(38100700002)(71200400001)(53546011)(6512007)(6506007)(316002)(6486002)(2616005)(6916009)(508600001)(2906002)(8936002)(7416002)(76116006)(8676002)(86362001)(66946007)(64756008)(4326008)(91956017)(66556008)(66446008)(66476007)(33656002)(36756003)(54906003)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <631A550A6A9EF14587677C594B264686@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3609
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	70254571-c102-42e6-4d30-08da1e171ba4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GwBxF58KB+2A0QXap4KfWqA9kh14TvtdJqPm3Q9zC1iIh7yCwfU+19zHuXtTkqJhzv3juPqpZfDI1hvK6RN6puhahZtb3cqa++GNGsQJNuuJIM3ElwizQUghlzSvOBAuM2B4WEccUG5U/UkGgBlSMffbfv6aoo2V/M4TE6hfyD5cfx8+O91FkJ7MgxnCBJ2wDJo8dBNH9KI+rTfEeJqwKRkDkJ32IIlBUvvmKt1WyCpkR9r7hy6hfxN4ntY2a0Jb7WBN/ZAsOFMR1DGUZPAhp+WbtYbTPi1v66L2ebaaIbNuHBmTyWgiAFPL0h9T8QBiBX17L5ne5gMuV3W9+QfJBTG5ZHx6xGB8JZ+o8LhF4VUTzS5jwkMlywpa7NLDBeSbiN+GdJs2BNYYVwD2Yw/VDyv4zdPIRpLGKVHRY//kXJfRBGInuCz/PoXHDYGOi1+tc30c0c/8GAubOgaC1IPaZlnpg0zo9lLwp1Gk5r7BZ6mOJ7O93iGzyG20DD04A35RTmtGUiVsvUebFDIFOG29G2lHcCqyJ4YIzwnE4AyTuzDc4ogmTMlmuJ3Cqy67dVbkRxsGrhBrRCguMDy8m6P4QUXQUd++lt6lHEajMM8BD83sGEozBtI6Q+ZQcvNYM3JG3vmKZcZCpZ7Bhp0PU4qFko0Qw2D2h0ilKFEMLTkdAwcbiasOX9r1X6Cgp4l54R8K+yhP+QhihmSfPEzegxoN1Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36756003)(336012)(6512007)(8676002)(70586007)(70206006)(81166007)(54906003)(82310400005)(356005)(36860700001)(316002)(47076005)(4326008)(6862004)(2906002)(53546011)(508600001)(6486002)(5660300002)(186003)(86362001)(26005)(6506007)(40460700003)(33656002)(8936002)(2616005)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 13:03:10.8388
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f9526bc-c4ae-44a2-03ba-08da1e1720c2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5308

Hi Peng,

> On 14 Apr 2022, at 08:44, Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>=20
> From: Peng Fan <peng.fan@nxp.com>
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> xen/arch/arm/Kconfig.debug              | 14 ++++++++
> xen/arch/arm/arm64/debug-imx-lpuart.inc | 48 +++++++++++++++++++++++++
> 2 files changed, 62 insertions(+)
> create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
>=20
> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
> index 35ccd13273..842d768280 100644
> --- a/xen/arch/arm/Kconfig.debug
> +++ b/xen/arch/arm/Kconfig.debug
> @@ -58,6 +58,16 @@ choice
> 			This option is preferred over the platform specific
> 			options; the platform specific options are deprecated
> 			and will soon be removed.
> +	config EARLY_UART_CHOICE_IMX_LPUART
> +		select EARLY_UART_IMX_LPUART
> +		depends on ARM_64
> +		bool "Early printk via i.MX LPUART"
> +		help
> +			Say Y here if you wish the early printk to direct their
> +			output to a i.MX LPUART. You can use this option to
> +			provide the parameters for the i.MX LPUART rather than
> +			selecting one of the platform specific options below if
> +			you know the parameters for the port.
> 	config EARLY_UART_CHOICE_MESON
> 		select EARLY_UART_MESON
> 		depends on ARM_64
> @@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
> config EARLY_UART_EXYNOS4210
> 	select EARLY_PRINTK
> 	bool
> +config EARLY_UART_IMX_LPUART
> +	select EARLY_PRINTK
> +	bool
> config EARLY_UART_MESON
> 	select EARLY_PRINTK
> 	bool
> @@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
> 	default "debug-8250.inc" if EARLY_UART_8250
> 	default "debug-cadence.inc" if EARLY_UART_CADENCE
> 	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
> +	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
> 	default "debug-meson.inc" if EARLY_UART_MESON
> 	default "debug-mvebu.inc" if EARLY_UART_MVEBU
> 	default "debug-pl011.inc" if EARLY_UART_PL011
> diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64=
/debug-imx-lpuart.inc
> new file mode 100644
> index 0000000000..b169332932
> --- /dev/null
> +++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
> @@ -0,0 +1,48 @@
> +/*
> + * xen/arch/arm/arm64/debug-imx-lpuart.inc
> + *
> + * i.MX8QM specific debug code
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <asm/imx-lpuart.h>
> +
> +/*
> + * Wait LPUART to be ready to transmit
> + * rb: register which contains the UART base address
> + * rc: scratch register
> + */
> +.macro early_uart_ready xb, c
> +1:
> +        ldr   w\c, [\xb, #UARTSTAT]   /* <- Flag register */
> +        tst   w\c, #UARTSTAT_TDRE     /* Check FIFO EMPTY bit */
> +        beq   1b                      /* Wait for the UART to be ready *=
/
> +.endm
> +
> +/*
> + * LPUART transmit character
> + * rb: register which contains the UART base address
> + * rt: register which contains the character to transmit
> + */
> +.macro early_uart_transmit xb, wt
> +        str   \wt, [\xb, #UARTDATA]  /* -> Data Register */
> +.endm
> +
> +/*
> + * Local variables:
> + * mode: ASM
> + * indent-tabs-mode: nil
> + * End:
> + */
> --=20
> 2.35.1
>=20



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:03:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:03:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304744.519471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez88-00084X-Tt; Thu, 14 Apr 2022 13:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304744.519471; Thu, 14 Apr 2022 13:03:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez88-00084Q-Qz; Thu, 14 Apr 2022 13:03:24 +0000
Received: by outflank-mailman (input) for mailman id 304744;
 Thu, 14 Apr 2022 13:03:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gNLD=UY=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nez87-000842-Vo
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 13:03:24 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20611.outbound.protection.outlook.com
 [2a01:111:f400:7d00::611])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ca04d92-bbf3-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 15:03:04 +0200 (CEST)
Received: from AM5PR0402CA0011.eurprd04.prod.outlook.com
 (2603:10a6:203:90::21) by AM4PR0802MB2276.eurprd08.prod.outlook.com
 (2603:10a6:200:5f::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19; Thu, 14 Apr
 2022 13:02:28 +0000
Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:90:cafe::e3) by AM5PR0402CA0011.outlook.office365.com
 (2603:10a6:203:90::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Thu, 14 Apr 2022 13:02:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 13:02:28 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Thu, 14 Apr 2022 13:02:28 +0000
Received: from e2d7c7bf6e5e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D5CC4D4B-BB13-4F8E-B953-ABB8AC4C64C8.1; 
 Thu, 14 Apr 2022 13:02:17 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e2d7c7bf6e5e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Apr 2022 13:02:17 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24)
 by DB7PR08MB3609.eurprd08.prod.outlook.com (2603:10a6:10:42::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr
 2022 13:02:15 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::e05d:b3fc:609a:df20]) by AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::e05d:b3fc:609a:df20%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 13:02:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ca04d92-bbf3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+17n+2DS4HN45Azv+xQsFHcLoxJ4XLMAWMN2uxsW3iA=;
 b=pl4gAa9AsFuAH1nl0zB5+TSx7ixD+PlxaJvF3Rm+oNRZxd8u/6m9b6qTuJQD3zsBvh8am1KYXMiY0C5xaNKyBhYNu7F50WvJ3s0mQL2+AV4MqNrmniQR12rsWfQcs97pcPRm+/bj8XrUUZZmFQMZFzrDQvjGSn47TlBHVJO4dWs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: e11f845ce3eb985c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dwt83TvDnPjJZJERlS9bbdBYlC5IRGsAbGPupsIzUwpvMEx/gs1NCccHIJjymMuQfh4Y8AiV5fZY4A4m0zcjRyWl7NPSWLv5lX/RN8IJpXpvQ0vhPNRFL9OAzXedpSDlhLpKUEewEXazkFVILnwaijP8ItTHPie9VUueSp9xLmpiRHgvzNDpECxwwyfFSYJYix4KbYcykdm7mV3szfg/C/LW4SLo3OqQhL8Q94SFlIVO2QVimmSvABN4DH/i6up8IQ7b2z2ALb3l42U83s1a+TzPxvtG4MHiieh2ch6XqJ5gfe0V/GKVPJWtHEpfzJcUo1x6Opnbli+PhAXbd8cBMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+17n+2DS4HN45Azv+xQsFHcLoxJ4XLMAWMN2uxsW3iA=;
 b=C++29OdeFJecGDcxb3Hj+J0SPw5/5FTFHq3DJYFpP55CjPA4YJrO39qSUvILUMMybrYMrKXjFx1lV6EIo4ksY5nQ9CCv+5KkzJO3xIw+qmhm2AcTQg5HDD8zsfxcKgm+mkI1sU0v4M7RO+f/C+o5Anb7l1tt4dGsS37bN3bBCYQ8IMGD1OLZdTf0PFBRdcJHa1HpMyhhN6weAipdO0awySjStlqw08tKpWfsFXHmX6NkyyzrIhgykRQB0NXjSAfdBv2zhMjLTUcwJyzG0sNuZCTFHwaWhiT4ASuij594MV3vO15Gltf3MQeg5vzO1LOCPCqNDeKJH81Igq1K7dlTtw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+17n+2DS4HN45Azv+xQsFHcLoxJ4XLMAWMN2uxsW3iA=;
 b=pl4gAa9AsFuAH1nl0zB5+TSx7ixD+PlxaJvF3Rm+oNRZxd8u/6m9b6qTuJQD3zsBvh8am1KYXMiY0C5xaNKyBhYNu7F50WvJ3s0mQL2+AV4MqNrmniQR12rsWfQcs97pcPRm+/bj8XrUUZZmFQMZFzrDQvjGSn47TlBHVJO4dWs=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, "julien@xen.org"
	<julien@xen.org>, "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"van.freenix@gmail.com" <van.freenix@gmail.com>, Michal Orzel
	<Michal.Orzel@arm.com>, Peng Fan <peng.fan@nxp.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: Re: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
Thread-Topic: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
Thread-Index: AQHYT83OVuHlhz8E70qIHrv4OCbfQKzvYB0A
Date: Thu, 14 Apr 2022 13:02:14 +0000
Message-ID: <CB41A35C-2117-4142-BBFC-3B2415F15927@arm.com>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com>
 <20220414074452.14419-2-peng.fan@oss.nxp.com>
In-Reply-To: <20220414074452.14419-2-peng.fan@oss.nxp.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: c19f92b3-b4f4-4b86-00ca-08da1e17076e
x-ms-traffictypediagnostic:
	DB7PR08MB3609:EE_|AM5EUR03FT027:EE_|AM4PR0802MB2276:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR0802MB22766C3B06F25C92B700F4DF9DEF9@AM4PR0802MB2276.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 XEoxWdtCvtGH/HPkohvqDaRpy15F/sxl86DN7EjbijNXASUqRfzFMxGhfJ9ZpE960x4lQ/Cow0WhmoKqfNGR+VwZtMgU06DZz1QULIkAyngsmXRQF+OXqME+whY65CtdEbkt7V6uYuDJC9rGfMuVlraRC8Qgyq80dIDMkAUBfflOCwYmH1dNG+IilVveF0sa1lq4OQetT3RtnNNgjgmK/wJjhv3gcZxoRuV8dkzKZ21l5X6lMrz9kSc3MjVJ0gmq+fBQQAc/4XVadL833mZqcWpuv716uzmj0I1hNiVei9ub5xSD3LY+60jeojxarotjrJMhzqYH8Atm2AngDgAACx2/GphVmAvxBhhkIXUaSsT+3fNwnti72k4eYBBTZRtIGBHNFksro7etO/3Iy3iGw4ZPsDkWi5cnSeeyOYdk7EWikrprDgQAfwIfp9ah1nQbSGGrkJ97t1ErA8hMkRBl+T/wH4F7BbsTXMdr2SQ0tuV0bvHv9k7ahpbqRfyYcWc4d8o37DFKVcLVKYUqM0g1+dlU4c/owkbyTWndy3eC9E5A4YiKusvKDjJmREu5QZAwClTBWqbFtCiPQ6N3hGha094GCbB0Yy2Uv2pJqdNVteLn9gjIbziF0JlO79x957PYGZe2Ph5HdNG8WSF69bxru6hIRDHtCqxT+qu+HlsCKtvScgq36IPhZeXkQUtoKOtjyFs2RuT/Aeg6Jc534GEPTgMrCq13PKM4MUnTgwlC8NkKiNkSrYKQjlthKWlQ/gEuTQo0LgFaeOc0PJzqcrFI7pz7RbWV1jtrPw8aw2IzSsr+O/zQkByzpmWZ+WZmfuCqQ8ODQwA0Ud9Hx5fKC1d+/bbkeDSyQJlcso+5QeQB3sg=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(966005)(26005)(186003)(5660300002)(38070700005)(122000001)(38100700002)(71200400001)(53546011)(6512007)(6506007)(316002)(6486002)(83380400001)(2616005)(6916009)(508600001)(30864003)(2906002)(8936002)(7416002)(76116006)(8676002)(86362001)(66946007)(64756008)(4326008)(91956017)(66556008)(66446008)(66476007)(33656002)(36756003)(54906003)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F337A23EFB4D2E4F92F3C31FECB016FE@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3609
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7dacd508-9a1e-4d4d-5992-08da1e16ff7d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Lcf/JpfZ6BbBJfSSJLOL18Ycsv7v2gaqrNG1EEgEmJhOUjnL5A6XroVu/1Fhj5KRdLtR6YRQIfLkz5nghlQPHOobBH3zJCjCjByiQ+NMN5eJG/2dGXoZmtiTkWRRtb+sryDssTjCoURd9LSZllLrKj5O+Yv+OKMcXY0fACFjB2s4LUWU3aJ378f0Srjhcoc0cVJ0uKbk6b5QVwkoAxueYiXzWE+uwgAYCkNjy3hbmZQVG4LQQoMEOMMsVBB72Or1rvCB8qbS0hN12T6ox14iMlZmb3gozm6/RYLyEkyHcHeE07it1ZM8vrhRMIjDopkV+1Z/zzuUmulhhi/wtr4Bg7rf74+9EZ+RKCEdGUZLw7duHj0ecyVi/uGZCP7b2Mb++G96sswFxicQ3gEvIvyuA1tQ5pQ8c8BG7VMFXYk53DociozBtxS0mBvJPLJZZ7+/ou1BT8ky366RKxe5MNd021FrPxDOym+JZh+UKsKK0waWSl2wrIhBXOhIFqBEJGfAwkZsFcfHe204s1JnHEnOLxEP9qv79JPd4Y06ORpEqnx78C+cnjHgvf2GkFYrSlHU4/5k878eMWYxeQ5e/EgKYb9WGxOD8pJbwyJCQlxRy/UGhqkg5ISldzJRGCaVackcv6oGWFmDQKjGPXiQ+Jd5nSkj2xLwYxhB0k17CZfu9ISqmRV03+mw9ko6MaCKwQsLQd++WHkO0rX9BLTJakMYEleMA5HhwgCMSV3lT/qwyd8FxPImqWkmGkfy7t2TiQm/SFqsbihcfeN8xvmanjGHb05QwFuDcg7uuD+xlOdoPeg=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(54906003)(36756003)(40460700003)(36860700001)(316002)(8936002)(508600001)(86362001)(70206006)(70586007)(81166007)(2616005)(6486002)(966005)(26005)(33656002)(8676002)(4326008)(82310400005)(6862004)(6512007)(83380400001)(336012)(2906002)(47076005)(356005)(186003)(53546011)(6506007)(30864003)(5660300002)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 13:02:28.3373
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c19f92b3-b4f4-4b86-00ca-08da1e17076e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2276

Hi Peng,

> On 14 Apr 2022, at 08:44, Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>=20
> From: Peng Fan <peng.fan@nxp.com>
>=20
> The i.MX LPUART Documentation:
> https://www.nxp.com/webapp/Download?colCode=3DIMX8QMIEC
> Chatper 13.6 Low Power Universal Asynchronous Receiver/
> Transmitter (LPUART)
>=20
> Tested-by: Henry Wang <Henry.Wang@arm.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Asked-by: Bertrand Marquis <bertrand.marquis@arm.com>

I did not check the code but enough people went through this so I think it =
can be merged.

Cheers
Bertrand

> ---
> xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
> xen/drivers/char/Kconfig              |   7 +
> xen/drivers/char/Makefile             |   1 +
> xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
> 4 files changed, 348 insertions(+)
> create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
> create mode 100644 xen/drivers/char/imx-lpuart.c
>=20
> diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include=
/asm/imx-lpuart.h
> new file mode 100644
> index 0000000000..fe859045dc
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/imx-lpuart.h
> @@ -0,0 +1,64 @@
> +/*
> + * xen/arch/arm/include/asm/imx-lpuart.h
> + *
> + * Common constant definition between early printk and the LPUART driver
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ASM_ARM_IMX_LPUART_H__
> +#define __ASM_ARM_IMX_LPUART_H__
> +
> +/* 32-bit register definition */
> +#define UARTBAUD          (0x10)
> +#define UARTSTAT          (0x14)
> +#define UARTCTRL          (0x18)
> +#define UARTDATA          (0x1C)
> +#define UARTMATCH         (0x20)
> +#define UARTMODIR         (0x24)
> +#define UARTFIFO          (0x28)
> +#define UARTWATER         (0x2c)
> +
> +#define UARTSTAT_TDRE     BIT(23, UL)
> +#define UARTSTAT_TC       BIT(22, UL)
> +#define UARTSTAT_RDRF     BIT(21, UL)
> +#define UARTSTAT_OR       BIT(19, UL)
> +
> +#define UARTBAUD_OSR_SHIFT    (24)
> +#define UARTBAUD_OSR_MASK     (0x1f)
> +#define UARTBAUD_SBR_MASK     (0x1fff)
> +#define UARTBAUD_BOTHEDGE     (0x00020000)
> +#define UARTBAUD_TDMAE        (0x00800000)
> +#define UARTBAUD_RDMAE        (0x00200000)
> +
> +#define UARTCTRL_TIE      BIT(23, UL)
> +#define UARTCTRL_TCIE     BIT(22, UL)
> +#define UARTCTRL_RIE      BIT(21, UL)
> +#define UARTCTRL_ILIE     BIT(20, UL)
> +#define UARTCTRL_TE       BIT(19, UL)
> +#define UARTCTRL_RE       BIT(18, UL)
> +#define UARTCTRL_M        BIT(4, UL)
> +
> +#define UARTWATER_RXCNT_OFF     24
> +
> +#endif /* __ASM_ARM_IMX_LPUART_H__ */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> index 2ff5b288e2..e5f7b1d8eb 100644
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -13,6 +13,13 @@ config HAS_CADENCE_UART
> 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
> 	  based board, say Y.
>=20
> +config HAS_IMX_LPUART
> +	bool "i.MX LPUART driver"
> +	default y
> +	depends on ARM_64
> +	help
> +	  This selects the i.MX LPUART. If you have i.MX8QM based board, say Y.
> +
> config HAS_MVEBU
> 	bool "Marvell MVEBU UART driver"
> 	default y
> diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
> index 7c646d771c..14e67cf072 100644
> --- a/xen/drivers/char/Makefile
> +++ b/xen/drivers/char/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) +=3D mvebu-uart.o
> obj-$(CONFIG_HAS_OMAP) +=3D omap-uart.o
> obj-$(CONFIG_HAS_SCIF) +=3D scif-uart.o
> obj-$(CONFIG_HAS_EHCI) +=3D ehci-dbgp.o
> +obj-$(CONFIG_HAS_IMX_LPUART) +=3D imx-lpuart.o
> obj-$(CONFIG_ARM) +=3D arm-uart.o
> obj-y +=3D serial.o
> obj-$(CONFIG_XEN_GUEST) +=3D xen_pv_console.o
> diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.=
c
> new file mode 100644
> index 0000000000..df44f91e5d
> --- /dev/null
> +++ b/xen/drivers/char/imx-lpuart.c
> @@ -0,0 +1,276 @@
> +/*
> + * xen/drivers/char/imx-lpuart.c
> + *
> + * Driver for i.MX LPUART.
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <xen/errno.h>
> +#include <xen/init.h>
> +#include <xen/irq.h>
> +#include <xen/mm.h>
> +#include <xen/serial.h>
> +#include <asm/device.h>
> +#include <asm/imx-lpuart.h>
> +#include <asm/io.h>
> +
> +#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
> +#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + of=
f)
> +
> +static struct imx_lpuart {
> +    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
> +    uint32_t irq;
> +    char __iomem *regs;
> +    struct irqaction irqaction;
> +    struct vuart_info vuart;
> +} imx8_com;
> +
> +static void imx_lpuart_interrupt(int irq, void *data,
> +                                 struct cpu_user_regs *regs)
> +{
> +    struct serial_port *port =3D data;
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t sts, rxcnt;
> +
> +    sts =3D imx_lpuart_read(uart, UARTSTAT);
> +    rxcnt =3D imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
> +
> +    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
> +	    serial_rx_interrupt(port, regs);
> +
> +    if ( sts & UARTSTAT_TDRE )
> +	    serial_tx_interrupt(port, regs);
> +
> +    imx_lpuart_write(uart, UARTSTAT, sts);
> +}
> +
> +static void __init imx_lpuart_init_preirq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t ctrl, old_ctrl, bd;
> +
> +    old_ctrl =3D imx_lpuart_read(uart, UARTCTRL);
> +    ctrl =3D (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
> +    bd =3D imx_lpuart_read(uart, UARTBAUD);
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
> +	    cpu_relax();
> +
> +    /* Disable transmit and receive */
> +    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL=
_RE));
> +
> +    /* Reuse firmware baudrate settings, only disable DMA here */
> +    bd &=3D ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
> +
> +    imx_lpuart_write(uart, UARTMODIR, 0);
> +    imx_lpuart_write(uart, UARTBAUD, bd);
> +    imx_lpuart_write(uart, UARTCTRL, ctrl);
> +}
> +
> +static void __init imx_lpuart_init_postirq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t temp;
> +
> +    uart->irqaction.handler =3D imx_lpuart_interrupt;
> +    uart->irqaction.name =3D "imx_lpuart";
> +    uart->irqaction.dev_id =3D port;
> +
> +    if ( setup_irq(uart->irq, 0, &uart->irqaction) !=3D 0 )
> +    {
> +        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
> +                uart->irq);
> +        return;
> +    }
> +
> +    /* Enable interrupts */
> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> +    temp |=3D (UARTCTRL_RIE | UARTCTRL_TIE);
> +    temp |=3D UARTCTRL_ILIE;
> +    imx_lpuart_write(uart, UARTCTRL, temp);
> +}
> +
> +static void imx_lpuart_suspend(struct serial_port *port)
> +{
> +    BUG();
> +}
> +
> +static void imx_lpuart_resume(struct serial_port *port)
> +{
> +    BUG();
> +}
> +
> +static int imx_lpuart_tx_ready(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +
> +    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
> +}
> +
> +static void imx_lpuart_putc(struct serial_port *port, char c)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
> +        cpu_relax();
> +
> +    imx_lpuart_write(uart, UARTDATA, c);
> +}
> +
> +static int imx_lpuart_getc(struct serial_port *port, char *pc)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    int ch;
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
> +	    return 0;
> +
> +    ch =3D imx_lpuart_read(uart, UARTDATA);
> +    *pc =3D ch & 0xff;
> +
> +    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
> +        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
> +
> +    return 1;
> +}
> +
> +static int __init imx_lpuart_irq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +
> +    return ((uart->irq > 0) ? uart->irq : -1);
> +}
> +
> +static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port=
 *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +
> +    return &uart->vuart;
> +}
> +
> +static void imx_lpuart_start_tx(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t temp;
> +
> +    temp =3D imx_lpuart_read(uart, UARTSTAT);
> +    /* Wait until empty */
> +    while ( !(temp & UARTSTAT_TDRE) )
> +	    cpu_relax();
> +
> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> +    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
> +}
> +
> +static void imx_lpuart_stop_tx(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart =3D port->uart;
> +    uint32_t temp;
> +
> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> +    temp &=3D ~(UARTCTRL_TIE | UARTCTRL_TCIE);
> +    imx_lpuart_write(uart, UARTCTRL, temp);
> +}
> +
> +static struct uart_driver __read_mostly imx_lpuart_driver =3D {
> +    .init_preirq =3D imx_lpuart_init_preirq,
> +    .init_postirq =3D imx_lpuart_init_postirq,
> +    .endboot =3D NULL,
> +    .suspend =3D imx_lpuart_suspend,
> +    .resume =3D imx_lpuart_resume,
> +    .tx_ready =3D imx_lpuart_tx_ready,
> +    .putc =3D imx_lpuart_putc,
> +    .getc =3D imx_lpuart_getc,
> +    .irq =3D imx_lpuart_irq,
> +    .start_tx =3D imx_lpuart_start_tx,
> +    .stop_tx =3D imx_lpuart_stop_tx,
> +    .vuart_info =3D imx_lpuart_vuart_info,
> +};
> +
> +static int __init imx_lpuart_init(struct dt_device_node *dev,
> +                                  const void *data)
> +{
> +    const char *config =3D data;
> +    struct imx_lpuart *uart;
> +    int res;
> +    u64 addr, size;
> +
> +    if ( strcmp(config, "") )
> +        printk("WARNING: UART configuration is not supported\n");
> +
> +    uart =3D &imx8_com;
> +
> +    uart->baud =3D 115200;
> +    uart->data_bits =3D 8;
> +    uart->parity =3D 0;
> +    uart->stop_bits =3D 1;
> +
> +    res =3D dt_device_get_address(dev, 0, &addr, &size);
> +    if ( res )
> +    {
> +        printk("imx8-lpuart: Unable to retrieve the base"
> +               " address of the UART\n");
> +        return res;
> +    }
> +
> +    res =3D platform_get_irq(dev, 0);
> +    if ( res < 0 )
> +    {
> +        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
> +        return -EINVAL;
> +    }
> +    uart->irq =3D res;
> +
> +    uart->regs =3D ioremap_nocache(addr, size);
> +    if ( !uart->regs )
> +    {
> +        printk("imx8-lpuart: Unable to map the UART memory\n");
> +        return -ENOMEM;
> +    }
> +
> +    uart->vuart.base_addr =3D addr;
> +    uart->vuart.size =3D size;
> +    uart->vuart.data_off =3D UARTDATA;
> +    /* tmp from uboot */
> +    uart->vuart.status_off =3D UARTSTAT;
> +    uart->vuart.status =3D UARTSTAT_TDRE;
> +
> +    /* Register with generic serial driver */
> +    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
> +
> +    dt_device_set_used_by(dev, DOMID_XEN);
> +
> +    return 0;
> +}
> +
> +static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
=3D
> +{
> +    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
> +    { /* sentinel */ },
> +};
> +
> +DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
> +    .dt_match =3D imx_lpuart_dt_compat,
> +    .init =3D imx_lpuart_init,
> +DT_DEVICE_END
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> --=20
> 2.35.1
>=20



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:03:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:03:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304750.519483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez8c-0000HT-70; Thu, 14 Apr 2022 13:03:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304750.519483; Thu, 14 Apr 2022 13:03:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nez8c-0000HM-3t; Thu, 14 Apr 2022 13:03:54 +0000
Received: by outflank-mailman (input) for mailman id 304750;
 Thu, 14 Apr 2022 13:03:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gNLD=UY=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nez8a-000842-FD
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 13:03:52 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2062d.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::62d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 550a9c7c-bbf3-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 15:03:52 +0200 (CEST)
Received: from DU2PR04CA0340.eurprd04.prod.outlook.com (2603:10a6:10:2b4::12)
 by AM4PR0802MB2340.eurprd08.prod.outlook.com (2603:10a6:200:60::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 14 Apr
 2022 13:03:47 +0000
Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b4:cafe::42) by DU2PR04CA0340.outlook.office365.com
 (2603:10a6:10:2b4::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Thu, 14 Apr 2022 13:03:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 13:03:47 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Thu, 14 Apr 2022 13:03:47 +0000
Received: from 89e0720a6f03.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E1DC4620-9B63-4E86-B544-8687E99A6CF0.1; 
 Thu, 14 Apr 2022 13:03:41 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 89e0720a6f03.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Apr 2022 13:03:41 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24)
 by AM6PR08MB4423.eurprd08.prod.outlook.com (2603:10a6:20b:bf::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr
 2022 13:03:38 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::e05d:b3fc:609a:df20]) by AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::e05d:b3fc:609a:df20%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 13:03:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 550a9c7c-bbf3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2Io7NRahxf4ET9ge18hVG2feNsJfPZHjJC5RcvqMt0k=;
 b=0S3JcKfr5HhxYeUUY0D2e71aA7ysmavRzJok8lvcQIMwBpu2lLXBGDydOvGrkr9syizLAjAtiM0rQqDfmOIxcYBk3YPBzcHQh4hgL2m2Z6JD2iaBCjQLz4fVgJ35Mbfog3uDrgkYEzOvNROdKRqB0oa4zN9yWSP2Ruyq+afILuw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: bb7b441c6c4f8238
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZQyc18mnm1JV+EN4Wn0BkO0vzdnzZELsCn4XqPt81/aenmsJZRWaSUmYtWSxQfNItiONr1PWhNUuWa0KGgdpnWPLt7FgOpaN/4IBzCKVVm9jITtTW3GQkyFQmtKJaPbh5E6MrqeNkKjd9Rx0vQsC3eAhasLLiNhJJeModgX25yLnkV6NRMuMDva0I93NZ5mWEiL2TWKo82Pp80Doy5RtJyVfJMpGGpnZ69wIysL0pPWKJqApgggAloJUB+j1oO6fkRiyRVgkT6jKILCJ2TXX5UJ6HvLabwzNO6m1NNsB/AAAatq6SPpX55Eh9CXHTsHTcnJ1kFsrZJ8UGaQUu1DLQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2Io7NRahxf4ET9ge18hVG2feNsJfPZHjJC5RcvqMt0k=;
 b=XzFtzdPu05Tlse6p4VMyUngj9DMIIiJpy2NEwHb5bcjsBDUXJSYlMYA1qnNue2qzXHBIjPJ3YFdY4ZN+Px4ygSZ+47tqd8Zqa7HNCNdLfrKkHoosvReoTynNEluDTJfvmC72ZtB7oE7rUG9wCxp/GEuAzeW7WeICj+ISZWLEySKS9MflomfBKcALsSsUiZ6Z6QJb0cxsjw0Nxms3Taz4s6zYDOBDeoNB4+6KIbmhScFdW3zeq39lp5Lli40ACqPgNzCah6dd6O7nbcqPv+CJEDZ9xss9OTC/VlU9QzSVPdOprYLzi8uYBUyCZstjN45AjtHPGv5Db6i6sRK+Yz7VwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2Io7NRahxf4ET9ge18hVG2feNsJfPZHjJC5RcvqMt0k=;
 b=0S3JcKfr5HhxYeUUY0D2e71aA7ysmavRzJok8lvcQIMwBpu2lLXBGDydOvGrkr9syizLAjAtiM0rQqDfmOIxcYBk3YPBzcHQh4hgL2m2Z6JD2iaBCjQLz4fVgJ35Mbfog3uDrgkYEzOvNROdKRqB0oa4zN9yWSP2Ruyq+afILuw=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, "julien@xen.org"
	<julien@xen.org>, "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"van.freenix@gmail.com" <van.freenix@gmail.com>, Michal Orzel
	<Michal.Orzel@arm.com>, Peng Fan <peng.fan@nxp.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: Re: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
Thread-Topic: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
Thread-Index: AQHYT83OVuHlhz8E70qIHrv4OCbfQKzvYB0AgAAAZAA=
Date: Thu, 14 Apr 2022 13:03:38 +0000
Message-ID: <D766CA91-29E8-46DE-B27D-E254DB50CE0C@arm.com>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com>
 <20220414074452.14419-2-peng.fan@oss.nxp.com>
 <CB41A35C-2117-4142-BBFC-3B2415F15927@arm.com>
In-Reply-To: <CB41A35C-2117-4142-BBFC-3B2415F15927@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: c3eeb518-8a59-4763-bf0f-08da1e17369e
x-ms-traffictypediagnostic:
	AM6PR08MB4423:EE_|DB5EUR03FT061:EE_|AM4PR0802MB2340:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR0802MB2340C424FD95BAF7919282619DEF9@AM4PR0802MB2340.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 sn2I44l1LfFz8GGzF9CukVSUU85Xl1y522esODQMHkJzHMvgtt6Qtj3kqjlAhEku5jehIQqTYpYcB/6ImMZYqbmVLwm51FTv6vlt3nworiKXwBQ2uAYVxbuYfOYMNBIJaQMm/TXZtIvGOys50PQOj7to/DbhA7yDblXF8kGYxEasa5IpB4fPqdBXGfe1nADLhLBlXRzhSAN8Y6TpH00OYVx7mPrqRNJkZcKFsbJVoiuhYe0V82D4NG6Lz5VfbkAs8nZe7iZdpMvLjFEx50nQinp49mHqimaSeSQ8r6JvGem8uCIiYUEvVQPg+CyO8Jt8cpvAx8Uki0IiZ/KCmluuduknqDNT3Z63RBEoDMvOJOXS/TFbKpEi+JD54f6YuPJBqfX6isMZiNefXbQmHG38OJ9svSTxRJJyzKRh/2PyrociDa2qhsGkHaYmztOu4RK7lF5Ro7+iotLvoko5QxM9abpn/SO6F/BdlHdd3FhUl1WiroCInPU4zL5SwQuImT1E6XjPC9pvXFy97aWAVDSsFv6mgzoQ4kj1iXeJh9QnJBTZ1XCuaSncB2Ybxh0XfSzrzr9ZoGWKih4gXXjOC39yL6HIUPmskJj7O0UUmxy00CNgz5DKnyt6XijWhk6vmwWTENjHNS/yy9ANJrlOcslcW67PElcAHaiHd70x2qBR5Nt9M0sfMI7RFiTVvrkvnrtCcL9fkIxDansvMJ4g+DUwXftM1Wx6gcmC40Vxxsw6ZwKUQaVIpx6/KuVaugicd4Dca7e0GfOtivPyJXNVIOYm7lsEzkYhmB7K/VqoB6aX1N7X7qxdyrjNJTL05824UpiPHQ32I3YDHHBL5SqqkfgwsraI6L6towkyBjNizrpnLmc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(83380400001)(91956017)(966005)(86362001)(30864003)(6486002)(7416002)(36756003)(6506007)(6916009)(508600001)(2906002)(316002)(64756008)(4326008)(66946007)(8676002)(66476007)(66556008)(66446008)(76116006)(6512007)(71200400001)(26005)(186003)(8936002)(122000001)(54906003)(53546011)(2616005)(38070700005)(38100700002)(33656002)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0F1412F5060024499743C14D7B96707B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4423
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	dbec0b84-8caa-4e41-6b0b-08da1e173165
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0bXkZxRoxGHVpwPIWzJzV7f/E89UMtoIE3fXsiaLiUqzvI+cOi8VF9Tkk9/QKeO1XkrbTyXN+oxysC8MEyFxhzzq/fBOek19rbOKnHRk7f8km9MlxTld2dwfZK0CWWcOGyfFxB0mWn9nh8geQZC52CJUWBWY4vSn+15hIeTJgUQs71nZaYFlIbHqz+FyErJ6BpNZoCMQSpYXNCirnUVLIByAQIbPUZ83SGy/zXmb8qKPclO0hGsmqiwQ6oUvdMHWl2y0nudtiMtoXYx0/nuT3qPAFWcxAeeff7cDkMl7TDE5yB/mC08z1ny9nbOsVY4S177C4fDX5cJ+pYWArxCEeVyfS1tWePeWm7hc82TiykDcFTNtzDE3Z5a6Dk+XBmwrQLWXVOOkHAvZ9OpNOXvYx2z6GCJ++sHtp+yXDVhCJmkJy++/BKHRPnN7F4nQhvUyVxf9fnCVoXUZ0jEMT2jIGxidXcqct1vsLwIXK6i2pFDu8avI6Tz2Bz1yWsxtjIWx59XWkOe/TIGsySf/HdAKhLR299dFNAc8JV9S8iO5IK1+ZKrz+GMbTo6cp7DYzlrpbhDqVumJ0a4lC0NchWupAbOzi/f/B1OWj3HLo5dhnUOS/ZSsFyDUpWAFYpvcOpJSnwTGYX/T9MTLHyEbrTnb+FJlE7idNLrhaN3BkusbTv7iAk62zVtkvXbYAJ78le1xTG7nIzyFL3DcAKg2i1GbDFl2XLkeppFB4jauHrg8B3MrrwX8R/cCJq+cRNkBwquqKSJOvvL4sTQYnqg1wT8xaXchQE2eceZiuHEtjogtbiE=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(2906002)(966005)(36756003)(40460700003)(36860700001)(6862004)(4326008)(6486002)(6506007)(6512007)(26005)(508600001)(186003)(53546011)(33656002)(54906003)(2616005)(316002)(82310400005)(47076005)(83380400001)(70586007)(8676002)(70206006)(336012)(86362001)(356005)(5660300002)(8936002)(81166007)(30864003)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 13:03:47.5644
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c3eeb518-8a59-4763-bf0f-08da1e17369e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2340



> On 14 Apr 2022, at 14:02, Bertrand Marquis <bertrand.marquis@arm.com> wro=
te:
>=20
> Hi Peng,
>=20
>> On 14 Apr 2022, at 08:44, Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>>=20
>> From: Peng Fan <peng.fan@nxp.com>
>>=20
>> The i.MX LPUART Documentation:
>> https://www.nxp.com/webapp/Download?colCode=3DIMX8QMIEC
>> Chatper 13.6 Low Power Universal Asynchronous Receiver/
>> Transmitter (LPUART)
>>=20
>> Tested-by: Henry Wang <Henry.Wang@arm.com>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Asked-by: Bertrand Marquis <bertrand.marquis@arm.com>
Acked-by: Bertrand Marquis <bertrand.marquis@arm.com>

(Auto correct, sorry for that)

Bertrand

>=20
> I did not check the code but enough people went through this so I think i=
t can be merged.
>=20
> Cheers
> Bertrand
>=20
>> ---
>> xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
>> xen/drivers/char/Kconfig              |   7 +
>> xen/drivers/char/Makefile             |   1 +
>> xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
>> 4 files changed, 348 insertions(+)
>> create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
>> create mode 100644 xen/drivers/char/imx-lpuart.c
>>=20
>> diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/includ=
e/asm/imx-lpuart.h
>> new file mode 100644
>> index 0000000000..fe859045dc
>> --- /dev/null
>> +++ b/xen/arch/arm/include/asm/imx-lpuart.h
>> @@ -0,0 +1,64 @@
>> +/*
>> + * xen/arch/arm/include/asm/imx-lpuart.h
>> + *
>> + * Common constant definition between early printk and the LPUART drive=
r
>> + *
>> + * Peng Fan <peng.fan@nxp.com>
>> + * Copyright 2022 NXP
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#ifndef __ASM_ARM_IMX_LPUART_H__
>> +#define __ASM_ARM_IMX_LPUART_H__
>> +
>> +/* 32-bit register definition */
>> +#define UARTBAUD          (0x10)
>> +#define UARTSTAT          (0x14)
>> +#define UARTCTRL          (0x18)
>> +#define UARTDATA          (0x1C)
>> +#define UARTMATCH         (0x20)
>> +#define UARTMODIR         (0x24)
>> +#define UARTFIFO          (0x28)
>> +#define UARTWATER         (0x2c)
>> +
>> +#define UARTSTAT_TDRE     BIT(23, UL)
>> +#define UARTSTAT_TC       BIT(22, UL)
>> +#define UARTSTAT_RDRF     BIT(21, UL)
>> +#define UARTSTAT_OR       BIT(19, UL)
>> +
>> +#define UARTBAUD_OSR_SHIFT    (24)
>> +#define UARTBAUD_OSR_MASK     (0x1f)
>> +#define UARTBAUD_SBR_MASK     (0x1fff)
>> +#define UARTBAUD_BOTHEDGE     (0x00020000)
>> +#define UARTBAUD_TDMAE        (0x00800000)
>> +#define UARTBAUD_RDMAE        (0x00200000)
>> +
>> +#define UARTCTRL_TIE      BIT(23, UL)
>> +#define UARTCTRL_TCIE     BIT(22, UL)
>> +#define UARTCTRL_RIE      BIT(21, UL)
>> +#define UARTCTRL_ILIE     BIT(20, UL)
>> +#define UARTCTRL_TE       BIT(19, UL)
>> +#define UARTCTRL_RE       BIT(18, UL)
>> +#define UARTCTRL_M        BIT(4, UL)
>> +
>> +#define UARTWATER_RXCNT_OFF     24
>> +
>> +#endif /* __ASM_ARM_IMX_LPUART_H__ */
>> +
>> +/*
>> + * Local variables:
>> + * mode: C
>> + * c-file-style: "BSD"
>> + * c-basic-offset: 4
>> + * indent-tabs-mode: nil
>> + * End:
>> + */
>> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
>> index 2ff5b288e2..e5f7b1d8eb 100644
>> --- a/xen/drivers/char/Kconfig
>> +++ b/xen/drivers/char/Kconfig
>> @@ -13,6 +13,13 @@ config HAS_CADENCE_UART
>> 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
>> 	  based board, say Y.
>>=20
>> +config HAS_IMX_LPUART
>> +	bool "i.MX LPUART driver"
>> +	default y
>> +	depends on ARM_64
>> +	help
>> +	  This selects the i.MX LPUART. If you have i.MX8QM based board, say Y=
.
>> +
>> config HAS_MVEBU
>> 	bool "Marvell MVEBU UART driver"
>> 	default y
>> diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
>> index 7c646d771c..14e67cf072 100644
>> --- a/xen/drivers/char/Makefile
>> +++ b/xen/drivers/char/Makefile
>> @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) +=3D mvebu-uart.o
>> obj-$(CONFIG_HAS_OMAP) +=3D omap-uart.o
>> obj-$(CONFIG_HAS_SCIF) +=3D scif-uart.o
>> obj-$(CONFIG_HAS_EHCI) +=3D ehci-dbgp.o
>> +obj-$(CONFIG_HAS_IMX_LPUART) +=3D imx-lpuart.o
>> obj-$(CONFIG_ARM) +=3D arm-uart.o
>> obj-y +=3D serial.o
>> obj-$(CONFIG_XEN_GUEST) +=3D xen_pv_console.o
>> diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart=
.c
>> new file mode 100644
>> index 0000000000..df44f91e5d
>> --- /dev/null
>> +++ b/xen/drivers/char/imx-lpuart.c
>> @@ -0,0 +1,276 @@
>> +/*
>> + * xen/drivers/char/imx-lpuart.c
>> + *
>> + * Driver for i.MX LPUART.
>> + *
>> + * Peng Fan <peng.fan@nxp.com>
>> + * Copyright 2022 NXP
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#include <xen/errno.h>
>> +#include <xen/init.h>
>> +#include <xen/irq.h>
>> +#include <xen/mm.h>
>> +#include <xen/serial.h>
>> +#include <asm/device.h>
>> +#include <asm/imx-lpuart.h>
>> +#include <asm/io.h>
>> +
>> +#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
>> +#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + o=
ff)
>> +
>> +static struct imx_lpuart {
>> +    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
>> +    uint32_t irq;
>> +    char __iomem *regs;
>> +    struct irqaction irqaction;
>> +    struct vuart_info vuart;
>> +} imx8_com;
>> +
>> +static void imx_lpuart_interrupt(int irq, void *data,
>> +                                 struct cpu_user_regs *regs)
>> +{
>> +    struct serial_port *port =3D data;
>> +    struct imx_lpuart *uart =3D port->uart;
>> +    uint32_t sts, rxcnt;
>> +
>> +    sts =3D imx_lpuart_read(uart, UARTSTAT);
>> +    rxcnt =3D imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
>> +
>> +    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
>> +	    serial_rx_interrupt(port, regs);
>> +
>> +    if ( sts & UARTSTAT_TDRE )
>> +	    serial_tx_interrupt(port, regs);
>> +
>> +    imx_lpuart_write(uart, UARTSTAT, sts);
>> +}
>> +
>> +static void __init imx_lpuart_init_preirq(struct serial_port *port)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +    uint32_t ctrl, old_ctrl, bd;
>> +
>> +    old_ctrl =3D imx_lpuart_read(uart, UARTCTRL);
>> +    ctrl =3D (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
>> +    bd =3D imx_lpuart_read(uart, UARTBAUD);
>> +
>> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
>> +	    cpu_relax();
>> +
>> +    /* Disable transmit and receive */
>> +    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTR=
L_RE));
>> +
>> +    /* Reuse firmware baudrate settings, only disable DMA here */
>> +    bd &=3D ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
>> +
>> +    imx_lpuart_write(uart, UARTMODIR, 0);
>> +    imx_lpuart_write(uart, UARTBAUD, bd);
>> +    imx_lpuart_write(uart, UARTCTRL, ctrl);
>> +}
>> +
>> +static void __init imx_lpuart_init_postirq(struct serial_port *port)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +    uint32_t temp;
>> +
>> +    uart->irqaction.handler =3D imx_lpuart_interrupt;
>> +    uart->irqaction.name =3D "imx_lpuart";
>> +    uart->irqaction.dev_id =3D port;
>> +
>> +    if ( setup_irq(uart->irq, 0, &uart->irqaction) !=3D 0 )
>> +    {
>> +        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
>> +                uart->irq);
>> +        return;
>> +    }
>> +
>> +    /* Enable interrupts */
>> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
>> +    temp |=3D (UARTCTRL_RIE | UARTCTRL_TIE);
>> +    temp |=3D UARTCTRL_ILIE;
>> +    imx_lpuart_write(uart, UARTCTRL, temp);
>> +}
>> +
>> +static void imx_lpuart_suspend(struct serial_port *port)
>> +{
>> +    BUG();
>> +}
>> +
>> +static void imx_lpuart_resume(struct serial_port *port)
>> +{
>> +    BUG();
>> +}
>> +
>> +static int imx_lpuart_tx_ready(struct serial_port *port)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +
>> +    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
>> +}
>> +
>> +static void imx_lpuart_putc(struct serial_port *port, char c)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +
>> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
>> +        cpu_relax();
>> +
>> +    imx_lpuart_write(uart, UARTDATA, c);
>> +}
>> +
>> +static int imx_lpuart_getc(struct serial_port *port, char *pc)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +    int ch;
>> +
>> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
>> +	    return 0;
>> +
>> +    ch =3D imx_lpuart_read(uart, UARTDATA);
>> +    *pc =3D ch & 0xff;
>> +
>> +    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
>> +        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
>> +
>> +    return 1;
>> +}
>> +
>> +static int __init imx_lpuart_irq(struct serial_port *port)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +
>> +    return ((uart->irq > 0) ? uart->irq : -1);
>> +}
>> +
>> +static const struct vuart_info *imx_lpuart_vuart_info(struct serial_por=
t *port)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +
>> +    return &uart->vuart;
>> +}
>> +
>> +static void imx_lpuart_start_tx(struct serial_port *port)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +    uint32_t temp;
>> +
>> +    temp =3D imx_lpuart_read(uart, UARTSTAT);
>> +    /* Wait until empty */
>> +    while ( !(temp & UARTSTAT_TDRE) )
>> +	    cpu_relax();
>> +
>> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
>> +    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
>> +}
>> +
>> +static void imx_lpuart_stop_tx(struct serial_port *port)
>> +{
>> +    struct imx_lpuart *uart =3D port->uart;
>> +    uint32_t temp;
>> +
>> +    temp =3D imx_lpuart_read(uart, UARTCTRL);
>> +    temp &=3D ~(UARTCTRL_TIE | UARTCTRL_TCIE);
>> +    imx_lpuart_write(uart, UARTCTRL, temp);
>> +}
>> +
>> +static struct uart_driver __read_mostly imx_lpuart_driver =3D {
>> +    .init_preirq =3D imx_lpuart_init_preirq,
>> +    .init_postirq =3D imx_lpuart_init_postirq,
>> +    .endboot =3D NULL,
>> +    .suspend =3D imx_lpuart_suspend,
>> +    .resume =3D imx_lpuart_resume,
>> +    .tx_ready =3D imx_lpuart_tx_ready,
>> +    .putc =3D imx_lpuart_putc,
>> +    .getc =3D imx_lpuart_getc,
>> +    .irq =3D imx_lpuart_irq,
>> +    .start_tx =3D imx_lpuart_start_tx,
>> +    .stop_tx =3D imx_lpuart_stop_tx,
>> +    .vuart_info =3D imx_lpuart_vuart_info,
>> +};
>> +
>> +static int __init imx_lpuart_init(struct dt_device_node *dev,
>> +                                  const void *data)
>> +{
>> +    const char *config =3D data;
>> +    struct imx_lpuart *uart;
>> +    int res;
>> +    u64 addr, size;
>> +
>> +    if ( strcmp(config, "") )
>> +        printk("WARNING: UART configuration is not supported\n");
>> +
>> +    uart =3D &imx8_com;
>> +
>> +    uart->baud =3D 115200;
>> +    uart->data_bits =3D 8;
>> +    uart->parity =3D 0;
>> +    uart->stop_bits =3D 1;
>> +
>> +    res =3D dt_device_get_address(dev, 0, &addr, &size);
>> +    if ( res )
>> +    {
>> +        printk("imx8-lpuart: Unable to retrieve the base"
>> +               " address of the UART\n");
>> +        return res;
>> +    }
>> +
>> +    res =3D platform_get_irq(dev, 0);
>> +    if ( res < 0 )
>> +    {
>> +        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
>> +        return -EINVAL;
>> +    }
>> +    uart->irq =3D res;
>> +
>> +    uart->regs =3D ioremap_nocache(addr, size);
>> +    if ( !uart->regs )
>> +    {
>> +        printk("imx8-lpuart: Unable to map the UART memory\n");
>> +        return -ENOMEM;
>> +    }
>> +
>> +    uart->vuart.base_addr =3D addr;
>> +    uart->vuart.size =3D size;
>> +    uart->vuart.data_off =3D UARTDATA;
>> +    /* tmp from uboot */
>> +    uart->vuart.status_off =3D UARTSTAT;
>> +    uart->vuart.status =3D UARTSTAT_TDRE;
>> +
>> +    /* Register with generic serial driver */
>> +    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
>> +
>> +    dt_device_set_used_by(dev, DOMID_XEN);
>> +
>> +    return 0;
>> +}
>> +
>> +static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
=3D
>> +{
>> +    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
>> +    { /* sentinel */ },
>> +};
>> +
>> +DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
>> +    .dt_match =3D imx_lpuart_dt_compat,
>> +    .init =3D imx_lpuart_init,
>> +DT_DEVICE_END
>> +
>> +/*
>> + * Local variables:
>> + * mode: C
>> + * c-file-style: "BSD"
>> + * c-basic-offset: 4
>> + * indent-tabs-mode: nil
>> + * End:
>> + */
>> --=20
>> 2.35.1
>>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:19:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:19:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304760.519494 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezNJ-0002Aj-Lq; Thu, 14 Apr 2022 13:19:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304760.519494; Thu, 14 Apr 2022 13:19:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezNJ-0002Ac-Hw; Thu, 14 Apr 2022 13:19:05 +0000
Received: by outflank-mailman (input) for mailman id 304760;
 Thu, 14 Apr 2022 13:19:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gNLD=UY=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nezNH-0002AW-Bi
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 13:19:03 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20614.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::614])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a2f390e-bbf5-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 15:18:52 +0200 (CEST)
Received: from AM5P194CA0023.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::33)
 by VI1PR0801MB1773.eurprd08.prod.outlook.com (2603:10a6:800:5c::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr
 2022 13:18:41 +0000
Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:8f:cafe::f1) by AM5P194CA0023.outlook.office365.com
 (2603:10a6:203:8f::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Thu, 14 Apr 2022 13:18:41 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 13:18:41 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Thu, 14 Apr 2022 13:18:40 +0000
Received: from 50866bb17fc4.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FE362ABC-E18F-42D3-9F4A-1533A044DBAF.1; 
 Thu, 14 Apr 2022 13:18:34 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 50866bb17fc4.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Apr 2022 13:18:34 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24)
 by GV2PR08MB8076.eurprd08.prod.outlook.com (2603:10a6:150:7a::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.29; Thu, 14 Apr
 2022 13:18:30 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::e05d:b3fc:609a:df20]) by AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::e05d:b3fc:609a:df20%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 13:18:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a2f390e-bbf5-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fygycZQNB6jKUTy5lFMUwvzRm8/tVyCQEmLeBeAetm4=;
 b=lkMA429Zez6f9P5HkN9xSd2VM6QBdgFM1TDDYfEbej2w+oTj6xhsPtPqST5DHYNV9f3Zkf0VwZu5ds07J9a8bwB51cVmxuJRZ3N2zj0ARuiNFHm7vMl1K8Pg3S1yoPTmH6eEHjXU8C8ifwSObQGAm55TFVKV1i7D8itzqWrXxcg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0e14f8990e6422d5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YoEyzkBp4z/+oho6XpY0RI/pxun9frYaAfxoCZ3FGm/3mvHnj2gb2Y+APFBGG6UCjw3+2dUvKx7rJlXKlb5EFiIX1VkyLZZ2UQ901PHGXry2YHS30LtCXZF62FKEHBM5DQi4RX5v1gkoNP3P1W7psPix80T37DIagIB0rknqiaMhH0QIoFxeR0gWmoRv3dQvUrovqX3YCU/MbIimH9hDnNqDY4i5nDuvnI1B22qO1CGcffkysmpg41o8k3HJK1iqe823c4Z09VjKH0tcSyxZH8BeW/WUoNN3JvYCHXtf6n+76rhQf2DuPNFplhJ4jKEtOi0TE16NI6kAIFierccOMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fygycZQNB6jKUTy5lFMUwvzRm8/tVyCQEmLeBeAetm4=;
 b=Q62S5o/KfrjR5yQPHhstrTpGgg2FRPXLYqZub/NqID0B71Slu7OllMWqv2LfJDVxSrcFS60Y0e1UWobfehHoShpTrBIoDhSRnrs0nMPk3x12fYFppEkj1RGbLNHSJ8h/sGFWP9uInE1076Vby3rVKwNmkXwn7Q24QW/J0jtiqID/E8BrRv3vxPMWsuDTzhObzAfFGJGb6CasDso75Aw7FP1fvXBg3v+K6N9TfxF5FyYdXdNu3cFJEyljZkZbz8Hl2MIcAT43q1I2/0+LMNbRIXOMPNW7Yd9lnfetdwaOdm6l8OvG5C9hgHqggMhbXvskesNXlt4atGle6YwgvOIFRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fygycZQNB6jKUTy5lFMUwvzRm8/tVyCQEmLeBeAetm4=;
 b=lkMA429Zez6f9P5HkN9xSd2VM6QBdgFM1TDDYfEbej2w+oTj6xhsPtPqST5DHYNV9f3Zkf0VwZu5ds07J9a8bwB51cVmxuJRZ3N2zj0ARuiNFHm7vMl1K8Pg3S1yoPTmH6eEHjXU8C8ifwSObQGAm55TFVKV1i7D8itzqWrXxcg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
Thread-Topic: [PATCH] xen/evtchn: Add design for static event channel
 signaling for domUs..
Thread-Index: AQHYPsy9JkZghYSHXUuV0Y0fm4T+9azm3KwAgAAMjACAA7tTAIAEF8gAgADKVoA=
Date: Thu, 14 Apr 2022 13:18:30 +0000
Message-ID: <BA690DF6-577C-44CD-BB01-2E8B2FCFEFC6@arm.com>
References:
 <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2204081837410.3066615@ubuntu-linux-20-04-desktop>
 <D24074F6-E6CF-440A-9E9B-A10783C273D7@arm.com>
 <alpine.DEB.2.22.394.2204131657200.3066615@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204131657200.3066615@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: b841157a-b698-4559-50b8-08da1e194b40
x-ms-traffictypediagnostic:
	GV2PR08MB8076:EE_|AM5EUR03FT047:EE_|VI1PR0801MB1773:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0801MB1773817FB453325195D5E0289DEF9@VI1PR0801MB1773.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 PDW8sIP0VYkcPVWQIXZcCONjwArqhYHNomcHTEKXAegN8CsibI9xH4E/48XI/d7ujtHB5jFvr6KRw3mRIVvs4I9m4VrsGKb6WCPZA0WT5fwm6SbX+SnzbnjT9xTIi2vJXGNOUeUlQ8b4PgsYwDMkK848CMoGXlepDjiszwSD4/19Ykjqo4rnwUBG+bk6YQsis8JNGjk0ZjyCzcCKFkXLDRyqXIElOGPN9RB1pPcjn+rOO91em5riFS0vxSK34ZpxX3/qxww6VKb37PIZlzFjeWdW9m7BEDl+yOoQOsAp/t9EKcvgILESQHEgWH7/Mo16OoIdUq+73LzXT4cnttnFiu+PAfHDUuRE5J/bn5/Ui56X8OlSCHVVECt22yzSY9aOq7zIEgoDYrKwKsHen7f4U97TpdxcajgP1GP0ums1pehEq+dRpXfHJ4OkeM2x9J2QQN/F6XqLUmhQITO0y29A0gx15yhW9yQ6Gr3YQ4KmUYFsXTXs5bb+cZB3pTkJNYD7era2KdaM/pBzDPIEZlqbgJa1W42Id3N5JBOHc4iFSnjBWWiJbbWLDz8Saa90q+d6eJO9ApbM/OaSr74bArNNSJWsbluD4Rjo9oVIjnrAZkkA4lo1u53N4c1DewNRSmd+Pu5We/OklCWwv2hdWVMsL81iu4aivOfaztlGpKETVA4iUH6ChfHoOZR7+aKT/NAjBSxAdGDaJyqdzB+/SfevUN+LOkRqLXHYZeuT6MRPQcbC+11p67Ow4iCqBaTnswVomPW3m3IYstQpiJLWA1XojuNKpTjxTCLxDLgf5MfAXZDLYNKVnCKxJMGh16/I5EfHLAoG87+G6HnVaeIjvwBCNQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(186003)(66946007)(122000001)(2906002)(36756003)(38100700002)(6512007)(38070700005)(966005)(2616005)(71200400001)(8936002)(26005)(6486002)(508600001)(66446008)(6506007)(66556008)(86362001)(33656002)(8676002)(76116006)(5660300002)(316002)(4326008)(91956017)(83380400001)(66476007)(54906003)(6916009)(64756008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C8C6CD1DB6F8E34EAF8746268E000D1E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8076
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e49470f4-f224-4c3b-0e49-08da1e1944d5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Am9wku8b8qkyektngoUBnIwuXBstI3ebLdwsXYXRqaLgtAXECWIWZwGQv3BxVj05FKW2T68Tb2ulnSjplpgyfKh6s3YF0dNKwWJyue+8VVNrj9iMKP53GCr1RedkjyblznHPWdNklKNUcLbq+GYIs7nUbSG5d3soooJ/AJ3F9OL2dfLnYEDuU1WWyYyQ4OfMSqYFoA7iEIIhbIdaYqJVm+rrVNvi4dZ59EH+fs3jbcn08prj6oXUAYriGhr5j7LUFGhAF1243J47j7LJYbUkEwDk9j+piMk6uu6EQtIkE3LEuEbiYiQ5PS60NoOutRS1I3pkSOX2lToxabYN001HRp8MGcoj//0j04rTocJpTtESnPAM2wLy9qh4CZ/AwiRvFt8j38O9oF1aMNfLZ8VVl6yIckO9NaZY7FW021ZWCtrEqeZxj6eRUrX1AM2X7W24J18vrF3eJiRK0xAoecIc6Zt2E1sNNWYKRGzDQHldcLBKpLmzn/rSfHlXvY+FCF3v7FqJJn4NsFeOar62Y67Rz9FIT5q6fbVl06n5jcdb1H3KHm5fszax6az+6Zg0zsz4yCyzDgbxrBlrmaRKL5uTZKTB3IsxbmdljPKgz77quIv6+harUSOmO4jUm7zIw8muA2JkEH5T+N4euUubgQTJm1OAX3JErLYcJXUh2iAIqXCjwhKdt3N2PbLp+8yXbj6kbPbT6pYri2E1WLDodZhS9mqpl2euZBQkbyk8a8po86wyuv3qdza6ou6YiaF8Md35rZbmKl7Zsp3ZlpQ+emuBLw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(356005)(53546011)(33656002)(6512007)(5660300002)(54906003)(26005)(186003)(36860700001)(47076005)(2616005)(336012)(81166007)(6506007)(83380400001)(86362001)(82310400005)(6486002)(966005)(36756003)(40460700003)(6862004)(70206006)(70586007)(4326008)(8676002)(508600001)(2906002)(316002)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 13:18:41.1243
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b841157a-b698-4559-50b8-08da1e194b40
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1773

Hi Stefano,

> On 14 Apr 2022, at 02:14, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Mon, 11 Apr 2022, Bertrand Marquis wrote:
>> What you mention here is actually combining 2 different solutions inside
>> Xen to build a custom communication solution.
>> My assumption here is that the user will actually create the device tree
>> nodes he wants to do that and we should not create guest node entries
>> as it would enforce some design.
>>=20
>> If everything can be statically defined for Xen then the user can also
>> statically define node entries inside his guest to make use of the event=
s
>> and the shared memories.
>>=20
>> For example one might need more than one event to build a communication
>> system, or more than one shared memory or could build something
>> communicating with multiple guest thus requiring even more events and
>> shared memories.
>=20
> Hi Bertrand, Rahul,
>=20
> If the guests are allowed some level of dynamic discovery, this feature
> is not needed. They can discover the shared memory location from the
> domU device tree, then proceed to allocate evtchns as needed and tell
> the other end the evtchn numbers over shared memory. I already have an
> example of it here:
>=20
> https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/2251030537/Xen+Shar=
ed+Memory+and+Interrupts+Between+VMs
>=20
> What if the guest doesn't support device tree at runtime, like baremetal
> or Zephyr? The shared memory address can be hardcoded or generated from
> device tree at build time. That's no problem. Then, the event channels
> can still be allocated at runtime and passed to the other end over
> shared memory. That's what the example on the wikipage does.
>=20
>=20
> When are static event channels actually useful? When the application
> cannot allocate the event channels at runtime at all. The reason for the
> restriction could be related to safety (no dynamic allocations at
> runtime) or convenience (everything else is fully static, why should the
> event channel numbers be dynamic?)

An other use case here is dom0less: you cannot have dom0 create them.

>=20
> Given the above, I can see why there is no need to describe the static
> event channel info in the domU device tree: static event channels are
> only useful in fully static configurations, and in those configurations
> the domU device tree dynamically generated by Xen is not needed. I can
> see where you are coming from.
>=20
>=20
> The workflow that we have been trying to enable with the System Device
> Tree effort (System Device Tree is similar to a normal Device Tree plus
> the xen,domains nodes) is the following:
>=20
> S-DT ---[lopper]---> Linux DT
>                L--> Zephyr DT ---[Zephyr build]---> Zephyr .h files
>=20
> S-DT contains all the needed information for both the regular Linux DT
> generation and also the Zephyr/RTOS/baremetal header files generation,
> that happens at build time.
>=20
> S-DT is not the same as the Xen device tree, but so far it has been
> conceptually and practically similar. I always imagine that the bindings
> we have in Xen we'll also have corresponding bindings in System Device
> Tree.
>=20
> For this workflow to work S-DT needs all the info so that both Linux DT
> and Zephyr DT and Zephyr .h files can be generated.
>=20
> Does this proposal contain enough information so that Zephyr .h files
> could be statically generated with the event channel numbers and static
> shared memory regions addresses?
>=20
> I am not sure. Maybe not?

Yes it should be possible to have all infos as the integrator will setup th=
e
system and will decide upfront the address and the event(s) number(s).

>=20
>=20
> It is possible that the shared memory usage is so application specific
> that there is no point in even talking about it. But I think that
> introducing a simple bundle of both event channels and shared memory
> would help a lot.
>=20
> Something like the following in the Xen device tree would be enough to
> specify an arbitrary number of event channels connected with the same
> domains sharing the memory region.
>=20
> It looks like that if we did the below, we would carry a lot more useful
> information compared to the original proposal alone. We could add a
> similar xen,notificaiton property to the domU reserved-memory region in
> device tree generated by Xen for consistency, so that everything
> available to the domU is described fully in device tree.
>=20
>=20
>    domU1 {
>        compatible =3D "xen,domain";
>=20
>        /* one sub-node per local event channel */
>        ec1: evtchn@1 {
>            compatible =3D "xen,evtchn-v1";
>            /* local-evtchn link-to-foreign-evtchn */
>            xen,evtchn =3D <0x1 &ec3>
>        };
>        ec2: evtchn@2 {
>            compatible =3D "xen,evtchn-v1";
>            xen,evtchn =3D <0x2 &ec4>
>        };
>        /*
>         * shared memory region between DomU1 and DomU2.
>         */
>        domU1-shared-mem@50000000 {
>            compatible =3D "xen,domain-shared-memory-v1";
>            xen,shm-id =3D <0x1>;
>            xen,shared-mem =3D <0x50000000 0x20000000 0x60000000>;
>            /* this is new */
>            xen,notification =3D <&ec1 &ec2>;
>        }
>    };
>=20
>    domU2 {
>        compatible =3D "xen,domain";
>=20
>        /* one sub-node per local event channel */
>        ec3: evtchn@3 {
>            compatible =3D "xen,evtchn-v1";
>            /* local-evtchn link-to-foreign-evtchn */
>            xen,evtchn =3D <0x3 &ec1>
>        };
>        ec4: evtchn@4 {
>            compatible =3D "xen,evtchn-v1";
>            xen,evtchn =3D <0x4 &ec2>
>        };
>        /*
>         * shared memory region between domU1 and domU2.
>         */
>        domU2-shared-mem@50000000 {
>            compatible =3D "xen,domain-shared-memory-v1";
>            xen,shm-id =3D <0x1>;
>            xen,shared-mem =3D <0x50000000 0x20000000 0x70000000>;
>            /* this is new */
>            xen,notification =3D <&ec3 &ec4>;
>        }
>    };

Few remarks/questions on this:
- this is not a shared memory anymore as you add a notification system to i=
t
- what if someone wants to use only a shared memory, or an event, what shou=
ld xen do ?
- in xen device tree, how do you associate the event with the shared memory=
 ?

>=20
>=20
>=20
> The good thing about this is that:
>=20
> - it is very flexible
> - nothing to do in this series, except switching to the
>  one-subnode-per-evtchn model, which we called 2) in the previous email
> - there were good reasons to use the one-subnode-per-evtchn model anyway
> - the xen,notification property can be added later without issues, after =
Penny's series
>=20
> There are a couple of ways to implement the xen,notification property
> but we don't need to discuss them now.

I think there is something to do here but we need a bit more discussion and=
 this can be done later.
Right now I am not quite sure we will not add something that will end up no=
t being used.

>=20
>=20
> Short Summary
> ------------
> I think it is fine to only introduce the Xen device tree binding for
> static event channels without domU binding, but I prefer if we switched
> to using proposal 2) "one subnode per event channel".

I will let Rahul answer on that.

Cheers
Bertrand




From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:31:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:31:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304765.519504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezZZ-0004Rs-OY; Thu, 14 Apr 2022 13:31:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304765.519504; Thu, 14 Apr 2022 13:31:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezZZ-0004Rl-Ld; Thu, 14 Apr 2022 13:31:45 +0000
Received: by outflank-mailman (input) for mailman id 304765;
 Thu, 14 Apr 2022 13:31:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f0xO=UY=citrix.com=prvs=09619e58f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nezZZ-0004Rf-0E
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 13:31:45 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37c69ede-bbf7-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 15:31:43 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37c69ede-bbf7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649943102;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=wFbRS81tc/ctaXUsSc6IwDd6maKUYxC/XjgjJbUtGdc=;
  b=M2ewaiiYIiLTtuTg3BDK6IR8QiQ1rx/xjDb1dDwGOltoOUhek8sV2Mkl
   BniUAyVtb34KD2eZGtN6CTZ8/xgObWe5F6dQrueDM+WmatAlk2YkDVmWB
   gEdxWgB32GE/4Ju+mRwPg7szqwtkHHRKrlbMdA+1UXXZ7pdR9VDkEe+QZ
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 69362062
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:S6WxnKAUU9HZwRVW/z7jw5YqxClBgxIJ4kV8jS/XYbTApDx2hTRWz
 WofCDzQb/qOajf0edh+bo2yo0gEv5SHxodiQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhNi
 4QQnqG8QDsqZKHAkdxNczp3KyBhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGjWxu3JgQR54yY
 eIzbSczTRjsPCFUP01NGbk4hfyxi3rGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiELH70M3ZtZZL+5g5A2E8vr0wCmhB3dRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqVFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tmuVh6b/PuREDGQ3C94afe51qXHb4
 hA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSLyLdoIuW8ifxw0WirhRdMPS
 BWC0e+2zMUNVEZGkIctO97hYyjU5fWI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5LTlU4OAbGkP3G/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chYwJIbX7ZEfFTi3Vw==
IronPort-HdrOrdr: A9a23:Iqzgaq3cN69pkUgWRohXDgqjBVZyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5Wo3SIDUO2VHYVr2KiLGC/9SOIVyaygcw79
 YFT0E6MqyOMbEYt7eL3ODbKadZ/DDvysnB7o2yvhQdLz2CKZsQlDuRYjzrY3GeLzM2fKbReq
 Dsgfau8FGbCAoqh4mAdzI4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P70rhJJGdZQ8qPSMexnwqDL3QSuvyAfcZek600ykke+C3Fxy3pDsRKA1
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="69362062"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RMVLdB7XeTsmkz5H0I6UxpmDUWDUUaEn1XwI3UG0mufFstPfuQkPqvB4s9Rwpr70P17FGsD9251XFEx+xONR5S2/jEL0s6Cz/H91B/pGrdOHL3BNzQd4A58C2eoM93r/4M5+nFHFDWd5spsPeaGofTrQQYuYuMksVTcd6bEcs0Bi0AuycW7ltu23ptaEASxk9Ifv5oFP+Rg/X5MfhLYXoyUJJnHNBgYmvBpgFcTHj6CuDd28ufTQ7AhXHeSOznk02P8xeKyH2xAe7uL1rztFd6jE5lCts9u3Tt3SGECIngnwY5bm2RMvk8S7qC0c/mNAFDh/ZUM3P/C7KWMDUe5+cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SwbesW5ci+kI4wB9TlzPPdzmxtvc5rCl/tLeAoijQ+4=;
 b=ilhd2DX9kQBZlpanm/WHNRrZUsP01XYKp0Kolewut7QxdgboMhcI/cFHmKRLgf7DVhR8aP6z1xDIhf8QOFsWKwBSdBx5VXi/UKFyU2YY4sE5qpMpuVfYCG6bEak7MRRzicstOpkQsNGx+7XHm/GNmW2g9xY5fGDdUVX1COIp5kVFdfyx3CLmKQVTEdqkLm6lX4yH+2QuJUjSjEbLDfYyo4YJfaFyzwLQ9fSlW+Go07Oc9D543IgRey1S89hXmycl/YhG0sxoDMT0Q/5v0afTTclwdwPQ8DKrQNFzD9RpiGl9gJYPa+TerFsDf0akc0yafodaNYJtHgo+ToEKQyQ4bw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SwbesW5ci+kI4wB9TlzPPdzmxtvc5rCl/tLeAoijQ+4=;
 b=QuoE1ljBiUM+gcbhBk9E5ZWMmBceG6aA4mCuUZL3745YQY3Iq8TrHvxmd42wTix2jg+BeUNtlB2mkFnUIakGqYYQCmGLAHNziUq89X8xRRGF1BqwDG1zeJ/oLXJmAqgcPTPTcysHvt2R4JBxPJ+iQHkd8qFt/R4CnJLXKMO81Co=
Date: Thu, 14 Apr 2022 15:31:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] x86: improve .debug_line contents for assembly
 sources
Message-ID: <YlgiLhvsKVYKKvrr@Air-de-Roger>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
 <YlgWKGmR+u41zSsw@Air-de-Roger>
 <04f9bd9c-70da-0966-afa6-96f81e290204@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <04f9bd9c-70da-0966-afa6-96f81e290204@suse.com>
X-ClientProxiedBy: LO4P123CA0478.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 26a943a9-68e5-467e-1b8e-08da1e1b15bd
X-MS-TrafficTypeDiagnostic: BN7PR03MB4372:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB43722C11F10AF903C5F02DFB8FEF9@BN7PR03MB4372.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 0UnqXDrqsMzYwic+6N6IXjCWVdJR/pR6ZNrdWwPsWejrXOLP5J8ARPQJmT3BtaLLnQIbWGUdC73HnWr48TXBonQSPWswYtmlBDJ+R8E84t4kByPnmk3qTQtsjAY2S5VLMRUnDY7RqYW/b8EV+tVPTeA+WOxaDyOoiglMXTKOcnCmLCRQo1Ev3bH57BpnJhc+FrNY2xuqIN/KI0RBeNOJUK+iR+NlezzWmdFpCzOTdz4Q9QXmcg2W2tJfAamnJ1aWjkNsUhUT8X3XKfVxsP6Uiv+eufqxaPE4YQ6/NiF8Ol+LUt9KjI+3s1Be9sjkk2C7go1PspRCJJwSMiffPDj0ShjqAtKT9JJvUSam2L3QOEOcZW0EUp1WZwZ9kJV1CehWwd7jtTuq09dMfFtu78jdTWOlxIk9CDZigsdPhql1UgxsYEbjUhMvnwgqjUWvrNJKchF279+83Dm0wfcL9tN2IRzgvl5p8GcWQJCTZI11rShzTCHAcmGljOQVWsyvFV5bvHKsunxtkyZgTW5gdJBzR71ibIDpEJuo/GaiIizESDIBdjjoDcTjxac2S15n+k5tVFOaScQ30srrWRSqJkoCxvmjU7Nc9q75jTlWJdois4eUR2xe6ZWddThHO/EVeZKigF+74sCtRjwZanflNxQNV35d7dxWbjk1WoXa4L0bOTcPB6DDgVVLTqyL4/rpcN/TNg2h3WGxBlzUWuJnub9cvRL2PYQlJza8DpBu/WXOUrDCoNcDRKD8rxQziueShNrHs16Qy66XzaVL+kdna3iR875oQCGd5x2GP6XciPIKlQJdW04mFzC5LGd7RtkvT0H3TARQlBBzJfn4jfj+QcEXqg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(66946007)(26005)(186003)(8936002)(33716001)(2906002)(82960400001)(83380400001)(38100700002)(66556008)(4326008)(6666004)(86362001)(508600001)(8676002)(6916009)(966005)(54906003)(66476007)(9686003)(53546011)(6512007)(316002)(5660300002)(6486002)(85182001)(142923001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkNNbTV1dVdVVlc4Vnp2d3ZTS1B2RjFxdVFJWDQxYTY2L1Q5ME1QV3FwZjZT?=
 =?utf-8?B?dWFCTFhmUUY0OHVnbkIxVG5EcmVnWmpRVWJ4TWh5NkE2aUdlK09rcUsrUWk4?=
 =?utf-8?B?aDZiTlBPcGZocUhLZmNrdXI4VTBBR0o0WmhqeXJHL2NwdStaaUxKcmFQM0RP?=
 =?utf-8?B?VGpWSkdHLzhaY2F5QjJlYjZQbnByYTA2eXFFUmtWL0tENzJkWEJzYWN4YVlK?=
 =?utf-8?B?TkI1endHQ3lza2dsSG4zZnAyTGxqRUxOTzZ6amp0RUM0RVhUL3VHV29oRUNs?=
 =?utf-8?B?STJaWTUwMG40eDFkZkMxR1ArU0dVVjRmaXJRdG1ReUk0TlpTOFk3bVpoaGpQ?=
 =?utf-8?B?QmFSMlBlRzBSTldYM2tRdERtZmx5WnNnSUtNeW9hamJNcHlJdFQ3dGgxQ0o5?=
 =?utf-8?B?QTZLOUZZejlEd0RvYnVZandjOGpxUEE4WU8yeEphVmQvcXdGUjlHUzJTQlVD?=
 =?utf-8?B?VndwRWxrcGJHa3BVU0h6eE9DNXVoMjYvcFptMVhISmcrZkhDQjk4a3JZVC9y?=
 =?utf-8?B?SjJjZVY4dEJDVjJUN2U1eWoveU1qMVJDU3JkTDM2Mzd0TWtxcGpjNHl6R2Qy?=
 =?utf-8?B?OFByQldET1FCbUhiUWIzVUxZdDBzZ2k5TmUzSUVhU1FFQktxSnRaZFlrS20z?=
 =?utf-8?B?T1VjeDRVUmMvcldod1IxKzJubWZreGFxcjZlUVlEZFdjVXdrMXFodVkzR0No?=
 =?utf-8?B?MkVIOG0vMjVWZHg2ZW9hKytjSkFySktNS0crZTg2TkM1b1FpSzhVZjFwT1hj?=
 =?utf-8?B?T1R3VDJFcjJabTlzKzBEUXJUMDR5S1BDakRLQSt5TnR2WWFNSkprVUVmQ3U4?=
 =?utf-8?B?dmJIcG9kTWRYcUZwU0UyNjBQVjZQeDR0NjVwRTNhZ0Z0QnhiT0NrWUF0bk1k?=
 =?utf-8?B?OTBoNkIrTzBORWFVT2JTeFZ2SHdwSVorY0FDbFR4cUFEMk9HRWZFRlZmSWNN?=
 =?utf-8?B?UjI3b3RJUDc4L0VzZWp5SGUrdEFjMHczZjlMTXNBcWVxdER0MGd5UXMyRFVD?=
 =?utf-8?B?ajV4c3pmd0RPemtvR2p1QXNxdlpXMHkyd215UkZWcUIvWitEZlVWT1poeWp2?=
 =?utf-8?B?SkNmMmJNWW1WeHBwNlhGaE0xY1B5NGI0WmlDd2JPSzdRalNXWnZiTTkrUUtY?=
 =?utf-8?B?c0ZKQTlUc0s0SW1Gb29CNlNtOUQ2VTBYalZJQ2RFRWpyOThzV2dMOFdhSVUy?=
 =?utf-8?B?ODNIeTUwNWdnc3d0ZEJLZWJ6aFBPM0lybGNqbStIcHVGWldCeGRGZHl6WnZu?=
 =?utf-8?B?YXhWRWVaVEcxZHJGdVN0TWtGNzh3TGc0Q2hDNi93c0VDdWVLc2dDeXJmSVkv?=
 =?utf-8?B?Q0tLVmJGZEhHMm1QeFVzdCt2emx5andxMkJRTTRaTVRMZjRzU0FZRWN0bnhH?=
 =?utf-8?B?UWVIK1cyNVJkcjlsOUpLNWs0aUhNQTQ0cm9QS1FJdjdVOFlzeGl4YkxmUjR3?=
 =?utf-8?B?RkNSVURNWi9xM2JPRGhabXJQaDdreHA3N3JBckpqMndxbml1cElORHJuS212?=
 =?utf-8?B?M1l2NmJFSG1KZlZwSmZhTVhIdjZabkh5UFliSDNvM2VHZURkSHI5RmVPb1k1?=
 =?utf-8?B?ZjVRQTlZVnM4MU5mR250ZWRTd2hUNGFxWGZDcm5kTWhDcWo3b2I5d3hDZVEz?=
 =?utf-8?B?Z3h6R3Frb1pvWWZieHJ1RWg0ckJNTW5CVWQ3VTltLzNUekVNZUxxY1ozOVQ3?=
 =?utf-8?B?WjJsWHl2SXIxaW1LUEVGaVJTd3BkNGt6UXFHc3NjTGU3T0dUMjlYT2VXTmh1?=
 =?utf-8?B?K0NlVlg5R2JMaWNTb08wUFJjR1dFSGtBb05FOWhYQkxpblphL2F5SXRETlJN?=
 =?utf-8?B?MXAxbVBIZ1dPWno1SmQ1ZXNyaUY0RTlrK0lyMFZlMWdkenZNdk1NZnZGQXRN?=
 =?utf-8?B?Tjl0cWhEd2luS2lubkxJczZ6RTFkY1FzK2svZUtjZml0UXJOS2ViZmdqUFBq?=
 =?utf-8?B?Nm9QWVN1NFN1a0lpT2trM0o4TTJrWkN3YlI5QjhlakVIZDFLcCtPdGpOMFUr?=
 =?utf-8?B?TzR2SVRPUDZnS2V5QUV0YXBNL1F4dGw4ZGZZNWJzZmxleXJjem5pNzFaK1cz?=
 =?utf-8?B?RlRHdk85anl1UkladUd0SG1qWkx1L3JuOVJUbVRFS0NqV1Z1eTdLNmY1UVAr?=
 =?utf-8?B?aHUvSkJaaklwTXRFa1FJaGtleXRpZmwyMS84OUlNaDJ1SzZTb2x2clpCSS9i?=
 =?utf-8?B?VGlhVVJhRlIzUm5HcGpGV3R0RHBGaVVsbnVVQzM3czJRQnZ1Z3RaZk1udmtQ?=
 =?utf-8?B?bXprVjNDYVZxUkIzcnFZZGl0WVhreFljcXZJQnQvZ0l1ZUp3QXg3em1Fd3pM?=
 =?utf-8?B?VGRtN3k0M3psNWIwaTIyaWtqZUxkNm9IaW5FODYxNU9seWF5WEFPZy83M2JT?=
 =?utf-8?Q?nW+EGWLbT0vr9PFo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 26a943a9-68e5-467e-1b8e-08da1e1b15bd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 13:31:30.5418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LtZg8BjoXHsIaURzxhWdMkRpHu57MDb7xZakk2L21oJYmZjXKpAZJfFDId61nSL4gra+w2FV+clNcDO73riGWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4372
X-OriginatorOrg: citrix.com

On Thu, Apr 14, 2022 at 02:52:47PM +0200, Jan Beulich wrote:
> On 14.04.2022 14:40, Roger Pau Monné wrote:
> > On Tue, Apr 12, 2022 at 12:27:34PM +0200, Jan Beulich wrote:
> >> While future gas versions will allow line number information to be
> >> generated for all instances of .irp and alike [1][2], the same isn't
> >> true (nor immediately intended) for .macro [3]. Hence macros, when they
> >> do more than just invoke another macro or issue an individual insn, want
> >> to have .line directives (in header files also .file ones) in place.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >>
> >> [1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
> >> [2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
> >> [3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
> >> ---
> >> Using .file has the perhaps undesirable side effect of generating a fair
> >> amount of (all identical) STT_FILE entries in the symbol table. We also
> >> can't use the supposedly assembler-internal (and hence undocumented)
> >> .appfile anymore, as it was removed [4]. Note that .linefile (also
> >> internal/undocumented) as well as the "# <line> <file>" constructs the
> >> compiler emits, leading to .linefile insertion by the assembler, aren't
> >> of use anyway as these are processed and purged when processing .macro
> >> [3].
> >>
> >> [4] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=c39e89c3aaa3a6790f85e80f2da5022bc4bce38b
> >>
> >> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
> >> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
> >> @@ -24,6 +24,8 @@
> >>  #include <asm/msr-index.h>
> >>  #include <asm/spec_ctrl.h>
> >>  
> >> +#define FILE_AND_LINE .file __FILE__; .line __LINE__
> > 
> > Seeing as this seems to get added to all macros below, I guess you did
> > consider (and discarded) introducing a preprocessor macro do to the
> > asm macro definitons:
> > 
> > #define DECLARE_MACRO(n, ...) \
> > .macro n __VA_ARGS__ \
> >     .file __FILE__; .line __LINE__
> 
> No, I didn't even consider that. I view such as too obfuscating - there's
> then e.g. no visual match with the .endm. Furthermore, as outlined in the
> description, I don't think this wants applying uniformly. There are
> macros which better don't have this added. Yet I also would prefer to not
> end up with a mix of .macro and DECLARE_MACRO().

I think it's a dummy question, but why would we want to add this to
some macros?

Isn't it better to always have the file and line reference where the
macro gets used?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:36:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:36:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304772.519516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezeO-0005Ci-G8; Thu, 14 Apr 2022 13:36:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304772.519516; Thu, 14 Apr 2022 13:36:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezeO-0005Cb-D2; Thu, 14 Apr 2022 13:36:44 +0000
Received: by outflank-mailman (input) for mailman id 304772;
 Thu, 14 Apr 2022 13:36:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f0xO=UY=citrix.com=prvs=09619e58f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nezeN-0005CV-4n
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 13:36:43 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9f123b2-bbf7-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 15:36:41 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9f123b2-bbf7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649943401;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=C1Z3+dJoMo890gQGvKH3XPKMzlZoAmE19EOrtZzUCWk=;
  b=QVGUkWO1P92iwfE8i7tz1eLn7x51sqC+L1Nud1sx+IniaFg3TCcivWGZ
   gyWNQa0KfP1XTdUxvvYkIp+xq7BPv8X0mE3Lp927TT1MQRpe9nsFT9GHj
   G3EVELT3lRwKnYV4cC7LwMHVMzR9vY8sR8KxwKkIwgml7ZUV0kQa3gZUr
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 71370862
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:e59aLK6Rq/MrZGznDXnJGgxRtC/HchMFZxGqfqrLsTDasY5as4F+v
 mpKXmrXO6uPajOkc90gb4m2px8C7ZXRmoBkHQBoris9Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTgX1vU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSvFyp2L7TukdgQXgJiMzsnPo1K2LvIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gRRK2BP
 5pHM1KDajyDXjxWZlEJFK44lbu0rFXFVwFAig6K8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc8UOPrIr8SOE9qfZ+Dy5HDEHbjJhbNNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODEsogz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vdB0xa5hYImS0C
 KM2he+3zMUCVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSnPHKGoNJJcAhiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSavxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:sfIl5K7F+5xcdEaCRAPXwSqBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ1yHtycegA2w
 3+CNUaqFh/dL5nUUtDPpZyfSKWMB26ffueChPaHbzYfJt3Tk4l7aSHpIkI2A==
X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; 
   d="scan'208";a="71370862"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KnbV/WSPOkDY9hWVPuYR5nZ3s5x85cdEFf/lY2owHVHnmLQnp2QhNQ+TtR+3bxP1SapYwZ1h5lSNdNOe7Nl888y6ulZHiUtROKlNwyY9h+XrT1n007ZIBb9408TvDUQNGroNfNN2T+b6GmOYHd48KJO+tn1riDwD249Cp0Zt5rDLeD7W3Nbnl+ZtGc6OKaWoid3hi9wr53SfsGIkArxhC3k20/KjFRsZWbXlB+eNx+mgxR/DTM8qLkzqiplk7lqJVxdd+YTYt870w8Il8oczPQv5YPYXYxvkBoHv3grXAGGX4p8LzPstF9lu0lqJu8xXndLq2WOuMtiWgakeD64D9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e+kNO7bL8CTwu7FCOsLRrph/IcUFpoDLwm+j3dZN2xs=;
 b=aPajtMtH3zSmhsSV3Vq11jvkcvy7NFBvlpS+pRSIpnuDsqB5piMDATDUyBJwbeGB/19VtxskAMgCSJsfio9HPdos+qfKKKS+KCuTTXylcGNieECzmVV2tJM/p8JcHBPDUpOQ59gVCcyDP567nutPoMGxZZuDpo3wkvSQYAtk3fV3xsCtPYy7zPHnQy+hgeSz5JwBbnOp9A6h5Gecvj1NVLWaa+a/blBu3EJvyHyDfzsQnvUEUV3sOTdLwyNWE394wOKNZen/Xq+lZED2Fd/0Fl3RIxrd4y6xHlYA2770dviaXbA2AQyneCTPhcnmZJ3ivV0zM9Ayq9IgMJT0z59FXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e+kNO7bL8CTwu7FCOsLRrph/IcUFpoDLwm+j3dZN2xs=;
 b=r/lUFJG3c3DuAMs4VQXoW8laiE4oY9WDKSn+bjfmCYDx6W8n3pwPBpjZSOwG0S8KCDLyzxxxETckIA8UV6r7p9FuC8pJMC9TaYonmOxf/1PnfT+s7nyKR2EIaq84xdiXN2TA9s853o5Fs1lzmi3rY+yU2xl7ZEVy2YA+l4pJZ1w=
Date: Thu, 14 Apr 2022 15:36:32 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] x86: improve .debug_line contents for assembly
 sources
Message-ID: <YlgjYMq3j4F0o+ay@Air-de-Roger>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
 <YlgWKGmR+u41zSsw@Air-de-Roger>
 <04f9bd9c-70da-0966-afa6-96f81e290204@suse.com>
 <YlgiLhvsKVYKKvrr@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YlgiLhvsKVYKKvrr@Air-de-Roger>
X-ClientProxiedBy: LO4P123CA0060.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0c466f12-85e5-47a8-8daa-08da1e1bcc5d
X-MS-TrafficTypeDiagnostic: SN6PR03MB3965:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB39651D371C504B13FC5B0CA18FEF9@SN6PR03MB3965.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Trr3iOwAH3ZMcOEdu8NjLcwOxgevGXaz3EdqpGlxe+7gqbUGr7WwOjlrfjFcBZYVUvSwz4RA8BtLJTTGsPJoX75MIHubNAEtkx91itYryEzYe9XmZs6lfQgkzwlJ6wYdoxDVGurRvTH9z4a/gBLzX5mxkmZDCMGkUBXoP6maSDGJ0kgj7xS80+TZrVCUdyZVrEk24zqgGdLLQepl4XWRWZ+uO0WFqT2ha4kwvSGW/qWQkKYcxQh3Q2PqTa0ra3Ha6tLIM2yaoVkJISm4Ph7tYDpjs0JGHw9BEBWetP30U8KzMYLAWqAqWP+6qnoVoyzioMmherMNmOayeOXhbaQYknbtmcBEZausoUGoX7MIxZ975nZuk/zRZP9VSglmBPLTY3YfwdArFvDJzt67Pgwzm3RypqmBBaV69tY9EPI6iRUPeTkJWbO2B7QqUFgvQV3Eo/Ov8FmGKO1bQW/7kY7+4Ml0hyWDguYmGut8GPdKlq5b2SnFl5OuA+ts7+LMm8rBNAuWyVNOCxiuAXgcWNTscXb3REKBqMW56q4T8n2QaDlUx+MRhdElcbTH8QucCmJ30vmMeZ1TWPa9BVhGWd9MntRx4dar09XNpEC1X3S8SMK6dvHXFhWbK7JjVQt5Mm5nlXavp77xnvfqBvEUeFpp6XtbnxCR3x7Ld8Vv7biw6F2to5MBGz+fVw8FMO2F59O1UIj2Nfg0Q9Zj54ReTlV/YaAWyKys/MM+el+bhD+JW3ctElCQ56Zz0Y+HKPpV+2ED6UugwWsdThgUupiDRu4uwQHk7EMPniK035S3s63P90gpVKopRy18vVj3bKl71SfhCWzxJ0ooefEKIuGwjNY7Y6C7oLM1+x2YZexuk9blO/w=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(316002)(508600001)(966005)(6486002)(66476007)(66556008)(9686003)(54906003)(6916009)(6512007)(86362001)(6666004)(6506007)(53546011)(33716001)(85182001)(186003)(8676002)(4326008)(26005)(8936002)(66946007)(83380400001)(5660300002)(2906002)(82960400001)(38100700002)(142923001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmcwU3NKaU9BdVdkdHkxYWEydDNyRk5adUN5d0pWcE0xeXdCWlNSWHFWM0xW?=
 =?utf-8?B?SzBkRHdmYXloNTdHV1l5bzR6NitHSXE4OEZuQVM5czRwMjlzRWkreSsxNlNa?=
 =?utf-8?B?N1NsOGhkRWxVMWIrRDZobW5iWWxrR09BSm9lTWFYNkszbzRCQWJkc2Jtc0wx?=
 =?utf-8?B?WWh0dmZubHhWblExd1luUS9EeC84Y3hVaGwwRW9KVVVobjJ0ZU9xMUk3Qmwv?=
 =?utf-8?B?dnROdEtOcnJCSGM4M3JtMkVtQSt3WUcyWlV0WDJZVjlMSWNYWnlxWktyUTV0?=
 =?utf-8?B?UEwwMlRZdk9VckVHdlIvSENwRDhhNHUxZlFieHJsSC84YlRaVkVrcVZTTTlW?=
 =?utf-8?B?VlNpRy9SMFdCaWM5L3ViYVVKc3BmZ0IzMDVLdHBnbFN2NXFPNUNsVCtUVWhy?=
 =?utf-8?B?NjB5aGpZeGpLbGxRWW93YndvOUtSaFZkajFnc3UyME1RR2xuOWZMN3pqc1Av?=
 =?utf-8?B?cHFQcEJSRWFuRFVHM2xoejFFQlJBZUYyWnMvbEVHUjNVZnZGWVh6VmV5Y0cr?=
 =?utf-8?B?VGNKVnZFSzBpVG1jWGJoWVhoeC9aOGZNYmlsVElmYkJMcm13UWdFdjRQQ0w4?=
 =?utf-8?B?Q0twMzJyTVVGWVQ1V0lsZEhLNWVOeStOMlowT1gzSU1mbVIvRDMrdktYQTQy?=
 =?utf-8?B?WWQ3Wklza1RDL1RJT0JmL01vQVhFTTU4SU1xelNaZWVuTEpGQkJRb2JiVisz?=
 =?utf-8?B?UUVqYXJweXZZWGMwZ01wRXdEek5MWFRVaHlIR3R1Rk8vT2dveC9PMnBZRGNX?=
 =?utf-8?B?WEw3YXdscmlvZm9KQUF4MnRPVEJBU0ZZMTduTzFCdi8vSkdPVmpNdllYVTcz?=
 =?utf-8?B?clJCa29YUDYvOFAzbmtMVHE3bVMyVTl6Q2ZhV212N0tuTjU1T0RUVnBrSk5h?=
 =?utf-8?B?WDZ0OG4yNTFsWWUwdE1BbkZUd2kwZXU0TlphNU5xcm5xMitKLzZaRDlHNVRh?=
 =?utf-8?B?cjhtYzdZM3ZOUzhMeDVEblB0WFA5Q0lCaFpHNllvcmF4dmNuZUNLRTFjZ1JN?=
 =?utf-8?B?TllURndXOGZwSTNQRmF3K0lNOW1heFhHYWd0TEJHWkVUWG5nUCtlMEdhQnRS?=
 =?utf-8?B?NjlGaVBxMVNjMHMrdFh5VzRNQ1Y1NkFYOG5YTlpXSnZ5c1Vzb044ZlFFRXkr?=
 =?utf-8?B?czZZTUNla0plQjA0Y3pCQmNBbDBxbVFlMkNsYTA3T3hySHVOVXNPV2JPMGxq?=
 =?utf-8?B?dnFBQUZibVZocHVrQndzSDlKcnJYNitQODVIaWNOZFdBZjM1aXEvdFZlcVho?=
 =?utf-8?B?N0dFc1piMWJ0ZlloYzNIakNrTUsrSjRMOVg1NGo5dHVpdG55YzNyVWQ5UWhU?=
 =?utf-8?B?UFNzQ0ljcUlsc2ZwK3h0clQ1VHYrUm9sSE0vM3J5VHc4andnME1sM09ZQmhH?=
 =?utf-8?B?c0wxb3JFMm5vZ0sxem5pYWRIb0xHS2NkL3RYdXBuaEZSNGVUSlljc3M3aGEv?=
 =?utf-8?B?dW5JeU96K002Mlc1ZDUraFpPc3ZnWjJNRElqQlNYa1J4M2tmQkNCQkVGQXBF?=
 =?utf-8?B?YWI2NUNxNVNqSTZ4T0hhVHQxWitCeEUvZTA4N3hlNGFrZHE1azdYYlBrVVM1?=
 =?utf-8?B?Ri9rakp0eGRVaDZZcUNiQzlMeXFjb3FHTnZWSDlTekwzWno1c1RLU3VYQVdQ?=
 =?utf-8?B?M0N4OXRKOVVpemhEdWRmbXIrZVYyUXhHMW5VSVBQWDQ4MzhIUklBaVFLVXU1?=
 =?utf-8?B?Qk43TkM1U3pDSThySnNhWGNreGtOZlJ3RkNUUVFwSWpnYkpqYjlBbVpMRWx4?=
 =?utf-8?B?SkU3QXpZc2x3Zi9CdlhQOGVzM0c0cWFici9vM295K0lIeWxhTXY0Wk5ZNWNC?=
 =?utf-8?B?cE9OSVdDRTFIUGJ3Yng3eGNobTF3NVVqUVBZcHJsSFBqNkd1Vkt5L1IyamVH?=
 =?utf-8?B?WmlyQ2dYaFlyVExreEE3eEN6SGQ4WGZudy9GL0htYVdNN1E2R3hMVkRXT0RR?=
 =?utf-8?B?V2cwUHpEVllRNVZJVkQwZWFQMGp6N0hzOGVUSnZGR3loM2dyQWRVL1BZT1c0?=
 =?utf-8?B?endqRHM1S0ZXcEx4U0syajJGZzRsNnB2enl3Z2d6UmFuUDNBelhUME91L0ho?=
 =?utf-8?B?dEZCbGRUMGJMeGZQSXhkejVOV3R5MnR6K1NpYTIzZHJrY0RVZHIzR1hIU1RS?=
 =?utf-8?B?Wm9RRjlEY2d5cWdCb0Jhc3VGa3ljNUg1VXpsMU50TndsNHB5QlNPNEFHT3Jw?=
 =?utf-8?B?ME9TYm5nRURLQ2w5Zlp4Qnk5RjhCVTVsd2kvZXNJSnVyM2VvNWFNZTRzeDdL?=
 =?utf-8?B?UWZKa3F6QnVrWlVDK2oyYmEwRDYyOXlsMUZRdmswZmNQRXdSdmR3ckY2SHhz?=
 =?utf-8?B?MktNNE1xMUhaYjQ5QlJmalVPNGpNRzFSekFlVUF2MWE2K2wxTFU2WmVHRU5u?=
 =?utf-8?Q?APX/KTQBO4AcMOz4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c466f12-85e5-47a8-8daa-08da1e1bcc5d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 13:36:36.8793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s3OJ1WjtVQpHAxUPpKDHFfseZpg+AMM9kDtoODtYg8buYjYeGHI+rNMpaDuWZKP04CaNbbrAZTvy13zwwpXmKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3965
X-OriginatorOrg: citrix.com

On Thu, Apr 14, 2022 at 03:31:26PM +0200, Roger Pau Monné wrote:
> On Thu, Apr 14, 2022 at 02:52:47PM +0200, Jan Beulich wrote:
> > On 14.04.2022 14:40, Roger Pau Monné wrote:
> > > On Tue, Apr 12, 2022 at 12:27:34PM +0200, Jan Beulich wrote:
> > >> While future gas versions will allow line number information to be
> > >> generated for all instances of .irp and alike [1][2], the same isn't
> > >> true (nor immediately intended) for .macro [3]. Hence macros, when they
> > >> do more than just invoke another macro or issue an individual insn, want
> > >> to have .line directives (in header files also .file ones) in place.
> > >>
> > >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > >>
> > >> [1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
> > >> [2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
> > >> [3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
> > >> ---
> > >> Using .file has the perhaps undesirable side effect of generating a fair
> > >> amount of (all identical) STT_FILE entries in the symbol table. We also
> > >> can't use the supposedly assembler-internal (and hence undocumented)
> > >> .appfile anymore, as it was removed [4]. Note that .linefile (also
> > >> internal/undocumented) as well as the "# <line> <file>" constructs the
> > >> compiler emits, leading to .linefile insertion by the assembler, aren't
> > >> of use anyway as these are processed and purged when processing .macro
> > >> [3].
> > >>
> > >> [4] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=c39e89c3aaa3a6790f85e80f2da5022bc4bce38b
> > >>
> > >> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
> > >> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
> > >> @@ -24,6 +24,8 @@
> > >>  #include <asm/msr-index.h>
> > >>  #include <asm/spec_ctrl.h>
> > >>  
> > >> +#define FILE_AND_LINE .file __FILE__; .line __LINE__
> > > 
> > > Seeing as this seems to get added to all macros below, I guess you did
> > > consider (and discarded) introducing a preprocessor macro do to the
> > > asm macro definitons:
> > > 
> > > #define DECLARE_MACRO(n, ...) \
> > > .macro n __VA_ARGS__ \
> > >     .file __FILE__; .line __LINE__
> > 
> > No, I didn't even consider that. I view such as too obfuscating - there's
> > then e.g. no visual match with the .endm. Furthermore, as outlined in the
> > description, I don't think this wants applying uniformly. There are
> > macros which better don't have this added. Yet I also would prefer to not
> > end up with a mix of .macro and DECLARE_MACRO().
> 
> I think it's a dummy question, but why would we want to add this to
                                              ^n't

Sorry.


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:37:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:37:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304776.519526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezf3-0005jA-Ow; Thu, 14 Apr 2022 13:37:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304776.519526; Thu, 14 Apr 2022 13:37:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezf3-0005j3-M0; Thu, 14 Apr 2022 13:37:25 +0000
Received: by outflank-mailman (input) for mailman id 304776;
 Thu, 14 Apr 2022 13:37:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nezf1-0005ip-QJ; Thu, 14 Apr 2022 13:37:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nezf1-0002cB-OQ; Thu, 14 Apr 2022 13:37:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nezf1-0002Zj-DF; Thu, 14 Apr 2022 13:37:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nezf1-0002yh-Cj; Thu, 14 Apr 2022 13:37:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QlP2eUzjFb9o0eeuPvLm2EpMUiy8TokE5h6M0nAvcTQ=; b=kImdOE4Uu3kW26G95+mqWHoR0f
	b1BU1W+ZLVDxd3ZEKYI10XmnsXMmbmFT/GmIvg4zqdWZc5ilXMrI69HJZb+pIA0/8firkFZZ8cG24
	qrWnE1uNdH5SOeequwW3EjjbxBEjZMrPoa/RTx6AoF9gG0QIVqGI6XXb31Un+nkEZyTE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169395-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169395: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 13:37:23 +0000

flight 169395 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169395/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  387 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 13:38:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 13:38:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304785.519538 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezgN-0006LS-4o; Thu, 14 Apr 2022 13:38:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304785.519538; Thu, 14 Apr 2022 13:38:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nezgN-0006LL-1a; Thu, 14 Apr 2022 13:38:47 +0000
Received: by outflank-mailman (input) for mailman id 304785;
 Thu, 14 Apr 2022 13:38:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fq7I=UY=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1nezgL-0006L2-2x
 for xen-devel@lists.xen.org; Thu, 14 Apr 2022 13:38:45 +0000
Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com
 [2a00:1450:4864:20::32b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33a27c15-bbf8-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 15:38:43 +0200 (CEST)
Received: by mail-wm1-x32b.google.com with SMTP id
 123-20020a1c1981000000b0038b3616a71aso3204451wmz.4
 for <xen-devel@lists.xen.org>; Thu, 14 Apr 2022 06:38:43 -0700 (PDT)
Received: from zen.linaroharston ([51.148.130.216])
 by smtp.gmail.com with ESMTPSA id
 v15-20020a056000144f00b002057eac999fsm2065008wrx.76.2022.04.14.06.38.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 14 Apr 2022 06:38:41 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 0FD221FFB7;
 Thu, 14 Apr 2022 14:38:41 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33a27c15-bbf8-11ec-8fbd-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=references:user-agent:from:to:cc:subject:date:in-reply-to
         :message-id:mime-version:content-transfer-encoding;
        bh=dBeqz0WsltLCKb2+HsQX+wxXNC5FlwtuzHZg2vOsv7s=;
        b=ZB9NtAr1/FToK4NnULEwMLe9jylvqu5IMmaSHd21ggPlwink+yaAGxBJgjHt7Y2Ij0
         DhA+xl+LpPG3AUhYXmGSqH6oL82stgD0amoSmrvkUwIWQDKnYKOx8Q69o96YMEYuoEac
         lkFo/J1fhPM2qYtxI5uHLEelb7IabpS70f2hNpc68Npla7Syi6yWaFXIPlr39d+ZGgPb
         zgD9CT/DPgpQ2j5kEbigT5dDSx86VrK9Fe78YgloFDTEMjF4+jPqkLfu67FqWx32z9UV
         fm1257pqrSYxiJHVnUkRm3DQlvP8mFswoynz2S3XOg+MzvtZ1NP/lQ0C7vxgltBjKKeW
         Xtow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:references:user-agent:from:to:cc:subject:date
         :in-reply-to:message-id:mime-version:content-transfer-encoding;
        bh=dBeqz0WsltLCKb2+HsQX+wxXNC5FlwtuzHZg2vOsv7s=;
        b=NtpLZZfg3vNW3dD3diaSeHWGzZyyInz2itC59Y7nhRz7DxTSEpZilgFsoaQVH+azQ4
         sj7pKEoPr7jN/COryURJqrVST2wSZbF8CDFlSXCz9Uo4BSfsrDi6/CJ+D1PufDOEm7Rb
         s7bQ+UhMSJKASBf76TTyqkvWdvYxfHOuObbr1yqJ/OsvoPLruAou2sG7ju4QkreWo6p6
         s7qKvcF4V84kXmeNgXcAcwf1S+1/gR+d5+xPZ3aDQI9fHqyGNAbr98CKpOvt2gbaEGi1
         C0QiTb/VMPRoMr7N+zJynaIO5cLP6UkgWTAn/9EzNIbTcfxJvkTdz76SiLmYtFF4vA87
         Eqvw==
X-Gm-Message-State: AOAM5321dFMPMsS8mD5v9OMfJoB5s/+cE9l6qcHKJXRyDCI2kQlsAgzA
	87cMa7VRMHReWcihOT7UklgVTA==
X-Google-Smtp-Source: ABdhPJyOpUFT1vjFFmcS3XRUtYc6u+SYoUOrO7gtVsf9tm6Cleq/iK7Qm2qE4+Nru9nt93pAOcimsg==
X-Received: by 2002:a05:600c:1c89:b0:38e:d1a6:bf7a with SMTP id k9-20020a05600c1c8900b0038ed1a6bf7amr3752757wms.204.1649943523111;
        Thu, 14 Apr 2022 06:38:43 -0700 (PDT)
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>
 <20220414114557.4myrs4ud4qi2hnrz@liuwe-devbox-debian-v2>
 <2a735486-a464-3997-642a-3b0660b11b9e@citrix.com>
 <20220414125213.6qqn5wcphau5j3i3@liuwe-devbox-debian-v2>
User-agent: mu4e 1.7.12; emacs 28.1.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Wei Liu <wl@xen.org>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, Viresh Kumar
 <viresh.kumar@linaro.org>, "stratos-dev@op-lists.linaro.org"
 <stratos-dev@op-lists.linaro.org>, "xen-devel@lists.xen.org"
 <xen-devel@lists.xen.org>, Stefano Stabellini
 <stefano.stabellini@xilinx.com>, Mathieu Poirier
 <mathieu.poirier@linaro.com>, Vincent Guittot
 <vincent.guittot@linaro.org>, Mike Holmes <mike.holmes@linaro.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>, Doug Goldstein
 <cardoe@cardoe.com>
Subject: Re: Virtio on Xen with Rust
Date: Thu, 14 Apr 2022 14:36:12 +0100
In-reply-to: <20220414125213.6qqn5wcphau5j3i3@liuwe-devbox-debian-v2>
Message-ID: <871qxzyecf.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Wei Liu <wl@xen.org> writes:

> On Thu, Apr 14, 2022 at 12:07:10PM +0000, Andrew Cooper wrote:
>> On 14/04/2022 12:45, Wei Liu wrote:
>> > Hi Viresh
>> >
>> > This is very cool.
>> >
>> > On Thu, Apr 14, 2022 at 02:53:58PM +0530, Viresh Kumar wrote:
>> >> +xen-devel
>> >>
>> >> On 14-04-22, 14:45, Viresh Kumar wrote:
>> >>> Hello,
>> >>>
>> >>> We verified our hypervisor-agnostic Rust based vhost-user backends w=
ith Qemu
>> >>> based setup earlier, and there was growing concern if they were truly
>> >>> hypervisor-agnostic.
>> >>>
>> >>> In order to prove that, we decided to give it a try with Xen, a type=
-1
>> >>> bare-metal hypervisor.
>> >>>
>> >>> We are happy to announce that we were able to make progress on that =
front and
>> >>> have a working setup where we can test our existing Rust based backe=
nds, like
>> >>> I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.
>> >>>
>> >>> Key components:
>> >>> --------------
>> >>>
>> >>> - Xen: https://github.com/vireshk/xen
>> >>>
>> >>>   Xen requires MMIO and device specific support in order to populate=
 the
>> >>>   required devices at the guest. This tree contains four patches on =
the top of
>> >>>   mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C).
>> >>>
>> >>> - libxen-sys: https://github.com/vireshk/libxen-sys
>> >>>
>> >>>   We currently depend on the userspace tools/libraries provided by X=
en, like
>> >>>   xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates prov=
ides Rust
>> >>>   wrappers over those calls, generated automatically with help of bi=
ndgen
>> >>>   utility in Rust, that allow us to use the installed Xen libraries.=
 Though we
>> >>>   plan to replace this with Rust based "oxerun" (find below) in long=
er run.
>> >>>
>> >>> - oxerun (WIP): https://gitlab.com/mathieupoirier/oxerun/-/tree/xen-=
ioctls
>> >>>
>> >>>   This is Rust based implementations for Ioctl and hypercalls to Xen=
. This is WIP
>> >>>   and should eventually replace "libxen-sys" crate entirely (which a=
re C based
>> >>>   implementation of the same).
>> >>>
>> > I'm curious to learn why there is a need to replace libxen-sys with the
>> > pure Rust implementation. Those libraries (xendevicemodel, xenevtchn,
>> > xenforeignmemory) are very stable and battle tested. Their interfaces
>> > are stable.
>>=20
>> Very easy.=C2=A0 The library APIs are mess even if they are technically
>> stable, and violate various commonly-agreed rules of being a libary such
>> as not messing with stdout/stderr behind the applications back, and
>> everything gets more simple when you remove an unnecessary level of C
>> indirection.
>
> You don't have to use the stdio logger FWIW. I don't disagree things can
> be simpler though.

Not directly related to this use case but the Rust API can also be
built to make direct HYP calls which will be useful for building Rust
based unikernels that need to interact with Xen. For example for a
dom0less system running a very minimal heartbeat/healthcheck monitor
written in pure rust.

We would also like to explore unikernel virtio backends but I suspect
currently the rest of the rust-vmm virtio bits assume a degree of POSIX
like userspace to set things up.

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 14:11:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 14:11:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304793.519549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0BM-0002Aj-QB; Thu, 14 Apr 2022 14:10:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304793.519549; Thu, 14 Apr 2022 14:10:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0BM-0002Ac-NG; Thu, 14 Apr 2022 14:10:48 +0000
Received: by outflank-mailman (input) for mailman id 304793;
 Thu, 14 Apr 2022 14:10:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jucj=UY=gmail.com=wei.liu.xen@srs-se1.protection.inumbo.net>)
 id 1nf0BL-0002AW-7z
 for xen-devel@lists.xen.org; Thu, 14 Apr 2022 14:10:47 +0000
Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com
 [209.85.128.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ad011fc9-bbfc-11ec-8fbd-03012f2f19d4;
 Thu, 14 Apr 2022 16:10:45 +0200 (CEST)
Received: by mail-wm1-f42.google.com with SMTP id
 l62-20020a1c2541000000b0038e4570af2fso3266748wml.5
 for <xen-devel@lists.xen.org>; Thu, 14 Apr 2022 07:10:45 -0700 (PDT)
Received: from liuwe-devbox-debian-v2 ([51.145.34.42])
 by smtp.gmail.com with ESMTPSA id
 k63-20020a1ca142000000b0038ff2c38e85sm2174013wme.39.2022.04.14.07.10.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 14 Apr 2022 07:10:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad011fc9-bbfc-11ec-8fbd-03012f2f19d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:content-transfer-encoding
         :in-reply-to;
        bh=YIzlXsrUeW5/iwfuFN2L5K77UYGr+Buj449anH+enN8=;
        b=htViHUcecTJJ4r7jcSSZH4DIwRJpPNOwwqAw1WOGEAGiXkqNpZXicOUt1wPvMVta6u
         mw7UgWlnnhsNPr29ywuiReQInaRw4d1v+eM5OjKXrhrLC6rDK30suvFLnrpwYD1USSsz
         3q4CqITiOyMNpcP6YHMTNvAYj0syS+G5ZMSIWkY6eakpmnf8NfXTDlerAE969Q4N7GtI
         hDMo5lGwiv5CGQqSuQWgcgFH5Bt1Wx4gbbQXoWuNQXlfKvQMRleyt/iDAxgB8IqQ38CF
         FzNdiGjHij+2XtHZdzac3kLE6J8K465fWTjwQwNdVUA6W0h7Du/1DeKWGkCF38udwHEM
         rqxQ==
X-Gm-Message-State: AOAM530MHTcRE+/im6tVx6Xugfx23TcOCoZiAUE0tlttYt/VtSki9gMk
	94xGSz+HYqr8l7+boU3/MWs=
X-Google-Smtp-Source: ABdhPJyILIufaX7wYWcIbc6xJhiKK07VKB8/P2fNs+sp/AGjtwyOLEcMCSvKfrKDgEoSXwa7E0LnZA==
X-Received: by 2002:a1c:1941:0:b0:38b:4af1:49f8 with SMTP id 62-20020a1c1941000000b0038b4af149f8mr3877599wmz.156.1649945444537;
        Thu, 14 Apr 2022 07:10:44 -0700 (PDT)
Date: Thu, 14 Apr 2022 14:10:41 +0000
From: Wei Liu <wl@xen.org>
To: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
Cc: Wei Liu <wl@xen.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"stratos-dev@op-lists.linaro.org" <stratos-dev@op-lists.linaro.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Mathieu Poirier <mathieu.poirier@linaro.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Mike Holmes <mike.holmes@linaro.org>,
	Oleksandr Tyshchenko <olekstysh@gmail.com>,
	Doug Goldstein <cardoe@cardoe.com>
Subject: Re: Virtio on Xen with Rust
Message-ID: <20220414141041.ogeaaplnb7mfufsb@liuwe-devbox-debian-v2>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>
 <20220414114557.4myrs4ud4qi2hnrz@liuwe-devbox-debian-v2>
 <2a735486-a464-3997-642a-3b0660b11b9e@citrix.com>
 <20220414125213.6qqn5wcphau5j3i3@liuwe-devbox-debian-v2>
 <871qxzyecf.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <871qxzyecf.fsf@linaro.org>

On Thu, Apr 14, 2022 at 02:36:12PM +0100, Alex Benn�e wrote:
> 
> Wei Liu <wl@xen.org> writes:
> 
> > On Thu, Apr 14, 2022 at 12:07:10PM +0000, Andrew Cooper wrote:
> >> On 14/04/2022 12:45, Wei Liu wrote:
> >> > Hi Viresh
> >> >
> >> > This is very cool.
> >> >
> >> > On Thu, Apr 14, 2022 at 02:53:58PM +0530, Viresh Kumar wrote:
> >> >> +xen-devel
> >> >>
> >> >> On 14-04-22, 14:45, Viresh Kumar wrote:
> >> >>> Hello,
> >> >>>
> >> >>> We verified our hypervisor-agnostic Rust based vhost-user backends with Qemu
> >> >>> based setup earlier, and there was growing concern if they were truly
> >> >>> hypervisor-agnostic.
> >> >>>
> >> >>> In order to prove that, we decided to give it a try with Xen, a type-1
> >> >>> bare-metal hypervisor.
> >> >>>
> >> >>> We are happy to announce that we were able to make progress on that front and
> >> >>> have a working setup where we can test our existing Rust based backends, like
> >> >>> I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.
> >> >>>
> >> >>> Key components:
> >> >>> --------------
> >> >>>
> >> >>> - Xen: https://github.com/vireshk/xen
> >> >>>
> >> >>>   Xen requires MMIO and device specific support in order to populate the
> >> >>>   required devices at the guest. This tree contains four patches on the top of
> >> >>>   mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C).
> >> >>>
> >> >>> - libxen-sys: https://github.com/vireshk/libxen-sys
> >> >>>
> >> >>>   We currently depend on the userspace tools/libraries provided by Xen, like
> >> >>>   xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates provides Rust
> >> >>>   wrappers over those calls, generated automatically with help of bindgen
> >> >>>   utility in Rust, that allow us to use the installed Xen libraries. Though we
> >> >>>   plan to replace this with Rust based "oxerun" (find below) in longer run.
> >> >>>
> >> >>> - oxerun (WIP): https://gitlab.com/mathieupoirier/oxerun/-/tree/xen-ioctls
> >> >>>
> >> >>>   This is Rust based implementations for Ioctl and hypercalls to Xen. This is WIP
> >> >>>   and should eventually replace "libxen-sys" crate entirely (which are C based
> >> >>>   implementation of the same).
> >> >>>
> >> > I'm curious to learn why there is a need to replace libxen-sys with the
> >> > pure Rust implementation. Those libraries (xendevicemodel, xenevtchn,
> >> > xenforeignmemory) are very stable and battle tested. Their interfaces
> >> > are stable.
> >> 
> >> Very easy.� The library APIs are mess even if they are technically
> >> stable, and violate various commonly-agreed rules of being a libary such
> >> as not messing with stdout/stderr behind the applications back, and
> >> everything gets more simple when you remove an unnecessary level of C
> >> indirection.
> >
> > You don't have to use the stdio logger FWIW. I don't disagree things can
> > be simpler though.
> 
> Not directly related to this use case but the Rust API can also be
> built to make direct HYP calls which will be useful for building Rust
> based unikernels that need to interact with Xen. For example for a
> dom0less system running a very minimal heartbeat/healthcheck monitor
> written in pure rust.
> 

I think this is a strong reason for not using existing C libraries. It
would be nice if the APIs can work with no_std.

> We would also like to explore unikernel virtio backends but I suspect
> currently the rest of the rust-vmm virtio bits assume a degree of POSIX
> like userspace to set things up.

Indeed.

Thanks,
Wei.

> 
> -- 
> Alex Benn�e


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 14:15:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 14:15:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304798.519560 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0Ft-0002q0-CY; Thu, 14 Apr 2022 14:15:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304798.519560; Thu, 14 Apr 2022 14:15:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0Ft-0002pt-9B; Thu, 14 Apr 2022 14:15:29 +0000
Received: by outflank-mailman (input) for mailman id 304798;
 Thu, 14 Apr 2022 14:15:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xfxB=UY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nf0Fs-0002pm-6o
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 14:15:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 54f2a66a-bbfd-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 16:15:27 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-Q7WiMJCXNDqnxe8KKgm1GA-1; Thu, 14 Apr 2022 16:15:25 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB6924.eurprd04.prod.outlook.com (2603:10a6:10:11e::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr
 2022 14:15:24 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 14:15:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54f2a66a-bbfd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649945726;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ioIB61VLktne7zybMsZf3ZCjOKaJEfvsJeptYiD/+/s=;
	b=gLJllP3ExGZjGh0ZJi7bQbiF/cOLJdpYLMsV/sHhAPEp2uQhSBE5AcZcmCh6JXTYCYxV8A
	tOPlNaBO4Ibp6zUp03Sfpiqeby530UlmQHidQwt2vKr5Tj7aI6pl/Xw6yfi1PvKGzdkUgl
	QXN6lWrBd0pXlsK88h1JMagiNtb1ATk=
X-MC-Unique: Q7WiMJCXNDqnxe8KKgm1GA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cGM00sAB1ltmfqyNeib5KquuzE+GQuiuX1kQhZrhKsl1vaE56x5mdBTn/v8t7b11ohIVfyoH8p3/Dqv/ofTlKKFUt55h/yZ9L8eoTr0Hj2QIelkqoZlFuu3pqnoRfmO2nm1dIH7TCm4H8XhAUX2q3+V4oKvNQbCmrilvjOYe5pq1O+EPvwJeTX9epD35KsBNhhonAb23QeZIdscbpP9am0b2XEySl6aKNYJk1TQhiWY86m4s6E5/j6kxUkH0ywIyESwip5ZT1rZJxXBARWxaVOKRdxuz6O/IsOVhuDsGE4vu6omXHRApil180MynpBNBMMS9beGbQLodia34xZIPgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YQr/41KWdn2hJYPYsmmgn9bYBJrMQ/0y2hDsszhW8Gk=;
 b=SyeARUEX7QY6PnFIM7KXh8R1riTkX4IX3GBx9sobeEIDQXEQRplH+Z5arSdghBgi7h0Q+6MqBRT38Z3WVVs6LDEB/0HZElVekwoIMtYDnYmcQ6HMqUv6BnLghkecSGeTmKvbAVFKP/bFTeLzN9ZfdJTOnBKb+tPiHUb3PnamZ0k/c9crJ9r1Jl1wF7pLD7Bsa5CJpoilNWbHZrOZa0my5KVwr0iZCoTyr421Mz6Xqah6i4lMdGCAdryNrBkjX3L6D/QUkWtT7GeBcRxW3FQ2vWDI/a5Z469BCjI0aNmHTHiYfJ3k82F7aKKilsG78QMvou2WhS2qjiNMB+lBFhS9/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2eab851f-0fe3-8462-cdbf-b438dc01ade1@suse.com>
Date: Thu, 14 Apr 2022 16:15:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/2] x86: improve .debug_line contents for assembly
 sources
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
 <YlgWKGmR+u41zSsw@Air-de-Roger>
 <04f9bd9c-70da-0966-afa6-96f81e290204@suse.com>
 <YlgiLhvsKVYKKvrr@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlgiLhvsKVYKKvrr@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0547.eurprd06.prod.outlook.com
 (2603:10a6:20b:485::21) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ec848aa2-9c77-4497-38e6-08da1e2137a8
X-MS-TrafficTypeDiagnostic: DB8PR04MB6924:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB69248CE354EF5784F47017A3B3EF9@DB8PR04MB6924.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dRer3x4jPaFpW8xdHuJdkXFWnaZcguW7aaQjn3T3pK51M2xWSAoQBl72WcJhmYzXPRjmeuQe0v64XGLicjmOrZC2mhVd79LbmVzUQFS4fYY0qe2DaIRx7mfVdXznQfLnnWA7EL7DSjOICAz1dz8w/8XTZzb13KfxyBQPvL5fvNLg+M0dt4RA1/DS7i5sqcewQaCwcSee3GKhzRiMCkrRc8XM2LE3tTBOcXJGF6jSYA82ncPT+A/OewGKL35o2IU4QPixgXzkQtc/LgoPhZ3sRQcnUvBwRXB0/x/yX8muaYz5VP8Hsmo1XpDw+XKLEQo6bxosWx0Sfoty4PLxw8/EKA+yYn1FL03au09UZti7fvoYK+6yodLvUzBqAsCE1jNmh9vPCxXZHJCHKB+4VOal/o51HlHkaUZ20A0f9AZCOGbXW6hPUSReFmrYAWBPnCCCjx0oWtkvkzqSI+50ukmz3/Ur7Oer3avODCPiMj0vaEbRLgcy+0V+kvYcUxUQxF2fThnCHnr7DSNsua5ksiGzNeIhqDiPeYQjD/6id/EpgRIrrOuvPw1M3E1hT6azCT5VCFBv+08qmhTk6hcJF5PxPI2tXJr5skf9I66fi0NxqSUoWlf9bB3kefBsHBipXVdNCHZOJOUILLdc9VUJPDUbowflo63eYqAqk9IgeLR3a8tGV8wZNTQvsa00cp7p0koyxu0Ah8Ji07h8yDsjpJCmDylEvPIbvz1RiNozVw+QD1DBB9qiH6Zwbd9C1f/YZlm7n9LZfZeg02DJmZi3BCqwW/RO5Y0T61K9kkoikJ9//PDAsepR5VIzqIl/6S6mQFtjcalGccLHP4wuvB4jRRqM/UvnZNILPR4bn/hWtaqnOmW874/XhE0fz//9Z3Mr1T4zwKTRCZZkxBoLamZWySAUFQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(316002)(31686004)(5660300002)(36756003)(38100700002)(26005)(6916009)(54906003)(6486002)(53546011)(6512007)(186003)(31696002)(8676002)(83380400001)(66476007)(66946007)(66556008)(86362001)(2906002)(2616005)(966005)(508600001)(8936002)(4326008)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pl6d2n2vodof9xe0X/N09LTAHUB6iq4Hgwc8Yc4OLPU4ahoxQYlOoNOe/OEr?=
 =?us-ascii?Q?tV0yhtPapfCG6298weKNWVB9mqh9PGhSYKtz4XQo+/B2xHyKNpJKVKUzqCo7?=
 =?us-ascii?Q?Tp7D8DulOe4nn7iRJsk8xjy9Tj+eDzfEkzeNhFhWyRzZ3xEXKKHftp5hBkdt?=
 =?us-ascii?Q?RxZ+WDjGlWSuwZkLe3K2Xdi+6JhTDmBYtkPu9zjXBkfIopKoNpQeltcUoMHf?=
 =?us-ascii?Q?DX3M0sZFTywPhVm8w7WNZiatANr5SouTxLSYzIEcC0sycHMvIPVaaZFtShNU?=
 =?us-ascii?Q?zk7fmDEKnxP+kWuUZByxi06pIS6a8+V33ADEivztQEvLaC/0AxMoWLGgpt/u?=
 =?us-ascii?Q?LukKljjVyqZjuUmn48FFVOiAQzERjH69qnCFxwm+ZgiRSoSQ9cnUvtzZu5ED?=
 =?us-ascii?Q?LT86jEFHdx+qXVoWsHGvTpxaX9uUVvTxggcOq+YyW9yO4ATQPZYtBTv2iViI?=
 =?us-ascii?Q?urH6bR401XjoCKtW7XuNyYf1oPLE1Arqghwo6QZiONjpzKvcG4R52mywUh1H?=
 =?us-ascii?Q?cEpZP4j46us+1JPsYgUa9mhWexOYxWKCNbjDKESvQpc9EYg8yQEYsjB38sl7?=
 =?us-ascii?Q?p59WKz6wEBXNtClyrSqOh+kqvsK/CAh7S2zlrjvcZrSaNCJEDikay0D6e9BU?=
 =?us-ascii?Q?MoebhUtsX4XgqRh5CLjVg6OzhKfJXer7hMplqIfrh2NUWq1vO/ktzZwzsMUB?=
 =?us-ascii?Q?l4xqpunCLk8BcI6/S6M0x/dQ72ru8leN9thu9y/A7wQ4kns/ciIxacJihDXV?=
 =?us-ascii?Q?Z7uYfSRPXwQSSjC5VUzuL27jfWn8iNSqWsYZeFsFmk7xpdG/yQj7aEwa/k2b?=
 =?us-ascii?Q?QFP0yT+k2jFhAZXt+hHaZzfTE6p6fikNjKt3hgfGYjM4OranYnzskqeswGgk?=
 =?us-ascii?Q?RbUZILCIwq9ZLoV7YXoR9j4D+FDgG7Mu2k9o99GyZlo++SREFUPtsf9stF10?=
 =?us-ascii?Q?HKVUIVd59FCQS3c+/7edHvslOSJtyVuRLRpzr4rn8M+mQ1UQuv0h8Qq0qSmb?=
 =?us-ascii?Q?xP3oAycdyO1qEc9VhlQHtdjVxLWRrLuhuVrSwplKKyHn4DH6E1jnHXkT525O?=
 =?us-ascii?Q?MpDZUKv2n7LJ+qTNw8bNO6ld+Z1hBEOJrNRpQYjdLrRKMjFiEceI/uRBmUp1?=
 =?us-ascii?Q?mHWV3IMmXG8rbSY1/C293m6eg+m1XXi8wEDJaEIzS6+B3oSsRPPkkxdVAVKT?=
 =?us-ascii?Q?8F0vojZ1yPJ7dxzCUOEnTkUZY8yp3pr9wQfOeOKMiidiK3m4eazQ2bwSrDdn?=
 =?us-ascii?Q?WcVSy1sGY47wxS52MPFjexy/NJUNk219Ykkd24epSd7VCpqticVE05uYrHwY?=
 =?us-ascii?Q?kTUoaQDaXvh7H6w7+/wxdgwnAHLpg3JnsQhsvWU3/fhoyaw5mTIIxTGL+IDM?=
 =?us-ascii?Q?WopiIBdXJoHNsPgxLrNFN+y4lTSntX6zSvQb6Q4GHiOhm3S+Otcs2d0hGLUi?=
 =?us-ascii?Q?HgJcn/uUXcrHztGHDAe4Un9+ZaPw7ulNexQ8j2l4VZ1hyIsfeQs6XRmdW3cr?=
 =?us-ascii?Q?s1rKLa1qlw5nnIWqAG+mPk9MufluvxN5Z7Yqkwb+89xYazN84zFtkfM+qaz6?=
 =?us-ascii?Q?LcxWuDfaSFgo85SlGMVNoUy9HJ9252u7MBDlJRfmwEAdy3gqXdEB4Nv4zS12?=
 =?us-ascii?Q?wCuqzAzoirZ2hpY43ahk+2T8goGZIIi8ZI5Vdwv+EGqh2ERFx+vuwC9bRKxp?=
 =?us-ascii?Q?hrP3D+mBrHCyMctmtBemZS0KkW5yWFxIHXBJDIH90cuTJ62TWZL6KuKzYz1e?=
 =?us-ascii?Q?/89Ul5NzLg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec848aa2-9c77-4497-38e6-08da1e2137a8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 14:15:24.4291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1cT/KXfk+PD+dD+pOZ/Qtcf/lhIrfUA2UGNqf38vpxdU3i62xO/ndXXaj60mtyGyu+Sj96NxiULhunCffMmcZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6924

On 14.04.2022 15:31, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 14, 2022 at 02:52:47PM +0200, Jan Beulich wrote:
>> On 14.04.2022 14:40, Roger Pau Monn=C3=A9 wrote:
>>> On Tue, Apr 12, 2022 at 12:27:34PM +0200, Jan Beulich wrote:
>>>> While future gas versions will allow line number information to be
>>>> generated for all instances of .irp and alike [1][2], the same isn't
>>>> true (nor immediately intended) for .macro [3]. Hence macros, when the=
y
>>>> do more than just invoke another macro or issue an individual insn, wa=
nt
>>>> to have .line directives (in header files also .file ones) in place.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>
>>>> [1] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D7992631e8c0b0e711fbaba991348ef6f6e583725
>>>> [2] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D2ee1792bec225ea19c71095cee5a3a9ae6df7c59
>>>> [3] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D6d1ace6861e999361b30d1bc27459ab8094e0d4a
>>>> ---
>>>> Using .file has the perhaps undesirable side effect of generating a fa=
ir
>>>> amount of (all identical) STT_FILE entries in the symbol table. We als=
o
>>>> can't use the supposedly assembler-internal (and hence undocumented)
>>>> .appfile anymore, as it was removed [4]. Note that .linefile (also
>>>> internal/undocumented) as well as the "# <line> <file>" constructs the
>>>> compiler emits, leading to .linefile insertion by the assembler, aren'=
t
>>>> of use anyway as these are processed and purged when processing .macro
>>>> [3].
>>>>
>>>> [4] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3Dc39e89c3aaa3a6790f85e80f2da5022bc4bce38b
>>>>
>>>> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
>>>> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
>>>> @@ -24,6 +24,8 @@
>>>>  #include <asm/msr-index.h>
>>>>  #include <asm/spec_ctrl.h>
>>>> =20
>>>> +#define FILE_AND_LINE .file __FILE__; .line __LINE__
>>>
>>> Seeing as this seems to get added to all macros below, I guess you did
>>> consider (and discarded) introducing a preprocessor macro do to the
>>> asm macro definitons:
>>>
>>> #define DECLARE_MACRO(n, ...) \
>>> .macro n __VA_ARGS__ \
>>>     .file __FILE__; .line __LINE__
>>
>> No, I didn't even consider that. I view such as too obfuscating - there'=
s
>> then e.g. no visual match with the .endm. Furthermore, as outlined in th=
e
>> description, I don't think this wants applying uniformly. There are
>> macros which better don't have this added. Yet I also would prefer to no=
t
>> end up with a mix of .macro and DECLARE_MACRO().
>=20
> I think it's a dummy question, but why would we want to add this to
> some macros?
>=20
> Isn't it better to always have the file and line reference where the
> macro gets used?

Like said in the description, a macro simply invoking another macro,
or a macro simply wrapping a single insn, is likely better to have
its generated code associated with the original line number. Complex
macros, otoh, are imo often better to have line numbers associated
with actual macro contents. IOW to some degree I support the cited
workaround in binutils (which has been there for many years).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 14:19:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 14:19:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304803.519571 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0JG-0003Sw-SO; Thu, 14 Apr 2022 14:18:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304803.519571; Thu, 14 Apr 2022 14:18:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0JG-0003Sp-PG; Thu, 14 Apr 2022 14:18:58 +0000
Received: by outflank-mailman (input) for mailman id 304803;
 Thu, 14 Apr 2022 14:18:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xfxB=UY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nf0JF-0003Sd-GL
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 14:18:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d1b0a8c0-bbfd-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 16:18:56 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-hn_yR_cqN4a2rebs8Ib6ZQ-1; Thu, 14 Apr 2022 16:18:55 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5357.eurprd04.prod.outlook.com (2603:10a6:803:cf::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 14 Apr
 2022 14:18:53 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 14:18:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1b0a8c0-bbfd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649945936;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=fjapXZlj1EwiPsPAor56cwM18lRMpGQ4R7RHmQzyM6E=;
	b=NVClrrxx/CccwMpzFKx5rC7dkHkGVDkYgvAt611XXCvzgTqxSVvH9lZ4ARtJg7JAss/ZfN
	aMe5Kt4W7EVewEwTHApKLfGkzKRTx38YGiC2UdDcfXs5yP1QBH/IWAE3yORIuNVisEXwz1
	VPo0s6kLPhxb8hBi3idWwmVNHJAKTdw=
X-MC-Unique: hn_yR_cqN4a2rebs8Ib6ZQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m0hbrKTH3xBWypD6fnBRQlCvxZI2q/vhaBRigKrkqlQCEUz1dNc0dOWoXUxoOhU4EEKidozuSu/vIfFp2PUBDLqCUjfDAn8PlHYQLqR3UE7A+rQ68I+pBcmviMFjN3rAWnu9jj+eROvyWENevFLyffFzzD856a3bGn60D68tyld9AMw2DkjderRrUKxVjh3rCIEe7fBz5JzbLCwEhKyof+i1jZ9xWNOlJusWIlMKIOTiLB6SbR5+gW6TXSP0b9pMyQt2cxhrv6ABBRaL/BuHADYAxZyopCmjjluEZSwh1RDsHKX/VxnvnLJFJylEY6wU1C8lQL9Tn9Qj0DnEpTQZLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fjapXZlj1EwiPsPAor56cwM18lRMpGQ4R7RHmQzyM6E=;
 b=CJe3rhBP0K1JWwB/3xMVLhI6gfAsCQlUHRK3bqlP2lW6bzNbMaLMVbCDfVuHKNVBio6j2t+FOXrzWvjQbuL331Ij18QvO0pyfH5IIkoEUKUBGesBbsEZZGYcDbUP8SC3iu/cYbUBH+5YKOwSJ2F1lMn/cnMD+XswB0I2O0YlkswZh95BlNUcYXy2LkLKGEsvR9Y8nPIK45nztGNvPqcCMVmxShLt+W5wD8C1mpZPV5zQ8IYdMg7JAJa/7XEujiQLTXA8HHPawzWdPyyfVzs4TqoqpDc7uz1CMaKtWo0vM+4OEYyVWyJBBXqunR8+ygEehwauG5lNffcHJiu+3t0hdQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <55d71893-08f6-f1ee-10fd-666cfd9ec639@suse.com>
Date: Thu, 14 Apr 2022 16:18:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
From: Jan Beulich <jbeulich@suse.com>
Subject: Xen 4.16.1 released
To: xen-announce@lists.xenproject.org
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0021.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::34) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d6798d12-0e53-4b58-e846-08da1e21b428
X-MS-TrafficTypeDiagnostic: VI1PR04MB5357:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53570954C40615BF6488DBCEB3EF9@VI1PR04MB5357.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	X8Mh3cXBQ4/RaiDIHcOolctqIEH9wYx2PVIybHkxMwyI14bGazqxS45XcCShhgdQ7Gwus1tQLLLqe23IhOetsRKzNfd5ntCr3KEWEZopo1N/7hs194Q2IT9HoreWG0Em83nwMcsi8GexueSpmn1KDf648gwGcKqZtqmfRtIM0kYJZLMjSPPSiCxfF7MOdxZ3dNdQPYPtX5OBjzdU6skxS+Rh8oT01XWnWMJR8KnVLDLoc+J5Lx5KZbcvF3xTHAj5FTG2ib9VwNa7jSGzmTKMEOZqtraFVl+rJ0uYwatEOrxJ48kgO72dPVrbVkUMMy1Pd2dxLB/57gZ/3pO3IHxYFNO72c9MwQRuMwYCRkOsQlz0Y143RTGjoDy+rL77mIRoWgn5MSpJ0te0L8YGCRorIChSGR+6Bi6mx0FRNpbzCr5JTChL9Vpjz1Qrfd9uvL5j3vpAqg5CH5jmNfIcvw+so7O34jJriSu9KnMIgE5aF+r7EM+jrxgrKZApaZ/B5OP/YCYZVb7lRZtHX3YVyXwISkuBQJ+asTfG8hJlLnbg9RcOGYv2qPak7cI4Wo4tB0Rv2L412G3EMawUN/GDyRMfx51ZVxMC3LZCQbtrNx38uG92my9KHbxz2uAfDQF8/3ha4vsZUc2Y09iF7SCglYZxsTE9ANF2dEeSal7YpeJw6effQUOFSQP6zKWMZbm+52jzcINTuSpCLCRNxSAzSM+wBb5jM08P8Zt6Zt4OGyN9Q9HmqonaARDHZs4HWEDAuNH8iz0nEFvIqHuI8V3WgteQIbmz/ah3YinO4bFEjKjQDx7KVeAhmCAUKDw5HjoXDX8+X3umZe2Uw6xa0pK+jFA8ew==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(966005)(6916009)(8936002)(6486002)(31686004)(450100002)(316002)(36756003)(83380400001)(5660300002)(8676002)(4326008)(2906002)(6512007)(66556008)(66946007)(4744005)(66476007)(7116003)(508600001)(2616005)(86362001)(26005)(31696002)(186003)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?czJ2V3VwaXloU0NEUm5nbEd0WWhoeDdtM0ZTTkFpS0NiLzJqakVkQkIzTndW?=
 =?utf-8?B?ZmpsdmFROVpvUWdrWUJLbzlUQ2pyeEFCV0FMNXc2WEE5d29maW5US0oreHEv?=
 =?utf-8?B?QkJtdmtGbm9Pc0NDMGFqc1A0M2JkcTlQQUZoNk1IVlJtaDhEb09JWlFoTWZJ?=
 =?utf-8?B?N21DTUdPdncvU2EzTkIrVjhjUzk2Q2RnMmViVDBXem16OVJNNEVKN1dDSmVh?=
 =?utf-8?B?ZGZ0S2lPb3NsUDhIVzc5aThaRGMyMGhqWkMzTEdtWUFZTFNPSFVnQ0I3WTlq?=
 =?utf-8?B?WlRSSE92VDIxWG9Qdk9rajNxQ1FIS3NBU0llQ2FOcnVnYUVFY2RhRFlzeDE2?=
 =?utf-8?B?Vnk3WndtcTJZdlBHYUNJL0J3MjErSENIREdHdTBxdjk2ZnNLZlJ3M21iQ0cy?=
 =?utf-8?B?Skk2ZEtyWmRKcGdFbG04ekFseHplTU5zRThQeVdNemZjT0NOaHpuckZJK3Y3?=
 =?utf-8?B?MW00aDNCNDkrVnRxcVkrY243emxYS0gxc3lHekUyRHZLcHF0VXYxem9TZ0tK?=
 =?utf-8?B?RGlIZVJ0amJhUndUL1Z4U0FsNmI4Y29pU2RPTE43YXN3M250dTdXQklxQmF0?=
 =?utf-8?B?Tlh4WEp4MU5vaTBCRktqa3djaXVZQ1N6VTE1eFU3Tm1YS1BsbzhJTUNIdzQ0?=
 =?utf-8?B?YXV4NlBwQUlGN1FFNTE5UXpObVhtL21ONkxzZGFISTF0UUhDTXBIRlZ0eUwx?=
 =?utf-8?B?aVlSNG5NTktwZFZOQitESGxmaEFrZzlEQmwvc2JDR0lka3hoam0wcm5YMVFp?=
 =?utf-8?B?ZFRnenY0YUpBQTNXbFVONGs4dnFnaGtseVM5V0VRRmxkbG9Tc2N0clVKcEhT?=
 =?utf-8?B?Z2g4NHVnQUdMeXdXR3gxdyszUEpMaU9xeThYVHNpRTdEV0hTMUV3bzI2Wlk5?=
 =?utf-8?B?akNodFZPdFlIZXBMNmJuQ1lSbkZTaHhUdnlibjF0L3FKSThFNjVXQ29JaEpU?=
 =?utf-8?B?Rmo3THVZZEVKMW5CRTNySWU4VS80S09JeDY2NmFneDI4TGJJcTkwdk1DUTVF?=
 =?utf-8?B?RVRIV2hURHBCdmUwdTZObGVjYnZXYkJmMi9qcldCMFMrYWhkdnFzTTBsMVBM?=
 =?utf-8?B?ZGpZZmpGQTRUN0V6V1ZEczA2UVY2NWJNbkdCSGFkeTcvQUZiY0s5NEx1bTAz?=
 =?utf-8?B?SURsMTBYZVZrckVZV2VWTGpZUFFRdUIveFUxS2RrN1V1TU41MkU2TFhsM3lI?=
 =?utf-8?B?NW9pN2JxQmVBRWV4OUtKaDZJTERFNG1pQmRNZzZTZnBYaHdaWXBpOXNnQ041?=
 =?utf-8?B?RkR0aW14MGVCUGRtMmtPQ29JbWlCRVptQ2NxclNPMW1hQnlpU1A2bnFtUVVu?=
 =?utf-8?B?aFRhRkFySTZ1d1V5Ykd0U05HWWd0dS9tdzd2SUhuQk5iSGFvUVpmelpIQTNw?=
 =?utf-8?B?aFk4c3VpQXFZSGdQWlNaZmFlejNaSFV3dWVJYjNzNEp2MklXRjZsSE1YckM0?=
 =?utf-8?B?Ykl2d29PTHV0WDhsT1JnN0pkcHVEQXJ6RW03a2padGQ2eFFwcS9VL1NoT05U?=
 =?utf-8?B?Y2I5Qmp3SDN6OEQvNjI4bFFXMWNXdkFTaDZkMWNlTG1sZkFMU091b29SSFVp?=
 =?utf-8?B?eUFma1piYzc5dFpubGVDMU84RGtIeCtTU3pNRHdHVTQ5REZodEp2OXdwUnUz?=
 =?utf-8?B?NW53V1Y4V1g4U21WTmlYS1RsUm5adkNSU2JFMXQyZzdXdkMwMkFUbzRxYkNI?=
 =?utf-8?B?OXNRU09RVGtzaHNSTmxSQ2ZQNWdwTWN6NGN4WUVjbGw0aWcxYlhza1hLb2FG?=
 =?utf-8?B?K1RGbzBFWVVRVDEvMXM4bFdnQ1dJVm94QzdPR3F3N3NoenJ3TlVDRDdiTnBm?=
 =?utf-8?B?em82SmlXNDBTcmhKNXk1SDdXUVBIbFUxd3Yrd0xSdHZJSlVZZjBLdm1qZEFQ?=
 =?utf-8?B?NWVZVEJEVElYbTdBQ2ZDSy9Rd3dmUjFmdmN3K0lOWUFMSlRaUkZkTXo1T1Qr?=
 =?utf-8?B?Mm83ZkE0WEZkeEt5TUVmNm5CQVQzc1NlTmJsYjY1c21yK1pBV3RWQ082cjdB?=
 =?utf-8?B?RjR6WnJ1UnQ3ZWFabG5ubjVlLys4ZDMvditEVUtXSFdOTGs0V0w3aUw2ZlBX?=
 =?utf-8?B?SEF4K2QvRE1tRzRudWR1dmtsZ3AzaWpVRFIvNlFJaWQrUzkrVG1kZHNNL0Uw?=
 =?utf-8?B?V3kwV2UzbW9idEs5c256NkRrdk1TU3hQTmdZTEpCYVYvQlArRmpjejd5OXRF?=
 =?utf-8?B?aUorR01OODFzMFFNcktQc2orR3NPaG10VUxRYndPazZFT1krMlNFaTZKQVJD?=
 =?utf-8?B?REFLMlh4NEkycnVzQUxOVHBDekVaODloaVI2RFdUU1VHRjdjNW5vTmV5ai9l?=
 =?utf-8?B?SytVWEpNY2FZSlNOMGtLU3hDZVJTYitTK0ZVUzh2ZldsL0FRRWk1QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6798d12-0e53-4b58-e846-08da1e21b428
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 14:18:53.3554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ps67YFGxdnSub0CdzOiTaN1oiXt7RDttHM69ghe7KX045PbPtTuHL0Tbibv8T69qDtfHP68FMWL67RG6Bw7R/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5357

All,

we're pleased to announce the release of Xen 4.16.1. This is available
immediately from its git repository
http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.16
(tag RELEASE-4.16.1) or from the XenProject download page
https://xenproject.org/downloads/xen-project-archives/xen-project-4-16-series/xen-project-4-16-1/
(where a list of changes can also be found).

We recommend all users of the 4.16 stable series to update to this
first point release.

Regards, Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 14:20:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 14:20:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304811.519581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0Ki-0004qw-B5; Thu, 14 Apr 2022 14:20:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304811.519581; Thu, 14 Apr 2022 14:20:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0Ki-0004qp-87; Thu, 14 Apr 2022 14:20:28 +0000
Received: by outflank-mailman (input) for mailman id 304811;
 Thu, 14 Apr 2022 14:20:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xfxB=UY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nf0Kg-0004qc-9F
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 14:20:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 06c9d52f-bbfe-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 16:20:25 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2056.outbound.protection.outlook.com [104.47.8.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-7QDFHWLWOV2FtGb6eOWJoQ-1; Thu, 14 Apr 2022 16:20:24 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR0402MB2854.eurprd04.prod.outlook.com (2603:10a6:4:94::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 14 Apr
 2022 14:20:23 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 14:20:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06c9d52f-bbfe-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649946025;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=HIpINN10M4B1EE/hnQMA0x4phNaVNsddRcEiCwGhGac=;
	b=c7Bt/LYzsq1if+6XHngo1gD7YI5Jim027iayMdgMxTN+bieTyhnOYPu81lfSI8nDAMsnti
	12rX8GJo08EVZpu33ww/cfGYgMaGy/YDtMUcXP1bFjOXR2+KhnGzCwsy/et+y18CQMoRr7
	M48iyznpasWvBS+cOWySecguVZOzE9A=
X-MC-Unique: 7QDFHWLWOV2FtGb6eOWJoQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hLfFBv7GlmQuYpAuF5mJGN5gmA3cPALHW2+9qepQUbC1A/Y5TH5KA6HDzoe7CENQLv7m1fL+6CFRthtAi3WKTo7sRfxo5bqgnNSHhQZ+g1prF4ppzvYYFTRN4TPDHy84PaccoeM1C1ohZO6I6OtkviuRjpC1yxB87r0z2F3Nu5Iqy3XZPvUtqxqRPMM4RIEvd0ofhAViFBL54F+SpJHC/jszP/vFxIxSCxEOI9z8je1gvH/yvvYTDBlbvCwZhDC1L49O2ykM+25bhugQSJ3mOdcI2aFCsGyZszDxZ6SC5s5QffmkLeuJKSutsOtl0Qxo2c9vSW7z3n0jZk0HiIhIsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HIpINN10M4B1EE/hnQMA0x4phNaVNsddRcEiCwGhGac=;
 b=S6HhldSFYsODfguuoCWhmbIrNLJkUMmMhTTqAYs8djQjFCd0zVRaJm2b0lX6T08y61zepUqjmNZcFP3y6rVlXTvGVhimzBrPr9+r3wY0ZdbUhzcT6GLSzat4J2gplckv7iNYYEP88zzocHgQz3vD3CwooKwZNTz1LOYxbYTUDgX9E7m4BCNU78Pm9EpT9IcmKqOC0/HL2C7vH259HxPuHyXTiLZ0e3wN2cAC1xPGJcSWhrAcq8CeBbcfW4b1t2Ckei/PvrUr1KfaXJ470egpo+E6odBScRa7Jk4uhulAnzNe0iJHfZTMtQTOUHuT5Ikn9+cubMCp0dDYcE3uYCsp2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d846f9b4-4404-668e-4045-7ae07fc79583@suse.com>
Date: Thu, 14 Apr 2022 16:20:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
From: Jan Beulich <jbeulich@suse.com>
Subject: Xen 4.14.5 released
To: xen-announce@lists.xenproject.org
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0048.eurprd06.prod.outlook.com
 (2603:10a6:203:68::34) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b477532-cd0c-41ed-ec4f-08da1e21e9b9
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2854:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0402MB2854EA403C20BA1FD72CAFE0B3EF9@DB6PR0402MB2854.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4mIqEVNk0RcE61elEf25dZ+l0jjBqr8ehylKKnlD7cYL2jVxee8SSjtV+ToFOi/uQgUJNQIiEOjdY270q2Al7KwEA2U2eHW5E0UM2T2ZcDuDZVqimzPim+trTfjp6DCL8nj4k+dBBnnOb4M7QSwYNp32DE27SURp4XIz7QnOnmnPNsyaxDQpaAWgzOKU3q0L9a0rn7fNL3TlLkKScmOKo3ZjuU0k5PRfrNTn9UGNW8XNrECttedoExVBMEgeSLL0qwPgxGFj5xseA83P4/NJoRBkIneB9H6uTuQLkdCjuHk9Yfz9oSHsIfgY2V19MRArza+tpuonE6KEDvXT/xaqudztU/UHjk0TCxYFpncptO42Hq+nrzpXU47DKnGNtUsaDgmXvVk2wPN5d7rVh8atImhQvuNIhKe0PfaCrIT4oKQwmk7uFRbEak2NM2L11eq3/+HjLXZD4ZCb56pzejVmOQlwn/bQHSpqhrYsc8DIXWaUsFOx8adEWoaflayp2mm50LqAHIK7c8QhdPoPkrlLLTyKlu3gXYUij/FrHfQ6VKh4zK3VX9j8/WyidCQIj+jzYgre4W7ZHPQRu6YRoHBy/xcm9L0EJabhvMdnKYz3r8o5a0BjK0d4cjd1golKsVE4OUMHu5At/GrXrzP4KZ/D9GnIrDgss6C7wSeRa8IVRjyOSXrfNeVygUSIxSUu9T/QbGONfxaym/Hg2Hw+YAgUi7JkVhdLxeUnNNMZCsH/7Cx2X7OfJ8ZBvSBVv2BwqPehbZzVmUd9TE96+j1qm0oOx5OAmiCsUlKiKmyVqaS+lo2zWg0cbhlHZXK/6wT6SOGbGY6cL5HBllKi78SYjnx2MA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(2906002)(6512007)(86362001)(5660300002)(6486002)(4744005)(7116003)(966005)(508600001)(31696002)(6506007)(450100002)(8936002)(8676002)(66476007)(4326008)(66556008)(38100700002)(36756003)(6916009)(316002)(31686004)(26005)(83380400001)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUh5djBnUVZpQlkxRU1uUzM0dzdsWVNnWDBoWnNhZGQvRGtlaVFhNnBhcmNJ?=
 =?utf-8?B?a1ZPalNTWEVIc3hLQjFMbUZIVzBXbkZ2RWxLT1hQeFNzelRpWkVYOER2QXRa?=
 =?utf-8?B?Z2Y4Yy9zYmF2bW5LRzIyNXZoQ0RkT2dZOFJNeHBya2pKTnAvaWRkYTFWd1Z6?=
 =?utf-8?B?WTM4eXptWnVhQk5FeGtkNGMvSHZFcW9kemVJTHQzZ3ZEMVZtc3IzdVIyRy9S?=
 =?utf-8?B?TWppZmRsb2lIajNwd0xoMzZpS1k5dVpkWkF4bWtVdFV2bERKM2tDeDJ0WHJX?=
 =?utf-8?B?V0ZwNS84czhPVmdhd3lIa1Q5OEZmWVBtRG81S1N4UGFDeWdlR0dMc3dEQ0lp?=
 =?utf-8?B?L2xtNkJZRDNsRXJ4NmNodXJ6dzhabWFlU3ZLWHdkcmVOZVNFeWNDNFcreDd3?=
 =?utf-8?B?dXhpdVBGRk9iRzM3ci9kSHZtdTdSeGxvNmFKbkk2M3p2T2tOM0xncUxxS2Nm?=
 =?utf-8?B?bEdub1c3TisybElsd2tzR2xzWFJjcHFOTks0MDg5bUlUWjBVWXJscWc4WUs2?=
 =?utf-8?B?MVI2WWNpa2ZlRE9kSFlNMEIwUFdYbGxxMnVzMlRINmxoS0FZWmFGYVc2ZHFa?=
 =?utf-8?B?K1c5ZmhpMG5STXlXSDUzTzdkeDI5WlEzV2lBSEFrOVJFRlp0TmNTWmhnU2FL?=
 =?utf-8?B?STRoWmE3NnRTQkVQNG1UbE9ySEZ4UUU4Y3NhMW5INUVHd3JsTVRPa2pYM3V1?=
 =?utf-8?B?QytGSzkvK0h4QWQ1ZHpkN1dLTDk5S2R4YmpoRzA0ZEsyQnM0bzY3WmcydjZx?=
 =?utf-8?B?eWNjZGM0S0RDV1dzYXZNVEZNS0laQWRRRmFkU3ptSlcxWG5HditYaFROclNq?=
 =?utf-8?B?RW9JcXVmTk5tYjVzcmhBZmhFQTNaL0dKY3B5b1lleDBSeE5EOHdaNzNrRzVo?=
 =?utf-8?B?NjdVbm9MZjZpcjhZVnU5dkZZTkRxZTNyZ0tHZ1hzYmxRSzZGSnJra2FpZGc2?=
 =?utf-8?B?ZFoxOGs5eWt3RnhBVE5EVHlocm0ydFFnZGVEeDdTSEw1a21DNENZbmhEMWJ3?=
 =?utf-8?B?eW5lSXdBR3pYZDd2SEtzQU1nM1UrZW1DVjNjYUg3bmtxQXdtclNnSnFOcFJu?=
 =?utf-8?B?ZEdoRG4xckVtbjNvaGh3SHRkSS9ySXBaNTlxaDZZR1NWTUhidUtYMGlVRE9K?=
 =?utf-8?B?dk80SEk3OTk2Vkg1MlpobXRmWEtMa0NUdVdTQ2pGVFpyamRMV1RXRzhjb1k5?=
 =?utf-8?B?a2l2cmduQVV1azVMS1haa3NlMXhVTit5WTFGNGVRQ3NpZXROblpmNjdOdWhD?=
 =?utf-8?B?U0RVc0hXTHpHYlVDcGFpU242SVdDc3FwWXl6MG1MeThGTnJSUnN2M1AxeEJn?=
 =?utf-8?B?VnA0OENRVnphOVd0SEM3eXBtVHBxVVpUU2hwb1VvbG9lbXd6Z1ZJM2ZWVXVV?=
 =?utf-8?B?ZklSbVNJMVNuRG9UbTFoVmY1RjJ0Zy9qcEw4NC95RVE0dEg2V2RWUzhSZnlQ?=
 =?utf-8?B?bnBEZlpFd3BpR1Qzc0VIRFQrc0dKZlhzQ3dxUm40U1hyTDdlUDhzazZoZkRw?=
 =?utf-8?B?Z0ZSWHUxbjYxRis0QVlKbHc0azU2SFpjY0dTdUJacUNtUzhRazVDcE1XOVdv?=
 =?utf-8?B?MGlaVGZieWdSUzg3RUpJVUltcTVLcTRmdTY0U0xyMjBCbG14NUE0Sm9Db1cy?=
 =?utf-8?B?NlJBREdYMzBBYU9wbHBlRlBvTmZZZVhjREd2dVc1SUtoY1JvM3RMY3RVZXZ6?=
 =?utf-8?B?UUJ2ZU8rNHBJWU93emhINWt5a3grVEFBSTM2QjdsNHFPZFZ4Nm56bXhMTTAr?=
 =?utf-8?B?RzR5Y2o5YzdYTkRzeDExVmNJblVUK05jV0NYWGRDZXcvdVlSbkRwQ1FqdkhS?=
 =?utf-8?B?ZncwUjEvaW9ndDlJb29PZE1RWCtaVkRrUCtPdi91aVRmNVlNd0Z6VVY4RUto?=
 =?utf-8?B?NVphcUYxQUVkY3A4b2RnWlYxSEh5SDl1UFJLcDhaemhIc1dKN1B5UlBoOFlK?=
 =?utf-8?B?cCtkeHJneGxGVTRrdUhQakRsZ2pvMWVnbFVFNDJ2UWtZVU04bHcxODBwZWlU?=
 =?utf-8?B?NGpOYzU4cHhHRWh6eDNBUm5nazNtZkpiWnNINzc0SVdiNVZza0prNGR5QnAz?=
 =?utf-8?B?dURydGJlU0k3d3grRDhaQlF6Skw4OUFsVFpJekM0d2lHYUhqQVR1eEV6WkFn?=
 =?utf-8?B?dWp5L1dHTGU5elBDVDQ2RnRjYjNOMzBPTXhtYnBWcHZTUWo2RmZTdkJkbDY1?=
 =?utf-8?B?Y1IxOVF6V3ZEYThnNGFhYm9uSGQ0THZWRVhTZlhidlpBMFFmY0pOS3hMSy9H?=
 =?utf-8?B?eWJISHNBTmtrZjJFWVhWZEl6NHZhWjNtQlNrVVJuS2ZXN0ZhVXZaV0VxQlp4?=
 =?utf-8?B?RXVXL01JRkg3NWRqWVB1SnI2OFJqV0lMd1ZSQkdVT2w2aGxGQXp3UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b477532-cd0c-41ed-ec4f-08da1e21e9b9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 14:20:23.2094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qIL6dYxPLUpBKLkzNkA3pJpWJQRR+K+kEOrTFdqKib+MrP5PD9DynQivQMxTnL879zwZot68UmrN4Gy8NKS+PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2854

All,

we're pleased to announce the out-of-band release of Xen 4.14.5. This is
available immediately from its git repository
http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.14
(tag RELEASE-4.14.5) or from the XenProject download page
https://xenproject.org/downloads/xen-project-archives/xen-project-4-14-series/xen-project-4-14-5/
(where a list of changes can also be found).

We recommend all users of the 4.14 stable series to update to this
now hopefully really last point release scheduled to be made by the Xen
Project team from this branch.

Regards, Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 14:41:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 14:41:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304820.519593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0eg-0007Jm-41; Thu, 14 Apr 2022 14:41:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304820.519593; Thu, 14 Apr 2022 14:41:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf0eg-0007Jf-0C; Thu, 14 Apr 2022 14:41:06 +0000
Received: by outflank-mailman (input) for mailman id 304820;
 Thu, 14 Apr 2022 14:41:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf0ef-0007JV-CL; Thu, 14 Apr 2022 14:41:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf0ef-0003pi-9G; Thu, 14 Apr 2022 14:41:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf0ee-0003wH-Vs; Thu, 14 Apr 2022 14:41:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf0ee-0004ju-VO; Thu, 14 Apr 2022 14:41:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PiXp153Yn1/MgdrPZPPaeJr6lXW6PPtavipyutG7JGs=; b=R27xxq3crRGdN/2hkPKrmTebrE
	x4RoPCapnAEZNRRSleF6EbMKc08ec2sgrlBeUeYjbYotUDcrdA3AoW/mLhhBA+T4/aRhYEyTWhHfT
	h0QVwr+qwaGDP7ozgG+qFQKKNJEikG+TSkSUaYBjD/cJSZFyz84YjIF0bI39WkhCMkz0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169396-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169396: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 14:41:04 +0000

flight 169396 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169396/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  388 attempts
Testing same since   169385  2022-04-14 03:40:29 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5086 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 15:36:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 15:36:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304894.519632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1W3-0005xV-2R; Thu, 14 Apr 2022 15:36:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304894.519632; Thu, 14 Apr 2022 15:36:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1W2-0005xO-Ux; Thu, 14 Apr 2022 15:36:14 +0000
Received: by outflank-mailman (input) for mailman id 304894;
 Thu, 14 Apr 2022 15:36:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf1W1-0005xE-Rk; Thu, 14 Apr 2022 15:36:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf1W1-0004rD-Ox; Thu, 14 Apr 2022 15:36:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf1W1-000584-8F; Thu, 14 Apr 2022 15:36:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf1W1-00033z-7j; Thu, 14 Apr 2022 15:36:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+D4okXkKXYBWoZeOy+lLkfj1lQf5DVBpU8BtlZFtvQQ=; b=xlJXOq/Px3fuFiQ2dCgRH50M9E
	EPyBetYhFRr8X8xPjKiiB9DGTLfXerUrUDKxTj4HsgIYUYlN58qxp0AKV+ebk4IRs4fxNadS+o/ZN
	yksVI49KE4t8NVss7E3PjeKNyaVw6CAOGBRcKhrkm1cyVq1wp3Rm39pQsWiL0R0WCBZ8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169397-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169397: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 15:36:13 +0000

flight 169397 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169397/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  389 attempts
Testing same since   169397  2022-04-14 15:10:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5103 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 15:51:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 15:51:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304906.519643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1l3-0008Hc-Hb; Thu, 14 Apr 2022 15:51:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304906.519643; Thu, 14 Apr 2022 15:51:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1l3-0008HV-EB; Thu, 14 Apr 2022 15:51:45 +0000
Received: by outflank-mailman (input) for mailman id 304906;
 Thu, 14 Apr 2022 15:51:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JhPh=UY=citrix.com=prvs=096381d68=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nf1l1-0008HP-Q3
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 15:51:43 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c5c20ff3-bc0a-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 17:51:41 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5c20ff3-bc0a-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649951501;
  h=from:to:subject:date:message-id:mime-version;
  bh=UfdD6DNA2F/xxG9DeQm9MsaviDoNXSr6zE/nTFJ1pEY=;
  b=ItxpqUI1v2hXKdzgb3pwGIJ2S+4R5MEYheTTa64P2lpgdAgF6YRMxCSz
   37MxMQFm6gaAYWHyUZxhmwHGmVfZltVZiciXDHxES7lDAy7Uto2TlaEzb
   PbRsOXDlJIaIRQrtaiphteEmdk4whehcjEKBeHAg9mSzFv9fV/NcsrGdY
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 71391243
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Aydu364ZRIJiBmG3AXjZ/QxRtNTHchMFZxGqfqrLsTDasI4TYg02e
 lBvGjDRZK7OJyCgZYg1O70CxjpUvsfTzodkHQppqyk2Hi8U8ZWaDtnJcxz+YnKeJ8CaRRlp4
 8kUM4LOdJ5tEXWMrxmkOea48XVwivjWFuGmBuSeUswdqXeIbQ944f40s7Jp0uaE+OSEPj5hm
 e8eguXSZgX0hTR5OG9Juvrbpko2tv3/5m0V71VmOvwQ4gbTnShJAMoTK5/qIiqjSOG4PAIbq
 8Uvbl2d1jmEl/v4Ior9yt4XSmVTHviKe1LmZkN+A8BOuDAbzsAJ+vt9ZaJ0hXt/0W3TxYgtk
 YkV7/RcdC9yVkHysLVFO/VnO3kW0Z1uoNcr9lDm7KR/Z2WfG5fd660G4HMeZOX0yc4uaY16z
 tQKKShlU/y2r7neLIRX6AVbrp9LwMHDZOvzs5z7pN3TJa5OrZvrG80m6TLEtduZaw8n8fv2P
 qIkhTRTgBvoWh1uK3E1MrsCk9yo2UDudxlEjHvIuv9ii4TT5FQZPLnFNdPUfpqBRNlPn1ber
 WXDl4j7KkhEbprFk2PDqy/ywL+U9c/4cNt6+LmQ2fNtmlKegEAODhkfTXOwoOWji174UNVaQ
 6AR0nV39vlrrhDwJjX7dxnm8Tm7g11bZ+ZBQtc44w286pL34z/MUwDoSRYeMYd75afaXwcCx
 lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3
 RizrAkvoZcppPIE7KXkxEHDpy6Ij8XWG1tdChrsYkqp6QZwZYiAboOu6ETG4fsoELt1XmVtr
 1BfxZHAsblm4YWl0XXUHb5TRO3BC+OtamW0vLJ5I3U2G91BEVaHdJsY3jxxLVwB3i0sKW6wO
 x+7Ve+8CfZu0JqWgU1fPtrZ5ycCl/GI+THZuhb8NIsmjn9ZLlHvwc2WTRTMt10BaWB1+U3FB
 b+VcNy3EVERArl9wTy9So81iOF3l3BknTqNGcugknxLNIZyglbPGN/p13PUMIgEAF6s+l2Jo
 76zyePXo/mgbAEOSnaOqtNCRbz7BXM6GYr3u6Rqmh2reWJb9JUaI6aJm9sJItU994wMz7ug1
 iztCydwlQuk7VWaeFriV5yWQO62NXqJhSlgZnJE0JfB8yVLXLtDG49GLsVsLOh7rrE7pRO2J
 tFcE/i97j10Ymmv0xwWbIXnrZwkcxKuhAmUODGibiR5dJllLzElMPe4I1WHGPUmZsZvifYDn
 g==
IronPort-HdrOrdr: A9a23:7G4UAKGuICeGCxGMpLqFZpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdoZJhSo6H6BEDgewKWyXcR2+cs1NiZLW/bUQeTXeJfBOjZsnfd8k/Fh5dgPM
 5bGsAUYryRMbETt7e/3ODSKadE/DDzytHOuQ6o9QYIcegFUdAD0y5JTiKgVmFmTghPApQ0UL
 CG4NBcmjamcXMLKuymG3gsRYH41pD2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8F
 LCjxfy6syYwr2GI17npiDuBqZt6ZrcI+h4dYyxYw8uW3bRYzOTFcpcsnu5zXIISa+UmRMXeZ
 L30m0d1oxImg7slyeO0FzQMkDboUkTwm6nxlmCjXT5p8vlADo8FspanIpcNgDU8kw6obhHod
 R2N/LwjesqMfrsplWI2zHzbWAcqqN0mwtQrccDy3hEFYcOYr5YqoISuEtTDZcbBSr/rIQqCv
 NnAs3Q7OtfNQryVQGQgkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D5NE++
 PHOKJ1k6wmdL5eUYttQOMaBcenAG3ERhzBdGqUPFT8DakCf2nArpbmiY9Fkd1CuKZ4vqfatK
 6xIW+w71RCBX4GIff+rKF2zg==
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="asc'?scan'208";a="71391243"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DGMCzwuDGAgieJR+g/ZQGYTRkA3Hi1kdYtD4oa8y1yU2E8Gx5L0XBPZphTZrFsnyQqk5UcAoa7h32h/3G3cC6a8zbza+w9/w9B5SdPbeWCZ3pJKaaESGFjw2dzM/SZrMoTLZW/XM1Wo9ZRg8B44GEDHySnNAgSmlgpPkQcSE7XY+/luRY37q5uuqKuXDrhFJyzSUoD4T+hhZ7LXjLxSzhh6kybsZ85gy45EylzorP0+TolqlmyYiq7FePPYRDQc08EKY+zz/HWK9NLYg2KaAKhoyDOKU+tcFIQO/TwV314UkkTOY3NNoISOfKXpgzyj1xxCTkEmMeZJYiA1jLhwWqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pGSbko+WcgL6PKsgTJywUL0utattM8w/OHIWrgcQxIk=;
 b=anb0MmBDHWm7jVfRsd6NoNLPruMxuGZwXPhjWXt3rHdahj29aZ3/u3v9IBq6gZnC5UKQj5w91+ov8JgEWlFTAIgXOlNrWZ1d5wds1LBxiKvAw+KsIqHc75vlo9wwHd9+EbrfGs9XnmLG6s14MoOAhY4YQSijGjjz+IwPDvEKM4dQ7QY8ayjOmaVJ8teVxGa5lEKD38Sns6zdf39DojbRi+lCDW9r8sJrQ6x0SAFxzfDa8qFYvNU8dXgWc2RS00g8d2HSn4OMqq5ScwNnTz8zVa7X/3fTWe6mNjv226SmgOYd/32Yt2aEFwcH7Bsp7iaTLUr0uq7ZdXVlUfTQHfhoDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pGSbko+WcgL6PKsgTJywUL0utattM8w/OHIWrgcQxIk=;
 b=GpOccjMc/EsgOe2oar3K+ZbfDHB3c3+CQ9Qtf2Rh+yBjlnSkKXQU6eq+nvTMgjRj3ohxpq/Z9Gs8HV8ZYSA7mhppvy+XzgB5z1kMbbXhPo46vU6Prc2fn8uw0LMJmiD4PEl4fKV/NvQe1jguSYz0bsOABoACOaPErVFZsY2hDzA=
From: George Dunlap <George.Dunlap@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Subject: PROPOSAL: Delete www-archive.xenproject.org
Thread-Topic: PROPOSAL: Delete www-archive.xenproject.org
Thread-Index: AQHYUBdJiHjKQTnhikefVXxt1bvp5A==
Date: Thu, 14 Apr 2022 15:49:55 +0000
Message-ID: <C3E2E17D-BFC1-48FB-837B-7FB621A3A3F7@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3f145b23-be89-4a26-4ed5-08da1e2e6c49
x-ms-traffictypediagnostic: DM6PR03MB5033:EE_
x-microsoft-antispam-prvs: <DM6PR03MB5033009D0B8198F76C67E84199EF9@DM6PR03MB5033.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: meUjPo8xZQ1167yzVhmKYwUa5tw5pTv/BcZd2bKORUvBZ6tz3kJwL1/Q9ctW79ybfCQM8jm4N28nUhmAw5cndBXtdm4Ls7qGhDjp/Oz53fQwFqtFnuatINKAW5fuNdh931YZ8Wt8yesjc1cp721De6FLbH5M2Hcm7fwInVmVJ79YFzUiGQP7cTyFEh1s8vQ0A78F5hR8YgH6SUQFT4O5r1No/GXJSHnnEeS8hQATT5BCDTSbpnplgdP8gMAZRHZpGWSSkMFvF+xsEx+ahISKRggH+WkyMRbt8L+trDN50XuV5fjsVPL7rg6wzWj4sr/Y36x9gefW9dnvh204SDiFlyP0Z+PKuMFiX11lSzED3rGsEYnHO03ylkCuenRtNfaziny4xkwON7Yrh5AQgXGCf9NiimuZGRj9liT42llzhj2TG5fvuzkVKy5jcsJUMRFCr81zm8dn333uNnfoz6BLmME1xCOBgG+fZJigVYpjGx3lqQap9cXoBpbp9vHJrz1Opya4pErvMJklLAWbHXS+aR9qYI5z+xMNvFbHczIQ/RCRIVGaW0vKKW0OkianCia6Q0EFZWhWXzWd8DXlA86Pyt5C42Lsu/liQJOTNcR5VPxMWoiS3wl2vutwL01lX6hlRKrovTVZShnQezKTvylS4+Nhnpc2WbhuQcpBviUJPvnmP9sOkq6b/5R/dMBzZn3hcrq9DkRsc2Yyk30oTN48vgD0OeAeJNAfEOhoyvoBCiBmq/2z6OT93gJp59vB735KzTQ2/luiefH2yTSQSOumqg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(8676002)(91956017)(6916009)(66574015)(33656002)(38070700005)(86362001)(99936003)(316002)(558084003)(6512007)(122000001)(38100700002)(83380400001)(82960400001)(2616005)(66556008)(76116006)(66946007)(66446008)(64756008)(26005)(186003)(66476007)(508600001)(5660300002)(71200400001)(8936002)(6486002)(36756003)(6506007)(200143007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SHYvOTdQbE1oL2k4aGsrVjZUc013UVZnVWZ4VjRCTWlhNHdQd2U1cWhoRklU?=
 =?utf-8?B?NUQ5Ni9WU2hkMlNTSzBNMmtOaE5xZEhWSHNxOXFIOFNxT2xrOUU1K0tlYjV6?=
 =?utf-8?B?MEQ3blF2WGNUWUl3dU5uN2VkdnJ4eUxGbHRtZWlBUDdZbk8xb1daMFd3OWI4?=
 =?utf-8?B?bW5xMGFTZkxZZTlnTjF2S0tCOTJIVkswU2hsTGtPY3NhSVp1SGN2KzluUUEw?=
 =?utf-8?B?TmRBSTh5S2xtdlJCTlYzMklXZUxkclR2UUFJYUdaQ3U3U29ZblRIQURrZlZi?=
 =?utf-8?B?QVp1bktDNUcxWmgxcVNSUER2ZnBmVUVCbWUvZ3c4Z09Dd0dOSTlKajZoWjg5?=
 =?utf-8?B?VTZzT01ZbjQ2UmpjamUzVTdVeEczald5cGdrS1dQVldrOXdlbFVWSEsxdjlV?=
 =?utf-8?B?T3h4TEhMZEZ6a3BtaXMvQ3llVW11N3VkQXFiNDVObFF3ZWUybnRHVjZLRFdS?=
 =?utf-8?B?cFEweUE2Y05nWnlkYWVTV2pUOG85dzhiNFpURWRmQ2tubGIwY1N0NGVVVExR?=
 =?utf-8?B?eGVRYk9CRVRjU1kyMXh2NS92eVB0bUttbzc3ZWVJU2tOY2pxOU95ak4xbjgx?=
 =?utf-8?B?NmZQaHNhczNVbkt2R3dGalVjMStRUUUvWUxXNjByZkx5OGV3dDZXS1Y1a29j?=
 =?utf-8?B?NFA2NmdlQTRHUlhreGpCUlE3VVljM2NUbXQydnM2VlNXMjJENWVScWcrL3NT?=
 =?utf-8?B?Q3lnWm5GeGhlUVpVUWwzV3pGcnVHa3RrVHJmVGdsMmJDNEJxUUZMaWFXeGxV?=
 =?utf-8?B?cDZ1Qk4zbXM0Qkh1emNhT3J6cmVldksrN1FLQnA0ejlOS3FSM29iTTNQWEdQ?=
 =?utf-8?B?djROMEl5SEpERTd6WGJVUFpIdmNmTjR5SGpTR3VMWXNaRTdGdVkwcDRKZzg3?=
 =?utf-8?B?Wkh1b3dyNGIzZ1c4dTFuRWJVS1FDNmZab3dwYjBpb0VhWWxGQkxneHh6a3oz?=
 =?utf-8?B?SUNKNURUQVdhOWxCNjB6UTVXRUI2NzE5TmlvbEFualdEbnpYNEFKeXExVDBr?=
 =?utf-8?B?TlNOVGZxbFQwVENwOGw3cmNGTmRLUUJuMk9vZ2F6M2xha1A4eGw3cEJBSTls?=
 =?utf-8?B?MzJVTjQ0c3FBOGNQZHVtOWJ0UjU1TmtxdXQwTGZBS2NlR1ZVQ205SDgxcVg2?=
 =?utf-8?B?NzFSbnp6QzVYR2JWQ1RhcHQ3ZDJtRU1aOUtUenlkZTF4N0MweFl1WWtYM2hX?=
 =?utf-8?B?MXNpOGJDSWNXV2ZJWDZ1WnJvVmhpQVlPdEZVc0JmTVlSZmVob1V4cWdYbEU2?=
 =?utf-8?B?eTVheG95RFV1bTE2Q254QXZZL1czaTM1K0duUWZoeUg5aEFJak9iWmNWSU1Y?=
 =?utf-8?B?djFXUVlTQlhUV2FIcGxsK2ZUZHdtUEY1QzNSU2dDVm41aDc0blAxTTJINno4?=
 =?utf-8?B?cE9nOUF4QS9rRGFyeTF3eTROcmcyTDJsNzZ0NDFMVDg2ZXQzVm1IZGVuWG5G?=
 =?utf-8?B?cnFtWm1SeElteE9nSytsbThxR29kNDFkK0ZaVUVlNlp2WXZwQTg2QzNiM0NP?=
 =?utf-8?B?Y2UzTlIzdVVIVS84SXozZEpoUlBld2RDbTRnN3FQRFZEY0g2S1FjcHFmVy9k?=
 =?utf-8?B?Wnl6ZnFIcUx2eDlLWkdKUjJGSEVLcll0SmFnRFhBbE5nYkFZQzhBMis3dUt3?=
 =?utf-8?B?TXNSbGJXdldGTUFiM0VYL0h3Unk3MGQzNCtGNSt1UDdibGFCVCtVM05OYUp6?=
 =?utf-8?B?Tzh0ZFVUbSs4ODBtRk5CdVZ6ZjlweVFzdEVLUVRrVm9wQ1hFcFduTTBlOUJx?=
 =?utf-8?B?WnY0VnBRWGhKTThJUTY0TzFTTGFxTlhlRi9PMEpUc2FrMG9vYXdXSyt2WFFv?=
 =?utf-8?B?KzM3RGVjZXYxWkh2UGMzVlBDVXpzK2Y4a2RvTkZSQkVZdkRVVjc1aXVxNVNJ?=
 =?utf-8?B?S3VIOEoyWDFMMEVvV1JNNjlRN1JsNkFwcnk2Mk5QZmVpU2ZJMXZ3QWpYb0Fh?=
 =?utf-8?B?cGtQMVdFQlN6Ni82c2FkRmFCVWpZK1lid0FJMGQwendTbnVCUUlPbSswNGtp?=
 =?utf-8?B?MXlETG81UGExRUlLTzVSQVUwQ0JRRzNXZk5sNWZqQzc1YnFqcHo1OVpTWGxa?=
 =?utf-8?B?dnFOdnhsczNDNXl1NUNXdHBQSlJzWStDZU5UWWZTQXNVU2FBejNwUnliN2VI?=
 =?utf-8?B?eEd0dUVrM0dlNjE3M0FJS2Y0T2tMelovR2p6aVNXb25pOTJXU3pvSFB3YzdX?=
 =?utf-8?B?bjUyd2w0TkFxTXBjeEpCeDVLcjd5QnFmYjBIbmw5cXFvQ2dYMEw0T0xEbXho?=
 =?utf-8?B?MDlWMUJJM1M4NVdoMmNhU2E2bEY4QjhJYlVwaG9TMmNBaEFrVEd1d0hybkg4?=
 =?utf-8?B?SW1lRFBoRWhaR1A0a2hMZ0RxcERPSFdLUW13eHFmQW01WVk2cEdSenVTNGpr?=
 =?utf-8?Q?aaVVX0Qw5nMoTilo=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_A4E434A6-7A7C-4722-9D37-F034685ACC78";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f145b23-be89-4a26-4ed5-08da1e2e6c49
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 15:49:55.9169
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LptqeFsEN6kourH81jYlC+UJOYtAKHjNJgs+51avpBW930Ny9vm1lvPMmCbg+/1QI0+0qP+tSlX9qg9y6jnFOtBukKQCsnbecyp/HUEQe8c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5033
X-OriginatorOrg: citrix.com

--Apple-Mail=_A4E434A6-7A7C-4722-9D37-F034685ACC78
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

I=E2=80=99m pretty sure www-archive.xenproject.org is at least N-2 for =
websites; last updated nearly 9 years ago.  As far as I can tell =
there=E2=80=99s nothing terribly interesting stored on the site itself.  =
I=E2=80=99m going to pursue deleting it within 4 weeks unless someone =
objects.

 -George



--Apple-Mail=_A4E434A6-7A7C-4722-9D37-F034685ACC78
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJYQqIACgkQshXHp8eE
G+3FYwf/blNC6aoYQrBGcxE+UKaLKg9bmP8/wuMeV7iylMwCLd+C6pnwzKdPuA81
uZXC9FZR8/CB8ZuorfVYUlYGobKj/21gotZrOEJR10mseq/YhrwVOZoiTQcAO4l9
8mt79exa7qA+uOlYu2yLCr5j9tmucc9wypBcw3QOxi32XxyLZAPjTFe68M1B2cSy
Taq/4eBCw15xY4GDXVDe9f1QYKrBQMzpP/uA6W2xJHi+NYFrzIQOlKbJXSsjPCOo
NNt52E0lkEhlLkxdTjJ+FlaSUhismh2DSVWELTMiWdlnUL17TaQVICTP5vKUBdTI
hCy0lDORiOAQ4Qab47/d17FnV6ha0A==
=ijfN
-----END PGP SIGNATURE-----

--Apple-Mail=_A4E434A6-7A7C-4722-9D37-F034685ACC78--


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 15:59:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 15:59:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304913.519654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1sm-0000dE-FY; Thu, 14 Apr 2022 15:59:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304913.519654; Thu, 14 Apr 2022 15:59:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1sm-0000d7-CR; Thu, 14 Apr 2022 15:59:44 +0000
Received: by outflank-mailman (input) for mailman id 304913;
 Thu, 14 Apr 2022 15:59:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rzxh=UY=cardoe.com=cardoe@srs-se1.protection.inumbo.net>)
 id 1nf1sk-0000d1-BD
 for xen-devel@lists.xen.org; Thu, 14 Apr 2022 15:59:42 +0000
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e389b338-bc0b-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 17:59:40 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 8A85F5C02EF;
 Thu, 14 Apr 2022 11:59:38 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Thu, 14 Apr 2022 11:59:38 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 14 Apr 2022 11:59:38 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e389b338-bc0b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; h=cc
	:cc:content-transfer-encoding:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm1; t=1649951978; x=
	1650038378; bh=l9hTAWgSLgGRmvELaQYMDJ5lKCpvQ2aDdF6RNvdGaC8=; b=F
	5i6InfhDlS9dRcfvwaFqFcK02ZXR/W3Za9exws4xZ7ELr24fjfEXafqfgraKGe8U
	RxKT98zTLPhoaur4V5VhxdsICcJvlr0maQevTIChYzROG/97Oe7SHjMpt9RHe2uR
	xRt2AudSu0BSnz66POgpcoGovg77zrYdhZyaQ9JafIs4CSUSfmz//TiSuUyfl7zC
	UWn+QlePzQmgOIAmB1OpsjRXe1GAo7jvBN4ungTCHTXUhO8YN+tVrAPcuk9aoh+2
	KN4aA6K2WCSV8kiPoLoBr+6YEcpErgvLuAaXU/0ljDzvkRx4rnagyRmqDAVF3KwE
	hY+SQvuIkwqEwix2qGFgQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm1; t=1649951978; x=1650038378; bh=l9hTAWgSLgGRm
	vELaQYMDJ5lKCpvQ2aDdF6RNvdGaC8=; b=EVcdmwTlaaDbmFp4SMiK/cmJyWO82
	mutx7KRTkP2oxnxb8AdHGpe3wu+3Ps4VFItLCZd7PiIXR0orahqYv5I6SdEaNRsD
	u3NI+jbFWxs3CI5Lf+ky3GB0MVXazQXs3NghjTRQBuzlQU6sUmC24fmzDNXKJ7eV
	gz+UI/ZX/Vp2Mwr4yc130UNLm8Ic8odPRozYKc68BzAbcMgQPtKs5dN37s4uGGFL
	4ua1LO/onkFpl5zjfGTiZvYF0VAeSWsn9ofYHRRK4EbG6N5W4i+aW4jyWOkW/1Ph
	JhFbyBVywJ2izyG/GvZxJFRksHmt4T47nqJsbKR7ayR96ZGZCI0USiZkA==
X-ME-Sender: <xms:6kRYYlwYxqMfDY-2ZaR0kfY7q3jjjD0n0c4p4a33FR1I-hVJ5iUnog>
    <xme:6kRYYlQjATp6WcK-0caRrvZgCsLF9_jbr2qUgkootJSNBwTdxoVkt5OM4_hf6Td39
    cy5xgv_6EAQmJ4M7zw>
X-ME-Received: <xmr:6kRYYvXaCRlLe3w6XE3f-ZMrSCJMsZuZsvW02fMzBaZQE9iGVG9jsgDaH8mUSL1UjZsNfbjNM-ALiTMnbdED7vjusIZXpRL68VXhgNwessPe1JR_i3QeBjhNiA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudelfedgleejucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurheptgfghfggufffkfhfjgfvofesthhqmhdthhdtjeenucfhrhhomhepffhouhhg
    ucfiohhlughsthgvihhnuceotggrrhguohgvsegtrghrughovgdrtghomheqnecuggftrf
    grthhtvghrnhepveffteegudefheeukeekhefgteduieffheelheeuueehhedtgfevtdef
    gffgfeefnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpghhithhlrggsrdgtohhmne
    cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptggrrhgu
    ohgvsegtrghrughovgdrtghomh
X-ME-Proxy: <xmx:6kRYYnjEqRjKc9ekzxltFOXfx4nH5f_rSXgqoWC9U-k4H1WI5YXmig>
    <xmx:6kRYYnA7sHF_kivAr6QeotAOqUb1R2TKt9c8vvg134zGiGjkmM477A>
    <xmx:6kRYYgKLlinRBiRrubITiPZhhV9jMhwcuBaVVOiB31RA8fGWBR-wMA>
    <xmx:6kRYYjvzGLrfFIlfTg9gXcvQG9cqsB-6MuXAiESgRtoxNXqvQd08AA>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Doug Goldstein <cardoe@cardoe.com>
Mime-Version: 1.0 (1.0)
Subject: Re: Virtio on Xen with Rust
Date: Thu, 14 Apr 2022 10:59:37 -0500
Message-Id: <D1358A28-BCD5-497F-A329-28DBC25AD792@cardoe.com>
References: <20220414141041.ogeaaplnb7mfufsb@liuwe-devbox-debian-v2>
Cc: =?utf-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Viresh Kumar <viresh.kumar@linaro.org>, stratos-dev@op-lists.linaro.org,
 xen-devel@lists.xen.org,
 Stefano Stabellini <stefano.stabellini@xilinx.com>,
 Mathieu Poirier <mathieu.poirier@linaro.com>,
 Vincent Guittot <vincent.guittot@linaro.org>,
 Mike Holmes <mike.holmes@linaro.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
In-Reply-To: <20220414141041.ogeaaplnb7mfufsb@liuwe-devbox-debian-v2>
To: Wei Liu <wl@xen.org>
X-Mailer: iPhone Mail (19E258)


> On Apr 14, 2022, at 9:10 AM, Wei Liu <wl@xen.org> wrote:
>=20
> =EF=BB=BFOn Thu, Apr 14, 2022 at 02:36:12PM +0100, Alex Benn=C3=A9e wrote:=

>>=20
>> Wei Liu <wl@xen.org> writes:
>>=20
>>> On Thu, Apr 14, 2022 at 12:07:10PM +0000, Andrew Cooper wrote:
>>>> On 14/04/2022 12:45, Wei Liu wrote:
>>>>> Hi Viresh
>>>>>=20
>>>>> This is very cool.
>>>>>=20
>>>>> On Thu, Apr 14, 2022 at 02:53:58PM +0530, Viresh Kumar wrote:
>>>>>> +xen-devel
>>>>>>=20
>>>>>>> On 14-04-22, 14:45, Viresh Kumar wrote:
>>>>>>>> Hello,
>>>>>>>>=20
>>>>>>>> We verified our hypervisor-agnostic Rust based vhost-user backends w=
ith Qemu
>>>>>>>> based setup earlier, and there was growing concern if they were tru=
ly
>>>>>>>> hypervisor-agnostic.
>>>>>>>>=20
>>>>>>>> In order to prove that, we decided to give it a try with Xen, a typ=
e-1
>>>>>>>> bare-metal hypervisor.
>>>>>>>>=20
>>>>>>>> We are happy to announce that we were able to make progress on that=
 front and
>>>>>>>> have a working setup where we can test our existing Rust based back=
ends, like
>>>>>>>> I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.
>>>>>>>>=20
>>>>>>>> Key components:
>>>>>>>> --------------
>>>>>>>>=20
>>>>>>>> - Xen: https://github.com/vireshk/xen
>>>>>>>>=20
>>>>>>>>  Xen requires MMIO and device specific support in order to populate=
 the
>>>>>>>>  required devices at the guest. This tree contains four patches on t=
he top of
>>>>>>>>  mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C)=
.
>>>>>>>>=20
>>>>>>>> - libxen-sys: https://github.com/vireshk/libxen-sys
>>>>>>>>=20
>>>>>>>>  We currently depend on the userspace tools/libraries provided by X=
en, like
>>>>>>>>  xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates prov=
ides Rust
>>>>>>>>  wrappers over those calls, generated automatically with help of bi=
ndgen
>>>>>>>>  utility in Rust, that allow us to use the installed Xen libraries.=
 Though we
>>>>>>>>  plan to replace this with Rust based "oxerun" (find below) in long=
er run.
>>>>>>>>=20
>>>>>>>> - oxerun (WIP): https://gitlab.com/mathieupoirier/oxerun/-/tree/xen=
-ioctls
>>>>>>>>=20
>>>>>>>>  This is Rust based implementations for Ioctl and hypercalls to Xen=
. This is WIP
>>>>>>>>  and should eventually replace "libxen-sys" crate entirely (which a=
re C based
>>>>>>>>  implementation of the same).
>>>>>>>>=20
>>>>>> I'm curious to learn why there is a need to replace libxen-sys with t=
he
>>>>>> pure Rust implementation. Those libraries (xendevicemodel, xenevtchn,=

>>>>>> xenforeignmemory) are very stable and battle tested. Their interfaces=

>>>>>> are stable.
>>>>>=20
>>>>> Very easy.  The library APIs are mess even if they are technically
>>>>> stable, and violate various commonly-agreed rules of being a libary su=
ch
>>>>> as not messing with stdout/stderr behind the applications back, and
>>>>> everything gets more simple when you remove an unnecessary level of C
>>>>> indirection.
>>>=20
>>> You don't have to use the stdio logger FWIW. I don't disagree things can=

>>> be simpler though.
>>=20
>> Not directly related to this use case but the Rust API can also be
>> built to make direct HYP calls which will be useful for building Rust
>> based unikernels that need to interact with Xen. For example for a
>> dom0less system running a very minimal heartbeat/healthcheck monitor
>> written in pure rust.
>>=20
>=20
> I think this is a strong reason for not using existing C libraries. It
> would be nice if the APIs can work with no_std.

This was the goal I had with the way I structured the xen-sys crate.
>=20
>> We would also like to explore unikernel virtio backends but I suspect
>> currently the rest of the rust-vmm virtio bits assume a degree of POSIX
>> like userspace to set things up.
>=20
Same area I had an interest in. As well. I played with a xenstore implementa=
tion in a unikernel as well. Some of the code was published but unfortunatel=
y the actual functional bits were not.

=E2=80=94
Doug=



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 16:02:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 16:02:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304918.519665 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1vT-0002a6-UC; Thu, 14 Apr 2022 16:02:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304918.519665; Thu, 14 Apr 2022 16:02:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1vT-0002Zz-Ql; Thu, 14 Apr 2022 16:02:31 +0000
Received: by outflank-mailman (input) for mailman id 304918;
 Thu, 14 Apr 2022 16:02:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f0xO=UY=citrix.com=prvs=09619e58f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nf1vS-0002Zt-OR
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 16:02:30 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 47c75d84-bc0c-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 18:02:29 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47c75d84-bc0c-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649952149;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=dBVTodBtX3hAbW9HcPK0oBLYvslWKKQuZM5s9mLTQ2Q=;
  b=WwNeNLkb8DKwJfdl8YWIrG3vYtbPO2Cw6no/QZs690KWZ0chgjBMeINS
   pFjtAch8+87Wjvc48L6152j0q9j9eO0QpHi4Z2bUfHYviEtLBY6w3hkxx
   UqBfGuGZHl5ylG2OSykYZnDXJBJgXT4YeR9oUzX9pmhr2HDrUxXrSTo4Z
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 68977507
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tpXFcqlFUO2JblfG5UOvEPro5gyWJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJNXj+HPf2IN2L0ft0jYNyz8htQuZ6Bm9Q1QFZkrSsxHiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWl/V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYYgUyBJ/nxuEnDgBVER5VAJUF85LXGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6aPO
 JVEMWUHgBLoRTwWYF0lArcHjeK1uULvWj5Jo1eluv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJ7EfYA2irTz5CJ+gubOUM5dn1KRcwf4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud1IWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtTABbvzt68owGOlor+p5
 ilsdy+2tr5mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8idRczap9aJWSyP
 Sc/XD+9ArcJbRNGioctPeqM5zkCl/C8RbwJqNiJBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WnO3eMoN9Pdw1SRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WZQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:9eL9Zq/MNP2iITZlV3Juk+E6db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wgK7VBaM0ot
 gsCZ4Y542mfvVmHZ6VO91xM/dfKla9Ny4kY1jiaGgOKsk8SgfwQtjMkfEI2N0=
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="scan'208";a="68977507"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aJi5YU0HWid8ojPtaLqXmlSSBB56iFZF7USgyF50/qmCFjVDeF/pKZA4EvTclfIYHeJTdg5JaaFV7gADfmFN5vmd+LWLhSqgS1wtS05HrEu2vdGeNaetGNzC2nMdIDV+BET3GUoV5Fof+OFtETBLEpWBwZNL72cRMWOQBe3vwFNpvhqcVTOhlTaPZSN4LMR43lc/kcQGqk7WFQyeUHWzzOaGrsTCTC8I1s1k3JpdKqgdwzO8ONGYz9UALSda6xQB3yEr3RXwcOZnhYOc+269PNyzlhA//I7jUmfzlx5sPNE90f4FP5kqjNLZGAmVEjCjzZOhuwYMxicyfXERKUnanA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GWucSSDjkz4advjswNkqcdcVCIrU5eHt8e/jefXM3KE=;
 b=koE6/wLCQq3XXXjLIQpqYrF9hVSPDF+dn1frjceRtQGp4ZZQx+ht70r2OsHUSl21O5S4vs2DptMIb1dJcSckxJgTu9qDoQIh9j+BhkOFbx4WRtaVcPegTSzfAQ3yy9JpOa5pZLZA3NXwF2V8fyYqIZJpTiyFeHIGsGkT491tv5Cip44Rmpisvp6RdykhuZUfVBVtYV9ihj9Js2i31uNuPv4S+/gpvs9Qno1xijGm6rs/D2pyIAN9coN85JI0nHUCoXhEpwZATWheYbc+vb855Jka5xy/s2kvcVMBiT75u5OVcucAeq2SVxM2cGN3SjDyVGOjbDH7cZDTA00/0sfWxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GWucSSDjkz4advjswNkqcdcVCIrU5eHt8e/jefXM3KE=;
 b=NRj01e10yOD4tYPHORyZFmg3KNkHnYrrGi/X5WI06srwUNDWHQPlxqEevfw3TZq4rz6yfOQv/n/vneBmG9huJjl5Msw+6sSpVIQ4ysCJHAu/N/lWqpbZSSaT+tLz2WAzqEqYJy7gPhpSP+xgahxrKCYwk0Ee99Zkk0HwFlUlCbM=
Date: Thu, 14 Apr 2022 18:02:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] x86: improve .debug_line contents for assembly
 sources
Message-ID: <YlhFiWYQMbjsOOAc@Air-de-Roger>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
 <YlgWKGmR+u41zSsw@Air-de-Roger>
 <04f9bd9c-70da-0966-afa6-96f81e290204@suse.com>
 <YlgiLhvsKVYKKvrr@Air-de-Roger>
 <2eab851f-0fe3-8462-cdbf-b438dc01ade1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2eab851f-0fe3-8462-cdbf-b438dc01ade1@suse.com>
X-ClientProxiedBy: LO2P265CA0213.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9e::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4824107c-6a1b-4508-7868-08da1e302983
X-MS-TrafficTypeDiagnostic: BYAPR03MB4664:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB46648CC66013E3F12FA3C9368FEF9@BYAPR03MB4664.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: XZ90Zb4LniYoayApSeL+2Mg9xnXSLvOAcpEq5O3igEigcj5EoYVMXKlD4CFpffsx5teonSEALHrWEUnSL+zm3xACLNroZEdPzkFOokiwLHrl4EovSUS/sJGViZ8CoFcPcNvUWJZAZV6CRc7Zf+ChcmovChUFst/j5MTB3gSm7+1iFUyujbRbmgFMo0n7vap0OGGqru8sbKc8ax9eIwvEO7XEVaIkJXd2NVHzeEnzQDEYVDvtueq9sPPWbgllEy4TKj/nLEjI2XTLkHRPdG7k4kYrcEikVeQEbRw10yQZ5WB3F6+wARgmbT/HD46FAGVqxmSiN+2VjAyyzYypsOnTgKPnHJUdos5OSO6Psp3+ZCfHozIAXzf5HxLKijps7ZemRyhD5gFkYw/u8+GY51+fTCOhlBeyaqtXhn0hSJy7B9OPOcH0Ze+ZLWWmQaECyq76gEw8VE7nriM67D8QLgPmf3rUzD1+1wShYEoleSa3SRvgyAPFc47CdYXANR2hkCRK9zBZBf5vP9FfRF1HTvAEXmserK6Ke2XexQspAhR45iePtJ/hk+Gm49OjwfWW+UyqFE/Tefkr3PBIIhGcIsOYMK1HtDpizwaLFJzTlcgjDEbmSxHsbMSAPCyQzhsdoOEeguU9kfP9VTxddTKr2dufThNwxiK/oh7wg0qbazWp2vWDwl0ARckNzmDvSzSCqdMrN4FM8d9u0NQHEbrrnKE2bNyy4FWITHgKZCgEIyiqSygEc4oCAe5kSqLlo8Oig7BlcGmkd301quQOHaoL8o1mowEFH2x6IVS+jUpSLB9gsYv35pVXpJdK4UlU2pA5M4B/p6lcYO4JuKUjgzWviBSC9w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(966005)(6486002)(508600001)(6666004)(53546011)(6512007)(85182001)(6506007)(9686003)(83380400001)(26005)(186003)(2906002)(38100700002)(54906003)(6916009)(316002)(66946007)(8936002)(86362001)(5660300002)(33716001)(4326008)(8676002)(66556008)(66476007)(82960400001)(142923001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlhzTGovU3IzcThoWFovZ01XaW54Y1FVT0NsTm5FbENzQ2tGeCs2WFhibnhC?=
 =?utf-8?B?MHUvMEtBYXVnV1BtcnQvS2Y4aDNSZmxoUFQ5SXA5RHNyUnduaFBUN0VWRDJ2?=
 =?utf-8?B?bzNmaGU1Y05Ldk50bDVoMTU5ZjFHUzN2TzU1MGF0ODdRRm1EeFNLL3dmZ3ox?=
 =?utf-8?B?V0wrRDliUi9XQjl0b2tRKzZqblhXWUhjcG5mM3hXeFk1YjlyN3Ywd1dyWlkx?=
 =?utf-8?B?TjJSU1I2VGNvR09tYnlsWkQ2T1NJWThhQzFjOHB4WUJuL2xGZ2pnVjVXNDVa?=
 =?utf-8?B?QlB3K1lLM20veldCTVRiNmNDaWM1LzF5aUNxYitvdVlzMFdZYm1GUHREcTRC?=
 =?utf-8?B?UGxOWnVUU25TNjF6cU5zeUwzRlNNdHp0T3NBU2M0a1NaSGNkdkE2bmpJb1Fx?=
 =?utf-8?B?OEpaUWYwZXE0aW9xM3RPZHgvRXBFNVhGRmtsM2FtM3pDT09SVzhuYzNUaUMr?=
 =?utf-8?B?M2FkdTF2cjhVZUFrR3c2SWxxQUc2dlZac3BFcEZPRVNlLytJRTBXSXlINFJI?=
 =?utf-8?B?RnpOcDBqa2h2WGJ2SDk3S3p4N0MwT0tndmJLeXloZzlIT2RVT1lRdFRGL2lz?=
 =?utf-8?B?cEVzcTgwbVNhWXVDT00xdnFWVkxNbm5sN1dXalFCRWpZdEN5Y2szbExBOFRa?=
 =?utf-8?B?VVJDTG9Ca3NvclVWTlZYUnVrK015UEtqc2MrVmJHVm9pc1BFOGVsVXhmZHZU?=
 =?utf-8?B?dk9URDgxNEZneGRRMm9lWVVwUXFiRE5RYW8vMkRmcTg3M0xHTzc5YnFjT0ZN?=
 =?utf-8?B?K2ZLOThFZFdvandJQTU2SXJXSFFXY1NPbDF3bXY1S3BJWWZnc0dNaS85VUI5?=
 =?utf-8?B?MGhOUm10NHd3aUZJRFppTCtQMHRCMitnMU1TTzBhOEZFV09KdkNheXRabjd1?=
 =?utf-8?B?OWRDZURDbGI0YTJHbzdQUlJMNVFJa0QwbXhlZXF6WldDVUNOd3Vsand6ZDJu?=
 =?utf-8?B?dy9TaFVQQjBsajRnWm94bEM5bzJmcFZkMlpzSzlqNjNrWGMrZTZUODNuTGh1?=
 =?utf-8?B?WTRGTjlKU1dzS01TZzNCY2Fxek1ITjBjUi9ONDNnbXV1NWZOS0xpczZxb2Rs?=
 =?utf-8?B?WmxKUmhhL3JZekV1MGwybUNFMkRBSVlGS2FDb2hlNm9lQURHUERvVDR5YWVV?=
 =?utf-8?B?ZWs1dnNtSnljNVc3ZUpqbHVHMUgzQjNBMlZFQ3dEM2pBbGZpZTNkOHJVT3Ir?=
 =?utf-8?B?ejRBOFNGZExycnA2TjdySENnUVk1TWxUcUM4aXRCNkhDWUFicUJUMnVSU3hQ?=
 =?utf-8?B?TnNPY2RpY3dXKzY3bkhvb0pDWkcrdFpsZjhpRER3QWFmcDk2ZFhPelR6R1dR?=
 =?utf-8?B?ZWZ2eTZWQ3BqU1Nrc0o3UlBiVzh0TlFMQWdQdDVweFN6dHd2VHFnMGhGV0xU?=
 =?utf-8?B?Y3pETXhDVnNNbXdya2d2RkNtNFdGbFBWWVdkUlpiamNkbGJkTDVLWUpQQUto?=
 =?utf-8?B?UU1DUnRJY0xDdk5qQnNITU5SQkpDcnpSZFc3SWs0QXN3bEc4SkNYdWVncDJU?=
 =?utf-8?B?THJRWGQrS3gwVE1tR0RKR0lacmJqaGxId0EreUcwTVAyNUdhUlo4bjhZczYv?=
 =?utf-8?B?N3JJT0pvVUszMWVMcC9Ycm03L3dPd0dOSHFNK1F3Y1c4bEhSeGRabVFWNVRm?=
 =?utf-8?B?TmtKUkFEVFk4NWpSekZVUmU2VXczWTJUQ2JhczhCdmtqZVRvR0xjeENZaFpo?=
 =?utf-8?B?MjRWc1ZNRFFBL3VrT1ZiNS8relV4dUhGeDdlWTVBOGhsSVVpK2pLMTc3RmJK?=
 =?utf-8?B?MHNnYW9HTGlXdHJlamJBaENSVGRCVUpIQXB4RmczTUVOa005Q3pneXVuYnln?=
 =?utf-8?B?THl1TlZ6TCt2cmFaY0twbnZqSGJCU3hvQlJuUm1NQWR6ek5nUTZ6SkQrWDdo?=
 =?utf-8?B?d2hYRGMrTmVoenRoVzcwaVV3YmVBRGZqVGNzOHlsSlhWMVF4R1JOQUNVQ0lK?=
 =?utf-8?B?cCs0bmNCb3JvVE9qdlNrMnNkK0xPMzN0SnR3dExnMDNKc3NJR0VxeWZwQnB4?=
 =?utf-8?B?ZVZ1QmVWVE1MRncrVnVTdDRYZ3hXNEZvTnlnR1FCaVZoVFJiTGxpYnhYeFhM?=
 =?utf-8?B?ZWdhdFVsM0IwTzB0dFdlT25RUG56TjFmWXdsc2xJZXJXMDg1RURUamRKRHVO?=
 =?utf-8?B?a3RmbHQ2Q3lLR1RjWjlrTmRIZTk2MTZnbFdzVWtNZ05vTWg0UUVLQXpHOERm?=
 =?utf-8?B?cFI3RHY0MTFINGtwYXFIdHptbW5mbExJSlVXdFhnVWhiOGlrenFyUElsQUlw?=
 =?utf-8?B?RFVQMVQyZzFDdjFENUlsRUgyd3g3RG8yQjJjQnhzcFhjMDJoRjRsRFFRZWJZ?=
 =?utf-8?B?U2JlcEk3VUF1Q242V1I3d0hwbFdKUUpRUmZCU2ZYZUtMUnY2SGRDcmJ2Rldi?=
 =?utf-8?Q?3E8xYxfYRWiovw40=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4824107c-6a1b-4508-7868-08da1e302983
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:02:23.1654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AnjjRHNKnLn74FWMAzaApNk18Qy05TXNHeHYgo9hcxZ4pc56DuuwepyEKlfAYQImtx4V86EoVZ44cto5IinD1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4664
X-OriginatorOrg: citrix.com

On Thu, Apr 14, 2022 at 04:15:22PM +0200, Jan Beulich wrote:
> On 14.04.2022 15:31, Roger Pau Monné wrote:
> > On Thu, Apr 14, 2022 at 02:52:47PM +0200, Jan Beulich wrote:
> >> On 14.04.2022 14:40, Roger Pau Monné wrote:
> >>> On Tue, Apr 12, 2022 at 12:27:34PM +0200, Jan Beulich wrote:
> >>>> While future gas versions will allow line number information to be
> >>>> generated for all instances of .irp and alike [1][2], the same isn't
> >>>> true (nor immediately intended) for .macro [3]. Hence macros, when they
> >>>> do more than just invoke another macro or issue an individual insn, want
> >>>> to have .line directives (in header files also .file ones) in place.
> >>>>
> >>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >>>>
> >>>> [1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
> >>>> [2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
> >>>> [3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
> >>>> ---
> >>>> Using .file has the perhaps undesirable side effect of generating a fair
> >>>> amount of (all identical) STT_FILE entries in the symbol table. We also
> >>>> can't use the supposedly assembler-internal (and hence undocumented)
> >>>> .appfile anymore, as it was removed [4]. Note that .linefile (also
> >>>> internal/undocumented) as well as the "# <line> <file>" constructs the
> >>>> compiler emits, leading to .linefile insertion by the assembler, aren't
> >>>> of use anyway as these are processed and purged when processing .macro
> >>>> [3].
> >>>>
> >>>> [4] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=c39e89c3aaa3a6790f85e80f2da5022bc4bce38b
> >>>>
> >>>> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
> >>>> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
> >>>> @@ -24,6 +24,8 @@
> >>>>  #include <asm/msr-index.h>
> >>>>  #include <asm/spec_ctrl.h>
> >>>>  
> >>>> +#define FILE_AND_LINE .file __FILE__; .line __LINE__
> >>>
> >>> Seeing as this seems to get added to all macros below, I guess you did
> >>> consider (and discarded) introducing a preprocessor macro do to the
> >>> asm macro definitons:
> >>>
> >>> #define DECLARE_MACRO(n, ...) \
> >>> .macro n __VA_ARGS__ \
> >>>     .file __FILE__; .line __LINE__
> >>
> >> No, I didn't even consider that. I view such as too obfuscating - there's
> >> then e.g. no visual match with the .endm. Furthermore, as outlined in the
> >> description, I don't think this wants applying uniformly. There are
> >> macros which better don't have this added. Yet I also would prefer to not
> >> end up with a mix of .macro and DECLARE_MACRO().
> > 
> > I think it's a dummy question, but why would we want to add this to
> > some macros?
> > 
> > Isn't it better to always have the file and line reference where the
> > macro gets used?
> 
> Like said in the description, a macro simply invoking another macro,
> or a macro simply wrapping a single insn, is likely better to have
> its generated code associated with the original line number. Complex
> macros, otoh, are imo often better to have line numbers associated
> with actual macro contents. IOW to some degree I support the cited
> workaround in binutils (which has been there for many years).

Seems a bit ad-hoc policy, but it's you and Andrew that mostly deal
with this stuff, so if you are fine with it.

Acked-by: roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 16:06:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 16:06:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304924.519676 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1yr-0003Dz-DD; Thu, 14 Apr 2022 16:06:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304924.519676; Thu, 14 Apr 2022 16:06:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf1yr-0003Ds-A1; Thu, 14 Apr 2022 16:06:01 +0000
Received: by outflank-mailman (input) for mailman id 304924;
 Thu, 14 Apr 2022 16:06:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf1yq-0003Di-Hy; Thu, 14 Apr 2022 16:06:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf1yq-00063k-GQ; Thu, 14 Apr 2022 16:06:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf1yq-0005lN-4j; Thu, 14 Apr 2022 16:06:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf1yq-0001h5-4G; Thu, 14 Apr 2022 16:06:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GfF1wh9MZlLuBuFtzYnFzx7Ts2y7E9T63oOjJA/hdoA=; b=wBP7up0hfB1vGmJyHDAsH8T8J7
	uK22uYZ3WA66doquoZ3pLtL631hF5G//7+0sEg5x8B3RhMEtPeLlpoLKREuqGO0rK5tOglY5cnQFm
	KBu8xAi66B/06r7m+zfF4I1GU6O0r6An5PH7FSti2Vu9R/WvA8f7SnVKI3N5x9ssk7WM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169398-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169398: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 16:06:00 +0000

flight 169398 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169398/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  390 attempts
Testing same since   169397  2022-04-14 15:10:23 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5103 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 16:24:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 16:24:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304934.519686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf2GR-0005fm-5Z; Thu, 14 Apr 2022 16:24:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304934.519686; Thu, 14 Apr 2022 16:24:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf2GR-0005ff-2k; Thu, 14 Apr 2022 16:24:11 +0000
Received: by outflank-mailman (input) for mailman id 304934;
 Thu, 14 Apr 2022 16:24:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nf2GP-0005fT-RD
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 16:24:09 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4e1673b5-bc0f-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 18:24:08 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e1673b5-bc0f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649953447;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=25+u62LbfN5p8WlI5gfw8aa2cbVtJKPyOxqKao7MRgM=;
  b=Mxm/9WW+f9/rJRMkKb7Is8ulMR+lkKh7kOqRswyYie/bzfE0wQazkEuV
   D4+HrbeeY+I6H/BiApPiSxLYU2FiJrPmDQkaxSKIAxB5KVAXnybvz/18Q
   8SL2c27BiglH9SxzSYhuTAqdTdAzgJY70aTLlh9mrMsFKEzATaQSjHdSK
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68980717
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BGisCKOcE/iPamXvrR2gl8FynXyQoLVcMsEvi/4bfWQNrUpx1jBSy
 GYWXWHTbqvbNzakfYgiPYTjp0IOuJ6ByNMyTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl29Iw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 YQK7aKIFjcQLpaQlr0gAkFZUHpaIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTaeOP
 5VANlKDajzkRC9lZGwsJK4lhea52lDBUjB0mnas8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u10bTDwweNdef4SGY6X/qjejK9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc/sBVLUE0F6987rvvwjAOzlcT30aTMNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODEsogz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vdB0xa5hYImS0C
 KM2he+3zMUCVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSnPHKGoNJJcAhiwLpSLcmelvG7v9WremJOcFzNwdeKqV/9U+SJR5hoq9o=
IronPort-HdrOrdr: A9a23:FjXiWaqwaQMQLERsZ86B8eMaV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="scan'208";a="68980717"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH] xen/build: Fix dependency for the MAP rule
Date: Thu, 14 Apr 2022 17:23:48 +0100
Message-ID: <20220414162348.4808-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
---
 xen/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/Makefile b/xen/Makefile
index dd05672ff42d..02a274f56dc0 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -599,7 +599,7 @@ cscope:
 	cscope -k -b -q
 
 .PHONY: _MAP
-_MAP:
+_MAP: $(TARGET)-syms
 	$(NM) -n $(TARGET)-syms | grep -v '\(compiled\)\|\(\.o$$\)\|\( [aUw] \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' > System.map
 
 %.o %.i %.s: %.c tools_fixdep FORCE
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 16:28:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 16:28:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304940.519698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf2K7-0006Iv-Lx; Thu, 14 Apr 2022 16:27:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304940.519698; Thu, 14 Apr 2022 16:27:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf2K7-0006Io-Iu; Thu, 14 Apr 2022 16:27:59 +0000
Received: by outflank-mailman (input) for mailman id 304940;
 Thu, 14 Apr 2022 16:27:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nf2K6-0006Ii-V4
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 16:27:58 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d7129773-bc0f-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 18:27:57 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7129773-bc0f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649953677;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=YpbrNsO5eqU21GpQZ9G2rrY/TRBO8lp6nInT+GXGccI=;
  b=Vdv6JI0vOsqW64hdqk0wtU+/Sc0pvwcd4t8ZVC1y/HsHNRYIE7L1xXlO
   3YTZ1em88Lmh6YAEV93cEhzbeuwrNyeglIC5Pos2mKYwuZwEOdqKl6m7/
   ZZchyyEGIdBFT3GMar4e1ZxARL+FDxHy9/1UoRSmvWspQe3HcS4josggH
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68981224
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dQx8YKABLndCEhVW/yzjw5YqxClBgxIJ4kV8jS/XYbTApG52gmMPy
 modWW+OO6qMYmqjft9wYYuw/BwC6sTcnNVjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jg3tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh/8
 Mxzn5mVEz4gJ7HooO4dTBwFSCZhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4eTKaHP
 ZBFAdZpRA7+SQJ0GXYSMcMVgryBuHjaTht6rk3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru3U70HxUbP9y30iee/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0VeJJLcc/zVu0w7PIxz6TBncBE2VGd4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPTt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPQ1
 JTjs5LAhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGAufh8wbJpfImKBj
 KrvVeV5vs470JyCN/EfXm5MI55ykfiI+SrNC5g4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3CbSgOXiGrdROdTjn7xETXPjLliCeTcbbSiIOJY3rI6W5LW8JE2C9o5loqw==
IronPort-HdrOrdr: A9a23:SFltrao3E1Y8mB/+awMcrCkaV5oTeYIsimQD101hICG8cqSj+f
 xG+85rrCMc6QxhPk3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM
 NdmsBFeaXN5DNB7PoSjjPWLz9Z+qjkzJyV
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="scan'208";a="68981224"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH v1.1 2/3] x86/build: Don't convert boot/{cmdline,head}.bin back to .S
Date: Thu, 14 Apr 2022 17:27:39 +0100
Message-ID: <20220414162739.7251-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220414114708.4788-3-andrew.cooper3@citrix.com>
References: <20220414114708.4788-3-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

There's no point wasting time converting binaries back to asm source.  Just
use .incbin directly.  Explain in head.S what these binaries are.

Also, align the blobs.  While there's very little static data in the blobs,
they should have at least 4 byte alignment.  There was previously no guarantee
that cmdline_parse_early was aligned, and there is no longer an implicit
4-byte alignment between cmdline_parse_early and reloc caused by the use of
.long.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>

v1.1:
 * Rebase over the out-of-tree build work

Cleanup to $(head-srcs) deferred to the subsequent patch to make the change
legible.
---
 xen/arch/x86/boot/Makefile |  9 ++++-----
 xen/arch/x86/boot/head.S   | 10 ++++++++--
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
index a5dd094836f6..0670e03b72e0 100644
--- a/xen/arch/x86/boot/Makefile
+++ b/xen/arch/x86/boot/Makefile
@@ -10,7 +10,10 @@ head-srcs := $(addprefix $(obj)/, $(head-srcs))
 ifdef building_out_of_srctree
 $(obj)/head.o: CFLAGS-y += -iquote $(obj)
 endif
-$(obj)/head.o: $(head-srcs)
+# For .incbin - add $(obj) to the include path and add the dependencies
+# manually as they're not included in .d
+$(obj)/head.o: AFLAGS-y += -Wa$(comma)-I$(obj)
+$(obj)/head.o: $(head-srcs:.S=.bin)
 
 CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS))
 $(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS))
@@ -24,10 +27,6 @@ CFLAGS_x86_32 += -I$(srctree)/include
 $(head-srcs:.S=.o): CFLAGS_stack_boundary :=
 $(head-srcs:.S=.o): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic
 
-$(head-srcs): %.S: %.bin
-	(od -v -t x $< | tr -s ' ' | awk 'NR > 1 {print s} {s=$$0}' | \
-	sed 's/ /,0x/g' | sed 's/,0x$$//' | sed 's/^[0-9]*,/ .long /') >$@
-
 %.bin: %.lnk
 	$(OBJCOPY) -j .text -O binary $< $@
 
diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
index 3db47197b841..0fb7dd3029f2 100644
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -777,11 +777,17 @@ trampoline_setup:
         /* Jump into the relocated trampoline. */
         lret
 
+        /*
+         * cmdline and reloc are written in C, and linked to be 32bit PIC with
+         * entrypoints at 0 and using the stdcall convention.
+         */
+        ALIGN
 cmdline_parse_early:
-#include "cmdline.S"
+        .incbin "cmdline.bin"
 
+        ALIGN
 reloc:
-#include "reloc.S"
+        .incbin "reloc.bin"
 
 ENTRY(trampoline_start)
 #include "trampoline.S"
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 16:34:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 16:34:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304946.519708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf2QX-0007jn-Bx; Thu, 14 Apr 2022 16:34:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304946.519708; Thu, 14 Apr 2022 16:34:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf2QX-0007jg-96; Thu, 14 Apr 2022 16:34:37 +0000
Received: by outflank-mailman (input) for mailman id 304946;
 Thu, 14 Apr 2022 16:34:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xfxB=UY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nf2QW-0007ja-IE
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 16:34:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c4f88601-bc10-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 18:34:35 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2059.outbound.protection.outlook.com [104.47.1.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-MfAtopO9Mta76a-O3MdQlg-2; Thu, 14 Apr 2022 18:34:34 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8955.eurprd04.prod.outlook.com (2603:10a6:20b:40a::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr
 2022 16:34:32 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022
 16:34:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4f88601-bc10-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1649954075;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JqeBv7uNjUwOrelaDS+QCNSnhaBNSrybNsEhnC8M7mQ=;
	b=P/wbW5hwRg/r95i9tzyTnDo6+wLJuQ7YPysfAhavO2BHlE6YKFWUREOOYok4maCk3EOf02
	XH6OLyNO86sZVha0Tb3XOtWCu8QHELUO/L04ASzqEeOPzWM9Ur6ir15fJ6n0FLD5Z5oHTf
	diImV9Dcq+iNCf3ojQHVnWuIPr68IwA=
X-MC-Unique: MfAtopO9Mta76a-O3MdQlg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XoBlh6MW1XHft1ebhetNR1kFIjMFhkjvrYgAdyd6bFi5vJ0dJToxR1TLoZKY8sGfraeTU4D9cC/OGjbfnpLG5nnGqq73fQOWQlWW/oZucJlDaIOgCJdJNhj05MHC5T1xV6TYMGwpw56TFgaCHZscbBZp67j9mCLVJZKs/DZulgTTuI9AfmNvF5BL9tcaoyPexi5ZH/DpiP0OlmYA3tLYgRRjOFP+U4on20RGrE1DBss30gK1G5gd1xyv6zQJZUTLO5BgHXduyDFTt4ue6N/cVDRv5Czd87pojoMrfd71bQq1xofdLeKu8BVDOhOospxhXqNCWVtdhFm85q00zqWvYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SJwdD5Tu+8YeA7HZ1XQVAi4DVCliaFUyUb0bIoJhaHs=;
 b=HGFrkKxkheCHlr4fJDbuW5+IJXXMNqr/gNvI7zA0mBfFBzBoQOudhzXD72yXvIk7L6IFw/giZpWdIe+WjTXdaX1bHOj4b5hr2riM7JQ9fwZBfa3f6JkYjJ7qPzN1BYjs8Ol8bxazuBbuDh6fL3ZQmm9RH5cEpFG6GWhR2cjQvZkNpzkaYpfz62DtGak3154qBlefdTYqaOAuJ2jWc4XdVuvM7ev4x4enxGie/DMqatzyWlSu9vk4kA3PhZFXZbF7oWe0hp7zjHUf9Itmu5sZRrAaZx8lQ5joy1iI9N7hS8mBe6nBROeaJj2HQxXOpt+ZyGzXEKUPVMXVsc0ieKGPhg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4e248866-abc4-5f17-5ec0-22339c48cf0b@suse.com>
Date: Thu, 14 Apr 2022 18:34:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/2] x86: improve .debug_line contents for assembly
 sources
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
 <YlgWKGmR+u41zSsw@Air-de-Roger>
 <04f9bd9c-70da-0966-afa6-96f81e290204@suse.com>
 <YlgiLhvsKVYKKvrr@Air-de-Roger>
 <2eab851f-0fe3-8462-cdbf-b438dc01ade1@suse.com>
 <YlhFiWYQMbjsOOAc@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlhFiWYQMbjsOOAc@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0074.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cb23c8d8-dea6-46e6-7c71-08da1e34a6e4
X-MS-TrafficTypeDiagnostic: AM9PR04MB8955:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB89557E42D885A7FEFC38039DB3EF9@AM9PR04MB8955.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F5/EcH88xo4itt4ey0tIokLlX7aHtQZdKHpt28t9VREuhSXFGaGE5dNTW1TlJC6rzKhHj8MluwpFVL6/TLAJprdOyY2/cCHUyVpWhtdKNeM1nrnx7ei6BPwfIo25ddH1bbFDXikaKFuJPUfekysurAUl1w9B1R/jY786NbywlL2h66/5gCEKxUh1akIHGfV/EyLvZPjsBbWigOnacmsvBBD61/+MfNR9yITjxr16fxknRHQLD3OG/SUtRhomTR12U2ZrW7uUdaamibL5R29uqAb6drtWIAWLfnyDPddCUhZcsm/Hyr3uOMnpksYGIdlUO4LqvGPaVXGnYxOnFadVOIgatTh3ph/il7yBUaoZsquarNrwA032/5HGWB5vPxs7OeOIWY+gbWvwHSLjf0Ih9O3Gah20xU7DVIN6CJHFrrk108FjWd2p3tCDMI9+R7/iIgOuPzor+MiuDcAVNqEI3kYq4IV7CUUs+oSzQiJGssluJl4O4rTiYcUYUuJJv77s6GX39jXIjPVDMSzuUBcXUT/nC1xS3RwVSpsTypYEKdzP6atIEhxV7mj02EWluOGr4w9hAFc7QgsWL8YmQX0DNmOtS313UwNljUcfQXIuHcR1qfFE34PVCDJPrhnQvONjHDh4gQWzldXpXJDwKAhsgkcxDXBBd9IdRJ7DTjDHdUxyRiAWazIlkYtGnvMxi5EvK/dvgyEZHVvR/Yv+Qj95U+absue/5LZnRR20DKGlfNBrTj9dqeHyOCwhKxPalZ+/Y5P2QgdhA/wLdnqBdlKJVYAHIZn/wATzx0K7dW6NeCYx/eqcVh3WtASMc73g06Y7I45WP2yXGVBRCt0aPusQmgbWf5BRtLfWDhmUpNJqMejPyCy3VTB+NZli3V9fevWss5RIUGZBCxq4aFyUKES4cA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(2906002)(53546011)(6506007)(8936002)(31686004)(6666004)(4326008)(6916009)(66946007)(508600001)(6486002)(966005)(5660300002)(6512007)(36756003)(54906003)(38100700002)(83380400001)(316002)(186003)(26005)(86362001)(66476007)(31696002)(8676002)(2616005)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qjjkynFh2PJZcmUdVzlLOIB5guMzHvTBRU0kEq+3hMqGAR3xxjOMhhMEOQbI?=
 =?us-ascii?Q?lnJIjNFMjNFHEHp08u9D8ekq/Yaiy5ApC34V6iP4j4xgHk9QVK/9QMkT9hzC?=
 =?us-ascii?Q?YVzaaKa29GZJHfPive31cizZOL1SVsxn3Ib6NNQr2pcbVZQUBqgMQJzmTXqP?=
 =?us-ascii?Q?EaiBjfL3zxbPZvtZwAOWolMjTMOEsofvEsXSNhr60jaTQFjgr95K29kp+ORk?=
 =?us-ascii?Q?YMWbnYMSAS+TeHOIra700dsYNYFrkA37A5ezo4aMzCl7cf41iaD+bZllLhPA?=
 =?us-ascii?Q?4nPmKLQUtx/Bh1v7n8lJT8wP5mDT01tJKzyCgD/Gt6ne1u7DvCvDtw221Lqb?=
 =?us-ascii?Q?PjSW4+C4m36xKc8KBpYYfu2fQeaYXqYNjfEMzAnIpH2WBrQm9mXL729ZlAmj?=
 =?us-ascii?Q?909WAYzu9zPWicOg2CXsxQD1jlfmpGPeLTnu9g+do7M7L4Vf5+yHkPgPvoxS?=
 =?us-ascii?Q?nO3B/zxxtyYBnHn5bFnfPQm0GKCRyPtDlZtq8FTVYxDdx9Ap7rzNbXpTfa3f?=
 =?us-ascii?Q?04XAXQuWeE1KoNqo2yWdgiCzSAYHN7BoVA2BEFpbeB36UG3RE9qK2TxZ9DrT?=
 =?us-ascii?Q?nhtzukbmBYGHbEclyJrHWVP+tLuGAg0Z0ktycDPrI9G/7/givyWmjnHjAQ/r?=
 =?us-ascii?Q?RfdftKzqtJT/tfV4ioBfAZhUsQgX+vuoHCFEZh0IBd99pgOH5SipaAFSmH2o?=
 =?us-ascii?Q?AmU589hHCkh013CVX1XiyNe25ScJ1gtNBo64ClbS0HAfvv12tMTg2/9qwQA8?=
 =?us-ascii?Q?G5MzwMDXkCfkVOGwXLNAZJJwR8vYk8xlEB77BnXqvoAh2ctihIWF8IL17T6v?=
 =?us-ascii?Q?IVQ+9XkA5nZhov+S7YESGYm02i/km2waTjyeBNetR0Vcm3awU2E5jfytIrjf?=
 =?us-ascii?Q?2WIKDS4j+oGtJ6UswCykV+eFyYbcRJOVzOOJVdNoH26h7turQPGRQ0qnnd+s?=
 =?us-ascii?Q?bjUFwHlsFqSxgs8PjNmiwujNJUUlVPWb3Gz7bRQGEO20mkXTUf0ghDjYLM0w?=
 =?us-ascii?Q?N92azZ5TP2n9rAx/FI0w7IPXBQIOjAr8AlQYwk1IP84LQYCY5xxWVBBqRhzr?=
 =?us-ascii?Q?vBnjzlddWKaRuTNvfqC6tjrxJN8DlCb/Jb6J0PCpPcw8Wxq23iDAhwYY5R3T?=
 =?us-ascii?Q?aNkL+UBLFDLWwBVTGD53e/SWzgWWHo/d+HXmGWb1Ncl+pFnakhq1nZkti8X6?=
 =?us-ascii?Q?QPnkjqhsxcHbzBzqDaS90HrK/Ux34uTuMKRDbnHha/X/MEUJQkNMFN6Dx0GV?=
 =?us-ascii?Q?llRHMoRajfoErfhnjXg3amvWoD6MEFHtdZHz1sCVQHaRDync/6yx6BDLFKZ/?=
 =?us-ascii?Q?/SgoqXwvtf07zPVqJA5fiof4/CG5Xtb2F2HrLdRGFW/vQODK4wJ5L9vo5l4H?=
 =?us-ascii?Q?MbS8wjiHbwSvprJUUnqxuKvp402Mgtktw8ETtPM0rpWyKwVs28+f0SfoUZW+?=
 =?us-ascii?Q?eK1Bde7Hy5f55rBB26GRYwssDVNj7SyKt161fY2Hao2KdnHbdQw8ysc7jKsx?=
 =?us-ascii?Q?YNOLs1xEjTWv91rgURG76yhCtS/DA4sMnW8IyWb2FPA7N0b+yTuTKhNI6REU?=
 =?us-ascii?Q?OvrCySeFNQRKddpvuzuXYn3yFCWGhX8pBe6/QodqtdA5EjtQx3iHIzK+w4ac?=
 =?us-ascii?Q?K74dw5ERmzpRe9aM62B9LiyS+KHlXOyKwLh94VS3MEid+yPEgCKWe4NBkS/i?=
 =?us-ascii?Q?SE+cMM2c//YgqvzAP8asDYXIwz3M3nrEUra2+LhjJezmF+FA7KvlEmUbz6wL?=
 =?us-ascii?Q?BMFzXvDbSQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb23c8d8-dea6-46e6-7c71-08da1e34a6e4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:34:32.6137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 10gVCtEGTOvcvARmhRe11Gq0enJnbGCyM+7/HquokMNQ4pmUAeXi/wMrHnY34xINMMyzcm7gw8MDsAXZIEnnLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8955

On 14.04.2022 18:02, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 14, 2022 at 04:15:22PM +0200, Jan Beulich wrote:
>> On 14.04.2022 15:31, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Apr 14, 2022 at 02:52:47PM +0200, Jan Beulich wrote:
>>>> On 14.04.2022 14:40, Roger Pau Monn=C3=A9 wrote:
>>>>> On Tue, Apr 12, 2022 at 12:27:34PM +0200, Jan Beulich wrote:
>>>>>> While future gas versions will allow line number information to be
>>>>>> generated for all instances of .irp and alike [1][2], the same isn't
>>>>>> true (nor immediately intended) for .macro [3]. Hence macros, when t=
hey
>>>>>> do more than just invoke another macro or issue an individual insn, =
want
>>>>>> to have .line directives (in header files also .file ones) in place.
>>>>>>
>>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>>>
>>>>>> [1] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D7992631e8c0b0e711fbaba991348ef6f6e583725
>>>>>> [2] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D2ee1792bec225ea19c71095cee5a3a9ae6df7c59
>>>>>> [3] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D6d1ace6861e999361b30d1bc27459ab8094e0d4a
>>>>>> ---
>>>>>> Using .file has the perhaps undesirable side effect of generating a =
fair
>>>>>> amount of (all identical) STT_FILE entries in the symbol table. We a=
lso
>>>>>> can't use the supposedly assembler-internal (and hence undocumented)
>>>>>> .appfile anymore, as it was removed [4]. Note that .linefile (also
>>>>>> internal/undocumented) as well as the "# <line> <file>" constructs t=
he
>>>>>> compiler emits, leading to .linefile insertion by the assembler, are=
n't
>>>>>> of use anyway as these are processed and purged when processing .mac=
ro
>>>>>> [3].
>>>>>>
>>>>>> [4] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3Dc39e89c3aaa3a6790f85e80f2da5022bc4bce38b
>>>>>>
>>>>>> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
>>>>>> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
>>>>>> @@ -24,6 +24,8 @@
>>>>>>  #include <asm/msr-index.h>
>>>>>>  #include <asm/spec_ctrl.h>
>>>>>> =20
>>>>>> +#define FILE_AND_LINE .file __FILE__; .line __LINE__
>>>>>
>>>>> Seeing as this seems to get added to all macros below, I guess you di=
d
>>>>> consider (and discarded) introducing a preprocessor macro do to the
>>>>> asm macro definitons:
>>>>>
>>>>> #define DECLARE_MACRO(n, ...) \
>>>>> .macro n __VA_ARGS__ \
>>>>>     .file __FILE__; .line __LINE__
>>>>
>>>> No, I didn't even consider that. I view such as too obfuscating - ther=
e's
>>>> then e.g. no visual match with the .endm. Furthermore, as outlined in =
the
>>>> description, I don't think this wants applying uniformly. There are
>>>> macros which better don't have this added. Yet I also would prefer to =
not
>>>> end up with a mix of .macro and DECLARE_MACRO().
>>>
>>> I think it's a dummy question, but why would we want to add this to
>>> some macros?
>>>
>>> Isn't it better to always have the file and line reference where the
>>> macro gets used?
>>
>> Like said in the description, a macro simply invoking another macro,
>> or a macro simply wrapping a single insn, is likely better to have
>> its generated code associated with the original line number. Complex
>> macros, otoh, are imo often better to have line numbers associated
>> with actual macro contents. IOW to some degree I support the cited
>> workaround in binutils (which has been there for many years).
>=20
> Seems a bit ad-hoc policy, but it's you and Andrew that mostly deal
> with this stuff, so if you are fine with it.

What other rule of thumb would you suggest? I'd be happy to take
suggestions rather than force in something which looks to be not
entirely uncontroversial.

> Acked-by: roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks. Given the above, I guess I'll apply this only provisionally.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 17:05:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 17:05:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304952.519720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf2uF-0002fI-Qs; Thu, 14 Apr 2022 17:05:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304952.519720; Thu, 14 Apr 2022 17:05:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf2uF-0002fB-N7; Thu, 14 Apr 2022 17:05:19 +0000
Received: by outflank-mailman (input) for mailman id 304952;
 Thu, 14 Apr 2022 17:05:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf2uE-0002f1-MR; Thu, 14 Apr 2022 17:05:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf2uE-00074V-Ku; Thu, 14 Apr 2022 17:05:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf2uE-000736-6N; Thu, 14 Apr 2022 17:05:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf2uE-0006FS-5v; Thu, 14 Apr 2022 17:05:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ayCqHguLf1wj2JAV2C+gdILr3PW5xEqlHKaw0J/a5Js=; b=QGUb+ZE4Mhipjplpzo/8VU5OUV
	YX+4vgcAFQBu9+yonvzk1YdVnU8yAtqK5vmzY+kyRQS+JHNQNQn0bQNmeNIe8ptQhsmMkVWiqkaGg
	ielxFUcNh4JLwKnesrQAcydtbf5KkeaY/PjqcgRFrEMKeNFJRGarbN4dDDD3/ZhZ7knk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169399-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169399: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 17:05:18 +0000

flight 169399 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169399/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  391 attempts
Testing same since   169397  2022-04-14 15:10:23 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5103 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 17:11:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 17:11:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304962.519731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf30S-0004A7-K1; Thu, 14 Apr 2022 17:11:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304962.519731; Thu, 14 Apr 2022 17:11:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf30S-0004A0-Gk; Thu, 14 Apr 2022 17:11:44 +0000
Received: by outflank-mailman (input) for mailman id 304962;
 Thu, 14 Apr 2022 17:11:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qEdm=UY=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nf30R-00049u-5p
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 17:11:43 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3ed911b-bc15-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 19:11:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D4174B82AE5;
 Thu, 14 Apr 2022 17:11:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A956C385A5;
 Thu, 14 Apr 2022 17:11:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3ed911b-bc15-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649956299;
	bh=RlbnDQE8CrHXLBBWm8AbRoILmKHoCiwRsc3a4lBjJPE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=r9YY9cKzSPn2Gr2JdVi+jTjn2+HZAp6X8GTLKxp7cJ9xF/b3BGAALuMn2KXE8bwjV
	 2Ll7713S//U+J5Tyg1pjFpz5ooZopF5afuBo+/gu4TTkSG8thGqYvYVtdLFF5vcS7A
	 lR2chB2vNOxafHpInwxu5W+70ftxH5rpMd2AfQNGaaR9TL8tHUuECJWKy1kkpxghSS
	 tHDz+xxBFaECaM0iKQvH1AoH4BihJwYvsJws5Dq4SlCSbf9znMX5AaG5ANu8pytCEn
	 4XNE+3Hohth8b61MacfWI9br27YXEC+zv2XrripGxsgnk5DedVKL6TMNokuydWWocJ
	 2yxyBXbRzFrxw==
Date: Thu, 14 Apr 2022 10:11:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Rahul Singh <Rahul.Singh@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
In-Reply-To: <BA690DF6-577C-44CD-BB01-2E8B2FCFEFC6@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204141001580.3066615@ubuntu-linux-20-04-desktop>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com> <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop> <alpine.DEB.2.22.394.2204081837410.3066615@ubuntu-linux-20-04-desktop> <D24074F6-E6CF-440A-9E9B-A10783C273D7@arm.com>
 <alpine.DEB.2.22.394.2204131657200.3066615@ubuntu-linux-20-04-desktop> <BA690DF6-577C-44CD-BB01-2E8B2FCFEFC6@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Apr 2022, Bertrand Marquis wrote:
> > On 14 Apr 2022, at 02:14, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > On Mon, 11 Apr 2022, Bertrand Marquis wrote:
> >> What you mention here is actually combining 2 different solutions inside
> >> Xen to build a custom communication solution.
> >> My assumption here is that the user will actually create the device tree
> >> nodes he wants to do that and we should not create guest node entries
> >> as it would enforce some design.
> >> 
> >> If everything can be statically defined for Xen then the user can also
> >> statically define node entries inside his guest to make use of the events
> >> and the shared memories.
> >> 
> >> For example one might need more than one event to build a communication
> >> system, or more than one shared memory or could build something
> >> communicating with multiple guest thus requiring even more events and
> >> shared memories.
> > 
> > Hi Bertrand, Rahul,
> > 
> > If the guests are allowed some level of dynamic discovery, this feature
> > is not needed. They can discover the shared memory location from the
> > domU device tree, then proceed to allocate evtchns as needed and tell
> > the other end the evtchn numbers over shared memory. I already have an
> > example of it here:
> > 
> > https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/2251030537/Xen+Shared+Memory+and+Interrupts+Between+VMs
> > 
> > What if the guest doesn't support device tree at runtime, like baremetal
> > or Zephyr? The shared memory address can be hardcoded or generated from
> > device tree at build time. That's no problem. Then, the event channels
> > can still be allocated at runtime and passed to the other end over
> > shared memory. That's what the example on the wikipage does.
> > 
> > 
> > When are static event channels actually useful? When the application
> > cannot allocate the event channels at runtime at all. The reason for the
> > restriction could be related to safety (no dynamic allocations at
> > runtime) or convenience (everything else is fully static, why should the
> > event channel numbers be dynamic?)
> 
> An other use case here is dom0less: you cannot have dom0 create them.
> 
> > 
> > Given the above, I can see why there is no need to describe the static
> > event channel info in the domU device tree: static event channels are
> > only useful in fully static configurations, and in those configurations
> > the domU device tree dynamically generated by Xen is not needed. I can
> > see where you are coming from.
> > 
> > 
> > The workflow that we have been trying to enable with the System Device
> > Tree effort (System Device Tree is similar to a normal Device Tree plus
> > the xen,domains nodes) is the following:
> > 
> > S-DT ---[lopper]---> Linux DT
> >                L--> Zephyr DT ---[Zephyr build]---> Zephyr .h files
> > 
> > S-DT contains all the needed information for both the regular Linux DT
> > generation and also the Zephyr/RTOS/baremetal header files generation,
> > that happens at build time.
> > 
> > S-DT is not the same as the Xen device tree, but so far it has been
> > conceptually and practically similar. I always imagine that the bindings
> > we have in Xen we'll also have corresponding bindings in System Device
> > Tree.
> > 
> > For this workflow to work S-DT needs all the info so that both Linux DT
> > and Zephyr DT and Zephyr .h files can be generated.
> > 
> > Does this proposal contain enough information so that Zephyr .h files
> > could be statically generated with the event channel numbers and static
> > shared memory regions addresses?
> > 
> > I am not sure. Maybe not?
> 
> Yes it should be possible to have all infos as the integrator will setup the
> system and will decide upfront the address and the event(s) number(s).
> 
> > 
> > 
> > It is possible that the shared memory usage is so application specific
> > that there is no point in even talking about it. But I think that
> > introducing a simple bundle of both event channels and shared memory
> > would help a lot.
> > 
> > Something like the following in the Xen device tree would be enough to
> > specify an arbitrary number of event channels connected with the same
> > domains sharing the memory region.
> > 
> > It looks like that if we did the below, we would carry a lot more useful
> > information compared to the original proposal alone. We could add a
> > similar xen,notificaiton property to the domU reserved-memory region in
> > device tree generated by Xen for consistency, so that everything
> > available to the domU is described fully in device tree.
> > 
> > 
> >    domU1 {
> >        compatible = "xen,domain";
> > 
> >        /* one sub-node per local event channel */
> >        ec1: evtchn@1 {
> >            compatible = "xen,evtchn-v1";
> >            /* local-evtchn link-to-foreign-evtchn */
> >            xen,evtchn = <0x1 &ec3>
> >        };
> >        ec2: evtchn@2 {
> >            compatible = "xen,evtchn-v1";
> >            xen,evtchn = <0x2 &ec4>
> >        };
> >        /*
> >         * shared memory region between DomU1 and DomU2.
> >         */
> >        domU1-shared-mem@50000000 {
> >            compatible = "xen,domain-shared-memory-v1";
> >            xen,shm-id = <0x1>;
> >            xen,shared-mem = <0x50000000 0x20000000 0x60000000>;
> >            /* this is new */
> >            xen,notification = <&ec1 &ec2>;
> >        }
> >    };
> > 
> >    domU2 {
> >        compatible = "xen,domain";
> > 
> >        /* one sub-node per local event channel */
> >        ec3: evtchn@3 {
> >            compatible = "xen,evtchn-v1";
> >            /* local-evtchn link-to-foreign-evtchn */
> >            xen,evtchn = <0x3 &ec1>
> >        };
> >        ec4: evtchn@4 {
> >            compatible = "xen,evtchn-v1";
> >            xen,evtchn = <0x4 &ec2>
> >        };
> >        /*
> >         * shared memory region between domU1 and domU2.
> >         */
> >        domU2-shared-mem@50000000 {
> >            compatible = "xen,domain-shared-memory-v1";
> >            xen,shm-id = <0x1>;
> >            xen,shared-mem = <0x50000000 0x20000000 0x70000000>;
> >            /* this is new */
> >            xen,notification = <&ec3 &ec4>;
> >        }
> >    };
> 
> Few remarks/questions on this:
> - this is not a shared memory anymore as you add a notification system to it
> - what if someone wants to use only a shared memory, or an event, what should xen do ?

They still can. xen,notification would only be an optional property, not
a mandatory property. So it is still possible to have shared memory
without notifications (skip the xen,notification property), or event
channels without shared memory (do not link the evtchn to
xen,notification).


> - in xen device tree, how do you associate the event with the shared memory ?

I don't think I understand the question. The example above shows how to
associate the event with the shared memory: the only additional thing
needed (compared to proposal 2 already discussed) is the new optional
property xen,notification.

Xen itself wouldn't have to do anything special when xen,notification is
specified, but would add a similar optional xen,notification property to
the generated domU device tree.


> > The good thing about this is that:
> > 
> > - it is very flexible
> > - nothing to do in this series, except switching to the
> >  one-subnode-per-evtchn model, which we called 2) in the previous email
> > - there were good reasons to use the one-subnode-per-evtchn model anyway
> > - the xen,notification property can be added later without issues, after Penny's series
> > 
> > There are a couple of ways to implement the xen,notification property
> > but we don't need to discuss them now.
> 
> I think there is something to do here but we need a bit more discussion and this can be done later.
> Right now I am not quite sure we will not add something that will end up not being used.
 
Yes, I am not asking to add xen,notification now, neither to the Xen
device tree or the domU device tree. I am only trying to make sure it
would be possible do something like it without major changes to the
existing device tree. And I think it is possible if we use proposal 2).
 

> > Short Summary
> > ------------
> > I think it is fine to only introduce the Xen device tree binding for
> > static event channels without domU binding, but I prefer if we switched
> > to using proposal 2) "one subnode per event channel".
> 
> I will let Rahul answer on that.



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 17:29:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 17:29:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304968.519741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3HG-0005mg-18; Thu, 14 Apr 2022 17:29:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304968.519741; Thu, 14 Apr 2022 17:29:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3HF-0005mZ-UY; Thu, 14 Apr 2022 17:29:05 +0000
Received: by outflank-mailman (input) for mailman id 304968;
 Thu, 14 Apr 2022 17:29:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Reb+=UY=citrix.com=prvs=096d93bb6=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nf3HD-0005mT-T8
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 17:29:03 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5f3a0a61-bc18-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 19:29:02 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f3a0a61-bc18-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649957341;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=xVpSYr4e8iNaOQs1kfEPg/nRoZ26UvAcDAfO6+j29J4=;
  b=EqJC4IJn9wd1Si8zQx1Wxn42CKjJ11Uf6dzM55cewViogsbI1EgNwRdm
   oK5RGNxy/3DsiLfk1CHyFwZPVDGWy46A2d76ZQFAG867zJP2S4Md56nnM
   tXX+wDOns14pwovZRqnvd0KkToMVzzYqLSOv8jaXJU1BymL/6sSHIDNf7
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69392699
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Otas1qCn9DIzGxVW/yzjw5YqxClBgxIJ4kV8jS/XYbTApGkigTdWm
 jFLWWqHO6rbajGkKdtzYYu+9RlXuJHRxt4yQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jg3tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgt+
 JZQmrr3FTwUN/eSmM0BSCNlSDpxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4fRqeEO
 ZtIAdZpRDjAZU1GK0xGMaAVnr6s32LTYTwG+V3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru3U70HxUbP9y30iee/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0B+oTDsIcr12296OOvQawGnM+c2VaZ4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPTt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPQ1
 JTjs5LAhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGAufh8wbJpfImKBj
 KrvVeV5vs470JyCN/EfXm5MI55ykfiI+SrNC5g4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3CbSgOXiGrdROdTjn7xETXPjLliCeTcbbSiIOJY3rI6a5LW8JE2C9o5loqw==
IronPort-HdrOrdr: A9a23:LEXjaKCU+DPjvETlHemu55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P
 xG/c5rsSMc5wx8ZJhNo7+90ey7MBXhHP1OkOws1NWZLWrbUQKTRekIh+bfKn/bak/DH4ZmpN
 5dmsNFaOEYY2IVsfrH
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="scan'208";a="69392699"
Date: Thu, 14 Apr 2022 18:28:56 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v1.1 2/3] x86/build: Don't convert
 boot/{cmdline,head}.bin back to .S
Message-ID: <YlhZ2H9hotfHaPLd@perard.uk.xensource.com>
References: <20220414114708.4788-3-andrew.cooper3@citrix.com>
 <20220414162739.7251-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220414162739.7251-1-andrew.cooper3@citrix.com>

On Thu, Apr 14, 2022 at 05:27:39PM +0100, Andrew Cooper wrote:
> There's no point wasting time converting binaries back to asm source.  Just
> use .incbin directly.  Explain in head.S what these binaries are.
> 
> Also, align the blobs.  While there's very little static data in the blobs,
> they should have at least 4 byte alignment.  There was previously no guarantee
> that cmdline_parse_early was aligned, and there is no longer an implicit
> 4-byte alignment between cmdline_parse_early and reloc caused by the use of
> .long.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
> index a5dd094836f6..0670e03b72e0 100644
> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -10,7 +10,10 @@ head-srcs := $(addprefix $(obj)/, $(head-srcs))
>  ifdef building_out_of_srctree
>  $(obj)/head.o: CFLAGS-y += -iquote $(obj)

With this patch, we don't the "-iquote" option above, it was only useful
for both "#include" been removed.

>  endif
> -$(obj)/head.o: $(head-srcs)
> +# For .incbin - add $(obj) to the include path and add the dependencies
> +# manually as they're not included in .d
> +$(obj)/head.o: AFLAGS-y += -Wa$(comma)-I$(obj)
> +$(obj)/head.o: $(head-srcs:.S=.bin)

The manual dependencies are needed because `make` needs to know what
other target are needed before building "head.o". The .d files wouldn't
exist on a first build. I don't think a comment about that isn't really
necessary, but if there's one it should be about telling `make` to build
cmdline.bin and head.bin first.

Otherwise, the patch looks good.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 17:29:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 17:29:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304971.519753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3Hr-0006JI-AY; Thu, 14 Apr 2022 17:29:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304971.519753; Thu, 14 Apr 2022 17:29:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3Hr-0006JB-7L; Thu, 14 Apr 2022 17:29:43 +0000
Received: by outflank-mailman (input) for mailman id 304971;
 Thu, 14 Apr 2022 17:29:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf3Hq-0006Iz-AL; Thu, 14 Apr 2022 17:29:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf3Hq-0007TM-9L; Thu, 14 Apr 2022 17:29:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf3Hp-0007a4-P5; Thu, 14 Apr 2022 17:29:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf3Hp-0003VN-Oc; Thu, 14 Apr 2022 17:29:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KD5rldBIYvVrt0/Kb8+BJbPK7Gz+kWj/HWe3d/gO0RM=; b=D++0PLxSLErgMOOYZnRi2SMX3F
	/Ft+h28wEcbDIKsaZCIJsR4mYzIequRyMWJ0HNii6dh6DJ0lOdLf04tLj6eYt1GAFalXDlhcxTV+c
	H6iMfIb5Q0jTHImf0KV3S6rauLEIKHr7JGelvq6Q7vqVOdTCtOFgCehTme9Izw2BrJ4k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169400-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169400: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 17:29:41 +0000

flight 169400 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169400/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  392 attempts
Testing same since   169397  2022-04-14 15:10:23 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5103 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 17:45:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 17:45:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304985.519764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3Wy-0000Ih-2y; Thu, 14 Apr 2022 17:45:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304985.519764; Thu, 14 Apr 2022 17:45:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3Wx-0000Ia-W6; Thu, 14 Apr 2022 17:45:19 +0000
Received: by outflank-mailman (input) for mailman id 304985;
 Thu, 14 Apr 2022 17:45:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Reb+=UY=citrix.com=prvs=096d93bb6=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nf3Ww-0000IU-I5
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 17:45:18 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a47a4fae-bc1a-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 19:45:17 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a47a4fae-bc1a-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649958316;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=4NkJuWY1T5u3oiDdR0JcD3BEo2N/VUwMRBI/LTCxpiI=;
  b=L3aYSOSbyBWNVntQWLFk3JqFQd8d/J6EX09rMrIR+qnlIrxkkHGl/+9x
   rNb0NifcGEqc4gn8y02jIRr7+rg1JPAmKQR5uDz+Pm85OMPw9nf8Ts4SF
   1Xr91SvDluJLWqGLd67Fk6tgIE1NlEujKynn4zEpbD9qmDDmX4vqvHEu9
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68872175
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:njgb76h5Hi4AZFjq5WPU+cLMX161ZBAKZh0ujC45NGQN5FlHY01je
 htvWm3SbqzZYzTzKdgiO97jpEkHsZHUy9RqQQQ9rno2ES4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1rR4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQkTEZPXhdYHbzVjFgxZErMXp+eecFHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i
 88xN2o/M06ZPEAn1lE/M4t5m+GnimXEcgZ7l3GUhLA74Hr/w1kkuFTqGIWMIYHbLSlPpW6Ho
 krW8mK/BQsVXPS94zeY9nOnhsfUgDj2HokVEdWQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI
 FBS/TAhxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9imD8IXq+BurHFQodTtsT/M45ZBuHG0Dg
 wrhc8zSORRjt7icSHS4/7iSrC+vNSV9EVLudRPoXiNevYC9/dhbYgbnC486TfXr1oGd9STYm
 WjikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsK4owGWxFADpU
 J04dy62trFm4XalznLlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYKG+zO
 BaN5VgKufe/2UdGi4ctMupd7Oxwk8Dd+SnNDKiIPrKinLAsHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZKdA5RfClnX82uwyGVH8baSjdb9KgaI6e56dscl0ZNxf49ejvgl
 p1lZnJl9Q==
IronPort-HdrOrdr: A9a23:hqMKAa4gvjsb318b+gPXwMrXdLJyesId70hD6qhwISY1TiW9rb
 HIoB17726RtN9/Yh0dcLy7V5VoBEmsk6KdgrNhWItKPjOW21dARbsKheCJrgEIWReOlNK1vZ
 0QCpSWY+eRMbEVt6jH3DU=
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="scan'208";a="68872175"
Date: Thu, 14 Apr 2022 18:45:05 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 3/3] x86/build: Clean up boot/Makefile
Message-ID: <YlhdoQsE10j+VSQg@perard.uk.xensource.com>
References: <20220414114708.4788-1-andrew.cooper3@citrix.com>
 <20220414114708.4788-4-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220414114708.4788-4-andrew.cooper3@citrix.com>

On Thu, Apr 14, 2022 at 12:47:08PM +0100, Andrew Cooper wrote:
> There are no .S intermediate files, so rework in terms of head-bin-objs.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

The patch looks fine.

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

> ---
> I'm slightly -1 on this, because
> 
>   head-bin-objs := $(addprefix $(obj)/,$(head-bin-objs))
> 
> is substantial obfuscation which I'd prefer to bin.

It might be possible to do something that Kbuild does, which would be to
teach the build system to look for "$(head-objs)" or maybe
"$(head-bin-objs)" when it want to build "head.o". That something that's
done in Kbuild I think to build a module from several source files.

> Anthony: Why does dropping the targets += line interfere with incremental
> builds?  With it gone, *.bin are regenerated unconditionally, but I can't see
> what would cause that, nor why the normal dependencies on head.o don't work.

Try to build with "make V=2", make will display why a target is been
rebuild (when this target is built with $(if_changed, )

$(targets) is used by Rules.mk to findout which dependencies files (the
.cmd) to load and only load them if the target exist. Then the
$(if_changed, ) macro rerun the command if prereq are newer than the
target or if the command as changed. Without the .cmd file loaded, the
macro would compare the new command to an empty value and so rebuild the
target.

Now, the *.bin files are regenerated because cmdline.o is been rebuild
mostly because make didn't load the record of the previous command run.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 17:49:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 17:49:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304992.519775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3bI-00010Q-Q4; Thu, 14 Apr 2022 17:49:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304992.519775; Thu, 14 Apr 2022 17:49:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3bI-00010J-Lc; Thu, 14 Apr 2022 17:49:48 +0000
Received: by outflank-mailman (input) for mailman id 304992;
 Thu, 14 Apr 2022 17:49:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Reb+=UY=citrix.com=prvs=096d93bb6=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nf3bI-00010D-6m
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 17:49:48 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 454968ac-bc1b-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 19:49:47 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 454968ac-bc1b-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649958587;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=9X0U8cpphL2NqZykSRAco9CM6VesTPSEoNXW/uxRS9I=;
  b=M2RuOzEIdeGEglgJBRSH4NLFP8vnfcSj32DaHe3NiNWizr1d0zLYMne4
   IT9xw8ONam9etMILPU9l6tqqyIES2aL0oUlxgluyeNMDI2WtzcC14qcxB
   cRg+nqbWAZRoR8mDM898eMyUxcu/uYN+lb4MjeVOMgYdAe4R/swVOBPNX
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69394780
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BQTRhaOi+0iE4K3vrR2gl8FynXyQoLVcMsEvi/4bfWQNrUon1zEOn
 WsZC2/UbPuLMGf1fd5xb4u38BhS68LczYU2GQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl29Iw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 okdl7aQRQ4VBqj3g9YweCJ2DQ56MvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQTK2PO
 5VJMVKDajz7XUxyIGYXIa5mp7uGp1ejSmJ6s1+a8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u10bTDwweNdef4SGY6X/qjejK9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc9wMQ88QyA2E9pLR2B2rK0M/YCBubNNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODEsogz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vdB0xa5hYImS0C
 KM2he+3zMUCVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSnPHKGoNJJcAhiwLpSLcmelvG7v9WremJOcFzNwdeIqV/9U+SJR5hoq9o=
IronPort-HdrOrdr: A9a23:R6jOoaiKe4XDqI0XyuFXWJQwSHBQXtgji2hC6mlwRA09TySZ//
 rOoB0+726StN9xYgBFpTnuAsW9qB/nmqKdpLNhW4tKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5
 0QEZSWYOeAdGSS5vyb3ODXKbgd/OU=
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="scan'208";a="69394780"
Date: Thu, 14 Apr 2022 18:49:40 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/build: Fix dependency for the MAP rule
Message-ID: <YlhetDD/Xsnn2Vif@perard.uk.xensource.com>
References: <20220414162348.4808-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220414162348.4808-1-andrew.cooper3@citrix.com>

On Thu, Apr 14, 2022 at 05:23:48PM +0100, Andrew Cooper wrote:
> diff --git a/xen/Makefile b/xen/Makefile
> index dd05672ff42d..02a274f56dc0 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -599,7 +599,7 @@ cscope:
>  	cscope -k -b -q
>  
>  .PHONY: _MAP
> -_MAP:
> +_MAP: $(TARGET)-syms

That's not going to work well as make isn't going to know how to build
$(TARGET)-syms. I guess you want to have $(TARGET) as prerequisite or
add somewhere "$(TARGET)-syms: $(TARGET)".

>  	$(NM) -n $(TARGET)-syms | grep -v '\(compiled\)\|\(\.o$$\)\|\( [aUw] \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' > System.map
>  
>  %.o %.i %.s: %.c tools_fixdep FORCE

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 17:59:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 17:59:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304998.519786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3kc-0002Uq-Nt; Thu, 14 Apr 2022 17:59:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304998.519786; Thu, 14 Apr 2022 17:59:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3kc-0002Uj-Jo; Thu, 14 Apr 2022 17:59:26 +0000
Received: by outflank-mailman (input) for mailman id 304998;
 Thu, 14 Apr 2022 17:59:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf3kb-0002UZ-QE; Thu, 14 Apr 2022 17:59:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf3kb-0007zA-OI; Thu, 14 Apr 2022 17:59:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf3kb-0008E3-CQ; Thu, 14 Apr 2022 17:59:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf3kb-0002NP-By; Thu, 14 Apr 2022 17:59:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ONAUJJNOGT1BSiQUtCX2MyMOcl/0xWgSDroA8S1GP+I=; b=eBAESBArZaQY+s0cDdEFSQRP0L
	hXwnpugX0WWlCO4Y/Wj/cvhPnjRf19+u3QaQJN39Ddd5A0p84MANZYrMlKcV6qRMZOQRPe/H2kjzS
	UxyHafEdRb4IdEFUXfPgh2hH3Nwm0KwRJof1Lq93CvzTesa22Hd23D+5Jq6/9OEufflY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169401-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169401: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 17:59:25 +0000

flight 169401 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169401/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  393 attempts
Testing same since   169397  2022-04-14 15:10:23 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5103 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 18:10:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 18:10:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.304983.519797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3uk-00044s-TY; Thu, 14 Apr 2022 18:09:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 304983.519797; Thu, 14 Apr 2022 18:09:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf3uk-00044l-Mk; Thu, 14 Apr 2022 18:09:54 +0000
Received: by outflank-mailman (input) for mailman id 304983;
 Thu, 14 Apr 2022 17:45:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxbQ=UY=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nf3Wb-0000Hm-AY
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 17:45:02 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20600.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::600])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9757062b-bc1a-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 19:44:54 +0200 (CEST)
Received: from AS9PR06CA0776.eurprd06.prod.outlook.com (2603:10a6:20b:484::33)
 by HE1PR0802MB2203.eurprd08.prod.outlook.com (2603:10a6:3:c3::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr
 2022 17:44:47 +0000
Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:484:cafe::eb) by AS9PR06CA0776.outlook.office365.com
 (2603:10a6:20b:484::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31 via Frontend
 Transport; Thu, 14 Apr 2022 17:44:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 17:44:47 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Thu, 14 Apr 2022 17:44:46 +0000
Received: from fc7e932e9452.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 39880B57-5139-47DB-84B4-FEC631CC3525.1; 
 Thu, 14 Apr 2022 17:44:29 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fc7e932e9452.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Apr 2022 17:44:29 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by DB8PR08MB5514.eurprd08.prod.outlook.com
 (2603:10a6:10:fa::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr
 2022 17:44:24 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0%11]) with mapi id 15.20.5164.020; Thu, 14 Apr
 2022 17:44:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9757062b-bc1a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rbQpKhI45P+wbcg885XGYSReiuO27OvDqIZBFs70wAw=;
 b=wiLhzyJjQ8b+nq/2pE8ZS3U9+0axW6ecvkl5/q4mQH9o+FBf7gJ+qoEeGz/e46WaphVkXxRiSZVJCgh6t1QTCnPVLVr8HXhK74uXxuuS2nx1XB5sVTN84j62bB6Oe/F/caxQ2FO6/t1nYnFlhR152RK0pTPnBzu1HAhxubq4VWI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 91b5e714b82b7511
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OEQl0xQSo699SdBi20U3MdGQUKd5jYeQq/GJthL5QlLbblc+bA4Au22PPFQD9wWz7r+YherYkb77Lbyp1yeSmeTqOVYhmc0Sys7MnQLtleTBppqljKq9Uxu60JqxflVaicCzo/rOuXJCbjiDA98bGONYuPIfXHDeDeBkt2tLi+cosDS9S3WvNYjUDYAqh45e6xHSqM36Y2H8izMdLlGoYpKg39O5CN+db95VInqht+B4fxX7nZ26w/wZqoewcii9x950cnx4aeNdf7Ws14k06HiKnGkMQOBN6CCxhPU1RJI9iQB6rq5s1yT68mXlq3KSNDRQ7WTHGUpmrt4eZSivgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rbQpKhI45P+wbcg885XGYSReiuO27OvDqIZBFs70wAw=;
 b=KzFGfP6HjrHxOrC2QvXjqEtUrNc/tMdbzmzpr+ZhMAANr2swM76hwJrjGIgQYYaDKsnbdFZO5LTRQZ/+5jBOg17eJA9+FSZEsHiRgoNPIch+kjvR5BNf4Nv9YXzuLccP/Wr9yTG8SaNCeA6rCJmYe+h17KC1V/YpMYrLLGaIq4M3tuF+dbf0UyMk5FjTtXw6SSwp06R6yeBRdY2jD38TB8MlFvJ7usLJZ911YQ5GwFuVkX238LMVJMHZ+aulzt5Lu0cE7YxW2HABX+hb0AQO12ngjJTL2SDKUcoQ4YXbzQnIXNVQ3xgctCfjYXDcVh9g6ysx7mnlVCd3N4jMpXduhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rbQpKhI45P+wbcg885XGYSReiuO27OvDqIZBFs70wAw=;
 b=wiLhzyJjQ8b+nq/2pE8ZS3U9+0axW6ecvkl5/q4mQH9o+FBf7gJ+qoEeGz/e46WaphVkXxRiSZVJCgh6t1QTCnPVLVr8HXhK74uXxuuS2nx1XB5sVTN84j62bB6Oe/F/caxQ2FO6/t1nYnFlhR152RK0pTPnBzu1HAhxubq4VWI=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Jan Beulich
	<jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Topic: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Index: AQHYTzcUggEUWxM2006iot1qnYxlIKzuW0oAgAFU1AA=
Date: Thu, 14 Apr 2022 17:44:24 +0000
Message-ID: <8C511888-6183-421E-A4C7-B271DAF46696@arm.com>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com>
 <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 68fa6a00-1e39-4847-4cf2-08da1e3e77c6
x-ms-traffictypediagnostic:
	DB8PR08MB5514:EE_|AM5EUR03FT037:EE_|HE1PR0802MB2203:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0802MB220386E0945195B3229C2D61FCEF9@HE1PR0802MB2203.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Lwu/L44kd/BB2rXSr73XODpQvn4nFHAy6O46eY+450MTtvXwXEckmgq0FmWAxLZ6PYZL9r8/cy5ON9Uk7Ha/ZM/NHBOQVlbd2g7MyUUGRWsOpX1XRfcRvZVTow62ngq5k6p7tmLP4+BTmCTO7YQ7wZPKilhITbK4jHDLhNnV7uagF6lYl0hkEQFhRwE7aW/Btl5cbtAQv+yFPGIHWywsqEMtS/IG6DUFEjoX4Tn4EbjGBiVA41sPyLwIVqm9jD4nKL4v+4OFYZe7z8qqrGvWW9b3qTYDZMADG7QUDAXpsN683x00WUlmzXibZQ+QS1NE0eWbZalPj6aAzLa4CoKcA5Dz7C78XQiZ0vJQh/6twNG8wQbACeOkGXSU/6H5zDcDV76Vv5AMre/dEgEuHUkFQG31XsU1gavTWs9ftRzu/ExMGGe/PRDXwhlmAy3Pz2+EQzLTu0tieSo6PLzsR+mKZRnb7PnduRXus3B9k7q6SBb2GhAKR0osEHyzmMkOAOYEMf8Wur1Oe6ZCq/Y28sQeueHpMRTdvJB7oT0R73PPbZR4H14G4Sp56hM7E2sZoSOjoA02Xf+OloJ6rSRZoLfUeuEDLtzm9VhoxztwEjKFB3J9yhnk7yi/LxUXATSPQhUE7deUz78CZ4G0ZE+oC/qXlyAB11FD84RjDSgCRnHRK25+DskWKAkn9vwDFMYiJ/0dDNdlwBwW76EjYRP7WXEM4YJNH8za9u+WZxOjlHBj7yWTWa4BEV9kpYHaUNIEmTuN
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(122000001)(38100700002)(99936003)(76116006)(316002)(64756008)(66476007)(66556008)(4326008)(66446008)(8676002)(8936002)(508600001)(86362001)(6486002)(66946007)(45080400002)(71200400001)(6512007)(2906002)(33656002)(6506007)(38070700005)(91956017)(2616005)(186003)(26005)(54906003)(6916009)(83380400001)(5660300002)(53546011)(45980500001);DIR:OUT;SFP:1101;
Content-Type: multipart/mixed;
	boundary="_007_8C5118886183421EA4C7B271DAF46696armcom_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5514
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d92d0ca0-53d9-458d-bbf4-08da1e3e6a39
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZRDk/8tlbDrpeA8RUCAYLbmPMA9pwPB5Lih3oe8IFiPSSu3HGa3BmR2ZF2p1uOcVO2rjQBeDs15wKxV7jRAzHJhbYmmn9BItPeJYijenQElpxm3C4KCroLX+OyslLCR1DzpXRiO95OUnWV6zoYg40uVrhKGXADh38fr1Xxv9DrHL6bo0hNxdcHZf8rsdV7ZkUtyplpLSvtQcTYb2lDXDbE+0Zgn9v8Bn5n2spCDlkOcZFcM1kNYqyAPiaynLW9P/RXSsDfqKG7CY7mWeUhpxjgbdbfqniCii/vpT11j92n2eIIiBNvrwusXFKj2wH5AMgDQnn8u5A/WSqwL/sUKCMPS6pWEzHVUEAX6+4Q9H5nRxiBu3eUSGYByxovHIEPFD+QjovfV4w1SLjoltU1ySM2FdHrYkGYD3UoBl9PPI7yWvIkW/TxLUDqFXuYq9RQjYKDjN/uCyu/MW/Emb8+Fmw5sPd1Wk2B1YY9COXvk6pIy0xMgVAtxznUpBR6tDGLwZBer1nbWkKmQ+YyBPVP+CpM/He64AAVTyWaaQIJmN/JLNAEpZI49hay/layraULlucA/HH6tOeAEGf+y67bCzGevWfNkaQV19T+c7hv0giLjmzbCASaedUr4gEYpHAbvwAytw6791/wd31pSWdygydbvJdGWtri9hQXABobWFyQhPZgAH723QzYI/042v7xty
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(8676002)(508600001)(316002)(235185007)(45080400002)(6862004)(40460700003)(81166007)(4326008)(336012)(36860700001)(33656002)(6512007)(54906003)(5660300002)(53546011)(8936002)(33964004)(6506007)(2616005)(30864003)(82310400005)(70206006)(36756003)(356005)(6486002)(70586007)(107886003)(186003)(2906002)(26005)(99936003)(83380400001)(47076005)(86362001)(21480400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 17:44:47.1855
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 68fa6a00-1e39-4847-4cf2-08da1e3e77c6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2203

--_007_8C5118886183421EA4C7B271DAF46696armcom_
Content-Type: multipart/alternative;
	boundary="_000_8C5118886183421EA4C7B271DAF46696armcom_"

--_000_8C5118886183421EA4C7B271DAF46696armcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

SGkgU3RlZmFubywNCg0KPiBPbiAxMyBBcHIgMjAyMiwgYXQgMTA6MjQgcG0sIFN0ZWZhbm8gU3Rh
YmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+DQo+IE9uIFdlZCwgMTMg
QXByIDIwMjIsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4gSGVsbG8gQWxsLA0KPj4NCj4+IFdlIGFy
ZSB0cnlpbmcgdG8gYm9vdCB0aGUgWGVuIDQuMTUuMSBhbmQgZG9tMCBMaW51eCBLZXJuZWwgKDUu
MTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCBmcm9tIFsxXSApIG9uIEFtcGVyZSBBbHRyYSAvIEFW
QSBEZXZlbG9wZXIgUGxhdGZvcm0NCj4+IFsyXSB3aXRoIEFDUEkuDQo+Pg0KPj4gTlZNZSBzdG9y
YWdlIGlzIGNvbm5lY3RlZCB0byBQQ0llLiBOYXRpdmUgTGludXgga2VybmVsIGJvb3QgZmluZSBh
bmQgYWxzbyBJIGFtIGFibGUgdG8gZGV0ZWN0IGFuZCBhY2Nlc3MgTlZNZSBzdG9yYWdlLg0KPj4g
SG93ZXZlciwgZHVyaW5nIFhFTiBib290IHdoZW4gTlZNRSBkcml2ZXIgaXMgcmVxdWVzdGluZyB0
aGUgRE1BIGJ1ZmZlciB3ZSBhcmUgb2JzZXJ2aW5nIHRoZSBPb3BzIHdpdGggWEVOLg0KPg0KPiBI
aSBSYWh1bCwNCj4NCj4gVGhhbmtzIGZvciB0aGUgYnVnIHJlcG9ydC4gTW9yZSBjb21tZW50cyBi
ZWxvdy4NCj4NCj4NCj4NCj4+IFBsZWFzZSBmaW5kIHRoZSBhdHRhY2hlZCBkZXRhaWwgbG9ncyBm
b3IgWGVuIGFuZCBkb20wIGJvb3RpbmcuDQo+Pg0KPj4gU25pcCBmcm9tIGxvZ3M6DQo+PiAoWEVO
KSBkMHYwOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZm
IHRvIElDQUNUSVZFUjANCj4+IFsgIDAuMDAwMDAwXSBCb290aW5nIExpbnV4IG9uIHBoeXNpY2Fs
IENQVSAweDAwMDAwMDAwMDAgWzB4NDEzZmQwYzFdDQo+PiBbICAwLjAwMDAwMF0gTGludXggdmVy
c2lvbiA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQgKG9lLXVzZXJAb2UtaG9zdCkgKGFhcmNo
NjQtcG9reS1saW51eC1nY2MgKEdDQykgMTEuMi4wLCBHTlUgbGQgKEdOVSBCaW51dGlscykNCj4+
IDIuMzcuMjAyMTA3MjEpICMxIFNNUCBQUkVFTVBUIFNhdCBTZXAgMTggMDY6MDE6NTkgVVRDIDIw
MjENCj4+IFsgIDAuMDAwMDAwXSBYZW4gWEVOX1ZFUlNJT04uWEVOX1NVQlZFUlNJT04gc3VwcG9y
dCBmb3VuZA0KPj4gWyAgMC4wMDAwMDBdIGVmaTogRUZJIHYyLjUwIGJ5IFhlbg0KPj4gWyAgMC4w
MDAwMDBdIGVmaTogQUNQSSAyLjA9MHg4MDdmNjZjZWNlOA0KPj4gWyAgMC4wMDAwMDBdIEFDUEk6
IEVhcmx5IHRhYmxlIGNoZWNrc3VtIHZlcmlmaWNhdGlvbiBkaXNhYmxlZA0KPj4gWyAgMC4wMDAw
MDBdIEFDUEk6IFJTRFAgMHgwMDAwMDgwN0Y2NkNFQ0U4IDAwMDAyNCAodjAyIEFtcGVyZSkNCj4+
IFsgIDAuMDAwMDAwXSBBQ1BJOiBYU0RUIDB4MDAwMDA4MDdGNjZDRUMzOCAwMDAwQUMgKHYwMSBB
bXBlcmUgQWx0cmEgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQo+PiBbICAwLjAwMDAwMF0gQUNQ
STogRkFDUCAweDAwMDAwODA3RjY2Q0UwMDAgMDAwMTE0ICh2MDYgQW1wZXJlIEFsdHJhICAwMDAw
MDAwMiBBTVAuIDAxMDAwMDEzKQ0KPj4gWyAgMC4wMDAwMDBdIEFDUEk6IERTRFQgMHgwMDAwMDgw
N0Y4REIwMDE4IDAyQzE5RSAodjAyIEFtcGVyZSBKYWRlICAwMDAwMDAwMSBJTlRMIDIwMjAxMjE3
KQ0KPj4gWyAgMC4wMDAwMDBdIEFDUEk6IEJFUlQgMHgwMDAwMDgwN0ZBMERGRjk4IDAwMDAzMCAo
djAxIEFtcGVyZSBBbHRyYSAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNCj4+IFsgIDAuMDAwMDAw
XSBBQ1BJOiBEQkcyIDB4MDAwMDA4MDdGQTBERkE5OCAwMDAwNUMgKHYwMCBBbXBlcmUgQWx0cmEg
IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQo+PiBbICAwLjAwMDAwMF0gQUNQSTogR1REVCAweDAw
MDAwODA3RkEwREU5OTggMDAwMTEwICh2MDMgQW1wZXJlIEFsdHJhICAwMDAwMDAwMiBBTVAuIDAx
MDAwMDEzKQ0KPj4gWyAgMC4wMDAwMDBdIEFDUEk6IFNQQ1IgMHgwMDAwMDgwN0ZBMERGRTE4IDAw
MDA1MCAodjAyIEFtcGVyZSBBbHRyYSAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNCj4+IFsgIDAu
MDAwMDAwXSBBQ1BJOiBFSU5KIDB4MDAwMDA4MDdGQTBERjU5OCAwMDAxNTAgKHYwMSBBbXBlcmUg
QWx0cmEgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQo+PiBbICAwLjAwMDAwMF0gQUNQSTogSEVT
VCAweDAwMDAwODA3RkEwREVCMTggMDAwMUY0ICh2MDEgQW1wZXJlIEFsdHJhICAwMDAwMDAwMSBJ
TlRMIDIwMjAxMjE3KQ0KPj4gWyAgMC4wMDAwMDBdIEFDUEk6IFNTRFQgMHgwMDAwMDgwN0ZBMERG
QTE4IDAwMDAyRCAodjAyIEFtcGVyZSBBbHRyYSAgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNykNCj4+
IFsgIDAuMDAwMDAwXSBBQ1BJOiBUUE0yIDB4MDAwMDA4MDdGQTBERkQxOCAwMDAwNEMgKHYwNCBB
bXBlcmUgQWx0cmEgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQo+PiBbICAwLjAwMDAwMF0gQUNQ
STogTUNGRyAweDAwMDAwODA3RkEwREY3MTggMDAwMDdDICh2MDEgQW1wZXJlIEFsdHJhICAwMDAw
MDAwMSBBTVAuIDAxMDAwMDEzKQ0KPj4gWyAgMC4wMDAwMDBdIEFDUEk6IElPUlQgMHgwMDAwMDgw
N0ZBMERFRjE4IDAwMDNEQyAodjAwIEFtcGVyZSBBbHRyYSAgMDAwMDAwMDIgQU1QLiAwMTAwMDAx
MykNCj4+IFsgIDAuMDAwMDAwXSBBQ1BJOiBBUElDIDB4MDAwMDA4MDdGNjZDRTExOCAwMDBBRjQg
KHYwNSBBbXBlcmUgQWx0cmEgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQo+PiBbICAwLjAwMDAw
MF0gQUNQSTogUFBUVCAweDAwMDAwODA3RkEwRDg2MTggMDA0NTIwICh2MDIgQW1wZXJlIEFsdHJh
ICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KPj4gWyAgMC4wMDAwMDBdIEFDUEk6IFNMSVQgMHgw
MDAwMDgwN0ZBMERGRDk4IDAwMDAyRCAodjAxIEFtcGVyZSBBbHRyYSAgMDAwMDAwMDIgQU1QLiAw
MTAwMDAxMykNCj4+IFsgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUIDB4MDAwMDA4MDdGQTBEQ0UxOCAw
MDAzNzAgKHYwMyBBbXBlcmUgQWx0cmEgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQo+PiBbICAw
LjAwMDAwMF0gQUNQSTogUENDVCAweDAwMDAwODA3RkEwREUzMTggMDAwNTc2ICh2MDIgQW1wZXJl
IEFsdHJhICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KPj4gWyAgMC4wMDAwMDBdIEFDUEk6IFNU
QU8gMHgwMDAwMDgwN0Y2NkNFQzEwIDAwMDAyNSAodjAxIEFtcGVyZSBBbHRyYSAgMDAwMDAwMDIg
QU1QLiAwMTAwMDAxMykNCj4+IFsgIDAuMDAwMDAwXSBBQ1BJOiBTUENSOiBjb25zb2xlOiBwbDAx
MSxtbWlvMzIsMHgxMDAwMDI2MDAwMDAsMTE1MjAwDQo+PiBbICAwLjAwMDAwMF0gQUNQSTogU1JB
VDogTm9kZSAwIFBYTSAwIFttZW0gMHg4ODMwMDAwMC0weDg4M2ZmZmZmXQ0KPj4gWyAgMC4wMDAw
MDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4OTAwMDAwMDAtMHhmZmZmZmZmZl0N
Cj4+IFsgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDgwMDAwMDAw
MDAwLTB4ODAwN2ZmZmZmZmZdDQo+PiBbICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBY
TSAwIFttZW0gMHg4MDEwMDAwMDAwMC0weDgwN2ZmZmZmZmZmXQ0KPj4gWyAgMC4wMDAwMDBdIE5V
TUE6IE5PREVfREFUQSBbbWVtIDB4ODA3OWZiZjVlMDAtMHg4MDc5ZmJmN2ZmZl0NCj4+IFsgIDAu
MDAwMDAwXSBab25lIHJhbmdlczoNCj4+IFsgIDAuMDAwMDAwXSAgRE1BICBbbWVtIDB4MDAwMDAw
MDA5ODAwMDAwMC0weDAwMDAwMDAwZmZmZmZmZmZdDQo+PiBbICAwLjAwMDAwMF0gIERNQTMyICBl
bXB0eQ0KPj4gWyAgMC4wMDAwMDBdICBOb3JtYWwgIFttZW0gMHgwMDAwMDAwMTAwMDAwMDAwLTB4
MDAwMDA4MDdmYTBkZmZmZl0NCj4+IFsgIDAuMDAwMDAwXSBNb3ZhYmxlIHpvbmUgc3RhcnQgZm9y
IGVhY2ggbm9kZQ0KPj4gWyAgMC4wMDAwMDBdIEVhcmx5IG1lbW9yeSBub2RlIHJhbmdlcw0KPj4g
4oCmLg0KPj4NCj4+IFsgIDAuMDAwMDAwXSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVz
OiAyNjIxNDQgKG9yZGVyOiA5LCAyMDk3MTUyIGJ5dGVzLCBsaW5lYXIpDQo+PiBbICAwLjAwMDAw
MF0gSW5vZGUtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAxMzEwNzIgKG9yZGVyOiA4LCAxMDQ4
NTc2IGJ5dGVzLCBsaW5lYXIpDQo+PiBbICAwLjAwMDAwMF0gbWVtIGF1dG8taW5pdDogc3RhY2s6
b2ZmLCBoZWFwIGFsbG9jOm9mZiwgaGVhcCBmcmVlOm9mZg0KPj4gWyAgMC4wMDAwMDBdIHNvZnR3
YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgwMDAwMDAwMGY0MDAwMDAwLTB4MDAwMDAwMDBmODAw
MDAwMF0gKDY0TUIpDQo+PiBbICAwLjAwMDAwMF0gTWVtb3J5OiAxOTI5MTUySy8yMDk3NDEySyBh
dmFpbGFibGUgKDEzNTY4SyBrZXJuZWwgY29kZSwgMTk5NksgcndkYXRhLCAzNDc2SyByb2RhdGEs
IDQxNjBLIGluaXQsIDgyMksgYnNzLCAxNjgyNjBLIHJlc2VydmVkLA0KPj4gMEsgY21hLXJlc2Vy
dmVkKQ0KPj4gWyAgMC4wMDAwMDBdIFNMVUI6IEhXYWxpZ249NjQsIE9yZGVyPTAtMywgTWluT2Jq
ZWN0cz0wLCBDUFVzPTMyLCBOb2Rlcz0xDQo+PiBbICAwLjAwMDAwMF0gZnRyYWNlOiBhbGxvY2F0
aW5nIDQxMzA2IGVudHJpZXMgaW4gMTYyIHBhZ2VzDQo+PiDigKYuDQo+Pg0KPj4g4oCmLg0KPj4g
WyAgMTIuNTk5NDg0XSBsb29wOiBtb2R1bGUgbG9hZGVkDQo+PiBbICAxMi42MDMxNjBdIG52bWUg
bnZtZTA6IHBjaSBmdW5jdGlvbiAwMDA1OjA0OjAwLjANCj4+IFsgIDEyLjYwODEyOV0gaWdiOiBJ
bnRlbChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgRHJpdmVyDQo+PiBbICAxMi42MTM0OTVd
IGlnYjogQ29weXJpZ2h0IChjKSAyMDA3LTIwMTQgSW50ZWwgQ29ycG9yYXRpb24uDQo+PiBbICAx
Mi42MTM2MzZdIG52bWUgbnZtZTA6IG1pc3Npbmcgb3IgaW52YWxpZCBTVUJOUU4gZmllbGQuDQo+
PiBbICAxMi42MjU5NDFdIFVuYWJsZSB0byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJl
ZmVyZW5jZSBhdCB2aXJ0dWFsIGFkZHJlc3MgMDAwMDAwMDAwMDAwMDAwOA0KPj4gWyAgMTIuNjM0
NzI2XSBNZW0gYWJvcnQgaW5mbzoNCj4+IFsgIDEyLjYzNzUyMF0gIEVTUiA9IDB4OTYwMDAwNDQN
Cj4+IFsgIDEyLjY0MDY0Nl0gIEVDID0gMHgyNTogREFCVCAoY3VycmVudCBFTCksIElMID0gMzIg
Yml0cw0KPj4gWyAgMTIuNjQ2MDU1XSAgU0VUID0gMCwgRm5WID0gMA0KPj4gWyAgMTIuNjQ5MTUz
XSAgRUEgPSAwLCBTMVBUVyA9IDANCj4+IFsgIDEyLjY1MjM2NV0gRGF0YSBhYm9ydCBpbmZvOg0K
Pj4gWyAgMTIuNjU1MzE0XSAgSVNWID0gMCwgSVNTID0gMHgwMDAwMDA0NA0KPj4gWyAgMTIuNjU5
MjMxXSAgQ00gPSAwLCBXblIgPSAxDQo+PiBbICAxMi42NjIyNjBdIFswMDAwMDAwMDAwMDAwMDA4
XSB1c2VyIGFkZHJlc3MgYnV0IGFjdGl2ZV9tbSBpcyBzd2FwcGVyDQo+PiBbICAxMi42Njg3MjRd
IEludGVybmFsIGVycm9yOiBPb3BzOiA5NjAwMDA0NCBbIzFdIFBSRUVNUFQgU01QDQo+PiBbICAx
Mi42NzQzNThdIE1vZHVsZXMgbGlua2VkIGluOg0KPj4gWyAgMTIuNjc3NDU1XSBDUFU6IDAgUElE
OiA3IENvbW06IGt3b3JrZXIvdTY0OjAgVGFpbnRlZDogRyAgVyAgNS4xMC4yNy1hbXBlcmUtbHRz
LXN0YW5kYXJkICMxDQo+PiBbICAxMi42ODcwODNdIFdvcmtxdWV1ZTogbnZtZS1yZXNldC13cSBu
dm1lX3Jlc2V0X3dvcmsNCj4+IFsgIDEyLjY5MjA1OV0gcHN0YXRlOiA2MGMwMDA4NSAoblpDdiBk
YUlmICtQQU4gK1VBTyAtVENPIEJUWVBFPS0tKQ0KPj4gWyAgMTIuNjk4MTQ5XSBwYyA6IHN0ZWFs
X3N1aXRhYmxlX2ZhbGxiYWNrKzB4MTM4LzB4MmYwDQo+PiBbICAxMi43MDMxNzBdIGxyIDogc3Rl
YWxfc3VpdGFibGVfZmFsbGJhY2srMHgxYmMvMHgyZjANCj4+IFsgIDEyLjcwODIwM10gc3AgOiBm
ZmZmODAwMDExOTZiODIwDQo+PiBbICAxMi43MTE1NjldIHgyOTogZmZmZjgwMDAxMTk2YjgyMCB4
Mjg6IDAwMDAwMDAwMDAwMDAwMDANCj4+IFsgIDEyLjcxNjk3NV0geDI3OiAwMDAwMDAwMDAwMDAw
MDAwIHgyNjogZmZmZjgwMDAxMTRkYmNiMA0KPj4gWyAgMTIuNzIyMzU3XSB4MjU6IGZmZmZmZGZm
ZmZlMDAwMDAgeDI0OiAwMDAwMDAwMDAwMDAwMDAxDQo+PiBbICAxMi43Mjc3NDBdIHgyMzogMDAw
MDAwMDAwMDAwMDAwMCB4MjI6IGZmZmZmZTIwMWJmNjAwMDANCj4+IFsgIDEyLjczMzEyMF0geDIx
OiBmZmZmMDgwNzFmYmY2OTgwIHgyMDogMDAwMDAwMDAwMDAwMDkwMQ0KPj4gWyAgMTIuNzM4NTAy
XSB4MTk6IDAwMDAwMDAwMDAwODAwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmDQo+PiBbICAxMi43
NDM4ODRdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMTINCj4+IFsg
IDEyLjc0OTI2Nl0geDE1OiBmZmZmMDgwNzA1MDhjNjgzIHgxNDogMDAwMDAwMDAwMDAwMDA1OA0K
Pj4gWyAgMTIuNzU0NjQ4XSB4MTM6IDAwMDAwMDAwMDAwMDAwYzAgeDEyOiAwMDAwMDAwMDAwMDAw
MDAwDQo+PiBbICAxMi43NjAwMzBdIHgxMTogMDAwMDAwMDAwMDAwMDQwMCB4MTA6IDAwMDAwMDAw
MDAwMDAwMGMNCj4+IFsgIDEyLjc2NTQxMl0geDkgOiBmZmZmODAwMDEwMDM5ZDU4IHg4IDogMDAw
MDAwMDAyMDAwMDAwMA0KPj4gWyAgMTIuNzcwNzk0XSB4NyA6IDAwMDAwMDAwMDAwMDAwMTggeDYg
OiBmZmZmODAwMDExNzUwODkwDQo+PiBbICAxMi43NzYxNzZdIHg1IDogZmZmZjgwMDAxMTc1MDg3
OCB4NCA6IDAwMDAwMDAwMDAwMDAwMDANCj4+IFsgIDEyLjc4MTU1OF0geDMgOiAwMDAwMDAwMDAw
MDAwMDAwIHgyIDogMDAwMDAwMDAwMDAwMDAwMA0KPj4gWyAgMTIuNzg2OTQwXSB4MSA6IDAwMDAw
MDAwMDAwMDAyMDAgeDAgOiAwMDAwMDAwMDAwMDAwMDAwDQo+PiBbICAxMi43OTIzMjJdIENhbGwg
dHJhY2U6DQo+PiBbICAxMi43OTQ4MDZdICBzdGVhbF9zdWl0YWJsZV9mYWxsYmFjaysweDEzOC8w
eDJmMA0KPj4gWyAgMTIuNzk5NTIwXSAgZ2V0X3BhZ2VfZnJvbV9mcmVlbGlzdCsweGUzMC8weDEy
YTANCj4+IFsgIDEyLjgwNDIwN10gIF9fYWxsb2NfcGFnZXNfbm9kZW1hc2srMHgxNDgvMHhlMDAN
Cj4+IFsgIDEyLjgwODgwOV0gIF9fZG1hX2RpcmVjdF9hbGxvY19wYWdlcysweGE0LzB4MWQwDQo+
PiBbICAxMi44MTM0OTZdICBkbWFfZGlyZWN0X2FsbG9jKzB4MWQ4LzB4MzQwDQo+PiBbICAxMi44
MTc1NzFdICB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCsweDY4LzB4MzcwDQo+PiBbICAxMi44
MjI0MzldICBkbWFfYWxsb2NfYXR0cnMrMHhlOC8weGYwDQo+PiBbICAxMi44MjYyNDZdICBudm1l
X3Jlc2V0X3dvcmsrMHgxMDMwLzB4MTUyMA0KPj4gWyAgMTIuODMwNDE3XSAgcHJvY2Vzc19vbmVf
d29yaysweDFkYy8weDRiYw0KPj4gWyAgMTIuODM0NDk1XSAgd29ya2VyX3RocmVhZCsweDE0NC8w
eDQ3MA0KPj4gWyAgMTIuODM4MzEzXSAga3RocmVhZCsweDE0Yy8weDE2MA0KPj4gWyAgMTIuODQx
NjA0XSAgcmV0X2Zyb21fZm9yaysweDEwLzB4MzgNCj4+IFsgIDEyLjg0NTI1NV0gQ29kZTogYTk0
MDgyYzQgZDM3ZWY0NjMgY2IzYzQwNjMgOGIzYzQwNDIgKGY5MDAwNDgwKQ0KPj4gWyAgMTIuODUx
NDQ3XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjcyIF0tLS0NCj4+IFsgIDEyLjg1NjEx
N10gbm90ZToga3dvcmtlci91NjQ6MFs3XSBleGl0ZWQgd2l0aCBwcmVlbXB0X2NvdW50DQo+DQo+
IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IGNhbGxzIGRtYV9kaXJlY3RfYWxsb2Mgd2hpY2gg
ZmFpbHMgZm9yIHRoZQ0KPiBkZXZpY2UuDQo+DQo+IFdpdGhvdXQgc3dpb3RsYl94ZW4sIGRtYV9h
bGxvY19hdHRycyB3b3VsZCBkbzoNCj4NCj4gICAgICAgIGlmIChkbWFfYWxsb2NfZGlyZWN0KGRl
diwgb3BzKSkNCj4gICAgICAgICAgICAgICAgY3B1X2FkZHIgPSBkbWFfZGlyZWN0X2FsbG9jKGRl
diwgc2l6ZSwgZG1hX2hhbmRsZSwgZmxhZywgYXR0cnMpOw0KPiAgICAgICAgZWxzZSBpZiAob3Bz
LT5hbGxvYykNCj4gICAgICAgICAgICAgICAgY3B1X2FkZHIgPSBvcHMtPmFsbG9jKGRldiwgc2l6
ZSwgZG1hX2hhbmRsZSwgZmxhZywgYXR0cnMpOw0KPg0KPiBkbWFfYWxsb2NfZGlyZWN0IGlzIHRo
ZSB2ZXJ5IHNhbWUgY2FsbCB0aGF0IGZhaWxzIHdoZW4gY2FsbGVkIGZyb20NCj4geGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQuIFNvIGl0IG11c3QgYmUgdGhhdCB0aGUgcGF0aCBtZWFudCB0byBi
ZQ0KPiB0YWtlbiBpcyBvcHMtPmFsbG9jIGluc3RlYWQuDQo+DQo+IG9wcy0+YWxsb2MgaXMgdGhl
IGRtYV9vcHMgZnVuY3Rpb24gdG8gYWxsb2NhdGUgYSBjb2hlcmVudCBidWZmZXIuDQo+IFdoZW4g
c3dpb3RsYi14ZW4gaXMgZW5hYmxlZCwgaXQgcG9pbnRzIHRvIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50Lg0KPiBPZnRlbiBkbWFfb3BzIGlzIE5VTEwgd2hlbiBYZW4gaXMgZGlzYWJsZWQuDQo+
DQo+IEkgdGhpbmsgdGhlIG1vc3QgbGlrZWx5IGV4cGxhbmF0aW9uIGlzIHRoYXQgdGhlIG52bWUg
ZGV2aWNlIHJlcXVpcmUgYQ0KPiBzcGVjaWZpYyBkbWFfb3BzLiBXaGVuIHN3aW90bGIteGVuIGlz
IGVuYWJsZWQsIGl0IGdldHMgb3ZlcndyaXR0ZW4gYnkNCj4gYXJjaC9hcm02NC9tbS9kbWEtbWFw
cGluZy5jOmFyY2hfc2V0dXBfZG1hX29wcy4NCj4NCj4gQ2FuIHlvdSBkb3VibGUtY2hlY2sgdGhp
cyB0aGVvcnkgYnkgYWRkaW5nIGEgZmV3IHByaW50a3MgaW4NCj4gYXJjaC9hcm02NC9tbS9kbWEt
bWFwcGluZy5jOmFyY2hfc2V0dXBfZG1hX29wcywgdG8gY2hlY2sgdGhlIGRtYV9vcHMNCj4gdXNl
ZCB3aGVuICFDT05GSUdfWEVOLCBhbmQgYWxzbyBpbiBrZXJuZWwvZG1hL21hcHBpbmcuYzpkbWFf
YWxsb2NfYXR0cnMNCj4gdG8gY2hlY2sgdGhlIGNvZGUgcGF0aCB0YWtlbiB3aGVuICFDT05GSUdf
WEVOPw0KDQpJIGNoZWNrZWQgdGhlIGNvZGUgcGF0aCB3aGVuICFDT05GSURfWEVOIGFuZCBTTU1V
IGlzIG5vdCBlbmFibGVkIGluIGxpbnV4LCBjb2RlIHBhdGggaXM6DQogICAgICAgIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKQ0KYW5kIHRoZXJlIGlzIG5vIGlzc3VlIGlu
IGJvb3RpbmcgYW5kIGFsbG9jYXRpbmcgYSBjb2hlcmVudCBidWZmZXIuDQoNCldoZW4gIUNPTkZJ
R19YRU4gYW5kIFNNTVUgaXMgZW5hYmxlZCBjb2RlIHBhdGggaXM6DQogICAgICAgIGRtYV9hbGxv
Y19hdHRycygpLT4gb3BzLT5hbGxvYyAtPiBpb21tdV9kbWFfYWxsb2MoKQ0KYW5kIHRoZXJlIGlz
IG5vIGlzc3VlIGluIGJvb3RpbmcgYW5kIGFsbG9jYXRpbmcgYSBjb2hlcmVudCBidWZmZXIgaW4g
dGhpcyBjYXNlIGFsc28uDQoNCldoZW4gWGVuIGlzIGVuYWJsZWQgY29kZSBwYXRoIGlzOg0KICAg
ICAgICBkbWFfYWxsb2NfYXR0cnMoKS0+IG9wcy0+YWxsb2MoKSAtPiB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCgpIC0+IGRtYV9hbGxvY19kaXJlY3QoKQ0KaW4gdGhpcyBjYXNlIGFsbG9jYXRp
bmcgdGhlIGNvaGVyZW50IGJ1ZmZlciBmYWlsZWQuDQoNCk9ubHkgZGlmZmVyZW5jZSBJIHNlZSBp
cyB0aGUgc2l6ZSBhcmd1bWVudCBmb3IgZG1hX2FsbG9jX2RpcmVjdCgpIGluIFhlbiBjYXNlIGJ1
dCBJIGRvbuKAmXQgdGhpbmsNCnRoYXQgaXMgY2F1c2luZyB0aGUgaXNzdWUgdGhlcmUgaXMgc29t
ZXRoaW5nIGVsc2UgY2F1c2luZyB0aGUgaXNzdWUgbWF5YmUgZnJvbQ0Kd2hlcmUgdGhlIGNvaGVy
ZW50IG1lbW9yeSBpcyBhbGxvY2F0ZWQuDQoNCiAgICAgICAgLyogQ29udmVydCB0aGUgc2l6ZSB0
byBhY3R1YWxseSBhbGxvY2F0ZWQuICovDQogICAgICAgIHNpemUgPSAxVUwgPDwgKG9yZGVyICsg
WEVOX1BBR0VfU0hJRlQpOw0KDQoNClBsZWFzZSBmaW5kIHRoZSBhdHRhY2hlZCBkZXRhaWxlZCBs
b2dzIGZvciBlYWNoIGNhc2UuDQoNCg0KDQoNClJlZ2FyZHMsDQpSYWh1bA0K

--_000_8C5118886183421EA4C7B271DAF46696armcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <6F4E4BCE9F888A4A84E17ECD8BA947D3@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i
Qm9keUZyYWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQ7
Ij4NCjxkaXYgY2xhc3M9IlBsYWluVGV4dCI+SGkgU3RlZmFubyw8YnI+DQo8YnI+DQomZ3Q7IE9u
IDEzIEFwciAyMDIyLCBhdCAxMDoyNCBwbSwgU3RlZmFubyBTdGFiZWxsaW5pICZsdDtzc3RhYmVs
bGluaUBrZXJuZWwub3JnJmd0OyB3cm90ZTo8YnI+DQomZ3Q7IDxicj4NCiZndDsgT24gV2VkLCAx
MyBBcHIgMjAyMiwgUmFodWwgU2luZ2ggd3JvdGU6PGJyPg0KJmd0OyZndDsgSGVsbG8gQWxsLDxi
cj4NCiZndDsmZ3Q7IDxicj4NCiZndDsmZ3Q7IFdlIGFyZSB0cnlpbmcgdG8gYm9vdCB0aGUgWGVu
IDQuMTUuMSBhbmQgZG9tMCBMaW51eCBLZXJuZWwgKDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFy
ZCBmcm9tIFsxXSApIG9uIEFtcGVyZSBBbHRyYSAvIEFWQSBEZXZlbG9wZXIgUGxhdGZvcm08YnI+
DQomZ3Q7Jmd0OyBbMl0gd2l0aCBBQ1BJLjxicj4NCiZndDsmZ3Q7IDxicj4NCiZndDsmZ3Q7IE5W
TWUgc3RvcmFnZSBpcyBjb25uZWN0ZWQgdG8gUENJZS4gTmF0aXZlIExpbnV4IGtlcm5lbCBib290
IGZpbmUgYW5kIGFsc28gSSBhbSBhYmxlIHRvIGRldGVjdCBhbmQgYWNjZXNzIE5WTWUgc3RvcmFn
ZS48YnI+DQomZ3Q7Jmd0OyBIb3dldmVyLCBkdXJpbmcgWEVOIGJvb3Qgd2hlbiBOVk1FIGRyaXZl
ciBpcyByZXF1ZXN0aW5nIHRoZSBETUEgYnVmZmVyIHdlIGFyZSBvYnNlcnZpbmcgdGhlIE9vcHMg
d2l0aCBYRU4uPGJyPg0KJmd0OyA8YnI+DQomZ3Q7IEhpIFJhaHVsLDxicj4NCiZndDsgPGJyPg0K
Jmd0OyBUaGFua3MgZm9yIHRoZSBidWcgcmVwb3J0LiBNb3JlIGNvbW1lbnRzIGJlbG93Ljxicj4N
CiZndDsgPGJyPg0KJmd0OyA8YnI+DQomZ3Q7IDxicj4NCiZndDsmZ3Q7IFBsZWFzZSBmaW5kIHRo
ZSBhdHRhY2hlZCBkZXRhaWwgbG9ncyBmb3IgWGVuIGFuZCBkb20wIGJvb3RpbmcuPGJyPg0KJmd0
OyZndDsgPGJyPg0KJmd0OyZndDsgU25pcCBmcm9tIGxvZ3M6PGJyPg0KJmd0OyZndDsgKFhFTikg
ZDB2MDogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0
byBJQ0FDVElWRVIwPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQm9vdGluZyBMaW51
eCBvbiBwaHlzaWNhbCBDUFUgMHgwMDAwMDAwMDAwIFsweDQxM2ZkMGMxXTxicj4NCiZndDsmZ3Q7
IFsmbmJzcDsgMC4wMDAwMDBdIExpbnV4IHZlcnNpb24gNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5k
YXJkIChvZS11c2VyQG9lLWhvc3QpIChhYXJjaDY0LXBva3ktbGludXgtZ2NjIChHQ0MpIDExLjIu
MCwgR05VIGxkIChHTlUgQmludXRpbHMpPGJyPg0KJmd0OyZndDsgMi4zNy4yMDIxMDcyMSkgIzEg
U01QIFBSRUVNUFQgU2F0IFNlcCAxOCAwNjowMTo1OSBVVEMgMjAyMTxicj4NCiZndDsmZ3Q7IFsm
bmJzcDsgMC4wMDAwMDBdIFhlbiBYRU5fVkVSU0lPTi5YRU5fU1VCVkVSU0lPTiBzdXBwb3J0IGZv
dW5kPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gZWZpOiBFRkkgdjIuNTAgYnkgWGVu
PGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gZWZpOiBBQ1BJIDIuMD0weDgwN2Y2NmNl
Y2U4PGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogRWFybHkgdGFibGUgY2hl
Y2tzdW0gdmVyaWZpY2F0aW9uIGRpc2FibGVkPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAw
MF0gQUNQSTogUlNEUCAweDAwMDAwODA3RjY2Q0VDRTggMDAwMDI0ICh2MDIgQW1wZXJlKTxicj4N
CiZndDsmZ3Q7IFsmbmJzcDsgMC4wMDAwMDBdIEFDUEk6IFhTRFQgMHgwMDAwMDgwN0Y2NkNFQzM4
IDAwMDBBQyAodjAxIEFtcGVyZSBBbHRyYSZuYnNwOyAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKTxi
cj4NCiZndDsmZ3Q7IFsmbmJzcDsgMC4wMDAwMDBdIEFDUEk6IEZBQ1AgMHgwMDAwMDgwN0Y2NkNF
MDAwIDAwMDExNCAodjA2IEFtcGVyZSBBbHRyYSZuYnNwOyAwMDAwMDAwMiBBTVAuIDAxMDAwMDEz
KTxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMC4wMDAwMDBdIEFDUEk6IERTRFQgMHgwMDAwMDgwN0Y4
REIwMDE4IDAyQzE5RSAodjAyIEFtcGVyZSBKYWRlJm5ic3A7IDAwMDAwMDAxIElOVEwgMjAyMDEy
MTcpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogQkVSVCAweDAwMDAwODA3
RkEwREZGOTggMDAwMDMwICh2MDEgQW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4gMDEw
MDAwMTMpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogREJHMiAweDAwMDAw
ODA3RkEwREZBOTggMDAwMDVDICh2MDAgQW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4g
MDEwMDAwMTMpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogR1REVCAweDAw
MDAwODA3RkEwREU5OTggMDAwMTEwICh2MDMgQW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFN
UC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogU1BDUiAw
eDAwMDAwODA3RkEwREZFMTggMDAwMDUwICh2MDIgQW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAy
IEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogRUlO
SiAweDAwMDAwODA3RkEwREY1OTggMDAwMTUwICh2MDEgQW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAw
MDAxIElOVEwgMjAyMDEyMTcpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTog
SEVTVCAweDAwMDAwODA3RkEwREVCMTggMDAwMUY0ICh2MDEgQW1wZXJlIEFsdHJhJm5ic3A7IDAw
MDAwMDAxIElOVEwgMjAyMDEyMTcpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQ
STogU1NEVCAweDAwMDAwODA3RkEwREZBMTggMDAwMDJEICh2MDIgQW1wZXJlIEFsdHJhJm5ic3A7
IDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0g
QUNQSTogVFBNMiAweDAwMDAwODA3RkEwREZEMTggMDAwMDRDICh2MDQgQW1wZXJlIEFsdHJhJm5i
c3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAw
MF0gQUNQSTogTUNGRyAweDAwMDAwODA3RkEwREY3MTggMDAwMDdDICh2MDEgQW1wZXJlIEFsdHJh
Jm5ic3A7IDAwMDAwMDAxIEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAw
MDAwMF0gQUNQSTogSU9SVCAweDAwMDAwODA3RkEwREVGMTggMDAwM0RDICh2MDAgQW1wZXJlIEFs
dHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAw
LjAwMDAwMF0gQUNQSTogQVBJQyAweDAwMDAwODA3RjY2Q0UxMTggMDAwQUY0ICh2MDUgQW1wZXJl
IEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZndDsgWyZuYnNw
OyAwLjAwMDAwMF0gQUNQSTogUFBUVCAweDAwMDAwODA3RkEwRDg2MTggMDA0NTIwICh2MDIgQW1w
ZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZndDsgWyZu
YnNwOyAwLjAwMDAwMF0gQUNQSTogU0xJVCAweDAwMDAwODA3RkEwREZEOTggMDAwMDJEICh2MDEg
QW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZndDsg
WyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogU1JBVCAweDAwMDAwODA3RkEwRENFMTggMDAwMzcwICh2
MDMgQW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0OyZn
dDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogUENDVCAweDAwMDAwODA3RkEwREUzMTggMDAwNTc2
ICh2MDIgQW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0KJmd0
OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogU1RBTyAweDAwMDAwODA3RjY2Q0VDMTAgMDAw
MDI1ICh2MDEgQW1wZXJlIEFsdHJhJm5ic3A7IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpPGJyPg0K
Jmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gQUNQSTogU1BDUjogY29uc29sZTogcGwwMTEsbW1p
bzMyLDB4MTAwMDAyNjAwMDAwLDExNTIwMDxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMC4wMDAwMDBd
IEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODgzMDAwMDAtMHg4ODNmZmZmZl08YnI+
DQomZ3Q7Jmd0OyBbJm5ic3A7IDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21l
bSAweDkwMDAwMDAwLTB4ZmZmZmZmZmZdPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0g
QUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4MDAwMDAwMDAwMC0weDgwMDdmZmZmZmZm
XTxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0g
MCBbbWVtIDB4ODAxMDAwMDAwMDAtMHg4MDdmZmZmZmZmZl08YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7
IDAuMDAwMDAwXSBOVU1BOiBOT0RFX0RBVEEgW21lbSAweDgwNzlmYmY1ZTAwLTB4ODA3OWZiZjdm
ZmZdPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gWm9uZSByYW5nZXM6PGJyPg0KJmd0
OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0mbmJzcDsgRE1BJm5ic3A7IFttZW0gMHgwMDAwMDAwMDk4
MDAwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl08YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDAuMDAwMDAw
XSZuYnNwOyBETUEzMiZuYnNwOyBlbXB0eTxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMC4wMDAwMDBd
Jm5ic3A7IE5vcm1hbCZuYnNwOyBbbWVtIDB4MDAwMDAwMDEwMDAwMDAwMC0weDAwMDAwODA3ZmEw
ZGZmZmZdPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gTW92YWJsZSB6b25lIHN0YXJ0
IGZvciBlYWNoIG5vZGU8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDAuMDAwMDAwXSBFYXJseSBtZW1v
cnkgbm9kZSByYW5nZXM8YnI+DQomZ3Q7Jmd0OyDigKYuPGJyPg0KJmd0OyZndDsgPGJyPg0KJmd0
OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gRGVudHJ5IGNhY2hlIGhhc2ggdGFibGUgZW50cmllczog
MjYyMTQ0IChvcmRlcjogOSwgMjA5NzE1MiBieXRlcywgbGluZWFyKTxicj4NCiZndDsmZ3Q7IFsm
bmJzcDsgMC4wMDAwMDBdIElub2RlLWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMTMxMDcyIChv
cmRlcjogOCwgMTA0ODU3NiBieXRlcywgbGluZWFyKTxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMC4w
MDAwMDBdIG1lbSBhdXRvLWluaXQ6IHN0YWNrOm9mZiwgaGVhcCBhbGxvYzpvZmYsIGhlYXAgZnJl
ZTpvZmY8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDAuMDAwMDAwXSBzb2Z0d2FyZSBJTyBUTEI6IG1h
cHBlZCBbbWVtIDB4MDAwMDAwMDBmNDAwMDAwMC0weDAwMDAwMDAwZjgwMDAwMDBdICg2NE1CKTxi
cj4NCiZndDsmZ3Q7IFsmbmJzcDsgMC4wMDAwMDBdIE1lbW9yeTogMTkyOTE1MksvMjA5NzQxMksg
YXZhaWxhYmxlICgxMzU2OEsga2VybmVsIGNvZGUsIDE5OTZLIHJ3ZGF0YSwgMzQ3Nksgcm9kYXRh
LCA0MTYwSyBpbml0LCA4MjJLIGJzcywgMTY4MjYwSyByZXNlcnZlZCw8YnI+DQomZ3Q7Jmd0OyAw
SyBjbWEtcmVzZXJ2ZWQpPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAwLjAwMDAwMF0gU0xVQjogSFdh
bGlnbj02NCwgT3JkZXI9MC0zLCBNaW5PYmplY3RzPTAsIENQVXM9MzIsIE5vZGVzPTE8YnI+DQom
Z3Q7Jmd0OyBbJm5ic3A7IDAuMDAwMDAwXSBmdHJhY2U6IGFsbG9jYXRpbmcgNDEzMDYgZW50cmll
cyBpbiAxNjIgcGFnZXM8YnI+DQomZ3Q7Jmd0OyDigKYuPGJyPg0KJmd0OyZndDsgPGJyPg0KJmd0
OyZndDsg4oCmLjxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNTk5NDg0XSBsb29wOiBtb2R1bGUg
bG9hZGVkPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi42MDMxNjBdIG52bWUgbnZtZTA6IHBjaSBm
dW5jdGlvbiAwMDA1OjA0OjAwLjA8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDEyLjYwODEyOV0gaWdi
OiBJbnRlbChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgRHJpdmVyPGJyPg0KJmd0OyZndDsg
WyZuYnNwOyAxMi42MTM0OTVdIGlnYjogQ29weXJpZ2h0IChjKSAyMDA3LTIwMTQgSW50ZWwgQ29y
cG9yYXRpb24uPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi42MTM2MzZdIG52bWUgbnZtZTA6IG1p
c3Npbmcgb3IgaW52YWxpZCBTVUJOUU4gZmllbGQuPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi42
MjU5NDFdIFVuYWJsZSB0byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBh
dCB2aXJ0dWFsIGFkZHJlc3MgMDAwMDAwMDAwMDAwMDAwODxicj4NCiZndDsmZ3Q7IFsmbmJzcDsg
MTIuNjM0NzI2XSBNZW0gYWJvcnQgaW5mbzo8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDEyLjYzNzUy
MF0mbmJzcDsgRVNSID0gMHg5NjAwMDA0NDxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNjQwNjQ2
XSZuYnNwOyBFQyA9IDB4MjU6IERBQlQgKGN1cnJlbnQgRUwpLCBJTCA9IDMyIGJpdHM8YnI+DQom
Z3Q7Jmd0OyBbJm5ic3A7IDEyLjY0NjA1NV0mbmJzcDsgU0VUID0gMCwgRm5WID0gMDxicj4NCiZn
dDsmZ3Q7IFsmbmJzcDsgMTIuNjQ5MTUzXSZuYnNwOyBFQSA9IDAsIFMxUFRXID0gMDxicj4NCiZn
dDsmZ3Q7IFsmbmJzcDsgMTIuNjUyMzY1XSBEYXRhIGFib3J0IGluZm86PGJyPg0KJmd0OyZndDsg
WyZuYnNwOyAxMi42NTUzMTRdJm5ic3A7IElTViA9IDAsIElTUyA9IDB4MDAwMDAwNDQ8YnI+DQom
Z3Q7Jmd0OyBbJm5ic3A7IDEyLjY1OTIzMV0mbmJzcDsgQ00gPSAwLCBXblIgPSAxPGJyPg0KJmd0
OyZndDsgWyZuYnNwOyAxMi42NjIyNjBdIFswMDAwMDAwMDAwMDAwMDA4XSB1c2VyIGFkZHJlc3Mg
YnV0IGFjdGl2ZV9tbSBpcyBzd2FwcGVyPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi42Njg3MjRd
IEludGVybmFsIGVycm9yOiBPb3BzOiA5NjAwMDA0NCBbIzFdIFBSRUVNUFQgU01QPGJyPg0KJmd0
OyZndDsgWyZuYnNwOyAxMi42NzQzNThdIE1vZHVsZXMgbGlua2VkIGluOjxicj4NCiZndDsmZ3Q7
IFsmbmJzcDsgMTIuNjc3NDU1XSBDUFU6IDAgUElEOiA3IENvbW06IGt3b3JrZXIvdTY0OjAgVGFp
bnRlZDogRyZuYnNwOyBXJm5ic3A7IDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAjMTxicj4N
CiZndDsmZ3Q7IFsmbmJzcDsgMTIuNjg3MDgzXSBXb3JrcXVldWU6IG52bWUtcmVzZXQtd3EgbnZt
ZV9yZXNldF93b3JrPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi42OTIwNTldIHBzdGF0ZTogNjBj
MDAwODUgKG5aQ3YgZGFJZiArUEFOICtVQU8gLVRDTyBCVFlQRT0tLSk8YnI+DQomZ3Q7Jmd0OyBb
Jm5ic3A7IDEyLjY5ODE0OV0gcGMgOiBzdGVhbF9zdWl0YWJsZV9mYWxsYmFjaysweDEzOC8weDJm
MDxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNzAzMTcwXSBsciA6IHN0ZWFsX3N1aXRhYmxlX2Zh
bGxiYWNrKzB4MWJjLzB4MmYwPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi43MDgyMDNdIHNwIDog
ZmZmZjgwMDAxMTk2YjgyMDxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNzExNTY5XSB4Mjk6IGZm
ZmY4MDAwMTE5NmI4MjAgeDI4OiAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0OyZndDsgWyZuYnNw
OyAxMi43MTY5NzVdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTE0ZGJjYjA8
YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDEyLjcyMjM1N10geDI1OiBmZmZmZmRmZmZmZTAwMDAwIHgy
NDogMDAwMDAwMDAwMDAwMDAwMTxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNzI3NzQwXSB4MjM6
IDAwMDAwMDAwMDAwMDAwMDAgeDIyOiBmZmZmZmUyMDFiZjYwMDAwPGJyPg0KJmd0OyZndDsgWyZu
YnNwOyAxMi43MzMxMjBdIHgyMTogZmZmZjA4MDcxZmJmNjk4MCB4MjA6IDAwMDAwMDAwMDAwMDA5
MDE8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDEyLjczODUwMl0geDE5OiAwMDAwMDAwMDAwMDgwMDAw
IHgxODogZmZmZmZmZmZmZmZmZmZmZjxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNzQzODg0XSB4
MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDEyPGJyPg0KJmd0OyZndDsg
WyZuYnNwOyAxMi43NDkyNjZdIHgxNTogZmZmZjA4MDcwNTA4YzY4MyB4MTQ6IDAwMDAwMDAwMDAw
MDAwNTg8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDEyLjc1NDY0OF0geDEzOiAwMDAwMDAwMDAwMDAw
MGMwIHgxMjogMDAwMDAwMDAwMDAwMDAwMDxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNzYwMDMw
XSB4MTE6IDAwMDAwMDAwMDAwMDA0MDAgeDEwOiAwMDAwMDAwMDAwMDAwMDBjPGJyPg0KJmd0OyZn
dDsgWyZuYnNwOyAxMi43NjU0MTJdIHg5IDogZmZmZjgwMDAxMDAzOWQ1OCB4OCA6IDAwMDAwMDAw
MjAwMDAwMDA8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDEyLjc3MDc5NF0geDcgOiAwMDAwMDAwMDAw
MDAwMDE4IHg2IDogZmZmZjgwMDAxMTc1MDg5MDxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNzc2
MTc2XSB4NSA6IGZmZmY4MDAwMTE3NTA4NzggeDQgOiAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0
OyZndDsgWyZuYnNwOyAxMi43ODE1NThdIHgzIDogMDAwMDAwMDAwMDAwMDAwMCB4MiA6IDAwMDAw
MDAwMDAwMDAwMDA8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDEyLjc4Njk0MF0geDEgOiAwMDAwMDAw
MDAwMDAwMjAwIHgwIDogMDAwMDAwMDAwMDAwMDAwMDxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIu
NzkyMzIyXSBDYWxsIHRyYWNlOjxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuNzk0ODA2XSZuYnNw
OyBzdGVhbF9zdWl0YWJsZV9mYWxsYmFjaysweDEzOC8weDJmMDxicj4NCiZndDsmZ3Q7IFsmbmJz
cDsgMTIuNzk5NTIwXSZuYnNwOyBnZXRfcGFnZV9mcm9tX2ZyZWVsaXN0KzB4ZTMwLzB4MTJhMDxi
cj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuODA0MjA3XSZuYnNwOyBfX2FsbG9jX3BhZ2VzX25vZGVt
YXNrKzB4MTQ4LzB4ZTAwPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi44MDg4MDldJm5ic3A7IF9f
ZG1hX2RpcmVjdF9hbGxvY19wYWdlcysweGE0LzB4MWQwPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAx
Mi44MTM0OTZdJm5ic3A7IGRtYV9kaXJlY3RfYWxsb2MrMHgxZDgvMHgzNDA8YnI+DQomZ3Q7Jmd0
OyBbJm5ic3A7IDEyLjgxNzU3MV0mbmJzcDsgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQrMHg2
OC8weDM3MDxicj4NCiZndDsmZ3Q7IFsmbmJzcDsgMTIuODIyNDM5XSZuYnNwOyBkbWFfYWxsb2Nf
YXR0cnMrMHhlOC8weGYwPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi44MjYyNDZdJm5ic3A7IG52
bWVfcmVzZXRfd29yaysweDEwMzAvMHgxNTIwPGJyPg0KJmd0OyZndDsgWyZuYnNwOyAxMi44MzA0
MTddJm5ic3A7IHByb2Nlc3Nfb25lX3dvcmsrMHgxZGMvMHg0YmM8YnI+DQomZ3Q7Jmd0OyBbJm5i
c3A7IDEyLjgzNDQ5NV0mbmJzcDsgd29ya2VyX3RocmVhZCsweDE0NC8weDQ3MDxicj4NCiZndDsm
Z3Q7IFsmbmJzcDsgMTIuODM4MzEzXSZuYnNwOyBrdGhyZWFkKzB4MTRjLzB4MTYwPGJyPg0KJmd0
OyZndDsgWyZuYnNwOyAxMi44NDE2MDRdJm5ic3A7IHJldF9mcm9tX2ZvcmsrMHgxMC8weDM4PGJy
Pg0KJmd0OyZndDsgWyZuYnNwOyAxMi44NDUyNTVdIENvZGU6IGE5NDA4MmM0IGQzN2VmNDYzIGNi
M2M0MDYzIDhiM2M0MDQyIChmOTAwMDQ4MCk8YnI+DQomZ3Q7Jmd0OyBbJm5ic3A7IDEyLjg1MTQ0
N10gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I3MiBdLS0tPGJyPg0KJmd0OyZndDsgWyZu
YnNwOyAxMi44NTYxMTddIG5vdGU6IGt3b3JrZXIvdTY0OjBbN10gZXhpdGVkIHdpdGggcHJlZW1w
dF9jb3VudDxicj4NCiZndDsgPGJyPg0KJmd0OyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCBj
YWxscyBkbWFfZGlyZWN0X2FsbG9jIHdoaWNoIGZhaWxzIGZvciB0aGU8YnI+DQomZ3Q7IGRldmlj
ZS48YnI+DQomZ3Q7IDxicj4NCiZndDsgV2l0aG91dCBzd2lvdGxiX3hlbiwgZG1hX2FsbG9jX2F0
dHJzIHdvdWxkIGRvOjxicj4NCiZndDsgPGJyPg0KJmd0OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyBpZiAoZG1hX2FsbG9jX2RpcmVjdChkZXYsIG9wcykpPGJyPg0K
Jmd0OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBjcHVfYWRkciA9IGRtYV9kaXJl
Y3RfYWxsb2MoZGV2LCBzaXplLCBkbWFfaGFuZGxlLCBmbGFnLCBhdHRycyk7PGJyPg0KJmd0OyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBlbHNlIGlmIChvcHMtJmd0
O2FsbG9jKTxicj4NCiZndDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgY3B1X2Fk
ZHIgPSBvcHMtJmd0O2FsbG9jKGRldiwgc2l6ZSwgZG1hX2hhbmRsZSwgZmxhZywgYXR0cnMpOzxi
cj4NCiZndDsgPGJyPg0KJmd0OyBkbWFfYWxsb2NfZGlyZWN0IGlzIHRoZSB2ZXJ5IHNhbWUgY2Fs
bCB0aGF0IGZhaWxzIHdoZW4gY2FsbGVkIGZyb208YnI+DQomZ3Q7IHhlbl9zd2lvdGxiX2FsbG9j
X2NvaGVyZW50LiBTbyBpdCBtdXN0IGJlIHRoYXQgdGhlIHBhdGggbWVhbnQgdG8gYmU8YnI+DQom
Z3Q7IHRha2VuIGlzIG9wcy0mZ3Q7YWxsb2MgaW5zdGVhZC48YnI+DQomZ3Q7IDxicj4NCiZndDsg
b3BzLSZndDthbGxvYyBpcyB0aGUgZG1hX29wcyBmdW5jdGlvbiB0byBhbGxvY2F0ZSBhIGNvaGVy
ZW50IGJ1ZmZlci48YnI+DQomZ3Q7IFdoZW4gc3dpb3RsYi14ZW4gaXMgZW5hYmxlZCwgaXQgcG9p
bnRzIHRvIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50Ljxicj4NCiZndDsgT2Z0ZW4gZG1hX29w
cyBpcyBOVUxMIHdoZW4gWGVuIGlzIGRpc2FibGVkLjxicj4NCiZndDsgPGJyPg0KJmd0OyBJIHRo
aW5rIHRoZSBtb3N0IGxpa2VseSBleHBsYW5hdGlvbiBpcyB0aGF0IHRoZSBudm1lIGRldmljZSBy
ZXF1aXJlIGE8YnI+DQomZ3Q7IHNwZWNpZmljIGRtYV9vcHMuIFdoZW4gc3dpb3RsYi14ZW4gaXMg
ZW5hYmxlZCwgaXQgZ2V0cyBvdmVyd3JpdHRlbiBieTxicj4NCiZndDsgYXJjaC9hcm02NC9tbS9k
bWEtbWFwcGluZy5jOmFyY2hfc2V0dXBfZG1hX29wcy48YnI+DQomZ3Q7IDxicj4NCiZndDsgQ2Fu
IHlvdSBkb3VibGUtY2hlY2sgdGhpcyB0aGVvcnkgYnkgYWRkaW5nIGEgZmV3IHByaW50a3MgaW48
YnI+DQomZ3Q7IGFyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYzphcmNoX3NldHVwX2RtYV9vcHMs
IHRvIGNoZWNrIHRoZSBkbWFfb3BzPGJyPg0KJmd0OyB1c2VkIHdoZW4gIUNPTkZJR19YRU4sIGFu
ZCBhbHNvIGluIGtlcm5lbC9kbWEvbWFwcGluZy5jOmRtYV9hbGxvY19hdHRyczxicj4NCiZndDsg
dG8gY2hlY2sgdGhlIGNvZGUgcGF0aCB0YWtlbiB3aGVuICFDT05GSUdfWEVOPzxicj4NCjxicj4N
CkkgY2hlY2tlZCB0aGUgY29kZSBwYXRoIHdoZW4gIUNPTkZJRF9YRU4gYW5kIFNNTVUgaXMgbm90
IGVuYWJsZWQgaW4gbGludXgsIGNvZGUgcGF0aCBpczo8YnI+DQombmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgZG1hX2FsbG9jX2F0dHJzKCkgLSZndDsgZG1hX2FsbG9j
X2RpcmVjdCgpPGJyPg0KYW5kIHRoZXJlIGlzIG5vIGlzc3VlIGluIGJvb3RpbmcgYW5kIGFsbG9j
YXRpbmcgYSBjb2hlcmVudCBidWZmZXIuPGJyPg0KPGJyPg0KV2hlbiAhQ09ORklHX1hFTiBhbmQg
U01NVSBpcyBlbmFibGVkIGNvZGUgcGF0aCBpczo8YnI+DQombmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsgZG1hX2FsbG9jX2F0dHJzKCktJmd0OyBvcHMtJmd0O2FsbG9j
IC0mZ3Q7IGlvbW11X2RtYV9hbGxvYygpPGJyPg0KYW5kIHRoZXJlIGlzIG5vIGlzc3VlIGluIGJv
b3RpbmcgYW5kIGFsbG9jYXRpbmcgYSBjb2hlcmVudCBidWZmZXIgaW4gdGhpcyBjYXNlIGFsc28u
PGJyPg0KPGJyPg0KV2hlbiBYZW4gaXMgZW5hYmxlZCBjb2RlIHBhdGggaXM6PGJyPg0KJm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IGRtYV9hbGxvY19hdHRycygpLSZn
dDsgb3BzLSZndDthbGxvYygpIC0mZ3Q7IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50KCkgLSZn
dDsgZG1hX2FsbG9jX2RpcmVjdCgpPGJyPg0KaW4gdGhpcyBjYXNlIGFsbG9jYXRpbmcgdGhlIGNv
aGVyZW50IGJ1ZmZlciBmYWlsZWQuPGJyPg0KPGJyPg0KT25seSBkaWZmZXJlbmNlIEkgc2VlIGlz
IHRoZSBzaXplIGFyZ3VtZW50IGZvciBkbWFfYWxsb2NfZGlyZWN0KCkgaW4gWGVuIGNhc2UgYnV0
IEkgZG9u4oCZdCB0aGluazxicj4NCnRoYXQgaXMgY2F1c2luZyB0aGUgaXNzdWUgdGhlcmUgaXMg
c29tZXRoaW5nIGVsc2UgY2F1c2luZyB0aGUgaXNzdWUgbWF5YmUgZnJvbTxicj4NCndoZXJlIHRo
ZSBjb2hlcmVudCBtZW1vcnkgaXMgYWxsb2NhdGVkLiA8YnI+DQombmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgPGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7IC8qIENvbnZlcnQgdGhlIHNpemUgdG8gYWN0dWFsbHkgYWxsb2NhdGVk
LiAqLyA8YnI+DQombmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgc2l6
ZSA9IDFVTCAmbHQ7Jmx0OyAob3JkZXIgKyBYRU5fUEFHRV9TSElGVCk7PGJyPg0KPGJyPg0KPGJy
Pg0KUGxlYXNlIGZpbmQgdGhlIGF0dGFjaGVkIGRldGFpbGVkIGxvZ3MgZm9yIGVhY2ggY2FzZS48
YnI+DQo8YnI+DQo8YnI+DQo8L2Rpdj4NCjwvc3Bhbj48L2ZvbnQ+PC9kaXY+DQo8ZGl2IGNsYXNz
PSJCb2R5RnJhZ21lbnQiPjxmb250IHNpemU9IjIiPjxzcGFuIHN0eWxlPSJmb250LXNpemU6MTFw
dDsiPg0KPGRpdiBjbGFzcz0iUGxhaW5UZXh0Ij48YnI+DQo8YnI+DQpSZWdhcmRzLDxicj4NClJh
aHVsPC9kaXY+DQo8L3NwYW4+PC9mb250PjwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K

--_000_8C5118886183421EA4C7B271DAF46696armcom_--

--_007_8C5118886183421EA4C7B271DAF46696armcom_
Content-Type: application/octet-stream;
	name="native_linux_boot_with_smmu_debug.log"
Content-Description: native_linux_boot_with_smmu_debug.log
Content-Disposition: attachment;
	filename="native_linux_boot_with_smmu_debug.log"; size=383190;
	creation-date="Thu, 14 Apr 2022 17:44:24 GMT";
	modification-date="Thu, 14 Apr 2022 17:44:24 GMT"
Content-ID: <D93460CC5F098F4E976B594249C4D93C@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogVGh1IEFwciAxNCAxMTozMToyNSBvbiB0dHlzMDAxCnJhaHNpbjAxQEMwMlpY
MEc5TFZETiB4ODZfNjQgJSB0ZWxuZXQgZTEyMzM0My5jYW1icmlkZ2UuYXJtLmNvbSAxMDAyMApU
cnlpbmcgMTAuMS4xOTQuMjUuLi4KQ29ubmVjdGVkIHRvIGUxMjMzNDMuY2FtYnJpZGdlLmFybS5j
b20uCkVzY2FwZSBjaGFyYWN0ZXIgaXMgJ15dJy4KCkFJUyB0YXJnZXQgc3lzdGVtIHBvcnQgMTAw
MjAgZGV2aWNlIC9kZXYvdHR5VVNCMSBbMTE1MjAwIE44MV0KCgpGUzA6XD4gY2QgRUZJCkZTMDpc
RUZJXD4gY2QgQk9PVApGUzA6XEVGSVxCT09UXD4gYm9vdGFhNjQuZWZpCldlbGNvbWUgdG8gR1JV
QiEKCmVycm9yOiBubyBzdWNoIGRldmljZTogKChoZDAsZ3B0MSkvRUZJL0JPT1QpL0VGSS9CT09U
L2dydWIuY2ZnLgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgR05VIEdSVUIgIHZlcnNpb24gMi4wNgoKIC8tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tXAogfCBQ
QVJUVVVJRCBCb290OiBDT00tSFBDIFlvY3RvIEltYWdlICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8IAogfCBOVk1lIE0uMiAgU1NEIEJvb3Q6IENPTS1IUEMgWW9jdG8g
SW1hZ2UgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8KlVTQiBCb290IChJ
ZiBEcml2ZSBpcyBwcmVzZW50KTogQ09NLUhQQyBZb2N0byBJbWFnZSAgICAgICAgICAgICAgICAg
ICAgICAgIHwKIHwgQ09NLUhQQyBZb2N0byBJbWFnZSAoWGVuKSAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAog
fCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgfCAKIFwtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLwoKICAgICAgVXNlIHRoZSBeIGFuZCB2
IGtleXMgdG8gc2VsZWN0IHdoaWNoIGVudHJ5IGlzIGhpZ2hsaWdodGVkLiAgICAgICAgICAKICAg
ICAgUHJlc3MgZW50ZXIgdG8gYm9vdCB0aGUgc2VsZWN0ZWQgT1MsIGBlJyB0byBlZGl0IHRoZSBj
b21tYW5kcyAgICAgICAKICAgICAgYmVmb3JlIGJvb3Rpbmcgb3IgYGMnIGZvciBhIGNvbW1hbmQt
bGluZS4gICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoK
CgoKCgoKCgoKCgoKCgoKRUZJIHN0dWI6IEJvb3RpbmcgTGludXggS2VybmVsLi4uCkVGSSBzdHVi
OiBVc2luZyBEVEIgZnJvbSBjb25maWd1cmF0aW9uIHRhYmxlCkVGSSBzdHViOiBFeGl0aW5nIGJv
b3Qgc2VydmljZXMgYW5kIGluc3RhbGxpbmcgdmlydHVhbCBhZGRyZXNzIG1hcC4uLgpQUk9HUkVT
UyBDT0RFOiBWMDMxMDEwMTkgSTAKWyAgICAwLjAwMDAwMF0gQm9vdGluZyBMaW51eCBvbiBwaHlz
aWNhbCBDUFUgMHgwMDAwMTAwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDAwMDAwXSBMaW51eCB2
ZXJzaW9uIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAob2UtdXNlckBvZS1ob3N0KSAoYWFy
Y2g2NC1wb2t5LWxpbnV4LWdjYyAoR0NDKSAxMS4yLjAsIEdOVSBsZCAoR05VIEJpbnV0aWxzKSAy
LjM3LjIwMjEwNzIxKSAjMSBTTVAgUFJFRU1QVCBTYXQgU2VwIDE4IDA2OjAxOjU5IFVUQyAyMDIx
ClsgICAgMC4wMDAwMDBdIGVmaTogRUZJIHYyLjcwIGJ5IEVESyBJSQpbICAgIDAuMDAwMDAwXSBl
Zmk6IFRQTUZpbmFsTG9nPTB4ODA3ZjllZjAwMDAgQUNQSSAyLjA9MHg4MDdmYTBkMDAxOCBTTUJJ
T1MgMy4wPTB4ODA3ZjhlMzAwMDAgTUVNQVRUUj0weDgwN2Y3ZGUwMDE4IEVTUlQ9MHg4MDdmODUx
YjM5OCBUUE1FdmVudExvZz0weDgwN2Y3ZGUxMDE4IFJORz0weGZmYjRiYTk4IE1FTVJFU0VSVkU9
MHg4MDdmN2ViOWU5OCAKWyAgICAwLjAwMDAwMF0gZWZpOiBzZWVkaW5nIGVudHJvcHkgcG9vbApb
ICAgIDAuMDAwMDAwXSBlc3J0OiBSZXNlcnZpbmcgRVNSVCBzcGFjZSBmcm9tIDB4MDAwMDA4MDdm
ODUxYjM5OCB0byAweDAwMDAwODA3Zjg1MWIzZDAuClsgICAgMC4wMDAwMDBdIEFDUEk6IEVhcmx5
IHRhYmxlIGNoZWNrc3VtIHZlcmlmaWNhdGlvbiBkaXNhYmxlZApbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBSU0RQIDB4MDAwMDA4MDdGQTBEMDAxOCAwMDAwMjQgKHYwMiBBbXBlcmUpClsgICAgMC4wMDAw
MDBdIEFDUEk6IFhTRFQgMHgwMDAwMDgwN0ZBMERGRTk4IDAwMDBBNCAodjAxIEFtcGVyZSBBbHRy
YSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBGQUNQIDB4
MDAwMDA4MDdGQTBERkI5OCAwMDAxMTQgKHYwNiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1Q
LiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogRFNEVCAweDAwMDAwODA3RjhEQjAwMTgg
MDJDMTlFICh2MDIgQW1wZXJlIEphZGUgICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpClsgICAg
MC4wMDAwMDBdIEFDUEk6IEJFUlQgMHgwMDAwMDgwN0ZBMERGRjk4IDAwMDAzMCAodjAxIEFtcGVy
ZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBE
QkcyIDB4MDAwMDA4MDdGQTBERkE5OCAwMDAwNUMgKHYwMCBBbXBlcmUgQWx0cmEgICAgMDAwMDAw
MDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogR1REVCAweDAwMDAwODA3RkEw
REU5OTggMDAwMTEwICh2MDMgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMp
ClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1IgMHgwMDAwMDgwN0ZBMERGRTE4IDAwMDA1MCAodjAy
IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBB
Q1BJOiBFSU5KIDB4MDAwMDA4MDdGQTBERjU5OCAwMDAxNTAgKHYwMSBBbXBlcmUgQWx0cmEgICAg
MDAwMDAwMDEgSU5UTCAyMDIwMTIxNykKWyAgICAwLjAwMDAwMF0gQUNQSTogSEVTVCAweDAwMDAw
ODA3RkEwREVCMTggMDAwMUY0ICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIElOVEwgMjAy
MDEyMTcpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNTRFQgMHgwMDAwMDgwN0ZBMERGQTE4IDAwMDAy
RCAodjAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAxMjE3KQpbICAgIDAuMDAw
MDAwXSBBQ1BJOiBUUE0yIDB4MDAwMDA4MDdGQTBERkQxOCAwMDAwNEMgKHYwNCBBbXBlcmUgQWx0
cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogTUNGRyAw
eDAwMDAwODA3RkEwREY3MTggMDAwMDdDICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIEFN
UC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IElPUlQgMHgwMDAwMDgwN0ZBMERFRjE4
IDAwMDNEQyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAg
IDAuMDAwMDAwXSBBQ1BJOiBBUElDIDB4MDAwMDA4MDdGQTBENzUxOCAwMDBBRjQgKHYwNSBBbXBl
cmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTog
UFBUVCAweDAwMDAwODA3RkEwRDg2MTggMDA0NTIwICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAw
MDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNMSVQgMHgwMDAwMDgwN0ZB
MERGRDk4IDAwMDAyRCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEz
KQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUIDB4MDAwMDA4MDdGQTBEQ0UxOCAwMDAzNzAgKHYw
MyBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0g
QUNQSTogUENDVCAweDAwMDAwODA3RkEwREUzMTggMDAwNTc2ICh2MDIgQW1wZXJlIEFsdHJhICAg
IDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1I6IGNvbnNv
bGU6IHBsMDExLG1taW8zMiwweDEwMDAwMjYwMDAwMCwxMTUyMDAKWyAgICAwLjAwMDAwMF0gQUNQ
STogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4ODMwMDAwMC0weDg4M2ZmZmZmXQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDkwMDAwMDAwLTB4ZmZmZmZm
ZmZdClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODAwMDAw
MDAwMDAtMHg4MDA3ZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBY
TSAwIFttZW0gMHg4MDEwMDAwMDAwMC0weDgwN2ZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSBOVU1B
OiBOT0RFX0RBVEEgW21lbSAweDgwN2ZjMDcwZTAwLTB4ODA3ZmMwNzJmZmZdClsgICAgMC4wMDAw
MDBdIFpvbmUgcmFuZ2VzOgpbICAgIDAuMDAwMDAwXSAgIERNQSAgICAgIFttZW0gMHgwMDAwMDAw
MDg4MzAwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBETUEzMiAgICBl
bXB0eQpbICAgIDAuMDAwMDAwXSAgIE5vcm1hbCAgIFttZW0gMHgwMDAwMDAwMTAwMDAwMDAwLTB4
MDAwMDA4MDdmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gTW92YWJsZSB6b25lIHN0YXJ0IGZvciBl
YWNoIG5vZGUKWyAgICAwLjAwMDAwMF0gRWFybHkgbWVtb3J5IG5vZGUgcmFuZ2VzClsgICAgMC4w
MDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMDg4MzAwMDAwLTB4MDAwMDAwMDA4ODNm
ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwOTAwMDAwMDAt
MHgwMDAwMDAwMDkxZmZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAw
MDAwMDA5MjAwMDAwMC0weDAwMDAwMDAwOTI3YmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAg
IDA6IFttZW0gMHgwMDAwMDAwMDkyN2MwMDAwLTB4MDAwMDAwMDBmZmIzZmZmZl0KWyAgICAwLjAw
MDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwZmZiNDAwMDAtMHgwMDAwMDAwMGZmYjRm
ZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAwMDBmZmI1MDAwMC0w
eDAwMDAwMDAwZmZmZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAw
MDgwMDAwMDAwMDAwLTB4MDAwMDA4MDA3ZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAg
MDogW21lbSAweDAwMDAwODAxMDAwMDAwMDAtMHgwMDAwMDgwN2Y2NTVjZmZmXQpbICAgIDAuMDAw
MDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmNjU1ZDAwMC0weDAwMDAwODA3ZjZjMDVm
ZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y2YzA2MDAwLTB4
MDAwMDA4MDdmNzBmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAw
ODA3ZjcxMDAwMDAtMHgwMDAwMDgwN2Y3MTlmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAw
OiBbbWVtIDB4MDAwMDA4MDdmNzFhMDAwMC0weDAwMDAwODA3ZjdlN2ZmZmZdClsgICAgMC4wMDAw
MDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y3ZTgwMDAwLTB4MDAwMDA4MDdmN2U5ZmZm
Zl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjdlYTAwMDAtMHgw
MDAwMDgwN2Y3ZWVmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4
MDdmN2VmMDAwMC0weDAwMDAwODA3ZjdmMmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6
IFttZW0gMHgwMDAwMDgwN2Y3ZjMwMDAwLTB4MDAwMDA4MDdmODdlZmZmZl0KWyAgICAwLjAwMDAw
MF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3Zjg3ZjAwMDAtMHgwMDAwMDgwN2Y4ODJmZmZm
XQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmODgzMDAwMC0weDAw
MDAwODA3ZjhhNmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgw
N2Y4YTcwMDAwLTB4MDAwMDA4MDdmOGFhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDog
W21lbSAweDAwMDAwODA3ZjhhYjAwMDAtMHgwMDAwMDgwN2Y4ZTFmZmZmXQpbICAgIDAuMDAwMDAw
XSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOGUyMDAwMC0weDAwMDAwODA3ZjhlM2ZmZmZd
ClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4ZTQwMDAwLTB4MDAw
MDA4MDdmOGU2ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3
ZjhlNzAwMDAtMHgwMDAwMDgwN2Y5ZTdmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBb
bWVtIDB4MDAwMDA4MDdmOWU4MDAwMC0weDAwMDAwODA3ZjllZWZmZmZdClsgICAgMC4wMDAwMDBd
ICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y5ZWYwMDAwLTB4MDAwMDA4MDdmOWYxZmZmZl0K
WyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjlmMjAwMDAtMHgwMDAw
MDgwN2Y5ZmJmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdm
OWZjMDAwMC0weDAwMDAwODA3ZjlmZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFtt
ZW0gMHgwMDAwMDgwN2ZhMDAwMDAwLTB4MDAwMDA4MDdmYTBmZmZmZl0KWyAgICAwLjAwMDAwMF0g
ICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmExMDAwMDAtMHgwMDAwMDgwN2ZhMTlmZmZmXQpb
ICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTFhMDAwMC0weDAwMDAw
ODA3ZmEyNmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Zh
MjcwMDAwLTB4MDAwMDA4MDdmYTRhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21l
bSAweDAwMDAwODA3ZmE0YjAwMDAtMHgwMDAwMDgwN2ZhNzFmZmZmXQpbICAgIDAuMDAwMDAwXSAg
IG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTcyMDAwMC0weDAwMDAwODA3ZmE3NWZmZmZdClsg
ICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhNzYwMDAwLTB4MDAwMDA4
MDdmYThjZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmE4
ZDAwMDAtMHgwMDAwMDgwN2ZhOTZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVt
IDB4MDAwMDA4MDdmYTk3MDAwMC0weDAwMDAwODA3ZmE5ZmZmZmZdClsgICAgMC4wMDAwMDBdICAg
bm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhYTAwMDAwLTB4MDAwMDA4MDdmYmFhZmZmZl0KWyAg
ICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmJhYjAwMDAtMHgwMDAwMDgw
N2ZiYjNmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmI0
MDAwMC0weDAwMDAwODA3ZmJiZGZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0g
MHgwMDAwMDgwN2ZiYmUwMDAwLTB4MDAwMDA4MDdmYmNhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBu
b2RlICAgMDogW21lbSAweDAwMDAwODA3ZmJjYjAwMDAtMHgwMDAwMDgwN2ZiY2VmZmZmXQpbICAg
IDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmNmMDAwMC0weDAwMDAwODA3
ZmJkNWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZiZDYw
MDAwLTB4MDAwMDA4MDdmYmRmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAw
eDAwMDAwODA3ZmJlMDAwMDAtMHgwMDAwMDgwN2ZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSBJbml0
bWVtIHNldHVwIG5vZGUgMCBbbWVtIDB4MDAwMDAwMDA4ODMwMDAwMC0weDAwMDAwODA3ZmZmZmZm
ZmZdClsgICAgMC4wMDAwMDBdIHBzY2k6IHByb2JpbmcgZm9yIGNvbmR1aXQgbWV0aG9kIGZyb20g
QUNQSS4KWyAgICAwLjAwMDAwMF0gcHNjaTogUFNDSXYxLjEgZGV0ZWN0ZWQgaW4gZmlybXdhcmUu
ClsgICAgMC4wMDAwMDBdIHBzY2k6IFVzaW5nIHN0YW5kYXJkIFBTQ0kgdjAuMiBmdW5jdGlvbiBJ
RHMKWyAgICAwLjAwMDAwMF0gcHNjaTogTUlHUkFURV9JTkZPX1RZUEUgbm90IHN1cHBvcnRlZC4K
WyAgICAwLjAwMDAwMF0gcHNjaTogU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4yClsgICAgMC4w
MDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ODAwMDAgLT4gTm9kZSAw
ClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ODAxMDAg
LT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURS
IDB4OTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAw
IC0+IE1QSURSIDB4OTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNS
QVQ6IFBYTSAwIC0+IE1QSURSIDB4ZTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6
IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAw
MDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZjAwMDAgLT4gTm9kZSAwClsg
ICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZjAxMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
MTAwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAt
PiBNUElEUiAweDEwMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JB
VDogUFhNIDAgLT4gTVBJRFIgMHgxMTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6
IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTEwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAw
MDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE2MDAwMCAtPiBOb2RlIDAK
WyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxNjAxMDAg
LT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURS
IDB4MTcwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0g
MCAtPiBNUElEUiAweDE3MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTog
U1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxODAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFD
UEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTgwMTAwIC0+IE5vZGUgMApbICAgIDAu
MDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE5MDAwMCAtPiBOb2Rl
IDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxOTAx
MDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1Q
SURSIDB4MWUwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQ
WE0gMCAtPiBNUElEUiAweDFlMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVN
QTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxZjAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBd
IEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MWYwMTAwIC0+IE5vZGUgMApbICAg
IDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDIwMDAwMCAtPiBO
b2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgy
MDAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+
IE1QSURSIDB4MjEwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFU
OiBQWE0gMCAtPiBNUElEUiAweDIxMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTog
TlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgyNjAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAw
MDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MjYwMTAwIC0+IE5vZGUgMApb
ICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDI3MDAwMCAt
PiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIg
MHgyNzAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIHBlcmNwdTogRW1iZWRkZWQgMzEgcGFn
ZXMvY3B1IHM4OTI0MCByODE5MiBkMjk1NDQgdTEyNjk3NgpbICAgIDAuMDAwMDAwXSBEZXRlY3Rl
ZCBQSVBUIEktY2FjaGUgb24gQ1BVMApbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVj
dGVkOiBHSUMgc3lzdGVtIHJlZ2lzdGVyIENQVSBpbnRlcmZhY2UKWyAgICAwLjAwMDAwMF0gQ1BV
IGZlYXR1cmVzOiBkZXRlY3RlZDogVmlydHVhbGl6YXRpb24gSG9zdCBFeHRlbnNpb25zClsgICAg
MC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEhhcmR3YXJlIGRpcnR5IGJpdCBtYW5h
Z2VtZW50ClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFNwZWN0cmUtdjQK
WyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQVJNIGVycmF0dW0gMTQxODA0
MApbICAgIDAuMDAwMDAwXSBhbHRlcm5hdGl2ZXM6IHBhdGNoaW5nIGtlcm5lbCBjb2RlClsgICAg
MC4wMDAwMDBdIEJ1aWx0IDEgem9uZWxpc3RzLCBtb2JpbGl0eSBncm91cGluZyBvbi4gIFRvdGFs
IHBhZ2VzOiA4MTkzMjc2ClsgICAgMC4wMDAwMDBdIFBvbGljeSB6b25lOiBOb3JtYWwKWyAgICAw
LjAwMDAwMF0gS2VybmVsIGNvbW1hbmQgbGluZTogQk9PVF9JTUFHRT0vSW1hZ2Ugcm9vdHdhaXQg
cncgcm9vdD0vZGV2L3NkYTIKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbiBpbmRp
dmlkdWFsIG1heCBjcHUgY29udHJpYnV0aW9uOiA0MDk2IGJ5dGVzClsgICAgMC4wMDAwMDBdIHBy
aW50azogbG9nX2J1Zl9sZW4gdG90YWwgY3B1X2V4dHJhIGNvbnRyaWJ1dGlvbnM6IDEyNjk3NiBi
eXRlcwpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVuIG1pbiBzaXplOiAxMzEwNzIg
Ynl0ZXMKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbjogMjYyMTQ0IGJ5dGVzClsg
ICAgMC4wMDAwMDBdIHByaW50azogZWFybHkgbG9nIGJ1ZiBmcmVlOiAxMjEyNDgoOTIlKQpbICAg
IDAuMDAwMDAwXSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA0MTk0MzA0IChvcmRl
cjogMTMsIDMzNTU0NDMyIGJ5dGVzLCBsaW5lYXIpClsgICAgMC4wMDAwMDBdIElub2RlLWNhY2hl
IGhhc2ggdGFibGUgZW50cmllczogMjA5NzE1MiAob3JkZXI6IDEyLCAxNjc3NzIxNiBieXRlcywg
bGluZWFyKQpbICAgIDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBzdGFjazpvZmYsIGhlYXAgYWxs
b2M6b2ZmLCBoZWFwIGZyZWU6b2ZmClsgICAgMC4wMDAwMDBdIHNvZnR3YXJlIElPIFRMQjogbWFw
cGVkIFttZW0gMHgwMDAwMDAwMGZiYjQwMDAwLTB4MDAwMDAwMDBmZmI0MDAwMF0gKDY0TUIpClsg
ICAgMC4wMDAwMDBdIE1lbW9yeTogMzI1MDIyOTJLLzMzMjkzMzEySyBhdmFpbGFibGUgKDEzNTY4
SyBrZXJuZWwgY29kZSwgMTk5NksgcndkYXRhLCAzNDgwSyByb2RhdGEsIDQxNjBLIGluaXQsIDgy
MksgYnNzLCA3OTEwMjBLIHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2ZWQpClsgICAgMC4wMDAwMDBd
IFNMVUI6IEhXYWxpZ249NjQsIE9yZGVyPTAtMywgTWluT2JqZWN0cz0wLCBDUFVzPTMyLCBOb2Rl
cz0xClsgICAgMC4wMDAwMDBdIGZ0cmFjZTogYWxsb2NhdGluZyA0MTM4NyBlbnRyaWVzIGluIDE2
MiBwYWdlcwpbICAgIDAuMDAwMDAwXSBmdHJhY2U6IGFsbG9jYXRlZCAxNjIgcGFnZXMgd2l0aCAz
IGdyb3VwcwpbICAgIDAuMDAwMDAwXSByY3U6IFByZWVtcHRpYmxlIGhpZXJhcmNoaWNhbCBSQ1Ug
aW1wbGVtZW50YXRpb24uClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSBldmVudCB0cmFjaW5nIGlz
IGVuYWJsZWQuClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSByZXN0cmljdGluZyBDUFVzIGZyb20g
TlJfQ1BVUz0yNTYgdG8gbnJfY3B1X2lkcz0zMi4KWyAgICAwLjAwMDAwMF0gCVRyYW1wb2xpbmUg
dmFyaWFudCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gCVJ1ZGUgdmFyaWFu
dCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gCVRyYWNpbmcgdmFyaWFudCBv
ZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gcmN1OiBSQ1UgY2FsY3VsYXRlZCB2
YWx1ZSBvZiBzY2hlZHVsZXItZW5saXN0bWVudCBkZWxheSBpcyAyNSBqaWZmaWVzLgpbICAgIDAu
MDAwMDAwXSByY3U6IEFkanVzdGluZyBnZW9tZXRyeSBmb3IgcmN1X2Zhbm91dF9sZWFmPTE2LCBu
cl9jcHVfaWRzPTMyClsgICAgMC4wMDAwMDBdIE5SX0lSUVM6IDY0LCBucl9pcnFzOiA2NCwgcHJl
YWxsb2NhdGVkIGlycXM6IDAKWyAgICAwLjAwMDAwMF0gR0lDdjM6IEdJQzogVXNpbmcgc3BsaXQg
RU9JL0RlYWN0aXZhdGUgbW9kZQpbICAgIDAuMDAwMDAwXSBHSUN2MzogNjcyIFNQSXMgaW1wbGVt
ZW50ZWQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IDAgRXh0ZW5kZWQgU1BJcyBpbXBsZW1lbnRlZApb
ICAgIDAuMDAwMDAwXSBHSUN2MzogRGlzdHJpYnV0b3IgaGFzIG5vIFJhbmdlIFNlbGVjdG9yIHN1
cHBvcnQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IDE2IFBQSXMgaW1wbGVtZW50ZWQKWyAgICAwLjAw
MDAwMF0gR0lDdjM6IENQVTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTAwMDAwIHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDU0MDAwMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMCAtPiBO
b2RlIDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDEgLT4gTm9kZSAwClsgICAg
MC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyAyIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBT
UkFUOiBQWE0gMCAtPiBJVFMgMyAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAg
LT4gSVRTIDQgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA1IC0+
IE5vZGUgMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNiAtPiBOb2RlIDAKWyAg
ICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDcgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBd
IElUUyBbbWVtIDB4MTAwMTAwMDQwMDAwLTB4MTAwMTAwMDVmZmZmXQpbICAgIDAuMDAwMDAwXSBJ
VFNAMHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDIyMDAw
MCAoaW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4
MDAwMDEwMDEwMDA0MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBA
ODAwMDAyMzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0g
SVRTIFttZW0gMHgxMDAxMDAwNjAwMDAtMHgxMDAxMDAwN2ZmZmZdClsgICAgMC4wMDAwMDBdIElU
U0AweDAwMDAxMDAxMDAwNjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMjUwMDAw
IChpbmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgw
MDAwMTAwMTAwMDYwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4
MDAwMDI2MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJ
VFMgW21lbSAweDEwMDEwMDA4MDAwMC0weDEwMDEwMDA5ZmZmZl0KWyAgICAwLjAwMDAwMF0gSVRT
QDB4MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAyODAwMDAg
KGluZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAwODAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgw
MDAwMjkwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElU
UyBbbWVtIDB4MTAwMTAwMGEwMDAwLTB4MTAwMTAwMGJmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNA
MHgwMDAwMTAwMTAwMGEwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDJiMDAwMCAo
aW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAw
MDEwMDEwMDBhMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAw
MDAyYzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRT
IFttZW0gMHgxMDAxMDAwYzAwMDAtMHgxMDAxMDAwZGZmZmZdClsgICAgMC4wMDAwMDBdIElUU0Aw
eDAwMDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMmUwMDAwIChp
bmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAw
MTAwMTAwMGMwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAw
MDJmMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFMg
W21lbSAweDEwMDEwMDBlMDAwMC0weDEwMDEwMDBmZmZmZl0KWyAgICAwLjAwMDAwMF0gSVRTQDB4
MDAwMDEwMDEwMDBlMDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAzMTAwMDAgKGlu
ZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAx
MDAxMDAwZTAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAw
MzIwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUUyBb
bWVtIDB4MTAwMTAwMTAwMDAwLTB4MTAwMTAwMTFmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNAMHgw
MDAwMTAwMTAwMTAwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDM0MDAwMCAoaW5k
aXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEw
MDEwMDEwMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAz
NTAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTIFtt
ZW0gMHgxMDAxMDAxMjAwMDAtMHgxMDAxMDAxM2ZmZmZdClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAxMjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMzcwMDAwIChpbmRp
cmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMTIwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDM4
MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBHSUN2Mzog
dXNpbmcgTFBJIHByb3BlcnR5IHRhYmxlIEAweDAwMDAwODAwMDAzOTAwMDAKWyAgICAwLjAwMDAw
MF0gR0lDdjM6IENQVTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAw
MDgwMDAwM2EwMDAwClsgICAgMC4wMDAwMDBdIHJhbmRvbTogZ2V0X3JhbmRvbV9ieXRlcyBjYWxs
ZWQgZnJvbSBzdGFydF9rZXJuZWwrMHgzOTQvMHg1NTQgd2l0aCBjcm5nX2luaXQ9MApbICAgIDAu
MDAwMDAwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJy
YXR1bSAxNDE4MDQwClsgICAgMC4wMDAwMDBdIEFDUEkgR1REVDogZm91bmQgMSBtZW1vcnktbWFw
cGVkIHRpbWVyIGJsb2NrKHMpLgpbICAgIDAuMDAwMDAwXSBhcmNoX3RpbWVyOiBjcDE1IGFuZCBt
bWlvIHRpbWVyKHMpIHJ1bm5pbmcgYXQgMjUuMDBNSHogKHBoeXMvcGh5cykuClsgICAgMC4wMDAw
MDBdIGNsb2Nrc291cmNlOiBhcmNoX3N5c19jb3VudGVyOiBtYXNrOiAweGZmZmZmZmZmZmZmZmZm
IG1heF9jeWNsZXM6IDB4NWM0MDkzOWI1LCBtYXhfaWRsZV9uczogNDQwNzk1MjAyNjQ2IG5zClsg
ICAgMC4wMDAwMDFdIHNjaGVkX2Nsb2NrOiA1NiBiaXRzIGF0IDI1TUh6LCByZXNvbHV0aW9uIDQw
bnMsIHdyYXBzIGV2ZXJ5IDQzOTgwNDY1MTExMDBucwpbICAgIDAuMDAwMDUzXSBDb25zb2xlOiBj
b2xvdXIgZHVtbXkgZGV2aWNlIDgweDI1ClsgICAgMC4wMDAwNzNdIEFDUEk6IENvcmUgcmV2aXNp
b24gMjAyMDA5MjUKWyAgICAwLjAwMDQ4NV0gQ2FsaWJyYXRpbmcgZGVsYXkgbG9vcCAoc2tpcHBl
ZCksIHZhbHVlIGNhbGN1bGF0ZWQgdXNpbmcgdGltZXIgZnJlcXVlbmN5Li4gNTAuMDAgQm9nb01J
UFMgKGxwaj0xMDAwMDApClsgICAgMC4wMDA0OTBdIHBpZF9tYXg6IGRlZmF1bHQ6IDMyNzY4IG1p
bmltdW06IDMwMQpbICAgIDAuMDAwNTE4XSBMU006IFNlY3VyaXR5IEZyYW1ld29yayBpbml0aWFs
aXppbmcKWyAgICAwLjAwMDY0Nl0gTW91bnQtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUz
NiAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAgIDAuMDAwNzMwXSBNb3VudHBv
aW50LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA3LCA1MjQyODggYnl0
ZXMsIGxpbmVhcikKWyAgICAwLjAwMTU4NV0gcmN1OiBIaWVyYXJjaGljYWwgU1JDVSBpbXBsZW1l
bnRhdGlvbi4KWyAgICAwLjAwMTcxNF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwNDAwMDAg
ZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxOF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAw
NjAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyMV0gUGxhdGZvcm0gTVNJOiBJVFNAMHgx
MDAxMDAwODAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyNF0gUGxhdGZvcm0gTVNJOiBJ
VFNAMHgxMDAxMDAwYTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyN10gUGxhdGZvcm0g
TVNJOiBJVFNAMHgxMDAxMDAwYzAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTczMF0gUGxh
dGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcz
M10gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMDAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAw
LjAwMTczN10gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMjAwMDAgZG9tYWluIGNyZWF0ZWQK
WyAgICAwLjAwMTc0NF0gUENJL01TSTogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVk
ClsgICAgMC4wMDE3NDddIFBDSS9NU0k6IElUU0AweDEwMDEwMDA2MDAwMCBkb21haW4gY3JlYXRl
ZApbICAgIDAuMDAxNzUwXSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9tYWluIGNyZWF0
ZWQKWyAgICAwLjAwMTc1Ml0gUENJL01TSTogSVRTQDB4MTAwMTAwMGEwMDAwIGRvbWFpbiBjcmVh
dGVkClsgICAgMC4wMDE3NTVdIFBDSS9NU0k6IElUU0AweDEwMDEwMDBjMDAwMCBkb21haW4gY3Jl
YXRlZApbICAgIDAuMDAxNzU5XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNy
ZWF0ZWQKWyAgICAwLjAwMTc2Ml0gUENJL01TSTogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBj
cmVhdGVkClsgICAgMC4wMDE3NjVdIFBDSS9NU0k6IElUU0AweDEwMDEwMDEyMDAwMCBkb21haW4g
Y3JlYXRlZApbICAgIDAuMDAxNzcyXSBSZW1hcHBpbmcgYW5kIGVuYWJsaW5nIEVGSSBzZXJ2aWNl
cy4KWyAgICAwLjAwMzYwOV0gc21wOiBCcmluZ2luZyB1cCBzZWNvbmRhcnkgQ1BVcyAuLi4KWyAg
ICAwLjAwMzkwM10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEKWyAgICAwLjAwMzkzMl0g
R0lDdjM6IENQVTE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTgwMDAwIHJlZ2lvbiAwOjB4MDAwMDEw
MDEwMDc0MDAwMApbICAgIDAuMDAzOTU2XSBHSUN2MzogQ1BVMTogdXNpbmcgYWxsb2NhdGVkIExQ
SSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzYjAwMDAKWyAgICAwLjAwNDAwMV0gYXJjaF90
aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApb
ICAgIDAuMDA0MDE1XSBDUFUxOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxODAw
MDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDQzMDNdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBD
UFUyClsgICAgMC4wMDQzMzFdIEdJQ3YzOiBDUFUyOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDE2MDAw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA2YzAwMDAKWyAgICAwLjAwNDM1NF0gR0lDdjM6IENQVTI6
IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2MwMDAwClsg
ICAgMC4wMDQ0MDJdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwNDQxNF0gQ1BVMjogQm9vdGVkIHNlY29uZGFyeSBw
cm9jZXNzb3IgMHgwMDAwMTYwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA0NzA3XSBEZXRlY3Rl
ZCBQSVBUIEktY2FjaGUgb24gQ1BVMwpbICAgIDAuMDA0NzM2XSBHSUN2MzogQ1BVMzogZm91bmQg
cmVkaXN0cmlidXRvciAxZTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOGMwMDAwClsgICAgMC4w
MDQ3NjBdIEdJQ3YzOiBDUFUzOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4
MDAwMDA4MDAwMDNkMDAwMApbICAgIDAuMDA0ODA4XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2Nh
bCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDQ4MjJdIENQVTM6
IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDFlMDAwMCBbMHg0MTNmZDBjMV0KWyAg
ICAwLjAwNTA5NV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTQKWyAgICAwLjAwNTExNF0g
R0lDdjM6IENQVTQ6IGZvdW5kIHJlZGlzdHJpYnV0b3IgODAwMDAgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwMzQwMDAwClsgICAgMC4wMDUxMzldIEdJQ3YzOiBDUFU0OiB1c2luZyBhbGxvY2F0ZWQgTFBJ
IHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNlMDAwMApbICAgIDAuMDA1MTg4XSBhcmNoX3Rp
bWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsg
ICAgMC4wMDUxOTldIENQVTQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDA4MDAw
MCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNTQ5OV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQ
VTUKWyAgICAwLjAwNTUyN10gR0lDdjM6IENQVTU6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjAwMDAw
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDk0MDAwMApbICAgIDAuMDA1NTUyXSBHSUN2MzogQ1BVNTog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzZjAwMDAKWyAg
ICAwLjAwNTU5OV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA1NjE2XSBDUFU1OiBCb290ZWQgc2Vjb25kYXJ5IHBy
b2Nlc3NvciAweDAwMDAyMDAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDU4OTVdIERldGVjdGVk
IFBJUFQgSS1jYWNoZSBvbiBDUFU2ClsgICAgMC4wMDU5MTddIEdJQ3YzOiBDUFU2OiBmb3VuZCBy
ZWRpc3RyaWJ1dG9yIGUwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDRjMDAwMApbICAgIDAuMDA1
OTQyXSBHSUN2MzogQ1BVNjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAw
MDAwODAwMDA4MDAwMDAKWyAgICAwLjAwNTk5M10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwg
d29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA2MDA2XSBDUFU2OiBC
b290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwZTAwMDAgWzB4NDEzZmQwYzFdClsgICAg
MC4wMDYyOThdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFU3ClsgICAgMC4wMDYzMzBdIEdJ
Q3YzOiBDUFU3OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDI2MDAwMCByZWdpb24gMDoweDAwMDAxMDAx
MDBhYzAwMDAKWyAgICAwLjAwNjM1NV0gR0lDdjM6IENQVTc6IHVzaW5nIGFsbG9jYXRlZCBMUEkg
cGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODEwMDAwClsgICAgMC4wMDY0MDVdIGFyY2hfdGlt
ZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAg
ICAwLjAwNjQyMl0gQ1BVNzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjYwMDAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDA2Njk1XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
OApbICAgIDAuMDA2NzE5XSBHSUN2MzogQ1BVODogZm91bmQgcmVkaXN0cmlidXRvciAxMTAwMDAg
cmVnaW9uIDA6MHgwMDAwMTAwMTAwNTgwMDAwClsgICAgMC4wMDY3NDVdIEdJQ3YzOiBDUFU4OiB1
c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDgyMDAwMApbICAg
IDAuMDA2NzkzXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0g
ZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDY4MDZdIENQVTg6IEJvb3RlZCBzZWNvbmRhcnkgcHJv
Y2Vzc29yIDB4MDAwMDExMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNzA5NV0gRGV0ZWN0ZWQg
UElQVCBJLWNhY2hlIG9uIENQVTkKWyAgICAwLjAwNzEyMV0gR0lDdjM6IENQVTk6IGZvdW5kIHJl
ZGlzdHJpYnV0b3IgMTkwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDc4MDAwMApbICAgIDAuMDA3
MTQ3XSBHSUN2MzogQ1BVOTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAw
MDAwODAwMDA4MzAwMDAKWyAgICAwLjAwNzE5NV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwg
d29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA3MjExXSBDUFU5OiBC
b290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxOTAwMDAgWzB4NDEzZmQwYzFdClsgICAg
MC4wMDc0OTNdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxMApbICAgIDAuMDA3NTE5XSBH
SUN2MzogQ1BVMTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTcwMDAwIHJlZ2lvbiAwOjB4MDAwMDEw
MDEwMDcwMDAwMApbICAgIDAuMDA3NTQ1XSBHSUN2MzogQ1BVMTA6IHVzaW5nIGFsbG9jYXRlZCBM
UEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODQwMDAwClsgICAgMC4wMDc1OTNdIGFyY2hf
dGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAK
WyAgICAwLjAwNzYxMF0gQ1BVMTA6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDE3
MDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNzg5NF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9u
IENQVTExClsgICAgMC4wMDc5MjNdIEdJQ3YzOiBDUFUxMTogZm91bmQgcmVkaXN0cmlidXRvciAx
ZjAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOTAwMDAwClsgICAgMC4wMDc5NDldIEdJQ3YzOiBD
UFUxMTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4NTAw
MDAKWyAgICAwLjAwNzk5Nl0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBm
b3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA4MDE0XSBDUFUxMTogQm9vdGVkIHNlY29u
ZGFyeSBwcm9jZXNzb3IgMHgwMDAwMWYwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA4Mzc1XSBE
ZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTIKWyAgICAwLjAwODM5NV0gR0lDdjM6IENQVTEy
OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDkwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDM4MDAwMApb
ICAgIDAuMDA4NDIyXSBHSUN2MzogQ1BVMTI6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0
YWJsZSBAMHgwMDAwMDgwMDAwODYwMDAwClsgICAgMC4wMDg0NzBdIGFyY2hfdGltZXI6IEVuYWJs
aW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwODQ4
OF0gQ1BVMTI6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDA5MDAwMCBbMHg0MTNm
ZDBjMV0KWyAgICAwLjAwODc5NF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEzClsgICAg
MC4wMDg4MjNdIEdJQ3YzOiBDUFUxMzogZm91bmQgcmVkaXN0cmlidXRvciAyMTAwMDAgcmVnaW9u
IDA6MHgwMDAwMTAwMTAwOTgwMDAwClsgICAgMC4wMDg4NTBdIEdJQ3YzOiBDUFUxMzogdXNpbmcg
YWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4NzAwMDAKWyAgICAwLjAw
ODg5NV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0
dW0gMTQxODA0MApbICAgIDAuMDA4OTEzXSBDUFUxMzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNz
b3IgMHgwMDAwMjEwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA5MjEwXSBEZXRlY3RlZCBQSVBU
IEktY2FjaGUgb24gQ1BVMTQKWyAgICAwLjAwOTIzM10gR0lDdjM6IENQVTE0OiBmb3VuZCByZWRp
c3RyaWJ1dG9yIGYwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDUwMDAwMApbICAgIDAuMDA5MjYx
XSBHSUN2MzogQ1BVMTQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAw
MDgwMDAwODgwMDAwClsgICAgMC4wMDkzMDldIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdv
cmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwOTMyOV0gQ1BVMTQ6IEJv
b3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDBmMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAw
LjAwOTc3OF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE1ClsgICAgMC4wMDk4MTFdIEdJ
Q3YzOiBDUFUxNTogZm91bmQgcmVkaXN0cmlidXRvciAyNzAwMDAgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwYjAwMDAwClsgICAgMC4wMDk4MzldIEdJQ3YzOiBDUFUxNTogdXNpbmcgYWxsb2NhdGVkIExQ
SSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4OTAwMDAKWyAgICAwLjAwOTg4OV0gYXJjaF90
aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApb
ICAgIDAuMDA5OTA4XSBDUFUxNTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjcw
MDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDEwMTk4XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24g
Q1BVMTYKWyAgICAwLjAxMDIyMV0gR0lDdjM6IENQVTE2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEw
MDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA1NjAwMDAKWyAgICAwLjAxMDI0OF0gR0lDdjM6IENQ
VTE2OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhhMDAw
MApbICAgIDAuMDEwMjk3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZv
ciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTAzMTZdIENQVTE2OiBCb290ZWQgc2Vjb25k
YXJ5IHByb2Nlc3NvciAweDAwMDAxMDAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTA1OTldIERl
dGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxNwpbICAgIDAuMDEwNjI2XSBHSUN2MzogQ1BVMTc6
IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTgwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDc2MDAwMApb
ICAgIDAuMDEwNjU0XSBHSUN2MzogQ1BVMTc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0
YWJsZSBAMHgwMDAwMDgwMDAwOGIwMDAwClsgICAgMC4wMTA3MDBdIGFyY2hfdGltZXI6IEVuYWJs
aW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxMDcy
MF0gQ1BVMTc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDE4MDEwMCBbMHg0MTNm
ZDBjMV0KWyAgICAwLjAxMTAwOV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE4ClsgICAg
MC4wMTEwMzVdIEdJQ3YzOiBDUFUxODogZm91bmQgcmVkaXN0cmlidXRvciAxNjAxMDAgcmVnaW9u
IDA6MHgwMDAwMTAwMTAwNmUwMDAwClsgICAgMC4wMTEwNjNdIEdJQ3YzOiBDUFUxODogdXNpbmcg
YWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4YzAwMDAKWyAgICAwLjAx
MTExMV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0
dW0gMTQxODA0MApbICAgIDAuMDExMTMxXSBDUFUxODogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNz
b3IgMHgwMDAwMTYwMTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDExNTg0XSBEZXRlY3RlZCBQSVBU
IEktY2FjaGUgb24gQ1BVMTkKWyAgICAwLjAxMTYxNF0gR0lDdjM6IENQVTE5OiBmb3VuZCByZWRp
c3RyaWJ1dG9yIDFlMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA4ZTAwMDAKWyAgICAwLjAxMTY0
M10gR0lDdjM6IENQVTE5OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAw
MDA4MDAwMDhkMDAwMApbICAgIDAuMDExNjkwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3
b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTE3MTBdIENQVTE5OiBC
b290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxZTAxMDAgWzB4NDEzZmQwYzFdClsgICAg
MC4wMTIwMDVdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMApbICAgIDAuMDEyMDI1XSBH
SUN2MzogQ1BVMjA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgODAxMDAgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwMzYwMDAwClsgICAgMC4wMTIwNTNdIEdJQ3YzOiBDUFUyMDogdXNpbmcgYWxsb2NhdGVkIExQ
SSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4ZTAwMDAKWyAgICAwLjAxMjEwMV0gYXJjaF90
aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApb
ICAgIDAuMDEyMTIxXSBDUFUyMDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDgw
MTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDEyNDA2XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24g
Q1BVMjEKWyAgICAwLjAxMjQzNl0gR0lDdjM6IENQVTIxOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDIw
MDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA5NjAwMDAKWyAgICAwLjAxMjQ2OF0gR0lDdjM6IENQ
VTIxOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhmMDAw
MApbICAgIDAuMDEyNTE1XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZv
ciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTI1MzZdIENQVTIxOiBCb290ZWQgc2Vjb25k
YXJ5IHByb2Nlc3NvciAweDAwMDAyMDAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTI5NzVdIERl
dGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMgpbICAgIDAuMDEyOTk5XSBHSUN2MzogQ1BVMjI6
IGZvdW5kIHJlZGlzdHJpYnV0b3IgZTAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNGUwMDAwClsg
ICAgMC4wMTMwMzBdIEdJQ3YzOiBDUFUyMjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRh
YmxlIEAweDAwMDAwODAwMDA5MDAwMDAKWyAgICAwLjAxMzA4MF0gYXJjaF90aW1lcjogRW5hYmxp
bmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDEzMTAw
XSBDUFUyMjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMGUwMTAwIFsweDQxM2Zk
MGMxXQpbICAgIDAuMDEzNDEzXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjMKWyAgICAw
LjAxMzQ0NV0gR0lDdjM6IENQVTIzOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDI2MDEwMCByZWdpb24g
MDoweDAwMDAxMDAxMDBhZTAwMDAKWyAgICAwLjAxMzQ3NV0gR0lDdjM6IENQVTIzOiB1c2luZyBh
bGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDkxMDAwMApbICAgIDAuMDEz
NTIzXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1
bSAxNDE4MDQwClsgICAgMC4wMTM1NDNdIENQVTIzOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3Nv
ciAweDAwMDAyNjAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTM5NzVdIERldGVjdGVkIFBJUFQg
SS1jYWNoZSBvbiBDUFUyNApbICAgIDAuMDEzOTk5XSBHSUN2MzogQ1BVMjQ6IGZvdW5kIHJlZGlz
dHJpYnV0b3IgMTEwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDVhMDAwMApbICAgIDAuMDE0MDI5
XSBHSUN2MzogQ1BVMjQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAw
MDgwMDAwOTIwMDAwClsgICAgMC4wMTQwNzZdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdv
cmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNDA5OF0gQ1BVMjQ6IEJv
b3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDExMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAw
LjAxNDM5Ml0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI1ClsgICAgMC4wMTQ0MTldIEdJ
Q3YzOiBDUFUyNTogZm91bmQgcmVkaXN0cmlidXRvciAxOTAxMDAgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwN2EwMDAwClsgICAgMC4wMTQ0NDldIEdJQ3YzOiBDUFUyNTogdXNpbmcgYWxsb2NhdGVkIExQ
SSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA5MzAwMDAKWyAgICAwLjAxNDQ5N10gYXJjaF90
aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApb
ICAgIDAuMDE0NTE4XSBDUFUyNTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMTkw
MTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDE0OTY0XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24g
Q1BVMjYKWyAgICAwLjAxNDk5MV0gR0lDdjM6IENQVTI2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDE3
MDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA3MjAwMDAKWyAgICAwLjAxNTAyMl0gR0lDdjM6IENQ
VTI2OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk0MDAw
MApbICAgIDAuMDE1MDcxXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZv
ciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTUwOTNdIENQVTI2OiBCb290ZWQgc2Vjb25k
YXJ5IHByb2Nlc3NvciAweDAwMDAxNzAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTUzODldIERl
dGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyNwpbICAgIDAuMDE1NDIwXSBHSUN2MzogQ1BVMjc6
IGZvdW5kIHJlZGlzdHJpYnV0b3IgMWYwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDkyMDAwMApb
ICAgIDAuMDE1NDUwXSBHSUN2MzogQ1BVMjc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0
YWJsZSBAMHgwMDAwMDgwMDAwOTUwMDAwClsgICAgMC4wMTU0OTZdIGFyY2hfdGltZXI6IEVuYWJs
aW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNTUx
OF0gQ1BVMjc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDFmMDEwMCBbMHg0MTNm
ZDBjMV0KWyAgICAwLjAxNTgwN10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI4ClsgICAg
MC4wMTU4MjddIEdJQ3YzOiBDUFUyODogZm91bmQgcmVkaXN0cmlidXRvciA5MDEwMCByZWdpb24g
MDoweDAwMDAxMDAxMDAzYTAwMDAKWyAgICAwLjAxNTg1OV0gR0lDdjM6IENQVTI4OiB1c2luZyBh
bGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk2MDAwMApbICAgIDAuMDE1
OTA3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1
bSAxNDE4MDQwClsgICAgMC4wMTU5MjldIENQVTI4OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3Nv
ciAweDAwMDAwOTAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTYzODddIERldGVjdGVkIFBJUFQg
SS1jYWNoZSBvbiBDUFUyOQpbICAgIDAuMDE2NDE4XSBHSUN2MzogQ1BVMjk6IGZvdW5kIHJlZGlz
dHJpYnV0b3IgMjEwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDlhMDAwMApbICAgIDAuMDE2NDQ5
XSBHSUN2MzogQ1BVMjk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAw
MDgwMDAwOTcwMDAwClsgICAgMC4wMTY0OTZdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdv
cmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNjUxOF0gQ1BVMjk6IEJv
b3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDIxMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAw
LjAxNjk3Ml0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTMwClsgICAgMC4wMTY5OTZdIEdJ
Q3YzOiBDUFUzMDogZm91bmQgcmVkaXN0cmlidXRvciBmMDEwMCByZWdpb24gMDoweDAwMDAxMDAx
MDA1MjAwMDAKWyAgICAwLjAxNzAyOF0gR0lDdjM6IENQVTMwOiB1c2luZyBhbGxvY2F0ZWQgTFBJ
IHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk4MDAwMApbICAgIDAuMDE3MDc3XSBhcmNoX3Rp
bWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsg
ICAgMC4wMTcxMDBdIENQVTMwOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwZjAx
MDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTc0MDRdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBD
UFUzMQpbICAgIDAuMDE3NDM3XSBHSUN2MzogQ1BVMzE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjcw
MTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMGIyMDAwMApbICAgIDAuMDE3NDY5XSBHSUN2MzogQ1BV
MzE6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTkwMDAw
ClsgICAgMC4wMTc1MTZdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9y
IEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNzUzOF0gQ1BVMzE6IEJvb3RlZCBzZWNvbmRh
cnkgcHJvY2Vzc29yIDB4MDAwMDI3MDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAxNzYyMV0gc21w
OiBCcm91Z2h0IHVwIDEgbm9kZSwgMzIgQ1BVcwpbICAgIDAuMDE3NzE0XSBTTVA6IFRvdGFsIG9m
IDMyIHByb2Nlc3NvcnMgYWN0aXZhdGVkLgpbICAgIDAuMDE3NzE3XSBDUFUgZmVhdHVyZXM6IGRl
dGVjdGVkOiBQcml2aWxlZ2VkIEFjY2VzcyBOZXZlcgpbICAgIDAuMDE3NzE5XSBDUFUgZmVhdHVy
ZXM6IGRldGVjdGVkOiBMU0UgYXRvbWljIGluc3RydWN0aW9ucwpbICAgIDAuMDE3NzIxXSBDUFUg
ZmVhdHVyZXM6IGRldGVjdGVkOiBVc2VyIEFjY2VzcyBPdmVycmlkZQpbICAgIDAuMDE3NzIzXSBD
UFUgZmVhdHVyZXM6IGRldGVjdGVkOiAzMi1iaXQgRUwwIFN1cHBvcnQKWyAgICAwLjAxNzcyNV0g
Q1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQ29tbW9uIG5vdCBQcml2YXRlIHRyYW5zbGF0aW9ucwpb
ICAgIDAuMDE3NzI3XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBSQVMgRXh0ZW5zaW9uIFN1cHBv
cnQKWyAgICAwLjAxNzcyOV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogRGF0YSBjYWNoZSBjbGVh
biB0byB0aGUgUG9VIG5vdCByZXF1aXJlZCBmb3IgSS9EIGNvaGVyZW5jZQpbICAgIDAuMDE3NzMx
XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBDUkMzMiBpbnN0cnVjdGlvbnMKWyAgICAwLjAxNzcz
Ml0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3VsYXRpdmUgU3RvcmUgQnlwYXNzaW5nIFNh
ZmUgKFNTQlMpClsgICAgMC4wNDk3NzJdIENQVTogQWxsIENQVShzKSBzdGFydGVkIGF0IEVMMgpb
ICAgIDAuMDUwNTY1XSBkZXZ0bXBmczogaW5pdGlhbGl6ZWQKWyAgICAwLjA1MDgzNl0gY2xvY2tz
b3VyY2U6IGppZmZpZXM6IG1hc2s6IDB4ZmZmZmZmZmYgbWF4X2N5Y2xlczogMHhmZmZmZmZmZiwg
bWF4X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnMKWyAgICAwLjA1MDg0Ml0gZnV0ZXggaGFz
aCB0YWJsZSBlbnRyaWVzOiA4MTkyIChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIpClsg
ICAgMC4wNTEwNzNdIFNNQklPUyAzLjMuMCBwcmVzZW50LgpbICAgIDAuMDUxMDc5XSBETUk6IEFE
TElOSyBDT00tSFBDLUFMVC9DT00tSFBDLUFMVCwgQklPUyBUaWFub0NvcmUgRURLSUkgMTEvMjMv
MjAyMQpbICAgIDAuMDUxMzA3XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDE2Clsg
ICAgMC4wNTE4MjVdIERNQTogcHJlYWxsb2NhdGVkIDQwOTYgS2lCIEdGUF9LRVJORUwgcG9vbCBm
b3IgYXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wNTE5OTNdIERNQTogcHJlYWxsb2NhdGVkIDQw
OTYgS2lCIEdGUF9LRVJORUx8R0ZQX0RNQSBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMKWyAg
ICAwLjA1MjE2NV0gRE1BOiBwcmVhbGxvY2F0ZWQgNDA5NiBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1B
MzIgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wNTIyNjJdIHRoZXJtYWxfc3lz
OiBSZWdpc3RlcmVkIHRoZXJtYWwgZ292ZXJub3IgJ3N0ZXBfd2lzZScKWyAgICAwLjA1MjM0M10g
Y3B1aWRsZTogdXNpbmcgZ292ZXJub3IgbWVudQpbICAgIDAuMDUyNDg1XSBEZXRlY3RlZCAxNSBQ
Q0MgU3Vic3BhY2VzClsgICAgMC4wNTI1MDZdIFJlZ2lzdGVyaW5nIFBDQyBkcml2ZXIgYXMgTWFp
bGJveCBjb250cm9sbGVyClsgICAgMC4wNTI1NDNdIGh3LWJyZWFrcG9pbnQ6IGZvdW5kIDYgYnJl
YWtwb2ludCBhbmQgNCB3YXRjaHBvaW50IHJlZ2lzdGVycy4KWyAgICAwLjA1Mjg1MF0gQVNJRCBh
bGxvY2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVzClsgICAgMC4wNTI4NTddIEFD
UEk6IGJ1cyB0eXBlIFBDSSByZWdpc3RlcmVkClsgICAgMC4wNTI4NTldIFNlcmlhbDogQU1CQSBQ
TDAxMSBVQVJUIGRyaXZlcgpbICAgIDAuMDU1MDE2XSBIdWdlVExCIHJlZ2lzdGVyZWQgMS4wMCBH
aUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAgICAwLjA1NTAxOV0gSHVnZVRM
QiByZWdpc3RlcmVkIDMyLjAgTWlCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzClsg
ICAgMC4wNTUwMjFdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAyLjAwIE1pQiBwYWdlIHNpemUsIHByZS1h
bGxvY2F0ZWQgMCBwYWdlcwpbICAgIDAuMDU1MDIzXSBIdWdlVExCIHJlZ2lzdGVyZWQgNjQuMCBL
aUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAgICAwLjA1NTczNV0gY3J5cHRk
OiBtYXhfY3B1X3FsZW4gc2V0IHRvIDEwMDAKWyAgICAwLjEyNDA1N10gcmFpZDY6IG5lb254OCAg
IGdlbigpICA3NzMyIE1CL3MKWyAgICAwLjE5MjA4Nl0gcmFpZDY6IG5lb254OCAgIHhvcigpICA2
MDYwIE1CL3MKWyAgICAwLjI2MDExN10gcmFpZDY6IG5lb254NCAgIGdlbigpICA3NjMzIE1CL3MK
WyAgICAwLjMyODE0OF0gcmFpZDY6IG5lb254NCAgIHhvcigpICA2MzI3IE1CL3MKWyAgICAwLjM5
NjE3OV0gcmFpZDY6IG5lb254MiAgIGdlbigpICA3Mzc5IE1CL3MKWyAgICAwLjQ2NDIxMF0gcmFp
ZDY6IG5lb254MiAgIHhvcigpICA1NzUyIE1CL3MKWyAgICAwLjUzMjI0M10gcmFpZDY6IG5lb254
MSAgIGdlbigpICA1OTkwIE1CL3MKWyAgICAwLjYwMDI3M10gcmFpZDY6IG5lb254MSAgIHhvcigp
ICA0OTM2IE1CL3MKWyAgICAwLjY2ODMwNV0gcmFpZDY6IGludDY0eDggIGdlbigpICAzNjAyIE1C
L3MKWyAgICAwLjczNjMzM10gcmFpZDY6IGludDY0eDggIHhvcigpICAyMDE5IE1CL3MKWyAgICAw
LjgwNDM2MV0gcmFpZDY6IGludDY0eDQgIGdlbigpICA0MTMyIE1CL3MKWyAgICAwLjg3MjQ0M10g
cmFpZDY6IGludDY0eDQgIHhvcigpICAyMTkxIE1CL3MKWyAgICAwLjk0MDQyMF0gcmFpZDY6IGlu
dDY0eDIgIGdlbigpICAzNTAzIE1CL3MKWyAgICAxLjAwODQ0OF0gcmFpZDY6IGludDY0eDIgIHhv
cigpICAxODg5IE1CL3MKWyAgICAxLjA3NjQ3NF0gcmFpZDY6IGludDY0eDEgIGdlbigpICAyODc1
IE1CL3MKWyAgICAxLjE0NDUwNV0gcmFpZDY6IGludDY0eDEgIHhvcigpICAxNTA4IE1CL3MKWyAg
ICAxLjE0NDUwN10gcmFpZDY6IHVzaW5nIGFsZ29yaXRobSBuZW9ueDggZ2VuKCkgNzczMiBNQi9z
ClsgICAgMS4xNDQ1MDldIHJhaWQ2OiAuLi4uIHhvcigpIDYwNjAgTUIvcywgcm13IGVuYWJsZWQK
WyAgICAxLjE0NDUxMV0gcmFpZDY6IHVzaW5nIG5lb24gcmVjb3ZlcnkgYWxnb3JpdGhtClsgICAg
MS4xNDQ1ODZdIEFDUEk6IEFkZGVkIF9PU0koTW9kdWxlIERldmljZSkKWyAgICAxLjE0NDU4OF0g
QUNQSTogQWRkZWQgX09TSShQcm9jZXNzb3IgRGV2aWNlKQpbICAgIDEuMTQ0NTkwXSBBQ1BJOiBB
ZGRlZCBfT1NJKDMuMCBfU0NQIEV4dGVuc2lvbnMpClsgICAgMS4xNDQ1OTNdIEFDUEk6IEFkZGVk
IF9PU0koUHJvY2Vzc29yIEFnZ3JlZ2F0b3IgRGV2aWNlKQpbICAgIDEuMTQ0NTk1XSBBQ1BJOiBB
ZGRlZCBfT1NJKExpbnV4LURlbGwtVmlkZW8pClsgICAgMS4xNDQ1OTddIEFDUEk6IEFkZGVkIF9P
U0koTGludXgtTGVub3ZvLU5WLUhETUktQXVkaW8pClsgICAgMS4xNDQ1OTldIEFDUEk6IEFkZGVk
IF9PU0koTGludXgtSFBJLUh5YnJpZC1HcmFwaGljcykKWyAgICAxLjE2NDg3MV0gQUNQSTogMiBB
Q1BJIEFNTCB0YWJsZXMgc3VjY2Vzc2Z1bGx5IGFjcXVpcmVkIGFuZCBsb2FkZWQKWyAgICAxLjE3
MTEzM10gQUNQSTogSW50ZXJwcmV0ZXIgZW5hYmxlZApbICAgIDEuMTcxMTM2XSBBQ1BJOiBVc2lu
ZyBHSUMgZm9yIGludGVycnVwdCByb3V0aW5nClsgICAgMS4xNzExNDldIEFDUEk6IE1DRkcgdGFi
bGUgZGV0ZWN0ZWQsIDUgZW50cmllcwpbICAgIDEuMTcxMTU0XSBBQ1BJOiBJT1JUOiBTTU1VLXYz
WzMzZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcxMTc4
XSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzM3ZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBk
b21haW4gMApbICAgIDEuMTcxMTkyXSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzNmZmZlMDAwMDAwMF0g
TWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcxMjA0XSBBQ1BJOiBJT1JUOiBT
TU1VLXYzWzJiZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEu
MTcxMjE4XSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzJmZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hp
bWl0eSBkb21haW4gMApbICAgIDEuMTcxMzA0XSBIRVNUOiBUYWJsZSBwYXJzaW5nIGhhcyBiZWVu
IGluaXRpYWxpemVkLgpbICAgIDEuMjA2MDg5XSBBUk1IMDAxMTowMDogdHR5QU1BMCBhdCBNTUlP
IDB4MTAwMDAyNjAwMDAwIChpcnEgPSA3OSwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBClsgICAg
NC4wMjA4MzVdIHByaW50azogY29uc29sZSBbdHR5QU1BMF0gZW5hYmxlZApbICAgIDQuMDI2ODk5
XSBBUk1IMDAxMTowMTogdHR5QU1BMSBhdCBNTUlPIDB4MTAwMDAyNjIwMDAwIChpcnEgPSA4MCwg
YmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBClsgICAgNC4wMzcwMjJdIEFDUEk6IFBDSSBSb290IEJy
aWRnZSBbUENJMF0gKGRvbWFpbiAwMDBjIFtidXMgMDAtZmZdKQpbICAgIDQuMDQzMjA1XSBhY3Bp
IFBOUDBBMDg6MDA6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2Nr
UE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICA0LjA1MjMwNl0gYWNwaSBQTlAwQTA4OjAw
OiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJv
bApbICAgIDQuMDYwMTI5XSBhY3BpIFBOUDBBMDg6MDA6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21l
bSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhm
ZmZmODAwMDEwZGUwZmMwClsgICAgNC4wNzI5NDJdIGFjcGkgUE5QMEEwODowMDogRUNBTSBhcmVh
IFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6
MDAKWyAgICA0LjA4MTgxNF0gYWNwaSBQTlAwQTA4OjAwOiBFQ0FNIGF0IFttZW0gMHgzM2ZmZjAw
MDAwMDAtMHgzM2ZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQpbICAgIDQuMDg5OTc2XSBQQ0kg
aG9zdCBicmlkZ2UgdG8gYnVzIDAwMGM6MDAKWyAgICA0LjA5NDA2M10gcGNpX2J1cyAwMDBjOjAw
OiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4NDAwMDAwMDAtMHg0ZmZmZmZmZiB3aW5kb3ddClsg
ICAgNC4xMDE1MzVdIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDMw
MDAwMDAwMDAwMC0weDMzZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNC4xMDk3MDFdIHBjaV9idXMg
MDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0KWyAgICA0LjExNTIxMl0gcGNp
IDAwMGM6MDA6MDAuMDogWzFkZWY6ZTEwMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMApbICAgIDQu
MTIxMjg4XSBwY2kgMDAwYzowMDowMS4wOiBbMWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYw
NDAwClsgICAgNC4xMjczMzVdIHBjaSAwMDBjOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyClsgICAg
NC4xMzE1OTZdIHBjaSAwMDBjOjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNo
b3QKWyAgICA0LjEzODQ1M10gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4
MTAwMC0weDBmZmZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDEwMDAKWyAgICA0LjE0NjYyMV0gcGNp
IDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2
NGJpdCBwcmVmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMApb
ICAgIDQuMTU4MDg2XSBwY2kgMDAwYzowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEw
MDAwMC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEw
MDAwMApbICAgIDQuMTY4NTk5XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21l
bSAweDQwMDAwMDAwLTB4NDAxZmZmZmZdClsgICAgNC4xNzUzNzddIHBjaSAwMDBjOjAwOjAxLjA6
IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0
IHByZWZdClsgICAgNC4xODM4MDNdIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBm
b3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjE5MDA1OV0gcGNpIDAwMGM6MDA6MDEuMDogQkFS
IDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjE5NjY2M10gcGNp
IDAwMGM6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAg
IDQuMjAyOTE5XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8g
IHNpemUgMHgxMDAwXQpbICAgIDQuMjA5NTIzXSBwY2kgMDAwYzowMDowMS4wOiBQQ0kgYnJpZGdl
IHRvIFtidXMgMDFdClsgICAgNC4yMTQ0NzhdIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0KWyAgICA0LjIyMTI1Nl0gcGNpIDAwMGM6
MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZm
ZmYgNjRiaXQgcHJlZl0KWyAgICA0LjIyOTY4NV0gcGNpX2J1cyAwMDBjOjAwOiByZXNvdXJjZSA0
IFttZW0gMHg0MDAwMDAwMC0weDRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjIzNjU0OV0gcGNpX2J1
cyAwMDBjOjAwOiByZXNvdXJjZSA1IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzM2ZmZGZmZmZmZmYg
d2luZG93XQpbICAgIDQuMjQ0MTA3XSBwY2lfYnVzIDAwMGM6MDE6IHJlc291cmNlIDEgW21lbSAw
eDQwMDAwMDAwLTB4NDAxZmZmZmZdClsgICAgNC4yNTAzNjRdIHBjaV9idXMgMDAwYzowMTogcmVz
b3VyY2UgMiBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdClsg
ICAgNC4yNTgzMTFdIEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJMV0gKGRvbWFpbiAwMDBkIFti
dXMgMDAtZmZdKQpbICAgIDQuMjY0NDg5XSBhY3BpIFBOUDBBMDg6MDE6IF9PU0M6IE9TIHN1cHBv
cnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10K
WyAgICA0LjI3MzU4OF0gYWNwaSBQTlAwQTA4OjAxOiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJs
ZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbApbICAgIDQuMjgxNDA5XSBhY3BpIFBOUDBB
MDg6MDE6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZm
ZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwClsgICAgNC4yOTQx
OTldIGFjcGkgUE5QMEEwODowMTogRUNBTSBhcmVhIFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2Zm
ZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDAKWyAgICA0LjMwMzA3MV0gYWNwaSBQTlAw
QTA4OjAxOiBFQ0FNIGF0IFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZmZmZmZmZdIGZvciBb
YnVzIDAwLWZmXQpbICAgIDQuMzExMjI0XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGQ6MDAK
WyAgICA0LjMxNTMxMV0gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4
NTAwMDAwMDAtMHg1ZmZmZmZmZiB3aW5kb3ddClsgICAgNC4zMjI3ODJdIHBjaV9idXMgMDAwZDow
MDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDM0MDAwMDAwMDAwMC0weDM3ZmZkZmZmZmZmZiB3
aW5kb3ddClsgICAgNC4zMzA5NDhdIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2Ug
W2J1cyAwMC1mZl0KWyAgICA0LjMzNjQ1NV0gcGNpIDAwMGQ6MDA6MDAuMDogWzFkZWY6ZTEwMF0g
dHlwZSAwMCBjbGFzcyAweDA2MDAwMApbICAgIDQuMzQyNTE3XSBwY2kgMDAwZDowMDowMS4wOiBb
MWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNC4zNDg1NDldIHBjaSAwMDBk
OjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNC4zNTI4MDldIHBjaSAwMDBkOjAwOjAxLjA6
IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA0LjM1ODYzM10gcGNpIDAwMGQ6
MDE6MDAuMDogWzEwZGU6MWU4OV0gdHlwZSAwMCBjbGFzcyAweDAzMDAwMApbICAgIDQuMzY0NjM5
XSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxMDogW21lbSAweDUwMDAwMDAwLTB4NTBmZmZmZmZd
ClsgICAgNC4zNzA5MDNdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDE0OiBbbWVtIDB4MzQwMDAw
MDAwMDAwLTB4MzQwMDBmZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC4zNzg4MTZdIHBjaSAwMDBk
OjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MzQwMDEwMDAwMDAwLTB4MzQwMDExZmZmZmZmIDY0
Yml0IHByZWZdClsgICAgNC4zODY3MjVdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDI0OiBbaW8g
IDB4NTdmZmUwMDAtMHg1N2ZmZTA3Zl0KWyAgICA0LjM5Mjk4NV0gcGNpIDAwMGQ6MDE6MDAuMDog
cmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAgNC4zOTk3MzZd
IHBjaSAwMDBkOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsg
ICAgNC40MDU4ODldIHBjaSAwMDBkOjAxOjAwLjE6IFsxMGRlOjEwZjhdIHR5cGUgMDAgY2xhc3Mg
MHgwNDAzMDAKWyAgICA0LjQxMTg5NF0gcGNpIDAwMGQ6MDE6MDAuMTogcmVnIDB4MTA6IFttZW0g
MHg1MTAwMDAwMC0weDUxMDAzZmZmXQpbICAgIDQuNDE4MjcxXSBwY2kgMDAwZDowMTowMC4yOiBb
MTBkZToxYWQ4XSB0eXBlIDAwIGNsYXNzIDB4MGMwMzMwClsgICAgNC40MjQyODFdIHBjaSAwMDBk
OjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4MzQwMDEyMDAwMDAwLTB4MzQwMDEyMDNmZmZmIDY0
Yml0IHByZWZdClsgICAgNC40MzIxOThdIHBjaSAwMDBkOjAxOjAwLjI6IHJlZyAweDFjOiBbbWVt
IDB4MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRmZmZmIDY0Yml0IHByZWZdClsgICAgNC40NDAxNTRd
IHBjaSAwMDBkOjAxOjAwLjI6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsg
ICAgNC40NDYyOTRdIHBjaSAwMDBkOjAxOjAwLjM6IFsxMGRlOjFhZDldIHR5cGUgMDAgY2xhc3Mg
MHgwYzgwMDAKWyAgICA0LjQ1MjI5OV0gcGNpIDAwMGQ6MDE6MDAuMzogcmVnIDB4MTA6IFttZW0g
MHg1MTAwNDAwMC0weDUxMDA0ZmZmXQpbICAgIDQuNDU4NjIzXSBwY2kgMDAwZDowMTowMC4zOiBQ
TUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuNDY0NzU5XSBwY2kgMDAw
ZDowMDowMS4wOiBBU1BNOiBjdXJyZW50IGNvbW1vbiBjbG9jayBjb25maWd1cmF0aW9uIGlzIGlu
Y29uc2lzdGVudCwgcmVjb25maWd1cmluZwpbICAgIDQuNDg2MDM3XSBwY2kgMDAwZDowMDowMS4w
OiBCQVIgOTogYXNzaWduZWQgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAxN2ZmZmZmZiA2NGJp
dCBwcmVmXQpbICAgIDQuNDk0NDY1XSBwY2kgMDAwZDowMDowMS4wOiBCQVIgODogYXNzaWduZWQg
W21lbSAweDUwMDAwMDAwLTB4NTE3ZmZmZmZdClsgICAgNC41MDEyNDJdIHBjaSAwMDBkOjAwOjAx
LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjUwNzQ5OF0g
cGNpIDAwMGQ6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAw
MF0KWyAgICA0LjUxNDEwM10gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFttZW0g
MHgzNDAwMDAwMDAwMDAtMHgzNDAwMGZmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjUyMjUzNl0g
cGNpIDAwMGQ6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTAwMDAwMDAtMHgz
NDAwMTFmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjUzMDk2OF0gcGNpIDAwMGQ6MDE6MDAuMDog
QkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MDAwMDAwMC0weDUwZmZmZmZmXQpbICAgIDQuNTM3NzQ4
XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDUxMDAwMDAwLTB4NTEw
N2ZmZmYgcHJlZl0KWyAgICA0LjU0NDk1OV0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDA6IGFzc2ln
bmVkIFttZW0gMHgzNDAwMTIwMDAwMDAtMHgzNDAwMTIwM2ZmZmYgNjRiaXQgcHJlZl0KWyAgICA0
LjU1MzM5Ml0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTIw
NDAwMDAtMHgzNDAwMTIwNGZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjU2MTgyNV0gcGNpIDAwMGQ6
MDE6MDAuMTogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MTA4MDAwMC0weDUxMDgzZmZmXQpbICAg
IDQuNTY4NjA1XSBwY2kgMDAwZDowMTowMC4zOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDUxMDg0
MDAwLTB4NTEwODRmZmZdClsgICAgNC41NzUzODRdIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiA1OiBu
byBzcGFjZSBmb3IgW2lvICBzaXplIDB4MDA4MF0KWyAgICA0LjU4MTY0MF0gcGNpIDAwMGQ6MDE6
MDAuMDogQkFSIDU6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0KWyAgICA0LjU4
ODI0NF0gcGNpIDAwMGQ6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQpbICAgIDQuNTkz
MTk5XSBwY2kgMDAwZDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDUwMDAwMDAwLTB4
NTE3ZmZmZmZdClsgICAgNC41OTk5NzddIHBjaSAwMDBkOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC42
MDg0MDRdIHBjaV9idXMgMDAwZDowMDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5h
c3NpZ25lZCwgdHJ5IGJvb3Rpbmcgd2l0aCBwY2k9cmVhbGxvYwpbICAgIDQuNjE3NDM4XSBwY2lf
YnVzIDAwMGQ6MDA6IHJlc291cmNlIDQgW21lbSAweDUwMDAwMDAwLTB4NWZmZmZmZmYgd2luZG93
XQpbICAgIDQuNjI0MzAxXSBwY2lfYnVzIDAwMGQ6MDA6IHJlc291cmNlIDUgW21lbSAweDM0MDAw
MDAwMDAwMC0weDM3ZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNC42MzE4NTldIHBjaV9idXMgMDAw
ZDowMTogcmVzb3VyY2UgMSBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0KWyAgICA0LjYzODEx
NV0gcGNpX2J1cyAwMDBkOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgzNDAw
MTdmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjY0NjA3NF0gQUNQSTogUENJIFJvb3QgQnJpZGdl
IFtQQ0kzXSAoZG9tYWluIDAwMDAgW2J1cyAwMC1mZl0pClsgICAgNC42NTIyNTJdIGFjcGkgUE5Q
MEEwODowMzogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBT
ZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDQuNjYxMzUyXSBhY3BpIFBOUDBBMDg6MDM6IFBD
SWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsg
ICAgNC42NjkxNzRdIGFjcGkgUE5QMEEwODowMzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4
M2ZmZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4
MDAwMTBkZTBmYzAKWyAgICA0LjY4MTk2OV0gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGFyZWEgW21l
bSAweDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApb
ICAgIDQuNjkwODQwXSBhY3BpIFBOUDBBMDg6MDM6IEVDQU0gYXQgW21lbSAweDNmZmZmMDAwMDAw
MC0weDNmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdClsgICAgNC42OTg5OTNdIFBDSSBob3N0
IGJyaWRnZSB0byBidXMgMDAwMDowMApbICAgIDQuNzAzMDgxXSBwY2lfYnVzIDAwMDA6MDA6IHJv
b3QgYnVzIHJlc291cmNlIFttZW0gMHg3MDAwMDAwMC0weDdmZmZmZmZmIHdpbmRvd10KWyAgICA0
LjcxMDU1M10gcGNpX2J1cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4M2MwMDAw
MDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjcxODcyMF0gcGNpX2J1cyAwMDAw
OjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQpbICAgIDQuNzI0MjI3XSBwY2kgMDAw
MDowMDowMC4wOiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwClsgICAgNC43MzAy
OTBdIHBjaSAwMDAwOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAK
WyAgICA0LjczNjMyM10gcGNpIDAwMDA6MDA6MDEuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA0Ljc0
MDU4Ml0gcGNpIDAwMDA6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApb
ICAgIDQuNzQ2NDAzXSBwY2kgMDAwMDowMTowMC4wOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNz
IDB4MDIwMDAwClsgICAgNC43NTI0MTFdIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDEwOiBbbWVt
IDB4M2MwMDAzMDAwMDAwLTB4M2MwMDAzZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC43NjAzMjhd
IHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODE4MDAwLTB4M2MwMDA0
ODFmZmZmIDY0Yml0IHByZWZdClsgICAgNC43NjgyNDFdIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAw
eDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuNzc1MDA0XSBwY2kg
MDAwMDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQu
NzgxMTYyXSBwY2kgMDAwMDowMTowMC4xOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIw
MDAwClsgICAgNC43ODcxNzFdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4M2Mw
MDAyMDAwMDAwLTB4M2MwMDAyZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC43OTUwODhdIHBjaSAw
MDAwOjAxOjAwLjE6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODEwMDAwLTB4M2MwMDA0ODE3ZmZm
IDY0Yml0IHByZWZdClsgICAgNC44MDMwMDJdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDMwOiBb
bWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODA5NzYwXSBwY2kgMDAwMDow
MTowMC4xOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODE1OTEx
XSBwY2kgMDAwMDowMTowMC4yOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsg
ICAgNC44MjE5MjBdIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAxMDAw
MDAwLTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC44Mjk4MzddIHBjaSAwMDAwOjAx
OjAwLjI6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODA4MDAwLTB4M2MwMDA0ODBmZmZmIDY0Yml0
IHByZWZdClsgICAgNC44Mzc3NTFdIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDMwOiBbbWVtIDB4
ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODQ0NTA4XSBwY2kgMDAwMDowMTowMC4y
OiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODUwNjU2XSBwY2kg
MDAwMDowMTowMC4zOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAgNC44
NTY2NjRdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4
M2MwMDAwZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC44NjQ1ODFdIHBjaSAwMDAwOjAxOjAwLjM6
IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODAwMDAwLTB4M2MwMDA0ODA3ZmZmIDY0Yml0IHByZWZd
ClsgICAgNC44NzI0OTVdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAw
MDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODc5MjUzXSBwY2kgMDAwMDowMTowMC4zOiBQTUUj
IHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODg1NDE1XSBwY2kgMDAwMDow
MDowMS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMS0wMl0g
YWRkX3NpemUgMTAwMApbICAgIDQuODkzODQ2XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgOTogYXNz
aWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQpbICAg
IDQuOTAyMjczXSBwY2kgMDAwMDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDcwMDAw
MDAwLTB4NzAxZmZmZmZdClsgICAgNC45MDkwNTBdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBu
byBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjkxNTMwNl0gcGNpIDAwMDA6MDA6
MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA0Ljky
MTkxMF0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgx
MDAwXQpbICAgIDQuOTI4MTY2XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFz
c2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuOTM0NzcyXSBwY2kgMDAwMDowMTowMC4wOiBC
QVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwMGZmZmZmZiA2NGJpdCBw
cmVmXQpbICAgIDQuOTQzMjA0XSBwY2kgMDAwMDowMTowMC4xOiBCQVIgMDogYXNzaWduZWQgW21l
bSAweDNjMDAwMTAwMDAwMC0weDNjMDAwMWZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTUxNjM3
XSBwY2kgMDAwMDowMTowMC4yOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMjAwMDAwMC0w
eDNjMDAwMmZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTYwMDY5XSBwY2kgMDAwMDowMTowMC4z
OiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMzAwMDAwMC0weDNjMDAwM2ZmZmZmZiA2NGJp
dCBwcmVmXQpbICAgIDQuOTY4NTAxXSBwY2kgMDAwMDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQg
W21lbSAweDcwMDAwMDAwLTB4NzAwN2ZmZmYgcHJlZl0KWyAgICA0Ljk3NTcxMl0gcGNpIDAwMDA6
MDE6MDAuMTogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg3MDA4MDAwMC0weDcwMGZmZmZmIHByZWZd
ClsgICAgNC45ODI5MjNdIHBjaSAwMDAwOjAxOjAwLjI6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4
NzAxMDAwMDAtMHg3MDE3ZmZmZiBwcmVmXQpbICAgIDQuOTkwMTM0XSBwY2kgMDAwMDowMTowMC4z
OiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMTgwMDAwLTB4NzAxZmZmZmYgcHJlZl0KWyAgICA0
Ljk5NzM0NV0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQw
MDAwMDAtMHgzYzAwMDQwMDdmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAwNTc3N10gcGNpIDAwMDA6
MDE6MDAuMTogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDgwMDAtMHgzYzAwMDQwMGZm
ZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAxNDIxMF0gcGNpIDAwMDA6MDE6MDAuMjogQkFSIDM6IGFz
c2lnbmVkIFttZW0gMHgzYzAwMDQwMTAwMDAtMHgzYzAwMDQwMTdmZmYgNjRiaXQgcHJlZl0KWyAg
ICA1LjAyMjY0M10gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAw
MDQwMTgwMDAtMHgzYzAwMDQwMWZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAzMTA3NV0gcGNpIDAw
MDA6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxLTAyXQpbICAgIDUuMDM2MjkwXSBwY2kg
MDAwMDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZmZmZd
ClsgICAgNS4wNDMwNjhdIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4
M2MwMDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS4wNTE0OTVdIHBj
aV9idXMgMDAwMDowMDogcmVzb3VyY2UgNCBbbWVtIDB4NzAwMDAwMDAtMHg3ZmZmZmZmZiB3aW5k
b3ddClsgICAgNS4wNTgzNTldIHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNSBbbWVtIDB4M2Mw
MDAwMDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA1LjA2NTkxOF0gcGNpX2J1cyAw
MDAwOjAxOiByZXNvdXJjZSAxIFttZW0gMHg3MDAwMDAwMC0weDcwMWZmZmZmXQpbICAgIDUuMDcy
MTczXSBwY2lfYnVzIDAwMDA6MDE6IHJlc291cmNlIDIgW21lbSAweDNjMDAwMDAwMDAwMC0weDNj
MDAwNDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDgwMTM1XSBBQ1BJOiBQQ0kgUm9vdCBCcmlk
Z2UgW1BDSTZdIChkb21haW4gMDAwNCBbYnVzIDAwLWZmXSkKWyAgICA1LjA4NjMxM10gYWNwaSBQ
TlAwQTA4OjA2OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9ja1BN
IFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAgNS4wOTU0MTJdIGFjcGkgUE5QMEEwODowNjog
UENJZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNvbnRyb2wK
WyAgICA1LjEwMzIzNF0gYWNwaSBQTlAwQTA4OjA2OiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0g
MHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZm
ZjgwMDAxMGRlMGZjMApbICAgIDUuMTE2MDIxXSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0gYXJlYSBb
bWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAwQzAyOjAw
ClsgICAgNS4xMjQ4OTNdIGFjcGkgUE5QMEEwODowNjogRUNBTSBhdCBbbWVtIDB4MmJmZmYwMDAw
MDAwLTB4MmJmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0KWyAgICA1LjEzMzA0OF0gUENJIGhv
c3QgYnJpZGdlIHRvIGJ1cyAwMDA0OjAwClsgICAgNS4xMzcxMzVdIHBjaV9idXMgMDAwNDowMDog
cm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpbICAg
IDUuMTQ0NjA3XSBwY2lfYnVzIDAwMDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgyODAw
MDAwMDAwMDAtMHgyYmZmZGZmZmZmZmYgd2luZG93XQpbICAgIDUuMTUyNzczXSBwY2lfYnVzIDAw
MDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdClsgICAgNS4xNTgyODBdIHBjaSAw
MDA0OjAwOjAwLjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDAKWyAgICA1LjE2
NDM0M10gcGNpIDAwMDQ6MDA6MDEuMDogWzFkZWY6ZTExMV0gdHlwZSAwMSBjbGFzcyAweDA2MDQw
MApbICAgIDUuMTcwMzc4XSBwY2kgMDAwNDowMDowMS4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDUu
MTc0NjM3XSBwY2kgMDAwNDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90
ClsgICAgNS4xODA0MjJdIHBjaSAwMDA0OjAwOjAzLjA6IFsxZGVmOmUxMTNdIHR5cGUgMDEgY2xh
c3MgMHgwNjA0MDAKWyAgICA1LjE4NjQ1NV0gcGNpIDAwMDQ6MDA6MDMuMDogc3VwcG9ydHMgRDEg
RDIKWyAgICA1LjE5MDcxNV0gcGNpIDAwMDQ6MDA6MDMuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE
MCBEMSBEM2hvdApbICAgIDUuMTk2NTAwXSBwY2kgMDAwNDowMDowNS4wOiBbMWRlZjplMTE1XSB0
eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNS4yMDI1NDJdIHBjaSAwMDA0OjAwOjA1LjA6IHN1
cHBvcnRzIEQxIEQyClsgICAgNS4yMDY4MDJdIHBjaSAwMDA0OjAwOjA1LjA6IFBNRSMgc3VwcG9y
dGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA1LjIxMjYyMF0gcGNpIDAwMDQ6MDE6MDAuMDogWzFh
MDM6MTE1MF0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUuMjE4NjY2XSBwY2kgMDAwNDow
MTowMC4wOiBlbmFibGluZyBFeHRlbmRlZCBUYWdzClsgICAgNS4yMjM2ODBdIHBjaSAwMDA0OjAx
OjAwLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS4yMjc5MzldIHBjaSAwMDA0OjAxOjAwLjA6IFBN
RSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDIgRDNob3QgRDNjb2xkClsgICAgNS4yMzQ2NDRdIHBj
aV9idXMgMDAwNDowMjogZXh0ZW5kZWQgY29uZmlnIHNwYWNlIG5vdCBhY2Nlc3NpYmxlClsgICAg
NS4yNDA3NDldIHBjaSAwMDA0OjAyOjAwLjA6IFsxYTAzOjIwMDBdIHR5cGUgMDAgY2xhc3MgMHgw
MzAwMDAKWyAgICA1LjI0Njc2M10gcGNpIDAwMDQ6MDI6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgy
MDAwMDAwMC0weDIwZmZmZmZmXQpbICAgIDUuMjUzMDI5XSBwY2kgMDAwNDowMjowMC4wOiByZWcg
MHgxNDogW21lbSAweDIxMDAwMDAwLTB4MjEwMWZmZmZdClsgICAgNS4yNTkyOTVdIHBjaSAwMDA0
OjAyOjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmYwMDAtMHgyN2ZmZjA3Zl0KWyAgICA1LjI2
NTYzNF0gcGNpIDAwMDQ6MDI6MDAuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjI2OTg5M10gcGNp
IDAwMDQ6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEMiBEM2hvdCBEM2NvbGQK
WyAgICA1LjI3NjYzNV0gcGNpIDAwMDQ6MDM6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBjbGFz
cyAweDBjMDMzMApbICAgIDUuMjgyNjUxXSBwY2kgMDAwNDowMzowMC4wOiByZWcgMHgxMDogW21l
bSAweDIxMjAwMDAwLTB4MjEyMDFmZmYgNjRiaXRdClsgICAgNS4yODk1MzJdIHBjaSAwMDA0OjAz
OjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAgNS4yOTU3NTRd
IHBjaSAwMDA0OjA0OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUgMDAgY2xhc3MgMHgwMjAwMDAKWyAg
ICA1LjMwMTc4MF0gcGNpIDAwMDQ6MDQ6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMTEwMDAwMC0w
eDIxMTdmZmZmXQpbICAgIDUuMzA4MDY3XSBwY2kgMDAwNDowNDowMC4wOiByZWcgMHgxODogW2lv
ICAweDI3ZmZlMDAwLTB4MjdmZmUwMWZdClsgICAgNS4zMTQzMzddIHBjaSAwMDA0OjA0OjAwLjA6
IHJlZyAweDFjOiBbbWVtIDB4MjExODAwMDAtMHgyMTE4M2ZmZl0KWyAgICA1LjMyMDc3MV0gcGNp
IDAwMDQ6MDQ6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAgICA1
LjMyNjk2N10gcGNpIDAwMDQ6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAt
MHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxLTAyXSBhZGRfc2l6ZSAyMDAwMDAgYWRk
X2FsaWduIDEwMDAwMApbICAgIDUuMzM4NjkzXSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2lu
ZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMApbICAgIDUu
MzQ2ODYwXSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0w
eDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxp
Z24gMTAwMDAwClsgICAgNS4zNTgzMjVdIHBjaSAwMDA0OjAwOjAzLjA6IGJyaWRnZSB3aW5kb3cg
W21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDEwMDAwMCBh
ZGRfYWxpZ24gMTAwMDAwClsgICAgNS4zNjg4MzVdIHBjaSAwMDA0OjAwOjA1LjA6IGJyaWRnZSB3
aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0g
YWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjM4MDMwMV0gcGNpIDAwMDQ6
MDA6MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1
cyAwNF0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjM5MDgxNV0gcGNp
IDAwMDQ6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZm
XQpbICAgIDUuMzk3NTkzXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAw
eDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuNDA2MDIwXSBw
Y2kgMDAwNDowMDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIxODAwMDAwLTB4MjE5ZmZm
ZmZdClsgICAgNS40MTI3OTddIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVt
IDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS40MjEyMjRd
IHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjFhMDAwMDAtMHgyMWJm
ZmZmZl0KWyAgICA1LjQyODAwMV0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDk6IGFzc2lnbmVkIFtt
ZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjQzNjQy
N10gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAw
XQpbICAgIDUuNDQyNjgzXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDQ5Mjg2XSBwY2kgMDAwNDowMDowMy4wOiBCQVIg
Nzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS40NTU1NDJdIHBjaSAwMDA0
OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAg
NS40NjIxNDVdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0KWyAgICA1LjQ2ODQwMV0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDc6IGZhaWxlZCB0
byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjQ3NTAwNl0gcGNpIDAwMDQ6MDA6MDEu
MDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDgxMjYyXSBw
Y2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAw
XQpbICAgIDUuNDg3ODY1XSBwY2kgMDAwNDowMDowNS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtp
byAgc2l6ZSAweDEwMDBdClsgICAgNS40OTQxMjFdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBm
YWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS41MDA3MjVdIHBjaSAwMDA0
OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjUw
Njk4MV0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXpl
IDB4MTAwMF0KWyAgICA1LjUxMzU4NV0gcGNpIDAwMDQ6MDE6MDAuMDogQkFSIDg6IGFzc2lnbmVk
IFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNTIwMzYyXSBwY2kgMDAwNDowMTow
MC4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS41MjY2MTdd
IHBjaSAwMDA0OjAxOjAwLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEw
MDBdClsgICAgNS41MzMyMjFdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVt
IDB4MjAwMDAwMDAtMHgyMGZmZmZmZl0KWyAgICA1LjU0MDAwMV0gcGNpIDAwMDQ6MDI6MDAuMDog
QkFSIDE6IGFzc2lnbmVkIFttZW0gMHgyMTAwMDAwMC0weDIxMDFmZmZmXQpbICAgIDUuNTQ2Nzgx
XSBwY2kgMDAwNDowMjowMC4wOiBCQVIgMjogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDAwODBd
ClsgICAgNS41NTMwMzddIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAyOiBmYWlsZWQgdG8gYXNzaWdu
IFtpbyAgc2l6ZSAweDAwODBdClsgICAgNS41NTk2NDBdIHBjaSAwMDA0OjAxOjAwLjA6IFBDSSBi
cmlkZ2UgdG8gW2J1cyAwMl0KWyAgICA1LjU2NDU5N10gcGNpIDAwMDQ6MDE6MDAuMDogICBicmlk
Z2Ugd2luZG93IFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNTcxMzgxXSBwY2kg
MDAwNDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDEtMDJdClsgICAgNS41NzY1OTZdIHBj
aSAwMDA0OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZm
Zl0KWyAgICA1LjU4MzM3M10gcGNpIDAwMDQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0g
MHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjU5MTgwMl0g
cGNpIDAwMDQ6MDM6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMTgwMDAwMC0weDIxODAx
ZmZmIDY0Yml0XQpbICAgIDUuNTk5MTA4XSBwY2kgMDAwNDowMDowMy4wOiBQQ0kgYnJpZGdlIHRv
IFtidXMgMDNdClsgICAgNS42MDQwNjNdIHBjaSAwMDA0OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MjE4MDAwMDAtMHgyMTlmZmZmZl0KWyAgICA1LjYxMDg0MV0gcGNpIDAwMDQ6MDA6
MDMuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYg
NjRiaXQgcHJlZl0KWyAgICA1LjYxOTI2OV0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDA6IGFzc2ln
bmVkIFttZW0gMHgyMWEwMDAwMC0weDIxYTdmZmZmXQpbICAgIDUuNjI2MDUxXSBwY2kgMDAwNDow
NDowMC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDIxYTgwMDAwLTB4MjFhODNmZmZdClsgICAg
NS42MzI4MzJdIHBjaSAwMDA0OjA0OjAwLjA6IEJBUiAyOiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MDAyMF0KWyAgICA1LjYzOTA4OF0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDI6IGZhaWxlZCB0
byBhc3NpZ24gW2lvICBzaXplIDB4MDAyMF0KWyAgICA1LjY0NTY5MV0gcGNpIDAwMDQ6MDA6MDUu
MDogUENJIGJyaWRnZSB0byBbYnVzIDA0XQpbICAgIDUuNjUwNjY4XSBwY2kgMDAwNDowMDowNS4w
OiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIxYTAwMDAwLTB4MjFiZmZmZmZdClsgICAgNS42NTc0
NDZdIHBjaSAwMDA0OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwNDAwMDAw
LTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNS42NjU4NzRdIHBjaV9idXMgMDAwNDow
MDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5IGJvb3Rpbmcg
d2l0aCBwY2k9cmVhbGxvYwpbICAgIDUuNjc0OTA4XSBwY2lfYnVzIDAwMDQ6MDA6IHJlc291cmNl
IDQgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpbICAgIDUuNjgxNzcyXSBwY2lf
YnVzIDAwMDQ6MDA6IHJlc291cmNlIDUgW21lbSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZmZmZm
ZiB3aW5kb3ddClsgICAgNS42ODkzMzBdIHBjaV9idXMgMDAwNDowMTogcmVzb3VyY2UgMSBbbWVt
IDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0KWyAgICA1LjY5NTU4Nl0gcGNpX2J1cyAwMDA0OjAxOiBy
ZXNvdXJjZSAyIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0K
WyAgICA1LjcwMzQ5Ml0gcGNpX2J1cyAwMDA0OjAyOiByZXNvdXJjZSAxIFttZW0gMHgyMDAwMDAw
MC0weDIxN2ZmZmZmXQpbICAgIDUuNzA5NzQ4XSBwY2lfYnVzIDAwMDQ6MDM6IHJlc291cmNlIDEg
W21lbSAweDIxODAwMDAwLTB4MjE5ZmZmZmZdClsgICAgNS43MTYwMDRdIHBjaV9idXMgMDAwNDow
MzogcmVzb3VyY2UgMiBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNS43MjM5MDldIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMSBbbWVtIDB4MjFh
MDAwMDAtMHgyMWJmZmZmZl0KWyAgICA1LjczMDE2NV0gcGNpX2J1cyAwMDA0OjA0OiByZXNvdXJj
ZSAyIFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1
LjczODExOV0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0k3XSAoZG9tYWluIDAwMDUgW2J1cyAw
MC1mZl0pClsgICAgNS43NDQyOThdIGFjcGkgUE5QMEEwODowNzogX09TQzogT1Mgc3VwcG9ydHMg
W0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAg
IDUuNzUzMzk4XSBhY3BpIFBOUDBBMDg6MDc6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsg
bm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsgICAgNS43NjEyMTldIGFjcGkgUE5QMEEwODow
NzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4MmZmZmZmZmZmZmZm
XSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzAKWyAgICA1Ljc3NDAxN10g
YWNwaSBQTlAwQTA4OjA3OiBFQ0FNIGFyZWEgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZm
ZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApbICAgIDUuNzgyODg4XSBhY3BpIFBOUDBBMDg6
MDc6IEVDQU0gYXQgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZmZmZmZl0gZm9yIFtidXMg
MDAtZmZdClsgICAgNS43OTEwNDJdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwNTowMApbICAg
IDUuNzk1MTMwXSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgzMDAw
MDAwMC0weDNmZmZmZmZmIHdpbmRvd10KWyAgICA1LjgwMjYwMV0gcGNpX2J1cyAwMDA1OjAwOiBy
b290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmZmZmRmZmZmZmZmIHdpbmRv
d10KWyAgICA1LjgxMDc2OF0gcGNpX2J1cyAwMDA1OjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVz
IDAwLWZmXQpbICAgIDUuODE2Mjc0XSBwY2kgMDAwNTowMDowMC4wOiBbMWRlZjplMTEwXSB0eXBl
IDAwIGNsYXNzIDB4MDYwMDAwClsgICAgNS44MjIzNDBdIHBjaSAwMDA1OjAwOjAxLjA6IFsxZGVm
OmUxMTFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA1LjgyODM4M10gcGNpIDAwMDU6MDA6
MDEuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjgzMjY0M10gcGNpIDAwMDU6MDA6MDEuMDogUE1F
IyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDUuODM4NDI3XSBwY2kgMDAwNTowMDow
My4wOiBbMWRlZjplMTEzXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNS44NDQ0NjJdIHBj
aSAwMDA1OjAwOjAzLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS44NDg3MjJdIHBjaSAwMDA1OjAw
OjAzLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA1Ljg1NDUwNl0gcGNp
IDAwMDU6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUu
ODYwNTQ5XSBwY2kgMDAwNTowMDowNS4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDUuODY0ODA4XSBw
Y2kgMDAwNTowMDowNS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90ClsgICAgNS44
NzA1OTJdIHBjaSAwMDA1OjAwOjA3LjA6IFsxZGVmOmUxMTddIHR5cGUgMDEgY2xhc3MgMHgwNjA0
MDAKWyAgICA1Ljg3NjYyMV0gcGNpIDAwMDU6MDA6MDcuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1
Ljg4MDg4MF0gcGNpIDAwMDU6MDA6MDcuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hv
dApbICAgIDUuODg3NzY0XSBwY2kgMDAwNTowMjowMC4wOiBbMTkxMjowMDE0XSB0eXBlIDAwIGNs
YXNzIDB4MGMwMzMwClsgICAgNS44OTM3NzldIHBjaSAwMDA1OjAyOjAwLjA6IHJlZyAweDEwOiBb
bWVtIDB4MzAxMDAwMDAtMHgzMDEwMWZmZiA2NGJpdF0KWyAgICA1LjkwMDY2MF0gcGNpIDAwMDU6
MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAgICA1LjkwNzky
NF0gcGNpIDAwMDU6MDQ6MDAuMDogWzEyNmY6MjI2M10gdHlwZSAwMCBjbGFzcyAweDAxMDgwMgpb
ICAgIDUuOTEzOTM4XSBwY2kgMDAwNTowNDowMC4wOiByZWcgMHgxMDogW21lbSAweDMwMDAwMDAw
LTB4MzAwMDNmZmYgNjRiaXRdClsgICAgNS45MjA4OTZdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRn
ZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAxMDAwClsg
ICAgNS45MjkwNjRdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAw
MDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMjAwMDAwIGFk
ZF9hbGlnbiAxMDAwMDAKWyAgICA1Ljk0MDUzMF0gcGNpIDAwMDU6MDA6MDEuMDogYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMjAw
MDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1Ljk1MTA0MF0gcGNpIDAwMDU6MDA6MDMuMDogYnJp
ZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDJdIGFkZF9zaXplIDEwMDAK
WyAgICA1Ljk1OTIwNl0gcGNpIDAwMDU6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAx
MDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAyXSBhZGRfc2l6ZSAyMDAwMDAg
YWRkX2FsaWduIDEwMDAwMApbICAgIDUuOTcwNjcxXSBwY2kgMDAwNTowMDowMy4wOiBicmlkZ2Ug
d2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBbYnVzIDAyXSBhZGRfc2l6ZSAx
MDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuOTgxMTgxXSBwY2kgMDAwNTowMDowNS4wOiBi
cmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAw
MApbICAgIDUuOTg5MzQ3XSBwY2kgMDAwNTowMDowNS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgw
MDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAw
MCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNi4wMDA4MTJdIHBjaSAwMDA1OjAwOjA1LjA6IGJyaWRn
ZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXpl
IDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNi4wMTEzMjJdIHBjaSAwMDA1OjAwOjA3LjA6
IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDA0XSBhZGRfc2l6ZSAx
MDAwClsgICAgNi4wMTk0ODhdIHBjaSAwMDA1OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAw
eDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUgMjAw
MDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjAzMDk1M10gcGNpIDAwMDU6MDA6MDcuMDogYnJp
ZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAwNF0gYWRkX3Np
emUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjA0MTQ2OF0gcGNpIDAwMDU6MDA6MDEu
MDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMC0weDMwMWZmZmZmXQpbICAgIDYuMDQ4
MjQ2XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAwMDAwMDAw
MC0weDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMDU2NjcyXSBwY2kgMDAwNTowMDow
My4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdClsgICAgNi4w
NjM0NTBdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MmMwMDAwMjAw
MDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4wNzE4NzddIHBjaSAwMDA1OjAw
OjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0KWyAgICA2
LjA3ODY1NV0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyYzAwMDA0
MDAwMDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjA4NzA4MV0gcGNpIDAwMDU6
MDA6MDcuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAwMC0weDMwN2ZmZmZmXQpbICAg
IDYuMDkzODU5XSBwY2kgMDAwNTowMDowNy4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAw
MDYwMDAwMC0weDJjMDAwMDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMTAyMjg1XSBwY2kgMDAw
NTowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4x
MDg1NDFdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6
ZSAweDEwMDBdClsgICAgNi4xMTUxNDVdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFj
ZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjEyMTQwMF0gcGNpIDAwMDU6MDA6MDMuMDog
QkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjEyODAwNF0g
cGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDYuMTM0MjU5XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTQwODYyXSBwY2kgMDAwNTowMDowNy4wOiBCQVIgNzog
bm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xNDcxMThdIHBjaSAwMDA1OjAw
OjA3LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4x
NTM3MjRdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4
MTAwMF0KWyAgICA2LjE1OTk4MF0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDc6IGZhaWxlZCB0byBh
c3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE2NjU4Ml0gcGNpIDAwMDU6MDA6MDUuMDog
QkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTcyODM4XSBwY2kg
MDAwNTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDYuMTc5NDQyXSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAg
c2l6ZSAweDEwMDBdClsgICAgNi4xODU2OThdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xOTIzMDFdIHBjaSAwMDA1OjAw
OjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE5ODU1
OF0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4
MTAwMF0KWyAgICA2LjIwNTE2MV0gcGNpIDAwMDU6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVz
IDAxXQpbICAgIDYuMjEwMTE3XSBwY2kgMDAwNTowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21l
bSAweDMwMDAwMDAwLTB4MzAxZmZmZmZdClsgICAgNi4yMTY4OTVdIHBjaSAwMDA1OjAwOjAxLjA6
ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmMwMDAwMWZmZmZmIDY0Yml0
IHByZWZdClsgICAgNi4yMjUzMjRdIHBjaSAwMDA1OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBb
bWVtIDB4MzAyMDAwMDAtMHgzMDIwMWZmZiA2NGJpdF0KWyAgICA2LjIzMjYzMF0gcGNpIDAwMDU6
MDA6MDMuMDogUENJIGJyaWRnZSB0byBbYnVzIDAyXQpbICAgIDYuMjM3NTg1XSBwY2kgMDAwNTow
MDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdClsgICAg
Ni4yNDQzNjJdIHBjaSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAw
MjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4yNTI3ODldIHBjaSAwMDA1
OjAwOjA1LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwM10KWyAgICA2LjI1Nzc0NF0gcGNpIDAwMDU6
MDA6MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDQwMDAwMC0weDMwNWZmZmZmXQpbICAg
IDYuMjY0NTIyXSBwY2kgMDAwNTowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAw
MDQwMDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMjcyOTUxXSBwY2kgMDAw
NTowNDowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDMwNjAwMDAwLTB4MzA2MDNmZmYgNjRi
aXRdClsgICAgNi4yODAyNjRdIHBjaSAwMDA1OjAwOjA3LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAw
NF0KWyAgICA2LjI4NTIxOV0gcGNpIDAwMDU6MDA6MDcuMDogICBicmlkZ2Ugd2luZG93IFttZW0g
MHgzMDYwMDAwMC0weDMwN2ZmZmZmXQpbICAgIDYuMjkxOTk3XSBwY2kgMDAwNTowMDowNy4wOiAg
IGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDYwMDAwMC0weDJjMDAwMDdmZmZmZiA2NGJpdCBw
cmVmXQpbICAgIDYuMzAwNDI0XSBwY2lfYnVzIDAwMDU6MDA6IHJlc291cmNlIDQgW21lbSAweDMw
MDAwMDAwLTB4M2ZmZmZmZmYgd2luZG93XQpbICAgIDYuMzA3Mjg4XSBwY2lfYnVzIDAwMDU6MDA6
IHJlc291cmNlIDUgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3aW5kb3ddClsg
ICAgNi4zMTQ4NDddIHBjaV9idXMgMDAwNTowMTogcmVzb3VyY2UgMSBbbWVtIDB4MzAwMDAwMDAt
MHgzMDFmZmZmZl0KWyAgICA2LjMyMTEwMl0gcGNpX2J1cyAwMDA1OjAxOiByZXNvdXJjZSAyIFtt
ZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjMyOTAw
OF0gcGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAxIFttZW0gMHgzMDIwMDAwMC0weDMwM2ZmZmZm
XQpbICAgIDYuMzM1MjY1XSBwY2lfYnVzIDAwMDU6MDI6IHJlc291cmNlIDIgW21lbSAweDJjMDAw
MDIwMDAwMC0weDJjMDAwMDNmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMzQzMTcwXSBwY2lfYnVz
IDAwMDU6MDM6IHJlc291cmNlIDEgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZmZmZdClsgICAgNi4z
NDk0MjZdIHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMiBbbWVtIDB4MmMwMDAwNDAwMDAwLTB4
MmMwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4zNTczMzFdIHBjaV9idXMgMDAwNTowNDog
cmVzb3VyY2UgMSBbbWVtIDB4MzA2MDAwMDAtMHgzMDdmZmZmZl0KWyAgICA2LjM2MzU4N10gcGNp
X2J1cyAwMDA1OjA0OiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZm
ZmYgNjRiaXQgcHJlZl0KWyAgICA2LjM3MTcwNF0gaW9tbXU6IERlZmF1bHQgZG9tYWluIHR5cGU6
IFRyYW5zbGF0ZWQgClsgICAgNi4zNzY2MTBdIHBjaSAwMDBkOjAxOjAwLjA6IHZnYWFyYjogVkdB
IGRldmljZSBhZGRlZDogZGVjb2Rlcz1pbyttZW0sb3ducz1ub25lLGxvY2tzPW5vbmUKWyAgICA2
LjM4NDk1OF0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBWR0EgZGV2aWNlIGFkZGVkOiBkZWNv
ZGVzPWlvK21lbSxvd25zPW5vbmUsbG9ja3M9bm9uZQpbICAgIDYuMzkzMzAwXSBwY2kgMDAwZDow
MTowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxlClsgICAgNi4zOTkwMzVdIHBj
aSAwMDA0OjAyOjAwLjA6IHZnYWFyYjogYnJpZGdlIGNvbnRyb2wgcG9zc2libGUKWyAgICA2LjQw
NDc3Ml0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBzZXR0aW5nIGFzIGJvb3QgZGV2aWNlIChW
R0EgbGVnYWN5IHJlc291cmNlcyBub3QgYXZhaWxhYmxlKQpbICAgIDYuNDEzNjMyXSB2Z2FhcmI6
IGxvYWRlZApbICAgIDYuNDE2NDE1XSBTQ1NJIHN1YnN5c3RlbSBpbml0aWFsaXplZApbICAgIDYu
NDIwMTU5XSBBQ1BJOiBidXMgdHlwZSBVU0IgcmVnaXN0ZXJlZApbICAgIDYuNDI0MTczXSB1c2Jj
b3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmZzClsgICAgNi40Mjk2NjFd
IHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgaHViClsgICAgNi40MzQ5
NzddIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGRldmljZSBkcml2ZXIgdXNiClsgICAgNi40NDAw
MzBdIHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAxIHJlZ2lzdGVyZWQKWyAgICA2LjQ0NDk4
NF0gcHBzX2NvcmU6IFNvZnR3YXJlIHZlci4gNS4zLjYgLSBDb3B5cmlnaHQgMjAwNS0yMDA3IFJv
ZG9sZm8gR2lvbWV0dGkgPGdpb21ldHRpQGxpbnV4Lml0PgpbICAgIDYuNDU0MTA2XSBQVFAgY2xv
Y2sgc3VwcG9ydCByZWdpc3RlcmVkClsgICAgNi40NTgxMzZdIFJlZ2lzdGVyZWQgZWZpdmFycyBv
cGVyYXRpb25zClsgICAgNi40NjI4NDVdIGNsb2Nrc291cmNlOiBTd2l0Y2hlZCB0byBjbG9ja3Nv
dXJjZSBhcmNoX3N5c19jb3VudGVyClsgICAgNi42NDQyNzldIHBucDogUG5QIEFDUEkgaW5pdApb
ICAgIDYuNjQ4Njk1XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzYmZmZjAwMDAwMDAtMHgzYmZmZmZm
ZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNjU2NjA2XSBzeXN0ZW0gMDA6
MDA6IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3Qg
YmUgcmVzZXJ2ZWQKWyAgICA2LjY2NDg2MF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MjNmZmYwMDAw
MDAwLTB4MjNmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA2LjY3Mjc2
Nl0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MjdmZmYwMDAwMDAwLTB4MjdmZmZmZmZmZmZmIHdpbmRv
d10gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA2LjY4MDY3Ml0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4
MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVk
ClsgICAgNi42ODg5MjZdIHN5c3RlbSAwMDowMDogW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZm
ZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZApbICAgIDYuNjk3MTc5XSBzeXN0
ZW0gMDA6MDA6IFttZW0gMHg3YmZmZjAwMDAwMDAtMHg3YmZmZmZmZmZmZmYgd2luZG93XSBoYXMg
YmVlbiByZXNlcnZlZApbICAgIDYuNzA1MDg2XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg3ZmZmZjAw
MDAwMDAtMHg3ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzEy
OTkyXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2M2ZmZjAwMDAwMDAtMHg2M2ZmZmZmZmZmZmYgd2lu
ZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzIwODk4XSBzeXN0ZW0gMDA6MDA6IFttZW0g
MHg2N2ZmZjAwMDAwMDAtMHg2N2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApb
ICAgIDYuNzI4ODA1XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2YmZmZjAwMDAwMDAtMHg2YmZmZmZm
ZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzM2NzExXSBzeXN0ZW0gMDA6
MDA6IFttZW0gMHg2ZmZmZjAwMDAwMDAtMHg2ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiBy
ZXNlcnZlZApbICAgIDYuNzQ0NjE3XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzM2ZmZjAwMDAwMDAt
MHgzM2ZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQKWyAgICA2Ljc1Mjg3
MF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZmIHdpbmRv
d10gY291bGQgbm90IGJlIHJlc2VydmVkClsgICAgNi43NjExMzJdIHBucDogUG5QIEFDUEk6IGZv
dW5kIDEgZGV2aWNlcwpbICAgIDYuNzY2OTQ4XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFt
aWx5IDIKWyAgICA2Ljc3MTQ4Ml0gdGNwX2xpc3Rlbl9wb3J0YWRkcl9oYXNoIGhhc2ggdGFibGUg
ZW50cmllczogMTYzODQgKG9yZGVyOiA2LCAyNjIxNDQgYnl0ZXMsIGxpbmVhcikKWyAgICA2Ljc4
MDM2M10gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUgZW50cmllczogMjYyMTQ0IChvcmRlcjog
OSwgMjA5NzE1MiBieXRlcywgbGluZWFyKQpbICAgIDYuNzg5Mzc2XSBUQ1AgYmluZCBoYXNoIHRh
YmxlIGVudHJpZXM6IDY1NTM2IChvcmRlcjogOCwgMTA0ODU3NiBieXRlcywgbGluZWFyKQpbICAg
IDYuNzk3MjU0XSBUQ1A6IEhhc2ggdGFibGVzIGNvbmZpZ3VyZWQgKGVzdGFibGlzaGVkIDI2MjE0
NCBiaW5kIDY1NTM2KQpbICAgIDYuODAzOTI1XSBVRFAgaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4
NCAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAgIDYuODExMTMyXSBVRFAtTGl0
ZSBoYXNoIHRhYmxlIGVudHJpZXM6IDE2Mzg0IChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5l
YXIpClsgICAgNi44MTg4OThdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMQpbICAg
IDYuODIzNDIwXSBSUEM6IFJlZ2lzdGVyZWQgbmFtZWQgVU5JWCBzb2NrZXQgdHJhbnNwb3J0IG1v
ZHVsZS4KWyAgICA2LjgyOTMzMV0gUlBDOiBSZWdpc3RlcmVkIHVkcCB0cmFuc3BvcnQgbW9kdWxl
LgpbICAgIDYuODM0MDI1XSBSUEM6IFJlZ2lzdGVyZWQgdGNwIHRyYW5zcG9ydCBtb2R1bGUuClsg
ICAgNi44Mzg3MTldIFJQQzogUmVnaXN0ZXJlZCB0Y3AgTkZTdjQuMSBiYWNrY2hhbm5lbCB0cmFu
c3BvcnQgbW9kdWxlLgpbICAgIDYuODQ1MTk1XSBwY2kgMDAwZDowMTowMC4xOiBEMCBwb3dlciBz
dGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDYuODUxNTk1XSBwY2kgMDAwZDowMTow
MC4yOiBEMCBwb3dlciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDYuODU3OTcz
XSBwY2kgMDAwZDowMTowMC4yOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAgICA2
Ljg2MzY3M10gcGNpIDAwMGQ6MDE6MDAuMzogRDAgcG93ZXIgc3RhdGUgZGVwZW5kcyBvbiAwMDBk
OjAxOjAwLjAKWyAgICA2Ljg3MDA3Nl0gcGNpIDAwMDQ6MDM6MDAuMDogZW5hYmxpbmcgZGV2aWNl
ICgwMDAwIC0+IDAwMDIpClsgICAgNi44NzU3NjRdIHBjaSAwMDA1OjAyOjAwLjA6IGVuYWJsaW5n
IGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAgIDYuODgxNDM1XSBQQ0k6IENMUyAxMjggYnl0ZXMs
IGRlZmF1bHQgNjQKWyAgICA2Ljg4Njc3N10gaHcgcGVyZmV2ZW50czogZW5hYmxlZCB3aXRoIGFy
bXY4X3BtdXYzXzAgUE1VIGRyaXZlciwgNyBjb3VudGVycyBhdmFpbGFibGUKWyAgICA2Ljg5NjE3
OV0gd29ya2luZ3NldDogdGltZXN0YW1wX2JpdHM9NDIgbWF4X29yZGVyPTIzIGJ1Y2tldF9vcmRl
cj0wClsgICAgNi45MDQzNjNdIE5GUzogUmVnaXN0ZXJpbmcgdGhlIGlkX3Jlc29sdmVyIGtleSB0
eXBlClsgICAgNi45MDk0MTVdIEtleSB0eXBlIGlkX3Jlc29sdmVyIHJlZ2lzdGVyZWQKWyAgICA2
LjkxMzU4OF0gS2V5IHR5cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQKWyAgICA2LjkxNzg1N10gS2V5
IHR5cGUgY2lmcy5pZG1hcCByZWdpc3RlcmVkClsgICAgNi45MzY1MjNdIHhvcjogbWVhc3VyaW5n
IHNvZnR3YXJlIGNoZWNrc3VtIHNwZWVkClsgICAgNi45NDIzMTFdICAgIDhyZWdzICAgICAgICAg
ICA6ICA5Nzk0IE1CL3NlYwpbICAgIDYuOTQ3NDk3XSAgICAzMnJlZ3MgICAgICAgICAgOiAxMTc2
MSBNQi9zZWMKWyAgICA2Ljk1MjU1OV0gICAgYXJtNjRfbmVvbiAgICAgIDogMTM5MjQgTUIvc2Vj
ClsgICAgNi45NTY5MDVdIHhvcjogdXNpbmcgZnVuY3Rpb246IGFybTY0X25lb24gKDEzOTI0IE1C
L3NlYykKWyAgICA2Ljk2MjM4OV0gQmxvY2sgbGF5ZXIgU0NTSSBnZW5lcmljIChic2cpIGRyaXZl
ciB2ZXJzaW9uIDAuNCBsb2FkZWQgKG1ham9yIDI0OSkKWyAgICA2Ljk2OTc3Nl0gaW8gc2NoZWR1
bGVyIG1xLWRlYWRsaW5lIHJlZ2lzdGVyZWQKWyAgICA2Ljk3NDI5Nl0gaW8gc2NoZWR1bGVyIGt5
YmVyIHJlZ2lzdGVyZWQKWyAgICA2Ljk3ODk5NF0gZ3Bpby1kd2FwYiBBUE1DMEQwNzowMjogbm8g
SVJRIGZvciBwb3J0MApbICAgIDYuOTg0NzU0XSBpbnB1dDogUG93ZXIgQnV0dG9uIGFzIC9kZXZp
Y2VzL0xOWFNZU1RNOjAwL0xOWFNZQlVTOjAwL1BOUDBDMEM6MDAvaW5wdXQvaW5wdXQwClsgICAg
Ni45OTMxMzddIEFDUEk6IFBvd2VyIEJ1dHRvbiBbUFdSQl0KWyAgICA2Ljk5OTkzM10gR0hFUzog
QVBFSSBmaXJtd2FyZSBmaXJzdCBtb2RlIGlzIGVuYWJsZWQgYnkgQVBFSSBiaXQuClsgICAgNy4w
MDYxNDldIEVJTko6IEVycm9yIElOSmVjdGlvbiBpcyBpbml0aWFsaXplZC4KWyAgICA3LjAxMDg4
MV0gQUNQSSBHVERUOiBmb3VuZCAxIFNCU0EgZ2VuZXJpYyBXYXRjaGRvZyhzKS4KWyAgICA3LjAx
Njc0N10gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMC5hdXRvOiBvcHRpb24gbWFzayAweDAKWyAg
ICA3LjAyMjMyNl0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMC5hdXRvOiBJRFIwLkNPSEFDQyBv
dmVycmlkZGVuIGJ5IEZXIGNvbmZpZ3VyYXRpb24gKGZhbHNlKQpbICAgIDcuMDMwOTI5XSBhcm0t
c21tdS12MyBhcm0tc21tdS12My4wLmF1dG86IGlhcyA0OC1iaXQsIG9hcyA0OC1iaXQgKGZlYXR1
cmVzIDB4MDAwMDFlY2YpClsgICAgNy4wMzkwMDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjA0NTUyNV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuMDUxNTYwXSBh
cm0tc21tdS12MyBhcm0tc21tdS12My4wLmF1dG86IGFsbG9jYXRlZCAyNjIxNDQgZW50cmllcyBm
b3IgY21kcQpbICAgIDcuMDU4NjkwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy4wNjUyMDZdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjA3MTIzNl0gYXJtLXNtbXUt
djMgYXJtLXNtbXUtdjMuMC5hdXRvOiBhbGxvY2F0ZWQgMTMxMDcyIGVudHJpZXMgZm9yIGV2dHEK
WyAgICA3LjA3ODM2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgIDcuMDg0ODc1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy4wOTE0NDJdIGFybS1zbW11LXYzIGFybS1z
bW11LXYzLjEuYXV0bzogb3B0aW9uIG1hc2sgMHgwClsgICAgNy4wOTcwMTddIGFybS1zbW11LXYz
IGFybS1zbW11LXYzLjEuYXV0bzogSURSMC5DT0hBQ0Mgb3ZlcnJpZGRlbiBieSBGVyBjb25maWd1
cmF0aW9uIChmYWxzZSkKWyAgICA3LjEwNTYxOV0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMS5h
dXRvOiBpYXMgNDgtYml0LCBvYXMgNDgtYml0IChmZWF0dXJlcyAweDAwMDAxZWNmKQpbICAgIDcu
MTEzNjk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAgNy4xMjAyMTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA3LjEyNjI0Nl0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMu
MS5hdXRvOiBhbGxvY2F0ZWQgMjYyMTQ0IGVudHJpZXMgZm9yIGNtZHEKWyAgICA3LjEzMzM3N10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgIDcuMTM5ODkzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAgNy4xNDU5MjRdIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjEuYXV0bzog
YWxsb2NhdGVkIDEzMTA3MiBlbnRyaWVzIGZvciBldnRxClsgICAgNy4xNTMwNDhdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3
LjE1OTU2M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgIDcuMTY1OTkzXSBhcm0tc21tdS12MyBhcm0tc21tdS12My4yLmF1dG86IG9wdGlvbiBt
YXNrIDB4MApbICAgIDcuMTcxNTY4XSBhcm0tc21tdS12MyBhcm0tc21tdS12My4yLmF1dG86IElE
UjAuQ09IQUNDIG92ZXJyaWRkZW4gYnkgRlcgY29uZmlndXJhdGlvbiAoZmFsc2UpClsgICAgNy4x
ODAxNjldIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjIuYXV0bzogaWFzIDQ4LWJpdCwgb2FzIDQ4
LWJpdCAoZmVhdHVyZXMgMHgwMDAwMWVjZikKWyAgICA3LjE4ODI0N10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuMTk0NzYz
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAg
Ny4yMDA4MDBdIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjIuYXV0bzogYWxsb2NhdGVkIDI2MjE0
NCBlbnRyaWVzIGZvciBjbWRxClsgICAgNy4yMDc5MzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjIxNDQ0N10gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuMjIwNDc5
XSBhcm0tc21tdS12MyBhcm0tc21tdS12My4yLmF1dG86IGFsbG9jYXRlZCAxMzEwNzIgZW50cmll
cyBmb3IgZXZ0cQpbICAgIDcuMjI3NjAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy4yMzQxMTddICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjI0MDU0NV0gYXJtLXNt
bXUtdjMgYXJtLXNtbXUtdjMuMy5hdXRvOiBvcHRpb24gbWFzayAweDAKWyAgICA3LjI0NjExOF0g
YXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMy5hdXRvOiBJRFIwLkNPSEFDQyBvdmVycmlkZGVuIGJ5
IEZXIGNvbmZpZ3VyYXRpb24gKGZhbHNlKQpbICAgIDcuMjU0NzE5XSBhcm0tc21tdS12MyBhcm0t
c21tdS12My4zLmF1dG86IGlhcyA0OC1iaXQsIG9hcyA0OC1iaXQgKGZlYXR1cmVzIDB4MDAwMDFl
Y2YpClsgICAgNy4yNjI3OTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjI2OTMxNF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuMjc1MzQ4XSBhcm0tc21tdS12MyBh
cm0tc21tdS12My4zLmF1dG86IGFsbG9jYXRlZCAyNjIxNDQgZW50cmllcyBmb3IgY21kcQpbICAg
IDcuMjgyNDc4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAgNy4yODg5OTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjI5NTAyN10gYXJtLXNtbXUtdjMgYXJtLXNtbXUt
djMuMy5hdXRvOiBhbGxvY2F0ZWQgMTMxMDcyIGVudHJpZXMgZm9yIGV2dHEKWyAgICA3LjMwMjE1
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgIDcuMzA4NjY2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAgNy4zMTUwOTBdIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjQuYXV0
bzogb3B0aW9uIG1hc2sgMHgwClsgICAgNy4zMjA2NjNdIGFybS1zbW11LXYzIGFybS1zbW11LXYz
LjQuYXV0bzogSURSMC5DT0hBQ0Mgb3ZlcnJpZGRlbiBieSBGVyBjb25maWd1cmF0aW9uIChmYWxz
ZSkKWyAgICA3LjMyOTI2M10gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuNC5hdXRvOiBpYXMgNDgt
Yml0LCBvYXMgNDgtYml0IChmZWF0dXJlcyAweDAwMDAxZWNmKQpbICAgIDcuMzM3MzQxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAgNy4zNDM4NTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA3LjM0OTg5MF0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuNC5hdXRvOiBhbGxv
Y2F0ZWQgMjYyMTQ0IGVudHJpZXMgZm9yIGNtZHEKWyAgICA3LjM1NzAyMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuMzYz
NTM2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAgNy4zNjk1NjhdIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjQuYXV0bzogYWxsb2NhdGVkIDEz
MTA3MiBlbnRyaWVzIGZvciBldnRxClsgICAgNy4zNzY2OTNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjM4MzIwOF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuMzg5
NzIzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAgNy4zOTYyNDVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA3LjQwMjAyMl0gYXN0IDAwMDQ6MDI6MDAuMDogQWRkaW5nIHRv
IGlvbW11IGdyb3VwIDAKWyAgICA3LjQwNzA3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNDEzNTg4XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy40MTk2MzddIGFz
dCAwMDA0OjAyOjAwLjA6IFtkcm1dIHBsYXRmb3JtIGhhcyBubyBJTyBzcGFjZSwgdHJ5aW5nIE1N
SU8KWyAgICA3LjQyNjQyOV0gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gVXNpbmcgUDJBIGJyaWRn
ZSBmb3IgY29uZmlndXJhdGlvbgpbICAgIDcuNDMyOTQ4XSBhc3QgMDAwNDowMjowMC4wOiBbZHJt
XSBBU1QgMjUwMCBkZXRlY3RlZApbICAgIDcuNDM3OTkzXSBhc3QgMDAwNDowMjowMC4wOiBbZHJt
XSBBbmFsb2cgVkdBIG9ubHkKWyAgICA3LjQ0Mjg2NV0gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0g
ZHJhbSBNQ0xLPTgwMCBNaHogdHlwZT04IGJ1c193aWR0aD0xNgpbICAgIDcuNDQ5NzMwXSBbVFRN
XSBab25lICBrZXJuZWw6IEF2YWlsYWJsZSBncmFwaGljcyBtZW1vcnk6IDE2MjUxMTQ2IEtpQgpb
ICAgIDcuNDU2MzM1XSBbVFRNXSBab25lICAgZG1hMzI6IEF2YWlsYWJsZSBncmFwaGljcyBtZW1v
cnk6IDIwOTcxNTIgS2lCClsgICAgNy40NjI4NTFdIFtUVE1dIEluaXRpYWxpemluZyBwb29sIGFs
bG9jYXRvcgpbICAgIDcuNDY3MjAxXSBbVFRNXSBJbml0aWFsaXppbmcgRE1BIHBvb2wgYWxsb2Nh
dG9yClsgICAgNy40NzIxODZdIFtkcm1dIEluaXRpYWxpemVkIGFzdCAwLjEuMCAyMDEyMDIyOCBm
b3IgMDAwNDowMjowMC4wIG9uIG1pbm9yIDAKWyAgICA3LjQ5NjU1OF0gQ29uc29sZTogc3dpdGNo
aW5nIHRvIGNvbG91ciBmcmFtZSBidWZmZXIgZGV2aWNlIDEyOHg0OApbICAgIDcuNTA1MDA2XSBh
c3QgMDAwNDowMjowMC4wOiBbZHJtXSBmYjA6IGFzdGRybWZiIGZyYW1lIGJ1ZmZlciBkZXZpY2UK
WyAgICA3LjUyNTU5Ml0gYnJkOiBtb2R1bGUgbG9hZGVkClsgICAgNy41MzMxNjBdIGxvb3A6IG1v
ZHVsZSBsb2FkZWQKWyAgICA3LjUzNjYwOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNTQzMTM0XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy41NDg5MTFdIG52bWUg
MDAwNTowNDowMC4wOiBBZGRpbmcgdG8gaW9tbXUgZ3JvdXAgMQpbICAgIDcuNTU0MDUxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAgNy41NjA1NjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA3LjU2NjY0OV0gbnZtZSBudm1lMDogcGNpIGZ1bmN0aW9uIDAwMDU6MDQ6MDAu
MApbICAgIDcuNTcxNTY0XSBpZ2I6IEludGVsKFIpIEdpZ2FiaXQgRXRoZXJuZXQgTmV0d29yayBE
cml2ZXIKWyAgICA3LjU3MzUxMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDcuNTc2OTU0XSBpZ2I6IENvcHlyaWdodCAoYykgMjAwNy0y
MDE0IEludGVsIENvcnBvcmF0aW9uLgpbICAgIDcuNTgyOTQ5XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjU4ODUyNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNTk0
MTYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAgNy42MDA2NzNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA3LjYwMDcxNF0gaWdiIDAwMDQ6MDQ6MDAuMDogQWRkaW5nIHRvIGlvbW11
IGdyb3VwIDIKWyAgICA3LjYwNjY2OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAgNy42MTAyMDhdIG52bWUgbnZtZTA6IG1pc3Npbmcgb3IgaW52
YWxpZCBTVUJOUU4gZmllbGQuClsgICAgNy42MTI0MTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjYxODQ2OV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDcuNjIz
MDk0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAgNy42MjgzOTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgIDcuNjI4Mzk5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAgNy42NTg4MjVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNjY1MTQxXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAgNy42NzE3ODJdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNjc4MDk5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAg
Ny42ODY4NjldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgIDcuNjkwMTYyXSBwcHMgcHBzMDogbmV3IFBQUyBzb3VyY2UgcHRwMApbICAgIDcuNjkz
MTg3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAgNy42OTY1NTNdIGlnYiAwMDA0OjA0OjAwLjA6IGFkZGVkIFBIQyBvbiBldGgwClsgICAg
Ny43MDI1MTldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgIDcuNzAzMTg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAgNy43MDcwNDBdIGlnYiAwMDA0OjA0OjAwLjA6IEludGVsKFIpIEdp
Z2FiaXQgRXRoZXJuZXQgTmV0d29yayBDb25uZWN0aW9uClsgICAgNy43MDcwNDNdIGlnYiAwMDA0
OjA0OjAwLjA6IGV0aDA6IChQQ0llOjIuNUdiL3M6V2lkdGggeDEpIDAwOjMwOjY0OjNiOjUwOjUy
ClsgICAgNy43MTI2ODldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgIDcuNzEzMzU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAgNy43MTg3NDNdIGlnYiAwMDA0OjA0OjAwLjA6IGV0aDA6
IFBCQSBObzogMDAwMzAwLTAwMApbICAgIDcuNzI1NTUwXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjczMjY3NF0gaWdiIDAwMDQ6MDQ6MDAu
MDogVXNpbmcgTVNJLVggaW50ZXJydXB0cy4gNCByeCBxdWV1ZShzKSwgNCB0eCBxdWV1ZShzKQpb
ICAgIDcuNzM4OTgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAgNy43NDQzNzhdIGlnYnZmOiBJbnRlbChSKSBHaWdhYml0IFZpcnR1YWwg
RnVuY3Rpb24gTmV0d29yayBEcml2ZXIKWyAgICA3Ljc0OTQ0NV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy43NTUwOTNdIGlnYnZmOiBDb3B5
cmlnaHQgKGMpIDIwMDkgLSAyMDEyIEludGVsIENvcnBvcmF0aW9uLgpbICAgIDcuNzYzMzE3XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAg
Ny43Njg2NTldIGk0MGU6IEludGVsKFIpIEV0aGVybmV0IENvbm5lY3Rpb24gWEw3MTAgTmV0d29y
ayBEcml2ZXIKWyAgICA3Ljc3NDkwMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAgNy43NzU1NjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgICA3Ljc4MDU0OV0gaTQwZTogQ29weXJpZ2h0
IChjKSAyMDEzIC0gMjAxOSBJbnRlbCBDb3Jwb3JhdGlvbi4KWyAgICA3Ljc4MDY1NV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
IDcuNzg2NDYwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA3Ljc4NzEzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDcuNzkyNDU2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy43OTI1MDNdIGk0MGUgMDAwMDowMTowMC4wOiBB
ZGRpbmcgdG8gaW9tbXUgZ3JvdXAgMwpbICAgIDcuNzk4NzEyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3Ljc5OTM3OF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDcuODA0MzY3XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAgNy44MTAzNTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgIDcuODE2MTc5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAgNy44MjMzNjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgICA3LjgyODU4MF0gaTQwZSAwMDAwOjAxOjAw
LjA6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAgIDcuODM0MzM3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjgzNTAxMl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDcuODUwODU0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAgNy44NTY4NDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgIDcuODU3NTA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAgNy44NjMzNTldICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuODYzMzgwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAgNy44NjkwMTBd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcu
ODY5Njc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAgNy44NzQ3NDVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgIDcuODc0NzUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAgNy44ODA3NDFdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuODgxNDE1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAgNy44ODY0NzddICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuODg2
NDgxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAgNy44OTIxMjddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgIDcuODkyNzk2XSBudm1lIG52bWUwOiBhbGxvY2F0ZWQgNjQgTWlCIGhvc3Qg
bWVtb3J5IGJ1ZmZlci4KWyAgICA3Ljg5ODEyM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy44OTgxMjhdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgICA3LjkwNjQ3OF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDcuOTA5Nzcw
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3
LjkwOTc3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgIDcuOTE1NzcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA3LjkxNTc4Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDcuOTIxNDIyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjkyNzQxN10gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy45Mjc0MzhdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgICA3Ljkz
MzA3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgIDcuOTM5MDYyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA3Ljk0NDcxMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAgNy45NTA3MTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgICA3Ljk1NjM1NV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDcuOTYyMzQ2XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3Ljk2MjM3
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDcuOTY3OTk3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA3Ljk3Mzk5Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAgNy45Nzk2NDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgICA3Ljk4NTI5NF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDcuOTkwOTM4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3Ljk5MDk0Ml0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDcuOTk2OTQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA4LjAwMjkzMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAgOC4wMDI5MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgICA4LjAwODU5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMDE0NTc4XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjAyMDIyNF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4wMjAy
MzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgICA4LjAyNjIyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDguMDI2MjI5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA4LjAzMTg3N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4wMzc1MjhdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgICA4LjA0MzUzOF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMDQ5
NTE0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA4LjA1NTE2MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAgOC4wNTUxNjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgICA4LjA2MDgxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMDY2ODA0XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjA2NjgyNl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMDcyODAx
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4
LjA3ODQ0OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAgOC4wNzg0NTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgICA4LjA4NDQ1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMDkwMDkwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjA5MDExMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMDk1NzQwXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjEw
MTczNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAgOC4xMDE3NDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgICA4LjEwNzczNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMTEzMzc4XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjExMzM5OF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMTE5Mzc0XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjExOTM3
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDguMTI1MDIzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA4LjEyNTAzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDguMTMwNjcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjEzNjY2Nl0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4xNDgxMDddIG52bWUgbnZtZTA6
IDgvMC8wIGRlZmF1bHQvcmVhZC9wb2xsIHF1ZXVlcwpbICAgIDguMTQ4MzEyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAgOC4yMTgyMThd
ICBudm1lMG4xOiBwMSBwMiBwMwpbICAgIDguMjI0MTgxXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjIyNDE4Nl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMzU0NDI4XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjM2MDA4
M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDguMzY2MDc5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA4LjM3MTczMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDguMzc3NzI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjM4MzM3OF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguMzg5MzczXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjM5NTAyNV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDguNDAxMDIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA4LjQwNjY3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDguNDEyNjY2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjQxODMxOF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNDI0MzE0XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjQyOTk2NV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDgu
NDM1OTYwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA4LjQ0MTYxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDguNDQ3NjA4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA4LjQ1MzI1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNDU5MjU0XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjQ2NDkwNV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNDcw
OTAyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA4LjQ3NjU1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgIDguNDgyNTUzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA4LjQ4ODIwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNDk0MjAwXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjQ5OTg1MV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNTA1ODQ3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4
LjUxMTQ5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgIDguNTE3NDkyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA4LjUyMzE0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNTI5MTM3XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjUzNDc4OF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNTQwNzgzXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjU0
NjQzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgIDguNTUyNDI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA4LjU1ODA3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNTY0MDcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjU2OTcyM10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNTc1NzE4XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjU4MTM2
OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDguNTg3MzY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA4LjU5MzAxNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDguNTk5MDA5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjYwNDY2MF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNjEwNjU1XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjYxNjMwNl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDguNjIyMzAxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA4LjYyNzk1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDguNjMzOTQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjYzOTU5Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNjQ1NTkwXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjY1MTI0Ml0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDgu
NjU3MjM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA4LjY2Mjg4N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDguNjY4ODgyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA4LjY3NDUzMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNjgwNTI3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjY4NjE3N10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNjky
MTcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA4LjY5NzgyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgIDguNzAzODE4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA4LjcwOTQ2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNzE1NDY0XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjcyMTExNF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNzI3MTA5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4
LjczMjc2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgIDguNzM4NzU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA4Ljc0NDQwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNzUwNDAwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljc1NjA1MF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNzYyMDQ1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljc2
NzY5N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgIDguNzczNjkyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA4Ljc3OTM0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNzg1MzM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljc5MDk4N10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguNzk2OTgyXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjgwMjYz
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDguODA4NjI3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA4LjgxNDI3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDguODIwMjcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjgyNTkyMl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguODMxOTE3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjgzNzU2N10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDguODQzNTYyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA4Ljg0OTIxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDguODU1MjA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljg2MDg2Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguODY2ODYxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljg3MjUxMV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDgu
ODc4NTA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA4Ljg4NDE1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDguODkwMTU0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljg5NTgwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguOTAxNzk5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjkwNzQ0OV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguOTEz
NDQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA4LjkxOTA5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgIDguOTI1MDkwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA4LjkzMDc0MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguOTM2NzM0XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljk0MjM4NF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguOTQ4Mzc5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4
Ljk1NDAyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgIDguOTYwMDI0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA4Ljk2NTY3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguOTcxNjczXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljk3NzMyNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDguOTgzMzE5XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljk4
ODk2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgIDguOTk0OTY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA5LjAwMDYxNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMDA2NjA5XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjAxMjI1OV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMDE4MjU0XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjAyMzkw
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDkuMDI5OTAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA5LjAzNTU1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDkuMDQxNTQ2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjA0NzE5Nl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMDUzMTkxXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjA1ODg0Ml0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDkuMDY0ODM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA5LjA3MDQ4N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDkuMDc2NDgxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjA4MjEzMl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMDg4MTI3XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjA5Mzc3N10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDku
MDk5NzcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA5LjEwNTQyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDkuMTExNDE4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA5LjExNzA2OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMTIzMDYzXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjEyODcxM10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMTM0
NzA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA5LjE0MDM1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgIDkuMTQ2MzU0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA5LjE1MjAwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMTU3OTk5XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjE2MzY0OV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMTY5NjQ0
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5
LjE3NTI5NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgIDkuMTgxMjg5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA5LjE4Njk0MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMTkyOTM1XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjE5ODU4NV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMjA0NTgwXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjIx
MDIzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgIDkuMjE2MjI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA5LjIyMTg3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMjI3ODcwXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjIzMzUyMF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMjM5NTE1XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjI0NTE2
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDkuMjUxMTYwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA5LjI1NjgwOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDkuMjYyODA0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjI2ODQ1NF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMjc0NDQ5XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjI4MDA5OV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDkuMjg2MDkzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA5LjI5MTc0NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDkuMjk3NzM4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjMwMzM4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMzA5MzgzXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjMxNTAzM10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDku
MzIxMDI5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA5LjMyNjY4MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDkuMzMyNjc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA5LjMzODMyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMzQ0MzE5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjM0OTk2OV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMzU1
OTY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA5LjM2MTYxNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgIDkuMzY3NjA4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA5LjM3MzI1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMzc5MjUzXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjM4NDkwM10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuMzkwODk5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5
LjM5NjU1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgIDkuNDAyNTQ2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA5LjQwODE5Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNDE0MTkxXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjQxOTg0Ml0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNDI1ODM2XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjQz
MTQ4Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgIDkuNDM3NDgxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA5LjQ0MzEzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNDQ5MTI1XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjQ1NDc3NV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNDYwNzcwXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjQ2NjQy
MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDkuNDcyNDE1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA5LjQ3ODA2Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDkuNDg0MDYxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjQ4OTcxMl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNDk1NzA3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjUwMTM1N10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDkuNTA3MzUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA5LjUxMzAwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDkuNTE4OTk4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjUyNDY0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNTMwNjQ0XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjUzNjI5M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDku
NTQyMjg4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA5LjU0NzkzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDkuNTUzOTM0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA5LjU1OTU4NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNTY1NTc5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjU3MTIyOV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNTc3
MjI0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA5LjU4Mjg3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgIDkuNTg4ODY5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA5LjU5NDUyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNjAwNTE0XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjYwNjE2NV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNjEyMTYw
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5
LjYxNzgxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgIDkuNjIzODA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA5LjYyOTQ1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNjM1NDQ5XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjY0MTEwNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNjQ3MDk4XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjY1
Mjc0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgIDkuNjU4NzQ0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA5LjY2NDM5NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNjcwMzg4XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjY3NjAzOV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNjgyMDMzXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjY4NzY4
M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDkuNjkzNjc4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA5LjY5OTMyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDkuNzA1MzI0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjcxMDk3M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNzE2OTY4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjcyMjYxOF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDkuNzI4NjEzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA5LjczNDI2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDkuNzQwMjU4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljc0NTkwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNzUxOTAzXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljc1NzU1M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDku
NzYzNTQ3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA5Ljc2OTE5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDkuNzc1MTkzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljc4MDg0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNzg2ODM4XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljc5MjQ4OV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuNzk4
NDgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA5LjgwNDEzNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgIDkuODEwMTI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA5LjgxNTc3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuODIxNzczXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjgyNzQyNF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuODMzNDE5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5
LjgzOTA2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgIDkuODQ1MDY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA5Ljg1MDcxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuODU2NzEwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljg2MjM1OV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuODY4MzU0XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljg3
NDAwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgIDkuODgwMDA2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA5Ljg4NTY1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuODkxNjUzXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljg5NzMwM10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuOTAzMjk5XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjkwODk1
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgIDkuOTE0OTQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA5LjkyMDU5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgIDkuOTI2NTkwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjkzMjI0MV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuOTM4MjM1XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljk0Mzg4Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
IDkuOTQ5ODgxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA5Ljk1NTUzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgIDkuOTYxNTI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljk2NzE3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDkuOTczMTcxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljk3ODgyMl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgIDku
OTg0ODE3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA5Ljk5MDQ2N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgIDkuOTk2NDYyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjAwMjExMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMDA4MTA3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjAxMzc1N10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMDE5
NzUzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEwLjAyNTQwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTAuMDMxMzk3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEwLjAzNzA0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMDQzMDQyXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjA0ODY5Ml0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMDU0Njg3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEw
LjA2MDMzN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTAuMDY2MzMzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEwLjA3MTk4N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMDc3OTgyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjA4MzYzMl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMDg5NjI3XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjA5
NTI3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTAuMTAxMjcxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEwLjEwNjkyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMTEyOTE2XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjExODU2Nl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMTI0NTYxXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjEzMDIx
MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTAuMTM2MjA2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEwLjE0MTg1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTAuMTQ3ODUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjE1MzUwMl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMTU5NDk2XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjE2NTE0N10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTAuMTcxMTQyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEwLjE3Njc5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTAuMTgyNzg4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjE4ODQzOF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMTk0NDMzXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjIwMDA4M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAu
MjA2MDc3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEwLjIxMTcyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTAuMjE3NzIyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjIyMzM3M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMjI5MzY3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjIzNTAxN10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMjQx
MDEyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEwLjI0NjY2Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTAuMjUyNjU3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEwLjI1ODMwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMjY0MzAyXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjI2OTk1Ml0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMjc1OTQ3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEw
LjI4MTU5N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTAuMjg3NTkxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEwLjI5MzI0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMjk5MjM2XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjMwNDg5MF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMzEwODg1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjMx
NjUzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTAuMzIyNTI5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEwLjMyODE3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMzM0MTc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjMzOTgyNV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMzQ1ODE5XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjM1MTQ3
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTAuMzU3NDY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEwLjM2MzExNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTAuMzY5MTA5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjM3NDc1OV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuMzgwNzU0XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjM4NjQwNV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTAuMzkyMzk5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEwLjM5ODA1MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTAuNDA0MDQ0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjQwOTY5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNDE1NjkxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjQyMTM0M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAu
NDI3MzM4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEwLjQzMjk4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTAuNDM4OTgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjQ0NDYzNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNDUwNjI4XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjQ1NjI3OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNDYy
MjczXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEwLjQ2NzkyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTAuNDczOTE4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEwLjQ3OTU2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNDg1NTYzXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjQ5MTIxNF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNDk3MjA5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEw
LjUwMjg1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTAuNTA4ODU0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEwLjUxNDUwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNTIwNTAwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjUyNjE1MF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNTMyMTQ1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjUz
Nzc5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTAuNTQzNzkwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEwLjU0OTQ0MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNTU1NDM1XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjU2MTA4Nl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNTY3MDgxXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjU3Mjcz
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTAuNTc4NzI3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEwLjU4NDM3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTAuNTkwMzcxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjU5NjAyMl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNjAyMDE3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjYwNzY2OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTAuNjEzNjYzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEwLjYxOTMxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTAuNjI1MzA4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjYzMDk1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNjM2OTUzXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjY0MjYwM10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAu
NjQ4NTk4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEwLjY1NDI0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTAuNjYwMjQyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjY2NTg5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNjcxODg3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjY3NzUzN10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNjgz
NTMxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEwLjY4OTE4Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTAuNjk1MTc3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEwLjcwMDgyNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNzA2ODIxXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjcxMjQ3Ml0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNzE4NDY3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEw
LjcyNDExN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTAuNzMwMTEyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEwLjczNTc2Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNzQxNzU4XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjc0NzQwOV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNzUzNDA0XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjc1
OTA1NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTAuNzY1MDQ5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEwLjc3MDY5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNzc2Njk0XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjc4MjM0NF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuNzg4MzM5XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjc5Mzk4
OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTAuNzk5OTgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEwLjgwNTYzNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTAuODExNjI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjgxNzI3OV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuODIzMjc0XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjgyODkyNF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTAuODM0OTE5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEwLjg0MDU2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTAuODQ2NTY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjg1MjIxNF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuODU4MjA5XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjg2Mzg1OV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAu
ODY5ODU0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEwLjg3NTUwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTAuODgxNDk5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjg4NzE0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuODkzMTQ0XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjg5ODc5NV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuOTA0
Nzk2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEwLjkxMDQ0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTAuOTE2NDQyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEwLjkyMjA5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuOTI4MDg4XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjkzMzc0MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuOTM5NzM0
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEw
Ljk0NTM4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTAuOTUxMzgwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEwLjk1NzAzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuOTYzMDI2XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjk2ODY3Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuOTc0NjcxXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjk4
MDMyNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTAuOTg2MzIxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEwLjk5MTk3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTAuOTk3OTY2XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjAwMzYxN10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMDA5NjEyXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjAxNTI2
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTEuMDIxMjU3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDExLjAyNjkwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTEuMDMyOTAyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjAzODU1Ml0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMDQ0NTQ3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjA1MDE5N10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTEuMDU2MTkxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDExLjA2MTg0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTEuMDY3ODM2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjA3MzQ4Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMDc5NDgwXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjA4NTEzMV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEu
MDkxMTI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDExLjA5Njc3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTEuMTAyNzcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDExLjEwODQyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMTE0NDE3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjEyMDA2N10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMTI2
MDYyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDExLjEzMTcxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTEuMTM3NzEwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDExLjE0MzM2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMTQ5MzU4XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjE1NTAwOV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMTYxMDA0
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEx
LjE2NjY1NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTEuMTcyNjQ5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDExLjE3ODI5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMTg0Mjk0XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjE4OTk0NV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMTk1OTM5XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjIw
MTU5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTEuMjA3NTg0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDExLjIxMzIzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMjE5MjMwXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjIyNDg4MF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMjMwODc1XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjIzNjUy
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTEuMjQyNTIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDExLjI0ODE3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTEuMjU0MTY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjI1OTgxNl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMjY1ODExXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjI3MTQ2MV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTEuMjc3NDU1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDExLjI4MzEwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTEuMjg5MTAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjI5NDc1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMzAwNzQ1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjMwNjM5Nl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEu
MzEyMzkwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDExLjMxODA0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTEuMzI0MDM1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDExLjMyOTY4Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMzM1NjgwXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjM0MTMzMF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMzQ3
MzI1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDExLjM1Mjk3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTEuMzU4OTcxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDExLjM2NDYyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMzcwNjE2XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjM3NjI2N10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuMzgyMjYy
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEx
LjM4NzkxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTEuMzkzOTA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDExLjM5OTU1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNDA1NTUyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjQxMTIwMl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNDE3MTk3XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjQy
Mjg0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTEuNDI4ODQyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDExLjQzNDQ5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNDQwNDg5XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjQ0NjE0MF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNDUyMTM1XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjQ1Nzc4
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTEuNDYzNzgwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDExLjQ2OTQzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTEuNDc1NDI1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjQ4MTA3Nl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNDg3MDcxXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjQ5MjcyMV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTEuNDk4NzE1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDExLjUwNDM2Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTEuNTEwMzYwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjUxNjAxMV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNTIyMDA1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjUyNzY1Nl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEu
NTMzNjUxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDExLjUzOTMwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTEuNTQ1Mjk1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDExLjU1MDk0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNTU2OTQxXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjU2MjU5Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNTY4
NTg4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDExLjU3NDIzOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTEuNTgwMjMzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDExLjU4NTg4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNTkxODc4XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjU5NzUyOF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNjAzNTIz
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEx
LjYwOTE3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTEuNjE1MTY5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDExLjYyMDgxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNjI2ODEzXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjYzMjQ2NF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNjM4NDU5XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjY0
NDExMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTEuNjUwMTA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDExLjY1NTc1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNjYxNzUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjY2NzQwMl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNjczMzk3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjY3OTA0
N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTEuNjg1MDQyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDExLjY5MDY5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTEuNjk2Njg3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjcwMjMzN10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNzA4MzMyXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjcxMzk4Ml0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTEuNzE5OTc3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDExLjcyNTYyOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTEuNzMxNjIyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjczNzI3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNzQzMjcwXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjc0ODkyMF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEu
NzU0OTE1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDExLjc2MDU2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTEuNzY2NTU5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDExLjc3MjIxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNzc4MjA1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjc4Mzg1NV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuNzg5
ODUwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDExLjc5NTUwMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTEuODAxNDk0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDExLjgwNzE0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuODEzMTQwXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjgxODc5MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuODI0Nzg1
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEx
LjgzMDQzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTEuODM2NDI5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDExLjg0MjA3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuODQ4MDc0XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjg1MzcyNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuODU5NzE4XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjg2
NTM2OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTEuODcxMzYzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDExLjg3NzAxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuODgzMDA4XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjg4ODY1OF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuODk0NjUyXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjkwMDMw
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTEuOTA2Mjk2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDExLjkxMTk0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTEuOTE3OTQxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjkyMzU5OF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuOTI5NTkzXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjkzNTI0NF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTEuOTQxMjM5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDExLjk0Njg4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTEuOTUyODg1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjk1ODUzN10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuOTY0NTMyXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjk3MDE4Ml0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEu
OTc2MTc4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDExLjk4MTgyOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTEuOTg3ODIzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDExLjk5MzQ3M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTEuOTk5NDY3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjAwNTExN10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMDEx
MTEyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEyLjAxNjc2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTIuMDIyNzU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEyLjAyODQwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMDM0NDAwXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjA0MDA1MV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMDQ2MDQ2
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEy
LjA1MTY5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTIuMDU3NjkwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEyLjA2MzM0MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMDY5MzM0XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjA3NDk4NF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMDgwOTc5XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjA4
NjYyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTIuMDkyNjI0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEyLjA5ODI3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMTA0MjY5XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjEwOTkyMF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMTE1OTE0XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjEyMTU2
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTIuMTI3NTU5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEyLjEzMzIwOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTIuMTM5MjA0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjE0NDg1M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMTUwODQ4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjE1NjQ5OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTIuMTYyNDkzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEyLjE2ODE0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTIuMTc0MTM5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjE3OTc5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMTg1Nzg1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjE5MTQzNV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIu
MTk3NDMwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEyLjIwMzA4MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTIuMjA5MDc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjIxNDcyNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMjIwNzE5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjIyNjM2OV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMjMy
MzY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEyLjIzODAxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTIuMjQ0MDA4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEyLjI0OTY1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMjU1NjUyXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjI2MTMwMl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMjY3Mjk3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEy
LjI3Mjk0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTIuMjc4OTQyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEyLjI4NDU5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMjkwNTg3XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjI5NjIzN10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMzAyMjMyXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjMw
Nzg4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTIuMzEzODgyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEyLjMxOTUzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMzI1NTI3XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjMzMTE3OF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMzM3MTcyXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjM0Mjgy
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTIuMzQ4ODE3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEyLjM1NDQ2Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTIuMzYwNDYxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjM2NjExMV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuMzcyMTA2XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjM3Nzc1NV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTIuMzgzNzUxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEyLjM4OTQwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTIuMzk1Mzk2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjQwMTA0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNDA3MDQxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjQxMjY5MV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIu
NDE4Njg2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEyLjQyNDMzNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTIuNDMwMzMwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjQzNTk4MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNDQxOTc1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjQ0NzYyNV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNDUz
NjIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEyLjQ1OTI3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTIuNDY1MjY2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEyLjQ3MDkxOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNDc2OTEzXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjQ4MjU2NV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNDg4NTYw
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEy
LjQ5NDIxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTIuNTAwMjA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEyLjUwNTg1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNTExODUwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjUxNzUwMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNTIzNDk1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjUy
OTE0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTIuNTM1MTQwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEyLjU0MDc5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNTQ2Nzg1XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjU1MjQzNV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNTU4NDMwXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjU2NDA4
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTIuNTcwMDc1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEyLjU3NTcyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTIuNTgxNzE5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjU4NzM3MF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNTkzMzY1XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjU5OTAxNV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTIuNjA1MDEwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEyLjYxMDY1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTIuNjE2NjU0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjYyMjMwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNjI4MzEwXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjYzMzk2M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIu
NjM5OTU4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEyLjY0NTYwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTIuNjUxNjAyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjY1NzI1Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNjYzMjQ3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjY2ODg5N10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNjc0
ODkyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEyLjY4MDU0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTIuNjg2NTM4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEyLjY5MjE4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNjk4MTgyXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjcwMzgzM10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNzA5ODI3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEy
LjcxNTQ3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTIuNzIxNDcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEyLjcyNzEyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNzMzMTE3XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjczODc2N10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNzQ0NzYyXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjc1
MDQxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTIuNzU2NDA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEyLjc2MjA1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNzY4MDUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjc3MzcwMl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuNzc5Njk3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjc4NTM0
N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTIuNzkxMzQzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEyLjc5Njk5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTIuODAyOTg3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjgwODYzOF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuODE0NjMyXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjgyMDI4Ml0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTIuODI2Mjc3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEyLjgzMTkyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTIuODM3OTIyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjg0MzU3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuODQ5NTY3XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjg1NTIxN10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIu
ODYxMjEyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEyLjg2Njg2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTIuODcyODU3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjg3ODUwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuODg0NTA1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjg5MDE1Nl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuODk2
MTUxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEyLjkwMTgwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTIuOTA3Nzk1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEyLjkxMzQ0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuOTE5NDQwXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjkyNTA5MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuOTMxMDg0
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEy
LjkzNjczNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTIuOTQyNzI5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEyLjk0ODM4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuOTU0MzgwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjk2MDAzMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuOTY2MDI1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjk3
MTY3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTIuOTc3NjcwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEyLjk4MzMyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTIuOTg5MzIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjk5NDk3MF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMDAwOTY1XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjAwNjYx
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTMuMDEyNjA5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEzLjAxODI1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTMuMDI0MjUzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjAyOTkwNF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMDM1ODk4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjA0MTU0OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTMuMDQ3NTQzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEzLjA1MzE5NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTMuMDU5MTg4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjA2NDgzOF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMDcwODMzXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjA3NjQ4M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMu
MDgyNDc3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEzLjA4ODEyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTMuMDk0MTIyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjA5OTc3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMTA1NzY3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjExMTQxN10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMTE3
NDExXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEzLjEyMzA2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTMuMTI5MDU1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEzLjEzNDcwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMTQwNzAwXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjE0NjM1MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMTUyMzQ1
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEz
LjE1Nzk5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTMuMTYzOTkxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEzLjE2OTY0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMTc1NjM1XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjE4MTI4Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMTg3MjgwXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjE5
MjkzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTMuMTk4OTI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEzLjIwNDU3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMjEwNTcwXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjIxNjIyMF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMjIyMjE1XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjIyNzg2
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTMuMjMzODYwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEzLjIzOTUxMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTMuMjQ1NTA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjI1MTE1NV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMjU3MTUwXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjI2MjgwMF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTMuMjY4Nzk0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEzLjI3NDQ0NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTMuMjgwNDM5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjI4NjA4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMjkyMDg0XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjI5NzczNF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMu
MzAzNzI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEzLjMwOTM3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTMuMzE1MzcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjMyMTAyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMzI3MDE3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjMzMjY2OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMzM4
NjYzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEzLjM0NDMxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTMuMzUwMzA4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEzLjM1NTk1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMzYxOTUyXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjM2NzYwMl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMzczNTk3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEz
LjM3OTI0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTMuMzg1MjQxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEzLjM5MDg5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuMzk2ODg4XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjQwMjUzOF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNDA4NTM0XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjQx
NDE4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTMuNDIwMTc4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEzLjQyNTgyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNDMxODI0XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjQzNzQ3NF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNDQzNDY5XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjQ0OTEx
OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTMuNDU1MTE0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEzLjQ2MDc2NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTMuNDY2NzU5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjQ3MjQwOV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNDc4NDAzXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjQ4NDA1NF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTMuNDkwMDUwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEzLjQ5NTcwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTMuNTAxNjk2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjUwNzM0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNTEzMzQxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjUxODk5MV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMu
NTI0OTg2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEzLjUzMDYzNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTMuNTM2NjMxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjU0MjI4MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNTQ4Mjc1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjU1MzkyNV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNTU5
OTIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEzLjU2NTU3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTMuNTcxNTY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEzLjU3NzIxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNTgzMjA5XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjU4ODg1OV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNTk0ODU0
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEz
LjYwMDUwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTMuNjA2NTAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEzLjYxMjE1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNjE4MTQ2XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjYyMzc5Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNjI5NzkwXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjYz
NTQ0MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTMuNjQxNDM1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEzLjY0NzA4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNjUzMDgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjY1ODczNF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNjY0NzI4XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjY3MDM3
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTMuNjc2Mzc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEzLjY4MjAyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTMuNjg4MDE4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjY5MzY2OF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNjk5NjYyXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjcwNTMxMl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTMuNzExMzA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEzLjcxNjk1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTMuNzIyOTUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjcyODYwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNzM0NTk3XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjc0MDI0N10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMu
NzQ2MjQxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEzLjc1MTg5MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTMuNzU3ODg2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjc2MzUzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNzY5NTMwXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjc3NTE4MV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuNzgx
MTc1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEzLjc4NjgyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTMuNzkyODIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEzLjc5ODQ3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuODA0NDY1XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjgxMDExNV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuODE2MTEw
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEz
LjgyMTc2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTMuODI3NzU0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEzLjgzMzQwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuODM5Mzk5XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjg0NTA0OV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuODUxMDQzXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjg1
NjY5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTMuODYyNjg4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEzLjg2ODMzOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuODc0MzMyXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjg3OTk4Ml0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuODg1OTc3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjg5MTYy
N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTMuODk3NjIyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEzLjkwMzI3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMTMuOTA5MjY3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjkxNDkxN10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuOTIwOTEyXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjkyNjU2MV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MTMuOTMyNTU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEzLjkzODIwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMTMuOTQ0MjAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjk0OTg1MF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuOTU1ODQ1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjk2MTQ5NV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMu
OTY3NDk2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEzLjk3MzE0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTMuOTc5MTQxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjk4NDc5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTMuOTkwNzg2XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjk5NjQzNl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTQuMDAy
NDMyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE0LjAwODA4NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMTQuMDE0MDc5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE0LjAxOTcyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTQuMDI1NzI0XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjAzMTM3NV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTQuMDM3MzY5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0
LjA0MzAxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMTQuMDQ5MDEzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE0LjA1NDY2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTQuMDYwNjU4XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjA2NjMwOF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTQuMDcyMzAyXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjA3
Nzk1Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMTQuMDgzOTQ3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE0LjA4OTU5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMTQuMDk1NTk0XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjEwMTI0M10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMTQuMTA3MjM4XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjExMjg4
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMTQuMTE4ODgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE0LjEyNTQ4OV0gaTQwZSAwMDAwOjAxOjAwLjA6IGZ3IDYuMC40ODQ0MiBhcGkg
MS43IG52bSA2LjAxIDB4ODAwMDM0ODUgMS4xNzQ3LjAgWzgwODY6MTU4OV0gWzgwODY6MDAwMl0K
WyAgIDE0LjQxMzM3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMTQuNDE5MzY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjQyNTE0MV0gaTQwZSAwMDAwOjAxOjAwLjA6IE1BQyBh
ZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMApbICAgMTQuNDMxMDMyXSBpNDBlIDAwMDA6MDE6MDAu
MDogRlcgTExEUCBpcyBlbmFibGVkClsgICAxNC40NDE3MjJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjQ0NzcyMl0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC40NTMzODNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0
LjQ1OTM3OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNC40Njk5ODhdIGk0MGUgMDAwMDowMTowMC4wOiBQQ0ktRXhwcmVzczogU3BlZWQgOC4w
R1QvcyBXaWR0aCB4OApbICAgMTQuNDc3MjQ4XSBpNDBlIDAwMDA6MDE6MDAuMDogRmVhdHVyZXM6
IFBGLWlkWzBdIFZTSXM6IDM0IFFQOiAzMiBSU1MgRkRfQVRSIEZEX1NCIE5UVVBMRSBWeExBTiBH
ZW5ldmUgUFRQIFZFUEEKWyAgIDE0LjQ4NzQwMF0gaTQwZSAwMDAwOjAxOjAwLjE6IEFkZGluZyB0
byBpb21tdSBncm91cCA0ClsgICAxNC40OTI1NDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0LjQ5OTA2Ml0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuNTA1MDI2XSBp
NDBlIDAwMDA6MDE6MDAuMTogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAxNC41
MjMyNzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE0LjUyOTI2N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNC41MzQ5MzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjU0MDkyN10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC41NDY1NzddICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjU1MjU3Ml0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC41NTgy
MjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE0LjU2NDIxN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNC41Njk4NjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjU3NTg2NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC41ODE1MTVdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjU4NzUxMF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC41OTMxNjBd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE0LjU5OTE1NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNC42MDQ4MDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE0LjYxMDgwMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC42MTY0NTFdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjYyMjQ0NV0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC42MjgwOTZdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0
LjYzNDA5MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNC42Mzk3NDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE0LjY0NTczOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNC42NTEzODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjY1NzM4M10gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC42NjMwMzNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjY2
OTAyN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNC42NzQ2NzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE0LjY4MDY3M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNC42ODYzMjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjY5MjMxOV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC42OTc5NjldICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjcwMzk2
NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
NC43MDk2MTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE0LjcxNTYwOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNC43MjEyNTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjcyNzI1NF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC43MzI5MDRdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjczODg5OV0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC43
NDQ1NDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE0Ljc1MDU0NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNC43NTYxOTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljc2MjE5MV0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC43Njc4NDFdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljc3MzgzNl0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC43Nzk0
ODZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE0Ljc4NTQ4MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNC43OTExMzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljc5NzEyN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC44MDI3NzddICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjgwODc3MV0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC44MTQ0MjFd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE0LjgyMDQxNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNC44MjYwNjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE0LjgzMjA2MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC44Mzc3MTBdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljg0MzcwNl0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC44NDkzNTZdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0
Ljg1NTM1MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNC44NjEwMDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE0Ljg2Njk5NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNC44NzI2NDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljg3ODYzOV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC44ODQyODldICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljg5
MDI4NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNC44OTU5MzRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE0LjkwMTkyOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNC45MDc1NzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjkxMzU3NF0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC45MTkyMjNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0LjkyNTIx
OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
NC45MzA4NjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE0LjkzNjg2M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNC45NDI1MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljk0ODUxMF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC45NTQxNjBdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljk2MDE1NF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC45
NjU4MDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE0Ljk3MTc5OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNC45Nzc0NDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljk4MzQ0M10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC45ODkwOTNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE0Ljk5NTA4OF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4wMDA3
MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE1LjAwNjczM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNS4wMTIzODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjAxODM3OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4wMjQwMjldICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjAzMDAyNF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4wMzU2NzRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE1LjA0MTY2OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNS4wNDczMTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE1LjA1MzMxNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4wNTg5NjRdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjA2NDk1OF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4wNzA2MDldICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1
LjA3NjYwNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNS4wODIyNTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE1LjA4ODI0OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4wOTM4OTldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjA5OTg5M10gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4xMDU1NDVdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjEx
MTUzOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNS4xMTcxOTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE1LjEyMzE4N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNS4xMjg4MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjEzNDgzM10gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4xNDA0ODVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjE0NjQ4
MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
NS4xNTIxMzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE1LjE1ODEyNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNS4xNjM3NzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjE2OTc3MF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4xNzU0MTldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjE4MTQxNF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4x
ODcwNjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE1LjE5MzA1OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNS4xOTg3MDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjIwNDcwM10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4yMTAzNTNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjIxNjM0OF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4yMjE5
OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE1LjIyNzk5M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNS4yMzM2NDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjIzOTYzN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4yNDUyODddICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjI1MTI4Ml0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4yNTY5MzNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE1LjI2MjkyOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNS4yNjg1NzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE1LjI3NDU3Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4yODAyMjJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjI4NjIxN10gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4yOTE4NjddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1
LjI5Nzg2MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNS4zMDM1MTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE1LjMwOTUwN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4zMTUxNThdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjMyMTE1Ml0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4zMjY4MDNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjMz
Mjc5N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNS4zMzg0NDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE1LjM0NDQ0M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNS4zNTAwOTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjM1NjA4OF0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4zNjE3MzhdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjM2Nzcz
Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
NS4zNzMzODJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE1LjM3OTM3N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNS4zODUwMjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjM5MTAyMV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4zOTY2NzFdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjQwMjY2Nl0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS40
MDgzMTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE1LjQxNDMxMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNS40MTk5NjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjQyNTk1NV0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS40MzE2MDVdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjQzNzYwMF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS40NDMy
NTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE1LjQ0OTI0NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNS40NTQ4OTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjQ2MDg5MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS40NjY1MzldICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjQ3MjUzNF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS40NzgxODRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE1LjQ4NDE3OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNS40ODk4MjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE1LjQ5NTgyM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS41MDE0NzNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjUwNzQ2OF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS41MTMxMThdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1
LjUxOTExM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNS41MjQ3NjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE1LjUzMDc1N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNS41MzY0MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjU0MjQxMV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS41NDgwNjFdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjU1
NDA1NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNS41NTk3MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE1LjU2NTcwMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNS41NzEzNTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjU3NzM0NV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS41ODI5OTVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjU4ODk5
MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
NS41OTQ2MzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE1LjYwMDYzNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNS42MDYyODRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjYxMjI3OV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS42MTc5MjldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjYyMzkyNF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS42
Mjk1NzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE1LjYzNTU2OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNS42NDEyMThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjY0NzIxM10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS42NTI4NjNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjY1ODg1OF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS42NjQ1
MDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE1LjY3MDUwNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNS42NzYxNTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjY4MjE0OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS42ODc3OTldICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjY5Mzc5NF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS42OTk0NDNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE1LjcwNTQzOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNS43MTEwODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE1LjcxNzA4M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS43MjI3MzJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjcyODcyN10gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS43MzQzNzhdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1
Ljc0MDM3Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNS43NDYwMjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE1Ljc1MjAxN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNS43NTc2NjZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljc2MzY2MV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS43NjkzMTFdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljc3
NTMwNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNS43ODA5NTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE1Ljc4Njk1MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNS43OTI2MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljc5ODU5OV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS44MDQyNTBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjgxMDI0
NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
NS44MTU4OTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE1LjgyMTg5MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNS44Mjc1NDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjgzMzUzNV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS44MzkxODVdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljg0NTE4MF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS44
NTA4MzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE1Ljg1NjgyNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNS44NjI0NzRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljg2ODQ3MF0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS44NzQxMjFdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljg4MDExNl0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS44ODU3
NjZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE1Ljg5MTc2MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNS44OTc0MTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjkwMzQwNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS45MDkwNTZdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1LjkxNTA1MF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS45MjA3MDBd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE1LjkyNjY5NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNS45MzIzNDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE1LjkzODMzOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS45NDM5ODldICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljk0OTk4NF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS45NTU2MzNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1
Ljk2MTYyOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNS45NjcyNzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE1Ljk3MzI3M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNS45Nzg5MjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljk4NDkyMV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS45OTA1NzFdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE1Ljk5
NjU2Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNi4wMDIyMTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE2LjAwODIxMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNi4wMTM4NjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjAxOTg1NV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4wMjU1MDVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjAzMTUw
MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ni4wMzcxNTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE2LjA0MzE0NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNi4wNDg3OTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjA1NDc5Ml0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4wNjA0NDJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjA2NjQzN10g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4w
NzIwODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE2LjA3ODA4M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNi4wODM3MzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjA4OTcyN10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4wOTUzNzddICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjEwMTM3Ml0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4xMDcw
MjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE2LjExMzAxN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNi4xMTg2NjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjEyNDY2Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4xMzAzMTJdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjEzNjMwNl0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4xNDE5NTZd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE2LjE0Nzk1MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNi4xNTM2MDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE2LjE1OTU5Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4xNjUyNDZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjE3MTI0MV0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4xNzY4OTFdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2
LjE4Mjg4NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNi4xODg1MzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE2LjE5NDUzMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4yMDAxODBdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjIwNjE3NV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4yMTE4MjZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjIx
NzgyMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNi4yMjM0NzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE2LjIyOTQ2Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNi4yMzUxMTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjI0MTExMV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4yNDY3NjFdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjI1Mjc1
Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ni4yNTg0MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE2LjI2NDQwMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNi4yNzAwNTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjI3NjA0NV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4yODE2OTVdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjI4NzY4OV0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4y
OTMzMzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE2LjI5OTMzNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNi4zMDQ5ODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjMxMDk3OF0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4zMTY2MjhdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjMyMjYyM10gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4zMjgy
NzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE2LjMzNDI2N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNi4zMzk5MTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjM0NTkxMl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4zNTE1NjJdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjM1NzU1Nl0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4zNjMyMDdd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE2LjM2OTIwMl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNi4zNzQ4NTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE2LjM4MDg0Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4zODY0OTZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjM5MjQ5MV0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4zOTgxNDFdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2
LjQwNDEzNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNi40MDk3ODZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE2LjQxNTc4MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNi40MjE0MzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjQyNzQyNV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi40MzMwNzZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjQz
OTA3MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNi40NDQ3MjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE2LjQ1MDcxNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNi40NTYzNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjQ2MjM2NF0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi40NjgwMTRdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjQ3NDAw
OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ni40Nzk2NTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE2LjQ4NTY1NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNi40OTEzMDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjQ5NzI5OV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi41MDI5NDldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjUwODk0M10g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi41
MTQ1OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE2LjUyMDU4OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNi41MjYyMzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjUzMjIzM10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi41Mzc4ODNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjU0Mzg3OF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi41NDk1
MjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE2LjU1NTUyOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNi41NjExODJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjU2NzE3N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi41NzI4MjddICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjU3ODgyMl0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi41ODQ0NzJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE2LjU5MDQ2N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNi41OTYxMTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE2LjYwMjExMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi42MDc3NjFdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjYxMzc1Nl0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi42MTk0MDddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2
LjYyNTQwMl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNi42MzEwNTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE2LjYzNzA0N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNi42NDI2OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjY0ODY5Ml0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi42NTQzNDJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjY2
MDMzNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNi42NjU5ODZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE2LjY3MTk4MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNi42Nzc2MzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjY4MzYyNl0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi42ODkyNzZdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjY5NTI3
MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ni43MDA5MjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE2LjcwNjkxNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNi43MTI1NjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjcxODU2MF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi43MjQyMTBdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjczMDIwNV0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi43
MzU4NTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE2Ljc0MTg1MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNi43NDc0OTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2Ljc1MzQ5NF0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi43NTkxNDRdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2Ljc2NTEzOV0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi43NzA3
ODldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE2Ljc3Njc4NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNi43ODI0MzRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE2Ljc4ODQyOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi43OTQwNzhdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjgwMDA3M10gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi44MDU3MjRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE2LjgxMTcxOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNi44MTczNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE2LjgyMzM2M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi44MjkwMTNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjgzNTAwOF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi44NDA2NTddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2
Ljg0NjY1Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNi44NTIzMDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE2Ljg1ODI5N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNi44NjM5NDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2Ljg2OTk0MV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi44NzU1OTFdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2Ljg4
MTU4Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNi44ODcyMzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE2Ljg5MzIzMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNi44OTg4ODFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjkwNDg3Nl0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi45MTA1MjVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjkxNjUy
MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ni45MjIxNzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE2LjkyODE2NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNi45MzM4MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2LjkzOTgxMF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi45NDU0NjBdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2Ljk1MTQ1NF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi45
NTcxMDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE2Ljk2MzA5OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNi45Njg3NDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2Ljk3NDc0NF0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi45ODAzOTRdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE2Ljk4NjM4OF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi45OTIw
MzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE2Ljk5ODAzNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNy4wMDM2ODRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjAwOTY4MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4wMTUzMzBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjAyMTMyNF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4wMjY5NzRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE3LjAzMjk2OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNy4wMzg2MThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE3LjA0NDYxM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4wNTAyNjNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjA1NjI1OF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4wNjE5MDddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3
LjA2NzkwMl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNy4wNzM1NTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE3LjA3OTU0OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4wODUxOTldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjA5MTE5NV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4wOTY4NDVdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjEw
MjgzOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNy4xMDg0OTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE3LjExNDQ4NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNy4xMjAxMzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjEyNjEzMF0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4xMzE3ODNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjEzNzc3
OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ny4xNDM0MjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE3LjE0OTQyM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNy4xNTUwNzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjE2MTA2OF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4xNjY3MThdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjE3MjcxM10g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4x
NzgzNjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE3LjE4NDM1OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNy4xOTAwMDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjE5NjAwM10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4yMDE2NTNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjIwNzY0OF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4yMTMy
OTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE3LjIxOTI5NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNy4yMjQ5NDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjIzMDkzOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4yMzY1ODldICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjI0MjU4NF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4yNDgyMzRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE3LjI1NDIyOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNy4yNTk4NzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE3LjI2NTg3NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4yNzE1MjRdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjI3NzUxOF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4yODMxNjhdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3
LjI4OTE2M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNy4yOTQ4MTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE3LjMwMDgwOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4zMDY0NThdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjMxMjQ1M10gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4zMTgxMDNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjMy
NDA5OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNy4zMjk3NDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE3LjMzNTc0Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNy4zNDEzOTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjM0NzM4N10gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4zNTMwMzddICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjM1OTAz
Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ny4zNjQ2ODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE3LjM3MDY3N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNy4zNzYzMjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjM4MjMyMl0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4zODc5NzJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjM5Mzk2N10g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4z
OTk2MTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE3LjQwNTYxMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNy40MTEyNjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjQxNzI1NV0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy40MjI5MDVdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjQyODkwMF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy40MzQ1
NTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE3LjQ0MDU0NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNy40NDYxOTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjQ1MjE4OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy40NTc4MzhdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjQ2MzgzNF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy40Njk0ODNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE3LjQ3NTQ3OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNy40ODExMjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE3LjQ4NzEyM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy40OTI3NzJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjQ5ODc2N10gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy41MDQ0MThdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3
LjUxMDQxM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNy41MTYwNjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE3LjUyMjA2MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNy41Mjc3MTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjUzMzcwN10gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy41MzkzNTddICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjU0
NTM1Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNy41NTEwMDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE3LjU1Njk5N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNy41NjI2NDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjU2ODY0MV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy41NzQyOTJdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjU4MDI5
Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ny41ODU5NDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE3LjU5MTk0MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNy41OTc1OTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjYwMzU4NV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy42MDkyMzVdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjYxNTIyOV0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy42
MjA4NzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE3LjYyNjg3NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNy42MzI1MjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjYzODUxOF0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy42NDQxNjldICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjY1MDE2NF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy42NTU4
MTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE3LjY2MTgwOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNy42Njc0NThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjY3MzQ1M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy42NzkxMDNdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjY4NTA5OF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy42OTA3NDdd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE3LjY5Njc0M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNy43MDIzOTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE3LjcwODM4OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy43MTQwMzhdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjcyMDAzM10gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy43MjU2ODJdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3
LjczMTY3OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNy43MzczMjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE3Ljc0MzMyM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNy43NDg5NzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljc1NDk2OF0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy43NjA2MThdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljc2
NjYxMl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNy43NzIyNjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE3Ljc3ODI1OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNy43ODM5MTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljc4OTkwNl0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy43OTU1NTVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjgwMTU1
MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ny44MDcyMDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE3LjgxMzE5NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNy44MTg4NDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjgyNDgzOV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy44MzA0ODhdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjgzNjQ4NF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy44
NDIxMzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE3Ljg0ODEyOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNy44NTM3NzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljg1OTc3M10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy44NjU0MjNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljg3MTQxOF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy44Nzcw
NjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE3Ljg4MzA2M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNy44ODg3MTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljg5NDcwN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy45MDAzNTddICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3LjkwNjM1Ml0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy45MTIwMDJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE3LjkxNzk5N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNy45MjM2NDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE3LjkyOTY0Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy45MzUyOTNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljk0MTI4N10gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy45NDY5MzddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3
Ljk1MjkzMl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNy45NTg1ODJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE3Ljk2NDU3Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNy45NzAyMjZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljk3NjIyMV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy45ODE4NzFdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE3Ljk4
Nzg2Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNy45OTM1MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE3Ljk5OTUxMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOC4wMDUxNjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjAxMTE1Nl0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4wMTY4MDZdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjAyMjgw
MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OC4wMjg0NTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE4LjAzNDQ0NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOC4wNDAwOTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjA0NjA5MV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4wNTE3NDJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjA1NzczN10g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4w
NjMzODddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE4LjA2OTM4Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOC4wNzUwMzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjA4MTAyOF0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4wODY2NzhdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjA5MjY3M10gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4wOTgz
MjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE4LjEwNDMyMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOC4xMDk5NzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjExNTk2Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4xMjE2MTZdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjEyNzYxMV0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4xMzMyNjJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE4LjEzOTI1Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOC4xNDQ5MDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE4LjE1MDkwMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4xNTY1NTBdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjE2MjU0NV0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4xNjgxOTVdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4
LjE3NDE5MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOC4xNzk4NDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE4LjE4NTgzNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4xOTE0ODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjE5NzQ4MF0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4yMDMxMzBdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjIw
OTEyNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOC4yMTQ3NzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE4LjIyMDc3MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOC4yMjY0MjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjIzMjQxNV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4yMzgwNjRdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjI0NDA1
OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OC4yNDk3MDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE4LjI1NTcwNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOC4yNjEzNTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjI2NzM0OV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4yNzI5OTldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjI3ODk5M10g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4y
ODQ2NDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE4LjI5MDYzOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOC4yOTYyOTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjMwMjI4NV0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4zMDc5MzVdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjMxMzkyOV0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4zMTk1
ODBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE4LjMyNTU3NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOC4zMzEyMjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjMzNzIyMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4zNDI4NzFdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjM0ODg2NV0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4zNTQ1MTZd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE4LjM2MDUxMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOC4zNjYxNjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE4LjM3MjE1NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4zNzc4MDVdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjM4MzgwMF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4zODk0NTBdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4
LjM5NTQ0NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOC40MDEwOTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE4LjQwNzA4OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOC40MTI3MzldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjQxODczNF0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC40MjQzODRdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjQz
MDM3OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOC40MzYwMjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE4LjQ0MjAyNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOC40NDc2NzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjQ1MzY3NF0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC40NTkzMjNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjQ2NTMx
OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OC40NzA5NjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE4LjQ3Njk2M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOC40ODI2MTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjQ4ODYwOV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC40OTQyNThdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjUwMDI1M10g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC41
MDU5MDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE4LjUxMTg5OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOC41MTc1NDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjUyMzU0M10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC41MjkxOTRdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjUzNTE4OF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC41NDA4
MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE4LjU0NjgzM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOC41NTI0ODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjU1ODQ3OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC41NjQxMzBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjU3MDEyNV0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC41NzU3NzVd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE4LjU4MTc3MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOC41ODc0MjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE4LjU5MzQxNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC41OTkwNzBdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjYwNTA2NV0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC42MTA3MTZdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4
LjYxNjcxM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOC42MjIzNjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE4LjYyODM1OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOC42MzQwMDddICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjY0MDAwMl0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC42NDU2NTJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjY1
MTY0Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOC42NTcyOTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE4LjY2MzI5MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOC42Njg5NDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjY3NDkzN10gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC42ODA1ODddICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjY4NjU4
Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OC42OTIyMzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE4LjY5ODIyNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOC43MDM4NzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjcwOTg3MV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC43MTU1MjJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjcyMTUxNl0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC43
MjcxNjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE4LjczMzE2Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOC43Mzg4MTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljc0NDgwNl0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC43NTA0NTZdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljc1NjQ1MV0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC43NjIx
MDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE4Ljc2ODA5Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOC43NzM3NDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljc3OTc0MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC43ODUzOTFdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljc5MTM4Nl0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC43OTcwMzZd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE4LjgwMzAzMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOC44MDg2ODFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE4LjgxNDY3Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC44MjAzMjZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjgyNjMyMV0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC44MzE5NzBdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4
LjgzNzk2NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOC44NDM2MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE4Ljg0OTYxMF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOC44NTUyNjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljg2MTI1NV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC44NjY5MDVdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljg3
Mjg5OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOC44Nzg1NTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE4Ljg4NDU0NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOC44OTAxOTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljg5NjE4OV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC45MDE4MzldICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjkwNzgz
M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OC45MTM0ODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE4LjkxOTQ3OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOC45MjUxMjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4LjkzMTEyM10gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC45MzY3NzNdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljk0Mjc2OF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC45
NDg0MThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE4Ljk1NDQxM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOC45NjAwNjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljk2NjA1N10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC45NzE3MDddICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE4Ljk3NzcwMl0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC45ODMz
NTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE4Ljk4OTM0N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOC45OTQ5OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjAwMDk5Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4wMDY2NDFdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjAxMjYzNl0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4wMTgyODZd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE5LjAyNDI4MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOS4wMjk5MzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE5LjAzNTkyNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4wNDE1NzZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjA0NzU3MV0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4wNTMyMjFdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5
LjA1OTIxNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOS4wNjQ4NjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE5LjA3MDg2MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4wNzY1MDldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjA4MjUwNF0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4wODgxNTRdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjA5
NDE0OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOS4wOTk3OThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE5LjEwNTc5M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOS4xMTE0NDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjExNzQzOF0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4xMjMwOTVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjEyOTA5
MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OS4xMzQ3NDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE5LjE0MDczNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOS4xNDYzODZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjE1MjM4MF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4xNTgwMzBdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjE2NDAyNV0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4x
Njk2NzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE5LjE3NTY3MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOS4xODEzMjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjE4NzMxNl0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4xOTI5NjZdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjE5ODk2MF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4yMDQ2
MTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE5LjIxMDYwNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOS4yMTYyNTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjIyMjI0OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4yMjc4OTldICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjIzMzg5NF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4yMzk1NDRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE5LjI0NTUzOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOS4yNTExODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE5LjI1NzE4M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4yNjI4MzJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjI2ODgyN10gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4yNzQ0NzddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5
LjI4MDQ3Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOS4yODYxMjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE5LjI5MjExN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4yOTc3NjZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjMwMzc2MV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4zMDk0MTFdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjMx
NTQwNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOS4zMjEwNTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE5LjMyNzA1MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOS4zMzI3MDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjMzODY5Nl0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4zNDQzNDZdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjM1MDM0
MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OS4zNTU5OTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE5LjM2MTk4Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOS4zNjc2MzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjM3MzYzMF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4zNzkyODBdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjM4NTI3NF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4z
OTA5MjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE5LjM5NjkxOV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOS40MDI1NjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjQwODU2M10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS40MTQyMTRdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjQyMDIwOV0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS40MjU4
NTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE5LjQzMTg1NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOS40Mzc1MDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjQ0MzQ5OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS40NDkxNDldICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjQ1NTE0NF0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS40NjA3OTNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE5LjQ2Njc4OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOS40NzI0MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE5LjQ3ODQzM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS40ODQwODNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjQ5MDA3OF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS40OTU3MjddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5
LjUwMTcyMl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOS41MDczNzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE5LjUxMzM2Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOS41MTkwMTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjUyNTAxMV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS41MzA2NjFdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjUz
NjY1NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOS41NDIzMDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE5LjU0ODMwMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOS41NTM5NTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjU1OTk0Nl0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS41NjU1OTZdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjU3MTU5
MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OS41NzcyNDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE5LjU4MzIzNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOS41ODg4ODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjU5NDg4MF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS42MDA1MzFdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjYwNjUyNV0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS42
MTIxNzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE5LjYxODE3MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOS42MjM4MjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjYyOTgyMF0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS42MzU0NzNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjY0MTQ2OF0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS42NDcx
MThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE5LjY1MzExM10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOS42NTg3NjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjY2NDc1N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS42NzA0MDddICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjY3NjQwMl0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS42ODIwNTJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE5LjY4ODA0N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOS42OTM2OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE5LjY5OTY5Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS43MDUzNDFdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjcxMTMzNl0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS43MTY5ODZdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5
LjcyMjk4MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOS43Mjg2MzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE5LjczNDYyNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOS43NDAyNzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljc0NjI3MV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS43NTE5MjJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljc1
NzkxN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOS43NjM1NjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE5Ljc2OTU2MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOS43NzUyMTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljc4MTIwN10gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS43ODY4NjNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljc5Mjg1
OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OS43OTg1MDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDE5LjgwNDUwNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOS44MTAxNTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjgxNjE0OV0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS44MjE3OTldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjgyNzc5NF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS44
MzM0NDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDE5LjgzOTQzOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOS44NDUwODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljg1MTA4M10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS44NTY3MzNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljg2MjcyN10gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS44Njgz
NzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDE5Ljg3NDM3Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOS44ODAwMjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljg4NjAxN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS44OTE2NjddICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljg5NzY2MV0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS45MDMzMTFd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDE5LjkwOTMwNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOS45MTQ5NTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDE5LjkyMDk1M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS45MjY2MDJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5LjkzMjU5OF0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS45MzgyNDddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5
Ljk0NDI0Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOS45NDk4OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDE5Ljk1NTg4OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOS45NjE1MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljk2NzUzM10gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS45NzMxODRdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDE5Ljk3
OTE3OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOS45ODQ4MzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDE5Ljk5MDgyNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOS45OTY0NzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjAwMjQ3MF0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4wMDgxMjBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjAxNDEx
NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
MC4wMTk3NjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDIwLjAyNTc1OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMC4wMzE0MDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjAzNzQwM10gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4wNDMwNTNdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjA0OTA0OF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4w
NTQ2OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDIwLjA2MDY5Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMC4wNjYzNDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjA3MjMzN10gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4wNzc5ODZdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjA4Mzk4MV0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4wODk2
MzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDIwLjA5NTYyNV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyMC4xMDEyNzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjEwNzI3MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4xMTI5MjBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjExODkxNV0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4xMjQ1NjVd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDIwLjEzMDU1OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyMC4xMzYyMDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDIwLjE0MjIwNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4xNDc4NTZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjE1Mzg1MV0gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4xNTk1MDNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIw
LjE2NTQ5OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyMC4xNzExNDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDIwLjE3NzE0M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4xODI3OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjE4ODc4N10gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4xOTQ0MzhdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjIw
MDQzMl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyMC4yMDYwODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDIwLjIxMjA3N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyMC4yMTc3MjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjIyMzcyMl0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4yMjkzNzJdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjIzNTM2
N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
MC4yNDEwMTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDIwLjI0NzAxMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMC4yNTI2NjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjI1ODY1Nl0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4yNjQzMDZdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjI3MDMwMV0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4y
NzU5NTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDIwLjI4MTk0NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMC4yODc1OTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjI5MzU5MV0gICoqKioqKiogSW4gaW9tbXVfZG1h
X2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4yOTkyNDFdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjMwNTIzNl0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4zMTA4
ODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDIwLjMxNjg4MF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyMC4zMjI1MzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjMyODUyNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4zMzQxNzRdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjM0MDE2OV0gICoqKioq
KiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4zNDU4MTld
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDIwLjM1MTgxNF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyMC4zNTc0NjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDIwLjM2MzQ1OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4zNjkxMDldICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjM3NTEwM10gICoqKioqKiog
SW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4zODA3NTNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIw
LjM4Njc0OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyMC4zOTIzOTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDIwLjM5ODM5Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyMC40MDQwNDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjQxMDAzN10gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC40MTU2ODZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjQy
MTY4MV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyMC40MjczMzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDIwLjQzMzMyNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyMC40Mzg5NzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjQ0NDk3MV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC40NTA2MjBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjQ1NjYx
NV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
MC40NjIyNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDIwLjQ2ODI2NF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMC40NzM5MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjQ3OTkxMF0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC40ODU1NTldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDIwLjQ5MTU1NF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC40
OTcyMDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDIwLjUwMzE5OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMC41MDk4MDNdIGk0MGUgMDAwMDowMTowMC4xOiBmdyA2LjAuNDg0NDIg
YXBpIDEuNyBudm0gNi4wMSAweDgwMDAzNDg1IDEuMTc0Ny4wIFs4MDg2OjE1ODldIFs4MDg2OjAw
MDBdClsgICAyMC44MDQ1MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxs
b2MoKSAqKioqKioqKioKWyAgIDIwLjgxMDUzMV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9j
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC44MTYzMDhdIGk0MGUgMDAwMDowMTowMC4xOiBN
QUMgYWRkcmVzczogM2M6ZmQ6ZmU6NmI6ZTk6YzEKWyAgIDIwLjgyMjE5Nl0gaTQwZSAwMDAwOjAx
OjAwLjE6IEZXIExMRFAgaXMgZW5hYmxlZApbICAgMjAuODMzMjgwXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMC44MzkyNzldICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuODQ0OTM0
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMC44NTA5MjldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjAuODU2NzU0XSBpNDBlIDAwMDA6MDE6MDAuMTogUENJLUV4cHJlc3M6IFNwZWVk
IDguMEdUL3MgV2lkdGggeDgKWyAgIDIwLjg2NDAxMl0gaTQwZSAwMDAwOjAxOjAwLjE6IEZlYXR1
cmVzOiBQRi1pZFsxXSBWU0lzOiAzNCBRUDogMzIgUlNTIEZEX0FUUiBGRF9TQiBOVFVQTEUgVnhM
QU4gR2VuZXZlIFBUUCBWRVBBClsgICAyMC44NzQxNThdIGk0MGUgMDAwMDowMTowMC4yOiBBZGRp
bmcgdG8gaW9tbXUgZ3JvdXAgNQpbICAgMjAuODc5MzA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC44ODU4MjFdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjg5MTc4
M10gaTQwZSAwMDAwOjAxOjAwLjI6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAg
MjAuOTE5MDQxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMC45MjUwMzhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjAuOTMwNzAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMC45MzY2OTZdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuOTQyMzQ4XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMC45NDgzNDNd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAu
OTUzOTk0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMC45NTk5ODldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjAuOTY1NjM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMC45NzE2MzRdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuOTc3Mjg1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMC45ODMyODFdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuOTg4
OTMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMC45OTQ5MjZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjEuMDAwNTc2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMS4wMDY1NzFdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMDEyMjI0XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4wMTgyMjBdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMDIzODY5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMS4wMjk4NjVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjEuMDM1NTE1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMS4wNDE1MDldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMDQ3MTYwXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4wNTMxNTVdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMDU4ODA1XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
MS4wNjQ4MDBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjEuMDcwNDUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMS4wNzY0NDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMDgyMDk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4wODgwOTFdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMDkzNzQxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4w
OTk3MzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjEuMTA1Mzg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMS4xMTEzODFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjEuMTE3MDMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4xMjMwMjddICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMTI4Njc4XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4xMzQ2
NzNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjEuMTQwMzIzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMS4xNDYzMThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjEuMTUxOTY4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4xNTc5NjNdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMTYzNjEzXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4xNjk2MDld
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEu
MTc1MjYwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMS4xODEyNTVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjEuMTg2OTA1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4xOTI5MDBdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMTk4NTQ5XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4yMDQ1NDVdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMjEw
MTk2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMS4yMTYxOTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjEuMjIxODQxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMS4yMjc4MzVdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMjMzNDg2XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4yMzk0ODBdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMjQ1MTMx
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMS4yNTExMjVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjEuMjU2Nzc2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMS4yNjI3NzFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMjY4NDIxXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4yNzQ0MTZdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMjgwMDY3XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
MS4yODYwNjJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjEuMjkxNzE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMS4yOTc3MTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMzAzMzYwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4zMDkzNTRdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMzE1MDA1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4z
MjA5OTldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjEuMzI2NjUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMS4zMzI2NDVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjEuMzM4Mjk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4zNDQyODldICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMzQ5OTM5XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4zNTU5
MzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjEuMzYxNTg0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMS4zNjc1NzldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjEuMzczMjMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4zNzkyMjRdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMzg0ODc2XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS4zOTA4NzFd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEu
Mzk2NTIxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMS40MDI1MTVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjEuNDA4MTY3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS40MTQxNjFdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNDE5ODExXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS40MjU4MDZdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNDMx
NDU2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMS40Mzc0NTFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjEuNDQzMTAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMS40NDkwOTZdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNDU0NzQ3XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS40NjA3NDJdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNDY2Mzky
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMS40NzIzODddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjEuNDc4MDM4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMS40ODQwMzNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNDg5NjgzXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS40OTU2NzhdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNTAxMzI5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
MS41MDczMjNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjEuNTEyOTc1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMS41MTg5NzBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNTI0NjE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS41MzA2MTRdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNTM2MjY1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS41
NDIyNjBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjEuNTQ3OTEwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMS41NTM5MDVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjEuNTU5NTU2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS41NjU1NTBdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNTcxMjAxXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS41Nzcx
OTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjEuNTgyODQ2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMS41ODg4NDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjEuNTk0NDkyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS42MDA0ODddICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNjA2MTM3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS42MTIxMzJd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEu
NjE3NzgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMS42MjM3NzddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjEuNjI5NDI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS42MzU0MjNdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNjQxMDczXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS42NDcwNjhdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNjUy
NzE4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMS42NTg3MTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjEuNjY0MzY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMS42NzAzNTldICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNjc2MDA5XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS42ODIwMDVdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNjg3NjU3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMS42OTM2NTFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjEuNjk5MzAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMS43MDUyOTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNzEwOTQ2XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS43MTY5NDFdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNzIyNTkxXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
MS43Mjg1ODZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjEuNzM0MjM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMS43NDAyMzFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNzQ1ODgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS43NTE4NzZdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNzU3NTI4XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS43
NjM1MjJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjEuNzY5MTcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMS43NzUxNjddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjEuNzgwODE4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS43ODY4MTJdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNzkyNDYzXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS43OTg0
NThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjEuODA0MTA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMS44MTAxMDNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjEuODE1NzU0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS44MjE3NDldICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuODI3Mzk5XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS44MzMzOTRd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEu
ODM5MDQ0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMS44NDUwMzldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjEuODUwNjkwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS44NTY2ODVdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuODYyMzM1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS44NjgzMzBdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuODcz
OTgwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMS44Nzk5NzVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjEuODg1NjI3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMS44OTE2MjFdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuODk3MjcxXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS45MDMyNjZdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuOTA4OTE3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMS45MTQ5MTFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjEuOTIwNTY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMS45MjY1NjRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuOTMyMjE0XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS45MzgyMDldICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuOTQzODYzXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
MS45NDk4NThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjEuOTU1NTA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMS45NjE1MDNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuOTY3MTUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS45NzMxNDddICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuOTc4Nzk3XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMS45
ODQ3OTJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjEuOTkwNDQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMS45OTY0MzhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjIuMDAyMDkwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4wMDgwODRdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMDEzNzM0XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4wMTk3
MjldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjIuMDI1Mzc5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMi4wMzEzNzNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjIuMDM3MDI0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4wNDMwMThdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMDQ4NjY5XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4wNTQ2NjRd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIu
MDYwMzE0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMi4wNjYzMDldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjIuMDcxOTYwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4wNzc5NTVdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMDgzNjA1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4wODk2MDBdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMDk1
MjUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMi4xMDEyNDVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjIuMTA2ODk2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMi4xMTI4OTBdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMTE4NTQxXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4xMjQ1MzZdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMTMwMTg3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMi4xMzYxODJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjIuMTQxODMyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMi4xNDc4MjddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMTUzNDc3XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4xNTk0NzJdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMTY1MTIzXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
Mi4xNzExMThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjIuMTc2NzY4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMi4xODI3NjNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMTg4NDEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4xOTQ0MDldICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMjAwMDYyXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4y
MDYwNTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjIuMjExNzA3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMi4yMTc3MDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjIuMjIzMzUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4yMjkzNDddICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMjM0OTk2XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4yNDA5
OTFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjIuMjQ2NjQxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMi4yNTI2MzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjIuMjU4Mjg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4yNjQyODFdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMjY5OTMxXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4yNzU5MjZd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIu
MjgxNTc2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMi4yODc1NzFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjIuMjkzMjIyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4yOTkyMTddICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMzA0ODY3XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4zMTA4NjJdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMzE2
NTEyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMi4zMjI1MDddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjIuMzI4MTU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMi4zMzQxNTNdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMzM5ODAzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4zNDU3OThdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMzUxNDQ5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMi4zNTc0NDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjIuMzYzMDk0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMi4zNjkwODldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMzc0NzM5XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi4zODA3MzRdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMzg2Mzg1XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
Mi4zOTIzNzldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjIuMzk4MDMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMi40MDQwMjVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNDA5Njc2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi40MTU2NzBdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNDIxMzIxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi40
MjczMTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjIuNDMyOTY2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMi40Mzg5NjFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjIuNDQ0NjEyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi40NTA2MDddICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNDU2MjU3XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi40NjIy
NTJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjIuNDY3OTAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMi40NzM4OTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjIuNDc5NTQ4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi40ODU1NDJdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNDkxMTkzXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi40OTcxODhd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIu
NTAyODM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMi41MDg4MzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjIuNTE0NDg0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi41MjA0NzldICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNTI2MTI5XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi41MzIxMjRdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNTM3
Nzc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMi41NDM3NjldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjIuNTQ5NDIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMi41NTU0MTRdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNTYxMDY1XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi41NjcwNjBdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNTcyNzEx
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMi41Nzg3MDVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjIuNTg0MzU2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMi41OTAzNTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNTk2MDAxXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi42MDE5OTZdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNjA3NjQ3XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
Mi42MTM2NDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjIuNjE5Mjk2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMi42MjUyOTFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNjMwOTQxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi42MzY5MzZdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNjQyNTg1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi42
NDg1ODBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjIuNjU0MjMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMi42NjAyMjRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjIuNjY1ODc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi42NzE4NjldICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNjc3NTE5XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi42ODM1
MTRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjIuNjg5MTY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMi42OTUxNTldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjIuNzAwODEwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi43MDY4MDZdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNzEyNDU3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi43MTg0NTJd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIu
NzI0MTAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMi43MzAwOTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjIuNzM1NzQ2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi43NDE3NDFdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNzQ3MzkxXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi43NTMzODZdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNzU5
MDM3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMi43NjUwMzFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjIuNzcwNjgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMi43NzY2NzddICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNzgyMzI3XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi43ODgzMjJdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNzkzOTcy
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMi43OTk5NjhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjIuODA1NjE4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMi44MTE2MTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuODE3MjY0XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi44MjMyNTldICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuODI4OTA5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
Mi44MzQ5MDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjIuODQwNTU0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMi44NDY1NDldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuODUyMjAwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi44NTgxOTRdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuODYzODQ1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi44
Njk4NDBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjIuODc1NDkxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMi44ODE0ODZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjIuODg3MTM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi44OTMxMzBdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuODk4NzgxXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi45MDQ3
NzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjIuOTEwNDI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMi45MTY0MjFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjIuOTIyMDcxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi45MjgwNjZdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuOTMzNzE1XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi45Mzk3MTZd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIu
OTQ1MzY2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMi45NTEzNjFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjIuOTU3MDExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi45NjMwMDVdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuOTY4NjU1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMi45NzQ2NTFdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuOTgw
MzAwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMi45ODYyOTVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjIuOTkxOTQ2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMi45OTc5NDFdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMDAzNTkxXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4wMDk1ODVdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMDE1MjM2
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMy4wMjEyMzBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjMuMDI2ODgwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMy4wMzI4NzVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMDM4NTI1XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4wNDQ1MjBdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMDUwMTcxXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
My4wNTYxNjVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjMuMDYxODE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMy4wNjc4MTFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMDczNDYyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4wNzk0NTZdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMDg1MTA3XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4w
OTExMDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjMuMDk2NzUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMy4xMDI3NDddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjMuMTA4Mzk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4xMTQzOTNdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMTIwMDQzXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4xMjYw
MzddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjMuMTMxNjg4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMy4xMzc2ODNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjMuMTQzMzM0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4xNDkzMjldICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMTU0OTc5XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4xNjA5NzRd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMu
MTY2NjI0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMy4xNzI2MTldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjMuMTc4MjcwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4xODQyNjRdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMTg5OTE2XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4xOTU5MTFdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMjAx
NTYxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMy4yMDc1NTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjMuMjEzMjA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMy4yMTkyMDRdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMjI0ODU0XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4yMzA4NDldICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMjM2NDk5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMy4yNDI0OTRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjMuMjQ4MTQ0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMy4yNTQxMzldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMjU5Nzg5XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4yNjU3ODRdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMjcxNDM0XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
My4yNzc0MjhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjMuMjgzMDgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMy4yODkwNzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMjk0NzI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4zMDA3MjFdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMzA2MzcxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4z
MTIzNjVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjMuMzE4MDE1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMy4zMjQwMTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjMuMzI5NjYwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4zMzU2NTVdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMzQxMzA1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4zNDcz
MDBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjMuMzUyOTUxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMy4zNTg5NDVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjMuMzY0NTk2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4zNzA1OTFdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMzc2MjQyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy4zODIyMzhd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMu
Mzg3ODg4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMy4zOTM4ODJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjMuMzk5NTMyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy40MDU1MjddICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNDExMTc3XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy40MTcxNzJdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNDIy
ODIzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMy40Mjg4MThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjMuNDM0NDY4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMy40NDA0NjNdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNDQ2MTEzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy40NTIxMDhdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNDU3NzU5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMy40NjM3NTRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjMuNDY5NDA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMy40NzUzOTldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNDgxMDQ5XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy40ODcwNDRdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNDkyNjk0XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
My40OTg2ODldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjMuNTA0MzM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMy41MTAzMzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNTE1OTg0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy41MjE5NzhdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNTI3NjI4XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy41
MzM2MjNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjMuNTM5MjcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMy41NDUyNjhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjMuNTUwOTE4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy41NTY5MTJdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNTYyNTYyXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy41Njg1
NTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjMuNTc0MjA3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMy41ODAyMDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjMuNTg1ODUxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy41OTE4NDZdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNTk3NDk2XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy42MDM0OTFd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMu
NjA5MTQxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMy42MTUxMzVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjMuNjIwNzg3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy42MjY3ODJdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNjMyNDMzXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy42Mzg0MjhdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNjQ0
MDc4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMy42NTAwNzNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjMuNjU1NzIyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMy42NjE3MTddICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNjY3MzY4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy42NzMzNjNdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNjc5MDEz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMy42ODUwMDddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjMuNjkwNjU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMy42OTY2NTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNzAyMzA0XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy43MDgyOTldICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNzEzOTQ5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
My43MTk5NDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjMuNzI1NTk0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMy43MzE1OTJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNzM3MjQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy43NDMyMzddICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNzQ4ODg3XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy43
NTQ4ODJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjMuNzYwNTMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMy43NjY1MjZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjMuNzcyMTc2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy43NzgxNzFdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNzgzODIxXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy43ODk4
MTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjMuNzk1NDY3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyMy44MDE0NjJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjMuODA3MTEyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy44MTMxMDddICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuODE4NzU3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy44MjQ3NTJd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMu
ODMwNDAzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyMy44MzYzOThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjMuODQyMDQ5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy44NDgwNDNdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuODUzNjk0XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy44NTk2ODldICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuODY1
MzM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyMy44NzEzMzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjMuODc2OTg0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyMy44ODI5NzldICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuODg4NjMwXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy44OTQ2MjRdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuOTAwMjc1
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyMy45MDYyNzBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjMuOTExOTIzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyMy45MTc5MTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuOTIzNTY5XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy45Mjk1NjRdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuOTM1MjE1XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
My45NDEyMTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjMuOTQ2ODY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyMy45NTI4NTldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuOTU4NTEwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy45NjQ1MTFdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuOTcwMTYxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy45
NzYxNTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjMuOTgxODA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyMy45ODc4MDFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjMuOTkzNDUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyMy45OTk0NDhdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMDA1MDk4XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4wMTEw
OTJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjQuMDE2NzQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNC4wMjI3MzddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjQuMDI4Mzg3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4wMzQzODJdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMDQwMDMyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4wNDYwMjdd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQu
MDUxNjc3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNC4wNTc2NzJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjQuMDYzMzIyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4wNjkzMTZdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMDc0OTY2XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4wODA5NjFdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMDg2
NjExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNC4wOTI2MDVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjQuMDk4MjU1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNC4xMDQyNTBdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMTA5OTAwXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4xMTU4OTVdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMTIxNTQ2
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNC4xMjc1NDBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjQuMTMzMTkwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNC4xMzkxODVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMTQ0ODM2XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4xNTA4MzBdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMTU2NDgxXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NC4xNjI0NzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjQuMTY4MTI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNC4xNzQxMjFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMTc5NzcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4xODU3NjddICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMTkxNDE3XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4x
OTc0MTJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjQuMjAzMDYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNC4yMDkwNTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjQuMjE0NzA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4yMjA3MDNdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMjI2MzUzXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4yMzIz
NDhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjQuMjM3OTk5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNC4yNDM5OTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjQuMjQ5NjQ3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4yNTU2NDJdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMjYxMjkyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4yNjcyODZd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQu
MjcyOTM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNC4yNzg5MzFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjQuMjg0NTgxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4yOTA1NzZdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMjk2MjI2XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4zMDIyMjFdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMzA3
ODcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNC4zMTM4NjZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjQuMzE5NTE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNC4zMjU1MTFdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMzMxMTYyXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4zMzcxNTddICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMzQyODA3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNC4zNDg4MDFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjQuMzU0NDUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNC4zNjA0NDddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMzY2MDk4XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC4zNzIwOTNdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMzc3NzQ0XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NC4zODM3MzldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjQuMzg5Mzg5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNC4zOTUzODNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNDAxMDM0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC40MDcwMjldICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNDEyNjc5XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC40
MTg2NzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjQuNDI0MzI0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNC40MzAzMTldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjQuNDM1OTcwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC40NDE5NjRdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNDQ3NjE1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC40NTM2
MTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjQuNDU5MjYxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNC40NjUyNTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjQuNDcwOTA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC40NzY5MDFdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNDgyNTUxXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC40ODg1NDZd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQu
NDk0MTk3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNC41MDAxOTJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjQuNTA1ODQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC41MTE4MzddICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNTE3NDg3XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC41MjM0ODJdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNTI5
MTMzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNC41MzUxMjhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjQuNTQwNzc4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNC41NDY3NzNdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNTUyNDIzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC41NTg0MTddICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNTY0MDY3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNC41NzAwNjJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjQuNTc1NzEyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNC41ODE3MDZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNTg3MzU2XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC41OTMzNTFdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNTk5MDAxXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NC42MDQ5OTVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjQuNjEwNjQ5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNC42MTY2NDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNjIyMjk0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC42MjgyODhdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNjMzOTM4XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC42
Mzk5MzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjQuNjQ1NTgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNC42NTE1NzhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjQuNjU3MjI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC42NjMyMjNdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNjY4ODczXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC42NzQ4
NjhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjQuNjgwNTE4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNC42ODY1MTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjQuNjkyMTYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC42OTgxNTddICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNzAzODA3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC43MDk4MDJd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQu
NzE1NDUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNC43MjE0NDddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjQuNzI3MDk2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC43MzMwOTFdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNzM4NzQzXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC43NDQ3MzddICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNzUw
Mzg3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNC43NTYzODRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjQuNzYyMDM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNC43NjgwMjldICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNzczNjc5XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC43Nzk2NzRdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNzg1MzI0
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNC43OTEzMThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjQuNzk2OTY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNC44MDI5NjNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuODA4NjE0XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC44MTQ2MDldICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuODIwMjU5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NC44MjYyNTRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjQuODMxOTA1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNC44Mzc5MDBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuODQzNTUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC44NDk1NDVdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuODU1MTk2XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC44
NjExOTFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjQuODY2ODQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNC44NzI4MzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjQuODc4NDg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC44ODQ0ODFdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuODkwMTMyXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC44OTYx
MjddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjQuOTAxNzc3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNC45MDc3NzJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjQuOTEzNDIyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC45MTk0MTddICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuOTI1MDY4XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC45MzEwNjJd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQu
OTM2NzEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNC45NDI3MDhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjQuOTQ4MzU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC45NTQzNTNdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuOTYwMDA0XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNC45NjU5OTldICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuOTcx
NjQ5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNC45Nzc2NDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjQuOTgzMzAwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNC45ODkyOTVdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuOTk0OTQ1XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4wMDA5NDBdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMDA2NTkw
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNS4wMTI1ODVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjUuMDE4MjM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNS4wMjQyMzBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMDI5ODgxXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4wMzU4NzVdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMDQxNTI1XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NS4wNDc1MjBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjUuMDUzMTcwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNS4wNTkxNjZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMDY0ODE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4wNzA4MTBdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMDc2NDYwXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4w
ODI0NTVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjUuMDg4MTA1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNS4wOTQxMDBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjUuMDk5NzUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4xMDU3NDRdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMTExMzk1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4xMTcz
ODldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjUuMTIzMDM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNS4xMjkwMzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjUuMTM0Njg0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4xNDA2NzldICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMTQ2MzMwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4xNTIzMjRd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUu
MTU3OTc1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNS4xNjM5NjldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjUuMTY5NjIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4xNzU2MTVdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMTgxMjY1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4xODcyNTldICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMTky
OTA5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNS4xOTg5MDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjUuMjA0NTU0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNS4yMTA1NDldICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMjE2MTk4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4yMjIxOTNdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMjI3ODQz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNS4yMzM4MzddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjUuMjM5NDg4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNS4yNDU0ODJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMjUxMTMyXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4yNTcxMjddICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMjYyNzc3XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NS4yNjg3NzVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjUuMjc0NDMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNS4yODA0MjRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMjg2MDc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4yOTIwNjldICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMjk3NzE5XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4z
MDM3MTRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjUuMzA5MzY1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNS4zMTUzNjBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjUuMzIxMDEwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4zMjcwMDVdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMzMyNjU2XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4zMzg2
NTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjUuMzQ0MzAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNS4zNTAyOTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjUuMzU1OTQ2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4zNjE5NDFdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMzY3NTkyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4zNzM1ODdd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUu
Mzc5MjM3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNS4zODUyMzJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjUuMzkwODgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS4zOTY4NzddICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNDAyNTI4XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS40MDg1MjJdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNDE0
MTczXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNS40MjAxNjhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjUuNDI1ODE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNS40MzE4MTRdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNDM3NDY0XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS40NDM0NTldICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNDQ5MTA5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNS40NTUxMDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjUuNDYwNzU1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNS40NjY3NTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNDcyNDAwXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS40NzgzOTVdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNDg0MDQ2XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NS40OTAwNDFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjUuNDk1NjkxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNS41MDE2ODZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNTA3MzM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS41MTMzMzFdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNTE4OTgyXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS41
MjQ5NzddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjUuNTMwNjI3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNS41MzY2MjJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjUuNTQyMjcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS41NDgyNjddICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNTUzOTE4XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS41NTk5
MTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjUuNTY1NTYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNS41NzE1NThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjUuNTc3MjA5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS41ODMyMDNdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNTg4ODU0XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS41OTQ4NDld
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUu
NjAwNDk5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNS42MDY0OTRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjUuNjEyMTQ1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS42MTgxNDBdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNjIzNzkwXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS42Mjk3ODVdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNjM1
NDM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNS42NDE0MzBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjUuNjQ3MDgxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNS42NTMwNzVdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNjU4NzI2XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS42NjQ3MjFdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNjcwMzcx
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNS42NzYzNjddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjUuNjgyMDE3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNS42ODgwMTJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNjkzNjYyXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS42OTk2NTddICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNzA1MzA4XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NS43MTEzMDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjUuNzE2OTUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNS43MjI5NDhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNzI4NTk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS43MzQ1OTNdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNzQwMjQ0XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS43
NDYyMzldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjUuNzUxODg5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNS43NTc4ODRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjUuNzYzNTM0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS43Njk1MjldICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNzc1MTgwXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS43ODEx
NzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjUuNzg2ODI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNS43OTI4MjFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjUuNzk4NDcxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS44MDQ0NjZdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuODEwMTE2XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS44MTYxMTFd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUu
ODIxNzYxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNS44Mjc3NTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjUuODMzNDA3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS44Mzk0MDFdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuODQ1MDUyXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS44NTEwNDZdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuODU2
Njk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNS44NjI2OTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjUuODY4MzQzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNS44NzQzMzhdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuODc5OTg4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS44ODU5ODNdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuODkxNjM0
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNS44OTc2MjhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjUuOTAzMjc5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNS45MDkyNzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuOTE0OTI0XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS45MjA5MTldICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuOTI2NTY5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
NS45MzI1NjRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjUuOTM4MjE1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNS45NDQyMDldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuOTQ5ODYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS45NTU4NThdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuOTYxNTA4XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS45
Njc1MDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjUuOTczMTUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNS45NzkxNDddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjUuOTg0Nzk3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNS45OTA3OTJdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuOTk2NDQyXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4wMDI0
MzhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjYuMDA4MDk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNi4wMTQwOTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjYuMDE5NzQwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4wMjU3MzVdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMDMxMzg2XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4wMzczODFd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYu
MDQzMDMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNi4wNDkwMjZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjYuMDU0Njc2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4wNjA2NzFdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMDY2MzIyXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4wNzIzMTZdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMDc3
OTY3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNi4wODM5NjJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjYuMDg5NjEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNi4wOTU2MDhdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMTAxMjU4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4xMDcyNTNdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMTEyOTAz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNi4xMTg4OThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjYuMTI0NTQ5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNi4xMzA1NDNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMTM2MTk0XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4xNDIxODldICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMTQ3ODM5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
Ni4xNTM4MzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjYuMTU5NDg1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNi4xNjU0ODBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMTcxMTMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4xNzcxMjZdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMTgyNzc2XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4x
ODg3NzBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjYuMTk0NDIxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNi4yMDA0MTVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjYuMjA2MDY2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4yMTIwNjFdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMjE3NzEyXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4yMjM3
MDddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjYuMjI5MzU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNi4yMzUzNTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjYuMjQxMDAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4yNDY5OTddICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMjUyNjQ4XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4yNTg2NDNd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYu
MjY0MjkzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNi4yNzAyODhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjYuMjc1OTM4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4yODE5MzNdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMjg3NTg1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4yOTM1ODFdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMjk5
MjMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNi4zMDUyMjZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjYuMzEwODc1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNi4zMTY4NzBdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMzIyNTIwXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4zMjg1MTVdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMzM0MTY1
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNi4zNDAxNjBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjYuMzQ1ODExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNi4zNTE4MDVdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMzU3NDU3XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4zNjM0NTFdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMzY5MTAyXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
Ni4zNzUwOTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjYuMzgwNzQ3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNi4zODY3NDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMzkyMzkyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi4zOTgzODddICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNDA0MDM3XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi40
MTAwMzJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjYuNDE1NjgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNi40MjE2NzhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjYuNDI3MzI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi40MzMzMjNdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNDM4OTczXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi40NDQ5
NjldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjYuNDUwNjE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNi40NTY2MTRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjYuNDYyMjY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi40NjgyNTldICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNDczOTEwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi40Nzk5MDRd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYu
NDg1NTU1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNi40OTE1NTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjYuNDk3MjAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi41MDMxOTVdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNTA4ODQ2XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi41MTQ4NDFdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNTIw
NDkxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNi41MjY0ODZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjYuNTMyMTM3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNi41MzgxMzFdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNTQzNzgzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi41NDk3NzddICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNTU1NDI3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNi41NjE0MjJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjYuNTY3MDczXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNi41NzMwNjhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNTc4NzE4XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi41ODQ3MTNdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNTkwMzYzXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
Ni41OTYzNThdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjYuNjAyMDA5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNi42MDgwMDRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNjEzNjU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi42MTk2NTJdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNjI1MzAyXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi42
MzEyOTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjYuNjM2OTQ2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNi42NDI5NDFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjYuNjQ4NTkxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi42NTQ1ODZdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNjYwMjM2XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi42NjYy
MzBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjYuNjcxODgxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNi42Nzc4NzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjYuNjgzNTI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi42ODk1MjFdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNjk1MTcyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi43MDExNjdd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYu
NzA2ODE4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAyNi43MTI4MTRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjYuNzE4NDY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi43MjQ0NTldICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNzMwMTA5XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi43MzYxMDRdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNzQx
NzUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAyNi43NDc3NDhdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjYuNzUzMzk5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNi43NTkzOTNdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNzY1MDQ0XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi43NzEwMzldICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNzc2Njg5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsg
ICAyNi43ODI2ODRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjYuNzg4MzM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAyNi43OTQzMjldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNzk5OTgwXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi44MDU5NzZdICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuODExNjI2XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAy
Ni44MTc2MjFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjYuODIzMjcxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAyNi44MjkyNjZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuODM0OTE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi44NDA5MTFdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuODQ2NTYxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi44
NTI1NTZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjYuODU4MjA3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkg
KioqKioqKioqClsgICAyNi44NjQyMDJdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjYuODY5ODU0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi44NzU4NDldICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuODgxNDk5XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAyNi44ODc0
OTNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjYuODkzMTQzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAyNi44OTkxMzldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjYuOTA1NzQzXSBpNDBlIDAwMDA6MDE6MDAuMjogZncgNi4wLjQ4
NDQyIGFwaSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5XSBbODA4
NjowMDAwXQpbICAgMjcuMTkzNDc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAyNy4xOTk0NzBdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuMjA1MjQ1XSBpNDBlIDAwMDA6MDE6MDAu
MjogTUFDIGFkZHJlc3M6IDNjOmZkOmZlOjZiOmU5OmMyClsgICAyNy4yMTExMzJdIGk0MGUgMDAw
MDowMTowMC4yOiBGVyBMTERQIGlzIGVuYWJsZWQKWyAgIDI3LjIyMjMwNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuMjI4MzAzXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjIz
Mzk1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjcuMjM5OTU0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI3LjI0NTc3NV0gaTQwZSAwMDAwOjAxOjAwLjI6IFBDSS1FeHByZXNzOiBT
cGVlZCA4LjBHVC9zIFdpZHRoIHg4ClsgICAyNy4yNTMwMzRdIGk0MGUgMDAwMDowMTowMC4yOiBG
ZWF0dXJlczogUEYtaWRbMl0gVlNJczogMzQgUVA6IDMyIFJTUyBGRF9BVFIgRkRfU0IgTlRVUExF
IFZ4TEFOIEdlbmV2ZSBQVFAgVkVQQQpbICAgMjcuMjYzMTc4XSBpNDBlIDAwMDA6MDE6MDAuMzog
QWRkaW5nIHRvIGlvbW11IGdyb3VwIDYKWyAgIDI3LjI2ODMxN10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuMjc0ODM0XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNy4y
ODA3OTJdIGk0MGUgMDAwMDowMTowMC4zOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikK
WyAgIDI3LjI5NzA1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjcuMzAzMDUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjMwODcxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuMzE0NzE0XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjMyMDM2Nl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuMzI2
MzYxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI3LjMzMjAxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjcuMzM4MDA2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI3LjM0MzY1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuMzQ5NjUyXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjM1NTMwM10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuMzYxMjk3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3
LjM2Njk0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjcuMzcyOTQyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI3LjM3ODU5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuMzg0NTg3XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjM5MDIzN10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuMzk2MjMyXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjQw
MTg4Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjcuNDA3ODc3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI3LjQxMzUzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNDE5NTI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjQyNTE3N10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNDMxMTcxXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjQzNjgy
MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjcuNDQyODE2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI3LjQ0ODQ2Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjcuNDU0NDYxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjQ2MDExMV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNDY2MTA2XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjQ3MTc1Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjcuNDc3NzUxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI3LjQ4MzQwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjcuNDg5Mzk2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjQ5NTA0N10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNTAxMDQzXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjUwNjY5M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcu
NTEyNjg5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI3LjUxODMzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjcuNTI0MzM0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjUyOTk4NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNTM1OTc5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjU0MTYzMF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNTQ3
NjI1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI3LjU1MzI3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjcuNTU5MjY5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI3LjU2NDkyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNTcwOTE1XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjU3NjU2Nl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNTgyNTYw
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3
LjU4ODIxMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjcuNTk0MjA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI3LjU5OTg1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNjA1ODUwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjYxMTUwMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNjE3NDk1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjYy
MzE0NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjcuNjI5MTM5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI3LjYzNDc4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNjQwNzgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjY0NjQzM10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNjUyNDI4XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjY1ODA3
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjcuNjY0MDczXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI3LjY2OTcyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjcuNjc1NzE4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjY4MTM3MF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNjg3MzY1XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjY5MzAxNl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjcuNjk5MDEwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI3LjcwNDY2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjcuNzEwNjU1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjcxNjMwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNzIyMzAwXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjcyNzk1MF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcu
NzMzOTQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI3LjczOTU5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjcuNzQ1NTkwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljc1MTI0MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNzU3MjM1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljc2Mjg4Nl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNzY4
ODgxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI3Ljc3NDUzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjcuNzgwNTI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI3Ljc4NjE3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuNzkyMTcxXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljc5NzgyMl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuODAzODE3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3
LjgwOTQ2N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjcuODE1NDYyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI3LjgyMTExM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuODI3MTEwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjgzMjc2MV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuODM4NzU1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljg0
NDQwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjcuODUwNDAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI3Ljg1NjA0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuODYyMDQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljg2NzY5NV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuODczNjkwXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljg3OTM0
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjcuODg1MzM1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI3Ljg5MDk4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjcuODk2OTgwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjkwMjYzMF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuOTA4NjI2XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjkxNDI3Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjcuOTIwMjcxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI3LjkyNTkyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjcuOTMxOTE3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjkzNzU2N10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuOTQzNTYxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljk0OTIxMl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcu
OTU1MjA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI3Ljk2MDg1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjcuOTY2ODUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljk3MjUwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuOTc4NDk3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljk4NDE1MF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjcuOTkw
MTQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI3Ljk5NTc5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjguMDAxNzg5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI4LjAwNzQ0MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMDEzNDM0XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjAxOTA4NF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMDI1MDc5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4
LjAzMDcyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjguMDM2NzI0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI4LjA0MjM3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMDQ4MzY5XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjA1NDAyMV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMDYwMDE2XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjA2
NTY3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjguMDcxNjY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI4LjA3NzMxNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMDgzMzA5XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjA4ODk1OV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMDk0OTU0XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjEwMDYw
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjguMTA2NTk5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI4LjExMjI0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjguMTE4MjQzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjEyMzg5M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMTI5ODg4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjEzNTUzOF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjguMTQxNTMzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI4LjE0NzE4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjguMTUzMTc4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjE1ODgyOF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMTY0ODI0XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjE3MDQ3NF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjgu
MTc2NDY5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI4LjE4MjExOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjguMTg4MTE0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjE5Mzc2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMTk5NzU5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjIwNTQxMF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMjEx
NDA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI4LjIxNzA1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjguMjIzMDUwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI4LjIyODcwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMjM0Njk2XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjI0MDM0N10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMjQ2MzQy
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4
LjI1MTk5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjguMjU3OTg3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI4LjI2MzYzN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMjY5NjMyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjI3NTI4Ml0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMjgxMjc3XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjI4
NjkyOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjguMjkyOTIyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI4LjI5ODU3M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMzA0NTY3XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjMxMDIxOF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMzE2MjIwXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjMyMTg3
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjguMzI3ODY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI4LjMzMzUxNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjguMzM5NTEzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjM0NTE2NF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMzUxMTU4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjM1NjgwOF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjguMzYyODAzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI4LjM2ODQ1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjguMzc0NDQ4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjM4MDA5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguMzg2MDkzXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjM5MTc0NF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjgu
Mzk3NzM5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI4LjQwMzM4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjguNDA5Mzg0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjQxNTAzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNDIxMDI5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjQyNjY4Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNDMy
Njc2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI4LjQzODMyNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjguNDQ0MzIxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI4LjQ0OTk3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNDU1OTY1XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjQ2MTYxNl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNDY3NjEx
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4
LjQ3MzI2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjguNDc5MjU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI4LjQ4NDkwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNDkwOTAyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjQ5NjU1Ml0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNTAyNTQ3XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjUw
ODE5N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjguNTE0MTkyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI4LjUxOTg0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNTI1ODM4XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjUzMTQ4OF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNTM3NDgzXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjU0MzEz
M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjguNTQ5MTI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI4LjU1NDc3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjguNTYwNzc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjU2NjQyNF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNTcyNDE5XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjU3ODA3MF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjguNTg0MDY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI4LjU4OTcxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjguNTk1NzEwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjYwMTM2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNjA3MzU1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjYxMzAwNl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjgu
NjE5MDAxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI4LjYyNDY1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjguNjMwNjQ3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjYzNjI5N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNjQyMjkyXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjY0Nzk0Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNjUz
OTM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI4LjY1OTU4N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjguNjY1NTgyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI4LjY3MTIzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNjc3MjI3XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjY4Mjg3OF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNjg4ODcz
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4
LjY5NDUyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjguNzAwNTE5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI4LjcwNjE2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNzEyMTY0XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjcxNzgxNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNzIzODA5XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljcy
OTQ1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjguNzM1NDU1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI4Ljc0MTEwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNzQ3MTAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljc1Mjc1Ml0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNzU4NzQ3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljc2NDM5
N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjguNzcwMzkxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI4Ljc3NjA0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjguNzgyMDM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljc4NzY4N10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguNzkzNjgxXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljc5OTMzM10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjguODA1MzI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI4LjgxMDk3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjguODE2OTcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjgyMjYyM10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguODI4NjE3XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjgzNDI2OF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjgu
ODQwMjYyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI4Ljg0NTkxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjguODUxOTEwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljg1NzU2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguODYzNTU1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljg2OTIwNV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguODc1
MjAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI4Ljg4MDg1MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjguODg2ODQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI4Ljg5MjQ5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguODk4NDg5XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjkwNDE0MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguOTEwMTM1
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4
LjkxNTc4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjguOTIxNzgwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI4LjkyNzQzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguOTMzNDI2XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjkzOTA3Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguOTQ1MDcxXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljk1
MDcyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjguOTU2NzE2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI4Ljk2MjM2N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjguOTY4MzYxXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljk3NDAxMl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjguOTgwMDA3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljk4NTY1
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjguOTkxNjUzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI4Ljk5NzMwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjkuMDAzMjk4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjAwODk0OV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMDE0OTQ0XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjAyMDU5NF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjkuMDI2NTg5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI5LjAzMjIzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjkuMDM4MjM0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjA0Mzg4NF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMDQ5ODc5XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjA1NTUzMF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjku
MDYxNTI1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI5LjA2NzE3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjkuMDczMTcwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjA3ODgyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMDg0ODE1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjA5MDQ2Nl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMDk2
NDYxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI5LjEwMjExMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjkuMTA4MTA2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI5LjExMzc1Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMTE5NzUxXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjEyNTQwMl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMTMxMzk3
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5
LjEzNzA0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjkuMTQzMDQzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI5LjE0ODY5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMTU0Njg4XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjE2MDMzOF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMTY2MzM0XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjE3
MTk4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjkuMTc3OTgwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI5LjE4MzYzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMTg5NjI1XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjE5NTI3NV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMjAxMjcwXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjIwNjky
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjkuMjEyOTE1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI5LjIxODU2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjkuMjI0NTYwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjIzMDIxMF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMjM2MjA1XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjI0MTg1Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjkuMjQ3ODUxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI5LjI1MzUwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjkuMjU5NDk2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjI2NTE0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMjcxMTQxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjI3Njc5Ml0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjku
MjgyNzg3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI5LjI4ODQzN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjkuMjk0NDMyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjMwMDA4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMzA2MDc3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjMxMTcyOF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMzE3
NzIzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI5LjMyMzM3M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjkuMzI5MzY5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI5LjMzNTAyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMzQxMDIwXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjM0NjY3MV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMzUyNjY2
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5
LjM1ODMxN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjkuMzY0MzE1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI5LjM2OTk2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMzc1OTYwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjM4MTYxMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuMzg3NjA1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjM5
MzI1NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjkuMzk5MjQ5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI5LjQwNDg5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNDEwODk0XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjQxNjU0N10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNDIyNTQyXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjQyODE5
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjkuNDM0MTg3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI5LjQzOTgzN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjkuNDQ1ODMyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjQ1MTQ4Ml0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNDU3NDc3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjQ2MzEyN10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjkuNDY5MTIyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI5LjQ3NDc3M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjkuNDgwNzY3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjQ4NjQxN10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNDkyNDEyXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjQ5ODA2Ml0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjku
NTA0MDU3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI5LjUwOTcwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjkuNTE1NzAzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjUyMTM1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNTI3MzQ4XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjUzMjk5OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNTM4
OTkzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI5LjU0NDY0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjkuNTUwNjQwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI5LjU1NjI5MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNTYyMjg2XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjU2NzkzNl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNTczOTMx
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5
LjU3OTU4MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjkuNTg1NTc2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI5LjU5MTIyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNTk3MjIwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjYwMjg3MF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNjA4ODY1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjYx
NDUxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjkuNjIwNTEwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI5LjYyNjE2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNjMyMTU1XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjYzNzgwNl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNjQzODAxXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjY0OTQ1
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjkuNjU1NDQ2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI5LjY2MTA5N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjkuNjY3MDkyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjY3Mjc0Ml0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNjc4NzM3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjY4NDM4OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjkuNjkwMzgyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI5LjY5NjAzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjkuNzAyMDI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjcwNzY3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNzEzNjczXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjcxOTMyNF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjku
NzI1MzE5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI5LjczMDk3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjkuNzM2OTY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljc0MjYxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNzQ4NjEwXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljc1NDI2MF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNzYw
MjU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI5Ljc2NTkwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjkuNzcxOTAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI5Ljc3NzU1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNzgzNTQ2XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljc4OTE5Nl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuNzk1MTkx
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5
LjgwMDg0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMjkuODA2ODM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI5LjgxMjQ4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuODE4NDgzXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjgyNDEzM10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuODMwMTI4XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljgz
NTc3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMjkuODQxNzc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI5Ljg0NzQyNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuODUzNDE5XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljg1OTA2OV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuODY1MDY0XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljg3MDcx
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMjkuODc2NzEyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI5Ljg4MjM2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMjkuODg4MzU3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljg5NDAwOF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuOTAwMDAyXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjkwNTY1M10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MjkuOTExNjQ4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI5LjkxNzMwMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMjkuOTIzMjk1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjkyODk0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuOTM0OTQwXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljk0MDU5MF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjku
OTQ2NTg1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI5Ljk1MjIzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMjkuOTU4MjMwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljk2Mzg4MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuOTY5ODc1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljk3NTUyNV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMjkuOTgx
NTIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI5Ljk4NzE3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMjkuOTkzMTY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI5Ljk5ODgxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMDA0ODExXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjAxMDQ2MV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMDE2NDU2
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMw
LjAyMjEwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzAuMDI4MTAxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMwLjAzMzc1Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMDM5NzQ3XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjA0NTM5N10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMDUxMzkyXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjA1
NzA0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzAuMDYzMDM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMwLjA2ODY4N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMDc0NjgyXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjA4MDMzMl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMDg2MzI3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjA5MTk4
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzAuMDk3OTc1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMwLjEwMzYyNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzAuMTA5NjIxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjExNTI3Ml0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMTIxMjY3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjEyNjkxN10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzAuMTMyOTEyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMwLjEzODU2Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzAuMTQ0NTU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjE1MDIwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMTU2MjAxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjE2MTg1Ml0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAu
MTY3ODQ3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMwLjE3MzQ5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzAuMTc5NDkyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjE4NTE0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMTkxMTM3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjE5Njc4N10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMjAy
NzgyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMwLjIwODQzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzAuMjE0NDI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMwLjIyMDA3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMjI2MDcxXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjIzMTcyMV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMjM3NzE2
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMw
LjI0MzM2Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzAuMjQ5MzYxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMwLjI1NTAxMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMjYxMDA2XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjI2NjY1Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMjcyNjUxXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjI3
ODMwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzAuMjg0Mjk3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMwLjI4OTk1MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMjk1OTQ2XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjMwMTYwMF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMzA3NTk1XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjMxMzI0
Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzAuMzE5MjQxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMwLjMyNDg5MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzAuMzMwODg2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjMzNjUzNl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMzQyNTMxXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjM0ODE4MV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzAuMzU0MTc2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMwLjM1OTgzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzAuMzY1ODI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjM3MTQ3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuMzc3NDc0XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjM4MzEyNl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAu
Mzg5MTIyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMwLjM5NDc3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzAuNDAwNzY2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjQwNjQxN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNDEyNDExXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjQxODA2Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNDI0
MDU3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMwLjQyOTcwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzAuNDM1NzAyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMwLjQ0MTM1Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNDQ3MzQ3XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjQ1Mjk5OF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNDU4OTkz
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMw
LjQ2NDY0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzAuNDcwNjM5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMwLjQ3NjI5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNDgyMjg0XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjQ4NzkzNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNDkzOTI5XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjQ5
OTU3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzAuNTA1NTc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMwLjUxMTIyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNTE3MjIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjUyMjg3MF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNTI4ODY1XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjUzNDUx
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzAuNTQwNTEwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMwLjU0NjE2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzAuNTUyMTU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjU1NzgwNl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNTYzODAxXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjU2OTQ1Ml0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzAuNTc1NDQ3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMwLjU4MTA5N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzAuNTg3MDkyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjU5Mjc0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNTk4NzM3XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjYwNDM4N10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAu
NjEwMzgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMwLjYxNjAzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzAuNjIyMDI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjYyNzY3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNjMzNjczXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjYzOTMyNF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNjQ1
MzE5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMwLjY1MDk2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzAuNjU2OTY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMwLjY2MjYxN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNjY4NjExXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjY3NDI2MV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNjgwMjU2
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMw
LjY4NTkwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzAuNjkxOTAxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMwLjY5NzU1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNzAzNTQ2XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjcwOTE5Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNzE1MTkxXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjcy
MDg0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzAuNzI2ODM2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMwLjczMjQ4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNzM4NDgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjc0NDEzM10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNzUwMTI4XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjc1NTc3
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzAuNzYxNzczXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMwLjc2NzQyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzAuNzczNDE4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjc3OTA2OF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuNzg1MDYzXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjc5MDcxM10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzAuNzk2NzA4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMwLjgwMjM1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzAuODA4MzUzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjgxNDAwM10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuODE5OTk4XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjgyNTY0OV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAu
ODMxNjQ0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMwLjgzNzI5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzAuODQzMjkwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjg0ODk0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuODU0OTM2XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjg2MDU4Nl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuODY2
NTgwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMwLjg3MjIzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzAuODc4MjI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMwLjg4Mzg3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuODg5ODcxXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjg5NTUyM10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuOTAxNTE5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMw
LjkwNzE2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzAuOTEzMTY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMwLjkxODgxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuOTI0ODA4XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjkzMDQ1OF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuOTM2NDU0XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjk0
MjEwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzAuOTQ4MDk5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMwLjk1Mzc0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuOTU5NzQ0XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjk2NTM5NF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzAuOTcxMzg5XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjk3NzAz
OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzAuOTgzMDM1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMwLjk4ODY4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzAuOTk0NjgxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjAwMDMzMV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMDA2MzI1XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjAxMTk3NV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzEuMDE3OTcwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMxLjAyMzYyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzEuMDI5NjE2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjAzNTI2OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMDQxMjYyXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjA0NjkxMl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEu
MDUyOTA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMxLjA1ODU1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzEuMDY0NTUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjA3MDIwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMDc2MTk3XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjA4MTg0OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMDg3
ODQzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMxLjA5MzQ5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzEuMDk5NDg4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMxLjEwNTEzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMTExMTMzXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjExNjc4NF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMTIyNzc5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMx
LjEyODQyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzEuMTM0NDI0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMxLjE0MDA3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMTQ2MDY5XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjE1MTcyMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMTU3NzE1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjE2
MzM2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzEuMTY5MzYxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMxLjE3NTAxMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMTgxMDA2XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjE4NjY1Nl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMTkyNjUyXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjE5ODMw
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzEuMjA0Mjk3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMxLjIwOTk0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzEuMjE1OTQyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjIyMTU5M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMjI3NTg4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjIzMzIzOF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzEuMjM5MjMzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMxLjI0NDg4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzEuMjUwODc4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjI1NjUyOF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMjYyNTIzXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjI2ODE3NF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEu
Mjc0MTY5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMxLjI3OTgxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzEuMjg1ODE0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjI5MTQ2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMjk3NDU5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjMwMzExMF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMzA5
MTA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMxLjMxNDc1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzEuMzIwNzUwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMxLjMyNjQwMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMzMyMzk1XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjMzODA0Nl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMzQ0MDQx
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMx
LjM0OTY5MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzEuMzU1Njg2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMxLjM2MTMzN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMzY3MzMyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjM3Mjk4Ml0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuMzc4OTgzXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjM4
NDYzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzEuMzkwNjI4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMxLjM5NjI3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNDAyMjc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjQwNzkzMF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNDEzOTI2XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjQxOTU3
N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzEuNDI1NTcxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMxLjQzMTIyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzEuNDM3MjE1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjQ0Mjg2NV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNDQ4ODYwXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjQ1NDUxMF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzEuNDYwNTA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMxLjQ2NjE1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzEuNDcyMTUwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjQ3NzgwMF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNDgzNzk1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjQ4OTQ0NV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEu
NDk1NDQwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMxLjUwMTA5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzEuNTA3MDg1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjUxMjczNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNTE4NzI5XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjUyNDM4MF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNTMw
Mzc1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMxLjUzNjAyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzEuNTQyMDIxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMxLjU0NzY3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNTUzNjY1XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjU1OTMxNl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNTY1MzEw
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMx
LjU3MDk2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzEuNTc2OTU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMxLjU4MjYwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNTg4NjAyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjU5NDI1M10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNjAwMjQ4XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjYw
NTg5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzEuNjExODkzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMxLjYxNzU0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNjIzNTM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjYyOTE4OF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNjM1MTgyXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjY0MDgz
M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzEuNjQ2ODI5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMxLjY1MjQ3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzEuNjU4NDc0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjY2NDEyNF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNjcwMTE5XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjY3NTc3MF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzEuNjgxNzY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMxLjY4NzQxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzEuNjkzNDEwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjY5OTA2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNzA1MDU1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjcxMDcwNV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEu
NzE2NzAwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMxLjcyMjM1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzEuNzI4MzQ2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjczMzk5Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNzM5OTkxXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjc0NTY0Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNzUx
NjM3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMxLjc1NzI4N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzEuNzYzMjgyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMxLjc2ODkzMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNzc0OTI3XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjc4MDU3OV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuNzg2NTc0
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMx
Ljc5MjIyNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzEuNzk4MjE5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMxLjgwMzg3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuODA5ODY0XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjgxNTUxNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuODIxNTA5XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjgy
NzE1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzEuODMzMTU0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMxLjgzODgwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuODQ0Nzk5XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjg1MDQ0OV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuODU2NDQ0XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjg2MjA5
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzEuODY4MDg5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMxLjg3MzczOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzEuODc5NzM0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjg4NTM4M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuODkxMzc4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjg5NzAyOF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzEuOTAzMDIzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMxLjkwODY3M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzEuOTE0NjY4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjkyMDMxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuOTI2MzE1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjkzMTk2NV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEu
OTM3OTYwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMxLjk0MzYxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzEuOTQ5NjA1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjk1NTI1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuOTYxMjUwXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjk2NjkwMV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuOTcy
ODk2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMxLjk3ODU0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzEuOTg0NTQxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMxLjk5MDE5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzEuOTk2MTg3XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjAwMTgzNl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMDA3ODMy
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMy
LjAxMzQ4Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzIuMDE5NDc3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMyLjAyNTEyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMDMxMTIyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjAzNjc3M10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMDQyNzY4XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjA0
ODQxN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzIuMDU0NDEyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMyLjA2MDA2Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMDY2MDU3XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjA3MTcwN10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMDc3NzAyXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjA4MzM1
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzIuMDg5MzQ5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMyLjA5NDk5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzIuMTAwOTkzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjEwNjY0M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMTEyNjM4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjExODI4OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzIuMTI0MjgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMyLjEyOTkzMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzIuMTM1OTI3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjE0MTU3N10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMTQ3NTcyXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjE1MzIyM10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIu
MTU5MjE4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMyLjE2NDg2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzIuMTcwODY0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjE3NjUxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMTgyNTA4XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjE4ODE1OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMTk0
MTUzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMyLjE5OTgwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzIuMjA1Nzk4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMyLjIxMTQ0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMjE3NDQ0XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjIyMzA5NF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMjI5MDg5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMy
LjIzNDczOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzIuMjQwNzM1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMyLjI0NjM4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMjUyMzgwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjI1ODAzMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMjY0MDI1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjI2
OTY3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzIuMjc1NjcwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMyLjI4MTMyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMjg3MzE2XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjI5Mjk2Nl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMjk4OTYxXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjMwNDYx
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzIuMzEwNjA3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMyLjMxNjI1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzIuMzIyMjUyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjMyNzkwMl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMzMzODk3XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjMzOTU0OV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzIuMzQ1NTQzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMyLjM1MTE5NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzIuMzU3MTg4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjM2MjgzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuMzY4ODM0XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjM3NDQ4NF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIu
MzgwNDc5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMyLjM4NjEzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzIuMzkyMTI0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjM5Nzc3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNDAzNzc1XSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjQwOTQyNl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNDE1
NDIxXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMyLjQyMTA3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzIuNDI3MDY2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMyLjQzMjcxN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNDM4NzEzXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjQ0NDM2NF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNDUwMzU5
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMy
LjQ1NjAwOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzIuNDYyMDA0XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMyLjQ2NzY1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNDczNjUwXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjQ3OTMwMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNDg1Mjk1XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjQ5
MDk0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzIuNDk2OTQwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMyLjUwMjU5MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNTA4NTg1XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjUxNDIzNl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNTIwMjMxXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjUyNTg4
M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzIuNTMxODc4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMyLjUzNzUyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzIuNTQzNTIzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjU0OTE3M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNTU1MTY4XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjU2MDgxOF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzIuNTY2ODEzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMyLjU3MjQ2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzIuNTc4NDU4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjU4NDEwOV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNTkwMTA0XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjU5NTc1NF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIu
NjAxNzQ5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMyLjYwNzM5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzIuNjEzMzk1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjYxOTA0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNjI1MDQwXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjYzMDY5MF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNjM2
Njg1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMyLjY0MjMzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzIuNjQ4MzMwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMyLjY1Mzk4MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNjU5OTc2XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjY2NTYyNl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNjcxNjIx
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMy
LjY3NzI3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzIuNjgzMjY2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMyLjY4ODkxN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNjk0OTExXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjcwMDU2MV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNzA2NTU2XSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjcx
MjIwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzIuNzE4MjAyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMyLjcyMzg1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNzI5ODQ4XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjczNTQ5OF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNzQxNDkzXSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjc0NzE0
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzIuNzUzMTQwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMyLjc1ODc5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzIuNzY0Nzg1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjc3MDQzNV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuNzc2NDMwXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjc4MjA4MF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzIuNzg4MDc1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMyLjc5MzcyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzIuNzk5NzIwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjgwNTM3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuODExMzY1XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjgxNzAxNl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIu
ODIzMDEyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMyLjgyODY2Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzIuODM0NjU3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjg0MDMwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuODQ2MzAyXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjg1MTk1Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuODU3
OTQ3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMyLjg2MzU5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzIuODY5NTkzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMyLjg3NTI0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuODgxMjM4XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjg4Njg4OF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuODkyODgz
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMy
Ljg5ODUzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzIuOTA0NTMwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMyLjkxMDE3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuOTE2MTc1XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjkyMTgyNV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuOTI3ODIwXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjkz
MzQ3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzIuOTM5NDY1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMyLjk0NTExN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuOTUxMTEzXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjk1Njc2M10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuOTYyNzU3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjk2ODQw
N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzIuOTc0NDAyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMyLjk4MDA1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzIuOTg2MDQ2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjk5MTY5N10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzIuOTk3NjkxXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjAwMzM0Ml0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzMuMDA5MzM4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMzLjAxNDk4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzMuMDIwOTgzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjAyNjYzM10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMDMyNjI4XSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjAzODI3OV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMu
MDQ0MjczXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMzLjA0OTkyNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzMuMDU1OTE4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjA2MTU2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMDY3NTYzXSAgKioqKioqKiBJbiBp
b21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjA3MzIxNF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMDc5
MjA5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMzLjA4NDg2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoq
KioqKioqKgpbICAgMzMuMDkwODU1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMzLjA5NjUwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMTAyNTAwXSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjEwODE1MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMTE0MTQ1
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMz
LjExOTc5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzMuMTI1NzkwXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMzLjEzMTQ0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMTM3NDM2XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjE0MzA4Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMTQ5MDgxXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjE1
NDczMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzMuMTYwNzI2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMzLjE2NjM3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMTcyMzcyXSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjE3ODAyMl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMTg0MDE3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjE4OTY2
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzMuMTk1NjYzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMzLjIwMTMxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzMuMjA3MzA4XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjIxMjk1OV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMjE4OTUzXSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjIyNDYwNF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzMuMjMwNTk5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMzLjIzNjI1MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzMuMjQyMjQ1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjI0Nzg5Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuMjUzODkxXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjI1OTU0MV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMu
MjY1NTM1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMzLjI3MTE4N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygp
ICoqKioqKioqKgpbICAgMzMuMjc3MTgyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjI4Mzc4N10gaTQwZSAwMDAwOjAxOjAwLjM6IGZ3IDYu
MC40ODQ0MiBhcGkgMS43IG52bSA2LjAxIDB4ODAwMDM0ODUgMS4xNzQ3LjAgWzgwODY6MTU4OV0g
WzgwODY6MDAwMF0KWyAgIDMzLjU3NjE0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuNTgyMTQ1XSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjU4NzkyMl0gaTQwZSAwMDAwOjAx
OjAwLjM6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMwpbICAgMzMuNTkzODA5XSBpNDBl
IDAwMDA6MDE6MDAuMzogRlcgTExEUCBpcyBlbmFibGVkClsgICAzMy42MDUwNDRdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDMzLjYxMTA0
M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
My42MTY2OThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDMzLjYyMjY5M10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAzMy42Mjg1MTVdIGk0MGUgMDAwMDowMTowMC4zOiBQQ0ktRXhwcmVz
czogU3BlZWQgOC4wR1QvcyBXaWR0aCB4OApbICAgMzMuNjM1ODI1XSBpNDBlIDAwMDA6MDE6MDAu
MzogRmVhdHVyZXM6IFBGLWlkWzNdIFZTSXM6IDM0IFFQOiAzMiBSU1MgRkRfQVRSIEZEX1NCIE5U
VVBMRSBWeExBTiBHZW5ldmUgUFRQIFZFUEEKWyAgIDMzLjY0NTk1N10gZWhjaV9oY2Q6IFVTQiAy
LjAgJ0VuaGFuY2VkJyBIb3N0IENvbnRyb2xsZXIgKEVIQ0kpIERyaXZlcgpbICAgMzMuNjUyNDg0
XSBlaGNpLXBjaTogRUhDSSBQQ0kgcGxhdGZvcm0gZHJpdmVyClsgICAzMy42NTY5NTRdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDMzLjY2MzQ3MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMzMuNjY5Mjc3XSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IEFkZGluZyB0byBpb21t
dSBncm91cCA3ClsgICAzMy42NzQ3NThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjY4MTI3NV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuNjg3Mjk2XSB4aGNpX2hj
ZCAwMDBkOjAxOjAwLjI6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAgMzMuNjkz
NDIwXSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IHhIQ0kgSG9zdCBDb250cm9sbGVyClsgICAzMy42
OTg2NDFdIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogbmV3IFVTQiBidXMgcmVnaXN0ZXJlZCwgYXNz
aWduZWQgYnVzIG51bWJlciAxClsgICAzMy43MDY1NzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDMzLjcxMjU3MV0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy43MTgyMzNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDMzLjcy
NDIyOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAzMy43Mjk4ODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAq
KioqKioqKioKWyAgIDMzLjczNTg3OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAzMy43NDE1MzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDMzLjc0NzUyNV0gICoqKioqKiogSW4gaW9t
bXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy43NTMxNzddICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDMzLjc1OTE3
Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
My43NjQ4NDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioq
KioqKioKWyAgIDMzLjc3MDgzNl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAzMy43NzY0ODddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDMzLjc4MjQ4Ml0gICoqKioqKiogSW4gaW9tbXVf
ZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy43ODgxMzJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDMzLjc5NDEyOF0g
ICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy43
OTk3NzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioq
KioKWyAgIDMzLjgwNTc3Ml0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzMy44MTE0NDZdIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogaGNjIHBhcmFt
cyAweDAxODBmZjA1IGhjaSB2ZXJzaW9uIDB4MTEwIHF1aXJrcyAweDAwMDAwMDAwMDAwMDAwMTAK
WyAgIDMzLjgyMDkwOF0gaHViIDEtMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDMzLjgyNDY2MF0g
aHViIDEtMDoxLjA6IDIgcG9ydHMgZGV0ZWN0ZWQKWyAgIDMzLjgyODc5M10geGhjaV9oY2QgMDAw
ZDowMTowMC4yOiB4SENJIEhvc3QgQ29udHJvbGxlcgpbICAgMzMuODM0MDExXSB4aGNpX2hjZCAw
MDBkOjAxOjAwLjI6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIg
MgpbICAgMzMuODQxMzk5XSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IEhvc3Qgc3VwcG9ydHMgVVNC
IDMuMSBFbmhhbmNlZCBTdXBlclNwZWVkClsgICAzMy44NDg0NjBdIHVzYiB1c2IyOiBXZSBkb24n
dCBrbm93IHRoZSBhbGdvcml0aG1zIGZvciBMUE0gZm9yIHRoaXMgaG9zdCwgZGlzYWJsaW5nIExQ
TS4KWyAgIDMzLjg1NjY1N10gaHViIDItMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDMzLjg2MDQw
OV0gaHViIDItMDoxLjA6IDQgcG9ydHMgZGV0ZWN0ZWQKWyAgIDMzLjg2NDU3N10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMu
ODcxMTAzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzMy44NzY4ODZdIHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogQWRkaW5nIHRvIGlvbW11IGdy
b3VwIDgKWyAgIDMzLjg4MjM2Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuODg4ODgzXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy44OTQ5MjhdIHhoY2lfaGNkIDAw
MDQ6MDM6MDAuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgIDMzLjkwMDE0OV0geGhjaV9oY2Qg
MDAwNDowMzowMC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVy
IDMKWyAgIDMzLjkwNzU1MV0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBaZXJvaW5nIDY0Yml0IGJh
c2UgcmVnaXN0ZXJzLCBleHBlY3RpbmcgZmF1bHQKWyAgIDMzLjkxNDk5Nl0geGhjaV9oY2QgMDAw
NDowMzowMC4wOiBGYXVsdCBkZXRlY3RlZApbICAgMzMuOTE1MDAzXSBhcm0tc21tdS12MyBhcm0t
c21tdS12My4zLmF1dG86IGV2ZW50IDB4MTAgcmVjZWl2ZWQ6ClsgICAzMy45MjQ5NjddICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDMzLjky
NTY5OF0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMy5hdXRvOiAJMHgwMDAwMDMwMDAwMDAwMDEw
ClsgICAzMy45MzE2OTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMzMuOTM3NTk5XSBhcm0tc21tdS12MyBhcm0tc21tdS12My4zLmF1dG86IAkw
eDAwMDAwMjA4MDAwMDAwMDAKWyAgIDMzLjk0MzI2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzMuOTQ5MTU1XSBhcm0tc21tdS12MyBh
cm0tc21tdS12My4zLmF1dG86IAkweDAwMDAwMDAwMDAwMDAwMDAKWyAgIDMzLjk1NTE0OV0gICoq
KioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy45NTUx
NTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioK
WyAgIDMzLjk2MTA2MF0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMy5hdXRvOiAJMHgwMDAwMDAw
MDAwMDAwMDAwClsgICAzMy45NjY3MDZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzMuOTY2NzEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzMy45OTAyNTNdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuOTk1OTA1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC4wMDE5
MDFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzQuMDA3NTY4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAzNC4wMTM1NjNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzQuMDE5MjEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC4wMjUyMDhdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuMDMwODU4XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC4wMzY4NTRd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQu
MDQyNTA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAzNC4wNDg0OTldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzQuMDU0MTUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC4wNjAxNDVdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuMDY1ODMwXSB4aGNpX2hjZCAwMDA0
OjAzOjAwLjA6IGhjYyBwYXJhbXMgMHgwMTQwNTFjZiBoY2kgdmVyc2lvbiAweDEwMCBxdWlya3Mg
MHgwMDAwMDAxMTAwMDAwNDEwClsgICAzNC4wNzY4ODRdIGh1YiAzLTA6MS4wOiBVU0IgaHViIGZv
dW5kClsgICAzNC4wODA2MzldIGh1YiAzLTA6MS4wOiA0IHBvcnRzIGRldGVjdGVkClsgICAzNC4w
ODQ4MTldIHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgIDM0
LjA5MDAzN10geGhjaV9oY2QgMDAwNDowMzowMC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBh
c3NpZ25lZCBidXMgbnVtYmVyIDQKWyAgIDM0LjA5NzQzNF0geGhjaV9oY2QgMDAwNDowMzowMC4w
OiBIb3N0IHN1cHBvcnRzIFVTQiAzLjAgU3VwZXJTcGVlZApbICAgMzQuMTAzNzE5XSB1c2IgdXNi
NDogV2UgZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGhtcyBmb3IgTFBNIGZvciB0aGlzIGhvc3QsIGRp
c2FibGluZyBMUE0uClsgICAzNC4xMTE5MjVdIGh1YiA0LTA6MS4wOiBVU0IgaHViIGZvdW5kClsg
ICAzNC4xMTU2NzddIGh1YiA0LTA6MS4wOiA0IHBvcnRzIGRldGVjdGVkClsgICAzNC4xMTk4MzRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDM0LjEyNjM1NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzQuMTMyMTQxXSB4aGNpX2hjZCAwMDA1OjAyOjAwLjA6IEFkZGluZyB0
byBpb21tdSBncm91cCA5ClsgICAzNC4xMzc2MjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM0LjE0NDEzOF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuMTUwMTQ1XSB4
aGNpX2hjZCAwMDA1OjAyOjAwLjA6IHhIQ0kgSG9zdCBDb250cm9sbGVyClsgICAzNC4xNTUzNjdd
IHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogbmV3IFVTQiBidXMgcmVnaXN0ZXJlZCwgYXNzaWduZWQg
YnVzIG51bWJlciA1ClsgICAzNC4xNjI3NjldIHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogWmVyb2lu
ZyA2NGJpdCBiYXNlIHJlZ2lzdGVycywgZXhwZWN0aW5nIGZhdWx0ClsgICAzNC4xNzAyMDVdIGFy
bS1zbW11LXYzIGFybS1zbW11LXYzLjQuYXV0bzogZXZlbnQgMHgxMCByZWNlaXZlZDoKWyAgIDM0
LjE3MDIxMl0geGhjaV9oY2QgMDAwNTowMjowMC4wOiBGYXVsdCBkZXRlY3RlZApbICAgMzQuMTc2
MjExXSBhcm0tc21tdS12MyBhcm0tc21tdS12My40LmF1dG86IAkweDAwMDAwMjAwMDAwMDAwMTAK
WyAgIDM0LjE4NjgwN10gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuNC5hdXRvOiAJMHgwMDAwMDIw
ODAwMDAwMDAwClsgICAzNC4xOTI3MTVdIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjQuYXV0bzog
CTB4MDAwMDAwMDAwMDAwMDAwMApbICAgMzQuMTk4NjI1XSBhcm0tc21tdS12MyBhcm0tc21tdS12
My40LmF1dG86IAkweDAwMDAwMDAwMDAwMDAwMDAKWyAgIDM0LjI5MTc4N10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzQuMjk3NzgzXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjMw
MzQ0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzQuMzA5NDQ3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDM0LjMxNTEwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3Bz
LT5hbGxvYygpICoqKioqKioqKgpbICAgMzQuMzIxMDk5XSAgKioqKioqKiBJbiBpb21tdV9kbWFf
YWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjMyNjc1Ml0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzQuMzMyNzQ3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjMzODQw
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzQuMzQ0Mzk1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDM0LjM1MDA2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5h
bGxvYygpICoqKioqKioqKgpbICAgMzQuMzU2MDU2XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjM2MTcwOV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzQuMzY3NzA0XSAgKioqKioq
KiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjM3MzM1NF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAg
MzQuMzc5MzQ5XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDM0LjM4NDk5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxv
YygpICoqKioqKioqKgpbICAgMzQuMzkwOTk1XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2Mo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjM5NjY0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzQuNDAyNjQwXSAgKioqKioqKiBJ
biBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjQwODMyNF0geGhj
aV9oY2QgMDAwNTowMjowMC4wOiBoY2MgcGFyYW1zIDB4MDE0MDUxY2YgaGNpIHZlcnNpb24gMHgx
MDAgcXVpcmtzIDB4MDAwMDAwMTEwMDAwMDQxMApbICAgMzQuNDE4MjQ4XSBodWIgNS0wOjEuMDog
VVNCIGh1YiBmb3VuZApbICAgMzQuNDIyMDAyXSBodWIgNS0wOjEuMDogNCBwb3J0cyBkZXRlY3Rl
ZApbICAgMzQuNDI2MTg1XSB4aGNpX2hjZCAwMDA1OjAyOjAwLjA6IHhIQ0kgSG9zdCBDb250cm9s
bGVyClsgICAzNC40MzE0MDRdIHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogbmV3IFVTQiBidXMgcmVn
aXN0ZXJlZCwgYXNzaWduZWQgYnVzIG51bWJlciA2ClsgICAzNC40Mzg3OTFdIHhoY2lfaGNkIDAw
MDU6MDI6MDAuMDogSG9zdCBzdXBwb3J0cyBVU0IgMy4wIFN1cGVyU3BlZWQKWyAgIDM0LjQ0NTEw
MV0gdXNiIHVzYjY6IFdlIGRvbid0IGtub3cgdGhlIGFsZ29yaXRobXMgZm9yIExQTSBmb3IgdGhp
cyBob3N0LCBkaXNhYmxpbmcgTFBNLgpbICAgMzQuNDUzMzAyXSBodWIgNi0wOjEuMDogVVNCIGh1
YiBmb3VuZApbICAgMzQuNDU3MDU0XSBodWIgNi0wOjEuMDogNCBwb3J0cyBkZXRlY3RlZApbICAg
MzQuNDYxNDkwXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYi1z
dG9yYWdlClsgICAzNC40NjgzODBdIHJ0Yy1lZmkgcnRjLWVmaS4wOiByZWdpc3RlcmVkIGFzIHJ0
YzAKWyAgIDM0LjQ3MzUxNl0gcnRjLWVmaSBydGMtZWZpLjA6IHNldHRpbmcgc3lzdGVtIGNsb2Nr
IHRvIDIwMjItMDQtMTRUMTA6Mzc6NDkgVVRDICgxNjQ5OTMyNjY5KQpbICAgMzQuNDgyMDI1XSBz
YnNhLWd3ZHQgc2JzYS1nd2R0LjA6IEluaXRpYWxpemVkIHdpdGggMTBzIHRpbWVvdXQgQCAyNTAw
MDAwMCBIeiwgYWN0aW9uPTAuClsgICAzNC40OTAyOTNdIGRldmljZS1tYXBwZXI6IGlvY3RsOiA0
LjQzLjAtaW9jdGwgKDIwMjAtMTAtMDEpIGluaXRpYWxpc2VkOiBkbS1kZXZlbEByZWRoYXQuY29t
ClsgICAzNC40OTk4MjddIHBzdG9yZTogUmVnaXN0ZXJlZCBlZmkgYXMgcGVyc2lzdGVudCBzdG9y
ZSBiYWNrZW5kClsgICAzNC41MDU2NzZdIFNNQ0NDOiBTT0NfSUQ6IElEID0gamVwMTA2OjBhMTY6
MDAwMSBSZXZpc2lvbiA9IDB4MDAwMDAwYTEKWyAgIDM0LjUxMjMwNl0gdXNiY29yZTogcmVnaXN0
ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciB1c2JoaWQKWyAgIDM0LjUxNzg2OF0gdXNiaGlkOiBV
U0IgSElEIGNvcmUgZHJpdmVyClsgICAzNC41MTk0NTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDM0LjUyMTcyNV0gdTMyIGNsYXNzaWZp
ZXIKWyAgIDM0LjUyNzY4N10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzNC41Mjc2OTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9w
cy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDM0LjUzMDM4Ml0gICAgIGlucHV0IGRldmljZSBjaGVj
ayBvbgpbICAgMzQuNTMwMzg0XSAgICAgQWN0aW9ucyBjb25maWd1cmVkClsgICAzNC41MzYwMzhd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQu
NTQyNDE0XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDEwClsgICAzNC41NDU2ODFd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAg
IDM0LjU0OTQ1NV0gU2VnbWVudCBSb3V0aW5nIHdpdGggSVB2NgpbICAgMzQuNTU0NzE3XSAgKioq
KioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjU1NDcy
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpb
ICAgMzQuNTU5MTgwXSBzaXQ6IElQdjYsIElQdjQgYW5kIE1QTFMgb3ZlciBJUHY0IHR1bm5lbGlu
ZyBkcml2ZXIKWyAgIDM0LjU2NTE1OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAzNC41OTIxNTBdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBm
YW1pbHkgMTcKWyAgIDM0LjU5NjYwM10gQnJpZGdlIGZpcmV3YWxsaW5nIHJlZ2lzdGVyZWQKWyAg
IDM0LjYwMDYyOV0gS2V5IHR5cGUgZG5zX3Jlc29sdmVyIHJlZ2lzdGVyZWQKWyAgIDM0LjYwNDk1
NF0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZhbWlseSA0MApbICAgMzQuNjA5NTIwXSBLZXkg
dHlwZSAuX2ZzY3J5cHQgcmVnaXN0ZXJlZApbICAgMzQuNjEzNTIyXSBLZXkgdHlwZSAuZnNjcnlw
dCByZWdpc3RlcmVkClsgICAzNC42MTc0MzRdIEtleSB0eXBlIGZzY3J5cHQtcHJvdmlzaW9uaW5n
IHJlZ2lzdGVyZWQKWyAgIDM0LjYyMjYxM10gQnRyZnMgbG9hZGVkLCBjcmMzMmM9Y3JjMzJjLWdl
bmVyaWMKWyAgIDM0LjYyNzIyN10gcHN0b3JlOiBVc2luZyBjcmFzaCBkdW1wIGNvbXByZXNzaW9u
OiBkZWZsYXRlClsgICAzNC42MzM1MjhdIEtleSB0eXBlIGVuY3J5cHRlZCByZWdpc3RlcmVkClsg
ICAzNC42Mzc4MDNdIEJFUlQ6IEVycm9yIHJlY29yZHMgZnJvbSBwcmV2aW91cyBib290OgpbICAg
MzQuNjQyNjc0XSBbSGFyZHdhcmUgRXJyb3JdOiBldmVudCBzZXZlcml0eTogcmVjb3ZlcmFibGUK
WyAgIDM0LjY0ODA2M10gW0hhcmR3YXJlIEVycm9yXTogIEVycm9yIDAsIHR5cGU6IGZhdGFsClsg
ICAzNC42NTI5MzFdIFtIYXJkd2FyZSBFcnJvcl06ICAgc2VjdGlvbiB0eXBlOiB1bmtub3duLCBl
OGVkODk4ZC1kZjE2LTQzY2MtOGVjYy01NGYwNjBlZjE1N2YKWyAgIDM0LjY2MTI3MF0gW0hhcmR3
YXJlIEVycm9yXTogICBzZWN0aW9uIGxlbmd0aDogMHgzMQpbICAgMzQuNjY2MjI2XSBbSGFyZHdh
cmUgRXJyb3JdOiAgIDAwMDAwMDAwOiAwMDAwMDA3ZiA2ZTZiNmU1NSAyMDZlNzc2ZiA2ZjYyNjU3
MiAgLi4uLlVua25vd24gcmVibwpbICAgMzQuNjcxMjEwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC42NzQ5MTNdIFtIYXJkd2FyZSBF
cnJvcl06ICAgMDAwMDAwMTA6IDcyMjA3NDZmIDZmNzM2MTY1IDAwMDAwMDZlIDAwMDAwMDAwICBv
dCByZWFzb24uLi4uLi4uClsgICAzNC42NzQ5MTZdIFtIYXJkd2FyZSBFcnJvcl06ICAgMDAwMDAw
MjA6IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwICAuLi4uLi4uLi4uLi4uLi4u
ClsgICAzNC42NzQ5MTddIFtIYXJkd2FyZSBFcnJvcl06ICAgMDAwMDAwMzA6IDExICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuClsgICAzNC43MDY3MjBdIHVz
YiAzLTQ6IG5ldyBoaWdoLXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDIgdXNpbmcgeGhjaV9oY2QK
WyAgIDM0LjcwNjcyN10gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzNC43MDY3MzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDM0LjcxMzI1M10gcHJpbnRrOiBjb25zb2xlIFtuZXRjb24w
XSBlbmFibGVkClsgICAzNC43MTg5MTFdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzQuNzI0ODk3XSBuZXRjb25zb2xlOiBuZXR3b3JrIGxvZ2dp
bmcgc3RhcnRlZApbICAgMzQuNzM5NDI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBv
cHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC43NDU0MjZdICAqKioqKioqIEluIGlvbW11X2Rt
YV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuNzUxMDc5XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC43NTEwOTRdIG1k
OiBXYWl0aW5nIGZvciBhbGwgZGV2aWNlcyB0byBiZSBhdmFpbGFibGUgYmVmb3JlIGF1dG9kZXRl
Y3QKWyAgIDM0Ljc1NzA3Nl0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzNC43NjM4NTNdIG1kOiBJZiB5b3UgZG9uJ3QgdXNlIHJhaWQsIHVzZSBy
YWlkPW5vYXV0b2RldGVjdApbICAgMzQuNzc1MTQ3XSBtZDogQXV0b2RldGVjdGluZyBSQUlEIGFy
cmF5cy4KWyAgIDM0Ljc3OTIzM10gbWQ6IGF1dG9ydW4gLi4uClsgICAzNC43ODIwMTRdIG1kOiAu
Li4gYXV0b3J1biBET05FLgpbICAgMzQuNzg1MzU5XSBXYWl0aW5nIGZvciByb290IGRldmljZSAv
ZGV2L3NkYTIuLi4KWyAgIDM0Ljg5MTYzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzQuODk3NjQyXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjkwMzI5OF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzQuOTA5MzAxXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0Ljkx
NDk1OF0gdXNiIDYtMTogbmV3IFN1cGVyU3BlZWQgR2VuIDEgVVNCIGRldmljZSBudW1iZXIgMiB1
c2luZyB4aGNpX2hjZApbICAgMzQuOTIzOTc1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC45Mjk5NzRdICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuOTQ3NTY2XSBodWIgMy00OjEu
MDogVVNCIGh1YiBmb3VuZApbICAgMzQuOTUxNzE5XSBodWIgMy00OjEuMDogNSBwb3J0cyBkZXRl
Y3RlZApbICAgMzQuOTY0Mzc1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFs
bG9jKCkgKioqKioqKioqClsgICAzNC45NzAzNzZdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxv
YygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuOTc2MDMwXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNC45ODIwMzddICAqKioqKioq
IEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuOTg3Njk2XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAz
NC45OTM3MzRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMzQuOTk5Mzg4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9j
KCkgKioqKioqKioqClsgICAzNS4wMDUzODNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuMDEzMzcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNS4wMTkzNzFdICAqKioqKioqIElu
IGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuMDM1MDc0XSB1c2It
c3RvcmFnZSA2LTE6MS4wOiBVU0IgTWFzcyBTdG9yYWdlIGRldmljZSBkZXRlY3RlZApbICAgMzUu
MDQxMzE0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioq
KioqClsgICAzNS4wNDczMTBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzUuMDUzMDIyXSBzY3NpIGhvc3QwOiB1c2Itc3RvcmFnZSA2LTE6MS4w
ClsgICAzNS4yMTE5ODFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2Mo
KSAqKioqKioqKioKWyAgIDM1LjIxNzk3OV0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzNS4yMjM2MzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDM1LjIyOTYzMF0gICoqKioqKiogSW4g
aW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNS4yMzUyODJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioKWyAgIDM1LjI0
MTI3OF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2FsbG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAzNS4zMzQ5MjFdIHVzYiAzLTQuMTogbmV3IGhpZ2gtc3BlZWQgVVNCIGRldmljZSBudW1iZXIg
MyB1c2luZyB4aGNpX2hjZApbICAgMzUuNDYxMzQ2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNS40NjczNDVdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuNDcyOTk5XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNS40Nzg5
OTddICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzUuNDg0NjQ4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAzNS40OTA2NDNdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzUuNDk2Mjk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNS41MDIyODldICAqKioqKioqIEluIGlvbW11
X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuNTEwMDA0XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNS41MTYwMDVd
ICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUu
NTM1MjA3XSB1c2Itc3RvcmFnZSAzLTQuMToxLjA6IFVTQiBNYXNzIFN0b3JhZ2UgZGV2aWNlIGRl
dGVjdGVkClsgICAzNS41NDE2MTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+
YWxsb2MoKSAqKioqKioqKioKWyAgIDM1LjU0NzYwOF0gICoqKioqKiogSW4gaW9tbXVfZG1hX2Fs
bG9jKCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNS41NTMzMjRdIHNjc2kgaG9zdDE6IHVzYi1z
dG9yYWdlIDMtNC4xOjEuMApbICAgMzUuNTYxNDM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNS41Njc0MzJdICAqKioqKioqIEluIGlv
bW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuNTczMDg3XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNS41Nzkw
ODRdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzUuNTg0NzM0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioq
KioqKioqClsgICAzNS41OTA3MzBdICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzUuNjgyOTYwXSB1c2IgMy00LjI6IG5ldyBoaWdoLXNwZWVkIFVT
QiBkZXZpY2UgbnVtYmVyIDQgdXNpbmcgeGhjaV9oY2QKWyAgIDM1LjgxMTU3M10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzUuODE3NTc0
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM1
LjgyMzIyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzUuODI5MjIzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDM1LjgzNDg3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
b3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzUuODQwODcxXSAgKioqKioqKiBJbiBpb21tdV9k
bWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM1Ljg0NjUyM10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzUuODUyNTIwXSAg
KioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM1Ljg2
MDIxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioq
KgpbICAgMzUuODY2MjEzXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDM1Ljg4NDU5OF0gdXNiLXN0b3JhZ2UgMy00LjI6MS4wOiBVU0IgTWFzcyBT
dG9yYWdlIGRldmljZSBkZXRlY3RlZApbICAgMzUuODkxMDY1XSBzY3NpIGhvc3QyOiB1c2Itc3Rv
cmFnZSAzLTQuMjoxLjAKWyAgIDM1Ljg5OTczNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzUuOTA1NzM0XSAgKioqKioqKiBJbiBpb21t
dV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM1LjkxMTM5MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzUuOTE3Mzg1
XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM1
LjkyMzAzNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioq
KioqKgpbICAgMzUuOTI5MDMyXSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxsb2MoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDM2LjAyMjkzOF0gdXNiIDMtNC4zOiBuZXcgbG93LXNwZWVkIFVTQiBk
ZXZpY2UgbnVtYmVyIDUgdXNpbmcgeGhjaV9oY2QKWyAgIDM2LjA3OTczNF0gc2NzaSAwOjA6MDow
OiBEaXJlY3QtQWNjZXNzICAgICAgVVNCICAgICAgU2FuRGlzayAzLjJHZW4xIDEuMDAgUFE6IDAg
QU5TSTogNgpbICAgMzYuMDg4Mjc0XSBzZCAwOjA6MDowOiBbc2RhXSAxMjAxNzY2NDAgNTEyLWJ5
dGUgbG9naWNhbCBibG9ja3M6ICg2MS41IEdCLzU3LjMgR2lCKQpbICAgMzYuMDk3ODg4XSBzZCAw
OjA6MDowOiBbc2RhXSBXcml0ZSBQcm90ZWN0IGlzIG9mZgpbICAgMzYuMTA0Njg4XSBzZCAwOjA6
MDowOiBbc2RhXSBXcml0ZSBjYWNoZTogZGlzYWJsZWQsIHJlYWQgY2FjaGU6IGVuYWJsZWQsIGRv
ZXNuJ3Qgc3VwcG9ydCBEUE8gb3IgRlVBClsgICAzNi4xNDAwMDZdIEdQVDpQcmltYXJ5IGhlYWRl
ciB0aGlua3MgQWx0LiBoZWFkZXIgaXMgbm90IGF0IHRoZSBlbmQgb2YgdGhlIGRpc2suClsgICAz
Ni4xNDc0MDBdIEdQVDoxNzE4MTk1MSAhPSAxMjAxNzY2MzkKWyAgIDM2LjE1MTA1M10gR1BUOkFs
dGVybmF0ZSBHUFQgaGVhZGVyIG5vdCBhdCB0aGUgZW5kIG9mIHRoZSBkaXNrLgpbICAgMzYuMTU3
MDQ5XSBHUFQ6MTcxODE5NTEgIT0gMTIwMTc2NjM5ClsgICAzNi4xNjA3MDBdIEdQVDogVXNlIEdO
VSBQYXJ0ZWQgdG8gY29ycmVjdCBHUFQgZXJyb3JzLgpbICAgMzYuMTYxOTUxXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNi4xNjU4MzRd
ICBzZGE6IHNkYTEgc2RhMgpbICAgMzYuMTcxODI3XSAgKioqKioqKiBJbiBpb21tdV9kbWFfYWxs
b2MoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM2LjE3MTgzOV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKgpbICAgMzYuMTgzNTY1XSBzZCAwOjA6
MDowOiBbc2RhXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNrClsgICAzNi4xODYyNTZdICAq
KioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzYuMTk3
MzgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
ClsgICAzNi4yMDMzNzldICAqKioqKioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMzYuMjA5MDM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMt
PmFsbG9jKCkgKioqKioqKioqClsgICAzNi4yMTUwMzFdICAqKioqKioqIEluIGlvbW11X2RtYV9h
bGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzYuMjIyODI2XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqClsgICAzNi4yMjg4MjZdICAqKioq
KioqIEluIGlvbW11X2RtYV9hbGxvYygpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzYuMjYxMTM0
XSBpbnB1dDogQW1lcmljYW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1YWwgS2V5Ym9hcmQgYW5kIE1v
dXNlIGFzIC9kZXZpY2VzL3BjaTAwMDQ6MDAvMDAwNDowMDowMy4wLzAwMDQ6MDM6MDAuMC91c2Iz
LzMtNC8zLTQuMy8zLTQuMzoxLjAvMDAwMzowNDZCOkZGMTAuMDAwMS9pbnB1dC9pbnB1dDEKWyAg
IDM2LjI3Njk5NV0gaGlkLWdlbmVyaWMgMDAwMzowNDZCOkZGMTAuMDAwMTogaW5wdXQ6IFVTQiBI
SUQgdjEuMTAgS2V5Ym9hcmQgW0FtZXJpY2FuIE1lZ2F0cmVuZHMgSW5jLiBWaXJ0dWFsIEtleWJv
YXJkIGFuZCBNb3VzZV0gb24gdXNiLTAwMDQ6MDM6MDAuMC00LjMvaW5wdXQwClsgICAzNi4zMDE0
NDldIGlucHV0OiBBbWVyaWNhbiBNZWdhdHJlbmRzIEluYy4gVmlydHVhbCBLZXlib2FyZCBhbmQg
TW91c2UgYXMgL2RldmljZXMvcGNpMDAwNDowMC8wMDA0OjAwOjAzLjAvMDAwNDowMzowMC4wL3Vz
YjMvMy00LzMtNC4zLzMtNC4zOjEuMS8wMDAzOjA0NkI6RkYxMC4wMDAyL2lucHV0L2lucHV0Mgpb
ICAgMzYuMzE3MzAyXSBoaWQtZ2VuZXJpYyAwMDAzOjA0NkI6RkYxMC4wMDAyOiBpbnB1dDogVVNC
IEhJRCB2MS4xMCBNb3VzZSBbQW1lcmljYW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1YWwgS2V5Ym9h
cmQgYW5kIE1vdXNlXSBvbiB1c2ItMDAwNDowMzowMC4wLTQuMy9pbnB1dDEKWyAgIDM2LjM0NDkw
NV0gcmFuZG9tOiBmYXN0IGluaXQgZG9uZQpbICAgMzYuNTY1NTc5XSBzY3NpIDE6MDowOjA6IENE
LVJPTSAgICAgICAgICAgIEFNSSAgICAgIFZpcnR1YWwgQ0RST00wICAgMS4wMCBQUTogMCBBTlNJ
OiAwIENDUwpbICAgMzYuNTc0NDIyXSBzY3NpIDE6MDowOjE6IENELVJPTSAgICAgICAgICAgIEFN
SSAgICAgIFZpcnR1YWwgQ0RST00xICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMzYuNTgz
MTY2XSBzY3NpIDE6MDowOjI6IENELVJPTSAgICAgICAgICAgIEFNSSAgICAgIFZpcnR1YWwgQ0RS
T00yICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMzYuNTkxOTMwXSBzY3NpIDE6MDowOjM6
IENELVJPTSAgICAgICAgICAgIEFNSSAgICAgIFZpcnR1YWwgQ0RST00zICAgMS4wMCBQUTogMCBB
TlNJOiAwIENDUwpbICAgMzYuODk2NzUwXSBFWFQ0LWZzIChzZGEyKTogcmVjb3ZlcnkgY29tcGxl
dGUKWyAgIDM2LjkwNDQyOV0gRVhUNC1mcyAoc2RhMik6IG1vdW50ZWQgZmlsZXN5c3RlbSB3aXRo
IG9yZGVyZWQgZGF0YSBtb2RlLiBPcHRzOiAobnVsbCkKWyAgIDM2LjkxMTU5MV0gc2NzaSAyOjA6
MDowOiBEaXJlY3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrMCAgIDEuMDAgUFE6
IDAgQU5TSTogMCBDQ1MKWyAgIDM2LjkxMjA5NF0gVkZTOiBNb3VudGVkIHJvb3QgKGV4dDQgZmls
ZXN5c3RlbSkgb24gZGV2aWNlIDg6Mi4KWyAgIDM2LjkyMTA0NF0gc2NzaSAyOjA6MDoxOiBEaXJl
Y3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrMSAgIDEuMDAgUFE6IDAgQU5TSTog
MCBDQ1MKWyAgIDM2LjkyNzQ2NF0gc2QgMjowOjA6MDogW3NkYl0gQXR0YWNoZWQgU0NTSSByZW1v
dmFibGUgZGlzawpbICAgMzYuOTMxNDM0XSBkZXZ0bXBmczogbW91bnRlZApbICAgMzYuOTM1Mjcw
XSBzY3NpIDI6MDowOjI6IERpcmVjdC1BY2Nlc3MgICAgIEFNSSAgICAgIFZpcnR1YWwgSERpc2sy
ICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMzYuOTUyMTEwXSBzY3NpIDI6MDowOjM6IERp
cmVjdC1BY2Nlc3MgICAgIEFNSSAgICAgIFZpcnR1YWwgSERpc2szICAgMS4wMCBQUTogMCBBTlNJ
OiAwIENDUwpbICAgMzYuOTUyNTEyXSBzZCAyOjA6MDoxOiBbc2RjXSBBdHRhY2hlZCBTQ1NJIHJl
bW92YWJsZSBkaXNrClsgICAzNi45NTI5MjhdIHNkIDI6MDowOjI6IFtzZGRdIEF0dGFjaGVkIFND
U0kgcmVtb3ZhYmxlIGRpc2sKWyAgIDM2Ljk3NzA2Ml0gc2NzaSAyOjA6MDo0OiBEaXJlY3QtQWNj
ZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrNCAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MK
WyAgIDM2Ljk3ODA4N10gc2QgMjowOjA6MzogW3NkZV0gQXR0YWNoZWQgU0NTSSByZW1vdmFibGUg
ZGlzawpbICAgMzYuOTk1MzUyXSBzZCAyOjA6MDo0OiBbc2RmXSBBdHRhY2hlZCBTQ1NJIHJlbW92
YWJsZSBkaXNrClsgICAzNy4wMDI2MTBdIEZyZWVpbmcgdW51c2VkIGtlcm5lbCBtZW1vcnk6IDQx
NjBLClsgICAzNy4wMTUwMzZdIFJ1biAvc2Jpbi9pbml0IGFzIGluaXQgcHJvY2VzcwpbICAgMzcu
Mjk4NjY0XSBzeXN0ZW1kWzFdOiBzeXN0ZW1kIDI0OS43KyBydW5uaW5nIGluIHN5c3RlbSBtb2Rl
ICgtUEFNIC1BVURJVCAtU0VMSU5VWCAtQVBQQVJNT1IgK0lNQSAtU01BQ0sgK1NFQ0NPTVAgLUdD
UllQVCAtR05VVExTIC1PUEVOU1NMICtBQ0wgK0JMS0lEIC1DVVJMIC1FTEZVVElMUyAtRklETzIg
LUlETjIgLUlETiAtSVBUQyArS01PRCAtTElCQ1JZUFRTRVRVUCArTElCRkRJU0sgLVBDUkUyIC1Q
V1FVQUxJVFkgLVAxMUtJVCAtUVJFTkNPREUgLUJaSVAyIC1MWjQgLVhaIC1aTElCICtaU1REICtY
S0JDT01NT04gK1VUTVAgK1NZU1ZJTklUIGRlZmF1bHQtaGllcmFyY2h5PWh5YnJpZCkKWyAgIDM3
LjMyOTA5MV0gc3lzdGVtZFsxXTogRGV0ZWN0ZWQgYXJjaGl0ZWN0dXJlIGFybTY0LgoKV2VsY29t
ZSB0byBFV0FPTCAoRWRnZSBXb3JrbG9hZCBBYnN0cmFjdGlvbiBhbmQgT3JjaGVzdHJhdGlvbiBM
YXllcikgdW5zdGFibGUgKGhvbmlzdGVyKSEKClsgICAzNy4zOTUxOTldIHN5c3RlbWRbMV06IEhv
c3RuYW1lIHNldCB0byA8Y29taHBjPi4KWyAgIDM3LjQ0MzUzMF0gc3lzdGVtZC1zeXN2LWdlbmVy
YXRvclszMzFdOiBTeXNWIHNlcnZpY2UgJy9ldGMvaW5pdC5kL2Nvbm50cmFja2QnIGxhY2tzIGEg
bmF0aXZlIHN5c3RlbWQgdW5pdCBmaWxlLiBBdXRvbWF0aWNhbGx5IGdlbmVyYXRpbmcgYSB1bml0
IGZpbGUgZm9yIGNvbXBhdGliaWxpdHkuIFBsZWFzZSB1cGRhdGUgcGFja2FnZSB0byBpbmNsdWRl
IGEgbmF0aXZlIHN5c3RlbWQgdW5pdCBmaWxlLCBpbiBvcmRlciB0byBtYWtlIGl0IG1vcmUgc2Fm
ZSBhbmQgcm9idXN0LgpbICAgMzcuNDY3NTQ0XSBzeXN0ZW1kLXN5c3YtZ2VuZXJhdG9yWzMzMV06
IFN5c1Ygc2VydmljZSAnL2V0Yy9pbml0LmQvY29ubnRyYWNrLWZhaWxvdmVyJyBsYWNrcyBhIG5h
dGl2ZSBzeXN0ZW1kIHVuaXQgZmlsZS4gQXV0b21hdGljYWxseSBnZW5lcmF0aW5nIGEgdW5pdCBm
aWxlIGZvciBjb21wYXRpYmlsaXR5LiBQbGVhc2UgdXBkYXRlIHBhY2thZ2UgdG8gaW5jbHVkZSBh
IG5hdGl2ZSBzeXN0ZW1kIHVuaXQgZmlsZSwgaW4gb3JkZXIgdG8gbWFrZSBpdCBtb3JlIHNhZmUg
YW5kIHJvYnVzdC4KWyAgIDM3LjU5NTgwMV0gc3lzdGVtZFsxXTogL2xpYi9zeXN0ZW1kL3N5c3Rl
bS94ZW4tcWVtdS1kb20wLWRpc2stYmFja2VuZC5zZXJ2aWNlOjExOiBQSURGaWxlPSByZWZlcmVu
Y2VzIGEgcGF0aCBiZWxvdyBsZWdhY3kgZGlyZWN0b3J5IC92YXIvcnVuLywgdXBkYXRpbmcgL3Zh
ci9ydW4veGVuL3FlbXUtZG9tMC5waWQg4oaSIC9ydW4veGVuL3FlbXUtZG9tMC5waWQ7IHBsZWFz
ZSB1cGRhdGUgdGhlIHVuaXQgZmlsZSBhY2NvcmRpbmdseS4KWyAgIDM3LjY4MzU5NF0gc3lzdGVt
ZFsxXTogUXVldWVkIHN0YXJ0IGpvYiBmb3IgZGVmYXVsdCB0YXJnZXQgTXVsdGktVXNlciBTeXN0
ZW0uClsgICAzNy42OTExMDFdIHJhbmRvbTogc3lzdGVtZDogdW5pbml0aWFsaXplZCB1cmFuZG9t
IHJlYWQgKDE2IGJ5dGVzIHJlYWQpClsgICAzNy43MjI2ODldIHN5c3RlbWRbMV06IENyZWF0ZWQg
c2xpY2UgU2xpY2UgL3N5c3RlbS9nZXR0eS4KWyAgT0sgIF0gQ3JlYXRlZCBzbGljZSBTbGljZSAv
c3lzdGVtL2dldHR5LgpbICAgMzcuNzQzNDQ1XSByYW5kb206IHN5c3RlbWQ6IHVuaW5pdGlhbGl6
ZWQgdXJhbmRvbSByZWFkICgxNiBieXRlcyByZWFkKQpbICAgMzcuNzUwNzQ4XSBzeXN0ZW1kWzFd
OiBDcmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vbW9kcHJvYmUuClsgIE9LICBdIENyZWF0ZWQg
c2xpY2UgU2xpY2UgL3N5c3RlbS9tb2Rwcm9iZS4KWyAgIDM3Ljc3MTAzMF0gcmFuZG9tOiBzeXN0
ZW1kOiB1bmluaXRpYWxpemVkIHVyYW5kb20gcmVhZCAoMTYgYnl0ZXMgcmVhZCkKWyAgIDM3Ljc3
ODIzNF0gc3lzdGVtZFsxXTogQ3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVtL3NlcmlhbC1nZXR0
eS4KWyAgT0sgIF0gQ3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVtL3NlcmlhbC1nZXR0eS4KWyAg
IDM3Ljc5OTg2N10gc3lzdGVtZFsxXTogQ3JlYXRlZCBzbGljZSBVc2VyIGFuZCBTZXNzaW9uIFNs
aWNlLgpbICBPSyAgXSBDcmVhdGVkIHNsaWNlIFVzZXIgYW5kIFNlc3Npb24gU2xpY2UuClsgICAz
Ny44MTkxODJdIHN5c3RlbWRbMV06IFN0YXJ0ZWQgRGlzcGF0Y2ggUGFzc3dvcmQgUmVxdWVzdHMg
dG8gQ29uc29sZSBEaXJlY3RvcnkgV2F0Y2guClsgIE9LICBdIFN0YXJ0ZWQgRGlzcGF0Y2ggUGFz
c3dvcmQg4oCmdHMgdG8gQ29uc29sZSBEaXJlY3RvcnkgV2F0Y2guClsgICAzNy44NDMxMjRdIHN5
c3RlbWRbMV06IFN0YXJ0ZWQgRm9yd2FyZCBQYXNzd29yZCBSZXF1ZXN0cyB0byBXYWxsIERpcmVj
dG9yeSBXYXRjaC4KWyAgT0sgIF0gU3RhcnRlZCBGb3J3YXJkIFBhc3N3b3JkIFLigKZ1ZXN0cyB0
byBXYWxsIERpcmVjdG9yeSBXYXRjaC4KWyAgIDM3Ljg2NzIyNF0gc3lzdGVtZFsxXTogUmVhY2hl
ZCB0YXJnZXQgUGF0aCBVbml0cy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgUGF0aCBVbml0cy4K
WyAgIDM3Ljg4NzAwNV0gc3lzdGVtZFsxXTogUmVhY2hlZCB0YXJnZXQgUmVtb3RlIEZpbGUgU3lz
dGVtcy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgUmVtb3RlIEZpbGUgU3lzdGVtcy4KWyAgIDM3
LjkwNjk4MV0gc3lzdGVtZFsxXTogUmVhY2hlZCB0YXJnZXQgU2xpY2UgVW5pdHMuClsgIE9LICBd
IFJlYWNoZWQgdGFyZ2V0IFNsaWNlIFVuaXRzLgpbICAgMzcuOTI2OTk2XSBzeXN0ZW1kWzFdOiBS
ZWFjaGVkIHRhcmdldCBTd2Fwcy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU3dhcHMuClsgICAz
Ny45NTE4NjVdIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBSUENiaW5kIFNlcnZlciBBY3RpdmF0
aW9uIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIFJQQ2JpbmQgU2VydmVyIEFjdGl2YXRp
b24gU29ja2V0LgpbICAgMzcuOTc1MTIzXSBzeXN0ZW1kWzFdOiBSZWFjaGVkIHRhcmdldCBSUEMg
UG9ydCBNYXBwZXIuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFJQQyBQb3J0IE1hcHBlci4KWyAg
IDM3Ljk5NTMxN10gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIFN5c2xvZyBTb2NrZXQuClsgIE9L
ICBdIExpc3RlbmluZyBvbiBTeXNsb2cgU29ja2V0LgpbICAgMzguMDE1MTUzXSBzeXN0ZW1kWzFd
OiBMaXN0ZW5pbmcgb24gaW5pdGN0bCBDb21wYXRpYmlsaXR5IE5hbWVkIFBpcGUuClsgIE9LICBd
IExpc3RlbmluZyBvbiBpbml0Y3RsIENvbXBhdGliaWxpdHkgTmFtZWQgUGlwZS4KWyAgIDM4LjA0
MDMxNl0gc3lzdGVtZFsxXTogQ29uZGl0aW9uIGNoZWNrIHJlc3VsdGVkIGluIEpvdXJuYWwgQXVk
aXQgU29ja2V0IGJlaW5nIHNraXBwZWQuClsgICAzOC4wNDg0MjldIHN5c3RlbWRbMV06IExpc3Rl
bmluZyBvbiBKb3VybmFsIFNvY2tldCAoL2Rldi9sb2cpLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24g
Sm91cm5hbCBTb2NrZXQgKC9kZXYvbG9nKS4KWyAgIDM4LjA3MTIyMl0gc3lzdGVtZFsxXTogTGlz
dGVuaW5nIG9uIEpvdXJuYWwgU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gSm91cm5hbCBT
b2NrZXQuClsgICAzOC4wOTEyODhdIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBOZXR3b3JrIFNl
cnZpY2UgTmV0bGluayBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiBOZXR3b3JrIFNlcnZp
Y2UgTmV0bGluayBTb2NrZXQuClsgICAzOC4xMTUyNjNdIHN5c3RlbWRbMV06IExpc3RlbmluZyBv
biB1ZGV2IENvbnRyb2wgU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gdWRldiBDb250cm9s
IFNvY2tldC4KWyAgIDM4LjEzNTE3M10gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIHVkZXYgS2Vy
bmVsIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIHVkZXYgS2VybmVsIFNvY2tldC4KWyAg
IDM4LjE1NTE5N10gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIFVzZXIgRGF0YWJhc2UgTWFuYWdl
ciBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiBVc2VyIERhdGFiYXNlIE1hbmFnZXIgU29j
a2V0LgpbICAgMzguMTgwNTIzXSBzeXN0ZW1kWzFdOiBNb3VudGluZyBIdWdlIFBhZ2VzIEZpbGUg
U3lzdGVtLi4uCiAgICAgICAgIE1vdW50aW5nIEh1Z2UgUGFnZXMgRmlsZSBTeXN0ZW0uLi4KWyAg
IDM4LjIwMDQwOV0gc3lzdGVtZFsxXTogTW91bnRpbmcgUE9TSVggTWVzc2FnZSBRdWV1ZSBGaWxl
IFN5c3RlbS4uLgogICAgICAgICBNb3VudGluZyBQT1NJWCBNZXNzYWdlIFF1ZXVlIEZpbGUgU3lz
dGVtLi4uClsgICAzOC4yMjMwNTRdIHN5c3RlbWRbMV06IENvbmRpdGlvbiBjaGVjayByZXN1bHRl
ZCBpbiBNb3VudCAvcHJvYy94ZW4gZmlsZXMgYmVpbmcgc2tpcHBlZC4KWyAgIDM4LjIzMjE4NF0g
c3lzdGVtZFsxXTogTW91bnRpbmcgS2VybmVsIERlYnVnIEZpbGUgU3lzdGVtLi4uCiAgICAgICAg
IE1vdW50aW5nIEtlcm5lbCBEZWJ1ZyBGaWxlIFN5c3RlbS4uLgpbICAgMzguMjU2NDMwXSBzeXN0
ZW1kWzFdOiBNb3VudGluZyBLZXJuZWwgVHJhY2UgRmlsZSBTeXN0ZW0uLi4KICAgICAgICAgTW91
bnRpbmcgS2VybmVsIFRyYWNlIEZpbGUgU3lzdGVtLi4uClsgICAzOC4yNzc2NDldIHN5c3RlbWRb
MV06IE1vdW50aW5nIFRlbXBvcmFyeSBEaXJlY3RvcnkgL3RtcC4uLgogICAgICAgICBNb3VudGlu
ZyBUZW1wb3JhcnkgRGlyZWN0b3J5IC90bXAuLi4KWyAgIDM4LjI5NjcxMl0gc3lzdGVtZFsxXTog
U3RhcnRpbmcgQ3JlYXRlIExpc3Qgb2YgU3RhdGljIERldmljZSBOb2Rlcy4uLgogICAgICAgICBT
dGFydGluZyBDcmVhdGUgTGlzdCBvZiBTdGF0aWMgRGV2aWNlIE5vZGVzLi4uClsgICAzOC4zMjA0
MDVdIHN5c3RlbWRbMV06IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBjb25maWdmcy4uLgog
ICAgICAgICBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgY29uZmlnZnMuLi4KWyAgIDM4LjM0
MDMzNF0gc3lzdGVtZFsxXTogU3RhcnRpbmcgTG9hZCBLZXJuZWwgTW9kdWxlIGRybS4uLgogICAg
ICAgICBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgZHJtLi4uClsgICAzOC4zNjAzNjBdIHN5
c3RlbWRbMV06IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBmdXNlLi4uCiAgICAgICAgIFN0
YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBmdXNlLi4uClsgICAzOC4zODQ1NzVdIHN5c3RlbWRb
MV06IFN0YXJ0aW5nIFJQQyBCaW5kLi4uCiAgICAgICAgIFN0YXJ0aW5nIFJQQyBCaW5kLi4uClsg
ICAzOC40MDMyNDZdIHN5c3RlbWRbMV06IENvbmRpdGlvbiBjaGVjayByZXN1bHRlZCBpbiBGaWxl
IFN5c3RlbSBDaGVjayBvbiBSb290IERldmljZSBiZWluZyBza2lwcGVkLgpbICAgMzguNDE0MjIy
XSBzeXN0ZW1kWzFdOiBTdGFydGluZyBKb3VybmFsIFNlcnZpY2UuLi4KICAgICAgICAgU3RhcnRp
bmcgSm91cm5hbCBTZXJ2aWNlLi4uClsgICAzOC40MzM2NjRdIHN5c3RlbWRbMV06IFN0YXJ0aW5n
IExvYWQgS2VybmVsIE1vZHVsZXMuLi4KICAgICAgICAgU3RhcnRpbmcgTG9hZCBLZXJuZWwgTW9k
dWxlcy4uLgpbICAgMzguNDUyMTExXSBzeXN0ZW1kWzFdOiBTdGFydGluZyBSZW1vdW50IFJvb3Qg
YW5kIEtlcm5lbCBGaWxlIFN5c3RlbXMuLi4KICAgICAgICAgU3RhcnRpbmcgUmVtb3VudCBSb290
IGFuZCBLZXJuZVsgICAzOC40NjAyNzRdIEVYVDQtZnMgKHNkYTIpOiByZS1tb3VudGVkLiBPcHRz
OiAobnVsbCkKbCBGaWxlIFN5c3RlbXMuLi4KWyAgIDM4LjQ4MDE3N10gc3lzdGVtZFsxXTogU3Rh
cnRpbmcgQ29sZHBsdWcgQWxsIHVkZXYgRGV2aWNlcy4uLgogICAgICAgICBTdGFydGluZyBDb2xk
cGx1ZyBBbGwgdWRldiBEZXZpY2VzLi4uClsgICAzOC41MDA3NzZdIHN5c3RlbWRbMV06IFN0YXJ0
ZWQgUlBDIEJpbmQuClsgIE9LICBdIFN0YXJ0ZWQgUlBDIEJpbmQuClsgICAzOC41MTkxNTVdIHN5
c3RlbWRbMV06IE1vdW50ZWQgSHVnZSBQYWdlcyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91bnRl
ZCBIdWdlIFBhZ2VzIEZpbGUgU3lzdGVtLgpbICAgMzguNTM5NzQ5XSBzeXN0ZW1kWzFdOiBTdGFy
dGVkIEpvdXJuYWwgU2VydmljZS4KWyAgT0sgIF0gU3RhcnRlZCBKb3VybmFsIFNlcnZpY2UuClsg
IE9LICBdIE1vdW50ZWQgUE9TSVggTWVzc2FnZSBRdWV1ZSBGaWxlIFN5c3RlbS4KWyAgT0sgIF0g
TW91bnRlZCBLZXJuZWwgRGVidWcgRmlsZSBTeXN0ZW0uClsgIE9LICBdIE1vdW50ZWQgS2VybmVs
IFRyYWNlIEZpbGUgU3lzdGVtLgpbICBPSyAgXSBNb3VudGVkIFRlbXBvcmFyeSBEaXJlY3Rvcnkg
L3RtcC4KWyAgT0sgIF0gRmluaXNoZWQgQ3JlYXRlIExpc3Qgb2YgU3RhdGljIERldmljZSBOb2Rl
cy4KWyAgT0sgIF0gRmluaXNoZWQgTG9hZCBLZXJuZWwgTW9kdWxlIGNvbmZpZ2ZzLgpbICBPSyAg
XSBGaW5pc2hlZCBMb2FkIEtlcm5lbCBNb2R1bGUgZHJtLgpbICBPSyAgXSBGaW5pc2hlZCBMb2Fk
IEtlcm5lbCBNb2R1bGUgZnVzZS4KWyAgT0sgIF0gRmluaXNoZWQgTG9hZCBLZXJuZWwgTW9kdWxl
cy4KWyAgT0sgIF0gRmluaXNoZWQgUmVtb3VudCBSb290IGFuZCBLZXJuZWwgRmlsZSBTeXN0ZW1z
LgogICAgICAgICBNb3VudGluZyBLZXJuZWwgQ29uZmlndXJhdGlvbiBGaWxlIFN5c3RlbS4uLgog
ICAgICAgICBTdGFydGluZyBGbHVzaCBKb3VybmFsIHRvIFBlcnNpc3RlbnQgU3RvcmFnZS4uLgpb
ICAgMzguNzQ1MTQyXSBzeXN0ZW1kLWpvdXJuYWxkWzM2MV06IFJlY2VpdmVkIGNsaWVudCByZXF1
ZXN0IHRvIGZsdXNoIHJ1bnRpbWUgam91cm5hbC4KICAgICAgICAgU3RhcnRpbmcgQXBwbHkgS2Vy
bmVsIFZhcmlhYmxlcy4uLgogICAgICAgICBTdGFydGluZyBDcmVhdGUgU3RhdGljIERldmljZSBO
b2RlcyBpbiAvZGV2Li4uClsgIE9LICBdIE1vdW50ZWQgS2VybmVsIENvbmZpZ3VyYXRpb24gRmls
ZSBTeXN0ZW0uClsgIE9LICBdIEZpbmlzaGVkIEZsdXNoIEpvdXJuYWwgdG8gUGVyc2lzdGVudCBT
dG9yYWdlLgpbICBPSyAgXSBGaW5pc2hlZCBBcHBseSBLZXJuZWwgVmFyaWFibGVzLgpbICBPSyAg
XSBGaW5pc2hlZCBDb2xkcGx1ZyBBbGwgdWRldiBEZXZpY2VzLgpbICBPSyAgXSBGaW5pc2hlZCBD
cmVhdGUgU3RhdGljIERldmljZSBOb2RlcyBpbiAvZGV2LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdl
dCBQcmVwYXJhdGlvbiBmb3IgTG9jYWwgRmlsZSBTeXN0ZW1zLgogICAgICAgICBNb3VudGluZyAv
dmFyL3ZvbGF0aWxlLi4uCiAgICAgICAgIFN0YXJ0aW5nIFdhaXQgZm9yIHVkZXYgVG8g4oCmcGxl
dGUgRGV2aWNlIEluaXRpYWxpemF0aW9uLi4uCiAgICAgICAgIFN0YXJ0aW5nIFJ1bGUtYmFzZWQg
TWFuYWdl4oCmZm9yIERldmljZSBFdmVudHMgYW5kIEZpbGVzLi4uClsgIE9LICBdIE1vdW50ZWQg
L3Zhci92b2xhdGlsZS4KICAgICAgICAgU3RhcnRpbmcgTG9hZC9TYXZlIFJhbmRvbSBTZWVkLi4u
ClsgIE9LICBdIFN0YXJ0ZWQgUnVsZS1iYXNlZCBNYW5hZ2VyIGZvciBEZXZpY2UgRXZlbnRzIGFu
ZCBGaWxlcy4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIExvYWQvU2F2ZSBSRiDigKZpdGNoIFN0YXR1
cyAvZGV2L3Jma2lsbCBXYXRjaC4KWyAgT0sgIF0gRm91bmQgZGV2aWNlIFNhbkRpc2tfMy4yR2Vu
MSBtc2Rvcy4KICAgICAgICAgTW91bnRpbmcgL2Jvb3QuLi4KWyAgT0sgIF0gTW91bnRlZCAvYm9v
dC4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgTG9jYWwgRmlsZSBTeXN0ZW1zLgogICAgICAgICBT
dGFydGluZyBDcmVhdGUgVm9sYXRpbGUgRmlsZXMgYW5kIERpcmVjdG9yaWVzLi4uClsgIE9LICBd
IEZpbmlzaGVkIFdhaXQgZm9yIHVkZXYgVG8gQ29tcGxldGUgRGV2aWNlIEluaXRpYWxpemF0aW9u
LgpbICBPSyAgXSBGaW5pc2hlZCBDcmVhdGUgVm9sYXRpbGUgRmlsZXMgYW5kIERpcmVjdG9yaWVz
LgpbICBPSyAgXSBTdGFydGVkIEhhcmR3YXJlIFJORyBFbnRyb3B5IEdhdGhlcmVyIERhZW1vbi4K
ICAgICAgICAgU3RhcnRpbmcgTmV0d29yayBUaW1lIFN5bmNocm9uaXphdGlvbi4uLgogICAgICAg
ICBTdGFydGluZyBSZWNvcmQgU3lzdGVtIEJvb3QvU2h1dGRvd24gaW4gVVRNUC4uLgpbICBPSyAg
XSBGaW5pc2hlZCBSZWNvcmQgU3lzdGVtIEJvb3QvU2h1dGRvd24gaW4gVVRNUC4KWyAgT0sgIF0g
U3RhcnRlZCBOZXR3b3JrIFRpbWUgU3luY2hyb25pemF0aW9uLgpbICBPSyAgXSBSZWFjaGVkIHRh
cmdldCBTeXN0ZW0gSW5pdGlhbGl6YXRpb24uClsgIE9LICBdIFN0YXJ0ZWQgRGFpbHkgQ2xlYW51
cCBvZiBUZW1wb3JhcnkgRGlyZWN0b3JpZXMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFN5c3Rl
bSBUaW1lIFNldC4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgVGltZXIgVW5pdHMuClsgIE9LICBd
IExpc3RlbmluZyBvbiBBdmFoaSBtRE5TL0ROUy1TRCBTdGFjayBBY3RpdmF0aW9uIFNvY2tldC4K
WyAgT0sgIF0gTGlzdGVuaW5nIG9uIEQtQnVzIFN5c3RlbSBNZXNzYWdlIEJ1cyBTb2NrZXQuCiAg
ICAgICAgIFN0YXJ0aW5nIERvY2tlciBTb2NrZXQgZm9yIHRoZSBBUEkuLi4KICAgICAgICAgU3Rh
cnRpbmcgc3NoZC5zb2NrZXQuLi4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIERvY2tlciBTb2NrZXQg
Zm9yIHRoZSBBUEkuClsgIE9LICBdIExpc3RlbmluZyBvbiBzc2hkLnNvY2tldC4KWyAgT0sgIF0g
UmVhY2hlZCB0YXJnZXQgU29ja2V0IFVuaXRzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBCYXNp
YyBTeXN0ZW0uCiAgICAgICAgIFN0YXJ0aW5nIEFDUEkgRXZlbnQgRGFlbW9uLi4uClsgIE9LICBd
IFN0YXJ0ZWQgS2VybmVsIExvZ2dpbmcgU2VydmljZS4KWyAgT0sgIF0gU3RhcnRlZCBTeXN0ZW0g
TG9nZ2luZyBTZXJ2aWNlLgpbICBPSyAgXSBTdGFydGVkIEQtQnVzIFN5c3RlbSBNZXNzYWdlIEJ1
cy4KWyAgT0sgIF0gU3RhcnRlZCBHZXR0eSBvbiB0dHkxLgogICAgICAgICBTdGFydGluZyBJUHY2
IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3JrLi4uCiAgICAgICAgIFN0YXJ0aW5nIElQdjQgUGFj
a2V0IEZpbHRlcmluZyBGcmFtZXdvcmsuLi4KICAgICAgICAgU3RhcnRpbmcgVGVsZXBob255IHNl
cnZpY2UuLi4KWyAgT0sgIF0gU3RhcnRlZCBTZXJpYWwgR2V0dHkgb24gdHR5QU1BMC4KWyAgT0sg
IF0gUmVhY2hlZCB0YXJnZXQgTG9naW4gUHJvbXB0cy4KICAgICAgICAgU3RhcnRpbmcgVXNlciBM
b2dpbiBNYW5hZ2VtZW50Li4uCiAgICAgICAgIFN0YXJ0aW5nIE9wZW5TU0ggS2V5IEdlbmVyYXRp
b24uLi4KWyAgT0sgIF0gU3RhcnRlZCBBQ1BJIEV2ZW50IERhZW1vbi4KWyAgT0sgIF0gRmluaXNo
ZWQgSVB2NiBQYWNrZXQgRmlsdGVyaW5nIEZyYW1ld29yay4KWyAgT0sgIF0gRmluaXNoZWQgSVB2
NCBQYWNrZXQgRmlsdGVyaW5nIEZyYW1ld29yay4KWyAgT0sgIF0gRmluaXNoZWQgT3BlblNTSCBL
ZXkgR2VuZXJhdGlvbi4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgUHJlcGFyYXRpb24gZm9yIE5l
dHdvcmsuCiAgICAgICAgIFN0YXJ0aW5nIE5ldHdvcmsgQ29uZmlndXJhdGlvbi4uLgpbICBPSyAg
XSBTdGFydGVkIFVzZXIgTG9naW4gTWFuYWdlbWVudC4KWyAgT0sgIF0gU3RhcnRlZCBUZWxlcGhv
bnkgc2VydmljZS4KWyAgT0sgIF0gU3RhcnRlZCBOZXR3b3JrIENvbmZpZ3VyYXRpb24uCiAgICAg
ICAgIFN0YXJ0aW5nIFdhaXQgZm9yIE5ldHdvcmsgdG8gYmUgQ29uZmlndXJlZC4uLgogICAgICAg
ICBTdGFydGluZyBOZXR3b3JrIE5hbWUgUmVzb2x1dGlvbi4uLgpbICBPSyAgXSBGaW5pc2hlZCBM
b2FkL1NhdmUgUmFuZG9tIFNlZWQuClsgIE9LICBdIFN0YXJ0ZWQgTmV0d29yayBOYW1lIFJlc29s
dXRpb24uClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IE5ldHdvcmsuClsgIE9LICBdIFJlYWNoZWQg
dGFyZ2V0IEhvc3QgYW5kIE5ldHdvcmsgTmFtZSBMb29rdXBzLgogICAgICAgICBTdGFydGluZyBB
dmFoaSBtRE5TL0ROUy1TRCBTdGFjay4uLgogICAgICAgICBTdGFydGluZyBjb250YWluZXJkIGNv
bnRhaW5lciBydW50aW1lLi4uClsgIE9LICBdIFN0YXJ0ZWQgQXZhaGkgbUROUy9ETlMtU0QgU3Rh
Y2suClsgIE9LICBdIFN0YXJ0ZWQgY29udGFpbmVyZCBjb250YWluZXIgcnVudGltZS4KCkVXQU9M
IChFZGdlIFdvcmtsb2FkIEFic3RyYWN0aW9uIGFuZCBPcmNoZXN0cmF0aW9uIExheWVyKSB1bnN0
YWJsZSBjb21ocGMgdHR5QU1BMAoKY29taHBjIGxvZ2luOiAK

--_007_8C5118886183421EA4C7B271DAF46696armcom_
Content-Type: application/octet-stream;
	name="native_linux_boot_without_smmu_debug.log"
Content-Description: native_linux_boot_without_smmu_debug.log
Content-Disposition: attachment;
	filename="native_linux_boot_without_smmu_debug.log"; size=390364;
	creation-date="Thu, 14 Apr 2022 17:44:24 GMT";
	modification-date="Thu, 14 Apr 2022 17:44:24 GMT"
Content-ID: <3E81EAA278352847A9C995EDA622D44C@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogV2VkIEFwciAxMyAxMjoxNToxMCBvbiB0dHlzMDAxCnJhaHNpbjAxQEMwMlpY
MEc5TFZETiB4ODZfNjQgJSB0ZWxuZXQgZTEyMzM0My5jYW1icmlkZ2UuYXJtLmNvbSAxMDAyMApU
cnlpbmcgMTAuMS4xOTQuMjUuLi4KQ29ubmVjdGVkIHRvIGUxMjMzNDMuY2FtYnJpZGdlLmFybS5j
b20uCkVzY2FwZSBjaGFyYWN0ZXIgaXMgJ15dJy4KCkFJUyB0YXJnZXQgc3lzdGVtIHBvcnQgMTAw
MjAgZGV2aWNlIC9kZXYvdHR5VVNCMSBbMTE1MjAwIE44MV0KCgpGUzA6XD4gCkZTMDpcPiBjZCBF
RkkKRlMwOlxFRklcPiBjZCBCT09UCkZTMDpcRUZJXEJPT1RcPiBib290YWE2NC5lZmkKV2VsY29t
ZSB0byBHUlVCIQoKZXJyb3I6IG5vIHN1Y2ggZGV2aWNlOiAoKGhkMCxncHQxKS9FRkkvQk9PVCkv
RUZJL0JPT1QvZ3J1Yi5jZmcuCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgogICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIEdOVSBHUlVCICB2ZXJzaW9uIDIuMDYKCiAvLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LVwKIHwgUEFSVFVVSUQgQm9vdDogQ09NLUhQQyBZb2N0byBJbWFnZSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgfCAKIHwgTlZNZSBNLjIgIFNTRCBCb290OiBDT00tSFBD
IFlvY3RvIEltYWdlICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCpVU0Ig
Qm9vdCAoSWYgRHJpdmUgaXMgcHJlc2VudCk6IENPTS1IUEMgWW9jdG8gSW1hZ2UgICAgICAgICAg
ICAgICAgICAgICAgICB8CiB8IENPTS1IUEMgWW9jdG8gSW1hZ2UgKFhlbikgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHwgCiBcLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS8KCiAgICAgIFVzZSB0aGUg
XiBhbmQgdiBrZXlzIHRvIHNlbGVjdCB3aGljaCBlbnRyeSBpcyBoaWdobGlnaHRlZC4gICAgICAg
ICAgCiAgICAgIFByZXNzIGVudGVyIHRvIGJvb3QgdGhlIHNlbGVjdGVkIE9TLCBgZScgdG8gZWRp
dCB0aGUgY29tbWFuZHMgICAgICAgCiAgICAgIGJlZm9yZSBib290aW5nIG9yIGBjJyBmb3IgYSBj
b21tYW5kLWxpbmUuICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIAoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoK
CgoKCgoKCgoKCgoKCgoKCgoKCgoKCkVGSSBzdHViOiBCb290aW5nIExpbnV4IEtlcm5lbC4uLgpF
Rkkgc3R1YjogVXNpbmcgRFRCIGZyb20gY29uZmlndXJhdGlvbiB0YWJsZQpFRkkgc3R1YjogRXhp
dGluZyBib290IHNlcnZpY2VzIGFuZCBpbnN0YWxsaW5nIHZpcnR1YWwgYWRkcmVzcyBtYXAuLi4K
UFJPR1JFU1MgQ09ERTogVjAzMTAxMDE5IEkwClsgICAgMC4wMDAwMDBdIEJvb3RpbmcgTGludXgg
b24gcGh5c2ljYWwgQ1BVIDB4MDAwMDEwMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwMDAwMF0g
TGludXggdmVyc2lvbiA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrIChvZS11c2VyQG9lLWhv
c3QpIChhYXJjaDY0LXBva3ktbGludXgtZ2NjIChHQ0MpIDExLjIuMCwgR05VIGxkIChHTlUgQmlu
dXRpbHMpIDIuMzcuMjAyMTA3MjEpICMxIFNNUCBQUkVFTVBUIFNhdCBTZXAgMTggMDY6MDE6NTkg
VVRDIDIwMjEKWyAgICAwLjAwMDAwMF0gZWZpOiBFRkkgdjIuNzAgYnkgRURLIElJClsgICAgMC4w
MDAwMDBdIGVmaTogVFBNRmluYWxMb2c9MHg4MDdmOWVmMDAwMCBBQ1BJIDIuMD0weDgwN2ZhMGQw
MDE4IFNNQklPUyAzLjA9MHg4MDdmOGUzMDAwMCBNRU1BVFRSPTB4ODA3Zjc3NGMwMTggRVNSVD0w
eDgwN2Y4MDQ0Mzk4IFRQTUV2ZW50TG9nPTB4ODA3Zjc3NjAwMTggUk5HPTB4ZmZiNGJhOTggTUVN
UkVTRVJWRT0weDgwN2Y3ZWE0ZTk4IApbICAgIDAuMDAwMDAwXSBlZmk6IHNlZWRpbmcgZW50cm9w
eSBwb29sClsgICAgMC4wMDAwMDBdIGVzcnQ6IFJlc2VydmluZyBFU1JUIHNwYWNlIGZyb20gMHgw
MDAwMDgwN2Y4MDQ0Mzk4IHRvIDB4MDAwMDA4MDdmODA0NDNkMC4KWyAgICAwLjAwMDAwMF0gQUNQ
STogRWFybHkgdGFibGUgY2hlY2tzdW0gdmVyaWZpY2F0aW9uIGRpc2FibGVkClsgICAgMC4wMDAw
MDBdIEFDUEk6IFJTRFAgMHgwMDAwMDgwN0ZBMEQwMDE4IDAwMDAyNCAodjAyIEFtcGVyZSkKWyAg
ICAwLjAwMDAwMF0gQUNQSTogWFNEVCAweDAwMDAwODA3RkEwREZFOTggMDAwMEE0ICh2MDEgQW1w
ZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6
IEZBQ1AgMHgwMDAwMDgwN0ZBMERGQjk4IDAwMDExNCAodjA2IEFtcGVyZSBBbHRyYSAgICAwMDAw
MDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBEU0RUIDB4MDAwMDA4MDdG
OERCMDAxOCAwMkMxOUUgKHYwMiBBbXBlcmUgSmFkZSAgICAgMDAwMDAwMDEgSU5UTCAyMDIwMTIx
NykKWyAgICAwLjAwMDAwMF0gQUNQSTogQkVSVCAweDAwMDAwODA3RkEwREZGOTggMDAwMDMwICh2
MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBd
IEFDUEk6IERCRzIgMHgwMDAwMDgwN0ZBMERGQTk4IDAwMDA1QyAodjAwIEFtcGVyZSBBbHRyYSAg
ICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBHVERUIDB4MDAw
MDA4MDdGQTBERTk5OCAwMDAxMTAgKHYwMyBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAw
MTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogU1BDUiAweDAwMDAwODA3RkEwREZFMTggMDAw
MDUwICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4w
MDAwMDBdIEFDUEk6IEVJTkogMHgwMDAwMDgwN0ZBMERGNTk4IDAwMDE1MCAodjAxIEFtcGVyZSBB
bHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAxMjE3KQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBIRVNU
IDB4MDAwMDA4MDdGQTBERUIxOCAwMDAxRjQgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDEg
SU5UTCAyMDIwMTIxNykKWyAgICAwLjAwMDAwMF0gQUNQSTogU1NEVCAweDAwMDAwODA3RkEwREZB
MTggMDAwMDJEICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpClsg
ICAgMC4wMDAwMDBdIEFDUEk6IFRQTTIgMHgwMDAwMDgwN0ZBMERGRDE4IDAwMDA0QyAodjA0IEFt
cGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBNQ0ZHIDB4MDAwMDA4MDdGQTBERjcxOCAwMDAwN0MgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAw
MDAwMDEgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogSU9SVCAweDAwMDAwODA3
RkEwREVGMTggMDAwM0RDICh2MDAgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAw
MTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IEFQSUMgMHgwMDAwMDgwN0ZBMEQ3NTE4IDAwMEFGNCAo
djA1IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAw
XSBBQ1BJOiBQUFRUIDB4MDAwMDA4MDdGQTBEODYxOCAwMDQ1MjAgKHYwMiBBbXBlcmUgQWx0cmEg
ICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogU0xJVCAweDAw
MDAwODA3RkEwREZEOTggMDAwMDJEICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4g
MDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQgMHgwMDAwMDgwN0ZBMERDRTE4IDAw
MDM3MCAodjAzIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBQQ0NUIDB4MDAwMDA4MDdGQTBERTMxOCAwMDA1NzYgKHYwMiBBbXBlcmUg
QWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogU1BD
UjogY29uc29sZTogcGwwMTEsbW1pbzMyLDB4MTAwMDAyNjAwMDAwLDExNTIwMApbICAgIDAuMDAw
MDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDg4MzAwMDAwLTB4ODgzZmZmZmZd
ClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4OTAwMDAwMDAt
MHhmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0g
MHg4MDAwMDAwMDAwMC0weDgwMDdmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBO
b2RlIDAgUFhNIDAgW21lbSAweDgwMTAwMDAwMDAwLTB4ODA3ZmZmZmZmZmZdClsgICAgMC4wMDAw
MDBdIE5VTUE6IE5PREVfREFUQSBbbWVtIDB4ODA3ZmMwNmZlMDAtMHg4MDdmYzA3MWZmZl0KWyAg
ICAwLjAwMDAwMF0gWm9uZSByYW5nZXM6ClsgICAgMC4wMDAwMDBdICAgRE1BICAgICAgW21lbSAw
eDAwMDAwMDAwODgzMDAwMDAtMHgwMDAwMDAwMGZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIERN
QTMyICAgIGVtcHR5ClsgICAgMC4wMDAwMDBdICAgTm9ybWFsICAgW21lbSAweDAwMDAwMDAxMDAw
MDAwMDAtMHgwMDAwMDgwN2ZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSBNb3ZhYmxlIHpvbmUgc3Rh
cnQgZm9yIGVhY2ggbm9kZQpbICAgIDAuMDAwMDAwXSBFYXJseSBtZW1vcnkgbm9kZSByYW5nZXMK
WyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwODgzMDAwMDAtMHgwMDAw
MDAwMDg4M2ZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAwMDA5
MDAwMDAwMC0weDAwMDAwMDAwOTFmZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFtt
ZW0gMHgwMDAwMDAwMDkyMDAwMDAwLTB4MDAwMDAwMDA5MjdiZmZmZl0KWyAgICAwLjAwMDAwMF0g
ICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwOTI3YzAwMDAtMHgwMDAwMDAwMGZmYjNmZmZmXQpb
ICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAwMDBmZmI0MDAwMC0weDAwMDAw
MDAwZmZiNGZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMGZm
YjUwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21l
bSAweDAwMDAwODAwMDAwMDAwMDAtMHgwMDAwMDgwMDdmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSAg
IG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDEwMDAwMDAwMC0weDAwMDAwODA3ZjVlN2ZmZmZdClsg
ICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y1ZTgwMDAwLTB4MDAwMDA4
MDdmNjU0M2ZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjY1
NDQwMDAtMHgwMDAwMDgwN2Y3MWVmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVt
IDB4MDAwMDA4MDdmNzFmMDAwMC0weDAwMDAwODA3ZjcyOGZmZmZdClsgICAgMC4wMDAwMDBdICAg
bm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y3MjkwMDAwLTB4MDAwMDA4MDdmN2U1ZmZmZl0KWyAg
ICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjdlNjAwMDAtMHgwMDAwMDgw
N2Y3ZTdmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmN2U4
MDAwMC0weDAwMDAwODA3ZjdlZGZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0g
MHgwMDAwMDgwN2Y3ZWUwMDAwLTB4MDAwMDA4MDdmN2YxZmZmZl0KWyAgICAwLjAwMDAwMF0gICBu
b2RlICAgMDogW21lbSAweDAwMDAwODA3ZjdmMjAwMDAtMHgwMDAwMDgwN2Y4N2VmZmZmXQpbICAg
IDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmODdmMDAwMC0weDAwMDAwODA3
Zjg4MmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4ODMw
MDAwLTB4MDAwMDA4MDdmOGE2ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAw
eDAwMDAwODA3ZjhhNzAwMDAtMHgwMDAwMDgwN2Y4YWFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5v
ZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOGFiMDAwMC0weDAwMDAwODA3ZjhlMWZmZmZdClsgICAg
MC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4ZTIwMDAwLTB4MDAwMDA4MDdm
OGUzZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjhlNDAw
MDAtMHgwMDAwMDgwN2Y4ZTZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4
MDAwMDA4MDdmOGU3MDAwMC0weDAwMDAwODA3ZjllN2ZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9k
ZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y5ZTgwMDAwLTB4MDAwMDA4MDdmOWVlZmZmZl0KWyAgICAw
LjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjllZjAwMDAtMHgwMDAwMDgwN2Y5
ZjFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOWYyMDAw
MC0weDAwMDAwODA3ZjlmYmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgw
MDAwMDgwN2Y5ZmMwMDAwLTB4MDAwMDA4MDdmOWZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2Rl
ICAgMDogW21lbSAweDAwMDAwODA3ZmEwMDAwMDAtMHgwMDAwMDgwN2ZhMGZmZmZmXQpbICAgIDAu
MDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTEwMDAwMC0weDAwMDAwODA3ZmEx
OWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhMWEwMDAw
LTB4MDAwMDA4MDdmYTI2ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAw
MDAwODA3ZmEyNzAwMDAtMHgwMDAwMDgwN2ZhNGFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUg
ICAwOiBbbWVtIDB4MDAwMDA4MDdmYTRiMDAwMC0weDAwMDAwODA3ZmE3MWZmZmZdClsgICAgMC4w
MDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhNzIwMDAwLTB4MDAwMDA4MDdmYTc1
ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmE3NjAwMDAt
MHgwMDAwMDgwN2ZhOGNmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAw
MDA4MDdmYThkMDAwMC0weDAwMDAwODA3ZmE5NmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAg
IDA6IFttZW0gMHgwMDAwMDgwN2ZhOTcwMDAwLTB4MDAwMDA4MDdmYTlmZmZmZl0KWyAgICAwLjAw
MDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmFhMDAwMDAtMHgwMDAwMDgwN2ZiYWFm
ZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmFiMDAwMC0w
eDAwMDAwODA3ZmJiM2ZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAw
MDgwN2ZiYjQwMDAwLTB4MDAwMDA4MDdmYmJkZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAg
MDogW21lbSAweDAwMDAwODA3ZmJiZTAwMDAtMHgwMDAwMDgwN2ZiY2FmZmZmXQpbICAgIDAuMDAw
MDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmNiMDAwMC0weDAwMDAwODA3ZmJjZWZm
ZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZiY2YwMDAwLTB4
MDAwMDA4MDdmYmQ1ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAw
ODA3ZmJkNjAwMDAtMHgwMDAwMDgwN2ZiZGZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAw
OiBbbWVtIDB4MDAwMDA4MDdmYmUwMDAwMC0weDAwMDAwODA3ZmZmZmZmZmZdClsgICAgMC4wMDAw
MDBdIEluaXRtZW0gc2V0dXAgbm9kZSAwIFttZW0gMHgwMDAwMDAwMDg4MzAwMDAwLTB4MDAwMDA4
MDdmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gcHNjaTogcHJvYmluZyBmb3IgY29uZHVpdCBtZXRo
b2QgZnJvbSBBQ1BJLgpbICAgIDAuMDAwMDAwXSBwc2NpOiBQU0NJdjEuMSBkZXRlY3RlZCBpbiBm
aXJtd2FyZS4KWyAgICAwLjAwMDAwMF0gcHNjaTogVXNpbmcgc3RhbmRhcmQgUFNDSSB2MC4yIGZ1
bmN0aW9uIElEcwpbICAgIDAuMDAwMDAwXSBwc2NpOiBNSUdSQVRFX0lORk9fVFlQRSBub3Qgc3Vw
cG9ydGVkLgpbICAgIDAuMDAwMDAwXSBwc2NpOiBTTUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjIK
WyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHg4MDAwMCAt
PiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIg
MHg4MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAg
LT4gTVBJRFIgMHg5MDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JB
VDogUFhNIDAgLT4gTVBJRFIgMHg5MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTog
TlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHhlMDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAw
MF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHhlMDEwMCAtPiBOb2RlIDAKWyAg
ICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHhmMDAwMCAtPiBO
b2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHhm
MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4g
TVBJRFIgMHgxMDAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6
IFBYTSAwIC0+IE1QSURSIDB4MTAwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBO
VU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDExMDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAw
MF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxMTAxMDAgLT4gTm9kZSAwClsg
ICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTYwMDAwIC0+
IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAw
eDE2MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAg
LT4gTVBJRFIgMHgxNzAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNS
QVQ6IFBYTSAwIC0+IE1QSURSIDB4MTcwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE4MDAwMCAtPiBOb2RlIDAKWyAgICAwLjAw
MDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxODAxMDAgLT4gTm9kZSAw
ClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTkwMDAw
IC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElE
UiAweDE5MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhN
IDAgLT4gTVBJRFIgMHgxZTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6
IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MWUwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBB
Q1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDFmMDAwMCAtPiBOb2RlIDAKWyAgICAw
LjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxZjAxMDAgLT4gTm9k
ZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MjAw
MDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBN
UElEUiAweDIwMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDog
UFhNIDAgLT4gTVBJRFIgMHgyMTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5V
TUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MjEwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAw
XSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDI2MDAwMCAtPiBOb2RlIDAKWyAg
ICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgyNjAxMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
MjcwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAt
PiBNUElEUiAweDI3MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gcGVyY3B1OiBFbWJlZGRl
ZCAzMSBwYWdlcy9jcHUgczg5MjQwIHI4MTkyIGQyOTU0NCB1MTI2OTc2ClsgICAgMC4wMDAwMDBd
IERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUwClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJl
czogZGV0ZWN0ZWQ6IEdJQyBzeXN0ZW0gcmVnaXN0ZXIgQ1BVIGludGVyZmFjZQpbICAgIDAuMDAw
MDAwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBWaXJ0dWFsaXphdGlvbiBIb3N0IEV4dGVuc2lv
bnMKWyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogSGFyZHdhcmUgZGlydHkg
Yml0IG1hbmFnZW1lbnQKWyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3Bl
Y3RyZS12NApbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBBUk0gZXJyYXR1
bSAxNDE4MDQwClsgICAgMC4wMDAwMDBdIGFsdGVybmF0aXZlczogcGF0Y2hpbmcga2VybmVsIGNv
ZGUKWyAgICAwLjAwMDAwMF0gQnVpbHQgMSB6b25lbGlzdHMsIG1vYmlsaXR5IGdyb3VwaW5nIG9u
LiAgVG90YWwgcGFnZXM6IDgxOTMyNzYKWyAgICAwLjAwMDAwMF0gUG9saWN5IHpvbmU6IE5vcm1h
bApbICAgIDAuMDAwMDAwXSBLZXJuZWwgY29tbWFuZCBsaW5lOiBCT09UX0lNQUdFPS9JbWFnZSBy
b290d2FpdCBydyByb290PS9kZXYvc2RhMgpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZf
bGVuIGluZGl2aWR1YWwgbWF4IGNwdSBjb250cmlidXRpb246IDQwOTYgYnl0ZXMKWyAgICAwLjAw
MDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbiB0b3RhbCBjcHVfZXh0cmEgY29udHJpYnV0aW9uczog
MTI2OTc2IGJ5dGVzClsgICAgMC4wMDAwMDBdIHByaW50azogbG9nX2J1Zl9sZW4gbWluIHNpemU6
IDEzMTA3MiBieXRlcwpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVuOiAyNjIxNDQg
Ynl0ZXMKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBlYXJseSBsb2cgYnVmIGZyZWU6IDEyMTI0OCg5
MiUpClsgICAgMC4wMDAwMDBdIERlbnRyeSBjYWNoZSBoYXNoIHRhYmxlIGVudHJpZXM6IDQxOTQz
MDQgKG9yZGVyOiAxMywgMzM1NTQ0MzIgYnl0ZXMsIGxpbmVhcikKWyAgICAwLjAwMDAwMF0gSW5v
ZGUtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAyMDk3MTUyIChvcmRlcjogMTIsIDE2Nzc3MjE2
IGJ5dGVzLCBsaW5lYXIpClsgICAgMC4wMDAwMDBdIG1lbSBhdXRvLWluaXQ6IHN0YWNrOm9mZiwg
aGVhcCBhbGxvYzpvZmYsIGhlYXAgZnJlZTpvZmYKWyAgICAwLjAwMDAwMF0gc29mdHdhcmUgSU8g
VExCOiBtYXBwZWQgW21lbSAweDAwMDAwMDAwZmJiNDAwMDAtMHgwMDAwMDAwMGZmYjQwMDAwXSAo
NjRNQikKWyAgICAwLjAwMDAwMF0gTWVtb3J5OiAzMjUwMjE4MEsvMzMyOTMzMTJLIGF2YWlsYWJs
ZSAoMTM1NjhLIGtlcm5lbCBjb2RlLCAxOTk2SyByd2RhdGEsIDM0NzZLIHJvZGF0YSwgNDE2MEsg
aW5pdCwgODIySyBic3MsIDc5MTEzMksgcmVzZXJ2ZWQsIDBLIGNtYS1yZXNlcnZlZCkKWyAgICAw
LjAwMDAwMF0gU0xVQjogSFdhbGlnbj02NCwgT3JkZXI9MC0zLCBNaW5PYmplY3RzPTAsIENQVXM9
MzIsIE5vZGVzPTEKWyAgICAwLjAwMDAwMF0gZnRyYWNlOiBhbGxvY2F0aW5nIDQxMzA2IGVudHJp
ZXMgaW4gMTYyIHBhZ2VzClsgICAgMC4wMDAwMDBdIGZ0cmFjZTogYWxsb2NhdGVkIDE2MiBwYWdl
cyB3aXRoIDMgZ3JvdXBzClsgICAgMC4wMDAwMDBdIHJjdTogUHJlZW1wdGlibGUgaGllcmFyY2hp
Y2FsIFJDVSBpbXBsZW1lbnRhdGlvbi4KWyAgICAwLjAwMDAwMF0gcmN1OiAJUkNVIGV2ZW50IHRy
YWNpbmcgaXMgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gcmN1OiAJUkNVIHJlc3RyaWN0aW5nIENQ
VXMgZnJvbSBOUl9DUFVTPTI1NiB0byBucl9jcHVfaWRzPTMyLgpbICAgIDAuMDAwMDAwXSAJVHJh
bXBvbGluZSB2YXJpYW50IG9mIFRhc2tzIFJDVSBlbmFibGVkLgpbICAgIDAuMDAwMDAwXSAJUnVk
ZSB2YXJpYW50IG9mIFRhc2tzIFJDVSBlbmFibGVkLgpbICAgIDAuMDAwMDAwXSAJVHJhY2luZyB2
YXJpYW50IG9mIFRhc2tzIFJDVSBlbmFibGVkLgpbICAgIDAuMDAwMDAwXSByY3U6IFJDVSBjYWxj
dWxhdGVkIHZhbHVlIG9mIHNjaGVkdWxlci1lbmxpc3RtZW50IGRlbGF5IGlzIDI1IGppZmZpZXMu
ClsgICAgMC4wMDAwMDBdIHJjdTogQWRqdXN0aW5nIGdlb21ldHJ5IGZvciByY3VfZmFub3V0X2xl
YWY9MTYsIG5yX2NwdV9pZHM9MzIKWyAgICAwLjAwMDAwMF0gTlJfSVJRUzogNjQsIG5yX2lycXM6
IDY0LCBwcmVhbGxvY2F0ZWQgaXJxczogMApbICAgIDAuMDAwMDAwXSBHSUN2MzogR0lDOiBVc2lu
ZyBzcGxpdCBFT0kvRGVhY3RpdmF0ZSBtb2RlClsgICAgMC4wMDAwMDBdIEdJQ3YzOiA2NzIgU1BJ
cyBpbXBsZW1lbnRlZApbICAgIDAuMDAwMDAwXSBHSUN2MzogMCBFeHRlbmRlZCBTUElzIGltcGxl
bWVudGVkClsgICAgMC4wMDAwMDBdIEdJQ3YzOiBEaXN0cmlidXRvciBoYXMgbm8gUmFuZ2UgU2Vs
ZWN0b3Igc3VwcG9ydApbICAgIDAuMDAwMDAwXSBHSUN2MzogMTYgUFBJcyBpbXBsZW1lbnRlZApb
ICAgIDAuMDAwMDAwXSBHSUN2MzogQ1BVMDogZm91bmQgcmVkaXN0cmlidXRvciAxMDAwMDAgcmVn
aW9uIDA6MHgwMDAwMTAwMTAwNTQwMDAwClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElU
UyAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMSAtPiBOb2Rl
IDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDIgLT4gTm9kZSAwClsgICAgMC4w
MDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyAzIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBTUkFU
OiBQWE0gMCAtPiBJVFMgNCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4g
SVRTIDUgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA2IC0+IE5v
ZGUgMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNyAtPiBOb2RlIDAKWyAgICAw
LjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwNDAwMDAtMHgxMDAxMDAwNWZmZmZdClsgICAgMC4w
MDAwMDBdIElUU0AweDAwMDAxMDAxMDAwNDAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgw
MDAwMjIwMDAwIChpbmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAw
XSBJVFNAMHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxl
Y3Rpb25zIEA4MDAwMDIzMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAu
MDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDA2MDAwMC0weDEwMDEwMDA3ZmZmZl0KWyAgICAwLjAw
MDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA2MDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAw
MDAyNTAwMDAgKGluZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBd
IElUU0AweDAwMDAxMDAxMDAwNjAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVj
dGlvbnMgQDgwMDAwMjYwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4w
MDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMDgwMDAwLTB4MTAwMTAwMDlmZmZmXQpbICAgIDAuMDAw
MDAwXSBJVFNAMHgwMDAwMTAwMTAwMDgwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAw
MDI4MDAwMCAoaW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0g
SVRTQDB4MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0
aW9ucyBAODAwMDAyOTAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAw
MDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwYTAwMDAtMHgxMDAxMDAwYmZmZmZdClsgICAgMC4wMDAw
MDBdIElUU0AweDAwMDAxMDAxMDAwYTAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAw
MmIwMDAwIChpbmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJ
VFNAMHgwMDAwMTAwMTAwMGEwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rp
b25zIEA4MDAwMDJjMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAw
MDAwXSBJVFMgW21lbSAweDEwMDEwMDBjMDAwMC0weDEwMDEwMDBkZmZmZl0KWyAgICAwLjAwMDAw
MF0gSVRTQDB4MDAwMDEwMDEwMDBjMDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAy
ZTAwMDAgKGluZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElU
U0AweDAwMDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlv
bnMgQDgwMDAwMmYwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAw
MDBdIElUUyBbbWVtIDB4MTAwMTAwMGUwMDAwLTB4MTAwMTAwMGZmZmZmXQpbICAgIDAuMDAwMDAw
XSBJVFNAMHgwMDAwMTAwMTAwMGUwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDMx
MDAwMCAoaW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRT
QDB4MDAwMDEwMDEwMDBlMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9u
cyBAODAwMDAzMjAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAw
MF0gSVRTIFttZW0gMHgxMDAxMDAxMDAwMDAtMHgxMDAxMDAxMWZmZmZdClsgICAgMC4wMDAwMDBd
IElUU0AweDAwMDAxMDAxMDAxMDAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMzQw
MDAwIChpbmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNA
MHgwMDAwMTAwMTAwMTAwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25z
IEA4MDAwMDM1MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAw
XSBJVFMgW21lbSAweDEwMDEwMDEyMDAwMC0weDEwMDEwMDEzZmZmZl0KWyAgICAwLjAwMDAwMF0g
SVRTQDB4MDAwMDEwMDEwMDEyMDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAzNzAw
MDAgKGluZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0Aw
eDAwMDAxMDAxMDAxMjAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMg
QDgwMDAwMzgwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBd
IEdJQ3YzOiB1c2luZyBMUEkgcHJvcGVydHkgdGFibGUgQDB4MDAwMDA4MDAwMDM5MDAwMApbICAg
IDAuMDAwMDAwXSBHSUN2MzogQ1BVMDogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDAzYTAwMDAKWyAgICAwLjAwMDAwMF0gcmFuZG9tOiBnZXRfcmFuZG9tX2J5
dGVzIGNhbGxlZCBmcm9tIHN0YXJ0X2tlcm5lbCsweDM5NC8weDU1NCB3aXRoIGNybmdfaW5pdD0w
ClsgICAgMC4wMDAwMDBdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9y
IEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwMDAwMF0gQUNQSSBHVERUOiBmb3VuZCAxIG1l
bW9yeS1tYXBwZWQgdGltZXIgYmxvY2socykuClsgICAgMC4wMDAwMDBdIGFyY2hfdGltZXI6IGNw
MTUgYW5kIG1taW8gdGltZXIocykgcnVubmluZyBhdCAyNS4wME1IeiAocGh5cy9waHlzKS4KWyAg
ICAwLjAwMDAwMF0gY2xvY2tzb3VyY2U6IGFyY2hfc3lzX2NvdW50ZXI6IG1hc2s6IDB4ZmZmZmZm
ZmZmZmZmZmYgbWF4X2N5Y2xlczogMHg1YzQwOTM5YjUsIG1heF9pZGxlX25zOiA0NDA3OTUyMDI2
NDYgbnMKWyAgICAwLjAwMDAwMV0gc2NoZWRfY2xvY2s6IDU2IGJpdHMgYXQgMjVNSHosIHJlc29s
dXRpb24gNDBucywgd3JhcHMgZXZlcnkgNDM5ODA0NjUxMTEwMG5zClsgICAgMC4wMDAwNTRdIENv
bnNvbGU6IGNvbG91ciBkdW1teSBkZXZpY2UgODB4MjUKWyAgICAwLjAwMDA3NF0gQUNQSTogQ29y
ZSByZXZpc2lvbiAyMDIwMDkyNQpbICAgIDAuMDAwNDg2XSBDYWxpYnJhdGluZyBkZWxheSBsb29w
IChza2lwcGVkKSwgdmFsdWUgY2FsY3VsYXRlZCB1c2luZyB0aW1lciBmcmVxdWVuY3kuLiA1MC4w
MCBCb2dvTUlQUyAobHBqPTEwMDAwMCkKWyAgICAwLjAwMDQ5MV0gcGlkX21heDogZGVmYXVsdDog
MzI3NjggbWluaW11bTogMzAxClsgICAgMC4wMDA1MjBdIExTTTogU2VjdXJpdHkgRnJhbWV3b3Jr
IGluaXRpYWxpemluZwpbICAgIDAuMDAwNjQ4XSBNb3VudC1jYWNoZSBoYXNoIHRhYmxlIGVudHJp
ZXM6IDY1NTM2IChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIpClsgICAgMC4wMDA3MzBd
IE1vdW50cG9pbnQtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDcsIDUy
NDI4OCBieXRlcywgbGluZWFyKQpbICAgIDAuMDAxNTgxXSByY3U6IEhpZXJhcmNoaWNhbCBTUkNV
IGltcGxlbWVudGF0aW9uLgpbICAgIDAuMDAxNzA5XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEw
MDA0MDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAuMDAxNzEzXSBQbGF0Zm9ybSBNU0k6IElUU0Aw
eDEwMDEwMDA2MDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAuMDAxNzE2XSBQbGF0Zm9ybSBNU0k6
IElUU0AweDEwMDEwMDA4MDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAuMDAxNzE4XSBQbGF0Zm9y
bSBNU0k6IElUU0AweDEwMDEwMDBhMDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAuMDAxNzIyXSBQ
bGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDBjMDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAuMDAx
NzI0XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDBlMDAwMCBkb21haW4gY3JlYXRlZApbICAg
IDAuMDAxNzI4XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDEwMDAwMCBkb21haW4gY3JlYXRl
ZApbICAgIDAuMDAxNzMyXSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDEyMDAwMCBkb21haW4g
Y3JlYXRlZApbICAgIDAuMDAxNzM4XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwNDAwMDAgZG9tYWlu
IGNyZWF0ZWQKWyAgICAwLjAwMTc0Ml0gUENJL01TSTogSVRTQDB4MTAwMTAwMDYwMDAwIGRvbWFp
biBjcmVhdGVkClsgICAgMC4wMDE3NDRdIFBDSS9NU0k6IElUU0AweDEwMDEwMDA4MDAwMCBkb21h
aW4gY3JlYXRlZApbICAgIDAuMDAxNzQ3XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwYTAwMDAgZG9t
YWluIGNyZWF0ZWQKWyAgICAwLjAwMTc1MF0gUENJL01TSTogSVRTQDB4MTAwMTAwMGMwMDAwIGRv
bWFpbiBjcmVhdGVkClsgICAgMC4wMDE3NTNdIFBDSS9NU0k6IElUU0AweDEwMDEwMDBlMDAwMCBk
b21haW4gY3JlYXRlZApbICAgIDAuMDAxNzU2XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAxMDAwMDAg
ZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTc2MF0gUENJL01TSTogSVRTQDB4MTAwMTAwMTIwMDAw
IGRvbWFpbiBjcmVhdGVkClsgICAgMC4wMDE3NjZdIFJlbWFwcGluZyBhbmQgZW5hYmxpbmcgRUZJ
IHNlcnZpY2VzLgpbICAgIDAuMDAzNjEyXSBzbXA6IEJyaW5naW5nIHVwIHNlY29uZGFyeSBDUFVz
IC4uLgpbICAgIDAuMDAzODYyXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMQpbICAgIDAu
MDAzODkxXSBHSUN2MzogQ1BVMTogZm91bmQgcmVkaXN0cmlidXRvciAxODAwMDAgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwNzQwMDAwClsgICAgMC4wMDM5MTVdIEdJQ3YzOiBDUFUxOiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNiMDAwMApbICAgIDAuMDAzOTYw
XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAx
NDE4MDQwClsgICAgMC4wMDM5NzNdIENQVTE6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4
MDAwMDE4MDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNDI1N10gRGV0ZWN0ZWQgUElQVCBJLWNh
Y2hlIG9uIENQVTIKWyAgICAwLjAwNDI4NF0gR0lDdjM6IENQVTI6IGZvdW5kIHJlZGlzdHJpYnV0
b3IgMTYwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDZjMDAwMApbICAgIDAuMDA0MzA4XSBHSUN2
MzogQ1BVMjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAz
YzAwMDAKWyAgICAwLjAwNDM1NV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3Vu
ZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA0MzY5XSBDUFUyOiBCb290ZWQgc2Vj
b25kYXJ5IHByb2Nlc3NvciAweDAwMDAxNjAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDQ2NThd
IERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUzClsgICAgMC4wMDQ2ODZdIEdJQ3YzOiBDUFUz
OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDFlMDAwMCByZWdpb24gMDoweDAwMDAxMDAxMDA4YzAwMDAK
WyAgICAwLjAwNDcxMV0gR0lDdjM6IENQVTM6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0
YWJsZSBAMHgwMDAwMDgwMDAwM2QwMDAwClsgICAgMC4wMDQ3NTldIGFyY2hfdGltZXI6IEVuYWJs
aW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwNDc3
NF0gQ1BVMzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMWUwMDAwIFsweDQxM2Zk
MGMxXQpbICAgIDAuMDA1MDUwXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVNApbICAgIDAu
MDA1MDY5XSBHSUN2MzogQ1BVNDogZm91bmQgcmVkaXN0cmlidXRvciA4MDAwMCByZWdpb24gMDow
eDAwMDAxMDAxMDAzNDAwMDAKWyAgICAwLjAwNTA5NV0gR0lDdjM6IENQVTQ6IHVzaW5nIGFsbG9j
YXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2UwMDAwClsgICAgMC4wMDUxNDNd
IGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0
MTgwNDAKWyAgICAwLjAwNTE1Nl0gQ1BVNDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgw
MDAwMDgwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA1NDYxXSBEZXRlY3RlZCBQSVBUIEktY2Fj
aGUgb24gQ1BVNQpbICAgIDAuMDA1NDkwXSBHSUN2MzogQ1BVNTogZm91bmQgcmVkaXN0cmlidXRv
ciAyMDAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOTQwMDAwClsgICAgMC4wMDU1MTRdIEdJQ3Yz
OiBDUFU1OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNm
MDAwMApbICAgIDAuMDA1NTYxXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5k
IGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDU1NzddIENQVTU6IEJvb3RlZCBzZWNv
bmRhcnkgcHJvY2Vzc29yIDB4MDAwMDIwMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNTg1M10g
RGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTYKWyAgICAwLjAwNTg3Nl0gR0lDdjM6IENQVTY6
IGZvdW5kIHJlZGlzdHJpYnV0b3IgZTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNGMwMDAwClsg
ICAgMC4wMDU5MDFdIEdJQ3YzOiBDUFU2OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFi
bGUgQDB4MDAwMDA4MDAwMDgwMDAwMApbICAgIDAuMDA1OTUyXSBhcmNoX3RpbWVyOiBFbmFibGlu
ZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDU5NjRd
IENQVTY6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDBlMDAwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAwNjI2N10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTcKWyAgICAwLjAw
NjI5OV0gR0lDdjM6IENQVTc6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjYwMDAwIHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMGFjMDAwMApbICAgIDAuMDA2MzI1XSBHSUN2MzogQ1BVNzogdXNpbmcgYWxsb2Nh
dGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4MTAwMDAKWyAgICAwLjAwNjM3NF0g
YXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQx
ODA0MApbICAgIDAuMDA2MzkwXSBDUFU3OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAw
MDAyNjAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDY2NjRdIERldGVjdGVkIFBJUFQgSS1jYWNo
ZSBvbiBDUFU4ClsgICAgMC4wMDY2ODhdIEdJQ3YzOiBDUFU4OiBmb3VuZCByZWRpc3RyaWJ1dG9y
IDExMDAwMCByZWdpb24gMDoweDAwMDAxMDAxMDA1ODAwMDAKWyAgICAwLjAwNjcxM10gR0lDdjM6
IENQVTg6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODIw
MDAwClsgICAgMC4wMDY3NjBdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQg
Zm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwNjc3Ml0gQ1BVODogQm9vdGVkIHNlY29u
ZGFyeSBwcm9jZXNzb3IgMHgwMDAwMTEwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA3MDU4XSBE
ZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVOQpbICAgIDAuMDA3MDg0XSBHSUN2MzogQ1BVOTog
Zm91bmQgcmVkaXN0cmlidXRvciAxOTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNzgwMDAwClsg
ICAgMC4wMDcxMTBdIEdJQ3YzOiBDUFU5OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFi
bGUgQDB4MDAwMDA4MDAwMDgzMDAwMApbICAgIDAuMDA3MTU3XSBhcmNoX3RpbWVyOiBFbmFibGlu
ZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDcxNzJd
IENQVTk6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDE5MDAwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAwNzQ1M10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEwClsgICAgMC4w
MDc0NzldIEdJQ3YzOiBDUFUxMDogZm91bmQgcmVkaXN0cmlidXRvciAxNzAwMDAgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwNzAwMDAwClsgICAgMC4wMDc1MDVdIEdJQ3YzOiBDUFUxMDogdXNpbmcgYWxs
b2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4NDAwMDAKWyAgICAwLjAwNzU1
M10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0g
MTQxODA0MApbICAgIDAuMDA3NTY5XSBDUFUxMDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3Ig
MHgwMDAwMTcwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA3ODUxXSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVMTEKWyAgICAwLjAwNzg4MF0gR0lDdjM6IENQVTExOiBmb3VuZCByZWRpc3Ry
aWJ1dG9yIDFmMDAwMCByZWdpb24gMDoweDAwMDAxMDAxMDA5MDAwMDAKWyAgICAwLjAwNzkwN10g
R0lDdjM6IENQVTExOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4
MDAwMDg1MDAwMApbICAgIDAuMDA3OTU0XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3Jr
YXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDc5NzJdIENQVTExOiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxZjAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4w
MDgzMzJdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxMgpbICAgIDAuMDA4MzUzXSBHSUN2
MzogQ1BVMTI6IGZvdW5kIHJlZGlzdHJpYnV0b3IgOTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
MzgwMDAwClsgICAgMC4wMDgzNzldIEdJQ3YzOiBDUFUxMjogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4NjAwMDAKWyAgICAwLjAwODQyNl0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDA4NDQ1XSBDUFUxMjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDkwMDAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDA4NzM5XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MTMKWyAgICAwLjAwODc2OF0gR0lDdjM6IENQVTEzOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDIxMDAw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA5ODAwMDAKWyAgICAwLjAwODc5NV0gR0lDdjM6IENQVTEz
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDg3MDAwMApb
ICAgIDAuMDA4ODM5XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDg4NTddIENQVTEzOiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAyMTAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDkxNTBdIERldGVj
dGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxNApbICAgIDAuMDA5MTczXSBHSUN2MzogQ1BVMTQ6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgZjAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNTAwMDAwClsgICAg
MC4wMDkyMDBdIEdJQ3YzOiBDUFUxNDogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDA4ODAwMDAKWyAgICAwLjAwOTI0OV0gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA5MjY3XSBD
UFUxNDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMGYwMDAwIFsweDQxM2ZkMGMx
XQpbICAgIDAuMDA5NzIzXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTUKWyAgICAwLjAw
OTc1NF0gR0lDdjM6IENQVTE1OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDI3MDAwMCByZWdpb24gMDow
eDAwMDAxMDAxMDBiMDAwMDAKWyAgICAwLjAwOTc4Ml0gR0lDdjM6IENQVTE1OiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDg5MDAwMApbICAgIDAuMDA5ODMy
XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAx
NDE4MDQwClsgICAgMC4wMDk4NTFdIENQVTE1OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAyNzAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTAxNDNdIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUxNgpbICAgIDAuMDEwMTY3XSBHSUN2MzogQ1BVMTY6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMTAwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDU2MDAwMApbICAgIDAuMDEwMTkzXSBH
SUN2MzogQ1BVMTY6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwOGEwMDAwClsgICAgMC4wMTAyNDFdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxMDI2MF0gQ1BVMTY6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDEwMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAx
MDU1Nl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE3ClsgICAgMC4wMTA1ODNdIEdJQ3Yz
OiBDUFUxNzogZm91bmQgcmVkaXN0cmlidXRvciAxODAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
NzYwMDAwClsgICAgMC4wMTA2MTFdIEdJQ3YzOiBDUFUxNzogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4YjAwMDAKWyAgICAwLjAxMDY1N10gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDEwNjc2XSBDUFUxNzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMTgwMTAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDEwOTcxXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MTgKWyAgICAwLjAxMDk5N10gR0lDdjM6IENQVTE4OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDE2MDEw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA2ZTAwMDAKWyAgICAwLjAxMTAyNV0gR0lDdjM6IENQVTE4
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhjMDAwMApb
ICAgIDAuMDExMDczXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTEwOTJdIENQVTE4OiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAxNjAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTE1NDhdIERldGVj
dGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxOQpbICAgIDAuMDExNTc3XSBHSUN2MzogQ1BVMTk6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgMWUwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDhlMDAwMApbICAg
IDAuMDExNjA2XSBHSUN2MzogQ1BVMTk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwMDAwOGQwMDAwClsgICAgMC4wMTE2NTRdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxMTY3NF0g
Q1BVMTk6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDFlMDEwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAxMjA0MV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTIwClsgICAgMC4w
MTIwNjJdIEdJQ3YzOiBDUFUyMDogZm91bmQgcmVkaXN0cmlidXRvciA4MDEwMCByZWdpb24gMDow
eDAwMDAxMDAxMDAzNjAwMDAKWyAgICAwLjAxMjA5MF0gR0lDdjM6IENQVTIwOiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhlMDAwMApbICAgIDAuMDEyMTM5
XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAx
NDE4MDQwClsgICAgMC4wMTIxNTVdIENQVTIwOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAwODAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTI1NDJdIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUyMQpbICAgIDAuMDEyNTcyXSBHSUN2MzogQ1BVMjE6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMjAwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDk2MDAwMApbICAgIDAuMDEyNjAyXSBH
SUN2MzogQ1BVMjE6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwOGYwMDAwClsgICAgMC4wMTI2NDldIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxMjY2OF0gQ1BVMjE6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDIwMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAx
Mjk2N10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTIyClsgICAgMC4wMTI5OTBdIEdJQ3Yz
OiBDUFUyMjogZm91bmQgcmVkaXN0cmlidXRvciBlMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA0
ZTAwMDAKWyAgICAwLjAxMzAyMV0gR0lDdjM6IENQVTIyOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDkwMDAwMApbICAgIDAuMDEzMDcwXSBhcmNoX3RpbWVy
OiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAg
MC4wMTMwOTJdIENQVTIyOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwZTAxMDAg
WzB4NDEzZmQwYzFdClsgICAgMC4wMTM1MzldIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUy
MwpbICAgIDAuMDEzNTcyXSBHSUN2MzogQ1BVMjM6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjYwMTAw
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMGFlMDAwMApbICAgIDAuMDEzNjAyXSBHSUN2MzogQ1BVMjM6
IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTEwMDAwClsg
ICAgMC4wMTM2NDldIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxMzY3MV0gQ1BVMjM6IEJvb3RlZCBzZWNvbmRhcnkg
cHJvY2Vzc29yIDB4MDAwMDI2MDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAxMzk2OV0gRGV0ZWN0
ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI0ClsgICAgMC4wMTM5OTNdIEdJQ3YzOiBDUFUyNDogZm91
bmQgcmVkaXN0cmlidXRvciAxMTAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNWEwMDAwClsgICAg
MC4wMTQwMjNdIEdJQ3YzOiBDUFUyNDogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDA5MjAwMDAKWyAgICAwLjAxNDA3MF0gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDE0MDkxXSBD
UFUyNDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMTEwMTAwIFsweDQxM2ZkMGMx
XQpbICAgIDAuMDE0NTMwXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjUKWyAgICAwLjAx
NDU1N10gR0lDdjM6IENQVTI1OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDE5MDEwMCByZWdpb24gMDow
eDAwMDAxMDAxMDA3YTAwMDAKWyAgICAwLjAxNDU4Nl0gR0lDdjM6IENQVTI1OiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDkzMDAwMApbICAgIDAuMDE0NjMz
XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAx
NDE4MDQwClsgICAgMC4wMTQ2NTRdIENQVTI1OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAxOTAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTQ5NjBdIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUyNgpbICAgIDAuMDE0OTg3XSBHSUN2MzogQ1BVMjY6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMTcwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDcyMDAwMApbICAgIDAuMDE1MDE4XSBH
SUN2MzogQ1BVMjY6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwOTQwMDAwClsgICAgMC4wMTUwNjddIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNTA4OV0gQ1BVMjY6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDE3MDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAx
NTU0NV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI3ClsgICAgMC4wMTU1NzVdIEdJQ3Yz
OiBDUFUyNzogZm91bmQgcmVkaXN0cmlidXRvciAxZjAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
OTIwMDAwClsgICAgMC4wMTU2MDZdIEdJQ3YzOiBDUFUyNzogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA5NTAwMDAKWyAgICAwLjAxNTY1MV0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDE1NjczXSBDUFUyNzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMWYwMTAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDE1OTYzXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MjgKWyAgICAwLjAxNTk4NF0gR0lDdjM6IENQVTI4OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDkwMTAw
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDNhMDAwMApbICAgIDAuMDE2MDE1XSBHSUN2MzogQ1BVMjg6
IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTYwMDAwClsg
ICAgMC4wMTYwNjNdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNjA4NV0gQ1BVMjg6IEJvb3RlZCBzZWNvbmRhcnkg
cHJvY2Vzc29yIDB4MDAwMDA5MDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAxNjU0MF0gRGV0ZWN0
ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI5ClsgICAgMC4wMTY1NzFdIEdJQ3YzOiBDUFUyOTogZm91
bmQgcmVkaXN0cmlidXRvciAyMTAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOWEwMDAwClsgICAg
MC4wMTY2MDNdIEdJQ3YzOiBDUFUyOTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDA5NzAwMDAKWyAgICAwLjAxNjY1MF0gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDE2NjczXSBD
UFUyOTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjEwMTAwIFsweDQxM2ZkMGMx
XQpbICAgIDAuMDE3MTI3XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMzAKWyAgICAwLjAx
NzE1MV0gR0lDdjM6IENQVTMwOiBmb3VuZCByZWRpc3RyaWJ1dG9yIGYwMTAwIHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDUyMDAwMApbICAgIDAuMDE3MTgzXSBHSUN2MzogQ1BVMzA6IHVzaW5nIGFsbG9j
YXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTgwMDAwClsgICAgMC4wMTcyMzFd
IGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0
MTgwNDAKWyAgICAwLjAxNzI1NF0gQ1BVMzA6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4
MDAwMDBmMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAxNzU1NF0gRGV0ZWN0ZWQgUElQVCBJLWNh
Y2hlIG9uIENQVTMxClsgICAgMC4wMTc1ODddIEdJQ3YzOiBDUFUzMTogZm91bmQgcmVkaXN0cmli
dXRvciAyNzAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwYjIwMDAwClsgICAgMC4wMTc2MThdIEdJ
Q3YzOiBDUFUzMTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAw
MDA5OTAwMDAKWyAgICAwLjAxNzY2N10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fy
b3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDE3Njg4XSBDUFUzMTogQm9vdGVk
IHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjcwMTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDE3
NzcwXSBzbXA6IEJyb3VnaHQgdXAgMSBub2RlLCAzMiBDUFVzClsgICAgMC4wMTc4NjRdIFNNUDog
VG90YWwgb2YgMzIgcHJvY2Vzc29ycyBhY3RpdmF0ZWQuClsgICAgMC4wMTc4NjddIENQVSBmZWF0
dXJlczogZGV0ZWN0ZWQ6IFByaXZpbGVnZWQgQWNjZXNzIE5ldmVyClsgICAgMC4wMTc4NjhdIENQ
VSBmZWF0dXJlczogZGV0ZWN0ZWQ6IExTRSBhdG9taWMgaW5zdHJ1Y3Rpb25zClsgICAgMC4wMTc4
NzBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFVzZXIgQWNjZXNzIE92ZXJyaWRlClsgICAgMC4w
MTc4NzJdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IDMyLWJpdCBFTDAgU3VwcG9ydApbICAgIDAu
MDE3ODc0XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBDb21tb24gbm90IFByaXZhdGUgdHJhbnNs
YXRpb25zClsgICAgMC4wMTc4NzZdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFJBUyBFeHRlbnNp
b24gU3VwcG9ydApbICAgIDAuMDE3ODc3XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBEYXRhIGNh
Y2hlIGNsZWFuIHRvIHRoZSBQb1Ugbm90IHJlcXVpcmVkIGZvciBJL0QgY29oZXJlbmNlClsgICAg
MC4wMTc4NzldIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IENSQzMyIGluc3RydWN0aW9ucwpbICAg
IDAuMDE3ODgxXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBTcGVjdWxhdGl2ZSBTdG9yZSBCeXBh
c3NpbmcgU2FmZSAoU1NCUykKWyAgICAwLjA0OTgwMV0gQ1BVOiBBbGwgQ1BVKHMpIHN0YXJ0ZWQg
YXQgRUwyClsgICAgMC4wNTA1ODVdIGRldnRtcGZzOiBpbml0aWFsaXplZApbICAgIDAuMDUwODU0
XSBjbG9ja3NvdXJjZTogamlmZmllczogbWFzazogMHhmZmZmZmZmZiBtYXhfY3ljbGVzOiAweGZm
ZmZmZmZmLCBtYXhfaWRsZV9uczogNzY0NTA0MTc4NTEwMDAwMCBucwpbICAgIDAuMDUwODYwXSBm
dXRleCBoYXNoIHRhYmxlIGVudHJpZXM6IDgxOTIgKG9yZGVyOiA3LCA1MjQyODggYnl0ZXMsIGxp
bmVhcikKWyAgICAwLjA1MTA5MV0gU01CSU9TIDMuMy4wIHByZXNlbnQuClsgICAgMC4wNTEwOTdd
IERNSTogQURMSU5LIENPTS1IUEMtQUxUL0NPTS1IUEMtQUxULCBCSU9TIFRpYW5vQ29yZSBFREtJ
SSAxMS8yMy8yMDIxClsgICAgMC4wNTEzMjddIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1p
bHkgMTYKWyAgICAwLjA1MTgzMV0gRE1BOiBwcmVhbGxvY2F0ZWQgNDA5NiBLaUIgR0ZQX0tFUk5F
TCBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMKWyAgICAwLjA1MTk5NV0gRE1BOiBwcmVhbGxv
Y2F0ZWQgNDA5NiBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BIHBvb2wgZm9yIGF0b21pYyBhbGxvY2F0
aW9ucwpbICAgIDAuMDUyMTY2XSBETUE6IHByZWFsbG9jYXRlZCA0MDk2IEtpQiBHRlBfS0VSTkVM
fEdGUF9ETUEzMiBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMKWyAgICAwLjA1MjI2M10gdGhl
cm1hbF9zeXM6IFJlZ2lzdGVyZWQgdGhlcm1hbCBnb3Zlcm5vciAnc3RlcF93aXNlJwpbICAgIDAu
MDUyMzQ0XSBjcHVpZGxlOiB1c2luZyBnb3Zlcm5vciBtZW51ClsgICAgMC4wNTI0ODRdIERldGVj
dGVkIDE1IFBDQyBTdWJzcGFjZXMKWyAgICAwLjA1MjUwNV0gUmVnaXN0ZXJpbmcgUENDIGRyaXZl
ciBhcyBNYWlsYm94IGNvbnRyb2xsZXIKWyAgICAwLjA1MjU0Ml0gaHctYnJlYWtwb2ludDogZm91
bmQgNiBicmVha3BvaW50IGFuZCA0IHdhdGNocG9pbnQgcmVnaXN0ZXJzLgpbICAgIDAuMDUyODQ0
XSBBU0lEIGFsbG9jYXRvciBpbml0aWFsaXNlZCB3aXRoIDY1NTM2IGVudHJpZXMKWyAgICAwLjA1
Mjg1MV0gQUNQSTogYnVzIHR5cGUgUENJIHJlZ2lzdGVyZWQKWyAgICAwLjA1Mjg1M10gU2VyaWFs
OiBBTUJBIFBMMDExIFVBUlQgZHJpdmVyClsgICAgMC4wNTUwMDVdIEh1Z2VUTEIgcmVnaXN0ZXJl
ZCAxLjAwIEdpQiBwYWdlIHNpemUsIHByZS1hbGxvY2F0ZWQgMCBwYWdlcwpbICAgIDAuMDU1MDA4
XSBIdWdlVExCIHJlZ2lzdGVyZWQgMzIuMCBNaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAg
cGFnZXMKWyAgICAwLjA1NTAxMF0gSHVnZVRMQiByZWdpc3RlcmVkIDIuMDAgTWlCIHBhZ2Ugc2l6
ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzClsgICAgMC4wNTUwMTJdIEh1Z2VUTEIgcmVnaXN0ZXJl
ZCA2NC4wIEtpQiBwYWdlIHNpemUsIHByZS1hbGxvY2F0ZWQgMCBwYWdlcwpbICAgIDAuMDU1NzA3
XSBjcnlwdGQ6IG1heF9jcHVfcWxlbiBzZXQgdG8gMTAwMApbICAgIDAuMTI0MDU5XSByYWlkNjog
bmVvbng4ICAgZ2VuKCkgIDc3MzMgTUIvcwpbICAgIDAuMTkyMDg4XSByYWlkNjogbmVvbng4ICAg
eG9yKCkgIDYwNTkgTUIvcwpbICAgIDAuMjYwMTMxXSByYWlkNjogbmVvbng0ICAgZ2VuKCkgIDc2
MTIgTUIvcwpbICAgIDAuMzI4MTUxXSByYWlkNjogbmVvbng0ICAgeG9yKCkgIDYzMjYgTUIvcwpb
ICAgIDAuMzk2MTgyXSByYWlkNjogbmVvbngyICAgZ2VuKCkgIDczNzkgTUIvcwpbICAgIDAuNDY0
MjExXSByYWlkNjogbmVvbngyICAgeG9yKCkgIDU3MjkgTUIvcwpbICAgIDAuNTMyMjQwXSByYWlk
NjogbmVvbngxICAgZ2VuKCkgIDU5OTUgTUIvcwpbICAgIDAuNjAwMjY3XSByYWlkNjogbmVvbngx
ICAgeG9yKCkgIDQ5MzMgTUIvcwpbICAgIDAuNjY4Mjk0XSByYWlkNjogaW50NjR4OCAgZ2VuKCkg
IDM2MDIgTUIvcwpbICAgIDAuNzM2MzI2XSByYWlkNjogaW50NjR4OCAgeG9yKCkgIDIwMTggTUIv
cwpbICAgIDAuODA0MzQ4XSByYWlkNjogaW50NjR4NCAgZ2VuKCkgIDQxMjQgTUIvcwpbICAgIDAu
ODcyNDI5XSByYWlkNjogaW50NjR4NCAgeG9yKCkgIDIxOTUgTUIvcwpbICAgIDAuOTQwNDA4XSBy
YWlkNjogaW50NjR4MiAgZ2VuKCkgIDM1MDMgTUIvcwpbICAgIDEuMDA4NDM2XSByYWlkNjogaW50
NjR4MiAgeG9yKCkgIDE4ODggTUIvcwpbICAgIDEuMDc2NDY3XSByYWlkNjogaW50NjR4MSAgZ2Vu
KCkgIDI4NzUgTUIvcwpbICAgIDEuMTQ0NDkzXSByYWlkNjogaW50NjR4MSAgeG9yKCkgIDE1MDgg
TUIvcwpbICAgIDEuMTQ0NDk1XSByYWlkNjogdXNpbmcgYWxnb3JpdGhtIG5lb254OCBnZW4oKSA3
NzMzIE1CL3MKWyAgICAxLjE0NDQ5Nl0gcmFpZDY6IC4uLi4geG9yKCkgNjA1OSBNQi9zLCBybXcg
ZW5hYmxlZApbICAgIDEuMTQ0NDk4XSByYWlkNjogdXNpbmcgbmVvbiByZWNvdmVyeSBhbGdvcml0
aG0KWyAgICAxLjE0NDU3MF0gQUNQSTogQWRkZWQgX09TSShNb2R1bGUgRGV2aWNlKQpbICAgIDEu
MTQ0NTczXSBBQ1BJOiBBZGRlZCBfT1NJKFByb2Nlc3NvciBEZXZpY2UpClsgICAgMS4xNDQ1NzVd
IEFDUEk6IEFkZGVkIF9PU0koMy4wIF9TQ1AgRXh0ZW5zaW9ucykKWyAgICAxLjE0NDU3N10gQUNQ
STogQWRkZWQgX09TSShQcm9jZXNzb3IgQWdncmVnYXRvciBEZXZpY2UpClsgICAgMS4xNDQ1Nzld
IEFDUEk6IEFkZGVkIF9PU0koTGludXgtRGVsbC1WaWRlbykKWyAgICAxLjE0NDU4MV0gQUNQSTog
QWRkZWQgX09TSShMaW51eC1MZW5vdm8tTlYtSERNSS1BdWRpbykKWyAgICAxLjE0NDU4M10gQUNQ
STogQWRkZWQgX09TSShMaW51eC1IUEktSHlicmlkLUdyYXBoaWNzKQpbICAgIDEuMTY0OTk4XSBB
Q1BJOiAyIEFDUEkgQU1MIHRhYmxlcyBzdWNjZXNzZnVsbHkgYWNxdWlyZWQgYW5kIGxvYWRlZApb
ICAgIDEuMTcxMzA4XSBBQ1BJOiBJbnRlcnByZXRlciBlbmFibGVkClsgICAgMS4xNzEzMTFdIEFD
UEk6IFVzaW5nIEdJQyBmb3IgaW50ZXJydXB0IHJvdXRpbmcKWyAgICAxLjE3MTMyNV0gQUNQSTog
TUNGRyB0YWJsZSBkZXRlY3RlZCwgNSBlbnRyaWVzClsgICAgMS4xNzEzMzFdIEFDUEk6IElPUlQ6
IFNNTVUtdjNbMzNmZmUwMDAwMDAwXSBNYXBwZWQgdG8gUHJveGltaXR5IGRvbWFpbiAwClsgICAg
MS4xNzEzNTddIEFDUEk6IElPUlQ6IFNNTVUtdjNbMzdmZmUwMDAwMDAwXSBNYXBwZWQgdG8gUHJv
eGltaXR5IGRvbWFpbiAwClsgICAgMS4xNzEzNzBdIEFDUEk6IElPUlQ6IFNNTVUtdjNbM2ZmZmUw
MDAwMDAwXSBNYXBwZWQgdG8gUHJveGltaXR5IGRvbWFpbiAwClsgICAgMS4xNzEzODNdIEFDUEk6
IElPUlQ6IFNNTVUtdjNbMmJmZmUwMDAwMDAwXSBNYXBwZWQgdG8gUHJveGltaXR5IGRvbWFpbiAw
ClsgICAgMS4xNzEzOTZdIEFDUEk6IElPUlQ6IFNNTVUtdjNbMmZmZmUwMDAwMDAwXSBNYXBwZWQg
dG8gUHJveGltaXR5IGRvbWFpbiAwClsgICAgMS4xNzE0ODZdIEhFU1Q6IFRhYmxlIHBhcnNpbmcg
aGFzIGJlZW4gaW5pdGlhbGl6ZWQuClsgICAgMS4yMDYzNjVdIEFSTUgwMDExOjAwOiB0dHlBTUEw
IGF0IE1NSU8gMHgxMDAwMDI2MDAwMDAgKGlycSA9IDc5LCBiYXNlX2JhdWQgPSAwKSBpcyBhIFNC
U0EKWyAgICA0LjAyMTE5MF0gcHJpbnRrOiBjb25zb2xlIFt0dHlBTUEwXSBlbmFibGVkClsgICAg
NC4wMjcyNTZdIEFSTUgwMDExOjAxOiB0dHlBTUExIGF0IE1NSU8gMHgxMDAwMDI2MjAwMDAgKGly
cSA9IDgwLCBiYXNlX2JhdWQgPSAwKSBpcyBhIFNCU0EKWyAgICA0LjAzNzM3N10gQUNQSTogUENJ
IFJvb3QgQnJpZGdlIFtQQ0kwXSAoZG9tYWluIDAwMGMgW2J1cyAwMC1mZl0pClsgICAgNC4wNDM1
NjBdIGFjcGkgUE5QMEEwODowMDogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFT
UE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDQuMDUyNjYyXSBhY3BpIFBO
UDBBMDg6MDA6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09T
QyBjb250cm9sClsgICAgNC4wNjA0ODVdIGFjcGkgUE5QMEEwODowMDogTUNGRyBxdWlyazogRUNB
TSBhdCBbbWVtIDB4MzNmZmYwMDAwMDAwLTB4MzNmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0g
d2l0aCAweGZmZmY4MDAwMTBkZTBmYzAKWyAgICA0LjA3MzI4OV0gYWNwaSBQTlAwQTA4OjAwOiBF
Q0FNIGFyZWEgW21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkg
UE5QMEMwMjowMApbICAgIDQuMDgyMTYyXSBhY3BpIFBOUDBBMDg6MDA6IEVDQU0gYXQgW21lbSAw
eDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdClsgICAgNC4wOTAz
MjNdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwYzowMApbICAgIDQuMDk0NDExXSBwY2lfYnVz
IDAwMGM6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHg0MDAwMDAwMC0weDRmZmZmZmZmIHdp
bmRvd10KWyAgICA0LjEwMTg4M10gcGNpX2J1cyAwMDBjOjAwOiByb290IGJ1cyByZXNvdXJjZSBb
bWVtIDB4MzAwMDAwMDAwMDAwLTB4MzNmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjExMDA0OV0g
cGNpX2J1cyAwMDBjOjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQpbICAgIDQuMTE1
NTYwXSBwY2kgMDAwYzowMDowMC4wOiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAw
ClsgICAgNC4xMjE2MzddIHBjaSAwMDBjOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xh
c3MgMHgwNjA0MDAKWyAgICA0LjEyNzY4NF0gcGNpIDAwMGM6MDA6MDEuMDogc3VwcG9ydHMgRDEg
RDIKWyAgICA0LjEzMTk0M10gcGNpIDAwMGM6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE
MCBEMSBEM2hvdApbICAgIDQuMTM4ODAxXSBwY2kgMDAwYzowMDowMS4wOiBicmlkZ2Ugd2luZG93
IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMTAwMApbICAgIDQuMTQ2
OTY5XSBwY2kgMDAwYzowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAw
MGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24g
MTAwMDAwClsgICAgNC4xNTg0MzRdIHBjaSAwMDBjOjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW21l
bSAweDAwMTAwMDAwLTB4MDAwZmZmZmZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDIwMDAwMCBhZGRf
YWxpZ24gMTAwMDAwClsgICAgNC4xNjg5NDddIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA4OiBhc3Np
Z25lZCBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0KWyAgICA0LjE3NTcyNV0gcGNpIDAwMGM6
MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZm
ZmYgNjRiaXQgcHJlZl0KWyAgICA0LjE4NDE1MV0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6IG5v
IHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuMTkwNDA3XSBwY2kgMDAwYzowMDow
MS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuMTk3
MDExXSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEw
MDBdClsgICAgNC4yMDMyNjddIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNz
aWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNC4yMDk4NzFdIHBjaSAwMDBjOjAwOjAxLjA6IFBD
SSBicmlkZ2UgdG8gW2J1cyAwMV0KWyAgICA0LjIxNDgyN10gcGNpIDAwMGM6MDA6MDEuMDogICBi
cmlkZ2Ugd2luZG93IFttZW0gMHg0MDAwMDAwMC0weDQwMWZmZmZmXQpbICAgIDQuMjIxNjA0XSBw
Y2kgMDAwYzowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwMDAwMDAwMDAwMC0weDMw
MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuMjMwMDMyXSBwY2lfYnVzIDAwMGM6MDA6IHJl
c291cmNlIDQgW21lbSAweDQwMDAwMDAwLTB4NGZmZmZmZmYgd2luZG93XQpbICAgIDQuMjM2ODk3
XSBwY2lfYnVzIDAwMGM6MDA6IHJlc291cmNlIDUgW21lbSAweDMwMDAwMDAwMDAwMC0weDMzZmZk
ZmZmZmZmZiB3aW5kb3ddClsgICAgNC4yNDQ0NTVdIHBjaV9idXMgMDAwYzowMTogcmVzb3VyY2Ug
MSBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0KWyAgICA0LjI1MDcxMl0gcGNpX2J1cyAwMDBj
OjAxOiByZXNvdXJjZSAyIFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZmZmYgNjRiaXQg
cHJlZl0KWyAgICA0LjI1ODY1N10gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0kxXSAoZG9tYWlu
IDAwMGQgW2J1cyAwMC1mZl0pClsgICAgNC4yNjQ4MzRdIGFjcGkgUE5QMEEwODowMTogX09TQzog
T1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBY
LVR5cGUzXQpbICAgIDQuMjczOTM0XSBhY3BpIFBOUDBBMDg6MDE6IFBDSWUgcG9ydCBzZXJ2aWNl
cyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsgICAgNC4yODE3NTVdIGFj
cGkgUE5QMEEwODowMTogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4
MzdmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzAKWyAg
ICA0LjI5NDU1M10gYWNwaSBQTlAwQTA4OjAxOiBFQ0FNIGFyZWEgW21lbSAweDM3ZmZmMDAwMDAw
MC0weDM3ZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApbICAgIDQuMzAzNDI2XSBh
Y3BpIFBOUDBBMDg6MDE6IEVDQU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZm
Zl0gZm9yIFtidXMgMDAtZmZdClsgICAgNC4zMTE1ODBdIFBDSSBob3N0IGJyaWRnZSB0byBidXMg
MDAwZDowMApbICAgIDQuMzE1NjY3XSBwY2lfYnVzIDAwMGQ6MDA6IHJvb3QgYnVzIHJlc291cmNl
IFttZW0gMHg1MDAwMDAwMC0weDVmZmZmZmZmIHdpbmRvd10KWyAgICA0LjMyMzEzOF0gcGNpX2J1
cyAwMDBkOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzdmZmRm
ZmZmZmZmIHdpbmRvd10KWyAgICA0LjMzMTMwNF0gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1cyBy
ZXNvdXJjZSBbYnVzIDAwLWZmXQpbICAgIDQuMzM2ODEyXSBwY2kgMDAwZDowMDowMC4wOiBbMWRl
ZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwClsgICAgNC4zNDI4NzVdIHBjaSAwMDBkOjAw
OjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA0LjM0ODkwOF0g
cGNpIDAwMGQ6MDA6MDEuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA0LjM1MzE2OF0gcGNpIDAwMGQ6
MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDQuMzU4OTkwXSBw
Y2kgMDAwZDowMTowMC4wOiBbMTBkZToxZTg5XSB0eXBlIDAwIGNsYXNzIDB4MDMwMDAwClsgICAg
NC4zNjQ5OTddIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4NTAwMDAwMDAtMHg1
MGZmZmZmZl0KWyAgICA0LjM3MTI2MV0gcGNpIDAwMGQ6MDE6MDAuMDogcmVnIDB4MTQ6IFttZW0g
MHgzNDAwMDAwMDAwMDAtMHgzNDAwMGZmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjM3OTE3NF0g
cGNpIDAwMGQ6MDE6MDAuMDogcmVnIDB4MWM6IFttZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAwMTFm
ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjM4NzA4M10gcGNpIDAwMGQ6MDE6MDAuMDogcmVnIDB4
MjQ6IFtpbyAgMHg1N2ZmZTAwMC0weDU3ZmZlMDdmXQpbICAgIDQuMzkzMzQzXSBwY2kgMDAwZDow
MTowMC4wOiByZWcgMHgzMDogW21lbSAweGZmZjgwMDAwLTB4ZmZmZmZmZmYgcHJlZl0KWyAgICA0
LjQwMDA5NF0gcGNpIDAwMGQ6MDE6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBE
M2NvbGQKWyAgICA0LjQwNjI0NV0gcGNpIDAwMGQ6MDE6MDAuMTogWzEwZGU6MTBmOF0gdHlwZSAw
MCBjbGFzcyAweDA0MDMwMApbICAgIDQuNDEyMjUwXSBwY2kgMDAwZDowMTowMC4xOiByZWcgMHgx
MDogW21lbSAweDUxMDAwMDAwLTB4NTEwMDNmZmZdClsgICAgNC40MTg2MjldIHBjaSAwMDBkOjAx
OjAwLjI6IFsxMGRlOjFhZDhdIHR5cGUgMDAgY2xhc3MgMHgwYzAzMzAKWyAgICA0LjQyNDYzOF0g
cGNpIDAwMGQ6MDE6MDAuMjogcmVnIDB4MTA6IFttZW0gMHgzNDAwMTIwMDAwMDAtMHgzNDAwMTIw
M2ZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjQzMjU1Nl0gcGNpIDAwMGQ6MDE6MDAuMjogcmVnIDB4
MWM6IFttZW0gMHgzNDAwMTIwNDAwMDAtMHgzNDAwMTIwNGZmZmYgNjRiaXQgcHJlZl0KWyAgICA0
LjQ0MDUxMV0gcGNpIDAwMGQ6MDE6MDAuMjogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBE
M2NvbGQKWyAgICA0LjQ0NjY1MF0gcGNpIDAwMGQ6MDE6MDAuMzogWzEwZGU6MWFkOV0gdHlwZSAw
MCBjbGFzcyAweDBjODAwMApbICAgIDQuNDUyNjU1XSBwY2kgMDAwZDowMTowMC4zOiByZWcgMHgx
MDogW21lbSAweDUxMDA0MDAwLTB4NTEwMDRmZmZdClsgICAgNC40NTg5ODBdIHBjaSAwMDBkOjAx
OjAwLjM6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAgNC40NjUxMTRd
IHBjaSAwMDBkOjAwOjAxLjA6IEFTUE06IGN1cnJlbnQgY29tbW9uIGNsb2NrIGNvbmZpZ3VyYXRp
b24gaXMgaW5jb25zaXN0ZW50LCByZWNvbmZpZ3VyaW5nClsgICAgNC40ODYzOTZdIHBjaSAwMDBk
OjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZm
ZmZmIDY0Yml0IHByZWZdClsgICAgNC40OTQ4MjNdIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA4OiBh
c3NpZ25lZCBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0KWyAgICA0LjUwMTYwMF0gcGNpIDAw
MGQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQu
NTA3ODU2XSBwY2kgMDAwZDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNp
emUgMHgxMDAwXQpbICAgIDQuNTE0NDYxXSBwY2kgMDAwZDowMTowMC4wOiBCQVIgMTogYXNzaWdu
ZWQgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAwZmZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQu
NTIyODk0XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDM0MDAxMDAw
MDAwMC0weDM0MDAxMWZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuNTMxMzI2XSBwY2kgMDAwZDow
MTowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDUwMDAwMDAwLTB4NTBmZmZmZmZdClsgICAg
NC41MzgxMDVdIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4NTEwMDAw
MDAtMHg1MTA3ZmZmZiBwcmVmXQpbICAgIDQuNTQ1MzE2XSBwY2kgMDAwZDowMTowMC4yOiBCQVIg
MDogYXNzaWduZWQgW21lbSAweDM0MDAxMjAwMDAwMC0weDM0MDAxMjAzZmZmZiA2NGJpdCBwcmVm
XQpbICAgIDQuNTUzNzQ5XSBwY2kgMDAwZDowMTowMC4yOiBCQVIgMzogYXNzaWduZWQgW21lbSAw
eDM0MDAxMjA0MDAwMC0weDM0MDAxMjA0ZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuNTYyMTgyXSBw
Y2kgMDAwZDowMTowMC4xOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDUxMDgwMDAwLTB4NTEwODNm
ZmZdClsgICAgNC41Njg5NjJdIHBjaSAwMDBkOjAxOjAwLjM6IEJBUiAwOiBhc3NpZ25lZCBbbWVt
IDB4NTEwODQwMDAtMHg1MTA4NGZmZl0KWyAgICA0LjU3NTc0MF0gcGNpIDAwMGQ6MDE6MDAuMDog
QkFSIDU6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgwMDgwXQpbICAgIDQuNTgxOTk3XSBwY2kg
MDAwZDowMTowMC4wOiBCQVIgNTogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgwMDgwXQpb
ICAgIDQuNTg4NjAxXSBwY2kgMDAwZDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDFdClsg
ICAgNC41OTM1NTZdIHBjaSAwMDBkOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NTAw
MDAwMDAtMHg1MTdmZmZmZl0KWyAgICA0LjYwMDMzNF0gcGNpIDAwMGQ6MDA6MDEuMDogICBicmlk
Z2Ugd2luZG93IFttZW0gMHgzNDAwMDAwMDAwMDAtMHgzNDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0K
WyAgICA0LjYwODc2MV0gcGNpX2J1cyAwMDBkOjAwOiBTb21lIFBDSSBkZXZpY2UgcmVzb3VyY2Vz
IGFyZSB1bmFzc2lnbmVkLCB0cnkgYm9vdGluZyB3aXRoIHBjaT1yZWFsbG9jClsgICAgNC42MTc3
OTVdIHBjaV9idXMgMDAwZDowMDogcmVzb3VyY2UgNCBbbWVtIDB4NTAwMDAwMDAtMHg1ZmZmZmZm
ZiB3aW5kb3ddClsgICAgNC42MjQ2NThdIHBjaV9idXMgMDAwZDowMDogcmVzb3VyY2UgNSBbbWVt
IDB4MzQwMDAwMDAwMDAwLTB4MzdmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjYzMjIxNl0gcGNp
X2J1cyAwMDBkOjAxOiByZXNvdXJjZSAxIFttZW0gMHg1MDAwMDAwMC0weDUxN2ZmZmZmXQpbICAg
IDQuNjM4NDcyXSBwY2lfYnVzIDAwMGQ6MDE6IHJlc291cmNlIDIgW21lbSAweDM0MDAwMDAwMDAw
MC0weDM0MDAxN2ZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuNjQ2NDI4XSBBQ1BJOiBQQ0kgUm9v
dCBCcmlkZ2UgW1BDSTNdIChkb21haW4gMDAwMCBbYnVzIDAwLWZmXSkKWyAgICA0LjY1MjYwNl0g
YWNwaSBQTlAwQTA4OjAzOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBD
bG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAgNC42NjE3MDddIGFjcGkgUE5QMEEw
ODowMzogUENJZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNv
bnRyb2wKWyAgICA0LjY2OTUyOV0gYWNwaSBQTlAwQTA4OjAzOiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0
IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRo
IDB4ZmZmZjgwMDAxMGRlMGZjMApbICAgIDQuNjgyMzM0XSBhY3BpIFBOUDBBMDg6MDM6IEVDQU0g
YXJlYSBbbWVtIDB4M2ZmZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAw
QzAyOjAwClsgICAgNC42OTEyMDddIGFjcGkgUE5QMEEwODowMzogRUNBTSBhdCBbbWVtIDB4M2Zm
ZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0KWyAgICA0LjY5OTM2M10g
UENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDAwOjAwClsgICAgNC43MDM0NTFdIHBjaV9idXMgMDAw
MDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDcwMDAwMDAwLTB4N2ZmZmZmZmYgd2luZG93
XQpbICAgIDQuNzEwOTIzXSBwY2lfYnVzIDAwMDA6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0g
MHgzYzAwMDAwMDAwMDAtMHgzZmZmZGZmZmZmZmYgd2luZG93XQpbICAgIDQuNzE5MDg5XSBwY2lf
YnVzIDAwMDA6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdClsgICAgNC43MjQ1OTZd
IHBjaSAwMDAwOjAwOjAwLjA6IFsxZGVmOmUxMDBdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDAKWyAg
ICA0LjczMDY2MV0gcGNpIDAwMDA6MDA6MDEuMDogWzFkZWY6ZTEwMV0gdHlwZSAwMSBjbGFzcyAw
eDA2MDQwMApbICAgIDQuNzM2NjkzXSBwY2kgMDAwMDowMDowMS4wOiBzdXBwb3J0cyBEMSBEMgpb
ICAgIDQuNzQwOTUzXSBwY2kgMDAwMDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQx
IEQzaG90ClsgICAgNC43NDY3NjldIHBjaSAwMDAwOjAxOjAwLjA6IFs4MDg2OjE1ODldIHR5cGUg
MDAgY2xhc3MgMHgwMjAwMDAKWyAgICA0Ljc1Mjc3OF0gcGNpIDAwMDA6MDE6MDAuMDogcmVnIDB4
MTA6IFttZW0gMHgzYzAwMDMwMDAwMDAtMHgzYzAwMDNmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0
Ljc2MDY5NV0gcGNpIDAwMDA6MDE6MDAuMDogcmVnIDB4MWM6IFttZW0gMHgzYzAwMDQ4MTgwMDAt
MHgzYzAwMDQ4MWZmZmYgNjRiaXQgcHJlZl0KWyAgICA0Ljc2ODYwOV0gcGNpIDAwMDA6MDE6MDAu
MDogcmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAgNC43NzUz
NzFdIHBjaSAwMDAwOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xk
ClsgICAgNC43ODE1MzBdIHBjaSAwMDAwOjAxOjAwLjE6IFs4MDg2OjE1ODldIHR5cGUgMDAgY2xh
c3MgMHgwMjAwMDAKWyAgICA0Ljc4NzUzOV0gcGNpIDAwMDA6MDE6MDAuMTogcmVnIDB4MTA6IFtt
ZW0gMHgzYzAwMDIwMDAwMDAtMHgzYzAwMDJmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0Ljc5NTQ1
N10gcGNpIDAwMDA6MDE6MDAuMTogcmVnIDB4MWM6IFttZW0gMHgzYzAwMDQ4MTAwMDAtMHgzYzAw
MDQ4MTdmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjgwMzM3MF0gcGNpIDAwMDA6MDE6MDAuMTogcmVn
IDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAgNC44MTAxMjldIHBj
aSAwMDAwOjAxOjAwLjE6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAg
NC44MTYyNzhdIHBjaSAwMDAwOjAxOjAwLjI6IFs4MDg2OjE1ODldIHR5cGUgMDAgY2xhc3MgMHgw
MjAwMDAKWyAgICA0LjgyMjI4N10gcGNpIDAwMDA6MDE6MDAuMjogcmVnIDB4MTA6IFttZW0gMHgz
YzAwMDEwMDAwMDAtMHgzYzAwMDFmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjgzMDIwNF0gcGNp
IDAwMDA6MDE6MDAuMjogcmVnIDB4MWM6IFttZW0gMHgzYzAwMDQ4MDgwMDAtMHgzYzAwMDQ4MGZm
ZmYgNjRiaXQgcHJlZl0KWyAgICA0LjgzODExOF0gcGNpIDAwMDA6MDE6MDAuMjogcmVnIDB4MzA6
IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAgNC44NDQ4NzZdIHBjaSAwMDAw
OjAxOjAwLjI6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAgNC44NTEw
MjJdIHBjaSAwMDAwOjAxOjAwLjM6IFs4MDg2OjE1ODldIHR5cGUgMDAgY2xhc3MgMHgwMjAwMDAK
WyAgICA0Ljg1NzAzMV0gcGNpIDAwMDA6MDE6MDAuMzogcmVnIDB4MTA6IFttZW0gMHgzYzAwMDAw
MDAwMDAtMHgzYzAwMDBmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0Ljg2NDk0OF0gcGNpIDAwMDA6
MDE6MDAuMzogcmVnIDB4MWM6IFttZW0gMHgzYzAwMDQ4MDAwMDAtMHgzYzAwMDQ4MDdmZmYgNjRi
aXQgcHJlZl0KWyAgICA0Ljg3Mjg2MV0gcGNpIDAwMDA6MDE6MDAuMzogcmVnIDB4MzA6IFttZW0g
MHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAgNC44Nzk2MTldIHBjaSAwMDAwOjAxOjAw
LjM6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAgNC44ODU3ODJdIHBj
aSAwMDAwOjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVz
IDAxLTAyXSBhZGRfc2l6ZSAxMDAwClsgICAgNC44OTQyMTJdIHBjaSAwMDAwOjAwOjAxLjA6IEJB
UiA5OiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNC45MDI2MzldIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVt
IDB4NzAwMDAwMDAtMHg3MDFmZmZmZl0KWyAgICA0LjkwOTQxNl0gcGNpIDAwMDA6MDA6MDEuMDog
QkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuOTE1NjcyXSBwY2kg
MDAwMDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDQuOTIyMjc2XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAg
c2l6ZSAweDEwMDBdClsgICAgNC45Mjg1MzJdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNC45MzUxMzddIHBjaSAwMDAwOjAx
OjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4M2MwMDAwZmZmZmZm
IDY0Yml0IHByZWZdClsgICAgNC45NDM1NzBdIHBjaSAwMDAwOjAxOjAwLjE6IEJBUiAwOiBhc3Np
Z25lZCBbbWVtIDB4M2MwMDAxMDAwMDAwLTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdClsgICAg
NC45NTIwMDJdIHBjaSAwMDAwOjAxOjAwLjI6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAy
MDAwMDAwLTB4M2MwMDAyZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC45NjA0MzRdIHBjaSAwMDAw
OjAxOjAwLjM6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAzMDAwMDAwLTB4M2MwMDAzZmZm
ZmZmIDY0Yml0IHByZWZdClsgICAgNC45Njg4NjZdIHBjaSAwMDAwOjAxOjAwLjA6IEJBUiA2OiBh
c3NpZ25lZCBbbWVtIDB4NzAwMDAwMDAtMHg3MDA3ZmZmZiBwcmVmXQpbICAgIDQuOTc2MDc3XSBw
Y2kgMDAwMDowMTowMC4xOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMDgwMDAwLTB4NzAwZmZm
ZmYgcHJlZl0KWyAgICA0Ljk4MzI4OF0gcGNpIDAwMDA6MDE6MDAuMjogQkFSIDY6IGFzc2lnbmVk
IFttZW0gMHg3MDEwMDAwMC0weDcwMTdmZmZmIHByZWZdClsgICAgNC45OTA0OTldIHBjaSAwMDAw
OjAxOjAwLjM6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4NzAxODAwMDAtMHg3MDFmZmZmZiBwcmVm
XQpbICAgIDQuOTk3NzEwXSBwY2kgMDAwMDowMTowMC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAw
eDNjMDAwNDAwMDAwMC0weDNjMDAwNDAwN2ZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDA2MTQyXSBw
Y2kgMDAwMDowMTowMC4xOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDNjMDAwNDAwODAwMC0weDNj
MDAwNDAwZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDE0NTc1XSBwY2kgMDAwMDowMTowMC4yOiBC
QVIgMzogYXNzaWduZWQgW21lbSAweDNjMDAwNDAxMDAwMC0weDNjMDAwNDAxN2ZmZiA2NGJpdCBw
cmVmXQpbICAgIDUuMDIzMDA4XSBwY2kgMDAwMDowMTowMC4zOiBCQVIgMzogYXNzaWduZWQgW21l
bSAweDNjMDAwNDAxODAwMC0weDNjMDAwNDAxZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDMxNDQw
XSBwY2kgMDAwMDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDEtMDJdClsgICAgNS4wMzY2
NTVdIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NzAwMDAwMDAtMHg3
MDFmZmZmZl0KWyAgICA1LjA0MzQzMl0gcGNpIDAwMDA6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93
IFttZW0gMHgzYzAwMDAwMDAwMDAtMHgzYzAwMDQ3ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjA1
MTg2MF0gcGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSA0IFttZW0gMHg3MDAwMDAwMC0weDdmZmZm
ZmZmIHdpbmRvd10KWyAgICA1LjA1ODcyNF0gcGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSA1IFtt
ZW0gMHgzYzAwMDAwMDAwMDAtMHgzZmZmZGZmZmZmZmYgd2luZG93XQpbICAgIDUuMDY2MjgyXSBw
Y2lfYnVzIDAwMDA6MDE6IHJlc291cmNlIDEgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZmZmZdClsg
ICAgNS4wNzI1MzddIHBjaV9idXMgMDAwMDowMTogcmVzb3VyY2UgMiBbbWVtIDB4M2MwMDAwMDAw
MDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS4wODA0OTldIEFDUEk6IFBDSSBS
b290IEJyaWRnZSBbUENJNl0gKGRvbWFpbiAwMDA0IFtidXMgMDAtZmZdKQpbICAgIDUuMDg2Njc3
XSBhY3BpIFBOUDBBMDg6MDY6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BN
IENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICA1LjA5NTc3NV0gYWNwaSBQTlAw
QTA4OjA2OiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0Mg
Y29udHJvbApbICAgIDUuMTAzNTk3XSBhY3BpIFBOUDBBMDg6MDY6IE1DRkcgcXVpcms6IEVDQU0g
YXQgW21lbSAweDJiZmZmMDAwMDAwMC0weDJiZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdp
dGggMHhmZmZmODAwMDEwZGUwZmMwClsgICAgNS4xMTYzOTVdIGFjcGkgUE5QMEEwODowNjogRUNB
TSBhcmVhIFttZW0gMHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBO
UDBDMDI6MDAKWyAgICA1LjEyNTI2N10gYWNwaSBQTlAwQTA4OjA2OiBFQ0FNIGF0IFttZW0gMHgy
YmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQpbICAgIDUuMTMzNDIx
XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMDQ6MDAKWyAgICA1LjEzNzUwOF0gcGNpX2J1cyAw
MDA0OjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MjAwMDAwMDAtMHgyZmZmZmZmZiB3aW5k
b3ddClsgICAgNS4xNDQ5NzldIHBjaV9idXMgMDAwNDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21l
bSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNS4xNTMxNDZdIHBj
aV9idXMgMDAwNDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0KWyAgICA1LjE1ODY1
M10gcGNpIDAwMDQ6MDA6MDAuMDogWzFkZWY6ZTExMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMApb
ICAgIDUuMTY0NzE1XSBwY2kgMDAwNDowMDowMS4wOiBbMWRlZjplMTExXSB0eXBlIDAxIGNsYXNz
IDB4MDYwNDAwClsgICAgNS4xNzA3NDldIHBjaSAwMDA0OjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQy
ClsgICAgNS4xNzUwMDldIHBjaSAwMDA0OjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAg
RDEgRDNob3QKWyAgICA1LjE4MDc5Ml0gcGNpIDAwMDQ6MDA6MDMuMDogWzFkZWY6ZTExM10gdHlw
ZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUuMTg2ODI2XSBwY2kgMDAwNDowMDowMy4wOiBzdXBw
b3J0cyBEMSBEMgpbICAgIDUuMTkxMDg1XSBwY2kgMDAwNDowMDowMy4wOiBQTUUjIHN1cHBvcnRl
ZCBmcm9tIEQwIEQxIEQzaG90ClsgICAgNS4xOTY4NjhdIHBjaSAwMDA0OjAwOjA1LjA6IFsxZGVm
OmUxMTVdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA1LjIwMjkxMV0gcGNpIDAwMDQ6MDA6
MDUuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjIwNzE3MF0gcGNpIDAwMDQ6MDA6MDUuMDogUE1F
IyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDUuMjEyOTg5XSBwY2kgMDAwNDowMTow
MC4wOiBbMWEwMzoxMTUwXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNS4yMTkwMzVdIHBj
aSAwMDA0OjAxOjAwLjA6IGVuYWJsaW5nIEV4dGVuZGVkIFRhZ3MKWyAgICA1LjIyNDA1MF0gcGNp
IDAwMDQ6MDE6MDAuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjIyODMwOV0gcGNpIDAwMDQ6MDE6
MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEMiBEM2hvdCBEM2NvbGQKWyAgICA1LjIz
NTAxM10gcGNpX2J1cyAwMDA0OjAyOiBleHRlbmRlZCBjb25maWcgc3BhY2Ugbm90IGFjY2Vzc2li
bGUKWyAgICA1LjI0MTExOF0gcGNpIDAwMDQ6MDI6MDAuMDogWzFhMDM6MjAwMF0gdHlwZSAwMCBj
bGFzcyAweDAzMDAwMApbICAgIDUuMjQ3MTMzXSBwY2kgMDAwNDowMjowMC4wOiByZWcgMHgxMDog
W21lbSAweDIwMDAwMDAwLTB4MjBmZmZmZmZdClsgICAgNS4yNTMzOThdIHBjaSAwMDA0OjAyOjAw
LjA6IHJlZyAweDE0OiBbbWVtIDB4MjEwMDAwMDAtMHgyMTAxZmZmZl0KWyAgICA1LjI1OTY2NF0g
cGNpIDAwMDQ6MDI6MDAuMDogcmVnIDB4MTg6IFtpbyAgMHgyN2ZmZjAwMC0weDI3ZmZmMDdmXQpb
ICAgIDUuMjY2MDAzXSBwY2kgMDAwNDowMjowMC4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDUuMjcw
MjYzXSBwY2kgMDAwNDowMjowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQyIEQzaG90
IEQzY29sZApbICAgIDUuMjc3MDA1XSBwY2kgMDAwNDowMzowMC4wOiBbMTkxMjowMDE0XSB0eXBl
IDAwIGNsYXNzIDB4MGMwMzMwClsgICAgNS4yODMwMjBdIHBjaSAwMDA0OjAzOjAwLjA6IHJlZyAw
eDEwOiBbbWVtIDB4MjEyMDAwMDAtMHgyMTIwMWZmZiA2NGJpdF0KWyAgICA1LjI4OTkwMF0gcGNp
IDAwMDQ6MDM6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAgICA1
LjI5NjEyMl0gcGNpIDAwMDQ6MDQ6MDAuMDogWzgwODY6MTUzM10gdHlwZSAwMCBjbGFzcyAweDAy
MDAwMApbICAgIDUuMzAyMTQ4XSBwY2kgMDAwNDowNDowMC4wOiByZWcgMHgxMDogW21lbSAweDIx
MTAwMDAwLTB4MjExN2ZmZmZdClsgICAgNS4zMDg0MzRdIHBjaSAwMDA0OjA0OjAwLjA6IHJlZyAw
eDE4OiBbaW8gIDB4MjdmZmUwMDAtMHgyN2ZmZTAxZl0KWyAgICA1LjMxNDcwNl0gcGNpIDAwMDQ6
MDQ6MDAuMDogcmVnIDB4MWM6IFttZW0gMHgyMTE4MDAwMC0weDIxMTgzZmZmXQpbICAgIDUuMzIx
MTM4XSBwY2kgMDAwNDowNDowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29s
ZApbICAgIDUuMzI3MzM1XSBwY2kgMDAwNDowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgw
MDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDEtMDJdIGFkZF9zaXplIDIw
MDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNS4zMzkwNjJdIHBjaSAwMDA0OjAwOjAzLjA6IGJy
aWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAzXSBhZGRfc2l6ZSAxMDAw
ClsgICAgNS4zNDcyMjhdIHBjaSAwMDA0OjAwOjAzLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAw
MTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMjAwMDAw
IGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjM1ODY5NF0gcGNpIDAwMDQ6MDA6MDMuMDogYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUg
MTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjM2OTIwNF0gcGNpIDAwMDQ6MDA6MDUuMDog
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBb
YnVzIDA0XSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuMzgwNjcwXSBw
Y2kgMDAwNDowMDowNS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZm
XSB0byBbYnVzIDA0XSBhZGRfc2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuMzkx
MTg0XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4
MjE3ZmZmZmZdClsgICAgNS4zOTc5NjJdIHBjaSAwMDA0OjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25l
ZCBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MjgwMDAwMWZmZmZmIDY0Yml0IHByZWZdClsgICAgNS40
MDYzODldIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjE4MDAwMDAt
MHgyMTlmZmZmZl0KWyAgICA1LjQxMzE2N10gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDk6IGFzc2ln
bmVkIFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1
LjQyMTU5NF0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMWEwMDAw
MC0weDIxYmZmZmZmXQpbICAgIDUuNDI4MzcxXSBwY2kgMDAwNDowMDowNS4wOiBCQVIgOTogYXNz
aWduZWQgW21lbSAweDI4MDAwMDQwMDAwMC0weDI4MDAwMDVmZmZmZiA2NGJpdCBwcmVmXQpbICAg
IDUuNDM2Nzk3XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6
ZSAweDEwMDBdClsgICAgNS40NDMwNTNdIHBjaSAwMDA0OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS40NDk2NTZdIHBjaSAwMDA0OjAwOjAz
LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjQ1NTkxMl0g
cGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAw
MF0KWyAgICA1LjQ2MjUxNl0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBb
aW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDY4NzcyXSBwY2kgMDAwNDowMDowNS4wOiBCQVIgNzog
ZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDc1Mzc2XSBwY2kgMDAw
NDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS40
ODE2MzNdIHBjaSAwMDA0OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6
ZSAweDEwMDBdClsgICAgNS40ODgyMzZdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFj
ZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjQ5NDQ5M10gcGNpIDAwMDQ6MDA6MDUuMDog
QkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjUwMTA5Nl0g
cGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDUuNTA3MzUyXSBwY2kgMDAwNDowMDowMy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNTEzOTU3XSBwY2kgMDAwNDowMTowMC4wOiBCQVIgODog
YXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZmZmZdClsgICAgNS41MjA3MzRdIHBjaSAw
MDA0OjAxOjAwLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1
LjUyNjk5MF0gcGNpIDAwMDQ6MDE6MDAuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBz
aXplIDB4MTAwMF0KWyAgICA1LjUzMzU5NF0gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDA6IGFzc2ln
bmVkIFttZW0gMHgyMDAwMDAwMC0weDIwZmZmZmZmXQpbICAgIDUuNTQwMzczXSBwY2kgMDAwNDow
MjowMC4wOiBCQVIgMTogYXNzaWduZWQgW21lbSAweDIxMDAwMDAwLTB4MjEwMWZmZmZdClsgICAg
NS41NDcxNTNdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAyOiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MDA4MF0KWyAgICA1LjU1MzQwOV0gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDI6IGZhaWxlZCB0
byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0KWyAgICA1LjU2MDAxMl0gcGNpIDAwMDQ6MDE6MDAu
MDogUENJIGJyaWRnZSB0byBbYnVzIDAyXQpbICAgIDUuNTY0OTY5XSBwY2kgMDAwNDowMTowMC4w
OiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZmZmZdClsgICAgNS41NzE3
NTRdIHBjaSAwMDA0OjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMS0wMl0KWyAgICA1LjU3
Njk2OF0gcGNpIDAwMDQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyMDAwMDAwMC0w
eDIxN2ZmZmZmXQpbICAgIDUuNTgzNzQ2XSBwY2kgMDAwNDowMDowMS4wOiAgIGJyaWRnZSB3aW5k
b3cgW21lbSAweDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUu
NTkyMTc0XSBwY2kgMDAwNDowMzowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDIxODAwMDAw
LTB4MjE4MDFmZmYgNjRiaXRdClsgICAgNS41OTk0ODFdIHBjaSAwMDA0OjAwOjAzLjA6IFBDSSBi
cmlkZ2UgdG8gW2J1cyAwM10KWyAgICA1LjYwNDQzNl0gcGNpIDAwMDQ6MDA6MDMuMDogICBicmlk
Z2Ugd2luZG93IFttZW0gMHgyMTgwMDAwMC0weDIxOWZmZmZmXQpbICAgIDUuNjExMjEzXSBwY2kg
MDAwNDowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDI4MDAwMDIwMDAwMC0weDI4MDAw
MDNmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuNjE5NjQyXSBwY2kgMDAwNDowNDowMC4wOiBCQVIg
MDogYXNzaWduZWQgW21lbSAweDIxYTAwMDAwLTB4MjFhN2ZmZmZdClsgICAgNS42MjY0MjRdIHBj
aSAwMDA0OjA0OjAwLjA6IEJBUiAzOiBhc3NpZ25lZCBbbWVtIDB4MjFhODAwMDAtMHgyMWE4M2Zm
Zl0KWyAgICA1LjYzMzIwNV0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDI6IG5vIHNwYWNlIGZvciBb
aW8gIHNpemUgMHgwMDIwXQpbICAgIDUuNjM5NDYxXSBwY2kgMDAwNDowNDowMC4wOiBCQVIgMjog
ZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgwMDIwXQpbICAgIDUuNjQ2MDY0XSBwY2kgMDAw
NDowMDowNS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDRdClsgICAgNS42NTEwNDFdIHBjaSAwMDA0
OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjFhMDAwMDAtMHgyMWJmZmZmZl0KWyAg
ICA1LjY1NzgxOV0gcGNpIDAwMDQ6MDA6MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyODAw
MDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjY2NjI0Nl0gcGNpX2J1
cyAwMDA0OjAwOiBTb21lIFBDSSBkZXZpY2UgcmVzb3VyY2VzIGFyZSB1bmFzc2lnbmVkLCB0cnkg
Ym9vdGluZyB3aXRoIHBjaT1yZWFsbG9jClsgICAgNS42NzUyODBdIHBjaV9idXMgMDAwNDowMDog
cmVzb3VyY2UgNCBbbWVtIDB4MjAwMDAwMDAtMHgyZmZmZmZmZiB3aW5kb3ddClsgICAgNS42ODIx
NDVdIHBjaV9idXMgMDAwNDowMDogcmVzb3VyY2UgNSBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MmJm
ZmRmZmZmZmZmIHdpbmRvd10KWyAgICA1LjY4OTcwM10gcGNpX2J1cyAwMDA0OjAxOiByZXNvdXJj
ZSAxIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNjk1OTU5XSBwY2lfYnVzIDAw
MDQ6MDE6IHJlc291cmNlIDIgW21lbSAweDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJp
dCBwcmVmXQpbICAgIDUuNzAzODY0XSBwY2lfYnVzIDAwMDQ6MDI6IHJlc291cmNlIDEgW21lbSAw
eDIwMDAwMDAwLTB4MjE3ZmZmZmZdClsgICAgNS43MTAxMjFdIHBjaV9idXMgMDAwNDowMzogcmVz
b3VyY2UgMSBbbWVtIDB4MjE4MDAwMDAtMHgyMTlmZmZmZl0KWyAgICA1LjcxNjM3Nl0gcGNpX2J1
cyAwMDA0OjAzOiByZXNvdXJjZSAyIFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYg
NjRiaXQgcHJlZl0KWyAgICA1LjcyNDI4Ml0gcGNpX2J1cyAwMDA0OjA0OiByZXNvdXJjZSAxIFtt
ZW0gMHgyMWEwMDAwMC0weDIxYmZmZmZmXQpbICAgIDUuNzMwNTM5XSBwY2lfYnVzIDAwMDQ6MDQ6
IHJlc291cmNlIDIgW21lbSAweDI4MDAwMDQwMDAwMC0weDI4MDAwMDVmZmZmZiA2NGJpdCBwcmVm
XQpbICAgIDUuNzM4NDkzXSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTddIChkb21haW4gMDAw
NSBbYnVzIDAwLWZmXSkKWyAgICA1Ljc0NDY3Ml0gYWNwaSBQTlAwQTA4OjA3OiBfT1NDOiBPUyBz
dXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlw
ZTNdClsgICAgNS43NTM3NzJdIGFjcGkgUE5QMEEwODowNzogUENJZSBwb3J0IHNlcnZpY2VzIGRp
c2FibGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNvbnRyb2wKWyAgICA1Ljc2MTU5NF0gYWNwaSBQ
TlAwQTA4OjA3OiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZm
ZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMApbICAgIDUu
Nzc0MzkzXSBhY3BpIFBOUDBBMDg6MDc6IEVDQU0gYXJlYSBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4
MmZmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAwQzAyOjAwClsgICAgNS43ODMyNjRdIGFjcGkg
UE5QMEEwODowNzogRUNBTSBhdCBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4MmZmZmZmZmZmZmZmXSBm
b3IgW2J1cyAwMC1mZl0KWyAgICA1Ljc5MTQxNl0gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDA1
OjAwClsgICAgNS43OTU1MDJdIHBjaV9idXMgMDAwNTowMDogcm9vdCBidXMgcmVzb3VyY2UgW21l
bSAweDMwMDAwMDAwLTB4M2ZmZmZmZmYgd2luZG93XQpbICAgIDUuODAyOTc0XSBwY2lfYnVzIDAw
MDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyZmZmZGZmZmZm
ZmYgd2luZG93XQpbICAgIDUuODExMTQwXSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291
cmNlIFtidXMgMDAtZmZdClsgICAgNS44MTY2NDddIHBjaSAwMDA1OjAwOjAwLjA6IFsxZGVmOmUx
MTBdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDAKWyAgICA1LjgyMjcxNl0gcGNpIDAwMDU6MDA6MDEu
MDogWzFkZWY6ZTExMV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUuODI4NzU5XSBwY2kg
MDAwNTowMDowMS4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDUuODMzMDE5XSBwY2kgMDAwNTowMDow
MS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90ClsgICAgNS44Mzg4MDVdIHBjaSAw
MDA1OjAwOjAzLjA6IFsxZGVmOmUxMTNdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA1Ljg0
NDg0MF0gcGNpIDAwMDU6MDA6MDMuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1Ljg0OTA5OV0gcGNp
IDAwMDU6MDA6MDMuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDUuODU0
ODgxXSBwY2kgMDAwNTowMDowNS4wOiBbMWRlZjplMTE1XSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAw
ClsgICAgNS44NjA5MjRdIHBjaSAwMDA1OjAwOjA1LjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS44
NjUxODRdIHBjaSAwMDA1OjAwOjA1LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QK
WyAgICA1Ljg3MDk2N10gcGNpIDAwMDU6MDA6MDcuMDogWzFkZWY6ZTExN10gdHlwZSAwMSBjbGFz
cyAweDA2MDQwMApbICAgIDUuODc2OTk2XSBwY2kgMDAwNTowMDowNy4wOiBzdXBwb3J0cyBEMSBE
MgpbICAgIDUuODgxMjU1XSBwY2kgMDAwNTowMDowNy4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQw
IEQxIEQzaG90ClsgICAgNS44ODgxMzZdIHBjaSAwMDA1OjAyOjAwLjA6IFsxOTEyOjAwMTRdIHR5
cGUgMDAgY2xhc3MgMHgwYzAzMzAKWyAgICA1Ljg5NDE1MV0gcGNpIDAwMDU6MDI6MDAuMDogcmVn
IDB4MTA6IFttZW0gMHgzMDEwMDAwMC0weDMwMTAxZmZmIDY0Yml0XQpbICAgIDUuOTAxMDMyXSBw
Y2kgMDAwNTowMjowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAg
IDUuOTA4Mjk0XSBwY2kgMDAwNTowNDowMC4wOiBbMTI2ZjoyMjYzXSB0eXBlIDAwIGNsYXNzIDB4
MDEwODAyClsgICAgNS45MTQzMDldIHBjaSAwMDA1OjA0OjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4
MzAwMDAwMDAtMHgzMDAwM2ZmZiA2NGJpdF0KWyAgICA1LjkyMTI2Nl0gcGNpIDAwMDU6MDA6MDEu
MDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDFdIGFkZF9zaXpl
IDEwMDAKWyAgICA1LjkyOTQzNV0gcGNpIDAwMDU6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVt
IDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAy
MDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuOTQwOTAwXSBwY2kgMDAwNTowMDowMS4wOiBi
cmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBhZGRf
c2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuOTUxNDEwXSBwY2kgMDAwNTowMDow
My4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMl0gYWRkX3Np
emUgMTAwMApbICAgIDUuOTU5NTc2XSBwY2kgMDAwNTowMDowMy4wOiBicmlkZ2Ugd2luZG93IFtt
ZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDJdIGFkZF9zaXpl
IDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNS45NzEwNDFdIHBjaSAwMDA1OjAwOjAzLjA6
IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDJdIGFk
ZF9zaXplIDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNS45ODE1NTFdIHBjaSAwMDA1OjAw
OjA1LjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAzXSBhZGRf
c2l6ZSAxMDAwClsgICAgNS45ODk3MTddIHBjaSAwMDA1OjAwOjA1LjA6IGJyaWRnZSB3aW5kb3cg
W21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwM10gYWRkX3Np
emUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjAwMTE4Ml0gcGNpIDAwMDU6MDA6MDUu
MDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAwM10g
YWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjAxMTY5Ml0gcGNpIDAwMDU6
MDA6MDcuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDRdIGFk
ZF9zaXplIDEwMDAKWyAgICA2LjAxOTg1OF0gcGNpIDAwMDU6MDA6MDcuMDogYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDA0XSBhZGRf
c2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDYuMDMxMzIzXSBwY2kgMDAwNTowMDow
Ny4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBbYnVzIDA0
XSBhZGRfc2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDYuMDQxODM3XSBwY2kgMDAw
NTowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwMDAwMDAwLTB4MzAxZmZmZmZdClsg
ICAgNi4wNDg2MTVdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MmMw
MDAwMDAwMDAwLTB4MmMwMDAwMWZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4wNTcwNDFdIHBjaSAw
MDA1OjAwOjAzLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzAyMDAwMDAtMHgzMDNmZmZmZl0K
WyAgICA2LjA2MzgxOV0gcGNpIDAwMDU6MDA6MDMuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgy
YzAwMDAyMDAwMDAtMHgyYzAwMDAzZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjA3MjI0Nl0gcGNp
IDAwMDU6MDA6MDUuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDQwMDAwMC0weDMwNWZmZmZm
XQpbICAgIDYuMDc5MDIzXSBwY2kgMDAwNTowMDowNS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAw
eDJjMDAwMDQwMDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMDg3NDUwXSBw
Y2kgMDAwNTowMDowNy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwNjAwMDAwLTB4MzA3ZmZm
ZmZdClsgICAgNi4wOTQyMjhdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVt
IDB4MmMwMDAwNjAwMDAwLTB4MmMwMDAwN2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4xMDI2NTVd
IHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0K
WyAgICA2LjEwODkxMV0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24g
W2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjExNTUxNF0gcGNpIDAwMDU6MDA6MDMuMDogQkFSIDc6
IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTIxNzcwXSBwY2kgMDAwNTow
MDowMy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDYu
MTI4MzczXSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAw
eDEwMDBdClsgICAgNi4xMzQ2MjhdIHBjaSAwMDA1OjAwOjA1LjA6IEJBUiA3OiBmYWlsZWQgdG8g
YXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xNDEyMzFdIHBjaSAwMDA1OjAwOjA3LjA6
IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE0NzQ4N10gcGNp
IDAwMDU6MDA6MDcuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0K
WyAgICA2LjE1NDA5M10gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8g
IHNpemUgMHgxMDAwXQpbICAgIDYuMTYwMzQ5XSBwY2kgMDAwNTowMDowNy4wOiBCQVIgNzogZmFp
bGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTY2OTUyXSBwY2kgMDAwNTow
MDowNS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xNzMy
MDddIHBjaSAwMDA1OjAwOjA1LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAw
eDEwMDBdClsgICAgNi4xNzk4MTFdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBm
b3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE4NjA2N10gcGNpIDAwMDU6MDA6MDMuMDogQkFS
IDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE5MjY3MF0gcGNp
IDAwMDU6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAg
IDYuMTk4OTI3XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8g
IHNpemUgMHgxMDAwXQpbICAgIDYuMjA1NTMxXSBwY2kgMDAwNTowMDowMS4wOiBQQ0kgYnJpZGdl
IHRvIFtidXMgMDFdClsgICAgNi4yMTA0ODVdIHBjaSAwMDA1OjAwOjAxLjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MzAwMDAwMDAtMHgzMDFmZmZmZl0KWyAgICA2LjIxNzI2M10gcGNpIDAwMDU6
MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZm
ZmYgNjRiaXQgcHJlZl0KWyAgICA2LjIyNTY5Ml0gcGNpIDAwMDU6MDI6MDAuMDogQkFSIDA6IGFz
c2lnbmVkIFttZW0gMHgzMDIwMDAwMC0weDMwMjAxZmZmIDY0Yml0XQpbICAgIDYuMjMyOTk4XSBw
Y2kgMDAwNTowMDowMy4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDJdClsgICAgNi4yMzc5NTJdIHBj
aSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MzAyMDAwMDAtMHgzMDNmZmZm
Zl0KWyAgICA2LjI0NDcyOV0gcGNpIDAwMDU6MDA6MDMuMDogICBicmlkZ2Ugd2luZG93IFttZW0g
MHgyYzAwMDAyMDAwMDAtMHgyYzAwMDAzZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjI1MzE1Nl0g
cGNpIDAwMDU6MDA6MDUuMDogUENJIGJyaWRnZSB0byBbYnVzIDAzXQpbICAgIDYuMjU4MTExXSBw
Y2kgMDAwNTowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZm
ZmZdClsgICAgNi4yNjQ4ODldIHBjaSAwMDA1OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVt
IDB4MmMwMDAwNDAwMDAwLTB4MmMwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4yNzMzMTdd
IHBjaSAwMDA1OjA0OjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MzA2MDAwMDAtMHgzMDYw
M2ZmZiA2NGJpdF0KWyAgICA2LjI4MDYzMF0gcGNpIDAwMDU6MDA6MDcuMDogUENJIGJyaWRnZSB0
byBbYnVzIDA0XQpbICAgIDYuMjg1NTg1XSBwY2kgMDAwNTowMDowNy4wOiAgIGJyaWRnZSB3aW5k
b3cgW21lbSAweDMwNjAwMDAwLTB4MzA3ZmZmZmZdClsgICAgNi4yOTIzNjNdIHBjaSAwMDA1OjAw
OjA3LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwNjAwMDAwLTB4MmMwMDAwN2ZmZmZm
IDY0Yml0IHByZWZdClsgICAgNi4zMDA3OTBdIHBjaV9idXMgMDAwNTowMDogcmVzb3VyY2UgNCBb
bWVtIDB4MzAwMDAwMDAtMHgzZmZmZmZmZiB3aW5kb3ddClsgICAgNi4zMDc2NTVdIHBjaV9idXMg
MDAwNTowMDogcmVzb3VyY2UgNSBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmZmZmRmZmZmZmZmIHdp
bmRvd10KWyAgICA2LjMxNTIxM10gcGNpX2J1cyAwMDA1OjAxOiByZXNvdXJjZSAxIFttZW0gMHgz
MDAwMDAwMC0weDMwMWZmZmZmXQpbICAgIDYuMzIxNDY4XSBwY2lfYnVzIDAwMDU6MDE6IHJlc291
cmNlIDIgW21lbSAweDJjMDAwMDAwMDAwMC0weDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAg
IDYuMzI5Mzc0XSBwY2lfYnVzIDAwMDU6MDI6IHJlc291cmNlIDEgW21lbSAweDMwMjAwMDAwLTB4
MzAzZmZmZmZdClsgICAgNi4zMzU2MzBdIHBjaV9idXMgMDAwNTowMjogcmVzb3VyY2UgMiBbbWVt
IDB4MmMwMDAwMjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4zNDM1MzVd
IHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMSBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0K
WyAgICA2LjM0OTc5MV0gcGNpX2J1cyAwMDA1OjAzOiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDA0
MDAwMDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjM1NzY5Nl0gcGNpX2J1cyAw
MDA1OjA0OiByZXNvdXJjZSAxIFttZW0gMHgzMDYwMDAwMC0weDMwN2ZmZmZmXQpbICAgIDYuMzYz
OTUyXSBwY2lfYnVzIDAwMDU6MDQ6IHJlc291cmNlIDIgW21lbSAweDJjMDAwMDYwMDAwMC0weDJj
MDAwMDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMzcyMDczXSBpb21tdTogRGVmYXVsdCBkb21h
aW4gdHlwZTogVHJhbnNsYXRlZCAKWyAgICA2LjM3Njk3OF0gcGNpIDAwMGQ6MDE6MDAuMDogdmdh
YXJiOiBWR0EgZGV2aWNlIGFkZGVkOiBkZWNvZGVzPWlvK21lbSxvd25zPW5vbmUsbG9ja3M9bm9u
ZQpbICAgIDYuMzg1MzI2XSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IFZHQSBkZXZpY2UgYWRk
ZWQ6IGRlY29kZXM9aW8rbWVtLG93bnM9bm9uZSxsb2Nrcz1ub25lClsgICAgNi4zOTM2NjldIHBj
aSAwMDBkOjAxOjAwLjA6IHZnYWFyYjogYnJpZGdlIGNvbnRyb2wgcG9zc2libGUKWyAgICA2LjM5
OTQwNF0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBicmlkZ2UgY29udHJvbCBwb3NzaWJsZQpb
ICAgIDYuNDA1MTQxXSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IHNldHRpbmcgYXMgYm9vdCBk
ZXZpY2UgKFZHQSBsZWdhY3kgcmVzb3VyY2VzIG5vdCBhdmFpbGFibGUpClsgICAgNi40MTQwMDJd
IHZnYWFyYjogbG9hZGVkClsgICAgNi40MTY3NzldIFNDU0kgc3Vic3lzdGVtIGluaXRpYWxpemVk
ClsgICAgNi40MjA1MjJdIEFDUEk6IGJ1cyB0eXBlIFVTQiByZWdpc3RlcmVkClsgICAgNi40MjQ1
MzhdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgdXNiZnMKWyAgICA2
LjQzMDAyMV0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBodWIKWyAg
ICA2LjQzNTMzN10gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgZGV2aWNlIGRyaXZlciB1c2IKWyAg
ICA2LjQ0MDM5NV0gcHBzX2NvcmU6IExpbnV4UFBTIEFQSSB2ZXIuIDEgcmVnaXN0ZXJlZApbICAg
IDYuNDQ1MzQ4XSBwcHNfY29yZTogU29mdHdhcmUgdmVyLiA1LjMuNiAtIENvcHlyaWdodCAyMDA1
LTIwMDcgUm9kb2xmbyBHaW9tZXR0aSA8Z2lvbWV0dGlAbGludXguaXQ+ClsgICAgNi40NTQ0NzBd
IFBUUCBjbG9jayBzdXBwb3J0IHJlZ2lzdGVyZWQKWyAgICA2LjQ1ODUwMV0gUmVnaXN0ZXJlZCBl
Zml2YXJzIG9wZXJhdGlvbnMKWyAgICA2LjQ2MzIwNV0gY2xvY2tzb3VyY2U6IFN3aXRjaGVkIHRv
IGNsb2Nrc291cmNlIGFyY2hfc3lzX2NvdW50ZXIKWyAgICA2LjY0NDU3NV0gcG5wOiBQblAgQUNQ
SSBpbml0ClsgICAgNi42NDg5ODldIHN5c3RlbSAwMDowMDogW21lbSAweDNiZmZmMDAwMDAwMC0w
eDNiZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkClsgICAgNi42NTY5MDBdIHN5
c3RlbSAwMDowMDogW21lbSAweDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZiB3aW5kb3ddIGNv
dWxkIG5vdCBiZSByZXNlcnZlZApbICAgIDYuNjY1MTU0XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgy
M2ZmZjAwMDAwMDAtMHgyM2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAg
IDYuNjczMDYwXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgyN2ZmZjAwMDAwMDAtMHgyN2ZmZmZmZmZm
ZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNjgwOTY2XSBzeXN0ZW0gMDA6MDA6
IFttZW0gMHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUg
cmVzZXJ2ZWQKWyAgICA2LjY4OTIyMF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MmZmZmYwMDAwMDAw
LTB4MmZmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkClsgICAgNi42OTc0
NzNdIHN5c3RlbSAwMDowMDogW21lbSAweDdiZmZmMDAwMDAwMC0weDdiZmZmZmZmZmZmZiB3aW5k
b3ddIGhhcyBiZWVuIHJlc2VydmVkClsgICAgNi43MDUzNzldIHN5c3RlbSAwMDowMDogW21lbSAw
eDdmZmZmMDAwMDAwMC0weDdmZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkClsg
ICAgNi43MTMyODVdIHN5c3RlbSAwMDowMDogW21lbSAweDYzZmZmMDAwMDAwMC0weDYzZmZmZmZm
ZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkClsgICAgNi43MjExOTJdIHN5c3RlbSAwMDow
MDogW21lbSAweDY3ZmZmMDAwMDAwMC0weDY3ZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJl
c2VydmVkClsgICAgNi43MjkwOThdIHN5c3RlbSAwMDowMDogW21lbSAweDZiZmZmMDAwMDAwMC0w
eDZiZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkClsgICAgNi43MzcwMDRdIHN5
c3RlbSAwMDowMDogW21lbSAweDZmZmZmMDAwMDAwMC0weDZmZmZmZmZmZmZmZiB3aW5kb3ddIGhh
cyBiZWVuIHJlc2VydmVkClsgICAgNi43NDQ5MTBdIHN5c3RlbSAwMDowMDogW21lbSAweDMzZmZm
MDAwMDAwMC0weDMzZmZmZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZApbICAg
IDYuNzUzMTYzXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZmZmZm
ZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQKWyAgICA2Ljc2MTQyNV0gcG5wOiBQblAg
QUNQSTogZm91bmQgMSBkZXZpY2VzClsgICAgNi43NjcyMzBdIE5FVDogUmVnaXN0ZXJlZCBwcm90
b2NvbCBmYW1pbHkgMgpbICAgIDYuNzcxNzY0XSB0Y3BfbGlzdGVuX3BvcnRhZGRyX2hhc2ggaGFz
aCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAob3JkZXI6IDYsIDI2MjE0NCBieXRlcywgbGluZWFyKQpb
ICAgIDYuNzgwNjQzXSBUQ1AgZXN0YWJsaXNoZWQgaGFzaCB0YWJsZSBlbnRyaWVzOiAyNjIxNDQg
KG9yZGVyOiA5LCAyMDk3MTUyIGJ5dGVzLCBsaW5lYXIpClsgICAgNi43ODk2NTRdIFRDUCBiaW5k
IGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA4LCAxMDQ4NTc2IGJ5dGVzLCBsaW5l
YXIpClsgICAgNi43OTc1MTldIFRDUDogSGFzaCB0YWJsZXMgY29uZmlndXJlZCAoZXN0YWJsaXNo
ZWQgMjYyMTQ0IGJpbmQgNjU1MzYpClsgICAgNi44MDQxOTBdIFVEUCBoYXNoIHRhYmxlIGVudHJp
ZXM6IDE2Mzg0IChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIpClsgICAgNi44MTEzOTdd
IFVEUC1MaXRlIGhhc2ggdGFibGUgZW50cmllczogMTYzODQgKG9yZGVyOiA3LCA1MjQyODggYnl0
ZXMsIGxpbmVhcikKWyAgICA2LjgxOTE2MV0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZhbWls
eSAxClsgICAgNi44MjM2OTBdIFJQQzogUmVnaXN0ZXJlZCBuYW1lZCBVTklYIHNvY2tldCB0cmFu
c3BvcnQgbW9kdWxlLgpbICAgIDYuODI5NjAyXSBSUEM6IFJlZ2lzdGVyZWQgdWRwIHRyYW5zcG9y
dCBtb2R1bGUuClsgICAgNi44MzQyOTVdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgdHJhbnNwb3J0IG1v
ZHVsZS4KWyAgICA2LjgzODk4OF0gUlBDOiBSZWdpc3RlcmVkIHRjcCBORlN2NC4xIGJhY2tjaGFu
bmVsIHRyYW5zcG9ydCBtb2R1bGUuClsgICAgNi44NDU0NjddIHBjaSAwMDBkOjAxOjAwLjE6IEQw
IHBvd2VyIHN0YXRlIGRlcGVuZHMgb24gMDAwZDowMTowMC4wClsgICAgNi44NTE4NjddIHBjaSAw
MDBkOjAxOjAwLjI6IEQwIHBvd2VyIHN0YXRlIGRlcGVuZHMgb24gMDAwZDowMTowMC4wClsgICAg
Ni44NTgyNDVdIHBjaSAwMDBkOjAxOjAwLjI6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAy
KQpbICAgIDYuODYzOTQ1XSBwY2kgMDAwZDowMTowMC4zOiBEMCBwb3dlciBzdGF0ZSBkZXBlbmRz
IG9uIDAwMGQ6MDE6MDAuMApbICAgIDYuODcwMzQ2XSBwY2kgMDAwNDowMzowMC4wOiBlbmFibGlu
ZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAgICA2Ljg3NjAzM10gcGNpIDAwMDU6MDI6MDAuMDog
ZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAgNi44ODE3MDVdIFBDSTogQ0xTIDEy
OCBieXRlcywgZGVmYXVsdCA2NApbICAgIDYuODg3MDM4XSBodyBwZXJmZXZlbnRzOiBlbmFibGVk
IHdpdGggYXJtdjhfcG11djNfMCBQTVUgZHJpdmVyLCA3IGNvdW50ZXJzIGF2YWlsYWJsZQpbICAg
IDYuODk2NDc2XSB3b3JraW5nc2V0OiB0aW1lc3RhbXBfYml0cz00MiBtYXhfb3JkZXI9MjMgYnVj
a2V0X29yZGVyPTAKWyAgICA2LjkwNDY1OF0gTkZTOiBSZWdpc3RlcmluZyB0aGUgaWRfcmVzb2x2
ZXIga2V5IHR5cGUKWyAgICA2LjkwOTcxMV0gS2V5IHR5cGUgaWRfcmVzb2x2ZXIgcmVnaXN0ZXJl
ZApbICAgIDYuOTEzODg0XSBLZXkgdHlwZSBpZF9sZWdhY3kgcmVnaXN0ZXJlZApbICAgIDYuOTE4
MTUzXSBLZXkgdHlwZSBjaWZzLmlkbWFwIHJlZ2lzdGVyZWQKWyAgICA2LjkzNzA4OV0geG9yOiBt
ZWFzdXJpbmcgc29mdHdhcmUgY2hlY2tzdW0gc3BlZWQKWyAgICA2Ljk0Mjg4NV0gICAgOHJlZ3Mg
ICAgICAgICAgIDogIDk3OTQgTUIvc2VjClsgICAgNi45NDgwNjddICAgIDMycmVncyAgICAgICAg
ICA6IDExNzU4IE1CL3NlYwpbICAgIDYuOTUzMTE2XSAgICBhcm02NF9uZW9uICAgICAgOiAxNDAz
NCBNQi9zZWMKWyAgICA2Ljk1NzQ2Ml0geG9yOiB1c2luZyBmdW5jdGlvbjogYXJtNjRfbmVvbiAo
MTQwMzQgTUIvc2VjKQpbICAgIDYuOTYyOTQ2XSBCbG9jayBsYXllciBTQ1NJIGdlbmVyaWMgKGJz
ZykgZHJpdmVyIHZlcnNpb24gMC40IGxvYWRlZCAobWFqb3IgMjQ5KQpbICAgIDYuOTcwMzMyXSBp
byBzY2hlZHVsZXIgbXEtZGVhZGxpbmUgcmVnaXN0ZXJlZApbICAgIDYuOTc0ODUxXSBpbyBzY2hl
ZHVsZXIga3liZXIgcmVnaXN0ZXJlZApbICAgIDYuOTc5NTQxXSBncGlvLWR3YXBiIEFQTUMwRDA3
OjAyOiBubyBJUlEgZm9yIHBvcnQwClsgICAgNi45ODUzMDZdIGlucHV0OiBQb3dlciBCdXR0b24g
YXMgL2RldmljZXMvTE5YU1lTVE06MDAvTE5YU1lCVVM6MDAvUE5QMEMwQzowMC9pbnB1dC9pbnB1
dDAKWyAgICA2Ljk5MzY5MV0gQUNQSTogUG93ZXIgQnV0dG9uIFtQV1JCXQpbICAgIDcuMDAwNDk4
XSBHSEVTOiBBUEVJIGZpcm13YXJlIGZpcnN0IG1vZGUgaXMgZW5hYmxlZCBieSBBUEVJIGJpdC4K
WyAgICA3LjAwNjcxNF0gRUlOSjogRXJyb3IgSU5KZWN0aW9uIGlzIGluaXRpYWxpemVkLgpbICAg
IDcuMDExNDQ3XSBBQ1BJIEdURFQ6IGZvdW5kIDEgU0JTQSBnZW5lcmljIFdhdGNoZG9nKHMpLgpb
ICAgIDcuMDE3NDY3XSBhc3QgMDAwNDowMjowMC4wOiBbZHJtXSBwbGF0Zm9ybSBoYXMgbm8gSU8g
c3BhY2UsIHRyeWluZyBNTUlPClsgICAgNy4wMjQyNTRdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1d
IFVzaW5nIFAyQSBicmlkZ2UgZm9yIGNvbmZpZ3VyYXRpb24KWyAgICA3LjAzMDc3M10gYXN0IDAw
MDQ6MDI6MDAuMDogW2RybV0gQVNUIDI1MDAgZGV0ZWN0ZWQKWyAgICA3LjAzNTgxN10gYXN0IDAw
MDQ6MDI6MDAuMDogW2RybV0gQW5hbG9nIFZHQSBvbmx5ClsgICAgNy4wNDA2OTBdIGFzdCAwMDA0
OjAyOjAwLjA6IFtkcm1dIGRyYW0gTUNMSz04MDAgTWh6IHR5cGU9OCBidXNfd2lkdGg9MTYKWyAg
ICA3LjA0NzU2Ml0gW1RUTV0gWm9uZSAga2VybmVsOiBBdmFpbGFibGUgZ3JhcGhpY3MgbWVtb3J5
OiAxNjI1MTA5MCBLaUIKWyAgICA3LjA1NDE2N10gW1RUTV0gWm9uZSAgIGRtYTMyOiBBdmFpbGFi
bGUgZ3JhcGhpY3MgbWVtb3J5OiAyMDk3MTUyIEtpQgpbICAgIDcuMDYwNjgyXSBbVFRNXSBJbml0
aWFsaXppbmcgcG9vbCBhbGxvY2F0b3IKWyAgICA3LjA2NTAzM10gW1RUTV0gSW5pdGlhbGl6aW5n
IERNQSBwb29sIGFsbG9jYXRvcgpbICAgIDcuMDcwMDE0XSBbZHJtXSBJbml0aWFsaXplZCBhc3Qg
MC4xLjAgMjAxMjAyMjggZm9yIDAwMDQ6MDI6MDAuMCBvbiBtaW5vciAwClsgICAgNy4wOTQ0NjVd
IENvbnNvbGU6IHN3aXRjaGluZyB0byBjb2xvdXIgZnJhbWUgYnVmZmVyIGRldmljZSAxMjh4NDgK
WyAgICA3LjEwMjkxN10gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gZmIwOiBhc3Rkcm1mYiBmcmFt
ZSBidWZmZXIgZGV2aWNlClsgICAgNy4xMjMzNzRdIGJyZDogbW9kdWxlIGxvYWRlZApbICAgIDcu
MTMwOTI5XSBsb29wOiBtb2R1bGUgbG9hZGVkClsgICAgNy4xMzQ1NTVdIG52bWUgbnZtZTA6IHBj
aSBmdW5jdGlvbiAwMDA1OjA0OjAwLjAKWyAgICA3LjEzOTUxMV0gaWdiOiBJbnRlbChSKSBHaWdh
Yml0IEV0aGVybmV0IE5ldHdvcmsgRHJpdmVyClsgICAgNy4xNDE0MjBdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjE0NDkw
M10gaWdiOiBDb3B5cmlnaHQgKGMpIDIwMDctMjAxNCBJbnRlbCBDb3Jwb3JhdGlvbi4KWyAgICA3
LjE1NzUyNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgIDcuMTYzMjYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAgNy4xNzA0MjBdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjE4Mzk0Nl0gbnZtZSBudm1lMDogbWlz
c2luZyBvciBpbnZhbGlkIFNVQk5RTiBmaWVsZC4KWyAgICA3LjE4NzQ4OF0gcHBzIHBwczA6IG5l
dyBQUFMgc291cmNlIHB0cDAKWyAgICA3LjE5MzI2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuMTkzMzAzXSBpZ2IgMDAw
NDowNDowMC4wOiBhZGRlZCBQSEMgb24gZXRoMApbICAgIDcuMTk5NzgxXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy4yMDQzMDBdIGlnYiAw
MDA0OjA0OjAwLjA6IEludGVsKFIpIEdpZ2FiaXQgRXRoZXJuZXQgTmV0d29yayBDb25uZWN0aW9u
ClsgICAgNy4yMDQzMDNdIGlnYiAwMDA0OjA0OjAwLjA6IGV0aDA6IChQQ0llOjIuNUdiL3M6V2lk
dGggeDEpIDAwOjMwOjY0OjNiOjUwOjUyClsgICAgNy4yMTAwMzhdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjIxNjk1N10g
aWdiIDAwMDQ6MDQ6MDAuMDogZXRoMDogUEJBIE5vOiAwMDAzMDAtMDAwClsgICAgNy4yMjQwMjRd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3
LjIyNDE0NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgIDcuMjMwNTQyXSBpZ2IgMDAwNDowNDowMC4wOiBVc2luZyBNU0ktWCBp
bnRlcnJ1cHRzLiA0IHJ4IHF1ZXVlKHMpLCA0IHR4IHF1ZXVlKHMpClsgICAgNy4yMzA1OTZdIGln
YnZmOiBJbnRlbChSKSBHaWdhYml0IFZpcnR1YWwgRnVuY3Rpb24gTmV0d29yayBEcml2ZXIKWyAg
ICA3LjIzNTY3MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgIDcuMjM1NzkzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy4yNDE0MDZdIGlnYnZmOiBDb3B5cmlnaHQgKGMp
IDIwMDkgLSAyMDEyIEludGVsIENvcnBvcmF0aW9uLgpbICAgIDcuMjQxNDIwXSBpNDBlOiBJbnRl
bChSKSBFdGhlcm5ldCBDb25uZWN0aW9uIFhMNzEwIE5ldHdvcmsgRHJpdmVyClsgICAgNy4yNDc5
MjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA3LjI0ODA0NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgIDcuMjU1NDgyXSBpNDBlOiBDb3B5cmlnaHQgKGMpIDIwMTMgLSAy
MDE5IEludGVsIENvcnBvcmF0aW9uLgpbICAgIDcuMjU1NjM5XSBpNDBlIDAwMDA6MDE6MDAuMDog
ZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAgNy4yNjE3MzldICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjI3ODgyNV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgIDcuMjgwMDE3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAgNy4yODYxNTJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjI4NjE1Nl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuMjkxODg4XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy4y
OTIwMDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgICA3LjI5ODQwNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgIDcuMjk4NDA3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy4zMDQyMjddICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjMwNDM0OV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgIDcuMzA5OTYyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAgNy4zMDk5NjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjMxNTY5OF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuMzE1ODE5XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAg
Ny4zMjIyMTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA3LjMyMjIxNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuMzI4NzMyXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy4zMzQ0NjddICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjM0MTEwMV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
IDcuMzQ2NzE3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAgNy4zNTMyMzNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjM1ODk2Nl0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuMzU4OTY4XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy4zNjU2
MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgICA3LjM3MTIxN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgIDcuMzcxMjIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy4zNzc3MzRdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjM3Nzg1NV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgIDcuMzgzNDcwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAgNy4zODM0NzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjM4OTk4Nl0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuMzkwMTA4XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy4z
OTU3MjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA3LjM5NTcyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgIDcuNDAyMjM5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy40MDc5NzNdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjQwNzk3NF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcu
NDE0NjA5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAgNy40MjAyMjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA3LjQyMDIyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNDI1OTU5XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy40MjYwODFd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgICA3LjQzMjQ3NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgIDcuNDMyNDc3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy40Mzg5OTNdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjQ0NDcyN10gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNDQ0NzI4
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAgNy40NTA1ODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjQ1Njk3N10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNDU2OTc5XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy40NjM0
OTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA3LjQ2MzYxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgIDcuNDY5MjMwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy40NzU3NDZdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjQ4MTQ4MV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNDg4
MTE5XSBudm1lIG52bWUwOiBhbGxvY2F0ZWQgNjQgTWlCIGhvc3QgbWVtb3J5IGJ1ZmZlci4KWyAg
ICA3LjQ5MzczMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgIDcuNDkzNzMyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy41MTI4MTZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjUxODIzOF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNTE4
MjQwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAgNy41MTgyNDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA3LjUxODI0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNTE4MjQzXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy41MTgyNDVdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgICA3LjUyNDc2Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgIDcuNTI0NzY1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy41MzA0OTldICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjUzNjIzM10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNTM2MjM5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAgNy41NDI3NTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgICA3LjU0OTI2N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNTU1MDAxXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy41NjE1MTldICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3
LjU2NzI1NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgIDcuNTczNzY5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAgNy41Nzk1MDRdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjU4NjAyM10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNTkxNzU3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAgNy41OTc0OTBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA3LjYwNDAwNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNjEwNTIzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy42MTYyNThdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
ICA3LjYyMjc3M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgIDcuNjI4NTA4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAgNy42MzUwMjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjY0MDc2Ml0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNjQ2
NTAwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAgNy42NTMwMTJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA3LjY1MzAxNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNjU4NjYzXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy42NjQzOTddICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjY3
MDkxMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgIDcuNjcwOTE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAgNy42Nzc0MjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3LjY4MzE2Ml0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNjgzMTY1XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAgNy42ODk2NzldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA3LjY4OTY4MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNjk1NDIyXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy43MDE5MzFdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjcwNzY2OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgIDcuNzE0MTgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAgNy43MTk5MTVdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3LjcxOTkxOF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNzI2NDMz
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAg
Ny43MzIxNjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA3LjczMjE3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNzM3OTAzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy43NDQ0MTddICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3Ljc0NDQy
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgIDcuNzUwOTM0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAgNy43NTA5MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3Ljc1NjY3MF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDcuNzU2Njc0XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAgNy43NjI0MDVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA3Ljc2MjQwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDcuNzY4OTIyXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgNy43Njg5MjRdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA3Ljc3
NTQzOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgIDcuNzgxMTcyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAgNy44NzkyMzFdIG52bWUgbnZtZTA6IDgvMC8wIGRlZmF1bHQvcmVhZC9wb2xs
IHF1ZXVlcwpbICAgIDcuODg0OTM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgNy44ODQ5MzddICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA3Ljk3NzI1NF0gIG52bWUwbjE6
IHAxIHAyIHAzClsgICAgNy45ODM3NDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjA4MzQwM10gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguMDg5MTM5XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAg
OC4wOTU2NTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA4LjEwMTM5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguMTA3OTEwXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4xMTM2NDVdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjEyMDE2
Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
IDguMTI1ODk5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAgOC4xMzI0MTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjEzODE1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguMTQ0NjY3XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4xNTA0
MDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgICA4LjE1NjkyMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgIDguMTYyNjU1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC4xNjkxNzFdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjE3NDkwN10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgIDguMTgxNDI0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAgOC4xODcxNTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjE5MzY3NV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguMTk5NDEwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC4y
MDU5MjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA4LjIxMTY2NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgIDguMjE4MTgxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4yMjM5MThdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjIzMDQzNF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDgu
MjM2MTY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAgOC4yNDI2ODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA4LjI0ODQyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguMjU0OTM4XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4yNjA2NzNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgICA4LjI2NzE4OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgIDguMjcyOTI0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC4yNzk0MzldICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjI4NTE3M10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
IDguMjkxNjk3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAgOC4yOTc0MzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjMwMzk0N10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguMzA5NjgyXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC4zMTYx
OThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA4LjMyMTkzMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgIDguMzI4NDQ5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4zMzQxODRdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjM0MDY5OV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguMzQ2
NDM0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAgOC4zNTI5NDldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA4LjM1ODY4NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguMzY1MjAwXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC4zNzA5MzVdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgICA4LjM3NzQ1Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgIDguMzgzMTg3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC4zODk3MDNdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjM5NTQzN10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDgu
NDAxOTUyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAgOC40MDc2ODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgICA4LjQxNDIwNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguNDE5OTM5XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC40MjY0NTRd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4
LjQzMjE4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgIDguNDM4NzA0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAgOC40NDQ0NDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjQ1MDk1Nl0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguNDU2Njkx
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAgOC40NjMyMDZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA4LjQ2ODk0MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguNDc1NDU2XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC40ODExOTFdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
ICA4LjQ4NzcwN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgIDguNDkzNDQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC40OTk5NTddICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjUwNTY5Ml0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguNTEy
MjA3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAgOC41MTc5NDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgICA4LjUyNDQ1OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguNTMwMTkzXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC41MzY3MDldICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjU0
MjQ0NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgIDguNTQ4OTYwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAgOC41NTQ2OTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjU2MTIxMV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguNTY2OTQ2XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAgOC41NzM0NjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA4LjU3OTE5Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguNTg1NzEyXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC41OTE0NDZdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4
LjU5Nzk2Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgIDguNjAzNjk3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAgOC42MTAyMTJdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjYxNTk0Nl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguNjIyNDYy
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAg
OC42MjgxOTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgICA4LjYzNDcxMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguNjQwNDQ2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC42NDY5NjFdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjY1MjY5
Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgIDguNjU5MjExXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAgOC42NjQ5NDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjY3MTQ2MV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguNjc3MTk2XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAgOC42ODM3MTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA4LjY4OTQ0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguNjk1OTYxXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC43MDE2OTZdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4Ljcw
ODIxMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgIDguNzEzOTQ3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAgOC43MjA0NjJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjcyNjE5N10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguNzMyNzEyXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC43
Mzg0NDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgICA4Ljc0NDk2M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgIDguNzUwNjk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC43NTcyMTNdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljc2Mjk0OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgIDguNzY5NDYzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAgOC43NzUxOThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4Ljc4MTcxNF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguNzg3NDQ4XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAg
OC43OTM5NjRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA4Ljc5OTY5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguODA2MjE0XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC44MTE5NDhdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjgxODQ2
NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
IDguODI0MTk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAgOC44MzA3MTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4LjgzNjQ0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguODQyOTYzXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC44NDg3
MDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgICA4Ljg1NTIxOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgIDguODYwOTUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC44Njc0NjddICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljg3MzIwMl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgIDguODc5NzE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAgOC44ODU0NTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4Ljg5MTk3MF0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDguODk3NzA1XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC45
MDQyMjBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA4LjkwOTk1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgIDguOTE2NDcwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC45MjIyMDVdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA4LjkyODcyMF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDgu
OTM0NDU1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAgOC45NDA5NzBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljk0NjcwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDguOTUzMjIxXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOC45NTg5NTVd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgICA4Ljk2NTQ3MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgIDguOTcxMjA1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOC45Nzc3MjFdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA4Ljk4MzQ1NV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
IDguOTg5OTcwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAgOC45OTU3MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjAwMjIyMV0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuMDA3OTU2XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS4wMTQ0
NzFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA5LjAyMDIwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgIDkuMDI2NzIxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS4wMzI0NTZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjAzODk3MV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuMDQ0
NzA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAgOS4wNTEyMjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA5LjA1Njk1Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuMDYzNDcxXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS4wNjkyMDZdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgICA5LjA3NTcyMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgIDkuMDgxNDU2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS4wODc5NzFdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjA5MzcwNV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDku
MTAwMjIxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAgOS4xMDU5NTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgICA5LjExMjQ3MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuMTE4MjA2XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS4xMjQ3MjFd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5
LjEzMDQ1Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgIDkuMTM2OTcxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAgOS4xNDI3MDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjE0OTIyMV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuMTU0OTU2
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAgOS4xNjE0NzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA5LjE2NzIwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuMTczNzIyXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS4xNzk0NTddICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
ICA5LjE4NTk3M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgIDkuMTkxNzA3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS4xOTgyMjNdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjIwMzk1OF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuMjEw
NDczXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAgOS4yMTYyMDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgICA5LjIyMjcyM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuMjI4NDU4XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS4yMzQ5NzNdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjI0
MDcwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgIDkuMjQ3MjIzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAgOS4yNTI5NThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjI1OTQ3M10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuMjY1MjA3XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAgOS4yNzE3MjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA5LjI3NzQ1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuMjgzOTczXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS4yODk3MDddICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5
LjI5NjIyMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgIDkuMzAxOTU3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAgOS4zMDg0NzJdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjMxNDIxM10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuMzIwNzI5
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAg
OS4zMjY0NjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgICA5LjMzMjk3OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuMzM4NzE0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS4zNDUyMjldICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjM1MDk2
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgIDkuMzU3NDgwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAgOS4zNjMyMTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjM2OTczMV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuMzc1NDY1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAgOS4zODE5ODFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgICA5LjM4NzcxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuMzk0MjMyXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS4zOTk5NjhdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjQw
NjQ4NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgIDkuNDEyMjE4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAgOS40MTg3MzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjQyNDQ2OV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuNDMwOTg0XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS40
MzY3MTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgICA5LjQ0MzIzNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgIDkuNDQ4OTY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS40NTU0ODRdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjQ2MTIxOV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgIDkuNDY3NzM0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAgOS40NzM0NzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjQ3OTk4NV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuNDg1NzIwXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAg
OS40OTIyMzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgICA5LjQ5Nzk3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuNTA0NDg2XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS41MTAyMjBdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjUxNjcz
Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
IDkuNTIyNDcwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAgOS41Mjg5ODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjUzNDcyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuNTQxMjM1XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS41NDY5
NzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgICA5LjU1MzQ4NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgIDkuNTU5MjIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS41NjU3MzVdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjU3MTQ3MF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgIDkuNTc3OTg2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAgOS41ODM3MjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjU5MDIzNl0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuNTk1OTcxXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS42
MDI0ODZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgICA5LjYwODIyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgIDkuNjE0NzM2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS42MjA0NzVdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjYyNjk5MF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDku
NjMyNzI1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAgOS42MzkyNDBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgICA5LjY0NDk3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuNjUxNDkwXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS42NTcyMjVd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgICA5LjY2Mzc0MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgIDkuNjY5NDc1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS42NzU5OTBdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjY4MTcyNV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
IDkuNjg4MjQwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAgOS42OTM5NzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjcwMDQ5MF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuNzA2MjI1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS43MTI3
NDBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
ICA5LjcxODQ3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgIDkuNzI0OTkwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS43MzA3MjVdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5LjczNzI0MF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuNzQy
OTc1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAgOS43NDk0OTBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgICA5Ljc1NTIyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuNzYxNzQwXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS43Njc0NzVdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgICA5Ljc3Mzk5MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgIDkuNzc5NzI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS43ODYyNDJdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljc5MTk3Nl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDku
Nzk4NDkxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAgOS44MDQyMjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgICA5LjgxMDc0Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuODE2NDc3XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS44MjI5OTJd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5
LjgyODcyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgIDkuODM1MjQyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAgOS44NDA5NzddICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5Ljg0NzQ5Ml0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuODUzMjI3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAgOS44NTk3NDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgICA5Ljg2NTQ3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuODcxOTkyXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS44Nzc3MjddICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
ICA5Ljg4NDI0Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgIDkuODg5OTc3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS44OTY0OTJdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5LjkwMjIyOF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuOTA4
NzQ2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAgOS45MTQ0ODFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgICA5LjkyMDk5N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuOTI2NzMxXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAgOS45MzMyNDZdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgICA5Ljkz
ODk4MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgIDkuOTQ1NDk2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAgOS45NTEyMzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5Ljk1Nzc0Nl0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgIDkuOTYzNDgxXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAgOS45Njk5OTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgICA5Ljk3NTczMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgIDkuOTgyMjQ3XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAgOS45ODc5ODJdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgICA5
Ljk5NDQ5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTAuMDAwMjMyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxMC4wMDY3NDhdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjAxMjQ4Ml0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuMDE4OTk3
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
MC4wMjQ3MzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDEwLjAzMTI0N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuMDM2OTgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC4wNDM0OTddICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjA0OTIz
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTAuMDU1NzQ3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxMC4wNjE0ODJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjA2ODAwMF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuMDczNzM1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxMC4wODAyNTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEwLjA4NTk4Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuMDkyNTAxXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC4wOTgyMzVdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjEw
NDc1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTAuMTEwNDg1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxMC4xMTcwMDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjEyMjczNV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuMTI5MjUwXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC4x
MzQ5ODZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDEwLjE0MTUwMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTAuMTQ3MjM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC4xNTM3NTFdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjE1OTQ4Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTAuMTY2MDAxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxMC4xNzE3MzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjE3ODI1MV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuMTgzOTg1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
MC4xOTA1MDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEwLjE5NjIzNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuMjAyNzUyXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC4yMDg0ODZdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjIxNTAw
MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTAuMjIwNzM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxMC4yMjcyNTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjIzMjk4Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuMjM5NTAxXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC4yNDUy
MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDEwLjI1MTc1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTAuMjU3NDg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC4yNjQwMDFdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjI2OTczNl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTAuMjc2MjUyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxMC4yODE5ODZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjI4ODUwMV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuMjk0MjM3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC4z
MDA3NTJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEwLjMwNjQ4N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTAuMzEzMDAyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC4zMTg3MzddICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjMyNTI1Ml0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAu
MzMwOTg3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxMC4zMzc1MDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjM0MzI0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuMzQ5NzU5XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC4zNTU0OTNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDEwLjM2MjAwOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTAuMzY3NzQ0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC4zNzQyNTldICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjM3OTk5NF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTAuMzg2NTA5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxMC4zOTIyNDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjM5ODc2Ml0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuNDA0NDk3XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC40MTEw
MTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEwLjQxNjc0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTAuNDIzMjY1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC40Mjg5OTldICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjQzNTUxNF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuNDQx
MjQ5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxMC40NDc3NjRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEwLjQ1MzQ5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuNDYwMDE0XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC40NjU3NDldICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDEwLjQ3MjI2NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTAuNDc3OTk5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC40ODQ1MTRdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjQ5MDI0OV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAu
NDk2NzY0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxMC41MDI0OTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjUwOTAxNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuNTE0NzQ5XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC41MjEyNjRd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEw
LjUyNjk5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTAuNTMzNTE0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxMC41MzkyNDldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjU0NTc2NF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuNTUxNDk5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxMC41NTgwMTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEwLjU2Mzc0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuNTcwMjY1XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC41NzU5OTldICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDEwLjU4MjUxNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTAuNTg4MjQ5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC41OTQ3NjRdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjYwMDQ5OV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuNjA3
MDE0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxMC42MTI3NTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDEwLjYxOTI2NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuNjI0OTk5XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC42MzE1MTVdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjYz
NzI0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTAuNjQzNzY1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxMC42NDk0OTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjY1NjAxNV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuNjYxNzUwXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxMC42NjgyNjVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEwLjY3NDAwMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuNjgwNTE1XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC42ODYyNTBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEw
LjY5Mjc2Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTAuNjk4NTAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxMC43MDUwMTZdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjcxMDc1MF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuNzE3MjY2
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
MC43MjMwMDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDEwLjcyOTUxNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuNzM1MjUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC43NDE3NjZdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjc0NzUw
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTAuNzU0MDE2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxMC43NTk3NTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjc2NjI2Nl0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuNzcyMDAxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxMC43Nzg1MTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEwLjc4NDI1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuNzkwNzY2XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC43OTY1MDFdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjgw
MzAxNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTAuODA4NzUxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxMC44MTUyNjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjgyMTAwNF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuODI3NTE5XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC44
MzMyNTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDEwLjgzOTc3MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTAuODQ1NTA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC44NTIwMjFdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjg1Nzc1Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTAuODY0MjcyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxMC44NzAwMDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjg3NjUyMl0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuODgyMjU2XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
MC44ODg3NzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEwLjg5NDUwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuOTAxMDIxXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC45MDY3NTZdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjkxMzI3
MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTAuOTE5MDA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxMC45MjU1MjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjkzMTI1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTAuOTM3Nzc0XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMC45NDM1
MDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDEwLjk1MDAyNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTAuOTU1NzU5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC45NjIyNzVdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEwLjk2ODAwOV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTAuOTc0NTI1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxMC45ODAyNTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEwLjk4Njc3NV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTAuOTkyNTEwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMC45
OTkwMjVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDExLjAwNDc2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTEuMDExMjc1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS4wMTcwMTBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjAyMzUyNl0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEu
MDI5MjYxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxMS4wMzU3NzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDExLjA0MTUxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuMDQ4MDI2XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS4wNTM3NjFd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDExLjA2MDI3N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTEuMDY2MDExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS4wNzI1MjddICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjA3ODI2Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTEuMDg0Nzc3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxMS4wOTA1MTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjA5NzAyN10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuMTAyNzYyXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS4xMDky
NzddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDExLjExNTAxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTEuMTIxNTI3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS4xMjcyNjJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjEzMzc3N10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuMTM5
NTExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxMS4xNDYwMjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDExLjE1MTc2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuMTU4Mjc2XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS4xNjQwMTJdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDExLjE3MDUyN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTEuMTc2MjY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS4xODI3ODBdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjE4ODUxNV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEu
MTk1MDMwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxMS4yMDA3NjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDExLjIwNzI4MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuMjEzMDE1XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS4yMTk1MzBd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEx
LjIyNTI2NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTEuMjMxNzgwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxMS4yMzc1MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjI0NDAzMV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuMjQ5NzY2
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxMS4yNTYyODFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDExLjI2MjAxNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuMjY4NTMxXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS4yNzQyNjZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDExLjI4MDc4MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTEuMjg2NTE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS4yOTMwMzFdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjI5ODc2Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuMzA1
MjgxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxMS4zMTEwMTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDExLjMxNzUzMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuMzIzMjY2XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS4zMjk3ODJdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjMz
NTUxN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTEuMzQyMDMyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxMS4zNDc3NjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjM1NDI4Ml0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuMzYwMDIzXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxMS4zNjY1MzhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDExLjM3MjI3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuMzc4Nzg5XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS4zODQ1MjRdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEx
LjM5MTAzOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTEuMzk2Nzc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxMS40MDMyODldICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjQwOTAyNF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuNDE1NTM5
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
MS40MjEyNzRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDExLjQyNzc4OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuNDMzNTI0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS40NDAwNDFdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjQ0NTc3
N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTEuNDUyMjkyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxMS40NTgwMjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjQ2NDU0M10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuNDcwMjc3XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxMS40NzY3OTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDExLjQ4MjUyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuNDg5MDQyXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS40OTQ3NzhdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjUw
MTI5M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTEuNTA3MDI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxMS41MTM1NDNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjUxOTI3OF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuNTI1NzkzXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS41
MzE1MjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDExLjUzODA0M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTEuNTQzNzc4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS41NTAyOTNdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjU1NjAyOF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTEuNTYyNTQzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxMS41NjgyNzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjU3NDc5M10gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuNTgwNTI4XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
MS41ODcwNDNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDExLjU5Mjc3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuNTk5MjkzXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS42MDUwMjhdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjYxMTU0
M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTEuNjE3Mjc4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxMS42MjM3OTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjYyOTUyN10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuNjM2MDQyXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS42NDE3
NzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDExLjY0ODI5M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTEuNjU0MDI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS42NjA1NDNdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjY2NjI3OF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTEuNjcyNzkzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxMS42Nzg1MjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjY4NTA0M10gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuNjkwNzc3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS42
OTcyOTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDExLjcwMzAyOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTEuNzA5NTQzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS43MTUyNzhdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjcyMTc5NF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEu
NzI3NTI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxMS43MzQwNDNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDExLjczOTc3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuNzQ2MjkzXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS43NTIwMjhd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDExLjc1ODU0M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTEuNzY0Mjc4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS43NzA3OTNdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjc3NjUyOF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTEuNzgzMDQzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxMS43ODg3NzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjc5NTI5M10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuODAxMDI4XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS44MDc1
NDNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDExLjgxMzI3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTEuODE5NzkzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS44MjU1MjddICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjgzMjA0M10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuODM3
Nzc3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxMS44NDQyOTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDExLjg1MDAyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuODU2NTQzXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS44NjIyNzhdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDExLjg2ODc5M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTEuODc0NTI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS44ODEwNDNdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjg4Njc3OF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEu
ODkzMjkzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxMS44OTkwMjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDExLjkwNTU0M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuOTExMjc4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS45MTc3OTNd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEx
LjkyMzUyOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTEuOTMwMDQzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxMS45MzU3NzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDExLjk0MjI5M10gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTEuOTQ4MDMw
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxMS45NTQ1NDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDExLjk2MDI4NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTEuOTY2Nzk5XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMS45NzI1MzRdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDExLjk3OTA1MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTEuOTg0Nzg0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMS45OTEzMDBdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDExLjk5NzAzNV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuMDAz
NTUwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxMi4wMDkyODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDEyLjAxNTgwMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuMDIxNTM1XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi4wMjgwNTBdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjAz
Mzc4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTIuMDQwMzAwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxMi4wNDYwMzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjA1MjU1MF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuMDU4Mjg0XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxMi4wNjQ4MDBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEyLjA3MDUzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuMDc3MDUxXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi4wODI3ODVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEy
LjA4OTMwMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTIuMDk1MDM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxMi4xMDE1NTFdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjEwNzI4Nl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuMTEzODAx
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Mi4xMTk1MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDEyLjEyNjA1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuMTMxNzg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi4xMzgzMDFdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjE0NDAz
Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTIuMTUwNTUxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxMi4xNTYyODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjE2MjgwMV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuMTY4NTM2XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxMi4xNzUwNTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEyLjE4MDc4Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuMTg3MzAxXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi4xOTMwMzZdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjE5
OTU1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTIuMjA1Mjg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxMi4yMTE4MDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjIxNzUzNl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuMjI0MDUxXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi4y
Mjk3ODZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDEyLjIzNjMwMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTIuMjQyMDM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi4yNDg1NTJdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjI1NDI4Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTIuMjYwODAxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxMi4yNjY1MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjI3MzA1Ml0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuMjc4Nzg3XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
Mi4yODUzMDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEyLjI5MTAzN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuMjk3NTUyXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi4zMDMyODhdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjMwOTgw
M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTIuMzE1NTM3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxMi4zMjIwNTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjMyNzc4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuMzM0MzAzXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi4zNDAw
MzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDEyLjM0NjU1M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTIuMzUyMjg3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi4zNTg4MDJdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjM2NDUzN10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTIuMzcxMDYwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxMi4zNzY3OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjM4MzMxOF0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuMzg5MDU0XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi4z
OTU1NjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEyLjQwMTMwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTIuNDA3ODE5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi40MTM1NTRdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjQyMDA2OV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIu
NDI1ODA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxMi40MzIzMjBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjQzODA1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuNDQ0NTcwXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi40NTAzMDVd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDEyLjQ1NjgyMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTIuNDYyNTU1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi40NjkwNzNdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjQ3NDgwOV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTIuNDgxMzI1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxMi40ODcwNjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjQ5MzU3NV0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuNDk5MzEwXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi41MDU4
MjVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEyLjUxMTU2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTIuNTE4MDc2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi41MjM4MTBdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjUzMDMyNl0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuNTM2
MDYwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxMi41NDI1NzVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEyLjU0ODMxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuNTU0ODI1XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi41NjA1NjBdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDEyLjU2NzA3NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTIuNTcyODEwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi41NzkzMjVdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjU4NTA2MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIu
NTkxNTc1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxMi41OTczMTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjYwMzgyNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuNjA5NTYwXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi42MTYwNzVd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEy
LjYyMTgxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTIuNjI4MzI1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxMi42MzQwNjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjY0MDU3NV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuNjQ2MzA5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxMi42NTI4MjVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEyLjY1ODU2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuNjY1MDc2XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi42NzA4MTBdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDEyLjY3NzMyNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTIuNjgzMDYxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi42ODk1NzZdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjY5NTMxMV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuNzAx
ODI3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxMi43MDc1NjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDEyLjcxNDA3N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuNzE5ODE1XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi43MjYzMzBdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjcz
MjA2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTIuNzM4NTgxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxMi43NDQzMTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjc1MDgzMF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuNzU2NTY2XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxMi43NjMwODFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEyLjc2ODgxNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuNzc1MzMxXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi43ODEwNjZdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEy
Ljc4NzU4MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTIuNzkzMzE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxMi43OTk4MzFdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjgwNTU2NV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuODEyMDgx
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Mi44MTc4MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDEyLjgyNDMzMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuODMwMDY1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi44MzY1ODBdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjg0MjMx
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTIuODQ4ODMwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxMi44NTQ1NjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjg2MTA4MF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuODY2ODE1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxMi44NzMzMzBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEyLjg3OTA2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuODg1NTgzXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi44OTEzMTldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjg5
NzgzNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTIuOTAzNTY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxMi45MTAwODRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjkxNTgxOV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuOTIyMzM1XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMi45
MjgwNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDEyLjkzNDU4NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTIuOTQwMzIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMi45NDY4MzVdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEyLjk1MjU3MF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTIuOTU5MDg1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxMi45NjQ4MjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEyLjk3MTMzNV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTIuOTc3MDcxXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
Mi45ODM1ODhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEyLjk4OTMyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTIuOTk1ODM3XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy4wMDE1NzJdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjAwODA4
N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTMuMDEzODIyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxMy4wMjAzMzddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjAyNjA3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuMDMyNTg4XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy4wMzgz
MjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDEzLjA0NDgzOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTMuMDUwNTczXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy4wNTcwODhdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjA2MjgyM10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTMuMDY5MzM4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxMy4wNzUwNzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjA4MTU4OF0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuMDg3MzIzXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy4w
OTM4MzldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEzLjA5OTU3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTMuMTA2MDg5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy4xMTE4MjRdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjExODMzOV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMu
MTI0MDc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxMy4xMzA1ODldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjEzNjMyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuMTQyODQyXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy4xNDg1Nzdd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDEzLjE1NTA5Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTMuMTYwODI3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy4xNjczNDJdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjE3MzA3OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTMuMTc5NTkzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxMy4xODUzMjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjE5MTg0M10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuMTk3NTc5XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy4yMDQw
OTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEzLjIwOTgyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTMuMjE2MzQ1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy4yMjIwODBdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjIyODU5NV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuMjM0
MzMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxMy4yNDA4NDVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEzLjI0NjU4MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuMjUzMDk2XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy4yNTg4MzFdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDEzLjI2NTM0N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTMuMjcxMDgxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy4yNzc1OTddICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjI4MzMzMl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMu
Mjg5ODQ4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxMy4yOTU1ODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjMwMjA5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuMzA3ODMzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy4zMTQzNDld
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEz
LjMyMDA4NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTMuMzI2NTk5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxMy4zMzIzMzRdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjMzODg0OV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuMzQ0NTg0
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxMy4zNTExMDBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDEzLjM1NjgzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuMzYzMzUxXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy4zNjkwODZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDEzLjM3NTYwMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTMuMzgxMzM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy4zODc4NTFdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjM5MzU4Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuNDAw
MTAxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxMy40MDU4NDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDEzLjQxMjM1N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuNDE4MDkyXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy40MjQ2MDhdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjQz
MDM0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTMuNDM2ODU3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxMy40NDI1OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjQ0OTEwOF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuNDU0ODQzXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxMy40NjEzNThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDEzLjQ2NzA5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuNDczNjA4XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy40NzkzNDNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEz
LjQ4NTg1OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTMuNDkxNjAwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxMy40OTgxMTZdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjUwMzg1MV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuNTEwMzY2
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
My41MTYxMDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDEzLjUyMjYxN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuNTI4MzUxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy41MzQ4NjddICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjU0MDYw
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTMuNTQ3MTE3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxMy41NTI4NTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjU1OTM2N10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuNTY1MTAyXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxMy41NzE2MTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDEzLjU3NzM1Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuNTgzODY3XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy41ODk2MDJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjU5
NjExN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTMuNjAxODUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxMy42MDgzNjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjYxNDEwMl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuNjIwNjE3XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy42
MjYzNTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDEzLjYzMjg2N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTMuNjM4NjAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy42NDUxMTddICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjY1MDg1MV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTMuNjU3MzY3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxMy42NjMxMDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjY2OTYxN10gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuNjc1MzUxXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
My42ODE4NjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDEzLjY4NzYwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuNjk0MTE2XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy42OTk4NTFdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjcwNjM2
Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTMuNzEyMTAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxMy43MTg2MTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjcyNDM1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuNzMwODY3XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy43MzY2
MDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDEzLjc0MzExN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTMuNzQ4ODUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy43NTUzNjddICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjc2MTEwMl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTMuNzY3NjE3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxMy43NzMzNTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjc3OTg2OF0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuNzg1NjAzXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy43
OTIxMThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDEzLjc5Nzg1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTMuODA0MzY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy44MTAxMDRdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjgxNjYxOV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMu
ODIyMzUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxMy44Mjg4NjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjgzNDYwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuODQxMTE5XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy44NDY4NTNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDEzLjg1MzM2OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTMuODU5MTAzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy44NjU2MThdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDEzLjg3MTM1M10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTMuODc3ODY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxMy44ODM2MDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjg5MDExOV0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuODk1ODU0XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxMy45MDIz
NjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDEzLjkwODEwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTMuOTE0NjE5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy45MjAzNTRdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDEzLjkyNjg2OV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTMuOTMy
NjA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxMy45MzkxMjBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDEzLjk0NDg1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTMuOTUxMzcwXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxMy45NTcxMDVdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDEzLjk2MzYyMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTMuOTcwMzEwXSBpNDBlIDAwMDA6MDE6MDAuMDogZncgNi4wLjQ4NDQyIGFw
aSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5XSBbODA4NjowMDAy
XQpbICAgMTQuMjU4MTkxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxNC4yNjQ3MDddICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjI3MDU1NV0gaTQwZSAwMDAwOjAxOjAw
LjA6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMApbICAgMTQuMjc2NDQ0XSBpNDBlIDAw
MDA6MDE6MDAuMDogRlcgTExEUCBpcyBlbmFibGVkClsgICAxNC4yODcxMTBdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0LjI5
MzYzMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTQuMjk5MzY3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxNC4zMDU4ODNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjMxMTc5MF0gaTQwZSAwMDAwOjAxOjAwLjA6
IFBDSS1FeHByZXNzOiBTcGVlZCA4LjBHVC9zIFdpZHRoIHg4ClsgICAxNC4zMTkwNDldIGk0MGUg
MDAwMDowMTowMC4wOiBGZWF0dXJlczogUEYtaWRbMF0gVlNJczogMzQgUVA6IDMyIFJTUyBGRF9B
VFIgRkRfU0IgTlRVUExFIFZ4TEFOIEdlbmV2ZSBQVFAgVkVQQQpbICAgMTQuMzI5MjMwXSBpNDBl
IDAwMDA6MDE6MDAuMTogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAxNC4zNDU1
NDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE0LjM1MjA1N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTQuMzU3Nzk0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC4zNjQzMTBdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjM3MDA0Nl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTQuMzc2NTYyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNC4zODIyOTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0LjM4ODgxMV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuMzk0NTQ3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC40
MDEwNjJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE0LjQwNjc5N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTQuNDEzMzEzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC40MTkwNDhdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0LjQyNTU2M10g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQu
NDMxMjk3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxNC40Mzc4MTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjQ0MzU0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQuNDUwMDYzXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC40NTU3OThd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDE0LjQ2MjMxM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTQuNDY4MDQ4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC40NzQ1NjNdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjQ4MDI5OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTQuNDg2ODE0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNC40OTI1NDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0LjQ5OTA2M10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuNTA0Nzk4XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC41MTEz
MTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE0LjUxNzA1MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTQuNTIzNTY2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC41MjkzMDBdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0LjUzNTgxNl0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuNTQx
NTUxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxNC41NDgwNjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE0LjU1MzgwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQuNTYwMzE3XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC41NjYwNTJdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDE0LjU3MjU2OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTQuNTc4MzAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC41ODQ4MThdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjU5MDU1Nl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQu
NTk3MDcyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNC42MDI4MDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDE0LjYwOTMyMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuNjE1MDU2XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC42MjE1NzJd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0
LjYyNzMwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTQuNjMzODIyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNC42Mzk1NTddICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0LjY0NjA3Ml0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuNjUxODA3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxNC42NTgzMjJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE0LjY2NDA1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQuNjcwNTcyXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC42NzYzMDddICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDE0LjY4MjgyMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTQuNjg4NTU3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC42OTUwNzNdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjcwMDgwN10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQuNzA3
MzIzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNC43MTMwNTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDE0LjcxOTU3M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuNzI1MzA3XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC43MzE4MjJdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0Ljcz
NzU1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTQuNzQ0MDcyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNC43NDk4MDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0Ljc1NjMyM10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuNzYyMDU4XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxNC43Njg1NzNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE0Ljc3NDMwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQuNzgwODIzXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC43ODY1NThdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0
Ljc5MzA3NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTQuNzk4ODA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxNC44MDUzMjRdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjgxMTA1OF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQuODE3NTcz
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
NC44MjMzMDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDE0LjgyOTgyM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuODM1NTU5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC44NDIwNzRdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0Ljg0Nzgw
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTQuODU0MzI0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNC44NjAwNTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0Ljg2NjU3NF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuODcyMzA5XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxNC44Nzg4MjVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE0Ljg4NDU1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQuODkxMDc0XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC44OTY4MDldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0Ljkw
MzMyNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTQuOTA5MDU5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxNC45MTU1NzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0LjkyMTMwOV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTQuOTI3ODI0XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNC45
MzM1NTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDE0Ljk0MDA3NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTQuOTQ1ODA5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNC45NTIzMjRdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE0Ljk1ODA1OV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTQuOTY0NTc1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNC45NzAzMDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE0Ljk3NjgyNV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTQuOTgyNTU5XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
NC45ODkwNzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDE0Ljk5NDgwOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuMDAxMzI1XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4wMDcwNTldICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjAxMzU3
NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTUuMDE5MzEwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxNS4wMjU4MjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjAzMTU2M10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuMDM4MDc4XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4wNDM4
MTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE1LjA1MDMyOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTUuMDU2MDYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS4wNjI1NzhdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjA2ODMxM10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTUuMDc0ODI4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNS4wODA1NjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjA4NzA3OF0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuMDkyODEzXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS4w
OTkzMjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE1LjEwNTA2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTUuMTExNTc4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4xMTczMTNdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjEyMzgyOF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUu
MTI5NTYyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxNS4xMzYwNzhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjE0MTgxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuMTQ4MzI4XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4xNTQwNjJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDE1LjE2MDU3N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTUuMTY2MzEyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS4xNzI4MjhdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjE3ODU2M10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTUuMTg1MDc4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNS4xOTA4MTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjE5NzMyOV0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuMjAzMDY0XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS4yMDk1
NzldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE1LjIxNTMxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTUuMjIxODI5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4yMjc1NjNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjIzNDA3OV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuMjM5
ODEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxNS4yNDYzMjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE1LjI1MjA2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuMjU4NTc4XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4yNjQzMTNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDE1LjI3MDgyOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTUuMjc2NTYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS4yODMwNzhdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjI4ODgxM10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUu
Mjk1MzI4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNS4zMDEwNjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjMwNzU3OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuMzEzMzE0XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS4zMTk4Mjld
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1
LjMyNTU2NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTUuMzMyMDc5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4zMzc4MTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjM0NDMyOV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuMzUwMDY0
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxNS4zNTY1NzldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE1LjM2MjMyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuMzY4ODM5XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS4zNzQ1NzNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDE1LjM4MTA4OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTUuMzg2ODI0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS4zOTMzMzldICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjM5OTA3NF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuNDA1
NTkwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNS40MTEzMjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDE1LjQxNzg0MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuNDIzNTc1XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS40MzAwOTBdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjQz
NTgyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTUuNDQyMzQwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNS40NDgwNzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjQ1NDU5MF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuNDYwMzI1XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxNS40NjY4NDBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE1LjQ3MjU3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuNDc5MDkwXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS40ODQ4MjRdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1
LjQ5MTM0MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTUuNDk3MDc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxNS41MDM1OTBdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjUwOTMyNF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuNTE1ODQw
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
NS41MjE1NzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDE1LjUyODA5MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuNTMzODI1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS41NDAzNDNdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjU0NjA3
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTUuNTUyNTk0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNS41NTgzMjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjU2NDg0M10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuNTcwNTc4XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxNS41NzcwOTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE1LjU4MjgyOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuNTg5MzQ0XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS41OTUwNzldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjYw
MTU5NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTUuNjA3MzI5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxNS42MTM4NDRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjYxOTU3OV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuNjI2MDk0XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS42
MzE4MjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDE1LjYzODM0NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTUuNjQ0MDc5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS42NTA1OTRdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjY1NjMyOV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTUuNjYyODQ0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNS42Njg1NzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjY3NTA5NF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuNjgwODI4XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
NS42ODczNDRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDE1LjY5MzA3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuNjk5NTk1XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS43MDUzMjldICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjcxMTg0
NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTUuNzE3NTc5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxNS43MjQwOTVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1LjcyOTgzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuNzM2MzQ1XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS43NDIw
ODBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE1Ljc0ODU5NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTUuNzU0MzMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS43NjA4NDVdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1Ljc2NjU4MF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTUuNzczMDk1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNS43Nzg4MzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1Ljc4NTM0Nl0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuNzkxMDgwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS43
OTc1OTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE1LjgwMzMzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTUuODA5ODQ3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS44MTU1ODFdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjgyMjA5Nl0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUu
ODI3ODMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxNS44MzQzNDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE1Ljg0MDA4Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuODQ2NTk3XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS44NTIzMzJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDE1Ljg1ODg0N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTUuODY0NTgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS44NzEwOTddICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1Ljg3NjgzMl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTUuODgzMzQ3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNS44ODkwODJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1Ljg5NTU5N10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuOTAxMzMyXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS45MDc4
NDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE1LjkxMzU4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTUuOTIwMDk4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS45MjU4MzNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE1LjkzMjM0OF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTUuOTM4
MDgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxNS45NDQ1OThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE1Ljk1MDMzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUuOTU2ODQ4XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNS45NjI1ODNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDE1Ljk2OTA5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTUuOTc0ODMzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNS45ODEzNDhdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE1Ljk4NzA4NV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTUu
OTkzNjAxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNS45OTkzMzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjAwNTg1Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuMDExNTg3XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi4wMTgxMDJd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2
LjAyMzgzN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTYuMDMwMzUzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4wMzYwODddICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjA0MjYwMl0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuMDQ4MzM4
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxNi4wNTQ4NTVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE2LjA2MDU5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuMDY3MTA1XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4wNzI4NDBdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDE2LjA3OTM1NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTYuMDg1MDkwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi4wOTE2MDVdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjA5NzMzOV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuMTAz
ODU1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNi4xMDk1OTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDE2LjExNjEwNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuMTIxODQwXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi4xMjgzNTVdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjEz
NDA5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTYuMTQwNjA4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNi4xNDYzNDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjE1Mjg1OF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuMTU4NTkyXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxNi4xNjUxMDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE2LjE3MDg0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuMTc3MzU3XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4xODMwOTJdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2
LjE4OTYwN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTYuMTk1MzQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxNi4yMDE4NTddICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjIwNzU5M10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuMjE0MTEw
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ni4yMTk4NDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDE2LjIyNjM2MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuMjMyMDk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi4yMzg2MTBdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjI0NDM0
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTYuMjUwODYwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNi4yNTY1OTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjI2MzExMV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuMjY4ODQ1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxNi4yNzUzNjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE2LjI4MTA5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuMjg3NjEwXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4yOTMzNDVdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjI5
OTg2MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTYuMzA1NTk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxNi4zMTIxMTBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjMxNzg0NV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuMzI0MzYwXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi4z
MzAwOTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDE2LjMzNjYxMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTYuMzQyMzQ1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi4zNDg4NjBdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjM1NDU5NV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTYuMzYxMTEwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNi4zNjY4NDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjM3MzM2MF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuMzc5MDk2XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
Ni4zODU2MTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDE2LjM5MTM1Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuMzk3ODY3XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi40MDM2MDJdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjQxMDEx
OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTYuNDE1ODUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxNi40MjIzNjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjQyODEwM10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuNDM0NjE5XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi40NDAz
NTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE2LjQ0Njg2OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTYuNDUyNjAzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi40NTkxMThdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjQ2NDg1M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTYuNDcxMzY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNi40NzcxMDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjQ4MzYxOF0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuNDg5MzUzXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi40
OTU4NjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE2LjUwMTYwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTYuNTA4MTE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi41MTM4NTNdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjUyMDM2OV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYu
NTI2MTA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxNi41MzI2MTldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjUzODM1NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuNTQ0ODY5XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi41NTA2MDRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDE2LjU1NzExOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTYuNTYyODU1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi41NjkzNzJdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjU3NTEwN10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTYuNTgxNjIyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNi41ODczNTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjU5Mzg3Ml0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuNTk5NjA3XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi42MDYx
MjJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE2LjYxMTg1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTYuNjE4MzcyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi42MjQxMDddICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjYzMDYyM10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuNjM2
MzU3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxNi42NDI4NzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE2LjY0ODYwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuNjU1MTIyXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi42NjA4NTddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDE2LjY2NzM3M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTYuNjczMTA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi42Nzk2MjNdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjY4NTM1OF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYu
NjkxODczXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNi42OTc2MDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDE2LjcwNDEyM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuNzA5ODU4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi43MTYzNzNd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2
LjcyMjEwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTYuNzI4NjIzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNi43MzQzNTddICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2Ljc0MDg3M10gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuNzQ2NjA3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxNi43NTMxMjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE2Ljc1ODg1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuNzY1MzczXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi43NzExMDddICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDE2Ljc3NzYyM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTYuNzgzMzU3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi43ODk4NzJdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2Ljc5NTYwN10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuODAy
MTIyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNi44MDc4NTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDE2LjgxNDM3Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuODIwMTA3XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi44MjY2MjJdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2Ljgz
MjM1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTYuODM4ODczXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNi44NDQ2MDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2Ljg1MTEyM10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuODU2ODU4XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxNi44NjMzNzNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE2Ljg2OTEwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuODc1NjIzXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi44ODEzNThdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2
Ljg4Nzg3M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTYuODkzNjA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxNi45MDAxMjNdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2LjkwNTg2M10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuOTEyMzc4
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ni45MTgxMTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDE2LjkyNDYyOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuOTMwMzYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNi45MzY4NzhdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE2Ljk0MjYx
M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTYuOTQ5MTI4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNi45NTQ4NjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2Ljk2MTM3OV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTYuOTY3MTEzXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxNi45NzM2MjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE2Ljk3OTM2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTYuOTg1ODc5XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNi45OTE2MTRdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE2Ljk5
ODEyOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTcuMDAzODY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxNy4wMTAzODBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjAxNjExNV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuMDIyNjMwXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4w
MjgzNjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDE3LjAzNDg4MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTcuMDQwNjE1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy4wNDcxMzFdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjA1Mjg2Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTcuMDU5MzgxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNy4wNjUxMTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjA3MTYzMl0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuMDc3MzY5XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
Ny4wODM4ODRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDE3LjA4OTYxOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuMDk2MTM0XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4xMDE4NjhdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjEwODM4
NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTcuMTE0MTE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxNy4xMjA2MzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjEyNjM2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuMTMyODg0XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4xMzg2
MTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE3LjE0NTEzNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTcuMTUwODY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy4xNTczODRdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjE2MzExOF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTcuMTY5NjM0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNy4xNzUzNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjE4MTg4NV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuMTg3NjE5XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy4x
OTQxMzVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE3LjE5OTg2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTcuMjA2Mzg1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4yMTIxMTldICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjIxODYzNV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcu
MjI0MzcwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxNy4yMzA4ODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjIzNjYyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuMjQzMTM1XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4yNDg4NzFd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDE3LjI1NTM4Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTcuMjYxMTIxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy4yNjc2MzZdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjI3MzM3MV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTcuMjc5ODg3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNy4yODU2MjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjI5MjEzN10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuMjk3ODcxXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy4zMDQz
ODZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE3LjMxMDEyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTcuMzE2NjM3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4zMjIzNzJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjMyODg4N10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuMzM0
NjIyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxNy4zNDExMzddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE3LjM0Njg3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuMzUzMzg3XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy4zNTkxMjJdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDE3LjM2NTYzOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTcuMzcxMzcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy4zNzc4ODhdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjM4MzYyMl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcu
MzkwMTM4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxNy4zOTU4NzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjQwMjM4N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuNDA4MTI4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy40MTQ2NDRd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3
LjQyMDM3OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTcuNDI2ODk0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxNy40MzI2MjldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjQzOTE0NF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuNDQ0ODc5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxNy40NTEzOTVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE3LjQ1NzEyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuNDYzNjQ1XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy40NjkzNzldICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDE3LjQ3NTg5NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTcuNDgxNjI5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy40ODgxNDVdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjQ5Mzg4Ml0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuNTAw
Mzk3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxNy41MDYxMzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDE3LjUxMjY1Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuNTE4Mzg3XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy41MjQ5MDJdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjUz
MDYzN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTcuNTM3MTUzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxNy41NDI4ODddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjU0OTQwM10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuNTU1MTM4XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxNy41NjE2NTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE3LjU2NzM4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuNTczOTAzXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy41Nzk2MzhdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3
LjU4NjE1NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTcuNTkxODkxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxNy41OTg0MDddICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjYwNDE0MV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuNjEwNjU3
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
Ny42MTYzOTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDE3LjYyMjkwN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuNjI4NjQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy42MzUxNTddICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjY0MDg5
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTcuNjQ3NDA3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxNy42NTMxNDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjY1OTY1OF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuNjY1MzkzXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxNy42NzE5MDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE3LjY3NzY0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuNjg0MTU4XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy42ODk4OTVdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjY5
NjQxMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTcuNzAyMTQ1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxNy43MDg2NjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjcxNDM5Nl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuNzIwOTExXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy43
MjY2NDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDE3LjczMzE2MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTcuNzM4ODk2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy43NDU0MTFdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3Ljc1MTE0Nl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTcuNzU3NjYxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxNy43NjMzOTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3Ljc2OTkxMV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuNzc1NjQ1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
Ny43ODIxNjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDE3Ljc4Nzg5NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuNzk0NDExXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy44MDAxNDVdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjgwNjY2
MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTcuODEyMzk2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxNy44MTg5MTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjgyNDY0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuODMxMTYxXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy44MzY4
OTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE3Ljg0MzQxMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTcuODQ5MTQ3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy44NTU2NjJdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3Ljg2MTM5N10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTcuODY3OTEzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxNy44NzM2NDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3Ljg4MDE2M10gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuODg1ODk4XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy44
OTI0MTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE3Ljg5ODE0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTcuOTA0NjYzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy45MTAzOThdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3LjkxNjkxM10g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcu
OTIyNjQ4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxNy45MjkxNjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE3LjkzNDg5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTcuOTQxNDEzXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxNy45NDcxNDhd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDE3Ljk1MzY2M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTcuOTU5Mzk3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxNy45NjU5MTNdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE3Ljk3MTY0N10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTcuOTc4MTYzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxNy45ODM4OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE3Ljk5MDQxMl0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTcuOTk2MTQ4XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC4wMDI2
NjRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE4LjAwODM5OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTguMDE0OTE0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4wMjA2NDldICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjAyNzE2NF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguMDMy
ODk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxOC4wMzk0MTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE4LjA0NTE0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguMDUxNjY0XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4wNTczOThdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDE4LjA2MzkxNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTguMDY5NjQ5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC4wNzYxNjRdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjA4MTkwMF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTgu
MDg4NDE1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOC4wOTQxNTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjEwMDY2OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguMTA2NDAzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC4xMTI5MThd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4
LjExODY1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTguMTI1MTY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4xMzA5MDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjEzNzQxOF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguMTQzMTUz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxOC4xNDk2NjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE4LjE1NTQwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguMTYxOTE4XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4xNjc2NTNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDE4LjE3NDE2OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTguMTc5OTAzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC4xODY0MThdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjE5MjE1M10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguMTk4
NjY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOC4yMDQ0MDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDE4LjIxMDkxOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguMjE2NjUzXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC4yMjMxNjhdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjIy
ODkwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTguMjM1NDE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOC4yNDExNTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjI0NzY2OF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguMjUzNDAyXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxOC4yNTk5MThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE4LjI2NTY1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguMjcyMTY4XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4yNzc5MDNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4
LjI4NDQxOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTguMjkwMTUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxOC4yOTY2NjldICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjMwMjQwM10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguMzA4OTE5
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OC4zMTQ2NTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDE4LjMyMTE2OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguMzI2OTA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC4zMzM0MjBdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjMzOTE1
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTguMzQ1NjcwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOC4zNTE0MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjM1NzkyMF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguMzYzNjU1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxOC4zNzAxNzBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE4LjM3NTkwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguMzgyNDIwXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC4zODgxNTRdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjM5
NDY3MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTguNDAwNDA1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxOC40MDY5MjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjQxMjY1NV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguNDE5MTcxXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC40
MjQ5MDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDE4LjQzMTQyN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTguNDM3MTYyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC40NDM2NzhdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjQ0OTQxMl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTguNDU1OTI4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOC40NjE2NjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjQ2ODE4MF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguNDczOTE1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
OC40ODA0MzBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDE4LjQ4NjE2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguNDkyNjgxXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC40OTg0MTZdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjUwNDkz
MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTguNTEwNjY2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxOC41MTcxODFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjUyMjkxNl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguNTI5NDMxXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC41MzUx
NjZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE4LjU0MTY4Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTguNTQ3NDE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC41NTM5MzJdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjU1OTY2Nl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTguNTY2MTgyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOC41NzE5MTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjU3ODQzMV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguNTg0MTY2XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC41
OTA2ODFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE4LjU5NjQxNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTguNjAyOTMxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC42MDg2NjhdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjYxNTE4NF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTgu
NjIwOTE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxOC42Mjc0MzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjYzMzE2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguNjM5Njg0XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC42NDU0MTld
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDE4LjY1MTkzNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTguNjU3NjY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC42NjQxODRdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4LjY2OTkxOV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTguNjc2NDM0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOC42ODIxNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjY4ODY4NF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguNjk0NDE5XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC43MDA5
MzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE4LjcwNjY2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTguNzEzMTg0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC43MTg5MTldICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjcyNTQzNF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguNzMx
MTY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxOC43Mzc2ODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE4Ljc0MzQxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguNzQ5OTM0XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC43NTU2NzBdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDE4Ljc2MjE4NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTguNzY3OTIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC43NzQ0MzVdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4Ljc4MDE3MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTgu
Nzg2Njg1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOC43OTI0MTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDE4Ljc5ODkzNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguODA0NjY5XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC44MTExODRd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4
LjgxNjkxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTguODIzNDM0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOC44MjkxNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4LjgzNTY4NF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguODQxNDE5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxOC44NDc5MzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE4Ljg1MzY2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguODYwMTg0XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC44NjU5MTldICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDE4Ljg3MjQzNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTguODc4MTY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC44ODQ2ODRdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4Ljg5MDQxOV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguODk2
OTM0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOC45MDI2NjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDE4LjkwOTE4NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguOTE0OTIwXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOC45MjE0MzVdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE4Ljky
NzE3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTguOTMzNjg1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOC45Mzk0MjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4Ljk0NTkzNV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTguOTUxNjcwXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxOC45NTgxODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE4Ljk2MzkyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTguOTcwNDM1XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOC45NzYxNzBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE4
Ljk4MjY4NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTguOTg4NDIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxOC45OTQ5MzVdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjAwMDY3MF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuMDA3MTg1
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OS4wMTI5MjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDE5LjAxOTQzNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuMDI1MTcwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS4wMzE2ODZdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjAzNzQy
MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTkuMDQzOTM2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOS4wNDk2NzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjA1NjE4Nl0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuMDYxOTIxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxOS4wNjg0MzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE5LjA3NDE3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuMDgwNjg2XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4wODY0MjFdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjA5
MjkzNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTkuMDk4NjcxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxOS4xMDUxODZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjExMDkyMV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuMTE3NDM3XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4x
MjMxNzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDE5LjEyOTY5MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTkuMTM1NDI1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS4xNDE5NDBdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjE0NzY3NV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTkuMTU0MTkwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOS4xNTk5MjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjE2NjQ0MF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuMTcyMTc0XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
OS4xNzg2ODldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDE5LjE4NDQyNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuMTkwOTM5XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4xOTY2NzRdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjIwMzE5
MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTkuMjA4OTI0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxOS4yMTU0NDBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjIyMTE3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuMjI3NjkwXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4yMzM0
MjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE5LjIzOTk0NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTkuMjQ1Njc5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS4yNTIxOTVdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjI1NzkzMF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTkuMjY0NDQ1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOS4yNzAxODBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjI3NjY5NV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuMjgyNDMwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS4y
ODg5NDVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE5LjI5NDY4MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTkuMzAxMTk1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4zMDY5MzBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjMxMzQ0NV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTku
MzE5MTgwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAxOS4zMjU2OTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjMzMTQzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuMzM3OTQ1XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS4zNDM2ODBd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDE5LjM1MDE5Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMTkuMzU1OTMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS4zNjI0NDZdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjM2ODE4MV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MTkuMzc0Njk2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAxOS4zODA0MzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjM4Njk0Nl0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuMzkyNjgxXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS4zOTkx
OTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDE5LjQwNDkzMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMTkuNDExNDQ3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS40MTcxODJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjQyMzY5N10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuNDI5
NDMyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAxOS40MzU5NDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDE5LjQ0MTY4Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuNDQ4MTk3XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS40NTM5MzhdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDE5LjQ2MDQ1M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMTkuNDY2MTg4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS40NzI3MDRdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjQ3ODQzOF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTku
NDg0OTUzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAxOS40OTA2ODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjQ5NzIwM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuNTAyOTM4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS41MDk0NTNd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5
LjUxNTE4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMTkuNTIxNzAzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAxOS41Mjc0MzldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjUzMzk1NF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuNTM5Njg5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAxOS41NDYyMDRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDE5LjU1MTkzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuNTU4NDU0XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS41NjQxODldICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDE5LjU3MDcwNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMTkuNTc2NDM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS41ODI5NTRdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjU4ODY4OF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuNTk1
MjA0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAxOS42MDA5MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDE5LjYwNzQ1NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuNjEzMTg4XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS42MTk3MDRdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjYy
NTQzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMTkuNjMxOTU2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAxOS42Mzc2OTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjY0NDIwN10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuNjQ5OTQyXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAxOS42NTY0NTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDE5LjY2MjE5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuNjY4NzA3XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS42NzQ0NDJdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5
LjY4MDk1N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMTkuNjg2NjkzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAxOS42OTMyMDhdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjY5ODk0M10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuNzA1NDU4
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAx
OS43MTExOTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDE5LjcxNzcxMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuNzIzNDQ1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS43Mjk5NjBdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjczNTY5
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMTkuNzQyMjExXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAxOS43NDc5NDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5Ljc1NDQ2MV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuNzYwMTk2XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAxOS43NjY3MTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDE5Ljc3MjQ0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuNzc4OTYxXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS43ODQ2OTZdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5Ljc5
MTIxMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMTkuNzk2OTQ3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAxOS44MDM0NjJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjgwOTE5OF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuODE1NzEzXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS44
MjE0NDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDE5LjgyNzk2M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMTkuODMzNjk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS44NDAyMTNdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5Ljg0NTk0OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMTkuODUyNDYzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAxOS44NTgxOTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5Ljg2NDcxM10gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuODcwNDQ3XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAx
OS44NzY5NjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDE5Ljg4MjY5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuODg5MjE0XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS44OTQ5NDhdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5LjkwMTQ2
M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MTkuOTA3MTk4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAxOS45MTM3MTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5LjkxOTQ0OV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMTkuOTI1OTY0XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAxOS45MzE2
OTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDE5LjkzODIxNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMTkuOTQzOTUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS45NTA0NjVdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDE5Ljk1NjIwMF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMTkuOTYyNzE1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAxOS45Njg0NTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDE5Ljk3NDk2NV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMTkuOTgwNzAwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAxOS45
ODcyMTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDE5Ljk5Mjk1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMTkuOTk5NDY2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4wMDUyMDNdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjAxMTcxOV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAu
MDE3NDUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyMC4wMjM5NjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjAyOTcwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuMDM2MjE4XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4wNDE5NTNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDIwLjA0ODQ2OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjAuMDU0MjAzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC4wNjA3MThdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjA2NjQ1M10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjAuMDcyOTY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyMC4wNzg3MDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjA4NTIxOV0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuMDkwOTUzXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC4wOTc0
NjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDIwLjEwMzIwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjAuMTA5NzE5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4xMTU0NTRdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjEyMTk2OV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuMTI3
NzA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyMC4xMzQyMTldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDIwLjEzOTk1NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuMTQ2NDcwXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4xNTIyMDddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDIwLjE1ODcyM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjAuMTY0NDU3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC4xNzA5NzNdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjE3NjcwN10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAu
MTgzMjIzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyMC4xODg5NTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjE5NTQ3M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuMjAxMjA3XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC4yMDc3MjNd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIw
LjIxMzQ1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjAuMjE5OTczXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4yMjU3MDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjIzMjIyM10gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuMjM3OTU4
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyMC4yNDQ0NzNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDIwLjI1MDIwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuMjU2NzIzXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4yNjI0NThdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDIwLjI2ODk3M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjAuMjc0NzA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC4yODEyMjRdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjI4Njk1OF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuMjkz
NDczXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyMC4yOTkyMDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDIwLjMwNTcyNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuMzExNDU4XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC4zMTc5NzNdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjMy
MzcwOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjAuMzMwMjI0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyMC4zMzU5NTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjM0MjQ3NF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuMzQ4MjA5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyMC4zNTQ3MjVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDIwLjM2MDQ2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuMzY2OTc1XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC4zNzI3MTBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIw
LjM3OTIyNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjAuMzg0OTYwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyMC4zOTE0NzVdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjM5NzIxMF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuNDAzNzI2
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
MC40MDk0NjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDIwLjQxNTk3Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuNDIxNzExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC40MjgyMjZdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjQzMzk2
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjAuNDQwNDc2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMC40NDYyMTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjQ1MjcyNl0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuNDU4NDYwXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyMC40NjQ5NzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDIwLjQ3MDcxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuNDc3MjMxXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC40ODI5NjZdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjQ4
OTQ4Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjAuNDk1MjE3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyMC41MDE3MzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjUwNzQ2N10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuNTEzOTgyXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC41
MTk3MTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDIwLjUyNjIzMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjAuNTMxOTY3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC41Mzg0ODNdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjU0NDIxN10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjAuNTUwNzMzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMC41NTY0NjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjU2Mjk4Ml0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjAuNTY4NzE4XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
MC41NzUyMzNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDIwLjU4MDk2OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuNTg3NDgzXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC41OTMyMThdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIwLjU5OTcz
M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjAuNjA1NDY4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyMC42MTE5ODRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjYxNzcxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjAuNjI0MjM0XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMC42Mjk5
NjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDIwLjYzNjQ4NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjAuNjQzMTcyXSBpNDBlIDAwMDA6MDE6MDAuMTogZncgNi4wLjQ4
NDQyIGFwaSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5XSBbODA4
NjowMDAwXQpbICAgMjAuOTMxMzIzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC45Mzc4MzhdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjk0NzE0Nl0gaTQwZSAwMDAw
OjAxOjAwLjE6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMQpbICAgMjAuOTUzMDMyXSBp
NDBlIDAwMDA6MDE6MDAuMTogRlcgTExEUCBpcyBlbmFibGVkClsgICAyMC45NjQxMTBdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDIwLjk3MDYyOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjAuOTc2MzY1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMC45ODI4ODFdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIwLjk4ODc4NF0gaTQwZSAwMDAwOjAx
OjAwLjE6IFBDSS1FeHByZXNzOiBTcGVlZCA4LjBHVC9zIFdpZHRoIHg4ClsgICAyMC45OTYwNDNd
IGk0MGUgMDAwMDowMTowMC4xOiBGZWF0dXJlczogUEYtaWRbMV0gVlNJczogMzQgUVA6IDMyIFJT
UyBGRF9BVFIgRkRfU0IgTlRVUExFIFZ4TEFOIEdlbmV2ZSBQVFAgVkVQQQpbICAgMjEuMDA2MjEy
XSBpNDBlIDAwMDA6MDE6MDAuMjogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAy
MS4wMjMyMzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDIxLjAyOTc1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMDM1NDkxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS4wNDIwMDZdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjA0Nzc0
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjEuMDU0MjU4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMS4wNTk5OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjA2NjUwOF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMDcyMjQzXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyMS4wNzg3NThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDIxLjA4NDQ5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuMDkxMDA4XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS4wOTY3NDNdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjEw
MzI1OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjEuMTA4OTk3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyMS4xMTU1MTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjEyMTI0OF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuMTI3NzYzXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS4x
MzM0OThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDIxLjE0MDAxM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjEuMTQ1NzQ5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS4xNTIyNjRdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjE1Nzk5OV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjEuMTY0NTE0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMS4xNzAyNTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjE3Njc2N10gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMTgyNTAzXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
MS4xODkwMThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDIxLjE5NDc1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuMjAxMjY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS4yMDcwMDJdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjIxMzUx
OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjEuMjE5MjUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyMS4yMjU3NjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjIzMTUwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuMjM4MDE4XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS4yNDM3
NTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDIxLjI1MDI2OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjEuMjU2MDAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS4yNjI1MThdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjI2ODI1M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjEuMjc0NzY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyMS4yODA1MDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjI4NzAxOF0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuMjkyNzUzXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS4y
OTkyNjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDIxLjMwNTAwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjEuMzExNTE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS4zMTcyNTNdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjMyMzc2OF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEu
MzI5NTAzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyMS4zMzYwMThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjM0MTc1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuMzQ4MjY5XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS4zNTQwMDRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDIxLjM2MDUxOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjEuMzY2MjU0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS4zNzI3NjldICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjM3ODUwNF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjEuMzg1MDIwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyMS4zOTA3NTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjM5NzI3MF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNDAzMDA0XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS40MDk1
MjBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDIxLjQxNTI1NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjEuNDIxNzcwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS40Mjc1MDRdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjQzNDAyMF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNDM5
NzU0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyMS40NDYyNjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDIxLjQ1MjAwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuNDU4NTIwXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS40NjQyNTRdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDIxLjQ3MDc2OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjEuNDc2NTA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS40ODMwMTldICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjQ4ODc1NF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEu
NDk1MjY5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyMS41MDEwMDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjUwNzUxOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNTEzMjU0XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS41MTk3Njld
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIx
LjUyNTUwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjEuNTMyMDE5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyMS41Mzc3NTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjU0NDI2OV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNTUwMDAz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyMS41NTY1MTldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDIxLjU2MjI1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuNTY4NzY4XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS41NzQ1MDNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDIxLjU4MTAxOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjEuNTg2NzUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS41OTMyNjldICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjU5OTAwNF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuNjA1
NTE5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyMS42MTEyNTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDIxLjYxNzc2OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNjIzNTAzXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS42MzAwMTldICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjYz
NTc1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjEuNjQyMjY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyMS42NDgwMDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjY1NDUxOF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNjYwMjUzXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyMS42NjY3NjldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDIxLjY3MjUwNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuNjc5MDE5XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS42ODQ3NTZdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIx
LjY5MTI3Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjEuNjk3MDA3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyMS43MDM1MjJdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjcwOTI1OF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuNzE1Nzcz
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
MS43MjE1MDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDIxLjcyODAyM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNzMzNzU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS43NDAyNzNdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjc0NjAw
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjEuNzUyNTIzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMS43NTgyNThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjc2NDc3M10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuNzcwNTA4XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyMS43NzcwMjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDIxLjc4Mjc1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuNzg5MjczXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS43OTUwMDddICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjgw
MTUyNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjEuODA3MjU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyMS44MTM3NzNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjgxOTUwOF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuODI2MDIzXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS44
MzE3NThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDIxLjgzODI3M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjEuODQ0MDA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS44NTA1MjNdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjg1NjI1OF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjEuODYyNzczXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMS44Njg1MDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjg3NTAyM10gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuODgwNzYwXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
MS44ODcyNzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDIxLjg5MzAxMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuODk5NTI2XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS45MDUyNjFdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjkxMTc3
Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjEuOTE3NTExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyMS45MjQwMjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjkyOTc2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjEuOTM2Mjc2XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMS45NDIw
MTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDIxLjk0ODUyNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjEuOTU0MjYxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS45NjA3NzZdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIxLjk2NjUxMV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjEuOTczMDI2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyMS45Nzg3NjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIxLjk4NTI3Nl0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjEuOTkxMDEwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMS45
OTc1MjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDIyLjAwMzI2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjIuMDA5Nzc4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi4wMTU1MTNdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjAyMjAyOF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIu
MDI3NzYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyMi4wMzQyNzhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjA0MDAyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuMDQ2NTM1XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi4wNTIyNzBd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDIyLjA1ODc4Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjIuMDY0NTIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi4wNzEwMzVdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjA3Njc3MF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjIuMDgzMjg1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyMi4wODkwMjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjA5NTUzNV0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMTAxMjcwXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi4xMDc3
ODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDIyLjExMzUyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjIuMTIwMDM2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi4xMjU3NzBdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjEzMjI4NV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMTM4
MDIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyMi4xNDQ1MzVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDIyLjE1MDI3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuMTU2Nzg1XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi4xNjI1MjBdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDIyLjE2OTAzNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjIuMTc0NzcwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi4xODEyODVdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjE4NzAyMF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIu
MTkzNTM2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyMi4xOTkyNzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjIwNTc4OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMjExNTIzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi4yMTgwMzld
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIy
LjIyMzc3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjIuMjMwMjg5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyMi4yMzYwMjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjI0MjUzOV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMjQ4Mjc0
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyMi4yNTQ3ODldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDIyLjI2MDUyNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuMjY3MDM5XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi4yNzI3NzNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDIyLjI3OTI4OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjIuMjg1MDIzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi4yOTE1MzldICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjI5NzI3NF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuMzAz
Nzg5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyMi4zMDk1MjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDIyLjMxNjAzOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMzIxNzc0XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi4zMjgyOTBdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjMz
NDAyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjIuMzQwNTQwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyMi4zNDYyNzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjM1Mjc5MV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuMzU4NTI2XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyMi4zNjUwNDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDIyLjM3MDc3NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuMzc3MjkxXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi4zODMwMjVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIy
LjM4OTU0MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjIuMzk1Mjc1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyMi40MDE3OTFdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjQwNzUyNV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuNDE0MDQw
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
Mi40MTk3NzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDIyLjQyNjI5MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNDMyMDI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi40Mzg1NDFdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjQ0NDI3
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjIuNDUwNzkxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMi40NTY1MjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjQ2MzA0MV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNDY4Nzc1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyMi40NzUyOTBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDIyLjQ4MTAyNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuNDg3NTQwXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi40OTMyNzZdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjQ5
OTc5MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjIuNTA1NTI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyMi41MTIwNDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjUxNzc3Nl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuNTI0MjkxXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi41
MzAwMjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDIyLjUzNjU0Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjIuNTQyMjc3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi41NDg3OTJdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjU1NDUyN10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjIuNTYxMDQyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMi41NjY3NzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjU3MzI5Ml0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNTc5MDI3XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
Mi41ODU1NDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDIyLjU5MTI3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuNTk3NzkyXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi42MDM1MjddICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjYxMDA0
Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjIuNjE1Nzc3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyMi42MjIyOTJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjYyODAyN10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuNjM0NTQzXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi42NDAy
NzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDIyLjY0Njc5Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjIuNjUyNTMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi42NTkwNDZdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjY2NDc4MF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjIuNjcxMjk2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyMi42NzcwMzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjY4MzU0NV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNjg5MjgwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi42
OTU3OTVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDIyLjcwMTUzMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjIuNzA4MDQ4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi43MTM3ODNdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjcyMDI5OV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIu
NzI2MDMzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyMi43MzI1NDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjczODI4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuNzQ0Nzk4XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi43NTA1MzNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDIyLjc1NzA0OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjIuNzYyNzgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi43NjkyOThdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjc3NTAzM10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjIuNzgxNTQ4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyMi43ODcyODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjc5Mzc5OF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuNzk5NTMzXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi44MDYw
NDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDIyLjgxMTc4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjIuODE4Mjk4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi44MjQwMzJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjgzMDU0OF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuODM2
MjgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyMi44NDI3OThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDIyLjg0ODUzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuODU1MDQ4XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi44NjA3ODNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDIyLjg2NzI5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjIuODczMDMzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi44Nzk1NDhdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjg4NTI4M10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIu
ODkxNzk4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyMi44OTc1MzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjkwNDA0OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuOTA5NzgzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi45MTYyOThd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIy
LjkyMjAzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjIuOTI4NTQ5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyMi45MzQyODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIyLjk0MDc5OF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjIuOTQ2NTMz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyMi45NTMwNDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDIyLjk1ODc4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjIuOTY1Mjk5XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMi45NzEwMzNdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDIyLjk3NzU0OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjIuOTgzMjg0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMi45ODk3OTldICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIyLjk5NTUzNV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuMDAy
MDUwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyMy4wMDc3ODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDIzLjAxNDMwMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMDIwMDM1XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy4wMjY1NTBdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjAz
MjI4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjMuMDM4ODAwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyMy4wNDQ1MzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjA1MTA1MF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMDU2Nzg1XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyMy4wNjMzMDZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDIzLjA2OTA0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuMDc1NTU3XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy4wODEyOTFdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIz
LjA4NzgwN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjMuMDkzNTQxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyMy4xMDAwNTddICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjEwNTc5MV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuMTEyMzA2
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
My4xMTgwNDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDIzLjEyNDU1Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMTMwMjkxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy4xMzY4MDZdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjE0MjU0
MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjMuMTQ5MDU2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMy4xNTQ3OTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjE2MTMwN10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMTY3MDQyXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyMy4xNzM1NTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDIzLjE3OTI5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuMTg1ODA3XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy4xOTE1NDJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjE5
ODA1OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjMuMjAzNzkzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyMy4yMTAzMDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjIxNjA0NF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuMjIyNTYxXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy4y
MjgyOTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDIzLjIzNDgxMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjMuMjQwNTQ3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy4yNDcwNjJdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjI1Mjc5N10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjMuMjU5MzEyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMy4yNjUwNDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjI3MTU2M10gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMjc3Mjk4XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
My4yODM4MTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDIzLjI4OTU0N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuMjk2MDYzXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy4zMDE3OTddICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjMwODMx
M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjMuMzE0MDQ4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyMy4zMjA1NjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjMyNjI5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuMzMyODE0XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy4zMzg1
NDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDIzLjM0NTA2NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjMuMzUwNzk5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy4zNTczMTRdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjM2MzA0OV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjMuMzY5NTY0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyMy4zNzUzMDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjM4MTgxN10gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuMzg3NTUyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy4z
OTQwNjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDIzLjM5OTgwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjMuNDA2MzE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy40MTIwNTJdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjQxODU2OF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMu
NDI0MzA1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyMy40MzA4MjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjQzNjU1Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuNDQzMDcxXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy40NDg4MDZd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDIzLjQ1NTMyMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjMuNDYxMDU3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy40Njc1NzJdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjQ3MzMwN10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjMuNDc5ODIyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyMy40ODU1NTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjQ5MjA3Ml0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNDk3ODA2XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy41MDQz
MjJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDIzLjUxMDA1Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjMuNTE2NTcxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy41MjIzMDZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjUyODgyMV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNTM0
NTU2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyMy41NDEwNzFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDIzLjU0NjgwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuNTUzMzIxXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy41NTkwNTZdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDIzLjU2NTU3MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjMuNTcxMzA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy41Nzc4MjFdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjU4MzU1Nl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMu
NTkwMDcxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyMy41OTU4MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjYwMjMyMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNjA4MDU1XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy42MTQ1NzFd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIz
LjYyMDMwNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjMuNjI2ODIwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyMy42MzI1NTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjYzOTA3MF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNjQ0ODA1
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyMy42NTEzMjBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDIzLjY1NzA1NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuNjYzNTcxXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy42NjkzMDVdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDIzLjY3NTgyMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjMuNjgxNTU2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy42ODgwNzFdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjY5MzgwNl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuNzAw
MzIxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyMy43MDYwNTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDIzLjcxMjU3MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNzE4MzA3XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy43MjQ4MjJdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjcz
MDU1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjMuNzM3MDc1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyMy43NDI4MTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjc0OTMyNV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuNzU1MDYwXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyMy43NjE1NzVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDIzLjc2NzMxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuNzczODI2XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy43Nzk1NjFdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIz
Ljc4NjA3Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjMuNzkxODExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyMy43OTgzMjZdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjgwNDA2MV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuODEwNTc2
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
My44MTYzMTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDIzLjgyMjgyN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuODI4NTYxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy44MzUwNzddICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjg0MDgx
MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjMuODQ3MzI3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyMy44NTMwNjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjg1OTU3Nl0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuODY1MzExXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyMy44NzE4MjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDIzLjg3NzU2Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuODg0MDc4XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy44ODk4MTNdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjg5
NjMyOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjMuOTAyMDYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyMy45MDg1NzhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjkxNDMxM10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuOTIwODI4XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyMy45
MjY1NjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDIzLjkzMzA3OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjMuOTM4ODEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyMy45NDUzMjhdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDIzLjk1MTA2M10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjMuOTU3NTc4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyMy45NjMzMTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDIzLjk2OTgyOF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjMuOTc1NTYyXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
My45ODIwNzhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDIzLjk4NzgxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjMuOTk0MzI5XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC4wMDAwNjNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjAwNjU3
OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjQuMDEyMzEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyNC4wMTg4MjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjAyNDU2M10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuMDMxMDc5XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC4wMzY4
MTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDI0LjA0MzMyOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjQuMDQ5MDYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC4wNTU1NzhdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjA2MTMxM10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjQuMDY3ODI5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyNC4wNzM1NjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjA4MDA3OV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMDg1ODIwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC4w
OTIzMzVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI0LjA5ODA3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjQuMTA0NTg1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC4xMTAzMjBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjExNjgzNV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQu
MTIyNTcwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyNC4xMjkwODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjEzNDgyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuMTQxMzM1XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC4xNDcwNjld
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI0LjE1MzU4NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjQuMTU5MzE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC4xNjU4MzVdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjE3MTU3MV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjQuMTc4MDg3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyNC4xODM4MjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjE5MDMzOV0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMTk2MDc0XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC4yMDI1
OTBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI0LjIwODMyN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjQuMjE0ODQzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC4yMjA1NzhdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjIyNzA5M10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMjMy
ODI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyNC4yMzkzNDVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI0LjI0NTA4MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuMjUxNTk2XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC4yNTczMzFdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDI0LjI2Mzg0Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjQuMjY5NTgxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC4yNzYwOTddICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjI4MTgzMl0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQu
Mjg4MzQ4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyNC4yOTQwODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjMwMDU5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMzA2MzMzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC4zMTI4NDhd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0
LjMxODU4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjQuMzI1MDk4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyNC4zMzA4MzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjMzNzM0OF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuMzQzMDgz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyNC4zNDk1OThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI0LjM1NTMzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuMzYxODQ4XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC4zNjc1ODJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI0LjM3NDA5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjQuMzc5ODMyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC4zODYzNDhdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjM5MjA4Ml0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuMzk4
NTk3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyNC40MDQzMzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI0LjQxMDg0N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNDE2NTgyXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC40MjMwOTddICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjQy
ODgzMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjQuNDM1MzQ3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyNC40NDEwODJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjQ0NzU5N10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNDUzMzMyXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyNC40NTk4NDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI0LjQ2NTU4Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuNDcyMDk3XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC40Nzc4MzJdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0
LjQ4NDM0N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjQuNDkwMDgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyNC40OTY1OTddICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjUwMjMzMl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuNTA4ODQ4
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
NC41MTQ1ODJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDI0LjUyMTA5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNTI2ODMzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC41MzMzNDhdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjUzOTA4
M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjQuNTQ1NTk5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyNC41NTEzMzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjU1Nzg0OF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNTYzNTgzXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyNC41NzAwOThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI0LjU3NTgzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuNTgyMzQ4XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC41ODgwODNdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjU5
NDU5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjQuNjAwMzMzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyNC42MDY4NDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjYxMjU4M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuNjE5MDk4XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC42
MjQ4MzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDI0LjYzMTM0OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjQuNjM3MDgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC42NDM1OThdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjY0OTMzM10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjQuNjU1ODQ4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyNC42NjE1ODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjY2ODA5OF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNjczODMzXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
NC42ODAzNDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI0LjY4NjA4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuNjkyNTk4XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC42OTgzMzNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjcwNDg0
OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjQuNzEwNTgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyNC43MTcwOThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjcyMjgzM10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuNzI5MzQ4XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC43MzUw
ODNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDI0Ljc0MTU5OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjQuNzQ3MzMzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC43NTM4NDldICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0Ljc1OTU4NV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjQuNzY2MTAxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyNC43NzE4MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0Ljc3ODM1MV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuNzg0MDg2XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC43
OTA2MDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI0Ljc5NjMzNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjQuODAyODUxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC44MDg1ODZdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjgxNTEwMV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQu
ODIwODM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyNC44MjczNTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI0LjgzMzA4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuODM5NjAxXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC44NDUzMzVd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI0Ljg1MTg1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjQuODU3NTg1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC44NjQxMDBdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0Ljg2OTgzNV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjQuODc2MzUxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyNC44ODIwODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0Ljg4ODYwMV0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuODk0MzM1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC45MDA4
NTBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI0LjkwNjU4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjQuOTEzMTAxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC45MTg4MzZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI0LjkyNTM1MV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjQuOTMx
MDg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyNC45Mzc2MDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI0Ljk0MzMzNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQuOTQ5ODUxXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNC45NTU1ODddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDI0Ljk2MjEwMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjQuOTY3ODM3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNC45NzQzNTJdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI0Ljk4MDA5MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjQu
OTg2NjA1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyNC45OTIzNDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI0Ljk5ODg1Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMDA0NTkwXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS4wMTExMDZd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1
LjAxNjg0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjUuMDIzMzU2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyNS4wMjkwOTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjAzNTYwNl0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMDQxMzQx
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyNS4wNDc4NTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI1LjA1MzU5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuMDYwMTA1XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS4wNjU4NDBdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI1LjA3MjM1Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjUuMDc4MDkwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS4wODQ2MDVdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjA5MDM0MF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuMDk2
ODU1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyNS4xMDI1OTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI1LjEwOTExMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMTE0ODQ2XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS4xMjEzNjNdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjEy
NzA5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjUuMTMzNjEzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyNS4xMzkzNDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjE0NTg2M10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMTUxNTk4XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyNS4xNTgxMTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI1LjE2Mzg0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuMTcwMzYzXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS4xNzYwOThdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1
LjE4MjYxM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjUuMTg4MzQ4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyNS4xOTQ4NjNdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjIwMDU5N10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuMjA3MTEz
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
NS4yMTI4NDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDI1LjIxOTM2M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMjI1MDk3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS4yMzE2MTJdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjIzNzM0
N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjUuMjQzODYzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyNS4yNDk1OThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjI1NjExM10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMjYxODQ4XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyNS4yNjgzNjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI1LjI3NDEwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuMjgwNjE2XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS4yODYzNTFdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjI5
Mjg2Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjUuMjk4NjAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyNS4zMDUxMTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjMxMDg1Ml0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuMzE3MzY3XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS4z
MjMxMDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDI1LjMyOTYxOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjUuMzM1MzUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS4zNDE4NjhdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjM0NzYwM10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjUuMzU0MTE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyNS4zNTk4NTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjM2NjM2OF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuMzcyMTAzXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
NS4zNzg2MThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI1LjM4NDM1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuMzkwODY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS4zOTY2MDNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjQwMzEx
OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjUuNDA4ODUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyNS40MTUzNjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjQyMTEwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuNDI3NjE4XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS40MzMz
NTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDI1LjQzOTg2N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjUuNDQ1NjAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS40NTIxMTddICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjQ1Nzg1Ml0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjUuNDY0MzY3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyNS40NzAxMDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjQ3NjYxN10gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNDgyMzUyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS40
ODg4NjddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI1LjQ5NDYwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjUuNTAxMTE3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS41MDY4NTJdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjUxMzM2N10g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUu
NTE5MTAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyNS41MjU2MTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjUzMTM1Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuNTM3ODY3XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS41NDM2MDJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI1LjU1MDExN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjUuNTU1ODUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS41NjIzNjhdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjU2ODEwMl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjUuNTc0NjE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyNS41ODAzNTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjU4Njg2OF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNTkyNjAzXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS41OTkx
MTldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI1LjYwNDg1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjUuNjExMzY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS42MTcxMDNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjYyMzYxOF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNjI5
MzUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyNS42MzU4NjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI1LjY0MTYwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuNjQ4MTE4XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS42NTM4NTNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDI1LjY2MDM2OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjUuNjY2MTAzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS42NzI2MThdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjY3ODM1M10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUu
Njg0ODY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyNS42OTA2MDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjY5NzExOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNzAyODUyXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS43MDkzNjhd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1
LjcxNTEwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjUuNzIxNjE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyNS43MjczNTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1LjczMzg2N10gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuNzM5NjAz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyNS43NDYxMThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI1Ljc1MTg1Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuNzU4MzcyXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS43NjQxMDZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI1Ljc3MDYyMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjUuNzc2MzU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS43ODI4NzVdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1Ljc4ODYxMF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuNzk1
MTI1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyNS44MDA4NjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI1LjgwNzM3NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuODEzMTEwXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS44MTk2MjZdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1Ljgy
NTM2MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjUuODMxODc1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyNS44Mzc2MTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1Ljg0NDEyNV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuODQ5ODYwXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyNS44NTYzNzVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI1Ljg2MjExMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuODY4NjI2XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS44NzQzNjFdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1
Ljg4MDg3Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjUuODg2NjExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyNS44OTMxMjddICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1Ljg5ODg2Ml0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuOTA1Mzc4
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
NS45MTExMTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDI1LjkxNzYyOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuOTIzMzYyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNS45Mjk4NzddICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI1LjkzNTYx
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjUuOTQyMTI3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyNS45NDc4NjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1Ljk1NDM3OF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjUuOTYwMTEzXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyNS45NjY2MjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI1Ljk3MjM2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjUuOTc4ODc5XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNS45ODQ2MTRdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI1Ljk5
MTEyOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjUuOTk2ODY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyNi4wMDMzODBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjAwOTExNV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuMDE1NjMwXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi4w
MjEzNjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDI2LjAyNzg4MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjYuMDMzNjE1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi4wNDAxMzBdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjA0NTg2NV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjYuMDUyMzgwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyNi4wNTgxMTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjA2NDYzMF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMDcwMzY1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
Ni4wNzY4ODBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI2LjA4MjYxNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuMDg5MTMwXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi4wOTQ4NjVdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjEwMTM4
MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjYuMTA3MTE1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyNi4xMTM2MzBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjExOTM2NF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuMTI1ODgwXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi4xMzE2
MjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDI2LjEzODEzNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjYuMTQzODcxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi4xNTAzODZdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjE1NjEyMV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjYuMTYyNjM3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyNi4xNjgzNzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjE3NDg4Nl0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMTgwNjIxXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi4x
ODcxMzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI2LjE5Mjg3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjYuMTk5Mzg3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi4yMDUxMjJdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjIxMTYzN10g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYu
MjE3MzcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyNi4yMjM4ODddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjIyOTYyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuMjM2MTM3XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi4yNDE4NzJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI2LjI0ODM4N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjYuMjU0MTIyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi4yNjA2MzhdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjI2NjM3M10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjYuMjcyODg4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyNi4yNzg2MjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjI4NTEzOF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMjkwODc0XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi4yOTcz
OTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI2LjMwMzEyNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjYuMzA5NjQxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi4zMTUzNzZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjMyMTg5MV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuMzI3
NjI3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyNi4zMzQxNDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI2LjMzOTg3Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuMzQ2MzkyXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi4zNTIxMjZdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDI2LjM1ODY0Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjYuMzY0Mzc3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi4zNzA4OTJdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjM3NjYyN10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYu
MzgzMTQyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyNi4zODg4NzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjM5NTM5Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNDAxMTI3XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi40MDc2NDJd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2
LjQxMzM3N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjYuNDE5ODkyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyNi40MjU2MjZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjQzMjE0Ml0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNDM3ODc2
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyNi40NDQzOTJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI2LjQ1MDEyNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuNDU2NjQxXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi40NjIzNzZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI2LjQ2ODg5MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjYuNDc0NjI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi40ODExNDFdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjQ4Njg3Nl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuNDkz
MzkxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyNi40OTkxMjZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI2LjUwNTY0MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNTExMzc2XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi41MTc4OTFdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjUy
MzYyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjYuNTMwMTQ1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyNi41MzU4NzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjU0MjM5NV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNTQ4MTI5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyNi41NTQ2NDVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI2LjU2MDM3OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuNTY2ODk0XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi41NzI2MzBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2
LjU3OTE0NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjYuNTg0ODgwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyNi41OTEzOTVdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjU5NzEzMF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuNjAzNjQ1
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
Ni42MDkzODBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDI2LjYxNTg5NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNjIxNjMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi42MjgxNDVdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjYzMzg4
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjYuNjQwMzk1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyNi42NDYxMzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjY1MjY0Nl0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNjU4MzgxXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyNi42NjQ4OTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI2LjY3MDYzMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuNjc3MTQ2XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi42ODI4ODFdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjY4
OTM5Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjYuNjk1MTMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyNi43MDE2NDZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjcwNzM4M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuNzEzODk4XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi43
MTk2MzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDI2LjcyNjE0OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjYuNzMxODg0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi43MzgzOTldICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2Ljc0NDEzNF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjYuNzUwNjQ5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyNi43NTYzODRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2Ljc2Mjg5OV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuNzY4NjM0XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
Ni43NzUxNDldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI2Ljc4MDg4NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuNzg3Mzk5XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi43OTMxMzRdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2Ljc5OTY1
MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjYuODA1Mzg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyNi44MTE5MDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjgxNzYzN10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuODI0MTUyXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi44Mjk4
ODddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDI2LjgzNjQwMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjYuODQyMTM3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi44NDg2NTJdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2Ljg1NDM4N10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjYuODYwOTAyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyNi44NjY2MzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2Ljg3MzE1Ml0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuODc4ODg3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi44
ODU0MDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI2Ljg5MTEzNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjYuODk3NjUyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi45MDMzODZdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2LjkwOTkwMl0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYu
OTE1NjM2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyNi45MjIxNTJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI2LjkyNzg4Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjYuOTM0NDAyXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNi45NDAxMzZd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI2Ljk0NjY1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjYuOTUyMzg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi45NTg5MDJdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI2Ljk2NDYzN10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjYuOTcxMTUyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyNi45NzY4ODZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI2Ljk4MzQwMl0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjYuOTg5MTM4XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNi45OTU2
NTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI3LjAwMTM4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjcuMDA3OTAzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNy4wMTM2MzhdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI3LjAyMDE1M10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuMDI1
ODg5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyNy4wMzI0MDRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI3LjAzODEzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuMDQ0NjU0XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNy4wNTAzODldICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDI3LjA1NjkwNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjcuMDYyNjM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy4wNjkxNTRdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjA3NDg4OF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcu
MDgxNDA0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyNy4wODcxMzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI3LjA5MzY1NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuMDk5Mzg5XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy4xMDU5MDRd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3
LjExMTYzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjcuMTE4MTU0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyNy4xMjM4ODldICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI3LjEzMDQwNF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuMTM2MTM5
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyNy4xNDI2NTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI3LjE0ODM4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuMTU0OTEwXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNy4xNjA2NDVdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI3LjE2NzE2MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjcuMTcyODk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy4xNzk0MTBdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjE4NTE0NV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuMTkx
NjYxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyNy4xOTczOTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI3LjIwMzkxMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuMjA5NjQ2XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy4yMTYxNjFdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjIy
MTg5Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjcuMjI4NDExXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyNy4yMzQxNDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI3LjI0MDY2MV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuMjQ2Mzk2XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyNy4yNTI5MTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI3LjI1ODY0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuMjY1MTYxXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNy4yNzA4OTZdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI3
LjI3NzQxMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjcuMjgzMTQ2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyNy4yODk2NjFdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjI5NTM5OV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuMzAxOTE0
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
Ny4zMDc2NDldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDI3LjMxNDE2NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuMzIwODU0XSBpNDBlIDAwMDA6MDE6MDAuMjogZncg
Ni4wLjQ4NDQyIGFwaSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5
XSBbODA4NjowMDAwXQpbICAgMjcuNjA4NzkzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy42MTUzMDldICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjYyMTE1Nl0gaTQw
ZSAwMDAwOjAxOjAwLjI6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMgpbICAgMjcuNjI3
MDQzXSBpNDBlIDAwMDA6MDE6MDAuMjogRlcgTExEUCBpcyBlbmFibGVkClsgICAyNy42MzgxODJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI3LjY0NDcwMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjcuNjUwNDM4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy42NTY5NTRdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjY2Mjg1Nl0gaTQwZSAw
MDAwOjAxOjAwLjI6IFBDSS1FeHByZXNzOiBTcGVlZCA4LjBHVC9zIFdpZHRoIHg4ClsgICAyNy42
NzAxMTVdIGk0MGUgMDAwMDowMTowMC4yOiBGZWF0dXJlczogUEYtaWRbMl0gVlNJczogMzQgUVA6
IDMyIFJTUyBGRF9BVFIgRkRfU0IgTlRVUExFIFZ4TEFOIEdlbmV2ZSBQVFAgVkVQQQpbICAgMjcu
NjgwMjg2XSBpNDBlIDAwMDA6MDE6MDAuMzogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIp
ClsgICAyNy43MDU1MjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI3LjcxMjA0MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuNzE3Nzc5XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy43MjQyOTVd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3
LjczMDAyOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjcuNzM2NTQ1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyNy43NDIyODFdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI3Ljc0ODc5Nl0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuNzU0NTMx
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyNy43NjEwNDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI3Ljc2Njc4Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuNzczMjk4XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNy43NzkwMzJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI3Ljc4NTU0OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjcuNzkxMjgzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy43OTc3OTldICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjgwMzUzNV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuODEw
MDUxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyNy44MTU3ODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI3LjgyMjMwMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuODI4MDM5XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy44MzQ1NTVdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljg0
MDI4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjcuODQ2ODA2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyNy44NTI1NDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI3Ljg1OTA1N10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuODY0NzkyXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyNy44NzEzMDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI3Ljg3NzA0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuODgzNTU4XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNy44ODkyOTNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI3
Ljg5NTgwOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjcuOTAxNTQzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyNy45MDgwNTldICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3LjkxMzc5NF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuOTIwMzEw
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
Ny45MjYwNDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDI3LjkzMjU2MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuOTM4Mjk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyNy45NDQ4MTFdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI3Ljk1MDU0
Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjcuOTU3MDYxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyNy45NjI3OTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI3Ljk2OTMxMV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjcuOTc1MDQ2XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyNy45ODE1NjJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI3Ljk4NzI5OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjcuOTkzODE0XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyNy45OTk1NDhdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjAw
NjA2NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjguMDExNzk5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyOC4wMTgzMTVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjAyNDA1MF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguMDMwNTY1XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC4w
MzYzMDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDI4LjA0MjgxNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjguMDQ4NTUxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC4wNTUwNjZdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjA2MDgwMV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjguMDY3MzE2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyOC4wNzMwNTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjA3OTU2N10gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguMDg1MzAxXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
OC4wOTE4MTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI4LjA5NzU1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguMTA0MDY2XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC4xMDk4MDFdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjExNjMx
Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjguMTIyMDUxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyOC4xMjg1NjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjEzNDMwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguMTQwODE2XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC4xNDY1
NTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDI4LjE1MzA2Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjguMTU4ODAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC4xNjUzMTZdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjE3MTA1MV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjguMTc3NTY3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyOC4xODMzMDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjE4OTgxN10gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguMTk1NTUyXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC4y
MDIwNjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI4LjIwNzgwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjguMjE0MzE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC4yMjAwNTNdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjIyNjU2OV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjgu
MjMyMzA0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyOC4yMzg4MTldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjI0NDU1NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguMjUxMDY5XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC4yNTY4MDRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI4LjI2MzMyMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjguMjY5MDU0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC4yNzU1NzBdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjI4MTMwNV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjguMjg3ODIwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyOC4yOTM1NTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjMwMDA3MF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguMzA1ODA2XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC4zMTIz
MjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI4LjMxODA1Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjguMzI0NTcyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC4zMzAzMDZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjMzNjgyM10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguMzQy
NTU5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyOC4zNDkwNzVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI4LjM1NDgxMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguMzYxMzI1XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC4zNjcwNjBdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDI4LjM3MzU3Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjguMzc5MzExXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC4zODU4MjZdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjM5MTU2MV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjgu
Mzk4MDc2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyOC40MDM4MTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjQxMDMyNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguNDE2MDY1XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC40MjI1ODFd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4
LjQyODMxN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjguNDM0ODMzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyOC40NDA1NjddICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjQ0NzA4Ml0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguNDUyODE3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyOC40NTkzMzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI4LjQ2NTA2N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguNDcxNTgyXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC40NzczMTddICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI4LjQ4MzgzM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjguNDg5NTY4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC40OTYwODNdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjUwMTgxOF0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguNTA4
MzMzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyOC41MTQwNjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI4LjUyMDU4M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguNTI2MzE4XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC41MzI4MzNdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjUz
ODU2OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjguNTQ1MDgzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyOC41NTA4MThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjU1NzMzNF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguNTYzMDY5XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyOC41Njk1ODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI4LjU3NTMxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguNTgxODM1XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC41ODc1NjldICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4
LjU5NDA4NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjguNTk5ODE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyOC42MDYzMzRdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjYxMjA2OV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguNjE4NTg0
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
OC42MjQzMTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDI4LjYzMDgzNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguNjM2NTY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC42NDMwODVdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjY0ODgx
OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjguNjU1MzM1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyOC42NjEwNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjY2NzU4NF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguNjczMzE5XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyOC42Nzk4MzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI4LjY4NTU2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguNjkyMDg0XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC42OTc4MTldICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4Ljcw
NDMzNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjguNzEwMDY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyOC43MTY1OTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjcyMjMyN10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguNzI4ODQyXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC43
MzQ1NzddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDI4Ljc0MTA5Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjguNzQ2ODI3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC43NTMzNDJdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljc1OTA3N10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjguNzY1NTkyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyOC43NzEzMjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4Ljc3Nzg0Ml0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguNzgzNTc2XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
OC43OTAwOTJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI4Ljc5NTgyNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguODAyMzQyXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC44MDgwNzZdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjgxNDU5
Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjguODIwMzI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyOC44MjY4NDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4LjgzMjU3N10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguODM5MDkyXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC44NDQ4
MjddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDI4Ljg1MTM0NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjguODU3MDgwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC44NjM1OTZdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljg2OTMzMV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjguODc1ODQ2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyOC44ODE1ODFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4Ljg4ODA5Nl0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjguODkzODMxXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC45
MDAzNDZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI4LjkwNjA4MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjguOTEyNTk3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC45MTgzMzJdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4LjkyNDg0N10g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjgu
OTMwNTgyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyOC45MzcwOTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljk0MjgzMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjguOTQ5MzQ3XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOC45NTUwODJd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI4Ljk2MTU5N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjguOTY3MzMyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOC45NzM4NDddICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI4Ljk3OTU4Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjguOTg2MDk3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyOC45OTE4MzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI4Ljk5ODM0N10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuMDA0MDgyXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS4wMTA1
OTldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI5LjAxNjMzNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjkuMDIyODUwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS4wMjg1ODRdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjAzNTEwMF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuMDQw
ODM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyOS4wNDczNTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI5LjA1MzA4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuMDU5NjAxXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS4wNjUzMzVdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDI5LjA3MTg1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjkuMDc3NTg1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS4wODQxMDBdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjA4OTgzNV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjku
MDk2MzUwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyOS4xMDIwODVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjEwODYwMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuMTE0MzM1XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS4xMjA4NTFd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5
LjEyNjU4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjkuMTMzMTAxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyOS4xMzg4MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjE0NTM1MV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuMTUxMDg2
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyOS4xNTc2MDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI5LjE2MzMzNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuMTY5ODUxXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS4xNzU1ODZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI5LjE4MjEwMV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjkuMTg3ODM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS4xOTQzNTRdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjIwMDA4OV0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuMjA2
NjA0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyOS4yMTIzMzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI5LjIxODg1NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuMjI0NTg5XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS4yMzExMDVdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjIz
NjgzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjkuMjQzMzU1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyOS4yNDkwODldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjI1NTYwNV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuMjYxMzQwXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyOS4yNjc4NTVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI5LjI3MzU5MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuMjgwMTA1XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS4yODU4NDBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5
LjI5MjM1NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjkuMjk4MDg5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAyOS4zMDQ2MDVdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjMxMDMzOV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuMzE2ODU0
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAy
OS4zMjI1ODldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDI5LjMyOTEwNV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuMzM0ODM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS4zNDEzNTRdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjM0NzA4
OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMjkuMzUzNjA0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAyOS4zNTkzNDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjM2NTg1N10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuMzcxNTkyXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAyOS4zNzgxMDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDI5LjM4Mzg0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuMzkwMzU3XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS4zOTYwOTJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjQw
MjYwN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMjkuNDA4MzQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAyOS40MTQ4NThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjQyMDU5Ml0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuNDI3MTA4XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS40
MzI4NDJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDI5LjQzOTM1OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMjkuNDQ1MDkyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS40NTE2MDddICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjQ1NzM0Ml0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMjkuNDYzODU4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAyOS40Njk1OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjQ3NjEwOF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuNDgxODQyXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAy
OS40ODgzNThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDI5LjQ5NDA5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuNTAwNjA4XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS41MDYzNDJdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjUxMjg1
N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MjkuNTE4NTkzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAyOS41MjUxMDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjUzMDg0M10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuNTM3MzU4XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS41NDMw
OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDI5LjU0OTYwOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMjkuNTU1MzQ0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS41NjE4NTldICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjU2NzU5M10gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMjkuNTc0MTA5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAyOS41Nzk4NDRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjU4NjM1OV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuNTkyMDk0XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS41
OTg2MDldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDI5LjYwNDM0NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMjkuNjEwODU5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS42MTY1OTRdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjYyMzEwOV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjku
NjI4ODQ0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAyOS42MzUzNTldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjY0MTA5NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuNjQ3NjA5XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS42NTMzNDRd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDI5LjY1OTg1OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMjkuNjY1NTk0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS42NzIxMTBdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5LjY3Nzg0NV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MjkuNjg0MzYwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAyOS42OTAwOTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjY5NjYxMF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuNzAyMzQ1XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS43MDg4
NjBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDI5LjcxNDU5Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMjkuNzIxMTExXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS43MjY4NDZdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjczMzM2MV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuNzM5
MTAyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAyOS43NDU2MThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDI5Ljc1MTM1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuNzU3ODY4XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS43NjM2MDNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDI5Ljc3MDExOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMjkuNzc1ODUzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS43ODIzNjhdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljc4ODEwM10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjku
Nzk0NjE5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAyOS44MDAzNTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDI5LjgwNjg2OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuODEyNjAzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS44MTkxMThd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5
LjgyNDg1M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMjkuODMxMzY4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAyOS44MzcxMDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5Ljg0MzYxOF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuODQ5MzUz
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAyOS44NTU4NjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDI5Ljg2MTYwM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuODY4MTE4XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS44NzM4NTRdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDI5Ljg4MDM3Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMjkuODg2MTA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS44OTI2MjJdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljg5ODM1N10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuOTA0
ODcyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAyOS45MTA2MDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDI5LjkxNzEyMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuOTIyODU3XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAyOS45MjkzNzJdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDI5Ljkz
NTEwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMjkuOTQxNjIyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAyOS45NDczNTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5Ljk1Mzg3Ml0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMjkuOTU5NjExXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAyOS45NjYxMjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDI5Ljk3MTg2MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMjkuOTc4Mzc2XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAyOS45ODQxMTBdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDI5
Ljk5MDYyNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMjkuOTk2MzYwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAzMC4wMDI4NzZdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjAwODYxMl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuMDE1MTI3
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
MC4wMjA4NjJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDMwLjAyNzM3OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuMDMzMTEyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC4wMzk2MjddICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjA0NTM2
Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMzAuMDUxODc3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAzMC4wNTc2MTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjA2NDEyN10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuMDY5ODYyXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAzMC4wNzYzNzddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMwLjA4MjExMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuMDg4NjI4XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC4wOTQzNjNdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjEw
MDg3OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMzAuMTA2NjEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAzMC4xMTMxMjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjExODg2M10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuMTI1Mzc4XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC4x
MzExMTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDMwLjEzNzYyOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzAuMTQzMzYzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC4xNDk4NzhdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjE1NTYxMl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMzAuMTYyMTI4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzMC4xNjc4NjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjE3NDM3OF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuMTgwMTEzXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAz
MC4xODY2MjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMwLjE5MjM2M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuMTk4ODc5XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC4yMDQ2MTNdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjIxMTEy
OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzAuMjE2ODY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAzMC4yMjMzNzldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjIyOTExNF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuMjM1NjI5XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC4yNDEz
NjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDMwLjI0Nzg3OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzAuMjUzNjE0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC4yNjAxMjldICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjI2NTg2NF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMzAuMjcyMzc5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzMC4yNzgxMTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjI4NDYyOV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuMjkwMzY0XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC4y
OTY4ODFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMwLjMwMjYxNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMzAuMzA5MTMxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC4zMTQ4NjddICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjMyMTM4Ml0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAu
MzI3MTE3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAzMC4zMzM2MzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjMzOTM2N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuMzQ1ODgyXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC4zNTE2MTdd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDMwLjM1ODEzMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzAuMzYzODY3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC4zNzAzODJdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjM3NjExN10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzAuMzgyNjMyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzMC4zODgzNjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjM5NDg4Nl0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuNDAwNjIwXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC40MDcx
MzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMwLjQxMjg3MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzAuNDE5Mzg2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC40MjUxMjFdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjQzMTYzNl0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuNDM3
MzcxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAzMC40NDM4ODZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMwLjQ0OTYyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuNDU2MTM2XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC40NjE4NzFdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDMwLjQ2ODM4Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMzAuNDc0MTIxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC40ODA2MzZdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjQ4NjM3MF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAu
NDkyODg2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzMC40OTg2MjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjUwNTEzNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuNTEwODcxXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC41MTczODZd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMw
LjUyMzEyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMzAuNTI5NjM2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzMC41MzUzNzFdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjU0MTg4Nl0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuNTQ3NjIx
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzMC41NTQxMzddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMwLjU1OTg3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuNTY2Mzg3XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC41NzIxMjJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDMwLjU3ODYzN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMzAuNTg0MzcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC41OTA4ODddICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjU5NjYyMl0gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuNjAz
MTM3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAzMC42MDg4NzJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDMwLjYxNTM4N10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuNjIxMTIyXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC42Mjc2MzddICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjYz
MzM3Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMzAuNjM5ODg3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAzMC42NDU2MjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjY1MjEzN10gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuNjU3ODcxXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAzMC42NjQzODZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMwLjY3MDEyMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuNjc2NjM2XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC42ODIzNzFdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMw
LjY4ODg4Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMzAuNjk0NjIxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAzMC43MDExMzZdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjcwNjg3MV0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuNzEzMzg3
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
MC43MTkxMjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDMwLjcyNTYzN10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuNzMxMzc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC43Mzc4ODldICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjc0MzYy
NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMzAuNzUwMTM5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAzMC43NTU4ODBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjc2MjM5Nl0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuNzY4MTMwXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAzMC43NzQ2NDVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMwLjc4MDM4MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuNzg2ODk2XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC43OTI2MzFdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjc5
OTE0Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMzAuODA0ODgxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAzMC44MTEzOTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjgxNzEzMV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuODIzNjQ2XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC44
MjkzODFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDMwLjgzNTg5Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzAuODQxNjMxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC44NDgxNDZdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjg1Mzg4M10g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMzAuODYwMzk4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzMC44NjYxMzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjg3MjY1MV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuODc4Mzg1XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAz
MC44ODQ5MDFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMwLjg5MDYzNV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuODk3MTUyXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC45MDI4ODhdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjkwOTQw
M10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzAuOTE1MTM4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAzMC45MjE2NTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjkyNzM4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzAuOTMzOTA0XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMC45Mzk2
MzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDMwLjk0NjE1NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzAuOTUxODg5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC45NTg0MDRdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMwLjk2NDEzOV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMzAuOTcwNjU0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzMC45NzYzODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMwLjk4MjkwNF0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzAuOTg4NjM4XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMC45
OTUxNTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMxLjAwMDg4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMzEuMDA3NDA1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS4wMTMxNDBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjAxOTY1NV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEu
MDI1MzkwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAzMS4wMzE5MDZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjAzNzY0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuMDQ0MTU2XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS4wNDk4OTFd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDMxLjA1NjQwNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzEuMDYyMTQxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS4wNjg2NTZdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjA3NDM5MV0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzEuMDgwOTA2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzMS4wODY2NDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjA5MzE1Nl0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuMDk4ODkxXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS4xMDU0
MDZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMxLjExMTE0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzEuMTE3NjU2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS4xMjMzOTFdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjEyOTkwN10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuMTM1
NjQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAzMS4xNDIxNTddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMxLjE0Nzg5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuMTU0NDA3XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS4xNjAxNDJdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDMxLjE2NjY1OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMzEuMTcyMzkyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS4xNzg5MDhdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjE4NDY0M10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEu
MTkxMTU4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzMS4xOTY4OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjIwMzQwOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuMjA5MTQzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS4yMTU2NThd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMx
LjIyMTM5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMzEuMjI3OTA4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzMS4yMzM2NDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjI0MDE1OF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuMjQ1ODky
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzMS4yNTI0MDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMxLjI1ODE0Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuMjY0NjU4XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS4yNzAzOTJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDMxLjI3NjkwOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMzEuMjgyNjQzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS4yODkxNThdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjI5NDg5M10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuMzAx
NDA4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAzMS4zMDcxNDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDMxLjMxMzY1OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuMzE5MzkyXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS4zMjU5MDhdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjMz
MTY0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMzEuMzM4MTU4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAzMS4zNDM4OTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjM1MDQwOF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuMzU2MTQzXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAzMS4zNjI2NThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMxLjM2ODM5M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuMzc0OTA4XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS4zODA2NDNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMx
LjM4NzE1OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMzEuMzkyODkyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAzMS4zOTk0MDhdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjQwNTE0M10gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuNDExNjYx
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
MS40MTczOTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDMxLjQyMzkxMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuNDI5NjQ4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS40MzYxNjNdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjQ0MTg5
OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMzEuNDQ4NDEzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAzMS40NTQxNDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjQ2MDY2M10gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuNDY2Mzk4XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAzMS40NzI5MTNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMxLjQ3ODY0OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuNDg1MTYzXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS40OTA4OThdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjQ5
NzQxM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMzEuNTAzMTQ4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAzMS41MDk2NjNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjUxNTQwMV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuNTIxOTE2XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS41
Mjc2NTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDMxLjUzNDE2Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzEuNTM5OTAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS41NDY0MTZdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjU1MjE1MV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMzEuNTU4NjY2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzMS41NjQ0MDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjU3MDkxNl0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuNTc2NjUxXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAz
MS41ODMxNjZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMxLjU4ODkwMV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuNTk1NDE2XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS42MDExNTFdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjYwNzY2
Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzEuNjEzNDAxXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAzMS42MTk5MTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjYyNTY1MV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuNjMyMTY2XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS42Mzc5
MDBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDMxLjY0NDQxNl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzEuNjUwMTUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS42NTY2NjZdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjY2MjQwMF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMzEuNjY4OTE1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzMS42NzQ2NTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjY4MTE2NV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuNjg2OTAwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS42
OTM0MTVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMxLjY5OTE1MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMzEuNzA1NjY1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS43MTE0MDBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjcxNzkxNV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEu
NzIzNjUwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAzMS43MzAxNjVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjczNTkwMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuNzQyNDE1XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS43NDgxNTBd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDMxLjc1NDY2NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzEuNzYwNDAwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS43NjY5MTVdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjc3MjY1MF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzEuNzc5MTcxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzMS43ODQ5MDddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjc5MTQyMl0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuNzk3MTU3XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS44MDM2
NzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMxLjgwOTQwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzEuODE1OTIzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS44MjE2NTddICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjgyODE3Ml0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuODMz
OTA3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAzMS44NDA0MjJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMxLjg0NjE1N10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuODUyNjcyXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS44NTg0MDddICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDMxLjg2NDkyM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMzEuODcwNjU3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS44NzcxNzNdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjg4MjkwOF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEu
ODg5NDIzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzMS44OTUxNThdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjkwMTY3NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuOTA3NDA4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS45MTM5MjNd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMx
LjkxOTY1OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMzEuOTI2MTc2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzMS45MzE5MTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMxLjkzODQyNl0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzEuOTQ0MTYx
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzMS45NTA2NzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMxLjk1NjQxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuOTYyOTI3XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMS45Njg2NjJdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDMxLjk3NTE3OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMzEuOTgwOTEzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMS45ODc0MjldICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMxLjk5MzE2M10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzEuOTk5
Njc5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAzMi4wMDU0MTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDMyLjAxMTkyOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuMDE3NjY0XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi4wMjQxNzldICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjAy
OTkxNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMzIuMDM2NDI5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAzMi4wNDIxNjVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjA0ODY4MF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuMDU0NDE1XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAzMi4wNjA5MzBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMyLjA2NjY2NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuMDczMTgwXSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi4wNzg5MTVdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMy
LjA4NTQzMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMzIuMDkxMTY0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAzMi4wOTc2ODBdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjEwMzQxNF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuMTA5OTMw
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
Mi4xMTU2NjRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDMyLjEyMjE3OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuMTI3OTE0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi4xMzQ0MzBdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjE0MDE2
NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMzIuMTQ2NjgwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAzMi4xNTI0MTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjE1ODkzMF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuMTY0NjY1XSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAzMi4xNzExODFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMyLjE3NjkxNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuMTgzNDMxXSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi4xODkxNjZdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjE5
NTY4MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMzIuMjAxNDE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAzMi4yMDc5MzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjIxMzY2Nl0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuMjIwMTgxXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi4y
MjU5MTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDMyLjIzMjQzMl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzIuMjM4MTY3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi4yNDQ2ODJdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjI1MDQxNl0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMzIuMjU2OTMyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzMi4yNjI2NjZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjI2OTE4Ml0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuMjc0OTE2XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAz
Mi4yODE0MzJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMyLjI4NzE2OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuMjkzNjg0XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi4yOTk0MTldICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjMwNTkz
NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzIuMzExNjY5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAzMi4zMTgxODRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjMyMzkxOV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuMzMwNDM0XSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi4zMzYx
NjldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDMyLjM0MjY4NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzIuMzQ4NDE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi4zNTQ5MzVdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjM2MDY2OV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMzIuMzY3MTg1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzMi4zNzI5MjBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjM3OTQzNV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuMzg1MTcwXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi4z
OTE2ODVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMyLjM5NzQyMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMzIuNDAzOTM1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi40MDk2NzBdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjQxNjE4NV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIu
NDIxOTIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAzMi40Mjg0MzVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjQzNDE3MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuNDQwNjg4XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi40NDY0MjNd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDMyLjQ1MjkzOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzIuNDU4NjczXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi40NjUxODhdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjQ3MDkyM10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzIuNDc3NDM4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzMi40ODMxNzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjQ4OTY4OF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuNDk1NDIzXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi41MDE5
MzhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMyLjUwNzY3M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzIuNTE0MTg4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi41MTk5MjNdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjUyNjQzOF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuNTMy
MTcyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAzMi41Mzg2ODhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMyLjU0NDQyMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuNTUwOTM4XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi41NTY2NzJdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDMyLjU2MzE4OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMzIuNTY4OTIyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi41NzU0MzhdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjU4MTE3M10gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIu
NTg3Njg4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzMi41OTM0MjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjU5OTkzOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuNjA1NjczXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi42MTIxODhd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMy
LjYxNzkyM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMzIuNjI0NDM5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzMi42MzAxNzRdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjYzNjY4OV0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuNjQyNDI0
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzMi42NDg5MzldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMyLjY1NDY3NF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuNjYxMTg5XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi42NjY5MjRdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDMyLjY3MzQzOV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMzIuNjc5MTc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi42ODU2ODldICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjY5MTQyM10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuNjk3
OTM5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAzMi43MDM2NzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDMyLjcxMDE4OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuNzE1OTIzXSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi43MjI0MzldICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjcy
ODE3M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMzIuNzM0Njg4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAzMi43NDA0MjNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjc0NjkzOF0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuNzUyNjczXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAzMi43NTkxODhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMyLjc2NDkyNF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuNzcxNDM5XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi43NzcxNzRdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMy
Ljc4MzY4OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMzIuNzg5NDI0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAzMi43OTU5NDVdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjgwMTY4MF0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuODA4MTk2
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
Mi44MTM5MzBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDMyLjgyMDQ0NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuODI2MTgwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi44MzI2OTVdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjgzODQz
MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMzIuODQ0OTQ1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAzMi44NTA2ODBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjg1NzE5NV0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuODYyOTMwXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAzMi44Njk0NDVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMyLjg3NTE4MF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuODgxNjk2XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi44ODc0MzBdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjg5
Mzk0NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMzIuODk5NjgwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAzMi45MDYxOTVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjkxMTkzMF0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuOTE4NDQ1XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi45
MjQxODBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDMyLjkzMDY5NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzIuOTM2NDMwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMi45NDI5NDVdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMyLjk0ODY4Ml0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMzIuOTU1MTk4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzMi45NjA5MzNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMyLjk2NzQ0OV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzIuOTczMTgzXSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAz
Mi45Nzk2OTldICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMyLjk4NTQzM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMzIuOTkxOTQ5XSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMi45OTc2ODRdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjAwNDE5
OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzMuMDA5OTM1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAzMy4wMTY0NTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjAyMjE4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuMDI4NzAxXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy4wMzQ0
MzZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDMzLjA0MDk1MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzMuMDQ2Njg2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy4wNTMyMDFdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjA1ODkzOF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMzMuMDY1NDU0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzMy4wNzExODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjA3NzcwM10gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuMDgzNDM5XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy4w
ODk5NTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMzLjA5NTY4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMzMuMTAyMjA0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy4xMDc5MzhdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjExNDQ1NF0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMu
MTIwMTg4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAzMy4xMjY3MDRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjEzMjQzOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuMTM4OTUzXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy4xNDQ2ODhd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDMzLjE1MTIwM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzMuMTU2OTM4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy4xNjM0NTNdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjE2OTE4OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzMuMTc1NzAzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzMy4xODE0MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjE4Nzk1M10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuMTkzNjg4XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy4yMDAy
MDRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMzLjIwNTkzOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzMuMjEyNDU0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy4yMTgxODhdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjIyNDcwNF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuMjMw
NDM5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAzMy4yMzY5NTRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMzLjI0MjY4OV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuMjQ5MjA0XSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy4yNTQ5MzhdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDMzLjI2MTQ1NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMzMuMjY3MTg4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy4yNzM3MDRdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjI3OTQzOF0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMu
Mjg1OTUzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzMy4yOTE2ODhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjI5ODIwM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuMzAzOTM4XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy4zMTA0NTNd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMz
LjMxNjE4OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMzMuMzIyNzAzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzMy4zMjg0MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjMzNDk1M10gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuMzQwNjg4
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzMy4zNDcyMDNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDMzLjM1MjkzOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuMzU5NDUzXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy4zNjUxODhdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDMzLjM3MTcwM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMzMuMzc3NDM3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy4zODM5NTNdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjM4OTY4N10gICoqKioqKiogZG1h
X2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuMzk2
MjAzXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsg
ICAzMy40MDE5MzhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJl
Y3QoKSAqKioqKioqKioKWyAgIDMzLjQwODQ1NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuNDE0MTg5XSAgKioqKioqKiBkbWFfYWxsb2Nf
YXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy40MjA3MDRdICAq
KioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjQy
NjQzOV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoq
KioqKioqKgpbICAgMzMuNDMyOTU1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqClsgICAzMy40Mzg2OTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygp
IC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjQ0NTIwNV0gICoqKioqKiog
SW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuNDUwOTQwXSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAzMy40NTc0NTZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDMzLjQ2MzE5Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuNDY5NzA4XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy40NzU0NDJdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMz
LjQ4MTk1OF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMzMuNDg3NjkyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAzMy40OTQyMDddICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjQ5OTk0Ml0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuNTA2NDU3
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
My41MTIxOTJdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDMzLjUxODcwOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgp
IGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuNTI0NDQzXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy41MzA5NThdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjUzNjY5
M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioq
KioqKgpbICAgMzMuNTQzMjA4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rp
b24gKioqKioqKioqClsgICAzMy41NDg5NDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+
IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjU1NTQ1OF0gICoqKioqKiogSW4g
ZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuNTYxMTkzXSAgKioq
KioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsg
ICAzMy41Njc3MDhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioq
KioqKioKWyAgIDMzLjU3MzQ0M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuNTc5OTU4XSAgKioqKioqKiBJbiBkbWFfYWxs
b2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy41ODU2OTJdICAqKioqKioqIGRt
YV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjU5
MjIwOF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMzMuNTk3OTQyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAzMy42MDQ0NThdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJl
Y3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjYxMDE5Ml0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuNjE2NzA4XSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy42
MjI0NDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDMzLjYyODk1OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzMuNjM0Njk0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy42NDEyMDldICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjY0Njk0NF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMzMuNjUzNDU5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzMy42NTkxOTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjY2NTcxMV0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuNjcxNDQ2XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAz
My42Nzc5NjFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDMzLjY4MzY5Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuNjkwMjExXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy42OTU5NDZdICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjcwMjQ2
MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzMuNzA4MTk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAzMy43MTQ3MTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjcyMDQ0NV0gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuNzI2OTYwXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy43MzI2
OTVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDMzLjczOTIxMF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzMuNzQ0OTQ1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy43NTE0NjBdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjc1NzE5Nl0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMzMuNzYzNzExXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzMy43Njk0NDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjc3NTk2MV0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuNzgxNjk2XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy43
ODgyMTFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDMzLjc5Mzk0Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Rp
cmVjdCgpICoqKioqKioqKgpbICAgMzMuODAwNDYyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGly
ZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy44MDYxOTZdICAqKioqKioqIGRtYV9hbGxv
Y19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjgxMjcxMV0g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMu
ODE4NDUyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAzMy44MjQ5NjhdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjgzMDcwNl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuODM3MjIxXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy44NDI5NTZd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDMzLjg0OTQ3Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzMuODU1MjA2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy44NjE3MjFdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjg2NzQ1N10gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzMuODczOTcyXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzMy44Nzk3MDhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjg4NjIyNF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuODkxOTU5XSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy44OTg0
NzRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDMzLjkwNDIwOF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzMuOTEwNzI0XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy45MTY0NThdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjkyMjk3NF0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzMuOTI4
NzA4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAzMy45MzUyMjRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDMzLjk0MDk1OF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkg
LT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMuOTQ3NDczXSAgKioqKioqKiBJ
biBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzMy45NTMyMDhdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDMzLjk1OTcyM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoq
KioqKioqKgpbICAgMzMuOTY1NDU4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFf
YWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzMy45NzE5NzZdICAqKioqKioqIEluIGRtYV9h
bGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDMzLjk3NzcxMV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzMu
OTg0MjI3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzMy45ODk5NjFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDMzLjk5NjQ3Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuMDAzMTY1XSBpNDBlIDAwMDA6MDE6MDAu
MzogZncgNi4wLjQ4NDQyIGFwaSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4
NjoxNTg5XSBbODA4NjowMDAwXQpbICAgMzQuMjkwOTI4XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0
cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNC4yOTc0NDNdICAqKioq
KioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjMwMzI5
Ml0gaTQwZSAwMDAwOjAxOjAwLjM6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMwpbICAg
MzQuMzA5MTc4XSBpNDBlIDAwMDA6MDE6MDAuMzogRlcgTExEUCBpcyBlbmFibGVkClsgICAzNC4z
MjA0MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAq
KioqKioqKioKWyAgIDM0LjMyNjkyNF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1
bmN0aW9uICoqKioqKioqKgpbICAgMzQuMzMyNjYwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNC4zMzkxNzZdICAqKioqKioq
IEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjM0NTA3N10g
aTQwZSAwMDAwOjAxOjAwLjM6IFBDSS1FeHByZXNzOiBTcGVlZCA4LjBHVC9zIFdpZHRoIHg4Clsg
ICAzNC4zNTIzODZdIGk0MGUgMDAwMDowMTowMC4zOiBGZWF0dXJlczogUEYtaWRbM10gVlNJczog
MzQgUVA6IDMyIFJTUyBGRF9BVFIgRkRfU0IgTlRVUExFIFZ4TEFOIEdlbmV2ZSBQVFAgVkVQQQpb
ICAgMzQuMzYyNTA1XSBlaGNpX2hjZDogVVNCIDIuMCAnRW5oYW5jZWQnIEhvc3QgQ29udHJvbGxl
ciAoRUhDSSkgRHJpdmVyClsgICAzNC4zNjkwMjZdIGVoY2ktcGNpOiBFSENJIFBDSSBwbGF0Zm9y
bSBkcml2ZXIKWyAgIDM0LjM3MzU5NF0geGhjaV9oY2QgMDAwZDowMTowMC4yOiBlbmFibGluZyBk
ZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAgIDM0LjM3OTcxNF0geGhjaV9oY2QgMDAwZDowMTowMC4y
OiB4SENJIEhvc3QgQ29udHJvbGxlcgpbICAgMzQuMzg0OTM0XSB4aGNpX2hjZCAwMDBkOjAxOjAw
LjI6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIgMQpbICAgMzQu
MzkyODU3XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAzNC4zOTkzNzNdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjQwNTExMF0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzQuNDExNjI3XSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNC40MTczNjVd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDM0LjQyMzg4MV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzQuNDI5NjE5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNC40MzYxMzZdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjQ0MTg3Ml0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzQuNDQ4Mzg5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzNC40NTQxNDFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM0LjQ2MDY1Nl0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuNDY2MzkxXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNC40NzI5
MDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDM0LjQ3ODY0MV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzQuNDg1MTU5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNC40OTA4OTRdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM0LjQ5NzQwOV0gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuNTAz
MTY3XSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IGhjYyBwYXJhbXMgMHgwMTgwZmYwNSBoY2kgdmVy
c2lvbiAweDExMCBxdWlya3MgMHgwMDAwMDAwMDAwMDAwMDEwClsgICAzNC41MTI2MjNdIGh1YiAx
LTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC41MTYzNzRdIGh1YiAxLTA6MS4wOiAyIHBvcnRz
IGRldGVjdGVkClsgICAzNC41MjA0OThdIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogeEhDSSBIb3N0
IENvbnRyb2xsZXIKWyAgIDM0LjUyNTcxNl0geGhjaV9oY2QgMDAwZDowMTowMC4yOiBuZXcgVVNC
IGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDIKWyAgIDM0LjUzMzEwNF0geGhj
aV9oY2QgMDAwZDowMTowMC4yOiBIb3N0IHN1cHBvcnRzIFVTQiAzLjEgRW5oYW5jZWQgU3VwZXJT
cGVlZApbICAgMzQuNTQwMTYzXSB1c2IgdXNiMjogV2UgZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGht
cyBmb3IgTFBNIGZvciB0aGlzIGhvc3QsIGRpc2FibGluZyBMUE0uClsgICAzNC41NDgzNjFdIGh1
YiAyLTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC41NTIxMTJdIGh1YiAyLTA6MS4wOiA0IHBv
cnRzIGRldGVjdGVkClsgICAzNC41NTYzMzBdIHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogeEhDSSBI
b3N0IENvbnRyb2xsZXIKWyAgIDM0LjU2MTU1MF0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBuZXcg
VVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDMKWyAgIDM0LjU3NDI0NF0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioq
KgpbICAgMzQuNTgwNzYwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzNC41ODY0OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRt
YV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM0LjU5MzAxNF0gICoqKioqKiogSW4gZG1h
X2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuNTk4NzU0XSAgKioqKioq
KiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAz
NC42MDUyNzBdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioq
KioKWyAgIDM0LjYxMTAwN10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9j
X2RpcmVjdCgpICoqKioqKioqKgpbICAgMzQuNjE3NTIyXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNC42MjMyNTldICAqKioqKioqIGRtYV9h
bGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM0LjYyOTc3
NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAg
MzQuNjM1NTI2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0
KCkgKioqKioqKioqClsgICAzNC42NDIwNDJdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3Qo
KSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjY0Nzc3N10gICoqKioqKiogZG1hX2FsbG9jX2F0
dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzQuNjU0MjkzXSAgKioq
KioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNC42NjAw
MjhdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioq
KioqKioKWyAgIDM0LjY2NjU0NF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0
aW9uICoqKioqKioqKgpbICAgMzQuNjcyMjc5XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAt
PiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNC42Nzg3OTVdICAqKioqKioqIElu
IGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjY4NDUyOV0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMzQuNjkxMDQ1XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzNC42OTY4MTVdIHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogaGNjIHBhcmFtcyAw
eDAxNDA1MWNmIGhjaSB2ZXJzaW9uIDB4MTAwIHF1aXJrcyAweDAwMDAwMDExMDAwMDA0MTAKWyAg
IDM0LjcwNzg1MF0gaHViIDMtMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDM0LjcxMTYwNF0gaHVi
IDMtMDoxLjA6IDQgcG9ydHMgZGV0ZWN0ZWQKWyAgIDM0LjcxNTc4Nl0geGhjaV9oY2QgMDAwNDow
MzowMC4wOiB4SENJIEhvc3QgQ29udHJvbGxlcgpbICAgMzQuNzIxMDA0XSB4aGNpX2hjZCAwMDA0
OjAzOjAwLjA6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIgNApb
ICAgMzQuNzI4Mzk4XSB4aGNpX2hjZCAwMDA0OjAzOjAwLjA6IEhvc3Qgc3VwcG9ydHMgVVNCIDMu
MCBTdXBlclNwZWVkClsgICAzNC43MzQ2ODVdIHVzYiB1c2I0OiBXZSBkb24ndCBrbm93IHRoZSBh
bGdvcml0aG1zIGZvciBMUE0gZm9yIHRoaXMgaG9zdCwgZGlzYWJsaW5nIExQTS4KWyAgIDM0Ljc0
Mjg5NF0gaHViIDQtMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDM0Ljc0NjY0NV0gaHViIDQtMDox
LjA6IDQgcG9ydHMgZGV0ZWN0ZWQKWyAgIDM0Ljc1MDkxN10geGhjaV9oY2QgMDAwNTowMjowMC4w
OiB4SENJIEhvc3QgQ29udHJvbGxlcgpbICAgMzQuNzU2MTM3XSB4aGNpX2hjZCAwMDA1OjAyOjAw
LjA6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIgNQpbICAgMzQu
ODc0NDMyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkg
KioqKioqKioqClsgICAzNC44ODA5NDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBm
dW5jdGlvbiAqKioqKioqKioKWyAgIDM0Ljg4NjY4NV0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJz
KCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzQuODkzMjAxXSAgKioqKioq
KiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNC44OTg5NDFd
ICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioq
KioKWyAgIDM0LjkwNTQ1Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9u
ICoqKioqKioqKgpbICAgMzQuOTExMTk1XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBk
bWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNC45MTc3MTFdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM0LjkyMzQ0Nl0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzQuOTI5OTYxXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzNC45MzU3MTFdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM0Ljk0MjIyN10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuOTQ3OTYyXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNC45NTQ0
NzddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDM0Ljk2MDIxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzQuOTY2NzI4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNC45NzI0NjJdICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM0Ljk3ODk3N10gICoq
KioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzQuOTg0
NzEyXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioq
KioqKioqClsgICAzNC45OTEyMzFdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5j
dGlvbiAqKioqKioqKioKWyAgIDM0Ljk5NzAwMF0geGhjaV9oY2QgMDAwNTowMjowMC4wOiBoY2Mg
cGFyYW1zIDB4MDE0MDUxY2YgaGNpIHZlcnNpb24gMHgxMDAgcXVpcmtzIDB4MDAwMDAwMTEwMDAw
MDQxMApbICAgMzUuMDA2OTM1XSBodWIgNS0wOjEuMDogVVNCIGh1YiBmb3VuZApbICAgMzUuMDEw
Njg5XSBodWIgNS0wOjEuMDogNCBwb3J0cyBkZXRlY3RlZApbICAgMzUuMDE0ODY4XSB4aGNpX2hj
ZCAwMDA1OjAyOjAwLjA6IHhIQ0kgSG9zdCBDb250cm9sbGVyClsgICAzNS4wMjAwODddIHhoY2lf
aGNkIDAwMDU6MDI6MDAuMDogbmV3IFVTQiBidXMgcmVnaXN0ZXJlZCwgYXNzaWduZWQgYnVzIG51
bWJlciA2ClsgICAzNS4wMjc0NzRdIHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogSG9zdCBzdXBwb3J0
cyBVU0IgMy4wIFN1cGVyU3BlZWQKWyAgIDM1LjAzMzc2OF0gdXNiIHVzYjY6IFdlIGRvbid0IGtu
b3cgdGhlIGFsZ29yaXRobXMgZm9yIExQTSBmb3IgdGhpcyBob3N0LCBkaXNhYmxpbmcgTFBNLgpb
ICAgMzUuMDQxOTY1XSBodWIgNi0wOjEuMDogVVNCIGh1YiBmb3VuZApbICAgMzUuMDQ1NzE3XSBo
dWIgNi0wOjEuMDogNCBwb3J0cyBkZXRlY3RlZApbICAgMzUuMDUwMDgzXSB1c2Jjb3JlOiByZWdp
c3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYi1zdG9yYWdlClsgICAzNS4wNTY5MzJdIHJ0
Yy1lZmkgcnRjLWVmaS4wOiByZWdpc3RlcmVkIGFzIHJ0YzAKWyAgIDM1LjA2MjA2OV0gcnRjLWVm
aSBydGMtZWZpLjA6IHNldHRpbmcgc3lzdGVtIGNsb2NrIHRvIDIwMjItMDQtMTRUMTA6MDM6NTgg
VVRDICgxNjQ5OTMwNjM4KQpbICAgMzUuMDcwNTI0XSBzYnNhLWd3ZHQgc2JzYS1nd2R0LjA6IElu
aXRpYWxpemVkIHdpdGggMTBzIHRpbWVvdXQgQCAyNTAwMDAwMCBIeiwgYWN0aW9uPTAuClsgICAz
NS4wNzg3NThdIGRldmljZS1tYXBwZXI6IGlvY3RsOiA0LjQzLjAtaW9jdGwgKDIwMjAtMTAtMDEp
IGluaXRpYWxpc2VkOiBkbS1kZXZlbEByZWRoYXQuY29tClsgICAzNS4wODg0MzVdIHBzdG9yZTog
UmVnaXN0ZXJlZCBlZmkgYXMgcGVyc2lzdGVudCBzdG9yZSBiYWNrZW5kClsgICAzNS4wOTQyODNd
IFNNQ0NDOiBTT0NfSUQ6IElEID0gamVwMTA2OjBhMTY6MDAwMSBSZXZpc2lvbiA9IDB4MDAwMDAw
YTEKWyAgIDM1LjEwMDkwN10gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZl
ciB1c2JoaWQKWyAgIDM1LjEwNjQ3MF0gdXNiaGlkOiBVU0IgSElEIGNvcmUgZHJpdmVyClsgICAz
NS4xMDc3OTddICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3Qo
KSAqKioqKioqKioKWyAgIDM1LjExMDMyMl0gdTMyIGNsYXNzaWZpZXIKWyAgIDM1LjExNjgxN10g
ICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUu
MTE5NTA4XSAgICAgaW5wdXQgZGV2aWNlIGNoZWNrIG9uClsgICAzNS4xMjUyNDNdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM1
LjEyNTI0NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMzUuMTI4ODk2XSAgICAgQWN0aW9ucyBjb25maWd1cmVkClsgICAzNS4xMzU0MTNdICAq
KioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioK
WyAgIDM1LjE0MTUzMF0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZhbWlseSAxMApbICAgMzUu
MTQ0NTM3XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzNS4xNDQ1MzldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDM1LjE1MTQ4M10gU2VnbWVudCBSb3V0aW5nIHdpdGggSVB2
NgpbICAgMzUuMTU1NDg4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24g
KioqKioqKioqClsgICAzNS4xNzcxNThdIHNpdDogSVB2NiwgSVB2NCBhbmQgTVBMUyBvdmVyIElQ
djQgdHVubmVsaW5nIGRyaXZlcgpbICAgMzUuMTgzMjA4XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9j
b2wgZmFtaWx5IDE3ClsgICAzNS4xODc2NTddIEJyaWRnZSBmaXJld2FsbGluZyByZWdpc3RlcmVk
ClsgICAzNS4xOTE2NzddIEtleSB0eXBlIGRuc19yZXNvbHZlciByZWdpc3RlcmVkClsgICAzNS4x
OTU5NzJdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgNDAKWyAgIDM1LjIwMDQ5OV0g
S2V5IHR5cGUgLl9mc2NyeXB0IHJlZ2lzdGVyZWQKWyAgIDM1LjIwNDUwNV0gS2V5IHR5cGUgLmZz
Y3J5cHQgcmVnaXN0ZXJlZApbICAgMzUuMjA4NDE4XSBLZXkgdHlwZSBmc2NyeXB0LXByb3Zpc2lv
bmluZyByZWdpc3RlcmVkClsgICAzNS4yMTM1ODZdIEJ0cmZzIGxvYWRlZCwgY3JjMzJjPWNyYzMy
Yy1nZW5lcmljClsgICAzNS4yMTgxOTJdIHBzdG9yZTogVXNpbmcgY3Jhc2ggZHVtcCBjb21wcmVz
c2lvbjogZGVmbGF0ZQpbICAgMzUuMjI0MTA3XSBLZXkgdHlwZSBlbmNyeXB0ZWQgcmVnaXN0ZXJl
ZApbICAgMzUuMjI4MzY0XSBCRVJUOiBFcnJvciByZWNvcmRzIGZyb20gcHJldmlvdXMgYm9vdDoK
WyAgIDM1LjIzMzIzNV0gW0hhcmR3YXJlIEVycm9yXTogZXZlbnQgc2V2ZXJpdHk6IHJlY292ZXJh
YmxlClsgICAzNS4yMzg2MjNdIFtIYXJkd2FyZSBFcnJvcl06ICBFcnJvciAwLCB0eXBlOiBmYXRh
bApbICAgMzUuMjQzNDkyXSBbSGFyZHdhcmUgRXJyb3JdOiAgIHNlY3Rpb24gdHlwZTogdW5rbm93
biwgZThlZDg5OGQtZGYxNi00M2NjLThlY2MtNTRmMDYwZWYxNTdmClsgICAzNS4yNTE4MzJdIFtI
YXJkd2FyZSBFcnJvcl06ICAgc2VjdGlvbiBsZW5ndGg6IDB4MzEKWyAgIDM1LjI1Njc4OV0gW0hh
cmR3YXJlIEVycm9yXTogICAwMDAwMDAwMDogMDAwMDAwN2YgNmU2YjZlNTUgMjA2ZTc3NmYgNmY2
MjY1NzIgIC4uLi5Vbmtub3duIHJlYm8KWyAgIDM1LjI1OTYwNV0gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzUuMjY1NDgwXSBb
SGFyZHdhcmUgRXJyb3JdOiAgIDAwMDAwMDEwOiA3MjIwNzQ2ZiA2ZjczNjE2NSAwMDAwMDA2ZSAw
MDAwMDAwMCAgb3QgcmVhc29uLi4uLi4uLgpbICAgMzUuMjY1NDgyXSBbSGFyZHdhcmUgRXJyb3Jd
OiAgIDAwMDAwMDIwOiAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAgLi4uLi4u
Li4uLi4uLi4uLgpbICAgMzUuMjY1NDg0XSBbSGFyZHdhcmUgRXJyb3JdOiAgIDAwMDAwMDMwOiAx
MSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLgpbICAgMzUu
MjcyMDAwXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioq
ClsgICAzNS4yNzIwMDNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDM1LjMxMDA1N10gdXNiIDMtNDogbmV3IGhpZ2gtc3BlZWQg
VVNCIGRldmljZSBudW1iZXIgMiB1c2luZyB4aGNpX2hjZApbICAgMzUuMzE2NTk3XSBwcmludGs6
IGNvbnNvbGUgW25ldGNvbjBdIGVuYWJsZWQKWyAgIDM1LjMyMDk1N10gbmV0Y29uc29sZTogbmV0
d29yayBsb2dnaW5nIHN0YXJ0ZWQKWyAgIDM1LjMyNTU0OF0gbWQ6IFdhaXRpbmcgZm9yIGFsbCBk
ZXZpY2VzIHRvIGJlIGF2YWlsYWJsZSBiZWZvcmUgYXV0b2RldGVjdApbICAgMzUuMzMyMzI3XSBt
ZDogSWYgeW91IGRvbid0IHVzZSByYWlkLCB1c2UgcmFpZD1ub2F1dG9kZXRlY3QKWyAgIDM1LjMz
Nzk3Nl0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpb
ICAgMzUuMzQzNzE0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGly
ZWN0KCkgKioqKioqKioqClsgICAzNS4zNTAyMzJdIG1kOiBBdXRvZGV0ZWN0aW5nIFJBSUQgYXJy
YXlzLgpbICAgMzUuMzU0MzIwXSBtZDogYXV0b3J1biAuLi4KWyAgIDM1LjM1NzEwNV0gbWQ6IC4u
LiBhdXRvcnVuIERPTkUuClsgICAzNS4zNjA0NDldIFdhaXRpbmcgZm9yIHJvb3QgZGV2aWNlIC9k
ZXYvc2RhMi4uLgpbICAgMzUuMzY1MDU4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzNS4zNzA4MDZdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM1LjM3NzMzMl0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuNDgyMzQ3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzNS40ODg4NjVdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDM1LjQ5NDYwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzUuNTAxMTE5XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNS41MDg2MTZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDM1LjUxNTE0M10gdXNiIDYtMTogbmV3IFN1cGVyU3BlZWQgR2VuIDEgVVNCIGRldmljZSBudW1i
ZXIgMiB1c2luZyB4aGNpX2hjZApbICAgMzUuNTIyMTgzXSAgKioqKioqKiBJbiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNS41Mzk2ODFdIGh1YiAzLTQ6MS4wOiBV
U0IgaHViIGZvdW5kClsgICAzNS41NDUwMDRdIGh1YiAzLTQ6MS4wOiA1IHBvcnRzIGRldGVjdGVk
ClsgICAzNS41NzA0MTldICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDM1LjU3Njk0MF0gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuNTgyNzAzXSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNS41ODkyMTld
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM1
LjU5NDk1Nl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMzUuNjAxNDczXSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzNS42MDcyMTBdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM1LjYxMzcyN10gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuNjIxMTI3
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzNS42Mjc2NDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDM1LjY0MjM2OF0gdXNiLXN0b3JhZ2UgNi0xOjEuMDogVVNCIE1hc3Mg
U3RvcmFnZSBkZXZpY2UgZGV0ZWN0ZWQKWyAgIDM1LjY0ODYwM10gICoqKioqKiogZG1hX2FsbG9j
X2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzUuNjU1MTIxXSAg
KioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNS42
NjA5MjFdIHNjc2kgaG9zdDA6IHVzYi1zdG9yYWdlIDYtMToxLjAKWyAgIDM1Ljc5MjI0MF0gICoq
KioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpb
ICAgMzUuNzk4NzU5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioq
KioqKioqClsgICAzNS44MDQ0OTZdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9h
bGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM1LjgxMTAxMl0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzUuODE2NzQ3XSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNS44
MjMyNjRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioK
WyAgIDM1LjkxNTI3OV0gdXNiIDMtNC4xOiBuZXcgaGlnaC1zcGVlZCBVU0IgZGV2aWNlIG51bWJl
ciAzIHVzaW5nIHhoY2lfaGNkClsgICAzNi4wMzg3MDVdICAqKioqKioqIGRtYV9hbGxvY19hdHRy
cygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM2LjA0NTIyNF0gICoqKioq
KiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzYuMDUwOTYw
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzNi4wNTc0NzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDM2LjA2MzIxM10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4g
ZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzYuMDY5NzI5XSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNi4wNzU0NjZdICAqKioq
KioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAg
IDM2LjA4MTk4Ml0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioq
KioqKgpbICAgMzYuMDg5Njc0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxs
b2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNi4wOTYxOTZdICAqKioqKioqIEluIGRtYV9hbGxv
Y19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM2LjExNTE4N10gdXNiLXN0b3JhZ2Ug
My00LjE6MS4wOiBVU0IgTWFzcyBTdG9yYWdlIGRldmljZSBkZXRlY3RlZApbICAgMzYuMTIxNTg1
XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioq
KioqClsgICAzNi4xMjgxMDRdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlv
biAqKioqKioqKioKWyAgIDM2LjEzMzkwMF0gc2NzaSBob3N0MTogdXNiLXN0b3JhZ2UgMy00LjE6
MS4wClsgICAzNi4xNDE0NzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM2LjE0Nzk5M10gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzYuMTUzNzMwXSAgKioqKioqKiBkbWFf
YWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNi4xNjAy
NDddICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAg
IDM2LjE2NTk4M10gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVj
dCgpICoqKioqKioqKgpbICAgMzYuMTcyNDk5XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0
KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNi4yNjcyNzVdIHVzYiAzLTQuMjogbmV3IGhpZ2gt
c3BlZWQgVVNCIGRldmljZSBudW1iZXIgNCB1c2luZyB4aGNpX2hjZApbICAgMzYuMzkwOTU3XSAg
KioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioq
ClsgICAzNi4zOTc0NzZdICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAq
KioqKioqKioKWyAgIDM2LjQwMzIxMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1h
X2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzYuNDA5NzI3XSAgKioqKioqKiBJbiBkbWFf
YWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAzNi40MTU0NjRdICAqKioqKioq
IGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM2
LjQyMTk3OV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioq
KgpbICAgMzYuNDI3NzE2XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2Nf
ZGlyZWN0KCkgKioqKioqKioqClsgICAzNi40MzQyMzJdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM2LjQ0MTkzMl0gICoqKioqKiogZG1hX2Fs
bG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzYuNDQ4NDUy
XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqClsgICAz
Ni40NjM1OTRdIHVzYi1zdG9yYWdlIDMtNC4yOjEuMDogVVNCIE1hc3MgU3RvcmFnZSBkZXZpY2Ug
ZGV0ZWN0ZWQKWyAgIDM2LjQ3MDA2M10gc2NzaSBob3N0MjogdXNiLXN0b3JhZ2UgMy00LjI6MS4w
ClsgICAzNi40Nzc4OTRdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxvY19k
aXJlY3QoKSAqKioqKioqKioKWyAgIDM2LjQ4NDQxM10gICoqKioqKiogSW4gZG1hX2FsbG9jX2Rp
cmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzYuNDkwMTQ5XSAgKioqKioqKiBkbWFfYWxs
b2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNi40OTY2NjZd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM2
LjUwMjQwMl0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgp
ICoqKioqKioqKgpbICAgMzYuNTA4OTE4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkg
ZnVuY3Rpb24gKioqKioqKioqClsgICAzNi42MDMyNzNdIHVzYiAzLTQuMzogbmV3IGxvdy1zcGVl
ZCBVU0IgZGV2aWNlIG51bWJlciA1IHVzaW5nIHhoY2lfaGNkClsgICAzNi42OTAyOTJdIHNjc2kg
MDowOjA6MDogRGlyZWN0LUFjY2VzcyAgICAgIFVTQiAgICAgIFNhbkRpc2sgMy4yR2VuMSAxLjAw
IFBROiAwIEFOU0k6IDYKWyAgIDM2LjcwMjcxM10gc2QgMDowOjA6MDogW3NkYV0gMTIwMTc2NjQw
IDUxMi1ieXRlIGxvZ2ljYWwgYmxvY2tzOiAoNjEuNSBHQi81Ny4zIEdpQikKWyAgIDM2LjcxMjAw
MF0gc2QgMDowOjA6MDogW3NkYV0gV3JpdGUgUHJvdGVjdCBpcyBvZmYKWyAgIDM2LjcyMDQyN10g
c2QgMDowOjA6MDogW3NkYV0gV3JpdGUgY2FjaGU6IGRpc2FibGVkLCByZWFkIGNhY2hlOiBlbmFi
bGVkLCBkb2Vzbid0IHN1cHBvcnQgRFBPIG9yIEZVQQpbICAgMzYuNzQ3MzIxXSAgKioqKioqKiBk
bWFfYWxsb2NfYXR0cnMoKSAtPiBkbWFfYWxsb2NfZGlyZWN0KCkgKioqKioqKioqClsgICAzNi43
NDg5NDBdIEdQVDpQcmltYXJ5IGhlYWRlciB0aGlua3MgQWx0LiBoZWFkZXIgaXMgbm90IGF0IHRo
ZSBlbmQgb2YgdGhlIGRpc2suClsgICAzNi43NTM4NDJdICAqKioqKioqIEluIGRtYV9hbGxvY19k
aXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM2Ljc2MTIyN10gR1BUOjE3MTgxOTUxICE9
IDEyMDE3NjYzOQpbICAgMzYuNzYxMjI5XSBHUFQ6QWx0ZXJuYXRlIEdQVCBoZWFkZXIgbm90IGF0
IHRoZSBlbmQgb2YgdGhlIGRpc2suClsgICAzNi43NjY5NjddICAqKioqKioqIGRtYV9hbGxvY19h
dHRycygpIC0+IGRtYV9hbGxvY19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM2Ljc3MDYxNF0gR1BU
OjE3MTgxOTUxICE9IDEyMDE3NjYzOQpbICAgMzYuNzcwNjE2XSBHUFQ6IFVzZSBHTlUgUGFydGVk
IHRvIGNvcnJlY3QgR1BUIGVycm9ycy4KWyAgIDM2Ljc3NjYxMl0gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzYuNzgzMTMyXSAgc2RhOiBzZGEx
IHNkYTIKWyAgIDM2Ljc4Njc4Ml0gICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2Fs
bG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAgMzYuNzk1MDY5XSBzZCAwOjA6MDowOiBbc2RhXSBB
dHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNrClsgICAzNi43OTc2NDVdICAqKioqKioqIEluIGRt
YV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioKWyAgIDM2Ljc5NzY0OF0gICoqKioq
KiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2RpcmVjdCgpICoqKioqKioqKgpbICAg
MzYuNzk3NjQ4XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioq
KioqClsgICAzNi43OTk3MzVdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IGRtYV9hbGxv
Y19kaXJlY3QoKSAqKioqKioqKioKWyAgIDM2LjgzNjkyMF0gICoqKioqKiogSW4gZG1hX2FsbG9j
X2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKgpbICAgMzYuODYzOTQ0XSBpbnB1dDogQW1lcmlj
YW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1YWwgS2V5Ym9hcmQgYW5kIE1vdXNlIGFzIC9kZXZpY2Vz
L3BjaTAwMDQ6MDAvMDAwNDowMDowMy4wLzAwMDQ6MDM6MDAuMC91c2IzLzMtNC8zLTQuMy8zLTQu
MzoxLjAvMDAwMzowNDZCOkZGMTAuMDAwMS9pbnB1dC9pbnB1dDEKWyAgIDM2Ljg3OTgwMl0gaGlk
LWdlbmVyaWMgMDAwMzowNDZCOkZGMTAuMDAwMTogaW5wdXQ6IFVTQiBISUQgdjEuMTAgS2V5Ym9h
cmQgW0FtZXJpY2FuIE1lZ2F0cmVuZHMgSW5jLiBWaXJ0dWFsIEtleWJvYXJkIGFuZCBNb3VzZV0g
b24gdXNiLTAwMDQ6MDM6MDAuMC00LjMvaW5wdXQwClsgICAzNi45MDQwMTFdIGlucHV0OiBBbWVy
aWNhbiBNZWdhdHJlbmRzIEluYy4gVmlydHVhbCBLZXlib2FyZCBhbmQgTW91c2UgYXMgL2Rldmlj
ZXMvcGNpMDAwNDowMC8wMDA0OjAwOjAzLjAvMDAwNDowMzowMC4wL3VzYjMvMy00LzMtNC4zLzMt
NC4zOjEuMS8wMDAzOjA0NkI6RkYxMC4wMDAyL2lucHV0L2lucHV0MgpbICAgMzYuOTE5ODYxXSBo
aWQtZ2VuZXJpYyAwMDAzOjA0NkI6RkYxMC4wMDAyOiBpbnB1dDogVVNCIEhJRCB2MS4xMCBNb3Vz
ZSBbQW1lcmljYW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1YWwgS2V5Ym9hcmQgYW5kIE1vdXNlXSBv
biB1c2ItMDAwNDowMzowMC4wLTQuMy9pbnB1dDEKWyAgIDM2Ljk0ODg4OV0gcmFuZG9tOiBmYXN0
IGluaXQgZG9uZQpbICAgMzcuMTY5Mjc0XSBzY3NpIDE6MDowOjA6IENELVJPTSAgICAgICAgICAg
IEFNSSAgICAgIFZpcnR1YWwgQ0RST00wICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMzcu
MTc5NTM1XSBzY3NpIDE6MDowOjE6IENELVJPTSAgICAgICAgICAgIEFNSSAgICAgIFZpcnR1YWwg
Q0RST00xICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMzcuMTkwMDAyXSBzY3NpIDE6MDow
OjI6IENELVJPTSAgICAgICAgICAgIEFNSSAgICAgIFZpcnR1YWwgQ0RST00yICAgMS4wMCBQUTog
MCBBTlNJOiAwIENDUwpbICAgMzcuMTk4ODAwXSBzY3NpIDE6MDowOjM6IENELVJPTSAgICAgICAg
ICAgIEFNSSAgICAgIFZpcnR1YWwgQ0RST00zICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAg
MzcuMjA0ODk4XSBFWFQ0LWZzIChzZGEyKTogMSB0cnVuY2F0ZSBjbGVhbmVkIHVwClsgICAzNy4y
MTE5MjldIEVYVDQtZnMgKHNkYTIpOiByZWNvdmVyeSBjb21wbGV0ZQpbICAgMzcuMjI5MjM4XSBF
WFQ0LWZzIChzZGEyKTogbW91bnRlZCBmaWxlc3lzdGVtIHdpdGggb3JkZXJlZCBkYXRhIG1vZGUu
IE9wdHM6IChudWxsKQpbICAgMzcuMjM2OTA2XSBWRlM6IE1vdW50ZWQgcm9vdCAoZXh0NCBmaWxl
c3lzdGVtKSBvbiBkZXZpY2UgODoyLgpbICAgMzcuMjQ4MDkwXSBkZXZ0bXBmczogbW91bnRlZApb
ICAgMzcuMjUyNjkwXSBGcmVlaW5nIHVudXNlZCBrZXJuZWwgbWVtb3J5OiA0MTYwSwpbICAgMzcu
MjYzMzk2XSBSdW4gL3NiaW4vaW5pdCBhcyBpbml0IHByb2Nlc3MKWyAgIDM3LjQ3MzI2MV0gc3lz
dGVtZFsxXTogc3lzdGVtZCAyNDkuNysgcnVubmluZyBpbiBzeXN0ZW0gbW9kZSAoLVBBTSAtQVVE
SVQgLVNFTElOVVggLUFQUEFSTU9SICtJTUEgLVNNQUNLICtTRUNDT01QIC1HQ1JZUFQgLUdOVVRM
UyAtT1BFTlNTTCArQUNMICtCTEtJRCAtQ1VSTCAtRUxGVVRJTFMgLUZJRE8yIC1JRE4yIC1JRE4g
LUlQVEMgK0tNT0QgLUxJQkNSWVBUU0VUVVAgK0xJQkZESVNLIC1QQ1JFMiAtUFdRVUFMSVRZIC1Q
MTFLSVQgLVFSRU5DT0RFIC1CWklQMiAtTFo0IC1YWiAtWkxJQiArWlNURCArWEtCQ09NTU9OICtV
VE1QICtTWVNWSU5JVCBkZWZhdWx0LWhpZXJhcmNoeT1oeWJyaWQpClsgICAzNy40ODc5MjhdIHNj
c2kgMjowOjA6MDogRGlyZWN0LUFjY2VzcyAgICAgQU1JICAgICAgVmlydHVhbCBIRGlzazAgICAx
LjAwIFBROiAwIEFOU0k6IDAgQ0NTClsgICAzNy41MDM2OTddIHN5c3RlbWRbMV06IERldGVjdGVk
IGFyY2hpdGVjdHVyZSBhcm02NC4KWyAgIDM3LjUxMjEwN10gc2NzaSAyOjA6MDoxOiBEaXJlY3Qt
QWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrMSAgIDEuMDAgUFE6IDAgQU5TSTogMCBD
Q1MKWyAgIDM3LjUyNTQyNF0gc2NzaSAyOjA6MDoyOiBEaXJlY3QtQWNjZXNzICAgICBBTUkgICAg
ICBWaXJ0dWFsIEhEaXNrMiAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM3LjUzNDExMl0g
c2NzaSAyOjA6MDozOiBEaXJlY3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrMyAg
IDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM3LjUzNjI1OF0gc2QgMjowOjA6MDogW3NkYl0g
QXR0YWNoZWQgU0NTSSByZW1vdmFibGUgZGlzawpbICAgMzcuNTQyODM3XSBzY3NpIDI6MDowOjQ6
IERpcmVjdC1BY2Nlc3MgICAgIEFNSSAgICAgIFZpcnR1YWwgSERpc2s0ICAgMS4wMCBQUTogMCBB
TlNJOiAwIENDUwpbICAgMzcuNTUyMzQ5XSBzZCAyOjA6MDoxOiBbc2RjXSBBdHRhY2hlZCBTQ1NJ
IHJlbW92YWJsZSBkaXNrCgpXZWxjb21lIHRvIEVXQU9MIChFZGdlIFdvcmtsb2FkIEFic3RyYWN0
aW9uIGFuZCBPcmNoZXN0cmF0aW9uIExheWVyKSB1bnN0YWJbICAgMzcuNTY3Mjk0XSBzZCAyOjA6
MDoyOiBbc2RkXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNrCmxlIChob25pc3RlcikhCgpb
ICAgMzcuNTgwMDA4XSBzZCAyOjA6MDozOiBbc2RlXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBk
aXNrClsgICAzNy41OTkxOTBdIHN5c3RlbWRbMV06IEhvc3RuYW1lIHNldCB0byA8Y29taHBjPi4K
WyAgIDM3LjYwMDU0MF0gc2QgMjowOjA6NDogW3NkZl0gQXR0YWNoZWQgU0NTSSByZW1vdmFibGUg
ZGlzawpbICAgMzcuNjQ3MDQyXSBzeXN0ZW1kLXN5c3YtZ2VuZXJhdG9yWzMzMl06IFN5c1Ygc2Vy
dmljZSAnL2V0Yy9pbml0LmQvY29ubnRyYWNrZCcgbGFja3MgYSBuYXRpdmUgc3lzdGVtZCB1bml0
IGZpbGUuIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGluZyBhIHVuaXQgZmlsZSBmb3IgY29tcGF0aWJp
bGl0eS4gUGxlYXNlIHVwZGF0ZSBwYWNrYWdlIHRvIGluY2x1ZGUgYSBuYXRpdmUgc3lzdGVtZCB1
bml0IGZpbGUsIGluIG9yZGVyIHRvIG1ha2UgaXQgbW9yZSBzYWZlIGFuZCByb2J1c3QuClsgICAz
Ny42NzEwNjJdIHN5c3RlbWQtc3lzdi1nZW5lcmF0b3JbMzMyXTogU3lzViBzZXJ2aWNlICcvZXRj
L2luaXQuZC9jb25udHJhY2stZmFpbG92ZXInIGxhY2tzIGEgbmF0aXZlIHN5c3RlbWQgdW5pdCBm
aWxlLiBBdXRvbWF0aWNhbGx5IGdlbmVyYXRpbmcgYSB1bml0IGZpbGUgZm9yIGNvbXBhdGliaWxp
dHkuIFBsZWFzZSB1cGRhdGUgcGFja2FnZSB0byBpbmNsdWRlIGEgbmF0aXZlIHN5c3RlbWQgdW5p
dCBmaWxlLCBpbiBvcmRlciB0byBtYWtlIGl0IG1vcmUgc2FmZSBhbmQgcm9idXN0LgpbICAgMzcu
Nzk1MDg2XSBzeXN0ZW1kWzFdOiAvbGliL3N5c3RlbWQvc3lzdGVtL3hlbi1xZW11LWRvbTAtZGlz
ay1iYWNrZW5kLnNlcnZpY2U6MTE6IFBJREZpbGU9IHJlZmVyZW5jZXMgYSBwYXRoIGJlbG93IGxl
Z2FjeSBkaXJlY3RvcnkgL3Zhci9ydW4vLCB1cGRhdGluZyAvdmFyL3J1bi94ZW4vcWVtdS1kb20w
LnBpZCDihpIgL3J1bi94ZW4vcWVtdS1kb20wLnBpZDsgcGxlYXNlIHVwZGF0ZSB0aGUgdW5pdCBm
aWxlIGFjY29yZGluZ2x5LgpbICAgMzcuODgzODA3XSBzeXN0ZW1kWzFdOiBRdWV1ZWQgc3RhcnQg
am9iIGZvciBkZWZhdWx0IHRhcmdldCBNdWx0aS1Vc2VyIFN5c3RlbS4KWyAgIDM3Ljg5MTI5MF0g
cmFuZG9tOiBzeXN0ZW1kOiB1bmluaXRpYWxpemVkIHVyYW5kb20gcmVhZCAoMTYgYnl0ZXMgcmVh
ZCkKWyAgIDM3LjkyMjc0MV0gc3lzdGVtZFsxXTogQ3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVt
L2dldHR5LgpbICBPSyAgXSBDcmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vZ2V0dHkuClsgICAz
Ny45NDM2OTddIHJhbmRvbTogc3lzdGVtZDogdW5pbml0aWFsaXplZCB1cmFuZG9tIHJlYWQgKDE2
IGJ5dGVzIHJlYWQpClsgICAzNy45NTA5NDNdIHN5c3RlbWRbMV06IENyZWF0ZWQgc2xpY2UgU2xp
Y2UgL3N5c3RlbS9tb2Rwcm9iZS4KWyAgT0sgIF0gQ3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVt
L21vZHByb2JlLgpbICAgMzcuOTcxMzk1XSByYW5kb206IHN5c3RlbWQ6IHVuaW5pdGlhbGl6ZWQg
dXJhbmRvbSByZWFkICgxNiBieXRlcyByZWFkKQpbICAgMzcuOTc4NTg5XSBzeXN0ZW1kWzFdOiBD
cmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vc2VyaWFsLWdldHR5LgpbICBPSyAgXSBDcmVhdGVk
IHNsaWNlIFNsaWNlIC9zeXN0ZW0vc2VyaWFsLWdldHR5LgpbICAgMzguMDAwMjIwXSBzeXN0ZW1k
WzFdOiBDcmVhdGVkIHNsaWNlIFVzZXIgYW5kIFNlc3Npb24gU2xpY2UuClsgIE9LICBdIENyZWF0
ZWQgc2xpY2UgVXNlciBhbmQgU2Vzc2lvbiBTbGljZS4KWyAgIDM4LjAxOTUyMF0gc3lzdGVtZFsx
XTogU3RhcnRlZCBEaXNwYXRjaCBQYXNzd29yZCBSZXF1ZXN0cyB0byBDb25zb2xlIERpcmVjdG9y
eSBXYXRjaC4KWyAgT0sgIF0gU3RhcnRlZCBEaXNwYXRjaCBQYXNzd29yZCDigKZ0cyB0byBDb25z
b2xlIERpcmVjdG9yeSBXYXRjaC4KWyAgIDM4LjA0MzQ3OF0gc3lzdGVtZFsxXTogU3RhcnRlZCBG
b3J3YXJkIFBhc3N3b3JkIFJlcXVlc3RzIHRvIFdhbGwgRGlyZWN0b3J5IFdhdGNoLgpbICBPSyAg
XSBTdGFydGVkIEZvcndhcmQgUGFzc3dvcmQgUuKApnVlc3RzIHRvIFdhbGwgRGlyZWN0b3J5IFdh
dGNoLgpbICAgMzguMDY3NTI0XSBzeXN0ZW1kWzFdOiBSZWFjaGVkIHRhcmdldCBQYXRoIFVuaXRz
LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBQYXRoIFVuaXRzLgpbICAgMzguMDg3Mzc2XSBzeXN0
ZW1kWzFdOiBSZWFjaGVkIHRhcmdldCBSZW1vdGUgRmlsZSBTeXN0ZW1zLgpbICBPSyAgXSBSZWFj
aGVkIHRhcmdldCBSZW1vdGUgRmlsZSBTeXN0ZW1zLgpbICAgMzguMTA3MzM3XSBzeXN0ZW1kWzFd
OiBSZWFjaGVkIHRhcmdldCBTbGljZSBVbml0cy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU2xp
Y2UgVW5pdHMuClsgICAzOC4xMjczNTVdIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0IFN3YXBz
LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTd2Fwcy4KWyAgIDM4LjE1NTg2MV0gc3lzdGVtZFsx
XTogTGlzdGVuaW5nIG9uIFJQQ2JpbmQgU2VydmVyIEFjdGl2YXRpb24gU29ja2V0LgpbICBPSyAg
XSBMaXN0ZW5pbmcgb24gUlBDYmluZCBTZXJ2ZXIgQWN0aXZhdGlvbiBTb2NrZXQuClsgICAzOC4x
Nzk0NDddIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0IFJQQyBQb3J0IE1hcHBlci4KWyAgT0sg
IF0gUmVhY2hlZCB0YXJnZXQgUlBDIFBvcnQgTWFwcGVyLgpbICAgMzguMTk5NjUyXSBzeXN0ZW1k
WzFdOiBMaXN0ZW5pbmcgb24gU3lzbG9nIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIFN5
c2xvZyBTb2NrZXQuClsgICAzOC4yMTk1MDddIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBpbml0
Y3RsIENvbXBhdGliaWxpdHkgTmFtZWQgUGlwZS4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIGluaXRj
dGwgQ29tcGF0aWJpbGl0eSBOYW1lZCBQaXBlLgpbICAgMzguMjQwNTYzXSBzeXN0ZW1kWzFdOiBD
b25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gSm91cm5hbCBBdWRpdCBTb2NrZXQgYmVpbmcgc2tp
cHBlZC4KWyAgIDM4LjI0ODY3Ml0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIEpvdXJuYWwgU29j
a2V0ICgvZGV2L2xvZykuClsgIE9LICBdIExpc3RlbmluZyBvbiBKb3VybmFsIFNvY2tldCAoL2Rl
di9sb2cpLgpbICAgMzguMjcxNTc2XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gSm91cm5hbCBT
b2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiBKb3VybmFsIFNvY2tldC4KWyAgIDM4LjI5MTYz
N10gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIE5ldHdvcmsgU2VydmljZSBOZXRsaW5rIFNvY2tl
dC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIE5ldHdvcmsgU2VydmljZSBOZXRsaW5rIFNvY2tldC4K
WyAgIDM4LjMxMTY1OV0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIHVkZXYgQ29udHJvbCBTb2Nr
ZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiB1ZGV2IENvbnRyb2wgU29ja2V0LgpbICAgMzguMzMx
NTI5XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gdWRldiBLZXJuZWwgU29ja2V0LgpbICBPSyAg
XSBMaXN0ZW5pbmcgb24gdWRldiBLZXJuZWwgU29ja2V0LgpbICAgMzguMzUxNTU4XSBzeXN0ZW1k
WzFdOiBMaXN0ZW5pbmcgb24gVXNlciBEYXRhYmFzZSBNYW5hZ2VyIFNvY2tldC4KWyAgT0sgIF0g
TGlzdGVuaW5nIG9uIFVzZXIgRGF0YWJhc2UgTWFuYWdlciBTb2NrZXQuClsgICAzOC4zNzI5MjFd
IHN5c3RlbWRbMV06IE1vdW50aW5nIEh1Z2UgUGFnZXMgRmlsZSBTeXN0ZW0uLi4KICAgICAgICAg
TW91bnRpbmcgSHVnZSBQYWdlcyBGaWxlIFN5c3RlbS4uLgpbICAgMzguMzkyNzk3XSBzeXN0ZW1k
WzFdOiBNb3VudGluZyBQT1NJWCBNZXNzYWdlIFF1ZXVlIEZpbGUgU3lzdGVtLi4uCiAgICAgICAg
IE1vdW50aW5nIFBPU0lYIE1lc3NhZ2UgUXVldWUgRmlsZSBTeXN0ZW0uLi4KWyAgIDM4LjQxNTQy
M10gc3lzdGVtZFsxXTogQ29uZGl0aW9uIGNoZWNrIHJlc3VsdGVkIGluIE1vdW50IC9wcm9jL3hl
biBmaWxlcyBiZWluZyBza2lwcGVkLgpbICAgMzguNDI0NTUxXSBzeXN0ZW1kWzFdOiBNb3VudGlu
ZyBLZXJuZWwgRGVidWcgRmlsZSBTeXN0ZW0uLi4KICAgICAgICAgTW91bnRpbmcgS2VybmVsIERl
YnVnIEZpbGUgU3lzdGVtLi4uClsgICAzOC40NDQ3MDNdIHN5c3RlbWRbMV06IE1vdW50aW5nIEtl
cm5lbCBUcmFjZSBGaWxlIFN5c3RlbS4uLgogICAgICAgICBNb3VudGluZyBLZXJuZWwgVHJhY2Ug
RmlsZSBTeXN0ZW0uLi4KWyAgIDM4LjQ2Njk0OF0gc3lzdGVtZFsxXTogTW91bnRpbmcgVGVtcG9y
YXJ5IERpcmVjdG9yeSAvdG1wLi4uCiAgICAgICAgIE1vdW50aW5nIFRlbXBvcmFyeSBEaXJlY3Rv
cnkgL3RtcC4uLgpbICAgMzguNDg3NjA1XSBzeXN0ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVz
dWx0ZWQgaW4gQ3JlYXRlIExpc3Qgb2YgU3RhdGljIERldmljZSBOb2RlcyBiZWluZyBza2lwcGVk
LgpbICAgMzguNDk3ODM1XSBzeXN0ZW1kWzFdOiBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUg
Y29uZmlnZnMuLi4KICAgICAgICAgU3RhcnRpbmcgTG9hZCBLZXJuZWwgTW9kdWxlIGNvbmZpZ2Zz
Li4uClsgICAzOC41MTY3MTZdIHN5c3RlbWRbMV06IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVs
ZSBkcm0uLi4KICAgICAgICAgU3RhcnRpbmcgTG9hZCBLZXJuZWwgTW9kdWxlIGRybS4uLgpbICAg
MzguNTM2NjY3XSBzeXN0ZW1kWzFdOiBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgZnVzZS4u
LgogICAgICAgICBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgZnVzZS4uLgpbICAgMzguNTU2
ODgwXSBzeXN0ZW1kWzFdOiBTdGFydGluZyBSUEMgQmluZC4uLgogICAgICAgICBTdGFydGluZyBS
UEMgQmluZC4uLgpbICAgMzguNTcyNzk1XSBzeXN0ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVz
dWx0ZWQgaW4gRmlsZSBTeXN0ZW0gQ2hlY2sgb24gUm9vdCBEZXZpY2UgYmVpbmcgc2tpcHBlZC4K
WyAgIDM4LjU4MzcyNF0gc3lzdGVtZFsxXTogU3RhcnRpbmcgSm91cm5hbCBTZXJ2aWNlLi4uCiAg
ICAgICAgIFN0YXJ0aW5nIEpvdXJuYWwgU2VydmljZS4uLgpbICAgMzguNjA1NTMxXSBzeXN0ZW1k
WzFdOiBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGVzLi4uCiAgICAgICAgIFN0YXJ0aW5nIExv
YWQgS2VybmVsIE1vZHVsZXMuLi4KWyAgIDM4LjYyNDUzOV0gc3lzdGVtZFsxXTogU3RhcnRpbmcg
UmVtb3VudCBSb290IGFuZCBLZXJuZWwgRmlsZSBTeXN0ZW1zLi4uClsgICAzOC42MzA4ODVdIEVY
VDQtZnMgKHNkYTIpOiByZS1tb3VudGVkLiBPcHRzOiAobnVsbCkKICAgICAgICAgU3RhcnRpbmcg
UmVtb3VudCBSb290IGFuZCBLZXJuZWwgRmlsZSBTeXN0ZW1zLi4uClsgICAzOC42NTI1NjldIHN5
c3RlbWRbMV06IFN0YXJ0aW5nIENvbGRwbHVnIEFsbCB1ZGV2IERldmljZXMuLi4KICAgICAgICAg
U3RhcnRpbmcgQ29sZHBsdWcgQWxsIHVkZXYgRGV2aWNlcy4uLgpbICAgMzguNjczMjQyXSBzeXN0
ZW1kWzFdOiBTdGFydGVkIFJQQyBCaW5kLgpbICBPSyAgXSBTdGFydGVkIFJQQyBCaW5kLgpbICAg
MzguNjkxODYxXSBzeXN0ZW1kWzFdOiBTdGFydGVkIEpvdXJuYWwgU2VydmljZS4KWyAgT0sgIF0g
U3RhcnRlZCBKb3VybmFsIFNlcnZpY2UuClsgIE9LICBdIE1vdW50ZWQgSHVnZSBQYWdlcyBGaWxl
IFN5c3RlbS4KWyAgT0sgIF0gTW91bnRlZCBQT1NJWCBNZXNzYWdlIFF1ZXVlIEZpbGUgU3lzdGVt
LgpbICBPSyAgXSBNb3VudGVkIEtlcm5lbCBEZWJ1ZyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91
bnRlZCBLZXJuZWwgVHJhY2UgRmlsZSBTeXN0ZW0uClsgIE9LICBdIE1vdW50ZWQgVGVtcG9yYXJ5
IERpcmVjdG9yeSAvdG1wLgpbICBPSyAgXSBGaW5pc2hlZCBMb2FkIEtlcm5lbCBNb2R1bGUgY29u
ZmlnZnMuClsgIE9LICBdIEZpbmlzaGVkIExvYWQgS2VybmVsIE1vZHVsZSBkcm0uClsgIE9LICBd
IEZpbmlzaGVkIExvYWQgS2VybmVsIE1vZHVsZSBmdXNlLgpbRkFJTEVEXSBGYWlsZWQgdG8gc3Rh
cnQgTG9hZCBLZXJuZWwgTW9kdWxlcy4KU2VlICdzeXN0ZW1jdGwgc3RhdHVzIHN5c3RlbWQtbW9k
dWxlcy1sb2FkLnNlcnZpY2UnIGZvciBkZXRhaWxzLgpbICBPSyAgXSBGaW5pc2hlZCBSZW1vdW50
IFJvb3QgYW5kIEtlcm5lbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIE1vdW50aW5nIEtlcm5lbCBD
b25maWd1cmF0aW9uIEZpbGUgU3lzdGVtLi4uCiAgICAgICAgIFN0YXJ0aW5nIEZsdXNoIEpvdXJu
YWwgdG8gUGVyc2lzdGVudCBTdG9yYWdlLi4uClsgICAzOC44ODkxMzBdIHN5c3RlbWQtam91cm5h
bGRbMzU1XTogUmVjZWl2ZWQgY2xpZW50IHJlcXVlc3QgdG8gZmx1c2ggcnVudGltZSBqb3VybmFs
LgogICAgICAgICBTdGFydGluZyBBcHBseSBLZXJuZWwgVmFyaWFibGVzLi4uCiAgICAgICAgIFN0
YXJ0aW5nIENyZWF0ZSBTdGF0aWMgRGV2aWNlIE5vZGVzIGluIC9kZXYuLi4KWyAgT0sgIF0gTW91
bnRlZCBLZXJuZWwgQ29uZmlndXJhdGlvbiBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gRmluaXNoZWQg
Rmx1c2ggSm91cm5hbCB0byBQZXJzaXN0ZW50IFN0b3JhZ2UuClsgIE9LICBdIEZpbmlzaGVkIEFw
cGx5IEtlcm5lbCBWYXJpYWJsZXMuClsgIE9LICBdIEZpbmlzaGVkIENvbGRwbHVnIEFsbCB1ZGV2
IERldmljZXMuClsgIE9LICBdIEZpbmlzaGVkIENyZWF0ZSBTdGF0aWMgRGV2aWNlIE5vZGVzIGlu
IC9kZXYuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFByZXBhcmF0aW9uIGZvciBMb2NhbCBGaWxl
IFN5c3RlbXMuCiAgICAgICAgIE1vdW50aW5nIC92YXIvdm9sYXRpbGUuLi4KICAgICAgICAgU3Rh
cnRpbmcgV2FpdCBmb3IgdWRldiBUbyDigKZwbGV0ZSBEZXZpY2UgSW5pdGlhbGl6YXRpb24uLi4K
ICAgICAgICAgU3RhcnRpbmcgUnVsZS1iYXNlZCBNYW5hZ2XigKZmb3IgRGV2aWNlIEV2ZW50cyBh
bmQgRmlsZXMuLi4KWyAgT0sgIF0gTW91bnRlZCAvdmFyL3ZvbGF0aWxlLgogICAgICAgICBTdGFy
dGluZyBMb2FkL1NhdmUgUmFuZG9tIFNlZWQuLi4KWyAgT0sgIF0gU3RhcnRlZCBSdWxlLWJhc2Vk
IE1hbmFnZXIgZm9yIERldmljZSBFdmVudHMgYW5kIEZpbGVzLgpbICBPSyAgXSBMaXN0ZW5pbmcg
b24gTG9hZC9TYXZlIFJGIOKApml0Y2ggU3RhdHVzIC9kZXYvcmZraWxsIFdhdGNoLgpbICBPSyAg
XSBGb3VuZCBkZXZpY2UgU2FuRGlza18zLjJHZW4xIG1zZG9zLgogICAgICAgICBNb3VudGluZyAv
Ym9vdC4uLgpbICBPSyAgXSBNb3VudGVkIC9ib290LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBM
b2NhbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIFN0YXJ0aW5nIENyZWF0ZSBWb2xhdGlsZSBGaWxl
cyBhbmQgRGlyZWN0b3JpZXMuLi4KWyAgT0sgIF0gRmluaXNoZWQgV2FpdCBmb3IgdWRldiBUbyBD
b21wbGV0ZSBEZXZpY2UgSW5pdGlhbGl6YXRpb24uClsgIE9LICBdIEZpbmlzaGVkIENyZWF0ZSBW
b2xhdGlsZSBGaWxlcyBhbmQgRGlyZWN0b3JpZXMuClsgIE9LICBdIFN0YXJ0ZWQgSGFyZHdhcmUg
Uk5HIEVudHJvcHkgR2F0aGVyZXIgRGFlbW9uLgogICAgICAgICBTdGFydGluZyBOZXR3b3JrIFRp
bWUgU3luY2hyb25pemF0aW9uLi4uCiAgICAgICAgIFN0YXJ0aW5nIFJlY29yZCBTeXN0ZW0gQm9v
dC9TaHV0ZG93biBpbiBVVE1QLi4uClsgIE9LICBdIEZpbmlzaGVkIFJlY29yZCBTeXN0ZW0gQm9v
dC9TaHV0ZG93biBpbiBVVE1QLgpbICBPSyAgXSBTdGFydGVkIE5ldHdvcmsgVGltZSBTeW5jaHJv
bml6YXRpb24uClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFN5c3RlbSBJbml0aWFsaXphdGlvbi4K
WyAgT0sgIF0gU3RhcnRlZCBEYWlseSBDbGVhbnVwIG9mIFRlbXBvcmFyeSBEaXJlY3Rvcmllcy4K
WyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU3lzdGVtIFRpbWUgU2V0LgpbICBPSyAgXSBSZWFjaGVk
IHRhcmdldCBUaW1lciBVbml0cy4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIEF2YWhpIG1ETlMvRE5T
LVNEIFN0YWNrIEFjdGl2YXRpb24gU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gRC1CdXMg
U3lzdGVtIE1lc3NhZ2UgQnVzIFNvY2tldC4KICAgICAgICAgU3RhcnRpbmcgRG9ja2VyIFNvY2tl
dCBmb3IgdGhlIEFQSS4uLgogICAgICAgICBTdGFydGluZyBzc2hkLnNvY2tldC4uLgpbICBPSyAg
XSBMaXN0ZW5pbmcgb24gRG9ja2VyIFNvY2tldCBmb3IgdGhlIEFQSS4KWyAgT0sgIF0gTGlzdGVu
aW5nIG9uIHNzaGQuc29ja2V0LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTb2NrZXQgVW5pdHMu
ClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEJhc2ljIFN5c3RlbS4KICAgICAgICAgU3RhcnRpbmcg
QUNQSSBFdmVudCBEYWVtb24uLi4KWyAgT0sgIF0gU3RhcnRlZCBLZXJuZWwgTG9nZ2luZyBTZXJ2
aWNlLgpbICBPSyAgXSBTdGFydGVkIFN5c3RlbSBMb2dnaW5nIFNlcnZpY2UuClsgIE9LICBdIFN0
YXJ0ZWQgRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVzLgpbICBPSyAgXSBTdGFydGVkIEdldHR5IG9u
IHR0eTEuCiAgICAgICAgIFN0YXJ0aW5nIElQdjYgUGFja2V0IEZpbHRlcmluZyBGcmFtZXdvcmsu
Li4KICAgICAgICAgU3RhcnRpbmcgSVB2NCBQYWNrZXQgRmlsdGVyaW5nIEZyYW1ld29yay4uLgog
ICAgICAgICBTdGFydGluZyBUZWxlcGhvbnkgc2VydmljZS4uLgpbICBPSyAgXSBTdGFydGVkIFNl
cmlhbCBHZXR0eSBvbiB0dHlBTUEwLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBMb2dpbiBQcm9t
cHRzLgogICAgICAgICBTdGFydGluZyBVc2VyIExvZ2luIE1hbmFnZW1lbnQuLi4KICAgICAgICAg
U3RhcnRpbmcgT3BlblNTSCBLZXkgR2VuZXJhdGlvbi4uLgpbICBPSyAgXSBTdGFydGVkIEFDUEkg
RXZlbnQgRGFlbW9uLgpbICBPSyAgXSBGaW5pc2hlZCBJUHY2IFBhY2tldCBGaWx0ZXJpbmcgRnJh
bWV3b3JrLgpbICBPSyAgXSBGaW5pc2hlZCBJUHY0IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3Jr
LgpbICBPSyAgXSBGaW5pc2hlZCBPcGVuU1NIIEtleSBHZW5lcmF0aW9uLgpbICBPSyAgXSBSZWFj
aGVkIHRhcmdldCBQcmVwYXJhdGlvbiBmb3IgTmV0d29yay4KICAgICAgICAgU3RhcnRpbmcgTmV0
d29yayBDb25maWd1cmF0aW9uLi4uClsgIE9LICBdIFN0YXJ0ZWQgVXNlciBMb2dpbiBNYW5hZ2Vt
ZW50LgpbICBPSyAgXSBTdGFydGVkIFRlbGVwaG9ueSBzZXJ2aWNlLgpbICBPSyAgXSBTdGFydGVk
IE5ldHdvcmsgQ29uZmlndXJhdGlvbi4KICAgICAgICAgU3RhcnRpbmcgV2FpdCBmb3IgTmV0d29y
ayB0byBiZSBDb25maWd1cmVkLi4uCiAgICAgICAgIFN0YXJ0aW5nIE5ldHdvcmsgTmFtZSBSZXNv
bHV0aW9uLi4uClsgIE9LICBdIFN0YXJ0ZWQgTmV0d29yayBOYW1lIFJlc29sdXRpb24uClsgIE9L
ICBdIFJlYWNoZWQgdGFyZ2V0IE5ldHdvcmsuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEhvc3Qg
YW5kIE5ldHdvcmsgTmFtZSBMb29rdXBzLgogICAgICAgICBTdGFydGluZyBBdmFoaSBtRE5TL0RO
Uy1TRCBTdGFjay4uLgogICAgICAgICBTdGFydGluZyBjb250YWluZXJkIGNvbnRhaW5lciBydW50
aW1lLi4uClsgIE9LICBdIEZpbmlzaGVkIExvYWQvU2F2ZSBSYW5kb20gU2VlZC4KWyAgT0sgIF0g
U3RhcnRlZCBBdmFoaSBtRE5TL0ROUy1TRCBTdGFjay4KWyAgT0sgIF0gU3RhcnRlZCBjb250YWlu
ZXJkIGNvbnRhaW5lciBydW50aW1lLgoKRVdBT0wgKEVkZ2UgV29ya2xvYWQgQWJzdHJhY3Rpb24g
YW5kIE9yY2hlc3RyYXRpb24gTGF5ZXIpIHVuc3RhYmxlIGNvbWhwYyB0dHlBTUEwCgpjb21ocGMg
bG9naW46IHJvb3QKcm9vdEBjb21ocGM6fiMgCg==

--_007_8C5118886183421EA4C7B271DAF46696armcom_
Content-Type: application/octet-stream; name="xen_linux_boot_debug.log"
Content-Description: xen_linux_boot_debug.log
Content-Disposition: attachment; filename="xen_linux_boot_debug.log";
	size=147979; creation-date="Thu, 14 Apr 2022 17:44:24 GMT";
	modification-date="Thu, 14 Apr 2022 17:44:24 GMT"
Content-ID: <F8D828581AE8AD42943E79D81173B5B4@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogVGh1IEFwciAxNCAxMTowMzowNyBvbiB0dHlzMDAxDQpyYWhzaW4wMUBDMDJa
WDBHOUxWRE4geDg2XzY0ICUgdGVsbmV0IGUxMjMzNDMuY2FtYnJpZGdlLmFybS5jb20gMTAwMjAN
ClRyeWluZyAxMC4xLjE5NC4yNS4uLg0KQ29ubmVjdGVkIHRvIGUxMjMzNDMuY2FtYnJpZGdlLmFy
bS5jb20uDQpFc2NhcGUgY2hhcmFjdGVyIGlzICdeXScuDQoNCkFJUyB0YXJnZXQgc3lzdGVtIHBv
cnQgMTAwMjAgZGV2aWNlIC9kZXYvdHR5VVNCMSBbMTE1MjAwIE44MV0NCg0KDQpGUzA6XD4gDQpG
UzA6XD4gDQpGUzA6XD4geGVuLmVmaQ0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0K
DQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KWGVuIDQu
MTctdW5zdGFibGUgKGMvcyBGcmkgQXByIDEgMDk6NTI6NTMgMjAyMiArMDEwMCBnaXQ6YjFkYzQy
ZjE0ZikgRUZJIGxvYWRlcg0KVXNpbmcgY29uZmlndXJhdGlvbiBmaWxlICd4ZW4uY2ZnJw0KSW1h
Z2UteGVuOiAweDAwMDAwMDAwZmU0N2MwMDAtMHgwMDAwMDAwMGZmYjNmMjAwDQpVc2luZyBib290
YXJncyBmcm9tIFhlbiBjb25maWd1cmF0aW9uIGZpbGUuDQpQUk9HUkVTUyBDT0RFOiBWMDMxMDEw
MTkgSTANCiBYZW4gNC4xNy11bnN0YWJsZQ0KKFhFTikgWGVuIHZlcnNpb24gNC4xNy11bnN0YWJs
ZSAocmFoc2luMDFAY2FtYnJpZGdlLmFybS5jb20pIChhYXJjaDY0LWxpbnV4LWdudS1nY2MgKFVi
dW50dSA5LjQuMC0xdWJ1bnR1MX4yMC4wNC4xKSA5LjQuMCkgZGVidWc9eSBXZWQgQXByIDEzIDEy
OjQ4OjUxIEJTVCAyMDIyDQooWEVOKSBMYXRlc3QgQ2hhbmdlU2V0OiBGcmkgQXByIDEgMDk6NTI6
NTMgMjAyMiArMDEwMCBnaXQ6YjFkYzQyZjE0Zg0KKFhFTikgYnVpbGQtaWQ6IDU4MzQxNWYyODk0
N2YwMGM4NmMxZWQwNjIwN2YzNzk4NjRmYTdiNzINCihYRU4pIFByb2Nlc3NvcjogMDAwMDAwMDA0
MTNmZDBjMTogIkFSTSBMaW1pdGVkIiwgdmFyaWFudDogMHgzLCBwYXJ0IDB4ZDBjLHJldiAweDEN
CihYRU4pIDY0LWJpdCBFeGVjdXRpb246DQooWEVOKSAgIFByb2Nlc3NvciBGZWF0dXJlczogMTEw
MDAwMDAxMTExMTExMiAwMDAwMDAwMDAwMDAwMDIwDQooWEVOKSAgICAgRXhjZXB0aW9uIExldmVs
czogRUwzOjY0IEVMMjo2NCBFTDE6NjQgRUwwOjY0KzMyDQooWEVOKSAgICAgRXh0ZW5zaW9uczog
RmxvYXRpbmdQb2ludCBBZHZhbmNlZFNJTUQgR0lDdjMtU3lzUmVnDQooWEVOKSAgIERlYnVnIEZl
YXR1cmVzOiAwMDAwMDAwMTEwMzA1NDA4IDAwMDAwMDAwMDAwMDAwMDANCihYRU4pICAgQXV4aWxp
YXJ5IEZlYXR1cmVzOiAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwMDAwMDAwMDANCihYRU4pICAg
TWVtb3J5IE1vZGVsIEZlYXR1cmVzOiAwMDAwMDAwMDAwMTAxMTI1IDAwMDAwMDAwMTAyMTIxMjIN
CihYRU4pICAgSVNBIEZlYXR1cmVzOiAgMDAwMDEwMDAxMDIxMTEyMCAwMDAwMDAwMDAwMTAwMDAx
DQooWEVOKSAzMi1iaXQgRXhlY3V0aW9uOg0KKFhFTikgICBQcm9jZXNzb3IgRmVhdHVyZXM6IDAw
MDAwMDAwMTAwMTAxMzE6MDAwMDAwMDAxMDAxMDAwMA0KKFhFTikgICAgIEluc3RydWN0aW9uIFNl
dHM6IEFBcmNoMzIgQTMyIFRodW1iIFRodW1iLTIgSmF6ZWxsZQ0KKFhFTikgICAgIEV4dGVuc2lv
bnM6IEdlbmVyaWNUaW1lcg0KKFhFTikgICBEZWJ1ZyBGZWF0dXJlczogMDAwMDAwMDAwNDAxMDA4
OA0KKFhFTikgICBBdXhpbGlhcnkgRmVhdHVyZXM6IDAwMDAwMDAwMDAwMDAwMDANCihYRU4pICAg
TWVtb3J5IE1vZGVsIEZlYXR1cmVzOiAwMDAwMDAwMDEwMjAxMTA1IDAwMDAwMDAwNDAwMDAwMDAN
CihYRU4pICAgICAgICAgICAgICAgICAgICAgICAgICAwMDAwMDAwMDAxMjYwMDAwIDAwMDAwMDAw
MDIxMjIyMTENCihYRU4pICAgSVNBIEZlYXR1cmVzOiAwMDAwMDAwMDAyMTAxMTEwIDAwMDAwMDAw
MTMxMTIxMTEgMDAwMDAwMDAyMTIzMjA0Mg0KKFhFTikgICAgICAgICAgICAgICAgIDAwMDAwMDAw
MDExMTIxMzEgMDAwMDAwMDAwMDAxMDE0MiAwMDAwMDAwMDAxMDExMTIxDQooWEVOKSBVc2luZyBT
TUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjINCihYRU4pIFVzaW5nIFBTQ0kgdjEuMQ0KKFhFTikg
QUNQSTogR0lDQyAoYWNwaV9pZFsweDEwMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDEwMDAwMF0g
ZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxODAwXSBhZGRyZXNzWzB4MF0g
TVBJRFJbMHgxODAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTYw
MF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTYwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lD
QyAoYWNwaV9pZFsweDFlMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDFlMDAwMF0gZW5hYmxlZCkN
CihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgwODAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHg4
MDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgyMDAwXSBhZGRyZXNz
WzB4MF0gTVBJRFJbMHgyMDAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lk
WzB4MGUwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4ZTAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJ
OiBHSUNDIChhY3BpX2lkWzB4MjYwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjYwMDAwXSBlbmFi
bGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDExMDBdIGFkZHJlc3NbMHgwXSBNUElE
UlsweDExMDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxOTAwXSBh
ZGRyZXNzWzB4MF0gTVBJRFJbMHgxOTAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChh
Y3BpX2lkWzB4MTcwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTcwMDAwXSBlbmFibGVkKQ0KKFhF
TikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDFmMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDFmMDAw
MF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgwOTAwXSBhZGRyZXNzWzB4
MF0gTVBJRFJbMHg5MDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgy
MTAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgyMTAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBH
SUNDIChhY3BpX2lkWzB4MGYwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4ZjAwMDBdIGVuYWJsZWQp
DQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MjcwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4
MjcwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDEwMDFdIGFkZHJl
c3NbMHgwXSBNUElEUlsweDEwMDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlf
aWRbMHgxODAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxODAxMDBdIGVuYWJsZWQpDQooWEVOKSBB
Q1BJOiBHSUNDIChhY3BpX2lkWzB4MTYwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTYwMTAwXSBl
bmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDFlMDFdIGFkZHJlc3NbMHgwXSBN
UElEUlsweDFlMDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgwODAx
XSBhZGRyZXNzWzB4MF0gTVBJRFJbMHg4MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0Mg
KGFjcGlfaWRbMHgyMDAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgyMDAxMDBdIGVuYWJsZWQpDQoo
WEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MGUwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4ZTAx
MDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MjYwMV0gYWRkcmVzc1sw
eDBdIE1QSURSWzB4MjYwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsw
eDExMDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDExMDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6
IEdJQ0MgKGFjcGlfaWRbMHgxOTAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxOTAxMDBdIGVuYWJs
ZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTcwMV0gYWRkcmVzc1sweDBdIE1QSURS
WzB4MTcwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDFmMDFdIGFk
ZHJlc3NbMHgwXSBNUElEUlsweDFmMDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFj
cGlfaWRbMHgwOTAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHg5MDEwMF0gZW5hYmxlZCkNCihYRU4p
IEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgyMTAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgyMTAxMDBd
IGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MGYwMV0gYWRkcmVzc1sweDBd
IE1QSURSWzB4ZjAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4Mjcw
MV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjcwMTAwXSBlbmFibGVkKQ0KKFhFTikgMzIgQ1BVcyBl
bmFibGVkLCAzMiBDUFVzIHRvdGFsDQooWEVOKSBTTVA6IEFsbG93aW5nIDMyIENQVXMNCihYRU4p
IEdlbmVyaWMgVGltZXIgSVJROiBwaHlzPTMwIGh5cD0yNiB2aXJ0PTI3IEZyZXE6IDI1MDAwIEtI
eg0KKFhFTikgR0lDdjMgaW5pdGlhbGl6YXRpb246DQooWEVOKSAgICAgICBnaWNfZGlzdF9hZGRy
PTB4MDAxMDAxMDAwMDAwMDANCihYRU4pICAgICAgIGdpY19tYWludGVuYW5jZV9pcnE9MjUNCihY
RU4pICAgICAgIGdpY19yZGlzdF9zdHJpZGU9MA0KKFhFTikgICAgICAgZ2ljX3JkaXN0X3JlZ2lv
bnM9MQ0KKFhFTikgICAgICAgcmVkaXN0cmlidXRvciByZWdpb25zOg0KKFhFTikgICAgICAgICAt
IHJlZ2lvbiAwOiAweDAwMTAwMTAwMTQwMDAwIC0gMHgwMDEwMDEwMTE0MDAwMA0KKFhFTikgR0lD
djM6IHVzaW5nIGF0IG1vc3QgNTczNDQgTFBJcyBvbiB0aGUgaG9zdC4NCihYRU4pIEdJQ3YzOiA3
MDQgbGluZXMsIChJSUQgMDIwMTc0M2IpLg0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBAMHgxMDAx
MDAwNDAwMDANCihYRU4pIEdJQ3YzOiBGb3VuZCBJVFMgQDB4MTAwMTAwMDYwMDAwDQooWEVOKSBH
SUN2MzogRm91bmQgSVRTIEAweDEwMDEwMDA4MDAwMA0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBA
MHgxMDAxMDAwYTAwMDANCihYRU4pIEdJQ3YzOiBGb3VuZCBJVFMgQDB4MTAwMTAwMGMwMDAwDQoo
WEVOKSBHSUN2MzogRm91bmQgSVRTIEAweDEwMDEwMDBlMDAwMA0KKFhFTikgR0lDdjM6IEZvdW5k
IElUUyBAMHgxMDAxMDAxMDAwMDANCihYRU4pIEdJQ3YzOiBGb3VuZCBJVFMgQDB4MTAwMTAwMTIw
MDAwDQooWEVOKSBHSUN2MzogQ1BVMDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBA
MDAwMDAwMDA0MDQzNDAwMA0KKFhFTikgWFNNIEZyYW1ld29yayB2MS4wLjEgaW5pdGlhbGl6ZWQN
CihYRU4pIEluaXRpYWxpc2luZyBYU00gU0lMTyBtb2RlDQooWEVOKSBVc2luZyBzY2hlZHVsZXI6
IFNNUCBDcmVkaXQgU2NoZWR1bGVyIHJldjIgKGNyZWRpdDIpDQooWEVOKSBJbml0aWFsaXppbmcg
Q3JlZGl0MiBzY2hlZHVsZXINCihYRU4pICBsb2FkX3ByZWNpc2lvbl9zaGlmdDogMTgNCihYRU4p
ICBsb2FkX3dpbmRvd19zaGlmdDogMzANCihYRU4pICB1bmRlcmxvYWRfYmFsYW5jZV90b2xlcmFu
Y2U6IDANCihYRU4pICBvdmVybG9hZF9iYWxhbmNlX3RvbGVyYW5jZTogLTMNCihYRU4pICBydW5x
dWV1ZXMgYXJyYW5nZW1lbnQ6IHNvY2tldA0KKFhFTikgIGNhcCBlbmZvcmNlbWVudCBncmFudWxh
cml0eTogMTBtcw0KKFhFTikgbG9hZCB0cmFja2luZyB3aW5kb3cgbGVuZ3RoIDEwNzM3NDE4MjQg
bnMNCihYRU4pIERlZmF1bHRpbmcgdG8gYWx0ZXJuYXRpdmUga2V5IGhhbmRsaW5nOyBzZW5kICdB
JyB0byBzd2l0Y2ggdG8gbm9ybWFsIG1vZGUuDQooWEVOKSBBbGxvY2F0ZWQgY29uc29sZSByaW5n
IG9mIDI1NiBLaUIuDQooWEVOKSBDUFUwOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE3IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIEJyaW5naW5nIHVwIENQVTENCihYRU4p
IEdJQ3YzOiBDUFUxOiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQw
NjM0MDAwDQooWEVOKSBDUFUxOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9y
ZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxIGJvb3RlZC4NCihYRU4pIEJyaW5naW5n
IHVwIENQVTINCihYRU4pIEdJQ3YzOiBDUFUyOiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lv
biAwIEAwMDAwMDAwMDQwNWI0MDAwDQooWEVOKSBDUFUyOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyIGJvb3RlZC4N
CihYRU4pIEJyaW5naW5nIHVwIENQVTMNCihYRU4pIEdJQ3YzOiBDUFUzOiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwN2I0MDAwDQooWEVOKSBDUFUzOiBHdWVzdCBh
dG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4p
IENQVSAzIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTQNCihYRU4pIEdJQ3YzOiBDUFU0
OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwMjM0MDAwDQooWEVO
KSBDUFU0OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRo
ZSBkb21haW4NCihYRU4pIENQVSA0IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTUNCihY
RU4pIEdJQ3YzOiBDUFU1OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAw
MDQwODM0MDAwDQooWEVOKSBDUFU1OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJl
Zm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA1IGJvb3RlZC4NCihYRU4pIEJyaW5n
aW5nIHVwIENQVTYNCihYRU4pIEdJQ3YzOiBDUFU2OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJl
Z2lvbiAwIEAwMDAwMDAwMDQwM2I0MDAwDQooWEVOKSBDUFU2OiBHdWVzdCBhdG9taWNzIHdpbGwg
dHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA2IGJvb3Rl
ZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTcNCihYRU4pIEdJQ3YzOiBDUFU3OiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwOWI0MDAwDQooWEVOKSBDUFU3OiBHdWVz
dCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihY
RU4pIENQVSA3IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTgNCihYRU4pIEdJQ3YzOiBD
UFU4OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNDc0MDAwDQoo
WEVOKSBDUFU4OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5n
IHRoZSBkb21haW4NCihYRU4pIENQVSA4IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTkN
CihYRU4pIEdJQ3YzOiBDUFU5OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAw
MDAwMDQwNjc0MDAwDQooWEVOKSBDUFU5OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE3IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA5IGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTEwDQooWEVOKSBHSUN2MzogQ1BVMTA6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA1ZjQwMDANCihYRU4pIENQVTEwOiBHdWVzdCBhdG9taWNz
IHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAx
MCBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFUxMQ0KKFhFTikgR0lDdjM6IENQVTExOiBG
b3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwN2Y0MDAwDQooWEVOKSBD
UFUxMTogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxNyB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUg
ZG9tYWluDQooWEVOKSBDUFUgMTEgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTINCihY
RU4pIEdJQ3YzOiBDUFUxMjogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAw
MDA0MDI3NDAwMA0KKFhFTikgQ1BVMTI6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMg
YmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDEyIGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTEzDQooWEVOKSBHSUN2MzogQ1BVMTM6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA4NzQwMDANCihYRU4pIENQVTEzOiBHdWVzdCBhdG9taWNz
IHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAx
MyBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFUxNA0KKFhFTikgR0lDdjM6IENQVTE0OiBG
b3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwM2Y0MDAwDQooWEVOKSBD
UFUxNDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUg
ZG9tYWluDQooWEVOKSBDUFUgMTQgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTUNCihY
RU4pIEdJQ3YzOiBDUFUxNTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAw
MDA0MDlmNDAwMA0KKFhFTikgQ1BVMTU6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTcgdGltZXMg
YmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDE1IGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTE2DQooWEVOKSBHSUN2MzogQ1BVMTY6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA0NTQwMDANCihYRU4pIENQVTE2OiBHdWVzdCBhdG9taWNz
IHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAx
NiBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFUxNw0KKFhFTikgR0lDdjM6IENQVTE3OiBG
b3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjU0MDAwDQooWEVOKSBD
UFUxNzogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUg
ZG9tYWluDQooWEVOKSBDUFUgMTcgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTgNCihY
RU4pIEdJQ3YzOiBDUFUxODogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAw
MDA0MDVkNDAwMA0KKFhFTikgQ1BVMTg6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMg
YmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDE4IGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTE5DQooWEVOKSBHSUN2MzogQ1BVMTk6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA3ZDQwMDANCihYRU4pIENQVTE5OiBHdWVzdCBhdG9taWNz
IHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAx
OSBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFUyMA0KKFhFTikgR0lDdjM6IENQVTIwOiBG
b3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwMjU0MDAwDQooWEVOKSBD
UFUyMDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUg
ZG9tYWluDQooWEVOKSBDUFUgMjAgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjENCihY
RU4pIEdJQ3YzOiBDUFUyMTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAw
MDA0MDg1NDAwMA0KKFhFTikgQ1BVMjE6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTcgdGltZXMg
YmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDIxIGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTIyDQooWEVOKSBHSUN2MzogQ1BVMjI6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDAzZDQwMDANCihYRU4pIENQVTIyOiBHdWVzdCBhdG9taWNz
IHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAy
MiBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFUyMw0KKFhFTikgR0lDdjM6IENQVTIzOiBG
b3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwOWQ0MDAwDQooWEVOKSBD
UFUyMzogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUg
ZG9tYWluDQooWEVOKSBDUFUgMjMgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjQNCihY
RU4pIEdJQ3YzOiBDUFUyNDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAw
MDA0MDQ5NDAwMA0KKFhFTikgQ1BVMjQ6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMg
YmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDI0IGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTI1DQooWEVOKSBHSUN2MzogQ1BVMjU6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA2OTQwMDANCihYRU4pIENQVTI1OiBHdWVzdCBhdG9taWNz
IHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAy
NSBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFUyNg0KKFhFTikgR0lDdjM6IENQVTI2OiBG
b3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjE0MDAwDQooWEVOKSBD
UFUyNjogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUg
ZG9tYWluDQooWEVOKSBDUFUgMjYgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjcNCihY
RU4pIEdJQ3YzOiBDUFUyNzogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAw
MDA0MDgxNDAwMA0KKFhFTikgQ1BVMjc6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMg
YmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDI3IGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTI4DQooWEVOKSBHSUN2MzogQ1BVMjg6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDAyOTQwMDANCihYRU4pIENQVTI4OiBHdWVzdCBhdG9taWNz
IHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAy
OCBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFUyOQ0KKFhFTikgR0lDdjM6IENQVTI5OiBG
b3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwODk0MDAwDQooWEVOKSBD
UFUyOTogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUg
ZG9tYWluDQooWEVOKSBDUFUgMjkgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMzANCihY
RU4pIEdJQ3YzOiBDUFUzMDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAw
MDA0MDQxNDAwMA0KKFhFTikgQ1BVMzA6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMg
YmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDMwIGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTMxDQooWEVOKSBHSUN2MzogQ1BVMzE6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDBhMTQwMDANCihYRU4pIENQVTMxOiBHdWVzdCBhdG9taWNz
IHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIEJyb3Vn
aHQgdXAgMzIgQ1BVcw0KKFhFTikgQ1BVIDMxIGJvb3RlZC4NCihYRU4pIEkvTyB2aXJ0dWFsaXNh
dGlvbiBkaXNhYmxlZA0KKFhFTikgUDJNOiA0OC1iaXQgSVBBIHdpdGggNDgtYml0IFBBIGFuZCAx
Ni1iaXQgVk1JRA0KKFhFTikgUDJNOiA0IGxldmVscyB3aXRoIG9yZGVyLTAgcm9vdCwgVlRDUiAw
eDAwMDAwMDAwODAwZDM1OTANCihYRU4pIFNjaGVkdWxpbmcgZ3JhbnVsYXJpdHk6IGNwdSwgMSBD
UFUgcGVyIHNjaGVkLXJlc291cmNlDQooWEVOKSBBZGRpbmcgY3B1IDAgdG8gcnVucXVldWUgMA0K
KFhFTikgIEZpcnN0IGNwdSBvbiBydW5xdWV1ZSwgYWN0aXZhdGluZw0KKFhFTikgQWRkaW5nIGNw
dSAxIHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMiB0byBydW5xdWV1ZSAwDQooWEVO
KSBBZGRpbmcgY3B1IDMgdG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSA0IHRvIHJ1bnF1
ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgNSB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1
IDYgdG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSA3IHRvIHJ1bnF1ZXVlIDANCihYRU4p
IEFkZGluZyBjcHUgOCB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDkgdG8gcnVucXVl
dWUgMA0KKFhFTikgQWRkaW5nIGNwdSAxMCB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1
IDExIHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMTIgdG8gcnVucXVldWUgMA0KKFhF
TikgQWRkaW5nIGNwdSAxMyB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDE0IHRvIHJ1
bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMTUgdG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5n
IGNwdSAxNiB0byBydW5xdWV1ZSAxDQooWEVOKSAgRmlyc3QgY3B1IG9uIHJ1bnF1ZXVlLCBhY3Rp
dmF0aW5nDQooWEVOKSBBZGRpbmcgY3B1IDE3IHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBj
cHUgMTggdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAxOSB0byBydW5xdWV1ZSAxDQoo
WEVOKSBBZGRpbmcgY3B1IDIwIHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjEgdG8g
cnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyMiB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRp
bmcgY3B1IDIzIHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjQgdG8gcnVucXVldWUg
MQ0KKFhFTikgQWRkaW5nIGNwdSAyNSB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDI2
IHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjcgdG8gcnVucXVldWUgMQ0KKFhFTikg
QWRkaW5nIGNwdSAyOCB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDI5IHRvIHJ1bnF1
ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMzAgdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNw
dSAzMSB0byBydW5xdWV1ZSAxDQooWEVOKSBhbHRlcm5hdGl2ZXM6IFBhdGNoaW5nIHdpdGggYWx0
IHRhYmxlIDAwMDAwMDAwMDAyZjBiMjAgLT4gMDAwMDAwMDAwMDJmMTQyMA0KKFhFTikgQ1BVMCB3
aWxsIHVzZSAyNCBsb29wcyB3b3JrYXJvdW5kIG9uIGV4Y2VwdGlvbiBlbnRyeQ0KKFhFTikgQ1BV
MTYgd2lsbCB1c2UgMjQgbG9vcHMgd29ya2Fyb3VuZCBvbiBleGNlcHRpb24gZW50cnkNCihYRU4p
IENQVTIyIHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9uIGVudHJ5DQoo
WEVOKSBDUFU4IHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9uIGVudHJ5
DQooWEVOKSBDUFU2IHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9uIGVu
dHJ5DQooWEVOKSBDUFUyNCB3aWxsIHVzZSAyNCBsb29wcyB3b3JrYXJvdW5kIG9uIGV4Y2VwdGlv
biBlbnRyeQ0KKFhFTikgQ1BVMiB3aWxsIHVzZSAyNCBsb29wcyB3b3JrYXJvdW5kIG9uIGV4Y2Vw
dGlvbiBlbnRyeQ0KKFhFTikgQ1BVMjMgd2lsbCB1c2UgMjQgbG9vcHMgd29ya2Fyb3VuZCBvbiBl
eGNlcHRpb24gZW50cnkNCihYRU4pIENQVTE4IHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91bmQg
b24gZXhjZXB0aW9uIGVudHJ5DQooWEVOKSBDUFU3IHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91
bmQgb24gZXhjZXB0aW9uIGVudHJ5DQooWEVOKSBDUFUxNCB3aWxsIHVzZSAyNCBsb29wcyB3b3Jr
YXJvdW5kIG9uIGV4Y2VwdGlvbiBlbnRyeQ0KKFhFTikgQ1BVMjEgd2lsbCB1c2UgMjQgbG9vcHMg
d29ya2Fyb3VuZCBvbiBleGNlcHRpb24gZW50cnkNCihYRU4pIENQVTMwIHdpbGwgdXNlIDI0IGxv
b3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9uIGVudHJ5DQooWEVOKSBDUFU1IHdpbGwgdXNlIDI0
IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9uIGVudHJ5DQooWEVOKSBDUFUxOSB3aWxsIHVz
ZSAyNCBsb29wcyB3b3JrYXJvdW5kIG9uIGV4Y2VwdGlvbiBlbnRyeQ0KKFhFTikgQ1BVMTMgd2ls
bCB1c2UgMjQgbG9vcHMgd29ya2Fyb3VuZCBvbiBleGNlcHRpb24gZW50cnkNCihYRU4pIENQVTMg
d2lsbCB1c2UgMjQgbG9vcHMgd29ya2Fyb3VuZCBvbiBleGNlcHRpb24gZW50cnkNCihYRU4pIENQ
VTI5IHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9uIGVudHJ5DQooWEVO
KSBDUFUyMCB3aWxsIHVzZSAyNCBsb29wcyB3b3JrYXJvdW5kIG9uIGV4Y2VwdGlvbiBlbnRyeQ0K
KFhFTikgQ1BVMTcgd2lsbCB1c2UgMjQgbG9vcHMgd29ya2Fyb3VuZCBvbiBleGNlcHRpb24gZW50
cnkNCihYRU4pIENQVTE1IHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9u
IGVudHJ5DQooWEVOKSBDUFUxIHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0
aW9uIGVudHJ5DQooWEVOKSBDUFUxMSB3aWxsIHVzZSAyNCBsb29wcyB3b3JrYXJvdW5kIG9uIGV4
Y2VwdGlvbiBlbnRyeQ0KKFhFTikgQ1BVMzEgd2lsbCB1c2UgMjQgbG9vcHMgd29ya2Fyb3VuZCBv
biBleGNlcHRpb24gZW50cnkNCihYRU4pIENQVTEyIHdpbGwgdXNlIDI0IGxvb3BzIHdvcmthcm91
bmQgb24gZXhjZXB0aW9uIGVudHJ5DQooWEVOKSBDUFUyNSB3aWxsIHVzZSAyNCBsb29wcyB3b3Jr
YXJvdW5kIG9uIGV4Y2VwdGlvbiBlbnRyeQ0KKFhFTikgQ1BVMjggd2lsbCB1c2UgMjQgbG9vcHMg
d29ya2Fyb3VuZCBvbiBleGNlcHRpb24gZW50cnkNCihYRU4pIENQVTkgd2lsbCB1c2UgMjQgbG9v
cHMgd29ya2Fyb3VuZCBvbiBleGNlcHRpb24gZW50cnkNCihYRU4pIENQVTEwIHdpbGwgdXNlIDI0
IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9uIGVudHJ5DQooWEVOKSBDUFU0IHdpbGwgdXNl
IDI0IGxvb3BzIHdvcmthcm91bmQgb24gZXhjZXB0aW9uIGVudHJ5DQooWEVOKSBDUFUyNiB3aWxs
IHVzZSAyNCBsb29wcyB3b3JrYXJvdW5kIG9uIGV4Y2VwdGlvbiBlbnRyeQ0KKFhFTikgQ1BVMjcg
d2lsbCB1c2UgMjQgbG9vcHMgd29ya2Fyb3VuZCBvbiBleGNlcHRpb24gZW50cnkNCihYRU4pICoq
KiBMT0FESU5HIERPTUFJTiAwICoqKg0KKFhFTikgTG9hZGluZyBkMCBrZXJuZWwgZnJvbSBib290
IG1vZHVsZSBAIDAwMDAwMDAwZmU0N2MwMDANCihYRU4pIEFsbG9jYXRpbmcgMToxIG1hcHBpbmdz
IHRvdGFsbGluZyAyNDU3Nk1CIGZvciBkb20wOg0KKFhFTikgQkFOS1swXSAweDAwMDAwMDk4MDAw
MDAwLTB4MDAwMDAwZjgwMDAwMDAgKDE1MzZNQikNCihYRU4pIEJBTktbMV0gMHgwMDA4MDAwMDAw
MDAwMC0weDAwMDgwMDgwMDAwMDAwICgyMDQ4TUIpDQooWEVOKSBCQU5LWzJdIDB4MDAwODAyODAw
MDAwMDAtMHgwMDA4MDdhMDAwMDAwMCAoMjA5OTJNQikNCihYRU4pIEdyYW50IHRhYmxlIHJhbmdl
OiAweDAwMDgwN2Y2ZDNmMDAwLTB4MDAwODA3ZjZkN2YwMDANCihYRU4pIEFsbG9jYXRpbmcgUFBJ
IDE2IGZvciBldmVudCBjaGFubmVsIGludGVycnVwdA0KKFhFTikgTG9hZGluZyB6SW1hZ2UgZnJv
bSAwMDAwMDAwMGZlNDdjMDAwIHRvIDAwMDAwMDAwOTgwMDAwMDAtMDAwMDAwMDA5OTZjMzIwMA0K
KFhFTikgTG9hZGluZyBkMCBEVEIgdG8gMHgwMDAwMDAwMGEwMDAwMDAwLTB4MDAwMDAwMDBhMDAw
MDI4Yg0KKFhFTikgSW5pdGlhbCBsb3cgbWVtb3J5IHZpcnEgdGhyZXNob2xkIHNldCBhdCAweDQw
MDAgcGFnZXMuDQooWEVOKSBTdGQuIExvZ2xldmVsOiBBbGwNCihYRU4pIEd1ZXN0IExvZ2xldmVs
OiBFcnJvcnMNCihYRU4pICoqKiBTZXJpYWwgaW5wdXQgdG8gRE9NMCAodHlwZSAnQ1RSTC1hJyB0
aHJlZSB0aW1lcyB0byBzd2l0Y2ggaW5wdXQpDQooWEVOKSBGcmVlZCA0MTJrQiBpbml0IG1lbW9y
eS4NCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZm
ZmZmIHRvIElDQUNUSVZFUjQNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0
ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjgNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhh
bmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjEyDQooWEVOKSBk
MHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FD
VElWRVIxNg0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAw
ZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMjANCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29y
ZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjI0DQooWEVOKSBkMHYwOiB2R0lD
RDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIyOA0K
KFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYg
dG8gSUNBQ1RJVkVSMzINCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAw
eDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjM2DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5k
bGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0MA0KKFhFTikgZDB2
MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJ
VkVSNDQNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZm
ZmZmZmZmIHRvIElDQUNUSVZFUjQ4DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQg
d3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI1Mg0KKFhFTikgZDB2MDogdkdJQ0Q6
IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNTYNCihY
RU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRv
IElDQUNUSVZFUjYwDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgw
MDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI2NA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxl
ZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNjgNCihYRU4pIGQwdjA6
IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZF
UjcyDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZm
ZmZmZiB0byBJQ0FDVElWRVI3Ng0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdy
aXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSODANCihYRU4pIGQwdjA6IHZHSUNEOiB1
bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjg0DQooWEVO
KSBkMHYwOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZm
IHRvIElDQUNUSVZFUjANClsgICAgMC4wMDAwMDBdIEJvb3RpbmcgTGludXggb24gcGh5c2ljYWwg
Q1BVIDB4MDAwMDAwMDAwMCBbMHg0MTNmZDBjMV0NClsgICAgMC4wMDAwMDBdIExpbnV4IHZlcnNp
b24gNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAob2UtdXNlckBvZS1ob3N0KSAoYWFyY2g2
NC1wb2t5LWxpbnV4LWdjYyAoR0NDKSAxMS4yLjAsIEdOVSBsZCAoR05VIEJpbnV0aWxzKSAyLjM3
LjIwMjEwNzIxKSAjMSBTTVAgUFJFRU1QVCBTYXQgU2VwIDE4IDA2OjAxOjU5IFVUQyAyMDIxDQpb
ICAgIDAuMDAwMDAwXSBYZW4gWEVOX1ZFUlNJT04uWEVOX1NVQlZFUlNJT04gc3VwcG9ydCBmb3Vu
ZA0KWyAgICAwLjAwMDAwMF0gZWZpOiBFRkkgdjIuNTAgYnkgWGVuDQpbICAgIDAuMDAwMDAwXSBl
Zmk6IEFDUEkgMi4wPTB4ODA3ZjZkM2ZjZTggDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBFYXJseSB0
YWJsZSBjaGVja3N1bSB2ZXJpZmljYXRpb24gZGlzYWJsZWQNClsgICAgMC4wMDAwMDBdIEFDUEk6
IFJTRFAgMHgwMDAwMDgwN0Y2RDNGQ0U4IDAwMDAyNCAodjAyIEFtcGVyZSkNClsgICAgMC4wMDAw
MDBdIEFDUEk6IFhTRFQgMHgwMDAwMDgwN0Y2RDNGQzM4IDAwMDBBQyAodjAxIEFtcGVyZSBBbHRy
YSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogRkFDUCAw
eDAwMDAwODA3RjZEM0YwMDAgMDAwMTE0ICh2MDYgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFN
UC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBEU0RUIDB4MDAwMDA4MDdGOERCMDAx
OCAwMkMxOUUgKHYwMiBBbXBlcmUgSmFkZSAgICAgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNykNClsg
ICAgMC4wMDAwMDBdIEFDUEk6IEJFUlQgMHgwMDAwMDgwN0ZBMERGRjk4IDAwMDAzMCAodjAxIEFt
cGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQ
STogREJHMiAweDAwMDAwODA3RkEwREZBOTggMDAwMDVDICh2MDAgQW1wZXJlIEFsdHJhICAgIDAw
MDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBHVERUIDB4MDAwMDA4
MDdGQTBERTk5OCAwMDAxMTAgKHYwMyBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAw
MDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1IgMHgwMDAwMDgwN0ZBMERGRTE4IDAwMDA1
MCAodjAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAw
MDAwMF0gQUNQSTogRUlOSiAweDAwMDAwODA3RkEwREY1OTggMDAwMTUwICh2MDEgQW1wZXJlIEFs
dHJhICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBIRVNU
IDB4MDAwMDA4MDdGQTBERUIxOCAwMDAxRjQgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDEg
SU5UTCAyMDIwMTIxNykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFNTRFQgMHgwMDAwMDgwN0ZBMERG
QTE4IDAwMDAyRCAodjAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAxMjE3KQ0K
WyAgICAwLjAwMDAwMF0gQUNQSTogVFBNMiAweDAwMDAwODA3RkEwREZEMTggMDAwMDRDICh2MDQg
QW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBB
Q1BJOiBNQ0ZHIDB4MDAwMDA4MDdGQTBERjcxOCAwMDAwN0MgKHYwMSBBbXBlcmUgQWx0cmEgICAg
MDAwMDAwMDEgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IElPUlQgMHgwMDAw
MDgwN0ZBMERFRjE4IDAwMDNEQyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAx
MDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogQVBJQyAweDAwMDAwODA3RjZEM0YxMTggMDAw
QUY0ICh2MDUgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBQUFRUIDB4MDAwMDA4MDdGQTBEODYxOCAwMDQ1MjAgKHYwMiBBbXBlcmUg
QWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFNM
SVQgMHgwMDAwMDgwN0ZBMERGRDk4IDAwMDAyRCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAw
MiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVCAweDAwMDAwODA3RkEw
RENFMTggMDAwMzcwICh2MDMgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMp
DQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBQQ0NUIDB4MDAwMDA4MDdGQTBERTMxOCAwMDA1NzYgKHYw
MiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBd
IEFDUEk6IFNUQU8gMHgwMDAwMDgwN0Y2RDNGQzEwIDAwMDAyNSAodjAxIEFtcGVyZSBBbHRyYSAg
ICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1BDUjogY29u
c29sZTogcGwwMTEsbW1pbzMyLDB4MTAwMDAyNjAwMDAwLDExNTIwMA0KWyAgICAwLjAwMDAwMF0g
QUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4ODMwMDAwMC0weDg4M2ZmZmZmXQ0KWyAg
ICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg5MDAwMDAwMC0weGZm
ZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4
MDAwMDAwMDAwMC0weDgwMDdmZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9k
ZSAwIFBYTSAwIFttZW0gMHg4MDEwMDAwMDAwMC0weDgwN2ZmZmZmZmZmXQ0KWyAgICAwLjAwMDAw
MF0gTlVNQTogTk9ERV9EQVRBIFttZW0gMHg4MDc5Y2ZkZWUwMC0weDgwNzljZmUwZmZmXQ0KWyAg
ICAwLjAwMDAwMF0gWm9uZSByYW5nZXM6DQpbICAgIDAuMDAwMDAwXSAgIERNQSAgICAgIFttZW0g
MHgwMDAwMDAwMDk4MDAwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0NClsgICAgMC4wMDAwMDBdICAg
RE1BMzIgICAgZW1wdHkNClsgICAgMC4wMDAwMDBdICAgTm9ybWFsICAgW21lbSAweDAwMDAwMDAx
MDAwMDAwMDAtMHgwMDAwMDgwN2ZhMGRmZmZmXQ0KWyAgICAwLjAwMDAwMF0gTW92YWJsZSB6b25l
IHN0YXJ0IGZvciBlYWNoIG5vZGUNClsgICAgMC4wMDAwMDBdIEVhcmx5IG1lbW9yeSBub2RlIHJh
bmdlcw0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwOTgwMDAwMDAt
MHgwMDAwMDAwMGY3ZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAw
MDAwODAwMDAwMDAwMDAtMHgwMDAwMDgwMDdmZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2Rl
ICAgMDogW21lbSAweDAwMDAwODAyODAwMDAwMDAtMHgwMDAwMDgwNzlmZmZmZmZmXQ0KWyAgICAw
LjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjZkM2YwMDAtMHgwMDAwMDgwN2Y2
ZDNmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjhkYjAw
MDAtMHgwMDAwMDgwN2Y4ZGRmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAw
eDAwMDAwODA3ZmEwZDAwMDAtMHgwMDAwMDgwN2ZhMGRmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSW5p
dG1lbSBzZXR1cCBub2RlIDAgW21lbSAweDAwMDAwMDAwOTgwMDAwMDAtMHgwMDAwMDgwN2ZhMGRm
ZmZmXQ0KWyAgICAwLjAwMDAwMF0gcHNjaTogcHJvYmluZyBmb3IgY29uZHVpdCBtZXRob2QgZnJv
bSBBQ1BJLg0KWyAgICAwLjAwMDAwMF0gcHNjaTogUFNDSXYxLjEgZGV0ZWN0ZWQgaW4gZmlybXdh
cmUuDQpbICAgIDAuMDAwMDAwXSBwc2NpOiBVc2luZyBzdGFuZGFyZCBQU0NJIHYwLjIgZnVuY3Rp
b24gSURzDQpbICAgIDAuMDAwMDAwXSBwc2NpOiBUcnVzdGVkIE9TIG1pZ3JhdGlvbiBub3QgcmVx
dWlyZWQNClsgICAgMC4wMDAwMDBdIHBzY2k6IFNNQyBDYWxsaW5nIENvbnZlbnRpb24gdjEuMQ0K
WyAgICAwLjAwMDAwMF0gcGVyY3B1OiBFbWJlZGRlZCAzMSBwYWdlcy9jcHUgczg5MjQwIHI4MTky
IGQyOTU0NCB1MTI2OTc2DQpbICAgIDAuMDAwMDAwXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24g
Q1BVMA0KWyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogR0lDIHN5c3RlbSBy
ZWdpc3RlciBDUFUgaW50ZXJmYWNlDQpbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVj
dGVkOiBIYXJkd2FyZSBkaXJ0eSBiaXQgbWFuYWdlbWVudA0KWyAgICAwLjAwMDAwMF0gQ1BVIGZl
YXR1cmVzOiBkZXRlY3RlZDogU3BlY3RyZS12NA0KWyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVz
OiBkZXRlY3RlZDogQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAwLjAwMDAwMF0gQnVpbHQgMSB6
b25lbGlzdHMsIG1vYmlsaXR5IGdyb3VwaW5nIG9uLiAgVG90YWwgcGFnZXM6IDYxOTMyMTUNClsg
ICAgMC4wMDAwMDBdIFBvbGljeSB6b25lOiBOb3JtYWwNClsgICAgMC4wMDAwMDBdIEtlcm5lbCBj
b21tYW5kIGxpbmU6IHN3aW90bGI9NjU1MzYgY29uc29sZT1odmMwIGVhcmx5Y29uPXhlbiByb290
d2FpdCByb290PVBBUlRVVUlEPTZhNjA1MjRkLTA2MWQtNDU0YS1iZmQxLTM4OTg5OTEwZWNjZA0K
WyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbiBpbmRpdmlkdWFsIG1heCBjcHUgY29u
dHJpYnV0aW9uOiA0MDk2IGJ5dGVzDQpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVu
IHRvdGFsIGNwdV9leHRyYSBjb250cmlidXRpb25zOiAxMjY5NzYgYnl0ZXMNClsgICAgMC4wMDAw
MDBdIHByaW50azogbG9nX2J1Zl9sZW4gbWluIHNpemU6IDEzMTA3MiBieXRlcw0KWyAgICAwLjAw
MDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbjogMjYyMTQ0IGJ5dGVzDQpbICAgIDAuMDAwMDAwXSBw
cmludGs6IGVhcmx5IGxvZyBidWYgZnJlZTogMTI1OTI4KDk2JSkNClsgICAgMC4wMDAwMDBdIERl
bnRyeSBjYWNoZSBoYXNoIHRhYmxlIGVudHJpZXM6IDQxOTQzMDQgKG9yZGVyOiAxMywgMzM1NTQ0
MzIgYnl0ZXMsIGxpbmVhcikNClsgICAgMC4wMDAwMDBdIElub2RlLWNhY2hlIGhhc2ggdGFibGUg
ZW50cmllczogMjA5NzE1MiAob3JkZXI6IDEyLCAxNjc3NzIxNiBieXRlcywgbGluZWFyKQ0KWyAg
ICAwLjAwMDAwMF0gbWVtIGF1dG8taW5pdDogc3RhY2s6b2ZmLCBoZWFwIGFsbG9jOm9mZiwgaGVh
cCBmcmVlOm9mZg0KWyAgICAwLjAwMDAwMF0gc29mdHdhcmUgSU8gVExCOiBtYXBwZWQgW21lbSAw
eDAwMDAwMDAwZjAwMDAwMDAtMHgwMDAwMDAwMGY4MDAwMDAwXSAoMTI4TUIpDQpbICAgIDAuMDAw
MDAwXSBNZW1vcnk6IDI0NDgwMjE2Sy8yNTE2NjA4NEsgYXZhaWxhYmxlICgxMzU2OEsga2VybmVs
IGNvZGUsIDE5OTZLIHJ3ZGF0YSwgMzQ3Nksgcm9kYXRhLCA0MTYwSyBpbml0LCA4MjJLIGJzcywg
Njg1ODY4SyByZXNlcnZlZCwgMEsgY21hLXJlc2VydmVkKQ0KWyAgICAwLjAwMDAwMF0gU0xVQjog
SFdhbGlnbj02NCwgT3JkZXI9MC0zLCBNaW5PYmplY3RzPTAsIENQVXM9MzIsIE5vZGVzPTENClsg
ICAgMC4wMDAwMDBdIGZ0cmFjZTogYWxsb2NhdGluZyA0MTMwNiBlbnRyaWVzIGluIDE2MiBwYWdl
cw0KWyAgICAwLjAwMDAwMF0gZnRyYWNlOiBhbGxvY2F0ZWQgMTYyIHBhZ2VzIHdpdGggMyBncm91
cHMNClsgICAgMC4wMDAwMDBdIHJjdTogUHJlZW1wdGlibGUgaGllcmFyY2hpY2FsIFJDVSBpbXBs
ZW1lbnRhdGlvbi4NClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSBldmVudCB0cmFjaW5nIGlzIGVu
YWJsZWQuDQpbICAgIDAuMDAwMDAwXSByY3U6IAlSQ1UgcmVzdHJpY3RpbmcgQ1BVcyBmcm9tIE5S
X0NQVVM9MjU2IHRvIG5yX2NwdV9pZHM9MzIuDQpbICAgIDAuMDAwMDAwXSAJVHJhbXBvbGluZSB2
YXJpYW50IG9mIFRhc2tzIFJDVSBlbmFibGVkLg0KWyAgICAwLjAwMDAwMF0gCVJ1ZGUgdmFyaWFu
dCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4NClsgICAgMC4wMDAwMDBdIAlUcmFjaW5nIHZhcmlhbnQg
b2YgVGFza3MgUkNVIGVuYWJsZWQuDQpbICAgIDAuMDAwMDAwXSByY3U6IFJDVSBjYWxjdWxhdGVk
IHZhbHVlIG9mIHNjaGVkdWxlci1lbmxpc3RtZW50IGRlbGF5IGlzIDI1IGppZmZpZXMuDQpbICAg
IDAuMDAwMDAwXSByY3U6IEFkanVzdGluZyBnZW9tZXRyeSBmb3IgcmN1X2Zhbm91dF9sZWFmPTE2
LCBucl9jcHVfaWRzPTMyDQpbICAgIDAuMDAwMDAwXSBOUl9JUlFTOiA2NCwgbnJfaXJxczogNjQs
IHByZWFsbG9jYXRlZCBpcnFzOiAwDQpbICAgIDAuMDAwMDAwXSBHSUN2MzogNjcyIFNQSXMgaW1w
bGVtZW50ZWQNClsgICAgMC4wMDAwMDBdIEdJQ3YzOiAwIEV4dGVuZGVkIFNQSXMgaW1wbGVtZW50
ZWQNClsgICAgMC4wMDAwMDBdIEdJQ3YzOiBEaXN0cmlidXRvciBoYXMgbm8gUmFuZ2UgU2VsZWN0
b3Igc3VwcG9ydA0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IDE2IFBQSXMgaW1wbGVtZW50ZWQNClsg
ICAgMC4wMDAwMDBdIEdJQ3YzOiBDUFUwOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDAgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwMTQwMDAwDQpbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMCAt
PiBOb2RlIDANClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyAxIC0+IE5vZGUgMA0K
WyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDIgLT4gTm9kZSAwDQpbICAgIDAuMDAw
MDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMyAtPiBOb2RlIDANClsgICAgMC4wMDAwMDBdIFNSQVQ6
IFBYTSAwIC0+IElUUyA0IC0+IE5vZGUgMA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4g
SVRTIDUgLT4gTm9kZSAwDQpbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNiAtPiBO
b2RlIDANClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA3IC0+IE5vZGUgMA0KWyAg
ICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwNDAwMDAtMHgxMDAxMDAwNWZmZmZdDQpbICAg
IDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDQwMDAwOiBEZXZpY2VzIFRhYmxlIHRvbyBsYXJn
ZSwgcmVkdWNlIGlkcyAyMC0+MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwNDAw
MDA6IGFsbG9jYXRlZCA1MjQyODggRGV2aWNlcyBAODAwMDA4MDAwMDAgKGZsYXQsIGVzeiA4LCBw
c3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwNDAwMDA6IGFs
bG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMjIwMDAwIChmbGF0LCBl
c3ogMiwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDA2
MDAwMC0weDEwMDEwMDA3ZmZmZl0NClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwNjAw
MDA6IERldmljZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRzIDIwLT4xOQ0KWyAgICAwLjAw
MDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA2MDAwMDogYWxsb2NhdGVkIDUyNDI4OCBEZXZpY2VzIEA4
MDAwMGMwMDAwMCAoZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0g
SVRTQDB4MDAwMDEwMDEwMDA2MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0
aW9ucyBAODAwMDAyNDAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4w
MDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMDgwMDAwLTB4MTAwMTAwMDlmZmZmXQ0KWyAgICAwLjAw
MDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA4MDAwMDogRGV2aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJl
ZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDgwMDAwOiBh
bGxvY2F0ZWQgNTI0Mjg4IERldmljZXMgQDgwMDAxMDAwMDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0
Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDgwMDAwOiBhbGxvY2F0
ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDI2MDAwMCAoZmxhdCwgZXN6IDIs
IHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwYTAwMDAt
MHgxMDAxMDAwYmZmZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGEwMDAwOiBE
ZXZpY2VzIFRhYmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAyMC0+MTkNClsgICAgMC4wMDAwMDBd
IElUU0AweDAwMDAxMDAxMDAwYTAwMDA6IGFsbG9jYXRlZCA1MjQyODggRGV2aWNlcyBAODAwMDE0
MDAwMDAgKGZsYXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUU0Aw
eDAwMDAxMDAxMDAwYTAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMg
QDgwMDAwMjgwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAw
XSBJVFMgW21lbSAweDEwMDEwMDBjMDAwMC0weDEwMDEwMDBkZmZmZl0NClsgICAgMC4wMDAwMDBd
IElUU0AweDAwMDAxMDAxMDAwYzAwMDA6IERldmljZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1Y2Ug
aWRzIDIwLT4xOQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBjMDAwMDogYWxsb2Nh
dGVkIDUyNDI4OCBEZXZpY2VzIEA4MDAwMTgwMDAwMCAoZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNo
ciAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBjMDAwMDogYWxsb2NhdGVkIDMy
NzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAyYTAwMDAgKGZsYXQsIGVzeiAyLCBwc3og
NjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMGUwMDAwLTB4MTAw
MTAwMGZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBlMDAwMDogRGV2aWNl
cyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNA
MHgwMDAwMTAwMTAwMGUwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMgQDgwMDAxYzAwMDAw
IChmbGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAw
MTAwMTAwMGUwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAw
MDJjMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRT
IFttZW0gMHgxMDAxMDAxMDAwMDAtMHgxMDAxMDAxMWZmZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNA
MHgwMDAwMTAwMTAwMTAwMDAwOiBEZXZpY2VzIFRhYmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAy
MC0+MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMDAwMDA6IGFsbG9jYXRlZCA1
MjQyODggRGV2aWNlcyBAODAwMDIwMDAwMDAgKGZsYXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkN
ClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMDAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJ
bnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMmUwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywg
c2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDEyMDAwMC0weDEwMDEwMDEz
ZmZmZl0NClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMjAwMDA6IERldmljZXMgVGFi
bGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRzIDIwLT4xOQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAw
MDEwMDEwMDEyMDAwMDogYWxsb2NhdGVkIDUyNDI4OCBEZXZpY2VzIEA4MDAwMjQwMDAwMCAoZmxh
dCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEw
MDEyMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAzMDAw
MDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIC0tLS0tLS0t
LS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAwLjAwMDAwMF0gV0FSTklORzogQ1BV
OiAwIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzoyMjQ3IGl0c19p
bml0KzB4Mzk4LzB4NjkwDQpbICAgIDAuMDAwMDAwXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAg
MC4wMDAwMDBdIENQVTogMCBQSUQ6IDAgQ29tbTogc3dhcHBlci8wIE5vdCB0YWludGVkIDUuMTAu
MjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMC4wMDAwMDBdIHBzdGF0ZTogNjAwMDAw
ODUgKG5aQ3YgZGFJZiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMC4wMDAwMDBdIHBj
IDogaXRzX2luaXQrMHgzOTgvMHg2OTANClsgICAgMC4wMDAwMDBdIGxyIDogaXRzX2luaXQrMHgz
OTQvMHg2OTANClsgICAgMC4wMDAwMDBdIHNwIDogZmZmZjgwMDAxMTRkM2M1MA0KWyAgICAwLjAw
MDAwMF0geDI5OiBmZmZmODAwMDExNGQzYzUwIHgyODogMDAwMDAwMDAwMDAwMDAwMCANClsgICAg
MC4wMDAwMDBdIHgyNzogZmZmZjgwMDAxMTRkYzljMCB4MjY6IGZmZmYwN2ZmODAxZTU1MDAgDQpb
ICAgIDAuMDAwMDAwXSB4MjU6IDAwMDAwMDAwMDAwMDAwMDAgeDI0OiBmZmZmMDgwNzFjYzBhMGMw
IA0KWyAgICAwLjAwMDAwMF0geDIzOiBmZmZmODAwMDExNjIyMzUwIHgyMjogZmZmZjA3ZmY4MDEx
YjYwMCANClsgICAgMC4wMDAwMDBdIHgyMTogZmZmZjgwMDAxMTRkYzljMCB4MjA6IGZmZmY4MDAw
MTE2MjIwMDAgDQpbICAgIDAuMDAwMDAwXSB4MTk6IGZmZmY4MDAwMTE3Njg5ZjggeDE4OiBmZmZm
ZmZmZmZmZmZmZmZmIA0KWyAgICAwLjAwMDAwMF0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjog
MDAwMDAwMDAwMDAwMDAxZiANClsgICAgMC4wMDAwMDBdIHgxNTogZmZmZjA3ZmY4MDIwNDcxZCB4
MTQ6IDAwMDAwMDAwMDAwMDAwNTggDQpbICAgIDAuMDAwMDAwXSB4MTM6IDAwMDAwMDAwMDAwMDAw
YzAgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDExOiAwMDAwMDAwMDAw
MDAwMDEwIHgxMDogZmZmZjA4MDcxY2FkMjAwMCANClsgICAgMC4wMDAwMDBdIHg5IDogZmZmZjgw
MDAxMGQzNWM5MCB4OCA6IGZmZmYwN2ZmODAzMjAwMDAgDQpbICAgIDAuMDAwMDAwXSB4NyA6IGEy
YTJhMmEyYTJhMmEyYTIgeDYgOiBmZmZmMDAwMDAwMDAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDUg
OiBmZmZmZmRmZmZmZTAwMDAwIHg0IDogZmZmZjgwMDAxMTRkYzljMCANClsgICAgMC4wMDAwMDBd
IHgzIDogZmZmZjgwMDAxMTRkZGFmMCB4MiA6IDAwMDAwMDAwMDAwMDAwM2QgDQpbICAgIDAuMDAw
MDAwXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAw
LjAwMDAwMF0gQ2FsbCB0cmFjZToNClsgICAgMC4wMDAwMDBdICBpdHNfaW5pdCsweDM5OC8weDY5
MA0KWyAgICAwLjAwMDAwMF0gIGdpY19pbml0X2Jhc2VzKzB4NTI0LzB4NTg0DQpbICAgIDAuMDAw
MDAwXSAgZ2ljX2FjcGlfaW5pdCsweDEzNC8weDI3OA0KWyAgICAwLjAwMDAwMF0gIGFjcGlfbWF0
Y2hfbWFkdCsweDUwLzB4ODgNClsgICAgMC4wMDAwMDBdICBhY3BpX3RhYmxlX3BhcnNlX2VudHJp
ZXNfYXJyYXkrMHgxNjQvMHgyNGMNClsgICAgMC4wMDAwMDBdICBhY3BpX3RhYmxlX3BhcnNlX2Vu
dHJpZXMrMHg0OC8weDcwDQpbICAgIDAuMDAwMDAwXSAgYWNwaV90YWJsZV9wYXJzZV9tYWR0KzB4
MzQvMHg0MA0KWyAgICAwLjAwMDAwMF0gIF9fYWNwaV9wcm9iZV9kZXZpY2VfdGFibGUrMHg5MC8w
eGVjDQpbICAgIDAuMDAwMDAwXSAgaXJxY2hpcF9pbml0KzB4NDAvMHg0Yw0KWyAgICAwLjAwMDAw
MF0gIGluaXRfSVJRKzB4ZDAvMHgxMDQNClsgICAgMC4wMDAwMDBdICBzdGFydF9rZXJuZWwrMHgz
NTQvMHg1NTQNClsgICAgMC4wMDAwMDBdIHJhbmRvbTogZ2V0X3JhbmRvbV9ieXRlcyBjYWxsZWQg
ZnJvbSBfX3dhcm4rMHgxMjgvMHgxYzAgd2l0aCBjcm5nX2luaXQ9MA0KWyAgICAwLjAwMDAwMF0g
LS0tWyBlbmQgdHJhY2UgMDAwMDAwMDAwMDAwMDAwMCBdLS0tDQpbICAgIDAuMDAwMDAwXSBHSUN2
MzogdXNpbmcgTFBJIHByb3BlcnR5IHRhYmxlIEAweDAwMDAwODAwMDAzMTAwMDANClsgICAgMC4w
MDAwMDBdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAwLjAwMDAw
MF0gV0FSTklORzogQ1BVOiAwIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1p
dHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAwLjAwMDAwMF0gTW9kdWxl
cyBsaW5rZWQgaW46DQpbICAgIDAuMDAwMDAwXSBDUFU6IDAgUElEOiAwIENvbW06IHN3YXBwZXIv
MCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJk
KyAjMQ0KWyAgICAwLjAwMDAwMF0gcHN0YXRlOiA2MDAwMDA4NSAoblpDdiBkYUlmIC1QQU4gLVVB
TyAtVENPIEJUWVBFPS0tKQ0KWyAgICAwLjAwMDAwMF0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMC4wMDAwMDBdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAg
IDAuMDAwMDAwXSBzcCA6IGZmZmY4MDAwMTE0ZDNjODANClsgICAgMC4wMDAwMDBdIHgyOTogZmZm
ZjgwMDAxMTRkM2M4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4Mjc6
IDAwMDAwMDAwMDAwMDAwMDEgeDI2OiBmZmZmODAwMDEyMDAwMDcwIA0KWyAgICAwLjAwMDAwMF0g
eDI1OiBmZmZmZmUxZmZkZTBjODAwIHgyNDogZmZmZjgwMDAxMjAwMDAwMCANClsgICAgMC4wMDAw
MDBdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDAu
MDAwMDAwXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAg
ICAwLjAwMDAwMF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiAN
ClsgICAgMC4wMDAwMDBdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAw
MWYgDQpbICAgIDAuMDAwMDAwXSB4MTU6IGZmZmY4MDAwOTE0ZDM5NjcgeDE0OiAwMDAwMDAwMDAw
MDAwMDU4IA0KWyAgICAwLjAwMDAwMF0geDEzOiAwMDAwMDAwMDAwMDAwMGMwIHgxMjogMDAwMDAw
MDAwMDAwMDAwMCANClsgICAgMC4wMDAwMDBdIHgxMTogMDAwMDAwMDAwMDAwMDAxMCB4MTA6IDAw
MDAwMDAwMDAwMDAwMGMgDQpbICAgIDAuMDAwMDAwXSB4OSA6IGZmZmY4MDAwMTBkMzVjOTAgeDgg
OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDcgOiBmZmZmMDgwNzFjZmRmYmMw
IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMC4wMDAwMDBdIHg1IDogMDAwMDAwMDAwMDAw
MDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4MyA6IDAwMDAwMDAw
MDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAwLjAwMDAwMF0geDEgOiAwMDAw
MDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMC4wMDAwMDBdIENhbGwg
dHJhY2U6DQpbICAgIDAuMDAwMDAwXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDAu
MDAwMDAwXSAgZ2ljX2luaXRfYmFzZXMrMHg1MjgvMHg1ODQNClsgICAgMC4wMDAwMDBdICBnaWNf
YWNwaV9pbml0KzB4MTM0LzB4Mjc4DQpbICAgIDAuMDAwMDAwXSAgYWNwaV9tYXRjaF9tYWR0KzB4
NTAvMHg4OA0KWyAgICAwLjAwMDAwMF0gIGFjcGlfdGFibGVfcGFyc2VfZW50cmllc19hcnJheSsw
eDE2NC8weDI0Yw0KWyAgICAwLjAwMDAwMF0gIGFjcGlfdGFibGVfcGFyc2VfZW50cmllcysweDQ4
LzB4NzANClsgICAgMC4wMDAwMDBdICBhY3BpX3RhYmxlX3BhcnNlX21hZHQrMHgzNC8weDQwDQpb
ICAgIDAuMDAwMDAwXSAgX19hY3BpX3Byb2JlX2RldmljZV90YWJsZSsweDkwLzB4ZWMNClsgICAg
MC4wMDAwMDBdICBpcnFjaGlwX2luaXQrMHg0MC8weDRjDQpbICAgIDAuMDAwMDAwXSAgaW5pdF9J
UlErMHhkMC8weDEwNA0KWyAgICAwLjAwMDAwMF0gIHN0YXJ0X2tlcm5lbCsweDM1NC8weDU1NA0K
WyAgICAwLjAwMDAwMF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I1MiBdLS0tDQpbICAg
IDAuMDAwMDAwXSBHSUN2MzogQ1BVMDogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDAzMjAwMDANClsgICAgMC4wMDAwMDBdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMC4wMDAwMDBd
IEFDUEkgR1REVDogZm91bmQgMSBtZW1vcnktbWFwcGVkIHRpbWVyIGJsb2NrKHMpLg0KWyAgICAw
LjAwMDAwMF0gYXJjaF90aW1lcjogY3AxNSBhbmQgbW1pbyB0aW1lcihzKSBydW5uaW5nIGF0IDI1
LjAwTUh6ICh2aXJ0L3BoeXMpLg0KWyAgICAwLjAwMDAwMF0gY2xvY2tzb3VyY2U6IGFyY2hfc3lz
X2NvdW50ZXI6IG1hc2s6IDB4ZmZmZmZmZmZmZmZmZmYgbWF4X2N5Y2xlczogMHg1YzQwOTM5YjUs
IG1heF9pZGxlX25zOiA0NDA3OTUyMDI2NDYgbnMNClsgICAgMC4wMDAwMDFdIHNjaGVkX2Nsb2Nr
OiA1NiBiaXRzIGF0IDI1TUh6LCByZXNvbHV0aW9uIDQwbnMsIHdyYXBzIGV2ZXJ5IDQzOTgwNDY1
MTExMDBucw0KWyAgICAwLjAwMDA1NV0gQ29uc29sZTogY29sb3VyIGR1bW15IGRldmljZSA4MHgy
NQ0KWyAgICAxLjI3MzQ5OV0gcHJpbnRrOiBjb25zb2xlIFtodmMwXSBlbmFibGVkDQpbICAgIDEu
Mjc3Njg2XSBBQ1BJOiBDb3JlIHJldmlzaW9uIDIwMjAwOTI1DQpbICAgIDEuMjgxOTk2XSBBQ1BJ
IEJJT1MgV2FybmluZyAoYnVnKTogSW5jb3JyZWN0IGNoZWNrc3VtIGluIHRhYmxlIFtJT1JUXSAt
IDB4RjIsIHNob3VsZCBiZSAweDBCICgyMDIwMDkyNS90YnByaW50LTE3MykNClsgICAgMS4yOTI1
ODBdIENhbGlicmF0aW5nIGRlbGF5IGxvb3AgKHNraXBwZWQpLCB2YWx1ZSBjYWxjdWxhdGVkIHVz
aW5nIHRpbWVyIGZyZXF1ZW5jeS4uIDUwLjAwIEJvZ29NSVBTIChscGo9MTAwMDAwKQ0KWyAgICAx
LjMwMjkyMF0gcGlkX21heDogZGVmYXVsdDogMzI3NjggbWluaW11bTogMzAxDQpbICAgIDEuMzA3
NjM0XSBMU006IFNlY3VyaXR5IEZyYW1ld29yayBpbml0aWFsaXppbmcNClsgICAgMS4zMTI0MThd
IE1vdW50LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA3LCA1MjQyODgg
Ynl0ZXMsIGxpbmVhcikNClsgICAgMS4zMjAwMTRdIE1vdW50cG9pbnQtY2FjaGUgaGFzaCB0YWJs
ZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQ0KWyAgICAx
LjMyODM1MF0gQUNQSSBQUFRUOiBQUFRUIHRhYmxlIGZvdW5kLCBidXQgdW5hYmxlIHRvIGxvY2F0
ZSBjb3JlIDIgKDIpDQpbICAgIDEuMzM1MzU3XSB4ZW46Z3JhbnRfdGFibGU6IEdyYW50IHRhYmxl
cyB1c2luZyB2ZXJzaW9uIDEgbGF5b3V0DQpbICAgIDEuMzQxMjc4XSBHcmFudCB0YWJsZSBpbml0
aWFsaXplZA0KWyAgICAxLjM0NDg0Nl0geGVuOmV2ZW50czogVXNpbmcgRklGTy1iYXNlZCBBQkkN
ClsgICAgMS4zNDkxNzRdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTANClsgICAgMS4zNTI2NjVdIHJj
dTogSGllcmFyY2hpY2FsIFNSQ1UgaW1wbGVtZW50YXRpb24uDQpbICAgIDEuMzU3NjM2XSBQbGF0
Zm9ybSBNU0k6IElUU0AweDEwMDEwMDA0MDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjM2MzE0
NF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwNjAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAg
MS4zNjg4MDddIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAwMDgwMDAwIGRvbWFpbiBjcmVhdGVk
DQpbICAgIDEuMzc0NDMzXSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDBhMDAwMCBkb21haW4g
Y3JlYXRlZA0KWyAgICAxLjM4MDA2NV0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwYzAwMDAg
ZG9tYWluIGNyZWF0ZWQNClsgICAgMS4zODU3MDZdIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAw
MGUwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzkxMzQ4XSBQbGF0Zm9ybSBNU0k6IElUU0Aw
eDEwMDEwMDEwMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjM5Njk5MF0gUGxhdGZvcm0gTVNJ
OiBJVFNAMHgxMDAxMDAxMjAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40MDI2MzZdIFBDSS9N
U0k6IElUU0AweDEwMDEwMDA0MDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjQwNzg0Ml0gUENJ
L01TSTogSVRTQDB4MTAwMTAwMDYwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuNDEzMDQ5XSBQ
Q0kvTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40MTgyNjBd
IFBDSS9NU0k6IElUU0AweDEwMDEwMDBhMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjQyMzQ2
Nl0gUENJL01TSTogSVRTQDB4MTAwMTAwMGMwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuNDI4
Njc3XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40
MzM4ODJdIFBDSS9NU0k6IElUU0AweDEwMDEwMDEwMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAx
LjQzOTA5M10gUENJL01TSTogSVRTQDB4MTAwMTAwMTIwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAg
IDEuNDQ0MzAyXSBFRkkgcnVudGltZSBzZXJ2aWNlcyBhY2Nlc3MgdmlhIHBhcmF2aXJ0Lg0KWyAg
ICAxLjQ0OTc2MV0gc21wOiBCcmluZ2luZyB1cCBzZWNvbmRhcnkgQ1BVcyAuLi4NCihYRU4pIGQw
djE6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8g
SUNBQ1RJVkVSMA0KKFhFTikgZDB2MjogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUg
MHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYzOiB2R0lDUjogU0dJOiB1
bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4p
IGQwdjQ6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYg
dG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2NTogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3Jp
dGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHY2OiB2R0lDUjogU0dJ
OiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihY
RU4pIGQwdjc6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZm
ZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2ODogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQg
d3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHY5OiB2R0lDUjog
U0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjAN
CihYRU4pIGQwdjEwOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZm
ZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjExOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQg
d29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjEyOiB2
R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNU
SVZFUjANCihYRU4pIGQwdjEzOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAw
MDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjE0OiB2R0lDUjogU0dJOiB1bmhh
bmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQw
djE1OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRv
IElDQUNUSVZFUjANCihYRU4pIGQwdjE2OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0
ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjE3OiB2R0lDUjogU0dJ
OiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihY
RU4pIGQwdjE4OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZm
ZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjE5OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29y
ZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjIwOiB2R0lD
UjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZF
UjANCihYRU4pIGQwdjIxOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAw
MGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjIyOiB2R0lDUjogU0dJOiB1bmhhbmRs
ZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjIz
OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElD
QUNUSVZFUjANCihYRU4pIGQwdjI0OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAw
eDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjI1OiB2R0lDUjogU0dJOiB1
bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4p
IGQwdjI2OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZm
IHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjI3OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3
cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjI4OiB2R0lDUjog
U0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjAN
CihYRU4pIGQwdjI5OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZm
ZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjMwOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQg
d29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjMxOiB2
R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNU
SVZFUjANClsgICAgMS40NTQ0MDddIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxDQpbICAg
IDEuNDU0NDMzXSBHSUN2MzogQ1BVMTogZm91bmQgcmVkaXN0cmlidXRvciAxIHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDE2MDAwMA0KWyAgICAxLjQ2MDk2N10gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBd
LS0tLS0tLS0tLS0tDQpbICAgIDEuNDYwOTcyXSBXQVJOSU5HOiBDUFU6IDEgUElEOiAwIGF0IGRy
aXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNDYwOTcyXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS40NjA5NzddIENQ
VTogMSBQSUQ6IDAgQ29tbTogc3dhcHBlci8xIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1
LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNDYwOTc5XSBwc3RhdGU6IDYw
MDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNDYwOTgw
XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ2MDk4Ml0gbHIgOiBpdHNf
Y3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS40NjA5ODNdIHNwIDogZmZmZjgwMDAxMWEzYmU4
MA0KWyAgICAxLjQ2MDk4NF0geDI5OiBmZmZmODAwMDExYTNiZTgwIHgyODogMDAwMDAwMDAwMDAw
MDAwMSANClsgICAgMS40NjA5ODZdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAw
MTIwMjAwNzAgDQpbICAgIDEuNDYwOTg4XSB4MjU6IGZmZmZmZTFmZmRlMGNjMDAgeDI0OiBmZmZm
ODAwMDEyMDIwMDAwIA0KWyAgICAxLjQ2MDk5MF0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjog
ZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS40NjA5OTJdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4
MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNDYwOTk0XSB4MTk6IGZmZmY4MDAwMTE2MjIw
MDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjQ2MDk5Nl0geDE3OiAwMDAwMDAwMDAw
MDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40NjA5OThdIHgxNTogZmZmZjgw
MDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNDYxMDAwXSB4MTM6IGZm
ZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjQ2MTAwMl0geDEx
OiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS40NjEwMDRd
IHg5IDogZmZmZjgwMDAxMDZkNjRmMCB4OCA6IDMwMzAzMDMwMzYzMTMwMzAgDQpbICAgIDEuNDYx
MDA2XSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAx
LjQ2MTAwOF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsg
ICAgMS40NjEwMTBdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYg
DQpbICAgIDEuNDYxMDEyXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZm
ZmVkIA0KWyAgICAxLjQ2MTAxNF0gQ2FsbCB0cmFjZToNClsgICAgMS40NjEwMTVdICBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NjEwMTldICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgv
MHg5MA0KWyAgICAxLjQ2MTAyMV0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpb
ICAgIDEuNDYxMDIzXSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS40NjEw
MjZdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS40NjEwMjddIC0t
LVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTMgXS0tLQ0KWyAgICAxLjQ2MTAzM10gR0lDdjM6
IENQVTE6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwMzMw
MDAwDQpbICAgIDEuNDYxMDk5XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5k
IGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNDYxMTA4XSBYZW46IGluaXRpYWxpemlu
ZyBjcHUxDQpbICAgIDEuNDYxMTMyXSBDUFUxOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAwMDAwMDEgWzB4NDEzZmQwYzFdDQpbICAgIDEuNDYxNDIzXSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVMg0KWyAgICAxLjQ2MTQ1Ml0gR0lDdjM6IENQVTI6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMiByZWdpb24gMDoweDAwMDAxMDAxMDAxODAwMDANClsgICAgMS40Njc5OTFdIC0tLS0t
LS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjQ2Nzk5N10gV0FSTklORzog
Q1BVOiAyIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ2Nzk5OV0gTW9kdWxlcyBsaW5rZWQgaW46
DQpbICAgIDEuNDY4MDA0XSBDUFU6IDIgUElEOiAwIENvbW06IHN3YXBwZXIvMiBUYWludGVkOiBH
ICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAx
LjQ2ODAwNl0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBF
PS0tKQ0KWyAgICAxLjQ2ODAwOF0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS40NjgwMDldIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNDY4MDExXSBz
cCA6IGZmZmY4MDAwMTFhNDNlODANClsgICAgMS40NjgwMTJdIHgyOTogZmZmZjgwMDAxMWE0M2U4
MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDIgDQpbICAgIDEuNDY4MDE0XSB4Mjc6IDAwMDAwMDAwMDAw
MDAwMDAgeDI2OiBmZmZmODAwMDEyMDQwMDcwIA0KWyAgICAxLjQ2ODAxN10geDI1OiBmZmZmZmUx
ZmZkZTBkMDAwIHgyNDogZmZmZjgwMDAxMjA0MDAwMCANClsgICAgMS40NjgwMTldIHgyMzogZmZm
ZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNDY4MDIxXSB4MjE6
IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjQ2ODAyM10g
eDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS40Njgw
MjVdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEu
NDY4MDI2XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAg
ICAxLjQ2ODAyOF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS40NjgwMzBdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAw
MDEgDQpbICAgIDEuNDY4MDMyXSB4OSA6IGZmZmY4MDAwMTA2ZDY0ZjAgeDggOiAzMDMwMzAzMDM4
MzEzMDMwIA0KWyAgICAxLjQ2ODAzNV0geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2IDogMDAwMDAw
MDAwMDAwMDAwMyANClsgICAgMS40NjgwMzddIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZm
ZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDY4MDM4XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIg
OiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ2ODA0MF0geDEgOiAwMDAwMDAwMDAwMDEwMDAw
IHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40NjgwNDNdIENhbGwgdHJhY2U6DQpbICAg
IDEuNDY4MDQ0XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDY4MDQ4XSAgZ2lj
X3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40NjgwNTJdICBjcHVocF9pbnZva2VfY2Fs
bGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ2ODA1NF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhh
MC8weGUwDQpbICAgIDEuNDY4MDU3XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkw
DQpbICAgIDEuNDY4MDU4XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjU0IF0tLS0NClsg
ICAgMS40NjgwNjVdIEdJQ3YzOiBDUFUyOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFi
bGUgQDB4MDAwMDA4MDAwMDM0MDAwMA0KWyAgICAxLjQ2ODE0Ml0gYXJjaF90aW1lcjogRW5hYmxp
bmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjQ2ODE1
NV0gWGVuOiBpbml0aWFsaXppbmcgY3B1Mg0KWyAgICAxLjQ2ODE4MV0gQ1BVMjogQm9vdGVkIHNl
Y29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDAyIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjQ2ODQ2
MF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTMNClsgICAgMS40Njg0ODhdIEdJQ3YzOiBD
UFUzOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDMgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMWEwMDAwDQpb
ICAgIDEuNDc1MDIyXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAg
MS40NzUwMjddIFdBUk5JTkc6IENQVTogMyBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1n
aWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NzUwMjhd
IE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ3NTAzMl0gQ1BVOiAzIFBJRDogMCBDb21tOiBz
d2FwcGVyLzMgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1z
dGFuZGFyZCsgIzENClsgICAgMS40NzUwMzRdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAt
UEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS40NzUwMzZdIHBjIDogaXRzX2NwdV9pbml0
KzB4ODI0LzB4YjIwDQpbICAgIDEuNDc1MDM4XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIy
MA0KWyAgICAxLjQ3NTAzOV0gc3AgOiBmZmZmODAwMDExYTRiZTgwDQpbICAgIDEuNDc1MDQwXSB4
Mjk6IGZmZmY4MDAwMTFhNGJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjQ3NTA0
Ml0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjA2MDA3MCANClsgICAgMS40
NzUwNDRdIHgyNTogZmZmZmZlMWZmZGUwZDQwMCB4MjQ6IGZmZmY4MDAwMTIwNjAwMDAgDQpbICAg
IDEuNDc1MDQ2XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0K
WyAgICAxLjQ3NTA0OF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1
MCANClsgICAgMS40NzUwNTBdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZm
ZmZmZmYgDQpbICAgIDEuNDc1MDUyXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAw
MDAwMDAwMDAwIA0KWyAgICAxLjQ3NTA1NV0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAw
MDAwMDAwMDAwMDAxMCANClsgICAgMS40NzUwNTddIHgxMzogZmZmZjgwMDAxMTZkNGNmNCB4MTI6
IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDc1MDU4XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAg
eDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjQ3NTA2MF0geDkgOiBmZmZmODAwMDEwNmQ2
NGYwIHg4IDogMzAzMDMwMzA2MTMxMzAzMCANClsgICAgMS40NzUwNjJdIHg3IDogMzEzMDMwMzEz
MDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNDc1MDY0XSB4NSA6IDAwMDAw
MDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjQ3NTA2Nl0geDMgOiAw
MDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS40NzUwNjhdIHgx
IDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNDc1MDcw
XSBDYWxsIHRyYWNlOg0KWyAgICAxLjQ3NTA3Ml0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjQ3NTA3NV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNDc1MDc3
XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS40NzUwNzldICBub3Rp
ZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjQ3NTA4Ml0gIHNlY29uZGFyeV9zdGFy
dF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjQ3NTA4M10gLS0tWyBlbmQgdHJhY2UgZjY4NzI4
YTBkMzA1M2I1NSBdLS0tDQpbICAgIDEuNDc1MDg5XSBHSUN2MzogQ1BVMzogdXNpbmcgYWxsb2Nh
dGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzNTAwMDANClsgICAgMS40NzUxNTld
IGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0
MTgwNDANClsgICAgMS40NzUxNjddIFhlbjogaW5pdGlhbGl6aW5nIGNwdTMNClsgICAgMS40NzUx
OTBdIENQVTM6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDAwMyBbMHg0MTNm
ZDBjMV0NClsgICAgMS40NzU0NjddIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFU0DQpbICAg
IDEuNDc1NDk4XSBHSUN2MzogQ1BVNDogZm91bmQgcmVkaXN0cmlidXRvciA0IHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDFjMDAwMA0KWyAgICAxLjQ4MjAzM10gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBd
LS0tLS0tLS0tLS0tDQpbICAgIDEuNDgyMDM3XSBXQVJOSU5HOiBDUFU6IDQgUElEOiAwIGF0IGRy
aXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNDgyMDM4XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS40ODIwNDJdIENQ
VTogNCBQSUQ6IDAgQ29tbTogc3dhcHBlci80IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1
LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNDgyMDQ0XSBwc3RhdGU6IDYw
MDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNDgyMDQ2
XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ4MjA0N10gbHIgOiBpdHNf
Y3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS40ODIwNDhdIHNwIDogZmZmZjgwMDAxMWE1M2U4
MA0KWyAgICAxLjQ4MjA1MF0geDI5OiBmZmZmODAwMDExYTUzZTgwIHgyODogMDAwMDAwMDAwMDAw
MDAwNCANClsgICAgMS40ODIwNTJdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAw
MTIwODAwNzAgDQpbICAgIDEuNDgyMDU0XSB4MjU6IGZmZmZmZTFmZmRlMGQ4MDAgeDI0OiBmZmZm
ODAwMDEyMDgwMDAwIA0KWyAgICAxLjQ4MjA1Nl0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjog
ZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS40ODIwNThdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4
MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNDgyMDYwXSB4MTk6IGZmZmY4MDAwMTE2MjIw
MDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjQ4MjA2MV0geDE3OiAwMDAwMDAwMDAw
MDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40ODIwNjNdIHgxNTogZmZmZjgw
MDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNDgyMDY1XSB4MTM6IGZm
ZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjQ4MjA2N10geDEx
OiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS40ODIwNjld
IHg5IDogZmZmZjgwMDAxMDZkNjRmMCB4OCA6IDMwMzAzMDMwNjMzMTMwMzAgDQpbICAgIDEuNDgy
MDcxXSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAx
LjQ4MjA3M10geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsg
ICAgMS40ODIwNzVdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYg
DQpbICAgIDEuNDgyMDc3XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZm
ZmVkIA0KWyAgICAxLjQ4MjA3OV0gQ2FsbCB0cmFjZToNClsgICAgMS40ODIwODFdICBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40ODIwODRdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgv
MHg5MA0KWyAgICAxLjQ4MjA4N10gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpb
ICAgIDEuNDgyMDg5XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS40ODIw
OTFdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS40ODIwOTJdIC0t
LVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTYgXS0tLQ0KWyAgICAxLjQ4MjA5OV0gR0lDdjM6
IENQVTQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwMzYw
MDAwDQpbICAgIDEuNDgyMTc0XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5k
IGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNDgyMTgzXSBYZW46IGluaXRpYWxpemlu
ZyBjcHU0DQpbICAgIDEuNDgyMjA3XSBDUFU0OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAwMDAwMDQgWzB4NDEzZmQwYzFdDQpbICAgIDEuNDgyNTQ2XSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVNQ0KWyAgICAxLjQ4MjU3OF0gR0lDdjM6IENQVTU6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgNSByZWdpb24gMDoweDAwMDAxMDAxMDAxZTAwMDANClsgICAgMS40ODkxMTNdIC0tLS0t
LS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjQ4OTExOF0gV0FSTklORzog
Q1BVOiA1IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ4OTExOV0gTW9kdWxlcyBsaW5rZWQgaW46
DQpbICAgIDEuNDg5MTIzXSBDUFU6IDUgUElEOiAwIENvbW06IHN3YXBwZXIvNSBUYWludGVkOiBH
ICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAx
LjQ4OTEyNV0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBF
PS0tKQ0KWyAgICAxLjQ4OTEyN10gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS40ODkxMjldIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNDg5MTMwXSBz
cCA6IGZmZmY4MDAwMTFhNWJlODANClsgICAgMS40ODkxMzFdIHgyOTogZmZmZjgwMDAxMWE1YmU4
MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDUgDQpbICAgIDEuNDg5MTMzXSB4Mjc6IDAwMDAwMDAwMDAw
MDAwMDAgeDI2OiBmZmZmODAwMDEyMGEwMDcwIA0KWyAgICAxLjQ4OTEzNV0geDI1OiBmZmZmZmUx
ZmZkZTBkYzAwIHgyNDogZmZmZjgwMDAxMjBhMDAwMCANClsgICAgMS40ODkxMzddIHgyMzogZmZm
ZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNDg5MTM5XSB4MjE6
IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjQ4OTE0MV0g
eDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS40ODkx
NDNdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEu
NDg5MTQ1XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAg
ICAxLjQ4OTE0N10geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS40ODkxNDldIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAw
MDEgDQpbICAgIDEuNDg5MTUxXSB4OSA6IGZmZmY4MDAwMTA2ZDY0ZjAgeDggOiAzMDMwMzAzMDY1
MzEzMDMwIA0KWyAgICAxLjQ4OTE1M10geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2IDogMDAwMDAw
MDAwMDAwMDAwMyANClsgICAgMS40ODkxNTVdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZm
ZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDg5MTU3XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIg
OiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ4OTE1OV0geDEgOiAwMDAwMDAwMDAwMDEwMDAw
IHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40ODkxNjFdIENhbGwgdHJhY2U6DQpbICAg
IDEuNDg5MTYzXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDg5MTY2XSAgZ2lj
X3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40ODkxNjhdICBjcHVocF9pbnZva2VfY2Fs
bGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ4OTE3MF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhh
MC8weGUwDQpbICAgIDEuNDg5MTczXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkw
DQpbICAgIDEuNDg5MTc0XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjU3IF0tLS0NClsg
ICAgMS40ODkxODFdIEdJQ3YzOiBDUFU1OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFi
bGUgQDB4MDAwMDA4MDAwMDM3MDAwMA0KWyAgICAxLjQ4OTI1Ml0gYXJjaF90aW1lcjogRW5hYmxp
bmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjQ4OTI2
MV0gWGVuOiBpbml0aWFsaXppbmcgY3B1NQ0KWyAgICAxLjQ4OTI4NF0gQ1BVNTogQm9vdGVkIHNl
Y29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA1IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjQ4OTY2
NF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTYNClsgICAgMS40ODk3MDBdIEdJQ3YzOiBD
UFU2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDYgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMjAwMDAwDQpb
ICAgIDEuNDk2MjM3XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAg
MS40OTYyNDFdIFdBUk5JTkc6IENQVTogNiBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1n
aWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40OTYyNDJd
IE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ5NjI0Nl0gQ1BVOiA2IFBJRDogMCBDb21tOiBz
d2FwcGVyLzYgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1z
dGFuZGFyZCsgIzENClsgICAgMS40OTYyNDhdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAt
UEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS40OTYyNTBdIHBjIDogaXRzX2NwdV9pbml0
KzB4ODI0LzB4YjIwDQpbICAgIDEuNDk2MjUxXSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIy
MA0KWyAgICAxLjQ5NjI1Ml0gc3AgOiBmZmZmODAwMDExYTYzZTgwDQpbICAgIDEuNDk2MjU0XSB4
Mjk6IGZmZmY4MDAwMTFhNjNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDA2IA0KWyAgICAxLjQ5NjI1
Nl0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjBjMDA3MCANClsgICAgMS40
OTYyNThdIHgyNTogZmZmZmZlMWZmZGUwZTAwMCB4MjQ6IGZmZmY4MDAwMTIwYzAwMDAgDQpbICAg
IDEuNDk2MjYwXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0K
WyAgICAxLjQ5NjI2M10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1
MCANClsgICAgMS40OTYyNjVdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZm
ZmZmZmYgDQpbICAgIDEuNDk2MjY3XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAw
MDAwMDAwMDAwIA0KWyAgICAxLjQ5NjI2OF0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAw
MDAwMDAwMDAwMDAxMCANClsgICAgMS40OTYyNzBdIHgxMzogZmZmZjgwMDAxMTZkNGNmNCB4MTI6
IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDk2MjcyXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAg
eDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjQ5NjI3NF0geDkgOiBmZmZmODAwMDEwNmQ2
NGYwIHg4IDogMzAzMDMwMzAzMDMyMzAzMCANClsgICAgMS40OTYyNzZdIHg3IDogMzEzMDMwMzEz
MDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNDk2Mjc4XSB4NSA6IDAwMDAw
MDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjQ5NjI4MF0geDMgOiAw
MDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS40OTYyODJdIHgx
IDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNDk2Mjg0
XSBDYWxsIHRyYWNlOg0KWyAgICAxLjQ5NjI4NV0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjQ5NjI4OF0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNDk2Mjkx
XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS40OTYyOTNdICBub3Rp
ZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjQ5NjI5NV0gIHNlY29uZGFyeV9zdGFy
dF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjQ5NjI5Nl0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4
YTBkMzA1M2I1OCBdLS0tDQpbICAgIDEuNDk2MzAzXSBHSUN2MzogQ1BVNjogdXNpbmcgYWxsb2Nh
dGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzODAwMDANClsgICAgMS40OTYzNzld
IGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0
MTgwNDANClsgICAgMS40OTYzODhdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTYNClsgICAgMS40OTY0
MTNdIENQVTY6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDAwNiBbMHg0MTNm
ZDBjMV0NClsgICAgMS40OTY3ODNdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFU3DQpbICAg
IDEuNDk2ODIxXSBHSUN2MzogQ1BVNzogZm91bmQgcmVkaXN0cmlidXRvciA3IHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDIyMDAwMA0KWyAgICAxLjUwMzM1Nl0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBd
LS0tLS0tLS0tLS0tDQpbICAgIDEuNTAzMzYwXSBXQVJOSU5HOiBDUFU6IDcgUElEOiAwIGF0IGRy
aXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNTAzMzYxXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41MDMzNjZdIENQ
VTogNyBQSUQ6IDAgQ29tbTogc3dhcHBlci83IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1
LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTAzMzY4XSBwc3RhdGU6IDYw
MDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNTAzMzcw
XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUwMzM3MV0gbHIgOiBpdHNf
Y3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41MDMzNzJdIHNwIDogZmZmZjgwMDAxMWE2YmU4
MA0KWyAgICAxLjUwMzM3M10geDI5OiBmZmZmODAwMDExYTZiZTgwIHgyODogMDAwMDAwMDAwMDAw
MDAwNyANClsgICAgMS41MDMzNzVdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAw
MTIwZTAwNzAgDQpbICAgIDEuNTAzMzc3XSB4MjU6IGZmZmZmZTFmZmRlMGU0MDAgeDI0OiBmZmZm
ODAwMDEyMGUwMDAwIA0KWyAgICAxLjUwMzM3OV0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjog
ZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41MDMzODFdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4
MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTAzMzgzXSB4MTk6IGZmZmY4MDAwMTE2MjIw
MDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjUwMzM4NV0geDE3OiAwMDAwMDAwMDAw
MDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MDMzODddIHgxNTogZmZmZjgw
MDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTAzMzg5XSB4MTM6IGZm
ZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjUwMzM5MV0geDEx
OiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41MDMzOTNd
IHg5IDogZmZmZjgwMDAxMDZkNjRmMCB4OCA6IDMwMzAzMDMwMzIzMjMwMzAgDQpbICAgIDEuNTAz
Mzk0XSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAx
LjUwMzM5Nl0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsg
ICAgMS41MDMzOThdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYg
DQpbICAgIDEuNTAzNDAwXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZm
ZmVkIA0KWyAgICAxLjUwMzQwMl0gQ2FsbCB0cmFjZToNClsgICAgMS41MDM0MDRdICBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MDM0MDddICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgv
MHg5MA0KWyAgICAxLjUwMzQwOV0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpb
ICAgIDEuNTAzNDExXSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS41MDM0
MTRdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41MDM0MTVdIC0t
LVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTkgXS0tLQ0KWyAgICAxLjUwMzQyMl0gR0lDdjM6
IENQVTc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwMzkw
MDAwDQpbICAgIDEuNTAzNDkxXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5k
IGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTAzNTAwXSBYZW46IGluaXRpYWxpemlu
ZyBjcHU3DQpbICAgIDEuNTAzNTIzXSBDUFU3OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAwMDAwMDcgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTAzNzk0XSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVOA0KWyAgICAxLjUwMzgzNF0gR0lDdjM6IENQVTg6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgOCByZWdpb24gMDoweDAwMDAxMDAxMDAyNDAwMDANClsgICAgMS41MTAzNzBdIC0tLS0t
LS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjUxMDM3NV0gV0FSTklORzog
Q1BVOiA4IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUxMDM3Nl0gTW9kdWxlcyBsaW5rZWQgaW46
DQpbICAgIDEuNTEwMzc5XSBDUFU6IDggUElEOiAwIENvbW06IHN3YXBwZXIvOCBUYWludGVkOiBH
ICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAx
LjUxMDM4Ml0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBF
PS0tKQ0KWyAgICAxLjUxMDM4M10gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS41MTAzODVdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTEwMzg2XSBz
cCA6IGZmZmY4MDAwMTFhNzNlODANClsgICAgMS41MTAzODddIHgyOTogZmZmZjgwMDAxMWE3M2U4
MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDggDQpbICAgIDEuNTEwMzg5XSB4Mjc6IDAwMDAwMDAwMDAw
MDAwMDAgeDI2OiBmZmZmODAwMDEyMTAwMDcwIA0KWyAgICAxLjUxMDM5Ml0geDI1OiBmZmZmZmUx
ZmZkZTBlODAwIHgyNDogZmZmZjgwMDAxMjEwMDAwMCANClsgICAgMS41MTAzOTRdIHgyMzogZmZm
ZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTEwMzk2XSB4MjE6
IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjUxMDM5N10g
eDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41MTAz
OTldIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEu
NTEwNDAxXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAg
ICAxLjUxMDQwM10geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS41MTA0MDVdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAw
MDEgDQpbICAgIDEuNTEwNDA3XSB4OSA6IGZmZmY4MDAwMTA2ZDY0ZjAgeDggOiAzMDMwMzAzMDM0
MzIzMDMwIA0KWyAgICAxLjUxMDQwOV0geDcgOiAzMTMwMzAzMTMwMzAzMDMwIHg2IDogMDAwMDAw
MDAwMDAwMDAwMyANClsgICAgMS41MTA0MTFdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZm
ZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTEwNDEzXSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIg
OiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjUxMDQxNV0geDEgOiAwMDAwMDAwMDAwMDEwMDAw
IHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41MTA0MTddIENhbGwgdHJhY2U6DQpbICAg
IDEuNTEwNDE5XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTEwNDIxXSAgZ2lj
X3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41MTA0MjRdICBjcHVocF9pbnZva2VfY2Fs
bGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjUxMDQyNl0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhh
MC8weGUwDQpbICAgIDEuNTEwNDI4XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkw
DQpbICAgIDEuNTEwNDMwXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjVhIF0tLS0NClsg
ICAgMS41MTA0MzZdIEdJQ3YzOiBDUFU4OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFi
bGUgQDB4MDAwMDA4MDAwMDNhMDAwMA0KWyAgICAxLjUxMDUxMl0gYXJjaF90aW1lcjogRW5hYmxp
bmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjUxMDUy
MV0gWGVuOiBpbml0aWFsaXppbmcgY3B1OA0KWyAgICAxLjUxMDU0N10gQ1BVODogQm9vdGVkIHNl
Y29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA4IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjUxMDgz
MF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTkNClsgICAgMS41MTA4NzNdIEdJQ3YzOiBD
UFU5OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDkgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMjYwMDAwDQpb
ICAgIDEuNTE3NDA5XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAg
MS41MTc0MTRdIFdBUk5JTkc6IENQVTogOSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1n
aWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MTc0MTVd
IE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjUxNzQxOV0gQ1BVOiA5IFBJRDogMCBDb21tOiBz
d2FwcGVyLzkgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1z
dGFuZGFyZCsgIzENClsgICAgMS41MTc0MjFdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAt
UEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41MTc0MjNdIHBjIDogaXRzX2NwdV9pbml0
KzB4ODI0LzB4YjIwDQpbICAgIDEuNTE3NDI0XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIy
MA0KWyAgICAxLjUxNzQyNV0gc3AgOiBmZmZmODAwMDExYTdiZTgwDQpbICAgIDEuNTE3NDI2XSB4
Mjk6IGZmZmY4MDAwMTFhN2JlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDA5IA0KWyAgICAxLjUxNzQy
OF0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjEyMDA3MCANClsgICAgMS41
MTc0MzFdIHgyNTogZmZmZmZlMWZmZGUwZWMwMCB4MjQ6IGZmZmY4MDAwMTIxMjAwMDAgDQpbICAg
IDEuNTE3NDMzXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0K
WyAgICAxLjUxNzQzNV0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1
MCANClsgICAgMS41MTc0MzddIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZm
ZmZmZmYgDQpbICAgIDEuNTE3NDM5XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAw
MDAwMDAwMDAwIA0KWyAgICAxLjUxNzQ0MV0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAw
MDAwMDAwMDAwMDAxMCANClsgICAgMS41MTc0NDNdIHgxMzogZmZmZjgwMDAxMTZkNGNmNCB4MTI6
IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTE3NDQ0XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAg
eDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjUxNzQ0Nl0geDkgOiBmZmZmODAwMDEwNmQ2
NGYwIHg4IDogMzAzMDMwMzAzNjMyMzAzMCANClsgICAgMS41MTc0NDhdIHg3IDogMzEzMDMwMzEz
MDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTE3NDUwXSB4NSA6IDAwMDAw
MDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjUxNzQ1Ml0geDMgOiAw
MDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS41MTc0NTRdIHgx
IDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTE3NDU3
XSBDYWxsIHRyYWNlOg0KWyAgICAxLjUxNzQ1OF0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjUxNzQ2MV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTE3NDY0
XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41MTc0NjZdICBub3Rp
ZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjUxNzQ2OV0gIHNlY29uZGFyeV9zdGFy
dF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjUxNzQ3MF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4
YTBkMzA1M2I1YiBdLS0tDQpbICAgIDEuNTE3NDc2XSBHSUN2MzogQ1BVOTogdXNpbmcgYWxsb2Nh
dGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzYjAwMDANClsgICAgMS41MTc1NDZd
IGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0
MTgwNDANClsgICAgMS41MTc1NTVdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTkNClsgICAgMS41MTc1
NzldIENQVTk6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDAwOSBbMHg0MTNm
ZDBjMV0NClsgICAgMS41MTc5MjddIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxMA0KWyAg
ICAxLjUxNzk3M10gR0lDdjM6IENQVTEwOiBmb3VuZCByZWRpc3RyaWJ1dG9yIGEgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwMjgwMDAwDQpbICAgIDEuNTI0NTk2XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJl
IF0tLS0tLS0tLS0tLS0NClsgICAgMS41MjQ2MDBdIFdBUk5JTkc6IENQVTogMTAgUElEOiAwIGF0
IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDEuNTI0NjAxXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41MjQ2MDVd
IENQVTogMTAgUElEOiAwIENvbW06IHN3YXBwZXIvMTAgVGFpbnRlZDogRyAgICAgICAgVyAgICAg
ICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS41MjQ2MDddIHBzdGF0
ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41
MjQ2MDldIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTI0NjEwXSBsciA6
IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjUyNDYxMV0gc3AgOiBmZmZmODAwMDEx
YTgzZTgwDQpbICAgIDEuNTI0NjEzXSB4Mjk6IGZmZmY4MDAwMTFhODNlODAgeDI4OiAwMDAwMDAw
MDAwMDAwMDBhIA0KWyAgICAxLjUyNDYxNV0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZm
ZjgwMDAxMjE0MDA3MCANClsgICAgMS41MjQ2MTddIHgyNTogZmZmZmZlMWZmZGUwZjAwMCB4MjQ6
IGZmZmY4MDAwMTIxNDAwMDAgDQpbICAgIDEuNTI0NjE5XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAg
eDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjUyNDYyMV0geDIxOiBmZmZmODAwMDExNzY4
OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41MjQ2MjRdIHgxOTogZmZmZjgwMDAx
MTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTI0NjI1XSB4MTc6IDAwMDAw
MDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjUyNDYyN10geDE1OiBm
ZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41MjQ2MjldIHgx
MzogZmZmZjgwMDAxMTZkNGNmNSB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTI0NjMx
XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjUy
NDYzM10geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDogMzAzMDMwMzgzMjMwMzAzMSANClsgICAg
MS41MjQ2MzVdIHg3IDogMzAzMDMxMzAzMDMwMzA3OCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpb
ICAgIDEuNTI0NjM3XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAw
IA0KWyAgICAxLjUyNDYzOV0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAw
ZmZmZiANClsgICAgMS41MjQ2NDBdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAw
ZmZmZmZmZWQgDQpbICAgIDEuNTI0NjQzXSBDYWxsIHRyYWNlOg0KWyAgICAxLjUyNDY0NF0gIGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUyNDY0N10gIGdpY19zdGFydGluZ19jcHUr
MHg0OC8weDkwDQpbICAgIDEuNTI0NjUwXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0
NjANClsgICAgMS41MjQ2NTJdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAx
LjUyNDY1NF0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjUyNDY1
Nl0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I1YyBdLS0tDQpbICAgIDEuNTI0NjYyXSBH
SUN2MzogQ1BVMTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwM2MwMDAwDQpbICAgIDEuNTI0NzM4XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3Jr
YXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTI0NzQ4XSBYZW46IGluaXRp
YWxpemluZyBjcHUxMA0KWyAgICAxLjUyNDc3M10gQ1BVMTA6IEJvb3RlZCBzZWNvbmRhcnkgcHJv
Y2Vzc29yIDB4MDAwMDAwMDAwYSBbMHg0MTNmZDBjMV0NClsgICAgMS41MjUxMjVdIERldGVjdGVk
IFBJUFQgSS1jYWNoZSBvbiBDUFUxMQ0KWyAgICAxLjUyNTE3MV0gR0lDdjM6IENQVTExOiBmb3Vu
ZCByZWRpc3RyaWJ1dG9yIGIgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMmEwMDAwDQpbICAgIDEuNTMx
Nzk0XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41MzE3OThd
IFdBUk5JTkc6IENQVTogMTEgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0
cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTMxODAwXSBNb2R1bGVz
IGxpbmtlZCBpbjoNClsgICAgMS41MzE4MDRdIENQVTogMTEgUElEOiAwIENvbW06IHN3YXBwZXIv
MTEgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFy
ZCsgIzENClsgICAgMS41MzE4MDZdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1V
QU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41MzE4MDhdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDEuNTMxODA5XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAg
ICAxLjUzMTgxMF0gc3AgOiBmZmZmODAwMDExYThiZTgwDQpbICAgIDEuNTMxODExXSB4Mjk6IGZm
ZmY4MDAwMTFhOGJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDBiIA0KWyAgICAxLjUzMTgxNF0geDI3
OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjE2MDA3MCANClsgICAgMS41MzE4MTZd
IHgyNTogZmZmZmZlMWZmZGUwZjQwMCB4MjQ6IGZmZmY4MDAwMTIxNjAwMDAgDQpbICAgIDEuNTMx
ODE4XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAx
LjUzMTgyMF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsg
ICAgMS41MzE4MjJdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYg
DQpbICAgIDEuNTMxODI0XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAw
MDAwIA0KWyAgICAxLjUzMTgyNl0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAw
MDAwMDAxMCANClsgICAgMS41MzE4MjhdIHgxMzogZmZmZjgwMDAxMTZkNGNmNSB4MTI6IDAwMDAw
MDAwMDAwMDAwMDAgDQpbICAgIDEuNTMxODMwXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAw
MDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjUzMTgzMl0geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4
IDogMzAzMDMwNjEzMjMwMzAzMSANClsgICAgMS41MzE4MzNdIHg3IDogMzAzMDMxMzAzMDMwMzA3
OCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTMxODM1XSB4NSA6IDAwMDAwMDAwMDAw
MDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjUzMTgzN10geDMgOiAwMDAwMDAw
MDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS41MzE4MzldIHgxIDogMDAw
MDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTMxODQxXSBDYWxs
IHRyYWNlOg0KWyAgICAxLjUzMTg0M10gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjUzMTg0Nl0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTMxODQ5XSAgY3B1
aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41MzE4NTFdICBub3RpZnlfY3B1
X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjUzMTg1M10gIHNlY29uZGFyeV9zdGFydF9rZXJu
ZWwrMHhlOC8weDE5MA0KWyAgICAxLjUzMTg1NV0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1
M2I1ZCBdLS0tDQpbICAgIDEuNTMxODYyXSBHSUN2MzogQ1BVMTE6IHVzaW5nIGFsbG9jYXRlZCBM
UEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2QwMDAwDQpbICAgIDEuNTMxOTMxXSBhcmNo
X3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQw
DQpbICAgIDEuNTMxOTQxXSBYZW46IGluaXRpYWxpemluZyBjcHUxMQ0KWyAgICAxLjUzMTk2NV0g
Q1BVMTE6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDAwYiBbMHg0MTNmZDBj
MV0NClsgICAgMS41MzIzMDldIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxMg0KWyAgICAx
LjUzMjM2MF0gR0lDdjM6IENQVTEyOiBmb3VuZCByZWRpc3RyaWJ1dG9yIGMgcmVnaW9uIDA6MHgw
MDAwMTAwMTAwMmMwMDAwDQpbICAgIDEuNTM4OTgyXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0t
LS0tLS0tLS0tLS0NClsgICAgMS41Mzg5ODddIFdBUk5JTkc6IENQVTogMTIgUElEOiAwIGF0IGRy
aXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNTM4OTg3XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41Mzg5OTFdIENQ
VTogMTIgUElEOiAwIENvbW06IHN3YXBwZXIvMTIgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAg
IDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS41Mzg5OTRdIHBzdGF0ZTog
NjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41Mzg5
OTVdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTM4OTk3XSBsciA6IGl0
c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjUzODk5OF0gc3AgOiBmZmZmODAwMDExYTkz
ZTgwDQpbICAgIDEuNTM4OTk5XSB4Mjk6IGZmZmY4MDAwMTFhOTNlODAgeDI4OiAwMDAwMDAwMDAw
MDAwMDBjIA0KWyAgICAxLjUzOTAwMV0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgw
MDAxMjE4MDA3MCANClsgICAgMS41MzkwMDNdIHgyNTogZmZmZmZlMWZmZGUwZjgwMCB4MjQ6IGZm
ZmY4MDAwMTIxODAwMDAgDQpbICAgIDEuNTM5MDA1XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIy
OiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjUzOTAwN10geDIxOiBmZmZmODAwMDExNzY4OWY4
IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41MzkwMDldIHgxOTogZmZmZjgwMDAxMTYy
MjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTM5MDExXSB4MTc6IDAwMDAwMDAw
MDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjUzOTAxM10geDE1OiBmZmZm
ODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41MzkwMTVdIHgxMzog
ZmZmZjgwMDAxMTZkNGNmNSB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTM5MDE3XSB4
MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjUzOTAx
OV0geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDogMzAzMDMwNjMzMjMwMzAzMSANClsgICAgMS41
MzkwMjFdIHg3IDogMzAzMDMxMzAzMDMwMzA3OCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAg
IDEuNTM5MDIzXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0K
WyAgICAxLjUzOTAyNV0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZm
ZiANClsgICAgMS41MzkwMjddIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZm
ZmZmZWQgDQpbICAgIDEuNTM5MDI5XSBDYWxsIHRyYWNlOg0KWyAgICAxLjUzOTAzMV0gIGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUzOTAzNF0gIGdpY19zdGFydGluZ19jcHUrMHg0
OC8weDkwDQpbICAgIDEuNTM5MDM2XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjAN
ClsgICAgMS41MzkwMzhdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjUz
OTA0MV0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjUzOTA0Ml0g
LS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I1ZSBdLS0tDQpbICAgIDEuNTM5MDQ4XSBHSUN2
MzogQ1BVMTI6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAw
M2UwMDAwDQpbICAgIDEuNTM5MTI1XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJv
dW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTM5MTM0XSBYZW46IGluaXRpYWxp
emluZyBjcHUxMg0KWyAgICAxLjUzOTE2MF0gQ1BVMTI6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vz
c29yIDB4MDAwMDAwMDAwYyBbMHg0MTNmZDBjMV0NClsgICAgMS41Mzk0MzJdIERldGVjdGVkIFBJ
UFQgSS1jYWNoZSBvbiBDUFUxMw0KWyAgICAxLjUzOTQ4M10gR0lDdjM6IENQVTEzOiBmb3VuZCBy
ZWRpc3RyaWJ1dG9yIGQgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMmUwMDAwDQpbICAgIDEuNTQ2MTA2
XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41NDYxMTFdIFdB
Uk5JTkc6IENQVTogMTMgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5j
OjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTQ2MTEyXSBNb2R1bGVzIGxp
bmtlZCBpbjoNClsgICAgMS41NDYxMTddIENQVTogMTMgUElEOiAwIENvbW06IHN3YXBwZXIvMTMg
VGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsg
IzENClsgICAgMS41NDYxMTldIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8g
LVRDTyBCVFlQRT0tLSkNClsgICAgMS41NDYxMjFdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNTQ2MTIyXSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAx
LjU0NjEyM10gc3AgOiBmZmZmODAwMDExYTliZTgwDQpbICAgIDEuNTQ2MTI0XSB4Mjk6IGZmZmY4
MDAwMTFhOWJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDBkIA0KWyAgICAxLjU0NjEyN10geDI3OiAw
MDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjFhMDA3MCANClsgICAgMS41NDYxMjldIHgy
NTogZmZmZmZlMWZmZGUwZmMwMCB4MjQ6IGZmZmY4MDAwMTIxYTAwMDAgDQpbICAgIDEuNTQ2MTMx
XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjU0
NjEzM10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAg
MS41NDYxMzVdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpb
ICAgIDEuNTQ2MTM3XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAw
IA0KWyAgICAxLjU0NjEzOV0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAw
MDAxMCANClsgICAgMS41NDYxNDFdIHgxMzogZmZmZjgwMDAxMTZkNGNmNSB4MTI6IDAwMDAwMDAw
MDAwMDAwMDAgDQpbICAgIDEuNTQ2MTQzXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAw
MDAwMDAwMDAwMDAxIA0KWyAgICAxLjU0NjE0NV0geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDog
MzAzMDMwNjUzMjMwMzAzMSANClsgICAgMS41NDYxNDddIHg3IDogMzAzMDMxMzAzMDMwMzA3OCB4
NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTQ2MTQ5XSB4NSA6IDAwMDAwMDAwMDAwMDAw
MDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjU0NjE1MF0geDMgOiAwMDAwMDAwMDAw
MDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS41NDYxNTJdIHgxIDogMDAwMDAw
MDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTQ2MTU0XSBDYWxsIHRy
YWNlOg0KWyAgICAxLjU0NjE1Nl0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU0
NjE1OV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTQ2MTYyXSAgY3B1aHBf
aW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41NDYxNjRdICBub3RpZnlfY3B1X3N0
YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjU0NjE2N10gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwr
MHhlOC8weDE5MA0KWyAgICAxLjU0NjE2OF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I1
ZiBdLS0tDQpbICAgIDEuNTQ2MTc1XSBHSUN2MzogQ1BVMTM6IHVzaW5nIGFsbG9jYXRlZCBMUEkg
cGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2YwMDAwDQpbICAgIDEuNTQ2MjQ1XSBhcmNoX3Rp
bWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpb
ICAgIDEuNTQ2MjU0XSBYZW46IGluaXRpYWxpemluZyBjcHUxMw0KWyAgICAxLjU0NjI3OV0gQ1BV
MTM6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDAwZCBbMHg0MTNmZDBjMV0N
ClsgICAgMS41NDY2NTddIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxNA0KWyAgICAxLjU0
NjcxMl0gR0lDdjM6IENQVTE0OiBmb3VuZCByZWRpc3RyaWJ1dG9yIGUgcmVnaW9uIDA6MHgwMDAw
MTAwMTAwMzAwMDAwDQpbICAgIDEuNTUzMzM1XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0t
LS0tLS0tLS0NClsgICAgMS41NTMzNDBdIFdBUk5JTkc6IENQVTogMTQgUElEOiAwIGF0IGRyaXZl
cnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIw
DQpbICAgIDEuNTUzMzQxXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41NTMzNDVdIENQVTog
MTQgUElEOiAwIENvbW06IHN3YXBwZXIvMTQgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUu
MTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS41NTMzNDddIHBzdGF0ZTogNjAw
MDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41NTMzNDld
IHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTUzMzUwXSBsciA6IGl0c19j
cHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjU1MzM1MV0gc3AgOiBmZmZmODAwMDExYWEzZTgw
DQpbICAgIDEuNTUzMzUyXSB4Mjk6IGZmZmY4MDAwMTFhYTNlODAgeDI4OiAwMDAwMDAwMDAwMDAw
MDBlIA0KWyAgICAxLjU1MzM1NF0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAx
MjFjMDA3MCANClsgICAgMS41NTMzNTZdIHgyNTogZmZmZmZlMWZmZGVhMDAwMCB4MjQ6IGZmZmY4
MDAwMTIxYzAwMDAgDQpbICAgIDEuNTUzMzU4XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBm
ZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjU1MzM2MF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgy
MDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41NTMzNjJdIHgxOTogZmZmZjgwMDAxMTYyMjAw
MCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTUzMzY0XSB4MTc6IDAwMDAwMDAwMDAw
MDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU1MzM2Nl0geDE1OiBmZmZmODAw
MDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41NTMzNjhdIHgxMzogZmZm
ZjgwMDAxMTZkNGNmNSB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTUzMzcwXSB4MTE6
IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjU1MzM3Ml0g
eDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDogMzAzMDMwMzAzMzMwMzAzMSANClsgICAgMS41NTMz
NzRdIHg3IDogMzAzMDMxMzAzMDMwMzA3OCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEu
NTUzMzc2XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAg
ICAxLjU1MzM3OF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiAN
ClsgICAgMS41NTMzODBdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZm
ZWQgDQpbICAgIDEuNTUzMzgyXSBDYWxsIHRyYWNlOg0KWyAgICAxLjU1MzM4NF0gIGl0c19jcHVf
aW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU1MzM4Nl0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8w
eDkwDQpbICAgIDEuNTUzMzg5XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsg
ICAgMS41NTMzOTBdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjU1MzM5
M10gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjU1MzM5NF0gLS0t
WyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2MCBdLS0tDQpbICAgIDEuNTUzNDAxXSBHSUN2Mzog
Q1BVMTQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyODAw
MDAwDQpbICAgIDEuNTUzNDc3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5k
IGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTUzNDg2XSBYZW46IGluaXRpYWxpemlu
ZyBjcHUxNA0KWyAgICAxLjU1MzUxMl0gQ1BVMTQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29y
IDB4MDAwMDAwMDAwZSBbMHg0MTNmZDBjMV0NClsgICAgMS41NTM4ODhdIERldGVjdGVkIFBJUFQg
SS1jYWNoZSBvbiBDUFUxNQ0KWyAgICAxLjU1Mzk0NF0gR0lDdjM6IENQVTE1OiBmb3VuZCByZWRp
c3RyaWJ1dG9yIGYgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMzIwMDAwDQpbICAgIDEuNTYwNTY4XSAt
LS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41NjA1NzNdIFdBUk5J
Tkc6IENQVTogMTUgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMw
NjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTYwNTc0XSBNb2R1bGVzIGxpbmtl
ZCBpbjoNClsgICAgMS41NjA1NzhdIENQVTogMTUgUElEOiAwIENvbW06IHN3YXBwZXIvMTUgVGFp
bnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzEN
ClsgICAgMS41NjA1ODBdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRD
TyBCVFlQRT0tLSkNClsgICAgMS41NjA1ODJdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIw
DQpbICAgIDEuNTYwNTgzXSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjU2
MDU4NF0gc3AgOiBmZmZmODAwMDExYWFiZTgwDQpbICAgIDEuNTYwNTg1XSB4Mjk6IGZmZmY4MDAw
MTFhYWJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDBmIA0KWyAgICAxLjU2MDU4N10geDI3OiAwMDAw
MDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjFlMDA3MCANClsgICAgMS41NjA1ODldIHgyNTog
ZmZmZmZlMWZmZGVhMDQwMCB4MjQ6IGZmZmY4MDAwMTIxZTAwMDAgDQpbICAgIDEuNTYwNTkxXSB4
MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjU2MDU5
M10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41
NjA1OTVdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAg
IDEuNTYwNTk3XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0K
WyAgICAxLjU2MDU5OV0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAx
MCANClsgICAgMS41NjA2MDFdIHgxMzogZmZmZjgwMDAxMTZkNGNmNSB4MTI6IDAwMDAwMDAwMDAw
MDAwMDAgDQpbICAgIDEuNTYwNjAzXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAw
MDAwMDAwMDAxIA0KWyAgICAxLjU2MDYwNV0geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDogMzAz
MDMwMzIzMzMwMzAzMSANClsgICAgMS41NjA2MDddIHg3IDogMzAzMDMxMzAzMDMwMzA3OCB4NiA6
IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTYwNjA4XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAg
eDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjU2MDYxMF0geDMgOiAwMDAwMDAwMDAwMDAw
MDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS41NjA2MTJdIHgxIDogMDAwMDAwMDAw
MDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTYwNjE0XSBDYWxsIHRyYWNl
Og0KWyAgICAxLjU2MDYxNl0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU2MDYx
OV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTYwNjIyXSAgY3B1aHBfaW52
b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41NjA2MjRdICBub3RpZnlfY3B1X3N0YXJ0
aW5nKzB4YTAvMHhlMA0KWyAgICAxLjU2MDYyNl0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhl
OC8weDE5MA0KWyAgICAxLjU2MDYyOF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2MSBd
LS0tDQpbICAgIDEuNTYwNjM1XSBHSUN2MzogQ1BVMTU6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVu
ZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyODEwMDAwDQpbICAgIDEuNTYwNzA0XSBhcmNoX3RpbWVy
OiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAg
IDEuNTYwNzE0XSBYZW46IGluaXRpYWxpemluZyBjcHUxNQ0KWyAgICAxLjU2MDczOF0gQ1BVMTU6
IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDAwZiBbMHg0MTNmZDBjMV0NClsg
ICAgMS41NjEwOTldIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxNg0KWyAgICAxLjU2MTE1
OV0gR0lDdjM6IENQVTE2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwMCByZWdpb24gMDoweDAwMDAx
MDAxMDAzNDAwMDANClsgICAgMS41Njc3ODJdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0t
LS0tLS0tLQ0KWyAgICAxLjU2Nzc4Nl0gV0FSTklORzogQ1BVOiAxNiBQSUQ6IDAgYXQgZHJpdmVy
cy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjAN
ClsgICAgMS41Njc3ODddIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjU2Nzc5MV0gQ1BVOiAx
NiBQSUQ6IDAgQ29tbTogc3dhcHBlci8xNiBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4x
MC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjU2Nzc5M10gcHN0YXRlOiA2MDAw
MDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjU2Nzc5NV0g
cGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41Njc3OTddIGxyIDogaXRzX2Nw
dV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTY3Nzk4XSBzcCA6IGZmZmY4MDAwMTFhYjNlODAN
ClsgICAgMS41Njc3OTldIHgyOTogZmZmZjgwMDAxMWFiM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAw
MTAgDQpbICAgIDEuNTY3ODAxXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEy
MjAwMDcwIA0KWyAgICAxLjU2NzgwM10geDI1OiBmZmZmZmUxZmZkZWEwODAwIHgyNDogZmZmZjgw
MDAxMjIwMDAwMCANClsgICAgMS41Njc4MDVdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZm
ZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTY3ODA3XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIw
OiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjU2NzgwOV0geDE5OiBmZmZmODAwMDExNjIyMDAw
IHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41Njc4MTFdIHgxNzogMDAwMDAwMDAwMDAw
MDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTY3ODEzXSB4MTU6IGZmZmY4MDAw
MTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjU2NzgxNV0geDEzOiBmZmZm
ODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41Njc4MTddIHgxMTog
MDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTY3ODE5XSB4
OSA6IGZmZmY4MDAwMTA2ZDY0ZjAgeDggOiAzMDM0MzMzMDMwMzEzMDMwIA0KWyAgICAxLjU2Nzgy
MV0geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41
Njc4MjNdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAg
IDEuNTY3ODI1XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0K
WyAgICAxLjU2NzgyNl0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZl
ZCANClsgICAgMS41Njc4MjhdIENhbGwgdHJhY2U6DQpbICAgIDEuNTY3ODMwXSAgaXRzX2NwdV9p
bml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTY3ODMzXSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4
OTANClsgICAgMS41Njc4MzVdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAg
ICAxLjU2NzgzN10gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTY3ODQw
XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTY3ODQxXSAtLS1b
IGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjYyIF0tLS0NClsgICAgMS41Njc4NDddIEdJQ3YzOiBD
UFUxNjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4MjAw
MDANClsgICAgMS41Njc5MjNdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQg
Zm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41Njc5MzJdIFhlbjogaW5pdGlhbGl6aW5n
IGNwdTE2DQpbICAgIDEuNTY3OTU4XSBDUFUxNjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3Ig
MHgwMDAwMDAwMTAwIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjU2ODMwNV0gRGV0ZWN0ZWQgUElQVCBJ
LWNhY2hlIG9uIENQVTE3DQpbICAgIDEuNTY4MzY2XSBHSUN2MzogQ1BVMTc6IGZvdW5kIHJlZGlz
dHJpYnV0b3IgMTAxIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDM2MDAwMA0KWyAgICAxLjU3NDk4OV0g
LS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTc0OTk1XSBXQVJO
SU5HOiBDUFU6IDE3IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzoz
MDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU3NDk5Nl0gTW9kdWxlcyBsaW5r
ZWQgaW46DQpbICAgIDEuNTc1MDAwXSBDUFU6IDE3IFBJRDogMCBDb21tOiBzd2FwcGVyLzE3IFRh
aW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMx
DQpbICAgIDEuNTc1MDAyXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1U
Q08gQlRZUEU9LS0pDQpbICAgIDEuNTc1MDA0XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIy
MA0KWyAgICAxLjU3NTAwNl0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41
NzUwMDddIHNwIDogZmZmZjgwMDAxMWFiYmU4MA0KWyAgICAxLjU3NTAwOF0geDI5OiBmZmZmODAw
MDExYWJiZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxMSANClsgICAgMS41NzUwMTBdIHgyNzogMDAw
MDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIyMjAwNzAgDQpbICAgIDEuNTc1MDEzXSB4MjU6
IGZmZmZmZTFmZmRlYTBjMDAgeDI0OiBmZmZmODAwMDEyMjIwMDAwIA0KWyAgICAxLjU3NTAxNF0g
eDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41NzUw
MTZdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEu
NTc1MDE4XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAg
ICAxLjU3NTAyMF0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS41NzUwMjJdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAw
MTAgDQpbICAgIDEuNTc1MDI0XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAw
MDAwMDAwIA0KWyAgICAxLjU3NTAyNl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAw
MDAwMDAwMDAwMSANClsgICAgMS41NzUwMjhdIHg5IDogZmZmZjgwMDAxMDZkNjRmMCB4OCA6IDMw
MzYzMzMwMzAzMTMwMzAgDQpbICAgIDEuNTc1MDMwXSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYg
OiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjU3NTAzMl0geDUgOiAwMDAwMDAwMDAwMDAwMDAw
IHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41NzUwMzRdIHgzIDogMDAwMDAwMDAwMDAw
MDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTc1MDM1XSB4MSA6IDAwMDAwMDAw
MDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjU3NTAzOF0gQ2FsbCB0cmFj
ZToNClsgICAgMS41NzUwMzldICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NzUw
NDJdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjU3NTA0NV0gIGNwdWhwX2lu
dm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTc1MDQ3XSAgbm90aWZ5X2NwdV9zdGFy
dGluZysweGEwLzB4ZTANClsgICAgMS41NzUwNTBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4
ZTgvMHgxOTANClsgICAgMS41NzUwNTFdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNjMg
XS0tLQ0KWyAgICAxLjU3NTA1N10gR0lDdjM6IENQVTE3OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjgzMDAwMA0KWyAgICAxLjU3NTEyN10gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAg
ICAxLjU3NTEzNl0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTcNClsgICAgMS41NzUxNjFdIENQVTE3
OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMDEgWzB4NDEzZmQwYzFdDQpb
ICAgIDEuNTc1NDI1XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTgNClsgICAgMS41NzU0
OTBdIEdJQ3YzOiBDUFUxODogZm91bmQgcmVkaXN0cmlidXRvciAxMDIgcmVnaW9uIDA6MHgwMDAw
MTAwMTAwMzgwMDAwDQpbICAgIDEuNTgyMTE0XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0t
LS0tLS0tLS0NClsgICAgMS41ODIxMThdIFdBUk5JTkc6IENQVTogMTggUElEOiAwIGF0IGRyaXZl
cnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIw
DQpbICAgIDEuNTgyMTE5XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41ODIxMjNdIENQVTog
MTggUElEOiAwIENvbW06IHN3YXBwZXIvMTggVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUu
MTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS41ODIxMjVdIHBzdGF0ZTogNjAw
MDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41ODIxMjdd
IHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTgyMTI4XSBsciA6IGl0c19j
cHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjU4MjEyOV0gc3AgOiBmZmZmODAwMDExYWMzZTgw
DQpbICAgIDEuNTgyMTMwXSB4Mjk6IGZmZmY4MDAwMTFhYzNlODAgeDI4OiAwMDAwMDAwMDAwMDAw
MDEyIA0KWyAgICAxLjU4MjEzMl0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAx
MjI0MDA3MCANClsgICAgMS41ODIxMzVdIHgyNTogZmZmZmZlMWZmZGVhMTAwMCB4MjQ6IGZmZmY4
MDAwMTIyNDAwMDAgDQpbICAgIDEuNTgyMTM3XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBm
ZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjU4MjEzOF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgy
MDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41ODIxNDFdIHgxOTogZmZmZjgwMDAxMTYyMjAw
MCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTgyMTQzXSB4MTc6IDAwMDAwMDAwMDAw
MDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU4MjE0NF0geDE1OiBmZmZmODAw
MDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41ODIxNDZdIHgxMzogZmZm
ZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTgyMTQ4XSB4MTE6
IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjU4MjE1MF0g
eDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDogMzAzODMzMzAzMDMxMzAzMCANClsgICAgMS41ODIx
NTJdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEu
NTgyMTU0XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAg
ICAxLjU4MjE1Nl0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiAN
ClsgICAgMS41ODIxNThdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZm
ZWQgDQpbICAgIDEuNTgyMTYwXSBDYWxsIHRyYWNlOg0KWyAgICAxLjU4MjE2Ml0gIGl0c19jcHVf
aW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU4MjE2NV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8w
eDkwDQpbICAgIDEuNTgyMTY3XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsg
ICAgMS41ODIxNjldICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjU4MjE3
Ml0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjU4MjE3M10gLS0t
WyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2NCBdLS0tDQpbICAgIDEuNTgyMTgwXSBHSUN2Mzog
Q1BVMTg6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyODQw
MDAwDQpbICAgIDEuNTgyMjU1XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5k
IGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTgyMjY1XSBYZW46IGluaXRpYWxpemlu
ZyBjcHUxOA0KWyAgICAxLjU4MjI5MV0gQ1BVMTg6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29y
IDB4MDAwMDAwMDEwMiBbMHg0MTNmZDBjMV0NClsgICAgMS41ODI2NTRdIERldGVjdGVkIFBJUFQg
SS1jYWNoZSBvbiBDUFUxOQ0KWyAgICAxLjU4MjcyMF0gR0lDdjM6IENQVTE5OiBmb3VuZCByZWRp
c3RyaWJ1dG9yIDEwMyByZWdpb24gMDoweDAwMDAxMDAxMDAzYTAwMDANClsgICAgMS41ODkzNDNd
IC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjU4OTM0OF0gV0FS
TklORzogQ1BVOiAxOSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6
MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41ODkzNDldIE1vZHVsZXMgbGlu
a2VkIGluOg0KWyAgICAxLjU4OTM1M10gQ1BVOiAxOSBQSUQ6IDAgQ29tbTogc3dhcHBlci8xOSBU
YWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAj
MQ0KWyAgICAxLjU4OTM1Nl0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAt
VENPIEJUWVBFPS0tKQ0KWyAgICAxLjU4OTM1N10gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhi
MjANClsgICAgMS41ODkzNTldIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEu
NTg5MzYwXSBzcCA6IGZmZmY4MDAwMTFhY2JlODANClsgICAgMS41ODkzNjFdIHgyOTogZmZmZjgw
MDAxMWFjYmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTMgDQpbICAgIDEuNTg5MzYzXSB4Mjc6IDAw
MDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMjYwMDcwIA0KWyAgICAxLjU4OTM2NV0geDI1
OiBmZmZmZmUxZmZkZWExNDAwIHgyNDogZmZmZjgwMDAxMjI2MDAwMCANClsgICAgMS41ODkzNjdd
IHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTg5
MzY5XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAx
LjU4OTM3MV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsg
ICAgMS41ODkzNzNdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAg
DQpbICAgIDEuNTg5Mzc1XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAw
MDEwIA0KWyAgICAxLjU4OTM3N10geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAw
MDAwMDAwMCANClsgICAgMS41ODkzNzldIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAw
MDAwMDAwMDAwMDEgDQpbICAgIDEuNTg5MzgxXSB4OSA6IGZmZmY4MDAwMTA2ZDY0ZjAgeDggOiAz
MDYxMzMzMDMwMzEzMDMwIA0KWyAgICAxLjU4OTM4M10geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2
IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41ODkzODVdIHg1IDogMDAwMDAwMDAwMDAwMDAw
MCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTg5Mzg3XSB4MyA6IDAwMDAwMDAwMDAw
MDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjU4OTM4OV0geDEgOiAwMDAwMDAw
MDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41ODkzOTFdIENhbGwgdHJh
Y2U6DQpbICAgIDEuNTg5MzkyXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTg5
Mzk1XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41ODkzOThdICBjcHVocF9p
bnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU4OTQwMF0gIG5vdGlmeV9jcHVfc3Rh
cnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTg5NDAzXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsw
eGU4LzB4MTkwDQpbICAgIDEuNTg5NDA0XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjY1
IF0tLS0NClsgICAgMS41ODk0MTBdIEdJQ3YzOiBDUFUxOTogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4NTAwMDANClsgICAgMS41ODk0ODFdIGFyY2hfdGlt
ZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsg
ICAgMS41ODk0OTBdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTE5DQpbICAgIDEuNTg5NTE1XSBDUFUx
OTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTAzIFsweDQxM2ZkMGMxXQ0K
WyAgICAxLjU4OTg5Ml0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTIwDQpbICAgIDEuNTg5
OTYxXSBHSUN2MzogQ1BVMjA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTA0IHJlZ2lvbiAwOjB4MDAw
MDEwMDEwMDNjMDAwMA0KWyAgICAxLjU5NjU4NV0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0t
LS0tLS0tLS0tDQpbICAgIDEuNTk2NTg5XSBXQVJOSU5HOiBDUFU6IDIwIFBJRDogMCBhdCBkcml2
ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIy
MA0KWyAgICAxLjU5NjU5MF0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTk2NTk0XSBDUFU6
IDIwIFBJRDogMCBDb21tOiBzd2FwcGVyLzIwIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1
LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTk2NTk2XSBwc3RhdGU6IDYw
MDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNTk2NTk4
XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU5NjYwMF0gbHIgOiBpdHNf
Y3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41OTY2MDFdIHNwIDogZmZmZjgwMDAxMWFkM2U4
MA0KWyAgICAxLjU5NjYwMl0geDI5OiBmZmZmODAwMDExYWQzZTgwIHgyODogMDAwMDAwMDAwMDAw
MDAxNCANClsgICAgMS41OTY2MDRdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAw
MTIyODAwNzAgDQpbICAgIDEuNTk2NjA2XSB4MjU6IGZmZmZmZTFmZmRlYTE4MDAgeDI0OiBmZmZm
ODAwMDEyMjgwMDAwIA0KWyAgICAxLjU5NjYwOV0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjog
ZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41OTY2MTFdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4
MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTk2NjEzXSB4MTk6IGZmZmY4MDAwMTE2MjIw
MDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjU5NjYxNV0geDE3OiAwMDAwMDAwMDAw
MDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41OTY2MTddIHgxNTogZmZmZjgw
MDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTk2NjE5XSB4MTM6IGZm
ZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU5NjYyMV0geDEx
OiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41OTY2MjNd
IHg5IDogZmZmZjgwMDAxMDZkNjRmMCB4OCA6IDMwNjMzMzMwMzAzMTMwMzAgDQpbICAgIDEuNTk2
NjI1XSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAx
LjU5NjYyN10geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsg
ICAgMS41OTY2MjldIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYg
DQpbICAgIDEuNTk2NjMxXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZm
ZmVkIA0KWyAgICAxLjU5NjYzM10gQ2FsbCB0cmFjZToNClsgICAgMS41OTY2MzVdICBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41OTY2MzddICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgv
MHg5MA0KWyAgICAxLjU5NjY0MF0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpb
ICAgIDEuNTk2NjQyXSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS41OTY2
NDRdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41OTY2NDZdIC0t
LVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNjYgXS0tLQ0KWyAgICAxLjU5NjY1Ml0gR0lDdjM6
IENQVTIwOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjg2
MDAwMA0KWyAgICAxLjU5NjczMF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3Vu
ZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjU5NjczOV0gWGVuOiBpbml0aWFsaXpp
bmcgY3B1MjANClsgICAgMS41OTY3NjhdIENQVTIwOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3Nv
ciAweDAwMDAwMDAxMDQgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTk3MTE3XSBEZXRlY3RlZCBQSVBU
IEktY2FjaGUgb24gQ1BVMjENClsgICAgMS41OTcxODddIEdJQ3YzOiBDUFUyMTogZm91bmQgcmVk
aXN0cmlidXRvciAxMDUgcmVnaW9uIDA6MHgwMDAwMTAwMTAwM2UwMDAwDQpbICAgIDEuNjAzODEx
XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS42MDM4MTVdIFdB
Uk5JTkc6IENQVTogMjEgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5j
OjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjAzODE3XSBNb2R1bGVzIGxp
bmtlZCBpbjoNClsgICAgMS42MDM4MjFdIENQVTogMjEgUElEOiAwIENvbW06IHN3YXBwZXIvMjEg
VGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsg
IzENClsgICAgMS42MDM4MjNdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8g
LVRDTyBCVFlQRT0tLSkNClsgICAgMS42MDM4MjVdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNjAzODI2XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAx
LjYwMzgyN10gc3AgOiBmZmZmODAwMDExYWRiZTgwDQpbICAgIDEuNjAzODI4XSB4Mjk6IGZmZmY4
MDAwMTFhZGJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDE1IA0KWyAgICAxLjYwMzgzMV0geDI3OiAw
MDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjJhMDA3MCANClsgICAgMS42MDM4MzNdIHgy
NTogZmZmZmZlMWZmZGVhMWMwMCB4MjQ6IGZmZmY4MDAwMTIyYTAwMDAgDQpbICAgIDEuNjAzODM1
XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjYw
MzgzN10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAg
MS42MDM4MzldIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpb
ICAgIDEuNjAzODQxXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAw
IA0KWyAgICAxLjYwMzg0M10geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAw
MDAxMCANClsgICAgMS42MDM4NDVdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAw
MDAwMDAwMDAgDQpbICAgIDEuNjAzODQ3XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAw
MDAwMDAwMDAwMDAxIA0KWyAgICAxLjYwMzg0OV0geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDog
MzA2NTMzMzAzMDMxMzAzMCANClsgICAgMS42MDM4NTFdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4
NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjAzODUzXSB4NSA6IDAwMDAwMDAwMDAwMDAw
MDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjYwMzg1NF0geDMgOiAwMDAwMDAwMDAw
MDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42MDM4NTZdIHgxIDogMDAwMDAw
MDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNjAzODU4XSBDYWxsIHRy
YWNlOg0KWyAgICAxLjYwMzg2MF0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYw
Mzg2NF0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNjAzODY2XSAgY3B1aHBf
aW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42MDM4NjhdICBub3RpZnlfY3B1X3N0
YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjYwMzg3MV0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwr
MHhlOC8weDE5MA0KWyAgICAxLjYwMzg3M10gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2
NyBdLS0tDQpbICAgIDEuNjAzODc5XSBHSUN2MzogQ1BVMjE6IHVzaW5nIGFsbG9jYXRlZCBMUEkg
cGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyODcwMDAwDQpbICAgIDEuNjAzOTQ4XSBhcmNoX3Rp
bWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpb
ICAgIDEuNjAzOTU3XSBYZW46IGluaXRpYWxpemluZyBjcHUyMQ0KWyAgICAxLjYwMzk4Ml0gQ1BV
MjE6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwNSBbMHg0MTNmZDBjMV0N
ClsgICAgMS42MDQyNTFdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMg0KWyAgICAxLjYw
NDMyNV0gR0lDdjM6IENQVTIyOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwNiByZWdpb24gMDoweDAw
MDAxMDAxMDA0MDAwMDANClsgICAgMS42MTA5NDldIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0t
LS0tLS0tLS0tLQ0KWyAgICAxLjYxMDk1NF0gV0FSTklORzogQ1BVOiAyMiBQSUQ6IDAgYXQgZHJp
dmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhi
MjANClsgICAgMS42MTA5NTVdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjYxMDk1OV0gQ1BV
OiAyMiBQSUQ6IDAgQ29tbTogc3dhcHBlci8yMiBUYWludGVkOiBHICAgICAgICBXICAgICAgICAg
NS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjYxMDk2MV0gcHN0YXRlOiA2
MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjYxMDk2
Ml0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MTA5NjRdIGxyIDogaXRz
X2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjEwOTY1XSBzcCA6IGZmZmY4MDAwMTFhZTNl
ODANClsgICAgMS42MTA5NjZdIHgyOTogZmZmZjgwMDAxMWFlM2U4MCB4Mjg6IDAwMDAwMDAwMDAw
MDAwMTYgDQpbICAgIDEuNjEwOTY4XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAw
MDEyMmMwMDcwIA0KWyAgICAxLjYxMDk3MF0geDI1OiBmZmZmZmUxZmZkZWEyMDAwIHgyNDogZmZm
ZjgwMDAxMjJjMDAwMCANClsgICAgMS42MTA5NzJdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6
IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNjEwOTc0XSB4MjE6IGZmZmY4MDAwMTE3Njg5Zjgg
eDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjYxMDk3Nl0geDE5OiBmZmZmODAwMDExNjIy
MDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS42MTA5NzhdIHgxNzogMDAwMDAwMDAw
MDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjEwOTc5XSB4MTU6IGZmZmY4
MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjYxMDk4MV0geDEzOiBm
ZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42MTA5ODNdIHgx
MTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjEwOTg1
XSB4OSA6IGZmZmY4MDAwMTA2ZDY0ZjAgeDggOiAzMDMwMzQzMDMwMzEzMDMwIA0KWyAgICAxLjYx
MDk4N10geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAg
MS42MTA5ODldIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpb
ICAgIDEuNjEwOTkwXSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZm
IA0KWyAgICAxLjYxMDk5Ml0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZm
ZmZlZCANClsgICAgMS42MTA5OTVdIENhbGwgdHJhY2U6DQpbICAgIDEuNjEwOTk2XSAgaXRzX2Nw
dV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjEwOTk5XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4
LzB4OTANClsgICAgMS42MTEwMDJdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0K
WyAgICAxLjYxMTAwNF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNjEx
MDA2XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNjExMDA3XSAt
LS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjY4IF0tLS0NClsgICAgMS42MTEwMTRdIEdJQ3Yz
OiBDUFUyMjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4
ODAwMDANClsgICAgMS42MTEwOTBdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91
bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS42MTEwOTldIFhlbjogaW5pdGlhbGl6
aW5nIGNwdTIyDQpbICAgIDEuNjExMTI4XSBDUFUyMjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNz
b3IgMHgwMDAwMDAwMTA2IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjYxMTM5Ml0gRGV0ZWN0ZWQgUElQ
VCBJLWNhY2hlIG9uIENQVTIzDQpbICAgIDEuNjExNDY4XSBHSUN2MzogQ1BVMjM6IGZvdW5kIHJl
ZGlzdHJpYnV0b3IgMTA3IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDQyMDAwMA0KWyAgICAxLjYxODA5
Ml0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNjE4MDk3XSBX
QVJOSU5HOiBDUFU6IDIzIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMu
YzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYxODA5OF0gTW9kdWxlcyBs
aW5rZWQgaW46DQpbICAgIDEuNjE4MTAyXSBDUFU6IDIzIFBJRDogMCBDb21tOiBzd2FwcGVyLzIz
IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQr
ICMxDQpbICAgIDEuNjE4MTA1XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFP
IC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNjE4MTA2XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8w
eGIyMA0KWyAgICAxLjYxODEwOF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAg
MS42MTgxMDldIHNwIDogZmZmZjgwMDAxMWFlYmU4MA0KWyAgICAxLjYxODExMF0geDI5OiBmZmZm
ODAwMDExYWViZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxNyANClsgICAgMS42MTgxMTJdIHgyNzog
MDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIyZTAwNzAgDQpbICAgIDEuNjE4MTE0XSB4
MjU6IGZmZmZmZTFmZmRlYTI0MDAgeDI0OiBmZmZmODAwMDEyMmUwMDAwIA0KWyAgICAxLjYxODEx
Nl0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS42
MTgxMThdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAg
IDEuNjE4MTIwXSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0K
WyAgICAxLjYxODEyMl0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAw
MCANClsgICAgMS42MTgxMjRdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAw
MDAwMTAgDQpbICAgIDEuNjE4MTI2XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAw
MDAwMDAwMDAwIA0KWyAgICAxLjYxODEyN10geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAw
MDAwMDAwMDAwMDAwMSANClsgICAgMS42MTgxMzBdIHg5IDogZmZmZjgwMDAxMDZkNjRmMCB4OCA6
IDMwMzIzNDMwMzAzMTMwMzAgDQpbICAgIDEuNjE4MTMyXSB4NyA6IDMxMzAzMDMwMzA3ODMwM2Eg
eDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjYxODEzM10geDUgOiAwMDAwMDAwMDAwMDAw
MDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS42MTgxMzVdIHgzIDogMDAwMDAwMDAw
MDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjE4MTM3XSB4MSA6IDAwMDAw
MDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjYxODEzOV0gQ2FsbCB0
cmFjZToNClsgICAgMS42MTgxNDFdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42
MTgxNDRdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjYxODE0N10gIGNwdWhw
X2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjE4MTQ5XSAgbm90aWZ5X2NwdV9z
dGFydGluZysweGEwLzB4ZTANClsgICAgMS42MTgxNTFdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVs
KzB4ZTgvMHgxOTANClsgICAgMS42MTgxNTJdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNi
NjkgXS0tLQ0KWyAgICAxLjYxODE1OV0gR0lDdjM6IENQVTIzOiB1c2luZyBhbGxvY2F0ZWQgTFBJ
IHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjg5MDAwMA0KWyAgICAxLjYxODIyOF0gYXJjaF90
aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0K
WyAgICAxLjYxODIzN10gWGVuOiBpbml0aWFsaXppbmcgY3B1MjMNClsgICAgMS42MTgyNjNdIENQ
VTIzOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMDcgWzB4NDEzZmQwYzFd
DQpbICAgIDEuNjE4NjM0XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjQNClsgICAgMS42
MTg3MTRdIEdJQ3YzOiBDUFUyNDogZm91bmQgcmVkaXN0cmlidXRvciAxMDggcmVnaW9uIDA6MHgw
MDAwMTAwMTAwNDQwMDAwDQpbICAgIDEuNjI1MzM4XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0t
LS0tLS0tLS0tLS0NClsgICAgMS42MjUzNDNdIFdBUk5JTkc6IENQVTogMjQgUElEOiAwIGF0IGRy
aXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNjI1MzQ1XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS42MjUzNDldIENQ
VTogMjQgUElEOiAwIENvbW06IHN3YXBwZXIvMjQgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAg
IDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS42MjUzNTFdIHBzdGF0ZTog
NjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS42MjUz
NTNdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjI1MzU0XSBsciA6IGl0
c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjYyNTM1NV0gc3AgOiBmZmZmODAwMDExYWYz
ZTgwDQpbICAgIDEuNjI1MzU2XSB4Mjk6IGZmZmY4MDAwMTFhZjNlODAgeDI4OiAwMDAwMDAwMDAw
MDAwMDE4IA0KWyAgICAxLjYyNTM1OV0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgw
MDAxMjMwMDA3MCANClsgICAgMS42MjUzNjFdIHgyNTogZmZmZmZlMWZmZGVhMjgwMCB4MjQ6IGZm
ZmY4MDAwMTIzMDAwMDAgDQpbICAgIDEuNjI1MzY0XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIy
OiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjYyNTM2NV0geDIxOiBmZmZmODAwMDExNzY4OWY4
IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42MjUzNjddIHgxOTogZmZmZjgwMDAxMTYy
MjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjI1MzY5XSB4MTc6IDAwMDAwMDAw
MDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYyNTM3MV0geDE1OiBmZmZm
ODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS42MjUzNzNdIHgxMzog
ZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjI1Mzc1XSB4
MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjYyNTM3
N10geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDogMzAzNDM0MzAzMDMxMzAzMCANClsgICAgMS42
MjUzNzldIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAg
IDEuNjI1MzgxXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0K
WyAgICAxLjYyNTM4M10geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZm
ZiANClsgICAgMS42MjUzODVdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZm
ZmZmZWQgDQpbICAgIDEuNjI1Mzg3XSBDYWxsIHRyYWNlOg0KWyAgICAxLjYyNTM4OV0gIGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYyNTM5MV0gIGdpY19zdGFydGluZ19jcHUrMHg0
OC8weDkwDQpbICAgIDEuNjI1Mzk0XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjAN
ClsgICAgMS42MjUzOTZdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjYy
NTM5OF0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjYyNTQwMF0g
LS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2YSBdLS0tDQpbICAgIDEuNjI1NDA2XSBHSUN2
MzogQ1BVMjQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAy
OGEwMDAwDQpbICAgIDEuNjI1NDgyXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJv
dW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjI1NDkxXSBYZW46IGluaXRpYWxp
emluZyBjcHUyNA0KWyAgICAxLjYyNTUyMF0gQ1BVMjQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vz
c29yIDB4MDAwMDAwMDEwOCBbMHg0MTNmZDBjMV0NClsgICAgMS42MjU4ODddIERldGVjdGVkIFBJ
UFQgSS1jYWNoZSBvbiBDUFUyNQ0KWyAgICAxLjYyNTk2N10gR0lDdjM6IENQVTI1OiBmb3VuZCBy
ZWRpc3RyaWJ1dG9yIDEwOSByZWdpb24gMDoweDAwMDAxMDAxMDA0NjAwMDANClsgICAgMS42MzI1
OTJdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjYzMjU5N10g
V0FSTklORzogQ1BVOiAyNSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRz
LmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MzI1OTldIE1vZHVsZXMg
bGlua2VkIGluOg0KWyAgICAxLjYzMjYwM10gQ1BVOiAyNSBQSUQ6IDAgQ29tbTogc3dhcHBlci8y
NSBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJk
KyAjMQ0KWyAgICAxLjYzMjYwNV0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVB
TyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjYzMjYwN10gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMS42MzI2MDhdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAg
IDEuNjMyNjA5XSBzcCA6IGZmZmY4MDAwMTFhZmJlODANClsgICAgMS42MzI2MTBdIHgyOTogZmZm
ZjgwMDAxMWFmYmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTkgDQpbICAgIDEuNjMyNjEzXSB4Mjc6
IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMzIwMDcwIA0KWyAgICAxLjYzMjYxNV0g
eDI1OiBmZmZmZmUxZmZkZWEyYzAwIHgyNDogZmZmZjgwMDAxMjMyMDAwMCANClsgICAgMS42MzI2
MTddIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEu
NjMyNjE5XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAg
ICAxLjYzMjYyMV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiAN
ClsgICAgMS42MzI2MjNdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAw
MDAgDQpbICAgIDEuNjMyNjI1XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAw
MDAwMDEwIA0KWyAgICAxLjYzMjYyN10geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAw
MDAwMDAwMDAwMCANClsgICAgMS42MzI2MjldIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAw
MDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjMyNjMxXSB4OSA6IGZmZmY4MDAwMTA2ZDY0ZjAgeDgg
OiAzMDM2MzQzMDMwMzEzMDMwIA0KWyAgICAxLjYzMjYzM10geDcgOiAzMTMwMzAzMDMwNzgzMDNh
IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS42MzI2MzVdIHg1IDogMDAwMDAwMDAwMDAw
MDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNjMyNjM3XSB4MyA6IDAwMDAwMDAw
MDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjYzMjYzOV0geDEgOiAwMDAw
MDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS42MzI2NDFdIENhbGwg
dHJhY2U6DQpbICAgIDEuNjMyNjQyXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEu
NjMyNjQ1XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS42MzI2NDhdICBjcHVo
cF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjYzMjY1MF0gIG5vdGlmeV9jcHVf
c3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNjMyNjUzXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5l
bCsweGU4LzB4MTkwDQpbICAgIDEuNjMyNjU0XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUz
YjZiIF0tLS0NClsgICAgMS42MzI2NjFdIEdJQ3YzOiBDUFUyNTogdXNpbmcgYWxsb2NhdGVkIExQ
SSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4YjAwMDANClsgICAgMS42MzI3MzFdIGFyY2hf
dGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAN
ClsgICAgMS42MzI3NDBdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTI1DQpbICAgIDEuNjMyNzY2XSBD
UFUyNTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTA5IFsweDQxM2ZkMGMx
XQ0KWyAgICAxLjYzMzEyMF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI2DQpbICAgIDEu
NjMzMjAwXSBHSUN2MzogQ1BVMjY6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTBhIHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDQ4MDAwMA0KWyAgICAxLjYzOTgyMV0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBd
LS0tLS0tLS0tLS0tDQpbICAgIDEuNjM5ODI1XSBXQVJOSU5HOiBDUFU6IDI2IFBJRDogMCBhdCBk
cml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8w
eGIyMA0KWyAgICAxLjYzOTgyNl0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNjM5ODMwXSBD
UFU6IDI2IFBJRDogMCBDb21tOiBzd2FwcGVyLzI2IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAg
ICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNjM5ODMyXSBwc3RhdGU6
IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNjM5
ODM0XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYzOTgzNl0gbHIgOiBp
dHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS42Mzk4MzddIHNwIDogZmZmZjgwMDAxMWIw
M2U4MA0KWyAgICAxLjYzOTgzOF0geDI5OiBmZmZmODAwMDExYjAzZTgwIHgyODogMDAwMDAwMDAw
MDAwMDAxYSANClsgICAgMS42Mzk4NDBdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4
MDAwMTIzNDAwNzAgDQpbICAgIDEuNjM5ODQyXSB4MjU6IGZmZmZmZTFmZmRlYTMwMDAgeDI0OiBm
ZmZmODAwMDEyMzQwMDAwIA0KWyAgICAxLjYzOTg0NF0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgy
MjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS42Mzk4NDddIHgyMTogZmZmZjgwMDAxMTc2ODlm
OCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNjM5ODQ5XSB4MTk6IGZmZmY4MDAwMTE2
MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjYzOTg1MV0geDE3OiAwMDAwMDAw
MDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42Mzk4NTNdIHgxNTogZmZm
ZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNjM5ODU1XSB4MTM6
IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYzOTg1N10g
eDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS42Mzk4
NThdIHg5IDogZmZmZjgwMDAxMDZkNjRmMCB4OCA6IDMwMzgzNDMwMzAzMTMwMzAgDQpbICAgIDEu
NjM5ODYwXSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAg
ICAxLjYzOTg2Ml0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCAN
ClsgICAgMS42Mzk4NjRdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZm
ZmYgDQpbICAgIDEuNjM5ODY2XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZm
ZmZmZmVkIA0KWyAgICAxLjYzOTg2OF0gQ2FsbCB0cmFjZToNClsgICAgMS42Mzk4NzBdICBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42Mzk4NzNdICBnaWNfc3RhcnRpbmdfY3B1KzB4
NDgvMHg5MA0KWyAgICAxLjYzOTg3NV0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYw
DQpbICAgIDEuNjM5ODc3XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS42
Mzk4ODBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS42Mzk4ODFd
IC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNmMgXS0tLQ0KWyAgICAxLjYzOTg4N10gR0lD
djM6IENQVTI2OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAw
MjhjMDAwMA0KWyAgICAxLjYzOTk2Nl0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fy
b3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjYzOTk3NV0gWGVuOiBpbml0aWFs
aXppbmcgY3B1MjYNClsgICAgMS42NDAwMDRdIENQVTI2OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nl
c3NvciAweDAwMDAwMDAxMGEgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjQwMjY4XSBEZXRlY3RlZCBQ
SVBUIEktY2FjaGUgb24gQ1BVMjcNClsgICAgMS42NDAzNTJdIEdJQ3YzOiBDUFUyNzogZm91bmQg
cmVkaXN0cmlidXRvciAxMGIgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNGEwMDAwDQpbICAgIDEuNjQ2
OTc3XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS42NDY5ODFd
IFdBUk5JTkc6IENQVTogMjcgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0
cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjQ2OTgyXSBNb2R1bGVz
IGxpbmtlZCBpbjoNClsgICAgMS42NDY5ODZdIENQVTogMjcgUElEOiAwIENvbW06IHN3YXBwZXIv
MjcgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFy
ZCsgIzENClsgICAgMS42NDY5ODhdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1V
QU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS42NDY5OTBdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDEuNjQ2OTkyXSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAg
ICAxLjY0Njk5Ml0gc3AgOiBmZmZmODAwMDExYjBiZTgwDQpbICAgIDEuNjQ2OTkzXSB4Mjk6IGZm
ZmY4MDAwMTFiMGJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDFiIA0KWyAgICAxLjY0Njk5Nl0geDI3
OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjM2MDA3MCANClsgICAgMS42NDY5OThd
IHgyNTogZmZmZmZlMWZmZGVhMzQwMCB4MjQ6IGZmZmY4MDAwMTIzNjAwMDAgDQpbICAgIDEuNjQ3
MDAwXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAx
LjY0NzAwMl0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsg
ICAgMS42NDcwMDRdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYg
DQpbICAgIDEuNjQ3MDA2XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAw
MDAwIA0KWyAgICAxLjY0NzAwOF0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAw
MDAwMDAxMCANClsgICAgMS42NDcwMTBdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAw
MDAwMDAwMDAwMDAgDQpbICAgIDEuNjQ3MDEyXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAw
MDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjY0NzAxNF0geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4
IDogMzA2MTM0MzAzMDMxMzAzMCANClsgICAgMS42NDcwMTZdIHg3IDogMzEzMDMwMzAzMDc4MzAz
YSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjQ3MDE3XSB4NSA6IDAwMDAwMDAwMDAw
MDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjY0NzAyMF0geDMgOiAwMDAwMDAw
MDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42NDcwMjFdIHgxIDogMDAw
MDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNjQ3MDI0XSBDYWxs
IHRyYWNlOg0KWyAgICAxLjY0NzAyNV0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjY0NzAyOF0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNjQ3MDMxXSAgY3B1
aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42NDcwMzNdICBub3RpZnlfY3B1
X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjY0NzAzNV0gIHNlY29uZGFyeV9zdGFydF9rZXJu
ZWwrMHhlOC8weDE5MA0KWyAgICAxLjY0NzAzNl0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1
M2I2ZCBdLS0tDQpbICAgIDEuNjQ3MDQzXSBHSUN2MzogQ1BVMjc6IHVzaW5nIGFsbG9jYXRlZCBM
UEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyOGQwMDAwDQpbICAgIDEuNjQ3MTEyXSBhcmNo
X3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQw
DQpbICAgIDEuNjQ3MTIyXSBYZW46IGluaXRpYWxpemluZyBjcHUyNw0KWyAgICAxLjY0NzE0OF0g
Q1BVMjc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwYiBbMHg0MTNmZDBj
MV0NClsgICAgMS42NDc0MTFdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyOA0KWyAgICAx
LjY0NzUwMF0gR0lDdjM6IENQVTI4OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwYyByZWdpb24gMDow
eDAwMDAxMDAxMDA0YzAwMDANClsgICAgMS42NTQxMjVdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUg
XS0tLS0tLS0tLS0tLQ0KWyAgICAxLjY1NDEyOV0gV0FSTklORzogQ1BVOiAyOCBQSUQ6IDAgYXQg
ZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMS42NTQxMzBdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjY1NDEzNF0g
Q1BVOiAyOCBQSUQ6IDAgQ29tbTogc3dhcHBlci8yOCBUYWludGVkOiBHICAgICAgICBXICAgICAg
ICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjY1NDEzN10gcHN0YXRl
OiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjY1
NDEzOF0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NTQxNDBdIGxyIDog
aXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjU0MTQxXSBzcCA6IGZmZmY4MDAwMTFi
MTNlODANClsgICAgMS42NTQxNDJdIHgyOTogZmZmZjgwMDAxMWIxM2U4MCB4Mjg6IDAwMDAwMDAw
MDAwMDAwMWMgDQpbICAgIDEuNjU0MTQ1XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZm
ODAwMDEyMzgwMDcwIA0KWyAgICAxLjY1NDE0N10geDI1OiBmZmZmZmUxZmZkZWEzODAwIHgyNDog
ZmZmZjgwMDAxMjM4MDAwMCANClsgICAgMS42NTQxNDldIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4
MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNjU0MTUxXSB4MjE6IGZmZmY4MDAwMTE3Njg5
ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjY1NDE1M10geDE5OiBmZmZmODAwMDEx
NjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS42NTQxNTVdIHgxNzogMDAwMDAw
MDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjU0MTU3XSB4MTU6IGZm
ZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjY1NDE1OV0geDEz
OiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42NTQxNjFd
IHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjU0
MTYzXSB4OSA6IGZmZmY4MDAwMTA2ZDY0ZjAgeDggOiAzMDYzMzQzMDMwMzEzMDMwIA0KWyAgICAx
LjY1NDE2NV0geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsg
ICAgMS42NTQxNjZdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAg
DQpbICAgIDEuNjU0MTY4XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBm
ZmZmIA0KWyAgICAxLjY1NDE3MF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBm
ZmZmZmZlZCANClsgICAgMS42NTQxNzJdIENhbGwgdHJhY2U6DQpbICAgIDEuNjU0MTc0XSAgaXRz
X2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjU0MTc3XSAgZ2ljX3N0YXJ0aW5nX2NwdSsw
eDQ4LzB4OTANClsgICAgMS42NTQxNzldICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2
MA0KWyAgICAxLjY1NDE4Ml0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEu
NjU0MTg0XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNjU0MTg2
XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjZlIF0tLS0NClsgICAgMS42NTQxOTJdIEdJ
Q3YzOiBDUFUyODogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAw
MDI4ZTAwMDANClsgICAgMS42NTQyNzBdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS42NTQyNzldIFhlbjogaW5pdGlh
bGl6aW5nIGNwdTI4DQpbICAgIDEuNjU0MzA5XSBDUFUyODogQm9vdGVkIHNlY29uZGFyeSBwcm9j
ZXNzb3IgMHgwMDAwMDAwMTBjIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjY1NDY4MV0gRGV0ZWN0ZWQg
UElQVCBJLWNhY2hlIG9uIENQVTI5DQpbICAgIDEuNjU0NzcyXSBHSUN2MzogQ1BVMjk6IGZvdW5k
IHJlZGlzdHJpYnV0b3IgMTBkIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDRlMDAwMA0KWyAgICAxLjY2
MTM5N10gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNjYxNDAy
XSBXQVJOSU5HOiBDUFU6IDI5IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1p
dHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY2MTQwMl0gTW9kdWxl
cyBsaW5rZWQgaW46DQpbICAgIDEuNjYxNDA2XSBDUFU6IDI5IFBJRDogMCBDb21tOiBzd2FwcGVy
LzI5IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRh
cmQrICMxDQpbICAgIDEuNjYxNDA4XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAt
VUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNjYxNDEwXSBwYyA6IGl0c19jcHVfaW5pdCsweDgy
NC8weGIyMA0KWyAgICAxLjY2MTQxMl0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsg
ICAgMS42NjE0MTNdIHNwIDogZmZmZjgwMDAxMWIxYmU4MA0KWyAgICAxLjY2MTQxNF0geDI5OiBm
ZmZmODAwMDExYjFiZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxZCANClsgICAgMS42NjE0MTZdIHgy
NzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIzYTAwNzAgDQpbICAgIDEuNjYxNDE4
XSB4MjU6IGZmZmZmZTFmZmRlYTNjMDAgeDI0OiBmZmZmODAwMDEyM2EwMDAwIA0KWyAgICAxLjY2
MTQyMF0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAg
MS42NjE0MjJdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpb
ICAgIDEuNjYxNDI0XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZm
IA0KWyAgICAxLjY2MTQyNl0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAw
MDAwMCANClsgICAgMS42NjE0MjhdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAw
MDAwMDAwMTAgDQpbICAgIDEuNjYxNDMwXSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAw
MDAwMDAwMDAwMDAwIA0KWyAgICAxLjY2MTQzMl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDog
MDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS42NjE0MzRdIHg5IDogZmZmZjgwMDAxMDZkNjRmMCB4
OCA6IDMwNjUzNDMwMzAzMTMwMzAgDQpbICAgIDEuNjYxNDM2XSB4NyA6IDMxMzAzMDMwMzA3ODMw
M2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjY2MTQzN10geDUgOiAwMDAwMDAwMDAw
MDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS42NjE0MzldIHgzIDogMDAwMDAw
MDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjYxNDQyXSB4MSA6IDAw
MDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjY2MTQ0NF0gQ2Fs
bCB0cmFjZToNClsgICAgMS42NjE0NDVdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS42NjE0NDhdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjY2MTQ1MV0gIGNw
dWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjYxNDUzXSAgbm90aWZ5X2Nw
dV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS42NjE0NTVdICBzZWNvbmRhcnlfc3RhcnRfa2Vy
bmVsKzB4ZTgvMHgxOTANClsgICAgMS42NjE0NTZdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMw
NTNiNmYgXS0tLQ0KWyAgICAxLjY2MTQ2M10gR0lDdjM6IENQVTI5OiB1c2luZyBhbGxvY2F0ZWQg
TFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjhmMDAwMA0KWyAgICAxLjY2MTUzOV0gYXJj
aF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0
MA0KWyAgICAxLjY2MTU0OF0gWGVuOiBpbml0aWFsaXppbmcgY3B1MjkNClsgICAgMS42NjE1Nzhd
IENQVTI5OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMGQgWzB4NDEzZmQw
YzFdDQpbICAgIDEuNjYxOTI2XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMzANClsgICAg
MS42NjIwMThdIEdJQ3YzOiBDUFUzMDogZm91bmQgcmVkaXN0cmlidXRvciAxMGUgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwNTAwMDAwDQpbICAgIDEuNjY4NjQzXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJl
IF0tLS0tLS0tLS0tLS0NClsgICAgMS42Njg2NDhdIFdBUk5JTkc6IENQVTogMzAgUElEOiAwIGF0
IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDEuNjY4NjQ5XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS42Njg2NTNd
IENQVTogMzAgUElEOiAwIENvbW06IHN3YXBwZXIvMzAgVGFpbnRlZDogRyAgICAgICAgVyAgICAg
ICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS42Njg2NTVdIHBzdGF0
ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS42
Njg2NTddIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjY4NjU4XSBsciA6
IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjY2ODY1OV0gc3AgOiBmZmZmODAwMDEx
YjIzZTgwDQpbICAgIDEuNjY4NjYwXSB4Mjk6IGZmZmY4MDAwMTFiMjNlODAgeDI4OiAwMDAwMDAw
MDAwMDAwMDFlIA0KWyAgICAxLjY2ODY2Ml0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZm
ZjgwMDAxMjNjMDA3MCANClsgICAgMS42Njg2NjVdIHgyNTogZmZmZmZlMWZmZGVhNDAwMCB4MjQ6
IGZmZmY4MDAwMTIzYzAwMDAgDQpbICAgIDEuNjY4NjY2XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAg
eDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjY2ODY2OF0geDIxOiBmZmZmODAwMDExNzY4
OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42Njg2NzBdIHgxOTogZmZmZjgwMDAx
MTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjY4NjcyXSB4MTc6IDAwMDAw
MDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjY2ODY3NF0geDE1OiBm
ZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS42Njg2NzZdIHgx
MzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjY4Njc4
XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjY2
ODY4MF0geDkgOiBmZmZmODAwMDEwNmQ2NGYwIHg4IDogMzAzMDM1MzAzMDMxMzAzMCANClsgICAg
MS42Njg2ODJdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpb
ICAgIDEuNjY4Njg0XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAw
IA0KWyAgICAxLjY2ODY4Nl0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAw
ZmZmZiANClsgICAgMS42Njg2ODhdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAw
ZmZmZmZmZWQgDQpbICAgIDEuNjY4NjkxXSBDYWxsIHRyYWNlOg0KWyAgICAxLjY2ODY5Ml0gIGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY2ODY5NV0gIGdpY19zdGFydGluZ19jcHUr
MHg0OC8weDkwDQpbICAgIDEuNjY4Njk4XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0
NjANClsgICAgMS42Njg3MDBdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAx
LjY2ODcwMl0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjY2ODcw
NF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I3MCBdLS0tDQpbICAgIDEuNjY4NzEwXSBH
SUN2MzogQ1BVMzA6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAyOTAwMDAwDQpbICAgIDEuNjY4Nzg5XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3Jr
YXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjY4Nzk4XSBYZW46IGluaXRp
YWxpemluZyBjcHUzMA0KWyAgICAxLjY2ODgyOF0gQ1BVMzA6IEJvb3RlZCBzZWNvbmRhcnkgcHJv
Y2Vzc29yIDB4MDAwMDAwMDEwZSBbMHg0MTNmZDBjMV0NClsgICAgMS42NjkxNjhdIERldGVjdGVk
IFBJUFQgSS1jYWNoZSBvbiBDUFUzMQ0KWyAgICAxLjY2OTI2Ml0gR0lDdjM6IENQVTMxOiBmb3Vu
ZCByZWRpc3RyaWJ1dG9yIDEwZiByZWdpb24gMDoweDAwMDAxMDAxMDA1MjAwMDANClsgICAgMS42
NzU4ODddIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjY3NTg5
Ml0gV0FSTklORzogQ1BVOiAzMSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMt
aXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NzU4OTNdIE1vZHVs
ZXMgbGlua2VkIGluOg0KWyAgICAxLjY3NTg5N10gQ1BVOiAzMSBQSUQ6IDAgQ29tbTogc3dhcHBl
ci8zMSBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5k
YXJkKyAjMQ0KWyAgICAxLjY3NTg5OV0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4g
LVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjY3NTkwMV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS42NzU5MDNdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpb
ICAgIDEuNjc1OTA0XSBzcCA6IGZmZmY4MDAwMTFiMmJlODANClsgICAgMS42NzU5MDVdIHgyOTog
ZmZmZjgwMDAxMWIyYmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMWYgDQpbICAgIDEuNjc1OTA3XSB4
Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyM2UwMDcwIA0KWyAgICAxLjY3NTkw
OV0geDI1OiBmZmZmZmUxZmZkZWE0NDAwIHgyNDogZmZmZjgwMDAxMjNlMDAwMCANClsgICAgMS42
NzU5MTFdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAg
IDEuNjc1OTEzXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0K
WyAgICAxLjY3NTkxNV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZm
ZiANClsgICAgMS42NzU5MTddIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAw
MDAwMDAgDQpbICAgIDEuNjc1OTE5XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAw
MDAwMDAwMDEwIA0KWyAgICAxLjY3NTkyMV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAw
MDAwMDAwMDAwMDAwMCANClsgICAgMS42NzU5MjJdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6
IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjc1OTI0XSB4OSA6IGZmZmY4MDAwMTA2ZDY0ZjAg
eDggOiAzMDMyMzUzMDMwMzEzMDMwIA0KWyAgICAxLjY3NTkyNl0geDcgOiAzMTMwMzAzMDMwNzgz
MDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS42NzU5MjhdIHg1IDogMDAwMDAwMDAw
MDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNjc1OTMwXSB4MyA6IDAwMDAw
MDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjY3NTkzMl0geDEgOiAw
MDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS42NzU5MzRdIENh
bGwgdHJhY2U6DQpbICAgIDEuNjc1OTM2XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAg
IDEuNjc1OTM5XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS42NzU5NDFdICBj
cHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjY3NTk0M10gIG5vdGlmeV9j
cHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNjc1OTQ2XSAgc2Vjb25kYXJ5X3N0YXJ0X2tl
cm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNjc1OTQ3XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQz
MDUzYjcxIF0tLS0NClsgICAgMS42NzU5NTRdIEdJQ3YzOiBDUFUzMTogdXNpbmcgYWxsb2NhdGVk
IExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI5MTAwMDANClsgICAgMS42NzYwMzJdIGFy
Y2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgw
NDANClsgICAgMS42NzYwNDFdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTMxDQpbICAgIDEuNjc2MDcx
XSBDUFUzMTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTBmIFsweDQxM2Zk
MGMxXQ0KWyAgICAxLjY3NjE1M10gc21wOiBCcm91Z2h0IHVwIDEgbm9kZSwgMzIgQ1BVcw0KWyAg
ICA3LjUyMTc4OF0gU01QOiBUb3RhbCBvZiAzMiBwcm9jZXNzb3JzIGFjdGl2YXRlZC4NClsgICAg
Ny41MjY2MTldIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFByaXZpbGVnZWQgQWNjZXNzIE5ldmVy
DQpbICAgIDcuNTMyMjc0XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBMU0UgYXRvbWljIGluc3Ry
dWN0aW9ucw0KWyAgICA3LjUzNzkwM10gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogVXNlciBBY2Nl
c3MgT3ZlcnJpZGUNClsgICAgNy41NDMyODRdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IDMyLWJp
dCBFTDAgU3VwcG9ydA0KWyAgICA3LjU0ODQ5Ml0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQ29t
bW9uIG5vdCBQcml2YXRlIHRyYW5zbGF0aW9ucw0KWyAgICA3LjU1NDgzMF0gQ1BVIGZlYXR1cmVz
OiBkZXRlY3RlZDogRGF0YSBjYWNoZSBjbGVhbiB0byB0aGUgUG9VIG5vdCByZXF1aXJlZCBmb3Ig
SS9EIGNvaGVyZW5jZQ0KWyAgICA3LjU2MzUxMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQ1JD
MzIgaW5zdHJ1Y3Rpb25zDQpbICAgIDcuNTY4NzE4XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBT
cGVjdWxhdGl2ZSBTdG9yZSBCeXBhc3NpbmcgU2FmZSAoU1NCUykNClsgICAgNy42MDgwNzddIENQ
VTogQWxsIENQVShzKSBzdGFydGVkIGF0IEVMMQ0KWyAgICA3LjYxMjIzMl0gYWx0ZXJuYXRpdmVz
OiBwYXRjaGluZyBrZXJuZWwgY29kZQ0KWyAgICA3LjYxNzU0MV0gZGV2dG1wZnM6IGluaXRpYWxp
emVkDQpbICAgIDcuNjIxMTQ0XSBjbG9ja3NvdXJjZTogamlmZmllczogbWFzazogMHhmZmZmZmZm
ZiBtYXhfY3ljbGVzOiAweGZmZmZmZmZmLCBtYXhfaWRsZV9uczogNzY0NTA0MTc4NTEwMDAwMCBu
cw0KWyAgICA3LjYzMDc4Nl0gZnV0ZXggaGFzaCB0YWJsZSBlbnRyaWVzOiA4MTkyIChvcmRlcjog
NywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIpDQpbICAgIDcuNjM3OTg0XSBETUkgbm90IHByZXNlbnQg
b3IgaW52YWxpZC4NClsgICAgNy42NDE5ODRdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1p
bHkgMTYNClsgICAgNy42NDc2NzhdIERNQTogcHJlYWxsb2NhdGVkIDQwOTYgS2lCIEdGUF9LRVJO
RUwgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zDQpbICAgIDcuNjU0ODg5XSBETUE6IHByZWFs
bG9jYXRlZCA0MDk2IEtpQiBHRlBfS0VSTkVMfEdGUF9ETUEgcG9vbCBmb3IgYXRvbWljIGFsbG9j
YXRpb25zDQpbICAgIDcuNjYyNzgxXSBETUE6IHByZWFsbG9jYXRlZCA0MDk2IEtpQiBHRlBfS0VS
TkVMfEdGUF9ETUEzMiBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMNClsgICAgNy42NzA5ODFd
IHRoZXJtYWxfc3lzOiBSZWdpc3RlcmVkIHRoZXJtYWwgZ292ZXJub3IgJ3N0ZXBfd2lzZScNClsg
ICAgNy42NzExMTJdIERldGVjdGVkIDE1IFBDQyBTdWJzcGFjZXMNClsgICAgNy42ODA3NjZdIFJl
Z2lzdGVyaW5nIFBDQyBkcml2ZXIgYXMgTWFpbGJveCBjb250cm9sbGVyDQpbICAgIDcuNjg2MTYy
XSBody1icmVha3BvaW50OiBmb3VuZCA2IGJyZWFrcG9pbnQgYW5kIDQgd2F0Y2hwb2ludCByZWdp
c3RlcnMuDQpbICAgIDcuNjk0NDYxXSBBU0lEIGFsbG9jYXRvciBpbml0aWFsaXNlZCB3aXRoIDY1
NTM2IGVudHJpZXMNClsgICAgNy42OTk3NjddIEFDUEk6IGJ1cyB0eXBlIFBDSSByZWdpc3RlcmVk
DQpbICAgIDcuNzAzODM4XSBTZXJpYWw6IEFNQkEgUEwwMTEgVUFSVCBkcml2ZXINClsgICAgNy43
MTAyODJdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAxLjAwIEdpQiBwYWdlIHNpemUsIHByZS1hbGxvY2F0
ZWQgMCBwYWdlcw0KWyAgICA3LjcxNjg5OV0gSHVnZVRMQiByZWdpc3RlcmVkIDMyLjAgTWlCIHBh
Z2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzDQpbICAgIDcuNzIzNjUyXSBIdWdlVExCIHJl
Z2lzdGVyZWQgMi4wMCBNaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMNClsgICAg
Ny43MzA0MzNdIEh1Z2VUTEIgcmVnaXN0ZXJlZCA2NC4wIEtpQiBwYWdlIHNpemUsIHByZS1hbGxv
Y2F0ZWQgMCBwYWdlcw0KWyAgICA3LjczODUxMF0gY3J5cHRkOiBtYXhfY3B1X3FsZW4gc2V0IHRv
IDEwMDANClsgICAgNy44MTA3NDJdIHJhaWQ2OiBuZW9ueDggICBnZW4oKSAgNzc3OSBNQi9zDQpb
ICAgIDcuODgyOTY4XSByYWlkNjogbmVvbng4ICAgeG9yKCkgIDYwNTkgTUIvcw0KWyAgICA3Ljk1
NTE5OF0gcmFpZDY6IG5lb254NCAgIGdlbigpICA3NjAyIE1CL3MNClsgICAgOC4wMjc0MjNdIHJh
aWQ2OiBuZW9ueDQgICB4b3IoKSAgNjA5NiBNQi9zDQpbICAgIDguMDk5NjQ3XSByYWlkNjogbmVv
bngyICAgZ2VuKCkgIDcyNzQgTUIvcw0KWyAgICA4LjE3MTg3MV0gcmFpZDY6IG5lb254MiAgIHhv
cigpICA1NzI2IE1CL3MNClsgICAgOC4yNDQwOThdIHJhaWQ2OiBuZW9ueDEgICBnZW4oKSAgNTky
MyBNQi9zDQpbICAgIDguMzE2MzIzXSByYWlkNjogbmVvbngxICAgeG9yKCkgIDQ5NDIgTUIvcw0K
WyAgICA4LjM4ODU0N10gcmFpZDY6IGludDY0eDggIGdlbigpICAzNjAxIE1CL3MNClsgICAgOC40
NjA3NzNdIHJhaWQ2OiBpbnQ2NHg4ICB4b3IoKSAgMjAxNyBNQi9zDQpbICAgIDguNTMzMjIyXSBy
YWlkNjogaW50NjR4NCAgZ2VuKCkgIDQxMjYgTUIvcw0KWyAgICA4LjYwNTQ1NF0gcmFpZDY6IGlu
dDY0eDQgIHhvcigpICAyMTgzIE1CL3MNClsgICAgOC42Nzc2ODFdIHJhaWQ2OiBpbnQ2NHgyICBn
ZW4oKSAgMzUwMCBNQi9zDQpbICAgIDguNzQ5OTA0XSByYWlkNjogaW50NjR4MiAgeG9yKCkgIDE4
ODcgTUIvcw0KWyAgICA4LjgyMjEyNl0gcmFpZDY6IGludDY0eDEgIGdlbigpICAyODczIE1CL3MN
ClsgICAgOC44OTQzNDldIHJhaWQ2OiBpbnQ2NHgxICB4b3IoKSAgMTUwNyBNQi9zDQpbICAgIDgu
ODk4NTE2XSByYWlkNjogdXNpbmcgYWxnb3JpdGhtIG5lb254OCBnZW4oKSA3Nzc5IE1CL3MNClsg
ICAgOC45MDM5ODRdIHJhaWQ2OiAuLi4uIHhvcigpIDYwNTkgTUIvcywgcm13IGVuYWJsZWQNClsg
ICAgOC45MDkwMjBdIHJhaWQ2OiB1c2luZyBuZW9uIHJlY292ZXJ5IGFsZ29yaXRobQ0KWyAgICA4
LjkxMzc4OF0gQUNQSTogQWRkZWQgX09TSShNb2R1bGUgRGV2aWNlKQ0KWyAgICA4LjkxNzk2OV0g
QUNQSTogQWRkZWQgX09TSShQcm9jZXNzb3IgRGV2aWNlKQ0KWyAgICA4LjkyMjQ3NF0gQUNQSTog
QWRkZWQgX09TSSgzLjAgX1NDUCBFeHRlbnNpb25zKQ0KWyAgICA4LjkyNzI0OV0gQUNQSTogQWRk
ZWQgX09TSShQcm9jZXNzb3IgQWdncmVnYXRvciBEZXZpY2UpDQpbICAgIDguOTMyNzE4XSBBQ1BJ
OiBBZGRlZCBfT1NJKExpbnV4LURlbGwtVmlkZW8pDQpbICAgIDguOTM3MjMyXSBBQ1BJOiBBZGRl
ZCBfT1NJKExpbnV4LUxlbm92by1OVi1IRE1JLUF1ZGlvKQ0KWyAgICA4Ljk0MjYxNF0gQUNQSTog
QWRkZWQgX09TSShMaW51eC1IUEktSHlicmlkLUdyYXBoaWNzKQ0KWyAgICA4Ljk2ODE3NV0gQUNQ
STogMiBBQ1BJIEFNTCB0YWJsZXMgc3VjY2Vzc2Z1bGx5IGFjcXVpcmVkIGFuZCBsb2FkZWQNClsg
ICAgOC45ODA3ODJdIEFDUEk6IEludGVycHJldGVyIGVuYWJsZWQNClsgICAgOC45ODQzNDZdIEFD
UEk6IFVzaW5nIEdJQyBmb3IgaW50ZXJydXB0IHJvdXRpbmcNClsgICAgOC45ODkxMzFdIEFDUEk6
IE1DRkcgdGFibGUgZGV0ZWN0ZWQsIDUgZW50cmllcw0KWyAgICA4Ljk5Mzg5OF0gSEVTVDogVGFi
bGUgcGFyc2luZyBoYXMgYmVlbiBpbml0aWFsaXplZC4NClsgICAgOS4wNDczMzldIEFSTUgwMDEx
OjAwOiB0dHlBTUEwIGF0IE1NSU8gMHgxMDAwMDI2MDAwMDAgKGlycSA9IDc5LCBiYXNlX2JhdWQg
PSAwKSBpcyBhIFNCU0ENClsgICAgOS4xNTg0ODJdIHByaW50azogY29uc29sZSBbdHR5QU1BMF0g
ZW5hYmxlZA0KWyAgICA5LjE2NDU3M10gQVJNSDAwMTE6MDE6IHR0eUFNQTEgYXQgTU1JTyAweDEw
MDAwMjYyMDAwMCAoaXJxID0gODAsIGJhc2VfYmF1ZCA9IDApIGlzIGEgU0JTQQ0KWyAgICA5LjE3
NDk4OF0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0kwXSAoZG9tYWluIDAwMGMgW2J1cyAwMC1m
Zl0pDQpbICAgIDkuMTgxMTczXSBhY3BpIFBOUDBBMDg6MDA6IF9PU0M6IE9TIHN1cHBvcnRzIFtF
eHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10NClsgICAg
OS4xOTAzODBdIGFjcGkgUE5QMEEwODowMDogUENJZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBu
b3QgcmVxdWVzdGluZyBfT1NDIGNvbnRyb2wNClsgICAgOS4xOTgyMzJdIGFjcGkgUE5QMEEwODow
MDogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MzNmZmYwMDAwMDAwLTB4MzNmZmZmZmZmZmZm
XSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzANClsgICAgOS4yMTExNjNd
IGFjcGkgUE5QMEEwODowMDogRUNBTSBhcmVhIFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZm
ZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDANClsgICAgOS4yMjAwNzRdIGFjcGkgUE5QMEEw
ODowMDogRUNBTSBhdCBbbWVtIDB4MzNmZmYwMDAwMDAwLTB4MzNmZmZmZmZmZmZmXSBmb3IgW2J1
cyAwMC1mZl0NClsgICAgOS4yMjgyOTZdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwYzowMA0K
WyAgICA5LjIzMjM1M10gcGNpX2J1cyAwMDBjOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4
NDAwMDAwMDAtMHg0ZmZmZmZmZiB3aW5kb3ddDQpbICAgIDkuMjM5OTUyXSBwY2lfYnVzIDAwMGM6
MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzM2ZmZGZmZmZmZmYg
d2luZG93XQ0KWyAgICA5LjI0ODIxNV0gcGNpX2J1cyAwMDBjOjAwOiByb290IGJ1cyByZXNvdXJj
ZSBbYnVzIDAwLWZmXQ0KWyAgICA5LjI1Mzc3MF0gcGNpIDAwMGM6MDA6MDAuMDogWzFkZWY6ZTEw
MF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMA0KWyAgICA5LjI1OTg4NF0gcGNpIDAwMGM6MDA6MDAu
MDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0K
WyAgICA5LjI2NzQ5OF0gcGNpIDAwMGM6MDA6MDEuMDogWzFkZWY6ZTEwMV0gdHlwZSAwMSBjbGFz
cyAweDA2MDQwMA0KWyAgICA5LjI3MzU3M10gcGNpIDAwMGM6MDA6MDEuMDogc3VwcG9ydHMgRDEg
RDINClsgICAgOS4yNzc4NTBdIHBjaSAwMDBjOjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20g
RDAgRDEgRDNob3QNClsgICAgOS4yODM3MTNdIHBjaSAwMDBjOjAwOjAxLjA6IEZhaWxlZCB0byBh
ZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS4yOTI0NTRd
IHBjaSAwMDBjOjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBb
YnVzIDAxXSBhZGRfc2l6ZSAxMDAwDQpbICAgIDkuMzAwNjQ4XSBwY2kgMDAwYzowMDowMS4wOiBi
cmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFti
dXMgMDFdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgIDkuMzEyMjQwXSBw
Y2kgMDAwYzowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZm
XSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgICA5LjMy
MjgyMl0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHg0MDAwMDAwMC0w
eDQwMWZmZmZmXQ0KWyAgICA5LjMyOTYyMF0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDk6IGFzc2ln
bmVkIFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAg
OS4zMzgxNTBdIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0NClsgICAgOS4zNDQ0NTVdIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDkuMzUxMTQ1XSBwY2kgMDAwYzowMDow
MS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDkuMzU3NDgy
XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgx
MDAwXQ0KWyAgICA5LjM2NDE2Nl0gcGNpIDAwMGM6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVz
IDAxXQ0KWyAgICA5LjM2OTE3N10gcGNpIDAwMGM6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFtt
ZW0gMHg0MDAwMDAwMC0weDQwMWZmZmZmXQ0KWyAgICA5LjM3NjA2MV0gcGNpIDAwMGM6MDA6MDEu
MDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZmZmYgNjRi
aXQgcHJlZl0NClsgICAgOS4zODQ1OTNdIHBjaV9idXMgMDAwYzowMDogcmVzb3VyY2UgNCBbbWVt
IDB4NDAwMDAwMDAtMHg0ZmZmZmZmZiB3aW5kb3ddDQpbICAgIDkuMzkxNTEzXSBwY2lfYnVzIDAw
MGM6MDA6IHJlc291cmNlIDUgW21lbSAweDMwMDAwMDAwMDAwMC0weDMzZmZkZmZmZmZmZiB3aW5k
b3ddDQpbICAgIDkuMzk5MTY0XSBwY2lfYnVzIDAwMGM6MDE6IHJlc291cmNlIDEgW21lbSAweDQw
MDAwMDAwLTB4NDAxZmZmZmZdDQpbICAgIDkuNDA1NDc5XSBwY2lfYnVzIDAwMGM6MDE6IHJlc291
cmNlIDIgW21lbSAweDMwMDAwMDAwMDAwMC0weDMwMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAg
ICA5LjQxMzUzMl0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0kxXSAoZG9tYWluIDAwMGQgW2J1
cyAwMC1mZl0pDQpbICAgIDkuNDE5NzIzXSBhY3BpIFBOUDBBMDg6MDE6IF9PU0M6IE9TIHN1cHBv
cnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10N
ClsgICAgOS40Mjg5MzhdIGFjcGkgUE5QMEEwODowMTogUENJZSBwb3J0IHNlcnZpY2VzIGRpc2Fi
bGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNvbnRyb2wNClsgICAgOS40MzY3ODJdIGFjcGkgUE5Q
MEEwODowMTogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZm
ZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzANClsgICAgOS40
NDk3MTddIGFjcGkgUE5QMEEwODowMTogRUNBTSBhcmVhIFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgz
N2ZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDANClsgICAgOS40NTg2MzBdIGFjcGkg
UE5QMEEwODowMTogRUNBTSBhdCBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZmXSBm
b3IgW2J1cyAwMC1mZl0NClsgICAgOS40NjY4NDldIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAw
ZDowMA0KWyAgICA5LjQ3MDkwNl0gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1cyByZXNvdXJjZSBb
bWVtIDB4NTAwMDAwMDAtMHg1ZmZmZmZmZiB3aW5kb3ddDQpbICAgIDkuNDc4NTA1XSBwY2lfYnVz
IDAwMGQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgzN2ZmZGZm
ZmZmZmYgd2luZG93XQ0KWyAgICA5LjQ4Njc2MV0gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1cyBy
ZXNvdXJjZSBbYnVzIDAwLWZmXQ0KWyAgICA5LjQ5MjMxOV0gcGNpIDAwMGQ6MDA6MDAuMDogWzFk
ZWY6ZTEwMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMA0KWyAgICA5LjQ5ODQxN10gcGNpIDAwMGQ6
MDA6MDAuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBm
YWlsIQ0KWyAgICA5LjUwNjA0MV0gcGNpIDAwMGQ6MDA6MDEuMDogWzFkZWY6ZTEwMV0gdHlwZSAw
MSBjbGFzcyAweDA2MDQwMA0KWyAgICA5LjUxMjExM10gcGNpIDAwMGQ6MDA6MDEuMDogc3VwcG9y
dHMgRDEgRDINClsgICAgOS41MTYzOTJdIHBjaSAwMDBkOjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVk
IGZyb20gRDAgRDEgRDNob3QNClsgICAgOS41MjIyNjJdIHBjaSAwMDBkOjAwOjAxLjA6IEZhaWxl
ZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS41
Mjk5NzVdIHBjaSAwMDBkOjAxOjAwLjA6IFsxMGRlOjFlODldIHR5cGUgMDAgY2xhc3MgMHgwMzAw
MDANClsgICAgOS41MzU5NzZdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4NTAw
MDAwMDAtMHg1MGZmZmZmZl0NClsgICAgOS41NDIzMTRdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAw
eDE0OiBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDBmZmZmZmZmIDY0Yml0IHByZWZdDQpbICAg
IDkuNTUwMzI0XSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxYzogW21lbSAweDM0MDAxMDAwMDAw
MC0weDM0MDAxMWZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjU1ODMxM10gcGNpIDAwMGQ6MDE6
MDAuMDogcmVnIDB4MjQ6IFtpbyAgMHg1N2ZmZTAwMC0weDU3ZmZlMDdmXQ0KWyAgICA5LjU2NDYy
MF0gcGNpIDAwMGQ6MDE6MDAuMDogcmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZm
IHByZWZdDQpbICAgIDkuNTcxNDU0XSBwY2kgMDAwZDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBm
cm9tIEQwIEQzaG90IEQzY29sZA0KWyAgICA5LjU3NzYwMl0gcGNpIDAwMGQ6MDE6MDAuMDogRmFp
bGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA5
LjU4NTIyN10gcGNpIDAwMGQ6MDE6MDAuMTogWzEwZGU6MTBmOF0gdHlwZSAwMCBjbGFzcyAweDA0
MDMwMA0KWyAgICA5LjU5MTI3M10gcGNpIDAwMGQ6MDE6MDAuMTogcmVnIDB4MTA6IFttZW0gMHg1
MTAwMDAwMC0weDUxMDAzZmZmXQ0KWyAgICA5LjU5NzcwN10gcGNpIDAwMGQ6MDE6MDAuMTogRmFp
bGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA5
LjYwNTMwMl0gcGNpIDAwMGQ6MDE6MDAuMjogWzEwZGU6MWFkOF0gdHlwZSAwMCBjbGFzcyAweDBj
MDMzMA0KWyAgICA5LjYxMTM1MV0gcGNpIDAwMGQ6MDE6MDAuMjogcmVnIDB4MTA6IFttZW0gMHgz
NDAwMTIwMDAwMDAtMHgzNDAwMTIwM2ZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS42MTkzNjRdIHBj
aSAwMDBkOjAxOjAwLjI6IHJlZyAweDFjOiBbbWVtIDB4MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRm
ZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuNjI3MzkwXSBwY2kgMDAwZDowMTowMC4yOiBQTUUjIHN1
cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZA0KWyAgICA5LjYzMzUwOV0gcGNpIDAwMGQ6MDE6
MDAuMjogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWls
IQ0KWyAgICA5LjY0MTIyN10gcGNpIDAwMGQ6MDE6MDAuMzogWzEwZGU6MWFkOV0gdHlwZSAwMCBj
bGFzcyAweDBjODAwMA0KWyAgICA5LjY0NzI1Ml0gcGNpIDAwMGQ6MDE6MDAuMzogcmVnIDB4MTA6
IFttZW0gMHg1MTAwNDAwMC0weDUxMDA0ZmZmXQ0KWyAgICA5LjY1MzY1N10gcGNpIDAwMGQ6MDE6
MDAuMzogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAgOS42NTk3OTld
IHBjaSAwMDBkOjAxOjAwLjM6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJ
LVggbWlnaHQgZmFpbCENClsgICAgOS42Njc0MjNdIHBjaSAwMDBkOjAwOjAxLjA6IEFTUE06IGN1
cnJlbnQgY29tbW9uIGNsb2NrIGNvbmZpZ3VyYXRpb24gaXMgaW5jb25zaXN0ZW50LCByZWNvbmZp
Z3VyaW5nDQpbICAgIDkuNjg4ODE5XSBwY2kgMDAwZDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQg
W21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAxN2ZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjY5
NzI4MF0gcGNpIDAwMGQ6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHg1MDAwMDAwMC0w
eDUxN2ZmZmZmXQ0KWyAgICA5LjcwNDExM10gcGNpIDAwMGQ6MDA6MDEuMDogQkFSIDc6IG5vIHNw
YWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA5LjcxMDQ0Ml0gcGNpIDAwMGQ6MDA6MDEu
MDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAgOS43MTcx
MzRdIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiAxOiBhc3NpZ25lZCBbbWVtIDB4MzQwMDAwMDAwMDAw
LTB4MzQwMDBmZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuNzI1NjcxXSBwY2kgMDAwZDowMTow
MC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDM0MDAxMDAwMDAwMC0weDM0MDAxMWZmZmZmZiA2
NGJpdCBwcmVmXQ0KWyAgICA5LjczNDE3N10gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDA6IGFzc2ln
bmVkIFttZW0gMHg1MDAwMDAwMC0weDUwZmZmZmZmXQ0KWyAgICA5Ljc0MTAwOF0gcGNpIDAwMGQ6
MDE6MDAuMDogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg1MTAwMDAwMC0weDUxMDdmZmZmIHByZWZd
DQpbICAgIDkuNzQ4MzAzXSBwY2kgMDAwZDowMTowMC4yOiBCQVIgMDogYXNzaWduZWQgW21lbSAw
eDM0MDAxMjAwMDAwMC0weDM0MDAxMjAzZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5Ljc1NjgzNF0g
cGNpIDAwMGQ6MDE6MDAuMjogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTIwNDAwMDAtMHgz
NDAwMTIwNGZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS43NjUzNDFdIHBjaSAwMDBkOjAxOjAwLjE6
IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4NTEwODAwMDAtMHg1MTA4M2ZmZl0NClsgICAgOS43NzIx
NzBdIHBjaSAwMDBkOjAxOjAwLjM6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4NTEwODQwMDAtMHg1
MTA4NGZmZl0NClsgICAgOS43NzkwMjhdIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiA1OiBubyBzcGFj
ZSBmb3IgW2lvICBzaXplIDB4MDA4MF0NClsgICAgOS43ODUzNTVdIHBjaSAwMDBkOjAxOjAwLjA6
IEJBUiA1OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDAwODBdDQpbICAgIDkuNzkyMDQ1
XSBwY2kgMDAwZDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDFdDQpbICAgIDkuNzk3MDU2
XSBwY2kgMDAwZDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDUwMDAwMDAwLTB4NTE3
ZmZmZmZdDQpbICAgIDkuODAzOTQxXSBwY2kgMDAwZDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cg
W21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAxN2ZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5Ljgx
MjQ3MV0gcGNpX2J1cyAwMDBkOjAwOiBTb21lIFBDSSBkZXZpY2UgcmVzb3VyY2VzIGFyZSB1bmFz
c2lnbmVkLCB0cnkgYm9vdGluZyB3aXRoIHBjaT1yZWFsbG9jDQpbICAgIDkuODIxNTkzXSBwY2lf
YnVzIDAwMGQ6MDA6IHJlc291cmNlIDQgW21lbSAweDUwMDAwMDAwLTB4NWZmZmZmZmYgd2luZG93
XQ0KWyAgICA5LjgyODUwNl0gcGNpX2J1cyAwMDBkOjAwOiByZXNvdXJjZSA1IFttZW0gMHgzNDAw
MDAwMDAwMDAtMHgzN2ZmZGZmZmZmZmYgd2luZG93XQ0KWyAgICA5LjgzNjE1Nl0gcGNpX2J1cyAw
MDBkOjAxOiByZXNvdXJjZSAxIFttZW0gMHg1MDAwMDAwMC0weDUxN2ZmZmZmXQ0KWyAgICA5Ljg0
MjQ5MV0gcGNpX2J1cyAwMDBkOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgz
NDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS44NTA1NzVdIEFDUEk6IFBDSSBSb290IEJy
aWRnZSBbUENJM10gKGRvbWFpbiAwMDAwIFtidXMgMDAtZmZdKQ0KWyAgICA5Ljg1Njc1NF0gYWNw
aSBQTlAwQTA4OjAzOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9j
a1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgIDkuODY1OTg0XSBhY3BpIFBOUDBBMDg6
MDM6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250
cm9sDQpbICAgIDkuODczODI4XSBhY3BpIFBOUDBBMDg6MDM6IE1DRkcgcXVpcms6IEVDQU0gYXQg
W21lbSAweDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGgg
MHhmZmZmODAwMDEwZGUwZmMwDQpbICAgIDkuODg2ODE4XSBhY3BpIFBOUDBBMDg6MDM6IEVDQU0g
YXJlYSBbbWVtIDB4M2ZmZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAw
QzAyOjAwDQpbICAgIDkuODk1NzM5XSBhY3BpIFBOUDBBMDg6MDM6IEVDQU0gYXQgW21lbSAweDNm
ZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpbICAgIDkuOTAzOTUz
XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMDA6MDANClsgICAgOS45MDgwMTBdIHBjaV9idXMg
MDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDcwMDAwMDAwLTB4N2ZmZmZmZmYgd2lu
ZG93XQ0KWyAgICA5LjkxNTYxMl0gcGNpX2J1cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBb
bWVtIDB4M2MwMDAwMDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10NClsgICAgOS45MjM4NjVd
IHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0NClsgICAgOS45
Mjk0MjRdIHBjaSAwMDAwOjAwOjAwLjA6IFsxZGVmOmUxMDBdIHR5cGUgMDAgY2xhc3MgMHgwNjAw
MDANClsgICAgOS45MzU1MzFdIHBjaSAwMDAwOjAwOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNz
dGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS45NDMxNDVdIHBjaSAwMDAw
OjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAgOS45NDky
MTZdIHBjaSAwMDAwOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgIDkuOTUzNDk2XSBwY2kg
MDAwMDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgIDkuOTU5
MzcyXSBwY2kgMDAwMDowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJ
L01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuOTY3MDc3XSBwY2kgMDAwMDowMTowMC4wOiBbODA4
NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwDQpbICAgIDkuOTczMDgxXSBwY2kgMDAwMDow
MTowMC4wOiByZWcgMHgxMDogW21lbSAweDNjMDAwMzAwMDAwMC0weDNjMDAwM2ZmZmZmZiA2NGJp
dCBwcmVmXQ0KWyAgICA5Ljk4MTA5NF0gcGNpIDAwMDA6MDE6MDAuMDogcmVnIDB4MWM6IFttZW0g
MHgzYzAwMDQ4MTgwMDAtMHgzYzAwMDQ4MWZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS45ODkwNzZd
IHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBw
cmVmXQ0KWyAgICA5Ljk5NTg5OF0gcGNpIDAwMDA6MDE6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJv
bSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMC4wMDIwMjddIHBjaSAwMDAwOjAxOjAwLjA6IEZhaWxl
ZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC4w
MDk2NzVdIHBjaSAwMDAwOjAxOjAwLjE6IFs4MDg2OjE1ODldIHR5cGUgMDAgY2xhc3MgMHgwMjAw
MDANClsgICAxMC4wMTU3MDhdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4M2Mw
MDAyMDAwMDAwLTB4M2MwMDAyZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMDIzNzIxXSBwY2kg
MDAwMDowMTowMC4xOiByZWcgMHgxYzogW21lbSAweDNjMDAwNDgxMDAwMC0weDNjMDAwNDgxN2Zm
ZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjAzMTcwNF0gcGNpIDAwMDA6MDE6MDAuMTogcmVnIDB4MzA6
IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdDQpbICAgMTAuMDM4NTEyXSBwY2kgMDAw
MDowMTowMC4xOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZA0KWyAgIDEwLjA0
NDYzOF0gcGNpIDAwMDA6MDE6MDAuMTogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1T
SS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjA1MjI4N10gcGNpIDAwMDA6MDE6MDAuMjogWzgw
ODY6MTU4OV0gdHlwZSAwMCBjbGFzcyAweDAyMDAwMA0KWyAgIDEwLjA1ODMyNl0gcGNpIDAwMDA6
MDE6MDAuMjogcmVnIDB4MTA6IFttZW0gMHgzYzAwMDEwMDAwMDAtMHgzYzAwMDFmZmZmZmYgNjRi
aXQgcHJlZl0NClsgICAxMC4wNjYzMzldIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDFjOiBbbWVt
IDB4M2MwMDA0ODA4MDAwLTB4M2MwMDA0ODBmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMDc0MzIy
XSBwY2kgMDAwMDowMTowMC4yOiByZWcgMHgzMDogW21lbSAweGZmZjgwMDAwLTB4ZmZmZmZmZmYg
cHJlZl0NClsgICAxMC4wODExMzVdIHBjaSAwMDAwOjAxOjAwLjI6IFBNRSMgc3VwcG9ydGVkIGZy
b20gRDAgRDNob3QgRDNjb2xkDQpbICAgMTAuMDg3MjYwXSBwY2kgMDAwMDowMTowMC4yOiBGYWls
ZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTAu
MDk0OTA5XSBwY2kgMDAwMDowMTowMC4zOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIw
MDAwDQpbICAgMTAuMTAwOTQ3XSBwY2kgMDAwMDowMTowMC4zOiByZWcgMHgxMDogW21lbSAweDNj
MDAwMDAwMDAwMC0weDNjMDAwMGZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjEwODk2MF0gcGNp
IDAwMDA6MDE6MDAuMzogcmVnIDB4MWM6IFttZW0gMHgzYzAwMDQ4MDAwMDAtMHgzYzAwMDQ4MDdm
ZmYgNjRiaXQgcHJlZl0NClsgICAxMC4xMTY5NDNdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDMw
OiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQ0KWyAgIDEwLjEyMzc1OF0gcGNpIDAw
MDA6MDE6MDAuMzogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMC4x
Mjk4OTBdIHBjaSAwMDAwOjAxOjAwLjM6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBN
U0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC4xMzc1NDRdIHBjaSAwMDAwOjAwOjAxLjA6IGJy
aWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAxLTAyXSBhZGRfc2l6ZSAx
MDAwDQpbICAgMTAuMTQ2MDI2XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21l
bSAweDNjMDAwMDAwMDAwMC0weDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjE1NDUz
MF0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHg3MDAwMDAwMC0weDcw
MWZmZmZmXQ0KWyAgIDEwLjE2MTM2M10gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNl
IGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjE2NzY5M10gcGNpIDAwMDA6MDA6MDEuMDog
QkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC4xNzQzODJd
IHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0N
ClsgICAxMC4xODA3MTNdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWdu
IFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuMTg3NDA1XSBwY2kgMDAwMDowMTowMC4wOiBCQVIg
MDogYXNzaWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwMGZmZmZmZiA2NGJpdCBwcmVm
XQ0KWyAgIDEwLjE5NTk0Ml0gcGNpIDAwMDA6MDE6MDAuMTogQkFSIDA6IGFzc2lnbmVkIFttZW0g
MHgzYzAwMDEwMDAwMDAtMHgzYzAwMDFmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4yMDQ0NDld
IHBjaSAwMDAwOjAxOjAwLjI6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAyMDAwMDAwLTB4
M2MwMDAyZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMjEyOTU2XSBwY2kgMDAwMDowMTowMC4z
OiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMzAwMDAwMC0weDNjMDAwM2ZmZmZmZiA2NGJp
dCBwcmVmXQ0KWyAgIDEwLjIyMTQ2Ml0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDY6IGFzc2lnbmVk
IFttZW0gMHg3MDAwMDAwMC0weDcwMDdmZmZmIHByZWZdDQpbICAgMTAuMjI4NzMwXSBwY2kgMDAw
MDowMTowMC4xOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMDgwMDAwLTB4NzAwZmZmZmYgcHJl
Zl0NClsgICAxMC4yMzYwMjJdIHBjaSAwMDAwOjAxOjAwLjI6IEJBUiA2OiBhc3NpZ25lZCBbbWVt
IDB4NzAxMDAwMDAtMHg3MDE3ZmZmZiBwcmVmXQ0KWyAgIDEwLjI0MzMxNF0gcGNpIDAwMDA6MDE6
MDAuMzogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg3MDE4MDAwMC0weDcwMWZmZmZmIHByZWZdDQpb
ICAgMTAuMjUwNjA2XSBwY2kgMDAwMDowMTowMC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDNj
MDAwNDAwMDAwMC0weDNjMDAwNDAwN2ZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjI1OTEzNl0gcGNp
IDAwMDA6MDE6MDAuMTogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDgwMDAtMHgzYzAw
MDQwMGZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4yNjc2NDNdIHBjaSAwMDAwOjAxOjAwLjI6IEJB
UiAzOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDA0MDEwMDAwLTB4M2MwMDA0MDE3ZmZmIDY0Yml0IHBy
ZWZdDQpbICAgMTAuMjc2MTUwXSBwY2kgMDAwMDowMTowMC4zOiBCQVIgMzogYXNzaWduZWQgW21l
bSAweDNjMDAwNDAxODAwMC0weDNjMDAwNDAxZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjI4NDY1
N10gcGNpIDAwMDA6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxLTAyXQ0KWyAgIDEwLjI4
OTkwNl0gcGNpIDAwMDA6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHg3MDAwMDAwMC0w
eDcwMWZmZmZmXQ0KWyAgIDEwLjI5Njc4Ml0gcGNpIDAwMDA6MDA6MDEuMDogICBicmlkZ2Ugd2lu
ZG93IFttZW0gMHgzYzAwMDAwMDAwMDAtMHgzYzAwMDQ3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAx
MC4zMDUzMTJdIHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNCBbbWVtIDB4NzAwMDAwMDAtMHg3
ZmZmZmZmZiB3aW5kb3ddDQpbICAgMTAuMzEyMjM4XSBwY2lfYnVzIDAwMDA6MDA6IHJlc291cmNl
IDUgW21lbSAweDNjMDAwMDAwMDAwMC0weDNmZmZkZmZmZmZmZiB3aW5kb3ddDQpbICAgMTAuMzE5
ODg4XSBwY2lfYnVzIDAwMDA6MDE6IHJlc291cmNlIDEgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZm
ZmZdDQpbICAgMTAuMzI2MTk5XSBwY2lfYnVzIDAwMDA6MDE6IHJlc291cmNlIDIgW21lbSAweDNj
MDAwMDAwMDAwMC0weDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjMzNDI3M10gQUNQ
STogUENJIFJvb3QgQnJpZGdlIFtQQ0k2XSAoZG9tYWluIDAwMDQgW2J1cyAwMC1mZl0pDQpbICAg
MTAuMzQwNDU0XSBhY3BpIFBOUDBBMDg6MDY6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENv
bmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10NClsgICAxMC4zNDk2NzJd
IGFjcGkgUE5QMEEwODowNjogUENJZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBub3QgcmVxdWVz
dGluZyBfT1NDIGNvbnRyb2wNClsgICAxMC4zNTc1MTVdIGFjcGkgUE5QMEEwODowNjogTUNGRyBx
dWlyazogRUNBTSBhdCBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSBmb3IgW2J1
cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzANClsgICAxMC4zNzA0NTldIGFjcGkgUE5Q
MEEwODowNjogRUNBTSBhcmVhIFttZW0gMHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIHJl
c2VydmVkIGJ5IFBOUDBDMDI6MDANClsgICAxMC4zNzkzNzBdIGFjcGkgUE5QMEEwODowNjogRUNB
TSBhdCBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0N
ClsgICAxMC4zODc1ODVdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwNDowMA0KWyAgIDEwLjM5
MTY0MV0gcGNpX2J1cyAwMDA0OjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MjAwMDAwMDAt
MHgyZmZmZmZmZiB3aW5kb3ddDQpbICAgMTAuMzk5MjQyXSBwY2lfYnVzIDAwMDQ6MDA6IHJvb3Qg
YnVzIHJlc291cmNlIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyYmZmZGZmZmZmZmYgd2luZG93XQ0K
WyAgIDEwLjQwNzQ5N10gcGNpX2J1cyAwMDA0OjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAw
LWZmXQ0KWyAgIDEwLjQxMzA1NF0gcGNpIDAwMDQ6MDA6MDAuMDogWzFkZWY6ZTExMF0gdHlwZSAw
MCBjbGFzcyAweDA2MDAwMA0KWyAgIDEwLjQxOTE1M10gcGNpIDAwMDQ6MDA6MDAuMDogRmFpbGVk
IHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjQy
Njc3NF0gcGNpIDAwMDQ6MDA6MDEuMDogWzFkZWY6ZTExMV0gdHlwZSAwMSBjbGFzcyAweDA2MDQw
MA0KWyAgIDEwLjQzMjg1MF0gcGNpIDAwMDQ6MDA6MDEuMDogc3VwcG9ydHMgRDEgRDINClsgICAx
MC40MzcxMjddIHBjaSAwMDA0OjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNo
b3QNClsgICAxMC40NDMwMDFdIHBjaSAwMDA0OjAwOjAxLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNz
dGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC40NTA2NDddIHBjaSAwMDA0
OjAwOjAzLjA6IFsxZGVmOmUxMTNdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAxMC40NTY3
MjNdIHBjaSAwMDA0OjAwOjAzLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTAuNDYwOTk5XSBwY2kg
MDAwNDowMDowMy4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgMTAuNDY2
ODcwXSBwY2kgMDAwNDowMDowMy4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJ
L01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTAuNDc0NTIwXSBwY2kgMDAwNDowMDowNS4wOiBbMWRl
ZjplMTE1XSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgMTAuNDgwNjA1XSBwY2kgMDAwNDow
MDowNS4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgIDEwLjQ4NDg3MF0gcGNpIDAwMDQ6MDA6MDUuMDog
UE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgIDEwLjQ5MDc0Ml0gcGNpIDAwMDQ6
MDA6MDUuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBm
YWlsIQ0KWyAgIDEwLjQ5ODQ0OF0gcGNpIDAwMDQ6MDE6MDAuMDogWzFhMDM6MTE1MF0gdHlwZSAw
MSBjbGFzcyAweDA2MDQwMA0KWyAgIDEwLjUwNDQ5MF0gcGNpIDAwMDQ6MDE6MDAuMDogZW5hYmxp
bmcgRXh0ZW5kZWQgVGFncw0KWyAgIDEwLjUwOTUxOV0gcGNpIDAwMDQ6MDE6MDAuMDogc3VwcG9y
dHMgRDEgRDINClsgICAxMC41MTM3ODhdIHBjaSAwMDA0OjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVk
IGZyb20gRDAgRDEgRDIgRDNob3QgRDNjb2xkDQpbICAgMTAuNTIwNTYzXSBwY2kgMDAwNDowMTow
MC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwh
DQpbICAgMTAuNTI4MjEzXSBwY2lfYnVzIDAwMDQ6MDI6IGV4dGVuZGVkIGNvbmZpZyBzcGFjZSBu
b3QgYWNjZXNzaWJsZQ0KWyAgIDEwLjUzNDMzM10gcGNpIDAwMDQ6MDI6MDAuMDogWzFhMDM6MjAw
MF0gdHlwZSAwMCBjbGFzcyAweDAzMDAwMA0KWyAgIDEwLjU0MDM5N10gcGNpIDAwMDQ6MDI6MDAu
MDogcmVnIDB4MTA6IFttZW0gMHgyMDAwMDAwMC0weDIwZmZmZmZmXQ0KWyAgIDEwLjU0NjcyN10g
cGNpIDAwMDQ6MDI6MDAuMDogcmVnIDB4MTQ6IFttZW0gMHgyMTAwMDAwMC0weDIxMDFmZmZmXQ0K
WyAgIDEwLjU1MzA2NF0gcGNpIDAwMDQ6MDI6MDAuMDogcmVnIDB4MTg6IFtpbyAgMHgyN2ZmZjAw
MC0weDI3ZmZmMDdmXQ0KWyAgIDEwLjU1OTQ3NF0gcGNpIDAwMDQ6MDI6MDAuMDogc3VwcG9ydHMg
RDEgRDINClsgICAxMC41NjM3MDRdIHBjaSAwMDA0OjAyOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZy
b20gRDAgRDEgRDIgRDNob3QgRDNjb2xkDQpbICAgMTAuNTcwNDY3XSBwY2kgMDAwNDowMjowMC4w
OiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpb
ICAgMTAuNTc4MjAyXSBwY2kgMDAwNDowMzowMC4wOiBbMTkxMjowMDE0XSB0eXBlIDAwIGNsYXNz
IDB4MGMwMzMwDQpbICAgMTAuNTg0MjEzXSBwY2kgMDAwNDowMzowMC4wOiByZWcgMHgxMDogW21l
bSAweDIxMjAwMDAwLTB4MjEyMDFmZmYgNjRiaXRdDQpbICAgMTAuNTkxMTY1XSBwY2kgMDAwNDow
MzowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZA0KWyAgIDEwLjU5NzMw
NF0gcGNpIDAwMDQ6MDM6MDAuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9N
U0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjYwNDk5Nl0gcGNpIDAwMDQ6MDQ6MDAuMDogWzgwODY6
MTUzM10gdHlwZSAwMCBjbGFzcyAweDAyMDAwMA0KWyAgIDEwLjYxMTAxNl0gcGNpIDAwMDQ6MDQ6
MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMTEwMDAwMC0weDIxMTdmZmZmXQ0KWyAgIDEwLjYxNzM2
MF0gcGNpIDAwMDQ6MDQ6MDAuMDogcmVnIDB4MTg6IFtpbyAgMHgyN2ZmZTAwMC0weDI3ZmZlMDFm
XQ0KWyAgIDEwLjYyMzY4MV0gcGNpIDAwMDQ6MDQ6MDAuMDogcmVnIDB4MWM6IFttZW0gMHgyMTE4
MDAwMC0weDIxMTgzZmZmXQ0KWyAgIDEwLjYzMDE4M10gcGNpIDAwMDQ6MDQ6MDAuMDogUE1FIyBz
dXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMC42MzYzMzVdIHBjaSAwMDA0OjA0
OjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFp
bCENClsgICAxMC42NDM5NjddIHBjaSAwMDA0OjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAw
eDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMS0wMl0gYWRkX3NpemUg
MjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMC42NTU3OTBdIHBjaSAwMDA0OjAwOjAzLjA6
IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAzXSBhZGRfc2l6ZSAx
MDAwDQpbICAgMTAuNjYzOTg0XSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93IFttZW0g
MHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIw
MDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTAuNjc1NTc4XSBwY2kgMDAwNDowMDowMy4wOiBi
cmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBbYnVzIDAzXSBhZGRf
c2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDEwLjY4NjE1M10gcGNpIDAwMDQ6MDA6
MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVm
XSB0byBbYnVzIDA0XSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDEwLjY5
NzcxNF0gcGNpIDAwMDQ6MDA6MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgw
MDFmZmZmZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsg
ICAxMC43MDgyOTJdIHBjaSAwMDA0OjAwOjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjAw
MDAwMDAtMHgyMTdmZmZmZl0NClsgICAxMC43MTUwOTNdIHBjaSAwMDA0OjAwOjAxLjA6IEJBUiA5
OiBhc3NpZ25lZCBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MjgwMDAwMWZmZmZmIDY0Yml0IHByZWZd
DQpbICAgMTAuNzIzNjIzXSBwY2kgMDAwNDowMDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAw
eDIxODAwMDAwLTB4MjE5ZmZmZmZdDQpbICAgMTAuNzMwNDYzXSBwY2kgMDAwNDowMDowMy4wOiBC
QVIgOTogYXNzaWduZWQgW21lbSAweDI4MDAwMDIwMDAwMC0weDI4MDAwMDNmZmZmZiA2NGJpdCBw
cmVmXQ0KWyAgIDEwLjczODk4OF0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDg6IGFzc2lnbmVkIFtt
ZW0gMHgyMWEwMDAwMC0weDIxYmZmZmZmXQ0KWyAgIDEwLjc0NTgyMl0gcGNpIDAwMDQ6MDA6MDUu
MDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRi
aXQgcHJlZl0NClsgICAxMC43NTQzNTJdIHBjaSAwMDA0OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFj
ZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC43NjA2NTddIHBjaSAwMDA0OjAwOjAxLjA6
IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuNzY3MzQ2
XSBwY2kgMDAwNDowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBd
DQpbICAgMTAuNzczNjc4XSBwY2kgMDAwNDowMDowMy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjc4MDM3M10gcGNpIDAwMDQ6MDA6MDUuMDogQkFS
IDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjc4NjY5OV0gcGNpIDAw
MDQ6MDA6MDUuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsg
ICAxMC43OTMzOTBdIHBjaSAwMDA0OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBz
aXplIDB4MTAwMF0NClsgICAxMC43OTk3MjVdIHBjaSAwMDA0OjAwOjAxLjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuODA2NDA5XSBwY2kgMDAwNDow
MDowNS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuODEy
Nzk0XSBwY2kgMDAwNDowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUg
MHgxMDAwXQ0KWyAgIDEwLjgxOTQ3M10gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IG5vIHNwYWNl
IGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjgyNTgwM10gcGNpIDAwMDQ6MDA6MDMuMDog
QkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC44MzI0OTZd
IHBjaSAwMDA0OjAxOjAwLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjAwMDAwMDAtMHgyMTdm
ZmZmZl0NClsgICAxMC44MzkzNTJdIHBjaSAwMDA0OjAxOjAwLjA6IEJBUiA3OiBubyBzcGFjZSBm
b3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC44NDU2ODNdIHBjaSAwMDA0OjAxOjAwLjA6IEJB
UiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuODUyMzcyXSBw
Y2kgMDAwNDowMjowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4MjBmZmZm
ZmZdDQpbICAgMTAuODU5MjM2XSBwY2kgMDAwNDowMjowMC4wOiBCQVIgMTogYXNzaWduZWQgW21l
bSAweDIxMDAwMDAwLTB4MjEwMWZmZmZdDQpbICAgMTAuODY2MDkyXSBwY2kgMDAwNDowMjowMC4w
OiBCQVIgMjogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDAwODBdDQpbICAgMTAuODcyNDE3XSBw
Y2kgMDAwNDowMjowMC4wOiBCQVIgMjogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgwMDgw
XQ0KWyAgIDEwLjg3OTEwN10gcGNpIDAwMDQ6MDE6MDAuMDogUENJIGJyaWRnZSB0byBbYnVzIDAy
XQ0KWyAgIDEwLjg4NDEyMl0gcGNpIDAwMDQ6MDE6MDAuMDogICBicmlkZ2Ugd2luZG93IFttZW0g
MHgyMDAwMDAwMC0weDIxN2ZmZmZmXQ0KWyAgIDEwLjg5MTAxNV0gcGNpIDAwMDQ6MDA6MDEuMDog
UENJIGJyaWRnZSB0byBbYnVzIDAxLTAyXQ0KWyAgIDEwLjg5NjI3NV0gcGNpIDAwMDQ6MDA6MDEu
MDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQ0KWyAgIDEwLjkw
MzE1Nl0gcGNpIDAwMDQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyODAwMDAwMDAw
MDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC45MTE2ODhdIHBjaSAwMDA0OjAz
OjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MjE4MDAwMDAtMHgyMTgwMWZmZiA2NGJpdF0N
ClsgICAxMC45MTkwNTZdIHBjaSAwMDA0OjAwOjAzLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwM10N
ClsgICAxMC45MjQwNTBdIHBjaSAwMDA0OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4
MjE4MDAwMDAtMHgyMTlmZmZmZl0NClsgICAxMC45MzA5MzldIHBjaSAwMDA0OjAwOjAzLjA6ICAg
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHBy
ZWZdDQpbICAgMTAuOTM5NDY1XSBwY2kgMDAwNDowNDowMC4wOiBCQVIgMDogYXNzaWduZWQgW21l
bSAweDIxYTAwMDAwLTB4MjFhN2ZmZmZdDQpbICAgMTAuOTQ2MzAyXSBwY2kgMDAwNDowNDowMC4w
OiBCQVIgMzogYXNzaWduZWQgW21lbSAweDIxYTgwMDAwLTB4MjFhODNmZmZdDQpbICAgMTAuOTUz
MTYwXSBwY2kgMDAwNDowNDowMC4wOiBCQVIgMjogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDAw
MjBdDQpbICAgMTAuOTU5NDg0XSBwY2kgMDAwNDowNDowMC4wOiBCQVIgMjogZmFpbGVkIHRvIGFz
c2lnbiBbaW8gIHNpemUgMHgwMDIwXQ0KWyAgIDEwLjk2NjE3M10gcGNpIDAwMDQ6MDA6MDUuMDog
UENJIGJyaWRnZSB0byBbYnVzIDA0XQ0KWyAgIDEwLjk3MTE4NV0gcGNpIDAwMDQ6MDA6MDUuMDog
ICBicmlkZ2Ugd2luZG93IFttZW0gMHgyMWEwMDAwMC0weDIxYmZmZmZmXQ0KWyAgIDEwLjk3ODA2
OV0gcGNpIDAwMDQ6MDA6MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyODAwMDA0MDAwMDAt
MHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC45ODY2MDBdIHBjaV9idXMgMDAwNDow
MDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5IGJvb3Rpbmcg
d2l0aCBwY2k9cmVhbGxvYw0KWyAgIDEwLjk5NTcyM10gcGNpX2J1cyAwMDA0OjAwOiByZXNvdXJj
ZSA0IFttZW0gMHgyMDAwMDAwMC0weDJmZmZmZmZmIHdpbmRvd10NClsgICAxMS4wMDI2MzZdIHBj
aV9idXMgMDAwNDowMDogcmVzb3VyY2UgNSBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MmJmZmRmZmZm
ZmZmIHdpbmRvd10NClsgICAxMS4wMTAyOTBdIHBjaV9idXMgMDAwNDowMTogcmVzb3VyY2UgMSBb
bWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0NClsgICAxMS4wMTY2MDJdIHBjaV9idXMgMDAwNDow
MTogcmVzb3VyY2UgMiBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MjgwMDAwMWZmZmZmIDY0Yml0IHBy
ZWZdDQpbICAgMTEuMDI0NjEzXSBwY2lfYnVzIDAwMDQ6MDI6IHJlc291cmNlIDEgW21lbSAweDIw
MDAwMDAwLTB4MjE3ZmZmZmZdDQpbICAgMTEuMDMwOTI2XSBwY2lfYnVzIDAwMDQ6MDM6IHJlc291
cmNlIDEgW21lbSAweDIxODAwMDAwLTB4MjE5ZmZmZmZdDQpbICAgMTEuMDM3MjYyXSBwY2lfYnVz
IDAwMDQ6MDM6IHJlc291cmNlIDIgW21lbSAweDI4MDAwMDIwMDAwMC0weDI4MDAwMDNmZmZmZiA2
NGJpdCBwcmVmXQ0KWyAgIDExLjA0NTI3M10gcGNpX2J1cyAwMDA0OjA0OiByZXNvdXJjZSAxIFtt
ZW0gMHgyMWEwMDAwMC0weDIxYmZmZmZmXQ0KWyAgIDExLjA1MTU4NV0gcGNpX2J1cyAwMDA0OjA0
OiByZXNvdXJjZSAyIFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJl
Zl0NClsgICAxMS4wNTk2ODNdIEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJN10gKGRvbWFpbiAw
MDA1IFtidXMgMDAtZmZdKQ0KWyAgIDExLjA2NTg2Ml0gYWNwaSBQTlAwQTA4OjA3OiBfT1NDOiBP
UyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgt
VHlwZTNdDQpbICAgMTEuMDc1MDg1XSBhY3BpIFBOUDBBMDg6MDc6IFBDSWUgcG9ydCBzZXJ2aWNl
cyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sDQpbICAgMTEuMDgyOTI5XSBh
Y3BpIFBOUDBBMDg6MDc6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAweDJmZmZmMDAwMDAwMC0w
eDJmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwDQpb
ICAgMTEuMDk1OTA1XSBhY3BpIFBOUDBBMDg6MDc6IEVDQU0gYXJlYSBbbWVtIDB4MmZmZmYwMDAw
MDAwLTB4MmZmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAwQzAyOjAwDQpbICAgMTEuMTA0ODIx
XSBhY3BpIFBOUDBBMDg6MDc6IEVDQU0gYXQgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZm
ZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpbICAgMTEuMTEzMDM5XSBQQ0kgaG9zdCBicmlkZ2UgdG8g
YnVzIDAwMDU6MDANClsgICAxMS4xMTcwOTddIHBjaV9idXMgMDAwNTowMDogcm9vdCBidXMgcmVz
b3VyY2UgW21lbSAweDMwMDAwMDAwLTB4M2ZmZmZmZmYgd2luZG93XQ0KWyAgIDExLjEyNDY5NV0g
cGNpX2J1cyAwMDA1OjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4
MmZmZmRmZmZmZmZmIHdpbmRvd10NClsgICAxMS4xMzI5NTFdIHBjaV9idXMgMDAwNTowMDogcm9v
dCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0NClsgICAxMS4xMzg1MTNdIHBjaSAwMDA1OjAwOjAw
LjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDANClsgICAxMS4xNDQ2MTddIHBj
aSAwMDA1OjAwOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVgg
bWlnaHQgZmFpbCENClsgICAxMS4xNTIyMzRdIHBjaSAwMDA1OjAwOjAxLjA6IFsxZGVmOmUxMTFd
IHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAxMS4xNTgzMTNdIHBjaSAwMDA1OjAwOjAxLjA6
IHN1cHBvcnRzIEQxIEQyDQpbICAgMTEuMTYyNTgyXSBwY2kgMDAwNTowMDowMS4wOiBQTUUjIHN1
cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgMTEuMTY4NDYxXSBwY2kgMDAwNTowMDowMS4w
OiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpb
ICAgMTEuMTc2MTAxXSBwY2kgMDAwNTowMDowMy4wOiBbMWRlZjplMTEzXSB0eXBlIDAxIGNsYXNz
IDB4MDYwNDAwDQpbICAgMTEuMTgyMTc2XSBwY2kgMDAwNTowMDowMy4wOiBzdXBwb3J0cyBEMSBE
Mg0KWyAgIDExLjE4NjQ1M10gcGNpIDAwMDU6MDA6MDMuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE
MCBEMSBEM2hvdA0KWyAgIDExLjE5MjMyOF0gcGNpIDAwMDU6MDA6MDMuMDogRmFpbGVkIHRvIGFk
ZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDExLjE5OTk4MV0g
cGNpIDAwMDU6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMA0KWyAg
IDExLjIwNjA1NV0gcGNpIDAwMDU6MDA6MDUuMDogc3VwcG9ydHMgRDEgRDINClsgICAxMS4yMTAz
MjVdIHBjaSAwMDA1OjAwOjA1LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QNClsg
ICAxMS4yMTYxOThdIHBjaSAwMDA1OjAwOjA1LjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3Vn
aCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMS4yMjM4NDRdIHBjaSAwMDA1OjAwOjA3
LjA6IFsxZGVmOmUxMTddIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAxMS4yMjk5MjNdIHBj
aSAwMDA1OjAwOjA3LjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTEuMjM0MTk2XSBwY2kgMDAwNTow
MDowNy4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgMTEuMjQwMDczXSBw
Y2kgMDAwNTowMDowNy4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1Y
IG1pZ2h0IGZhaWwhDQpbICAgMTEuMjQ4ODQzXSBwY2kgMDAwNTowMjowMC4wOiBbMTkxMjowMDE0
XSB0eXBlIDAwIGNsYXNzIDB4MGMwMzMwDQpbICAgMTEuMjU0ODUyXSBwY2kgMDAwNTowMjowMC4w
OiByZWcgMHgxMDogW21lbSAweDMwMTAwMDAwLTB4MzAxMDFmZmYgNjRiaXRdDQpbICAgMTEuMjYx
ODA1XSBwY2kgMDAwNTowMjowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29s
ZA0KWyAgIDExLjI2Nzk0MF0gcGNpIDAwMDU6MDI6MDAuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0
aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDExLjI3NjY3NV0gcGNpIDAwMDU6
MDQ6MDAuMDogWzEyNmY6MjI2M10gdHlwZSAwMCBjbGFzcyAweDAxMDgwMg0KWyAgIDExLjI4MjY4
NF0gcGNpIDAwMDU6MDQ6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgzMDAwMDAwMC0weDMwMDAzZmZm
IDY0Yml0XQ0KWyAgIDExLjI4OTY4Ml0gcGNpIDAwMDU6MDQ6MDAuMDogRmFpbGVkIHRvIGFkZCAt
IHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDExLjI5NzI5NF0gcGNp
IDAwMDU6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMg
MDFdIGFkZF9zaXplIDEwMDANClsgICAxMS4zMDU1MTZdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRn
ZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAw
MV0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMS4zMTcxMDddIHBjaSAw
MDA1OjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmZdIHRv
IFtidXMgMDFdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMzI3Njg0
XSBwY2kgMDAwNTowMDowMy4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8g
W2J1cyAwMl0gYWRkX3NpemUgMTAwMA0KWyAgIDExLjMzNTg5Nl0gcGNpIDAwMDU6MDA6MDMuMDog
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBb
YnVzIDAyXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjM0NzQ5MF0g
cGNpIDAwMDU6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZm
Zl0gdG8gW2J1cyAwMl0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMS4z
NTgwNzRdIHBjaSAwMDA1OjAwOjA1LjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZm
XSB0byBbYnVzIDAzXSBhZGRfc2l6ZSAxMDAwDQpbICAgMTEuMzY2Mjc3XSBwY2kgMDAwNTowMDow
NS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZd
IHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMzc3
ODcyXSBwY2kgMDAwNTowMDowNS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAw
MGZmZmZmXSB0byBbYnVzIDAzXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAg
IDExLjM4ODQ0N10gcGNpIDAwMDU6MDA6MDcuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0w
eDBmZmZdIHRvIFtidXMgMDRdIGFkZF9zaXplIDEwMDANClsgICAxMS4zOTY2NTldIHBjaSAwMDA1
OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQg
cHJlZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAx
MS40MDgyNTNdIHBjaSAwMDA1OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAw
LTB4MDAxZmZmZmZdIHRvIFtidXMgMDRdIGFkZF9zaXplIDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAw
DQpbICAgMTEuNDE4ODM0XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAw
eDMwMDAwMDAwLTB4MzAxZmZmZmZdDQpbICAgMTEuNDI1NjMzXSBwY2kgMDAwNTowMDowMS4wOiBC
QVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAwMDAwMDAwMC0weDJjMDAwMDFmZmZmZiA2NGJpdCBw
cmVmXQ0KWyAgIDExLjQzNDE2M10gcGNpIDAwMDU6MDA6MDMuMDogQkFSIDg6IGFzc2lnbmVkIFtt
ZW0gMHgzMDIwMDAwMC0weDMwM2ZmZmZmXQ0KWyAgIDExLjQ0MTAwM10gcGNpIDAwMDU6MDA6MDMu
MDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyYzAwMDAyMDAwMDAtMHgyYzAwMDAzZmZmZmYgNjRi
aXQgcHJlZl0NClsgICAxMS40NDk1MjhdIHBjaSAwMDA1OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25l
ZCBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0NClsgICAxMS40NTYzNjJdIHBjaSAwMDA1OjAw
OjA1LjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MmMwMDAwNDAwMDAwLTB4MmMwMDAwNWZmZmZm
IDY0Yml0IHByZWZdDQpbICAgMTEuNDY0ODkyXSBwY2kgMDAwNTowMDowNy4wOiBCQVIgODogYXNz
aWduZWQgW21lbSAweDMwNjAwMDAwLTB4MzA3ZmZmZmZdDQpbICAgMTEuNDcxNzI3XSBwY2kgMDAw
NTowMDowNy4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAwMDYwMDAwMC0weDJjMDAwMDdm
ZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjQ4MDI1N10gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDc6
IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjQ4NjU2NF0gcGNpIDAwMDU6
MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAx
MS40OTMyNTFdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0NClsgICAxMS40OTk1ODNdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTA2Mjc3XSBwY2kgMDAwNTowMDow
NS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTEyNjAz
XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgx
MDAwXQ0KWyAgIDExLjUxOTMwMl0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDc6IG5vIHNwYWNlIGZv
ciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjUyNTYyNV0gcGNpIDAwMDU6MDA6MDcuMDogQkFS
IDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS41MzIzMTddIHBj
aSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsg
ICAxMS41Mzg2NDZdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtp
byAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTQ1MzM0XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzog
bm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTUxNjY2XSBwY2kgMDAwNTow
MDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEx
LjU1ODM2MV0gcGNpIDAwMDU6MDA6MDMuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUg
MHgxMDAwXQ0KWyAgIDExLjU2NDY4N10gcGNpIDAwMDU6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0
byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS41NzEzNzZdIHBjaSAwMDA1OjAwOjAx
LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS41Nzc3MDhd
IHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEw
MDBdDQpbICAgMTEuNTg0Mzk3XSBwY2kgMDAwNTowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMg
MDFdDQpbICAgMTEuNTg5NDA4XSBwY2kgMDAwNTowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21l
bSAweDMwMDAwMDAwLTB4MzAxZmZmZmZdDQpbICAgMTEuNTk2MjkzXSBwY2kgMDAwNTowMDowMS4w
OiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDAwMDAwMC0weDJjMDAwMDFmZmZmZiA2NGJp
dCBwcmVmXQ0KWyAgIDExLjYwNDgyNV0gcGNpIDAwMDU6MDI6MDAuMDogQkFSIDA6IGFzc2lnbmVk
IFttZW0gMHgzMDIwMDAwMC0weDMwMjAxZmZmIDY0Yml0XQ0KWyAgIDExLjYxMjE5NF0gcGNpIDAw
MDU6MDA6MDMuMDogUENJIGJyaWRnZSB0byBbYnVzIDAyXQ0KWyAgIDExLjYxNzE4N10gcGNpIDAw
MDU6MDA6MDMuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDIwMDAwMC0weDMwM2ZmZmZmXQ0K
WyAgIDExLjYyNDA5Ml0gcGNpIDAwMDU6MDA6MDMuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgy
YzAwMDAyMDAwMDAtMHgyYzAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS42MzI2MDJdIHBj
aSAwMDA1OjAwOjA1LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwM10NClsgICAxMS42Mzc1ODVdIHBj
aSAwMDA1OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZm
Zl0NClsgICAxMS42NDQ0NzBdIHBjaSAwMDA1OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVt
IDB4MmMwMDAwNDAwMDAwLTB4MmMwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuNjUzMDAy
XSBwY2kgMDAwNTowNDowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDMwNjAwMDAwLTB4MzA2
MDNmZmYgNjRiaXRdDQpbICAgMTEuNjYwMzcwXSBwY2kgMDAwNTowMDowNy4wOiBQQ0kgYnJpZGdl
IHRvIFtidXMgMDRdDQpbICAgMTEuNjY1MzYzXSBwY2kgMDAwNTowMDowNy4wOiAgIGJyaWRnZSB3
aW5kb3cgW21lbSAweDMwNjAwMDAwLTB4MzA3ZmZmZmZdDQpbICAgMTEuNjcyMjQ4XSBwY2kgMDAw
NTowMDowNy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDYwMDAwMC0weDJjMDAwMDdm
ZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjY4MDc3OV0gcGNpX2J1cyAwMDA1OjAwOiByZXNvdXJj
ZSA0IFttZW0gMHgzMDAwMDAwMC0weDNmZmZmZmZmIHdpbmRvd10NClsgICAxMS42ODc3MDBdIHBj
aV9idXMgMDAwNTowMDogcmVzb3VyY2UgNSBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmZmZmRmZmZm
ZmZmIHdpbmRvd10NClsgICAxMS42OTUzNDhdIHBjaV9idXMgMDAwNTowMTogcmVzb3VyY2UgMSBb
bWVtIDB4MzAwMDAwMDAtMHgzMDFmZmZmZl0NClsgICAxMS43MDE3MjldIHBjaV9idXMgMDAwNTow
MTogcmVzb3VyY2UgMiBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmMwMDAwMWZmZmZmIDY0Yml0IHBy
ZWZdDQpbICAgMTEuNzA5NzI5XSBwY2lfYnVzIDAwMDU6MDI6IHJlc291cmNlIDEgW21lbSAweDMw
MjAwMDAwLTB4MzAzZmZmZmZdDQpbICAgMTEuNzE2MDQxXSBwY2lfYnVzIDAwMDU6MDI6IHJlc291
cmNlIDIgW21lbSAweDJjMDAwMDIwMDAwMC0weDJjMDAwMDNmZmZmZiA2NGJpdCBwcmVmXQ0KWyAg
IDExLjcyNDA1MV0gcGNpX2J1cyAwMDA1OjAzOiByZXNvdXJjZSAxIFttZW0gMHgzMDQwMDAwMC0w
eDMwNWZmZmZmXQ0KWyAgIDExLjczMDM2OF0gcGNpX2J1cyAwMDA1OjAzOiByZXNvdXJjZSAyIFtt
ZW0gMHgyYzAwMDA0MDAwMDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS43Mzgz
NzNdIHBjaV9idXMgMDAwNTowNDogcmVzb3VyY2UgMSBbbWVtIDB4MzA2MDAwMDAtMHgzMDdmZmZm
Zl0NClsgICAxMS43NDQ2ODZdIHBjaV9idXMgMDAwNTowNDogcmVzb3VyY2UgMiBbbWVtIDB4MmMw
MDAwNjAwMDAwLTB4MmMwMDAwN2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuNzUyOTUyXSB4ZW46
YmFsbG9vbjogSW5pdGlhbGlzaW5nIGJhbGxvb24gZHJpdmVyDQpbICAgMTEuNzU3OTQwXSBpb21t
dTogRGVmYXVsdCBkb21haW4gdHlwZTogVHJhbnNsYXRlZCANClsgICAxMS43NjI4OTldIHBjaSAw
MDBkOjAxOjAwLjA6IHZnYWFyYjogVkdBIGRldmljZSBhZGRlZDogZGVjb2Rlcz1pbyttZW0sb3du
cz1ub25lLGxvY2tzPW5vbmUNClsgICAxMS43NzEzMjNdIHBjaSAwMDA0OjAyOjAwLjA6IHZnYWFy
YjogVkdBIGRldmljZSBhZGRlZDogZGVjb2Rlcz1pbyttZW0sb3ducz1ub25lLGxvY2tzPW5vbmUN
ClsgICAxMS43Nzk3MjldIHBjaSAwMDBkOjAxOjAwLjA6IHZnYWFyYjogYnJpZGdlIGNvbnRyb2wg
cG9zc2libGUNClsgICAxMS43ODU1MDNdIHBjaSAwMDA0OjAyOjAwLjA6IHZnYWFyYjogYnJpZGdl
IGNvbnRyb2wgcG9zc2libGUNClsgICAxMS43OTEzMjJdIHBjaSAwMDA0OjAyOjAwLjA6IHZnYWFy
Yjogc2V0dGluZyBhcyBib290IGRldmljZSAoVkdBIGxlZ2FjeSByZXNvdXJjZXMgbm90IGF2YWls
YWJsZSkNClsgICAxMS44MDAzMTFdIHZnYWFyYjogbG9hZGVkDQpbICAgMTEuODAzMDg1XSBTQ1NJ
IHN1YnN5c3RlbSBpbml0aWFsaXplZA0KWyAgIDExLjgwNjgzN10gQUNQSTogYnVzIHR5cGUgVVNC
IHJlZ2lzdGVyZWQNClsgICAxMS44MTA5MzldIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVy
ZmFjZSBkcml2ZXIgdXNiZnMNClsgICAxMS44MTY0OTddIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3
IGludGVyZmFjZSBkcml2ZXIgaHViDQpbICAgMTEuODIxODg0XSB1c2Jjb3JlOiByZWdpc3RlcmVk
IG5ldyBkZXZpY2UgZHJpdmVyIHVzYg0KWyAgIDExLjgyNzAwM10gcHBzX2NvcmU6IExpbnV4UFBT
IEFQSSB2ZXIuIDEgcmVnaXN0ZXJlZA0KWyAgIDExLjgzMjAyMF0gcHBzX2NvcmU6IFNvZnR3YXJl
IHZlci4gNS4zLjYgLSBDb3B5cmlnaHQgMjAwNS0yMDA3IFJvZG9sZm8gR2lvbWV0dGkgPGdpb21l
dHRpQGxpbnV4Lml0Pg0KWyAgIDExLjg0MTI4NF0gUFRQIGNsb2NrIHN1cHBvcnQgcmVnaXN0ZXJl
ZA0KWyAgIDExLjg0NTM0Nl0gUmVnaXN0ZXJlZCBlZml2YXJzIG9wZXJhdGlvbnMNClsgICAxMS44
NDkzMjldIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMA0KWyAgIDExLjg1Mjk0NF0gTm8gQUNQSSBQ
TVUgSVJRIGZvciBDUFUxDQpbICAgMTEuODU2NTk3XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTIN
ClsgICAxMS44NjAyNDFdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMw0KWyAgIDExLjg2Mzg4OF0g
Tm8gQUNQSSBQTVUgSVJRIGZvciBDUFU0DQpbICAgMTEuODY3NTI2XSBObyBBQ1BJIFBNVSBJUlEg
Zm9yIENQVTUNClsgICAxMS44NzExODBdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVNg0KWyAgIDEx
Ljg3NDgxOF0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFU3DQpbICAgMTEuODc4NDcyXSBObyBBQ1BJ
IFBNVSBJUlEgZm9yIENQVTgNClsgICAxMS44ODIxMTBdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BV
OQ0KWyAgIDExLjg4NTc2Ml0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUxMA0KWyAgIDExLjg4OTQ5
MF0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUxMQ0KWyAgIDExLjg5MzIzMF0gTm8gQUNQSSBQTVUg
SVJRIGZvciBDUFUxMg0KWyAgIDExLjg5Njk1NV0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUxMw0K
WyAgIDExLjkwMDcwMV0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUxNA0KWyAgIDExLjkwNDQyMF0g
Tm8gQUNQSSBQTVUgSVJRIGZvciBDUFUxNQ0KWyAgIDExLjkwODE2MF0gTm8gQUNQSSBQTVUgSVJR
IGZvciBDUFUxNg0KWyAgIDExLjkxMTg4Nl0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUxNw0KWyAg
IDExLjkxNTYyNV0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUxOA0KWyAgIDExLjkxOTM1MV0gTm8g
QUNQSSBQTVUgSVJRIGZvciBDUFUxOQ0KWyAgIDExLjkyMzA5NF0gTm8gQUNQSSBQTVUgSVJRIGZv
ciBDUFUyMA0KWyAgIDExLjkyNjgxNl0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUyMQ0KWyAgIDEx
LjkzMDU2M10gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUyMg0KWyAgIDExLjkzNDI4MV0gTm8gQUNQ
SSBQTVUgSVJRIGZvciBDUFUyMw0KWyAgIDExLjkzODAyMV0gTm8gQUNQSSBQTVUgSVJRIGZvciBD
UFUyNA0KWyAgIDExLjk0MTc0N10gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUyNQ0KWyAgIDExLjk0
NTQ4Nl0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUyNg0KWyAgIDExLjk0OTIxMl0gTm8gQUNQSSBQ
TVUgSVJRIGZvciBDUFUyNw0KWyAgIDExLjk1Mjk1Ml0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUy
OA0KWyAgIDExLjk1NjY3N10gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUyOQ0KWyAgIDExLjk2MDQy
M10gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUzMA0KWyAgIDExLjk2NDE0M10gTm8gQUNQSSBQTVUg
SVJRIGZvciBDUFUzMQ0KWyAgIDExLjk2OTIwOV0gY2xvY2tzb3VyY2U6IFN3aXRjaGVkIHRvIGNs
b2Nrc291cmNlIGFyY2hfc3lzX2NvdW50ZXINClsgICAxMi4xNTA5MTZdIHBucDogUG5QIEFDUEkg
aW5pdA0KWyAgIDEyLjE1NTMyM10gc3lzdGVtIDAwOjAwOiBbbWVtIDB4M2JmZmYwMDAwMDAwLTB4
M2JmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsgICAxMi4xNjMyNjBdIHN5
c3RlbSAwMDowMDogW21lbSAweDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZiB3aW5kb3ddIGNv
dWxkIG5vdCBiZSByZXNlcnZlZA0KWyAgIDEyLjE3MTU5NV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4
MjNmZmYwMDAwMDAwLTB4MjNmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsg
ICAxMi4xNzk1NzJdIHN5c3RlbSAwMDowMDogW21lbSAweDI3ZmZmMDAwMDAwMC0weDI3ZmZmZmZm
ZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgMTIuMTg3NTU5XSBzeXN0ZW0gMDA6
MDA6IFttZW0gMHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3Qg
YmUgcmVzZXJ2ZWQNClsgICAxMi4xOTU5MDJdIHN5c3RlbSAwMDowMDogW21lbSAweDJmZmZmMDAw
MDAwMC0weDJmZmZmZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZA0KWyAgIDEy
LjIwNDIzMV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4N2JmZmYwMDAwMDAwLTB4N2JmZmZmZmZmZmZm
IHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsgICAxMi4yMTIyMTFdIHN5c3RlbSAwMDowMDog
W21lbSAweDdmZmZmMDAwMDAwMC0weDdmZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2Vy
dmVkDQpbICAgMTIuMjIwMTk3XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2M2ZmZjAwMDAwMDAtMHg2
M2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjIyODE4M10gc3lz
dGVtIDAwOjAwOiBbbWVtIDB4NjdmZmYwMDAwMDAwLTB4NjdmZmZmZmZmZmZmIHdpbmRvd10gaGFz
IGJlZW4gcmVzZXJ2ZWQNClsgICAxMi4yMzYxNzNdIHN5c3RlbSAwMDowMDogW21lbSAweDZiZmZm
MDAwMDAwMC0weDZiZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgMTIu
MjQ0MTU2XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2ZmZmZjAwMDAwMDAtMHg2ZmZmZmZmZmZmZmYg
d2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjI1MjE0Ml0gc3lzdGVtIDAwOjAwOiBb
bWVtIDB4MzNmZmYwMDAwMDAwLTB4MzNmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJl
c2VydmVkDQpbICAgMTIuMjYwNDgwXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzN2ZmZjAwMDAwMDAt
MHgzN2ZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQNClsgICAxMi4yNjg4
MjRdIHBucDogUG5QIEFDUEk6IGZvdW5kIDEgZGV2aWNlcw0KWyAgIDEyLjI3NjA3OV0gTkVUOiBS
ZWdpc3RlcmVkIHByb3RvY29sIGZhbWlseSAyDQpbICAgMTIuMjgwNjA0XSB0Y3BfbGlzdGVuX3Bv
cnRhZGRyX2hhc2ggaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAob3JkZXI6IDYsIDI2MjE0NCBi
eXRlcywgbGluZWFyKQ0KWyAgIDEyLjI4OTUzNF0gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUg
ZW50cmllczogMjYyMTQ0IChvcmRlcjogOSwgMjA5NzE1MiBieXRlcywgbGluZWFyKQ0KWyAgIDEy
LjI5ODU3MV0gVENQIGJpbmQgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDgsIDEw
NDg1NzYgYnl0ZXMsIGxpbmVhcikNClsgICAxMi4zMDY0NTRdIFRDUDogSGFzaCB0YWJsZXMgY29u
ZmlndXJlZCAoZXN0YWJsaXNoZWQgMjYyMTQ0IGJpbmQgNjU1MzYpDQpbICAgMTIuMzEzMTM3XSBV
RFAgaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGlu
ZWFyKQ0KWyAgIDEyLjMyMDM1MV0gVURQLUxpdGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAo
b3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQ0KWyAgIDEyLjMyODEzM10gTkVUOiBSZWdp
c3RlcmVkIHByb3RvY29sIGZhbWlseSAxDQpbICAgMTIuMzMyNzY0XSBSUEM6IFJlZ2lzdGVyZWQg
bmFtZWQgVU5JWCBzb2NrZXQgdHJhbnNwb3J0IG1vZHVsZS4NClsgICAxMi4zMzg2NzRdIFJQQzog
UmVnaXN0ZXJlZCB1ZHAgdHJhbnNwb3J0IG1vZHVsZS4NClsgICAxMi4zNDM0MjNdIFJQQzogUmVn
aXN0ZXJlZCB0Y3AgdHJhbnNwb3J0IG1vZHVsZS4NClsgICAxMi4zNDgxOTZdIFJQQzogUmVnaXN0
ZXJlZCB0Y3AgTkZTdjQuMSBiYWNrY2hhbm5lbCB0cmFuc3BvcnQgbW9kdWxlLg0KWyAgIDEyLjM1
NDc4N10gcGNpIDAwMGQ6MDE6MDAuMTogRDAgcG93ZXIgc3RhdGUgZGVwZW5kcyBvbiAwMDBkOjAx
OjAwLjANClsgICAxMi4zNjEyMTRdIHBjaSAwMDBkOjAxOjAwLjI6IEQwIHBvd2VyIHN0YXRlIGRl
cGVuZHMgb24gMDAwZDowMTowMC4wDQpbICAgMTIuMzY3NjE5XSBwY2kgMDAwZDowMTowMC4yOiBl
bmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikNClsgICAxMi4zNzMzNjBdIHBjaSAwMDBkOjAx
OjAwLjM6IEQwIHBvd2VyIHN0YXRlIGRlcGVuZHMgb24gMDAwZDowMTowMC4wDQpbICAgMTIuMzc5
NzkyXSBwY2kgMDAwNDowMzowMC4wOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikNClsg
ICAxMi4zODU0OTddIHBjaSAwMDA1OjAyOjAwLjA6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAw
MDAyKQ0KWyAgIDEyLjM5MTIwN10gUENJOiBDTFMgMTI4IGJ5dGVzLCBkZWZhdWx0IDY0DQpbICAg
MTIuMzk3OTI5XSBodyBwZXJmZXZlbnRzOiBlbmFibGVkIHdpdGggYXJtdjhfcG11djNfMCBQTVUg
ZHJpdmVyLCAxIGNvdW50ZXJzIGF2YWlsYWJsZQ0KWyAgIDEyLjQwODA2M10gd29ya2luZ3NldDog
dGltZXN0YW1wX2JpdHM9NDIgbWF4X29yZGVyPTIzIGJ1Y2tldF9vcmRlcj0wDQpbICAgMTIuNDE2
MzA0XSBORlM6IFJlZ2lzdGVyaW5nIHRoZSBpZF9yZXNvbHZlciBrZXkgdHlwZQ0KWyAgIDEyLjQy
MTM1MF0gS2V5IHR5cGUgaWRfcmVzb2x2ZXIgcmVnaXN0ZXJlZA0KWyAgIDEyLjQyNTU3N10gS2V5
IHR5cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQNClsgICAxMi40Mjk5NTFdIEtleSB0eXBlIGNpZnMu
aWRtYXAgcmVnaXN0ZXJlZA0KWyAgIDEyLjQ0OTEyOF0geG9yOiBtZWFzdXJpbmcgc29mdHdhcmUg
Y2hlY2tzdW0gc3BlZWQNClsgICAxMi40NTQ4OTVdICAgIDhyZWdzICAgICAgICAgICA6ICA5ODA3
IE1CL3NlYw0KWyAgIDEyLjQ2MDA1MF0gICAgMzJyZWdzICAgICAgICAgIDogMTE3NjEgTUIvc2Vj
DQpbICAgMTIuNDY1MDc0XSAgICBhcm02NF9uZW9uICAgICAgOiAxMzk2OSBNQi9zZWMNClsgICAx
Mi40NjkzOTJdIHhvcjogdXNpbmcgZnVuY3Rpb246IGFybTY0X25lb24gKDEzOTY5IE1CL3NlYykN
ClsgICAxMi40NzQ5NzNdIEJsb2NrIGxheWVyIFNDU0kgZ2VuZXJpYyAoYnNnKSBkcml2ZXIgdmVy
c2lvbiAwLjQgbG9hZGVkIChtYWpvciAyNDkpDQpbICAgMTIuNDgyNDU3XSBpbyBzY2hlZHVsZXIg
bXEtZGVhZGxpbmUgcmVnaXN0ZXJlZA0KWyAgIDEyLjQ4NzAxNl0gaW8gc2NoZWR1bGVyIGt5YmVy
IHJlZ2lzdGVyZWQNClsgICAxMi40OTI0OThdIGdwaW8tZHdhcGIgQVBNQzBEMDc6MDI6IG5vIElS
USBmb3IgcG9ydDANClsgICAxMi40OTgzNjddIGlucHV0OiBQb3dlciBCdXR0b24gYXMgL2Rldmlj
ZXMvTE5YU1lTVE06MDAvTE5YU1lCVVM6MDAvUE5QMEMwQzowMC9pbnB1dC9pbnB1dDANClsgICAx
Mi41MDY3ODBdIEFDUEk6IFBvd2VyIEJ1dHRvbiBbUFdSQl0NClsgICAxMi41MTExNjBdIEdIRVM6
IEFQRUkgZmlybXdhcmUgZmlyc3QgbW9kZSBpcyBlbmFibGVkIGJ5IEFQRUkgYml0Lg0KWyAgIDEy
LjUxNzM4N10gRUlOSjogRXJyb3IgSU5KZWN0aW9uIGlzIGluaXRpYWxpemVkLg0KWyAgIDEyLjUy
MjEyNF0gQUNQSSBHVERUOiBmb3VuZCAxIFNCU0EgZ2VuZXJpYyBXYXRjaGRvZyhzKS4NClsgICAx
Mi41Mjc5NzJdIHhlbjp4ZW5fZXZ0Y2huOiBFdmVudC1jaGFubmVsIGRldmljZSBpbnN0YWxsZWQN
ClsgICAxMi41MzQxNTBdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIHBsYXRmb3JtIGhhcyBubyBJ
TyBzcGFjZSwgdHJ5aW5nIE1NSU8NClsgICAxMi41NDA5NjFdIGFzdCAwMDA0OjAyOjAwLjA6IFtk
cm1dIFVzaW5nIFAyQSBicmlkZ2UgZm9yIGNvbmZpZ3VyYXRpb24NClsgICAxMi41NDc1MzJdIGFz
dCAwMDA0OjAyOjAwLjA6IFtkcm1dIEFTVCAyNTAwIGRldGVjdGVkDQpbICAgMTIuNTUyNjMyXSBh
c3QgMDAwNDowMjowMC4wOiBbZHJtXSBBbmFsb2cgVkdBIG9ubHkNClsgICAxMi41NTc1ODFdIGFz
dCAwMDA0OjAyOjAwLjA6IFtkcm1dIGRyYW0gTUNMSz04MDAgTWh6IHR5cGU9OCBidXNfd2lkdGg9
MTYNClsgICAxMi41NjQ1MzhdIFtUVE1dIFpvbmUgIGtlcm5lbDogQXZhaWxhYmxlIGdyYXBoaWNz
IG1lbW9yeTogMTIyMzk5ODAgS2lCDQpbICAgMTIuNTcxMTQ4XSBbVFRNXSBab25lICAgZG1hMzI6
IEF2YWlsYWJsZSBncmFwaGljcyBtZW1vcnk6IDIwOTcxNTIgS2lCDQpbICAgMTIuNTc3NzQyXSBb
VFRNXSBJbml0aWFsaXppbmcgcG9vbCBhbGxvY2F0b3INClsgICAxMi41ODIxNDBdIFtUVE1dIElu
aXRpYWxpemluZyBETUEgcG9vbCBhbGxvY2F0b3INClsgICAxMi41ODcxODBdIFtkcm1dIEluaXRp
YWxpemVkIGFzdCAwLjEuMCAyMDEyMDIyOCBmb3IgMDAwNDowMjowMC4wIG9uIG1pbm9yIDANClsg
ICAxMi42MTIxOTRdIENvbnNvbGU6IHN3aXRjaGluZyB0byBjb2xvdXIgZnJhbWUgYnVmZmVyIGRl
dmljZSAxMjh4NDgNClsgICAxMi42MjA2NTRdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIGZiMDog
YXN0ZHJtZmIgZnJhbWUgYnVmZmVyIGRldmljZQ0KWyAgIDEyLjY0MTc4OF0gYnJkOiBtb2R1bGUg
bG9hZGVkDQpbICAgMTIuNjQ5MzE5XSBsb29wOiBtb2R1bGUgbG9hZGVkDQpbICAgMTIuNjUyOTQw
XSBudm1lIG52bWUwOiBwY2kgZnVuY3Rpb24gMDAwNTowNDowMC4wDQpbICAgMTIuNjU3OTA5XSBp
Z2I6IEludGVsKFIpIEdpZ2FiaXQgRXRoZXJuZXQgTmV0d29yayBEcml2ZXINClsgICAxMi42NTk4
NTNdICAqKioqKioqIGRtYV9hbGxvY19hdHRycygpIC0+IG9wcy0+YWxsb2MoKSAqKioqKioqKioN
ClsgICAxMi42NjMyOTBdIGlnYjogQ29weXJpZ2h0IChjKSAyMDA3LTIwMTQgSW50ZWwgQ29ycG9y
YXRpb24uDQpbICAgMTIuNjc1NjE2XSAgKioqKioqKiBJbiBkbWFfYWxsb2NfZGlyZWN0KCkgZnVu
Y3Rpb24gKioqKioqKioqDQpbICAgMTIuNjgxMzQ0XSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMo
KSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioqDQpbICAgMTIuNjg4MDcxXSAgKioqKioqKiBJbiBk
bWFfYWxsb2NfZGlyZWN0KCkgZnVuY3Rpb24gKioqKioqKioqDQpbICAgMTIuNjk3Mzc4XSBudm1l
IG52bWUwOiBtaXNzaW5nIG9yIGludmFsaWQgU1VCTlFOIGZpZWxkLg0KWyAgIDEyLjcwMzkzMV0g
ICoqKioqKiogZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKg0KWyAg
IDEyLjcwODc3MF0gcHBzIHBwczA6IG5ldyBQUFMgc291cmNlIHB0cDANClsgICAxMi43MDk5MzBd
ICAqKioqKioqIEluIGRtYV9hbGxvY19kaXJlY3QoKSBmdW5jdGlvbiAqKioqKioqKioNClsgICAx
Mi43MTQwNDVdIGlnYiAwMDA0OjA0OjAwLjA6IGFkZGVkIFBIQyBvbiBldGgwDQpbICAgMTIuNzE5
ODIwXSAgKioqKioqKiBkbWFfYWxsb2NfYXR0cnMoKSAtPiBvcHMtPmFsbG9jKCkgKioqKioqKioq
DQpbICAgMTIuNzI0NDAzXSBpZ2IgMDAwNDowNDowMC4wOiBJbnRlbChSKSBHaWdhYml0IEV0aGVy
bmV0IE5ldHdvcmsgQ29ubmVjdGlvbg0KWyAgIDEyLjczMDQ5N10gICoqKioqKiogSW4gZG1hX2Fs
bG9jX2RpcmVjdCgpIGZ1bmN0aW9uICoqKioqKioqKg0KWyAgIDEyLjczMDc0OV0gICoqKioqKiog
ZG1hX2FsbG9jX2F0dHJzKCkgLT4gb3BzLT5hbGxvYygpICoqKioqKioqKg0KWyAgIDEyLjczNzQ1
NV0gaWdiIDAwMDQ6MDQ6MDAuMDogZXRoMDogKFBDSWU6Mi41R2IvczpXaWR0aCB4MSkgMDA6MzA6
NjQ6M2I6NTA6NTINClsgICAxMi43Mzc1MTVdIGlnYiAwMDA0OjA0OjAwLjA6IGV0aDA6IFBCQSBO
bzogMDAwMzAwLTAwMA0KWyAgIDEyLjc0MzI1NV0gICoqKioqKiogSW4gZG1hX2FsbG9jX2RpcmVj
dCgpIGZ1bmN0aW9uICoqKioqKioqKg0KWyAgIDEyLjc0MzI2OF0gVW5hYmxlIHRvIGhhbmRsZSBr
ZXJuZWwgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIGF0IHZpcnR1YWwgYWRkcmVzcyAwMDAwMDAw
MDAwMDAwMDA4DQpbICAgMTIuNzQ5MzM2XSBpZ2IgMDAwNDowNDowMC4wOiBVc2luZyBNU0ktWCBp
bnRlcnJ1cHRzLiA0IHJ4IHF1ZXVlKHMpLCA0IHR4IHF1ZXVlKHMpDQpbICAgMTIuNzU2NTUzXSBN
ZW0gYWJvcnQgaW5mbzoNClsgICAxMi43NTY1NTVdICAgRVNSID0gMHg5NjAwMDA0NA0KWyAgIDEy
Ljc1NjU1OV0gICBFQyA9IDB4MjU6IERBQlQgKGN1cnJlbnQgRUwpLCBJTCA9IDMyIGJpdHMNClsg
ICAxMi43NjE3OTZdIGlnYnZmOiBJbnRlbChSKSBHaWdhYml0IFZpcnR1YWwgRnVuY3Rpb24gTmV0
d29yayBEcml2ZXINClsgICAxMi43Njc1NThdICAgU0VUID0gMCwgRm5WID0gMA0KWyAgIDEyLjc2
NzU1OV0gICBFQSA9IDAsIFMxUFRXID0gMA0KWyAgIDEyLjc2NzU1OV0gRGF0YSBhYm9ydCBpbmZv
Og0KWyAgIDEyLjc2NzU2MF0gICBJU1YgPSAwLCBJU1MgPSAweDAwMDAwMDQ0DQpbICAgMTIuNzY3
NTY1XSAgIENNID0gMCwgV25SID0gMQ0KWyAgIDEyLjc3NjQ1OV0gaWdidmY6IENvcHlyaWdodCAo
YykgMjAwOSAtIDIwMTIgSW50ZWwgQ29ycG9yYXRpb24uDQpbICAgMTIuNzg0MDgwXSBbMDAwMDAw
MDAwMDAwMDAwOF0gdXNlciBhZGRyZXNzIGJ1dCBhY3RpdmVfbW0gaXMgc3dhcHBlcg0KWyAgIDEy
Ljc4NDA4NF0gSW50ZXJuYWwgZXJyb3I6IE9vcHM6IDk2MDAwMDQ0IFsjMV0gUFJFRU1QVCBTTVAN
ClsgICAxMi43ODY4OTVdIGk0MGU6IEludGVsKFIpIEV0aGVybmV0IENvbm5lY3Rpb24gWEw3MTAg
TmV0d29yayBEcml2ZXINClsgICAxMi43OTAwMDZdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgIDEy
Ljc5MDAwOV0gQ1BVOiAyIFBJRDogNyBDb21tOiBrd29ya2VyL3U2NDowIFRhaW50ZWQ6IEcgICAg
ICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgMTIuNzkw
MDIwXSBXb3JrcXVldWU6IG52bWUtcmVzZXQtd3EgbnZtZV9yZXNldF93b3JrDQpbICAgMTIuNzk1
NDMxXSBpNDBlOiBDb3B5cmlnaHQgKGMpIDIwMTMgLSAyMDE5IEludGVsIENvcnBvcmF0aW9uLg0K
WyAgIDEyLjgwMTc4M10gDQpbICAgMTIuODAxNzg1XSBwc3RhdGU6IDYwYzAwMDg1IChuWkN2IGRh
SWYgK1BBTiArVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgMTIuODAxNzg5XSBwYyA6IHN0ZWFsX3N1
aXRhYmxlX2ZhbGxiYWNrKzB4MTM4LzB4MmYwDQpbICAgMTIuODAxNzk0XSBsciA6IHN0ZWFsX3N1
aXRhYmxlX2ZhbGxiYWNrKzB4MWJjLzB4MmYwDQpbICAgMTIuODA1MDU4XSBpNDBlIDAwMDA6MDE6
MDAuMDogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpDQpbICAgMTIuODA4MDY2XSBzcCA6
IGZmZmY4MDAwMTE5NmI4MTANClsgICAxMi44MDgwNjddIHgyOTogZmZmZjgwMDAxMTk2YjgxMCB4
Mjg6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgMTIuODk4Mzg1XSB4Mjc6IDAwMDAwMDAwMDAwMDAw
MDAgeDI2OiBmZmZmODAwMDExNGRiY2IwIA0KWyAgIDEyLjkwMzc3MF0geDI1OiBmZmZmZmRmZmZm
ZTAwMDAwIHgyNDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAxMi45MDkxNDhdIHgyMzogMDAwMDAw
MDAwMDAwMDAwMCB4MjI6IGZmZmZmZTFmZmRmOTAwMDAgDQpbICAgMTIuOTE0NTMzXSB4MjE6IGZm
ZmYwODA3MWNmZGY5ODAgeDIwOiAwMDAwMDAwMDAwMDAwOTAxIA0KWyAgIDEyLjkxOTkxMV0geDE5
OiAwMDAwMDAwMDAwMDgwMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAxMi45MjUyOTRd
IHgxNzogMDAwMDAwMDAwMDAwMDAwZSB4MTY6IDAwMDAwMDAwZGVhZGJlZWYgDQpbICAgMTIuOTMw
Njc3XSB4MTU6IGZmZmY4MDAwOTE5NmI5NTcgeDE0OiAwMDAwMDAwMDAwMDAwMDA2IA0KWyAgIDEy
LjkzNjA1N10geDEzOiBmZmZmODAwMDExOTZiOTVmIHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsg
ICAxMi45NDE0NDBdIHgxMTogMDAwMDAwMDAwMDAwMDQwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMGMg
DQpbICAgMTIuOTQ2ODIxXSB4OSA6IGZmZmY4MDAwMTAwMzlkNTggeDggOiAwMDAwMDAwMDgwMDAw
MDAwIA0KWyAgIDEyLjk1MjIwM10geDcgOiAwMDAwMDAwMDAwMDAwMDE4IHg2IDogZmZmZjgwMDAx
MTc1MDg5MCANClsgICAxMi45NTc1ODVdIHg1IDogZmZmZjgwMDAxMTc1MDg3OCB4NCA6IDAwMDAw
MDAwMDAwMDAwMDAgDQpbICAgMTIuOTYyOTY4XSB4MyA6IDAwMDAwMDAwMDAwMDAwMDAgeDIgOiAw
MDAwMDAwMDAwMDAwMDAwIA0KWyAgIDEyLjk2ODM0OV0geDEgOiAwMDAwMDAwMDAwMDAwMjAwIHgw
IDogMDAwMDAwMDAwMDAwMDAwMCANClsgICAxMi45NzM3MzZdIENhbGwgdHJhY2U6DQpbICAgMTIu
OTc2MTk4XSAgc3RlYWxfc3VpdGFibGVfZmFsbGJhY2srMHgxMzgvMHgyZjANClsgICAxMi45ODA5
MjRdICBnZXRfcGFnZV9mcm9tX2ZyZWVsaXN0KzB4ZTMwLzB4MTJhMA0KWyAgIDEyLjk4NTYxM10g
IF9fYWxsb2NfcGFnZXNfbm9kZW1hc2srMHgxNDgvMHhlMDANClsgICAxMi45OTAyMTJdICBfX2Rt
YV9kaXJlY3RfYWxsb2NfcGFnZXMrMHhhNC8weDFkMA0KWyAgIDEyLjk5NDkwMl0gIGRtYV9kaXJl
Y3RfYWxsb2MrMHg3Yy8weDJiOA0KWyAgIDEyLjk5ODg4Ml0gIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50KzB4NjgvMHgzNzANClsgICAxMy4wMDM3NjNdICBkbWFfYWxsb2NfYXR0cnMrMHhkOC8w
eDExMA0KWyAgIDEzLjAwNzY0N10gIG52bWVfcmVzZXRfd29yaysweDEwMzAvMHgxNTIwDQpbICAg
MTMuMDExODE4XSAgcHJvY2Vzc19vbmVfd29yaysweDFkYy8weDRiYw0KWyAgIDEzLjAxNTg5NF0g
IHdvcmtlcl90aHJlYWQrMHgxNDQvMHg0NzANClsgICAxMy4wMTk3MTBdICBrdGhyZWFkKzB4MTRj
LzB4MTYwDQpbICAgMTMuMDIyOTk5XSAgcmV0X2Zyb21fZm9yaysweDEwLzB4MzgNClsgICAxMy4w
MjY2NTJdIENvZGU6IGE5NDA4MmM0IGQzN2VmNDYzIGNiM2M0MDYzIDhiM2M0MDQyIChmOTAwMDQ4
MCkgDQpbICAgMTMuMDMyODU3XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjcyIF0tLS0N
ClsgICAxMy4wMzc1MTldIG5vdGU6IGt3b3JrZXIvdTY0OjBbN10gZXhpdGVkIHdpdGggcHJlZW1w
dF9jb3VudCAxDQpbICAgMzQuMDUzMjExXSByY3U6IElORk86IHJjdV9wcmVlbXB0IGRldGVjdGVk
IHN0YWxscyBvbiBDUFVzL3Rhc2tzOg0KWyAgIDM0LjA1OTMxMF0gcmN1OiAJMC0uLi4wOiAoMjEg
dGlja3MgdGhpcyBHUCkgaWRsZT0zNTYvMS8weDQwMDAwMDAwMDAwMDAwMDAgc29mdGlycT03OS84
MSBmcXM9MjYyNSANClsgICAzNC4wNjgzODRdIHJjdTogCTEzLS4uLjA6ICg1IEdQcyBiZWhpbmQp
IGlkbGU9OWFlLzEvMHg0MDAwMDAwMDAwMDAwMDAwIHNvZnRpcnE9MzQvMzQgZnFzPTI2MjUgDQpb
ICAgMzQuMDc3MTQ3XSAJKGRldGVjdGVkIGJ5IDIsIHQ9NTI1MiBqaWZmaWVzLCBnPS0xMDcxLCBx
PTIpDQoNCg==

--_007_8C5118886183421EA4C7B271DAF46696armcom_
Content-Type: application/octet-stream; name="native_linux_boot.log"
Content-Description: native_linux_boot.log
Content-Disposition: attachment; filename="native_linux_boot.log"; size=91753;
	creation-date="Thu, 14 Apr 2022 17:44:24 GMT";
	modification-date="Thu, 14 Apr 2022 17:44:24 GMT"
Content-ID: <301A4B6B0815CF4683CE5A494AE456A4@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogVGh1IEFwciAxNCAxMTozNjo1NyBvbiB0dHlzMDAxCnJhaHNpbjAxQEMwMlpY
MEc5TFZETiB4ODZfNjQgJSB0ZWxuZXQgZTEyMzM0My5jYW1icmlkZ2UuYXJtLmNvbSAxMDAyMApU
cnlpbmcgMTAuMS4xOTQuMjUuLi4KQ29ubmVjdGVkIHRvIGUxMjMzNDMuY2FtYnJpZGdlLmFybS5j
b20uCkVzY2FwZSBjaGFyYWN0ZXIgaXMgJ15dJy4KCkFJUyB0YXJnZXQgc3lzdGVtIHBvcnQgMTAw
MjAgZGV2aWNlIC9kZXYvdHR5VVNCMSBbMTE1MjAwIE44MV0KCgpTaGVsbD4gClNoZWxsPiBmczA6
CkZTMDpcPiBjZCBFRkkKRlMwOlxFRklcPiBjZCBCT09UCkZTMDpcRUZJXEJPT1RcPiBib290YWE2
NC5lZmkKV2VsY29tZSB0byBHUlVCIQoKZXJyb3I6IG5vIHN1Y2ggZGV2aWNlOiAoKGhkMCxncHQx
KS9FRkkvQk9PVCkvRUZJL0JPT1QvZ3J1Yi5jZmcuCgoKCgoKCgoKCgoKCgoKCgoKCgoKCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgR05VIEdSVUIgIHZlcnNpb24gMi4wNgoKIC8tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tXAogfCBQQVJUVVVJRCBCb290OiBDT00tSFBDIFlvY3RvIEltYWdlICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IAogfCBOVk1lIE0uMiAgU1NEIEJv
b3Q6IENPTS1IUEMgWW9jdG8gSW1hZ2UgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICB8CiB8KlVTQiBCb290IChJZiBEcml2ZSBpcyBwcmVzZW50KTogQ09NLUhQQyBZb2N0byBJbWFn
ZSAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgQ09NLUhQQyBZb2N0byBJbWFnZSAoWGVuKSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAKIFwtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLwoKICAg
ICAgVXNlIHRoZSBeIGFuZCB2IGtleXMgdG8gc2VsZWN0IHdoaWNoIGVudHJ5IGlzIGhpZ2hsaWdo
dGVkLiAgICAgICAgICAKICAgICAgUHJlc3MgZW50ZXIgdG8gYm9vdCB0aGUgc2VsZWN0ZWQgT1Ms
IGBlJyB0byBlZGl0IHRoZSBjb21tYW5kcyAgICAgICAKICAgICAgYmVmb3JlIGJvb3Rpbmcgb3Ig
YGMnIGZvciBhIGNvbW1hbmQtbGluZS4gICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCgoKCgoKCgoKCgoKCgoKCgoK
CgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKRUZJIHN0dWI6IEJvb3RpbmcgTGludXgg
S2VybmVsLi4uCkVGSSBzdHViOiBVc2luZyBEVEIgZnJvbSBjb25maWd1cmF0aW9uIHRhYmxlCkVG
SSBzdHViOiBFeGl0aW5nIGJvb3Qgc2VydmljZXMgYW5kIGluc3RhbGxpbmcgdmlydHVhbCBhZGRy
ZXNzIG1hcC4uLgpQUk9HUkVTUyBDT0RFOiBWMDMxMDEwMTkgSTAKWyAgICAwLjAwMDAwMF0gQm9v
dGluZyBMaW51eCBvbiBwaHlzaWNhbCBDUFUgMHgwMDAwMTAwMDAwIFsweDQxM2ZkMGMxXQpbICAg
IDAuMDAwMDAwXSBMaW51eCB2ZXJzaW9uIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCAob2Ut
dXNlckBvZS1ob3N0KSAoYWFyY2g2NC1wb2t5LWxpbnV4LWdjYyAoR0NDKSAxMS4yLjAsIEdOVSBs
ZCAoR05VIEJpbnV0aWxzKSAyLjM3LjIwMjEwNzIxKSAjMSBTTVAgUFJFRU1QVCBTYXQgU2VwIDE4
IDA2OjAxOjU5IFVUQyAyMDIxClsgICAgMC4wMDAwMDBdIGVmaTogRUZJIHYyLjcwIGJ5IEVESyBJ
SQpbICAgIDAuMDAwMDAwXSBlZmk6IFRQTUZpbmFsTG9nPTB4ODA3ZjllZjAwMDAgQUNQSSAyLjA9
MHg4MDdmYTBkMDAxOCBTTUJJT1MgMy4wPTB4ODA3ZjhlMzAwMDAgTUVNQVRUUj0weDgwN2Y3ZGUw
MDE4IEVTUlQ9MHg4MDdmN2Y1OGU5OCBUUE1FdmVudExvZz0weDgwN2Y3ZGUxMDE4IFJORz0weGZm
YjRiYTk4IE1FTVJFU0VSVkU9MHg4MDdmN2ViN2U5OCAKWyAgICAwLjAwMDAwMF0gZWZpOiBzZWVk
aW5nIGVudHJvcHkgcG9vbApbICAgIDAuMDAwMDAwXSBlc3J0OiBSZXNlcnZpbmcgRVNSVCBzcGFj
ZSBmcm9tIDB4MDAwMDA4MDdmN2Y1OGU5OCB0byAweDAwMDAwODA3ZjdmNThlZDAuClsgICAgMC4w
MDAwMDBdIEFDUEk6IEVhcmx5IHRhYmxlIGNoZWNrc3VtIHZlcmlmaWNhdGlvbiBkaXNhYmxlZApb
ICAgIDAuMDAwMDAwXSBBQ1BJOiBSU0RQIDB4MDAwMDA4MDdGQTBEMDAxOCAwMDAwMjQgKHYwMiBB
bXBlcmUpClsgICAgMC4wMDAwMDBdIEFDUEk6IFhTRFQgMHgwMDAwMDgwN0ZBMERGRTk4IDAwMDBB
NCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAw
MDAwXSBBQ1BJOiBGQUNQIDB4MDAwMDA4MDdGQTBERkI5OCAwMDAxMTQgKHYwNiBBbXBlcmUgQWx0
cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogRFNEVCAw
eDAwMDAwODA3RjhEQjAwMTggMDJDMTlFICh2MDIgQW1wZXJlIEphZGUgICAgIDAwMDAwMDAxIElO
VEwgMjAyMDEyMTcpClsgICAgMC4wMDAwMDBdIEFDUEk6IEJFUlQgMHgwMDAwMDgwN0ZBMERGRjk4
IDAwMDAzMCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAg
IDAuMDAwMDAwXSBBQ1BJOiBEQkcyIDB4MDAwMDA4MDdGQTBERkE5OCAwMDAwNUMgKHYwMCBBbXBl
cmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTog
R1REVCAweDAwMDAwODA3RkEwREU5OTggMDAwMTEwICh2MDMgQW1wZXJlIEFsdHJhICAgIDAwMDAw
MDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1IgMHgwMDAwMDgwN0ZB
MERGRTE4IDAwMDA1MCAodjAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEz
KQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBFSU5KIDB4MDAwMDA4MDdGQTBERjU5OCAwMDAxNTAgKHYw
MSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNykKWyAgICAwLjAwMDAwMF0g
QUNQSTogSEVTVCAweDAwMDAwODA3RkEwREVCMTggMDAwMUY0ICh2MDEgQW1wZXJlIEFsdHJhICAg
IDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNTRFQgMHgwMDAw
MDgwN0ZBMERGQTE4IDAwMDAyRCAodjAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIw
MjAxMjE3KQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBUUE0yIDB4MDAwMDA4MDdGQTBERkQxOCAwMDAw
NEMgKHYwNCBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAw
MDAwMF0gQUNQSTogTUNGRyAweDAwMDAwODA3RkEwREY3MTggMDAwMDdDICh2MDEgQW1wZXJlIEFs
dHJhICAgIDAwMDAwMDAxIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IElPUlQg
MHgwMDAwMDgwN0ZBMERFRjE4IDAwMDNEQyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBB
TVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBBUElDIDB4MDAwMDA4MDdGQTBENzUx
OCAwMDBBRjQgKHYwNSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAg
ICAwLjAwMDAwMF0gQUNQSTogUFBUVCAweDAwMDAwODA3RkEwRDg2MTggMDA0NTIwICh2MDIgQW1w
ZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6
IFNMSVQgMHgwMDAwMDgwN0ZBMERGRDk4IDAwMDAyRCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAw
MDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUIDB4MDAwMDA4MDdG
QTBEQ0UxOCAwMDAzNzAgKHYwMyBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAx
MykKWyAgICAwLjAwMDAwMF0gQUNQSTogUENDVCAweDAwMDAwODA3RkEwREUzMTggMDAwNTc2ICh2
MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBd
IEFDUEk6IFNQQ1I6IGNvbnNvbGU6IHBsMDExLG1taW8zMiwweDEwMDAwMjYwMDAwMCwxMTUyMDAK
WyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4ODMwMDAwMC0w
eDg4M2ZmZmZmXQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAw
eDkwMDAwMDAwLTB4ZmZmZmZmZmZdClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQ
WE0gMCBbbWVtIDB4ODAwMDAwMDAwMDAtMHg4MDA3ZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gQUNQ
STogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4MDEwMDAwMDAwMC0weDgwN2ZmZmZmZmZmXQpb
ICAgIDAuMDAwMDAwXSBOVU1BOiBOT0RFX0RBVEEgW21lbSAweDgwN2ZjMDcwZTAwLTB4ODA3ZmMw
NzJmZmZdClsgICAgMC4wMDAwMDBdIFpvbmUgcmFuZ2VzOgpbICAgIDAuMDAwMDAwXSAgIERNQSAg
ICAgIFttZW0gMHgwMDAwMDAwMDg4MzAwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0KWyAgICAwLjAw
MDAwMF0gICBETUEzMiAgICBlbXB0eQpbICAgIDAuMDAwMDAwXSAgIE5vcm1hbCAgIFttZW0gMHgw
MDAwMDAwMTAwMDAwMDAwLTB4MDAwMDA4MDdmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gTW92YWJs
ZSB6b25lIHN0YXJ0IGZvciBlYWNoIG5vZGUKWyAgICAwLjAwMDAwMF0gRWFybHkgbWVtb3J5IG5v
ZGUgcmFuZ2VzClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMDg4MzAw
MDAwLTB4MDAwMDAwMDA4ODNmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAw
eDAwMDAwMDAwOTAwMDAwMDAtMHgwMDAwMDAwMDkxZmZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5v
ZGUgICAwOiBbbWVtIDB4MDAwMDAwMDA5MjAwMDAwMC0weDAwMDAwMDAwOTI3YmZmZmZdClsgICAg
MC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMDkyN2MwMDAwLTB4MDAwMDAwMDBm
ZmIzZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwZmZiNDAw
MDAtMHgwMDAwMDAwMGZmYjRmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4
MDAwMDAwMDBmZmI1MDAwMC0weDAwMDAwMDAwZmZmZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9k
ZSAgIDA6IFttZW0gMHgwMDAwMDgwMDAwMDAwMDAwLTB4MDAwMDA4MDA3ZmZmZmZmZl0KWyAgICAw
LjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODAxMDAwMDAwMDAtMHgwMDAwMDgwN2Y2
YTNmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmNmE0MDAw
MC0weDAwMDAwODA3ZjZhZGZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgw
MDAwMDgwN2Y2YWUwMDAwLTB4MDAwMDA4MDdmNmJkM2ZmZl0KWyAgICAwLjAwMDAwMF0gICBub2Rl
ICAgMDogW21lbSAweDAwMDAwODA3ZjZiZDQwMDAtMHgwMDAwMDgwN2Y3Mjk3ZmZmXQpbICAgIDAu
MDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmNzI5ODAwMC0weDAwMDAwODA3Zjdl
N2ZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y3ZTgwMDAw
LTB4MDAwMDA4MDdmN2U5ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAw
MDAwODA3ZjdlYTAwMDAtMHgwMDAwMDgwN2Y3ZWVmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUg
ICAwOiBbbWVtIDB4MDAwMDA4MDdmN2VmMDAwMC0weDAwMDAwODA3ZjdmMmZmZmZdClsgICAgMC4w
MDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y3ZjMwMDAwLTB4MDAwMDA4MDdmODdl
ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3Zjg3ZjAwMDAt
MHgwMDAwMDgwN2Y4ODJmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAw
MDA4MDdmODgzMDAwMC0weDAwMDAwODA3ZjhhNmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAg
IDA6IFttZW0gMHgwMDAwMDgwN2Y4YTcwMDAwLTB4MDAwMDA4MDdmOGFhZmZmZl0KWyAgICAwLjAw
MDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjhhYjAwMDAtMHgwMDAwMDgwN2Y4ZTFm
ZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOGUyMDAwMC0w
eDAwMDAwODA3ZjhlM2ZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAw
MDgwN2Y4ZTQwMDAwLTB4MDAwMDA4MDdmOGU2ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAg
MDogW21lbSAweDAwMDAwODA3ZjhlNzAwMDAtMHgwMDAwMDgwN2Y5ZTdmZmZmXQpbICAgIDAuMDAw
MDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOWU4MDAwMC0weDAwMDAwODA3ZjllZWZm
ZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y5ZWYwMDAwLTB4
MDAwMDA4MDdmOWYxZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAw
ODA3ZjlmMjAwMDAtMHgwMDAwMDgwN2Y5ZmJmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAw
OiBbbWVtIDB4MDAwMDA4MDdmOWZjMDAwMC0weDAwMDAwODA3ZjlmZmZmZmZdClsgICAgMC4wMDAw
MDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhMDAwMDAwLTB4MDAwMDA4MDdmYTBmZmZm
Zl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmExMDAwMDAtMHgw
MDAwMDgwN2ZhMTlmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4
MDdmYTFhMDAwMC0weDAwMDAwODA3ZmEyNmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6
IFttZW0gMHgwMDAwMDgwN2ZhMjcwMDAwLTB4MDAwMDA4MDdmYTRhZmZmZl0KWyAgICAwLjAwMDAw
MF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmE0YjAwMDAtMHgwMDAwMDgwN2ZhNzFmZmZm
XQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTcyMDAwMC0weDAw
MDAwODA3ZmE3NWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgw
N2ZhNzYwMDAwLTB4MDAwMDA4MDdmYThjZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDog
W21lbSAweDAwMDAwODA3ZmE4ZDAwMDAtMHgwMDAwMDgwN2ZhOTZmZmZmXQpbICAgIDAuMDAwMDAw
XSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTk3MDAwMC0weDAwMDAwODA3ZmE5ZmZmZmZd
ClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhYTAwMDAwLTB4MDAw
MDA4MDdmYmFhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3
ZmJhYjAwMDAtMHgwMDAwMDgwN2ZiYjNmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBb
bWVtIDB4MDAwMDA4MDdmYmI0MDAwMC0weDAwMDAwODA3ZmJiZGZmZmZdClsgICAgMC4wMDAwMDBd
ICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZiYmUwMDAwLTB4MDAwMDA4MDdmYmNhZmZmZl0K
WyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmJjYjAwMDAtMHgwMDAw
MDgwN2ZiY2VmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdm
YmNmMDAwMC0weDAwMDAwODA3ZmJkNWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFtt
ZW0gMHgwMDAwMDgwN2ZiZDYwMDAwLTB4MDAwMDA4MDdmYmRmZmZmZl0KWyAgICAwLjAwMDAwMF0g
ICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmJlMDAwMDAtMHgwMDAwMDgwN2ZmZmZmZmZmXQpb
ICAgIDAuMDAwMDAwXSBJbml0bWVtIHNldHVwIG5vZGUgMCBbbWVtIDB4MDAwMDAwMDA4ODMwMDAw
MC0weDAwMDAwODA3ZmZmZmZmZmZdClsgICAgMC4wMDAwMDBdIHBzY2k6IHByb2JpbmcgZm9yIGNv
bmR1aXQgbWV0aG9kIGZyb20gQUNQSS4KWyAgICAwLjAwMDAwMF0gcHNjaTogUFNDSXYxLjEgZGV0
ZWN0ZWQgaW4gZmlybXdhcmUuClsgICAgMC4wMDAwMDBdIHBzY2k6IFVzaW5nIHN0YW5kYXJkIFBT
Q0kgdjAuMiBmdW5jdGlvbiBJRHMKWyAgICAwLjAwMDAwMF0gcHNjaTogTUlHUkFURV9JTkZPX1RZ
UEUgbm90IHN1cHBvcnRlZC4KWyAgICAwLjAwMDAwMF0gcHNjaTogU01DIENhbGxpbmcgQ29udmVu
dGlvbiB2MS4yClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURS
IDB4ODAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAw
IC0+IE1QSURSIDB4ODAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNS
QVQ6IFBYTSAwIC0+IE1QSURSIDB4OTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6
IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4OTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAw
MDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZTAwMDAgLT4gTm9kZSAwClsg
ICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZTAxMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
ZjAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+
IE1QSURSIDB4ZjAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6
IFBYTSAwIC0+IE1QSURSIDB4MTAwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBO
VU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDEwMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAw
MF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxMTAwMDAgLT4gTm9kZSAwClsg
ICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTEwMTAwIC0+
IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAw
eDE2MDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAg
LT4gTVBJRFIgMHgxNjAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNS
QVQ6IFBYTSAwIC0+IE1QSURSIDB4MTcwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE3MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAw
MDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxODAwMDAgLT4gTm9kZSAw
ClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTgwMTAw
IC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElE
UiAweDE5MDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhN
IDAgLT4gTVBJRFIgMHgxOTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6
IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MWUwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBB
Q1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDFlMDEwMCAtPiBOb2RlIDAKWyAgICAw
LjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxZjAwMDAgLT4gTm9k
ZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MWYw
MTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBN
UElEUiAweDIwMDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDog
UFhNIDAgLT4gTVBJRFIgMHgyMDAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5V
TUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MjEwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAw
XSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDIxMDEwMCAtPiBOb2RlIDAKWyAg
ICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgyNjAwMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
MjYwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAt
PiBNUElEUiAweDI3MDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JB
VDogUFhNIDAgLT4gTVBJRFIgMHgyNzAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIHBlcmNw
dTogRW1iZWRkZWQgMzEgcGFnZXMvY3B1IHM4OTI0MCByODE5MiBkMjk1NDQgdTEyNjk3NgpbICAg
IDAuMDAwMDAwXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMApbICAgIDAuMDAwMDAwXSBD
UFUgZmVhdHVyZXM6IGRldGVjdGVkOiBHSUMgc3lzdGVtIHJlZ2lzdGVyIENQVSBpbnRlcmZhY2UK
WyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogVmlydHVhbGl6YXRpb24gSG9z
dCBFeHRlbnNpb25zClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEhhcmR3
YXJlIGRpcnR5IGJpdCBtYW5hZ2VtZW50ClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0
ZWN0ZWQ6IFNwZWN0cmUtdjQKWyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDog
QVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDAwMDAwXSBhbHRlcm5hdGl2ZXM6IHBhdGNoaW5n
IGtlcm5lbCBjb2RlClsgICAgMC4wMDAwMDBdIEJ1aWx0IDEgem9uZWxpc3RzLCBtb2JpbGl0eSBn
cm91cGluZyBvbi4gIFRvdGFsIHBhZ2VzOiA4MTkzMjc2ClsgICAgMC4wMDAwMDBdIFBvbGljeSB6
b25lOiBOb3JtYWwKWyAgICAwLjAwMDAwMF0gS2VybmVsIGNvbW1hbmQgbGluZTogQk9PVF9JTUFH
RT0vSW1hZ2Ugcm9vdHdhaXQgcncgcm9vdD0vZGV2L3NkYTIKWyAgICAwLjAwMDAwMF0gcHJpbnRr
OiBsb2dfYnVmX2xlbiBpbmRpdmlkdWFsIG1heCBjcHUgY29udHJpYnV0aW9uOiA0MDk2IGJ5dGVz
ClsgICAgMC4wMDAwMDBdIHByaW50azogbG9nX2J1Zl9sZW4gdG90YWwgY3B1X2V4dHJhIGNvbnRy
aWJ1dGlvbnM6IDEyNjk3NiBieXRlcwpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVu
IG1pbiBzaXplOiAxMzEwNzIgYnl0ZXMKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xl
bjogMjYyMTQ0IGJ5dGVzClsgICAgMC4wMDAwMDBdIHByaW50azogZWFybHkgbG9nIGJ1ZiBmcmVl
OiAxMjEyNDgoOTIlKQpbICAgIDAuMDAwMDAwXSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRy
aWVzOiA0MTk0MzA0IChvcmRlcjogMTMsIDMzNTU0NDMyIGJ5dGVzLCBsaW5lYXIpClsgICAgMC4w
MDAwMDBdIElub2RlLWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMjA5NzE1MiAob3JkZXI6IDEy
LCAxNjc3NzIxNiBieXRlcywgbGluZWFyKQpbICAgIDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBz
dGFjazpvZmYsIGhlYXAgYWxsb2M6b2ZmLCBoZWFwIGZyZWU6b2ZmClsgICAgMC4wMDAwMDBdIHNv
ZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgwMDAwMDAwMGZiYjQwMDAwLTB4MDAwMDAwMDBm
ZmI0MDAwMF0gKDY0TUIpClsgICAgMC4wMDAwMDBdIE1lbW9yeTogMzI1MDIxODRLLzMzMjkzMzEy
SyBhdmFpbGFibGUgKDEzNTY4SyBrZXJuZWwgY29kZSwgMTk5NksgcndkYXRhLCAzNDgwSyByb2Rh
dGEsIDQxNjBLIGluaXQsIDgyMksgYnNzLCA3OTExMjhLIHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2
ZWQpClsgICAgMC4wMDAwMDBdIFNMVUI6IEhXYWxpZ249NjQsIE9yZGVyPTAtMywgTWluT2JqZWN0
cz0wLCBDUFVzPTMyLCBOb2Rlcz0xClsgICAgMC4wMDAwMDBdIGZ0cmFjZTogYWxsb2NhdGluZyA0
MTM4NyBlbnRyaWVzIGluIDE2MiBwYWdlcwpbICAgIDAuMDAwMDAwXSBmdHJhY2U6IGFsbG9jYXRl
ZCAxNjIgcGFnZXMgd2l0aCAzIGdyb3VwcwpbICAgIDAuMDAwMDAwXSByY3U6IFByZWVtcHRpYmxl
IGhpZXJhcmNoaWNhbCBSQ1UgaW1wbGVtZW50YXRpb24uClsgICAgMC4wMDAwMDBdIHJjdTogCVJD
VSBldmVudCB0cmFjaW5nIGlzIGVuYWJsZWQuClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSByZXN0
cmljdGluZyBDUFVzIGZyb20gTlJfQ1BVUz0yNTYgdG8gbnJfY3B1X2lkcz0zMi4KWyAgICAwLjAw
MDAwMF0gCVRyYW1wb2xpbmUgdmFyaWFudCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAw
MDAwMF0gCVJ1ZGUgdmFyaWFudCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0g
CVRyYWNpbmcgdmFyaWFudCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gcmN1
OiBSQ1UgY2FsY3VsYXRlZCB2YWx1ZSBvZiBzY2hlZHVsZXItZW5saXN0bWVudCBkZWxheSBpcyAy
NSBqaWZmaWVzLgpbICAgIDAuMDAwMDAwXSByY3U6IEFkanVzdGluZyBnZW9tZXRyeSBmb3IgcmN1
X2Zhbm91dF9sZWFmPTE2LCBucl9jcHVfaWRzPTMyClsgICAgMC4wMDAwMDBdIE5SX0lSUVM6IDY0
LCBucl9pcnFzOiA2NCwgcHJlYWxsb2NhdGVkIGlycXM6IDAKWyAgICAwLjAwMDAwMF0gR0lDdjM6
IEdJQzogVXNpbmcgc3BsaXQgRU9JL0RlYWN0aXZhdGUgbW9kZQpbICAgIDAuMDAwMDAwXSBHSUN2
MzogNjcyIFNQSXMgaW1wbGVtZW50ZWQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IDAgRXh0ZW5kZWQg
U1BJcyBpbXBsZW1lbnRlZApbICAgIDAuMDAwMDAwXSBHSUN2MzogRGlzdHJpYnV0b3IgaGFzIG5v
IFJhbmdlIFNlbGVjdG9yIHN1cHBvcnQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IDE2IFBQSXMgaW1w
bGVtZW50ZWQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IENQVTA6IGZvdW5kIHJlZGlzdHJpYnV0b3Ig
MTAwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDU0MDAwMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQ
WE0gMCAtPiBJVFMgMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRT
IDEgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyAyIC0+IE5vZGUg
MApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMyAtPiBOb2RlIDAKWyAgICAwLjAw
MDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDQgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIFNSQVQ6
IFBYTSAwIC0+IElUUyA1IC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJ
VFMgNiAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDcgLT4gTm9k
ZSAwClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMDQwMDAwLTB4MTAwMTAwMDVmZmZm
XQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgODE5MiBE
ZXZpY2VzIEA4MDAwMDIyMDAwMCAoaW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAg
ICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA0MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVy
cnVwdCBDb2xsZWN0aW9ucyBAODAwMDAyMzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIg
MSkKWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwNjAwMDAtMHgxMDAxMDAwN2ZmZmZd
ClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwNjAwMDA6IGFsbG9jYXRlZCA4MTkyIERl
dmljZXMgQDgwMDAwMjUwMDAwIChpbmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAg
IDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDYwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJy
dXB0IENvbGxlY3Rpb25zIEA4MDAwMDI2MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAx
KQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDA4MDAwMC0weDEwMDEwMDA5ZmZmZl0K
WyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2
aWNlcyBAODAwMDAyODAwMDAgKGluZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAg
MC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwODAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1
cHQgQ29sbGVjdGlvbnMgQDgwMDAwMjkwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEp
ClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMGEwMDAwLTB4MTAwMTAwMGJmZmZmXQpb
ICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGEwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZp
Y2VzIEA4MDAwMDJiMDAwMCAoaW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAw
LjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBhMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVw
dCBDb2xsZWN0aW9ucyBAODAwMDAyYzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkK
WyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwYzAwMDAtMHgxMDAxMDAwZGZmZmZdClsg
ICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmlj
ZXMgQDgwMDAwMmUwMDAwIChpbmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAu
MDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGMwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0
IENvbGxlY3Rpb25zIEA4MDAwMDJmMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpb
ICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDBlMDAwMC0weDEwMDEwMDBmZmZmZl0KWyAg
ICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBlMDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNl
cyBAODAwMDAzMTAwMDAgKGluZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4w
MDAwMDBdIElUU0AweDAwMDAxMDAxMDAwZTAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQg
Q29sbGVjdGlvbnMgQDgwMDAwMzIwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsg
ICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMTAwMDAwLTB4MTAwMTAwMTFmZmZmXQpbICAg
IDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMTAwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2Vz
IEA4MDAwMDM0MDAwMCAoaW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAw
MDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEwMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBD
b2xsZWN0aW9ucyBAODAwMDAzNTAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAg
ICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAxMjAwMDAtMHgxMDAxMDAxM2ZmZmZdClsgICAg
MC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMg
QDgwMDAwMzcwMDAwIChpbmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAw
MDAwXSBJVFNAMHgwMDAwMTAwMTAwMTIwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENv
bGxlY3Rpb25zIEA4MDAwMDM4MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAg
IDAuMDAwMDAwXSBHSUN2MzogdXNpbmcgTFBJIHByb3BlcnR5IHRhYmxlIEAweDAwMDAwODAwMDAz
OTAwMDAKWyAgICAwLjAwMDAwMF0gR0lDdjM6IENQVTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVu
ZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2EwMDAwClsgICAgMC4wMDAwMDBdIHJhbmRvbTogZ2V0
X3JhbmRvbV9ieXRlcyBjYWxsZWQgZnJvbSBzdGFydF9rZXJuZWwrMHgzOTQvMHg1NTQgd2l0aCBj
cm5nX2luaXQ9MApbICAgIDAuMDAwMDAwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3Jr
YXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDAwMDBdIEFDUEkgR1REVDog
Zm91bmQgMSBtZW1vcnktbWFwcGVkIHRpbWVyIGJsb2NrKHMpLgpbICAgIDAuMDAwMDAwXSBhcmNo
X3RpbWVyOiBjcDE1IGFuZCBtbWlvIHRpbWVyKHMpIHJ1bm5pbmcgYXQgMjUuMDBNSHogKHBoeXMv
cGh5cykuClsgICAgMC4wMDAwMDBdIGNsb2Nrc291cmNlOiBhcmNoX3N5c19jb3VudGVyOiBtYXNr
OiAweGZmZmZmZmZmZmZmZmZmIG1heF9jeWNsZXM6IDB4NWM0MDkzOWI1LCBtYXhfaWRsZV9uczog
NDQwNzk1MjAyNjQ2IG5zClsgICAgMC4wMDAwMDFdIHNjaGVkX2Nsb2NrOiA1NiBiaXRzIGF0IDI1
TUh6LCByZXNvbHV0aW9uIDQwbnMsIHdyYXBzIGV2ZXJ5IDQzOTgwNDY1MTExMDBucwpbICAgIDAu
MDAwMDU1XSBDb25zb2xlOiBjb2xvdXIgZHVtbXkgZGV2aWNlIDgweDI1ClsgICAgMC4wMDAwNzdd
IEFDUEk6IENvcmUgcmV2aXNpb24gMjAyMDA5MjUKWyAgICAwLjAwMDQ4OV0gQ2FsaWJyYXRpbmcg
ZGVsYXkgbG9vcCAoc2tpcHBlZCksIHZhbHVlIGNhbGN1bGF0ZWQgdXNpbmcgdGltZXIgZnJlcXVl
bmN5Li4gNTAuMDAgQm9nb01JUFMgKGxwaj0xMDAwMDApClsgICAgMC4wMDA0OTRdIHBpZF9tYXg6
IGRlZmF1bHQ6IDMyNzY4IG1pbmltdW06IDMwMQpbICAgIDAuMDAwNTIyXSBMU006IFNlY3VyaXR5
IEZyYW1ld29yayBpbml0aWFsaXppbmcKWyAgICAwLjAwMDY0OV0gTW91bnQtY2FjaGUgaGFzaCB0
YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAg
IDAuMDAwNzMyXSBNb3VudHBvaW50LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9y
ZGVyOiA3LCA1MjQyODggYnl0ZXMsIGxpbmVhcikKWyAgICAwLjAwMTU4MV0gcmN1OiBIaWVyYXJj
aGljYWwgU1JDVSBpbXBsZW1lbnRhdGlvbi4KWyAgICAwLjAwMTcxMF0gUGxhdGZvcm0gTVNJOiBJ
VFNAMHgxMDAxMDAwNDAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxNF0gUGxhdGZvcm0g
TVNJOiBJVFNAMHgxMDAxMDAwNjAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxN10gUGxh
dGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcy
MF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwYTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAw
LjAwMTcyMl0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwYzAwMDAgZG9tYWluIGNyZWF0ZWQK
WyAgICAwLjAwMTcyNV0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNy
ZWF0ZWQKWyAgICAwLjAwMTcyOF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMDAwMDAgZG9t
YWluIGNyZWF0ZWQKWyAgICAwLjAwMTczM10gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMjAw
MDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTczOV0gUENJL01TSTogSVRTQDB4MTAwMTAwMDQw
MDAwIGRvbWFpbiBjcmVhdGVkClsgICAgMC4wMDE3NDJdIFBDSS9NU0k6IElUU0AweDEwMDEwMDA2
MDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAuMDAxNzQ0XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAw
ODAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTc0OF0gUENJL01TSTogSVRTQDB4MTAwMTAw
MGEwMDAwIGRvbWFpbiBjcmVhdGVkClsgICAgMC4wMDE3NTFdIFBDSS9NU0k6IElUU0AweDEwMDEw
MDBjMDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAuMDAxNzU0XSBQQ0kvTVNJOiBJVFNAMHgxMDAx
MDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTc1N10gUENJL01TSTogSVRTQDB4MTAw
MTAwMTAwMDAwIGRvbWFpbiBjcmVhdGVkClsgICAgMC4wMDE3NjFdIFBDSS9NU0k6IElUU0AweDEw
MDEwMDEyMDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAuMDAxNzY3XSBSZW1hcHBpbmcgYW5kIGVu
YWJsaW5nIEVGSSBzZXJ2aWNlcy4KWyAgICAwLjAwMzYxNF0gc21wOiBCcmluZ2luZyB1cCBzZWNv
bmRhcnkgQ1BVcyAuLi4KWyAgICAwLjAwMzkzNV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQ
VTEKWyAgICAwLjAwMzk2M10gR0lDdjM6IENQVTE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTgwMDAw
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDc0MDAwMApbICAgIDAuMDAzOTg4XSBHSUN2MzogQ1BVMTog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzYjAwMDAKWyAg
ICAwLjAwNDAzM10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA0MDUwXSBDUFUxOiBCb290ZWQgc2Vjb25kYXJ5IHBy
b2Nlc3NvciAweDAwMDAxODAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDQzNDhdIERldGVjdGVk
IFBJUFQgSS1jYWNoZSBvbiBDUFUyClsgICAgMC4wMDQzNzVdIEdJQ3YzOiBDUFUyOiBmb3VuZCBy
ZWRpc3RyaWJ1dG9yIDE2MDAwMCByZWdpb24gMDoweDAwMDAxMDAxMDA2YzAwMDAKWyAgICAwLjAw
NDM5OV0gR0lDdjM6IENQVTI6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgw
MDAwMDgwMDAwM2MwMDAwClsgICAgMC4wMDQ0NDZdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2Fs
IHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwNDQ1OV0gQ1BVMjog
Qm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMTYwMDAwIFsweDQxM2ZkMGMxXQpbICAg
IDAuMDA0NzQyXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMwpbICAgIDAuMDA0NzcxXSBH
SUN2MzogQ1BVMzogZm91bmQgcmVkaXN0cmlidXRvciAxZTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwOGMwMDAwClsgICAgMC4wMDQ3OTVdIEdJQ3YzOiBDUFUzOiB1c2luZyBhbGxvY2F0ZWQgTFBJ
IHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNkMDAwMApbICAgIDAuMDA0ODQzXSBhcmNoX3Rp
bWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsg
ICAgMC4wMDQ4NTldIENQVTM6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDFlMDAw
MCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNTEzOV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQ
VTQKWyAgICAwLjAwNTE1OF0gR0lDdjM6IENQVTQ6IGZvdW5kIHJlZGlzdHJpYnV0b3IgODAwMDAg
cmVnaW9uIDA6MHgwMDAwMTAwMTAwMzQwMDAwClsgICAgMC4wMDUxODNdIEdJQ3YzOiBDUFU0OiB1
c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNlMDAwMApbICAg
IDAuMDA1MjMyXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0g
ZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDUyNDRdIENQVTQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJv
Y2Vzc29yIDB4MDAwMDA4MDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNTUzOV0gRGV0ZWN0ZWQg
UElQVCBJLWNhY2hlIG9uIENQVTUKWyAgICAwLjAwNTU2OF0gR0lDdjM6IENQVTU6IGZvdW5kIHJl
ZGlzdHJpYnV0b3IgMjAwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDk0MDAwMApbICAgIDAuMDA1
NTkzXSBHSUN2MzogQ1BVNTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAw
MDAwODAwMDAzZjAwMDAKWyAgICAwLjAwNTY0MF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwg
d29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA1NjU3XSBDUFU1OiBC
b290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAyMDAwMDAgWzB4NDEzZmQwYzFdClsgICAg
MC4wMDU5MzZdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFU2ClsgICAgMC4wMDU5NTldIEdJ
Q3YzOiBDUFU2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIGUwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDRjMDAwMApbICAgIDAuMDA1OTg0XSBHSUN2MzogQ1BVNjogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4MDAwMDAKWyAgICAwLjAwNjAzNV0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDA2MDQ5XSBDUFU2OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwZTAwMDAg
WzB4NDEzZmQwYzFdClsgICAgMC4wMDYzNDhdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFU3
ClsgICAgMC4wMDYzODFdIEdJQ3YzOiBDUFU3OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDI2MDAwMCBy
ZWdpb24gMDoweDAwMDAxMDAxMDBhYzAwMDAKWyAgICAwLjAwNjQwNl0gR0lDdjM6IENQVTc6IHVz
aW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODEwMDAwClsgICAg
MC4wMDY0NTVdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBl
cnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwNjQ3Ml0gQ1BVNzogQm9vdGVkIHNlY29uZGFyeSBwcm9j
ZXNzb3IgMHgwMDAwMjYwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA2NzUwXSBEZXRlY3RlZCBQ
SVBUIEktY2FjaGUgb24gQ1BVOApbICAgIDAuMDA2NzczXSBHSUN2MzogQ1BVODogZm91bmQgcmVk
aXN0cmlidXRvciAxMTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNTgwMDAwClsgICAgMC4wMDY3
OThdIEdJQ3YzOiBDUFU4OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAw
MDA4MDAwMDgyMDAwMApbICAgIDAuMDA2ODQ1XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3
b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDY4NThdIENQVTg6IEJv
b3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDExMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAw
LjAwNzEzNV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTkKWyAgICAwLjAwNzE2MV0gR0lD
djM6IENQVTk6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTkwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDc4MDAwMApbICAgIDAuMDA3MTg2XSBHSUN2MzogQ1BVOTogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4MzAwMDAKWyAgICAwLjAwNzIzNF0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDA3MjUxXSBDUFU5OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxOTAwMDAg
WzB4NDEzZmQwYzFdClsgICAgMC4wMDc1MzFdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUx
MApbICAgIDAuMDA3NTU3XSBHSUN2MzogQ1BVMTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTcwMDAw
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDcwMDAwMApbICAgIDAuMDA3NTgzXSBHSUN2MzogQ1BVMTA6
IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODQwMDAwClsg
ICAgMC4wMDc2MzFdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwNzY0OV0gQ1BVMTA6IEJvb3RlZCBzZWNvbmRhcnkg
cHJvY2Vzc29yIDB4MDAwMDE3MDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNzk0Ml0gRGV0ZWN0
ZWQgUElQVCBJLWNhY2hlIG9uIENQVTExClsgICAgMC4wMDc5NzFdIEdJQ3YzOiBDUFUxMTogZm91
bmQgcmVkaXN0cmlidXRvciAxZjAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOTAwMDAwClsgICAg
MC4wMDc5OTddIEdJQ3YzOiBDUFUxMTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDA4NTAwMDAKWyAgICAwLjAwODA0NF0gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA4MDYyXSBD
UFUxMTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMWYwMDAwIFsweDQxM2ZkMGMx
XQpbICAgIDAuMDA4NDIyXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTIKWyAgICAwLjAw
ODQ0Ml0gR0lDdjM6IENQVTEyOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDkwMDAwIHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDM4MDAwMApbICAgIDAuMDA4NDY5XSBHSUN2MzogQ1BVMTI6IHVzaW5nIGFsbG9j
YXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODYwMDAwClsgICAgMC4wMDg1MTdd
IGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0
MTgwNDAKWyAgICAwLjAwODUzNV0gQ1BVMTI6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4
MDAwMDA5MDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwODg0M10gRGV0ZWN0ZWQgUElQVCBJLWNh
Y2hlIG9uIENQVTEzClsgICAgMC4wMDg4NzJdIEdJQ3YzOiBDUFUxMzogZm91bmQgcmVkaXN0cmli
dXRvciAyMTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOTgwMDAwClsgICAgMC4wMDg5MDBdIEdJ
Q3YzOiBDUFUxMzogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAw
MDA4NzAwMDAKWyAgICAwLjAwODk0NV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fy
b3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA4OTYzXSBDUFUxMzogQm9vdGVk
IHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjEwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA5
NDA4XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTQKWyAgICAwLjAwOTQzMV0gR0lDdjM6
IENQVTE0OiBmb3VuZCByZWRpc3RyaWJ1dG9yIGYwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDUw
MDAwMApbICAgIDAuMDA5NDU4XSBHSUN2MzogQ1BVMTQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVu
ZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODgwMDAwClsgICAgMC4wMDk1MDddIGFyY2hfdGltZXI6
IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAw
LjAwOTUyNl0gQ1BVMTQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDBmMDAwMCBb
MHg0MTNmZDBjMV0KWyAgICAwLjAwOTgzOV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE1
ClsgICAgMC4wMDk4NzJdIEdJQ3YzOiBDUFUxNTogZm91bmQgcmVkaXN0cmlidXRvciAyNzAwMDAg
cmVnaW9uIDA6MHgwMDAwMTAwMTAwYjAwMDAwClsgICAgMC4wMDk4OTldIEdJQ3YzOiBDUFUxNTog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4OTAwMDAKWyAg
ICAwLjAwOTk0OF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA5OTY3XSBDUFUxNTogQm9vdGVkIHNlY29uZGFyeSBw
cm9jZXNzb3IgMHgwMDAwMjcwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDEwMjU2XSBEZXRlY3Rl
ZCBQSVBUIEktY2FjaGUgb24gQ1BVMTYKWyAgICAwLjAxMDI3OV0gR0lDdjM6IENQVTE2OiBmb3Vu
ZCByZWRpc3RyaWJ1dG9yIDEwMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA1NjAwMDAKWyAgICAw
LjAxMDMwNl0gR0lDdjM6IENQVTE2OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUg
QDB4MDAwMDA4MDAwMDhhMDAwMApbICAgIDAuMDEwMzU0XSBhcmNoX3RpbWVyOiBFbmFibGluZyBs
b2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTAzNzNdIENQ
VTE2OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxMDAxMDAgWzB4NDEzZmQwYzFd
ClsgICAgMC4wMTA4MTNdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxNwpbICAgIDAuMDEw
ODQwXSBHSUN2MzogQ1BVMTc6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTgwMTAwIHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDc2MDAwMApbICAgIDAuMDEwODY3XSBHSUN2MzogQ1BVMTc6IHVzaW5nIGFsbG9j
YXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOGIwMDAwClsgICAgMC4wMTA5MTVd
IGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0
MTgwNDAKWyAgICAwLjAxMDkzNV0gQ1BVMTc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4
MDAwMDE4MDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAxMTIyNl0gRGV0ZWN0ZWQgUElQVCBJLWNh
Y2hlIG9uIENQVTE4ClsgICAgMC4wMTEyNTJdIEdJQ3YzOiBDUFUxODogZm91bmQgcmVkaXN0cmli
dXRvciAxNjAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNmUwMDAwClsgICAgMC4wMTEyODFdIEdJ
Q3YzOiBDUFUxODogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAw
MDA4YzAwMDAKWyAgICAwLjAxMTMyOV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fy
b3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDExMzQ5XSBDUFUxODogQm9vdGVk
IHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMTYwMTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDEx
NjU0XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTkKWyAgICAwLjAxMTY4M10gR0lDdjM6
IENQVTE5OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDFlMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA4
ZTAwMDAKWyAgICAwLjAxMTcxMl0gR0lDdjM6IENQVTE5OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhkMDAwMApbICAgIDAuMDExNzU5XSBhcmNoX3RpbWVy
OiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAg
MC4wMTE3NzldIENQVTE5OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxZTAxMDAg
WzB4NDEzZmQwYzFdClsgICAgMC4wMTIxMzhdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUy
MApbICAgIDAuMDEyMTU4XSBHSUN2MzogQ1BVMjA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgODAxMDAg
cmVnaW9uIDA6MHgwMDAwMTAwMTAwMzYwMDAwClsgICAgMC4wMTIxODZdIEdJQ3YzOiBDUFUyMDog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4ZTAwMDAKWyAg
ICAwLjAxMjIzM10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MApbICAgIDAuMDEyMjQ4XSBDUFUyMDogQm9vdGVkIHNlY29uZGFyeSBw
cm9jZXNzb3IgMHgwMDAwMDgwMTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDEyNjI5XSBEZXRlY3Rl
ZCBQSVBUIEktY2FjaGUgb24gQ1BVMjEKWyAgICAwLjAxMjY1OV0gR0lDdjM6IENQVTIxOiBmb3Vu
ZCByZWRpc3RyaWJ1dG9yIDIwMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA5NjAwMDAKWyAgICAw
LjAxMjY5MF0gR0lDdjM6IENQVTIxOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUg
QDB4MDAwMDA4MDAwMDhmMDAwMApbICAgIDAuMDEyNzM3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBs
b2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTI3NThdIENQ
VTIxOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAyMDAxMDAgWzB4NDEzZmQwYzFd
ClsgICAgMC4wMTMyMTBdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMgpbICAgIDAuMDEz
MjM1XSBHSUN2MzogQ1BVMjI6IGZvdW5kIHJlZGlzdHJpYnV0b3IgZTAxMDAgcmVnaW9uIDA6MHgw
MDAwMTAwMTAwNGUwMDAwClsgICAgMC4wMTMyNjVdIEdJQ3YzOiBDUFUyMjogdXNpbmcgYWxsb2Nh
dGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA5MDAwMDAKWyAgICAwLjAxMzMxNV0g
YXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQx
ODA0MApbICAgIDAuMDEzMzM3XSBDUFUyMjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgw
MDAwMGUwMTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDEzNjQ2XSBEZXRlY3RlZCBQSVBUIEktY2Fj
aGUgb24gQ1BVMjMKWyAgICAwLjAxMzY4MF0gR0lDdjM6IENQVTIzOiBmb3VuZCByZWRpc3RyaWJ1
dG9yIDI2MDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDBhZTAwMDAKWyAgICAwLjAxMzcxMF0gR0lD
djM6IENQVTIzOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAw
MDkxMDAwMApbICAgIDAuMDEzNzU3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJv
dW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTM3NzhdIENQVTIzOiBCb290ZWQg
c2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAyNjAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTQy
MjJdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyNApbICAgIDAuMDE0MjQ2XSBHSUN2Mzog
Q1BVMjQ6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTEwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDVh
MDAwMApbICAgIDAuMDE0Mjc2XSBHSUN2MzogQ1BVMjQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVu
ZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTIwMDAwClsgICAgMC4wMTQzMjNdIGFyY2hfdGltZXI6
IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAw
LjAxNDM0Nl0gQ1BVMjQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDExMDEwMCBb
MHg0MTNmZDBjMV0KWyAgICAwLjAxNDY0Nl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI1
ClsgICAgMC4wMTQ2NzJdIEdJQ3YzOiBDUFUyNTogZm91bmQgcmVkaXN0cmlidXRvciAxOTAxMDAg
cmVnaW9uIDA6MHgwMDAwMTAwMTAwN2EwMDAwClsgICAgMC4wMTQ3MDJdIEdJQ3YzOiBDUFUyNTog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA5MzAwMDAKWyAg
ICAwLjAxNDc0OV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MApbICAgIDAuMDE0NzcxXSBDUFUyNTogQm9vdGVkIHNlY29uZGFyeSBw
cm9jZXNzb3IgMHgwMDAwMTkwMTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDE1MjI2XSBEZXRlY3Rl
ZCBQSVBUIEktY2FjaGUgb24gQ1BVMjYKWyAgICAwLjAxNTI1NF0gR0lDdjM6IENQVTI2OiBmb3Vu
ZCByZWRpc3RyaWJ1dG9yIDE3MDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA3MjAwMDAKWyAgICAw
LjAxNTI4NV0gR0lDdjM6IENQVTI2OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUg
QDB4MDAwMDA4MDAwMDk0MDAwMApbICAgIDAuMDE1MzM0XSBhcmNoX3RpbWVyOiBFbmFibGluZyBs
b2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTUzNTZdIENQ
VTI2OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxNzAxMDAgWzB4NDEzZmQwYzFd
ClsgICAgMC4wMTU4MDddIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyNwpbICAgIDAuMDE1
ODM3XSBHSUN2MzogQ1BVMjc6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMWYwMTAwIHJlZ2lvbiAwOjB4
MDAwMDEwMDEwMDkyMDAwMApbICAgIDAuMDE1ODY4XSBHSUN2MzogQ1BVMjc6IHVzaW5nIGFsbG9j
YXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTUwMDAwClsgICAgMC4wMTU5MTNd
IGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0
MTgwNDAKWyAgICAwLjAxNTkzNV0gQ1BVMjc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4
MDAwMDFmMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAxNjQyNF0gRGV0ZWN0ZWQgUElQVCBJLWNh
Y2hlIG9uIENQVTI4ClsgICAgMC4wMTY0NDVdIEdJQ3YzOiBDUFUyODogZm91bmQgcmVkaXN0cmli
dXRvciA5MDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDAzYTAwMDAKWyAgICAwLjAxNjQ3NV0gR0lD
djM6IENQVTI4OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAw
MDk2MDAwMApbICAgIDAuMDE2NTIzXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJv
dW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTY1NDZdIENQVTI4OiBCb290ZWQg
c2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwOTAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTY4
NTddIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyOQpbICAgIDAuMDE2ODg3XSBHSUN2Mzog
Q1BVMjk6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjEwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDlh
MDAwMApbICAgIDAuMDE2OTE4XSBHSUN2MzogQ1BVMjk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVu
ZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTcwMDAwClsgICAgMC4wMTY5NjZdIGFyY2hfdGltZXI6
IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAw
LjAxNjk4OV0gQ1BVMjk6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDIxMDEwMCBb
MHg0MTNmZDBjMV0KWyAgICAwLjAxNzQyNl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTMw
ClsgICAgMC4wMTc0NTBdIEdJQ3YzOiBDUFUzMDogZm91bmQgcmVkaXN0cmlidXRvciBmMDEwMCBy
ZWdpb24gMDoweDAwMDAxMDAxMDA1MjAwMDAKWyAgICAwLjAxNzQ4MV0gR0lDdjM6IENQVTMwOiB1
c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk4MDAwMApbICAg
IDAuMDE3NTMwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0g
ZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTc1NTRdIENQVTMwOiBCb290ZWQgc2Vjb25kYXJ5IHBy
b2Nlc3NvciAweDAwMDAwZjAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTc4NTFdIERldGVjdGVk
IFBJUFQgSS1jYWNoZSBvbiBDUFUzMQpbICAgIDAuMDE3ODg0XSBHSUN2MzogQ1BVMzE6IGZvdW5k
IHJlZGlzdHJpYnV0b3IgMjcwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMGIyMDAwMApbICAgIDAu
MDE3OTE2XSBHSUN2MzogQ1BVMzE6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBA
MHgwMDAwMDgwMDAwOTkwMDAwClsgICAgMC4wMTc5NjNdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxv
Y2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNzk4Nl0gQ1BV
MzE6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDI3MDEwMCBbMHg0MTNmZDBjMV0K
WyAgICAwLjAxODA3MV0gc21wOiBCcm91Z2h0IHVwIDEgbm9kZSwgMzIgQ1BVcwpbICAgIDAuMDE4
MTY1XSBTTVA6IFRvdGFsIG9mIDMyIHByb2Nlc3NvcnMgYWN0aXZhdGVkLgpbICAgIDAuMDE4MTY4
XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBQcml2aWxlZ2VkIEFjY2VzcyBOZXZlcgpbICAgIDAu
MDE4MTY5XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBMU0UgYXRvbWljIGluc3RydWN0aW9ucwpb
ICAgIDAuMDE4MTcxXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBVc2VyIEFjY2VzcyBPdmVycmlk
ZQpbICAgIDAuMDE4MTczXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiAzMi1iaXQgRUwwIFN1cHBv
cnQKWyAgICAwLjAxODE3NV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQ29tbW9uIG5vdCBQcml2
YXRlIHRyYW5zbGF0aW9ucwpbICAgIDAuMDE4MTc3XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBS
QVMgRXh0ZW5zaW9uIFN1cHBvcnQKWyAgICAwLjAxODE3OV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3Rl
ZDogRGF0YSBjYWNoZSBjbGVhbiB0byB0aGUgUG9VIG5vdCByZXF1aXJlZCBmb3IgSS9EIGNvaGVy
ZW5jZQpbICAgIDAuMDE4MTgxXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBDUkMzMiBpbnN0cnVj
dGlvbnMKWyAgICAwLjAxODE4M10gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3VsYXRpdmUg
U3RvcmUgQnlwYXNzaW5nIFNhZmUgKFNTQlMpClsgICAgMC4wNTAwOTFdIENQVTogQWxsIENQVShz
KSBzdGFydGVkIGF0IEVMMgpbICAgIDAuMDUwODg3XSBkZXZ0bXBmczogaW5pdGlhbGl6ZWQKWyAg
ICAwLjA1MTE2MV0gY2xvY2tzb3VyY2U6IGppZmZpZXM6IG1hc2s6IDB4ZmZmZmZmZmYgbWF4X2N5
Y2xlczogMHhmZmZmZmZmZiwgbWF4X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnMKWyAgICAw
LjA1MTE2N10gZnV0ZXggaGFzaCB0YWJsZSBlbnRyaWVzOiA4MTkyIChvcmRlcjogNywgNTI0Mjg4
IGJ5dGVzLCBsaW5lYXIpClsgICAgMC4wNTE0MDFdIFNNQklPUyAzLjMuMCBwcmVzZW50LgpbICAg
IDAuMDUxNDA2XSBETUk6IEFETElOSyBDT00tSFBDLUFMVC9DT00tSFBDLUFMVCwgQklPUyBUaWFu
b0NvcmUgRURLSUkgMTEvMjMvMjAyMQpbICAgIDAuMDUxNjM2XSBORVQ6IFJlZ2lzdGVyZWQgcHJv
dG9jb2wgZmFtaWx5IDE2ClsgICAgMC4wNTIxNTRdIERNQTogcHJlYWxsb2NhdGVkIDQwOTYgS2lC
IEdGUF9LRVJORUwgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wNTIzMjJdIERN
QTogcHJlYWxsb2NhdGVkIDQwOTYgS2lCIEdGUF9LRVJORUx8R0ZQX0RNQSBwb29sIGZvciBhdG9t
aWMgYWxsb2NhdGlvbnMKWyAgICAwLjA1MjQ4Nl0gRE1BOiBwcmVhbGxvY2F0ZWQgNDA5NiBLaUIg
R0ZQX0tFUk5FTHxHRlBfRE1BMzIgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4w
NTI1ODZdIHRoZXJtYWxfc3lzOiBSZWdpc3RlcmVkIHRoZXJtYWwgZ292ZXJub3IgJ3N0ZXBfd2lz
ZScKWyAgICAwLjA1MjY2OF0gY3B1aWRsZTogdXNpbmcgZ292ZXJub3IgbWVudQpbICAgIDAuMDUy
ODA5XSBEZXRlY3RlZCAxNSBQQ0MgU3Vic3BhY2VzClsgICAgMC4wNTI4MzJdIFJlZ2lzdGVyaW5n
IFBDQyBkcml2ZXIgYXMgTWFpbGJveCBjb250cm9sbGVyClsgICAgMC4wNTI4NzBdIGh3LWJyZWFr
cG9pbnQ6IGZvdW5kIDYgYnJlYWtwb2ludCBhbmQgNCB3YXRjaHBvaW50IHJlZ2lzdGVycy4KWyAg
ICAwLjA1MzE2OV0gQVNJRCBhbGxvY2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVz
ClsgICAgMC4wNTMxNzZdIEFDUEk6IGJ1cyB0eXBlIFBDSSByZWdpc3RlcmVkClsgICAgMC4wNTMx
NzhdIFNlcmlhbDogQU1CQSBQTDAxMSBVQVJUIGRyaXZlcgpbICAgIDAuMDU1MzYyXSBIdWdlVExC
IHJlZ2lzdGVyZWQgMS4wMCBHaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAg
ICAwLjA1NTM2Nl0gSHVnZVRMQiByZWdpc3RlcmVkIDMyLjAgTWlCIHBhZ2Ugc2l6ZSwgcHJlLWFs
bG9jYXRlZCAwIHBhZ2VzClsgICAgMC4wNTUzNjhdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAyLjAwIE1p
QiBwYWdlIHNpemUsIHByZS1hbGxvY2F0ZWQgMCBwYWdlcwpbICAgIDAuMDU1MzY5XSBIdWdlVExC
IHJlZ2lzdGVyZWQgNjQuMCBLaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAg
ICAwLjA1NjA5N10gY3J5cHRkOiBtYXhfY3B1X3FsZW4gc2V0IHRvIDEwMDAKWyAgICAwLjEyNDA1
OF0gcmFpZDY6IG5lb254OCAgIGdlbigpICA3Nzc2IE1CL3MKWyAgICAwLjE5MjA4OF0gcmFpZDY6
IG5lb254OCAgIHhvcigpICA1OTg5IE1CL3MKWyAgICAwLjI2MDExOF0gcmFpZDY6IG5lb254NCAg
IGdlbigpICA3NjAxIE1CL3MKWyAgICAwLjMyODE0OF0gcmFpZDY6IG5lb254NCAgIHhvcigpICA2
MzI2IE1CL3MKWyAgICAwLjM5NjE4MF0gcmFpZDY6IG5lb254MiAgIGdlbigpICA3MjcyIE1CL3MK
WyAgICAwLjQ2NDIwOF0gcmFpZDY6IG5lb254MiAgIHhvcigpICA1NzI2IE1CL3MKWyAgICAwLjUz
MjI0M10gcmFpZDY6IG5lb254MSAgIGdlbigpICA1OTk1IE1CL3MKWyAgICAwLjYwMDI3Ml0gcmFp
ZDY6IG5lb254MSAgIHhvcigpICA0OTUyIE1CL3MKWyAgICAwLjY2ODMwNF0gcmFpZDY6IGludDY0
eDggIGdlbigpICAzNjAwIE1CL3MKWyAgICAwLjczNjMzMl0gcmFpZDY6IGludDY0eDggIHhvcigp
ICAyMDE5IE1CL3MKWyAgICAwLjgwNDM1OF0gcmFpZDY6IGludDY0eDQgIGdlbigpICA0MTI3IE1C
L3MKWyAgICAwLjg3MjQzOV0gcmFpZDY6IGludDY0eDQgIHhvcigpICAyMTkxIE1CL3MKWyAgICAw
Ljk0MDQxOF0gcmFpZDY6IGludDY0eDIgIGdlbigpICAzNTAzIE1CL3MKWyAgICAxLjAwODQ0MV0g
cmFpZDY6IGludDY0eDIgIHhvcigpICAxODkxIE1CL3MKWyAgICAxLjA3NjQ2OV0gcmFpZDY6IGlu
dDY0eDEgIGdlbigpICAyODc1IE1CL3MKWyAgICAxLjE0NDQ5OV0gcmFpZDY6IGludDY0eDEgIHhv
cigpICAxNTA4IE1CL3MKWyAgICAxLjE0NDUwMV0gcmFpZDY6IHVzaW5nIGFsZ29yaXRobSBuZW9u
eDggZ2VuKCkgNzc3NiBNQi9zClsgICAgMS4xNDQ1MDNdIHJhaWQ2OiAuLi4uIHhvcigpIDU5ODkg
TUIvcywgcm13IGVuYWJsZWQKWyAgICAxLjE0NDUwNV0gcmFpZDY6IHVzaW5nIG5lb24gcmVjb3Zl
cnkgYWxnb3JpdGhtClsgICAgMS4xNDQ1ODNdIEFDUEk6IEFkZGVkIF9PU0koTW9kdWxlIERldmlj
ZSkKWyAgICAxLjE0NDU4NV0gQUNQSTogQWRkZWQgX09TSShQcm9jZXNzb3IgRGV2aWNlKQpbICAg
IDEuMTQ0NTg3XSBBQ1BJOiBBZGRlZCBfT1NJKDMuMCBfU0NQIEV4dGVuc2lvbnMpClsgICAgMS4x
NDQ1ODldIEFDUEk6IEFkZGVkIF9PU0koUHJvY2Vzc29yIEFnZ3JlZ2F0b3IgRGV2aWNlKQpbICAg
IDEuMTQ0NTkyXSBBQ1BJOiBBZGRlZCBfT1NJKExpbnV4LURlbGwtVmlkZW8pClsgICAgMS4xNDQ1
OTRdIEFDUEk6IEFkZGVkIF9PU0koTGludXgtTGVub3ZvLU5WLUhETUktQXVkaW8pClsgICAgMS4x
NDQ1OTZdIEFDUEk6IEFkZGVkIF9PU0koTGludXgtSFBJLUh5YnJpZC1HcmFwaGljcykKWyAgICAx
LjE2NDg2Nl0gQUNQSTogMiBBQ1BJIEFNTCB0YWJsZXMgc3VjY2Vzc2Z1bGx5IGFjcXVpcmVkIGFu
ZCBsb2FkZWQKWyAgICAxLjE3MTE0NF0gQUNQSTogSW50ZXJwcmV0ZXIgZW5hYmxlZApbICAgIDEu
MTcxMTQ3XSBBQ1BJOiBVc2luZyBHSUMgZm9yIGludGVycnVwdCByb3V0aW5nClsgICAgMS4xNzEx
NjJdIEFDUEk6IE1DRkcgdGFibGUgZGV0ZWN0ZWQsIDUgZW50cmllcwpbICAgIDEuMTcxMTY4XSBB
Q1BJOiBJT1JUOiBTTU1VLXYzWzMzZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21h
aW4gMApbICAgIDEuMTcxMTkzXSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzM3ZmZlMDAwMDAwMF0gTWFw
cGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcxMjA3XSBBQ1BJOiBJT1JUOiBTTU1V
LXYzWzNmZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcx
MjE5XSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzJiZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0
eSBkb21haW4gMApbICAgIDEuMTcxMjMzXSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzJmZmZlMDAwMDAw
MF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcxMzIyXSBIRVNUOiBUYWJs
ZSBwYXJzaW5nIGhhcyBiZWVuIGluaXRpYWxpemVkLgpbICAgIDEuMjA2NTMxXSBBUk1IMDAxMTow
MDogdHR5QU1BMCBhdCBNTUlPIDB4MTAwMDAyNjAwMDAwIChpcnEgPSA3OSwgYmFzZV9iYXVkID0g
MCkgaXMgYSBTQlNBClsgICAgNC4wMjEyNjldIHByaW50azogY29uc29sZSBbdHR5QU1BMF0gZW5h
YmxlZApbICAgIDQuMDI3MzI5XSBBUk1IMDAxMTowMTogdHR5QU1BMSBhdCBNTUlPIDB4MTAwMDAy
NjIwMDAwIChpcnEgPSA4MCwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBClsgICAgNC4wMzc0MzZd
IEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJMF0gKGRvbWFpbiAwMDBjIFtidXMgMDAtZmZdKQpb
ICAgIDQuMDQzNjIwXSBhY3BpIFBOUDBBMDg6MDA6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRl
ZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICA0LjA1Mjcy
MF0gYWNwaSBQTlAwQTA4OjAwOiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1
ZXN0aW5nIF9PU0MgY29udHJvbApbICAgIDQuMDYwNTQ0XSBhY3BpIFBOUDBBMDg6MDA6IE1DRkcg
cXVpcms6IEVDQU0gYXQgW21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFti
dXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwClsgICAgNC4wNzMzNTZdIGFjcGkgUE5Q
MEEwODowMDogRUNBTSBhcmVhIFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIHJl
c2VydmVkIGJ5IFBOUDBDMDI6MDAKWyAgICA0LjA4MjIyOV0gYWNwaSBQTlAwQTA4OjAwOiBFQ0FN
IGF0IFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQpb
ICAgIDQuMDkwMzg5XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGM6MDAKWyAgICA0LjA5NDQ3
Nl0gcGNpX2J1cyAwMDBjOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4NDAwMDAwMDAtMHg0
ZmZmZmZmZiB3aW5kb3ddClsgICAgNC4xMDE5NDhdIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMg
cmVzb3VyY2UgW21lbSAweDMwMDAwMDAwMDAwMC0weDMzZmZkZmZmZmZmZiB3aW5kb3ddClsgICAg
NC4xMTAxMTVdIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0K
WyAgICA0LjExNTYyNV0gcGNpIDAwMGM6MDA6MDAuMDogWzFkZWY6ZTEwMF0gdHlwZSAwMCBjbGFz
cyAweDA2MDAwMApbICAgIDQuMTIxNjk5XSBwY2kgMDAwYzowMDowMS4wOiBbMWRlZjplMTAxXSB0
eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNC4xMjc3NDZdIHBjaSAwMDBjOjAwOjAxLjA6IHN1
cHBvcnRzIEQxIEQyClsgICAgNC4xMzIwMDVdIHBjaSAwMDBjOjAwOjAxLjA6IFBNRSMgc3VwcG9y
dGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA0LjEzODg2NF0gcGNpIDAwMGM6MDA6MDEuMDogYnJp
ZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDEwMDAK
WyAgICA0LjE0NzAzMl0gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAx
MDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAg
YWRkX2FsaWduIDEwMDAwMApbICAgIDQuMTU4NDk3XSBwY2kgMDAwYzowMDowMS4wOiBicmlkZ2Ug
d2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAy
MDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDQuMTY5MDA5XSBwY2kgMDAwYzowMDowMS4wOiBC
QVIgODogYXNzaWduZWQgW21lbSAweDQwMDAwMDAwLTB4NDAxZmZmZmZdClsgICAgNC4xNzU3ODdd
IHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4
MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdClsgICAgNC4xODQyMTRdIHBjaSAwMDBjOjAwOjAxLjA6
IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjE5MDQ3MF0gcGNp
IDAwMGM6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0K
WyAgICA0LjE5NzA3NF0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8g
IHNpemUgMHgxMDAwXQpbICAgIDQuMjAzMzMwXSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFp
bGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuMjA5OTM0XSBwY2kgMDAwYzow
MDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDFdClsgICAgNC4yMTQ4ODldIHBjaSAwMDBjOjAw
OjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0KWyAgICA0
LjIyMTY2Nl0gcGNpIDAwMGM6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAw
MDAwMDAtMHgzMDAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjIzMDA5NF0gcGNpX2J1cyAw
MDBjOjAwOiByZXNvdXJjZSA0IFttZW0gMHg0MDAwMDAwMC0weDRmZmZmZmZmIHdpbmRvd10KWyAg
ICA0LjIzNjk1OV0gcGNpX2J1cyAwMDBjOjAwOiByZXNvdXJjZSA1IFttZW0gMHgzMDAwMDAwMDAw
MDAtMHgzM2ZmZGZmZmZmZmYgd2luZG93XQpbICAgIDQuMjQ0NTE3XSBwY2lfYnVzIDAwMGM6MDE6
IHJlc291cmNlIDEgW21lbSAweDQwMDAwMDAwLTB4NDAxZmZmZmZdClsgICAgNC4yNTA3NzRdIHBj
aV9idXMgMDAwYzowMTogcmVzb3VyY2UgMiBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZm
ZmZmIDY0Yml0IHByZWZdClsgICAgNC4yNTg3MjFdIEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJ
MV0gKGRvbWFpbiAwMDBkIFtidXMgMDAtZmZdKQpbICAgIDQuMjY0ODk4XSBhY3BpIFBOUDBBMDg6
MDE6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVu
dHMgTVNJIEhQWC1UeXBlM10KWyAgICA0LjI3Mzk5N10gYWNwaSBQTlAwQTA4OjAxOiBQQ0llIHBv
cnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbApbICAgIDQu
MjgxODE4XSBhY3BpIFBOUDBBMDg6MDE6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAweDM3ZmZm
MDAwMDAwMC0weDM3ZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEw
ZGUwZmMwClsgICAgNC4yOTQ2MTRdIGFjcGkgUE5QMEEwODowMTogRUNBTSBhcmVhIFttZW0gMHgz
N2ZmZjAwMDAwMDAtMHgzN2ZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDAKWyAgICA0
LjMwMzQ4N10gYWNwaSBQTlAwQTA4OjAxOiBFQ0FNIGF0IFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgz
N2ZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQpbICAgIDQuMzExNjM5XSBQQ0kgaG9zdCBicmlk
Z2UgdG8gYnVzIDAwMGQ6MDAKWyAgICA0LjMxNTcyN10gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1
cyByZXNvdXJjZSBbbWVtIDB4NTAwMDAwMDAtMHg1ZmZmZmZmZiB3aW5kb3ddClsgICAgNC4zMjMx
OThdIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDM0MDAwMDAwMDAw
MC0weDM3ZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNC4zMzEzNjRdIHBjaV9idXMgMDAwZDowMDog
cm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0KWyAgICA0LjMzNjg3MF0gcGNpIDAwMGQ6MDA6
MDAuMDogWzFkZWY6ZTEwMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMApbICAgIDQuMzQyOTM0XSBw
Y2kgMDAwZDowMDowMS4wOiBbMWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAg
NC4zNDg5NjZdIHBjaSAwMDBkOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNC4zNTMyMjZd
IHBjaSAwMDBkOjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA0
LjM1OTA0N10gcGNpIDAwMGQ6MDE6MDAuMDogWzEwZGU6MWU4OV0gdHlwZSAwMCBjbGFzcyAweDAz
MDAwMApbICAgIDQuMzY1MDU0XSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxMDogW21lbSAweDUw
MDAwMDAwLTB4NTBmZmZmZmZdClsgICAgNC4zNzEzMThdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAw
eDE0OiBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDBmZmZmZmZmIDY0Yml0IHByZWZdClsgICAg
NC4zNzkyMzFdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MzQwMDEwMDAwMDAw
LTB4MzQwMDExZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC4zODcxNDBdIHBjaSAwMDBkOjAxOjAw
LjA6IHJlZyAweDI0OiBbaW8gIDB4NTdmZmUwMDAtMHg1N2ZmZTA3Zl0KWyAgICA0LjM5MzQwMF0g
cGNpIDAwMGQ6MDE6MDAuMDogcmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHBy
ZWZdClsgICAgNC40MDAxNTFdIHBjaSAwMDBkOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20g
RDAgRDNob3QgRDNjb2xkClsgICAgNC40MDYzMDRdIHBjaSAwMDBkOjAxOjAwLjE6IFsxMGRlOjEw
ZjhdIHR5cGUgMDAgY2xhc3MgMHgwNDAzMDAKWyAgICA0LjQxMjMwOV0gcGNpIDAwMGQ6MDE6MDAu
MTogcmVnIDB4MTA6IFttZW0gMHg1MTAwMDAwMC0weDUxMDAzZmZmXQpbICAgIDQuNDE4Njg2XSBw
Y2kgMDAwZDowMTowMC4yOiBbMTBkZToxYWQ4XSB0eXBlIDAwIGNsYXNzIDB4MGMwMzMwClsgICAg
NC40MjQ2OTVdIHBjaSAwMDBkOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4MzQwMDEyMDAwMDAw
LTB4MzQwMDEyMDNmZmZmIDY0Yml0IHByZWZdClsgICAgNC40MzI2MTJdIHBjaSAwMDBkOjAxOjAw
LjI6IHJlZyAweDFjOiBbbWVtIDB4MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNC40NDA1NjhdIHBjaSAwMDBkOjAxOjAwLjI6IFBNRSMgc3VwcG9ydGVkIGZyb20g
RDAgRDNob3QgRDNjb2xkClsgICAgNC40NDY3MDhdIHBjaSAwMDBkOjAxOjAwLjM6IFsxMGRlOjFh
ZDldIHR5cGUgMDAgY2xhc3MgMHgwYzgwMDAKWyAgICA0LjQ1MjcxNF0gcGNpIDAwMGQ6MDE6MDAu
MzogcmVnIDB4MTA6IFttZW0gMHg1MTAwNDAwMC0weDUxMDA0ZmZmXQpbICAgIDQuNDU5MDQwXSBw
Y2kgMDAwZDowMTowMC4zOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAg
IDQuNDY1MTc3XSBwY2kgMDAwZDowMDowMS4wOiBBU1BNOiBjdXJyZW50IGNvbW1vbiBjbG9jayBj
b25maWd1cmF0aW9uIGlzIGluY29uc2lzdGVudCwgcmVjb25maWd1cmluZwpbICAgIDQuNDg2NDU2
XSBwY2kgMDAwZDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDM0MDAwMDAwMDAwMC0w
eDM0MDAxN2ZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuNDk0ODg0XSBwY2kgMDAwZDowMDowMS4w
OiBCQVIgODogYXNzaWduZWQgW21lbSAweDUwMDAwMDAwLTB4NTE3ZmZmZmZdClsgICAgNC41MDE2
NjFdIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAw
MF0KWyAgICA0LjUwNzkxN10gcGNpIDAwMGQ6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3Np
Z24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjUxNDUyMl0gcGNpIDAwMGQ6MDE6MDAuMDogQkFS
IDE6IGFzc2lnbmVkIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgzNDAwMGZmZmZmZmYgNjRiaXQgcHJl
Zl0KWyAgICA0LjUyMjk1NV0gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0g
MHgzNDAwMTAwMDAwMDAtMHgzNDAwMTFmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjUzMTM4N10g
cGNpIDAwMGQ6MDE6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MDAwMDAwMC0weDUwZmZm
ZmZmXQpbICAgIDQuNTM4MTY2XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQgW21l
bSAweDUxMDAwMDAwLTB4NTEwN2ZmZmYgcHJlZl0KWyAgICA0LjU0NTM3OF0gcGNpIDAwMGQ6MDE6
MDAuMjogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTIwMDAwMDAtMHgzNDAwMTIwM2ZmZmYg
NjRiaXQgcHJlZl0KWyAgICA0LjU1MzgxMV0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDM6IGFzc2ln
bmVkIFttZW0gMHgzNDAwMTIwNDAwMDAtMHgzNDAwMTIwNGZmZmYgNjRiaXQgcHJlZl0KWyAgICA0
LjU2MjI0M10gcGNpIDAwMGQ6MDE6MDAuMTogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MTA4MDAw
MC0weDUxMDgzZmZmXQpbICAgIDQuNTY5MDIyXSBwY2kgMDAwZDowMTowMC4zOiBCQVIgMDogYXNz
aWduZWQgW21lbSAweDUxMDg0MDAwLTB4NTEwODRmZmZdClsgICAgNC41NzU4MDFdIHBjaSAwMDBk
OjAxOjAwLjA6IEJBUiA1OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MDA4MF0KWyAgICA0LjU4
MjA1N10gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDU6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXpl
IDB4MDA4MF0KWyAgICA0LjU4ODY2Ml0gcGNpIDAwMGQ6MDA6MDEuMDogUENJIGJyaWRnZSB0byBb
YnVzIDAxXQpbICAgIDQuNTkzNjE3XSBwY2kgMDAwZDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cg
W21lbSAweDUwMDAwMDAwLTB4NTE3ZmZmZmZdClsgICAgNC42MDAzOTRdIHBjaSAwMDBkOjAwOjAx
LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0
Yml0IHByZWZdClsgICAgNC42MDg4MjFdIHBjaV9idXMgMDAwZDowMDogU29tZSBQQ0kgZGV2aWNl
IHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5IGJvb3Rpbmcgd2l0aCBwY2k9cmVhbGxvYwpb
ICAgIDQuNjE3ODU1XSBwY2lfYnVzIDAwMGQ6MDA6IHJlc291cmNlIDQgW21lbSAweDUwMDAwMDAw
LTB4NWZmZmZmZmYgd2luZG93XQpbICAgIDQuNjI0NzE5XSBwY2lfYnVzIDAwMGQ6MDA6IHJlc291
cmNlIDUgW21lbSAweDM0MDAwMDAwMDAwMC0weDM3ZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNC42
MzIyNzZdIHBjaV9idXMgMDAwZDowMTogcmVzb3VyY2UgMSBbbWVtIDB4NTAwMDAwMDAtMHg1MTdm
ZmZmZl0KWyAgICA0LjYzODUzM10gcGNpX2J1cyAwMDBkOjAxOiByZXNvdXJjZSAyIFttZW0gMHgz
NDAwMDAwMDAwMDAtMHgzNDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjY0NjQ5Ml0gQUNQ
STogUENJIFJvb3QgQnJpZGdlIFtQQ0kzXSAoZG9tYWluIDAwMDAgW2J1cyAwMC1mZl0pClsgICAg
NC42NTI2NzFdIGFjcGkgUE5QMEEwODowMzogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29u
ZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDQuNjYxNzcwXSBh
Y3BpIFBOUDBBMDg6MDM6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3Rp
bmcgX09TQyBjb250cm9sClsgICAgNC42Njk1OTFdIGFjcGkgUE5QMEEwODowMzogTUNGRyBxdWly
azogRUNBTSBhdCBbbWVtIDB4M2ZmZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSBmb3IgW2J1cyAw
MC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzAKWyAgICA0LjY4MjM5NV0gYWNwaSBQTlAwQTA4
OjAzOiBFQ0FNIGFyZWEgW21lbSAweDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gcmVzZXJ2
ZWQgYnkgUE5QMEMwMjowMApbICAgIDQuNjkxMjY2XSBhY3BpIFBOUDBBMDg6MDM6IEVDQU0gYXQg
W21lbSAweDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdClsgICAg
NC42OTk0MjBdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwMDowMApbICAgIDQuNzAzNTA3XSBw
Y2lfYnVzIDAwMDA6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHg3MDAwMDAwMC0weDdmZmZm
ZmZmIHdpbmRvd10KWyAgICA0LjcxMDk3OV0gcGNpX2J1cyAwMDAwOjAwOiByb290IGJ1cyByZXNv
dXJjZSBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA0Ljcx
OTE0NV0gcGNpX2J1cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQpbICAg
IDQuNzI0NjUxXSBwY2kgMDAwMDowMDowMC4wOiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4
MDYwMDAwClsgICAgNC43MzA3MTZdIHBjaSAwMDAwOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUg
MDEgY2xhc3MgMHgwNjA0MDAKWyAgICA0LjczNjc0OF0gcGNpIDAwMDA6MDA6MDEuMDogc3VwcG9y
dHMgRDEgRDIKWyAgICA0Ljc0MTAwOF0gcGNpIDAwMDA6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQg
ZnJvbSBEMCBEMSBEM2hvdApbICAgIDQuNzQ2ODI2XSBwY2kgMDAwMDowMTowMC4wOiBbODA4Njox
NTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAgNC43NTI4MzVdIHBjaSAwMDAwOjAxOjAw
LjA6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAzMDAwMDAwLTB4M2MwMDAzZmZmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNC43NjA3NTFdIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4M2Mw
MDA0ODE4MDAwLTB4M2MwMDA0ODFmZmZmIDY0Yml0IHByZWZdClsgICAgNC43Njg2NjVdIHBjaSAw
MDAwOjAxOjAwLjA6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpb
ICAgIDQuNzc1NDI3XSBwY2kgMDAwMDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQz
aG90IEQzY29sZApbICAgIDQuNzgxNTg1XSBwY2kgMDAwMDowMTowMC4xOiBbODA4NjoxNTg5XSB0
eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAgNC43ODc1OTNdIHBjaSAwMDAwOjAxOjAwLjE6IHJl
ZyAweDEwOiBbbWVtIDB4M2MwMDAyMDAwMDAwLTB4M2MwMDAyZmZmZmZmIDY0Yml0IHByZWZdClsg
ICAgNC43OTU1MTFdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODEw
MDAwLTB4M2MwMDA0ODE3ZmZmIDY0Yml0IHByZWZdClsgICAgNC44MDM0MjVdIHBjaSAwMDAwOjAx
OjAwLjE6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQu
ODEwMTgzXSBwY2kgMDAwMDowMTowMC4xOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQz
Y29sZApbICAgIDQuODE2MzM0XSBwY2kgMDAwMDowMTowMC4yOiBbODA4NjoxNTg5XSB0eXBlIDAw
IGNsYXNzIDB4MDIwMDAwClsgICAgNC44MjIzNDNdIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDEw
OiBbbWVtIDB4M2MwMDAxMDAwMDAwLTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC44
MzAyNjBdIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODA4MDAwLTB4
M2MwMDA0ODBmZmZmIDY0Yml0IHByZWZdClsgICAgNC44MzgxNzNdIHBjaSAwMDAwOjAxOjAwLjI6
IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODQ0OTMx
XSBwY2kgMDAwMDowMTowMC4yOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApb
ICAgIDQuODUxMDc5XSBwY2kgMDAwMDowMTowMC4zOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNz
IDB4MDIwMDAwClsgICAgNC44NTcwODhdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVt
IDB4M2MwMDAwMDAwMDAwLTB4M2MwMDAwZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC44NjUwMDVd
IHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODAwMDAwLTB4M2MwMDA0
ODA3ZmZmIDY0Yml0IHByZWZdClsgICAgNC44NzI5MTldIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAw
eDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODc5Njc3XSBwY2kg
MDAwMDowMTowMC4zOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQu
ODg1ODQwXSBwY2kgMDAwMDowMDowMS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZm
Zl0gdG8gW2J1cyAwMS0wMl0gYWRkX3NpemUgMTAwMApbICAgIDQuODk0MjY5XSBwY2kgMDAwMDow
MDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwNDdmZmZm
ZiA2NGJpdCBwcmVmXQpbICAgIDQuOTAyNjk3XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgODogYXNz
aWduZWQgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZmZmZdClsgICAgNC45MDk0NzRdIHBjaSAwMDAw
OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0Ljkx
NTczMF0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXpl
IDB4MTAwMF0KWyAgICA0LjkyMjMzNF0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNl
IGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuOTI4NTkwXSBwY2kgMDAwMDowMDowMS4wOiBC
QVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuOTM1MTk1XSBw
Y2kgMDAwMDowMTowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNj
MDAwMGZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTQzNjI4XSBwY2kgMDAwMDowMTowMC4xOiBC
QVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMTAwMDAwMC0weDNjMDAwMWZmZmZmZiA2NGJpdCBw
cmVmXQpbICAgIDQuOTUyMDYxXSBwY2kgMDAwMDowMTowMC4yOiBCQVIgMDogYXNzaWduZWQgW21l
bSAweDNjMDAwMjAwMDAwMC0weDNjMDAwMmZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTYwNDkz
XSBwY2kgMDAwMDowMTowMC4zOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMzAwMDAwMC0w
eDNjMDAwM2ZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTY4OTI1XSBwY2kgMDAwMDowMTowMC4w
OiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMDAwMDAwLTB4NzAwN2ZmZmYgcHJlZl0KWyAgICA0
Ljk3NjEzNl0gcGNpIDAwMDA6MDE6MDAuMTogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg3MDA4MDAw
MC0weDcwMGZmZmZmIHByZWZdClsgICAgNC45ODMzNDddIHBjaSAwMDAwOjAxOjAwLjI6IEJBUiA2
OiBhc3NpZ25lZCBbbWVtIDB4NzAxMDAwMDAtMHg3MDE3ZmZmZiBwcmVmXQpbICAgIDQuOTkwNTU3
XSBwY2kgMDAwMDowMTowMC4zOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMTgwMDAwLTB4NzAx
ZmZmZmYgcHJlZl0KWyAgICA0Ljk5Nzc2OV0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDM6IGFzc2ln
bmVkIFttZW0gMHgzYzAwMDQwMDAwMDAtMHgzYzAwMDQwMDdmZmYgNjRiaXQgcHJlZl0KWyAgICA1
LjAwNjIwMV0gcGNpIDAwMDA6MDE6MDAuMTogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQw
MDgwMDAtMHgzYzAwMDQwMGZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAxNDYzNF0gcGNpIDAwMDA6
MDE6MDAuMjogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMTAwMDAtMHgzYzAwMDQwMTdm
ZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAyMzA2Nl0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDM6IGFz
c2lnbmVkIFttZW0gMHgzYzAwMDQwMTgwMDAtMHgzYzAwMDQwMWZmZmYgNjRiaXQgcHJlZl0KWyAg
ICA1LjAzMTQ5OF0gcGNpIDAwMDA6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxLTAyXQpb
ICAgIDUuMDM2NzEzXSBwY2kgMDAwMDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDcw
MDAwMDAwLTB4NzAxZmZmZmZdClsgICAgNS4wNDM0OTFdIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJp
ZGdlIHdpbmRvdyBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZd
ClsgICAgNS4wNTE5MThdIHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNCBbbWVtIDB4NzAwMDAw
MDAtMHg3ZmZmZmZmZiB3aW5kb3ddClsgICAgNS4wNTg3ODJdIHBjaV9idXMgMDAwMDowMDogcmVz
b3VyY2UgNSBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA1
LjA2NjM0MV0gcGNpX2J1cyAwMDAwOjAxOiByZXNvdXJjZSAxIFttZW0gMHg3MDAwMDAwMC0weDcw
MWZmZmZmXQpbICAgIDUuMDcyNTk2XSBwY2lfYnVzIDAwMDA6MDE6IHJlc291cmNlIDIgW21lbSAw
eDNjMDAwMDAwMDAwMC0weDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDgwNTU5XSBB
Q1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTZdIChkb21haW4gMDAwNCBbYnVzIDAwLWZmXSkKWyAg
ICA1LjA4NjczNl0gYWNwaSBQTlAwQTA4OjA2OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRD
b25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAgNS4wOTU4MzRd
IGFjcGkgUE5QMEEwODowNjogUENJZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBub3QgcmVxdWVz
dGluZyBfT1NDIGNvbnRyb2wKWyAgICA1LjEwMzY1NV0gYWNwaSBQTlAwQTA4OjA2OiBNQ0ZHIHF1
aXJrOiBFQ0FNIGF0IFttZW0gMHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIGZvciBbYnVz
IDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMApbICAgIDUuMTE2NDU1XSBhY3BpIFBOUDBB
MDg6MDY6IEVDQU0gYXJlYSBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSByZXNl
cnZlZCBieSBQTlAwQzAyOjAwClsgICAgNS4xMjUzMjddIGFjcGkgUE5QMEEwODowNjogRUNBTSBh
dCBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0KWyAg
ICA1LjEzMzQ4Ml0gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDA0OjAwClsgICAgNS4xMzc1Njld
IHBjaV9idXMgMDAwNDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDIwMDAwMDAwLTB4MmZm
ZmZmZmYgd2luZG93XQpbICAgIDUuMTQ1MDQxXSBwY2lfYnVzIDAwMDQ6MDA6IHJvb3QgYnVzIHJl
c291cmNlIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyYmZmZGZmZmZmZmYgd2luZG93XQpbICAgIDUu
MTUzMjA4XSBwY2lfYnVzIDAwMDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdClsg
ICAgNS4xNTg3MTRdIHBjaSAwMDA0OjAwOjAwLjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3Mg
MHgwNjAwMDAKWyAgICA1LjE2NDc3Nl0gcGNpIDAwMDQ6MDA6MDEuMDogWzFkZWY6ZTExMV0gdHlw
ZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUuMTcwODExXSBwY2kgMDAwNDowMDowMS4wOiBzdXBw
b3J0cyBEMSBEMgpbICAgIDUuMTc1MDcxXSBwY2kgMDAwNDowMDowMS4wOiBQTUUjIHN1cHBvcnRl
ZCBmcm9tIEQwIEQxIEQzaG90ClsgICAgNS4xODA4NTVdIHBjaSAwMDA0OjAwOjAzLjA6IFsxZGVm
OmUxMTNdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA1LjE4Njg4OV0gcGNpIDAwMDQ6MDA6
MDMuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjE5MTE0OF0gcGNpIDAwMDQ6MDA6MDMuMDogUE1F
IyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDUuMTk2OTM0XSBwY2kgMDAwNDowMDow
NS4wOiBbMWRlZjplMTE1XSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNS4yMDI5NzZdIHBj
aSAwMDA0OjAwOjA1LjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS4yMDcyMzZdIHBjaSAwMDA0OjAw
OjA1LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA1LjIxMzA1NV0gcGNp
IDAwMDQ6MDE6MDAuMDogWzFhMDM6MTE1MF0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUu
MjE5MTAyXSBwY2kgMDAwNDowMTowMC4wOiBlbmFibGluZyBFeHRlbmRlZCBUYWdzClsgICAgNS4y
MjQxMTZdIHBjaSAwMDA0OjAxOjAwLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS4yMjgzNzVdIHBj
aSAwMDA0OjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDIgRDNob3QgRDNjb2xk
ClsgICAgNS4yMzUwODJdIHBjaV9idXMgMDAwNDowMjogZXh0ZW5kZWQgY29uZmlnIHNwYWNlIG5v
dCBhY2Nlc3NpYmxlClsgICAgNS4yNDExODddIHBjaSAwMDA0OjAyOjAwLjA6IFsxYTAzOjIwMDBd
IHR5cGUgMDAgY2xhc3MgMHgwMzAwMDAKWyAgICA1LjI0NzIwMl0gcGNpIDAwMDQ6MDI6MDAuMDog
cmVnIDB4MTA6IFttZW0gMHgyMDAwMDAwMC0weDIwZmZmZmZmXQpbICAgIDUuMjUzNDY4XSBwY2kg
MDAwNDowMjowMC4wOiByZWcgMHgxNDogW21lbSAweDIxMDAwMDAwLTB4MjEwMWZmZmZdClsgICAg
NS4yNTk3MzRdIHBjaSAwMDA0OjAyOjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmYwMDAtMHgy
N2ZmZjA3Zl0KWyAgICA1LjI2NjA3M10gcGNpIDAwMDQ6MDI6MDAuMDogc3VwcG9ydHMgRDEgRDIK
WyAgICA1LjI3MDMzM10gcGNpIDAwMDQ6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBE
MSBEMiBEM2hvdCBEM2NvbGQKWyAgICA1LjI3NzA3NV0gcGNpIDAwMDQ6MDM6MDAuMDogWzE5MTI6
MDAxNF0gdHlwZSAwMCBjbGFzcyAweDBjMDMzMApbICAgIDUuMjgzMDkxXSBwY2kgMDAwNDowMzow
MC4wOiByZWcgMHgxMDogW21lbSAweDIxMjAwMDAwLTB4MjEyMDFmZmYgNjRiaXRdClsgICAgNS4y
ODk5NzFdIHBjaSAwMDA0OjAzOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNj
b2xkClsgICAgNS4yOTYxOTVdIHBjaSAwMDA0OjA0OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUgMDAg
Y2xhc3MgMHgwMjAwMDAKWyAgICA1LjMwMjIyMF0gcGNpIDAwMDQ6MDQ6MDAuMDogcmVnIDB4MTA6
IFttZW0gMHgyMTEwMDAwMC0weDIxMTdmZmZmXQpbICAgIDUuMzA4NTA4XSBwY2kgMDAwNDowNDow
MC4wOiByZWcgMHgxODogW2lvICAweDI3ZmZlMDAwLTB4MjdmZmUwMWZdClsgICAgNS4zMTQ3Nzld
IHBjaSAwMDA0OjA0OjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MjExODAwMDAtMHgyMTE4M2ZmZl0K
WyAgICA1LjMyMTIxMV0gcGNpIDAwMDQ6MDQ6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBE
M2hvdCBEM2NvbGQKWyAgICA1LjMyNzQwN10gcGNpIDAwMDQ6MDA6MDEuMDogYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxLTAyXSBh
ZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuMzM5MTMzXSBwY2kgMDAwNDow
MDowMy4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRk
X3NpemUgMTAwMApbICAgIDUuMzQ3Mjk5XSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93
IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9z
aXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNS4zNTg3NjVdIHBjaSAwMDA0OjAwOjAz
LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDNd
IGFkZF9zaXplIDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNS4zNjkyNzVdIHBjaSAwMDA0
OjAwOjA1LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQg
cHJlZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1
LjM4MDc0MF0gcGNpIDAwMDQ6MDA6MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAt
MHgwMDFmZmZmZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAK
WyAgICA1LjM5MTI1NF0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgy
MDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuMzk4MDMyXSBwY2kgMDAwNDowMDowMS4wOiBCQVIg
OTogYXNzaWduZWQgW21lbSAweDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVm
XQpbICAgIDUuNDA2NDU5XSBwY2kgMDAwNDowMDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAw
eDIxODAwMDAwLTB4MjE5ZmZmZmZdClsgICAgNS40MTMyMzddIHBjaSAwMDA0OjAwOjAzLjA6IEJB
UiA5OiBhc3NpZ25lZCBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNS40MjE2NjNdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVt
IDB4MjFhMDAwMDAtMHgyMWJmZmZmZl0KWyAgICA1LjQyODQ0MF0gcGNpIDAwMDQ6MDA6MDUuMDog
QkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQg
cHJlZl0KWyAgICA1LjQzNjg2Nl0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZv
ciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDQzMTIyXSBwY2kgMDAwNDowMDowMS4wOiBCQVIg
NzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDQ5NzI1XSBwY2kg
MDAwNDowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAg
NS40NTU5ODFdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAg
c2l6ZSAweDEwMDBdClsgICAgNS40NjI1ODRdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBz
cGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjQ2ODg0MF0gcGNpIDAwMDQ6MDA6MDUu
MDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjQ3NTQ0
NV0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAw
XQpbICAgIDUuNDgxNzAxXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDg4MzA1XSBwY2kgMDAwNDowMDowNS4wOiBCQVIg
Nzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS40OTQ1NjFdIHBjaSAwMDA0
OjAwOjA1LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAg
NS41MDExNjRdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0KWyAgICA1LjUwNzQyMF0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0
byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjUxNDAyNF0gcGNpIDAwMDQ6MDE6MDAu
MDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNTIw
ODAxXSBwY2kgMDAwNDowMTowMC4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEw
MDBdClsgICAgNS41MjcwNTddIHBjaSAwMDA0OjAxOjAwLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNz
aWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS41MzM2NjBdIHBjaSAwMDA0OjAyOjAwLjA6IEJB
UiAwOiBhc3NpZ25lZCBbbWVtIDB4MjAwMDAwMDAtMHgyMGZmZmZmZl0KWyAgICA1LjU0MDQ0MF0g
cGNpIDAwMDQ6MDI6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFttZW0gMHgyMTAwMDAwMC0weDIxMDFm
ZmZmXQpbICAgIDUuNTQ3MjIwXSBwY2kgMDAwNDowMjowMC4wOiBCQVIgMjogbm8gc3BhY2UgZm9y
IFtpbyAgc2l6ZSAweDAwODBdClsgICAgNS41NTM0NzZdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAy
OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDAwODBdClsgICAgNS41NjAwNzhdIHBjaSAw
MDA0OjAxOjAwLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMl0KWyAgICA1LjU2NTAzNV0gcGNpIDAw
MDQ6MDE6MDAuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpb
ICAgIDUuNTcxODE5XSBwY2kgMDAwNDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDEtMDJd
ClsgICAgNS41NzcwMzRdIHBjaSAwMDA0OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4
MjAwMDAwMDAtMHgyMTdmZmZmZl0KWyAgICA1LjU4MzgxMV0gcGNpIDAwMDQ6MDA6MDEuMDogICBi
cmlkZ2Ugd2luZG93IFttZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJl
Zl0KWyAgICA1LjU5MjI0MF0gcGNpIDAwMDQ6MDM6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0g
MHgyMTgwMDAwMC0weDIxODAxZmZmIDY0Yml0XQpbICAgIDUuNTk5NTQ2XSBwY2kgMDAwNDowMDow
My4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDNdClsgICAgNS42MDQ1MDFdIHBjaSAwMDA0OjAwOjAz
LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjE4MDAwMDAtMHgyMTlmZmZmZl0KWyAgICA1LjYx
MTI3OF0gcGNpIDAwMDQ6MDA6MDMuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyODAwMDAyMDAw
MDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjYxOTcwNl0gcGNpIDAwMDQ6MDQ6
MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMWEwMDAwMC0weDIxYTdmZmZmXQpbICAgIDUu
NjI2NDg4XSBwY2kgMDAwNDowNDowMC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDIxYTgwMDAw
LTB4MjFhODNmZmZdClsgICAgNS42MzMyNzBdIHBjaSAwMDA0OjA0OjAwLjA6IEJBUiAyOiBubyBz
cGFjZSBmb3IgW2lvICBzaXplIDB4MDAyMF0KWyAgICA1LjYzOTUyNV0gcGNpIDAwMDQ6MDQ6MDAu
MDogQkFSIDI6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDAyMF0KWyAgICA1LjY0NjEy
OF0gcGNpIDAwMDQ6MDA6MDUuMDogUENJIGJyaWRnZSB0byBbYnVzIDA0XQpbICAgIDUuNjUxMTA1
XSBwY2kgMDAwNDowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIxYTAwMDAwLTB4MjFi
ZmZmZmZdClsgICAgNS42NTc4ODNdIHBjaSAwMDA0OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBb
bWVtIDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNS42NjYz
MTBdIHBjaV9idXMgMDAwNDowMDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3Np
Z25lZCwgdHJ5IGJvb3Rpbmcgd2l0aCBwY2k9cmVhbGxvYwpbICAgIDUuNjc1MzQ0XSBwY2lfYnVz
IDAwMDQ6MDA6IHJlc291cmNlIDQgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpb
ICAgIDUuNjgyMjA4XSBwY2lfYnVzIDAwMDQ6MDA6IHJlc291cmNlIDUgW21lbSAweDI4MDAwMDAw
MDAwMC0weDJiZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNS42ODk3NjZdIHBjaV9idXMgMDAwNDow
MTogcmVzb3VyY2UgMSBbbWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0KWyAgICA1LjY5NjAyMl0g
cGNpX2J1cyAwMDA0OjAxOiByZXNvdXJjZSAyIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAx
ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjcwMzkyN10gcGNpX2J1cyAwMDA0OjAyOiByZXNvdXJj
ZSAxIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNzEwMTgzXSBwY2lfYnVzIDAw
MDQ6MDM6IHJlc291cmNlIDEgW21lbSAweDIxODAwMDAwLTB4MjE5ZmZmZmZdClsgICAgNS43MTY0
MzldIHBjaV9idXMgMDAwNDowMzogcmVzb3VyY2UgMiBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4Mjgw
MDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS43MjQzNDVdIHBjaV9idXMgMDAwNDowNDogcmVz
b3VyY2UgMSBbbWVtIDB4MjFhMDAwMDAtMHgyMWJmZmZmZl0KWyAgICA1LjczMDYwMV0gcGNpX2J1
cyAwMDA0OjA0OiByZXNvdXJjZSAyIFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYg
NjRiaXQgcHJlZl0KWyAgICA1LjczODU1NV0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0k3XSAo
ZG9tYWluIDAwMDUgW2J1cyAwMC1mZl0pClsgICAgNS43NDQ3MzNdIGFjcGkgUE5QMEEwODowNzog
X09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBN
U0kgSFBYLVR5cGUzXQpbICAgIDUuNzUzODMzXSBhY3BpIFBOUDBBMDg6MDc6IFBDSWUgcG9ydCBz
ZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsgICAgNS43NjE2
NTRdIGFjcGkgUE5QMEEwODowNzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MmZmZmYwMDAw
MDAwLTB4MmZmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBm
YzAKWyAgICA1Ljc3NDQ1N10gYWNwaSBQTlAwQTA4OjA3OiBFQ0FNIGFyZWEgW21lbSAweDJmZmZm
MDAwMDAwMC0weDJmZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApbICAgIDUuNzgz
MzI4XSBhY3BpIFBOUDBBMDg6MDc6IEVDQU0gYXQgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZm
ZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdClsgICAgNS43OTE0ODFdIFBDSSBob3N0IGJyaWRnZSB0
byBidXMgMDAwNTowMApbICAgIDUuNzk1NTY4XSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJl
c291cmNlIFttZW0gMHgzMDAwMDAwMC0weDNmZmZmZmZmIHdpbmRvd10KWyAgICA1LjgwMzA0MF0g
cGNpX2J1cyAwMDA1OjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4
MmZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA1LjgxMTIwNl0gcGNpX2J1cyAwMDA1OjAwOiByb290
IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQpbICAgIDUuODE2NzEyXSBwY2kgMDAwNTowMDowMC4w
OiBbMWRlZjplMTEwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwClsgICAgNS44MjI3NzhdIHBjaSAw
MDA1OjAwOjAxLjA6IFsxZGVmOmUxMTFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA1Ljgy
ODgyMV0gcGNpIDAwMDU6MDA6MDEuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjgzMzA4MV0gcGNp
IDAwMDU6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDUuODM4
ODY3XSBwY2kgMDAwNTowMDowMy4wOiBbMWRlZjplMTEzXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAw
ClsgICAgNS44NDQ5MDFdIHBjaSAwMDA1OjAwOjAzLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS44
NDkxNjFdIHBjaSAwMDA1OjAwOjAzLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QK
WyAgICA1Ljg1NDk0Nl0gcGNpIDAwMDU6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlwZSAwMSBjbGFz
cyAweDA2MDQwMApbICAgIDUuODYwOTg5XSBwY2kgMDAwNTowMDowNS4wOiBzdXBwb3J0cyBEMSBE
MgpbICAgIDUuODY1MjQ4XSBwY2kgMDAwNTowMDowNS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQw
IEQxIEQzaG90ClsgICAgNS44NzEwMzJdIHBjaSAwMDA1OjAwOjA3LjA6IFsxZGVmOmUxMTddIHR5
cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA1Ljg3NzA2MV0gcGNpIDAwMDU6MDA6MDcuMDogc3Vw
cG9ydHMgRDEgRDIKWyAgICA1Ljg4MTMyMV0gcGNpIDAwMDU6MDA6MDcuMDogUE1FIyBzdXBwb3J0
ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDUuODg4MjA0XSBwY2kgMDAwNTowMjowMC4wOiBbMTkx
MjowMDE0XSB0eXBlIDAwIGNsYXNzIDB4MGMwMzMwClsgICAgNS44OTQyMjBdIHBjaSAwMDA1OjAy
OjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4MzAxMDAwMDAtMHgzMDEwMWZmZiA2NGJpdF0KWyAgICA1
LjkwMTEwMl0gcGNpIDAwMDU6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBE
M2NvbGQKWyAgICA1LjkwODM2N10gcGNpIDAwMDU6MDQ6MDAuMDogWzEyNmY6MjI2M10gdHlwZSAw
MCBjbGFzcyAweDAxMDgwMgpbICAgIDUuOTE0MzgxXSBwY2kgMDAwNTowNDowMC4wOiByZWcgMHgx
MDogW21lbSAweDMwMDAwMDAwLTB4MzAwMDNmZmYgNjRiaXRdClsgICAgNS45MjEzMzldIHBjaSAw
MDA1OjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAx
XSBhZGRfc2l6ZSAxMDAwClsgICAgNS45Mjk1MDddIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRnZSB3
aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMV0g
YWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1Ljk0MDk3Ml0gcGNpIDAwMDU6
MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1
cyAwMV0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1Ljk1MTQ4Ml0gcGNp
IDAwMDU6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMg
MDJdIGFkZF9zaXplIDEwMDAKWyAgICA1Ljk1OTY0OF0gcGNpIDAwMDU6MDA6MDMuMDogYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAy
XSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuOTcxMTE0XSBwY2kgMDAw
NTowMDowMy4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBb
YnVzIDAyXSBhZGRfc2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuOTgxNjI0XSBw
Y2kgMDAwNTowMDowNS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1
cyAwM10gYWRkX3NpemUgMTAwMApbICAgIDUuOTg5Nzg5XSBwY2kgMDAwNTowMDowNS4wOiBicmlk
Z2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMg
MDNdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNi4wMDEyNTRdIHBjaSAw
MDA1OjAwOjA1LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmZdIHRv
IFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNi4wMTE3NjRd
IHBjaSAwMDA1OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBb
YnVzIDA0XSBhZGRfc2l6ZSAxMDAwClsgICAgNi4wMTk5MzBdIHBjaSAwMDA1OjAwOjA3LjA6IGJy
aWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1
cyAwNF0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjAzMTM5NV0gcGNp
IDAwMDU6MDA6MDcuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0g
dG8gW2J1cyAwNF0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjA0MTkx
MV0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMC0weDMw
MWZmZmZmXQpbICAgIDYuMDQ4Njg5XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgOTogYXNzaWduZWQg
W21lbSAweDJjMDAwMDAwMDAwMC0weDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMDU3
MTE1XSBwY2kgMDAwNTowMDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwMjAwMDAwLTB4
MzAzZmZmZmZdClsgICAgNi4wNjM4OTNdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25l
ZCBbbWVtIDB4MmMwMDAwMjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4w
NzIzMjBdIHBjaSAwMDA1OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzA0MDAwMDAt
MHgzMDVmZmZmZl0KWyAgICA2LjA3OTA5N10gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDk6IGFzc2ln
bmVkIFttZW0gMHgyYzAwMDA0MDAwMDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2
LjA4NzUyNF0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAw
MC0weDMwN2ZmZmZmXQpbICAgIDYuMDk0MzAxXSBwY2kgMDAwNTowMDowNy4wOiBCQVIgOTogYXNz
aWduZWQgW21lbSAweDJjMDAwMDYwMDAwMC0weDJjMDAwMDdmZmZmZiA2NGJpdCBwcmVmXQpbICAg
IDYuMTAyNzI3XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6
ZSAweDEwMDBdClsgICAgNi4xMDg5ODNdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xMTU1ODddIHBjaSAwMDA1OjAwOjAz
LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjEyMTg0M10g
cGNpIDAwMDU6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAw
MF0KWyAgICA2LjEyODQ0Nl0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBb
aW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTM0NzAxXSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzog
ZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTQxMzA0XSBwY2kgMDAw
NTowMDowNy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4x
NDc1NjBdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6
ZSAweDEwMDBdClsgICAgNi4xNTQxNjZdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFj
ZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE2MDQyMl0gcGNpIDAwMDU6MDA6MDcuMDog
QkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE2NzAyNV0g
cGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDYuMTczMjgwXSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTc5ODg0XSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzog
bm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xODYxNDBdIHBjaSAwMDA1OjAw
OjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4x
OTI3NDRdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4
MTAwMF0KWyAgICA2LjE5OTAwMF0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBh
c3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjIwNTYwNF0gcGNpIDAwMDU6MDA6MDEuMDog
UENJIGJyaWRnZSB0byBbYnVzIDAxXQpbICAgIDYuMjEwNTU5XSBwY2kgMDAwNTowMDowMS4wOiAg
IGJyaWRnZSB3aW5kb3cgW21lbSAweDMwMDAwMDAwLTB4MzAxZmZmZmZdClsgICAgNi4yMTczMzdd
IHBjaSAwMDA1OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4
MmMwMDAwMWZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4yMjU3NjVdIHBjaSAwMDA1OjAyOjAwLjA6
IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MzAyMDAwMDAtMHgzMDIwMWZmZiA2NGJpdF0KWyAgICA2
LjIzMzA3Ml0gcGNpIDAwMDU6MDA6MDMuMDogUENJIGJyaWRnZSB0byBbYnVzIDAyXQpbICAgIDYu
MjM4MDI3XSBwY2kgMDAwNTowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwMjAwMDAw
LTB4MzAzZmZmZmZdClsgICAgNi4yNDQ4MDRdIHBjaSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MmMwMDAwMjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAg
Ni4yNTMyMzFdIHBjaSAwMDA1OjAwOjA1LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwM10KWyAgICA2
LjI1ODE4NV0gcGNpIDAwMDU6MDA6MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDQwMDAw
MC0weDMwNWZmZmZmXQpbICAgIDYuMjY0OTYzXSBwY2kgMDAwNTowMDowNS4wOiAgIGJyaWRnZSB3
aW5kb3cgW21lbSAweDJjMDAwMDQwMDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQpbICAg
IDYuMjczMzkxXSBwY2kgMDAwNTowNDowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDMwNjAw
MDAwLTB4MzA2MDNmZmYgNjRiaXRdClsgICAgNi4yODA3MDZdIHBjaSAwMDA1OjAwOjA3LjA6IFBD
SSBicmlkZ2UgdG8gW2J1cyAwNF0KWyAgICA2LjI4NTY2MF0gcGNpIDAwMDU6MDA6MDcuMDogICBi
cmlkZ2Ugd2luZG93IFttZW0gMHgzMDYwMDAwMC0weDMwN2ZmZmZmXQpbICAgIDYuMjkyNDM3XSBw
Y2kgMDAwNTowMDowNy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDYwMDAwMC0weDJj
MDAwMDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMzAwODY1XSBwY2lfYnVzIDAwMDU6MDA6IHJl
c291cmNlIDQgW21lbSAweDMwMDAwMDAwLTB4M2ZmZmZmZmYgd2luZG93XQpbICAgIDYuMzA3NzI5
XSBwY2lfYnVzIDAwMDU6MDA6IHJlc291cmNlIDUgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZk
ZmZmZmZmZiB3aW5kb3ddClsgICAgNi4zMTUyODhdIHBjaV9idXMgMDAwNTowMTogcmVzb3VyY2Ug
MSBbbWVtIDB4MzAwMDAwMDAtMHgzMDFmZmZmZl0KWyAgICA2LjMyMTU0NF0gcGNpX2J1cyAwMDA1
OjAxOiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQg
cHJlZl0KWyAgICA2LjMyOTQ0OV0gcGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAxIFttZW0gMHgz
MDIwMDAwMC0weDMwM2ZmZmZmXQpbICAgIDYuMzM1NzA1XSBwY2lfYnVzIDAwMDU6MDI6IHJlc291
cmNlIDIgW21lbSAweDJjMDAwMDIwMDAwMC0weDJjMDAwMDNmZmZmZiA2NGJpdCBwcmVmXQpbICAg
IDYuMzQzNjEwXSBwY2lfYnVzIDAwMDU6MDM6IHJlc291cmNlIDEgW21lbSAweDMwNDAwMDAwLTB4
MzA1ZmZmZmZdClsgICAgNi4zNDk4NjZdIHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMiBbbWVt
IDB4MmMwMDAwNDAwMDAwLTB4MmMwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4zNTc3NzFd
IHBjaV9idXMgMDAwNTowNDogcmVzb3VyY2UgMSBbbWVtIDB4MzA2MDAwMDAtMHgzMDdmZmZmZl0K
WyAgICA2LjM2NDAyN10gcGNpX2J1cyAwMDA1OjA0OiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDA2
MDAwMDAtMHgyYzAwMDA3ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjM3MjE0NF0gaW9tbXU6IERl
ZmF1bHQgZG9tYWluIHR5cGU6IFRyYW5zbGF0ZWQgClsgICAgNi4zNzcwNTBdIHBjaSAwMDBkOjAx
OjAwLjA6IHZnYWFyYjogVkdBIGRldmljZSBhZGRlZDogZGVjb2Rlcz1pbyttZW0sb3ducz1ub25l
LGxvY2tzPW5vbmUKWyAgICA2LjM4NTM5OF0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBWR0Eg
ZGV2aWNlIGFkZGVkOiBkZWNvZGVzPWlvK21lbSxvd25zPW5vbmUsbG9ja3M9bm9uZQpbICAgIDYu
MzkzNzQxXSBwY2kgMDAwZDowMTowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxl
ClsgICAgNi4zOTk0NzZdIHBjaSAwMDA0OjAyOjAwLjA6IHZnYWFyYjogYnJpZGdlIGNvbnRyb2wg
cG9zc2libGUKWyAgICA2LjQwNTIxM10gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBzZXR0aW5n
IGFzIGJvb3QgZGV2aWNlIChWR0EgbGVnYWN5IHJlc291cmNlcyBub3QgYXZhaWxhYmxlKQpbICAg
IDYuNDE0MDczXSB2Z2FhcmI6IGxvYWRlZApbICAgIDYuNDE2ODU0XSBTQ1NJIHN1YnN5c3RlbSBp
bml0aWFsaXplZApbICAgIDYuNDIwNTk3XSBBQ1BJOiBidXMgdHlwZSBVU0IgcmVnaXN0ZXJlZApb
ICAgIDYuNDI0NjEzXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVz
YmZzClsgICAgNi40MzAxMDFdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2
ZXIgaHViClsgICAgNi40MzU0MTddIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGRldmljZSBkcml2
ZXIgdXNiClsgICAgNi40NDA0NzFdIHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAxIHJlZ2lz
dGVyZWQKWyAgICA2LjQ0NTQyNV0gcHBzX2NvcmU6IFNvZnR3YXJlIHZlci4gNS4zLjYgLSBDb3B5
cmlnaHQgMjAwNS0yMDA3IFJvZG9sZm8gR2lvbWV0dGkgPGdpb21ldHRpQGxpbnV4Lml0PgpbICAg
IDYuNDU0NTQ4XSBQVFAgY2xvY2sgc3VwcG9ydCByZWdpc3RlcmVkClsgICAgNi40NTg1NzhdIFJl
Z2lzdGVyZWQgZWZpdmFycyBvcGVyYXRpb25zClsgICAgNi40NjMyODZdIGNsb2Nrc291cmNlOiBT
d2l0Y2hlZCB0byBjbG9ja3NvdXJjZSBhcmNoX3N5c19jb3VudGVyClsgICAgNi42NDE4OThdIHBu
cDogUG5QIEFDUEkgaW5pdApbICAgIDYuNjQ2MzI4XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzYmZm
ZjAwMDAwMDAtMHgzYmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYu
NjU0MjQwXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmYg
d2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQKWyAgICA2LjY2MjQ5NF0gc3lzdGVtIDAwOjAw
OiBbbWVtIDB4MjNmZmYwMDAwMDAwLTB4MjNmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVz
ZXJ2ZWQKWyAgICA2LjY3MDQwMF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MjdmZmYwMDAwMDAwLTB4
MjdmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA2LjY3ODMwNl0gc3lz
dGVtIDAwOjAwOiBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmIHdpbmRvd10gY291
bGQgbm90IGJlIHJlc2VydmVkClsgICAgNi42ODY1NTldIHN5c3RlbSAwMDowMDogW21lbSAweDJm
ZmZmMDAwMDAwMC0weDJmZmZmZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZApb
ICAgIDYuNjk0ODEzXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg3YmZmZjAwMDAwMDAtMHg3YmZmZmZm
ZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzAyNzIxXSBzeXN0ZW0gMDA6
MDA6IFttZW0gMHg3ZmZmZjAwMDAwMDAtMHg3ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiBy
ZXNlcnZlZApbICAgIDYuNzEwNjI2XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2M2ZmZjAwMDAwMDAt
MHg2M2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzE4NTMyXSBz
eXN0ZW0gMDA6MDA6IFttZW0gMHg2N2ZmZjAwMDAwMDAtMHg2N2ZmZmZmZmZmZmYgd2luZG93XSBo
YXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzI2NDM4XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2YmZm
ZjAwMDAwMDAtMHg2YmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYu
NzM0MzQ1XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2ZmZmZjAwMDAwMDAtMHg2ZmZmZmZmZmZmZmYg
d2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzQyMjUxXSBzeXN0ZW0gMDA6MDA6IFtt
ZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVz
ZXJ2ZWQKWyAgICA2Ljc1MDUwNF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4
MzdmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkClsgICAgNi43NTg3Njdd
IHBucDogUG5QIEFDUEk6IGZvdW5kIDEgZGV2aWNlcwpbICAgIDYuNzY0NTg3XSBORVQ6IFJlZ2lz
dGVyZWQgcHJvdG9jb2wgZmFtaWx5IDIKWyAgICA2Ljc2OTEyMl0gdGNwX2xpc3Rlbl9wb3J0YWRk
cl9oYXNoIGhhc2ggdGFibGUgZW50cmllczogMTYzODQgKG9yZGVyOiA2LCAyNjIxNDQgYnl0ZXMs
IGxpbmVhcikKWyAgICA2Ljc3ODAwM10gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUgZW50cmll
czogMjYyMTQ0IChvcmRlcjogOSwgMjA5NzE1MiBieXRlcywgbGluZWFyKQpbICAgIDYuNzg3MDE2
XSBUQ1AgYmluZCBoYXNoIHRhYmxlIGVudHJpZXM6IDY1NTM2IChvcmRlcjogOCwgMTA0ODU3NiBi
eXRlcywgbGluZWFyKQpbICAgIDYuNzk0ODgyXSBUQ1A6IEhhc2ggdGFibGVzIGNvbmZpZ3VyZWQg
KGVzdGFibGlzaGVkIDI2MjE0NCBiaW5kIDY1NTM2KQpbICAgIDYuODAxNTUyXSBVRFAgaGFzaCB0
YWJsZSBlbnRyaWVzOiAxNjM4NCAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAg
IDYuODA4NzU4XSBVRFAtTGl0ZSBoYXNoIHRhYmxlIGVudHJpZXM6IDE2Mzg0IChvcmRlcjogNywg
NTI0Mjg4IGJ5dGVzLCBsaW5lYXIpClsgICAgNi44MTY1MThdIE5FVDogUmVnaXN0ZXJlZCBwcm90
b2NvbCBmYW1pbHkgMQpbICAgIDYuODIxMDQxXSBSUEM6IFJlZ2lzdGVyZWQgbmFtZWQgVU5JWCBz
b2NrZXQgdHJhbnNwb3J0IG1vZHVsZS4KWyAgICA2LjgyNjk1NV0gUlBDOiBSZWdpc3RlcmVkIHVk
cCB0cmFuc3BvcnQgbW9kdWxlLgpbICAgIDYuODMxNjQ5XSBSUEM6IFJlZ2lzdGVyZWQgdGNwIHRy
YW5zcG9ydCBtb2R1bGUuClsgICAgNi44MzYzNDNdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgTkZTdjQu
MSBiYWNrY2hhbm5lbCB0cmFuc3BvcnQgbW9kdWxlLgpbICAgIDYuODQyODIxXSBwY2kgMDAwZDow
MTowMC4xOiBEMCBwb3dlciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDYuODQ5
MjE5XSBwY2kgMDAwZDowMTowMC4yOiBEMCBwb3dlciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6
MDAuMApbICAgIDYuODU1NTk4XSBwY2kgMDAwZDowMTowMC4yOiBlbmFibGluZyBkZXZpY2UgKDAw
MDAgLT4gMDAwMikKWyAgICA2Ljg2MTI5N10gcGNpIDAwMGQ6MDE6MDAuMzogRDAgcG93ZXIgc3Rh
dGUgZGVwZW5kcyBvbiAwMDBkOjAxOjAwLjAKWyAgICA2Ljg2NzY5OV0gcGNpIDAwMDQ6MDM6MDAu
MDogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAgNi44NzMzODddIHBjaSAwMDA1
OjAyOjAwLjA6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAgIDYuODc5MDU5XSBQ
Q0k6IENMUyAxMjggYnl0ZXMsIGRlZmF1bHQgNjQKWyAgICA2Ljg4NDQxNV0gaHcgcGVyZmV2ZW50
czogZW5hYmxlZCB3aXRoIGFybXY4X3BtdXYzXzAgUE1VIGRyaXZlciwgNyBjb3VudGVycyBhdmFp
bGFibGUKWyAgICA2Ljg5MzkyOV0gd29ya2luZ3NldDogdGltZXN0YW1wX2JpdHM9NDIgbWF4X29y
ZGVyPTIzIGJ1Y2tldF9vcmRlcj0wClsgICAgNi45MDIxMTddIE5GUzogUmVnaXN0ZXJpbmcgdGhl
IGlkX3Jlc29sdmVyIGtleSB0eXBlClsgICAgNi45MDcxNjldIEtleSB0eXBlIGlkX3Jlc29sdmVy
IHJlZ2lzdGVyZWQKWyAgICA2LjkxMTM0M10gS2V5IHR5cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQK
WyAgICA2LjkxNTYxMF0gS2V5IHR5cGUgY2lmcy5pZG1hcCByZWdpc3RlcmVkClsgICAgNi45MzM5
NjBdIHhvcjogbWVhc3VyaW5nIHNvZnR3YXJlIGNoZWNrc3VtIHNwZWVkClsgICAgNi45Mzk3NTVd
ICAgIDhyZWdzICAgICAgICAgICA6ICA5NzU5IE1CL3NlYwpbICAgIDYuOTQ0OTQzXSAgICAzMnJl
Z3MgICAgICAgICAgOiAxMTc1NiBNQi9zZWMKWyAgICA2Ljk0OTk5Nl0gICAgYXJtNjRfbmVvbiAg
ICAgIDogMTM5NTggTUIvc2VjClsgICAgNi45NTQzNTFdIHhvcjogdXNpbmcgZnVuY3Rpb246IGFy
bTY0X25lb24gKDEzOTU4IE1CL3NlYykKWyAgICA2Ljk1OTg0NF0gQmxvY2sgbGF5ZXIgU0NTSSBn
ZW5lcmljIChic2cpIGRyaXZlciB2ZXJzaW9uIDAuNCBsb2FkZWQgKG1ham9yIDI0OSkKWyAgICA2
Ljk2NzIzMF0gaW8gc2NoZWR1bGVyIG1xLWRlYWRsaW5lIHJlZ2lzdGVyZWQKWyAgICA2Ljk3MTc1
N10gaW8gc2NoZWR1bGVyIGt5YmVyIHJlZ2lzdGVyZWQKWyAgICA2Ljk3NjQxMV0gZ3Bpby1kd2Fw
YiBBUE1DMEQwNzowMjogbm8gSVJRIGZvciBwb3J0MApbICAgIDYuOTgyMTk4XSBpbnB1dDogUG93
ZXIgQnV0dG9uIGFzIC9kZXZpY2VzL0xOWFNZU1RNOjAwL0xOWFNZQlVTOjAwL1BOUDBDMEM6MDAv
aW5wdXQvaW5wdXQwClsgICAgNi45OTA1ODJdIEFDUEk6IFBvd2VyIEJ1dHRvbiBbUFdSQl0KWyAg
ICA2Ljk5NzQ0M10gR0hFUzogQVBFSSBmaXJtd2FyZSBmaXJzdCBtb2RlIGlzIGVuYWJsZWQgYnkg
QVBFSSBiaXQuClsgICAgNy4wMDM2NThdIEVJTko6IEVycm9yIElOSmVjdGlvbiBpcyBpbml0aWFs
aXplZC4KWyAgICA3LjAwODM4OV0gQUNQSSBHVERUOiBmb3VuZCAxIFNCU0EgZ2VuZXJpYyBXYXRj
aGRvZyhzKS4KWyAgICA3LjAxNDI2MF0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMC5hdXRvOiBv
cHRpb24gbWFzayAweDAKWyAgICA3LjAxOTg0MF0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMC5h
dXRvOiBJRFIwLkNPSEFDQyBvdmVycmlkZGVuIGJ5IEZXIGNvbmZpZ3VyYXRpb24gKGZhbHNlKQpb
ICAgIDcuMDI4NDQyXSBhcm0tc21tdS12MyBhcm0tc21tdS12My4wLmF1dG86IGlhcyA0OC1iaXQs
IG9hcyA0OC1iaXQgKGZlYXR1cmVzIDB4MDAwMDFlY2YpClsgICAgNy4wMzY4MjRdIGFybS1zbW11
LXYzIGFybS1zbW11LXYzLjAuYXV0bzogYWxsb2NhdGVkIDI2MjE0NCBlbnRyaWVzIGZvciBjbWRx
ClsgICAgNy4wNDQyNDhdIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjAuYXV0bzogYWxsb2NhdGVk
IDEzMTA3MiBlbnRyaWVzIGZvciBldnRxClsgICAgNy4wNTIxODVdIGFybS1zbW11LXYzIGFybS1z
bW11LXYzLjEuYXV0bzogb3B0aW9uIG1hc2sgMHgwClsgICAgNy4wNTc3NjRdIGFybS1zbW11LXYz
IGFybS1zbW11LXYzLjEuYXV0bzogSURSMC5DT0hBQ0Mgb3ZlcnJpZGRlbiBieSBGVyBjb25maWd1
cmF0aW9uIChmYWxzZSkKWyAgICA3LjA2NjM2Nl0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMS5h
dXRvOiBpYXMgNDgtYml0LCBvYXMgNDgtYml0IChmZWF0dXJlcyAweDAwMDAxZWNmKQpbICAgIDcu
MDc0NzQ0XSBhcm0tc21tdS12MyBhcm0tc21tdS12My4xLmF1dG86IGFsbG9jYXRlZCAyNjIxNDQg
ZW50cmllcyBmb3IgY21kcQpbICAgIDcuMDgyMTczXSBhcm0tc21tdS12MyBhcm0tc21tdS12My4x
LmF1dG86IGFsbG9jYXRlZCAxMzEwNzIgZW50cmllcyBmb3IgZXZ0cQpbICAgIDcuMDg5OTgzXSBh
cm0tc21tdS12MyBhcm0tc21tdS12My4yLmF1dG86IG9wdGlvbiBtYXNrIDB4MApbICAgIDcuMDk1
NTU3XSBhcm0tc21tdS12MyBhcm0tc21tdS12My4yLmF1dG86IElEUjAuQ09IQUNDIG92ZXJyaWRk
ZW4gYnkgRlcgY29uZmlndXJhdGlvbiAoZmFsc2UpClsgICAgNy4xMDQxNThdIGFybS1zbW11LXYz
IGFybS1zbW11LXYzLjIuYXV0bzogaWFzIDQ4LWJpdCwgb2FzIDQ4LWJpdCAoZmVhdHVyZXMgMHgw
MDAwMWVjZikKWyAgICA3LjExMjUzNF0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMi5hdXRvOiBh
bGxvY2F0ZWQgMjYyMTQ0IGVudHJpZXMgZm9yIGNtZHEKWyAgICA3LjExOTk2MV0gYXJtLXNtbXUt
djMgYXJtLXNtbXUtdjMuMi5hdXRvOiBhbGxvY2F0ZWQgMTMxMDcyIGVudHJpZXMgZm9yIGV2dHEK
WyAgICA3LjEyNzc2OF0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMy5hdXRvOiBvcHRpb24gbWFz
ayAweDAKWyAgICA3LjEzMzM0MF0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMy5hdXRvOiBJRFIw
LkNPSEFDQyBvdmVycmlkZGVuIGJ5IEZXIGNvbmZpZ3VyYXRpb24gKGZhbHNlKQpbICAgIDcuMTQx
OTQxXSBhcm0tc21tdS12MyBhcm0tc21tdS12My4zLmF1dG86IGlhcyA0OC1iaXQsIG9hcyA0OC1i
aXQgKGZlYXR1cmVzIDB4MDAwMDFlY2YpClsgICAgNy4xNTAzMTldIGFybS1zbW11LXYzIGFybS1z
bW11LXYzLjMuYXV0bzogYWxsb2NhdGVkIDI2MjE0NCBlbnRyaWVzIGZvciBjbWRxClsgICAgNy4x
NTc3NDZdIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjMuYXV0bzogYWxsb2NhdGVkIDEzMTA3MiBl
bnRyaWVzIGZvciBldnRxClsgICAgNy4xNjU1NTddIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjQu
YXV0bzogb3B0aW9uIG1hc2sgMHgwClsgICAgNy4xNzExMzBdIGFybS1zbW11LXYzIGFybS1zbW11
LXYzLjQuYXV0bzogSURSMC5DT0hBQ0Mgb3ZlcnJpZGRlbiBieSBGVyBjb25maWd1cmF0aW9uIChm
YWxzZSkKWyAgICA3LjE3OTczMV0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuNC5hdXRvOiBpYXMg
NDgtYml0LCBvYXMgNDgtYml0IChmZWF0dXJlcyAweDAwMDAxZWNmKQpbICAgIDcuMTg4MTA4XSBh
cm0tc21tdS12MyBhcm0tc21tdS12My40LmF1dG86IGFsbG9jYXRlZCAyNjIxNDQgZW50cmllcyBm
b3IgY21kcQpbICAgIDcuMTk1NTM2XSBhcm0tc21tdS12MyBhcm0tc21tdS12My40LmF1dG86IGFs
bG9jYXRlZCAxMzEwNzIgZW50cmllcyBmb3IgZXZ0cQpbICAgIDcuMjAzNDcxXSBhc3QgMDAwNDow
MjowMC4wOiBBZGRpbmcgdG8gaW9tbXUgZ3JvdXAgMApbICAgIDcuMjA4ODQzXSBhc3QgMDAwNDow
MjowMC4wOiBbZHJtXSBwbGF0Zm9ybSBoYXMgbm8gSU8gc3BhY2UsIHRyeWluZyBNTUlPClsgICAg
Ny4yMTU2MzRdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIFVzaW5nIFAyQSBicmlkZ2UgZm9yIGNv
bmZpZ3VyYXRpb24KWyAgICA3LjIyMjE1M10gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gQVNUIDI1
MDAgZGV0ZWN0ZWQKWyAgICA3LjIyNzE5N10gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gQW5hbG9n
IFZHQSBvbmx5ClsgICAgNy4yMzIwNzBdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIGRyYW0gTUNM
Sz04MDAgTWh6IHR5cGU9OCBidXNfd2lkdGg9MTYKWyAgICA3LjIzODkzNV0gW1RUTV0gWm9uZSAg
a2VybmVsOiBBdmFpbGFibGUgZ3JhcGhpY3MgbWVtb3J5OiAxNjI1MTA5MiBLaUIKWyAgICA3LjI0
NTU0MV0gW1RUTV0gWm9uZSAgIGRtYTMyOiBBdmFpbGFibGUgZ3JhcGhpY3MgbWVtb3J5OiAyMDk3
MTUyIEtpQgpbICAgIDcuMjUyMDU3XSBbVFRNXSBJbml0aWFsaXppbmcgcG9vbCBhbGxvY2F0b3IK
WyAgICA3LjI1NjQwNl0gW1RUTV0gSW5pdGlhbGl6aW5nIERNQSBwb29sIGFsbG9jYXRvcgpbICAg
IDcuMjYxMzU3XSBbZHJtXSBJbml0aWFsaXplZCBhc3QgMC4xLjAgMjAxMjAyMjggZm9yIDAwMDQ6
MDI6MDAuMCBvbiBtaW5vciAwClsgICAgNy4yODU4MTFdIENvbnNvbGU6IHN3aXRjaGluZyB0byBj
b2xvdXIgZnJhbWUgYnVmZmVyIGRldmljZSAxMjh4NDgKWyAgICA3LjI5NDI1OF0gYXN0IDAwMDQ6
MDI6MDAuMDogW2RybV0gZmIwOiBhc3Rkcm1mYiBmcmFtZSBidWZmZXIgZGV2aWNlClsgICAgNy4z
MTQ4NTFdIGJyZDogbW9kdWxlIGxvYWRlZApbICAgIDcuMzIyNDA2XSBsb29wOiBtb2R1bGUgbG9h
ZGVkClsgICAgNy4zMjU5MDVdIG52bWUgMDAwNTowNDowMC4wOiBBZGRpbmcgdG8gaW9tbXUgZ3Jv
dXAgMQpbICAgIDcuMzMxNDEyXSBudm1lIG52bWUwOiBwY2kgZnVuY3Rpb24gMDAwNTowNDowMC4w
ClsgICAgNy4zMzYzMjJdIGlnYjogSW50ZWwoUikgR2lnYWJpdCBFdGhlcm5ldCBOZXR3b3JrIERy
aXZlcgpbICAgIDcuMzQxNzEyXSBpZ2I6IENvcHlyaWdodCAoYykgMjAwNy0yMDE0IEludGVsIENv
cnBvcmF0aW9uLgpbICAgIDcuMzQxODQ5XSBudm1lIG52bWUwOiBtaXNzaW5nIG9yIGludmFsaWQg
U1VCTlFOIGZpZWxkLgpbICAgIDcuMzQ3MzM0XSBpZ2IgMDAwNDowNDowMC4wOiBBZGRpbmcgdG8g
aW9tbXUgZ3JvdXAgMgpbICAgIDcuMzY0NDIyXSBudm1lIG52bWUwOiBhbGxvY2F0ZWQgNjQgTWlC
IGhvc3QgbWVtb3J5IGJ1ZmZlci4KWyAgICA3LjM5NTg5Ml0gbnZtZSBudm1lMDogOC8wLzAgZGVm
YXVsdC9yZWFkL3BvbGwgcXVldWVzClsgICAgNy4zOTk0NjRdIHBwcyBwcHMwOiBuZXcgUFBTIHNv
dXJjZSBwdHAwClsgICAgNy40MDUwNjldIGlnYiAwMDA0OjA0OjAwLjA6IGFkZGVkIFBIQyBvbiBl
dGgwClsgICAgNy40MDk1OTZdIGlnYiAwMDA0OjA0OjAwLjA6IEludGVsKFIpIEdpZ2FiaXQgRXRo
ZXJuZXQgTmV0d29yayBDb25uZWN0aW9uClsgICAgNy40MTY0NjNdIGlnYiAwMDA0OjA0OjAwLjA6
IGV0aDA6IChQQ0llOjIuNUdiL3M6V2lkdGggeDEpIDAwOjMwOjY0OjNiOjUwOjUyClsgICAgNy40
MjM2NDddIGlnYiAwMDA0OjA0OjAwLjA6IGV0aDA6IFBCQSBObzogMDAwMzAwLTAwMApbICAgIDcu
NDI4Nzc5XSBpZ2IgMDAwNDowNDowMC4wOiBVc2luZyBNU0ktWCBpbnRlcnJ1cHRzLiA0IHJ4IHF1
ZXVlKHMpLCA0IHR4IHF1ZXVlKHMpClsgICAgNy40MzY0MDddIGlnYnZmOiBJbnRlbChSKSBHaWdh
Yml0IFZpcnR1YWwgRnVuY3Rpb24gTmV0d29yayBEcml2ZXIKWyAgICA3LjQzNjgwNF0gIG52bWUw
bjE6IHAxIHAyIHAzClsgICAgNy40NDI2NjldIGlnYnZmOiBDb3B5cmlnaHQgKGMpIDIwMDkgLSAy
MDEyIEludGVsIENvcnBvcmF0aW9uLgpbICAgIDcuNDQyNjg2XSBpNDBlOiBJbnRlbChSKSBFdGhl
cm5ldCBDb25uZWN0aW9uIFhMNzEwIE5ldHdvcmsgRHJpdmVyClsgICAgNy40NTc4ODBdIGk0MGU6
IENvcHlyaWdodCAoYykgMjAxMyAtIDIwMTkgSW50ZWwgQ29ycG9yYXRpb24uClsgICAgNy40NjM4
NTBdIGk0MGUgMDAwMDowMTowMC4wOiBBZGRpbmcgdG8gaW9tbXUgZ3JvdXAgMwpbICAgIDcuNDY5
MjM1XSBpNDBlIDAwMDA6MDE6MDAuMDogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsg
ICAgNy40OTAwNDFdIGk0MGUgMDAwMDowMTowMC4wOiBmdyA2LjAuNDg0NDIgYXBpIDEuNyBudm0g
Ni4wMSAweDgwMDAzNDg1IDEuMTc0Ny4wIFs4MDg2OjE1ODldIFs4MDg2OjAwMDJdClsgICAgNy43
NzgyOTVdIGk0MGUgMDAwMDowMTowMC4wOiBNQUMgYWRkcmVzczogM2M6ZmQ6ZmU6NmI6ZTk6YzAK
WyAgICA3Ljc4NDE4Nl0gaTQwZSAwMDAwOjAxOjAwLjA6IEZXIExMRFAgaXMgZW5hYmxlZApbICAg
IDcuNzk1MDYxXSBpNDBlIDAwMDA6MDE6MDAuMDogUENJLUV4cHJlc3M6IFNwZWVkIDguMEdUL3Mg
V2lkdGggeDgKWyAgICA3LjgwMjMyNl0gaTQwZSAwMDAwOjAxOjAwLjA6IEZlYXR1cmVzOiBQRi1p
ZFswXSBWU0lzOiAzNCBRUDogMzIgUlNTIEZEX0FUUiBGRF9TQiBOVFVQTEUgVnhMQU4gR2VuZXZl
IFBUUCBWRVBBClsgICAgNy44MTI0NzVdIGk0MGUgMDAwMDowMTowMC4xOiBBZGRpbmcgdG8gaW9t
bXUgZ3JvdXAgNApbICAgIDcuODE3ODMxXSBpNDBlIDAwMDA6MDE6MDAuMTogZW5hYmxpbmcgZGV2
aWNlICgwMDAwIC0+IDAwMDIpClsgICAgNy44Mzc3OTddIGk0MGUgMDAwMDowMTowMC4xOiBmdyA2
LjAuNDg0NDIgYXBpIDEuNyBudm0gNi4wMSAweDgwMDAzNDg1IDEuMTc0Ny4wIFs4MDg2OjE1ODld
IFs4MDg2OjAwMDBdClsgICAgOC4xMjk3NDNdIGk0MGUgMDAwMDowMTowMC4xOiBNQUMgYWRkcmVz
czogM2M6ZmQ6ZmU6NmI6ZTk6YzEKWyAgICA4LjEzNTYyOV0gaTQwZSAwMDAwOjAxOjAwLjE6IEZX
IExMRFAgaXMgZW5hYmxlZApbICAgIDguMTQ2NDAzXSBpNDBlIDAwMDA6MDE6MDAuMTogUENJLUV4
cHJlc3M6IFNwZWVkIDguMEdUL3MgV2lkdGggeDgKWyAgICA4LjE2MjgyNF0gaTQwZSAwMDAwOjAx
OjAwLjE6IEZlYXR1cmVzOiBQRi1pZFsxXSBWU0lzOiAzNCBRUDogMzIgUlNTIEZEX0FUUiBGRF9T
QiBOVFVQTEUgVnhMQU4gR2VuZXZlIFBUUCBWRVBBClsgICAgOC4xNzI5NjddIGk0MGUgMDAwMDow
MTowMC4yOiBBZGRpbmcgdG8gaW9tbXUgZ3JvdXAgNQpbICAgIDguMTc4MzQ1XSBpNDBlIDAwMDA6
MDE6MDAuMjogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAgOC4xOTgwMzldIGk0
MGUgMDAwMDowMTowMC4yOiBmdyA2LjAuNDg0NDIgYXBpIDEuNyBudm0gNi4wMSAweDgwMDAzNDg1
IDEuMTc0Ny4wIFs4MDg2OjE1ODldIFs4MDg2OjAwMDBdClsgICAgOC40ODYwODFdIGk0MGUgMDAw
MDowMTowMC4yOiBNQUMgYWRkcmVzczogM2M6ZmQ6ZmU6NmI6ZTk6YzIKWyAgICA4LjQ5MTk2OF0g
aTQwZSAwMDAwOjAxOjAwLjI6IEZXIExMRFAgaXMgZW5hYmxlZApbICAgIDguNTAyNzQ0XSBpNDBl
IDAwMDA6MDE6MDAuMjogUENJLUV4cHJlc3M6IFNwZWVkIDguMEdUL3MgV2lkdGggeDgKWyAgICA4
LjUxMDAwN10gaTQwZSAwMDAwOjAxOjAwLjI6IEZlYXR1cmVzOiBQRi1pZFsyXSBWU0lzOiAzNCBR
UDogMzIgUlNTIEZEX0FUUiBGRF9TQiBOVFVQTEUgVnhMQU4gR2VuZXZlIFBUUCBWRVBBClsgICAg
OC41MjAxNTBdIGk0MGUgMDAwMDowMTowMC4zOiBBZGRpbmcgdG8gaW9tbXUgZ3JvdXAgNgpbICAg
IDguNTI1NTEwXSBpNDBlIDAwMDA6MDE6MDAuMzogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAw
MDIpClsgICAgOC41NDQ0NDldIGk0MGUgMDAwMDowMTowMC4zOiBmdyA2LjAuNDg0NDIgYXBpIDEu
NyBudm0gNi4wMSAweDgwMDAzNDg1IDEuMTc0Ny4wIFs4MDg2OjE1ODldIFs4MDg2OjAwMDBdClsg
ICAgOC44MzI0MzhdIGk0MGUgMDAwMDowMTowMC4zOiBNQUMgYWRkcmVzczogM2M6ZmQ6ZmU6NmI6
ZTk6YzMKWyAgICA4LjgzODMyNV0gaTQwZSAwMDAwOjAxOjAwLjM6IEZXIExMRFAgaXMgZW5hYmxl
ZApbICAgIDguODQ5MTA2XSBpNDBlIDAwMDA6MDE6MDAuMzogUENJLUV4cHJlc3M6IFNwZWVkIDgu
MEdUL3MgV2lkdGggeDgKWyAgICA4Ljg1NjM2OV0gaTQwZSAwMDAwOjAxOjAwLjM6IEZlYXR1cmVz
OiBQRi1pZFszXSBWU0lzOiAzNCBRUDogMzIgUlNTIEZEX0FUUiBGRF9TQiBOVFVQTEUgVnhMQU4g
R2VuZXZlIFBUUCBWRVBBClsgICAgOC44NjY0OThdIGVoY2lfaGNkOiBVU0IgMi4wICdFbmhhbmNl
ZCcgSG9zdCBDb250cm9sbGVyIChFSENJKSBEcml2ZXIKWyAgICA4Ljg3MzAyMV0gZWhjaS1wY2k6
IEVIQ0kgUENJIHBsYXRmb3JtIGRyaXZlcgpbICAgIDguODc3NTYzXSB4aGNpX2hjZCAwMDBkOjAx
OjAwLjI6IEFkZGluZyB0byBpb21tdSBncm91cCA3ClsgICAgOC44ODMzMzRdIHhoY2lfaGNkIDAw
MGQ6MDE6MDAuMjogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAgOC44ODk0NTZd
IHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgICA4Ljg5NDY3
N10geGhjaV9oY2QgMDAwZDowMTowMC4yOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25l
ZCBidXMgbnVtYmVyIDEKWyAgICA4LjkwMjcwNF0geGhjaV9oY2QgMDAwZDowMTowMC4yOiBoY2Mg
cGFyYW1zIDB4MDE4MGZmMDUgaGNpIHZlcnNpb24gMHgxMTAgcXVpcmtzIDB4MDAwMDAwMDAwMDAw
MDAxMApbICAgIDguOTEyMTY3XSBodWIgMS0wOjEuMDogVVNCIGh1YiBmb3VuZApbICAgIDguOTE1
OTE4XSBodWIgMS0wOjEuMDogMiBwb3J0cyBkZXRlY3RlZApbICAgIDguOTIwMDQ2XSB4aGNpX2hj
ZCAwMDBkOjAxOjAwLjI6IHhIQ0kgSG9zdCBDb250cm9sbGVyClsgICAgOC45MjUyNjRdIHhoY2lf
aGNkIDAwMGQ6MDE6MDAuMjogbmV3IFVTQiBidXMgcmVnaXN0ZXJlZCwgYXNzaWduZWQgYnVzIG51
bWJlciAyClsgICAgOC45MzI2NTJdIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogSG9zdCBzdXBwb3J0
cyBVU0IgMy4xIEVuaGFuY2VkIFN1cGVyU3BlZWQKWyAgICA4LjkzOTcxM10gdXNiIHVzYjI6IFdl
IGRvbid0IGtub3cgdGhlIGFsZ29yaXRobXMgZm9yIExQTSBmb3IgdGhpcyBob3N0LCBkaXNhYmxp
bmcgTFBNLgpbICAgIDguOTQ3OTExXSBodWIgMi0wOjEuMDogVVNCIGh1YiBmb3VuZApbICAgIDgu
OTUxNjYyXSBodWIgMi0wOjEuMDogNCBwb3J0cyBkZXRlY3RlZApbICAgIDguOTU1ODkzXSB4aGNp
X2hjZCAwMDA0OjAzOjAwLjA6IEFkZGluZyB0byBpb21tdSBncm91cCA4ClsgICAgOC45NjE2Nzdd
IHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgICA4Ljk2Njg5
N10geGhjaV9oY2QgMDAwNDowMzowMC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25l
ZCBidXMgbnVtYmVyIDMKWyAgICA4Ljk3NDMwMF0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBaZXJv
aW5nIDY0Yml0IGJhc2UgcmVnaXN0ZXJzLCBleHBlY3RpbmcgZmF1bHQKWyAgICA4Ljk4MTc0M10g
eGhjaV9oY2QgMDAwNDowMzowMC4wOiBGYXVsdCBkZXRlY3RlZApbICAgIDguOTgxNzUwXSBhcm0t
c21tdS12MyBhcm0tc21tdS12My4zLmF1dG86IGV2ZW50IDB4MTAgcmVjZWl2ZWQ6ClsgICAgOC45
OTE3OTFdIHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogaGNjIHBhcmFtcyAweDAxNDA1MWNmIGhjaSB2
ZXJzaW9uIDB4MTAwIHF1aXJrcyAweDAwMDAwMDExMDAwMDA0MTAKWyAgICA4Ljk5MjQ0NF0gYXJt
LXNtbXUtdjMgYXJtLXNtbXUtdjMuMy5hdXRvOiAJMHgwMDAwMDMwMDAwMDAwMDEwClsgICAgOS4w
MDIwOTVdIGh1YiAzLTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAgOS4wMDc0NzBdIGFybS1zbW11
LXYzIGFybS1zbW11LXYzLjMuYXV0bzogCTB4MDAwMDAyMDgwMDAwMDAwMApbICAgIDkuMDA3NDcx
XSBhcm0tc21tdS12MyBhcm0tc21tdS12My4zLmF1dG86IAkweDAwMDAwMDAwMDAwMDAwMDAKWyAg
ICA5LjAwNzQ3Ml0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuMy5hdXRvOiAJMHgwMDAwMDAwMDAw
MDAwMDAwClsgICAgOS4wMjg5NDddIGh1YiAzLTA6MS4wOiA0IHBvcnRzIGRldGVjdGVkClsgICAg
OS4wMzMxMjddIHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAg
ICA5LjAzODM0NF0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVk
LCBhc3NpZ25lZCBidXMgbnVtYmVyIDQKWyAgICA5LjA0NTczMV0geGhjaV9oY2QgMDAwNDowMzow
MC4wOiBIb3N0IHN1cHBvcnRzIFVTQiAzLjAgU3VwZXJTcGVlZApbICAgIDkuMDUyMDI3XSB1c2Ig
dXNiNDogV2UgZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGhtcyBmb3IgTFBNIGZvciB0aGlzIGhvc3Qs
IGRpc2FibGluZyBMUE0uClsgICAgOS4wNjI1NzldIGh1YiA0LTA6MS4wOiBVU0IgaHViIGZvdW5k
ClsgICAgOS4wNjYzMzFdIGh1YiA0LTA6MS4wOiA0IHBvcnRzIGRldGVjdGVkClsgICAgOS4wNzA1
NTVdIHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogQWRkaW5nIHRvIGlvbW11IGdyb3VwIDkKWyAgICA5
LjA3NjMxOF0geGhjaV9oY2QgMDAwNTowMjowMC4wOiB4SENJIEhvc3QgQ29udHJvbGxlcgpbICAg
IDkuMDgxNTUwXSB4aGNpX2hjZCAwMDA1OjAyOjAwLjA6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQs
IGFzc2lnbmVkIGJ1cyBudW1iZXIgNQpbICAgIDkuMDg4OTU0XSB4aGNpX2hjZCAwMDA1OjAyOjAw
LjA6IFplcm9pbmcgNjRiaXQgYmFzZSByZWdpc3RlcnMsIGV4cGVjdGluZyBmYXVsdApbICAgIDku
MDk2Mzg5XSBhcm0tc21tdS12MyBhcm0tc21tdS12My40LmF1dG86IGV2ZW50IDB4MTAgcmVjZWl2
ZWQ6ClsgICAgOS4wOTYzOTldIHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogRmF1bHQgZGV0ZWN0ZWQK
WyAgICA5LjEwMjM5NV0gYXJtLXNtbXUtdjMgYXJtLXNtbXUtdjMuNC5hdXRvOiAJMHgwMDAwMDIw
MDAwMDAwMDEwClsgICAgOS4xMTI5OTJdIGFybS1zbW11LXYzIGFybS1zbW11LXYzLjQuYXV0bzog
CTB4MDAwMDAyMDgwMDAwMDAwMApbICAgIDkuMTE4OTAwXSBhcm0tc21tdS12MyBhcm0tc21tdS12
My40LmF1dG86IAkweDAwMDAwMDAwMDAwMDAwMDAKWyAgICA5LjEyNDgwOV0gYXJtLXNtbXUtdjMg
YXJtLXNtbXUtdjMuNC5hdXRvOiAJMHgwMDAwMDAwMDAwMDAwMDAwClsgICAgOS4yMTgwNTBdIHho
Y2lfaGNkIDAwMDU6MDI6MDAuMDogaGNjIHBhcmFtcyAweDAxNDA1MWNmIGhjaSB2ZXJzaW9uIDB4
MTAwIHF1aXJrcyAweDAwMDAwMDExMDAwMDA0MTAKWyAgICA5LjIyNzk5NV0gaHViIDUtMDoxLjA6
IFVTQiBodWIgZm91bmQKWyAgICA5LjIzMTc0OV0gaHViIDUtMDoxLjA6IDQgcG9ydHMgZGV0ZWN0
ZWQKWyAgICA5LjIzNTkzMl0geGhjaV9oY2QgMDAwNTowMjowMC4wOiB4SENJIEhvc3QgQ29udHJv
bGxlcgpbICAgIDkuMjQxMTQ5XSB4aGNpX2hjZCAwMDA1OjAyOjAwLjA6IG5ldyBVU0IgYnVzIHJl
Z2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIgNgpbICAgIDkuMjQ4NTM4XSB4aGNpX2hjZCAw
MDA1OjAyOjAwLjA6IEhvc3Qgc3VwcG9ydHMgVVNCIDMuMCBTdXBlclNwZWVkClsgICAgOS4yNTQ4
MzFdIHVzYiB1c2I2OiBXZSBkb24ndCBrbm93IHRoZSBhbGdvcml0aG1zIGZvciBMUE0gZm9yIHRo
aXMgaG9zdCwgZGlzYWJsaW5nIExQTS4KWyAgICA5LjI2MzA0OV0gaHViIDYtMDoxLjA6IFVTQiBo
dWIgZm91bmQKWyAgICA5LjI2NjgwMV0gaHViIDYtMDoxLjA6IDQgcG9ydHMgZGV0ZWN0ZWQKWyAg
ICA5LjI3MTI1MF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciB1c2It
c3RvcmFnZQpbICAgIDkuMjc4MTQwXSBydGMtZWZpIHJ0Yy1lZmkuMDogcmVnaXN0ZXJlZCBhcyBy
dGMwClsgICAgOS4yODMyNzhdIHJ0Yy1lZmkgcnRjLWVmaS4wOiBzZXR0aW5nIHN5c3RlbSBjbG9j
ayB0byAyMDIyLTA0LTE0VDE3OjMyOjQ5IFVUQyAoMTY0OTk1NzU2OSkKWyAgICA5LjI5MTc4Ml0g
c2JzYS1nd2R0IHNic2EtZ3dkdC4wOiBJbml0aWFsaXplZCB3aXRoIDEwcyB0aW1lb3V0IEAgMjUw
MDAwMDAgSHosIGFjdGlvbj0wLgpbICAgIDkuMzAwMDQzXSBkZXZpY2UtbWFwcGVyOiBpb2N0bDog
NC40My4wLWlvY3RsICgyMDIwLTEwLTAxKSBpbml0aWFsaXNlZDogZG0tZGV2ZWxAcmVkaGF0LmNv
bQpbICAgIDkuMzA5NDk2XSBwc3RvcmU6IFJlZ2lzdGVyZWQgZWZpIGFzIHBlcnNpc3RlbnQgc3Rv
cmUgYmFja2VuZApbICAgIDkuMzE1MzQ3XSBTTUNDQzogU09DX0lEOiBJRCA9IGplcDEwNjowYTE2
OjAwMDEgUmV2aXNpb24gPSAweDAwMDAwMGExClsgICAgOS4zMjE5NzldIHVzYmNvcmU6IHJlZ2lz
dGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgdXNiaGlkClsgICAgOS4zMjc1NDJdIHVzYmhpZDog
VVNCIEhJRCBjb3JlIGRyaXZlcgpbICAgIDkuMzMxNDAwXSB1MzIgY2xhc3NpZmllcgpbICAgIDku
MzM0MDk1XSAgICAgaW5wdXQgZGV2aWNlIGNoZWNrIG9uClsgICAgOS4zMzc3NDhdICAgICBBY3Rp
b25zIGNvbmZpZ3VyZWQKWyAgICA5LjM0MTUyOV0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZh
bWlseSAxMApbICAgIDkuMzQ2MzUxXSBTZWdtZW50IFJvdXRpbmcgd2l0aCBJUHY2ClsgICAgOS4z
NTAwMzNdIHNpdDogSVB2NiwgSVB2NCBhbmQgTVBMUyBvdmVyIElQdjQgdHVubmVsaW5nIGRyaXZl
cgpbICAgIDkuMzU2MDc1XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDE3ClsgICAg
OS4zNjA1MjZdIEJyaWRnZSBmaXJld2FsbGluZyByZWdpc3RlcmVkClsgICAgOS4zNjQ1NTNdIEtl
eSB0eXBlIGRuc19yZXNvbHZlciByZWdpc3RlcmVkClsgICAgOS4zNjg4ODRdIE5FVDogUmVnaXN0
ZXJlZCBwcm90b2NvbCBmYW1pbHkgNDAKWyAgICA5LjM3MzQ0OV0gS2V5IHR5cGUgLl9mc2NyeXB0
IHJlZ2lzdGVyZWQKWyAgICA5LjM3NzQ1MV0gS2V5IHR5cGUgLmZzY3J5cHQgcmVnaXN0ZXJlZApb
ICAgIDkuMzgxMzY0XSBLZXkgdHlwZSBmc2NyeXB0LXByb3Zpc2lvbmluZyByZWdpc3RlcmVkClsg
ICAgOS4zODY1NDFdIEJ0cmZzIGxvYWRlZCwgY3JjMzJjPWNyYzMyYy1nZW5lcmljClsgICAgOS4z
OTExNTJdIHBzdG9yZTogVXNpbmcgY3Jhc2ggZHVtcCBjb21wcmVzc2lvbjogZGVmbGF0ZQpbICAg
IDkuMzk3MDk1XSBLZXkgdHlwZSBlbmNyeXB0ZWQgcmVnaXN0ZXJlZApbICAgIDkuNDAxMzY0XSBC
RVJUOiBFcnJvciByZWNvcmRzIGZyb20gcHJldmlvdXMgYm9vdDoKWyAgICA5LjQwNjIzNF0gW0hh
cmR3YXJlIEVycm9yXTogZXZlbnQgc2V2ZXJpdHk6IHJlY292ZXJhYmxlClsgICAgOS40MTE2MjRd
IFtIYXJkd2FyZSBFcnJvcl06ICBFcnJvciAwLCB0eXBlOiBmYXRhbApbICAgIDkuNDE2NDkyXSBb
SGFyZHdhcmUgRXJyb3JdOiAgIHNlY3Rpb24gdHlwZTogdW5rbm93biwgZThlZDg5OGQtZGYxNi00
M2NjLThlY2MtNTRmMDYwZWYxNTdmClsgICAgOS40MjQ4MzJdIFtIYXJkd2FyZSBFcnJvcl06ICAg
c2VjdGlvbiBsZW5ndGg6IDB4MzEKWyAgICA5LjQyOTc4OF0gW0hhcmR3YXJlIEVycm9yXTogICAw
MDAwMDAwMDogMDAwMDAwN2YgNmU2YjZlNTUgMjA2ZTc3NmYgNmY2MjY1NzIgIC4uLi5Vbmtub3du
IHJlYm8KWyAgICA5LjQzODQ3N10gW0hhcmR3YXJlIEVycm9yXTogICAwMDAwMDAxMDogNzIyMDc0
NmYgNmY3MzYxNjUgMDAwMDAwNmUgMDAwMDAwMDAgIG90IHJlYXNvbi4uLi4uLi4KWyAgICA5LjQ0
NzE2NV0gW0hhcmR3YXJlIEVycm9yXTogICAwMDAwMDAyMDogMDAwMDAwMDAgMDAwMDAwMDAgMDAw
MDAwMDAgMDAwMDAwMDAgIC4uLi4uLi4uLi4uLi4uLi4KWyAgICA5LjQ1NTg1MV0gW0hhcmR3YXJl
IEVycm9yXTogICAwMDAwMDAzMDogMTEgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIC4KWyAgICA5LjQ1OTMwM10gdXNiIDMtNDogbmV3IGhpZ2gtc3BlZWQgVVNC
IGRldmljZSBudW1iZXIgMiB1c2luZyB4aGNpX2hjZApbICAgIDkuNDcwODE5XSBwcmludGs6IGNv
bnNvbGUgW25ldGNvbjBdIGVuYWJsZWQKWyAgICA5LjQ3NTE2OV0gbmV0Y29uc29sZTogbmV0d29y
ayBsb2dnaW5nIHN0YXJ0ZWQKWyAgICA5LjQ3OTc2N10gbWQ6IFdhaXRpbmcgZm9yIGFsbCBkZXZp
Y2VzIHRvIGJlIGF2YWlsYWJsZSBiZWZvcmUgYXV0b2RldGVjdApbICAgIDkuNDg2NTQ1XSBtZDog
SWYgeW91IGRvbid0IHVzZSByYWlkLCB1c2UgcmFpZD1ub2F1dG9kZXRlY3QKWyAgICA5LjQ5MjE5
M10gbWQ6IEF1dG9kZXRlY3RpbmcgUkFJRCBhcnJheXMuClsgICAgOS40OTYyNzldIG1kOiBhdXRv
cnVuIC4uLgpbICAgIDkuNDk5MDYxXSBtZDogLi4uIGF1dG9ydW4gRE9ORS4KWyAgICA5LjUwMjQw
N10gV2FpdGluZyBmb3Igcm9vdCBkZXZpY2UgL2Rldi9zZGEyLi4uClsgICAgOS42MDQxOTJdIHVz
YiA2LTE6IG5ldyBTdXBlclNwZWVkIEdlbiAxIFVTQiBkZXZpY2UgbnVtYmVyIDIgdXNpbmcgeGhj
aV9oY2QKWyAgICA5LjYzODcyNF0gaHViIDMtNDoxLjA6IFVTQiBodWIgZm91bmQKWyAgICA5LjY0
NDI4Nl0gaHViIDMtNDoxLjA6IDUgcG9ydHMgZGV0ZWN0ZWQKWyAgICA5LjY2MzA3M10gdXNiLXN0
b3JhZ2UgNi0xOjEuMDogVVNCIE1hc3MgU3RvcmFnZSBkZXZpY2UgZGV0ZWN0ZWQKWyAgICA5LjY2
OTM3NF0gc2NzaSBob3N0MDogdXNiLXN0b3JhZ2UgNi0xOjEuMApbICAgIDkuOTgzNDMxXSB1c2Ig
My00LjE6IG5ldyBoaWdoLXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDMgdXNpbmcgeGhjaV9oY2QK
WyAgIDEwLjEyNTEwN10gdXNiLXN0b3JhZ2UgMy00LjE6MS4wOiBVU0IgTWFzcyBTdG9yYWdlIGRl
dmljZSBkZXRlY3RlZApbICAgMTAuMTMxNTc5XSBzY3NpIGhvc3QxOiB1c2Itc3RvcmFnZSAzLTQu
MToxLjAKWyAgIDEwLjIyMzMyN10gdXNiIDMtNC4yOiBuZXcgaGlnaC1zcGVlZCBVU0IgZGV2aWNl
IG51bWJlciA0IHVzaW5nIHhoY2lfaGNkClsgICAxMC4zNzI4MTNdIHVzYi1zdG9yYWdlIDMtNC4y
OjEuMDogVVNCIE1hc3MgU3RvcmFnZSBkZXZpY2UgZGV0ZWN0ZWQKWyAgIDEwLjM3OTI3Ml0gc2Nz
aSBob3N0MjogdXNiLXN0b3JhZ2UgMy00LjI6MS4wClsgICAxMC40NzEzMjZdIHVzYiAzLTQuMzog
bmV3IGxvdy1zcGVlZCBVU0IgZGV2aWNlIG51bWJlciA1IHVzaW5nIHhoY2lfaGNkClsgICAxMC42
NDQ4ODVdIGlucHV0OiBBbWVyaWNhbiBNZWdhdHJlbmRzIEluYy4gVmlydHVhbCBLZXlib2FyZCBh
bmQgTW91c2UgYXMgL2RldmljZXMvcGNpMDAwNDowMC8wMDA0OjAwOjAzLjAvMDAwNDowMzowMC4w
L3VzYjMvMy00LzMtNC4zLzMtNC4zOjEuMC8wMDAzOjA0NkI6RkYxMC4wMDAxL2lucHV0L2lucHV0
MQpbICAgMTAuNjYwNzMyXSBoaWQtZ2VuZXJpYyAwMDAzOjA0NkI6RkYxMC4wMDAxOiBpbnB1dDog
VVNCIEhJRCB2MS4xMCBLZXlib2FyZCBbQW1lcmljYW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1YWwg
S2V5Ym9hcmQgYW5kIE1vdXNlXSBvbiB1c2ItMDAwNDowMzowMC4wLTQuMy9pbnB1dDAKWyAgIDEw
LjY4NjU3M10gaW5wdXQ6IEFtZXJpY2FuIE1lZ2F0cmVuZHMgSW5jLiBWaXJ0dWFsIEtleWJvYXJk
IGFuZCBNb3VzZSBhcyAvZGV2aWNlcy9wY2kwMDA0OjAwLzAwMDQ6MDA6MDMuMC8wMDA0OjAzOjAw
LjAvdXNiMy8zLTQvMy00LjMvMy00LjM6MS4xLzAwMDM6MDQ2QjpGRjEwLjAwMDIvaW5wdXQvaW5w
dXQyClsgICAxMC43MDI0MDddIGhpZC1nZW5lcmljIDAwMDM6MDQ2QjpGRjEwLjAwMDI6IGlucHV0
OiBVU0IgSElEIHYxLjEwIE1vdXNlIFtBbWVyaWNhbiBNZWdhdHJlbmRzIEluYy4gVmlydHVhbCBL
ZXlib2FyZCBhbmQgTW91c2VdIG9uIHVzYi0wMDA0OjAzOjAwLjAtNC4zL2lucHV0MQpbICAgMTAu
NzE4NjA5XSBzY3NpIDA6MDowOjA6IERpcmVjdC1BY2Nlc3MgICAgICBVU0IgICAgICBTYW5EaXNr
IDMuMkdlbjEgMS4wMCBQUTogMCBBTlNJOiA2ClsgICAxMC43MjcwODldIHNkIDA6MDowOjA6IFtz
ZGFdIDEyMDE3NjY0MCA1MTItYnl0ZSBsb2dpY2FsIGJsb2NrczogKDYxLjUgR0IvNTcuMyBHaUIp
ClsgICAxMC43MzY5MDBdIHNkIDA6MDowOjA6IFtzZGFdIFdyaXRlIFByb3RlY3QgaXMgb2ZmClsg
ICAxMC43NDQyMTldIHNkIDA6MDowOjA6IFtzZGFdIFdyaXRlIGNhY2hlOiBkaXNhYmxlZCwgcmVh
ZCBjYWNoZTogZW5hYmxlZCwgZG9lc24ndCBzdXBwb3J0IERQTyBvciBGVUEKWyAgIDEwLjc3ODQ5
N10gR1BUOlByaW1hcnkgaGVhZGVyIHRoaW5rcyBBbHQuIGhlYWRlciBpcyBub3QgYXQgdGhlIGVu
ZCBvZiB0aGUgZGlzay4KWyAgIDEwLjc4NTg5MV0gR1BUOjE3MTgxOTUxICE9IDEyMDE3NjYzOQpb
ICAgMTAuNzg5NTQ1XSBHUFQ6QWx0ZXJuYXRlIEdQVCBoZWFkZXIgbm90IGF0IHRoZSBlbmQgb2Yg
dGhlIGRpc2suClsgICAxMC43OTU1MzldIEdQVDoxNzE4MTk1MSAhPSAxMjAxNzY2MzkKWyAgIDEw
Ljc5OTE4OV0gR1BUOiBVc2UgR05VIFBhcnRlZCB0byBjb3JyZWN0IEdQVCBlcnJvcnMuClsgICAx
MC44MDQzMzFdICBzZGE6IHNkYTEgc2RhMgpbICAgMTAuODEzMTE2XSBzZCAwOjA6MDowOiBbc2Rh
XSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNrClsgICAxMC44NTA5ODZdIHJhbmRvbTogZmFz
dCBpbml0IGRvbmUKWyAgIDExLjE1NDQ3OF0gc2NzaSAxOjA6MDowOiBDRC1ST00gICAgICAgICAg
ICBBTUkgICAgICBWaXJ0dWFsIENEUk9NMCAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDEx
LjE2MzQyMF0gc2NzaSAxOjA6MDoxOiBDRC1ST00gICAgICAgICAgICBBTUkgICAgICBWaXJ0dWFs
IENEUk9NMSAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDExLjE3Mjk4OV0gc2NzaSAxOjA6
MDoyOiBDRC1ST00gICAgICAgICAgICBBTUkgICAgICBWaXJ0dWFsIENEUk9NMiAgIDEuMDAgUFE6
IDAgQU5TSTogMCBDQ1MKWyAgIDExLjE4MTY2MF0gc2NzaSAxOjA6MDozOiBDRC1ST00gICAgICAg
ICAgICBBTUkgICAgICBWaXJ0dWFsIENEUk9NMyAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAg
IDExLjI5MTM1NV0gRVhUNC1mcyAoc2RhMik6IHJlY292ZXJ5IGNvbXBsZXRlClsgICAxMS4yOTcz
NzBdIEVYVDQtZnMgKHNkYTIpOiBtb3VudGVkIGZpbGVzeXN0ZW0gd2l0aCBvcmRlcmVkIGRhdGEg
bW9kZS4gT3B0czogKG51bGwpClsgICAxMS4zMDUwMzZdIFZGUzogTW91bnRlZCByb290IChleHQ0
IGZpbGVzeXN0ZW0pIG9uIGRldmljZSA4OjIuClsgICAxMS4zMTQyMDJdIGRldnRtcGZzOiBtb3Vu
dGVkClsgICAxMS4zMTg3NTRdIEZyZWVpbmcgdW51c2VkIGtlcm5lbCBtZW1vcnk6IDQxNjBLClsg
ICAxMS4zMjMzMzNdIFJ1biAvc2Jpbi9pbml0IGFzIGluaXQgcHJvY2VzcwpbICAgMTEuNDA4MDEw
XSBzY3NpIDI6MDowOjA6IERpcmVjdC1BY2Nlc3MgICAgIEFNSSAgICAgIFZpcnR1YWwgSERpc2sw
ICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMTEuNDE4NjI1XSBzY3NpIDI6MDowOjE6IERp
cmVjdC1BY2Nlc3MgICAgIEFNSSAgICAgIFZpcnR1YWwgSERpc2sxICAgMS4wMCBQUTogMCBBTlNJ
OiAwIENDUwpbICAgMTEuNDI4NzgzXSBzY3NpIDI6MDowOjI6IERpcmVjdC1BY2Nlc3MgICAgIEFN
SSAgICAgIFZpcnR1YWwgSERpc2syICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMTEuNDM3
NDY3XSBzY3NpIDI6MDowOjM6IERpcmVjdC1BY2Nlc3MgICAgIEFNSSAgICAgIFZpcnR1YWwgSERp
c2szICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMTEuNDM4MTQwXSBzZCAyOjA6MDowOiBb
c2RiXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNrClsgICAxMS40NDYxNjldIHNjc2kgMjow
OjA6NDogRGlyZWN0LUFjY2VzcyAgICAgQU1JICAgICAgVmlydHVhbCBIRGlzazQgICAxLjAwIFBR
OiAwIEFOU0k6IDAgQ0NTClsgICAxMS40NTIxNThdIHNkIDI6MDowOjE6IFtzZGNdIEF0dGFjaGVk
IFNDU0kgcmVtb3ZhYmxlIGRpc2sKWyAgIDExLjQ2ODA5NF0gc2QgMjowOjA6MjogW3NkZF0gQXR0
YWNoZWQgU0NTSSByZW1vdmFibGUgZGlzawpbICAgMTEuNDgwNDY5XSBzZCAyOjA6MDozOiBbc2Rl
XSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNrClsgICAxMS40ODgzNzZdIHNkIDI6MDowOjQ6
IFtzZGZdIEF0dGFjaGVkIFNDU0kgcmVtb3ZhYmxlIGRpc2sKWyAgIDExLjUwMTE2MF0gc3lzdGVt
ZFsxXTogc3lzdGVtZCAyNDkuNysgcnVubmluZyBpbiBzeXN0ZW0gbW9kZSAoLVBBTSAtQVVESVQg
LVNFTElOVVggLUFQUEFSTU9SICtJTUEgLVNNQUNLICtTRUNDT01QIC1HQ1JZUFQgLUdOVVRMUyAt
T1BFTlNTTCArQUNMICtCTEtJRCAtQ1VSTCAtRUxGVVRJTFMgLUZJRE8yIC1JRE4yIC1JRE4gLUlQ
VEMgK0tNT0QgLUxJQkNSWVBUU0VUVVAgK0xJQkZESVNLIC1QQ1JFMiAtUFdRVUFMSVRZIC1QMTFL
SVQgLVFSRU5DT0RFIC1CWklQMiAtTFo0IC1YWiAtWkxJQiArWlNURCArWEtCQ09NTU9OICtVVE1Q
ICtTWVNWSU5JVCBkZWZhdWx0LWhpZXJhcmNoeT1oeWJyaWQpClsgICAxMS41MzE1OThdIHN5c3Rl
bWRbMV06IERldGVjdGVkIGFyY2hpdGVjdHVyZSBhcm02NC4KCldlbGNvbWUgdG8gRVdBT0wgKEVk
Z2UgV29ya2xvYWQgQWJzdHJhY3Rpb24gYW5kIE9yY2hlc3RyYXRpb24gTGF5ZXIpIHVuc3RhYmxl
IChob25pc3RlcikhCgpbICAgMTEuNTkwNjMxXSBzeXN0ZW1kWzFdOiBIb3N0bmFtZSBzZXQgdG8g
PGNvbWhwYz4uClsgICAxMS42MzQwNzldIHN5c3RlbWQtc3lzdi1nZW5lcmF0b3JbMzM0XTogU3lz
ViBzZXJ2aWNlICcvZXRjL2luaXQuZC9jb25udHJhY2tkJyBsYWNrcyBhIG5hdGl2ZSBzeXN0ZW1k
IHVuaXQgZmlsZS4gQXV0b21hdGljYWxseSBnZW5lcmF0aW5nIGEgdW5pdCBmaWxlIGZvciBjb21w
YXRpYmlsaXR5LiBQbGVhc2UgdXBkYXRlIHBhY2thZ2UgdG8gaW5jbHVkZSBhIG5hdGl2ZSBzeXN0
ZW1kIHVuaXQgZmlsZSwgaW4gb3JkZXIgdG8gbWFrZSBpdCBtb3JlIHNhZmUgYW5kIHJvYnVzdC4K
WyAgIDExLjY1ODA5NF0gc3lzdGVtZC1zeXN2LWdlbmVyYXRvclszMzRdOiBTeXNWIHNlcnZpY2Ug
Jy9ldGMvaW5pdC5kL2Nvbm50cmFjay1mYWlsb3ZlcicgbGFja3MgYSBuYXRpdmUgc3lzdGVtZCB1
bml0IGZpbGUuIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGluZyBhIHVuaXQgZmlsZSBmb3IgY29tcGF0
aWJpbGl0eS4gUGxlYXNlIHVwZGF0ZSBwYWNrYWdlIHRvIGluY2x1ZGUgYSBuYXRpdmUgc3lzdGVt
ZCB1bml0IGZpbGUsIGluIG9yZGVyIHRvIG1ha2UgaXQgbW9yZSBzYWZlIGFuZCByb2J1c3QuClsg
ICAxMS43NDc2OTJdIHN5c3RlbWRbMV06IC9saWIvc3lzdGVtZC9zeXN0ZW0veGVuLXFlbXUtZG9t
MC1kaXNrLWJhY2tlbmQuc2VydmljZToxMTogUElERmlsZT0gcmVmZXJlbmNlcyBhIHBhdGggYmVs
b3cgbGVnYWN5IGRpcmVjdG9yeSAvdmFyL3J1bi8sIHVwZGF0aW5nIC92YXIvcnVuL3hlbi9xZW11
LWRvbTAucGlkIOKGkiAvcnVuL3hlbi9xZW11LWRvbTAucGlkOyBwbGVhc2UgdXBkYXRlIHRoZSB1
bml0IGZpbGUgYWNjb3JkaW5nbHkuClsgICAxMS44MzM2NjBdIHN5c3RlbWRbMV06IFF1ZXVlZCBz
dGFydCBqb2IgZm9yIGRlZmF1bHQgdGFyZ2V0IE11bHRpLVVzZXIgU3lzdGVtLgpbICAgMTEuODQx
MTcwXSByYW5kb206IHN5c3RlbWQ6IHVuaW5pdGlhbGl6ZWQgdXJhbmRvbSByZWFkICgxNiBieXRl
cyByZWFkKQpbICAgMTEuODcyOTE5XSBzeXN0ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIFNsaWNlIC9z
eXN0ZW0vZ2V0dHkuClsgIE9LICBdIENyZWF0ZWQgc2xpY2UgU2xpY2UgL3N5c3RlbS9nZXR0eS4K
WyAgIDExLjg5MTUwM10gcmFuZG9tOiBzeXN0ZW1kOiB1bmluaXRpYWxpemVkIHVyYW5kb20gcmVh
ZCAoMTYgYnl0ZXMgcmVhZCkKWyAgIDExLjg5ODc0Ml0gc3lzdGVtZFsxXTogQ3JlYXRlZCBzbGlj
ZSBTbGljZSAvc3lzdGVtL21vZHByb2JlLgpbICBPSyAgXSBDcmVhdGVkIHNsaWNlIFNsaWNlIC9z
eXN0ZW0vbW9kcHJvYmUuClsgICAxMS45MTk0MThdIHJhbmRvbTogc3lzdGVtZDogdW5pbml0aWFs
aXplZCB1cmFuZG9tIHJlYWQgKDE2IGJ5dGVzIHJlYWQpClsgICAxMS45MjY2MTddIHN5c3RlbWRb
MV06IENyZWF0ZWQgc2xpY2UgU2xpY2UgL3N5c3RlbS9zZXJpYWwtZ2V0dHkuClsgIE9LICBdIENy
ZWF0ZWQgc2xpY2UgU2xpY2UgL3N5c3RlbS9zZXJpYWwtZ2V0dHkuClsgICAxMS45NDgyNThdIHN5
c3RlbWRbMV06IENyZWF0ZWQgc2xpY2UgVXNlciBhbmQgU2Vzc2lvbiBTbGljZS4KWyAgT0sgIF0g
Q3JlYXRlZCBzbGljZSBVc2VyIGFuZCBTZXNzaW9uIFNsaWNlLgpbICAgMTEuOTcxNjA4XSBzeXN0
ZW1kWzFdOiBTdGFydGVkIERpc3BhdGNoIFBhc3N3b3JkIFJlcXVlc3RzIHRvIENvbnNvbGUgRGly
ZWN0b3J5IFdhdGNoLgpbICBPSyAgXSBTdGFydGVkIERpc3BhdGNoIFBhc3N3b3JkIOKApnRzIHRv
IENvbnNvbGUgRGlyZWN0b3J5IFdhdGNoLgpbICAgMTEuOTk1NTQ1XSBzeXN0ZW1kWzFdOiBTdGFy
dGVkIEZvcndhcmQgUGFzc3dvcmQgUmVxdWVzdHMgdG8gV2FsbCBEaXJlY3RvcnkgV2F0Y2guClsg
IE9LICBdIFN0YXJ0ZWQgRm9yd2FyZCBQYXNzd29yZCBS4oCmdWVzdHMgdG8gV2FsbCBEaXJlY3Rv
cnkgV2F0Y2guClsgICAxMi4wMTk2MDNdIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0IFBhdGgg
VW5pdHMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFBhdGggVW5pdHMuClsgICAxMi4wMzk0MzFd
IHN5c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0IFJlbW90ZSBGaWxlIFN5c3RlbXMuClsgIE9LICBd
IFJlYWNoZWQgdGFyZ2V0IFJlbW90ZSBGaWxlIFN5c3RlbXMuClsgICAxMi4wNTk0MzNdIHN5c3Rl
bWRbMV06IFJlYWNoZWQgdGFyZ2V0IFNsaWNlIFVuaXRzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdl
dCBTbGljZSBVbml0cy4KWyAgIDEyLjA3OTQ0OV0gc3lzdGVtZFsxXTogUmVhY2hlZCB0YXJnZXQg
U3dhcHMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFN3YXBzLgpbICAgMTIuMTAyMzYxXSBzeXN0
ZW1kWzFdOiBMaXN0ZW5pbmcgb24gUlBDYmluZCBTZXJ2ZXIgQWN0aXZhdGlvbiBTb2NrZXQuClsg
IE9LICBdIExpc3RlbmluZyBvbiBSUENiaW5kIFNlcnZlciBBY3RpdmF0aW9uIFNvY2tldC4KWyAg
IDEyLjEyMzUxOF0gc3lzdGVtZFsxXTogUmVhY2hlZCB0YXJnZXQgUlBDIFBvcnQgTWFwcGVyLgpb
ICBPSyAgXSBSZWFjaGVkIHRhcmdldCBSUEMgUG9ydCBNYXBwZXIuClsgICAxMi4xNDM3NDBdIHN5
c3RlbWRbMV06IExpc3RlbmluZyBvbiBTeXNsb2cgU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcg
b24gU3lzbG9nIFNvY2tldC4KWyAgIDEyLjE2MzU2MF0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9u
IGluaXRjdGwgQ29tcGF0aWJpbGl0eSBOYW1lZCBQaXBlLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24g
aW5pdGN0bCBDb21wYXRpYmlsaXR5IE5hbWVkIFBpcGUuClsgICAxMi4xODQ2ODFdIHN5c3RlbWRb
MV06IENvbmRpdGlvbiBjaGVjayByZXN1bHRlZCBpbiBKb3VybmFsIEF1ZGl0IFNvY2tldCBiZWlu
ZyBza2lwcGVkLgpbICAgMTIuMTkyNzk1XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gSm91cm5h
bCBTb2NrZXQgKC9kZXYvbG9nKS4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIEpvdXJuYWwgU29ja2V0
ICgvZGV2L2xvZykuClsgICAxMi4yMTE2NzZdIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBKb3Vy
bmFsIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIEpvdXJuYWwgU29ja2V0LgpbICAgMTIu
MjMxNzA5XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gTmV0d29yayBTZXJ2aWNlIE5ldGxpbmsg
U29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gTmV0d29yayBTZXJ2aWNlIE5ldGxpbmsgU29j
a2V0LgpbICAgMTIuMjUxNzI2XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gdWRldiBDb250cm9s
IFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIHVkZXYgQ29udHJvbCBTb2NrZXQuClsgICAx
Mi4yNzE1OTZdIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiB1ZGV2IEtlcm5lbCBTb2NrZXQuClsg
IE9LICBdIExpc3RlbmluZyBvbiB1ZGV2IEtlcm5lbCBTb2NrZXQuClsgICAxMi4yOTE2MDldIHN5
c3RlbWRbMV06IExpc3RlbmluZyBvbiBVc2VyIERhdGFiYXNlIE1hbmFnZXIgU29ja2V0LgpbICBP
SyAgXSBMaXN0ZW5pbmcgb24gVXNlciBEYXRhYmFzZSBNYW5hZ2VyIFNvY2tldC4KWyAgIDEyLjMx
MjkyM10gc3lzdGVtZFsxXTogTW91bnRpbmcgSHVnZSBQYWdlcyBGaWxlIFN5c3RlbS4uLgogICAg
ICAgICBNb3VudGluZyBIdWdlIFBhZ2VzIEZpbGUgU3lzdGVtLi4uClsgICAxMi4zMzI4NDFdIHN5
c3RlbWRbMV06IE1vdW50aW5nIFBPU0lYIE1lc3NhZ2UgUXVldWUgRmlsZSBTeXN0ZW0uLi4KICAg
ICAgICAgTW91bnRpbmcgUE9TSVggTWVzc2FnZSBRdWV1ZSBGaWxlIFN5c3RlbS4uLgpbICAgMTIu
MzU1NTEzXSBzeXN0ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gTW91bnQgL3By
b2MveGVuIGZpbGVzIGJlaW5nIHNraXBwZWQuClsgICAxMi4zNjQ3NDddIHN5c3RlbWRbMV06IE1v
dW50aW5nIEtlcm5lbCBEZWJ1ZyBGaWxlIFN5c3RlbS4uLgogICAgICAgICBNb3VudGluZyBLZXJu
ZWwgRGVidWcgRmlsZSBTeXN0ZW0uLi4KWyAgIDEyLjM4NDg2MV0gc3lzdGVtZFsxXTogTW91bnRp
bmcgS2VybmVsIFRyYWNlIEZpbGUgU3lzdGVtLi4uCiAgICAgICAgIE1vdW50aW5nIEtlcm5lbCBU
cmFjZSBGaWxlIFN5c3RlbS4uLgpbICAgMTIuNDA2MzQ4XSBzeXN0ZW1kWzFdOiBNb3VudGluZyBU
ZW1wb3JhcnkgRGlyZWN0b3J5IC90bXAuLi4KICAgICAgICAgTW91bnRpbmcgVGVtcG9yYXJ5IERp
cmVjdG9yeSAvdG1wLi4uClsgICAxMi40MjUyMDddIHN5c3RlbWRbMV06IFN0YXJ0aW5nIENyZWF0
ZSBMaXN0IG9mIFN0YXRpYyBEZXZpY2UgTm9kZXMuLi4KICAgICAgICAgU3RhcnRpbmcgQ3JlYXRl
IExpc3Qgb2YgU3RhdGljIERldmljZSBOb2Rlcy4uLgpbICAgMTIuNDUyODIyXSBzeXN0ZW1kWzFd
OiBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgY29uZmlnZnMuLi4KICAgICAgICAgU3RhcnRp
bmcgTG9hZCBLZXJuZWwgTW9kdWxlIGNvbmZpZ2ZzLi4uClsgICAxMi40NzY3NTBdIHN5c3RlbWRb
MV06IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBkcm0uLi4KICAgICAgICAgU3RhcnRpbmcg
TG9hZCBLZXJuZWwgTW9kdWxlIGRybS4uLgpbICAgMTIuNTAwNzU2XSBzeXN0ZW1kWzFdOiBTdGFy
dGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgZnVzZS4uLgogICAgICAgICBTdGFydGluZyBMb2FkIEtl
cm5lbCBNb2R1bGUgZnVzZS4uLgpbICAgMTIuNTI0OTkxXSBzeXN0ZW1kWzFdOiBTdGFydGluZyBS
UEMgQmluZC4uLgogICAgICAgICBTdGFydGluZyBSUEMgQmluZC4uLgpbICAgMTIuNTQ3MzQwXSBz
eXN0ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gRmlsZSBTeXN0ZW0gQ2hlY2sg
b24gUm9vdCBEZXZpY2UgYmVpbmcgc2tpcHBlZC4KWyAgIDEyLjU1ODMxNV0gc3lzdGVtZFsxXTog
U3RhcnRpbmcgSm91cm5hbCBTZXJ2aWNlLi4uCiAgICAgICAgIFN0YXJ0aW5nIEpvdXJuYWwgU2Vy
dmljZS4uLgpbICAgMTIuNTc3NTgzXSBzeXN0ZW1kWzFdOiBTdGFydGluZyBMb2FkIEtlcm5lbCBN
b2R1bGVzLi4uCiAgICAgICAgIFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZXMuLi4KWyAgIDEy
LjU5NjY0N10gc3lzdGVtZFsxXTogU3RhcnRpbmcgUmVtb3VudCBSb290IGFuZCBLZXJuZWwgRmls
ZSBTeXN0ZW1zLi4uCiAgICAgICAgIFN0YXJ0aW5nIFJlbW91blsgICAxMi42MDQyNDddIEVYVDQt
ZnMgKHNkYTIpOiByZS1tb3VudGVkLiBPcHRzOiAobnVsbCkKdCBSb290IGFuZCBLZXJuZWwgRmls
ZSBTeXN0ZW1zLi4uClsgICAxMi42MjQ3MzJdIHN5c3RlbWRbMV06IFN0YXJ0aW5nIENvbGRwbHVn
IEFsbCB1ZGV2IERldmljZXMuLi4KICAgICAgICAgU3RhcnRpbmcgQ29sZHBsdWcgQWxsIHVkZXYg
RGV2aWNlcy4uLgpbICAgMTIuNjQ1MjkxXSBzeXN0ZW1kWzFdOiBTdGFydGVkIFJQQyBCaW5kLgpb
ICBPSyAgXSBTdGFydGVkIFJQQyBCaW5kLgpbICAgMTIuNjY3NzAwXSBzeXN0ZW1kWzFdOiBTdGFy
dGVkIEpvdXJuYWwgU2VydmljZS4KWyAgT0sgIF0gU3RhcnRlZCBKb3VybmFsIFNlcnZpY2UuClsg
IE9LICBdIE1vdW50ZWQgSHVnZSBQYWdlcyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91bnRlZCBQ
T1NJWCBNZXNzYWdlIFF1ZXVlIEZpbGUgU3lzdGVtLgpbICBPSyAgXSBNb3VudGVkIEtlcm5lbCBE
ZWJ1ZyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91bnRlZCBLZXJuZWwgVHJhY2UgRmlsZSBTeXN0
ZW0uClsgIE9LICBdIE1vdW50ZWQgVGVtcG9yYXJ5IERpcmVjdG9yeSAvdG1wLgpbICBPSyAgXSBG
aW5pc2hlZCBDcmVhdGUgTGlzdCBvZiBTdGF0aWMgRGV2aWNlIE5vZGVzLgpbICBPSyAgXSBGaW5p
c2hlZCBMb2FkIEtlcm5lbCBNb2R1bGUgY29uZmlnZnMuClsgIE9LICBdIEZpbmlzaGVkIExvYWQg
S2VybmVsIE1vZHVsZSBkcm0uClsgIE9LICBdIEZpbmlzaGVkIExvYWQgS2VybmVsIE1vZHVsZSBm
dXNlLgpbICBPSyAgXSBGaW5pc2hlZCBMb2FkIEtlcm5lbCBNb2R1bGVzLgpbICBPSyAgXSBGaW5p
c2hlZCBSZW1vdW50IFJvb3QgYW5kIEtlcm5lbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIE1vdW50
aW5nIEtlcm5lbCBDb25maWd1cmF0aW9uIEZpbGUgU3lzdGVtLi4uCiAgICAgICAgIFN0YXJ0aW5n
IEZsdXNoIEpvdXJuYWwgdG8gUGVyc2lzdGVudCBTdG9yYWdlLi4uClsgICAxMi45MjI2MzddIHN5
c3RlbWQtam91cm5hbGRbMzU5XTogUmVjZWl2ZWQgY2xpZW50IHJlcXVlc3QgdG8gZmx1c2ggcnVu
dGltZSBqb3VybmFsLgogICAgICAgICBTdGFydGluZyBBcHBseSBLZXJuZWwgVmFyaWFibGVzLi4u
CiAgICAgICAgIFN0YXJ0aW5nIENyZWF0ZSBTdGF0aWMgRGV2aWNlIE5vZGVzIGluIC9kZXYuLi4K
WyAgT0sgIF0gTW91bnRlZCBLZXJuZWwgQ29uZmlndXJhdGlvbiBGaWxlIFN5c3RlbS4KWyAgT0sg
IF0gRmluaXNoZWQgRmx1c2ggSm91cm5hbCB0byBQZXJzaXN0ZW50IFN0b3JhZ2UuClsgIE9LICBd
IEZpbmlzaGVkIENvbGRwbHVnIEFsbCB1ZGV2IERldmljZXMuClsgIE9LICBdIEZpbmlzaGVkIEFw
cGx5IEtlcm5lbCBWYXJpYWJsZXMuClsgIE9LICBdIEZpbmlzaGVkIENyZWF0ZSBTdGF0aWMgRGV2
aWNlIE5vZGVzIGluIC9kZXYuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFByZXBhcmF0aW9uIGZv
ciBMb2NhbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIE1vdW50aW5nIC92YXIvdm9sYXRpbGUuLi4K
ICAgICAgICAgU3RhcnRpbmcgV2FpdCBmb3IgdWRldiBUbyDigKZwbGV0ZSBEZXZpY2UgSW5pdGlh
bGl6YXRpb24uLi4KICAgICAgICAgU3RhcnRpbmcgUnVsZS1iYXNlZCBNYW5hZ2XigKZmb3IgRGV2
aWNlIEV2ZW50cyBhbmQgRmlsZXMuLi4KWyAgT0sgIF0gTW91bnRlZCAvdmFyL3ZvbGF0aWxlLgog
ICAgICAgICBTdGFydGluZyBMb2FkL1NhdmUgUmFuZG9tIFNlZWQuLi4KWyAgT0sgIF0gU3RhcnRl
ZCBSdWxlLWJhc2VkIE1hbmFnZXIgZm9yIERldmljZSBFdmVudHMgYW5kIEZpbGVzLgpbICBPSyAg
XSBMaXN0ZW5pbmcgb24gTG9hZC9TYXZlIFJGIOKApml0Y2ggU3RhdHVzIC9kZXYvcmZraWxsIFdh
dGNoLgpbICBPSyAgXSBGb3VuZCBkZXZpY2UgU2FuRGlza18zLjJHZW4xIG1zZG9zLgogICAgICAg
ICBNb3VudGluZyAvYm9vdC4uLgpbICBPSyAgXSBNb3VudGVkIC9ib290LgpbICBPSyAgXSBSZWFj
aGVkIHRhcmdldCBMb2NhbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIFN0YXJ0aW5nIENyZWF0ZSBW
b2xhdGlsZSBGaWxlcyBhbmQgRGlyZWN0b3JpZXMuLi4KWyAgT0sgIF0gRmluaXNoZWQgV2FpdCBm
b3IgdWRldiBUbyBDb21wbGV0ZSBEZXZpY2UgSW5pdGlhbGl6YXRpb24uClsgIE9LICBdIEZpbmlz
aGVkIENyZWF0ZSBWb2xhdGlsZSBGaWxlcyBhbmQgRGlyZWN0b3JpZXMuClsgIE9LICBdIFN0YXJ0
ZWQgSGFyZHdhcmUgUk5HIEVudHJvcHkgR2F0aGVyZXIgRGFlbW9uLgogICAgICAgICBTdGFydGlu
ZyBOZXR3b3JrIFRpbWUgU3luY2hyb25pemF0aW9uLi4uCiAgICAgICAgIFN0YXJ0aW5nIFJlY29y
ZCBTeXN0ZW0gQm9vdC9TaHV0ZG93biBpbiBVVE1QLi4uClsgIE9LICBdIEZpbmlzaGVkIFJlY29y
ZCBTeXN0ZW0gQm9vdC9TaHV0ZG93biBpbiBVVE1QLgpbICBPSyAgXSBTdGFydGVkIE5ldHdvcmsg
VGltZSBTeW5jaHJvbml6YXRpb24uClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFN5c3RlbSBJbml0
aWFsaXphdGlvbi4KWyAgT0sgIF0gU3RhcnRlZCBEYWlseSBDbGVhbnVwIG9mIFRlbXBvcmFyeSBE
aXJlY3Rvcmllcy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU3lzdGVtIFRpbWUgU2V0LgpbICBP
SyAgXSBSZWFjaGVkIHRhcmdldCBUaW1lciBVbml0cy4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIEF2
YWhpIG1ETlMvRE5TLVNEIFN0YWNrIEFjdGl2YXRpb24gU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5p
bmcgb24gRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVzIFNvY2tldC4KICAgICAgICAgU3RhcnRpbmcg
RG9ja2VyIFNvY2tldCBmb3IgdGhlIEFQSS4uLgogICAgICAgICBTdGFydGluZyBzc2hkLnNvY2tl
dC4uLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gRG9ja2VyIFNvY2tldCBmb3IgdGhlIEFQSS4KWyAg
T0sgIF0gTGlzdGVuaW5nIG9uIHNzaGQuc29ja2V0LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBT
b2NrZXQgVW5pdHMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEJhc2ljIFN5c3RlbS4KICAgICAg
ICAgU3RhcnRpbmcgQUNQSSBFdmVudCBEYWVtb24uLi4KWyAgT0sgIF0gU3RhcnRlZCBLZXJuZWwg
TG9nZ2luZyBTZXJ2aWNlLgpbICBPSyAgXSBTdGFydGVkIFN5c3RlbSBMb2dnaW5nIFNlcnZpY2Uu
ClsgIE9LICBdIFN0YXJ0ZWQgRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVzLgpbICBPSyAgXSBTdGFy
dGVkIEdldHR5IG9uIHR0eTEuCiAgICAgICAgIFN0YXJ0aW5nIElQdjYgUGFja2V0IEZpbHRlcmlu
ZyBGcmFtZXdvcmsuLi4KICAgICAgICAgU3RhcnRpbmcgSVB2NCBQYWNrZXQgRmlsdGVyaW5nIEZy
YW1ld29yay4uLgogICAgICAgICBTdGFydGluZyBUZWxlcGhvbnkgc2VydmljZS4uLgpbICBPSyAg
XSBTdGFydGVkIFNlcmlhbCBHZXR0eSBvbiB0dHlBTUEwLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdl
dCBMb2dpbiBQcm9tcHRzLgogICAgICAgICBTdGFydGluZyBVc2VyIExvZ2luIE1hbmFnZW1lbnQu
Li4KICAgICAgICAgU3RhcnRpbmcgT3BlblNTSCBLZXkgR2VuZXJhdGlvbi4uLgpbICBPSyAgXSBT
dGFydGVkIEFDUEkgRXZlbnQgRGFlbW9uLgpbICBPSyAgXSBGaW5pc2hlZCBJUHY2IFBhY2tldCBG
aWx0ZXJpbmcgRnJhbWV3b3JrLgpbICBPSyAgXSBGaW5pc2hlZCBJUHY0IFBhY2tldCBGaWx0ZXJp
bmcgRnJhbWV3b3JrLgpbICBPSyAgXSBGaW5pc2hlZCBPcGVuU1NIIEtleSBHZW5lcmF0aW9uLgpb
ICBPSyAgXSBSZWFjaGVkIHRhcmdldCBQcmVwYXJhdGlvbiBmb3IgTmV0d29yay4KICAgICAgICAg
U3RhcnRpbmcgTmV0d29yayBDb25maWd1cmF0aW9uLi4uClsgIE9LICBdIFN0YXJ0ZWQgVXNlciBM
b2dpbiBNYW5hZ2VtZW50LgpbICBPSyAgXSBTdGFydGVkIFRlbGVwaG9ueSBzZXJ2aWNlLgpbICBP
SyAgXSBTdGFydGVkIE5ldHdvcmsgQ29uZmlndXJhdGlvbi4KICAgICAgICAgU3RhcnRpbmcgV2Fp
dCBmb3IgTmV0d29yayB0byBiZSBDb25maWd1cmVkLi4uCiAgICAgICAgIFN0YXJ0aW5nIE5ldHdv
cmsgTmFtZSBSZXNvbHV0aW9uLi4uClsgIE9LICBdIEZpbmlzaGVkIExvYWQvU2F2ZSBSYW5kb20g
U2VlZC4KWyAgT0sgIF0gU3RhcnRlZCBOZXR3b3JrIE5hbWUgUmVzb2x1dGlvbi4KWyAgT0sgIF0g
UmVhY2hlZCB0YXJnZXQgTmV0d29yay4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgSG9zdCBhbmQg
TmV0d29yayBOYW1lIExvb2t1cHMuCiAgICAgICAgIFN0YXJ0aW5nIEF2YWhpIG1ETlMvRE5TLVNE
IFN0YWNrLi4uCiAgICAgICAgIFN0YXJ0aW5nIGNvbnRhaW5lcmQgY29udGFpbmVyIHJ1bnRpbWUu
Li4KWyAgT0sgIF0gU3RhcnRlZCBBdmFoaSBtRE5TL0ROUy1TRCBTdGFjay4KWyAgT0sgIF0gU3Rh
cnRlZCBjb250YWluZXJkIGNvbnRhaW5lciBydW50aW1lLgoKRVdBT0wgKEVkZ2UgV29ya2xvYWQg
QWJzdHJhY3Rpb24gYW5kIE9yY2hlc3RyYXRpb24gTGF5ZXIpIHVuc3RhYmxlIGNvbWhwYyB0dHlB
TUEwCgpjb21ocGMgbG9naW46IHJvb3QKcm9vdEBjb21ocGM6fiMgCg==

--_007_8C5118886183421EA4C7B271DAF46696armcom_--


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 18:17:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 18:17:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305013.519808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf41k-0005ct-6b; Thu, 14 Apr 2022 18:17:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305013.519808; Thu, 14 Apr 2022 18:17:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf41k-0005cm-3X; Thu, 14 Apr 2022 18:17:08 +0000
Received: by outflank-mailman (input) for mailman id 305013;
 Thu, 14 Apr 2022 18:17:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A50e=UY=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nf41i-0005cg-R0
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 18:17:06 +0000
Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 162bfc9c-bc1f-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 20:17:05 +0200 (CEST)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:42386)
 by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nf41g-000Tx9-Ja (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 14 Apr 2022 19:17:04 +0100
Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id CD77A1FA77;
 Thu, 14 Apr 2022 19:17:03 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 162bfc9c-bc1f-11ec-a405-831a346695d4
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <59eab45c-ea10-b7b6-d78d-5ea4b6213246@srcf.net>
Date: Thu, 14 Apr 2022 19:17:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <20220414162348.4808-1-andrew.cooper3@citrix.com>
 <YlhetDD/Xsnn2Vif@perard.uk.xensource.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] xen/build: Fix dependency for the MAP rule
In-Reply-To: <YlhetDD/Xsnn2Vif@perard.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 14/04/2022 18:49, Anthony PERARD wrote:
> On Thu, Apr 14, 2022 at 05:23:48PM +0100, Andrew Cooper wrote:
>> diff --git a/xen/Makefile b/xen/Makefile
>> index dd05672ff42d..02a274f56dc0 100644
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -599,7 +599,7 @@ cscope:
>>  	cscope -k -b -q
>>  
>>  .PHONY: _MAP
>> -_MAP:
>> +_MAP: $(TARGET)-syms
> That's not going to work well as make isn't going to know how to build
> $(TARGET)-syms.

Huh... It appears to work for me, but it's parallel build so who knows.

>  I guess you want to have $(TARGET) as prerequisite or
> add somewhere "$(TARGET)-syms: $(TARGET)".

That becomes cyclic with arch/*/Makefile which has:

$(TARGET): $(TARGET)-syms

The _install rule does make the implication that a dependency on
$(TARGET) builds $(TARGET)-syms so I guess that's good enough for _MAP too.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 18:28:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 18:28:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305023.519819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf4CZ-00077o-7C; Thu, 14 Apr 2022 18:28:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305023.519819; Thu, 14 Apr 2022 18:28:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf4CZ-00077h-49; Thu, 14 Apr 2022 18:28:19 +0000
Received: by outflank-mailman (input) for mailman id 305023;
 Thu, 14 Apr 2022 18:28:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DvB4=UY=rere.qmqm.pl=mirq-linux@srs-se1.protection.inumbo.net>)
 id 1nf4CW-00077b-QS
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 18:28:17 +0000
Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a6076b8e-bc20-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 20:28:15 +0200 (CEST)
Received: from remote.user (localhost [127.0.0.1])
 by rere.qmqm.pl (Postfix) with ESMTPSA id 4KfSCW69gWz4X;
 Thu, 14 Apr 2022 20:09:27 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6076b8e-bc20-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1;
	t=1649959782; bh=dFgq80ZhVmCzh8EszsBqFZFG3IVVYvOIEvlGI0Tq4bM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=M6meHZrwxDyeU2pD3ZmxqrGIOzrLBQXdCeqnbtwDtUq7d8NQ4FnteJZa5YFykZ6e+
	 X355Jw6iEC8xz5YVcTjA7IGBOIrhJJnO2gyLkF37nJHv3MgLZmJqPn2G0I5dDKnrg4
	 F4lkBza7OIX6WAPVjLgmrFFU3bI2WDyTsmq3yRNaX+0PJysAXwkYCJl0nPOwBhBgob
	 8slrsU1NRKlCWPtWM49DA1EczNJlhcfy1OC/YVXW0ILmdWA2Y4HIWMLSnQstsdxWpp
	 LxCcPEO0wf/x0jtEuJ4NrLpxwq+b047xHqknUEqc50McWrzi2dQf66NZb5+xCwTgL8
	 LJAaOowB2v/uQ==
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.5 at mail
Date: Thu, 14 Apr 2022 20:09:26 +0200
From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>, linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v7 00/20] Introduce power-off+restart call chain API
Message-ID: <YlhjVqStJJoL01v9@qmqm.qmqm.pl>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220411233832.391817-1-dmitry.osipenko@collabora.com>

On Tue, Apr 12, 2022 at 02:38:12AM +0300, Dmitry Osipenko wrote:
> Problem
> -------
> 
> SoC devices require power-off call chaining functionality from kernel.
> We have a widely used restart chaining provided by restart notifier API,
> but nothing for power-off.
> 
> Solution
> --------
> 
> Introduce new API that provides both restart and power-off call chains.
[...]

For the series:

Reviewed-by: Micha� Miros�aw <mirq-linux@rere.qmqm.pl>


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 18:36:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 18:36:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305028.519830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf4KD-0000Ak-0Y; Thu, 14 Apr 2022 18:36:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305028.519830; Thu, 14 Apr 2022 18:36:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf4KC-0000Ac-Tt; Thu, 14 Apr 2022 18:36:12 +0000
Received: by outflank-mailman (input) for mailman id 305028;
 Thu, 14 Apr 2022 18:36:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nf4KB-0000AW-AI
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 18:36:11 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba977b17-bc21-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 20:36:01 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba977b17-bc21-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649961361;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Di5+t/87BhZxgJtY2Uvlne/fduhLkHlu/xbxATrt2uA=;
  b=SFuyBtXT2dC4iogrYILcqXB7HIphyPzrXtz6ws4bU4zU8uY5JB9PWyad
   e4eUVrlcki8SSbtgAenOF+8ebkSe/wh/L0kuxXSWx+g0We74GX56qNMxM
   e62ewhLeqookYNwe5KbD5vjmlB0I1D4ZbAIhBQZcBBwlIceUkrmwc7OYZ
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69399701
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gb87g6PeZSpM++HvrR2gl8FynXyQoLVcMsEvi/4bfWQNrUojhGEDm
 mQcWTrTb//ZZmfxfdx/PIW280lVucKAmoNkQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl29Iw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z2
 Y5GlZLhZycQeY7Bs/1FcDMJIQREFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTK2PN
 pVBMFKDajzcTydzC1U1CKksp9mawVj6KWFlhkqK8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u10bTDwweNdef4SGY6X/qjejK9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc8sLGM00uS+t8+337i2AXksuHwxkUvVz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODEsogz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0vdB0xa5hYImS0C
 KM2he+3zMUCVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSnPHKGoNJJcAhiwLpSLcmelvG7v9WremJOcFzNwdeKqV/9U+SJR5hoq9o=
IronPort-HdrOrdr: A9a23:PYKRSK3qmF34E6oB7wBCuQqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoVj6faUskd2ZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOcOEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="scan'208";a="69399701"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH v2] xen/build: Fix dependency for the MAP rule
Date: Thu, 14 Apr 2022 19:35:48 +0100
Message-ID: <20220414183548.19611-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220414162348.4808-1-andrew.cooper3@citrix.com>
References: <20220414162348.4808-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>

v2:
 * Use $(TARGET) not $(TARGET)-syms
---
 xen/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/Makefile b/xen/Makefile
index dd05672ff42d..3a4e3bdd0f95 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -599,7 +599,7 @@ cscope:
 	cscope -k -b -q
 
 .PHONY: _MAP
-_MAP:
+_MAP: $(TARGET)
 	$(NM) -n $(TARGET)-syms | grep -v '\(compiled\)\|\(\.o$$\)\|\( [aUw] \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' > System.map
 
 %.o %.i %.s: %.c tools_fixdep FORCE
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 18:59:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 18:59:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305036.519841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf4gr-0002ck-JG; Thu, 14 Apr 2022 18:59:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305036.519841; Thu, 14 Apr 2022 18:59:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf4gr-0002cd-Fv; Thu, 14 Apr 2022 18:59:37 +0000
Received: by outflank-mailman (input) for mailman id 305036;
 Thu, 14 Apr 2022 18:59:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf4gp-0002cT-QU; Thu, 14 Apr 2022 18:59:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf4gp-0000eI-Ms; Thu, 14 Apr 2022 18:59:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf4gp-000162-7S; Thu, 14 Apr 2022 18:59:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf4gp-0007gj-71; Thu, 14 Apr 2022 18:59:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iOjSqNwjKjouEnjxrUhwVGWcBVu9lqIW1P4QkIiPvtA=; b=UsAGN3sQX8zJxinfkDuEEqmViB
	lqChap+cuT3bfO7sfWAhqbNQ84WfHhnE28IL5MMYBC7aSVY2MjJD0H9V6M2Ijhpr+hv+3C2ujr8zY
	I0l6tB8/NXKLwcyMJhxUEfqQpy/0EPI+VRm3tNpkxTh7HdHZX6KMypGfhU5l9AkRoGvc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169402-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169402: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 18:59:35 +0000

flight 169402 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169402/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  394 attempts
Testing same since   169397  2022-04-14 15:10:23 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5103 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:19:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:19:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305051.519918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50O-0006gE-CU; Thu, 14 Apr 2022 19:19:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305051.519918; Thu, 14 Apr 2022 19:19:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50O-0006f8-5l; Thu, 14 Apr 2022 19:19:48 +0000
Received: by outflank-mailman (input) for mailman id 305051;
 Thu, 14 Apr 2022 19:19:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf50M-00054x-G3
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:19:46 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d82992f9-bc27-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 21:19:45 +0200 (CEST)
Received: by mail-lf1-x136.google.com with SMTP id u7so10757064lfs.8
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 12:19:45 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a194943000000b0046b928d2795sm85001lfj.67.2022.04.14.12.19.44
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Apr 2022 12:19:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d82992f9-bc27-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=JLvcL2fLROn3t3atjcd/ETf/m7mMDU63S8SDHDmllis=;
        b=PHixjVnS4M4CDbB1CHxDVeo28b/aVzSp0mJdrnkLOhqhj+Q/2wwhqo/TFVejF1D2cn
         M+V0zaS78dJd9lsRuBeMiEdLy1jV96PMJyIQ6tdjGX+3REplXlVqvCJvz8NPjkgZDOPf
         0khIrkBNwrWYo3QJ78y6BdHbLNpK0mHknzDWftCsqrE3xGyfA0HJKlIH7azM+WvVfhCo
         FHFrJ5hJRJK3Z7+BjHY/QTvixVEHiQzKm5aCRqRcCN/lRd8u9CYEkm4z/L9bHAfjRB0R
         fxISXS4qdfBlfdENdbDSL4T/6mCEkKAVOD6Rznx/DdO6NACB2S+j7tbT1uhlqWI/zvSd
         XiZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=JLvcL2fLROn3t3atjcd/ETf/m7mMDU63S8SDHDmllis=;
        b=NmroHfOKX7GO4XNqsPzENCJPicBKQx90nzYREaR2EgI0VLCirEea6c83Frat2N2VXj
         8FQmz9x/TMbdotJQKOmIQqAirCgeLxl+SgFg6GolQOb8g0my+yciaf1GcZvnpThNkw3G
         7GG0ixdcPaFmEF++hUpmwCJHvmHodEUSZP3Ua8rCdOdBk1i1vPScRjs1vgTKYCtu39/E
         kpIs6JBuDxdDnrhGx+Qn8L+7o76scyX5K97Jb9S8ARabQ8qLuh3cy1QCdVoEotTi28KD
         khbAb/9s5F6vyo73TOyMkiVr9kLwXXG7rnjRYXYCzH9HzYa0RpDXv3vTRSr+CMC8G+Nc
         RbsQ==
X-Gm-Message-State: AOAM530jZozdHCB7us1QOnymzZkRUqUZe3pm6rFRkW3bcNysnUsJwXI6
	U3NO/oWH4AEwUvqow+Rf54XJhP9w9/o=
X-Google-Smtp-Source: ABdhPJwMUxbIWiWwpSwBanMHzTQNTMGbJ4JbV9MkuLqT17euk/S+BBLtlBgciKyx0qEt1KTBdH2vcw==
X-Received: by 2002:a05:6512:1082:b0:44a:a6be:90b with SMTP id j2-20020a056512108200b0044aa6be090bmr2827259lfg.45.1649963985288;
        Thu, 14 Apr 2022 12:19:45 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Subject: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio devices in Xen guests
Date: Thu, 14 Apr 2022 22:19:33 +0300
Message-Id: <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Call xen_virtio_setup_dma_ops() only for Xen-aware virtio devices
in Xen guests if restricted access to the guest memory is enabled.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
 include/xen/arm/xen-ops.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
index 621da05..28b2ad3 100644
--- a/include/xen/arm/xen-ops.h
+++ b/include/xen/arm/xen-ops.h
@@ -2,12 +2,19 @@
 #ifndef _ASM_ARM_XEN_OPS_H
 #define _ASM_ARM_XEN_OPS_H
 
+#include <linux/virtio_config.h>
 #include <xen/swiotlb-xen.h>
+#include <xen/xen-ops.h>
 
 static inline void xen_setup_dma_ops(struct device *dev)
 {
 	if (xen_swiotlb_detect())
 		dev->dma_ops = &xen_swiotlb_dma_ops;
+
+#ifdef CONFIG_XEN_VIRTIO
+	if (arch_has_restricted_virtio_memory_access() && xen_is_virtio_device(dev))
+		xen_virtio_setup_dma_ops(dev);
+#endif
 }
 
 #endif /* _ASM_ARM_XEN_OPS_H */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:19:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:19:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305049.519891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50L-0005vc-Mf; Thu, 14 Apr 2022 19:19:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305049.519891; Thu, 14 Apr 2022 19:19:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50L-0005v5-G6; Thu, 14 Apr 2022 19:19:45 +0000
Received: by outflank-mailman (input) for mailman id 305049;
 Thu, 14 Apr 2022 19:19:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf50K-00054x-KR
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:19:44 +0000
Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com
 [2a00:1450:4864:20::230])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6d29c6f-bc27-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 21:19:43 +0200 (CEST)
Received: by mail-lj1-x230.google.com with SMTP id o16so7264762ljp.3
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 12:19:43 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a194943000000b0046b928d2795sm85001lfj.67.2022.04.14.12.19.41
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Apr 2022 12:19:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6d29c6f-bc27-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=HH0lNJhCKrn1KVzcgV/uI3rqOPkxUwMay92nkSrAjww=;
        b=CSmQsWmMPhKn65VWOLhlyWUk/5YwfpW6oHGmDgSr8oyIRtln1bgL/FxXCzwqOQ2scW
         Kul15jhG/xUMsrq9hwxgzV7VZ+jj3hupZRanvoSdnRr8nY+F8D9bVK1bhDZDRzNimT23
         LAh7fUHs+YKWYCqE86acY6uO/YWr6KZAKVBtZxwCRFor0ambo4hAmrApMjmGMTo04/Vx
         omjZqW9FpYwni3wQwXilVmnhhBiTL44fcofN4KwMa0r/naLAzWmPO9D0cVR9OT/QkH7A
         h4d5ucGnzxq/vZwtYADqFA6IbCHPqfZ2O1SM0pyYOBrcVF6qgnYeOnQS+OhyTtG8dwru
         XDgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=HH0lNJhCKrn1KVzcgV/uI3rqOPkxUwMay92nkSrAjww=;
        b=C45vKP/KXwWMnkBsnGoT9PkvB8ww3PfQgr0HsOvcUR8+2LI2TRnE/I2ZZtmSw3uBs4
         pzfpUGNjqW584lp93FohXlmcRBiIwSYZRXooztWmRGbNT6LEUT6r6lKJiaaxgHWbmOhX
         TZhxbf66R5j2i1Ok6L57UGLMjQi9xzX4cFdmVDBpP43fn9mi6UGj8hkOmjQNRX8aOuCP
         Hc1S7w6AYeQJ00YaGsfSjuWMXejW2nM0sKOvAHn1HO/FFWr4oIphFs7L5dEgBlTQf+2e
         pVt1V904IdslXAkRbKCrZBcBc8pqSIceJTWkqC7joxKN/ntrt/aY4ncjLdZuqHN2cTfm
         xaHw==
X-Gm-Message-State: AOAM532kWm62D2QwoAqF8ETnuLrkLgLn4WPPibAL5uM+gRlrMTu9aKMm
	5tEKWdcqQfY3o85r/APcaYMWeFWeHX0=
X-Google-Smtp-Source: ABdhPJyqaIJqLPokLPf5w1P1n+RXHoKfPPFHkJ8cRMG0ZDENL1jq4zsAVzAnYaGGBHo3X65+xfsMjQ==
X-Received: by 2002:a2e:9c2:0:b0:24a:c757:b9bb with SMTP id 185-20020a2e09c2000000b0024ac757b9bbmr2493120ljj.360.1649963982965;
        Thu, 14 Apr 2022 12:19:42 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>
Subject: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer
Date: Thu, 14 Apr 2022 22:19:31 +0300
Message-Id: <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

In the context of current patch do the following:
1. Update code to support virtio-mmio devices
2. Introduce struct xen_virtio_data and account passed virtio devices
   (using list) as we need to store some per-device data
3. Add multi-page support for xen_virtio_dma_map(unmap)_page callbacks
4. Harden code against malicious backend
5. Change to use alloc_pages_exact() instead of __get_free_pages()
6. Introduce locking scheme to protect mappings (I am not 100% sure
   whether per-device lock is really needed)
7. Handle virtio device's DMA mask
8. Retrieve the ID of backend domain from DT for virtio-mmio device
   instead of hardcoding it.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
 arch/arm/xen/enlighten.c |  11 +++
 drivers/xen/Kconfig      |   2 +-
 drivers/xen/xen-virtio.c | 200 ++++++++++++++++++++++++++++++++++++++++++-----
 include/xen/xen-ops.h    |   5 ++
 4 files changed, 196 insertions(+), 22 deletions(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index ec5b082..870d92f 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -409,6 +409,17 @@ int __init arch_xen_unpopulated_init(struct resource **res)
 }
 #endif
 
+#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+int arch_has_restricted_virtio_memory_access(void)
+{
+	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
+		return 1;
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
+#endif
+
 static void __init xen_dt_guest_init(void)
 {
 	struct device_node *xen_node;
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index fc61f7a..56afe6a 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -347,7 +347,7 @@ config XEN_VIRTIO
 
 config XEN_HVM_VIRTIO_GRANT
 	bool "Require virtio for fully virtualized guests to use grant mappings"
-	depends on XEN_VIRTIO && X86_64
+	depends on XEN_VIRTIO && (X86_64 || ARM || ARM64)
 	default y
 	help
 	  Require virtio for fully virtualized guests to use grant mappings.
diff --git a/drivers/xen/xen-virtio.c b/drivers/xen/xen-virtio.c
index cfd5eda..c5b2ec9 100644
--- a/drivers/xen/xen-virtio.c
+++ b/drivers/xen/xen-virtio.c
@@ -7,12 +7,26 @@
 
 #include <linux/module.h>
 #include <linux/dma-map-ops.h>
+#include <linux/of.h>
 #include <linux/pci.h>
 #include <linux/pfn.h>
 #include <linux/virtio_config.h>
 #include <xen/xen.h>
 #include <xen/grant_table.h>
 
+struct xen_virtio_data {
+	/* The ID of backend domain */
+	domid_t dev_domid;
+	struct device *dev;
+	struct list_head list;
+	spinlock_t lock;
+	/* Is device behaving sane? */
+	bool broken;
+};
+
+static LIST_HEAD(xen_virtio_devices);
+static DEFINE_SPINLOCK(xen_virtio_lock);
+
 #define XEN_GRANT_ADDR_OFF	0x8000000000000000ULL
 
 static inline dma_addr_t grant_to_dma(grant_ref_t grant)
@@ -25,6 +39,25 @@ static inline grant_ref_t dma_to_grant(dma_addr_t dma)
 	return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT);
 }
 
+static struct xen_virtio_data *find_xen_virtio_data(struct device *dev)
+{
+	struct xen_virtio_data *data = NULL;
+	bool found = false;
+
+	spin_lock(&xen_virtio_lock);
+
+	list_for_each_entry( data, &xen_virtio_devices, list) {
+		if (data->dev == dev) {
+			found = true;
+			break;
+		}
+	}
+
+	spin_unlock(&xen_virtio_lock);
+
+	return found ? data : NULL;
+}
+
 /*
  * DMA ops for Xen virtio frontends.
  *
@@ -43,48 +76,78 @@ static void *xen_virtio_dma_alloc(struct device *dev, size_t size,
 				  dma_addr_t *dma_handle, gfp_t gfp,
 				  unsigned long attrs)
 {
-	unsigned int n_pages = PFN_UP(size);
-	unsigned int i;
+	struct xen_virtio_data *data;
+	unsigned int i, n_pages = PFN_UP(size);
 	unsigned long pfn;
 	grant_ref_t grant;
-	void *ret;
+	void *ret = NULL;
 
-	ret = (void *)__get_free_pages(gfp, get_order(size));
-	if (!ret)
+	data = find_xen_virtio_data(dev);
+	if (!data)
 		return NULL;
 
+	spin_lock(&data->lock);
+
+	if (unlikely(data->broken))
+		goto out;
+
+	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
+	if (!ret)
+		goto out;
+
 	pfn = virt_to_pfn(ret);
 
 	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
-		free_pages((unsigned long)ret, get_order(size));
-		return NULL;
+		free_pages_exact(ret, n_pages * PAGE_SIZE);
+		ret = NULL;
+		goto out;
 	}
 
 	for (i = 0; i < n_pages; i++) {
-		gnttab_grant_foreign_access_ref(grant + i, 0,
+		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
 						pfn_to_gfn(pfn + i), 0);
 	}
 
 	*dma_handle = grant_to_dma(grant);
 
+out:
+	spin_unlock(&data->lock);
+
 	return ret;
 }
 
 static void xen_virtio_dma_free(struct device *dev, size_t size, void *vaddr,
 				dma_addr_t dma_handle, unsigned long attrs)
 {
-	unsigned int n_pages = PFN_UP(size);
-	unsigned int i;
+	struct xen_virtio_data *data;
+	unsigned int i, n_pages = PFN_UP(size);
 	grant_ref_t grant;
 
+	data = find_xen_virtio_data(dev);
+	if (!data)
+		return;
+
+	spin_lock(&data->lock);
+
+	if (unlikely(data->broken))
+		goto out;
+
 	grant = dma_to_grant(dma_handle);
 
-	for (i = 0; i < n_pages; i++)
-		gnttab_end_foreign_access_ref(grant + i);
+	for (i = 0; i < n_pages; i++) {
+		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
+			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
+			data->broken = true;
+			goto out;
+		}
+	}
 
 	gnttab_free_grant_reference_seq(grant, n_pages);
 
-	free_pages((unsigned long)vaddr, get_order(size));
+	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
+
+out:
+	spin_unlock(&data->lock);
 }
 
 static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_t size,
@@ -108,28 +171,71 @@ static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct page *page,
 					  enum dma_data_direction dir,
 					  unsigned long attrs)
 {
+	struct xen_virtio_data *data;
+	unsigned int i, n_pages = PFN_UP(size);
 	grant_ref_t grant;
+	dma_addr_t dma_handle = DMA_MAPPING_ERROR;
+
+	BUG_ON(dir == DMA_NONE);
+
+	data = find_xen_virtio_data(dev);
+	if (!data)
+		return DMA_MAPPING_ERROR;
+
+	spin_lock(&data->lock);
 
-	if (gnttab_alloc_grant_references(1, &grant))
-		return 0;
+	if (unlikely(data->broken))
+		goto out;
 
-	gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page),
-					dir == DMA_TO_DEVICE);
+	if (gnttab_alloc_grant_reference_seq(n_pages, &grant))
+		goto out;
 
-	return grant_to_dma(grant) + offset;
+	for (i = 0; i < n_pages; i++) {
+		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
+				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
+	}
+
+	dma_handle = grant_to_dma(grant) + offset;
+
+out:
+	spin_unlock(&data->lock);
+
+	return dma_handle;
 }
 
 static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
 				      size_t size, enum dma_data_direction dir,
 				      unsigned long attrs)
 {
+	struct xen_virtio_data *data;
+	unsigned int i, n_pages = PFN_UP(size);
 	grant_ref_t grant;
 
+	BUG_ON(dir == DMA_NONE);
+
+	data = find_xen_virtio_data(dev);
+	if (!data)
+		return;
+
+	spin_lock(&data->lock);
+
+	if (unlikely(data->broken))
+		goto out;
+
 	grant = dma_to_grant(dma_handle);
 
-	gnttab_end_foreign_access_ref(grant);
+	for (i = 0; i < n_pages; i++) {
+		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
+			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
+			data->broken = true;
+			goto out;
+		}
+	}
+
+	gnttab_free_grant_reference_seq(grant, n_pages);
 
-	gnttab_free_grant_reference(grant);
+out:
+	spin_unlock(&data->lock);
 }
 
 static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist *sg,
@@ -149,7 +255,7 @@ static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
 
 static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask)
 {
-	return 1;
+	return mask == DMA_BIT_MASK(64);
 }
 
 static const struct dma_map_ops xen_virtio_dma_ops = {
@@ -166,9 +272,61 @@ static const struct dma_map_ops xen_virtio_dma_ops = {
 	.dma_supported = xen_virtio_dma_dma_supported,
 };
 
+bool xen_is_virtio_device(struct device *dev)
+{
+	/* XXX Handle only DT devices for now */
+	if (!dev->of_node)
+		return false;
+
+	if (!of_device_is_compatible(dev->of_node, "virtio,mmio"))
+		return false;
+
+	return of_property_read_bool(dev->of_node, "xen,dev-domid");
+}
+EXPORT_SYMBOL_GPL(xen_is_virtio_device);
+
 void xen_virtio_setup_dma_ops(struct device *dev)
 {
+	struct xen_virtio_data *data;
+	uint32_t dev_domid;
+
+	data = find_xen_virtio_data(dev);
+	if (data) {
+		dev_err(dev, "xen_virtio data is already created\n");
+		return;
+	}
+
+	if (dev_is_pci(dev)) {
+		/* XXX Leave it hard wired to dom0 for now */
+		dev_domid = 0;
+	} else if (dev->of_node) {
+		if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) {
+			dev_err(dev, "xen,dev-domid property is not present\n");
+			goto err;
+		}
+	} else
+		/* The ACPI case is not supported */
+		goto err;
+
+	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
+	if (!data) {
+		dev_err(dev, "Сannot allocate xen_virtio data\n");
+		goto err;
+	}
+	data->dev_domid = dev_domid;
+	data->dev = dev;
+	spin_lock_init(&data->lock);
+
+	spin_lock(&xen_virtio_lock);
+	list_add(&data->list, &xen_virtio_devices);
+	spin_unlock(&xen_virtio_lock);
+
 	dev->dma_ops = &xen_virtio_dma_ops;
+
+	return;
+
+err:
+	dev_err(dev, "Сannot set up xen_virtio DMA ops, retain platform DMA ops\n");
 }
 EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops);
 
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index ae3c1bc..fdbcb99 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { }
 
 #ifdef CONFIG_XEN_VIRTIO
 void xen_virtio_setup_dma_ops(struct device *dev);
+bool xen_is_virtio_device(struct device *dev);
 #else
 static inline void xen_virtio_setup_dma_ops(struct device *dev)
 {
 }
+static inline bool xen_is_virtio_device(struct device *dev)
+{
+	return false;
+}
 #endif /* CONFIG_XEN_VIRTIO */
 
 #endif /* INCLUDE_XEN_OPS_H */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:19:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:19:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305047.519874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50J-0005aW-UM; Thu, 14 Apr 2022 19:19:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305047.519874; Thu, 14 Apr 2022 19:19:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50J-0005aP-RK; Thu, 14 Apr 2022 19:19:43 +0000
Received: by outflank-mailman (input) for mailman id 305047;
 Thu, 14 Apr 2022 19:19:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf50I-00054x-GV
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:19:42 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d5956c64-bc27-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 21:19:41 +0200 (CEST)
Received: by mail-lf1-x133.google.com with SMTP id b21so10776889lfb.5
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 12:19:41 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a194943000000b0046b928d2795sm85001lfj.67.2022.04.14.12.19.39
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Apr 2022 12:19:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5956c64-bc27-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=nXDE5bXmpYq/ePRB6NaY2RzAfrYEzRtO2mFypRZiPSg=;
        b=cA7nvITvdvZ/NWohiTI9yXw9Bsz1InbMamu75ldsnVN7x3qmhXLAyGvrPtVVlEgWuL
         NZ3WkBCQbtGZmGnVfZF2FI0zW3lSrAaEiYaf3NmzuajCnK038Drh9zTO0b7nSusi4CnL
         e1qZbPPKBKFxxe5DFB0XvQaj7wjjs2o9wvNtVpddBoGigZZMnKaYx5+oaeq3JQzLKw0i
         dmCDvFfxnorQ4mEMq5dbKyVJvdzCrQPa7QBoW2pSIpyUfluDWhcpbCpCEOrh3ERVZ6RQ
         JHqdT6uWfB4Vl0qS8RUuuhOok2RLcjf5S86uHftuQb/SnSZkGxKzOpqLEaWYzD0UAaz4
         EOBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=nXDE5bXmpYq/ePRB6NaY2RzAfrYEzRtO2mFypRZiPSg=;
        b=sgOKNksVCeJ0vfPhlYl3dls2dYRr4Tt8ncOo8JIONmfhB8m5YmQ5959AFhYn3dkziT
         cGRiyel9Q3vaqMV5PInb6rZyUlgAFAar09gKHcMKuuDsMRuORJjB+2bGKPxVfp6DDUt4
         cl/ewW0DIQ19aKPdfH4hK4Z8SYeMQzreGIZsVJEr99D5VLMIRaJjD44rj4d1Eblp1UIc
         j6CBxWGC82i/ldyYmQPfq2RSBDDbjLqAJWOKuh7neUinw87Xw7+jCWWxIM79Q/IGUU7y
         BzH8Kf3VDC4oriUb09D/MiRXT3xLPa60b4TiL3J64lzCcj0XxxYMzJucK1kQOXbirNqa
         bZ3w==
X-Gm-Message-State: AOAM532CjZ7IuUbvQWNvrDiAAkYsty+btwwKWSay1qxOY0/V+uAhQHoC
	eZqmDQ6Sh3esp8gzuRtTszhCQOWl7yU=
X-Google-Smtp-Source: ABdhPJzJhDvPs8vZGIIBknd5EoVx+RBEPyUKlr3iat2rqmV3Cugsf4QEmPHWFroNg//S6JCMgOBeAA==
X-Received: by 2002:a05:6512:b18:b0:44a:9a1f:dcf6 with SMTP id w24-20020a0565120b1800b0044a9a1fdcf6mr2838218lfu.4.1649963980695;
        Thu, 14 Apr 2022 12:19:40 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: [RFC PATCH 2/6] virtio: add option to restrict memory access under Xen
Date: Thu, 14 Apr 2022 22:19:29 +0300
Message-Id: <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>

From: Juergen Gross <jgross@suse.com>

In order to support virtio in Xen guests add a config option enabling
the user to specify whether in all Xen guests virtio should be able to
access memory via Xen grant mappings only on the host side.

This applies to fully virtualized guests only, as for paravirtualized
guests this is mandatory.

This requires to switch arch_has_restricted_virtio_memory_access()
from a pure stub to a real function on x86 systems (Arm systems are
not covered by now).

Add the needed functionality by providing a special set of DMA ops
handling the needed grant operations for the I/O pages.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/mm/init.c        |  15 ++++
 arch/x86/mm/mem_encrypt.c |   5 --
 arch/x86/xen/Kconfig      |   9 +++
 drivers/xen/Kconfig       |  20 ++++++
 drivers/xen/Makefile      |   1 +
 drivers/xen/xen-virtio.c  | 177 ++++++++++++++++++++++++++++++++++++++++++++++
 include/xen/xen-ops.h     |   8 +++
 7 files changed, 230 insertions(+), 5 deletions(-)
 create mode 100644 drivers/xen/xen-virtio.c

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index d8cfce2..526a3b2 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -8,6 +8,8 @@
 #include <linux/kmemleak.h>
 #include <linux/sched/task.h>
 
+#include <xen/xen.h>
+
 #include <asm/set_memory.h>
 #include <asm/e820/api.h>
 #include <asm/init.h>
@@ -1065,3 +1067,16 @@ unsigned long max_swapfile_size(void)
 	return pages;
 }
 #endif
+
+#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+int arch_has_restricted_virtio_memory_access(void)
+{
+	if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
+		return 1;
+	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
+		return 1;
+
+	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
+}
+EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
+#endif
diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
index 50d2099..dda020f 100644
--- a/arch/x86/mm/mem_encrypt.c
+++ b/arch/x86/mm/mem_encrypt.c
@@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
 	print_mem_encrypt_feature_info();
 }
 
-int arch_has_restricted_virtio_memory_access(void)
-{
-	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
-}
-EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
index 85246dd..dffdffd 100644
--- a/arch/x86/xen/Kconfig
+++ b/arch/x86/xen/Kconfig
@@ -92,3 +92,12 @@ config XEN_DOM0
 	select X86_X2APIC if XEN_PVH && X86_64
 	help
 	  Support running as a Xen Dom0 guest.
+
+config XEN_PV_VIRTIO
+	bool "Xen virtio support for PV guests"
+	depends on XEN_VIRTIO && XEN_PV
+	default y
+	help
+	  Support virtio for running as a paravirtualized guest. This will
+	  need support on the backend side (qemu or kernel, depending on the
+	  virtio device types used).
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 120d32f..fc61f7a 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -335,4 +335,24 @@ config XEN_UNPOPULATED_ALLOC
 	  having to balloon out RAM regions in order to obtain physical memory
 	  space to create such mappings.
 
+config XEN_VIRTIO
+	bool "Xen virtio support"
+	default n
+	depends on VIRTIO && DMA_OPS
+	select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+	help
+	  Enable virtio support for running as Xen guest. Depending on the
+	  guest type this will require special support on the backend side
+	  (qemu or kernel, depending on the virtio device types used).
+
+config XEN_HVM_VIRTIO_GRANT
+	bool "Require virtio for fully virtualized guests to use grant mappings"
+	depends on XEN_VIRTIO && X86_64
+	default y
+	help
+	  Require virtio for fully virtualized guests to use grant mappings.
+	  This will avoid the need to give the backend the right to map all
+	  of the guest memory. This will need support on the backend side
+	  (qemu or kernel, depending on the virtio device types used).
+
 endmenu
diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
index 5aae66e..767009c 100644
--- a/drivers/xen/Makefile
+++ b/drivers/xen/Makefile
@@ -39,3 +39,4 @@ xen-gntalloc-y				:= gntalloc.o
 xen-privcmd-y				:= privcmd.o privcmd-buf.o
 obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)	+= xen-front-pgdir-shbuf.o
 obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)	+= unpopulated-alloc.o
+obj-$(CONFIG_XEN_VIRTIO)		+= xen-virtio.o
diff --git a/drivers/xen/xen-virtio.c b/drivers/xen/xen-virtio.c
new file mode 100644
index 00000000..cfd5eda
--- /dev/null
+++ b/drivers/xen/xen-virtio.c
@@ -0,0 +1,177 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/******************************************************************************
+ * Xen virtio driver - enables using virtio devices in Xen guests.
+ *
+ * Copyright (c) 2021, Juergen Gross <jgross@suse.com>
+ */
+
+#include <linux/module.h>
+#include <linux/dma-map-ops.h>
+#include <linux/pci.h>
+#include <linux/pfn.h>
+#include <linux/virtio_config.h>
+#include <xen/xen.h>
+#include <xen/grant_table.h>
+
+#define XEN_GRANT_ADDR_OFF	0x8000000000000000ULL
+
+static inline dma_addr_t grant_to_dma(grant_ref_t grant)
+{
+	return XEN_GRANT_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
+}
+
+static inline grant_ref_t dma_to_grant(dma_addr_t dma)
+{
+	return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT);
+}
+
+/*
+ * DMA ops for Xen virtio frontends.
+ *
+ * Used to act as a kind of software IOMMU for Xen guests by using grants as
+ * DMA addresses.
+ * Such a DMA address is formed by using the grant reference as a frame
+ * number and setting the highest address bit (this bit is for the backend
+ * to be able to distinguish it from e.g. a mmio address).
+ *
+ * Note that for now we hard wire dom0 to be the backend domain. In order to
+ * support any domain as backend we'd need to add a way to communicate the
+ * domid of this backend, e.g. via Xenstore or via the PCI-device's config
+ * space.
+ */
+static void *xen_virtio_dma_alloc(struct device *dev, size_t size,
+				  dma_addr_t *dma_handle, gfp_t gfp,
+				  unsigned long attrs)
+{
+	unsigned int n_pages = PFN_UP(size);
+	unsigned int i;
+	unsigned long pfn;
+	grant_ref_t grant;
+	void *ret;
+
+	ret = (void *)__get_free_pages(gfp, get_order(size));
+	if (!ret)
+		return NULL;
+
+	pfn = virt_to_pfn(ret);
+
+	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
+		free_pages((unsigned long)ret, get_order(size));
+		return NULL;
+	}
+
+	for (i = 0; i < n_pages; i++) {
+		gnttab_grant_foreign_access_ref(grant + i, 0,
+						pfn_to_gfn(pfn + i), 0);
+	}
+
+	*dma_handle = grant_to_dma(grant);
+
+	return ret;
+}
+
+static void xen_virtio_dma_free(struct device *dev, size_t size, void *vaddr,
+				dma_addr_t dma_handle, unsigned long attrs)
+{
+	unsigned int n_pages = PFN_UP(size);
+	unsigned int i;
+	grant_ref_t grant;
+
+	grant = dma_to_grant(dma_handle);
+
+	for (i = 0; i < n_pages; i++)
+		gnttab_end_foreign_access_ref(grant + i);
+
+	gnttab_free_grant_reference_seq(grant, n_pages);
+
+	free_pages((unsigned long)vaddr, get_order(size));
+}
+
+static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_t size,
+					       dma_addr_t *dma_handle,
+					       enum dma_data_direction dir,
+					       gfp_t gfp)
+{
+	WARN_ONCE(1, "xen_virtio_dma_alloc_pages size %ld\n", size);
+	return NULL;
+}
+
+static void xen_virtio_dma_free_pages(struct device *dev, size_t size,
+				      struct page *vaddr, dma_addr_t dma_handle,
+				      enum dma_data_direction dir)
+{
+	WARN_ONCE(1, "xen_virtio_dma_free_pages size %ld\n", size);
+}
+
+static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct page *page,
+					  unsigned long offset, size_t size,
+					  enum dma_data_direction dir,
+					  unsigned long attrs)
+{
+	grant_ref_t grant;
+
+	if (gnttab_alloc_grant_references(1, &grant))
+		return 0;
+
+	gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page),
+					dir == DMA_TO_DEVICE);
+
+	return grant_to_dma(grant) + offset;
+}
+
+static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
+				      size_t size, enum dma_data_direction dir,
+				      unsigned long attrs)
+{
+	grant_ref_t grant;
+
+	grant = dma_to_grant(dma_handle);
+
+	gnttab_end_foreign_access_ref(grant);
+
+	gnttab_free_grant_reference(grant);
+}
+
+static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist *sg,
+				 int nents, enum dma_data_direction dir,
+				 unsigned long attrs)
+{
+	WARN_ONCE(1, "xen_virtio_dma_map_sg nents %d\n", nents);
+	return -EINVAL;
+}
+
+static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
+				    int nents, enum dma_data_direction dir,
+				    unsigned long attrs)
+{
+	WARN_ONCE(1, "xen_virtio_dma_unmap_sg nents %d\n", nents);
+}
+
+static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask)
+{
+	return 1;
+}
+
+static const struct dma_map_ops xen_virtio_dma_ops = {
+	.alloc = xen_virtio_dma_alloc,
+	.free = xen_virtio_dma_free,
+	.alloc_pages = xen_virtio_dma_alloc_pages,
+	.free_pages = xen_virtio_dma_free_pages,
+	.mmap = dma_common_mmap,
+	.get_sgtable = dma_common_get_sgtable,
+	.map_page = xen_virtio_dma_map_page,
+	.unmap_page = xen_virtio_dma_unmap_page,
+	.map_sg = xen_virtio_dma_map_sg,
+	.unmap_sg = xen_virtio_dma_unmap_sg,
+	.dma_supported = xen_virtio_dma_dma_supported,
+};
+
+void xen_virtio_setup_dma_ops(struct device *dev)
+{
+	dev->dma_ops = &xen_virtio_dma_ops;
+}
+EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops);
+
+MODULE_DESCRIPTION("Xen virtio support driver");
+MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
+MODULE_LICENSE("GPL");
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index a3584a3..ae3c1bc 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { }
 
 #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
 
+#ifdef CONFIG_XEN_VIRTIO
+void xen_virtio_setup_dma_ops(struct device *dev);
+#else
+static inline void xen_virtio_setup_dma_ops(struct device *dev)
+{
+}
+#endif /* CONFIG_XEN_VIRTIO */
+
 #endif /* INCLUDE_XEN_OPS_H */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:19:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:19:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305046.519857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50I-0005Cn-Lj; Thu, 14 Apr 2022 19:19:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305046.519857; Thu, 14 Apr 2022 19:19:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50I-00059z-I8; Thu, 14 Apr 2022 19:19:42 +0000
Received: by outflank-mailman (input) for mailman id 305046;
 Thu, 14 Apr 2022 19:19:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf50H-00054x-1D
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:19:41 +0000
Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com
 [2a00:1450:4864:20::22d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d4a12a15-bc27-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 21:19:40 +0200 (CEST)
Received: by mail-lj1-x22d.google.com with SMTP id m8so7251849ljc.7
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 12:19:39 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a194943000000b0046b928d2795sm85001lfj.67.2022.04.14.12.19.38
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Apr 2022 12:19:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4a12a15-bc27-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=dof6CivR5ktaOrwRlo+Yx4ESbsQ7cxmBJatNzZcwa2k=;
        b=fxQPwiBYbg+xlj/wY1p5MdYQ66sD8b5fLGqQMckaU3CMT8EL/wfvWZU4SIiD6U9ip6
         x0PnmD1xHmrsNFIVjQHsdnZPvUxHpmODdoG0gXRG1Z8rSW12jjdRfc1aIsVwhopbfwnB
         45qwr+ltaiaL4VURctt6I1DyO99ZcxTE6B5dyns0TnRE7PewjAtJfw6eXZ2h61MbtG5G
         gnoBsZ84YiucFs13V1ifHyFlwHANNo9kDZLqLovrihL3G4p4VvU/pBaprwk/UBUaHLF8
         Jet2oVaZ2CJOnjtS1rjynU5Y1dbnTih8Gq9+zPwZEHWY78hWw5dqkTkzEh7mHxP/iI+V
         giOA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=dof6CivR5ktaOrwRlo+Yx4ESbsQ7cxmBJatNzZcwa2k=;
        b=U8jycHLX6l4wXpbSnKJd5BQrjSIZqn9lCBq6eb+NZmHVnFhK2CEuRZTP6IcV0H8Hwh
         MWs+UmliMQSi7f5l/bLBowDlBvclILPIetoW+DPYBVBRJHM9h4lW85ZP9pgpYYlgxDzP
         vxS8Q6ca+bwXGYcjPa0Bn4khrpCm05ZzvoHFNXERFzz+zke4h0l2+tq4IWUMCr6WVhzg
         lL9WdOz32xg7mdDziZI+LSJTFdhOyJiGqjxyQAjpo+9LN7/hgRoVBOjh8EVfFw2kNFvN
         GxAJ+ONiV5m9/V9nHjeiQaOXq6yl4KKhO0UmQF09sN3dIFUKNAwQ9e3FqLr+SnpT33Eb
         JMZA==
X-Gm-Message-State: AOAM5335nD7WF+ckKq1VtE8C7U0oUpFweDNEDWNCxFOrkuBv/u2NyKEr
	8WAvF8Un01oOQlMLR5NTYDrGiUyA+sM=
X-Google-Smtp-Source: ABdhPJx+KdnmdSildpq+aXrS8xmx/k1yM6QEi9zPtQDYyy8myxHzG38Yu1RM9ZZJBp2dsAgRlV7UJQ==
X-Received: by 2002:a05:651c:512:b0:24d:9ee0:7f11 with SMTP id o18-20020a05651c051200b0024d9ee07f11mr1779012ljp.367.1649963979236;
        Thu, 14 Apr 2022 12:19:39 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: [RFC PATCH 1/6] xen/grants: support allocating consecutive grants
Date: Thu, 14 Apr 2022 22:19:28 +0300
Message-Id: <1649963973-22879-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>

From: Juergen Gross <jgross@suse.com>

For support of virtio via grant mappings in rare cases larger mappings
using consecutive grants are needed. Support those by adding a bitmap
of free grants.

As consecutive grants will be needed only in very rare cases (e.g. when
configuring a virtio device with a multi-page ring), optimize for the
normal case of non-consecutive allocations.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/grant-table.c | 238 +++++++++++++++++++++++++++++++++++++++-------
 include/xen/grant_table.h |   4 +
 2 files changed, 210 insertions(+), 32 deletions(-)

diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 8ccccac..1b458c0 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -33,6 +33,7 @@
 
 #define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt
 
+#include <linux/bitmap.h>
 #include <linux/memblock.h>
 #include <linux/sched.h>
 #include <linux/mm.h>
@@ -72,9 +73,32 @@
 
 static grant_ref_t **gnttab_list;
 static unsigned int nr_grant_frames;
+
+/*
+ * Handling of free grants:
+ *
+ * Free grants are in a simple list anchored in gnttab_free_head. They are
+ * linked by grant ref, the last element contains GNTTAB_LIST_END. The number
+ * of free entries is stored in gnttab_free_count.
+ * Additionally there is a bitmap of free entries anchored in
+ * gnttab_free_bitmap. This is being used for simplifying allocation of
+ * multiple consecutive grants, which is needed e.g. for support of virtio.
+ * gnttab_last_free is used to add free entries of new frames at the end of
+ * the free list.
+ * gnttab_free_tail_ptr specifies the variable which references the start
+ * of consecutive free grants ending with gnttab_last_free. This pointer is
+ * updated in a rather defensive way, in order to avoid performance hits in
+ * hot paths.
+ * All those variables are protected by gnttab_list_lock.
+ */
 static int gnttab_free_count;
-static grant_ref_t gnttab_free_head;
+static unsigned int gnttab_size;
+static grant_ref_t gnttab_free_head = GNTTAB_LIST_END;
+static grant_ref_t gnttab_last_free = GNTTAB_LIST_END;
+static grant_ref_t *gnttab_free_tail_ptr;
+static unsigned long *gnttab_free_bitmap;
 static DEFINE_SPINLOCK(gnttab_list_lock);
+
 struct grant_frames xen_auto_xlat_grant_frames;
 static unsigned int xen_gnttab_version;
 module_param_named(version, xen_gnttab_version, uint, 0);
@@ -170,16 +194,111 @@ static int get_free_entries(unsigned count)
 
 	ref = head = gnttab_free_head;
 	gnttab_free_count -= count;
-	while (count-- > 1)
-		head = gnttab_entry(head);
+	while (count--) {
+		bitmap_clear(gnttab_free_bitmap, head, 1);
+		if (gnttab_free_tail_ptr == __gnttab_entry(head))
+			gnttab_free_tail_ptr = &gnttab_free_head;
+		if (count)
+			head = gnttab_entry(head);
+	}
 	gnttab_free_head = gnttab_entry(head);
 	gnttab_entry(head) = GNTTAB_LIST_END;
 
+	if (!gnttab_free_count) {
+		gnttab_last_free = GNTTAB_LIST_END;
+		gnttab_free_tail_ptr = NULL;
+	}
+
 	spin_unlock_irqrestore(&gnttab_list_lock, flags);
 
 	return ref;
 }
 
+static int get_seq_entry_count(void)
+{
+	if (gnttab_last_free == GNTTAB_LIST_END || !gnttab_free_tail_ptr ||
+	    *gnttab_free_tail_ptr == GNTTAB_LIST_END)
+		return 0;
+
+	return gnttab_last_free - *gnttab_free_tail_ptr + 1;
+}
+
+/* Rebuilds the free grant list and tries to find count consecutive entries. */
+static int get_free_seq(unsigned int count)
+{
+	int ret = -ENOSPC;
+	unsigned int from, to;
+	grant_ref_t *last;
+
+	gnttab_free_tail_ptr = &gnttab_free_head;
+	last = &gnttab_free_head;
+
+	for (from = find_first_bit(gnttab_free_bitmap, gnttab_size);
+	     from < gnttab_size;
+	     from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + 1)) {
+		to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size,
+					from + 1);
+		if (ret < 0 && to - from >= count) {
+			ret = from;
+			bitmap_clear(gnttab_free_bitmap, ret, count);
+			from += count;
+			gnttab_free_count -= count;
+			if (from == to)
+				continue;
+		}
+
+		while (from < to) {
+			*last = from;
+			last = __gnttab_entry(from);
+			gnttab_last_free = from;
+			from++;
+		}
+		if (to < gnttab_size)
+			gnttab_free_tail_ptr = __gnttab_entry(to - 1);
+	}
+
+	*last = GNTTAB_LIST_END;
+	if (gnttab_last_free != gnttab_size - 1)
+		gnttab_free_tail_ptr = NULL;
+
+	return ret;
+}
+
+static int get_free_entries_seq(unsigned int count)
+{
+	unsigned long flags;
+	int ret = 0;
+
+	spin_lock_irqsave(&gnttab_list_lock, flags);
+
+	if (gnttab_free_count < count) {
+		ret = gnttab_expand(count - gnttab_free_count);
+		if (ret < 0)
+			goto out;
+	}
+
+	if (get_seq_entry_count() < count) {
+		ret = get_free_seq(count);
+		if (ret >= 0)
+			goto out;
+		ret = gnttab_expand(count - get_seq_entry_count());
+		if (ret < 0)
+			goto out;
+	}
+
+	ret = *gnttab_free_tail_ptr;
+	*gnttab_free_tail_ptr = gnttab_entry(ret + count - 1);
+	gnttab_free_count -= count;
+	if (!gnttab_free_count)
+		gnttab_free_tail_ptr = NULL;
+	bitmap_clear(gnttab_free_bitmap, ret, count);
+
+ out:
+	spin_unlock_irqrestore(&gnttab_list_lock, flags);
+
+	return ret;
+}
+
 static void do_free_callbacks(void)
 {
 	struct gnttab_free_callback *callback, *next;
@@ -206,17 +325,48 @@ static inline void check_free_callbacks(void)
 		do_free_callbacks();
 }
 
-static void put_free_entry(grant_ref_t ref)
+static void put_free_entry_locked(grant_ref_t ref)
 {
-	unsigned long flags;
-	spin_lock_irqsave(&gnttab_list_lock, flags);
 	gnttab_entry(ref) = gnttab_free_head;
 	gnttab_free_head = ref;
+	if (!gnttab_free_count)
+		gnttab_last_free = ref;
+	if (gnttab_free_tail_ptr == &gnttab_free_head)
+		gnttab_free_tail_ptr = __gnttab_entry(ref);
 	gnttab_free_count++;
+	bitmap_set(gnttab_free_bitmap, ref, 1);
+}
+
+static void put_free_entry(grant_ref_t ref)
+{
+	unsigned long flags;
+
+	spin_lock_irqsave(&gnttab_list_lock, flags);
+	put_free_entry_locked(ref);
 	check_free_callbacks();
 	spin_unlock_irqrestore(&gnttab_list_lock, flags);
 }
 
+static void gnttab_set_free(unsigned int start, unsigned int n)
+{
+	unsigned int i;
+
+	for (i = start; i < start + n - 1; i++)
+		gnttab_entry(i) = i + 1;
+
+	gnttab_entry(i) = GNTTAB_LIST_END;
+	if (!gnttab_free_count) {
+		gnttab_free_head = start;
+		gnttab_free_tail_ptr = &gnttab_free_head;
+	} else {
+		gnttab_entry(gnttab_last_free) = start;
+	}
+	gnttab_free_count += n;
+	gnttab_last_free = i;
+
+	bitmap_set(gnttab_free_bitmap, start, n);
+}
+
 /*
  * Following applies to gnttab_update_entry_v1 and gnttab_update_entry_v2.
  * Introducing a valid entry into the grant table:
@@ -448,23 +598,31 @@ void gnttab_free_grant_references(grant_ref_t head)
 {
 	grant_ref_t ref;
 	unsigned long flags;
-	int count = 1;
-	if (head == GNTTAB_LIST_END)
-		return;
+
 	spin_lock_irqsave(&gnttab_list_lock, flags);
-	ref = head;
-	while (gnttab_entry(ref) != GNTTAB_LIST_END) {
-		ref = gnttab_entry(ref);
-		count++;
+	while (head != GNTTAB_LIST_END) {
+		ref = gnttab_entry(head);
+		put_free_entry_locked(head);
+		head = ref;
 	}
-	gnttab_entry(ref) = gnttab_free_head;
-	gnttab_free_head = head;
-	gnttab_free_count += count;
 	check_free_callbacks();
 	spin_unlock_irqrestore(&gnttab_list_lock, flags);
 }
 EXPORT_SYMBOL_GPL(gnttab_free_grant_references);
 
+void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count)
+{
+	unsigned long flags;
+	unsigned int i;
+
+	spin_lock_irqsave(&gnttab_list_lock, flags);
+	for (i = count; i > 0; i--)
+		put_free_entry_locked(head + i - 1);
+	check_free_callbacks();
+	spin_unlock_irqrestore(&gnttab_list_lock, flags);
+}
+EXPORT_SYMBOL_GPL(gnttab_free_grant_reference_seq);
+
 int gnttab_alloc_grant_references(u16 count, grant_ref_t *head)
 {
 	int h = get_free_entries(count);
@@ -478,6 +636,24 @@ int gnttab_alloc_grant_references(u16 count, grant_ref_t *head)
 }
 EXPORT_SYMBOL_GPL(gnttab_alloc_grant_references);
 
+int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first)
+{
+	int h;
+
+	if (count == 1)
+		h = get_free_entries(1);
+	else
+		h = get_free_entries_seq(count);
+
+	if (h < 0)
+		return -ENOSPC;
+
+	*first = h;
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(gnttab_alloc_grant_reference_seq);
+
 int gnttab_empty_grant_references(const grant_ref_t *private_head)
 {
 	return (*private_head == GNTTAB_LIST_END);
@@ -570,16 +746,13 @@ static int grow_gnttab_list(unsigned int more_frames)
 			goto grow_nomem;
 	}
 
+	gnttab_set_free(gnttab_size, extra_entries);
 
-	for (i = grefs_per_frame * nr_grant_frames;
-	     i < grefs_per_frame * new_nr_grant_frames - 1; i++)
-		gnttab_entry(i) = i + 1;
-
-	gnttab_entry(i) = gnttab_free_head;
-	gnttab_free_head = grefs_per_frame * nr_grant_frames;
-	gnttab_free_count += extra_entries;
+	if (!gnttab_free_tail_ptr)
+		gnttab_free_tail_ptr = __gnttab_entry(gnttab_size);
 
 	nr_grant_frames = new_nr_grant_frames;
+	gnttab_size += extra_entries;
 
 	check_free_callbacks();
 
@@ -1424,7 +1597,6 @@ int gnttab_init(void)
 	int i;
 	unsigned long max_nr_grant_frames;
 	unsigned int max_nr_glist_frames, nr_glist_frames;
-	unsigned int nr_init_grefs;
 	int ret;
 
 	gnttab_request_version();
@@ -1452,6 +1624,13 @@ int gnttab_init(void)
 		}
 	}
 
+	i = gnttab_interface->grefs_per_grant_frame * max_nr_grant_frames;
+	gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL);
+	if (!gnttab_free_bitmap) {
+		ret = -ENOMEM;
+		goto ini_nomem;
+	}
+
 	ret = arch_gnttab_init(max_nr_grant_frames,
 			       nr_status_frames(max_nr_grant_frames));
 	if (ret < 0)
@@ -1462,15 +1641,9 @@ int gnttab_init(void)
 		goto ini_nomem;
 	}
 
-	nr_init_grefs = nr_grant_frames *
-			gnttab_interface->grefs_per_grant_frame;
-
-	for (i = NR_RESERVED_ENTRIES; i < nr_init_grefs - 1; i++)
-		gnttab_entry(i) = i + 1;
+	gnttab_size = nr_grant_frames * gnttab_interface->grefs_per_grant_frame;
 
-	gnttab_entry(nr_init_grefs - 1) = GNTTAB_LIST_END;
-	gnttab_free_count = nr_init_grefs - NR_RESERVED_ENTRIES;
-	gnttab_free_head  = NR_RESERVED_ENTRIES;
+	gnttab_set_free(NR_RESERVED_ENTRIES, gnttab_size - NR_RESERVED_ENTRIES);
 
 	printk("Grant table initialized\n");
 	return 0;
@@ -1479,6 +1652,7 @@ int gnttab_init(void)
 	for (i--; i >= 0; i--)
 		free_page((unsigned long)gnttab_list[i]);
 	kfree(gnttab_list);
+	bitmap_free(gnttab_free_bitmap);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(gnttab_init);
diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h
index dfd5bf3..d815e1d 100644
--- a/include/xen/grant_table.h
+++ b/include/xen/grant_table.h
@@ -129,10 +129,14 @@ int gnttab_try_end_foreign_access(grant_ref_t ref);
  */
 int gnttab_alloc_grant_references(u16 count, grant_ref_t *pprivate_head);
 
+int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first);
+
 void gnttab_free_grant_reference(grant_ref_t ref);
 
 void gnttab_free_grant_references(grant_ref_t head);
 
+void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count);
+
 int gnttab_empty_grant_references(const grant_ref_t *pprivate_head);
 
 int gnttab_claim_grant_reference(grant_ref_t *pprivate_head);
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:19:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:19:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305045.519852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50I-00055F-8x; Thu, 14 Apr 2022 19:19:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305045.519852; Thu, 14 Apr 2022 19:19:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50I-000558-5O; Thu, 14 Apr 2022 19:19:42 +0000
Received: by outflank-mailman (input) for mailman id 305045;
 Thu, 14 Apr 2022 19:19:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf50G-00054x-8T
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:19:40 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d419adcc-bc27-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 21:19:39 +0200 (CEST)
Received: by mail-lf1-x130.google.com with SMTP id p10so10721585lfa.12
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 12:19:39 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a194943000000b0046b928d2795sm85001lfj.67.2022.04.14.12.19.36
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Apr 2022 12:19:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d419adcc-bc27-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=hBeYUJyh8cohFIBXMw+rp2zvHseFstsvrmjjJq6v1RA=;
        b=OS9Zyyw11+ahcSbaFBwnet4m/+SqFvTSxBJAra7HuBWht0AJqsov+byDRY2fDcE7Cs
         ytQj6zRGrqwIncCbAZw9crMvkswQ0zpZovlwDav7PgeiWph9GDH1Vn+lFgWyfq4pf9Q6
         D2bG8OWhifqZbowaCdO0dbVut/XPPk2sn+J4gDQPfI0IRUkzB49h1qS2s77WM2wj6Hc0
         XiiWyRzeOYZiYXi7x7A/rRQlZHH+glMqunBBbrU6BwKqFdu1m5oH6E29FDom7ZKFAHyW
         2ozw4PRAgrtB8ITcoMnvHW1txGeX3p4mnMFmtLnTd+4XkolWYRvNXGTibUY+EzZSgMXW
         D3vw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=hBeYUJyh8cohFIBXMw+rp2zvHseFstsvrmjjJq6v1RA=;
        b=hAZmmcU5Owv+s0GbrbfllirN7dzhY7fl4g5me5r7uNjrBvBVv6ggtl4Gju2Es6eNeT
         BbA54HK0DUoRmjMNSXactDKPojFPZWssYXnTNoKUO1BYc6VCpTFV0BY/wSE0YmPrn3Bq
         uP/jnnwECzeXG5x7m6c+dMlH4HIc7TOEH5w30o8aCJc0emDYViIVuvSJ1SnD4PJtYD34
         MrfWjt06NGSbVvhanhnsEBudqc88DhQ5OR++4y4Sic85gvF9170+ghWamHFvZEejGhNp
         PdsdaP1xukKkDRle62QjmmZzh2PMN+MpxR4GWHxpcYy9WedUY2zAjc8WoTvxpfjco7nA
         +TDQ==
X-Gm-Message-State: AOAM533zINWnobCY7AB3LklX+m+KEJsGfPnX2mId1grteYswviyZJkSb
	o1VRjf0Uh6LvaHQRuYg3mkKSXR1XXoY=
X-Google-Smtp-Source: ABdhPJyF5XrQhJyJg+R3ILmVTNsDHntbRwzflHI2RtvXh6tjp4CUiSxKClbc5XPs/9iS6Kt3RoSWZQ==
X-Received: by 2002:ac2:4d18:0:b0:46b:c318:193b with SMTP id r24-20020ac24d18000000b0046bc318193bmr2602821lfi.293.1649963978137;
        Thu, 14 Apr 2022 12:19:38 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	virtualization@lists.linux-foundation.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>,
	Henry Wang <Henry.Wang@arm.com>,
	Kaly Xin <Kaly.Xin@arm.com>,
	Jiamei Xie <Jiamei.Xie@arm.com>,
	=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
Subject: [RFC PATCH 0/6] virtio: Solution to restrict memory access under Xen using xen-virtio DMA ops layer
Date: Thu, 14 Apr 2022 22:19:27 +0300
Message-Id: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

The purpose of this RFC patch series is to add support for restricting memory access under Xen using specific
grant table based DMA ops layer. Patch series is based on Juergen Gross’ initial work [1] which implies using
grant references instead of raw guest physical addresses (GPA) for the virtio communications (some kind of
the software IOMMU).

The high level idea is to create new Xen’s grant table based DMA ops layer for the guest Linux whose main
purpose is to provide a special 64-bit DMA address which is formed by using the grant reference (for a page
to be shared with the backend) with offset and setting the highest address bit (this is for the backend to
be able to distinguish grant ref based DMA address from normal GPA). For this to work we need the ability
to allocate contiguous (consecutive) grant references for multi-page allocations. And the backend then needs
to offer VIRTIO_F_ACCESS_PLATFORM and VIRTIO_F_VERSION_1 feature bits (it must support virtio-mmio modern
transport for 64-bit addresses in the virtqueue).

Xen's grant mapping mechanism is the secure and safe solution to share pages between domains which proven
to work and works for years (in the context of traditional Xen PV drivers for example). So far, the foreign
mapping is used for the virtio backend to map and access guest memory. With the foreign mapping, the backend
is able to map arbitrary pages from the guest memory (or even from Dom0 memory). And as the result, the malicious
backend which runs in a non-trusted domain can take advantage of this. Instead, with the grant mapping
the backend is only allowed to map pages which were explicitly granted by the guest before and nothing else. 
According to the discussions in various mainline threads this solution would likely be welcome because it
perfectly fits in the security model Xen provides. 

What is more, the grant table based solution requires zero changes to the Xen hypervisor itself at least
with virtio-mmio and DT (in comparison, for example, with "foreign mapping + virtio-iommu" solution which would
require the whole new complex emulator in hypervisor in addition to new functionality/hypercall to pass IOVA
from the virtio backend running elsewhere to the hypervisor and translate it to the GPA before mapping into
P2M or denying the foreign mapping request if no corresponding IOVA-GPA mapping present in the IOMMU page table
for that particular device). We only need to update toolstack to insert a new "xen,dev-domid" property to
the virtio-mmio device node when creating a guest device-tree (this is an indicator for the guest to use grants
and the ID of Xen domain where the corresponding backend resides, it is used as an argument to the grant mapping
APIs). It worth mentioning that toolstack patch is based on non  upstreamed yet “Virtio support for toolstack
on Arm” series which is on review now [2].

Please note the following:
- Patch series only covers Arm and virtio-mmio (device-tree) for now. To enable the restricted memory access
  feature on Arm the following options should be set:
  CONFIG_XEN_VIRTIO = y
  CONFIG_XEN_HVM_VIRTIO_GRANT = y
- Some callbacks in xen-virtio DMA ops layer (map_sg/unmap_sg, etc) are not implemented yet as they are not
  needed/used in the first prototype

Patch series is rebased on Linux 5.18-rc2 tag and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64)
with standalone userspace (non-Qemu) virtio-mmio based virtio-disk backend running in Driver domain and Linux
guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy'
use-cases work properly. I have also tested other use-cases such as assigning several virtio block devices
or a mix of virtio and Xen PV block devices to the guest. 

1. Xen changes located at (last patch):
https://github.com/otyshchenko1/xen/commits/libxl_virtio_next
2. Linux changes located at:
https://github.com/otyshchenko1/linux/commits/virtio_grant5
3. virtio-disk changes located at:
https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant

Any feedback/help would be highly appreciated.

[1] https://www.youtube.com/watch?v=IrlEdaIUDPk
[2] https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/

Juergen Gross (2):
  xen/grants: support allocating consecutive grants
  virtio: add option to restrict memory access under Xen

Oleksandr Tyshchenko (4):
  dt-bindings: xen: Add xen,dev-domid property description for
    xen-virtio layer
  virtio: Various updates to xen-virtio DMA ops layer
  arm/xen: Introduce xen_setup_dma_ops()
  arm/xen: Assign xen-virtio DMA ops for virtio devices in Xen guests

 .../devicetree/bindings/virtio/xen,dev-domid.yaml  |  39 +++
 arch/arm/include/asm/xen/xen-ops.h                 |   1 +
 arch/arm/mm/dma-mapping.c                          |   5 +-
 arch/arm/xen/enlighten.c                           |  11 +
 arch/arm64/include/asm/xen/xen-ops.h               |   1 +
 arch/arm64/mm/dma-mapping.c                        |   5 +-
 arch/x86/mm/init.c                                 |  15 +
 arch/x86/mm/mem_encrypt.c                          |   5 -
 arch/x86/xen/Kconfig                               |   9 +
 drivers/xen/Kconfig                                |  20 ++
 drivers/xen/Makefile                               |   1 +
 drivers/xen/grant-table.c                          | 238 +++++++++++++--
 drivers/xen/xen-virtio.c                           | 335 +++++++++++++++++++++
 include/xen/arm/xen-ops.h                          |  20 ++
 include/xen/grant_table.h                          |   4 +
 include/xen/xen-ops.h                              |  13 +
 16 files changed, 679 insertions(+), 43 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
 create mode 100644 arch/arm/include/asm/xen/xen-ops.h
 create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
 create mode 100644 drivers/xen/xen-virtio.c
 create mode 100644 include/xen/arm/xen-ops.h

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:19:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:19:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305050.519905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50N-0006L0-17; Thu, 14 Apr 2022 19:19:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305050.519905; Thu, 14 Apr 2022 19:19:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50M-0006J6-Q5; Thu, 14 Apr 2022 19:19:46 +0000
Received: by outflank-mailman (input) for mailman id 305050;
 Thu, 14 Apr 2022 19:19:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf50L-0005Nh-I8
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:19:45 +0000
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com
 [2a00:1450:4864:20::129])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d788765a-bc27-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 21:19:44 +0200 (CEST)
Received: by mail-lf1-x129.google.com with SMTP id b21so10777111lfb.5
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 12:19:44 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a194943000000b0046b928d2795sm85001lfj.67.2022.04.14.12.19.43
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Apr 2022 12:19:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d788765a-bc27-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=lMGcVfKV8sctWGleZvUOf73V/MSGq5S+Npr1qVNtBaA=;
        b=HouaAb9VHQFNGxR9MIu6VzU91fVp9m4H9MFuGHWemt2O82W51Jf7w0svknXQnp9eoL
         Goijg/CjOJm12gw7O79o4tOKKi3VWVpFlGcCExQrgrgWjTLybck87oaBE8839ZFvqsgt
         PHA9UIv4u9ZIJ0KRv79B8BNi7Ma48plv0i8Ikw6DPDjZOba9itZELQd6iL42ER4Do5KC
         KnGW1lDf5sUT5lSWC5BOctu4TM3VkGzNie7bvNS2Bn7x53eayd0Dgb1qqP6phAjj3tzd
         uRuUa2wtuEaXrTf/kpJoJpqL9whQiLU0m+UmApeEsmIl/mWjegT0468noSCexcMl91FI
         NpKQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=lMGcVfKV8sctWGleZvUOf73V/MSGq5S+Npr1qVNtBaA=;
        b=MLZV1woHGMPXjj97f21iis6hTFiZ4Sb+0Kp3cFo1vnj6cEWqpeujGqjL311nWBhNX2
         t/rRh8b2dxzKAqf85apkDW47KT4ahAuVuu9wNbm1YuyJpZVl4pmbWESeQ2cxjPyV8DFr
         2oCrqk0Qyo/6unaR39nGvzjttwU0fiWhBAiwc3QZvnluq6DboqYrw8U9MQfvLunPmi1U
         ioUCk8CP1IkDEV5h+EuaJK54SE8/BLJ0NKqiqAoYMoqte1fWRxsd0GWrs+kbNMkPMej2
         h8PvDkJgrUhDYRImSTUQWcroXBVBXMLVMuqGmORoARMLlL+MVz/fClLoMkfFLMSVYrUH
         Y3Ng==
X-Gm-Message-State: AOAM530zbh5ClJsjSXhwi+UeZ92gQFR0ayKC/Ndxu0/ADc+wOK8+28Pv
	gIE2FT39txPv/j6kzn1I7M2jzPrKubM=
X-Google-Smtp-Source: ABdhPJyqpKzQq/8peqyhT0SdO2Fz0WkprUG2NmtNhK+vB9NhUMwVEFgX8mPVozIXpha113okS20X4g==
X-Received: by 2002:a05:6512:3f97:b0:44a:f67d:7d8 with SMTP id x23-20020a0565123f9700b0044af67d07d8mr2755017lfa.81.1649963984241;
        Thu, 14 Apr 2022 12:19:44 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	David Hildenbrand <david@redhat.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Kees Cook <keescook@chromium.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Julien Grall <julien@xen.org>
Subject: [RFC PATCH 5/6] arm/xen: Introduce xen_setup_dma_ops()
Date: Thu, 14 Apr 2022 22:19:32 +0300
Message-Id: <1649963973-22879-6-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This patch introduces new helper and places it in new header.
The helper's purpose is to assign any Xen specific DMA ops in
a single place. For now, we deal with xen-swiotlb DMA ops only.
The subsequent patch will add xen-virtio DMA ops case.

Also re-use the xen_swiotlb_detect() check on Arm32.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
 arch/arm/include/asm/xen/xen-ops.h   |  1 +
 arch/arm/mm/dma-mapping.c            |  5 ++---
 arch/arm64/include/asm/xen/xen-ops.h |  1 +
 arch/arm64/mm/dma-mapping.c          |  5 ++---
 include/xen/arm/xen-ops.h            | 13 +++++++++++++
 5 files changed, 19 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/include/asm/xen/xen-ops.h
 create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
 create mode 100644 include/xen/arm/xen-ops.h

diff --git a/arch/arm/include/asm/xen/xen-ops.h b/arch/arm/include/asm/xen/xen-ops.h
new file mode 100644
index 00000000..8d2fa24
--- /dev/null
+++ b/arch/arm/include/asm/xen/xen-ops.h
@@ -0,0 +1 @@
+#include <xen/arm/xen-ops.h>
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 82ffac6..a1bf9dd 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -33,7 +33,7 @@
 #include <asm/dma-iommu.h>
 #include <asm/mach/map.h>
 #include <asm/system_info.h>
-#include <xen/swiotlb-xen.h>
+#include <asm/xen/xen-ops.h>
 
 #include "dma.h"
 #include "mm.h"
@@ -2288,8 +2288,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
 	set_dma_ops(dev, dma_ops);
 
 #ifdef CONFIG_XEN
-	if (xen_initial_domain())
-		dev->dma_ops = &xen_swiotlb_dma_ops;
+	xen_setup_dma_ops(dev);
 #endif
 	dev->archdata.dma_ops_setup = true;
 }
diff --git a/arch/arm64/include/asm/xen/xen-ops.h b/arch/arm64/include/asm/xen/xen-ops.h
new file mode 100644
index 00000000..8d2fa24
--- /dev/null
+++ b/arch/arm64/include/asm/xen/xen-ops.h
@@ -0,0 +1 @@
+#include <xen/arm/xen-ops.h>
diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
index 6719f9e..831e673 100644
--- a/arch/arm64/mm/dma-mapping.c
+++ b/arch/arm64/mm/dma-mapping.c
@@ -9,9 +9,9 @@
 #include <linux/dma-map-ops.h>
 #include <linux/dma-iommu.h>
 #include <xen/xen.h>
-#include <xen/swiotlb-xen.h>
 
 #include <asm/cacheflush.h>
+#include <asm/xen/xen-ops.h>
 
 void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
 		enum dma_data_direction dir)
@@ -53,7 +53,6 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
 		iommu_setup_dma_ops(dev, dma_base, dma_base + size - 1);
 
 #ifdef CONFIG_XEN
-	if (xen_swiotlb_detect())
-		dev->dma_ops = &xen_swiotlb_dma_ops;
+	xen_setup_dma_ops(dev);
 #endif
 }
diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
new file mode 100644
index 00000000..621da05
--- /dev/null
+++ b/include/xen/arm/xen-ops.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_ARM_XEN_OPS_H
+#define _ASM_ARM_XEN_OPS_H
+
+#include <xen/swiotlb-xen.h>
+
+static inline void xen_setup_dma_ops(struct device *dev)
+{
+	if (xen_swiotlb_detect())
+		dev->dma_ops = &xen_swiotlb_dma_ops;
+}
+
+#endif /* _ASM_ARM_XEN_OPS_H */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:19:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:19:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305048.519885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50L-0005qi-62; Thu, 14 Apr 2022 19:19:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305048.519885; Thu, 14 Apr 2022 19:19:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf50L-0005qZ-2k; Thu, 14 Apr 2022 19:19:45 +0000
Received: by outflank-mailman (input) for mailman id 305048;
 Thu, 14 Apr 2022 19:19:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf50J-0005Nh-TZ
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:19:44 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d6233aba-bc27-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 21:19:42 +0200 (CEST)
Received: by mail-lf1-x12c.google.com with SMTP id k5so10752364lfg.9
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 12:19:42 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a194943000000b0046b928d2795sm85001lfj.67.2022.04.14.12.19.40
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Apr 2022 12:19:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6233aba-bc27-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=R46jQ8Mh8wQzPdylSEViVF+ujde6F3v3VBI24iINPTM=;
        b=QRWLAqmejMzVP/VaSSlfrFYwEo3OK4Yf6F7LquH6LbczOkSkbq/vAsvvcBkQZ3ISuO
         wk/F7z7KZoaZjO6jJEtsC8Z8u0HmEeGUEZBJ+5uIIL8d4EZc/Xy5CV+958+05d7Oh+3w
         0MTx5F+/q1lMyyGoE/T8SwKtQsZ+ljloGYnRMXgZR3RSh42S3JxNeguRIyZ8pSqxFcSJ
         lbwOzjD3LaDkuMdE7Vsq66i//JMVvHCxYJln9faVJVA4/8+FWK/0SSS5ZAme/0sNPB8x
         GZApoZF4cbZLwHjguo+2oIvkWDrnYDqQpErg124vnNNbbDISEkGcSHd43FjTBLZC5Hys
         u53A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=R46jQ8Mh8wQzPdylSEViVF+ujde6F3v3VBI24iINPTM=;
        b=4meuLF+S9MkKvDqe43qsESqN0ZDAdkVh/zFlh/fZ+qUky8MXYmSJa3Za3beYLuBdBa
         J13zkytivl8kUaWkwQOV+8oPY8IxRXfNnpBJZ9lda0rp239knQXcrL2EY9M/2IB09Qdb
         hnsGOCzgBY6AVjoeFd33jcJpNC7InRQcbwQCm72ZsliKwZu6Le5d4fz7iqIkEtgD58Mp
         0t62GnmvNX0bkwpgMB0KPLpgVGoSI+0vUX0+P8zLYbDFuTLKmNy6N8YSA0XxvsDaWiyf
         b1UDYdOzKRAqS52sri4L2Z83g2oxd1OXlCCPtdGAqrdKwqaZRYgaEZwIlElpLZPIR5dN
         sRLA==
X-Gm-Message-State: AOAM533tWmRIG6r012KBsptJ6Zb7IgifwiAx5YO/QP9NYYm4/H8UelyR
	+l9vuQu+9tmQWHPzYK9t4USloLOTvg8=
X-Google-Smtp-Source: ABdhPJwDFkGrudp03NZzkhnvIn/IK69FMZdjURZkh3p/wuKd/xnIHAcuOjWitfBhsfM9796bR6Fn5A==
X-Received: by 2002:a05:6512:169a:b0:44a:fea7:50a5 with SMTP id bu26-20020a056512169a00b0044afea750a5mr2825082lfb.498.1649963981876;
        Thu, 14 Apr 2022 12:19:41 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Julien Grall <julien@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [RFC PATCH 3/6] dt-bindings: xen: Add xen,dev-domid property description for xen-virtio layer
Date: Thu, 14 Apr 2022 22:19:30 +0300
Message-Id: <1649963973-22879-4-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Introduce Xen specific binding for the virtio-mmio device to be used
by Xen virtio support driver in a subsequent commit.

This binding specifies the ID of Xen domain where the corresponding
device (backend) resides. This is needed for the option to restrict
memory access using Xen grant mappings to work.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
 .../devicetree/bindings/virtio/xen,dev-domid.yaml  | 39 ++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml

diff --git a/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
new file mode 100644
index 00000000..78be993
--- /dev/null
+++ b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/virtio/xen,dev-domid.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xen specific binding for the virtio device
+
+maintainers:
+  - Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
+
+select: true
+
+description:
+  This binding specifies the ID of Xen domain where the corresponding device
+  (backend) resides. This is needed for the option to restrict memory access
+  using Xen grant mappings to work.
+
+  Note that current and generic "iommus" bindings are mutually exclusive, since
+  the restricted memory access model on Xen behaves as a kind of software IOMMU.
+
+properties:
+  xen,dev-domid:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Should contain the ID of device's domain.
+
+additionalProperties: true
+
+examples:
+  - |
+    virtio_block@3000 {
+            compatible = "virtio,mmio";
+            reg = <0x3000 0x100>;
+            interrupts = <41>;
+
+            /* The device is located in Xen domain with ID 1 */
+            xen,dev-domid = <1>;
+    };
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:28:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:28:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305082.519929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf58T-0001ja-46; Thu, 14 Apr 2022 19:28:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305082.519929; Thu, 14 Apr 2022 19:28:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf58T-0001jT-0q; Thu, 14 Apr 2022 19:28:09 +0000
Received: by outflank-mailman (input) for mailman id 305082;
 Thu, 14 Apr 2022 19:28:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dNZz=UY=citrix.com=prvs=096427a9b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nf58R-0001jN-CG
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:28:07 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00acf739-bc29-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 21:28:04 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00acf739-bc29-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1649964484;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=y8zqh3+zgPXkgwMgdXb2YVMZEeAqe9RHrQMmSlDBnDA=;
  b=Rqd0oPKzRcwMOqpXWxe4JRW7mECOcHy6RgZWUAoi4UUzwO6A7THYjt+B
   rm51JP/5fY37O2CsMR5nXvliFM7cy/BiSXeK/DvpIB9trxOqI97rJU6El
   PKn1Y+Hjkxn+d1iwjrqBsiUn76AS/bkviqXCRsHZX5PAwRnvJv6Lqobud
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 69404497
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mzn/gKiueNCqzi0D7PZMKAnxX161chAKZh0ujC45NGQN5FlHY01je
 htvUG7SPK6Jamv1f95zYdzi80wE7ZaEn9dlHlA4r31gQXgb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1rR4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YRwMGqHxvPo/bz0GDwJefqQa/Pj5BHfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i
 88xN2szNEicMkIn1lE/FZkuu9qhj3DFfh5Wila4lbUe5FOD5VkkuFTqGIWMIYHbLSlPpW6Ho
 krW8mK/BQsVXPS94zeY9nOnhsfUgDj2HokVEdWQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI
 FBS/TAhxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9imW747Y3iKHJFQgECJiSJ8v6Mtxexklg
 wrhc8zSORRjt7icSHS4/7iSrC+vNSV9EVLudRPoXiNevYC9/dhbYgbnC486TfXr1oGd9STYm
 WjikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsK4owGWxFADpU
 J04dy62trFm4XalznLlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYKG+zO
 BaN5VgKufe/2UdGi4ctMupd7Oxwk8Dd+SnNDKiIPrKinLAsHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZKdA5RfClnX82uwyGVH8baSjdb9KgaI6a56ZsqepB/nrQTkeHN/
 3qnXVRfxka5jnrCQThmoFg5AF8zdf6TdU4GABE=
IronPort-HdrOrdr: A9a23:rzsGE6zE6pZ0qh/GOOtTKrPxoeskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9xYgBspTnuAtjnfZqxz+8X3WBzB8bvYOCFghrQEGgK1+KLqFeMek3DH4ZmpO
 NdmsNFebjN5C1B/KHHCX6DYrIdKbe8gcKVbM7lvgxQZDAvT5slwxZyCw6dHEEzbhJBH4AFGJ
 2V4dcCjya8eFwMB/7LSUUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8DlyxwgoeaTVS2r0vmF
 K13TARp5/T8s1T+CWslFM73K4m2ucJ/+EzRPBl0KAuW0/RY0iTFcFcsva5zUgISamUmSsXeZ
 /30lAd1o1Img/sljTcm2qS5yDwlDkp8HPs0lmenD/qptH4XiszD45biZteaQax0TtpgDhQ6t
 M844uijesfMfoAplWJ2/HYExVx0kakq3srluAey3RZTIsFcbdU6YgS5llcHpsMFD/zrNlPKp
 glMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wi0EY2MsclHEd849VcegO28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBQnBNWqDSG6XY53uExr22u/KCJxc3pDURHXJ9upHpH
 3saiIqiYdpQTOfNSSn5uw4zizw
X-IronPort-AV: E=Sophos;i="5.90,260,1643691600"; 
   d="scan'208";a="69404497"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ea+AF9XuZ1yb1133L90EeNB7GBHfP25r+V8dubaYFCmm/CoCnStW8wfBM3VaDqEkasZucuu+0RPMa66TFQ5uw/kS1FgxseGiXXFfhqPIWeSaNJmfs6TtZvbv/Hvz503LK8kDFvu5L/qeb+saV9peQtuqmgRookYHVijBZ9AkGsH979mobyKTe/i9Ssjr0e4BcgPSsemfOqYxA0ff2j/K4W8nEY1acaeBCE/EFbq/298t56R4rZt9wlsyNQWd86vhpuNAGU1P5bTUXiqn9m3/6lJu34IyjMC/qMaUEEEjbZ1cpgv7g+bQGBDwHZwJ6QDMQWzuOwPvtF1aixs5ui8I4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=y8zqh3+zgPXkgwMgdXb2YVMZEeAqe9RHrQMmSlDBnDA=;
 b=Ur+MA03VKWE396zHdoIVLVDI7kTCk7cVZgIbTK2GPuHWuy+VOfEPXqeshs+DYbkXf/5xb2RlpMIJsptsekpe+bvnLS+kCpspg2Mpi2NL0RbC3AlNLBt7bnd8lAQlIsoQ7yhSTEbXlFSeUP2hTyfRuoUcSJIUJSj2lHPx5cVLRfuu1dfqwpUOleOjgB+D/SMRzDgrlelLoisADs6byDykbL/9hIIT3pskzbGCbtKJIBq8h80VYu/eeE6n9ITm+3cAAxoKHafF3/auBQXIZliSAC/hs14TavZeyJScPzbMo5fHv+T6E5z51iiC7OThNONRF5GU4dSuhvu8d1S5ZbisNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=y8zqh3+zgPXkgwMgdXb2YVMZEeAqe9RHrQMmSlDBnDA=;
 b=jCs3GtcMSpyHq0a+QxKMlfVmDgyUl7P5d+fg8CMFSpW1BzrXN65xicRIVwwoNN2TcFbFKLGPCdqSk24s8NRhK+lfJQ+Wu0LpFET3lbUwVepFhWDstG2zeU1eBWaF5kYsAYbFdWGbHUjuELiXNK4U1eG13+W6jaVZw3A2kMnndNA=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH 3/3] x86/build: Clean up boot/Makefile
Thread-Topic: [PATCH 3/3] x86/build: Clean up boot/Makefile
Thread-Index: AQHYT/V67Id16NtaEUioBH+FcJmIEKzvrtSAgAAcvQA=
Date: Thu, 14 Apr 2022 19:27:56 +0000
Message-ID: <c65d5641-7c09-ca90-a2fd-9808d02a44df@citrix.com>
References: <20220414114708.4788-1-andrew.cooper3@citrix.com>
 <20220414114708.4788-4-andrew.cooper3@citrix.com>
 <YlhdoQsE10j+VSQg@perard.uk.xensource.com>
In-Reply-To: <YlhdoQsE10j+VSQg@perard.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0b82e0ff-aa5d-418b-d95b-08da1e4ce147
x-ms-traffictypediagnostic: SA1PR03MB6385:EE_
x-microsoft-antispam-prvs: <SA1PR03MB63856936189F22E9B49D5C22BAEF9@SA1PR03MB6385.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: cGNpuFo/6NDOUdp4Qg+BRLQFMqPwhkQame65GO/qsMxLS0hwnxA/tCB6oN+sF8hz0iIfssV7aqSUFtu5adYxkjR9MlxhkyK7w4A3H+inLRT0qGiTGFITxZsqCQfBcqAC62R+dujRI1DNIyEOTfCaOAS3pqo+njOl7DEUuBWllURs+X+XNY9T1pSs0UUjwCP7WVuipphtELp6qusQftTgbfyLJrane74SyZIjinljXkwBGikhGbxN3qsN2menrF5BBXO2zfH8WPXXGSL0+VZ0FgoKpJV20JJC0EKGf+6Ke5pLflRlw/thUwB7sTAHf8jyOhGFwFiBIwS1SMZh/8riad8iTjeGSA7dr4SoNtqtgbIuyS5gS8kDlQGYGZ8ClSEZs3UsjMSFD7VS1i12vPaVCNlIfeWAIQajsPidfhllklC4jzHrx6/s1n+OqMi5H6lpHs1SxXfEU6QxnDOM2z29oAb7uAZMldrfMTLlj4TDzSc28B9U+GJ2yTBLrgM4/qGDBk8UmDsTfdsI5pIgfDr4aMynoxRqx9NYLCC64WCNtgVAyj9M+9ZRtg4O4LVVL5YRCt0DXPSw1jbBc8TLqKNzMl7tsP+Hd7Cb3rv2p/adaoj5SlbXgOxnbTzAbq2FYqbCDOMY6mUKnf+n9WQYTG1ZozgIlfiVDS5CbBeqD/YLVtwici1cIy2uqetxP5CY49RPDffGIXXZb7sPbaLhexhEfnQcJRFCKi916SUdQP4NRUWwtTtjCamz5yW3bHn6OY9Fwa3qDUm+S9J74R/meOcSaA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(316002)(64756008)(38070700005)(8676002)(6862004)(5660300002)(83380400001)(82960400001)(86362001)(91956017)(53546011)(31696002)(76116006)(6512007)(4326008)(6506007)(26005)(508600001)(66556008)(54906003)(66446008)(38100700002)(6636002)(66476007)(36756003)(186003)(2616005)(71200400001)(31686004)(2906002)(6486002)(8936002)(37006003)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Yk45aktQY0NkakJpY3IzUFNVVDQwTGJWcUZRcWx3R2crbUxtTlgvdC8zZUVB?=
 =?utf-8?B?UHBIT1ptcHBhVmZqS1dHWlVUblluUUc2Q1ZpWkZnVVpacGtHVkRmeTRKVS9z?=
 =?utf-8?B?a0liQWlSQnBXUVRPY2F6YktvRDlYQmg1MTNpSTl1alhaOFFSZ1YxaXhERlg5?=
 =?utf-8?B?RER5NnFLSFhBVWdyNFB4SlY3N1MwYUpYTW9ZTXFZcUxRc3N5MDFUcm44cDU5?=
 =?utf-8?B?R3prY3p6WWx3SlBIN1RmWXYxR0NtOTMzcHpDa29WSFVTTEhMWEJTZldlSm5y?=
 =?utf-8?B?S3NORU13emg3RGtHdGdnbVdFZmhDcWdWL25KZkV2emJSM3FpczRZcEdjalBu?=
 =?utf-8?B?UlJiMXp4RDRUQnhGWmNNZXphTTJHRXR0SDF4R1dtM1ZjNjlPVDlobThYTUxT?=
 =?utf-8?B?Y0w3UytTRFNQQ0M0WE80c1hRODdJZThKVkJLVlBRd0hpenBLcVpZREpyY1Vu?=
 =?utf-8?B?SEl3ck9abm45YkFodU1lMzNRUkxGU2ZhM282emNDU243WCtCVnY5TnYrMXNm?=
 =?utf-8?B?Zm9jRm90aHJlQzcrVVdqUTBGL2ZrS2pKWGd5Z2YzRUdjVFE0di9KOUFaQTVI?=
 =?utf-8?B?cWp2T2kwM2NDU0tWMGxZeTRxblpVak1LdkhFaDhXbWRrWTJuckc5YnA1akJm?=
 =?utf-8?B?MStpQUtBcndFUDlqTkxid3licDFMNEx4c0pKUGc5dVZrd3VpRktxdzFlb2Jz?=
 =?utf-8?B?Vmg1bUhuZ2RzbDVHTkFFUEUvekpiU0JZUTVQSTNzc0xWampnTnIrWXluYTU2?=
 =?utf-8?B?V2lnM2NMYnlHRGdjcjl2Wk5BeWdDclNVclo2ZjhHcTZWZlhDKzZxazZ6VVJn?=
 =?utf-8?B?RFlHazJIejRUUjZyWFg5U3l3WVJ0c0xVTXpHYVFrenAwQWVIamFBeFluSlEw?=
 =?utf-8?B?UkZqUVFxN2krdjRYbStBVXloVDZsZzluRUlHQXhCbnRrZit2N1htM0Nsc21Q?=
 =?utf-8?B?ODF5L25Ob2RrUkM4OFlsNnVnbnBQdk1GRVpTNlFNV3hMRkgzS0toWWpNYmdJ?=
 =?utf-8?B?NE1aR1BBLzhRRklNaWJ4YW50YTBTTEo3N29zRjIzUWJmemNlUC9aMkV2Y05Z?=
 =?utf-8?B?Tkprc1ZwL1ZsZVU5U0w0ckFZWGdBa2FkbWxUT0cxTTNFQ284Rk1hTTc3cnJw?=
 =?utf-8?B?UHpvakpiaTZBcksxZURjZ29DV3cwTXZWUVlabC8rcmVkM211RTJOMUg2R0xu?=
 =?utf-8?B?QWd0UURHK2c1Vk1MYmljbVhqaWNVbjQyZTBSckwyeFpLUXZXSWJ1a1ZreU1a?=
 =?utf-8?B?eE5WWTY3TjAzblRmVmtSSy85cFVGL2tjdEJmQTNza0xSV2Q0eTkrR2tLZWw0?=
 =?utf-8?B?dEd5Ym1ySmxQeFdudWJuZFoydEJ2RTJMSmF1ams4dzlORXFmQ2d5YnNtV01n?=
 =?utf-8?B?NUJYdHdWQkROYWozSzg2OU5HaFJLQ25xMEMrSGYvRWx1eUJnQVhlamlHYlBQ?=
 =?utf-8?B?d2gzYjhwUzRKa0YyRjJtRW5CRVRBS0t0cU5Da1VHMVhHK2Z5ajNRa1JxenZx?=
 =?utf-8?B?SE9TZmxZMFRPRFhBVzgzT0Nydy8xcE1hczlXY1E3RTR3Uy8vWnVCdDZLdlp0?=
 =?utf-8?B?OFNBNTJHVVBTdXhBd3VtRFR0aEtrc1NhMGl1bEowcjdobjU0SXZ0NCtncnR5?=
 =?utf-8?B?UXdqYkc5TnBEUkgxUEVVaFJUQ3VpZ3B5dEpWS2NUN1BBSnJ5UU15YVJxNDVs?=
 =?utf-8?B?QkFmYTBmcDZLKzJLTWkycGo5NkhJVGRnNDZ3SFNQTklKaVozRnpQbTFzbjRv?=
 =?utf-8?B?L29QaWFONnVVTytSYVd2cExVT1RkTTdUVkhaQ0dmYUtxUlpONWNCNEU4NlFw?=
 =?utf-8?B?R3d6YkRhNW9RdjhVVHhBWHd6dXRkZyt4VG53V0lqTnprM3h2MGtTWlhUQm8v?=
 =?utf-8?B?YUpZMG55VTJneFlFVklpSEJxNlBiK2dPSEk1VzlwV3Q3Sk52WUwvWTVlU242?=
 =?utf-8?B?bGJub0FUcjEwME5WeEovT2dRdE95QTJMWTZ3YmVkdW4vZHdwVnRFRTB4d1Rh?=
 =?utf-8?B?Tnl0MUVHZUVMVmUvbndnWXB0RTk1MURuMGVBa29MOW5obTBoUWF2aEhOa0Zy?=
 =?utf-8?B?WE8rWktOQndhSFZhT0VIRWIzT2hEZ1RzMFZtZ0dHb1AvdDBYdG04aktBTDVM?=
 =?utf-8?B?ZUF6T2dQaWJoYkY1bUhzUUxUOEtRT0VpZmRDSnhld1lKOWpkM2FlWGpodkQ2?=
 =?utf-8?B?ZEtSNGZidGRyZ0ZzaUZGbGVwQ24yaHJDZVpEeFpYZ21oYU1LeU82dVhDVzlB?=
 =?utf-8?B?RlV5Qit1a29aWkpSTUNVNXhaNW4yeEw5QTIybSt2T3Z4eHMxSVBqYnVRZzNw?=
 =?utf-8?B?YU9VVUl0NExVUVYraWJLWXdQZDMyVGFoL2l0NVJhWUdWNFVudU5XQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F929282FBC2E6E42ACCE380A0703F532@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b82e0ff-aa5d-418b-d95b-08da1e4ce147
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 19:27:56.9151
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tYaWIfFNnGibYBRABR/0BDkPAEyTmRUWfuKxq6AjwIW6/3fH9uTjMipkWAvKO3ReaSUsLH10Vdl4tEBVWPsUtj8zZldc76DUSALrcSIz028=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6385
X-OriginatorOrg: citrix.com

T24gMTQvMDQvMjAyMiAxODo0NSwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IE9uIFRodSwgQXBy
IDE0LCAyMDIyIGF0IDEyOjQ3OjA4UE0gKzAxMDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBU
aGVyZSBhcmUgbm8gLlMgaW50ZXJtZWRpYXRlIGZpbGVzLCBzbyByZXdvcmsgaW4gdGVybXMgb2Yg
aGVhZC1iaW4tb2Jqcy4NCj4+DQo+PiBObyBmdW5jdGlvbmFsIGNoYW5nZS4NCj4+DQo+PiBTaWdu
ZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBU
aGUgcGF0Y2ggbG9va3MgZmluZS4NCj4NCj4gUmV2aWV3ZWQtYnk6IEFudGhvbnkgUEVSQVJEIDxh
bnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KPg0KPj4gLS0tDQo+PiBJJ20gc2xpZ2h0bHkgLTEg
b24gdGhpcywgYmVjYXVzZQ0KPj4NCj4+ICAgaGVhZC1iaW4tb2JqcyA6PSAkKGFkZHByZWZpeCAk
KG9iaikvLCQoaGVhZC1iaW4tb2JqcykpDQo+Pg0KPj4gaXMgc3Vic3RhbnRpYWwgb2JmdXNjYXRp
b24gd2hpY2ggSSdkIHByZWZlciB0byBiaW4uDQo+IEl0IG1pZ2h0IGJlIHBvc3NpYmxlIHRvIGRv
IHNvbWV0aGluZyB0aGF0IEtidWlsZCBkb2VzLCB3aGljaCB3b3VsZCBiZSB0bw0KPiB0ZWFjaCB0
aGUgYnVpbGQgc3lzdGVtIHRvIGxvb2sgZm9yICIkKGhlYWQtb2JqcykiIG9yIG1heWJlDQo+ICIk
KGhlYWQtYmluLW9ianMpIiB3aGVuIGl0IHdhbnQgdG8gYnVpbGQgImhlYWQubyIuIFRoYXQgc29t
ZXRoaW5nIHRoYXQncw0KPiBkb25lIGluIEtidWlsZCBJIHRoaW5rIHRvIGJ1aWxkIGEgbW9kdWxl
IGZyb20gc2V2ZXJhbCBzb3VyY2UgZmlsZXMuDQo+DQo+PiBBbnRob255OiBXaHkgZG9lcyBkcm9w
cGluZyB0aGUgdGFyZ2V0cyArPSBsaW5lIGludGVyZmVyZSB3aXRoIGluY3JlbWVudGFsDQo+PiBi
dWlsZHM/ICBXaXRoIGl0IGdvbmUsICouYmluIGFyZSByZWdlbmVyYXRlZCB1bmNvbmRpdGlvbmFs
bHksIGJ1dCBJIGNhbid0IHNlZQ0KPj4gd2hhdCB3b3VsZCBjYXVzZSB0aGF0LCBub3Igd2h5IHRo
ZSBub3JtYWwgZGVwZW5kZW5jaWVzIG9uIGhlYWQubyBkb24ndCB3b3JrLg0KPiBUcnkgdG8gYnVp
bGQgd2l0aCAibWFrZSBWPTIiLCBtYWtlIHdpbGwgZGlzcGxheSB3aHkgYSB0YXJnZXQgaXMgYmVl
bg0KPiByZWJ1aWxkICh3aGVuIHRoaXMgdGFyZ2V0IGlzIGJ1aWx0IHdpdGggJChpZl9jaGFuZ2Vk
LCApDQo+DQo+ICQodGFyZ2V0cykgaXMgdXNlZCBieSBSdWxlcy5tayB0byBmaW5kb3V0IHdoaWNo
IGRlcGVuZGVuY2llcyBmaWxlcyAodGhlDQo+IC5jbWQpIHRvIGxvYWQgYW5kIG9ubHkgbG9hZCB0
aGVtIGlmIHRoZSB0YXJnZXQgZXhpc3QuIFRoZW4gdGhlDQo+ICQoaWZfY2hhbmdlZCwgKSBtYWNy
byByZXJ1biB0aGUgY29tbWFuZCBpZiBwcmVyZXEgYXJlIG5ld2VyIHRoYW4gdGhlDQo+IHRhcmdl
dCBvciBpZiB0aGUgY29tbWFuZCBhcyBjaGFuZ2VkLiBXaXRob3V0IHRoZSAuY21kIGZpbGUgbG9h
ZGVkLCB0aGUNCj4gbWFjcm8gd291bGQgY29tcGFyZSB0aGUgbmV3IGNvbW1hbmQgdG8gYW4gZW1w
dHkgdmFsdWUgYW5kIHNvIHJlYnVpbGQgdGhlDQo+IHRhcmdldC4NCj4NCj4gTm93LCB0aGUgKi5i
aW4gZmlsZXMgYXJlIHJlZ2VuZXJhdGVkIGJlY2F1c2UgY21kbGluZS5vIGlzIGJlZW4gcmVidWls
ZA0KPiBtb3N0bHkgYmVjYXVzZSBtYWtlIGRpZG4ndCBsb2FkIHRoZSByZWNvcmQgb2YgdGhlIHBy
ZXZpb3VzIGNvbW1hbmQgcnVuLg0KDQpJJ20gbm90IGNlcnRhaW4gaWYgdGhpcyBjYXNlIGlzIGEg
bWF0Y2ggd2l0aCBMaW51eCdzIG1vZHVsZSBsb2dpYy7CoCBUaGUNCm1vZHVsZSBsb2dpYyBpcyAi
Y29tcGlsZSBlYWNoIC5jIGZpbGUsIHRoZW4gbGluayBhbGwgdGhlIC5vJ3MgdG9nZXRoZXINCmlu
dG8gb25lIC5rbyIuDQoNCkluIHRoaXMgY2FzZSwgd2UncmUgc2F5aW5nICJ0byBhc3NlbWJsZSBo
ZWFkLlMgdG8gaGVhZC5vLCB5b3UgZmlyc3QgbmVlZA0KdG8gYnVpbGQge2NtZGxpbmUscmVsb2N9
LmJpbiBzbyB0aGUgaW5jYmluIGRvZXNuJ3QgZXhwbG9kZSIuwqAgSSBndWVzcyBpdA0KZGVwZW5k
cyBob3cgZ2VuZXJpYyB0aGUgIiRYIGRlcGVuZHMgb24gYXJiaXRyYXJ5ICRZJ3MiIGV4cHJlc3Np
b24gY2FuIGJlDQptYWRlLg0KDQpCZXR3ZWVuIHRoaXMgcGF0Y2ggYW4gdGhlIHByZXZpb3VzIG9u
ZSwgSSd2ZSBjbGVhcmx5IGdvdCBtaXhlZCB1cCB3aXRoDQp3aGF0IGV4YWN0bHkgdGhlIHRhcmdl
dCs9IGFuZCByZWd1bGFyIGRlcGVuZGVuY2llcy4NCg0KVGhlIGNvbW1lbnQgc3BlY2lmaWNhbGx5
IHJlZmVycyB0byB0aGUgZmFjdCB0aGF0IHRoZSBvbGQgI2luY2x1ZGUNCiJjbWRsaW5lLlMiIHVz
ZWQgdG8gc2hvdyB1cCBhcyBhIGRlcCBpbiAuaGVhZC5vLmNtZCwgd2hlcmVhcyAuaW5jYmluDQpk
b2Vzbid0LsKgIChOb3Qgc3VycHJpc2luZywgYmVjYXVzZSAtTSBhbmQgZnJpZW5kcyBhcmUgZnJv
bSB0aGUNCnByZXByb2Nlc3Nvciwgbm90IGFzc2VtYmxlciwgYnV0IGl0IHdvdWxkIGJlIGhlbHBm
dWwgaWYgdGhpcyBsaW1pdGF0aW9uDQpkaWRuJ3QgZXhpc3QuKcKgIEFzIGEgY29uc2VxdWVuY2Us
IHRoZSBkZXBlbmRlbmN5IG5lZWRzIGFkZGluZyBiYWNrIGluDQpzb21laG93Lg0KDQpGcm9tIHlv
dXIgZGVzY3JpcHRpb24gYWJvdmUsIEkgYXNzdW1lIHRoYXQgc2ltcGx5IGJlaW5nIGxpc3RlZCBh
cyBhIGRlcA0KaXNuJ3QgZ29vZCBlbm91Z2ggdG8gdHJpZ2dlciBhIHJlY3Vyc2l2ZSBsb2FkIG9m
IHRoZSAuYmluJ3MgLmNtZCBmaWxlDQoobm90IHRoYXQgdGhlcmUgaXMgb25lKSwgd2hpY2ggaXMg
d2h5IHRoZXkgbmVlZCBhZGRpbmcgc3BlY2lhbGx5IHRvIHRhcmdldHM/DQoNCkFzIEkgaGF2ZSBz
aW1wbGlmaWVkIHRoaXMgdG8gKGFsbW9zdCkgbm9ybWFsIGJ1aWxkIHJ1bmVzLCBzaG91bGQgd2Ug
YmUNCmV4cHJlc3NpbmcgaXQgZGlmZmVyZW50bHkgbm93IHRvIGZpdCBpbiB3aXRoIHRoZSBuZXcg
d2F5IG9mIGRvaW5nIHRoaW5ncz8NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:36:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:36:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305089.519939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf5GA-0003HI-1U; Thu, 14 Apr 2022 19:36:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305089.519939; Thu, 14 Apr 2022 19:36:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf5G9-0003HB-Ud; Thu, 14 Apr 2022 19:36:05 +0000
Received: by outflank-mailman (input) for mailman id 305089;
 Thu, 14 Apr 2022 19:36:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf5G8-0003H5-IV
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:36:04 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e9644a1-bc2a-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 21:36:03 +0200 (CEST)
Received: by mail-lj1-x229.google.com with SMTP id c15so7298520ljr.9
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 12:36:03 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 y14-20020a2eb00e000000b0024b55cda2eesm80127ljk.30.2022.04.14.12.36.01
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Apr 2022 12:36:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e9644a1-bc2a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=sOQzqq1JRdIBUn7b46U2ZLsHxv1oDPMvZlhGwn1tgUM=;
        b=DWmwgeffoVU1kflkJbM00vaPsUrpMY7mEHEHMEMctxShKY35faldd4CvM0qK3a2zXZ
         neMNYoChcxVBY4ngfy8HKHmZRcPq74o7AlkimyX2uucmytuCZMREfB35rrO15GIIvxLn
         PCmpflHcA/TqR3q58tT0ejO6wpJVWjfTyRCaRqiz+jqq0IuSSKqfdmf+Qv5WhIeQQeQL
         e13qyV2aWIMGP2AazfOLgDwiJ8jcUt6atugFDE4D/7V1/MaHL3Mo0vKgwWJAmR4kq+wm
         wQyNWF4eoPI97GgcoCOUffuwtu7Nsyg0FMF9wEJqzUZ164lh20vU1IEOz0X5sS30xhdf
         Y57g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=sOQzqq1JRdIBUn7b46U2ZLsHxv1oDPMvZlhGwn1tgUM=;
        b=FYCKgjD6Ta/kJ1C10CduVM3HfalkLnST/eJGRvgYcKsjBakgaG0R35LJBus5Nai+tR
         Q6+R+9xyoeDtKaswoqX7jJtUkbsnHG71bgR0cSsO6KsfBEw4/LMtjJya9vkHosoNFN3H
         i0riz0R59G+jm1c9JNtaDvjdWZLSvT277cNdAtRvVVE8oVOb3UyC3UX+VmUOH+59NI1C
         8TVwSyDKCVLby1vEyPOexBUTLz4Ksujbgr+oMbwzG9Owb1f16UY41pILzvnaBsvdbFuI
         U0py+O5DG6UbyVMHSGMXLWrezeWMUetd26KsR/WI0iDkWrHhgbBbwC3B/L/44EL3QYWq
         nYGg==
X-Gm-Message-State: AOAM532C3a366YsVkuUBmCRVgV93Tqa3AOdAK1cgIjFavNULEWnhhHJx
	srccTWFlfRZp4W53Tpx5gcrBxaurT+s=
X-Google-Smtp-Source: ABdhPJxHGujD1IucpfW2l2QsnEeQLPUoypoFIolcUnb9af/DdrdyTNAq4fgZpfB5d8xa0HK56Zfd1Q==
X-Received: by 2002:a05:651c:1591:b0:24d:a2ed:7104 with SMTP id h17-20020a05651c159100b0024da2ed7104mr584691ljq.11.1649964962411;
        Thu, 14 Apr 2022 12:36:02 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>,
	Henry Wang <Henry.Wang@arm.com>,
	Kaly Xin <Kaly.Xin@arm.com>,
	Jiamei Xie <Jiamei.Xie@arm.com>,
	=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
Subject: [RFC PATCH] libxl/arm: Insert "xen,dev-domid" property to virtio-mmio device node
Date: Thu, 14 Apr 2022 22:36:00 +0300
Message-Id: <1649964960-24864-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is needed for grant table based DMA ops layer (CONFIG_XEN_VIRTIO)
at the guest side to retrieve the ID of Xen domain where the corresponding
backend resides (it is used as an argument to the grant table APIs).

This is a part of restricted memory access under Xen feature.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
!!! This patch is based on non upstreamed yet “Virtio support for toolstack
on Arm” series which is on review now:
https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/

All details are at:
https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-olekstysh@gmail.com/
---
 tools/libs/light/libxl_arm.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 8132a47..d9b26fc 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -875,7 +875,8 @@ static int make_vpci_node(libxl__gc *gc, void *fdt,
 
 
 static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
-                                 uint64_t base, uint32_t irq)
+                                 uint64_t base, uint32_t irq,
+                                 uint32_t backend_domid)
 {
     int res;
     gic_interrupt intr;
@@ -900,6 +901,14 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
     res = fdt_property(fdt, "dma-coherent", NULL, 0);
     if (res) return res;
 
+    if (backend_domid != LIBXL_TOOLSTACK_DOMID) {
+        uint32_t domid[1];
+
+        domid[0] = cpu_to_fdt32(backend_domid);
+        res = fdt_property(fdt, "xen,dev-domid", domid, sizeof(domid));
+        if (res) return res;
+    }
+
     res = fdt_end_node(fdt);
     if (res) return res;
 
@@ -1218,7 +1227,8 @@ next_resize:
             libxl_device_disk *disk = &d_config->disks[i];
 
             if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
-                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) );
+                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq,
+                                           disk->backend_domid) );
         }
 
         if (pfdt)
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:52:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:52:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305094.519951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf5Vc-0005gM-D7; Thu, 14 Apr 2022 19:52:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305094.519951; Thu, 14 Apr 2022 19:52:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf5Vc-0005gF-9i; Thu, 14 Apr 2022 19:52:04 +0000
Received: by outflank-mailman (input) for mailman id 305094;
 Thu, 14 Apr 2022 19:52:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=IfEj=UY=zytor.com=hpa@srs-se1.protection.inumbo.net>)
 id 1nf5Va-0005g9-Kr
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 19:52:02 +0000
Received: from mail.zytor.com (terminus.zytor.com [198.137.202.136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 58518ede-bc2c-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 21:52:00 +0200 (CEST)
Received: from [IPv6:::1] ([IPv6:2607:fb90:7391:dbf4:ac39:3cd7:6899:402e])
 (authenticated bits=0)
 by mail.zytor.com (8.17.1/8.15.2) with ESMTPSA id 23EJp85B2752024
 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO);
 Thu, 14 Apr 2022 12:51:11 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 58518ede-bc2c-11ec-8fbe-03012f2f19d4
DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 23EJp85B2752024
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com;
	s=2022040301; t=1649965875;
	bh=/BfbkVBNXXWXvD67lDcz7ZEDHdrIeL3N3o3RiijcK/8=;
	h=Date:From:To:CC:Subject:In-Reply-To:References:From;
	b=Ih1N5WnNg/CUOzYCRiUlmBCjhBc//rksM7yddZRMTFGF8Uocg3oC42OfEA2rSuBaQ
	 L5Dme8+oj2fdSEdk/CxJMQPZs/zYnFik3LdwTHGYDohHpZXX6qcFFcvZCs/PB4FMFc
	 XmSuFGQW3BgjOHVQbPknw0P2yjwJQXRqaPXHHq0GGsuvwlPEG9YTwI76DZS0zVMXk/
	 QlK9c5QdQFKsH5aY9qCbqxzlwred9ckWKCSZJFXav5KgFgy7zjduOSo9pwYkttwNJr
	 3LnCQBPB8SFFclqvnQZTPvwAfiwTz3r8s87Q4F+gUiNy4I9rsT68Xuq4xGFjAbzhXv
	 kUBJUiDoikUTA==
Date: Thu, 14 Apr 2022 12:43:33 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org, linux-kernel@vger.kernel.org
CC: Juergen Gross <jgross@suse.com>, Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: =?US-ASCII?Q?Re=3A_=5BRFC_PATCH_2/6=5D_virtio=3A_add_optio?= =?US-ASCII?Q?n_to_restrict_memory_access_under_Xen?=
User-Agent: K-9 Mail for Android
In-Reply-To: <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
Message-ID: <5A795507-715D-494B-B56B-B12E5BE348A4@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On April 14, 2022 12:19:29 PM PDT, Oleksandr Tyshchenko <olekstysh@gmail=2E=
com> wrote:
>From: Juergen Gross <jgross@suse=2Ecom>
>
>In order to support virtio in Xen guests add a config option enabling
>the user to specify whether in all Xen guests virtio should be able to
>access memory via Xen grant mappings only on the host side=2E
>
>This applies to fully virtualized guests only, as for paravirtualized
>guests this is mandatory=2E
>
>This requires to switch arch_has_restricted_virtio_memory_access()
>from a pure stub to a real function on x86 systems (Arm systems are
>not covered by now)=2E
>
>Add the needed functionality by providing a special set of DMA ops
>handling the needed grant operations for the I/O pages=2E
>
>Signed-off-by: Juergen Gross <jgross@suse=2Ecom>
>---
> arch/x86/mm/init=2Ec        |  15 ++++
> arch/x86/mm/mem_encrypt=2Ec |   5 --
> arch/x86/xen/Kconfig      |   9 +++
> drivers/xen/Kconfig       |  20 ++++++
> drivers/xen/Makefile      |   1 +
> drivers/xen/xen-virtio=2Ec  | 177 ++++++++++++++++++++++++++++++++++++++=
++++++++
> include/xen/xen-ops=2Eh     |   8 +++
> 7 files changed, 230 insertions(+), 5 deletions(-)
> create mode 100644 drivers/xen/xen-virtio=2Ec
>
>diff --git a/arch/x86/mm/init=2Ec b/arch/x86/mm/init=2Ec
>index d8cfce2=2E=2E526a3b2 100644
>--- a/arch/x86/mm/init=2Ec
>+++ b/arch/x86/mm/init=2Ec
>@@ -8,6 +8,8 @@
> #include <linux/kmemleak=2Eh>
> #include <linux/sched/task=2Eh>
>=20
>+#include <xen/xen=2Eh>
>+
> #include <asm/set_memory=2Eh>
> #include <asm/e820/api=2Eh>
> #include <asm/init=2Eh>
>@@ -1065,3 +1067,16 @@ unsigned long max_swapfile_size(void)
> 	return pages;
> }
> #endif
>+
>+#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>+int arch_has_restricted_virtio_memory_access(void)
>+{
>+	if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
>+		return 1;
>+	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
>+		return 1;
>+
>+	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
>+}
>+EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>+#endif
>diff --git a/arch/x86/mm/mem_encrypt=2Ec b/arch/x86/mm/mem_encrypt=2Ec
>index 50d2099=2E=2Edda020f 100644
>--- a/arch/x86/mm/mem_encrypt=2Ec
>+++ b/arch/x86/mm/mem_encrypt=2Ec
>@@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
> 	print_mem_encrypt_feature_info();
> }
>=20
>-int arch_has_restricted_virtio_memory_access(void)
>-{
>-	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
>-}
>-EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
>index 85246dd=2E=2Edffdffd 100644
>--- a/arch/x86/xen/Kconfig
>+++ b/arch/x86/xen/Kconfig
>@@ -92,3 +92,12 @@ config XEN_DOM0
> 	select X86_X2APIC if XEN_PVH && X86_64
> 	help
> 	  Support running as a Xen Dom0 guest=2E
>+
>+config XEN_PV_VIRTIO
>+	bool "Xen virtio support for PV guests"
>+	depends on XEN_VIRTIO && XEN_PV
>+	default y
>+	help
>+	  Support virtio for running as a paravirtualized guest=2E This will
>+	  need support on the backend side (qemu or kernel, depending on the
>+	  virtio device types used)=2E
>diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>index 120d32f=2E=2Efc61f7a 100644
>--- a/drivers/xen/Kconfig
>+++ b/drivers/xen/Kconfig
>@@ -335,4 +335,24 @@ config XEN_UNPOPULATED_ALLOC
> 	  having to balloon out RAM regions in order to obtain physical memory
> 	  space to create such mappings=2E
>=20
>+config XEN_VIRTIO
>+	bool "Xen virtio support"
>+	default n
>+	depends on VIRTIO && DMA_OPS
>+	select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>+	help
>+	  Enable virtio support for running as Xen guest=2E Depending on the
>+	  guest type this will require special support on the backend side
>+	  (qemu or kernel, depending on the virtio device types used)=2E
>+
>+config XEN_HVM_VIRTIO_GRANT
>+	bool "Require virtio for fully virtualized guests to use grant mappings=
"
>+	depends on XEN_VIRTIO && X86_64
>+	default y
>+	help
>+	  Require virtio for fully virtualized guests to use grant mappings=2E
>+	  This will avoid the need to give the backend the right to map all
>+	  of the guest memory=2E This will need support on the backend side
>+	  (qemu or kernel, depending on the virtio device types used)=2E
>+
> endmenu
>diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>index 5aae66e=2E=2E767009c 100644
>--- a/drivers/xen/Makefile
>+++ b/drivers/xen/Makefile
>@@ -39,3 +39,4 @@ xen-gntalloc-y				:=3D gntalloc=2Eo
> xen-privcmd-y				:=3D privcmd=2Eo privcmd-buf=2Eo
> obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)	+=3D xen-front-pgdir-shbuf=2Eo
> obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)	+=3D unpopulated-alloc=2Eo
>+obj-$(CONFIG_XEN_VIRTIO)		+=3D xen-virtio=2Eo
>diff --git a/drivers/xen/xen-virtio=2Ec b/drivers/xen/xen-virtio=2Ec
>new file mode 100644
>index 00000000=2E=2Ecfd5eda
>--- /dev/null
>+++ b/drivers/xen/xen-virtio=2Ec
>@@ -0,0 +1,177 @@
>+// SPDX-License-Identifier: GPL-2=2E0-only
>+/***********************************************************************=
*******
>+ * Xen virtio driver - enables using virtio devices in Xen guests=2E
>+ *
>+ * Copyright (c) 2021, Juergen Gross <jgross@suse=2Ecom>
>+ */
>+
>+#include <linux/module=2Eh>
>+#include <linux/dma-map-ops=2Eh>
>+#include <linux/pci=2Eh>
>+#include <linux/pfn=2Eh>
>+#include <linux/virtio_config=2Eh>
>+#include <xen/xen=2Eh>
>+#include <xen/grant_table=2Eh>
>+
>+#define XEN_GRANT_ADDR_OFF	0x8000000000000000ULL
>+
>+static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>+{
>+	return XEN_GRANT_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
>+}
>+
>+static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>+{
>+	return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT);
>+}
>+
>+/*
>+ * DMA ops for Xen virtio frontends=2E
>+ *
>+ * Used to act as a kind of software IOMMU for Xen guests by using grant=
s as
>+ * DMA addresses=2E
>+ * Such a DMA address is formed by using the grant reference as a frame
>+ * number and setting the highest address bit (this bit is for the backe=
nd
>+ * to be able to distinguish it from e=2Eg=2E a mmio address)=2E
>+ *
>+ * Note that for now we hard wire dom0 to be the backend domain=2E In or=
der to
>+ * support any domain as backend we'd need to add a way to communicate t=
he
>+ * domid of this backend, e=2Eg=2E via Xenstore or via the PCI-device's =
config
>+ * space=2E
>+ */
>+static void *xen_virtio_dma_alloc(struct device *dev, size_t size,
>+				  dma_addr_t *dma_handle, gfp_t gfp,
>+				  unsigned long attrs)
>+{
>+	unsigned int n_pages =3D PFN_UP(size);
>+	unsigned int i;
>+	unsigned long pfn;
>+	grant_ref_t grant;
>+	void *ret;
>+
>+	ret =3D (void *)__get_free_pages(gfp, get_order(size));
>+	if (!ret)
>+		return NULL;
>+
>+	pfn =3D virt_to_pfn(ret);
>+
>+	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
>+		free_pages((unsigned long)ret, get_order(size));
>+		return NULL;
>+	}
>+
>+	for (i =3D 0; i < n_pages; i++) {
>+		gnttab_grant_foreign_access_ref(grant + i, 0,
>+						pfn_to_gfn(pfn + i), 0);
>+	}
>+
>+	*dma_handle =3D grant_to_dma(grant);
>+
>+	return ret;
>+}
>+
>+static void xen_virtio_dma_free(struct device *dev, size_t size, void *v=
addr,
>+				dma_addr_t dma_handle, unsigned long attrs)
>+{
>+	unsigned int n_pages =3D PFN_UP(size);
>+	unsigned int i;
>+	grant_ref_t grant;
>+
>+	grant =3D dma_to_grant(dma_handle);
>+
>+	for (i =3D 0; i < n_pages; i++)
>+		gnttab_end_foreign_access_ref(grant + i);
>+
>+	gnttab_free_grant_reference_seq(grant, n_pages);
>+
>+	free_pages((unsigned long)vaddr, get_order(size));
>+}
>+
>+static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_=
t size,
>+					       dma_addr_t *dma_handle,
>+					       enum dma_data_direction dir,
>+					       gfp_t gfp)
>+{
>+	WARN_ONCE(1, "xen_virtio_dma_alloc_pages size %ld\n", size);
>+	return NULL;
>+}
>+
>+static void xen_virtio_dma_free_pages(struct device *dev, size_t size,
>+				      struct page *vaddr, dma_addr_t dma_handle,
>+				      enum dma_data_direction dir)
>+{
>+	WARN_ONCE(1, "xen_virtio_dma_free_pages size %ld\n", size);
>+}
>+
>+static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct pag=
e *page,
>+					  unsigned long offset, size_t size,
>+					  enum dma_data_direction dir,
>+					  unsigned long attrs)
>+{
>+	grant_ref_t grant;
>+
>+	if (gnttab_alloc_grant_references(1, &grant))
>+		return 0;
>+
>+	gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page),
>+					dir =3D=3D DMA_TO_DEVICE);
>+
>+	return grant_to_dma(grant) + offset;
>+}
>+
>+static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma=
_handle,
>+				      size_t size, enum dma_data_direction dir,
>+				      unsigned long attrs)
>+{
>+	grant_ref_t grant;
>+
>+	grant =3D dma_to_grant(dma_handle);
>+
>+	gnttab_end_foreign_access_ref(grant);
>+
>+	gnttab_free_grant_reference(grant);
>+}
>+
>+static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist =
*sg,
>+				 int nents, enum dma_data_direction dir,
>+				 unsigned long attrs)
>+{
>+	WARN_ONCE(1, "xen_virtio_dma_map_sg nents %d\n", nents);
>+	return -EINVAL;
>+}
>+
>+static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterli=
st *sg,
>+				    int nents, enum dma_data_direction dir,
>+				    unsigned long attrs)
>+{
>+	WARN_ONCE(1, "xen_virtio_dma_unmap_sg nents %d\n", nents);
>+}
>+
>+static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask)
>+{
>+	return 1;
>+}
>+
>+static const struct dma_map_ops xen_virtio_dma_ops =3D {
>+	=2Ealloc =3D xen_virtio_dma_alloc,
>+	=2Efree =3D xen_virtio_dma_free,
>+	=2Ealloc_pages =3D xen_virtio_dma_alloc_pages,
>+	=2Efree_pages =3D xen_virtio_dma_free_pages,
>+	=2Emmap =3D dma_common_mmap,
>+	=2Eget_sgtable =3D dma_common_get_sgtable,
>+	=2Emap_page =3D xen_virtio_dma_map_page,
>+	=2Eunmap_page =3D xen_virtio_dma_unmap_page,
>+	=2Emap_sg =3D xen_virtio_dma_map_sg,
>+	=2Eunmap_sg =3D xen_virtio_dma_unmap_sg,
>+	=2Edma_supported =3D xen_virtio_dma_dma_supported,
>+};
>+
>+void xen_virtio_setup_dma_ops(struct device *dev)
>+{
>+	dev->dma_ops =3D &xen_virtio_dma_ops;
>+}
>+EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops);
>+
>+MODULE_DESCRIPTION("Xen virtio support driver");
>+MODULE_AUTHOR("Juergen Gross <jgross@suse=2Ecom>");
>+MODULE_LICENSE("GPL");
>diff --git a/include/xen/xen-ops=2Eh b/include/xen/xen-ops=2Eh
>index a3584a3=2E=2Eae3c1bc 100644
>--- a/include/xen/xen-ops=2Eh
>+++ b/include/xen/xen-ops=2Eh
>@@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) {=
 }
>=20
> #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
>=20
>+#ifdef CONFIG_XEN_VIRTIO
>+void xen_virtio_setup_dma_ops(struct device *dev);
>+#else
>+static inline void xen_virtio_setup_dma_ops(struct device *dev)
>+{
>+}
>+#endif /* CONFIG_XEN_VIRTIO */
>+
> #endif /* INCLUDE_XEN_OPS_H */

Can you please encapsulate the Xen part of the test in some Xen-specific f=
ile?


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 19:58:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 19:58:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305099.519961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf5bT-0006KJ-1U; Thu, 14 Apr 2022 19:58:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305099.519961; Thu, 14 Apr 2022 19:58:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf5bS-0006KC-Uy; Thu, 14 Apr 2022 19:58:06 +0000
Received: by outflank-mailman (input) for mailman id 305099;
 Thu, 14 Apr 2022 19:58:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf5bR-0006K2-RW; Thu, 14 Apr 2022 19:58:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf5bR-0001gm-Ob; Thu, 14 Apr 2022 19:58:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf5bR-0002Mo-Ez; Thu, 14 Apr 2022 19:58:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf5bR-0007X8-EV; Thu, 14 Apr 2022 19:58:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ucUdF6nukkKXsteQJKemGeQxsStaOri+D6t5mr2dhz4=; b=uM6oYWdbJZKU9SYq0dfdyVhDzF
	XmsGbpYboWyXYbXvVohSF349Rk0CXQw7tGQiNwW+LcPXEbmG3vW5V26/ZEX5yrKRaLE8toDvMO7QZ
	tbXIQAHbXTwp3TJoBiHRQjkcXMFnfpx4luerI/dbZWAnRGA8xkb+s1QyIIOjJz94RFAQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169404-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169404: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 19:58:05 +0000

flight 169404 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169404/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f3da13461cbed699e54b1d7ef3fba5144cc3b3b4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  395 attempts
Testing same since   169397  2022-04-14 15:10:23 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5103 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 20:03:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 20:03:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305110.519973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf5h3-0007r3-O3; Thu, 14 Apr 2022 20:03:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305110.519973; Thu, 14 Apr 2022 20:03:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf5h3-0007qw-L8; Thu, 14 Apr 2022 20:03:53 +0000
Received: by outflank-mailman (input) for mailman id 305110;
 Thu, 14 Apr 2022 20:03:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCiM=UY=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nf5h1-0007qq-Qg
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 20:03:51 +0000
Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com
 [2607:f8b0:4864:20::f2d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0056c53f-bc2e-11ec-a405-831a346695d4;
 Thu, 14 Apr 2022 22:03:50 +0200 (CEST)
Received: by mail-qv1-xf2d.google.com with SMTP id hu11so4978328qvb.7
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 13:03:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0056c53f-bc2e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=2pNaKHROdAKSL54wzL8nb03qQdEJLmJRk4/BgRLUAWc=;
        b=ftpbXYlrRYaJ8QQy2Zkaaj2oLnX/1pmRBi+IkSpNFBlOwK8/fSLN1rZwd3BokbFLFZ
         qNezLQJ3M7lcwb1dkzWiosVDlrpiWWJfRkfzlJLFF0p4KnS8+Cn5n/rY5l0VOQPtj+fL
         qxMmpxQhYXEpf8D5XJxrXKDZ1seKwqKZ5DkrXkt1h3v4443V5KjG30mDAH72EW/swD2F
         WFKZnHKRxAYITnNd6n+xj8F4kDZ1keCfaVzFmSspZJR5qAwaJ5z91WTfQad8VkBaYfoi
         +vgz34DB/aS0jLnqGr/azhqAFLx9v6SeUXKCp4+LO7qcQa4hHj18xNC/uILWETU7rsz6
         /IUw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=2pNaKHROdAKSL54wzL8nb03qQdEJLmJRk4/BgRLUAWc=;
        b=MqVfnTYRPWaPQXWLrBIAH7+Oel39Q7HxzGdfMmhMJuHN4+Or9yfvnRr15IlUcSD6MH
         RjiOvrM8yNpu7qoDIln4YuRYO8s5WN6aEtCHJ5dBss9sJ/AQEZfvN0zvW64UF1HN3Hok
         8pxhBlGMNcfdFucDa7SyN9ywOj2oJ10BYmUfCAGnjsMqcpL6ko8+jU54wKxoxH4f6KJ7
         uUjTIIMm+ZEIEo+B6sy4oN9RQn2XYUFhfrJ1rt+I0ANdaIJGgK0sBXn9fhITKU5YOPkq
         9qti+9J6OKZ/6yp4eCHs1wWn9V7GPvqnqktAm2EN/0lPFPlVi6L6EIzz7nrZ3Ro7kjht
         4Mvw==
X-Gm-Message-State: AOAM530xg698hmJE9qb85O3VL4S9f1SIRfgE8mksv/z/kwJ4g5XgQBed
	ZEl6cpNrAYZhqsQLVcVozP4yeaNfcFP5jdVa5Q7/YIhcxTU=
X-Google-Smtp-Source: ABdhPJzX2jSVS3FygLQp+MUraAjUTpufsH6dXQtH61r/dmx8+uTxzPCLPaIL1JQH3FbzxGBJfU9OZaj7+t+tZCHCogk=
X-Received: by 2002:a05:6214:5284:b0:444:10c8:ee59 with SMTP id
 kj4-20020a056214528400b0044410c8ee59mr4997174qvb.68.1649966629539; Thu, 14
 Apr 2022 13:03:49 -0700 (PDT)
MIME-Version: 1.0
References: <87pmsylywy.fsf@linaro.org> <YU5mW396S04IsCBr@mail-itl>
 <874ka68h96.fsf@linaro.org> <CACMJ4GbgnQVQbH1N3Duxmx10n-Qv+zzncqarNyuhmKhE-wqdqA@mail.gmail.com>
 <alpine.DEB.2.21.2109272323160.5022@sstabellini-ThinkPad-T480s>
 <CAPD2p-=MdGB_a+oEsFrPQpLo7GeKkMwYyAWcQt3z0qrGr3vR7w@mail.gmail.com>
 <alpine.DEB.2.21.2110011649220.3209@sstabellini-ThinkPad-T480s>
 <CAPD2p-m=hYbG1YjPZ9yZ7Qzs6KjCT2jSHpaDUPB0sFJoZfY4uw@mail.gmail.com>
 <alpine.DEB.2.21.2110041436070.3209@sstabellini-ThinkPad-T480s> <1d6382b6-ddf8-494c-4f7b-afc50a4269a4@gmail.com>
In-Reply-To: <1d6382b6-ddf8-494c-4f7b-afc50a4269a4@gmail.com>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Thu, 14 Apr 2022 23:03:37 +0300
Message-ID: <CAPD2p-nftmTXQTaOw1kmkBDn96i8sgcaH21o7bsGK-fA+fYbaw@mail.gmail.com>
Subject: Re: [Stratos-dev] Xen Rust VirtIO demos work breakdown for Project Stratos
To: xen-devel <xen-devel@lists.xenproject.org>, 
	Rust-VMM Mailing List <rust-vmm@lists.opendev.org>, 
	Stratos Mailing List <stratos-dev@op-lists.linaro.org>
Cc: Christopher Clark <christopher.w.clark@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>, 
	Artem Mygaiev <Artem_Mygaiev@epam.com>, Sergio Lopez <slp@redhat.com>, Wei Liu <wl@xen.org>, 
	Stefan Hajnoczi <stefanha@gmail.com>, Doug Goldstein <cardoe@cardoe.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Arnd Bergmann <arnd.bergmann@linaro.org>, 
	David Woodhouse <dwmw2@infradead.org>, Rich Persaud <persaur@gmail.com>, 
	Daniel Smith <dpsmith@apertussolutions.com>, Paul Durrant <paul@xen.org>, 
	openxt <openxt@googlegroups.com>, Julien Grall <julien@xen.org>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Content-Type: multipart/alternative; boundary="000000000000d8536405dca2cafd"

--000000000000d8536405dca2cafd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello all.

[Sorry for the possible format issues]

I have an update regarding (valid) concern which has been also raised in
current thread which is the virtio backend's ability (when using Xen
foreign mapping) to map any guest pages without guest "agreement" on that.
There is a PoC (with virtio-mmio on Arm) which is based on Juergen Gross=E2=
=80=99
work to reuse secure Xen grant mapping for the virtio communications.
All details are at:
https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-oleksty=
sh@gmail.com/
https://lore.kernel.org/xen-devel/1649964960-24864-1-git-send-email-oleksty=
sh@gmail.com/

--=20
Regards,

Oleksandr Tyshchenko

--000000000000d8536405dca2cafd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div class=3D"gmail_attr">Hello all.</div><div class=3D"gmail_attr"><br></d=
iv><div class=3D"gmail_attr">[Sorry for the possible format issues]</div><d=
iv class=3D"gmail_attr"><br></div><div class=3D"gmail_attr">I have an updat=
e regarding (valid) concern which has been also raised in current thread wh=
ich is the virtio backend&#39;s ability (when using Xen foreign mapping) to=
 map any guest pages without guest &quot;agreement&quot; on that.</div><div=
 class=3D"gmail_attr">There is a PoC (with virtio-mmio on Arm) which is bas=
ed on Juergen Gross=E2=80=99=C2=A0 work to reuse secure Xen grant mapping f=
or the virtio communications.</div><div class=3D"gmail_attr">All details ar=
e at:<br></div><div class=3D"gmail_attr"><a href=3D"https://lore.kernel.org=
/xen-devel/1649963973-22879-1-git-send-email-olekstysh@gmail.com/" target=
=3D"_blank">https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-e=
mail-olekstysh@gmail.com/</a><br></div><div class=3D"gmail_attr"><a href=3D=
"https://lore.kernel.org/xen-devel/1649964960-24864-1-git-send-email-olekst=
ysh@gmail.com/">https://lore.kernel.org/xen-devel/1649964960-24864-1-git-se=
nd-email-olekstysh@gmail.com/</a><br></div><div class=3D"gmail_attr"><br></=
div></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div><div dir=3D"ltr"><d=
iv><div dir=3D"ltr"><span style=3D"background-color:rgb(255,255,255)"><font=
 size=3D"2"><span style=3D"color:rgb(51,51,51);font-family:Arial,sans-serif=
">Regards,</span></font></span></div><div dir=3D"ltr"><br></div><div dir=3D=
"ltr"><div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"=
2">Oleksandr Tyshchenko</font></span></div></div></div></div></div></div></=
div></div>

--000000000000d8536405dca2cafd--


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 20:39:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 20:39:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305117.519984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf6Fg-0002sh-LO; Thu, 14 Apr 2022 20:39:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305117.519984; Thu, 14 Apr 2022 20:39:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf6Fg-0002sa-He; Thu, 14 Apr 2022 20:39:40 +0000
Received: by outflank-mailman (input) for mailman id 305117;
 Thu, 14 Apr 2022 20:39:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qEdm=UY=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nf6Ff-0002sE-60
 for xen-devel@lists.xenproject.org; Thu, 14 Apr 2022 20:39:39 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ff54faeb-bc32-11ec-8fbe-03012f2f19d4;
 Thu, 14 Apr 2022 22:39:37 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 7600D61B98;
 Thu, 14 Apr 2022 20:39:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CDE4C385A1;
 Thu, 14 Apr 2022 20:39:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff54faeb-bc32-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649968774;
	bh=R1wd4B+cBCa/YB/NXjO8virq7TohKQ4D10Gi/ExkIP8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ayshRXFHMAzv6sXVHiluh0E0+yR3ug3hrkX+Pwwyh/10waIWmmQIZPng1coPtEJiX
	 5EQ1x8Sr1J6rLi7YcQg+3yY13rd79e08MXc/HwS4OuCDoi1NBqtQoxYideK4is9yVs
	 MbwzPoAnXWUOZrphp7y4uJCPQ6Ne/dfh2Vvn33T0aWNpIgMnKH9akO7mvX6Bk5hDNC
	 u3Da5v4sAoc2Fnje0iZ0eqg2KXRPUBeAXO6S6W/konKIbp/zOv/hjLZw5lDXhDHhOj
	 /XVm08oI1puCqdCeF4yVBiwPIv5NJX/8sMFkHjZxER1ZkYl0gq2xQlOIIGyuHT61Fq
	 1S2HAL+i+20NA==
Date: Thu, 14 Apr 2022 13:39:23 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <Rahul.Singh@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>, 
    "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>, hch@lst.de
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
In-Reply-To: <8C511888-6183-421E-A4C7-B271DAF46696@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com> <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop> <8C511888-6183-421E-A4C7-B271DAF46696@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-332270353-1649968266=:894007"
Content-ID: <alpine.DEB.2.22.394.2204141331150.894007@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-332270353-1649968266=:894007
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204141331151.894007@ubuntu-linux-20-04-desktop>

+ Christoph

Hi Christoph,

Rahul is seeing a swiotlb-xen failure on Ampere Altra triggered by the
NVME driver doing DMA. There is stacktrace below.

I asked Rahul to check the code path taken with and without Xen and it
looks like everything checks out. See below.


On Thu, 14 Apr 2022, Rahul Singh wrote:
> Hi Stefano,
> 
> > On 13 Apr 2022, at 10:24 pm, Stefano Stabellini <sstabellini@kernel.org> wrote:
> >
> > On Wed, 13 Apr 2022, Rahul Singh wrote:
> >> Hello All,
> >>
> >> We are trying to boot the Xen 4.15.1 and dom0 Linux Kernel (5.10.27-ampere-lts-standard from [1] ) on Ampere Altra / AVA Developer
> Platform
> >> [2] with ACPI.
> >>
> >> NVMe storage is connected to PCIe. Native Linux kernel boot fine and also I am able to detect and access NVMe storage.
> >> However, during XEN boot when NVME driver is requesting the DMA buffer we are observing the Oops with XEN.
> >
> > Hi Rahul,
> >
> > Thanks for the bug report. More comments below.
> >
> >
> >
> >> Please find the attached detail logs for Xen and dom0 booting.
> >>
> >> Snip from logs:
> >> (XEN) d0v0: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0
> >> [  0.000000] Booting Linux on physical CPU 0x0000000000 [0x413fd0c1]
> >> [  0.000000] Linux version 5.10.27-ampere-lts-standard (oe-user@oe-host) (aarch64-poky-linux-gcc (GCC) 11.2.0, GNU ld (GNU Binutils)
> >> 2.37.20210721) #1 SMP PREEMPT Sat Sep 18 06:01:59 UTC 2021
> >> [  0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found
> >> [  0.000000] efi: EFI v2.50 by Xen
> >> [  0.000000] efi: ACPI 2.0=0x807f66cece8
> >> [  0.000000] ACPI: Early table checksum verification disabled
> >> [  0.000000] ACPI: RSDP 0x00000807F66CECE8 000024 (v02 Ampere)
> >> [  0.000000] ACPI: XSDT 0x00000807F66CEC38 0000AC (v01 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: FACP 0x00000807F66CE000 000114 (v06 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: DSDT 0x00000807F8DB0018 02C19E (v02 Ampere Jade  00000001 INTL 20201217)
> >> [  0.000000] ACPI: BERT 0x00000807FA0DFF98 000030 (v01 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: DBG2 0x00000807FA0DFA98 00005C (v00 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: GTDT 0x00000807FA0DE998 000110 (v03 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: SPCR 0x00000807FA0DFE18 000050 (v02 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: EINJ 0x00000807FA0DF598 000150 (v01 Ampere Altra  00000001 INTL 20201217)
> >> [  0.000000] ACPI: HEST 0x00000807FA0DEB18 0001F4 (v01 Ampere Altra  00000001 INTL 20201217)
> >> [  0.000000] ACPI: SSDT 0x00000807FA0DFA18 00002D (v02 Ampere Altra  00000001 INTL 20201217)
> >> [  0.000000] ACPI: TPM2 0x00000807FA0DFD18 00004C (v04 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: MCFG 0x00000807FA0DF718 00007C (v01 Ampere Altra  00000001 AMP. 01000013)
> >> [  0.000000] ACPI: IORT 0x00000807FA0DEF18 0003DC (v00 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: APIC 0x00000807F66CE118 000AF4 (v05 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: PPTT 0x00000807FA0D8618 004520 (v02 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: SLIT 0x00000807FA0DFD98 00002D (v01 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: SRAT 0x00000807FA0DCE18 000370 (v03 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: PCCT 0x00000807FA0DE318 000576 (v02 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: STAO 0x00000807F66CEC10 000025 (v01 Ampere Altra  00000002 AMP. 01000013)
> >> [  0.000000] ACPI: SPCR: console: pl011,mmio32,0x100002600000,115200
> >> [  0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x88300000-0x883fffff]
> >> [  0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x90000000-0xffffffff]
> >> [  0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x80000000000-0x8007fffffff]
> >> [  0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x80100000000-0x807ffffffff]
> >> [  0.000000] NUMA: NODE_DATA [mem 0x8079fbf5e00-0x8079fbf7fff]
> >> [  0.000000] Zone ranges:
> >> [  0.000000]  DMA  [mem 0x0000000098000000-0x00000000ffffffff]
> >> [  0.000000]  DMA32  empty
> >> [  0.000000]  Normal  [mem 0x0000000100000000-0x00000807fa0dffff]
> >> [  0.000000] Movable zone start for each node
> >> [  0.000000] Early memory node ranges
> >> ….
> >>
> >> [  0.000000] Dentry cache hash table entries: 262144 (order: 9, 2097152 bytes, linear)
> >> [  0.000000] Inode-cache hash table entries: 131072 (order: 8, 1048576 bytes, linear)
> >> [  0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off
> >> [  0.000000] software IO TLB: mapped [mem 0x00000000f4000000-0x00000000f8000000] (64MB)
> >> [  0.000000] Memory: 1929152K/2097412K available (13568K kernel code, 1996K rwdata, 3476K rodata, 4160K init, 822K bss, 168260K
> reserved,
> >> 0K cma-reserved)
> >> [  0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=32, Nodes=1
> >> [  0.000000] ftrace: allocating 41306 entries in 162 pages
> >> ….
> >>
> >> ….
> >> [  12.599484] loop: module loaded
> >> [  12.603160] nvme nvme0: pci function 0005:04:00.0
> >> [  12.608129] igb: Intel(R) Gigabit Ethernet Network Driver
> >> [  12.613495] igb: Copyright (c) 2007-2014 Intel Corporation.
> >> [  12.613636] nvme nvme0: missing or invalid SUBNQN field.
> >> [  12.625941] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008
> >> [  12.634726] Mem abort info:
> >> [  12.637520]  ESR = 0x96000044
> >> [  12.640646]  EC = 0x25: DABT (current EL), IL = 32 bits
> >> [  12.646055]  SET = 0, FnV = 0
> >> [  12.649153]  EA = 0, S1PTW = 0
> >> [  12.652365] Data abort info:
> >> [  12.655314]  ISV = 0, ISS = 0x00000044
> >> [  12.659231]  CM = 0, WnR = 1
> >> [  12.662260] [0000000000000008] user address but active_mm is swapper
> >> [  12.668724] Internal error: Oops: 96000044 [#1] PREEMPT SMP
> >> [  12.674358] Modules linked in:
> >> [  12.677455] CPU: 0 PID: 7 Comm: kworker/u64:0 Tainted: G  W  5.10.27-ampere-lts-standard #1
> >> [  12.687083] Workqueue: nvme-reset-wq nvme_reset_work
> >> [  12.692059] pstate: 60c00085 (nZCv daIf +PAN +UAO -TCO BTYPE=--)
> >> [  12.698149] pc : steal_suitable_fallback+0x138/0x2f0
> >> [  12.703170] lr : steal_suitable_fallback+0x1bc/0x2f0
> >> [  12.708203] sp : ffff80001196b820
> >> [  12.711569] x29: ffff80001196b820 x28: 0000000000000000
> >> [  12.716975] x27: 0000000000000000 x26: ffff8000114dbcb0
> >> [  12.722357] x25: fffffdffffe00000 x24: 0000000000000001
> >> [  12.727740] x23: 0000000000000000 x22: fffffe201bf60000
> >> [  12.733120] x21: ffff08071fbf6980 x20: 0000000000000901
> >> [  12.738502] x19: 0000000000080000 x18: ffffffffffffffff
> >> [  12.743884] x17: 0000000000000000 x16: 0000000000000012
> >> [  12.749266] x15: ffff08070508c683 x14: 0000000000000058
> >> [  12.754648] x13: 00000000000000c0 x12: 0000000000000000
> >> [  12.760030] x11: 0000000000000400 x10: 000000000000000c
> >> [  12.765412] x9 : ffff800010039d58 x8 : 0000000020000000
> >> [  12.770794] x7 : 0000000000000018 x6 : ffff800011750890
> >> [  12.776176] x5 : ffff800011750878 x4 : 0000000000000000
> >> [  12.781558] x3 : 0000000000000000 x2 : 0000000000000000
> >> [  12.786940] x1 : 0000000000000200 x0 : 0000000000000000
> >> [  12.792322] Call trace:
> >> [  12.794806]  steal_suitable_fallback+0x138/0x2f0
> >> [  12.799520]  get_page_from_freelist+0xe30/0x12a0
> >> [  12.804207]  __alloc_pages_nodemask+0x148/0xe00
> >> [  12.808809]  __dma_direct_alloc_pages+0xa4/0x1d0
> >> [  12.813496]  dma_direct_alloc+0x1d8/0x340
> >> [  12.817571]  xen_swiotlb_alloc_coherent+0x68/0x370
> >> [  12.822439]  dma_alloc_attrs+0xe8/0xf0
> >> [  12.826246]  nvme_reset_work+0x1030/0x1520
> >> [  12.830417]  process_one_work+0x1dc/0x4bc
> >> [  12.834495]  worker_thread+0x144/0x470
> >> [  12.838313]  kthread+0x14c/0x160
> >> [  12.841604]  ret_from_fork+0x10/0x38
> >> [  12.845255] Code: a94082c4 d37ef463 cb3c4063 8b3c4042 (f9000480)
> >> [  12.851447] ---[ end trace f68728a0d3053b72 ]---
> >> [  12.856117] note: kworker/u64:0[7] exited with preempt_count
> >
> > xen_swiotlb_alloc_coherent calls dma_direct_alloc which fails for the
> > device.
> >
> > Without swiotlb_xen, dma_alloc_attrs would do:
> >
> >        if (dma_alloc_direct(dev, ops))
> >                cpu_addr = dma_direct_alloc(dev, size, dma_handle, flag, attrs);
> >        else if (ops->alloc)
> >                cpu_addr = ops->alloc(dev, size, dma_handle, flag, attrs);
> >
> > dma_alloc_direct is the very same call that fails when called from
> > xen_swiotlb_alloc_coherent. So it must be that the path meant to be
> > taken is ops->alloc instead.
> >
> > ops->alloc is the dma_ops function to allocate a coherent buffer.
> > When swiotlb-xen is enabled, it points to xen_swiotlb_alloc_coherent.
> > Often dma_ops is NULL when Xen is disabled.
> >
> > I think the most likely explanation is that the nvme device require a
> > specific dma_ops. When swiotlb-xen is enabled, it gets overwritten by
> > arch/arm64/mm/dma-mapping.c:arch_setup_dma_ops.
> >
> > Can you double-check this theory by adding a few printks in
> > arch/arm64/mm/dma-mapping.c:arch_setup_dma_ops, to check the dma_ops
> > used when !CONFIG_XEN, and also in kernel/dma/mapping.c:dma_alloc_attrs
> > to check the code path taken when !CONFIG_XEN?
> 
> I checked the code path when !CONFID_XEN and SMMU is not enabled in linux, code path is:
>         dma_alloc_attrs() -> dma_alloc_direct()
> and there is no issue in booting and allocating a coherent buffer.
> 
> When !CONFIG_XEN and SMMU is enabled code path is:
>         dma_alloc_attrs()-> ops->alloc -> iommu_dma_alloc()
> and there is no issue in booting and allocating a coherent buffer in this case also.
> 
> When Xen is enabled code path is:
>         dma_alloc_attrs()-> ops->alloc() -> xen_swiotlb_alloc_coherent() -> dma_alloc_direct()
> in this case allocating the coherent buffer failed.
> 
> Only difference I see is the size argument for dma_alloc_direct() in Xen case but I don’t think
> that is causing the issue there is something else causing the issue maybe from
> where the coherent memory is allocated.
>        
>         /* Convert the size to actually allocated. */
>         size = 1UL << (order + XEN_PAGE_SHIFT);
> 
> 
> Please find the attached detailed logs for each case.


OK, now we know that the code path with Xen is correct and it is the
same code path taken (dma_alloc_direct) as when !CONFIG_XEN and !SMMU.
That is how it should be.

I cannot explain why dma_alloc_direct() would fail when called from
xen_swiotlb_alloc_coherent(), but it would succeed when called from
dma_alloc_attrs() without Xen.

I am not aware of any restrictions that xen or swiotlb-xen would
introduce in that regard. Unless you are just running out of memory
because dom0_mem too low.
--8323329-332270353-1649968266=:894007--


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 20:59:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 20:59:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305122.519995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf6YQ-0005Hd-8y; Thu, 14 Apr 2022 20:59:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305122.519995; Thu, 14 Apr 2022 20:59:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf6YQ-0005HW-5s; Thu, 14 Apr 2022 20:59:02 +0000
Received: by outflank-mailman (input) for mailman id 305122;
 Thu, 14 Apr 2022 20:59:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf6YO-0005HM-Ju; Thu, 14 Apr 2022 20:59:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf6YO-0002qH-GY; Thu, 14 Apr 2022 20:59:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf6YO-0005gh-3i; Thu, 14 Apr 2022 20:59:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf6YO-0006TA-3D; Thu, 14 Apr 2022 20:59:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cb8Dme/rG4LYOjCCo+nHsU3hYW3pjafgYSICZr4E+sw=; b=XpC8OYRtJuBEijgbzM6+cED4bd
	7ea1d0Cj0KiDuFmpffA5XGCtN7vFQ4Mnz2BKk663se9ufHC9wlFuzmM1ZMnwTtrCc6u+lQJPjHLwG
	XKZCLMrvTnhReeRir1a0RCVow5UE2coc1UoLtMWlyG9InKsgFGJSBYIObpfY5i7IhYRw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169405-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169405: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4cfb28f12a8d24cab32d3223275a772227062a39
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 20:59:00 +0000

flight 169405 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169405/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4cfb28f12a8d24cab32d3223275a772227062a39
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  396 attempts
Testing same since   169405  2022-04-14 20:10:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5119 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 21:58:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 21:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305131.520006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf7U8-00030y-J1; Thu, 14 Apr 2022 21:58:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305131.520006; Thu, 14 Apr 2022 21:58:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf7U8-00030r-Fi; Thu, 14 Apr 2022 21:58:40 +0000
Received: by outflank-mailman (input) for mailman id 305131;
 Thu, 14 Apr 2022 21:58:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf7U7-00030h-MC; Thu, 14 Apr 2022 21:58:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf7U7-0003tK-KM; Thu, 14 Apr 2022 21:58:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf7U7-0007zS-98; Thu, 14 Apr 2022 21:58:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf7U7-0007Dq-8i; Thu, 14 Apr 2022 21:58:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=F9AMgZhKN3Uhw7MGcBRARCnxyC5cAMF0R3erPsxFyLk=; b=3SwZ6SSf93hTI6iZw1xjtH6YXT
	+U04fe/J7BDBPG706XSZXDd6VFYjGiIUuns5vlegJEHbnXxDwoDvApdtDX/MzKHXusyErViSrRG9c
	LD84OULy0kBYiDniYNnt3o/jLx2UULo4VI3blINNG3LxlBYQYONlxnnLTMZgl4DJNtZ8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169406-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169406: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4cfb28f12a8d24cab32d3223275a772227062a39
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 21:58:39 +0000

flight 169406 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169406/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4cfb28f12a8d24cab32d3223275a772227062a39
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  397 attempts
Testing same since   169405  2022-04-14 20:10:31 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5119 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 14 23:32:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Apr 2022 23:32:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305145.520016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf8x4-00058q-Pj; Thu, 14 Apr 2022 23:32:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305145.520016; Thu, 14 Apr 2022 23:32:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf8x4-00058j-M8; Thu, 14 Apr 2022 23:32:38 +0000
Received: by outflank-mailman (input) for mailman id 305145;
 Thu, 14 Apr 2022 23:32:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf8x2-00058Z-P3; Thu, 14 Apr 2022 23:32:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf8x2-0005UG-NJ; Thu, 14 Apr 2022 23:32:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf8x2-0002hW-CO; Thu, 14 Apr 2022 23:32:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf8x2-0006lT-Bw; Thu, 14 Apr 2022 23:32:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TTZVSxwTCoBoGa4PvONVkRG2NaKhtk9UYKCj5iDlizY=; b=VbZbpQai5EVNLMEn9ubJ3/p5Do
	qLwgfGTdMHHJNLN5JhiW/8wiPXpflRYYsLZxV8I9/mNzQE/D8rP8X8lfee5tPHPwYYOfxit7l1AGl
	aAmbFCx9rUkt0Bjdeyusuu9gQ0RBb0XZid61IsgRIIJsi4BhRoeg/SYqCdOtj+SMCInM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169407-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169407: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4cfb28f12a8d24cab32d3223275a772227062a39
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Apr 2022 23:32:36 +0000

flight 169407 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169407/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4cfb28f12a8d24cab32d3223275a772227062a39
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  398 attempts
Testing same since   169405  2022-04-14 20:10:31 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5119 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 00:00:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 00:00:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305154.520028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf9O7-0000Z0-9t; Fri, 15 Apr 2022 00:00:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305154.520028; Fri, 15 Apr 2022 00:00:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf9O7-0000Yt-5i; Fri, 15 Apr 2022 00:00:35 +0000
Received: by outflank-mailman (input) for mailman id 305154;
 Fri, 15 Apr 2022 00:00:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf9O5-0000Yj-Un; Fri, 15 Apr 2022 00:00:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf9O5-0006cB-Pa; Fri, 15 Apr 2022 00:00:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf9O5-0003PZ-9v; Fri, 15 Apr 2022 00:00:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf9O5-000740-9R; Fri, 15 Apr 2022 00:00:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xYBy/2vlVdMNsSEOICZ2rWRs3AFB+VRST2VuF9iLYfI=; b=HZ0kW5aS6ERJxEPW1kZFt72P70
	/JNvPcIOhfSfi2USi9tD5kcAKCCPkpbyQLe+9KDAEuNkp61gTK4YCjaQCDUfFxoO43BlcYd8nKjxF
	WbhswTxnVeYzyoA1qs/23bhBnze0GRvt/iu/O5XU7GapXpZi8dlx27hnBKQoiGbhA7tQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169403-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169403: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b9b4c79e58305ac64352286ee5030d193fc8aa22
X-Osstest-Versions-That:
    linux=a19944809fe9942e6a96292490717904d0690c21
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 00:00:33 +0000

flight 169403 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169403/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169346
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169346
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169346
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169346
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169346
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169346
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169346
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169346
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                b9b4c79e58305ac64352286ee5030d193fc8aa22
baseline version:
 linux                a19944809fe9942e6a96292490717904d0690c21

Last test of basis   169346  2022-04-13 01:40:44 Z    1 days
Testing same since   169403  2022-04-14 19:11:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Borislav Petkov <bp@suse.de>
  Dave Wysochanski <dwysocha@redhat.com>
  David Howells <dhowells@redhat.com>
  David Sterba <dsterba@suse.com>
  Dennis Zhou <dennis@kernel.org>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Haowen Bai <baihaowen@meizu.com>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jia-Ju Bai <baijiaju1990@gmail.com>
  Johannes Thumshirn <johannes.thumshirn@wdc.com>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Naohiro Aota <naohiro.aota@wdc.com>
  Nathan Chancellor <nathan@kernel.org>
  Nikolay Borisov <nborisov@suse.com>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Takashi Iwai <tiwai@suse.de>
  Tao Jin <tao-j@outlook.com>
  Tim Crawford <tcrawford@system76.com>
  Yue Hu <huyue2@coolpad.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   a19944809fe9..b9b4c79e5830  b9b4c79e58305ac64352286ee5030d193fc8aa22 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 00:29:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 00:29:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305164.520038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf9pk-00037j-KB; Fri, 15 Apr 2022 00:29:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305164.520038; Fri, 15 Apr 2022 00:29:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nf9pk-00037c-HH; Fri, 15 Apr 2022 00:29:08 +0000
Received: by outflank-mailman (input) for mailman id 305164;
 Fri, 15 Apr 2022 00:29:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf9pj-00037S-J4; Fri, 15 Apr 2022 00:29:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf9pj-00075T-H8; Fri, 15 Apr 2022 00:29:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nf9pj-00042O-4j; Fri, 15 Apr 2022 00:29:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nf9pj-0005mF-4E; Fri, 15 Apr 2022 00:29:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DW9KZjI7AS2Vc6CXYn9jRGFHk0nJP4Qe75fBDopj1dQ=; b=WXuIaUTEjV7U2Nu/q7Q/sMZigL
	9o9vSNRA3onfTqlj/ox3ah59GCABEGrixi7gmjRtPQl5rpH3MYyEBSollBzvVC7IuUAyGIyNDRUhf
	5myF80EFkHBGIlNrypthoeqDFrAZFzr6VELAZHpKpL8F8vFBkVpfjo/NFQGduqztLXYk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169408-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169408: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4cfb28f12a8d24cab32d3223275a772227062a39
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 00:29:07 +0000

flight 169408 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169408/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4cfb28f12a8d24cab32d3223275a772227062a39
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  399 attempts
Testing same since   169405  2022-04-14 20:10:31 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5119 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 00:41:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 00:41:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305175.520049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfA1g-0005V3-Sv; Fri, 15 Apr 2022 00:41:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305175.520049; Fri, 15 Apr 2022 00:41:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfA1g-0005Uw-Q3; Fri, 15 Apr 2022 00:41:28 +0000
Received: by outflank-mailman (input) for mailman id 305175;
 Fri, 15 Apr 2022 00:41:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfA1f-0005Uo-GY
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 00:41:27 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c580f497-bc54-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 02:41:23 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 31A79621C9;
 Fri, 15 Apr 2022 00:41:21 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 379F8C385A1;
 Fri, 15 Apr 2022 00:41:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c580f497-bc54-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1649983280;
	bh=RVExx0DiGUmKDlEdUc5y2CAkuSAq5pnnkv1erAyYRNo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=PQFPsJOjS5XEp0X0nzDCNiC/q4C0TALGQ+gwsXedxgo4im1ono7NAlpdWFxfwBPEy
	 oY8oGD/SU1Gxj9Z2OF4Uf8oUjjvZvA/LMzZ4EM/euIUgX732ny/JEZaf8CvlirndP1
	 VPvpAYL13ChJdQnNXXC04MXyPj2WwRjSlcOvUoTLYALulsb8Z7CaRXzut2/s2LZT0X
	 Xe8QdE18RwsyPT6pEN9/K/f2+ucAw6luTu0M11frx7Cnnv7tRj9BcZOgXH24A40mQf
	 Mt0mheMMt2Asg/X5IhfVLbdi5J9FLZnyHXv/lhCDH8HogiSU0h8dux29NOtmRvbnFk
	 cYkSedocIDjag==
Date: Thu, 14 Apr 2022 17:41:19 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <Wei.Chen@arm.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "julien@xen.org" <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Penny Zheng <Penny.Zheng@arm.com>
Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftB
In-Reply-To: <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop>
References: <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 25 Mar 2022, Wei Chen wrote:
> # Proposal for Porting Xen to Armv8-R64
> 
> This proposal will introduce the PoC work of porting Xen to Armv8-R64,
> which includes:
> - The changes of current Xen capability, like Xen build system, memory
>   management, domain management, vCPU context switch.
> - The expanded Xen capability, like static-allocation and direct-map.
> 
> ***Notes:***
> 1. ***This proposal only covers the work of porting Xen to Armv8-R64***
>    ***single CPU.Xen SMP support on Armv8-R64 relates to Armv8-R***
>    ***Trusted-Frimware (TF-R). This is an external dependency,***
>    ***so we think the discussion of Xen SMP support on Armv8-R64***
>    ***should be started when single-CPU support is complete.***
> 2. ***This proposal will not touch xen-tools. In current stange,***
>    ***Xen on Armv8-R64 only support dom0less, all guests should***
>    ***be booted from device tree.***
> 
> ## Changelogs
> Draft-A -> Draft-B:
> 1. Update Kconfig options usage.
> 2. Update the section for XEN_START_ADDRESS.
> 3. Add description of MPU initialization before parsing device tree.
> 4. Remove CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS.
> 5. Update the description of ioremap_nocache/cache.
> 6. Update about the free_init_memory on Armv8-R.
> 7. Describe why we need to switch the MPU configuration later.
> 8. Add alternative proposal in TODO.
> 9. Add use tool to generate Xen Armv8-R device tree in TODO.
> 10. Add Xen PIC/PIE discussion in TODO.
> 11. Add Xen event channel support in TODO.
> 
> ## Contributors:
> Wei Chen <Wei.Chen@arm.com>
> Penny Zheng <Penny.Zheng@arm.com>
> 
> ## 1. Essential Background
> 
> ### 1.1. Armv8-R64 Profile
> The Armv-R architecture profile was designed to support use cases that
> have a high sensitivity to deterministic execution. (e.g. Fuel Injection,
> Brake control, Drive trains, Motor control etc)
> 
> Arm announced Armv8-R in 2013, it is the latest generation Arm architecture
> targeted at the Real-time profile. It introduces virtualization at the highest
> security level while retaining the Protected Memory System Architecture (PMSA)
> based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-R82,
> which is the first Arm 64-bit Cortex-R processor based on Armv8-R64.
> 
> - The latest Armv8-R64 document can be found here:
>   [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R AArch64 architecture profile](https://developer.arm.com/documentation/ddi0600/latest/).
> 
> - Armv-R Architecture progression:
>   Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64
>   The following figure is a simple comparison of "R" processors based on
>   different Armv-R Architectures.
>   ![image](https://drive.google.com/uc?export=view&id=1nE5RAXaX8zY2KPZ8imBpbvIr2eqBguEB)
> 
> - The Armv8-R architecture evolved additional features on top of Armv7-R:
>     - An exception model that is compatible with the Armv8-A model
>     - Virtualization with support for guest operating systems
>         - PMSA virtualization using MPUs In EL2.
> - The new features of Armv8-R64 architecture
>     - Adds support for the 64-bit A64 instruction set, previously Armv8-R
>       only supported A32.
>     - Supports up to 48-bit physical addressing, previously up to 32-bit
>       addressing was supported.
>     - Optional Arm Neon technology and Advanced SIMD
>     - Supports three Exception Levels (ELs)
>         - Secure EL2 - The Highest Privilege, MPU only, for firmware, hypervisor
>         - Secure EL1 - RichOS (MMU) or RTOS (MPU)
>         - Secure EL0 - Application Workloads
>     - Optionally supports Virtual Memory System Architecture at S-EL1/S-EL0.
>       This means it's possible to run rich OS kernels - like Linux - either
>       bare-metal or as a guest.
> - Differences with the Armv8-A AArch64 architecture
>     - Supports only a single Security state - Secure. There is not Non-Secure
>       execution state supported.
>     - EL3 is not supported, EL2 is mandatory. This means secure EL2 is the
>       highest EL.
>     - Supports the A64 ISA instruction
>         - With a small set of well-defined differences
>     - Provides a PMSA (Protected Memory System Architecture) based
>       virtualization model.
>         - As opposed to Armv8-A AArch64's VMSA based Virtualization
>         - Can support address bits up to 52 if FEAT_LPA is enabled,
>           otherwise 48 bits.
>         - Determines the access permissions and memory attributes of
>           the target PA.
>         - Can implement PMSAv8-64 at EL1 and EL2
>             - Address translation flat-maps the VA to the PA for EL2 Stage 1.
>             - Address translation flat-maps the VA to the PA for EL1 Stage 1.
>             - Address translation flat-maps the IPA to the PA for EL1 Stage 2.
>     - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable.
> 
> ### 1.2. Xen Challenges with PMSA Virtualization
> Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run
> with an MPU and host multiple guest OSes.
> 
> - No MMU at EL2:
>     - No EL2 Stage 1 address translation
>         - Xen provides fixed ARM64 virtual memory layout as basis of EL2
>           stage 1 address translation, which is not applicable on MPU system,
>           where there is no virtual addressing. As a result, any operation
>           involving transition from PA to VA, like ioremap, needs modification
>           on MPU system.
>     - Xen's run-time addresses are the same as the link time addresses.
>         - Enable PIC/PIE (position-independent code) on a real-time target
>           processor probably very rare. Further discussion in 2.1 and TODO
>           sections.
>     - Xen will need to use the EL2 MPU memory region descriptors to manage
>       access permissions and attributes for accesses made by VMs at EL1/0.
>         - Xen currently relies on MMU EL1 stage 2 table to manage these
>           accesses.
> - No MMU Stage 2 translation at EL1:
>     - A guest doesn't have an independent guest physical address space
>     - A guest can not reuse the current Intermediate Physical Address
>       memory layout
>     - A guest uses physical addresses to access memory and devices
>     - The MPU at EL2 manages EL1 stage 2 access permissions and attributes
> - There are a limited number of MPU protection regions at both EL2 and EL1:
>     - Architecturally, the maximum number of protection regions is 256,
>       typical implementations have 32.
>     - By contrast, Xen does not need to consider the number of page table
>       entries in theory when using MMU.
> - The MPU protection regions at EL2 need to be shared between the hypervisor
>   and the guest stage 2.
>     - Requires careful consideration - may impact feature 'fullness' of both
>       the hypervisor and the guest
>     - By contrast, when using MMU, Xen has standalone P2M table for guest
>       stage 2 accesses.
> 
> ## 2. Proposed changes of Xen
> ### **2.1. Changes of build system:**
> 
> - ***Introduce new Kconfig options for Armv8-R64***:
>   Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not
>   expect one Xen binary to run on all machines. Xen images are not common
>   across Armv8-R64 platforms. Xen must be re-built for different Armv8-R64
>   platforms. Because these platforms may have different memory layout and
>   link address.
>     - `ARM64_V8R`:
>       This option enables Armv8-R profile for Arm64. Enabling this option
>       results in selecting MPU. This Kconfig option is used to gate some
>       Armv8-R64 specific code except MPU code, like some code for Armv8-R64
>       only system ID registers access.
> 
>     - `ARM_MPU`
>       This option enables MPU on Armv8-R architecture. Enabling this option
>       results in disabling MMU. This Kconfig option is used to gate some
>       ARM_MPU specific code. Once when this Kconfig option has been enabled,
>       the MMU relate code will not be built for Armv8-R64. The reason why
>       not depends on runtime detection to select MMU or MPU is that, we don't
>       think we can use one image for both Armv8-R64 and Armv8-A64. Another
>       reason that we separate MPU and V8R in provision to allow to support MPU
>       on 32bit Arm one day.
> 
>   ***Try to use `if ( IS_ENABLED(CONFIG_ARMXXXX) )` instead of spreading***
>   ***`#ifdef CONFIG_ARMXXXX` everywhere, if it is possible.***
> 
> - ***About Xen start address for Armv8-R64***:
>   On Armv8-A, Xen has a fixed virtual start address (link address too) on all
>   Armv8-A platforms. In an MMU based system, Xen can map its loaded address
>   to this virtual start address. On Armv8-A platforms, the Xen start address
>   does not need to be configurable. But on Armv8-R platforms, they don't have
>   MMU to map loaded address to a fixed virtual address. And different platforms
>   will have very different address space layout, so it's impossible for Xen to
>   specify a fixed physical address for all Armv8-R platforms' start address.
> 
>   - `XEN_START_ADDRESS`
>     This option allows to set the custom address at which Xen will be
>     linked. This address must be aligned to a page size. Xen's run-time
>     addresses are the same as the link time addresses.
>     ***Notes: Fixed link address means the Xen binary could not be***
>     ***relocated by EFI loader. So in current stage, Xen could not***
>     ***be launched as an EFI application on Armv8-R64.(TODO#3.3)***
> 
>     - Provided by platform files.
>       We can reuse the existed arm/platforms store platform specific files.
>       And `XEN_START_ADDRESS` is one kind of platform specific information.
>       So we can use platform file to define default `XEN_START_ADDRESS` for
>       each platform.
> 
>     - Provided by Kconfig.
>       This option can be an independent or a supplymental option. Users can
>       define a customized `XEN_START_ADDRESS` to override the default value
>       in platform's file.
> 
>     - Generated from device tree by build scripts (optional)
>       Vendors who want to enable Xen on their Armv8-R platforms, they can
>       use some tools/scripts to parse their boards device tree to generate
>       the basic platform information. These tools/scripts do not necessarily
>       need to be integrated in Xen, but Xen can give some recommended
>       configuration. For example, Xen can recommend Armv8-R platforms to use
>       lowest ram start address + 2MB as the default Xen start address.
>       The generated platform files can be placed to arm/platforms for
>       maintenance.
> 
>     - Enable Xen PIC/PIE (optional)
>       We have mentioned about PIC/PIE in section 1.2. With PIC/PIE support,
>       Xen can run from everywhere it has been loaded. But it's rare to use
>       PIC/PIE on a real-time system (code size, more memory access). So a
>       partial PIC/PIE image maybe better (see 3. TODO section). But partial
>       PIC/PIE image may not solve this Xen start address issue.

I like the description of the XEN_START_ADDRESS problem and solutions.

For the initial implementation, a platform file is fine. We need to
start easy.

Afterwards, I think it would be far better to switch to a script that
automatically generates XEN_START_ADDRESS from the host device tree.
Also, if we provide a way to customize the start address via Kconfig,
then the script that reads the device tree could simply output the right
CONFIG_* option for Xen to build. It wouldn't even have to generate an
header file.


> - ***About MPU initialization before parsing device tree***:
>       Before Xen can start parsing information from device tree and use
>       this information to setup MPU, Xen need an initial MPU state. This
>       is because:
>       1. More deterministic: Arm MPU supports background regions, if we
>          don't configure the MPU regions and don't enable MPU. The default
>          MPU background attributes will take effect. The default background
>          attributes are `IMPLEMENTATION DEFINED`. That means all RAM regions
>          may be configured to device memory and RWX. Random values in RAM or
>          maliciously embedded data can be exploited.
>       2. More compatible: On some Armv8-R64 platforms, if MPU is disabled,
>          the `dc zva` instruction will make the system halt (This is one
>          side effect of MPU background attributes, the RAM has been configured
>          as device memory). And this instruction will be embedded in some
>          built-in functions, like `memory set`. If we use `-ddont_use_dc` to
>          rebuild GCC, the built-in functions will not contain `dc zva`.
>          However, it is obviously unlikely that we will be able to recompile
>          all GCC for ARMv8-R64.
> 
>     - Reuse `XEN_START_ADDRESS`
>       In the very beginning of Xen boot, Xen just need to cover a limited
>       memory range and very few devices (actually only UART device). So we
>       can use two MPU regions to map:
>       1. `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or.
>          `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_size`as
>          normal memory.
>       2. `UART` MMIO region base to `UART` MMIO region end to device memory.
>       These two are enough to support Xen run in boot time. And we don't need
>       to provide additional platform information for initial normal memory
>       and device memory regions. In current PoC we have used this option
>       for implementation, and it's the same as Armv8-A.
> 
>     - Additional platform information for initial MPU state
>       Introduce some macros to allow users to set initial normal
>       memory regions:
>       `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END`
>       and device memory:
>       `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END`
>       These macros are the same platform specific information as
>       `XEN_START_ADDRESS`, so the options#1/#2/#3 of generating
>       `XEN_START_ADDRESS` also can be applied to these macros.
>       ***From our current PoC work, we think these macros may***
>       ***not be necessary. But we still place them here to see***
>       ***whether the community will have some different scenarios***
>       ***that we haven't considered.***

I think it is fine for now. And their values could be automatically
generated by the same script that will automatically generate
XEN_START_ADDRESS from the host device tree.


> - ***Define new system registers for compiliers***:
>   Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
>   specific system registers. As Armv8-R64 only have secure state, so
>   at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
>   first GCC version that supports Armv8.4 is GCC 8.1. In addition to
>   these, PMSA of Armv8-R64 introduced lots of MPU related system registers:
>   `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
>   `MPUIR_ELx`. But the first GCC version to support these system registers
>   is GCC 11. So we have two ways to make compilers to work properly with
>   these system registers.
>   1. Bump GCC version to GCC 11.
>      The pros of this method is that, we don't need to encode these
>      system registers in macros by ourselves. But the cons are that,
>      we have to update Makefiles to support GCC 11 for Armv8-R64.
>      1.1. Check the GCC version 11 for Armv8-R64.
>      1.2. Add march=armv8r to CFLAGS for Armv8-R64.
>      1.3. Solve the confliction of march=armv8r and mcpu=generic
>     These changes will affect common Makefiles, not only Arm Makefiles.
>     And GCC 11 is new, lots of toolchains and Distro haven't supported it.
> 
>   2. Encode new system registers in macros ***(preferred)***
>         ```
>         /* Virtualization Secure Translation Control Register */
>         #define VSTCR_EL2  S3_4_C2_C6_2
>         /* Virtualization System Control Register */
>         #define VSCTLR_EL2 S3_4_C2_C0_0
>         /* EL1 MPU Protection Region Base Address Register encode */
>         #define PRBAR_EL1  S3_0_C6_C8_0
>         ...
>         /* EL2 MPU Protection Region Base Address Register encode */
>         #define PRBAR_EL2  S3_4_C6_C8_0
>         ...
>         ```
>      If we encode all above system registers, we don't need to bump GCC
>      version. And the common CFLAGS Xen is using still can be applied to
>      Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS.
>      ***Notes:***
>      ***Armv8-R AArch64 supports the A64 ISA instruction set with***
>      ***some modifications:***
>      ***Redefines DMB, DSB, and adds an DFB. But actually, the***
>      ***encodings of DMB and DSB are still the same with A64.***
>      ***And DFB is an alias of DSB #12. In this case, we think***
>      ***we don't need a new architecture specific flag to***
>      ***generate new instructions for Armv8-R.***

I think that for the initial implementation either way is fine. I agree
that macros would be better than requiring GCC 11.


> ### **2.2. Changes of the initialization process**
> In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent
> initialization process. In addition to some architecutre differences, there
> is no more than reusable code that we will distinguish through CONFIG_ARM_MPU
> or CONFIG_ARM64_V8R. We want most of the initialization code to be reusable
> between Armv8-R64 and Armv8-A64.
> 
> - We will reuse the original head.s and setup.c of Arm. But replace the
>   MMU and page table operations in these files with configuration operations
>   for MPU and MPU regions.
> 
> - We provide a boot-time MPU configuration. This MPU configuration will
>   support Xen to finish its initialization. And this boot-time MPU
>   configuration will record the memory regions that will be parsed from
>   device tree.
> 
>   In the end of Xen initialization, we will use a runtime MPU configuration
>   to replace boot-time MPU configuration. The runtime MPU configuration will
>   merge and reorder memory regions to save more MPU regions for guests.
>   ![img](https://drive.google.com/uc?export=view&id=1wTFyK2XfU3lTlH1PqRDoacQVTwUtWIGU)
> 
> - Defer system unpausing domain after free_init_memory.
>   When Xen initialization is about to end, Xen unpauses guests created
>   during initialization. But this will cause some issues. The unpause
>   action occurs before free_init_memory, however the runtime MPU
>   configuration is built after free_init_memory. In Draft-A, we had
>   discussed whether a zeroing operation for init code and data is
>   enough or not. Because I had just given a security reason for doing
>   free_init_memory on Armv8-R (free_init_memory will drop the Xen init
>   code & data, this will reduce the code an attacker can exploit).
>   But I forgot other very important reasons:
>   1. Init code and data will occupy two MPU regions, because they
>      have different memory attributes.
>   2. It's not easy to zero init code section, because it's readonly.
>      We have to update its MPU region to make this section RW. This
>      operation doesn't do much less than free_init_memory.
>   3. Zeroing init code and data will not release the two MPU regions
>      they are using. This would be a very big waste of a limited MPU
>      regions resource.
>   4. Current free_init_memory operation is reusing lots of Armv8-A
>      codes, except re-add init memory to Xen heap. Becuase we're using
>      static heap on Armv8-R.
> 
>   So if the unpaused guests start executing the context switch at this
>   point, then its MPU context will base on the boot-time MPU configuration.
>   Probably it will be inconsistent with runtime MPU configuration, this
>   will cause unexpected problems (This may not happen in a single core
>   system, but on SMP systems, this problem is forseeable, so we hope to
>   solve it at the beginning).
> 
>   Why we need to switch the MPU configuration that late?
>   Because we need to re-order the MPU regions to reduce complexity of runtime
>   MPU regions management.
>   1. In the boot stage, we allocate MPU regions in sequence until the max.
>      Since a few MPU regions will get removed along the way, they will leave
>      holes there. For example, when heap is ready, fdt will be reallocated
>      in the heap, which means the MPU region for device tree is never needed.
>      And also in free_init_memory, although we do not add init memory to heap,
>      we still reclaim the MPU regions they are using. Without ordering, we
>      may need a bitmap to record such information.
> 
>      In context switch, the memory layout is quite different for guest mode
>      and hypervisor mode. When switching to guest mode, only guest RAM,
>      emulated/passthrough devices, etc could be seen, but in hypervisor mode,
>      all Xen used devices and guests RAM shall be seen. And without reordering,
>      we need to iterate all MPU regions to find according regions to disable
>      during runtime context switch, that's definitely a overhead.
> 
>      So we propose an ordering at the tail of the boot time, to put all fixed
>      MPU regions in the head, like xen text/data, etc, and put all flexible
>      ones at tail, like device memory, guests RAM.
> 
>      Then later in runtime, like context switch, we could easily just disable
>      ones from tail and inserts new ones in the tail.
> 
> ### **2.3. Changes to reduce memory fragmentation**
> 
> In general, memory in Xen system can be classified to 4 classes:
> `image sections`, `heap sections`, `guest RAM`, `boot modules (guest Kernel,
> initrd and dtb)`
> 
> Currently, Xen doesn't have any restriction for users how to allocate
> memory for different classes. That means users can place boot modules
> anywhere, can reserve Xen heap memory anywhere and can allocate guest
> memory anywhere.
> 
> In a VMSA system, this would not be too much of a problem, since the
> MMU can manage memory at a granularity of 4KB after all. But in a
> PMSA system, this will be a big problem. On Armv8-R64, the max MPU
> protection regions number has been limited to 256. But in typical
> processor implementations, few processors will design more than 32
> MPU protection regions. Add in the fact that Xen shares MPU protection
> regions with guest's EL1 Stage 2. It becomes even more important
> to properly plan the use of MPU protection regions.
> 
> - An ideal of memory usage layout restriction:
> ![img](https://drive.google.com/uc?export=view&id=1kirOL0Tx2aAypTtd3kXAtd75XtrngcnW)
> 1. Reserve proper MPU regions for Xen image (code, rodata and data + bss).
> 2. Reserve one MPU region for boot modules.
>    That means the placement of all boot modules, include guest kernel,
>    initrd and dtb, will be limited to this MPU region protected area.
> 3. Reserve one or more MPU regions for Xen heap.
>    On Armv8-R64, the guest memory is predefined in device tree, it will
>    not be allocated from heap. Unlike Armv8-A64, we will not move all
>    free memory to heap. We want Xen heap is dertermistic too, so Xen on
>    Armv8-R64 also rely on Xen static heap feature. The memory for Xen
>    heap will be defined in tree too. Considering that physical memory
>    can also be discontinuous, one or more MPU protection regions needs
>    to be reserved for Xen HEAP.
> 4. If we name above used MPU protection regions PART_A, and name left
>    MPU protection regions PART_B:
>    4.1. In hypervisor context, Xen will map left RAM and devices to PART_B.
>         This will give Xen the ability to access whole memory.
>    4.2. In guest context, Xen will create EL1 stage 2 mapping in PART_B.
>         In this case, Xen just need to update PART_B in context switch,
>         but keep PART_A as fixed.
> 
> ***Notes: Static allocation will be mandatory on MPU based systems***
> 
> **A sample device tree of memory layout restriction**:
> ```
> chosen {
>     ...
>     /*
>      * Define a section to place boot modules,
>      * all boot modules must be placed in this section.
>      */
>     mpu,boot-module-section = <0x10000000 0x10000000>;
>     /*
>      * Define a section to cover all guest RAM. All guest RAM must be located
>      * within this section. The pros is that, in best case, we can only have
>      * one MPU protection region to map all guest RAM for Xen.
>      */
>     mpu,guest-memory-section = <0x20000000 0x30000000>;
>     /*
>      * Define a memory section that can cover all device memory that
>      * will be used in Xen.
>      */
>     mpu,device-memory-section = <0x80000000 0x7ffff000>;
>     /* Define a section for Xen heap */
>     xen,static-mem = <0x50000000 0x20000000>;
> 
>     domU1 {
>         ...
>         #xen,static-mem-address-cells = <0x01>;
>         #xen,static-mem-size-cells = <0x01>;
>         /* Statically allocated guest memory, within mpu,guest-memory-section */
>         xen,static-mem = <0x30000000 0x1f000000>;
> 
>         module@11000000 {
>             compatible = "multiboot,kernel\0multiboot,module";
>             /* Boot module address, within mpu,boot-module-section */
>             reg = <0x11000000 0x3000000>;
>             ...
>         };
> 
>         module@10FF0000 {
>                 compatible = "multiboot,device-tree\0multiboot,module";
>                 /* Boot module address, within mpu,boot-module-section */
>                 reg = <0x10ff0000 0x10000>;
>                 ...
>         };
>     };
> };
> ```
> It's little hard for users to compose such a device tree by hand. Based
> on the discussion of Draft-A, Xen community suggested users to use some
> tools like [imagebuilder](https://gitlab.com/ViryaOS/imagebuilder/-/blob/master/scripts/uboot-script-gen#L390) to generate the above device tree properties.
> Please goto TODO#3.3 section to get more details of this suggestion.

Yes, I think we'll need an ImageBuilder script to populate these entries
automatically. With George's help, I moved ImageBuilder to Xen Project.
This is the new repository: https://gitlab.com/xen-project/imagebuilder

The script to generate mpu,boot-module-section and the other mpu
addresses could be the same ImageBuilder script that generates also
XEN_START_ADDRESS.


> ### **2.4. Changes of memory management**
> Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to
> decouple Xen from VMSA. And give Xen the ablity to manage memory in PMSA.
> 
> 1. ***Use buddy allocator to manage physical pages for PMSA***
>    From the view of physical page, PMSA and VMSA don't have any difference.
>    So we can reuse buddy allocator on Armv8-R64 to manage physical pages.
>    The difference is that, in VMSA, Xen will map allocated pages to virtual
>    addresses. But in PMSA, Xen just convert the pages to physical address.
> 
> 2. ***Can not use virtual address for memory management***
>    As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using virtual
>    address to manage memory. This brings some problems, some virtual address
>    based features could not work well on Armv8-R64, like `FIXMAP`, `vmap/vumap`,
>    `ioremap` and `alternative`.
> 
>    But the functions or macros of these features are used in lots of common
>    code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate code
>    everywhere. In this case, we propose to use stub helpers to make the changes
>    transparently to common code.
>    1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap operations.
>       This will return physical address directly of fixmapped item.
>    2. For `vmap/vumap`, we will use some empty inline stub helpers:
>         ```
>         static inline void vm_init_type(...) {}
>         static inline void *__vmap(...)
>         {
>             return NULL;
>         }
>         static inline void vunmap(const void *va) {}
>         static inline void *vmalloc(size_t size)
>         {
>             return NULL;
>         }
>         static inline void *vmalloc_xen(size_t size)
>         {
>             return NULL;
>         }
>         static inline void vfree(void *va) {}
>         ```
> 
>    3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to always
>       return `NULL`, they could not work well on Armv8-R64 without changes.
>       `ioremap` will return input address directly. But if some extended
>       functions like `ioremap_nocache`, `ioremap_cache`, need to ask a new
>       memory attributes. As Armv8-R doesn't have infinite MPU regions for
>       Xen to split the memory area from its located MPU region and assign
>       the new attributes to it. So in `ioremap_nocache`, `ioremap_cache`,
>       if the input attributes are different from current memory attributes,
>       these functions will return `NULL`.
>         ```
>         static inline void *ioremap_attr(...)
>         {
>             /* We don't have the ability to change input PA cache attributes */
>             if ( CACHE_ATTR_need_change )
>                 return NULL;
>             return (void *)pa;
>         }
>         static inline void __iomem *ioremap_nocache(...)
>         {
>             return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE);
>         }
>         static inline void __iomem *ioremap_cache(...)
>         {
>             return ioremap_attr(start, len, PAGE_HYPERVISOR);
>         }
>         static inline void __iomem *ioremap_wc(...)
>         {
>             return ioremap_attr(start, len, PAGE_HYPERVISOR_WC);
>         }
>         void *ioremap(...)
>         {
>             return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
>         }
> 
>         ```
>     4. For `alternative`, it has been listed in TODO, we will simply disable
>        it on Armv8-R64 in current stage. But simply disable `alternative`
>        will make `cpus_have_const_cap` always return false.
>         ```
>         * System capability check for constant cap */
>         #define cpus_have_const_cap(num) ({                \
>                register_t __ret;                           \
>                                                            \
>                asm volatile (ALTERNATIVE("mov %0, #0",     \
>                                          "mov %0, #1",     \
>                                          num)              \
>                              : "=r" (__ret));              \
>                                                            \
>                 unlikely(__ret);                           \
>                 })
>         ```
>         So, before we have an PMSA `alternative` implementation, we have to
>         implement a separate `cpus_have_const_cap` for Armv8-R64:
>         ```
>         #define cpus_have_const_cap(num) cpus_have_cap(num)
>         ```
> 
> ### **2.5. Changes of guest management**
> Armv8-R64 only supports PMSA in EL2, but it supports configurable
> VMSA or PMSA in EL1. This means Xen will have a new type guest on
> Armv8-R64 - MPU based guest.
> 
> 1. **Add a new domain type - MPU_DOMAIN**
>    When user want to create a guest that will be using MPU in EL1, user
>    should add a `mpu` property in device tree `domU` node, like following
>    example:
>     ```
>     domU2 {
>         compatible = "xen,domain";
>         direct-map;
>         mpu; --> Indicates this domain will use PMSA in EL1.
>         ...
>     };
>     ```
>     Corresponding to `mpu` property in device tree, we also need to introduce
>     a new flag `XEN_DOMCTL_CDF_INTERNAL_mpu` for domain to mark itself as an
>     MPU domain. This flag will be used in domain creation and domain doing
>     vCPU context switch.
>     1. Domain creation need this flag to decide enable PMSA or VMSA in EL1.
>     2. vCPU context switch need this flag to decide save/restore MMU or MPU
>        related registers.
> 
> 2. **Add MPU registers for vCPU to save EL1 MPU context**
>    Current Xen only supports MMU based guest, so it hasn't considered to
>    save/restore MPU context. In this case, we need to add MPU registers
>    to `arch_vcpu`:
>     ```
>     struct arch_vcpu
>     {
>         ...
>     #ifdef CONFIG_ARM_MPU
>         /* Virtualization Translation Control Register */
>         register_t vtcr_el2;
> 
>         /* EL1 MPU regions' registers */
>         pr_t *mpu_regions;
>     #endif
>         ...
>     }
>     ```
>     Armv8-R64 can support max to 256 MPU regions. But that's just theoretical.
>     So we don't want to embed `pr_t mpu_regions[256]` in `arch_vcpu` directly,
>     this will be a memory waste in most cases. Instead we use a pointer in
>     `arch_vcpu` to link with a dynamically allocated `mpu_regions`:
>     ```
>     p->arch.mpu_regions = _xzalloc(sizeof(pr_t) * mpu_regions_count_el1, SMP_CACHE_BYTES);
>     ```
>     As `arch_vcpu` is used very frequently in context switch, so Xen defines
>     `arch_vcpu` as a cache alignment data structure. `mpu_regions` also will
>     be used very frequently in Armv8-R context switch. So we use `_xzalloc`
>     to allocate `SMP_CACHE_BYTES` alignment memory for `mpu_regions`.
> 
>     `mpu_regions_count_el1` can be detected from `MPUIR_EL1` system register
>     in Xen boot stage. The limitation is that, if we define a static
>     `arch_vcpu`, we have to allocate `mpu_regions` before using it.
> 
> 3. **MPU based P2M table management**
>    Armv8-R64 EL2 doesn't have EL1 stage 2 address translation. But through
>    PMSA, it still has the ability to control the permissions and attributes
>    of EL1 stage 2. In this case, we still hope to keep the interface
>    consistent with MMU based P2M as far as possible.
> 
>    p2m->root will point to an allocated memory. In Armv8-A64, this memory
>    is used to save the EL1 stage 2 translation table. But in Armv8-R64,
>    this memory will be used to store EL2 MPU protection regions that are
>    used by guest. During domain creation, Xen will prepare the data in
>    this memory to make guest can access proper RAM and devices. When the
>    guest's vCPU will be scheduled in, this data will be written to MPU
>    protection region registers.
> 
> ### **2.6. Changes of exception trap**
> As Armv8-R64 has compatible excetpion mode with Armv8-A64, so we can reuse most
> of Armv8-A64's exception trap & handler code. But except the trap based on EL1
> stage 2 translation abort.
> 
> In Armv8-A64, we use `FSC_FLT_TRANS`
> ```
>     case FSC_FLT_TRANS:
>         ...
>         if ( is_data )
>         {
>             enum io_state state = try_handle_mmio(regs, hsr, gpa);
>             ...
>         }
> ```
> But for Armv8-R64, we have to use `FSC_FLT_PERM`
> ```
>     case FSC_FLT_PERM:
>         ...
>         if ( is_data )
>         {
>             enum io_state state = try_handle_mmio(regs, hsr, gpa);
>             ...
>         }
> ```
> 
> ### **2.5. Changes of device driver**
> Because Armv8-R64 only has single secure state, this will affect some
> devices that have two secure state, like GIC. But fortunately, most
> vendors will not link a two secure state GIC to Armv8-R64 processors.
> Current GIC driver can work well with single secure state GIC for Armv8-R64.
> 
> ### **2.7. Changes of virtual device**
> Currently, we only support pass-through devices in guest. Becuase event
> channel, xen-bus, xen-storage and other advanced Xen features haven't been
> enabled in Armv8-R64.
> 
> ## 3. TODO
> This section describes some features that are not currently implemented in
> the PoC. Those features are things that should be looked in a second stage
> and will not be part of the initial support of MPU/Armv8-R. Those jobs could
> be done by Arm or any Xen contributors.
> 
> ### 3.1. Alternative framework support
>     On Armv8-A system, `alternative` is depending on `VMAP` function to remap
>     a code section to a new read/write virtual address. But on Armv8-R, we do
>     not have virtual address to do remap. So as an alternative method, we will
>     disable the MPU to make all RAM `RWX` in "apply alternative all patches"
>     progress temporarily.
> 
>     1. Disable MPU -> Code section becomes RWX.
>     2. Apply alternative patches to Xen text.
>     3. Enable MPU -> Code section restores to RX.
> 
>     All memory is RWX, there may be some security risk. But, because
>     "alternative apply patches" happens in Xen init stage, it propoably
>     doesn't matter as much.
> 
> ### 3.2. Xen Event Channel Support
>     In Current RFC patches we haven't enabled the event channel support.
>     But I think it's good opportunity to do some discussion in advanced.
>     On Armv8-R, all VMs are native direct-map, because there is no stage2
>     MMU translation. Current event channel implementation depends on some
>     shared pages between Xen and guest: `shared_info` and per-cpu `vcpu_info`.
> 
>     For `shared_info`, in current implementation, Xen will allocate a page
>     from heap for `shared_info` to store initial meta data. When guest is
>     trying to setup `shared_info`, it will allocate a free gfn and use a
>     hypercall to setup P2M mapping between gfn and `shared_info`.
> 
>     For direct-mapping VM, this will break the direct-mapping concept.
>     And on an MPU based system, like Armv8-R system, this operation will
>     be very unfriendly. Xen need to pop `shared_info` page from Xen heap
>     and insert it to VM P2M pages. If this page is in the middle of
>     Xen heap, this means Xen need to split current heap and use extra
>     MPU regions. Also for the P2M part, this page is unlikely to form
>     a new continuous memory region with the existing p2m pages, and Xen
>     is likely to need another additional MPU region to set it up, which
>     is obviously a waste for limited MPU regions. And This kind of dynamic
>     is quite hard to imagine on an MPU system.

Yeah, it doesn't make any sense for MPU systems


>     For `vcpu_info`, in current implementation, Xen will store `vcpu_info`
>     meta data for all vCPUs in `shared_info`. When guest is trying to setup
>     `vcpu_info`, it will allocate memory for `vcpu_info` from guest side.
>     And then guest will use hypercall to copy meta data from `shared_info`
>     to guest page. After that both Xen `vcpu_info` and guest `vcpu_info`
>     are pointed to the same page that allocated by guest.
> 
>     This implementation has serval benifits:
>     1. There is no waste memory. No extra memory will be allocated from Xen heap.
>     2. There is no P2M remap. This will not break the direct-mapping, and
>        is MPU system friendly.
>     So, on Armv8-R system, we can still keep current implementation for
>     per-cpu `vcpu_info`.
> 
>     So, our proposal is that, can we reuse current implementation idea of
>     `vcpu_info` for `shared_info`? We still allocate one page for
>     `d->shared_info` at domain construction for holding some initial meta-data,
>     using alloc_domheap_pages instead of alloc_xenheap_pages and
>     share_xen_page_with_guest. And when guest allocates a page for
>     `shared_info` and use hypercall to setup it,  We copy the initial data from
>     `d->shared_info` to it. And after copy we can update `d->shared_info` to point
>     to guest allocated 'shared_info' page. In this case, we don't have to think
>     about the fragmentation of Xen heap and p2m and the extra MPU regions.

Yes, I think that would work.

Also I think it should be possible to get rid of the initial
d->shared_info allocation in Xen, given that d->shared_info is for the
benefit of the guest and the guest cannot access it until it makes the
XENMAPSPACE_shared_info hypercall.


>     But here still has some concerns:
>     `d->shared_info` in Xen is accessed without any lock. So it will not be
>     that simple to update `d->shared_info`. It might be possible to protect
>     d->shared_info (or other structure) with a read-write lock.
> 
>     Do we need to add PGT_xxx flags to make it global and stay as much the
>     same with the original op, a simple investigation tells us that it only
>     be referred in `get_page_type`. Since ARM doesn't care about typecounts
>     and always return 1, it doesn't have too much impact.
>
> ### 3.3. Xen Partial PIC/PIE
>     As we have described in `XEN_START_ADDRESS` section. PIC/PIE can solve
>     different platforms have different `XEN_START_ADDRESS` issue. But we
>     also describe some issues to use PIC/PIE in real time systems like
>     Armv8-R platforms.
> 
>     But a partial PIC/PIE support may be needed for Armv8-R. Because Arm
>     [EBBR](https://arm-software.github.io/ebbr/index.html) require Xen
>     on Armv8-R to support EFI boot service. Due to lack of relocation
>     capability, EFI loader could not launch xen.efi on Armv8-R. So maybe
>     we still need a partially supported PIC/PIE. Only some boot code
>     support PIC/PIE to make EFI relocation happy. This boot code will
>     help Xen to check its loaded address and relocate Xen image to Xen's
>     run-time address if need.
> 
> ### 3.4. A tool to generate Armv8-R Xen device tree
> 1. Use a tool to generate above device tree property.
>    This tool will have some similar inputs as below:
>    ---
>    DEVICE_TREE="fvp_baremetal.dtb"
>    XEN="4.16-2022.1/xen"
> 
>    NUM_DOMUS=1
>    DOMU_KERNEL[0]="4.16-2022.1/Image-domU"
>    DOMU_RAMDISK[0]="4.16-2022.1/initrd.cpio"
>    DOMU_PASSTHROUGH_DTB[0]="4.16-2022.1/passthrough-example-dev.dtb"
>    DOMU_RAM_BASE[0]=0x30000000
>    DOMU_RAM_SIZE[0]=0x1f000000
>    ---
>    Using above inputs, the tool can generate a device tree similar as
>    we have described in sample.
> 
>    - `mpu,guest-memory-section`:
>    This section will cover all guests' RAM (`xen,static-mem` defined regions
>    in all DomU nodes). All guest RAM must be located within this section.
>    In the best case, we can only have one MPU protection region to map all
>    guests' RAM for Xen.
> 
>    If users set `DOMU_RAM_BASE` and `DOMU_RAM_SIZE`, these will be converted
>    to the base and size of `xen,static-mem`. This tool will scan all
>    `xen, static-mem` in DomU nodes to determin the base and size of
>    `mpu,guest-memory-section`. If there is any other kind of memory usage
>    has been detected in this section, this tool can report an error.
>    Except build time check, Xen also need to do runtime check to prevent a
>    bad device tree that generated by malicious tools.
> 
>    If users set `DOMU_RAM_SIZE` only, this will be converted to the size of
>    `xen,static-mem` only. Xen will allocate the guest memory in runtime, but
>    not from Xen heap. `mpu,guest-memory-section` will be caculated in runtime
>    too. The property in device tree doesn't need or will be ignored by Xen.

I am fine with this. You should also know that there was a recent
discussion about adding something like:

# address size address size ...
DOMU_STATIC_MEM_RANGES[0]="0xe000000 0x1000000 0xa0000000 0x30000000"

to the ImageBuilder config file.


>    - `mpu,boot-module-section`:
>    This section will be used to store the boot modules like DOMU_KERNEL,
>    DOMU_RAMDISK, and DOMU_PASSTHROUGH_DTB. Xen keeps all boot modules in
>    this section to meet the requirment of DomU restart on Armv8-R. In
>    current stage, we don't have a privilege domain like Dom0 that can
>    access filesystem to reload DomU images.
> 
>    And in current Xen code, the base and size are mandatory for boot modules
>    If users don't specify the base of each boot module, the tool will
>    allocte a base for each module. And the tool will generate the
>    `mpu,boot-module-section` region, when it finishs boot module memory
>    allocation.
> 
>    Users also can specify the base and size of each boot module, these will
>    be converted to the base and size of module's `reg` directly. The tool
>    will scan all modules `reg` in DomU nodes to generate the base and size of
>    `mpu,boot-module-section`. If there is any kind of other memory usage
>    has been detected in this section, this tool can report an error.
>    Except build time check, Xen also need to do runtime check to prevent a
>    bad device tree that generated by malicious tools.

Xen should always check for the validity of its input. However I should
point out that there is no "malicious tool" in this picture because a
malicious entity with access to the tool would also have access to Xen
directly, so they might as well replace the Xen binary.


>    - `mpu,device-memory-section`:
>    This section will cover all device memory that will be used in Xen. Like
>    `UART`, `GIC`, `SMMU` and other devices. We haven't considered multiple
>    `mpu,device-memory-section` scenarios. The devices' memory and RAM are
>    interleaving in physical address space, it would be required to use
>    multiple `mpu,device-memory-section` to cover all devices. This layout
>    is common on Armv8-A system, especially in server. But it's rare in
>    Armv8-R. So in current stage, we don't want to allow multiple
>    `mpu,device-memory-section`. The tool can scan baremetal device tree
>    to sort all devices' memory ranges. And calculate a proper region for
>    `mpu,device-memory-section`. If it find Xen need multiple
>    `mpu,device-memory-section`, it can report an unsupported error.
> 
> 2. Use a tool to generate device tree property and platform files
>    This opinion still uses the same inputs as opinion#1. But this tool only
>    generates `xen,static-mem` and `module` nodes in DomU nodes, it will not
>    generate `mpu,guest-memory-section`, `mpu,boot-module-section` and
>    `mpu,device-memory-section` properties in device tree. This will
>    generate following macros:
>    `MPU_GUEST_MEMORY_SECTION_BASE`, `MPU_GUEST_MEMORY_SECTION_SIZE`
>    `MPU_BOOT_MODULE_SECTION_BASE`, `MPU_BOOT_MODULE_SECTION_SIZE`
>    `MPU_DEVICE_MEMORY_SECTION_BASE`, `MPU_DEVICE_MEMORY_SECTION_SIZE`
>    in platform files in build time. In runtime, Xen will skip the device
>    tree parsing for `mpu,guest-memory-section`, `mpu,boot-module-section`
>    and `mpu,device-memory-section`. And instead Xen will use these macros
>    to do runtime check.
>    But, this also means these macros only exist in local build system,
>    these macros will not be maintained in Xen repo.

Yes this makes sense to me.

I think we should add both scripts to the imagebuilder repository. This
way, they could share code easily, and we can keep the documentation in
a single place.


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 01:12:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 01:12:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305182.520061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfAVN-0007CS-9G; Fri, 15 Apr 2022 01:12:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305182.520061; Fri, 15 Apr 2022 01:12:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfAVN-0007CL-6G; Fri, 15 Apr 2022 01:12:09 +0000
Received: by outflank-mailman (input) for mailman id 305182;
 Fri, 15 Apr 2022 01:12:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfAVM-0007CB-0X; Fri, 15 Apr 2022 01:12:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfAVL-0005eI-V7; Fri, 15 Apr 2022 01:12:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfAVL-0005CB-FX; Fri, 15 Apr 2022 01:12:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfAVL-0003Kd-F2; Fri, 15 Apr 2022 01:12:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2E8XR9L+cOL7/YHPWCHEI7jcgK0jG2ZT4MhsLHjP1FQ=; b=2uGBYz3xUpbX4Q3pHuQzgxlKpL
	HIAM6o1pXfkfgCBV1wU63/2KWbnUmV1ctDs0eQqXJEEDzUrxnbTZGt0r8Odx/30n2YzHqKhZphbkh
	CD4MBkaOz8CDO/unNy5SvUhxFK3LXyqBZU9hXaCWLOgq70j43ROvBfKpZoWhcsBBw/mI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169410-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169410: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4cfb28f12a8d24cab32d3223275a772227062a39
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 01:12:07 +0000

flight 169410 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169410/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4cfb28f12a8d24cab32d3223275a772227062a39
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   44 days  400 attempts
Testing same since   169405  2022-04-14 20:10:31 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5119 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 02:29:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 02:29:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305192.520072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfBiS-0006F3-BZ; Fri, 15 Apr 2022 02:29:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305192.520072; Fri, 15 Apr 2022 02:29:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfBiS-0006Ec-42; Fri, 15 Apr 2022 02:29:44 +0000
Received: by outflank-mailman (input) for mailman id 305192;
 Fri, 15 Apr 2022 02:29:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfBiQ-0006EC-OS; Fri, 15 Apr 2022 02:29:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfBiQ-0007Of-Ih; Fri, 15 Apr 2022 02:29:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfBiQ-0008V7-Aq; Fri, 15 Apr 2022 02:29:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfBiQ-0007IE-AQ; Fri, 15 Apr 2022 02:29:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=i+QeNocvlrVaxfdCjfxSO6wHkyaJrb6YCcsSmOQ26VQ=; b=ndqZN+KPyDprT6OuGeDvKcTT7l
	gW2vo7MVIJ6f525KoHHbftAsCOLRoHSCjh9sPUoMy8q3/wKe2p1lsqhv8zH86RgM4ZU+Oh4hXA3G+
	V/tVdcXXI3C8WFbMQkADknsCVES561OMOYKZlyYrQbsLro8Ns1TyLcHT+u+mWMpZ4mpI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169411-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169411: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4cfb28f12a8d24cab32d3223275a772227062a39
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 02:29:42 +0000

flight 169411 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169411/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4cfb28f12a8d24cab32d3223275a772227062a39
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  401 attempts
Testing same since   169405  2022-04-14 20:10:31 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5119 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 03:46:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 03:46:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305203.520082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfCur-0005jD-QP; Fri, 15 Apr 2022 03:46:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305203.520082; Fri, 15 Apr 2022 03:46:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfCur-0005j6-N9; Fri, 15 Apr 2022 03:46:37 +0000
Received: by outflank-mailman (input) for mailman id 305203;
 Fri, 15 Apr 2022 03:46:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfCuq-0005iw-4B; Fri, 15 Apr 2022 03:46:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfCuq-0000Ek-2S; Fri, 15 Apr 2022 03:46:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfCup-0004Ui-NP; Fri, 15 Apr 2022 03:46:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfCup-0006MN-Mw; Fri, 15 Apr 2022 03:46:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aV2BRrLuzlB6tYnvLU0mo+7WmB0tZmwWazxCYuzHnMg=; b=z7/ZE0TFm+NpMm0phP+su0Zh8U
	nlqkRKdF7akaNyUOCGUL3ey0jF/2EJduO/eb9FbkphwcWV29wvUjGANFnOmm6VrUIAykwnusrh9EJ
	ybB9fLtCbZ2doNEBLlLSF8y4BLrk1JojfsoJBsF4KIiZ/oQasSZ0yHqKxkC/DXJviOSY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169413-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169413: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=4cfb28f12a8d24cab32d3223275a772227062a39
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 03:46:35 +0000

flight 169413 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169413/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 4cfb28f12a8d24cab32d3223275a772227062a39
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  402 attempts
Testing same since   169405  2022-04-14 20:10:31 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5119 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305215.520126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxe-0005Ec-M2; Fri, 15 Apr 2022 04:53:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305215.520126; Fri, 15 Apr 2022 04:53:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxe-0005ET-J5; Fri, 15 Apr 2022 04:53:34 +0000
Received: by outflank-mailman (input) for mailman id 305215;
 Fri, 15 Apr 2022 04:53:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxd-0004b8-8q
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:33 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc3e810d-bc77-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:53:30 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxL-008Omo-Q5; Fri, 15 Apr 2022 04:53:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc3e810d-bc77-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=UUS6y6SVPRCfJmQVPGCeD5o714qtaTT6EGogPxQdIy8=; b=x5agUVGSt4qUPiArfFruXQZEkh
	ED5eIR3aSkNtXX7nLmypr4HghgJKhQCB8SBb7JsEb44bJsx67U0AujP5aBa1btb0b+S+xGwgwPD/7
	RRQm+W0tVsP/DSqW5U9c8tVIT1qiiaD3HIowj1Lt7t2v4nBRlePLOFKu6cvzlYV9ePp50Bne//9CJ
	umsrwM4RvhODoSk65phqK4ewBHRrL/nBunRhsHvf5+9CdNnqhx6U7RpMnn5jES/jOpBFGw0/3/808
	G3CmRXGpdyxJMHizR5B5MMLpxywFyHZzcVohmA18ECgaE440XvejvcNkIHffvwRVbT/cfUPwhLobO
	l5t6lMLg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction
Date: Fri, 15 Apr 2022 06:52:32 +0200
Message-Id: <20220415045258.199825-2-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

For block devices, the SCSI target drivers implements UNMAP as calls to
blkdev_issue_discard, which does not guarantee zeroing just because
Write Zeroes is supported.

Note that this does not affect the file backed path which uses
fallocate to punch holes.

Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/target/target_core_device.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 44bb380e7390c..fa866acef5bb2 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -850,7 +850,6 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
 	attrib->unmap_granularity_alignment = q->limits.discard_alignment /
 								block_size;
-	attrib->unmap_zeroes_data = !!(q->limits.max_write_zeroes_sectors);
 	return true;
 }
 EXPORT_SYMBOL(target_configure_unmap_from_queue);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305217.520149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxj-0005rm-Ai; Fri, 15 Apr 2022 04:53:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305217.520149; Fri, 15 Apr 2022 04:53:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxj-0005rd-6y; Fri, 15 Apr 2022 04:53:39 +0000
Received: by outflank-mailman (input) for mailman id 305217;
 Fri, 15 Apr 2022 04:53:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxi-0004TJ-EF
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:38 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 027d28bb-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:53:37 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxW-008OrQ-LX; Fri, 15 Apr 2022 04:53:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 027d28bb-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=XZGhvwW8WnEXnqFpyMAZS4hEeSHoeSYBiqC69zbelFo=; b=Gxz7Y5uJ+XKe3DFB5F+glNf4Qd
	+ilmHliKeg1fmYV7/5LLANJc72+LNxw8j97CHk5ziFCgc1uz7kS3J7fxsGIO6cnBRc/aEIND8YKio
	0SkKbU86rwF6U+vXBBwyr3GFqwWasgE9TCw8n+hO0zPxSPP5I4ZPpiX7PrV0Nkluz9OYVJwj4Hmwy
	oKidnHT0/AqxHbe4vf+J+1VyQBy8myzVvzFwGzWB5MOWnMsTyORGtxjAzgY+jPvDzJzijUERBo3GF
	IuBPqJCO6mtg8vZGmw86bOvzf7HW3Tdf+1Wt8evubUZivpuvFh33FBjqoHj3OCwfnGHVCD1k5Crl7
	crl4uuXw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>
Subject: [PATCH 05/27] drbd: use bdev based limit helpers in drbd_send_sizes
Date: Fri, 15 Apr 2022 06:52:36 +0200
Message-Id: <20220415045258.199825-6-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based limits helpers where they exist.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
 drivers/block/drbd/drbd_main.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 367715205c860..c39b04bda261f 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -924,7 +924,9 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 
 	memset(p, 0, packet_size);
 	if (get_ldev_if_state(device, D_NEGOTIATING)) {
-		struct request_queue *q = bdev_get_queue(device->ldev->backing_bdev);
+		struct block_device *bdev = device->ldev->backing_bdev;
+		struct request_queue *q = bdev_get_queue(bdev);
+
 		d_size = drbd_get_max_capacity(device->ldev);
 		rcu_read_lock();
 		u_size = rcu_dereference(device->ldev->disk_conf)->disk_size;
@@ -933,13 +935,13 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		max_bio_size = queue_max_hw_sectors(q) << 9;
 		max_bio_size = min(max_bio_size, DRBD_MAX_BIO_SIZE);
 		p->qlim->physical_block_size =
-			cpu_to_be32(queue_physical_block_size(q));
+			cpu_to_be32(bdev_physical_block_size(bdev));
 		p->qlim->logical_block_size =
-			cpu_to_be32(queue_logical_block_size(q));
+			cpu_to_be32(bdev_logical_block_size(bdev));
 		p->qlim->alignment_offset =
 			cpu_to_be32(queue_alignment_offset(q));
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
+		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
 		p->qlim->discard_enabled = blk_queue_discard(q);
 		put_ldev(device);
 	} else {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305214.520116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxd-0004yr-FD; Fri, 15 Apr 2022 04:53:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305214.520116; Fri, 15 Apr 2022 04:53:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxd-0004yk-BQ; Fri, 15 Apr 2022 04:53:33 +0000
Received: by outflank-mailman (input) for mailman id 305214;
 Fri, 15 Apr 2022 04:53:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxc-0004TJ-02
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:32 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fec9ba66-bc77-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:53:31 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxR-008Ooe-Ik; Fri, 15 Apr 2022 04:53:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fec9ba66-bc77-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=OTIsP1OizukmDhxFkiULvJk6rKtH8rZ66Toc2zFZ06c=; b=ooMRjv2JAUzFUPyfh+XZqWb8QW
	Q9pjLNLNX62Z8C2MtoU6HU3VpVt4OAZRBuYSsD6pXMOi8ZjLOdl54eYy3Tp24LGUVsHa2hBE7Y0RM
	gDKNIKXjx2hbqJA1iCpB6nzk3wFq7ScIOiguPmNGaxWjNFoSpuysiesbbWxhRLyGcBXCzqkMTGuuD
	XDeeqdLlxhy91bRF+ZdOWJypNUbEcjrD8gjGqtH4BhZffx0JY9uZOYdBApIPmQ3bzD93iVI7xEHYb
	JNb40WmRbrFCmN1/+6dAisHF7eHMEiTWRFZXLfqhSoZ7Cj20tDlAxwUfcT/Ob7kj6Vu7zsHN8pcpE
	pX9GukFg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 03/27] target: fix discard alignment on partitions
Date: Fri, 15 Apr 2022 06:52:34 +0200
Message-Id: <20220415045258.199825-4-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the proper bdev_discard_alignment helper that accounts for partition
offsets.

Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/target/target_core_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 3a1ec705cd80b..16e775bcf4a7c 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -849,8 +849,8 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	 */
 	attrib->max_unmap_block_desc_count = 1;
 	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
-	attrib->unmap_granularity_alignment = q->limits.discard_alignment /
-								block_size;
+	attrib->unmap_granularity_alignment =
+		bdev_discard_alignment(bdev) / block_size;
 	return true;
 }
 EXPORT_SYMBOL(target_configure_unmap_from_queue);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305212.520094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxb-0004Tc-R0; Fri, 15 Apr 2022 04:53:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305212.520094; Fri, 15 Apr 2022 04:53:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxb-0004TV-Nu; Fri, 15 Apr 2022 04:53:31 +0000
Received: by outflank-mailman (input) for mailman id 305212;
 Fri, 15 Apr 2022 04:53:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxZ-0004TJ-9N
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:30 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fb16759c-bc77-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:53:25 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxI-008OmY-4r; Fri, 15 Apr 2022 04:53:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb16759c-bc77-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=T00AEFQ4LdY1QMdERyaPozZpUOF+QiWNLetpSJJQdDo=; b=4z6KO6NFlCmw6gfLt5PMjkbZbu
	ouT60XDqcfvRhernsRXD0vwaftH4PWGz4g/tfgJxaVQdnBahT9rSu+DPV0LcVWvfqp3gSmaRRdKjo
	LrtjVJU30r+VyvCuJqCpqyJLq+Np0yb+WyGJf7TtEsin5OlECXGHTRm8CUgIrhr286x9pu7HMkFwj
	WRWOTWk+UhMPmcPKIHaMsVI41kiHgzfBLpjBUgT/qUn8kDftheRbfzGB5lKPyfqxPgkVCnkl5qRhd
	TvTcdGJElRmxpcgYx6fNN6THfHB/GfYIgPywakC/rqA7h0nFLzILemkQ8Y3NKIc/JU1eL4CKelMvU
	3Q7Lrsyw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: use block_device based APIs in block layer consumers v3
Date: Fri, 15 Apr 2022 06:52:31 +0200
Message-Id: <20220415045258.199825-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Hi Jens,

this series cleanups up the block layer API so that APIs consumed
by file systems are (almost) only struct block_devic based, so that
file systems don't have to poke into block layer internals like the
request_queue.

I also found a bunch of existing bugs related to partition offsets
and discard so these are fixed while going along.

Changes since v2:
 - fix an inverted check in btrfs
 - set max_discard_sectors to 0 in all places where the flag was
   previously cleared
 - fix a few sligtly incorrect collected Acks

Changes since v1:
 - fix a bisection hazard
 - minor spelling fixes
 - reorder hunks between two patches to make the changes more obvious
 - reorder a patch to be earlier in the series to ease backporting


Diffstat:
 arch/um/drivers/ubd_kern.c           |    2 
 block/blk-core.c                     |    4 -
 block/blk-lib.c                      |  124 ++++++++++++++++++++---------------
 block/blk-mq-debugfs.c               |    2 
 block/blk-settings.c                 |   74 ++++++++++++++++++++
 block/blk.h                          |   14 ---
 block/fops.c                         |    2 
 block/genhd.c                        |    4 -
 block/ioctl.c                        |   48 ++++++++++---
 block/partitions/core.c              |   12 ---
 drivers/block/drbd/drbd_main.c       |   51 ++++++--------
 drivers/block/drbd/drbd_nl.c         |   94 +++++++++++---------------
 drivers/block/drbd/drbd_receiver.c   |   13 +--
 drivers/block/loop.c                 |   15 +---
 drivers/block/nbd.c                  |    5 -
 drivers/block/null_blk/main.c        |    1 
 drivers/block/rbd.c                  |    1 
 drivers/block/rnbd/rnbd-clt.c        |    6 -
 drivers/block/rnbd/rnbd-srv-dev.h    |    8 --
 drivers/block/rnbd/rnbd-srv.c        |    5 -
 drivers/block/virtio_blk.c           |    2 
 drivers/block/xen-blkback/blkback.c  |   15 ++--
 drivers/block/xen-blkback/xenbus.c   |    9 --
 drivers/block/xen-blkfront.c         |    8 +-
 drivers/block/zram/zram_drv.c        |    1 
 drivers/md/bcache/alloc.c            |    2 
 drivers/md/bcache/request.c          |    4 -
 drivers/md/bcache/super.c            |    3 
 drivers/md/bcache/sysfs.c            |    2 
 drivers/md/dm-cache-target.c         |    9 --
 drivers/md/dm-clone-target.c         |    9 --
 drivers/md/dm-io.c                   |    2 
 drivers/md/dm-log-writes.c           |    3 
 drivers/md/dm-raid.c                 |    9 --
 drivers/md/dm-table.c                |   25 +------
 drivers/md/dm-thin.c                 |   15 ----
 drivers/md/dm.c                      |    3 
 drivers/md/md-linear.c               |   11 ---
 drivers/md/md.c                      |    5 -
 drivers/md/raid0.c                   |    7 -
 drivers/md/raid1.c                   |   18 -----
 drivers/md/raid10.c                  |   20 -----
 drivers/md/raid5-cache.c             |    8 +-
 drivers/md/raid5.c                   |   14 +--
 drivers/mmc/core/queue.c             |    3 
 drivers/mtd/mtd_blkdevs.c            |    1 
 drivers/nvme/host/core.c             |    4 -
 drivers/nvme/target/io-cmd-bdev.c    |    2 
 drivers/nvme/target/zns.c            |    3 
 drivers/s390/block/dasd_fba.c        |    1 
 drivers/scsi/sd.c                    |    2 
 drivers/target/target_core_device.c  |   20 ++---
 drivers/target/target_core_file.c    |   10 +-
 drivers/target/target_core_iblock.c  |   17 +---
 fs/btrfs/disk-io.c                   |    3 
 fs/btrfs/extent-tree.c               |    8 +-
 fs/btrfs/ioctl.c                     |   12 +--
 fs/btrfs/volumes.c                   |    4 -
 fs/btrfs/zoned.c                     |    3 
 fs/direct-io.c                       |   32 +--------
 fs/exfat/file.c                      |    5 -
 fs/exfat/super.c                     |   10 --
 fs/ext4/ioctl.c                      |   10 --
 fs/ext4/mballoc.c                    |   10 +-
 fs/ext4/super.c                      |   10 --
 fs/f2fs/f2fs.h                       |    3 
 fs/f2fs/file.c                       |   19 ++---
 fs/f2fs/segment.c                    |    8 --
 fs/fat/file.c                        |    5 -
 fs/fat/inode.c                       |   10 --
 fs/gfs2/rgrp.c                       |    7 -
 fs/iomap/direct-io.c                 |    3 
 fs/jbd2/journal.c                    |    9 --
 fs/jfs/ioctl.c                       |    5 -
 fs/jfs/super.c                       |    8 --
 fs/nilfs2/ioctl.c                    |    6 -
 fs/nilfs2/sufile.c                   |    4 -
 fs/nilfs2/the_nilfs.c                |    4 -
 fs/ntfs3/file.c                      |    6 -
 fs/ntfs3/super.c                     |   10 +-
 fs/ocfs2/ioctl.c                     |    5 -
 fs/super.c                           |    2 
 fs/xfs/xfs_discard.c                 |    8 +-
 fs/xfs/xfs_log_cil.c                 |    2 
 fs/xfs/xfs_super.c                   |   12 +--
 fs/zonefs/super.c                    |    3 
 include/linux/blkdev.h               |  112 +++++++++++--------------------
 include/target/target_core_backend.h |    4 -
 mm/swapfile.c                        |   31 ++------
 89 files changed, 494 insertions(+), 651 deletions(-)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305216.520138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxh-0005X0-1z; Fri, 15 Apr 2022 04:53:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305216.520138; Fri, 15 Apr 2022 04:53:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxg-0005Wr-Sr; Fri, 15 Apr 2022 04:53:36 +0000
Received: by outflank-mailman (input) for mailman id 305216;
 Fri, 15 Apr 2022 04:53:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxf-0004b8-Er
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:35 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 009533d9-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:53:34 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxU-008Opj-8L; Fri, 15 Apr 2022 04:53:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 009533d9-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=be5XRqr6FpD/xPCRROQj1WW79ZNoTG4VrTyORPZGjVE=; b=zfdoWKjLNg8/93VMXMR/8dmem+
	WdvS+5iIu6uir1zneoGsW/PVn5k5msDFRP3cNUjzgk48HwXHEWdbPPQegdyt6x56ivnd6KhVFEdRn
	raW2CONj2YH3bKud1GU1IPcR9v/j6pw0pUmG9drywqIdz4cTw9frqxiK8uJ0qudjT7ff4EmR2zNpd
	iXKlU7IflKK7BZ1vMlEvBpbCIpEVLMDJnliSIXYAubrng3TWL7OH99pGfDALzISzxUUJefgBXG3V5
	WlBB+jh7r7m3TcfVeysrxVV3wHeAvYOUUoaQFeOXr6OBj0iU6tL7PMj+sYlQjUaSSJXCl4UqBVXnS
	NdWcSxoQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>
Subject: [PATCH 04/27] drbd: remove assign_p_sizes_qlim
Date: Fri, 15 Apr 2022 06:52:35 +0200
Message-Id: <20220415045258.199825-5-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Fold each branch into its only caller.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
 drivers/block/drbd/drbd_main.c | 47 +++++++++++++++-------------------
 1 file changed, 20 insertions(+), 27 deletions(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 4b0b25cc916ee..367715205c860 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -903,31 +903,6 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device)
 	}
 }
 
-/* communicated if (agreed_features & DRBD_FF_WSAME) */
-static void
-assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p,
-					struct request_queue *q)
-{
-	if (q) {
-		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));
-		p->qlim->logical_block_size = cpu_to_be32(queue_logical_block_size(q));
-		p->qlim->alignment_offset = cpu_to_be32(queue_alignment_offset(q));
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
-		p->qlim->discard_enabled = blk_queue_discard(q);
-		p->qlim->write_same_capable = 0;
-	} else {
-		q = device->rq_queue;
-		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));
-		p->qlim->logical_block_size = cpu_to_be32(queue_logical_block_size(q));
-		p->qlim->alignment_offset = 0;
-		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
-		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
-		p->qlim->discard_enabled = 0;
-		p->qlim->write_same_capable = 0;
-	}
-}
-
 int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enum dds_flags flags)
 {
 	struct drbd_device *device = peer_device->device;
@@ -957,14 +932,32 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		q_order_type = drbd_queue_order_type(device);
 		max_bio_size = queue_max_hw_sectors(q) << 9;
 		max_bio_size = min(max_bio_size, DRBD_MAX_BIO_SIZE);
-		assign_p_sizes_qlim(device, p, q);
+		p->qlim->physical_block_size =
+			cpu_to_be32(queue_physical_block_size(q));
+		p->qlim->logical_block_size =
+			cpu_to_be32(queue_logical_block_size(q));
+		p->qlim->alignment_offset =
+			cpu_to_be32(queue_alignment_offset(q));
+		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
+		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->discard_enabled = blk_queue_discard(q);
 		put_ldev(device);
 	} else {
+		struct request_queue *q = device->rq_queue;
+
+		p->qlim->physical_block_size =
+			cpu_to_be32(queue_physical_block_size(q));
+		p->qlim->logical_block_size =
+			cpu_to_be32(queue_logical_block_size(q));
+		p->qlim->alignment_offset = 0;
+		p->qlim->io_min = cpu_to_be32(queue_io_min(q));
+		p->qlim->io_opt = cpu_to_be32(queue_io_opt(q));
+		p->qlim->discard_enabled = 0;
+
 		d_size = 0;
 		u_size = 0;
 		q_order_type = QUEUE_ORDERED_NONE;
 		max_bio_size = DRBD_MAX_BIO_SIZE; /* ... multiple BIOs per peer_request */
-		assign_p_sizes_qlim(device, p, NULL);
 	}
 
 	if (peer_device->connection->agreed_pro_version <= 94)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305213.520099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxc-0004Vq-4I; Fri, 15 Apr 2022 04:53:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305213.520099; Fri, 15 Apr 2022 04:53:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxb-0004VN-VV; Fri, 15 Apr 2022 04:53:31 +0000
Received: by outflank-mailman (input) for mailman id 305213;
 Fri, 15 Apr 2022 04:53:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxa-0004TJ-EQ
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:30 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fd14b36f-bc77-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:53:28 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxP-008OnZ-2m; Fri, 15 Apr 2022 04:53:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd14b36f-bc77-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=6JVZQz23Gg3oLV4oYc05UwmOH+nGeMd1Qpin5+I9KgM=; b=p4/UQY65J530pBrFxSnyzz+s1S
	20vQFpTrN15G6NO5F9VDuyGriDpCNyWjbyKgPkMSrLLko0Q4FtJ1eCzi+YOgwapAyJib+3l/z0nqL
	+NYMVQXNHIEHx4U8dz9u48TnCqPcYXyNXVQmQKYJgAexB2zuX97VLPbrU2HmJIKE7g1fg+Kmpeu2X
	7In2j9JZDuGthZuxusAdOOuAjghMTjSwC/AdUlo5SnfFd1vgrm4uEPQ78/HVr7y9+RCydI3REXKPH
	s1r/AwsdOouUPRQPQY3Kuv+Zv/88cYk9RfHpmYADsU3re53XPeDNlC3OFKsZfaMhZuxBpfzjqoDMO
	ifzKUlSQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 02/27] target: pass a block_device to target_configure_unmap_from_queue
Date: Fri, 15 Apr 2022 06:52:33 +0200
Message-Id: <20220415045258.199825-3-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The SCSI target drivers is a consumer of the block layer and shoul
d generally work on struct block_device.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/target/target_core_device.c  | 5 +++--
 drivers/target/target_core_file.c    | 7 ++++---
 drivers/target/target_core_iblock.c  | 2 +-
 include/target/target_core_backend.h | 4 ++--
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index fa866acef5bb2..3a1ec705cd80b 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -834,9 +834,10 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
  * in ATA and we need to set TPE=1
  */
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
-				       struct request_queue *q)
+				       struct block_device *bdev)
 {
-	int block_size = queue_logical_block_size(q);
+	struct request_queue *q = bdev_get_queue(bdev);
+	int block_size = bdev_logical_block_size(bdev);
 
 	if (!blk_queue_discard(q))
 		return false;
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index 8190b840065f3..8d191fdc33217 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -134,10 +134,11 @@ static int fd_configure_device(struct se_device *dev)
 	 */
 	inode = file->f_mapping->host;
 	if (S_ISBLK(inode->i_mode)) {
-		struct request_queue *q = bdev_get_queue(I_BDEV(inode));
+		struct block_device *bdev = I_BDEV(inode);
+		struct request_queue *q = bdev_get_queue(bdev);
 		unsigned long long dev_size;
 
-		fd_dev->fd_block_size = bdev_logical_block_size(I_BDEV(inode));
+		fd_dev->fd_block_size = bdev_logical_block_size(bdev);
 		/*
 		 * Determine the number of bytes from i_size_read() minus
 		 * one (1) logical sector from underlying struct block_device
@@ -150,7 +151,7 @@ static int fd_configure_device(struct se_device *dev)
 			dev_size, div_u64(dev_size, fd_dev->fd_block_size),
 			fd_dev->fd_block_size);
 
-		if (target_configure_unmap_from_queue(&dev->dev_attrib, q))
+		if (target_configure_unmap_from_queue(&dev->dev_attrib, bdev))
 			pr_debug("IFILE: BLOCK Discard support available,"
 				 " disabled by default\n");
 		/*
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 87ede165ddba4..b886ce1770bfd 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -119,7 +119,7 @@ static int iblock_configure_device(struct se_device *dev)
 	dev->dev_attrib.hw_max_sectors = queue_max_hw_sectors(q);
 	dev->dev_attrib.hw_queue_depth = q->nr_requests;
 
-	if (target_configure_unmap_from_queue(&dev->dev_attrib, q))
+	if (target_configure_unmap_from_queue(&dev->dev_attrib, bd))
 		pr_debug("IBLOCK: BLOCK Discard support available,"
 			 " disabled by default\n");
 
diff --git a/include/target/target_core_backend.h b/include/target/target_core_backend.h
index 675f3a1fe6139..773963a1e0b53 100644
--- a/include/target/target_core_backend.h
+++ b/include/target/target_core_backend.h
@@ -14,7 +14,7 @@
 #define TRANSPORT_FLAG_PASSTHROUGH_ALUA		0x2
 #define TRANSPORT_FLAG_PASSTHROUGH_PGR          0x4
 
-struct request_queue;
+struct block_device;
 struct scatterlist;
 
 struct target_backend_ops {
@@ -117,7 +117,7 @@ sense_reason_t passthrough_parse_cdb(struct se_cmd *cmd,
 bool target_sense_desc_format(struct se_device *dev);
 sector_t target_to_linux_sector(struct se_device *dev, sector_t lb);
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
-				       struct request_queue *q);
+				       struct block_device *bdev);
 
 static inline bool target_dev_configured(struct se_device *se_dev)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305218.520159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxl-0006DU-Mq; Fri, 15 Apr 2022 04:53:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305218.520159; Fri, 15 Apr 2022 04:53:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxl-0006DI-I0; Fri, 15 Apr 2022 04:53:41 +0000
Received: by outflank-mailman (input) for mailman id 305218;
 Fri, 15 Apr 2022 04:53:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxk-0004TJ-2S
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:40 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 03a46f31-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:53:39 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxZ-008OtX-AH; Fri, 15 Apr 2022 04:53:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03a46f31-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=pjOlLI0zIPscdljJBqydWvc1kCbsO4mNomowvsnW144=; b=qvkOjPFjyqYMQWW/2QWIK68ENP
	k2NNTMvf9yJkIIsMinaHWq3ShtV9GAA9eD1j84n/4A1YSynSJPbH7xunvM4gFW2tBAaf34uDjFYTF
	Cf27zURP5kxthNnuilxHYkuF0+dYk/s+KgITZDeRBuWDyLf29iyj7NC5GSjUBL7HTLudqqDHJV7jI
	umQOzmF/ghCqietP9jcYeXWa5VJNEKLQMKEWsHvHjmzPuAlTBx/BxH8sjV6Sj89/sE85wKvCAMm7z
	4onw1pEIPzrLUGePDGOaGXDfMTfY5lSCh3pdlvTomsyZDMHzABEpf6210R46hSLONPkgfa2cukRRf
	iN4Lrpmg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>
Subject: [PATCH 06/27] drbd: use bdev_alignment_offset instead of queue_alignment_offset
Date: Fri, 15 Apr 2022 06:52:37 +0200
Message-Id: <20220415045258.199825-7-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The bdev version does the right thing for partitions, so use that.

Fixes: 9104d31a759f ("drbd: introduce WRITE_SAME support")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
 drivers/block/drbd/drbd_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index c39b04bda261f..7b501c8d59928 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -939,7 +939,7 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 		p->qlim->logical_block_size =
 			cpu_to_be32(bdev_logical_block_size(bdev));
 		p->qlim->alignment_offset =
-			cpu_to_be32(queue_alignment_offset(q));
+			cpu_to_be32(bdev_alignment_offset(bdev));
 		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
 		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
 		p->qlim->discard_enabled = blk_queue_discard(q);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305221.520171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxq-0006gK-7z; Fri, 15 Apr 2022 04:53:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305221.520171; Fri, 15 Apr 2022 04:53:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxq-0006g4-3j; Fri, 15 Apr 2022 04:53:46 +0000
Received: by outflank-mailman (input) for mailman id 305221;
 Fri, 15 Apr 2022 04:53:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxo-0004b8-P1
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:44 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 060b1d78-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:53:43 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxb-008OvZ-Ly; Fri, 15 Apr 2022 04:53:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 060b1d78-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=9tUaZULhEmteAuYmNe/S5K85i8mY+zpV/R7NWj8li0M=; b=AjCBuPx/UHSGTakXv8HXmgNw4N
	Iyofq9wNNzfgjbG93scprq/gUs5OOhFUGL0tKjcj2IWWkpHNBkXqusk5CV5Uj/P/70TymjB6Unzdu
	VnxSzUtQb3ldimIkXALq/IfCXSo1TL1NzeISVmz+Ea7q6xFf02zHvxp+FndxH2zbBXHBFRTOnXe4c
	nAXrXpjx27cFTMs0mjOzvEq3gOjLOY6hKIcglkznMntAYg+vXORRN23xzGalvjS8R6ccxTXJWj8QW
	sdXJMYerLCI2QfFcDPA/f8tI4pucu7JSpv7rjXlKJh5WSo2NBa1UXNlyVf9emnFeALezPoiPRp2d8
	jaVM4Jaw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>
Subject: [PATCH 07/27] drbd: cleanup decide_on_discard_support
Date: Fri, 15 Apr 2022 06:52:38 +0200
Message-Id: <20220415045258.199825-8-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Sanitize the calling conventions and use a goto label to cleanup the
code flow.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
 drivers/block/drbd/drbd_nl.c | 68 +++++++++++++++++++-----------------
 1 file changed, 35 insertions(+), 33 deletions(-)

diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index b7216c186ba4d..4d00986d6f588 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1204,38 +1204,42 @@ static unsigned int drbd_max_discard_sectors(struct drbd_connection *connection)
 }
 
 static void decide_on_discard_support(struct drbd_device *device,
-			struct request_queue *q,
-			struct request_queue *b,
-			bool discard_zeroes_if_aligned)
+		struct drbd_backing_dev *bdev)
 {
-	/* q = drbd device queue (device->rq_queue)
-	 * b = backing device queue (device->ldev->backing_bdev->bd_disk->queue),
-	 *     or NULL if diskless
-	 */
-	struct drbd_connection *connection = first_peer_device(device)->connection;
-	bool can_do = b ? blk_queue_discard(b) : true;
-
-	if (can_do && connection->cstate >= C_CONNECTED && !(connection->agreed_features & DRBD_FF_TRIM)) {
-		can_do = false;
-		drbd_info(connection, "peer DRBD too old, does not support TRIM: disabling discards\n");
-	}
-	if (can_do) {
-		/* We don't care for the granularity, really.
-		 * Stacking limits below should fix it for the local
-		 * device.  Whether or not it is a suitable granularity
-		 * on the remote device is not our problem, really. If
-		 * you care, you need to use devices with similar
-		 * topology on all peers. */
-		blk_queue_discard_granularity(q, 512);
-		q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
-		q->limits.max_write_zeroes_sectors = drbd_max_discard_sectors(connection);
-	} else {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
-		blk_queue_discard_granularity(q, 0);
-		q->limits.max_discard_sectors = 0;
-		q->limits.max_write_zeroes_sectors = 0;
+	struct drbd_connection *connection =
+		first_peer_device(device)->connection;
+	struct request_queue *q = device->rq_queue;
+
+	if (bdev && !blk_queue_discard(bdev->backing_bdev->bd_disk->queue))
+		goto not_supported;
+
+	if (connection->cstate >= C_CONNECTED &&
+	    !(connection->agreed_features & DRBD_FF_TRIM)) {
+		drbd_info(connection,
+			"peer DRBD too old, does not support TRIM: disabling discards\n");
+		goto not_supported;
 	}
+
+	/*
+	 * We don't care for the granularity, really.
+	 *
+	 * Stacking limits below should fix it for the local device.  Whether or
+	 * not it is a suitable granularity on the remote device is not our
+	 * problem, really. If you care, you need to use devices with similar
+	 * topology on all peers.
+	 */
+	blk_queue_discard_granularity(q, 512);
+	q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
+	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
+	q->limits.max_write_zeroes_sectors =
+		drbd_max_discard_sectors(connection);
+	return;
+
+not_supported:
+	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
+	blk_queue_discard_granularity(q, 0);
+	q->limits.max_discard_sectors = 0;
+	q->limits.max_write_zeroes_sectors = 0;
 }
 
 static void fixup_discard_if_not_supported(struct request_queue *q)
@@ -1273,7 +1277,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 	unsigned int max_segments = 0;
 	struct request_queue *b = NULL;
 	struct disk_conf *dc;
-	bool discard_zeroes_if_aligned = true;
 
 	if (bdev) {
 		b = bdev->backing_bdev->bd_disk->queue;
@@ -1282,7 +1285,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 		rcu_read_lock();
 		dc = rcu_dereference(device->ldev->disk_conf);
 		max_segments = dc->max_bio_bvecs;
-		discard_zeroes_if_aligned = dc->discard_zeroes_if_aligned;
 		rcu_read_unlock();
 
 		blk_set_stacking_limits(&q->limits);
@@ -1292,7 +1294,7 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 	/* This is the workaround for "bio would need to, but cannot, be split" */
 	blk_queue_max_segments(q, max_segments ? max_segments : BLK_MAX_SEGMENTS);
 	blk_queue_segment_boundary(q, PAGE_SIZE-1);
-	decide_on_discard_support(device, q, b, discard_zeroes_if_aligned);
+	decide_on_discard_support(device, bdev);
 
 	if (b) {
 		blk_stack_limits(&q->limits, &b->limits, 0);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305226.520182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxs-00072K-Ib; Fri, 15 Apr 2022 04:53:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305226.520182; Fri, 15 Apr 2022 04:53:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxs-00072D-Cn; Fri, 15 Apr 2022 04:53:48 +0000
Received: by outflank-mailman (input) for mailman id 305226;
 Fri, 15 Apr 2022 04:53:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfDxr-0006yx-Nb; Fri, 15 Apr 2022 04:53:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfDxr-0001ZI-LA; Fri, 15 Apr 2022 04:53:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfDxr-0007bL-9r; Fri, 15 Apr 2022 04:53:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfDxr-0005G5-92; Fri, 15 Apr 2022 04:53:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ucy0ddcIzLOwS7S/VZxs/EBF5rA4QZaVbsnzssX9U9k=; b=JAN7ti7jcZedJv5TrEs7s/a1Bq
	NyM4hpmWAsmUmHplClfxP5sCis4FnDqrVevY+zOpb9xGdxSmGM5n2zoZxZc5PWBJhlZZr07Vm4TPq
	wmheCp8Ft/avqzlwqthJPTRV/SLyAWkZXk/pvcQNYtsHRvQTsyhTcH1PzbUuirK+tW9U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169414-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169414: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 04:53:47 +0000

flight 169414 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169414/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  403 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305232.520193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxu-0007O3-Ro; Fri, 15 Apr 2022 04:53:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305232.520193; Fri, 15 Apr 2022 04:53:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxu-0007Nu-NV; Fri, 15 Apr 2022 04:53:50 +0000
Received: by outflank-mailman (input) for mailman id 305232;
 Fri, 15 Apr 2022 04:53:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxt-0004TJ-SK
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:49 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 07e8fd14-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:53:46 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxe-008Oxy-2A; Fri, 15 Apr 2022 04:53:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07e8fd14-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=3FWZlAG92h1RMyWa34xIeRgUUqbPb180tFAKbgq0RAE=; b=vLBRGmYA6jBMZDlzC6PXWv+Ksh
	9na0CpZ5vQifHyF0I8hMiOODlZP67Q2wDV/bHkW9tDW3iYlbHmeg8cbzKsYytJTpwvlcHhRbVfqcX
	u3Kb/T1hJpTRApCefLOPvQW0mKpxDcNm47SF5wKvwDYKsM4SjV65VWQFHoZN4xC3iqhdpTgH60xyD
	3FkocDRpHF7/kXuVb8jwQtLL3ZBVVz+fa7PIdADFNqNFERroneG/Wkz00hQMCvFOcmh7+ThP9CfhC
	oK97r2DvOPV2WXipkXhu1yEAGyGeER9Ori1+uKdJHNOs14UTWNR2qEKSdnT4Cxh5GrNg5oiq3V6Rp
	ycclGS7g==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open coding it
Date: Fri, 15 Apr 2022 06:52:39 +0200
Message-Id: <20220415045258.199825-9-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Acked-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/zoned.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 1b1b310c3c510..f72cad7391a11 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -350,7 +350,6 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
 	struct btrfs_fs_info *fs_info = device->fs_info;
 	struct btrfs_zoned_device_info *zone_info = NULL;
 	struct block_device *bdev = device->bdev;
-	struct request_queue *queue = bdev_get_queue(bdev);
 	unsigned int max_active_zones;
 	unsigned int nactive;
 	sector_t nr_sectors;
@@ -410,7 +409,7 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
 	if (!IS_ALIGNED(nr_sectors, zone_sectors))
 		zone_info->nr_zones++;
 
-	max_active_zones = queue_max_active_zones(queue);
+	max_active_zones = bdev_max_active_zones(bdev);
 	if (max_active_zones && max_active_zones < BTRFS_MIN_ACTIVE_ZONES) {
 		btrfs_err_in_rcu(fs_info,
 "zoned: %s: max active zones %u is too small, need at least %u active zones",
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 04:53:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 04:53:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305233.520205 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxw-0007g9-BC; Fri, 15 Apr 2022 04:53:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305233.520205; Fri, 15 Apr 2022 04:53:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfDxw-0007er-29; Fri, 15 Apr 2022 04:53:52 +0000
Received: by outflank-mailman (input) for mailman id 305233;
 Fri, 15 Apr 2022 04:53:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxu-0004b8-Er
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:50 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 09506ebe-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:53:49 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxg-008P0P-IF; Fri, 15 Apr 2022 04:53:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09506ebe-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=Bh+vV8H1PUD+w/3YWj6wMRz8JdOJ8okMcDjW6Mx/Fiw=; b=EDKTioiwyVTPK+3osA6SlCjZIh
	XT2MFqWZOTWCp0TzWu6P4fqhDWPMpkttHrN+m9dRro3N5CDnlXbRs0EPkfGOyM+igunHSMpD1drYP
	wVG9uOkzBpiVKojyqfYhi6+OMNU5l2i8PZR4B1REL+uCtnEoooz23D6FVFibL3Fu1/dIA+0rTSxtr
	oKyzI2WMLHHUV9rvM0v15/lCAj3aZ6PKIBUE2kOCt4TslhWmWNZKgszd/7d2ie8DKfEQnXgchcj36
	NzfvLJkjkLxSqax1JuD1ELqlJ8gRaVf5Gn7y07gnCWPWGyuEN/9bXBtizUFBY7p5eDKr/MYNHjMCe
	ltnYH85Q==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 09/27] ntfs3: use bdev_logical_block_size instead of open coding it
Date: Fri, 15 Apr 2022 06:52:40 +0200
Message-Id: <20220415045258.199825-10-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/ntfs3/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 278dcf5024102..cd30e81abbce0 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -920,7 +920,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	}
 
 	/* Parse boot. */
-	err = ntfs_init_from_boot(sb, rq ? queue_logical_block_size(rq) : 512,
+	err = ntfs_init_from_boot(sb, bdev_logical_block_size(bdev),
 				  bdev_nr_bytes(bdev));
 	if (err)
 		goto out;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:01:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:01:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305249.520215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE5k-0003hM-3k; Fri, 15 Apr 2022 05:01:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305249.520215; Fri, 15 Apr 2022 05:01:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE5k-0003hF-0p; Fri, 15 Apr 2022 05:01:56 +0000
Received: by outflank-mailman (input) for mailman id 305249;
 Fri, 15 Apr 2022 05:01:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyI-0004b8-1a
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:14 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 14f31f50-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:54:08 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDy1-008PNf-1X; Fri, 15 Apr 2022 04:53:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14f31f50-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=q2ranmlO4Nl6vweHnkN5W/lhAXFqjXPKY6W4cI6bGNw=; b=Imm4Yfj4lK8os56GTjHtESv8Ln
	/f/n//I9UVgO0gz0loVNZo7Kx8U2lN8GWuypT8815hL/Cbxkr3GIfFYT2oap2P7u27ZNlfV4ESUm3
	nUKYekUTiCtdte0HtVU0mfHtnc1JSUCyagOIpbgNEzqbzUQNiwlEp8m5sb47dsYKebQL4R3A3Igsy
	dTbWNMbYDJIYjtYyj8uxb8rBDcOQ+bzOZSC1SBOJPEIu1iXFYJPGOni5DOCC7FW8wOycr+QifG/Wg
	MwWy7d+vMvWLfxa4iMbFhmkTIzHqao0ZRSaYQGzHa37lKAGUhFr/qfO/PDwSf9PSBl8O2KxhcHtX4
	P2d5tlXw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 17/27] block: use bdev_alignment_offset in disk_alignment_offset_show
Date: Fri, 15 Apr 2022 06:52:48 +0200
Message-Id: <20220415045258.199825-18-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

This does the same as the open coded variant except for an extra branch,
and allows to remove queue_alignment_offset entirely.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/genhd.c          | 2 +-
 include/linux/blkdev.h | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index b8b6759d670f0..712031ce19070 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1010,7 +1010,7 @@ static ssize_t disk_alignment_offset_show(struct device *dev,
 {
 	struct gendisk *disk = dev_to_disk(dev);
 
-	return sprintf(buf, "%d\n", queue_alignment_offset(disk->queue));
+	return sprintf(buf, "%d\n", bdev_alignment_offset(disk->part0));
 }
 
 static ssize_t disk_discard_alignment_show(struct device *dev,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f8c50b77543eb..d5346e72e3645 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1251,14 +1251,6 @@ bdev_zone_write_granularity(struct block_device *bdev)
 	return queue_zone_write_granularity(bdev_get_queue(bdev));
 }
 
-static inline int queue_alignment_offset(const struct request_queue *q)
-{
-	if (q->limits.misaligned)
-		return -1;
-
-	return q->limits.alignment_offset;
-}
-
 static inline int queue_limit_alignment_offset(struct queue_limits *lim, sector_t sector)
 {
 	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305252.520225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE5q-00040p-Fo; Fri, 15 Apr 2022 05:02:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305252.520225; Fri, 15 Apr 2022 05:02:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE5q-00040f-CI; Fri, 15 Apr 2022 05:02:02 +0000
Received: by outflank-mailman (input) for mailman id 305252;
 Fri, 15 Apr 2022 05:02:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyH-0004TJ-NG
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:13 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 144db865-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:54:07 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxy-008PKU-DT; Fri, 15 Apr 2022 04:53:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 144db865-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=V+N3WPhcjqbqmVRPAoIxuBjo6dgh1f5KuPVQDpaEGEs=; b=nvLDGsPTiAetPju9xhjyf64KX7
	7ozMCWWCzv+ARhNAuWIGIewpeBs3t3aim/vmyIsXxJJQ8D6e6M3a/IJbXoQcPtzLYF8SFlKXBpOqM
	ETxPrnhTBR4f07V6gtDeEqdGfb51nKXQBTRpYPNUhpzcsR3DXwU2yZKBDkC9971ryVgupM8yHNByX
	XVPHLYl9bzyBrPwqQLBM+QwlQjI8z/UzTo262uc5gVNBSBEUT1iHLOtxrGXvyRuwX4DfSfPrfgzSz
	mZOGRfCY5mWiQtABTIuaX0+Vh6+ub+qekGvIjW8PCF25qEYReZ47iYhf1WPmN6PzqNTyFHnP9LWNJ
	HQK2650A==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 16/27] block: use bdev_alignment_offset in part_alignment_offset_show
Date: Fri, 15 Apr 2022 06:52:47 +0200
Message-Id: <20220415045258.199825-17-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Replace the open coded offset calculation with the proper helper.
This is an ABI change in that the -1 for a misaligned partition is
properly propagated, which can be considered a bug fix and matches
what is done on the whole device.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/partitions/core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 2ef8dfa1e5c85..240b3fff521e4 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -200,11 +200,7 @@ static ssize_t part_ro_show(struct device *dev,
 static ssize_t part_alignment_offset_show(struct device *dev,
 					  struct device_attribute *attr, char *buf)
 {
-	struct block_device *bdev = dev_to_bdev(dev);
-
-	return sprintf(buf, "%u\n",
-		queue_limit_alignment_offset(&bdev_get_queue(bdev)->limits,
-				bdev->bd_start_sect));
+	return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));
 }
 
 static ssize_t part_discard_alignment_show(struct device *dev,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305254.520237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE5s-0004If-Oc; Fri, 15 Apr 2022 05:02:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305254.520237; Fri, 15 Apr 2022 05:02:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE5s-0004IW-LI; Fri, 15 Apr 2022 05:02:04 +0000
Received: by outflank-mailman (input) for mailman id 305254;
 Fri, 15 Apr 2022 05:02:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyL-0004TJ-O4
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:17 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19bc1bae-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:54:16 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDy3-008PQw-Ke; Fri, 15 Apr 2022 04:54:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19bc1bae-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=LA03+v2RMrt5LLwAfTBpcNFXpYhSXKyM/LEXrkZN1Tc=; b=LADyBsuLQpSvZVOI9iNu3zFf2Z
	SEH5za8/XrvPRuwh4TwHe7OlvnSu6j9qkRRGGecLPPLsoWIvS7KxzQE5AizDIz9MvjgfVsuNp13Eq
	ZByoLLOiZSAgO2FmaZjLKmy35f7AqZ0bRkQXyFt0KFpuATixmIymK5iv+aV8uMY/BiO9z1ISlyebq
	wDQWs1lYdYUlF31lbm99N6Kdbl82pDjKi5m2oYGDMZ/ESoukEtgyT6rpjPpocnNkNMxqHhSPxrha3
	uTQvCNZSoso625zW5i+ex0gK0vrdhQ8qDshZOw3gMwuVl8MKqYXFvH6egXHkAdYDBWWCkoyT5Gevx
	A5jRU7mg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line
Date: Fri, 15 Apr 2022 06:52:49 +0200
Message-Id: <20220415045258.199825-19-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

No need to inline these fairly larger helpers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/blk-settings.c   | 23 +++++++++++++++++++++++
 include/linux/blkdev.h | 21 +--------------------
 2 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index b83df3d2eebca..94410a13c0dee 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -468,6 +468,16 @@ void blk_queue_io_opt(struct request_queue *q, unsigned int opt)
 }
 EXPORT_SYMBOL(blk_queue_io_opt);
 
+static int queue_limit_alignment_offset(struct queue_limits *lim,
+		sector_t sector)
+{
+	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
+	unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
+		<< SECTOR_SHIFT;
+
+	return (granularity + lim->alignment_offset - alignment) % granularity;
+}
+
 static unsigned int blk_round_down_sectors(unsigned int sectors, unsigned int lbs)
 {
 	sectors = round_down(sectors, lbs >> SECTOR_SHIFT);
@@ -901,3 +911,16 @@ void blk_queue_set_zoned(struct gendisk *disk, enum blk_zoned_model model)
 	}
 }
 EXPORT_SYMBOL_GPL(blk_queue_set_zoned);
+
+int bdev_alignment_offset(struct block_device *bdev)
+{
+	struct request_queue *q = bdev_get_queue(bdev);
+
+	if (q->limits.misaligned)
+		return -1;
+	if (bdev_is_partition(bdev))
+		return queue_limit_alignment_offset(&q->limits,
+				bdev->bd_start_sect);
+	return q->limits.alignment_offset;
+}
+EXPORT_SYMBOL_GPL(bdev_alignment_offset);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index d5346e72e3645..0a1795ac26275 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1251,26 +1251,7 @@ bdev_zone_write_granularity(struct block_device *bdev)
 	return queue_zone_write_granularity(bdev_get_queue(bdev));
 }
 
-static inline int queue_limit_alignment_offset(struct queue_limits *lim, sector_t sector)
-{
-	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
-	unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
-		<< SECTOR_SHIFT;
-
-	return (granularity + lim->alignment_offset - alignment) % granularity;
-}
-
-static inline int bdev_alignment_offset(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	if (q->limits.misaligned)
-		return -1;
-	if (bdev_is_partition(bdev))
-		return queue_limit_alignment_offset(&q->limits,
-				bdev->bd_start_sect);
-	return q->limits.alignment_offset;
-}
+int bdev_alignment_offset(struct block_device *bdev);
 
 static inline int queue_discard_alignment(const struct request_queue *q)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305255.520248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE5v-0004c3-Bq; Fri, 15 Apr 2022 05:02:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305255.520248; Fri, 15 Apr 2022 05:02:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE5u-0004bk-UL; Fri, 15 Apr 2022 05:02:06 +0000
Received: by outflank-mailman (input) for mailman id 305255;
 Fri, 15 Apr 2022 05:02:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyT-0004TJ-QW
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:25 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1e6024c9-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:54:24 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDyD-008Pdc-VZ; Fri, 15 Apr 2022 04:54:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e6024c9-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=GLA2nAe/cQO5WqFsrtbqfq8T3xUan5SkfUOusFqqAns=; b=VsGSXhUuIEFuRZtndYvZ6/P8Oc
	BDcT4E1kdUm0zMpQr8vfARZ9SBXzHbIzUwD1GYcduf3i506YLp6g548TDVxAtbp8KULMmrxF/ukva
	fgeigpWf0NIDRQPagvS6VzFyZpJ3xcSZOqt1eMagBiZEETs+p7tuGOEblnRA/Ubh/DSR79GR69y6j
	FXiQ7FqkrDKHIdBeDoZ8IY+N1d7emzC5iIlTdFynPRNmDVt0LMc9eg28VMj13kA7fa+HCrkwQXu48
	dUI7fDaAt8ItsFFi9XzyzHuoHEFOt6Vg27L4pMYHOgWMn9i+eAuB2cLGlEi8YHAGqnLzqjEoo43U0
	EggVK9WA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Coly Li <colyli@suse.de>
Subject: [PATCH 22/27] block: refactor discard bio size limiting
Date: Fri, 15 Apr 2022 06:52:53 +0200
Message-Id: <20220415045258.199825-23-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Coly Li <colyli@suse.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 4ea5167dc3392..434017701403f 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305271.520258 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE65-0005Jd-Hf; Fri, 15 Apr 2022 05:02:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305271.520258; Fri, 15 Apr 2022 05:02:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE65-0005JP-Dx; Fri, 15 Apr 2022 05:02:17 +0000
Received: by outflank-mailman (input) for mailman id 305271;
 Fri, 15 Apr 2022 05:02:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDye-0004b8-KV
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:36 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 246a1773-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:54:34 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDyR-008Ptb-2k; Fri, 15 Apr 2022 04:54:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 246a1773-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=eypoqjBCbHteIGJMjEE77faduCfiNIsAQ0ydQeu7OQ0=; b=yel/I7wJHKQGgU++DGlNr4s6By
	PhYVQZj76IsIJmZMeImq5Q6B2/aQRkMD3ug5dWOU3Jeh5aspjbtIuEjPut08JeM1WmCeQvYQ+tJ0f
	U696Xi8dd1qtuDaSpjLkD+EO876944juvaQn7mqYu4AmZhVRFKFIBWZURNzhkvK80mkS4SdYE8ghg
	5kwkeIFA+dIpz0sffz1xoP4BK6LoTUtTMKLOpm6yB1H7oV7nfL4grqbNBsJP5+jCEy6k9Hq/bQASA
	9dlkqzozrnkdCC5ckIaWKU5KZigzG6TnQjnKvn/KI4zIY9eR4oRyKCNwIxfdzpwno3WYuY2QxxbuI
	z9ygJJXA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 27/27] direct-io: remove random prefetches
Date: Fri, 15 Apr 2022 06:52:58 +0200
Message-Id: <20220415045258.199825-28-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Randomly poking into block device internals for manual prefetches isn't
exactly a very maintainable thing to do.  And none of the performance
criticil direct I/O implementations still use this library function
anyway, so just drop it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/direct-io.c | 32 ++++----------------------------
 1 file changed, 4 insertions(+), 28 deletions(-)

diff --git a/fs/direct-io.c b/fs/direct-io.c
index aef06e607b405..840752006f601 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -1115,11 +1115,10 @@ static inline int drop_refcount(struct dio *dio)
  * individual fields and will generate much worse code. This is important
  * for the whole file.
  */
-static inline ssize_t
-do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
-		      struct block_device *bdev, struct iov_iter *iter,
-		      get_block_t get_block, dio_iodone_t end_io,
-		      dio_submit_t submit_io, int flags)
+ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
+		struct block_device *bdev, struct iov_iter *iter,
+		get_block_t get_block, dio_iodone_t end_io,
+		dio_submit_t submit_io, int flags)
 {
 	unsigned i_blkbits = READ_ONCE(inode->i_blkbits);
 	unsigned blkbits = i_blkbits;
@@ -1334,29 +1333,6 @@ do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
 	kmem_cache_free(dio_cache, dio);
 	return retval;
 }
-
-ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
-			     struct block_device *bdev, struct iov_iter *iter,
-			     get_block_t get_block,
-			     dio_iodone_t end_io, dio_submit_t submit_io,
-			     int flags)
-{
-	/*
-	 * The block device state is needed in the end to finally
-	 * submit everything.  Since it's likely to be cache cold
-	 * prefetch it here as first thing to hide some of the
-	 * latency.
-	 *
-	 * Attempt to prefetch the pieces we likely need later.
-	 */
-	prefetch(&bdev->bd_disk->part_tbl);
-	prefetch(bdev->bd_disk->queue);
-	prefetch((char *)bdev->bd_disk->queue + SMP_CACHE_BYTES);
-
-	return do_blockdev_direct_IO(iocb, inode, bdev, iter, get_block,
-				     end_io, submit_io, flags);
-}
-
 EXPORT_SYMBOL(__blockdev_direct_IO);
 
 static __init int dio_init(void)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305272.520263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE65-0005OG-Tj; Fri, 15 Apr 2022 05:02:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305272.520263; Fri, 15 Apr 2022 05:02:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE65-0005NL-Nl; Fri, 15 Apr 2022 05:02:17 +0000
Received: by outflank-mailman (input) for mailman id 305272;
 Fri, 15 Apr 2022 05:02:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyD-0004b8-1c
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:09 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 125374be-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:54:04 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxt-008PFj-9w; Fri, 15 Apr 2022 04:53:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 125374be-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=2RG8/4DncVNJBVxiwRZlDWFw3of1TwdfVdHLgkB+Spw=; b=TPuJfqXQYB+IC35ZbEz9CiQlaP
	djXIx0VTkzhzaYzpf2LZ0DDooPinTXguiju0AYCGSu3XAhEA+wzVismYaoX+3FR9eNAg3biu1OIj0
	CNWcQrqG9KwJqTbS05bqC74Hcp5G8fJ5Dpqbc41a5wovtXyrz6AnrzdO6HJSlv+co9m5WLmUX5I/2
	1vg6dJgX8fRkFI9MMSOkSfnCdkNwHb1kqsdqtSSukL34iYYeRnM6jabi2m1nx/iB0bJqJyAfSKPi1
	QfdCggnyqMztz/KBp1d+dGH+Q0SMobP0ybTMhNnUN2Xr4FneN5Nr0VM4ULPM98M5hdJ71ysDrIM3k
	XuXkKxgg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 14/27] block: add a bdev_stable_writes helper
Date: Fri, 15 Apr 2022 06:52:45 +0200
Message-Id: <20220415045258.199825-15-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the stable writes flag based on the block_device
instead of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/md/dm-table.c  | 4 +---
 fs/super.c             | 2 +-
 include/linux/blkdev.h | 6 ++++++
 mm/swapfile.c          | 2 +-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 5e38d0dd009d5..d46839faa0ca5 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1950,9 +1950,7 @@ static int device_requires_stable_pages(struct dm_target *ti,
 					struct dm_dev *dev, sector_t start,
 					sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return blk_queue_stable_writes(q);
+	return bdev_stable_writes(dev->bdev);
 }
 
 int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
diff --git a/fs/super.c b/fs/super.c
index f1d4a193602d6..60f57c7bc0a69 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1204,7 +1204,7 @@ static int set_bdev_super(struct super_block *s, void *data)
 	s->s_dev = s->s_bdev->bd_dev;
 	s->s_bdi = bdi_get(s->s_bdev->bd_disk->bdi);
 
-	if (blk_queue_stable_writes(s->s_bdev->bd_disk->queue))
+	if (bdev_stable_writes(s->s_bdev))
 		s->s_iflags |= SB_I_STABLE_WRITES;
 	return 0;
 }
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 075b16d4560e7..a433798c3343e 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1330,6 +1330,12 @@ static inline bool bdev_nonrot(struct block_device *bdev)
 	return blk_queue_nonrot(bdev_get_queue(bdev));
 }
 
+static inline bool bdev_stable_writes(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_STABLE_WRITES,
+			&bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline bool bdev_write_cache(struct block_device *bdev)
 {
 	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index d5ab7ec4d92ca..4069f17a82c8e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -3065,7 +3065,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 		goto bad_swap_unlock_inode;
 	}
 
-	if (p->bdev && blk_queue_stable_writes(p->bdev->bd_disk->queue))
+	if (p->bdev && bdev_stable_writes(p->bdev))
 		p->flags |= SWP_STABLE_WRITES;
 
 	if (p->bdev && p->bdev->bd_disk->fops->rw_page)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305279.520280 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6A-000695-CJ; Fri, 15 Apr 2022 05:02:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305279.520280; Fri, 15 Apr 2022 05:02:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6A-00068a-7t; Fri, 15 Apr 2022 05:02:22 +0000
Received: by outflank-mailman (input) for mailman id 305279;
 Fri, 15 Apr 2022 05:02:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyf-0004TJ-Qi
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:38 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 24228354-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:54:34 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDyJ-008PkB-3y; Fri, 15 Apr 2022 04:54:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24228354-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=JEp+Ydky4hX/95I7Lm2zDDRxFAsMkADcWxP2d9kmm+k=; b=qsTDfotmtIWHWraU2dgGVjIKy/
	C8gTlmi51yWMclX54ORFg7Xna22avP3VcyiXLYBC6nR19lbVENNopVJ9tQGKgQy04iWEaJit4uDtN
	KQhTJamDnRgtj1KkFNuR9gefCo+gNrgNnOWwTkGS9hkFTQu7vnpYzsSyXBC1wEK5I+vUB41wYHdql
	4XWbh8XjCfzVsn8dXva3n3BSPwQT7BQDgyMt4id2YqsEF5oM+pQUbkIbjwYtgr1GpPU7BSmSRTPF+
	FYEjAb9JYAnCoiewCCJgGkFfvJ0Vto4uuR3qScpniY79wd9YisLWyxKpjL/zI/YKfvEqQHCtRnFM/
	wD74URHg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>,
	=?UTF-8?q?Jan=20H=C3=B6ppner?= <hoeppner@linux.ibm.com>,
	Coly Li <colyli@suse.de>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Date: Fri, 15 Apr 2022 06:52:55 +0200
Message-Id: <20220415045258.199825-25-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Just use a non-zero max_discard_sectors as an indicator for discard
support, similar to what is done for write zeroes.

The only places where needs special attention is the RAID5 driver,
which must clear discard support for security reasons by default,
even if the default stacking rules would allow for it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
Acked-by: Jan Höppner <hoeppner@linux.ibm.com> [s390]
Acked-by: Coly Li <colyli@suse.de> [bcache]
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 arch/um/drivers/ubd_kern.c          |  2 --
 block/blk-core.c                    |  2 +-
 block/blk-lib.c                     |  2 +-
 block/blk-mq-debugfs.c              |  1 -
 block/ioctl.c                       |  3 +--
 drivers/block/drbd/drbd_main.c      |  2 +-
 drivers/block/drbd/drbd_nl.c        | 19 ++-----------------
 drivers/block/drbd/drbd_receiver.c  |  3 +--
 drivers/block/loop.c                | 11 +++--------
 drivers/block/nbd.c                 |  5 +----
 drivers/block/null_blk/main.c       |  1 -
 drivers/block/rbd.c                 |  1 -
 drivers/block/rnbd/rnbd-clt.c       |  2 --
 drivers/block/rnbd/rnbd-srv-dev.h   |  3 ---
 drivers/block/virtio_blk.c          |  2 --
 drivers/block/xen-blkback/xenbus.c  |  2 +-
 drivers/block/xen-blkfront.c        |  3 +--
 drivers/block/zram/zram_drv.c       |  1 -
 drivers/md/bcache/request.c         |  4 ++--
 drivers/md/bcache/super.c           |  3 +--
 drivers/md/bcache/sysfs.c           |  2 +-
 drivers/md/dm-cache-target.c        |  9 +--------
 drivers/md/dm-clone-target.c        |  9 +--------
 drivers/md/dm-log-writes.c          |  3 +--
 drivers/md/dm-raid.c                |  9 ++-------
 drivers/md/dm-table.c               |  9 ++-------
 drivers/md/dm-thin.c                | 11 +----------
 drivers/md/dm.c                     |  3 +--
 drivers/md/md-linear.c              | 11 +----------
 drivers/md/raid0.c                  |  7 -------
 drivers/md/raid1.c                  | 16 +---------------
 drivers/md/raid10.c                 | 18 ++----------------
 drivers/md/raid5-cache.c            |  2 +-
 drivers/md/raid5.c                  | 12 ++++--------
 drivers/mmc/core/queue.c            |  1 -
 drivers/mtd/mtd_blkdevs.c           |  1 -
 drivers/nvme/host/core.c            |  4 ++--
 drivers/s390/block/dasd_fba.c       |  1 -
 drivers/scsi/sd.c                   |  2 --
 drivers/target/target_core_device.c |  2 +-
 fs/btrfs/extent-tree.c              |  4 ++--
 fs/btrfs/ioctl.c                    |  2 +-
 fs/exfat/file.c                     |  2 +-
 fs/exfat/super.c                    | 10 +++-------
 fs/ext4/ioctl.c                     | 10 +++-------
 fs/ext4/super.c                     | 10 +++-------
 fs/f2fs/f2fs.h                      |  3 +--
 fs/fat/file.c                       |  2 +-
 fs/fat/inode.c                      | 10 +++-------
 fs/gfs2/rgrp.c                      |  2 +-
 fs/jbd2/journal.c                   |  7 ++-----
 fs/jfs/ioctl.c                      |  2 +-
 fs/jfs/super.c                      |  8 ++------
 fs/nilfs2/ioctl.c                   |  2 +-
 fs/ntfs3/file.c                     |  2 +-
 fs/ntfs3/super.c                    |  2 +-
 fs/ocfs2/ioctl.c                    |  2 +-
 fs/xfs/xfs_discard.c                |  2 +-
 fs/xfs/xfs_super.c                  | 12 ++++--------
 include/linux/blkdev.h              |  2 --
 mm/swapfile.c                       | 17 ++---------------
 61 files changed, 73 insertions(+), 244 deletions(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index b03269faef714..085ffdf98e57e 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -483,7 +483,6 @@ static void ubd_handler(void)
 			if ((io_req->error == BLK_STS_NOTSUPP) && (req_op(io_req->req) == REQ_OP_DISCARD)) {
 				blk_queue_max_discard_sectors(io_req->req->q, 0);
 				blk_queue_max_write_zeroes_sectors(io_req->req->q, 0);
-				blk_queue_flag_clear(QUEUE_FLAG_DISCARD, io_req->req->q);
 			}
 			blk_mq_end_request(io_req->req, io_req->error);
 			kfree(io_req);
@@ -803,7 +802,6 @@ static int ubd_open_dev(struct ubd *ubd_dev)
 		ubd_dev->queue->limits.discard_alignment = SECTOR_SIZE;
 		blk_queue_max_discard_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
 		blk_queue_max_write_zeroes_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, ubd_dev->queue);
 	}
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, ubd_dev->queue);
 	return 0;
diff --git a/block/blk-core.c b/block/blk-core.c
index 937bb6b863317..b5c3a8049134c 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -820,7 +820,7 @@ void submit_bio_noacct(struct bio *bio)
 
 	switch (bio_op(bio)) {
 	case REQ_OP_DISCARD:
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(bdev))
 			goto not_supported;
 		break;
 	case REQ_OP_SECURE_ERASE:
diff --git a/block/blk-lib.c b/block/blk-lib.c
index 2ae32a722851c..8b4b66d3a9bfc 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -53,7 +53,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 			return -EOPNOTSUPP;
 		op = REQ_OP_SECURE_ERASE;
 	} else {
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(bdev))
 			return -EOPNOTSUPP;
 		op = REQ_OP_DISCARD;
 	}
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index aa0349e9f083b..fd111c5001256 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -113,7 +113,6 @@ static const char *const blk_queue_flag_name[] = {
 	QUEUE_FLAG_NAME(FAIL_IO),
 	QUEUE_FLAG_NAME(NONROT),
 	QUEUE_FLAG_NAME(IO_STAT),
-	QUEUE_FLAG_NAME(DISCARD),
 	QUEUE_FLAG_NAME(NOXMERGES),
 	QUEUE_FLAG_NAME(ADD_RANDOM),
 	QUEUE_FLAG_NAME(SECERASE),
diff --git a/block/ioctl.c b/block/ioctl.c
index ad3771b268b81..c2cd3ba5290ce 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -87,14 +87,13 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
 {
 	uint64_t range[2];
 	uint64_t start, len;
-	struct request_queue *q = bdev_get_queue(bdev);
 	struct inode *inode = bdev->bd_inode;
 	int err;
 
 	if (!(mode & FMODE_WRITE))
 		return -EBADF;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(range, (void __user *)arg, sizeof(range)))
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 7b501c8d59928..912560f611c35 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -942,7 +942,7 @@ int drbd_send_sizes(struct drbd_peer_device *peer_device, int trigger_reply, enu
 			cpu_to_be32(bdev_alignment_offset(bdev));
 		p->qlim->io_min = cpu_to_be32(bdev_io_min(bdev));
 		p->qlim->io_opt = cpu_to_be32(bdev_io_opt(bdev));
-		p->qlim->discard_enabled = blk_queue_discard(q);
+		p->qlim->discard_enabled = !!bdev_max_discard_sectors(bdev);
 		put_ldev(device);
 	} else {
 		struct request_queue *q = device->rq_queue;
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index a0a06e238e917..0678ceb505799 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1210,7 +1210,7 @@ static void decide_on_discard_support(struct drbd_device *device,
 		first_peer_device(device)->connection;
 	struct request_queue *q = device->rq_queue;
 
-	if (bdev && !blk_queue_discard(bdev->backing_bdev->bd_disk->queue))
+	if (bdev && !bdev_max_discard_sectors(bdev->backing_bdev))
 		goto not_supported;
 
 	if (connection->cstate >= C_CONNECTED &&
@@ -1230,30 +1230,16 @@ static void decide_on_discard_support(struct drbd_device *device,
 	 */
 	blk_queue_discard_granularity(q, 512);
 	q->limits.max_discard_sectors = drbd_max_discard_sectors(connection);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	q->limits.max_write_zeroes_sectors =
 		drbd_max_discard_sectors(connection);
 	return;
 
 not_supported:
-	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 	blk_queue_discard_granularity(q, 0);
 	q->limits.max_discard_sectors = 0;
 	q->limits.max_write_zeroes_sectors = 0;
 }
 
-static void fixup_discard_if_not_supported(struct request_queue *q)
-{
-	/* To avoid confusion, if this queue does not support discard, clear
-	 * max_discard_sectors, which is what lsblk -D reports to the user.
-	 * Older kernels got this wrong in "stack limits".
-	 * */
-	if (!blk_queue_discard(q)) {
-		blk_queue_max_discard_sectors(q, 0);
-		blk_queue_discard_granularity(q, 0);
-	}
-}
-
 static void fixup_write_zeroes(struct drbd_device *device, struct request_queue *q)
 {
 	/* Fixup max_write_zeroes_sectors after blk_stack_limits():
@@ -1300,7 +1286,6 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
 		blk_stack_limits(&q->limits, &b->limits, 0);
 		disk_update_readahead(device->vdisk);
 	}
-	fixup_discard_if_not_supported(q);
 	fixup_write_zeroes(device, q);
 }
 
@@ -1447,7 +1432,7 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 	if (disk_conf->al_extents > drbd_al_extents_max(nbc))
 		disk_conf->al_extents = drbd_al_extents_max(nbc);
 
-	if (!blk_queue_discard(q)) {
+	if (!bdev_max_discard_sectors(bdev)) {
 		if (disk_conf->rs_discard_granularity) {
 			disk_conf->rs_discard_granularity = 0; /* disable feature */
 			drbd_info(device, "rs_discard_granularity feature disabled\n");
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 0b4c7de463989..8a4a47da56fe9 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1575,11 +1575,10 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 
 static bool can_do_reliable_discards(struct drbd_device *device)
 {
-	struct request_queue *q = bdev_get_queue(device->ldev->backing_bdev);
 	struct disk_conf *dc;
 	bool can_do;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(device->ldev->backing_bdev))
 		return false;
 
 	rcu_read_lock();
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 8d800d46e4985..0e061c9896eff 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -314,15 +314,12 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
 
 	mode |= FALLOC_FL_KEEP_SIZE;
 
-	if (!blk_queue_discard(lo->lo_queue)) {
-		ret = -EOPNOTSUPP;
-		goto out;
-	}
+	if (!bdev_max_discard_sectors(lo->lo_device))
+		return -EOPNOTSUPP;
 
 	ret = file->f_op->fallocate(file, mode, pos, blk_rq_bytes(rq));
 	if (unlikely(ret && ret != -EINVAL && ret != -EOPNOTSUPP))
-		ret = -EIO;
- out:
+		return -EIO;
 	return ret;
 }
 
@@ -787,12 +784,10 @@ static void loop_config_discard(struct loop_device *lo)
 		q->limits.discard_granularity = granularity;
 		blk_queue_max_discard_sectors(q, max_discard_sectors);
 		blk_queue_max_write_zeroes_sectors(q, max_discard_sectors);
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	} else {
 		q->limits.discard_granularity = 0;
 		blk_queue_max_discard_sectors(q, 0);
 		blk_queue_max_write_zeroes_sectors(q, 0);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 	}
 	q->limits.discard_alignment = 0;
 }
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 5a1f98494dddf..4729aef8c6462 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1231,8 +1231,6 @@ static void nbd_parse_flags(struct nbd_device *nbd)
 		set_disk_ro(nbd->disk, true);
 	else
 		set_disk_ro(nbd->disk, false);
-	if (config->flags & NBD_FLAG_SEND_TRIM)
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, nbd->disk->queue);
 	if (config->flags & NBD_FLAG_SEND_FLUSH) {
 		if (config->flags & NBD_FLAG_SEND_FUA)
 			blk_queue_write_cache(nbd->disk->queue, true, true);
@@ -1319,8 +1317,7 @@ static void nbd_config_put(struct nbd_device *nbd)
 		nbd->tag_set.timeout = 0;
 		nbd->disk->queue->limits.discard_granularity = 0;
 		nbd->disk->queue->limits.discard_alignment = 0;
-		blk_queue_max_discard_sectors(nbd->disk->queue, UINT_MAX);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, nbd->disk->queue);
+		blk_queue_max_discard_sectors(nbd->disk->queue, 0);
 
 		mutex_unlock(&nbd->config_lock);
 		nbd_put(nbd);
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 05b1120e66234..f6493a9e85ed3 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1767,7 +1767,6 @@ static void null_config_discard(struct nullb *nullb)
 	nullb->q->limits.discard_granularity = nullb->dev->blocksize;
 	nullb->q->limits.discard_alignment = nullb->dev->blocksize;
 	blk_queue_max_discard_sectors(nullb->q, UINT_MAX >> 9);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, nullb->q);
 }
 
 static const struct block_device_operations null_bio_ops = {
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index b844432bad20b..2b21f717cce1a 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -4942,7 +4942,6 @@ static int rbd_init_disk(struct rbd_device *rbd_dev)
 	blk_queue_io_opt(q, rbd_dev->opts->alloc_size);
 
 	if (rbd_dev->opts->trim) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 		q->limits.discard_granularity = rbd_dev->opts->alloc_size;
 		blk_queue_max_discard_sectors(q, objset_bytes >> SECTOR_SHIFT);
 		blk_queue_max_write_zeroes_sectors(q, objset_bytes >> SECTOR_SHIFT);
diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index b66e8840b94b8..efa99a3884507 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1364,8 +1364,6 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
 	blk_queue_max_discard_sectors(dev->queue, dev->max_discard_sectors);
 	dev->queue->limits.discard_granularity	= dev->discard_granularity;
 	dev->queue->limits.discard_alignment	= dev->discard_alignment;
-	if (dev->max_discard_sectors)
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, dev->queue);
 	if (dev->secure_discard)
 		blk_queue_flag_set(QUEUE_FLAG_SECERASE, dev->queue);
 
diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index f82fbb4bbda8e..1f7e1c8fd4d9b 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -49,9 +49,6 @@ static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
 
 static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
 {
-	if (!blk_queue_discard(bdev_get_queue(dev->bdev)))
-		return 0;
-
 	return bdev_max_discard_sectors(dev->bdev);
 }
 
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index a8bcf3f664af1..6ccf15253dee1 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -888,8 +888,6 @@ static int virtblk_probe(struct virtio_device *vdev)
 			v = sg_elems;
 		blk_queue_max_discard_segments(q,
 					       min(v, MAX_DISCARD_SEGMENTS));
-
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	}
 
 	if (virtio_has_feature(vdev, VIRTIO_BLK_F_WRITE_ZEROES)) {
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 8b691fe50475f..83cd08041e6b3 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -583,7 +583,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
 	if (!xenbus_read_unsigned(dev->nodename, "discard-enable", 1))
 		return;
 
-	if (blk_queue_discard(q)) {
+	if (bdev_max_discard_sectors(bdev)) {
 		err = xenbus_printf(xbt, dev->nodename,
 			"discard-granularity", "%u",
 			q->limits.discard_granularity);
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 003056d4f7f5f..e13cb4d48f1ea 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -944,7 +944,6 @@ static void blkif_set_queue_limits(struct blkfront_info *info)
 	blk_queue_flag_set(QUEUE_FLAG_VIRT, rq);
 
 	if (info->feature_discard) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, rq);
 		blk_queue_max_discard_sectors(rq, get_capacity(gd));
 		rq->limits.discard_granularity = info->discard_granularity ?:
 						 info->physical_sector_size;
@@ -1606,7 +1605,7 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
 				blkif_req(req)->error = BLK_STS_NOTSUPP;
 				info->feature_discard = 0;
 				info->feature_secdiscard = 0;
-				blk_queue_flag_clear(QUEUE_FLAG_DISCARD, rq);
+				blk_queue_max_discard_sectors(rq, 0);
 				blk_queue_flag_clear(QUEUE_FLAG_SECERASE, rq);
 			}
 			break;
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index e9474b02012de..59ff444bf6c76 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1952,7 +1952,6 @@ static int zram_add(void)
 	blk_queue_io_opt(zram->disk->queue, PAGE_SIZE);
 	zram->disk->queue->limits.discard_granularity = PAGE_SIZE;
 	blk_queue_max_discard_sectors(zram->disk->queue, UINT_MAX);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, zram->disk->queue);
 
 	/*
 	 * zram_bio_discard() will clear all logical blocks if logical block
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index fdd0194f84dd0..e27f67f06a428 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1005,7 +1005,7 @@ static void cached_dev_write(struct cached_dev *dc, struct search *s)
 		bio_get(s->iop.bio);
 
 		if (bio_op(bio) == REQ_OP_DISCARD &&
-		    !blk_queue_discard(bdev_get_queue(dc->bdev)))
+		    !bdev_max_discard_sectors(dc->bdev))
 			goto insert_data;
 
 		/* I/O request sent to backing device */
@@ -1115,7 +1115,7 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
 	bio->bi_private = ddip;
 
 	if ((bio_op(bio) == REQ_OP_DISCARD) &&
-	    !blk_queue_discard(bdev_get_queue(dc->bdev)))
+	    !bdev_max_discard_sectors(dc->bdev))
 		bio->bi_end_io(bio);
 	else
 		submit_bio_noacct(bio);
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index bf3de149d3c9f..2f49e31142f62 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -973,7 +973,6 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
 
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, d->disk->queue);
 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, d->disk->queue);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, d->disk->queue);
 
 	blk_queue_write_cache(q, true, true);
 
@@ -2350,7 +2349,7 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
 	ca->bdev->bd_holder = ca;
 	ca->sb_disk = sb_disk;
 
-	if (blk_queue_discard(bdev_get_queue(bdev)))
+	if (bdev_max_discard_sectors((bdev)))
 		ca->discard = CACHE_DISCARD(&ca->sb);
 
 	ret = cache_alloc(ca);
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index d1029d71ff3bc..c6f677059214d 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -1151,7 +1151,7 @@ STORE(__bch_cache)
 	if (attr == &sysfs_discard) {
 		bool v = strtoul_or_return(buf);
 
-		if (blk_queue_discard(bdev_get_queue(ca->bdev)))
+		if (bdev_max_discard_sectors(ca->bdev))
 			ca->discard = v;
 
 		if (v != CACHE_DISCARD(&ca->sb)) {
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 780a61bc6cc03..28c5de8eca4a0 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -3329,13 +3329,6 @@ static int cache_iterate_devices(struct dm_target *ti,
 	return r;
 }
 
-static bool origin_dev_supports_discard(struct block_device *origin_bdev)
-{
-	struct request_queue *q = bdev_get_queue(origin_bdev);
-
-	return blk_queue_discard(q);
-}
-
 /*
  * If discard_passdown was enabled verify that the origin device
  * supports discards.  Disable discard_passdown if not.
@@ -3349,7 +3342,7 @@ static void disable_passdown_if_not_supported(struct cache *cache)
 	if (!cache->features.discard_passdown)
 		return;
 
-	if (!origin_dev_supports_discard(origin_bdev))
+	if (!bdev_max_discard_sectors(origin_bdev))
 		reason = "discard unsupported";
 
 	else if (origin_limits->max_discard_sectors < cache->sectors_per_block)
diff --git a/drivers/md/dm-clone-target.c b/drivers/md/dm-clone-target.c
index 128316a73d016..811b0a5379d03 100644
--- a/drivers/md/dm-clone-target.c
+++ b/drivers/md/dm-clone-target.c
@@ -2016,13 +2016,6 @@ static void clone_resume(struct dm_target *ti)
 	do_waker(&clone->waker.work);
 }
 
-static bool bdev_supports_discards(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	return (q && blk_queue_discard(q));
-}
-
 /*
  * If discard_passdown was enabled verify that the destination device supports
  * discards. Disable discard_passdown if not.
@@ -2036,7 +2029,7 @@ static void disable_passdown_if_not_supported(struct clone *clone)
 	if (!test_bit(DM_CLONE_DISCARD_PASSDOWN, &clone->flags))
 		return;
 
-	if (!bdev_supports_discards(dest_dev))
+	if (!bdev_max_discard_sectors(dest_dev))
 		reason = "discard unsupported";
 	else if (dest_limits->max_discard_sectors < clone->region_size)
 		reason = "max discard sectors smaller than a region";
diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
index c9d036d6bb2ee..e194226c89e54 100644
--- a/drivers/md/dm-log-writes.c
+++ b/drivers/md/dm-log-writes.c
@@ -866,9 +866,8 @@ static int log_writes_message(struct dm_target *ti, unsigned argc, char **argv,
 static void log_writes_io_hints(struct dm_target *ti, struct queue_limits *limits)
 {
 	struct log_writes_c *lc = ti->private;
-	struct request_queue *q = bdev_get_queue(lc->dev->bdev);
 
-	if (!q || !blk_queue_discard(q)) {
+	if (!bdev_max_discard_sectors(lc->dev->bdev)) {
 		lc->device_supports_discard = false;
 		limits->discard_granularity = lc->sectorsize;
 		limits->max_discard_sectors = (UINT_MAX >> SECTOR_SHIFT);
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 2b26435a6946e..9526ccbedafba 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2963,13 +2963,8 @@ static void configure_discard_support(struct raid_set *rs)
 	raid456 = rs_is_raid456(rs);
 
 	for (i = 0; i < rs->raid_disks; i++) {
-		struct request_queue *q;
-
-		if (!rs->dev[i].rdev.bdev)
-			continue;
-
-		q = bdev_get_queue(rs->dev[i].rdev.bdev);
-		if (!q || !blk_queue_discard(q))
+		if (!rs->dev[i].rdev.bdev ||
+		    !bdev_max_discard_sectors(rs->dev[i].rdev.bdev))
 			return;
 
 		if (raid456) {
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index d46839faa0ca5..0dff6907fd00d 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1888,9 +1888,7 @@ static bool dm_table_supports_nowait(struct dm_table *t)
 static int device_not_discard_capable(struct dm_target *ti, struct dm_dev *dev,
 				      sector_t start, sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_discard(q);
+	return !bdev_max_discard_sectors(dev->bdev);
 }
 
 static bool dm_table_supports_discards(struct dm_table *t)
@@ -1970,15 +1968,12 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
 		blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);
 
 	if (!dm_table_supports_discards(t)) {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
-		/* Must also clear discard limits... */
 		q->limits.max_discard_sectors = 0;
 		q->limits.max_hw_discard_sectors = 0;
 		q->limits.discard_granularity = 0;
 		q->limits.discard_alignment = 0;
 		q->limits.discard_misaligned = 0;
-	} else
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
+	}
 
 	if (dm_table_supports_secure_erase(t))
 		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index 4d25d0e270313..eded4bcc4545f 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -2802,13 +2802,6 @@ static void requeue_bios(struct pool *pool)
 /*----------------------------------------------------------------
  * Binding of control targets to a pool object
  *--------------------------------------------------------------*/
-static bool data_dev_supports_discard(struct pool_c *pt)
-{
-	struct request_queue *q = bdev_get_queue(pt->data_dev->bdev);
-
-	return blk_queue_discard(q);
-}
-
 static bool is_factor(sector_t block_size, uint32_t n)
 {
 	return !sector_div(block_size, n);
@@ -2828,7 +2821,7 @@ static void disable_passdown_if_not_supported(struct pool_c *pt)
 	if (!pt->adjusted_pf.discard_passdown)
 		return;
 
-	if (!data_dev_supports_discard(pt))
+	if (!bdev_max_discard_sectors(pt->data_dev->bdev))
 		reason = "discard unsupported";
 
 	else if (data_limits->max_discard_sectors < pool->sectors_per_block)
@@ -4057,8 +4050,6 @@ static void pool_io_hints(struct dm_target *ti, struct queue_limits *limits)
 		/*
 		 * Must explicitly disallow stacking discard limits otherwise the
 		 * block layer will stack them if pool's data device has support.
-		 * QUEUE_FLAG_DISCARD wouldn't be set but there is no way for the
-		 * user to see that, so make sure to set all discard limits to 0.
 		 */
 		limits->discard_granularity = 0;
 		return;
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 3c5fad7c4ee68..dbbf64ce7e927 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -955,7 +955,6 @@ void disable_discard(struct mapped_device *md)
 
 	/* device doesn't really support DISCARD, disable it */
 	limits->max_discard_sectors = 0;
-	blk_queue_flag_clear(QUEUE_FLAG_DISCARD, md->queue);
 }
 
 void disable_write_zeroes(struct mapped_device *md)
@@ -982,7 +981,7 @@ static void clone_endio(struct bio *bio)
 
 	if (unlikely(error == BLK_STS_TARGET)) {
 		if (bio_op(bio) == REQ_OP_DISCARD &&
-		    !q->limits.max_discard_sectors)
+		    !bdev_max_discard_sectors(bio->bi_bdev))
 			disable_discard(md);
 		else if (bio_op(bio) == REQ_OP_WRITE_ZEROES &&
 			 !q->limits.max_write_zeroes_sectors)
diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
index 0f55b079371b1..138a3b25c5c82 100644
--- a/drivers/md/md-linear.c
+++ b/drivers/md/md-linear.c
@@ -64,7 +64,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 	struct linear_conf *conf;
 	struct md_rdev *rdev;
 	int i, cnt;
-	bool discard_supported = false;
 
 	conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL);
 	if (!conf)
@@ -96,9 +95,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 
 		conf->array_sectors += rdev->sectors;
 		cnt++;
-
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
-			discard_supported = true;
 	}
 	if (cnt != raid_disks) {
 		pr_warn("md/linear:%s: not enough drives present. Aborting!\n",
@@ -106,11 +102,6 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
 		goto out;
 	}
 
-	if (!discard_supported)
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, mddev->queue);
-	else
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
-
 	/*
 	 * Here we calculate the device offsets.
 	 */
@@ -252,7 +243,7 @@ static bool linear_make_request(struct mddev *mddev, struct bio *bio)
 		start_sector + data_offset;
 
 	if (unlikely((bio_op(bio) == REQ_OP_DISCARD) &&
-		     !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) {
+		     !bdev_max_discard_sectors(bio->bi_bdev))) {
 		/* Just ignore it */
 		bio_endio(bio);
 	} else {
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index b21e101183f44..7231f5e1eaa73 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -399,7 +399,6 @@ static int raid0_run(struct mddev *mddev)
 	conf = mddev->private;
 	if (mddev->queue) {
 		struct md_rdev *rdev;
-		bool discard_supported = false;
 
 		blk_queue_max_hw_sectors(mddev->queue, mddev->chunk_sectors);
 		blk_queue_max_write_zeroes_sectors(mddev->queue, mddev->chunk_sectors);
@@ -412,13 +411,7 @@ static int raid0_run(struct mddev *mddev)
 		rdev_for_each(rdev, mddev) {
 			disk_stack_limits(mddev->gendisk, rdev->bdev,
 					  rdev->data_offset << 9);
-			if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
-				discard_supported = true;
 		}
-		if (!discard_supported)
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD, mddev->queue);
-		else
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 	}
 
 	/* calculate array device size */
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index d81b896855f9f..3da749d150a17 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -802,7 +802,7 @@ static void flush_bio_list(struct r1conf *conf, struct bio *bio)
 		if (test_bit(Faulty, &rdev->flags)) {
 			bio_io_error(bio);
 		} else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) &&
-				    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+				    !bdev_max_discard_sectors(bio->bi_bdev)))
 			/* Just ignore it */
 			bio_endio(bio);
 		else
@@ -1826,8 +1826,6 @@ static int raid1_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 			break;
 		}
 	}
-	if (mddev->queue && blk_queue_discard(bdev_get_queue(rdev->bdev)))
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 	print_conf(conf);
 	return err;
 }
@@ -3106,7 +3104,6 @@ static int raid1_run(struct mddev *mddev)
 	int i;
 	struct md_rdev *rdev;
 	int ret;
-	bool discard_supported = false;
 
 	if (mddev->level != 1) {
 		pr_warn("md/raid1:%s: raid level not set to mirroring (%d)\n",
@@ -3141,8 +3138,6 @@ static int raid1_run(struct mddev *mddev)
 			continue;
 		disk_stack_limits(mddev->gendisk, rdev->bdev,
 				  rdev->data_offset << 9);
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
-			discard_supported = true;
 	}
 
 	mddev->degraded = 0;
@@ -3179,15 +3174,6 @@ static int raid1_run(struct mddev *mddev)
 
 	md_set_array_sectors(mddev, raid1_size(mddev, 0, 0));
 
-	if (mddev->queue) {
-		if (discard_supported)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						  mddev->queue);
-	}
-
 	ret = md_integrity_register(mddev);
 	if (ret) {
 		md_unregister_thread(&mddev->thread);
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 7816c8b2e8087..36a460015cf58 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -888,7 +888,7 @@ static void flush_pending_writes(struct r10conf *conf)
 			if (test_bit(Faulty, &rdev->flags)) {
 				bio_io_error(bio);
 			} else if (unlikely((bio_op(bio) ==  REQ_OP_DISCARD) &&
-					    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+					    !bdev_max_discard_sectors(bio->bi_bdev)))
 				/* Just ignore it */
 				bio_endio(bio);
 			else
@@ -1083,7 +1083,7 @@ static void raid10_unplug(struct blk_plug_cb *cb, bool from_schedule)
 		if (test_bit(Faulty, &rdev->flags)) {
 			bio_io_error(bio);
 		} else if (unlikely((bio_op(bio) ==  REQ_OP_DISCARD) &&
-				    !blk_queue_discard(bio->bi_bdev->bd_disk->queue)))
+				    !bdev_max_discard_sectors(bio->bi_bdev)))
 			/* Just ignore it */
 			bio_endio(bio);
 		else
@@ -2144,8 +2144,6 @@ static int raid10_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 		rcu_assign_pointer(p->rdev, rdev);
 		break;
 	}
-	if (mddev->queue && blk_queue_discard(bdev_get_queue(rdev->bdev)))
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, mddev->queue);
 
 	print_conf(conf);
 	return err;
@@ -4069,7 +4067,6 @@ static int raid10_run(struct mddev *mddev)
 	sector_t size;
 	sector_t min_offset_diff = 0;
 	int first = 1;
-	bool discard_supported = false;
 
 	if (mddev_init_writes_pending(mddev) < 0)
 		return -ENOMEM;
@@ -4140,20 +4137,9 @@ static int raid10_run(struct mddev *mddev)
 					  rdev->data_offset << 9);
 
 		disk->head_position = 0;
-
-		if (blk_queue_discard(bdev_get_queue(rdev->bdev)))
-			discard_supported = true;
 		first = 0;
 	}
 
-	if (mddev->queue) {
-		if (discard_supported)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						  mddev->queue);
-	}
 	/* need to check that every block has at least one working mirror */
 	if (!enough(conf, -1)) {
 		pr_err("md/raid10:%s: not enough operational mirrors.\n",
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index a7d50ff9020a8..c3cbf9a574a39 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1318,7 +1318,7 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
 
 	r5l_write_super(log, end);
 
-	if (!blk_queue_discard(bdev_get_queue(bdev)))
+	if (!bdev_max_discard_sectors(bdev))
 		return;
 
 	mddev = log->rdev->mddev;
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 0bbae0e638666..59f91e392a2ae 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7776,14 +7776,10 @@ static int raid5_run(struct mddev *mddev)
 		 * A better idea might be to turn DISCARD into WRITE_ZEROES
 		 * requests, as that is required to be safe.
 		 */
-		if (devices_handle_discard_safely &&
-		    mddev->queue->limits.max_discard_sectors >= (stripe >> 9) &&
-		    mddev->queue->limits.discard_granularity >= stripe)
-			blk_queue_flag_set(QUEUE_FLAG_DISCARD,
-						mddev->queue);
-		else
-			blk_queue_flag_clear(QUEUE_FLAG_DISCARD,
-						mddev->queue);
+		if (!devices_handle_discard_safely ||
+		    mddev->queue->limits.max_discard_sectors < (stripe >> 9) ||
+		    mddev->queue->limits.discard_granularity < stripe)
+			blk_queue_max_discard_sectors(mddev->queue, 0);
 
 		blk_queue_max_hw_sectors(mddev->queue, UINT_MAX);
 	}
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index c69b2d9df6f16..cac6315010a3d 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -183,7 +183,6 @@ static void mmc_queue_setup_discard(struct request_queue *q,
 	if (!max_discard)
 		return;
 
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 	blk_queue_max_discard_sectors(q, max_discard);
 	q->limits.discard_granularity = card->pref_erase << 9;
 	/* granularity must not be greater than max. discard */
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 64d2b093f114b..f731721114655 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -377,7 +377,6 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, new->rq);
 
 	if (tr->discard) {
-		blk_queue_flag_set(QUEUE_FLAG_DISCARD, new->rq);
 		blk_queue_max_discard_sectors(new->rq, UINT_MAX);
 		new->rq->limits.discard_granularity = tr->blksize;
 	}
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index efb85c6d8e2d5..b01300d9cd372 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1608,7 +1608,7 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
 	u32 size = queue_logical_block_size(queue);
 
 	if (ctrl->max_discard_sectors == 0) {
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, queue);
+		blk_queue_max_discard_sectors(queue, 0);
 		return;
 	}
 
@@ -1619,7 +1619,7 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
 	queue->limits.discard_granularity = size;
 
 	/* If discard is already enabled, don't reset queue limits */
-	if (blk_queue_flag_test_and_set(QUEUE_FLAG_DISCARD, queue))
+	if (queue->limits.max_discard_sectors)
 		return;
 
 	blk_queue_max_discard_sectors(queue, ctrl->max_discard_sectors);
diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c
index e084f4deddddd..8bd5665db9198 100644
--- a/drivers/s390/block/dasd_fba.c
+++ b/drivers/s390/block/dasd_fba.c
@@ -791,7 +791,6 @@ static void dasd_fba_setup_blk_queue(struct dasd_block *block)
 
 	blk_queue_max_discard_sectors(q, max_discard_sectors);
 	blk_queue_max_write_zeroes_sectors(q, max_discard_sectors);
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 }
 
 static int dasd_fba_pe_handler(struct dasd_device *device,
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index dc6e55761fd1f..9694e2cfaf9a6 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -797,7 +797,6 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
 	case SD_LBP_FULL:
 	case SD_LBP_DISABLE:
 		blk_queue_max_discard_sectors(q, 0);
-		blk_queue_flag_clear(QUEUE_FLAG_DISCARD, q);
 		return;
 
 	case SD_LBP_UNMAP:
@@ -830,7 +829,6 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
 	}
 
 	blk_queue_max_discard_sectors(q, max_blocks * (logical_block_size >> 9));
-	blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
 }
 
 static blk_status_t sd_setup_unmap_cmnd(struct scsi_cmnd *cmd)
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index c3e25bac90d59..6cb9f87843278 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -838,7 +838,7 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	struct request_queue *q = bdev_get_queue(bdev);
 	int block_size = bdev_logical_block_size(bdev);
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(bdev))
 		return false;
 
 	attrib->max_unmap_lba_count =
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index f477035a2ac23..efd8deb3ab7e8 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1291,7 +1291,7 @@ static int do_discard_extent(struct btrfs_io_stripe *stripe, u64 *bytes)
 		ret = btrfs_reset_device_zone(dev_replace->tgtdev, phys, len,
 					      &discarded);
 		discarded += src_disc;
-	} else if (blk_queue_discard(bdev_get_queue(stripe->dev->bdev))) {
+	} else if (bdev_max_discard_sectors(stripe->dev->bdev)) {
 		ret = btrfs_issue_discard(dev->bdev, phys, len, &discarded);
 	} else {
 		ret = 0;
@@ -5987,7 +5987,7 @@ static int btrfs_trim_free_extents(struct btrfs_device *device, u64 *trimmed)
 	*trimmed = 0;
 
 	/* Discard not supported = nothing to do. */
-	if (!blk_queue_discard(bdev_get_queue(device->bdev)))
+	if (!bdev_max_discard_sectors(device->bdev))
 		return 0;
 
 	/* Not writable = nothing to do. */
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index f46e71061942d..096bb0da03f1c 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -501,7 +501,7 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 		if (!device->bdev)
 			continue;
 		q = bdev_get_queue(device->bdev);
-		if (blk_queue_discard(q)) {
+		if (bdev_max_discard_sectors(device->bdev)) {
 			num_devices++;
 			minlen = min_t(u64, q->limits.discard_granularity,
 				     minlen);
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 2f51300592366..765e4f63dd18d 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -358,7 +358,7 @@ static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(inode->i_sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&range, (struct fstrim_range __user *)arg, sizeof(range)))
diff --git a/fs/exfat/super.c b/fs/exfat/super.c
index 8ca21e7917d16..be0788ecaf20e 100644
--- a/fs/exfat/super.c
+++ b/fs/exfat/super.c
@@ -627,13 +627,9 @@ static int exfat_fill_super(struct super_block *sb, struct fs_context *fc)
 	if (opts->allow_utime == (unsigned short)-1)
 		opts->allow_utime = ~opts->fs_dmask & 0022;
 
-	if (opts->discard) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-
-		if (!blk_queue_discard(q)) {
-			exfat_warn(sb, "mounting with \"discard\" option, but the device does not support discard");
-			opts->discard = 0;
-		}
+	if (opts->discard && !bdev_max_discard_sectors(sb->s_bdev)) {
+		exfat_warn(sb, "mounting with \"discard\" option, but the device does not support discard");
+		opts->discard = 0;
 	}
 
 	sb->s_flags |= SB_NODIRATIME;
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 992229ca2d830..6e3b9eea126f4 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -1044,7 +1044,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
 	__u32 flags = 0;
 	unsigned int flush_flags = 0;
 	struct super_block *sb = file_inode(filp)->i_sb;
-	struct request_queue *q;
 
 	if (copy_from_user(&flags, (__u32 __user *)arg,
 				sizeof(__u32)))
@@ -1065,10 +1064,8 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
 	if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
 		return -EINVAL;
 
-	q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);
-	if (!q)
-		return -ENXIO;
-	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !blk_queue_discard(q))
+	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
+	    !bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev))
 		return -EOPNOTSUPP;
 
 	if (flags & EXT4_IOC_CHECKPOINT_FLAG_DRY_RUN)
@@ -1393,14 +1390,13 @@ static long __ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 
 	case FITRIM:
 	{
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		int ret = 0;
 
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(sb->s_bdev))
 			return -EOPNOTSUPP;
 
 		/*
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 81749eaddf4c1..93f4e4e9e2631 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5458,13 +5458,9 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
 			goto failed_mount9;
 	}
 
-	if (test_opt(sb, DISCARD)) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-		if (!blk_queue_discard(q))
-			ext4_msg(sb, KERN_WARNING,
-				 "mounting with \"discard\" option, but "
-				 "the device does not support discard");
-	}
+	if (test_opt(sb, DISCARD) && !bdev_max_discard_sectors(sb->s_bdev))
+		ext4_msg(sb, KERN_WARNING,
+			 "mounting with \"discard\" option, but the device does not support discard");
 
 	if (es->s_error_count)
 		mod_timer(&sbi->s_err_report, jiffies + 300*HZ); /* 5 minutes */
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index cd1e65bcf0b04..0ea9a5fa7c1dd 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4381,8 +4381,7 @@ static inline bool f2fs_hw_should_discard(struct f2fs_sb_info *sbi)
 
 static inline bool f2fs_bdev_support_discard(struct block_device *bdev)
 {
-	return blk_queue_discard(bdev_get_queue(bdev)) ||
-	       bdev_is_zoned(bdev);
+	return bdev_max_discard_sectors(bdev) || bdev_is_zoned(bdev);
 }
 
 static inline bool f2fs_hw_support_discard(struct f2fs_sb_info *sbi)
diff --git a/fs/fat/file.c b/fs/fat/file.c
index a5a309fcc7faf..e4c7d10e80129 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -133,7 +133,7 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	user_range = (struct fstrim_range __user *)arg;
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index bf6051bdf1d1d..3d1afb95a925a 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1872,13 +1872,9 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
 		goto out_fail;
 	}
 
-	if (sbi->options.discard) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-		if (!blk_queue_discard(q))
-			fat_msg(sb, KERN_WARNING,
-					"mounting with \"discard\" option, but "
-					"the device does not support discard");
-	}
+	if (sbi->options.discard && !bdev_max_discard_sectors(sb->s_bdev))
+		fat_msg(sb, KERN_WARNING,
+			"mounting with \"discard\" option, but the device does not support discard");
 
 	fat_set_state(sb, 1, 0);
 	return 0;
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 801ad9f4f2bef..7f20ac9133bc6 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1405,7 +1405,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
 		return -EROFS;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sdp->sd_vfs->s_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&r, argp, sizeof(r)))
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index fcacafa4510d1..19d226cd4ff4d 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1762,7 +1762,6 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 	unsigned long block, log_offset; /* logical */
 	unsigned long long phys_block, block_start, block_stop; /* physical */
 	loff_t byte_start, byte_stop, byte_count;
-	struct request_queue *q = bdev_get_queue(journal->j_dev);
 
 	/* flags must be set to either discard or zeroout */
 	if ((flags & ~JBD2_JOURNAL_FLUSH_VALID) || !flags ||
@@ -1770,10 +1769,8 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 			(flags & JBD2_JOURNAL_FLUSH_ZEROOUT)))
 		return -EINVAL;
 
-	if (!q)
-		return -ENXIO;
-
-	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !blk_queue_discard(q))
+	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
+	    !bdev_max_discard_sectors(journal->j_dev))
 		return -EOPNOTSUPP;
 
 	/*
diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
index 03a845ab4f009..357ae6e5c36ec 100644
--- a/fs/jfs/ioctl.c
+++ b/fs/jfs/ioctl.c
@@ -117,7 +117,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q)) {
+		if (!bdev_max_discard_sectors(sb->s_bdev)) {
 			jfs_warn("FITRIM not supported on device");
 			return -EOPNOTSUPP;
 		}
diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index f1a13a74cddf3..85d4f44f2ac4d 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -372,19 +372,16 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
 		}
 
 		case Opt_discard:
-		{
-			struct request_queue *q = bdev_get_queue(sb->s_bdev);
 			/* if set to 1, even copying files will cause
 			 * trimming :O
 			 * -> user has more control over the online trimming
 			 */
 			sbi->minblks_trim = 64;
-			if (blk_queue_discard(q))
+			if (bdev_max_discard_sectors(sb->s_bdev))
 				*flag |= JFS_DISCARD;
 			else
 				pr_err("JFS: discard option not supported on device\n");
 			break;
-		}
 
 		case Opt_nodiscard:
 			*flag &= ~JFS_DISCARD;
@@ -392,10 +389,9 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
 
 		case Opt_discard_minblk:
 		{
-			struct request_queue *q = bdev_get_queue(sb->s_bdev);
 			char *minblks_trim = args[0].from;
 			int rc;
-			if (blk_queue_discard(q)) {
+			if (bdev_max_discard_sectors(sb->s_bdev)) {
 				*flag |= JFS_DISCARD;
 				rc = kstrtouint(minblks_trim, 0,
 						&sbi->minblks_trim);
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
index fec194a666f4b..52b73f558fcb1 100644
--- a/fs/nilfs2/ioctl.c
+++ b/fs/nilfs2/ioctl.c
@@ -1059,7 +1059,7 @@ static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(nilfs->ns_bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&range, argp, sizeof(range)))
diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index 787b53b984ee1..e763236169331 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -28,7 +28,7 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(sbi->sb->s_bdev))
 		return -EOPNOTSUPP;
 
 	user_range = (struct fstrim_range __user *)arg;
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index cd30e81abbce0..c734085bcce4a 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -913,7 +913,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	}
 
 	rq = bdev_get_queue(bdev);
-	if (blk_queue_discard(rq) && rq->limits.discard_granularity) {
+	if (bdev_max_discard_sectors(bdev) && rq->limits.discard_granularity) {
 		sbi->discard_granularity = rq->limits.discard_granularity;
 		sbi->discard_granularity_mask_inv =
 			~(u64)(sbi->discard_granularity - 1);
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index f59461d85da45..9b78ef103ada6 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -910,7 +910,7 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
 
-		if (!blk_queue_discard(q))
+		if (!bdev_max_discard_sectors(sb->s_bdev))
 			return -EOPNOTSUPP;
 
 		if (copy_from_user(&range, argp, sizeof(range)))
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index 0191de8ce9ced..a4e6609d616b7 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -162,7 +162,7 @@ xfs_ioc_trim(
 
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
-	if (!blk_queue_discard(q))
+	if (!bdev_max_discard_sectors(mp->m_ddev_targp->bt_bdev))
 		return -EOPNOTSUPP;
 
 	/*
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 54be9d64093ed..a276b8111f636 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1608,14 +1608,10 @@ xfs_fs_fill_super(
 			goto out_filestream_unmount;
 	}
 
-	if (xfs_has_discard(mp)) {
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
-
-		if (!blk_queue_discard(q)) {
-			xfs_warn(mp, "mounting with \"discard\" option, but "
-					"the device does not support discard");
-			mp->m_features &= ~XFS_FEAT_DISCARD;
-		}
+	if (xfs_has_discard(mp) && !bdev_max_discard_sectors(sb->s_bdev)) {
+		xfs_warn(mp,
+	"mounting with \"discard\" option, but the device does not support discard");
+		mp->m_features &= ~XFS_FEAT_DISCARD;
 	}
 
 	if (xfs_has_reflink(mp)) {
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index ce16247d3afab..767ab22e1052a 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -540,7 +540,6 @@ struct request_queue {
 #define QUEUE_FLAG_NONROT	6	/* non-rotational device (SSD) */
 #define QUEUE_FLAG_VIRT		QUEUE_FLAG_NONROT /* paravirt device */
 #define QUEUE_FLAG_IO_STAT	7	/* do disk/partitions IO accounting */
-#define QUEUE_FLAG_DISCARD	8	/* supports DISCARD */
 #define QUEUE_FLAG_NOXMERGES	9	/* No extended merges */
 #define QUEUE_FLAG_ADD_RANDOM	10	/* Contributes to random pool */
 #define QUEUE_FLAG_SECERASE	11	/* supports secure erase */
@@ -582,7 +581,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 	test_bit(QUEUE_FLAG_STABLE_WRITES, &(q)->queue_flags)
 #define blk_queue_io_stat(q)	test_bit(QUEUE_FLAG_IO_STAT, &(q)->queue_flags)
 #define blk_queue_add_random(q)	test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
-#define blk_queue_discard(q)	test_bit(QUEUE_FLAG_DISCARD, &(q)->queue_flags)
 #define blk_queue_zone_resetall(q)	\
 	test_bit(QUEUE_FLAG_ZONE_RESETALL, &(q)->queue_flags)
 #define blk_queue_secure_erase(q) \
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 4069f17a82c8e..5d9cedf9e7b84 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2957,20 +2957,6 @@ static int setup_swap_map_and_extents(struct swap_info_struct *p,
 	return nr_extents;
 }
 
-/*
- * Helper to sys_swapon determining if a given swap
- * backing device queue supports DISCARD operations.
- */
-static bool swap_discardable(struct swap_info_struct *si)
-{
-	struct request_queue *q = bdev_get_queue(si->bdev);
-
-	if (!blk_queue_discard(q))
-		return false;
-
-	return true;
-}
-
 SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 {
 	struct swap_info_struct *p;
@@ -3132,7 +3118,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 					 sizeof(long),
 					 GFP_KERNEL);
 
-	if (p->bdev && (swap_flags & SWAP_FLAG_DISCARD) && swap_discardable(p)) {
+	if ((swap_flags & SWAP_FLAG_DISCARD) &&
+	    p->bdev && bdev_max_discard_sectors(p->bdev)) {
 		/*
 		 * When discard is enabled for swap with no particular
 		 * policy flagged, we set all swap discard flags here in
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305284.520287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6B-0006JY-73; Fri, 15 Apr 2022 05:02:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305284.520287; Fri, 15 Apr 2022 05:02:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6A-0006Ha-UC; Fri, 15 Apr 2022 05:02:22 +0000
Received: by outflank-mailman (input) for mailman id 305284;
 Fri, 15 Apr 2022 05:02:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxy-0004b8-JE
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:54 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0ba18722-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:53:53 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxj-008P34-1w; Fri, 15 Apr 2022 04:53:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ba18722-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=OGJvHxXgCvw9/l2/0Y6T0ivupEa5/VICLVgDi4pj6zk=; b=V1O5NFc1OlhQKBAtPUESXrscbH
	+gcfK8CWzUYJRweVfHt/gmcJRbnnyENCL0uxhp1nElH2rQXnBLZskSDze6nM9j3gF5JGx31h7pu9N
	vPub4AczDFXqMD/nyRBLgGmvIyYUqZBGTv5Cc6JJINS7BJNf0/btoIeeLCOjZ4a5fxHer4O2Wp+wl
	3U3FDeLPVBAqUisUOlzqQt8zs+kHINf2usFr1NigldxLvR21wl2YG3uLr/6AwNNFGfA7YCs2iW8C/
	bPJ75RbYfKAHSDs+/fiusGnx0gVrEkfUrP1ZPu0GLZCLsq5AzPGOB49mYYVnrdML7RbrD/GaYtdc7
	GVJ2xQ0g==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile
Date: Fri, 15 Apr 2022 06:52:41 +0200
Message-Id: <20220415045258.199825-11-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based helper instead of poking into the queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 mm/swapfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/swapfile.c b/mm/swapfile.c
index 63c61f8b26118..4c7537162af5e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2761,7 +2761,7 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
 		 * write only restriction.  Hence zoned block devices are not
 		 * suitable for swapping.  Disallow them here.
 		 */
-		if (blk_queue_is_zoned(p->bdev->bd_disk->queue))
+		if (bdev_is_zoned(p->bdev))
 			return -EINVAL;
 		p->flags |= SWP_BLKDEV;
 	} else if (S_ISREG(inode->i_mode)) {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305286.520293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6B-0006N2-SS; Fri, 15 Apr 2022 05:02:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305286.520293; Fri, 15 Apr 2022 05:02:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6B-0006Lf-AO; Fri, 15 Apr 2022 05:02:23 +0000
Received: by outflank-mailman (input) for mailman id 305286;
 Fri, 15 Apr 2022 05:02:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyS-0004TJ-QR
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:24 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1deab6a8-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:54:24 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDy9-008PY0-20; Fri, 15 Apr 2022 04:54:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1deab6a8-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=A3F4pzgWH2QQ0wtpIeTWEbWkE7zvp2Hf2SzUvBBV6uI=; b=2blFxPm6xz5pgZn6E5jvsGqhvn
	2WDz/E43ISZl4v/rhlHMaqtSb4lVbmKeEW11/ljs0aiEkq0TnWEDxeJnrojcMAcOqNB8N3gDxJnoZ
	0NRetUsPJHvzddTt7lmgpHndIYp7bFipN2chfdRidmHIR3lH3yyIVmQny7lS+2WzaIVhTRY61ZPLW
	cNdIp932vWgZbDLAr3bVHO1tMLGx1FOnjxoa9UVQZYEIwSKlwU7ByTf62px4tvbNkH8lyOAfKg6eV
	fvQs7AcyDRrAWF5ZnpqPRd0RsttREedP1tYS6zdjKYykJ8LivF4bs1Leq71tf07T70LHtI3i4RcFf
	TuAsL+Kw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 20/27] block: use bdev_discard_alignment in part_discard_alignment_show
Date: Fri, 15 Apr 2022 06:52:51 +0200
Message-Id: <20220415045258.199825-21-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the bdev based alignment helper instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/partitions/core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 240b3fff521e4..70dec1c78521d 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -206,11 +206,7 @@ static ssize_t part_alignment_offset_show(struct device *dev,
 static ssize_t part_discard_alignment_show(struct device *dev,
 					   struct device_attribute *attr, char *buf)
 {
-	struct block_device *bdev = dev_to_bdev(dev);
-
-	return sprintf(buf, "%u\n",
-		queue_limit_discard_alignment(&bdev_get_queue(bdev)->limits,
-				bdev->bd_start_sect));
+	return sprintf(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev)));
 }
 
 static DEVICE_ATTR(partition, 0444, part_partition_show, NULL);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305287.520301 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6C-0006X2-GO; Fri, 15 Apr 2022 05:02:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305287.520301; Fri, 15 Apr 2022 05:02:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6B-0006V0-Re; Fri, 15 Apr 2022 05:02:23 +0000
Received: by outflank-mailman (input) for mailman id 305287;
 Fri, 15 Apr 2022 05:02:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyE-0004b8-1Q
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:10 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 12a07798-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:54:05 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxv-008PIQ-ME; Fri, 15 Apr 2022 04:53:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12a07798-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=EfN09E7KgfFk5NOTogRSBSf7jTlM22RGe5+0+tCjcRA=; b=HT20lFvm4eaWJQtGcnmbhRoft9
	/gWueL2ezX0rtmvfD1y6vW4lHfpzH1cPIp08f4BIGZSC49RVBBYbHgbS+KAX1oiXK6QDo4EDns/41
	oLVOfq3MekqhckOiTRP9I3u5vQgfRVLF/o2daYUi8nTXdLHpKUoyn49HYrmB7+ZqRfsquW9YDBu4p
	D4uxvWlZnhsloYsO2zNcp/KkBQnezNnSaCF8uUycTEb/HLNgy42tQ7EfyQZm1uZruK006gQ9xmJK1
	PsGSSD0WP/jCSlttlJweZM8gxob8/S6HjFCPWqpNQJhWwkjWmgqx1AWPPsqaJu3qLEkP5zbjSOfgd
	w6iJtnUA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 15/27] block: add a bdev_max_zone_append_sectors helper
Date: Fri, 15 Apr 2022 06:52:46 +0200
Message-Id: <20220415045258.199825-16-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the max supported sectors for zone append based on
the block_device instead of having to poke into the block layer internal
request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 drivers/nvme/target/zns.c | 3 +--
 fs/zonefs/super.c         | 3 +--
 include/linux/blkdev.h    | 6 ++++++
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
index e34718b095504..82b61acf7a72b 100644
--- a/drivers/nvme/target/zns.c
+++ b/drivers/nvme/target/zns.c
@@ -34,8 +34,7 @@ static int validate_conv_zones_cb(struct blk_zone *z,
 
 bool nvmet_bdev_zns_enable(struct nvmet_ns *ns)
 {
-	struct request_queue *q = ns->bdev->bd_disk->queue;
-	u8 zasl = nvmet_zasl(queue_max_zone_append_sectors(q));
+	u8 zasl = nvmet_zasl(bdev_max_zone_append_sectors(ns->bdev));
 	struct gendisk *bd_disk = ns->bdev->bd_disk;
 	int ret;
 
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index 3614c7834007d..7a63807b736c4 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -678,13 +678,12 @@ static ssize_t zonefs_file_dio_append(struct kiocb *iocb, struct iov_iter *from)
 	struct inode *inode = file_inode(iocb->ki_filp);
 	struct zonefs_inode_info *zi = ZONEFS_I(inode);
 	struct block_device *bdev = inode->i_sb->s_bdev;
-	unsigned int max;
+	unsigned int max = bdev_max_zone_append_sectors(bdev);
 	struct bio *bio;
 	ssize_t size;
 	int nr_pages;
 	ssize_t ret;
 
-	max = queue_max_zone_append_sectors(bdev_get_queue(bdev));
 	max = ALIGN_DOWN(max << SECTOR_SHIFT, inode->i_sb->s_blocksize);
 	iov_iter_truncate(from, max);
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index a433798c3343e..f8c50b77543eb 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1188,6 +1188,12 @@ static inline unsigned int queue_max_zone_append_sectors(const struct request_qu
 	return min(l->max_zone_append_sectors, l->max_sectors);
 }
 
+static inline unsigned int
+bdev_max_zone_append_sectors(struct block_device *bdev)
+{
+	return queue_max_zone_append_sectors(bdev_get_queue(bdev));
+}
+
 static inline unsigned queue_logical_block_size(const struct request_queue *q)
 {
 	int retval = 512;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305301.520325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6K-0007w3-Ob; Fri, 15 Apr 2022 05:02:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305301.520325; Fri, 15 Apr 2022 05:02:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6K-0007vk-JU; Fri, 15 Apr 2022 05:02:32 +0000
Received: by outflank-mailman (input) for mailman id 305301;
 Fri, 15 Apr 2022 05:02:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyf-0004b8-KY
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:37 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 23ed66ed-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:54:33 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDyL-008Pnr-T3; Fri, 15 Apr 2022 04:54:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23ed66ed-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=kNp/brlkIe235G5uL2MrVnIRtgqb7cDd/DmZFPBWIBU=; b=Co/TUtYjxXhBannRnRPPMzniSz
	KzMOTkfBm1/hatrRCsXat8xvCYh5GhThX4mzrGtKHb6LAYG+sPH3KwWtVY3xSHJr/UXxKAr/c8lOd
	9nzEDK8J1+urJnRHTt8OvyyB9riUUShlfJxQQc5tl17Aeq2Ob83x7bFSyDRg1kFsMfBGYCbDiai4T
	MmRIecJu05pH8quQ4Da7LC0ahNKk3viQlUZsK3kTx8GJB07Ab+tCpvf4TxuQJg0Ur8EB4xfyeBW86
	w/cFJ63yhIzxe5o3O4E4JugMkp6nxsaFU/g8r/FsjvJTzkEcJyR5P45yJBFH2vwfQ5gqACkXysc+F
	Z7/+X18g==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 25/27] block: add a bdev_discard_granularity helper
Date: Fri, 15 Apr 2022 06:52:56 +0200
Message-Id: <20220415045258.199825-26-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Abstract away implementation details from file systems by providing a
block_device based helper to retrieve the discard granularity.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 block/blk-lib.c                     |  5 ++---
 drivers/block/drbd/drbd_nl.c        |  9 +++++----
 drivers/block/drbd/drbd_receiver.c  |  3 +--
 drivers/block/loop.c                |  2 +-
 drivers/target/target_core_device.c |  3 +--
 fs/btrfs/ioctl.c                    | 12 ++++--------
 fs/exfat/file.c                     |  3 +--
 fs/ext4/mballoc.c                   |  6 +++---
 fs/f2fs/file.c                      |  3 +--
 fs/fat/file.c                       |  3 +--
 fs/gfs2/rgrp.c                      |  7 +++----
 fs/jfs/ioctl.c                      |  3 +--
 fs/nilfs2/ioctl.c                   |  4 ++--
 fs/ntfs3/file.c                     |  4 ++--
 fs/ntfs3/super.c                    |  6 ++----
 fs/ocfs2/ioctl.c                    |  3 +--
 fs/xfs/xfs_discard.c                |  4 ++--
 include/linux/blkdev.h              |  5 +++++
 18 files changed, 38 insertions(+), 47 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 8b4b66d3a9bfc..43aa4d7fe859f 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -12,8 +12,7 @@
 
 static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
 {
-	unsigned int discard_granularity =
-		bdev_get_queue(bdev)->limits.discard_granularity;
+	unsigned int discard_granularity = bdev_discard_granularity(bdev);
 	sector_t granularity_aligned_sector;
 
 	if (bdev_is_partition(bdev))
@@ -59,7 +58,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	}
 
 	/* In case the discard granularity isn't set by buggy device driver */
-	if (WARN_ON_ONCE(!q->limits.discard_granularity)) {
+	if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
 		char dev_name[BDEVNAME_SIZE];
 
 		bdevname(bdev, dev_name);
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 0678ceb505799..a6280dcb37679 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1425,7 +1425,6 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 			       struct drbd_backing_dev *nbc)
 {
 	struct block_device *bdev = nbc->backing_bdev;
-	struct request_queue *q = bdev->bd_disk->queue;
 
 	if (disk_conf->al_extents < DRBD_AL_EXTENTS_MIN)
 		disk_conf->al_extents = DRBD_AL_EXTENTS_MIN;
@@ -1442,12 +1441,14 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 	if (disk_conf->rs_discard_granularity) {
 		int orig_value = disk_conf->rs_discard_granularity;
 		sector_t discard_size = bdev_max_discard_sectors(bdev) << 9;
+		unsigned int discard_granularity = bdev_discard_granularity(bdev);
 		int remainder;
 
-		if (q->limits.discard_granularity > disk_conf->rs_discard_granularity)
-			disk_conf->rs_discard_granularity = q->limits.discard_granularity;
+		if (discard_granularity > disk_conf->rs_discard_granularity)
+			disk_conf->rs_discard_granularity = discard_granularity;
 
-		remainder = disk_conf->rs_discard_granularity % q->limits.discard_granularity;
+		remainder = disk_conf->rs_discard_granularity %
+				discard_granularity;
 		disk_conf->rs_discard_granularity += remainder;
 
 		if (disk_conf->rs_discard_granularity > discard_size)
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 8a4a47da56fe9..275c53c7b629e 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1511,7 +1511,6 @@ void drbd_bump_write_ordering(struct drbd_resource *resource, struct drbd_backin
 int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, unsigned int nr_sectors, int flags)
 {
 	struct block_device *bdev = device->ldev->backing_bdev;
-	struct request_queue *q = bdev_get_queue(bdev);
 	sector_t tmp, nr;
 	unsigned int max_discard_sectors, granularity;
 	int alignment;
@@ -1521,7 +1520,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		goto zero_out;
 
 	/* Zero-sector (unknown) and one-sector granularities are the same.  */
-	granularity = max(q->limits.discard_granularity >> 9, 1U);
+	granularity = max(bdev_discard_granularity(bdev) >> 9, 1U);
 	alignment = (bdev_discard_alignment(bdev) >> 9) % granularity;
 
 	max_discard_sectors = min(bdev_max_discard_sectors(bdev), (1U << 22));
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 0e061c9896eff..976cf987b3920 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -759,7 +759,7 @@ static void loop_config_discard(struct loop_device *lo)
 		struct request_queue *backingq = bdev_get_queue(I_BDEV(inode));
 
 		max_discard_sectors = backingq->limits.max_write_zeroes_sectors;
-		granularity = backingq->limits.discard_granularity ?:
+		granularity = bdev_discard_granularity(I_BDEV(inode)) ?:
 			queue_physical_block_size(backingq);
 
 	/*
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 6cb9f87843278..25f33eb25337c 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -835,7 +835,6 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 				       struct block_device *bdev)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	int block_size = bdev_logical_block_size(bdev);
 
 	if (!bdev_max_discard_sectors(bdev))
@@ -847,7 +846,7 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 	 * Currently hardcoded to 1 in Linux/SCSI code..
 	 */
 	attrib->max_unmap_block_desc_count = 1;
-	attrib->unmap_granularity = q->limits.discard_granularity / block_size;
+	attrib->unmap_granularity = bdev_discard_granularity(bdev) / block_size;
 	attrib->unmap_granularity_alignment =
 		bdev_discard_alignment(bdev) / block_size;
 	return true;
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 096bb0da03f1c..70765d59616a5 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -468,7 +468,6 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 					void __user *arg)
 {
 	struct btrfs_device *device;
-	struct request_queue *q;
 	struct fstrim_range range;
 	u64 minlen = ULLONG_MAX;
 	u64 num_devices = 0;
@@ -498,14 +497,11 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
 	rcu_read_lock();
 	list_for_each_entry_rcu(device, &fs_info->fs_devices->devices,
 				dev_list) {
-		if (!device->bdev)
+		if (!device->bdev || !bdev_max_discard_sectors(device->bdev))
 			continue;
-		q = bdev_get_queue(device->bdev);
-		if (bdev_max_discard_sectors(device->bdev)) {
-			num_devices++;
-			minlen = min_t(u64, q->limits.discard_granularity,
-				     minlen);
-		}
+		num_devices++;
+		minlen = min_t(u64, bdev_discard_granularity(device->bdev),
+				    minlen);
 	}
 	rcu_read_unlock();
 
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 765e4f63dd18d..20d4e47f57ab2 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -351,7 +351,6 @@ int exfat_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
 
 static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 {
-	struct request_queue *q = bdev_get_queue(inode->i_sb->s_bdev);
 	struct fstrim_range range;
 	int ret = 0;
 
@@ -365,7 +364,7 @@ static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 		return -EFAULT;
 
 	range.minlen = max_t(unsigned int, range.minlen,
-				q->limits.discard_granularity);
+				bdev_discard_granularity(inode->i_sb->s_bdev));
 
 	ret = exfat_trim_fs(inode, &range);
 	if (ret < 0)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index c3668c977cd99..6d1820536d88d 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -6455,7 +6455,7 @@ ext4_trim_all_free(struct super_block *sb, ext4_group_t group,
  */
 int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
 {
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
+	unsigned int discard_granularity = bdev_discard_granularity(sb->s_bdev);
 	struct ext4_group_info *grp;
 	ext4_group_t group, first_group, last_group;
 	ext4_grpblk_t cnt = 0, first_cluster, last_cluster;
@@ -6475,9 +6475,9 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
 	    range->len < sb->s_blocksize)
 		return -EINVAL;
 	/* No point to try to trim less than discard granularity */
-	if (range->minlen < q->limits.discard_granularity) {
+	if (range->minlen < discard_granularity) {
 		minlen = EXT4_NUM_B2C(EXT4_SB(sb),
-			q->limits.discard_granularity >> sb->s_blocksize_bits);
+				discard_granularity >> sb->s_blocksize_bits);
 		if (minlen > EXT4_CLUSTERS_PER_GROUP(sb))
 			goto out;
 	}
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 5b89af0f27f05..8053d99f3920b 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2285,7 +2285,6 @@ static int f2fs_ioc_fitrim(struct file *filp, unsigned long arg)
 {
 	struct inode *inode = file_inode(filp);
 	struct super_block *sb = inode->i_sb;
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
 	struct fstrim_range range;
 	int ret;
 
@@ -2304,7 +2303,7 @@ static int f2fs_ioc_fitrim(struct file *filp, unsigned long arg)
 		return ret;
 
 	range.minlen = max((unsigned int)range.minlen,
-				q->limits.discard_granularity);
+			   bdev_discard_granularity(sb->s_bdev));
 	ret = f2fs_trim_fs(F2FS_SB(sb), &range);
 	mnt_drop_write_file(filp);
 	if (ret < 0)
diff --git a/fs/fat/file.c b/fs/fat/file.c
index e4c7d10e80129..bf91f977debea 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -127,7 +127,6 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 	struct super_block *sb = inode->i_sb;
 	struct fstrim_range __user *user_range;
 	struct fstrim_range range;
-	struct request_queue *q = bdev_get_queue(sb->s_bdev);
 	int err;
 
 	if (!capable(CAP_SYS_ADMIN))
@@ -141,7 +140,7 @@ static int fat_ioctl_fitrim(struct inode *inode, unsigned long arg)
 		return -EFAULT;
 
 	range.minlen = max_t(unsigned int, range.minlen,
-			     q->limits.discard_granularity);
+			     bdev_discard_granularity(sb->s_bdev));
 
 	err = fat_trim_fs(inode, &range);
 	if (err < 0)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 7f20ac9133bc6..6d26bb5254844 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1386,7 +1386,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 {
 	struct inode *inode = file_inode(filp);
 	struct gfs2_sbd *sdp = GFS2_SB(inode);
-	struct request_queue *q = bdev_get_queue(sdp->sd_vfs->s_bdev);
+	struct block_device *bdev = sdp->sd_vfs->s_bdev;
 	struct buffer_head *bh;
 	struct gfs2_rgrpd *rgd;
 	struct gfs2_rgrpd *rgd_end;
@@ -1405,7 +1405,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
 		return -EROFS;
 
-	if (!bdev_max_discard_sectors(sdp->sd_vfs->s_bdev))
+	if (!bdev_max_discard_sectors(bdev))
 		return -EOPNOTSUPP;
 
 	if (copy_from_user(&r, argp, sizeof(r)))
@@ -1418,8 +1418,7 @@ int gfs2_fitrim(struct file *filp, void __user *argp)
 	start = r.start >> bs_shift;
 	end = start + (r.len >> bs_shift);
 	minlen = max_t(u64, r.minlen, sdp->sd_sb.sb_bsize);
-	minlen = max_t(u64, minlen,
-		       q->limits.discard_granularity) >> bs_shift;
+	minlen = max_t(u64, minlen, bdev_discard_granularity(bdev)) >> bs_shift;
 
 	if (end <= start || minlen > sdp->sd_max_rg_data)
 		return -EINVAL;
diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
index 357ae6e5c36ec..1e7b177ece605 100644
--- a/fs/jfs/ioctl.c
+++ b/fs/jfs/ioctl.c
@@ -110,7 +110,6 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	case FITRIM:
 	{
 		struct super_block *sb = inode->i_sb;
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		s64 ret = 0;
 
@@ -127,7 +126,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 			return -EFAULT;
 
 		range.minlen = max_t(unsigned int, range.minlen,
-			q->limits.discard_granularity);
+				     bdev_discard_granularity(sb->s_bdev));
 
 		ret = jfs_ioc_trim(inode, &range);
 		if (ret < 0)
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
index 52b73f558fcb1..87e1004b606d2 100644
--- a/fs/nilfs2/ioctl.c
+++ b/fs/nilfs2/ioctl.c
@@ -1052,7 +1052,6 @@ static int nilfs_ioctl_resize(struct inode *inode, struct file *filp,
 static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 {
 	struct the_nilfs *nilfs = inode->i_sb->s_fs_info;
-	struct request_queue *q = bdev_get_queue(nilfs->ns_bdev);
 	struct fstrim_range range;
 	int ret;
 
@@ -1065,7 +1064,8 @@ static int nilfs_ioctl_trim_fs(struct inode *inode, void __user *argp)
 	if (copy_from_user(&range, argp, sizeof(range)))
 		return -EFAULT;
 
-	range.minlen = max_t(u64, range.minlen, q->limits.discard_granularity);
+	range.minlen = max_t(u64, range.minlen,
+			     bdev_discard_granularity(nilfs->ns_bdev));
 
 	down_read(&nilfs->ns_segctor_sem);
 	ret = nilfs_sufile_trim_fs(nilfs->ns_sufile, &range);
diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index e763236169331..15806eeae217a 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -22,7 +22,6 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 {
 	struct fstrim_range __user *user_range;
 	struct fstrim_range range;
-	struct request_queue *q = bdev_get_queue(sbi->sb->s_bdev);
 	int err;
 
 	if (!capable(CAP_SYS_ADMIN))
@@ -35,7 +34,8 @@ static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg)
 	if (copy_from_user(&range, user_range, sizeof(range)))
 		return -EFAULT;
 
-	range.minlen = max_t(u32, range.minlen, q->limits.discard_granularity);
+	range.minlen = max_t(u32, range.minlen,
+			     bdev_discard_granularity(sbi->sb->s_bdev));
 
 	err = ntfs_trim_fs(sbi, &range);
 	if (err < 0)
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index c734085bcce4a..5f2e414cfa79b 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -882,7 +882,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	int err;
 	struct ntfs_sb_info *sbi = sb->s_fs_info;
 	struct block_device *bdev = sb->s_bdev;
-	struct request_queue *rq;
 	struct inode *inode;
 	struct ntfs_inode *ni;
 	size_t i, tt;
@@ -912,9 +911,8 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 		goto out;
 	}
 
-	rq = bdev_get_queue(bdev);
-	if (bdev_max_discard_sectors(bdev) && rq->limits.discard_granularity) {
-		sbi->discard_granularity = rq->limits.discard_granularity;
+	if (bdev_max_discard_sectors(bdev) && bdev_discard_granularity(bdev)) {
+		sbi->discard_granularity = bdev_discard_granularity(bdev);
 		sbi->discard_granularity_mask_inv =
 			~(u64)(sbi->discard_granularity - 1);
 	}
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index 9b78ef103ada6..afd54ec661030 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -903,7 +903,6 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	case FITRIM:
 	{
 		struct super_block *sb = inode->i_sb;
-		struct request_queue *q = bdev_get_queue(sb->s_bdev);
 		struct fstrim_range range;
 		int ret = 0;
 
@@ -916,7 +915,7 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (copy_from_user(&range, argp, sizeof(range)))
 			return -EFAULT;
 
-		range.minlen = max_t(u64, q->limits.discard_granularity,
+		range.minlen = max_t(u64, bdev_discard_granularity(sb->s_bdev),
 				     range.minlen);
 		ret = ocfs2_trim_fs(sb, &range);
 		if (ret < 0)
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index a4e6609d616b7..e2ada115c23f9 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -152,8 +152,8 @@ xfs_ioc_trim(
 	struct xfs_mount		*mp,
 	struct fstrim_range __user	*urange)
 {
-	struct request_queue	*q = bdev_get_queue(mp->m_ddev_targp->bt_bdev);
-	unsigned int		granularity = q->limits.discard_granularity;
+	unsigned int		granularity =
+		bdev_discard_granularity(mp->m_ddev_targp->bt_bdev);
 	struct fstrim_range	range;
 	xfs_daddr_t		start, end, minlen;
 	xfs_agnumber_t		start_agno, end_agno, agno;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 767ab22e1052a..f1cf557ea20ef 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1257,6 +1257,11 @@ static inline unsigned int bdev_max_discard_sectors(struct block_device *bdev)
 	return bdev_get_queue(bdev)->limits.max_discard_sectors;
 }
 
+static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.discard_granularity;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305303.520331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6L-00084F-Di; Fri, 15 Apr 2022 05:02:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305303.520331; Fri, 15 Apr 2022 05:02:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6L-00081N-5L; Fri, 15 Apr 2022 05:02:33 +0000
Received: by outflank-mailman (input) for mailman id 305303;
 Fri, 15 Apr 2022 05:02:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDy3-0004TJ-Ki
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:59 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0e447d58-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:53:57 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxn-008P9R-W4; Fri, 15 Apr 2022 04:53:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e447d58-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=fsm4eQJmjNs7mthWl6aQ0QoznH4mW7xZq3krP8KP9Uc=; b=Kc0kFPKNrBsztP51rQrb436EpC
	clkRG1c+RWauytSxyP1VZHzZm0k/n/bJiQF9offdgxlhFL9TpCe41mL4yiFXHZXG7NN3dZBqQWTyh
	VS32YFvooKg6jmcfwAv8iLy6ibtMV7kgdq4kptYmhPm0Z6NWmVX2oFVQWm6WbZ6ctUwWMEvyxnK3Y
	b9ovdNw4IiS4Q9grCcaQcJlT12XLY6ANDPyUjFzxFxy5R6sXbufEUiOBD2A9POWjPp9fJgc5BHmlx
	btpCR9+B/FjoYWNox5ht1MfT6qlsZJ4E91t9jc1UTJI5F9kZQSgKF9QlK5aIdPlC3AU3hlr6Kf/BQ
	9t86XlyA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 12/27] block: add a bdev_write_cache helper
Date: Fri, 15 Apr 2022 06:52:43 +0200
Message-Id: <20220415045258.199825-13-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the write cache flag based on the block_device
instead of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 drivers/block/rnbd/rnbd-srv.c       | 2 +-
 drivers/block/xen-blkback/xenbus.c  | 2 +-
 drivers/target/target_core_iblock.c | 8 ++------
 fs/btrfs/disk-io.c                  | 3 +--
 include/linux/blkdev.h              | 5 +++++
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index f04df6294650b..f8cc3c5fecb4b 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -558,7 +558,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 	rsp->secure_discard =
 		cpu_to_le16(rnbd_dev_get_secure_discard(rnbd_dev));
 	rsp->cache_policy = 0;
-	if (test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (bdev_write_cache(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_WRITEBACK;
 	if (blk_queue_fua(q))
 		rsp->cache_policy |= RNBD_FUA;
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index f09040435e2e5..8b691fe50475f 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -517,7 +517,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 		vbd->type |= VDISK_REMOVABLE;
 
 	q = bdev_get_queue(bdev);
-	if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (bdev_write_cache(bdev))
 		vbd->flush_support = true;
 
 	if (q && blk_queue_secure_erase(q))
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index b41ee5c3b5b82..03013e85ffc03 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -737,7 +737,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
 		if (test_bit(QUEUE_FLAG_FUA, &q->queue_flags)) {
 			if (cmd->se_cmd_flags & SCF_FUA)
 				opf |= REQ_FUA;
-			else if (!test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+			else if (!bdev_write_cache(ib_dev->ibd_bd))
 				opf |= REQ_FUA;
 		}
 	} else {
@@ -886,11 +886,7 @@ iblock_parse_cdb(struct se_cmd *cmd)
 
 static bool iblock_get_write_cache(struct se_device *dev)
 {
-	struct iblock_dev *ib_dev = IBLOCK_DEV(dev);
-	struct block_device *bd = ib_dev->ibd_bd;
-	struct request_queue *q = bdev_get_queue(bd);
-
-	return test_bit(QUEUE_FLAG_WC, &q->queue_flags);
+	return bdev_write_cache(IBLOCK_DEV(dev)->ibd_bd);
 }
 
 static const struct target_backend_ops iblock_ops = {
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index b30309f187cf0..092e986b8e8ed 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -4247,8 +4247,7 @@ static void write_dev_flush(struct btrfs_device *device)
 	 * of simplicity, since this is a debug tool and not meant for use in
 	 * non-debug builds.
 	 */
-	struct request_queue *q = bdev_get_queue(device->bdev);
-	if (!test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+	if (!bdev_write_cache(device->bdev))
 		return;
 #endif
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 3a9578e14a6b0..807a49aa5a27a 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1331,6 +1331,11 @@ static inline bool bdev_nonrot(struct block_device *bdev)
 	return blk_queue_nonrot(bdev_get_queue(bdev));
 }
 
+static inline bool bdev_write_cache(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305304.520335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6L-0008Dk-VY; Fri, 15 Apr 2022 05:02:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305304.520335; Fri, 15 Apr 2022 05:02:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6L-0008Au-MT; Fri, 15 Apr 2022 05:02:33 +0000
Received: by outflank-mailman (input) for mailman id 305304;
 Fri, 15 Apr 2022 05:02:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyM-0004b8-4a
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:18 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 19d281f0-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:54:17 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDy6-008PUJ-Fn; Fri, 15 Apr 2022 04:54:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19d281f0-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=J+DlKJplDF1Q+uvJsRC9/x84m39e7OAPqS6lbIf59go=; b=SEeH/79eKPqdW8SzrNl3V2nOHl
	ZWhXxUOKMmxbomD4h47qxDHhmZR1AcrilsdsHynv3whZecHSbjPQD1q9d/FU6+E8K/5xf+VTFPZEC
	yjptUXDEOozEKnhNef4pA/iH+U6X5UT2a4kDQV1dcB4OMBiR7EqjwvZGUpUqzaw/ctS1BK7jfj0ET
	6bEbZ634DG1jUBSD4gMSefXlbHX9s1oVYHaM3eb8uWhP4KXYOa4yPkTPaEVS3k17D/+asg++w51Tw
	tL9Bw3UnRO/ROF9NNLI3S4GrxiqTSBVA9Nyw52Y9tkIfGW9lfoR4Uoz9tWbp7jnXJX8faoVQRTg4x
	Z/Iw+o9w==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 19/27] block: remove queue_discard_alignment
Date: Fri, 15 Apr 2022 06:52:50 +0200
Message-Id: <20220415045258.199825-20-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Just use bdev_alignment_offset in disk_discard_alignment_show instead.
That helpers is the same except for an always false branch that doesn't
matter in this slow path.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/genhd.c          | 2 +-
 include/linux/blkdev.h | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index 712031ce19070..36532b9318419 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1019,7 +1019,7 @@ static ssize_t disk_discard_alignment_show(struct device *dev,
 {
 	struct gendisk *disk = dev_to_disk(dev);
 
-	return sprintf(buf, "%d\n", queue_discard_alignment(disk->queue));
+	return sprintf(buf, "%d\n", bdev_alignment_offset(disk->part0));
 }
 
 static ssize_t diskseq_show(struct device *dev,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 0a1795ac26275..5a9b7aeda010b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1253,14 +1253,6 @@ bdev_zone_write_granularity(struct block_device *bdev)
 
 int bdev_alignment_offset(struct block_device *bdev);
 
-static inline int queue_discard_alignment(const struct request_queue *q)
-{
-	if (q->limits.discard_misaligned)
-		return -1;
-
-	return q->limits.discard_alignment;
-}
-
 static inline int queue_limit_discard_alignment(struct queue_limits *lim, sector_t sector)
 {
 	unsigned int alignment, granularity, offset;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305308.520351 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6N-0000FF-LM; Fri, 15 Apr 2022 05:02:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305308.520351; Fri, 15 Apr 2022 05:02:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6N-0000DF-BV; Fri, 15 Apr 2022 05:02:35 +0000
Received: by outflank-mailman (input) for mailman id 305308;
 Fri, 15 Apr 2022 05:02:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDye-0004TJ-QS
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:37 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 245e43eb-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:54:34 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDyO-008Pqp-9l; Fri, 15 Apr 2022 04:54:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 245e43eb-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=1+K44dLnv1qtZ8K5ocxln1dNPqAEd3mqKxhGjJmuTNM=; b=YA4UrToMyLOyTb6T8PdQY6fa7w
	zSl96632xCt6vtjeoAiIMBf8lPrX6rvQ0aK7mUdQju7SSOoIcOGQIMjjsa583be9/X7eQs5/z9EEk
	ZxwkIJLzIlR7KGVOGBE3/O0Nz9gcgnfo8RRS9O4sFaWmfI9lGdcKc4cWGJDLRKW45p1c62AeuZHjg
	wDPYgHtEk0Rd30f09NF8sGQm5vhCpK4A+PvBPBZlS2RhImSgxXj2drTG/n3+oimsvID/A/YpcdPTb
	MgNmm6hkeDqou/BLupCl4YSpQ9XwMfjLX6IslwuZeNTzyz04MMHHT2QYYtekz8l/aJbm02lgwrQCn
	3FTCp5Vg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Coly Li <colyli@suse.de>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD
Date: Fri, 15 Apr 2022 06:52:57 +0200
Message-Id: <20220415045258.199825-27-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Secure erase is a very different operation from discard in that it is
a data integrity operation vs hint.  Fully split the limits and helper
infrastructure to make the separation more clear.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> [nifs2]
Acked-by: Jaegeuk Kim <jaegeuk@kernel.org> [f2fs]
Acked-by: Coly Li <colyli@suse.de> [bcache]
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 block/blk-core.c                    |  2 +-
 block/blk-lib.c                     | 64 ++++++++++++++++++++---------
 block/blk-mq-debugfs.c              |  1 -
 block/blk-settings.c                | 16 +++++++-
 block/fops.c                        |  2 +-
 block/ioctl.c                       | 43 +++++++++++++++----
 drivers/block/drbd/drbd_receiver.c  |  5 ++-
 drivers/block/rnbd/rnbd-clt.c       |  4 +-
 drivers/block/rnbd/rnbd-srv-dev.h   |  2 +-
 drivers/block/xen-blkback/blkback.c | 15 +++----
 drivers/block/xen-blkback/xenbus.c  |  5 +--
 drivers/block/xen-blkfront.c        |  5 ++-
 drivers/md/bcache/alloc.c           |  2 +-
 drivers/md/dm-table.c               |  8 ++--
 drivers/md/dm-thin.c                |  4 +-
 drivers/md/md.c                     |  2 +-
 drivers/md/raid5-cache.c            |  6 +--
 drivers/mmc/core/queue.c            |  2 +-
 drivers/nvme/target/io-cmd-bdev.c   |  2 +-
 drivers/target/target_core_file.c   |  2 +-
 drivers/target/target_core_iblock.c |  2 +-
 fs/btrfs/extent-tree.c              |  4 +-
 fs/ext4/mballoc.c                   |  2 +-
 fs/f2fs/file.c                      | 16 ++++----
 fs/f2fs/segment.c                   |  2 +-
 fs/jbd2/journal.c                   |  2 +-
 fs/nilfs2/sufile.c                  |  4 +-
 fs/nilfs2/the_nilfs.c               |  4 +-
 fs/ntfs3/super.c                    |  2 +-
 fs/xfs/xfs_discard.c                |  2 +-
 fs/xfs/xfs_log_cil.c                |  2 +-
 include/linux/blkdev.h              | 27 +++++++-----
 mm/swapfile.c                       |  6 +--
 33 files changed, 168 insertions(+), 99 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index b5c3a8049134c..ee18b6a699bdf 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -824,7 +824,7 @@ void submit_bio_noacct(struct bio *bio)
 			goto not_supported;
 		break;
 	case REQ_OP_SECURE_ERASE:
-		if (!blk_queue_secure_erase(q))
+		if (!bdev_max_secure_erase_sectors(bdev))
 			goto not_supported;
 		break;
 	case REQ_OP_ZONE_APPEND:
diff --git a/block/blk-lib.c b/block/blk-lib.c
index 43aa4d7fe859f..09b7e1200c0f4 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -36,26 +36,15 @@ static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
 }
 
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, int flags,
-		struct bio **biop)
+		sector_t nr_sects, gfp_t gfp_mask, struct bio **biop)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
-	unsigned int op;
 	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
-
-	if (flags & BLKDEV_DISCARD_SECURE) {
-		if (!blk_queue_secure_erase(q))
-			return -EOPNOTSUPP;
-		op = REQ_OP_SECURE_ERASE;
-	} else {
-		if (!bdev_max_discard_sectors(bdev))
-			return -EOPNOTSUPP;
-		op = REQ_OP_DISCARD;
-	}
+	if (!bdev_max_discard_sectors(bdev))
+		return -EOPNOTSUPP;
 
 	/* In case the discard granularity isn't set by buggy device driver */
 	if (WARN_ON_ONCE(!bdev_discard_granularity(bdev))) {
@@ -77,7 +66,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t req_sects =
 			min(nr_sects, bio_discard_limit(bdev, sector));
 
-		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
+		bio = blk_next_bio(bio, bdev, 0, REQ_OP_DISCARD, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
 		bio->bi_iter.bi_size = req_sects << 9;
 		sector += req_sects;
@@ -103,21 +92,19 @@ EXPORT_SYMBOL(__blkdev_issue_discard);
  * @sector:	start sector
  * @nr_sects:	number of sectors to discard
  * @gfp_mask:	memory allocation flags (for bio_alloc)
- * @flags:	BLKDEV_DISCARD_* flags to control behaviour
  *
  * Description:
  *    Issue a discard request for the sectors in question.
  */
 int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags)
+		sector_t nr_sects, gfp_t gfp_mask)
 {
 	struct bio *bio = NULL;
 	struct blk_plug plug;
 	int ret;
 
 	blk_start_plug(&plug);
-	ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, flags,
-			&bio);
+	ret = __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, &bio);
 	if (!ret && bio) {
 		ret = submit_bio_wait(bio);
 		if (ret == -EOPNOTSUPP)
@@ -314,3 +301,42 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
 	return ret;
 }
 EXPORT_SYMBOL(blkdev_issue_zeroout);
+
+int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp)
+{
+	sector_t bs_mask = (bdev_logical_block_size(bdev) >> 9) - 1;
+	unsigned int max_sectors = bdev_max_secure_erase_sectors(bdev);
+	struct bio *bio = NULL;
+	struct blk_plug plug;
+	int ret = 0;
+
+	if (max_sectors == 0)
+		return -EOPNOTSUPP;
+	if ((sector | nr_sects) & bs_mask)
+		return -EINVAL;
+	if (bdev_read_only(bdev))
+		return -EPERM;
+
+	blk_start_plug(&plug);
+	for (;;) {
+		unsigned int len = min_t(sector_t, nr_sects, max_sectors);
+
+		bio = blk_next_bio(bio, bdev, 0, REQ_OP_SECURE_ERASE, gfp);
+		bio->bi_iter.bi_sector = sector;
+		bio->bi_iter.bi_size = len;
+
+		sector += len << SECTOR_SHIFT;
+		nr_sects -= len << SECTOR_SHIFT;
+		if (!nr_sects) {
+			ret = submit_bio_wait(bio);
+			bio_put(bio);
+			break;
+		}
+		cond_resched();
+	}
+	blk_finish_plug(&plug);
+
+	return ret;
+}
+EXPORT_SYMBOL(blkdev_issue_secure_erase);
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index fd111c5001256..7e4136a60e1cc 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -115,7 +115,6 @@ static const char *const blk_queue_flag_name[] = {
 	QUEUE_FLAG_NAME(IO_STAT),
 	QUEUE_FLAG_NAME(NOXMERGES),
 	QUEUE_FLAG_NAME(ADD_RANDOM),
-	QUEUE_FLAG_NAME(SECERASE),
 	QUEUE_FLAG_NAME(SAME_FORCE),
 	QUEUE_FLAG_NAME(DEAD),
 	QUEUE_FLAG_NAME(INIT_DONE),
diff --git a/block/blk-settings.c b/block/blk-settings.c
index fd83d674afd0a..6ccceb421ed2f 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -46,6 +46,7 @@ void blk_set_default_limits(struct queue_limits *lim)
 	lim->max_zone_append_sectors = 0;
 	lim->max_discard_sectors = 0;
 	lim->max_hw_discard_sectors = 0;
+	lim->max_secure_erase_sectors = 0;
 	lim->discard_granularity = 0;
 	lim->discard_alignment = 0;
 	lim->discard_misaligned = 0;
@@ -176,6 +177,18 @@ void blk_queue_max_discard_sectors(struct request_queue *q,
 }
 EXPORT_SYMBOL(blk_queue_max_discard_sectors);
 
+/**
+ * blk_queue_max_secure_erase_sectors - set max sectors for a secure erase
+ * @q:  the request queue for the device
+ * @max_sectors: maximum number of sectors to secure_erase
+ **/
+void blk_queue_max_secure_erase_sectors(struct request_queue *q,
+		unsigned int max_sectors)
+{
+	q->limits.max_secure_erase_sectors = max_sectors;
+}
+EXPORT_SYMBOL(blk_queue_max_secure_erase_sectors);
+
 /**
  * blk_queue_max_write_zeroes_sectors - set max sectors for a single
  *                                      write zeroes
@@ -661,7 +674,8 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
 		t->discard_alignment = lcm_not_zero(t->discard_alignment, alignment) %
 			t->discard_granularity;
 	}
-
+	t->max_secure_erase_sectors = min_not_zero(t->max_secure_erase_sectors,
+						   b->max_secure_erase_sectors);
 	t->zone_write_granularity = max(t->zone_write_granularity,
 					b->zone_write_granularity);
 	t->zoned = max(t->zoned, b->zoned);
diff --git a/block/fops.c b/block/fops.c
index ba5e7d5ff9a52..e3643362c2440 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -677,7 +677,7 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
 		break;
 	case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE:
 		error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT,
-					     len >> SECTOR_SHIFT, GFP_KERNEL, 0);
+					     len >> SECTOR_SHIFT, GFP_KERNEL);
 		break;
 	default:
 		error = -EOPNOTSUPP;
diff --git a/block/ioctl.c b/block/ioctl.c
index c2cd3ba5290ce..5b5027fa78f7e 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -83,7 +83,7 @@ static int compat_blkpg_ioctl(struct block_device *bdev,
 #endif
 
 static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
-		unsigned long arg, unsigned long flags)
+		unsigned long arg)
 {
 	uint64_t range[2];
 	uint64_t start, len;
@@ -114,15 +114,43 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,
 	err = truncate_bdev_range(bdev, mode, start, start + len - 1);
 	if (err)
 		goto fail;
-
-	err = blkdev_issue_discard(bdev, start >> 9, len >> 9,
-				   GFP_KERNEL, flags);
-
+	err = blkdev_issue_discard(bdev, start >> 9, len >> 9, GFP_KERNEL);
 fail:
 	filemap_invalidate_unlock(inode->i_mapping);
 	return err;
 }
 
+static int blk_ioctl_secure_erase(struct block_device *bdev, fmode_t mode,
+		void __user *argp)
+{
+	uint64_t start, len;
+	uint64_t range[2];
+	int err;
+
+	if (!(mode & FMODE_WRITE))
+		return -EBADF;
+	if (!bdev_max_secure_erase_sectors(bdev))
+		return -EOPNOTSUPP;
+	if (copy_from_user(range, argp, sizeof(range)))
+		return -EFAULT;
+
+	start = range[0];
+	len = range[1];
+	if ((start & 511) || (len & 511))
+		return -EINVAL;
+	if (start + len > bdev_nr_bytes(bdev))
+		return -EINVAL;
+
+	filemap_invalidate_lock(bdev->bd_inode->i_mapping);
+	err = truncate_bdev_range(bdev, mode, start, start + len - 1);
+	if (!err)
+		err = blkdev_issue_secure_erase(bdev, start >> 9, len >> 9,
+						GFP_KERNEL);
+	filemap_invalidate_unlock(bdev->bd_inode->i_mapping);
+	return err;
+}
+
+
 static int blk_ioctl_zeroout(struct block_device *bdev, fmode_t mode,
 		unsigned long arg)
 {
@@ -450,10 +478,9 @@ static int blkdev_common_ioctl(struct block_device *bdev, fmode_t mode,
 	case BLKROSET:
 		return blkdev_roset(bdev, mode, cmd, arg);
 	case BLKDISCARD:
-		return blk_ioctl_discard(bdev, mode, arg, 0);
+		return blk_ioctl_discard(bdev, mode, arg);
 	case BLKSECDISCARD:
-		return blk_ioctl_discard(bdev, mode, arg,
-				BLKDEV_DISCARD_SECURE);
+		return blk_ioctl_secure_erase(bdev, mode, argp);
 	case BLKZEROOUT:
 		return blk_ioctl_zeroout(bdev, mode, arg);
 	case BLKGETDISKSEQ:
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 275c53c7b629e..2957b0b68d600 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1547,7 +1547,8 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		start = tmp;
 	}
 	while (nr_sectors >= max_discard_sectors) {
-		err |= blkdev_issue_discard(bdev, start, max_discard_sectors, GFP_NOIO, 0);
+		err |= blkdev_issue_discard(bdev, start, max_discard_sectors,
+					    GFP_NOIO);
 		nr_sectors -= max_discard_sectors;
 		start += max_discard_sectors;
 	}
@@ -1559,7 +1560,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 		nr = nr_sectors;
 		nr -= (unsigned int)nr % granularity;
 		if (nr) {
-			err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO, 0);
+			err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO);
 			nr_sectors -= nr;
 			start += nr;
 		}
diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index efa99a3884507..d178be175ad99 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1365,8 +1365,8 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
 	dev->queue->limits.discard_granularity	= dev->discard_granularity;
 	dev->queue->limits.discard_alignment	= dev->discard_alignment;
 	if (dev->secure_discard)
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, dev->queue);
-
+		blk_queue_max_secure_erase_sectors(dev->queue,
+				dev->max_discard_sectors);
 	blk_queue_flag_set(QUEUE_FLAG_SAME_COMP, dev->queue);
 	blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue);
 	blk_queue_max_segments(dev->queue, dev->max_segments);
diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index 1f7e1c8fd4d9b..d080a0de59225 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -44,7 +44,7 @@ static inline int rnbd_dev_get_max_hw_sects(const struct rnbd_dev *dev)
 
 static inline int rnbd_dev_get_secure_discard(const struct rnbd_dev *dev)
 {
-	return blk_queue_secure_erase(bdev_get_queue(dev->bdev));
+	return bdev_max_secure_erase_sectors(dev->bdev);
 }
 
 static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index de42458195bc1..a97f2bf5b01b9 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -970,7 +970,6 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
 	int status = BLKIF_RSP_OKAY;
 	struct xen_blkif *blkif = ring->blkif;
 	struct block_device *bdev = blkif->vbd.bdev;
-	unsigned long secure;
 	struct phys_req preq;
 
 	xen_blkif_get(blkif);
@@ -987,13 +986,15 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring,
 	}
 	ring->st_ds_req++;
 
-	secure = (blkif->vbd.discard_secure &&
-		 (req->u.discard.flag & BLKIF_DISCARD_SECURE)) ?
-		 BLKDEV_DISCARD_SECURE : 0;
+	if (blkif->vbd.discard_secure &&
+	    (req->u.discard.flag & BLKIF_DISCARD_SECURE))
+		err = blkdev_issue_secure_erase(bdev,
+				req->u.discard.sector_number,
+				req->u.discard.nr_sectors, GFP_KERNEL);
+	else
+		err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
+				req->u.discard.nr_sectors, GFP_KERNEL);
 
-	err = blkdev_issue_discard(bdev, req->u.discard.sector_number,
-				   req->u.discard.nr_sectors,
-				   GFP_KERNEL, secure);
 fail_response:
 	if (err == -EOPNOTSUPP) {
 		pr_debug("discard op failed, not supported\n");
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 83cd08041e6b3..b21bffc9c50bc 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -484,7 +484,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 {
 	struct xen_vbd *vbd;
 	struct block_device *bdev;
-	struct request_queue *q;
 
 	vbd = &blkif->vbd;
 	vbd->handle   = handle;
@@ -516,11 +515,9 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 	if (vbd->bdev->bd_disk->flags & GENHD_FL_REMOVABLE)
 		vbd->type |= VDISK_REMOVABLE;
 
-	q = bdev_get_queue(bdev);
 	if (bdev_write_cache(bdev))
 		vbd->flush_support = true;
-
-	if (q && blk_queue_secure_erase(q))
+	if (bdev_max_secure_erase_sectors(bdev))
 		vbd->discard_secure = true;
 
 	vbd->feature_gnt_persistent = feature_persistent;
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index e13cb4d48f1ea..0f3f5238f7bce 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -949,7 +949,8 @@ static void blkif_set_queue_limits(struct blkfront_info *info)
 						 info->physical_sector_size;
 		rq->limits.discard_alignment = info->discard_alignment;
 		if (info->feature_secdiscard)
-			blk_queue_flag_set(QUEUE_FLAG_SECERASE, rq);
+			blk_queue_max_secure_erase_sectors(rq,
+							   get_capacity(gd));
 	}
 
 	/* Hard sector size and max sectors impersonate the equiv. hardware. */
@@ -1606,7 +1607,7 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
 				info->feature_discard = 0;
 				info->feature_secdiscard = 0;
 				blk_queue_max_discard_sectors(rq, 0);
-				blk_queue_flag_clear(QUEUE_FLAG_SECERASE, rq);
+				blk_queue_max_secure_erase_sectors(rq, 0);
 			}
 			break;
 		case BLKIF_OP_FLUSH_DISKCACHE:
diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
index 097577ae3c471..ce13c272c3872 100644
--- a/drivers/md/bcache/alloc.c
+++ b/drivers/md/bcache/alloc.c
@@ -336,7 +336,7 @@ static int bch_allocator_thread(void *arg)
 				mutex_unlock(&ca->set->bucket_lock);
 				blkdev_issue_discard(ca->bdev,
 					bucket_to_sector(ca->set, bucket),
-					ca->sb.bucket_size, GFP_KERNEL, 0);
+					ca->sb.bucket_size, GFP_KERNEL);
 				mutex_lock(&ca->set->bucket_lock);
 			}
 
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 0dff6907fd00d..e7d42f6335a2a 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1920,9 +1920,7 @@ static int device_not_secure_erase_capable(struct dm_target *ti,
 					   struct dm_dev *dev, sector_t start,
 					   sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_secure_erase(q);
+	return !bdev_max_secure_erase_sectors(dev->bdev);
 }
 
 static bool dm_table_supports_secure_erase(struct dm_table *t)
@@ -1975,8 +1973,8 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
 		q->limits.discard_misaligned = 0;
 	}
 
-	if (dm_table_supports_secure_erase(t))
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
+	if (!dm_table_supports_secure_erase(t))
+		q->limits.max_secure_erase_sectors = 0;
 
 	if (dm_table_supports_flush(t, (1UL << QUEUE_FLAG_WC))) {
 		wc = true;
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index eded4bcc4545f..84c083f766736 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -398,8 +398,8 @@ static int issue_discard(struct discard_op *op, dm_block_t data_b, dm_block_t da
 	sector_t s = block_to_sectors(tc->pool, data_b);
 	sector_t len = block_to_sectors(tc->pool, data_e - data_b);
 
-	return __blkdev_issue_discard(tc->pool_dev->bdev, s, len,
-				      GFP_NOWAIT, 0, &op->bio);
+	return __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOWAIT,
+				      &op->bio);
 }
 
 static void end_discard(struct discard_op *op, int r)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 19636c2f2cda4..2587f872c0884 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8584,7 +8584,7 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
 {
 	struct bio *discard_bio = NULL;
 
-	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, 0,
+	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,
 			&discard_bio) || !discard_bio)
 		return;
 
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index c3cbf9a574a39..094a4042589eb 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1344,14 +1344,14 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
 	if (log->last_checkpoint < end) {
 		blkdev_issue_discard(bdev,
 				log->last_checkpoint + log->rdev->data_offset,
-				end - log->last_checkpoint, GFP_NOIO, 0);
+				end - log->last_checkpoint, GFP_NOIO);
 	} else {
 		blkdev_issue_discard(bdev,
 				log->last_checkpoint + log->rdev->data_offset,
 				log->device_size - log->last_checkpoint,
-				GFP_NOIO, 0);
+				GFP_NOIO);
 		blkdev_issue_discard(bdev, log->rdev->data_offset, end,
-				GFP_NOIO, 0);
+				GFP_NOIO);
 	}
 }
 
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index cac6315010a3d..a3d4460055716 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -189,7 +189,7 @@ static void mmc_queue_setup_discard(struct request_queue *q,
 	if (card->pref_erase > max_discard)
 		q->limits.discard_granularity = SECTOR_SIZE;
 	if (mmc_can_secure_erase_trim(card))
-		blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
+		blk_queue_max_secure_erase_sectors(q, max_discard);
 }
 
 static unsigned short mmc_get_max_segments(struct mmc_host *host)
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
index d886c2c59554f..27a72504d31ce 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
+++ b/drivers/nvme/target/io-cmd-bdev.c
@@ -360,7 +360,7 @@ static u16 nvmet_bdev_discard_range(struct nvmet_req *req,
 	ret = __blkdev_issue_discard(ns->bdev,
 			nvmet_lba_to_sect(ns, range->slba),
 			le32_to_cpu(range->nlb) << (ns->blksize_shift - 9),
-			GFP_KERNEL, 0, bio);
+			GFP_KERNEL, bio);
 	if (ret && ret != -EOPNOTSUPP) {
 		req->error_slba = le64_to_cpu(range->slba);
 		return errno_to_nvme_status(req, ret);
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index b6ba582b06775..e68f1cc8ef98b 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -558,7 +558,7 @@ fd_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
 		ret = blkdev_issue_discard(bdev,
 					   target_to_linux_sector(dev, lba),
 					   target_to_linux_sector(dev,  nolb),
-					   GFP_KERNEL, 0);
+					   GFP_KERNEL);
 		if (ret < 0) {
 			pr_warn("FILEIO: blkdev_issue_discard() failed: %d\n",
 				ret);
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index c4a903b8a47fc..378c80313a0f2 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -434,7 +434,7 @@ iblock_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb)
 	ret = blkdev_issue_discard(bdev,
 				   target_to_linux_sector(dev, lba),
 				   target_to_linux_sector(dev,  nolb),
-				   GFP_KERNEL, 0);
+				   GFP_KERNEL);
 	if (ret < 0) {
 		pr_err("blkdev_issue_discard() failed: %d\n", ret);
 		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index efd8deb3ab7e8..5c1d3a564da5a 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1239,7 +1239,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
 
 		if (size) {
 			ret = blkdev_issue_discard(bdev, start >> 9, size >> 9,
-						   GFP_NOFS, 0);
+						   GFP_NOFS);
 			if (!ret)
 				*discarded_bytes += size;
 			else if (ret != -EOPNOTSUPP)
@@ -1256,7 +1256,7 @@ static int btrfs_issue_discard(struct block_device *bdev, u64 start, u64 len,
 
 	if (bytes_left) {
 		ret = blkdev_issue_discard(bdev, start >> 9, bytes_left >> 9,
-					   GFP_NOFS, 0);
+					   GFP_NOFS);
 		if (!ret)
 			*discarded_bytes += bytes_left;
 	}
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 6d1820536d88d..ea653d19f9ec7 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3629,7 +3629,7 @@ static inline int ext4_issue_discard(struct super_block *sb,
 		return __blkdev_issue_discard(sb->s_bdev,
 			(sector_t)discard_block << (sb->s_blocksize_bits - 9),
 			(sector_t)count << (sb->s_blocksize_bits - 9),
-			GFP_NOFS, 0, biop);
+			GFP_NOFS, biop);
 	} else
 		return sb_issue_discard(sb, discard_block, count, GFP_NOFS, 0);
 }
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 8053d99f3920b..35b6c720c2bc1 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3685,18 +3685,18 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg)
 static int f2fs_secure_erase(struct block_device *bdev, struct inode *inode,
 		pgoff_t off, block_t block, block_t len, u32 flags)
 {
-	struct request_queue *q = bdev_get_queue(bdev);
 	sector_t sector = SECTOR_FROM_BLOCK(block);
 	sector_t nr_sects = SECTOR_FROM_BLOCK(len);
 	int ret = 0;
 
-	if (!q)
-		return -ENXIO;
-
-	if (flags & F2FS_TRIM_FILE_DISCARD)
-		ret = blkdev_issue_discard(bdev, sector, nr_sects, GFP_NOFS,
-						blk_queue_secure_erase(q) ?
-						BLKDEV_DISCARD_SECURE : 0);
+	if (flags & F2FS_TRIM_FILE_DISCARD) {
+		if (bdev_max_secure_erase_sectors(bdev))
+			ret = blkdev_issue_secure_erase(bdev, sector, nr_sects,
+					GFP_NOFS);
+		else
+			ret = blkdev_issue_discard(bdev, sector, nr_sects,
+					GFP_NOFS);
+	}
 
 	if (!ret && (flags & F2FS_TRIM_FILE_ZEROOUT)) {
 		if (IS_ENCRYPTED(inode))
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 71f09adbcba86..e433c61e64b93 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1244,7 +1244,7 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
 		err = __blkdev_issue_discard(bdev,
 					SECTOR_FROM_BLOCK(start),
 					SECTOR_FROM_BLOCK(len),
-					GFP_NOFS, 0, &bio);
+					GFP_NOFS, &bio);
 submit:
 		if (err) {
 			spin_lock_irqsave(&dc->lock, flags);
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 19d226cd4ff4d..c0cbeeaec2d1a 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1825,7 +1825,7 @@ static int __jbd2_journal_erase(journal_t *journal, unsigned int flags)
 			err = blkdev_issue_discard(journal->j_dev,
 					byte_start >> SECTOR_SHIFT,
 					byte_count >> SECTOR_SHIFT,
-					GFP_NOFS, 0);
+					GFP_NOFS);
 		} else if (flags & JBD2_JOURNAL_FLUSH_ZEROOUT) {
 			err = blkdev_issue_zeroout(journal->j_dev,
 					byte_start >> SECTOR_SHIFT,
diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c
index e385cca2004a7..77ff8e95421fa 100644
--- a/fs/nilfs2/sufile.c
+++ b/fs/nilfs2/sufile.c
@@ -1100,7 +1100,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
 				ret = blkdev_issue_discard(nilfs->ns_bdev,
 						start * sects_per_block,
 						nblocks * sects_per_block,
-						GFP_NOFS, 0);
+						GFP_NOFS);
 				if (ret < 0) {
 					put_bh(su_bh);
 					goto out_sem;
@@ -1134,7 +1134,7 @@ int nilfs_sufile_trim_fs(struct inode *sufile, struct fstrim_range *range)
 			ret = blkdev_issue_discard(nilfs->ns_bdev,
 					start * sects_per_block,
 					nblocks * sects_per_block,
-					GFP_NOFS, 0);
+					GFP_NOFS);
 			if (!ret)
 				ndiscarded += nblocks;
 		}
diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c
index dd48a8f74d577..3b4a079c9617c 100644
--- a/fs/nilfs2/the_nilfs.c
+++ b/fs/nilfs2/the_nilfs.c
@@ -672,7 +672,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
 			ret = blkdev_issue_discard(nilfs->ns_bdev,
 						   start * sects_per_block,
 						   nblocks * sects_per_block,
-						   GFP_NOFS, 0);
+						   GFP_NOFS);
 			if (ret < 0)
 				return ret;
 			nblocks = 0;
@@ -682,7 +682,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump,
 		ret = blkdev_issue_discard(nilfs->ns_bdev,
 					   start * sects_per_block,
 					   nblocks * sects_per_block,
-					   GFP_NOFS, 0);
+					   GFP_NOFS);
 	return ret;
 }
 
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 5f2e414cfa79b..5781b9e8e3d85 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1333,7 +1333,7 @@ int ntfs_discard(struct ntfs_sb_info *sbi, CLST lcn, CLST len)
 		return 0;
 
 	err = blkdev_issue_discard(sb->s_bdev, start >> 9, (end - start) >> 9,
-				   GFP_NOFS, 0);
+				   GFP_NOFS);
 
 	if (err == -EOPNOTSUPP)
 		sbi->flags |= NTFS_FLAGS_NODISCARD;
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index e2ada115c23f9..c6fe3f6ebb6b0 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -114,7 +114,7 @@ xfs_trim_extents(
 		}
 
 		trace_xfs_discard_extent(mp, agno, fbno, flen);
-		error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS, 0);
+		error = blkdev_issue_discard(bdev, dbno, dlen, GFP_NOFS);
 		if (error)
 			goto out_del_cursor;
 		*blocks_trimmed += flen;
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
index ba57323bfdcea..c9f55e4f09571 100644
--- a/fs/xfs/xfs_log_cil.c
+++ b/fs/xfs/xfs_log_cil.c
@@ -605,7 +605,7 @@ xlog_discard_busy_extents(
 		error = __blkdev_issue_discard(mp->m_ddev_targp->bt_bdev,
 				XFS_AGB_TO_DADDR(mp, busyp->agno, busyp->bno),
 				XFS_FSB_TO_BB(mp, busyp->length),
-				GFP_NOFS, 0, &bio);
+				GFP_NOFS, &bio);
 		if (error && error != -EOPNOTSUPP) {
 			xfs_info(mp,
 	 "discard failed for extent [0x%llx,%u], error %d",
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f1cf557ea20ef..c9b5925af5a3b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -248,6 +248,7 @@ struct queue_limits {
 	unsigned int		io_opt;
 	unsigned int		max_discard_sectors;
 	unsigned int		max_hw_discard_sectors;
+	unsigned int		max_secure_erase_sectors;
 	unsigned int		max_write_zeroes_sectors;
 	unsigned int		max_zone_append_sectors;
 	unsigned int		discard_granularity;
@@ -542,7 +543,6 @@ struct request_queue {
 #define QUEUE_FLAG_IO_STAT	7	/* do disk/partitions IO accounting */
 #define QUEUE_FLAG_NOXMERGES	9	/* No extended merges */
 #define QUEUE_FLAG_ADD_RANDOM	10	/* Contributes to random pool */
-#define QUEUE_FLAG_SECERASE	11	/* supports secure erase */
 #define QUEUE_FLAG_SAME_FORCE	12	/* force complete on same CPU */
 #define QUEUE_FLAG_DEAD		13	/* queue tear-down finished */
 #define QUEUE_FLAG_INIT_DONE	14	/* queue is initialized */
@@ -583,8 +583,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 #define blk_queue_add_random(q)	test_bit(QUEUE_FLAG_ADD_RANDOM, &(q)->queue_flags)
 #define blk_queue_zone_resetall(q)	\
 	test_bit(QUEUE_FLAG_ZONE_RESETALL, &(q)->queue_flags)
-#define blk_queue_secure_erase(q) \
-	(test_bit(QUEUE_FLAG_SECERASE, &(q)->queue_flags))
 #define blk_queue_dax(q)	test_bit(QUEUE_FLAG_DAX, &(q)->queue_flags)
 #define blk_queue_pci_p2pdma(q)	\
 	test_bit(QUEUE_FLAG_PCI_P2PDMA, &(q)->queue_flags)
@@ -947,6 +945,8 @@ extern void blk_queue_chunk_sectors(struct request_queue *, unsigned int);
 extern void blk_queue_max_segments(struct request_queue *, unsigned short);
 extern void blk_queue_max_discard_segments(struct request_queue *,
 		unsigned short);
+void blk_queue_max_secure_erase_sectors(struct request_queue *q,
+		unsigned int max_sectors);
 extern void blk_queue_max_segment_size(struct request_queue *, unsigned int);
 extern void blk_queue_max_discard_sectors(struct request_queue *q,
 		unsigned int max_discard_sectors);
@@ -1087,13 +1087,12 @@ static inline long nr_blockdev_pages(void)
 
 extern void blk_io_schedule(void);
 
-#define BLKDEV_DISCARD_SECURE	(1 << 0)	/* issue a secure erase */
-
-extern int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags);
-extern int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
-		sector_t nr_sects, gfp_t gfp_mask, int flags,
-		struct bio **biop);
+int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp_mask);
+int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp_mask, struct bio **biop);
+int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
+		sector_t nr_sects, gfp_t gfp);
 
 #define BLKDEV_ZERO_NOUNMAP	(1 << 0)  /* do not free blocks */
 #define BLKDEV_ZERO_NOFALLBACK	(1 << 1)  /* don't write explicit zeroes */
@@ -1112,7 +1111,7 @@ static inline int sb_issue_discard(struct super_block *sb, sector_t block,
 					      SECTOR_SHIFT),
 				    nr_blocks << (sb->s_blocksize_bits -
 						  SECTOR_SHIFT),
-				    gfp_mask, flags);
+				    gfp_mask);
 }
 static inline int sb_issue_zeroout(struct super_block *sb, sector_t block,
 		sector_t nr_blocks, gfp_t gfp_mask)
@@ -1262,6 +1261,12 @@ static inline unsigned int bdev_discard_granularity(struct block_device *bdev)
 	return bdev_get_queue(bdev)->limits.discard_granularity;
 }
 
+static inline unsigned int
+bdev_max_secure_erase_sectors(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.max_secure_erase_sectors;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 5d9cedf9e7b84..a2b31fea0c42e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -179,7 +179,7 @@ static int discard_swap(struct swap_info_struct *si)
 	nr_blocks = ((sector_t)se->nr_pages - 1) << (PAGE_SHIFT - 9);
 	if (nr_blocks) {
 		err = blkdev_issue_discard(si->bdev, start_block,
-				nr_blocks, GFP_KERNEL, 0);
+				nr_blocks, GFP_KERNEL);
 		if (err)
 			return err;
 		cond_resched();
@@ -190,7 +190,7 @@ static int discard_swap(struct swap_info_struct *si)
 		nr_blocks = (sector_t)se->nr_pages << (PAGE_SHIFT - 9);
 
 		err = blkdev_issue_discard(si->bdev, start_block,
-				nr_blocks, GFP_KERNEL, 0);
+				nr_blocks, GFP_KERNEL);
 		if (err)
 			break;
 
@@ -254,7 +254,7 @@ static void discard_swap_cluster(struct swap_info_struct *si,
 		start_block <<= PAGE_SHIFT - 9;
 		nr_blocks <<= PAGE_SHIFT - 9;
 		if (blkdev_issue_discard(si->bdev, start_block,
-					nr_blocks, GFP_NOIO, 0))
+					nr_blocks, GFP_NOIO))
 			break;
 
 		se = next_se(se);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305309.520368 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6Q-00013r-Ou; Fri, 15 Apr 2022 05:02:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305309.520368; Fri, 15 Apr 2022 05:02:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6Q-000117-B5; Fri, 15 Apr 2022 05:02:38 +0000
Received: by outflank-mailman (input) for mailman id 305309;
 Fri, 15 Apr 2022 05:02:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDxz-0004b8-J9
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:53:55 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0bffa702-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:53:53 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxl-008P65-E3; Fri, 15 Apr 2022 04:53:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bffa702-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=HrgNfnZXHjI7+oEfFDB5J5Uuocj6xy8pedsh1Yy5WG4=; b=R0lBPRibOGoSZmsdT2BBTTPD3x
	NwCzRpJB/bxli2xONupKhhJNx7Tq1nA6hg5urvI8CevCDma1aSHOvltCxPQVBkCYYIAazdu94JhOg
	jUc9C0uB0ZcqdXuo3tqllo7RFWblcuoKttRRtshPAOTk9xPWXo9L51Jx+MBLxWuevzEN6ePJqPM9o
	O/Kgk+1vrPJJ/tXWxgEWAoGzr7Z1pW3yunSGYLN41shEprbTPauLr7ZDX+uOWX/sBmVGFEWkzS8iP
	pSkYNyZUK+8w0sI6r2DBAifGctVRL3GCvrebz8RO5GOBvOX0W6zq/yOSLOkXbitIIxFW4u3HYF7ZU
	82QTqcrQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 11/27] block: add a bdev_nonrot helper
Date: Fri, 15 Apr 2022 06:52:42 +0200
Message-Id: <20220415045258.199825-12-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the nonrot flag based on the block_device instead
of having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 block/ioctl.c                       | 2 +-
 drivers/block/loop.c                | 2 +-
 drivers/md/dm-table.c               | 4 +---
 drivers/md/md.c                     | 3 +--
 drivers/md/raid1.c                  | 2 +-
 drivers/md/raid10.c                 | 2 +-
 drivers/md/raid5.c                  | 2 +-
 drivers/target/target_core_file.c   | 3 +--
 drivers/target/target_core_iblock.c | 2 +-
 fs/btrfs/volumes.c                  | 4 ++--
 fs/ext4/mballoc.c                   | 2 +-
 include/linux/blkdev.h              | 5 +++++
 mm/swapfile.c                       | 4 ++--
 13 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/block/ioctl.c b/block/ioctl.c
index 4a86340133e46..ad3771b268b81 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -489,7 +489,7 @@ static int blkdev_common_ioctl(struct block_device *bdev, fmode_t mode,
 				    queue_max_sectors(bdev_get_queue(bdev)));
 		return put_ushort(argp, max_sectors);
 	case BLKROTATIONAL:
-		return put_ushort(argp, !blk_queue_nonrot(bdev_get_queue(bdev)));
+		return put_ushort(argp, !bdev_nonrot(bdev));
 	case BLKRASET:
 	case BLKFRASET:
 		if(!capable(CAP_SYS_ADMIN))
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index a58595f5ee2c8..8d800d46e4985 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -903,7 +903,7 @@ static void loop_update_rotational(struct loop_device *lo)
 
 	/* not all filesystems (e.g. tmpfs) have a sb->s_bdev */
 	if (file_bdev)
-		nonrot = blk_queue_nonrot(bdev_get_queue(file_bdev));
+		nonrot = bdev_nonrot(file_bdev);
 
 	if (nonrot)
 		blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 03541cfc2317c..5e38d0dd009d5 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1820,9 +1820,7 @@ static int device_dax_write_cache_enabled(struct dm_target *ti,
 static int device_is_rotational(struct dm_target *ti, struct dm_dev *dev,
 				sector_t start, sector_t len, void *data)
 {
-	struct request_queue *q = bdev_get_queue(dev->bdev);
-
-	return !blk_queue_nonrot(q);
+	return !bdev_nonrot(dev->bdev);
 }
 
 static int device_is_not_random(struct dm_target *ti, struct dm_dev *dev,
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 309b3af906ad3..19636c2f2cda4 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5991,8 +5991,7 @@ int md_run(struct mddev *mddev)
 		bool nonrot = true;
 
 		rdev_for_each(rdev, mddev) {
-			if (rdev->raid_disk >= 0 &&
-			    !blk_queue_nonrot(bdev_get_queue(rdev->bdev))) {
+			if (rdev->raid_disk >= 0 && !bdev_nonrot(rdev->bdev)) {
 				nonrot = false;
 				break;
 			}
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 99d5464a51f81..d81b896855f9f 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -704,7 +704,7 @@ static int read_balance(struct r1conf *conf, struct r1bio *r1_bio, int *max_sect
 			/* At least two disks to choose from so failfast is OK */
 			set_bit(R1BIO_FailFast, &r1_bio->state);
 
-		nonrot = blk_queue_nonrot(bdev_get_queue(rdev->bdev));
+		nonrot = bdev_nonrot(rdev->bdev);
 		has_nonrot_disk |= nonrot;
 		pending = atomic_read(&rdev->nr_pending);
 		dist = abs(this_sector - conf->mirrors[disk].head_position);
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index dfe7d62d3fbdd..7816c8b2e8087 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -796,7 +796,7 @@ static struct md_rdev *read_balance(struct r10conf *conf,
 		if (!do_balance)
 			break;
 
-		nonrot = blk_queue_nonrot(bdev_get_queue(rdev->bdev));
+		nonrot = bdev_nonrot(rdev->bdev);
 		has_nonrot_disk |= nonrot;
 		pending = atomic_read(&rdev->nr_pending);
 		if (min_pending > pending && nonrot) {
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 351d341a1ffa4..0bbae0e638666 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7242,7 +7242,7 @@ static struct r5conf *setup_conf(struct mddev *mddev)
 	rdev_for_each(rdev, mddev) {
 		if (test_bit(Journal, &rdev->flags))
 			continue;
-		if (blk_queue_nonrot(bdev_get_queue(rdev->bdev))) {
+		if (bdev_nonrot(rdev->bdev)) {
 			conf->batch_bio_dispatch = false;
 			break;
 		}
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index 8d191fdc33217..b6ba582b06775 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -135,7 +135,6 @@ static int fd_configure_device(struct se_device *dev)
 	inode = file->f_mapping->host;
 	if (S_ISBLK(inode->i_mode)) {
 		struct block_device *bdev = I_BDEV(inode);
-		struct request_queue *q = bdev_get_queue(bdev);
 		unsigned long long dev_size;
 
 		fd_dev->fd_block_size = bdev_logical_block_size(bdev);
@@ -160,7 +159,7 @@ static int fd_configure_device(struct se_device *dev)
 		 */
 		dev->dev_attrib.max_write_same_len = 0xFFFF;
 
-		if (blk_queue_nonrot(q))
+		if (bdev_nonrot(bdev))
 			dev->dev_attrib.is_nonrot = 1;
 	} else {
 		if (!(fd_dev->fbd_flags & FBDF_HAS_SIZE)) {
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index b886ce1770bfd..b41ee5c3b5b82 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -133,7 +133,7 @@ static int iblock_configure_device(struct se_device *dev)
 	else
 		dev->dev_attrib.max_write_same_len = 0xFFFF;
 
-	if (blk_queue_nonrot(q))
+	if (bdev_nonrot(bd))
 		dev->dev_attrib.is_nonrot = 1;
 
 	bi = bdev_get_integrity(bd);
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2cfbc74a3b4ee..77f1a5696842b 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -643,7 +643,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
 			set_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state);
 	}
 
-	if (!blk_queue_nonrot(bdev_get_queue(bdev)))
+	if (!bdev_nonrot(bdev))
 		fs_devices->rotating = true;
 
 	device->bdev = bdev;
@@ -2706,7 +2706,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
 
 	atomic64_add(device->total_bytes, &fs_info->free_chunk_space);
 
-	if (!blk_queue_nonrot(bdev_get_queue(bdev)))
+	if (!bdev_nonrot(bdev))
 		fs_devices->rotating = true;
 
 	orig_super_total_bytes = btrfs_super_total_bytes(fs_info->super_copy);
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 252c168454c7f..c3668c977cd99 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3498,7 +3498,7 @@ int ext4_mb_init(struct super_block *sb)
 		spin_lock_init(&lg->lg_prealloc_lock);
 	}
 
-	if (blk_queue_nonrot(bdev_get_queue(sb->s_bdev)))
+	if (bdev_nonrot(sb->s_bdev))
 		sbi->s_mb_max_linear_groups = 0;
 	else
 		sbi->s_mb_max_linear_groups = MB_DEFAULT_LINEAR_LIMIT;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 60d0161389971..3a9578e14a6b0 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1326,6 +1326,11 @@ static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 	return 0;
 }
 
+static inline bool bdev_nonrot(struct block_device *bdev)
+{
+	return blk_queue_nonrot(bdev_get_queue(bdev));
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 4c7537162af5e..d5ab7ec4d92ca 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2466,7 +2466,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile)
 	if (p->flags & SWP_CONTINUED)
 		free_swap_count_continuations(p);
 
-	if (!p->bdev || !blk_queue_nonrot(bdev_get_queue(p->bdev)))
+	if (!p->bdev || !bdev_nonrot(p->bdev))
 		atomic_dec(&nr_rotate_swap);
 
 	mutex_lock(&swapon_mutex);
@@ -3071,7 +3071,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 	if (p->bdev && p->bdev->bd_disk->fops->rw_page)
 		p->flags |= SWP_SYNCHRONOUS_IO;
 
-	if (p->bdev && blk_queue_nonrot(bdev_get_queue(p->bdev))) {
+	if (p->bdev && bdev_nonrot(p->bdev)) {
 		int cpu;
 		unsigned long ci, nr_cluster;
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305320.520380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6d-0002sC-7N; Fri, 15 Apr 2022 05:02:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305320.520380; Fri, 15 Apr 2022 05:02:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6d-0002ro-2F; Fri, 15 Apr 2022 05:02:51 +0000
Received: by outflank-mailman (input) for mailman id 305320;
 Fri, 15 Apr 2022 05:02:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyB-0004b8-15
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:07 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 114fa417-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:54:02 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDxq-008PC1-Gz; Fri, 15 Apr 2022 04:53:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 114fa417-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=ZlX6tQSx9Ltba6eWidCjog7i9CmwA2DoDl+4xkJfBJs=; b=mK5Q76NpPUvc78f6UJP6DQWA/7
	NKBjQM3eKggVVlsB90RP9nWbWfQQRf5B/jpgaA1Q9EfhEKM6lJIkbGZcu7PpXQpjIFw5FBt2pbsp/
	MOoSSA4Ia9EScAPP1GzU9Z/ZQQucRFdEcK1J7IinCMg7xBNHzYM+zhxh9/8+JGCxjva2x2nAoCRtc
	/jXC9gicBp3dw18FSq1x+PVYM/uSyKZyRhIEi86XF4FPTwvQg4pS+RVuHw79vZX329QreecldYuvL
	XgVsFKXu2B19byXqlKObQtsOc9NysNwyvK+OIp8FWlGn58YTS0dBRTNV0sUd2V4lcvAVAxYH2RH2k
	wQndRV7A==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 13/27] block: add a bdev_fua helper
Date: Fri, 15 Apr 2022 06:52:44 +0200
Message-Id: <20220415045258.199825-14-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to check the FUA flag based on the block_device instead of
having to poke into the block layer internal request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/block/rnbd/rnbd-srv.c       | 3 +--
 drivers/target/target_core_iblock.c | 3 +--
 fs/iomap/direct-io.c                | 3 +--
 include/linux/blkdev.h              | 6 +++++-
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index f8cc3c5fecb4b..beaef43a67b9d 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -533,7 +533,6 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 					struct rnbd_srv_sess_dev *sess_dev)
 {
 	struct rnbd_dev *rnbd_dev = sess_dev->rnbd_dev;
-	struct request_queue *q = bdev_get_queue(rnbd_dev->bdev);
 
 	rsp->hdr.type = cpu_to_le16(RNBD_MSG_OPEN_RSP);
 	rsp->device_id =
@@ -560,7 +559,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 	rsp->cache_policy = 0;
 	if (bdev_write_cache(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_WRITEBACK;
-	if (blk_queue_fua(q))
+	if (bdev_fua(rnbd_dev->bdev))
 		rsp->cache_policy |= RNBD_FUA;
 }
 
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 03013e85ffc03..c4a903b8a47fc 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -727,14 +727,13 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
 
 	if (data_direction == DMA_TO_DEVICE) {
 		struct iblock_dev *ib_dev = IBLOCK_DEV(dev);
-		struct request_queue *q = bdev_get_queue(ib_dev->ibd_bd);
 		/*
 		 * Force writethrough using REQ_FUA if a volatile write cache
 		 * is not enabled, or if initiator set the Force Unit Access bit.
 		 */
 		opf = REQ_OP_WRITE;
 		miter_dir = SG_MITER_TO_SG;
-		if (test_bit(QUEUE_FLAG_FUA, &q->queue_flags)) {
+		if (bdev_fua(ib_dev->ibd_bd)) {
 			if (cmd->se_cmd_flags & SCF_FUA)
 				opf |= REQ_FUA;
 			else if (!bdev_write_cache(ib_dev->ibd_bd))
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index b08f5dc31780d..62da020d02a11 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -265,8 +265,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
 		 * cache flushes on IO completion.
 		 */
 		if (!(iomap->flags & (IOMAP_F_SHARED|IOMAP_F_DIRTY)) &&
-		    (dio->flags & IOMAP_DIO_WRITE_FUA) &&
-		    blk_queue_fua(bdev_get_queue(iomap->bdev)))
+		    (dio->flags & IOMAP_DIO_WRITE_FUA) && bdev_fua(iomap->bdev))
 			use_fua = true;
 	}
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 807a49aa5a27a..075b16d4560e7 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -602,7 +602,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
 			     REQ_FAILFAST_DRIVER))
 #define blk_queue_quiesced(q)	test_bit(QUEUE_FLAG_QUIESCED, &(q)->queue_flags)
 #define blk_queue_pm_only(q)	atomic_read(&(q)->pm_only)
-#define blk_queue_fua(q)	test_bit(QUEUE_FLAG_FUA, &(q)->queue_flags)
 #define blk_queue_registered(q)	test_bit(QUEUE_FLAG_REGISTERED, &(q)->queue_flags)
 #define blk_queue_nowait(q)	test_bit(QUEUE_FLAG_NOWAIT, &(q)->queue_flags)
 
@@ -1336,6 +1335,11 @@ static inline bool bdev_write_cache(struct block_device *bdev)
 	return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
 }
 
+static inline bool bdev_fua(struct block_device *bdev)
+{
+	return test_bit(QUEUE_FLAG_FUA, &bdev_get_queue(bdev)->queue_flags);
+}
+
 static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305325.520391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6f-0003QP-EV; Fri, 15 Apr 2022 05:02:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305325.520391; Fri, 15 Apr 2022 05:02:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6f-0003QD-An; Fri, 15 Apr 2022 05:02:53 +0000
Received: by outflank-mailman (input) for mailman id 305325;
 Fri, 15 Apr 2022 05:02:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyR-0004TJ-QN
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:23 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d60f137-bc78-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 06:54:23 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDyB-008PbH-KB; Fri, 15 Apr 2022 04:54:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d60f137-bc78-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=6r328luNCDNaFOT33dRflffYOj2Ig+snh5CgwFTaxcw=; b=mNuFiFjSDLbldIX31eYOuSlRR9
	8563S/h8LrxYIHowjJfVJZ76RAtIHUbU8W+hFh4MWU8WMYfdB6LyJh2COdvD/iZqFmSUWNE+zj3n8
	TjDK1RADFF2jHuhjgFvsFPr2iNfo2ZxzGPd6/D7n8+r4+csvAbreOAgnv7mb2shTRUMZRApT5F90K
	NcXEn1pmSIjxsyXRt1Q5Fpafq+pdIcKs6RGb6uD0qSORONp8YiTBWhXw1jJiMd9DQ1XNtZR7AS8Rn
	LRWZ13064QQZdYqJpwxZzURW2pQw6Vjn+9nq/BjlV+QBzJ7qa6lBovEI7n8jqfejDLm+YrLORSOW6
	48XX9zTw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 21/27] block: move {bdev,queue_limit}_discard_alignment out of line
Date: Fri, 15 Apr 2022 06:52:52 +0200
Message-Id: <20220415045258.199825-22-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

No need to inline these fairly larger helpers.  Also fix the return value
to be unsigned, just like the field in struct queue_limits.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/blk-settings.c   | 35 +++++++++++++++++++++++++++++++++++
 include/linux/blkdev.h | 34 +---------------------------------
 2 files changed, 36 insertions(+), 33 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index 94410a13c0dee..fd83d674afd0a 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -478,6 +478,30 @@ static int queue_limit_alignment_offset(struct queue_limits *lim,
 	return (granularity + lim->alignment_offset - alignment) % granularity;
 }
 
+static unsigned int queue_limit_discard_alignment(struct queue_limits *lim,
+		sector_t sector)
+{
+	unsigned int alignment, granularity, offset;
+
+	if (!lim->max_discard_sectors)
+		return 0;
+
+	/* Why are these in bytes, not sectors? */
+	alignment = lim->discard_alignment >> SECTOR_SHIFT;
+	granularity = lim->discard_granularity >> SECTOR_SHIFT;
+	if (!granularity)
+		return 0;
+
+	/* Offset of the partition start in 'granularity' sectors */
+	offset = sector_div(sector, granularity);
+
+	/* And why do we do this modulus *again* in blkdev_issue_discard()? */
+	offset = (granularity + alignment - offset) % granularity;
+
+	/* Turn it back into bytes, gaah */
+	return offset << SECTOR_SHIFT;
+}
+
 static unsigned int blk_round_down_sectors(unsigned int sectors, unsigned int lbs)
 {
 	sectors = round_down(sectors, lbs >> SECTOR_SHIFT);
@@ -924,3 +948,14 @@ int bdev_alignment_offset(struct block_device *bdev)
 	return q->limits.alignment_offset;
 }
 EXPORT_SYMBOL_GPL(bdev_alignment_offset);
+
+unsigned int bdev_discard_alignment(struct block_device *bdev)
+{
+	struct request_queue *q = bdev_get_queue(bdev);
+
+	if (bdev_is_partition(bdev))
+		return queue_limit_discard_alignment(&q->limits,
+				bdev->bd_start_sect);
+	return q->limits.discard_alignment;
+}
+EXPORT_SYMBOL_GPL(bdev_discard_alignment);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 5a9b7aeda010b..34b1cfd067421 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1252,39 +1252,7 @@ bdev_zone_write_granularity(struct block_device *bdev)
 }
 
 int bdev_alignment_offset(struct block_device *bdev);
-
-static inline int queue_limit_discard_alignment(struct queue_limits *lim, sector_t sector)
-{
-	unsigned int alignment, granularity, offset;
-
-	if (!lim->max_discard_sectors)
-		return 0;
-
-	/* Why are these in bytes, not sectors? */
-	alignment = lim->discard_alignment >> SECTOR_SHIFT;
-	granularity = lim->discard_granularity >> SECTOR_SHIFT;
-	if (!granularity)
-		return 0;
-
-	/* Offset of the partition start in 'granularity' sectors */
-	offset = sector_div(sector, granularity);
-
-	/* And why do we do this modulus *again* in blkdev_issue_discard()? */
-	offset = (granularity + alignment - offset) % granularity;
-
-	/* Turn it back into bytes, gaah */
-	return offset << SECTOR_SHIFT;
-}
-
-static inline int bdev_discard_alignment(struct block_device *bdev)
-{
-	struct request_queue *q = bdev_get_queue(bdev);
-
-	if (bdev_is_partition(bdev))
-		return queue_limit_discard_alignment(&q->limits,
-				bdev->bd_start_sect);
-	return q->limits.discard_alignment;
-}
+unsigned int bdev_discard_alignment(struct block_device *bdev);
 
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:02:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:02:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305326.520402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6k-0004BO-QM; Fri, 15 Apr 2022 05:02:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305326.520402; Fri, 15 Apr 2022 05:02:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfE6k-0004Ay-Lq; Fri, 15 Apr 2022 05:02:58 +0000
Received: by outflank-mailman (input) for mailman id 305326;
 Fri, 15 Apr 2022 05:02:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfDyU-0004b8-U6
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 04:54:27 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1ef67c11-bc78-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 06:54:25 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nfDyG-008PgP-Ki; Fri, 15 Apr 2022 04:54:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ef67c11-bc78-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:
	To:From:Sender:Reply-To:Content-ID:Content-Description;
	bh=CzPLS+Gjxb/zoXdxVG3wb1X+zPEYuY3a71fFFzUQsIo=; b=PxTC6KnciQw0TSk9vI+K+AMZhB
	u9e+Rsg6/gEELi9/+U/v63dpyvw0hUtfHyPU16IZS1Eodmr5X+cu2FRmZWSzJpe+KZhaB8WPX73iy
	c6TK87vBkvMsokVjnVkLP6p7ua2/nu4iRHseV7k8Otwf/q7lwy6z7apWU+n+IP1iUvyEzbauM7lCp
	dkSj+aQUOppSdadfxst8W0LcrS+Mm/D+yrRNvKalP/J5Dfogq3zfiOEumpJYUHKnW8QvLxDGWbnNa
	GemfPfulsMzUnykcCOMbb7hTYIQIE4W/va/oe9dQyCoWo0AOAT691zcccidiP4Ae970vBl8VgjIPB
	+dTJ1dFw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com,
	linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com,
	nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org,
	ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?UTF-8?q?Christoph=20B=C3=B6hmwalder?= <christoph.boehmwalder@linbit.com>,
	Coly Li <colyli@suse.de>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH 23/27] block: add a bdev_max_discard_sectors helper
Date: Fri, 15 Apr 2022 06:52:54 +0200
Message-Id: <20220415045258.199825-24-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Add a helper to query the number of sectors support per each discard bio
based on the block device and use this helper to stop various places from
poking into the request_queue to see if discard is supported and if so how
much.  This mirrors what is done e.g. for write zeroes as well.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
Acked-by: Coly Li <colyli@suse.de> [bcache]
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
---
 drivers/block/drbd/drbd_nl.c        | 8 +++++---
 drivers/block/drbd/drbd_receiver.c  | 2 +-
 drivers/block/rnbd/rnbd-srv-dev.h   | 3 +--
 drivers/md/dm-io.c                  | 2 +-
 drivers/target/target_core_device.c | 7 +++----
 fs/f2fs/segment.c                   | 6 ++----
 include/linux/blkdev.h              | 5 +++++
 7 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 4d00986d6f588..a0a06e238e917 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1439,7 +1439,8 @@ static bool write_ordering_changed(struct disk_conf *a, struct disk_conf *b)
 static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *disk_conf,
 			       struct drbd_backing_dev *nbc)
 {
-	struct request_queue * const q = nbc->backing_bdev->bd_disk->queue;
+	struct block_device *bdev = nbc->backing_bdev;
+	struct request_queue *q = bdev->bd_disk->queue;
 
 	if (disk_conf->al_extents < DRBD_AL_EXTENTS_MIN)
 		disk_conf->al_extents = DRBD_AL_EXTENTS_MIN;
@@ -1455,6 +1456,7 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 
 	if (disk_conf->rs_discard_granularity) {
 		int orig_value = disk_conf->rs_discard_granularity;
+		sector_t discard_size = bdev_max_discard_sectors(bdev) << 9;
 		int remainder;
 
 		if (q->limits.discard_granularity > disk_conf->rs_discard_granularity)
@@ -1463,8 +1465,8 @@ static void sanitize_disk_conf(struct drbd_device *device, struct disk_conf *dis
 		remainder = disk_conf->rs_discard_granularity % q->limits.discard_granularity;
 		disk_conf->rs_discard_granularity += remainder;
 
-		if (disk_conf->rs_discard_granularity > q->limits.max_discard_sectors << 9)
-			disk_conf->rs_discard_granularity = q->limits.max_discard_sectors << 9;
+		if (disk_conf->rs_discard_granularity > discard_size)
+			disk_conf->rs_discard_granularity = discard_size;
 
 		if (disk_conf->rs_discard_granularity != orig_value)
 			drbd_info(device, "rs_discard_granularity changed to %d\n",
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 08da922f81d1d..0b4c7de463989 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1524,7 +1524,7 @@ int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, u
 	granularity = max(q->limits.discard_granularity >> 9, 1U);
 	alignment = (bdev_discard_alignment(bdev) >> 9) % granularity;
 
-	max_discard_sectors = min(q->limits.max_discard_sectors, (1U << 22));
+	max_discard_sectors = min(bdev_max_discard_sectors(bdev), (1U << 22));
 	max_discard_sectors -= max_discard_sectors % granularity;
 	if (unlikely(!max_discard_sectors))
 		goto zero_out;
diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index 2c3df02b5e8ec..f82fbb4bbda8e 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -52,8 +52,7 @@ static inline int rnbd_dev_get_max_discard_sects(const struct rnbd_dev *dev)
 	if (!blk_queue_discard(bdev_get_queue(dev->bdev)))
 		return 0;
 
-	return blk_queue_get_max_sectors(bdev_get_queue(dev->bdev),
-					 REQ_OP_DISCARD);
+	return bdev_max_discard_sectors(dev->bdev);
 }
 
 static inline int rnbd_dev_get_discard_granularity(const struct rnbd_dev *dev)
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
index 5762366333a27..e4b95eaeec8c7 100644
--- a/drivers/md/dm-io.c
+++ b/drivers/md/dm-io.c
@@ -311,7 +311,7 @@ static void do_region(int op, int op_flags, unsigned region,
 	 * Reject unsupported discard and write same requests.
 	 */
 	if (op == REQ_OP_DISCARD)
-		special_cmd_max_sectors = q->limits.max_discard_sectors;
+		special_cmd_max_sectors = bdev_max_discard_sectors(where->bdev);
 	else if (op == REQ_OP_WRITE_ZEROES)
 		special_cmd_max_sectors = q->limits.max_write_zeroes_sectors;
 	if ((op == REQ_OP_DISCARD || op == REQ_OP_WRITE_ZEROES) &&
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 16e775bcf4a7c..c3e25bac90d59 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -829,9 +829,8 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
 }
 
 /*
- * Check if the underlying struct block_device request_queue supports
- * the QUEUE_FLAG_DISCARD bit for UNMAP/WRITE_SAME in SCSI + TRIM
- * in ATA and we need to set TPE=1
+ * Check if the underlying struct block_device supports discard and if yes
+ * configure the UNMAP parameters.
  */
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 				       struct block_device *bdev)
@@ -843,7 +842,7 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
 		return false;
 
 	attrib->max_unmap_lba_count =
-		q->limits.max_discard_sectors >> (ilog2(block_size) - 9);
+		bdev_max_discard_sectors(bdev) >> (ilog2(block_size) - 9);
 	/*
 	 * Currently hardcoded to 1 in Linux/SCSI code..
 	 */
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 22dfeb9915290..71f09adbcba86 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1196,9 +1196,8 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
 						unsigned int *issued)
 {
 	struct block_device *bdev = dc->bdev;
-	struct request_queue *q = bdev_get_queue(bdev);
 	unsigned int max_discard_blocks =
-			SECTOR_TO_BLOCK(q->limits.max_discard_sectors);
+			SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
 	struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
 	struct list_head *wait_list = (dpolicy->type == DPOLICY_FSTRIM) ?
 					&(dcc->fstrim_list) : &(dcc->wait_list);
@@ -1375,9 +1374,8 @@ static void __update_discard_tree_range(struct f2fs_sb_info *sbi,
 	struct discard_cmd *dc;
 	struct discard_info di = {0};
 	struct rb_node **insert_p = NULL, *insert_parent = NULL;
-	struct request_queue *q = bdev_get_queue(bdev);
 	unsigned int max_discard_blocks =
-			SECTOR_TO_BLOCK(q->limits.max_discard_sectors);
+			SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
 	block_t end = lstart + len;
 
 	dc = (struct discard_cmd *)f2fs_lookup_rb_tree_ret(&dcc->root,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 34b1cfd067421..ce16247d3afab 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1254,6 +1254,11 @@ bdev_zone_write_granularity(struct block_device *bdev)
 int bdev_alignment_offset(struct block_device *bdev);
 unsigned int bdev_discard_alignment(struct block_device *bdev);
 
+static inline unsigned int bdev_max_discard_sectors(struct block_device *bdev)
+{
+	return bdev_get_queue(bdev)->limits.max_discard_sectors;
+}
+
 static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
 {
 	struct request_queue *q = bdev_get_queue(bdev);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:08:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:08:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305346.520413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfECB-0006DL-MH; Fri, 15 Apr 2022 05:08:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305346.520413; Fri, 15 Apr 2022 05:08:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfECB-0006DE-JP; Fri, 15 Apr 2022 05:08:35 +0000
Received: by outflank-mailman (input) for mailman id 305346;
 Fri, 15 Apr 2022 05:08:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0QNy=UZ=opensource.wdc.com=prvs=0972008b0=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1nfEC9-0006D8-TF
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:08:34 +0000
Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1633e9b5-bc7a-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 07:08:30 +0200 (CEST)
Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com)
 ([199.255.45.15])
 by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:08:28 +0800
Received: from uls-op-cesaip02.wdc.com ([10.248.3.37])
 by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Apr 2022 21:38:53 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Apr 2022 22:08:29 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kfkqw14Ytz1Rwrw
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 22:08:28 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id dF0E43yWNVGO for <xen-devel@lists.xenproject.org>;
 Thu, 14 Apr 2022 22:08:27 -0700 (PDT)
Received: from [10.225.163.9] (unknown [10.225.163.9])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kfkqn6sCZz1Rvlx;
 Thu, 14 Apr 2022 22:08:21 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1633e9b5-bc7a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1649999311; x=1681535311;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6js5zQuBI=;
  b=eH7fhRQ5Emf7mnVoxYT0vT1ynrsoefol7CjLKx/XFK1lQ81oC9FnkImk
   0NvSAhootdN/mtykKo57EDtbn7QC7BqNjq7L/dHxLEFE6ljGWqWQIm0i3
   BW5OG8PE8TF6wOemfDnO5HzDUZnLBPyHAYk2akTrdI//A9C6bbVD9C8CG
   6QbLAAhWuHhV9fk4K+f8Pjrbv15O0S56sdANUVtss7i9WT7pH9QsV4tH5
   kCwbUNkuqTLEkoJQ/bUoE233322a65AFm2rEvTmKcnFsaa+C4zrvzX79x
   SMjZjjguqq845PbqpRFsFxIU8MBB741m0wBEDKq9MFre5pFWtmZ0idIkm
   g==;
X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; 
   d="scan'208";a="196832497"
IronPort-SDR: r/U+vtci+X4HPe9ujWMwpfkUfbsbCcWqXKxHoayJa6xV+i8v5i2KJRe1VLg0TixUuTDlh8KxUp
 xtu7gnPqPhAHBOpyCftZaSWw6kYpv4UNlptcVlimSaiEGocv+DQsQVCE0rd+HVrSWwP+Ch6KLr
 fRto+V9OoRAsqeiUsp7ZcOOXRLV1l8koA7C0phXDh93tn7qhJtYJ/BN2HJ/00GDqFatPr1iIwb
 UMOseDrWaxa5Dt0ktXrx4ay9KUVlHM+UiXIQgZgW3pIxDTHMnpEYqWO6/+Iviw7p3MNBB20myA
 a68RRPf1uCn8s+L/9Ibci2A6
IronPort-SDR: iL0mm+wiCaUehNzQTIAc5nHSO2tqDZxn1PKkGf9DXqWxstPp2kNwcB7Deo9AkpRy3RSw4yW4PY
 BOD6EeF/DGebidA6uvD5DpM7isv4WzqSJ8w8F9764sNrbz/HjjFv4964ZZ/GBpOZFrzNUPAeXV
 0rfe6BnNHdU2m8txIDi1Le0heuK4ojGJkkzlLD/NADRr8hp81l8bm4CQ8KZMF27OimFMxuEaOP
 QQOp5d2WGJE3M4c1zAU2bMhrbTxmYZeczUt1U7NjlOtuWa0rx2bl6W91DnlIbxAxGCLEP1xOJ+
 veA=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1649999307; x=1652591308; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6
	js5zQuBI=; b=PnLGxxEK3pLyssa8yxGNdC4XjW2wbor1ccVbtGFYLuF6J3cLtHd
	AbpMYH7aDhgG/pTbCzP2Jz5UXeITA2uAAyiR/Fy6attbFAobIm77MiZ1d9JwxmK8
	shfFnnjg3a2RytIj37jVhbyrF9O4v+hLyhCzQz2dnHJygtOnBuY0SiH0emrVEC5V
	37Q51RwNl9CEkvSI7J63mNoy2HlvXkxHid/Xl33/pVaD25Hfmrh/cyibuFKv7AtS
	/tmUO1ElBPCNJo60JkfPy33eMUDO0eae+UlOxVUV5CwFdxfl0b0VIs1osnbs2TmY
	qPuOzeMMi/kXJvdALFOBXWDwdlihcT0EYFQ==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <d7a39cfc-9b28-f0d6-bf62-4351c55daec2@opensource.wdc.com>
Date: Fri, 15 Apr 2022 14:08:20 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 27/27] direct-io: remove random prefetches
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 nbd@other.debian.org, ceph-devel@vger.kernel.org,
 virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
 linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
 linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
 linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
 jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org,
 ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-28-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220415045258.199825-28-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/15/22 13:52, Christoph Hellwig wrote:
> Randomly poking into block device internals for manual prefetches isn't
> exactly a very maintainable thing to do.  And none of the performance
> criticil direct I/O implementations still use this library function

s/criticil/critical

> anyway, so just drop it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good to me.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>


-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:09:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:09:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305350.520424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEDU-0006lo-18; Fri, 15 Apr 2022 05:09:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305350.520424; Fri, 15 Apr 2022 05:09:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEDT-0006ld-UU; Fri, 15 Apr 2022 05:09:55 +0000
Received: by outflank-mailman (input) for mailman id 305350;
 Fri, 15 Apr 2022 05:09:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0QNy=UZ=opensource.wdc.com=prvs=0972008b0=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1nfEDS-0006lW-S8
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:09:54 +0000
Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46bbfed0-bc7a-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:09:51 +0200 (CEST)
Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com)
 ([199.255.45.14])
 by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:09:50 +0800
Received: from uls-op-cesaip02.wdc.com ([10.248.3.37])
 by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Apr 2022 21:41:01 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Apr 2022 22:09:50 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KfksT1jjKz1SVp2
 for <xen-devel@lists.xenproject.org>; Thu, 14 Apr 2022 22:09:49 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id 6zELggWG5jd9 for <xen-devel@lists.xenproject.org>;
 Thu, 14 Apr 2022 22:09:48 -0700 (PDT)
Received: from [10.225.163.9] (unknown [10.225.163.9])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KfksM3c9Fz1Rvlx;
 Thu, 14 Apr 2022 22:09:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46bbfed0-bc7a-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1649999392; x=1681535392;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=wC6/PVYH+J9es8aT7sK5ZaGwsGnDQHOFu7y4PW6r0NI=;
  b=K2XZiA01CH8m6rHS0Bde2s+ZW1bXpFwZqfU+BqH5yks1hA7r0Rphkp+b
   glrMSU+iFhgjpEBrsGq5QXjaSJCjToXB/EIg/A2K0R6UydQXVTgUecQHx
   2Yt+39Y310Oxav9rvr1jlfRMi/AhfUCV5OejO8UZHUV/q/REuedRke8DC
   TIrTHnxwuGfe14LgPAr9E0LUbnEinKujtqKcHHUGRE96fNJkECeu9A0hS
   dXji0yQ0bexUFATaaCLLWNt1n7+yBN2l50cT0HH1OPWu8Q8NP4LgQgvL5
   GEsiNM5zIA4kmSHrsZHx9XAnYB/jx2vvGJgdobNLnLOaVhSIdyCotZmPr
   A==;
X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; 
   d="scan'208";a="198866636"
IronPort-SDR: hBovH/mIEnhPrmnNhlTbaFYy8pz3ohM1g/F95gCJawDkwTkjQ6d+X3ELKc1MBq8aNaOoM1YPG5
 ukA6G8hAi8RJ11xcPYPkUoUWjjwLl/Tm2g7naU/HdsTGgoCDh6l3PM+Gz6ncnK2vGah4UE7Yz/
 i5UCzdCMl/s8dbjWq29MSc2ZM7cxOUVG6ywRNN9lTyaIptkWfY+BUMqTi+cuZbMfFeg8VRG1xh
 GxfFda/+hKSjQ5+VvwH3BFq4BIFkOGN0FJALBGC7apj7hKrtwejoar8DxkiV4XOU1DdTuIvuUx
 BqiyqpAQwrL+tcdl0NzcR2R+
IronPort-SDR: bps6QUVXgZkdrbGTYIIWoVFCL2b0NA+nkiYCHjzvqxxEQtsKowrRSfXwbIdsXFT9t0KutRSR9A
 MoXMGHcvTqxiWw7Mdk8WAkVEruzTxr6zr04BZVQNL5F2P5ysCm3X6WdB4H5ujGb2WcOeoG6wbD
 UjBM1JD7+qheb+ozCDWW8S6YfETox5WrmHONQXlX1mMi0O6fMN1OCQHeN+gZXK8CQiFl/IwJ9U
 QjIdJryOQzX0Vcln2j59Yc6SFk3+Hp2ED1PhXfMPKc2/RApVFRC+XAnTfBe85TGK9A2aOrn03g
 v/8=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1649999388; x=1652591389; bh=wC6/PVYH+J9es8aT7sK5ZaGwsGnDQHOFu7y
	4PW6r0NI=; b=D8kdC3rz3pjqnugRL+G3XHXL6Ng78iZSZCza4fEMQpTN/xdgY6D
	ndgbPRv8Ii6RTniwYP01qFwFHzH91r1LoAWx6xGwWEN+Qsp3Ex2YpjoRKlcblFjc
	7yjQF4oBeK9egOucgCIrr2m+tKTIlJA0mcKIvKIgWCVnz5iEJtEs0vxeju2wZT96
	jtBkpdSzig+EY3uiGMCOqAfDYf4ob5UMdfn63Y/7o6floZGBngeQCZ8K+n+vY3d5
	lYsSP/0Lz/G5amM7P4+yygELabSZDZHGZG/YfdQpCLMrO4FBxFoQbF9pdD3HvN17
	o1OWdE4/X82Vq8Fyie48I/oIcM5G/NLyIZA==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <62ebc311-e5ef-cea5-5236-0c83d1a3eb64@opensource.wdc.com>
Date: Fri, 15 Apr 2022 14:09:42 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
 linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
 nbd@other.debian.org, ceph-devel@vger.kernel.org,
 virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
 linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
 linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
 linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
 jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org,
 ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-11-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220415045258.199825-11-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/15/22 13:52, Christoph Hellwig wrote:
> Use the bdev based helper instead of poking into the queue.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  mm/swapfile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 63c61f8b26118..4c7537162af5e 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -2761,7 +2761,7 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
>  		 * write only restriction.  Hence zoned block devices are not
>  		 * suitable for swapping.  Disallow them here.
>  		 */
> -		if (blk_queue_is_zoned(p->bdev->bd_disk->queue))
> +		if (bdev_is_zoned(p->bdev))
>  			return -EINVAL;
>  		p->flags |= SWP_BLKDEV;
>  	} else if (S_ISREG(inode->i_mode)) {

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:36:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:36:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305437.520435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEd2-0001x7-4L; Fri, 15 Apr 2022 05:36:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305437.520435; Fri, 15 Apr 2022 05:36:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEd2-0001x0-1D; Fri, 15 Apr 2022 05:36:20 +0000
Received: by outflank-mailman (input) for mailman id 305437;
 Fri, 15 Apr 2022 05:36:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEcz-0001wu-OT
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:36:17 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2061a.outbound.protection.outlook.com
 [2a01:111:f400:7e88::61a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f722399e-bc7d-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:36:15 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:36:12 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:36:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f722399e-bc7d-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WWif4DDX+SDI4boNRQQJAfomnKYarbf5KgueLDXVi62Jn8qiem/iyYZVVIwzZBAY2FO/hUbE0/k8am+DV9NzDmK/62jv7EbQQ2xHJgZ3podJRvVcsfcthIacamMjh0+2Bys833/pVttFX6HMGCHft90NGIZC2OhBpUvOaKbEfsYIP5SuB9SFmvjX/HkDIKzPwcPJOra6bQHsHIvQYdrmzC4JcOkPp2n9L9Kzd3KW7KMgR0+4F83EsX+F5/pqcemkBoGnAJ8G4IYx8XmjDLyL/0QpisOV/dNNER9VtKUobx1HbGsLt6kX0QeeVZZ/l71OogHk3KKxynVBjLNz+dN4cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4IuTuVb/KyS1ZV0aqxRI/Yu1yD+ABTgelallVeHsTxk=;
 b=mzxXlASfNGcmJR0mr+mPSsFKifSuchQIwkCtoqenqILPlPwfVsfyJoWvV2vj3RoJPtSRpPkt9K83Ahukg5kI2JoN/Z9/8nz4/nDUQk0ZEKta6UWDAQgvMmbobzSBoamWw8jXjAwtVH/D3Uwv5jjjQNbLRI+nALtZxB0tIzvDIJ7Sx4iP+SD9GyKVI/tLMSy3gphyizEH17iVU+/oXXTAraPpBUOKqzboZDTvTbrp+3YcOcXVg0CVR2lmkVmRsXOCuXcMhwVkQgPndF7agaCW2nQRrDSmp7Sqv9tNd1qqxKW5XIEA3+6UqeV/8kYLZ70SgjJzqvpuOL5U8zGdf8fFHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4IuTuVb/KyS1ZV0aqxRI/Yu1yD+ABTgelallVeHsTxk=;
 b=lx/vsdq1wuVjGXFb0RtlS8aNQVUdAwD32nu7CMFt+qyOZp4fU3BYd3nAfXUFYKskrRJfQL7Sgji53ElZm5sqH6S/Ro6ASYp2RNr5+WHyhQPl3V6ohDw/8K2T39LgGqYhL4BcILkZlIF3ghKn0878TKS0ZcvZmL9PLTjfMTSIQNzECGhofyqMeQ+XUOAPN0Q3qU8PzNiUwWiOS3ftFL8yvZ1G2R/FHpEDy1mrydwcAu2LEF+6QmWcTz3dW09SMVJheytf97BROBR4O2mgsLrGBQYZ8LvNMcZhgPtxqrDaz2MjJwXa5Np6BaGNWj9+2NWfTymrAIM8L/TicDPywpv7Gg==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 01/27] target: remove an incorrect unmap zeroes data
 deduction
Thread-Topic: [PATCH 01/27] target: remove an incorrect unmap zeroes data
 deduction
Thread-Index: AQHYUITCWfO5Vbexo02RhnP7B3Qt7KzwdGUA
Date: Fri, 15 Apr 2022 05:36:12 +0000
Message-ID: <673afa25-cf3f-616c-6bcd-16de35b307b2@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-2-hch@lst.de>
In-Reply-To: <20220415045258.199825-2-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0c41c8b1-f98c-4a0c-d430-08da1ea1da48
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB1815025F04E67817416EF431A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 FFcKzlLusYcihPuQmtr3t8KbNF6ZULdsUk3VDGoPU5Bzoim7x014V7OQAcQDACuimx2k4yREtr5B6uvJ2a8+1Uhd2xpAsmFn/qLBWU+QmZXIapLZyFQRTQOeeiEfFoms7bv0O8TA2h1Sa8MwWLeGYXuS1/E3RvLIoTNRVuO9UzRcZWyZWSQFxTMOL12Qns3v9NVdUfPovTVZiFDfTwJgyfqWPItknrB6PQlFJeMVHgxGslTmq350gxs5qs+xG+OVxS/DQedOy3ltIFpHUiPwk72NY7m7PE0ZlBBrkJb3u2+zh2ymtgCOaG+bowFhrlWJOiQ1OwDOMlmF5ns3rKS8XvTN/YJYaWqL8TEOp2RpLN5OL+mrCAx8hNrBZ0paAaO92k0nRjvEM6m4d0Euaf1ZzgMt2pH+HMEHp2QtyXP9V5w9mNVIo/cpWEyM9aGG7CEQ6NufsCVtLrmceiZK+BBSOVVx6Kuriw3HemolNu69pRP3r+/ON7gJqNR9OqkQgD2pVbeubVClHb9mztUeZpd652FKmn3k9GUpqg5Fe9lm5bEDvx0Aoq1f8yqjfX3ghiHmqp6YVLYwCamze5SKJVglv1TzAO9lFIT8BZ8sXV5+npwVYd84V645TVbI7wxZVK4gtOuLWMNwXfLbt49QpuuJyb/uGDLz+jrZrlKAeP6Fj4tVN/dOdqRK/YGL4BDamm/r2o2eVfWnzC0AYh4B4aDJjdm8z4b0LqHcyk5IYJaMM56QV7Z2E1G1LDpAAKpMl5MZM530+NFxKIwbYkKX2GXdiQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(76116006)(6486002)(54906003)(110136005)(66476007)(36756003)(66946007)(38100700002)(31696002)(316002)(64756008)(66446008)(122000001)(8676002)(83380400001)(4326008)(66556008)(86362001)(7416002)(91956017)(7406005)(5660300002)(8936002)(2906002)(53546011)(6506007)(186003)(31686004)(2616005)(38070700005)(508600001)(4744005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VW9NMHpPcWJ5Mm9hcGpGT1lSZXc4SlQ0Y1FhTUpRNUYrZjArajhyN1lGNUk3?=
 =?utf-8?B?SHM3OU5IZVNYNktNNHdzUzBGNnJjb3RVRnhzR3czakQrdWxtYlAwNTNOcUk2?=
 =?utf-8?B?c3Q1YVpZK1FoUjZ5andsZnpRbmFZUUNhb2gwek1MQkFWNld1ZFloQWRldzRw?=
 =?utf-8?B?T082RjhBTVluRDNORENwQW5lTHFOUmlNNHFhbm1QWXJySi8ydER1dFZYS0FT?=
 =?utf-8?B?YzJla20zODFTQzh0cytmNGU2eEpLTVp1YXlTYzZKUzFjSjFuYjErYWRMTHJD?=
 =?utf-8?B?cUpRa2tWaG9zYkN2QUI0dWppcnlXS29mWDd2ZUVPNjlLdmUwM0V6cUxlK2x1?=
 =?utf-8?B?ajZwRlJEWi9QQ0YvQXR6MUtRTXVoRzFMK3grcmdLSTk4WWZFVXZDbEdYZkZH?=
 =?utf-8?B?YmZuTHpuNEdCeXczMjlza1ZHS1NveU1tSVR5MkhwUUREbTRRMXdVT0FWWlFv?=
 =?utf-8?B?V29DSDdlUXZRdGZObHNMOVk1d2puWkhOWFFpY0FBUHVZTzJkNU5Wd01xL05o?=
 =?utf-8?B?SlN3a2pURnV4ZnZWRVRmVUcvU2hrK3h5ZnE2aFN2V3lRMnBJODlLaTFzWGh1?=
 =?utf-8?B?cUNCWGppN2hUWVRKTy9ManRxOGdtSFRxclFPSFh6aVh6ZnVKRURJQm9VVm9l?=
 =?utf-8?B?VnJtRWYrYkFUOTBoTmZEWXFGSHIzcVdyWk84NEZvVUNxTGdYbEllbEF5Nlpj?=
 =?utf-8?B?S2pONlQ2RnFIcE4xZDdpQkFtZmt0dUdEaWhKUWVvKzY5YmRYOXlrb3B5ZGhJ?=
 =?utf-8?B?VVpJSkZ2bWd3OXdubDdYZ0I3K25sVU4yOWQwMXFYS0ZzMjJONWtCaFpGYmRV?=
 =?utf-8?B?MThGc0Z1NVI3U2FvakFEcHplWVRqK3R4cXFLbyttR3ZtQW5zQk5wZndsc3FY?=
 =?utf-8?B?WE9PdUpwL0w4WjdMSURBNExMV1U5NUY4SjRUS0dwTXQ5TlBOT3RIUUVrTm1l?=
 =?utf-8?B?eC94djVmVHRIc1hBRTcvcUoreGlQMFpHNUVTbkR4UVRCTDQ4OFZ0Nm80L2Yy?=
 =?utf-8?B?WnRYREczdnpzRkJiK1hnQmg0cTFXUzk0L2o4dFppY0gyMElscDVtL2dNZTdu?=
 =?utf-8?B?QkUwSFNuU1VBMXhLNXNTTW82WVF0dmtZcm1BYm1iSjc4TFl2OU1sRkxTN3VM?=
 =?utf-8?B?alVrL1ZZOUF0Mm05alNiNjhKYVNZZW15T1hwTkVKWXZVcTJSUDllcFFaY29T?=
 =?utf-8?B?YkppVUFRU09lWTZWeTV4RUVDelJRbnpLbzBzbWl3NzVsenJNNGVSeDZVbE1m?=
 =?utf-8?B?N2o2MGdpNTlQOWNEazFWajFNQTVvUjlZaS9BbUZoMFJWL2JCR0pIbzJFandM?=
 =?utf-8?B?eG1WdkdKamY1ZlJwZlp2aFplbm9DeGpsY3dudWE3OUhXSm1rQ2pUcy9YcmV0?=
 =?utf-8?B?dzVUVlZNYkp3d2FtanhWcmZocHlLRW5BZ1BTMU1yTDVaWVFPb0pCL3Z6T2JD?=
 =?utf-8?B?eEx5ZE5nNVNpQ016TGI2TkYvV3VPNlBNMFFndmJ1OXI5REQ3ZE9DNVN0T1R5?=
 =?utf-8?B?cDl5WjdJNWpyaXV4cEFyUVpNTkZ5RU9hZC8rNnNVQWsyeWkvaU8vSkhOSTlQ?=
 =?utf-8?B?ajlnZDd5NHhlbUFWbm9WZ01lUGxDTDY3dTFLc3hob2locXpxWVBLYVpNNEhB?=
 =?utf-8?B?MExOaXBCU2xOeGxRMkdnU2s1ZU5vVlFQREpaRHJKVHh6M3dCdGozTUR5WTFB?=
 =?utf-8?B?UUxoSTlNM2tneVkwODlVSWNQVGpOMmpURStJVmVxYmxTUTloSjVaWUZydTlW?=
 =?utf-8?B?L0lsYS9TeVJHVExDdXpMa2tHOG5HZzJmNmxVYXMvZzlVakd1eTYveVdraC9N?=
 =?utf-8?B?UU9rSTl4VzI0OEJMUDRQS3VrY0VUSGNlbk1wcnA2VVNoc3RxNmkwSCt6WWk0?=
 =?utf-8?B?dEwrbUhnTzUvaG12YVp6bzRrMmJQWStmQ3oyTzNUYmlqbjU3dkdPZnlDWEh4?=
 =?utf-8?B?Z05maEErSG1uSzBLNTM1dEZCTmVUVVJNVUVxalVhRFFtTEdGUUdyS3ZvcXI4?=
 =?utf-8?B?OEs1VXNtWTRTd01uTzVVYXpLaU1JcU5ETTB4ZXpnZitEMDkzVTRqOXdPVjlm?=
 =?utf-8?B?YVZlTS9pWHVJV0ZzR1ZONzVrMFVlWHhOa1hvc21YSGFCZDRxSVcxeWVXSmdB?=
 =?utf-8?B?YkRyNHpEMEREdUhXWkh2Vk5pUmFoaXMrSXpqVGlYVzljMWcvZHRObnpDRjJo?=
 =?utf-8?B?cDd3YVdKMWZlNWtGYWVleFBGOW8xME9QTTJ2VzBzWGNCT013enJHOUh2dE83?=
 =?utf-8?B?WDBWWjlaUjRXU2h6TExEL1djWDdFVW1kSm14UmhLQ0VwNW1mWWNlNmd2Y0h0?=
 =?utf-8?B?d1lPQ1k5Z09rYkZ2QjNBMC9TSk0zaUExcTE2TExpdGM3Wm4vSE1oUXM5Z1dn?=
 =?utf-8?Q?3cEYgCOzwmgBAk9I=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E802A778DDA3DB47923030D024586109@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c41c8b1-f98c-4a0c-d430-08da1ea1da48
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:36:12.6026
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: y2FweSrSmTAGEteeg0PCeGV7la14HH5hz8rms25Vojja8JCsoAbp7ZNFYuPk0ZPEHv+6sDcSZkAYz2to/Dl6Vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEZvciBibG9jayBk
ZXZpY2VzLCB0aGUgU0NTSSB0YXJnZXQgZHJpdmVycyBpbXBsZW1lbnRzIFVOTUFQIGFzIGNhbGxz
IHRvDQo+IGJsa2Rldl9pc3N1ZV9kaXNjYXJkLCB3aGljaCBkb2VzIG5vdCBndWFyYW50ZWUgemVy
b2luZyBqdXN0IGJlY2F1c2UNCj4gV3JpdGUgWmVyb2VzIGlzIHN1cHBvcnRlZC4NCj4gDQo+IE5v
dGUgdGhhdCB0aGlzIGRvZXMgbm90IGFmZmVjdCB0aGUgZmlsZSBiYWNrZWQgcGF0aCB3aGljaCB1
c2VzDQo+IGZhbGxvY2F0ZSB0byBwdW5jaCBob2xlcy4NCj4gDQo+IEZpeGVzOiAyMjM3NDk4ZjBi
NWMgKCJ0YXJnZXQvaWJsb2NrOiBDb252ZXJ0IFdSSVRFX1NBTUUgdG8gYmxrZGV2X2lzc3VlX3pl
cm9vdXQiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4N
Cj4gUmV2aWV3ZWQtYnk6IE1hcnRpbiBLLiBQZXRlcnNlbiA8bWFydGluLnBldGVyc2VuQG9yYWNs
ZS5jb20+DQoNCk5vdCBhIGdvb2QgYXNzdW1wdGlvbiB0byBoYXZlIGZvciBzdXJlLg0KDQpMb29r
cyBnb29kLg0KDQpSZXZpZXdlZC1ieTogQ2hhaXRhbnlhIEt1bGthcm5pIDxrY2hAbnZpZGlhLmNv
bT4NCg0KLWNrDQoNCg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:38:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:38:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305442.520446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEeq-0002Wa-Ha; Fri, 15 Apr 2022 05:38:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305442.520446; Fri, 15 Apr 2022 05:38:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEeq-0002WT-Du; Fri, 15 Apr 2022 05:38:12 +0000
Received: by outflank-mailman (input) for mailman id 305442;
 Fri, 15 Apr 2022 05:38:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEep-0002WL-BZ
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:38:11 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2060f.outbound.protection.outlook.com
 [2a01:111:f400:7e88::60f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b35310d-bc7e-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:38:10 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:38:03 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:38:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b35310d-bc7e-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G8hmcOadGSG92VaohQPg0VH/yBKeIFmAYk/Zr+21PC/zsBiQhRhbyPR0a4e2n3tkglp7kUW0hNWQ5z4NXi/iqJR03CLELttUibu/ydMNS7UZt5Gyhq00SLbC1MuB77PcmULeT83qXkBM/zvrvG747lPjJ1LEB4BxqVFNbIG/mA6RkC83PorDL/lMgcrecMQDhG4gSPtM45g5+9gp8E7vmcTq2Vt9Q1fJ4ELBD7OvidWdb4t2CCG8etTi8Cirx+26ELc0m54BTc9q/FM5iOEep7cFcHlVu32XDrkHIqoiEWZDwBWln2TDIX58CXAwvzQe9WoTh8RL2aJPE+IzQrcCGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+74sie7PTwpCtd24VFJpkgQyUHaJLy3D4yyRUD7Tn80=;
 b=lpe0WgIMb0UqK/OWlmTFAGEC8X0g9wNEJoAYOOhrab+4bOTMbbAP/8rySuZlqpgPjW0ox7R/Oj1VSZ3eS7pWDluv4BOQrTYTCDM2Jg9ZT9na5yuhVKZcfEAY8FWT9QhecI28cOEQOk726CMDnnenyon413rd6T8h0e9Ul/yyBIkF+uyDQyIezRlfhUGu+gh7IxEo25pDPiI4Y0Q3iQBQXHBgPOjFG2S1cGW56LVOvkC+WcJ1RIpRtrh5+XKZuw+HkQp07nCZ/GJwFDtzMZUMwAjpSNCMUpZlTMT/3HXrEfwh1n0o2AZPdlM6n1KulfAnWqfe2lFLotPZ0W2mT5S0fw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+74sie7PTwpCtd24VFJpkgQyUHaJLy3D4yyRUD7Tn80=;
 b=aX918WIKGvRh0tesQxl97U66xWhTmwqBIixj+qqe6353AASra41tNuWIdyvJ0vv9dQuICMgse/4m+4sEFOAgwqDdqDLbtuTg+2eqdw9cqypNegR5AKwfzSGQ1esrzo/wqwj0T/SF/5Xq3ZUMfv86VEhgFcm/d8HjvpV90yTcuZmGT9BoDQ2ZNEdaC6P5vnZpS5LndgKkG0xoHdwdJVgX4J23Vtg2C2BgtRzrm98UHRiTB9oXIc1fL1jKIbOl3x2UWtOsza1IaNuPOy5hW3xwiDsoHLYUJpQZUZi7kcn4K/DoR+forZO4IfXT1zGUDGyKDUdHsugwnYbNEZsknTQS8g==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 02/27] target: pass a block_device to
 target_configure_unmap_from_queue
Thread-Topic: [PATCH 02/27] target: pass a block_device to
 target_configure_unmap_from_queue
Thread-Index: AQHYUITD/OVlel93skeY5tfftzV30KzwdOmA
Date: Fri, 15 Apr 2022 05:38:03 +0000
Message-ID: <c440aaea-6617-c26d-e2a1-2107bcc4559e@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-3-hch@lst.de>
In-Reply-To: <20220415045258.199825-3-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 850d74d7-2e5d-4ff4-4b90-08da1ea21c8b
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB1815493E0F03732F323B43A3A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 A3hCZAZY5NLfauwUgZEygmJFzH+z9vEj9n5IHzXfUjAwOC7aY1NJ+fWONw+VhzISBKRT2kQd6RuEDYrytmrA3RqmZ96M0fmdbvUv8BbTmduTkUmofW7negpKepAE+Ih/ChrWBUxejTUY7+Qxkoyc8lMrls4PSOllylTxV8/EYp8cnkL+QF8VgBdTSBQPWrJHiK0TUCOgxHTAGD95g8RCpPY8jILgIqicd+ajjlOREo1PkeOgtowBQZnohbI6RXFPxlcgKTqU3oyQhXr5nyI5WOeIPv/cq7hPAQyBs+rVkm/ayUPqwbRYkOAgXVHW1QUw23XpdxjhRA1mSgUVHc7MaVoFQqcjRUsbwpj15Dkr1h2QgnQXjZKbXkOQuYoS+cS/8F95ekll0/wBcUiqPz9Md9H1XyNxYBurzLUekup30HLbT9b/g6By62MakJsyZiuygt1HzGUg8bSDPoBhGLvlLwfrW6FFaMWiLPE7RWp62HQCN5NfP/QbUc1S/bmqVlHvoyOgf6f4XlPvy7F4tIVTKpAMXDBLhnMzdlsD3WmsPeZdWh2LJHFu0VZ7UT7gn2YECdBx1lO+vvqaCWjJxOcDVuDneKW8hNzii48GgqXOMzFGPo6dGWRrWvWqJy6Dr81PttER/FV0TGZL8HUDcGuuDtTcJru/5nGIBepAzvzrK67Zas8joPvndBwvywdfGi5I3BWR4fYJ57JUn8CxkzVbR9eXvXjkRtiRSQykI+8KpStctDb6EcjAJuRnFF320MhFDh7wNe36Vbk8VoHcUI7sZQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(83380400001)(86362001)(31686004)(508600001)(4744005)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dERYQXI3VmVSUVIyZlJVbGZsRHRpczdjTVpJZ1ZwbmNWRFQrQUsyOVRCYngy?=
 =?utf-8?B?akpSUFEvSXhtQ0k2Q3VRaHNZN0hQRVRESmJ5alFPVC93VmpZNVVaZFBxd1pJ?=
 =?utf-8?B?R1VPRTBleHNmb0U3S2dRYkdZQkhtcDQ2bGRiTDdpd2ZxbGdtTDNYN3doZmtm?=
 =?utf-8?B?UEZsTkVXSGM5dGVXVVVWN1Q5TDhPZy9mMms4dzVVcDFMNFAwbDRSeTJMeTFj?=
 =?utf-8?B?MDd6SnJ2cDFnSHFPdks1dEJ5MzFmbGtSRkNQMWJ1djl3SnY0TjYwd1pudWkx?=
 =?utf-8?B?blFQT2gyd3pzLzM3YWZwOXJ2bmFlYjBIY1ozUUNQVEU4NWV6bkZyenh6aitE?=
 =?utf-8?B?dDFNRlRpemdDeUxHWlY4QUptYVg5R25PaWJVWUM2a2lJSnd1VkFBZFBDRWJl?=
 =?utf-8?B?NjdXK3ppb1ZUNmo3bk1yNFJtMjRIa3FFQUo2djZVQXNod2paUzUyTm5IZExM?=
 =?utf-8?B?bXUzV1VKNFA0MjFhcnNXNGN0NnJ5cTQ2VWczeEFZUmdGdWwyd0FpaUFGSDlR?=
 =?utf-8?B?UHdCWnJUaUdzcmxFUmtFMzZjbGNyTGJ4YmlqZDRSczNFUXFWOWxnOXJEdXdw?=
 =?utf-8?B?UGs5cE5DUWFSWGtkQWovR0ZXQWR0cFNNRi9VYW10TU9OSTZVN1B1YkhlNUxv?=
 =?utf-8?B?N0Q5akZJSDVTRW9lQW1kbkdIeXpnaWF2eGxYVUFLVkk0dm1YNmFqaEVXa0Yy?=
 =?utf-8?B?TkR0Q1JER0pxd2VwWDVrWFp3SEowbnRORFZpTEhyKy9KSmlWMlI0OEU5V3lv?=
 =?utf-8?B?S2dCUzBPOGkzSlJaeTEzcWFObmw1Y240M3AvejJ6QUJHNGNNaU5hUTkzN3h4?=
 =?utf-8?B?SlRWYkZ2VWZhSzcxT1ZDbnpYWHRLY0JtZktCdnNRb2owQXN6MW81QkdRNjZj?=
 =?utf-8?B?TDc3WDBWR3ZnYmhXYWxEczNicVBGZ2J5OFRoMmd6SVA5N2xIdHFsSmo3dlVK?=
 =?utf-8?B?YXBBckwzZmFQZ2Fjckg2bnVkcEZWSXpTbW5vNXZWbVdVYWZHbVJvNkg0UGdP?=
 =?utf-8?B?blhndFNrQ2wrZ3lFckdicDJhNUJlTE9SeGM1R1BXeGY0ZHl0bXRDOXE5MGZx?=
 =?utf-8?B?ekNZYnYvNUxuYVlMNlNJWSs4RTRpRWxRaGRlKzBEcnZ1dnl2cVNxUXhjcnh6?=
 =?utf-8?B?LzB3bjlSMHVpYlFrZ05JTTl5RkJVUm5lcEp1cGtLMVJadldESmI2bEo0KzFB?=
 =?utf-8?B?cS9URm5IbkdWUzZhZlRYajFLNWlEc051WE1HT2xOa0dRTEJYZitGbm1zbFRQ?=
 =?utf-8?B?WHRPdjhVbUFVVDJxVTNCRDFXbnZRclYzR1E5T3VzTEdGWEgxQWV1T1I0Ritj?=
 =?utf-8?B?VWp1Zy9IUlhaR3BnbDJpckZDTll1d2ZrOXdKVmdqaDNoUTZxdk1sL2o1elNj?=
 =?utf-8?B?OFVBM1NoTzE4bmFzbnhudHFhYit6WGF3Sm1tRVpCWDlDM283YzI2YWs2NHZD?=
 =?utf-8?B?UUJzSi9UVEdza1BEUEhhdXRmbis5b2Ivclc5WndvVFVCYVA1RkZ6cVRINUo3?=
 =?utf-8?B?a0FrcEMwM0c3ZUI3c2F5TzdWV1kvdXNNSFVzbkw0TFV4L28vMzF0RUprKy8x?=
 =?utf-8?B?YVc3dlc2V2tHOVFFMVdZQkpSTlArU3h5NS9XMGlVSzFGRUFUK0ZFb3dEbktS?=
 =?utf-8?B?Y3hGNHdHTUtrV0tHN1Z2aHBaUjZwWndrRElQSS9xWklnZlcrM1k2THNDR0t6?=
 =?utf-8?B?NFA2Q1Y5U2V4OE5yeVdYOHpkbCtOK0dQOXlGVTROOUVaZ1Z6eEo2N2hlWmhI?=
 =?utf-8?B?bGF2ejF0c3AxaFNqK09oajVFbVNIbEhUMmJuNDRLb3dsNWhNdEZQVlNnejkw?=
 =?utf-8?B?NHNnc3dESWF2RUxJVnNYSndJcmlmTEk3eDdHYjBnSTFKK0t0K2V1K3ZHZmxL?=
 =?utf-8?B?c09jeGUwNE5NRnRFb1AzQy9RQkx3OFNXdU40aCs2eG03bkl4OTROR3p5VWdh?=
 =?utf-8?B?VXlSQlhQZFkwdDRqUFdFQ3AyTUFlZjB1T2xDY0JxaWJUeXBmcnlTL0FDNjZh?=
 =?utf-8?B?MGU0eUVJMHhveGZiSVRHcEdYSHZzVmtpMmRTZVBxamIwYW04blI4N3MyN08w?=
 =?utf-8?B?bEVXVllvcjUxTFEyVE9RQU9XdnVqbVRJRnFpZFFidzB2Q0Jjakszbi9GRVBT?=
 =?utf-8?B?ejh5VU00dXV6bWdjM2dpWkJpc1haOGpoaG13bGN6YmVBdFV1M1ZGVWI0Q3ho?=
 =?utf-8?B?WG5vaXRYSC9Ba2lVQkNFYWwxdEhHb05KWVg2M3pRcWh5dTB1WlZ0bW5Eb25r?=
 =?utf-8?B?bUdNbDRHWGJicDlJaVROV3N0cFU5MFFMcXc0eHUybkZSRXBNa21RT2Q2bko3?=
 =?utf-8?B?QzJ6SXRTYlBNT0poWnA0eWI1RUcvNXBKODVQRkE0SThmUWFyMGduY2tBY1dT?=
 =?utf-8?Q?m/yCMP1qLjJIhtJQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <98CD87A15D6DAE479794C1E9643FCF3A@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 850d74d7-2e5d-4ff4-4b90-08da1ea21c8b
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:38:03.7522
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p6CruZ+VHjGIkpw05IbkgEleUtBoACM2V9uU26iGSHl9Se6QjDKl3Po1E2i8YHFl3OKgmwiWmrBRrYL/qLnKXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFRoZSBTQ1NJIHRh
cmdldCBkcml2ZXJzIGlzIGEgY29uc3VtZXIgb2YgdGhlIGJsb2NrIGxheWVyIGFuZCBzaG91bA0K
PiBkIGdlbmVyYWxseSB3b3JrIG9uIHN0cnVjdCBibG9ja19kZXZpY2UuDQo+ICA+IFNpZ25lZC1v
ZmYtYnk6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPg0KPiBSZXZpZXdlZC1ieTogTWFy
dGluIEsuIFBldGVyc2VuIDxtYXJ0aW4ucGV0ZXJzZW5Ab3JhY2xlLmNvbT4NCg0KRXhjZXB0IGZy
b20gc3BsaXQgd29yZCBpbiBsb2cgInNob3VsZCIsIGxvb2tzIGdvb2QuDQoNClJldmlld2VkLWJ5
OiBDaGFpdGFueWEgS3Vsa2FybmkgPGtjaEBudmlkaWEuY29tPg0KDQotY2sNCg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:39:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:39:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305447.520457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEgE-0003B4-0N; Fri, 15 Apr 2022 05:39:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305447.520457; Fri, 15 Apr 2022 05:39:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEgD-0003Ax-SQ; Fri, 15 Apr 2022 05:39:37 +0000
Received: by outflank-mailman (input) for mailman id 305447;
 Fri, 15 Apr 2022 05:39:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEgC-0003Ap-Tz
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:39:36 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20607.outbound.protection.outlook.com
 [2a01:111:f400:7e88::607])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6e42234a-bc7e-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:39:35 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:39:32 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:39:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e42234a-bc7e-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P82s2ORVbDIQbJaWJiObFL0CLo5ewQNxQl1cKjf93adA9YrQCXeils/zai2grgqHWT6T4GP1C0C1w6uzbKAwLGkxkBa48zLUIKXwS64bXWeF+Bv5aNX9ZwWPk+nWa15qTZMiREtkCXAiggauz7226Mvj/iMf+0k4Rz/ULKgpoQAhBBK7m7Lxo3g1sG17olHSQAVs+3ITQ32tq2yQupl7SMuvt8CDRCLfc0NMIQNQXgZieAro6uc2prjCToQjh57Fc6LRQJIEd01ssrODPmJe4Pj4aPH+uUzhFQ/1Id5DqV+2LOcnIkyV/JlLlrsJIoOtlRaNRiUk0uQNF6ZVYah2xA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=omIGCLGdXguYoUP6MBg7rPuCF4y33QrfLBFAULbl9Lk=;
 b=oUb6eg9qq66thkFW2dsafu0xpu758ry7qtaFkyqFeh/a3kpd4XM5WYvxrkA7nynDkjQzFxwQMVDhc4zui4JpRTt0zltnLKP9Er6Nrbd0Y0zh2kyBctQeNWKzIkOl7pYuNS86OBxcMiPuAUuIEM4Q3gZ+Mhy7xJtDFKCAI5qKs/fJybBJYqBr3kO2H0reHrwxVx0lck7ITFiO23a3c9LdM+dE6315lGqYRZ4E/PGA2Wkr5MpoPDfmcciTEjQPKgIUpiBxpPP/QXDkXYyKP48k8EJGMsuFUBKSx48J2PXBKNkGdDiNanYaHBZuTTam+c5GVtakTGG3uh32n1YjkH6I3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=omIGCLGdXguYoUP6MBg7rPuCF4y33QrfLBFAULbl9Lk=;
 b=WKHIMc22M8cT1F4TOOdGS5jyRprS6YflieD57kJ9VHosgbK2qXi00dqf1n91wOkO7ioZIoaivqfw2E8t2/tyTEF80oWdFDeVot1F/XsxETSyu/JHk8xM6A0Y0XwpTrsf4O49SF9PbJj8oBkC81zk8KAT7ExVsBJV0OJ8x/aLpj/ihQJjIbVXwFkEQ6+f5qx9tlug0RP1HacUA9FoicsZ1wpcWsWsyDNLApdRT/u2WzVzb3oootNWEegrnufnMNAdwghM737ozJ+YrgKft4Jq+BeeiXX6JKM08kFx3qx24exPuw2WdHEFDi9aqAQqG2xTjKa2hWVsPiJe2YQ3F4WmSw==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 03/27] target: fix discard alignment on partitions
Thread-Topic: [PATCH 03/27] target: fix discard alignment on partitions
Thread-Index: AQHYUITFeHwvXEjzw06+32xoV+0XX6zwdVMA
Date: Fri, 15 Apr 2022 05:39:32 +0000
Message-ID: <883810d2-c170-388d-a031-63a9792fef5e@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-4-hch@lst.de>
In-Reply-To: <20220415045258.199825-4-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f75ff33f-773e-4acc-6d5a-08da1ea25175
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB1815B6BBB70B3A16BD279E14A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 ct2OLeRIuik4P+2DUeO5AU8gZqPN6uyQIUnOB8Te+jtyDQNy6aUS+2wsUCMu8u05rWrtf0DIc95cYzd/uLaKTLCrJxxQtZnGGKhUTdcGX6GSWCuCwxkxGsNEG+qJSr9MwUJ7XV9Zvf4FJqe7DdIfzabcBJWl0widLMYk4wFdipWIDEgBVwlNKStVB4Pxswixw3xwANpWRJg7bFt0bQFSjiUuJkSR7z0bjIDhBvb4MU32HFtiyMZF6OWyg8DId41GzQeNxLyflykrZEg7zoRuIKYYiICmpgkAzJFBYYgV5mxIh0ODt8HLe8voQYI34dMRJ2q1zzDO9N6AvHzhbTWTMdsKs4T3CR07noro0Q+qb1WlHpYDdG9DvL2DCoCaarkL1zCHAUJkxEAyMDkzxdV7YkDlSMmau8i/g2y9w9JUbyO4YMAn8IbGR+TdxlqOSApiqh5rCevCWXCyj8q6unx+vib0nG0MK7JxHb7cag3lx4NrOlh++otAdbNAgAhRpzSgd6zLuYF5yoCgnE5OXtwW2xmmSbbIl4IfBfZxZ62Uz72R7UeZkrvDAbKwM+q8p0QzWNVE7+Tj5+OAiwUQj9ZN21aoKS/qM0isH1HffCwIA7CF4XxbqGl9FtgJ3gBe0gt6S6dX/NceavBgo1VeL9RfL1LcflQn3Q3aQvl4LqXD+sV+VQ99i4CuOr/ZuVcFtZnN8LvB0jGsL2I6mgWwy/cIGsBz+W3FIUOiMubueCem4c0OQc3RUQ5rHinqZ5V6IZeWEMz+VO6hBed+QWX+vJJ+Xw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(83380400001)(86362001)(31686004)(508600001)(4744005)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?c0tlN1NsN3ExRHNGOTQ4NWpMd08vcEpCWVpOcnFEZTR0TFJXY29qR1V0a2JY?=
 =?utf-8?B?WG5DZWtKRC84VCtLd2xrUnIycjlveWFGbTNuRGY0Tjhqd0Nxc0JrVFZNRGpB?=
 =?utf-8?B?ZnplU09JdGt0elc4dUlocWNGQnZqZGJnVEljUlN2SjZDL0tvMjRDdGJ5V05i?=
 =?utf-8?B?MmVNdHRCZWRNVEduYmxqREl2Y29zdTg0d2NlYW5NQU9ZemYwRDJWMVBwY0xQ?=
 =?utf-8?B?Tk5lUXdJd2dCVlBZczlVNWY2S2o0cVB3ZEdBbDhzeFA2a3lrR1czWHEyUGZD?=
 =?utf-8?B?blBCN0N0QjFpQVlyOGNuNVhFMmh1OXROOUhNTHNGRmE0bDFUeUdxZUJNRWJB?=
 =?utf-8?B?ajdyUHN0aGNuVHlCdTE1cEZhVmVjam1KbGlLbnZwaW5HWGlySUVnY283cHhw?=
 =?utf-8?B?VUNTclhzYTVBNVRpeFNRNWI4RnFUYW1HM21IZCt1anJTTVRoR2xpZHo3TXBW?=
 =?utf-8?B?cWN0YjgwcjZTMGlnSFJlbEowZUNITEhGN3NNV2YyRUh1OHFQbUZ4N2hhcnYy?=
 =?utf-8?B?SDZBaUx2MWdwZ0kzME12bi9hczJKUkpobDhJNC9WbnJKelhRbytKYWNpQW0v?=
 =?utf-8?B?Q2hJQ1dSdnVnT1lEOGFHd0FGSE5RQ2UyRFErcEk3WHJTanlRZWRtUDhVcE95?=
 =?utf-8?B?QzRwV1VLYkl4ZEpYSExkTmRla0gzb3UwK1RsbEtpNVFLdDJPNlVxNXF0K1VS?=
 =?utf-8?B?d2o5d1FxOTh2M05JY3ZyQ0ExQU52LzVLVlROcG4xUUtJWkVQL2cyaWtvekcx?=
 =?utf-8?B?aCtpNy8zZnBvcnpyR1NMSUZyUEJzNVBoeGtydWpnNCtzWUgvTnZQSjdQK1lL?=
 =?utf-8?B?bGtzWHBoYm5SM0pmQ3RJY1JDbmkrTElnZXFOWVNRVmlEOTR2N2FmTFBydVJO?=
 =?utf-8?B?eGY0T1l5Vk9sRU9wcWI0ZDEralBTOUs2RkpXTlhmOUluWXJmVnVJaGxuV3pm?=
 =?utf-8?B?dkh0bElzTTBvc290WGp6WXFxdDZic0Y1N3c3ckQ2Rm10bUlwY1dNMUxnQmNh?=
 =?utf-8?B?bXozSVlGTXkrb1AybTN5aGwxU0hWNUNGd3B4V05LcjcrMmlHNFN1NTRkRU9h?=
 =?utf-8?B?eDR4aFppVVVqVXk0cGdDNVJvUjh3Qjc3OXJIeUpHL2lNWWtURVpUWEpkN1Ni?=
 =?utf-8?B?bTVmWVBkWm0xamF5L0I1U3l4NkJqZUN4eE1zUWk2YlN5QmZwNklHR1diSHE0?=
 =?utf-8?B?TE5yZTVibENkcFdNeE8vZlgyS0NrWlY0WnVsNDBTMEZrWHdpY1NaUFpBby9E?=
 =?utf-8?B?UEJicGxvQm5uMWROTlZ6dWlLaDkzTUp1L0p6ZWUyOTZnT1REUkVxZyswK0xw?=
 =?utf-8?B?cU5UREIvSkxhQUtyZW1FT2pTaU5iWEhoamRscUE0Slg4NzNJQzlGUVAyYWVn?=
 =?utf-8?B?V1NOZHNUOVJFVTRRQTlNcDdGYVljY01mcStrV3lJMCtPWkVqNC92dzIya0tQ?=
 =?utf-8?B?eG8vamViOWdrRkF3eU5kVFViR3FZT1F5azdnZnBJUk1tUWp4QlF4NDBPN3Z2?=
 =?utf-8?B?ZDNXdlEzN1djbDErUlF3YnlCZWdoVjJaMVRRWi9LRFY1bzN5dE5mZjBjaHZo?=
 =?utf-8?B?M3lZakZkdk1DUk5lUmhOYUp0aEJ1WUZReVViY2kxaStQOVhFaWpIZFRGQjd1?=
 =?utf-8?B?Qm9SVklaYXM3QVNNUlVIZHVIVVBpUnpXaUxwdVdHL20xYUdOdkxYSzd1K3FW?=
 =?utf-8?B?Qi9SL0lTd3NXUldmOXkvNllsejgwbFJWMkNpVUQ0WDdCYm02ZDhOMjlTWG9R?=
 =?utf-8?B?ODJPa2d2S1d3L1RIMkQzaTlkd1R0VnA0NzhtUWNWYW5NTll2ZThYbDZ0U2Jz?=
 =?utf-8?B?b3o0MllMNDkxaVN2NTVYNnloRUl1V1NqV3YyNGdpdzRWdGhNMzdFZWNkbGlH?=
 =?utf-8?B?eEJBcU9USU9jV1cyd29DZnYzLy9sZ2Vham5aRWRnWVF0S096Nmg0UmlHVW1y?=
 =?utf-8?B?ckozbFFpWm8zSUVzR3RBRGl5S0hMbEsvcFRVNEdnVEhiSzB6RnpDYUFrVVBO?=
 =?utf-8?B?dlY0bkNrRWZYVElwS3JHZ0ZqK3ZjUThiUmtpQXBHamwzajBCb2FRZDBCWWxo?=
 =?utf-8?B?R1BrR29Ua3FDZmQvb3c0cmwyOWIwVFBVVW9VSTl4RzdDUUNWOGpiSWYvMHR6?=
 =?utf-8?B?SGxGdStidzNBK2l2WE5meldvK0ZtTFJxN00xeU1OeUgzM1gxY00wdmpxb2Zm?=
 =?utf-8?B?cWJFbGlkZ3dOZlp3QXpadGFKSkRkc2I4NTlwMXBYRDF4RWtoS0NNZVFUZi9W?=
 =?utf-8?B?dkI2N2ZVOFBNT1o1UFdjV3ZEOTNRVkU1ZUdwUWxDbDFuNThzM1ZJY0FwZ2M3?=
 =?utf-8?B?OHJGcVZHOXRtdkJiZmNOMjRXQW5ZNjFuQTJKM0I1eS9hNVRKMjZSTUlmbnli?=
 =?utf-8?Q?mwLvyuXNtT2dnZQ8=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <308F8700311C87409575E1C200FD2EC0@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f75ff33f-773e-4acc-6d5a-08da1ea25175
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:39:32.4969
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ODsOQS1Mue5lFCyrdhicFWU5WLi2FcJdfWJh4a+Hin5SswAuBJNfxrqbBcEL8rN3XrCR3LTTvxXQb4HjN73Pmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFVzZSB0aGUgcHJv
cGVyIGJkZXZfZGlzY2FyZF9hbGlnbm1lbnQgaGVscGVyIHRoYXQgYWNjb3VudHMgZm9yIHBhcnRp
dGlvbg0KPiBvZmZzZXRzLg0KPiANCj4gRml4ZXM6IGM2NmFjOWRiOGQ0YSAoIltTQ1NJXSB0YXJn
ZXQ6IEFkZCBMSU8gdGFyZ2V0IGNvcmUgdjQuMC4wLXJjNiIpDQo+IFNpZ25lZC1vZmYtYnk6IENo
cmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPg0KPiBSZXZpZXdlZC1ieTogTWFydGluIEsuIFBl
dGVyc2VuIDxtYXJ0aW4ucGV0ZXJzZW5Ab3JhY2xlLmNvbT4NCj4gLS0tDQoNCkhlbHBlciBkb2Vz
IGhhbmRsZSB0aGUgY2FzZSBmb3Igb2YgcGFydGl0aW9uLg0KDQpMb29rcyBnb29kLg0KDQpSZXZp
ZXdlZC1ieTogQ2hhaXRhbnlhIEt1bGthcm5pIDxrY2hAbnZpZGlhLmNvbT4NCg0KLWNrDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:40:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:40:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305453.520468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEh3-0004UE-9L; Fri, 15 Apr 2022 05:40:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305453.520468; Fri, 15 Apr 2022 05:40:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEh3-0004U7-5y; Fri, 15 Apr 2022 05:40:29 +0000
Received: by outflank-mailman (input) for mailman id 305453;
 Fri, 15 Apr 2022 05:40:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEh1-0003eW-T6
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:40:28 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20612.outbound.protection.outlook.com
 [2a01:111:f400:7e88::612])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8cb15309-bc7e-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 07:40:26 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:40:24 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:40:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8cb15309-bc7e-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XaUp15sxV+//g92SNHPxpHEIn6Z0vwNxlZ5SiGEOC7n7Y/7SHZOg1QrGwNi+VawjXeEdsooPVfiTferfy+60OecCfl3uv5VV4B+CGo2rWILU6y7YrB4eQKBH9LV/lCSc+crg/7ewvxQmS2/vuYqOay7eJYewBvA/R160NYW2iX54/BBpBerimiazjbnxgR+Ad5eTSrxf/Tnuiq67KLytvLF/zs6nDke9q2KiqBg8nNYmuZBXSCcXmbcV4ZnCyD+ghkGXQ628ZGgso1YvqIKHXP5Cab9GnSCUY6RskwxAqF7EZ/sg8DIeS07IAGhVhHBE5279XeuGjWR0eSqpiy5Zdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zeqRsi5qUzfOoVz5mMgRNawNkDuhgO1aMKf+Il7fseA=;
 b=a5qqqDjvchMTx3X6EmLdiBAbZ6ozPaEX5RpA2w2s1HkzYH/1DzzjdsztZZ09Nb2p9/yFlLMmtgmj1mASL4vrkvyrRvxfTZ3XcSQ2NvKHiqzeQjbrxdTfoNxjNkoD6cNqPmGTmlhHrJ/Qno8QL0q17XWm3iCIFKAMYgHL5ex3zy9OXTRt56cJyUHXToZCS1jn3793fB+Nmie/He3XVjrpV/yotxwaaK6p2VMHYJgJZHLOgmVbCa8IN18+DHZ7y5dZAT7myJP6c7TVMBfRp+dZDelt18yEB8aY04P68bMoq3ctS4p/B8adm5fy1Yh+GidzVWEavSG5IKvakzm+F0LSRg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zeqRsi5qUzfOoVz5mMgRNawNkDuhgO1aMKf+Il7fseA=;
 b=azL6I2325DJzuoKqfpuEgluZIpFyKYMAebUZ3uVLb+D8/min/TTIi0GhU5pc5YcoWY3ypu+cvJ2h6kPJ5DzWPQF4Ka+PXGN3utcWBPdOFzQM0cPm4O9O4qw7kZkIL66j6Q/KzDy1bbaz9J0Kfi4ET5fFckgv1moefbaXSwIgsZyMZVVcwedMQE9MkQdzz7yiw2Hp0GxG9oyd07bJYodqBAMeLHSLU9v1uLw2SJF20VOgGob04i3fJh2YXt3oe4bFonCDvWM27tK/2xJHnIzjDDRRz6fQ5V7oHq5tr0JbngQ43LFbjBDPrF91HcbYlB4OVQbnZN4foXvyhXQ7TW/HMQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>, David Sterba
	<dsterba@suse.com>
Subject: Re: [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open
 coding it
Thread-Topic: [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open
 coding it
Thread-Index: AQHYUITWCcMUA8bLiEua0LAPQuFUBKzwdZCA
Date: Fri, 15 Apr 2022 05:40:23 +0000
Message-ID: <f4851d27-c4c6-7fc2-9c32-ee1ae891c598@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-9-hch@lst.de>
In-Reply-To: <20220415045258.199825-9-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9d43f1e0-5642-4bc0-dae4-08da1ea27005
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB18150B7B7C6465355214E778A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 4ZPhtRNK+M5DKU8YWmTcN1yGt63cADpKaKfCy/SEb0ur+bnkBgj3MlbsUf87YdTU/lEwo1kpqxgFgtH8fApnw+l4mJQzPxaR2it9Negil3/1unaOyHoHqsB2RYc4eAWOy7TjHI0V9XtWp0eq8Q6nFlIrU/IQA9ny/AGrRroqxVS0UYCUUBfTbs0OQFL+twKXYYhUOdUF5NGxpRRf/UU3HQ3855viSwY41opIcAH5MN3OiLTGmxOY6qgrUbpyq7SaPp9g3wS1wvUL8ahdr9Vr+8Ua8vSbrn31OnQniKki7qIPMfi/VQGYNLn8wpC/AYXmcfm9Aui0kTzczK374wimI5S+9mGdcIUUXnQpLNxt6pa2ycSh1NipecEHR5kDNNYMMuezpb2BqWkDPjZJk/xmFSuN9RZlpk/Rt45rCQp/6Q47VSXKYSwvB43vOFYqSmdFzhmlkwnsmw5gdzMnd6rLw3wo9ykjXTmv8oOCNpOU5uUOI6nsMvLtFifgR0AhkO41VtGfwUFo4fkHTCfFmMDK2bOrVNRiAnkNSeg4knlHo1ce02U1FgrWfBtIbv6KlV5VDeKgDhTmzeyQrZYwoS3D84S56snOINbURrksogAlCBvSi4vfWgD9y6SpMsQTlr8KXJ4PJnkissEDr0GhMG96/mFk85ei8zPqQg0jPKDCHnTzGWFmG7w+BtU9ztBkWW99Sf8RB/aqb5cuMtiZTpMjDHrjlwVnor19WwImHXrimuJjSYpjbfrMSB1YXRasRs/xLdqtS6uovYxboYtN85dQ0Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(86362001)(31686004)(508600001)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(558084003)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bXNVZ0s5eHh2SjU5OFR2YUlhcVk1azI0dFRONmRyZW1XTHo5REpvbkJ1d1JS?=
 =?utf-8?B?N0JCV29aalFmajl6eHg2aVZJY2t1dlQvbzJxV0lNOUJJSHE4bXE5am91cjR3?=
 =?utf-8?B?NEd6b0YvMTZhb0ZUU0UvSUMzL3BYNEZ1Ny9YeSt5LzZEUS9sMWFYSU54RTlm?=
 =?utf-8?B?VFRKdC9ZclFITE8zdFhJL2YzTmZVYzEvU2J3anBxZlk2TmgvSjhESXhDbmQ1?=
 =?utf-8?B?OWNUUTVzUExzYVdXRlZZTTl6Vkd5dWlPMEt3LzZHUEt4b2xPSmR4RDVkWThH?=
 =?utf-8?B?WlE4RHduVjJBam13c3IwV3JFcXRFZzd5bmlEZEFybjlZRVI5TStGbWl3RnRM?=
 =?utf-8?B?MytzUFlUanAwOFpHR0RFbGY1YUljTnhwSHVBQ1drUkE3K3dkVjNBU2g0YXl6?=
 =?utf-8?B?QWNoZ2sxcTd6a0NJN0RkVmNGYWRMeFZpZ2Z5WkJvWHpiYUJPVE9EMTc4Z1pi?=
 =?utf-8?B?ekJMVmt0bSt6YXFkeTlyK2szVFhIajE0V0ZhdWU4V1g4VnczbVR3R3FMTjJn?=
 =?utf-8?B?U3A3RlR6SS9uRU54OHZUL1VBUit6ZFFJTndwWWRBc21nUlN6cGcvUVNRSDRw?=
 =?utf-8?B?U1JHalNFQVhDcEpETTBWclhhVXFMejBCTGFWT3I2WVFwMUJvSHBlaDdqeFdu?=
 =?utf-8?B?TytkVSsxRWdjUTFnVFFKOVd1QnMrL2Irb0ttMUxUR3FCVEVKa2kvek5XaEJY?=
 =?utf-8?B?ZWt2RHF4UVJzMzdqVmM4OCs5NnhhejZsYm1jbWJMQ3dyMGxUMzVWUGpRekdl?=
 =?utf-8?B?Tk00K01KY3JvZktIZGh0ejIraWxYN1JlZm1aVGxyM1IwVklhbjhlWlV1dkJq?=
 =?utf-8?B?ZWExcERaVldteEgxWUpuSHB1U3FxMUw1QnUxcUEwQVlpYytIcXBTMmk0V1VL?=
 =?utf-8?B?U2prRFBOdEFEeE1jTmFlb1lRZVBJT1JVUFdLOFAvTjJhWEZjK1VlZjVEcCtq?=
 =?utf-8?B?N1daVC9MQVg5WHRSTTlYWXpxMWIvQVNvdVcyVTJ3R1lZM0p2eC82RkdmZ0l4?=
 =?utf-8?B?Z0UySFJhM3R6OEY5aWxsMW0zWnJIM1A0SmdJcVhlaGdodXpCOVhneHNtc3Nz?=
 =?utf-8?B?SkZ1dmp0dlY2R0pqaGJIM1dJNE5ZNmhlOFJiLzlyVnVwNXBsNExUVkZGK2l6?=
 =?utf-8?B?OUl5UkdETTR4bFI2NWhXYktRYWtoUDVvaGpoRmkwSEZxeHFZR3VLSkJiZ3pr?=
 =?utf-8?B?aXJxUXovV0h4ekROWHVyOEVvTTBtN3MydE01dWV3emZTaGxxMGlqTU43NHpy?=
 =?utf-8?B?Mzg2UUtKTjQwRGNWUGovdlViSXk4TmthZ3dQTXNHQ0pCa1VzOU55WGZzcjBi?=
 =?utf-8?B?M0VHWHBKTngzYy9mR0xkUHhZT0ltdW9aS1VEUlNwbHZMZ2RQR1FNYU5KNHlz?=
 =?utf-8?B?cG1SeFJVdkRaTTFDek9xTi9mM0kvLzFKbHVveC9GUVZlOXkxdWNaY2RyTnR1?=
 =?utf-8?B?VXFxYS9US2dZWXhBZ1EwallXUUlmdE9ZRVN1S2xTdm9vbkdtWHAzRjRncStW?=
 =?utf-8?B?RjYwT28xdm9wVDZwMUpUSEZpR21GeG0wdVF4K1FSL04xdDY4SDg4RmcrVFhv?=
 =?utf-8?B?U2FsWmREQnpoTWMrTmI4bjl5MVRPbFZlWUdIN3FJSWMweHgyV3BlbVNWSFo1?=
 =?utf-8?B?QUNsY29PdFNjS1RBL3N6VkI3OE5kV1J6bFpnc1JiYUpyUHdzNjBhaENZalg2?=
 =?utf-8?B?aGtsWXJMbnNDS29IOTBNK3JJYkRxVFpxbUs3aUxLVS9sVmpaWS9tYndJTzN3?=
 =?utf-8?B?RkFEY3NyakFKQmVTamNSc3BwbjlaaTkzem96SStSUUtXQ1JwYXU5YXliTVM1?=
 =?utf-8?B?YWlrc0RJV0NIL29nMXVUclExaS9yOXU5MVhNdGpFTEJPNXUrREwrQ1lvSW5a?=
 =?utf-8?B?eWdYaCtqekswbHltRUtmNENEdURDU0xVdXpTVVdkYWlxcTVvTzk5ZTQ2YTJJ?=
 =?utf-8?B?TWloY1dVSFdwbUhoOTN4V0dWMDBTSXgzUUI3Vys3WXpMU21JaUpqVFl2Tnhh?=
 =?utf-8?B?cmZNa2wrbGpnMUJndXNQdzlQZml6K1NvTm9nc1IrY1A5a0FFeGtPZTMzaVFh?=
 =?utf-8?B?cE5zV29sN1Z4c3pUTXNrT2JCZDMyRy92VFlKMnBiSHZGYkNsSUFic0x6ZXNW?=
 =?utf-8?B?QW55aDBDYUtrWGp6OXpJOWJMWUorUlliaWJ6YmQ1dzZtdEVOUFdFVUNFNUs3?=
 =?utf-8?B?UjE4MlFnS2Mrc0JmQXJjYWgwa0M2L0dVUktFb1lnWXArRjFaQ3I2VjFOc090?=
 =?utf-8?B?UUlWRUh6Y1Qwakx1RTVPekhBN1E2SGU2ZDYxU3ZJekVnWGNsdlUvYlFOdDVR?=
 =?utf-8?B?dmFxYk9RcXEwWEJnWEdwYzhGYlJpelJnTzVPN3N4Tnl5MXgzZzAzd3FJL0ln?=
 =?utf-8?Q?LoY5Xge/tXZoe4cU=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3BD681E83CBB8E4A8EA752EE0A94BCBE@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d43f1e0-5642-4bc0-dae4-08da1ea27005
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:40:23.7751
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mi5Z+Cd0ksdzCO1rvE8Hu0ta8qQXfT/P1tA5VxBskatP8RIWaggzSdjfKrbZb/7EXEjVORAi8kufABb00rwpzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFNpZ25lZC1vZmYt
Ynk6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPg0KPiBSZXZpZXdlZC1ieTogSm9oYW5u
ZXMgVGh1bXNoaXJuIDxqb2hhbm5lcy50aHVtc2hpcm5Ad2RjLmNvbT4NCj4gQWNrZWQtYnk6IERh
dmlkIFN0ZXJiYSA8ZHN0ZXJiYUBzdXNlLmNvbT4NCj4gLS0tDQoNCkxvb2tzIGdvb2QuDQoNClJl
dmlld2VkLWJ5OiBDaGFpdGFueWEgS3Vsa2FybmkgPGtjaEBudmlkaWEuY29tPg0KDQotY2sNCg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:40:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305457.520478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEhV-00051a-Iu; Fri, 15 Apr 2022 05:40:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305457.520478; Fri, 15 Apr 2022 05:40:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEhV-00051T-Fy; Fri, 15 Apr 2022 05:40:57 +0000
Received: by outflank-mailman (input) for mailman id 305457;
 Fri, 15 Apr 2022 05:40:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEhU-0004nG-2W
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:40:56 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20601.outbound.protection.outlook.com
 [2a01:111:f400:7e88::601])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9db4174e-bc7e-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:40:55 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:40:52 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:40:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9db4174e-bc7e-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f58Bsro6zu7Ss8dNVaTKQE+FQHwhPGehVpnj9W4B+slHL9fwI48rREnURxApH08AFOS6tetZWGpdhCs0aDbTMGYJzPElJ4+c81Me7S3iU0LalnON3f/MwnyeA4tzHtXmLMA/I2XIouVy2NxRb61XuGueE9VFwfToPkMr9xDxdzH17j9rK9J85AzlWpuDmGHh/I9oQxR7rfvI6JFIfE5CCc1ZrSa39xJjoWt1EcwYpRf2e+EXohU6ImQeF2oNZ66sVVKSvuGQYAxTWlR5bfT/fBoDrUhYcH8XOHU/WrWfdE0nNxLJxA2rb3Pg+hJH/x8TRvVCFdJLWenpTMw1yu9KWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9xPbQGHhQ4OpqliAE2ppXjst3khmyYefsmdMvrf0gYE=;
 b=jjOzoE+Vm/qlQokwddIlSUm8ecBKDholeBySBcVSLkkbCG6Hh3ZOr9CsALbekzKvEbtyNHWqFctTTgvkbiXVvtBB5d/PwNRe2+dceM1ubhtxP0NJpjH+YDmrlyv4rpkio3++V207NVXQ28d+r00G34PPi/vMyWfJbNslJNlrC1TS6/scheNPzT/3p3eo7XCfMAfusElPYz2XSjueoHOuQAqyqOwxYj0V6qX60d5Y7emoAdUhQQesmYJITbHdORrpIMQDk1+LdrH9LGEp69MrdSQFWlHD/ykfpSZftzMX4OlsMYJpkwBxUVwNzPQ//Sbz4ETDknpEVnpQuZm3zQb7vg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9xPbQGHhQ4OpqliAE2ppXjst3khmyYefsmdMvrf0gYE=;
 b=jm6qn2n01mei+/os+xEVde2HSiJOmUg3q2UrHEN9LjaywMdGQwJFt77WfC70RrylqIfeYNwzM3TMGodHOlZkAvg4lYloMyZ1DpLg869ufX2Y5nXmupQYG4w9ZvAK9mZlkd1+0lndelrlNYigERJuS01UMGYPMxdei2NImPnA7vKA1bz6Sm5r4C+crImloG6Ba2xeBfe8WqxpMFN8iAOZs9zr8x9oAuNvOOt/yRwOPLHtLe+IsLkTaS+LwmdWGwtfuGnOTPuhKv/4Kfu5EC0YHUxh5DDCLvJ/TUPmku9oaurCrlU+EyFlVLn4TA8SDJSgK9IyIMWA3cOO9m08nHQbXQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile
Thread-Topic: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile
Thread-Index: AQHYUITaaZIEEJsgKUC+wO3WwWQ60azwdbIA
Date: Fri, 15 Apr 2022 05:40:52 +0000
Message-ID: <0da96aad-412b-9afa-c42d-92ca2a650d1e@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-11-hch@lst.de>
In-Reply-To: <20220415045258.199825-11-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: aea663ee-d1f2-4514-a72a-08da1ea28110
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB18159DA5D8FC0199C25F222EA3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 M34dFIzT0LV588aq6aIAGcgbjFXRluuYfXVQM6iNXvjdMwoeKeFBKBg1bghEe7k9t8y6Z5AyNBw/oD320Tio0S1m8PgrMXdIhntJtODQdLBnIhKAP28tJkRREQtszuGfbWFxqsBpClX5b2CNwWfFcyZOV9iU1D/FDauDeXl45/gWrS6a4h16M6rbfnLLgI4wBd7UwkvXcP1DTEPisunfwUMy4+wCC3eFpvjkbARACjDrUJTgMZFs5TZokIc6JnZnMKzIupFEqnhD0hcHJBAwuu4ucObPeA7ecyuz4+4sEG74G+2F036CTLI3jKSw7bGTOTJCwzzuZO9U2uwikGT7hbW77Dta8N6jnvi6E5eZVARMdmJO5CD8pvslNQvIcAte5bqUZzg+j6SHYsvaxhM/Zzv8pK8jbup781PwaxLUuGeVChY22kcWzr3RBW2x0g5ZRh7Nh0ipfISoWUnD/hRIU8LP9ftilHK4Oyib3ov5IjNleB9l17sxDKoEZ1iNpdf+UK5spUg5UA67pmlowjfw2IaOWzLbcrsQpuSy2gM5fQ2jPiG2CcXZi6RgmNoMsvXeWwmbP2uGJTlDhNWSflSWcOBe/1gX5IZU/hZGYfCwiJETf2A7vLRzSUCxSzIiTsWu3J3zSqXmTlN7p/QdH0bmT4GNBdyJOtdsp0a7Z07Og+b+Wy0yNNubVjqJAv6islzQqCPzpMffELFiAH3SFUjlpVM3o3SYWA4Zptgo86P/qGFflXN2rtVGKcZevr3CvF9Us9LApcqQqt8taqJvFLfk8Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(5660300002)(4326008)(66556008)(86362001)(31686004)(508600001)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(558084003)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?REtnQjB2b2dibWFRdnVXaDF4OXJNTDVZaGFnQzd1ZHp3azVzbUZKL1JDdG5N?=
 =?utf-8?B?TGg3V05zc0dYUGJTSWNnZVNaSVFwK2JhSC9GNlMzQkVvenZZaWdFK2I5ay8w?=
 =?utf-8?B?dDl4V3U2dm5qQ1BTRlpQeVBRWVhFRjcyeFBheWVITk5nRklPNDhDcDhZRll5?=
 =?utf-8?B?cVRzQVVSeWZiY3dvdFBUaWtVOUU0UmhUY3dOZkpCTHB2S2M2NmkzVnc3U0V2?=
 =?utf-8?B?d1lUMmRRdnVKS3p4UUVDaDJtSFYrNlBkT1RFZVJZU0h2K09SM2paQUdJSGpl?=
 =?utf-8?B?aGxDZGF1ekJ5Z1pZVjBoM0tGdmJtcko2NWlBd1JDZXNSYlJCY3hWMlBVZ0lu?=
 =?utf-8?B?eldoK2xmK1NhZkR3THpQUHNOd3MwdmJROTVSSXlqNWFJRnNFdGNDRENCRFBN?=
 =?utf-8?B?aDRTazUxbUVEM3EvUmU1RG0wUGhadU1pdWFpWFppZXBBZ3RFYjNWZTl3bFRY?=
 =?utf-8?B?eDZDMjEyYVh1WlZRQUpkSllRMmttKzVxTyszYWR2bFcwTlppbXJBd25weUtH?=
 =?utf-8?B?UHVKdTBmbUlVRE1QZk1XSlpURUQ0UWtVY1RsSzh3N0k2S2czZkgwYlJ5cERa?=
 =?utf-8?B?RldrellCR2hCV2cyL1dMeDJkRE9tdUpSdUV0ZnY4enlBSVdTZTVIb3NkUHlU?=
 =?utf-8?B?L0dNU2dIOFlBTEc2K1RyRkxaQnVOTUpFQVNxNkQ2bXFBbGhkMVB5bnQyc2ln?=
 =?utf-8?B?UnI0Vkx1MFFNOWp5eEdlWnk1V0EzK1FGZHlVV3RJeXNpMDI1aWl4Ulc5US82?=
 =?utf-8?B?WFZXbWxaSXdPdk1keFBWMEcxUHpWb2s0MGx4TWtTdUoxOTRLMWI3RUEyUGFP?=
 =?utf-8?B?dmEySHh0bjdqNjNIVjlNMXFnL0d2ZWhZaDBMNzZCV2NNdDJtSURCbXIrZVVl?=
 =?utf-8?B?Y01RNndva3phZ3dRSU1LR1pkRlhVNW11Vk9tYnM2cGZOcHN4L0RXdC94VDBw?=
 =?utf-8?B?K09zNlhVRUY4TW12dUZlNU9QQTZwOTZ3YVhieWdkbkFjUHJ3dHJMK0ZsWjV4?=
 =?utf-8?B?MDJDY2ZUUmV5ZUVwRTlrZittdWdDMXU0Mks5SnZiSFFNellQZTFFVDNGejBZ?=
 =?utf-8?B?RTMybExHSXMwUXkrRmhIdXdmYXN6YmlhQmJxNThweWJhRFZSTUgxOVpCd0ln?=
 =?utf-8?B?R2RMZVFEK3QwQlg3MjRGTjk2Z3VMSC9Mem5Sbkg0SHVucklQWWE1aFQxc2I3?=
 =?utf-8?B?emJyakE3dHRmQ0FaUjJaTU9TUzIwVllKUlRKN3RKNFlzSXBUd1l0ak9RZUp1?=
 =?utf-8?B?Vm1CZFdoTmVGN1orYnRzZ04zMXhZMHFOdTdkWXJkbmh5YndZakZHc0VURWoy?=
 =?utf-8?B?RXhxclpvZ2N1Nk1tTFM0c0RsclJBTjVSdXBoYW1WdmdtdlNjbEpDK3BqWk5F?=
 =?utf-8?B?NFpYWWo5cUM3ZDVzZDh5L3B1WDhoTi9sbm9SK29Ma3FOUEpWd1crelMrQngx?=
 =?utf-8?B?YWtGblNiem9uVll1N2NtaXlaMVpLTHdWd3piUUpKZTEzbTlqTFordlJhSWdM?=
 =?utf-8?B?RThIQ3RzZW1FOUs0SGVaRkVPaDRkTU8vUnB6cktqY3Qra09MYUVoWHJlTzNI?=
 =?utf-8?B?ZVR0Q0tXRFFYemVGcXI3bGoyZThnSzdBSDM0K3dHcFNNUXZqbGZyYWpkcDhy?=
 =?utf-8?B?QllKQXRCZ05FbjV3MTNqV1BXZzg0VmkyeS9UZ2tYdlRSODRrL1BrRXBzV3hW?=
 =?utf-8?B?V2dQTkJKM2hzRlNLZkNHUUgwOFhZZ01HVW5nOUxnYTh3UWErMFNwZmFIWnds?=
 =?utf-8?B?b0xGM0NOUEEybmRNWGlXdWJLRS9PMEhmL3lPV0Rsd3laZE91clVlRm5MNkJp?=
 =?utf-8?B?ZmRDV2ExeGw2bkhFc1A0Y25CMUZ4ejhOOFhqeFV1TzJBUDlSWGZIamtsV2JW?=
 =?utf-8?B?a0NLU1RlSEQ1NW43TzVkM1piOHdvdjMxVm90V0RhLzEwK0pKcndYNTU3cFk3?=
 =?utf-8?B?TzBEYXhKbEpXVlNkcXVtcThOSFdwbTYvTTJWdGVPaUpzV1NYRjVVSkx4aWZu?=
 =?utf-8?B?QXBRbVA0SitHQ2s0c1AzdEZQK29BUURISmIzZWtSNjlFOW53THo3TkwyRGNR?=
 =?utf-8?B?MGRPYytuM3JPTUUwbWZSamxxZFpEVE02aGxLM3JSK1diTGRzN0QrclBoeWIr?=
 =?utf-8?B?S2VtWWtXMnRnRCtaTFM0blV1bDlHWG5GU0hYODFmeFU1ZG9YRmNaeW9vVUdF?=
 =?utf-8?B?QnQ3eDJlZk5WelYvcGU2VUlROGoxMGE5RDk2OVZvWHVGVVRnbnB2bWJmQ0Fz?=
 =?utf-8?B?R215U0tORSs1ZXVSS0Vjd09ySzRSNXM2Y0M2OW9OVEZFcXJRYU80cXhWcEVL?=
 =?utf-8?B?YVlSS0JRcWRhNi9lREtiT0Z3TEw4Q1lTUkk4RjRvOU94NlZYUFJqNDBud09j?=
 =?utf-8?Q?fNzSH1XXej3O0JvI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <807FABDDF8F92345AAFE5DF5D2053FEC@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aea663ee-d1f2-4514-a72a-08da1ea28110
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:40:52.3984
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aRHw2otjvuGwsDds8CNzFbeFzIULc5OPanDRop/gKBwt/QQI0D4jISCjUFC3clY67udtv5Wb1eK47vFOJyX3/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFVzZSB0aGUgYmRl
diBiYXNlZCBoZWxwZXIgaW5zdGVhZCBvZiBwb2tpbmcgaW50byB0aGUgcXVldWUuDQo+IA0KPiBT
aWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4NCj4gLS0tDQoNCkxv
b2tzIGdvb2QuDQoNClJldmlld2VkLWJ5OiBDaGFpdGFueWEgS3Vsa2FybmkgPGtjaEBudmlkaWEu
Y29tPg0KDQotY2sNCg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:41:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:41:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305464.520490 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEi3-0005gd-W2; Fri, 15 Apr 2022 05:41:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305464.520490; Fri, 15 Apr 2022 05:41:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEi3-0005gW-T2; Fri, 15 Apr 2022 05:41:31 +0000
Received: by outflank-mailman (input) for mailman id 305464;
 Fri, 15 Apr 2022 05:41:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEi3-0004nG-8X
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:41:31 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20602.outbound.protection.outlook.com
 [2a01:111:f400:7e88::602])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b181fa7e-bc7e-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:41:30 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:41:25 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:41:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b181fa7e-bc7e-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mtEqlB93bRxdM+nD46BARuntDXCQqiZmZIgo2rafU6GdMoJX45o0HSDGQ5TCVDmW0gBgHEnzpXP4+miBc3y9rw2OKt7Ftd8DmNJNREYyXnp1kSg6Dtob7Vse9JxhkjEepc7WxvXLNx58jVnoS4d4nILrtKuhoRr8MCGZPmZsrj6kGbwqa+B0/kAJHiA5QCXlezxsp2Kvju//CrAnAuPG4LX3xVfrMmNg7wuzFIo9LfTeJYNbaEqavWVa5dbugUU8AJwyhuc4pJuhryydFiO/FHNR05zycxDQ9b1Dopc9iTx+JijR9IccZGtBpNcAIxlAwOH0iVhr+81qQz9rhcO2HA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tzXz3EW8164cUoT21ZBUSUoZ9U90cZUmBkouo2Rft2s=;
 b=PEi3oSBnEJtyzLlh3n6RkPnhY1410Lsd3pl8eUIDaJPHX3XdtokZINGMZz27IOnnuRC7FRNv3KjVmAJI3Pg1dyCNQ4oXa+wU6UkDDsJClowRFDCQ5D4kAlbbdJjnXVqx4Cm35X/i8TRVI9ksX0w+E5YBGxv9N/5Efqb6BuUZ5oM+vB4sV7g5o8guHgIvEidNItEywfTzS8wm19brU8t2/ECSQazbDu/aWHPXdThTEMiCldDXzo0EW/k/j/gqL0M7dkrutD3w2vHGeeWqTEp5pIlF9e5a4+2znZgh8JOLJQyPCUwemgO7vevzE6mi9Kiw7aYSIEP46jGr67tWpQB6HQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tzXz3EW8164cUoT21ZBUSUoZ9U90cZUmBkouo2Rft2s=;
 b=bGHX/fV6uJIpyCR2p2PaPG9oBWBEvVWfxrceGopaEEh4AETPGGtfSzbwP3/8gUrk1TdOjJGM7AaoEAjY0DQkOp8XY2tsTP26SrWcsmOFe15NJaW+XmVxFL6N82mgoyPNAT0dvPGmhE73zLaS6Xvw9HWDTAiduFRGVeU13ZU/ALibmVm5mPwujCQ+y06Zn1tHHc241PNquirvyc6UHc2gtlggT45ZBFfw8/dgbrWJroQy7f2eDsPUatZzuIVq/LfnaO8Rrf1vBJCy8Kzakbef0ePwgeXIrVtXF/Lil/8oPzyddYcm4P6BcKj14UIuMGss9Hz8CF6QNKLxXNOl5WdpOw==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>, David Sterba
	<dsterba@suse.com>
Subject: Re: [PATCH 11/27] block: add a bdev_nonrot helper
Thread-Topic: [PATCH 11/27] block: add a bdev_nonrot helper
Thread-Index: AQHYUITcvf8y733cvkGOzPkg1cM5pKzwddkA
Date: Fri, 15 Apr 2022 05:41:25 +0000
Message-ID: <eba999b5-e9fc-1522-67dd-e232b48be9c4@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-12-hch@lst.de>
In-Reply-To: <20220415045258.199825-12-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1e3ace5d-eebf-4341-4b63-08da1ea294a6
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB1815A801B371E320ADF9BE64A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 2jzgUEHIrAsov39Nu4LyXYMxHaRS/0z/PqpjC27blY99b3mEjRApvUf7RTIOWU/4qQyQqWnA5g2AeWnuv1xrOzdSykyH5KKZe4+y8Pr4RYbQNJ9O9dXXzyd0bXePbajuD15BRouQVSX43IsFkMfzfawpEgHePKqgTOOFU5QariEIIFHfcefLo72/oopQxBzqq8fv6cEIHqcEdUB92BMHHRKLpYjbjKGt5iRjeqUPIfkLRUS68tVft4zXiyfScqU/+SmWdNXjjNEbzgSWiUfGWypf19LoPtzxsSWCqPSMGIaoZDvqfLekfdsjx2E9OxivGSVxoGnS6Vs4pulGCMByuDH2z3U4uBmAls/ATCl1XzRpxXqcts8YJftMpLGav6verm+fnj4amkU4kBjHeQ+xiHxAqryln8MQLJay7U4DYd/6nBihFw1hlVdwYN+EoG4kYrjI1m07gPMfdo4nYHqsyBdwAnUhyQmb3a02lL+tyi7+Y6RdYs2V9VtX2fkJjJ958pd1Issfg+1h7Ge9CpWYZaK5LuzNjEVgzHS/dACTdInBjbX0RwWQb1xxM6bmXCAJJufUobRrKaS++Y/Rng7ViTYyXqZiiY4dCeUhUqwNvVgyGvFlyzQGrCMNLcVlGxSSiFHUUXZyseGiJxV1PMhhX+lPbu+2ARSOpnFoJ36tnbWt/4UJkqdMUyF9vCtVv1cZ0j298rxtDqBdov8UxjpUqSnYlKWIZaNYAoE9zWy2lWqx1H+COPtTfVBA8fi2uomChpfWPJ5XSLiLyJDd8/txjw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(83380400001)(86362001)(31686004)(508600001)(4744005)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZUhHeUZ4SzZMVTFrUG9WeUlFYjNoekFLVW4zVG1RUVd0cVpGY2ljdmpTcGlu?=
 =?utf-8?B?S0M4OTVyNzZta1o4STZOSXBkU2lGTGloMXY0aVQzOUNLRWJ1cFZlc2loV1ph?=
 =?utf-8?B?eHEvUzhvb3M4NGo1eDJQbGxjMXJCZUVWWHB4dEk0YVh6UUducCs1Wk1EVFZM?=
 =?utf-8?B?MU5VZ0Z4N1h0dVlPYlFBcTQ3eXRwODZTUi9QSitDV0FqcytvbkhOV1ptNHR3?=
 =?utf-8?B?T2U5SlNuU1pRMy8zYTBTSlNzOFBOTkp6bXhtaklGSmhZQ2hnbG94OE1EUHBJ?=
 =?utf-8?B?M3pjMlJVNjhnMllDMm1ERUR5d2x1a2lyYStucm9lU1ZTNVZ6a2FhNXh2RDAx?=
 =?utf-8?B?cTNGcnhTYWFRbWdFZk9KaTJIR0xCYmMxZ0pSQ3pTcGlmdWd4QTJiV1EzcU1C?=
 =?utf-8?B?cURMejRBZjJYRzVzMjdOVFNJa1RKREJWcCtVL2wxaVVvdi9Sb1V2dHAwRS9r?=
 =?utf-8?B?Q3VtQ1UvdXgwd3dlRGlNdDZkQjZ3OUxGMjVJQmI4MXBTMHFTYXQ2ck1xYlNW?=
 =?utf-8?B?b0RmaE1IZEVFZC9ZaWVwcW96Rk5SZ0FjY2JoSWxSSXBKWjdjaVpISWlZM1c3?=
 =?utf-8?B?THorVUZFTHVmU2wvYXMwb2dDS0ZYOXh6NWxxSHFEWTlENDIzbXlEc0ZSYzhD?=
 =?utf-8?B?Rk9vSURWZzVZcDZXU1c5dHE3dG90dlFYbTM5NC8wOEtJMGpFcEhES1BaN1g4?=
 =?utf-8?B?NWN3aGpvQXpKRmdYK3VkVTd1MFllcHdlelZ1SWY0c3Y3SFg0ajNkMWxFb1dx?=
 =?utf-8?B?cTZacVJZY0N4ZlgvRVV3dVkrMjkvajQ2SDZuT2Vnb0FQUDFGM0lOVmpHUU1Y?=
 =?utf-8?B?eEhhZFp3WXh4UUxzWXNnYXFkRkZCWGtVMEhhaGNOanFHbEh4QVRlRUJhak41?=
 =?utf-8?B?bncvQW9wZ05KOEl2MkJscitvWStRVUVQNWVleEZBWGM3MFdxU2pHaHB0ZGNv?=
 =?utf-8?B?Wk1vWjNCY24vUndxdjlObFhoeXRvT0ZjTGtrUnZDNEp0MnZhTHdoNWsvMFdp?=
 =?utf-8?B?RWpzaVFhT3l0TU9JaktBT1FJY09qVmc4a2xEOElNNGFnV1hoRkFmamExVE1k?=
 =?utf-8?B?Mk9MUmwyUUJYQVNRNUV2N1hkcXYyU1RlQW8yQXVlbFRIbkYveVJQUTRRdUZQ?=
 =?utf-8?B?dTU0aDV0YkxLVWhBTWYyS3M3R3Nka0ZGSjhsOVYzdmh5MGNIQjVZNWxpMFVO?=
 =?utf-8?B?ejFrMXd6ZTA1dFdzSWhKZmJaellZVDFBY2VpK3c4N1UwNTFQTlNmU1FiOEtr?=
 =?utf-8?B?cFZhL2t1aEpUZ21NazNNeWN4OWRKa3VuMzR6N3UxK1pBb21QamVxRzZnUGZG?=
 =?utf-8?B?OENPZDhBZ3BZWmdmK0dWRDE5V3dmNUNqZTJOenFuNzl5d1o4ZkFoajdXVGgw?=
 =?utf-8?B?TFplVnRrQUpyRitjTU5CMDFYc3JURThuOEljT1ZFYklwQTY3ZTNSeTFuL0VY?=
 =?utf-8?B?dVNtWmZkMjI3ajBjMzdJM05qbVUrQ25MSTRCMkE5RDBRYkJ1d2xkK3Q1RWJP?=
 =?utf-8?B?TkVGeWF0UCs2emZYblNIUkloZkZRVklLOHExdEFpbFNXVnQ2TFpNMEtoSHVG?=
 =?utf-8?B?UzIwUU9CQUU3RTJ4cWFvVHc2SDdhZW93cGZZbFNDbndqVkZVL01XK2g2bUdn?=
 =?utf-8?B?djVnSVlFenNiZGpsZzJGWDc4NlhUS29VTTV6WmE3ZlRzWFV3eHYxM0ZJRzFH?=
 =?utf-8?B?SC9YTFVhMWdlY041K3FMZ2MxQm1jK1B2K09Ua3NpQUNwYjRJREYrbk8vbDNV?=
 =?utf-8?B?VC9BTVBuS0dpT1llWXRNZ3JFNkROeEN0dkJhUy8yWkxXUlpwWnhzY0FrQmdx?=
 =?utf-8?B?U3l1bFRPUnVnVit4dzQrZWFuanlwekdybi85UDYxbjlqQkJqc2NmS1lrTUI0?=
 =?utf-8?B?MHpFSmpibFZtVU9jVHJCWWtDQmVXNkZWNFVzRzB2S1U4M1RmaitxeiswZ3NB?=
 =?utf-8?B?MDdMQVFheGpvTXlVeWg3WC9hdWEwSnNXV3lMYTVIT2c4QlNqUFArell1bE9i?=
 =?utf-8?B?SXNCNkRBbWdCbDJuLzdOeFVSVUEwMHJwc0NYZG1vOFRzQTRqZUM0TXIxbnlS?=
 =?utf-8?B?Nm9vb01haHJ2eUgrR29KUStMN3RpaktxRGZ3Y2VtUEF5aVRwK2N6N2FsMlFa?=
 =?utf-8?B?UVBNS1VSV20rSnEwT2pMbExSNldHRTV1Q0ZqdnBpODJ0TW5kQndKSFRkcUVC?=
 =?utf-8?B?QkFWbmZobUVLQ054WWdzcEx2SzExVTBEN3FRUjR5V1R2a3AyeDVmazFUeTFN?=
 =?utf-8?B?VlZ6QmRmK0w4VVlMUFpyVVV4ZkpNQTIvODJWejMvUWxid3NqRmh5OGRvZHhU?=
 =?utf-8?B?bVpFSEkyZkp1L0pKNW9iSTBMU2MrVTdqNzFjVHlaK2pkZ1FMUXlqZ0JHdHY5?=
 =?utf-8?Q?2LBvpDbn9ASM/rdI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <78329BCB58D5BB408C7439FBB9C8189D@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3ace5d-eebf-4341-4b63-08da1ea294a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:41:25.2089
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sQnzIbBLTrp57c3vH8r48gJfpEIw9VzuFDfFpnwqaIrkuMKle22fiUk7xI+IyQciiM9x+KvS7whe2PMfw5w8MA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEFkZCBhIGhlbHBl
ciB0byBjaGVjayB0aGUgbm9ucm90IGZsYWcgYmFzZWQgb24gdGhlIGJsb2NrX2RldmljZSBpbnN0
ZWFkDQo+IG9mIGhhdmluZyB0byBwb2tlIGludG8gdGhlIGJsb2NrIGxheWVyIGludGVybmFsIHJl
cXVlc3RfcXVldWUuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNo
QGxzdC5kZT4NCj4gUmV2aWV3ZWQtYnk6IE1hcnRpbiBLLiBQZXRlcnNlbiA8bWFydGluLnBldGVy
c2VuQG9yYWNsZS5jb20+DQo+IEFja2VkLWJ5OiBEYXZpZCBTdGVyYmEgPGRzdGVyYmFAc3VzZS5j
b20+IFtidHJmc10NCj4gLS0tDQoNCkxvb2tzIGdvb2QuDQoNClJldmlld2VkLWJ5OiBDaGFpdGFu
eWEgS3Vsa2FybmkgPGtjaEBudmlkaWEuY29tPg0KDQotY2sNCg0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:41:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:41:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305466.520501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEiP-0006Eg-8H; Fri, 15 Apr 2022 05:41:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305466.520501; Fri, 15 Apr 2022 05:41:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEiP-0006EZ-5C; Fri, 15 Apr 2022 05:41:53 +0000
Received: by outflank-mailman (input) for mailman id 305466;
 Fri, 15 Apr 2022 05:41:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEiN-00060Y-Hj
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:41:51 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20613.outbound.protection.outlook.com
 [2a01:111:f400:7e88::613])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf4d8517-bc7e-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 07:41:50 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:41:46 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:41:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf4d8517-bc7e-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OMNCqekaQ2PPLXsItKoSPbv7xKyBM8FG4bDYzsTI8p3pFlzNiSFLFYL/K2KXbJfY7llLFks4m3mdrdw3EVEtYAX2siioptEBYZ3FKx7C/tiq5/JYQ4FxJ+76iLsBi/LluoLaUyataCSrWf6pJFKGdGYGrNnAx3nugwCi6ejqpAuWnmpRudBM64DAZsSFdYFgpSNAnoAE0dq/s8h0UMwhonjQG/Y7nm5FG7X3CWA9Kh68T2P2LpiuqyE4BfwIU2kg/+bN8Mp08nncID0B2wemNSevI4kIA4kbinB+m3GQuo4y3Aq/jtNOLsUhPkTHuji08+uKzfLI0x5oVeOLCqq4aA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+FqhaTrfUIQ4NPWF8rNUYFIy1CuNkuH68bv7RBix4hU=;
 b=nuaIirgzT8DzctS5Y9j/d2kyd0lW3DM5qrq/AXm0vasrNszSA74DN86ufg+ORASklF44xrj+ptqmPyYfDuCdb++JXyEt/OyILP/AWa1FaBDmEanRIcLTW3cTMUJJxEApdlf0P0lOCxpMcNlq/leITabTxivbxpXreDhZ0aBnvdzyOs6xaFRYIBE9jczIsTwvKlH78i4uy+v4PHxgrMTDagBtYn4RKVmBZRvdKSKilJvPkb6TCe8WwsaWXPDtGd3pGAzgvPi+A9GDlcHzuj7rI/77IS77QIdRX80JurmTBhmI5K76W99fnlsE+agJ1STzKPFmajXoLIJVGsEwDe6DQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+FqhaTrfUIQ4NPWF8rNUYFIy1CuNkuH68bv7RBix4hU=;
 b=tODTqjlAlsHeCHfKrGBmp/tDHryUzAA7ST5FHPcQ4MnODbRHDx40ZYACQv3iV8osnIwGU7mI45cL8QjiiX3HNHLJm/2G45jzrmT1Mc0fYmxAOaiV8rCseFGQ3tWvtBtqOKkXO7telm8RCXpcS8UehyxM3hRkrZHHNRI/KkJP7TEMk7gyB43Ks7EwAYOKDdyp+T6bLCR3kCDElDJEGMMNcCAvCxWOEUoPtjl4p0bl82up+6InTGQbswUlW4+y9UOfW5KkeRkP19LusgWV8XKdeXad5d5ZC2O8KmLypNfb7maetucp1RfqAl5zZNiLBqeh9L94vpoq80dB5LzJE2dZig==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>, David Sterba
	<dsterba@suse.com>
Subject: Re: [PATCH 12/27] block: add a bdev_write_cache helper
Thread-Topic: [PATCH 12/27] block: add a bdev_write_cache helper
Thread-Index: AQHYUITdob/Ugwum8EaYZwRM1yM7v6zwdfMA
Date: Fri, 15 Apr 2022 05:41:46 +0000
Message-ID: <cf0b3178-8823-4cb2-c987-db76e005ac4d@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-13-hch@lst.de>
In-Reply-To: <20220415045258.199825-13-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 48830246-69de-427d-1f12-08da1ea2a179
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB1815BFF38ECDB61E066BCE78A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 QukpvFRWGEJB2QMDxopY+7PehX7V0MCO16Kh18N7kY4LOzr9YuBq8I+WJa8MvCoM5twpadFcdPxd+GRpk+xryAGpEsKBOtHwdFoHJSkkARPlYe13Te+9szYCWxaNM/i8IRBLCZxqh1GJ30cPMCf9I+ua9PzkMxrJIFIsHawZ1toOQCPTN3GsLd7BronqU3M9pLSvHmxKCVfGHnuxLHaMvcysmwRv1lTdiKN++/TAKBYwtptwP0kT3tVJB1Xh0KzR3m/pBOgR8es4hNmVTf6QzA+RFLSk+P3bZHwY6wX5nDfSFZtmtt740wSmNkMIdD++XfLcRV0X4jwL5qba1Tui2KcPBPz8S5wyx3RmD/YxTxFI9ZhP81i9HPrY5m3kkP6EobNmIYtVi+X5db7S68Z1A1RnZoawXaSALScymo19klGFGU4il16B+3AoRk9pNOSfJ+q0/jcfJsbO3ftz1JrKnkLWDs34mDZyRcmcEqxE2nsNTl63HJ7Pz0OhK5YKWCL1QvH+pVK1qvS/ZHQRCqC7cqfHmDOZqAOvoi6Jx4WT7AWoFG0cXsMwCzZrQN9nj062h2CbUX6EdW4xQgty0PGht7c3U7fKr48E8zApO+g+NpHOISkyfSXJxb0C1Tyr2hA11F9Q+TnT18ReXZLRWu1ToFYQK75baOmk5HMrOFAM3fLJRyug6J95Nkh+gWiDtSa9twCfF1M9EXacFEk9cl5dpXFezGiAlPle5HX2rjSTdoU4GPrIA4/u/0V1SVv5Uxdg3fWlCfeHiNwRGj8lO8uNfg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(83380400001)(86362001)(31686004)(508600001)(4744005)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?SHN1U0pkOSs4MDNHMG1yMkhRTUg4b0M1Q0dRTUVSWGRyYXc3NlN6NWhVcy9q?=
 =?utf-8?B?V1NoZDdFVjdycXdrRDVMQUVGa1B0TndSUWdhNE90ZEh0ai9Pdk4veWZhcDd6?=
 =?utf-8?B?cXFmVTdTU29YV2hFcGpSQlpxMEpvV3o5M3lZelJTUXN0d2w2N08wZU1EOTFS?=
 =?utf-8?B?ZjU2d0JneUdXR0owQUk2RUlmNHZqZlo0aTgrQTVFZUdKRTZjL0NNT0RyTzVY?=
 =?utf-8?B?OU1NZ0xmNVVEQ0laalFsNDVYMExkaklTSTI2WExpTVA5UGwybk1GTlZYMjZS?=
 =?utf-8?B?dEtBU0NOWU5sblRkRGJrdVlGNVpsYlNUK0srUXBVdGdFdHVURXZCd3ZrYmVS?=
 =?utf-8?B?ZHZnQkVYSkJRdlFlaDArMUJQUjhsMDlKdFJvTnF4OU53OUVHamtkUnZ0OUNq?=
 =?utf-8?B?b01GZzJlQk9BMFkwb01INi8vbmdUUGl0Q1lvc2Q0SExxUVJkaFVuUHNSNUdC?=
 =?utf-8?B?Rng1b2JMNjBlTnFuWEgyNGQ1SGcybVV3Ykh1YlU3Q0krbDVYYnFLUHhYWXV4?=
 =?utf-8?B?YnJKMElIRE1SQUY1VHc1YVc3SDcwd21hZzJPZUdGWXhzR1c4ZEpPSXB0dDhM?=
 =?utf-8?B?b0Z4dFVBOW1tR1Q0YUR0aXBWYTlCeG1RVFpXVHorWStVK3VJRFY2L0hhdklR?=
 =?utf-8?B?bHR2bDliamh2WElncUJ4emFZVjJRejRZMDV2KzhhTW45eU4wNGRPSC9qVGZs?=
 =?utf-8?B?d2RXNWlXbmhUbHBzWENxcGhuRUZTbFcvTU1RUzRjdzFiOGNaSGhZM3A4Vkd0?=
 =?utf-8?B?NkphNkpONWFuNmg0UVlFdjZVK0w4OGd0WjlTMWJvRTRNRERsM0ExN1NTallZ?=
 =?utf-8?B?bWVhVVVOS25ldythMUN0NHlnR1FpbENUV1RpcE1Qb0hEemJzeis3UDhtN2Qz?=
 =?utf-8?B?bXZZMlV2RGc0dHorUHF4RmluSmd1SmZ2SjBKNmN2NmJKendtMGFqdE04U2x0?=
 =?utf-8?B?Tk9mWWowQ2IrNWVtTTRtZmNNRitVaHcraXZOODAreXVYTGw1MVJROXY4c3Z4?=
 =?utf-8?B?MzdzWlVBaDR6UGJrSDBuQVZYcWVPUndOSGl5dklGQlZ6V1hKL0prME05aFE4?=
 =?utf-8?B?MERSbVBMNEdLZm9zUWdBQS83Yzg3VmN2WTk0NEFzc1NYRUZpdnlOYXBCakxq?=
 =?utf-8?B?N3krcHpSQTB2R2s5Q2d1VFQwc2FsSlkwVlVpQy9BWk52b0lyamExYTdNejhn?=
 =?utf-8?B?SXIzNldFZ0JvVUtIRmNQUlhmWHVwczV0cE8yRkJHSEE1UXNnZm1oNzJBK3Nw?=
 =?utf-8?B?aW1yaGpXYkRod1lJcVo0MzFTdlNCYnZETHptOFY3ZkdDV0pIaVRsMFJiblhE?=
 =?utf-8?B?UzNhbytweThWanJvZVl5cXRwTmlKTkJxNytGNkdsRUNnN21USThYV2JuZXhJ?=
 =?utf-8?B?SVUwUjNlT0t5TDc3YXYwdStKS1EzZ1NvVjB4TGhTQzBnd1c4VmhOZy9RRkMv?=
 =?utf-8?B?aWhWZVBUUDkzcDlJcGkvOFpYNnBkTGFWOU40WjRzckxYaHdmL3RhaWJnYUZw?=
 =?utf-8?B?Mjk0UUFSTlp5eWZ6MEVockpJWTE0TmtzTjhXaDI1d2h2V2pqU1k4R2FxODRT?=
 =?utf-8?B?eUxLS1hVQWEzVzZFR1hQOXh5Q29mZ1NJQ3NYS1U4SHQxMmpXUjkraWxUQ0gw?=
 =?utf-8?B?eC9RbWVsMFFKUTVoNDhJMHhyVXowbkcrSml0RWx4S3BzQTBpWFlmYTdXOGpZ?=
 =?utf-8?B?endhcXN3anl3OFY2TG5DSERySE55eGpyaVVwbklMSlhhVW5DN3UzZEFRZUg4?=
 =?utf-8?B?VVhQdzAzMUI5UUFRRzBtZDEzdlZPOVlkd1FSMmdwRERGMzJYUmhzN3ZKU3RL?=
 =?utf-8?B?QnBxeWxodGRJQ2N6ZExJcjdyS0FoaC9PaHhyaWNjRGc0SzRPOERubzVvbyt3?=
 =?utf-8?B?emYzL1U2WENJblEwL09QYWVLYmZZTlJST3hra1htSTRINnBJbG01OGJZWVo2?=
 =?utf-8?B?WXFSZ1JPd2lBQXRiNmVycE0zVko4YjNTOThsYjl5MmtPK3FpOWsvc2hQUEE0?=
 =?utf-8?B?SW5xMFV5eEplQUlEdFdxR0NEa1NSR3gzNm9QdUpHZGdQbzdTK2JsSG41QTBZ?=
 =?utf-8?B?TEJSS1planUrZk12eEtjeXh4TkNLelNNK2ErVlUxbWJ3dlZHaCsrMUxHSHZ3?=
 =?utf-8?B?eCtFLzBnOWl1UDhRcWlEcE9neGRJdGtFVkZmd01iWVZuTVRodUgxM0JhZ0hQ?=
 =?utf-8?B?K1FwTlE4bHd5RWRrb2pxaUxXajNmK2UvZ3hUb1h4T3dGRk9QdUVyQjFoSzFD?=
 =?utf-8?B?WVUxODNxcnF4Tk9uZVBGOThiTkFzSTJveHlzbWU2TnJ1bVZ6SzVrY0R2Q2xL?=
 =?utf-8?B?Um5kY1MxL0NhaHlYTm5ZSnB5em8xSXVqSWdYMnhSVUM4OWY5RmdGSmNiMFgw?=
 =?utf-8?Q?yoCsm6uWvQ1a7EMM=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <80FC9A4858701045A17542A9B486AED5@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48830246-69de-427d-1f12-08da1ea2a179
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:41:46.7857
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1I/HGrTepjPrJfyDJXvAhA0IGeyaOEbNK+YAiCNuMMlAxhtbd6TSpK4UrJ9KB71YHciDco0PVv/pgbmfpPENTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEFkZCBhIGhlbHBl
ciB0byBjaGVjayB0aGUgd3JpdGUgY2FjaGUgZmxhZyBiYXNlZCBvbiB0aGUgYmxvY2tfZGV2aWNl
DQo+IGluc3RlYWQgb2YgaGF2aW5nIHRvIHBva2UgaW50byB0aGUgYmxvY2sgbGF5ZXIgaW50ZXJu
YWwgcmVxdWVzdF9xdWV1ZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IENocmlzdG9waCBIZWxsd2ln
IDxoY2hAbHN0LmRlPg0KPiBSZXZpZXdlZC1ieTogTWFydGluIEsuIFBldGVyc2VuIDxtYXJ0aW4u
cGV0ZXJzZW5Ab3JhY2xlLmNvbT4NCj4gQWNrZWQtYnk6IERhdmlkIFN0ZXJiYSA8ZHN0ZXJiYUBz
dXNlLmNvbT4gW2J0cmZzXQ0KPiAtLS0NCg0KTG9va3MgZ29vZC4NCg0KUmV2aWV3ZWQtYnk6IENo
YWl0YW55YSBLdWxrYXJuaSA8a2NoQG52aWRpYS5jb20+DQoNCi1jaw0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:42:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:42:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305473.520512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEii-0006nG-Gu; Fri, 15 Apr 2022 05:42:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305473.520512; Fri, 15 Apr 2022 05:42:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEii-0006n7-Dz; Fri, 15 Apr 2022 05:42:12 +0000
Received: by outflank-mailman (input) for mailman id 305473;
 Fri, 15 Apr 2022 05:42:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEig-0006c4-U6
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:42:11 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2062f.outbound.protection.outlook.com
 [2a01:111:f400:7e88::62f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ca46f699-bc7e-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:42:10 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:42:07 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:42:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca46f699-bc7e-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WU7wbWXMPRMCSKSHOIytJ+eX2d7dPF5S2B41rPR3o4NX7LGL0eHg2cjg0QKdThr7boThD7I81sqWbwhiim08Hq3J4/Jj657abDF6suNR7NgQVF22H5N1SZTbnBnf2Pqd5ZD8THBZ+JXLf2jOteWlqiWuGapnIk2FLAMdxDsgiBkTFNCBcKydzcIv/JHfXGsmFDgTSnYcb4cOIM07K1LX2JGAX4Gi9vT6SQ5ulze2BRBcHyHn+Y44YjQyz7lAI8dK+YtktkWZZ3HDcnkP5N1ftYZe0iF1KcXU0nmLDJW8pAv4Vu350YkK2wQIxW0rHbAVMNCHjXq8MLHd6d0CvE1zhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cXmWoxiNrFUT36KRaCWH5ftRvcuoLnY+vq0rmT1Kt9U=;
 b=HKq1lIpiEHpgz9XqSMCEvSRBp9j3kHVQVk5Sswl/JMPviKMnDbhJNWBGyF8HPEMM6FoOOLF1FeEezIR12hm3p7VJCfN/erbDjSP+lQnc2KCFWy32yVAnz4VK3JoAVwiJ9QGkhqazVUmun/MHtWU6jXTyfZQTd7r8SAZmBicxVR++jI+ImkjoLqjdr0YnTSkumqBuEuG5fK5W+IzZJETt9umKCLvJm5dcmXgpgAEiLkwDPsIMlbq/c5AyQ2O4ftDAJ6gCkqB2TGJhaGfeCa4k2oac/XHH18to4YhjNptm+inZc29pqJ74rR1q3TftXkc2g8A2Pptz+dk8+26hhQ3k+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cXmWoxiNrFUT36KRaCWH5ftRvcuoLnY+vq0rmT1Kt9U=;
 b=PjcfOcmcIW+IJ+Rx7sLUBgkGMqL5A9o8uphx3jDX0X3PWGeQ7n8JJwtjzF4wxaDknIExHlAPQjAebMZY/u+ZU5YXZqony9jVj93r9e42VIOUwZtZOUhVOKYzuPQ418L2D9YinV5P3ASM3hpk+Z8l1gtLXh/oKAgJEPl0rxL6fjq4jhUXXVow5xQzmMlj45FbdPWI+THaSSV30hXXb4Z3aPWoVQxkZlwvOPVOWmMxQecPzPnSIjNvA0awydisQaYqmiVEPzY+LECJ09AJUKiN+T2VQ+aQxh+vAkV4lFt8kJAQHYNWnsYXDOKMmAOABtDsDaUImG5BHHxkuAKfIqczjg==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 13/27] block: add a bdev_fua helper
Thread-Topic: [PATCH 13/27] block: add a bdev_fua helper
Thread-Index: AQHYUITeWwsZSeujF02rS5YtUAwIEKzwdgyA
Date: Fri, 15 Apr 2022 05:42:07 +0000
Message-ID: <77dedfc7-d5af-4d87-0383-613b80139850@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-14-hch@lst.de>
In-Reply-To: <20220415045258.199825-14-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 78d5bffc-1ecf-410e-e5e5-08da1ea2addb
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB181583C18B6F4B1306D9F075A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 EyB8hyf1JleddzYMugoCzU5pDkbuoBJ4pMtfwahP2ogCrshpAMwi/M3kryaDsr86Ji8Q9U4kHeq8opzY12HtfVHQnFhUIP4brKkdTIq4Y6ukil1eCLgOOYlrZ5o1P0nbImPP8bumuAkoyxQWEqr2pscBJl7suKAqCf+rn7r+oOenvqj+4obi/miPtobHImnRCiFqVQgtDsT/N32Ixv+yCvs7EJ/Hlgkoeim10mAXruT2vQpZWRXCIY71uWhnrRmvywzHl7+0ryrDGpRopaC4VXorwnKmlY7xCtQdT3mJrLKecVx4z1anmMntcRJN4vtQSorQWycnaL1JGitCMJ13sT7IUOpDp8A9esZxVNNwKoF5yroommwEp/ZWFV25t1L6NdLAVHxuUSTk2hLWvATU1xURTecgCIb0C+Nt7FJH9FgvN1phKoF3Jy0/LQ7Z2L5XS7q3Y2RTN4gd17beEyBfgw9bBAZ7KGjVbp0h4a/agz8f8JNJ14537BDPs6J4py2NSMmRbnayX1NHA9E2IbENVLOxyFwNhoNxoUeEk4M9KIZevesgLhYW+Jmz/E5nFz5VzA4tF30LXK/mutY8o+Q3ehw562gSxt3f8beQMVMuO4uH1b0XtHszv8e4ig5MbRiv7U7I69/l0BQK5qbz4DsvzlZdDK2gMlITuS6vpjPKMLETzOjcBDVIkDggnK+CZDCHTsQf7NR8pON2Gh1zpljGDLbLOiFSS7nCHuiYk3MYIrgjzUsd+XeEtmHZBqZVF24+Em7DxOzP3Z/CS72dLl3aOA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(83380400001)(86362001)(31686004)(508600001)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(558084003)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Rmh3d1NVRWtMeEFsb25ENXVPcVBIMC9EU1JnVHNBZDdqNHpPUDR3SGJFb1B1?=
 =?utf-8?B?WFVvOWJBVjFvWnNHOTdvQmVRQ2hHeHN3UlNEVHRuazZ5MFI2SVVraTQ5UEMz?=
 =?utf-8?B?VzZYdTAxRVp6U1RtSUFzUjdSaW5udmZySW9BenAvM2FZZ09hQVJ1SlVqUDJh?=
 =?utf-8?B?eXhCQm1lZExVT2pKSFRsNUt3RjlteDdQZk1LQkdUT2xNTDNoWSt2SThmMUVE?=
 =?utf-8?B?MCsxUi9lcU5OYTdzL1RFZ3kvMWVSa1Jjcjl5YVFJUDVyWGVzL1lmK2d3c3c0?=
 =?utf-8?B?eW5BL1pOdVp1SW92TzhlVzFJR3ZhVFFxYTdKRTMyN1ArMFVGZ01NYjZ5WnU4?=
 =?utf-8?B?SE8zQXdaWHkrclZZWWYxWWsyWEJMU0VSWFEzRldFU09HZUdock5xZGYrL3F2?=
 =?utf-8?B?VU1yN3FUYzk2Ny9JYXhNQVZqdTlCUkoxbURaUE54M29ZdXBVM1pWZGUvc3lo?=
 =?utf-8?B?em03MStETWlGekZqQXA2L3dHdjlWZThmbkk1VHdzMDN6eHo3YTNuZEc0cWN3?=
 =?utf-8?B?WFBvWDhlUTIwMCtjcVRqbjhUbGhCZTdRK1hFbWw3LzRSeHNQWGk4U1o1RG1G?=
 =?utf-8?B?ZEcxbGZlN3VkWlQzT2FZM1hlR0cyZVcreDYrU1ZpakhoS2V6ck1ka3pnSjV3?=
 =?utf-8?B?c2l3dVBUdE1mUVRnMGVYRGpSLzdXVTNRUzNHUitqbHVKaUNlb0RVcE9najdp?=
 =?utf-8?B?OUxqaFZXbzhZUXNNemhHd1lCcGRvQmlPSHFIc0tid3lPVlgyK083Z0ZuT3dh?=
 =?utf-8?B?SUVZdUxjb2lHRkNSRFhHODVKMklUYStkUDVYN2RVWDNLcUpaZmIvMk85WmFK?=
 =?utf-8?B?UzN1ekVRTnAwVVF6RXR0YmJSUXVnYlZSbmRSVTZoSHZrc1BKUXlVeGpVMkE0?=
 =?utf-8?B?dk5ram9IUTMwVXNZVFU1WmluR2NZZkIrSlNXQ3l2NEpXZUhZbXYzbHNDTnUz?=
 =?utf-8?B?UXNxM0JGUE1ORWFaQWphWEVIcEZpS1FzQUJZYUtmeURpa091SlJxMTJUOTFQ?=
 =?utf-8?B?MmIvMU1ucUVkWEFvblNJZHh6QVFmbUxSMUJzQ054MXdGV1h5eDJTSU5XTjZp?=
 =?utf-8?B?RkprY1hweDJlNDRnUGpIMEFYWkVuMERPUGk1b0FmTHRyNzFyRHpHemgzVHZp?=
 =?utf-8?B?RVZ0aXJxRXF4cGVmQkNYd3BOdzZjSWtVSVd0UWwxa1QrdFlNcEo3NjZZTVU5?=
 =?utf-8?B?L0Nid1ZoSkI5U3YvNkZNclY1dVZGaWZlTmROQ1lHUkJDa3AyYTZkWm1CaDNn?=
 =?utf-8?B?K2tWSy9va0hNcmRhZWl4SFV4RjNDSTFCaUdOeGVjNjNscmsyNFJUQWEreCta?=
 =?utf-8?B?dURReHdvTnplV3IyTWJzRjd0QS9mY0Z5b0hKQjhNT29MQnhYZXowZ1EySHZC?=
 =?utf-8?B?VWRRVEhGV1R2V0llT29Vcy9XZXBjemlQV0FpeXVnYXRPODd1NHczY2xiaFoy?=
 =?utf-8?B?cVo2WDV4UmF5TXh2M0R5TnVRY3dkakI2Mm9kOUNLaUhtRHA4M0plYlFuQ3hI?=
 =?utf-8?B?SHdkaldiWTRnUkx1VzdjYmUrdmZCMFQ0VHg3V0wxeUpJTy85Ujd5Q0hPc2Jw?=
 =?utf-8?B?YkFLMnE3Nk9zRENtY09wQXJkaUV4QmJVOElZb1pWTmNTUnd4NDZGVXkySU9T?=
 =?utf-8?B?UG1xRDVGMGhtb1AwWWo0UFJ6SmNiY1duYkQvcTBEY3p4OWREWVY4cXZtNzhG?=
 =?utf-8?B?dVNMcnU0ZVRCV3hjNG5kNGdnZlo1eGVwaHlIbWRtTmVXU0RXYWdRUnpReGJq?=
 =?utf-8?B?ZU4rZytpajlJdzJ0ZnNqV1lCYVlBNloxYUVYOUtmaUMwQ0UrYjZMMDVJYTUr?=
 =?utf-8?B?eHkzc0JVdnBvcmVabU9KeURONnBiRXZuN21mT2NJcVpZam93dXRDVFVyL3VC?=
 =?utf-8?B?UDF0cjhFU1hmaG1oQUlPdjluVjQyUng0YjYwUlhQT2x3MWVHOGxzc3BhYWdn?=
 =?utf-8?B?aWdCZ24xZmVselZnWTJtNng0Q2pvWGRUdXVBZVhTNlV2Umg0T1BxcjduVjRT?=
 =?utf-8?B?OGsvNnZKd1M5bXptRWdoNGNobDdTamxFbXNTMzhCOWxOSDZMTGZ6V0RHeHE4?=
 =?utf-8?B?czkxb2JnVnB0dHExUE9vODdBNWFJdlhqLzBrakJrMU1mSWlKSll4M0pTOWxk?=
 =?utf-8?B?SmZOTFN2cVJpdXB0UVdxSzFMVUt4RjFENFNIanNNWWovYTFkT1J4Q2c2SEhB?=
 =?utf-8?B?MGJKUk5PdUZyZHRSekVETit4MkZ3WUo2WmRZV2hmaitKYjRybnYySklQdHVB?=
 =?utf-8?B?dlBFMzlYdENUUHpCL3NXak1WU0FiZ091TGswZ1pSQW5ZZTlWN3lZWTJCVnN6?=
 =?utf-8?B?YlJEeHlaMnUzL2tuZ2pHM1lBN2g5T3hJVXJDSGdOeGhaSDg0Rm1Va2loa2c3?=
 =?utf-8?Q?1Z66E7GDw37e6nTgD+MH8VjpaJC1xSuIdTeG5?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DF997BF112FF594981505DC1D908FBEE@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78d5bffc-1ecf-410e-e5e5-08da1ea2addb
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:42:07.5188
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4Ta0Zovff0U+n3TbFxVzpBAWYFvV5vI9cPj3l5EKpKj/yjyOIuU3gSYzhUD53UrhII2nt3yMopUhXs1a5HAr+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEFkZCBhIGhlbHBl
ciB0byBjaGVjayB0aGUgRlVBIGZsYWcgYmFzZWQgb24gdGhlIGJsb2NrX2RldmljZSBpbnN0ZWFk
IG9mDQo+IGhhdmluZyB0byBwb2tlIGludG8gdGhlIGJsb2NrIGxheWVyIGludGVybmFsIHJlcXVl
c3RfcXVldWUuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxz
dC5kZT4NCj4gUmV2aWV3ZWQtYnk6IE1hcnRpbiBLLiBQZXRlcnNlbiA8bWFydGluLnBldGVyc2Vu
QG9yYWNsZS5jb20+DQoNCkxvb2tzIGdvb2QuDQoNClJldmlld2VkLWJ5OiBDaGFpdGFueWEgS3Vs
a2FybmkgPGtjaEBudmlkaWEuY29tPg0KDQotY2sNCg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:42:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:42:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305479.520523 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEj5-0007T2-TU; Fri, 15 Apr 2022 05:42:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305479.520523; Fri, 15 Apr 2022 05:42:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEj5-0007Sv-Pa; Fri, 15 Apr 2022 05:42:35 +0000
Received: by outflank-mailman (input) for mailman id 305479;
 Fri, 15 Apr 2022 05:42:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEj4-00060Y-Cp
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:42:34 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20614.outbound.protection.outlook.com
 [2a01:111:f400:7e88::614])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d7f6da82-bc7e-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 07:42:33 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:42:30 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:42:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7f6da82-bc7e-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iMyy/u7mrK6vyWy6HrqlEawCAF5259NZFthPsEWvcKIZM8b06Uu0sLrbKGRT8DlUuVi20WRyyLVGhjpMlaTE41rd2eMmWxkAr8jEUOCCcupGR/iRfFUgwxCeXTbBlaCa2QrgN5zCYOAwUnbOGEk9dxA9lQonM0rtHkWLgBHscFiQUHAtR9l7aru1wb0eQZOAGGmlSsxlS/VIle0FZWHdBj8oyuYlaprb4gJ3JIn2xHIyjFdThwtnt30razYljvVb4m1/Z1PMYoc89ZBMizkcPpzbfxvDw8kSqyfQcb1nqGaj/3Iikr886AT3NJD3gGjo4BJYzf59YI0hXCDP4sVTzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i63dxVhBes5m7cPwLoD+A13NfCaI28iV9y4PoA3bvMA=;
 b=eW7rRL2JvxzWokoCJRlXqj0mHNv/XQO/j91LPUJbPJ9QpPs4v09A9i0Wu4zbSN0eph4DP9QtLXiqHm1di1BjlcIFZzv4XVFYy8hU9betLx4shVOlEeYzUpl4rv9he2KuAJSaZlts29SJsDDbjkb6N5oirukovedY+3eNde40X1hRXew/lv5cWBncc1R23nmA5zZV4ALOhWHwQRBgNyuNkJNH6nuYrfmoUYdSw/78Qpy7UjTI3h3NAGXlDATxKAmDQ5jbYu4W220oLe/Gu7zuWGd/gAdwjdA0K3vlal24KNIEoSgv+zy5C/B1UCyHPWrwPizW/rSDg9uFurWSXPJDgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i63dxVhBes5m7cPwLoD+A13NfCaI28iV9y4PoA3bvMA=;
 b=rPgk33sgBEZSP/Ovm7jvsz640IYdyFvdM1fnM3lU6m7hGyj/mWMg6EjvUnHN7MbENCPEl6B+GzAIQaOFxp5xfiWrefupuWBvxHL+PgSXw1OCMSh0PcIokAm8WOCYnl1njdMmUi5oCY4Gw9qBkq6gSLZnrWSAlcI53nwvVVpbv4T/7VXZt8rnTjgH4EonEpnVATg3odZIT0zEG2nLh/hoHGpgFEUMCk69GbLgQ2mGc1pYX3UNAraZuE012TWuofQ/IJqZ3PGvHiqEQOaIeD/zc9Gn6iofz5djOWF9l2i2/bT4Jj9e+rMAdJs16xkW+gFk4KU4rptnTfDJHCOAzH/gzw==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 14/27] block: add a bdev_stable_writes helper
Thread-Topic: [PATCH 14/27] block: add a bdev_stable_writes helper
Thread-Index: AQHYUITf17GqiWYdIke9HM2RTAhEIqzwdicA
Date: Fri, 15 Apr 2022 05:42:30 +0000
Message-ID: <3a257cff-628b-e03e-e539-fda51a9ebad9@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-15-hch@lst.de>
In-Reply-To: <20220415045258.199825-15-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 078d3f1e-b513-47a0-d329-08da1ea2bb8e
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB181508B1B3F0B522FE8C7925A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 QIkcmQpRB+xKmlDfFYlHUkmX9U4k0s3PPCFk9L95hYvst+R+B6ueQ94YpjVXMCCC7mSfTlW22ek92Xo2SPueIiM/I2OFC89VWd3noQNYQ5GcU188lFc+DjRrw/NdCE+6lMZeDgxBUcbhevLIw/1hzBhGgWOurw/dCxsxbsO4ReBNB+AwMryEsD6970l/Jgwxs783gRGNFAKBreyDkSX2ujlxCYetaPCdNhdkCcJJffRGhyF+R2SRe/aFn9fsW2PdzFFVLUWg5Jx27S7j5La/9HIp1HWuMck0dSZbWM2n++AnATid/HWvso0tzZbJpO9BT+pvSoVANkloNwNW7ohvV3XN6pS9UzilfboTkxikSKsYTNIOLfh3n16E7pYaU8kjwjCxd3vK4quyu2Ljs1LR29xt52O0to+1CQONljUt/clIq+27re9SCQSIph5fD4/K+x1b/p6IWJzefT+hKnCX4EUfYQBAYR2SPJIweP7l36y5X3au05Y2opXiW+rPwvg/xMrQ2V+vL1BRjcjhM3CEJMTtx/6RcTcboxR70pjQ3yHnC/S6V448l+/pEi7YFTziJrbdkUQYMFYOdEF9slrPDNPM8EkDyeNCSmo3HRfL7WOVhiFXCKAptFtLF2fXtZ0HpmuoWgoD7S0+op0mdjVEgIoYMVYMnCP0ta+yoWKmr7VVmh7Qie4j85WHpSPFNQdAXx3/TaIRyu4E0mc/ncpiH75GCPcEy08soEmxOKQ5SFHzZDb0wawjxFNHjlDCZlMyphcZfntXeCOio/mnwViOQw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(83380400001)(86362001)(31686004)(508600001)(4744005)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?enB3TjJodk1tZVRFdE4xcVFyb3czaEVxU3BQcmxCZGlZWUJNbTZGWEJldXVo?=
 =?utf-8?B?YUFCcjJ4bXZMTnRGRnY3dlloZDNpQlZNdzQ0QVgrbmd5RlZiM1ZDZG1tZ3Zv?=
 =?utf-8?B?Q08wSjVHbnp3RW9oa2xxUHUxVHdKN04rd0RHSWdYbjFpSDRtVi9zTk5VK2Fl?=
 =?utf-8?B?Vzh2T2V2RWZNTmJmVXE4TGdaWmhXeEIwMkx3NmtKbDlyVkxQZXZtN2pLY3FF?=
 =?utf-8?B?alduMVlMRG9lV2dLWThjR1o0aUQyTEM1a1lSZGI5VTErWGNBZDF3NkVsME4w?=
 =?utf-8?B?V2d0YkRDVEtBZHcxTVN5Qkxzcm1sS0xEYzRqQm5mNG9tN0xIck5sSGplT01V?=
 =?utf-8?B?WmVmVXp2ZDc4UktUQkY4SUlNSlRncTd2b2l2Z0lsTUVkRmxtYXVOalBYbHov?=
 =?utf-8?B?amR2VUZCZHBGZ3FFeVF6bFNXYWRvZlA3U0RhQmQvQ2YyeDVkaXBOLytFaXh5?=
 =?utf-8?B?TjdWMDg0TWt5ajdRS3FET2ZuN3VnWWhWYjZJNG8rTjBZYUtZUHBLeGEwemxU?=
 =?utf-8?B?MnBoUzcydm5PbzBIWXBUVVU1N2RtMGgvekE3WStzNzRSb3YxZXg5dXZLZWJJ?=
 =?utf-8?B?bXRZTmw1b09zNkVwVTJ1UEhCa1ZEcTBHbDhjTTdTTzZ1UFByQUVVSWIrS2wy?=
 =?utf-8?B?cC9iUjE4aXFkd3Q3WG0ydWtoZmtFaFBsSVdtcjhsMWhFNFJnRmJjMEUvN0Fv?=
 =?utf-8?B?RFM2MTU2ZjBXRWpKeDhOTE9mckxUZTBYeXhQRDMzOTN3QklZeXhIeUgxTUhh?=
 =?utf-8?B?MEkvc0VWTVY3MVprUTBheVRzUW4zbngycE1OaGRxNlBIOFdSaGhjOERYaGMr?=
 =?utf-8?B?a2xucWpJekZYbHVtTlpGQ1pOYzNwRGpjN1dpK3JpbEovMzY0MTkyb1k3cnAv?=
 =?utf-8?B?ejRwcDR3aHFMMk1OVE9iTEFCeFBYQjIrZ1cxZzN3NWwwQnFkaEFCRExZRWVD?=
 =?utf-8?B?bnNIZWF6VGpHMVFsWXJLS3NpV040dFBQZVowWnEzVWVKS0prMFpjeFpYMEYz?=
 =?utf-8?B?MThtaEdXV3JraHFCSmo4aERrNE53czMrZmsvVE55cHNsM1lwMGlLMWpUT3Uw?=
 =?utf-8?B?WGpyVWJ3S0I0RUc1bkhVcWNNWDRCNzNyNlI0QnhxMnl3RlBHMjNsN3pZSURy?=
 =?utf-8?B?MVdXbEFmL1BZK2xpVGdxR00xakVidTlJempoRFpwT0pGc1AxRktmVWR1UDFi?=
 =?utf-8?B?RnhyTkU3ZENGRERML3NxMi95NTZkNUN5WWJxalphK0JlZFdqUVNYS21pWGVW?=
 =?utf-8?B?eE50YlUvSzdPNnBNazZnLzNTK01OWVp5QzVPUWkzRDhBVHA3WERxQStqeGY5?=
 =?utf-8?B?L2JDK0d0cDdxMmZSMnJVVHNMbXlnTHd1Q2N3U1dsSkdBWkZveHR5ZjhmUFda?=
 =?utf-8?B?dStrZ0RVUDdZdGhSN2k4OC9lSTBjcXQzaG52L1BqeHUxTkVvQmFqa0F4Nlcv?=
 =?utf-8?B?S2hoT0JJMy9Wb3JyeFE2SzRwaFZCM01laURpWWVoeXZyaEE0c2ZvcCtNdyt2?=
 =?utf-8?B?UXJUNmxhdkpTYkZKQmE1dEZxYTF2NHhnNUQxRGJiSXhCY2o5QmxMdXFmazRC?=
 =?utf-8?B?c3NUSExLK2tUdFNGUlBhOUJtem9XVXJkV211bHJnMEhUYThidXdBQUVzYUZm?=
 =?utf-8?B?UXFUUk5HL3BZZlFOYWh4bWxMUC8xSXFKaDhVU2ZWRTVtU3lubXFIV21PejNM?=
 =?utf-8?B?RGVPMFFsWUwxcWVLZ3dLOXU4dFpVRDhOZnk3U2diSEpTSkZVVVBJajVZK052?=
 =?utf-8?B?K3dlcng0MFVLVE0yTm4yRU85dG92YTVHWFRzbTA1alQ3Zm01MUZWRU1HTStt?=
 =?utf-8?B?WkVVYkM2bjFJVVBET2lvUmRUc3VJUHpqT3l6aWZQSWhvR2Z5eHE1N1VvNUNn?=
 =?utf-8?B?Z1czMVB5eEIwUW10Wm5VZ3ZNMHIwUnpWL05QWWhEZzNQR1NvcTBBOUhYVXg3?=
 =?utf-8?B?c1d4eXkwWmw0WTM3YXEvVHhHVHhnWlU3RnZMejF4eWJvdzMvL01BS3B4Zy8x?=
 =?utf-8?B?NlA4UXZPN0VTVmpIVks5Sk44RU5iUlFEdTF0QUkwbkZSbWJhU3JWWnFwVUpG?=
 =?utf-8?B?UmQ3NlpCSVJ3cXIvL2JJWHZZeFhtOVFGdjg0MlhKZE1mOWl6T291N1BkbFJJ?=
 =?utf-8?B?a2paVVdmaVVpY2RyaDYvNHJEdG5PaURIR2FjK2VUN1dRZ3czWlBidDY4RXRh?=
 =?utf-8?B?MmFPMlZaM3ZzUDFWY0NOdnh6ZmlncjFVWjdvNlozd0JSbUZ2YVFaUEM2SHds?=
 =?utf-8?B?UTJpc1BPeDZPakVybTlYL1p6OXhBMXUyMGcyUXFzVzVtQzRoK3d2ZHMxOXRP?=
 =?utf-8?B?RjNYQ1NwREdDcjdVaVQ2T0JBZ254U0Q4UC9mRTFad3JwTCtiVkpEVllweDB4?=
 =?utf-8?Q?pYtC1AMYu8KuMRuhqkOqway9etFx0cADrGZMy?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BC25D9F96CBBE841BBAF019B54F927FD@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 078d3f1e-b513-47a0-d329-08da1ea2bb8e
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:42:30.5331
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CBLfUV4czhdmP5VBDMkNhv1sreSiKqiRtJSo6We3NVLb7+NWNzJ2UCP4PGdqXaU4w5GPhVgZkc2E0t9OkXiYIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEFkZCBhIGhlbHBl
ciB0byBjaGVjayB0aGUgc3RhYmxlIHdyaXRlcyBmbGFnIGJhc2VkIG9uIHRoZSBibG9ja19kZXZp
Y2UNCj4gaW5zdGVhZCBvZiBoYXZpbmcgdG8gcG9rZSBpbnRvIHRoZSBibG9jayBsYXllciBpbnRl
cm5hbCByZXF1ZXN0X3F1ZXVlLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoIEhlbGx3
aWcgPGhjaEBsc3QuZGU+DQo+IFJldmlld2VkLWJ5OiBNYXJ0aW4gSy4gUGV0ZXJzZW4gPG1hcnRp
bi5wZXRlcnNlbkBvcmFjbGUuY29tPg0KPiAtLS0NCg0KTG9va3MgZ29vZC4NCg0KUmV2aWV3ZWQt
Ynk6IENoYWl0YW55YSBLdWxrYXJuaSA8a2NoQG52aWRpYS5jb20+DQoNCi1jaw0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:43:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:43:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305487.520534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEji-00088X-6v; Fri, 15 Apr 2022 05:43:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305487.520534; Fri, 15 Apr 2022 05:43:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEji-00088Q-2V; Fri, 15 Apr 2022 05:43:14 +0000
Received: by outflank-mailman (input) for mailman id 305487;
 Fri, 15 Apr 2022 05:43:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEjg-0006c4-Oj
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:43:12 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20616.outbound.protection.outlook.com
 [2a01:111:f400:7e88::616])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ef030751-bc7e-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:43:11 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:43:09 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:43:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef030751-bc7e-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R5xmOosq2CA76gdgm6VfUB1pSubKAWraGkUGptftmTUx6soaY2zrItNPwxTlvdnQbkGHRttyCOskGudy4NlF/wLoXzpzF/EsejVfBD8RRVawAg+HW2h2Ee8k1M5oGEVjdpdQkLnp9EnFko0ztZjGDVY2GAb3D+22PwiZeOcl9O/N26mW1ZBSkqJub6ssns2U9MWviR5Kp569zngIlDY7GFnDkw/6Ks6kQ9nZku5RTAHm+naUGvlvAxOHUdhXUezohgNOsgU83OCH/IkOyRZPOePv1MkJZcFcw478P1UtyoermwZEegfM+bn0WB67fM231W8jiRLDfh6tPoB58hiJ4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/5H+8Htl+4waRugxbMx4Qrdik8L7tyzYJrNYknxljDg=;
 b=DD6/kBr1T8p20Qy5G4MnmbrlfQNsSPGYYHlOFiqCnxtlUvYkrslD6SVVIGbaJomLomkFAnjRGvdKt8LRZRtSydG5qfl2li1LIECN75pldb4hGa4u11EtW3ABLfCnwYax/2NVXnVtzNxNdLb2NJWk5l50LzyORV7pAngYn/T0umInWjqueJJbW0UozX9F1Eh/eibcpUMH5kdJL31+H73UelklLS8Uem/8wu+ZkE8oLksRYXhDaZMlXTAkUvdB6hAb/UDbK3J8Sz15smPZPeo/1hFCELeu0uPc2kmh8xS8C02Vk4Bs2eoRYFjKNRmukSuXeDlPAW6UR1vqQs1a/HbCvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/5H+8Htl+4waRugxbMx4Qrdik8L7tyzYJrNYknxljDg=;
 b=bbQcnGI+WjMQNQsa+dIiZJb6XflLSwuUmitGjnUrE1+K2mZ1hM0qTAY6w5oFoM3BVgzz1TLav0E5w8H2LEdwFgKZBKvW++4hTnZmCQJ9NFJVhYN9f3dkATOUCjUANbMEKL6l45b8yYqPoW2ybuDs/rZLEvXj7UV3+OSsOvgIaGenA0jsWeFjQS+vn7lKL1TxKHIT6zWvmDWd9fBFFHkj10xS7juBmZeLdjI3Tgubc1dkhc2jSdph4ITmdstRwFudio8xxKlcTK6jae6mJOWVC+wXHrG3+Jzh3JSVwz25WoFXEVaPWIxmEm/WdZ8SC3lvxlKY9mi9dU4KBSIX0yRhJQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>, "Martin K . Petersen"
	<martin.petersen@oracle.com>, Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH 15/27] block: add a bdev_max_zone_append_sectors helper
Thread-Topic: [PATCH 15/27] block: add a bdev_max_zone_append_sectors helper
Thread-Index: AQHYUIThL7IFGipIVkSGIZfvx5g6z6zwdlQA
Date: Fri, 15 Apr 2022 05:43:08 +0000
Message-ID: <29b7e5b3-172b-c006-94c3-ad23e058e438@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-16-hch@lst.de>
In-Reply-To: <20220415045258.199825-16-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 329d9650-aa25-4c36-bb1c-08da1ea2d25f
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB1815F3B93CAD76B7BC5687A4A3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 t6t+OjGUQ1OzaWpmgj6CRMw/oONXIm3UqcwYFA2T2rxL0gmi2gY70ddUD0K6Yoaibu9boOOIqd1sMsP4CbzKPtbQYwM1IuxsKpoKGXVP0M3JkttCknJs8GZDnhcxJgArTJBsyvlZnBqIbkRjFPCLFihtUqT6fV0hVQZNY2BxY2P5UAf5WBOR7I0LhKaVr/CWet93K7A7AXwUD2dYflyjdTdDHm9tcJPkTAXcir/2fpOqvw+eKW2jdnYm7P5aWyirx/3QPcRunm2hFEAIbKyvQGga+6KLFRgexCQ5D/Hih+3RRNOxKCsCZVGzDlSp8zaoD9hXaKgpW+yvFslrcRXDHv2iiP+jaeEB3zaZU7axixGIkNC+6QxEA1W099/MWYtx9krTcvxx8yUJ65Bwf6Vy1QkdXPjwMVMCaTTb5t8AHDKLW+c/4tXcEq+MDjI3vHByOqfK7z0Rd1Rly7qnjDQqcLdHpj9KWhC0LbbG4XgzwGQcQ6TQGEvliw6Y/kToovcBRrI4vpileZwct9UvYcC6islmD0DWSoaNjyHDsTwPQQt7e9A4Syw6quQC/ODj+xrkfNS4L70tSmleGz0qVUkKLjRyWJA5ficWTWVeyDq0jlaeehPKszMYOPXZ/mTOZgJlW883XsU9Ydwb48LBCXutALWEoeiS8UsOIPoHMn9hq1f8HO028tdO+IFYz4749b6dvSCp2+cNqJZWrdJnK6UGvaYqUvnP3sF6fcv0lB1FLdjUHsBTqH5cddPu7xcS/XyS0zo+QyH22wYdQqyV0xXOzQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(83380400001)(86362001)(31686004)(508600001)(4744005)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?WGF4eEVUSDhUZVgvZEFGYUtJdXZaMHp1VnQxYVNBZ0ZpblNkYm1pUUl2SEtM?=
 =?utf-8?B?Nk9KeDNZbHB3aUlYMlhoYVBIdzZNWE4zcFNBaVkxUUFYV0thZzBhRTRQYUNu?=
 =?utf-8?B?dlFwdXRpTFdwbmdZS3MxZDFrV0hFUUxJeGVYNkVnWkVEVDdmRk5QdmpTTjZa?=
 =?utf-8?B?d1Q4NysydjJWWmU2TkZJM2NPempodW54VjFzK2pTVWtMV3Aybi9rNlJMMm9q?=
 =?utf-8?B?ZDlhZ280cSsxQ3ZtT1owK1kxYmo4QmxOVit0cEhwQWsrYmw0RzdFM0JXSGtJ?=
 =?utf-8?B?QWFkVnVFMDJQdGVIMmRIMDVjK0h0bDc2UFIwS0k5bEcreEdjOTJJTXQyc2R1?=
 =?utf-8?B?YWRLZXFza2xabjFLU3dOSHdvSFJKOGZpc3B2ZllvZ0p3Ky85dUx3cVpHYmVu?=
 =?utf-8?B?YktUbkVIZUovMlFxY3FpRFQzUmxQc1BhY3loSGNWcmZ1c0tOSHdIcDVsN0Z5?=
 =?utf-8?B?VmR6dXN4ZnJLUm9adGVkL0pCSGtZM3ZmcURMWU1NTUVGUmRQb2JiUm1UWmFY?=
 =?utf-8?B?TUw4bzBaQ05jbXpqL0hxMTkzTytiN0hMT0NJclZwOWxpQWxzU3ZvYkpBeGVV?=
 =?utf-8?B?cWhiRHBCOHR6b2FtWkFwcWVkcjZRTlVTZ3hNWE9ZeDYxNFEzWHZadmVaYWRQ?=
 =?utf-8?B?TG5VZUtJVnVqZVhGVTJ3RWkxWG5MQWZHemNNMXhwc2hjbkRjbXRpUUMyVExa?=
 =?utf-8?B?c1FNOGhWcm41Rk94ZUhmWlE3M0xCOUZvTFpMcWptdlM3NzhLYzhxaDRMdVAw?=
 =?utf-8?B?UEJxRlB3RUk4a0g1SktnTUJPZjhCcitPbW1UV3BrU2NTTHVwN1Fpd2hSTDBu?=
 =?utf-8?B?Tk4rZ1NMOHg3THZyUXE3T215cGs0NkVSa2FxV0p6ZWhYL29Cc0hydHdoeUts?=
 =?utf-8?B?cjY3RHFYNTlQUFRGajA2YU5VMUJud1A5ZEhleXBFaVB3aitncWVOVlFIWUVF?=
 =?utf-8?B?SHZhTlAzemxBZ2FuQWhQcnI0NktpdE9XY0ZKRURBTDFWeWZmSXNDZTZkRENB?=
 =?utf-8?B?cS9pS1ovV0VmeFRwd1hqVXFCTjMxT3dockhqV1NWeXlxVU04cHNuUnhNYlZD?=
 =?utf-8?B?R2owcFpVbUhMZlI2L3c4a3dublkyTWdzZDQydFJKa04rOGVhZDBFb1JhdE94?=
 =?utf-8?B?dGR4bTYxUGljT1R4L0ZRcTBlbVRyVXZLTGF3emhhZ0VqcmdKTGVEbVlYWXdK?=
 =?utf-8?B?OVZWK3FWRlFqSEp5TDBWaldiQXBGaW9pVXVkRTl4YmpUUkVzS2tMMEZJYkMy?=
 =?utf-8?B?eEpxcVJmQUFPN0dHVTdPSXh6OG1rOE1UUXNRNmU0KzV0M0FkUFh0Z0FHV2Ro?=
 =?utf-8?B?dVAyeHF3RUh3Tms2OWJoTlpyM0pPR2tZcnllZ2hpY2NTM293a1dYUjRuNmNG?=
 =?utf-8?B?VldPK0ViRlBVTG9lTWc1bkYxeUZFZGx1cFoxZTd3YmVxeXJ3OHI3bElRMTRG?=
 =?utf-8?B?ZUduVXVtRzY4VHY2cHlYaTVVRGx5MVBqdkIxTDcwSXA0RC9GeDh4ZDVUeHVr?=
 =?utf-8?B?NUF1dnNwdGp5WXJJNCtrbTdPK2M5TXFEWXJ3UDJmTFZVaEcxYlduNWFmZ2d2?=
 =?utf-8?B?SXNSOXlXOGVjcUpiZmxDRGpaM2xEKzkrNUFPTnJHRllDMkIvN0tZNTR5bG5C?=
 =?utf-8?B?dEpDV0VwRU9wTDJBSnlwTEh1cVN3dzBKS0piN0hwaEVzSWU0a2owcGVBWWZX?=
 =?utf-8?B?QTBCS1dtdnU2OElqam93OFVRRHdaZHBkSXp4eWdQZlNkbXJkOTQzbk1sRmNr?=
 =?utf-8?B?Z3AzTDNTY2NLN3VRVDlqYy9FWlJWb25GZmd0SjF0U3ZoZGtqL01TSTF4MTNE?=
 =?utf-8?B?enIvNkpLUCt2K2hrZ3h3anM1SFBVVnFkTHphaXJMYWlxaE1ycHBxYlo5bEpt?=
 =?utf-8?B?R3puZ043TzlkSDlVSTZmQ1ZQblI1SjJNSlI1N3FXSDBWeUE0bzZBUElWWjg4?=
 =?utf-8?B?Q2Y1YlBic0RpdXhpcXd2TXBPY0llZzhxbWU1RzRzMk92OGQ3bW5yamp4NWhi?=
 =?utf-8?B?SEUyMFBqcDdaa29NTDZFV3ZGVGJjakF5aHFDTGZyU1RQSzZhYlU2d2pDSmpT?=
 =?utf-8?B?Q3NOVnltRDhndzJVMndLWjB4Z3VVSlVqSE84VEFEaGZNdTF0QVBSQXN0NFYz?=
 =?utf-8?B?amhicXhOdE5ybmxnSE5XbTZya3ZFSVcrMUhYSHB6cnJOeDBLdEZja3ZSeUdv?=
 =?utf-8?B?VTVPQ0g0Y1BNVFNJakNIWkl3b1VtL3NSSnVEV0pUR2o0a1V1b285VnVNcVVx?=
 =?utf-8?B?dkZKczUrK0JJOWlEMzRGc1JBVVA2dThsU0daUmtvS0R5VW10VkkyZkNGNjlm?=
 =?utf-8?B?THJORE5zYkl4enJBNTRrMjlYYWJ3U2RoV3lyWUFrS2VvUlhpOFIrZ3JQZ2tC?=
 =?utf-8?Q?9dpsVxsWYuGaBiJZKWvNwYXf0NoBW3MqzIHF/?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6CDFF86F90989C4A95462B2BEA592E1A@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 329d9650-aa25-4c36-bb1c-08da1ea2d25f
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:43:08.8277
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pI4Ug6p8HtKxYGGTRxGsdbryu83yFMwivmnD9Bi4GdnIIxiVGCQx5DSYPhYLUiIiFyypc2wCWvLHLPzmgBetuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEFkZCBhIGhlbHBl
ciB0byBjaGVjayB0aGUgbWF4IHN1cHBvcnRlZCBzZWN0b3JzIGZvciB6b25lIGFwcGVuZCBiYXNl
ZCBvbg0KPiB0aGUgYmxvY2tfZGV2aWNlIGluc3RlYWQgb2YgaGF2aW5nIHRvIHBva2UgaW50byB0
aGUgYmxvY2sgbGF5ZXIgaW50ZXJuYWwNCj4gcmVxdWVzdF9xdWV1ZS4NCj4gDQo+IFNpZ25lZC1v
ZmYtYnk6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPg0KPiBBY2tlZC1ieTogRGFtaWVu
IExlIE1vYWwgPGRhbWllbi5sZW1vYWxAb3BlbnNvdXJjZS53ZGMuY29tPg0KPiBSZXZpZXdlZC1i
eTogTWFydGluIEsuIFBldGVyc2VuIDxtYXJ0aW4ucGV0ZXJzZW5Ab3JhY2xlLmNvbT4NCj4gUmV2
aWV3ZWQtYnk6IEpvaGFubmVzIFRodW1zaGlybiA8am9oYW5uZXMudGh1bXNoaXJuQHdkYy5jb20+
DQo+IC0tLQ0KDQpMb29rcyBnb29kLg0KDQpSZXZpZXdlZC1ieTogQ2hhaXRhbnlhIEt1bGthcm5p
IDxrY2hAbnZpZGlhLmNvbT4NCg0KLWNrDQoNCg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:43:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:43:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305492.520545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEkQ-0000JZ-GM; Fri, 15 Apr 2022 05:43:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305492.520545; Fri, 15 Apr 2022 05:43:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEkQ-0000JQ-DG; Fri, 15 Apr 2022 05:43:58 +0000
Received: by outflank-mailman (input) for mailman id 305492;
 Fri, 15 Apr 2022 05:43:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEkP-0000JI-4k
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:43:57 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20626.outbound.protection.outlook.com
 [2a01:111:f400:7e88::626])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 098e4e90-bc7f-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 07:43:56 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by CY4PR12MB1815.namprd12.prod.outlook.com (2603:10b6:903:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:43:53 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:43:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 098e4e90-bc7f-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j7V/a/shH/50ILjNRowsunIUKIrGOFQk4PtG3aqgLufUl3eo9FFXwRzTWPP0RHT9QEPFzVuAfsmM6PCRYN5uE0isK63LlyeHjOY0AhybDM7EYaEv313h0B8JQcoGkJ+P8ou4SSZ68myiiO2W/zAJlZIMyEJugOt6pa+EHrzzsdEdgeXfyQ2hrnQuoV+qMhRt7jvZWTcwHRViaer362s1SoSvXNtAczEOt7Su+OGs3u5WCNJHPDlWJpBlIIJWUsCudfYCIgJ86AtMcbg8PUDiz5JxKqcz1mVsoX3/ySLAnqbhQxP+XN7M+IT4v0LILgblyOpkIBzIt9jwEGjNnTbO6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rBkQBjRSn9XGMGFyMCBwAEJr7XdtAp3lo0AoSBJHgvo=;
 b=La4HVrWc+fl6CdBxWbYFJDk0OThR0snei0TmD5q5HBftn4TOFU0Sv30q9DPkrYRZP93DneBDXzStfiizo/VaGF5Dq/BIxFJF9Y3j/RLEXqPmQWS2xJmz76k+Je7dYfNX3BwNEwY3a5ns6xpYYd0JFRi/VQDGiSMFpWPLxr4FSqEsaLnl5xTh6/hI899c4xmOYJXwKh9mMzz4SGPWIaxNU9frp3hdE+4hCh/pRxbUAhElptvjZKAxwao31fVwnoZaSyHoiat4R6Zs54X3v5V2I4PIsfoCi8ET5ZJEeGoV2kMrdTpuWI2kHG6nXbcpIXbRvnlchf0h5R3iS4OKqP7Hsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rBkQBjRSn9XGMGFyMCBwAEJr7XdtAp3lo0AoSBJHgvo=;
 b=TD25AIYRb8iwCA9fahL99Olp9+/Hgztmyc7Cke/aNxVFMkYqgPmEKIa0h9K26Lizf8FQtbpJ6ZrI43SRYXUa/IEilbPb/yWrsMWKkvVMTb5eGrmKtloM/HeeGoLG/okNV7PxpECiAiiYRo9oQlbfjDmkiuiTM6mgxRU4PVVmr6RXqlPoiVfxAOLCq44bzbjr04GIsU+i+wkYwmXqFd8z069t2I0ex/3qnxQewZ5y7zNzeShvVEPpwZo9kcCoprtQzOE532RcrC4q5AQc5fs0lnzBrqkQUccvapN4PmMnK+mDecb7Qq3G0+gQfrs7UHiuHRUHtlqVG0C/W5DVaZuTUQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 16/27] block: use bdev_alignment_offset in
 part_alignment_offset_show
Thread-Topic: [PATCH 16/27] block: use bdev_alignment_offset in
 part_alignment_offset_show
Thread-Index: AQHYUITgGyb6ZxOVoECvHtCH20IFIqzwdokA
Date: Fri, 15 Apr 2022 05:43:53 +0000
Message-ID: <d4d70cec-aaef-27bd-4d29-7382a740f192@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-17-hch@lst.de>
In-Reply-To: <20220415045258.199825-17-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fadb5741-c217-4402-81c7-08da1ea2ece5
x-ms-traffictypediagnostic: CY4PR12MB1815:EE_
x-microsoft-antispam-prvs:
 <CY4PR12MB181587392FBC362EB9BA46BDA3EE9@CY4PR12MB1815.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 /zPE7EFfZCRyhrUuJ8xZg9ucWLWFwJmvS3SCCy3Gaw/2yxq3SLG9KlcHIP+uThF51l80EN6TZSRiTdQYGcRu0jCdhuALoVMKwS8W0pRofsGVFS2xSGj41t91O6b3SGy+xBhR0pwJvhvExxhfgFMeJv0kf4NLE3kzDlCKkQiUSHe9UUFRHRiu71HiTj9048fpgx+LMHahpSNX93/a0NzTVZSI34Jnz76e3Zbz5izJ0Btbe01tt33GWjvGm9MTZSXMrbEGKj+kS7mHGob6GbOEfPMtU9msKPzYGpb02V1m4UiygUdR2JLzyHKmSZ+Qk2YRKEOWnH51jj8kUevfIc6zuDr6NdNQR2dBO4u/kxc3pW86qOc/ly7+l5ASnifdFRNBlGObIMk454XaCAJCG8Lb/FzQnENxr3ByAWVaZjA2UUOU54L09Sro2bC+uf2XcSeLQgrUF7ONhLnwI5Fijea+cZY8H4fztMTlN3TZ/uEd9ApUgyy5udU1p9XTYcxj++ua7g47w3aeX7Y5VzkSGbmquc4wRnCJBKrD/sHPCbPVgvd6yujzP41M6MslnU2d/EfCPWdTo3HBEEduFrUZjh+X7HW8TYgvVDdXfTH06HgyG4GnRRnI9J8fUjx0QN7t1TNLvC52WnAi765Nyg1VPPBrl3i21BYZ901pgAkXDGXI2t1yUM7IV7ny9/ixyZZKXV53DwJDjsiEuGwzKQpZYABsQLuZZnLaLSXEfn2lkfqCxswy/6XXTaLwC7+nDFr/m7bYPN/eTEB9T3cxQN1Vc4nNqg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(8936002)(2906002)(91956017)(7406005)(5660300002)(4326008)(66556008)(86362001)(31686004)(508600001)(4744005)(38070700005)(6512007)(2616005)(186003)(53546011)(6506007)(36756003)(66946007)(66476007)(54906003)(110136005)(71200400001)(76116006)(6486002)(38100700002)(64756008)(66446008)(122000001)(8676002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?QkhLTC9Hb1B6S3FOdlFHNnJDNWdpYy85WDdZZWFmTW9PalFZSXZBbGxNeDZR?=
 =?utf-8?B?OUI4WFg1M2twZmZuS0d5b3VmM0RJZm9KWGQ5V2VPUXlxNlFKa3VjZVVsUHRE?=
 =?utf-8?B?aE5KOUFKRXBHb00xSjAyUVhnUnJ4VzBlNlR2OTVqZTZCS2JlYkJaNXFmZk5W?=
 =?utf-8?B?QWtTS1E4ZWM0NkplMkNnSGJuYXEzYnZDRCt4UXpnN3QvYllydGZZS3JNUFJD?=
 =?utf-8?B?dzlya2l1cFROcHB0WG50YnRmOTUxZmtFcWJYYkFxR3IrTFJqTHFTbXdjd2pS?=
 =?utf-8?B?UHRhcFA5dTdGdTV4dGx3aGtwemlDbkxCYjJPY2Myc2tpYS9SdzdwWlBIc2pR?=
 =?utf-8?B?UDMxSUpKWE9qYzRmaTdKUXh3MjRyOWhXM2ZGNHdMajR0alRQYzc0eHNUekdm?=
 =?utf-8?B?Z1ZnRDVNUldxcm1xREFydEdSWnJJSitIZnpMMW9odGJPOEsrUFZKYUhGOTVT?=
 =?utf-8?B?WndnNG9hb0NPb1NTdjJwZDJNUGl2NUpSWUhoQjMxRDN2dzhOd0s1ckdvaDRP?=
 =?utf-8?B?OFZVQVRSUS8wVndOTytLcE8vYnZnQ244bGR1MHhvWGR5MFBoa0NVcm1DTVFH?=
 =?utf-8?B?MFBFWUhEeERFZmlINEpqV3ZPZ055cUVMcytyYWk4MEc4ZXpZUGtaa0l4YmFq?=
 =?utf-8?B?cVMycGhwREZhZXUyNkNqblZ1YnNMY0RBczd4djZJSlFCWmlNZGMreTVSL1l2?=
 =?utf-8?B?S3hDWElZaXZWYjJQQW1jWk5BTFN0VFhVQTRla1IrNWdKeTgwdTBIb3ZVOG9M?=
 =?utf-8?B?VFE2Tkp3VHV5S1ZPcXIwVUdwSDJ2bUhMMG9yTWk2VlEwQUpmVWVNNnJ3Rzd5?=
 =?utf-8?B?MjlzQlA4TVd3Y1ByVWZyKzZWQmQzdHp1V3kxNE5Zdm9EM0V4TjA0UVNoWmp2?=
 =?utf-8?B?czAvdUpiMERNeTU5UldlTlo5NEpHczJmcno5bGxaRXlzTklhV1lpVXU1T3JL?=
 =?utf-8?B?ZG90RzJKcHU2RCtwNDIxWWVqSjNCaFpNaXIvaHNZak9QOEVZVE5UT1kvTEpl?=
 =?utf-8?B?QUxhSlBNb3JUL3NWTHcwNG5OdU5haWdLd1BndU5MZTVkTUloRDU5aHNaeVZL?=
 =?utf-8?B?TEUzSkpaUEVTcThhdnI0dDVaKzhSckt2NkhJK25xSUZLbXhLVzdEcTJuQ1FB?=
 =?utf-8?B?ZWs3TFE5SXV0RXBWT3dXL2RLOGVVVFhEcklFbmRjU0NheHVadmRYSjc2VVRw?=
 =?utf-8?B?bHA5OVh6cmpEbjE5VnlncEE4UUgwemw0N2wrRSs0REp6L3o0bjNQRFRHYUlr?=
 =?utf-8?B?WGhqLzJJdlhoMUVjcTVVUm1WR3UvRDdra3BhZzQxK1VWTTd6d0ZiWDRhZjUr?=
 =?utf-8?B?NitvS2dtZExkZzVvL0prS0tPQkJtdnFjNlZ2cW85SzAwZS84dUhhR3NzT0VT?=
 =?utf-8?B?WWErM2hId0NrTkZ4QS84RVhBK2tnd0tmRXVsYjZrR3VwNWkzNGVmdUpFYTdl?=
 =?utf-8?B?NlpsVzBTbFlVYy9xMzBYUFB1a3JPRFl2QVJqRzFJWFl6ZjVSZ2VyQnZMYjlv?=
 =?utf-8?B?czhiZ3lZTmpzTXEvOFAwNldYb0FqYW9pWGVKZWkwckZOV2F4cFBCNnorcWxo?=
 =?utf-8?B?T3hxaC8xYW42SnFjbmJVZ3FaYXYrcjZiLy8vU0tLcXdTMzAwbUFhbGViMlhp?=
 =?utf-8?B?QjFaSVNhdXVvaUFvMWtDMnlJTG9HeHNkMXpXaStQOUpQY1RUbHpJN2UwM0lT?=
 =?utf-8?B?ZmcwcndhQS80SFZKY0t4SjVqWUpyNFJqU3BtMUVYM3ZjN1l4Tk5wWnZzYkxR?=
 =?utf-8?B?YlgxcTV1bWRMUEdMWWQ5MytFUHBsMXZSUXRwaENTaVEwL2pNOXNvYjJJOEZS?=
 =?utf-8?B?eHQ2dm1ySi8zZjd1eEtXWTFZOFFwdlVobitnUS9yaG9nNHR6eDA1Tm0xWkxt?=
 =?utf-8?B?SWt4Um9NMmc0WkFsTGFIbW5uWUY4Wnp4OGFCZ2tpMnQ2VmU3QVB0MVQrQ0l6?=
 =?utf-8?B?NUdmeVdPQndjQVRxWVlVUSttOE1CM2pyVDBoMGdObE00aDBxQ3hZNnMvRDgz?=
 =?utf-8?B?MGpCT3hNL1FPRkRJZEJOdlZZTXN3b0hSOC94VGYwa2lENDJLNzhsbkdycWtT?=
 =?utf-8?B?OFdFeldWWEpFN2s2Nk1wWTE1ZTZROXVPbWl2R0l2UEYrWUN2WkpaRG9Zbzlt?=
 =?utf-8?B?S3BzM3NmTjdreEFPMlIxQUh2dURrK3drbDZ6UzZUSUg2amNiZ2tLVGkya0d1?=
 =?utf-8?B?TDErRm1PTHNrbnRuQWc2M1BEU3hrSDNVQ0pyYzAyVFJZLy82ZHlrY09FOUR0?=
 =?utf-8?B?M2hTb2ZOUnh5UWN3c3cxK1o1dGpBMFFpdEpLZzJubGVDTGhsMEhPOXRTZEE4?=
 =?utf-8?B?ZDR5bkFrZWlMbEUwRHd1RFdybXdURFg5bGw1NFNvRzhEV29zTFZIL09qZnJY?=
 =?utf-8?Q?AYvHXapXcoGFw6Gj5LPtzLlzXjgd4w5ny2Ge1?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <082F7C538FC35349BB8BF71526006F64@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fadb5741-c217-4402-81c7-08da1ea2ece5
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:43:53.2939
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z89R72UQaC+/+ZifCAazwywTUZEAu78qSqfzKG51E0QeCoJkksyXq4ipp5lT82IG6zIQc23xZHHhe3Sr5hGvgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1815

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFJlcGxhY2UgdGhl
IG9wZW4gY29kZWQgb2Zmc2V0IGNhbGN1bGF0aW9uIHdpdGggdGhlIHByb3BlciBoZWxwZXIuDQo+
IFRoaXMgaXMgYW4gQUJJIGNoYW5nZSBpbiB0aGF0IHRoZSAtMSBmb3IgYSBtaXNhbGlnbmVkIHBh
cnRpdGlvbiBpcw0KPiBwcm9wZXJseSBwcm9wYWdhdGVkLCB3aGljaCBjYW4gYmUgY29uc2lkZXJl
ZCBhIGJ1ZyBmaXggYW5kIG1hdGNoZXMNCj4gd2hhdCBpcyBkb25lIG9uIHRoZSB3aG9sZSBkZXZp
Y2UuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4N
Cj4gUmV2aWV3ZWQtYnk6IE1hcnRpbiBLLiBQZXRlcnNlbiA8bWFydGluLnBldGVyc2VuQG9yYWNs
ZS5jb20+DQo+IC0tLQ0KDQpOZWF0IQ0KDQpMb29rcyBnb29kLg0KDQpSZXZpZXdlZC1ieTogQ2hh
aXRhbnlhIEt1bGthcm5pIDxrY2hAbnZpZGlhLmNvbT4NCg0KLWNrDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:46:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:46:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305506.520556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEn1-000157-2W; Fri, 15 Apr 2022 05:46:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305506.520556; Fri, 15 Apr 2022 05:46:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEn0-00014z-Vc; Fri, 15 Apr 2022 05:46:38 +0000
Received: by outflank-mailman (input) for mailman id 305506;
 Fri, 15 Apr 2022 05:46:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEmz-00014t-PF
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:46:37 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on20614.outbound.protection.outlook.com
 [2a01:111:f400:7ea9::614])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 68d9b905-bc7f-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 07:46:36 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by DM5PR1201MB0169.namprd12.prod.outlook.com (2603:10b6:4:55::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:46:33 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:46:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68d9b905-bc7f-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RwA28g/vQTNduBROKV754mUMzxIhkxw6nhWNj9LXK3pIMDgmRN7mCojVpzi8zsQoP1Yq3CEnrn6/DNPk2DDYFaZPRGAwNFKwn1Pq3G3w7dpaywH9QGkj11HrbRneYJ5bznkbVLzD78VcXOXoYrP2bakk/PGh0VwJA4Jf63GlolTQLsL4e4ILrTIhkx6BOOL8g9WCKMgv/JADC39HYFKFJHR+Xs8Z4VJIKHgWSU7Elhu3rKxYf6cfyucUT4kTaG/cfr1acIY5lHwA2ZbGDGD1PIRBCgj/l70+kicabB6oXcB+88dKvQD/fcQLbNlbrQdMnBiZHJQOzRIXF1bNzwmhow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ll6nOnUsFN4t09CavEjEFdgdIftb6EE+wpAq2T7XWI8=;
 b=lMTWH1XE/HfLoP+K10KfKTFl7wnlFMUUhM6ymMXSZoauF0qSaabvuyr6VHKB1e0qtc5D9oSNZpOgvS9SHiJZ5I/55B94I5TUERwQyzvKkDT/pFAIhh4NvukL20JDy121zF3f/val+9tGkpVGKW58Sxcw4qimPomTzT5PI9ni0YcAj7QYz9pprCA1nEcusFpsaPjaS8Njgb4rcrkTCBzHJFz0Zp/2nWQAWiE4yiaWSo2d8oxbBTqtzofw4/UavFaApVVBo7xEuOasRSnClPQhFlz46d5GmdB72ALmMZ5V64XIcEvthNEg0cQi3Af/HFUSgoc59EIBBpAcPs2nKEkQZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ll6nOnUsFN4t09CavEjEFdgdIftb6EE+wpAq2T7XWI8=;
 b=ppRLTkwLk6uegRJ2kfkGhWth1BBuonhTnRrzZ9Un7tjuB0GULPSRiaczQgUkJsyzpYnevIx+ZFRiDRhQIR/udWanzMKbOuvh6xNUzIgKfw2LeV3XTqYPKNm9KrNPUr/EqJ+v8Vu8lBWcpvEWCKdFTiZu8/Y/bpycbLdnGnMpP74amXzuPEo6m2kAo+rfWauBp/tVU7gLcfg+1KAVsP7A4GLeLtKoyI2G+ClrLlQuWeRfEigiQd6QWBHxQYpzbWto1yEQT43IV17ysfDx3I713iJzzSIELWtCGagp+9269anNe6S76f29QxYfpaZYBOBHZk6za0WIxP/ECbVELFUhpg==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>, Coly Li <colyli@suse.de>
Subject: Re: [PATCH 22/27] block: refactor discard bio size limiting
Thread-Topic: [PATCH 22/27] block: refactor discard bio size limiting
Thread-Index: AQHYUITpUnTHchxryEq5+LCXZWuKpazwd0gA
Date: Fri, 15 Apr 2022 05:46:32 +0000
Message-ID: <d3f73a4f-0d45-6627-7878-9b5acd47842f@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-23-hch@lst.de>
In-Reply-To: <20220415045258.199825-23-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c9b589c8-cb4a-4ba4-a30a-08da1ea34bfa
x-ms-traffictypediagnostic: DM5PR1201MB0169:EE_
x-microsoft-antispam-prvs:
 <DM5PR1201MB01695F76C1A4B9A7D05A3F7AA3EE9@DM5PR1201MB0169.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 VOFzXF/s96NsYbBCYoyP+Oqyrbo7ZvySarnLRF7ZTp6sy8qxvAl38W1b3iHUqaUeX8qz3GMN+qFT0JGb0/6aWm9O+1hhIvw77xbO2yTllmJhR3Lt7TRH8Ih/6krLUtCDg/KLCzdP6EtLbWyHqJsFOBk9QZi+Jdf7ktdltvMZdfTGcqg/GtsHXgwytDp3/3BHa7RZv4CMTRiforweHkzX6rhZQUbhHXfX3qgCVX6xsn3qBMqbPW72/h3/tu2p+WSmKmb+LaYHADTssjdesb9wusH0HnmLfZC9hd55NDHkhwSEJjghkUvRMFQEsh1KvVKoQrtB4DjUg0ZSApUd63FFA8xt4OcLIcOO4PsN/sjBxXjGQ2cb5r8PVoRu/yNjyv84c9yC8f3gy1R3gnNW1Dqu/ZUkIvw9SiUkDg6U7dY8UbecAYBhZRsHGUtUViHiJYON3dSfvKaGX38RUIGG/yPM8FZYYuawjdoDNL12/MMR+hJLoT/hZdl1lu1rPaZ4VRRpoA1UcaS9qeldpb3c4xeQpV8TgRcsZg90HoAPRNpCSKfJSJsWhFB4kAw1XUX8sXUpXgykfyTR5h1H6A3x3h5VO5n67XpNrSc2Tyf40kCZfPcYlFZKOOT0O/4XuuqIY19aXpXjjtrIodvoM0aI+cWoOvLmovj0zTEANUyleszRXiElvmrFroYc9epemyTr2r52FDFSLyKlBX4s/B4IOrGsWKtBYUWQ9RaofryxfBm47b5nk+dodGVkY4HSgZN+2dDventXpgL6bl654kMamsVYVQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(110136005)(71200400001)(64756008)(8936002)(83380400001)(2616005)(31686004)(2906002)(38070700005)(316002)(6506007)(53546011)(6512007)(66446008)(7406005)(122000001)(186003)(7416002)(76116006)(66476007)(66946007)(91956017)(66556008)(508600001)(36756003)(5660300002)(54906003)(38100700002)(6486002)(86362001)(31696002)(558084003)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?QVdCWElBQWNxMytqeUo1SThNS2NFL2FaVitHUUNldkxvMDllVVZIbXJhWEhP?=
 =?utf-8?B?YWJWNzBjSDY4TTZQVCtNTXlZVzR1bzNOalJkVVZwTXFtZUt1ajFleFZBUUFr?=
 =?utf-8?B?WnRUM0ZlYU9YOVZ0bWRLaEZKY2MzbjRYVlFuaWliMEZpRkpwOWVmMHRGUU8r?=
 =?utf-8?B?R3BORVRldHVHMi9HVzlxa3Z1Q1JzUmwvYlUwdVhKK08yRTJCeVJ3L2xCUHBs?=
 =?utf-8?B?VHhpSXh5cTVuT0RPYjJZWHMxcVJXV3FxZjQ0QTc5Rys2a0Y0SWgzazdZY1Jy?=
 =?utf-8?B?S2NyWmIxM0VIMFBOWjRVUjlkeUR6VitGUXRiZElSTEQrRXhMa3dOT0ZwdmZv?=
 =?utf-8?B?aGJ4S2pFQ3N5a21FZGR3V0wrOXlTQytVamVOb000cDZ1K0hpL0NMbDlSdmlV?=
 =?utf-8?B?VG1CUXp2eHRud2d2STJxNVYxZllxbTUydFQ3ZkV6S2YydXAycVhDL0ttbEdo?=
 =?utf-8?B?V0xCbi83cW5MenBkWG5vWnNKQVl1YzdDTi9lelljK08rcjdwMEMvT0p4NmpQ?=
 =?utf-8?B?cE1nUjNBOUU4d29MeGxYRFNKYTRsMElKanNwSjdKYktpa0VRWXJOK0tEODJD?=
 =?utf-8?B?SGNkaXJKdlNZQWdQelpJWTlwdStHeU1sekV0d3RPOUlrbHdCTGV1UTV0Ymkx?=
 =?utf-8?B?aWg0eXdjQzhGK0FkVWkybGs0eTQvOWk5UkJSRGp5ME01dmFqdk5QME9tTHdS?=
 =?utf-8?B?a2dNeXZ3aGk5em90aUVSeEdGcFg0SldKQ3hOeWtoQXlFQk90bzdrM3o0R2Z5?=
 =?utf-8?B?OUdGdXJ4N0w3eXlRQWllSWhJR2hNZ25MTFlsaE80emU3UU9WcFZlTTU5eXNQ?=
 =?utf-8?B?OFZ2TUoyY2Nkb1UraHVxY3VlMDdLNjhBUWdEUzk5ZlRhTU9iczRmSjA1c2hC?=
 =?utf-8?B?Y2lqSDdJa2NXclZBSzRYT3RYVlNSQzVJZ2V6RkhadytSRkxzQ1NWbFJUNFAy?=
 =?utf-8?B?T1FlR1FPckR6d2g3bjJWNXl0emJVK1NVYUVaakc2RElBSTB2NDB6SDNKL1dp?=
 =?utf-8?B?MmQ5TmM1b1ZQVTkyVGZraXJaNHNMVkFMeXN5ZGUwMFdjWUZvZmZHdGh4ZmhC?=
 =?utf-8?B?K2JnQjNseU5TZXQxd1hTdHd6T25KYUFsd0h0ODhZcUpINFB0cFBtcGp0L3Qz?=
 =?utf-8?B?Mk5GaXBGbHJVNUJnMCttTm0wZUEzM2t5T0cyLzhOMThyRGpwdG9xQURzMnFF?=
 =?utf-8?B?dDRJRm1UaXIvbUs4MWRQemM2SERMUHI0aDVndEROcVRNTFRpbFNkYktiUE5P?=
 =?utf-8?B?WndUdDlYUW1EeVR4UE85Q0M3dlVza1ptaXdvblVlVnhJbC80S3V1b0Njcjgy?=
 =?utf-8?B?ZnFtKzRTMU5KNEx0ZTR5ZUtCY2ZOcjdVZ2N1VXV5eGJ2eThLbEZaWkxQK3d5?=
 =?utf-8?B?UWQrWS9yRkxISnhPbWRQN25jdmFOSzc4SWhpaGxGQjA2bDFIaUFlL1ZjeEkz?=
 =?utf-8?B?OWxOWEVCZVZwMjFVVm9XeUVIZ3VYVWIxUWphZTMvb3Y4eU1URVluUzFUYTBX?=
 =?utf-8?B?ZkFsVTVqaGJhM1VJbFV6UEE2MGlad2RxYmtuR0tiV29PbU1BYzM5cVZIZVV2?=
 =?utf-8?B?VG16N2NlQ3ZBWk1tbjUrbXVOTDFVY0d3VEMwRlg2N0drTTUvU0dEd2tCZHo1?=
 =?utf-8?B?WVBxT0Q4RFdLRDFKVEVDUGxHbzBVQVNtVmI0cG9HVzhzTWF2RllZRXVybEZt?=
 =?utf-8?B?TGNNNkRLMUZORks3S2w1S1dEL3R4QjB5cnBHUktqd0VVNjlRc1UzeUxsTXpT?=
 =?utf-8?B?MzN0MmdWODMySXVwOTVFTHJxcE5TenVCdUhjemliMzdlbG1SNnNsMjgwbDJZ?=
 =?utf-8?B?TWxRZjFucURhZ1VXV1Zmd3B5VW9HRmdNcnBvVS84YWRBUW9OdGxzVzRFaWRH?=
 =?utf-8?B?TmV1Z0VHSFU2amdPNkxoODBWOUlRaE40Z1hVTUNpNDU0SDIwSkVDYlpXdys3?=
 =?utf-8?B?WEs1S3JMRXNjVGJpMWp5czBMTjZ2RWJzWExyS1JkZ1VCNFQ5TlUxSU93c3NP?=
 =?utf-8?B?Mm91WC9HRmhSejBlRWJFd1F5TnlFcmFQNWdOdDgwR3JvTW5yTWtyOFFSb0Zx?=
 =?utf-8?B?UTNDaFluaHBJU1Zwelg3VEhYU3ZjdmFlallmVVRkQXhjeFZhdlpWSmpyMEw3?=
 =?utf-8?B?dmliaXV0b2V1UzdXbmppby9YUDZVSnRHRTNRaTIwQ1N6Q1pTZFBtamdlY3ZW?=
 =?utf-8?B?bUorTXBOZ1FNY3krQWkzdVJHWnFJSStBcG8vTm8wSHV1TEd4WkZhRk1EN1Fl?=
 =?utf-8?B?MzVKWTR4S2lMYTY0OGtaUW5oUHNrRlBvVkkvUjB5M05teVVnVExvdGRjV0Nj?=
 =?utf-8?B?SElQTElOcHVCRnpKQVY1S1NEUEtUenRhbjdRQWlZWTMwSDIrT0c2UFJpT0t4?=
 =?utf-8?Q?R2jwV8YoRmuWle80=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5C40943C50889249AD34D58B6AD3A631@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9b589c8-cb4a-4ba4-a30a-08da1ea34bfa
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:46:32.8003
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +ASbusO8W34q0zkWuXk1qiivnBz95QaMhMAdwYhU6fcikvNpkn9x0Er0VaGbVy82Z3hkljoFFymMKBrM9EwUVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0169

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IE1vdmUgYWxsIHRo
ZSBsb2dpYyB0byBsaW1pdCB0aGUgZGlzY2FyZCBiaW8gc2l6ZSBpbnRvIGEgY29tbW9uIGhlbHBl
cg0KPiBzbyB0aGF0IGl0IGlzIGJldHRlciBkb2N1bWVudGVkLg0KPiANCj4gU2lnbmVkLW9mZi1i
eTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+DQo+IFJldmlld2VkLWJ5OiBNYXJ0aW4g
Sy4gUGV0ZXJzZW4gPG1hcnRpbi5wZXRlcnNlbkBvcmFjbGUuY29tPg0KPiBBY2tlZC1ieTogQ29s
eSBMaSA8Y29seWxpQHN1c2UuZGU+DQo+IC0tLQ0KDQpMb29rcyBnb29kLg0KDQpSZXZpZXdlZC1i
eTogQ2hhaXRhbnlhIEt1bGthcm5pIDxrY2hAbnZpZGlhLmNvbT4NCg0KLWNrDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:47:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:47:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305510.520567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEnf-0001c0-F7; Fri, 15 Apr 2022 05:47:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305510.520567; Fri, 15 Apr 2022 05:47:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEnf-0001bt-Ad; Fri, 15 Apr 2022 05:47:19 +0000
Received: by outflank-mailman (input) for mailman id 305510;
 Fri, 15 Apr 2022 05:47:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEnd-00014t-9D
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:47:17 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on20609.outbound.protection.outlook.com
 [2a01:111:f400:7ea9::609])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 80ba34aa-bc7f-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 07:47:16 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by DM5PR1201MB0169.namprd12.prod.outlook.com (2603:10b6:4:55::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:47:13 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:47:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80ba34aa-bc7f-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nE4sKdPGoMABYZ4kAMLAh3jVni5uF+yjcAUUvY+7dljSFk1iu/l7LoEHsL8JAltU4GNvNuWw0O0Z9+OYtOe8MQu5IA5bcDlLOU9wQ0HumHQIF2vPzOtnzLJz2A6JUj4jmsTEZCtZXSNDEXp4Ov+SFMhUyAdYdaPf+r3NEwJc8WmOXZ9gHzncTvxphGmPelLoofjND8YGsH+4QjBrTvHqT2sTYGrcqXIWxFUhEGP8UX04mHTu38x0CG5cTN68fPbpSBo4c+PVePg74x0ZdinVtTe3BILAhn6pVoXT8MfN2vyKsUghPYg+g8hkgjaq37eli8KMDo4B+gN1gKMRcfmzIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KdzVxQLhOIzwO3EIom1scI2CEKlGZZ29ZfmeWI/0Tzs=;
 b=So/eo19GlMrFYLgo1xaGggzFalmv8kNy1r34JUwZQoMCp9ZWiiBkWalID8+uinkoQNVLiES1NxF6rNC+CAjHaJk5p4+IdiTTpUq0e1jhXIRJFCvcdsFYW603S2aHAB942QDYXrCO5pPXSeaAgnDjKHEnMtTO+O5oqZ9zN2SNYRuoYJIqcvvPs+3eLDICIWswDWEvdE7yX6yG+pOwJc6kZX4LqPpZetKx9nGpGEfDrkZKhjI8qtj28qaSmx+vwyMcDP5rFhMOOs1W9Py3dLTuaPp+XAl+EmEcaXQtBEMDQjvYOweUfZcYa1jdYJEVDugGNah766Gey8FP1boGMjdw5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KdzVxQLhOIzwO3EIom1scI2CEKlGZZ29ZfmeWI/0Tzs=;
 b=HAcwx2b4PXoa4zPnYgVIEbCtts9d7sVBpXDyaHqzXDR3VcfBub5R72rObkzotyIEJEQZMAdvbp+1UZSk6FYN2tvzBxBnun7v6RbD1qVyNdK2jdYsj3VJCL+Z4Y0SlfFLbZG1wsqKrRMUAdKkvc+U74nFHzLFwRepcSQh2PDvgynZ+6bg6fY8yYRtAC1ZCJlFp/971+W+s0PcBuS+dZzi89lnlBKfbMbxYX8hRxKMl5x3pKpTZPk/jNyslSRVFcIzJ3B9uMiG7HvVKDBjo7xdJ9yx9ax333Aj4goLKBrY97BONbulZtk/giNDMNXel1JnkyeQ6N2IfbvX3nsw9+ngtQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?utf-8?B?Q2hyaXN0b3BoIELDtmhtd2FsZGVy?= <christoph.boehmwalder@linbit.com>,
	Coly Li <colyli@suse.de>, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 23/27] block: add a bdev_max_discard_sectors helper
Thread-Topic: [PATCH 23/27] block: add a bdev_max_discard_sectors helper
Thread-Index: AQHYUITqaOcsO5gg2k+4WC+bePE7r6zwd3cA
Date: Fri, 15 Apr 2022 05:47:13 +0000
Message-ID: <3583727e-1260-0907-1b18-cad774750ed0@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-24-hch@lst.de>
In-Reply-To: <20220415045258.199825-24-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7b895042-ef19-401e-8e43-08da1ea363f5
x-ms-traffictypediagnostic: DM5PR1201MB0169:EE_
x-microsoft-antispam-prvs:
 <DM5PR1201MB01694CAD0B3BD74D7D4B1F4CA3EE9@DM5PR1201MB0169.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 KSrPFGpoP9v40ktuShVXOU9KDNwv6XMxXqvafCumrfEP/nwLBaXfspxM+boucxgrDcsj/8XwlaQFjO7+BpocTlRbDdUNJM8wd6gmFwBiQDVugRc/j+gJdRmBbpsWXRPCVyhemC+W55DUoYOY6erm2JxtW0Xa2Vwyvvh3QJ0M/7QUd/CilYqG+8M/z+9MAicCBmB5gA6CE2DFZc7A4LOL1eILj7eA2+AFFE+vdNfc3RvrkmYaozYHNqLPZ41X3c1m+/AIUtAoLpV9Ddxvs2gijOQPD/bjbHrdiayIQADxTMNv+noNS1FjzOlp+uuHXWb66bUa9ef86Vu6TG5mXVBOWPjACx5XrRQ8r5tfcirBvMYSXejuVDw2JuKDZWfPDn2P1lZcgeLvDfsK4LtvWJ0TXoaaGeI0GhqLr6pJdG5S9x1JYr1ke5P8upOHUy14kCLDqk8s+lmEkhKM0fI2H206UySO4iPs706GoPRJbS39EwiI2le2vjhXDZlHn6FZ+f9Cdn4KV9kUMP6PRZ5kVH6U6OT78DJqqZZkzAQdzmaTnKYDbfhoFHt8JQod45yAyIGlGzht1sQ8GPDUEFNNdOkbaD6XWb3ooshOCWtlaKiMtdrTfC1e/o9yuFrScsQgEDv5ql+6/ZdDky5daEoES2X78q27h1efGG5xI1ASD2Sab8pZsJ6bxp5k0AmFhmxMnklmfxeP7deAjoBbmR+fD+G6yknzBIV3T8tYwcNOhV6jdtBzUkY8Mlt3FDoLcHvVTVYuoftH6Wb7L7AwHQzjkoCh4w==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(110136005)(71200400001)(64756008)(8936002)(83380400001)(4744005)(2616005)(31686004)(2906002)(38070700005)(316002)(6506007)(53546011)(6512007)(66446008)(7406005)(122000001)(186003)(7416002)(76116006)(66476007)(66946007)(91956017)(66556008)(508600001)(36756003)(5660300002)(54906003)(38100700002)(6486002)(66574015)(86362001)(31696002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?YThWcXFiVzBaMnh4WGo4ekM3WjhiemhHT2JwcmpQS0laYnd6bzBEc2pHNFdj?=
 =?utf-8?B?WnhMVzdiZklQMkZxYXVaM3d5NGhyUDhoU09FektZUkVBeklvU2o3Y09lUXVS?=
 =?utf-8?B?bmloUzVSSThVanJjVC94enZjbzJ1Q0ZvcE9EMkxNS2I1L2lka1JNT2F5a2xa?=
 =?utf-8?B?SWZOMXlXZ1RzQ2dacnVLNk1PWk55a2xVcFZjUGQ0SWVoenpIdmt6WGVheHRG?=
 =?utf-8?B?bE1RazJRcmpYdk02c2srdzVNb0VHM2l4eFJWTEVjVkRBQis3WlZ1dE43TEJ4?=
 =?utf-8?B?eW5UaFdUY2RZeS9WSEpUZTVMT2M3ckxiOFJXdHpRMnpKTlhLMU5rVnlmQzVO?=
 =?utf-8?B?SUlnNVZsNS9lLzVyZ0lzVXlFK3Q3RExRSVlvcG12K21NclFLUXY0T2FRaUVa?=
 =?utf-8?B?ZHRiVUVvbUN4R3lLdlJuNklQOGlTblp6aWpselNrWUpEbXV5SklvdkdnRXZo?=
 =?utf-8?B?bnl0WWtsRjkyTS9zNnNNMzBwT21sK3Jsamdyb01DNnJObGsxMC9QYTNlQXVN?=
 =?utf-8?B?ZXJwZmp3UXN6ZWxUS01YcStKN3d3Sm1QUHRaRG1Xc3I2VWZodzJ2bEhJdlBr?=
 =?utf-8?B?T3dTbnJsYXJjU2xGeHBiNTdSM1d2U1hnbmxidHdBUUNCNlhKcnJXOUllZzhP?=
 =?utf-8?B?ZTMyc1htWlhuSWkyVklwN0lTaXp6c1FMcHhCdDNMZjR4b0VKdzdBS0lkSnl0?=
 =?utf-8?B?TE5PdTF0eC81Y3plN1kzUitvSFZadU82dW5FL2Ywc2FaSWE2Nkw1Z2xRNFE3?=
 =?utf-8?B?UXU0b0NqV3pGbG9raHBBckVHN0tpODJsR0p6QzRNYit2ZllzZW5VeTVXMTdp?=
 =?utf-8?B?dXRQRkFTVVhCMWZka1E3K3hJa0NiZStrbXRGaUNwNUExZC9uR1FWYm96UXJF?=
 =?utf-8?B?cExDTTlleGE4QnNjTXdVOHdzMkJBR0RhTVh3RHB3dTl2TTk4YmxDVjBneFkz?=
 =?utf-8?B?MlQyMlRrcElvdGt6Qk5TSmQ4dDg4a2Nvejgrd29hL3RGUTVVRnYxcGFxQ2FZ?=
 =?utf-8?B?QTBQZWtUSUxZTGFHSGRLN2w2VnBJQlRubEhQcVFmT1h0c281am5yN3ppanpD?=
 =?utf-8?B?NWpVc2tzVTZkdHh6VDA0VlN2WExaTFRGZXhMNW5YMlUveWxzN3g5QUw1SHhh?=
 =?utf-8?B?VUJqQWlYZ3oxTjJ4Nkc5c1Mxc3ZiQkcxUzVKUlNUaUN1Y3N4OTJoNkdIbHBn?=
 =?utf-8?B?WkZ0SGV3UTJFVWhVc3hkM3NNUzNuME9LUWVsWFpQR0J2dGwzTUFtdmtFTFNx?=
 =?utf-8?B?ZkVTUFBrU2tsczZoNTcvUWNDWU9GU0tWaERWanNWM0toZXNWZDZpK1lyV1BP?=
 =?utf-8?B?T3E5RjQxSHBwcmFCeXFZZGRPS3JnM2ZuZGtVUThVLzJrb1o0Mys0eEtscmZ0?=
 =?utf-8?B?azY1cVFDM0JiTW1zYnFaR3NyanZTNFJNdDV2Yyt6Q1dMaCttYzJweFMrdkh5?=
 =?utf-8?B?VGdwOSttL0ZCblRWK2treUhjSWlYaUp4bDhnYXB3VFJoWW43UGJvWlZHYzBG?=
 =?utf-8?B?T1lDRTY4VU9RVXBScVMvb2JsU0kyZFp3VCtMaHk0T250YkM0OUtlckRPanA2?=
 =?utf-8?B?UCsrdzQvNFlLTlZ1M2NJUU5MaGhsTm9qdUdSMFZibmhGaEFBQWtyb2RZR1Y5?=
 =?utf-8?B?elRuUlBET1lnZFdXSXoxMit3S3Y4R0xabUtJVXNiVUJBc094VEpMSjdEYURt?=
 =?utf-8?B?MGpKc1YxNnJLNVR2REZkdHp4bUJpeUQ3OWRPYm1jTTFhN1l4bWRNUUUzL2Vw?=
 =?utf-8?B?TWhuRDYvRTdGT0FockZOWUNXTTVYNHFkMFltc01KcDNrU2tVVkIrTDcrcEsy?=
 =?utf-8?B?LzFTeW1qU21FZEVmL1Z2cjEwZGkzeTMxTndYb0EwNFBmUUwxT0lxQ0lnOUZR?=
 =?utf-8?B?ZXBBNWl3TXkvVzJFN09yZS80TEx6eDJ0bC9KaUMwd3poZEtuMXJkOHpadFBJ?=
 =?utf-8?B?OUJEQ2xteVJWVmdjdXNLbWd2RGpuYzE2dnhVYk9SVHZraXpKcllpajE4bHhi?=
 =?utf-8?B?N0UxR0VWdkxPaFBBbjl5Uy9QTkNWaDA5YmtabStmcDZITnFXdk9pRk85c2hl?=
 =?utf-8?B?b1R4QnNiQXRUSzJ2c0pVY0UzNjJMdFBMOWp5Z2hKblpKNDVweU5UNTN5ZVlW?=
 =?utf-8?B?d0VQQWJNVzF5eEFaVXA0elA5aU1QSUFyd0l4REFBbW53SE9UaGt5SDZlYXpG?=
 =?utf-8?B?WXJuYXg5UWcyNHlkRzIyZ2trWG1rVTdEYS9DRzRLb0tMK2tGNEpkd2tDVmVJ?=
 =?utf-8?B?SFQ3ck5QVzltQ2JISytLc3ozem9wek5idk9WRVZSVlJ3OU5ZR2hBOG1BRndy?=
 =?utf-8?B?UHNCQ0tuMUdGNktQNkJnZHBmTTJZUmNROG9PMmxUVHRiQUdpV1JwVENrNDlj?=
 =?utf-8?Q?ptdB47J/J7pYwwdQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <198DA0096D964E4496BC8D9005BDA9B4@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b895042-ef19-401e-8e43-08da1ea363f5
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:47:13.0323
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GiB+aEF+f3GHt3hruWQXkleGZf77t7VfkqUEj/ZcZKs3RBHclynXamevo+pJNjR5rzxg9sJhxUY0a39YMer1cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0169

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEFkZCBhIGhlbHBl
ciB0byBxdWVyeSB0aGUgbnVtYmVyIG9mIHNlY3RvcnMgc3VwcG9ydCBwZXIgZWFjaCBkaXNjYXJk
IGJpbw0KPiBiYXNlZCBvbiB0aGUgYmxvY2sgZGV2aWNlIGFuZCB1c2UgdGhpcyBoZWxwZXIgdG8g
c3RvcCB2YXJpb3VzIHBsYWNlcyBmcm9tDQo+IHBva2luZyBpbnRvIHRoZSByZXF1ZXN0X3F1ZXVl
IHRvIHNlZSBpZiBkaXNjYXJkIGlzIHN1cHBvcnRlZCBhbmQgaWYgc28gaG93DQo+IG11Y2guICBU
aGlzIG1pcnJvcnMgd2hhdCBpcyBkb25lIGUuZy4gZm9yIHdyaXRlIHplcm9lcyBhcyB3ZWxsLg0K
PiANCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+DQo+IFJl
dmlld2VkLWJ5OiBNYXJ0aW4gSy4gUGV0ZXJzZW4gPG1hcnRpbi5wZXRlcnNlbkBvcmFjbGUuY29t
Pg0KPiBBY2tlZC1ieTogQ2hyaXN0b3BoIELDtmhtd2FsZGVyIDxjaHJpc3RvcGguYm9laG13YWxk
ZXJAbGluYml0LmNvbT4gW2RyYmRdDQo+IEFja2VkLWJ5OiBDb2x5IExpIDxjb2x5bGlAc3VzZS5k
ZT4gW2JjYWNoZV0NCj4gQWNrZWQtYnk6IERhdmlkIFN0ZXJiYSA8ZHN0ZXJiYUBzdXNlLmNvbT4g
W2J0cmZzXQ0KPiAtLS0NCg0KTG9va3MgZ29vZC4NCg0KUmV2aWV3ZWQtYnk6IENoYWl0YW55YSBL
dWxrYXJuaSA8a2NoQG52aWRpYS5jb20+DQoNCi1jaw0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:47:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:47:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305514.520578 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEoB-0002A4-Nx; Fri, 15 Apr 2022 05:47:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305514.520578; Fri, 15 Apr 2022 05:47:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfEoB-00029x-JS; Fri, 15 Apr 2022 05:47:51 +0000
Received: by outflank-mailman (input) for mailman id 305514;
 Fri, 15 Apr 2022 05:47:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfEoA-00029j-DX
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:47:50 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on2062f.outbound.protection.outlook.com
 [2a01:111:f400:7ea9::62f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 94577ecd-bc7f-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 07:47:49 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by DM5PR1201MB0169.namprd12.prod.outlook.com (2603:10b6:4:55::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:47:46 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:47:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94577ecd-bc7f-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TPk0O6tEDhuKAM7Ba1VETuhiLVSniDNnDNvDwLHweQAAMAnVBxm3felIgvdeeTra7y7bSarZJqus8iCg2G8a05R56VwwTPb9prcGd4hwbKulSR7yGpZZK0DIiy2w1OtrQ/OXYZIgIOUAqQpuEMclF4x5lKZR25hsxX4TwaouW3lrhbrhTSfKOFye3M4UGEIY7lhPwCt3rrHQJI/1/TNA8qG0xpGGr9WaY1FwDxpYQO3szLUZ4qWhfkQhrUadkieKa8XARdnnzfilPa+gi4KC7mym7ZQVRWTcVbxsud1nVZ6XMOO7pfwhsssTEkwZ3OUl5ijJfVWAc3oIB+4nqxgsRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5yccX0Ck38D03COpr5o1/1QaWpsfoh5G/DeZ7DRwbxA=;
 b=NYuJOrJ2zsP67QUGov1BM5eW7UCGdD7PFHZcAgDi9CeCT3M3kcCEoW0Lsq7TAsOf1pqsPw07l8apuGFGHGl0PnzWScuDRKr1YycpOUyXsFO6y+s4e9IzfGR80gz3IsBXLNkblPeU2rnsuob0/7YH5z7Qm3Ztmt3h/A7LYd/3wSBugjf12u0S3R2lEdrdNeBcsxwVSHWLHXUMrCoSZqCWh+RfqKhnUuo2tpcgbi1TwKmbNOh49JWMRQ1ofDpPCLhDkqEQQIN6RrKth/em4c0RZRWj6eoqtDFtihLTunVH3WALBowYOeC5VhqdNSixD4DXTwdKFqUgKceuMYLpjb+dXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5yccX0Ck38D03COpr5o1/1QaWpsfoh5G/DeZ7DRwbxA=;
 b=eexxlZfYMjmAdwt+eDdwGqGoSYW67KO1NX9sKkqRDCqyY6hBFpyBG+BpU+2/e7y7pWsF9bCw+rrqnt3vqhBdk7UFPEhEK6KOIRAYQsnOGAeT2l8jFcYcHUD9WieOuybNERv2EYDzEuZQ/N4THg5CILJmeXucz0BocQG462XQzWLIltv3jqhHaHzhPGaKxU/U9EdvRnZlHVUN57vzdDLRTmxYMdtUEhBY4IcaeLLCiIuhhWf+AaJs/GQADZOhGnvfvFDCMkD9MdnMzTwEVFj+4cHzzy/VTaNWnqS739bzw3BHJt+LWtQIDD9LcA0Q2eWKw05BiPxioGGadwmKdTVB7g==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?utf-8?B?Q2hyaXN0b3BoIELDtmhtd2FsZGVy?= <christoph.boehmwalder@linbit.com>,
	=?utf-8?B?SmFuIEjDtnBwbmVy?= <hoeppner@linux.ibm.com>, Coly Li
	<colyli@suse.de>, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Thread-Topic: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
Thread-Index: AQHYUITwHwmFqkxbgUOy+ZlMTcrucqzwd5+A
Date: Fri, 15 Apr 2022 05:47:45 +0000
Message-ID: <0bf7bda0-0c19-7186-8492-ad894456d98d@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-25-hch@lst.de>
In-Reply-To: <20220415045258.199825-25-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 440487f6-ed5b-42fa-3422-08da1ea3778b
x-ms-traffictypediagnostic: DM5PR1201MB0169:EE_
x-microsoft-antispam-prvs:
 <DM5PR1201MB01694ADC34E9EBF9CD309483A3EE9@DM5PR1201MB0169.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 q0WkzUzQ88U0jXi33Plo0IGtu+s+0FhW5jG3JNBZuI1CKLpAQuJ8fdB5n0oSEDvIB7vtCVUwCDVnDak+yGhQci+LIPNUxWp++wHC1hN0hvK6+WkpkL8GR62mtNSqy32qx6VdPr+iA3Xa6s1B4XUp36Puun4ss7MpQhDC0nTJtIQeFe1cKWpLjuOWJknC69aUOCqLhAM0libwtB79dYPWbgHZemZJPhxnuizB2CNhUDJQ3dKXM4Yn7HsO5FoPSX9vQklzzVk2uHh2Bn+TtJtGdp5UDkrs2CXirUxaot1ufgTVZ7xcdBZixy9s7EJUyJ5Tjc77S7vWCZBsay1BpW/FEQIFBA4BVzuewtk/3ICyqSwMuA8c/Xz5L1hmc8wUNBd5PIv8BWshOrQwgeHptY3GPRsXoMO8tci2+txD0MxM86x/C/qpu/1iEdgg4PkneUcICTEn9vZthXp4SBlK87nyVWU9y1mXRQzBWJDpl0c46uOAsDP8PBlkqw1vsLuSPMBHdc8CWSe4esbPeMtUc9mDylh5JP8EwIeytsETljATJ7/oSit6Sf0QT3kumxL+dRyhXSoPTPQEgB/nN7oSytYKKuEbEiSiX26Gdb+sgZ4jZedikS6LUbA5BdATinxDZsGktNU+LGpbIlY2FxbXa1zJtiDN/Rcoqc3wzuNY97fPNLi1ijO+HsfaUyY0FYG4iVRx7b4+p9ik9NFbAjNKAuc/aow74uOFIpNEDMU1rLOB2McUDwTrBEb9xowLNvy2yZCnsc6FpXKfx6voaLB3duTybw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(110136005)(71200400001)(64756008)(8936002)(83380400001)(4744005)(2616005)(31686004)(2906002)(38070700005)(316002)(6506007)(53546011)(6512007)(66446008)(7406005)(122000001)(186003)(7416002)(76116006)(66476007)(66946007)(91956017)(66556008)(508600001)(36756003)(5660300002)(54906003)(38100700002)(6486002)(66574015)(86362001)(31696002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?aHdiUE96TjVSeVFUcnNxNDVCQXJQcWJvZmNqVjVmUnE4UlZCOGNwTHVFMSt3?=
 =?utf-8?B?bjFjYndwdFpxYzZuS2NYNkNsaThhM2ZuNEZyVDZUQ2ZpbDdLTHJDNWxER1U4?=
 =?utf-8?B?N1UyekVnZUgxVHVTT0lOaEtXcnMyWGl5ZjZhWVVHZGxBb1hRaTVaWnJOSjR4?=
 =?utf-8?B?NCtZRnpXWndYcEpjenlWT1UwMC9rV1p4aFpPZnJFVUhOZlVmRVUwOGs2aXY2?=
 =?utf-8?B?MFZsOXpnUCtBalFrbHd5SkJQbkVvTzBwZTNRaE9OazJiVFpMeC9uc2FuRnRm?=
 =?utf-8?B?THNIQlU4L0l1WnpFYkZYZWlreVU3SkpIaCtVempaZGkvVjBjdGVZRWc0czhz?=
 =?utf-8?B?ZlRqTlM2U01TNHJNb0ovb0RLTjdTT3VqclVXNnhoV2RjMkhNUmZSbzN2dnRO?=
 =?utf-8?B?bUJHcTBYY3pXQkVjcDBJcGEyM2JSd09acmhBUGxGNjAzckc2aDlXUnNkZjFH?=
 =?utf-8?B?T25xU2ZvRVdLbGQvYzJKTC8waDVMeFZVajFQT0ZYbytvQTNyV2o2eGU1VWFN?=
 =?utf-8?B?c0tKbnF1b3hQdDZlTFg4NCswa3lVK2lnSyt2SS8wcjhXVTZNTnlubjJBOW1Y?=
 =?utf-8?B?c0lFWnpBMmJZTnZnTEpEeW5ZVkVZWE1uV25JWDcva1FCanUyRXZxc2ZUem1I?=
 =?utf-8?B?aENwc1V4a2RjUEllRTM1THE1WmMxdW1oV2JmLzVZL0lxUU5mUmw1MXBnNWUy?=
 =?utf-8?B?QlNmbkZyMTRDOFFhMU52Rm9uc3lNcXNRaDJGS3VFczVUeCtSR2s1TTNBWkFu?=
 =?utf-8?B?bjZwSXMwL2NlZFRNL094Vy90elkrb0IvRXFvTGJCNVZPdDRhczIrRGZOM3VI?=
 =?utf-8?B?ekFUVmU5Um12RDY4czg5enlMdXpkVnNob0pCS3VyVVRQR251OFZwbWFjNmNs?=
 =?utf-8?B?bnY2YTFOK0E0QnRpNEhHb3RXVG16bG8xMjJXL25jRC9jamI2TG1NWkhmemdN?=
 =?utf-8?B?WlRzbzh3cElXY3Q4R3U4TEFBWkppcGtyaXdzb2dvdGgrK1hiRVFRQVp2ZWVD?=
 =?utf-8?B?SnFkT3JUbEVPejVZa1RYTnFiejkwRUhyZGR3Zy9YbThxZ3B4Z1A0S0V5ZnVG?=
 =?utf-8?B?OElVbnFnSnprSnBiaXlGWklUVUhJa29qRVVSK2lMRzhuWHlaNXZOc1M0eTNK?=
 =?utf-8?B?OFJHdkxRcHI3d0E0TUw4aU5DRndaVDZlQUhSeDBhS1ErNnViMnlIZk15OWNp?=
 =?utf-8?B?MWg4UVRncWtjbEs0RWN1MWhoa3pwaFovamVER244RXhwZEVlWVYyWXV2SG5j?=
 =?utf-8?B?czBtTXJtdGVKWjNFOUx2Si9SNm5kR2s2Y1BGMFFmUVJFWnZBSE0rUGw5WnFi?=
 =?utf-8?B?SFFFaDZ5YWpNRDJVa1dRdWU5MkxldVIwN01iR0hlTUJTQkdxMWkzd0lZc1Ro?=
 =?utf-8?B?MmpYN3F2bUVNaFVsYmd4bTlwbitXMzlPbUx2UmZENzNTUVdnNmhvNUZCVWRP?=
 =?utf-8?B?QU1qNXNHcWxpbXdCV2w3RFhNMlB1MTM1UFR5cUd0VURhMHNEcUpuUW55WjMz?=
 =?utf-8?B?WkFIQW9yRVM4LzJqWnRkMk9vZEhzdU1RWWFGUnBhWWZpUDNPSG94dGo5U1RL?=
 =?utf-8?B?QUN3Titmb3FqMytLaWFqbGF2QTc3MVN3eDZhaFVrSUltRTVMSlpsL2kwNFFx?=
 =?utf-8?B?aTgyOGdDUC9vS1pZSEphcEhKZ0J6SXZrbElxNTBQczNGSUN6cVcxditXYmNh?=
 =?utf-8?B?cGtOMWJ0TzdzVXA2ZksvcXJFYWhZSEJuRWpRMmJBd3JYc2NvVFc1c0NqQUcx?=
 =?utf-8?B?eXJaOXkycDBibEJuUmZNU055WXlBbHlPeDZpRDQwSkpoVHArTnFjZTM1c20w?=
 =?utf-8?B?eWd3eHRNYSthOG1NZ1BOek5UcVkyVTRSZDcvM3h1YXMyMFNjVUI5NlEybnB4?=
 =?utf-8?B?UkRFbVI3M3dBb1F5NFV6ZEVRUk51bzFCUGtuSlh0aU43MkZoL1Q0OEJDTFMy?=
 =?utf-8?B?VVRlSEd2cjU5b3VPWXRWTGd2RUp3bGVXOUtFRGY2SEFxU080ZGJqemFDVjlT?=
 =?utf-8?B?b1h6QjExNUpRWklsTVgyc3FESFgyOEtKd210ZGloYUZhTDhxaWVRZks1R2Vm?=
 =?utf-8?B?VnJaVG9YMlBTQXpsYlMwTzFHV1lETm1QbldBMFB1RmJuWVpCOC9talRRc3dU?=
 =?utf-8?B?bmlZamhlTHhKOHJURVozbXBXdHhzVEI5YzJUYkdSbjI0cWJMWTlVeW83VEVq?=
 =?utf-8?B?L2tHUFV4Mi9obGN2Rm9QUVk1K1lBTnYxQ1lCdTh4Z3NFTVJPWWlRMzBPbHgv?=
 =?utf-8?B?VzJXM1JVZ2pYaTA2YW1Id0E0bThLZDNVb1dXUHg0b3FvWm5JNnJ5OUNnMWFB?=
 =?utf-8?B?c3VObXVCWXFaU3d2YlE3dUR2QlRBQTF3ZTkrRTQzUEIrQmVwN3A1VTRzSEp6?=
 =?utf-8?Q?lLngOiMUsnjBXv80=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B35E75958048F04C98F125EEE4A4B3F7@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 440487f6-ed5b-42fa-3422-08da1ea3778b
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:47:45.9210
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ppEpaEXyVIbVSePEJ7wcrxl3EYx79mbfMaGBhJoxUD4tL0hru/1v9euWD5zTV77oZdGiiMDXmH8ygtIW71l8Vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0169

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEp1c3QgdXNlIGEg
bm9uLXplcm8gbWF4X2Rpc2NhcmRfc2VjdG9ycyBhcyBhbiBpbmRpY2F0b3IgZm9yIGRpc2NhcmQN
Cj4gc3VwcG9ydCwgc2ltaWxhciB0byB3aGF0IGlzIGRvbmUgZm9yIHdyaXRlIHplcm9lcy4NCj4g
DQo+IFRoZSBvbmx5IHBsYWNlcyB3aGVyZSBuZWVkcyBzcGVjaWFsIGF0dGVudGlvbiBpcyB0aGUg
UkFJRDUgZHJpdmVyLA0KPiB3aGljaCBtdXN0IGNsZWFyIGRpc2NhcmQgc3VwcG9ydCBmb3Igc2Vj
dXJpdHkgcmVhc29ucyBieSBkZWZhdWx0LA0KPiBldmVuIGlmIHRoZSBkZWZhdWx0IHN0YWNraW5n
IHJ1bGVzIHdvdWxkIGFsbG93IGZvciBpdC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IENocmlzdG9w
aCBIZWxsd2lnIDxoY2hAbHN0LmRlPg0KPiBSZXZpZXdlZC1ieTogTWFydGluIEsuIFBldGVyc2Vu
IDxtYXJ0aW4ucGV0ZXJzZW5Ab3JhY2xlLmNvbT4NCj4gQWNrZWQtYnk6IENocmlzdG9waCBCw7Zo
bXdhbGRlciA8Y2hyaXN0b3BoLmJvZWhtd2FsZGVyQGxpbmJpdC5jb20+IFtkcmJkXQ0KPiBBY2tl
ZC1ieTogSmFuIEjDtnBwbmVyIDxob2VwcG5lckBsaW51eC5pYm0uY29tPiBbczM5MF0NCj4gQWNr
ZWQtYnk6IENvbHkgTGkgPGNvbHlsaUBzdXNlLmRlPiBbYmNhY2hlXQ0KPiBBY2tlZC1ieTogRGF2
aWQgU3RlcmJhIDxkc3RlcmJhQHN1c2UuY29tPiBbYnRyZnNdDQo+IC0tLQ0KDQoNCkxvb2tzIGdv
b2QuDQoNClJldmlld2VkLWJ5OiBDaGFpdGFueWEgS3Vsa2FybmkgPGtjaEBudmlkaWEuY29tPg0K
DQotY2sNCg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:51:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:51:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305525.520588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfErn-0003gq-9U; Fri, 15 Apr 2022 05:51:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305525.520588; Fri, 15 Apr 2022 05:51:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfErn-0003gj-6W; Fri, 15 Apr 2022 05:51:35 +0000
Received: by outflank-mailman (input) for mailman id 305525;
 Fri, 15 Apr 2022 05:51:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bg9y=UZ=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1nfErm-0003gd-3V
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 05:51:34 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on2062a.outbound.protection.outlook.com
 [2a01:111:f400:7ea9::62a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19936aa5-bc80-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 07:51:32 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by DM5PR1201MB0169.namprd12.prod.outlook.com (2603:10b6:4:55::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 05:51:29 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 05:51:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19936aa5-bc80-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O77Ekaajc81OAFOi95GlPR4qcqaBkysRHsJ43vFj1+j3H3zLtSUSqZUgbck05+m4DSy9MMrse7WZocMAwHtUfg3UyWBUfse+6nx1sGW0+7mq0XASog4m1XVFgjPp8rdSIM5tx5IbNA7UhqYvbNZ4b3pKlQA/BdrMKRbQ5+gd50O7Wvq5adewagI0+2R15UvKZIwSieXyV93tgXxuyTqGlUcEjVpHRvyBWPvcI81M64098L5mQr8udbKzqt8nEmImFpxC3DCVIYhgVhkWidXrMpzZfmRiQljqlO9/VVQPqSQQs61a63GpccjAjXny4IGLF2wUMT6Se6SpFO2haEIx7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gg8hdgNEhj02MY/XmMdpyN8wb87wt0DFAivKrNj4n08=;
 b=jvguEBMxycXbMCw6KPaqOa4VrhjKN9V7qiaNFWMwsqbfLjBYgQENWNFsj6ZMi2P1fT4Y6agiBkPTFtUyhBFWuWrE1bi3V3PiwpdSAbk7MIssOAqWRLZBqXaVnNjDHGFfH8hAPV0RdufDizG/sjrdB09LBoYh0Osnq3kDjgv6riaMxfMPXNK6G8tBGlEhIgqPS363DChPE3g2Ef/K/nllIjxcrUEv8mvcrnkpP12p57t+rLO/YKzFlvFG3ePYKKIZiKxwqC5GQNEmeyTsE1Gwf+9yU/ydFjpva9A8DRNAATmD1DdZXXMPQX/yra+sryYPqCC5OHH3H0w6sIG4CGt3Cg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gg8hdgNEhj02MY/XmMdpyN8wb87wt0DFAivKrNj4n08=;
 b=VDfgTaSk5uOJnNTZAAWJSAbOvvp7Dt4od+YuLkDUMZ2ERormmWeB0Q+sPvkB5n8RJoFUxRkiwP+nDz2Fs35bmeYFbR6mPO7uQUMmz8n+49u7LUiIP7y7mFawzwK7yKMqEI8j4UQb9MnM2x3Ux28jnKdTq3TvNRrMh+Cd30qzvuh4VFhe5SOTf9k8SzDkKUBCFMDoLPfntk5xglLsaVsAJ0vk30HUrRpiyKMMuKHle45ZrfOjcTEmsdvFY6+fnxfZJUNzP25uVLHPMXEvhyITTPlYWasjDVq4Nqh/uR27m991It4FlP/HgYDyr4CYtAh1OK3Ou+7Afi6ldKj5DeFnFw==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "drbd-dev@lists.linbit.com"
	<drbd-dev@lists.linbit.com>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-bcache@vger.kernel.org"
	<linux-bcache@vger.kernel.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>, "linux-mtd@lists.infradead.org"
	<linux-mtd@lists.infradead.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org"
	<target-devel@vger.kernel.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "cluster-devel@redhat.com"
	<cluster-devel@redhat.com>, "jfs-discussion@lists.sourceforge.net"
	<jfs-discussion@lists.sourceforge.net>, "linux-nilfs@vger.kernel.org"
	<linux-nilfs@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>, "ocfs2-devel@oss.oracle.com"
	<ocfs2-devel@oss.oracle.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	=?utf-8?B?Q2hyaXN0b3BoIELDtmhtd2FsZGVy?= <christoph.boehmwalder@linbit.com>,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>, Jaegeuk Kim
	<jaegeuk@kernel.org>, Coly Li <colyli@suse.de>, David Sterba
	<dsterba@suse.com>
Subject: Re: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from
 REQ_OP_DISCARD
Thread-Topic: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from
 REQ_OP_DISCARD
Thread-Index: AQHYUITx2Wbm58EJ9UyANBYH5JqbHKzweKgA
Date: Fri, 15 Apr 2022 05:51:29 +0000
Message-ID: <ad050f78-2d64-0ff9-a6b0-968cfa53eacf@nvidia.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-27-hch@lst.de>
In-Reply-To: <20220415045258.199825-27-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c9fd5094-8dc8-417c-1c9a-08da1ea3fcca
x-ms-traffictypediagnostic: DM5PR1201MB0169:EE_
x-microsoft-antispam-prvs:
 <DM5PR1201MB0169C8FEB54422A788EA47EFA3EE9@DM5PR1201MB0169.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 AmVfwKV6cd4uqx7He4BuZiTWp0+dFZvn6EzYAM/qM8fTafRDgAWKcLgUoMlxzsJPYe+yQX6WDo7+kOOvNSP1qP781PM+B2kjgmIo08YtxKcDWv8NCW+TpQR3IvIHAgE1OUK6c+WT4VB3oJrcV2vmJoS/+ddH6IHDewe2Ftogor2p+oKFRxGJj7A5qQ6NBla1a1aBdvnEZyIuQsvkx3H+FW6X2mGTjy4lO1K3ZmAq2Z/ycAshtZs6BVUFDr3C60r/jBPzVuGmm2kSQ3/xsgW1l/B1vIsQnRVXFm1cff8PyptIUiXNozdrEZ5eTeV1aX0zyp7TJTEMIL8jbd5Lel1KdL0iwNiYFC9BYAC3rMKweU/Q+5Ec8Vdz5xcpoZGYlj1FYv/SWNzZA0KFL9itvVdJte10Pcl6KQaU5mMRUQBTrWn9J9EmBuNqdbpSbvtdX7N12XqQ163AFebLWjsUVIJTMEJohi8GMAT7ShaGokObl+W37caJWbNxCs3NPznZAiSRdu12XyL14x8V1XFdDoibTUectDnELKTbuJ9hdUv6/6Y9ixL2uacBcUzLvhzwXS2P8xfrcItzXmQFBPx1OAsWvc6zYc/IfF6hSofnZCOqRNya6ocs0d8cjvnlr7+3NoOWeoLFSZqV/6QGmKKdmPKdWVoYx8NRG0dpBtVU8qUigY1IERlt4Y0kMx90+EZymw29N313FbUSHIZ/M4Ww2HQNApkHt6ZXb7eZrVYIqdrmmLknsJ2VEU+KBkOiekjlqC1YM32UJ8GWmnhbxrQX55cNdQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(66556008)(76116006)(66476007)(66946007)(91956017)(66446008)(7406005)(122000001)(186003)(86362001)(4326008)(31696002)(508600001)(36756003)(5660300002)(6486002)(54906003)(38100700002)(8936002)(83380400001)(4744005)(2616005)(64756008)(8676002)(110136005)(71200400001)(38070700005)(316002)(6506007)(53546011)(6512007)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?QzF4enRGVEozclBWQ2xUVjF5L1g3NzRQZkxXZmdSbGxpZVZLMkJtY1NkV1lR?=
 =?utf-8?B?aHFveDlYcnVyVUNXQXVYc3lZN1ZtRWt3dk5vNHEwN1lXUkdlRVEvVkIvazVw?=
 =?utf-8?B?Q3dTa0lsdnlyRk15ejFpTTIwd2EyK2Jnd3RNQS9WbzZHL3U2enYzSHU2bExl?=
 =?utf-8?B?dHlRckZXSmlPNEIwenZTcmFXdlEvUXI3b0tQd01KQ3RiNkxDbU9qZk5MOWNL?=
 =?utf-8?B?b3hRVUduTG1VQmJIYnFuNDNSZGFNK1FxSks4dTRleit5S0ZBSHJKN2dzWXE2?=
 =?utf-8?B?OW5qVGpUYmV1dTFSWGlnMUtkNzJPUDl4d0prZ0RsVFBBZ0JPTHhlY0xvdDFa?=
 =?utf-8?B?eW50T3FJc0J5YkNVcms5QldtMkJmamMvakZMUVl2SU9acUs3eElDQmxSUnBq?=
 =?utf-8?B?ZnkyL01hcy82YmtqQlJUSEJUd3lEaC9Ld3JacXRTNy9mQ0V5dHRhQm9FRjJQ?=
 =?utf-8?B?b3BOU1BtWXpqSUVoUFd0UGZBWUFmL2Y2U0FBQXVqOVVGMlFuRlU4ZTBSbDMr?=
 =?utf-8?B?K29nbDBZRTJPNHJXNnBqdnRRbWxLSnVNbWtnNnhoTVBKNU42UWlMSjRNYXVJ?=
 =?utf-8?B?ZjE2QjJac1lhd1ZFUXRaMDFsWVJLbmU2azZoV1VRd3FMYnkzcUNmcjNpN1F0?=
 =?utf-8?B?ejJPNmxyTVZqblBucUdEQ29VRFlLT1pUb0tOTUJyQkc0SGtrSS84UEhhNFUy?=
 =?utf-8?B?bGhpY1lKcUxzNWdqYnE3anI3S3dWeE1Sa3B1OEdhNi94UVl6TXZ2NGlUSUY3?=
 =?utf-8?B?dC9hZnR5RmIrUWN1OUp4TjZQOTc4ZXpIZU9kazUwUEJETDBhOSticFdYMDRo?=
 =?utf-8?B?Ti9DL2R5bVV6TnFpeDVYdzhnQzZOcDJYQVhxVHRiWkxqYjBoMWdiUjZrU1pa?=
 =?utf-8?B?d3RMVURoRHg4SlBJeTBraDZqK1RpMHlndnZCN1h3bDZjc0haN0I1K1JTYWVo?=
 =?utf-8?B?c016dkNObFNVa2VDU01Va2hubDdLbC8yS09TdGNHSVM0TFdVYldHckRNbUk3?=
 =?utf-8?B?RXhNdkZQcWRCTUJzdHBveUtBVVpQTkl2WGNHd0ZLeVVWUC9IbzYyck5lTDJV?=
 =?utf-8?B?SDQyRjJMN0RmL1dyL0xVZ2FKTVRBcjVUNTFDR3NFbUl2Y0gybjFwTFFoOUJ4?=
 =?utf-8?B?T1lKTzcyS1lKbVBGYlVOU0hqSHFUbTF0dXpMYXRTTVgxcmNzdHBIVnZ4N29z?=
 =?utf-8?B?YW9CYUhSekxRSy8rTGVvdllhU0VnWmZSZE8vejhNbnptWnZOQm4rUFRrS3Nx?=
 =?utf-8?B?aU9RQXdYRElEakFpM1RkL0N1YnVuVDh6Z2VPdUZBWDdJU3FRaTRYYlphQVFT?=
 =?utf-8?B?cGdNZDkwYUs0UUN4TlhGdUZCOENsbXNqbjh6QUZ5TThGTGM4eXZJa3luc1o2?=
 =?utf-8?B?TGtCR3VKYkthbXUxaHJMZmdjMkZhZlJOU3kzUWxMSlpFK05hTEhWQlZCWlFB?=
 =?utf-8?B?b0ROckVJcW52RWFxWUFpeGpWOWZ0WFNWTVZzUm15aWU2R2d4ZGwvT0k0OHIr?=
 =?utf-8?B?eGJ5Q1VYZWJGZ3RHQktJSE1RQWRBVFFza0J5SGhmQm1KVGhMdE1YSmMxUDY5?=
 =?utf-8?B?VmNiTjdJOWJhMnBsVHBFVTJaWm13d2d3VjhoaFpSSm1sVERMZkVGUTlFSWtH?=
 =?utf-8?B?OTY1QUN6UlhtbFhsNUIydW9Bb1VDTUs4L3pSMEIxYktlZ1hidy81aHBIOTZC?=
 =?utf-8?B?RWgwOXlPZ2E3Ti8vM25yRG4xUFZSblBjM2ZGVVBEck1qM2JmYU4xVzJTVW1r?=
 =?utf-8?B?SkQ0dDV4V1JRaWFxTTl2cEp4aFdwRjZ4ZTJsaWErVjIxT2d5cUJKbkpaQlFN?=
 =?utf-8?B?NWtzd2ZNYlZUenZwOG1zREFGOU1LVGovRHl6THRpWWkydlFnN3VoN1V0TEZU?=
 =?utf-8?B?YVBkQy9ZRncyK2g5OXVrL3BkZTYvcVVTbG9wdUhpNkttaGlIOVhuRlFSWmRL?=
 =?utf-8?B?YkJMd0dNNUJnTmdqNFFRZDNNQU84VUZVdHc0ZnJObmpYYTNrZEhmMXpLS1Vk?=
 =?utf-8?B?MVdETlYzeGxUZHJCL1IyeFNrU1Z3YlpqQjFrd2lJdlhXaG9sSG1GU2pBQTlD?=
 =?utf-8?B?RGNVd0RGa0s0ZU9vL09PL1RjZDFHbytOL3BHRzB4NTAzU2c3anNENDJsMGRT?=
 =?utf-8?B?Q0NNblVSMklrVTN5MHd6ZUxOeGRTbXN4YnUwL3o3ajJlbzVpZXhObmMvZHdm?=
 =?utf-8?B?NkpnaWo3QjIyZUdNREhOWkppd0V3TzllSFNreWVEV1J0MGhVSFhwLzVTejNB?=
 =?utf-8?B?QndGdTN1NzMrM0RyLzYzRVhDUDhQYytNYWU2OEQrKzFYSVQxNFh1bzZ5MXBX?=
 =?utf-8?B?djB5eEw2WXRYNERJQi9EaVp6dE1pdlBZY0Y5SDRHSld5QXpCNlJLcHkvdmN5?=
 =?utf-8?Q?3X2JVDPgqkisQy2o=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C5A7864F5C266F4ABDCFD32C055621F9@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9fd5094-8dc8-417c-1c9a-08da1ea3fcca
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 05:51:29.4703
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IPcAt18WzYDe1ZXZaQ67IfuhtbBuQMqjGvQ61935BGXjt8u7waNpeop0EhPBq1EGBFzNYdvWpPbakAPDA6Tcaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0169

T24gNC8xNC8yMiAyMTo1MiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFNlY3VyZSBlcmFz
ZSBpcyBhIHZlcnkgZGlmZmVyZW50IG9wZXJhdGlvbiBmcm9tIGRpc2NhcmQgaW4gdGhhdCBpdCBp
cw0KPiBhIGRhdGEgaW50ZWdyaXR5IG9wZXJhdGlvbiB2cyBoaW50LiAgRnVsbHkgc3BsaXQgdGhl
IGxpbWl0cyBhbmQgaGVscGVyDQo+IGluZnJhc3RydWN0dXJlIHRvIG1ha2UgdGhlIHNlcGFyYXRp
b24gbW9yZSBjbGVhci4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IENocmlzdG9waCBIZWxsd2lnIDxo
Y2hAbHN0LmRlPg0KPiBSZXZpZXdlZC1ieTogTWFydGluIEsuIFBldGVyc2VuIDxtYXJ0aW4ucGV0
ZXJzZW5Ab3JhY2xlLmNvbT4NCj4gQWNrZWQtYnk6IENocmlzdG9waCBCw7ZobXdhbGRlciA8Y2hy
aXN0b3BoLmJvZWhtd2FsZGVyQGxpbmJpdC5jb20+IFtkcmJkXQ0KPiBBY2tlZC1ieTogUnl1c3Vr
ZSBLb25pc2hpIDxrb25pc2hpLnJ5dXN1a2VAZ21haWwuY29tPiBbbmlmczJdDQo+IEFja2VkLWJ5
OiBKYWVnZXVrIEtpbSA8amFlZ2V1a0BrZXJuZWwub3JnPiBbZjJmc10NCj4gQWNrZWQtYnk6IENv
bHkgTGkgPGNvbHlsaUBzdXNlLmRlPiBbYmNhY2hlXQ0KPiBBY2tlZC1ieTogRGF2aWQgU3RlcmJh
IDxkc3RlcmJhQHN1c2UuY29tPiBbYnRyZnNdDQo+IC0tLQ0KDQpMb29rcyBnb29kLg0KDQpSZXZp
ZXdlZC1ieTogQ2hhaXRhbnlhIEt1bGthcm5pIDxrY2hAbnZpZGlhLmNvbT4NCg0KLWNrDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 05:57:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 05:57:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305536.520600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfExR-0004Oo-Oo; Fri, 15 Apr 2022 05:57:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305536.520600; Fri, 15 Apr 2022 05:57:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfExR-0004Oh-L9; Fri, 15 Apr 2022 05:57:25 +0000
Received: by outflank-mailman (input) for mailman id 305536;
 Fri, 15 Apr 2022 05:57:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfExQ-0004OX-Bo; Fri, 15 Apr 2022 05:57:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfExQ-00039z-4H; Fri, 15 Apr 2022 05:57:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfExP-0001p8-OA; Fri, 15 Apr 2022 05:57:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfExP-0006nA-Nd; Fri, 15 Apr 2022 05:57:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7E1lLLxgBwpz96c+AVwwoVQEztE0CQQ4VJP5SAths1Q=; b=wYlfulReEjYjPBhIhnKx88a19Z
	Y3613W+1MTsyxOWtOuaxJqtg4Ye4wmFe3EVelN9VEste61JB1zXp/GPWehsPwF/LkOUVWY/AvFFjy
	0SJaphmwKzNv1IaIOUaSqq618bwIQB6KqLIlbHQ7Sy2g92R/oWrjiXY7ioNH0eI7MSP4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169416-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169416: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 05:57:23 +0000

flight 169416 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169416/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  404 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 06:30:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 06:30:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305545.520612 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfFT3-0008Nm-B2; Fri, 15 Apr 2022 06:30:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305545.520612; Fri, 15 Apr 2022 06:30:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfFT3-0008NK-5x; Fri, 15 Apr 2022 06:30:05 +0000
Received: by outflank-mailman (input) for mailman id 305545;
 Fri, 15 Apr 2022 06:30:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfFT2-0008FH-BZ; Fri, 15 Apr 2022 06:30:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfFT2-0003o2-97; Fri, 15 Apr 2022 06:30:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfFT1-0004Gh-QI; Fri, 15 Apr 2022 06:30:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfFT1-00058d-Pq; Fri, 15 Apr 2022 06:30:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dREgIw8LVWZr3pWPprgm0bQLvNvqyQ85+NNtXL+Tc8w=; b=FjHt5YUeMJXvnY/ep/1Qwtn2lr
	+fkJoMIgVoxeLBNTrgH7zJ22yg5BAKxgmlYiGN7rM+1xPgi7mvFb0/kKA2zhOTxNC7qANAA3v0TV9
	/7mj3KTkf+VqVnLIfG5obEKdqOcMqgvN/s5cu6ON2UVJTxhONYcTcIViS8Wg6Gnq2gTg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169417-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169417: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 06:30:03 +0000

flight 169417 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169417/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  405 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 06:37:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 06:37:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305554.520622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfFZv-0000ua-1G; Fri, 15 Apr 2022 06:37:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305554.520622; Fri, 15 Apr 2022 06:37:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfFZu-0000uT-UO; Fri, 15 Apr 2022 06:37:10 +0000
Received: by outflank-mailman (input) for mailman id 305554;
 Fri, 15 Apr 2022 06:37:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTan=UZ=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1nfFZt-0000uN-IG
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 06:37:09 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 78b53c6c-bc86-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 08:37:08 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 8657568B05; Fri, 15 Apr 2022 08:37:05 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78b53c6c-bc86-11ec-a405-831a346695d4
Date: Fri, 15 Apr 2022 08:37:05 +0200
From: Christoph Hellwig <hch@lst.de>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Rahul Singh <Rahul.Singh@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>,
	"jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	hch@lst.de
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Message-ID: <20220415063705.GA24262@lst.de>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com> <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop> <8C511888-6183-421E-A4C7-B271DAF46696@arm.com> <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Apr 14, 2022 at 01:39:23PM -0700, Stefano Stabellini wrote:
> OK, now we know that the code path with Xen is correct and it is the
> same code path taken (dma_alloc_direct) as when !CONFIG_XEN and !SMMU.
> That is how it should be.
> 
> I cannot explain why dma_alloc_direct() would fail when called from
> xen_swiotlb_alloc_coherent(), but it would succeed when called from
> dma_alloc_attrs() without Xen.
> 
> I am not aware of any restrictions that xen or swiotlb-xen would
> introduce in that regard. Unless you are just running out of memory
> because dom0_mem too low.

The crash is deep down in the page allocator.  Even if memory was low
it should no crash.  So there is some odd interaction between Xen
and the page allocator going on.  I think nvme and dma-direct really
are only the messenger here.


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 07:00:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 07:00:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305563.520633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfFvw-0003Rp-TP; Fri, 15 Apr 2022 06:59:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305563.520633; Fri, 15 Apr 2022 06:59:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfFvw-0003Ri-QW; Fri, 15 Apr 2022 06:59:56 +0000
Received: by outflank-mailman (input) for mailman id 305563;
 Fri, 15 Apr 2022 06:59:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfFvv-0003RY-8M; Fri, 15 Apr 2022 06:59:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfFvv-0004Hx-6c; Fri, 15 Apr 2022 06:59:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfFvu-0006KJ-Mh; Fri, 15 Apr 2022 06:59:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfFvu-0001Rm-MD; Fri, 15 Apr 2022 06:59:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sxmaXP2j8W/WZ1yKeLIMnwLykBdxpKPEDOLBjXlwiog=; b=3r9uJKqZF0NTjItT6uakhb8zB1
	N/ftgADj2ywU46eHeNiJfYBWwyw71fQ1TIuxMsCAxZECaL+Wa2tpt1BNQAz0e+gKiZw2oRfXfd9rc
	E3AnXsmXVnwvEVFxC3b/K5HVx0GidTRQYy4gROxLpTzRbM3RcduMr94SolgmTtpxysuU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169418-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169418: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 06:59:54 +0000

flight 169418 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169418/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  406 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 07:41:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 07:41:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305573.520644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfGaO-00008i-2c; Fri, 15 Apr 2022 07:41:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305573.520644; Fri, 15 Apr 2022 07:41:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfGaN-00008b-Vj; Fri, 15 Apr 2022 07:41:43 +0000
Received: by outflank-mailman (input) for mailman id 305573;
 Fri, 15 Apr 2022 07:41:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5UAI=UZ=bombadil.srs.infradead.org=BATV+2d633663de0085320ac7+6809+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfGaL-00008V-Ul
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 07:41:42 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7b4262ae-bc8f-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 09:41:38 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1nfGaG-009Cis-7P; Fri, 15 Apr 2022 07:41:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b4262ae-bc8f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=xanSGgJ3nmtzvbbdp9vVuGDNU57I0ihEAXyIecrf4bA=; b=lps71QQUamaHvR3jlBRw+n3uyM
	JFgM5Skqngi7JHyRil4qKMmAEM5LFTvcWctJCRRUKTHITWjByEaRjFXlI1QFwKwfDznzrnq/lmskY
	ehCLULfMu+QaORULxHxFRPom6cawrtOvL6VeWCdLRS1vsaXUEDq/mTvEhVnvx0flpxmqzBiwKSAX3
	LmQI65ZSeNYRW47jHR4TI91hvxdPBP9a+ni/rg4MKnyPzCdRkLG2CLrX55JwN8keJFvMvbjNu1uEU
	DrvFdR6Ne1c+TOm7uYaONr2V++soK+q3+FnvCW2LW7BjSo6SkR3egrhx72Jv82FoBDGRaXaU2ABV7
	CtfGLRrg==;
Date: Fri, 15 Apr 2022 00:41:36 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
	Kaly Xin <Kaly.Xin@arm.com>, Jiamei Xie <Jiamei.Xie@arm.com>,
	Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>
Subject: Re: [RFC PATCH 0/6] virtio: Solution to restrict memory access under
 Xen using xen-virtio DMA ops layer
Message-ID: <YlkhsH4zqly/BykB@infradead.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

I can only see three out of 6 patches on the linux-arm-kernel list,
which makes reviewing this impossible.  Also please Cc me directly
on any series doing crazy things with dma ops.  Thanks!


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 07:47:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 07:47:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305582.520654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfGfa-0000qg-LM; Fri, 15 Apr 2022 07:47:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305582.520654; Fri, 15 Apr 2022 07:47:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfGfa-0000qZ-II; Fri, 15 Apr 2022 07:47:06 +0000
Received: by outflank-mailman (input) for mailman id 305582;
 Fri, 15 Apr 2022 07:47:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfGfZ-0000qP-47; Fri, 15 Apr 2022 07:47:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfGfZ-00056E-05; Fri, 15 Apr 2022 07:47:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfGfY-0007tY-GU; Fri, 15 Apr 2022 07:47:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfGfY-000295-Fz; Fri, 15 Apr 2022 07:47:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9XLMSYrSVCAVMyckI1Dd2SMzZL727kLluhwp46M1eXw=; b=lD+QpQ8F/RorZL16euHobDMsFr
	VhMYMScUG7FO9DmvQQ9VeUf55rIohEoEmUb4odPMeMSSFzCqDIXLgj8wn6VWLrGTKllJ2x8JF8bPY
	rGvd+4lFXLyTv4oNpS5vKPbr9cJlTiCFjzUSAU6+ErjS8hWyYCGxwRvK2u/gUg5+UsWI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169409-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169409: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=028192fea1de083f4f12bfb1eb7c4d7beb5c8ecd
X-Osstest-Versions-That:
    linux=b9b4c79e58305ac64352286ee5030d193fc8aa22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 07:47:04 +0000

flight 169409 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169409/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169403
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169403
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169403
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169403
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169403
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169403
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169403
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169403
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                028192fea1de083f4f12bfb1eb7c4d7beb5c8ecd
baseline version:
 linux                b9b4c79e58305ac64352286ee5030d193fc8aa22

Last test of basis   169403  2022-04-14 19:11:53 Z    0 days
Testing same since   169409  2022-04-15 00:10:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Deucher <alexander.deucher@amd.com>
  Alex Williamson <alex.williamson@redhat.com>
  Alexander Lobakin <alexandr.lobakin@intel.com>
  Alvin Šipraga <alsi@bang-olufsen.dk>
  Anilkumar Kolli <quic_akolli@quicinc.com>
  Antoine Tenart <atenart@kernel.org>
  Arend van Spriel <arend.vanspriel@broadcom.com>
  Arun Ramadoss <arun.ramadoss@microchip.com>
  Bagas Sanjaya <bagasdotme@gmail.com>
  Ben Greear <greearb@candelatech.com>
  Benedikt Spranger <b.spranger@linutronix.de>
  Borislav Petkov <bp@alien8.de>
  Borislav Petkov <bp@suse.de>
  Charlene Liu <Charlene.Liu@amd.com>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Dave Airlie <airlied@redhat.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dylan Hung <dylan_hung@aspeedtech.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Gal Pressman <gal@nvidia.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guillaume Nault <gnault@redhat.com>
  Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
  Heiko Carstens <hca@linux.ibm.com>
  Hongbin Wang <wh_bin@126.com>
  Horatiu Vultur <horatiu.vultur@microchip.com>
  Ido Schimmel <idosch@nvidia.com>
  Ivan Vecera <ivecera@redhat.com>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gunthorpe <jgg@nvidia.com>
  Jeremy Linton <jeremy.linton@arm.com>
  Johannes Berg <johannes.berg@intel.com>
  Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kalle Valo <kvalo@kernel.org>
  Karsten Graul <kgraul@linux.ibm.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Kuogee Hsieh <quic_khsieh@quicinc.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marijn Suijten <marijn.suijten@somainline.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Martin Willi <martin@strongswan.org>
  Mateusz Palczewski <mateusz.palczewski@intel.com>
  Matt Roper <matthew.d.roper@intel.com>
  Melissa Wen <mwen@igalia.com>
  Michael Walle <michael@walle.cc>
  Nathan Chancellor <nathan@kernel.org>
  NeilBrown <neilb@suse.de>
  Nicolas Dichtel <nicolas.dichtel@6wind.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paolo Abeni <pabeni@redhat.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Pavle Kotarac <Pavle.Kotarac@amd.com>
  Peter Seiderer <ps.report@gmx.net>
  Petr Machata <petrm@nvidia.com>
  Petr Malat <oss@malat.biz>
  Rameshkumar Sundaram <quic_ramess@quicinc.com>
  Rob Clark <robdclark@chromium.org>
  Rob Clark <robdclark@gmail.com>
  Rob Herring <robh@kernel.org>
  Robin Murphy <robin.murphy@arm.com>
  Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Shyam Prasad N <sprasad@microsoft.com>
  Simon Ser <contact@emersion.fr>
  Stephen Boyd <swboyd@chromium.org>
  Steve French <stfrench@microsoft.com>
  Sven Schnelle <svens@linux.ibm.com>
  Toke Høiland-Jørgensen <toke@redhat.com>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tomas Melin <tomas.melin@vaisala.com>
  Tomasz Moń <desowin@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Topi Miettinen <toiwoton@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Vinicius Costa Gomes <vinicius.gomes@intel.com>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xin Long <lucien.xin@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b9b4c79e5830..028192fea1de  028192fea1de083f4f12bfb1eb7c4d7beb5c8ecd -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 07:57:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 07:57:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305593.520666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfGpl-0002Pg-OR; Fri, 15 Apr 2022 07:57:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305593.520666; Fri, 15 Apr 2022 07:57:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfGpl-0002PZ-L5; Fri, 15 Apr 2022 07:57:37 +0000
Received: by outflank-mailman (input) for mailman id 305593;
 Fri, 15 Apr 2022 07:57:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfGpk-0002PP-Cz; Fri, 15 Apr 2022 07:57:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfGpk-0005GZ-8I; Fri, 15 Apr 2022 07:57:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfGpj-0008Gv-Um; Fri, 15 Apr 2022 07:57:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfGpj-0007QU-UN; Fri, 15 Apr 2022 07:57:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=r+mSXAJVQBG9S0DzwHKhjnUaPF488b34G7yaNB/OBoM=; b=4mLwbj9YgrvGKbutJid3Z9Ollm
	caK+KOxi+jyhqrOX2HuoY0oqDDv0df4Pzq+aD33hKusL8TJy/m/Wx7f1yYpzy9ePCeZRfPQ0AS8g+
	rwWwGq9wXOJkUGMwybyoFYCv5R5HuPqWTJ/8hwB0M2dt/v9ZFfcj1YmeKepulwhjnCtE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169419-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169419: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 07:57:35 +0000

flight 169419 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169419/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  407 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 08:08:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 08:08:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305612.520677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfH0N-0004VJ-4K; Fri, 15 Apr 2022 08:08:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305612.520677; Fri, 15 Apr 2022 08:08:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfH0N-0004VC-1I; Fri, 15 Apr 2022 08:08:35 +0000
Received: by outflank-mailman (input) for mailman id 305612;
 Fri, 15 Apr 2022 08:08:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0Y4D=UZ=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nfH0L-0004V6-Av
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 08:08:33 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on0625.outbound.protection.outlook.com
 [2a01:111:f400:fe07::625])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3ceb3bc0-bc93-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 10:08:31 +0200 (CEST)
Received: from AM7PR03CA0020.eurprd03.prod.outlook.com (2603:10a6:20b:130::30)
 by DB6PR0802MB2357.eurprd08.prod.outlook.com (2603:10a6:4:87::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Fri, 15 Apr
 2022 08:08:28 +0000
Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:130:cafe::66) by AM7PR03CA0020.outlook.office365.com
 (2603:10a6:20b:130::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Fri, 15 Apr 2022 08:08:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Fri, 15 Apr 2022 08:08:26 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Fri, 15 Apr 2022 08:08:25 +0000
Received: from cd53b77d6ea3.4
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5E9F91C9-A4CC-4CE4-BE85-FB86F76AF5D6.1; 
 Fri, 15 Apr 2022 08:08:15 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd53b77d6ea3.4
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Apr 2022 08:08:15 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by DBAPR08MB5704.eurprd08.prod.outlook.com (2603:10a6:10:1a1::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Fri, 15 Apr
 2022 08:08:11 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::b97d:6bc0:1ce6:ee38]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::b97d:6bc0:1ce6:ee38%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 08:08:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ceb3bc0-bc93-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=goLkyhFvV4U6s/r0VYqj7UwQNHDJmEgbRbA6FqI02P0=;
 b=PFX3vjQaLISTxAAIjRxY6iY3KnJRG+yRA8UKjmOyDa3jJtH4umSyMDcGaglOHcNHlm+5nu71WAHB+R2A5mUx3ahVEmZcswMCERHDqvzHzt1IvusJ2BzjcqKeTw+C4+buA3UJE+IO4a6N/CTcN7BCNqeJTMeGIto3gNU1ZJ2hroU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A+FuUY2dUrgEUhBmShTUL4WYhV/t8L6lkPBIVcg2uZ70qVRntyy1BmeH7UjkHiOl8yqXzcRgWvxhnwWfRtqdYMCZIS7hZx9NS6Y1Z3ar9s63xQgzjFPJ9KM5nEAEP5delmDadBF5tjSJCSdI+R0f0LeZeOt0NK+KFAwQU8RF1lvS1tn9N/sg0XsRhKEwq5cRZ0QtZhWompDgVvuRBiMC50YMziVvbxYAv81Jm1Myy9dbK9iHEnPatnzCgHcY1+lAEyC+eM8rqZLYUdejYCXtsHAqZwIeJR70Yq+dUGChwluJ9bAOsaYH4IzfuZSlQ8bw+g+/nnYKRT+gIe7pwnHlHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=goLkyhFvV4U6s/r0VYqj7UwQNHDJmEgbRbA6FqI02P0=;
 b=lth2uKdAqtIYrs3zaNX5fx6ikvg0lQEaoO1rWwqF/ElyGQfnAH7qpkzU/uI81V/6xCozcB/Lv5tDePeVJaAl+p+OUVXhfE3hJCvwxlV7BHk4UNq7qRCEoPIyEsWlLnHuQCvygg446ZnxUq+TqQT4GKRBMUQxcENp6p5luMQEfdWeQtxA3T33KPaG4aNkxcMAb6CALETLbAzYmFnKmP/iKiHpY/e11FLdrhcGuSVvSjNpraajMQOM3I8DcwE1fOK89wAiqkys5G+G8Rexiczjt2Aap8eyIB55wa3H/0OSxdaUcYG+VVDKJCwvVyzmuWT+H4OwDV5gencU3RSSpp+I8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=goLkyhFvV4U6s/r0VYqj7UwQNHDJmEgbRbA6FqI02P0=;
 b=PFX3vjQaLISTxAAIjRxY6iY3KnJRG+yRA8UKjmOyDa3jJtH4umSyMDcGaglOHcNHlm+5nu71WAHB+R2A5mUx3ahVEmZcswMCERHDqvzHzt1IvusJ2BzjcqKeTw+C4+buA3UJE+IO4a6N/CTcN7BCNqeJTMeGIto3gNU1ZJ2hroU=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Penny Zheng <penzhe01@a011292.shanghai.arm.com>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Chen
	<Wei.Chen@arm.com>
Subject: RE: [PATCH v1 02/13] xen/arm: introduce a special domain DOMID_SHARED
Thread-Topic: [PATCH v1 02/13] xen/arm: introduce a special domain
 DOMID_SHARED
Thread-Index:
 AQHYNQ8BtyFeP2p9kkWMo7TCkVRwI6zE4SIAgADZHwCAA9xiAIAAvMUAgB0mG4CACUwasA==
Date: Fri, 15 Apr 2022 08:08:11 +0000
Message-ID:
 <DU2PR08MB7325F469140EFE83F2F8F91DF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-3-Penny.Zheng@arm.com>
 <eefa9cf2-a04c-ba8d-74cb-0d2aaa35badb@suse.com>
 <alpine.DEB.2.22.394.2203181443440.2910984@ubuntu-linux-20-04-desktop>
 <30a6ef6f-d37c-b66c-d5af-be2208766057@suse.com>
 <alpine.DEB.2.22.394.2203211256370.2910984@ubuntu-linux-20-04-desktop>
 <f8627956-8b01-6a5d-d69a-d2da16d74726@xen.org>
In-Reply-To: <f8627956-8b01-6a5d-d69a-d2da16d74726@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: C3A6C2EEE8E32145B632735585840FB6.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: b7ac04a4-78c8-4e41-68be-08da1eb71e32
x-ms-traffictypediagnostic:
	DBAPR08MB5704:EE_|AM5EUR03FT064:EE_|DB6PR0802MB2357:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0802MB23573C4F0750EA997074284DF7EE9@DB6PR0802MB2357.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 lFsekelK1Yic2TjUnpATYnF8onU6D2n83QKOomqkKutoATuw5M7VRVkST2BOBIsO7riBi2l3my/W8cF6hpPlJSu0Wxa4Q4cTjeSfbBk0uxkaVPRXhxkl1Hj7a3O7AnRIsRg6QMOXV1XMK21wZqPWdNpVQZnn71tqGxCTsOWunMEI2GwlwiuSYE9dvJyHANjQSFadUT19F7i4kWMa1Mo5IMWWCqpuYQIEgvP9R34rIhCd2NLIhMmJ8aWucW93LjBEj7e3FzdP9sC3q4YlJy5BdTlVv+YplRZVP9OT6+3v+2panQj8xJ8ps5gAqU7uwu5XTThozla7uDoNXDfu7EHQS6JKfRpDEiFU/9RK0JZP/OHFWD3ZjOK4iCa+6xWM4yAe9KnNwApj05WmkvgvgbBrOTrtELWF3dYBvQOJBf3zv8P4V/7Ui5gFabImKfLDjvLe+875IeKE96w4kMjS3JGS/kpp/rL99b0JATY9OoBcnRao0SIkcpXLKF1i/jFgNUzrt2A6npvLuus0YILQYLIy26v39CdaCKS++d3xrw4SAK+atCw1EESBoS33pJd4wloiO25meigr/CslkM7th7fSY+klyVDXqV9vyPc+uxhK84mhaICfxaunbNtgEv4Di4nNzZZdH17g7v4ijDH5xTg9Xl2Mfv6chyhFQeeomNrrN7YVKqcBtBIwTtnqFt/tHfN05rIPxiYVwk/qugWHLdDR3w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(54906003)(110136005)(86362001)(316002)(83380400001)(9686003)(26005)(186003)(508600001)(122000001)(2906002)(6506007)(33656002)(5660300002)(53546011)(4326008)(64756008)(52536014)(66476007)(66946007)(66556008)(66446008)(55016003)(7696005)(8676002)(38070700005)(38100700002)(76116006)(8936002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5704
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0042a807-7521-4c78-3f05-08da1eb71597
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rWv3R0XBWuwgyBzN0LnlGL7CIk0svLkYbP6X1zdNrVYAG3OE1d/4jq1ChPKET87IMoa2ppO1ptWm14j9hyxOyd65swjAUmWPdCx1U0URKUfkrJI/b2k6xN+rd+bfvokzXrAJzdDWo+dL9QoySojXNbCTU5acI3HuIHDSSVaagviaICDLJ05mN/ENbxzhUHmNiRrBCwkWgHqmDe8Y9yrd//oRjuiWeBXRsLodpJtyjJxo0cLQVZgNTnIJhVzuTCUvtfzM5Sq9bj4LirIUWVSAHvj3LDLukuR4kjim5r54Wzrl08cdv1nHM1fN0eFIt6Q3Kb0yUHe7w3NBSSvYXhbRyZu/5jmODhPD07m5vPUSLncMySpuazgdZ4iSUK7pr0N6st7kinl/Hi69CoRq8/RGW8i8ewo5B7NiEgeQ3MWpdYrvlMZ5FNq7r8Ru+n7uF41mfXycPxBiJu5MQ+RnsVTJtgyU0s83fXEu9RgHqX4HSHeRF9nQkU+LwxUwblDLLl+xPfxToNjV1meq1J3pCwIzOxLBeeYL0fxyCwb95eMejMPg7XS+9cHIxSxqAwcP+Rr2MhyxiH9xHGhqymuKDbEo/xYHyODxQvwaORkpseGwEIfFLN0eGMR+Up/BLHa7c9IhGStv6BSp8k0az8aIRlwojYkHHG+x7vOreOMaK9RlACHXYJnNZFceTWV4IaVaHG1D
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(55016003)(9686003)(53546011)(7696005)(316002)(70206006)(6506007)(508600001)(70586007)(4326008)(356005)(26005)(81166007)(40460700003)(86362001)(33656002)(83380400001)(336012)(82310400005)(186003)(110136005)(2906002)(8676002)(54906003)(52536014)(8936002)(5660300002)(36860700001)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 08:08:26.0033
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b7ac04a4-78c8-4e41-68be-08da1eb71e32
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2357

SGkgSnVsaWVuIGFuZCBTdGVmYW5vDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g
RnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogU2F0dXJkYXksIEFw
cmlsIDksIDIwMjIgNToxMiBQTQ0KPiBUbzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGlu
aUBrZXJuZWwub3JnPjsgSmFuIEJldWxpY2gNCj4gPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBDYzog
UGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyBuZCA8bmRAYXJtLmNvbT47IFBlbm55
IFpoZW5nDQo+IDxwZW56aGUwMUBhMDExMjkyLnNoYW5naGFpLmFybS5jb20+OyBCZXJ0cmFuZCBN
YXJxdWlzDQo+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFiY2h1aw0K
PiA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcu
Y29vcGVyM0BjaXRyaXguY29tPjsgR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXgu
Y29tPjsNCj4gV2VpIExpdSA8d2xAeGVuLm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0
Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYxIDAyLzEzXSB4ZW4vYXJtOiBpbnRyb2R1Y2Ug
YSBzcGVjaWFsIGRvbWFpbg0KPiBET01JRF9TSEFSRUQNCj4gDQo+IEhpIFN0ZWZhbm8sDQo+IA0K
PiBPbiAyMS8wMy8yMDIyIDIwOjAzLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+ID4gT24g
TW9uLCAyMSBNYXIgMjAyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4+IE9uIDE4LjAzLjIwMjIg
MjI6NTAsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gPj4+IE9uIEZyaSwgMTggTWFyIDIw
MjIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+Pj4+IE9uIDExLjAzLjIwMjIgMDc6MTEsIFBlbm55
IFpoZW5nIHdyb3RlOg0KPiA+Pj4+PiBJbiBjYXNlIHRvIG93biBzdGF0aWNhbGx5IHNoYXJlZCBw
YWdlcyB3aGVuIG93bmVyIGRvbWFpbiBpcyBub3QNCj4gPj4+Pj4gZXhwbGljaXRseSBkZWZpbmVk
LCB0aGlzIGNvbW1pdHMgcHJvcG9zZSBhIHNwZWNpYWwgZG9tYWluDQo+ID4+Pj4+IERPTUlEX1NI
QVJFRCwgYW5kIHdlIGFzc2lnbiBpdCAweDdGRjUsIGFzIG9uZSBvZiB0aGUgc3lzdGVtIGRvbWFp
bnMuDQo+ID4+Pj4+DQo+ID4+Pj4+IFN0YXRpY2FsbHkgc2hhcmVkIG1lbW9yeSByZXVzZXMgdGhl
IHNhbWUgd2F5IG9mIGluaXRpYWxpemF0aW9uDQo+ID4+Pj4+IHdpdGggc3RhdGljIG1lbW9yeSwg
aGVuY2UgdGhpcyBjb21taXRzIHByb3Bvc2VzIGEgbmV3IEtjb25maWcNCj4gPj4+Pj4gQ09ORklH
X1NUQVRJQ19TSE0gdG8gd3JhcCByZWxhdGVkIGNvZGVzLCBhbmQgdGhpcyBvcHRpb24gZGVwZW5k
cw0KPiBvbiBzdGF0aWMgbWVtb3J5KENPTkZJR19TVEFUSUNfTUVNT1JZKS4NCj4gPj4+Pj4NCj4g
Pj4+Pj4gV2UgaW50ZW5kcyB0byBkbyBzaGFyZWQgZG9tYWluIGNyZWF0aW9uIGFmdGVyIHNldHVw
X3ZpcnRfcGFnaW5nIHNvDQo+ID4+Pj4+IHNoYXJlZCBkb21haW4gY291bGQgc3VjY2Vzc2Z1bGx5
IGRvIHAybSBpbml0aWFsaXphdGlvbi4NCj4gPj4+Pg0KPiA+Pj4+IFRoZXJlJ3Mgbm90aGluZyBz
YWlkIGhlcmUsIGluIHRoZSBlYXJsaWVyIHBhdGNoLCBvciBpbiB0aGUgY292ZXINCj4gPj4+PiBs
ZXR0ZXIgYWJvdXQgdGhlIHNlY3VyaXR5IGFzcGVjdHMgb2YgdGhpcy4gVGhlcmUgaXMgYSByZWFz
b24gd2UNCj4gPj4+PiBoYXZlbid0IGJlZW4gYWxsb3dpbmcgYXJiaXRyYXJ5LCB1bi1zdXBlcnZp
c2VkIHNoYXJpbmcgb2YgbWVtb3J5DQo+ID4+Pj4gYmV0d2VlbiBkb21haW5zLiBJdCB3YW50cyBj
bGFyaWZ5aW5nIHdoeSBlLmcuIGdyYW50cyBhcmVuJ3QgYW4NCj4gPj4+PiBvcHRpb24gdG8gYWNo
aWV2ZSB3aGF0IHlvdSBuZWVkLCBhbmQgaG93IHlvdSBtZWFuIHRvIGVzdGFibGlzaA0KPiA+Pj4+
IHdoaWNoIGRvbWFpbnMgYXJlIC8gYXJlbid0IHBlcm1pdHRlZCB0byBhY2Nlc3MgYW55IGluZGl2
aWR1YWwgcGFnZQ0KPiBvd25lZCBieSB0aGlzIGRvbWFpbi4NCj4gPj4+DQo+ID4+Pg0KPiA+Pj4g
SSdsbCBsZXQgUGVubnkgd3JpdGUgYSBmdWxsIHJlcGx5IGJ1dCBJJ2xsIGNoaW1lIGluIHRvIHRy
eSB0byBoZWxwDQo+ID4+PiB3aXRoIHRoZSBleHBsYW5hdGlvbi4NCj4gPj4+DQo+ID4+PiBUaGlz
IGlzIG5vdCBhcmJpdHJhcnkgdW4tc3VwZXJ2aXNlZCBzaGFyaW5nIG9mIG1lbW9yeSBiZXR3ZWVu
DQo+ID4+PiBkb21haW5zLCB3aGljaCBpbmRlZWQgaXMgY29uY2VybmluZy4NCj4gPj4+DQo+ID4+
PiBUaGlzIGlzIHN0YXRpY2FsbHktY29uZmlndXJlZCwgc3VwZXJ2aXNlZCBieSB0aGUgc3lzdGVt
DQo+ID4+PiBjb25maWd1cmF0b3IsIHNoYXJpbmcgb2YgbWVtb3J5IGJldHdlZW4gZG9tYWlucy4N
Cj4gPj4+DQo+ID4+PiBBbmQgaW4gZmFjdCBzYWZldHkgKHdoaWNoIGlzIGp1c3QgYSBkaWZmZXJl
bnQgYXNwZWN0IG9mIHNlY3VyaXR5KSBpcw0KPiA+Pj4gb25lIG9mIHRoZSBwcmltYXJ5IGdvYWxz
IGZvciB0aGlzIHdvcmsuDQo+ID4+Pg0KPiA+Pj4gSW4gc2FmZXR5LWNyaXRpY2FsIGVudmlyb25t
ZW50cywgaXQgaXMgbm90IGNvbnNpZGVyZWQgc2FmZSB0bw0KPiA+Pj4gZHluYW1pY2FsbHkgY2hh
bmdlIGltcG9ydGFudCBjb25maWd1cmF0aW9ucyBhdCBydW50aW1lLiBFdmVyeXRoaW5nDQo+ID4+
PiBzaG91bGQgYmUgc3RhdGljYWxseSBkZWZpbmVkIGFuZCBzdGF0aWNhbGx5IHZlcmlmaWVkLg0K
PiA+Pj4NCj4gPj4+IEluIHRoaXMgY2FzZSwgaWYgdGhlIHN5c3RlbSBjb25maWd1cmF0aW9uIGtu
b3dzIGEgcHJpb3JpIHRoYXQgdGhlcmUNCj4gPj4+IGFyZSBvbmx5IDIgVk0gYW5kIHRoZXkgbmVl
ZCB0byBjb21tdW5pY2F0aW9uIG92ZXIgc2hhcmVkIG1lbW9yeSwgaXQNCj4gPj4+IGlzIHNhZmVy
IHRvIHByZS1jb25maWd1cmUgdGhlIHNoYXJlZCBtZW1vcnkgYXQgYnVpbGQgdGltZSByYXRoZXIN
Cj4gPj4+IHRoYW4gbGV0IHRoZSBWTXMgYXR0ZW1wdCB0byBzaGFyZSBtZW1vcnkgYXQgcnVudGlt
ZS4gSXQgaXMgZmFzdGVyIHRvby4NCj4gPj4+DQo+ID4+PiBUaGUgb25seSB3YXkgdG8gdHJpZ2dl
ciB0aGlzIHN0YXRpYyBzaGFyZWQgbWVtb3J5IGNvbmZpZ3VyYXRpb24NCj4gPj4+IHNob3VsZCBi
ZSB2aWEgZGV2aWNlIHRyZWUsIHdoaWNoIGlzIGF0IHRoZSBzYW1lIGxldmVsIGFzIHRoZSBYU00N
Cj4gPj4+IHJ1bGVzIHRoZW1zZWx2ZXMuDQo+ID4+Pg0KPiA+Pj4gSG9wZWZ1bGx5IEkgbWFkZSB0
aGluZ3MgY2xlYXJlciBhbmQgbm90IG11cmtpZXIgOi0pDQo+ID4+DQo+ID4+IEl0IGFkZHMgc29t
ZSBoZWxwZnVsIGJhY2tncm91bmQsIHllcywgYnV0IGF0IHRoZSBzYW1lIHRpbWUgaXQgZG9lc24n
dA0KPiA+PiBhZGRyZXNzIHRoZSBzZWN1cml0eSBjb25jZXJuIGF0IGFsbDogSG93IGFyZSBhY2Nl
c3MgcGVybWlzc2lvbnMNCj4gPj4gbWFuYWdlZCB3aGVuIHRoZSBvd25pbmcgZG9tYWluIGlzIGEg
c3BlY2lhbCBvbmU/IEkgaGF2ZW4ndCBzcG90dGVkDQo+ID4+IGFueSByZWNvcmRpbmcgb2YgdGhl
IGRvbWFpbnMgd2hpY2ggYXJlIGFjdHVhbGx5IHBlcm1pdHRlZCB0byBtYXAgLw0KPiA+PiBhY2Nl
c3MgdGhlIHBhZ2VzIGluIHF1ZXN0aW9ucy4gKEJ1dCBvZiBjb3Vyc2UgSSBhbHNvIG9ubHkgbG9v
a2VkIGF0DQo+ID4+IG5vbi1Bcm0tc3BlY2lmaWMgY29kZS4gSSdkIGV4cGVjdCBzdWNoIGNvZGUg
bm90IHRvIGxpdmUgaW4gYXJjaC0NCj4gPj4gc3BlY2lmaWMgZmlsZXMuKQ0KPiA+DQo+ID4gQWxs
IHRoaXMgc3RhdGljIG1lbW9yeSBzaGFyaW5nIGlzIHN0YXRpY2FsbHkgZG9uZSBhdCBfX2luaXQg
dGltZSBvbmx5Lg0KPiA+IEl0IHNob3VsZCBub3QgYmUgcG9zc2libGUgdG8gdHJpZ2dlciBhbnkg
ZnVydGhlciBtZW1vcnkgc2hhcmluZyBhdA0KPiA+IHJ1bnRpbWUgKGlmIHRoZXJlIGlzLCB0aGF0
IHdvdWxkIGJlIGEgYnVnKS4NCj4gDQo+IExvb2tpbmcgYXQgdGhlIGNvZGUsIGdldF9wZ19vd25l
cigpIHdpbGwgYmUgYWJsZSB0byBoYW5kbGUgRE9NSURfU0hBUkVELg0KPiBTbyBhbnlvbmUgdGhh
dCBpcyBwZXJtaXR0ZWQgdG8gYWNjZXNzIERPTUlEX1NIQVJFRCB3aWxsIGJlIGFibGUgdG8gbWFw
IGFueQ0KPiBtZW1vcnkgcmVnaW9uIGF0IHJ1bnRpbWUuDQo+IA0KPiA+IFRoZXJlIGFyZSBubyBu
ZXcgaW50ZXJmYWNlcyBmb3IgdGhlIGd1ZXN0IHRvIG1hcCB0aGlzIG1lbW9yeSBiZWNhdXNlDQo+
ID4gaXQgaXMgYWxyZWFkeSAicHJlLW1hcHBlZCIuDQo+IA0KPiBJdCBjYW4gdmlhIFhFTk1BUFNQ
QUNFX2dtZm5fZm9yZWlnbiAoYXNzdW1pbmcgcHJvcGVyIHBlcm1pc3Npb24pLg0KPiANCg0KQ29y
cmVjdCBtZSBpZiBJJ20gd3Jvbmc6DQpUaGUgZXhpc3RpbmcgWEVOTUFQU1BBQ0VfZ21mbl9mb3Jl
aWduIG9ubHkgYWxsb3dzIHByaXZpbGVnZWQgRG9tMCB0byBtYXANCm1lbW9yeSBwYWdlcyBmcm9t
IG9uZSBmb3JlaWduIERvbVUgdG8gaXRzZWxmLiBTbyBJdCBjYW4gaGFwcGVuIHRoYXQgRG9tMCBp
cw0KdXNpbmcgWEVOTUFQU1BBQ0VfZ21mbl9mb3JlaWduIHRvIChtYWxpY2lvdXNseT8pIGFjY2Vz
cyBzaGFyZWQgbWVtb3J5IG93bmVkDQpieSBET01JRF9TSEFSRUQsIGFuZCBmb3Igbm93IG9ubHkg
RG9tMCBjb3VsZC4NCg0KU28sIG1heWJlIHdlIHNob3VsZCBlbmhhbmNlIHRoZSBjaGVjayBvZiB4
c21fbWFwX2dtZm5fZm9yZWlnbigpIHRvIGZvcmJpZCB0aGUNCmFjY2VzcyB0byBET01JRF9TSEFS
RUQsIGhtbSwgYnV0IHN0YXRpYyBzaGFyZWQgbWVtb3J5IHJlZ2lvbiBjb3VsZCBhY3R1YWxseSBi
ZSBvd25lZA0KYnkgYW55IGFyYml0cmFyeSBkb21haW4uDQoNClNvLCBob3cgYWJvdXQgd2UgYWRk
IHJlc3RyaWN0aW9uIG9uIHRoZSBwYWdlIGl0c2VsZj8NClBhZ2VzIG9mIHN0YXRpYyBzaGFyZWQg
bWVtb3J5IHJlZ2lvbiBhcmUgc3RhdGljIG1lbW9yeSh3aXRoIFBHQ19yZXNlcnZlZCBmbGFnIG9u
KSwNCnNvIG1heWJlIHdlIGNvdWxkIHJlc3RyaWN0IFhFTk1BUFNQQUNFX2dtZm5fZm9yZWlnbiB0
byBhY2Nlc3MgYW55IFBHQ19yZXNlcnZlZCBwYWdlcz8NCg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0K
DQpDaGVlcnMsDQoNCi0tDQpQZW5ueSBaaGVuZw0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 08:30:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 08:30:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305618.520688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfHLb-0007g9-0E; Fri, 15 Apr 2022 08:30:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305618.520688; Fri, 15 Apr 2022 08:30:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfHLa-0007g2-SY; Fri, 15 Apr 2022 08:30:30 +0000
Received: by outflank-mailman (input) for mailman id 305618;
 Fri, 15 Apr 2022 08:30:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfHLa-0007fs-Bm; Fri, 15 Apr 2022 08:30:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfHLa-0006Nt-9O; Fri, 15 Apr 2022 08:30:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfHLZ-0001HJ-QL; Fri, 15 Apr 2022 08:30:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfHLZ-00028Y-Pu; Fri, 15 Apr 2022 08:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tI4Px1HrmVsT3lJDYYwK2v0W5PmkMQ1wRwmBxbp8BzA=; b=5ryvpQJEIw02vCsAjcXuLHnaP3
	bTOF0At3HbZ6h5YhP6cqonzOMuZ/uPr7tbc8wMSorVl5XKM4PXrSTQ5ZTJ640jctbRUnuW0cbIilc
	CMH5KrnXt5KlDzB6/piaAlApAIJvvhcisdF4tAv3GY8SEXab7wG6i6N2eSjR2S3MSBl0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169415-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169415: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 08:30:29 +0000

flight 169415 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169415/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  644 days
Failing since        151818  2020-07-11 04:18:52 Z  643 days  625 attempts
Testing same since   169415  2022-04-15 04:18:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104670 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 08:31:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 08:31:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305627.520698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfHLy-000891-C9; Fri, 15 Apr 2022 08:30:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305627.520698; Fri, 15 Apr 2022 08:30:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfHLy-00088u-9G; Fri, 15 Apr 2022 08:30:54 +0000
Received: by outflank-mailman (input) for mailman id 305627;
 Fri, 15 Apr 2022 08:30:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfHLw-00087X-PN; Fri, 15 Apr 2022 08:30:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfHLw-0006O2-Ob; Fri, 15 Apr 2022 08:30:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfHLw-0001Hj-D1; Fri, 15 Apr 2022 08:30:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfHLw-000296-Cb; Fri, 15 Apr 2022 08:30:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0VYUV3Oy6Wte+XzMdw0qRxB4dYgoHll1tlWLRIXPokA=; b=c/tSvoN/13O8mtV7huH60m00u3
	BUXC7lZ3Y5Yap8iZDR1SnX1SIDiZAmGSUM1ZL02RRHWROJAeQ1AX2zrUbsJaNHzD+R2WZqKbW0B++
	6ZGuWs4+PZ2t7oVppTwd8Dprs0M7ts5J3+ARBENhb7TgAbN3zjb8ozazz1WkPCBWy+YQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169420-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169420: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 08:30:52 +0000

flight 169420 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169420/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  408 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 08:45:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 08:45:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305638.520710 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfHZo-0001Wn-Lq; Fri, 15 Apr 2022 08:45:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305638.520710; Fri, 15 Apr 2022 08:45:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfHZo-0001Wg-Ig; Fri, 15 Apr 2022 08:45:12 +0000
Received: by outflank-mailman (input) for mailman id 305638;
 Fri, 15 Apr 2022 08:45:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CGMI=UZ=redhat.com=mst@srs-se1.protection.inumbo.net>)
 id 1nfHZn-0001Wa-E8
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 08:45:11 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5a115076-bc98-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 10:45:09 +0200 (CEST)
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-120-ZzN6tgpTPbeI8GbBdd-A9Q-1; Fri, 15 Apr 2022 04:45:06 -0400
Received: by mail-wm1-f70.google.com with SMTP id
 v62-20020a1cac41000000b0038cfe6edf3fso5800954wme.5
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 01:45:05 -0700 (PDT)
Received: from redhat.com ([2.53.138.98]) by smtp.gmail.com with ESMTPSA id
 f8-20020a5d64c8000000b0020784359295sm5084468wri.54.2022.04.15.01.45.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 15 Apr 2022 01:45:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a115076-bc98-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1650012307;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UbLS45MxOVAnr1j0DEMaqGL/RKjN2qTV3wn5wivIOzo=;
	b=jN4PcIbHd31R62NfrM2xBUJWQ9x9ThFw8TpaH2YteOoe5B/KPx9tKKQXq4jJT835xJazxv
	uToWwYyN/Si8PvszwPsFaw2cV1kXZhIKpLq/tt/l9x3w/lrqOMsoMZBiGXj1n92escJ/5p
	yCD/nJuFHqkl24I1FmEnF9C0k1D9aes=
X-MC-Unique: ZzN6tgpTPbeI8GbBdd-A9Q-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:content-transfer-encoding
         :in-reply-to;
        bh=UbLS45MxOVAnr1j0DEMaqGL/RKjN2qTV3wn5wivIOzo=;
        b=YInDRGrBmHX4rWyLO1yrtFRcogiyDLlQSeyjJnCgsWK8HvE7HmzeEl/EAH8ExvPBcx
         wA1jev6QICXREBa/8nM1iP2SW/t7KpTizwE87kO+g/j4pQ5P4y91O8vgXa6IcrnNe+Vn
         /80VKwn+Kjq+iHn0NPE2z05KywZ2oyTzzOTtVcB+uLUSpLPPo7x6E1v4aPHCQiUlc6bN
         ntyx9wgxpM7mi449kJJLGkeWWrUyQpdlWWu0POjkkrgS+0coz4uz8dhn7Uo7mq3pjzqy
         zM9dC4GGvPzZjJu7WFCl8KuymISmOP0z2zwrfsdD7HhC0XYnUCFfR70Er+TPfJ6fkZpD
         V6Sw==
X-Gm-Message-State: AOAM532IwenAl6VgMDABGf1l6AGvISdVGe7wV96EBlzfeBrtDntLJH7z
	fS5ejYZkQgTj4M9Js3xN410A+vsy8QjK3dWDuYy0/3fk6kymfzh/m8ilV1LjByOHAvqOj6fJVlZ
	vrimStjYj6hpaut7CCPULz8SpJaU=
X-Received: by 2002:a05:600c:4f88:b0:391:e34e:ca66 with SMTP id n8-20020a05600c4f8800b00391e34eca66mr768134wmq.16.1650012303800;
        Fri, 15 Apr 2022 01:45:03 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxtZ3CsHMRHFsioNGpLaugIquRbj8GlmtB0g6ZbYpJjZi2MjwNik9eBG9L3OBpQkHXDtDgk7g==
X-Received: by 2002:a05:600c:4f88:b0:391:e34e:ca66 with SMTP id n8-20020a05600c4f8800b00391e34eca66mr768102wmq.16.1650012303495;
        Fri, 15 Apr 2022 01:45:03 -0700 (PDT)
Date: Fri, 15 Apr 2022 04:44:58 -0400
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
	Kaly Xin <Kaly.Xin@arm.com>, Jiamei Xie <Jiamei.Xie@arm.com>,
	Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>
Subject: Re: [RFC PATCH 0/6] virtio: Solution to restrict memory access under
 Xen using xen-virtio DMA ops layer
Message-ID: <20220415044225-mutt-send-email-mst@kernel.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Thu, Apr 14, 2022 at 10:19:27PM +0300, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Hello all.
> 
> The purpose of this RFC patch series is to add support for restricting memory access under Xen using specific
> grant table based DMA ops layer. Patch series is based on Juergen Gross’ initial work [1] which implies using
> grant references instead of raw guest physical addresses (GPA) for the virtio communications (some kind of
> the software IOMMU).
> 
> The high level idea is to create new Xen’s grant table based DMA ops layer for the guest Linux whose main
> purpose is to provide a special 64-bit DMA address which is formed by using the grant reference (for a page
> to be shared with the backend) with offset and setting the highest address bit (this is for the backend to
> be able to distinguish grant ref based DMA address from normal GPA). For this to work we need the ability
> to allocate contiguous (consecutive) grant references for multi-page allocations. And the backend then needs
> to offer VIRTIO_F_ACCESS_PLATFORM and VIRTIO_F_VERSION_1 feature bits (it must support virtio-mmio modern
> transport for 64-bit addresses in the virtqueue).

I'm not enough of a xen expert to review this, and I didn't get
all patches, but I'm very happy to see that approach being
taken. VIRTIO_F_ACCESS_PLATFORM and VIRTIO_F_VERSION_1 are
exactly the way to declare not all of memory is accessible.
Thanks!

> Xen's grant mapping mechanism is the secure and safe solution to share pages between domains which proven
> to work and works for years (in the context of traditional Xen PV drivers for example). So far, the foreign
> mapping is used for the virtio backend to map and access guest memory. With the foreign mapping, the backend
> is able to map arbitrary pages from the guest memory (or even from Dom0 memory). And as the result, the malicious
> backend which runs in a non-trusted domain can take advantage of this. Instead, with the grant mapping
> the backend is only allowed to map pages which were explicitly granted by the guest before and nothing else. 
> According to the discussions in various mainline threads this solution would likely be welcome because it
> perfectly fits in the security model Xen provides. 
> 
> What is more, the grant table based solution requires zero changes to the Xen hypervisor itself at least
> with virtio-mmio and DT (in comparison, for example, with "foreign mapping + virtio-iommu" solution which would
> require the whole new complex emulator in hypervisor in addition to new functionality/hypercall to pass IOVA
> from the virtio backend running elsewhere to the hypervisor and translate it to the GPA before mapping into
> P2M or denying the foreign mapping request if no corresponding IOVA-GPA mapping present in the IOMMU page table
> for that particular device). We only need to update toolstack to insert a new "xen,dev-domid" property to
> the virtio-mmio device node when creating a guest device-tree (this is an indicator for the guest to use grants
> and the ID of Xen domain where the corresponding backend resides, it is used as an argument to the grant mapping
> APIs). It worth mentioning that toolstack patch is based on non  upstreamed yet “Virtio support for toolstack
> on Arm” series which is on review now [2].
> 
> Please note the following:
> - Patch series only covers Arm and virtio-mmio (device-tree) for now. To enable the restricted memory access
>   feature on Arm the following options should be set:
>   CONFIG_XEN_VIRTIO = y
>   CONFIG_XEN_HVM_VIRTIO_GRANT = y
> - Some callbacks in xen-virtio DMA ops layer (map_sg/unmap_sg, etc) are not implemented yet as they are not
>   needed/used in the first prototype
> 
> Patch series is rebased on Linux 5.18-rc2 tag and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64)
> with standalone userspace (non-Qemu) virtio-mmio based virtio-disk backend running in Driver domain and Linux
> guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy'
> use-cases work properly. I have also tested other use-cases such as assigning several virtio block devices
> or a mix of virtio and Xen PV block devices to the guest. 
> 
> 1. Xen changes located at (last patch):
> https://github.com/otyshchenko1/xen/commits/libxl_virtio_next
> 2. Linux changes located at:
> https://github.com/otyshchenko1/linux/commits/virtio_grant5
> 3. virtio-disk changes located at:
> https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant
> 
> Any feedback/help would be highly appreciated.
> 
> [1] https://www.youtube.com/watch?v=IrlEdaIUDPk
> [2] https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/
> 
> Juergen Gross (2):
>   xen/grants: support allocating consecutive grants
>   virtio: add option to restrict memory access under Xen
> 
> Oleksandr Tyshchenko (4):
>   dt-bindings: xen: Add xen,dev-domid property description for
>     xen-virtio layer
>   virtio: Various updates to xen-virtio DMA ops layer
>   arm/xen: Introduce xen_setup_dma_ops()
>   arm/xen: Assign xen-virtio DMA ops for virtio devices in Xen guests
> 
>  .../devicetree/bindings/virtio/xen,dev-domid.yaml  |  39 +++
>  arch/arm/include/asm/xen/xen-ops.h                 |   1 +
>  arch/arm/mm/dma-mapping.c                          |   5 +-
>  arch/arm/xen/enlighten.c                           |  11 +
>  arch/arm64/include/asm/xen/xen-ops.h               |   1 +
>  arch/arm64/mm/dma-mapping.c                        |   5 +-
>  arch/x86/mm/init.c                                 |  15 +
>  arch/x86/mm/mem_encrypt.c                          |   5 -
>  arch/x86/xen/Kconfig                               |   9 +
>  drivers/xen/Kconfig                                |  20 ++
>  drivers/xen/Makefile                               |   1 +
>  drivers/xen/grant-table.c                          | 238 +++++++++++++--
>  drivers/xen/xen-virtio.c                           | 335 +++++++++++++++++++++
>  include/xen/arm/xen-ops.h                          |  20 ++
>  include/xen/grant_table.h                          |   4 +
>  include/xen/xen-ops.h                              |  13 +
>  16 files changed, 679 insertions(+), 43 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
>  create mode 100644 arch/arm/include/asm/xen/xen-ops.h
>  create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
>  create mode 100644 drivers/xen/xen-virtio.c
>  create mode 100644 include/xen/arm/xen-ops.h
> 
> -- 
> 2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 09:14:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 09:14:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305644.520721 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfI2L-0004s0-W6; Fri, 15 Apr 2022 09:14:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305644.520721; Fri, 15 Apr 2022 09:14:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfI2L-0004rt-Sz; Fri, 15 Apr 2022 09:14:41 +0000
Received: by outflank-mailman (input) for mailman id 305644;
 Fri, 15 Apr 2022 09:14:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfI2K-0004rj-JW; Fri, 15 Apr 2022 09:14:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfI2K-0007Bp-H1; Fri, 15 Apr 2022 09:14:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfI2K-0002P3-56; Fri, 15 Apr 2022 09:14:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfI2K-0004hw-4d; Fri, 15 Apr 2022 09:14:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UMzVaXSszwVFqCnjX3HEHyQUfGq6bW+6q9xyPsB/MjI=; b=r1om/q6UI+snD9u5ajloP+G9ZD
	sJy7tMkKDD9wEosDyZJtDi1exNX4cA0V0KCPERnpP5sxzhnUVv3a7QUZ3nvxd5qobzOUr49KU1eQW
	1DjMdXeJHapK2zX6g7kqxxpsO0Hy5TMJ3qymrDu/4u2o5ZYo1MHJrQU3aAkKGTNbxs38=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169421-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169421: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 09:14:40 +0000

flight 169421 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169421/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  409 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 09:22:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 09:22:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305653.520731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfIAH-0006MY-RP; Fri, 15 Apr 2022 09:22:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305653.520731; Fri, 15 Apr 2022 09:22:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfIAH-0006MR-OS; Fri, 15 Apr 2022 09:22:53 +0000
Received: by outflank-mailman (input) for mailman id 305653;
 Fri, 15 Apr 2022 09:22:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfIAF-0006MH-VS; Fri, 15 Apr 2022 09:22:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfIAF-0007J3-Sc; Fri, 15 Apr 2022 09:22:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfIAF-0002af-DN; Fri, 15 Apr 2022 09:22:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfIAF-00061G-Cu; Fri, 15 Apr 2022 09:22:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5HF8nxSujsfmZy6gxlxmZ35uofZYjti7R4QC30JlZ6k=; b=WSIqqOgVn4R2DANWcoufBR9cDJ
	wZRKNgGcATAD7tiOSRlg/UCGcDMxzjndlt/wHV1R9CLvyQtwdVpy3lFyF+YBLktOAlaiDe3KlTkfm
	7vFasM048YVu7orxe3GO9ulNNyRvBRaDuDkst10fAxWCwlLfihnDdyqlmZIgA5PW0HCo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169412-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169412: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-examine:reboot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 09:22:51 +0000

flight 169412 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169412/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-examine      8 reboot           fail in 169383 pass in 169412
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169383

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169383
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169383
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169383
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169383
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169383
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 169383
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169383
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169383
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169383
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169383
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169383
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169383
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169383
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647

Last test of basis   169412  2022-04-15 01:51:54 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 09:23:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 09:23:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305659.520743 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfIAh-0006sE-Al; Fri, 15 Apr 2022 09:23:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305659.520743; Fri, 15 Apr 2022 09:23:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfIAh-0006s5-6m; Fri, 15 Apr 2022 09:23:19 +0000
Received: by outflank-mailman (input) for mailman id 305659;
 Fri, 15 Apr 2022 09:23:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bOrE=UZ=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1nfIAg-0006hY-I9
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 09:23:18 +0000
Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com
 [2a00:1450:4864:20::62c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aef3a49e-bc9d-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 11:23:17 +0200 (CEST)
Received: by mail-ej1-x62c.google.com with SMTP id k23so14484173ejd.3
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 02:23:17 -0700 (PDT)
Received: from zen.linaroharston ([51.148.130.216])
 by smtp.gmail.com with ESMTPSA id
 ck5-20020a0564021c0500b00420b49ba80fsm2423370edb.24.2022.04.15.02.23.15
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 15 Apr 2022 02:23:15 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id B279B1FFB7;
 Fri, 15 Apr 2022 10:23:14 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aef3a49e-bc9d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=references:user-agent:from:to:cc:subject:date:in-reply-to
         :message-id:mime-version:content-transfer-encoding;
        bh=w667gKYBbDBTMCfXxJDqMeQkVCc8+IrorrB4oS1oJ5E=;
        b=a1GWJXNhyAXH5ruzAaxXwsuOH1eqRjJ2MKQAhRi/ipCf16gTMLgrPbZOhNKePB24Pf
         5z9Om4c2T6IDo78fsg/z08IDdB40iGCMN2YeXLaIKrg1Fj/G23HI463LKAiwvFgTQRqP
         eJzHWYKGIr3jR0zbeVtIiGY53hVBuQ1I5CKaknhuzQIprb+fZyHxuMfD9mL32g9QbVHD
         2kCYr8j+kTuH7NkE5D7cxwS8r3rJbGqVSfkoNJQ2y9HtndrWcEKX63X+n17IPPIO6BCs
         /8taSqZvn0E3yaSCWZP9/0FOSQTcWekteBTpolr69ddPZOVdY6BSh+8K2UXVm38Px7kh
         RaRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:references:user-agent:from:to:cc:subject:date
         :in-reply-to:message-id:mime-version:content-transfer-encoding;
        bh=w667gKYBbDBTMCfXxJDqMeQkVCc8+IrorrB4oS1oJ5E=;
        b=HXkcrdn5zKRuTP/kBJjCYiNR3w0IfFa8+woZEKsVidxnyLHUHDHp/3jpyTY7M0oGe6
         xlDnuARrYKtdR90ObyJZFzc6r2CRQYhrXb0jXTxd3wGdL747qmrN8k6n5gZqRTIen3fu
         vLK4L+5T8UkeH5bvJaROORoj5oG+d9yaI5Zg5OO7He6dfEKGlcseLEnOzJi+3lsF/Xrs
         Bao0Bh8j+S3B5XBCD6CZu0H05CE7+HvhRs5TYN+DcSQx0dg0vK/e/Nm2BCfmgmv0SLQC
         xDr3Ven2ijNuMjS4vF9khwDEyaYTdv6YVvD+oCLfAz0QbOo6parqndexcLMZ/bDv+yOf
         J4kA==
X-Gm-Message-State: AOAM532riNQPTcndSdxK0IgaUp9IQRFx0bJBYjvxkfGLMcq7UDCruhPT
	is/+955/DKR+Kw3pXWrlPIq7MA==
X-Google-Smtp-Source: ABdhPJxUyhO5yAboBwLOcBNkKmseAjK+8zK18o9n0eLHUP9gS4AfNzZPnXiso3pb9aw5D1JuttK3+Q==
X-Received: by 2002:a17:906:704f:b0:6e0:2ce5:131e with SMTP id r15-20020a170906704f00b006e02ce5131emr5321502ejj.246.1650014596978;
        Fri, 15 Apr 2022 02:23:16 -0700 (PDT)
References: <87pmsylywy.fsf@linaro.org> <YU5mW396S04IsCBr@mail-itl>
 <874ka68h96.fsf@linaro.org>
 <CACMJ4GbgnQVQbH1N3Duxmx10n-Qv+zzncqarNyuhmKhE-wqdqA@mail.gmail.com>
 <alpine.DEB.2.21.2109272323160.5022@sstabellini-ThinkPad-T480s>
 <CAPD2p-=MdGB_a+oEsFrPQpLo7GeKkMwYyAWcQt3z0qrGr3vR7w@mail.gmail.com>
 <alpine.DEB.2.21.2110011649220.3209@sstabellini-ThinkPad-T480s>
 <CAPD2p-m=hYbG1YjPZ9yZ7Qzs6KjCT2jSHpaDUPB0sFJoZfY4uw@mail.gmail.com>
 <alpine.DEB.2.21.2110041436070.3209@sstabellini-ThinkPad-T480s>
 <1d6382b6-ddf8-494c-4f7b-afc50a4269a4@gmail.com>
 <CAPD2p-nftmTXQTaOw1kmkBDn96i8sgcaH21o7bsGK-fA+fYbaw@mail.gmail.com>
User-agent: mu4e 1.7.12; emacs 28.1.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Rust-VMM Mailing List
 <rust-vmm@lists.opendev.org>, Stratos Mailing List
 <stratos-dev@op-lists.linaro.org>, Christopher Clark
 <christopher.w.clark@gmail.com>, Marek =?utf-8?Q?Marczykowski-G=C3=B3reck?=
 =?utf-8?Q?i?=
 <marmarek@invisiblethingslab.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Sergio Lopez <slp@redhat.com>, Wei Liu <wl@xen.org>, Stefan Hajnoczi
 <stefanha@gmail.com>, Doug Goldstein <cardoe@cardoe.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Arnd Bergmann <arnd.bergmann@linaro.org>,
 David Woodhouse <dwmw2@infradead.org>, Rich Persaud <persaur@gmail.com>,
 Daniel Smith <dpsmith@apertussolutions.com>, Paul Durrant <paul@xen.org>,
 openxt <openxt@googlegroups.com>, Julien Grall <julien@xen.org>, Juergen
 Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [Stratos-dev] Xen Rust VirtIO demos work breakdown for Project
 Stratos
Date: Fri, 15 Apr 2022 10:07:09 +0100
In-reply-to: <CAPD2p-nftmTXQTaOw1kmkBDn96i8sgcaH21o7bsGK-fA+fYbaw@mail.gmail.com>
Message-ID: <87pmlisnst.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Oleksandr Tyshchenko <olekstysh@gmail.com> writes:

> Hello all.
>
> [Sorry for the possible format issues]
>
> I have an update regarding (valid) concern which has been also raised in =
current thread which is the virtio backend's ability (when using
> Xen foreign mapping) to map any guest pages without guest "agreement" on =
that.
> There is a PoC (with virtio-mmio on Arm) which is based on Juergen Gross=
=E2=80=99  work to reuse secure Xen grant mapping for the virtio
> communications.
> All details are at:
> https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-oleks=
tysh@gmail.com/
> https://lore.kernel.org/xen-devel/1649964960-24864-1-git-send-email-oleks=
tysh@gmail.com/

Thanks for that. I shall try and find some time to have a look at it.

Did you see Viresh's post about getting our rust-vmm vhost-user backends
working on Xen?

One thing that came up during that work was how guest pages are mapped
into the dom0 domain where Xen needs to use kernel allocated pages via
privcmd rather than then normal shared mmap that is used on KVM. As I
understand it this is to avoid the situation where dom0 may invalidate a
user PTE causing issues for the hypervisor itself. At some point we
would like to fix that wrinkle so we can remove the (minor) hack in
rust-vmm's mmap code to be truly hypervisor agnostic.=20

Anyway I hope you and your team are safe and well.

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 09:52:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 09:52:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305669.520753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfId4-0001wr-Ca; Fri, 15 Apr 2022 09:52:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305669.520753; Fri, 15 Apr 2022 09:52:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfId4-0001wk-8x; Fri, 15 Apr 2022 09:52:38 +0000
Received: by outflank-mailman (input) for mailman id 305669;
 Fri, 15 Apr 2022 09:52:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0Y4D=UZ=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nfId3-0001we-GC
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 09:52:37 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0606.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::606])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c60ac00d-bca1-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 11:52:35 +0200 (CEST)
Received: from AM7PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:20b:110::30)
 by AM0PR08MB3331.eurprd08.prod.outlook.com (2603:10a6:208:5b::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Fri, 15 Apr
 2022 09:52:31 +0000
Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:110:cafe::a5) by AM7PR04CA0020.outlook.office365.com
 (2603:10a6:20b:110::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Fri, 15 Apr 2022 09:52:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Fri, 15 Apr 2022 09:52:30 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Fri, 15 Apr 2022 09:52:29 +0000
Received: from e9f6d6aafce8.4
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5ED546D9-865B-4000-9FD8-86E855700636.1; 
 Fri, 15 Apr 2022 09:52:20 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9f6d6aafce8.4
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Apr 2022 09:52:20 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by DBBPR08MB4508.eurprd08.prod.outlook.com (2603:10a6:10:c6::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Fri, 15 Apr
 2022 09:52:15 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::b97d:6bc0:1ce6:ee38]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::b97d:6bc0:1ce6:ee38%3]) with mapi id 15.20.5144.030; Fri, 15 Apr 2022
 09:52:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c60ac00d-bca1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=t+6wfYKYO48PvL1zb+hNMHa4fCRhRKrcUwf9p5hplCo=;
 b=AVPHIPTCs7dzp/+5TMxIx3VuCmtRN1VXJs66uKUB2SVCzkewUUlkONtGu2fvUbu0vvwhd5F5gZ3zR0RzAb9MnQDAjb7ipWpXijoPooXCVhZL0WZjBNx99tjwmzbHmy6xxn2RP0z2gFOSUfGTg0iPxVAowOIkXeQJcIYX1aZq2Ac=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jbyaJYQoM1U8Q5nLZ3mqEzkZTEBi0/diR4XOrZvPsjd3PTUq/wNGn7KRhQsG7/XnP88E1nUjkE5bWpoSx9VJWpCiw2PPWcYh+Shh2PC9iBur50JlgX2uxnDQJKBKrbvFQjJ/b6BvrBFKaFphd0rHy39YYm+7VG6hjiVVYK/H5IWnrvQxaqgSzmEVRm6zEBuiDQJ7CCcuMTGkRFgHeM70LWdtxa7UWuLEbd71kz2VPc4lHo0ahTfTOV3KP0wCicc8CXKNHYCl3J7kRgKNXn7bDxAeRtSE9SMvRvYDXCQS10SYcnOm9ZY9Bq/5JnCdIhVyxxRPcg35I+asncdw7Lq/Hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=t+6wfYKYO48PvL1zb+hNMHa4fCRhRKrcUwf9p5hplCo=;
 b=CLbhzf2G0ybuAKZUGMfx6yC5k550UVpWC4OFD7GiwL+6CnL7XxHXN35fXF59P+Zuq3DrC4/EF7X0MW2a+QnYrOAcNQ8TXEoz4/YRg88kdBG4HCoNqNbMIEL3cWIU7wqkwy0vCAoRtj9vGTtwR66FtyXtGQORPrKdC2wyjWZrAlfM0qjFp3/OXos1lgVZHmFqj6bEJCr9T/2/lM34T7iqPIsJWYJKQgGmFU5ND4IMSCp/cFrnnbubRBT6xcxuWtkUtsKehdGOj/Gl1rAB7DIkwPCFaA7c7Tvt0RBVwgLpLeVw3qH97QmMYU/Vubfxy7dogDkcTVb8+/mOogplL6o9XQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=t+6wfYKYO48PvL1zb+hNMHa4fCRhRKrcUwf9p5hplCo=;
 b=AVPHIPTCs7dzp/+5TMxIx3VuCmtRN1VXJs66uKUB2SVCzkewUUlkONtGu2fvUbu0vvwhd5F5gZ3zR0RzAb9MnQDAjb7ipWpXijoPooXCVhZL0WZjBNx99tjwmzbHmy6xxn2RP0z2gFOSUfGTg0iPxVAowOIkXeQJcIYX1aZq2Ac=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Penny Zheng <penzhe01@a011292.shanghai.arm.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Chen
	<Wei.Chen@arm.com>
Subject: RE: [PATCH v1 02/13] xen/arm: introduce a special domain DOMID_SHARED
Thread-Topic: [PATCH v1 02/13] xen/arm: introduce a special domain
 DOMID_SHARED
Thread-Index: AQHYNQ8BtyFeP2p9kkWMo7TCkVRwI6zE4SIAgCv+qWA=
Date: Fri, 15 Apr 2022 09:52:15 +0000
Message-ID:
 <DU2PR08MB7325265A2356A09AC1DA5FDDF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-3-Penny.Zheng@arm.com>
 <eefa9cf2-a04c-ba8d-74cb-0d2aaa35badb@suse.com>
In-Reply-To: <eefa9cf2-a04c-ba8d-74cb-0d2aaa35badb@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: E2426FB9878C5648AE114DBCDD8731CA.1
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: cf0032bc-0312-4e12-4eee-08da1ec5a828
x-ms-traffictypediagnostic:
	DBBPR08MB4508:EE_|VE1EUR03FT027:EE_|AM0PR08MB3331:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB33311874D5F223268DBD93C1F7EE9@AM0PR08MB3331.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 199qmm7Whe6UeLQn09IVVlQgTYAZdQ8suFaAbqcDRCWzucY67NDuMb4qT0jtf3qf0U2PpPOkrJ6iFEJdw5e9OEN8Ne2CryP+/aGXL6M+Hke1FRZE/dZzvoIYH4U0mOWpITCpwzBPZPx3NisD64NeS8eFLKSAbh6L3DAWfOf0RyjizsUttt0evSiz2LSY+LaD2Kulzctq1CZy3Soo221r3o3xunbxWia7mv7igX3h3wMijekHH5zHdSbjoE+zawo9u18IG+f7Be9MppxfAapcUEXbXMkMT8huTNp7E2Jy5XmO7hCCw6mXwDQVLI/BvveRHWko6SJmUe83gpn/HbhmLfPw/6w5/Q4ZtsU8pYC2tR93jUGAT5wCpdahuJkk7YGSjdL2CXqDd7uGWzX/Fsxpyj5UaDVaTuFE6EuJYP6scjHZdbMrWWn98yQL/0zBazOCGai5LN6FkJPdFI1nrnZaf6WUnouOYlCQ46VAOPoM2NH0MbY1v+cN5ztNjnfPSvz+wV7vVPqPgYAjY98mwO38RarIoJnvAU+ND0Lzv+prhjssZKG4g6I8IzuFNXN6/yUOemBaNBP560n8NtKqwX3ZqOEwBJzA5IMZM8KLxE9jE5g2QJyN3hJrjTtA+KPQPjXfCOIv/vvpNei9nEmBn5dPEy+VhJPrSYYxs78bbSogj+whBQYVLv46gID0Gl8Cu/WQL71ZfRox/77rAFFSEAOYdQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(508600001)(26005)(6506007)(2906002)(316002)(6916009)(38070700005)(83380400001)(38100700002)(54906003)(66476007)(64756008)(33656002)(76116006)(55016003)(86362001)(8936002)(4326008)(66946007)(9686003)(122000001)(66446008)(52536014)(66556008)(8676002)(186003)(53546011)(7696005)(71200400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4508
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4833c966-0f85-498f-6f92-08da1ec59f3d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rq9/+EG2TAZZ0eoE+XSVGjr8Pj8LShzVRD9GI9wTHxiENup0c3kEewVYj9Xb/383i0DO+0PdpAbzKfozkvGo6V88wPglL3PoCSJjd20h4JG5nl11vrMgC0gnjVo3EbYwvtwaudaIuRQjQNratDIEultdeLIU8YtnDT5CqbhIqAP3wDfYK2GboKtIESWvL35SXPYJ113BS5z37B6IkRlLMRg5ThJxPa/RGsIeVEvfJrmOxvE9kQ3sgNYcls1zX/bvVHrW1e7mmslkQrIFoqwrjjiFaAKyvPHcXOboIvZgYxTrg7LeZaihrrJrPuJZJCYJMQe0nfQyZwI1Ku43yVaN6mW1wB4GZMfQ7fEgGdvXNtaNSpkw1OXmMgv7Bw8q4ZjFSGrDEVzNVbqGinBi29hv+vttqv/jKtjwHA5UJiZm5jfmYbcX8Ak7++qYZAI30VH0ETvHyJNI7WvDisCOR8i8fULjkiu6HedM+2t5Xfb84iekg8Hg66n5fi94U3TI+eQ0p0Qy/VmVhRFrpMxsmwarwbkXbLvQSJWqdAcJAGx2hBpZGXb1HgsSoqPcfnkiOwF++B4IYYTCednYMPa7lVeenhtVg2+wUdftOnSObpO+aAYJvtTLZjc5SKSntJU3eRJddfhf0vtS1OMl8HeRFu8v/HIgZ5XhCsFJBJIiMhBs12/+bF1hbKn53FXnN4guddw4
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(508600001)(9686003)(2906002)(6506007)(86362001)(55016003)(33656002)(36860700001)(82310400005)(83380400001)(186003)(26005)(53546011)(5660300002)(7696005)(40460700003)(356005)(316002)(70586007)(70206006)(8936002)(52536014)(54906003)(6862004)(4326008)(336012)(81166007)(47076005)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 09:52:30.3701
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cf0032bc-0312-4e12-4eee-08da1ec5a828
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3331

SGkgamFuIA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogRnJpZGF5LCBNYXJjaCAxOCwgMjAyMiA0
OjUzIFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IG5k
IDxuZEBhcm0uY29tPjsgUGVubnkgWmhlbmcNCj4gPHBlbnpoZTAxQGEwMTEyOTIuc2hhbmdoYWku
YXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47
IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0
cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFiY2h1aw0KPiA8Vm9sb2R5bXlyX0Jh
YmNodWtAZXBhbS5jb20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXgu
Y29tPjsgR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsNCj4gV2VpIExp
dSA8d2xAeGVuLm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0
OiBSZTogW1BBVENIIHYxIDAyLzEzXSB4ZW4vYXJtOiBpbnRyb2R1Y2UgYSBzcGVjaWFsIGRvbWFp
bg0KPiBET01JRF9TSEFSRUQNCj4gDQo+IE9uIDExLjAzLjIwMjIgMDc6MTEsIFBlbm55IFpoZW5n
IHdyb3RlOg0KPiA+IEluIGNhc2UgdG8gb3duIHN0YXRpY2FsbHkgc2hhcmVkIHBhZ2VzIHdoZW4g
b3duZXIgZG9tYWluIGlzIG5vdA0KPiA+IGV4cGxpY2l0bHkgZGVmaW5lZCwgdGhpcyBjb21taXRz
IHByb3Bvc2UgYSBzcGVjaWFsIGRvbWFpbg0KPiA+IERPTUlEX1NIQVJFRCwgYW5kIHdlIGFzc2ln
biBpdCAweDdGRjUsIGFzIG9uZSBvZiB0aGUgc3lzdGVtIGRvbWFpbnMuDQo+ID4NCj4gPiBTdGF0
aWNhbGx5IHNoYXJlZCBtZW1vcnkgcmV1c2VzIHRoZSBzYW1lIHdheSBvZiBpbml0aWFsaXphdGlv
biB3aXRoDQo+ID4gc3RhdGljIG1lbW9yeSwgaGVuY2UgdGhpcyBjb21taXRzIHByb3Bvc2VzIGEg
bmV3IEtjb25maWcNCj4gPiBDT05GSUdfU1RBVElDX1NITSB0byB3cmFwIHJlbGF0ZWQgY29kZXMs
IGFuZCB0aGlzIG9wdGlvbiBkZXBlbmRzIG9uDQo+IHN0YXRpYyBtZW1vcnkoQ09ORklHX1NUQVRJ
Q19NRU1PUlkpLg0KPiA+DQo+ID4gV2UgaW50ZW5kcyB0byBkbyBzaGFyZWQgZG9tYWluIGNyZWF0
aW9uIGFmdGVyIHNldHVwX3ZpcnRfcGFnaW5nIHNvDQo+ID4gc2hhcmVkIGRvbWFpbiBjb3VsZCBz
dWNjZXNzZnVsbHkgZG8gcDJtIGluaXRpYWxpemF0aW9uLg0KPiANCj4gVGhlcmUncyBub3RoaW5n
IHNhaWQgaGVyZSwgaW4gdGhlIGVhcmxpZXIgcGF0Y2gsIG9yIGluIHRoZSBjb3ZlciBsZXR0ZXIg
YWJvdXQgdGhlDQo+IHNlY3VyaXR5IGFzcGVjdHMgb2YgdGhpcy4gVGhlcmUgaXMgYSByZWFzb24g
d2UgaGF2ZW4ndCBiZWVuIGFsbG93aW5nIGFyYml0cmFyeSwNCj4gdW4tc3VwZXJ2aXNlZCBzaGFy
aW5nIG9mIG1lbW9yeSBiZXR3ZWVuIGRvbWFpbnMuIEl0IHdhbnRzIGNsYXJpZnlpbmcgd2h5IGUu
Zy4NCj4gZ3JhbnRzIGFyZW4ndCBhbiBvcHRpb24gdG8gYWNoaWV2ZSB3aGF0IHlvdSBuZWVkLCBh
bmQgaG93IHlvdSBtZWFuIHRvDQo+IGVzdGFibGlzaCB3aGljaCBkb21haW5zIGFyZSAvIGFyZW4n
dCBwZXJtaXR0ZWQgdG8gYWNjZXNzIGFueSBpbmRpdmlkdWFsIHBhZ2UNCj4gb3duZWQgYnkgdGhp
cyBkb21haW4uDQo+IA0KDQpJJ2xsIGFkZCB0aGUgc2VjdXJpdHkgYXNwZWN0cyB3aGF0IFN0ZWZh
bm8gZXhwbGFpbnMgaW4gdGhlIGNvdmVyIGxldHRlciBuZXh0IHNlcmllDQpmb3IgYmV0dGVyIHVu
ZGVyc3RhbmRpbmcuDQoNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPiA+ICsrKyBi
L3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4gQEAgLTEwNiw2ICsxMDYsMTMgQEAgY29uZmlnIFRF
RQ0KPiA+DQo+ID4gIHNvdXJjZSAiYXJjaC9hcm0vdGVlL0tjb25maWciDQo+ID4NCj4gPiArY29u
ZmlnIFNUQVRJQ19TSE0NCj4gPiArICAgICAgIGJvb2wgIlN0YXRpY2FsbHkgc2hhcmVkIG1lbW9y
eSBvbiBhIGRvbTBsZXNzIHN5c3RlbSIgaWYgVU5TVVBQT1JURUQNCj4gPiArICAgICAgIGRlcGVu
ZHMgb24gU1RBVElDX01FTU9SWQ0KPiA+ICsgICAgICAgZGVmYXVsdCBuDQo+IA0KPiBOaXQ6ICJk
ZWZhdWx0IG4iIGlzIHJlZHVuZGFudCBhbmQgaGVuY2Ugd291bGQgaW1vIGJldHRlciBiZSBvbWl0
dGVkLg0KPiANCj4gPiBAQCAtNzEyLDEyICs3MTYsMTYgQEAgaW50IGFyY2hfZG9tYWluX2NyZWF0
ZShzdHJ1Y3QgZG9tYWluICpkLA0KPiA+ICAgICAgZC0+YXJjaC5kaXJlY3RtYXAgPSBmbGFncyAm
IENERl9kaXJlY3RtYXA7DQo+ID4NCj4gPiAgICAgIC8qIHAybV9pbml0IHJlbGllcyBvbiBzb21l
IHZhbHVlIGluaXRpYWxpemVkIGJ5IHRoZSBJT01NVSBzdWJzeXN0ZW0gKi8NCj4gPiAtICAgIGlm
ICggKHJjID0gaW9tbXVfZG9tYWluX2luaXQoZCwgY29uZmlnLT5pb21tdV9vcHRzKSkgIT0gMCAp
DQo+ID4gKyAgICBpZiAoIChyYyA9IGlvbW11X2RvbWFpbl9pbml0KGQsIGlzX3NoYXJlZF9kb21h
aW4oZCkgPyAwIDoNCj4gPiArIGNvbmZpZy0+aW9tbXVfb3B0cykpICE9IDAgKQ0KPiANCj4gTml0
OiBPdmVybG9uZyBsaW5lLg0KPiANCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiA+
ICsrKyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+ID4gQEAgLTg1NSw2ICs4NTUsMjAgQEAgc3Rh
dGljIGJvb2wgX19pbml0IGlzX2RvbTBsZXNzX21vZGUodm9pZCkNCj4gPiAgICAgIHJldHVybiAo
ICFkb20wZm91bmQgJiYgZG9tVWZvdW5kICk7ICB9DQo+ID4NCj4gPiArI2lmZGVmIENPTkZJR19T
VEFUSUNfU0hNDQo+ID4gK3N0YXRpYyB2b2lkIF9faW5pdCBzZXR1cF9zaGFyZWRfZG9tYWluKHZv
aWQpIHsNCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBJbml0aWFsaXNlIG91ciBET01JRF9TSEFS
RUQgZG9tYWluLg0KPiA+ICsgICAgICogVGhpcyBkb21haW4gb3ducyBzdGF0aWNhbGx5IHNoYXJl
ZCBwYWdlcyB3aGVuIG93bmVyIGRvbWFpbiBpcyBub3QNCj4gPiArICAgICAqIGV4cGxpY2l0bHkg
ZGVmaW5lZC4NCj4gPiArICAgICAqLw0KPiA+ICsgICAgZG9tX3NoYXJlZCA9IGRvbWFpbl9jcmVh
dGUoRE9NSURfU0hBUkVELCBOVUxMLCBDREZfZGlyZWN0bWFwKTsNCj4gPiArICAgIGlmICggSVNf
RVJSKGRvbV9zaGFyZWQpICkNCj4gPiArICAgICAgICBwYW5pYygiRmFpbGVkIHRvIGNyZWF0ZSBk
W1NIQVJFRF06ICVsZFxuIiwNCj4gPiArUFRSX0VSUihkb21fc2hhcmVkKSk7DQo+IA0KPiBJIGRv
bid0IHRoaW5rIHRoaXMgc2hvdWxkIGJlIGEgcGFuaWMgLSB0aGUgc3lzdGVtIG91Z2h0IHRvIGJl
IGFibGUgdG8gY29tZSB1cA0KPiBmaW5lLCBqdXN0IHdpdGhvdXQgYWN0dWFsbHkgdXNpbmcgdGhp
cyBkb21haW4uIEFmdGVyIGFsbCB0aGlzIGlzIGFuIG9wdGlvbmFsDQo+IGZlYXR1cmUgd2hpY2gg
bWF5IG5vdCBhY3R1YWxseSBiZSB1c2VkLg0KPiANCj4gQWxzbywgYWxvbmcgdGhlIGxpbmVzIG9m
IHdoYXQgU3RlZmFubyBoYXMgc2FpZCwgdGhpcyBzZXR0aW5nIHVwIG9mIHRoZSBkb21haW4NCj4g
d291bGQgYWxzbyBiZXR0ZXIgbGl2ZSBuZXh0IHRvIHdoZXJlIHRoZSBvdGhlciBzcGVjaWFsIGRv
bWFpbnMgYXJlIHNldCB1cC4gQW5kDQo+IGV2ZW4gaWYgaXQgd2FzIHRvIHJlbWFpbiBoZXJlLCAu
Li4NCj4gDQoNClRoZSByZWFzb24gd2h5IEkgcGxhY2UgdGhlIHNldHRpbmcgdXAgaGVyZSBpcyB0
aGF0IERPTUlEX1NIQVJFRCBuZWVkcyB0byBtYXANCnByZS1jb25maWd1cmVkIHN0YXRpYyBzaGFy
ZWQgbWVtb3J5IGluIGl0cyBwMm0gdGFibGUsIHNvIGl0IG11c3QgYmUgc2V0IHVwDQphZnRlciBz
eXN0ZW0gUDJNIGluaXRpYWxpemF0aW9uKHNldHVwX3ZpcnRfcGFnaW5nKCkpLiBzZXR1cF9zeXN0
ZW1fZG9tYWlucygpDQppcyBjYWxsZWQgYmVmb3JlIHN5c3RlbSBQMk0gaW5pdGlhbGl6YXRpb24g
b24geGVuL2FyY2gvYXJtL3NldHVwLmMsIHdoaWNoDQpjYW4ndCBtZWV0IHRoZSByZXF1aXJlbWVu
dC4NCg0KPiA+IEBAIC0xMDIyLDYgKzEwMzYsMTQgQEAgdm9pZCBfX2luaXQgc3RhcnRfeGVuKHVu
c2lnbmVkIGxvbmcNCj4gYm9vdF9waHlzX29mZnNldCwNCj4gPiAgICAgIGFwcGx5X2FsdGVybmF0
aXZlc19hbGwoKTsNCj4gPiAgICAgIGVuYWJsZV9lcnJhdGFfd29ya2Fyb3VuZHMoKTsNCj4gPg0K
PiA+ICsjaWZkZWYgQ09ORklHX1NUQVRJQ19TSE0NCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBU
aGlzIG5lZWRzIHRvIGJlIGNhbGxlZCAqKmFmdGVyKiogc2V0dXBfdmlydF9wYWdpbmcgc28gc2hh
cmVkDQo+ID4gKyAgICAgKiBkb21haW5zIGNvdWxkIHN1Y2Nlc3NmdWxseSBkbyBwMm0gaW5pdGlh
bGl6YXRpb24uDQo+ID4gKyAgICAgKi8NCj4gPiArICAgIHNldHVwX3NoYXJlZF9kb21haW4oKTsN
Cj4gPiArI2VuZGlmDQo+IA0KPiAuLi4gdGhlICNpZmRlZi1hcnkgaGVyZSBzaG91bGQgYmUgYXZv
aWRlZCBieSBtb3ZpbmcgdGhlIG90aGVyICNpZmRlZiBpbnNpZGUgdGhlDQo+IGZ1bmN0aW9uIGJv
ZHkuDQo+IA0KPiA+IC0tLSBhL3hlbi9jb21tb24vZG9tYWluLmMNCj4gPiArKysgYi94ZW4vY29t
bW9uL2RvbWFpbi5jDQo+ID4gQEAgLTY0MywxMSArNjQzLDE0IEBAIHN0cnVjdCBkb21haW4gKmRv
bWFpbl9jcmVhdGUoZG9taWRfdCBkb21pZCwNCj4gPg0KPiA+ICAgICAgcmFuZ2VzZXRfZG9tYWlu
X2luaXRpYWxpc2UoZCk7DQo+ID4NCj4gPiAtICAgIC8qIERPTUlEX3tYRU4sSU8sZXRjfSAob3Ro
ZXIgdGhhbiBJRExFKSBhcmUgc3VmZmljaWVudGx5IGNvbnN0cnVjdGVkLiAqLw0KPiA+IC0gICAg
aWYgKCBpc19zeXN0ZW1fZG9tYWluKGQpICYmICFpc19pZGxlX2RvbWFpbihkKSApDQo+ID4gKyAg
ICAvKg0KPiA+ICsgICAgICogRE9NSURfe1hFTixJTyxldGN9IChvdGhlciB0aGFuIElETEUgYW5k
IERPTUlEX3NoYXJlZCkgYXJlDQo+ID4gKyAgICAgKiBzdWZmaWNpZW50bHkgY29uc3RydWN0ZWQu
DQo+ID4gKyAgICAgKi8NCj4gPiArICAgIGlmICggaXNfc3lzdGVtX2RvbWFpbihkKSAmJiAhaXNf
aWRsZV9kb21haW4oZCkgJiYNCj4gPiArICFpc19zaGFyZWRfZG9tYWluKGQpICkNCj4gPiAgICAg
ICAgICByZXR1cm4gZDsNCj4gPg0KPiA+IC0gICAgaWYgKCAhaXNfaWRsZV9kb21haW4oZCkgKQ0K
PiA+ICsgICAgaWYgKCAhaXNfaWRsZV9kb21haW4oZCkgJiYgIWlzX3NoYXJlZF9kb21haW4oZCkg
KQ0KPiA+ICAgICAgew0KPiA+ICAgICAgICAgIGlmICggIWlzX2hhcmR3YXJlX2RvbWFpbihkKSAp
DQo+ID4gICAgICAgICAgICAgIGQtPm5yX3BpcnFzID0gbnJfc3RhdGljX2lycXMgKyBleHRyYV9k
b21VX2lycXM7IEBAIC02NjMsNw0KPiA+ICs2NjYsNyBAQCBzdHJ1Y3QgZG9tYWluICpkb21haW5f
Y3JlYXRlKGRvbWlkX3QgZG9taWQsDQo+ID4gICAgICAgICAgZ290byBmYWlsOw0KPiA+ICAgICAg
aW5pdF9zdGF0dXMgfD0gSU5JVF9hcmNoOw0KPiA+DQo+ID4gLSAgICBpZiAoICFpc19pZGxlX2Rv
bWFpbihkKSApDQo+ID4gKyAgICBpZiAoICFpc19pZGxlX2RvbWFpbihkKSAmJiAhaXNfc2hhcmVk
X2RvbWFpbihkKSApDQo+ID4gICAgICB7DQo+ID4gICAgICAgICAgd2F0Y2hkb2dfZG9tYWluX2lu
aXQoZCk7DQo+ID4gICAgICAgICAgaW5pdF9zdGF0dXMgfD0gSU5JVF93YXRjaGRvZzsNCj4gDQo+
IEFsbCBvZiB0aGVzZSBleHRyYSBpc19zaGFyZWRfZG9tYWluKCkgYXJlIHF1aXRlIHVnbHkgdG8g
c2VlIGFkZGVkLg0KPiBGaXJzdCBhbmQgZm9yZW1vc3QgZ29pbmcgdGhpcyByb3V0ZSBkb2Vzbid0
IHNjYWxlIHZlcnkgd2VsbCAtIGNvbnNpZGVyIGhvdyB0aGUNCj4gY29kZSB3aWxsIGxvb2sgbGlr
ZSB3aGVuIHR3byBtb3JlIHNwZWNpYWwgZG9tYWlucyB3aXRoIHNwZWNpYWwgbmVlZHMgd291bGQN
Cj4gYmUgYWRkZWQuIEkgdGhpbmsgeW91IHdhbnQgdG8gYWJzdHJhY3QgdGhpcyBzb21lIGJ5IGlu
dHJvZHVjaW5nIG9uZSAob3IgYSBzbWFsbA0KPiBzZXQgb2YpIG5ldyBpc18uLi4oKSBvciBlLmcu
IG5lZWRzXy4uLigpIHByZWRpY2F0ZXMuDQo+IA0KDQpBZ3JlZS4gU2hhcmVkIGRvbWFpbiBuZWVk
cyB0aGUgcDJtIGluaXRpYWxpemF0aW9uKHAybV9pbml0KSwgd2hpY2ggaXMNCmluIGFyY2hfZG9t
YWluX2NyZWF0ZS4gU28gSSB3aWxsIGludHJvZHVjZSBhIG5ldyBoZWxwZXIgbmVlZHNfYXJjaF9k
b21haW5fY3JlYXRpb24oKQ0KdG8gaW5jbHVkZSB0aGVzZSBzeXN0ZW0gZG9tYWlucyB3aGljaCBu
ZWVkIHRvIGNhbGwgYXJjaF9kb21haW5fY3JlYXRlIHRvDQpiZSBzdWZmaWNpZW50bHkgY29uc3Ry
dWN0ZWQuDQoNCj4gRnVydGhlciAodGhlcmUncyBubyBwYXJ0aWN1bGFybHkgZ29vZCBwbGFjZSB0
byBtZW50aW9uIHRoaXMpIEknbSBhZnJhaWQgSSBkb24ndA0KPiB2aWV3ICJzaGFyZWQiIGFzIGEg
Z29vZCBuYW1lOiBJdCdzIG5vdCB0aGUgZG9tYWluIHdoaWNoIGlzIHNoYXJlZCwgYnV0IGl0J3Mg
dGhlDQo+IGRvbWFpbiB0byBob2xkIHNoYXJlZCBtZW1vcnkuIEZvciB0aGlzIG15IGZpcnN0IGNv
bnNpZGVyYXRpb24gd291bGQgYmUgdG8NCj4gc2VlIHdoZXRoZXIgYW4gZXhpc3Rpbmcgc3BlY2lh
bCBkb21haW4gY2FuIGJlIHJlLXVzZWQ7IGFmdGVyIGFsbCB0aGUgc2V0IG9mDQo+IHJlc2VydmVk
IGRvbWFpbiBJRHMgaXMgYSB2ZXJ5IGxpbWl0ZWQgb25lLCBhbmQgaGVuY2UgZWFjaCB2YWx1ZSB0
YWtlbiBmcm9tDQo+IHRoZXJlIHNob3VsZCBjb21lIHdpdGggYSB2ZXJ5IGdvb2QgcmVhc29uLiBX
ZSBkaWQgc3VjaCByZS11c2UgZS5nLiB3aGVuDQo+IGludHJvZHVjaW5nIHF1YXJhbnRpbmluZyBm
b3IgUENJIGRldmljZXMsIGJ5IGFzc29jaWF0aW5nIHRoZW0gd2l0aCBET01fSU8NCj4gcmF0aGVy
IHRoYW4gaW52ZW50aW5nIGEgbmV3IERPTV9RVUFSQU5USU5FLiBJZiB0aGVyZSBhcmUgZ29vZCBy
ZWFzb25zDQo+IHNwZWFraW5nIGFnYWluc3Qgc3VjaCByZS11c2UsIHRoZW4gSSdkIGxpa2UgdG8g
YXNrIHRvIGNvbnNpZGVyIGUuZy4NCj4gRE9NSURfU0hNIC8gRE9NSURfU0hNRU0gcGx1cyBhc3Nv
Y2lhdGVkIHByZWRpY2F0ZS4NCj4gDQoNCkknbGwgdGFrZSBzdGVmYW5vJ3Mgc3VnZ2VzdGlvbiB0
byByZXVzZSBET01JRF9JTy4NCg0KPiA+IC0tLSBhL3hlbi9jb21tb24vcGFnZV9hbGxvYy5jDQo+
ID4gKysrIGIveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMNCj4gPiBAQCAtMjYxNiw2ICsyNjE2LDEx
IEBAIHN0cnVjdCBkb21haW4gKmdldF9wZ19vd25lcihkb21pZF90IGRvbWlkKQ0KPiA+DQo+ID4g
ICAgICBzd2l0Y2ggKCBkb21pZCApDQo+ID4gICAgICB7DQo+ID4gKyNpZmRlZiBDT05GSUdfU1RB
VElDX1NITQ0KPiA+ICsgICAgY2FzZSBET01JRF9TSEFSRUQ6DQo+ID4gKyAgICAgICAgcGdfb3du
ZXIgPSByY3VfbG9ja19kb21haW4oZG9tX3NoYXJlZCk7DQo+ID4gKyAgICAgICAgYnJlYWs7DQo+
ID4gKyNlbmRpZg0KPiANCj4gUGxlYXNlIGNhbiB5b3UgYXZvaWQgI2lmZGVmIGluIGNhc2VzIGxp
a2UgdGhpcyBvbmUsIGJ5IGluc3RlYWQgdXNpbmcNCj4gDQo+ICAgICBjYXNlIERPTUlEX1NITUVN
Og0KPiAgICAgICAgIHBnX293bmVyID0gZG9tX3NoYXJlZCA/IHJjdV9sb2NrX2RvbWFpbihkb21f
c2hhcmVkKSA6IE5VTEw7DQo+ICAgICAgICAgYnJlYWs7DQo+IA0KPiA+IC0tLSBhL3hlbi9pbmNs
dWRlL3hlbi9zY2hlZC5oDQo+ID4gKysrIGIveGVuL2luY2x1ZGUveGVuL3NjaGVkLmgNCj4gPiBA
QCAtNjE4LDYgKzYxOCw4IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpc19zeXN0ZW1fZG9tYWluKGNv
bnN0IHN0cnVjdA0KPiBkb21haW4gKmQpDQo+ID4gICAgICByZXR1cm4gZC0+ZG9tYWluX2lkID49
IERPTUlEX0ZJUlNUX1JFU0VSVkVEOyAgfQ0KPiA+DQo+ID4gKyNkZWZpbmUgaXNfc2hhcmVkX2Rv
bWFpbihkKSAoKGQpLT5kb21haW5faWQgPT0gRE9NSURfU0hBUkVEKQ0KPiANCj4gV291bGQgdGhp
cyBiZXR0ZXIgZXZhbHVhdGUgdG8gImZhbHNlIiB3aGVuICFTVEFUSUNfU0hNLCBzdWNoIHRoYXQg
dGhlDQo+IGNvbXBpbGVyIGNhbiBlbGltaW5hdGUgcmVzcGVjdGl2ZSBjb25kaXRpb25hbHMgYW5k
L29yIGNvZGU/DQo+IA0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 10:05:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 10:05:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305675.520765 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfIpc-0003Xe-Ho; Fri, 15 Apr 2022 10:05:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305675.520765; Fri, 15 Apr 2022 10:05:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfIpc-0003XX-Ea; Fri, 15 Apr 2022 10:05:36 +0000
Received: by outflank-mailman (input) for mailman id 305675;
 Fri, 15 Apr 2022 10:05:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GqiY=UZ=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nfIpb-0003XR-Mf
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 10:05:35 +0000
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [2a00:1450:4864:20::135])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 96aea3a1-bca3-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 12:05:34 +0200 (CEST)
Received: by mail-lf1-x135.google.com with SMTP id bi26so13359584lfb.2
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 03:05:33 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 y20-20020a2e7d14000000b0024b44fb9a9esm237038ljc.51.2022.04.15.03.05.31
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 15 Apr 2022 03:05:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96aea3a1-bca3-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=3bPZ/57wkOzXUeVbdrpb2yRMsao/hRXkHHvgI0MANKk=;
        b=kElByGo2IoedNfGnE2cZcLVPTVjK2UCWKdN87D6dViUUxOUff7l1/vPg+ZNT/zSxRC
         khbLbPeDzufZCJHNVhOB0Kv/4sAzVYBjMhpQEpXmtMohWCmzDeVHYewrH4NXQW2cnrRC
         1TNkQ7TCXY6ck4WcBIMXN4g9xiJTkTMAvoJ9C5X8P/cSWJVISPk8u10sUCC6oPCpBZfx
         tHKYCXQWpgzYXt3E2drudncvyvkkeqG0Dd91QNiUbXv3Uyw9NwloWfWK6N2A+OUDOkU1
         c5d5JvHq/xyLu75EJS3wPRGbevU1Vcxwi5jFKn71vpfFRbD4nVu/2KEnJ/IBdJ4IhmJg
         1A/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=3bPZ/57wkOzXUeVbdrpb2yRMsao/hRXkHHvgI0MANKk=;
        b=XmJ7dciFI72VSfoJRU2yJxYWzpycCOg8WSLfLN3kBPM+LbTuXH1wYBwToLSM1DAXbD
         Tqv/rl0/KBvxiKxwYUfYKXgt9evShq1/WUGrlFIcIR8+t90TUj5UsZXYo4RBk1A/zfyz
         BwTBkHL3u6OcQRgQ3Ly8OIvyGoiTWdbO4upsxoGuMoMZ/R/0aV0xgpqwCwFG7femCg/2
         fYHgqHgDRn15+AUC0bE77suIfpADiCL2f2IsH8r2Q9Z04kVxPEIFEQ2/CprUpkeOlIRZ
         NTt/U4lYAsXqICkUf9Oej1fF99TqHZqAMo0lYWMoyBJyab6eymeGgYIfLoY4BGInU+/u
         Tiyw==
X-Gm-Message-State: AOAM533vEGASVWjEZu+1XOwG3LHHlXaVReXm3LEbXa77lXl8pcQF0IDu
	Rh2mSooDHxhiuzbQCCDA6Qw=
X-Google-Smtp-Source: ABdhPJyjVd4rtR6Bjb/C8iblfrbGe544Fs3ujvYDVQYhCwQ6WGVTei+TFMsEsUoTdRkLe/bDvzEXNw==
X-Received: by 2002:a05:6512:32c7:b0:44a:762:27e4 with SMTP id f7-20020a05651232c700b0044a076227e4mr4687202lfg.401.1650017133014;
        Fri, 15 Apr 2022 03:05:33 -0700 (PDT)
Subject: Re: [RFC PATCH 0/6] virtio: Solution to restrict memory access under
 Xen using xen-virtio DMA ops layer
To: Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 virtualization@lists.linux-foundation.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Henry Wang <Henry.Wang@arm.com>, Kaly Xin <Kaly.Xin@arm.com>,
 Jiamei Xie <Jiamei.Xie@arm.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?=
 <alex.bennee@linaro.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <YlkhsH4zqly/BykB@infradead.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <251e957d-03f9-8ee6-789d-517417c95aff@gmail.com>
Date: Fri, 15 Apr 2022 13:04:11 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YlkhsH4zqly/BykB@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 15.04.22 10:41, Christoph Hellwig wrote:

Hello Christoph

> I can only see three out of 6 patches on the linux-arm-kernel list,
> which makes reviewing this impossible.


Oops, I will add linux-arm-kernel. I blindly followed what 
get_maintainer.pl suggested for each patch plus added manually some Xen 
folks,
but, indeed, the first three patches add the base of this enabling work.


> Also please Cc me directly
> on any series doing crazy things with dma ops.  Thanks!

yes, sure.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 10:30:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 10:30:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305682.520776 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfJD2-00067x-JV; Fri, 15 Apr 2022 10:29:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305682.520776; Fri, 15 Apr 2022 10:29:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfJD2-00067q-G3; Fri, 15 Apr 2022 10:29:48 +0000
Received: by outflank-mailman (input) for mailman id 305682;
 Fri, 15 Apr 2022 10:29:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfJD1-00067g-DS; Fri, 15 Apr 2022 10:29:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfJD1-0008Ut-AC; Fri, 15 Apr 2022 10:29:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfJD1-00041Z-03; Fri, 15 Apr 2022 10:29:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfJD0-0006lS-Vr; Fri, 15 Apr 2022 10:29:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AH22I1ec0wNMkyyFZkfa0gfGG2bhiS25lapqABgqAkI=; b=Vazz94UWo140Onvh6Mq6EtaEbq
	l5FZCQyVmkqCiKVkFvmQNofH5ZE9idRSZnJ9x7znK++mcuG4raH23ocin3Bh7xWfKDvI6NqdLQ5F9
	vgXX/yo0TcJrQVfrgNLK9pD8HrCYtFOc9IputPp5DiRxGrQ5fcalCDPzW/WHQ7EK4MLQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169422-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169422: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 10:29:46 +0000

flight 169422 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169422/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   45 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  410 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 10:56:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 10:56:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305713.520805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfJcr-00020z-8Q; Fri, 15 Apr 2022 10:56:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305713.520805; Fri, 15 Apr 2022 10:56:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfJcr-00020s-5J; Fri, 15 Apr 2022 10:56:29 +0000
Received: by outflank-mailman (input) for mailman id 305713;
 Fri, 15 Apr 2022 10:56:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4CzB=UZ=gmail.com=marco.cacre@srs-se1.protection.inumbo.net>)
 id 1nfJcq-00020i-Hc
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 10:56:28 +0000
Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com
 [2607:f8b0:4864:20::32b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b26dca8a-bcaa-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 12:56:27 +0200 (CEST)
Received: by mail-ot1-x32b.google.com with SMTP id
 e25-20020a0568301e5900b005b236d5d74fso5203678otj.0
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 03:56:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b26dca8a-bcaa-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:from:date:message-id:subject:to;
        bh=/JhnDXHdpjHE4vq5NzzLKIxK+4k+ZM9QlgHgrpe5rT8=;
        b=SgYSfpKAvXyYjX6d7KmiNgvn6/TXipPIVBwJdEJzRTDgoYCnLwF3/HVm5JYEFTGUXy
         vqArY/bomVfSp0/AqJo4H53DpKi5H/NY1ZYvTDSht7JsYIcy7D9RcQLm/fc3FZ6wym7w
         Lxv/WoP8Uar+CHkHZ4rtyGhiOSkPMjS4MIarZfa/GfBJ5vg9mgVlDUHWmt7a0aOyt/Ll
         S2B3sccijh4ntsguH+Iyu1FjUPxoZQdbYa47NzRtmQNQ1yc3S0rmmEvMBacvf1ZovAbd
         n9T7/oGa11uivhms2mmN79apik9DrELpFnR7gCCRKgchhHgMAB7hdeCchIgIRXOfrDbF
         2h4Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=/JhnDXHdpjHE4vq5NzzLKIxK+4k+ZM9QlgHgrpe5rT8=;
        b=WSqYpHYH+BVChu7WJQmLcchRUeG/pkiPKkeR1jGJjScS/baPX6KUujPAD2yUYepeCA
         vuLMLkpny3bbb4qWl9X3On5hyNSdu5qAfw7J0Pkfq8oJ+7tos0D67SHfmW0SbNjEPb45
         Ibap092x4zewlD1q976S12Ai4J1JsFoKWPq2qJ+m5j0Ie+uUYaxR00TCLWMokk6J0BdP
         /0DWQ3GDVvi8+5ekbB++IvPBoMnaCEFk3bwjhNPxpeSIKJNolrXHl9l3tcJeAxg6VZHN
         Zn491vRfBtBV4GGKRW2NlWPT7f0gfGPv94HazS8X8sxlHtIj8Z3YQQL0NWwXLz4ik/Fx
         bWYA==
X-Gm-Message-State: AOAM53007JsVNo83UfIEgRDkeugE4mHpfQL3cMEuQhwBTfB/UnvJ23UK
	4H/rHnttyznBoUlduSkFH7al/ez1rx5Y80p9cGinsphD
X-Google-Smtp-Source: ABdhPJxjIuDdOYPYcL2P7mB9geSE9jqILWHfe+UGYpZ8PsiuBbw0eYjx0l32Q20Vs52H4JyO4cwzI3zYy3lTHvnSH4Q=
X-Received: by 2002:a9d:6c47:0:b0:604:a6f3:f55c with SMTP id
 g7-20020a9d6c47000000b00604a6f3f55cmr99679otq.175.1650020186080; Fri, 15 Apr
 2022 03:56:26 -0700 (PDT)
MIME-Version: 1.0
From: Marco Cacre <marco.cacre@gmail.com>
Date: Fri, 15 Apr 2022 12:56:15 +0200
Message-ID: <CAGHctbYx6sspA__OmKyumU+WkhzEsDpLstyhRDM9Kbc696Co7Q@mail.gmail.com>
Subject: Problem creating domU guest on arm64
To: xen-devel@lists.xenproject.org
Content-Type: multipart/alternative; boundary="00000000000010498605dcaf43ab"

--00000000000010498605dcaf43ab
Content-Type: text/plain; charset="UTF-8"

Hi all,

I'm facing always the same problem (described below) trying to create a Xen
guest domain on rockpro64 (arm64).

I have successfully built uboot, xen (4.14.4) and dom0 linux kernel with
xen tool stack, these two last starting from buildroot (with linux kernel
version 5.15.33 and xen toolstack version 4.14.4)

These are the process of Xen:

177 root    /usr/sbin/xenwatchdogd 30 15
203 root    /usr/sbin/xenstored --pid-file /var/run/xen/xenstored.pid
208 root    /usr/sbin/xenconsoled --pid-file=/var/run/xen/xenconsoled.pid
214 root    /usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 -xen-attach
-name dom0 -nographic -M xenpv -daemonize -monitor /dev/null
-serial/dev/nul -parallel/dev/null -pidfile/var/run/xen/qemu-dom0.pid

and the drivers loaded as a module:
# lsmod
Module                  Size  Used by    Tainted: G
xen_netback            65536  0
xen_blkback            49152  0

Xen and dom0 Image boot up successfully, at the end:
================================================
>xl list
Name                                        ID  Mem VCPUs State Time(s)
Domain-0                                    0  1024    2    r-----    4000.3

# uname -a
Linux rockpro64 5.15.33 #3 SMP PREEMPT Fri Apr 15 11:01:37 CEST 2022
aarch64 GNU/Linux
================================================

when I try to create a domU domain I have problem with disk backend, I have
made several attempts trying with different domU linux and I always get the
following error :

================================================
Parsing config from ./alpine_xen_domu.config

libxl: error: libxl_aoutils.c:539:async_exec_timeout: killing execution of
/etc/xen/scripts/block add because of timeout
libxl: error: libxl_create.c:1608:domcreate_launch_dm: Domain 2:unable to
add disk devices
libxl: error: libxl_aoutils.c:539:async_exec_timeout: killing execution of
/etc/xen/scripts/block remove because of timeout
libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain
2:Non-existant domain
libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 2:Unable
to destroy guest
libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 2:Destruction
of domain failed
================================================

The last try was with alpine domU linux with the following config:
================================================

# Alpine Linux PV DomU
# Kernel paths for install
kernel = "/home/xen/vmlinuz-virt"
ramdisk = "/home/xen/initramfs-virt"
extra="modules=loop,squashfs console=hvc0"
# Path to HDD and iso file
disk = [ 'format=raw, vdev=xvda, access=w, target=/data/a1.img',
        'format=raw, vdev=xvdc, access=r, devtype=cdrom,
target=/home/xen/alpine-virt-3.15.3-armv7.iso'  ]
# Network configuration
vif = ['bridge=br0']
# DomU settings

memory = 512

name = "alpine-a1"

vcpus = 1

maxvcpus = 1
================================================

thanks a lot in advance
Best regards
Marco

--00000000000010498605dcaf43ab
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: base64

PGRpdiBkaXI9Imx0ciI+SGkgYWxsLDxicj48YnI+SSYjMzk7bSBmYWNpbmcgYWx3YXlzIHRoZSBz
YW1lIHByb2JsZW0gKGRlc2NyaWJlZCBiZWxvdykgdHJ5aW5nIHRvIGNyZWF0ZSBhIFhlbiBndWVz
dCBkb21haW4gb24gcm9ja3BybzY0IChhcm02NCkuPGJyPjxicj5JIGhhdmUgc3VjY2Vzc2Z1bGx5
IGJ1aWx0IHVib290LCB4ZW4gKDQuMTQuNCkgYW5kIGRvbTAgbGludXgga2VybmVsIHdpdGggeGVu
IHRvb2wgc3RhY2ssIHRoZXNlIHR3byBsYXN0IHN0YXJ0aW5nIGZyb20gYnVpbGRyb290ICh3aXRo
IGxpbnV4IGtlcm5lbCB2ZXJzaW9uIDUuMTUuMzMgYW5kIHhlbiB0b29sc3RhY2sgdmVyc2lvbiA0
LjE0LjQpPGJyPjxicj5UaGVzZSBhcmUgdGhlIHByb2Nlc3Mgb2YgWGVuOjxicj48YnI+MTc3IHJv
b3QgwqAgwqAvdXNyL3NiaW4veGVud2F0Y2hkb2dkIDMwIDE1PGJyPjIwMyByb290IMKgIMKgL3Vz
ci9zYmluL3hlbnN0b3JlZCAtLXBpZC1maWxlIC92YXIvcnVuL3hlbi94ZW5zdG9yZWQucGlkPGJy
PjIwOCByb290IMKgIMKgL3Vzci9zYmluL3hlbmNvbnNvbGVkIC0tcGlkLWZpbGU9L3Zhci9ydW4v
eGVuL3hlbmNvbnNvbGVkLnBpZDxicj4yMTQgcm9vdCDCoCDCoC91c3IvbGliL3hlbi9iaW4vcWVt
dS1zeXN0ZW0taTM4NiAteGVuLWRvbWlkIDAgLXhlbi1hdHRhY2ggLW5hbWUgZG9tMCAtbm9ncmFw
aGljIC1NIHhlbnB2IC1kYWVtb25pemUgLW1vbml0b3IgL2Rldi9udWxsIC1zZXJpYWwvZGV2L251
bCAtcGFyYWxsZWwvZGV2L251bGwgLXBpZGZpbGUvdmFyL3J1bi94ZW4vcWVtdS1kb20wLnBpZDxi
cj48YnI+YW5kIHRoZSBkcml2ZXJzIGxvYWRlZCBhcyBhIG1vZHVsZTo8YnI+IyBsc21vZDxicj5N
b2R1bGUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBTaXplIMKgVXNlZCBieSDCoCDCoFRhaW50
ZWQ6IEc8YnI+eGVuX25ldGJhY2sgwqAgwqAgwqAgwqAgwqAgwqA2NTUzNiDCoDA8YnI+eGVuX2Js
a2JhY2sgwqAgwqAgwqAgwqAgwqAgwqA0OTE1MiDCoDA8YnI+PGJyPlhlbiBhbmQgZG9tMCBJbWFn
ZSBib290IHVwIHN1Y2Nlc3NmdWxseSwgYXQgdGhlIGVuZDo8YnI+PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PGJyPiZndDt4bCBsaXN0PGJyPk5hbWUgwqAg
wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBJ
RCDCoE1lbSBWQ1BVcyBTdGF0ZSBUaW1lKHMpPGJyPkRvbWFpbi0wIMKgIMKgIMKgIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgMCDCoDEwMjQgwqAgwqAyIMKgIMKg
ci0tLS0tIMKgIMKgNDAwMC4zPGJyPjxicj4jIHVuYW1lIC1hPGJyPkxpbnV4IHJvY2twcm82NCA1
LjE1LjMzICMzIFNNUCBQUkVFTVBUIEZyaSBBcHIgMTUgMTE6MDE6MzcgQ0VTVCAyMDIyIGFhcmNo
NjQgR05VL0xpbnV4PGJyPj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PTxicj48YnI+d2hlbiBJIHRyeSB0byBjcmVhdGUgYSBkb21VIGRvbWFpbiBJIGhhdmUg
cHJvYmxlbSB3aXRoIGRpc2sgYmFja2VuZCwgSSBoYXZlIG1hZGUgc2V2ZXJhbCBhdHRlbXB0cyB0
cnlpbmcgd2l0aCBkaWZmZXJlbnQgZG9tVSBsaW51eCBhbmQgSSBhbHdheXMgZ2V0IHRoZSBmb2xs
b3dpbmcgZXJyb3IgOjxicj48YnI+PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PGJyPlBhcnNpbmcgY29uZmlnIGZyb20gLi9hbHBpbmVfeGVuX2RvbXUuY29u
ZmlnPGJyPjxicj5saWJ4bDogZXJyb3I6IGxpYnhsX2FvdXRpbHMuYzo1Mzk6YXN5bmNfZXhlY190
aW1lb3V0OiBraWxsaW5nIGV4ZWN1dGlvbiBvZiAvZXRjL3hlbi9zY3JpcHRzL2Jsb2NrIGFkZCBi
ZWNhdXNlIG9mIHRpbWVvdXQ8YnI+bGlieGw6IGVycm9yOiBsaWJ4bF9jcmVhdGUuYzoxNjA4OmRv
bWNyZWF0ZV9sYXVuY2hfZG06IERvbWFpbiAyOnVuYWJsZSB0byBhZGQgZGlzayBkZXZpY2VzPGJy
PmxpYnhsOiBlcnJvcjogbGlieGxfYW91dGlscy5jOjUzOTphc3luY19leGVjX3RpbWVvdXQ6IGtp
bGxpbmcgZXhlY3V0aW9uIG9mIC9ldGMveGVuL3NjcmlwdHMvYmxvY2sgcmVtb3ZlIGJlY2F1c2Ug
b2YgdGltZW91dDxicj5saWJ4bDogZXJyb3I6IGxpYnhsX2RvbWFpbi5jOjExODI6bGlieGxfX2Rl
c3Ryb3lfZG9taWQ6IERvbWFpbiAyOk5vbi1leGlzdGFudCBkb21haW48YnI+bGlieGw6IGVycm9y
OiBsaWJ4bF9kb21haW4uYzoxMTM2OmRvbWFpbl9kZXN0cm95X2NhbGxiYWNrOiBEb21haW4gMjpV
bmFibGUgdG8gZGVzdHJveSBndWVzdDxicj5saWJ4bDogZXJyb3I6IGxpYnhsX2RvbWFpbi5jOjEw
NjM6ZG9tYWluX2Rlc3Ryb3lfY2I6IERvbWFpbiAyOkRlc3RydWN0aW9uIG9mIGRvbWFpbiBmYWls
ZWQ8YnI+PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PGJy
Pjxicj5UaGUgbGFzdCB0cnkgd2FzIHdpdGggYWxwaW5lIGRvbVUgbGludXggd2l0aCB0aGUgZm9s
bG93aW5nIGNvbmZpZzo8YnI+PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PGJyPjxicj4jIEFscGluZSBMaW51eCBQViBEb21VPGJyPiMgS2VybmVsIHBhdGhz
IGZvciBpbnN0YWxsPGJyPmtlcm5lbCA9ICZxdW90Oy9ob21lL3hlbi92bWxpbnV6LXZpcnQmcXVv
dDs8YnI+cmFtZGlzayA9ICZxdW90Oy9ob21lL3hlbi9pbml0cmFtZnMtdmlydCZxdW90Ozxicj5l
eHRyYT0mcXVvdDttb2R1bGVzPWxvb3Asc3F1YXNoZnMgY29uc29sZT1odmMwJnF1b3Q7PGJyPiMg
UGF0aCB0byBIREQgYW5kIGlzbyBmaWxlPGJyPmRpc2sgPSBbICYjMzk7Zm9ybWF0PXJhdywgdmRl
dj14dmRhLCBhY2Nlc3M9dywgdGFyZ2V0PS9kYXRhL2ExLmltZyYjMzk7LDxicj7CoCDCoCDCoCDC
oCAmIzM5O2Zvcm1hdD1yYXcsIHZkZXY9eHZkYywgYWNjZXNzPXIsIGRldnR5cGU9Y2Ryb20sIHRh
cmdldD0vaG9tZS94ZW4vYWxwaW5lLXZpcnQtMy4xNS4zLWFybXY3LmlzbyYjMzk7IMKgXTxicj4j
IE5ldHdvcmsgY29uZmlndXJhdGlvbiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoDxicj52aWYgPSBbJiMzOTticmlkZ2U9YnIwJiMzOTtd
PGJyPiMgRG9tVSBzZXR0aW5ncyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoDxi
cj5tZW1vcnkgPSA1MTIgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqA8
YnI+bmFtZSA9ICZxdW90O2FscGluZS1hMSZxdW90OyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoDxicj52Y3B1cyA9IDEgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgwqA8YnI+bWF4dmNwdXMgPSAxPGJyPj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PTxicj48YnI+dGhhbmtzIGEgbG90IGluIGFkdmFuY2U8YnI+QmVz
dCByZWdhcmRzPGZvbnQgY29sb3I9IiM4ODg4ODgiPjxicj5NYXJjbzwvZm9udD48YnI+PC9kaXY+
DQo=
--00000000000010498605dcaf43ab--


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 11:07:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 11:07:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305726.520815 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfJmq-0003e8-7h; Fri, 15 Apr 2022 11:06:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305726.520815; Fri, 15 Apr 2022 11:06:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfJmq-0003e1-4g; Fri, 15 Apr 2022 11:06:48 +0000
Received: by outflank-mailman (input) for mailman id 305726;
 Fri, 15 Apr 2022 11:06:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GqiY=UZ=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nfJmo-0003dv-OA
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 11:06:46 +0000
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com
 [2a00:1450:4864:20::12e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2355faae-bcac-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 13:06:45 +0200 (CEST)
Received: by mail-lf1-x12e.google.com with SMTP id u7so13529505lfs.8
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 04:06:45 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 u20-20020a2ea174000000b0024daa37e1b9sm47007ljl.42.2022.04.15.04.06.43
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 15 Apr 2022 04:06:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2355faae-bcac-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=9OZ0DfSHkuifjXA+DSw6eW4ayG5DohDS90ciIVw9aDA=;
        b=qrJ4Gj9j7MYNfbOFOHoNEmPF4/sRHBmP/5QqKRwVY+TUn2YsHnLbKCZG/JQ6MxhTqe
         F1t85WXInHtX/2IOtS9A4+1NNz67SPsPIUvX8H6pD8o8J29GlIspabwnrzY2jVKuACXM
         yNWy7e0TJ6+3BdgJcR2OXjnZEzgXEnd3fkge71SV5W4JAxBUIXfFqbjmxA0yQXDjH1zp
         wqdImTm93fbf/sN1O0lNYi/S8SsL6E/ygJpQKrCuYWSFLSqd9RuEO711nWI8DnKX3qyi
         NdDqlXWrNTWIb8UIS/9KZRckwte9mRWmuY9ot8WlB/THL0Ei6xblHjDdG/RTJmJGLXVk
         NCCw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=9OZ0DfSHkuifjXA+DSw6eW4ayG5DohDS90ciIVw9aDA=;
        b=1QB1IKWF+sM0WcB0bF2SBOLn7/dbiu0NOZMt0RoEVvtWVyfcLA9rMSav3Fd9ujSjyH
         GQ3TV+HndEewx19BUbqLW0mELuA4X3aR3ljZj1CHlk3ObES3TvDonp7Vp2durdlGdixR
         JQ9FnqqNUwag5nT/EVf5lFj24jK6mA8yBLAiwkRfvjyeMWWaLXoS+o4eA1FOQG8kGq2F
         5Yv7itTGJy+qlTxGy3Yp4Z8dS/NwtBZYKg8HvbF5rNR/2iTHOLq1YTLHz4LWetuZ4RIt
         JCRekx0FBisDxPqL8Ip55cjHS9nTlqBuOsKFdcjM97jo1Hq1sAZ5mZ7vJA2qyKGhpjlp
         CbRw==
X-Gm-Message-State: AOAM533aQvrsvONxfkh6u1ZszZJU61GFzHgc3TshqGT7j0eKAeSN/SP1
	nEmhYLcqe3t7umFto1gwh4M=
X-Google-Smtp-Source: ABdhPJzZJ3c3sR0XS14bKxbAClozJqziR03ZDWQ8k0vcdD2EvEID7ve1ZL+FxpnjzYBkOZ5Uj9DdKg==
X-Received: by 2002:a05:6512:3e1f:b0:464:f5e3:d8a2 with SMTP id i31-20020a0565123e1f00b00464f5e3d8a2mr4945816lfv.366.1650020804961;
        Fri, 15 Apr 2022 04:06:44 -0700 (PDT)
Subject: Re: [Stratos-dev] Xen Rust VirtIO demos work breakdown for Project
 Stratos
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Rust-VMM Mailing List <rust-vmm@lists.opendev.org>,
 Stratos Mailing List <stratos-dev@op-lists.linaro.org>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Sergio Lopez <slp@redhat.com>, Wei Liu <wl@xen.org>,
 Stefan Hajnoczi <stefanha@gmail.com>, Doug Goldstein <cardoe@cardoe.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Arnd Bergmann <arnd.bergmann@linaro.org>,
 David Woodhouse <dwmw2@infradead.org>, Rich Persaud <persaur@gmail.com>,
 Daniel Smith <dpsmith@apertussolutions.com>, Paul Durrant <paul@xen.org>,
 openxt <openxt@googlegroups.com>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
References: <87pmsylywy.fsf@linaro.org> <YU5mW396S04IsCBr@mail-itl>
 <874ka68h96.fsf@linaro.org>
 <CACMJ4GbgnQVQbH1N3Duxmx10n-Qv+zzncqarNyuhmKhE-wqdqA@mail.gmail.com>
 <alpine.DEB.2.21.2109272323160.5022@sstabellini-ThinkPad-T480s>
 <CAPD2p-=MdGB_a+oEsFrPQpLo7GeKkMwYyAWcQt3z0qrGr3vR7w@mail.gmail.com>
 <alpine.DEB.2.21.2110011649220.3209@sstabellini-ThinkPad-T480s>
 <CAPD2p-m=hYbG1YjPZ9yZ7Qzs6KjCT2jSHpaDUPB0sFJoZfY4uw@mail.gmail.com>
 <alpine.DEB.2.21.2110041436070.3209@sstabellini-ThinkPad-T480s>
 <1d6382b6-ddf8-494c-4f7b-afc50a4269a4@gmail.com>
 <CAPD2p-nftmTXQTaOw1kmkBDn96i8sgcaH21o7bsGK-fA+fYbaw@mail.gmail.com>
 <87pmlisnst.fsf@linaro.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6bf0ebc5-fe3c-5c59-0427-87f02a35e7f2@gmail.com>
Date: Fri, 15 Apr 2022 14:06:42 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <87pmlisnst.fsf@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 15.04.22 12:07, Alex Bennée wrote:


Hello Alex

> Oleksandr Tyshchenko <olekstysh@gmail.com> writes:
>
>> Hello all.
>>
>> [Sorry for the possible format issues]
>>
>> I have an update regarding (valid) concern which has been also raised in current thread which is the virtio backend's ability (when using
>> Xen foreign mapping) to map any guest pages without guest "agreement" on that.
>> There is a PoC (with virtio-mmio on Arm) which is based on Juergen Gross’  work to reuse secure Xen grant mapping for the virtio
>> communications.
>> All details are at:
>> https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-olekstysh@gmail.com/
>> https://lore.kernel.org/xen-devel/1649964960-24864-1-git-send-email-olekstysh@gmail.com/
> Thanks for that. I shall try and find some time to have a look at it.
>
> Did you see Viresh's post about getting our rust-vmm vhost-user backends
> working on Xen?

Great work! I see the email in my mailbox, but didn't analyze it yet. I 
will definitely take a look at it.


>
> One thing that came up during that work was how guest pages are mapped
> into the dom0 domain where Xen needs to use kernel allocated pages via
> privcmd rather than then normal shared mmap that is used on KVM. As I
> understand it this is to avoid the situation where dom0 may invalidate a
> user PTE causing issues for the hypervisor itself. At some point we
> would like to fix that wrinkle so we can remove the (minor) hack in
> rust-vmm's mmap code to be truly hypervisor agnostic.
>
> Anyway I hope you and your team are safe and well.

Thank you!


>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 11:19:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 11:19:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305732.520827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfJyZ-0005AU-C3; Fri, 15 Apr 2022 11:18:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305732.520827; Fri, 15 Apr 2022 11:18:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfJyZ-0005AN-91; Fri, 15 Apr 2022 11:18:55 +0000
Received: by outflank-mailman (input) for mailman id 305732;
 Fri, 15 Apr 2022 11:18:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfJyX-0005AD-Nb; Fri, 15 Apr 2022 11:18:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfJyX-000153-MZ; Fri, 15 Apr 2022 11:18:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfJyX-0005Uk-Fp; Fri, 15 Apr 2022 11:18:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfJyX-0002CN-FK; Fri, 15 Apr 2022 11:18:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rMD/6UyNLbDarrdP2ptWY766pNdNDGjzZxDn9zwCkgo=; b=ek1zCsET/wSvsAAjhMRm1+BIQL
	D9R7A1odRUECBxkVSgyYMYVSHTH6+9gySDsW6pG1g855zXxkEYPltLDJPK5RrU7zNQBAXBD7uVfPZ
	6dQSzEwSvzkm8d8eEkqnb+29DMOnigm1SVNFLbcI3KOIWqrvIF6yKFLT7p1qIoUn7Jgg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169424-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169424: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 11:18:53 +0000

flight 169424 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169424/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  411 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 12:37:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 12:37:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305764.520837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfLC0-0005Ay-ED; Fri, 15 Apr 2022 12:36:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305764.520837; Fri, 15 Apr 2022 12:36:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfLC0-0005Ar-BI; Fri, 15 Apr 2022 12:36:52 +0000
Received: by outflank-mailman (input) for mailman id 305764;
 Fri, 15 Apr 2022 12:36:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfLBy-0005Ah-WF; Fri, 15 Apr 2022 12:36:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfLBy-0002SR-Tl; Fri, 15 Apr 2022 12:36:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfLBy-0001FC-J6; Fri, 15 Apr 2022 12:36:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfLBy-0003lh-HD; Fri, 15 Apr 2022 12:36:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WcUHhJBr2LfJCWIE3c1mrRzmjtrlp6asG2jrS2DgXvw=; b=nLwKQ540n+5Rrz4cZ9HGvPd5o7
	l6YDDXWl16D4M16F/4j5/Lys0arNPeYC4FCLqfNsJ84IghgE66Eqr4nUHWZwezoQitWXUn0KSZ9bf
	a0X8eJVGXjYa/N0rUT+ImwdSWoZnveWuPNa2FnFzgaqan/l2M2N83sHMn7KupTt/4J58=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169425-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169425: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 12:36:50 +0000

flight 169425 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169425/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  412 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 13:52:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 13:52:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305775.520848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfMMm-0004ep-3z; Fri, 15 Apr 2022 13:52:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305775.520848; Fri, 15 Apr 2022 13:52:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfMMm-0004ei-0s; Fri, 15 Apr 2022 13:52:04 +0000
Received: by outflank-mailman (input) for mailman id 305775;
 Fri, 15 Apr 2022 13:52:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfMMk-0004eY-KT; Fri, 15 Apr 2022 13:52:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfMMk-0003h4-I2; Fri, 15 Apr 2022 13:52:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfMMk-0005Yw-4i; Fri, 15 Apr 2022 13:52:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfMMk-0008V6-4A; Fri, 15 Apr 2022 13:52:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9j5baCWTMTzmtfQ+oUQsDMCqUFaT/L4r/3jTTCVljcU=; b=0zRaCZ7JbonWbSJfY86dPqS55g
	9RIg/G96hrdCCXgOQsbfgrgEjUDslhP15T653U30GVwddBGAF3ZVYmqq8oI1fnH4IpEwvdrs5btNp
	krGeIYaCw52otkmcVx2kBU3Igw1Ix4xyNHVQaT+8KnrN02nvxSV9UCbj7ta/PPmx0tXs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169427-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169427: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 13:52:02 +0000

flight 169427 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169427/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  413 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 15:04:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 15:04:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305786.520859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfNUU-0003Lu-Fe; Fri, 15 Apr 2022 15:04:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305786.520859; Fri, 15 Apr 2022 15:04:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfNUU-0003Ln-CI; Fri, 15 Apr 2022 15:04:06 +0000
Received: by outflank-mailman (input) for mailman id 305786;
 Fri, 15 Apr 2022 15:04:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfNUS-0003Ld-FR; Fri, 15 Apr 2022 15:04:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfNUS-000530-AX; Fri, 15 Apr 2022 15:04:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfNUS-0001hW-2d; Fri, 15 Apr 2022 15:04:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfNUS-00067E-27; Fri, 15 Apr 2022 15:04:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MfXbMXc6kAo3Nq1ZX/+6VfpvEBAEzSMg9VZaBeeWrbg=; b=LYmOeS/WJvf5SDSxX/ME83d0jX
	VPskxTs09Z/RSNhivyiK3LCm6CvIzc5meAMPYwd331zF+EjMYjb0HckNB5mqx1+UzxGrnxVJ7Zbyj
	SEeDwKHUu3ecWnAy2XYKm7OFJwZIw7O7eMWK+2wCX7NBtojgZ4HE0Dll5s2w5aRNYkdo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169428-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169428: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 15:04:04 +0000

flight 169428 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169428/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  414 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 15:21:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 15:21:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305796.520871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfNkr-0005hV-00; Fri, 15 Apr 2022 15:21:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305796.520871; Fri, 15 Apr 2022 15:21:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfNkq-0005hO-Rc; Fri, 15 Apr 2022 15:21:00 +0000
Received: by outflank-mailman (input) for mailman id 305796;
 Fri, 15 Apr 2022 15:21:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GqiY=UZ=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nfNkq-0005hI-7z
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 15:21:00 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a695e358-bccf-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 17:20:58 +0200 (CEST)
Received: by mail-lj1-x234.google.com with SMTP id 17so9852063lji.1
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 08:20:58 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 p25-20020a056512313900b0046f4f252ebfsm175823lfd.226.2022.04.15.08.20.55
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 15 Apr 2022 08:20:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a695e358-bccf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=tKPtQz+15frjCFqtKqOJi6EaMDFvouH7Zhy6D7XdcRQ=;
        b=iMQhO3UyThOnnoJuPW45l59saUXzOpnn2SSyXXhV0SO20SvDU4ozWdMEcvNk1cYhWE
         JJXUs8s8k7ddksgmfTzy0juYSOz3O2OPfA/xQuaDAUHQhtvtvvioZHE121kzLCXYCEIv
         w9OBPAWtl/2kxVdgDLFK+taJvIEqzadWKar7xfr1RhPp8OuuaOgsOIkCDBbQIf1tnNzI
         Okk3WO387jSJMT0Td/g756NWcFrxa+x/6s2PQEwj5758Q0xEaz3xa9LEh1SQwRoS2ucm
         CP0l4F/nBniNW/TODw0pTAKBtMyWrpUfJVf6RyIIXfI87N7xjLF9okkr/lJTtAiF1w7n
         VPxQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=tKPtQz+15frjCFqtKqOJi6EaMDFvouH7Zhy6D7XdcRQ=;
        b=rQ6A8M/uifHnJXvgJVLnM/Ck0cJEIWAxNeuc3BeoP1uuZWhQ7Rkj2FhvgliweTTNC9
         Osm5cxPJlv3WxvBEtQks0kGF55dLN9l9qkExUqN9TlVzrD8PRzZ+19ZcTWhAffKpnjYe
         D8159lMxYpQ/7yj8nQo9j3d3pC0FZYLx69nn4EtSGhT8tarXrnd7pJYogRxRA+cvizci
         eCrKO7O/CwDIU361WLqiSiyR+iQTJ7uz0+b5/S4D2+O08DqXmpSYwhS/Sen/LT66Pobk
         Mu1KcgsA3XPu5cUb9wwFN1v8LQnHOU0102QiMYnY+hOv8lDt6JLiqvgtOAJhoowtGK8k
         aF8w==
X-Gm-Message-State: AOAM531CQ/lbG6kKAqZ64dQmSFQjV4uhldVws4InvxiVs3Yud3fov8yu
	Y6UrV6FsgEd44fLcyuFkqVY=
X-Google-Smtp-Source: ABdhPJziuyJyQYEu7x8SHebulqTxg+V1vpGA+dmLswY7ea4Efi9mFESgm9VTDaGLQC3z9xTvYuj0bg==
X-Received: by 2002:a2e:a553:0:b0:24b:2081:2bbf with SMTP id e19-20020a2ea553000000b0024b20812bbfmr4632775ljn.414.1650036057479;
        Fri, 15 Apr 2022 08:20:57 -0700 (PDT)
Subject: Re: [RFC PATCH 2/6] virtio: add option to restrict memory access
 under Xen
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Boris Ostrovsky
 <boris.ostrovsky@oracle.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Christoph Hellwig <hch@infradead.org>, "Michael S. Tsirkin"
 <mst@redhat.com>, linux-arm-kernel@lists.infradead.org
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
 <5A795507-715D-494B-B56B-B12E5BE348A4@zytor.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6b3ceb42-5848-4a1b-61d7-f37c4a18d725@gmail.com>
Date: Fri, 15 Apr 2022 18:20:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <5A795507-715D-494B-B56B-B12E5BE348A4@zytor.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 14.04.22 22:43, H. Peter Anvin wrote:

Hello Peter


> On April 14, 2022 12:19:29 PM PDT, Oleksandr Tyshchenko <olekstysh@gmail.com> wrote:
>> From: Juergen Gross <jgross@suse.com>
>>
>> In order to support virtio in Xen guests add a config option enabling
>> the user to specify whether in all Xen guests virtio should be able to
>> access memory via Xen grant mappings only on the host side.
>>
>> This applies to fully virtualized guests only, as for paravirtualized
>> guests this is mandatory.
>>
>> This requires to switch arch_has_restricted_virtio_memory_access()
> >from a pure stub to a real function on x86 systems (Arm systems are
>> not covered by now).
>>
>> Add the needed functionality by providing a special set of DMA ops
>> handling the needed grant operations for the I/O pages.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> arch/x86/mm/init.c        |  15 ++++
>> arch/x86/mm/mem_encrypt.c |   5 --
>> arch/x86/xen/Kconfig      |   9 +++
>> drivers/xen/Kconfig       |  20 ++++++
>> drivers/xen/Makefile      |   1 +
>> drivers/xen/xen-virtio.c  | 177 ++++++++++++++++++++++++++++++++++++++++++++++
>> include/xen/xen-ops.h     |   8 +++
>> 7 files changed, 230 insertions(+), 5 deletions(-)
>> create mode 100644 drivers/xen/xen-virtio.c
>>
>> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
>> index d8cfce2..526a3b2 100644
>> --- a/arch/x86/mm/init.c
>> +++ b/arch/x86/mm/init.c
>> @@ -8,6 +8,8 @@
>> #include <linux/kmemleak.h>
>> #include <linux/sched/task.h>
>>
>> +#include <xen/xen.h>
>> +
>> #include <asm/set_memory.h>
>> #include <asm/e820/api.h>
>> #include <asm/init.h>
>> @@ -1065,3 +1067,16 @@ unsigned long max_swapfile_size(void)
>> 	return pages;
>> }
>> #endif
>> +
>> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>> +int arch_has_restricted_virtio_memory_access(void)
>> +{
>> +	if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
>> +		return 1;
>> +	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
>> +		return 1;
>> +
>> +	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
>> +}
>> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>> +#endif
>> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
>> index 50d2099..dda020f 100644
>> --- a/arch/x86/mm/mem_encrypt.c
>> +++ b/arch/x86/mm/mem_encrypt.c
>> @@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
>> 	print_mem_encrypt_feature_info();
>> }
>>
>> -int arch_has_restricted_virtio_memory_access(void)
>> -{
>> -	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
>> -}
>> -EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
>> index 85246dd..dffdffd 100644
>> --- a/arch/x86/xen/Kconfig
>> +++ b/arch/x86/xen/Kconfig
>> @@ -92,3 +92,12 @@ config XEN_DOM0
>> 	select X86_X2APIC if XEN_PVH && X86_64
>> 	help
>> 	  Support running as a Xen Dom0 guest.
>> +
>> +config XEN_PV_VIRTIO
>> +	bool "Xen virtio support for PV guests"
>> +	depends on XEN_VIRTIO && XEN_PV
>> +	default y
>> +	help
>> +	  Support virtio for running as a paravirtualized guest. This will
>> +	  need support on the backend side (qemu or kernel, depending on the
>> +	  virtio device types used).
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index 120d32f..fc61f7a 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -335,4 +335,24 @@ config XEN_UNPOPULATED_ALLOC
>> 	  having to balloon out RAM regions in order to obtain physical memory
>> 	  space to create such mappings.
>>
>> +config XEN_VIRTIO
>> +	bool "Xen virtio support"
>> +	default n
>> +	depends on VIRTIO && DMA_OPS
>> +	select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>> +	help
>> +	  Enable virtio support for running as Xen guest. Depending on the
>> +	  guest type this will require special support on the backend side
>> +	  (qemu or kernel, depending on the virtio device types used).
>> +
>> +config XEN_HVM_VIRTIO_GRANT
>> +	bool "Require virtio for fully virtualized guests to use grant mappings"
>> +	depends on XEN_VIRTIO && X86_64
>> +	default y
>> +	help
>> +	  Require virtio for fully virtualized guests to use grant mappings.
>> +	  This will avoid the need to give the backend the right to map all
>> +	  of the guest memory. This will need support on the backend side
>> +	  (qemu or kernel, depending on the virtio device types used).
>> +
>> endmenu
>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>> index 5aae66e..767009c 100644
>> --- a/drivers/xen/Makefile
>> +++ b/drivers/xen/Makefile
>> @@ -39,3 +39,4 @@ xen-gntalloc-y				:= gntalloc.o
>> xen-privcmd-y				:= privcmd.o privcmd-buf.o
>> obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)	+= xen-front-pgdir-shbuf.o
>> obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)	+= unpopulated-alloc.o
>> +obj-$(CONFIG_XEN_VIRTIO)		+= xen-virtio.o
>> diff --git a/drivers/xen/xen-virtio.c b/drivers/xen/xen-virtio.c
>> new file mode 100644
>> index 00000000..cfd5eda
>> --- /dev/null
>> +++ b/drivers/xen/xen-virtio.c
>> @@ -0,0 +1,177 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/******************************************************************************
>> + * Xen virtio driver - enables using virtio devices in Xen guests.
>> + *
>> + * Copyright (c) 2021, Juergen Gross <jgross@suse.com>
>> + */
>> +
>> +#include <linux/module.h>
>> +#include <linux/dma-map-ops.h>
>> +#include <linux/pci.h>
>> +#include <linux/pfn.h>
>> +#include <linux/virtio_config.h>
>> +#include <xen/xen.h>
>> +#include <xen/grant_table.h>
>> +
>> +#define XEN_GRANT_ADDR_OFF	0x8000000000000000ULL
>> +
>> +static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>> +{
>> +	return XEN_GRANT_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
>> +}
>> +
>> +static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>> +{
>> +	return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT);
>> +}
>> +
>> +/*
>> + * DMA ops for Xen virtio frontends.
>> + *
>> + * Used to act as a kind of software IOMMU for Xen guests by using grants as
>> + * DMA addresses.
>> + * Such a DMA address is formed by using the grant reference as a frame
>> + * number and setting the highest address bit (this bit is for the backend
>> + * to be able to distinguish it from e.g. a mmio address).
>> + *
>> + * Note that for now we hard wire dom0 to be the backend domain. In order to
>> + * support any domain as backend we'd need to add a way to communicate the
>> + * domid of this backend, e.g. via Xenstore or via the PCI-device's config
>> + * space.
>> + */
>> +static void *xen_virtio_dma_alloc(struct device *dev, size_t size,
>> +				  dma_addr_t *dma_handle, gfp_t gfp,
>> +				  unsigned long attrs)
>> +{
>> +	unsigned int n_pages = PFN_UP(size);
>> +	unsigned int i;
>> +	unsigned long pfn;
>> +	grant_ref_t grant;
>> +	void *ret;
>> +
>> +	ret = (void *)__get_free_pages(gfp, get_order(size));
>> +	if (!ret)
>> +		return NULL;
>> +
>> +	pfn = virt_to_pfn(ret);
>> +
>> +	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
>> +		free_pages((unsigned long)ret, get_order(size));
>> +		return NULL;
>> +	}
>> +
>> +	for (i = 0; i < n_pages; i++) {
>> +		gnttab_grant_foreign_access_ref(grant + i, 0,
>> +						pfn_to_gfn(pfn + i), 0);
>> +	}
>> +
>> +	*dma_handle = grant_to_dma(grant);
>> +
>> +	return ret;
>> +}
>> +
>> +static void xen_virtio_dma_free(struct device *dev, size_t size, void *vaddr,
>> +				dma_addr_t dma_handle, unsigned long attrs)
>> +{
>> +	unsigned int n_pages = PFN_UP(size);
>> +	unsigned int i;
>> +	grant_ref_t grant;
>> +
>> +	grant = dma_to_grant(dma_handle);
>> +
>> +	for (i = 0; i < n_pages; i++)
>> +		gnttab_end_foreign_access_ref(grant + i);
>> +
>> +	gnttab_free_grant_reference_seq(grant, n_pages);
>> +
>> +	free_pages((unsigned long)vaddr, get_order(size));
>> +}
>> +
>> +static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_t size,
>> +					       dma_addr_t *dma_handle,
>> +					       enum dma_data_direction dir,
>> +					       gfp_t gfp)
>> +{
>> +	WARN_ONCE(1, "xen_virtio_dma_alloc_pages size %ld\n", size);
>> +	return NULL;
>> +}
>> +
>> +static void xen_virtio_dma_free_pages(struct device *dev, size_t size,
>> +				      struct page *vaddr, dma_addr_t dma_handle,
>> +				      enum dma_data_direction dir)
>> +{
>> +	WARN_ONCE(1, "xen_virtio_dma_free_pages size %ld\n", size);
>> +}
>> +
>> +static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct page *page,
>> +					  unsigned long offset, size_t size,
>> +					  enum dma_data_direction dir,
>> +					  unsigned long attrs)
>> +{
>> +	grant_ref_t grant;
>> +
>> +	if (gnttab_alloc_grant_references(1, &grant))
>> +		return 0;
>> +
>> +	gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page),
>> +					dir == DMA_TO_DEVICE);
>> +
>> +	return grant_to_dma(grant) + offset;
>> +}
>> +
>> +static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>> +				      size_t size, enum dma_data_direction dir,
>> +				      unsigned long attrs)
>> +{
>> +	grant_ref_t grant;
>> +
>> +	grant = dma_to_grant(dma_handle);
>> +
>> +	gnttab_end_foreign_access_ref(grant);
>> +
>> +	gnttab_free_grant_reference(grant);
>> +}
>> +
>> +static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist *sg,
>> +				 int nents, enum dma_data_direction dir,
>> +				 unsigned long attrs)
>> +{
>> +	WARN_ONCE(1, "xen_virtio_dma_map_sg nents %d\n", nents);
>> +	return -EINVAL;
>> +}
>> +
>> +static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
>> +				    int nents, enum dma_data_direction dir,
>> +				    unsigned long attrs)
>> +{
>> +	WARN_ONCE(1, "xen_virtio_dma_unmap_sg nents %d\n", nents);
>> +}
>> +
>> +static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask)
>> +{
>> +	return 1;
>> +}
>> +
>> +static const struct dma_map_ops xen_virtio_dma_ops = {
>> +	.alloc = xen_virtio_dma_alloc,
>> +	.free = xen_virtio_dma_free,
>> +	.alloc_pages = xen_virtio_dma_alloc_pages,
>> +	.free_pages = xen_virtio_dma_free_pages,
>> +	.mmap = dma_common_mmap,
>> +	.get_sgtable = dma_common_get_sgtable,
>> +	.map_page = xen_virtio_dma_map_page,
>> +	.unmap_page = xen_virtio_dma_unmap_page,
>> +	.map_sg = xen_virtio_dma_map_sg,
>> +	.unmap_sg = xen_virtio_dma_unmap_sg,
>> +	.dma_supported = xen_virtio_dma_dma_supported,
>> +};
>> +
>> +void xen_virtio_setup_dma_ops(struct device *dev)
>> +{
>> +	dev->dma_ops = &xen_virtio_dma_ops;
>> +}
>> +EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops);
>> +
>> +MODULE_DESCRIPTION("Xen virtio support driver");
>> +MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
>> +MODULE_LICENSE("GPL");
>> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>> index a3584a3..ae3c1bc 100644
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { }
>>
>> #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
>>
>> +#ifdef CONFIG_XEN_VIRTIO
>> +void xen_virtio_setup_dma_ops(struct device *dev);
>> +#else
>> +static inline void xen_virtio_setup_dma_ops(struct device *dev)
>> +{
>> +}
>> +#endif /* CONFIG_XEN_VIRTIO */
>> +
>> #endif /* INCLUDE_XEN_OPS_H */
> Can you please encapsulate the Xen part of the test in some Xen-specific file?

I assume your question is about changes to common arch/x86/mm/init.c?


#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
int arch_has_restricted_virtio_memory_access(void)
{
     if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
         return 1;
     if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
         return 1;

     return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
}
EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);


If we are speaking about the whole function, then I am not sure, 
unfortunately. I think, if this was a purely Xen specific function 
(which was used by Xen guests only) I would move it somewhere to 
arch/x86/xen/...   (probably to arch/x86/xen/enlighten.c).

As I understand (please bear in mind I am not too familiar with x86 
code), so far this function was only used by SEV guests, but with 
current changes it is going to be used by both Xen and SEV guests, so it 
should be available even if Xen support is compiled out. Could you 
please suggest a better place to keep this stuff?


If we are speaking about only Xen specific bits in that function, then 
definitely yes, for example, in this way:

1. arch/x86/mm/init.c or other common (non-Xen specific) location:

#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
int arch_has_restricted_virtio_memory_access(void)
{
     return (xen_has_restricted_virtio_memory_access() ||
             cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
}
EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
#endif

2.  include/xen/xen.h or other Xen specific location:

static inline int xen_has_restricted_virtio_memory_access(void)
{
     if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
         return 1;
     if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
         return 1;

     return 0;
}

Or I misunderstood your question?

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 15:30:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 15:30:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305802.520882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfNtX-0006Tb-V5; Fri, 15 Apr 2022 15:29:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305802.520882; Fri, 15 Apr 2022 15:29:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfNtX-0006TU-S9; Fri, 15 Apr 2022 15:29:59 +0000
Received: by outflank-mailman (input) for mailman id 305802;
 Fri, 15 Apr 2022 15:29:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GqiY=UZ=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nfNtW-0006TO-Eu
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 15:29:58 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e7dc6ce9-bcd0-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 17:29:57 +0200 (CEST)
Received: by mail-lf1-x12f.google.com with SMTP id g19so655699lfv.2
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 08:29:57 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 k15-20020a2e92cf000000b002493cc687f3sm306793ljh.45.2022.04.15.08.29.55
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 15 Apr 2022 08:29:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7dc6ce9-bcd0-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=HL1TptI/3GtEHoAEr6jgXfR6NOOXBI/okx+jAapSegA=;
        b=eGddImuMmSOl3LcNuqTpT7K9ZL8iCjmwgxofKW7ht3Uk3JRubmks2WiLlqpBXSr1qS
         RK3VJXyuo6udZuS2bPlaPW49IjORlzh6jUv3jnHzDJ59AxdpiPxlJhRJ0YFcoacIYNKl
         pipMBLfJayeC8olZ/1827EaP56sCpiMmFxux/Qe6aqPPZ5EgfEbm4Pzs1r8HhCgT3BEI
         VOwXNdFHqmaPRfUexgZpgpCXwVuhmHy/N65russv34m6G3Nbm0waba56RK2Av9HSBa2Z
         dOd6WfICrgB76klVBL3gnR1cW24uxPRZcDlssl6kzJl27NNNviM7cWTNcmbxxWHoa+4z
         wlMg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=HL1TptI/3GtEHoAEr6jgXfR6NOOXBI/okx+jAapSegA=;
        b=E3O2pxYYeCcRvwOh6aIPa4udwdZ48l3paM2NuK9EJ1Px+Vfz1View49bDpwSPgxbB7
         b6Uc4iTAZTsR9NWZec8xjLWfwiN8Q6VdhrK/TmwEVdQorvyfEEf+3qE+y71t19rKU6yB
         soqfMzul/21xSi8Gea9XYsTGhErF7a3h3g/LPYHxDg9khTdMD4aRyzWV5Ap1Vmj1nOP2
         niLgNkC3pvq7GK8pm9wA9RRy0+Z0htjrU2zpw+I21VwUXgOn/wKxQrAxZxDKu5/ipxd7
         /7SXnyWirP3dc5f+Kzogg8XIdNUe4n2+LQOCffH45AdI9NlyVDAfPdZCnI89wr2q+sSF
         oMHQ==
X-Gm-Message-State: AOAM532nfT+vZ99J6qXD9Lmo0XcVoT00uW9GeXlX4Gl8AlHn/0RzGt4n
	Dl6LfzmU1iG8y0SyF7Zpy/M=
X-Google-Smtp-Source: ABdhPJyrKcKa96eBJYqES8xrdpgPF+J4GHxlt596kf7yccL7/6Po/qumO4NBK1RNMWLXvzRCcCvcMw==
X-Received: by 2002:a05:6512:3d28:b0:46d:d45:8f31 with SMTP id d40-20020a0565123d2800b0046d0d458f31mr5356989lfv.146.1650036596600;
        Fri, 15 Apr 2022 08:29:56 -0700 (PDT)
Subject: Re: [RFC PATCH 0/6] virtio: Solution to restrict memory access under
 Xen using xen-virtio DMA ops layer
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 virtualization@lists.linux-foundation.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Henry Wang <Henry.Wang@arm.com>, Kaly Xin <Kaly.Xin@arm.com>,
 Jiamei Xie <Jiamei.Xie@arm.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?=
 <alex.bennee@linaro.org>, Christoph Hellwig <hch@infradead.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <20220415044225-mutt-send-email-mst@kernel.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <d179fc28-c64c-42aa-8402-789639781cbb@gmail.com>
Date: Fri, 15 Apr 2022 18:29:54 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220415044225-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 15.04.22 11:44, Michael S. Tsirkin wrote:


Hello Michael



> On Thu, Apr 14, 2022 at 10:19:27PM +0300, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Hello all.
>>
>> The purpose of this RFC patch series is to add support for restricting memory access under Xen using specific
>> grant table based DMA ops layer. Patch series is based on Juergen Gross’ initial work [1] which implies using
>> grant references instead of raw guest physical addresses (GPA) for the virtio communications (some kind of
>> the software IOMMU).
>>
>> The high level idea is to create new Xen’s grant table based DMA ops layer for the guest Linux whose main
>> purpose is to provide a special 64-bit DMA address which is formed by using the grant reference (for a page
>> to be shared with the backend) with offset and setting the highest address bit (this is for the backend to
>> be able to distinguish grant ref based DMA address from normal GPA). For this to work we need the ability
>> to allocate contiguous (consecutive) grant references for multi-page allocations. And the backend then needs
>> to offer VIRTIO_F_ACCESS_PLATFORM and VIRTIO_F_VERSION_1 feature bits (it must support virtio-mmio modern
>> transport for 64-bit addresses in the virtqueue).
> I'm not enough of a xen expert to review this, and I didn't get
> all patches, but I'm very happy to see that approach being
> taken. VIRTIO_F_ACCESS_PLATFORM and VIRTIO_F_VERSION_1 are
> exactly the way to declare not all of memory is accessible.
> Thanks!

I am happy to hear that! Thank you.


Regarding the "all patches" I have already redirect missing ones, I hope 
you and Christoph will get them.

Sorry for the inconvenience.


>
>> Xen's grant mapping mechanism is the secure and safe solution to share pages between domains which proven
>> to work and works for years (in the context of traditional Xen PV drivers for example). So far, the foreign
>> mapping is used for the virtio backend to map and access guest memory. With the foreign mapping, the backend
>> is able to map arbitrary pages from the guest memory (or even from Dom0 memory). And as the result, the malicious
>> backend which runs in a non-trusted domain can take advantage of this. Instead, with the grant mapping
>> the backend is only allowed to map pages which were explicitly granted by the guest before and nothing else.
>> According to the discussions in various mainline threads this solution would likely be welcome because it
>> perfectly fits in the security model Xen provides.
>>
>> What is more, the grant table based solution requires zero changes to the Xen hypervisor itself at least
>> with virtio-mmio and DT (in comparison, for example, with "foreign mapping + virtio-iommu" solution which would
>> require the whole new complex emulator in hypervisor in addition to new functionality/hypercall to pass IOVA
>> from the virtio backend running elsewhere to the hypervisor and translate it to the GPA before mapping into
>> P2M or denying the foreign mapping request if no corresponding IOVA-GPA mapping present in the IOMMU page table
>> for that particular device). We only need to update toolstack to insert a new "xen,dev-domid" property to
>> the virtio-mmio device node when creating a guest device-tree (this is an indicator for the guest to use grants
>> and the ID of Xen domain where the corresponding backend resides, it is used as an argument to the grant mapping
>> APIs). It worth mentioning that toolstack patch is based on non  upstreamed yet “Virtio support for toolstack
>> on Arm” series which is on review now [2].
>>
>> Please note the following:
>> - Patch series only covers Arm and virtio-mmio (device-tree) for now. To enable the restricted memory access
>>    feature on Arm the following options should be set:
>>    CONFIG_XEN_VIRTIO = y
>>    CONFIG_XEN_HVM_VIRTIO_GRANT = y
>> - Some callbacks in xen-virtio DMA ops layer (map_sg/unmap_sg, etc) are not implemented yet as they are not
>>    needed/used in the first prototype
>>
>> Patch series is rebased on Linux 5.18-rc2 tag and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64)
>> with standalone userspace (non-Qemu) virtio-mmio based virtio-disk backend running in Driver domain and Linux
>> guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy'
>> use-cases work properly. I have also tested other use-cases such as assigning several virtio block devices
>> or a mix of virtio and Xen PV block devices to the guest.
>>
>> 1. Xen changes located at (last patch):
>> https://github.com/otyshchenko1/xen/commits/libxl_virtio_next
>> 2. Linux changes located at:
>> https://github.com/otyshchenko1/linux/commits/virtio_grant5
>> 3. virtio-disk changes located at:
>> https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant
>>
>> Any feedback/help would be highly appreciated.
>>
>> [1] https://www.youtube.com/watch?v=IrlEdaIUDPk
>> [2] https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/
>>
>> Juergen Gross (2):
>>    xen/grants: support allocating consecutive grants
>>    virtio: add option to restrict memory access under Xen
>>
>> Oleksandr Tyshchenko (4):
>>    dt-bindings: xen: Add xen,dev-domid property description for
>>      xen-virtio layer
>>    virtio: Various updates to xen-virtio DMA ops layer
>>    arm/xen: Introduce xen_setup_dma_ops()
>>    arm/xen: Assign xen-virtio DMA ops for virtio devices in Xen guests
>>
>>   .../devicetree/bindings/virtio/xen,dev-domid.yaml  |  39 +++
>>   arch/arm/include/asm/xen/xen-ops.h                 |   1 +
>>   arch/arm/mm/dma-mapping.c                          |   5 +-
>>   arch/arm/xen/enlighten.c                           |  11 +
>>   arch/arm64/include/asm/xen/xen-ops.h               |   1 +
>>   arch/arm64/mm/dma-mapping.c                        |   5 +-
>>   arch/x86/mm/init.c                                 |  15 +
>>   arch/x86/mm/mem_encrypt.c                          |   5 -
>>   arch/x86/xen/Kconfig                               |   9 +
>>   drivers/xen/Kconfig                                |  20 ++
>>   drivers/xen/Makefile                               |   1 +
>>   drivers/xen/grant-table.c                          | 238 +++++++++++++--
>>   drivers/xen/xen-virtio.c                           | 335 +++++++++++++++++++++
>>   include/xen/arm/xen-ops.h                          |  20 ++
>>   include/xen/grant_table.h                          |   4 +
>>   include/xen/xen-ops.h                              |  13 +
>>   16 files changed, 679 insertions(+), 43 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
>>   create mode 100644 arch/arm/include/asm/xen/xen-ops.h
>>   create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
>>   create mode 100644 drivers/xen/xen-virtio.c
>>   create mode 100644 include/xen/arm/xen-ops.h
>>
>> -- 
>> 2.7.4

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 15 15:56:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 15:56:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305807.520893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfOIz-0001N0-3t; Fri, 15 Apr 2022 15:56:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305807.520893; Fri, 15 Apr 2022 15:56:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfOIz-0001Mt-0f; Fri, 15 Apr 2022 15:56:17 +0000
Received: by outflank-mailman (input) for mailman id 305807;
 Fri, 15 Apr 2022 15:56:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfOIx-0001Mj-Nv; Fri, 15 Apr 2022 15:56:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfOIx-0005xL-KA; Fri, 15 Apr 2022 15:56:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfOIx-00059j-4w; Fri, 15 Apr 2022 15:56:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfOIx-0005dD-4U; Fri, 15 Apr 2022 15:56:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TxL8bEahygJjLO1TtLuZIraeJUImqqODMhKyVsHAsbg=; b=NKsiK00KG1U0O2dc/t5+K2C184
	icsAHiznwW8Xi2rDWlQKn+rMLtn8a3nZHClAudBY0QsnoXJZ8SQtmDi4SPlEF8kSFxN6n153rRulK
	RhCxY5P4ZyMpx3J+3nL1rJ3YO3+tYbJVRFif4ky6TRsBQ+mtErYUy8Qj6oERBzwAJwuw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169423-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169423: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=81c7ed41a1b33031f3e4fe24191a998a492044b8
X-Osstest-Versions-That:
    qemuu=4bf58c7213b0ab03209a53731c71f0861c35ef91
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 15:56:15 +0000

flight 169423 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169423/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169261

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169261
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169261
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169261
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169261
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169261
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169261
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169261
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169261
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                81c7ed41a1b33031f3e4fe24191a998a492044b8
baseline version:
 qemuu                4bf58c7213b0ab03209a53731c71f0861c35ef91

Last test of basis   169261  2022-04-09 14:44:31 Z    6 days
Testing same since   169423  2022-04-15 10:07:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Peter Maydell <peter.maydell@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   4bf58c7213..81c7ed41a1  81c7ed41a1b33031f3e4fe24191a998a492044b8 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 16:19:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 16:19:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305817.520904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfOey-0004Pl-46; Fri, 15 Apr 2022 16:19:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305817.520904; Fri, 15 Apr 2022 16:19:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfOey-0004Pe-0R; Fri, 15 Apr 2022 16:19:00 +0000
Received: by outflank-mailman (input) for mailman id 305817;
 Fri, 15 Apr 2022 16:18:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfOex-0004PU-9M; Fri, 15 Apr 2022 16:18:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfOex-0006vc-7m; Fri, 15 Apr 2022 16:18:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfOew-00064A-Uv; Fri, 15 Apr 2022 16:18:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfOew-0006LM-UU; Fri, 15 Apr 2022 16:18:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CLR0NtjN+SlOhC5g71iMDWk65mz7O4FxPzCNBZ8dutQ=; b=DIxLHe+Wao6O3zHUhNMTzyp9dM
	pJJnoDyzX9fZVUou2Zq78BS56yx02N3SqGWZJ8DH5Yns3ObwX04MQS9YzItMfpccODJX4h0YK6AY3
	8ouS8lOIQAcQfIA5PGKX1VaK5vPEatj8oS7bamSIMQceCL+eQOaOQwUCE6qrVpitGiP8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169429-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169429: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 16:18:58 +0000

flight 169429 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169429/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  415 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 17:34:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 17:34:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305828.520915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfPpT-00040c-Ox; Fri, 15 Apr 2022 17:33:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305828.520915; Fri, 15 Apr 2022 17:33:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfPpT-00040V-Ly; Fri, 15 Apr 2022 17:33:55 +0000
Received: by outflank-mailman (input) for mailman id 305828;
 Fri, 15 Apr 2022 17:33:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfPpS-00040L-A4; Fri, 15 Apr 2022 17:33:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfPpS-0008Ao-8I; Fri, 15 Apr 2022 17:33:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfPpR-0000Ag-QQ; Fri, 15 Apr 2022 17:33:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfPpR-0000In-Px; Fri, 15 Apr 2022 17:33:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NzsJ9IX0HBNf5APZkcOd6sdKFbquoBbI5OscZqy0Bfs=; b=pM44czVsfsSrZ/H/0bubppe0qL
	RjqxcEhZKn7AMKtihuy/F/pVPfJ+tB5VvubIHsinhkLkRytru2PvsfFWce8eCfYI1T05UWSx8KXaM
	YzYyqS5b+UieXBUDgsKCOZiAgNjCAe2M63FDSleeBXxs9R263oCOaM0yNKBXEz6HyJpw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169430-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169430: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 17:33:53 +0000

flight 169430 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169430/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  416 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 17:41:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 17:41:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305837.520925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfPwI-0005Rd-Gn; Fri, 15 Apr 2022 17:40:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305837.520925; Fri, 15 Apr 2022 17:40:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfPwI-0005RW-E5; Fri, 15 Apr 2022 17:40:58 +0000
Received: by outflank-mailman (input) for mailman id 305837;
 Fri, 15 Apr 2022 17:40:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfPwG-0005RQ-LZ
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 17:40:56 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 337ce481-bce3-11ec-a405-831a346695d4;
 Fri, 15 Apr 2022 19:40:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 5A399B82E86;
 Fri, 15 Apr 2022 17:40:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEA12C385A5;
 Fri, 15 Apr 2022 17:40:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 337ce481-bce3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650044453;
	bh=tWqCZ6POdjdIuth1uLtLWXsCD/lbgEQY/bea6jlGg18=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=tenMTJ+m0TnYenmiypOhgcvCrusUkdJTXnjplnZ5BJ0HMvFnrY3sU9G+1vpmUpQsy
	 zpIFa0oZcadKrRhAGFmd8rTzmZCvXkwdpx4XLrH6MxBKMt9Kp7fW31dhXaRIIxw5uR
	 BWYOaEdqBnYhkWjangxJ8mrx5hRN/LtrMiysYEjtx/NuAvX9wItzGnFTH5WESku9oP
	 LI8pgJbiIKsBpkEdcFiZNZyV03uPBhFP+3hDi4xgNsIbqIXN76q2rzkvBuTJpj6K7f
	 TG9pq9CtInIMvtiOgIt62T4IFo/32qlhNDxWR0TnLKV1UCQPp65fnbb8YPgqhSHEnx
	 W8i222N5F92Hg==
Date: Fri, 15 Apr 2022 10:40:52 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Christoph Hellwig <hch@lst.de>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Rahul Singh <Rahul.Singh@arm.com>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>, 
    "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
In-Reply-To: <20220415063705.GA24262@lst.de>
Message-ID: <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com> <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop> <8C511888-6183-421E-A4C7-B271DAF46696@arm.com> <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 15 Apr 2022, Christoph Hellwig wrote:
> On Thu, Apr 14, 2022 at 01:39:23PM -0700, Stefano Stabellini wrote:
> > OK, now we know that the code path with Xen is correct and it is the
> > same code path taken (dma_alloc_direct) as when !CONFIG_XEN and !SMMU.
> > That is how it should be.
> > 
> > I cannot explain why dma_alloc_direct() would fail when called from
> > xen_swiotlb_alloc_coherent(), but it would succeed when called from
> > dma_alloc_attrs() without Xen.
> > 
> > I am not aware of any restrictions that xen or swiotlb-xen would
> > introduce in that regard. Unless you are just running out of memory
> > because dom0_mem too low.
> 
> The crash is deep down in the page allocator.  Even if memory was low
> it should no crash.  So there is some odd interaction between Xen
> and the page allocator going on.  I think nvme and dma-direct really
> are only the messenger here.


I cannot think of anything but if that is the case I guess it is more
likely related to reserved-memory not properly advertised or ACPI tables
not properly populated.


Rahul,

What happens if you boot Linux on Xen with swiotlb-xen disabled?


diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
index 93e87b287556..26d9da58f2c6 100644
--- a/arch/arm64/mm/dma-mapping.c
+++ b/arch/arm64/mm/dma-mapping.c
@@ -51,9 +51,4 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
 	dev->dma_coherent = coherent;
 	if (iommu)
 		iommu_setup_dma_ops(dev, dma_base, size);
-
-#ifdef CONFIG_XEN
-	if (xen_initial_domain())
-		dev->dma_ops = &xen_swiotlb_dma_ops;
-#endif
 }
 

I thought Bertrand said that "it works" but I can't imagine how
swiotlb-xen could be the cause of the Linux stacktrace now.


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 18:15:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 18:15:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305843.520936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfQTH-0000Vt-6u; Fri, 15 Apr 2022 18:15:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305843.520936; Fri, 15 Apr 2022 18:15:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfQTH-0000Vm-3w; Fri, 15 Apr 2022 18:15:03 +0000
Received: by outflank-mailman (input) for mailman id 305843;
 Fri, 15 Apr 2022 18:15:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xLN4=UZ=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1nfQTE-0000Vg-PX
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 18:15:00 +0000
Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com
 [209.85.219.173]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f4f3ad3a-bce7-11ec-8fbe-03012f2f19d4;
 Fri, 15 Apr 2022 20:14:58 +0200 (CEST)
Received: by mail-yb1-f173.google.com with SMTP id x200so15595334ybe.13
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 11:14:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4f3ad3a-bce7-11ec-8fbe-03012f2f19d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=77m6r0YC0hwpFEj/omSUxYxpraZkiDpa5+1u4U17wuw=;
        b=s8TIlwQZ/TtGDINsYIKxOQawWQbzEjpm6R4YBOs3h1NlRI/Jc6V/6xFfTFadeu69QR
         VdHNqFWczFq1FMl9sOdnUoM+39RbHuxZKnbBGc1JOErNMjXYV68/gSI3tk7M384S10P4
         TuAybXm5/9c75l/OaqIS1agmyXUbqI8pXYCWEVKMywDGPEysJcSlfJQOyLeLjM7c6Clh
         LQD0osyaC69iGKCc5TrUTikpz7wo1TLgkEXXb7tQY9GcabW4Rf5ZXes/yrYgHgmaNiqs
         GctTl3zS2IiQWRrL5KAPPStAR7Kucj+xiiy8ZrsZ42mxyKiMB3qxP5IT8z1+eNqa0Jgj
         oIwg==
X-Gm-Message-State: AOAM533N8qckNI2mMhhZ+8mcopro6rW8iXMOTSaxqXdk/h0l65qyJXSQ
	GrB1sDCUsRrHcfughU5bgX6pO5UHoe8koP8veY0=
X-Google-Smtp-Source: ABdhPJxt5sJRQzRdxjsC4x8wXGkJItgc7hQN04UOiLAgqkfQ3EsFlprZZZVDC7UwT+872A2Ba0pWN4l51uLxhp+UCpY=
X-Received: by 2002:a05:6902:187:b0:63d:9c95:edca with SMTP id
 t7-20020a056902018700b0063d9c95edcamr412193ybh.81.1650046496677; Fri, 15 Apr
 2022 11:14:56 -0700 (PDT)
MIME-Version: 1.0
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com> <20220411233832.391817-5-dmitry.osipenko@collabora.com>
In-Reply-To: <20220411233832.391817-5-dmitry.osipenko@collabora.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 15 Apr 2022 20:14:45 +0200
Message-ID: <CAJZ5v0gnTSoeNP+QXwrZ45FQY4howVkJMuCjM=j+_-2BngJdQg@mail.gmail.com>
Subject: Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler
 call chain API
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, 
	Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	=?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>, linux-parisc@vger.kernel.org, 
	linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>, 
	xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

Honestly, I would prefer this to be split so as to make it easier to
review if nothing else.

On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
>
> SoC platforms often have multiple ways of how to perform system's
> power-off and restart operations. Meanwhile today's kernel is limited to
> a single option. Add combined power-off+restart handler call chain API,
> which is inspired by the restart API. The new API provides both power-off
> and restart functionality.
>
> The old pm_power_off method will be kept around till all users are
> converted to the new API.
>
> Current restart API will be replaced by the new unified API since
> new API is its superset. The restart functionality of the sys-off handler
> API is built upon the existing restart-notifier APIs.

Which means that the existing notifier chains for system restart are
used as they are without modifications.

At least that's what follows from the code and it would be good to
mention it here.

Moreover, a new notifier chain is introduced for the power-off case
and it appears to be the counterpart of the restart_handler_list
chain, but then why is it blocking and not atomic like the latter?

> In order to ease conversion to the new API, convenient helpers are added
> for the common use-cases. They will reduce amount of boilerplate code and
> remove global variables. These helpers preserve old behaviour for cases
> where only one power-off handler is expected, this is what all existing
> drivers want, and thus, they could be easily converted to the new API.
> Users of the new API should explicitly enable power-off chaining by
> setting corresponding flag of the power_handler structure.

"the corresponding"

>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>  include/linux/reboot.h   | 229 ++++++++++++++-
>  kernel/power/hibernate.c |   2 +-
>  kernel/reboot.c          | 604 ++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 827 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/reboot.h b/include/linux/reboot.h
> index a2429648d831..ba5e5dddcfcd 100644
> --- a/include/linux/reboot.h
> +++ b/include/linux/reboot.h
> @@ -8,10 +8,35 @@
>
>  struct device;
>
> -#define SYS_DOWN       0x0001  /* Notify of system down */
> -#define SYS_RESTART    SYS_DOWN
> -#define SYS_HALT       0x0002  /* Notify of system halt */
> -#define SYS_POWER_OFF  0x0003  /* Notify of system power off */
> +enum reboot_prepare_mode {
> +       SYS_DOWN = 1,           /* Notify of system down */
> +       SYS_RESTART = SYS_DOWN,
> +       SYS_HALT,               /* Notify of system halt */
> +       SYS_POWER_OFF,          /* Notify of system power off */
> +};
> +
> +/*
> + * Standard restart priority levels. Intended to be set in the
> + * sys_off_handler.restart_priority field.
> + *
> + * Use `RESTART_PRIO_ABC +- prio` style for additional levels.
> + *
> + * RESTART_PRIO_RESERVED:      Falls back to RESTART_PRIO_DEFAULT.
> + *                             Drivers may leave priority initialized
> + *                             to zero, to auto-set it to the default level.

What is the "default level" here?

> + *
> + * RESTART_PRIO_LOW:           Use this for handler of last resort.
> + *
> + * RESTART_PRIO_DEFAULT:       Use this for default/generic handler.
> + *
> + * RESTART_PRIO_HIGH:          Use this if you have multiple handlers and
> + *                             this handler has higher priority than the
> + *                             default handler.
> + */
> +#define RESTART_PRIO_RESERVED          0
> +#define RESTART_PRIO_LOW               8
> +#define RESTART_PRIO_DEFAULT           128
> +#define RESTART_PRIO_HIGH              192
>
>  enum reboot_mode {
>         REBOOT_UNDEFINED = -1,
> @@ -49,6 +74,201 @@ extern int register_restart_handler(struct notifier_block *);
>  extern int unregister_restart_handler(struct notifier_block *);
>  extern void do_kernel_restart(char *cmd);
>
> +/*
> + * System power-off and restart API.
> + */
> +
> +/*
> + * Standard power-off priority levels. Intended to be set in the
> + * sys_off_handler.power_off_priority field.
> + *
> + * Use `POWEROFF_PRIO_ABC +- prio` style for additional levels.

What exactly does this mean?

> + *
> + * POWEROFF_PRIO_RESERVED:     Falls back to POWEROFF_PRIO_DEFAULT.
> + *                             Drivers may leave priority initialized
> + *                             to zero, to auto-set it to the default level.
> + *
> + * POWEROFF_PRIO_PLATFORM:     Intended to be used by platform-level handler.
> + *                             Has lowest priority since device drivers are
> + *                             expected to take over platform handler which
> + *                             doesn't allow further callback chaining.
> + *
> + * POWEROFF_PRIO_DEFAULT:      Use this for default/generic handler.
> + *
> + * POWEROFF_PRIO_FIRMWARE:     Use this if handler uses firmware call.
> + *                             Has highest priority since firmware is expected
> + *                             to know best how to power-off hardware properly.
> + */
> +#define POWEROFF_PRIO_RESERVED         0
> +#define POWEROFF_PRIO_PLATFORM         1
> +#define POWEROFF_PRIO_DEFAULT          128
> +#define POWEROFF_PRIO_HIGH             192
> +#define POWEROFF_PRIO_FIRMWARE         224
> +
> +enum poweroff_mode {
> +       POWEROFF_NORMAL = 0,

Why not just POWEROFF?

> +       POWEROFF_PREPARE,
> +};
> +
> +/**
> + * struct power_off_data - Power-off callback argument
> + *
> + * @cb_data: Callback data.
> + */
> +struct power_off_data {
> +       void *cb_data;
> +};
> +
> +/**
> + * struct power_off_prep_data - Power-off preparation callback argument
> + *
> + * @cb_data: Callback data.
> + */
> +struct power_off_prep_data {
> +       void *cb_data;
> +};

Why does this need to be a separate data type?

> +
> +/**
> + * struct restart_data - Restart callback argument
> + *
> + * @cb_data: Callback data.
> + * @cmd: Restart command string.
> + * @stop_chain: Further lower priority callbacks won't be executed if set to
> + *             true. Can be changed within callback. Default is false.
> + * @mode: Reboot mode ID.
> + */
> +struct restart_data {
> +       void *cb_data;
> +       const char *cmd;
> +       bool stop_chain;
> +       enum reboot_mode mode;
> +};
> +
> +/**
> + * struct reboot_prep_data - Reboot and shutdown preparation callback argument
> + *
> + * @cb_data: Callback data.
> + * @cmd: Restart command string.
> + * @stop_chain: Further lower priority callbacks won't be executed if set to
> + *             true. Can be changed within callback. Default is false.
> + * @mode: Preparation mode ID.
> + */
> +struct reboot_prep_data {
> +       void *cb_data;
> +       const char *cmd;
> +       bool stop_chain;
> +       enum reboot_prepare_mode mode;
> +};

There seem to be some duplicate data items between struct restart_data
and struct reboot_prep_data, so what's the reason why they are
separate?

> +
> +struct sys_off_handler_private_data {
> +       struct notifier_block power_off_nb;
> +       struct notifier_block restart_nb;
> +       struct notifier_block reboot_nb;

So restart_nb is going to be added to restart_handler_list, eboot_nb
will be added to reboot_notifier_list (which both exist already) and
power_off_nb will be added to the new power_off_handler_list, right?

Of course, this means that reboot_nb will be used in
kernel_restart_prepare() and kernel_shutdown_prepare(), so the
corresponding callback will be invoked in both the restart and
power-off cases.

It would be good to document that somehow.

> +       void (*platform_power_off_cb)(void);
> +       void (*simple_power_off_cb)(void *data);
> +       void *simple_power_off_cb_data;

Is there any particular reason to put these callbacks here and not
directly into struct sys_off_handler?

> +       bool registered;
> +};
> +
> +/**
> + * struct sys_off_handler - System power-off and restart handler
> + *
> + * @cb_data: Pointer to user's data.
> + *
> + * @power_off_cb: Callback that powers off this machine. Inactive if NULL.
> + *
> + * @power_off_prepare_cb: Power-off preparation callback. All power-off
> + * preparation callbacks are invoked after @reboot_prepare_cb and before
> + * @power_off_cb. Inactive if NULL.
> + *
> + * @power_off_priority: Power-off callback priority, must be unique.
> + * Zero value is reserved and auto-reassigned to POWEROFF_PRIO_DEFAULT.
> + * Inactive if @power_off_cb is NULL.
> + *
> + * @power_off_chaining_allowed: Set to false if callback's execution should
> + * stop when @power_off_cb fails to power off this machine. True if further
> + * lower priority power-off callback should be executed. False is default
> + * value.
> + *
> + * @restart_cb: Callback that reboots this machine. Inactive if NULL.
> + *
> + * @restart_priority: Restart callback priority, must be unique. Zero value
> + * is reserved and auto-reassigned to RESTART_PRIO_DEFAULT. Inactive if
> + * @restart_cb is NULL.
> + *
> + * @restart_chaining_disallowed: Set to true if callback's execution should
> + * stop when @restart_cb fails to restart this machine. False if further
> + * lower priority restart callback should be executed. False is default
> + * value.
> + *
> + * @reboot_prepare_cb: Reboot/shutdown preparation callback. All reboot
> + * preparation callbacks are invoked before @restart_cb or @power_off_cb,
> + * depending on the mode. It's registered with register_reboot_notifier().
> + * The point is to remove boilerplate code from drivers which use this
> + * callback in conjunction with the restart/power-off callbacks.
> + *
> + * @reboot_priority: Reboot/shutdown preparation callback priority, doesn't
> + * need to be unique. Zero is default value. Inactive if @reboot_prepare_cb
> + * is NULL.

It is unclear that the ->reboot_prepare_cb() callback is going to be
used for both restart and power-off and reboot_priority is about the
preparation phase only.

And in the preparation phase the priority may not matter that much,
because there are users who don't care about the ordering as long as
their stuff is called at all.

Honestly, I would change the naming here, because what it is is quite
confusing at least to me.  Especially that "restart" and "reboot" seem
to be used interchangeably in the comments.

> + *
> + * @priv: Internal data. Shouldn't be touched.
> + *
> + * Describes power-off and restart handlers which are invoked by kernel
> + * to power off or restart this machine. Supports prioritized chaining for
> + * both restart and power-off handlers.
> + *
> + * Struct sys_off_handler can be static. Members of this structure must not be
> + * altered while handler is registered.
> + *
> + * Fill the structure members and pass it to @register_sys_off_handler().
> + */
> +struct sys_off_handler {
> +       void *cb_data;
> +
> +       void (*power_off_cb)(struct power_off_data *data);
> +       void (*power_off_prepare_cb)(struct power_off_prep_data *data);
> +       int power_off_priority;
> +       bool power_off_chaining_allowed;
> +
> +       void (*restart_cb)(struct restart_data *data);
> +       int restart_priority;
> +       bool restart_chaining_disallowed;
> +
> +       void (*reboot_prepare_cb)(struct reboot_prep_data *data);
> +       int reboot_priority;
> +
> +       const struct sys_off_handler_private_data priv;

Why is it const?  Because of the callbacks in there?

Doesn't this mean that all struct sys_off_handler need to be static?

> +};
> +
> +int register_sys_off_handler(struct sys_off_handler *handler);
> +int unregister_sys_off_handler(struct sys_off_handler *handler);
> +
> +int devm_register_sys_off_handler(struct device *dev,
> +                                 struct sys_off_handler *handler);
> +
> +int devm_register_prioritized_power_off_handler(struct device *dev,
> +                                               int priority,
> +                                               void (*callback)(void *data),
> +                                               void *cb_data);
> +
> +int devm_register_simple_power_off_handler(struct device *dev,
> +                                          void (*callback)(void *data),
> +                                          void *cb_data);
> +
> +int register_platform_power_off(void (*power_off)(void));
> +int unregister_platform_power_off(void (*power_off)(void));
> +
> +int devm_register_prioritized_restart_handler(struct device *dev,
> +                                             int priority,
> +                                             void (*callback)(struct restart_data *data),
> +                                             void *cb_data);
> +
> +int devm_register_simple_restart_handler(struct device *dev,
> +                                        void (*callback)(struct restart_data *data),
> +                                        void *cb_data);
> +
> +void do_kernel_power_off(void);
> +
>  /*
>   * Architecture-specific implementations of sys_reboot commands.
>   */
> @@ -70,6 +290,7 @@ extern void kernel_restart_prepare(char *cmd);
>  extern void kernel_restart(char *cmd);
>  extern void kernel_halt(void);
>  extern void kernel_power_off(void);
> +extern bool kernel_can_power_off(void);
>
>  void ctrl_alt_del(void);
>
> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> index 938d5c78b421..a9464b4a3209 100644
> --- a/kernel/power/hibernate.c
> +++ b/kernel/power/hibernate.c
> @@ -665,7 +665,7 @@ static void power_down(void)
>                 hibernation_platform_enter();
>                 fallthrough;
>         case HIBERNATION_SHUTDOWN:
> -               if (pm_power_off)
> +               if (kernel_can_power_off())
>                         kernel_power_off();
>                 break;
>         }
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index acdae4e95061..e76e2570dcf5 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -296,6 +296,595 @@ void kernel_halt(void)
>  }
>  EXPORT_SYMBOL_GPL(kernel_halt);
>
> +/*
> + *     Notifier list for kernel code which wants to be called
> + *     to power off the system.
> + */
> +static BLOCKING_NOTIFIER_HEAD(power_off_handler_list);
> +
> +/*
> + * Temporary stub that prevents linkage failure while we're in process
> + * of removing all uses of legacy pm_power_off() around the kernel.

Nit: inconsistent comment formatting.

> + */
> +void __weak (*pm_power_off)(void);
> +
> +static void dummy_pm_power_off(void)
> +{
> +       /* temporary stub until pm_power_off() is gone, see more below */
> +}
> +
> +static struct notifier_block *pm_power_off_nb;
> +
> +/**
> + *     register_power_off_handler - Register function to be called to power off
> + *                                  the system
> + *     @nb: Info about handler function to be called
> + *     @nb->priority:  Handler priority. Handlers should follow the
> + *                     following guidelines for setting priorities.
> + *                     0:      Reserved
> + *                     1:      Power-off handler of last resort,
> + *                             with limited power-off capabilities
> + *                     128:    Default power-off handler; use if no other
> + *                             power-off handler is expected to be available,
> + *                             and/or if power-off functionality is
> + *                             sufficient to power-off the entire system
> + *                     255:    Highest priority power-off handler, will
> + *                             preempt all other power-off handlers
> + *
> + *     Registers a function with code to be called to power off the
> + *     system.

Because this is only used internally in this file, I'd say what it
does directly, that is "Add a notifier to the power-off chain used for
powering off the system".

> + *
> + *     Registered functions will be called as last step of the power-off
> + *     sequence.
> + *
> + *     Registered functions are expected to power off the system immediately.
> + *     If more than one function is registered, the power-off handler priority
> + *     selects which function will be called first.
> + *
> + *     Power-off handlers are expected to be registered from non-architecture
> + *     code, typically from drivers. A typical use case would be a system
> + *     where power-off functionality is provided through a PMIC. Multiple
> + *     power-off handlers may exist; for example, one power-off handler might
> + *     turn off the entire system, while another only turns off part of
> + *     system. In such cases, the power-off handler which only disables part
> + *     of the hardware is expected to register with low priority to ensure
> + *     that it only runs if no other means to power off the system is
> + *     available.

I would move the above 3 paragraphs to the description comment for
power_off_handler_list.

> + *
> + *     Currently always returns zero, as blocking_notifier_chain_register()
> + *     always returns zero.
> + */
> +static int register_power_off_handler(struct notifier_block *nb)
> +{
> +       int ret;
> +
> +       ret = blocking_notifier_chain_register_unique_prio(&power_off_handler_list, nb);
> +       if (ret && ret != -EBUSY)
> +               return ret;
> +
> +       if (!ret)
> +               goto set_pm_power_off;
> +
> +       /*
> +        * Handler must have unique priority. Otherwise call order is
> +        * determined by registration order, which is unreliable.
> +        *
> +        * This requirement will become mandatory once all drivers
> +        * will be converted to use new sys-off API.
> +        */
> +       pr_err("failed to register power-off handler using unique priority\n");
> +
> +       ret = blocking_notifier_chain_register(&power_off_handler_list, nb);
> +       if (ret)
> +               return ret;
> +
> +       /*
> +        * Some drivers check whether pm_power_off was already installed.
> +        * Install dummy callback using new API to preserve old behaviour
> +        * for those drivers during period of transition to the new API.
> +        */
> +set_pm_power_off:
> +       if (!pm_power_off) {
> +               pm_power_off = dummy_pm_power_off;
> +               pm_power_off_nb = nb;
> +       }
> +
> +       return 0;
> +}
> +
> +static int unregister_power_off_handler(struct notifier_block *nb)
> +{
> +       if (nb == pm_power_off_nb) {
> +               if (pm_power_off == dummy_pm_power_off)
> +                       pm_power_off = NULL;
> +
> +               pm_power_off_nb = NULL;
> +       }
> +
> +       return blocking_notifier_chain_unregister(&power_off_handler_list, nb);
> +}
> +
> +static void devm_unregister_power_off_handler(void *data)
> +{
> +       struct notifier_block *nb = data;
> +
> +       unregister_power_off_handler(nb);
> +}
> +
> +static int devm_register_power_off_handler(struct device *dev,
> +                                          struct notifier_block *nb)
> +{
> +       int err;
> +
> +       err = register_power_off_handler(nb);
> +       if (err)
> +               return err;
> +
> +       return devm_add_action_or_reset(dev, devm_unregister_power_off_handler,
> +                                       nb);
> +}
> +
> +static int sys_off_handler_power_off(struct notifier_block *nb,
> +                                    unsigned long mode, void *unused)
> +{
> +       struct power_off_prep_data prep_data = {};
> +       struct sys_off_handler_private_data *priv;
> +       struct power_off_data data = {};
> +       struct sys_off_handler *h;
> +       int ret = NOTIFY_DONE;
> +
> +       priv = container_of(nb, struct sys_off_handler_private_data, power_off_nb);
> +       h = container_of(priv, struct sys_off_handler, priv);
> +       prep_data.cb_data = h->cb_data;
> +       data.cb_data = h->cb_data;
> +
> +       switch (mode) {
> +       case POWEROFF_NORMAL:
> +               if (h->power_off_cb)
> +                       h->power_off_cb(&data);
> +
> +               if (priv->simple_power_off_cb)
> +                       priv->simple_power_off_cb(priv->simple_power_off_cb_data);
> +
> +               if (priv->platform_power_off_cb)
> +                       priv->platform_power_off_cb();

The invocation of the priv callbacks here confuses me quite a bit.

Can you please at least add a comment explaining this?

> +
> +               if (!h->power_off_chaining_allowed)
> +                       ret = NOTIFY_STOP;
> +
> +               break;
> +
> +       case POWEROFF_PREPARE:
> +               if (h->power_off_prepare_cb)
> +                       h->power_off_prepare_cb(&prep_data);
> +
> +               break;
> +
> +       default:
> +               unreachable();
> +       }
> +
> +       return ret;
> +}
> +
> +static int sys_off_handler_restart(struct notifier_block *nb,
> +                                  unsigned long mode, void *cmd)
> +{
> +       struct sys_off_handler_private_data *priv;
> +       struct restart_data data = {};
> +       struct sys_off_handler *h;
> +
> +       priv = container_of(nb, struct sys_off_handler_private_data, restart_nb);
> +       h = container_of(priv, struct sys_off_handler, priv);
> +
> +       data.stop_chain = h->restart_chaining_disallowed;
> +       data.cb_data = h->cb_data;
> +       data.mode = mode;
> +       data.cmd = cmd;
> +
> +       h->restart_cb(&data);

Wouldn't it be a bit more straightforward to allow ->restart_cb() to
return a value being either NOTIFY_STOP or NOTIFY_DONE?

> +
> +       return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;

And I would prefer

if (data.stop_chain)
        return NOTIFY_STOP;

return NOTIFY_DONE;

> +}
> +
> +static int sys_off_handler_reboot(struct notifier_block *nb,
> +                                 unsigned long mode, void *cmd)
> +{
> +       struct sys_off_handler_private_data *priv;
> +       struct reboot_prep_data data = {};
> +       struct sys_off_handler *h;
> +
> +       priv = container_of(nb, struct sys_off_handler_private_data, reboot_nb);
> +       h = container_of(priv, struct sys_off_handler, priv);
> +
> +       data.cb_data = h->cb_data;
> +       data.stop_chain = false;
> +       data.mode = mode;
> +       data.cmd = cmd;
> +
> +       h->reboot_prepare_cb(&data);
> +
> +       return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;

And analogously here.

> +}
> +
> +static struct sys_off_handler_private_data *
> +sys_off_handler_private_data(struct sys_off_handler *handler)
> +{
> +       return (struct sys_off_handler_private_data *)&handler->priv;

Is the cast needed to avoid a warning about "const"?

> +}
> +
> +/**
> + *     devm_register_sys_off_handler - Register system power-off/restart handler

register_sys_off_handler

> + *     @dev: Device that registers handler
> + *     @handler: System-off handler
> + *
> + *     Registers handler that will be called as last step of the power-off
> + *     and restart sequences.

Not necessarily as the last step, because there may be other system
power-off/restart handlers called after it.

I would just say "at the end of the power-off and restart sequences".

Moreover, it registers the "reboot_cb" part that is not called "at the
end" even.

Also, because this is the function that will be used by drivers etc to
register handlers, I would give some more information on how the
object registered by it is going to be used to the prospective users.

> + *
> + *     Returns zero on success, or error code on failure.
> + */
> +int register_sys_off_handler(struct sys_off_handler *handler)
> +{
> +       struct sys_off_handler_private_data *priv;
> +       int err, priority;
> +
> +       priv = sys_off_handler_private_data(handler);
> +
> +       /* sanity-check whether handler is registered twice */
> +       if (priv->registered)
> +               return -EBUSY;
> +
> +       if (handler->power_off_cb || handler->power_off_prepare_cb) {
> +               if (handler->power_off_priority == POWEROFF_PRIO_RESERVED)
> +                       priority = POWEROFF_PRIO_DEFAULT;

I'm not sure that this helps.

I mean, why can't the users of this new API pass POWEROFF_PRIO_DEFAULT
directly if they want "default"?

> +               else
> +                       priority = handler->power_off_priority;
> +
> +               priv->power_off_nb.notifier_call = sys_off_handler_power_off;
> +               priv->power_off_nb.priority = priority;
> +
> +               err = register_power_off_handler(&priv->power_off_nb);
> +               if (err)
> +                       goto reset_sys_off_handler;
> +       }
> +
> +       if (handler->restart_cb) {
> +               if (handler->restart_priority == RESTART_PRIO_RESERVED)
> +                       priority = RESTART_PRIO_DEFAULT;
> +               else
> +                       priority = handler->restart_priority;
> +
> +               priv->restart_nb.notifier_call = sys_off_handler_restart;
> +               priv->restart_nb.priority = priority;
> +
> +               err = register_restart_handler(&priv->restart_nb);
> +               if (err)
> +                       goto unreg_power_off_handler;
> +       }
> +
> +       if (handler->reboot_prepare_cb) {
> +               priv->reboot_nb.notifier_call = sys_off_handler_reboot;
> +               priv->reboot_nb.priority = handler->reboot_priority;
> +
> +               err = register_reboot_notifier(&priv->reboot_nb);
> +               if (err)
> +                       goto unreg_restart_handler;
> +       }
> +
> +       priv->registered = true;
> +
> +       return 0;
> +
> +unreg_restart_handler:
> +       if (handler->restart_cb)
> +               unregister_restart_handler(&priv->restart_nb);
> +
> +unreg_power_off_handler:
> +       if (handler->power_off_cb)
> +               unregister_power_off_handler(&priv->power_off_nb);
> +
> +reset_sys_off_handler:
> +       memset(priv, 0, sizeof(*priv));
> +
> +       return err;
> +}
> +EXPORT_SYMBOL(register_sys_off_handler);
> +
> +/**
> + *     unregister_sys_off_handler - Unregister system power-off/restart handler
> + *     @handler: System-off handler
> + *
> + *     Unregisters sys-off handler. Does nothing and returns zero if handler
> + *     is NULL.
> + *
> + *     Returns zero on success, or error code on failure.
> + */
> +int unregister_sys_off_handler(struct sys_off_handler *handler)
> +{
> +       struct sys_off_handler_private_data *priv;
> +
> +       if (!handler)
> +               return 0;
> +
> +       priv = sys_off_handler_private_data(handler);
> +
> +       /* sanity-check whether handler is unregistered twice */
> +       if (!priv->registered)
> +               return -EINVAL;
> +
> +       if (handler->reboot_prepare_cb)
> +               unregister_reboot_notifier(&priv->reboot_nb);
> +
> +       if (handler->restart_cb)
> +               unregister_restart_handler(&priv->restart_nb);
> +
> +       if (handler->power_off_cb)
> +               unregister_power_off_handler(&priv->power_off_nb);
> +
> +       memset(priv, 0, sizeof(*priv));
> +
> +       return 0;
> +}
> +EXPORT_SYMBOL(unregister_sys_off_handler);
> +
> +static void devm_unregister_sys_off_handler(void *data)
> +{
> +       struct sys_off_handler *handler = data;
> +
> +       unregister_sys_off_handler(handler);
> +}
> +
> +/**
> + *     devm_register_sys_off_handler - Register system power-off/restart handler
> + *     @dev: Device that registers handler
> + *     @handler: System-off handler
> + *
> + *     Resource-managed variant of register_sys_off_handler().
> + *
> + *     Returns zero on success, or error code on failure.
> + */
> +int devm_register_sys_off_handler(struct device *dev,
> +                                 struct sys_off_handler *handler)
> +{
> +       int err;
> +
> +       err = register_sys_off_handler(handler);
> +       if (err)
> +               return err;
> +
> +       return devm_add_action_or_reset(dev, devm_unregister_sys_off_handler,
> +                                       handler);
> +}
> +EXPORT_SYMBOL(devm_register_sys_off_handler);
> +
> +/**
> + *     devm_register_prioritized_power_off_handler - Register prioritized power-off callback
> + *     @dev: Device that registers callback
> + *     @priority: Callback's priority
> + *     @callback: Callback function
> + *     @cb_data: Callback's argument
> + *
> + *     Registers resource-managed power-off callback with a given priority.
> + *     It will be called as last step of the power-off sequence. Callbacks
> + *     chaining is disabled, i.e. further lower priority callbacks won't
> + *     be executed if this @callback will fail to execute.
> + *
> + *     Returns zero on success, or error code on failure.

What's the case in which this should be used instead of registering a
full sys_off handler?

> + */
> +int devm_register_prioritized_power_off_handler(struct device *dev,
> +                                               int priority,
> +                                               void (*callback)(void *data),
> +                                               void *cb_data)
> +{
> +       struct sys_off_handler_private_data *priv;
> +       struct sys_off_handler *handler;
> +
> +       handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
> +       if (!handler)
> +               return -ENOMEM;
> +
> +       if (priority == POWEROFF_PRIO_RESERVED)
> +               priority = POWEROFF_PRIO_DEFAULT;
> +
> +       priv = sys_off_handler_private_data(handler);
> +
> +       priv->power_off_nb.notifier_call = sys_off_handler_power_off;
> +       priv->power_off_nb.priority = priority;
> +       priv->simple_power_off_cb_data = cb_data;
> +       priv->simple_power_off_cb = callback;
> +
> +       return devm_register_power_off_handler(dev, &priv->power_off_nb);
> +}
> +EXPORT_SYMBOL(devm_register_prioritized_power_off_handler);
> +
> +int devm_register_prioritized_power_off_handler(struct device *dev,
> +                                               int priority,
> +                                               void (*callback)(void *data),
> +                                               void *cb_data);
> +
> +/**
> + *     devm_register_simple_power_off_handler - Register simple power-off callback
> + *     @dev: Device that registers callback
> + *     @callback: Callback function
> + *     @cb_data: Callback's argument
> + *
> + *     Registers resource-managed power-off callback with default priority.
> + *     It will be invoked as last step of the power-off sequence. Further
> + *     lower priority callbacks won't be executed if this @callback fails.
> + *
> + *     Returns zero on success, or error code on failure.

And here?

> + */
> +int devm_register_simple_power_off_handler(struct device *dev,
> +                                          void (*callback)(void *data),
> +                                          void *cb_data)
> +{
> +       return devm_register_prioritized_power_off_handler(dev,
> +                                                          POWEROFF_PRIO_DEFAULT,
> +                                                          callback, cb_data);
> +}
> +EXPORT_SYMBOL(devm_register_simple_power_off_handler);
> +
> +/**
> + *     devm_register_prioritized_restart_handler - Register prioritized restart callback
> + *     @dev: Device that registers callback
> + *     @priority: Callback's priority
> + *     @callback: Callback function
> + *     @cb_data: Callback's argument
> + *
> + *     Registers resource-managed restart callback with a given priority.
> + *     It will be called as a part of the restart sequence. Callbacks
> + *     chaining is disabled, i.e. further lower priority callbacks won't
> + *     be executed if this @callback will fail to execute.
> + *
> + *     Returns zero on success, or error code on failure.

And here?

> + */
> +int devm_register_prioritized_restart_handler(struct device *dev,
> +                                             int priority,
> +                                             void (*callback)(struct restart_data *data),
> +                                             void *cb_data)
> +{
> +       struct sys_off_handler *handler;
> +
> +       handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
> +       if (!handler)
> +               return -ENOMEM;
> +
> +       if (priority == RESTART_PRIO_RESERVED)
> +               priority = RESTART_PRIO_DEFAULT;
> +
> +       handler->restart_priority = priority;
> +       handler->restart_cb = callback;
> +       handler->cb_data = cb_data;
> +
> +       return devm_register_sys_off_handler(dev, handler);
> +}
> +EXPORT_SYMBOL(devm_register_prioritized_restart_handler);
> +
> +/**
> + *     devm_register_simple_restart_handler - Register simple restart callback
> + *     @dev: Device that registers callback
> + *     @callback: Callback function
> + *     @cb_data: Callback's argument
> + *
> + *     Registers resource-managed restart callback with default priority.
> + *     It will be invoked as a part of the restart sequence. Further
> + *     lower priority callback will be executed if this @callback fails.
> + *
> + *     Returns zero on success, or error code on failure.

And here?

> + */
> +int devm_register_simple_restart_handler(struct device *dev,
> +                                        void (*callback)(struct restart_data *data),
> +                                        void *cb_data)
> +{
> +       return devm_register_prioritized_restart_handler(dev,
> +                                                        RESTART_PRIO_DEFAULT,
> +                                                        callback, cb_data);
> +}
> +EXPORT_SYMBOL(devm_register_simple_restart_handler);
> +
> +static struct sys_off_handler platform_power_off_handler = {
> +       .priv = {
> +               .power_off_nb = {
> +                       .notifier_call = sys_off_handler_power_off,
> +                       .priority = POWEROFF_PRIO_PLATFORM,
> +               },
> +       },
> +};
> +
> +static DEFINE_SPINLOCK(platform_power_off_lock);
> +
> +/**
> + *     register_platform_power_off - Register platform-level power-off callback
> + *     @power_off: Power-off callback
> + *
> + *     Registers power-off callback that will be called as last step
> + *     of the power-off sequence. This callback is expected to be invoked
> + *     for the last resort. Further lower priority callbacks won't be
> + *     executed if @power_off fails. Only one platform power-off callback
> + *     is allowed to be registered at a time.
> + *
> + *     Returns zero on success, or error code on failure.

What's the use case for this?

> + */
> +int register_platform_power_off(void (*power_off)(void))
> +{
> +       struct sys_off_handler_private_data *priv;
> +       int ret = 0;
> +
> +       priv = sys_off_handler_private_data(&platform_power_off_handler);
> +
> +       spin_lock(&platform_power_off_lock);
> +       if (priv->platform_power_off_cb)
> +               ret = -EBUSY;
> +       else
> +               priv->platform_power_off_cb = power_off;

Wasn't priv supposed to be const?

> +       spin_unlock(&platform_power_off_lock);
> +
> +       if (ret)
> +               return ret;
> +
> +       ret = register_power_off_handler(&priv->power_off_nb);
> +       if (ret)
> +               priv->platform_power_off_cb = NULL;
> +
> +       return ret;
> +}
> +EXPORT_SYMBOL_GPL(register_platform_power_off);
> +
> +/**
> + *     unregister_platform_power_off - Unregister platform-level power-off callback
> + *     @power_off: Power-off callback
> + *
> + *     Unregisters previously registered platform power-off callback.
> + *
> + *     Returns zero on success, or error code on failure.
> + */
> +int unregister_platform_power_off(void (*power_off)(void))
> +{
> +       struct sys_off_handler_private_data *priv;
> +       int ret;
> +
> +       priv = sys_off_handler_private_data(&platform_power_off_handler);
> +
> +       if (priv->platform_power_off_cb != power_off)
> +               return -EINVAL;
> +
> +       ret = unregister_power_off_handler(&priv->power_off_nb);
> +       priv->platform_power_off_cb = NULL;
> +
> +       return ret;
> +}
> +EXPORT_SYMBOL_GPL(unregister_platform_power_off);
> +
> +/**
> + *     do_kernel_power_off - Execute kernel power-off handler call chain
> + *
> + *     Calls functions registered with register_power_off_handler.
> + *
> + *     Expected to be called as last step of the power-off sequence.
> + *
> + *     Powers off the system immediately if a power-off handler function has
> + *     been registered. Otherwise does nothing.
> + */
> +void do_kernel_power_off(void)
> +{
> +       /* legacy pm_power_off() is unchained and has highest priority */
> +       if (pm_power_off && pm_power_off != dummy_pm_power_off)
> +               return pm_power_off();
> +
> +       blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_NORMAL,
> +                                    NULL);
> +}
> +
> +static void do_kernel_power_off_prepare(void)
> +{
> +       /* legacy pm_power_off_prepare() is unchained and has highest priority */
> +       if (pm_power_off_prepare)
> +               return pm_power_off_prepare();
> +
> +       blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE,
> +                                    NULL);
> +}
> +
>  /**
>   *     kernel_power_off - power_off the system
>   *
> @@ -304,8 +893,7 @@ EXPORT_SYMBOL_GPL(kernel_halt);
>  void kernel_power_off(void)
>  {
>         kernel_shutdown_prepare(SYSTEM_POWER_OFF);
> -       if (pm_power_off_prepare)
> -               pm_power_off_prepare();
> +       do_kernel_power_off_prepare();
>         migrate_to_reboot_cpu();
>         syscore_shutdown();
>         pr_emerg("Power down\n");
> @@ -314,6 +902,16 @@ void kernel_power_off(void)
>  }
>  EXPORT_SYMBOL_GPL(kernel_power_off);
>
> +bool kernel_can_power_off(void)
> +{
> +       if (!pm_power_off &&
> +           blocking_notifier_call_chain_is_empty(&power_off_handler_list))
> +               return false;
> +
> +       return true;

return pm_power_off ||
blocking_notifier_call_chain_is_empty(&power_off_handler_list);

> +}
> +EXPORT_SYMBOL_GPL(kernel_can_power_off);
> +
>  DEFINE_MUTEX(system_transition_mutex);
>
>  /*
> @@ -355,7 +953,7 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd,
>         /* Instead of trying to make the power_off code look like
>          * halt when pm_power_off is not set do it the easy way.
>          */
> -       if ((cmd == LINUX_REBOOT_CMD_POWER_OFF) && !pm_power_off)
> +       if (cmd == LINUX_REBOOT_CMD_POWER_OFF && !kernel_can_power_off())
>                 cmd = LINUX_REBOOT_CMD_HALT;
>
>         mutex_lock(&system_transition_mutex);
> --


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 18:29:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 18:29:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305853.520948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfQh8-00028h-ML; Fri, 15 Apr 2022 18:29:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305853.520948; Fri, 15 Apr 2022 18:29:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfQh8-00028a-Hl; Fri, 15 Apr 2022 18:29:22 +0000
Received: by outflank-mailman (input) for mailman id 305853;
 Fri, 15 Apr 2022 18:29:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfQh6-00028Q-Ud; Fri, 15 Apr 2022 18:29:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfQh6-0000nY-Rf; Fri, 15 Apr 2022 18:29:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfQh6-0001ja-H3; Fri, 15 Apr 2022 18:29:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfQh6-00088c-Gc; Fri, 15 Apr 2022 18:29:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uR9biiPaEafand/j0+JNbYEMFnYRFctsGXmUknuTZeo=; b=bh66UUbQ9zLEkgjghVKJW74VUr
	weYCUY6WsedifknaoP4XlPdbfJd51NsNDGr7KxKZYDQr31QWYCnxaOQ+dXwQYzXM04AGQ7vWJib6V
	rL2TNNPq7iQUBlbcxD210U902gIt5MvPGS9p+r0l5hAd0zBAlGE8qocN03oq0hRyXmpQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169431-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169431: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 18:29:20 +0000

flight 169431 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169431/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  417 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 19:06:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 19:06:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305863.520958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfRH7-0006Pv-4s; Fri, 15 Apr 2022 19:06:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305863.520958; Fri, 15 Apr 2022 19:06:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfRH7-0006Po-1u; Fri, 15 Apr 2022 19:06:33 +0000
Received: by outflank-mailman (input) for mailman id 305863;
 Fri, 15 Apr 2022 19:06:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfRH5-0006Pe-TG; Fri, 15 Apr 2022 19:06:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfRH5-0001Pp-Pl; Fri, 15 Apr 2022 19:06:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfRH5-0002bq-Du; Fri, 15 Apr 2022 19:06:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfRH5-00031N-DM; Fri, 15 Apr 2022 19:06:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BSpVqesYIEmw+0QU71Xy2cypY7f+Md3BFfPDMUX65XY=; b=R989sIYs0MYHRz5oiE6VMy/Agk
	Jgxrc59hjrNxt9lxqUJt5C9Q7Yc8uoYmw+BNk1RRTwK92sEGRU6jMWCFvLvznKLypJG/mv5Popgj2
	rhUjJ5plxyt80i3Ba8csMBl9qrhVAtjBvMZx06jzou/QWO5+G17pTnBhAx99guC5BFHw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169432-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169432: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 19:06:31 +0000

flight 169432 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169432/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  418 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 19:58:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 19:58:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305873.520969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfS5D-0003JF-Vl; Fri, 15 Apr 2022 19:58:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305873.520969; Fri, 15 Apr 2022 19:58:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfS5D-0003J8-So; Fri, 15 Apr 2022 19:58:19 +0000
Received: by outflank-mailman (input) for mailman id 305873;
 Fri, 15 Apr 2022 19:58:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfS5C-0003Iy-Pc; Fri, 15 Apr 2022 19:58:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfS5C-0002Ec-Kk; Fri, 15 Apr 2022 19:58:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfS5C-0004j3-30; Fri, 15 Apr 2022 19:58:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfS5C-00057P-2a; Fri, 15 Apr 2022 19:58:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t1AtAxnk8Ca63GFtVuNI6qetGA0PVUopmrfZdYa+CKU=; b=f2CVaF0/h9ecYQJsOlCryTUGMA
	/Wi7feg11a3Hb/Vwq4H4Es3HyMxbePj5kNSt0O4fbWtYOK+x9b3OS26nzB600wtYObxrOUdJKAXGT
	IIbDlSF8Mudz2ekJyXi7TReHDI5mTxrkCvPidtrrUFvfEzK10Ui47ce5IJc9d9iIwqBk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169426-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 169426: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-arm64-arm64-libvirt-raw:xen-boot:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e7f5213d755bc34f366d36f08825c0b446117d96
X-Osstest-Versions-That:
    linux=2845ff3fd34499603249676495c524a35e795b45
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 19:58:18 +0000

flight 169426 linux-5.4 real [real]
flight 169433 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169426/
http://logs.test-lab.xenproject.org/osstest/logs/169433/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw  8 xen-boot            fail pass in 169433-retest
 test-amd64-i386-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 169433-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 169433 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 169433 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168976
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168976
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168976
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168976
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168976
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168976
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168976
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168976
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168976
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168976
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168976
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168976
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                e7f5213d755bc34f366d36f08825c0b446117d96
baseline version:
 linux                2845ff3fd34499603249676495c524a35e795b45

Last test of basis   168976  2022-03-29 08:01:18 Z   17 days
Testing same since   169426  2022-04-15 12:43:23 Z    0 days    1 attempts

------------------------------------------------------------
438 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2845ff3fd344..e7f5213d755b  e7f5213d755bc34f366d36f08825c0b446117d96 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 20:28:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 20:28:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305883.520981 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfSXw-0006nc-FY; Fri, 15 Apr 2022 20:28:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305883.520981; Fri, 15 Apr 2022 20:28:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfSXw-0006nV-Bv; Fri, 15 Apr 2022 20:28:00 +0000
Received: by outflank-mailman (input) for mailman id 305883;
 Fri, 15 Apr 2022 20:27:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfSXv-0006nL-Dw; Fri, 15 Apr 2022 20:27:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfSXv-0002r1-4r; Fri, 15 Apr 2022 20:27:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfSXu-0006Wq-Mo; Fri, 15 Apr 2022 20:27:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfSXu-0001W9-MK; Fri, 15 Apr 2022 20:27:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=W2wgIWHONdTdAxfV6b1J0qH+Exn0hhQ9w4FJ7Rg+i3U=; b=Rtp9WENeqcbX6NGd7/dHDXn22z
	KlUkzq1Vngm+8NFVBgw9fA7th3bZFdbM5pg+W29dUotVKUWiqHWra5V5hSLq+buzQky9WEbF3Aajo
	PpQnCfjlqak5taIzD7yyG+BgxVTwOOQYozqKDZL80NpurakcBb8Vc7QN6m2wGBCVrym0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169435-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169435: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 20:27:58 +0000

flight 169435 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169435/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  419 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 21:26:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 21:26:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305893.520992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfTSL-0004VF-RJ; Fri, 15 Apr 2022 21:26:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305893.520992; Fri, 15 Apr 2022 21:26:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfTSL-0004V8-O5; Fri, 15 Apr 2022 21:26:17 +0000
Received: by outflank-mailman (input) for mailman id 305893;
 Fri, 15 Apr 2022 21:26:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfTSJ-0004Uy-Up; Fri, 15 Apr 2022 21:26:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfTSJ-0003rF-S9; Fri, 15 Apr 2022 21:26:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfTSJ-00005C-ED; Fri, 15 Apr 2022 21:26:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfTSJ-0004ya-Dj; Fri, 15 Apr 2022 21:26:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Qrl3e2w72raVfzM95Ovltthk5PvvrCwd0m7kcQBQyWU=; b=3w7TTvCDOx0S4zUI4YZFIC+tNe
	6eSNAsomv8qmZ9OuF5U395BObR7ZtjCdKC+UMy3XQLKEh294EdOtC+K63qzAYrLTgp+N5NZYhmYqj
	j3o+bRftMoJRb4fpCKRDUlInTHNbzWdfmQcHb9hx7hdxaeejrN9sBeW/eqtNcgPBSXd8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169436-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169436: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 21:26:15 +0000

flight 169436 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169436/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  420 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 22:01:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 22:01:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305904.521014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU0O-0000bR-Vf; Fri, 15 Apr 2022 22:01:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305904.521014; Fri, 15 Apr 2022 22:01:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU0O-0000bK-Sc; Fri, 15 Apr 2022 22:01:28 +0000
Received: by outflank-mailman (input) for mailman id 305904;
 Fri, 15 Apr 2022 22:01:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfU0O-0000HG-51
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 22:01:28 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 990a68e0-bd07-11ec-8fbe-03012f2f19d4;
 Sat, 16 Apr 2022 00:01:27 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 95673B83120;
 Fri, 15 Apr 2022 22:01:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0D90C385A4;
 Fri, 15 Apr 2022 22:01:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 990a68e0-bd07-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650060085;
	bh=3nAlILfONam3A1vF12+Z//hbMZsSoLMl3r4snyjFDkg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=R5ACtTmRa1lWffZNP40CcYwujsVyYLvLu7t4cuSkHx/zaTDgutlQ4iwTl0T+OF46E
	 KTk2+o63Z5vwr6TH66atXLG4sAjRb/3Fu3/lo+Yd3s4T2y408M4g5eshPM00FXsruY
	 gnQywd9MCBBru4u0+hmOTmRr5Sf6fOH6A8aUY3iN3hikuJ5hZX6mYNnkvR8sfqbHJZ
	 6cwdJQMOfy9nf5UrBix4ZArxlSXSr5cEKNoGxqL5AE9/8QMWl5q0TSv2lORkNvm+eu
	 0mpduXkufAAx6byB3UeBLcqIFKHPEHxW+sH7kFA7AyIzaxOVMzTIUGBGsnuhnJ9rtg
	 ul349pv5wZ/2g==
Date: Fri, 15 Apr 2022 15:01:24 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, 
    devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, 
    Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
    Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [RFC PATCH 3/6] dt-bindings: xen: Add xen,dev-domid property
 description for xen-virtio layer
In-Reply-To: <1649963973-22879-4-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204151300130.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-4-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Introduce Xen specific binding for the virtio-mmio device to be used
> by Xen virtio support driver in a subsequent commit.
> 
> This binding specifies the ID of Xen domain where the corresponding
> device (backend) resides. This is needed for the option to restrict
> memory access using Xen grant mappings to work.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>  .../devicetree/bindings/virtio/xen,dev-domid.yaml  | 39 ++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
> 
> diff --git a/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
> new file mode 100644
> index 00000000..78be993
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/virtio/xen,dev-domid.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xen specific binding for the virtio device
> +
> +maintainers:
> +  - Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> +
> +select: true
> +
> +description:
> +  This binding specifies the ID of Xen domain where the corresponding device
> +  (backend) resides. This is needed for the option to restrict memory access
> +  using Xen grant mappings to work.
> +
> +  Note that current and generic "iommus" bindings are mutually exclusive, since
> +  the restricted memory access model on Xen behaves as a kind of software IOMMU.

I don't think that this last statement is necessary or fully accurate, so
I would remove it. Other than that, this looks good to me.


> +properties:
> +  xen,dev-domid:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Should contain the ID of device's domain.

Maybe better as:
"The domid (domain ID) of the domain where the device (backend) is running"



> +additionalProperties: true
> +
> +examples:
> +  - |
> +    virtio_block@3000 {
> +            compatible = "virtio,mmio";
> +            reg = <0x3000 0x100>;
> +            interrupts = <41>;
> +
> +            /* The device is located in Xen domain with ID 1 */
> +            xen,dev-domid = <1>;
> +    };
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 22:01:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 22:01:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305903.521002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU0B-0000HT-KI; Fri, 15 Apr 2022 22:01:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305903.521002; Fri, 15 Apr 2022 22:01:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU0B-0000HM-HQ; Fri, 15 Apr 2022 22:01:15 +0000
Received: by outflank-mailman (input) for mailman id 305903;
 Fri, 15 Apr 2022 22:01:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfU0A-0000HG-9J
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 22:01:14 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8d7846c4-bd07-11ec-8fbe-03012f2f19d4;
 Sat, 16 Apr 2022 00:01:08 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 4B89A62113;
 Fri, 15 Apr 2022 22:01:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 021A7C385A5;
 Fri, 15 Apr 2022 22:01:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d7846c4-bd07-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650060066;
	bh=gF05qkj1BV8YRPMKFq8okTDWS2TOnvBdsgGfuKBcUNc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=qkvRQK+cwAX5qxBIrsmll2HBQ6tdyXXOo48j7ThKlxLDK5IqB60sSNQJiU/oIq5Dl
	 20sHI1dQ7J2buTs1iZVfVzMb8qQv9kFEtF060AAgDXgp21wXhfZhVzSJ8KzHuFWHiF
	 QY5bSK01PvE2nT6D5UX8S3AqWikLAnlWrJAARbHYWADztrluf1XJyAYTGZxzsKQ0Tr
	 wxfatIV+KrZ8u0jd34nEX/EUOQbNU7F96vC/7YPuAzQdX9LjnLphr4cb2zuWXL5TAY
	 Nui0tbFH8+eF/1aF2Bl0kxcmRkFg70TWIreWjyFRo02mboDXrwpyr4MOVbnTqlS4nP
	 WClFyObLzhRLg==
Date: Fri, 15 Apr 2022 15:01:05 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, x86@kernel.org, 
    linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>, 
    Dave Hansen <dave.hansen@linux.intel.com>, 
    Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, 
    Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, 
    Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [RFC PATCH 2/6] virtio: add option to restrict memory access
 under Xen
In-Reply-To: <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204151235440.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Juergen Gross <jgross@suse.com>
> 
> In order to support virtio in Xen guests add a config option enabling
> the user to specify whether in all Xen guests virtio should be able to
> access memory via Xen grant mappings only on the host side.
> 
> This applies to fully virtualized guests only, as for paravirtualized
> guests this is mandatory.
> 
> This requires to switch arch_has_restricted_virtio_memory_access()
> from a pure stub to a real function on x86 systems (Arm systems are
> not covered by now).
> 
> Add the needed functionality by providing a special set of DMA ops
> handling the needed grant operations for the I/O pages.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  arch/x86/mm/init.c        |  15 ++++
>  arch/x86/mm/mem_encrypt.c |   5 --
>  arch/x86/xen/Kconfig      |   9 +++
>  drivers/xen/Kconfig       |  20 ++++++
>  drivers/xen/Makefile      |   1 +
>  drivers/xen/xen-virtio.c  | 177 ++++++++++++++++++++++++++++++++++++++++++++++
>  include/xen/xen-ops.h     |   8 +++
>  7 files changed, 230 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/xen/xen-virtio.c
> 
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index d8cfce2..526a3b2 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -8,6 +8,8 @@
>  #include <linux/kmemleak.h>
>  #include <linux/sched/task.h>
>  
> +#include <xen/xen.h>
> +
>  #include <asm/set_memory.h>
>  #include <asm/e820/api.h>
>  #include <asm/init.h>
> @@ -1065,3 +1067,16 @@ unsigned long max_swapfile_size(void)
>  	return pages;
>  }
>  #endif
> +
> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> +int arch_has_restricted_virtio_memory_access(void)
> +{
> +	if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
> +		return 1;
> +	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
> +		return 1;

I think these two checks could be moved to a separate function in a Xen
header, e.g. xen_restricted_virtio_memory_access, and here you could
just

if (xen_restricted_virtio_memory_access())
    return 1;



> +	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
> +}
> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> +#endif
> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
> index 50d2099..dda020f 100644
> --- a/arch/x86/mm/mem_encrypt.c
> +++ b/arch/x86/mm/mem_encrypt.c
> @@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
>  	print_mem_encrypt_feature_info();
>  }
>  
> -int arch_has_restricted_virtio_memory_access(void)
> -{
> -	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
> -}
> -EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> index 85246dd..dffdffd 100644
> --- a/arch/x86/xen/Kconfig
> +++ b/arch/x86/xen/Kconfig
> @@ -92,3 +92,12 @@ config XEN_DOM0
>  	select X86_X2APIC if XEN_PVH && X86_64
>  	help
>  	  Support running as a Xen Dom0 guest.
> +
> +config XEN_PV_VIRTIO
> +	bool "Xen virtio support for PV guests"
> +	depends on XEN_VIRTIO && XEN_PV
> +	default y
> +	help
> +	  Support virtio for running as a paravirtualized guest. This will
> +	  need support on the backend side (qemu or kernel, depending on the
> +	  virtio device types used).
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index 120d32f..fc61f7a 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -335,4 +335,24 @@ config XEN_UNPOPULATED_ALLOC
>  	  having to balloon out RAM regions in order to obtain physical memory
>  	  space to create such mappings.
>  
> +config XEN_VIRTIO
> +	bool "Xen virtio support"
> +	default n
> +	depends on VIRTIO && DMA_OPS
> +	select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> +	help
> +	  Enable virtio support for running as Xen guest. Depending on the
> +	  guest type this will require special support on the backend side
> +	  (qemu or kernel, depending on the virtio device types used).
> +
> +config XEN_HVM_VIRTIO_GRANT
> +	bool "Require virtio for fully virtualized guests to use grant mappings"
> +	depends on XEN_VIRTIO && X86_64
> +	default y
> +	help
> +	  Require virtio for fully virtualized guests to use grant mappings.
> +	  This will avoid the need to give the backend the right to map all
> +	  of the guest memory. This will need support on the backend side
> +	  (qemu or kernel, depending on the virtio device types used).

I don't think we need 3 visible kconfig options for this.

In fact, I would only add one: XEN_VIRTIO. We can have any X86 (or ARM)
specific dependencies in the "depends" line under XEN_VIRTIO. And I
don't think we need XEN_HVM_VIRTIO_GRANT as a kconfig option
necessarely. It doesn't seem like some we want as build time option. At
most, it could be a runtime option (like a command line) or a debug
option (like an #define at the top of the source file.)


>  endmenu
> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> index 5aae66e..767009c 100644
> --- a/drivers/xen/Makefile
> +++ b/drivers/xen/Makefile
> @@ -39,3 +39,4 @@ xen-gntalloc-y				:= gntalloc.o
>  xen-privcmd-y				:= privcmd.o privcmd-buf.o
>  obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)	+= xen-front-pgdir-shbuf.o
>  obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)	+= unpopulated-alloc.o
> +obj-$(CONFIG_XEN_VIRTIO)		+= xen-virtio.o
> diff --git a/drivers/xen/xen-virtio.c b/drivers/xen/xen-virtio.c
> new file mode 100644
> index 00000000..cfd5eda
> --- /dev/null
> +++ b/drivers/xen/xen-virtio.c
> @@ -0,0 +1,177 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/******************************************************************************
> + * Xen virtio driver - enables using virtio devices in Xen guests.
> + *
> + * Copyright (c) 2021, Juergen Gross <jgross@suse.com>
> + */
> +
> +#include <linux/module.h>
> +#include <linux/dma-map-ops.h>
> +#include <linux/pci.h>
> +#include <linux/pfn.h>
> +#include <linux/virtio_config.h>
> +#include <xen/xen.h>
> +#include <xen/grant_table.h>
> +
> +#define XEN_GRANT_ADDR_OFF	0x8000000000000000ULL

NIT: (1ULL << 31)


> +static inline dma_addr_t grant_to_dma(grant_ref_t grant)
> +{
> +	return XEN_GRANT_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
> +}
> +
> +static inline grant_ref_t dma_to_grant(dma_addr_t dma)
> +{
> +	return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT);
> +}
> +
> +/*
> + * DMA ops for Xen virtio frontends.
> + *
> + * Used to act as a kind of software IOMMU for Xen guests by using grants as
> + * DMA addresses.
> + * Such a DMA address is formed by using the grant reference as a frame
> + * number and setting the highest address bit (this bit is for the backend
> + * to be able to distinguish it from e.g. a mmio address).
> + *
> + * Note that for now we hard wire dom0 to be the backend domain. In order to
> + * support any domain as backend we'd need to add a way to communicate the
> + * domid of this backend, e.g. via Xenstore or via the PCI-device's config
> + * space.

I would add device tree as possible way of domid communication


> + */
> +static void *xen_virtio_dma_alloc(struct device *dev, size_t size,
> +				  dma_addr_t *dma_handle, gfp_t gfp,
> +				  unsigned long attrs)
> +{
> +	unsigned int n_pages = PFN_UP(size);
> +	unsigned int i;
> +	unsigned long pfn;
> +	grant_ref_t grant;
> +	void *ret;
> +
> +	ret = (void *)__get_free_pages(gfp, get_order(size));
> +	if (!ret)
> +		return NULL;
> +
> +	pfn = virt_to_pfn(ret);
> +
> +	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
> +		free_pages((unsigned long)ret, get_order(size));
> +		return NULL;
> +	}
> +
> +	for (i = 0; i < n_pages; i++) {
> +		gnttab_grant_foreign_access_ref(grant + i, 0,
> +						pfn_to_gfn(pfn + i), 0);
> +	}
> +
> +	*dma_handle = grant_to_dma(grant);
> +
> +	return ret;
> +}
> +
> +static void xen_virtio_dma_free(struct device *dev, size_t size, void *vaddr,
> +				dma_addr_t dma_handle, unsigned long attrs)
> +{
> +	unsigned int n_pages = PFN_UP(size);
> +	unsigned int i;
> +	grant_ref_t grant;
> +
> +	grant = dma_to_grant(dma_handle);
> +
> +	for (i = 0; i < n_pages; i++)
> +		gnttab_end_foreign_access_ref(grant + i);
> +
> +	gnttab_free_grant_reference_seq(grant, n_pages);
> +
> +	free_pages((unsigned long)vaddr, get_order(size));
> +}
> +
> +static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_t size,
> +					       dma_addr_t *dma_handle,
> +					       enum dma_data_direction dir,
> +					       gfp_t gfp)
> +{
> +	WARN_ONCE(1, "xen_virtio_dma_alloc_pages size %ld\n", size);
> +	return NULL;
> +}
> +
> +static void xen_virtio_dma_free_pages(struct device *dev, size_t size,
> +				      struct page *vaddr, dma_addr_t dma_handle,
> +				      enum dma_data_direction dir)
> +{
> +	WARN_ONCE(1, "xen_virtio_dma_free_pages size %ld\n", size);
> +}
> +
> +static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct page *page,
> +					  unsigned long offset, size_t size,
> +					  enum dma_data_direction dir,
> +					  unsigned long attrs)
> +{
> +	grant_ref_t grant;
> +
> +	if (gnttab_alloc_grant_references(1, &grant))
> +		return 0;
> +
> +	gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page),
> +					dir == DMA_TO_DEVICE);
> +	return grant_to_dma(grant) + offset;
> +}
> +
> +static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
> +				      size_t size, enum dma_data_direction dir,
> +				      unsigned long attrs)
> +{
> +	grant_ref_t grant;
> +
> +	grant = dma_to_grant(dma_handle);
> +
> +	gnttab_end_foreign_access_ref(grant);
> +
> +	gnttab_free_grant_reference(grant);
> +}
> +
> +static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist *sg,
> +				 int nents, enum dma_data_direction dir,
> +				 unsigned long attrs)
> +{
> +	WARN_ONCE(1, "xen_virtio_dma_map_sg nents %d\n", nents);
> +	return -EINVAL;
> +}
> +
> +static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> +				    int nents, enum dma_data_direction dir,
> +				    unsigned long attrs)
> +{
> +	WARN_ONCE(1, "xen_virtio_dma_unmap_sg nents %d\n", nents);
> +}

You can implement xen_virtio_dma_map_sg and xen_virtio_dma_unmap_sg
based on xen_virtio_dma_map_page and xen_virtio_dma_unmap_page, like we
do in drivers/xen/swiotlb-xen.c.


> +static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask)
> +{
> +	return 1;
> +}
> +
> +static const struct dma_map_ops xen_virtio_dma_ops = {
> +	.alloc = xen_virtio_dma_alloc,
> +	.free = xen_virtio_dma_free,
> +	.alloc_pages = xen_virtio_dma_alloc_pages,
> +	.free_pages = xen_virtio_dma_free_pages,
> +	.mmap = dma_common_mmap,
> +	.get_sgtable = dma_common_get_sgtable,
> +	.map_page = xen_virtio_dma_map_page,
> +	.unmap_page = xen_virtio_dma_unmap_page,
> +	.map_sg = xen_virtio_dma_map_sg,
> +	.unmap_sg = xen_virtio_dma_unmap_sg,
> +	.dma_supported = xen_virtio_dma_dma_supported,
> +};
> +
> +void xen_virtio_setup_dma_ops(struct device *dev)
> +{
> +	dev->dma_ops = &xen_virtio_dma_ops;
> +}
> +EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops);
> +
> +MODULE_DESCRIPTION("Xen virtio support driver");
> +MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
> +MODULE_LICENSE("GPL");
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index a3584a3..ae3c1bc 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { }
>  
>  #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
>  
> +#ifdef CONFIG_XEN_VIRTIO
> +void xen_virtio_setup_dma_ops(struct device *dev);
> +#else
> +static inline void xen_virtio_setup_dma_ops(struct device *dev)
> +{
> +}
> +#endif /* CONFIG_XEN_VIRTIO */
> +
>  #endif /* INCLUDE_XEN_OPS_H */
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 22:02:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 22:02:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305912.521024 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU1N-0001Sy-8r; Fri, 15 Apr 2022 22:02:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305912.521024; Fri, 15 Apr 2022 22:02:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU1N-0001Sr-5n; Fri, 15 Apr 2022 22:02:29 +0000
Received: by outflank-mailman (input) for mailman id 305912;
 Fri, 15 Apr 2022 22:02:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfU1L-0001ST-V4
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 22:02:28 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bc1db8d9-bd07-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 00:02:26 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 72DD8B8312A;
 Fri, 15 Apr 2022 22:02:25 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9FCAC385A5;
 Fri, 15 Apr 2022 22:02:23 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc1db8d9-bd07-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650060144;
	bh=ibniDVagqscz7a9Zqfo95NyntpeZavcP31iiyCGyBhk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=sgTvRxnqzjSXyujNEr61AXshfpFwRsPyEjfhWozbdOo1d5PIsG/V/KJ+zIokfZmf6
	 5V3oTSlhN2Bj64ypUrDD8wbuI7a/NXYvrsmGnDxIn8TxY//OHvqrYSBsfyPLSK7uE4
	 mp9UK703vMqODlPgd/mDUwo/TATJ629EBvXVjQ/VC+dyUZxjEm/6e6821+hFNS51hq
	 vyNQ2n3CUG3N+EF0aoJXwLOUKwiPinKtwkA25QuSmxgxZ3rzUWSrPjCgySpgYT+1xm
	 t0eT4xBysLmHXbt6NvDvxRHJN5N15JV4FFjaQKvLCvpTxQuRIgO/V2p8xrvSbO9fmY
	 oBxC5hp/myqEA==
Date: Fri, 15 Apr 2022 15:02:23 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Russell King <linux@armlinux.org.uk>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops
 layer
In-Reply-To: <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204151302350.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-487410210-1650053003=:915916"
Content-ID: <alpine.DEB.2.22.394.2204151317490.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-487410210-1650053003=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204151317491.915916@ubuntu-linux-20-04-desktop>

On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> In the context of current patch do the following:
> 1. Update code to support virtio-mmio devices
> 2. Introduce struct xen_virtio_data and account passed virtio devices
>    (using list) as we need to store some per-device data
> 3. Add multi-page support for xen_virtio_dma_map(unmap)_page callbacks
> 4. Harden code against malicious backend
> 5. Change to use alloc_pages_exact() instead of __get_free_pages()
> 6. Introduce locking scheme to protect mappings (I am not 100% sure
>    whether per-device lock is really needed)
> 7. Handle virtio device's DMA mask
> 8. Retrieve the ID of backend domain from DT for virtio-mmio device
>    instead of hardcoding it.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>  arch/arm/xen/enlighten.c |  11 +++
>  drivers/xen/Kconfig      |   2 +-
>  drivers/xen/xen-virtio.c | 200 ++++++++++++++++++++++++++++++++++++++++++-----
>  include/xen/xen-ops.h    |   5 ++
>  4 files changed, 196 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index ec5b082..870d92f 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -409,6 +409,17 @@ int __init arch_xen_unpopulated_init(struct resource **res)
>  }
>  #endif
>  
> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> +int arch_has_restricted_virtio_memory_access(void)
> +{
> +	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
> +		return 1;

Instead of xen_hvm_domain(), you can just use xen_domain(). Also there
is no need for the #ifdef
CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, given that:

CONFIG_XEN_HVM_VIRTIO_GRANT depends on XEN_VIRTIO which selects
ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS


> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> +#endif
> +
>  static void __init xen_dt_guest_init(void)
>  {
>  	struct device_node *xen_node;
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index fc61f7a..56afe6a 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -347,7 +347,7 @@ config XEN_VIRTIO
>  
>  config XEN_HVM_VIRTIO_GRANT
>  	bool "Require virtio for fully virtualized guests to use grant mappings"
> -	depends on XEN_VIRTIO && X86_64
> +	depends on XEN_VIRTIO && (X86_64 || ARM || ARM64)

you can remove the architectural dependencies


>  	default y
>  	help
>  	  Require virtio for fully virtualized guests to use grant mappings.
> diff --git a/drivers/xen/xen-virtio.c b/drivers/xen/xen-virtio.c
> index cfd5eda..c5b2ec9 100644
> --- a/drivers/xen/xen-virtio.c
> +++ b/drivers/xen/xen-virtio.c
> @@ -7,12 +7,26 @@
>  
>  #include <linux/module.h>
>  #include <linux/dma-map-ops.h>
> +#include <linux/of.h>
>  #include <linux/pci.h>
>  #include <linux/pfn.h>
>  #include <linux/virtio_config.h>
>  #include <xen/xen.h>
>  #include <xen/grant_table.h>
>  
> +struct xen_virtio_data {
> +	/* The ID of backend domain */
> +	domid_t dev_domid;
> +	struct device *dev;
> +	struct list_head list;
> +	spinlock_t lock;
> +	/* Is device behaving sane? */
> +	bool broken;

If you moved "broken" after "dev_domid" we would save a few bytes for
every allocation due to padding.

Is data->lock only there to protect accesses to "broken"? If so, we
might not need it, but I am not sure.


> +};
> +
> +static LIST_HEAD(xen_virtio_devices);
> +static DEFINE_SPINLOCK(xen_virtio_lock);
> +
>  #define XEN_GRANT_ADDR_OFF	0x8000000000000000ULL
>  
>  static inline dma_addr_t grant_to_dma(grant_ref_t grant)
> @@ -25,6 +39,25 @@ static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>  	return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT);
>  }
>  
> +static struct xen_virtio_data *find_xen_virtio_data(struct device *dev)
> +{
> +	struct xen_virtio_data *data = NULL;
> +	bool found = false;
> +
> +	spin_lock(&xen_virtio_lock);
> +
> +	list_for_each_entry( data, &xen_virtio_devices, list) {
> +		if (data->dev == dev) {
> +			found = true;
> +			break;
> +		}
> +	}
> +
> +	spin_unlock(&xen_virtio_lock);
> +
> +	return found ? data : NULL;
> +}
> +
>  /*
>   * DMA ops for Xen virtio frontends.
>   *
> @@ -43,48 +76,78 @@ static void *xen_virtio_dma_alloc(struct device *dev, size_t size,
>  				  dma_addr_t *dma_handle, gfp_t gfp,
>  				  unsigned long attrs)
>  {
> -	unsigned int n_pages = PFN_UP(size);
> -	unsigned int i;
> +	struct xen_virtio_data *data;
> +	unsigned int i, n_pages = PFN_UP(size);
>  	unsigned long pfn;
>  	grant_ref_t grant;
> -	void *ret;
> +	void *ret = NULL;
>  
> -	ret = (void *)__get_free_pages(gfp, get_order(size));
> -	if (!ret)
> +	data = find_xen_virtio_data(dev);
> +	if (!data)
>  		return NULL;
>  
> +	spin_lock(&data->lock);
> +
> +	if (unlikely(data->broken))
> +		goto out;
> +
> +	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
> +	if (!ret)
> +		goto out;
> +
>  	pfn = virt_to_pfn(ret);
>  
>  	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
> -		free_pages((unsigned long)ret, get_order(size));
> -		return NULL;
> +		free_pages_exact(ret, n_pages * PAGE_SIZE);
> +		ret = NULL;
> +		goto out;
>  	}
>  
>  	for (i = 0; i < n_pages; i++) {
> -		gnttab_grant_foreign_access_ref(grant + i, 0,
> +		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
>  						pfn_to_gfn(pfn + i), 0);
>  	}
>  
>  	*dma_handle = grant_to_dma(grant);
>  
> +out:
> +	spin_unlock(&data->lock);
> +
>  	return ret;
>  }
>  
>  static void xen_virtio_dma_free(struct device *dev, size_t size, void *vaddr,
>  				dma_addr_t dma_handle, unsigned long attrs)
>  {
> -	unsigned int n_pages = PFN_UP(size);
> -	unsigned int i;
> +	struct xen_virtio_data *data;
> +	unsigned int i, n_pages = PFN_UP(size);
>  	grant_ref_t grant;
>  
> +	data = find_xen_virtio_data(dev);
> +	if (!data)
> +		return;
> +
> +	spin_lock(&data->lock);
> +
> +	if (unlikely(data->broken))
> +		goto out;
> +
>  	grant = dma_to_grant(dma_handle);
>  
> -	for (i = 0; i < n_pages; i++)
> -		gnttab_end_foreign_access_ref(grant + i);
> +	for (i = 0; i < n_pages; i++) {
> +		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
> +			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
> +			data->broken = true;
> +			goto out;
> +		}
> +	}
>  
>  	gnttab_free_grant_reference_seq(grant, n_pages);
>  
> -	free_pages((unsigned long)vaddr, get_order(size));
> +	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
> +
> +out:
> +	spin_unlock(&data->lock);
>  }
>  
>  static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_t size,
> @@ -108,28 +171,71 @@ static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct page *page,
>  					  enum dma_data_direction dir,
>  					  unsigned long attrs)
>  {
> +	struct xen_virtio_data *data;
> +	unsigned int i, n_pages = PFN_UP(size);
>  	grant_ref_t grant;
> +	dma_addr_t dma_handle = DMA_MAPPING_ERROR;
> +
> +	BUG_ON(dir == DMA_NONE);
> +
> +	data = find_xen_virtio_data(dev);
> +	if (!data)
> +		return DMA_MAPPING_ERROR;
> +
> +	spin_lock(&data->lock);
>  
> -	if (gnttab_alloc_grant_references(1, &grant))
> -		return 0;
> +	if (unlikely(data->broken))
> +		goto out;
>  
> -	gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page),
> -					dir == DMA_TO_DEVICE);
> +	if (gnttab_alloc_grant_reference_seq(n_pages, &grant))
> +		goto out;
>  
> -	return grant_to_dma(grant) + offset;
> +	for (i = 0; i < n_pages; i++) {
> +		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
> +				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
> +	}
> +
> +	dma_handle = grant_to_dma(grant) + offset;
> +
> +out:
> +	spin_unlock(&data->lock);
> +
> +	return dma_handle;
>  }
>  
>  static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>  				      size_t size, enum dma_data_direction dir,
>  				      unsigned long attrs)
>  {
> +	struct xen_virtio_data *data;
> +	unsigned int i, n_pages = PFN_UP(size);
>  	grant_ref_t grant;
>  
> +	BUG_ON(dir == DMA_NONE);
> +
> +	data = find_xen_virtio_data(dev);
> +	if (!data)
> +		return;
> +
> +	spin_lock(&data->lock);
> +
> +	if (unlikely(data->broken))
> +		goto out;
> +
>  	grant = dma_to_grant(dma_handle);
>  
> -	gnttab_end_foreign_access_ref(grant);
> +	for (i = 0; i < n_pages; i++) {
> +		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
> +			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
> +			data->broken = true;
> +			goto out;
> +		}
> +	}
> +
> +	gnttab_free_grant_reference_seq(grant, n_pages);
>  
> -	gnttab_free_grant_reference(grant);
> +out:
> +	spin_unlock(&data->lock);
>  }
>  
>  static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist *sg,
> @@ -149,7 +255,7 @@ static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
>  
>  static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask)
>  {
> -	return 1;
> +	return mask == DMA_BIT_MASK(64);
>  }
>  
>  static const struct dma_map_ops xen_virtio_dma_ops = {
> @@ -166,9 +272,61 @@ static const struct dma_map_ops xen_virtio_dma_ops = {
>  	.dma_supported = xen_virtio_dma_dma_supported,
>  };
>  
> +bool xen_is_virtio_device(struct device *dev)
> +{
> +	/* XXX Handle only DT devices for now */
> +	if (!dev->of_node)
> +		return false;
> +
> +	if (!of_device_is_compatible(dev->of_node, "virtio,mmio"))
> +		return false;
> +
> +	return of_property_read_bool(dev->of_node, "xen,dev-domid");
> +}
> +EXPORT_SYMBOL_GPL(xen_is_virtio_device);
> +
>  void xen_virtio_setup_dma_ops(struct device *dev)
>  {
> +	struct xen_virtio_data *data;
> +	uint32_t dev_domid;
> +
> +	data = find_xen_virtio_data(dev);
> +	if (data) {
> +		dev_err(dev, "xen_virtio data is already created\n");
> +		return;
> +	}
> +
> +	if (dev_is_pci(dev)) {
> +		/* XXX Leave it hard wired to dom0 for now */
> +		dev_domid = 0;
> +	} else if (dev->of_node) {
> +		if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) {
> +			dev_err(dev, "xen,dev-domid property is not present\n");
> +			goto err;
> +		}
> +	} else
> +		/* The ACPI case is not supported */
> +		goto err;

If we get here, it means that xen_is_virtio_device returned true, so the
PCI case is actually impossible?

I would rewrite these checks like this:

/* XXX: ACPI and PCI unsupported for now */
if (dev_is_pci(dev) || !dev->of_node) {
	goto err;
}
if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) {
	dev_err(dev, "xen,dev-domid property is not present\n");
	goto err;
}



> +	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> +	if (!data) {
> +		dev_err(dev, "Сannot allocate xen_virtio data\n");
> +		goto err;
> +	}
> +	data->dev_domid = dev_domid;
> +	data->dev = dev;
> +	spin_lock_init(&data->lock);
> +
> +	spin_lock(&xen_virtio_lock);
> +	list_add(&data->list, &xen_virtio_devices);
> +	spin_unlock(&xen_virtio_lock);
> +
>  	dev->dma_ops = &xen_virtio_dma_ops;
> +
> +	return;
> +
> +err:
> +	dev_err(dev, "Сannot set up xen_virtio DMA ops, retain platform DMA ops\n");
>  }
>  EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops);
>  
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index ae3c1bc..fdbcb99 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { }
>  
>  #ifdef CONFIG_XEN_VIRTIO
>  void xen_virtio_setup_dma_ops(struct device *dev);
> +bool xen_is_virtio_device(struct device *dev);
>  #else
>  static inline void xen_virtio_setup_dma_ops(struct device *dev)
>  {
>  }
> +static inline bool xen_is_virtio_device(struct device *dev)
> +{
> +	return false;
> +}
>  #endif /* CONFIG_XEN_VIRTIO */
>  
>  #endif /* INCLUDE_XEN_OPS_H */
--8323329-487410210-1650053003=:915916--


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 22:02:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 22:02:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305913.521036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU1W-0001nu-Go; Fri, 15 Apr 2022 22:02:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305913.521036; Fri, 15 Apr 2022 22:02:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU1W-0001nk-DL; Fri, 15 Apr 2022 22:02:38 +0000
Received: by outflank-mailman (input) for mailman id 305913;
 Fri, 15 Apr 2022 22:02:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfU1U-0001ST-K3
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 22:02:36 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c15a1619-bd07-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 00:02:35 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 37B6162197;
 Fri, 15 Apr 2022 22:02:34 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E20BCC385A5;
 Fri, 15 Apr 2022 22:02:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c15a1619-bd07-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650060153;
	bh=PeF6Zc0nAV5VY/+eiewggzupF5+3PeXMBsC5arnyfGg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZonlUzR62i2dx/H/zmKML/zbXZLoU8bNTM3Qo+bpEHOIhO/tl1vChpFxc9FnNP7tI
	 iBrLaRmWNGkok98HLRW8srCFNX3xB7D1iWQIOgVUcV8UkQ277gin7i1//XVYoKSh45
	 aRQ4+ryHCPnZ2fAzxeGFqksQQsvOdKw1nuio5BBDTGrma/qwnv5GiYuI0i5X7csc9r
	 0gNi+/kkolFIBJqlZnMu1kI/DPk6O1MPcvIOY7eNNR3H5HVRMadEBHjhYdnCb2DIkm
	 H9QclxzfOEk+uBt3Cn9nvDI6q/6E8InTJypsEJFNEZcel7WomzKZfHLtMTWMymCF/i
	 /k3KqskBJ6ayg==
Date: Fri, 15 Apr 2022 15:02:32 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Russell King <linux@armlinux.org.uk>, 
    Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Logan Gunthorpe <logang@deltatee.com>, 
    David Hildenbrand <david@redhat.com>, 
    Martin Oliveira <martin.oliveira@eideticom.com>, 
    Kees Cook <keescook@chromium.org>, 
    Jean-Philippe Brucker <jean-philippe@linaro.org>, 
    Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH 5/6] arm/xen: Introduce xen_setup_dma_ops()
In-Reply-To: <1649963973-22879-6-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204151303340.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-6-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This patch introduces new helper and places it in new header.
> The helper's purpose is to assign any Xen specific DMA ops in
> a single place. For now, we deal with xen-swiotlb DMA ops only.
> The subsequent patch will add xen-virtio DMA ops case.
> 
> Also re-use the xen_swiotlb_detect() check on Arm32.

Thanks for the patch, this is good to have in any case. I would move it
to the beginning of the series.


> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>  arch/arm/include/asm/xen/xen-ops.h   |  1 +
>  arch/arm/mm/dma-mapping.c            |  5 ++---
>  arch/arm64/include/asm/xen/xen-ops.h |  1 +
>  arch/arm64/mm/dma-mapping.c          |  5 ++---
>  include/xen/arm/xen-ops.h            | 13 +++++++++++++
>  5 files changed, 19 insertions(+), 6 deletions(-)
>  create mode 100644 arch/arm/include/asm/xen/xen-ops.h
>  create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
>  create mode 100644 include/xen/arm/xen-ops.h
> 
> diff --git a/arch/arm/include/asm/xen/xen-ops.h b/arch/arm/include/asm/xen/xen-ops.h
> new file mode 100644
> index 00000000..8d2fa24
> --- /dev/null
> +++ b/arch/arm/include/asm/xen/xen-ops.h
> @@ -0,0 +1 @@
> +#include <xen/arm/xen-ops.h>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 82ffac6..a1bf9dd 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -33,7 +33,7 @@
>  #include <asm/dma-iommu.h>
>  #include <asm/mach/map.h>
>  #include <asm/system_info.h>
> -#include <xen/swiotlb-xen.h>
> +#include <asm/xen/xen-ops.h>
>  
>  #include "dma.h"
>  #include "mm.h"
> @@ -2288,8 +2288,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>  	set_dma_ops(dev, dma_ops);
>  
>  #ifdef CONFIG_XEN
> -	if (xen_initial_domain())
> -		dev->dma_ops = &xen_swiotlb_dma_ops;
> +	xen_setup_dma_ops(dev);
>  #endif

You can take this opportunity to also remove the #ifdef, by providing an
empty stub implemention of xen_setup_dma_ops for the !CONFIG_XEN case.


>  	dev->archdata.dma_ops_setup = true;
>  }
> diff --git a/arch/arm64/include/asm/xen/xen-ops.h b/arch/arm64/include/asm/xen/xen-ops.h
> new file mode 100644
> index 00000000..8d2fa24
> --- /dev/null
> +++ b/arch/arm64/include/asm/xen/xen-ops.h
> @@ -0,0 +1 @@
> +#include <xen/arm/xen-ops.h>
> diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
> index 6719f9e..831e673 100644
> --- a/arch/arm64/mm/dma-mapping.c
> +++ b/arch/arm64/mm/dma-mapping.c
> @@ -9,9 +9,9 @@
>  #include <linux/dma-map-ops.h>
>  #include <linux/dma-iommu.h>
>  #include <xen/xen.h>
> -#include <xen/swiotlb-xen.h>
>  
>  #include <asm/cacheflush.h>
> +#include <asm/xen/xen-ops.h>
>  
>  void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
>  		enum dma_data_direction dir)
> @@ -53,7 +53,6 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>  		iommu_setup_dma_ops(dev, dma_base, dma_base + size - 1);
>  
>  #ifdef CONFIG_XEN
> -	if (xen_swiotlb_detect())
> -		dev->dma_ops = &xen_swiotlb_dma_ops;
> +	xen_setup_dma_ops(dev);
>  #endif

same here


>  }
> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
> new file mode 100644
> index 00000000..621da05
> --- /dev/null
> +++ b/include/xen/arm/xen-ops.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _ASM_ARM_XEN_OPS_H
> +#define _ASM_ARM_XEN_OPS_H
> +
> +#include <xen/swiotlb-xen.h>
> +
> +static inline void xen_setup_dma_ops(struct device *dev)
> +{
> +	if (xen_swiotlb_detect())
> +		dev->dma_ops = &xen_swiotlb_dma_ops;
> +}
> +
> +#endif /* _ASM_ARM_XEN_OPS_H */
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 22:02:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 22:02:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305915.521047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU1h-0002IO-Pd; Fri, 15 Apr 2022 22:02:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305915.521047; Fri, 15 Apr 2022 22:02:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfU1h-0002IF-M9; Fri, 15 Apr 2022 22:02:49 +0000
Received: by outflank-mailman (input) for mailman id 305915;
 Fri, 15 Apr 2022 22:02:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfU1g-0001ST-Cw
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 22:02:48 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c8dfebc9-bd07-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 00:02:47 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2682CB82BAA;
 Fri, 15 Apr 2022 22:02:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B080C385A4;
 Fri, 15 Apr 2022 22:02:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8dfebc9-bd07-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650060165;
	bh=jMIyyGQ4CRdsA1X7oxI8CTQb0IBKbJqeD84G5GJpvrs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DXvqR0Keim+tfwUUwYyM6574yaiWEcj28C/cHng/0XCSegk9hetkQruScA8hrYQlS
	 /ZD/C1AjvTcFvA+XXBN77pc/acwLax0/RDIpW6c218usILvr5ehxi1F/0eyj6WXzi0
	 O1cDrfH+NOQVSkSKclpyrjWv3CIlYFatU0R4G+J4pyaE20kPRekBJxB7JLzPqRIi6V
	 30Zgqtkgwwv4XNEXn71dvq+Z2MUUCB9bMJs4PyIAj1Q+y/GnNOBNaGU0Est8neT7EQ
	 qOK3sD4Gg9vLArJLSsNa+wTCI6qfW56EyOoPpLezZK1AlyLe43X1zlkbJFNu3ymWJS
	 /vTcXwOaDkD2w==
Date: Fri, 15 Apr 2022 15:02:45 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
In-Reply-To: <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Call xen_virtio_setup_dma_ops() only for Xen-aware virtio devices
> in Xen guests if restricted access to the guest memory is enabled.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>  include/xen/arm/xen-ops.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
> index 621da05..28b2ad3 100644
> --- a/include/xen/arm/xen-ops.h
> +++ b/include/xen/arm/xen-ops.h
> @@ -2,12 +2,19 @@
>  #ifndef _ASM_ARM_XEN_OPS_H
>  #define _ASM_ARM_XEN_OPS_H
>  
> +#include <linux/virtio_config.h>
>  #include <xen/swiotlb-xen.h>
> +#include <xen/xen-ops.h>
>  
>  static inline void xen_setup_dma_ops(struct device *dev)
>  {
>  	if (xen_swiotlb_detect())
>  		dev->dma_ops = &xen_swiotlb_dma_ops;
> +
> +#ifdef CONFIG_XEN_VIRTIO
> +	if (arch_has_restricted_virtio_memory_access() && xen_is_virtio_device(dev))
> +		xen_virtio_setup_dma_ops(dev);
> +#endif

This makes sense overall. Considering that the swiotlb-xen case and the
virtio case are mutually exclusive, I would write it like this:

	if (arch_has_restricted_virtio_memory_access() && xen_is_virtio_device(dev))
		xen_virtio_setup_dma_ops(dev);
	else if (xen_swiotlb_detect())
		dev->dma_ops = &xen_swiotlb_dma_ops;

There is no need for #ifdef (also see other comments).


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 22:17:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 22:17:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305930.521058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfUFR-0004LR-5o; Fri, 15 Apr 2022 22:17:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305930.521058; Fri, 15 Apr 2022 22:17:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfUFR-0004LK-2k; Fri, 15 Apr 2022 22:17:01 +0000
Received: by outflank-mailman (input) for mailman id 305930;
 Fri, 15 Apr 2022 22:16:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfUFP-0004LA-Si; Fri, 15 Apr 2022 22:16:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfUFP-0004lh-QT; Fri, 15 Apr 2022 22:16:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfUFP-0001hc-Cc; Fri, 15 Apr 2022 22:16:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfUFP-0006HH-CA; Fri, 15 Apr 2022 22:16:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gIwQr7VJWJmfBm7A8jY6BJQOswklH9i4LtFWQDQu1FA=; b=4ENlD71EBciYYTQgmUDcpO7M5x
	qtSIGyKvrXS8XfVTW9ghbITgrAqGqdz6jSjYelCR686zRrjOrI0ZJ422m8wibTDCpcENGDkvXrzF+
	tjkR7Bt3XLxtQgIufEHV404+pJHnQhwiddthazsLeRFbl/ysXw0dJHxFuANwaIuSTXmU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169437-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169437: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 22:16:59 +0000

flight 169437 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169437/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  421 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 22:19:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 22:19:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305939.521069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfUHP-0004vy-J1; Fri, 15 Apr 2022 22:19:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305939.521069; Fri, 15 Apr 2022 22:19:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfUHP-0004vr-Fv; Fri, 15 Apr 2022 22:19:03 +0000
Received: by outflank-mailman (input) for mailman id 305939;
 Fri, 15 Apr 2022 22:19:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfUHO-0004vj-0d
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 22:19:02 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0d09fda6-bd0a-11ec-8fbe-03012f2f19d4;
 Sat, 16 Apr 2022 00:19:00 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 150A7B83122;
 Fri, 15 Apr 2022 22:19:00 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24E2DC385A4;
 Fri, 15 Apr 2022 22:18:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d09fda6-bd0a-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650061138;
	bh=fscACWys4DXSOaZ8pzzt20bUsUJOvEXojsuQGUVaXEI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=cV7D6S9Zcm9o1PgKk/92APwE108cD816p4nS+GfJm3a5hYohEmbQoM0CNgq0o9Ojb
	 7Dn2iGFyV3PcBW6ni5wpYkPF+Yf5mZ9UrQLv9kZ6QJvOYlj9k1SFTUAIyDbeVHQqBg
	 u0gQZio8p45XsDmfpgQwMnwxQPSqwB2fNwgu5E5Dy2LKYDdFZBUtgQoDhDa/nqZbkj
	 6N8a3Y50leuzl0xEH9WMl0CaYIFTuq/n8ALwaOEditxCWgxE8tlDv/Feq2rj/+6+kp
	 qW5uaQEwmw57vr1CDikL5ydRGkueOUsexQeWHcpXO+da4mtmFbVAfhGxZKdlYwKb7s
	 8Uo7Js2X3rM7w==
Date: Fri, 15 Apr 2022 15:18:57 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Penny Zheng <Penny.Zheng@arm.com>
cc: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Jan Beulich <jbeulich@suse.com>, nd <nd@arm.com>, 
    Penny Zheng <penzhe01@a011292.shanghai.arm.com>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH v1 02/13] xen/arm: introduce a special domain
 DOMID_SHARED
In-Reply-To: <DU2PR08MB7325F469140EFE83F2F8F91DF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2204151506520.915916@ubuntu-linux-20-04-desktop>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com> <20220311061123.1883189-3-Penny.Zheng@arm.com> <eefa9cf2-a04c-ba8d-74cb-0d2aaa35badb@suse.com> <alpine.DEB.2.22.394.2203181443440.2910984@ubuntu-linux-20-04-desktop> <30a6ef6f-d37c-b66c-d5af-be2208766057@suse.com>
 <alpine.DEB.2.22.394.2203211256370.2910984@ubuntu-linux-20-04-desktop> <f8627956-8b01-6a5d-d69a-d2da16d74726@xen.org> <DU2PR08MB7325F469140EFE83F2F8F91DF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 15 Apr 2022, Penny Zheng wrote:
> > Hi Stefano,
> > 
> > On 21/03/2022 20:03, Stefano Stabellini wrote:
> > > On Mon, 21 Mar 2022, Jan Beulich wrote:
> > >> On 18.03.2022 22:50, Stefano Stabellini wrote:
> > >>> On Fri, 18 Mar 2022, Jan Beulich wrote:
> > >>>> On 11.03.2022 07:11, Penny Zheng wrote:
> > >>>>> In case to own statically shared pages when owner domain is not
> > >>>>> explicitly defined, this commits propose a special domain
> > >>>>> DOMID_SHARED, and we assign it 0x7FF5, as one of the system domains.
> > >>>>>
> > >>>>> Statically shared memory reuses the same way of initialization
> > >>>>> with static memory, hence this commits proposes a new Kconfig
> > >>>>> CONFIG_STATIC_SHM to wrap related codes, and this option depends
> > on static memory(CONFIG_STATIC_MEMORY).
> > >>>>>
> > >>>>> We intends to do shared domain creation after setup_virt_paging so
> > >>>>> shared domain could successfully do p2m initialization.
> > >>>>
> > >>>> There's nothing said here, in the earlier patch, or in the cover
> > >>>> letter about the security aspects of this. There is a reason we
> > >>>> haven't been allowing arbitrary, un-supervised sharing of memory
> > >>>> between domains. It wants clarifying why e.g. grants aren't an
> > >>>> option to achieve what you need, and how you mean to establish
> > >>>> which domains are / aren't permitted to access any individual page
> > owned by this domain.
> > >>>
> > >>>
> > >>> I'll let Penny write a full reply but I'll chime in to try to help
> > >>> with the explanation.
> > >>>
> > >>> This is not arbitrary un-supervised sharing of memory between
> > >>> domains, which indeed is concerning.
> > >>>
> > >>> This is statically-configured, supervised by the system
> > >>> configurator, sharing of memory between domains.
> > >>>
> > >>> And in fact safety (which is just a different aspect of security) is
> > >>> one of the primary goals for this work.
> > >>>
> > >>> In safety-critical environments, it is not considered safe to
> > >>> dynamically change important configurations at runtime. Everything
> > >>> should be statically defined and statically verified.
> > >>>
> > >>> In this case, if the system configuration knows a priori that there
> > >>> are only 2 VM and they need to communication over shared memory, it
> > >>> is safer to pre-configure the shared memory at build time rather
> > >>> than let the VMs attempt to share memory at runtime. It is faster too.
> > >>>
> > >>> The only way to trigger this static shared memory configuration
> > >>> should be via device tree, which is at the same level as the XSM
> > >>> rules themselves.
> > >>>
> > >>> Hopefully I made things clearer and not murkier :-)
> > >>
> > >> It adds some helpful background, yes, but at the same time it doesn't
> > >> address the security concern at all: How are access permissions
> > >> managed when the owning domain is a special one? I haven't spotted
> > >> any recording of the domains which are actually permitted to map /
> > >> access the pages in questions. (But of course I also only looked at
> > >> non-Arm-specific code. I'd expect such code not to live in arch-
> > >> specific files.)
> > >
> > > All this static memory sharing is statically done at __init time only.
> > > It should not be possible to trigger any further memory sharing at
> > > runtime (if there is, that would be a bug).
> > 
> > Looking at the code, get_pg_owner() will be able to handle DOMID_SHARED.
> > So anyone that is permitted to access DOMID_SHARED will be able to map any
> > memory region at runtime.
> > 
> > > There are no new interfaces for the guest to map this memory because
> > > it is already "pre-mapped".
> > 
> > It can via XENMAPSPACE_gmfn_foreign (assuming proper permission).
> > 
> 
> Correct me if I'm wrong:
> The existing XENMAPSPACE_gmfn_foreign only allows privileged Dom0 to map
> memory pages from one foreign DomU to itself. So It can happen that Dom0 is
> using XENMAPSPACE_gmfn_foreign to (maliciously?) access shared memory owned
> by DOMID_SHARED, and for now only Dom0 could.

No, currently there is no protection against dom0 doing malicious
operations. Dom0 can poweroff the entire system.

If we are certain that only dom0 (and not other domains) can use
XENMAPSPACE_gmfn_foreign to access shared memory owned by DOMID_SHARED
then we are good. Looking at the code, and also considering that we have
agreed to move to DOMID_IO, get_pg_owner can already handle DOMID_IO.

Next is the xsm_map_gmfn_foreign(XSM_TARGET, d, od) check, which would
fail unless the asking domain is privileged over the target domain.
xsm_map_gmfn_foreign would fail for all domains except dom0.

So I think we are OK. I don't think we need to do anything else.


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 22:27:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 22:27:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305944.521079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfUP8-0006RO-CM; Fri, 15 Apr 2022 22:27:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305944.521079; Fri, 15 Apr 2022 22:27:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfUP8-0006RH-9U; Fri, 15 Apr 2022 22:27:02 +0000
Received: by outflank-mailman (input) for mailman id 305944;
 Fri, 15 Apr 2022 22:27:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfUP6-0006RB-UD
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 22:27:01 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 29863fb3-bd0b-11ec-8fbe-03012f2f19d4;
 Sat, 16 Apr 2022 00:26:59 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 9480862116;
 Fri, 15 Apr 2022 22:26:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F9E6C385A4;
 Fri, 15 Apr 2022 22:26:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29863fb3-bd0b-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650061617;
	bh=PN9Wghh2u+WBV+lc4rxfbwHQy8ORwnCgwhxfFuTi1wo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ofhs9m+fl2KPBq9TGw1n5JPnc9k04T5CMRnpplI1k/bNYFFdkN3l/MgFRJN35Ylv+
	 3AtAhZiVhfXnIiDrC7eKvsJbE+IWA0ikFrrUQsc9iFHDj/UtLHPx2mJ4jEuJpr6rg8
	 Ux3GjEmFDbjRTUQDWbkgyE4+URCkVmIWuHQm4oHTzWwPAraDGUI0MNrnV6o4jmOX90
	 0K3mix+T6V9aelzBvJVDxRc/3Q8LCR/mW2hcApxSDmUUKy+Hc0yaOUIUrd/fuiqW18
	 lISMzMJjv52Pbghnsks/TJO4OOqSUKfKaEUtyUbiPwcx7WxSBvlSqldjtuuixtZ9PH
	 k9tkKu/DbfHag==
Date: Fri, 15 Apr 2022 15:26:56 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
cc: sstabellini@kernel.org, julien@xen.org, Volodymyr_Babchuk@epam.com, 
    bertrand.marquis@arm.com, andrew.cooper3@citrix.com, 
    george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, 
    xen-devel@lists.xenproject.org, van.freenix@gmail.com, 
    michal.orzel@arm.com, Peng Fan <peng.fan@nxp.com>, 
    Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
In-Reply-To: <20220414074452.14419-2-peng.fan@oss.nxp.com>
Message-ID: <alpine.DEB.2.22.394.2204151525120.915916@ubuntu-linux-20-04-desktop>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com> <20220414074452.14419-2-peng.fan@oss.nxp.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Apr 2022, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The i.MX LPUART Documentation:
> https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
> Chatper 13.6 Low Power Universal Asynchronous Receiver/
> Transmitter (LPUART)
> 
> Tested-by: Henry Wang <Henry.Wang@arm.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
>  xen/drivers/char/Kconfig              |   7 +
>  xen/drivers/char/Makefile             |   1 +
>  xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
>  4 files changed, 348 insertions(+)
>  create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
>  create mode 100644 xen/drivers/char/imx-lpuart.c
> 
> diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
> new file mode 100644
> index 0000000000..fe859045dc
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/imx-lpuart.h
> @@ -0,0 +1,64 @@
> +/*
> + * xen/arch/arm/include/asm/imx-lpuart.h
> + *
> + * Common constant definition between early printk and the LPUART driver
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ASM_ARM_IMX_LPUART_H__
> +#define __ASM_ARM_IMX_LPUART_H__
> +
> +/* 32-bit register definition */
> +#define UARTBAUD          (0x10)
> +#define UARTSTAT          (0x14)
> +#define UARTCTRL          (0x18)
> +#define UARTDATA          (0x1C)
> +#define UARTMATCH         (0x20)
> +#define UARTMODIR         (0x24)
> +#define UARTFIFO          (0x28)
> +#define UARTWATER         (0x2c)
> +
> +#define UARTSTAT_TDRE     BIT(23, UL)
> +#define UARTSTAT_TC       BIT(22, UL)
> +#define UARTSTAT_RDRF     BIT(21, UL)
> +#define UARTSTAT_OR       BIT(19, UL)
> +
> +#define UARTBAUD_OSR_SHIFT    (24)
> +#define UARTBAUD_OSR_MASK     (0x1f)
> +#define UARTBAUD_SBR_MASK     (0x1fff)
> +#define UARTBAUD_BOTHEDGE     (0x00020000)
> +#define UARTBAUD_TDMAE        (0x00800000)
> +#define UARTBAUD_RDMAE        (0x00200000)
> +
> +#define UARTCTRL_TIE      BIT(23, UL)
> +#define UARTCTRL_TCIE     BIT(22, UL)
> +#define UARTCTRL_RIE      BIT(21, UL)
> +#define UARTCTRL_ILIE     BIT(20, UL)
> +#define UARTCTRL_TE       BIT(19, UL)
> +#define UARTCTRL_RE       BIT(18, UL)
> +#define UARTCTRL_M        BIT(4, UL)
> +
> +#define UARTWATER_RXCNT_OFF     24
> +
> +#endif /* __ASM_ARM_IMX_LPUART_H__ */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> index 2ff5b288e2..e5f7b1d8eb 100644
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -13,6 +13,13 @@ config HAS_CADENCE_UART
>  	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
>  	  based board, say Y.
>  
> +config HAS_IMX_LPUART
> +	bool "i.MX LPUART driver"
> +	default y
> +	depends on ARM_64
> +	help
> +	  This selects the i.MX LPUART. If you have i.MX8QM based board, say Y.
> +
>  config HAS_MVEBU
>  	bool "Marvell MVEBU UART driver"
>  	default y
> diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
> index 7c646d771c..14e67cf072 100644
> --- a/xen/drivers/char/Makefile
> +++ b/xen/drivers/char/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o
>  obj-$(CONFIG_HAS_OMAP) += omap-uart.o
>  obj-$(CONFIG_HAS_SCIF) += scif-uart.o
>  obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o
> +obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o
>  obj-$(CONFIG_ARM) += arm-uart.o
>  obj-y += serial.o
>  obj-$(CONFIG_XEN_GUEST) += xen_pv_console.o
> diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
> new file mode 100644
> index 0000000000..df44f91e5d
> --- /dev/null
> +++ b/xen/drivers/char/imx-lpuart.c
> @@ -0,0 +1,276 @@
> +/*
> + * xen/drivers/char/imx-lpuart.c
> + *
> + * Driver for i.MX LPUART.
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright 2022 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <xen/errno.h>
> +#include <xen/init.h>
> +#include <xen/irq.h>
> +#include <xen/mm.h>
> +#include <xen/serial.h>
> +#include <asm/device.h>
> +#include <asm/imx-lpuart.h>
> +#include <asm/io.h>
> +
> +#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
> +#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
> +
> +static struct imx_lpuart {
> +    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
> +    uint32_t irq;
> +    char __iomem *regs;
> +    struct irqaction irqaction;
> +    struct vuart_info vuart;
> +} imx8_com;
> +
> +static void imx_lpuart_interrupt(int irq, void *data,
> +                                 struct cpu_user_regs *regs)
> +{
> +    struct serial_port *port = data;
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t sts, rxcnt;
> +
> +    sts = imx_lpuart_read(uart, UARTSTAT);
> +    rxcnt = imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
> +
> +    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
> +	    serial_rx_interrupt(port, regs);
> +
> +    if ( sts & UARTSTAT_TDRE )
> +	    serial_tx_interrupt(port, regs);
> +
> +    imx_lpuart_write(uart, UARTSTAT, sts);
> +}
> +
> +static void __init imx_lpuart_init_preirq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t ctrl, old_ctrl, bd;
> +
> +    old_ctrl = imx_lpuart_read(uart, UARTCTRL);
> +    ctrl = (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
> +    bd = imx_lpuart_read(uart, UARTBAUD);
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
> +	    cpu_relax();
> +
> +    /* Disable transmit and receive */
> +    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL_RE));
> +
> +    /* Reuse firmware baudrate settings, only disable DMA here */
> +    bd &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
> +
> +    imx_lpuart_write(uart, UARTMODIR, 0);
> +    imx_lpuart_write(uart, UARTBAUD, bd);
> +    imx_lpuart_write(uart, UARTCTRL, ctrl);
> +}
> +
> +static void __init imx_lpuart_init_postirq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t temp;
> +
> +    uart->irqaction.handler = imx_lpuart_interrupt;
> +    uart->irqaction.name = "imx_lpuart";
> +    uart->irqaction.dev_id = port;
> +
> +    if ( setup_irq(uart->irq, 0, &uart->irqaction) != 0 )
> +    {
> +        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
> +                uart->irq);
> +        return;
> +    }
> +
> +    /* Enable interrupts */
> +    temp = imx_lpuart_read(uart, UARTCTRL);
> +    temp |= (UARTCTRL_RIE | UARTCTRL_TIE);
> +    temp |= UARTCTRL_ILIE;
> +    imx_lpuart_write(uart, UARTCTRL, temp);
> +}
> +
> +static void imx_lpuart_suspend(struct serial_port *port)
> +{
> +    BUG();
> +}
> +
> +static void imx_lpuart_resume(struct serial_port *port)
> +{
> +    BUG();
> +}
> +
> +static int imx_lpuart_tx_ready(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +
> +    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
> +}
> +
> +static void imx_lpuart_putc(struct serial_port *port, char c)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
> +        cpu_relax();
> +
> +    imx_lpuart_write(uart, UARTDATA, c);
> +}
> +
> +static int imx_lpuart_getc(struct serial_port *port, char *pc)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    int ch;
> +
> +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
> +	    return 0;
> +
> +    ch = imx_lpuart_read(uart, UARTDATA);
> +    *pc = ch & 0xff;
> +
> +    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
> +        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
> +
> +    return 1;
> +}
> +
> +static int __init imx_lpuart_irq(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +
> +    return ((uart->irq > 0) ? uart->irq : -1);
> +}
> +
> +static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +
> +    return &uart->vuart;
> +}
> +
> +static void imx_lpuart_start_tx(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t temp;
> +
> +    temp = imx_lpuart_read(uart, UARTSTAT);
> +    /* Wait until empty */
> +    while ( !(temp & UARTSTAT_TDRE) )
> +	    cpu_relax();

It looks like this is looping over a stale variable?


> +    temp = imx_lpuart_read(uart, UARTCTRL);
> +    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
> +}
> +
> +static void imx_lpuart_stop_tx(struct serial_port *port)
> +{
> +    struct imx_lpuart *uart = port->uart;
> +    uint32_t temp;
> +
> +    temp = imx_lpuart_read(uart, UARTCTRL);
> +    temp &= ~(UARTCTRL_TIE | UARTCTRL_TCIE);
> +    imx_lpuart_write(uart, UARTCTRL, temp);
> +}
> +
> +static struct uart_driver __read_mostly imx_lpuart_driver = {
> +    .init_preirq = imx_lpuart_init_preirq,
> +    .init_postirq = imx_lpuart_init_postirq,
> +    .endboot = NULL,
> +    .suspend = imx_lpuart_suspend,
> +    .resume = imx_lpuart_resume,
> +    .tx_ready = imx_lpuart_tx_ready,
> +    .putc = imx_lpuart_putc,
> +    .getc = imx_lpuart_getc,
> +    .irq = imx_lpuart_irq,
> +    .start_tx = imx_lpuart_start_tx,
> +    .stop_tx = imx_lpuart_stop_tx,
> +    .vuart_info = imx_lpuart_vuart_info,
> +};
> +
> +static int __init imx_lpuart_init(struct dt_device_node *dev,
> +                                  const void *data)
> +{
> +    const char *config = data;
> +    struct imx_lpuart *uart;
> +    int res;
> +    u64 addr, size;
> +
> +    if ( strcmp(config, "") )
> +        printk("WARNING: UART configuration is not supported\n");
> +
> +    uart = &imx8_com;
> +
> +    uart->baud = 115200;
> +    uart->data_bits = 8;
> +    uart->parity = 0;
> +    uart->stop_bits = 1;
> +
> +    res = dt_device_get_address(dev, 0, &addr, &size);
> +    if ( res )
> +    {
> +        printk("imx8-lpuart: Unable to retrieve the base"
> +               " address of the UART\n");
> +        return res;
> +    }
> +
> +    res = platform_get_irq(dev, 0);
> +    if ( res < 0 )
> +    {
> +        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
> +        return -EINVAL;
> +    }
> +    uart->irq = res;
> +
> +    uart->regs = ioremap_nocache(addr, size);
> +    if ( !uart->regs )
> +    {
> +        printk("imx8-lpuart: Unable to map the UART memory\n");
> +        return -ENOMEM;
> +    }
> +
> +    uart->vuart.base_addr = addr;
> +    uart->vuart.size = size;
> +    uart->vuart.data_off = UARTDATA;
> +    /* tmp from uboot */
> +    uart->vuart.status_off = UARTSTAT;
> +    uart->vuart.status = UARTSTAT_TDRE;
> +
> +    /* Register with generic serial driver */
> +    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
> +
> +    dt_device_set_used_by(dev, DOMID_XEN);
> +
> +    return 0;
> +}
> +
> +static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
> +{
> +    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
> +    { /* sentinel */ },
> +};
> +
> +DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
> +    .dt_match = imx_lpuart_dt_compat,
> +    .init = imx_lpuart_init,
> +DT_DEVICE_END
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> -- 
> 2.35.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 23:10:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 23:10:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305951.521090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfV59-0003B4-Rn; Fri, 15 Apr 2022 23:10:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305951.521090; Fri, 15 Apr 2022 23:10:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfV59-0003Ax-P0; Fri, 15 Apr 2022 23:10:27 +0000
Received: by outflank-mailman (input) for mailman id 305951;
 Fri, 15 Apr 2022 23:10:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfV58-0003Ar-Cg
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 23:10:26 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b08c5ef-bd11-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 01:10:24 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0E395B831B8;
 Fri, 15 Apr 2022 23:10:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EB6AC385A4;
 Fri, 15 Apr 2022 23:10:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b08c5ef-bd11-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650064222;
	bh=A0u2cdRoH5YJkFMFzhOSuqQn+v7uguDxOgX08aD0OkA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=XALcqqZEix5pd5JP/seGq02aBaIzPalksoATaduJHVL3YuSrcAQWy4qKD593yP7lB
	 Ih8PVm1ZjG1JolNnj60XWRF/Xsr5ctiwzYKeXp1lLJ/hdmi7pncwKj+y58y7wCXn2G
	 QXERrMdeEIIhLt2ESMTFtf5M4hRRyZCJqPMDV3vlk0gcKia+CezDpZvMsn1HThxZFV
	 mIwIFZ+ULpqgfkHy8y7sVXshlA2equRnq7nGu7ydNDNCSStH2Lb207ietC6UWkHnbY
	 rdpVGZkmQcrhJqEJFrra/5HmbtW3jACZ7wE4XXAT8iiPsUjWG7mko6rXgOJU/YIKRW
	 /1mm9icoYmzYQ==
Date: Fri, 15 Apr 2022 16:10:22 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@arm.com>
cc: xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: Make use of DT_MATCH_TIMER in make_timer_node
In-Reply-To: <20220414095843.102305-1-michal.orzel@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204151609140.915916@ubuntu-linux-20-04-desktop>
References: <20220414095843.102305-1-michal.orzel@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Apr 2022, Michal Orzel wrote:
> DT_MATCH_TIMER stores the compatible timer ids and as such should be
> used in all the places where we need to refer to them. make_timer_node
> explicitly lists the same ids as the ones defined in DT_MATCH_TIMER so
> make use of this macro instead.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

This is a good cleanup, thanks! time.h is not currently included by
domain_build.c, I think we should add:

#include <asm/time.h>

to domain_build.c 


> ---
>  xen/arch/arm/domain_build.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 8be01678de..1472ca4972 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1672,8 +1672,7 @@ static int __init make_timer_node(const struct kernel_info *kinfo)
>      void *fdt = kinfo->fdt;
>      static const struct dt_device_match timer_ids[] __initconst =
>      {
> -        DT_MATCH_COMPATIBLE("arm,armv7-timer"),
> -        DT_MATCH_COMPATIBLE("arm,armv8-timer"),
> +        DT_MATCH_TIMER,
>          { /* sentinel */ },
>      };
>      struct dt_device_node *dev;
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 23:26:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 23:26:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305957.521102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVKf-0004pG-9B; Fri, 15 Apr 2022 23:26:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305957.521102; Fri, 15 Apr 2022 23:26:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVKf-0004p9-4s; Fri, 15 Apr 2022 23:26:29 +0000
Received: by outflank-mailman (input) for mailman id 305957;
 Fri, 15 Apr 2022 23:26:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfVKd-0004oz-QZ; Fri, 15 Apr 2022 23:26:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfVKd-0005vm-OU; Fri, 15 Apr 2022 23:26:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfVKd-0003in-7s; Fri, 15 Apr 2022 23:26:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfVKd-0004rd-7M; Fri, 15 Apr 2022 23:26:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=J+6eeYIU3HLmZh1ygJBUgoCKMbFCIDXDkfLR/lYTaeY=; b=gXT6i6Hs9VPTmmMWGpl1QOK1ew
	0j+0acUrpG+oLTtDoEl3Daey/jAXSfTAwAWCQ6UieNCj5SYxxuvVqObx9OJhlZgDHJeJNANpX32gz
	W+qPj/ILRtAdiwd5qezXBsVfanQkta0N/t8SwgLmoy++Vwx4S+CXNFAGoabSeNXhwdic=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169438-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169438: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 23:26:27 +0000

flight 169438 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169438/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  422 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 23:34:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 23:34:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305966.521112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVSG-0006Ij-37; Fri, 15 Apr 2022 23:34:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305966.521112; Fri, 15 Apr 2022 23:34:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVSG-0006Ic-0M; Fri, 15 Apr 2022 23:34:20 +0000
Received: by outflank-mailman (input) for mailman id 305966;
 Fri, 15 Apr 2022 23:34:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6WtN=UZ=gmail.com=julien.grall@srs-se1.protection.inumbo.net>)
 id 1nfVSE-0006IW-HX
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 23:34:18 +0000
Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com
 [2607:f8b0:4864:20::d36])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90ac761e-bd14-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 01:34:17 +0200 (CEST)
Received: by mail-io1-xd36.google.com with SMTP id b16so9577243ioz.3
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 16:34:17 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90ac761e-bd14-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=jeaoYUKUL61or4HyLQQqgOlw63VbKTQ0KLIlQ62k0w4=;
        b=BTSL9zh+DO29jjB+y19O5XX0kTNctJJJU0WJ4+rVxBHzdijJyf6HXkU8ORoHbSPoPe
         ALyhAgV37MlQIden1ISUVkCKbwL97B3D+ZX20nDRFvtBcOjmANdsjFS04eybz6aOSzCY
         lH7dnqGMKV8ZspiTdTBszyjLyIUVJ5yi/ePSNYYbbBbthNyfhRovyq86X7dROK4iXEGm
         yU+8h1HzfgLSdND5CnybC698LD6NY53zdc8WJhcb+hc9jFhz0UBl+Cr3Zrc71FpuIO5u
         u+JrgcNivnUH8RiddPYNUcc+fOXizCuCrqFV3Vj/In0YyelONtmIqCl4vDik0XobYB0g
         XKoA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=jeaoYUKUL61or4HyLQQqgOlw63VbKTQ0KLIlQ62k0w4=;
        b=n0vALS1AUXZbnNqW3+LS3j3R2irTbt5yuLPWDnMzb9KBNQnW+eN4p5Hf8pl6J+ZZb7
         vNoWB5sAeUM9HzsGGNrS8vRLEmcl6Cwqf10Rfm+99NI0TXMejM8angZzJAAdI2hvPd06
         5ZkF6Rbv1fBdfaECn0hL7qDZr7i2UQFeocTBBnCXCA9ZF7wuj+4oCuAUncYQxhw8769r
         UC7yH8TFNsbcprsbjXAMKf1aNhfw5qNL351LhERXetErelxmiQAhZ4/1OSsW6GCxvgwV
         tH+kOmmclY+WBme81IHcqR+PWoQFzZzN35BuvZlQE8UQtiCC/gsWpDo0VfDOOPRNmeye
         f4Gw==
X-Gm-Message-State: AOAM532h/U+Gwf1DfwYGV0/uZcX8lWHghNdbsM5ZJKcYoTXXLFzGftr+
	+Mo1/KXAqOETBuufh/jZ64pAY5Y3ZIzllzUmmr8=
X-Google-Smtp-Source: ABdhPJwvuwBQRNRRouqsaPF3MNC/+/Pn6uxNPLuIjscP+b3L0dIi5QIaucDlm6uPNBUT10+02BtVuUMEcNo3IuFPskQ=
X-Received: by 2002:a02:b899:0:b0:328:522b:9417 with SMTP id
 p25-20020a02b899000000b00328522b9417mr627893jam.79.1650065656096; Fri, 15 Apr
 2022 16:34:16 -0700 (PDT)
MIME-Version: 1.0
References: <20220311061123.1883189-1-Penny.Zheng@arm.com> <20220311061123.1883189-3-Penny.Zheng@arm.com>
 <eefa9cf2-a04c-ba8d-74cb-0d2aaa35badb@suse.com> <DU2PR08MB7325265A2356A09AC1DA5FDDF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
In-Reply-To: <DU2PR08MB7325265A2356A09AC1DA5FDDF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
From: Julien Grall <julien.grall@gmail.com>
Date: Fri, 15 Apr 2022 23:34:04 +0000
Message-ID: <CAF3u54AffFUvjz1OJ41LSaMaUOU_QScFSYnztw6bx8w1Ksh8pg@mail.gmail.com>
Subject: Re: [PATCH v1 02/13] xen/arm: introduce a special domain DOMID_SHARED
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>, 
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
	Julien Grall <julien@xen.org>, Penny Zheng <penzhe01@a011292.shanghai.arm.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Wei Chen <Wei.Chen@arm.com>, Wei Liu <wl@xen.org>, nd <nd@arm.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: multipart/alternative; boundary="00000000000049acf205dcb9d97c"

--00000000000049acf205dcb9d97c
Content-Type: text/plain; charset="UTF-8"

Hi Penny,

Sorry for the formatting.

On Fri, 15 Apr 2022 at 09:53, Penny Zheng <Penny.Zheng@arm.com> wrote:

> Hi jan
>
> > -----
> > > +#ifdef CONFIG_STATIC_SHM
> > > +static void __init setup_shared_domain(void) {
> > > +    /*
> > > +     * Initialise our DOMID_SHARED domain.
> > > +     * This domain owns statically shared pages when owner domain is
> not
> > > +     * explicitly defined.
> > > +     */
> > > +    dom_shared = domain_create(DOMID_SHARED, NULL, CDF_directmap);
> > > +    if ( IS_ERR(dom_shared) )
> > > +        panic("Failed to create d[SHARED]: %ld\n",
> > > +PTR_ERR(dom_shared));
> >
> > I don't think this should be a panic - the system ought to be able to
> come up
> > fine, just without actually using this domain. After all this is an
> optional
> > feature which may not actually be used.
> >
> > Also, along the lines of what Stefano has said, this setting up of the
> domain
> > would also better live next to where the other special domains are set
> up. And
> > even if it was to remain here, ...
> >
>
> The reason why I place the setting up here is that DOMID_SHARED needs to
> map
> pre-configured static shared memory in its p2m table, so it must be set up
> after system P2M initialization(setup_virt_paging()).
> setup_system_domains()
> is called before system P2M initialization on xen/arch/arm/setup.c, which
> can't meet the requirement.


AFAIU, DOM_SHARED (or whatever you want to call it) will never run and the
GFN will always be equal to the MFN. So it sounds to me that creating a P2M
is a bit over the top. Instead, we should have a special case in
get_page_from_gfn like we did for DOM_XEN.

Cheers,
-- 
Julien Grall

--00000000000049acf205dcb9d97c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><div dir=3D"auto">Hi Penny,</div><div dir=3D"auto"><br></div><div dir=
=3D"auto">Sorry for the formatting.</div><div><br><div class=3D"gmail_quote=
"></div></div></div><div><div><div class=3D"gmail_quote"><div dir=3D"ltr" c=
lass=3D"gmail_attr">On Fri, 15 Apr 2022 at 09:53, Penny Zheng &lt;<a href=
=3D"mailto:Penny.Zheng@arm.com" target=3D"_blank">Penny.Zheng@arm.com</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;=
border-left-color:rgb(204,204,204)">Hi jan <br>
<br>
&gt; -----<br>
&gt; &gt; +#ifdef CONFIG_STATIC_SHM<br>
&gt; &gt; +static void __init setup_shared_domain(void) {<br>
&gt; &gt; +=C2=A0 =C2=A0 /*<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0* Initialise our DOMID_SHARED domain.<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0* This domain owns statically shared pages w=
hen owner domain is not<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0* explicitly defined.<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0*/<br>
&gt; &gt; +=C2=A0 =C2=A0 dom_shared =3D domain_create(DOMID_SHARED, NULL, C=
DF_directmap);<br>
&gt; &gt; +=C2=A0 =C2=A0 if ( IS_ERR(dom_shared) )<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 panic(&quot;Failed to create d[SHARE=
D]: %ld\n&quot;,<br>
&gt; &gt; +PTR_ERR(dom_shared));<br>
&gt; <br>
&gt; I don&#39;t think this should be a panic - the system ought to be able=
 to come up<br>
&gt; fine, just without actually using this domain. After all this is an op=
tional<br>
&gt; feature which may not actually be used.<br>
&gt; <br>
&gt; Also, along the lines of what Stefano has said, this setting up of the=
 domain<br>
&gt; would also better live next to where the other special domains are set=
 up. And<br>
&gt; even if it was to remain here, ...<br>
&gt; <br>
<br>
The reason why I place the setting up here is that DOMID_SHARED needs to ma=
p<br>
pre-configured static shared memory in its p2m table, so it must be set up<=
br>
after system P2M initialization(setup_virt_paging()). setup_system_domains(=
)<br>
is called before system P2M initialization on xen/arch/arm/setup.c, which<b=
r>
can&#39;t meet the requirement.</blockquote><div dir=3D"auto"><br></div></d=
iv></div></div><div><div><div class=3D"gmail_quote"><div dir=3D"auto">AFAIU=
, DOM_SHARED (or whatever you want to call it) will never run and the GFN w=
ill always be equal to the MFN. So it sounds to me that creating a P2M is a=
 bit over the top. Instead, we should have a special case in get_page_from_=
gfn like we did for DOM_XEN.</div><div dir=3D"auto"><br></div><div dir=3D"a=
uto">Cheers,</div></div></div></div>-- <br><div dir=3D"ltr" class=3D"gmail_=
signature" data-smartmail=3D"gmail_signature">Julien Grall</div>

--00000000000049acf205dcb9d97c--


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 23:42:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 23:42:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305971.521124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVaL-0007n6-Ul; Fri, 15 Apr 2022 23:42:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305971.521124; Fri, 15 Apr 2022 23:42:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVaL-0007mz-R3; Fri, 15 Apr 2022 23:42:41 +0000
Received: by outflank-mailman (input) for mailman id 305971;
 Fri, 15 Apr 2022 23:42:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JP5O=UZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfVaK-0007mt-Ho
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 23:42:40 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bbdc95b0-bd15-11ec-8fbe-03012f2f19d4;
 Sat, 16 Apr 2022 01:42:38 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0CFD3B82FAE;
 Fri, 15 Apr 2022 23:42:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24EFAC385A4;
 Fri, 15 Apr 2022 23:42:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbdc95b0-bd15-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650066156;
	bh=Ov+uoU9Mc5w1Tn66KpXzUke9yX7nZixhdesKNbF7kCs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=LQ9x8WKH7aujfYxbJUYU+3Rq3dJNPtnYYhCddTsFUjmZkvbKpDWVsHlwI9ti1tgw5
	 0+wRL/rYkSPZI7a3bcGPysbWRaLygsZzEDG22EGx94vkPLnoem1umMMzguBxomQ0OM
	 C2uPAhmWrSYqCl1IOpbn0dwO1iKt0eW/TEqug14YsBFl8sI+Q4zkPIm1h462kkwUiY
	 dAo+xLul5RDculs2BENK2fGkdGWnWfq2dWQPyQxoAhFPUk2UT0Z6mR5mmB8Wl76vge
	 aBth8ukmlFWboZ89rRZ2jnlUx3LUhvxSaW9xSM3cXlTW1s/L5cGd1Xc1ba2tVCRH6Z
	 6sQUaclcd8qvQ==
Date: Fri, 15 Apr 2022 16:42:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <bertrand.marquis@arm.com>
cc: xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v2] xen/build: Add cppcheck and cppcheck-html make
 rules
In-Reply-To: <74b35aab0706fc977a3c5c3dfa20b52fda6f4698.1649855186.git.bertrand.marquis@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204151637350.915916@ubuntu-linux-20-04-desktop>
References: <74b35aab0706fc977a3c5c3dfa20b52fda6f4698.1649855186.git.bertrand.marquis@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 13 Apr 2022, Bertrand Marquis wrote:
> cppcheck can be used to check Xen code quality.
> 
> To create a report do "make cppcheck" on a built tree adding any options
> you added during the process you used to build xen (like CROSS_COMPILE
> or XEN_TARGET_ARCH). This will generate an xml report xen-cppcheck.xml.
> 
> To create a html report do "make cppcheck-html" in the same way and a
> full report to be seen in a browser will be generated in
> cppcheck-htmlreport/index.html.
> 
> For better results it is recommended to build your own cppcheck from the
> latest sources that you can find at [1].
> Development and result analysis has been done with cppcheck 2.7.
> 
> The Makefile rule is searching for all C files which have been compiled
> (ie which have a generated .o file) and is running cppcheck on all of
> them using the current configuration of xen so only the code actually
> compiled is checked.
> 
> A new tool is introduced to merge all cppcheck reports into one global
> report including all findings and removing duplicates.
> 
> Some extra variables can be used to customize the report:
> - CPPCHECK can be used to give the full path to the cppcheck binary to
> use (default is to use the one from the standard path).
> - CPPCHECK_HTMLREPORT can be used to give the full path to
> cppcheck-htmlreport (default is to use the one from the standard path).
> 
> This has been tested on several arm configurations (x86 should work but
> has not been tested).
> 
> [1] https://cppcheck.sourceforge.io/
> 
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

This is better, thanks! I don't have a lot of comments as it looks
pretty OK to me already. Only one comment on the python script.


> ---
> Changes in v2:
> - catch parsing errors during merge and tell the user to update cppcheck
> - fix alignments in Makefile
> - use srctree and objtree instead of BASEDIR
> - remove SCTLR invalid change
> - add a check of cppcheck version and mandate version 2.7 or greater
> - rework the merge script to make it faster and display progress
> ---
>  .gitignore                           |  3 +
>  xen/Makefile                         | 84 +++++++++++++++++++++++++++-
>  xen/arch/arm/include/asm/processor.h |  2 +
>  xen/include/xen/config.h             |  4 ++
>  xen/include/xen/kconfig.h            |  5 ++
>  xen/tools/merge_cppcheck_reports.py  | 83 +++++++++++++++++++++++++++
>  6 files changed, 179 insertions(+), 2 deletions(-)
>  create mode 100755 xen/tools/merge_cppcheck_reports.py
> 
> diff --git a/.gitignore b/.gitignore
> index d425be4bd9..0d2d60b8f1 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -7,6 +7,7 @@
>  *.o
>  *.d
>  *.d2
> +*.c.cppcheck
>  *.opic
>  *.a
>  *.so
> @@ -296,6 +297,7 @@ xen/.banner
>  xen/.config
>  xen/.config.old
>  xen/.xen.elf32
> +xen/xen-cppcheck.xml
>  xen/System.map
>  xen/arch/x86/boot/mkelf32
>  xen/arch/x86/boot/cmdline.S
> @@ -316,6 +318,7 @@ xen/arch/*/efi/runtime.c
>  xen/arch/*/include/asm/asm-offsets.h
>  xen/common/config_data.S
>  xen/common/config.gz
> +xen/cppcheck-htmlreport
>  xen/include/headers*.chk
>  xen/include/compat/*
>  xen/include/config/
> diff --git a/xen/Makefile b/xen/Makefile
> index ebc7854c08..734f9f2b4f 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -335,7 +335,7 @@ export CFLAGS_UBSAN
>  
>  endif # need-config
>  
> -main-targets := build install uninstall clean distclean MAP
> +main-targets := build install uninstall clean distclean MAP cppcheck cppcheck-html
>  .PHONY: $(main-targets)
>  ifneq ($(XEN_TARGET_ARCH),x86_32)
>  $(main-targets): %: _% ;
> @@ -423,15 +423,17 @@ _clean:
>  	$(Q)$(MAKE) $(clean)=tools/kconfig
>  	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
>  		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
> -		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
> +		-o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \
>  		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
>  	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map
>  	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
>  	rm -f .banner .allconfig.tmp include/xen/compile.h
> +	rm -f xen-cppcheck.xml
>  
>  .PHONY: _distclean
>  _distclean: clean
>  	rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS .config
> +	rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR)
>  
>  $(TARGET).gz: $(TARGET)
>  	gzip -n -f -9 < $< > $@.new
> @@ -505,6 +507,84 @@ cloc:
>  	    done; \
>  	done | cloc --list-file=-
>  
> +# What cppcheck command to use.
> +# To get proper results, it is recommended to build cppcheck manually from the
> +# latest source and use CPPCHECK to give the full path to the built version.
> +CPPCHECK ?= cppcheck
> +
> +# What cppcheck-htmlreport to use.
> +# If you give the full path to a self compiled cppcheck, this should be set
> +# to the full path to cppcheck-html in the htmlreport directory of cppcheck.
> +# On recent distribution, this is available in the standard path.
> +CPPCHECK_HTMLREPORT ?= cppcheck-htmlreport
> +
> +# By default we generate the report in cppcheck-htmlreport directory in the
> +# build directory. This can be changed by giving a directory in this variable.
> +CPPCHECK_HTMLREPORT_OUTDIR ?= cppcheck-htmlreport
> +
> +# Compile flags to pass to cppcheck:
> +# - include directories and defines Xen Makefile is passing (from CFLAGS)
> +# - include config.h as this is passed directly to the compiler.
> +# - define CPPCHECK as we use to disable or enable some specific part of the
> +#   code to solve some cppcheck issues.
> +# - explicitely enable some cppcheck checks as we do not want to use "all"
> +#   which includes unusedFunction which gives wrong positives as we check file
> +#   per file.
> +#
> +# Compiler defines are in compiler-def.h which is included in config.h
> +#
> +CPPCHECKFLAGS := -DCPPCHECK --max-ctu-depth=10 \
> +                 --enable=style,information,missingInclude \
> +                 --include=$(srctree)/include/xen/config.h \
> +                 -I $(srctree)/xsm/flask/include \
> +                 -I $(srctree)/include/xen/libfdt \
> +                 $(filter -D% -I%,$(CFLAGS))
> +
> +# We need to find all C files (as we are not checking assembly files) so
> +# we find all generated .o files which have a .c corresponding file.
> +CPPCHECKFILES := $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c, \
> +                 $(filter-out $(objtree)/tools/%, \
> +                 $(shell find $(objtree) -name "*.o"))))
> +
> +quiet_cmd_cppcheck_xml = CPPCHECK $(patsubst $(srctree)/%,%,$<)
> +cmd_cppcheck_xml = $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \
> +                   --output-file=$@ $<
> +
> +quiet_cmd_merge_cppcheck_reports = CPPCHECK-MERGE $@
> +cmd_merge_cppcheck_reports = $(srctree)/tools/merge_cppcheck_reports.py $^ $@
> +
> +quiet_cmd_cppcheck_html = CPPCHECK-HTML $<
> +cmd_cppcheck_html = $(CPPCHECK_HTMLREPORT) --file=$< --source-dir=$(srctree) \
> +                    --report-dir=$(CPPCHECK_HTMLREPORT_OUTDIR) --title=Xen
> +
> +PHONY += _cppcheck _cppcheck-html cppcheck-version
> +
> +_cppcheck-html: xen-cppcheck.xml
> +	$(call if_changed,cppcheck_html)
> +
> +_cppcheck: xen-cppcheck.xml
> +
> +xen-cppcheck.xml: $(patsubst $(srctree)/%.c,$(objtree)/%.c.cppcheck,$(CPPCHECKFILES))
> +ifeq ($(CPPCHECKFILES),)
> +	$(error Please build Xen before running cppcheck)
> +endif
> +	$(call if_changed,merge_cppcheck_reports)
> +
> +$(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h $(objtree)/include/generated/compiler-def.h | cppcheck-version
> +	$(call if_changed,cppcheck_xml)
> +
> +cppcheck-version:
> +ifeq ($(shell which $(CPPCHECK)),)
> +	$(error Cannot find cppcheck executable: $(CPPCHECK))
> +endif
> +ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1)
> +	$(error Please upgrade your cppcheck to version 2.7 or greater)
> +endif
> +
> +# Put this in generated headers this way it is cleaned by include/Makefile
> +$(objtree)/include/generated/compiler-def.h:
> +	$(Q)$(CC) -dM -E -o $@ - < /dev/null
> +
>  endif #config-build
>  
>  PHONY += FORCE
> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
> index 852b5f3c24..ef37cfa16f 100644
> --- a/xen/arch/arm/include/asm/processor.h
> +++ b/xen/arch/arm/include/asm/processor.h
> @@ -219,9 +219,11 @@
>                           SCTLR_Axx_ELx_A    | SCTLR_Axx_ELx_C   |\
>                           SCTLR_Axx_ELx_WXN  | SCTLR_Axx_ELx_EE)
>  
> +#ifndef CPPCHECK
>  #if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xffffffffffffffffUL
>  #error "Inconsistent SCTLR_EL2 set/clear bits"
>  #endif
> +#endif
>  
>  #endif
>  
> diff --git a/xen/include/xen/config.h b/xen/include/xen/config.h
> index 85c6f59be9..d888b2314d 100644
> --- a/xen/include/xen/config.h
> +++ b/xen/include/xen/config.h
> @@ -7,6 +7,10 @@
>  #ifndef __XEN_CONFIG_H__
>  #define __XEN_CONFIG_H__
>  
> +#ifdef CPPCHECK
> +#include <generated/compiler-def.h>
> +#endif
> +
>  #include <xen/kconfig.h>
>  
>  #ifndef __ASSEMBLY__
> diff --git a/xen/include/xen/kconfig.h b/xen/include/xen/kconfig.h
> index 4d58c5bb3c..a717b0819c 100644
> --- a/xen/include/xen/kconfig.h
> +++ b/xen/include/xen/kconfig.h
> @@ -8,6 +8,10 @@
>   * these only work with boolean option.
>   */
>  
> +/* cppcheck is failing to parse the macro so use a dummy one */
> +#ifdef CPPCHECK
> +#define IS_ENABLED(option) option
> +#else
>  /*
>   * Getting something that works in C and CPP for an arg that may or may
>   * not be defined is tricky.  Here, if we have "#define CONFIG_BOOGER 1"
> @@ -27,5 +31,6 @@
>   * otherwise.
>   */
>  #define IS_ENABLED(option) config_enabled(option)
> +#endif
>  
>  #endif /* __XEN_KCONFIG_H */
> diff --git a/xen/tools/merge_cppcheck_reports.py b/xen/tools/merge_cppcheck_reports.py
> new file mode 100755
> index 0000000000..eabf558768
> --- /dev/null
> +++ b/xen/tools/merge_cppcheck_reports.py
> @@ -0,0 +1,83 @@
> +#!/usr/bin/env python
> +
> +"""
> +This script acts as a tool to merge XML files created by cppcheck.
> +Usage:
> +    merge_cppcheck_reports.py [FILES] [OUTPUT]
> +
> +    FILES  - list of XML files with extension .cppcheck
> +    OUTPUT - file to store results (with .xml extension).
> +             If not specified, the script will print results to stdout.
> +"""
> +
> +import sys
> +from xml.etree import ElementTree
> +
> +def elements_equal(el1, el2):
> +    if type(el1) != type(el2): return False
> +
> +    el1_location = str(el1.find('location').attrib)
> +    el2_location = str(el2.find('location').attrib)

I managed to repro another stacktrace:

  CPPCHECK-MERGE xen-cppcheck.xml
 123 / 191Traceback (most recent call last):
  File "./tools/merge_cppcheck_reports.py", line 83, in <module>
    run()
  File "./tools/merge_cppcheck_reports.py", line 72, in run
    result = merge(files)
  File "./tools/merge_cppcheck_reports.py", line 53, in merge
    if not contain_element(xml_error_elem, curr_elem_list):
  File "./tools/merge_cppcheck_reports.py", line 28, in contain_element
    if elements_equal(new, elem):
  File "./tools/merge_cppcheck_reports.py", line 19, in elements_equal
    el1_location = str(el1.find('location').attrib)
AttributeError: 'NoneType' object has no attribute 'attrib'
make: *** [Makefile:685: xen-cppcheck.xml] Error 1

It must be a natural talent :-)

Should we have a try/except also here as well?

FYI I added:

    if el1.find('location') is None: return False
    if el2.find('location') is None: return False

And that solved the issue for me


> +    if el1_location != el2_location: return False
> +
> +    return True
> +
> +def contain_element(new, lst):
> +    for elem in lst:
> +        if elements_equal(new, elem):
> +            return True
> +    return False
> +
> +def merge(files):
> +    try:
> +        result_xml_root = ElementTree.parse(files[0]).getroot()
> +    except ParseError:
> +        print("Xml parsing error in %s\n" % (files[0]))
> +        print("Please upgrade your cppcheck to version 2.7 or greater")
> +        sys.exit(1)
> +    insert_point = result_xml_root.findall("errors")[0]
> +    curr = 1
> +    total = len(files)
> +    numelem = len(insert_point)
> +    for xml_file in files[1:]:
> +        try:
> +            xml_root = ElementTree.parse(xml_file).getroot()
> +        except ParseError:
> +            print("Xml parsing error in %s\n" % (xml_file))
> +            print("Please upgrade your cppcheck to version 2.7 or greater")
> +            sys.exit(1)
> +        curr_elem_list = list(insert_point)
> +        new_elem_list = list(xml_root.findall("errors")[0])
> +        for xml_error_elem in new_elem_list:
> +            if not contain_element(xml_error_elem, curr_elem_list):
> +                insert_point.insert(1,xml_error_elem)
> +                numelem = numelem + 1
> +        curr = curr + 1
> +        sys.stdout.write('\r')
> +        sys.stdout.write(" %d / %d" % (curr,total))
> +        sys.stdout.flush()
> +
> +    sys.stdout.write('\r\n')
> +    print("Done: %d elements" % (numelem))
> +    return result_xml_root
> +
> +def run():
> +    files = []
> +    output = None
> +    for i in sys.argv[1:]:
> +        output = i if '.xml' in i else None
> +        files.append(i) if '.cppcheck' in i else None
> +
> +    result = merge(files)
> +
> +    if result is None:
> +        return
> +
> +    if output is not None:
> +        ElementTree.ElementTree(result).write(output)
> +    else:
> +        print(ElementTree.tostring(result).decode('utf-8'))
> +
> +if __name__ == '__main__':
> +    run()
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 23:45:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 23:45:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305977.521134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVdI-0008Sj-F2; Fri, 15 Apr 2022 23:45:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305977.521134; Fri, 15 Apr 2022 23:45:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVdI-0008Sc-CA; Fri, 15 Apr 2022 23:45:44 +0000
Received: by outflank-mailman (input) for mailman id 305977;
 Fri, 15 Apr 2022 23:45:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6WtN=UZ=gmail.com=julien.grall@srs-se1.protection.inumbo.net>)
 id 1nfVdH-0008SU-Gk
 for xen-devel@lists.xenproject.org; Fri, 15 Apr 2022 23:45:43 +0000
Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com
 [2607:f8b0:4864:20::12b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28c8ccb0-bd16-11ec-8fbe-03012f2f19d4;
 Sat, 16 Apr 2022 01:45:42 +0200 (CEST)
Received: by mail-il1-x12b.google.com with SMTP id r11so5587085ila.1
 for <xen-devel@lists.xenproject.org>; Fri, 15 Apr 2022 16:45:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28c8ccb0-bd16-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Whatm5yIxNGgA/0xJCvQkgGDKdJIiTfGm5E24y+lywE=;
        b=qjhN6EmDK8JYzzB0h95JndTPrKZWIZ34kSvOJ3ZYAwS+AE+Jkr8kTkGlnBrrXm9Adg
         Xoa+BS40pMly5WaWhJB3gI4+VZdqo2Vqm+WgE0ztl7pNdRaY0XyQXNpW1DwY7zaGFSn7
         lBe+TjGYXFkBKo4UHF/xBx4N+lMgjpR++/Hnwd2i5nCnE9GofIdq9IoaIJ+OpBuSRaAV
         D0aDt30cTxlhYWWUPYI4GFwYPRZa/qIr6dWsC8GOT33DrZzjGw97aTd78ezuxud54Xo6
         URGWpXtbdaf+PXaKDdxSicUFMO5qEl9o7FTVfg+1z20mILOWTzFizs+z+XV76vuMzOmj
         IQYA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Whatm5yIxNGgA/0xJCvQkgGDKdJIiTfGm5E24y+lywE=;
        b=ZD6ACaUB1EifN0C/85ODIaAeg8KrchVQRrpiQLvg4witM/4KEIvPqurPmBL94C5lYg
         Mo+Umsv9fqvepU/+1d+CQV+mV8Hv/FcLebwAo6oVDSe3MHXAiMJwVAqGPDJAgAgPv6vt
         oOD8afJH8E8r3iysHS7XOEv9iaTxhHAwli9tdW0cZ6kdUwcUTu4uKaXkwBSDdJIfV7Q/
         JEfHSrP18UPlOBs45sKgYXE0aSE0oiwtXSm+0IC3lSl0BNDmT1OjuK+hIq4boxL/ZFMm
         OYY7Ti2POko8ekFQnkK+Qs254hEiB9Kfp6oHCK85yt0HHR7vuRxK1XSmHJXcT3fvQtrz
         SWYw==
X-Gm-Message-State: AOAM530sAQMBFA9xVEDSrnDKXCUOghzKMs86J1SA98Tlw3T2shp2hOyv
	LSZ9MNDHr48rVZNT8+s4dX2ySRxZ4oCqoiwVXI4=
X-Google-Smtp-Source: ABdhPJy8GAnfvKOABU1JAIHlWVNQOx834WVOABoUoFjyHkXBLQb8+J2Wx28YfV0e0Tqi+2f8Sh/BX7IDAWRMQJXIhtI=
X-Received: by 2002:a05:6e02:12ce:b0:2ca:3c80:3abc with SMTP id
 i14-20020a056e0212ce00b002ca3c803abcmr461394ilm.47.1650066340766; Fri, 15 Apr
 2022 16:45:40 -0700 (PDT)
MIME-Version: 1.0
References: <20220311061123.1883189-1-Penny.Zheng@arm.com> <20220311061123.1883189-3-Penny.Zheng@arm.com>
 <eefa9cf2-a04c-ba8d-74cb-0d2aaa35badb@suse.com> <alpine.DEB.2.22.394.2203181443440.2910984@ubuntu-linux-20-04-desktop>
 <30a6ef6f-d37c-b66c-d5af-be2208766057@suse.com> <alpine.DEB.2.22.394.2203211256370.2910984@ubuntu-linux-20-04-desktop>
 <f8627956-8b01-6a5d-d69a-d2da16d74726@xen.org> <DU2PR08MB7325F469140EFE83F2F8F91DF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204151506520.915916@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2204151506520.915916@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien.grall@gmail.com>
Date: Fri, 15 Apr 2022 23:45:29 +0000
Message-ID: <CAF3u54AC1QRrGgPWDYjeb5xyuXhpF5GsHh5WFPxr=9XCKe1fCg@mail.gmail.com>
Subject: Re: [PATCH v1 02/13] xen/arm: introduce a special domain DOMID_SHARED
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>, 
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
	Julien Grall <julien@xen.org>, Penny Zheng <penzhe01@a011292.shanghai.arm.com>, 
	Penny Zheng <Penny.Zheng@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Wei Chen <Wei.Chen@arm.com>, Wei Liu <wl@xen.org>, nd <nd@arm.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: multipart/alternative; boundary="00000000000018e86605dcba0279"

--00000000000018e86605dcba0279
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 15 Apr 2022 at 22:19, Stefano Stabellini <sstabellini@kernel.org>
wrote:

> On Fri, 15 Apr 2022, Penny Zheng wrote:
> > > Hi Stefano,
> > >
> > > On 21/03/2022 20:03, Stefano Stabellini wrote:
> > > > On Mon, 21 Mar 2022, Jan Beulich wrote:
> > > >> On 18.03.2022 22:50, Stefano Stabellini wrote:
> > > >>> On Fri, 18 Mar 2022, Jan Beulich wrote:
> > > >>>> On 11.03.2022 07:11, Penny Zheng wrote:
> > > >>>>> In case to own statically shared pages when owner domain is not
> > > >>>>> explicitly defined, this commits propose a special domain
> > > >>>>> DOMID_SHARED, and we assign it 0x7FF5, as one of the system
> domains.
> > > >>>>>
> > > >>>>> Statically shared memory reuses the same way of initialization
> > > >>>>> with static memory, hence this commits proposes a new Kconfig
> > > >>>>> CONFIG_STATIC_SHM to wrap related codes, and this option depend=
s
> > > on static memory(CONFIG_STATIC_MEMORY).
> > > >>>>>
> > > >>>>> We intends to do shared domain creation after setup_virt_paging
> so
> > > >>>>> shared domain could successfully do p2m initialization.
> > > >>>>
> > > >>>> There's nothing said here, in the earlier patch, or in the cover
> > > >>>> letter about the security aspects of this. There is a reason we
> > > >>>> haven't been allowing arbitrary, un-supervised sharing of memory
> > > >>>> between domains. It wants clarifying why e.g. grants aren't an
> > > >>>> option to achieve what you need, and how you mean to establish
> > > >>>> which domains are / aren't permitted to access any individual pa=
ge
> > > owned by this domain.
> > > >>>
> > > >>>
> > > >>> I'll let Penny write a full reply but I'll chime in to try to hel=
p
> > > >>> with the explanation.
> > > >>>
> > > >>> This is not arbitrary un-supervised sharing of memory between
> > > >>> domains, which indeed is concerning.
> > > >>>
> > > >>> This is statically-configured, supervised by the system
> > > >>> configurator, sharing of memory between domains.
> > > >>>
> > > >>> And in fact safety (which is just a different aspect of security)
> is
> > > >>> one of the primary goals for this work.
> > > >>>
> > > >>> In safety-critical environments, it is not considered safe to
> > > >>> dynamically change important configurations at runtime. Everythin=
g
> > > >>> should be statically defined and statically verified.
> > > >>>
> > > >>> In this case, if the system configuration knows a priori that the=
re
> > > >>> are only 2 VM and they need to communication over shared memory, =
it
> > > >>> is safer to pre-configure the shared memory at build time rather
> > > >>> than let the VMs attempt to share memory at runtime. It is faster
> too.
> > > >>>
> > > >>> The only way to trigger this static shared memory configuration
> > > >>> should be via device tree, which is at the same level as the XSM
> > > >>> rules themselves.
> > > >>>
> > > >>> Hopefully I made things clearer and not murkier :-)
> > > >>
> > > >> It adds some helpful background, yes, but at the same time it
> doesn't
> > > >> address the security concern at all: How are access permissions
> > > >> managed when the owning domain is a special one? I haven't spotted
> > > >> any recording of the domains which are actually permitted to map /
> > > >> access the pages in questions. (But of course I also only looked a=
t
> > > >> non-Arm-specific code. I'd expect such code not to live in arch-
> > > >> specific files.)
> > > >
> > > > All this static memory sharing is statically done at __init time
> only.
> > > > It should not be possible to trigger any further memory sharing at
> > > > runtime (if there is, that would be a bug).
> > >
> > > Looking at the code, get_pg_owner() will be able to handle
> DOMID_SHARED.
> > > So anyone that is permitted to access DOMID_SHARED will be able to ma=
p
> any
> > > memory region at runtime.
> > >
> > > > There are no new interfaces for the guest to map this memory becaus=
e
> > > > it is already "pre-mapped".
> > >
> > > It can via XENMAPSPACE_gmfn_foreign (assuming proper permission).
> > >
> >
> > Correct me if I'm wrong:
> > The existing XENMAPSPACE_gmfn_foreign only allows privileged Dom0 to ma=
p
> > memory pages from one foreign DomU to itself. So It can happen that Dom=
0
> is
> > using XENMAPSPACE_gmfn_foreign to (maliciously?) access shared memory
> owned
> > by DOMID_SHARED, and for now only Dom0 could.
>
> No, currently there is no protection against dom0 doing malicious
> operations. Dom0 can poweroff the entire system.


This is the classic argument=E2=80=A6 Yes, on a default setup, dom0 is full=
y
trusted today. However there are way to reduce the trust via XSM.

For new interfaces we should also try to avoid  considering dom0 as fully
trusted whenever it is possible. This is one of the example where I think
this should be done. The more if we use DOMID_IO as we may add more than
shared pages there=E2=80=A6


>
> If we are certain that only dom0 (and not other domains) can use
> XENMAPSPACE_gmfn_foreign to access shared memory owned by DOMID_SHARED
> then we are good. Looking at the code, and also considering that we have
> agreed to move to DOMID_IO, get_pg_owner can already handle DOMID_IO.


AFAIK, dom0 cannot map DOMID_IO page for now because get_page_from_gfn
would not work. This would change with this approach.


>
> Next is the xsm_map_gmfn_foreign(XSM_TARGET, d, od) check, which would
> fail unless the asking domain is privileged over the target domain.
> xsm_map_gmfn_foreign would fail for all domains except dom0.


This depends your XSM policy. In this case, think we need to prevent
runtime mapping via the hypercall interface. We can relax it afterwards if
we have use cases for it.


>
> So I think we are OK. I don't think we need to do anything else.



Cheers,
--=20
Julien Grall

--00000000000018e86605dcba0279
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hi,</div><div><br><div class=3D"gmail_quote"><div dir=3D"=
ltr" class=3D"gmail_attr">On Fri, 15 Apr 2022 at 22:19, Stefano Stabellini =
&lt;<a href=3D"mailto:sstabellini@kernel.org">sstabellini@kernel.org</a>&gt=
; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;b=
order-left-color:rgb(204,204,204)">On Fri, 15 Apr 2022, Penny Zheng wrote:<=
br>
&gt; &gt; Hi Stefano,<br>
&gt; &gt; <br>
&gt; &gt; On 21/03/2022 20:03, Stefano Stabellini wrote:<br>
&gt; &gt; &gt; On Mon, 21 Mar 2022, Jan Beulich wrote:<br>
&gt; &gt; &gt;&gt; On 18.03.2022 22:50, Stefano Stabellini wrote:<br>
&gt; &gt; &gt;&gt;&gt; On Fri, 18 Mar 2022, Jan Beulich wrote:<br>
&gt; &gt; &gt;&gt;&gt;&gt; On 11.03.2022 07:11, Penny Zheng wrote:<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt; In case to own statically shared pages when =
owner domain is not<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt; explicitly defined, this commits propose a s=
pecial domain<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt; DOMID_SHARED, and we assign it 0x7FF5, as on=
e of the system domains.<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt; Statically shared memory reuses the same way=
 of initialization<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt; with static memory, hence this commits propo=
ses a new Kconfig<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt; CONFIG_STATIC_SHM to wrap related codes, and=
 this option depends<br>
&gt; &gt; on static memory(CONFIG_STATIC_MEMORY).<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt; We intends to do shared domain creation afte=
r setup_virt_paging so<br>
&gt; &gt; &gt;&gt;&gt;&gt;&gt; shared domain could successfully do p2m init=
ialization.<br>
&gt; &gt; &gt;&gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt;&gt; There&#39;s nothing said here, in the earlier pa=
tch, or in the cover<br>
&gt; &gt; &gt;&gt;&gt;&gt; letter about the security aspects of this. There=
 is a reason we<br>
&gt; &gt; &gt;&gt;&gt;&gt; haven&#39;t been allowing arbitrary, un-supervis=
ed sharing of memory<br>
&gt; &gt; &gt;&gt;&gt;&gt; between domains. It wants clarifying why e.g. gr=
ants aren&#39;t an<br>
&gt; &gt; &gt;&gt;&gt;&gt; option to achieve what you need, and how you mea=
n to establish<br>
&gt; &gt; &gt;&gt;&gt;&gt; which domains are / aren&#39;t permitted to acce=
ss any individual page<br>
&gt; &gt; owned by this domain.<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt; I&#39;ll let Penny write a full reply but I&#39;ll c=
hime in to try to help<br>
&gt; &gt; &gt;&gt;&gt; with the explanation.<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt; This is not arbitrary un-supervised sharing of memor=
y between<br>
&gt; &gt; &gt;&gt;&gt; domains, which indeed is concerning.<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt; This is statically-configured, supervised by the sys=
tem<br>
&gt; &gt; &gt;&gt;&gt; configurator, sharing of memory between domains.<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt; And in fact safety (which is just a different aspect=
 of security) is<br>
&gt; &gt; &gt;&gt;&gt; one of the primary goals for this work.<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt; In safety-critical environments, it is not considere=
d safe to<br>
&gt; &gt; &gt;&gt;&gt; dynamically change important configurations at runti=
me. Everything<br>
&gt; &gt; &gt;&gt;&gt; should be statically defined and statically verified=
.<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt; In this case, if the system configuration knows a pr=
iori that there<br>
&gt; &gt; &gt;&gt;&gt; are only 2 VM and they need to communication over sh=
ared memory, it<br>
&gt; &gt; &gt;&gt;&gt; is safer to pre-configure the shared memory at build=
 time rather<br>
&gt; &gt; &gt;&gt;&gt; than let the VMs attempt to share memory at runtime.=
 It is faster too.<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt; The only way to trigger this static shared memory co=
nfiguration<br>
&gt; &gt; &gt;&gt;&gt; should be via device tree, which is at the same leve=
l as the XSM<br>
&gt; &gt; &gt;&gt;&gt; rules themselves.<br>
&gt; &gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt;&gt; Hopefully I made things clearer and not murkier :-)<=
br>
&gt; &gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; It adds some helpful background, yes, but at the same ti=
me it doesn&#39;t<br>
&gt; &gt; &gt;&gt; address the security concern at all: How are access perm=
issions<br>
&gt; &gt; &gt;&gt; managed when the owning domain is a special one? I haven=
&#39;t spotted<br>
&gt; &gt; &gt;&gt; any recording of the domains which are actually permitte=
d to map /<br>
&gt; &gt; &gt;&gt; access the pages in questions. (But of course I also onl=
y looked at<br>
&gt; &gt; &gt;&gt; non-Arm-specific code. I&#39;d expect such code not to l=
ive in arch-<br>
&gt; &gt; &gt;&gt; specific files.)<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; All this static memory sharing is statically done at __init =
time only.<br>
&gt; &gt; &gt; It should not be possible to trigger any further memory shar=
ing at<br>
&gt; &gt; &gt; runtime (if there is, that would be a bug).<br>
&gt; &gt; <br>
&gt; &gt; Looking at the code, get_pg_owner() will be able to handle DOMID_=
SHARED.<br>
&gt; &gt; So anyone that is permitted to access DOMID_SHARED will be able t=
o map any<br>
&gt; &gt; memory region at runtime.<br>
&gt; &gt; <br>
&gt; &gt; &gt; There are no new interfaces for the guest to map this memory=
 because<br>
&gt; &gt; &gt; it is already &quot;pre-mapped&quot;.<br>
&gt; &gt; <br>
&gt; &gt; It can via XENMAPSPACE_gmfn_foreign (assuming proper permission).=
<br>
&gt; &gt; <br>
&gt; <br>
&gt; Correct me if I&#39;m wrong:<br>
&gt; The existing XENMAPSPACE_gmfn_foreign only allows privileged Dom0 to m=
ap<br>
&gt; memory pages from one foreign DomU to itself. So It can happen that Do=
m0 is<br>
&gt; using XENMAPSPACE_gmfn_foreign to (maliciously?) access shared memory =
owned<br>
&gt; by DOMID_SHARED, and for now only Dom0 could.<br>
<br>
No, currently there is no protection against dom0 doing malicious<br>
operations. Dom0 can poweroff the entire system.</blockquote><div dir=3D"au=
to"><br></div><div dir=3D"auto">This is the classic argument=E2=80=A6 Yes, =
on a default setup, dom0 is fully trusted today. However there are way to r=
educe the trust via XSM.</div><div dir=3D"auto"><br></div><div dir=3D"auto"=
>For new interfaces we should also try to avoid =C2=A0considering dom0 as f=
ully trusted whenever it is possible. This is one of the example where I th=
ink this should be done. The more if we use DOMID_IO as we may add more tha=
n shared pages there=E2=80=A6</div><div dir=3D"auto"><br></div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1=
px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,2=
04)" dir=3D"auto"><br>
<br>
If we are certain that only dom0 (and not other domains) can use<br>
XENMAPSPACE_gmfn_foreign to access shared memory owned by DOMID_SHARED<br>
then we are good. Looking at the code, and also considering that we have<br=
>
agreed to move to DOMID_IO, get_pg_owner can already handle DOMID_IO.</bloc=
kquote><div dir=3D"auto"><br></div><div dir=3D"auto"><span style=3D"border-=
color:rgb(0,0,0);color:rgb(0,0,0)">AFAIK, dom0 cannot map DOMID_IO page for=
 now because get_page_from_gfn would not work. This would change with this =
approach.</span><br></div><div dir=3D"auto"><br></div><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border=
-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)" dir=
=3D"auto"></blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:=
1ex;border-left-color:rgb(204,204,204)" dir=3D"auto"><br>
<br>
Next is the xsm_map_gmfn_foreign(XSM_TARGET, d, od) check, which would<br>
fail unless the asking domain is privileged over the target domain.<br>
xsm_map_gmfn_foreign would fail for all domains except dom0.</blockquote><d=
iv dir=3D"auto"><br></div><div dir=3D"auto">This depends your XSM policy. I=
n this case, think we need to prevent runtime mapping via the hypercall int=
erface. We can relax it afterwards if we have use cases for it.<br></div><d=
iv dir=3D"auto"><br></div><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-le=
ft:1ex;border-left-color:rgb(204,204,204)" dir=3D"auto"><br>
<br>
So I think we are OK. I don&#39;t think we need to do anything else.</block=
quote><div dir=3D"auto"><br></div><div dir=3D"auto"><br></div><div dir=3D"a=
uto">Cheers,</div></div></div>-- <br><div dir=3D"ltr" class=3D"gmail_signat=
ure" data-smartmail=3D"gmail_signature">Julien Grall</div>

--00000000000018e86605dcba0279--


From xen-devel-bounces@lists.xenproject.org Fri Apr 15 23:59:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Apr 2022 23:59:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305982.521146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVqb-0001bG-Lv; Fri, 15 Apr 2022 23:59:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305982.521146; Fri, 15 Apr 2022 23:59:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfVqb-0001b9-J8; Fri, 15 Apr 2022 23:59:29 +0000
Received: by outflank-mailman (input) for mailman id 305982;
 Fri, 15 Apr 2022 23:59:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfVqa-0001az-Hb; Fri, 15 Apr 2022 23:59:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfVqa-0006V8-CR; Fri, 15 Apr 2022 23:59:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfVqa-0004jt-47; Fri, 15 Apr 2022 23:59:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfVqa-0006kN-3e; Fri, 15 Apr 2022 23:59:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8e8szTwd5Cd0/QPjzOakQvAV7h1lc+VlYyMtmr2OkYQ=; b=2AJq1j3v7dKRybNst0lSprhpl0
	WSV2qHXeFMEbwjE+A4ZOz2N6yWcAfg1wn2ikbdAFQ+oiVl/unxdcqgAdvjicwVvJg7iJ1DPy7UjM1
	o6FMjM5Wg+qDQh3IeKMEdIJrmvzqZgr0bOs0R1LoZzJbLrhUCmo+7KCpnYIAB7iV8Z58=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169439-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169439: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Apr 2022 23:59:28 +0000

flight 169439 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169439/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  423 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   21 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 00:15:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 00:15:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305992.521156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfW5n-0004bx-9J; Sat, 16 Apr 2022 00:15:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305992.521156; Sat, 16 Apr 2022 00:15:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfW5n-0004bq-6V; Sat, 16 Apr 2022 00:15:11 +0000
Received: by outflank-mailman (input) for mailman id 305992;
 Sat, 16 Apr 2022 00:15:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ijIa=U2=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfW5l-0004bk-6c
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 00:15:09 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 444da34f-bd1a-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 02:15:07 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 0B24C622CA;
 Sat, 16 Apr 2022 00:15:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02A5EC385A5;
 Sat, 16 Apr 2022 00:15:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 444da34f-bd1a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650068104;
	bh=RMCqUIyu+8cc8+ChZ/FDO02YYsUXmU0lQ+m6Z7MF/Zo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=S1ei9TslvEm1hbhqkxfWBr7y2oW8uKYxCqaRVwvVQBT/+K3aEtk0jQntdmWMgu1p4
	 138Jct3Jv2/+YpI0fd4vLA/CDU7RMlYVxOkNjLsuzRhHVgFQOdza9536oRBxSMLAz2
	 73iV4CgVBS5Pr9N3qFCzjFDE+7xTaiz1+w+VKBSbXI7XUbo+caCx6XN5TIOTa3UGrd
	 ipvKVC3d0nV4ALSbtdYP6NqqirCUAD4jTvaEchKK1NKBYoPNBvYazAM8gdGn6NH5Ex
	 ZXTQKQPyu3jrl8P/wq2fArgxvJgYAx2aAALdjfZRVPL0oMMU2x+YMJjFAGv9Ljrgp6
	 QYRcyEbTKyb+g==
Date: Fri, 15 Apr 2022 17:15:03 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, cardoe@cardoe.com, wl@xen.org, 
    andrew.cooper3@citrix.com, anthony.perard@citrix.com, 
    bertrand.marquis@arm.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v4 2/2] gitlab-ci: add an ARM32 qemu-based smoke test
In-Reply-To: <49c9d0b5-308c-59ea-cd7a-4d369156ffed@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204151714250.915916@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2203221337230.2910984@ubuntu-linux-20-04-desktop> <20220322203854.420940-2-sstabellini@kernel.org> <49c9d0b5-308c-59ea-cd7a-4d369156ffed@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 23 Mar 2022, Michal Orzel wrote:
> Hi Stefano,

Hi Michal,

I addressed both points below. Sorry for taking so long but the CI-loop
was blocked on ARM. Now it is running again.



> On 22.03.2022 21:38, Stefano Stabellini wrote:
> > Add a minimal ARM32 smoke test based on qemu-system-arm, as provided by
> > the test-artifacts qemu container. The minimal test simply boots Xen
> > (built from previous build stages) and Dom0.
> > 
> > The test needs a working kernel and minimal initrd for dom0. Instead of
> > building our own kernel and initrd, which would mean maintaining one or
> > two more builting scripts under automation/, we borrow a kernel and
> > initrd from distros.
> > 
> > For the kernel we pick the Debian Bullseye kernel, which has everything
> > we need already built-in. However, we cannot use the Debian Bullseye
> > initrd because it is 22MB and the large size causes QEMU to core dump.
> > 
> > Instead, use the tiny busybox-based rootfs provided by Alpine Linux,
> > which is really minimal: just 2.5MB. Note that we cannot use the Alpine
> > Linux kernel because that doesn't boot on Xen.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > ---
> > Changes in v4:
> > - improve commit message
> > - use Debian Bullseye kernel
> > - use Alpine Linux initrd
> > ---
> >  automation/gitlab-ci/test.yaml         | 23 ++++++++
> >  automation/scripts/qemu-smoke-arm32.sh | 81 ++++++++++++++++++++++++++
> >  2 files changed, 104 insertions(+)
> >  create mode 100755 automation/scripts/qemu-smoke-arm32.sh
> > 
> > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> > index ec2a2e1607..42cd725a12 100644
> > --- a/automation/gitlab-ci/test.yaml
> > +++ b/automation/gitlab-ci/test.yaml
> > @@ -95,6 +95,29 @@ qemu-smoke-arm64-gcc:
> >      - /^coverity-tested\/.*/
> >      - /^stable-.*/
> >  
> > +qemu-smoke-arm32-gcc:
> > +  stage: test
> > +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> > +  variables:
> > +    CONTAINER: debian:unstable-arm64v8
> > +  script:
> > +    - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
> > +  dependencies:
> > +    - debian-unstable-gcc-arm32
> > +    - qemu-system-aarch64-6.0.0-arm32-export
> > +  artifacts:
> > +    paths:
> > +      - smoke.serial
> > +      - '*.log'
> > +    when: always
> > +  tags:
> > +    - arm64
> > +  except:
> > +    - master
> > +    - smoke
> > +    - /^coverity-tested\/.*/
> > +    - /^stable-.*/
> > +
> >  qemu-smoke-x86-64-gcc:
> >    stage: test
> >    image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> > diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh
> > new file mode 100755
> > index 0000000000..d554de7939
> > --- /dev/null
> > +++ b/automation/scripts/qemu-smoke-arm32.sh
> > @@ -0,0 +1,81 @@
> > +#!/bin/bash
> > +
> > +set -ex
> > +
> > +export DEBIAN_FRONTENT=noninteractive
> > +apt-get -qy update
> > +apt-get -qy install --no-install-recommends device-tree-compiler \
> > +                                            curl \
> > +                                            cpio
> > +
> > +cd binaries
> > +# Use the kernel from Debian
> > +curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz
> > +# Use a tiny initrd based on busybox from Alpine Linux
> > +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz
> > +
> > +mkdir rootfs
> > +cd rootfs
> > +tar xvzf ../initrd.tar.gz
> > +find . | cpio -H newc -o | gzip > ../initrd.gz
> > +cd ..
> > +
> > +kernel=`stat -L --printf="%s" vmlinuz`
> > +initrd=`stat -L --printf="%s" initrd.gz`
> > +
> > +# For Xen, we need a couple of more node. Dump the DT from QEMU and add them
> > +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded
> > +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom
> > +./qemu-system-arm \
> > +   -machine virt-6.0 \
> Can't we just use "virt" as an alias to the latest virt machine available?
> 
> > +   -machine virtualization=true \
> > +   -smp 4 \
> > +   -m 1024 \
> > +   -serial stdio \
> > +   -monitor none \
> > +   -display none \
> > +   -machine dumpdtb=virt.dtb
> > +
> > +dtc -I dtb -O dts virt.dtb > virt.dts
> > +
> > +cat >> virt.dts << EOF
> > +/ {
> > +	chosen {
> > +		#address-cells = <0x2>;
> > +		#size-cells = <0x2>;
> > +		stdout-path = "/pl011@9000000";
> > +        xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0";
> > +		xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh init=/bin/sh";
> As you are using initrd, rdinit is the correct option.
> Specyfing both rdinit and init does not make a lot of sense as the kernel won't reach init= parsing.
> 
> > +		dom0 {
> > +			compatible = "xen,linux-zimage", "xen,multiboot-module";
> > +			reg = <0x0 0x1000000 0x0 $kernel>;
> > +		};
> > +        dom0-ramdisk {
> > +			compatible = "xen,linux-initrd", "xen,multiboot-module";
> > +			reg = <0x0 0x3200000 0x0 $initrd>;
> > +		};
> > +	};
> > +};
> > +EOF
> > +dtc -I dts -O dtb virt.dts > virt.dtb
> > +
> > +rm -f smoke.serial
> > +set +e
> > +timeout -k 1 240 \
> > +./qemu-system-arm \
> > +   -machine virt-6.0 \
> > +   -machine virtualization=true \
> > +   -smp 4 \
> > +   -m 1024 \
> > +   -serial stdio \
> > +   -monitor none \
> > +   -display none \
> > +   -dtb virt.dtb \
> > +   -no-reboot \
> > +   -kernel ./xen \
> > +   -device loader,file=./vmlinuz,addr=0x1000000 \
> > +   -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial
> > +
> > +set -e
> > +(grep -q "^/ #" smoke.serial) || exit 1
> > +exit 0
> 
> Cheers,
> Michal
> 


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 00:16:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 00:16:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305997.521168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfW7V-0005Fs-QW; Sat, 16 Apr 2022 00:16:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305997.521168; Sat, 16 Apr 2022 00:16:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfW7V-0005Fl-NP; Sat, 16 Apr 2022 00:16:57 +0000
Received: by outflank-mailman (input) for mailman id 305997;
 Sat, 16 Apr 2022 00:16:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ijIa=U2=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfW7U-0005Ff-F9
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 00:16:56 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 854a5eff-bd1a-11ec-8fbe-03012f2f19d4;
 Sat, 16 Apr 2022 02:16:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 27755622B5;
 Sat, 16 Apr 2022 00:16:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39197C385A4;
 Sat, 16 Apr 2022 00:16:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 854a5eff-bd1a-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650068213;
	bh=ptYmmK7oSeN6t7zkKcFYae82czllhfj65kZFPx7eje4=;
	h=Date:From:To:cc:Subject:From;
	b=mmMxlkPBumEwZ5nFNbQ3y/ZMrbBFww4I4Hl8u7sB7sgqBEZdO8WCELxL68plOJNb8
	 99I+Xqt2wXIY0+x6YUZeSdm5aN1FjY4yK5V05zcsIhNTrYW4A9BXwQ5QNtGscq6QwS
	 YkYPpw/hzOyuJmqFBYh3IW274/iuierCOlAkRLyZBHJhma3f+AIE4403ViNn1YyK8x
	 tfshRPV/n8xlT5AFAtBFoo1b0x5FRbfobtupdkGrIEr48eYwH1ZtkYfV0PkuXj40qk
	 3gIxYIQO9i0uFKzpK13oAK/Lnk7tgZZClUrTZtohLAt4cljOGqp11xi8Dn9lhPP9Hc
	 icxCptLSDkYUA==
Date: Fri, 15 Apr 2022 17:16:52 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, cardoe@cardoe.com, wl@xen.org, 
    andrew.cooper3@citrix.com, anthony.perard@citrix.com, 
    bertrand.marquis@arm.com
Subject: [PATCH v5 0/2] automation: qemu32 smoke test
Message-ID: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi all,

This small series adds a simple Xen + Dom0 boot arm32 test to gitlab-ci
using QEMU, similar to the existing tests for arm64 and x86.

Cheers,

Stefano

Stefano Stabellini (2):
      gitlab-ci: add qemu-system-arm to the existing tests-artifacts container
      gitlab-ci: add an ARM32 qemu-based smoke test

 automation/gitlab-ci/build.yaml                    | 14 +++-
 automation/gitlab-ci/test.yaml                     | 27 +++++++-
 automation/scripts/qemu-smoke-arm32.sh             | 81 ++++++++++++++++++++++
 ...arm64v8.dockerfile => 6.0.0-arm64v8.dockerfile} |  5 +-
 4 files changed, 121 insertions(+), 6 deletions(-)
 create mode 100755 automation/scripts/qemu-smoke-arm32.sh
 rename automation/tests-artifacts/qemu-system-aarch64/{5.2.0-arm64v8.dockerfile => 6.0.0-arm64v8.dockerfile} (95%)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 00:17:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 00:17:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.305999.521179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfW7g-0005ap-2d; Sat, 16 Apr 2022 00:17:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 305999.521179; Sat, 16 Apr 2022 00:17:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfW7f-0005ah-Uy; Sat, 16 Apr 2022 00:17:07 +0000
Received: by outflank-mailman (input) for mailman id 305999;
 Sat, 16 Apr 2022 00:17:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ijIa=U2=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfW7e-0005ZY-JX
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 00:17:06 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8bc253b9-bd1a-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 02:17:05 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id CF7DCB82E4A;
 Sat, 16 Apr 2022 00:17:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31FAAC385A5;
 Sat, 16 Apr 2022 00:17:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bc253b9-bd1a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650068223;
	bh=6fcuGmN0VOLiEsFwZuvE42PfLHtwz8AS00f3BuXsHLc=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=pmApBdSJcHbWbnfh+wsXmuRYSnhYIeiPQPRc4utM1Ay1wZAcwlg9eARU4nGFie76I
	 PsvlRrYXaf4UdX0165uOp7ChN1y2AwXvQpPFnJwUiDXxu5C6dQf81pDwXHKfvAGA4z
	 T6BIWl9KhXAJyfQ8hRWTCh9gVxCIlbCX97jbX/IwuR6uQJdn4iaxUYWfsVgB5+u864
	 g6G3UOO4ec7D0Iqt8BMPw8/DxIoZROyDWTdd4CJrInXjC+69/ilbCUcjV58zvS3v5y
	 wQxHd8egnwz8ohRMB9SdkYv4k3IKUD6ZEpUCLWwEc0pVFu7REztgesJJxPbhrUL+n5
	 7XbL0a/A47Uug==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	cardoe@cardoe.com,
	wl@xen.org,
	andrew.cooper3@citrix.com,
	anthony.perard@citrix.com,
	bertrand.marquis@arm.com,
	michal.orzel@arm.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v5 1/2] gitlab-ci: add qemu-system-arm to the existing tests-artifacts container
Date: Fri, 15 Apr 2022 17:17:00 -0700
Message-Id: <20220416001701.1301324-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Add qemu-system-arm to the existing test-artifacts qemu container (which
doesn't get build for every iteration but only updated once in a while.)

With qemu-system-arm available, we'll be able to run ARM32 tests.

This patch also bumps the QEMU version to v6.0.0 for both arm32 and
arm64 (the test-artifacts container is one, shared for both).

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/gitlab-ci/build.yaml                    | 14 ++++++++++++--
 automation/gitlab-ci/test.yaml                     |  4 ++--
 ...arm64v8.dockerfile => 6.0.0-arm64v8.dockerfile} |  5 +++--
 3 files changed, 17 insertions(+), 6 deletions(-)
 rename automation/tests-artifacts/qemu-system-aarch64/{5.2.0-arm64v8.dockerfile => 6.0.0-arm64v8.dockerfile} (95%)

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index cc36428cf5..72f2a317ac 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -591,9 +591,9 @@ kernel-5.9.9-arm64-export:
   tags:
     - arm64
 
-qemu-system-aarch64-5.2.0-arm64-export:
+qemu-system-aarch64-6.0.0-arm64-export:
   stage: build
-  image: registry.gitlab.com/xen-project/xen/tests-artifacts/qemu-system-aarch64:5.2.0-arm64v8
+  image: registry.gitlab.com/xen-project/xen/tests-artifacts/qemu-system-aarch64:6.0.0-arm64v8
   script:
     - mkdir binaries && cp /qemu-system-aarch64 binaries/qemu-system-aarch64
   artifacts:
@@ -602,6 +602,16 @@ qemu-system-aarch64-5.2.0-arm64-export:
   tags:
     - arm64
 
+qemu-system-aarch64-6.0.0-arm32-export:
+  stage: build
+  image: registry.gitlab.com/xen-project/xen/tests-artifacts/qemu-system-aarch64:6.0.0-arm64v8
+  script:
+    - mkdir binaries && cp /qemu-system-arm binaries/qemu-system-arm
+  artifacts:
+    paths:
+      - binaries/qemu-system-arm
+  tags:
+    - arm64
 
 # x86_64 test artifacts
 
diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 47e8704df3..ec2a2e1607 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -33,7 +33,7 @@ qemu-alpine-arm64-gcc:
     - alpine-3.12-gcc-arm64
     - alpine-3.12-arm64-rootfs-export
     - kernel-5.9.9-arm64-export
-    - qemu-system-aarch64-5.2.0-arm64-export
+    - qemu-system-aarch64-6.0.0-arm64-export
   artifacts:
     paths:
       - smoke.serial
@@ -81,7 +81,7 @@ qemu-smoke-arm64-gcc:
   dependencies:
     - debian-unstable-gcc-arm64
     - kernel-5.9.9-arm64-export
-    - qemu-system-aarch64-5.2.0-arm64-export
+    - qemu-system-aarch64-6.0.0-arm64-export
   artifacts:
     paths:
       - smoke.serial
diff --git a/automation/tests-artifacts/qemu-system-aarch64/5.2.0-arm64v8.dockerfile b/automation/tests-artifacts/qemu-system-aarch64/6.0.0-arm64v8.dockerfile
similarity index 95%
rename from automation/tests-artifacts/qemu-system-aarch64/5.2.0-arm64v8.dockerfile
rename to automation/tests-artifacts/qemu-system-aarch64/6.0.0-arm64v8.dockerfile
index e105a1c636..793432d40b 100644
--- a/automation/tests-artifacts/qemu-system-aarch64/5.2.0-arm64v8.dockerfile
+++ b/automation/tests-artifacts/qemu-system-aarch64/6.0.0-arm64v8.dockerfile
@@ -3,7 +3,7 @@ LABEL maintainer.name="The Xen Project" \
       maintainer.email="xen-devel@lists.xenproject.org"
 
 ENV DEBIAN_FRONTEND=noninteractive
-ENV QEMU_VERSION=5.2.0
+ENV QEMU_VERSION=6.0.0
 ENV USER root
 
 RUN mkdir /build
@@ -25,7 +25,7 @@ RUN apt-get update && \
     tar xvJf qemu-"$QEMU_VERSION".tar.xz && \
     cd qemu-"$QEMU_VERSION" && \
     ./configure                \
-        --target-list=aarch64-softmmu \
+        --target-list=arm-softmmu,aarch64-softmmu \
         --enable-system        \
         --disable-blobs        \
         --disable-bsd-user     \
@@ -68,6 +68,7 @@ RUN apt-get update && \
     && \
     make -j$(nproc) && \
     cp ./build/qemu-system-aarch64 / && \
+    cp ./build/qemu-system-arm / && \
     cd /build && \
     rm -rf qemu-"$QEMU_VERSION"* && \
     apt-get autoremove -y && \
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Apr 16 00:17:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 00:17:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306000.521190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfW7h-0005rj-AW; Sat, 16 Apr 2022 00:17:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306000.521190; Sat, 16 Apr 2022 00:17:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfW7h-0005ra-6i; Sat, 16 Apr 2022 00:17:09 +0000
Received: by outflank-mailman (input) for mailman id 306000;
 Sat, 16 Apr 2022 00:17:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ijIa=U2=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfW7f-0005ZY-Cb
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 00:17:07 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b9d9499-bd1a-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 02:17:05 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id BB975622B5;
 Sat, 16 Apr 2022 00:17:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7EF4C385AA;
 Sat, 16 Apr 2022 00:17:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b9d9499-bd1a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650068224;
	bh=5Np3QJHz98DXqqQOyVt/bJUStMP1ux42too3httshOM=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=GGk7FQPBX78Jy0zC06YkRYQgkHl9X/VVXm+j0zZ2rZe+BV+MmKI/biyTEhjWXfpOS
	 Xndf4vO3MYl2m/j7zpMziN+kqMMAkiBTrTNef7CekW46i27Pl1sNIKyftQstAkHk81
	 e0aMUkbydtno06j0vP0kn9L6ETZDkn4JyHP5chGPegLutjvVXPskHYmmoM/XSjuBbG
	 s7Kj1zo62eeNFxA4EwXEs722OxlHSkzSZ5E5yGhTyYxdmps3KlNKSE7H7HnaLyNP3l
	 QaIYXH9DjB+J2f6tSMEo+mxgBeR9rfh0jIBbxwgj+wzMeqQymOP0z4EcQCBpKWeTfc
	 4EceshJB3s+2w==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	cardoe@cardoe.com,
	wl@xen.org,
	andrew.cooper3@citrix.com,
	anthony.perard@citrix.com,
	bertrand.marquis@arm.com,
	michal.orzel@arm.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v5 2/2] gitlab-ci: add an ARM32 qemu-based smoke test
Date: Fri, 15 Apr 2022 17:17:01 -0700
Message-Id: <20220416001701.1301324-2-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a minimal ARM32 smoke test based on qemu-system-arm, as provided by
the test-artifacts qemu container. The minimal test simply boots Xen
(built from previous build stages) and Dom0.

The test needs a working kernel and minimal initrd for dom0. Instead of
building our own kernel and initrd, which would mean maintaining one or
two more builting scripts under automation/, we borrow a kernel and
initrd from distros.

For the kernel we pick the Debian Bullseye kernel, which has everything
we need already built-in. However, we cannot use the Debian Bullseye
initrd because it is 22MB and the large size causes QEMU to core dump.

Instead, use the tiny busybox-based rootfs provided by Alpine Linux,
which is really minimal: just 2.5MB. Note that we cannot use the Alpine
Linux kernel because that doesn't boot on Xen.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
Changes in v5:
- use "virt" machine in QEMU
- remove init= option

Changes in v4:
- improve commit message
- use Debian Bullseye kernel
- use Alpine Linux initrd

---
 automation/gitlab-ci/test.yaml         | 23 ++++++++
 automation/scripts/qemu-smoke-arm32.sh | 81 ++++++++++++++++++++++++++
 2 files changed, 104 insertions(+)
 create mode 100755 automation/scripts/qemu-smoke-arm32.sh

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index ec2a2e1607..42cd725a12 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -95,6 +95,29 @@ qemu-smoke-arm64-gcc:
     - /^coverity-tested\/.*/
     - /^stable-.*/
 
+qemu-smoke-arm32-gcc:
+  stage: test
+  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  variables:
+    CONTAINER: debian:unstable-arm64v8
+  script:
+    - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
+  dependencies:
+    - debian-unstable-gcc-arm32
+    - qemu-system-aarch64-6.0.0-arm32-export
+  artifacts:
+    paths:
+      - smoke.serial
+      - '*.log'
+    when: always
+  tags:
+    - arm64
+  except:
+    - master
+    - smoke
+    - /^coverity-tested\/.*/
+    - /^stable-.*/
+
 qemu-smoke-x86-64-gcc:
   stage: test
   image: registry.gitlab.com/xen-project/xen/${CONTAINER}
diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh
new file mode 100755
index 0000000000..15e6f46ce9
--- /dev/null
+++ b/automation/scripts/qemu-smoke-arm32.sh
@@ -0,0 +1,81 @@
+#!/bin/bash
+
+set -ex
+
+export DEBIAN_FRONTENT=noninteractive
+apt-get -qy update
+apt-get -qy install --no-install-recommends device-tree-compiler \
+                                            curl \
+                                            cpio
+
+cd binaries
+# Use the kernel from Debian
+curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz
+# Use a tiny initrd based on busybox from Alpine Linux
+curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz
+
+mkdir rootfs
+cd rootfs
+tar xvzf ../initrd.tar.gz
+find . | cpio -H newc -o | gzip > ../initrd.gz
+cd ..
+
+kernel=`stat -L --printf="%s" vmlinuz`
+initrd=`stat -L --printf="%s" initrd.gz`
+
+# For Xen, we need a couple of more node. Dump the DT from QEMU and add them
+# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded
+curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom
+./qemu-system-arm \
+   -machine virt \
+   -machine virtualization=true \
+   -smp 4 \
+   -m 1024 \
+   -serial stdio \
+   -monitor none \
+   -display none \
+   -machine dumpdtb=virt.dtb
+
+dtc -I dtb -O dts virt.dtb > virt.dts
+
+cat >> virt.dts << EOF
+/ {
+	chosen {
+		#address-cells = <0x2>;
+		#size-cells = <0x2>;
+		stdout-path = "/pl011@9000000";
+        xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0";
+		xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh";
+		dom0 {
+			compatible = "xen,linux-zimage", "xen,multiboot-module";
+			reg = <0x0 0x1000000 0x0 $kernel>;
+		};
+        dom0-ramdisk {
+			compatible = "xen,linux-initrd", "xen,multiboot-module";
+			reg = <0x0 0x3200000 0x0 $initrd>;
+		};
+	};
+};
+EOF
+dtc -I dts -O dtb virt.dts > virt.dtb
+
+rm -f smoke.serial
+set +e
+timeout -k 1 240 \
+./qemu-system-arm \
+   -machine virt-6.0 \
+   -machine virtualization=true \
+   -smp 4 \
+   -m 1024 \
+   -serial stdio \
+   -monitor none \
+   -display none \
+   -dtb virt.dtb \
+   -no-reboot \
+   -kernel ./xen \
+   -device loader,file=./vmlinuz,addr=0x1000000 \
+   -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial
+
+set -e
+(grep -q "^/ #" smoke.serial) || exit 1
+exit 0
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Apr 16 00:29:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 00:29:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306013.521201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfWJZ-0007yL-Do; Sat, 16 Apr 2022 00:29:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306013.521201; Sat, 16 Apr 2022 00:29:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfWJZ-0007yE-AV; Sat, 16 Apr 2022 00:29:25 +0000
Received: by outflank-mailman (input) for mailman id 306013;
 Sat, 16 Apr 2022 00:29:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfWJX-0007y4-TX; Sat, 16 Apr 2022 00:29:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfWJX-0007ez-RF; Sat, 16 Apr 2022 00:29:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfWJX-0005OI-ER; Sat, 16 Apr 2022 00:29:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfWJX-0005sB-Dz; Sat, 16 Apr 2022 00:29:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7iejVxuIpM38hfESg2HP/Vm6/VcHx6BujSbDbbH0rTo=; b=DwNMwd6Jzb+QDDJeHujYID28Xu
	MxXVNx+IZ5mAJ8s5AJaNNV6RtZLsv2YZS1r8xpAmXRhnV9ly/K1gvYF01gJpuzyV0gjyQK5bnr3mZ
	FLnEzsODOEEgOgzyOOycM/Ow0eiZ97siu/ZdKnsa6PeIElha1+TQ/VS423AE9z0iw5Ww=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169440-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169440: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=9bf7291d636ebd816b8f81edcf366dac926f9f44
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 00:29:23 +0000

flight 169440 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169440/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 9bf7291d636ebd816b8f81edcf366dac926f9f44
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  424 attempts
Testing same since   169414  2022-04-15 04:11:47 Z    0 days   22 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5135 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 00:30:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 00:30:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306021.521211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfWKi-0000qY-PU; Sat, 16 Apr 2022 00:30:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306021.521211; Sat, 16 Apr 2022 00:30:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfWKi-0000qR-MG; Sat, 16 Apr 2022 00:30:36 +0000
Received: by outflank-mailman (input) for mailman id 306021;
 Sat, 16 Apr 2022 00:30:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ijIa=U2=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nfWKh-0000qJ-HF
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 00:30:35 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d537b71-bd1c-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 02:30:34 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D2D2E622CE;
 Sat, 16 Apr 2022 00:30:32 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E029EC385A5;
 Sat, 16 Apr 2022 00:30:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d537b71-bd1c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650069032;
	bh=gQSFkzWaSCzU6UI9kfwlgCZeTrqeUZGpegqf+xzbLAQ=;
	h=From:To:Cc:Subject:Date:From;
	b=mK4bZmXVRMVSWKWTH9TVzcmpV3DnUZkbRpvjz/DD1T5ZhThWoNd9U4H+7uNIdVfJL
	 INCK0P8w24MupU6S4o6rd8p8V9WrGLwDR0Dj/Y1EBCtyPALbRi0PRtMtjIvGjzoSE5
	 Af+REMEn7gGqdACUEpoqRnfM1zaKsRfoNlIftOmN8LzZTeG/GtFFliec/nLvK+TmsZ
	 fO1XYmboB8vsYUfaKDLCUZv9zULTPj7wY+YGbxnqNtnwXpNcZOv7oXKofSjNUjrWVJ
	 /HfMju5Ot8B0JfMq554EeAxRdXPhd6G788cbgzCAyyt4XGu9+Z21QZ7oTnUUjNouzp
	 DFwB07UstNwnA==
From: Stefano Stabellini <sstabellini@kernel.org>
To: robh+dt@kernel.org,
	frowand.list@gmail.com
Cc: sstabellini@kernel.org,
	devicetree@vger.kernel.org,
	julien@xen.org,
	xen-devel@lists.xenproject.org,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v2] of: of_property_read_string return -ENODATA when !length
Date: Fri, 15 Apr 2022 17:30:28 -0700
Message-Id: <20220416003028.1315268-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

When the length of the string is zero of_property_read_string should
return -ENODATA according to the description of the function.

However, of_property_read_string doesn't check prop->length. If
prop->length is zero, return -ENODATA.

Without this patch the following command in u-boot:

fdt set /chosen/node property-name

results in of_property_read_string returning -EILSEQ when attempting to
read property-name. With this patch, it returns -ENODATA as expected.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
Changes in v2:
- use prop instead pp
- drop value check
- update function header documentation
---
 drivers/of/property.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 8e90071de6ed..84903dad96a4 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -431,6 +431,9 @@ EXPORT_SYMBOL_GPL(of_property_read_variable_u64_array);
  * property does not have a value, and -EILSEQ if the string is not
  * null-terminated within the length of the property data.
  *
+ * Note that the empty string "" has length of 1, thus -ENODATA cannot
+ * be interpreted as an empty string.
+ *
  * The out_string pointer is modified only if a valid string can be decoded.
  */
 int of_property_read_string(const struct device_node *np, const char *propname,
@@ -439,7 +442,7 @@ int of_property_read_string(const struct device_node *np, const char *propname,
 	const struct property *prop = of_find_property(np, propname, NULL);
 	if (!prop)
 		return -EINVAL;
-	if (!prop->value)
+	if (!prop->length)
 		return -ENODATA;
 	if (strnlen(prop->value, prop->length) >= prop->length)
 		return -EILSEQ;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Apr 16 00:57:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 00:57:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306029.521223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfWkS-0003a5-Tr; Sat, 16 Apr 2022 00:57:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306029.521223; Sat, 16 Apr 2022 00:57:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfWkS-0003Zy-PU; Sat, 16 Apr 2022 00:57:12 +0000
Received: by outflank-mailman (input) for mailman id 306029;
 Sat, 16 Apr 2022 00:57:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfWkS-0003Zo-1y; Sat, 16 Apr 2022 00:57:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfWkR-00086V-Ve; Sat, 16 Apr 2022 00:57:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfWkR-000641-EV; Sat, 16 Apr 2022 00:57:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfWkR-0004Lk-E3; Sat, 16 Apr 2022 00:57:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IQVVZOCy/SzTyuifp9ZBxcc+hGmRpCD0LHLYV8i4ZyE=; b=1KZEkYkHuAYMRaFhDWZXh6OmZ6
	kCW/BsJo5PJ5Ncue/FQ+HE0u3NqlUVG0BqHijC/Z5uGlLfBqWfVnC3xhpk3aknEDCkwbcBoH1D00T
	HE5mjy02pDpbRYRwTp3YqE9Vi7jWGkQemQ1rgPgtqCmfuFyWgaspyxCJGMoWzhuQYfn4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169434-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169434: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fb649bda6f5642f173ee3429a965c769554f23d8
X-Osstest-Versions-That:
    linux=028192fea1de083f4f12bfb1eb7c4d7beb5c8ecd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 00:57:11 +0000

flight 169434 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169434/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169409
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169409
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169409
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169409
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169409
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169409
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169409
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169409
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                fb649bda6f5642f173ee3429a965c769554f23d8
baseline version:
 linux                028192fea1de083f4f12bfb1eb7c4d7beb5c8ecd

Last test of basis   169409  2022-04-15 00:10:44 Z    1 days
Testing same since   169434  2022-04-15 19:09:47 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Alan Adamson <alan.adamson@oracle.com>
  Alexander Lobakin <alobakin@pm.me>
  Alexey Bayduraev <alexey.bayduraev@gmail.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Athira Jajeev <atrajeev@linux.vnet.ibm.com>
  Athira Rajeev <atrajeev@linux.vnet.ibm.com>
  Chaitanya Kulkarni <kch@nvidia.com>
  Christoph Hellwig <hch@lst.de>
  Disha Goel <disgoel@linux.vnet.ibm.com>
  Dylan Yudaken <dylany@fb.com>
  Ian Rogers <irogers@google.com>
  Jens Axboe <axboe@kernel.dk>
  Keith Busch <kbusch@kernel.org>
  Khazhismel Kumykov <khazhy@google.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Ming Lei <ming.lei@redhat.com>
  Pavel Begunkov <asml.silence@gmail.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Yi Zhang <yi.zhang@redhat.com>
  金韬 <me@kingtous.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   028192fea1de..fb649bda6f56  fb649bda6f5642f173ee3429a965c769554f23d8 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 01:30:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 01:30:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306039.521234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfXGv-00060l-JJ; Sat, 16 Apr 2022 01:30:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306039.521234; Sat, 16 Apr 2022 01:30:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfXGv-00060e-FR; Sat, 16 Apr 2022 01:30:45 +0000
Received: by outflank-mailman (input) for mailman id 306039;
 Sat, 16 Apr 2022 01:30:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfXGu-00060U-FP; Sat, 16 Apr 2022 01:30:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfXGu-0006Wd-Dn; Sat, 16 Apr 2022 01:30:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfXGt-0006mM-NN; Sat, 16 Apr 2022 01:30:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfXGt-0003qW-Mv; Sat, 16 Apr 2022 01:30:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=985p7p2+y+NyOLmnljuKeZW00JJOiwEKP/Suf8CZlVY=; b=4GqPWxlo45uhodkh2v0fHzI77/
	gL5Ij9moftQqwfpMeqvlpYzk81oZrRM492aTCSnMmj5VQuuh7zKv1w7OhbB40EHKZsjGSglznG4/O
	R/FJMEFhJZ3KaD2HrzT43PD8ZyVmn+qbeoHyDojY8OIJ75UtwQ4O0F6vXOccJBfFrekU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169441-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169441: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 01:30:43 +0000

flight 169441 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169441/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   45 days  425 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 02:25:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 02:25:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306050.521244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfY7m-0003MD-PJ; Sat, 16 Apr 2022 02:25:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306050.521244; Sat, 16 Apr 2022 02:25:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfY7m-0003M6-Lf; Sat, 16 Apr 2022 02:25:22 +0000
Received: by outflank-mailman (input) for mailman id 306050;
 Sat, 16 Apr 2022 02:25:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfY7l-0003Lw-Il; Sat, 16 Apr 2022 02:25:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfY7l-0007sl-Do; Sat, 16 Apr 2022 02:25:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfY7l-0000Hf-0y; Sat, 16 Apr 2022 02:25:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfY7l-0007ix-0X; Sat, 16 Apr 2022 02:25:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=20Z6Ep/19QtYNBxXRFBosKjsWn6VorZVzx8TwaBXcjk=; b=TOfQx2ctWd1TwdEAYNpCJIu1Ac
	w6P7Tj/pEKAdim3LMuIZDk0Kbm0JVVBeH/htYtZzh8a8+XetSo+6E4NlfIIs1muL4AOq2sPo4hDUu
	6AYPphCMkV2Ag9Gt7ridxkL3BEZ8hyXJMrOYoGM8GFueX8outvtCVyzIZtaZf0keqdtE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169443-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169443: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 02:25:21 +0000

flight 169443 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169443/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  426 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 03:23:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 03:23:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306063.521256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfZ25-0001C9-8R; Sat, 16 Apr 2022 03:23:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306063.521256; Sat, 16 Apr 2022 03:23:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfZ25-0001C2-4x; Sat, 16 Apr 2022 03:23:33 +0000
Received: by outflank-mailman (input) for mailman id 306063;
 Sat, 16 Apr 2022 03:23:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfZ24-0001Bs-Nh; Sat, 16 Apr 2022 03:23:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfZ24-0000RM-La; Sat, 16 Apr 2022 03:23:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfZ24-0003NV-5L; Sat, 16 Apr 2022 03:23:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfZ24-0003ey-4t; Sat, 16 Apr 2022 03:23:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hD6s1FsFgqJa1LJ6mgyoyAGkAXz5Y8n/gGftoxvwDyg=; b=kdoUMKuDvv+nY3TSNzRgbOF7nl
	8HYhDGIdKeLT4bQqqUDGBv3uNSnJ/tN69ZlL49lhGnmoLVWJGF3WEqZpBC9JdnAPYk+1uY1BUxgLo
	jy1m+iJxreasSJChlZgFlx/FXJmABsm6DQunB7TN5Wq9rPSfGwhs2l/ecrKkoJD0YyFY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169445-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169445: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 03:23:32 +0000

flight 169445 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169445/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  427 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 04:50:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 04:50:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306079.521268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfaNp-0001kZ-Eq; Sat, 16 Apr 2022 04:50:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306079.521268; Sat, 16 Apr 2022 04:50:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfaNp-0001jx-9T; Sat, 16 Apr 2022 04:50:05 +0000
Received: by outflank-mailman (input) for mailman id 306079;
 Sat, 16 Apr 2022 04:50:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfaNo-0001ZB-Bv; Sat, 16 Apr 2022 04:50:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfaNo-00025O-8o; Sat, 16 Apr 2022 04:50:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfaNn-0007te-S2; Sat, 16 Apr 2022 04:50:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfaNn-0000lW-RY; Sat, 16 Apr 2022 04:50:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=m/8OV9uyARQcPVglBhmJ66ArpymXrV/BePkY8eQ2SyE=; b=TjHmHWsqbY9jBVsCpOPDKmVTAA
	iFoz1v0wpiqEHhlN0p6O6+7nXa3vKPAx10wknithbWHxXn+CVzikYLyXaXTGeK0jAnr+YPf7xZZdM
	aXgvdpGnqBarw9B+Q1ZU8oG6NV4DnGuitEkByXe+tlCu/okaP2tIhneRZGgh0jDDsbBc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169446-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169446: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 04:50:03 +0000

flight 169446 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169446/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  428 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 05:51:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 05:51:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306112.521277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfbKZ-0008SQ-0k; Sat, 16 Apr 2022 05:50:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306112.521277; Sat, 16 Apr 2022 05:50:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfbKY-0008SJ-U9; Sat, 16 Apr 2022 05:50:46 +0000
Received: by outflank-mailman (input) for mailman id 306112;
 Sat, 16 Apr 2022 05:50:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=APt2=U2=gmail.com=cheyenne.wills@srs-se1.protection.inumbo.net>)
 id 1nfbKX-0008SD-BU
 for xen-devel@lists.xen.org; Sat, 16 Apr 2022 05:50:45 +0000
Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com
 [2607:f8b0:4864:20::1129])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2726de28-bd49-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 07:50:44 +0200 (CEST)
Received: by mail-yw1-x1129.google.com with SMTP id
 00721157ae682-2ec04a2ebadso99020107b3.12
 for <xen-devel@lists.xen.org>; Fri, 15 Apr 2022 22:50:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2726de28-bd49-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:from:date:message-id:subject:to;
        bh=1UIFF5U/Ka4zr1pIlbdRJ1zFRVaVz1C9GcXIRGvn7qw=;
        b=L41egicTDgm7U2qK/btcKbQcn1Dmli0MwNufDUaAt9jUYHlhs47WWouQ+sbaH+Pcan
         gDYUPriQCv68EZW5210tYIJ+WBsmpQKBWSAbeBB/u0cUUc4NWPLGYl4Bst5buGLoBUpm
         MBqO6hG8M7/us9Qx+InP9KrdY2BvlAdlYob6q87qfVBiG8lr5d08OjhQfxFjrp5V/Ggh
         yraoV/UDLs4r1/VGnQAUT9ovCCJ4pyYT9nAhmcoV9PCYnKEkbBQovkw/LLiNbFogZ/pS
         RKBZ4D7+YylWdVghSSZdkSbTMJwlXuFLfECVlLBI9FdSA74MdhmlOMNltfuJCo6HNtcj
         g67w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=1UIFF5U/Ka4zr1pIlbdRJ1zFRVaVz1C9GcXIRGvn7qw=;
        b=WiYblyblReclE5fQGy5G39P0hQ0NTWzfuqoGQz348zxQj6Zg2r3IDbFtATc9MUq3fv
         lv86pVvFdMY7/CFHk3IfocwW6RCUESDxVYTB5R/tw/s+XHAgxtZN/wCWeuF5Bfr52cjv
         ZeNbCkYtLf428BnyXXHrIGIzXn8d9wnECAhOy7GqMAisFsRvQ2Xv3BLG+FSGgDjUj2FX
         2OJF75z5yU08id78B6m8Da9Aqjkk/SfKA3U1dBdVCpxyZNEpLmK5JwJ9weDKrBxEBiSH
         QUrSdMjbLPwfHCYP0uRGuu2E6MjrlZvvFYYEzFHbR8x1C3WY+SgGt48VQWMdVCQxyeXX
         Stzw==
X-Gm-Message-State: AOAM533RoU5cy2KPgzxVMXxAAh3P0QG6n5Jr7yRes9Yxzkf57miQEfKq
	53J62yCxIPzSU/pY/NAAUhwzVKqAKZKxjFS2lIdqWWi5EO8=
X-Google-Smtp-Source: ABdhPJwt58nP7W7gPl3OFZjvGV5M+jDkoP2s3ykLuet2YEbWGJsFCQJxjlieCHI0r91xn22xaYiTEfAxu6mC1oJHK2U=
X-Received: by 2002:a81:2551:0:b0:2ef:2d02:8979 with SMTP id
 l78-20020a812551000000b002ef2d028979mr1967836ywl.352.1650088242250; Fri, 15
 Apr 2022 22:50:42 -0700 (PDT)
MIME-Version: 1.0
From: Cheyenne Wills <cheyenne.wills@gmail.com>
Date: Fri, 15 Apr 2022 23:50:31 -0600
Message-ID: <CAHpsFVfYE0TfCEON1fuNsoxT54TgwAy9EJTM5utQEjtNMEd3NQ@mail.gmail.com>
Subject: [BUG] RIP panic when using gdbsx and CONFIG_GDBSX is not set
To: xen-devel@lists.xen.org
Content-Type: text/plain; charset="UTF-8"

I have a reproducible Xen hypervisor crash (tried 4.15 and 4.16) when
using gdbsx to perform debugging on a guest.

steps to reproduce:

xen host system built without CONFIG_GDBSX configured

start a linux guest
attach gdbsx to the guest (e.g. gdbsx -a {domid} 64 9999

on a remote system, set up a debugging session for the linux kernel on the guest

(in linux source tree that matches the guest)
gdb vmlinux
target remote {remotexen}:9999
lx-symbol

At this point the xen system will have crashed with a RIP panic

Rebuilding the xen hypervisor with CONFIG_GDBSX fixes the panic.

-----
I'm using a gentoo system for the host DOM0 system and used the gentoo
xen/xen-tools ebuild packages.  I've tried the:

xen-4.15.2-r2.ebuild and xen-4.16.0-r5.ebuild

I was able to resolve the problem by stepping through their ebuild
steps and performing a manual "make menuconfig" to enable CONFIG_GDBSX
right before the compile step.

---- capture from xen serial console ----
-----
(XEN) ----[ Xen-4.16.0  x86_64  debug=n  Not tainted ]----
(XEN) CPU:    6
(XEN) RIP:    e008:[<ffff82d040269984>] iommu_do_domctl+0x4/0x30
(XEN) RFLAGS: 0000000000010202   CONTEXT: hypervisor (d0v0)
(XEN) rax: 00000000000003e8   rbx: ffff830856277ef8   rcx: ffff830856277fff
(XEN) rdx: 0000560164cad1e0   rsi: 0000000000000000   rdi: ffff830856277db0
(XEN) rbp: 0000560164cad1e0   rsp: ffff830856277c90   r8:  0000000000000001
(XEN) r9:  0000000000000001   r10: 0000000000000000   r11: 0000000000000000
(XEN) r12: ffff830856277db0   r13: 0000000000000000   r14: ffff83085624f000
(XEN) r15: 0000000000000000   cr0: 0000000080050033   cr4: 0000000000372660
(XEN) cr3: 00000004e64e4000   cr2: 0000000000000144
(XEN) fsb: 00007f02cdbbb740   gsb: ffff888173a00000   gss: 0000000000000000
(XEN) ds: 0000   es: 0000   fs: 0000   gs: 0000   ss: e010   cs: e008
(XEN) Xen code around <ffff82d040269984> (iommu_do_domctl+0x4/0x30):
(XEN)  00 0f 1f 00 f3 0f 1e fa <f6> 86 44 01 00 00 20 74 0b 0f ae e8 e9 ab 1b 00
(XEN) Xen stack trace from rsp=ffff830856277c90:
(XEN)    ffff82d04035cd5f 0000000000000000 ffffffff8109e860 ffff830856277ef8
(XEN)    ffffffff0c926d00 0000000000000000 aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaa
(XEN)    aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaa
(XEN)    aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaa ffff82d040580120 ffff8308562834b0
(XEN)    ffff82d040461d00 0000000000000000 ffff830856277e68 0000560164cad1e0
(XEN)    0000560164cad1e0 ffff830856277db0 0000000000000000 ffff82d040239e46
(XEN)    ffffc90040ebbb0c 0000000000000000 0000000000000000 0000000000000000
(XEN)    0000000000000000 0000000000000000 00000000c0000102 0000000000000000
(XEN)    ffffc90040ebbaa8 00000000c0000102 0000000d00000000 ffffffff8109e860
(XEN)    00000014000003e8 0000000000000001 0000000000000000 ffffffff82a15ec0
(XEN)    00005601656f06c0 0000000000000004 0000000000000000 0000000000000000
(XEN)    0000000000000000 0000000000000000 0000000000000000 0000000000000000
(XEN)    0000000000000000 0000000000000000 0000000000000000 0000000000000000
(XEN)    0000000000000000 0000000000000000 ffff830856277ef8 ffff82d040238ff0
(XEN)    0000560164cad1e0 0000000000000000 0000000000000000 ffff83085623c000
(XEN)    ffff82d0402f8c59 0000000000000000 0000000000000000 0000000000000000
(XEN)    0000000000000000 ffffffffffffffff 0000000000000000 0000000000000000
(XEN)    ffff830856277ef8 ffff82d0402f5161 ffff83085623c000 0000000000000000
(XEN)    0000000000000000 0000000000000000 0000000000000000 0000000000000000
(XEN)    ffff82d040366288 0000000000000000 ffff88811703ad00 00007ffcb2259d60
(XEN) Xen call trace:
(XEN)    [<ffff82d040269984>] R iommu_do_domctl+0x4/0x30
(XEN)    [<ffff82d04035cd5f>] S arch_do_domctl+0x7f/0x2330
(XEN)    [<ffff82d040239e46>] S do_domctl+0xe56/0x1930
(XEN)    [<ffff82d040238ff0>] S do_domctl+0/0x1930
(XEN)    [<ffff82d0402f8c59>] S pv_hypercall+0x99/0x110
(XEN)    [<ffff82d0402f5161>] S arch/x86/pv/domain.c#_toggle_guest_pt+0x11/0x90
(XEN)    [<ffff82d040366288>] S lstar_enter+0x128/0x130
(XEN)
(XEN) Pagetable walk from 0000000000000144:
(XEN)  L4[0x000] = 0000000000000000 ffffffffffffffff
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 6:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=0000]
(XEN) Faulting linear address: 0000000000000144
(XEN) ****************************************
(XEN)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 06:05:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 06:05:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306117.521289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfbYy-0001kD-BG; Sat, 16 Apr 2022 06:05:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306117.521289; Sat, 16 Apr 2022 06:05:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfbYy-0001k6-7u; Sat, 16 Apr 2022 06:05:40 +0000
Received: by outflank-mailman (input) for mailman id 306117;
 Sat, 16 Apr 2022 06:05:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=x34X=U2=bombadil.srs.infradead.org=BATV+8011bb1914c3be3034d5+6810+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfbYx-0001k0-0b
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 06:05:39 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3a7df21b-bd4b-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 08:05:37 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1nfbYm-00CJyx-V4; Sat, 16 Apr 2022 06:05:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a7df21b-bd4b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=+t0Bu8KSg3jBujgghxzlFf0uKoDQfWljvnbuJuxey94=; b=NADL9qThPsf2tQw9wSHR9J87h6
	TY536TR9jkne0wei9WY4j7IwwHfhpH1iteQfDtfp4OZtWhkNUzwPVqifBfszMOendhZl2f4xZ2u+y
	TYC00bS1du/ddF5g5gu8CKTOXCDS5Guevew6Pjc26q9dR7Z9M0Tzye5DzR1ltSKBqF7cgb7+GOLnS
	ZH9JNk7WKDNl5rub16At6nBeAgYi3wqX2ljSIa64BwQEYdkcsrW4z1OpISFIXlqvsgSU2MCZUI/+1
	dK+0Mrtad1Cvt7l6kF+NqECSoae/PgeDBD+5SorOBUGeEhESw974b1TzM4gfXqvz3hnfnTZbcEEfi
	YwNHI30A==;
Date: Fri, 15 Apr 2022 23:05:28 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops
 layer
Message-ID: <YlpcqOUK59yExXlq@infradead.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Thu, Apr 14, 2022 at 10:19:31PM +0300, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Various updates is a big indicator that the patch should be split
further.  Please do one change at a time, and fold updates to the
previous patches in the series into those patches instead of fixing
them up later.


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 06:07:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 06:07:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306123.521300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfbaK-0002Kg-LL; Sat, 16 Apr 2022 06:07:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306123.521300; Sat, 16 Apr 2022 06:07:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfbaK-0002KZ-IX; Sat, 16 Apr 2022 06:07:04 +0000
Received: by outflank-mailman (input) for mailman id 306123;
 Sat, 16 Apr 2022 06:07:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=x34X=U2=bombadil.srs.infradead.org=BATV+8011bb1914c3be3034d5+6810+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nfbaJ-0002KJ-Hw
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 06:07:03 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6e9b0c86-bd4b-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 08:07:02 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1nfbaG-00CK5x-5f; Sat, 16 Apr 2022 06:07:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e9b0c86-bd4b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=7q55fBD/If1zhZdmpRrkJ8LAPojnNiIN0sEvE05Ctwk=; b=cMcvUoLF9t8i+WPX8nbPrHKTpU
	B06E6ECDKRBlaNNA7/4Q6dRDnLjRFGOUX8wd8Q2KKhjuHBLFPV9+Zue4ho9wVEB6RS30D1zBioXtt
	V+Lp1o4dTv5oHaBbZVlDVRCWQUwOi4y++6lq9CNFsRHkBUsaMwrJ7yHeIh4axcp/jLCE81Q+dkQXH
	6UwiBQxst4/dOqKM6Sf62txqv0VdU6kGjqWXmReVZcuCiaXZJC0kVaZ6qvGpFR5T8y5tPNfSVSm4b
	OXEoHMu6B0oPLJmJynm2f59ZyjZEkOocBrfRZD/q2Q/YyYMduY3sFwU4R8BNOZYm074q3ByEG86ZA
	ROsKlu+w==;
Date: Fri, 15 Apr 2022 23:07:00 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
Message-ID: <YlpdBHKT1bYzZe2e@infradead.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Fri, Apr 15, 2022 at 03:02:45PM -0700, Stefano Stabellini wrote:
> This makes sense overall. Considering that the swiotlb-xen case and the
> virtio case are mutually exclusive, I would write it like this:

Curious question:  Why can't the same grant scheme also be used for
non-virtio devices?  I really hate having virtio hooks in the arch
dma code.  Why can't Xen just say in DT/ACPI that grants can be used
for a given device?


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 07:45:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 07:45:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306145.521311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfd7K-00041G-4l; Sat, 16 Apr 2022 07:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306145.521311; Sat, 16 Apr 2022 07:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfd7K-000419-0M; Sat, 16 Apr 2022 07:45:14 +0000
Received: by outflank-mailman (input) for mailman id 306145;
 Sat, 16 Apr 2022 07:45:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfd7J-00040z-84; Sat, 16 Apr 2022 07:45:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfd7J-0005UR-4t; Sat, 16 Apr 2022 07:45:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfd7I-0007jZ-Ep; Sat, 16 Apr 2022 07:45:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfd7I-00079s-ES; Sat, 16 Apr 2022 07:45:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DeVuKYtAaSmsn5b8SJdbZHfianfH91aQ0yH/0Xhx+hs=; b=yXwpQMYo9UgEbH2eiJW0eZ7+MM
	bVqs0x614v2w8cZ+9XYE3wX2mbaR556jErs5+/lKhRdH/2HI/UpQBbjrZWP6TOq8GruSLdWld4D9Y
	okjbb6QKFcjYANMcLiAT+U1abCkegJNBeMJybyGbcOQ6QCy+yIhfwnfuKOJ/ED8xZ0IU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169442-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169442: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=59250f8a7f3a60a2661b84cbafc1e0eb5d05ec9b
X-Osstest-Versions-That:
    linux=fb649bda6f5642f173ee3429a965c769554f23d8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 07:45:12 +0000

flight 169442 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169442/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169434
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169434
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169434
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169434
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169434
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169434
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169434
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169434
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                59250f8a7f3a60a2661b84cbafc1e0eb5d05ec9b
baseline version:
 linux                fb649bda6f5642f173ee3429a965c769554f23d8

Last test of basis   169434  2022-04-15 19:09:47 Z    0 days
Testing same since   169442  2022-04-16 01:09:41 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Morton <akpm@linux-foundation.org>
  Axel Rasmussen <axelrasmussen@google.com>
  Baoquan He <bhe@redhat.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Charan Teja Kalla <quic_charante@quicinc.com>
  Chris Down <chris@chrisdown.name>
  Chuck Lever III <chuck.lever@oracle.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  David Hildenbrand <david@redhat.com>
  Hugh Dickins <hughd@google.com>
  Ivan Babrou <ivan@cloudflare.com>
  Joe Perches <joe@perches.com>
  Juergen Gross <jgross@suse.com>
  Khazhismel Kumykov <khazhy@google.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marco Elver <elver@google.com>
  Michal Hocko <mhocko@suse.com>
  Mike Kravetz <mike.kravetz@oracle.com>
  Mike Snitzer <snitzer@kernel.org>
  Mikulas Patocka <mpatocka@redhat.com>
  Minchan Kim <minchan@kernel.org>
  Omar Sandoval <osandov@fb.com>
  Patrick Wang <patrick.wang.shcn@gmail.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Vincenzo Frascino <vincenzo.frascino@arm.com>
  Vlastimil Babka <vbabka@suse.cz>
  Vlastimil Babka <vbabka@suse.cz>      [slab]
  Zqiang <qiang1.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   fb649bda6f56..59250f8a7f3a  59250f8a7f3a60a2661b84cbafc1e0eb5d05ec9b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 07:53:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 07:53:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306154.521322 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfdFj-0005X0-3N; Sat, 16 Apr 2022 07:53:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306154.521322; Sat, 16 Apr 2022 07:53:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfdFj-0005Wt-0H; Sat, 16 Apr 2022 07:53:55 +0000
Received: by outflank-mailman (input) for mailman id 306154;
 Sat, 16 Apr 2022 07:53:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfdFh-0005Wj-8y; Sat, 16 Apr 2022 07:53:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfdFh-0005dQ-7D; Sat, 16 Apr 2022 07:53:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfdFg-0008Gn-LB; Sat, 16 Apr 2022 07:53:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfdFg-0001t8-Kf; Sat, 16 Apr 2022 07:53:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ETqbhzetCtyTDYDO/By+5u5j1ad/BScoGuPjG74nn5Y=; b=x+/TRHGaWWs7OXOKExMr8Mo45t
	uS1vJIEmweNs02qzbOfwuVKn7fh9oGhNcAafW9Y77+7FDU9PiVmpSZSdlWQSzDa+a+QV7uLEEYZif
	jYBIC8jD99FofjpG4X54+v/Ghd48p8aaBNiSvQtNxC893V/CTcGEXn3CA5LoLogkEjYM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169448-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169448: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 07:53:52 +0000

flight 169448 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169448/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  429 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 08:44:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 08:44:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306176.521333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfe2r-000326-5z; Sat, 16 Apr 2022 08:44:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306176.521333; Sat, 16 Apr 2022 08:44:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfe2r-00031z-2j; Sat, 16 Apr 2022 08:44:41 +0000
Received: by outflank-mailman (input) for mailman id 306176;
 Sat, 16 Apr 2022 08:44:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfe2p-00031p-PK; Sat, 16 Apr 2022 08:44:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfe2p-00071b-Mo; Sat, 16 Apr 2022 08:44:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfe2p-00024b-6n; Sat, 16 Apr 2022 08:44:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfe2p-00047c-6P; Sat, 16 Apr 2022 08:44:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sIbzIRJatBKoTFWY2CJIEsWLj5G0f2ZpoVdvRj3BTK4=; b=iNSJobUoYHdYASuX0f3QAmg58w
	R6CBAmXKE2RkPIyupdbq7LWovXvpomxDR1TcZdlm78TVl2oshJV5k81UjfnPnWSohm7jUbxSx6iHD
	NbnufURRHUhgGM4trmoaTA45u9g/lfAUv9OOdC2b5JR+LwWZfcWd/IUArQJU+hNEjx44=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169449-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169449: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 08:44:39 +0000

flight 169449 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169449/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  430 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 09:30:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 09:30:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306188.521344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfekM-0007dq-RR; Sat, 16 Apr 2022 09:29:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306188.521344; Sat, 16 Apr 2022 09:29:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfekM-0007dj-OX; Sat, 16 Apr 2022 09:29:38 +0000
Received: by outflank-mailman (input) for mailman id 306188;
 Sat, 16 Apr 2022 09:29:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfekL-0007dZ-6e; Sat, 16 Apr 2022 09:29:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfekL-0007lT-4p; Sat, 16 Apr 2022 09:29:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfekK-0003OV-Ni; Sat, 16 Apr 2022 09:29:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfekK-0001on-NI; Sat, 16 Apr 2022 09:29:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Dbm7ZUxEGZn5OR3uewuivF7w8J8xSy2B999/hmlzHWA=; b=TJ+3KULxmoQ0npcxKQFzW6go8q
	WEoBmUyWggk3jF0X5HPnx6lMw+h3+VH/dkRauLeOjb5R9N+vQDQTOHs9aHTNE8sdSiGEADaoQwbrl
	U+u8py/wPyFCP42QeELgB57jm6M/XBHN2N6LUsGGAMIeQ+VlodCyfyFF7uCcSZuvhXgM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169450-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169450: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 09:29:36 +0000

flight 169450 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169450/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  431 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 09:35:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 09:35:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306198.521354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfeqL-0000gy-JT; Sat, 16 Apr 2022 09:35:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306198.521354; Sat, 16 Apr 2022 09:35:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfeqL-0000gr-Fc; Sat, 16 Apr 2022 09:35:49 +0000
Received: by outflank-mailman (input) for mailman id 306198;
 Sat, 16 Apr 2022 09:35:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfeqK-0000gh-EB; Sat, 16 Apr 2022 09:35:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfeqK-0007rg-8z; Sat, 16 Apr 2022 09:35:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfeqJ-0003Wv-TS; Sat, 16 Apr 2022 09:35:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfeqJ-0004HT-T2; Sat, 16 Apr 2022 09:35:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=D+0ABB6moTeyv7z7G5led0DsZT0etZbcRuxWrxN2DeA=; b=2ZHmrhH6OBYckE3ZWXuzFWBycP
	MaqcrNedE3eBlhGZcil6cVNCagjBuD25KzhEkpVcpaS9GTD7WpEhJ3qb3NSrybP6iJiw8JFVKrRkM
	QPr1COZ/OObVVcTerMiSSjU2l3i7JIg4jDSHy7NUpE4BB49Ua9d0CUyWgqAPn7zrqKvA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169447-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169447: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 09:35:47 +0000

flight 169447 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169447/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  645 days
Failing since        151818  2020-07-11 04:18:52 Z  644 days  626 attempts
Testing same since   169415  2022-04-15 04:18:55 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104670 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 10:02:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 10:02:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306208.521365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nffGL-0004Ay-Rg; Sat, 16 Apr 2022 10:02:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306208.521365; Sat, 16 Apr 2022 10:02:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nffGL-0004Ar-Og; Sat, 16 Apr 2022 10:02:41 +0000
Received: by outflank-mailman (input) for mailman id 306208;
 Sat, 16 Apr 2022 10:02:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nffGJ-0004Ae-Qa; Sat, 16 Apr 2022 10:02:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nffGJ-0008OG-O5; Sat, 16 Apr 2022 10:02:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nffGJ-0004EI-DJ; Sat, 16 Apr 2022 10:02:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nffGJ-0001rv-Ct; Sat, 16 Apr 2022 10:02:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+o0ghe+i9vJHyeQSoi9qs+levmk+G5wGMfrgwvDs8HQ=; b=UlJBX/dcolqXQOQzfUS6rVDWOV
	xNyD1yWEAlyzamhlIYiLpX4Cs3FvQ+Y/qL/wZRNhbK4X4e3bOjH+f6AfxGvPjRgNoNYqZIwCixksc
	CR8f0EZsYwkyglds4j48kUUOohn6HEHOHA6BgfrisAT6PQz5Xn2d8qrGS7+j0GP9pwh4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169451-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169451: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 10:02:39 +0000

flight 169451 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169451/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   46 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  432 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 10:58:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 10:58:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306222.521377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfg7w-0001EU-AR; Sat, 16 Apr 2022 10:58:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306222.521377; Sat, 16 Apr 2022 10:58:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfg7w-0001EN-6m; Sat, 16 Apr 2022 10:58:04 +0000
Received: by outflank-mailman (input) for mailman id 306222;
 Sat, 16 Apr 2022 10:58:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfg7u-0001ED-Ma; Sat, 16 Apr 2022 10:58:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfg7u-0000tm-Jv; Sat, 16 Apr 2022 10:58:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfg7u-0005y5-7T; Sat, 16 Apr 2022 10:58:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfg7u-00079n-6z; Sat, 16 Apr 2022 10:58:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Hnok7OSo76dsqr5cq3RSwsq+XIvoAivvkMNYplZZhkQ=; b=rSgy4DW6m/xvJGrB9vhg/CGI2z
	iE6cW3St4nLAsk6sQzfNb+XOKh0KVaqNZQHfo9YDJZfZJcZHgdpaqvni792pgeWmhQ6t+MDEX+E6F
	BWwMFBYfh31xkgSEoxBQy+g1wgtFXXCiqEv/2VyeLvn8lYzrPBv3InKh+z7gLljZ7fjc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169452-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169452: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 10:58:02 +0000

flight 169452 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169452/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  433 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 11:14:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 11:14:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306233.521387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfgNe-0003gq-Id; Sat, 16 Apr 2022 11:14:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306233.521387; Sat, 16 Apr 2022 11:14:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfgNe-0003gj-FU; Sat, 16 Apr 2022 11:14:18 +0000
Received: by outflank-mailman (input) for mailman id 306233;
 Sat, 16 Apr 2022 11:14:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfgNd-0003gZ-F2; Sat, 16 Apr 2022 11:14:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfgNd-0001Dq-5S; Sat, 16 Apr 2022 11:14:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfgNc-0006JW-OC; Sat, 16 Apr 2022 11:14:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfgNc-0001tS-Ni; Sat, 16 Apr 2022 11:14:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cNZCfUPjOPBZoydoog5dVbw9BOYd/PXT7+aeCQXI4JI=; b=1uShHTAb78HFGryhYBDYVl+/IR
	cDem3vJ24Ox01I9bJ9X9BFEvBb53eVebR8zzpLwfq7aqM890Mm+LY+MTIlw+6/uoTrgTh0kDiA/el
	+sG1z7gmeRRO3WzXr5l09bO3ObDkbd0Evsu1Td2hxp2qoHLC3MtGlZWAViMf0ARWXtCE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169444-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169444: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 11:14:16 +0000

flight 169444 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169444/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169412
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169412
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169412
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169412
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169412
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169412
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169412
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169412
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169412
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169412
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169412
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169412
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647

Last test of basis   169444  2022-04-16 01:53:08 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Apr 16 11:45:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 11:45:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306242.521398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfgrF-00076E-V7; Sat, 16 Apr 2022 11:44:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306242.521398; Sat, 16 Apr 2022 11:44:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfgrF-000767-SE; Sat, 16 Apr 2022 11:44:53 +0000
Received: by outflank-mailman (input) for mailman id 306242;
 Sat, 16 Apr 2022 11:44:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfgrE-00075x-5p; Sat, 16 Apr 2022 11:44:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfgrE-0001j0-2q; Sat, 16 Apr 2022 11:44:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfgrD-0006yG-Oj; Sat, 16 Apr 2022 11:44:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfgrD-0008MS-OH; Sat, 16 Apr 2022 11:44:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xs/EtN1cyIMRC7DALQUUxrMY+U1kM82uEssaShtx270=; b=kcgnJ7RP1CzalK9AucH1T6qU7s
	9ob/qEFhnRp76XxZQnFzXFGYFewagVxSFsTw1ab6r8wmF6uclx90OcQR8gBfDulArhnKt35jqzdCv
	r3jLJriJRXG2d4KX2u3se1Maw9/LdQT40f/zQdMtvrd4XTa9Nd4Jnj5UjMDe3LbadWGQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169453-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169453: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 11:44:51 +0000

flight 169453 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169453/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  434 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 12:31:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 12:31:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306255.521409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfhZz-0003yK-Jk; Sat, 16 Apr 2022 12:31:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306255.521409; Sat, 16 Apr 2022 12:31:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfhZz-0003yD-Gv; Sat, 16 Apr 2022 12:31:07 +0000
Received: by outflank-mailman (input) for mailman id 306255;
 Sat, 16 Apr 2022 12:31:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfhZz-0003y3-2D; Sat, 16 Apr 2022 12:31:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfhZy-0002Ua-Qg; Sat, 16 Apr 2022 12:31:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfhZy-0007xf-Ft; Sat, 16 Apr 2022 12:31:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfhZy-00039h-FS; Sat, 16 Apr 2022 12:31:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lXVaseepXgjiRlK8EC6guZooKEgKof5PbUip5PSksl0=; b=cyBMm2A6Vk3BCe1PSez6zEQIyC
	VYbbQVvUe3oWTu280QLVZNLjEtkRVFDMhQICz1IiHcn18C4COEmcKWp2fez9ZdPBH1oKJnrvNFifV
	he3bxBLK8+tWhQTy6uPhg9vDibfGYy2tqVTFvTM1H1gyLLQTNgwKRwxNt7pYeuxFBA50=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169454-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169454: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 12:31:06 +0000

flight 169454 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169454/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  435 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 13:30:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 13:30:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306268.521420 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfiUu-0001BB-0Z; Sat, 16 Apr 2022 13:29:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306268.521420; Sat, 16 Apr 2022 13:29:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfiUt-0001B4-Tq; Sat, 16 Apr 2022 13:29:55 +0000
Received: by outflank-mailman (input) for mailman id 306268;
 Sat, 16 Apr 2022 13:29:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfiUt-0001Au-BI; Sat, 16 Apr 2022 13:29:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfiUt-0003TB-82; Sat, 16 Apr 2022 13:29:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfiUs-0000oT-Su; Sat, 16 Apr 2022 13:29:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfiUs-0008S8-SS; Sat, 16 Apr 2022 13:29:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GSJTl4qVamX6qWDjmCnrer7QCpyrddaUO/jYDOFwS6Q=; b=ZSk6bQElVzFK45Ld8gDRcZtL86
	aKPS+KVNpvCGQMuZ6jgq6R+cVGlMk06UAiQ+NGE0Z9vIQibSDO7H1vHZxPxsn/eHB0YdTuXfuDM2P
	+cT/L4YymW864iie9t0w0w4qpzpdQ9s815Qs5/cv8S82eAHTIXjtCDqimpLNf39dPDYo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169455-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169455: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 13:29:54 +0000

flight 169455 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169455/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  436 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 13:32:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 13:32:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306276.521432 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfiWy-0002cA-EN; Sat, 16 Apr 2022 13:32:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306276.521432; Sat, 16 Apr 2022 13:32:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfiWy-0002c2-B9; Sat, 16 Apr 2022 13:32:04 +0000
Received: by outflank-mailman (input) for mailman id 306276;
 Sat, 16 Apr 2022 13:32:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ga0E=U2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nfiWw-0002bq-NE
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 13:32:02 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98dce0fc-bd89-11ec-a405-831a346695d4;
 Sat, 16 Apr 2022 15:32:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1080E215FD;
 Sat, 16 Apr 2022 13:32:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B164913A5D;
 Sat, 16 Apr 2022 13:32:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Exg2KVDFWmJCEQAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 16 Apr 2022 13:32:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98dce0fc-bd89-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650115921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=i2w0dpKapFbBkdrJeQ76OphKXR6E2VibjK4wYA3Bo4o=;
	b=babyk9Jk7OhmYmEzg7NumvI4PobmqO3xGmdru2QeTdz1GuPAJRi11orJazrXE/W713tbIO
	ZV7yqI9vMa2y0RrHjIsIRXW8xneVPhntiD1fYwqeG3SpMVFjsootepnXjNTspGwo8UUopn
	tm8Ok3+/9ixVsA0j8bU9gFKA1ogohpE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Cheyenne Wills <cheyenne.wills@gmail.com>
Subject: [PATCH] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Date: Sat, 16 Apr 2022 15:31:58 +0200
Message-Id: <20220416133158.16162-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

A hypervisor built without CONFIG_GDBSX will crash in case the
XEN_DOMCTL_gdbsx_guestmemio domctl is being called, as the call will
end up in iommu_do_domctl() with d == NULL:

(XEN) CPU:    6
(XEN) RIP:    e008:[<ffff82d040269984>] iommu_do_domctl+0x4/0x30
(XEN) RFLAGS: 0000000000010202   CONTEXT: hypervisor (d0v0)
(XEN) rax: 00000000000003e8   rbx: ffff830856277ef8   rcx: ffff830856277fff
...
(XEN) Xen call trace:
(XEN)    [<ffff82d040269984>] R iommu_do_domctl+0x4/0x30
(XEN)    [<ffff82d04035cd5f>] S arch_do_domctl+0x7f/0x2330
(XEN)    [<ffff82d040239e46>] S do_domctl+0xe56/0x1930
(XEN)    [<ffff82d040238ff0>] S do_domctl+0/0x1930
(XEN)    [<ffff82d0402f8c59>] S pv_hypercall+0x99/0x110
(XEN)    [<ffff82d0402f5161>] S arch/x86/pv/domain.c#_toggle_guest_pt+0x11/0x90
(XEN)    [<ffff82d040366288>] S lstar_enter+0x128/0x130
(XEN)
(XEN) Pagetable walk from 0000000000000144:
(XEN)  L4[0x000] = 0000000000000000 ffffffffffffffff
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 6:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=0000]
(XEN) Faulting linear address: 0000000000000144

Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
Fixes: e726a82ca0dc ("xen: make gdbsx support configurable")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/common/domctl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 57135d4478..5602dc6b34 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -308,7 +308,9 @@ long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
         if ( op->domain == DOMID_INVALID )
         {
     case XEN_DOMCTL_createdomain:
+#ifdef CONFIG_GDBSX
     case XEN_DOMCTL_gdbsx_guestmemio:
+#endif
             d = NULL;
             break;
         }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Apr 16 13:42:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 13:42:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306060.521443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfihP-0004A4-En; Sat, 16 Apr 2022 13:42:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306060.521443; Sat, 16 Apr 2022 13:42:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfihP-00049x-Ax; Sat, 16 Apr 2022 13:42:51 +0000
Received: by outflank-mailman (input) for mailman id 306060;
 Sat, 16 Apr 2022 02:29:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1IJx=U2=kernel.org=chao@srs-se1.protection.inumbo.net>)
 id 1nfYBN-00043Q-El
 for xen-devel@lists.xenproject.org; Sat, 16 Apr 2022 02:29:05 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fb83e679-bd2c-11ec-8fbe-03012f2f19d4;
 Sat, 16 Apr 2022 04:29:04 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2FF20B82E4A;
 Sat, 16 Apr 2022 02:29:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49BEAC385A9;
 Sat, 16 Apr 2022 02:28:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb83e679-bd2c-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650076142;
	bh=64fC476XAzTfqTSPn+hnDLb+pMKn+pGg/cu9T2ZYoeo=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=YR2swQd5bHjAFWTiUHuzi2CBAoBviVOC618ZH6KrZjKGz54+nb14CQuuZA/rg7rT4
	 HOUGUM1/um4+uLyDQbz+2PZe7eFGngBlsNfmtF55BEnpI8SeGgAW1TB9RPEF0hZ/gu
	 wadS+mRuD6cvw4fVgc6pYN09yVoj6blhm7pLMwx6SJQPqerB95uO3eDsfGVZkI1tAT
	 ypjbfbxn7+bT/FWjnusepnTR0gEoGRsC/NgAvlwAmFKhGsjLJGRbec9W3gsrNwS1xO
	 /N5W0GD6Xr6BMAFslHSxbnYfv+w/HrqJWAmw3dvOKrGV8WDuaNAVrqQjvW1ASku3np
	 CHDdJgFxl65YQ==
Message-ID: <ffa14a07-b8f9-828e-97bc-cf7a2099bab5@kernel.org>
Date: Sat, 16 Apr 2022 10:28:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [f2fs-dev] [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from
 REQ_OP_DISCARD
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org,
 virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
 dm-devel@redhat.com, target-devel@vger.kernel.org,
 linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
 linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
 linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
 xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
 linux-um@lists.infradead.org, nbd@other.debian.org,
 linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
 David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
 ceph-devel@vger.kernel.org, Coly Li <colyli@suse.de>,
 Ryusuke Konishi <konishi.ryusuke@gmail.com>, linux-raid@vger.kernel.org,
 "Martin K . Petersen" <martin.petersen@oracle.com>,
 linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
 linux-xfs@vger.kernel.org,
 =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= <christoph.boehmwalder@linbit.com>,
 ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
 ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-27-hch@lst.de>
From: Chao Yu <chao@kernel.org>
In-Reply-To: <20220415045258.199825-27-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2022/4/15 12:52, Christoph Hellwig wrote:
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint.  Fully split the limits and helper
> infrastructure to make the separation more clear.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
> Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> [nifs2]
> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org> [f2fs]
> Acked-by: Coly Li <colyli@suse.de> [bcache]
> Acked-by: David Sterba <dsterba@suse.com> [btrfs]

For f2fs part,

Acked-by: Chao Yu <chao@kernel.org>

Thanks,


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 14:01:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 14:01:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306286.521454 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfiz8-0006dY-T7; Sat, 16 Apr 2022 14:01:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306286.521454; Sat, 16 Apr 2022 14:01:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfiz8-0006dR-Q8; Sat, 16 Apr 2022 14:01:10 +0000
Received: by outflank-mailman (input) for mailman id 306286;
 Sat, 16 Apr 2022 14:01:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfiz7-0006dH-DQ; Sat, 16 Apr 2022 14:01:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfiz7-00046p-Ar; Sat, 16 Apr 2022 14:01:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfiz7-0001Tj-23; Sat, 16 Apr 2022 14:01:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfiz7-0007WI-1d; Sat, 16 Apr 2022 14:01:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lOmwKRP1bzzb7IPBjKHGcTBT5J11BiQR9Z+DtINC8YQ=; b=aUtLORPlINlakV3p2R6j1PblRe
	QQCg8AlnXbXu6dcs+99gtIrqhVh+agFau/9d9V/2P4dAdeR3fSyuBzkgyCkApz2SH9vn1KSThbQqz
	m0XehdOP7ktMwkU9XWtq5LSWc+0w4mYM+2KLiExs6n0/CNF32SdsHgIv9WneOVMynMgo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169456-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169456: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 14:01:09 +0000

flight 169456 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169456/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  437 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 14:55:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 14:55:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306298.521465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfjpS-0003hu-Vp; Sat, 16 Apr 2022 14:55:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306298.521465; Sat, 16 Apr 2022 14:55:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfjpS-0003hn-RA; Sat, 16 Apr 2022 14:55:14 +0000
Received: by outflank-mailman (input) for mailman id 306298;
 Sat, 16 Apr 2022 14:55:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfjpQ-0003hd-NH; Sat, 16 Apr 2022 14:55:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfjpQ-0004zH-Kr; Sat, 16 Apr 2022 14:55:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfjpQ-0002eg-6i; Sat, 16 Apr 2022 14:55:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfjpQ-0002lz-6E; Sat, 16 Apr 2022 14:55:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=APSMZsYHcT4V4TTLhPW2yt+VNVyn7gr38Rol79VfHAs=; b=ATleZBw/TmHQcF2cSds4r70gLn
	dzenm12t13pbd8LSKq9n3IZ+ARd7fWlQY1ZkfzVFD01D2Hwjh1h3F4f3T4nkdqSdBKMDxnYt5UPoR
	vSi3r1RERQYZx8qYrykuN0OBTlvP7ZoM0yZBOw8xWmwX51hDQJaKCd5B741ZMsnQ8tqw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169457-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169457: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 14:55:12 +0000

flight 169457 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169457/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  438 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 15:44:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 15:44:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306308.521476 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfkbH-0000c5-Ke; Sat, 16 Apr 2022 15:44:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306308.521476; Sat, 16 Apr 2022 15:44:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfkbH-0000by-Hh; Sat, 16 Apr 2022 15:44:39 +0000
Received: by outflank-mailman (input) for mailman id 306308;
 Sat, 16 Apr 2022 15:44:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfkbH-0000bo-1Z; Sat, 16 Apr 2022 15:44:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfkbG-0005pw-TF; Sat, 16 Apr 2022 15:44:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfkbG-0003j0-Ee; Sat, 16 Apr 2022 15:44:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfkbG-0005dC-ED; Sat, 16 Apr 2022 15:44:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aQxIwCscMMR/nqtPHsK6IZjsfbYfAoPk7Efzy72CxGw=; b=hD9p07wVnwlhyTuXHkGD+UAtgK
	7mo0utth307zwDvtbfNWiBstQC473UKpXj/oXsjVQutm9XwqCdrkWRts2ydMQJ1s3RaUFaaX2+aX3
	K87+m0rNWFX+JMAO3FqD+lKuUgK1mOm/2eR6mPYADzR6b2T+sbbSrjLJPOVlaMLHNDbM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169458-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169458: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 15:44:38 +0000

flight 169458 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169458/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  439 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 16:45:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 16:45:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306319.521487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nflXe-0007Qo-8K; Sat, 16 Apr 2022 16:44:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306319.521487; Sat, 16 Apr 2022 16:44:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nflXe-0007Qh-5R; Sat, 16 Apr 2022 16:44:58 +0000
Received: by outflank-mailman (input) for mailman id 306319;
 Sat, 16 Apr 2022 16:44:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nflXd-0007QX-96; Sat, 16 Apr 2022 16:44:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nflXd-0007OZ-3W; Sat, 16 Apr 2022 16:44:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nflXc-00051Y-PB; Sat, 16 Apr 2022 16:44:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nflXc-0002Vc-Oj; Sat, 16 Apr 2022 16:44:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ptlazQh2VVjNd8g5fZZGwjUrSPk+8zgbKaJUnLsLJy4=; b=yjiPQ2HiwhKnUDjt2G1R8NvunB
	1GSg1XChRHNHu6lM09JypghZTUvCcXC9OGa1s/STC64N5lRsGb2+WMIbLRgAyKekxvvWCMLxY0FG0
	uuiVifDroXBZC1ae/JQHOzcU+R5ZjZFEdWv+y3k3XzimpNiXjmh2rYDmaBbTWCPP5o5U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169459-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169459: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 16:44:56 +0000

flight 169459 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169459/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  440 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 17:30:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 17:30:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306329.521498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfmFH-0003oZ-Q2; Sat, 16 Apr 2022 17:30:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306329.521498; Sat, 16 Apr 2022 17:30:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfmFH-0003o5-Mq; Sat, 16 Apr 2022 17:30:03 +0000
Received: by outflank-mailman (input) for mailman id 306329;
 Sat, 16 Apr 2022 17:30:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfmFG-0003Zi-BO; Sat, 16 Apr 2022 17:30:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfmFG-00089e-AE; Sat, 16 Apr 2022 17:30:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfmFF-0005zw-VV; Sat, 16 Apr 2022 17:30:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfmFF-0005RF-V1; Sat, 16 Apr 2022 17:30:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Sqb/QHV9Y6s/xKt3zViRtJ7EY0xgq9ujW3e+UbIuM6w=; b=uPIFOmV/LdJlbQWixbtYZt8MMF
	27DDq71Dv2nsAmrtahV3kVX7WbxbB9BiogaNwCr+lwI+v2UiULir6r4w3JETrWanRqfGmsG+vxML5
	aBOcMsTFeiZFUmu0M7523Vt3LkGFFyJaHbWo2J/bHpWlJwrMwjTWglEMYAW1f7+6Gs9k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169460-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169460: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 17:30:01 +0000

flight 169460 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169460/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  441 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 18:00:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 18:00:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306340.521508 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfmi6-00071P-41; Sat, 16 Apr 2022 17:59:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306340.521508; Sat, 16 Apr 2022 17:59:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfmi6-00071I-15; Sat, 16 Apr 2022 17:59:50 +0000
Received: by outflank-mailman (input) for mailman id 306340;
 Sat, 16 Apr 2022 17:59:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfmi4-000717-AN; Sat, 16 Apr 2022 17:59:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfmi4-0000Cg-8i; Sat, 16 Apr 2022 17:59:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfmi3-0006dn-QJ; Sat, 16 Apr 2022 17:59:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfmi3-0004J2-Pp; Sat, 16 Apr 2022 17:59:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sILLsUobBy4+PfGqYsX6RBeSTx7GJ2zu3KslXbpsFp4=; b=dpivE/pQbW9M3x+kfZu8kG3Eu+
	N5v8xVOF1ku6cY+aiLTYHd8CaosMbrNPXLIBS/3FxAbXNB8c3zCJezl08x5iE70re1HsJbj2FFjFE
	+MCq64Pw6UEWriAMDX6lPTC5bjLJhTwLgmiNKsYOR2pcX7TnZdHdLvicmF1qWpiU7tLk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169461-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169461: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 17:59:47 +0000

flight 169461 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169461/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  442 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 18:56:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 18:56:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306352.521520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfnb7-00057G-VW; Sat, 16 Apr 2022 18:56:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306352.521520; Sat, 16 Apr 2022 18:56:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfnb7-000579-R2; Sat, 16 Apr 2022 18:56:41 +0000
Received: by outflank-mailman (input) for mailman id 306352;
 Sat, 16 Apr 2022 18:56:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfnb6-00056y-8G; Sat, 16 Apr 2022 18:56:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfnb6-0001Ee-6Q; Sat, 16 Apr 2022 18:56:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfnb5-0007sg-Pj; Sat, 16 Apr 2022 18:56:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfnb5-0000VT-PF; Sat, 16 Apr 2022 18:56:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GXosAbE8IHox1GevvP0AjB79eA0Rk2P9lSO7Fn87nsY=; b=PKKhrdYICMtH0pmVlZuB/nY7HY
	A2XJLsnCNEdtPdJogD4KKWYBt9s7JuHPwzk0MlQf6RToqiv3e1lCWKnj6qD7ZxGbi6YRAmlBQUpyo
	FUWwTLUV/6ESxMWEyaZRXJlefDYS7weUdUcB4+XW7XCFiw/FMkPXEbfgj29robptpH1A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169462-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169462: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 18:56:39 +0000

flight 169462 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169462/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  443 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 19:45:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 19:45:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306362.521530 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfoLg-0001z7-GN; Sat, 16 Apr 2022 19:44:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306362.521530; Sat, 16 Apr 2022 19:44:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfoLg-0001z0-DX; Sat, 16 Apr 2022 19:44:48 +0000
Received: by outflank-mailman (input) for mailman id 306362;
 Sat, 16 Apr 2022 19:44:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfoLf-0001yq-Gt; Sat, 16 Apr 2022 19:44:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfoLf-00026O-Dr; Sat, 16 Apr 2022 19:44:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfoLf-0000T8-1q; Sat, 16 Apr 2022 19:44:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfoLf-0002d1-1N; Sat, 16 Apr 2022 19:44:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7DEddbR8zbpg1uAqjTwZ3hucKzhzqAYMY5qr5RXycWo=; b=J5NrC3Axt0ikyYP2KnLyMe139p
	1JKGAwb9PTE+0OWSaOuzTS/B/2YhdU2Se9cShx4YdqXbcSBnY/rOytDgj/6yDnJMq44sua+uHoP1e
	Z1YBygX8zpKpUOGW6O82T/q7iSWu+ZFFU8Wh5HOMapoC5AzIMTPTf9YY8WfuJkGnb8uI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169463-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169463: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 19:44:47 +0000

flight 169463 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169463/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  444 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 20:30:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 20:30:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306371.521542 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfp3J-0006VS-1E; Sat, 16 Apr 2022 20:29:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306371.521542; Sat, 16 Apr 2022 20:29:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfp3I-0006VL-TJ; Sat, 16 Apr 2022 20:29:52 +0000
Received: by outflank-mailman (input) for mailman id 306371;
 Sat, 16 Apr 2022 20:29:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfp3H-0006VA-Jt; Sat, 16 Apr 2022 20:29:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfp3H-00035t-HT; Sat, 16 Apr 2022 20:29:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfp3H-0001SP-5d; Sat, 16 Apr 2022 20:29:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfp3H-0005YE-5A; Sat, 16 Apr 2022 20:29:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8YIx8v2q9b8OLSMXhMu1COwopnW+/QTJnhkhIkeinpc=; b=nFwt+YHsZTs0zoUbDBKN/piyXr
	2VPM7E61Vk3xDVSF6aWUfVrvP26T8QUQWK8G+XF4ly30nyuC3klceFdUD7C7OUhgjv0UoHzgB5oUg
	pD6LdgFiO5F8daeg+6NaUYGFUE3o+yCdsHoYuC4PpEaF/bHx/Iyihh2ITK+NzbpojI5c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169464-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169464: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 20:29:51 +0000

flight 169464 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169464/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  445 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   21 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 21:28:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 21:28:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306386.521553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfpxR-0004Pc-IF; Sat, 16 Apr 2022 21:27:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306386.521553; Sat, 16 Apr 2022 21:27:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfpxR-0004PV-FF; Sat, 16 Apr 2022 21:27:53 +0000
Received: by outflank-mailman (input) for mailman id 306386;
 Sat, 16 Apr 2022 21:27:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfpxQ-0004PL-Oj; Sat, 16 Apr 2022 21:27:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfpxQ-0004ED-L3; Sat, 16 Apr 2022 21:27:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfpxQ-0002i7-3t; Sat, 16 Apr 2022 21:27:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfpxQ-00038b-3P; Sat, 16 Apr 2022 21:27:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YHX0K2m2RrjdPYspcpYxWkoCZUGVKolPt8GQogps97w=; b=BWG+Pk1wM6vwcJN9ihnzJg/JdF
	NdscrRQgafrr1DoV7cAPsUV61IFMSgFxld6j2eUTE3E8IBA4Shk6/h5bBkRbXy8Mrz/k1VlukCJ4u
	3iNvY/oMZ6a27zxrvZYs8MF9luB4xZtZsUof6hDEyr0lbd6MltERl+2xM0AdSdtAplIQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169465-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169465: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 21:27:52 +0000

flight 169465 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169465/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  446 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   22 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 16 22:51:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Apr 2022 22:51:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306404.521563 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfrGS-0004xn-KW; Sat, 16 Apr 2022 22:51:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306404.521563; Sat, 16 Apr 2022 22:51:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfrGS-0004xg-Hc; Sat, 16 Apr 2022 22:51:36 +0000
Received: by outflank-mailman (input) for mailman id 306404;
 Sat, 16 Apr 2022 22:51:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfrGR-0004xW-8N; Sat, 16 Apr 2022 22:51:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfrGR-0005sI-0d; Sat, 16 Apr 2022 22:51:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfrGQ-0006BA-HE; Sat, 16 Apr 2022 22:51:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfrGQ-0007xy-Gl; Sat, 16 Apr 2022 22:51:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JmreTsavvXcWIcxa+Bb8M7QRvCyN+sQdNLlAxyPTQ6I=; b=nWxCTFISe81F4fM1IdHIZzuOKz
	PdNKuRG2qAfGS0acfRIPjk6s0HjDW/hS8PyBSNOqc3l2Tbsu3iQuLaQntnb9xkAzy8FbLAi9jaFD5
	Sf43d7pE5jpcUfCpNxf23/4vuCBzYKKDuTR3NTJxfA/YIBCrFUEZN+i4qmF21Inmr6rQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169467-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169467: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Apr 2022 22:51:34 +0000

flight 169467 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169467/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  447 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   23 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 00:04:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 00:04:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306418.521575 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfsOV-0004WW-2c; Sun, 17 Apr 2022 00:03:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306418.521575; Sun, 17 Apr 2022 00:03:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfsOU-0004WP-Vz; Sun, 17 Apr 2022 00:03:58 +0000
Received: by outflank-mailman (input) for mailman id 306418;
 Sun, 17 Apr 2022 00:03:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfsOT-0004WF-2Y; Sun, 17 Apr 2022 00:03:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfsOS-0007xC-Vd; Sun, 17 Apr 2022 00:03:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfsOS-0000x1-KS; Sun, 17 Apr 2022 00:03:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfsOS-0005WP-K0; Sun, 17 Apr 2022 00:03:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IOnjvfi7uxDWNYFz/NqRS5E7CnjVwfx5j5VBuLVH7HA=; b=cBbDoNr/MUgm6ZwoLs5JJv22Ta
	q9n/TxngVFsV/m0MLocHMrpu7oyVwBJvo+UXXxb7DBY3R1Qr9gWs20TopdhqHy4AH3Dnq1TdUSEgk
	NVmUqgVjSMFTYNuotsavg//Tg5C36Ay125Q5ossRwelgD/UYNnKpPovyeqqHoVBUrHXs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169468-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169468: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 00:03:56 +0000

flight 169468 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169468/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  448 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   24 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 00:36:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 00:36:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306431.521585 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfsti-0007yq-IR; Sun, 17 Apr 2022 00:36:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306431.521585; Sun, 17 Apr 2022 00:36:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfsti-0007yj-Fa; Sun, 17 Apr 2022 00:36:14 +0000
Received: by outflank-mailman (input) for mailman id 306431;
 Sun, 17 Apr 2022 00:36:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfsti-0007yJ-1O; Sun, 17 Apr 2022 00:36:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfsth-000085-Q6; Sun, 17 Apr 2022 00:36:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfsth-00020O-Cx; Sun, 17 Apr 2022 00:36:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfsth-0003Ef-CQ; Sun, 17 Apr 2022 00:36:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=u9LkGIj/oESmlAWhNfwh5eGY6EpULe0bYQ5iR/McVbY=; b=QLdQyNPWNUhEnm9vupj8F4cCRo
	TLfQ1nasvZ585nXs7GfQRpJrEPKMHxM0PyaWSNWzONrwGMkmJ9gJkAHNIUqxQ+MSflsIux/HaPoYT
	lYbMf3nt1FVcBA1a6R5I6dAjksIfVlqFuMFSuhOLUmXzwoS9qc3pQBfb3ci59mfvTBms=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169469-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169469: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 00:36:13 +0000

flight 169469 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169469/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  449 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    0 days   25 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 01:07:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 01:07:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306446.521596 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nftO5-0001ON-74; Sun, 17 Apr 2022 01:07:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306446.521596; Sun, 17 Apr 2022 01:07:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nftO5-0001OG-40; Sun, 17 Apr 2022 01:07:37 +0000
Received: by outflank-mailman (input) for mailman id 306446;
 Sun, 17 Apr 2022 01:07:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nftO3-0001O6-TO; Sun, 17 Apr 2022 01:07:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nftO3-00073O-QE; Sun, 17 Apr 2022 01:07:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nftO3-0002yX-HH; Sun, 17 Apr 2022 01:07:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nftO3-0007iV-Gl; Sun, 17 Apr 2022 01:07:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=A12YuM0rmrOhgIx3o/fYizLBJry9YgqRBevcgw8tZio=; b=HEPc3N3AdkZCQqjQUcxFFDntol
	dPZXkoaPzTRHws+vm2XmWzxqMPlmKkFjmzXW85EDoIxZFwdKcFBvXCaXtDw0Z+pGj7Ygq6ugRz6nF
	ErgtqFt1uS77/l3Ky8ncHeyMuRapu9IvpO8pc650yNcj4ANuZqdm1PipsaKak6ErKOOc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169470-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169470: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 01:07:35 +0000

flight 169470 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169470/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   46 days  450 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   26 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 02:25:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 02:25:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306459.521608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfubB-0001W5-14; Sun, 17 Apr 2022 02:25:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306459.521608; Sun, 17 Apr 2022 02:25:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfubA-0001Vx-SX; Sun, 17 Apr 2022 02:25:12 +0000
Received: by outflank-mailman (input) for mailman id 306459;
 Sun, 17 Apr 2022 02:25:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfub9-0001Vn-Ki; Sun, 17 Apr 2022 02:25:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfub9-0000dZ-Jk; Sun, 17 Apr 2022 02:25:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfub9-0004uG-9h; Sun, 17 Apr 2022 02:25:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfub9-0000xW-8Y; Sun, 17 Apr 2022 02:25:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eYZpw2JIpmCnYb5v8kxlLUrGXE3Y5UWijqfkBOdwj2U=; b=WnLxLt5sVb+6tUnmhThG86W2Ii
	f4Kz5vTfFY4GUg7RxO0mwEDq3oG2gECtR7WqYfZ5XoYXu4O9NOcqajBHghySVs0QKDdgtewg2Wqwe
	cm4cCqfucl0B174KU7m6yCNHvASucRsmcVsk57e8/Sdp4+xBYxB3yiJL1VpcnDvGI+gQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169471-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169471: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 02:25:11 +0000

flight 169471 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169471/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  451 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   27 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 03:19:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 03:19:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306470.521619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfvRp-0006vC-5D; Sun, 17 Apr 2022 03:19:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306470.521619; Sun, 17 Apr 2022 03:19:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfvRp-0006v5-23; Sun, 17 Apr 2022 03:19:37 +0000
Received: by outflank-mailman (input) for mailman id 306470;
 Sun, 17 Apr 2022 03:19:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfvRo-0006uv-1L; Sun, 17 Apr 2022 03:19:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfvRn-0001ja-Sr; Sun, 17 Apr 2022 03:19:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfvRn-0007oh-Eo; Sun, 17 Apr 2022 03:19:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfvRn-000311-EO; Sun, 17 Apr 2022 03:19:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jk+VASnSvo0uDruhVhF7TkmW8LDe5lv5x+JzXyVAHKY=; b=GLrwV79NJ7qGVTtOmEgaxHI/5C
	ysumMZ8QX4VUxLwlfO7z6YCstiVDwa6e05RiPGVozoRN26U0ZYn1zdqppLe0BONUdKvK+g9oauJdT
	Jc3UC26HOq10SgK7K2+jjEHHGGkfqlA+XPuYtS7Z23Aqm9NMqhaEroWyh/IVb5N+Thxw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169466-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169466: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=90ea17a9e27b5778ec517efb1ce0b81d36905654
X-Osstest-Versions-That:
    linux=59250f8a7f3a60a2661b84cbafc1e0eb5d05ec9b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 03:19:35 +0000

flight 169466 linux-linus real [real]
flight 169474 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169466/
http://logs.test-lab.xenproject.org/osstest/logs/169474/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-credit2   8 xen-boot            fail pass in 169474-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 169474 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 169474 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169442
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169442
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169442
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169442
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169442
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169442
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169442
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169442
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                90ea17a9e27b5778ec517efb1ce0b81d36905654
baseline version:
 linux                59250f8a7f3a60a2661b84cbafc1e0eb5d05ec9b

Last test of basis   169442  2022-04-16 01:09:41 Z    1 days
Testing same since   169466  2022-04-16 21:09:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ajish Koshy <Ajish.Koshy@microchip.com>
  Bart Van Assche <bvanassche@acm.org>
  Chao Gao <chao.gao@intel.com>
  Chris Leech <cleech@redhat.com>
  Christoph Hellwig <hch@lst.de>
  Douglas Gilbert <dgilbert@interlog.com>
  Jack Wang <jinpu.wang@ionos.com>
  Lee Duncan <lduncan@suse.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Manish Rangankar <mrangankar@marvell.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Mike Christie <michael.christie@oracle.com>
  Viswas G <Viswas.G@microchip.com>
  Yi Zhang <yi.zhang@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   59250f8a7f3a..90ea17a9e27b  90ea17a9e27b5778ec517efb1ce0b81d36905654 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 03:42:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 03:42:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306480.521629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfvo3-0001tP-3F; Sun, 17 Apr 2022 03:42:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306480.521629; Sun, 17 Apr 2022 03:42:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfvo3-0001tI-0K; Sun, 17 Apr 2022 03:42:35 +0000
Received: by outflank-mailman (input) for mailman id 306480;
 Sun, 17 Apr 2022 03:42:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfvo1-0001t8-O3; Sun, 17 Apr 2022 03:42:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfvo1-00029j-MI; Sun, 17 Apr 2022 03:42:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfvo1-0000YK-Ae; Sun, 17 Apr 2022 03:42:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfvo1-0000QG-AA; Sun, 17 Apr 2022 03:42:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CiEltukzcwghQNesPBTLuPagnYPVmEpuk7odXX07/Fs=; b=LGdfkuVZMzr1lTDI8vu3YnFk88
	0bKxLQMMI9IVjHq1vcuiXIuzcaulaIqeuJzx1K1P7cK5xnM62eiHlDFEkD4PfZgvMedtqhd1UbJ/T
	D/IeuENKyeKLB5WZXeTdd/3wQte3kSgoNm2qwxfCsshWXIgPOZSfwIK6VLnrXhuliGS8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169473-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169473: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 03:42:33 +0000

flight 169473 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169473/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  452 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   28 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 05:00:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 05:00:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306491.521641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfx0n-000100-EZ; Sun, 17 Apr 2022 04:59:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306491.521641; Sun, 17 Apr 2022 04:59:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfx0n-0000zt-BO; Sun, 17 Apr 2022 04:59:49 +0000
Received: by outflank-mailman (input) for mailman id 306491;
 Sun, 17 Apr 2022 04:59:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfx0m-0000zj-DV; Sun, 17 Apr 2022 04:59:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfx0m-0003xj-Bo; Sun, 17 Apr 2022 04:59:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfx0l-00048H-Th; Sun, 17 Apr 2022 04:59:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfx0l-0006qr-TD; Sun, 17 Apr 2022 04:59:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QDBQV/YbpLMirqHEYS4tJtbaWUB8r+DrX4QuzerBAQA=; b=qBe0pPpkjoRyOj1Ol/KcpztPS/
	00m760BzrupfOqlQyYqp2erarBw50eV+B+CxdKCTT3SgKYhIbePFxfx7hBLZdZiAbtA2RfrWQLILl
	Fe0nILfApCmDoN4FQ78s1nZ4qJiKIe2geXjUz/O/WEZno2Z2qACY7Ed1N5Afj6v8nLO8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169476-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169476: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 04:59:47 +0000

flight 169476 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169476/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  453 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   29 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 08:05:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 08:05:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306520.521652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfzuB-0003dS-1e; Sun, 17 Apr 2022 08:05:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306520.521652; Sun, 17 Apr 2022 08:05:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nfzuA-0003dL-TP; Sun, 17 Apr 2022 08:05:10 +0000
Received: by outflank-mailman (input) for mailman id 306520;
 Sun, 17 Apr 2022 08:05:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfzu9-0003dB-Px; Sun, 17 Apr 2022 08:05:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfzu9-0008Mr-LE; Sun, 17 Apr 2022 08:05:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nfzu9-0007CW-Ak; Sun, 17 Apr 2022 08:05:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nfzu9-0006AB-AK; Sun, 17 Apr 2022 08:05:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PPUruk7heEOk3dpvEf+arl6ln2sADGThP7fnNQBjt4E=; b=pWlov3F1Krhhk92N1DQ5xIByr8
	vMTmPmlcdAUgFvYkhiJUraoq1EczYiYQeLZB9umNDrIrXXXoitJOa7/jNZDkvT4U8pn2Ya1VjbaGW
	nXmdKaVpzhdIWfzcDckTrXw7dM7RmXtXvr//XDboslmzlxu0gHixV66lcOnKlddBrhfg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169478-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169478: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 08:05:09 +0000

flight 169478 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169478/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  454 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   30 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 08:16:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 08:16:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306529.521663 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng05H-0005E1-61; Sun, 17 Apr 2022 08:16:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306529.521663; Sun, 17 Apr 2022 08:16:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng05H-0005Du-10; Sun, 17 Apr 2022 08:16:39 +0000
Received: by outflank-mailman (input) for mailman id 306529;
 Sun, 17 Apr 2022 08:16:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ljwx=U3=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ng05G-0005Dn-IR
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 08:16:38 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b355ab92-be26-11ec-8fbe-03012f2f19d4;
 Sun, 17 Apr 2022 10:16:37 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6DBB81F756;
 Sun, 17 Apr 2022 08:16:33 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3667D13216;
 Sun, 17 Apr 2022 08:16:33 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id v4REC+HMW2LTXAAAMHmgww
 (envelope-from <jgross@suse.com>); Sun, 17 Apr 2022 08:16:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b355ab92-be26-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650183393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=8hA3P47WmX5/EGYFrm5XFq7kqAZ1F4M1ZIzKycvSpTo=;
	b=o9CfhqReKWVWM271Udk/wEwqeAl4nvA017R8Kqn4LvU5KbDTv58bxQJTwxW4AEW8mE81UB
	gNwJKgLmswA4e/exU6isnZravzoepT3FO4n33kSn8/Cv+sMdiPa4viOh3buEA2fSRfm5W2
	jx9l/HVrSPG5OiTgDV/c0y3en01EPVY=
From: Juergen Gross <jgross@suse.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com
Subject: [GIT PULL] xen: branch for v5.18-rc3
Date: Sun, 17 Apr 2022 10:16:32 +0200
Message-Id: <20220417081632.11230-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Linus,

Please git pull the following tag:

 git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.18-rc3-tag

xen: branch for v5.18-rc3

It contains just a single cleanup patch for the Xen balloon driver.


Thanks.

Juergen

 drivers/xen/balloon.c           | 54 ++++++++++++++++++-----------------------
 drivers/xen/unpopulated-alloc.c | 33 -------------------------
 2 files changed, 23 insertions(+), 64 deletions(-)

Juergen Gross (1):
      xen/balloon: don't use PV mode extra memory for zone device allocations


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 08:28:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 08:28:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306535.521674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng0Gk-0006lu-6d; Sun, 17 Apr 2022 08:28:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306535.521674; Sun, 17 Apr 2022 08:28:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng0Gk-0006ln-3b; Sun, 17 Apr 2022 08:28:30 +0000
Received: by outflank-mailman (input) for mailman id 306535;
 Sun, 17 Apr 2022 08:28:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng0Gi-0006ld-Kr; Sun, 17 Apr 2022 08:28:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng0Gi-0000Km-HK; Sun, 17 Apr 2022 08:28:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng0Gi-0007rB-1O; Sun, 17 Apr 2022 08:28:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng0Gi-0006sN-0y; Sun, 17 Apr 2022 08:28:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TG9RF5e/IKfLD4yI1FxDzDs7RwQTR7E9BfP7t4Ufs2Y=; b=qnmrVXOLB6Rf7rVvCAzcp6AYTo
	3Kk+EmcPSTg/o8s78354PKwJrcePMA9TI1tOVVb8H/0OEwLxEw0lypS4tmn8nwyzG7KaO330W2LWD
	ZuKFKKjcglFPN5ItSGluHlnp/apWya4hhlXOXRPi46hxrTY9S28sT2pWjs1VvXT/3sd0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169472-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169472: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-pvhv2-amd:debian-fixup:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 08:28:28 +0000

flight 169472 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169472/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-pvhv2-amd 13 debian-fixup              fail pass in 169444

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169444
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169444
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169444
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169444
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169444
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169444
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169444
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169444
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169444
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169444
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169444
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169444
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647

Last test of basis   169472  2022-04-17 01:51:51 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 09:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 09:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306546.521685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng0yW-0003h9-RK; Sun, 17 Apr 2022 09:13:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306546.521685; Sun, 17 Apr 2022 09:13:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng0yW-0003h2-NR; Sun, 17 Apr 2022 09:13:44 +0000
Received: by outflank-mailman (input) for mailman id 306546;
 Sun, 17 Apr 2022 09:13:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng0yV-0003gs-Fs; Sun, 17 Apr 2022 09:13:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng0yV-000171-Ct; Sun, 17 Apr 2022 09:13:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng0yV-0000qs-4J; Sun, 17 Apr 2022 09:13:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng0yV-0002rd-3r; Sun, 17 Apr 2022 09:13:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DS47Hi7uRkovrB0zjJS2jHn92mRG5BvAAT3+KwiAOLw=; b=dP39UhamG79m2I25R6lCxyk3aU
	9ouJb1kjC9jiffJpBGnmm3B5Hy2JSsC2TGxceOoifBXu9yR5Z8SrxwBPgUWnV1m9SfQqy83cBp5uc
	rSsVzghpWWW7JSyoVrB7sGiALQ1w9TPbDJ43m5sy7UBqc9zo1V9ZXo7xHmYW0UCqO6uA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169479-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169479: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 09:13:43 +0000

flight 169479 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169479/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  455 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   31 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 09:43:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 09:43:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306557.521695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng1Ql-00077L-0O; Sun, 17 Apr 2022 09:42:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306557.521695; Sun, 17 Apr 2022 09:42:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng1Qk-00077E-Tf; Sun, 17 Apr 2022 09:42:54 +0000
Received: by outflank-mailman (input) for mailman id 306557;
 Sun, 17 Apr 2022 09:42:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TbK7=U3=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1ng1Qj-000778-7M
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 09:42:53 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0601.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::601])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bcfdf7ab-be32-11ec-a405-831a346695d4;
 Sun, 17 Apr 2022 11:42:51 +0200 (CEST)
Received: from AS9P194CA0002.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::7)
 by AS8PR08MB6149.eurprd08.prod.outlook.com (2603:10a6:20b:29d::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Sun, 17 Apr
 2022 09:42:33 +0000
Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46d:cafe::d1) by AS9P194CA0002.outlook.office365.com
 (2603:10a6:20b:46d::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Sun, 17 Apr 2022 09:42:32 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Sun, 17 Apr 2022 09:42:32 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Sun, 17 Apr 2022 09:42:32 +0000
Received: from ff2a2baed506.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 068F7784-F0B5-4D3B-86EA-071BF0C1C555.1; 
 Sun, 17 Apr 2022 09:42:21 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ff2a2baed506.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sun, 17 Apr 2022 09:42:21 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by GV1PR08MB7916.eurprd08.prod.outlook.com
 (2603:10a6:150:8c::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.29; Sun, 17 Apr
 2022 09:42:17 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0%11]) with mapi id 15.20.5164.025; Sun, 17 Apr
 2022 09:42:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bcfdf7ab-be32-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RKm1FiP+IHOUtOp2uEAHl66xiZrEvQsYWNPH0+ljHZg=;
 b=LLJ/wR3ckMofRnVbS4zlFWngW80nY5lI8+6m2BJ0NFuq/qHjrL0M3pajXUqdFPRgniOrqOS6ChTCgowF2ghWlxgYPSC3PsvJGcGVGmlt52pzBwDJYZn9iOdv50xLyJ202QlUEXj5Xz8lFhcLT3r/geQRHEinRKEBTld5Z3+L2IQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 57077541f65d3535
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hbDsUz0hnlrKfNMWejCXcm2AOUjMpPElf3xBLbogyxt3EeHpS6UNPF5+UgMoyVTOtILaa0rWP0D+/kbgDeYpoVclLaIXded7fFJ79VlqWkiV4EfnpDcCbgaFO/Fj4VwcCCFjKdaeJDQAZGUNQrIEfXpSdWHQsO5H/snsG9nluJNrkWgCyCrRgENKirzxee5yCYYeCyBEw/Z2f8VSSJaCOT9Mp1tAcc39/471DqoRhycGkaFAZOtY4LvY96v1YUxKuNMqJw60A5AWnw11SJQzdH3JbgUh8yVKDilowM3BKu64ae3XUYbbZE8txgcoT5SYtwLc7grGzvQE7Bje6UeFiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RKm1FiP+IHOUtOp2uEAHl66xiZrEvQsYWNPH0+ljHZg=;
 b=mT4dkx6/o+iz5ysTx7cZICqmDdN7hC+tiUPI8/cKBSBiDfnprwcQyFBKHFrhapj9uUgwWNzEg5aNKIMvRoJu9STLj8r3pntjoXzxVLBuu9M0IvgNT43HQwYybG7gDYnPGLLQ9J6vcOrSz2iGZRMvWHMIG+lhJSnIZkkbNqC61r5HBZEHd00eJI0ijf7n5YXsuE52YDynxPqZkBolVXeL5YE/fILIORLeI0TifZGKIY0SQrE2vZz0WAB0h1/gX6+uEUsCO6UPCmDcA4nK7jBJdxGNYEzGin1a7ojB6lmRt7RC8NlQ8nhPg9mcPIC5IM41GfoFqBEfCwT8XNfEWi/TKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RKm1FiP+IHOUtOp2uEAHl66xiZrEvQsYWNPH0+ljHZg=;
 b=LLJ/wR3ckMofRnVbS4zlFWngW80nY5lI8+6m2BJ0NFuq/qHjrL0M3pajXUqdFPRgniOrqOS6ChTCgowF2ghWlxgYPSC3PsvJGcGVGmlt52pzBwDJYZn9iOdv50xLyJ202QlUEXj5Xz8lFhcLT3r/geQRHEinRKEBTld5Z3+L2IQ=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Christoph Hellwig <hch@lst.de>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Jan Beulich
	<jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Topic: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Index:
 AQHYTzcUggEUWxM2006iot1qnYxlIKzuW0oAgAFU1ACAADDmgIAApv+AgAC5dQCAAp7ugA==
Date: Sun, 17 Apr 2022 09:42:17 +0000
Message-ID: <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com>
 <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop>
 <8C511888-6183-421E-A4C7-B271DAF46696@arm.com>
 <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de>
 <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: bf9eeb33-2044-4c0d-4c2f-08da20569890
x-ms-traffictypediagnostic:
	GV1PR08MB7916:EE_|VE1EUR03FT012:EE_|AS8PR08MB6149:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB61490AA38F7AC2AA585FB7B9FCF09@AS8PR08MB6149.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 MujaIzEeIDGA35RhYlFuPZyI958+0jjIReIzR9vLTZd79ESPf43wiAAVmipBYZTTIZBUerDgotoJm/1TWoGMEA4aEjj4xfCDsS4sFg6qWLhosuBIO6xPdCM0Aq2zSJWofBMDVoOUWaApnZbJ9UaDRhmswwDFVa+WvPdzQa/Yal7I8RmmGyf3pZgzGva4rh8qarSsoBYWSRYl7pVs/stoJHhd3Vc+Tx6xlGOxnu6GvKPxEWkl4kWBXW0lyk/4LzWkz4syEXsXkCULfqYnPgGqtEqP846y3LaoWZiZ3BcBzCfKxHd4uuF03Xk/BquI9vVoAn6xY5/0MDvWKojCZDUZjQoROIgG7typ9b546CvyHXIAQgl0RQ/X5NvQXml6vV6xx+oNcMbjldgwXzcgg3VRSF0r1PqFUpy4nD9A33HE41AUC5fQSurn0dcNm6CaDa/f2uvE30AHusFJGbthqnyFtuZ4H3hvqdHL/2yD61yT+zZFkl843mRps3iALQBnUXfuR89BPRdeufBI++b/WApMf/ka75d12Kf8waZTrq3W3kHuDLcKL1r5kyHEArIzVWX6cYr6dlNgLbKenpLCuOzNTOojVpMkfycliQMTdo/pAyx+1LmLXTL2l29kaGP7fnTehg4Lv0nkxnQKh+E2FjtutZLSZe6p9e9109No/JrsCE12vFG1q+iSxXMNhLtIw4iZyDZ4D5Us+oNYZn6+8HWOYetZtyEvDjtXlXqUn73Tlw7zxqC9tFdpdPkEUrpuriEj
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(6486002)(8936002)(508600001)(66946007)(86362001)(122000001)(66556008)(66476007)(8676002)(76116006)(64756008)(66446008)(4326008)(2616005)(54906003)(6506007)(33656002)(38100700002)(53546011)(6512007)(36756003)(91956017)(316002)(6916009)(38070700005)(83380400001)(2906002)(71200400001)(186003)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <08F047B6DEB6864782D7AC6BE7D820EB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7916
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c226c0df-73d1-4c31-346b-08da20568f64
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	L+opb2khXPr4n0FKe5o90AtU1C8gXK2kaWji4Gg6KPQqzwTfhFPb+rJ+Vn3u0UbGok2G7VB1cnmymSNJjpZAVCXZvHnH2ieyC2/hQ3v2YUPPDAEDW80Mg8JnteTs0o7JrnDn6WAL88x2IsMJ20dDk3aCjZqqcWMvzjNtJ5z5Ci4bcG5xN3Ho3DJ59SxgRR9QXmVKE07wgWVh36RNqFSK9tnXQx5PuIyn42Qd1aDUbLudM+L7Um95v3lbXdnuR1iDJsUD7CAcbPR/xJocl+uu83hcAo37AnlGK4BYiojYJh6VeCP1YKWgY3dyceIxI6cSnHMjLrV8pS1mN5lVtoX3m4a96xV1yXQCoUdltr+peNBkGFgrVd568B2asNKiWekGDdPCZPD0URyrIerMGQj8MzaX4XF7tnVIP8Pkwz/c/mYEXTqChfay6T2F9quao2eYHhLTMUfDp4ahs689KRPMSSDTiZ6CiGRq9oeIIIBZFWuGgcEb15z5g5dplxcmeiNy++CCjnyf0qdTf9JM6JNf9C1jy8aqXNeX8f+dXdD02vUjfSZ5y42u7Ei9r3BwwjD0rXIGEWoqovvx6qYwsa06fQuY1trrrYTtcq8NhjbF7rcScfFCuk24cuIEiyjlRFmAS6aTmL2LdYs/nOJErF5O+A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(36756003)(54906003)(81166007)(356005)(8936002)(36860700001)(6506007)(33656002)(70586007)(6862004)(5660300002)(26005)(47076005)(70206006)(4326008)(2616005)(83380400001)(8676002)(6512007)(336012)(53546011)(86362001)(82310400005)(316002)(508600001)(6486002)(2906002)(107886003)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2022 09:42:32.3966
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bf9eeb33-2044-4c0d-4c2f-08da20569890
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6149

Hi Stefano,

> On 15 Apr 2022, at 6:40 pm, Stefano Stabellini <sstabellini@kernel.org> w=
rote:
>=20
> On Fri, 15 Apr 2022, Christoph Hellwig wrote:
>> On Thu, Apr 14, 2022 at 01:39:23PM -0700, Stefano Stabellini wrote:
>>> OK, now we know that the code path with Xen is correct and it is the
>>> same code path taken (dma_alloc_direct) as when !CONFIG_XEN and !SMMU.
>>> That is how it should be.
>>>=20
>>> I cannot explain why dma_alloc_direct() would fail when called from
>>> xen_swiotlb_alloc_coherent(), but it would succeed when called from
>>> dma_alloc_attrs() without Xen.
>>>=20
>>> I am not aware of any restrictions that xen or swiotlb-xen would
>>> introduce in that regard. Unless you are just running out of memory
>>> because dom0_mem too low.
>>=20
>> The crash is deep down in the page allocator.  Even if memory was low
>> it should no crash.  So there is some odd interaction between Xen
>> and the page allocator going on.  I think nvme and dma-direct really
>> are only the messenger here.
>=20
>=20
> I cannot think of anything but if that is the case I guess it is more
> likely related to reserved-memory not properly advertised or ACPI tables
> not properly populated.

I am not sure if it is true as we are able to boot with the same reserved m=
emory or
the same ACPI table populated if we boot without swiotlb-xen dma ops.

>=20
>=20
> Rahul,
>=20
> What happens if you boot Linux on Xen with swiotlb-xen disabled?

Linux boots fine without any issue if we disable swiotlb-xen as mentioned b=
elow.
>=20
>=20
> diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
> index 93e87b287556..26d9da58f2c6 100644
> --- a/arch/arm64/mm/dma-mapping.c
> +++ b/arch/arm64/mm/dma-mapping.c
> @@ -51,9 +51,4 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_bas=
e, u64 size,
> 	dev->dma_coherent =3D coherent;
> 	if (iommu)
> 		iommu_setup_dma_ops(dev, dma_base, size);
> -
> -#ifdef CONFIG_XEN
> -	if (xen_initial_domain())
> -		dev->dma_ops =3D &xen_swiotlb_dma_ops;
> -#endif
> }
>=20
>=20

Regards,
Rahul



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 10:17:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 10:17:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306565.521707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng1xe-0002FP-Hf; Sun, 17 Apr 2022 10:16:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306565.521707; Sun, 17 Apr 2022 10:16:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng1xe-0002FI-Cm; Sun, 17 Apr 2022 10:16:54 +0000
Received: by outflank-mailman (input) for mailman id 306565;
 Sun, 17 Apr 2022 10:16:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng1xc-0002F8-Rc; Sun, 17 Apr 2022 10:16:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng1xc-0002Do-Q1; Sun, 17 Apr 2022 10:16:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng1xc-0002Ra-Gw; Sun, 17 Apr 2022 10:16:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng1xc-0001nN-GR; Sun, 17 Apr 2022 10:16:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Hq+E8rqseoldfTCHFh5wBIoQl9EJtNRTOodztasWpK4=; b=h92orpN69fp7w+4g4JKBRIsxsj
	mfLBsJ8s917jOcDlKJkPk4eJEF3cG25M/Vz2ldRAPGIjyA+y4lv+UvyCR8/xkwUE/WUOLv580lblZ
	qzG8Acdxco2piloic8MJCwrBzUq84b7AkZ8rXSZ9UXh4+PUTj5YxkJsrhQKJkrHfFEgQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169480-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169480: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 10:16:52 +0000

flight 169480 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169480/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   47 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  456 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   32 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 10:28:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 10:28:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306574.521717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng28f-0003np-KC; Sun, 17 Apr 2022 10:28:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306574.521717; Sun, 17 Apr 2022 10:28:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng28f-0003ni-Go; Sun, 17 Apr 2022 10:28:17 +0000
Received: by outflank-mailman (input) for mailman id 306574;
 Sun, 17 Apr 2022 10:28:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng28e-0003nY-DI; Sun, 17 Apr 2022 10:28:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng28e-0002P0-A7; Sun, 17 Apr 2022 10:28:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng28d-0002gK-OY; Sun, 17 Apr 2022 10:28:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng28d-0005of-O4; Sun, 17 Apr 2022 10:28:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sO+OjtlOFTx9qk2KNesAscqZ52Pdz2CZrPNqPtpEDtk=; b=h5jh12d4P2hUsP4p53smLwXISM
	CjRrAUXvkvBlSe7PP0D2oDgV6Y79Ppl6UN2Q09ZAqN8evbhDGRW4wBfwqN7xRxF4/Rwa0w4rW64W4
	h5ZcgjZWbRoc1LaMiEH/Wk0xKazRGtW6Fe3jhqGtYKKnuEKPDnoPgx9r+GFCThIp1P6Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169477-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169477: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 10:28:15 +0000

flight 169477 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169477/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  646 days
Failing since        151818  2020-07-11 04:18:52 Z  645 days  627 attempts
Testing same since   169415  2022-04-15 04:18:55 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104670 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 11:07:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 11:07:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306586.521728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng2kY-0008Ei-Sf; Sun, 17 Apr 2022 11:07:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306586.521728; Sun, 17 Apr 2022 11:07:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng2kY-0008Eb-PW; Sun, 17 Apr 2022 11:07:26 +0000
Received: by outflank-mailman (input) for mailman id 306586;
 Sun, 17 Apr 2022 11:07:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng2kX-0008ER-TW; Sun, 17 Apr 2022 11:07:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng2kX-00034X-QF; Sun, 17 Apr 2022 11:07:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng2kX-0003X0-F4; Sun, 17 Apr 2022 11:07:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng2kX-0001R3-Ea; Sun, 17 Apr 2022 11:07:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lBP8qh1EDkhOHMe6pPrQ5kTc37d/Tu0EvcK1kqwIsYo=; b=o5HomhK+7h//eKziotbGPkSYEI
	HDkAQ+RaOeoWUF7fNummfkIOviM/RR7pU+dxTJWUF+cS8Y6Df4skPVV2NyajU1Bw13Ou/PWVR9Z7h
	QZld3QAC4TYkNrIgdv2xBDrOfIcJ6mygrsJheKF1GPt0w1c7YXjL7fOKoqcM2NKY5pfc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169481-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169481: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 11:07:25 +0000

flight 169481 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169481/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  457 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   33 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 12:11:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 12:11:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306600.521740 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng3kR-0006x8-Qj; Sun, 17 Apr 2022 12:11:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306600.521740; Sun, 17 Apr 2022 12:11:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng3kR-0006x1-NJ; Sun, 17 Apr 2022 12:11:23 +0000
Received: by outflank-mailman (input) for mailman id 306600;
 Sun, 17 Apr 2022 12:11:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng3kQ-0006wr-Uz; Sun, 17 Apr 2022 12:11:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng3kQ-00049T-SS; Sun, 17 Apr 2022 12:11:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng3kQ-0004xM-By; Sun, 17 Apr 2022 12:11:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng3kQ-0003LX-BS; Sun, 17 Apr 2022 12:11:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=P95mMrQPc53GxpxoK6HHZwgO5fX2KO8p+5WH1MoK3V0=; b=bYUyZF0RnmadmkDK9cGhIlq0vs
	r+c6Bpk64pc9K6Bl7HqTusWfrb928OdYdPMX9NrKt0BRcwI/s73gxXBzvuHyiDp/RRkmn6e3G/MJe
	b+XKkHTzBx/hLpcc2OEZMzs4S2++l6azQKCUQCYMysLqjwKiH5K/HTKJP6j7uzJd35mk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169482-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169482: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 12:11:22 +0000

flight 169482 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169482/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  458 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   34 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 12:43:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 12:43:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306609.521751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng4Fa-00021E-Bf; Sun, 17 Apr 2022 12:43:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306609.521751; Sun, 17 Apr 2022 12:43:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng4Fa-000217-8f; Sun, 17 Apr 2022 12:43:34 +0000
Received: by outflank-mailman (input) for mailman id 306609;
 Sun, 17 Apr 2022 12:43:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng4FZ-00020x-8C; Sun, 17 Apr 2022 12:43:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng4FZ-0004iB-4P; Sun, 17 Apr 2022 12:43:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng4FY-0005hX-Mr; Sun, 17 Apr 2022 12:43:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng4FY-0002lf-MM; Sun, 17 Apr 2022 12:43:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PNo+bTYSY/4rAngM8hVYOxXlO1qaa0KTVCHTdk6OCuw=; b=BoRlUm7gKyd3EPRHvOkWbiFxGI
	L0o1IJq1p1Vg14u0XCybO2peFD4/vdgGQE/26J2x17p29i4CaYm4cW43Fo37XIND2E3p90CArSqxo
	i9Ks5TndBwOgsx84YJXI6d/TqxvIcChtdpy8om+jQXoskQ/3rZioFwErQl6EZFHpyCzc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169475-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169475: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a2c29ccd9477861b16ddc02c411a6c9665250558
X-Osstest-Versions-That:
    linux=90ea17a9e27b5778ec517efb1ce0b81d36905654
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 12:43:32 +0000

flight 169475 linux-linus real [real]
flight 169483 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169475/
http://logs.test-lab.xenproject.org/osstest/logs/169483/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169483-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 169466

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169466
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169466
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169466
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169466
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169466
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169466
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169466
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169466
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                a2c29ccd9477861b16ddc02c411a6c9665250558
baseline version:
 linux                90ea17a9e27b5778ec517efb1ce0b81d36905654

Last test of basis   169466  2022-04-16 21:09:58 Z    0 days
Testing same since   169475  2022-04-17 03:22:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Sverdlin <alexander.sverdlin@gmail.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Cristian Marussi <cristian.marussi@arm.com>
  David Heidelberg <david@ixit.cz>
  Dongjin Yang <dj76.yang@samsung.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Guenter Roeck <linux@roeck-us.net>
  Heiner Kallweit <hkallweit1@gmail.com>
  Jakub Kicinski <kuba@kernel.org>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Kees Cook <keescook@chromium.org>
  Krzysztof Kozlowski <krzk@kernel.org>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
  Li Yang <leoyang.li@nxp.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Liviu Dudau <liviu.dudau@arm.com>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Mark Brown <broonie@kernel.org>
  Miaoqian Lin <linmq006@gmail.com>
  Nathan Chancellor <nathan@kernel.org>
  Philipp Zabel <p.zabel@pengutronix.de>
  Rob Herring <robh@kernel.org>
  Sameer Pujar <spujar@nvidia.com>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Sherry Sun <sherry.sun@nxp.com>
  Sudeep Holla <sudeep.holla@arm.com>
  Thierry Reding <treding@nvidia.com>
  Thomas Gleixner <tglx@linutronix.de>
  Viresh Kumar <viresh.kumar@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   90ea17a9e27b..a2c29ccd9477  a2c29ccd9477861b16ddc02c411a6c9665250558 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 13:27:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 13:27:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306618.521762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng4w4-0006So-Og; Sun, 17 Apr 2022 13:27:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306618.521762; Sun, 17 Apr 2022 13:27:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng4w4-0006Sh-Kw; Sun, 17 Apr 2022 13:27:28 +0000
Received: by outflank-mailman (input) for mailman id 306618;
 Sun, 17 Apr 2022 13:27:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng4w3-0006SX-JN; Sun, 17 Apr 2022 13:27:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng4w3-0005QE-Gv; Sun, 17 Apr 2022 13:27:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng4w3-0006ei-08; Sun, 17 Apr 2022 13:27:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng4w2-00050F-Vv; Sun, 17 Apr 2022 13:27:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pVvc0fxRj+RYYdAoCLdji0/lLZb4ckNATOQw4GFtKtY=; b=W7HE7VbdsYwKa2pY2l48kb0s0D
	7y9a7Bwf4fuQNOb5UH4PsV8steqloy1Dj6dUYiCqJaw8KfXVaXN80V/Wi1wRAnZDH4hjNzZskPMpq
	APAx1FKjFwPbRWE4pXlkINF2Bz9rkpf/eewkoGmSUZM/weDGINAAdqDjSWwm8/Htq0es=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169484-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169484: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 13:27:26 +0000

flight 169484 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169484/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  459 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   35 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 14:12:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 14:12:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306630.521772 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng5dD-0003RG-A7; Sun, 17 Apr 2022 14:12:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306630.521772; Sun, 17 Apr 2022 14:12:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng5dD-0003R9-75; Sun, 17 Apr 2022 14:12:03 +0000
Received: by outflank-mailman (input) for mailman id 306630;
 Sun, 17 Apr 2022 14:12:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng5dC-0003Qz-AG; Sun, 17 Apr 2022 14:12:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng5dC-0006Fu-9G; Sun, 17 Apr 2022 14:12:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng5dB-0007ce-QV; Sun, 17 Apr 2022 14:12:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng5dB-00065e-Q4; Sun, 17 Apr 2022 14:12:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BuCj2PV/VYqZOqS2vSHUXb2u1W/Yq2AQ3yW4PQ0S0Lo=; b=fn/2cbVy8HxwuPzeSBFFoVpfJj
	xbnhW1zjX5o7O1IwDbZ5zMdSQG2lkaUyt6aFcR2Zpe76rzTjCmKeg62ibB9nwb5oN9dPtJ//ocUwf
	dyGPtz2M1llkczLs3pIXZk79Hd5MdGizN+QgVmM0UilDju8zL7mBfIBKjVNwmZJvRPrQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169485-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169485: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 14:12:01 +0000

flight 169485 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169485/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  460 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   36 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 15:46:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 15:46:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306646.521784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng76F-0004IF-9s; Sun, 17 Apr 2022 15:46:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306646.521784; Sun, 17 Apr 2022 15:46:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng76F-0004I8-6u; Sun, 17 Apr 2022 15:46:07 +0000
Received: by outflank-mailman (input) for mailman id 306646;
 Sun, 17 Apr 2022 15:46:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng76D-0004Hy-Fc; Sun, 17 Apr 2022 15:46:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng76D-0007rF-EX; Sun, 17 Apr 2022 15:46:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng76D-0001D9-55; Sun, 17 Apr 2022 15:46:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng76D-0001Bd-4e; Sun, 17 Apr 2022 15:46:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Oh+9lCKYLHBQpmH5xOVemsh/eOm/vW4jat1hP+PxgeY=; b=m9QOefQE3QLYZGp+r2PpHhFxAr
	cDA86sm6/ZCSah7YEedsI4IBxCihYczoc2TqbQI9eS54ISvmvlDGIjlaDWjtARN3kNVCboCIxyshW
	eqb/4TQ8HBmkMfrPVE8WFxEkUVOo/R05UxGDefrdrFwq7dayQaQP2Yn8c5OK+v6h3zyc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169486-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169486: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 15:46:05 +0000

flight 169486 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169486/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  461 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   37 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 16:57:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 16:57:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306663.521794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng8D8-0003fW-IA; Sun, 17 Apr 2022 16:57:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306663.521794; Sun, 17 Apr 2022 16:57:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng8D8-0003fP-FE; Sun, 17 Apr 2022 16:57:18 +0000
Received: by outflank-mailman (input) for mailman id 306663;
 Sun, 17 Apr 2022 16:57:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng8D7-0003fF-0J; Sun, 17 Apr 2022 16:57:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng8D6-000172-U5; Sun, 17 Apr 2022 16:57:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ng8D6-0002lG-LL; Sun, 17 Apr 2022 16:57:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ng8D6-0001dk-Kq; Sun, 17 Apr 2022 16:57:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=a+ZqBBaqJCElwNLSSudIOGN2DctmW/ll7ZviR6Xvj6M=; b=wg+ZZ/Oo1hDPfDC7oO2MSFND55
	dlDCHLquI4XP97Yo6uNSBlMWGQrhZSizNU9+23FzfxEay/ha/HKq5rI3MckNHkBpZhElDfukOwAD+
	zqQTKbKl0sLSyBpe1n4MFvI2RuG4UJtxLn0OLQ6qOsoB6leI62BZfIje/2vHcB+QUzCE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169487-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169487: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 16:57:16 +0000

flight 169487 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169487/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  462 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   38 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 17:02:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 17:02:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306671.521805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng8IB-0005Aq-5m; Sun, 17 Apr 2022 17:02:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306671.521805; Sun, 17 Apr 2022 17:02:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng8IB-0005Aj-2j; Sun, 17 Apr 2022 17:02:31 +0000
Received: by outflank-mailman (input) for mailman id 306671;
 Sun, 17 Apr 2022 17:02:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V3EG=U3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ng8IA-0005Ad-64
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 17:02:30 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29632672-be70-11ec-a405-831a346695d4;
 Sun, 17 Apr 2022 19:02:28 +0200 (CEST)
Received: by mail-lj1-x236.google.com with SMTP id 17so14630189lji.1
 for <xen-devel@lists.xenproject.org>; Sun, 17 Apr 2022 10:02:28 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 e9-20020a05651c04c900b0024b6ce19ef1sm921681lji.96.2022.04.17.10.02.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 Apr 2022 10:02:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29632672-be70-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=hafAfueljTfqgLafYpJ0VMiQP+fHqJGqkLhjQLTHMfs=;
        b=KZJTT9SaRHmCQskg5KlLXLJayizDmfcXTulKEUTAmG26q9Ke698WoFa1dnScnVYZwM
         FmMTpBuiAZDzjQ6iaOFshvmdkkq9k+WFUSw+l7loDt6ZugMuE7lzvgO6gGUHj0jOL/2I
         iPzmbJTVDbT0pNBr0KOU7sCDqZQ5pLUIAEpisphAyO02bKLkAzoHdCAFGvaCQj6EtLNB
         0rNvP5LejaJ2jOXJ1skyloepvxUjTTN61qIGxiBSo4qfv/aFoGzacNzTFjP8oDN+FQIn
         GuUAweqfRB4d6sfyyomA8t6W41kGI7HkO0bMDKExMbukUQ8NmWQl+1pDJh2eXU81M8lW
         hsvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=hafAfueljTfqgLafYpJ0VMiQP+fHqJGqkLhjQLTHMfs=;
        b=IcGN4CWu/AW4/C1IeRIvCGkGelSXvcl7UFJXP+N7PFkRaOyCx5g7IMpDI2ghO6aMPo
         43sTkewXvZXqYD3W/MeTgt26exFlpoSZe767aC3H7uggeWjU2hXl3KwSrKeiSQoAssx4
         UebKyjteDnZVn8e5xFCDxVOXtstuiLJASujtTR3hMsfUILTDAdmPG0G7HbEtJMktyw6y
         1toef4RmaQjSJPEe9cUJUPfQHzfuuytxcacjX1CL0Fbejq60C8goL2LMbOaAuez9GGyr
         Y/b2ccMRTfpqf4/90ZMgJT8Tp60iGPcC+JtuWZAe5OJBRjtN3FmA/2OY135v1h7ulaz4
         yGSA==
X-Gm-Message-State: AOAM532I38f5wI14XK2b9LjJtkofuojWRpk0OdSOQ6S8k4RXKH8w2BPr
	ueKBS5ep/nojXCQuoFOo/TCtBtpLmQ0=
X-Google-Smtp-Source: ABdhPJx6FibJ/hCfUGzrlPei6jqFjeM4z16w/wWKJHfluEauRsSBrcOz2tinQuqtoorCY4g25STP/w==
X-Received: by 2002:a2e:9c8f:0:b0:24d:ba11:7552 with SMTP id x15-20020a2e9c8f000000b0024dba117552mr1541735lji.260.1650214946667;
        Sun, 17 Apr 2022 10:02:26 -0700 (PDT)
Subject: Re: [RFC PATCH 2/6] virtio: add option to restrict memory access
 under Xen
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 linux-arm-kernel@lists.infradead.org, Christoph Hellwig <hch@infradead.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151235440.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <8a66ad42-a3e7-c29d-7d4e-35766dcccd15@gmail.com>
Date: Sun, 17 Apr 2022 20:02:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204151235440.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 16.04.22 01:01, Stefano Stabellini wrote:


Hello Stefano


> On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Juergen Gross <jgross@suse.com>
>>
>> In order to support virtio in Xen guests add a config option enabling
>> the user to specify whether in all Xen guests virtio should be able to
>> access memory via Xen grant mappings only on the host side.
>>
>> This applies to fully virtualized guests only, as for paravirtualized
>> guests this is mandatory.
>>
>> This requires to switch arch_has_restricted_virtio_memory_access()
>> from a pure stub to a real function on x86 systems (Arm systems are
>> not covered by now).
>>
>> Add the needed functionality by providing a special set of DMA ops
>> handling the needed grant operations for the I/O pages.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>   arch/x86/mm/init.c        |  15 ++++
>>   arch/x86/mm/mem_encrypt.c |   5 --
>>   arch/x86/xen/Kconfig      |   9 +++
>>   drivers/xen/Kconfig       |  20 ++++++
>>   drivers/xen/Makefile      |   1 +
>>   drivers/xen/xen-virtio.c  | 177 ++++++++++++++++++++++++++++++++++++++++++++++
>>   include/xen/xen-ops.h     |   8 +++
>>   7 files changed, 230 insertions(+), 5 deletions(-)
>>   create mode 100644 drivers/xen/xen-virtio.c
>>
>> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
>> index d8cfce2..526a3b2 100644
>> --- a/arch/x86/mm/init.c
>> +++ b/arch/x86/mm/init.c
>> @@ -8,6 +8,8 @@
>>   #include <linux/kmemleak.h>
>>   #include <linux/sched/task.h>
>>   
>> +#include <xen/xen.h>
>> +
>>   #include <asm/set_memory.h>
>>   #include <asm/e820/api.h>
>>   #include <asm/init.h>
>> @@ -1065,3 +1067,16 @@ unsigned long max_swapfile_size(void)
>>   	return pages;
>>   }
>>   #endif
>> +
>> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>> +int arch_has_restricted_virtio_memory_access(void)
>> +{
>> +	if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
>> +		return 1;
>> +	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
>> +		return 1;
> I think these two checks could be moved to a separate function in a Xen
> header, e.g. xen_restricted_virtio_memory_access, and here you could
> just
>
> if (xen_restricted_virtio_memory_access())
>      return 1;

Agree, will do


>
>
>
>> +	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
>> +}
>> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>> +#endif
>> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
>> index 50d2099..dda020f 100644
>> --- a/arch/x86/mm/mem_encrypt.c
>> +++ b/arch/x86/mm/mem_encrypt.c
>> @@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
>>   	print_mem_encrypt_feature_info();
>>   }
>>   
>> -int arch_has_restricted_virtio_memory_access(void)
>> -{
>> -	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
>> -}
>> -EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
>> index 85246dd..dffdffd 100644
>> --- a/arch/x86/xen/Kconfig
>> +++ b/arch/x86/xen/Kconfig
>> @@ -92,3 +92,12 @@ config XEN_DOM0
>>   	select X86_X2APIC if XEN_PVH && X86_64
>>   	help
>>   	  Support running as a Xen Dom0 guest.
>> +
>> +config XEN_PV_VIRTIO
>> +	bool "Xen virtio support for PV guests"
>> +	depends on XEN_VIRTIO && XEN_PV
>> +	default y
>> +	help
>> +	  Support virtio for running as a paravirtualized guest. This will
>> +	  need support on the backend side (qemu or kernel, depending on the
>> +	  virtio device types used).
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index 120d32f..fc61f7a 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -335,4 +335,24 @@ config XEN_UNPOPULATED_ALLOC
>>   	  having to balloon out RAM regions in order to obtain physical memory
>>   	  space to create such mappings.
>>   
>> +config XEN_VIRTIO
>> +	bool "Xen virtio support"
>> +	default n
>> +	depends on VIRTIO && DMA_OPS
>> +	select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>> +	help
>> +	  Enable virtio support for running as Xen guest. Depending on the
>> +	  guest type this will require special support on the backend side
>> +	  (qemu or kernel, depending on the virtio device types used).
>> +
>> +config XEN_HVM_VIRTIO_GRANT
>> +	bool "Require virtio for fully virtualized guests to use grant mappings"
>> +	depends on XEN_VIRTIO && X86_64
>> +	default y
>> +	help
>> +	  Require virtio for fully virtualized guests to use grant mappings.
>> +	  This will avoid the need to give the backend the right to map all
>> +	  of the guest memory. This will need support on the backend side
>> +	  (qemu or kernel, depending on the virtio device types used).
> I don't think we need 3 visible kconfig options for this.
>
> In fact, I would only add one: XEN_VIRTIO. We can have any X86 (or ARM)
> specific dependencies in the "depends" line under XEN_VIRTIO. And I
> don't think we need XEN_HVM_VIRTIO_GRANT as a kconfig option
> necessarely. It doesn't seem like some we want as build time option. At
> most, it could be a runtime option (like a command line) or a debug
> option (like an #define at the top of the source file.)


I don't know what was the initial idea of having and extra 
XEN_HVM_VIRTIO and XEN_PV_VIRTIO options, but taking into the account that
they are only used in arch_has_restricted_virtio_memory_access() 
currently, I share your opinion regarding a single XEN_VIRTIO option.

Looking ahead (including changes in the commit #4), we can imagine the 
resulting option:

config XEN_VIRTIO
     bool "Xen virtio support"
     default n
     depends on VIRTIO && DMA_OPS
     depends on (X86_64 || ARM || ARM64)
     select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
     help
       Enable virtio support for running as Xen guest. Depending on the
       guest type this will require special support on the backend side
       (qemu or kernel, depending on the virtio device types used).


and then arch_has_restricted_virtio_memory_access() per arch:


1. x86:

int arch_has_restricted_virtio_memory_access(void)
{
     return (xen_has_restricted_virtio_memory_access() ||
             cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
}


2. Arm:

int arch_has_restricted_virtio_memory_access(void)
{
     return xen_has_restricted_virtio_memory_access();
}


3. xen.h:

static inline int xen_has_restricted_virtio_memory_access(void)
{
     if (IS_ENABLED(CONFIG_XEN_VIRTIO) && (xen_pv_domain() || 
xen_hvm_domain()))
         return 1;

     return 0;
}


Actually, as domain type on Arm is always XEN_HVM_DOMAIN, we could 
probably have the following on Arm:

int arch_has_restricted_virtio_memory_access(void)
{
     return IS_ENABLED(CONFIG_XEN_VIRTIO);
}

but I would prefer not to diverge and use common 
xen_has_restricted_virtio_memory_access().

Any thoughts?



>
>
>>   endmenu
>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>> index 5aae66e..767009c 100644
>> --- a/drivers/xen/Makefile
>> +++ b/drivers/xen/Makefile
>> @@ -39,3 +39,4 @@ xen-gntalloc-y				:= gntalloc.o
>>   xen-privcmd-y				:= privcmd.o privcmd-buf.o
>>   obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)	+= xen-front-pgdir-shbuf.o
>>   obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)	+= unpopulated-alloc.o
>> +obj-$(CONFIG_XEN_VIRTIO)		+= xen-virtio.o
>> diff --git a/drivers/xen/xen-virtio.c b/drivers/xen/xen-virtio.c
>> new file mode 100644
>> index 00000000..cfd5eda
>> --- /dev/null
>> +++ b/drivers/xen/xen-virtio.c
>> @@ -0,0 +1,177 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/******************************************************************************
>> + * Xen virtio driver - enables using virtio devices in Xen guests.
>> + *
>> + * Copyright (c) 2021, Juergen Gross <jgross@suse.com>
>> + */
>> +
>> +#include <linux/module.h>
>> +#include <linux/dma-map-ops.h>
>> +#include <linux/pci.h>
>> +#include <linux/pfn.h>
>> +#include <linux/virtio_config.h>
>> +#include <xen/xen.h>
>> +#include <xen/grant_table.h>
>> +
>> +#define XEN_GRANT_ADDR_OFF	0x8000000000000000ULL
> NIT: (1ULL << 31)

ok, I assume you meant (1ULL << 63)?


>
>
>> +static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>> +{
>> +	return XEN_GRANT_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
>> +}
>> +
>> +static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>> +{
>> +	return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT);
>> +}
>> +
>> +/*
>> + * DMA ops for Xen virtio frontends.
>> + *
>> + * Used to act as a kind of software IOMMU for Xen guests by using grants as
>> + * DMA addresses.
>> + * Such a DMA address is formed by using the grant reference as a frame
>> + * number and setting the highest address bit (this bit is for the backend
>> + * to be able to distinguish it from e.g. a mmio address).
>> + *
>> + * Note that for now we hard wire dom0 to be the backend domain. In order to
>> + * support any domain as backend we'd need to add a way to communicate the
>> + * domid of this backend, e.g. via Xenstore or via the PCI-device's config
>> + * space.
> I would add device tree as possible way of domid communication

I agree, but changes in the commit #4 (which add DT support and remove 
hardcoded domid 0) render this comment stale. For the next version I 
will squash changes and drop or rephrase this comment.


>
>
>> + */
>> +static void *xen_virtio_dma_alloc(struct device *dev, size_t size,
>> +				  dma_addr_t *dma_handle, gfp_t gfp,
>> +				  unsigned long attrs)
>> +{
>> +	unsigned int n_pages = PFN_UP(size);
>> +	unsigned int i;
>> +	unsigned long pfn;
>> +	grant_ref_t grant;
>> +	void *ret;
>> +
>> +	ret = (void *)__get_free_pages(gfp, get_order(size));
>> +	if (!ret)
>> +		return NULL;
>> +
>> +	pfn = virt_to_pfn(ret);
>> +
>> +	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
>> +		free_pages((unsigned long)ret, get_order(size));
>> +		return NULL;
>> +	}
>> +
>> +	for (i = 0; i < n_pages; i++) {
>> +		gnttab_grant_foreign_access_ref(grant + i, 0,
>> +						pfn_to_gfn(pfn + i), 0);
>> +	}
>> +
>> +	*dma_handle = grant_to_dma(grant);
>> +
>> +	return ret;
>> +}
>> +
>> +static void xen_virtio_dma_free(struct device *dev, size_t size, void *vaddr,
>> +				dma_addr_t dma_handle, unsigned long attrs)
>> +{
>> +	unsigned int n_pages = PFN_UP(size);
>> +	unsigned int i;
>> +	grant_ref_t grant;
>> +
>> +	grant = dma_to_grant(dma_handle);
>> +
>> +	for (i = 0; i < n_pages; i++)
>> +		gnttab_end_foreign_access_ref(grant + i);
>> +
>> +	gnttab_free_grant_reference_seq(grant, n_pages);
>> +
>> +	free_pages((unsigned long)vaddr, get_order(size));
>> +}
>> +
>> +static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_t size,
>> +					       dma_addr_t *dma_handle,
>> +					       enum dma_data_direction dir,
>> +					       gfp_t gfp)
>> +{
>> +	WARN_ONCE(1, "xen_virtio_dma_alloc_pages size %ld\n", size);
>> +	return NULL;
>> +}
>> +
>> +static void xen_virtio_dma_free_pages(struct device *dev, size_t size,
>> +				      struct page *vaddr, dma_addr_t dma_handle,
>> +				      enum dma_data_direction dir)
>> +{
>> +	WARN_ONCE(1, "xen_virtio_dma_free_pages size %ld\n", size);
>> +}
>> +
>> +static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct page *page,
>> +					  unsigned long offset, size_t size,
>> +					  enum dma_data_direction dir,
>> +					  unsigned long attrs)
>> +{
>> +	grant_ref_t grant;
>> +
>> +	if (gnttab_alloc_grant_references(1, &grant))
>> +		return 0;
>> +
>> +	gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page),
>> +					dir == DMA_TO_DEVICE);
>> +	return grant_to_dma(grant) + offset;
>> +}
>> +
>> +static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>> +				      size_t size, enum dma_data_direction dir,
>> +				      unsigned long attrs)
>> +{
>> +	grant_ref_t grant;
>> +
>> +	grant = dma_to_grant(dma_handle);
>> +
>> +	gnttab_end_foreign_access_ref(grant);
>> +
>> +	gnttab_free_grant_reference(grant);
>> +}
>> +
>> +static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist *sg,
>> +				 int nents, enum dma_data_direction dir,
>> +				 unsigned long attrs)
>> +{
>> +	WARN_ONCE(1, "xen_virtio_dma_map_sg nents %d\n", nents);
>> +	return -EINVAL;
>> +}
>> +
>> +static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
>> +				    int nents, enum dma_data_direction dir,
>> +				    unsigned long attrs)
>> +{
>> +	WARN_ONCE(1, "xen_virtio_dma_unmap_sg nents %d\n", nents);
>> +}
> You can implement xen_virtio_dma_map_sg and xen_virtio_dma_unmap_sg
> based on xen_virtio_dma_map_page and xen_virtio_dma_unmap_page, like we
> do in drivers/xen/swiotlb-xen.c.

Good point, thank you, will implement.


>
>
>> +static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask)
>> +{
>> +	return 1;
>> +}
>> +
>> +static const struct dma_map_ops xen_virtio_dma_ops = {
>> +	.alloc = xen_virtio_dma_alloc,
>> +	.free = xen_virtio_dma_free,
>> +	.alloc_pages = xen_virtio_dma_alloc_pages,
>> +	.free_pages = xen_virtio_dma_free_pages,
>> +	.mmap = dma_common_mmap,
>> +	.get_sgtable = dma_common_get_sgtable,
>> +	.map_page = xen_virtio_dma_map_page,
>> +	.unmap_page = xen_virtio_dma_unmap_page,
>> +	.map_sg = xen_virtio_dma_map_sg,
>> +	.unmap_sg = xen_virtio_dma_unmap_sg,
>> +	.dma_supported = xen_virtio_dma_dma_supported,
>> +};
>> +
>> +void xen_virtio_setup_dma_ops(struct device *dev)
>> +{
>> +	dev->dma_ops = &xen_virtio_dma_ops;
>> +}
>> +EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops);
>> +
>> +MODULE_DESCRIPTION("Xen virtio support driver");
>> +MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
>> +MODULE_LICENSE("GPL");
>> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>> index a3584a3..ae3c1bc 100644
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { }
>>   
>>   #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
>>   
>> +#ifdef CONFIG_XEN_VIRTIO
>> +void xen_virtio_setup_dma_ops(struct device *dev);
>> +#else
>> +static inline void xen_virtio_setup_dma_ops(struct device *dev)
>> +{
>> +}
>> +#endif /* CONFIG_XEN_VIRTIO */
>> +
>>   #endif /* INCLUDE_XEN_OPS_H */
>> -- 
>> 2.7.4
>>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 17:24:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 17:24:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306677.521816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng8dA-0007hL-0H; Sun, 17 Apr 2022 17:24:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306677.521816; Sun, 17 Apr 2022 17:24:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng8d9-0007hE-Ti; Sun, 17 Apr 2022 17:24:11 +0000
Received: by outflank-mailman (input) for mailman id 306677;
 Sun, 17 Apr 2022 17:24:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V3EG=U3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ng8d8-0007h8-PV
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 17:24:10 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3117f4e1-be73-11ec-a405-831a346695d4;
 Sun, 17 Apr 2022 19:24:09 +0200 (CEST)
Received: by mail-lj1-x234.google.com with SMTP id n17so9723903ljc.11
 for <xen-devel@lists.xenproject.org>; Sun, 17 Apr 2022 10:24:09 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 o2-20020a056512052200b0047067a6e5d5sm524448lfc.218.2022.04.17.10.24.07
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 Apr 2022 10:24:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3117f4e1-be73-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=BzXYSzvfK+AdGCOQfhtjoV/H2s/prwGV3n0qtSorc04=;
        b=TfLFZImLLGFLitXlcV5CC54oDV7wPZeOc/E2oAolOwNyvhSJHXphZzRM3dpmgyQCRe
         ODu5+qawstLwAF36zv5uxkWthN/ZlZOrbjCYMoCwpDAsndrnK+ej6cNahBLYhNLoef6y
         HxDXOb8x6+XUKiBRtkH9U5lx0lFSfg/W2AGqhAS7h6HYThF9BdulGC9ibWBSuolxF1E0
         Y4FCW/iFqBg3x9L5byXkdwS1MzVqYmaLs0/WNqkLUpfRLWU/WvP1TbUJZrBsaS6jibsY
         0nbYf0kkYmnEpQRsopT0oZlbiK7KPhDsohAdwvHLRkyQYq5YGkwVe/LDNEY9dcO5VVKK
         0v3g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=BzXYSzvfK+AdGCOQfhtjoV/H2s/prwGV3n0qtSorc04=;
        b=W/fbT8OnMccBX3mN8jC3R/UDWbMwcONW7OoymH699ocqn/1kBJpv6Zk625DzSN2j6j
         gvYPU2S52dp276daEb9ce7XJLIfZsCymoO4sEUaJp4N5Ytq+gA5Fx6OMYLuRnHHbrGV7
         pAi01QNLmZ/hbPsg8ET7Ap0dgFGUKPFqbmA2hkg8Rc0K4C7h3FP4L1x2TvY7swegXLZb
         RJuAhJbiUj5IYD7FEBHLeWPByRFcvf06wPCzEaz192bWnd2yxsZ+spdiDQUdfLHh8ane
         qYlF/oVgfCV+rpsn4b0B2gbK7ql+RsJyUu5FoYOQFEIQABivX5JJ5sEdYY0qzfR1x1Fa
         pQlQ==
X-Gm-Message-State: AOAM533s2aQ1qiADCIpWWCtYY3nuDQ9TCH1P4G/oztAA0W9r/rzs5/VL
	n4Q3AGIh0gaG2pRw2yaT0Vk=
X-Google-Smtp-Source: ABdhPJxTemiKeMLlnU7cPGCdgJGGmlp8j7m20rDTsAgzxwVprfeIhsQG7I18pOXBCqf5AZgV84wFEQ==
X-Received: by 2002:a2e:9654:0:b0:24d:b57c:5f29 with SMTP id z20-20020a2e9654000000b0024db57c5f29mr2869471ljh.70.1650216249064;
        Sun, 17 Apr 2022 10:24:09 -0700 (PDT)
Subject: Re: [RFC PATCH 3/6] dt-bindings: xen: Add xen,dev-domid property
 description for xen-virtio layer
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
 Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>,
 Christoph Hellwig <hch@infradead.org>, linux-arm-kernel@lists.infradead.org
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151300130.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <fd3a53da-e3a4-5503-30d7-07b180c6d227@gmail.com>
Date: Sun, 17 Apr 2022 20:24:07 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204151300130.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 16.04.22 01:01, Stefano Stabellini wrote:

Hello Stefano


> On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Introduce Xen specific binding for the virtio-mmio device to be used
>> by Xen virtio support driver in a subsequent commit.
>>
>> This binding specifies the ID of Xen domain where the corresponding
>> device (backend) resides. This is needed for the option to restrict
>> memory access using Xen grant mappings to work.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>>   .../devicetree/bindings/virtio/xen,dev-domid.yaml  | 39 ++++++++++++++++++++++
>>   1 file changed, 39 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
>> new file mode 100644
>> index 00000000..78be993
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml
>> @@ -0,0 +1,39 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/virtio/xen,dev-domid.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Xen specific binding for the virtio device
>> +
>> +maintainers:
>> +  - Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> +
>> +select: true
>> +
>> +description:
>> +  This binding specifies the ID of Xen domain where the corresponding device
>> +  (backend) resides. This is needed for the option to restrict memory access
>> +  using Xen grant mappings to work.
>> +
>> +  Note that current and generic "iommus" bindings are mutually exclusive, since
>> +  the restricted memory access model on Xen behaves as a kind of software IOMMU.
> I don't think that this last statement is necessary or fully accurate, so
> I would remove it.


ok, will remove


> Other than that, this looks good to me.


thank you


>
>
>> +properties:
>> +  xen,dev-domid:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description:
>> +      Should contain the ID of device's domain.
> Maybe better as:
> "The domid (domain ID) of the domain where the device (backend) is running"


ok, will change


>
>
>
>> +additionalProperties: true
>> +
>> +examples:
>> +  - |
>> +    virtio_block@3000 {
>> +            compatible = "virtio,mmio";
>> +            reg = <0x3000 0x100>;
>> +            interrupts = <41>;
>> +
>> +            /* The device is located in Xen domain with ID 1 */
>> +            xen,dev-domid = <1>;
>> +    };
>> -- 
>> 2.7.4
>>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 18:07:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 18:07:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306687.521827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng9Id-0003lN-8Z; Sun, 17 Apr 2022 18:07:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306687.521827; Sun, 17 Apr 2022 18:07:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng9Id-0003lG-5m; Sun, 17 Apr 2022 18:07:03 +0000
Received: by outflank-mailman (input) for mailman id 306687;
 Sun, 17 Apr 2022 18:07:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=frYh=U3=kernel.org=pr-tracker-bot@srs-se1.protection.inumbo.net>)
 id 1ng9Ib-0003lA-Ra
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 18:07:01 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2d496761-be79-11ec-a405-831a346695d4;
 Sun, 17 Apr 2022 20:07:00 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 6A592B80D08;
 Sun, 17 Apr 2022 18:06:59 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPS id 17E76C385A9;
 Sun, 17 Apr 2022 18:06:58 +0000 (UTC)
Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org
 (localhost.localdomain [127.0.0.1])
 by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id
 01666E7399D; Sun, 17 Apr 2022 18:06:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d496761-be79-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650218818;
	bh=S/fuXmDS1XoI+nET+aUSs99FrSJzwjzC004PXgrz5xY=;
	h=Subject:From:In-Reply-To:References:Date:To:Cc:From;
	b=A/TL+RpGdVTybhqLT1+2d/jfJtDuWvJST1gKopqnlLyNpq54UL7wVYwStZWsOEupG
	 rP/Xmj9uOMWB9vQ57HxQp2jQrB7wgmZzzCXaU80OXfpjDI2Wv+rN05cTnqv/BAyWIV
	 TvWW2uh3mFlltkWKaWmKkLGSsumFkjPfHaDsZKMqkm2kYJZbqJsd2I6tkFu6y2tLGQ
	 cmDLI/uzIq2McK7iJnhyoz8wUu9vYpwuAUELjU6KXJmnIeu064VXAiQAGOkYiTax+q
	 8ZeegY/A4prTkubPkSq+1wlx7I6SFSjmHadrw9kW1sWzRbS5sjSKhF2zczZXBrG/GZ
	 HEyQdHpSflY9Q==
Subject: Re: [GIT PULL] xen: branch for v5.18-rc3
From: pr-tracker-bot@kernel.org
In-Reply-To: <20220417081632.11230-1-jgross@suse.com>
References: <20220417081632.11230-1-jgross@suse.com>
X-PR-Tracked-List-Id: <linux-kernel.vger.kernel.org>
X-PR-Tracked-Message-Id: <20220417081632.11230-1-jgross@suse.com>
X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.18-rc3-tag
X-PR-Tracked-Commit-Id: 262fc47ac17461c8cdc71c70aff6c3ea45acb0b9
X-PR-Merge-Tree: torvalds/linux.git
X-PR-Merge-Refname: refs/heads/master
X-PR-Merge-Commit-Id: a1901b464e7e3e28956ae7423db2847dbbfb5be8
Message-Id: <165021881799.30246.5843841963508898915.pr-tracker-bot@kernel.org>
Date: Sun, 17 Apr 2022 18:06:57 +0000
To: Juergen Gross <jgross@suse.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com

The pull request you sent on Sun, 17 Apr 2022 10:16:32 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.18-rc3-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a1901b464e7e3e28956ae7423db2847dbbfb5be8

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 18:21:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 18:21:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306692.521839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng9WZ-00065m-Gc; Sun, 17 Apr 2022 18:21:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306692.521839; Sun, 17 Apr 2022 18:21:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng9WZ-00065f-D6; Sun, 17 Apr 2022 18:21:27 +0000
Received: by outflank-mailman (input) for mailman id 306692;
 Sun, 17 Apr 2022 18:21:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V3EG=U3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ng9WX-00065G-5B
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 18:21:25 +0000
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com
 [2a00:1450:4864:20::22b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2e25090c-be7b-11ec-8fbe-03012f2f19d4;
 Sun, 17 Apr 2022 20:21:22 +0200 (CEST)
Received: by mail-lj1-x22b.google.com with SMTP id w5so1528877lji.4
 for <xen-devel@lists.xenproject.org>; Sun, 17 Apr 2022 11:21:21 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 j17-20020a2e3c11000000b0024d5c9b8d8csm913188lja.67.2022.04.17.11.21.19
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 Apr 2022 11:21:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e25090c-be7b-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=HOTM5tpBYxAb1qtW2MCOB1TQN7ARlsIhllyek+NnKb0=;
        b=klCT/uoPzTl1EgjzQV3oH8Ani6TzcUI1aYpYynSRvEWYqqRCk3Jj1LNk9ZktsbF/i0
         n79fletwteCSJ30Z6u4+dfPXavKY08Xjlm1NUblBXiD8OA12dG6srB9dGE4bVEElY6g9
         4K8EhnEM8U1dhftqZ1vSaxBWtKzg9B7x69yu8AYA9Mue/OVMjGlby7Ap+keAnbYqbh5U
         ub6OC4DabnVDsPmAtDwGqfRCBpkvrzHF1wOACQujG7M5asYiz+MCzcYR2kWvwu2cd9lz
         NeeXAttlwuEvJoxWGwiGpaucZkJrCsbhO9PFumUrgQ8VQLHuB4JwS6zWIvO8/Ah12NSu
         x50A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=HOTM5tpBYxAb1qtW2MCOB1TQN7ARlsIhllyek+NnKb0=;
        b=R+oLpYbC7wsFFYaLRV+9SFIhAFy7ZDST14bCA93GJm2bxuQJomY2Rmutahevb++ZG/
         SIFsM3yfl7DnwYA6DsD+zMS8ulyidZ8yWa1nOI8hCV+BE8oWXWpDWaR7HBuekiTnapzy
         OTdBJPoH2JFUQ7Dl/AaQMHShsG3i/PAY+STCaUsLnb8mci0OKVLeLLFO1JVjGyW2j+8w
         FNoS+MJtjDbyv1TjjZ1VpZpeZ0XRdVrGjuo3K6g9W9/vpshzPUw5QBvFPve4y8SF0dLx
         G9FTZXpjDP2YOZdduzgnfeCbvkhj61wXxgdutDPSg2viUK1shzb/Og60kf6RwWocDRd3
         VptA==
X-Gm-Message-State: AOAM530E8ng22d54I9HPsgVMsktl1LAdQ8DHi90DHyRkzi7sptxuWwnu
	yFobOO6uVdlOcAKRbHSIgzQ=
X-Google-Smtp-Source: ABdhPJzQLr3slVx6P9rGKBRO6Z1L/UfXVkwFnZZYoGy4MSWTfhkB82YDTfnCzZbU0/6f7UzpkBAJ7A==
X-Received: by 2002:a05:651c:54c:b0:249:9d06:24ef with SMTP id q12-20020a05651c054c00b002499d0624efmr5069689ljp.331.1650219680786;
        Sun, 17 Apr 2022 11:21:20 -0700 (PDT)
Subject: Re: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops
 layer
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Russell King <linux@armlinux.org.uk>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151302350.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <84f5264c-6b98-6d56-b7ca-61c19dc502ca@gmail.com>
Date: Sun, 17 Apr 2022 21:21:19 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204151302350.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 16.04.22 01:02, Stefano Stabellini wrote:

Hello Stefano


> On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> In the context of current patch do the following:
>> 1. Update code to support virtio-mmio devices
>> 2. Introduce struct xen_virtio_data and account passed virtio devices
>>     (using list) as we need to store some per-device data
>> 3. Add multi-page support for xen_virtio_dma_map(unmap)_page callbacks
>> 4. Harden code against malicious backend
>> 5. Change to use alloc_pages_exact() instead of __get_free_pages()
>> 6. Introduce locking scheme to protect mappings (I am not 100% sure
>>     whether per-device lock is really needed)
>> 7. Handle virtio device's DMA mask
>> 8. Retrieve the ID of backend domain from DT for virtio-mmio device
>>     instead of hardcoding it.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>>   arch/arm/xen/enlighten.c |  11 +++
>>   drivers/xen/Kconfig      |   2 +-
>>   drivers/xen/xen-virtio.c | 200 ++++++++++++++++++++++++++++++++++++++++++-----
>>   include/xen/xen-ops.h    |   5 ++
>>   4 files changed, 196 insertions(+), 22 deletions(-)
>>
>> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
>> index ec5b082..870d92f 100644
>> --- a/arch/arm/xen/enlighten.c
>> +++ b/arch/arm/xen/enlighten.c
>> @@ -409,6 +409,17 @@ int __init arch_xen_unpopulated_init(struct resource **res)
>>   }
>>   #endif
>>   
>> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>> +int arch_has_restricted_virtio_memory_access(void)
>> +{
>> +	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
>> +		return 1;
> Instead of xen_hvm_domain(), you can just use xen_domain(). Also there
> is no need for the #ifdef
> CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, given that:
>
> CONFIG_XEN_HVM_VIRTIO_GRANT depends on XEN_VIRTIO which selects
> ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS


Yes, but please see my comments in commit #2 regarding 
CONFIG_XEN_HVM_VIRTIO_GRANT option and 
arch_has_restricted_virtio_memory_access() on Arm.

I propose to have the following on Arm:

int arch_has_restricted_virtio_memory_access(void)
{
      return xen_has_restricted_virtio_memory_access();
}


where common xen.h contain a helper to be used by both Arm and x86:

static inline int xen_has_restricted_virtio_memory_access(void)
{
      if (IS_ENABLED(CONFIG_XEN_VIRTIO) && (xen_pv_domain() || 
xen_hvm_domain()))
          return 1;

      return 0;
}


But I would be happy with what you propose as well.


>
>
>> +	return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>> +#endif
>> +
>>   static void __init xen_dt_guest_init(void)
>>   {
>>   	struct device_node *xen_node;
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index fc61f7a..56afe6a 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -347,7 +347,7 @@ config XEN_VIRTIO
>>   
>>   config XEN_HVM_VIRTIO_GRANT
>>   	bool "Require virtio for fully virtualized guests to use grant mappings"
>> -	depends on XEN_VIRTIO && X86_64
>> +	depends on XEN_VIRTIO && (X86_64 || ARM || ARM64)
> you can remove the architectural dependencies


According to the conversation in commit #2 we are considering just a 
single XEN_VIRTIO option, but it is going to has the
same architectural dependencies: (X86_64 || ARM || ARM64)

By removing the architectural dependencies here, we will leave also 
X86_32 covered (neither XEN_HVM_VIRTIO_GRANT nor XEN_PV_VIRTIO covered 
it). I don't know whether it is ok or not.

Shall I remove dependencies anyway?


>
>
>>   	default y
>>   	help
>>   	  Require virtio for fully virtualized guests to use grant mappings.
>> diff --git a/drivers/xen/xen-virtio.c b/drivers/xen/xen-virtio.c
>> index cfd5eda..c5b2ec9 100644
>> --- a/drivers/xen/xen-virtio.c
>> +++ b/drivers/xen/xen-virtio.c
>> @@ -7,12 +7,26 @@
>>   
>>   #include <linux/module.h>
>>   #include <linux/dma-map-ops.h>
>> +#include <linux/of.h>
>>   #include <linux/pci.h>
>>   #include <linux/pfn.h>
>>   #include <linux/virtio_config.h>
>>   #include <xen/xen.h>
>>   #include <xen/grant_table.h>
>>   
>> +struct xen_virtio_data {
>> +	/* The ID of backend domain */
>> +	domid_t dev_domid;
>> +	struct device *dev;
>> +	struct list_head list;
>> +	spinlock_t lock;
>> +	/* Is device behaving sane? */
>> +	bool broken;
> If you moved "broken" after "dev_domid" we would save a few bytes for
> every allocation due to padding.

ok, will do


>
> Is data->lock only there to protect accesses to "broken"? If so, we
> might not need it, but I am not sure.


Really good question, I introduced a lock for other purpose, I was 
thinking we needed to protect grants allocation and removing, but wasn't 
100% sure about it (I wrote a remark in commit description). But looking 
into grant_table.c again I see that grant table code uses it's own lock, 
so looks like we don't need an extra lock here. I need to re-check 
regarding "broken", but likely we don't need here as well. If so, I will 
remove the lock.


>
>
>> +};
>> +
>> +static LIST_HEAD(xen_virtio_devices);
>> +static DEFINE_SPINLOCK(xen_virtio_lock);
>> +
>>   #define XEN_GRANT_ADDR_OFF	0x8000000000000000ULL
>>   
>>   static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>> @@ -25,6 +39,25 @@ static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>>   	return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT);
>>   }
>>   
>> +static struct xen_virtio_data *find_xen_virtio_data(struct device *dev)
>> +{
>> +	struct xen_virtio_data *data = NULL;
>> +	bool found = false;
>> +
>> +	spin_lock(&xen_virtio_lock);
>> +
>> +	list_for_each_entry( data, &xen_virtio_devices, list) {
>> +		if (data->dev == dev) {
>> +			found = true;
>> +			break;
>> +		}
>> +	}
>> +
>> +	spin_unlock(&xen_virtio_lock);
>> +
>> +	return found ? data : NULL;
>> +}
>> +
>>   /*
>>    * DMA ops for Xen virtio frontends.
>>    *
>> @@ -43,48 +76,78 @@ static void *xen_virtio_dma_alloc(struct device *dev, size_t size,
>>   				  dma_addr_t *dma_handle, gfp_t gfp,
>>   				  unsigned long attrs)
>>   {
>> -	unsigned int n_pages = PFN_UP(size);
>> -	unsigned int i;
>> +	struct xen_virtio_data *data;
>> +	unsigned int i, n_pages = PFN_UP(size);
>>   	unsigned long pfn;
>>   	grant_ref_t grant;
>> -	void *ret;
>> +	void *ret = NULL;
>>   
>> -	ret = (void *)__get_free_pages(gfp, get_order(size));
>> -	if (!ret)
>> +	data = find_xen_virtio_data(dev);
>> +	if (!data)
>>   		return NULL;
>>   
>> +	spin_lock(&data->lock);
>> +
>> +	if (unlikely(data->broken))
>> +		goto out;
>> +
>> +	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
>> +	if (!ret)
>> +		goto out;
>> +
>>   	pfn = virt_to_pfn(ret);
>>   
>>   	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
>> -		free_pages((unsigned long)ret, get_order(size));
>> -		return NULL;
>> +		free_pages_exact(ret, n_pages * PAGE_SIZE);
>> +		ret = NULL;
>> +		goto out;
>>   	}
>>   
>>   	for (i = 0; i < n_pages; i++) {
>> -		gnttab_grant_foreign_access_ref(grant + i, 0,
>> +		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
>>   						pfn_to_gfn(pfn + i), 0);
>>   	}
>>   
>>   	*dma_handle = grant_to_dma(grant);
>>   
>> +out:
>> +	spin_unlock(&data->lock);
>> +
>>   	return ret;
>>   }
>>   
>>   static void xen_virtio_dma_free(struct device *dev, size_t size, void *vaddr,
>>   				dma_addr_t dma_handle, unsigned long attrs)
>>   {
>> -	unsigned int n_pages = PFN_UP(size);
>> -	unsigned int i;
>> +	struct xen_virtio_data *data;
>> +	unsigned int i, n_pages = PFN_UP(size);
>>   	grant_ref_t grant;
>>   
>> +	data = find_xen_virtio_data(dev);
>> +	if (!data)
>> +		return;
>> +
>> +	spin_lock(&data->lock);
>> +
>> +	if (unlikely(data->broken))
>> +		goto out;
>> +
>>   	grant = dma_to_grant(dma_handle);
>>   
>> -	for (i = 0; i < n_pages; i++)
>> -		gnttab_end_foreign_access_ref(grant + i);
>> +	for (i = 0; i < n_pages; i++) {
>> +		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
>> +			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
>> +			data->broken = true;
>> +			goto out;
>> +		}
>> +	}
>>   
>>   	gnttab_free_grant_reference_seq(grant, n_pages);
>>   
>> -	free_pages((unsigned long)vaddr, get_order(size));
>> +	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
>> +
>> +out:
>> +	spin_unlock(&data->lock);
>>   }
>>   
>>   static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_t size,
>> @@ -108,28 +171,71 @@ static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct page *page,
>>   					  enum dma_data_direction dir,
>>   					  unsigned long attrs)
>>   {
>> +	struct xen_virtio_data *data;
>> +	unsigned int i, n_pages = PFN_UP(size);
>>   	grant_ref_t grant;
>> +	dma_addr_t dma_handle = DMA_MAPPING_ERROR;
>> +
>> +	BUG_ON(dir == DMA_NONE);
>> +
>> +	data = find_xen_virtio_data(dev);
>> +	if (!data)
>> +		return DMA_MAPPING_ERROR;
>> +
>> +	spin_lock(&data->lock);
>>   
>> -	if (gnttab_alloc_grant_references(1, &grant))
>> -		return 0;
>> +	if (unlikely(data->broken))
>> +		goto out;
>>   
>> -	gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page),
>> -					dir == DMA_TO_DEVICE);
>> +	if (gnttab_alloc_grant_reference_seq(n_pages, &grant))
>> +		goto out;
>>   
>> -	return grant_to_dma(grant) + offset;
>> +	for (i = 0; i < n_pages; i++) {
>> +		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
>> +				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
>> +	}
>> +
>> +	dma_handle = grant_to_dma(grant) + offset;
>> +
>> +out:
>> +	spin_unlock(&data->lock);
>> +
>> +	return dma_handle;
>>   }
>>   
>>   static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>>   				      size_t size, enum dma_data_direction dir,
>>   				      unsigned long attrs)
>>   {
>> +	struct xen_virtio_data *data;
>> +	unsigned int i, n_pages = PFN_UP(size);
>>   	grant_ref_t grant;
>>   
>> +	BUG_ON(dir == DMA_NONE);
>> +
>> +	data = find_xen_virtio_data(dev);
>> +	if (!data)
>> +		return;
>> +
>> +	spin_lock(&data->lock);
>> +
>> +	if (unlikely(data->broken))
>> +		goto out;
>> +
>>   	grant = dma_to_grant(dma_handle);
>>   
>> -	gnttab_end_foreign_access_ref(grant);
>> +	for (i = 0; i < n_pages; i++) {
>> +		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
>> +			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
>> +			data->broken = true;
>> +			goto out;
>> +		}
>> +	}
>> +
>> +	gnttab_free_grant_reference_seq(grant, n_pages);
>>   
>> -	gnttab_free_grant_reference(grant);
>> +out:
>> +	spin_unlock(&data->lock);
>>   }
>>   
>>   static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist *sg,
>> @@ -149,7 +255,7 @@ static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
>>   
>>   static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask)
>>   {
>> -	return 1;
>> +	return mask == DMA_BIT_MASK(64);
>>   }
>>   
>>   static const struct dma_map_ops xen_virtio_dma_ops = {
>> @@ -166,9 +272,61 @@ static const struct dma_map_ops xen_virtio_dma_ops = {
>>   	.dma_supported = xen_virtio_dma_dma_supported,
>>   };
>>   
>> +bool xen_is_virtio_device(struct device *dev)
>> +{
>> +	/* XXX Handle only DT devices for now */
>> +	if (!dev->of_node)
>> +		return false;
>> +
>> +	if (!of_device_is_compatible(dev->of_node, "virtio,mmio"))
>> +		return false;
>> +
>> +	return of_property_read_bool(dev->of_node, "xen,dev-domid");
>> +}
>> +EXPORT_SYMBOL_GPL(xen_is_virtio_device);
>> +
>>   void xen_virtio_setup_dma_ops(struct device *dev)
>>   {
>> +	struct xen_virtio_data *data;
>> +	uint32_t dev_domid;
>> +
>> +	data = find_xen_virtio_data(dev);
>> +	if (data) {
>> +		dev_err(dev, "xen_virtio data is already created\n");
>> +		return;
>> +	}
>> +
>> +	if (dev_is_pci(dev)) {
>> +		/* XXX Leave it hard wired to dom0 for now */
>> +		dev_domid = 0;
>> +	} else if (dev->of_node) {
>> +		if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) {
>> +			dev_err(dev, "xen,dev-domid property is not present\n");
>> +			goto err;
>> +		}
>> +	} else
>> +		/* The ACPI case is not supported */
>> +		goto err;
> If we get here, it means that xen_is_virtio_device returned true, so the
> PCI case is actually impossible?

Good catch, thank you. Yes, it is impossible on Arm for now (with 
changes in commit #6).


>
> I would rewrite these checks like this:
>
> /* XXX: ACPI and PCI unsupported for now */
> if (dev_is_pci(dev) || !dev->of_node) {
> 	goto err;
> }
> if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) {
> 	dev_err(dev, "xen,dev-domid property is not present\n");
> 	goto err;
> }


ok, will do


>
>
>
>> +	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
>> +	if (!data) {
>> +		dev_err(dev, "Сannot allocate xen_virtio data\n");
>> +		goto err;
>> +	}
>> +	data->dev_domid = dev_domid;
>> +	data->dev = dev;
>> +	spin_lock_init(&data->lock);
>> +
>> +	spin_lock(&xen_virtio_lock);
>> +	list_add(&data->list, &xen_virtio_devices);
>> +	spin_unlock(&xen_virtio_lock);
>> +
>>   	dev->dma_ops = &xen_virtio_dma_ops;
>> +
>> +	return;
>> +
>> +err:
>> +	dev_err(dev, "Сannot set up xen_virtio DMA ops, retain platform DMA ops\n");
>>   }
>>   EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops);
>>   
>> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>> index ae3c1bc..fdbcb99 100644
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { }
>>   
>>   #ifdef CONFIG_XEN_VIRTIO
>>   void xen_virtio_setup_dma_ops(struct device *dev);
>> +bool xen_is_virtio_device(struct device *dev);
>>   #else
>>   static inline void xen_virtio_setup_dma_ops(struct device *dev)
>>   {
>>   }
>> +static inline bool xen_is_virtio_device(struct device *dev)
>> +{
>> +	return false;
>> +}
>>   #endif /* CONFIG_XEN_VIRTIO */
>>   
>>   #endif /* INCLUDE_XEN_OPS_H */

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 18:39:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 18:39:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306699.521849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng9oB-0007lN-0f; Sun, 17 Apr 2022 18:39:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306699.521849; Sun, 17 Apr 2022 18:39:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng9oA-0007lG-Tb; Sun, 17 Apr 2022 18:39:38 +0000
Received: by outflank-mailman (input) for mailman id 306699;
 Sun, 17 Apr 2022 18:39:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V3EG=U3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ng9oA-0007lA-E9
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 18:39:38 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bba85544-be7d-11ec-a405-831a346695d4;
 Sun, 17 Apr 2022 20:39:37 +0200 (CEST)
Received: by mail-lf1-x136.google.com with SMTP id d6so3653957lfv.9
 for <xen-devel@lists.xenproject.org>; Sun, 17 Apr 2022 11:39:37 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 p41-20020a05651213a900b00443e2c39fc4sm1003889lfa.111.2022.04.17.11.39.35
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 Apr 2022 11:39:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bba85544-be7d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=I4fx1hE4/XanHvXXT61GagAtRkg7k3tgW0Yywww1X/E=;
        b=FEccoRnaF+wbNXngW5iZweCAocsqLhshHwThOJF6lZswLZbeUUkZJlHXWlqwYvu2zh
         M6ncNqOqhSdo8d0h6tcZAH0cscsrN4GQj3wKFmXZIgr/YNtoQylktDQ6T0NwCPLzx+Zb
         UCfa6UQWqEocDxiT9sS+j8rhj4cHHVfZvRYiWLJCoJe0c2v1mxt3yQN9NmWmE1QZIxFe
         HDyRfhqmjvoIy/MN7AlJQUMyMyC/9X+OV+dSXqpZEXPkl+1+OyY6nzO2neMzYhanmAlz
         3VNJtEcmSmxMjyWNhi+jpm8saHRv/Xv8IYnE8HiDOYMOW1pGVbcazbvNURWkmjqemdcL
         4IbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=I4fx1hE4/XanHvXXT61GagAtRkg7k3tgW0Yywww1X/E=;
        b=RI74sUAMHtrjpVQAwT2WzG8ma+yxpjSKP/vhCP7yAKMGDfUg/tx8upm5xhtYU1EOky
         TJCRoXOUEeWA0gnJv0IMyMcdUxUZn+X8ZPthANeeYfz0yTbcHKnpPSasngewrg6aa3uf
         UqM1qoihHXCVRu18EtqmkO/tAPpA1TwaMmaW6IljMyFIRPE03jraMmL3vtWoS/RBboJr
         Th1RqoAZlWugpqyZb7oBwJ2bb+rgkvdAnjRi2w080mF49dqBmUAiDNcKeRM6WtvsVpb4
         bv/r8Qp2BJYVZyc+mA481VRYZgl933HWCqcFFWPGCHNQVaLRhcv9JSfiFJKFE34VMUSu
         J1Gg==
X-Gm-Message-State: AOAM530E/Fpj1Ehp3cGsP4x1/DRB0s9EsiaVhciPLi2lux8/iVf5363M
	Qu8L4lpd2MiYPgcwVCuKawE=
X-Google-Smtp-Source: ABdhPJzA+VxQFkx8HmF0tiTX8iqmLNuHvigncHHa0RSibVSg5k0iQLaeVAuqP3PChRgmomWCGz3WGw==
X-Received: by 2002:ac2:5296:0:b0:46d:da1:773e with SMTP id q22-20020ac25296000000b0046d0da1773emr5704173lfm.197.1650220776577;
        Sun, 17 Apr 2022 11:39:36 -0700 (PDT)
Subject: Re: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops
 layer
To: Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Russell King <linux@armlinux.org.uk>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
 <YlpcqOUK59yExXlq@infradead.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <a8ef5394-3eb8-cd2a-f61d-a38277407eed@gmail.com>
Date: Sun, 17 Apr 2022 21:39:35 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YlpcqOUK59yExXlq@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 16.04.22 09:05, Christoph Hellwig wrote:

Hello Christoph

> On Thu, Apr 14, 2022 at 10:19:31PM +0300, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Various updates is a big indicator that the patch should be split
> further.  Please do one change at a time, and fold updates to the
> previous patches in the series into those patches instead of fixing
> them up later.


Sure, next (non-RFC) version will do things properly.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 18:43:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 18:43:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306706.521861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng9ri-0000qj-Jy; Sun, 17 Apr 2022 18:43:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306706.521861; Sun, 17 Apr 2022 18:43:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ng9ri-0000qc-Gh; Sun, 17 Apr 2022 18:43:18 +0000
Received: by outflank-mailman (input) for mailman id 306706;
 Sun, 17 Apr 2022 18:43:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V3EG=U3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ng9rh-0000qW-Od
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 18:43:17 +0000
Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com
 [2a00:1450:4864:20::230])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e968736-be7e-11ec-a405-831a346695d4;
 Sun, 17 Apr 2022 20:43:16 +0200 (CEST)
Received: by mail-lj1-x230.google.com with SMTP id v13so8644510ljg.10
 for <xen-devel@lists.xenproject.org>; Sun, 17 Apr 2022 11:43:16 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 n2-20020a19d602000000b0046d150c112dsm999811lfg.234.2022.04.17.11.43.15
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 Apr 2022 11:43:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e968736-be7e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=Kk9BppkAb1GLyoA2hlXyi8RoR58LZ27BwBibVf+whww=;
        b=qt5JWOZ1VfiLDVLEejVPGDYo3ZcP+JCb/V3FdDnmfvP9WmAWjdDok5wpZUVuADRg24
         fS/HUufwFDewQAGNUruGZUWRsayZYLyRWsbPnthPGLeban+cJ+sfdiZr4+6hZ8K+H/fq
         HaF7YfEMxlTsydFQ6VJEyHmcvpcepTm1ox5hOSvpTaf/VW/vMkACJQmHuCofbf7EQTSb
         YTUlrx3yCnHQ24kUxwwOj6znDjmn1Kb8i1QrzF3m8VAufNmIQbIx425Kl9LZDPjOxIng
         6E+6kHI9MbvnSm9HzKn1MfSr582N/2iNs5Zcd/9Lj9zQYqMx4tFf915Bgcyb2FYMkAvD
         DvrA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=Kk9BppkAb1GLyoA2hlXyi8RoR58LZ27BwBibVf+whww=;
        b=EIrrpazc+z1FuubTcF1knauvZ9A+7LEDXIks0woUCRg+0iiUccG/ZawyMyC1iHQamu
         k3mXJGSJpoYyk8KKanxwXEN9IaMbUOt8UUFYnksB12dvu52C8nW4pEx660JUYbxy4I+a
         dbqKdhsMoASk1jCvB04tP/NTt31Pl+ccefcVq3Duia1/H/nB8ce39Ph6PTvYvNFocWOd
         /B3vJgWweKWuoZFwhAusoPpOtbwUDOdDqNptLUA7TBFriZY33gkRpUdcRLaj7y5xNjCP
         jlGA+riVKSgfrrllUJiycNlKO4Ko2NFqIIkLtHjel4bbkFKdAyqTUXUnX/hevbzdtkoQ
         msMg==
X-Gm-Message-State: AOAM531lCXZ39ib+x/C4ULuhHsxZt492t6NU+91PkynnXNB83KNStYPO
	1xoXM3pOXy5jSQEpTb9zMf0=
X-Google-Smtp-Source: ABdhPJwUkJUNtAb7kvGmdnAfzY9PQvgtza8+x07uV7miQaHaGsm/DshtCFE9C62GtukahGs1aCKfTw==
X-Received: by 2002:a05:651c:19a5:b0:24c:87dd:d60d with SMTP id bx37-20020a05651c19a500b0024c87ddd60dmr5119546ljb.344.1650220996419;
        Sun, 17 Apr 2022 11:43:16 -0700 (PDT)
Subject: Re: [RFC PATCH 5/6] arm/xen: Introduce xen_setup_dma_ops()
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Russell King <linux@armlinux.org.uk>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Logan Gunthorpe <logang@deltatee.com>,
 David Hildenbrand <david@redhat.com>,
 Martin Oliveira <martin.oliveira@eideticom.com>,
 Kees Cook <keescook@chromium.org>,
 Jean-Philippe Brucker <jean-philippe@linaro.org>,
 Julien Grall <julien@xen.org>, Christoph Hellwig <hch@infradead.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-6-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151303340.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <53d13d03-b387-bf01-20fb-8d11a964b370@gmail.com>
Date: Sun, 17 Apr 2022 21:43:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204151303340.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 16.04.22 01:02, Stefano Stabellini wrote:

Hello Stefano

> On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> This patch introduces new helper and places it in new header.
>> The helper's purpose is to assign any Xen specific DMA ops in
>> a single place. For now, we deal with xen-swiotlb DMA ops only.
>> The subsequent patch will add xen-virtio DMA ops case.
>>
>> Also re-use the xen_swiotlb_detect() check on Arm32.
> Thanks for the patch, this is good to have in any case. I would move it
> to the beginning of the series.


ok, will move


>
>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>>   arch/arm/include/asm/xen/xen-ops.h   |  1 +
>>   arch/arm/mm/dma-mapping.c            |  5 ++---
>>   arch/arm64/include/asm/xen/xen-ops.h |  1 +
>>   arch/arm64/mm/dma-mapping.c          |  5 ++---
>>   include/xen/arm/xen-ops.h            | 13 +++++++++++++
>>   5 files changed, 19 insertions(+), 6 deletions(-)
>>   create mode 100644 arch/arm/include/asm/xen/xen-ops.h
>>   create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
>>   create mode 100644 include/xen/arm/xen-ops.h
>>
>> diff --git a/arch/arm/include/asm/xen/xen-ops.h b/arch/arm/include/asm/xen/xen-ops.h
>> new file mode 100644
>> index 00000000..8d2fa24
>> --- /dev/null
>> +++ b/arch/arm/include/asm/xen/xen-ops.h
>> @@ -0,0 +1 @@
>> +#include <xen/arm/xen-ops.h>
>> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
>> index 82ffac6..a1bf9dd 100644
>> --- a/arch/arm/mm/dma-mapping.c
>> +++ b/arch/arm/mm/dma-mapping.c
>> @@ -33,7 +33,7 @@
>>   #include <asm/dma-iommu.h>
>>   #include <asm/mach/map.h>
>>   #include <asm/system_info.h>
>> -#include <xen/swiotlb-xen.h>
>> +#include <asm/xen/xen-ops.h>
>>   
>>   #include "dma.h"
>>   #include "mm.h"
>> @@ -2288,8 +2288,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>>   	set_dma_ops(dev, dma_ops);
>>   
>>   #ifdef CONFIG_XEN
>> -	if (xen_initial_domain())
>> -		dev->dma_ops = &xen_swiotlb_dma_ops;
>> +	xen_setup_dma_ops(dev);
>>   #endif
> You can take this opportunity to also remove the #ifdef, by providing an
> empty stub implemention of xen_setup_dma_ops for the !CONFIG_XEN case.


agree, will do


>
>
>>   	dev->archdata.dma_ops_setup = true;
>>   }
>> diff --git a/arch/arm64/include/asm/xen/xen-ops.h b/arch/arm64/include/asm/xen/xen-ops.h
>> new file mode 100644
>> index 00000000..8d2fa24
>> --- /dev/null
>> +++ b/arch/arm64/include/asm/xen/xen-ops.h
>> @@ -0,0 +1 @@
>> +#include <xen/arm/xen-ops.h>
>> diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
>> index 6719f9e..831e673 100644
>> --- a/arch/arm64/mm/dma-mapping.c
>> +++ b/arch/arm64/mm/dma-mapping.c
>> @@ -9,9 +9,9 @@
>>   #include <linux/dma-map-ops.h>
>>   #include <linux/dma-iommu.h>
>>   #include <xen/xen.h>
>> -#include <xen/swiotlb-xen.h>
>>   
>>   #include <asm/cacheflush.h>
>> +#include <asm/xen/xen-ops.h>
>>   
>>   void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
>>   		enum dma_data_direction dir)
>> @@ -53,7 +53,6 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>>   		iommu_setup_dma_ops(dev, dma_base, dma_base + size - 1);
>>   
>>   #ifdef CONFIG_XEN
>> -	if (xen_swiotlb_detect())
>> -		dev->dma_ops = &xen_swiotlb_dma_ops;
>> +	xen_setup_dma_ops(dev);
>>   #endif
> same here

ok


>
>
>>   }
>> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
>> new file mode 100644
>> index 00000000..621da05
>> --- /dev/null
>> +++ b/include/xen/arm/xen-ops.h
>> @@ -0,0 +1,13 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +#ifndef _ASM_ARM_XEN_OPS_H
>> +#define _ASM_ARM_XEN_OPS_H
>> +
>> +#include <xen/swiotlb-xen.h>
>> +
>> +static inline void xen_setup_dma_ops(struct device *dev)
>> +{
>> +	if (xen_swiotlb_detect())
>> +		dev->dma_ops = &xen_swiotlb_dma_ops;
>> +}
>> +
>> +#endif /* _ASM_ARM_XEN_OPS_H */
>> -- 
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 19:02:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 19:02:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306712.521872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngAAN-0003LJ-71; Sun, 17 Apr 2022 19:02:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306712.521872; Sun, 17 Apr 2022 19:02:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngAAN-0003LC-2h; Sun, 17 Apr 2022 19:02:35 +0000
Received: by outflank-mailman (input) for mailman id 306712;
 Sun, 17 Apr 2022 19:02:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngAAL-0003L2-Lb; Sun, 17 Apr 2022 19:02:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngAAL-0003KD-Ka; Sun, 17 Apr 2022 19:02:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngAAL-0006bz-8C; Sun, 17 Apr 2022 19:02:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngAAL-0003GP-7l; Sun, 17 Apr 2022 19:02:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=X3rKOskeE9mXeOmj43iBI9zfXpZjd/tb5ucqrytijNA=; b=tlj7vW9VPDowbOh7Qpn0AyYfFJ
	qeqdnd8cQD7jd7Ln7dh/nHkdAVTimzVBnpQX+tcWAHwwwiJ3m3nfKWMhIHPvBqsFaaaFNo5Mli4jA
	P4pn8ujvGL9JmRnxzSrITOyEEXtmsdx11mVpKpf2xn3SLK0WmAvr57AtVCxg7hMT2z5s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169489-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169489: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 19:02:33 +0000

flight 169489 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169489/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  463 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   39 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 19:20:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 19:20:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306723.521883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngARN-0005iC-NW; Sun, 17 Apr 2022 19:20:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306723.521883; Sun, 17 Apr 2022 19:20:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngARN-0005i5-Jw; Sun, 17 Apr 2022 19:20:09 +0000
Received: by outflank-mailman (input) for mailman id 306723;
 Sun, 17 Apr 2022 19:20:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V3EG=U3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ngARL-0005hy-GU
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 19:20:07 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 636d663c-be83-11ec-8fbe-03012f2f19d4;
 Sun, 17 Apr 2022 21:20:06 +0200 (CEST)
Received: by mail-lf1-x12b.google.com with SMTP id b21so21452682lfb.5
 for <xen-devel@lists.xenproject.org>; Sun, 17 Apr 2022 12:20:06 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 f3-20020a056512322300b0046bbce218f2sm1005348lfe.79.2022.04.17.12.20.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 Apr 2022 12:20:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 636d663c-be83-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=UX+UJJi6cm6n3siakzXlqA7VdWeUuC0amPEI0CKnoy8=;
        b=anmuYIHMR44DHUBsKUVkyea2mPIgGJA1WVaLfL42XbsYHNLQ0QX5zF1vmXuveOfZa4
         TlIHgkTCOoYjOOVnzvPRkPqi+LYsmZYW7I9daLrolOUzGvJlP00NxPg1O42tKDiJdj3F
         W9UfoOoRhm9POPkypEpow7p+m6+WvsPwt0uKdYh6rfDXjumAupEnI2eqJ5bvdLrMXSrC
         Cydz5opZP1kh8wO33oIdvdQNglyjqHQLYMwCMFJqbSQLDJLtzHIrpnxoZKpVTXJ6x3oS
         ln3RXLd9fG/Z8R9g6sIQ9UgqXuc/KTif0O4MOzEsU4QUu9/7gdRIRnOzt0xx7Xe7vU1v
         3hVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=UX+UJJi6cm6n3siakzXlqA7VdWeUuC0amPEI0CKnoy8=;
        b=K6HF7qVTe+WPQGz4dVgfkgGnj8LHzpc9BjTlY8/oa60meF7UmV/Zf/8uKvCLR85e9+
         3OHEJBbG6PC+sa7Fj+nTnpxujwL3EdLkq1tnlotx8M149+ncSYI3hstKdGfrQHrd8TaZ
         Qzr0FqTO4d1sT0ZG++gaasbRC8Ag3HJZ0gHTNC/Lt/PK4I7R1D6mop83hPXE4LS6ZRPP
         lTCsOts23YzLFeSWiOPZRk7zefIKGIsiVgKWKIft3O4V9g/k3gCm3lW63SkPpHGbirE7
         XRuITrypPtPvTNxWZ3ZuveayjfGw46rz3pgo2HTHvHtXqOuZn1DoeJMR5h31vAsHmX8t
         Bpug==
X-Gm-Message-State: AOAM53127Y6BzQKqBoLhJuD9Uil9qMlGXVCR6E2iJ8/GGF8o77e+8ppY
	4KPgP/r53b43DHkGURy+YWw=
X-Google-Smtp-Source: ABdhPJwipgGgKdPerX/TjaWsmOWeRcT7lQlBUqHmoX8ARPDdhaoRZak1gHU/2o+0U1HoS6YY+cJbTA==
X-Received: by 2002:a05:6512:c21:b0:471:9935:f8f2 with SMTP id z33-20020a0565120c2100b004719935f8f2mr35608lfu.650.1650223205568;
        Sun, 17 Apr 2022 12:20:05 -0700 (PDT)
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <8df1dc60-614a-67fa-3a9d-e2db4a7e0132@gmail.com>
Date: Sun, 17 Apr 2022 22:20:04 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 16.04.22 01:02, Stefano Stabellini wrote:


Hello Stefano

> On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Call xen_virtio_setup_dma_ops() only for Xen-aware virtio devices
>> in Xen guests if restricted access to the guest memory is enabled.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>>   include/xen/arm/xen-ops.h | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
>> index 621da05..28b2ad3 100644
>> --- a/include/xen/arm/xen-ops.h
>> +++ b/include/xen/arm/xen-ops.h
>> @@ -2,12 +2,19 @@
>>   #ifndef _ASM_ARM_XEN_OPS_H
>>   #define _ASM_ARM_XEN_OPS_H
>>   
>> +#include <linux/virtio_config.h>
>>   #include <xen/swiotlb-xen.h>
>> +#include <xen/xen-ops.h>
>>   
>>   static inline void xen_setup_dma_ops(struct device *dev)
>>   {
>>   	if (xen_swiotlb_detect())
>>   		dev->dma_ops = &xen_swiotlb_dma_ops;
>> +
>> +#ifdef CONFIG_XEN_VIRTIO
>> +	if (arch_has_restricted_virtio_memory_access() && xen_is_virtio_device(dev))
>> +		xen_virtio_setup_dma_ops(dev);
>> +#endif
> This makes sense overall.


thank you


> Considering that the swiotlb-xen case and the
> virtio case are mutually exclusive, I would write it like this:
>
> 	if (arch_has_restricted_virtio_memory_access() && xen_is_virtio_device(dev))
> 		xen_virtio_setup_dma_ops(dev);
> 	else if (xen_swiotlb_detect())
> 		dev->dma_ops = &xen_swiotlb_dma_ops;


Agree, will do


>
> There is no need for #ifdef (also see other comments).


Agree, if !CONFIG_XEN_VIRTIO then xen_virtio_ are just stubs.


#ifdef CONFIG_XEN_VIRTIO
void xen_virtio_setup_dma_ops(struct device *dev);
bool xen_is_virtio_device(struct device *dev);
#else
static inline void xen_virtio_setup_dma_ops(struct device *dev)
{
}
static inline bool xen_is_virtio_device(struct device *dev)
{
     return false;
}
#endif /* CONFIG_XEN_VIRTIO */



-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 19:48:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 19:48:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306730.521894 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngAsj-0008La-Sc; Sun, 17 Apr 2022 19:48:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306730.521894; Sun, 17 Apr 2022 19:48:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngAsj-0008LT-Pe; Sun, 17 Apr 2022 19:48:25 +0000
Received: by outflank-mailman (input) for mailman id 306730;
 Sun, 17 Apr 2022 19:48:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngAsi-0008LJ-MF; Sun, 17 Apr 2022 19:48:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngAsi-00047c-Jy; Sun, 17 Apr 2022 19:48:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngAsi-0000Qs-4L; Sun, 17 Apr 2022 19:48:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngAsi-0003qh-3o; Sun, 17 Apr 2022 19:48:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZM5FLalYSRA7kGOasBpYcKHZCn6SSmiucw7NefFq66o=; b=G2Nx3sR+Dw75BY1DImH8gB+E/l
	zWWp3Xux5Ay4aTXIaKCXhTYDEReipAvRilr7QwNvyiTskRXv6FiACjSo1XU6nwzyEIFymWgn4qWHH
	2QUkcZGUHGLuzODjjcVO/cdEnZmI0iRMV3MLTYgtzjehDYVC3wNtX9ioPBY9KlzieDZI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169490-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169490: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 19:48:24 +0000

flight 169490 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169490/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  464 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   40 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 20:43:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 20:43:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306743.521904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngBk2-0006IW-Vq; Sun, 17 Apr 2022 20:43:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306743.521904; Sun, 17 Apr 2022 20:43:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngBk2-0006IP-Sr; Sun, 17 Apr 2022 20:43:30 +0000
Received: by outflank-mailman (input) for mailman id 306743;
 Sun, 17 Apr 2022 20:43:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngBk1-0006ID-Kk; Sun, 17 Apr 2022 20:43:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngBk1-00059m-E6; Sun, 17 Apr 2022 20:43:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngBk0-0002iw-U4; Sun, 17 Apr 2022 20:43:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngBk0-0000sm-Tb; Sun, 17 Apr 2022 20:43:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ugaDkrPKHZ4Y8cuanlyj3IAuaiKMryDUGDxpoLpsQ3o=; b=x9LjqWkvP6I+1xIKsFJhn5Zo2H
	ybVeAtoYg0C0qROS/iOVAXzWjvL1wMKge/dHkCuuTUij8/lTMDngYZNcdwkBJer+xtiQXsFNC0HG7
	NUVCMB1Hgb+4mBsG/y9hdRugL0EXWWw1MBtW9BkYf1gcLuhuHO7y4Ow50wcgUscx0gmY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169491-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169491: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 20:43:28 +0000

flight 169491 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169491/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  465 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   41 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 21:05:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 21:05:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306751.521916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngC54-0000PZ-Qu; Sun, 17 Apr 2022 21:05:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306751.521916; Sun, 17 Apr 2022 21:05:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngC54-0000PS-MI; Sun, 17 Apr 2022 21:05:14 +0000
Received: by outflank-mailman (input) for mailman id 306751;
 Sun, 17 Apr 2022 21:05:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V3EG=U3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ngC52-0000PM-OF
 for xen-devel@lists.xenproject.org; Sun, 17 Apr 2022 21:05:12 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 114f3fbf-be92-11ec-8fbe-03012f2f19d4;
 Sun, 17 Apr 2022 23:05:10 +0200 (CEST)
Received: by mail-lj1-x236.google.com with SMTP id v13so8852498ljg.10
 for <xen-devel@lists.xenproject.org>; Sun, 17 Apr 2022 14:05:10 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 p9-20020a2e93c9000000b0024b3c2ecc18sm979821ljh.115.2022.04.17.14.05.09
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 17 Apr 2022 14:05:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 114f3fbf-be92-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=3+nbTY+84mWqEaxVh9si/y236NGTkkPaVHQEn9FFNrQ=;
        b=SqsQaN3fYS853QyFaqhKfWVcI1U/A4Juzvi+EN0SFJi1ZQ2FiQxlnlVvOkN8wT92pg
         gYeEGqE2PFZCSAUQjDQ8XlgcTPj/J2mPfqkKTxv9+bvDqHwu4L+OrW2E048B79hejG7J
         YGS5pVsV5N+uPco8nKvkzcIXjk8rBoBeWtXYgbHek3YWtvLnCgvIMLLeFD1jBuQmmrJf
         ZQgFJnXSrmh9mMXyBlk6yc2g6dV6Eq6VoeNeRcFrMFJVpIdAoMg92fyYoEGZ/Al0blfo
         epqj6ufkNBRCTbF7UfmPszNHZrkig+Ad6MAtecdlZJnWfmFOMAluLmNo7zX3yOPkSVAx
         9dBg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=3+nbTY+84mWqEaxVh9si/y236NGTkkPaVHQEn9FFNrQ=;
        b=KcEvsQR3QYLmH/jf68jum5vPYTiHUq0A1a2Hi3dVcsZQ1p2pJqFAf5HSHGw8xnJaFD
         E5RDE+HcNkiYOnjrORrJ2Ak2fiXcEjtMMpw8teeLK/7PTAvAPd3m8dp/2md0DZmgE8yj
         6xJRFEIm0bO0wzZhxwCmjrcivYPW6TiJRLpuAJzlzVuZXHkQLxxLdtiNvp2DbWSs+wMY
         bm+vuaEcL7Wgcq/gCRsnogUkiXHDzIfKwgxXM4cyNyQoNm1Bkp9jThKn72SARvEv9/lS
         jSvMOtCt3s79aehhu5ySUwkJwcrKvQkjYEO2Ws7ooLgB0CJeKBeJO6blUhbp8GvXpysA
         Ys9Q==
X-Gm-Message-State: AOAM532SxC+Jcsr4Je4wAm7+Xh55nkKk/XqpU04bqPAnKbq8r5l8t+L/
	zRo2d2SEyGmgs2E9f6MRHF0=
X-Google-Smtp-Source: ABdhPJwA45/8xaDYUsCh46Vd5PLnnCYBZYvMyLLmDl7WHF9eI0ftD1WkdGwRVKQNKCGBZhzlQf9Pyg==
X-Received: by 2002:a2e:b8c7:0:b0:24d:a697:cbf3 with SMTP id s7-20020a2eb8c7000000b0024da697cbf3mr5387864ljp.448.1650229510204;
        Sun, 17 Apr 2022 14:05:10 -0700 (PDT)
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
To: Christoph Hellwig <hch@infradead.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
 <YlpdBHKT1bYzZe2e@infradead.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
Date: Mon, 18 Apr 2022 00:05:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YlpdBHKT1bYzZe2e@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 16.04.22 09:07, Christoph Hellwig wrote:

Hello Christoph

> On Fri, Apr 15, 2022 at 03:02:45PM -0700, Stefano Stabellini wrote:
>> This makes sense overall. Considering that the swiotlb-xen case and the
>> virtio case are mutually exclusive, I would write it like this:
> Curious question:  Why can't the same grant scheme also be used for
> non-virtio devices?  I really hate having virtio hooks in the arch
> dma code.  Why can't Xen just say in DT/ACPI that grants can be used
> for a given device?


In Xen system:
- the grants are not used for "non-virtualized" devices at all (platform 
devices for the passthrough).
- the grants are widely used for "virtualized, but non-virtio" devices 
(traditional Xen PV devices), but grants for these Xen PV devices
are used in a different way and *not* at the DMA ops level like in 
current approach

Or I misunderstood your question?

This patch series tries to make things work with "virtio" devices in Xen 
system without introducing any modifications to code under drivers/virtio.
We could avoid having virtio hooks in the arch DMA code, but we need to 
trigger setting xen-virtio DMA ops for the virtio device from some other 
place.
For example, the following code would also work, but requires altering 
virtio_mmio_probe():

diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 56128b9..8f48491 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -615,6 +615,9 @@ static int virtio_mmio_probe(struct platform_device 
*pdev)
                                               DMA_BIT_MASK(32 + 
PAGE_SHIFT));
         } else {
                 rc = dma_set_mask_and_coherent(&pdev->dev, 
DMA_BIT_MASK(64));
+
+               if (arch_has_restricted_virtio_memory_access())
+ xen_virtio_setup_dma_ops(&pdev->dev);
         }
         if (rc)
                 rc = dma_set_mask_and_coherent(&pdev->dev, 
DMA_BIT_MASK(32));


Another possible option could be to introduce local init function in 
drivers/xen/xen-virtio.c to scan the device tree and set xen-virtio DMA 
ops for all devices with the
"xen,dev-domid" property.


What do you think?

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 17 21:43:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 21:43:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306758.521926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngCft-0004nx-Nb; Sun, 17 Apr 2022 21:43:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306758.521926; Sun, 17 Apr 2022 21:43:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngCft-0004nq-Kk; Sun, 17 Apr 2022 21:43:17 +0000
Received: by outflank-mailman (input) for mailman id 306758;
 Sun, 17 Apr 2022 21:43:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngCfs-0004ng-06; Sun, 17 Apr 2022 21:43:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngCfr-00067u-Uc; Sun, 17 Apr 2022 21:43:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngCfr-0004VV-7F; Sun, 17 Apr 2022 21:43:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngCfr-0002iI-6m; Sun, 17 Apr 2022 21:43:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WoRUb5ObmOCevEGzFMCwIZNGbPgWhCOvG1GXnqmYCH0=; b=THgBMsowcJijyAQnUokr72xe4b
	QXlvsVJwPtaL8sxLeKrG4bd7kY0hwILCkXcht1KtaON/brEIalmLSRWhwUKXe6BLjKLQ1ITtR0QIB
	yvXFcXp+44y+sCK5kzPf3osq7nOJ15M1DevRRKA4u1m6OLiDLAeXwquQ1+vaFu04YyVU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169492-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169492: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 21:43:15 +0000

flight 169492 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169492/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  466 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   42 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 23:03:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 23:03:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306770.521938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngDut-0004dU-IZ; Sun, 17 Apr 2022 23:02:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306770.521938; Sun, 17 Apr 2022 23:02:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngDut-0004dN-FX; Sun, 17 Apr 2022 23:02:51 +0000
Received: by outflank-mailman (input) for mailman id 306770;
 Sun, 17 Apr 2022 23:02:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngDus-0004dD-Dq; Sun, 17 Apr 2022 23:02:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngDus-0007Yt-7g; Sun, 17 Apr 2022 23:02:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngDur-0006Nz-Jr; Sun, 17 Apr 2022 23:02:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngDur-0004mn-JQ; Sun, 17 Apr 2022 23:02:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2Rr7p6vA11hfLYIz9LwwxRZz7S+e4nluvsVB+fpSAp8=; b=atnNbJnDMLxIb/3D9B8lpZahFt
	BGRa9jut6RBnMu8eBySzAQzGZkr9dbTUSuf0TZXUcGmviTXf1Mxw+x3Ovihm59VE0/X5BADezuqIM
	V50znk+g6QLWNq3ufeksmHrxTZb9g0N8WhdxZjA2a0Malq35Oltn0Kod8YgZc6PJqvPE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169488-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169488: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3a69a44278a72e15f12e24f5db4d277a497649aa
X-Osstest-Versions-That:
    linux=a2c29ccd9477861b16ddc02c411a6c9665250558
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 23:02:49 +0000

flight 169488 linux-linus real [real]
flight 169493 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169488/
http://logs.test-lab.xenproject.org/osstest/logs/169493/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 169493-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169475
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169475
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169475
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169475
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169475
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169475
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 169475
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169475
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169475
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                3a69a44278a72e15f12e24f5db4d277a497649aa
baseline version:
 linux                a2c29ccd9477861b16ddc02c411a6c9665250558

Last test of basis   169475  2022-04-17 03:22:21 Z    0 days
Testing same since   169488  2022-04-17 17:09:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anna-Maria Behnsen <anna-maria@linutronix.de>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Borislav Petkov <bp@suse.de>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Marek Vasut <marex@denx.de>
  Martin Povišer <povik+lin@cutebit.org>
  Nadav Amit <namit@vmware.com>
  Neelima Krishnan <neelima.krishnan@intel.com>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Paul Gortmaker <paul.gortmaker@windriver.com>
  Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
  Rei Yamamoto <yamamoto.rei@jp.fujitsu.com>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Steven Price <steven.price@arm.com>
  Thomas Gleixner <tglx@linutronix.de>
  Wolfram Sang <wsa@kernel.org>
  Yassine Oudjana <y.oudjana@protonmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   a2c29ccd9477..3a69a44278a7  3a69a44278a72e15f12e24f5db4d277a497649aa -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 17 23:04:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Apr 2022 23:04:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306778.521949 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngDw0-0005EX-2F; Sun, 17 Apr 2022 23:04:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306778.521949; Sun, 17 Apr 2022 23:04:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngDvz-0005EQ-Ue; Sun, 17 Apr 2022 23:03:59 +0000
Received: by outflank-mailman (input) for mailman id 306778;
 Sun, 17 Apr 2022 23:03:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngDvy-0005EF-Ap; Sun, 17 Apr 2022 23:03:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngDvy-0007bC-9y; Sun, 17 Apr 2022 23:03:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngDvx-0006P9-SP; Sun, 17 Apr 2022 23:03:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngDvx-0004oX-Rx; Sun, 17 Apr 2022 23:03:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ywT5M0tbxjTT10Z1IWdNottGfPLmqqWL6bpNQfWx3UE=; b=czNheerZhjS8yvbamZl5EIs5Ji
	sd01SVeJiZXXDl+6TefuvwDkGApuumLtAxQ6bJv/DZsUu6dULwNF/uI2WEJSgxtp0/WfTWHcYa2qI
	UKvVlfP6t/mhbawO9LRdUqMw0mEolDJT8T4LCEi+3f8Ps/QeQDvkJ1cASQo18/KkR6lk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169494-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169494: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Apr 2022 23:03:57 +0000

flight 169494 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169494/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  467 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   43 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 00:36:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 00:36:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306795.521960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngFNa-0006gv-FR; Mon, 18 Apr 2022 00:36:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306795.521960; Mon, 18 Apr 2022 00:36:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngFNa-0006go-Bw; Mon, 18 Apr 2022 00:36:34 +0000
Received: by outflank-mailman (input) for mailman id 306795;
 Mon, 18 Apr 2022 00:36:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngFNY-0006ge-Ux; Mon, 18 Apr 2022 00:36:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngFNY-0001Jj-SQ; Mon, 18 Apr 2022 00:36:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngFNY-0001dU-H7; Mon, 18 Apr 2022 00:36:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngFNY-0003u3-CL; Mon, 18 Apr 2022 00:36:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MZMQgn1d/7TLJ1i7bGw3XKJc6PA52MQ5a7Nv7E7nThc=; b=xyo49v6xpWHSl0H05Fhy3kXXEJ
	PfhMfUnroZe7fXnUTGRkRcfuOl2kw2PDVG3LwE8Q2P1sNW7Pg97mRk4LSJOX0nM2g8ljUaWCRPNY0
	3FK5InPD6bdAGurK2id7f53mxWX7H5NNmyf6sPjBR4PP7nKZ4sgIZgPB5yRcEYfZRzjk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169496-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169496: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 00:36:32 +0000

flight 169496 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169496/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  468 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    1 days   44 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 00:38:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 00:38:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306802.521970 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngFPV-0007Fw-SE; Mon, 18 Apr 2022 00:38:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306802.521970; Mon, 18 Apr 2022 00:38:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngFPV-0007Fp-PQ; Mon, 18 Apr 2022 00:38:33 +0000
Received: by outflank-mailman (input) for mailman id 306802;
 Mon, 18 Apr 2022 00:38:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Fiv=U4=nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ngFPU-0007Fb-IQ
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 00:38:32 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20615.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::615])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id de69d1bd-beaf-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 02:38:30 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DU2PR04MB8981.eurprd04.prod.outlook.com (2603:10a6:10:2e0::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 00:38:28 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022
 00:38:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de69d1bd-beaf-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jQDo5bVRmjzNVc/l/hicRaPdYVZEb+n4kGwd1Kqo1vU4P65S9hmkfmMUYqefnC9fg6g2fVuBorMfyDa2jcqjeBiaCRpwPeEQqYIhAVvu0oUdp7p2PSUEql9JBGDMVydA7wX7MKIn10Lg4InxNor4fkUHGtNP9ORS41vJuQwCGG1HG2cVzVGhrB+JI7f5ZBwbK5NKD4QhgqmfTh/2TsD6FwC0k8TtDCXNeXBJzDFOA0rm/hiPqAas+UtELOktYM0MGYsKmjeK6lj1yVRXOBn1MF5cdk0nIfrE1azsZMFaoNW37gaUrahzdeLLacD5IP54AI3cKRlS2Q+ntjIgcxnvfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WbwKF2f0yg06bsFysHLKsTYaFaqea66AklRc9H6oONY=;
 b=n1nis8asxa0yhLYRqqw8zIvPCRlk7Skll6pMI/FOSFXHBgdWie764e4FVcPb1EvUr7qccOOvYx0lzExFP/pIRAlnFfyjNmwEV6NJPyKLHryiW/mUQN8omzbZoHI19Gg+0+opu8d3SOF5ttmbC5qhoG8e4Jek3/2izxC9+igSvWDbUEqiXlvY3sn18B7QqOE3BoC/Y+D+0X7EFA8zCWSO/n/MpNM9YbgRmtvGVQAN2CBkC9NUPdgUqxhJfdUbWYof6f6/sHDoxNcNmi0OGjHDTlwI1o0968c9ZjnkO8i5Zw1PDYS94KdckKPiUFLMpKyXVYVznlnrlfSC2l0YVX+Iew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass
 header.d=nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WbwKF2f0yg06bsFysHLKsTYaFaqea66AklRc9H6oONY=;
 b=TZiES3b4J0CysS/Pc/ADEXNSZow+GwzC3ci8GxyDIFmoazELkJ6o/yZpB8V1SZ3fgd0u5H0xs0mKFT8MSf6p7ySiPcdO51ecz2Be6vIqrOITGgff9hwuuUW1Kse/kwvBWFUQeaV+2djliYxQYUfvWbVXBOm+KTV3C03/d0D8enk=
From: Peng Fan <peng.fan@nxp.com>
To: Stefano Stabellini <sstabellini@kernel.org>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: "julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, "bertrand.marquis@arm.com"
	<bertrand.marquis@arm.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>,
	"wl@xen.org" <wl@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "van.freenix@gmail.com"
	<van.freenix@gmail.com>, "michal.orzel@arm.com" <michal.orzel@arm.com>, Henry
 Wang <Henry.Wang@arm.com>
Subject: RE: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
Thread-Topic: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
Thread-Index: AQHYT83HqYjaMfsCa0Wqq3F8Df72S6zxkDgAgANItFA=
Date: Mon, 18 Apr 2022 00:38:27 +0000
Message-ID:
 <DU0PR04MB94178AA133761F3908DABE3E88F39@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220414074452.14419-1-peng.fan@oss.nxp.com>
 <20220414074452.14419-2-peng.fan@oss.nxp.com>
 <alpine.DEB.2.22.394.2204151525120.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204151525120.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nxp.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d6204fa9-f4b9-43b7-ef62-08da20d3c177
x-ms-traffictypediagnostic: DU2PR04MB8981:EE_
x-microsoft-antispam-prvs:
 <DU2PR04MB89816A1407388ED5DEC540AD88F39@DU2PR04MB8981.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 pF5oeiXLC8yqsU2+Em72hmKT8KNOsgeCXJd5UKYxhfFzbhyBUllh9e5d59evFhnz8q3wYBKYN/CuNdVtqw1Cq04CfULq8NH27Q6/5XRLe+F4lIlW/oTN3gJEyTv4LZfdKFRiYPWt6Ub9zWDBihzlErk+uSiobRwJIYza+yEerdksGRUzWL2a+WG/FX9tHd6ZPOqrwaP4/7OTwDYskfZON/a2IejhZLHut014vl4nJeTRM89EEwtvkEqkT6Jqli2+h6E5FiaVKSxB/czB9WSM5HU6q1s9iOdz4hlLrzAOgH1uCryLYZgUEp0xGmoWR3OG+QKcSlVZQYDVp9wQuw9QP2RCdo6oT4+ha5PcDBRjxHdOiK0raYAgdsZDo9t+pY2jNaC779eWiRarscRXJGODiLlQbl9UcvosBjdmTU+5ZKsG0W1tFaV893bEJlNqgec3uPxnqE6od3al/J6PcUSZFtpgqEJOYaIpynkZm2aDwzz32LeVF1ruAiL5Pj0cB1jCbf0qvb/WxRJigFr5+p0VIE/ZmM2ATU3rhvuyRPevXPTENonq7fXG6PZIjD4HL9Tf0XN4UFTaCBiSuDteWwwZA4vee9DBaZMaAi7wdDs82uXz0SOceh/66yiPrpnsW9fimWFy/nAB5MVg89sn3el9H9Bfi3FRw5Vl/LU+br0Ao7np90tKxN+/Lo2dh5Qc5rXPDrUnL7DbXadsmTWr3wJcOorFD2d6UGfRSnK6+TDABRgzlwN6XDEgJ2VXYfHK5pemmNRbFk901/1fD6yTtGcTTLWup0EkfCF4FiZszFouyWIyxRW9tjxH3EtOKofSk8BG
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(2906002)(83380400001)(966005)(6506007)(9686003)(55016003)(86362001)(122000001)(8936002)(45080400002)(30864003)(52536014)(5660300002)(7416002)(44832011)(508600001)(7696005)(38100700002)(71200400001)(186003)(316002)(38070700005)(76116006)(64756008)(66946007)(66556008)(66476007)(8676002)(4326008)(54906003)(66446008)(26005)(110136005)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?2dIvvep0KaThtrHfihC8ixLV4fjLo1NZedpH8YxUhiK7JT49ig7rxybckRsI?=
 =?us-ascii?Q?+rRZQQ412agMW2MXkOirZYMXebPxxUlRsSTVN6+k/Be/AHA5dCQs78tco8Dx?=
 =?us-ascii?Q?o3bYNBmblTVm3S5AC6oKX97HlFzHSgl12G5DNrHvYK5y6NGbawWZ3Tjd5oAc?=
 =?us-ascii?Q?Uu1BwLhyDtyrmp0m/0/9FYcScvfOn0iSCsA6+nB40iZ5j5vkRUpN4Ox1ybsX?=
 =?us-ascii?Q?+lgyj2NG+kx7Y08/sWjgj+nPVOmK5NvrXjhH536KqoWu3tUmALtfOisLtcCm?=
 =?us-ascii?Q?TGc3dFieevYBXiiEjkLSaT2xI0ba4akr672HnyJzq+bHcgiwu/fYUdHa6yX2?=
 =?us-ascii?Q?FTNMyMZ9KkazzaHyY2GEaLdAGMZ1HILkNFgbzICJjYmIyiHU6euvFKS+dh+b?=
 =?us-ascii?Q?k6UNj9/4fGiGOPh8ao/vO1vWCDEUi0zu6BYI6iTR2kYm0GDL/c8EMCuLeyp8?=
 =?us-ascii?Q?1MMcW/aRtRzzyk6g7+WS/sKY6oUkoVp18kf5XxYqBWsb/+WzK45qWQirCpP2?=
 =?us-ascii?Q?W+40BBPCsBHsLh0mM2YFuDwGsaKkSvInABoFYrUvBG8lRrLj/KuhrRlEA3g2?=
 =?us-ascii?Q?DTQUzccyC9hvP4yBd+WEPVxAc0TGpJkkoWX8YW37z+8wXt7kEhdthzBDobSJ?=
 =?us-ascii?Q?GmOooHLJtBvtlEZWg1/yrw6ba+X+HvFDTcLwZ08ohTVH+HZFwOAvo/rvrz6e?=
 =?us-ascii?Q?RmDK4VCLcjEERdh2HAHFvGvBCnLi3G8ylO853zn0iVyfI9D+mN7EK6F3uP1q?=
 =?us-ascii?Q?1A34uY2v2XB2LpB+kAnJv4dGT+Xb1kVHFAO7iz1CCSyCNBRcdScRFQ1HFYWu?=
 =?us-ascii?Q?DAjQd25SGkpkT201YMlbJXH9yzMhvqWCbl5xdvtbUYivt2yJVNskWQmf2XJa?=
 =?us-ascii?Q?Tz8C8fKoUSQdwCvZw3NPksl5B+hVe4EwU5Jaz1pCnnvS3iu9giLl+MB8cAQV?=
 =?us-ascii?Q?MjC29ayoh8IMuKu256jZxz+OVbI3OkJbaRk2uSzLqfCRBYPvn5eZu3NTygVI?=
 =?us-ascii?Q?87beLuWpWFPkNSaH4YDgPWiZzFChFMXun58bDIsmD046PVgrJV2Un1lHqG9R?=
 =?us-ascii?Q?pPiyqaPEq7d54XfvJeanzy2m8NjjAGpBcwig/aGrGYC5B1DVpMp9rMjoMYrf?=
 =?us-ascii?Q?9Q6LoOcgCzA2K42WsALMe1+qenTYz3PN7M34strfBB4dcCFfQMuFTj1UjKu1?=
 =?us-ascii?Q?LdIY0QzIEx1SH9B9Tp+kznUMyWac/9Q3/L09K1Ne1yGBDOcbAhhVorv649Cu?=
 =?us-ascii?Q?G60JOdZYTPgX8Fnj26I1yAncQBY5vU7jjojAKKg3/0/TygK8bn0aNArRkQNo?=
 =?us-ascii?Q?OpVem4IG2FmcXz9/SxTDngqLiEjvqXvG72LlG2BSlHkugGTDaM1H4FUiLyT0?=
 =?us-ascii?Q?I+3JFaskOvTfVnmq7KhcyPcdPKWIGtZ1fnGn1liYsv2z01OlgAfrnalv1qf1?=
 =?us-ascii?Q?FTgd+VsyD0mcGYB/vlYhT60o/SC72PXrYY43t/iWajMlge8PqpPzOdDBbspI?=
 =?us-ascii?Q?EfXXc8lqMYe0R8K/fC+HNh17UQ38TifzAkY23mSFMVcSKPczCRGvvFPSXphw?=
 =?us-ascii?Q?lIU4DSPSrYjwSPXea46XuPJKcYenTmYzfha/5Dywwtm95JDu3kByxwp1mIcZ?=
 =?us-ascii?Q?8Lf/O3GDmGx+aSm6gRMoApi1XIi/xEyx4EccvjGRaPawNfzBpH47orgvf3eH?=
 =?us-ascii?Q?Wi081xUifUPPuq2P3C5FWPvSbGOXPUbVhYqZsQh2+0B/1dp1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6204fa9-f4b9-43b7-ef62-08da20d3c177
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 00:38:28.0054
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: svfpBOK+WVecOD98c+YpaZPRs1qM7YERAesoexBlDsWINkDAtbYb2ZaBCL0Sp1CRhjqHl/wrilNKF2sEabg3uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8981

> Subject: Re: [PATCH V5 1/2] xen/arm: Add i.MX lpuart driver
>=20
> On Thu, 14 Apr 2022, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The i.MX LPUART Documentation:
> > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww=
.
> >
> nxp.com%2Fwebapp%2FDownload%3FcolCode%3DIMX8QMIEC&amp;data=3D04
> %7C01%7Cp
> >
> eng.fan%40nxp.com%7Caf595d02a1dd4ed5825b08da1f2f0e78%7C686ea1d3bc
> 2b4c6
> >
> fa92cd99c5c301635%7C0%7C0%7C637856584221931187%7CUnknown%7CTW
> FpbGZsb3d
> >
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7C
> >
> 3000&amp;sdata=3D3N2TsMqzhHF5dem1Cyeo2HVdgfTJFnPHSoMW7KrNph8%3D
> &amp;rese
> > rved=3D0 Chatper 13.6 Low Power Universal Asynchronous Receiver/
> > Transmitter (LPUART)
> >
> > Tested-by: Henry Wang <Henry.Wang@arm.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
> >  xen/drivers/char/Kconfig              |   7 +
> >  xen/drivers/char/Makefile             |   1 +
> >  xen/drivers/char/imx-lpuart.c         | 276 ++++++++++++++++++++++++++
> >  4 files changed, 348 insertions(+)
> >  create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
> >  create mode 100644 xen/drivers/char/imx-lpuart.c
> >
> > diff --git a/xen/arch/arm/include/asm/imx-lpuart.h
> > b/xen/arch/arm/include/asm/imx-lpuart.h
> > new file mode 100644
> > index 0000000000..fe859045dc
> > --- /dev/null
> > +++ b/xen/arch/arm/include/asm/imx-lpuart.h
> > @@ -0,0 +1,64 @@
> > +/*
> > + * xen/arch/arm/include/asm/imx-lpuart.h
> > + *
> > + * Common constant definition between early printk and the LPUART
> > +driver
> > + *
> > + * Peng Fan <peng.fan@nxp.com>
> > + * Copyright 2022 NXP
> > + *
> > + * This program is free software; you can redistribute it and/or
> > +modify
> > + * it under the terms of the GNU General Public License as published
> > +by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#ifndef __ASM_ARM_IMX_LPUART_H__
> > +#define __ASM_ARM_IMX_LPUART_H__
> > +
> > +/* 32-bit register definition */
> > +#define UARTBAUD          (0x10)
> > +#define UARTSTAT          (0x14)
> > +#define UARTCTRL          (0x18)
> > +#define UARTDATA          (0x1C)
> > +#define UARTMATCH         (0x20)
> > +#define UARTMODIR         (0x24)
> > +#define UARTFIFO          (0x28)
> > +#define UARTWATER         (0x2c)
> > +
> > +#define UARTSTAT_TDRE     BIT(23, UL)
> > +#define UARTSTAT_TC       BIT(22, UL)
> > +#define UARTSTAT_RDRF     BIT(21, UL)
> > +#define UARTSTAT_OR       BIT(19, UL)
> > +
> > +#define UARTBAUD_OSR_SHIFT    (24)
> > +#define UARTBAUD_OSR_MASK     (0x1f)
> > +#define UARTBAUD_SBR_MASK     (0x1fff)
> > +#define UARTBAUD_BOTHEDGE     (0x00020000)
> > +#define UARTBAUD_TDMAE        (0x00800000)
> > +#define UARTBAUD_RDMAE        (0x00200000)
> > +
> > +#define UARTCTRL_TIE      BIT(23, UL)
> > +#define UARTCTRL_TCIE     BIT(22, UL)
> > +#define UARTCTRL_RIE      BIT(21, UL)
> > +#define UARTCTRL_ILIE     BIT(20, UL)
> > +#define UARTCTRL_TE       BIT(19, UL)
> > +#define UARTCTRL_RE       BIT(18, UL)
> > +#define UARTCTRL_M        BIT(4, UL)
> > +
> > +#define UARTWATER_RXCNT_OFF     24
> > +
> > +#endif /* __ASM_ARM_IMX_LPUART_H__ */
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index
> > 2ff5b288e2..e5f7b1d8eb 100644
> > --- a/xen/drivers/char/Kconfig
> > +++ b/xen/drivers/char/Kconfig
> > @@ -13,6 +13,13 @@ config HAS_CADENCE_UART
> >  	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zyn=
q
> >  	  based board, say Y.
> >
> > +config HAS_IMX_LPUART
> > +	bool "i.MX LPUART driver"
> > +	default y
> > +	depends on ARM_64
> > +	help
> > +	  This selects the i.MX LPUART. If you have i.MX8QM based board, say =
Y.
> > +
> >  config HAS_MVEBU
> >  	bool "Marvell MVEBU UART driver"
> >  	default y
> > diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
> > index 7c646d771c..14e67cf072 100644
> > --- a/xen/drivers/char/Makefile
> > +++ b/xen/drivers/char/Makefile
> > @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) +=3D mvebu-uart.o
> >  obj-$(CONFIG_HAS_OMAP) +=3D omap-uart.o
> >  obj-$(CONFIG_HAS_SCIF) +=3D scif-uart.o
> >  obj-$(CONFIG_HAS_EHCI) +=3D ehci-dbgp.o
> > +obj-$(CONFIG_HAS_IMX_LPUART) +=3D imx-lpuart.o
> >  obj-$(CONFIG_ARM) +=3D arm-uart.o
> >  obj-y +=3D serial.o
> >  obj-$(CONFIG_XEN_GUEST) +=3D xen_pv_console.o diff --git
> > a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c new
> > file mode 100644 index 0000000000..df44f91e5d
> > --- /dev/null
> > +++ b/xen/drivers/char/imx-lpuart.c
> > @@ -0,0 +1,276 @@
> > +/*
> > + * xen/drivers/char/imx-lpuart.c
> > + *
> > + * Driver for i.MX LPUART.
> > + *
> > + * Peng Fan <peng.fan@nxp.com>
> > + * Copyright 2022 NXP
> > + *
> > + * This program is free software; you can redistribute it and/or
> > +modify
> > + * it under the terms of the GNU General Public License as published
> > +by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <xen/errno.h>
> > +#include <xen/init.h>
> > +#include <xen/irq.h>
> > +#include <xen/mm.h>
> > +#include <xen/serial.h>
> > +#include <asm/device.h>
> > +#include <asm/imx-lpuart.h>
> > +#include <asm/io.h>
> > +
> > +#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
> > +#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs +
> > +off)
> > +
> > +static struct imx_lpuart {
> > +    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
> > +    uint32_t irq;
> > +    char __iomem *regs;
> > +    struct irqaction irqaction;
> > +    struct vuart_info vuart;
> > +} imx8_com;
> > +
> > +static void imx_lpuart_interrupt(int irq, void *data,
> > +                                 struct cpu_user_regs *regs) {
> > +    struct serial_port *port =3D data;
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t sts, rxcnt;
> > +
> > +    sts =3D imx_lpuart_read(uart, UARTSTAT);
> > +    rxcnt =3D imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
> > +
> > +    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
> > +	    serial_rx_interrupt(port, regs);
> > +
> > +    if ( sts & UARTSTAT_TDRE )
> > +	    serial_tx_interrupt(port, regs);
> > +
> > +    imx_lpuart_write(uart, UARTSTAT, sts); }
> > +
> > +static void __init imx_lpuart_init_preirq(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t ctrl, old_ctrl, bd;
> > +
> > +    old_ctrl =3D imx_lpuart_read(uart, UARTCTRL);
> > +    ctrl =3D (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
> > +    bd =3D imx_lpuart_read(uart, UARTBAUD);
> > +
> > +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
> > +	    cpu_relax();
> > +
> > +    /* Disable transmit and receive */
> > +    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE |
> > + UARTCTRL_RE));
> > +
> > +    /* Reuse firmware baudrate settings, only disable DMA here */
> > +    bd &=3D ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
> > +
> > +    imx_lpuart_write(uart, UARTMODIR, 0);
> > +    imx_lpuart_write(uart, UARTBAUD, bd);
> > +    imx_lpuart_write(uart, UARTCTRL, ctrl); }
> > +
> > +static void __init imx_lpuart_init_postirq(struct serial_port *port)
> > +{
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t temp;
> > +
> > +    uart->irqaction.handler =3D imx_lpuart_interrupt;
> > +    uart->irqaction.name =3D "imx_lpuart";
> > +    uart->irqaction.dev_id =3D port;
> > +
> > +    if ( setup_irq(uart->irq, 0, &uart->irqaction) !=3D 0 )
> > +    {
> > +        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
> > +                uart->irq);
> > +        return;
> > +    }
> > +
> > +    /* Enable interrupts */
> > +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> > +    temp |=3D (UARTCTRL_RIE | UARTCTRL_TIE);
> > +    temp |=3D UARTCTRL_ILIE;
> > +    imx_lpuart_write(uart, UARTCTRL, temp); }
> > +
> > +static void imx_lpuart_suspend(struct serial_port *port) {
> > +    BUG();
> > +}
> > +
> > +static void imx_lpuart_resume(struct serial_port *port) {
> > +    BUG();
> > +}
> > +
> > +static int imx_lpuart_tx_ready(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +
> > +    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC; }
> > +
> > +static void imx_lpuart_putc(struct serial_port *port, char c) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +
> > +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
> > +        cpu_relax();
> > +
> > +    imx_lpuart_write(uart, UARTDATA, c); }
> > +
> > +static int imx_lpuart_getc(struct serial_port *port, char *pc) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    int ch;
> > +
> > +    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
> > +	    return 0;
> > +
> > +    ch =3D imx_lpuart_read(uart, UARTDATA);
> > +    *pc =3D ch & 0xff;
> > +
> > +    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
> > +        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
> > +
> > +    return 1;
> > +}
> > +
> > +static int __init imx_lpuart_irq(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +
> > +    return ((uart->irq > 0) ? uart->irq : -1); }
> > +
> > +static const struct vuart_info *imx_lpuart_vuart_info(struct
> > +serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +
> > +    return &uart->vuart;
> > +}
> > +
> > +static void imx_lpuart_start_tx(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t temp;
> > +
> > +    temp =3D imx_lpuart_read(uart, UARTSTAT);
> > +    /* Wait until empty */
> > +    while ( !(temp & UARTSTAT_TDRE) )
> > +	    cpu_relax();
>=20
> It looks like this is looping over a stale variable?

Oh, yeah, good catch.


Thanks,
Peng.

>=20
>=20
> > +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> > +    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE)); }
> > +
> > +static void imx_lpuart_stop_tx(struct serial_port *port) {
> > +    struct imx_lpuart *uart =3D port->uart;
> > +    uint32_t temp;
> > +
> > +    temp =3D imx_lpuart_read(uart, UARTCTRL);
> > +    temp &=3D ~(UARTCTRL_TIE | UARTCTRL_TCIE);
> > +    imx_lpuart_write(uart, UARTCTRL, temp); }
> > +
> > +static struct uart_driver __read_mostly imx_lpuart_driver =3D {
> > +    .init_preirq =3D imx_lpuart_init_preirq,
> > +    .init_postirq =3D imx_lpuart_init_postirq,
> > +    .endboot =3D NULL,
> > +    .suspend =3D imx_lpuart_suspend,
> > +    .resume =3D imx_lpuart_resume,
> > +    .tx_ready =3D imx_lpuart_tx_ready,
> > +    .putc =3D imx_lpuart_putc,
> > +    .getc =3D imx_lpuart_getc,
> > +    .irq =3D imx_lpuart_irq,
> > +    .start_tx =3D imx_lpuart_start_tx,
> > +    .stop_tx =3D imx_lpuart_stop_tx,
> > +    .vuart_info =3D imx_lpuart_vuart_info, };
> > +
> > +static int __init imx_lpuart_init(struct dt_device_node *dev,
> > +                                  const void *data) {
> > +    const char *config =3D data;
> > +    struct imx_lpuart *uart;
> > +    int res;
> > +    u64 addr, size;
> > +
> > +    if ( strcmp(config, "") )
> > +        printk("WARNING: UART configuration is not supported\n");
> > +
> > +    uart =3D &imx8_com;
> > +
> > +    uart->baud =3D 115200;
> > +    uart->data_bits =3D 8;
> > +    uart->parity =3D 0;
> > +    uart->stop_bits =3D 1;
> > +
> > +    res =3D dt_device_get_address(dev, 0, &addr, &size);
> > +    if ( res )
> > +    {
> > +        printk("imx8-lpuart: Unable to retrieve the base"
> > +               " address of the UART\n");
> > +        return res;
> > +    }
> > +
> > +    res =3D platform_get_irq(dev, 0);
> > +    if ( res < 0 )
> > +    {
> > +        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
> > +        return -EINVAL;
> > +    }
> > +    uart->irq =3D res;
> > +
> > +    uart->regs =3D ioremap_nocache(addr, size);
> > +    if ( !uart->regs )
> > +    {
> > +        printk("imx8-lpuart: Unable to map the UART memory\n");
> > +        return -ENOMEM;
> > +    }
> > +
> > +    uart->vuart.base_addr =3D addr;
> > +    uart->vuart.size =3D size;
> > +    uart->vuart.data_off =3D UARTDATA;
> > +    /* tmp from uboot */
> > +    uart->vuart.status_off =3D UARTSTAT;
> > +    uart->vuart.status =3D UARTSTAT_TDRE;
> > +
> > +    /* Register with generic serial driver */
> > +    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
> > +
> > +    dt_device_set_used_by(dev, DOMID_XEN);
> > +
> > +    return 0;
> > +}
> > +
> > +static const struct dt_device_match imx_lpuart_dt_compat[]
> > +__initconst =3D {
> > +    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
> > +    { /* sentinel */ },
> > +};
> > +
> > +DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
> > +    .dt_match =3D imx_lpuart_dt_compat,
> > +    .init =3D imx_lpuart_init,
> > +DT_DEVICE_END
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > --
> > 2.35.1
> >


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 01:19:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 01:19:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306816.521981 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngG2X-0001Ym-3Y; Mon, 18 Apr 2022 01:18:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306816.521981; Mon, 18 Apr 2022 01:18:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngG2X-0001Yf-0o; Mon, 18 Apr 2022 01:18:53 +0000
Received: by outflank-mailman (input) for mailman id 306816;
 Mon, 18 Apr 2022 01:18:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngG2V-0001YV-Cu; Mon, 18 Apr 2022 01:18:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngG2V-0008KZ-AK; Mon, 18 Apr 2022 01:18:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngG2U-0003Q0-Uu; Mon, 18 Apr 2022 01:18:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngG2U-0007To-UT; Mon, 18 Apr 2022 01:18:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KCqMoDaatC9zWGYqi9a0xyuCwd1rx4wFSRlPpKRrrQE=; b=jwuzyJuJhHyocBrJmOkYTDaC/n
	u56+wQo6oe7S5XO3EHrT9HeC9gM12siy/EyWqeXIseUxvQoZ+OJmmQL/94fyPEebXbHeZPVkPuDrf
	tMeb/mYVurvv4GVFpccoEbe4P/oTjhlBv7g6t0sVp2cJbAKpVkp1U+vYenmeQGu569ws=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169497-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169497: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 01:18:50 +0000

flight 169497 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169497/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   47 days  469 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   45 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 01:29:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 01:29:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306825.521994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngGCz-00036v-70; Mon, 18 Apr 2022 01:29:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306825.521994; Mon, 18 Apr 2022 01:29:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngGCz-00036o-1U; Mon, 18 Apr 2022 01:29:41 +0000
Received: by outflank-mailman (input) for mailman id 306825;
 Mon, 18 Apr 2022 01:29:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SHO4=U4=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ngGCx-00036h-BA
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 01:29:39 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0280fffe-beb7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 03:29:37 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id 77A9B1F44320
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0280fffe-beb7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1650245376;
	bh=Ajn7d9ehxuO5NknWvmo0k/aIhgzNt/YPk9MMAC0rgK4=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=H6wbrzdvBv8/q0QMxBBTynYiA8MocDKNi6pPzdbeah1TBS0sfobjoYMeVHdywDKJa
	 YOMseWFehs7fKiS1bqLxpLaRV3E2gVJ6NGmAk/kK7Tkj7SOk+d7kIA+pVboML+0znZ
	 oBB6ZdZaJe8q4CuDbVjC8i5gSLP4M7dhUJeJhWywSpYx0y55HsGlo0NSg/sn82x813
	 XAZwVlD5NoEcUOWKl8ezQsrDqxJrPlOK3xiszEQs//fITbMqaQ95IAUW03Xr4Fzay/
	 IWbATXa2Chl0Jy2VqKMQd994g2oQEgzNvPwVOvB9VgKGF8p+Y8PjFoazCNalTfgpXO
	 TGCe7ZBTJXzKg==
Message-ID: <fa20ae2f-e265-c713-493d-5b2ebcdf7f0a@collabora.com>
Date: Mon, 18 Apr 2022 04:29:30 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v7 03/20] reboot: Print error message if restart handler
 has duplicated priority
Content-Language: en-US
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzk@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
 Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org,
 "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
 linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
 Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <20220411233832.391817-4-dmitry.osipenko@collabora.com>
 <CAJZ5v0gf1J+yPW14TAdLGLGfO+-2s=r0DDP7d+Rgop3=dB0gaQ@mail.gmail.com>
 <af51d9d0-26ba-fc66-05f1-d92ef7172730@collabora.com>
 <CAJZ5v0jFQi1x1Fnfk04n+HTTirz19-_xW2NgJtpOYyPgVh3Afw@mail.gmail.com>
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
In-Reply-To: <CAJZ5v0jFQi1x1Fnfk04n+HTTirz19-_xW2NgJtpOYyPgVh3Afw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/14/22 14:19, Rafael J. Wysocki wrote:
> On Thu, Apr 14, 2022 at 12:24 AM Dmitry Osipenko
> <dmitry.osipenko@collabora.com> wrote:
>>
>> On 4/13/22 21:48, Rafael J. Wysocki wrote:
>>> On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
>>> <dmitry.osipenko@collabora.com> wrote:
>>>>
>>>> Add sanity check which ensures that there are no two restart handlers
>>>> registered using the same priority. This requirement will become mandatory
>>>> once all drivers will be converted to the new API and such errors will be
>>>> fixed.
>>>>
>>>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>
>>> The first two patches in the series are fine with me and there's only
>>> one minor nit regarding this one (below).
>>>
>>>> ---
>>>>  kernel/reboot.c | 15 +++++++++++++++
>>>>  1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/kernel/reboot.c b/kernel/reboot.c
>>>> index ed4e6dfb7d44..acdae4e95061 100644
>>>> --- a/kernel/reboot.c
>>>> +++ b/kernel/reboot.c
>>>> @@ -182,6 +182,21 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
>>>>   */
>>>>  int register_restart_handler(struct notifier_block *nb)
>>>>  {
>>>> +       int ret;
>>>> +
>>>> +       ret = atomic_notifier_chain_register_unique_prio(&restart_handler_list, nb);
>>>> +       if (ret != -EBUSY)
>>>> +               return ret;
>>>> +
>>>> +       /*
>>>> +        * Handler must have unique priority. Otherwise call order is
>>>> +        * determined by registration order, which is unreliable.
>>>> +        *
>>>> +        * This requirement will become mandatory once all drivers
>>>> +        * will be converted to use new sys-off API.
>>>> +        */
>>>> +       pr_err("failed to register restart handler using unique priority\n");
>>>
>>> I would use pr_info() here, because this is not a substantial error AFAICS.
>>
>> It's indeed not a substantial error so far, but it will become
>> substantial later on once only unique priorities will be allowed. The
>> pr_warn() could be a good compromise here, pr_info() is too mild, IMO.
> 
> Well, I'm still unconvinced about requiring all of the users of this
> interface to use unique priorities.
> 
> Arguably, there are some of them who don't really care about the
> ordering, so could there be an option for them to specify the lack of
> care by, say, passing 0 as the priority that would be regarded as a
> special case?
> 
> IOW, if you pass 0, you'll be run along the others who've also passed
> 0, but if you pass anything different from 0, it must be unique.  What
> do you think?

There are indeed cases where ordering is unimportant. Like a case of
PMIC and watchdog restart handlers for example, both handlers will
produce equal effect from a user's perspective. Perhaps indeed it's more
practical to have at least one shared level.

In this patchset the level 0 is specified as an alias to the default
level 128. If one user registers handler using unique level 128 and the
other user uses non-unique level 0, then we have ambiguity.

One potential option is to make the whole default level 128 non-unique.
This will allow users to not care about the uniqueness by default like
they always did it previously, but it will hide potential problems for
users who actually need unique level and don't know about it yet due to
a lucky registration ordering that they have today. Are you okay with
this option?


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 01:44:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 01:44:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306831.522004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngGRU-0005Vp-Ff; Mon, 18 Apr 2022 01:44:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306831.522004; Mon, 18 Apr 2022 01:44:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngGRU-0005Vh-Aa; Mon, 18 Apr 2022 01:44:40 +0000
Received: by outflank-mailman (input) for mailman id 306831;
 Mon, 18 Apr 2022 01:44:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SHO4=U4=collabora.com=dmitry.osipenko@srs-se1.protection.inumbo.net>)
 id 1ngGRS-0005Vb-Sk
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 01:44:39 +0000
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1998219e-beb9-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 03:44:35 +0200 (CEST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
 (Authenticated sender: dmitry.osipenko) with ESMTPSA id BA62C1F44208
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1998219e-beb9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
	s=mail; t=1650246274;
	bh=nlFxW1H4DpgW9qavO+5IvwxFDk2mDdf2XZlYpkCCJTM=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=TYGkKJ4d25ZsDTsjZYO+SiMLeCTZL7QLa8dlcHjU7GBCUbYJrPrpkRjNOL+3qx9f+
	 8DhGHaUHqR2C+BQ59mazBzIx8EGKsBCEUujaoWcS4g5fJQTSLlaBDHvfWDTiWwHFcc
	 Z0LLc8UihIbMlV3x8/sTjPqrXn6lx+O/1YmkAK2N9B28kSrTCUox2RxJFfTcdbJidK
	 Gprolr/37VhjviiRj9FC44P7fMOwq3iXjr60SCQIiC+uq/ODXT/+m6ku89lPvSgdr8
	 9wO0O/Bj0alQQUngCS7PTA5vTRqvxsQAlRtPtBHzcOLMOk5FMLSYCQxo7tfuamLs4u
	 gevPmNYwz67Iw==
Message-ID: <990621e7-9f8a-8b4a-02ec-fd6c1e1f48ff@collabora.com>
Date: Mon, 18 Apr 2022 04:44:26 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler
 call chain API
Content-Language: en-US
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzk@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
 Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org,
 "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
 linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
 Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <20220411233832.391817-5-dmitry.osipenko@collabora.com>
 <CAJZ5v0gnTSoeNP+QXwrZ45FQY4howVkJMuCjM=j+_-2BngJdQg@mail.gmail.com>
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
In-Reply-To: <CAJZ5v0gnTSoeNP+QXwrZ45FQY4howVkJMuCjM=j+_-2BngJdQg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/15/22 21:14, Rafael J. Wysocki wrote:
> Honestly, I would prefer this to be split so as to make it easier to
> review if nothing else.

I'll try to split it in v8.

> On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
> <dmitry.osipenko@collabora.com> wrote:
>>
>> SoC platforms often have multiple ways of how to perform system's
>> power-off and restart operations. Meanwhile today's kernel is limited to
>> a single option. Add combined power-off+restart handler call chain API,
>> which is inspired by the restart API. The new API provides both power-off
>> and restart functionality.
>>
>> The old pm_power_off method will be kept around till all users are
>> converted to the new API.
>>
>> Current restart API will be replaced by the new unified API since
>> new API is its superset. The restart functionality of the sys-off handler
>> API is built upon the existing restart-notifier APIs.
> 
> Which means that the existing notifier chains for system restart are
> used as they are without modifications.
> 
> At least that's what follows from the code and it would be good to
> mention it here.

Will improve the commit message.

> Moreover, a new notifier chain is introduced for the power-off case
> and it appears to be the counterpart of the restart_handler_list
> chain, but then why is it blocking and not atomic like the latter?

Good catch, it probably indeed should be atomic because shutting down
could run with a disabled interrupts. I'll invistigate this more for v8,
at least right now I don't recall any particular reason for using the
blocking notifier.

>> In order to ease conversion to the new API, convenient helpers are added
>> for the common use-cases. They will reduce amount of boilerplate code and
>> remove global variables. These helpers preserve old behaviour for cases
>> where only one power-off handler is expected, this is what all existing
>> drivers want, and thus, they could be easily converted to the new API.
>> Users of the new API should explicitly enable power-off chaining by
>> setting corresponding flag of the power_handler structure.
> 
> "the corresponding"

Thanks

>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> ---
>>  include/linux/reboot.h   | 229 ++++++++++++++-
>>  kernel/power/hibernate.c |   2 +-
>>  kernel/reboot.c          | 604 ++++++++++++++++++++++++++++++++++++++-
>>  3 files changed, 827 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/linux/reboot.h b/include/linux/reboot.h
>> index a2429648d831..ba5e5dddcfcd 100644
>> --- a/include/linux/reboot.h
>> +++ b/include/linux/reboot.h
>> @@ -8,10 +8,35 @@
>>
>>  struct device;
>>
>> -#define SYS_DOWN       0x0001  /* Notify of system down */
>> -#define SYS_RESTART    SYS_DOWN
>> -#define SYS_HALT       0x0002  /* Notify of system halt */
>> -#define SYS_POWER_OFF  0x0003  /* Notify of system power off */
>> +enum reboot_prepare_mode {
>> +       SYS_DOWN = 1,           /* Notify of system down */
>> +       SYS_RESTART = SYS_DOWN,
>> +       SYS_HALT,               /* Notify of system halt */
>> +       SYS_POWER_OFF,          /* Notify of system power off */
>> +};
>> +
>> +/*
>> + * Standard restart priority levels. Intended to be set in the
>> + * sys_off_handler.restart_priority field.
>> + *
>> + * Use `RESTART_PRIO_ABC +- prio` style for additional levels.
>> + *
>> + * RESTART_PRIO_RESERVED:      Falls back to RESTART_PRIO_DEFAULT.
>> + *                             Drivers may leave priority initialized
>> + *                             to zero, to auto-set it to the default level.
> 
> What is the "default level" here?

"default level" = RESTART_PRIO_DEFAULT = 128

I'll remove the second sentence about the "default level", for clarity.

>> + *
>> + * RESTART_PRIO_LOW:           Use this for handler of last resort.
>> + *
>> + * RESTART_PRIO_DEFAULT:       Use this for default/generic handler.
>> + *
>> + * RESTART_PRIO_HIGH:          Use this if you have multiple handlers and
>> + *                             this handler has higher priority than the
>> + *                             default handler.
>> + */
>> +#define RESTART_PRIO_RESERVED          0
>> +#define RESTART_PRIO_LOW               8
>> +#define RESTART_PRIO_DEFAULT           128
>> +#define RESTART_PRIO_HIGH              192
>>
>>  enum reboot_mode {
>>         REBOOT_UNDEFINED = -1,
>> @@ -49,6 +74,201 @@ extern int register_restart_handler(struct notifier_block *);
>>  extern int unregister_restart_handler(struct notifier_block *);
>>  extern void do_kernel_restart(char *cmd);
>>
>> +/*
>> + * System power-off and restart API.
>> + */
>> +
>> +/*
>> + * Standard power-off priority levels. Intended to be set in the
>> + * sys_off_handler.power_off_priority field.
>> + *
>> + * Use `POWEROFF_PRIO_ABC +- prio` style for additional levels.
> 
> What exactly does this mean?

"POWEROFF_PRIO_DEFAULT+1 or POWEROFF_PRIO_DEFAULT-1" for example, I'll
improve it in v8.

>> + *
>> + * POWEROFF_PRIO_RESERVED:     Falls back to POWEROFF_PRIO_DEFAULT.
>> + *                             Drivers may leave priority initialized
>> + *                             to zero, to auto-set it to the default level.
>> + *
>> + * POWEROFF_PRIO_PLATFORM:     Intended to be used by platform-level handler.
>> + *                             Has lowest priority since device drivers are
>> + *                             expected to take over platform handler which
>> + *                             doesn't allow further callback chaining.
>> + *
>> + * POWEROFF_PRIO_DEFAULT:      Use this for default/generic handler.
>> + *
>> + * POWEROFF_PRIO_FIRMWARE:     Use this if handler uses firmware call.
>> + *                             Has highest priority since firmware is expected
>> + *                             to know best how to power-off hardware properly.
>> + */
>> +#define POWEROFF_PRIO_RESERVED         0
>> +#define POWEROFF_PRIO_PLATFORM         1
>> +#define POWEROFF_PRIO_DEFAULT          128
>> +#define POWEROFF_PRIO_HIGH             192
>> +#define POWEROFF_PRIO_FIRMWARE         224
>> +
>> +enum poweroff_mode {
>> +       POWEROFF_NORMAL = 0,
> 
> Why not just POWEROFF?

This is a bit too generic name to me.

I can rename it as MODE_POWEROFF and MODE_POWEROFF_PREPARE.

>> +       POWEROFF_PREPARE,
>> +};
>> +
>> +/**
>> + * struct power_off_data - Power-off callback argument
>> + *
>> + * @cb_data: Callback data.
>> + */
>> +struct power_off_data {
>> +       void *cb_data;
>> +};
>> +
>> +/**
>> + * struct power_off_prep_data - Power-off preparation callback argument
>> + *
>> + * @cb_data: Callback data.
>> + */
>> +struct power_off_prep_data {
>> +       void *cb_data;
>> +};
> 
> Why does this need to be a separate data type?

To allow us extend the "struct power_off_prep_data" with more parameters
later on without a need to update each driver with the new arguments.

>> +
>> +/**
>> + * struct restart_data - Restart callback argument
>> + *
>> + * @cb_data: Callback data.
>> + * @cmd: Restart command string.
>> + * @stop_chain: Further lower priority callbacks won't be executed if set to
>> + *             true. Can be changed within callback. Default is false.
>> + * @mode: Reboot mode ID.
>> + */
>> +struct restart_data {
>> +       void *cb_data;
>> +       const char *cmd;
>> +       bool stop_chain;
>> +       enum reboot_mode mode;
>> +};
>> +
>> +/**
>> + * struct reboot_prep_data - Reboot and shutdown preparation callback argument
>> + *
>> + * @cb_data: Callback data.
>> + * @cmd: Restart command string.
>> + * @stop_chain: Further lower priority callbacks won't be executed if set to
>> + *             true. Can be changed within callback. Default is false.
>> + * @mode: Preparation mode ID.
>> + */
>> +struct reboot_prep_data {
>> +       void *cb_data;
>> +       const char *cmd;
>> +       bool stop_chain;
>> +       enum reboot_prepare_mode mode;
>> +};
> 
> There seem to be some duplicate data items between struct restart_data
> and struct reboot_prep_data, so what's the reason why they are
> separate?

They indeed look similar, but have different purposes. We shouldn't use
reboot handler for restarting, hence why should we mix them?

>> +struct sys_off_handler_private_data {
>> +       struct notifier_block power_off_nb;
>> +       struct notifier_block restart_nb;
>> +       struct notifier_block reboot_nb;
> 
> So restart_nb is going to be added to restart_handler_list, eboot_nb
> will be added to reboot_notifier_list (which both exist already) and
> power_off_nb will be added to the new power_off_handler_list, right?
> 
> Of course, this means that reboot_nb will be used in
> kernel_restart_prepare() and kernel_shutdown_prepare(), so the
> corresponding callback will be invoked in both the restart and
> power-off cases.
> 
> It would be good to document that somehow.

This is documented in the doc-comment to struct sys_off_handler later in
this patch. You actually found it below.

>> +       void (*platform_power_off_cb)(void);
>> +       void (*simple_power_off_cb)(void *data);
>> +       void *simple_power_off_cb_data;
> 
> Is there any particular reason to put these callbacks here and not
> directly into struct sys_off_handler?

They are used internally by reboot.c and shouldn't be touched by the
kernel API users, so I wanted to factor out and protect all the private
data.

>> +       bool registered;
>> +};
>> +
>> +/**
>> + * struct sys_off_handler - System power-off and restart handler
>> + *
>> + * @cb_data: Pointer to user's data.
>> + *
>> + * @power_off_cb: Callback that powers off this machine. Inactive if NULL.
>> + *
>> + * @power_off_prepare_cb: Power-off preparation callback. All power-off
>> + * preparation callbacks are invoked after @reboot_prepare_cb and before
>> + * @power_off_cb. Inactive if NULL.
>> + *
>> + * @power_off_priority: Power-off callback priority, must be unique.
>> + * Zero value is reserved and auto-reassigned to POWEROFF_PRIO_DEFAULT.
>> + * Inactive if @power_off_cb is NULL.
>> + *
>> + * @power_off_chaining_allowed: Set to false if callback's execution should
>> + * stop when @power_off_cb fails to power off this machine. True if further
>> + * lower priority power-off callback should be executed. False is default
>> + * value.
>> + *
>> + * @restart_cb: Callback that reboots this machine. Inactive if NULL.
>> + *
>> + * @restart_priority: Restart callback priority, must be unique. Zero value
>> + * is reserved and auto-reassigned to RESTART_PRIO_DEFAULT. Inactive if
>> + * @restart_cb is NULL.
>> + *
>> + * @restart_chaining_disallowed: Set to true if callback's execution should
>> + * stop when @restart_cb fails to restart this machine. False if further
>> + * lower priority restart callback should be executed. False is default
>> + * value.
>> + *
>> + * @reboot_prepare_cb: Reboot/shutdown preparation callback. All reboot
>> + * preparation callbacks are invoked before @restart_cb or @power_off_cb,
>> + * depending on the mode. It's registered with register_reboot_notifier().
>> + * The point is to remove boilerplate code from drivers which use this
>> + * callback in conjunction with the restart/power-off callbacks.
>> + *
>> + * @reboot_priority: Reboot/shutdown preparation callback priority, doesn't
>> + * need to be unique. Zero is default value. Inactive if @reboot_prepare_cb
>> + * is NULL.
> 
> It is unclear that the ->reboot_prepare_cb() callback is going to be
> used for both restart and power-off and reboot_priority is about the
> preparation phase only.
> 
> And in the preparation phase the priority may not matter that much,
> because there are users who don't care about the ordering as long as
> their stuff is called at all.
> 
> Honestly, I would change the naming here, because what it is is quite
> confusing at least to me.  Especially that "restart" and "reboot" seem
> to be used interchangeably in the comments.

These are the legacy names and they are indeed very confusing. Do you
have suggestion for a better names?

>> + *
>> + * @priv: Internal data. Shouldn't be touched.
>> + *
>> + * Describes power-off and restart handlers which are invoked by kernel
>> + * to power off or restart this machine. Supports prioritized chaining for
>> + * both restart and power-off handlers.
>> + *
>> + * Struct sys_off_handler can be static. Members of this structure must not be
>> + * altered while handler is registered.
>> + *
>> + * Fill the structure members and pass it to @register_sys_off_handler().
>> + */
>> +struct sys_off_handler {
>> +       void *cb_data;
>> +
>> +       void (*power_off_cb)(struct power_off_data *data);
>> +       void (*power_off_prepare_cb)(struct power_off_prep_data *data);
>> +       int power_off_priority;
>> +       bool power_off_chaining_allowed;
>> +
>> +       void (*restart_cb)(struct restart_data *data);
>> +       int restart_priority;
>> +       bool restart_chaining_disallowed;
>> +
>> +       void (*reboot_prepare_cb)(struct reboot_prep_data *data);
>> +       int reboot_priority;
>> +
>> +       const struct sys_off_handler_private_data priv;
> 
> Why is it const?  Because of the callbacks in there?

It's const to prevent changing/abusing of the internal data by kernel
API users. Those callbacks are private to kernel/reboot.c

> Doesn't this mean that all struct sys_off_handler need to be static?

The reboot.c is allowed to modify the private data, sys_off_handler can
be static and dynamic. There is no limitaion, I made the 'priv' member
constant only for the API users.

>> +};
>> +
>> +int register_sys_off_handler(struct sys_off_handler *handler);
>> +int unregister_sys_off_handler(struct sys_off_handler *handler);
>> +
>> +int devm_register_sys_off_handler(struct device *dev,
>> +                                 struct sys_off_handler *handler);
>> +
>> +int devm_register_prioritized_power_off_handler(struct device *dev,
>> +                                               int priority,
>> +                                               void (*callback)(void *data),
>> +                                               void *cb_data);
>> +
>> +int devm_register_simple_power_off_handler(struct device *dev,
>> +                                          void (*callback)(void *data),
>> +                                          void *cb_data);
>> +
>> +int register_platform_power_off(void (*power_off)(void));
>> +int unregister_platform_power_off(void (*power_off)(void));
>> +
>> +int devm_register_prioritized_restart_handler(struct device *dev,
>> +                                             int priority,
>> +                                             void (*callback)(struct restart_data *data),
>> +                                             void *cb_data);
>> +
>> +int devm_register_simple_restart_handler(struct device *dev,
>> +                                        void (*callback)(struct restart_data *data),
>> +                                        void *cb_data);
>> +
>> +void do_kernel_power_off(void);
>> +
>>  /*
>>   * Architecture-specific implementations of sys_reboot commands.
>>   */
>> @@ -70,6 +290,7 @@ extern void kernel_restart_prepare(char *cmd);
>>  extern void kernel_restart(char *cmd);
>>  extern void kernel_halt(void);
>>  extern void kernel_power_off(void);
>> +extern bool kernel_can_power_off(void);
>>
>>  void ctrl_alt_del(void);
>>
>> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
>> index 938d5c78b421..a9464b4a3209 100644
>> --- a/kernel/power/hibernate.c
>> +++ b/kernel/power/hibernate.c
>> @@ -665,7 +665,7 @@ static void power_down(void)
>>                 hibernation_platform_enter();
>>                 fallthrough;
>>         case HIBERNATION_SHUTDOWN:
>> -               if (pm_power_off)
>> +               if (kernel_can_power_off())
>>                         kernel_power_off();
>>                 break;
>>         }
>> diff --git a/kernel/reboot.c b/kernel/reboot.c
>> index acdae4e95061..e76e2570dcf5 100644
>> --- a/kernel/reboot.c
>> +++ b/kernel/reboot.c
>> @@ -296,6 +296,595 @@ void kernel_halt(void)
>>  }
>>  EXPORT_SYMBOL_GPL(kernel_halt);
>>
>> +/*
>> + *     Notifier list for kernel code which wants to be called
>> + *     to power off the system.
>> + */
>> +static BLOCKING_NOTIFIER_HEAD(power_off_handler_list);
>> +
>> +/*
>> + * Temporary stub that prevents linkage failure while we're in process
>> + * of removing all uses of legacy pm_power_off() around the kernel.
> 
> Nit: inconsistent comment formatting.
> 
>> + */
>> +void __weak (*pm_power_off)(void);
>> +
>> +static void dummy_pm_power_off(void)
>> +{
>> +       /* temporary stub until pm_power_off() is gone, see more below */
>> +}
>> +
>> +static struct notifier_block *pm_power_off_nb;
>> +
>> +/**
>> + *     register_power_off_handler - Register function to be called to power off
>> + *                                  the system
>> + *     @nb: Info about handler function to be called
>> + *     @nb->priority:  Handler priority. Handlers should follow the
>> + *                     following guidelines for setting priorities.
>> + *                     0:      Reserved
>> + *                     1:      Power-off handler of last resort,
>> + *                             with limited power-off capabilities
>> + *                     128:    Default power-off handler; use if no other
>> + *                             power-off handler is expected to be available,
>> + *                             and/or if power-off functionality is
>> + *                             sufficient to power-off the entire system
>> + *                     255:    Highest priority power-off handler, will
>> + *                             preempt all other power-off handlers
>> + *
>> + *     Registers a function with code to be called to power off the
>> + *     system.
> 
> Because this is only used internally in this file, I'd say what it
> does directly, that is "Add a notifier to the power-off chain used for
> powering off the system".

I'll improve it, thanks.

>> + *
>> + *     Registered functions will be called as last step of the power-off
>> + *     sequence.
>> + *
>> + *     Registered functions are expected to power off the system immediately.
>> + *     If more than one function is registered, the power-off handler priority
>> + *     selects which function will be called first.
>> + *
>> + *     Power-off handlers are expected to be registered from non-architecture
>> + *     code, typically from drivers. A typical use case would be a system
>> + *     where power-off functionality is provided through a PMIC. Multiple
>> + *     power-off handlers may exist; for example, one power-off handler might
>> + *     turn off the entire system, while another only turns off part of
>> + *     system. In such cases, the power-off handler which only disables part
>> + *     of the hardware is expected to register with low priority to ensure
>> + *     that it only runs if no other means to power off the system is
>> + *     available.
> 
> I would move the above 3 paragraphs to the description comment for
> power_off_handler_list.

Noted

>> + *
>> + *     Currently always returns zero, as blocking_notifier_chain_register()
>> + *     always returns zero.
>> + */
>> +static int register_power_off_handler(struct notifier_block *nb)
>> +{
>> +       int ret;
>> +
>> +       ret = blocking_notifier_chain_register_unique_prio(&power_off_handler_list, nb);
>> +       if (ret && ret != -EBUSY)
>> +               return ret;
>> +
>> +       if (!ret)
>> +               goto set_pm_power_off;
>> +
>> +       /*
>> +        * Handler must have unique priority. Otherwise call order is
>> +        * determined by registration order, which is unreliable.
>> +        *
>> +        * This requirement will become mandatory once all drivers
>> +        * will be converted to use new sys-off API.
>> +        */
>> +       pr_err("failed to register power-off handler using unique priority\n");
>> +
>> +       ret = blocking_notifier_chain_register(&power_off_handler_list, nb);
>> +       if (ret)
>> +               return ret;
>> +
>> +       /*
>> +        * Some drivers check whether pm_power_off was already installed.
>> +        * Install dummy callback using new API to preserve old behaviour
>> +        * for those drivers during period of transition to the new API.
>> +        */
>> +set_pm_power_off:
>> +       if (!pm_power_off) {
>> +               pm_power_off = dummy_pm_power_off;
>> +               pm_power_off_nb = nb;
>> +       }
>> +
>> +       return 0;
>> +}
>> +
>> +static int unregister_power_off_handler(struct notifier_block *nb)
>> +{
>> +       if (nb == pm_power_off_nb) {
>> +               if (pm_power_off == dummy_pm_power_off)
>> +                       pm_power_off = NULL;
>> +
>> +               pm_power_off_nb = NULL;
>> +       }
>> +
>> +       return blocking_notifier_chain_unregister(&power_off_handler_list, nb);
>> +}
>> +
>> +static void devm_unregister_power_off_handler(void *data)
>> +{
>> +       struct notifier_block *nb = data;
>> +
>> +       unregister_power_off_handler(nb);
>> +}
>> +
>> +static int devm_register_power_off_handler(struct device *dev,
>> +                                          struct notifier_block *nb)
>> +{
>> +       int err;
>> +
>> +       err = register_power_off_handler(nb);
>> +       if (err)
>> +               return err;
>> +
>> +       return devm_add_action_or_reset(dev, devm_unregister_power_off_handler,
>> +                                       nb);
>> +}
>> +
>> +static int sys_off_handler_power_off(struct notifier_block *nb,
>> +                                    unsigned long mode, void *unused)
>> +{
>> +       struct power_off_prep_data prep_data = {};
>> +       struct sys_off_handler_private_data *priv;
>> +       struct power_off_data data = {};
>> +       struct sys_off_handler *h;
>> +       int ret = NOTIFY_DONE;
>> +
>> +       priv = container_of(nb, struct sys_off_handler_private_data, power_off_nb);
>> +       h = container_of(priv, struct sys_off_handler, priv);
>> +       prep_data.cb_data = h->cb_data;
>> +       data.cb_data = h->cb_data;
>> +
>> +       switch (mode) {
>> +       case POWEROFF_NORMAL:
>> +               if (h->power_off_cb)
>> +                       h->power_off_cb(&data);
>> +
>> +               if (priv->simple_power_off_cb)
>> +                       priv->simple_power_off_cb(priv->simple_power_off_cb_data);
>> +
>> +               if (priv->platform_power_off_cb)
>> +                       priv->platform_power_off_cb();
> 
> The invocation of the priv callbacks here confuses me quite a bit.
> 
> Can you please at least add a comment explaining this?

Sure

>> +
>> +               if (!h->power_off_chaining_allowed)
>> +                       ret = NOTIFY_STOP;
>> +
>> +               break;
>> +
>> +       case POWEROFF_PREPARE:
>> +               if (h->power_off_prepare_cb)
>> +                       h->power_off_prepare_cb(&prep_data);
>> +
>> +               break;
>> +
>> +       default:
>> +               unreachable();
>> +       }
>> +
>> +       return ret;
>> +}
>> +
>> +static int sys_off_handler_restart(struct notifier_block *nb,
>> +                                  unsigned long mode, void *cmd)
>> +{
>> +       struct sys_off_handler_private_data *priv;
>> +       struct restart_data data = {};
>> +       struct sys_off_handler *h;
>> +
>> +       priv = container_of(nb, struct sys_off_handler_private_data, restart_nb);
>> +       h = container_of(priv, struct sys_off_handler, priv);
>> +
>> +       data.stop_chain = h->restart_chaining_disallowed;
>> +       data.cb_data = h->cb_data;
>> +       data.mode = mode;
>> +       data.cmd = cmd;
>> +
>> +       h->restart_cb(&data);
> 
> Wouldn't it be a bit more straightforward to allow ->restart_cb() to
> return a value being either NOTIFY_STOP or NOTIFY_DONE?

Vast majority of drivers don't use the 'stop_chain', hence it's
unnecessary boilerplate code for drivers. The code looks nicer without
the boilerplate "return NOTIFY_DONE", IMO.

>> +       return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;
> 
> And I would prefer
> 
> if (data.stop_chain)
>         return NOTIFY_STOP;
> 
> return NOTIFY_DONE;

Okay

>> +}
>> +
>> +static int sys_off_handler_reboot(struct notifier_block *nb,
>> +                                 unsigned long mode, void *cmd)
>> +{
>> +       struct sys_off_handler_private_data *priv;
>> +       struct reboot_prep_data data = {};
>> +       struct sys_off_handler *h;
>> +
>> +       priv = container_of(nb, struct sys_off_handler_private_data, reboot_nb);
>> +       h = container_of(priv, struct sys_off_handler, priv);
>> +
>> +       data.cb_data = h->cb_data;
>> +       data.stop_chain = false;
>> +       data.mode = mode;
>> +       data.cmd = cmd;
>> +
>> +       h->reboot_prepare_cb(&data);
>> +
>> +       return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;
> 
> And analogously here.
> 
>> +}
>> +
>> +static struct sys_off_handler_private_data *
>> +sys_off_handler_private_data(struct sys_off_handler *handler)
>> +{
>> +       return (struct sys_off_handler_private_data *)&handler->priv;
> 
> Is the cast needed to avoid a warning about "const"?

The private data is constant to prevent the API users from using it. For
internal use we need to cast out the "const". It's a compilation error
to change the constant members.

>> +}
>> +
>> +/**
>> + *     devm_register_sys_off_handler - Register system power-off/restart handler
> 
> register_sys_off_handler

Good catch!

>> + *     @dev: Device that registers handler
>> + *     @handler: System-off handler
>> + *
>> + *     Registers handler that will be called as last step of the power-off
>> + *     and restart sequences.
> 
> Not necessarily as the last step, because there may be other system
> power-off/restart handlers called after it.
> 
> I would just say "at the end of the power-off and restart sequences".
> 
> Moreover, it registers the "reboot_cb" part that is not called "at the
> end" even.
> 
> Also, because this is the function that will be used by drivers etc to
> register handlers, I would give some more information on how the
> object registered by it is going to be used to the prospective users.

I'll improve the description, thank you.

>> + *
>> + *     Returns zero on success, or error code on failure.
>> + */
>> +int register_sys_off_handler(struct sys_off_handler *handler)
>> +{
>> +       struct sys_off_handler_private_data *priv;
>> +       int err, priority;
>> +
>> +       priv = sys_off_handler_private_data(handler);
>> +
>> +       /* sanity-check whether handler is registered twice */
>> +       if (priv->registered)
>> +               return -EBUSY;
>> +
>> +       if (handler->power_off_cb || handler->power_off_prepare_cb) {
>> +               if (handler->power_off_priority == POWEROFF_PRIO_RESERVED)
>> +                       priority = POWEROFF_PRIO_DEFAULT;
> 
> I'm not sure that this helps.
> 
> I mean, why can't the users of this new API pass POWEROFF_PRIO_DEFAULT
> directly if they want "default"?

Users could pass POWEROFF_PRIO_DEFAULT, but it's a boilerplate code
which I wanted to avoid by reserving 0 for the alias to
POWEROFF_PRIO_DEFAULT=128.

This removes a need from drivers to explicitly specify the default
priorities in the code, assuming that sys_off_handler is initialized to
zero.

>> +               else
>> +                       priority = handler->power_off_priority;
>> +
>> +               priv->power_off_nb.notifier_call = sys_off_handler_power_off;
>> +               priv->power_off_nb.priority = priority;
>> +
>> +               err = register_power_off_handler(&priv->power_off_nb);
>> +               if (err)
>> +                       goto reset_sys_off_handler;
>> +       }
>> +
>> +       if (handler->restart_cb) {
>> +               if (handler->restart_priority == RESTART_PRIO_RESERVED)
>> +                       priority = RESTART_PRIO_DEFAULT;
>> +               else
>> +                       priority = handler->restart_priority;
>> +
>> +               priv->restart_nb.notifier_call = sys_off_handler_restart;
>> +               priv->restart_nb.priority = priority;
>> +
>> +               err = register_restart_handler(&priv->restart_nb);
>> +               if (err)
>> +                       goto unreg_power_off_handler;
>> +       }
>> +
>> +       if (handler->reboot_prepare_cb) {
>> +               priv->reboot_nb.notifier_call = sys_off_handler_reboot;
>> +               priv->reboot_nb.priority = handler->reboot_priority;
>> +
>> +               err = register_reboot_notifier(&priv->reboot_nb);
>> +               if (err)
>> +                       goto unreg_restart_handler;
>> +       }
>> +
>> +       priv->registered = true;
>> +
>> +       return 0;
>> +
>> +unreg_restart_handler:
>> +       if (handler->restart_cb)
>> +               unregister_restart_handler(&priv->restart_nb);
>> +
>> +unreg_power_off_handler:
>> +       if (handler->power_off_cb)
>> +               unregister_power_off_handler(&priv->power_off_nb);
>> +
>> +reset_sys_off_handler:
>> +       memset(priv, 0, sizeof(*priv));
>> +
>> +       return err;
>> +}
>> +EXPORT_SYMBOL(register_sys_off_handler);
>> +
>> +/**
>> + *     unregister_sys_off_handler - Unregister system power-off/restart handler
>> + *     @handler: System-off handler
>> + *
>> + *     Unregisters sys-off handler. Does nothing and returns zero if handler
>> + *     is NULL.
>> + *
>> + *     Returns zero on success, or error code on failure.
>> + */
>> +int unregister_sys_off_handler(struct sys_off_handler *handler)
>> +{
>> +       struct sys_off_handler_private_data *priv;
>> +
>> +       if (!handler)
>> +               return 0;
>> +
>> +       priv = sys_off_handler_private_data(handler);
>> +
>> +       /* sanity-check whether handler is unregistered twice */
>> +       if (!priv->registered)
>> +               return -EINVAL;
>> +
>> +       if (handler->reboot_prepare_cb)
>> +               unregister_reboot_notifier(&priv->reboot_nb);
>> +
>> +       if (handler->restart_cb)
>> +               unregister_restart_handler(&priv->restart_nb);
>> +
>> +       if (handler->power_off_cb)
>> +               unregister_power_off_handler(&priv->power_off_nb);
>> +
>> +       memset(priv, 0, sizeof(*priv));
>> +
>> +       return 0;
>> +}
>> +EXPORT_SYMBOL(unregister_sys_off_handler);
>> +
>> +static void devm_unregister_sys_off_handler(void *data)
>> +{
>> +       struct sys_off_handler *handler = data;
>> +
>> +       unregister_sys_off_handler(handler);
>> +}
>> +
>> +/**
>> + *     devm_register_sys_off_handler - Register system power-off/restart handler
>> + *     @dev: Device that registers handler
>> + *     @handler: System-off handler
>> + *
>> + *     Resource-managed variant of register_sys_off_handler().
>> + *
>> + *     Returns zero on success, or error code on failure.
>> + */
>> +int devm_register_sys_off_handler(struct device *dev,
>> +                                 struct sys_off_handler *handler)
>> +{
>> +       int err;
>> +
>> +       err = register_sys_off_handler(handler);
>> +       if (err)
>> +               return err;
>> +
>> +       return devm_add_action_or_reset(dev, devm_unregister_sys_off_handler,
>> +                                       handler);
>> +}
>> +EXPORT_SYMBOL(devm_register_sys_off_handler);
>> +
>> +/**
>> + *     devm_register_prioritized_power_off_handler - Register prioritized power-off callback
>> + *     @dev: Device that registers callback
>> + *     @priority: Callback's priority
>> + *     @callback: Callback function
>> + *     @cb_data: Callback's argument
>> + *
>> + *     Registers resource-managed power-off callback with a given priority.
>> + *     It will be called as last step of the power-off sequence. Callbacks
>> + *     chaining is disabled, i.e. further lower priority callbacks won't
>> + *     be executed if this @callback will fail to execute.
>> + *
>> + *     Returns zero on success, or error code on failure.
> 
> What's the case in which this should be used instead of registering a
> full sys_off handler?

There are a lot of drivers that just want to register power-off handler
with a non-default priority and don't need to stop the chain or do
anything else special. This is a convinient helper for them.

Please note that the callback here takes only the cb_data for the
argument, while sys_off uses "struct power_off_data".

Similar for the reset of the convinient helpers.

...
>> +/**
>> + *     register_platform_power_off - Register platform-level power-off callback
>> + *     @power_off: Power-off callback
>> + *
>> + *     Registers power-off callback that will be called as last step
>> + *     of the power-off sequence. This callback is expected to be invoked
>> + *     for the last resort. Further lower priority callbacks won't be
>> + *     executed if @power_off fails. Only one platform power-off callback
>> + *     is allowed to be registered at a time.
>> + *
>> + *     Returns zero on success, or error code on failure.
> 
> What's the use case for this?

There are dozens of trivial platform/board-specific power-off handlers
in the arch/ code. Those handlers don't take any arguments, hence it's a
convinient helper that transits them to the new API neatly.

>> + */
>> +int register_platform_power_off(void (*power_off)(void))
>> +{
>> +       struct sys_off_handler_private_data *priv;
>> +       int ret = 0;
>> +
>> +       priv = sys_off_handler_private_data(&platform_power_off_handler);
>> +
>> +       spin_lock(&platform_power_off_lock);
>> +       if (priv->platform_power_off_cb)
>> +               ret = -EBUSY;
>> +       else
>> +               priv->platform_power_off_cb = power_off;
> 
> Wasn't priv supposed to be const?

It's const only for the external API users to prevent them from abusing
the internal data.

>> +       spin_unlock(&platform_power_off_lock);
>> +
>> +       if (ret)
>> +               return ret;
>> +
>> +       ret = register_power_off_handler(&priv->power_off_nb);
>> +       if (ret)
>> +               priv->platform_power_off_cb = NULL;
>> +
>> +       return ret;
>> +}
>> +EXPORT_SYMBOL_GPL(register_platform_power_off);
>> +
>> +/**
>> + *     unregister_platform_power_off - Unregister platform-level power-off callback
>> + *     @power_off: Power-off callback
>> + *
>> + *     Unregisters previously registered platform power-off callback.
>> + *
>> + *     Returns zero on success, or error code on failure.
>> + */
>> +int unregister_platform_power_off(void (*power_off)(void))
>> +{
>> +       struct sys_off_handler_private_data *priv;
>> +       int ret;
>> +
>> +       priv = sys_off_handler_private_data(&platform_power_off_handler);
>> +
>> +       if (priv->platform_power_off_cb != power_off)
>> +               return -EINVAL;
>> +
>> +       ret = unregister_power_off_handler(&priv->power_off_nb);
>> +       priv->platform_power_off_cb = NULL;
>> +
>> +       return ret;
>> +}
>> +EXPORT_SYMBOL_GPL(unregister_platform_power_off);
>> +
>> +/**
>> + *     do_kernel_power_off - Execute kernel power-off handler call chain
>> + *
>> + *     Calls functions registered with register_power_off_handler.
>> + *
>> + *     Expected to be called as last step of the power-off sequence.
>> + *
>> + *     Powers off the system immediately if a power-off handler function has
>> + *     been registered. Otherwise does nothing.
>> + */
>> +void do_kernel_power_off(void)
>> +{
>> +       /* legacy pm_power_off() is unchained and has highest priority */
>> +       if (pm_power_off && pm_power_off != dummy_pm_power_off)
>> +               return pm_power_off();
>> +
>> +       blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_NORMAL,
>> +                                    NULL);
>> +}
>> +
>> +static void do_kernel_power_off_prepare(void)
>> +{
>> +       /* legacy pm_power_off_prepare() is unchained and has highest priority */
>> +       if (pm_power_off_prepare)
>> +               return pm_power_off_prepare();
>> +
>> +       blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE,
>> +                                    NULL);
>> +}
>> +
>>  /**
>>   *     kernel_power_off - power_off the system
>>   *
>> @@ -304,8 +893,7 @@ EXPORT_SYMBOL_GPL(kernel_halt);
>>  void kernel_power_off(void)
>>  {
>>         kernel_shutdown_prepare(SYSTEM_POWER_OFF);
>> -       if (pm_power_off_prepare)
>> -               pm_power_off_prepare();
>> +       do_kernel_power_off_prepare();
>>         migrate_to_reboot_cpu();
>>         syscore_shutdown();
>>         pr_emerg("Power down\n");
>> @@ -314,6 +902,16 @@ void kernel_power_off(void)
>>  }
>>  EXPORT_SYMBOL_GPL(kernel_power_off);
>>
>> +bool kernel_can_power_off(void)
>> +{
>> +       if (!pm_power_off &&
>> +           blocking_notifier_call_chain_is_empty(&power_off_handler_list))
>> +               return false;
>> +
>> +       return true;
> 
> return pm_power_off ||
> blocking_notifier_call_chain_is_empty(&power_off_handler_list);

Thank you for the thorough review!


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 02:01:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 02:01:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306840.522015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngGhq-0008KD-Vr; Mon, 18 Apr 2022 02:01:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306840.522015; Mon, 18 Apr 2022 02:01:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngGhq-0008K6-SX; Mon, 18 Apr 2022 02:01:34 +0000
Received: by outflank-mailman (input) for mailman id 306840;
 Mon, 18 Apr 2022 02:01:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngGhp-0008Jw-PF; Mon, 18 Apr 2022 02:01:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngGhp-00014R-NO; Mon, 18 Apr 2022 02:01:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngGhp-0004z6-7o; Mon, 18 Apr 2022 02:01:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngGhp-0006aN-7P; Mon, 18 Apr 2022 02:01:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RCybc8GR5oPIQHuRiUsfbltRmt3Cyc19sZ9yFhVzr/w=; b=6Q9OwWzmWqUKyFraUs9PapGEJj
	N3Rh+J1iFXQk5gDTD/rjFB+hxVDUsf08vIGUHcGljtBUavyVgDtOqPNOC8fXBClA736UnCHHP62Hf
	JquQYU1fFFZC2vEJQv+UDLj9XpUoIW4SX1xqNiiYsVBlPBzoAo8qZcdumej0Lx/GvW7w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169498-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169498: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 02:01:33 +0000

flight 169498 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169498/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  470 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   46 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 03:14:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 03:14:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306851.522025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngHqW-0007qg-Dc; Mon, 18 Apr 2022 03:14:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306851.522025; Mon, 18 Apr 2022 03:14:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngHqW-0007qZ-Ai; Mon, 18 Apr 2022 03:14:36 +0000
Received: by outflank-mailman (input) for mailman id 306851;
 Mon, 18 Apr 2022 03:14:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngHqV-0007qP-2V; Mon, 18 Apr 2022 03:14:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngHqU-0002pF-WF; Mon, 18 Apr 2022 03:14:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngHqU-0007C5-G7; Mon, 18 Apr 2022 03:14:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngHqU-0005p7-FV; Mon, 18 Apr 2022 03:14:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lyk5D730UOtSajTCrMTaML13uhOjgajN1vrYBmYG0A4=; b=pjqUCbspXZsO3JkIxK9cR2TooL
	w5LMaHylnGt8HYEVNFeHPube7oQrclh5wA7pBR6WZ1RLvmtAjoEy+yRnCUXNYI0doigiPQejT22Ng
	BHKo/hAV/GJJcAI46VI8greQeUdEIRiQXwIeqa85qOpLzpHvEA1yqgYa5Q6FDzVZ578s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169500-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169500: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 03:14:34 +0000

flight 169500 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169500/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  471 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   47 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306869.522037 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOA-0001Gi-Gg; Mon, 18 Apr 2022 04:53:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306869.522037; Mon, 18 Apr 2022 04:53:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOA-0001Gb-DL; Mon, 18 Apr 2022 04:53:26 +0000
Received: by outflank-mailman (input) for mailman id 306869;
 Mon, 18 Apr 2022 04:53:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngJO9-0001GR-Be; Mon, 18 Apr 2022 04:53:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngJO9-0004gX-67; Mon, 18 Apr 2022 04:53:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngJO8-0004Xk-Kz; Mon, 18 Apr 2022 04:53:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngJO8-0005Vw-KZ; Mon, 18 Apr 2022 04:53:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ploA6+Ne2vtpbvnGkclD6jsXit1z0mGkEzdArMQ+/Bk=; b=qMYR1R7cFpu/tjEBzOBde1wXG3
	26lvmVH8x8FqaroRu7/TN7OyvhAEABbr2Dehq1e4Qc5kGTMswygCXyfTYoSXMtgecKNJG2CXd+pLM
	FxY1vQiQl3L3C8upTa6JswoI2s63F24ALDC/3h5t4tDBTRAFL1zX0FJde3UbAdp3KTZM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169501-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169501: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 04:53:24 +0000

flight 169501 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169501/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  472 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   48 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306872.522048 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOV-0001fR-QU; Mon, 18 Apr 2022 04:53:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306872.522048; Mon, 18 Apr 2022 04:53:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOV-0001fK-Mo; Mon, 18 Apr 2022 04:53:47 +0000
Received: by outflank-mailman (input) for mailman id 306872;
 Mon, 18 Apr 2022 04:53:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOT-0001c8-LY
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:46 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 859e67d2-bed3-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 06:53:44 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJO3-00FYha-FT; Mon, 18 Apr 2022 04:53:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 859e67d2-bed3-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=ehhbXywWEInDu2MzhhcU8qyC2x202NRIVxnfV552fWg=; b=4+aRzQJYcjSRih3CAHHoWbQKH7
	tpRyxCuoqoDD29J+mP/JD+tuOpLTzRf6tGAVyuGm1tGzqWiKw0VPI3Z//Ivegeb/zkkMfBF25uEJu
	8o1KOY9vmrdu70v5p52qRPOvKYU/KO1j7AILK0X1SV3xH0zUNCBtjO5MxmPWDyB3FnDcknLf1/b8+
	fYnEzGYeuBU14+X4y8DMlr1JmpgaZUgZLWvLmRML5UshcDri7muDpboKeTNp2VDYLGcnydDsZfdy1
	EQTV6mqhUtxtdvZYv9mIEeqGcvXfbsOHMtH6Uny/9EHEwtxN5JNm1DCu1+PcS53QbmFNMsfc4uiGB
	S1uPtQoA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 01/11] ubd: don't set the discard_alignment queue limit
Date: Mon, 18 Apr 2022 06:53:04 +0200
Message-Id: <20220418045314.360785-2-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.
Setting it to the discard granularity as done by ubd is mostly harmless
but also useless.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/um/drivers/ubd_kern.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 085ffdf98e57e..c4344b67628dd 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -799,7 +799,6 @@ static int ubd_open_dev(struct ubd *ubd_dev)
 	}
 	if (ubd_dev->no_trim == 0) {
 		ubd_dev->queue->limits.discard_granularity = SECTOR_SIZE;
-		ubd_dev->queue->limits.discard_alignment = SECTOR_SIZE;
 		blk_queue_max_discard_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
 		blk_queue_max_write_zeroes_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
 	}
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306873.522055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOW-0001iM-6P; Mon, 18 Apr 2022 04:53:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306873.522055; Mon, 18 Apr 2022 04:53:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOV-0001gj-Ul; Mon, 18 Apr 2022 04:53:47 +0000
Received: by outflank-mailman (input) for mailman id 306873;
 Mon, 18 Apr 2022 04:53:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOU-0001c8-Hl
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:46 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 854ca340-bed3-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 06:53:43 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJO9-00FYiQ-3d; Mon, 18 Apr 2022 04:53:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 854ca340-bed3-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=QvtQsYVY573QihyBU8P2z12+bQQI/RcwQdA2DddKTiA=; b=LUQ5PRFm2GAJyoA/D+xu4w8Ii5
	0paCHfyXTYDxbjypETMxwgir9bcwOwM4o4rWjUOpuxTq4I9Q4G/j7GVoJnIwTdVosqCyx9KlBfHHz
	GBr7tV+xv5gxPcKBzizKftU8Qv6ZFFPGtMjheiYrReTlWeRhvuhAaarOva0kSOa3erCllKH+TrqTE
	Z8pVWD52/LOaeff3ZAer03ApAz1EBAKLkUGDdVFxHrg+FnoIus0ydxQ8Xo+w5VHre+DsJ0CVzeJRd
	u4Ni5puCzFaEbwzGI41J6IW4XU0jzki6izerpFqhBoxMjIEwaBJMooUN/P+xSgYx2bCA+8qthvREk
	rDuUzWUA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 03/11] null_blk: don't set the discard_alignment queue limit
Date: Mon, 18 Apr 2022 06:53:06 +0200
Message-Id: <20220418045314.360785-4-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.
Setting it to the discard granularity as done by null_blk is mostly
harmless but also useless.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/null_blk/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 5cb4c92cdffea..a521e914a9843 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1765,7 +1765,6 @@ static void null_config_discard(struct nullb *nullb)
 	}
 
 	nullb->q->limits.discard_granularity = nullb->dev->blocksize;
-	nullb->q->limits.discard_alignment = nullb->dev->blocksize;
 	blk_queue_max_discard_sectors(nullb->q, UINT_MAX >> 9);
 }
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306874.522060 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOW-0001st-ME; Mon, 18 Apr 2022 04:53:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306874.522060; Mon, 18 Apr 2022 04:53:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOW-0001oP-EB; Mon, 18 Apr 2022 04:53:48 +0000
Received: by outflank-mailman (input) for mailman id 306874;
 Mon, 18 Apr 2022 04:53:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOV-0001do-CN
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:47 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 867b6edd-bed3-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 06:53:45 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJOC-00FYj8-0H; Mon, 18 Apr 2022 04:53:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 867b6edd-bed3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=KG+SgMW1cgxv4FiMP5E+75DsV8uftH+qG3p1TXEyEio=; b=WCY6skOHo4HAb9P+VnkeBFb0Wd
	6HtmKYsZebjLRF7olS575CTUsYnepT6MLhQcw4sj2+aChzDYFdv2TJAkdt+xyZ1fXNBl7i0qMNjh3
	atVTLApTQdVrJzkAw+e1xu5UI+XeibuBhpE8sdBqSRgmuc6LQWX7Gh+vwa6QmZwgL4o7wDhOkPATZ
	JJdiL4zj1+8ON5LJ5rpzrXXnZZ2Gt3WLli0Y+Kla+bD/xTw/zq7EpruzAfxZI9IfvyngDrwoC2oVp
	27txs+BLBDIzzVrm7MMsfkvqKD3aBSqEiOBeG/1GG6jcIJdI2YJ/vneItfmtIQXQEFbm2vNa5lU9l
	aHTP8xYA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 04/11] virtio_blk: fix the discard_granularity and discard_alignment queue limits
Date: Mon, 18 Apr 2022 06:53:07 +0200
Message-Id: <20220418045314.360785-5-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.

On the other hand the discard_sector_alignment from the virtio 1.1 looks
similar to what Linux uses as discard granularity (even if not very well
described):

  "discard_sector_alignment can be used by OS when splitting a request
   based on alignment. "

And at least qemu does set it to the discard granularity.

So stop setting the discard_alignment and use the virtio
discard_sector_alignment to set the discard granularity.

Fixes: 1f23816b8eb8 ("virtio_blk: add discard and write zeroes support")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/virtio_blk.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 6ccf15253dee1..d624cc8eddc3c 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -867,11 +867,12 @@ static int virtblk_probe(struct virtio_device *vdev)
 		blk_queue_io_opt(q, blk_size * opt_io_size);
 
 	if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) {
-		q->limits.discard_granularity = blk_size;
-
 		virtio_cread(vdev, struct virtio_blk_config,
 			     discard_sector_alignment, &v);
-		q->limits.discard_alignment = v ? v << SECTOR_SHIFT : 0;
+		if (v)
+			q->limits.discard_granularity = v << SECTOR_SHIFT;
+		else
+			q->limits.discard_granularity = blk_size;
 
 		virtio_cread(vdev, struct virtio_blk_config,
 			     max_discard_sectors, &v);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306875.522070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOX-00020j-AU; Mon, 18 Apr 2022 04:53:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306875.522070; Mon, 18 Apr 2022 04:53:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOW-0001y1-Uq; Mon, 18 Apr 2022 04:53:48 +0000
Received: by outflank-mailman (input) for mailman id 306875;
 Mon, 18 Apr 2022 04:53:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOV-0001c8-Dj
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:47 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 84c8facb-bed3-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 06:53:43 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJO0-00FYhR-Fv; Mon, 18 Apr 2022 04:53:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84c8facb-bed3-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=tyZKBZElFW6HvHSlv9xeAjIG3dO7xKdX7mIPZUu3++o=; b=Fc1PLXWY+U61UCduGVVmNa4xRX
	W2DkcCfgMrkwb1FtowTBpkb1LuVkZ8TInpQDBRu63s01XGNymYAVBze9K7cuggrvtLVCsRIQvDof7
	ljUfhulALzTsFS4w+l71wYoV1q2Lm4YK8vgQZhkj/Np9aC0Yu9S1JLLXx3eykhjg6NsyORI3PutJm
	sTMvqTpRRhFFdcZ7EV5IvV6e5FER4KWu6+dJ4duc2TYsclYeI94eZYYw/+h90AObggztOx4giuutC
	Qw7muGk8qWXO7hVhEGAmI1WIrhzpj4Cevvqzf0Uppevy9o3pTO/Ek4OGE2kkDtP//trS4bSL7nhaU
	+mBAe6Vg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: fix and cleanup discard_alignment handling
Date: Mon, 18 Apr 2022 06:53:03 +0200
Message-Id: <20220418045314.360785-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Hi all,

the somewhat confusing name of the discard_alignment queue limit, that
really is an offset for the discard granularity mislead a lot of driver
authors to set it to an incorrect value.  This series tries to fix up
all these cases.

Diffstat:
 arch/um/drivers/ubd_kern.c         |    1 -
 drivers/block/loop.c               |    1 -
 drivers/block/nbd.c                |    3 ---
 drivers/block/null_blk/main.c      |    1 -
 drivers/block/rnbd/rnbd-srv-dev.h  |    2 +-
 drivers/block/virtio_blk.c         |    7 ++++---
 drivers/block/xen-blkback/xenbus.c |    4 ++--
 drivers/md/dm-zoned-target.c       |    2 +-
 drivers/md/raid5.c                 |    1 -
 drivers/nvme/host/core.c           |    1 -
 drivers/s390/block/dasd_fba.c      |    1 -
 11 files changed, 8 insertions(+), 16 deletions(-)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306876.522076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOX-0002Az-QR; Mon, 18 Apr 2022 04:53:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306876.522076; Mon, 18 Apr 2022 04:53:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOX-00029z-GC; Mon, 18 Apr 2022 04:53:49 +0000
Received: by outflank-mailman (input) for mailman id 306876;
 Mon, 18 Apr 2022 04:53:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOW-0001do-5T
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:48 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85b226ba-bed3-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 06:53:45 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJO6-00FYhe-Hq; Mon, 18 Apr 2022 04:53:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85b226ba-bed3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=koCagwvOxhN7Shu8/AJxKzZVAKuzrO1L5//iYnC02Iw=; b=AfuHTR/V7lcr3zFbVv43aXi0wl
	9BXiL1MXkRpqJBplwxZBu6BMXzKAwM3cLacngv6w9v/xu4r4wsZXJzUpjj8oykifbHGOdLOj9+cXd
	w57UeuYr1aXFL4KN5snqFZNRlx3/zg/as2hg/byKwuFPkRBWSqYCMgz6Nalf6bjYlUrYWYMFOg7lM
	VVtAyBmc/UB6YQDpwNy9RxJMNN3OFjU5UKmrw+vl4PuZd7vQ6hmG2jXje40n9Bl31/uUTw3g/iABO
	fgajCyxoKwPRp2bRxD9DHepUAQfpOnb0+QEai/a9nd+iaTwNGZ7XqT7mmOiN9r3r1T9l317vuoSmZ
	0Zs1vSZQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 02/11] nbd: don't set the discard_alignment queue limit
Date: Mon, 18 Apr 2022 06:53:05 +0200
Message-Id: <20220418045314.360785-3-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.
Setting it to the discard granularity as done by nbd is mostly harmless
but also useless.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/nbd.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 4729aef8c6462..102597a4277b9 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -333,7 +333,6 @@ static int nbd_set_size(struct nbd_device *nbd, loff_t bytesize,
 
 	if (nbd->config->flags & NBD_FLAG_SEND_TRIM) {
 		nbd->disk->queue->limits.discard_granularity = blksize;
-		nbd->disk->queue->limits.discard_alignment = blksize;
 		blk_queue_max_discard_sectors(nbd->disk->queue, UINT_MAX);
 	}
 	blk_queue_logical_block_size(nbd->disk->queue, blksize);
@@ -1316,7 +1315,6 @@ static void nbd_config_put(struct nbd_device *nbd)
 
 		nbd->tag_set.timeout = 0;
 		nbd->disk->queue->limits.discard_granularity = 0;
-		nbd->disk->queue->limits.discard_alignment = 0;
 		blk_queue_max_discard_sectors(nbd->disk->queue, 0);
 
 		mutex_unlock(&nbd->config_lock);
@@ -1781,7 +1779,6 @@ static struct nbd_device *nbd_dev_add(int index, unsigned int refs)
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, disk->queue);
 	disk->queue->limits.discard_granularity = 0;
-	disk->queue->limits.discard_alignment = 0;
 	blk_queue_max_discard_sectors(disk->queue, 0);
 	blk_queue_max_segment_size(disk->queue, UINT_MAX);
 	blk_queue_max_segments(disk->queue, USHRT_MAX);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306877.522097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOZ-0002l6-Af; Mon, 18 Apr 2022 04:53:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306877.522097; Mon, 18 Apr 2022 04:53:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOY-0002hT-Vx; Mon, 18 Apr 2022 04:53:50 +0000
Received: by outflank-mailman (input) for mailman id 306877;
 Mon, 18 Apr 2022 04:53:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOW-0001c8-Ey
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:48 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 87e10c8b-bed3-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 06:53:47 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJOE-00FYjt-Uc; Mon, 18 Apr 2022 04:53:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87e10c8b-bed3-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=jJDfNJ+noyJ0aQwSxPjfuM0bukOLXIlZdKOCCRo7UC0=; b=xuIkX7BaO7YLYo2xtforYUeJSz
	D4ZkceNgWZcqsdA4kKDR70kSEQCNujP+EuBqv6qBw0ZF92W/0/cEfjWOan0nETRKihTYr6lzIZlZl
	bBcwq/JHARHxWpbiEMaI9y7fhWsSop569zSNCbdEUmCgnceKeTdNHmdubHo2T02f4jZnDeMuy9YEp
	gX5Gk0YQFUdeh+lTgVE6905xov9XyUfA8uV/rEBVxEimHbnB03TXVy+Q+6Z3Gp8bR9szIE8Cp8Ndy
	rknbV4gm7RVldjeoTzmK+sn63+wAUNv9Myo89P/eXTHdhfPYO+SAS69EJRqWmwD6yqU/r8IFcrYqq
	/61rhfuw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 05/11] dm-zoned: don't set the discard_alignment queue limit
Date: Mon, 18 Apr 2022 06:53:08 +0200
Message-Id: <20220418045314.360785-6-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.
Setting it to the discard granularity as done by dm-zoned is mostly
harmless but also useless.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm-zoned-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
index cac295cc8840e..0ec5d8b9b1a4e 100644
--- a/drivers/md/dm-zoned-target.c
+++ b/drivers/md/dm-zoned-target.c
@@ -1001,7 +1001,7 @@ static void dmz_io_hints(struct dm_target *ti, struct queue_limits *limits)
 	blk_limits_io_min(limits, DMZ_BLOCK_SIZE);
 	blk_limits_io_opt(limits, DMZ_BLOCK_SIZE);
 
-	limits->discard_alignment = DMZ_BLOCK_SIZE;
+	limits->discard_alignment = 0;
 	limits->discard_granularity = DMZ_BLOCK_SIZE;
 	limits->max_discard_sectors = chunk_sectors;
 	limits->max_hw_discard_sectors = chunk_sectors;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306878.522114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOb-0003PC-JP; Mon, 18 Apr 2022 04:53:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306878.522114; Mon, 18 Apr 2022 04:53:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOb-0003Oz-Ds; Mon, 18 Apr 2022 04:53:53 +0000
Received: by outflank-mailman (input) for mailman id 306878;
 Mon, 18 Apr 2022 04:53:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOa-0001do-6Y
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:52 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a06660d-bed3-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 06:53:51 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJOI-00FYkg-0o; Mon, 18 Apr 2022 04:53:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a06660d-bed3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=5rcnJ83GrgSSabCav/BawazCovpIiEvHei2b2gmullQ=; b=CjJhpozaz3ZvUqlOlRhUG6HF0e
	L1k08qBdI7FjLxrC+2SHHoNWrKKNNyMlTyF4yTi95nmPu6QjzipSWH9TvaHMjTe8XoTWpzOf49Xwn
	/jTNmyPXW291lu9ai/kVpUcGZy0BEma/a+v71WBQptYeQK53Oa4G3wRCg1iH80jgNCDh+UkonCJTi
	b2hNWpI0YPpjBR+0L2Bg82wVndKnPmP8XXH33hc/RLegnrrgdomyqC3ANZRjwyzqph4yUIcfGGV1b
	13e7GSLfhf8SaHCAofITijpch9zJ9GPiLs40aqk7qM6e7KoHhSnPrPVcNE2jwVOMrxC25OuZ8i44W
	kFZNgihA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 06/11] raid5: don't set the discard_alignment queue limit
Date: Mon, 18 Apr 2022 06:53:09 +0200
Message-Id: <20220418045314.360785-7-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.
Setting it to the discard granularity as done by raid5 is mostly
harmless but also useless.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/raid5.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 59f91e392a2ae..39b0afdf40d0a 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7749,7 +7749,6 @@ static int raid5_run(struct mddev *mddev)
 		 */
 		stripe = stripe * PAGE_SIZE;
 		stripe = roundup_pow_of_two(stripe);
-		mddev->queue->limits.discard_alignment = stripe;
 		mddev->queue->limits.discard_granularity = stripe;
 
 		blk_queue_max_write_zeroes_sectors(mddev->queue, 0);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306880.522124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOc-0003ha-Sy; Mon, 18 Apr 2022 04:53:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306880.522124; Mon, 18 Apr 2022 04:53:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOc-0003gx-Oi; Mon, 18 Apr 2022 04:53:54 +0000
Received: by outflank-mailman (input) for mailman id 306880;
 Mon, 18 Apr 2022 04:53:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOb-0001do-RW
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:53 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b1b7e18-bed3-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 06:53:53 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJOK-00FYlu-W5; Mon, 18 Apr 2022 04:53:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b1b7e18-bed3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=rEun4CykQNh9XCzIn07hcf266lJSo8SoQFV5h3aZDN4=; b=Iyi59rQ8jx9ZFvYgDjqU1HKgI3
	3ER3HIO6el0yfwsbhwUqMaebwGQMLJp2Ty8pfApDcdy/dox4NBRD0zlAwgVZHz3C//ttRe2EpMMpE
	TlYo85CuBa66xfYMYNTFqP97nYG9E4UMoh/+mq+XldHcgyiYn8t88j0p38CFlHyG1WnflGfc9N6IQ
	ALupyQSKl6Do9NriswZQgpSbmVhWvg3qZzOpBx8BeEjzA/SfHSRhmM03Xd44QDRw6m5kWouXbMQLj
	EsfQEvQ7/s2jVpOeH9ws1tRZrnKNo3KfR2dNjEk6WSbmEVrg/W3E52Bl0bOqmREpLbkSwxlK3mr9T
	SboayqTg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 07/11] dasd: don't set the discard_alignment queue limit
Date: Mon, 18 Apr 2022 06:53:10 +0200
Message-Id: <20220418045314.360785-8-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.
Setting it to PAGE_SIZE while the discard granularity is the block size
that is smaller or the same as PAGE_SIZE as done by dasd is mostly
harmless but also useless.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/s390/block/dasd_fba.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c
index 8bd5665db9198..60be7f7bf2d16 100644
--- a/drivers/s390/block/dasd_fba.c
+++ b/drivers/s390/block/dasd_fba.c
@@ -782,7 +782,6 @@ static void dasd_fba_setup_blk_queue(struct dasd_block *block)
 	blk_queue_segment_boundary(q, PAGE_SIZE - 1);
 
 	q->limits.discard_granularity = logical_block_size;
-	q->limits.discard_alignment = PAGE_SIZE;
 
 	/* Calculate max_discard_sectors and make it PAGE aligned */
 	max_bytes = USHRT_MAX * logical_block_size;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:53:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:53:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306882.522136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOg-0004EI-Cm; Mon, 18 Apr 2022 04:53:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306882.522136; Mon, 18 Apr 2022 04:53:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOg-0004E3-7e; Mon, 18 Apr 2022 04:53:58 +0000
Received: by outflank-mailman (input) for mailman id 306882;
 Mon, 18 Apr 2022 04:53:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOe-0001do-9X
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:56 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8c8ec796-bed3-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 06:53:55 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJOO-00FYn5-24; Mon, 18 Apr 2022 04:53:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c8ec796-bed3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=Nwnahs8dGCrFyGqh76Osy38QIfFTcrX+bg/5w9K9Oig=; b=JeF0YY6h1iSEXtKIJVRU4DnakB
	iSag4ipYDNufx4HIec1J7pwr04yj7IlNVOtLFyn04Wv2YpFZQhlvsu33m0GRmsb3PkylahgmTcFWG
	A4k1DZepK4PC3rtyMOIt75ceY450AzbeQqmXxm+KLwXIuNpy9wB3M0Uxbj7eFeRU7NZgOrm9qsdNf
	A83iEm2C44aUr+gvbqtQjawIInyHUcvlGHqsANM4j5nbfMhu01wcMFNv2L5KV+vzWfSNOxp+gx01K
	hklzOClX07D/J1uBkeOOPeQzaPTilIo4n7FSI/fYdOVYYmtE3o12kxKv1emVZBbh+e6QSqMnFkRxM
	x9QqhNaQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 08/11] loop: remove a spurious clear of discard_alignment
Date: Mon, 18 Apr 2022 06:53:11 +0200
Message-Id: <20220418045314.360785-9-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The loop driver never sets a discard_alignment, so it also doens't need
to clear it to zero.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/loop.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 976cf987b3920..61b642b966a08 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -789,7 +789,6 @@ static void loop_config_discard(struct loop_device *lo)
 		blk_queue_max_discard_sectors(q, 0);
 		blk_queue_max_write_zeroes_sectors(q, 0);
 	}
-	q->limits.discard_alignment = 0;
 }
 
 struct loop_worker {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 04:54:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 04:54:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306886.522147 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOj-0004jW-53; Mon, 18 Apr 2022 04:54:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306886.522147; Mon, 18 Apr 2022 04:54:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJOi-0004jA-TR; Mon, 18 Apr 2022 04:54:00 +0000
Received: by outflank-mailman (input) for mailman id 306886;
 Mon, 18 Apr 2022 04:53:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOh-0001c8-3i
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:53:59 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8df91ea5-bed3-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 06:53:58 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJOR-00FYpT-19; Mon, 18 Apr 2022 04:53:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8df91ea5-bed3-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=p9kVzatrYS3rOQLSwSVe7hP5f0rChlSo2rdSBrIcPYE=; b=0FL1fru1SsYGhSt8FM9Hn5xwZJ
	EmQtcyxuckYmdCptFk4+/gbaxge3l3nq3kRFPBP2il/Rof09pxe6Ws2nfts4MKx5OwwmpIZVuaYn4
	QeXpjkKcOgL+kIGAlsZf8TM3L2foTyd4yXmmcS+vpt95vjmJlLA2Izx3NJJBScVt157v41DjhjlqM
	L7UcHqXMheEW+Am7Onu8gXnRyneCudkfEE0daVhQvCm9moV6YBkxEJJ4GpFmY1uJvO31vQEX3ElTE
	DJMzx/mYKMVBU0H0c+NGX3DON4EMSxBXtNngeE5dikTPdCHtE3RUwtmqsEkdAx9DNdwjKW/ddgcK7
	QLRmmVOw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 09/11] nvme: remove a spurious clear of discard_alignment
Date: Mon, 18 Apr 2022 06:53:12 +0200
Message-Id: <20220418045314.360785-10-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The nvme driver never sets a discard_alignment, so it also doens't need
to clear it to zero.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/nvme/host/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index b9b0fbde97c80..76a9ccd5d064a 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1628,7 +1628,6 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
 	BUILD_BUG_ON(PAGE_SIZE / sizeof(struct nvme_dsm_range) <
 			NVME_DSM_MAX_RANGES);
 
-	queue->limits.discard_alignment = 0;
 	queue->limits.discard_granularity = size;
 
 	/* If discard is already enabled, don't reset queue limits */
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 05:02:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 05:02:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306917.522158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJWX-0000Wn-0e; Mon, 18 Apr 2022 05:02:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306917.522158; Mon, 18 Apr 2022 05:02:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJWW-0000Wg-U2; Mon, 18 Apr 2022 05:02:04 +0000
Received: by outflank-mailman (input) for mailman id 306917;
 Mon, 18 Apr 2022 05:02:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJOl-0001c8-Qc
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:54:03 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 910a362d-bed3-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 06:54:03 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJOU-00FYrv-1m; Mon, 18 Apr 2022 04:53:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 910a362d-bed3-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=l98+JE7NsbGjf5nWv4p96TEYrrJUm3Xf8r7AJ/Re+50=; b=b3jjhl3NnpidTbS0yNml6BOTZ8
	g5tAOt/e4fr16yh0hdRjlvIGx02REr0Be/uhAhfgcsNY4E/teSSgiM/GgyhOUQSv8IiRoSt3RzkXd
	8ui/01VcFQfFGEsSUAyAx5STB9OojQQpAMNCVjttzU6nFKsO6z0j+D3KoS7MAvwWFyJEJ3mY3oIsB
	aTOMIweseDzyB/wuWieC2B/KurzoqX4uzoCO/b2//x4TSx2HhfzcfsLpYy6R0eW8NN3W7VB+YjfkW
	SzDEVVy4J5mGZoqCt2e5fSbZvWNFqqIYUzWtTTDJikCF+4YJ7f49HyVqAPAjNJ9U+5xHbqAhd2nPp
	Q4yHIWlA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 10/11] rnbd-srv: use bdev_discard_alignment
Date: Mon, 18 Apr 2022 06:53:13 +0200
Message-Id: <20220418045314.360785-11-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use bdev_discard_alignment to calculate the correct discard alignment
offset even for partitions instead of just looking at the queue limit.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/rnbd/rnbd-srv-dev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
index d080a0de59225..4309e52524691 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.h
+++ b/drivers/block/rnbd/rnbd-srv-dev.h
@@ -59,7 +59,7 @@ static inline int rnbd_dev_get_discard_granularity(const struct rnbd_dev *dev)
 
 static inline int rnbd_dev_get_discard_alignment(const struct rnbd_dev *dev)
 {
-	return bdev_get_queue(dev->bdev)->limits.discard_alignment;
+	return bdev_discard_alignment(dev->bdev);
 }
 
 #endif /* RNBD_SRV_DEV_H */
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 05:02:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 05:02:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306935.522169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJWw-00016Y-8W; Mon, 18 Apr 2022 05:02:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306935.522169; Mon, 18 Apr 2022 05:02:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngJWw-00016R-5W; Mon, 18 Apr 2022 05:02:30 +0000
Received: by outflank-mailman (input) for mailman id 306935;
 Mon, 18 Apr 2022 05:02:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f7HF=U4=bombadil.srs.infradead.org=BATV+786b5b18f0b4466cc734+6812+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1ngJP0-0001do-Qb
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 04:54:18 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 941fd8d7-bed3-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 06:54:08 +0200 (CEST)
Received: from [2a02:1205:504b:4280:f5dd:42a4:896c:d877] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngJOW-00FYuM-S5; Mon, 18 Apr 2022 04:53:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 941fd8d7-bed3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=FtH/TzYq8qAlMP8iMYBlGWDgAyvZ+dC0QKeXw0CO9iY=; b=BUsTo3zH0HXFlc2PINU8GKGh7x
	xOheprcMV4SR/Bv+uFwxwEEXQNbDYNV0dXmpOloJvszTTFIFrVWaZxvzBY3RFcl0N0jCpn4vw3nb4
	mTGNcSlargn2+/9oPzLzWJrWP+vix6g0SW/61Ow0uZFQlb8WOgevrVuktiq9QO8aHLzYorKaOwQBQ
	CfxG3eR2YUokj3T01RV5d+uhBYCjSMPbPfvUkXoiOxJvCqf7RvI027xldIPQkqonm5kkPHmkKj1CY
	TNHlrnSp6mhzujyAzSdQ8dHMYyS7hxSExdUVN15TaHiISjHO2rUQKK97SneL+jfBatao0hyUgCdvx
	1/5nIEmg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Song Liu <song@kernel.org>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	nbd@other.debian.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org,
	linux-raid@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 11/11] xen-blkback: use bdev_discard_alignment
Date: Mon, 18 Apr 2022 06:53:14 +0200
Message-Id: <20220418045314.360785-12-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
References: <20220418045314.360785-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use bdev_discard_alignment to calculate the correct discard alignment
offset even for partitions instead of just looking at the queue limit.

Also switch to use bdev_discard_granularity to get rid of the last direct
queue reference in xen_blkbk_discard.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/xen-blkback/xenbus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index b21bffc9c50bc..04c90cb8955f6 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -583,14 +583,14 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
 	if (bdev_max_discard_sectors(bdev)) {
 		err = xenbus_printf(xbt, dev->nodename,
 			"discard-granularity", "%u",
-			q->limits.discard_granularity);
+			bdev_discard_granularity(bdev));
 		if (err) {
 			dev_warn(&dev->dev, "writing discard-granularity (%d)", err);
 			return;
 		}
 		err = xenbus_printf(xbt, dev->nodename,
 			"discard-alignment", "%u",
-			q->limits.discard_alignment);
+			bdev_discard_alignment(bdev));
 		if (err) {
 			dev_warn(&dev->dev, "writing discard-alignment (%d)", err);
 			return;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 07:10:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 07:10:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306963.522180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngLWm-0005tY-3v; Mon, 18 Apr 2022 07:10:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306963.522180; Mon, 18 Apr 2022 07:10:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngLWm-0005tR-10; Mon, 18 Apr 2022 07:10:28 +0000
Received: by outflank-mailman (input) for mailman id 306963;
 Mon, 18 Apr 2022 07:10:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngLWk-0005tH-Dn; Mon, 18 Apr 2022 07:10:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngLWk-0007Pe-BD; Mon, 18 Apr 2022 07:10:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngLWj-0002sd-Vg; Mon, 18 Apr 2022 07:10:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngLWj-0001CH-VC; Mon, 18 Apr 2022 07:10:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=nv5BXCGFc/4vhD3zvsUh5j4cl6utQXOuI9wfh05zh0c=; b=2t4S93iwlxu4RXcWI2f9zwypTX
	5nXk34SlCWuEMtoKzoi7zLsI0BA68XPiorhrlr7hAsTqAeDWCFsUwLj8oTEnR5jrWw2PiyuNqe8Oj
	pG9d5XoS07Q78hrWGHU5Z0KVoSNYUxDLsoUt5FGAueHEGFsSYkJAsNJePtqu3ufs2Ljk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169502-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169502: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 07:10:25 +0000

flight 169502 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169502/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  647 days
Failing since        151818  2020-07-11 04:18:52 Z  646 days  628 attempts
Testing same since   169415  2022-04-15 04:18:55 Z    3 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104670 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 07:11:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 07:11:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306971.522191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngLXn-0006Vw-LW; Mon, 18 Apr 2022 07:11:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306971.522191; Mon, 18 Apr 2022 07:11:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngLXn-0006Vp-IF; Mon, 18 Apr 2022 07:11:31 +0000
Received: by outflank-mailman (input) for mailman id 306971;
 Mon, 18 Apr 2022 07:11:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0hkv=U4=inria.fr=julia.lawall@srs-se1.protection.inumbo.net>)
 id 1ngLXm-0006Fh-8t
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 07:11:30 +0000
Received: from mail2-relais-roc.national.inria.fr
 (mail2-relais-roc.national.inria.fr [192.134.164.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c45458bb-bee6-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 09:11:29 +0200 (CEST)
Received: from 203.107.68.85.rev.sfr.net (HELO hadrien) ([85.68.107.203])
 by mail2-relais-roc.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2022 09:11:28 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c45458bb-bee6-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=inria.fr; s=dc;
  h=date:from:to:cc:subject:in-reply-to:message-id:
   references:mime-version;
  bh=mv4SaWQ4Bw/fucJMQTHXYSdAaF06VUODAZIEs7Rd828=;
  b=lWksnZqipOAWdvIJHQZisQD4gkBg4dI8MjvO0LGlApIsodldzOKpy7RB
   WkZlN9qNTRdIP0Rz5pZF6HfRrHibnwybDOJS664mmGWq3JP343u7vK3dV
   W9b500xj2LIBfEoXpNJHkCJmk/9uX5ACczMVJ+EpOgFB8QEErkVJhLi1B
   s=;
Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr
X-IronPort-AV: E=Sophos;i="5.90,269,1643670000"; 
   d="scan'208";a="32129625"
Date: Mon, 18 Apr 2022 09:11:27 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
X-X-Sender: jll@hadrien
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
cc: outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, 
    sstabellini@kernel.org, xen-devel@lists.xenproject.org, 
    linux-kernel@vger.kernel.org, ira.weiny@intel.com
Subject: Re: [PATCH] xen: gntalloc.c:  Convert kmap() to kmap_local_page()
In-Reply-To: <20220418061927.6833-1-eng.alaamohamedsoliman.am@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204180910320.2860@hadrien>
References: <20220418061927.6833-1-eng.alaamohamedsoliman.am@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII



On Mon, 18 Apr 2022, Alaa Mohamed wrote:

> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible.
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Therefore __del_gref() is a function
> where the use of kmap_local_page() in place of kmap() is correctly
> suited.

What is it about __del_gref() that makes this change the right choice?

julia

>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
>  drivers/xen/gntalloc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c
> index 4849f94372a4..55acb32842a3 100644
> --- a/drivers/xen/gntalloc.c
> +++ b/drivers/xen/gntalloc.c
> @@ -178,9 +178,9 @@ static void __del_gref(struct gntalloc_gref *gref)
>  	unsigned long addr;
>
>  	if (gref->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) {
> -		uint8_t *tmp = kmap(gref->page);
> +		uint8_t *tmp = kmap_local_page(gref->page);
>  		tmp[gref->notify.pgoff] = 0;
> -		kunmap(gref->page);
> +		kunmap_local(tmp);
>  	}
>  	if (gref->notify.flags & UNMAP_NOTIFY_SEND_EVENT) {
>  		notify_remote_via_evtchn(gref->notify.event);
> --
> 2.35.2
>
>
>


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 07:46:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 07:46:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306977.522202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngM5U-0001iL-Ba; Mon, 18 Apr 2022 07:46:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306977.522202; Mon, 18 Apr 2022 07:46:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngM5U-0001iE-7y; Mon, 18 Apr 2022 07:46:20 +0000
Received: by outflank-mailman (input) for mailman id 306977;
 Mon, 18 Apr 2022 07:46:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngM5T-0001i4-0O; Mon, 18 Apr 2022 07:46:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngM5S-00081C-TH; Mon, 18 Apr 2022 07:46:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngM5S-0003sA-EW; Mon, 18 Apr 2022 07:46:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngM5S-0002Zj-E5; Mon, 18 Apr 2022 07:46:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dKtUDcgeAQBOFysuOxKtjahirnUnFSLlLk7ZFNqL0c4=; b=l/EGADcRS5O+PsKNjUNxI2xb78
	BXVJ80tukBb7betFkyNcXwOSQYTuc55tiNgv+5G3rzl9Wior/+A8Sm0oy+yzh0qfCNdZEW7g3qnxF
	c8R2PSnslErnzeamJI4N0xpSkWMeVDw+pKsOahRA4tnU4Qa0sb2qm38m2Qs5rMJt6US0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169503-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169503: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 07:46:18 +0000

flight 169503 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169503/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  473 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   49 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 08:00:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 08:00:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306994.522212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMJS-0004dD-1p; Mon, 18 Apr 2022 08:00:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306994.522212; Mon, 18 Apr 2022 08:00:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMJR-0004d6-VC; Mon, 18 Apr 2022 08:00:45 +0000
Received: by outflank-mailman (input) for mailman id 306994;
 Mon, 18 Apr 2022 08:00:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pOmA=U4=opensource.wdc.com=prvs=10001294c=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1ngMJQ-0004cS-Bm
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 08:00:45 +0000
Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a27bdda8-beed-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 10:00:41 +0200 (CEST)
Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com)
 ([199.255.45.15])
 by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:00:18 +0800
Received: from uls-op-cesaip02.wdc.com ([10.248.3.37])
 by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 00:30:40 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 01:00:20 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfVq2fB6z1SVnx
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 01:00:19 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id BhgU8AvAgnJR for <xen-devel@lists.xenproject.org>;
 Mon, 18 Apr 2022 01:00:18 -0700 (PDT)
Received: from [10.225.163.14] (unknown [10.225.163.14])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfVj0QSXz1Rvlx;
 Mon, 18 Apr 2022 01:00:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a27bdda8-beed-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1650268839; x=1681804839;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=N3pAk4FME4FfpMn1iEoaJawKiDbUT/rSC5t+NXLtpDE=;
  b=Np4I5saXpkuSNJ8xGxhlXAfjyM0dEp1de1CyGzRZkncAtx4Kn1Mo2Qd1
   3uFpRHIQUM9joO9XPonyU0Q/uUSCYkWofj1b++JnzvTtz3YfTiiyiZo1j
   Mo0aeArXhToJrf51OVGiw65dbtNv9U56Y/FyBmXUvW1gFxBRyaMhQgSUy
   yOkG4lqgGcbadx6UMn5+HIVjU9hR5fs8igBL1fCksSANAHJMfVnHPXfQF
   F7f1WPsWCfy//hTtR161Q7wDEVZRMDTnzByEjSE28CniQZRbnA5gTM1lm
   BRcsi0uwZWH1ZuEL61dHq7coQnieNiSypiL/QgzmEjndfi/+y/LF1nKr7
   w==;
X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; 
   d="scan'208";a="198149975"
IronPort-SDR: TxjYTGZzvwB7psWV6W3KI5gHtngzKvQ9JxaTVaOTeJ4NZK4GDI2cdHKphZ7YJnAEDVEkvrehp/
 MAf5al43fZSUKkug6uH5WjF2aCvht2WrBzxmOq7Wgq/TeAKWpiWCP3t5lU1HcAsc378XmzKCi2
 qDJiza/Pln0FR8FhC36WJjPliM1zumqCBQSX7G9owKqF+IZ2LG1za0kSZfsUL08F4oOzaglZjJ
 86LcQUngZjo7+HI25Jnkx913fesX3QTYhBJ+Oz7g96HU/LzilCpc/PCqii+rycQlaT6HSNc1rF
 SE+VZcuH4cR8el44w5YJEJUs
IronPort-SDR: dqA0xkY883fVijO20XJqeYblV2DWNXbc84/nNH4mXZoWrmsCDmq9yK0hYQF03HZX3QBHQEDplf
 +595UVSkEuhf+7Bi3heEvTHwVRoUxmVPvShU8Ttgw1tcHKIATDvo/BSjz8rJFVXrLrTIykzjJT
 QsWw7WLn2LBR1V9OdkCICVSyxsYAbFr7P9XukHnxb0pLM72ibiNBafAorxUru7d2Uovq555V+V
 JnpVEHe6b4S7ggDv9tKgG+ze4OR9H4hkqMHt5h2SIz6gSZreoeiZla8Y4q56rvVpde6bN8fDXb
 Lk0=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1650268818; x=1652860819; bh=N3pAk4FME4FfpMn1iEoaJawKiDbUT/rSC5t
	+NXLtpDE=; b=ngOD3AFWFrt/ceE/OfeSecQhSFkdIAqL4au/Ckft9QaJpM386gc
	0ImAPwGT7Psw9TW4U9H1Wk016Xt8xz3e58a2jMPjv2GUTU3lwqJDabo248ANBg9B
	yGm/JHCOf+MkaWwS0ckjilCWJPsn++mDNKE/DElMmPiwsl/DnA2X8O5j9+e1FI/O
	Sb9z/z+qdyd3Y9JHSpmMHGQ4hYiRLI2EmbjDJfQUe+XGmCnY6Hi2UDi/exS4y7fr
	1KX3e3L6UMTrKsZi4KA7lcWdg1otbXp3BYKvKqOI1E8g+9m6JavT2WjH+kV8tJq0
	p4fOa4l54RqiF7FiS1+NPOJ/yFRpyCwiSew==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <fd915a51-035f-d5c6-42a1-c517e3d1f1b1@opensource.wdc.com>
Date: Mon, 18 Apr 2022 17:00:11 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [dm-devel] [PATCH 05/11] dm-zoned: don't set the
 discard_alignment queue limit
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Jan Hoeppner <hoeppner@linux.ibm.com>, "Michael S. Tsirkin"
 <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
 linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org,
 Song Liu <song@kernel.org>, dm-devel@redhat.com,
 "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>,
 linux-s390@vger.kernel.org, Richard Weinberger <richard@nod.at>,
 xen-devel@lists.xenproject.org, linux-um@lists.infradead.org,
 Mike Snitzer <snitzer@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
 nbd@other.debian.org, linux-block@vger.kernel.org,
 Stefan Haberland <sth@linux.ibm.com>, linux-raid@vger.kernel.org,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 Johannes Berg <johannes@sipsolutions.net>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-6-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220418045314.360785-6-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/18/22 13:53, Christoph Hellwig wrote:
> The discard_alignment queue limit is named a bit misleading means the
> offset into the block device at which the discard granularity starts.
> Setting it to the discard granularity as done by dm-zoned is mostly
> harmless but also useless.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/md/dm-zoned-target.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
> index cac295cc8840e..0ec5d8b9b1a4e 100644
> --- a/drivers/md/dm-zoned-target.c
> +++ b/drivers/md/dm-zoned-target.c
> @@ -1001,7 +1001,7 @@ static void dmz_io_hints(struct dm_target *ti, struct queue_limits *limits)
>  	blk_limits_io_min(limits, DMZ_BLOCK_SIZE);
>  	blk_limits_io_opt(limits, DMZ_BLOCK_SIZE);
>  
> -	limits->discard_alignment = DMZ_BLOCK_SIZE;
> +	limits->discard_alignment = 0;
>  	limits->discard_granularity = DMZ_BLOCK_SIZE;
>  	limits->max_discard_sectors = chunk_sectors;
>  	limits->max_hw_discard_sectors = chunk_sectors
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 08:01:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 08:01:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306996.522224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMJs-00053n-9y; Mon, 18 Apr 2022 08:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306996.522224; Mon, 18 Apr 2022 08:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMJs-00053g-6f; Mon, 18 Apr 2022 08:01:12 +0000
Received: by outflank-mailman (input) for mailman id 306996;
 Mon, 18 Apr 2022 08:01:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pOmA=U4=opensource.wdc.com=prvs=10001294c=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1ngMJr-0004cS-Cs
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 08:01:11 +0000
Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3b2543f-beed-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 10:01:09 +0200 (CEST)
Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com)
 ([199.255.45.15])
 by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:01:06 +0800
Received: from uls-op-cesaip02.wdc.com ([10.248.3.37])
 by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 00:31:27 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 01:01:07 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfWk35dFz1SVp4
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 01:01:06 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id bb1julzUhVc3 for <xen-devel@lists.xenproject.org>;
 Mon, 18 Apr 2022 01:01:05 -0700 (PDT)
Received: from [10.225.163.14] (unknown [10.225.163.14])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfWd1wHlz1Rvlx;
 Mon, 18 Apr 2022 01:01:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3b2543f-beed-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1650268869; x=1681804869;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=3/KeY74fCa89/HKmeQeN7bAvF9g3Fcpr0R9Z+15MzFA=;
  b=n3VUvakaw7u3ZLZBeVEpaOvi+Kn8121F2/n6FX023+B8RaAGfVaF0fXQ
   N34pdiutwzL6az2zVCDYIj3hQpxl2hGGa1dLED/RuGaB7rU5c5um9Pgxr
   2UwNGqUfZfJN21r86IXAZBg2E+K/XmLGINFkt1woms3U2zAmJ+u3qEkOk
   k1b0bZA/efGvbT2lpxzLsmainMQkMGoUKuoDwECbjTE/7xImw3X7o/aGC
   tPg60J21kEmukKrYqYJSOyaajwcPsutNTrsy531MZbwYZn6h2tewlkr3g
   5UO+tzh86RaaPWMtEM/dwzEnDKY8guZTnecWSlyPoMyODPJhVNbE0nxCi
   g==;
X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; 
   d="scan'208";a="302341556"
IronPort-SDR: FSK+niTIVWPIyQbKdZR9DcXH2NU6rXAVwfSU3IUc17ZRuhaFIUSqjuaaVYFAHmVocOswTKA0Jj
 qtKQiGIMElpiVUi2RKfk+fQ+h5/KTCQvhu4KB7CoawlWtmaJsSzr9TPVWhC1MJOD+bcpLbZrJZ
 dAtWWZj1Cqzyy+eArFi7qCLsFTVq/lQ+pCVGjVNKXbGy2TelIM3xRuO8ZN8r8Av1uMqy1Ef98/
 dyC41Jwxg89q1C1TuMRoHzKG6qahryggP9DWCyCaYL2z0FRgvCazs7sLmjT1SkIHsu8zTJzgy+
 0mNFOMzyT89mlqD7N81UOr5B
IronPort-SDR: LL/yxAMcvWV+8u3amKRZeDi8bALPYNhlL4Sb3gUsUW50/sY+GVheGM96arfLRe4Bm2Y1g6v9fF
 ww9vz41jQVM0cSKvYpiSEUuoPLUGM7BgBkABRuM1xk6Im7rPnNpZ9CLs33UUz93aRXmwe+9P5u
 sN3Gs8GclG4ODsOZOJ9yGZoEPEnPnNPAiLMIowOfx+gVAEqepruGYwD87t9xWYmR5G0x0tY4wb
 ePWSQ9G9OOaXHtQV038VahJpQu08ivHwGf5s0SVNmKBuwi/xHFx8Qw0ituC0MIey4s9x5GyAj3
 6qo=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1650268865; x=1652860866; bh=3/KeY74fCa89/HKmeQeN7bAvF9g3Fcpr0R9
	Z+15MzFA=; b=ACjR9UWryki+eudgsq/STqOr+GWbZj16v+u8a2Dftxm2lDM945o
	bVfFaY/GsX43zY1Oaqxrub1Jc7lHHvzftjDWfDRuVxraf/ZRLqw//ZXMp0b77lQF
	9nYnsBvjkMg6iSu1Rv/HmkRv1DVTbN1qSEzerCzsXyF6bp1SxFaGiDvrfWwA/S8s
	Ou+wVx4dk6/UkHkzLXk1TgA23a21B8j7ugHMvIsEFVP+7333Loa1WdkbITzQ4Hw9
	emhVU3z9B140JbFTYr/MrEfmv94Pd9Ofm/6fRMxFKfgG5QPr8AyMYWl9tghfqOsu
	In8Vw6oTR+9i83mC26mJTU/FoazxybA/EHA==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <fb5baf81-fa19-bb48-865c-e13277a0952a@opensource.wdc.com>
Date: Mon, 18 Apr 2022 17:01:00 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [dm-devel] [PATCH 03/11] null_blk: don't set the
 discard_alignment queue limit
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Jan Hoeppner <hoeppner@linux.ibm.com>, "Michael S. Tsirkin"
 <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
 linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org,
 Song Liu <song@kernel.org>, dm-devel@redhat.com,
 "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>,
 linux-s390@vger.kernel.org, Richard Weinberger <richard@nod.at>,
 xen-devel@lists.xenproject.org, linux-um@lists.infradead.org,
 Mike Snitzer <snitzer@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
 nbd@other.debian.org, linux-block@vger.kernel.org,
 Stefan Haberland <sth@linux.ibm.com>, linux-raid@vger.kernel.org,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 Johannes Berg <johannes@sipsolutions.net>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-4-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220418045314.360785-4-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/18/22 13:53, Christoph Hellwig wrote:
> The discard_alignment queue limit is named a bit misleading means the
> offset into the block device at which the discard granularity starts.
> Setting it to the discard granularity as done by null_blk is mostly
> harmless but also useless.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/block/null_blk/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index 5cb4c92cdffea..a521e914a9843 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -1765,7 +1765,6 @@ static void null_config_discard(struct nullb *nullb)
>  	}
>  
>  	nullb->q->limits.discard_granularity = nullb->dev->blocksize;
> -	nullb->q->limits.discard_alignment = nullb->dev->blocksize;
>  	blk_queue_max_discard_sectors(nullb->q, UINT_MAX >> 9);
>  }
>  

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 08:02:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 08:02:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307004.522234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngML3-0005rH-LD; Mon, 18 Apr 2022 08:02:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307004.522234; Mon, 18 Apr 2022 08:02:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngML3-0005rA-IK; Mon, 18 Apr 2022 08:02:25 +0000
Received: by outflank-mailman (input) for mailman id 307004;
 Mon, 18 Apr 2022 08:02:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pOmA=U4=opensource.wdc.com=prvs=10001294c=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1ngML2-0005qu-AY
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 08:02:24 +0000
Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df89e3fb-beed-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 10:02:22 +0200 (CEST)
Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com)
 ([199.255.45.14])
 by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:02:18 +0800
Received: from uls-op-cesaip02.wdc.com ([10.248.3.37])
 by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 00:33:27 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 01:02:21 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfY7613Cz1SVp2
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 01:02:19 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id VxOvw3OKk_Vi for <xen-devel@lists.xenproject.org>;
 Mon, 18 Apr 2022 01:02:19 -0700 (PDT)
Received: from [10.225.163.14] (unknown [10.225.163.14])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfY24GYPz1Rvlx;
 Mon, 18 Apr 2022 01:02:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df89e3fb-beed-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1650268940; x=1681804940;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=OmPuKz2YWA8zfnI8UisdXu/UB5gIbMI/eeJtu4mrOgE=;
  b=UAYpmOe1Ga9rpGWf/oYIVNxr6xHWAv9DodQoZP6Vp7+zyCHy7LzEWMe9
   SlupvqE/I8Ukh5gj/uKzwQSYQ5NhKgSLAajoKsjyy1Gey3E80RAeD+3oM
   6DfkUXvDs/jKzfQBhKTcpOvdl2ez91iEt54/BxjiXVhGCOOBbqlh7UEjU
   69iu5MUEkLAzYoZyHk9h782ySIAc69FIn7g2sa375uIfjDMNXZu+tWX1y
   j10OzbgBHscqmSqknpJF82S+o+qQAHZ9AyF+XYVSUh4wCurLXaKdh76oL
   2icwJC8WZOWNbPgL6fSfVzuLH+HaE0+zh8yR9+gx5WkmaMcsscw9FgEVS
   Q==;
X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; 
   d="scan'208";a="310120099"
IronPort-SDR: NPz6pUrKH+IKjih5Eho4MX5TsnfwsKckpV2Oio4YneRCdHk5SNkKmAiwCmWJRgxHaXafiubSPw
 fWvKkvZOO6HpvHcrY/YWaX5RquicpR8u4gKy6q1b/UxZ34MkBs5OH733NOkxPTIj+2bppS9Yzl
 /bESb4xU/zWCqnZkE4MDapay06cfqXjSGbEIRa2oiXMRv0rfB/yR1HAZ96UtIMIwIbcI6CE2k4
 2/P83vsy1BE3LGapVO1r8xoKJZnXNm8ayA+eO9IXkvHh0mjOSMp3YAk7omG/ncMaBDpJWWOl4z
 XUUYfWfmlCh+fAffjGgOMhOG
IronPort-SDR: 1sk8GsPnvxngwDfq5I2X1GlngP5rHoTjXQOzOMa65Ii3FtjJvR4KGeNBfR1TFCih9IzaYzVVW0
 GppzRVt0av45coByGUj3xSLrgO0TvV5O/Npw+YwuIQ+gESGb7Gqc9EKi0+tlrtRWS5Y/6E1Fw/
 K8zpyI9imErcRPx+fsR7CkLEoLbXyAU3AfWsg/tgeOc0GVKKSDycQDP2w2VfjjLmdbXVfh/VvX
 ehu8zL8verrWCGyQgDsEpVHFSbHp1zw9CDgFZlUa1FtuSWGbQELdRZM9bcJmSubcLW2jTKY0wm
 74M=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1650268939; x=1652860940; bh=OmPuKz2YWA8zfnI8UisdXu/UB5gIbMI/eeJ
	tu4mrOgE=; b=k+ny4hyvVfxtH5oBMEu00VLv8LgxeeF+SRrMURWYyg8tMFDxkwO
	b45mao7rScufOtmSeeirU8HISQWEsqx4Z0+6Fp4WqP+u1N3fE8V/YIR6F2X+HeuX
	iefLcNmsD6ccKAg8s1APjkVBBM5TxNfPxViHr0PfOhnQWubPOFyhCNR52v6EBzYf
	mQuACDthuVg7XI9wnY368QOgdxnn4zmZyGLPUy6JsbIKZRxqrCxMqlH7F33rlWbN
	zGaLtX1DYo/0fZe2l+XJY/ItU0InrXWf+SYpSLJmCouyQlCkf2fR+ljgMe6ZYxxb
	dtxP5RP+Z16XgALOx7aLuUc4/TgwOGCLLXg==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <cd77bfd9-e133-1929-2d61-73822ad95366@opensource.wdc.com>
Date: Mon, 18 Apr 2022 17:02:13 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [dm-devel] [PATCH 09/11] nvme: remove a spurious clear of
 discard_alignment
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Jan Hoeppner <hoeppner@linux.ibm.com>, "Michael S. Tsirkin"
 <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
 linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org,
 Song Liu <song@kernel.org>, dm-devel@redhat.com,
 "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>,
 linux-s390@vger.kernel.org, Richard Weinberger <richard@nod.at>,
 xen-devel@lists.xenproject.org, linux-um@lists.infradead.org,
 Mike Snitzer <snitzer@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
 nbd@other.debian.org, linux-block@vger.kernel.org,
 Stefan Haberland <sth@linux.ibm.com>, linux-raid@vger.kernel.org,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 Johannes Berg <johannes@sipsolutions.net>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-10-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220418045314.360785-10-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/18/22 13:53, Christoph Hellwig wrote:
> The nvme driver never sets a discard_alignment, so it also doens't need
> to clear it to zero.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/nvme/host/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index b9b0fbde97c80..76a9ccd5d064a 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1628,7 +1628,6 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
>  	BUILD_BUG_ON(PAGE_SIZE / sizeof(struct nvme_dsm_range) <
>  			NVME_DSM_MAX_RANGES);
>  
> -	queue->limits.discard_alignment = 0;
>  	queue->limits.discard_granularity = size;
>  
>  	/* If discard is already enabled, don't reset queue limits */

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 08:02:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 08:02:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307009.522246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMLV-0006Rp-1M; Mon, 18 Apr 2022 08:02:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307009.522246; Mon, 18 Apr 2022 08:02:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMLU-0006Ri-Ua; Mon, 18 Apr 2022 08:02:52 +0000
Received: by outflank-mailman (input) for mailman id 307009;
 Mon, 18 Apr 2022 08:02:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pOmA=U4=opensource.wdc.com=prvs=10001294c=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1ngMLT-0006DK-14
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 08:02:51 +0000
Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f00750fa-beed-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 10:02:50 +0200 (CEST)
Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com)
 ([199.255.45.14])
 by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:02:47 +0800
Received: from uls-op-cesaip02.wdc.com ([10.248.3.37])
 by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 00:33:55 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 01:02:49 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfYg5rsWz1SVp4
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 01:02:47 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id F9TQifwSoqxs for <xen-devel@lists.xenproject.org>;
 Mon, 18 Apr 2022 01:02:47 -0700 (PDT)
Received: from [10.225.163.14] (unknown [10.225.163.14])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfYZ5jVFz1Rwrw;
 Mon, 18 Apr 2022 01:02:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f00750fa-beed-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1650268969; x=1681804969;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=MERTNbn4AhK74X7Db7lDnICPdc+nuPVKeYAvKUf3y7M=;
  b=SOCuxhlZJ7WRjcH9BTWHPdr45UYEoIA6NQ2cvItkmf/HPVhjPHrmwjXb
   pLBPXztjHBW7cGuUVGNHYWZb5CiklBhgcabMUN3MMC1s261WbehzCmgzD
   NOjkFNOlPS8yGpCPaee6FWEIlkbeTG9gcLgvIWmNuu2gWK4Ka64kC4UhL
   M7+v1y092SJRbX825DLoY5ZXTTdRMHDrJN/GL+Q/RWFtM4pLDpGW6Gwda
   ilkqf5Vmkh72q3OedQd+J8W/Jt7RcnzirSt5K1xfWaVBvtD4oS9Jw7xA7
   OozQTuEd2AQJwo9yaDU+9NBB7NcKTir4s7l/wiqoCYlJjR7e1AQXI+3ci
   Q==;
X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; 
   d="scan'208";a="302341719"
IronPort-SDR: F6HphDK79lVKdJUEbCpaz0QQdl9N4jHR69ZKiLELdafpiwEuRMXq1uQD7mIGDkOsWFfj41mzZy
 7LAJl96soOLOzMcZh3dWBqGLxaWHUy7jzEq+wYRVZAMxhGOaCVtxI7+tLFat5pGtPnLKUfJcmq
 iH/nuTrHKYaz4pqtkezoqkDxFbX0uM9L2V0D2DEUU4tfezBTXWJYezvPo2K2UxT41srZIxHIvm
 HGOkOTIK4yTKquMb1zC37Atg7imDvIzeHZjivp/kRZtiI6x6T9MFoDbOH9Ibku5U+YPaWOgVlE
 lLQWorfIzdti+TkM4gqFdUG5
IronPort-SDR: ey49updTy2G5R496629lYGShk8E54BdpPbx50jXUcFVqlYiMdYxC38PlcBvu37dUWE2/A1aT45
 NmwLfqkRAMPuflCOPpYdtLB8/HV2ElDeG+uLxM3hV2HJdzBc6P+94S2S7IhVwK5Oo9qzCC2O+0
 3LBJdhDFuRSly8Z6fXvKS5bzUbuT6b1gpacDSw2RlnWFDraczhPwBSlAhetiWJ2SrXb0Cm3/l7
 MeIGTmZARSNWmBeno0sKMzD39UVWEWurEw+2AYkJTn3Hqa/0r22o/Uz6FAsmk7HMvobI7jY5DI
 IMQ=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1650268967; x=1652860968; bh=MERTNbn4AhK74X7Db7lDnICPdc+nuPVKeYA
	vKUf3y7M=; b=pFSYQHMj6JxZD2nZKoXb0b+2KiMHzSI7kIgL2d9DDoSJwDoyb2V
	Jot0KfiMcXahH+V15PE1aTl0G8AenwSXzG0WI7RDrUfFB7doNcD0BJwPAxrGthTB
	RPQdEZribmuuBdGwDqJzjpAGgGWu5Iv8j9e7smsHQ3EGJ7uUKUVyDKHw0Dwpjb5m
	VKXGaoKFCl61VF680DWPqgyQwWoSspl7DQpeul4qZDKZ8KZf5ni07sUW5KEoQB8R
	LOx5yqrztNmP9PtPKNFGRrWiJVnFNw27cIxXm22F73QFgn/A+fQU8CE1vn6vx4oc
	nzsZRnXmNP6Vi4We3fjaZm/ox3jdWeRsAgQ==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <1cef25df-b00d-4590-5598-555c5d97d1c1@opensource.wdc.com>
Date: Mon, 18 Apr 2022 17:02:41 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [dm-devel] [PATCH 10/11] rnbd-srv: use bdev_discard_alignment
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Jan Hoeppner <hoeppner@linux.ibm.com>, "Michael S. Tsirkin"
 <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
 linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org,
 Song Liu <song@kernel.org>, dm-devel@redhat.com,
 "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>,
 linux-s390@vger.kernel.org, Richard Weinberger <richard@nod.at>,
 xen-devel@lists.xenproject.org, linux-um@lists.infradead.org,
 Mike Snitzer <snitzer@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
 nbd@other.debian.org, linux-block@vger.kernel.org,
 Stefan Haberland <sth@linux.ibm.com>, linux-raid@vger.kernel.org,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 Johannes Berg <johannes@sipsolutions.net>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-11-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220418045314.360785-11-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/18/22 13:53, Christoph Hellwig wrote:
> Use bdev_discard_alignment to calculate the correct discard alignment
> offset even for partitions instead of just looking at the queue limit.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/block/rnbd/rnbd-srv-dev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
> index d080a0de59225..4309e52524691 100644
> --- a/drivers/block/rnbd/rnbd-srv-dev.h
> +++ b/drivers/block/rnbd/rnbd-srv-dev.h
> @@ -59,7 +59,7 @@ static inline int rnbd_dev_get_discard_granularity(const struct rnbd_dev *dev)
>  
>  static inline int rnbd_dev_get_discard_alignment(const struct rnbd_dev *dev)
>  {
> -	return bdev_get_queue(dev->bdev)->limits.discard_alignment;
> +	return bdev_discard_alignment(dev->bdev);
>  }
>  
>  #endif /* RNBD_SRV_DEV_H */

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 08:03:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 08:03:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307014.522256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMMQ-00073g-Ar; Mon, 18 Apr 2022 08:03:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307014.522256; Mon, 18 Apr 2022 08:03:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMMQ-00073Z-7p; Mon, 18 Apr 2022 08:03:50 +0000
Received: by outflank-mailman (input) for mailman id 307014;
 Mon, 18 Apr 2022 08:03:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pOmA=U4=opensource.wdc.com=prvs=10001294c=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1ngMMO-0006DK-Ho
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 08:03:48 +0000
Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 11f0512e-beee-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 10:03:47 +0200 (CEST)
Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com)
 ([199.255.45.15])
 by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:03:46 +0800
Received: from uls-op-cesaip02.wdc.com ([10.248.3.37])
 by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 00:34:05 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 01:03:45 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfZm2prXz1SVp4
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 01:03:44 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id g-pMfqZHpZX9 for <xen-devel@lists.xenproject.org>;
 Mon, 18 Apr 2022 01:03:43 -0700 (PDT)
Received: from [10.225.163.14] (unknown [10.225.163.14])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfZg2dWsz1Rvlx;
 Mon, 18 Apr 2022 01:03:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11f0512e-beee-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1650269028; x=1681805028;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=rst7WZOXaJnTOprfWYkoaRENgax/3SjcG41/Nf0ZaiQ=;
  b=EmdD7FamYGmavx1pUGfT1fI8RCXuQt/sLKvEI6XvEoYEa8tCQJHYWMyo
   Da7WKAwPjA16523o9E8lfx4JbLWg8frrVTynHnbW9K4X48xKLE17yOQLs
   mkwASqVuZyKzzQoisr5JTJIuVDHTf26WfCZIso66cwu/xCcidWuGkO/W5
   R2/CQ+sSFuMH4Emih9V5GXcnM+a6LIp0jX3c0cIm/hzBYecHWGkNHDbnr
   SNsZV1bfPDTMSWIFjZamgunEf/JRpA0fPKVSddWPtklGmwtuFtP0tGN0C
   JK6ot2tLzuYFojWRJpFcL7kjrrKZTllBi1m/OJDf+a8cDnRllznYi9wjH
   g==;
X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; 
   d="scan'208";a="199047834"
IronPort-SDR: EZv3uLcC1dQHJThopLQlejGyQWVPvjXLdxnQ0C0w01HLMA5o0ZJRaogTV1wlHb4/Q/w+zPZ9+9
 OExgT3jfo+3CY1cf8MX53I/BHrLEDIVqwmZURG1jHV/Z0AUkdV/KsXlz2Q/RFUZ/L3UcJECC8l
 c3ZTJnxarvJj/i9PGps9tkWBZ0rHDGtgI82SOWSn5fzGv1sj9YkQAAzkDqSmIuTbsqCpxyD3Ag
 R4VrbcrR9aj+AWBnkiYAyXozG1hE7P2P4ZlYq27sCCmlwAAnzE2KL8KVdz0mPijUhR4G738pkw
 nSUUmuWbG0y0J237G2SRYwv5
IronPort-SDR: FzI1DlYTfmOdUDHCnSQhuP5LJ92ZlCsmTBwLm4MWvTpCgx0kq8WRmc45c51e5Q/2qCCDa+kaHb
 JkYJslACdFipRMLvDG2/IaELV8LT75MwLLDSZsFxt27g/nCIhKhu9hoSsW/65tDZlc21QAe4Ev
 u6jz1dAoIP9q3iMl8K7EuiqnJACe4WEMUyYWxqxT/H6khAflJ2I4IGsLnPPLuCtkyP5/0Jv+Y2
 KvlECgNMWmnCJ5JCQ3cP9UnqaVNIUcc8WXwh3H9wQ+BVXVGKw7mXbXHR328Ub/eNaUMjnUGqns
 aZM=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1650269023; x=1652861024; bh=rst7WZOXaJnTOprfWYkoaRENgax/3SjcG41
	/Nf0ZaiQ=; b=YwIZvBG+Q6As3HMHZdqx3chNbvRrKNFPClgQ9l4SFijMhFWKZ8E
	YhLeA+aCumtaM4E8BSAw9tPoo+DFBjRdgzlDdYb1CVrznhaoDlJ5uLs4geuSL4/H
	TFurAULN2uVb/wBvNTrstEc0MtfZQQC0eAZB0U4q1eddErc1Eqd9jJiRpAIQbe+k
	Q6pWlnCRUg6h1llQU+3m8+z63aBnXWWbfre3psRJEGoWwAs955kZAevrPBkjOGNR
	HWtFV1/L0EzZNT5wA87k5Wfl0lxZ+bjousfqKAOSqGkvi12NRpaAXEsEXcJSsNpy
	VzvPiiCk/j6EtUs7OZ5fTKWjV1EJcsRrgNg==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <034efb57-9e1d-41ed-1855-e2b057b03ea7@opensource.wdc.com>
Date: Mon, 18 Apr 2022 17:03:38 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [dm-devel] [PATCH 11/11] xen-blkback: use bdev_discard_alignment
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Jan Hoeppner <hoeppner@linux.ibm.com>, "Michael S. Tsirkin"
 <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
 linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org,
 Song Liu <song@kernel.org>, dm-devel@redhat.com,
 "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>,
 linux-s390@vger.kernel.org, Richard Weinberger <richard@nod.at>,
 xen-devel@lists.xenproject.org, linux-um@lists.infradead.org,
 Mike Snitzer <snitzer@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
 nbd@other.debian.org, linux-block@vger.kernel.org,
 Stefan Haberland <sth@linux.ibm.com>, linux-raid@vger.kernel.org,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 Johannes Berg <johannes@sipsolutions.net>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-12-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220418045314.360785-12-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/18/22 13:53, Christoph Hellwig wrote:
> Use bdev_discard_alignment to calculate the correct discard alignment
> offset even for partitions instead of just looking at the queue limit.
> 
> Also switch to use bdev_discard_granularity to get rid of the last direct
> queue reference in xen_blkbk_discard.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/block/xen-blkback/xenbus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index b21bffc9c50bc..04c90cb8955f6 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -583,14 +583,14 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
>  	if (bdev_max_discard_sectors(bdev)) {
>  		err = xenbus_printf(xbt, dev->nodename,
>  			"discard-granularity", "%u",
> -			q->limits.discard_granularity);
> +			bdev_discard_granularity(bdev));
>  		if (err) {
>  			dev_warn(&dev->dev, "writing discard-granularity (%d)", err);
>  			return;
>  		}
>  		err = xenbus_printf(xbt, dev->nodename,
>  			"discard-alignment", "%u",
> -			q->limits.discard_alignment);
> +			bdev_discard_alignment(bdev));
>  		if (err) {
>  			dev_warn(&dev->dev, "writing discard-alignment (%d)", err);
>  			return;

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 08:04:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 08:04:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307020.522268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMMw-0007bM-KU; Mon, 18 Apr 2022 08:04:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307020.522268; Mon, 18 Apr 2022 08:04:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMMw-0007bF-HT; Mon, 18 Apr 2022 08:04:22 +0000
Received: by outflank-mailman (input) for mailman id 307020;
 Mon, 18 Apr 2022 08:04:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pOmA=U4=opensource.wdc.com=prvs=10001294c=damien.lemoal@srs-se1.protection.inumbo.net>)
 id 1ngMMv-0007PH-6V
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 08:04:21 +0000
Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 25dfe76e-beee-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 10:04:20 +0200 (CEST)
Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com)
 ([199.255.45.15])
 by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:04:16 +0800
Received: from uls-op-cesaip02.wdc.com ([10.248.3.37])
 by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 00:34:39 -0700
Received: from usg-ed-osssrv.wdc.com ([10.3.10.180])
 by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 18 Apr 2022 01:04:19 -0700
Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfbQ06vHz1SVp2
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 01:04:18 -0700 (PDT)
Received: from usg-ed-osssrv.wdc.com ([127.0.0.1])
 by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new,
 port 10026)
 with ESMTP id CAb-oJ30zaVu for <xen-devel@lists.xenproject.org>;
 Mon, 18 Apr 2022 01:04:17 -0700 (PDT)
Received: from [10.225.163.14] (unknown [10.225.163.14])
 by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfbJ6g7Wz1Rwrw;
 Mon, 18 Apr 2022 01:04:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25dfe76e-beee-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;
  t=1650269058; x=1681805058;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=rpofyDUALxK7dXMfprZ48DmzWqCt1/MYuoJj74ZUCIU=;
  b=c9HAt/u1QTECNqD99ajVLnA0kiUyw8EXC3GohKr0tgRmsbCdTxLvT5nx
   XVEBeQyO5WE4rQqY8IMWAZwZLQ8umD9b3qjCS0pJEeHF5PnDnGLE4wz/F
   Yt401ou+JYYO5EP3yUsMz/u6t8qC9UCHADscrUSyZ448zz4GTBZ88W/+t
   8Z32kccOmUCy2zCqmpZf8FfAGiqxB0vbq9WXIK5FpYk9yZ7cDBRKkHt6u
   REJdHyTgh4smym+HHCdPdYCajMtnCg8CzZVCTogT/6GHrBI6WJBvrxVa6
   a6S8SqE8Z9Cu3MuqG6BuAJCH8Mmk5VkplZzV4mR9RsJPX4y4lUZSoydN8
   A==;
X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; 
   d="scan'208";a="310120332"
IronPort-SDR: bLAYGLCb7s8Y/SCiExQ10X8inQBGQs5XYT3Ch4hjMMOvZfGbMz1IkJa8WKrtmamWpxtYRzw/bI
 mu4XBidqURZaAz1juycP6OQ6GJNwPndF14rmCvJJpgKI4iUjtynG8NvMZukvwyoGS++cW06oCI
 R/5ZwY2zPSr8SuDF6RY1pCVQ+D1xgMGVRpryeBt94/nRIN0G4FVTQs2Nm5PPmY3xttT9mHFgfQ
 R46zKgM93m1qCg5ToeHdQPGR8W3Y37wM3CC/Ouq2vRBpeMzctk+ctTTwCyNQFnZ4OVDJLMiNSh
 C4X6DbML/BsjVaFyy9W/R8Qc
IronPort-SDR: lTnMAMxNN/Q0vLxpw8sxmmKrj2CJ2mma0hhAEW+rH9dCGEonA/7O5HV+dTkZu9C0gQGJQyVD+q
 IaLYmy8sxEOuGoPoT/os/U2nTcOhzF/PJCia/5abgVYlvQWCP1YKoSJyyvcwdJO+USNZtxgIOP
 VBdXbIEGJHu+CgAbFUudCmEDMPeB6D18eGYG9zwIY1Pcz3bVCwRdqqa89PlyN+IAfLdqRanNcj
 Td29iafgMgDMFyGLPHMr4GHkHQqcCnTnrJUwSsLXinB7XOF5j6J2UkveYUAHpI9NnuwUo0VnOi
 FrU=
WDCIronportException: Internal
Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass
	reason="pass (just generated, assumed good)"
	header.d=opensource.wdc.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=
	opensource.wdc.com; h=content-transfer-encoding:content-type
	:in-reply-to:organization:from:references:to:content-language
	:subject:user-agent:mime-version:date:message-id; s=dkim; t=
	1650269057; x=1652861058; bh=rpofyDUALxK7dXMfprZ48DmzWqCt1/MYuoJ
	j74ZUCIU=; b=HJZNzwH+Ya8Lh7fQ8EMITGW2E5Om7BfPbFoRhLpWnW1FNcZ8M97
	TK23SdL3V92f6aNBG2vIYI0gDssBn/mhxBwSaBmQ/xfiGX6JpTqdbyplEcM3/QPd
	YyR04YET0AyNeqqGu/qYp7lW/huq0m6CT68sYmcr630FWrzGkdmCtJbqrWNypH2Y
	TJVuIpVo+OZCpO89xGW7fGtNGyFZvGt5M0KC+IJs3BaNbOroa0IUVJXir/qiQd5B
	lqD1wpmPTbVXvHTfgzngWAccyjf/xfEF71aKD++ki43Kx1QfUXAHkCRRPeo2dA+i
	R2SGy4d83q83vsdCn6C41e1TqK2ajxRurdQ==
X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com
Message-ID: <18032025-f1aa-2daa-d012-8996590ada6a@opensource.wdc.com>
Date: Mon, 18 Apr 2022 17:04:11 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [dm-devel] [PATCH 08/11] loop: remove a spurious clear of
 discard_alignment
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Jan Hoeppner <hoeppner@linux.ibm.com>, "Michael S. Tsirkin"
 <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
 linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org,
 Song Liu <song@kernel.org>, dm-devel@redhat.com,
 "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>,
 linux-s390@vger.kernel.org, Richard Weinberger <richard@nod.at>,
 xen-devel@lists.xenproject.org, linux-um@lists.infradead.org,
 Mike Snitzer <snitzer@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
 nbd@other.debian.org, linux-block@vger.kernel.org,
 Stefan Haberland <sth@linux.ibm.com>, linux-raid@vger.kernel.org,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 Johannes Berg <johannes@sipsolutions.net>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-9-hch@lst.de>
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220418045314.360785-9-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/18/22 13:53, Christoph Hellwig wrote:
> The loop driver never sets a discard_alignment, so it also doens't need
> to clear it to zero.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/block/loop.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 976cf987b3920..61b642b966a08 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -789,7 +789,6 @@ static void loop_config_discard(struct loop_device *lo)
>  		blk_queue_max_discard_sectors(q, 0);
>  		blk_queue_max_write_zeroes_sectors(q, 0);
>  	}
> -	q->limits.discard_alignment = 0;
>  }
>  
>  struct loop_worker {

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 08:29:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 08:29:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307028.522278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMlL-0001pV-KN; Mon, 18 Apr 2022 08:29:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307028.522278; Mon, 18 Apr 2022 08:29:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngMlL-0001pO-HY; Mon, 18 Apr 2022 08:29:35 +0000
Received: by outflank-mailman (input) for mailman id 307028;
 Mon, 18 Apr 2022 08:29:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngMlK-0001ov-J1; Mon, 18 Apr 2022 08:29:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngMlK-0000tX-Bx; Mon, 18 Apr 2022 08:29:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngMlK-0005VL-0R; Mon, 18 Apr 2022 08:29:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngMlJ-0007mx-WE; Mon, 18 Apr 2022 08:29:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=o95GC+hJQXQmBCNI08ykHrPTArd33SW4F583cB5y/kI=; b=jO/JakXr4JOgBD9QmhKR+TAWXd
	XlpbfKUpqBSyAapjHqSW+xZ3CmROwmHy3g0XknYdXIXso/Hec58z/iWxf5GZP7kXBy7/4NyWMX+JM
	XxMkQurnublwDENF7nGP1gDKgiGx7gBt4GY9ORnWlGPYUagKtBaH+JlhGMtdY9Dsbh1s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169504-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169504: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 08:29:33 +0000

flight 169504 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169504/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  474 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   50 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 08:59:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 08:59:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307039.522290 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNED-0005I2-0y; Mon, 18 Apr 2022 08:59:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307039.522290; Mon, 18 Apr 2022 08:59:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNEC-0005Hv-U6; Mon, 18 Apr 2022 08:59:24 +0000
Received: by outflank-mailman (input) for mailman id 307039;
 Mon, 18 Apr 2022 08:59:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngNEB-0005Hl-NT; Mon, 18 Apr 2022 08:59:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngNEB-0001Ol-GE; Mon, 18 Apr 2022 08:59:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngNEB-0006Bx-4a; Mon, 18 Apr 2022 08:59:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngNEB-000788-49; Mon, 18 Apr 2022 08:59:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=egvDkFHUz4hzLGfTcM8JbsiFAL+vjysRyRRMRYCrOho=; b=U2CU8l673JQNIHkw1ah/f7tn+H
	D8aQmPLx+tJuNK4oHpebZe8EMMj7/p4hM46AMNjyx71azlpMFX2Leht/KLXh/Hy236vTwCkEKUavy
	L9KHQ4EbqoFacjWAl2D/CVoCK2mZjFn87eDNqXXlzPNcEEu9HZiwydIhglxrq60r1ydQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169505-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169505: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 08:59:23 +0000

flight 169505 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169505/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  475 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   51 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:08:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:08:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307048.522300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNNO-0006uo-4Z; Mon, 18 Apr 2022 09:08:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307048.522300; Mon, 18 Apr 2022 09:08:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNNO-0006uh-1d; Mon, 18 Apr 2022 09:08:54 +0000
Received: by outflank-mailman (input) for mailman id 307048;
 Mon, 18 Apr 2022 09:08:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNNM-0006ub-Gn
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:08:52 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on061f.outbound.protection.outlook.com
 [2a01:111:f400:fe07::61f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 27c87a87-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:08:50 +0200 (CEST)
Received: from AM5PR1001CA0051.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::28) by AM0PR08MB5297.eurprd08.prod.outlook.com
 (2603:10a6:208:18a::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:08:45 +0000
Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:15:cafe::9a) by AM5PR1001CA0051.outlook.office365.com
 (2603:10a6:206:15::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:08:45 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:08:44 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Mon, 18 Apr 2022 09:08:44 +0000
Received: from cea964681399.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 72641FAC-1115-434F-B749-2300E8A819C9.1; 
 Mon, 18 Apr 2022 09:08:37 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cea964681399.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:08:37 +0000
Received: from AS9PR06CA0405.eurprd06.prod.outlook.com (2603:10a6:20b:461::35)
 by AM4PR08MB2786.eurprd08.prod.outlook.com (2603:10a6:205:9::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:08:35 +0000
Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::65) by AS9PR06CA0405.outlook.office365.com
 (2603:10a6:20b:461::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Mon, 18 Apr 2022 09:08:35 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:08:35 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:08:32 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:08:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27c87a87-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uWDfg78C1UDetJEmkoFFM9pCZJTLn7wc10oRJng+Vmw=;
 b=JRNhaqyftzItjnA2Sl2xjKKSVvE9AsRUCUZuPlIS164AHVb31Bgk5csyhkErPszV6HoqeRKVx5ltmqOAsKsatx8FEVlvFRks4u9PiWfwudU5ji5JCD6miFi9Q1r7fbZEf8OCuN5bbKbGsd1Li0ChtVeYZJx2BoLhaUrrhFyhV+Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7b82d4f1b73fcc74
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R93Z8CACV3A/F55iQDu5fqLpVSc6u7eJ0xAelwW1eRpQv3B6tRh8lEek9JBuXQ1DtXN9qNH9w9DMsz2n/1508kkuYedYE9j1vnhZNZhr/ckhYcCUMv7CiLhptwxHikXGbDKnH6EiRjzzSzxz6PorpHDMkAE4SoHSzYwIBI47OnwTyziS+m85+042idObYtnr3ttz31zru5G3Xv2ssmfj21e0isWv/L1DRT+DAJfvzTkMSbWzaNw4/2t9nT8Cd/JR3a8/t/t2tjY6SdHZFJcf9fFQQQygQvtvWHJJzsJEWGAbFE7dKb01McuqBBdu0zHpoNKzKnfpg83d/96dl+2TLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uWDfg78C1UDetJEmkoFFM9pCZJTLn7wc10oRJng+Vmw=;
 b=YYRM7VxsqG3PE7QIDK5IB0LBpm1g4GwhQUq2r+m18t1CG7twrZA+nBdQhGWWlGSlvAPp4TuTuPA2smVULbsv2ozfTWltWsYbXTC19E+QaA3ULdD8yCmHH2F0+0jedq1kNC0tBNDNL96+1oSaGKkK3XDucJ8LgP/QpTVi2+585Ov036xo6omXe0Ikj1QlMqy6P4lbkygDeD1ekFFondtO/4VH7USrgv/UADtkMY8Y39Fr7Fk6nVaXzlTNxE0GsBKIG+BsFaEBLjBZ+RijfxPEeAUWNchfqDehfJk/UlU6SyI1GI8geoLv5/5TUf3awRZv6G26NIUfnEH4SSAu88m4Zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uWDfg78C1UDetJEmkoFFM9pCZJTLn7wc10oRJng+Vmw=;
 b=JRNhaqyftzItjnA2Sl2xjKKSVvE9AsRUCUZuPlIS164AHVb31Bgk5csyhkErPszV6HoqeRKVx5ltmqOAsKsatx8FEVlvFRks4u9PiWfwudU5ji5JCD6miFi9Q1r7fbZEf8OCuN5bbKbGsd1Li0ChtVeYZJx2BoLhaUrrhFyhV+Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Jan Beulich
	<jbeulich@suse.com>
Subject: [PATCH v2 00/10] Device tree based NUMA support for Arm - Part#1
Date: Mon, 18 Apr 2022 17:07:25 +0800
Message-ID: <20220418090735.3940393-1-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 876f0214-42b0-4bef-fe81-08da211b0a6e
X-MS-TrafficTypeDiagnostic:
	AM4PR08MB2786:EE_|AM5EUR03FT055:EE_|AM0PR08MB5297:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB5297CC9A64C54F3B4FEAC8FA9EF39@AM0PR08MB5297.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 A7rDPV5VfBp1dH3xvcZQRjwUWDXjfy8CWATwAPRdknVNV6vT477TLW0ExgqYdblcG6tYP/WNMNGPKH2j+PGxu6XltJiijwXCuhzU6Jv5S2PfKzdPCXXYYI1vzeYtVFQIu64ZOxxVL9Kdf61ZucO/OGLC4pHH4Gx1x2D7Ug2E970o/nNGaDYQ5qIobkUqUkYOuyB5B1+jr/cbSpxM4kZ7zkuhDxcSM8pS21nJu/ee5LhjvJ8RsaQmUROwMydvRv4n0JQz7B0pl2Z52RzXLotwkC9Zpw38LSRmmdCqoIjYJgWVx0LzmrXMrCGy2X7MaqdLR5klT+4aimjWS2FPuUtXKkhsiHGu/3giZ8cAXeoe/Bzawhz99WZeoXqUuXwLB+4yCPW74vGcPEuayddEWeHiopsccchSshQU44/6D3QLcaVtNefKoGfD3aZ6nB4m+zcKVhrrsRh/P19pWlZyaNZYA5MlxKMwDhn+aW4odKM+Juh7xBF6hXrVg4Rer7cqN111XXL7Z+T+ut7b34WGURdOUp1WgCFBQAjjVKDaCriRaxwJ6TfWPy8B1M3Elbm729cVS8HXWYbQaXP6FVMiDZrHhhm2O9iV+VYASXKtBZeWfp5eBCP7K9/lzS6VxYeNjI8NDHrt9mcvjKuyRbmgNxQs7Ao/unTfoED1urUkOxT7cuIJ8dS3M6w2qg5CQ3Uo1RWQD1y/RJkFJATwU8Zjlu9Wz7BAfmfyi4voO7Q6v+jfmjw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(44832011)(70586007)(316002)(70206006)(356005)(54906003)(110136005)(8936002)(4326008)(8676002)(5660300002)(2616005)(1076003)(36860700001)(186003)(336012)(81166007)(426003)(86362001)(83380400001)(508600001)(82310400005)(40460700003)(47076005)(26005)(6666004)(7696005)(36756003)(2906002)(17413003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2786
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f1a0faf3-1128-413e-15e9-08da211b04a9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6ePnHCBoZL91IjimYgU1OVc6y+kIfZjOJ+cfV5i0DgDYfuIEoQwLItcNE5lPw0HSEDeUZgV3rmt45KCnAlP2lAczoNX4Jtt8mPFaM3Uogab3UBcTbrhDsIG/GstitooBJ6Fj/nvYydCoKqNrUCRKSAGyPpIWuOdLeGc0YMHOYKA0YZ2GAEYwyFFocU3iXbmdoG2sKNw1jwIW0W/hGbGwZiCeoQmmuq5pRpi/I7nwjx2oYZG1V9eQJNQCkbB0+aCFhLrPGOIZOM8DtnU+f37/jkCUxyZN6Qmw88r5f6GNz76XSG0z41TqtyPPssjsNH6S9SUYyzeUZKegSPSgzKYmtQtbeCr00svb4Y+PSIXzw2vWbShE421v/9UoXW1Z9FQOXj7SLBLN+IE4FJ9Pxf5W4uYMvizPMBVOdqHlEi1o0WdSsVAabXTUGiD5+4fLjZkarTUYJKqRCQm6r8fO2TM3y+szzEanQdO3pQHAldoW1rx85G+lBV6KLw8hNWc3jjbBEfYJbYemQDBCthYqGjEr6fF/ITCC+tz0wvJVbEU0qLCOeLApI8YbVTwkc2EqNb0amPo5skvTKBoSvFl/OaX9IlNDUEQ4IkOn4HEZhu2bTy9Khd0WPLjGEJowQaA6fRcSe/Dzlz40mSCgnbCAzhvTzWXSzYd7u54mmFvPFLrj8qXkC/vhiCDyrA2j33Ndif3s70tCUdWmnwjR6tXOq9tYww==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(450100002)(107886003)(6666004)(86362001)(36756003)(40460700003)(2616005)(186003)(110136005)(1076003)(336012)(82310400005)(54906003)(426003)(47076005)(5660300002)(8936002)(316002)(81166007)(4326008)(44832011)(2906002)(26005)(83380400001)(508600001)(70206006)(70586007)(36860700001)(8676002)(7696005)(17413003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:08:44.8288
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 876f0214-42b0-4bef-fe81-08da211b0a6e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5297

(The Arm device tree based NUMA support patch set contains 35
patches. In order to make stuff easier for reviewers, I split
them into 3 parts:
1. Preparation. I have re-sorted the patch series. And moved
   independent patches to the head of the series.
2. Move generically usable code from x86 to common.
3. Add new code to support Arm.

This series only contains the first part patches.
The full patch list can be found in this cover letter.)

Xen memory allocation and scheduler modules are NUMA aware.
But actually, on x86 has implemented the architecture APIs
to support NUMA. Arm was providing a set of fake architecture
APIs to make it compatible with NUMA awared memory allocation
and scheduler.

Arm system was working well as a single node NUMA system with
these fake APIs, because we didn't have multiple nodes NUMA
system on Arm. But in recent years, more and more Arm devices
support multiple nodes NUMA system.

So now we have a new problem. When Xen is running on these Arm
devices, Xen still treat them as single node SMP systems. The
NUMA affinity capability of Xen memory allocation and scheduler
becomes meaningless. Because they rely on input data that does
not reflect real NUMA layout.

Xen still think the access time for all of the memory is the
same for all CPUs. However, Xen may allocate memory to a VM
from different NUMA nodes with different access speeds. This
difference can be amplified in workloads inside VM, causing
performance instability and timeouts. 

So in this patch series, we implement a set of NUMA API to use
device tree to describe the NUMA layout. We reuse most of the
code of x86 NUMA to create and maintain the mapping between
memory and CPU, create the matrix between any two NUMA nodes.
Except ACPI and some x86 specified code, we have moved other
code to common. In next stage, when we implement ACPI based
NUMA for Arm64, we may move the ACPI NUMA code to common too,
but in current stage, we keep it as x86 only.

This patch serires has been tested and booted well on one
Arm64 NUMA machine and one HPE x86 NUMA machine.

---
Part1 v1->v2:
1. Move independent patches from later to early of this series.
2. Drop the copy of EFI stub.c from Arm. Share common codes of
   x86 EFI stub for Arm.
3. Use CONFIG_ARM_EFI to replace CONFIG_EFI and remove help text
   and make CONFIG_ARM_EFI invisible.
4. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid.
5. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86.
6. Extend the description of Arm's workaround for reserve DMA
   allocations to avoid the same discussion every time for
   arch_have_default_dmazone.
7. Update commit messages.

Wei Chen (10):
  xen/arm: Print a 64-bit number in hex from early uart
  xen/x86: move reusable EFI stub functions from x86 to common
  xen/arm: add CONFIG_ARM_EFI to stub EFI API
  xen/arm: Keep memory nodes in device tree when Xen boots from EFI
  xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid
  xen: introduce an arch helper for default dma zone status
  xen: decouple NUMA from ACPI in Kconfig
  xen/arm: use !CONFIG_NUMA to keep fake NUMA API
  xen/x86: use paddr_t for addresses in NUMA node structure
  xen/x86: add detection of memory interleaves for different nodes

PART2:
  xen/x86: introduce a helper to update memory hotplug end
  xen/x86: Use enumerations to indicate NUMA status
  xen/x86: move generically usable NUMA code from x86 to common
  xen/x86: use arch_get_memory_map to get information from E820 map
  xen/x86: move NUMA scan nodes codes from x86 to common
  xen/x86: rename bad_srat to numa_bad

PART3:
  xen: rename acpi_scan_nodes to numa_scan_nodes
  xen: introduce a Kconfig option to configure NUMA nodes number
  xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKS
  xen/arm: implement helpers to get and update NUMA status
  xen/arm: implement node distance helpers for Arm
  xen/arm: use arch_get_memory_map to memory bank from bootinfo
  xen/arm: build NUMA cpu_to_node map in dt_smp_init_cpus
  xen/arm: Add boot and secondary CPU to NUMA system
  xen/arm: stub mem_hotplug_update_boundary for Arm
  xen/arm: introduce a helper to parse device tree processor node
  xen/arm: introduce a helper to parse device tree memory node
  xen/arm: introduce a helper to parse device tree NUMA distance map
  xen/arm: unified entry to parse all NUMA data from device tree
  xen/arm: keep guest still be NUMA unware
  xen/arm: enable device tree based NUMA in system init
  xen/arm: implement a dummy 1:1 node to pxm mapping
  xen/arm: use CONFIG_NUMA to gate node_online_map in smpboot
  xen/arm: Provide Kconfig options for Arm to enable NUMA
  docs: update numa command line to support Arm

 xen/arch/arm/Kconfig                    |  5 ++
 xen/arch/arm/Makefile                   |  2 +-
 xen/arch/arm/arm64/head.S               | 12 ++--
 xen/arch/arm/bootfdt.c                  |  8 ++-
 xen/arch/arm/efi/Makefile               |  5 ++
 xen/arch/arm/efi/efi-boot.h             | 25 ---------
 xen/arch/arm/include/asm/numa.h         |  6 ++
 xen/arch/x86/Kconfig                    |  2 +-
 xen/arch/x86/efi/Makefile               |  4 +-
 xen/arch/x86/efi/{stub.c => stub-x86.c} | 37 -------------
 xen/arch/x86/include/asm/config.h       |  1 -
 xen/arch/x86/include/asm/numa.h         | 15 ++---
 xen/arch/x86/numa.c                     | 30 +++++-----
 xen/arch/x86/srat.c                     | 74 +++++++++++++++++++------
 xen/common/Kconfig                      |  3 +
 xen/common/efi/stub.c                   | 38 +++++++++++++
 xen/common/page_alloc.c                 |  2 +-
 xen/drivers/acpi/Kconfig                |  3 +-
 xen/drivers/acpi/Makefile               |  2 +-
 xen/include/xen/numa.h                  |  2 +
 20 files changed, 162 insertions(+), 114 deletions(-)
 rename xen/arch/x86/efi/{stub.c => stub-x86.c} (71%)
 create mode 100644 xen/common/efi/stub.c

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:09:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:09:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307049.522312 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNNW-0007Ct-Ep; Mon, 18 Apr 2022 09:09:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307049.522312; Mon, 18 Apr 2022 09:09:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNNW-0007Cm-BB; Mon, 18 Apr 2022 09:09:02 +0000
Received: by outflank-mailman (input) for mailman id 307049;
 Mon, 18 Apr 2022 09:09:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNNV-0006ub-EY
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:01 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02on061e.outbound.protection.outlook.com
 [2a01:111:f400:fe06::61e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2f58788e-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:09:00 +0200 (CEST)
Received: from AS9PR04CA0057.eurprd04.prod.outlook.com (2603:10a6:20b:46a::17)
 by PAXPR08MB7089.eurprd08.prod.outlook.com (2603:10a6:102:200::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:08:58 +0000
Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46a:cafe::13) by AS9PR04CA0057.outlook.office365.com
 (2603:10a6:20b:46a::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:08:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:08:57 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Mon, 18 Apr 2022 09:08:56 +0000
Received: from e904b8361973.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 07049532-8FD6-4FEA-BCB0-EEAFAB37F2F0.1; 
 Mon, 18 Apr 2022 09:08:50 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e904b8361973.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:08:50 +0000
Received: from AS8PR04CA0148.eurprd04.prod.outlook.com (2603:10a6:20b:127::33)
 by AM5PR0801MB1972.eurprd08.prod.outlook.com (2603:10a6:203:4b::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Mon, 18 Apr
 2022 09:08:48 +0000
Received: from VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:127:cafe::78) by AS8PR04CA0148.outlook.office365.com
 (2603:10a6:20b:127::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:08:48 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT020.mail.protection.outlook.com (10.152.18.242) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:08:47 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:08:46 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Mon, 18
 Apr 2022 09:08:44 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:08:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f58788e-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FIw93tJ3H+SfJwxD5M/sOYcJYzkHITrNvMbzRUuV10w=;
 b=nI5PJ/2apY4zRDuBKuJiTRS5Dlnw6e7il1gzcfWEFnE6UKQ3a+Sjp3IqisvxYNr7Khog7PT/MD3h4tAR1qYjr8BIskaZiehm7FwOTKHa0ZIHatTVJsCSZ3phy7nOWf0+IqYJJBw3vn3S+V2FnpLoFH4aydCxW9JrzUiHIiNcNzI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2363d4b466de078c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RzoFdnGDJnskow1Ky3YI5yjPDXf7PkzJ4O7gUvM+/onqmxm5RX5xcNPsWjgu5faqpqM7WpWzcsaynu17lXIhnLZxWvKl2TdFJh9VTyNOtSZ5EfI2c4gu+3TTpyGUBnB4qWarQSyzlRP25MSCGFE6S5hYPomUONn0Y4e024X73zKl8U4tOLk42zir66tzIHg/K7jOHse8kfBzF9H/rKrnN6wcK9e7jf3p4x8fU5RLzm8ZxYOuAN10N8MvEDMg0Q1tpGnDoyaAKV/FqugJvMcqH8CfZytH0MLdIDxBeIflpMh1mSSokxCTpr/xbhEzjMB2SUYYRd0RhBDiDeeBQvJ1jQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FIw93tJ3H+SfJwxD5M/sOYcJYzkHITrNvMbzRUuV10w=;
 b=b9Hf+f/t5UF9Z1H4gBgpnLVEDhVPWfJtF7srDN659wSrn9bQ81QUbFfqUuTHgxfE7M+vBsCyr62ba/uyiis2xrEulLjbhGYOwt1FdfSmuP+xCbjiGiqFf+P9ac1riVKftkXo+Q0Opv7TdJdEa7Ho0wWK2rSWLujvGaLcnm5YXRKXEw2q8QfKi+ov0Tki5lKBmIe2sFerGcfHTl3g4hfVT7IoNjpt9csT6tZC8KL/a/bIZOKGHI9HAo2jMirSHJhE5VTeaXUhP1TbLeUFDvP4U5xwiKsburwUcaZMX6wq1fTmA4f9r3QXU8AU7BIHLqyS+0x+GBuKDbxhT+vcTvybgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FIw93tJ3H+SfJwxD5M/sOYcJYzkHITrNvMbzRUuV10w=;
 b=nI5PJ/2apY4zRDuBKuJiTRS5Dlnw6e7il1gzcfWEFnE6UKQ3a+Sjp3IqisvxYNr7Khog7PT/MD3h4tAR1qYjr8BIskaZiehm7FwOTKHa0ZIHatTVJsCSZ3phy7nOWf0+IqYJJBw3vn3S+V2FnpLoFH4aydCxW9JrzUiHIiNcNzI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v2 01/10] xen/arm: Print a 64-bit number in hex from early uart
Date: Mon, 18 Apr 2022 17:07:26 +0800
Message-ID: <20220418090735.3940393-2-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 212121c3-b22f-43b3-f3c6-08da211b11ee
X-MS-TrafficTypeDiagnostic:
	AM5PR0801MB1972:EE_|VE1EUR03FT045:EE_|PAXPR08MB7089:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB70893862D4D6823979D9CFCF9EF39@PAXPR08MB7089.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 JymwDniJCB3u+g3PmTSrn9f2tp4UHCiROgez7VHxj9XkAA2WRClZLTGZ6zxixnzVJDE2Rmpx+GXv/gjh8LmFMZLDPZhYdDg8O6JK0UFuSaP0XYHBLqVF7DqrWkZboaxY/LXC0rONRzafGyrk19LePpJQ0cwq0QnarEjXsfH6gEH2shsGva9wo2VkCVMk2tdlCBToTPBhUfSgN90khvuUcsJbh1IJT5H71qv4v0qtWHAFVbsbiqdqj3NtJYuG9daN6xyYAKHvNHatLMFhlOW+jhnE6UAveAFcY8lsQkr1ecgYka9NACJBDH3TVH2UhVgVK9ibK6lqDTRU4/Tic/MU1GPMpoxiqtca18kS9XLNAqCQpE/DwijLH8H/RnOeGpTAJ/R6ws1lZGv7RLH7oLsut1FKtYacLczzojyA4WH4EXrRhj9hLbBdvXIzxguXq1GDlgApjC319WCyHCXWCYtNV3Eu+CeGurRKvlmOgZIv8hE6qDa/ydeYFI5d6h1phFwUQVBp594u/4tHbLQMRpJwrc8LKo+ByoNNslO6NErbNTfk8fgDxJ6fvozuVojiWz3yMTuPSinyHhCElfWC0MwfLv+2tPqetlunObLlSEubDyFYZE3zXWnKfPzQaRiNXSPz/wZb0XoGSSHYEm0qrK46QMk1NilXEUmqq/DSE0aSqPFF4uYOzaFSQcRaKXA+xaM0U3yOQ3h934TmdLan5mPGUg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(356005)(8676002)(508600001)(4326008)(40460700003)(70586007)(44832011)(5660300002)(6666004)(81166007)(8936002)(2906002)(83380400001)(426003)(336012)(70206006)(26005)(7696005)(186003)(1076003)(110136005)(54906003)(86362001)(316002)(36756003)(47076005)(82310400005)(36860700001)(2616005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1972
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8acaf597-ff42-42ce-0ace-08da211b0c28
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mUEQJTf5bR60qaye7+ufanAlkWIyCjOHO/phoTSP+UiJjdG5FWeRmb3z7y6GVw3BKdnok/HBte/S/cPJZ+PwGPxNtkHdYyT6+DU7FPMavHWQNf1aCYHrXCfbLiyAPGQFunSFDV+JQdExhQ+01R+l6rj/IdwCxqX/TxD2vZVJHOIWGqyxrxOJLczlpDquBmg+XVODq87T8YG2JdlRQ8CSRdOdWxh4JYYvEFt+3QyB74wC9bIXrC7tm35xAO2lJony91JGBTwizKc5whodpxIB9ZCmMwVTNZUcoHvrYssZByuqnZeNjT9C/J/ivN/ZZ28gKrUYFZzbmRU+A2XajqHVqBYWeOh9KukdMHgRTvhmxOqrQVilXzKiFSpcyqPjRqQaPVFpAwiHLPfb0cEALuD52pLtnnNAPZhU1n4RCSsG6TQTviTu24fbIAllQAOMj8LBasVX13ygDdyEHmPdSJuMn6U8xBM4TthAsarSOv/kDeENDBS6ZHdsfC06jd2agnaBlc4Wfzm6LCXYtQmB726xD6NaiCCxqWKTB/LtO52tyXzny+HDmqjzDjmk+tIowiW0O80NqqHihrUchtNLvCmfvoeb6Ht2zR+ICjzEXb2L67LvIHPEiFA5ilzekVNdbI6isxmVlWVdrCadEwVV4UNwSfhs+hkibeAjnQre8z5UHC5qxAflfQcyfp4K4b/tmLCj
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(4326008)(40460700003)(70206006)(70586007)(36756003)(336012)(8936002)(5660300002)(508600001)(1076003)(2616005)(186003)(44832011)(426003)(86362001)(2906002)(8676002)(107886003)(81166007)(47076005)(36860700001)(110136005)(54906003)(316002)(82310400005)(450100002)(6666004)(26005)(7696005)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:08:57.3490
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 212121c3-b22f-43b3-f3c6-08da211b11ee
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7089

Current putn function that is using for early print
only can print low 32-bit of AArch64 register. This
will lose some important messages while debugging
with early console. For example:
(XEN) Bringing up CPU5
- CPU 0000000100000100 booting -
Will be truncated to
(XEN) Bringing up CPU5
- CPU 00000100 booting -

In this patch, we increased the print loops and shift
bits to make putn print 64-bit number.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/arm64/head.S | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index e62c48ec1c..2bb7906f69 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -866,17 +866,19 @@ puts:
         ret
 ENDPROC(puts)
 
-/* Print a 32-bit number in hex.  Specific to the PL011 UART.
+/*
+ * Print a 64-bit number in hex.
  * x0: Number to print.
  * x23: Early UART base address
- * Clobbers x0-x3 */
+ * Clobbers x0-x3
+ */
 putn:
         adr   x1, hex
-        mov   x3, #8
+        mov   x3, #16
 1:
         early_uart_ready x23, 2
-        and   x2, x0, #0xf0000000    /* Mask off the top nybble */
-        lsr   x2, x2, #28
+        and   x2, x0, #(0xf<<60)     /* Mask off the top nybble */
+        lsr   x2, x2, #60
         ldrb  w2, [x1, x2]           /* Convert to a char */
         early_uart_transmit x23, w2
         lsl   x0, x0, #4             /* Roll it through one nybble at a time */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:09:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:09:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307055.522323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNNo-0007pR-Vs; Mon, 18 Apr 2022 09:09:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307055.522323; Mon, 18 Apr 2022 09:09:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNNo-0007pK-QE; Mon, 18 Apr 2022 09:09:20 +0000
Received: by outflank-mailman (input) for mailman id 307055;
 Mon, 18 Apr 2022 09:09:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNNn-0006ub-1b
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:19 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0618.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::618])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 39d4040b-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:09:18 +0200 (CEST)
Received: from DU2PR04CA0294.eurprd04.prod.outlook.com (2603:10a6:10:28c::29)
 by DB7PR08MB3161.eurprd08.prod.outlook.com (2603:10a6:5:1d::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Mon, 18 Apr
 2022 09:09:15 +0000
Received: from DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28c:cafe::d2) by DU2PR04CA0294.outlook.office365.com
 (2603:10a6:10:28c::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT037.mail.protection.outlook.com (10.152.20.215) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:15 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Mon, 18 Apr 2022 09:09:15 +0000
Received: from 9d98b1640673.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BB27E34A-68A8-4D6E-A93F-CB124D85EABE.1; 
 Mon, 18 Apr 2022 09:09:08 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9d98b1640673.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:08 +0000
Received: from AS9PR06CA0202.eurprd06.prod.outlook.com (2603:10a6:20b:45d::32)
 by AM0PR08MB4593.eurprd08.prod.outlook.com (2603:10a6:208:fd::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:07 +0000
Received: from VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45d:cafe::d6) by AS9PR06CA0202.outlook.office365.com
 (2603:10a6:20b:45d::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:07 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT050.mail.protection.outlook.com (10.152.19.209) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:06 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:05 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39d4040b-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tvRkI0wVuOuaZghSz7/nXNikDcYdh4Q7PzQrJ96r9QA=;
 b=YUDKS71MikoJvX65ifqmPpod0KGHhhnq+pzS0w4Rou/tRPHHvB0BhqcCJkvHJiKwFYzS65TqaAbYxiL4YyCwfju+9FM3pgGFWFpzSdd0PuuAPOyhg1XaxON3/J41yMX+3jF06ufHgRqdVqETjerWiSuPubJ7M8gQ5A6x9UgLb/E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8506ce5e04c293cb
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oPwufD1BqEtiZBCWKPIhWFqRtCR90lYDMkv5Q7vm9rtS8ZOHru/opEfuIBBUlT4KwvLuFtPLBLY+eW0dAHc8HFB7pyEeQujC9B/91CDvdGeKcK9wmSlCf+6QKtGoU4xBHdTqFXIrhAakkezVr68AqiBEjZJFiEZvmpFiY8bOEW+OrzU9kjVB/3hZAHx4jAKE45km6Ly3ZzIneNQPnvSGHn3hmnAZdJIqErLzlRi8sUFX1AJbO3/7Daebwg/0g5Mdijc6b/H2Bk+rkV8Ca/3ZaOralIMneOen6n91rHJ1gC8Z9QGCvBDg5ZsyBrA5c7erNIkLWB5LTicVaxKjZAzG8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tvRkI0wVuOuaZghSz7/nXNikDcYdh4Q7PzQrJ96r9QA=;
 b=cppydxpY1baLhGESuagiuW5xVhmC++ewa3Xy5fV2ZJjxIXDg7C7qvQR2EBz/7KnzDG3o3sj6rgQncrjqWCB/io7IDkjAlK3gjNxajfb/ARX/gyRPEJ5KXGAf4MiKEDR3E0escmYpB1C8LB1UijEfbweESIjy+XxEiQdKp3yDQbUZiWWbxmSrTSXNxf2q1GTjh4WhJx9pRC1/zO1ZeWADoFlmHiwaBAQVyBBWEweXDOHkF1bHulZkhXRSPrENhibRzBv9+ThqUGxrgmO0m8FuG++2cIKic++PlAT3kJGctMZ8cie4fA7+exh7jHBZD69VA1nLMkCKxSyz2z/ImvqQlw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tvRkI0wVuOuaZghSz7/nXNikDcYdh4Q7PzQrJ96r9QA=;
 b=YUDKS71MikoJvX65ifqmPpod0KGHhhnq+pzS0w4Rou/tRPHHvB0BhqcCJkvHJiKwFYzS65TqaAbYxiL4YyCwfju+9FM3pgGFWFpzSdd0PuuAPOyhg1XaxON3/J41yMX+3jF06ufHgRqdVqETjerWiSuPubJ7M8gQ5A6x9UgLb/E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 03/10] xen/arm: add CONFIG_ARM_EFI to stub EFI API
Date: Mon, 18 Apr 2022 17:07:28 +0800
Message-ID: <20220418090735.3940393-4-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: f44a135a-5445-481a-9760-08da211b1c7a
X-MS-TrafficTypeDiagnostic:
	AM0PR08MB4593:EE_|DB5EUR03FT037:EE_|DB7PR08MB3161:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB31615CE20A8BC5F7F63806299EF39@DB7PR08MB3161.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 dOXIfggwWPsp+6c2RVO80rNMNXkx9IgEIySwNoUJbD4Dqkpy/O+17fQDzLLTyAOOjO3+pZg44A8BYDfz2Hx4rxY3pjeP4WLGhkM209w6l1kvSAJxuws8HllNt2HSN12pSXS2t2bxP6E+ofPOnCJNo0+fzfT3kWPgW/nXSGgwAm+IjAzTwFx66SmXq6G631HG2Xu4OosYrSLEjugykXSV7UUAgUBaDD/gi0dWhvh6GhMv9pYu4nkX07gmPWkQvflRTVEXz55li/dBPKdYFnZjMX+7aUBuN8qWAcNEpumqyW1IIWLgwndg85EgquTQKZaWFxI9I4xiwH9VK+y3XwnSnK7uCjoMHhUGYkmUYUL86hf/2JDay6fRqaXswk8duuAlU+DM6ukk878WnLN5Hz6zFlL+fU4XdP9kiQBUB8VC/SlECGET87n9W5vevHaTLfqow9nA6AOA7937iRNwslOUKbvjxUNDDWZN++E0hcEspa5goAtnAtF7NCVoYy2h2nXVBDiEU1+G4C+tsRgOe6L1fZpGfh3byq+kgr/XsEszUxGvLa9ZWwMMYacS9cJPqvqXfWm1W5gw9t9KvKQQa4tdnuhDk6ijYRf+w/wREyPBLfL0Qw/9TM7Kr1YOmCSNaBtUpKxA+BkHw9kuUtP4XVqzOnWDLDk0AzWKH96yeBzeRs/Jdomi5Gm0WP9jOoDl2wVDufSb6rLr3kjHRdgrmwCpjA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(426003)(4326008)(44832011)(47076005)(508600001)(70206006)(2616005)(8676002)(6666004)(336012)(81166007)(26005)(8936002)(83380400001)(186003)(5660300002)(2906002)(316002)(356005)(1076003)(70586007)(36860700001)(110136005)(54906003)(7696005)(40460700003)(36756003)(86362001)(82310400005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4593
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b375e3d7-1360-4db0-74a6-08da211b178b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pVq2uErkLBaSvoQ/RcIr2zTkF5GT/Kvp00oLPu5F37/53IjsfW2SRebGNC+k2SruUiBdryCvyNFEKma94HJ5C67OkJpowRcYme/la2Elb15W0VW8e+Smht4H8+SEF9gHB30J5dajpzut08db+x8XWtIKqVmvbImLRSmuMaOZZ30vGRr2KOphLGLbrxJOg73nWfVMImXTsB8luNJxEkgrkzKq/A7jNrhb/GqIXxOl+CAZTupmycD1+3M8SDshD7uI/sAv7Q+yUdBvoUa7j5zX+NyXOzCr/akNf/1VnK9UP7ZAD5rbs1GFcaD7jmiAQBt0o+Wg44+BiacbH1s9A9hWuj4bGFmIRckexgwElPwn32M2l2urHQF8TWMLm+uHESVoQegIZ8vGT1HalwLM5dwdT64ITr6x4nxlwdLRJU1Hb+TVhLL0SYOAvYunBuDnDUEfbFOYh36YutthvgwTdB2Wd+dPHQG12mG+WzH4Mdf2KI0kEfeXS0vFUIUEftwwUumaO+ozgg7uGs+NA7Hmacd8353yAb8bqTptg98lhO+v+yVbDtqDNgNubmsx1Q03HrchHqel1zK5dtlIQ+bB0N11OUEcTkWfOVPO2bAgykz2zVYrLitP1U9yuK++lhu/B/q5RWdOwlfG2qzAbwrxWEs+sw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(2906002)(508600001)(36860700001)(54906003)(450100002)(81166007)(44832011)(8676002)(4326008)(70206006)(70586007)(86362001)(110136005)(316002)(83380400001)(5660300002)(8936002)(2616005)(107886003)(36756003)(336012)(1076003)(7696005)(186003)(47076005)(426003)(26005)(82310400005)(6666004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:09:15.1820
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f44a135a-5445-481a-9760-08da211b1c7a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3161

x86 is using compiler feature testing to decide EFI
build enable or not. When EFI build is disabled, x86
will use a efi/stub.c file to replace efi/runtime.c
for build objects. Following this idea, we introduce
a stub file for Arm, but use CONFIG_ARM_EFI to decide
EFI build enable or not.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v1 -> v2:
1. Use CONFIG_ARM_EFI to replace CONFIG_EFI
2. Remove help text and make CONFIG_ARM_EFI invisible.
3. Merge one following patch:
   xen/arm: introduce a stub file for non-EFI architectures
4. Use the common stub.c instead of creating new one.
---
 xen/arch/arm/Kconfig      | 5 +++++
 xen/arch/arm/Makefile     | 2 +-
 xen/arch/arm/efi/Makefile | 5 +++++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4..5f1b0121b0 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -6,6 +6,7 @@ config ARM_64
 	def_bool y
 	depends on !ARM_32
 	select 64BIT
+	select ARM_EFI
 	select HAS_FAST_MULTIPLY
 
 config ARM
@@ -33,6 +34,10 @@ config ACPI
 	  Advanced Configuration and Power Interface (ACPI) support for Xen is
 	  an alternative to device tree on ARM64.
 
+config ARM_EFI
+	bool
+	depends on ARM_64
+
 config GICV3
 	bool "GICv3 driver"
 	depends on ARM_64 && !NEW_VGIC
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 1d862351d1..bb7a6151c1 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -1,6 +1,5 @@
 obj-$(CONFIG_ARM_32) += arm32/
 obj-$(CONFIG_ARM_64) += arm64/
-obj-$(CONFIG_ARM_64) += efi/
 obj-$(CONFIG_ACPI) += acpi/
 obj-$(CONFIG_HAS_PCI) += pci/
 ifneq ($(CONFIG_NO_PLAT),y)
@@ -20,6 +19,7 @@ obj-y += domain.o
 obj-y += domain_build.init.o
 obj-y += domctl.o
 obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
+obj-y += efi/
 obj-y += gic.o
 obj-y += gic-v2.o
 obj-$(CONFIG_GICV3) += gic-v3.o
diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile
index 4313c39066..75ef180233 100644
--- a/xen/arch/arm/efi/Makefile
+++ b/xen/arch/arm/efi/Makefile
@@ -1,4 +1,9 @@
 include $(srctree)/common/efi/efi-common.mk
 
+ifeq ($(CONFIG_ARM_EFI),y)
 obj-y += $(EFIOBJ-y)
 obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
+else
+EFIOBJ-y += stub.o
+obj-y += stub.o
+endif
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:09:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:09:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307056.522329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNNp-0007tL-E2; Mon, 18 Apr 2022 09:09:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307056.522329; Mon, 18 Apr 2022 09:09:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNNp-0007rX-3o; Mon, 18 Apr 2022 09:09:21 +0000
Received: by outflank-mailman (input) for mailman id 307056;
 Mon, 18 Apr 2022 09:09:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNNn-0007Zt-IQ
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:19 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2060d.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::60d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 397f129c-bef7-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 11:09:18 +0200 (CEST)
Received: from AS9PR06CA0314.eurprd06.prod.outlook.com (2603:10a6:20b:45b::16)
 by GV2PR08MB8027.eurprd08.prod.outlook.com (2603:10a6:150:77::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.29; Mon, 18 Apr
 2022 09:09:14 +0000
Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45b:cafe::e7) by AS9PR06CA0314.outlook.office365.com
 (2603:10a6:20b:45b::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:14 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:14 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Mon, 18 Apr 2022 09:09:13 +0000
Received: from 34f05a90a264.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 517773D1-31C0-4A4B-BE16-A9622B197C53.1; 
 Mon, 18 Apr 2022 09:09:07 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 34f05a90a264.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:07 +0000
Received: from AS9PR04CA0099.eurprd04.prod.outlook.com (2603:10a6:20b:50e::22)
 by AM6PR08MB3768.eurprd08.prod.outlook.com (2603:10a6:20b:90::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:05 +0000
Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:50e:cafe::cd) by AS9PR04CA0099.outlook.office365.com
 (2603:10a6:20b:50e::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:05 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:04 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:02 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 397f129c-bef7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hKhGWgAz7VOd0X/bf4Vgu84CVR+pM2MueQtIIaIgjYw=;
 b=em5bSzYnov4JJhMJs5UnjOdhKnbfxDzdIgrxZXCiWpmzYDdl7L/RFfARfUH7AL/ZVZPLCGzpuZU8DFXrYwTKBncDdRMRCBkfKmPGDg17jrRoo5Lx5c0F+YC9xaSV4QOWUGAecgtRR/fU1FhYdUoQh2aPhEojNgskWFRxZ6MBKsk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9baa8cfa302fb627
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F9NxgDoGs2mP7ZgvvucXHIcAPQEgCXPKG/YM8/BIKG+9IPokoUmiemn2k083mD7+frthxfecocMB79REkFVY/7CcubbEGjXdgkZc5HjINpaC05//m14ZtWeMjscG7hPAwaPDcgrfmiXdWnp/J/jkqpXFGJT8WY/mene+eY+EdKvyDB9eBZMVpIqeRRFxfzim3nyzYxqqxSWeFXxTUQb9DNHE9ILWUkkBT3xTajhvetZunzFWSzM7IFSuX3075QPedjv49o9HUCWB3wQpZgF81B1ZU18Mpex4fk6YAwESWDkHYp94MY1SMdnS7BxjHC4lrb4Ahkgbyc5KB1ZsUZAV6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hKhGWgAz7VOd0X/bf4Vgu84CVR+pM2MueQtIIaIgjYw=;
 b=CYY9zLdZsWsiDOJG9eQzaAgmz2LqX+pvY0lvgJ/7hbS/FHEl0eYNqJNK25ElATPA2+SGC9JD4AXx2SUhU0foxh+kWaHe/BsfunLLb5CgazCQqmt/s5nK3XwRFJE2MXSSyadiRJDaYie9gysiVGQztYPTnHJZ9azRK1akpOnVPXbWYJcajFfkU29bfFNTPSVeFGmVbQg24XGPP7+BSi7/xqpAzgyTaDEVdB9sCHbpGdYogYnA5aJByCNChq7QS8DerKEcfvcNj9ML9GVmt6yYMUBbuk9BHJSszR2xjwhPBefoIvYrummHCTDj5hmmTPF3S376YOHvGzr7IjsXhLgYdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hKhGWgAz7VOd0X/bf4Vgu84CVR+pM2MueQtIIaIgjYw=;
 b=em5bSzYnov4JJhMJs5UnjOdhKnbfxDzdIgrxZXCiWpmzYDdl7L/RFfARfUH7AL/ZVZPLCGzpuZU8DFXrYwTKBncDdRMRCBkfKmPGDg17jrRoo5Lx5c0F+YC9xaSV4QOWUGAecgtRR/fU1FhYdUoQh2aPhEojNgskWFRxZ6MBKsk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from x86 to common
Date: Mon, 18 Apr 2022 17:07:27 +0800
Message-ID: <20220418090735.3940393-3-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 3bb0308f-f56b-40dc-a080-08da211b1bf6
X-MS-TrafficTypeDiagnostic:
	AM6PR08MB3768:EE_|VE1EUR03FT037:EE_|GV2PR08MB8027:EE_
X-Microsoft-Antispam-PRVS:
	<GV2PR08MB80273CA3D0DEA2745B4D6E9B9EF39@GV2PR08MB8027.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 nPhU5GAwzl4cbqeWymZlcWm9ejTGEJ8V56FpA0XINtwGGCHrXAL+PbqIrcTu9CWrAJaZW5aU7ZFcUljnebPAE4PjMEYtDHoB3YHMY/lnMbxcBfHj9wdraJP0m+Qq/5JNmw9q8UezFwDX0o2ucD1bnRg2MkpEXeytqrx4s8lfdUQZEsmXUICwR/veaR0eQqOUj3R0IPM/KvFSXc+xTV8sg9ORUMzp8mEWU6+565d0Gy3sKGb+kH4fLWYkVAOZ0HLS9DCDTEcHloDoXCMpLfQlf8vlmZf3kdqb4/rXUVtcAyJjjPXoBtTXFCMqB+7lYXbb0j6lnVEM8kpfBDhkr1FntN87NzZalQl1pSDQCzdkf1A9qfCOifs/T2LiT8awt5xuiwpZRoKlABXNB+KlON+OkAqzu8+2JW/+C88gG6J8M+dGplROF5fsygLoHNZ8MBY3j6jL675kIutuj9+2M4UxJTox6lLudFTuoU9Bt/iSF5n7yM+Ky2jTkTCUHlEsab9iD0pyL3jRhb8uT3wnoA+TXSmX4pu2MmrmrfzmCkf3TzHN5tadiZ2aejQrLMA63lvp7wqcq3COxl2YMLM4OUFDUC1Lb54WCmeCcq5tl4krBAs/ikfH/ykMAiknLIThYg8X9UgZnj2ocvqRwaaFT18IMszNr3LDPTuiwi+70V4T30u2lxrIETZ4qfimpchSjQ7arEm/xJftuKNA+oYIbU+XsQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(83380400001)(2906002)(40460700003)(70586007)(70206006)(44832011)(4326008)(8676002)(26005)(5660300002)(186003)(1076003)(86362001)(6666004)(8936002)(2616005)(7696005)(47076005)(356005)(508600001)(336012)(36756003)(82310400005)(36860700001)(426003)(54906003)(316002)(110136005)(81166007)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3768
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0f4cbbba-1f71-490f-c943-08da211b163c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JbkXeTDt1x5JrTLySBhvZ5V7uZQE1YZnMnCLNy1uyC8+DddhDEF/nLr+cbsPEwu/K8ngd/bsGWNDGN0W4KOAQBC0Mg5zJKCtsP1+4tudkoWcSCLIwy7g0pGyW6xUrum49yYoZ5TFd8m7NjvWjkfFpOWTBZC8DqV1wvfR/FnCYrI/uc05ZT9dEmGuNgOxT3u46rDYF4StJi2hVAN5JgsGzLhF2UasX5vPXwXJLtpZnZSlZf7IikRXo7PGwUpTpJ33E34pJMqMw96sLFnI2YJODycjRjDKqA2xGheruOz6wsANx776bmLbmBjvJqdktNdv14ascrCtTEhmmatpCaf2nhkPrk2iEmZsvnnt0Arh/0Qhe1QSS28xhXYqcl0OM3Ux3RFtjoXKj9UA+7xQg6PlRbJKZhFseLi3x9jbeXTBE8R5f5OLocU9UMa2Lqv1t0eNsY9Mt3U4y7NYwNd6Bm2kWLoEa98Ijnu7gpkVRgB4DSbOnyDWF4cq4o4DwSzB9I04BeKDxSzyIzp4wJR3ucz7n2C0/WTD3SDO1KedPZHEa9AdkThBHwKIq6LZxs3vu1S9/93YmqD2g3Yl6PVda1DUcDABNQCCfEl5VEyEyxc62PmXsy8NptRfvyR/emePBbIKT4tRU3L/0WjHbS4oU7YN0j7Oo0X/tEm1QGRm/NVQJ+XWL7fOtFq7Q+qnRh1qoxGq
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(36756003)(40460700003)(26005)(86362001)(110136005)(2616005)(81166007)(36860700001)(186003)(7696005)(6666004)(336012)(5660300002)(44832011)(8936002)(508600001)(426003)(83380400001)(70586007)(450100002)(82310400005)(1076003)(2906002)(54906003)(4326008)(316002)(70206006)(8676002)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:09:14.1921
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bb0308f-f56b-40dc-a080-08da211b1bf6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8027

Most of the functions in x86 EFI stub.c can be reused for other
architectures. So we move them to common and keep the x86 specific
function in stub-x86.c.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v1 -> v2:
1. Drop the copy of stub.c from Arm EFI.
2. Share common codes of x86 EFI stub for other architectures.
---
 xen/arch/x86/efi/Makefile               |  4 +--
 xen/arch/x86/efi/{stub.c => stub-x86.c} | 37 ------------------------
 xen/common/efi/stub.c                   | 38 +++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 39 deletions(-)
 rename xen/arch/x86/efi/{stub.c => stub-x86.c} (71%)
 create mode 100644 xen/common/efi/stub.c

diff --git a/xen/arch/x86/efi/Makefile b/xen/arch/x86/efi/Makefile
index 034ec87895..5ca3a0b4a4 100644
--- a/xen/arch/x86/efi/Makefile
+++ b/xen/arch/x86/efi/Makefile
@@ -11,8 +11,8 @@ $(obj)/boot.init.o: $(obj)/buildid.o
 $(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary=4)
 $(addprefix $(obj)/,$(EFIOBJ-y)): CFLAGS_stack_boundary := $(cflags-stack-boundary)
 
-obj-y := stub.o
+obj-y := stub.o stub-x86.o
 obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y))
 obj-bin-$(XEN_BUILD_EFI) := $(filter %.init.o,$(EFIOBJ-y))
 extra-$(XEN_BUILD_EFI) += buildid.o relocs-dummy.o
-nocov-$(XEN_BUILD_EFI) += stub.o
+nocov-$(XEN_BUILD_EFI) += stub.o stub-x86.o
diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub-x86.c
similarity index 71%
rename from xen/arch/x86/efi/stub.c
rename to xen/arch/x86/efi/stub-x86.c
index 9984932626..2cd5c8d4dc 100644
--- a/xen/arch/x86/efi/stub.c
+++ b/xen/arch/x86/efi/stub-x86.c
@@ -1,7 +1,5 @@
 #include <xen/efi.h>
-#include <xen/errno.h>
 #include <xen/init.h>
-#include <xen/lib.h>
 #include <asm/asm_defns.h>
 #include <asm/efibind.h>
 #include <asm/page.h>
@@ -45,11 +43,6 @@ void __init noreturn efi_multiboot2(EFI_HANDLE ImageHandle,
     unreachable();
 }
 
-bool efi_enabled(unsigned int feature)
-{
-    return false;
-}
-
 void __init efi_init_memory(void) { }
 
 bool efi_boot_mem_unused(unsigned long *start, unsigned long *end)
@@ -61,33 +54,3 @@ bool efi_boot_mem_unused(unsigned long *start, unsigned long *end)
 }
 
 void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t l4e) { }
-
-bool efi_rs_using_pgtables(void)
-{
-    return false;
-}
-
-unsigned long efi_get_time(void)
-{
-    BUG();
-    return 0;
-}
-
-void efi_halt_system(void) { }
-void efi_reset_system(bool warm) { }
-
-int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
-{
-    return -ENOSYS;
-}
-
-int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *)
-    __attribute__((__alias__("efi_get_info")));
-
-int efi_runtime_call(struct xenpf_efi_runtime_call *op)
-{
-    return -ENOSYS;
-}
-
-int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *)
-    __attribute__((__alias__("efi_runtime_call")));
diff --git a/xen/common/efi/stub.c b/xen/common/efi/stub.c
new file mode 100644
index 0000000000..6e4f4de9af
--- /dev/null
+++ b/xen/common/efi/stub.c
@@ -0,0 +1,38 @@
+#include <xen/efi.h>
+#include <xen/errno.h>
+#include <xen/lib.h>
+
+bool efi_enabled(unsigned int feature)
+{
+    return false;
+}
+
+bool efi_rs_using_pgtables(void)
+{
+    return false;
+}
+
+unsigned long efi_get_time(void)
+{
+    BUG();
+    return 0;
+}
+
+void efi_halt_system(void) { }
+void efi_reset_system(bool warm) { }
+
+int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
+{
+    return -ENOSYS;
+}
+
+int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *)
+    __attribute__((__alias__("efi_get_info")));
+
+int efi_runtime_call(struct xenpf_efi_runtime_call *op)
+{
+    return -ENOSYS;
+}
+
+int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *)
+    __attribute__((__alias__("efi_runtime_call")));
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:09:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:09:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307062.522345 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNO1-0000Fq-JB; Mon, 18 Apr 2022 09:09:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307062.522345; Mon, 18 Apr 2022 09:09:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNO1-0000Ff-Fw; Mon, 18 Apr 2022 09:09:33 +0000
Received: by outflank-mailman (input) for mailman id 307062;
 Mon, 18 Apr 2022 09:09:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNNz-0006ub-Mg
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:31 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20626.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::626])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4158a990-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:09:30 +0200 (CEST)
Received: from DB9PR02CA0004.eurprd02.prod.outlook.com (2603:10a6:10:1d9::9)
 by AM6PR08MB3016.eurprd08.prod.outlook.com (2603:10a6:209:44::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:27 +0000
Received: from DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d9:cafe::ac) by DB9PR02CA0004.outlook.office365.com
 (2603:10a6:10:1d9::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT043.mail.protection.outlook.com (10.152.20.236) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:27 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Mon, 18 Apr 2022 09:09:27 +0000
Received: from e5a766ff2263.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5E91799F-258E-49D9-A7AF-0C51ED3A79AF.1; 
 Mon, 18 Apr 2022 09:09:21 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e5a766ff2263.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:21 +0000
Received: from AM6PR0502CA0058.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::35) by PR3PR08MB5867.eurprd08.prod.outlook.com
 (2603:10a6:102:87::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:19 +0000
Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::e) by AM6PR0502CA0058.outlook.office365.com
 (2603:10a6:20b:56::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.21 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:18 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:18 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:15 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4158a990-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7upcQINO9FI5IlOhkk4nMfwI1rBCpr+XywVNSPgYPn8=;
 b=PIM8W0tLp9LpyVtpY0MQOwvdwEv7drh56TbvkwFuYs8nqi6VxplHfstgEaDA2var/kCF7COufc9CLilQ51SITm4drV/fpgTLwYkQQAMg5Qvbh/jshqss8N8iPXOaL55bPIAbhkfIYT1ZSKU03FRj1KnUP0sjK3UEgXCxrDjzoNk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b47319d808b60900
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W/waVCtOtUlgsNeY60R1HtvU2s+XbInCZMbzhOgNGN8RTUBoUChExhGoUOCqviiXsVLw8GDEZTf/XcCUSqJd7hvOagX7pROMs6SaL5EilFu3jMHdEYOxDNrxiJmqlI0oaUhrJGWCdmIrljIhiHo7JXYvlCi7hn5DWaO5Vz8ekN1fSnscW0rsIImeuwJUlWxUpxtTvv0laPi0OSL3NIDfesYbp8jEiefXSqK+02+uVDIg7QZgFY68YFAJbw/ucpp+nmUVOhuhpQ4xhtlz2Qz+BgCWnbGlVx8KzjeM83DcYTPX+bdCt/Su3cHrtgGq6nTG4Rufz/2ZWszghx2CLUxcDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7upcQINO9FI5IlOhkk4nMfwI1rBCpr+XywVNSPgYPn8=;
 b=i8I/WeOTBLWOe2Zk5wdWS7jNQhMaHBtCAyXVa/V01hOt3KedOJrNQ3Ey7ro0M2ZymrkjK/H6vgSfPdGyOyk3Wayd91byreeyyWrIN4PMWz/UzRv2zfqS5HkeDxnK5cHWpUWL/hAURNLdw26Jb8IPuigOY4Io+sy435rIXlQPt41e4rytwuIbuXG0iNsibOmVRZXxt9V6U02RWonYdNl+72pTbZXBSS1LjgrZzDQ6aFVO1D7iWEsdNRu/QNDwf8aBkrW/CwO0fmPTGZ0JMjXYPShVltsbVYJU3NIZcwb5xoqBz72vgP5WTD3J1O27d7qOElYWksCjB0UumxfAuY5saQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7upcQINO9FI5IlOhkk4nMfwI1rBCpr+XywVNSPgYPn8=;
 b=PIM8W0tLp9LpyVtpY0MQOwvdwEv7drh56TbvkwFuYs8nqi6VxplHfstgEaDA2var/kCF7COufc9CLilQ51SITm4drV/fpgTLwYkQQAMg5Qvbh/jshqss8N8iPXOaL55bPIAbhkfIYT1ZSKU03FRj1KnUP0sjK3UEgXCxrDjzoNk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v2 06/10] xen: introduce an arch helper for default dma zone status
Date: Mon, 18 Apr 2022 17:07:31 +0800
Message-ID: <20220418090735.3940393-7-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 33871645-af97-441c-446a-08da211b23b3
X-MS-TrafficTypeDiagnostic:
	PR3PR08MB5867:EE_|DB5EUR03FT043:EE_|AM6PR08MB3016:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB3016F7CB6F4A528DDB5E3BBC9EF39@AM6PR08MB3016.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 u2ou5bKMLU+wCecp/60EdU9X2Sc35AAL11VfPoZDhUfTeC+KgweShRK7lt3mMiwJJXRYxTVFvNkMtmtKO+pr307wYvcLYnnmknUeKHd9oodcK2uEJGAJn9uyPOT74tuz6ZS3j5IJX4YfdgCu8n8sAxFZ2XfAlWD+mLEwH4Mr+XZkPuzvBP4Ucpp75pDpwgyO8nbSyjCCfKA0cAj+WBw4lq6QDif6fke8nSNdhpZ6O6WPwiiZZTxfD2g4QPmnwVJZFeQeGuOSS7Xkiu/DNaOQPV+RuowTGk33Kw7p24axDddBEFwRjzBUNukj6KO/MXiodi2a75hFzAEDjtHQ02kh83cS7KacB59ne2BHy9kKdO1NCDTMq+PvlIpPKmwxeo6qkiISt442E8XUGDYvZqy+Q08SJDJ/tQJoy5zFQzPWRlMBIIkfPWyO+6qGA3pnC2fVg5Sw5HD9QqKJ/RcKiIB/cT+PDmlLVbGNzph+D0KNCQqu6KS9VDYbFF+b58ke9Kf73/cXfD185ympTsW3jD7ZcuExfqMQMX77uKxLCciSpeL899aKtA3kd3GVYUKt9Kk90V3tM2jgn3esdlYT9BcrrjKeegzU2zTOVauSxzLjxB6VyCLYYrydlgycMFfUZU9E0DSHMQgs+BPyOnV/9bl6WsVaa31WFzqBgIkdjY+ANBDVfEp4lDdqI+QVnqWXBWCADqP+2hbftjRIrDrApvuqcg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(81166007)(356005)(7696005)(86362001)(426003)(2616005)(1076003)(6666004)(47076005)(336012)(186003)(8936002)(4326008)(8676002)(36860700001)(26005)(83380400001)(44832011)(7416002)(70206006)(70586007)(5660300002)(36756003)(82310400005)(2906002)(110136005)(54906003)(316002)(40460700003)(508600001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5867
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5f895dc0-e219-4c8f-c810-08da211b1eaa
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dHgqf7KBYEt5JNj8G/kREUDoEGqf9/XCzpQbEhsio9Vxvw/bi2NeRPPyc9L7cJ4Rzb23haAUWWV88AyQONxEDLEVvniHtx5CiRvd7dXBBF6l5sasMjdgN4dQDScJ66wbMZY5JhDZO5s2mOtYN7aw2Pol+HLa6jUL8/J22J/7Axer899nKegkxRMaaD4CZbr+b2bJ5SStk4ueP7n3+FU1KQEHHWAym49Jra0mq4TlW/Fd3bPe1hmJjge2Jzpb1WrYX8YIDkq+tV/qEOX7YKNnEYKUZJEI6xLNcvn+RrObYYLSkWeUMsrT1sGTk+0dpMAi9wjqKFKueEdzu8VP1Nod0kucNIY7eXl7+aVwX5WadnQHQa67qomnscLxKlSSiSVnWBpCmhReY+6PIMRVs5g1Ua+lF+/nsf0igC6SBWIxqumPMde1ZQIBPH4k0y2TvuxVOJ01ywBnY4/YhCAVuqqP+8MeUMctQ2/olhwiyRNIZEOr5+aePnF1PXzCYI9vYlqUB/OVVwF6T0CymlErZv/USN8LsX/VKPvQqearozFUwnxDy7o2rgcGo5hvMQkEHvQyFJSPrTSPANNGIonM36sfHXzQXFcWN95j7LBrRalVWy7Ps73sd/o1lXqa4rrLSURtadeBDMWjAzW8px61CJZ3JCa1b6sVawF6BG9QJJBLRLoMCm8M3s1ikd1x2lDiD6Tq
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(186003)(7696005)(336012)(426003)(5660300002)(44832011)(47076005)(2906002)(508600001)(86362001)(107886003)(1076003)(2616005)(26005)(8936002)(316002)(82310400005)(6666004)(81166007)(54906003)(110136005)(8676002)(450100002)(4326008)(70206006)(70586007)(40460700003)(83380400001)(36756003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:09:27.2974
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 33871645-af97-441c-446a-08da211b23b3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3016

In current code, when Xen is running in a multiple nodes
NUMA system, it will set dma_bitsize in end_boot_allocator
to reserve some low address memory as DMA zone.

There are some x86 implications in the implementation.
Because on x86, memory starts from 0. On a multiple-nodes
NUMA system, if a single node contains the majority or all
of the DMA memory, x86 prefers to give out memory from
non-local allocations rather than exhausting the DMA memory
ranges. Hence x86 uses dma_bitsize to set aside some largely
arbitrary amount of memory for DMA zone. The allocations
from DMA zone would happen only after exhausting all other
nodes' memory.

But the implications are not shared across all architectures.
For example, Arm cannot guarantee the availability of memory
below a certain boundary for DMA limited-capability devices
either. But currently, Arm doesn't need a reserved DMA zone
in Xen. Because there is no DMA device in Xen. And for guests,
Xen Arm only allows Dom0 to have DMA operations without IOMMU.
Xen will try to allocate memory under 4GB or memory range that
is limited by dma_bitsize for Dom0 in boot time. For DomU, even
Xen can passthrough devices to DomU without IOMMU, but Xen Arm
doesn't guarantee their DMA operations. So, Xen Arm doesn't
need a reserved DMA zone to provide DMA memory for guests.

In this patch, we introduce an arch_have_default_dmazone helper
for different architectures to determine whether they need to
set dma_bitsize for DMA zone reservation or not.

At the same time, when x86 Xen is built with CONFIG_PV=n could
probably leverage this new helper to actually not trigger DMA
zone reservation.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v1 -> v2:
1. Extend the description of Arm's workaround for reserve DMA
   allocations to avoid the same discussion every time.
2. Use a macro to define arch_have_default_dmazone, because
   it's little hard to make x86 version to static inline.
   Use a macro will also avoid add __init for this function.
3. Change arch_have_default_dmazone return value from
   unsigned int to bool.
4. Un-addressed comment: make arch_have_default_dmazone
   of x86 to be static inline. Because, if we move
   arch_have_default_dmazone to x86/asm/numa.h, it depends
   on nodemask.h to provide num_online_nodes. But nodemask.h
   needs numa.h to provide MAX_NUMANODES. This will cause a
   loop dependency. And this function can only be used in
   end_boot_allocator, in Xen initialization. So I think,
   compared to the changes introduced by inline, it doesn't
   mean much.
---
 xen/arch/arm/include/asm/numa.h | 1 +
 xen/arch/x86/include/asm/numa.h | 1 +
 xen/common/page_alloc.c         | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h
index 31a6de4e23..268ba93a92 100644
--- a/xen/arch/arm/include/asm/numa.h
+++ b/xen/arch/arm/include/asm/numa.h
@@ -24,6 +24,7 @@ extern mfn_t first_valid_mfn;
 #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn))
 #define node_start_pfn(nid) (mfn_x(first_valid_mfn))
 #define __node_distance(a, b) (20)
+#define arch_have_default_dmazone() (false)
 
 #endif /* __ARCH_ARM_NUMA_H */
 /*
diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index 1f268ce77d..6eeae02060 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -74,6 +74,7 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr)
 #define node_spanned_pages(nid)	(NODE_DATA(nid)->node_spanned_pages)
 #define node_end_pfn(nid)       (NODE_DATA(nid)->node_start_pfn + \
 				 NODE_DATA(nid)->node_spanned_pages)
+#define arch_have_default_dmazone() (num_online_nodes() > 1)
 
 extern int valid_numa_range(u64 start, u64 end, nodeid_t node);
 
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..4c0dc3cb3c 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1889,7 +1889,7 @@ void __init end_boot_allocator(void)
     }
     nr_bootmem_regions = 0;
 
-    if ( !dma_bitsize && (num_online_nodes() > 1) )
+    if ( !dma_bitsize && arch_have_default_dmazone() )
         dma_bitsize = arch_get_dma_bitsize();
 
     printk("Domain heap initialised");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:09:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:09:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307063.522355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNO3-0000XN-2q; Mon, 18 Apr 2022 09:09:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307063.522355; Mon, 18 Apr 2022 09:09:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNO2-0000X7-Va; Mon, 18 Apr 2022 09:09:34 +0000
Received: by outflank-mailman (input) for mailman id 307063;
 Mon, 18 Apr 2022 09:09:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNO1-0006ub-Dz
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:33 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0609.outbound.protection.outlook.com
 [2a01:111:f400:fe02::609])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4241f919-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:09:32 +0200 (CEST)
Received: from DB7PR03CA0095.eurprd03.prod.outlook.com (2603:10a6:10:72::36)
 by AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:18 +0000
Received: from DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:72:cafe::ba) by DB7PR03CA0095.outlook.office365.com
 (2603:10a6:10:72::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:18 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT010.mail.protection.outlook.com (10.152.20.96) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:17 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Mon, 18 Apr 2022 09:09:17 +0000
Received: from f51aa0450e9c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A2B559B8-7646-46D0-8CE1-D20079B0863E.1; 
 Mon, 18 Apr 2022 09:09:11 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f51aa0450e9c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:11 +0000
Received: from AM7PR04CA0025.eurprd04.prod.outlook.com (2603:10a6:20b:110::35)
 by AM0PR08MB4577.eurprd08.prod.outlook.com (2603:10a6:208:fe::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:10 +0000
Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:110:cafe::6a) by AM7PR04CA0025.outlook.office365.com
 (2603:10a6:20b:110::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:10 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:09 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:08 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4241f919-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=b+kkvGS3/fA3Z6skbovMJfBC0zHGpIPcShHjvP25cAE=;
 b=l27uyZZ9/Y7WzwOt6kXyxm2MfJYNG8NBjX56R7Igc7yz+yIMR8UiKbJO1Pa5D3w5CXDIQjJXBZzYc3r7GRjv6UmTL+GRM2dQqbMGhrbxg5Bw00B/i4kqnfknROwGWgyTY/GDIk7bt/PKAHjfhvf53r9VCTOpBxZrJKpHZCLrVl8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 95b13141f1f39154
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jJhIAr5eQlspRDJp8E93yhTHxeWgfZYDdopNGYSXsNbHxvWeTsQ5KB4HMBQeH/rp1e4tj8LNm8ThdB/ZRLgysBPitPiNJGPzMz0scLwGFU4dS5F2nX4EalTFIm2Y3sbfsAR+acmF4umhgPwvKBF8D1nxJebOijtE8G1FU2PCFa3cnjgP45AZG59BJ/KaNImsrQkAhwKuKRXh45d4Q0cVtv6nU1K3UMUYiPqv4HA9fQUSCnE59OxkLLqAZsn7XRRWQFlvXPANLto04NytLp6JjIlslJzzBUjl/LJIABOkmS3CTPMTLLApV/g2iX8vOrNc4PBBL1DWLFulkSdLuuygLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b+kkvGS3/fA3Z6skbovMJfBC0zHGpIPcShHjvP25cAE=;
 b=lbnnQmm7c0hl1wBmhZt8sRrujxSqaXGIeiPUzu/DB62WJ1VXUtSlkhlCfmstt7okhzl2RMH/C4p1C7WpjtnmisAYtT5/DE7yYUBFZv/H6WB85WvPnwYcEeW2ab5K8uEqTeDwpTRvIFWERDc5QfAMim4VFM2JxI/sDrg3EGTKi6Pj1vDl5LttPjHinvqfcu8cl3xvVtcv2ncd6tHC08BKdHRkGvg53I/Itp7vCmiY9jbyk4VV0VuaibQvh6uJGOPRp5r5JwSIzt7hdDCiwsqs/gwg97iV1ZlFY5mBsQf3bWooy8GJaHt79HlqsB1dQCQkXI74CX68AZhiLqxVRFWwoQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=b+kkvGS3/fA3Z6skbovMJfBC0zHGpIPcShHjvP25cAE=;
 b=l27uyZZ9/Y7WzwOt6kXyxm2MfJYNG8NBjX56R7Igc7yz+yIMR8UiKbJO1Pa5D3w5CXDIQjJXBZzYc3r7GRjv6UmTL+GRM2dQqbMGhrbxg5Bw00B/i4kqnfknROwGWgyTY/GDIk7bt/PKAHjfhvf53r9VCTOpBxZrJKpHZCLrVl8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 04/10] xen/arm: Keep memory nodes in device tree when Xen boots from EFI
Date: Mon, 18 Apr 2022 17:07:29 +0800
Message-ID: <20220418090735.3940393-5-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 281da175-eb93-4564-b5d5-08da211b1e02
X-MS-TrafficTypeDiagnostic:
	AM0PR08MB4577:EE_|DB5EUR03FT010:EE_|AS8PR08MB6919:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB6919C39C059C9D65398B054A9EF39@AS8PR08MB6919.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 B7eFzo2nCsVI+2O9YuQQ30xoceR2qZ/mdcc2jeaQFkpCIwAC3ZHKSTfiEY28FgJci0xRrFm9pz2MJQvBCftuhMYzT6/0ql2KmAUA71iu8NKiR8T6vvxFO0BOw30IMdrv3NkNDeQHkAoPbNRXgmMHFl6e1PvJSyljX7JT98ORET2n/gwQA3uBWgKWW0EXLTxhqeBbcDqffTDWbQQ3vos8UNyKNvxpBxJLWY0XP6a4SRjP6xEM3I7kXYVwFkmEW6w5VEAm8jcFQySohqUKvAYBrJ1/eMFmUBkEZuF8XSDji6YYazcNutzHlh5KwBENXS+xTBsamgrlivVJOCr1xrNaRTVexmPZxyTxbkV3dinJ3K6Bka150aWe8tIr58DCODneG7F2Cb7Xlv3r+aRfP0JOllxmIexggHZHMmSyuZs6G6KW0/TBT0+LPPp3cXp2G2/Aph4Vg3rhDxstqaNWodgBkxDd3fRh/Ukpc9sUsH5FRQp+qJduV8Lu0m4saFvdOXWG93RdXMQp33m4H8mi5nKJESl7AxDOT9KBV2e/m6yGOilhwNzEKi0D2hmdnR0uvPrWOcOcv4Hg6HYDugLPjtMYdqtbR738igcjB40yiCMWQ+3eJwjWUnDu3yBeIugXkUOLbrh7EFcOOq/vfIcmMdJ7X+ufmXru3ZvZ4YTlvWkIrf2NxRQImeWkX6HVdZireDVtbBO8BofjCpUNb3Xje+HBnw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(82310400005)(26005)(508600001)(8676002)(4326008)(47076005)(110136005)(54906003)(36756003)(86362001)(6666004)(7696005)(40460700003)(316002)(70586007)(186003)(2616005)(83380400001)(2906002)(70206006)(1076003)(426003)(336012)(81166007)(356005)(36860700001)(5660300002)(8936002)(44832011)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4577
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	dca60300-23c2-4b04-23d8-08da211b192d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IvcVQkdpgv1Emytnp1hjEzD7ZTRBp8ATPOyd1TM8AEMu4m96hzphwBjdlSgrDjEeSMllW+YeTn3uyfsrcbo3CuXHvCZfavOB4N5B0CKlt+B6l6qJC/Fk4IJ3vTqOy5dNyZivRTEfPeViEEIPFhCpV1Cu67ZMl6wLmnnLX9v4NipQCE7x/mlgZTPC8rwPcgC5ZKBOeQGLbo8x14PF6092f0yGWlrosYvkChHE9FzaRZ/uzMSlhExxpuSATdzoxrfKmF80jH9zUB/9Ar4JeorlCs8+xSOzes5yvrXnFlyxVKzLvBDMfM2rToz8f851tTM8YMt4EpXoBGc4UWJywwHO3UcKbTptdOVVM+4IsaPaOCvgVEdlhuWxeBKsKtBiJ83kMdXeYupMvgA8XA2wN65RHqArPgV19w1L6/CCo5xYGhUT7bK+srMgoyBo/5vLBp4xzSzFgDNme4rtrgWqHRxhADiGe6iO7z4ls0uhpKNagbWkVg0yEx8ripkYOmXomTn3vnIvpY1xZllGxDK4R/IUbHfRfXOdmyWx29+bSJlOjI+LLvg7oW0B+qaWAGIwWdcqj51w4OSjmcx1TZhiF+xWzOHKPBJXHgmzoyGSJIkyhFMuzZDlqYdsLXGctWDLgLcHXufMe7jyhHUCqQsSchUnSyBKyszgd1VYx9rlCCS9h4NWtIy5cQ6f5Z0KmOhuVdQv
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(8936002)(40460700003)(54906003)(508600001)(6666004)(5660300002)(81166007)(316002)(83380400001)(86362001)(36756003)(110136005)(2906002)(7696005)(44832011)(8676002)(4326008)(26005)(82310400005)(36860700001)(70586007)(70206006)(450100002)(2616005)(1076003)(47076005)(426003)(107886003)(336012)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:09:17.7674
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 281da175-eb93-4564-b5d5-08da211b1e02
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6919

In current code, when Xen is booting from EFI, it will delete
all memory nodes in device tree. This would work well in current
stage, because Xen can get memory map from EFI system table.
However, EFI system table cannot completely replace memory nodes
of device tree. EFI system table doesn't contain memory NUMA
information. Xen depends on ACPI SRAT or device tree memory nodes
to parse memory blocks' NUMA mapping. So in EFI + DTB boot, Xen
doesn't have any method to get numa-node-id for memory blocks any
more. This makes device tree based NUMA support become impossible
for Xen in EFI + DTB boot.

So in this patch, we will keep memory nodes in device tree for
NUMA code to parse memory numa-node-id later.

As a side effect, if we still parse boot memory information in
early_scan_node, bootmem.info will calculate memory ranges in
memory nodes twice. So we have to prevent early_scan_node to
parse memory nodes in EFI boot.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v1 -> v2:
1. Move this patch from later to early of this series.
2. Refine commit message.
---
 xen/arch/arm/bootfdt.c      |  8 +++++++-
 xen/arch/arm/efi/efi-boot.h | 25 -------------------------
 2 files changed, 7 insertions(+), 26 deletions(-)

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index e318ef9603..78e10c6ebc 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -11,6 +11,7 @@
 #include <xen/lib.h>
 #include <xen/kernel.h>
 #include <xen/init.h>
+#include <xen/efi.h>
 #include <xen/device_tree.h>
 #include <xen/libfdt/libfdt.h>
 #include <xen/sort.h>
@@ -370,7 +371,12 @@ static int __init early_scan_node(const void *fdt,
 {
     int rc = 0;
 
-    if ( device_tree_node_matches(fdt, node, "memory") )
+    /*
+     * If Xen has been booted via UEFI, the memory banks are
+     * populated. So we should skip the parsing.
+     */
+    if ( !efi_enabled(EFI_BOOT) &&
+         device_tree_node_matches(fdt, node, "memory") )
         rc = process_memory_node(fdt, node, name, depth,
                                  address_cells, size_cells, &bootinfo.mem);
     else if ( depth == 1 && !dt_node_cmp(name, "reserved-memory") )
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index e452b687d8..59d93c24a1 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -231,33 +231,8 @@ EFI_STATUS __init fdt_add_uefi_nodes(EFI_SYSTEM_TABLE *sys_table,
     int status;
     u32 fdt_val32;
     u64 fdt_val64;
-    int prev;
     int num_rsv;
 
-    /*
-     * Delete any memory nodes present.  The EFI memory map is the only
-     * memory description provided to Xen.
-     */
-    prev = 0;
-    for (;;)
-    {
-        const char *type;
-        int len;
-
-        node = fdt_next_node(fdt, prev, NULL);
-        if ( node < 0 )
-            break;
-
-        type = fdt_getprop(fdt, node, "device_type", &len);
-        if ( type && strncmp(type, "memory", len) == 0 )
-        {
-            fdt_del_node(fdt, node);
-            continue;
-        }
-
-        prev = node;
-    }
-
    /*
     * Delete all memory reserve map entries. When booting via UEFI,
     * kernel will use the UEFI memory map to find reserved regions.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:09:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:09:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307064.522367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNO5-0000v0-Ef; Mon, 18 Apr 2022 09:09:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307064.522367; Mon, 18 Apr 2022 09:09:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNO5-0000ut-Aq; Mon, 18 Apr 2022 09:09:37 +0000
Received: by outflank-mailman (input) for mailman id 307064;
 Mon, 18 Apr 2022 09:09:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNO3-0006ub-Ko
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:35 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0624.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::624])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4394dd6e-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:09:34 +0200 (CEST)
Received: from DB6PR07CA0081.eurprd07.prod.outlook.com (2603:10a6:6:2b::19) by
 VI1PR08MB3104.eurprd08.prod.outlook.com (2603:10a6:803:42::17) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.18; Mon, 18 Apr 2022 09:09:30 +0000
Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2b:cafe::e6) by DB6PR07CA0081.outlook.office365.com
 (2603:10a6:6:2b::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.12 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:30 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:30 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Mon, 18 Apr 2022 09:09:30 +0000
Received: from 4f42fa70571b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FF6153FE-11D1-415C-91D8-C9DFCB1B1FCB.1; 
 Mon, 18 Apr 2022 09:09:23 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4f42fa70571b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:23 +0000
Received: from AM6PR0502CA0070.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::47) by DB6PR0801MB2069.eurprd08.prod.outlook.com
 (2603:10a6:4:7a::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:21 +0000
Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::a2) by AM6PR0502CA0070.outlook.office365.com
 (2603:10a6:20b:56::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:21 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:20 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:19 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4394dd6e-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bpBKGazT9JC8lRpfqSPdaFeJFZI9C70EVp+BKwYVSR4=;
 b=nQ+5MP228nSOFQBxbFNYpOZFA3FJTx0PYgo593b0kojgaovpgPA17f2LMDesqQcVu7P2KH+2vX7bmmuf2YWf1Wh5i3IXBUMHsIVsZd2PkH58gO/lLZX9c9YbxkJz2YLSCdoX99XD/lbP1/WBLIqY26op2sMeo2AreflHn2K8K3U=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 23b4a5fef05d5e3e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qu7vEESF5z6unrsZANbJVxjyuDCWIgW25s1Mt3F2+KC1PHbovU8aR3tTrc5Mtk3UXvNUCuBRMOGG5Xhmw07eIz43xr07gFXhJOim8QL8DXk5uRgwFY5AQI7IyU6J2LngytOAVJ2ExZMyUx7B3FBuu76z7lJgaKLObukZc7K0F/zhsBsYv6FvQdv5ghyCPTT422k3LLw3nqYzuXvU7kMliUozoY2PsJjfbqCYUk8z7bfh3FW9fQ++GacZNp5hB0wr3dpDc1x/DO/BWjzRmym56Xef6FDBfAa+YYWszDnCcp9y2RWS1aiom+uMzNLR/eRug4t1C3XeffbjRpmOQpllOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bpBKGazT9JC8lRpfqSPdaFeJFZI9C70EVp+BKwYVSR4=;
 b=h7X7y4Kf66cd7DEbFbDHCIoGUCNfCWo/Rc+unLWy1mtErL4ZfjsNEgxS9df9KkY0tiE88qPel80sMrjD2wu01AWjzfCLH7kZWQi+65Too7aYHDU7JgS+5CpxfndSMAwmKD8UH7WOuHZO+sRKvoPhqThB15ZhzSrZY0OgD3hfabgd9phCkBNUEUOp9ZAW4VmFG62+8i/qNwO1CyzdhvpuaYYZOOfpHO0zlXvvDBlJOnV3cM27qWr4gI6PlnhSnzj64DoI9r4umG7k6kWf+hueQJR2RYPSS2iyDuILRGuk2DTaNxBa609CPntQxO01zPhJ031aLSDpx/W/1OasHGQ96Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bpBKGazT9JC8lRpfqSPdaFeJFZI9C70EVp+BKwYVSR4=;
 b=nQ+5MP228nSOFQBxbFNYpOZFA3FJTx0PYgo593b0kojgaovpgPA17f2LMDesqQcVu7P2KH+2vX7bmmuf2YWf1Wh5i3IXBUMHsIVsZd2PkH58gO/lLZX9c9YbxkJz2YLSCdoX99XD/lbP1/WBLIqY26op2sMeo2AreflHn2K8K3U=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 07/10] xen: decouple NUMA from ACPI in Kconfig
Date: Mon, 18 Apr 2022 17:07:32 +0800
Message-ID: <20220418090735.3940393-8-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: d5855dca-c0cc-4346-8026-08da211b2575
X-MS-TrafficTypeDiagnostic:
	DB6PR0801MB2069:EE_|DB5EUR03FT034:EE_|VI1PR08MB3104:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3104D8DBDBA8996CEE297A679EF39@VI1PR08MB3104.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 gluoZOpqTErfSkjpXG4bjpicgNlQUvAqQOyKwXx3178Z3G0Jhc7aZIzRjfMFHJiu08QuhKOcuJMlwHARcohT4lRylZPuGrXpW47A27Ncje+i6jGRNoE+ET9E9OUqmRgZOO1HRjmQwiJ/lz7Tb+eHPZUkq+YSud70fCPAoNVwMsFyjjnaKzzJ7KbrffK2FCrbNPylIunh//406cVjt5tpAQiCvmOChu5myOUngysvTcIhlxcu6qLZ+CTzzvLbt1OQFpPwwqjqzqLuEeNv492l1Hzs+DcaYcsS1I7yMwfzK0Dw04NKicU3reeLlw5TY6e1B6bbyHF+6WiScyyfsmNX4mozWEAn/TxjSt/hrguxFeZfGT5Bd5ApCjufToUazFS4j1/LvOr9uSukd6fx4EbM6z1O+Iz99ib26FJYz8qIKGYg/CW55CC0uVIFgbU2wVZZzgT9HCNVgrl7oNXRQgYASJsu0lDO/zHPmjN+DqxTepxL67T4TqVkNUVDsfvQpnKDVWneXtL5y0Ohga7F7tSCEuIriVLWvqGqWlsWNjNpWD21v/mn2urnSuNU0MRyLaUKWYuqbmLgZ3eUPVHDMb+gLgWdefDb5n/yp60XyN3HafArG0XC03WgviaVHEXG3HNsrr1Gsp03XxB+BecUJ6tTnb7228w6pCcLsHYTeXiYXd7nVx+5YWe30GvEvXyPvg3N
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(86362001)(83380400001)(5660300002)(110136005)(1076003)(7696005)(82310400005)(2906002)(508600001)(81166007)(356005)(36756003)(26005)(186003)(54906003)(47076005)(426003)(336012)(8936002)(2616005)(44832011)(6666004)(36860700001)(8676002)(4326008)(70206006)(316002)(70586007)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2069
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	15f81b41-839c-4ea2-ef6a-08da211b1ffa
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+6IE9pkXIU+eAR2kSZmGkM49XZCJ17ZGJ/Qt8BSj/PvGOKvKIWywiq8+hqxwCYjBr5EDdt90E+Fst8TTDfow8bUheq0veEVwHnZ7SzS8T94clMB753Oo5Br/hO/8Y/zyT13GyW60a1mgRzBlRjk0fM9155vZ/y7Tx8HzdHQD/Gz0E8lEgoY//+4m12eTLcQcqCcH3x98a69oG1auXQPj3xUpppxJ/V9q46WlXUNB08NZGRuDR/YtuJuvR1c7gSe4AqB5ch95sCCEp2dLjQQYvAZt4Ct3LXubqju5NBzNeAJzVmFAb6VnWREzk0qLQt5/vIl0Mu9XHjr5JlA60mcLzXkS/hmR+YjDcWUfNDD7/igWHkNFfO2cYrdBeHX8QjhyVXBHZdOWtIlhoB1XkOKgAi279EVfdBYiDYRCByBCKl2FWTGmhI/TkS3SS9MXVstSK3Z8rVhrksYpM7KDQvJIqPlbd7yJt3KKCFSu88lhnvddSu7Pdns+l7V2vqQOYwaC8bboXtI0N5MrKcj6s4r7tfCp3ZfUfptQTGnrjJFL8f0a0EwGPfrJJ6tQRaknFcJRlwInq16VIVVyXrI2Ma9JzkmRCTj6sV5utz0UNm9W9E/VfWeiOQ2cFrYtXgspolvMJ6bGsvQLauHH0iDbfoY9Pg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(44832011)(36756003)(8936002)(5660300002)(2616005)(450100002)(316002)(54906003)(110136005)(7696005)(6666004)(508600001)(70586007)(70206006)(2906002)(1076003)(86362001)(186003)(107886003)(426003)(26005)(47076005)(336012)(36860700001)(82310400005)(8676002)(4326008)(81166007)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:09:30.2637
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d5855dca-c0cc-4346-8026-08da211b2575
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3104

In current Xen code only implements x86 ACPI-based NUMA support.
So in Xen Kconfig system, NUMA equals to ACPI_NUMA. x86 selects
NUMA by default, and CONFIG_ACPI_NUMA is hardcode in config.h.

In a follow-up patch, we will introduce support for NUMA using
the device tree. That means we will have two NUMA implementations,
so in this patch we decouple NUMA from ACPI based NUMA in Kconfig.
Make NUMA as a common feature, that device tree based NUMA also
can select it.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/Kconfig              | 2 +-
 xen/arch/x86/include/asm/config.h | 1 -
 xen/common/Kconfig                | 3 +++
 xen/drivers/acpi/Kconfig          | 3 ++-
 xen/drivers/acpi/Makefile         | 2 +-
 5 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 06d6fbc864..1e31edc99f 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -6,6 +6,7 @@ config X86
 	def_bool y
 	select ACPI
 	select ACPI_LEGACY_TABLES_LOOKUP
+	select ACPI_NUMA
 	select ALTERNATIVE_CALL
 	select ARCH_SUPPORTS_INT128
 	select CORE_PARKING
@@ -26,7 +27,6 @@ config X86
 	select HAS_UBSAN
 	select HAS_VPCI if HVM
 	select NEEDS_LIBELF
-	select NUMA
 
 config ARCH_DEFCONFIG
 	string
diff --git a/xen/arch/x86/include/asm/config.h b/xen/arch/x86/include/asm/config.h
index de20642524..07bcd15831 100644
--- a/xen/arch/x86/include/asm/config.h
+++ b/xen/arch/x86/include/asm/config.h
@@ -31,7 +31,6 @@
 /* Intel P4 currently has largest cache line (L2 line size is 128 bytes). */
 #define CONFIG_X86_L1_CACHE_SHIFT 7
 
-#define CONFIG_ACPI_NUMA 1
 #define CONFIG_ACPI_SRAT 1
 #define CONFIG_ACPI_CSTATE 1
 
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index d921c74d61..d65add3fc6 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -70,6 +70,9 @@ config MEM_ACCESS
 config NEEDS_LIBELF
 	bool
 
+config NUMA
+	bool
+
 config STATIC_MEMORY
 	bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED
 	depends on ARM
diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig
index b64d3731fb..e3f3d8f4b1 100644
--- a/xen/drivers/acpi/Kconfig
+++ b/xen/drivers/acpi/Kconfig
@@ -5,5 +5,6 @@ config ACPI
 config ACPI_LEGACY_TABLES_LOOKUP
 	bool
 
-config NUMA
+config ACPI_NUMA
 	bool
+	select NUMA
diff --git a/xen/drivers/acpi/Makefile b/xen/drivers/acpi/Makefile
index 4f8e97228e..2fc5230253 100644
--- a/xen/drivers/acpi/Makefile
+++ b/xen/drivers/acpi/Makefile
@@ -3,7 +3,7 @@ obj-y += utilities/
 obj-$(CONFIG_X86) += apei/
 
 obj-bin-y += tables.init.o
-obj-$(CONFIG_NUMA) += numa.o
+obj-$(CONFIG_ACPI_NUMA) += numa.o
 obj-y += osl.o
 obj-$(CONFIG_HAS_CPUFREQ) += pmstat.o
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:11:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:11:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307089.522383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNQG-0003aJ-9D; Mon, 18 Apr 2022 09:11:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307089.522383; Mon, 18 Apr 2022 09:11:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNQG-0003Zt-1F; Mon, 18 Apr 2022 09:11:52 +0000
Received: by outflank-mailman (input) for mailman id 307089;
 Mon, 18 Apr 2022 09:11:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNOB-0006ub-Cx
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:43 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0620.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::620])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 485455bc-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:09:42 +0200 (CEST)
Received: from AS8PR04CA0175.eurprd04.prod.outlook.com (2603:10a6:20b:331::30)
 by AM0PR08MB4402.eurprd08.prod.outlook.com (2603:10a6:208:147::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:39 +0000
Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:331:cafe::13) by AS8PR04CA0175.outlook.office365.com
 (2603:10a6:20b:331::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:38 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Mon, 18 Apr 2022 09:09:38 +0000
Received: from ff45ff41fb00.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B65B4532-1C2E-4959-AB3A-F74E8031AACF.1; 
 Mon, 18 Apr 2022 09:09:32 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ff45ff41fb00.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:32 +0000
Received: from AS9PR06CA0544.eurprd06.prod.outlook.com (2603:10a6:20b:485::14)
 by AS8PR08MB7791.eurprd08.prod.outlook.com (2603:10a6:20b:52d::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 18 Apr
 2022 09:09:30 +0000
Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:485:cafe::e8) by AS9PR06CA0544.outlook.office365.com
 (2603:10a6:20b:485::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:30 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:30 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:28 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Mon, 18
 Apr 2022 09:09:27 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 485455bc-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D2YTQR4kVi07mVUXoM7ogXNLlXVpGhLewzGsT6EnZHU=;
 b=JWOD7Em0KRj2/b2TGc2wmvTSRaoDrgOwJFbKZMvDrztf1Ewfn6npj2HPv+CwwfENTVlLTz86gF7g4K7EsXP2jFxpEqQMl51V2b2buaHrFKRahmEVZoZFK3iQemf9Fem1wDGYNfMnhby0xthq7Vk1hzWw0JhfjYOLUiiow/jSWqI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4a4768c3d8d5e889
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MvMLb6QpuStdUhsJUHMdqf5n5N5A750ce+Nn1hP4hQCVok2rBbkH21A+23+cdUJMYFYsKw8zXyk2tWbqkgwjQG3S9B6COdHjqOt2wesqsM/KKmSl0PT308Sabk9rzpVUYZtESI2MzEQlgYSy2nhcZlJiMJzHxN9u6LUrQr7HJ8pt+t3MYgkcsWL1+G/hjseuPRo9KRp8jEVTweifcZJJBzWnopQJSKKGzHWpI5+GifcGYSQbIeD20WWtpBoIdzA1ZSoXg24Dj9ftUoGwx0y4HGSiOsRmzXPhBhbF0r66mqg4Rscy8+rwQ1ri6d/CEQKwwLO8wYXZ5NgzbSGtK3taMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D2YTQR4kVi07mVUXoM7ogXNLlXVpGhLewzGsT6EnZHU=;
 b=eXF4NlfHtEaY99c12+vK/3Zl/3X5GGv7v514hhhsu3/TObhkHxTIRGyDbaw6nV/5l7Whx8AjwcIoOdFjCY4psxeDpU/RTDoHF1+kGxJkqug0V5XzYI720EY6+0SN8XFBgOhXGNCfWg4IFQHOtYOuL2M75Nr6+fC6CMczmNT+adi6fRYe/2JlQNw3v7FJiFIi5n+x+nyhFIjLzbYjQvKwwWoF+Keaua5hQBD/XmP4nc56vZueD2BCe1b6TGrMRJpziGyh7d1l046AJrAxETV2mzCpTn+a55OLb9hm6v8YqS9d+nvtIFbTvVwmSJNVkB59PD4BkH0qFi3mnSvWT46pfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D2YTQR4kVi07mVUXoM7ogXNLlXVpGhLewzGsT6EnZHU=;
 b=JWOD7Em0KRj2/b2TGc2wmvTSRaoDrgOwJFbKZMvDrztf1Ewfn6npj2HPv+CwwfENTVlLTz86gF7g4K7EsXP2jFxpEqQMl51V2b2buaHrFKRahmEVZoZFK3iQemf9Fem1wDGYNfMnhby0xthq7Vk1hzWw0JhfjYOLUiiow/jSWqI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v2 10/10] xen/x86: add detection of memory interleaves for different nodes
Date: Mon, 18 Apr 2022 17:07:35 +0800
Message-ID: <20220418090735.3940393-11-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 8fe2667f-5c83-42ed-43f9-08da211b2a8f
X-MS-TrafficTypeDiagnostic:
	AS8PR08MB7791:EE_|VE1EUR03FT021:EE_|AM0PR08MB4402:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB4402701740F880166D0971C99EF39@AM0PR08MB4402.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5vbjxV65qalRGNW5ycXmUv+w0iYAcmkTaStqPKnnMYYqR5Xzuab2REBMdjGyiGGEXxFDuEB83IZkl/+HM3EUGXVrs9wYDRWr3lKgedgA4t2CY4luQDmcLg6K0uP07QM+gB2RhNzhuc1cbNYm5SX78Dz0zcagN18/ymFNhFyXd4NuA3T+D2bHlv2Yr7DychNA83lEWnH8PJ5Zbp4YyS0xfpH4EssaV6TT+4hXCXJeHyQJo+ks7rmfQJS59sqiZnqkpUMFkOpuS8ZRYvbrroMoFY5jnzI7xnQvo1pzy3kTHuPugTbb+STF+8S7JO70Ah0OQaXhk9XMjwxXoaoG0cSCcW/mtlz4+IQZHo6/v35QD2MSKK1OjcPEFniJ68Eie934IMlQz9w7u7XN/4I6UZbOYyhredIVU01qKs2EwSbVL7+PGxQe99lQwdc44XzzWb+faPmDEsPZNZCjMpwXuXJEcU2kbuy8GJeT9CmkvboAB4dXGJVs1GaRBvmUnYhgcqHifwZdx3acqrusyliqlwZviCvycUpAC9unkHMUbZC2yjS49+9wmCV3MIozf5C4UVrbSZ9iPV1ljZsIeOls6LiWZQT57zlNOE56Qz1uzwr8hkQQyBdXeE0Nu8t7EDYahmHC5drbARKDZQWtdGummQO/97Fc/EDcWTCEOXrISS740SkdtIACsbKzM2LMjuEEj4Khz+5/5fpzHZtAN0iBR2/fQw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8936002)(6666004)(7696005)(8676002)(316002)(356005)(26005)(1076003)(336012)(426003)(70586007)(4326008)(86362001)(36860700001)(5660300002)(44832011)(83380400001)(70206006)(2616005)(81166007)(47076005)(186003)(36756003)(2906002)(40460700003)(110136005)(508600001)(54906003)(82310400005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7791
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8cf1de3b-8cb8-4123-5504-08da211b2569
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fNTokM2cT+IhKc36fE7XL8XYfarcIIcbNawRbwsPJW7WB2nn6gxgg0fawG4QfJKenpbd7N7H0BvcYlAbzOSlecRkYZwxnINx4Ws6Oz3f5tgu2At5v+y0qzmZQ+VaBogZUQxhBUEZeNrD7Q3X7ko7PtHZsDOymnTN5r2Ro2a/jaOvaIq/TRHonjg5XUHoUYdKdWejufiX+NjYGQbWy91KDMMbkzwLepl7imO4amQn6bhfd7axDsA2kKv35tfZUnTGORhA3EOYyvmgh/56TY8YQnPFeyJsvfS7ZZwbnGSeQY0lzuD/f4/zFz/MxAnsmC2B8kmrLsUHsB9aQrguHwAaQPAlBuYwuwGxkQr6qa4jhALQ1F43ZxLEAbmNuo6X58BjZGeRDPz2gmen5Ci37kHYrXtiOBriXqoHmQYTMWDJOVzQdE1d99Xt2btL49g+KLrB70hDj1MHjE+keCV4i3ef8tWnQem4Uq5dwcIQkE3nEWIFseoVx3Tt4zQgBNbF7r0zA8x6dVpJkZVlKNZNKgKglk/+2IaePDI9rgg6xHegeJqL1dZbEjC11Qc4BpE32v8Kpuf8S2Wb8cdWa8LQ66Eojxw6eWva1m1B1D/wj5qudHcAfGuflEIh8Vv47Q/wDEB6Dz+yZEWtpx5+2vu6haB60Izyz4alZf3GSmpB1yL3VmxDVVhyl6J5ITloWFpUxX8L
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(44832011)(186003)(450100002)(26005)(40460700003)(110136005)(36860700001)(7696005)(82310400005)(2906002)(54906003)(316002)(6666004)(336012)(70586007)(47076005)(426003)(70206006)(2616005)(81166007)(36756003)(4326008)(1076003)(508600001)(8936002)(83380400001)(86362001)(8676002)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:09:38.6829
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fe2667f-5c83-42ed-43f9-08da211b2a8f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4402

One NUMA node may contain several memory blocks. In current Xen
code, Xen will maintain a node memory range for each node to cover
all its memory blocks. But here comes the problem, in the gap of
one node's two memory blocks, if there are some memory blocks don't
belong to this node (remote memory blocks). This node's memory range
will be expanded to cover these remote memory blocks.

One node's memory range contains other nodes' memory, this is
obviously not very reasonable. This means current NUMA code only
can support node has no interleaved memory blocks. However, on a
physical machine, the addresses of multiple nodes can be interleaved.

So in this patch, we add code to detect memory interleaves of
different nodes. NUMA initialization will be failed and error
messages will be printed when Xen detect such hardware configuration.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v1 ->v2:
1. Update the description to say we're after is no memory
   interleaves of different nodes.
2. Only update node range when it passes the interleave check.
3. Don't use full upper-case for "node".
---
 xen/arch/x86/srat.c | 49 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 45 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index c3e13059e9..53968e4085 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -271,6 +271,35 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 		       pxm, pa->apic_id, node);
 }
 
+/*
+ * Check to see if there are other nodes within this node's range.
+ * We just need to check full contains situation. Because overlaps
+ * have been checked before by conflicting_memblks.
+ */
+static bool __init check_node_memory_interleave(nodeid_t nid,
+                                                paddr_t start, paddr_t end)
+{
+	nodeid_t i;
+	const struct node *nd = &nodes[nid];
+
+	for_each_node_mask(i, memory_nodes_parsed)
+	{
+		/* Skip itself */
+		if (i == nid)
+			continue;
+
+		nd = &nodes[i];
+		if (start < nd->start && nd->end < end) {
+			printk(KERN_ERR
+			       "Node %u: (%"PRIpaddr"-%"PRIpaddr") interleaves with node %u (%"PRIpaddr"-%"PRIpaddr")\n",
+			       nid, start, end, i, nd->start, nd->end);
+			return true;
+		}
+	}
+
+	return false;
+}
+
 /* Callback for parsing of the Proximity Domain <-> Memory Area mappings */
 void __init
 acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
@@ -340,10 +369,22 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 			nd->start = start;
 			nd->end = end;
 		} else {
-			if (start < nd->start)
-				nd->start = start;
-			if (nd->end < end)
-				nd->end = end;
+			paddr_t new_start = nd->start;
+			paddr_t new_end = nd->end;
+
+			if (start < new_start)
+				new_start = start;
+			if (new_end < end)
+				new_end = end;
+
+			/* Check whether new range contains memory for other nodes */
+			if (check_node_memory_interleave(node, new_start, new_end)) {
+				bad_srat();
+				return;
+			}
+
+			nd->start = new_start;
+			nd->end = new_end;
 		}
 	}
 	printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIpaddr"-%"PRIpaddr"%s\n",
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:11:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:11:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307084.522378 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNQF-0003Xs-Si; Mon, 18 Apr 2022 09:11:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307084.522378; Mon, 18 Apr 2022 09:11:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNQF-0003XX-Ok; Mon, 18 Apr 2022 09:11:51 +0000
Received: by outflank-mailman (input) for mailman id 307084;
 Mon, 18 Apr 2022 09:11:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNO4-0006ub-SW
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:36 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on062b.outbound.protection.outlook.com
 [2a01:111:f400:fe07::62b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 44786735-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:09:36 +0200 (CEST)
Received: from DB6PR07CA0086.eurprd07.prod.outlook.com (2603:10a6:6:2b::24) by
 DB8PR08MB4057.eurprd08.prod.outlook.com (2603:10a6:10:a5::24) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.18; Mon, 18 Apr 2022 09:09:32 +0000
Received: from DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2b:cafe::75) by DB6PR07CA0086.outlook.office365.com
 (2603:10a6:6:2b::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.12 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:32 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT062.mail.protection.outlook.com (10.152.20.197) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:32 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Mon, 18 Apr 2022 09:09:32 +0000
Received: from 473d338c93a5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1E534BB9-E16A-47EF-9784-088848B356DE.1; 
 Mon, 18 Apr 2022 09:09:25 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 473d338c93a5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:25 +0000
Received: from AM6P192CA0024.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::37)
 by AM6PR08MB4659.eurprd08.prod.outlook.com (2603:10a6:20b:ca::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:24 +0000
Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:83:cafe::96) by AM6P192CA0024.outlook.office365.com
 (2603:10a6:209:83::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:24 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:23 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:22 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 44786735-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ryDzFvecatRrku+p3Uf242SapmXbat71UQcLw2AlN5k=;
 b=kRdd1KkF/a9OIi8OvMKVCRWILg36qwTODXAZ+P03LTPM64hqkt+AOjC6p1NqCTr3jSrxHsiFlodHVRWWY6RfQcZIUsNZ41R1ZS4PqfJ+VOkNhfYHBzlzcQXCP2bisOiczHGnjF7qMvppGpFOx4nO+N97F7nUAJQAw7zbzLOm3sw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7c151209e6bdb9ca
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NvbN3UGXKosLyTwzRN1T4ZaXMq65MMCC2iQhb8bXVEC3wO+tLkFLtfhHTQcaOqaerAU2lSoPFOVixllZ60q7MqHUIKlx9w2+CfbrUcMKFZ0u+yRWTvjdiHRV/r9HlUnUhQ2gbW1qgDfamW4bGnUmNsIIC83nLU/TRfvOTd0hDRqUKHZK31H8LeZRMVg6clokV0GnSNzA2EhtezM3zZ8KJOCMylbL/Kv1Dn5djTTuzvYIE3HkvxJgvOf1DRj9+XiE9BrfZdPiDjwP8iQzTFK+GMoM/OPll9+iaF/ri/ti/R4Nn36is5tM9Yximlh9IjVNPTAbqT42FfMVvHlc6/5UvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ryDzFvecatRrku+p3Uf242SapmXbat71UQcLw2AlN5k=;
 b=h85gJgsW7lC3C9jfpluPe8RVDCVyZnAfnyMH0xqnV9qfRRsqL28ymsSPsenYXwScE0BQsQS2kK/Z1p3yXqcNQCD7iyrDqh9NiG1HeZXJBMxv7D0IZHxR9oVnsC0VonNX5Ps9nF6vjZFNP34IeNZDBXKJ0TacoejsBdjZrK5HbDfu7KwQTpiRsrYeRXolHl4ayqFAWvkg42rywDoPQqUr0vR58YNsS+RM3k/KgMkQ9I+YDM1/NRT7wBUgQcljTf65XZ62QOiiYbcaT4K+eBHlTioOswT7zf82YlZYLrLj8HGyibsgLeU+EPUUyaYjNDhMrvZcp2E/8YiYdoBtALKGIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ryDzFvecatRrku+p3Uf242SapmXbat71UQcLw2AlN5k=;
 b=kRdd1KkF/a9OIi8OvMKVCRWILg36qwTODXAZ+P03LTPM64hqkt+AOjC6p1NqCTr3jSrxHsiFlodHVRWWY6RfQcZIUsNZ41R1ZS4PqfJ+VOkNhfYHBzlzcQXCP2bisOiczHGnjF7qMvppGpFOx4nO+N97F7nUAJQAw7zbzLOm3sw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 08/10] xen/arm: use !CONFIG_NUMA to keep fake NUMA API
Date: Mon, 18 Apr 2022 17:07:33 +0800
Message-ID: <20220418090735.3940393-9-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: c15145fe-f9b9-416e-b35f-08da211b26a7
X-MS-TrafficTypeDiagnostic:
	AM6PR08MB4659:EE_|DB5EUR03FT062:EE_|DB8PR08MB4057:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB40577EA08132D81E73D3215B9EF39@DB8PR08MB4057.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0Bbpp2Dc7JF+jbPJeJ3ESNoo3UbR9EXyjBpRvm/02e1f3d/LwKlxHQ28Pv9EN7n/4DDnCESngLqeKQ5oBIwuwyaBmuwWn1IrD5ZjZ26oXocI9czMSavjthQPxnsLSgtJv3EOjKjDeo4Ab8td0UqrBN2uKyVxOfeLn90WxW46bcWVJWvvsvuBqrkuIbcLv+cBpHynhJ3WarDYPL1cI4ulFAeZ1qOTTNCMpBSN5iXL++Cl1I+4uhNUUYD2L2ShsDbacJwOtBRjgxxGyJ6LeGaKenBHrIA1Gkr/ZWz8+ZBKF/eouqabM3eMF7WokiyWptio7R8rAvgGruDV0xAekVh/4Jaoh1X2YXYRLnsBstK5abr6TIzLk4eWBdeHOzIx4H6We96/wqQTsESFgMxZhAR+XduBqgi6gUDWZX1OXK3tMnU7h914+3e7Sp1MYBdJYAJsSIA3Ha1CD2N95JPexUbjPvFfhYsGvjbPrUlkz69m9w0UuEbxP2lR24biKMvhTvbqeI8HRMRkLyUt26jV1cbBODtpl9fR9+r3DDUR0rM5LPKUWQIUctviWJHUeze0s3t4LKNEek9X5D86mDlFJlW8cyXeoBUK4SktE6Zj9ma1W54GwC9/Nww0qTrvUYBa/khCtOaYSnd2lJeuXSGsLLIPWecFCjgBcjI7LVklCScqGD2qUErdzlD92rMFWYjzy/PPXlkzjVsjVMwXHzlWZq7ujg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(40460700003)(8936002)(336012)(426003)(86362001)(1076003)(4326008)(508600001)(83380400001)(47076005)(26005)(316002)(54906003)(110136005)(5660300002)(36756003)(6666004)(36860700001)(7696005)(82310400005)(8676002)(70586007)(70206006)(186003)(81166007)(2616005)(2906002)(44832011)(356005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4659
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	84fc2458-507d-4f9e-f124-08da211b21c3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o3wAxv0Yx+4bc/e2GiE9lDFYuYcCW8sJef+RNUHm11bH0S8zU6wYjmg/LyaejnnpmO5WViPNLpHTsGNnha5/P+5tu0qH+NcLDvBZLA0VSto8ncCdzbdvixInz2gaGxTCVJwKH+8KiA/nSibzJ/ZtsTiPYXhR37wrsyEg9rihuOo4iJ20TNY5EVPvAYCmiTHE+qLAIvAzgWPQWjIFPK17JP55Zg2dajSHJwgekwZOHjnkjE6/VrxZrJxSly4+d4K7qN4PNqyF5c2gCs+iO9xBAK7O4osUyHtUgOs5KWRvSd4DNoVipf8p3/Do8uPpUFWvItEyBr22bFKn00ylYxn+qFgc/isb1wmbMIcVTMIaWodcOclu8Yrobef2kW/5kWFwU01yDPWcwdlQerIsx4GBKLkKX1qNPgg29VY903Bss5DR1QRD502atZUX9Ii5xDbRfz14q8Ye1wnlmFLQgdITg68xfS8tHzTX5jvel8ZOBDVD1spF6K+5rl1EdWty/D7TEPfo8DUHxGRWblP1huMh8XzxP3nBMxI0EpO5cp/p6C4h1iQKrY9Ii++smWoXMmbVqp+nTmfSCarkl8p4LxYpnZVwy/oD14iRFdyqVso02mOOCHJI74UgYBe6/qBNcqNe2IDYlZCL/pndkWM5/x347+TW1JkaZYXZIfFABNIwvDnUJ2tWeUqXjfwLft7HmXU3
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(36756003)(426003)(86362001)(4326008)(8676002)(2616005)(81166007)(450100002)(110136005)(70206006)(82310400005)(70586007)(508600001)(7696005)(40460700003)(107886003)(47076005)(2906002)(336012)(26005)(54906003)(316002)(6666004)(1076003)(44832011)(83380400001)(36860700001)(186003)(8936002)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:09:32.2548
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c15145fe-f9b9-416e-b35f-08da211b26a7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4057

We have introduced CONFIG_NUMA in a previous patch. And this
option is enabled only on x86 at the current stage. In a follow
up patch, we will enable this option for Arm. But we still
want users to be able to disable the CONFIG_NUMA via Kconfig. In
this case, keep the fake NUMA API, will make Arm code still
able to work with NUMA aware memory allocation and scheduler.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
 xen/arch/arm/include/asm/numa.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h
index 268ba93a92..59cdf8e39e 100644
--- a/xen/arch/arm/include/asm/numa.h
+++ b/xen/arch/arm/include/asm/numa.h
@@ -5,6 +5,8 @@
 
 typedef u8 nodeid_t;
 
+#ifndef CONFIG_NUMA
+
 /* Fake one node for now. See also node_online_map. */
 #define cpu_to_node(cpu) 0
 #define node_to_cpumask(node)   (cpu_online_map)
@@ -24,6 +26,9 @@ extern mfn_t first_valid_mfn;
 #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn))
 #define node_start_pfn(nid) (mfn_x(first_valid_mfn))
 #define __node_distance(a, b) (20)
+
+#endif
+
 #define arch_have_default_dmazone() (false)
 
 #endif /* __ARCH_ARM_NUMA_H */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:11:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:11:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307091.522399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNQH-00041g-KY; Mon, 18 Apr 2022 09:11:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307091.522399; Mon, 18 Apr 2022 09:11:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNQH-00040C-EG; Mon, 18 Apr 2022 09:11:53 +0000
Received: by outflank-mailman (input) for mailman id 307091;
 Mon, 18 Apr 2022 09:11:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mice=U4=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngNOD-0006ub-Eb
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 09:09:45 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03on0607.outbound.protection.outlook.com
 [2a01:111:f400:fe08::607])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49c68361-bef7-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 11:09:44 +0200 (CEST)
Received: from AS8PR05CA0028.eurprd05.prod.outlook.com (2603:10a6:20b:311::33)
 by HE1PR0802MB2489.eurprd08.prod.outlook.com (2603:10a6:3:d8::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:24 +0000
Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:311:cafe::86) by AS8PR05CA0028.outlook.office365.com
 (2603:10a6:20b:311::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.21 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:24 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Mon, 18 Apr 2022 09:09:23 +0000
Received: from 0675bfe1463d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 060C464D-32CF-48A5-80EC-4AC72AB3D0C0.1; 
 Mon, 18 Apr 2022 09:09:16 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0675bfe1463d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:16 +0000
Received: from AM6PR0502CA0051.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::28) by VE1PR08MB5629.eurprd08.prod.outlook.com
 (2603:10a6:800:1a6::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:14 +0000
Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::b3) by AM6PR0502CA0051.outlook.office365.com
 (2603:10a6:20b:56::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:13 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:13 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:11 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49c68361-bef7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=29LYeiieE23CD0WLwJtnSYLtGaVHDf97F/bctCj7n5U=;
 b=Ki2e13f7txQp2lVU1auB2Mskus6Vu3CeqUunChNJF3PNL9PWPBoHQN4r/pRVj+YC7j73D2DxAYl0ldcA1AHJMqidYRPWqanpAeT6HCbq0rjguxOBbkO844wS/btll53P6ozf6vuZOWNF84lDIVc75oBCFR4aW9ewRpiKAcCadnE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 65cdb1ba32225669
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TnUbvlFfTLseXlX229YjrFVy49gUlyHRQ1XUjIDI9eRkFv+e+zXzij53P2QPvak147CUgrm9WsNr+WXuiQ0WPEBhTlwens/olTlZK5PO9VEybSeB/3c/CbyOZPFAXP4sMXRZnfctfkzT9tiEcDaQGtJa2S9LXAQuP9MaEsFjuol5faaqfXyNP74L24ImUs6nQUuVEglPvajP02cj1NpRf4LkCmA01dTiQl5Am0QDcs3aeuyq8CgO+1b6NiyacD2mLx1Sg9Fk1UmStsiK3stvgl2FzDqSCwM49pKlXJOrlytx/zX+hXvmCtXCr38szNcBY51miXEJyQ1t2N+pk4ujvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=29LYeiieE23CD0WLwJtnSYLtGaVHDf97F/bctCj7n5U=;
 b=S4h+BmdlbhNyndFyKuzmOqXQy0lpZfIeg32RbMPgmEw0tFi2SUtPoXZPYGVTN3Epdo8bPmPivcnCqOt+bQ8Hlislto3Gv8bcLfwZkXDqf1uNzgf4/b40Z7UxwnMq+qxRYBa6Z5HvAYPe1Hcqg+dzyD9u/k6/7PA56QheQKktQ3Zgu2qCkA+tjzrAHj76KQIkxg19pxym4K+hVOEfoQi+u4vIu4QW17eVZzI7UQ+mj+fi+A2k5AfEJTEzGBlXcnfXwLRjVwa68WQCMzD5aoNjCYs0d6UzglBd7IyxzPqbX2sXt34jPtZefsdBPBIXqhk6P9iAyySppwIm/i5UIIoaMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=29LYeiieE23CD0WLwJtnSYLtGaVHDf97F/bctCj7n5U=;
 b=Ki2e13f7txQp2lVU1auB2Mskus6Vu3CeqUunChNJF3PNL9PWPBoHQN4r/pRVj+YC7j73D2DxAYl0ldcA1AHJMqidYRPWqanpAeT6HCbq0rjguxOBbkO844wS/btll53P6ozf6vuZOWNF84lDIVc75oBCFR4aW9ewRpiKAcCadnE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid
Date: Mon, 18 Apr 2022 17:07:30 +0800
Message-ID: <20220418090735.3940393-6-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 65092e79-f4c7-48a7-aa5b-08da211b21cf
X-MS-TrafficTypeDiagnostic:
	VE1PR08MB5629:EE_|AM5EUR03FT013:EE_|HE1PR0802MB2489:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0802MB24899E2F38E3D3966EAC6F189EF39@HE1PR0802MB2489.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 7IKQK5lDBBDGYu0rD2Pr0OrXLlFPQVESNGhFivy8MMmjZgSDFxXHdWvvYnRC+HPZz7kWKVVRWj8jhZQm+/ceZ0HMR7b156QxWxiulakBfX8djucS1gD9luwNbz5FSA1f2VQgz8EJV4UEePE6uusEwSnvr5W64yHzDSRpe6ptMhG2654Rc6hSftguphMQwREN8tQN4a4VW9Ahnc5q/DpRhppCvpBh/GbgdjK8qLgrUD8S5c9G4MgrzhnxUd/VUIl3JSPKUvtbHAOQmyZjt7aiJOxyGhdX9gflUP++48Baw5GrXOA+dLv3W+dencJ7Q/NDkwmklrCLbfwAehX1jslDRnroep8xsGOQg8p5dnESLxKQKQbA8DtRFIwDbmxCR+/GaouqyGLB/G/aJDpLeFNz7yZI23i/FoAORyJggsMWIS3zV0f1fBfT40S+sCuF0DlaAiMcyFfIpVsBofRO3FEWC1B4gn8hyZZjl2AYSgXjMNMBdBS0vajE2z3/Ezw0liN81R2EwfrfqSw4EEUI6UQew1Jhs20EWlf6frjHhAAVe6cYSu5EIY0N2LA9Wc5W4puEIcyEVhNOYmub96ZD/hYFi4U5dqK9nz9nh5/Ck6KBv66khVUUdGhMG9jTkzy9usNxf/LeBdSCETI9QFwmowEueQ2e8Z2sdAY7CMS3E0X5ImQtw4TlhbFbbX8Ls9gooZVg
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(36860700001)(83380400001)(36756003)(82310400005)(316002)(2906002)(5660300002)(86362001)(47076005)(8936002)(44832011)(6666004)(508600001)(426003)(356005)(336012)(7696005)(81166007)(1076003)(2616005)(110136005)(26005)(186003)(54906003)(70586007)(70206006)(4326008)(8676002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5629
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	400928e9-6c96-4e76-3289-08da211b1b80
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OC58Yi+c2HFoaJ4N/2psBKHyhFtkz9Ni2sKz7FegMCGwfzWOMFxbicr3Z0tUAknR6QVlnn929VSd47t2a0m+6AyOXqSFDq6kv1lpWLXIqU8n2sS2zfCuw8fVnE1j9wDWgSznxidbi0oSmwN8oDjhE+GtLcVd8xTItLLNb0dqWPYd3ux+kkChuGyxwfZlm58NzhS4GoejeKs5LMM0tLB6onBcmiIs5QnMZP3ZQQoN24DbRUULovQTq4FUjDGBC2nAiibbpiHtZXRLi+istMuK6JWiBEA9w1DVvpxttkoqDsw28yG91ft6XKLEN5iwCNvsRDcVX5Mv+VYx/2sbEOXNoS6o7B66Bxptuv8aE3WEudYXBj+M+uTnNWZCslliTxnA7swDRfLJlHXAOV4N/5QilusswNhjwdCJuNQ4B5wRog0uZ89p/4KwXpF+xKs/ClPy1Bz8+i2WjmkbobrClbPxU5ElHvn8wbNT0XDtPgrIiPSvJGDo0sh9ZZG8bBsfH3Fg9A3mesFaleKj7wt5FoB8BBcW0eeKRXjTj3DXfJ1u+t+vYCXal/KwnTRkayZi08wtwT6dKwPKv6cviLO4g0vSYZRoxsIGY5xCD84WlqdfM8pdo12dvYSKij2ij8BYQm+FRC7IJdnJ7drA3iZotFJknv7PdfJxk5fH7lvYxBu/jyj9Sle6lHO3zWfUTJD5IHEM
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8936002)(36756003)(2906002)(83380400001)(5660300002)(54906003)(426003)(186003)(36860700001)(316002)(47076005)(336012)(44832011)(107886003)(1076003)(6666004)(2616005)(7696005)(508600001)(8676002)(4326008)(70586007)(86362001)(70206006)(26005)(110136005)(450100002)(81166007)(40460700003)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:09:24.0656
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 65092e79-f4c7-48a7-aa5b-08da211b21cf
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2489

VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This
results in two lines of error-checking code in phys_to_nid
that is not actually working and causing two compilation
errors:
1. error: "MAX_NUMNODES" undeclared (first use in this function).
   This is because in the common header file, "MAX_NUMNODES" is
   defined after the common header file includes the ARCH header
   file, where phys_to_nid has attempted to use "MAX_NUMNODES".
   This error was resolved when we moved the definition of
   "MAX_NUMNODES" to x86 ARCH header file. And we reserve the
   "MAX_NUMNODES" definition in common header file through a
   conditional compilation for some architectures that don't
   need to define "MAX_NUMNODES" in their ARCH header files.
2. error: wrong type argument to unary exclamation mark.
   This is because, the error-checking code contains !node_data[nid].
   But node_data is a data structure variable, it's not a pointer.

So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
enable the two lines of error-checking code. And fix the left
compilation errors by replacing !node_data[nid] to
!node_data[nid].node_spanned_pages.

Because when node_spanned_pages is 0, this node has no memory,
numa_scan_node will print warning message for such kind of nodes:
"Firmware Bug or mis-configured hardware?".

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v1 -> v2:
1. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid.
2. Adjust the conditional express for ASSERT.
3. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86.
4. Use conditional macro to gate MAX_NUMNODES for other architectures.
---
 xen/arch/x86/include/asm/numa.h | 6 +++---
 xen/include/xen/numa.h          | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index bada2c0bb9..1f268ce77d 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -4,6 +4,7 @@
 #include <xen/cpumask.h>
 
 #define NODES_SHIFT 6
+#define MAX_NUMNODES    (1 << NODES_SHIFT)
 
 typedef u8 nodeid_t;
 
@@ -26,7 +27,6 @@ extern int compute_hash_shift(struct node *nodes, int numnodes,
 extern nodeid_t pxm_to_node(unsigned int pxm);
 
 #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT))
-#define VIRTUAL_BUG_ON(x) 
 
 extern void numa_add_cpu(int cpu);
 extern void numa_init_array(void);
@@ -62,9 +62,9 @@ extern struct node_data node_data[];
 static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr)
 { 
 	nodeid_t nid;
-	VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize);
+	ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize);
 	nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; 
-	VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); 
+	ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages);
 	return nid; 
 } 
 
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 7aef1a88dc..91b25c5617 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -10,7 +10,9 @@
 #define NUMA_NO_NODE     0xFF
 #define NUMA_NO_DISTANCE 0xFF
 
+#ifndef MAX_NUMNODES
 #define MAX_NUMNODES    (1 << NODES_SHIFT)
+#endif
 
 #define vcpu_to_node(v) (cpu_to_node((v)->processor))
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 09:30:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 09:30:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307117.522411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNhu-00079x-CK; Mon, 18 Apr 2022 09:30:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307117.522411; Mon, 18 Apr 2022 09:30:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngNhu-00079q-6W; Mon, 18 Apr 2022 09:30:06 +0000
Received: by outflank-mailman (input) for mailman id 307117;
 Mon, 18 Apr 2022 09:30:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngNhs-00070f-L4; Mon, 18 Apr 2022 09:30:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngNhs-0001zB-Gr; Mon, 18 Apr 2022 09:30:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngNhs-0006uN-5D; Mon, 18 Apr 2022 09:30:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngNhs-0006y9-4k; Mon, 18 Apr 2022 09:30:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dGGfHbl2qlIrfj7F/rSzZrcLmHgHcfL4HcrDrVshfRA=; b=oRGZkLA6TQa8msqDvOyHkORFhv
	lxcSdoM66VUuJM+IOIgMTr8kL2m2vzbAiKZ7vrb975UbAdyL6QxXtxNPthn/KWfhmdHr33t2T5E6G
	S5f+gC+aHPESJsknVTaiBZ9ajbWH2dCxA+I5V7+YeyjqDTaYafnyLb+KN+MVk3VtG//s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169506-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169506: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 09:30:04 +0000

flight 169506 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169506/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  476 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   52 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 10:08:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 10:08:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307129.522422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngOJD-0002XH-V7; Mon, 18 Apr 2022 10:08:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307129.522422; Mon, 18 Apr 2022 10:08:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngOJD-0002XA-R1; Mon, 18 Apr 2022 10:08:39 +0000
Received: by outflank-mailman (input) for mailman id 307129;
 Mon, 18 Apr 2022 10:08:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngOJC-0002X0-GB; Mon, 18 Apr 2022 10:08:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngOJC-0002hk-8q; Mon, 18 Apr 2022 10:08:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngOJB-0007oX-Q7; Mon, 18 Apr 2022 10:08:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngOJB-0005Fw-Pg; Mon, 18 Apr 2022 10:08:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tGJ5YxZClYrg680yhAjZlEHLkyb+lWPvw/lSjqVMOik=; b=yZGwgR1pr+DbMeauZ29ij/b2Xs
	X2f1c1pllu1IWBG5pL/E7hv9JFD5lQ5lUnDLwijUyVaWkoaZkPilKsnCZZQdMA4hy55D04eNo/bpx
	eMpbAlVC2xRcWBN7v5E/TZM8CglsO2vekssPD3zKX5mAO/V2LHYwVHfDOpILT7VIlGM0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169499-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169499: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 10:08:37 +0000

flight 169499 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169499/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169472
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169472
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169472
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169472
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169472
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169472
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169472
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169472
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169472
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169472
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169472
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169472
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647

Last test of basis   169499  2022-04-18 01:52:00 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 10:14:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 10:14:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307138.522433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngOP7-00042e-LY; Mon, 18 Apr 2022 10:14:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307138.522433; Mon, 18 Apr 2022 10:14:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngOP7-00042X-Ht; Mon, 18 Apr 2022 10:14:45 +0000
Received: by outflank-mailman (input) for mailman id 307138;
 Mon, 18 Apr 2022 10:14:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngOP6-00042N-Cq; Mon, 18 Apr 2022 10:14:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngOP6-0002oT-AC; Mon, 18 Apr 2022 10:14:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngOP5-0007xA-Tb; Mon, 18 Apr 2022 10:14:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngOP5-0000Nn-TB; Mon, 18 Apr 2022 10:14:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Yv+jG6vSaE1bMG6c2IYL73r3hR5gEOc6z7gSjhzhzFo=; b=aUaac2113ZfM20eeNV8Q50/a/1
	YtYZOKz2342pIIxTTeMpVulek5kJFPxvFGVPOC86yXY1xBmvcfgIEvKrNeJoDpvlVr4sYrw6+AvMD
	9EPJkrrOpmpG5JtQqL4qK/oUgYaS6QGiw9eMEb5rTZQGqaMmnjMrUWuts3qAd+SVrpnY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169508-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169508: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 10:14:43 +0000

flight 169508 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169508/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   48 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  477 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   53 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 10:21:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 10:21:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.306957.522443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngOVy-0005cU-Jq; Mon, 18 Apr 2022 10:21:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 306957.522443; Mon, 18 Apr 2022 10:21:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngOVy-0005cN-Gp; Mon, 18 Apr 2022 10:21:50 +0000
Received: by outflank-mailman (input) for mailman id 306957;
 Mon, 18 Apr 2022 06:19:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9uw9=U4=gmail.com=eng.alaamohamedsoliman.am@srs-se1.protection.inumbo.net>)
 id 1ngKjU-0000EQ-CW
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 06:19:32 +0000
Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com
 [2a00:1450:4864:20::329])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 821ff2cc-bedf-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 08:19:31 +0200 (CEST)
Received: by mail-wm1-x329.google.com with SMTP id
 m15-20020a7bca4f000000b0038fdc1394b1so7689823wml.2
 for <xen-devel@lists.xenproject.org>; Sun, 17 Apr 2022 23:19:31 -0700 (PDT)
Received: from alaa-emad ([197.57.90.163]) by smtp.gmail.com with ESMTPSA id
 q16-20020a1ce910000000b0038eabd31749sm13992199wmc.32.2022.04.17.23.19.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 Apr 2022 23:19:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 821ff2cc-bedf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=TpWXWlsIiwFWqITQBBmHqt+ptX9YU3vyMz2FKFbBljI=;
        b=KVf+4C/PtpEfuB/Nxd/EYlIv9rV9YIYR3O2bMQguZFWKge/IUlTq8vQWAZQe8oiaVp
         tSbS/pFY1PvpYzcU3FT9E8BRiWtfFu5LHlsOjEmoAi7ACi+Iy1ESCvvP4miqPbcT8X8j
         fFiFpDshwNnmiXZ11QLg/k9C528xaqqbPLvtDAIxe/C2/xIV1DalMdAup68C2N13YvlV
         +Euy8Huqd/3jlzskYYaJTeN7QjGP7T0lPwSx0WQmyKkF0TicIgSgJVnDmChDfq/cmVJu
         wBFN3wCYNC2QFtJ8ZvakpGXI6GS2j/tdOF/sDc/nVPvMpu2Xh1aU376/LhlyUkX967ky
         Psrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=TpWXWlsIiwFWqITQBBmHqt+ptX9YU3vyMz2FKFbBljI=;
        b=nQOamLNyOA7+UquH6h26jFU3EaxFH+qFlKYY8UstLNYgqen7ZDm47z7yvccx1jsAN6
         lCQM5B/Exg6iwMyQAMXPtLuFxv5HWkolYTgRmzdL/ueJ3cuIWwGeu7DlxkR3Zfu5Kzhy
         IA/C7KkZSVQbJGEihPmtHfldFY669RqfXcTf/na3Ho2Ybm4emTD1SeBZaU3wLNnCFOch
         GS0pnVJ2fh0PX/7yJU9rSRaOXhRO7aX0rDi9vtrroXXghNmJxskgxeA/pQOC8xg18nko
         0IVk6UY+H2cxG6m3vou7WxD4jCGV9WI/0sknQUlenyJheoBelt1xnrVKmNY8batZyyeY
         VSqQ==
X-Gm-Message-State: AOAM532a3zddnfM2YjogP0lWL4CrtkeTHx4cYOaf9/yw3qQy87AsfdFU
	4D81iNAcnIiCdRfr/2mHVpU=
X-Google-Smtp-Source: ABdhPJyZ1HNParLvvy4rzpznCl7QS81uDSoiwV8fB4OIS0XVE5dQ8FZK+15fz5DY06IYoRqXJpCRHw==
X-Received: by 2002:a05:600c:4f87:b0:392:9236:3c73 with SMTP id n7-20020a05600c4f8700b0039292363c73mr5367903wmq.158.1650262770786;
        Sun, 17 Apr 2022 23:19:30 -0700 (PDT)
From: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
To: outreachy@lists.linux.dev
Cc: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	ira.weiny@intel.com,
	eng.alaamohamedsoliman.am@gmail.com
Subject: [PATCH] xen: gntalloc.c:  Convert kmap() to kmap_local_page()
Date: Mon, 18 Apr 2022 08:19:27 +0200
Message-Id: <20220418061927.6833-1-eng.alaamohamedsoliman.am@gmail.com>
X-Mailer: git-send-email 2.35.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The use of kmap() is being deprecated in favor of kmap_local_page()
where it is feasible.

With kmap_local_page(), the mapping is per thread, CPU local and not
globally visible. Therefore __del_gref() is a function
where the use of kmap_local_page() in place of kmap() is correctly
suited.

Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
 drivers/xen/gntalloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c
index 4849f94372a4..55acb32842a3 100644
--- a/drivers/xen/gntalloc.c
+++ b/drivers/xen/gntalloc.c
@@ -178,9 +178,9 @@ static void __del_gref(struct gntalloc_gref *gref)
 	unsigned long addr;
 
 	if (gref->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) {
-		uint8_t *tmp = kmap(gref->page);
+		uint8_t *tmp = kmap_local_page(gref->page);
 		tmp[gref->notify.pgoff] = 0;
-		kunmap(gref->page);
+		kunmap_local(tmp);
 	}
 	if (gref->notify.flags & UNMAP_NOTIFY_SEND_EVENT) {
 		notify_remote_via_evtchn(gref->notify.event);
-- 
2.35.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 11:00:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 11:00:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307154.522455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngP6f-0000kx-Jf; Mon, 18 Apr 2022 10:59:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307154.522455; Mon, 18 Apr 2022 10:59:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngP6f-0000kq-GD; Mon, 18 Apr 2022 10:59:45 +0000
Received: by outflank-mailman (input) for mailman id 307154;
 Mon, 18 Apr 2022 10:59:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngP6d-0000kW-Ui; Mon, 18 Apr 2022 10:59:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngP6d-0003Xe-Rc; Mon, 18 Apr 2022 10:59:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngP6d-0000XA-CU; Mon, 18 Apr 2022 10:59:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngP6d-00039E-C2; Mon, 18 Apr 2022 10:59:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KGrTOa4DB4gwFIPeSF28E+nLQZ6QdpSi+XngvUSJEcI=; b=xnDqEBPoIF5gr31GXmTRU2qFHa
	qpLF7RbILK8EqhTsRJhqZzmQRj7VQbMBmB7JrExPWtug3RVM7c3f/05RVdgxQIMLL8dCfbSms3uSE
	SqFdeA2gq/WWWvsfYtiQgZhOkYzJPLLANIKba2jpToIAsYA5+lCVzxvzZ+YBf3luO9Io=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169495-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169495: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b2d229d4ddb17db541098b83524d901257e93845
X-Osstest-Versions-That:
    linux=3a69a44278a72e15f12e24f5db4d277a497649aa
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 10:59:43 +0000

flight 169495 linux-linus real [real]
flight 169507 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169495/
http://logs.test-lab.xenproject.org/osstest/logs/169507/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm       8 xen-boot            fail pass in 169507-retest
 test-armhf-armhf-libvirt-raw 12 debian-di-install   fail pass in 169507-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 169507 like 169488
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 169507 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 169507 never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 169507 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169488
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169488
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169488
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169488
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169488
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169488
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169488
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                b2d229d4ddb17db541098b83524d901257e93845
baseline version:
 linux                3a69a44278a72e15f12e24f5db4d277a497649aa

Last test of basis   169488  2022-04-17 17:09:36 Z    0 days
Testing same since   169495  2022-04-17 23:10:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Boris Ostrovsky <boris.ostrovsky@oracle.com>
  Juergen Gross <jgross@suse.com>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   3a69a44278a7..b2d229d4ddb1  b2d229d4ddb17db541098b83524d901257e93845 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:03:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:03:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307179.522465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQ6I-0008Fz-Ed; Mon, 18 Apr 2022 12:03:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307179.522465; Mon, 18 Apr 2022 12:03:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQ6I-0008Fs-Bh; Mon, 18 Apr 2022 12:03:26 +0000
Received: by outflank-mailman (input) for mailman id 307179;
 Mon, 18 Apr 2022 12:03:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngQ6H-0008Fi-23; Mon, 18 Apr 2022 12:03:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngQ6H-0004fR-0z; Mon, 18 Apr 2022 12:03:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngQ6G-0001v9-MB; Mon, 18 Apr 2022 12:03:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngQ6G-000894-Li; Mon, 18 Apr 2022 12:03:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QjJQDu9YXmu5BYgzSVkpKQxVAbPn3IqcNJOIDWNihXI=; b=XtQhfiasmvxTPxQ0J7MQAcVddX
	0F592euaJJd4LYHGd+9m6/KDooI2q04fblDktO2svbRkLJn1JXEgiPJNnY/8efJaTQTp0gZaPZ88G
	PoNLoqIXTIDjl20jQUhLHYX6pOGsIpxJ3PajtEZJaAkTVb1xsKACd8zsTJidX3RDKVQU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169509-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169509: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 12:03:24 +0000

flight 169509 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169509/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  478 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   54 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:23:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:23:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307189.522476 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQPm-0002KG-44; Mon, 18 Apr 2022 12:23:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307189.522476; Mon, 18 Apr 2022 12:23:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQPm-0002K9-0t; Mon, 18 Apr 2022 12:23:34 +0000
Received: by outflank-mailman (input) for mailman id 307189;
 Mon, 18 Apr 2022 12:23:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UkN/=U4=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngQPl-0002K3-2v
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 12:23:33 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20606.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::606])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5aca533a-bf12-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 14:23:30 +0200 (CEST)
Received: from AM6PR10CA0105.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::46)
 by DB6PR0801MB1621.eurprd08.prod.outlook.com (2603:10a6:4:39::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:23:23 +0000
Received: from AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8c:cafe::27) by AM6PR10CA0105.outlook.office365.com
 (2603:10a6:209:8c::46) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT042.mail.protection.outlook.com (10.152.17.168) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:22 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Mon, 18 Apr 2022 12:23:22 +0000
Received: from a8f67386c85d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F57D3D2B-A9CB-4177-B502-625DCAB600EC.1; 
 Mon, 18 Apr 2022 12:23:15 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8f67386c85d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 12:23:15 +0000
Received: from AS9PR06CA0096.eurprd06.prod.outlook.com (2603:10a6:20b:465::25)
 by VE1PR08MB5054.eurprd08.prod.outlook.com (2603:10a6:803:10d::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Mon, 18 Apr
 2022 12:23:13 +0000
Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:465:cafe::3d) by AS9PR06CA0096.outlook.office365.com
 (2603:10a6:20b:465::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:13 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:12 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 12:23:03 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5aca533a-bf12-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0jEisy1eATjqY9YTsVOUYfJAJGD5K6BvzhFoHMEHvwc=;
 b=Aurocu2ta85DIMxDSXdWrUAVExaSkmxjbRbewCZrPD7yUpwb4SX3HLuyOmeN1nz0cJHLe/FSj8u34xZPejW3uTvM5gvZnJ5wMI6YnE+JSDGN0XGK1r9JbV65Tar+bACmn4lPOf19eJdLH2/715iD96vv9G7aby+2UjtV4PvpdNk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 83e03bd944504bf7
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aFpVpHDXLh79SvgSwqlheMNes2IiWkmVApWwBntPZeWiydOhQ+i7V9R3QvCs+aCniK9YL0aHFAG4tU1ixyoYl04RWBc5YDyNM1s+29ifCoDk8OztJL+OwakHo7O99LAx+BtibUqwyGgJHmbfYpihiiNfuk8GCme0/WtA9Gzx45meVKovbYczV999OWJl+3qIL3/QP7BIeVXXWQKHuX63K661Poiiw91GKzo8ATvG3kBme61rV41uNVJKwkBwi7A2FH1vouMw7Pas+iDnF/Jv9sN18iuUl6BuLk0PBWPY8I/LBiZ21Khvk3IjTkS/7frbpnZ1HiEynqIlhe5kLQTqOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0jEisy1eATjqY9YTsVOUYfJAJGD5K6BvzhFoHMEHvwc=;
 b=SnUfKrv6eu7bgl2oSQ1tRSBMOJJ6lRC2Jrl7PrEHkdP2qrJGI4FisRn4ccrTbNkp1IOar4OqS2Xv2euRCiSX2ECQhWjUPwY1rXOSvEEyGBQvRA2DOvMkR3pZwADaXXlG+aVn/ApsdvW2Xfx31MGjCkPXpqYcKRPOr78G1rKoURPQQpK6d7Z1WQgsjIPo7rWKh0Jg93oFp1T/KN/lzhDB8AWjTGNGkFiPnYKrJQMIsNmQ8NHiq0LP8EEfF9ADg0FqIL5tQ6+9Sne37gRbnUGbtbKAHFQmFQQVfFde9AEmj8jj/0PHEttKy8mvpAvntNDSAVW0ib8bc+C/Y6XZKzHXsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0jEisy1eATjqY9YTsVOUYfJAJGD5K6BvzhFoHMEHvwc=;
 b=Aurocu2ta85DIMxDSXdWrUAVExaSkmxjbRbewCZrPD7yUpwb4SX3HLuyOmeN1nz0cJHLe/FSj8u34xZPejW3uTvM5gvZnJ5wMI6YnE+JSDGN0XGK1r9JbV65Tar+bACmn4lPOf19eJdLH2/715iD96vv9G7aby+2UjtV4PvpdNk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH V2 0/6] populate/unpopulate memory when domain on static
Date: Mon, 18 Apr 2022 20:22:45 +0800
Message-ID: <20220418122251.3583049-1-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 3a7e17bb-2b4f-4aa9-7291-08da21363b09
X-MS-TrafficTypeDiagnostic:
	VE1PR08MB5054:EE_|AM5EUR03FT042:EE_|DB6PR0801MB1621:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0801MB1621FD995E04EBB8419A0371F7F39@DB6PR0801MB1621.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 FlW3t7DM/7MFyp9HnD0kqQqPgbXIskpZNCoedInVbj8GUhxv4p9YulCweRInId8muHqJ2IwychS/PM6QpJBv93Z/e3pSs0Rh4Csuf4Qtx7x4JcWuSKCGEpjS4klzmcUAZj4GG7FsCnlXzr9K8Vrq+PAT/WffWYbId9jRk6gJl3HKwMptNjbsTxTQpneulhonjnrs4XXX4Z5jzhOXY0FUfcRkJqQTVUYqkBX5S99heNHBpgRLRYMiJEXcAKebpLOpg1dMYz2IRNWM+XBrrf7WuZ1IZZ29+sUlDWCksvOJ/+UX3Qd9Zm6HVGHe1QkpqATEfmGm8UOiTX3o+Ntjx086hdehKDN/8Xh7s2t1OkmgynErxIJN1USZRgpu/dSYdwEnRY1vjhwGYAHRlP783kAlcILIgpTO9f2EEnehNMWG5jidQ5D4cJqcxib+6DSSGJlu/xIAh9FkHzYc1BClfCOQxBkQJWMNLuopG1cAunXvj8sy9Pyh8SjriqTh1YolDFnVY4p9xX766w2vrgIYJfR5i/R9lHiml6NomDG7YPhIMC0LEmpgG2HM0PlVdisZhm5KcSt5RiPYRQue7tUpHmjkRXI4Hb/pyVNCJ6jAymZQW/PHtBC5lBLqT/CeTdEjkyasXtZcQobFnvhckZig9Hcdcxfop4IO2Wa8/uZSuveG3aVS+ngMO2UUkQDgU6c8RBCYekIZJuAQwX8JfjxN1VDv/g==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(47076005)(2906002)(356005)(81166007)(4326008)(70206006)(8676002)(5660300002)(70586007)(8936002)(36756003)(26005)(36860700001)(86362001)(54906003)(7696005)(83380400001)(508600001)(6916009)(336012)(186003)(426003)(2616005)(6666004)(1076003)(316002)(82310400005)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5054
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f14227bc-b6f5-43dc-201d-08da213634fd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uHzrKeS4/JkxH2yQVzDD9VtQL0rHl+qVYOjUXTLjfIPLd1u+VI2q1hG4Y8dAJtoMLhdP4UysPvvAxmobFSvhErNXyZcaKQFR8IxatYyD4EM76iFyqtYiyXQU6KQP5g/0gjUpxIzehSmbAP6OCBVL80LLqcyzM7plkfO/wilhDFXR8/x791AOgo/CdgaEdCUC64ZyIjnpgmpfQOH/OwIqUX5AHQRO6BPTwPA0qxAKE6Yw8Y+y+vGX/yrR1U+HknQ0QH+nQxI5YJBotw5LVaFTQbcXktcK2PfBpKujzorcOzOFAWcOo/t1HUtXWX7XlE/Cm8+GFRdx7tmnF2MaFCaXDbRPDSgIaSriBFzNUezs5ARmCWvgXAIkVK/xv9hOiqqTaj1zSLvNVgKRmlW4zFHHF0h7eOKiwZYzO0aIv08dpRwCMpQjummF+kbqApXnDuNG/JFJBO35InmPI654CJINUGszAlRANLqZqBkLQW3E8jyOeNu1F+UXE8kjYmzmAzbSRvO5hUldpskNBaXm6lMrqMSMot4E3StCcb7ovQ8M0L2DSMpJrBVWIXmUzQItMet7cQgc+sTrZOjubFSDXMKgkKjJXr9ywuelE7Pgj6kyuaHFEUso0b389lrOSEiww8il4QNVbaaAOu8XoPwhz7JfwrjuYEXwXjt/mOVqKB/8a1Q=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(5660300002)(6666004)(2906002)(7696005)(8676002)(336012)(86362001)(1076003)(107886003)(2616005)(26005)(186003)(47076005)(426003)(83380400001)(508600001)(8936002)(6916009)(4326008)(54906003)(81166007)(316002)(36756003)(36860700001)(70586007)(82310400005)(70206006)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 12:23:22.8143
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a7e17bb-2b4f-4aa9-7291-08da21363b09
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1621

Today when a domain unpopulates the memory on runtime, they will always
hand the memory over to the heap allocator. And it will be a problem if it
is a static domain. Pages as guest RAM for static domain shall always be
reserved to only this domain and not be used for any other purposes, so
they shall never go back to heap allocator.

This patch serie intends to fix this issue, by adding pages on the new list
resv_page_list after having taken them off the "normal" list, when unpopulating
memory, and retrieving pages from resv page list(resv_page_list) when
populating memory.

---
v2 changes:
- let "flags" live in the struct domain. So other arch can take
advantage of it in the future
- change name from "is_domain_on_static_allocation" to "is_domain_static()"
- put reserved pages on resv_page_list after having taken them off
the "normal" list
- introduce acquire_reserved_page to retrieve reserved pages from
resv_page_list
- forbid non-zero-order requests in populate_physmap
- let is_domain_static return ((void)(d), false) on x86
- fix coding style

Penny Zheng (6):
  xen/arm: do not free reserved memory into heap
  xen/arm: do not merge reserved pages in free_heap_pages()
  xen: add field "flags" to cover all internal CDF_XXX
  xen/arm: introduce CDF_staticmem
  xen/arm: unpopulate memory when domain is static
  xen/arm: retrieve reserved pages on populate_physmap

 xen/arch/arm/domain.c             |  2 --
 xen/arch/arm/domain_build.c       |  5 +++-
 xen/arch/arm/include/asm/domain.h |  5 ++--
 xen/arch/arm/include/asm/mm.h     | 17 +++++++++++++
 xen/common/domain.c               |  7 ++++++
 xen/common/memory.c               | 29 ++++++++++++++++++++++
 xen/common/page_alloc.c           | 40 +++++++++++++++++++++++++++++--
 xen/include/xen/domain.h          |  2 ++
 xen/include/xen/mm.h              |  1 +
 xen/include/xen/sched.h           |  9 +++++++
 10 files changed, 110 insertions(+), 7 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:23:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:23:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307190.522488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQPu-0002d1-DC; Mon, 18 Apr 2022 12:23:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307190.522488; Mon, 18 Apr 2022 12:23:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQPu-0002cu-92; Mon, 18 Apr 2022 12:23:42 +0000
Received: by outflank-mailman (input) for mailman id 307190;
 Mon, 18 Apr 2022 12:23:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UkN/=U4=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngQPs-0002c3-Qa
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 12:23:40 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0604.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::604])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f1db000-bf12-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 14:23:39 +0200 (CEST)
Received: from AM6P192CA0005.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::18)
 by VI1PR08MB4208.eurprd08.prod.outlook.com (2603:10a6:803:ec::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:23:33 +0000
Received: from AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:83:cafe::85) by AM6P192CA0005.outlook.office365.com
 (2603:10a6:209:83::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT063.mail.protection.outlook.com (10.152.16.226) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:32 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Mon, 18 Apr 2022 12:23:32 +0000
Received: from 004be2d42b56.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A3F84FA2-5A5B-42EB-8079-4A7752AE7F25.1; 
 Mon, 18 Apr 2022 12:23:26 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 004be2d42b56.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 12:23:26 +0000
Received: from AM6P193CA0094.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::35)
 by VI1PR08MB4623.eurprd08.prod.outlook.com (2603:10a6:803:b8::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Mon, 18 Apr
 2022 12:23:22 +0000
Received: from VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:88:cafe::c1) by AM6P193CA0094.outlook.office365.com
 (2603:10a6:209:88::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.21 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:22 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT019.mail.protection.outlook.com (10.152.18.153) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:21 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 12:23:20 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f1db000-bf12-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VsBClypD3Wkaou4TbtLWlS8ixNFn1OaoB4eWjjlhZLY=;
 b=XMw0DXRrIiWYDMUlgcUxvWzO33jcuxIrFxUjIkIQG5KMtYpwgB5d7bk/BBXBcoNNEoqvDibZML0a+4lOZuShhHz+RN2vcQDx7gwKCM5BmNgLVvya0Dc8bDInoJcrRXOb3OzY9mgrP++nCqUy4WZAzVC2U3qhTRuUSPiecy/RSNA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f18c35403e40e7b4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TuWLliA54m3uLQnWMXGz6AaT4+4IEDItBQEgMCFMI+T7TvHa+HSCO3e3oso/c2LMtJgjplY/qjSRfWnQsaWEuLgzHVOO+sSwyFU+TBLw5YvfNkHrAAcrW1bDb0Bl1frXB4ukKe9YAs6NoFFbTWo65RxfV/76Aji+DBfeUwWr/cfMDQr/hSph2/pnC5gosJoBZuurLG96O8zR9fAq8AMFdx6u6Ch2fdcJii9TYW9RqmJsA827LHHG45wQiCFxNDdVe5AnvRq8x3zuFqUbvr5ndorsNXDrQUNL2Gyok4ir4nQ5xdZONgbkzocWw8w0S1vqmxQjxM6iPJ1Mz/XqoLwvaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VsBClypD3Wkaou4TbtLWlS8ixNFn1OaoB4eWjjlhZLY=;
 b=Z+4r/H9JyyeKjnw2euYP1/ozHcE8Dn0p/X6hHcUceeq64JrOD7VzCQkAcuOLxy4i/w9aFgSXLKgMQ3xHv1NTF76U2NJnbzP27TnmIIbmxUv9buyD3g6R2k3HdijN2ik2oW6zRD7/KK+xrsOXcO0c0ebtS9FOM9Ny+OCvfRlLHVNVa/TtuA49xQ01aGKl3R78p8aHFIWSCo9h+fWFB9+ys3tRBy1qUkx/KMwt54gNnipDTl9rc26C/1LIQa74FbaZK6FH435rDTdgK7cRCzO8nG/jvv6ph3TN8U1XbNUClBAWIW6QT1iZcHq+nsauDk7cFVDqJuNMl9Jm1ftpfvrj2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VsBClypD3Wkaou4TbtLWlS8ixNFn1OaoB4eWjjlhZLY=;
 b=XMw0DXRrIiWYDMUlgcUxvWzO33jcuxIrFxUjIkIQG5KMtYpwgB5d7bk/BBXBcoNNEoqvDibZML0a+4lOZuShhHz+RN2vcQDx7gwKCM5BmNgLVvya0Dc8bDInoJcrRXOb3OzY9mgrP++nCqUy4WZAzVC2U3qhTRuUSPiecy/RSNA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Penny Zheng
	<penny.zheng@arm.com>
Subject: [PATCH v2 2/6] xen/arm: do not merge reserved pages in free_heap_pages()
Date: Mon, 18 Apr 2022 20:22:47 +0800
Message-ID: <20220418122251.3583049-3-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418122251.3583049-1-Penny.Zheng@arm.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 345cdf11-6447-4125-6ccc-08da213640d1
X-MS-TrafficTypeDiagnostic:
	VI1PR08MB4623:EE_|AM5EUR03FT063:EE_|VI1PR08MB4208:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB42080EAA77F992417766AD19F7F39@VI1PR08MB4208.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DUe8vwslOtQMM3VjM/l2nefFS84nARDr4352AY8d4ixXR1jt8VzU5BCAuYzApb2eSw33RALJzy41Wb5AcCU8zhV/Qau4jxcrfsmh5FgqwALH9lYCnP80qc9m3IAeSF1EpSP3FH15i4/YMVDG467dennqFfy7u0TNz1auL7ZY/Qiq66HtLEW2luBCP4DB1V055GBEsoLmKF8ruPGI0/0qffSiX/kv1kpVDCYvYbOqQVFUnXXFksD906PG0x/dJzGHkTc7gf1ZUhh96jOFohJxFQ8aQhldn/viuBYW2Rix6XzYC3GkYvO2rYr6D2ML/M6bfI1iKKrLnH2aEXsVXzkugNd6SCrU56J7i5lezlj3Dw1WGT4j8pMiue8iReO3UqlcFTAXs3vaV5DQX+tT/t/2MIzgEnC1YkS02vAaBZ8w6vNADRkSWG8viJ6lS6z2fpYL1+5fCJ+ghKE+AJ0CcxBS4wO8TX9Vaq36+69TM1Ovg6oGMWoljzJYLZR0TUsxOKt/p+4i07liob0EOyo8bwoA0P+znRhJatS+A/0atNSxiLEjM+71cXPdxi2Ix/6HrW18CBeIkBOWi9WhUPcOKwh0lZeIUKCK1pIhF7vPu96t+mvBh7jMTQWiCBlhZTC3GyCNo4lQL28XJfaqVtkAQhdclqcUqe21jlr1N6VeKNh0k+6NI7Hmgguufxkw2o+PpqWD
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(83380400001)(8676002)(86362001)(4326008)(7696005)(70206006)(70586007)(82310400005)(2906002)(26005)(356005)(2616005)(508600001)(81166007)(36860700001)(36756003)(1076003)(6666004)(6916009)(54906003)(316002)(186003)(336012)(426003)(5660300002)(47076005)(8936002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4623
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	189f755d-ff31-45a7-38ca-08da21363a8e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uiPmoukHoBDPcPGxFpmKDJMBH42XjXn7BN7jd5XkIGQTtR/k7rpG9s/HBLhYyeY/WXlPdupVWps+GPyvUQuTL0bOpLxV0b+JKBxNvOmNzw+EYFFv9FG129tvDcAz+X81kfVrrf09eGjuBMSSxbtLGOKgkNMwIKCQxc7t46uTGh9rJ0UO8iuoqDbBMnESc1m88EwzAW/zFkFcHcROHsB98aADt2acSGb83hQG0K1RoMEBziZWxBh7BMfv4d2Fyvj7a7WOtJIEUVwVYfcv7+qh4d3hUV+j1bSOCc45FxB8w0Z+sMuXHUcFy+J39q/rSwbeXAWQxWT7QcHoRHFdeTFxuuTfHahp9e2VYmMHRZtx2L/WXOgDzR5FpLrfPYRJoXHJUoI4Ztxwc8qAEljkpGOdcJWj2I/6AQM/TugSW9HgpSQX7eVpu6BhJBRdwf17nbkzcj6HzREk0Wv5znvqmNTCEakWNy2y6gRNJON2ksMcB0TB+QK+kjU7sgUUOFV+QLuN/4Jtow8wgQTEDAnMJbEIGDzMuNOecm+ggdGIa6HCSEmshc7EnIsYu/7Kxw28ojRyfxQ7tyNkWC/JJXueNNk1QirpTHiDOpVuAlGfuU/N5R05Nxf2VAjJU6sNhQ0R/3e9gE04OwYKKHeN+ZWsH4747w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(6666004)(36860700001)(83380400001)(26005)(4326008)(54906003)(7696005)(47076005)(82310400005)(426003)(186003)(336012)(1076003)(2616005)(2906002)(5660300002)(8936002)(70586007)(70206006)(316002)(508600001)(6916009)(8676002)(36756003)(81166007)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 12:23:32.5138
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 345cdf11-6447-4125-6ccc-08da213640d1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4208

There is a slim chance that free_heap_pages() may decide to merge a chunk
from the static region(PGC_reserved) with the about-to-be-free chunk.

So in order to avoid the above scenario, this commit updates free_heap_pages()
to check whether the predecessor and/or successor has PGC_reserved set,
when trying to merge the about-to-be-freed chunk with the predecessor
and/or successor.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- new commit
---
 xen/common/page_alloc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 9a3e9c1328..8ba38bca9a 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1479,6 +1479,7 @@ static void free_heap_pages(
             /* Merge with predecessor block? */
             if ( !mfn_valid(page_to_mfn(predecessor)) ||
                  !page_state_is(predecessor, free) ||
+                 (predecessor->count_info & PGC_reserved) ||
                  (PFN_ORDER(predecessor) != order) ||
                  (phys_to_nid(page_to_maddr(predecessor)) != node) )
                 break;
@@ -1502,6 +1503,7 @@ static void free_heap_pages(
             /* Merge with successor block? */
             if ( !mfn_valid(page_to_mfn(successor)) ||
                  !page_state_is(successor, free) ||
+                 (successor->count_info & PGC_reserved) ||
                  (PFN_ORDER(successor) != order) ||
                  (phys_to_nid(page_to_maddr(successor)) != node) )
                 break;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:23:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:23:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307191.522499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQPv-0002u0-OB; Mon, 18 Apr 2022 12:23:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307191.522499; Mon, 18 Apr 2022 12:23:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQPv-0002ts-KZ; Mon, 18 Apr 2022 12:23:43 +0000
Received: by outflank-mailman (input) for mailman id 307191;
 Mon, 18 Apr 2022 12:23:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UkN/=U4=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngQPt-0002c3-JV
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 12:23:41 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0629.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::629])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 60e10c57-bf12-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 14:23:40 +0200 (CEST)
Received: from DB6PR0601CA0043.eurprd06.prod.outlook.com (2603:10a6:4:17::29)
 by AM0PR08MB5474.eurprd08.prod.outlook.com (2603:10a6:208:187::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Mon, 18 Apr
 2022 12:23:38 +0000
Received: from DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:17:cafe::14) by DB6PR0601CA0043.outlook.office365.com
 (2603:10a6:4:17::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:37 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT060.mail.protection.outlook.com (10.152.21.231) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:37 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Mon, 18 Apr 2022 12:23:37 +0000
Received: from a8fc1654a874.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C85D2999-8FFD-4078-A829-6B8863DA15D5.1; 
 Mon, 18 Apr 2022 12:23:30 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8fc1654a874.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 12:23:30 +0000
Received: from AS9PR06CA0110.eurprd06.prod.outlook.com (2603:10a6:20b:465::29)
 by DBBPR08MB4458.eurprd08.prod.outlook.com (2603:10a6:10:c8::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:23:16 +0000
Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:465:cafe::ed) by AS9PR06CA0110.outlook.office365.com
 (2603:10a6:20b:465::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:15 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:15 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 12:23:11 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60e10c57-bf12-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TVQetJuWhfla6PNj0JS8SWxjHJNlo5AFHEjQX+4a0Lw=;
 b=lNkNZueafa1r82+6Wfv37bHAv6HTYX35lMDpf2fvhu1TK0W6ZrFyqUdm5+3qZTFVEAzvIX/hE91eGSYYpOk9Ysu8dNb0LqPYIEr8Sh07ECoIFxKj3QX5Q1Cn7YZCR9ewOYMajMVAuQpnagSdOkadDpDJC0kBSH1gq22wAffb1vk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0c2d8033ba52ada8
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kpa8zWvqRKZa7pQ4AECf3K18vcoNb5ntfSm+zpqbZL5hRDwuV+iZJzoXJm5Gnjocek/CiyyUDTRKoRlfJlfXV9dg8MHcVLpV1040D7jYR3rWvmJ2qdpiMOuDOdLIrMjMIZ2ZFOxCDQ8HAuxg3MWKdSWlOiRF6UOAuhVzAc5D9OK78R+eR7XYLLq4Ed+uHVP6XRKXwfvBx42h/NkhtlpMlPsCBUaHyVmMmvFjnyiwlaoodhs8h2nIS9DKnBVBLR8jHpW0SFpsWNaBri0BqhcxNytA7GO8lBsADu+c5KPMeyetZ+b7wRCX+ogjdBfBya0lXH+YChyyiqrsHeIo+/TVFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TVQetJuWhfla6PNj0JS8SWxjHJNlo5AFHEjQX+4a0Lw=;
 b=UNIRTC2XwI+u7M9pj22U/BWjCPgq4tLdCIf3lPSFagSLsyBHOvGx8jbOXBoqLupIYWwZvX5q79kr1XAJhtGg/vV5fvaVQa9qa7+Ml9Q4xH29ZVxJwefqQ71lESrjAogxD7+ZjZd0of1FdG++OcKhp6kTDlElyjd1kcdMwZQj21AJjIKIX54zo34YVAGSheKw0YQkOyBXFLQEGwh+7+TDRqDiek9dwRfo78HFFCnQr5SkPUgPMGUNqjeCs99sUakaSrrq9xIUcv8bcpiDRV/Cpb6AqY1fhqMo4xflTK0SrgDnmP60ri94o1Zb7Ug1SMD36geKtzQdgq5ddEpPv5bpuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TVQetJuWhfla6PNj0JS8SWxjHJNlo5AFHEjQX+4a0Lw=;
 b=lNkNZueafa1r82+6Wfv37bHAv6HTYX35lMDpf2fvhu1TK0W6ZrFyqUdm5+3qZTFVEAzvIX/hE91eGSYYpOk9Ysu8dNb0LqPYIEr8Sh07ECoIFxKj3QX5Q1Cn7YZCR9ewOYMajMVAuQpnagSdOkadDpDJC0kBSH1gq22wAffb1vk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Penny Zheng
	<penny.zheng@arm.com>
Subject: [PATCH v2 1/6] xen/arm: do not free reserved memory into heap
Date: Mon, 18 Apr 2022 20:22:46 +0800
Message-ID: <20220418122251.3583049-2-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418122251.3583049-1-Penny.Zheng@arm.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 357b6f0c-3161-4241-ebea-08da213643b9
X-MS-TrafficTypeDiagnostic:
	DBBPR08MB4458:EE_|DB5EUR03FT060:EE_|AM0PR08MB5474:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB5474421C2DAA4BC26B9341FFF7F39@AM0PR08MB5474.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 IxurwQ1CQavmlIrI8U3eRmgIvuhwToBh/0G4jEjR9rFbOv8mq62GHuKZuV8nsJ1vqidLGwv4qEoZSrgW+5JpQ2nnf+4lh33mfW+KQnSofOIeZZyoac2ubh4pf+6dPqlIFmprhJUvLHb/TBA7hiQMVM93kNFIfCWVNlFP+jp3s/pnhVrkBJxepgFSblIzpbpWkoudyxqVNvQSxhI2n0sYbKvG0o1pV7x5kFSNiFXhIzEL/5kAxt1k0RrBVDun+J713vS6qDr6j1XhC+td5iPMEjewyIfpj2XZnVK0M3czcBUrmgWRSErzWlKTa5q+tyfVoF1qZy3w6Eghqp3vKubE7vOPq9Z3fFghEwZV/o6oedCG5CUKU5PQ9yYQXxtkrp7VdUBcM1QBxEr/eSpCVMlDjlT9/YkzIUhFWQbGlZkn3iDcuf2WdRATogMf5fq3vtvspK6e9px29f8VogdqJBhenNxm7LCuyy/aYBt/hqGyS3SWUAXixVe6fdZ7e3e2ysJpxRexB2ftWds5eNZDL+L5eXXfZ/5ehXfdP4HzavAqYu0Td6tJbKCm4RjsJ4slz0o1WkvJWUrNNcOjPmJSBuMaaB1Jzb1xwPhwQF2sQmrb9vIoTaO39xA5xZOYQqCc/l1nsbd6qyqMI1ZrNcCLFRXN9afbKLzmSZSORzY0NV4wrh/dbqu+Upzcv3HuSF+d1Awpbx48tiasp0Rp2OfUxxQZWA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(426003)(26005)(86362001)(36756003)(83380400001)(336012)(5660300002)(54906003)(356005)(70206006)(70586007)(186003)(6916009)(2906002)(6666004)(1076003)(2616005)(40460700003)(47076005)(7696005)(82310400005)(316002)(36860700001)(81166007)(4326008)(8676002)(8936002)(508600001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4458
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	231a9c3f-ecac-47a8-8f80-08da213636b8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jHMtAGm645GbQ8H4TlrlHTr1bQSbmtCY5Qu+1iUhmPr6Xn13WL0wuBI1ijkb048Qtchq5nuLIbpj6wxYzedV8ZhrZR673m2v4VL/YiPo+oNz/RXSgK6Fcf6gWtyYowvICgoEmDic5Q0PXo67QyB3H4/JYYUhD2OhbDtEetlKDNcVA843fBe5kzbf05GUNBUH9PykkQaVdxWVqycMUg60zTQOLsSVshXKMqbehc9kR5V7ndJNz02XGjJ8KLPqAiMg9Wed6jtA7p94GJxGcNgnFbHqSTmyvwQTo08RzeW+38laA/pCp7SytzpiElKigDx7eAsO1FYP+W6GSnCqHmu6XHIcIleKVxD3oWwZq4o7YuXmEbOmeQsxLyjSeZE/3H/Az5D4G4PBeEOv0G7vOD13XeyWcAfYUOIWKof2GMwARdkAZ7YziW3veP+1zlLsIZZKe33Y+n/vR1C4noa2QOPSdH504ddwbAEEo/YUNym1zkEdqL15xqviB9Bm2ESJd3ZHW2yqLEyYZ0HGdrB3BX0nH9BfUUAKCZsWqTosgnY1+tyfUoJ/HBYvKX0y6YSDlT9Iu9VsXbuXDn7Zr+C6vkXdHyyt0DVfHgwdIvz7ndQM7R52sVHwsB5p9Qs1vzsu3DYVmkL10os6qfWgLr1mAh5/HvxyMADX5+zzm1jJ1UVaAY+5Dkk33ei2c2Cm6n6usYHS
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(2616005)(1076003)(82310400005)(7696005)(2906002)(26005)(6666004)(86362001)(8936002)(336012)(426003)(47076005)(508600001)(186003)(40460700003)(316002)(5660300002)(83380400001)(6916009)(81166007)(54906003)(36756003)(70586007)(70206006)(4326008)(36860700001)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 12:23:37.4555
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 357b6f0c-3161-4241-ebea-08da213643b9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5474

Pages as guest RAM for static domain, shall be reserved to this domain only.
So in case reserved pages being used for other purpose, users
shall not free them back to heap, even when last ref gets dropped.

free_staticmem_pages will be called by free_domheap_pages in runtime
for static domain freeing memory resource, so let's drop the __init
flag.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- new commit
---
 xen/common/page_alloc.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..9a3e9c1328 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -2488,7 +2488,13 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
             scrub = 1;
         }
 
-        free_heap_pages(pg, order, scrub);
+#ifdef CONFIG_STATIC_MEMORY
+        if ( pg->count_info & PGC_reserved )
+            /* Reserved page shall not go back to the heap. */
+            free_staticmem_pages(pg, 1 << order, scrub);
+        else
+#endif
+            free_heap_pages(pg, order, scrub);
     }
 
     if ( drop_dom_ref )
@@ -2636,7 +2642,7 @@ struct domain *get_pg_owner(domid_t domid)
 
 #ifdef CONFIG_STATIC_MEMORY
 /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */
-void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
+void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
                                  bool need_scrub)
 {
     mfn_t mfn = page_to_mfn(pg);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:23:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:23:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307192.522509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQQ0-0003FG-1n; Mon, 18 Apr 2022 12:23:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307192.522509; Mon, 18 Apr 2022 12:23:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQPz-0003F7-Up; Mon, 18 Apr 2022 12:23:47 +0000
Received: by outflank-mailman (input) for mailman id 307192;
 Mon, 18 Apr 2022 12:23:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UkN/=U4=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngQPy-0002c3-E5
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 12:23:46 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on060a.outbound.protection.outlook.com
 [2a01:111:f400:fe05::60a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63f4bba1-bf12-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 14:23:45 +0200 (CEST)
Received: from AS8PR04CA0095.eurprd04.prod.outlook.com (2603:10a6:20b:31e::10)
 by AM0PR08MB4019.eurprd08.prod.outlook.com (2603:10a6:208:128::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:23:42 +0000
Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:31e:cafe::5f) by AS8PR04CA0095.outlook.office365.com
 (2603:10a6:20b:31e::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:42 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Mon, 18 Apr 2022 12:23:42 +0000
Received: from 38a061796f99.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 30740B92-F3AC-480E-8C36-58F0DADEA8C2.1; 
 Mon, 18 Apr 2022 12:23:35 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 38a061796f99.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 12:23:34 +0000
Received: from AS9PR06CA0498.eurprd06.prod.outlook.com (2603:10a6:20b:49b::24)
 by HE1PR08MB2892.eurprd08.prod.outlook.com (2603:10a6:7:30::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:23:33 +0000
Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:49b:cafe::9a) by AS9PR06CA0498.outlook.office365.com
 (2603:10a6:20b:49b::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:32 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:32 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 12:23:29 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63f4bba1-bf12-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uyBX+fsNkrz5HUOuaIVqm6IKexBIh5lxFql//sHUJM4=;
 b=vLA7Be18p24LEiOJS5tLPPWUKlFHVYaztq6P+wHHsznD1M9kSS/wbVuzMD1jhquag9RAF32Ih79iVW4HNZOYlIuzyLQwQKgtHWUYYriHOa+2bvQesQ33IQAlRKrtc6wNEcOCk4GqPUVEZzGpReDNomoDnvB6S7f+dm92KZWJ9TM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b53748e9b814031d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lm3HNdec7I7A5Zrn0/ClCUvK1ljQZTEn34QR8kILz2lNZbnYM2h/X0CJDXRjAlOhjDki8BdlSrksyhjw98X4Qv8PyG2EL5CHmhsyjE+LOU3Ku2U6jcfGMlMj+fto2qEaEgMMLy+gCH1wfyrjxcsZ6pA6v196k52xS7/61MIAliF9ur1UKtXR6sgZHVrHywdmiYiG/2WrcuNyGtvz7/WyZyJzVDpv/dTAISxsvTqHdYiSzTT63UOVJ0WeN8MmEnon1SQ4SJB6wgJXNQz9366EbX16t6dT4bOI2QgbY8y3aTToD40n/8uVSY3QtVRDzk/F1/YOJ+NnXRzb1iWfg94/Fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uyBX+fsNkrz5HUOuaIVqm6IKexBIh5lxFql//sHUJM4=;
 b=P/suv8TqTHF/CxyTi+2iJJiaDz4VnQaFX5mO36/viASAP6w/K0pdf/LBPm9VJABZa4dJvkTN43WtSLVgqBgZbWRRO4GbdL6giIWprbwY7swd+8OZDLXIdzWIm7ofDmf836mv6zEf5VeOmqFNfn2chXVZ6sGnRrhPnueDyVxCGHo4piE2Gji0z1A3muFgT8qiCLqzJ2Y+TUPue7+Kx9QVupji24SjDQvYigma9SYwZIa3VdHSsqcgDY3vxfdKvfVPR9NdoEJ6K/PUqBMQ+BsWA5yjWd3w/VQBAoWC+0JUcZaRRzTbys25RnzEFWa3u81ZTq0lb9IkzR+mtrj5BYr+UQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uyBX+fsNkrz5HUOuaIVqm6IKexBIh5lxFql//sHUJM4=;
 b=vLA7Be18p24LEiOJS5tLPPWUKlFHVYaztq6P+wHHsznD1M9kSS/wbVuzMD1jhquag9RAF32Ih79iVW4HNZOYlIuzyLQwQKgtHWUYYriHOa+2bvQesQ33IQAlRKrtc6wNEcOCk4GqPUVEZzGpReDNomoDnvB6S7f+dm92KZWJ9TM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Penny Zheng <penny.zheng@arm.com>
Subject: [PATCH v2 3/6] xen: add field "flags" to cover all internal CDF_XXX
Date: Mon, 18 Apr 2022 20:22:48 +0800
Message-ID: <20220418122251.3583049-4-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418122251.3583049-1-Penny.Zheng@arm.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: a5dcc233-7aa2-4a92-4021-08da21364697
X-MS-TrafficTypeDiagnostic:
	HE1PR08MB2892:EE_|AM5EUR03FT043:EE_|AM0PR08MB4019:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB401971B94B73290B39EA534DF7F39@AM0PR08MB4019.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 grONejuSOQg698IMeUKWD7yEXpzELpn6Y+M11a+Dc/JLxyLtEIDfRLpiOMDHP9EMu8oKMbeFNGd0c0FemCVgHiBshOX8K7CCl6rF7aktdQm+9DZNgiqAAvJCj53zq+hX1cFJht6ExMDZPzBfsHkEJo5KIPhXwITK6dqLCAzSSQgguxQXfjBkV79dWlyX6zY3XfBnIGFTzgxqZ1yD06ziXZQe8Z4HodpJRpai6ObJZrrZC7c8R9GlCe/YOdb99Ku/kpFd//b3Lab5wZTiJqMsdH3Q+RE+KdqdvriVnZyKUOWTUya1GfmgVDfesFJclYgjBeQ++xrWcaQuy41TbcLajQZtbxYt2Ybeo2yIa3RQ2z4Ifpq+EqopmVnURmg2NNWUhi8w1DvqeIVeYpyUQ6rhsScnOHE5D4s5w130Wif3f+lIknV+n/CBWWSs+3Mwitga7IpF79Cx2ukkdSut+JcqbnSALSN/eVXyssNZQB/HIIB2XydhrTZDnmxVhY2T57PQ4GZ5bv7TncA3dTnx3lKVmC2w1UUW9rz8JAPCmTBZnF8tqJ8kwJPhmUJDJhSmY037Bk7idRpiUmXdCxSKyO3Dzm2VavEgvGjCK3RpNEO7DV2YRXxWBNPU7uiOHY0Q8vKlC3fQXwdzdrXd3s4P71B3UdKO3FViiCe8uDC7IImvGTjj6lgwXvJ2A+qFlExAeSi6LfvfapI+GvuR1MUGusJGNKqye24usTxHFijxLeAZ4/s=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(356005)(1076003)(26005)(5660300002)(4326008)(36756003)(36860700001)(70206006)(83380400001)(81166007)(82310400005)(8676002)(70586007)(8936002)(54906003)(6916009)(2906002)(316002)(186003)(2616005)(40460700003)(7696005)(86362001)(6666004)(508600001)(336012)(426003)(47076005)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2892
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	59e0dada-653e-4a91-9d43-08da21364090
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	56Y2qAUXbbPHavPrlibf2hrbe0jXKcK+X4Vd89J4OgTeD002+Wy3I+RxwqQNb3WhcB7+1Q+fQshxk6mdTcS7OOc+JA6eIQ8xHVSoVgzrO4Ff9zhF/xIgsxrJ124PIuigO9gcIzWtJTE760D73rxp+vvxahX5wtjaXy1ACvpLBayKxl4nPOErRHrJeDiqgyP41PiXz6MCCsRUK5b4nncYIXtxiKtrgwNjk+L4tiJMhSsQLG34Gaydf6eBr0SnQO9+V+3s0Co3VEuQymja36sQw5i3i0Fa+gjIF05cF6s4wmDBHvjqJJGyLnGtbWdA/wt2EIZK5qwHGY6M81KfwNhG3Zs8elBzzAWfpeQOOyCYXVr/mrDYVHi1uBS+9FR4aceSE+pjpAGXVYxpynJN2lRPNvOTdfFgyQq6QRzPad/VrLs43WFDKWWbFk2i32NnHxlRAa303wZw7+573sUFo6Y6gM3wNHxT9ZPfPfwWmZIeOvRcVClHS+tMHejROL1Wy8e+0Km/ZTm+8NIIomn80Cqj7E+nzykTkum+IrooCFb/TVflBSZ4GQ/baCsEA92LCbWXecZA6nLzDx0hefssfv7tLsnDHCIgkzSahjoxyWI+uaQAUkwu5r5M2NfQRV3nl8Vh/lQ0f6tK+IzSqlBIh6l169PSsZj9PK1C+7Gnh3R28HZLy3tdD6Ca/B+znmmWs1vbJnp18xTHlCAXIw6Zn+wXBg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(8936002)(6916009)(40460700003)(54906003)(498600001)(6666004)(5660300002)(81166007)(83380400001)(36756003)(86362001)(2906002)(7696005)(8676002)(4326008)(82310400005)(26005)(70206006)(36860700001)(70586007)(1076003)(47076005)(2616005)(426003)(336012)(186003)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 12:23:42.1989
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a5dcc233-7aa2-4a92-4021-08da21364697
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4019

With more and more CDF_xxx internal flags in and to save the space, this
commit introduces a new field "flags" in struct domain to store CDF_*
internal flags directly.

Another new CDF_xxx will be introduced in the next patch.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- let "flags" live in the struct domain. So other arch can take
advantage of it in the future
- fix coding style
---
 xen/arch/arm/domain.c             | 2 --
 xen/arch/arm/include/asm/domain.h | 3 +--
 xen/common/domain.c               | 3 +++
 xen/include/xen/sched.h           | 3 +++
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 8110c1df86..74189d9878 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -709,8 +709,6 @@ int arch_domain_create(struct domain *d,
     ioreq_domain_init(d);
 #endif
 
-    d->arch.directmap = flags & CDF_directmap;
-
     /* p2m_init relies on some value initialized by the IOMMU subsystem */
     if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
         goto fail;
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index ed63c2b6f9..36ec00e62d 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -29,7 +29,7 @@ enum domain_type {
 #define is_64bit_domain(d) (0)
 #endif
 
-#define is_domain_direct_mapped(d) (d)->arch.directmap
+#define is_domain_direct_mapped(d) ((d)->flags & CDF_directmap)
 
 /*
  * Is the domain using the host memory layout?
@@ -103,7 +103,6 @@ struct arch_domain
     void *tee;
 #endif
 
-    bool directmap;
 }  __cacheline_aligned;
 
 struct arch_vcpu
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 351029f8b2..859cc13d3b 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -568,6 +568,9 @@ struct domain *domain_create(domid_t domid,
     /* Sort out our idea of is_system_domain(). */
     d->domain_id = domid;
 
+    /* Holding CDF_* internal flags. */
+    d->flags = flags;
+
     /* Debug sanity. */
     ASSERT(is_system_domain(d) ? config == NULL : config != NULL);
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index ed8539f6d2..68eb08058e 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -591,6 +591,9 @@ struct domain
         struct ioreq_server     *server[MAX_NR_IOREQ_SERVERS];
     } ioreq_server;
 #endif
+
+    /* Holding CDF_* constant. Internal flags for domain creation. */
+    uint32_t flags;
 };
 
 static inline struct page_list_head *page_to_list(
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:23:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:23:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307194.522521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQQA-0003uD-BM; Mon, 18 Apr 2022 12:23:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307194.522521; Mon, 18 Apr 2022 12:23:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQQA-0003u2-8A; Mon, 18 Apr 2022 12:23:58 +0000
Received: by outflank-mailman (input) for mailman id 307194;
 Mon, 18 Apr 2022 12:23:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UkN/=U4=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngQQ9-0002c3-0W
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 12:23:57 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0618.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::618])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a3a52f4-bf12-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 14:23:56 +0200 (CEST)
Received: from AM6PR0502CA0047.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::24) by VI1PR08MB2702.eurprd08.prod.outlook.com
 (2603:10a6:802:1e::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:23:51 +0000
Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::57) by AM6PR0502CA0047.outlook.office365.com
 (2603:10a6:20b:56::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:51 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:51 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Mon, 18 Apr 2022 12:23:51 +0000
Received: from e29f6da64349.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8820953C-0C6B-4FA7-A917-066E529E9D5C.1; 
 Mon, 18 Apr 2022 12:23:44 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e29f6da64349.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 12:23:44 +0000
Received: from AM6P195CA0018.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::31)
 by DB7PR08MB4603.eurprd08.prod.outlook.com (2603:10a6:10:75::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19; Mon, 18 Apr
 2022 12:23:40 +0000
Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:81:cafe::9a) by AM6P195CA0018.outlook.office365.com
 (2603:10a6:209:81::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:40 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:40 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 12:23:38 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Mon, 18
 Apr 2022 12:23:37 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a3a52f4-bf12-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1mDieelJvb1HIU1cidQRUGTfXl8e3DylFrqxsNNPrcs=;
 b=K4W6TSM7Alvw8B7lvq1YytYxHhz0/bzuCRtEbPw61p+RpBd6hmGGH+a4hYw8Bd02S1W2JpdubbwNpFMHY2wnu6D4qhBk9DL6kGgTHH4uorr+jpk8w98s6ldfj9uySK54ypm95+hzLiaEyZzPjT1rJJQnkHt9Z1yInvdZVZ+yqiw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1a1646ab449e3623
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kIhNxDcOmyaw4juOGJZ/GX+RK+qwmky0FL4/A6z1EaN7HyR0MrwTH2DN2Gut8Gk5Etek4mq+gpKK7Ajh+Qe5My/oQGdyqoYbNz6Gp7ZtTOfi+ET47OMAA9pd324bL34O5SL94qkIdnedaS5Sy09h2rBRDjVXK39Pc39HeJJexQltb75C9XPDdLhIYAGX4WPQbjqQGrQInhe5ntbdIW/VDLkcjchC00BpQAWGM0FuXNqHP/jTM7ZxCKdzr7s6jcqJ0R5n3nB3WoS1TPqzvMnrsWQvfzdwToIJm9gqDG0dpqmmJLcxZ/oinoHUw/NplfTGWYe4NwE65Q96Ayp9GHnxLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1mDieelJvb1HIU1cidQRUGTfXl8e3DylFrqxsNNPrcs=;
 b=b5ro8J7WQdbIDk9HVRgCQeZT4U6pwfxcKrAhEhf+cCg2ZAcuxpOdShABEMdAebwINiO1TJcURBBTLmEvZNuEwu0OJUpnuYGCSEQA5v6R3ar335wO641FqJaWDoNVjntVwTY/NHHaIvPxVqg0JoRM1/nRUHLa8jeN3YS7thnJPAJQtM2BdOQJIr/N0ptRbvXfzeL8XInglWeJOvyQ83k5ldJyVEm8t4f6Maz2IaQbOiRTmsnXsi1aDSt+z0xs01J1q0q8lhls9j7/W5x4NvSIGgLsP3oL9Yl5jZxEC4c8jxeeqw60/oW9Cmfj3VaCwuLKNnJ420VMrWABC/IKw15TEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1mDieelJvb1HIU1cidQRUGTfXl8e3DylFrqxsNNPrcs=;
 b=K4W6TSM7Alvw8B7lvq1YytYxHhz0/bzuCRtEbPw61p+RpBd6hmGGH+a4hYw8Bd02S1W2JpdubbwNpFMHY2wnu6D4qhBk9DL6kGgTHH4uorr+jpk8w98s6ldfj9uySK54ypm95+hzLiaEyZzPjT1rJJQnkHt9Z1yInvdZVZ+yqiw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Penny Zheng <penny.zheng@arm.com>
Subject: [PATCH v2 4/6] xen/arm: introduce CDF_staticmem
Date: Mon, 18 Apr 2022 20:22:49 +0800
Message-ID: <20220418122251.3583049-5-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418122251.3583049-1-Penny.Zheng@arm.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 44f5ffe0-a21d-4559-9e64-08da21364c28
X-MS-TrafficTypeDiagnostic:
	DB7PR08MB4603:EE_|AM5EUR03FT024:EE_|VI1PR08MB2702:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB2702005C6A0F34902ED78511F7F39@VI1PR08MB2702.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 1U7j5DI8E7i8W8LYObBaBcllMn07c/OAXFKyEWrUqp/yQOZkAfB1oGK9fiLnmLxUKlxjJwFf7t1n3ZkZcezdUEcWiCgug5z9N74WJBFRmyP40WLi+RF3EOrZugxCwRRbo3hx3fGRT/rFr9TnwBNjJWWfZbuLB3AtV+HMM7AvtrX/UvhOLCGHzBDmRXriSLPGw3st/Xavw/lokY5cv1l6Jr6YtTRjLV7NiuSpp8K4nlbTTM0tVgw+ry0HWupE8Uht63pULPQyC+GHs8e9U0Cxx4IP3h7qaVYDgfoAh9qTGHbQCI5XrfKLRIePJcqNelOCxLApk95IAcPEqbA8104PQ7+pf/qgctGje+4FLuhhdGd+8b7bvnck+qfQ2SvCXdS2FXINwljV5eG1LQwJEYuyb1hrp9Uy0ProogutF5z8o1sevxrhkk0SeWhVjNntCUSzOIiRxyZ9GybyP/farRiGyHOhrzaBqOwVRTa6EMsN+MnPOPMdYuMUjoaWdLM7UaRsxgNfE/LrGEhDbpfWQ1cudcRXamg8c1HabeQ1SOTl2BscKJ5Vh7J9N0t7GcQ/h6hJvg/xU6BnLq3DbCB5XOdCJ0/GVYJ0NCHlKcRrGMeNdXqfgpcBP22D3D9p+62GvSi/J+371XqRdp1/k0TeIKaGAGw/DLdFrsZduW91clMDnpXYkS8ErA5l4LDgMsIOWVYu
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(508600001)(83380400001)(8936002)(2616005)(2906002)(186003)(4326008)(8676002)(1076003)(70206006)(36756003)(70586007)(86362001)(6916009)(5660300002)(54906003)(81166007)(316002)(7696005)(26005)(6666004)(36860700001)(82310400005)(47076005)(426003)(336012)(356005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4603
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9742ef45-520a-4323-45ca-08da2136454f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cUK60Wv/Pa/9zpmPFYA9v4iGO4FAgdlJwb1oEbksgx4gbkgrze7GBqHLeg6lwht/z5pQZizPZcumxvwMItegwg0QM6nKM/2ke/JZiVpQN3ClHDm66V++ONgG97Ep2rCbN78Fw4vFBHVOTKWgMCILbGsKxrpBI0S0BWucPlzT+/Bvfo/Xth4aoCQbGnjz4IbuyOBPPlKqtIXx4VTVIo+CcANWJuLsqSNKUs5BhzuJkAolNp0jJSkMk07D99nJVg1VyFvWdXaXjJ1QuzUsYWMgQ/nQ3wYEUdLcKBk+8rW2luWunUmYjVpU0+CxW9pK8g1FU/jtlbpsRGyYwLrPLB9rBXL+qcxbASIL8mrv7jwBo2um2SHDhhf2Sf0qHGBeRTJacoP4eHceosOMM6RPohULK9x8x1bMqPrjbUM737/Tkoncp5SdZP4de7khVoSriUQDqV6q8vEC6IXY5cToMuflZsZIt3a4skO8NeDxfR0ag9DEkpqtDqJQ2GCAnlzMUW81XRaSlzx2XjyO5mp7z9zaL6c3EtUCfM6tfdWJn0ep80KcnZrpoRBUj42C/6VB6EQ7WrhRZriojoHI5N1Iy17nsL553SVRn5OhTDvbhrLK2WlpXS0XmzL+UCd2hyssTCDnpGJNWLgR59nGhDzFMjeHVA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(2906002)(47076005)(186003)(2616005)(8936002)(86362001)(6666004)(7696005)(83380400001)(508600001)(26005)(1076003)(336012)(426003)(4326008)(36756003)(36860700001)(70206006)(70586007)(5660300002)(316002)(8676002)(81166007)(82310400005)(54906003)(6916009);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 12:23:51.5402
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 44f5ffe0-a21d-4559-9e64-08da21364c28
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2702

In order to have an easy and quick way to find out whether this domain memory
is statically configured, this commit introduces a new flag CDF_staticmem and a
new helper is_domain_static to tell.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- change name from "is_domain_on_static_allocation" to "is_domain_static()"
---
 xen/arch/arm/domain_build.c       | 5 ++++-
 xen/arch/arm/include/asm/domain.h | 2 ++
 xen/include/xen/domain.h          | 2 ++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8be01678de..4e62fd0bf1 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3191,9 +3191,12 @@ void __init create_domUs(void)
         if ( !dt_device_is_compatible(node, "xen,domain") )
             continue;
 
+        if ( dt_find_property(node, "xen,static-mem", NULL) )
+            flags |= CDF_staticmem;
+
         if ( dt_property_read_bool(node, "direct-map") )
         {
-            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) )
+            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !(flags & CDF_staticmem) )
                 panic("direct-map is not valid for domain %s without static allocation.\n",
                       dt_node_name(node));
 
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index 36ec00e62d..b097433f9f 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -31,6 +31,8 @@ enum domain_type {
 
 #define is_domain_direct_mapped(d) ((d)->flags & CDF_directmap)
 
+#define is_domain_static(d) ((d)->flags & CDF_staticmem)
+
 /*
  * Is the domain using the host memory layout?
  *
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 1c3c88a14d..35dc7143a4 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -34,6 +34,8 @@ void arch_get_domain_info(const struct domain *d,
 #ifdef CONFIG_ARM
 /* Should domain memory be directly mapped? */
 #define CDF_directmap            (1U << 1)
+/* Is domain memory on static allocation? */
+#define CDF_staticmem            (1U << 2)
 #endif
 
 /*
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:24:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:24:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307205.522532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQQK-0004eM-Qa; Mon, 18 Apr 2022 12:24:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307205.522532; Mon, 18 Apr 2022 12:24:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQQK-0004d5-MP; Mon, 18 Apr 2022 12:24:08 +0000
Received: by outflank-mailman (input) for mailman id 307205;
 Mon, 18 Apr 2022 12:24:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UkN/=U4=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngQQJ-0002K3-Bb
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 12:24:07 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20621.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::621])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6e91ce18-bf12-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 14:24:03 +0200 (CEST)
Received: from AM6P193CA0060.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::37)
 by VI1PR08MB4622.eurprd08.prod.outlook.com (2603:10a6:803:bc::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Mon, 18 Apr
 2022 12:23:59 +0000
Received: from VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8e:cafe::30) by AM6P193CA0060.outlook.office365.com
 (2603:10a6:209:8e::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT018.mail.protection.outlook.com (10.152.18.135) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:58 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Mon, 18 Apr 2022 12:23:58 +0000
Received: from c37794760062.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7BDC8C1E-EAB9-4136-86E0-ECA025413728.1; 
 Mon, 18 Apr 2022 12:23:51 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c37794760062.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 12:23:51 +0000
Received: from AM7PR03CA0019.eurprd03.prod.outlook.com (2603:10a6:20b:130::29)
 by AS8PR08MB5896.eurprd08.prod.outlook.com (2603:10a6:20b:294::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:23:50 +0000
Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:130:cafe::f4) by AM7PR03CA0019.outlook.office365.com
 (2603:10a6:20b:130::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:50 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:49 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 12:23:47 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e91ce18-bf12-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rYZ7/21bXTduzlBPK071K+W97NWodHf7d5105P0sD+8=;
 b=2JdSqc/a/HH+0YeJVglTUEVJZ8GBNb7c0sUcnsJdzTPBDapohw7w4OsrF7JwKc1V4X8qtxxsNYDq8Uv1UtKmHb/a+ZE7hUStjh7c4WhnfpWbftnIPQwWQa0BGC64R3YXp7u0lsMjRf1pSZr7376qjwzcIg2b4XPH7/2FFC3gRow=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2fe4311b042f5cc7
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fi7naA2IVcQ6csHoeDpsrjgzM2CJ1KJ7f5msPQViNdXN3EcC6okm1zTRoBYfHG9kZlb2HwF0mh7yjJdKohf2ZUjXrImQvUBjXxuMBXRtmUQXW87E1TolNn/FDJld7jPMv8Bg6ZK23NOZThAIQPo0D/5bLILwaG6AzVY/7YmdUQ4mWQAMRwcMrYRyvddYFkvF2XeYTBs+p68+stPboUV9WUWHIkS2Iw6I1UhR4t1xEmSEoShX0V2WNoBCEXhiv3cWyKhuuXdPhEUSy7i1LdiV6eDhoAqxSqOML3673z0dVEFSojGEl/VuYBdTEVdzOhkf9XSRPtZSJIssHgOW8NoZsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rYZ7/21bXTduzlBPK071K+W97NWodHf7d5105P0sD+8=;
 b=M6shXsTSgJjqPVu43i5yYDUlD25Ar2lrCcFFhT7fcu1g7PGmRUf9o+dmCcUUySU9D3mSiaVdlRQD0ks3rHfgX+DsBTEb1egNegCqh5ndajYgOTbxVa1H6mc7LiUGE3icYX0ZxWqJXHsLhR4K+X7bOi6iPISfhczVUcADOwNdltwGQxPOrXG4rMjC/t83GdfgfWpSLT6HXoUjsDsH0YkuTGJIaT/4mI9A2UnuwpBFarVnQK4t+uRE6aVVlgs7oZqc8//khSWwVCiEcZfCyxiOIKTQresSltm853X3NiECjQlEgDrO/XsNY1B+Zy+kXh2mgW8veZE3JUA8cSI7dxIQKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rYZ7/21bXTduzlBPK071K+W97NWodHf7d5105P0sD+8=;
 b=2JdSqc/a/HH+0YeJVglTUEVJZ8GBNb7c0sUcnsJdzTPBDapohw7w4OsrF7JwKc1V4X8qtxxsNYDq8Uv1UtKmHb/a+ZE7hUStjh7c4WhnfpWbftnIPQwWQa0BGC64R3YXp7u0lsMjRf1pSZr7376qjwzcIg2b4XPH7/2FFC3gRow=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Penny Zheng <penny.zheng@arm.com>
Subject: [PATCH v2 5/6] xen/arm: unpopulate memory when domain is static
Date: Mon, 18 Apr 2022 20:22:50 +0800
Message-ID: <20220418122251.3583049-6-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418122251.3583049-1-Penny.Zheng@arm.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 4999d099-47ea-49ad-774f-08da2136508c
X-MS-TrafficTypeDiagnostic:
	AS8PR08MB5896:EE_|VE1EUR03FT018:EE_|VI1PR08MB4622:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB46222054ACB4BBE028995819F7F39@VI1PR08MB4622.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 heFRGt/zvBO88kv4uV5RbbLIEAze6cFninXGuepuAzUWODN8h4+Il3IJzxSrnyuRVRiL/FJbGyIXRIfc7l1kvkbskGVduj9x6RTDPg57Xoe478FpzwKTBam/WcI583DguEe77zisEpwNjLWIG5d2BAWuE/O+X+NpCKHPda+ILiGkO0QsfjV/GNnTrFBFVXBaD+lCLG6mKdqoWZrMw9XClmMdwOc8wF+iKom9tkbDiBtV4JPQeHwncEKiBa1U9kTVuv/Bao5Qj4EmoKHM/3TixWnNTMiGfK3cofaHYo8lDck4Qstk3uhbFB1dXhFP3hQy4YIVtXCxlc7mnk7A08omfrFG8n5ZUQkL7kNPTv5+c2Vv0edaCwuy3CIgBl5QQkhFsd+zwuZp1HTozQQFoDNOWRaxPgrJIa/KnFhdfB2Bl6+ca0NgJWwv12cOJic4ZuoOPulVeejBm7obK0lq3IIfUArLXakKKuB41ISORBj0wQkjWnoT4GRnVZ1rnd4/0/wxVN37zDMzMPE2xQ+PYOpvt3eVjrvGScpkOKQNOw1phwILSSUOyit/nuLeRW7/NlhG4Cg2gawBICw7gI04fyZ+PW7tSgv4enUWoh9Fiwz2Bdto4xI+wRMiDkT4xQ1/02HYoH8L14RpxgkQg6SAYbEGZNrcH8sW/U3V+azflKWleNgIaD0v/vgkz4T5P2t47LFTBNWQbEeP1koacciHB1ca/w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(47076005)(4326008)(7696005)(81166007)(8676002)(1076003)(40460700003)(2906002)(6916009)(86362001)(2616005)(186003)(26005)(36756003)(82310400005)(70206006)(70586007)(426003)(8936002)(6666004)(356005)(508600001)(336012)(36860700001)(5660300002)(54906003)(316002)(83380400001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5896
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0c959f4a-48b3-4d0c-a3db-08da21364ab5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SKGn8JWLqKzecWzAYMG4ooNeXI7VoXzjq+j9J8SRUHqb500j1Dw3NYalF0Wr86vi3gvv+yc55A4zLydEzQlcGKQF5AgPOdEhZyWr52dpf+rcV6v0/awF1uwM0pKGKkkt2Oe93vnPOJmf+dePVUgaq+Qm+DpkY0EpaoWghHTQfAwajZSE45eR4HN4bvNzs2qHQVqOBFWEd7HiGvCUAosDGolUzJEGwELdfTcC9YjYWMlnO7vPt9IMF+/9W37+n7ZOQ7h/Fu+J9UZRdg0CH9tpPi024nFoPeSzO41ra66jJvOfyONMksKQ7WvOHfMPI1XLowRHLa4K/OUMrffL7FcYjnKHNm4ijtF92IBtIwDPLd/xfVfl113KbZKaI3Y4DFJuty7Sx+YkcMCz2BjJpGW/HICGLh8E8ePxNC0pZjIXLkJy8AVQIlHHS1VdBEenbCmwXgLE0eZ8q2c87KAy5MCLv55G6328PkhTPsYsIaP/OqM8RaVp9EqeXu+IqV6B6oYB20BZVYggvCW3OU1f0tgmIStkgJE1hRyCWqyKkJ8waoIecBweVgi9rwwNEzfe3T/I4b3hcU494gNki7WZxFXl7TQPstvClet498nnihWDQE4U4KfWZXPig2eKdTlRctJ5u6jUkD1ELUYvX2pFla20Zw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(83380400001)(82310400005)(2906002)(186003)(81166007)(7696005)(70206006)(70586007)(1076003)(2616005)(5660300002)(316002)(36756003)(26005)(6666004)(426003)(336012)(47076005)(508600001)(54906003)(6916009)(36860700001)(8936002)(8676002)(4326008)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 12:23:58.8586
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4999d099-47ea-49ad-774f-08da2136508c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4622

Today when a domain unpopulates the memory on runtime, they will always
hand the memory back to the heap allocator. And it will be a problem if domain
is static.

Pages as guest RAM for static domain shall be reserved to only this domain
and not be used for any other purposes, so they shall never go back to heap
allocator.

This commit puts reserved pages on the new list resv_page_list only after
having taken them off the "normal" list, when the last ref dropped.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- put reserved pages on resv_page_list after having taken them off
the "normal" list
---
 xen/arch/arm/include/asm/mm.h | 17 +++++++++++++++++
 xen/common/domain.c           |  4 ++++
 xen/include/xen/sched.h       |  6 ++++++
 3 files changed, 27 insertions(+)

diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
index 424aaf2823..a2dde01cfa 100644
--- a/xen/arch/arm/include/asm/mm.h
+++ b/xen/arch/arm/include/asm/mm.h
@@ -358,6 +358,23 @@ void clear_and_clean_page(struct page_info *page);
 
 unsigned int arch_get_dma_bitsize(void);
 
+/*
+ * Put free pages on the resv page list after having taken them
+ * off the "normal" page list, when pages from static memory
+ */
+#ifdef CONFIG_STATIC_MEMORY
+#define arch_free_heap_page(d, pg) {                    \
+    if ( (pg)->count_info & PGC_reserved )              \
+    {                                                   \
+        page_list_del(pg, page_to_list(d, pg));         \
+        page_list_add_tail(pg, &(d)->resv_page_list);   \
+        (d)->resv_pages++;                              \
+    }                                                   \
+    else                                                \
+        page_list_del(pg, page_to_list(d, pg));         \
+}
+#endif
+
 #endif /*  __ARCH_ARM_MM__ */
 /*
  * Local variables:
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 859cc13d3b..b499cf8d2c 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -605,6 +605,10 @@ struct domain *domain_create(domid_t domid,
     INIT_PAGE_LIST_HEAD(&d->page_list);
     INIT_PAGE_LIST_HEAD(&d->extra_page_list);
     INIT_PAGE_LIST_HEAD(&d->xenpage_list);
+#ifdef CONFIG_STATIC_MEMORY
+    INIT_PAGE_LIST_HEAD(&d->resv_page_list);
+#endif
+
 
     spin_lock_init(&d->node_affinity_lock);
     d->node_affinity = NODE_MASK_ALL;
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 68eb08058e..85ef378752 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -376,6 +376,9 @@ struct domain
     struct page_list_head page_list;  /* linked list */
     struct page_list_head extra_page_list; /* linked list (size extra_pages) */
     struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */
+#ifdef CONFIG_STATIC_MEMORY
+    struct page_list_head resv_page_list; /* linked list (size resv_pages) */
+#endif
 
     /*
      * This field should only be directly accessed by domain_adjust_tot_pages()
@@ -395,6 +398,9 @@ struct domain
 #ifdef CONFIG_MEM_PAGING
     atomic_t         paged_pages;       /* paged-out pages */
 #endif
+#ifdef CONFIG_STATIC_MEMORY
+    unsigned int     resv_pages;        /* reserved pages from static region. */
+#endif
 
     /* Scheduling. */
     void            *sched_priv;    /* scheduler-specific data */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:24:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:24:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307208.522543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQQb-0005S9-6P; Mon, 18 Apr 2022 12:24:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307208.522543; Mon, 18 Apr 2022 12:24:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQQb-0005Ru-17; Mon, 18 Apr 2022 12:24:25 +0000
Received: by outflank-mailman (input) for mailman id 307208;
 Mon, 18 Apr 2022 12:24:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UkN/=U4=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngQQZ-0002c3-49
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 12:24:23 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20613.outbound.protection.outlook.com
 [2a01:111:f400:7d00::613])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7278a62d-bf12-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 14:24:18 +0200 (CEST)
Received: from AS8PR07CA0002.eurprd07.prod.outlook.com (2603:10a6:20b:451::31)
 by AM0PR08MB3634.eurprd08.prod.outlook.com (2603:10a6:208:d6::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:24:06 +0000
Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:451:cafe::85) by AS8PR07CA0002.outlook.office365.com
 (2603:10a6:20b:451::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.12 via Frontend
 Transport; Mon, 18 Apr 2022 12:24:06 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:24:05 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Mon, 18 Apr 2022 12:24:05 +0000
Received: from e4e3ea6435ab.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 40C510F7-811A-4D4C-AD76-32739D5FC527.1; 
 Mon, 18 Apr 2022 12:23:59 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e4e3ea6435ab.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 12:23:59 +0000
Received: from AS8P251CA0013.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::28)
 by DB9PR08MB6633.eurprd08.prod.outlook.com (2603:10a6:10:23d::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 12:23:58 +0000
Received: from VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2f2:cafe::44) by AS8P251CA0013.outlook.office365.com
 (2603:10a6:20b:2f2::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:57 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT038.mail.protection.outlook.com (10.152.19.112) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 12:23:57 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 12:23:56 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Mon, 18
 Apr 2022 12:23:54 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 12:23:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7278a62d-bf12-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LpppyH+TZRPMImSMb65msgwXr8BDg+yB7jYmPGh/pdI=;
 b=1rVz0EKHXAFIUCMUxXT1dInfz/BwBq7Pd3RkzgzBbbwbsiuPsNoU/jkciSX6HtOVis1yw4FtaZBN3Er7SBFCKOD9NMg+Pp+AfelIIZOcEeVvmHFBjHg3Q2FfUHEip+cYYODwN6n/BxjVNV85KXQOADN0+9wO5ehWXNduW7irHbc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b244345b88eeedf2
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JjWGpL5fQ0fNuvmUduLTGOrJxUMWmvOIMyZZy1wlYP8OrlWOV6Yt6/gBJIhU/MX70DgMQ1/3xmPtYm4gJ+P5KQ5apLARF8LngJvcLcCeN5PgPZ/oH89PWzQOhg6gFA401sIZBL4qhdZJItIwu2xIf3phXQWPOgPHWJU+8SmBxXmDmD0h+Cn2Ine2kVdWeiC1+hLEkEN/vO7ekdsRDkGX0pin14/g9C1EUdUr++BwK2E3xQe2YuZeoGgoyvB8v7n4XMXAIDdkkbSx6lukz1J/S6S9nnAWLQTQ6uMSM9qRQ+vmE7pMWrEYLbqXkgm2xnBA+rv8KhBidZljIrD9b3vl0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LpppyH+TZRPMImSMb65msgwXr8BDg+yB7jYmPGh/pdI=;
 b=PqpgCseApIDd0YTSoWNfojInYWQspPzDvckhhD0cBJq05WhFoKJDkvSOizkyfEQURo5tJ96/nzHd+V6t2Pcp0QEcJvMq2g1+TuJIQGDRxhuDDF2hfcZOBq8P+yzH93M/vYD2g3QO0QqHcTsRvCFkkEntpwRyW5R4c777NwRQTK80+acENv2hZnrI3AjzgizPJhU54XiEXC2rkgHyg6PHmSH72CBF98L8Ve1AkKGSpxvidms2LKxmXblGowYNgfINKobncMP5PTWaSwypNvCyZ3eTlI7N4dQG4OWPdwGw9f+OpNjk1Tb/JKkG9gOXKqGI2gfSm6jzi2xOVScOUn9lAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LpppyH+TZRPMImSMb65msgwXr8BDg+yB7jYmPGh/pdI=;
 b=1rVz0EKHXAFIUCMUxXT1dInfz/BwBq7Pd3RkzgzBbbwbsiuPsNoU/jkciSX6HtOVis1yw4FtaZBN3Er7SBFCKOD9NMg+Pp+AfelIIZOcEeVvmHFBjHg3Q2FfUHEip+cYYODwN6n/BxjVNV85KXQOADN0+9wO5ehWXNduW7irHbc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Penny Zheng
	<penny.zheng@arm.com>
Subject: [PATCH v2 6/6] xen/arm: retrieve reserved pages on populate_physmap
Date: Mon, 18 Apr 2022 20:22:51 +0800
Message-ID: <20220418122251.3583049-7-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418122251.3583049-1-Penny.Zheng@arm.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 350dfaa3-c7ac-4f11-8f93-08da213654cc
X-MS-TrafficTypeDiagnostic:
	DB9PR08MB6633:EE_|VE1EUR03FT025:EE_|AM0PR08MB3634:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB36346B6D14CB4350E0653F05F7F39@AM0PR08MB3634.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 yZHreejEepp+S4felBM7EMQVtmCTlQr34VytMaysREGzNcXtiJd60MIlPCOeT2jlKvNsFUAQH72n1Fd4dbYHJz3Q6QtZdWB+oZIPIn02pu07gqqHP9UZz9M4OrmBajdJ51B6YLZKPQtkJUeLO0Z6ien6Q4dRDoe5I35fqwYYts6QfNglv7kAbIYcHEgZjoJG0zh3BsLE1vJF/QwqfN/b+Oje4vBU42HrFdmNAoHFPE3/Hc9+fa3zwz3VBfS0uVBMVETMVlQhY1Ky7jOGW8X8+6Rhu+aUVWRjyFfsa6YhvVDBdR4tTymbiJufRz34LiuUqXXWC9PtSPcV9DAWwNDtC/sQJFZxDwebqgxsVt7b2cMaf5DVWxAu0QIDUuwlh/UEyZwiO5XINXkllbg4roN9ZF693vnjNlQp1RJqWUz+lgzE+xBYauv7X5MziDJTsN8Njva9Xe6TNbpizCyGUFDtsbxNgIh+CPxvB7CivXPnNV4nStUCmlNiHivsq6Io7csEjLfcQXPUE9wry7I3b69YZ9s/VYmS849ruLsrm9iXyynSrp+UyEhGTSibByghJSh5So89THrM33mTslbuEDi8EhYQC7HX5hJ1XGDcAjj3oE1A2D9E/igWqfvVsc887R/mCFfGitC5xojJGchhq/dOIHhpxsrTYTolpUsXsHnDmqOmYEuIlzRLiuD8YcswdcjjViq2KygZzlVv4ckgz2HAiA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(426003)(5660300002)(47076005)(6666004)(86362001)(83380400001)(6916009)(54906003)(70586007)(336012)(70206006)(316002)(26005)(186003)(356005)(36860700001)(40460700003)(2616005)(1076003)(4326008)(8676002)(81166007)(508600001)(8936002)(36756003)(7696005)(2906002)(82310400005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6633
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	08f7a41c-bed6-4869-df99-08da21364fa3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Bk898ASg9yrzEoDJJ0v4wdiLXfu0dpP2bD5/GwdDMDyFHTLRuUVjJvySydwjdeMxDXhBoqQWpFm6HgAD6Bd6+VAwVlrIH6dknNrWDHFdxg/iVHZ2Ll3HMv8zIHgFvBDpHnEAYOrwxfDYQYxdM5DlqeTBYR2TIWrX9Hh6G3wjxcnLgjyJwPnd4+nuA6Fh0E2ZL+Z67KVizuO+5lfKfH6AZ/uPbQXUyyCaQJWRTj/EppVpfhyIgE9qSf7q5eZTkpvtoPipw4/6g4gjubdZOCWlA4BNsRV5j41WoqQCyH4JuaprWtFgqoAhSiFUjIjoTOhl8lYUOFOcbTBZakFYItdVbWysFkwGya6S9nXI7bKteGHn71jWW99oQQYlOheFH5aC8zF66s7d47F4BwK3yfB5K46E67Vz4lNevn5hRYiWgoNrDHnOVpQ4X4zRQdyilcizUU0sdCK3rNn5zmO8KPLRzSHMhFbPL+6IMHe2G3ykqcWOH/Z6Tlmi8TeZ+U+FFM/w/e9Z6kGCSUUs5HnJt15ksOF3GsTeqhj5IvySx6kV0kje9GkzpnFtx/wgSwahTb/RXKYWm0VgjxnqZW0ubEkgOEg142admvH5T+0ONQFnOSVosPkyniKTaQeZN4HvVIGC1FGNksPoB2UEtWkW3lZvu2qAmeqjiUlA3QSflpOzVCHj6h2+GwJSDRZD9UEKf9h6
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(82310400005)(36860700001)(81166007)(4326008)(8676002)(8936002)(498600001)(54906003)(70206006)(5660300002)(70586007)(336012)(426003)(26005)(86362001)(186003)(36756003)(83380400001)(2616005)(40460700003)(47076005)(7696005)(2906002)(6916009)(6666004)(1076003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 12:24:05.9951
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 350dfaa3-c7ac-4f11-8f93-08da213654cc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3634

When static domain populates memory through populate_physmap on runtime,
other than allocating from heap, it shall retrieve reserved pages from
resv_page_list to make sure that guest RAM is still restricted in statically
configured memory regions. And this commit introduces a new helper
acquire_reserved_page to make it work.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- introduce acquire_reserved_page to retrieve reserved pages from
resv_page_list
- forbid non-zero-order requests in populate_physmap
- let is_domain_static return ((void)(d), false) on x86
---
 xen/common/memory.c     | 29 +++++++++++++++++++++++++++++
 xen/common/page_alloc.c | 28 ++++++++++++++++++++++++++++
 xen/include/xen/mm.h    |  1 +
 3 files changed, 58 insertions(+)

diff --git a/xen/common/memory.c b/xen/common/memory.c
index 69b0cd1e50..f7729dfa5c 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -35,6 +35,10 @@
 #include <asm/guest.h>
 #endif
 
+#ifndef is_domain_static
+#define is_domain_static(d) ((void)(d), false)
+#endif
+
 struct memop_args {
     /* INPUT */
     struct domain *domain;     /* Domain to be affected. */
@@ -245,6 +249,31 @@ static void populate_physmap(struct memop_args *a)
 
                 mfn = _mfn(gpfn);
             }
+#ifdef CONFIG_STATIC_MEMORY
+            else if ( is_domain_static(d) )
+            {
+                /*
+                 * No easy way to guarantee the retreived pages are contiguous,
+                 * so forbid non-zero-order requests here.
+                 */
+                if ( a->extent_order != 0 )
+                {
+                    gdprintk(XENLOG_INFO,
+                             "Could not allocate non-zero-order pages for static %pd.\n.",
+                             d);
+                    goto out;
+                }
+
+                mfn = acquire_reserved_page(d, a->memflags);
+                if ( mfn_eq(mfn, INVALID_MFN) )
+                {
+                    gdprintk(XENLOG_INFO,
+                             "%pd: failed to retrieve a reserved page.\n.",
+                             d);
+                    goto out;
+                }
+            }
+#endif
             else
             {
                 page = alloc_domheap_pages(d, a->extent_order, a->memflags);
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 8ba38bca9a..759d612eb8 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -2770,6 +2770,34 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
 
     return 0;
 }
+
+/*
+ * Acquire a page from reserved page list(resv_page_list), when populating
+ * memory for static domain on runtime.
+ */
+mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags)
+{
+    struct page_info *page;
+    mfn_t smfn;
+
+    /* Acquire a page from reserved page list(resv_page_list). */
+    page = page_list_remove_head(&d->resv_page_list);
+    if ( unlikely(!page) )
+    {
+        printk(XENLOG_ERR
+               "%pd: failed to acquire a reserved page %"PRI_mfn".\n",
+               d, mfn_x(page_to_mfn(page)));
+        return INVALID_MFN;
+    }
+    d->resv_pages--;
+
+    smfn = page_to_mfn(page);
+
+    if ( acquire_domstatic_pages(d, smfn, 1, memflags) )
+        return INVALID_MFN;
+
+    return smfn;
+}
 #endif
 
 /*
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index 3be754da92..6ef5a6adcd 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -91,6 +91,7 @@ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
                           bool need_scrub);
 int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns,
                             unsigned int memflags);
+mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags);
 #endif
 
 /* Map machine page range in Xen virtual address space. */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:30:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:30:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307220.522553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQWl-0007OP-UU; Mon, 18 Apr 2022 12:30:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307220.522553; Mon, 18 Apr 2022 12:30:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQWl-0007OI-Rf; Mon, 18 Apr 2022 12:30:47 +0000
Received: by outflank-mailman (input) for mailman id 307220;
 Mon, 18 Apr 2022 12:30:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngQWk-0007O8-QP; Mon, 18 Apr 2022 12:30:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngQWk-00057z-Nt; Mon, 18 Apr 2022 12:30:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngQWk-0002Va-8P; Mon, 18 Apr 2022 12:30:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngQWk-0006z8-80; Mon, 18 Apr 2022 12:30:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2KbtfmkxOvlTa2NY7Os45pDjbnCbJpNqgwrDSw2xd7w=; b=h7nI0VXBl3gKKdseAJZj4NhMAb
	3k1FYB94BXE3X7VmhJlPBS/6hmKu67DTybt2ocoinab5tfpiwVAiUzPuFKlfGvuEPvdYTQO57qEs/
	Ni/XHIsdSuNauZzPdg6WdafjqQ33qr94iJC7uRBW0VyyqZXycDmT/IP7vIKaF5bhyujU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169510-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169510: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 12:30:46 +0000

flight 169510 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169510/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  479 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   55 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 12:53:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 12:53:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307246.522565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQsC-0001cr-QD; Mon, 18 Apr 2022 12:52:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307246.522565; Mon, 18 Apr 2022 12:52:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngQsC-0001ck-MV; Mon, 18 Apr 2022 12:52:56 +0000
Received: by outflank-mailman (input) for mailman id 307246;
 Mon, 18 Apr 2022 12:52:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=HB8F=U4=kernel.dk=axboe@srs-se1.protection.inumbo.net>)
 id 1ngQsB-0001ce-Ak
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 12:52:55 +0000
Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com
 [2607:f8b0:4864:20::634])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 75bada36-bf16-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 14:52:53 +0200 (CEST)
Received: by mail-pl1-x634.google.com with SMTP id t12so12260061pll.7
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 05:52:53 -0700 (PDT)
Received: from [127.0.1.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id
 s24-20020a17090a441800b001ca9b5724a6sm12663301pjg.36.2022.04.18.05.52.49
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 18 Apr 2022 05:52:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75bada36-bf16-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=kernel-dk.20210112.gappssmtp.com; s=20210112;
        h=from:to:cc:in-reply-to:references:subject:message-id:date
         :mime-version:content-transfer-encoding;
        bh=F9FMycteyYrs8wEiBExwTDtAcc/2JBQ5GQqodkswvTM=;
        b=zqMJx9kEO/syGgh/jfUujcMdgZO1Zk4th79yyPJcsdnvdIDI8Xk864jrHuyarDgv8c
         gBt2ez+Ym/+EaLgC6MfWMHx5OVcgB54eOfckx7Cmdvf3bmGVDc/T0aLwM9rpN+nKDwcO
         dWklV+ARMeZbUO1+GrFCqFc/xZjiULaGiN1ll1DVCyoNwgzG1P+0Y9ZhUcwBpI/7WQx/
         gN/pYZdJuI935bVWCVcjkTqu2k20R+5oG6mGhil2uYi4X3QtR1zxXemtHM8NZ8XUvixz
         3tQXFtvzqXbRCXIajCtyaq1nqo4kcpEpLyzsTyB3FvSvWQd/rTixV4XGHzsBwq9Bu/vV
         stDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:in-reply-to:references:subject
         :message-id:date:mime-version:content-transfer-encoding;
        bh=F9FMycteyYrs8wEiBExwTDtAcc/2JBQ5GQqodkswvTM=;
        b=q8rVGxRdAxYpfZKGrl91sZijpvjwmdYpezOqmvh91LiPGJJLARrPlhdjSfLvk+XZgR
         xmUzkW8KSp5+KERNIvYVw1w75DfUCd1I2Ey/OpGY2ZJpl465I1HZZG74gTa5bWXD5bHC
         XNq3/qUNVObAVQ1aFVto+Sn/sIo6v0j+JGG+hBtVL/pyPqroNDFcgOIR2yKtMJ7cItHx
         iG05xM38tqM8xh4ohFbdc6H8nkhSbxdPkK+Lc5a0D8WBLeCVbzEj0sdw3ZnkBxhwylN0
         hn6VBtcK2n/YhEsEO28ey9A36sJDcJbw7EVp3+fidLavvF8OpH8awNWyClQl6nMzVJ8V
         I/Nw==
X-Gm-Message-State: AOAM531MSXGkY/gNgtFe3SWMB2Br6z1u8UZ+XG0OK4HBWgK12QbFv7ED
	FSW2g8rf14KISc1DX2vbmkJbAw==
X-Google-Smtp-Source: ABdhPJyPDIaLEewZhdBb/81ulQRxH4lnSCW72QYENTWzgjKzLqW/EIFRVhnHg8tc4oCKtNOZ6kDuRg==
X-Received: by 2002:a17:902:6b44:b0:154:4bee:c434 with SMTP id g4-20020a1709026b4400b001544beec434mr10858040plt.43.1650286372060;
        Mon, 18 Apr 2022 05:52:52 -0700 (PDT)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-f2fs-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, nbd@other.debian.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, dm-devel@redhat.com, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-bcache@vger.kernel.org, ceph-devel@vger.kernel.org, ntfs3@lists.linux.dev, linux-um@lists.infradead.org, target-devel@vger.kernel.org
In-Reply-To: <20220415045258.199825-1-hch@lst.de>
References: <20220415045258.199825-1-hch@lst.de>
Subject: Re: use block_device based APIs in block layer consumers v3
Message-Id: <165028636949.14872.7589996414521818725.b4-ty@kernel.dk>
Date: Mon, 18 Apr 2022 06:52:49 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Fri, 15 Apr 2022 06:52:31 +0200, Christoph Hellwig wrote:
> this series cleanups up the block layer API so that APIs consumed
> by file systems are (almost) only struct block_devic based, so that
> file systems don't have to poke into block layer internals like the
> request_queue.
> 
> I also found a bunch of existing bugs related to partition offsets
> and discard so these are fixed while going along.
> 
> [...]

Applied, thanks!

[01/27] target: remove an incorrect unmap zeroes data deduction
        commit: 179d8609d8424529e95021df939ed7b0b82b37f1
[02/27] target: pass a block_device to target_configure_unmap_from_queue
        commit: 817e8b51eb3d927ce6d56ecf9f48bc3c5b26168b
[03/27] target: fix discard alignment on partitions
        commit: 968786b9ef56e75e0109158a4936ffffea962c1e
[04/27] drbd: remove assign_p_sizes_qlim
        commit: 40349d0e16cedd0de561f59752c3249780fb749b
[05/27] drbd: use bdev based limit helpers in drbd_send_sizes
        commit: 7a38acce229685968b770d1d9e64e01396b93643
[06/27] drbd: use bdev_alignment_offset instead of queue_alignment_offset
        commit: c6f23b1a05441a26f765e59dd95e8ba7354f9388
[07/27] drbd: cleanup decide_on_discard_support
        commit: 998e9cbcd615e5e6a7baa69e673ee845f812744e
[08/27] btrfs: use bdev_max_active_zones instead of open coding it
        commit: c1e7b24416400ef13ff92a1c60c336c9a2834d7b
[09/27] ntfs3: use bdev_logical_block_size instead of open coding it
        commit: f09dac9afb8e3ce4b6485dbc091a9b9c742db023
[10/27] mm: use bdev_is_zoned in claim_swapfile
        commit: 9964e674559b02619fee2012a56839624143d02e
[11/27] block: add a bdev_nonrot helper
        commit: 10f0d2a517796b8f6dc04fb0cc3e49003ae6b0bc
[12/27] block: add a bdev_write_cache helper
        commit: 08e688fdb8f7e862092ae64cee20bc8b463d1046
[13/27] block: add a bdev_fua helper
        commit: a557e82e5a01826f902bd94fc925c03f253cb712
[14/27] block: add a bdev_stable_writes helper
        commit: 36d254893aa6a6e204075c3cce94bb572ac32c04
[15/27] block: add a bdev_max_zone_append_sectors helper
        commit: 2aba0d19f4d8c8929b4b3b94a9cfde2aa20e6ee2
[16/27] block: use bdev_alignment_offset in part_alignment_offset_show
        commit: 64dcc7c2717395b7c83ffb10f040d3be795d03c1
[17/27] block: use bdev_alignment_offset in disk_alignment_offset_show
        commit: 640f2a23911b8388989547f89d055afbb910b88e
[18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line
        commit: 89098b075cb74a80083bc4ed6b71d0ee18b6898f
[19/27] block: remove queue_discard_alignment
        commit: 4e1462ffe8998749884d61f91be251a7a8719677
[20/27] block: use bdev_discard_alignment in part_discard_alignment_show
        commit: f0f975a4dde890bfe25ce17bf07a6495453988a4
[21/27] block: move {bdev,queue_limit}_discard_alignment out of line
        commit: 5c4b4a5c6f11c869a57c6bd977143430bc9dc43d
[22/27] block: refactor discard bio size limiting
        commit: e3cc28ea28b5f8794db2aed24f8a0282ad2e85a2
[23/27] block: add a bdev_max_discard_sectors helper
        commit: cf0fbf894bb543f472f682c486be48298eccf199
[24/27] block: remove QUEUE_FLAG_DISCARD
        commit: 70200574cc229f6ba038259e8142af2aa09e6976
[25/27] block: add a bdev_discard_granularity helper
        commit: 7b47ef52d0a2025fd1408a8a0990933b8e1e510f
[26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD
        commit: 44abff2c0b970ae3d310b97617525dc01f248d7c
[27/27] direct-io: remove random prefetches
        commit: c22198e78d523c8fa079bbb70b2523bb6aa51849

Best regards,
-- 
Jens Axboe




From xen-devel-bounces@lists.xenproject.org Mon Apr 18 13:25:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 13:25:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307253.522576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngRNo-00058J-Bc; Mon, 18 Apr 2022 13:25:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307253.522576; Mon, 18 Apr 2022 13:25:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngRNo-00058C-8a; Mon, 18 Apr 2022 13:25:36 +0000
Received: by outflank-mailman (input) for mailman id 307253;
 Mon, 18 Apr 2022 13:25:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngRNm-000582-Un; Mon, 18 Apr 2022 13:25:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngRNm-00064X-Q2; Mon, 18 Apr 2022 13:25:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngRNm-0003h3-FX; Mon, 18 Apr 2022 13:25:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngRNm-0002cP-F2; Mon, 18 Apr 2022 13:25:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dvZLcj/N/ILrzbcIfLYi3u1wPz/8GfHSe7n4qEeHa4g=; b=fjlkniq/IlBz6xApEh+klr91S1
	3RnHAsvdvA0etznnTjEoc58kA445eUpyXk6nuPsWE9OJrcTCIrUPVSVPpm2FZifztp9b5suHY7UN4
	JHG6PIROdcDYF1HhdZWFFze7XofXxaVQcopwHM+R/QZrYS851npz0r/BH/p70KNaIR/0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169511-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169511: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 13:25:34 +0000

flight 169511 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169511/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  480 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   56 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 13:59:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 13:59:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307262.522587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngRue-0000E1-2L; Mon, 18 Apr 2022 13:59:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307262.522587; Mon, 18 Apr 2022 13:59:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngRud-0000Du-Va; Mon, 18 Apr 2022 13:59:31 +0000
Received: by outflank-mailman (input) for mailman id 307262;
 Mon, 18 Apr 2022 13:59:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngRub-0000Df-Ut; Mon, 18 Apr 2022 13:59:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngRub-0006ci-SX; Mon, 18 Apr 2022 13:59:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngRub-0004QF-GH; Mon, 18 Apr 2022 13:59:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngRub-0002ip-Fq; Mon, 18 Apr 2022 13:59:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8y1fh/lkiSVNL9owcojEkVqJcMSM/30fIfMeV1y97/E=; b=LrT8eptVIjYUn2AJDzU61M6V8k
	T2EzqLmQDHWGmmWh8jPBhqj/uTBPKAtf5qVa/7BWb0L68zKp4UpfkIaEu9Fvwnh5YTrctXJq8a/C/
	oLfl6loBKKXviriER4ZTNZZVbpuHmQOJkDmSK5GQd+IMOJLpBFn5GVQKg19P8dJBWRXU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169512-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169512: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 13:59:29 +0000

flight 169512 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169512/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  481 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   57 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 14:51:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 14:51:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307275.522598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngSin-0006Yn-3R; Mon, 18 Apr 2022 14:51:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307275.522598; Mon, 18 Apr 2022 14:51:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngSim-0006Yg-W6; Mon, 18 Apr 2022 14:51:20 +0000
Received: by outflank-mailman (input) for mailman id 307275;
 Mon, 18 Apr 2022 14:51:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngSim-0006YV-CY; Mon, 18 Apr 2022 14:51:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngSil-0007ZM-Vl; Mon, 18 Apr 2022 14:51:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngSil-0005XP-Ii; Mon, 18 Apr 2022 14:51:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngSil-0004I3-II; Mon, 18 Apr 2022 14:51:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FdMjE4+9MJwP5FRMfAoLf5uRG6ac0z6YzdY6ooivipo=; b=XtPlqabxnffW+DM2zOiRLfGA14
	qwTi34h0KrUiOtSpOMs8BBOWzLmquwcAmkbVIblGbuUuUEF49TjtWG4nqlNsTG20ESdtVfQplb8CP
	c988jVVteWGdMWf6lHzYrKmmjm7zjzdoBMbiuqIc8pkNQM06Yzv9UmLbVgp6qIplspac=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169513-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169513: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 14:51:19 +0000

flight 169513 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169513/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  482 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   58 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 15:59:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 15:59:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307292.522609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngTm9-0004j5-VO; Mon, 18 Apr 2022 15:58:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307292.522609; Mon, 18 Apr 2022 15:58:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngTm9-0004iy-S5; Mon, 18 Apr 2022 15:58:53 +0000
Received: by outflank-mailman (input) for mailman id 307292;
 Mon, 18 Apr 2022 15:58:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngTm8-0004io-NX; Mon, 18 Apr 2022 15:58:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngTm8-0000IY-Js; Mon, 18 Apr 2022 15:58:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngTm8-000704-4F; Mon, 18 Apr 2022 15:58:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngTm8-0004xq-3n; Mon, 18 Apr 2022 15:58:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YokNXzQd9l7fLSBFMlxoXwrItMw81Jmtz0YypuG75oQ=; b=qTqt+SAfSVow3ZW2MX0HytD4eS
	LF1PKcdidJS9Ywne3ccv6Lhe+TOvQoSCMH6u3sZuSzAuMvp9ETGDYBdAMPEcplHzKrlBBPrOsYHyl
	hYsxXKwnpMZ7g+/Em08xiXtAUxtMyRFG1lXjxvY/DL9hU0FnSlii8AtkpA4RwXts1H8o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169514-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169514: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 15:58:52 +0000

flight 169514 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169514/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  483 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   59 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 16:29:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 16:29:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307300.522620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngUFw-0000IN-2E; Mon, 18 Apr 2022 16:29:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307300.522620; Mon, 18 Apr 2022 16:29:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngUFv-0000IG-VZ; Mon, 18 Apr 2022 16:29:39 +0000
Received: by outflank-mailman (input) for mailman id 307300;
 Mon, 18 Apr 2022 16:29:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngUFu-0000I6-Aq; Mon, 18 Apr 2022 16:29:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngUFu-0001Qi-8t; Mon, 18 Apr 2022 16:29:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngUFt-0007f5-Tr; Mon, 18 Apr 2022 16:29:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngUFt-00041p-TO; Mon, 18 Apr 2022 16:29:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=F4AOTdP/PvZbOpkSjkFQlzfw4net77zIlx6geK2mng4=; b=KrWsOHebXBGSo7WaQ7RWvKbvb1
	/5gESpYcxVS1137KwTjS1bUC3aR8z3H8oQYXqXiewdW4+8aOBX6FmlF5mq/Cm+Qi4qFVK+9adnJd9
	M1LbFa3jTjbejffeDh9Aht6fNw2+XPIs+EgBjI80V21BmArXqgUHHUxVfvhYIKSbcFsU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169515-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169515: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 16:29:37 +0000

flight 169515 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169515/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  484 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   60 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 16:51:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 16:51:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307308.522630 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngUal-0003bW-T9; Mon, 18 Apr 2022 16:51:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307308.522630; Mon, 18 Apr 2022 16:51:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngUal-0003bP-QB; Mon, 18 Apr 2022 16:51:11 +0000
Received: by outflank-mailman (input) for mailman id 307308;
 Mon, 18 Apr 2022 16:51:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1+Oo=U4=redhat.com=jpoimboe@srs-se1.protection.inumbo.net>)
 id 1ngUak-0003bJ-RP
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 16:51:10 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bd02f26e-bf37-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 18:51:06 +0200 (CEST)
Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com
 [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-385-IgKty319Nm2wMqn5SMYLQw-1; Mon, 18 Apr 2022 12:51:02 -0400
Received: by mail-qv1-f71.google.com with SMTP id
 dd5-20020ad45805000000b004461b16d4caso11286982qvb.16
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 09:51:02 -0700 (PDT)
Received: from treble.redhat.com ([2600:1700:6e32:6c00::35])
 by smtp.gmail.com with ESMTPSA id
 e15-20020ac8670f000000b002e22d9c756dsm7277059qtp.30.2022.04.18.09.50.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 18 Apr 2022 09:51:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd02f26e-bf37-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1650300665;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sKtm4nbSU3FWhhvlPNHt662yt7zgfxklNVpsEjzLR6E=;
	b=jJv1fhUJRuWhH5UqA5skXagwnF6IbzWxhH4gUYAJRVJCle4I4H1sOCB4tGSQybfmg9zhD1
	MAXm4yBrgVWI1V9vpD0MpQKH8ejU8d40bRkcOtkwr8zyrR1X2pRJ/UWn0BEjVfgIZcG4qK
	trtF9Ic8om1wCorcJFf08Mks95ctCOM=
X-MC-Unique: IgKty319Nm2wMqn5SMYLQw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=sKtm4nbSU3FWhhvlPNHt662yt7zgfxklNVpsEjzLR6E=;
        b=jHoDmafRTgEDH/Ru7RDYo41z5XEDkXGgs7+AFx0x7MqDyz5TIksSb9N90p58i8d+0j
         DPqmfpdNd6oNyuxaH3nPoLYEeaLclEEgaxxpFNi1zH4sLltuthcR2DEfkyKj9XzF1Ur2
         YmuHXV3HtRs7pFudaaG9gEIdX+twDm/cbW8dMRDbb0TFmbvWcCKLv9jpD6sg2V1udvRS
         AhSVaJras9qtEIHJ0f8TwwEaTD4pefI1a1l2p7Y274WH9+A7VjwBX/X+//wvv+EFj//7
         QvZzRs2eFegU7GUxZiQvngT8gkZ5OusDHO9hRnbEjN7PbpW8lmEglm9Mn99YXO8goOIf
         tJow==
X-Gm-Message-State: AOAM532It8Xw5m/m+1jLKjysvRYKtbK0f3pRtzju4RolZcQLe8LysqvC
	rKW0BDTJDucxhwlaqWe9y+eLznNc4+SRhLpAvLN08G5X12NfOrCD0AS/p8tA7e2ppuxOL4AYEvn
	EHPWQaJP1SRLPncHBsId0Loqf+hQ=
X-Received: by 2002:a05:620a:269a:b0:680:a5c5:954e with SMTP id c26-20020a05620a269a00b00680a5c5954emr7178497qkp.468.1650300661655;
        Mon, 18 Apr 2022 09:51:01 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJw5s03dJEz37yFRd0bt8VJZXKfEi+tgI60K56wnTALH0l5S//HMzNqbEJEbGM7GALoZ4yLkjw==
X-Received: by 2002:a05:620a:269a:b0:680:a5c5:954e with SMTP id c26-20020a05620a269a00b00680a5c5954emr7178482qkp.468.1650300661440;
        Mon, 18 Apr 2022 09:51:01 -0700 (PDT)
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: x86@kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org,
	Miroslav Benes <mbenes@suse.cz>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Date: Mon, 18 Apr 2022 09:50:25 -0700
Message-Id: <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <cover.1650300597.git.jpoimboe@redhat.com>
References: <cover.1650300597.git.jpoimboe@redhat.com>
MIME-Version: 1.0
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jpoimboe@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-type: text/plain
Content-Transfer-Encoding: 8bit

The startup_xen() kernel entry point is referenced by the ".note.Xen"
section, but is presumably not indirect-branched to.  Add ANNOTATE_ENDBR
to silence future objtool warnings.

Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 arch/x86/xen/xen-head.S | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
index ac17196e2518..3a2cd93bf059 100644
--- a/arch/x86/xen/xen-head.S
+++ b/arch/x86/xen/xen-head.S
@@ -45,6 +45,7 @@ SYM_CODE_END(hypercall_page)
 	__INIT
 SYM_CODE_START(startup_xen)
 	UNWIND_HINT_EMPTY
+	ANNOTATE_NOENDBR
 	cld
 
 	/* Clear .bss */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 18 16:59:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 16:59:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307333.522641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngUix-0004QW-5G; Mon, 18 Apr 2022 16:59:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307333.522641; Mon, 18 Apr 2022 16:59:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngUix-0004QP-2M; Mon, 18 Apr 2022 16:59:39 +0000
Received: by outflank-mailman (input) for mailman id 307333;
 Mon, 18 Apr 2022 16:59:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngUiv-0004QF-Bj; Mon, 18 Apr 2022 16:59:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngUiv-0001vD-2e; Mon, 18 Apr 2022 16:59:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngUiu-0008JC-K9; Mon, 18 Apr 2022 16:59:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngUiu-0002tI-Jg; Mon, 18 Apr 2022 16:59:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GQK8Kw81W9o/COFdBnzLc3sa4k4khj+stzJA2rrIr6c=; b=U+5jVJ96KKYd9ENCOpi2aftsfE
	+UPbwLdTkC97IWSNIjJqD/bGQa2tJskrS0lk1bXt6ceSo+KWGrucYUGDN5Z6cRxX4up7H/YcCNEx6
	d2aJQCfl/i5lBspCzaIbefnk8Mw4B5o2a19cm5ou/FDBkhwIRWF3tLQqBJKVj+1+/pZE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169516-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169516: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 16:59:36 +0000

flight 169516 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169516/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  485 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   61 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 17:31:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 17:31:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307518.522652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngVDI-0000kv-2v; Mon, 18 Apr 2022 17:31:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307518.522652; Mon, 18 Apr 2022 17:31:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngVDH-0000ko-Vo; Mon, 18 Apr 2022 17:30:59 +0000
Received: by outflank-mailman (input) for mailman id 307518;
 Mon, 18 Apr 2022 17:30:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngVDH-0000ke-Dp; Mon, 18 Apr 2022 17:30:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngVDH-0002SS-Bw; Mon, 18 Apr 2022 17:30:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngVDH-0000Xa-3m; Mon, 18 Apr 2022 17:30:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngVDH-0001xZ-3I; Mon, 18 Apr 2022 17:30:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3ytbse2kv8Vhwkl1l9g456a10bgjLMO0T2D9grR+Ik0=; b=wysi+chd+Z9WVRGXI4fwzuHYYk
	9gxnKnFMgCUPQ7yzjJu/yVM13K6AXPiFpYsqJzUwPQGlaIQYKT4ceuhMojNlcAvvFnbVsFEYwUYmJ
	TDeJsxgufP1/xgmN74iYP2j1Cyrz2T99vmtCkMzzSjtxYkJSomEbL51knx9DIHnEMrL8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169517-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169517: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 17:30:59 +0000

flight 169517 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169517/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  486 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   62 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 18:14:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 18:14:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307527.522664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngVtT-0005QK-85; Mon, 18 Apr 2022 18:14:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307527.522664; Mon, 18 Apr 2022 18:14:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngVtT-0005QD-4p; Mon, 18 Apr 2022 18:14:35 +0000
Received: by outflank-mailman (input) for mailman id 307527;
 Mon, 18 Apr 2022 18:14:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngVtS-0005Q3-G7; Mon, 18 Apr 2022 18:14:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngVtS-0003He-3L; Mon, 18 Apr 2022 18:14:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngVtR-0001VF-Hp; Mon, 18 Apr 2022 18:14:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngVtR-0003OL-HQ; Mon, 18 Apr 2022 18:14:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JRdcinKWZO1cdey451p12P+u5838ByYsHPTjyEbqZB0=; b=QcTLWRmcWlIm+URmTEWp7fUPfI
	WgCArKlwcHQ3A4l3W51IM/1Qxl3NTkGbXj7ple7uaO/+zYKpreB2rzbUGteCj3ZEPX4Pa4Mv5TW/R
	8qL/aQm9TQgrarWcz+pkWqrPqI1sWodzLoTIH6AAXvlsG3AE6MiOdgibwsOtmXpxho6o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169518-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169518: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 18:14:33 +0000

flight 169518 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169518/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  487 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   63 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 18:44:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 18:44:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307537.522674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWM7-0000Sb-L4; Mon, 18 Apr 2022 18:44:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307537.522674; Mon, 18 Apr 2022 18:44:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWM7-0000SU-I7; Mon, 18 Apr 2022 18:44:11 +0000
Received: by outflank-mailman (input) for mailman id 307537;
 Mon, 18 Apr 2022 18:44:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WNlM=U4=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1ngWM6-0000SO-1n
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 18:44:10 +0000
Received: from MTA-07-4.privateemail.com (mta-07-4.privateemail.com
 [68.65.122.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 86b137a5-bf47-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 20:44:09 +0200 (CEST)
Received: from mta-07.privateemail.com (localhost [127.0.0.1])
 by mta-07.privateemail.com (Postfix) with ESMTP id E62AB18000A7
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 14:44:05 -0400 (EDT)
Received: from mail-ot1-f53.google.com (unknown [10.20.151.140])
 by mta-07.privateemail.com (Postfix) with ESMTPA id C148418000AC
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 14:44:05 -0400 (EDT)
Received: by mail-ot1-f53.google.com with SMTP id
 e15-20020a9d63cf000000b006054e65aaecso1810556otl.0
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 11:44:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86b137a5-bf47-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650307445;
	bh=7vUzavakaGaO6E0zlDOAogK+8n1PQfQHDvi1VXpo9lA=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=Flj2Coj75hUbQWIQNaqp7EXCKFL/qJWuN7eJGExmUfcVF9qapRHeuipFSu9nqAM8O
	 UXCeaAxsZKxNfUsyJuHgHxKMyBO2ei1VxrV7U8RRGOSSBvH63A7TkOXGz4V1lf1CHZ
	 vKs4RxXQjwYwttmCez9blAS0OsWDcg+oE8u1Z8qvrpMOfDos0+J1Nb5xHmscs4G05m
	 ssQisdjjyUdnb1qtQITP5QDs6o+EcE9lRKlcmcCvccqbhWVJ7L57saihzNAtdEFe/K
	 NWAorVEMXkZSCBNbEH3DqEutbc0OoM0qbHv+A6UvKCtDuZ4Plhaozhab2sBg4Vq9lE
	 eF0pTDToi0eDg==
X-Gm-Message-State: AOAM530Jz6bTPQK+Wton04/UQUS2RlAqhipbg3y97v2aMJwWiQDlL0+j
	SxPZpc7/h/bECNHyoCO+9QxH1meuXwy/Ezcue04=
X-Google-Smtp-Source: ABdhPJzsXMPBn9ZscHy6NSd943UAnP7Q0xuJUJG3Md84R3HOOC0ZsI99DMCq7OIZg7WmnCYgDMp3vs0ljI2yu52CQ+Y=
X-Received: by 2002:a9d:4e8d:0:b0:605:4f04:4863 with SMTP id
 v13-20020a9d4e8d000000b006054f044863mr1385531otk.204.1650307445122; Mon, 18
 Apr 2022 11:44:05 -0700 (PDT)
MIME-Version: 1.0
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
In-Reply-To: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 18 Apr 2022 14:43:28 -0400
X-Gmail-Original-Message-ID: <CABfawhk-oCAoz-99LOaOYKD-N1FvRnFvM9_AUCgsPEF16F=VCA@mail.gmail.com>
Message-ID: <CABfawhk-oCAoz-99LOaOYKD-N1FvRnFvM9_AUCgsPEF16F=VCA@mail.gmail.com>
Subject: Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: xen-devel@lists.xenproject.org, Jun Nakajima <jun.nakajima@intel.com>, 
	Kevin Tian <kevin.tian@intel.com>, Jan Beulich <jbeulich@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Fri, Mar 25, 2022 at 9:34 AM Tamas K Lengyel <tamas.lengyel@intel.com> wrote:
>
> During VM forking and resetting a failed vmentry has been observed due
> to the guest non-register state going out-of-sync with the guest register
> state. For example, a VM fork reset right after a STI instruction can trigger
> the failed entry. This is due to the guest non-register state not being saved
> from the parent VM, thus the reset operation only copies the register state.
>
> Fix this by adding a new pair of hvm functions to get/set the guest
> non-register state so that the overall vCPU state remains in sync.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> ---
> v5: Switch to internal-only hvm funcs instead of adding to hvm_hw_cpu

Patch ping.


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 19:11:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 19:11:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307542.522686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWmF-0003r6-Q4; Mon, 18 Apr 2022 19:11:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307542.522686; Mon, 18 Apr 2022 19:11:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWmF-0003qz-MR; Mon, 18 Apr 2022 19:11:11 +0000
Received: by outflank-mailman (input) for mailman id 307542;
 Mon, 18 Apr 2022 19:11:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hjWk=U4=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngWmD-0003qt-Fb
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 19:11:09 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 49ba0603-bf4b-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 21:11:03 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C1F2160C33;
 Mon, 18 Apr 2022 19:11:01 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A80A8C385A7;
 Mon, 18 Apr 2022 19:11:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49ba0603-bf4b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650309061;
	bh=FqMrB3LTVheJzBcEVjR9TRPvl3+5WxICePYJ9H+WYRE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=iaOMCyRQAZv6m5n78HaBURxK4NMMAN9CI4xs+oSzDJbyFRw0xw+JmtcXEZiLYs6f6
	 sWQZINgA/mWWsVjHbXZpZgKYQBG/nbrRkzD9Ng31J6SrfwKPZnCBJ4uvKKloxPuIYU
	 gmBsGOVzZg3RriB3VWqZ9plK2DvIAG+cH3w10+YrNfgRh2sngFmSSehrUFTciYqu7T
	 zT5w8FDN0R3R3txesKnzG9aufRHfEwzLWhFmgeulNNrs5UcXMXLPapHGO/BNvf2NOf
	 jC57LqnXClajT8Mqetp1AltnOuq2ME4B5BFkhuLGN6A/2//wMDcXj42G2e90kh+jIQ
	 zqiUjbXtEVKYw==
Date: Mon, 18 Apr 2022 12:11:00 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr <olekstysh@gmail.com>
cc: Christoph Hellwig <hch@infradead.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, 
    "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
In-Reply-To: <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-7-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop> <YlpdBHKT1bYzZe2e@infradead.org>
 <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 18 Apr 2022, Oleksandr wrote:
> On 16.04.22 09:07, Christoph Hellwig wrote:
> 
> Hello Christoph
> 
> > On Fri, Apr 15, 2022 at 03:02:45PM -0700, Stefano Stabellini wrote:
> > > This makes sense overall. Considering that the swiotlb-xen case and the
> > > virtio case are mutually exclusive, I would write it like this:
> > Curious question:  Why can't the same grant scheme also be used for
> > non-virtio devices?  I really hate having virtio hooks in the arch
> > dma code.  Why can't Xen just say in DT/ACPI that grants can be used
> > for a given device?

[...]

> This patch series tries to make things work with "virtio" devices in Xen
> system without introducing any modifications to code under drivers/virtio.


Actually, I think Christoph has a point.

There is nothing inherently virtio specific in this patch series or in
the "xen,dev-domid" device tree binding. Assuming a given device is
emulated by a Xen backend, it could be used with grants as well.

For instance, we could provide an emulated e1000 NIC with a
"xen,dev-domid" property in device tree. Linux could use grants with it
and the backend could map the grants. It would work the same way as
virtio-net/block/etc. Passthrough devices wouldn't have the
"xen,dev-domid" property, so no problems.

So I think we could easily generalize this work and expand it to any
device. We just need to hook on the "xen,dev-domid" device tree
property.

I think it is just a matter of:
- remove the "virtio,mmio" check from xen_is_virtio_device
- rename xen_is_virtio_device to something more generic, like
  xen_is_grants_device
- rename xen_virtio_setup_dma_ops to something more generic, like
  xen_grants_setup_dma_ops

And that's pretty much it.


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 19:11:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 19:11:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307543.522697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWmK-000472-2m; Mon, 18 Apr 2022 19:11:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307543.522697; Mon, 18 Apr 2022 19:11:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWmJ-00046v-VL; Mon, 18 Apr 2022 19:11:15 +0000
Received: by outflank-mailman (input) for mailman id 307543;
 Mon, 18 Apr 2022 19:11:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hjWk=U4=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngWmJ-00046X-2W
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 19:11:15 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4f1b56b2-bf4b-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 21:11:11 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A97D4B81060;
 Mon, 18 Apr 2022 19:11:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85AE5C385A7;
 Mon, 18 Apr 2022 19:11:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f1b56b2-bf4b-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650309069;
	bh=4YKezrNNiB9m8IY/75trg+uDeE7rdnHIo5cZ9GUis00=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=iB4T6PRJQ/PKnUiFGV0kERbAIMsu/ZMsqV0vd8fXTENKsNL/Tltd13gSLsYQPTMgw
	 3+sVGM22tO6yathGP9PBYeMd9xLJMQ0f4DDQMBIlg+vy+n0ZnWnz148N7MAb6RMrkX
	 zATi/Y9l1605SLRUrYuA23MKANhBqDqE+FxK0U60m7zlj1lWOLbPpOsvX8mlB8QJsI
	 5xSYg4w4iF243ekVooz3mQg4iUDwd9p7FjbvnOlegC4CgGuDTWXahyOOxe3bKmm3fw
	 3ucmpsFSnkdKjD10ynpex39h49+PFhqpNe6+jvIeX+r9T7fnmIXkhP15hu2tzu9HBn
	 PjktHBLyZ1gQw==
Date: Mon, 18 Apr 2022 12:11:08 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, x86@kernel.org, 
    linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>, 
    Dave Hansen <dave.hansen@linux.intel.com>, 
    Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, 
    Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, 
    Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Julien Grall <julien@xen.org>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    linux-arm-kernel@lists.infradead.org, 
    Christoph Hellwig <hch@infradead.org>, 
    "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC PATCH 2/6] virtio: add option to restrict memory access
 under Xen
In-Reply-To: <8a66ad42-a3e7-c29d-7d4e-35766dcccd15@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204181151030.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-3-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2204151235440.915916@ubuntu-linux-20-04-desktop> <8a66ad42-a3e7-c29d-7d4e-35766dcccd15@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-171909756-1650308130=:915916"
Content-ID: <alpine.DEB.2.22.394.2204181201000.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-171909756-1650308130=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204181201001.915916@ubuntu-linux-20-04-desktop>

On Sun, 17 Apr 2022, Oleksandr wrote:
> On 16.04.22 01:01, Stefano Stabellini wrote:
> > On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
> > > From: Juergen Gross <jgross@suse.com>
> > > 
> > > In order to support virtio in Xen guests add a config option enabling
> > > the user to specify whether in all Xen guests virtio should be able to
> > > access memory via Xen grant mappings only on the host side.
> > > 
> > > This applies to fully virtualized guests only, as for paravirtualized
> > > guests this is mandatory.
> > > 
> > > This requires to switch arch_has_restricted_virtio_memory_access()
> > > from a pure stub to a real function on x86 systems (Arm systems are
> > > not covered by now).
> > > 
> > > Add the needed functionality by providing a special set of DMA ops
> > > handling the needed grant operations for the I/O pages.
> > > 
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > ---
> > >   arch/x86/mm/init.c        |  15 ++++
> > >   arch/x86/mm/mem_encrypt.c |   5 --
> > >   arch/x86/xen/Kconfig      |   9 +++
> > >   drivers/xen/Kconfig       |  20 ++++++
> > >   drivers/xen/Makefile      |   1 +
> > >   drivers/xen/xen-virtio.c  | 177
> > > ++++++++++++++++++++++++++++++++++++++++++++++
> > >   include/xen/xen-ops.h     |   8 +++
> > >   7 files changed, 230 insertions(+), 5 deletions(-)
> > >   create mode 100644 drivers/xen/xen-virtio.c
> > > 
> > > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> > > index d8cfce2..526a3b2 100644
> > > --- a/arch/x86/mm/init.c
> > > +++ b/arch/x86/mm/init.c
> > > @@ -8,6 +8,8 @@
> > >   #include <linux/kmemleak.h>
> > >   #include <linux/sched/task.h>
> > >   +#include <xen/xen.h>
> > > +
> > >   #include <asm/set_memory.h>
> > >   #include <asm/e820/api.h>
> > >   #include <asm/init.h>
> > > @@ -1065,3 +1067,16 @@ unsigned long max_swapfile_size(void)
> > >   	return pages;
> > >   }
> > >   #endif
> > > +
> > > +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> > > +int arch_has_restricted_virtio_memory_access(void)
> > > +{
> > > +	if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
> > > +		return 1;
> > > +	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
> > > +		return 1;
> > I think these two checks could be moved to a separate function in a Xen
> > header, e.g. xen_restricted_virtio_memory_access, and here you could
> > just
> > 
> > if (xen_restricted_virtio_memory_access())
> >      return 1;
> 
> Agree, will do
> 
> 
> > 
> > 
> > 
> > > +	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
> > > +}
> > > +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> > > +#endif
> > > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
> > > index 50d2099..dda020f 100644
> > > --- a/arch/x86/mm/mem_encrypt.c
> > > +++ b/arch/x86/mm/mem_encrypt.c
> > > @@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
> > >   	print_mem_encrypt_feature_info();
> > >   }
> > >   -int arch_has_restricted_virtio_memory_access(void)
> > > -{
> > > -	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
> > > -}
> > > -EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> > > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> > > index 85246dd..dffdffd 100644
> > > --- a/arch/x86/xen/Kconfig
> > > +++ b/arch/x86/xen/Kconfig
> > > @@ -92,3 +92,12 @@ config XEN_DOM0
> > >   	select X86_X2APIC if XEN_PVH && X86_64
> > >   	help
> > >   	  Support running as a Xen Dom0 guest.
> > > +
> > > +config XEN_PV_VIRTIO
> > > +	bool "Xen virtio support for PV guests"
> > > +	depends on XEN_VIRTIO && XEN_PV
> > > +	default y
> > > +	help
> > > +	  Support virtio for running as a paravirtualized guest. This will
> > > +	  need support on the backend side (qemu or kernel, depending on the
> > > +	  virtio device types used).
> > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> > > index 120d32f..fc61f7a 100644
> > > --- a/drivers/xen/Kconfig
> > > +++ b/drivers/xen/Kconfig
> > > @@ -335,4 +335,24 @@ config XEN_UNPOPULATED_ALLOC
> > >   	  having to balloon out RAM regions in order to obtain physical memory
> > >   	  space to create such mappings.
> > >   +config XEN_VIRTIO
> > > +	bool "Xen virtio support"
> > > +	default n
> > > +	depends on VIRTIO && DMA_OPS
> > > +	select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> > > +	help
> > > +	  Enable virtio support for running as Xen guest. Depending on the
> > > +	  guest type this will require special support on the backend side
> > > +	  (qemu or kernel, depending on the virtio device types used).
> > > +
> > > +config XEN_HVM_VIRTIO_GRANT
> > > +	bool "Require virtio for fully virtualized guests to use grant
> > > mappings"
> > > +	depends on XEN_VIRTIO && X86_64
> > > +	default y
> > > +	help
> > > +	  Require virtio for fully virtualized guests to use grant mappings.
> > > +	  This will avoid the need to give the backend the right to map all
> > > +	  of the guest memory. This will need support on the backend side
> > > +	  (qemu or kernel, depending on the virtio device types used).
> > I don't think we need 3 visible kconfig options for this.
> > 
> > In fact, I would only add one: XEN_VIRTIO. We can have any X86 (or ARM)
> > specific dependencies in the "depends" line under XEN_VIRTIO. And I
> > don't think we need XEN_HVM_VIRTIO_GRANT as a kconfig option
> > necessarely. It doesn't seem like some we want as build time option. At
> > most, it could be a runtime option (like a command line) or a debug
> > option (like an #define at the top of the source file.)
> 
> 
> I don't know what was the initial idea of having and extra XEN_HVM_VIRTIO and
> XEN_PV_VIRTIO options, but taking into the account that
> they are only used in arch_has_restricted_virtio_memory_access() currently, I
> share your opinion regarding a single XEN_VIRTIO option.
> 
> Looking ahead (including changes in the commit #4), we can imagine the
> resulting option:
> 
> config XEN_VIRTIO
>     bool "Xen virtio support"
>     default n
>     depends on VIRTIO && DMA_OPS
>     depends on (X86_64 || ARM || ARM64)
>     select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>     help
>       Enable virtio support for running as Xen guest. Depending on the
>       guest type this will require special support on the backend side
>       (qemu or kernel, depending on the virtio device types used).
> 
> 
> and then arch_has_restricted_virtio_memory_access() per arch:
> 
> 
> 1. x86:
> 
> int arch_has_restricted_virtio_memory_access(void)
> {
>     return (xen_has_restricted_virtio_memory_access() ||
>             cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
> }
> 
> 
> 2. Arm:
> 
> int arch_has_restricted_virtio_memory_access(void)
> {
>     return xen_has_restricted_virtio_memory_access();
> }
> 
> 
> 3. xen.h:
> 
> static inline int xen_has_restricted_virtio_memory_access(void)
> {
>     if (IS_ENABLED(CONFIG_XEN_VIRTIO) && (xen_pv_domain() ||
> xen_hvm_domain()))
>         return 1;
> 
>     return 0;
> }
> 
> 
> Actually, as domain type on Arm is always XEN_HVM_DOMAIN, we could probably
> have the following on Arm:
> 
> int arch_has_restricted_virtio_memory_access(void)
> {
>     return IS_ENABLED(CONFIG_XEN_VIRTIO);
> }
> 
> but I would prefer not to diverge and use common
> xen_has_restricted_virtio_memory_access().
> 
> Any thoughts?

Yes, I would also prefer not to diverge between the x86 and arm versions
of xen_has_restricted_virtio_memory_access. But what case are we trying
to catch with (xen_pv_domain() || xen_hvm_domain()) ? Even on x86, it is
not going to leave much out. Is it really meant only to exclude pvh
domains?

I have the feeling that we could turn this check into:

static inline int xen_has_restricted_virtio_memory_access(void)
{
    return IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain();
}

even on x86, but one of the xen/x86 maintainers should confirm.
--8323329-171909756-1650308130=:915916--


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 19:11:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 19:11:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307544.522708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWmP-0004SC-EW; Mon, 18 Apr 2022 19:11:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307544.522708; Mon, 18 Apr 2022 19:11:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWmP-0004S5-B7; Mon, 18 Apr 2022 19:11:21 +0000
Received: by outflank-mailman (input) for mailman id 307544;
 Mon, 18 Apr 2022 19:11:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hjWk=U4=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngWmO-00046X-5K
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 19:11:20 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 52f220bb-bf4b-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 21:11:18 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 615D760C3E;
 Mon, 18 Apr 2022 19:11:17 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BDD1C385AA;
 Mon, 18 Apr 2022 19:11:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52f220bb-bf4b-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650309076;
	bh=VegG9uE/cYW7iPEYsyywdBTiJppdUCAamOZypgp6yWg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dWKEoF6YDrqYBpKYvfAng6jhBLKMVcug1HKoz5+2L0SANk3CzFv06Gx4efZ7rQqom
	 yoiB7TEUpR+DC0KRPMlEbkVOWEGrzBIlgQH0Xss/9Gwk94ImpPFBKRJj3w1Sege4SV
	 l+SgzGOEzsHq9rUvnxfXSy58byJaX/PqgojrhXUXN+CniUyCzytq3UITOtzuB8qhYN
	 uMJZP4NCtqRtorHPsjEjvxneczklbQvDrIG3Qpq+IeLtSzZqwCF8s6eb12AR9pvR0o
	 C+X8FSqXeLzv22uwmwyy0S8kuDPOrc7QWkZkWTCOZVYN6hcOUHxkAr/TjiXDOpFQ9o
	 DFmewThitLLsg==
Date: Mon, 18 Apr 2022 12:11:16 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Russell King <linux@armlinux.org.uk>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, 
    "Michael S. Tsirkin" <mst@redhat.com>, 
    Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops
 layer
In-Reply-To: <84f5264c-6b98-6d56-b7ca-61c19dc502ca@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204181156280.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-5-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2204151302350.915916@ubuntu-linux-20-04-desktop> <84f5264c-6b98-6d56-b7ca-61c19dc502ca@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1608932710-1650308427=:915916"
Content-ID: <alpine.DEB.2.22.394.2204181201160.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1608932710-1650308427=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204181201161.915916@ubuntu-linux-20-04-desktop>

On Sun, 17 Apr 2022, Oleksandr wrote:
> On 16.04.22 01:02, Stefano Stabellini wrote:
> > On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
> > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > 
> > > In the context of current patch do the following:
> > > 1. Update code to support virtio-mmio devices
> > > 2. Introduce struct xen_virtio_data and account passed virtio devices
> > >     (using list) as we need to store some per-device data
> > > 3. Add multi-page support for xen_virtio_dma_map(unmap)_page callbacks
> > > 4. Harden code against malicious backend
> > > 5. Change to use alloc_pages_exact() instead of __get_free_pages()
> > > 6. Introduce locking scheme to protect mappings (I am not 100% sure
> > >     whether per-device lock is really needed)
> > > 7. Handle virtio device's DMA mask
> > > 8. Retrieve the ID of backend domain from DT for virtio-mmio device
> > >     instead of hardcoding it.
> > > 
> > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > ---
> > >   arch/arm/xen/enlighten.c |  11 +++
> > >   drivers/xen/Kconfig      |   2 +-
> > >   drivers/xen/xen-virtio.c | 200
> > > ++++++++++++++++++++++++++++++++++++++++++-----
> > >   include/xen/xen-ops.h    |   5 ++
> > >   4 files changed, 196 insertions(+), 22 deletions(-)
> > > 
> > > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> > > index ec5b082..870d92f 100644
> > > --- a/arch/arm/xen/enlighten.c
> > > +++ b/arch/arm/xen/enlighten.c
> > > @@ -409,6 +409,17 @@ int __init arch_xen_unpopulated_init(struct resource
> > > **res)
> > >   }
> > >   #endif
> > >   +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> > > +int arch_has_restricted_virtio_memory_access(void)
> > > +{
> > > +	if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
> > > +		return 1;
> > Instead of xen_hvm_domain(), you can just use xen_domain(). Also there
> > is no need for the #ifdef
> > CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, given that:
> > 
> > CONFIG_XEN_HVM_VIRTIO_GRANT depends on XEN_VIRTIO which selects
> > ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> 
> 
> Yes, but please see my comments in commit #2 regarding
> CONFIG_XEN_HVM_VIRTIO_GRANT option and
> arch_has_restricted_virtio_memory_access() on Arm.
> 
> I propose to have the following on Arm:
> 
> int arch_has_restricted_virtio_memory_access(void)
> {
>      return xen_has_restricted_virtio_memory_access();
> }
> 
> 
> where common xen.h contain a helper to be used by both Arm and x86:
> 
> static inline int xen_has_restricted_virtio_memory_access(void)
> {
>      if (IS_ENABLED(CONFIG_XEN_VIRTIO) && (xen_pv_domain() ||
> xen_hvm_domain()))
>          return 1;
> 
>      return 0;
> }
> 
> 
> But I would be happy with what you propose as well.

As I wrote in the previous reply, I also prefer to share the code
between x86 and ARM, and I think it could look like:

int arch_has_restricted_virtio_memory_access(void)
{
     return xen_has_restricted_virtio_memory_access();
}
[...]
static inline int xen_has_restricted_virtio_memory_access(void)
{
     return (IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain());
}

But let's check with Juergen and Boris.


> > > +	return 0;
> > > +}
> > > +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> > > +#endif
> > > +
> > >   static void __init xen_dt_guest_init(void)
> > >   {
> > >   	struct device_node *xen_node;
> > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> > > index fc61f7a..56afe6a 100644
> > > --- a/drivers/xen/Kconfig
> > > +++ b/drivers/xen/Kconfig
> > > @@ -347,7 +347,7 @@ config XEN_VIRTIO
> > >     config XEN_HVM_VIRTIO_GRANT
> > >   	bool "Require virtio for fully virtualized guests to use grant
> > > mappings"
> > > -	depends on XEN_VIRTIO && X86_64
> > > +	depends on XEN_VIRTIO && (X86_64 || ARM || ARM64)
> > you can remove the architectural dependencies
> 
> 
> According to the conversation in commit #2 we are considering just a single
> XEN_VIRTIO option, but it is going to has the
> same architectural dependencies: (X86_64 || ARM || ARM64)
> 
> By removing the architectural dependencies here, we will leave also X86_32
> covered (neither XEN_HVM_VIRTIO_GRANT nor XEN_PV_VIRTIO covered it). I don't
> know whether it is ok or not.
> 
> Shall I remove dependencies anyway?

No, good point. I don't know about X86_32. This is another detail where
Juergen or Boris should comment.
--8323329-1608932710-1650308427=:915916--


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 19:15:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 19:15:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307558.522718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWqW-0005m3-Vu; Mon, 18 Apr 2022 19:15:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307558.522718; Mon, 18 Apr 2022 19:15:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngWqW-0005lw-T6; Mon, 18 Apr 2022 19:15:36 +0000
Received: by outflank-mailman (input) for mailman id 307558;
 Mon, 18 Apr 2022 19:15:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngWqV-0005lm-LI; Mon, 18 Apr 2022 19:15:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngWqV-0004NP-JY; Mon, 18 Apr 2022 19:15:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngWqV-0002oV-3z; Mon, 18 Apr 2022 19:15:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngWqV-0000G7-3X; Mon, 18 Apr 2022 19:15:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AfTQq1qdIf3z1gBCZWlnPJ9h4naFZBStF182VTrR0Pg=; b=6Xcnx4pA96WyvabD7IEL28+STn
	jNwmKKmbi0UYk9D2TXfORIwJ6ShsjvZ65PvTh9/i+LV6059zE0+6DxAsIkYXuV75MASRBYPim46FX
	wH2v+9pt23eGw+os5THVq5tRjHzkq236UXcb/nrWZzAFp14zY4M+51wNURT/sdTSyqbs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169519-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169519: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 19:15:35 +0000

flight 169519 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169519/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  488 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   64 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 19:59:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 19:59:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307567.522730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngXXH-0001qI-Et; Mon, 18 Apr 2022 19:59:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307567.522730; Mon, 18 Apr 2022 19:59:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngXXH-0001qB-B8; Mon, 18 Apr 2022 19:59:47 +0000
Received: by outflank-mailman (input) for mailman id 307567;
 Mon, 18 Apr 2022 19:59:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngXXF-0001q1-AK; Mon, 18 Apr 2022 19:59:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngXXF-0005CQ-7C; Mon, 18 Apr 2022 19:59:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngXXE-0003m1-Ns; Mon, 18 Apr 2022 19:59:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngXXE-000305-NP; Mon, 18 Apr 2022 19:59:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UjOOKL1DBWDjU2zWtagu/8nKJgoFeouGOUIoS3rl0fI=; b=AzPAm2KVf4eo3avZEPdRHnWFiE
	K7hRMuS7Xaq3ISnFh6CjVcr3Q9W/FTjFSzNNKRByLf9BE55hBqdwFtuO02FhOozqNofogWtCLnmmg
	Mujh8MCgX4eZXn8/QlXmTn1Nser2ZpDF92++5lXzwQh+UxxGl0MLDloqI2IIOLq4TWGw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169520-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169520: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 19:59:44 +0000

flight 169520 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169520/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  489 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   65 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 20:04:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 20:04:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307575.522742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngXbw-0003QV-4n; Mon, 18 Apr 2022 20:04:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307575.522742; Mon, 18 Apr 2022 20:04:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngXbv-0003QO-Vl; Mon, 18 Apr 2022 20:04:35 +0000
Received: by outflank-mailman (input) for mailman id 307575;
 Mon, 18 Apr 2022 20:04:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hjWk=U4=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngXbv-0003QI-43
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 20:04:35 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c3c70b10-bf52-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 22:04:33 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2218DB80EC4;
 Mon, 18 Apr 2022 20:04:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44B36C385A7;
 Mon, 18 Apr 2022 20:04:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3c70b10-bf52-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650312271;
	bh=LAVQiVUq2UceX5cUJmduKFr0nYCl3IkCjZt6Is7HFfo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Mbz5kWV/SyTJwKusKFqk4tNewLSmibDGEkBZq/8wf/9WiihgXummVpsXzMOXv8dHc
	 rFCe7ld8Vxyzm+8/8YlCNiGG53/iORdxSMmQSHjdoODtIRjHEY0Dw3huj69zS/yo1r
	 3hdVkFpoWRV6fz7iTiUPHcD+61wHf5CRW/3tuTNmpxZij8MERAl1HyBd8QVtC+jmpD
	 /Yg5zFGVOK4sMLLna6vAqEhz5dGX+RItPYJexvT/Nn8n2fC8kvoZ2TcByKJdK8zHS0
	 IOyur6sjv3Nwptyib0I78s60dBlZlFmNsuBdwtRDHP1xv30xk6odKjg6M5E5i/yisX
	 MOPCkbcMi9Pkw==
Date: Mon, 18 Apr 2022 13:04:30 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <Rahul.Singh@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Christoph Hellwig <hch@lst.de>, xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>, 
    "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
In-Reply-To: <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com> <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop> <8C511888-6183-421E-A4C7-B271DAF46696@arm.com> <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de> <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop> <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sun, 17 Apr 2022, Rahul Singh wrote:
> > On 15 Apr 2022, at 6:40 pm, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > On Fri, 15 Apr 2022, Christoph Hellwig wrote:
> >> On Thu, Apr 14, 2022 at 01:39:23PM -0700, Stefano Stabellini wrote:
> >>> OK, now we know that the code path with Xen is correct and it is the
> >>> same code path taken (dma_alloc_direct) as when !CONFIG_XEN and !SMMU.
> >>> That is how it should be.
> >>> 
> >>> I cannot explain why dma_alloc_direct() would fail when called from
> >>> xen_swiotlb_alloc_coherent(), but it would succeed when called from
> >>> dma_alloc_attrs() without Xen.
> >>> 
> >>> I am not aware of any restrictions that xen or swiotlb-xen would
> >>> introduce in that regard. Unless you are just running out of memory
> >>> because dom0_mem too low.
> >> 
> >> The crash is deep down in the page allocator.  Even if memory was low
> >> it should no crash.  So there is some odd interaction between Xen
> >> and the page allocator going on.  I think nvme and dma-direct really
> >> are only the messenger here.
> > 
> > 
> > I cannot think of anything but if that is the case I guess it is more
> > likely related to reserved-memory not properly advertised or ACPI tables
> > not properly populated.
> 
> I am not sure if it is true as we are able to boot with the same reserved memory or
> the same ACPI table populated if we boot without swiotlb-xen dma ops.
> 
> > 
> > 
> > Rahul,
> > 
> > What happens if you boot Linux on Xen with swiotlb-xen disabled?
> 
> Linux boots fine without any issue if we disable swiotlb-xen as mentioned below.

The plot thinkens.

Without swiotlb-xen, Linux boots fine. With swiotlb-xen it crashes.
However, in both cases, the very same memory allocation function is
used: dma_direct_alloc. In one case it works, in the other case it
crashes.  Everything else is the same.

There are a couple of questionable things with dma masks in
xen_swiotlb_alloc_coherent, but they are *after* the call to
xen_alloc_coherent_pages, which is the one that crashes. So they cannot
be the cause of the crash.

Before the call to xen_alloc_coherent_pages, there is only:

  1) flags &= ~(__GFP_DMA | __GFP_HIGHMEM);
  2) size = 1UL << (order + XEN_PAGE_SHIFT);


1) is already done by dma_alloc_attrs, so it is superfluous. I couldn't
explain how 2) could possibly trigger the crash.  XEN_PAGE_SHIFT is
always 12 even on 64K pages kernels. You can try removing 2) from
xen_swiotlb_alloc_coherent, but we are really wandering in the dark
here.

Then there is xen_swiotlb_init() which allocates some memory for
swiotlb-xen at boot. It could lower the total amount of memory
available, but if you disabled swiotlb-xen like I suggested,
xen_swiotlb_init() still should get called and executed anyway at boot
(it is called from arch/arm/xen/mm.c:xen_mm_init). So xen_swiotlb_init()
shouldn't be the one causing problems.

That's it -- there is nothing else in swiotlb-xen that I can think of.

I don't have any good ideas, so I would only suggest to add more printks
and report the results, for instance:


diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 2b385c1b4a99..c81f9dc7e5a0 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -284,6 +284,7 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	phys_addr_t phys;
 	dma_addr_t dev_addr;
 
+	printk("DEBUG %s %d size=%lu flags=%x attr=%lx\n",__func__,__LINE__,size,flags,attrs);
 	/*
 	* Ignore region specifiers - the kernel's ideas of
 	* pseudo-phys memory layout has nothing to do with the
@@ -295,6 +296,8 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	/* Convert the size to actually allocated. */
 	size = 1UL << (order + XEN_PAGE_SHIFT);
 
+	printk("DEBUG %s %d size=%lu flags=%x attr=%lx\n",__func__,__LINE__,size,flags,attrs);
+
 	/* On ARM this function returns an ioremap'ped virtual address for
 	 * which virt_to_phys doesn't return the corresponding physical
 	 * address. In fact on ARM virt_to_phys only works for kernel direct
diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
index 51bb8fa8eb89..549b2c85999c 100644
--- a/kernel/dma/mapping.c
+++ b/kernel/dma/mapping.c
@@ -429,9 +429,11 @@ void *dma_alloc_attrs(struct device *dev, size_t size, dma_addr_t *dma_handle,
 	if (dma_alloc_from_dev_coherent(dev, size, dma_handle, &cpu_addr))
 		return cpu_addr;
 
+	printk("DEBUG %s %d size=%lu flags=%x attr=%lx\n",__func__,__LINE__,size,flags,attrs);
 	/* let the implementation decide on the zone to allocate from: */
 	flag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM);
 
+	printk("DEBUG %s %d size=%lu flags=%x attr=%lx\n",__func__,__LINE__,size,flags,attrs);
 	if (dma_alloc_direct(dev, ops))
 		cpu_addr = dma_direct_alloc(dev, size, dma_handle, flag, attrs);
 	else if (ops->alloc)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 20:59:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 20:59:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307581.522751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYSi-0000VY-AI; Mon, 18 Apr 2022 20:59:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307581.522751; Mon, 18 Apr 2022 20:59:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYSi-0000VR-7J; Mon, 18 Apr 2022 20:59:08 +0000
Received: by outflank-mailman (input) for mailman id 307581;
 Mon, 18 Apr 2022 20:59:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngYSg-0000VH-D8; Mon, 18 Apr 2022 20:59:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngYSg-0006Ii-9b; Mon, 18 Apr 2022 20:59:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngYSf-00053c-TD; Mon, 18 Apr 2022 20:59:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngYSf-0008JC-Sl; Mon, 18 Apr 2022 20:59:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MC+bXEVODkNAXW+JWHcLlpv8nP1HQCLGuPNPmHBpheM=; b=C05PEz+pbya3nUw2DcDm5l1fub
	uJzViNrx0vb8sGchYIDgumENMpqJg5JHgzHiY2VkL5xX+DNv9amCht4ZnzMF+fCH4WhauivXafqSz
	ZCk/Ttdk0dPpULTmosT6ahRZx1/afeKAmYb1Vd+4fAwap2F5ne8zp+wbMKGHJX8ykcf8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169521-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169521: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 20:59:05 +0000

flight 169521 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169521/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  490 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   66 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:02:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:02:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307589.522763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYW6-00020u-R5; Mon, 18 Apr 2022 21:02:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307589.522763; Mon, 18 Apr 2022 21:02:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYW6-00020n-No; Mon, 18 Apr 2022 21:02:38 +0000
Received: by outflank-mailman (input) for mailman id 307589;
 Mon, 18 Apr 2022 21:02:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hjWk=U4=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngYW5-00020h-Ec
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 21:02:37 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id def4b8a0-bf5a-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 23:02:35 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 9E67A60FCB;
 Mon, 18 Apr 2022 21:02:34 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E9DCC385A1;
 Mon, 18 Apr 2022 21:02:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: def4b8a0-bf5a-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650315754;
	bh=1nTJUTd3vSH9xAxWpz9xqIR5cJ1mGGt6UlvZA/dq5B0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=iGVaRUro2zRx/0+gBdUxhw8G9BPgjA3f1ClzxOaQAf3gOLIhz/rrN4sp4Gqi7LFpu
	 mRE05p5BlQZcS8jgyVEo5vToBpQ9SMuoqoiuVgZ8Ru1u7hu/zxHdtyk/pmb2dJAR5k
	 X98K5gINzbGfi1+RaW2Jm6cAGlW61yRdTPG3a2ThlsgV+dDnkhujD2uP1Ajhw9JFAm
	 WXLfsSHbnfUKhkoiWYpJ1jbsj/lH6zY7SNR/egp3E2uIorBsE7LelVQYQyZdZEGesu
	 S8mmLevWoPW5cIs4Qf5H8I+nJGIkPeWvHjbGQ5qW1xAu+HFQqQN5jW8Vz01XMgAlw3
	 kN+5f0wct8iFQ==
Date: Mon, 18 Apr 2022 14:02:32 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>, 
    xen-devel@lists.xenproject.org, sstabellini@kernel.org, 
    stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, 
    Ayan Kumar Halder <ayankuma@xilinx.com>
Subject: Re: [PATCH v12] xen/arm64: io: Handle data abort due to cache
 maintenance instructions
In-Reply-To: <2a287b59-9ff2-6bd0-fa42-d95333fc1554@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204181402070.915916@ubuntu-linux-20-04-desktop>
References: <20220324133705.37882-1-ayankuma@xilinx.com> <2a287b59-9ff2-6bd0-fa42-d95333fc1554@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 1 Apr 2022, Julien Grall wrote:
> On 24/03/2022 13:37, Ayan Kumar Halder wrote:
> >       /*
> >        * At this point, we know that the instruction is either valid or has
> > been
> >        * decoded successfully. Thus, Xen should be allowed to execute the
> > diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
> > index 54167aebcb..87a6240f2a 100644
> > --- a/xen/arch/arm/ioreq.c
> > +++ b/xen/arch/arm/ioreq.c
> > @@ -47,7 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
> >                                struct vcpu *v, mmio_info_t *info)
> >   {
> >       struct vcpu_io *vio = &v->io;
> > -    struct instr_details instr = info->dabt_instr;
> > +    const struct instr_details instr = info->dabt_instr;
> >       struct hsr_dabt dabt = info->dabt;
> >       ioreq_t p = {
> >           .type = IOREQ_TYPE_COPY,
> > @@ -62,7 +62,6 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
> >            * memory access. So for now, we can safely always set to 0.
> >            */
> >           .df = 0,
> > -        .data = get_user_reg(regs, info->dabt.reg),
> >           .state = STATE_IOREQ_READY,
> >       };
> >       struct ioreq_server *s = NULL;
> > @@ -74,12 +73,23 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
> >           return IO_ABORT;
> >       }
> >   +    if ( instr.state == INSTR_CACHE )
> > +        p.size = dcache_line_bytes;
> I think it would be best to only set the p.size when instr.state !=
> INSTR_CACHE in the else here.
> 
> I can do that on commit. I will also give a chance to Stefano to reply.

The patch looks OK to me, please go ahead and make the change on
commit.


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:21:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:21:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307594.522774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYoh-0004XN-F4; Mon, 18 Apr 2022 21:21:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307594.522774; Mon, 18 Apr 2022 21:21:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYoh-0004XG-BC; Mon, 18 Apr 2022 21:21:51 +0000
Received: by outflank-mailman (input) for mailman id 307594;
 Mon, 18 Apr 2022 21:21:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lLCB=U4=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1ngYog-0004XA-AN
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 21:21:50 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2061c.outbound.protection.outlook.com
 [2a01:111:f400:7eae::61c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8d6a749a-bf5d-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 23:21:47 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by DM4PR12MB5101.namprd12.prod.outlook.com (2603:10b6:5:390::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 21:21:45 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022
 21:21:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d6a749a-bf5d-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cBprRuHTAqjyrdZLgXpxN/jbKb4hf93g0yBGpvMRX64f1U0ECDUBe3wx0loJyLBBBlpOghO4/sW9lj3TpZc3teLjLCeNbUlt8kEKOxH3g3Y9lw+myjikITpmFCZHcTbGTcgpfgq+NvlV1IJsmyIteahFKuMkCnhfFw9QnbmDB+Pkj2dQpu0trz8AGiMEIEZHS5MlwejXn/MWd/V85kzr0hnJhv7/iubLz/KUgOQLnBneogSrzfOkGhW8yF4/NNmfG3XrKvwi3V9l0CeBPMW5v1iK2/JE8jcaHbitsczbmp8C12H6C34YJzswPQJ+HoTl+jylxPVHISMrBs+aRmiXMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SN+jaZlItyVekpsnL569YkoOgGJzVlcO1URdevBm70E=;
 b=hGU44lA9Ofv4clDlJ5I70vAUjnri5bZR86K3cCyV+h7pV98MTZ3HBygl7th/lxWYbzxpvTL2NI/4biUyVDPXmaqzGvSVaf8dZGpJK28fcgtAB/47rx6/mowE1DWgLvqiL1AcZCZK457o9Jro/yJPZUf0FqGAqGUCQJUKykDO6n4YcdUSPFh7wZOfTmWT1sv80+RZjRglYhPWbQv3YXGEaSR1ksygUaI45cLmcarqK9s1VynX1UU4+80yVy6vd6rC+7tZ+PW2ZAeOPTbC5Fdam/8hYwIesM4kpr/OKc+afc5J+CO4pAEW8le/ZUN/cP64XntfjTH9HhiyTP0AMJ5sWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SN+jaZlItyVekpsnL569YkoOgGJzVlcO1URdevBm70E=;
 b=scWDnKzXDPtOpqYqxi3SWbaPYejy8UIXqSPZunbjaMaM/VkrPRjQ/lzDGbHwub3nN+5snni5oRsFu74qokJ2VyF0k72CKsGQlAEvilW0LPTbxkPD8nMCtS/PepH4feOVJURogNFLWj2Q1wN5b84T7tSHG40nN5yfF0fhq4kmybHyG5kl1vW0FhX2LmIHxWWuw6pJz834z+E8DnlMa8HcllohH3IMfCqOq+X4F6fCXblq3wyQqLcNIUuvxszQRhGbhFdSC16WW090jwncJM3krX0N6ZzlYPcjXKrXNTtNeJLJbANYOIVPTrPV0OnD37ywMoTkmtZIr3nVQTkhscH4AQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: Richard Weinberger <richard@nod.at>, Johannes Berg
	<johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, "Md. Haris
 Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>, "Michael S.
 Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Mike Snitzer
	<snitzer@kernel.org>, Song Liu <song@kernel.org>, Stefan Haberland
	<sth@linux.ibm.com>, Jan Hoeppner <hoeppner@linux.ibm.com>, "Martin K.
 Petersen" <martin.petersen@oracle.com>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH 08/11] loop: remove a spurious clear of discard_alignment
Thread-Topic: [PATCH 08/11] loop: remove a spurious clear of discard_alignment
Thread-Index: AQHYUuBa8QWBZz9aDUOa5Tmj7psG5qz2LtoA
Date: Mon, 18 Apr 2022 21:21:44 +0000
Message-ID: <a60f5fc2-fad3-3e82-00b2-46126c7844ed@nvidia.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-9-hch@lst.de>
In-Reply-To: <20220418045314.360785-9-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 29c292e8-3de4-4b82-65bd-08da21817097
x-ms-traffictypediagnostic: DM4PR12MB5101:EE_
x-microsoft-antispam-prvs:
 <DM4PR12MB5101905494492F3B3B1789BBA3F39@DM4PR12MB5101.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 VTdOHMLOgj5nGlVqc9NJF8HcI54YZvuZgAg95udf3adOomd+wnZvnFAnda6i9vsfcSdwvXzHOCeeqxWt9aMlrMjRWF7Xv9ySzuXME4VPhTN6b7ns2yrqA075agaZdGinqKpCILKu86+pqIbpUNB7ihfkTGMgUI44TM4j8mL5K+wRdRnDOux1aCIyo85Wi24KeN8TisGUyr2oIbkV7/Lg+6ZyC/+btl7c36JMnsxIoHus4s5Yj3TIe51AJhZxWcFEv5Wj+I7IkVe2aWIIFQ6gssIKIt46n0J0ldMlDfh6Y+MFdRUEZ8tppl2ALPOjxZvB99il+VWZ5X4bLWTWl6JwR0Gty6B5Bfm/6c2/uDwv7PD3USn3AXdA2X8HK5mb5ibCpFELSYp1vTg5bBr8XnpgAClHXDU66lJrPlW1e84y4+nf0j3eHfsO3i7DYZT7tulSMSyiTJSBPkV9mCKI2W93bwqfY5s7gNZ2RdO2/4Qg7mNhPkiqdJdFo7Yeotx1Yz7emda/qftdc6e8vNGM5VUFW43ZFvdL3NsiG6P8Uwra5wmEkVFYZz4Bc6PRf568LaAMP3B23aCWHIB7AxBI2Nmm90JPG3Pv94gJxiMzjH+o+oECMD0A/cdho5FbbDmKZz1VGs1WIQuwUCqcIk1syuc8uQj9uZ0XiZoXSS7IH3MsjfaGsnWX4U/Njp053kRrHzoG7aKMPQ9OClMuvLfpWMh0gLOw9Z04aQgHxVy9ekz0n+4gnIxtkwrlMl0Xl7Ap0YqtO9luyWBM5+K1Ke+FJuKVBA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(122000001)(38100700002)(5660300002)(4326008)(6486002)(186003)(2616005)(54906003)(110136005)(508600001)(6512007)(71200400001)(6506007)(7416002)(66556008)(66476007)(64756008)(8676002)(76116006)(8936002)(66446008)(53546011)(66946007)(316002)(91956017)(31686004)(558084003)(86362001)(2906002)(36756003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?UE45SDBjVlIraVRQaFkxSXBFV3dQaGFhdzNpYXhoeFp5Q2QyZzBTR2dEUm5E?=
 =?utf-8?B?WEs4NXVhT1orNTZheFBQcytBanZXTjN4ZS9Tdk5oNERRbnNXQlNuV1BjSHNU?=
 =?utf-8?B?NC9jTmZKalpaRVRMN0MreC9qVFRLY0JCMytKTzNhVzRoeVRGMjF1c1Q5VTVJ?=
 =?utf-8?B?UURCZWZMQ1Y2eXc4WGJPczFLRW1zWHlGdlU5WU1UK1pwdzcwMjQrOENTM1E2?=
 =?utf-8?B?bU11TnVVakFOc0pvRHBqQ2JTb3FBK1B6Q2FWaGVIRlkwVmRKNGIwY1V1N2ph?=
 =?utf-8?B?RXFjR2N6YW9UbUdYTkNSNm5tYVBwdWR6MWNPWlBDVVdPQ3UvdmdsSVFHOXl5?=
 =?utf-8?B?TGl3VktDNFdWRG9SU2xUKzV2Rm9KWUFBdzdZbldDOGlncFhzbnRYdWNJQmow?=
 =?utf-8?B?aFdFTGQ1cjhvUS92NmN1RmlDSE1kdWV0YktBZ2dkS2J5U1dteW5GTW9PSzNO?=
 =?utf-8?B?UW5JZlFqSjVPREtQTWdScHZKaytXckxnejFHNUYxOXozUWdqNW9ibkFBUS9u?=
 =?utf-8?B?TXFORU1kUDkyVWpZNElQUnoxSi9XTEFQNnJEellVSXcybnNCT2FWWVNMeHJU?=
 =?utf-8?B?MXcvZXlTT0krUmlhVVFkQ2Q4OGVrYjk4cjhsVm9Ibm1xTjdMdGdoVWcwbTJE?=
 =?utf-8?B?bHFtYXVXeHp0cW41eWI2VTVBQkFjcmJWZGJQbGZKeDdQRnNyRjVaVlB2NWk2?=
 =?utf-8?B?MnVFSm03V1dnUXNsTm5ubWEvUjRnb0F2cDhXemFkaEtnYzJibHh0d3RFSHV1?=
 =?utf-8?B?RmlqdnRRWWpFVEVBNUZNWjFmODFLNkVmWE01akFmUklpTzNhMjBIWXVIZDF1?=
 =?utf-8?B?Q2pGTjlibERiNkpkeTNQYW14RVVGaWJISU5CdUNWTW5icXU0cG0xQVJ3TkN1?=
 =?utf-8?B?cGQ5VWhzTnNZSmtIblFyVVJuaEp5cGRpeXlTNU5oMmRRdVNBdVQrVlFWNEdY?=
 =?utf-8?B?ZlF2ZUtYTUVwRjRuN3RPVkxCY0ZIUURkdlJGRUkzdnByMGJoRDcveGcxbUFL?=
 =?utf-8?B?T05ZY3M4bktoNXlIdGkxZXk5VVM1STJrZHMyTDF4VnQ1UXE1bVc2V1Z6djcr?=
 =?utf-8?B?VFp6cW94RmhFZzRUdXNGdDkyVWlRRUhPR1JZUnNJSEdndHpHSk1lZ2ErVHl1?=
 =?utf-8?B?SS9LbzRjVlJCQm9IMk4rWXZkbFIzUnlZVUVWdXFHUFdLekUxeHg3aUVJcE5p?=
 =?utf-8?B?ejJKdDhVOTU3S20rNy9FOG14N2pCc3FDNDQvVk5YamhkMmt3RkYxMlJQaWRL?=
 =?utf-8?B?NWJnRHJKYStzam1OTTBxUFErdjdyTkl2QjF3Nk1sL3FFVFJRS2RVeGVLL1hy?=
 =?utf-8?B?NWtMcEVPUURwMk5aeHJCZ0d1U0xOQWFxRWYzL1VDZ0p1enAraGwyeG9LOUo3?=
 =?utf-8?B?Vm5senFER2FTUmttTGdXOEhqL2pwK0RvTS90UVpOK09xMzFGcHhtODhHYUtz?=
 =?utf-8?B?aEhCcXBqVUxMWmZmNEcrYzI0emJLN1hjbmlyL2pDOUtBSldyMDFWNVh2elpi?=
 =?utf-8?B?NHJqTE5vRmYzVmswQVYvNFI2QkxyRUw3V3ZzN2Z0QjRHRkZnSGJ4UG45SlpB?=
 =?utf-8?B?TmNiNnpYVVkzczlQWGE4bkF0UzNnZHFtMFkzTjg3d1grVWdBb1pweHZ1TWpl?=
 =?utf-8?B?WEljWGlNUHFFZ2paUmR0WFY2RVRFKzZOTTRkblltL04xNVZ5b1R4NmVMN2t5?=
 =?utf-8?B?ZDJQYk9iQ0tGOHFnUXdNWXNxTlRZTEtzOVN0MktwUTBUd01oREFlSURkQWVK?=
 =?utf-8?B?R3h1SUYvNmN6U2tadGU0U1dKRiszczhLYnhhSXNXcXFHL29HcVRpRGVBczNH?=
 =?utf-8?B?Rko5aVBIblhEdlB4TGJRay9PbkkwWVNXNi9vdnYzWkkwY0lKQWk2bjd6N0JO?=
 =?utf-8?B?VGR0NkxSUjJHeHo0ZU5lRkt2N0dHVVdocXgwaytlVlo0Qmp4dlB4Ym0waGhL?=
 =?utf-8?B?MWtVQTlyWDd5SkUyR0E1c0d4QnIxMWxYbUUvOUVFWjk4Sy9hTlJIbkJ5a3FC?=
 =?utf-8?B?N3hvYzRUMlJ5M2oyRzRnYVcvTzc2a0dqRnhKUXVTY2FDL3NMcnZ6Q1BkWlpU?=
 =?utf-8?B?VEE0OGpEdDlBN3RKMEFWR3JiUFJQMnAySTMvbHBSbFBRcXU3aTVXdXlleHhI?=
 =?utf-8?B?Vm80bmE2RGsyN0d1WnZ3VThXRlVoVG9vS0lLbWJjK08vRE1JUHhvbklUcU1C?=
 =?utf-8?B?TnlBMXJBSzlBeGtoTjdwUnVmaXlQMFZIMDIvR2ZzN3ZXRVhIT0hpZkk3L21n?=
 =?utf-8?B?bnZzZWlTUUtvVVFTSUg2d1BYTjVXM0s5R3JkQXMrcDA5bllLS3FpdWlYdmNX?=
 =?utf-8?B?cFFLRmdGSkxHd0ZRY2tPdHdKdk1aVEs4TDE5S2x3L25EMzZrUnFKOGR6ZTRi?=
 =?utf-8?Q?PQoUgCYR9P1+D+Oo=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <41D9387E299FEA4DBE85A4EDA24D0FFB@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29c292e8-3de4-4b82-65bd-08da21817097
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 21:21:44.8408
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XFN+DIrHwXW4dMMfM+xmFlg+tyVkcF7I1h6/S9n/Q2biCyaj6At7SnFy02ZzrCvM3Xc6fVux9dDTKsDMn+vhYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5101

T24gNC8xNy8yMiAyMTo1MywgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFRoZSBsb29wIGRy
aXZlciBuZXZlciBzZXRzIGEgZGlzY2FyZF9hbGlnbm1lbnQsIHNvIGl0IGFsc28gZG9lbnMndCBu
ZWVkDQoNCnMvZG9lbnMndC9kb2Vzbid0Lw0KDQo+IHRvIGNsZWFyIGl0IHRvIHplcm8uDQo+IA0K
PiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4NCg0KUmV2aWV3
ZWQtYnk6IENoYWl0YW55YSBLdWxrYXJuaSA8a2NoQG52aWRpYS5jb20+DQoNCi1jaw0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307598.522785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYpJ-00052C-Ox; Mon, 18 Apr 2022 21:22:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307598.522785; Mon, 18 Apr 2022 21:22:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYpJ-000525-LW; Mon, 18 Apr 2022 21:22:29 +0000
Received: by outflank-mailman (input) for mailman id 307598;
 Mon, 18 Apr 2022 21:22:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lLCB=U4=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1ngYpI-0004XA-5R
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 21:22:28 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2061c.outbound.protection.outlook.com
 [2a01:111:f400:7eae::61c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a5371183-bf5d-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 23:22:27 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by DM4PR12MB5101.namprd12.prod.outlook.com (2603:10b6:5:390::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 21:22:25 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022
 21:22:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5371183-bf5d-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ahltv4baQgP64rZir2XmZjBKOiurntvq0NHiJGnyOiVp/Mih+c/7k9R/sOM7dVzJLL+ydo4sCfhW9EtD6QD4AWUebh355mz/JMDv8SKWWaXEFwz/5fZkGFtVseUMjyfB66NsnYQDFMlONPuA5twN1kE1qgb7VdGAiZk928q9vEGnCuyRDda62UhJduuhL5i64q3gnwJSvLyZG3pwQRtf0yi35qmffvSH/w1aD1nU5C3nCv8bV+8zaWK2eLilrtnER5Ang6YQDtjgFiPS9TxiExtLITGIcjlrEDDV4YzeU94egJ2IG6Nj6rTaQ96pShsBrBzHOGf+5AC63Q/rad08jA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vHAtozakIa+rugaZJkDU64nrzSb8M+UK1EwDJHNwVhQ=;
 b=QLLkL5Ftm+W1VR/afboZaZBgiD6BsYT9Kl6++CYVzWq7c6FSSHLV2b1+ClMEOocv0PNLuqUCTMjj9aWB3Ftu2wBL6S6v9WmSwL2SU9kfxChyejoVXP49prZ+2s9gBs/FuB67U8e9K7ZHyZHQt0WP5OOiSUy3m4yXe6tV+Kn41irBAtqs7OnCepuZtUZKV+e5wUUMwO3nX535roLB31fUUwIEW/GXQixrZkxll6mDd5/LhRqgoZeKnG3rKAEIz7bDpD9rTq2Top909NpUIjY2pjA0nL1iNE17aHKlUb7FAhrRTYNf/qW7BOCd51WXrDCG+23xrKBmz0i7kbG41BKk1g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vHAtozakIa+rugaZJkDU64nrzSb8M+UK1EwDJHNwVhQ=;
 b=i9E5C5fkyINkyhujSvZmmJrJXug111LbwYGi1FiuNlLfxmJpmceV2xJXfqLvNWhxb/53WAQ3LkiSPlZxSDy/o60pbUfaKW6zRA1Iw7vS6RcT5WIfgk2LpYUDjxoJ6oogKu6QLyjOuVZu8rDLREBWSyew8qwDp8JXcFQrNEyIiD9YN61zznIpwcdeJGwQIGCPhOSnEvNSFXErRO/BbsnQF10AQem3KMI5Vn5ks9Xmk317Gli7KVxlQJh9j682Cr/Nx7CZyu/ETGDvtPFy9tsWDn34bpWj3Z1UKeqflamo2PU+3Olt9GDd/gkk3lAHcHBLT7Ph93F7Pnumjw3FTJ3MtQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: Richard Weinberger <richard@nod.at>, Johannes Berg
	<johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, "Md. Haris
 Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>, "Michael S.
 Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Mike Snitzer
	<snitzer@kernel.org>, Song Liu <song@kernel.org>, Stefan Haberland
	<sth@linux.ibm.com>, Jan Hoeppner <hoeppner@linux.ibm.com>, "Martin K.
 Petersen" <martin.petersen@oracle.com>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH 03/11] null_blk: don't set the discard_alignment queue
 limit
Thread-Topic: [PATCH 03/11] null_blk: don't set the discard_alignment queue
 limit
Thread-Index: AQHYUuBbOHZrkZG1wkiLxi5X413wpaz2LwoA
Date: Mon, 18 Apr 2022 21:22:25 +0000
Message-ID: <89b62032-297a-1201-3a35-fa1731a0d620@nvidia.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-4-hch@lst.de>
In-Reply-To: <20220418045314.360785-4-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f9cd3ac9-a34b-453e-372e-08da218188bd
x-ms-traffictypediagnostic: DM4PR12MB5101:EE_
x-microsoft-antispam-prvs:
 <DM4PR12MB5101D98C45971BA44D603479A3F39@DM4PR12MB5101.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 aRpHrH2zfUblOq5eGVmc/JRpRc6KZNhp5dR+XBuco/SHMe93F0bxC2UTJLLOm2T+6EdQ+c4XeV+ul0kQHLz2Vnn1y0V5QEmI103RjJRobjFKKxPfVxaWndfqq6qT3iYhthYrZJT6dIoYhHGYfKyqTlfDZrIGK0R6BiRt4g5uiCf2x0bcl2DWontr5Dr61AmhQloenQKAgsEU5INA/q4qu+9FjAJLos21upgt82THgXyhKD8QSrW8opFfz/Y1+NDrDPaEgRSxXF8RK4/StZnJg1Fom3RNUryA3xXkr+shyyzD+Fv5nl+YITFaersVxhpvxjG6QmQH1kgno3SL9vK0+uHcaaPdOVm4DI/DE8Zm2jPe16n8zhEHPVmzdxmyNaE4rT/U6r4ZlrOrOYEEGiUCQHROMX4m8wMp+sN0nfUCAgOTkNWFxbp/jrUNrL1NrOF3BjOyA7c5ZcaFN0F9cnQ7Eu6PMJDEmRB/sCpGgSEFtFaQap9vAzzBpgIaluqI7qffiUoiiBFV4QO2yqqdGlUl6eoefFlGZTwEqBeWJq887fm0UXYYU3MotTAl+4zbvEZ1wtXpfNM3KX3QcoeuaWGC6zN3GxRx6UYqfCjjdkW9fAgDbBMsse15a+S1BG6yE7SJEiDs0xP7T4Li5r0GN9gD/KajsmHdSpTiCzxmISh6t4H1eQOT0+h8IYRRwH2wYFOACxRDoNc/TXQAXy6iL5I0WnGIFQL8hiNjNez18GCbfLQn1KNFYZ6WzKUvEj1kncFHCTcolnhLCH87Zl2bO/+DTA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(122000001)(4744005)(38100700002)(5660300002)(4326008)(6486002)(83380400001)(186003)(2616005)(54906003)(110136005)(508600001)(6512007)(71200400001)(6506007)(7416002)(66556008)(66476007)(64756008)(8676002)(76116006)(8936002)(66446008)(53546011)(66946007)(316002)(91956017)(31686004)(86362001)(2906002)(36756003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?UHlwcE9FdWtqUDhXN2M1c1lUQ2NEbk52YnlWd1drazN0OXo0NXZMQkhTTjRU?=
 =?utf-8?B?UVp5WDlnN01SYk5VSFlhdmlBRHFLdjNzTnN1ajhINUdsM2RNYkhtZnhqcTdv?=
 =?utf-8?B?TlVQSmtTRGFWd3FWNVpqNERvSnVEUTFvUGloWWRpKzNCbm5KWHJobXVPMzNH?=
 =?utf-8?B?a0kvKyt3cmpJWVF2QVo2Y3dwOUJjNVlRTm50UTVzM010eXdjM01MQWpZVWg3?=
 =?utf-8?B?QUR0c2ZHSFh6N1QrRkU4SHJlMzVBYW1jcGpvdkY0RS9ady9YTFZsUVZDSjBr?=
 =?utf-8?B?VWdLSEtkdGRlbWFreGVSaWNkak1ZU2ZFNFJ5ZjNBN3hDdmpaeGNydUFZdlFZ?=
 =?utf-8?B?eG9JOVRyVlRheG1jNklhZlgwRGEvanBmV2p5MVRncGNZWnhUQ3hNZEVuaEFI?=
 =?utf-8?B?L2VUMzR2TTVwSUJROUpkd2l1blVDelhXcWhudmZRV1d4S05LTGZLOFg0cVhF?=
 =?utf-8?B?RkFiOVU1K0c1eVd5bXZnbGxraE5GM1dMYzdaZTdjbnA3STZPOHYyMTc5MHY2?=
 =?utf-8?B?SVZRdEpRSVNPTjJGc3dqQnhYS25hdTdNMU1wOFlaVmxoNkFrbkJ6ams0c1Zi?=
 =?utf-8?B?VlJqVEI0TlBiTTU4ckhDWVk1RnRhSGJEazRZdFg0THI3d3Z2dkx1bS9rQ2Zo?=
 =?utf-8?B?TzR6Q0g5QWF4VjVFcVZ0ZDdUQjJVMU5ySTdqN1M2UFdvakZhdlZ4enpaRTRK?=
 =?utf-8?B?NHhjVGRNbHA5WW5Yd0x6NkVXTjZoYVV1NGFxY1F4VmlaKzNpL3dJZmsycVhl?=
 =?utf-8?B?NVJ4MHBHczBvMWZNYzFmcmswVUVWSEl3S0N2dkVKVVpwelpFSytzQUU1bVJ4?=
 =?utf-8?B?QmUyTHgvYUtCTWphMnAxSjVlcDcwcENFcGgxQjBPbEVwTkRLZHF1K1hOM2hK?=
 =?utf-8?B?Q1o5cWdsNGRSQ3RvdXZQR3JOcVZLNFNVWk92NlQyNkdPOVFhM1c3L3Viek02?=
 =?utf-8?B?ZGJYRkUzNzd4MVU2WlVxUEtLSXJHSWlOYlcwRjBoSTFzbnZSMFlVWm1yL1FW?=
 =?utf-8?B?ZzI1bEs0MEgydFhtNXBtMHR1aEpFK1dwRHMrRitiUmJYOU8weU04MytDamth?=
 =?utf-8?B?ZFBGNkNrOGhUd0xYMGU5cktxZjI2RWw4Vll4ZEZxSDQxMVFsT1hyZm9EUFJy?=
 =?utf-8?B?NTVCYVF4YkpTdVZDS002UVo0Wk9qQW1EWldBTlZGb1hCV3JrM1ZkU2tkTlIz?=
 =?utf-8?B?Y3k5UmQxMHd0WWFCR0d0b3FVdnlmQUhYUUlXYml5dmJ3NElpVmtZRFhFMkFJ?=
 =?utf-8?B?ekwwR0ZnY3VVazZHZzFBS0hua3RqVkU2Y3J4WnRhc0tWK2t0cE82c3hxWUpG?=
 =?utf-8?B?YkNBUS9vZUg3aFF6R1hiQ2p5ckZTN05EUzFUTXRRamJ3amZHNHFLQ0x2WFoz?=
 =?utf-8?B?SDFuNWkxMzJNK1dVNDNRWHpyM1lZNzJkekwvdVVXRFpiUUsrTmc5ZTcvQUdv?=
 =?utf-8?B?OWZLYkJacWgxbWNCQ3hVbklzTEQxRjNBVWh4TGdjNStxOGdTYUIrdjhvS3Jp?=
 =?utf-8?B?dE5YakJtRVRVQTI3VjF2dUM5RU14eWVpQ3BBdjY5dUovVityNzJzUVBacm1D?=
 =?utf-8?B?VGcyMGhpKzhCd1hwQ3Q5Q2xWSDlNaXZvcFBDL1hlRDhEbjlvdUVNS0phaHpy?=
 =?utf-8?B?ZWNpcjZJTytQTG5yMXFGUCtXYk1MWWNuai8rQVRvTzRvYUkvK0tMRGZVdXN6?=
 =?utf-8?B?WXZJcEk5UHJlNHZyVE1vZzdsS1ZTaGlkRkdqdkc1VzhzTXQ2TzJ1SEY2UjZo?=
 =?utf-8?B?ZmJlTlNSdC8rb3pBVmxmNFNGRWQ4b0NBd3BQZ21EeWFOUnZRUmttdkhic2RU?=
 =?utf-8?B?MlhLYm5WVnZWcU1URlZZZmNCMWZYencvbHJZZGJHNmdLNm1qc0lJdXM5dEcv?=
 =?utf-8?B?dXI4Z1VyM2llU1J0dEhtcFc3SE16NjlxbmxNU2RxZlE3WGNYZGNEOGREM3Mw?=
 =?utf-8?B?elRKL2JmNkNsa0pLNGNySzcwSUlFQ1RTcDh1WStUL0d5MjFzdTNZOUFGTTJN?=
 =?utf-8?B?eDN6RjlnMWd2VnpEdkhLL1dOVkVSZGNWVlNUaEpWOHBpZVBWVjF1ZHVqbjlF?=
 =?utf-8?B?azNRWU9La1VOdXF4SGpVM0ZUVTZvc2p0TFJSK3N3Q2hrRzU0NlVSNmZuYWZM?=
 =?utf-8?B?cnFldThZQkJlU3VaS0lrVE1TbHVoNTlkQks0OXRRWXhKdERMOWh3dTZnSGhZ?=
 =?utf-8?B?QTdPRVRTZExTRGlQU0ZsZnJrcy9naXRJa0RabEwyS05aSU9vc0wwN1MwYnRM?=
 =?utf-8?B?QkxLTzZqdkF2YUxwMlREbHhUQ25PTU81T1hObWwyZ1RnRm9YVUNjMzlzUzIv?=
 =?utf-8?B?WnBqdDMwT25mbXdjdWZQUFZMR05ySUJCUmxsdGM3NHdDbStyWFpGd3BlTWhR?=
 =?utf-8?Q?UaiVDBgSRkbWIBTE=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <ED7EE68D9ECC2E45BB1E6AA4E02C1AC7@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9cd3ac9-a34b-453e-372e-08da218188bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 21:22:25.3852
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ocsZWn2s6zKRxvQpyKeFcrsqFtOLj2JpUOEoP9+wJ9xZDYN6R4YaqeL0mZLa1xxmZ3QSO9WGmlE7qcBux2cerA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5101

T24gNC8xNy8yMiAyMTo1MywgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFRoZSBkaXNjYXJk
X2FsaWdubWVudCBxdWV1ZSBsaW1pdCBpcyBuYW1lZCBhIGJpdCBtaXNsZWFkaW5nIG1lYW5zIHRo
ZQ0KPiBvZmZzZXQgaW50byB0aGUgYmxvY2sgZGV2aWNlIGF0IHdoaWNoIHRoZSBkaXNjYXJkIGdy
YW51bGFyaXR5IHN0YXJ0cy4NCj4gU2V0dGluZyBpdCB0byB0aGUgZGlzY2FyZCBncmFudWxhcml0
eSBhcyBkb25lIGJ5IG51bGxfYmxrIGlzIG1vc3RseQ0KPiBoYXJtbGVzcyBidXQgYWxzbyB1c2Vs
ZXNzLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+
DQo+IC0tLQ0KDQpSZXZpZXdlZC1ieTogQ2hhaXRhbnlhIEt1bGthcm5pIDxrY2hAbnZpZGlhLmNv
bT4NCg0KLWNrDQoNCg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:23:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:23:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307603.522796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYq0-0005f5-7k; Mon, 18 Apr 2022 21:23:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307603.522796; Mon, 18 Apr 2022 21:23:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYq0-0005ey-43; Mon, 18 Apr 2022 21:23:12 +0000
Received: by outflank-mailman (input) for mailman id 307603;
 Mon, 18 Apr 2022 21:23:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lLCB=U4=nvidia.com=chaitanyak@srs-se1.protection.inumbo.net>)
 id 1ngYpy-0004w0-A2
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 21:23:10 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on20626.outbound.protection.outlook.com
 [2a01:111:f400:fe5b::626])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bdef2bdf-bf5d-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 23:23:08 +0200 (CEST)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by BYAPR12MB5703.namprd12.prod.outlook.com (2603:10b6:a03:a5::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Mon, 18 Apr
 2022 21:23:05 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::a90b:9df2:370c:e76b%3]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022
 21:23:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bdef2bdf-bf5d-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DCTnzYl+A3W1QQ39xpG5158yMEOX1tX8kBsBFih687ArE4aExk9nDwadSZOJxtI8eSLpXx7MMVEFXK+vWQ6T5HRTB3E2c/PH17fWAv1mmQCW9KcWzKW56S6J4IxDY1NN94HBCdbrsihxpT0/hZWVtVXrq4m2PQBnpNcXYs5imYg4lrolYDCf4zf9ILKuJ588bnQ1+8I3rB9U6mHLGokShUOmwt5ZwlDSkL/jN2NyqjR+TMB+H5gOHFWaHJR7gR2HXTRfvqQ0oKZtCXkrQfVUEejwTJ5S+uVLAhBsjmYuEdRWRDI9HdoNiqyx9ZyCFfDPYf0Ueqqv1bzzDfVaWl0xGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ylu+JR0gsLNhok9CksoK3rBzZXhje5IsRF+GG5APk2s=;
 b=NhyDGKEHIKHnZQ6i6J4WB9/rf2SbvqnX8fTvl5GbbeRZc+L+MDC9mt5j3Q6c4yVp+7gx4BkL2CQIHM9Mi1wgO7zatLHOyW80qXA93sWUBRWZWnINVY+QO6mee3wvwvl7CsUwmo4Zyk+52t3IcnCOLot5C1Wkgckzo6kq2FrX7N+5GaMYKp45W24MvOFsziVYqYvZBRT2xRaOZNN7Qt8mMWWvk3BMK6W0/c/uLGk7Km+ShDd3pKpHMPw5Hv+f9/J130cOmwQ4Yl8S5veSkYuwpP0E6RiSjORFAucri1YJvCS+0aRqtuWFVJSUl2IVnFMqLXbCpaVJw/zI2wujGo/kpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ylu+JR0gsLNhok9CksoK3rBzZXhje5IsRF+GG5APk2s=;
 b=EDDoBtO40FqhH6APtRLewO5ws0a/ttWuuMyQgjdR6zAnxJcQBjPBp8l2RrEvyJCGQWhoE3LqjgDnHPwYnSIM/C6FlHB6+3cRU6nNeKQkRLP9aiRQmx9LCnQ7U2TOmSLMCE3JqEl0L8Bun3T5hSpiPH7HiK15E9QhLyc1HYWmqcUjJHUlPS3+EZ0upPIyg6nqkq2Ls9jwQ49VrVXTvkujKbtqvEZRzEiZDnwj5GpL07WdWaRyJKQdco8D8vVmsWYEnPkn9avBBQNgjwk2TZyD3BCpW2egHzWEULxJvhFWHaN/Gq0j6jo+QA7g3caOjiChtPDpLBXS7FmJ6CMTJiCf7w==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: Richard Weinberger <richard@nod.at>, Johannes Berg
	<johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, "Md. Haris
 Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>, "Michael S.
 Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Mike Snitzer
	<snitzer@kernel.org>, Song Liu <song@kernel.org>, Stefan Haberland
	<sth@linux.ibm.com>, Jan Hoeppner <hoeppner@linux.ibm.com>, "Martin K.
 Petersen" <martin.petersen@oracle.com>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "nbd@other.debian.org" <nbd@other.debian.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-raid@vger.kernel.org"
	<linux-raid@vger.kernel.org>, "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH 09/11] nvme: remove a spurious clear of discard_alignment
Thread-Topic: [PATCH 09/11] nvme: remove a spurious clear of discard_alignment
Thread-Index: AQHYUuBcFEm/XfqSQ0uW2E3HX2krVaz2LzqA
Date: Mon, 18 Apr 2022 21:23:05 +0000
Message-ID: <66df636c-b98a-23f7-20f5-f124109b81c1@nvidia.com>
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-10-hch@lst.de>
In-Reply-To: <20220418045314.360785-10-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8ea33572-46a0-4def-4816-08da2181a0a0
x-ms-traffictypediagnostic: BYAPR12MB5703:EE_
x-microsoft-antispam-prvs:
 <BYAPR12MB57034654840D806181EA4705A3F39@BYAPR12MB5703.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 wZRIafoMZ+RNEv0jR3059UeyDTFK32ryaMGSLWdws/jWK1ZLHE9hYQAuxaagMVs/LEd/tpZiQVJDQf1nmESaKq+E5Cog4yW9qJs+ajxMRBm0ihATE22BxMXT67QvxcLPHLKUxtogqLjr2S3bccK0HG8KLBQgdD7S4N1dtflpco/vndZ9fHtv8ZVS44KE+gAB7iIu1cFQeZX00WRBwVkiIPbxklRZ7reZXWoinrMqonA+BbWykmn9TA6hOVhJkz+a4LV2zrC2nBas3p2lgORI24Re5BSDJaXDU71ZPwsW/FJY3K58yAj/q3xPJWAvcAzpClVyBI/ieTTMTanbP75jut6qk8WNQb7/Vn0m7SA19hWgKnRK/K+ONQrHCQR5N78AMkwuS+Fsl48/Y0Om1/cP0nF7aWaKnJ6dhQvQgK1wY+Lnmvoy+BE6li5iHNeJW1nlfWQ/A3HXyZ2MKDaObYA841BmXGhg3Fy4GVlTz/bkvccGcD5D0u5ncn7CJd9BRyI9HT4voIcBXJZEfYvnhiMQWgI+awGaihUto+et5YyvXTdHpJX1lg0tU6U3DQPO1sdLiez5LvX+/BVai9Rkxh846t7jct1VZnTXRVGqZYkIamc4I66l6G1W2ypSWvc6XABmk2hgEj3iAZbAcCsedSHS6h5dAxJXHpYA9nR2zGUkWfm0HSdv/eRAd8LZ6qz4Zjq5pVf670aNRxbNeWA42OmJ1kRJ7dXwgG38AMo2qb1kid+PSZXlzehAFA+FXLA4LD+7+h3ile31o23bjx8fvRA7Nw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(558084003)(71200400001)(86362001)(5660300002)(66946007)(76116006)(31696002)(186003)(316002)(38070700005)(6486002)(38100700002)(2616005)(122000001)(66446008)(110136005)(7416002)(54906003)(64756008)(91956017)(4326008)(8676002)(66476007)(66556008)(508600001)(8936002)(31686004)(6506007)(36756003)(2906002)(6512007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?K3JyUHJGTk9VOGd4ejRtQ2k2SktOU0RoODU2STdRZ2Juc1lvMFFsRzdBUkRm?=
 =?utf-8?B?b0hxTGpHME5nWGs0bkxZRE5KUUpLZjg2U1NmY1VLUHNRVG56YXVEMnQwWHRL?=
 =?utf-8?B?YXNGQmNISmNxQjRxV2F5am1VZU5sV2hhb0ppSGtUT242b0U3OWVyUTE2eGt5?=
 =?utf-8?B?cnhLeHpNRC9uQ2hQNTFJNE9vWTkxUVRndmpnYmYwVjdqVDJnMldhVFhxVmhk?=
 =?utf-8?B?RTAvbm9yZVYxbDBDdlpWblJxRldKMVk1OVcwWi8xQWhxd1JVN0kzeHpsRkZC?=
 =?utf-8?B?M1YxMEoveUpVT2YxZFB2T2NmSkNBOGRlV0p5ZG43STJBMW1vVFJMdXNHUXVK?=
 =?utf-8?B?K1UrL21mcFk1Z3Nta3N2Y0xncE9tZnB0S1FKTzF3OHQ5VkNvYUtxUEgvYkVR?=
 =?utf-8?B?Y3hnWmY3ZGdQZEVuL2JaK1FndE9iaEJxbkJuSmFkZGFxckEyMTJkdEJ0VUFh?=
 =?utf-8?B?M2VlbUxXTVgwWUh5TGxqbkQyNUVTU05QcHRBcm1XQUNla0VKTzY0UUFYODAr?=
 =?utf-8?B?MjZucUQ3VDRpazRZRTFWeGt2QXZDWXhrdWowTjBUUHpwYUVvK0dYVnpiVE5l?=
 =?utf-8?B?Q2NKNEo5Z3ZuSlN4bXVvK3FvaHlUdHJTZVNLenBEQm53ekpiekxNeGYvOXZh?=
 =?utf-8?B?WUZLQjR6dWlXczl5VXFmVXg5TkplY1UzeWdVMGFzTmlaaGlBZjJETEhVbjhx?=
 =?utf-8?B?eFU0SXdBZ09zOEZtQU1rc2tIR1NlRTFzQXNzZnpWM3RCdE5rOXZKV1FwMksy?=
 =?utf-8?B?NFBralNBei9kOG1PWlhCZmFFa0szY1I5WHlZR3J2am5FMEUwRkp4Zk42VTc4?=
 =?utf-8?B?N3J6L1Z5YURoRVphVjMvdmxiR0NwMForU21QblVXUWN6Y2hOVTM4LzBqeUM4?=
 =?utf-8?B?NXV4aFlLUFFrdHpza1RtN3A2TkhDYnN5ZEZuRnlQVWRta0JiQTd1aEVQL2d0?=
 =?utf-8?B?ZlVXVVUwdllzTzFYN2dqQWVhNjYxVGZ5bUJEMXM0NGZHdnlsUUFSRFVVU1FF?=
 =?utf-8?B?TzhJQmhpZ0hZSG1oVjl0ODhsRXlYOC9lVVBETEZlaEZXWkhhNENnbytlYlJP?=
 =?utf-8?B?bnpyVXlMaE5XNzhUMFVYclF2aTFFQ2d4ZkUwTFhuUWxTRmpiSmYydnFYdHhh?=
 =?utf-8?B?bG9BWFp3TFcrVW1KN2xBWm84dnY1N3FoZ0NQcFhYRGtIeUM3ekxrVGFXL2Fk?=
 =?utf-8?B?NWRZQkVHZm1xb1I4RUt5Q0lKb2d4c3NSNkdlS1ZhTVptNjBQUUFhZHdXS09H?=
 =?utf-8?B?ZGxINlE1WDAzOUZNNlJObnVuaU93ckY1ZzJpMW9rYWN6c1RNdkZJdTBLTXZK?=
 =?utf-8?B?S1BJZnF1YXEyWmpiNVhNNXZ0d0FxZ0dDZHFOVm1URi9YUzMxc0VBMWFuSm94?=
 =?utf-8?B?L0xBWDhTUldOQjJZOG8xYnVzOHhWVzBvcDN4UmJmN0VadWd6OTZIVE16TTF1?=
 =?utf-8?B?OUxVbCtOOVRZR0oySW8raDhLalh6SDhwZXV4ZGI1aTVFWkh0ZTc3MUwvS1lC?=
 =?utf-8?B?UjVRdE9NWDJrRWdMKy9iaXRMMTV2c1VhLzBFVW4yU3JTblpicHQ4cDVPNC9n?=
 =?utf-8?B?b1VpTVN4b0VHalZVTzJrNFpTWHBreHU4L01IZE1VOU9LNHh4TWRBcXFtY1oz?=
 =?utf-8?B?RWVvVDYvYmRzUCszVE1adk4rNUp0Y3JSOHRNeVdOd3lvZCtEcTdWMFMxQTFM?=
 =?utf-8?B?bWNHVytkWXVjakNmKzgvV1RzZ01EWGFZdFRHYlVHSXNFSGxFODZqOTJJN2xI?=
 =?utf-8?B?RllFTHBybk1zeUxnU2FEbVBRa2tGWDNWcTRScTE4TWtvQ1R2bEQvQ25SWFd5?=
 =?utf-8?B?d0lWcWw2aURlYzR0VDZpay9SZy84VGVSU2tCSnlLOE9ZZ3ZseExMU2pUM1ha?=
 =?utf-8?B?bzg3SjJSc3I1V21Xc0FPOUVrci9LQmx5SkxpZThDRjdkTTEvdVk2ZWF4RXp4?=
 =?utf-8?B?NEhlK1NKdjBiU1gxT0k4UFA3U1l2cWRpNlprSnd2cVQ4SG5aWWIrdTRKVkto?=
 =?utf-8?B?QnFNU0hucTl1QWRwKzJaUFMzNTN2aVh2dGRJZEdkYUpKVCtPY21sVUtWbHor?=
 =?utf-8?B?L2ZRSkZBYjVQK1Jpd3dzcTNQRmltaDVXbVp2Zm4yVUE5azdFUTc5MEtWdVJ2?=
 =?utf-8?B?Wk1XQ0NmTEJHQnptT0tpNERWdXVzbk9xbG11VDBjMFpQNmhqK05tMkNKaTAw?=
 =?utf-8?B?T0tkbVhwSjZrMDEzR0lnMDgwak8zZVlXMXg5OVNlOWdBc0trSnpyellyWERK?=
 =?utf-8?B?L1dtT3FLaTYvUk9RdFU1NEFOSHFhOFNHcTJHQ3hBMkNDbSswUkd2K1JBMUNS?=
 =?utf-8?B?R0dUWEt1eTJXWExteGIrczUzWXMvVXE3eUIxejVJdVFneEQxZFR2SzBJVDc5?=
 =?utf-8?Q?3ThODCQ/tQz/cwX0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2261F5F6E0810744877DAE4E412E6B80@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea33572-46a0-4def-4816-08da2181a0a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 21:23:05.4140
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bX94/9AH8QVpG+ra0QBfSC7XQkW0/5sNBc2d1BEGlO4VFk0lgNSO6gOFfRnduTdTtrVmVUtGs0aqwIqvFg029g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB5703

T24gNC8xNy8yMiAyMTo1MywgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFRoZSBudm1lIGRy
aXZlciBuZXZlciBzZXRzIGEgZGlzY2FyZF9hbGlnbm1lbnQsIHNvIGl0IGFsc28gZG9lbnMndCBu
ZWVkDQo+IHRvIGNsZWFyIGl0IHRvIHplcm8uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3Rv
cGggSGVsbHdpZyA8aGNoQGxzdC5kZT4NCj4gLS0tDQoNClJldmlld2VkLWJ5OiBDaGFpdGFueWEg
S3Vsa2FybmkgPGtjaEBudmlkaWEuY29tPg0KDQotY2sNCg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:29:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:29:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307613.522807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYw8-0006PU-UW; Mon, 18 Apr 2022 21:29:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307613.522807; Mon, 18 Apr 2022 21:29:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngYw8-0006PN-R9; Mon, 18 Apr 2022 21:29:32 +0000
Received: by outflank-mailman (input) for mailman id 307613;
 Mon, 18 Apr 2022 21:29:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngYw7-0006PD-FC; Mon, 18 Apr 2022 21:29:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngYw7-0006qT-9R; Mon, 18 Apr 2022 21:29:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngYw6-0005iM-Qy; Mon, 18 Apr 2022 21:29:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngYw6-0007My-QV; Mon, 18 Apr 2022 21:29:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AdH6gkIFjW4TjrGE7ZowpJUTSdBI4EGt//vpVejgqEU=; b=W9xrM6NpgiVm8BdgkPIMYzb/ff
	sPOVv3/ZxPsuqmIgA6+Pcm9BQWfewb5ejgYEGpUd3j+zOrDxC3sJo3sEdfPk6r4u7j8v6Gk7NYimX
	xsQrIlpLLKRl2z56uhh3T0juaU++aVW2LmyRtfxm9P9rtdvJ8p0XIkiALmdLOTgPHtKs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169522-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169522: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 21:29:30 +0000

flight 169522 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169522/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  491 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   67 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:36:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:36:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307621.522818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngZ2w-0007wT-N1; Mon, 18 Apr 2022 21:36:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307621.522818; Mon, 18 Apr 2022 21:36:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngZ2w-0007wM-Jb; Mon, 18 Apr 2022 21:36:34 +0000
Received: by outflank-mailman (input) for mailman id 307621;
 Mon, 18 Apr 2022 21:36:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FkDd=U4=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ngZ2v-0007wG-8K
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 21:36:33 +0000
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9bc2f5fa-bf5f-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 23:36:31 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 6773B5C00E2;
 Mon, 18 Apr 2022 17:36:29 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Mon, 18 Apr 2022 17:36:29 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 18 Apr 2022 17:36:28 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bc2f5fa-bf5f-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650317789; x=
	1650404189; bh=jaVPkCHjJZvy8W69XBYb9VIwIp1IMXE4f8+LGNc37jA=; b=Z
	JvYTwfNqdryzXq1O9EEEDFzGElszNPUm304mAPfr3UwvrfaHf5FeRcC5wuDbI5jB
	6+y8wgQQpgv0oKsno8GhMDBccOtxQyZUaB+kL3btKRIxN8rwF74dUtmPDnsYY5+O
	UtNWeTgzIfGdC+ejvQepqWubcMi2XnfY/wg5Soz0jGK6jVU8TP9YuZVoZNQ+81H/
	9lWf9r/GSTTISS2No3u69j0PSunC0q/XqtNQwVMjEg+Z/HKbaUA1lRQWt5a/sjtq
	Te2iY4/VAh2n0tygIIRHqFZx9GteyKEICrnC/HQJJf7JZZj4h0ttoTQPLMU+4oMv
	KRb2y6EuDedO7E/6obFzw==
X-ME-Sender: <xms:3NldYoIsDq-fC9TfubcuhJehhPibReupd5moWU_FWD-c7v4idKtNYw>
    <xme:3NldYoLb01AMXneladr2bC44d0q73v7li7-yl50Xo1kVcQ4A8A1JO7HURViClqJer
    oujxo4RotL2tyA>
X-ME-Received: <xmr:3NldYouao9CeeAG6YLjlpNZQzMavsETQSw6xrQp67t_5EARkKW9h5Wnk-xqS>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtvdcutefuodetggdotefrodftvfcurf
    hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr
    ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug
    hrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhiucforghr
    ihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsg
    drtghomheqnecuggftrfgrthhtvghrnhepvdefleelfeefteekueeuvdfgtdegveekieff
    geeuffeuudeitddvkedtjedvueejnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenuc
    evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:3NldYlYbiRkfQln5teLiLwFnPeA2R2csCAJr5KFgE3BboOUS9j1n-Q>
    <xmx:3NldYvarexHTZqKrUejxBxsMxXEUpULRZgMAq89YdvNs9fkV6HKyvQ>
    <xmx:3NldYhDY1enbrQ4_CXZ4oiZRup-5rM6aMtVDYuTDw9Avl1TdzTRVpw>
    <xmx:3dldYkO2RyXS-d5LvKdgAxNtVT4ZSL2DyLeoR8xX_jRwu4icmCPv5g>
Date: Mon, 18 Apr 2022 17:36:22 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] Grab the EFI System Resource Table and check it
Message-ID: <Yl3Z2nilGQemHZnr@itl-email>
References: <YkeHXFvgB3MwXnuR@itl-email>
 <72ed7420-5f01-6cf4-b1fd-dd2186162a20@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GzkyR82Ue5kMn+dX"
Content-Disposition: inline
In-Reply-To: <72ed7420-5f01-6cf4-b1fd-dd2186162a20@suse.com>


--GzkyR82Ue5kMn+dX
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 18 Apr 2022 17:36:22 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] Grab the EFI System Resource Table and check it

On Wed, Apr 06, 2022 at 12:10:17PM +0200, Jan Beulich wrote:
> On 02.04.2022 01:14, Demi Marie Obenour wrote:
> > The EFI System Resource Table (ESRT) is necessary for fwupd to identify
> > firmware updates to install.  According to the UEFI specification =C2=
=A723.4,
> > the table shall be stored in memory of type EfiBootServicesData.
> > Therefore, Xen must avoid reusing that memory for other purposes, so
> > that Linux can access the ESRT.  Additionally, Xen must mark the memory
> > as reserved, so that Linux knows accessing it is safe.
> >=20
> > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/
> > for details.
> >=20
> > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
>=20
> First a note on patch submission: Patches are sent To: the list, with
> Cc: to involved maintainers (and perhaps other interested parties).

Sorry about that =E2=80=94 I am used to Linux which does things the other w=
ay
around.

> > ---
> >  xen/arch/arm/efi/efi-boot.h |  9 +++--
> >  xen/arch/x86/efi/efi-boot.h |  5 ++-
> >  xen/common/efi/boot.c       | 77 +++++++++++++++++++++++++++++++++++--
> >  xen/common/efi/efi.h        |  2 +-
> >  xen/common/efi/runtime.c    |  5 ++-
> >  xen/include/efi/efiapi.h    |  3 ++
> >  6 files changed, 89 insertions(+), 12 deletions(-)
>=20
> This being v2 (oddly enough with another v2 sent on Mar 30), you will
> want to add a brief revision log clarifying to reviewers what has
> changed. Together with the duplicate v2 it's not really clear whether
> this was a plain resend, or whether anything actually changed (it
> looks like you did address the Arm build issue).

Only change was to break the ARM build IIRC.

> > --- a/xen/arch/arm/efi/efi-boot.h
> > +++ b/xen/arch/arm/efi/efi-boot.h
> > @@ -176,7 +176,8 @@ static bool __init meminfo_add_bank(struct meminfo =
*mem,
> > =20
> >  static EFI_STATUS __init efi_process_memory_map_bootinfo(EFI_MEMORY_DE=
SCRIPTOR *map,
> >                                                  UINTN mmap_size,
> > -                                                UINTN desc_size)
> > +                                                UINTN desc_size,
> > +                                                const EFI_MEMORY_DESCR=
IPTOR *const esrt_desc)
>=20
> Please omit the 2nd const (here and elsewhere) - no other parameters are
> modified like this.

Will fix in v3.

> > --- a/xen/arch/x86/efi/efi-boot.h
> > +++ b/xen/arch/x86/efi/efi-boot.h
> > @@ -154,7 +154,8 @@ static void __init efi_arch_process_memory_map(EFI_=
SYSTEM_TABLE *SystemTable,
> >                                                 void *map,
> >                                                 UINTN map_size,
> >                                                 UINTN desc_size,
> > -                                               UINT32 desc_ver)
> > +                                               UINT32 desc_ver,
> > +                                               const EFI_MEMORY_DESCRI=
PTOR *const esrt_desc)
> >  {
> >      struct e820entry *e;
> >      unsigned int i;
> > @@ -171,7 +172,7 @@ static void __init efi_arch_process_memory_map(EFI_=
SYSTEM_TABLE *SystemTable,
> >          {
> >          case EfiBootServicesCode:
> >          case EfiBootServicesData:
> > -            if ( map_bs )
> > +            if ( map_bs || desc =3D=3D esrt_desc )
> >              {
> >          default:
> >                  type =3D E820_RESERVED;
>=20
> How certain is it that this descriptor doesn't cover (much) more than
> just ESRT? This could be quite wasteful in terms of memory which
> wouldn't be reclaimed just because of the (perhaps small) ESRT.

I can=E2=80=99t be certain at all, but this has the advantage of a much sim=
pler
and smaller patch.  I don=E2=80=99t intend to fix this in v3, but I will se=
nd a
follow-up patch that fixes it for x86.

> > --- a/xen/common/efi/boot.c
> > +++ b/xen/common/efi/boot.c
> > @@ -93,6 +93,23 @@ typedef struct _EFI_LOAD_OPTION {
> >      CHAR16 Description[];
> >  } EFI_LOAD_OPTION;
> > =20
> > +struct esrt_entry {
> > +    EFI_GUID fw_class;
> > +    UINT32 fw_type;
> > +    UINT32 fw_version;
> > +    UINT32 fw_lowest_supported_version;
> > +    UINT32 fw_capsule_flags;
> > +    UINT32 fw_last_attempt_version;
> > +    UINT32 fw_last_attempt_status;
> > +};
> > +
> > +struct esrt {
> > +    UINT32 esrt_count;
> > +    UINT32 esrt_max;
> > +    UINT64 esrt_version;
> > +    struct esrt_entry esrt_entries[];
> > +};
>=20
> Please follow the naming and naming convention used by immediately
> preceding structure definitions as well as the specification: All
> names matching the spec and using typedef. That's how such structures
> would eventually be added to the EFI headers we're inheriting from
> the gnu-efi package. At such a point we would want to be able to
> delete the declarations here without needing to touch any other code.
>=20
> > #define LOAD_OPTION_ACTIVE              0x00000001
>=20
> Also please don't insert in the middle of two related definitions.
>=20
> > @@ -567,6 +584,38 @@ static int __init efi_check_dt_boot(const EFI_LOAD=
ED_IMAGE *loaded_image)
> >  }
> >  #endif
> > =20
> > +static UINTN __initdata esrt;
>=20
> Don't you need to initialize this to EFI_INVALID_TABLE_ADDR in order
> for ...
>=20
> > +static bool __init is_esrt_valid(
> > +    const EFI_MEMORY_DESCRIPTOR *const desc)
> > +{
> > +    size_t available_len, esrt_len, len;
> > +    const UINTN physical_start =3D desc->PhysicalStart;
> > +    const struct esrt *esrt_ptr;
> > +
> > +    len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
> > +    if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR )
> > +        return false;
>=20
> ... this check to actually be useful?
>=20
> > +    if ( physical_start > esrt || esrt - physical_start >=3D len )
> > +        return false;
> > +    /*
> > +     * The specification requires EfiBootServicesData, but accept
> > +     * EfiRuntimeServicesData for compatibility
> > +     */
> > +    if ( (desc->Type !=3D EfiRuntimeServicesData) &&
> > +         (desc->Type !=3D EfiBootServicesData) )
> > +        return false;
> > +    available_len =3D len - (esrt - physical_start);
> > +    if ( available_len < sizeof(*esrt_ptr) )
> > +        return false;
> > +    esrt_ptr =3D (const struct esrt *)esrt;
> > +    if ( esrt_ptr->esrt_version !=3D 1 || esrt_ptr->esrt_count <=3D 0 )
>=20
> Nit: I think unsigned values would better not be compared for "<=3D 0";
> this wants to be "=3D=3D 0" (or simply use the ! operator as we tend to
> do elsewhere).
>=20
> > +        return false;
> > +    esrt_len =3D esrt_ptr->esrt_count * sizeof(esrt_ptr->esrt_entries[=
0]);
>=20
> While presently we support EFI only for 64-bit architectures, this
> can overflow for 32-bit ones. Better to guard against this right
> away. This could be achieved implicitly by ...
>=20
> > +    return esrt_len > available_len - sizeof(*esrt_ptr);
>=20
>     return esrt_ptr->esrt_count <=3D
>            (available_len - sizeof(*esrt_ptr)) /
>            sizeof(esrt_ptr->esrt_entries[0]);
>=20
> (also correcting > to <=3D at the same time).
>=20
> > @@ -846,6 +895,10 @@ static void __init efi_tables(void)
> >  {
> >      unsigned int i;
> > =20
> > +    BUILD_BUG_ON(sizeof(struct esrt_entry) !=3D 40);
> > +    BUILD_BUG_ON(__alignof(struct esrt_entry) !=3D 4);
> > +    BUILD_BUG_ON(sizeof(struct esrt) !=3D 16);
>=20
> What are these about? I don't think we have similar checks for
> other interface definitions, and I don't see why we would need
> such.

These are there because I wanted to make sure I didn=E2=80=99t mess up when
writing the struct definitions.  Will remove in v3.

> > @@ -854,6 +907,7 @@ static void __init efi_tables(void)
> >          static EFI_GUID __initdata mps_guid =3D MPS_TABLE_GUID;
> >          static EFI_GUID __initdata smbios_guid =3D SMBIOS_TABLE_GUID;
> >          static EFI_GUID __initdata smbios3_guid =3D SMBIOS3_TABLE_GUID;
> > +        static EFI_GUID __initdata esrt_guid =3D ESRT_GUID;
> > =20
> >          if ( match_guid(&acpi2_guid, &efi_ct[i].VendorGuid) )
> >  	       efi.acpi20 =3D (long)efi_ct[i].VendorTable;
> > @@ -865,6 +919,8 @@ static void __init efi_tables(void)
> >  	       efi.smbios =3D (long)efi_ct[i].VendorTable;
> >          if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) )
> >  	       efi.smbios3 =3D (long)efi_ct[i].VendorTable;
> > +        if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) )
> > +	       esrt =3D (long)efi_ct[i].VendorTable;
>=20
> I think all the casts to "long" are bogus here. At the very least
> this ought to be "unsigned long", but I think in your case it
> actually wants to be UINTN (the destination variable's type). Also,
> while I guess you simply derived the two new lines by copy-and-
> paste, please avoid introducing yet another instance of the pre-
> exisiting indentation issues (hard tab and too deep when tabs
> expand to the usual 8 blank positions).

Will fix in v3.

> > @@ -1053,19 +1109,19 @@ static void __init efi_exit_boot(EFI_HANDLE Ima=
geHandle, EFI_SYSTEM_TABLE *Syste
> >      EFI_STATUS status;
> >      UINTN info_size =3D 0, map_key;
> >      bool retry;
> > -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
> >      unsigned int i;
> > -#endif
> > =20
> >      efi_bs->GetMemoryMap(&info_size, NULL, &map_key,
> >                           &efi_mdesc_size, &mdesc_ver);
> > -    info_size +=3D 8 * efi_mdesc_size;
> > +    info_size +=3D 8 * (efi_mdesc_size + 1);
> >      efi_memmap =3D efi_arch_allocate_mmap_buffer(info_size);
> >      if ( !efi_memmap )
> >          blexit(L"Unable to allocate memory for EFI memory map");
> > =20
> >      for ( retry =3D false; ; retry =3D true )
> >      {
> > +        esrt_desc =3D (EFI_MEMORY_DESCRIPTOR*)EFI_INVALID_TABLE_ADDR;
>=20
> Nit: Missing blank before * and perhaps wants to cast to pointer-to-
> const.

Will change in v3.

> > @@ -1074,8 +1130,21 @@ static void __init efi_exit_boot(EFI_HANDLE Imag=
eHandle, EFI_SYSTEM_TABLE *Syste
> >          if ( EFI_ERROR(status) )
> >              PrintErrMesg(L"Cannot obtain memory map", status);
> > =20
> > +        for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
> > +        {
> > +            if ( is_esrt_valid(efi_memmap + i) )
> > +            {
> > +                esrt_desc =3D efi_memmap + i;
> > +                break;
> > +            }
> > +        }
> > +
> > +        /*
> > +         * We cannot pass esrt because we need to explicitly compare t=
he
> > +         * descriptor pointers for equality.
> > +         */
> >          efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memma=
p_size,
> > -                                    efi_mdesc_size, mdesc_ver);
> > +                                    efi_mdesc_size, mdesc_ver, esrt_de=
sc);
>=20
> Since esrt_desc is a global variable, why do you pass it as an argument
> here?

I was trying to minimize the use of globals.  Will change in v3.

> > --- a/xen/common/efi/runtime.c
> > +++ b/xen/common/efi/runtime.c
> > @@ -52,6 +52,7 @@ static unsigned int efi_rs_on_cpu =3D NR_CPUS;
> >  UINTN __read_mostly efi_memmap_size;
> >  UINTN __read_mostly efi_mdesc_size;
> >  void *__read_mostly efi_memmap;
> > +void *__read_mostly esrt_desc;
>=20
> Why "void *" and not pointer-to-const?
>=20
> > @@ -269,14 +270,14 @@ int efi_get_info(uint32_t idx, union xenpf_efi_in=
fo *info)
> >      case XEN_FW_EFI_MEM_INFO:
> >          for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
> >          {
> > -            EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
> > +            const EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
> >              u64 len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
> > =20
> >              if ( info->mem.addr >=3D desc->PhysicalStart &&
> >                   info->mem.addr < desc->PhysicalStart + len )
> >              {
> >                  info->mem.type =3D desc->Type;
> > -                info->mem.attr =3D desc->Attribute;
> > +                info->mem.attr =3D desc =3D=3D esrt_desc ? EFI_MEMORY_=
RUNTIME : desc->Attribute;
>=20
> Why this override?

This tells the dom0 kernel that the memory was reserved by Xen, even
though it is of type EfiBootServicesData.  Otherwise, dom0 might think
that the memory has been overwritten with garbage.  I will use a
different solution.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--GzkyR82Ue5kMn+dX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJd2doACgkQsoi1X/+c
IsFTcxAA3hmh5pBHBjmWpI89qnoJC1h2u/DEni9ssTEVwm9ft4qHSnZ4rGQOtvTl
7+OxVdR6YTlSjs7fv6QCb3jQGuhHpZEUTmSQZeBMAg9rltBaQZcy+P8840eRb3HU
TZO0ZuBQRmdq/Qd6/28V/65fTKIg6Ag84pcIMMvlCToqf60wT/7psAy91kLkooZV
4XGyPFH4fitW7qpM9BSP31d+d8enaM0gJZEqRKDnaXjVVFtaFL+z0SodvJRszW5G
g3d1/xls2DouP0vheLU3NfGXiTQMPgCdx+pJCP/QVApGx2uK9rCdcyzJctNXqtdT
fWWcanzeWnFeLs++Wd7Q8np2ba9Ss7QHulLr0aud17xPoycL9ZvvhNH3iBsFXUgo
tfJeWPXFAxIL+LCDvjHuHmB0xspPJ7MB6clzM+9pft4s94poEdAg+hC2N+1EwB6j
gRRLoNAXGXX9fWWohu8GqfDKhyLRBB1TKz8vI7b6W5tN1q4ERMdUZGA+CPitbtO7
Z5ZGeX+RlXnpSyG5/cM7gQ/SpOaKf2nWkPokweJ04Us6eDdzkXFCPFLSX3+rVCVf
Yul0n1SRCmlFgdGIbppanybX1qiYE7LVsk6drZoj7z4rFg8guWiW8dzJLkQGSBMC
IA+DVxdptxsd5bOVnMGk8yHX1RsKxetxFrxO1fFvq0Lk143j6zw=
=F8v6
-----END PGP SIGNATURE-----

--GzkyR82Ue5kMn+dX--


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:38:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:38:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307630.522829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngZ4g-00008h-6a; Mon, 18 Apr 2022 21:38:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307630.522829; Mon, 18 Apr 2022 21:38:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngZ4g-00008a-3T; Mon, 18 Apr 2022 21:38:22 +0000
Received: by outflank-mailman (input) for mailman id 307630;
 Mon, 18 Apr 2022 21:38:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hjWk=U4=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngZ4e-00008U-KS
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 21:38:20 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dd11b8e6-bf5f-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 23:38:19 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 94629B810E7;
 Mon, 18 Apr 2022 21:38:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4FAAC385AB;
 Mon, 18 Apr 2022 21:38:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd11b8e6-bf5f-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650317897;
	bh=F56gL278wUN7kHPNkMHh5kGcZvHET9B2DZFR89c7M1Y=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=tn7dJ8VGVb9hHKzQ0WI3x7KP7iZ5RgyKlH/uXxuu7GD0qIrVpDKfoejkGofzvW93s
	 xIk+VobUj7cDfI5fnVNlunV2nY0IlKWecShUtybCPMx98T6Vunf7Zev+AvmKjjM4NB
	 +D4AtXBE+uUXxfyRX1AR61mSIvVc1M8qd5ajVMu4YKxJ8p13Cl0xtnt3JrfUJEfSdD
	 tSMwUwJ/tHLamDSJGltwVywtBSk5nmVgJiAqU4b+lr9f7vNCFqzBbdsQa90PX626sV
	 mKG0RMkrd3TiGfWWlP53ubxsnIm8sal92zEq71OyOSUyjtT5sG96NNha21wZfV3l21
	 LbxOZ/RZ+Zfyw==
Date: Mon, 18 Apr 2022 14:38:16 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, 
    Nick Rosbrook <rosbrookn@gmail.com>, Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk
 configuration
In-Reply-To: <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204181405160.915916@ubuntu-linux-20-04-desktop>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com> <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This patch adds basic support for configuring and assisting virtio-mmio
> based virtio-disk backend (emualator) which is intended to run out of
                             ^ emulator


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:41:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:41:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307636.522840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngZ7f-0001eU-Kd; Mon, 18 Apr 2022 21:41:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307636.522840; Mon, 18 Apr 2022 21:41:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngZ7f-0001eN-Hf; Mon, 18 Apr 2022 21:41:27 +0000
Received: by outflank-mailman (input) for mailman id 307636;
 Mon, 18 Apr 2022 21:41:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hjWk=U4=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngZ7e-0001eH-KT
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 21:41:26 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4b337284-bf60-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 23:41:24 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 742EC60FE4;
 Mon, 18 Apr 2022 21:41:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 412D2C385A7;
 Mon, 18 Apr 2022 21:41:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b337284-bf60-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650318082;
	bh=qeusrSDpnDNRhAcxBb6eiJKfM1LFf3UbltkauHYqh3s=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=AUzUdmkpEJS1jb6KO5nZMgdjeH6o6Z+L0z3nJ57eWFSjUL80NSJdvP5JTNfHjkWYM
	 Zkbe9/u5ijwnAF6VJiEYcORvYX2VhKNoIjvpGjkuSvg/pyQKGP3i2VjZKWQfIbgSg4
	 Yy6kwq+RJ1aA+miWnyMkHk87r1G1dEOFK6voGEvdZ9EYJK576qM+cH9IfBbVRXWO8W
	 e3q+EP7lkGKMfBdnWAkZPyfFgMD0XCsA7JLyHg31LIxralw+cJxpa6mRH7ZGOhtlWB
	 J/retS6nZ+WAmUYfzk/6MDSzxF2PuRKpEVtL1k2l4izwcvXDydK9pQ/hbI9ltvmcu6
	 Y+quXQE4Fj41A==
Date: Mon, 18 Apr 2022 14:41:21 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Jiamei Xie <Jiamei.Xie@arm.com>, Henry Wang <Henry.Wang@arm.com>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on
 Arm
In-Reply-To: <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204181417370.915916@ubuntu-linux-20-04-desktop>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com> <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-529431033-1650317034=:915916"
Content-ID: <alpine.DEB.2.22.394.2204181426371.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-529431033-1650317034=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204181426372.915916@ubuntu-linux-20-04-desktop>

On Fri, 8 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Julien Grall <julien.grall@arm.com>
> 
> This patch introduces helpers to allocate Virtio MMIO params
> (IRQ and memory region) and create specific device node in
> the Guest device-tree with allocated params. In order to deal
> with multiple Virtio devices, reserve corresponding ranges.
> For now, we reserve 1MB for memory regions and 10 SPIs.
> 
> As these helpers should be used for every Virtio device attached
> to the Guest, call them for Virtio disk(s).
> 
> Please note, with statically allocated Virtio IRQs there is
> a risk of a clash with a physical IRQs of passthrough devices.
> For the first version, it's fine, but we should consider allocating
> the Virtio IRQs automatically. Thankfully, we know in advance which
> IRQs will be used for passthrough to be able to choose non-clashed
> ones.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Tested-by: Jiamei Xie <Jiamei.xie@arm.com>
> Reviewed-by: Henry Wang <Henry.Wang@arm.com>

I realize that we are at v7 and I haven't reviewed this before, so I'll
limit my comments. I'll clarify the ones that I think are more important
from the one that are less important.


> ---
> @Jiamei, @Henry I decided to leave your T-b and R-b tags with the minor
> change I made, are you still happy with that?
> 
> s/if (disk->virtio)/if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
> 
> Please note, this is a split/cleanup/hardening of Julien's PoC:
> "Add support for Guest IO forwarding to a device emulator"
> 
> Changes RFC -> V1:
>    - was squashed with:
>      "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way"
>      "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node"
>      "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT"
>    - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h
> 
> Changes V1 -> V2:
>    - update the author of a patch
> 
> Changes V2 -> V3:
>    - no changes
> 
> Changes V3 -> V4:
>    - no changes
> 
> Changes V4 -> V5:
>    - split the changes, change the order of the patches
>    - drop an extra "virtio" configuration option
>    - update patch description
>    - use CONTAINER_OF instead of own implementation
>    - reserve ranges for Virtio MMIO params and put them
>      in correct location
>    - create helpers to allocate Virtio MMIO params, add
>      corresponding sanity-сhecks
>    - add comment why MMIO size 0x200 is chosen
>    - update debug print
>    - drop Wei's T-b
> 
> Changes V5 -> V6:
>    - rebase on current staging
> 
> Changes V6 -> V7:
>    - rebase on current staging
>    - add T-b and R-b tags
>    - update according to the recent changes to
>      "libxl: Add support for Virtio disk configuration"
> ---
>  tools/libs/light/libxl_arm.c  | 131 +++++++++++++++++++++++++++++++++++++++++-
>  xen/include/public/arch-arm.h |   7 +++
>  2 files changed, 136 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index eef1de0..8132a47 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -8,6 +8,56 @@
>  #include <assert.h>
>  #include <xen/device_tree_defs.h>
>  
> +/*
> + * There is no clear requirements for the total size of Virtio MMIO region.
> + * The size of control registers is 0x100 and device-specific configuration
> + * registers starts at the offset 0x100, however it's size depends on the device
> + * and the driver. Pick the biggest known size at the moment to cover most
> + * of the devices (also consider allowing the user to configure the size via
> + * config file for the one not conforming with the proposed value).
> + */
> +#define VIRTIO_MMIO_DEV_SIZE   xen_mk_ullong(0x200)

Actually, I don't think we need to make this generic. We only support
virtio-disk now and I think it is fine if this was called
VIRTIO_DISK_MMIO_DEV_SIZE and the size was exactly the size needed by
virtio-disk. When/if we support another virtio protocol we can add set
the appropriate size of that one as well.

At the moment as you can see below:

     */
    for (i = 0; i < d_config->num_disks; i++) {
        libxl_device_disk *disk = &d_config->disks[i];

        if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO) {

it is all very virtio-disk specific, so we might as well exploit it for
the better :-)

Given that we are at v7 of this series, I don't think this is very
important, so I think it is OK if we keep the code as is.


> +static uint64_t virtio_mmio_base;
> +static uint32_t virtio_mmio_irq;

No need for these two variables to be global in this file, they could be
local variables in libxl__arch_domain_prepare_config.

I think that this is a change we should make if possible before
committing these patches.



> +static void init_virtio_mmio_params(void)
> +{
> +    virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE;
> +    virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST;
> +}
> +
> +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc)
> +{
> +    uint64_t base = virtio_mmio_base;

If virtio_mmio_base is local in libxl__arch_domain_prepare_config, then
it could be passed here as parameter (as pointer).

If we make the dev MMIO size (GUEST_VIRTIO_MMIO_SIZE) specific to
virtio-disk, then we could pass it also as argument to this function:

static uint64_t alloc_virtio_mmio_base(libxl__gc *gc,
                                       uint64 *virtio_mmio_base,
                                       uint64_t dev_mmio_size)


> +    /* Make sure we have enough reserved resources */
> +    if ((virtio_mmio_base + VIRTIO_MMIO_DEV_SIZE >
> +        GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) {
> +        LOG(ERROR, "Ran out of reserved range for Virtio MMIO BASE 0x%"PRIx64"\n",
> +            virtio_mmio_base);
> +        return 0;
> +    }
> +    virtio_mmio_base += VIRTIO_MMIO_DEV_SIZE;
> +
> +    return base;
> +}
> +
> +static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc)
> +{
> +    uint32_t irq = virtio_mmio_irq;
> +
> +    /* Make sure we have enough reserved resources */
> +    if (virtio_mmio_irq > GUEST_VIRTIO_MMIO_SPI_LAST) {
> +        LOG(ERROR, "Ran out of reserved range for Virtio MMIO IRQ %u\n",
> +            virtio_mmio_irq);
> +        return 0;
> +    }
> +    virtio_mmio_irq++;
> +
> +    return irq;
> +}
> +
>  static const char *gicv_to_string(libxl_gic_version gic_version)
>  {
>      switch (gic_version) {
> @@ -26,8 +76,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>  {
>      uint32_t nr_spis = 0;
>      unsigned int i;
> -    uint32_t vuart_irq;
> -    bool vuart_enabled = false;
> +    uint32_t vuart_irq, virtio_irq = 0;
> +    bool vuart_enabled = false, virtio_enabled = false;
>  
>      /*
>       * If pl011 vuart is enabled then increment the nr_spis to allow allocation
> @@ -39,6 +89,35 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>          vuart_enabled = true;
>      }
>  
> +    /*
> +     * Virtio MMIO params are non-unique across the whole system and must be
> +     * initialized for every new guest.
> +     */
> +    init_virtio_mmio_params();

No need to initialize them in init_virtio_mmio_params, you could just
do:

  uint64_t virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE;
  uint32_t virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST;

at the top of libxl__arch_domain_prepare_config


> +    for (i = 0; i < d_config->num_disks; i++) {
> +        libxl_device_disk *disk = &d_config->disks[i];
> +
> +        if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO) {
> +            disk->base = alloc_virtio_mmio_base(gc);
> +            if (!disk->base)
> +                return ERROR_FAIL;
> +
> +            disk->irq = alloc_virtio_mmio_irq(gc);
> +            if (!disk->irq)
> +                return ERROR_FAIL;
> +
> +            if (virtio_irq < disk->irq)
> +                virtio_irq = disk->irq;
> +            virtio_enabled = true;
> +
> +            LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64,
> +                disk->vdev, disk->irq, disk->base);
> +        }
> +    }
> +
> +    if (virtio_enabled)
> +        nr_spis += (virtio_irq - 32) + 1;
> +
>      for (i = 0; i < d_config->b_info.num_irqs; i++) {
>          uint32_t irq = d_config->b_info.irqs[i];
>          uint32_t spi;
> @@ -58,6 +137,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>              return ERROR_FAIL;
>          }
>  
> +        /* The same check as for vpl011 */
> +        if (virtio_enabled &&
> +           (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) {

NIT: alignment:

        if (virtio_enabled &&
            (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) {



> +            LOG(ERROR, "Physical IRQ %u conflicting with Virtio MMIO IRQ range\n", irq);
> +            return ERROR_FAIL;
> +        }
> +
>          if (irq < 32)
>              continue;
>  
> @@ -787,6 +873,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt,
>      return 0;
>  }
>  
> +
> +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
> +                                 uint64_t base, uint32_t irq)
> +{
> +    int res;
> +    gic_interrupt intr;
> +    /* Placeholder for virtio@ + a 64-bit number + \0 */
> +    char buf[24];
> +
> +    snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base);
> +    res = fdt_begin_node(fdt, buf);
> +    if (res) return res;
> +
> +    res = fdt_property_compat(gc, fdt, 1, "virtio,mmio");
> +    if (res) return res;
> +
> +    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +                            1, base, VIRTIO_MMIO_DEV_SIZE);
> +    if (res) return res;
> +
> +    set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING);
> +    res = fdt_property_interrupts(gc, fdt, &intr, 1);
> +    if (res) return res;
> +
> +    res = fdt_property(fdt, "dma-coherent", NULL, 0);
> +    if (res) return res;
> +
> +    res = fdt_end_node(fdt);
> +    if (res) return res;
> +
> +    return 0;
> +}
> +
>  static const struct arch_info *get_arch_info(libxl__gc *gc,
>                                               const struct xc_dom_image *dom)
>  {
> @@ -988,6 +1107,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config,
>      size_t fdt_size = 0;
>      int pfdt_size = 0;
>      libxl_domain_build_info *const info = &d_config->b_info;
> +    unsigned int i;
>  
>      const libxl_version_info *vers;
>      const struct arch_info *ainfo;
> @@ -1094,6 +1214,13 @@ next_resize:
>          if (d_config->num_pcidevs)
>              FDT( make_vpci_node(gc, fdt, ainfo, dom) );
>  
> +        for (i = 0; i < d_config->num_disks; i++) {
> +            libxl_device_disk *disk = &d_config->disks[i];
> +
> +            if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
> +                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) );
> +        }
> +
>          if (pfdt)
>              FDT( copy_partial_fdt(gc, fdt, pfdt) );
>  
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index ab05fe1..c8b6058 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -407,6 +407,10 @@ typedef uint64_t xen_callback_t;
>  
>  /* Physical Address Space */
>  
> +/* Virtio MMIO mappings */
> +#define GUEST_VIRTIO_MMIO_BASE   xen_mk_ullong(0x02000000)
> +#define GUEST_VIRTIO_MMIO_SIZE   xen_mk_ullong(0x00100000)
> +
>  /*
>   * vGIC mappings: Only one set of mapping is used by the guest.
>   * Therefore they can overlap.
> @@ -493,6 +497,9 @@ typedef uint64_t xen_callback_t;
>  
>  #define GUEST_VPL011_SPI        32
>  
> +#define GUEST_VIRTIO_MMIO_SPI_FIRST   33
> +#define GUEST_VIRTIO_MMIO_SPI_LAST    43
> +
>  /* PSCI functions */
>  #define PSCI_cpu_suspend 0
>  #define PSCI_cpu_off     1
> -- 
> 2.7.4
> 
--8323329-529431033-1650317034=:915916--


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 21:47:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 21:47:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307641.522851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngZD9-0002Ol-8h; Mon, 18 Apr 2022 21:47:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307641.522851; Mon, 18 Apr 2022 21:47:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngZD9-0002Oe-56; Mon, 18 Apr 2022 21:47:07 +0000
Received: by outflank-mailman (input) for mailman id 307641;
 Mon, 18 Apr 2022 21:47:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hjWk=U4=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngZD7-0002OY-KR
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 21:47:05 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 160b7632-bf61-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 23:47:04 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id CC07BB810BC;
 Mon, 18 Apr 2022 21:47:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBE40C385A1;
 Mon, 18 Apr 2022 21:47:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 160b7632-bf61-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650318422;
	bh=7+Xds58jFRdKBOXoypL1eP8EJZkvYKIUOpOuQi6rZvg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=YKBQhGGOeTNfMtz/n5lnSGdyRpDFLBv5ba2OUPC6PirkMk3Il5J8DfBD+OAj1KCx1
	 JW1AafAZ1vP/R4LeFluFJ4ROKf2qa1JsEaUjm/BIsLEgpe9mH0uKQNgShzC1I5vPz+
	 9sGiMyhVsPrPloIl8ED8yb2l8ZBDvOKI7hvxh9p3yVXerhvAKCWZb+L4kI3AZavl/W
	 TrarhS+JUv2wH2U2U5eIsJtducrj2K3z8LJJMiyxXiR/ToWgXyF5+P/XS3FuK6zlQO
	 c6WyKcNaZei3qbzssTHlHpQNrK0lY9cj96XkR0Krpzh3FHTdBzTaVH2ch6bJavcGNN
	 h214WSbFlwBfQ==
Date: Mon, 18 Apr 2022 14:47:01 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, 
    Henry Wang <Henry.Wang@arm.com>, Kaly Xin <Kaly.Xin@arm.com>, 
    Jiamei Xie <Jiamei.Xie@arm.com>, 
    =?UTF-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>
Subject: Re: [RFC PATCH] libxl/arm: Insert "xen,dev-domid" property to
 virtio-mmio device node
In-Reply-To: <1649964960-24864-1-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204181445300.915916@ubuntu-linux-20-04-desktop>
References: <1649964960-24864-1-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-785202687-1650318422=:915916"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-785202687-1650318422=:915916
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This is needed for grant table based DMA ops layer (CONFIG_XEN_VIRTIO)
> at the guest side to retrieve the ID of Xen domain where the corresponding
> backend resides (it is used as an argument to the grant table APIs).
> 
> This is a part of restricted memory access under Xen feature.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

I think this looks good overall. Instead of mentioning details of the
Linux implementation, we should mention the device tree binding instead,
including a link to it. The device tree binding is the relevant spec in
this case.


> ---
> !!! This patch is based on non upstreamed yet “Virtio support for toolstack
> on Arm” series which is on review now:
> https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/
> 
> All details are at:
> https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-olekstysh@gmail.com/
> ---
>  tools/libs/light/libxl_arm.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index 8132a47..d9b26fc 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -875,7 +875,8 @@ static int make_vpci_node(libxl__gc *gc, void *fdt,
>  
>  
>  static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
> -                                 uint64_t base, uint32_t irq)
> +                                 uint64_t base, uint32_t irq,
> +                                 uint32_t backend_domid)
>  {
>      int res;
>      gic_interrupt intr;
> @@ -900,6 +901,14 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
>      res = fdt_property(fdt, "dma-coherent", NULL, 0);
>      if (res) return res;
>  
> +    if (backend_domid != LIBXL_TOOLSTACK_DOMID) {
> +        uint32_t domid[1];
> +
> +        domid[0] = cpu_to_fdt32(backend_domid);
> +        res = fdt_property(fdt, "xen,dev-domid", domid, sizeof(domid));
> +        if (res) return res;
> +    }
> +
>      res = fdt_end_node(fdt);
>      if (res) return res;
>  
> @@ -1218,7 +1227,8 @@ next_resize:
>              libxl_device_disk *disk = &d_config->disks[i];
>  
>              if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
> -                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) );
> +                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq,
> +                                           disk->backend_domid) );
>          }
>  
>          if (pfdt)
> -- 
> 2.7.4
> 
--8323329-785202687-1650318422=:915916--


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 22:39:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 22:39:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307646.522862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nga1y-0007sl-PA; Mon, 18 Apr 2022 22:39:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307646.522862; Mon, 18 Apr 2022 22:39:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nga1y-0007se-LE; Mon, 18 Apr 2022 22:39:38 +0000
Received: by outflank-mailman (input) for mailman id 307646;
 Mon, 18 Apr 2022 22:39:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nga1x-0007sU-Gv; Mon, 18 Apr 2022 22:39:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nga1x-00082n-FV; Mon, 18 Apr 2022 22:39:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nga1x-0007E8-4A; Mon, 18 Apr 2022 22:39:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nga1x-0004Fw-3e; Mon, 18 Apr 2022 22:39:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ofCELDKV3vrGxTi+zWf/ucjAoYs0OK4S3ZHiCCtsBPo=; b=NxryiRtugmGt/kEB4XYRdoIDYi
	GvfHuznJOkPhN3R5pMUhEBSWaifChlv3tqyhK1M+5KxgLOQp8ve8pa39Vg6iOTeZ3ayNyI7k2BWeR
	mFKS+q6SyeJ4VI8dA9z+yL2QgEIGkfXki+Gn1cB/4kRaCMVvLdfPjU4+M6NW29SDBnNA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169523-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169523: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 22:39:37 +0000

flight 169523 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169523/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  492 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   68 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 23:04:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 23:04:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307655.522873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngaPf-00031U-Sc; Mon, 18 Apr 2022 23:04:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307655.522873; Mon, 18 Apr 2022 23:04:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngaPf-00031N-PX; Mon, 18 Apr 2022 23:04:07 +0000
Received: by outflank-mailman (input) for mailman id 307655;
 Mon, 18 Apr 2022 23:04:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qGAa=U4=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1ngaPe-00031H-O5
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 23:04:06 +0000
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com
 [2a00:1450:4864:20::42b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d83d44a2-bf6b-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 01:04:05 +0200 (CEST)
Received: by mail-wr1-x42b.google.com with SMTP id m14so20179952wrb.6
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 16:04:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d83d44a2-bf6b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=eOg9LZC2IjRjuND7dpeRT2K91j6txG9Sx44bcjjryEw=;
        b=JZnvG/91J5N4Vj4TOnNWS5OAKc2gHrpGNw0Rtp1nbIMex+2wpnPz6Bh/juHxXedzft
         u+mtdor7hICvROmS8lhIhj8DwSyW9WrHSJlgIBMJajJQwOE2YmX1tBo8N6KK4qCPh+iO
         wVYMKqD2qC0m4FrxcSf/oXghzQ/ig7u5z7DpszcpUKRxsgXWVHznBtVk/sG/ioi0ovWd
         Ao+WnRBnxFuO+AsSBA/fSI4SeKlksvfPpJ5Gu/4yaZJEM+wLQUujRSahhd10VzyvzaDU
         KFlqPw6gEqCmmUiLvZrdEpRtLzQCPSJsgHDr3VBVGexlRZ7UuwkEqt4/avaPGemkTkSW
         4YfA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=eOg9LZC2IjRjuND7dpeRT2K91j6txG9Sx44bcjjryEw=;
        b=fyCGJjy0bGuVM+x+aw4BglZRhzx19esXGkWx0Yg4m+XWQAffze7fTQZpnS53kfQBwN
         9yLyEGrG3aTXtsFvaxeS/6t/SgfrNymCw+Cupz9M9AY0ygX7jMhpL7vRmS9QeVlans/A
         vveIYVE+CkLecnPPY92rkegJ5yDwXur8nxEOedeiznLKXWK5zoowO/p4IFZUhFWT2Ezc
         3tad4d1v5hNvq66eL6ZMJitY4PUxvk6qRWFBzQZfG04LYoCUeMZtu6BulwYGI0wQVLso
         6ga35wEQB2H5t0/v0yYItSHY/uTfCS/uUvwZHDLItgJ9qO/ZApVjq5Z8v7dw2iu7kfaq
         oO5A==
X-Gm-Message-State: AOAM531xOMQEg7R9TsaC1gLJNQ987cg2UDLnFq+pZ0+puN7H/zl7mWA3
	Kq5nazpLw6s8kTDuWOUyPVv7fue+ukEBsYBKFB8=
X-Google-Smtp-Source: ABdhPJzFu/hDOhyUh6ftWEfSYIcMxDQRwz4rxChpKaXL9oMbO2Pui8JLqjJiZeI+OhAlELQ0zP5ovbdYHQaqTtxDRXA=
X-Received: by 2002:adf:dd8a:0:b0:207:9e5f:fd0a with SMTP id
 x10-20020adfdd8a000000b002079e5ffd0amr9280174wrl.94.1650323044809; Mon, 18
 Apr 2022 16:04:04 -0700 (PDT)
MIME-Version: 1.0
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-3-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2204181417370.915916@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2204181417370.915916@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Mon, 18 Apr 2022 23:03:52 +0000
Message-ID: <CAJ=z9a30ADk98EP5nsS+w9QY-8exQeOLYrVQTSsJUsfwUcfFhA@mail.gmail.com>
Subject: Re: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel <xen-devel@lists.xenproject.org>, 
	Julien Grall <julien.grall@arm.com>, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Jiamei Xie <Jiamei.Xie@arm.com>, Henry Wang <Henry.Wang@arm.com>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Content-Type: multipart/alternative; boundary="000000000000d9bdf805dcf5c65a"

--000000000000d9bdf805dcf5c65a
Content-Type: text/plain; charset="UTF-8"

Hi,

Sorry for the formatting issues.

On Mon, 18 Apr 2022, 21:41 Stefano Stabellini, <sstabellini@kernel.org>
wrote:

> > +static uint64_t virtio_mmio_base;
> > +static uint32_t virtio_mmio_irq;
>
> No need for these two variables to be global in this file, they could be
> local variables in libxl__arch_domain_prepare_config.


It is more than "no need". Libxl can be used by a daemon to handle multiple
domains. So we can't use static variable to keep track of local information.

Cheers,

--000000000000d9bdf805dcf5c65a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Hi,</div><div dir=3D"auto"><br></div><div dir=3D"aut=
o">Sorry for the formatting issues.<br><br><div class=3D"gmail_quote" dir=
=3D"auto"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 18 Apr 2022, 21:41 =
Stefano Stabellini, &lt;<a href=3D"mailto:sstabellini@kernel.org">sstabelli=
ni@kernel.org</a>&gt; wrote:</div></div></div><div dir=3D"auto"><div class=
=3D"gmail_quote" dir=3D"auto"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; +static uint64_t virtio_mmio_base;<br>
&gt; +static uint32_t virtio_mmio_irq;<br>
<br>
No need for these two variables to be global in this file, they could be<br=
>
local variables in libxl__arch_domain_prepare_config.</blockquote></div></d=
iv><div dir=3D"auto"><br></div><div dir=3D"auto">It is more than &quot;no n=
eed&quot;. Libxl can be used by a daemon to handle multiple domains. So we =
can&#39;t use static variable to keep track of local information.</div><div=
 dir=3D"auto"><br></div><div dir=3D"auto">Cheers,</div><div dir=3D"auto"><b=
r></div></div>

--000000000000d9bdf805dcf5c65a--


From xen-devel-bounces@lists.xenproject.org Mon Apr 18 23:28:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Apr 2022 23:28:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307660.522884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nganD-0005b0-Sg; Mon, 18 Apr 2022 23:28:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307660.522884; Mon, 18 Apr 2022 23:28:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nganD-0005at-P7; Mon, 18 Apr 2022 23:28:27 +0000
Received: by outflank-mailman (input) for mailman id 307660;
 Mon, 18 Apr 2022 23:28:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nganC-0005aj-9W; Mon, 18 Apr 2022 23:28:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nganC-0000S0-71; Mon, 18 Apr 2022 23:28:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nganB-0008Hp-Sj; Mon, 18 Apr 2022 23:28:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nganB-00018F-SF; Mon, 18 Apr 2022 23:28:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NfJb051bEAFEYPCpWUnxEm6rSejAMaiOtAu3+2Usqw0=; b=kemlDxBTjk0GqOTTOq7Kgq0O+n
	eH8WZAdQzjHat9kfhDKT7UPGCnbJi4D1mC9dXHGasMhdK2+V7WRQA2Ngpntjoz+RTLdZrGXIIpLBj
	1PyV+yb+V6U4TLIIyzeaf0LaWE2NGSIdYR96ioeqGKwSW616WMUXKqPEGLMn5MxcpdKM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169524-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169524: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Apr 2022 23:28:25 +0000

flight 169524 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169524/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  493 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   69 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 00:12:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 00:12:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307669.522895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngbTo-00039p-Qy; Tue, 19 Apr 2022 00:12:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307669.522895; Tue, 19 Apr 2022 00:12:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngbTo-00039i-Ns; Tue, 19 Apr 2022 00:12:28 +0000
Received: by outflank-mailman (input) for mailman id 307669;
 Tue, 19 Apr 2022 00:12:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngbTn-00039Y-24; Tue, 19 Apr 2022 00:12:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngbTn-0001nb-0I; Tue, 19 Apr 2022 00:12:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngbTm-0000o5-Hg; Tue, 19 Apr 2022 00:12:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngbTm-0002IT-HC; Tue, 19 Apr 2022 00:12:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+CVQJo54qeZi6VtMLGOOqARUI3ykfeQIF4b8sScFxQg=; b=J57k37VeSGJ+rGltsHA3Nxof93
	v+IwdkKYRKLBaP+2rDGgr8L8ZLrAnu+3swZ3fmjdL8RQtD3u4f6j0ZMnSg/ZNubLkOTPd7rO8S7kr
	EYHgkRapqWFf6FdjpD6BXSdMXl+bM2KMUVAz9tjxQMHqo7igbyihYGwePXwvafGtriKg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169525-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169525: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 00:12:26 +0000

flight 169525 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169525/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  494 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    2 days   70 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 01:11:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 01:11:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307677.522905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngcOe-0007jS-7h; Tue, 19 Apr 2022 01:11:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307677.522905; Tue, 19 Apr 2022 01:11:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngcOe-0007jL-4i; Tue, 19 Apr 2022 01:11:12 +0000
Received: by outflank-mailman (input) for mailman id 307677;
 Tue, 19 Apr 2022 01:11:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pcs0=U5=linaro.org=viresh.kumar@srs-se1.protection.inumbo.net>)
 id 1ngcOd-0007jF-Df
 for xen-devel@lists.xen.org; Tue, 19 Apr 2022 01:11:11 +0000
Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com
 [2607:f8b0:4864:20::d2b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 986b63a3-bf7d-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 03:11:10 +0200 (CEST)
Received: by mail-io1-xd2b.google.com with SMTP id 79so7883904iou.7
 for <xen-devel@lists.xen.org>; Mon, 18 Apr 2022 18:11:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 986b63a3-bf7d-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=npRBzAa9weMhje/sr00rqCUwY7iCXEij6kRS7kNmJsY=;
        b=w2E+okI2hzbkNZWAOUtk8qXj4s9ndQWv9mspXFlclJZ9xnVXCEAo1k+01IwyK4bXUQ
         7oaHuoVoFwnAwAXc3tFM65iYmeg83xiVi+WXU7C7mM2tJ07cgbeQ8nDYFkSWIHUnyOPG
         8BDXZQPu9dyu4R0SiaZzXVUeccO0BSOx7rjTsumeHf2WB+nh3j5D6KdNsZ3zYCE7S0Hl
         cubUZNFKXkSyJVG4Le/wwMNMC92edT0pGPabL+vD19TsnhbbejX5nRXbmu3JH6M8umnz
         wMxtnDxo0X2Z+s034UbBKcdLHa2YVSK0q3W18hbkE0yHbReW6T6rSMRxEi3TQsTELHI8
         gGtg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=npRBzAa9weMhje/sr00rqCUwY7iCXEij6kRS7kNmJsY=;
        b=Bh5oxntnCEflrtgzhqNtd1AVbGXPTZTVSY4eevFRVOvQe3SYX4lGD2tTup1uCDvomv
         ulGDxefEEssAfrp5sBx3a4dv5FwjI26vHfEtWLI8YNuB2fbq+AxdoWvANDPCzPgDVj2+
         xdJHtiKTpUnEF+UvXmcHuS7LGLd+Emm/vCBmeicLyBRWT05xifhyjsW6pJvUOysVf6V4
         jaLPYQ8vuzFi03jod8RjO9C3Gn3nH+ZG4VllddK5sAnV8KiqwSd3cJCt66JojFriAATE
         ff/hk729zV+yEE9UZjfGjpv2+5taQmwvJoeSi0hMOtVpxaEdVoGmd+a0HKk+ai6raBlx
         UJ6w==
X-Gm-Message-State: AOAM531c9zyLxUHd0FhV+4TM465zF1jrcp+qmkHbFS9QcFBmCurZHR7d
	Q9+EHroVRqUYbPgF7iM7MM8YzCVi9VNI23GE3wEYNQ==
X-Google-Smtp-Source: ABdhPJzqX0yCNlbHhnLFkFVIY8mnKLvd386rn31Re56wRPFC6xFim/AR5qcxrw/l2KN0fHtavTwBGX0XTOQIAHDbWD8=
X-Received: by 2002:a05:6638:328f:b0:328:884a:c97a with SMTP id
 f15-20020a056638328f00b00328884ac97amr3060755jav.19.1650330668487; Mon, 18
 Apr 2022 18:11:08 -0700 (PDT)
MIME-Version: 1.0
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7> <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>
In-Reply-To: <20220414092358.kepxbmnrtycz7mhe@vireshk-i7>
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Tue, 19 Apr 2022 06:40:57 +0530
Message-ID: <CAKohpomBcWWXxip4uvW_kmPpANobKpU2zUx2P9Z+-=PaYCoPQw@mail.gmail.com>
Subject: Re: Virtio on Xen with Rust
To: Stratos Mailing List <stratos-dev@op-lists.linaro.org>, xen-devel@lists.xen.org, 
	rust-vmm@lists.opendev.org
Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, 
	Stefano Stabellini <stefano.stabellini@xilinx.com>, 
	Mathieu Poirier <mathieu.poirier@linaro.com>, Vincent Guittot <vincent.guittot@linaro.org>, 
	Mike Holmes <mike.holmes@linaro.org>, Oleksandr Tyshchenko <olekstysh@gmail.com>, Wei Liu <wl@xen.org>
Content-Type: text/plain; charset="UTF-8"

+rust-vmm@lists.opendev.org

On Thu, 14 Apr 2022 at 14:54, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> +xen-devel
>
> On 14-04-22, 14:45, Viresh Kumar wrote:
> > Hello,
> >
> > We verified our hypervisor-agnostic Rust based vhost-user backends with Qemu
> > based setup earlier, and there was growing concern if they were truly
> > hypervisor-agnostic.
> >
> > In order to prove that, we decided to give it a try with Xen, a type-1
> > bare-metal hypervisor.
> >
> > We are happy to announce that we were able to make progress on that front and
> > have a working setup where we can test our existing Rust based backends, like
> > I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.
> >
> > Key components:
> > --------------
> >
> > - Xen: https://github.com/vireshk/xen
> >
> >   Xen requires MMIO and device specific support in order to populate the
> >   required devices at the guest. This tree contains four patches on the top of
> >   mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C).
> >
> > - libxen-sys: https://github.com/vireshk/libxen-sys
> >
> >   We currently depend on the userspace tools/libraries provided by Xen, like
> >   xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates provides Rust
> >   wrappers over those calls, generated automatically with help of bindgen
> >   utility in Rust, that allow us to use the installed Xen libraries. Though we
> >   plan to replace this with Rust based "oxerun" (find below) in longer run.
> >
> > - oxerun (WIP): https://gitlab.com/mathieupoirier/oxerun/-/tree/xen-ioctls
> >
> >   This is Rust based implementations for Ioctl and hypercalls to Xen. This is WIP
> >   and should eventually replace "libxen-sys" crate entirely (which are C based
> >   implementation of the same).
> >
> > - vhost-device: https://github.com/vireshk/vhost-device
> >
> >   These are Rust based vhost-user backends, maintained inside the rust-vmm
> >   project. This already contain support for I2C and RNG, while GPIO is under
> >   review. These are not required to be modified based on hypervisor and are
> >   truly hypervisor-agnostic.
> >
> >   Ideally the backends are hypervisor agnostic, as explained earlier, but
> >   because of the way Xen maps the guest memory currently, we need a minor update
> >   for the backends to work. Xen maps the memory via a kernel file
> >   /dev/xen/privcmd, which needs calls to mmap() followed by an ioctl() to make
> >   it work. For this a hack has been added to one of the rust-vmm crates,
> >   vm-virtio, which is used by vhost-user.
> >
> >   https://github.com/vireshk/vm-memory/commit/54b56c4dd7293428edbd7731c4dbe5739a288abd
> >
> >   The update to vm-memory is responsible to do ioctl() after the already present
> >   mmap().
> >
> > - vhost-user-master (WIP): https://github.com/vireshk/vhost-user-master
> >
> >   This implements the master side interface of the vhost protocol, and is like
> >   the vhost-user-backend (https://github.com/rust-vmm/vhost-user-backend) crate
> >   maintained inside the rust-vmm project, which provides similar infrastructure
> >   for the backends to use. This shall be hypervisor independent and provide APIs
> >   for the hypervisor specific implementations. This will eventually be
> >   maintained inside the rust-vmm project and used by all Rust based hypervisors.
> >
> > - xen-vhost-master (WIP): https://github.com/vireshk/xen-vhost-master
> >
> >   This is the Xen specific implementation and uses the APIs provided by
> >   "vhost-user-master", "oxerun" and "libxen-sys" crates for its functioning.
> >
> >   This is designed based on the EPAM's "virtio-disk" repository
> >   (https://github.com/xen-troops/virtio-disk/) and is pretty much similar to it.
> >
> >   One can see the analogy as:
> >
> >   Virtio-disk == "Xen-vhost-master" + "vhost-user-master" + "oxerun" + "libxen-sys" + "vhost-device".
> >
> >
> >
> > Test setup:
> > ----------
> >
> > 1. Build Xen:
> >
> >   $ ./configure --libdir=/usr/lib --build=x86_64-unknown-linux-gnu --host=aarch64-linux-gnu --disable-docs --disable-golang --disable-ocamltools --with-system-qemu=/root/qemu/build/i386-softmmu/qemu-system-i386;
> >   $ make -j9 debball CROSS_COMPILE=aarch64-linux-gnu- XEN_TARGET_ARCH=arm64
> >
> > 2. Run Xen via Qemu on X86 machine:
> >
> >   $ qemu-system-aarch64 -machine virt,virtualization=on -cpu cortex-a57 -serial mon:stdio \
> >         -device virtio-net-pci,netdev=net0 -netdev user,id=net0,hostfwd=tcp::8022-:22 \
> >         -device virtio-scsi-pci -drive file=/home/vireshk/virtio/debian-bullseye-arm64.qcow2,index=0,id=hd0,if=none,format=qcow2 -device scsi-hd,drive=hd0 \
> >         -display none -m 8192 -smp 8 -kernel /home/vireshk/virtio/xen/xen \
> >         -append "dom0_mem=5G,max:5G dom0_max_vcpus=7 loglvl=all guest_loglvl=all" \
> >         -device guest-loader,addr=0x46000000,kernel=/home/vireshk/kernel/barm64/arch/arm64/boot/Image,bootargs="root=/dev/sda2 console=hvc0 earlyprintk=xen" \
> >         -device ds1338,address=0x20     # This is required to create a virtual I2C based RTC device on Dom0.
> >
> >   This should get Dom0 up and running.
> >
> > 3. Build rust crates:
> >
> >   $ cd /root/
> >   $ git clone https://github.com/vireshk/xen-vhost-master
> >   $ cd xen-vhost-master
> >   $ cargo build
> >
> >   $ cd ../
> >   $ git clone https://github.com/vireshk/vhost-device
> >   $ cd vhost-device
> >   $ cargo build
> >
> > 4. Setup I2C based RTC device
> >
> >   $ echo ds1338 0x20 > /sys/bus/i2c/devices/i2c-0/new_device; echo 0-0020 > /sys/bus/i2c/devices/0-0020/driver/unbind
> >
> > 5. Lets run everything now
> >
> >   # Start the I2C backend in one terminal (open new terminal with "ssh
> >   # root@localhost -p8022"). This tells the I2C backend to hook up to
> >   # "/root/vi2c.sock0" socket and wait for the master to start transacting.
> >   $ /root/vhost-device/target/debug/vhost-device-i2c -s /root/vi2c.sock -c 1 -l 0:32
> >
> >   # Start the xen-vhost-master in another terminal. This provides the path of
> >   # the socket to the master side and the device to look from Xen, which is I2C
> >   # here.
> >   $ /root/xen-vhost-master/target/debug/xen-vhost-master --socket-path /root/vi2c.sock0 --name i2c
> >
> >   # Start guest in another terminal, i2c_domu.conf is attached. The guest kernel
> >   # should have Virtio related config options enabled, along with i2c-virtio
> >   # driver.
> >   $ xl create -c  i2c_domu.conf
> >
> >   # The guest should boot fine now. Once the guest is up, you can create the I2C
> >   # RTC device and use it. Following will create /dev/rtc0 in the guest, which
> >   # you can configure with 'hwclock' utility.
> >
> >   $ echo ds1338 0x20 > /sys/bus/i2c/devices/i2c-0/new_device
> >
> >
> > Hope this helps.
> >
> > --
> > viresh
>
> i2c_domu.conf
>
> > kernel="/root/Image"
> > memory=512
> > vcpus=2
> > command="console=hvc0 earlycon=xenboot"
> > name="domu"
> > i2c = [ "virtio=true, irq=1, base=1" ]
>
> --
> viresh


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 01:12:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 01:12:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307682.522917 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngcPX-0008QY-Kh; Tue, 19 Apr 2022 01:12:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307682.522917; Tue, 19 Apr 2022 01:12:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngcPX-0008QR-Gt; Tue, 19 Apr 2022 01:12:07 +0000
Received: by outflank-mailman (input) for mailman id 307682;
 Tue, 19 Apr 2022 01:12:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngcPW-0008QB-5m; Tue, 19 Apr 2022 01:12:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngcPW-0000fK-3K; Tue, 19 Apr 2022 01:12:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngcPV-000268-Pd; Tue, 19 Apr 2022 01:12:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngcPV-0007LV-PC; Tue, 19 Apr 2022 01:12:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Iq+X0q/0IJ2jaTqdYrq293+ppKLpJstiGldQQvsh4Xs=; b=KbgFTL50sfr9SR2vovdAZadxJs
	X1OoAQStRavvKBEVFPGkAtTS5621wZVUyGKGKSlhH52Z9xG6GB5rpCIaxkvhYJriy5525nllMng9i
	+7N4n/St2QLnESjbZyHp2lEbntr+riMVMT8cFppgaG3eAYII4otUhf6s0arl9zhxaPEc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169526-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169526: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 01:12:05 +0000

flight 169526 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169526/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 91a03f78ba0b75bc4ed2c4b756cbe57c685d9c72
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   48 days  495 attempts
Testing same since   169441  2022-04-16 00:41:39 Z    3 days   71 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5290 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 02:47:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 02:47:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307692.522928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngdtS-0001SX-KX; Tue, 19 Apr 2022 02:47:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307692.522928; Tue, 19 Apr 2022 02:47:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngdtS-0001S6-ES; Tue, 19 Apr 2022 02:47:06 +0000
Received: by outflank-mailman (input) for mailman id 307692;
 Tue, 19 Apr 2022 02:47:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=abXu=U5=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngdtQ-0001S0-R6
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 02:47:05 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on061d.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::61d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id facfdd5d-bf8a-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 04:46:58 +0200 (CEST)
Received: from DB8PR04CA0010.eurprd04.prod.outlook.com (2603:10a6:10:110::20)
 by DB7PR08MB3754.eurprd08.prod.outlook.com (2603:10a6:10:73::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 02:46:54 +0000
Received: from DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:110:cafe::8c) by DB8PR04CA0010.outlook.office365.com
 (2603:10a6:10:110::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Tue, 19 Apr 2022 02:46:54 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT043.mail.protection.outlook.com (10.152.20.236) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 02:46:53 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Tue, 19 Apr 2022 02:46:53 +0000
Received: from eecc551432fa.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E86391A6-58F2-4CD5-816B-05DDCD21C153.1; 
 Tue, 19 Apr 2022 02:46:48 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eecc551432fa.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Apr 2022 02:46:48 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by PAXPR08MB7318.eurprd08.prod.outlook.com (2603:10a6:102:231::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Tue, 19 Apr
 2022 02:46:44 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 02:46:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: facfdd5d-bf8a-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KMcP4d/Lx/GBBBUlnOBTu3ShUjSCCSTbkQkU3ncPfeg=;
 b=hzx7LdeGMgEuxLhUt48pnqyyyGJrdl+MNMnvkP6OnK/8VB16kb1Ujwyx67dlw0BkguTa7eylrwnwcUzqgPfVQpqF3+DUyVCQXUZaLYkhVVM8Jyw9nrVWYjFJXxJExEQARVXF7VNlbGEFS2/8lU2GEfB4bJ/nNYzbjJlVNpW8wEM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nOj6/cVUNbnxc+IvagVgzxDxDtRXDusQV0bIX9sGE8rAF18I8tkvExiG28BS11llarXUydPJhK5IgHyw7b0qnWtlRcrhj8ZfVwqVfNAnj1SlYWaB8+lt8CwLwpD4/8Psb+0sc9sSUEIYkOrQ9TsPTpthwPCWfHt7DjN2Ov6fY1seypWeYc/FMP6YJqgIHksF0qaOAWoElErE6/NeTB02xqPooAnL3S4FDisguEOX9ZtzSJALb/wxQowCY8Vc8YAANln4Ikbgph8qIt/d7nw6HWhBnQDDtk/Vyvpn1dsIwx0c0hSadWDoXl5h8D6/q8PC0SYrsOQ9UhMhGpzr9OIlgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KMcP4d/Lx/GBBBUlnOBTu3ShUjSCCSTbkQkU3ncPfeg=;
 b=MNjjTvK4kA3ksZOHeDidoiYzTX090BCabCeZMZKoqkOtMn2sjXT21N6Lh6uRegtXFPWW7AfIZgvibwKjKCF1BoS4HHKWqHIfeiZhew3cS0SeV7unwS7GcNp47QoyF5uKhMiexpn0bLefrpF1Q8cB7Sa4KS2miJjjocijHkvzRrRMP3ihnHLbjws8ChHr63n14j1hogyjCaOJqkCB4KMsI0tMrUd2XAI7RNzIYsKCoETVnNR90aXhXEDe+at30lSmm33KynivvxE0XXlai+A/0V3ww9OdXfhuQGSKmkdoWdlbpOeo26tCcHyR3MT04munhtWUtRnj2OScVxqNM8x0lg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KMcP4d/Lx/GBBBUlnOBTu3ShUjSCCSTbkQkU3ncPfeg=;
 b=hzx7LdeGMgEuxLhUt48pnqyyyGJrdl+MNMnvkP6OnK/8VB16kb1Ujwyx67dlw0BkguTa7eylrwnwcUzqgPfVQpqF3+DUyVCQXUZaLYkhVVM8Jyw9nrVWYjFJXxJExEQARVXF7VNlbGEFS2/8lU2GEfB4bJ/nNYzbjJlVNpW8wEM=
From: Wei Chen <Wei.Chen@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftB
Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftB
Thread-Index: Adg/5aAUG5Xb47xpSru14p+HpAimXgQe+V2AAMnR/dA=
Date: Tue, 19 Apr 2022 02:46:44 +0000
Message-ID:
 <PAXPR08MB7420786607A15FA5027BF4579EF29@PAXPR08MB7420.eurprd08.prod.outlook.com>
References:
 <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 76C51B0BB9D43B46961B19CD6AF1B09F.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 914bf55b-cbc3-495c-6b49-08da21aedcdb
x-ms-traffictypediagnostic:
	PAXPR08MB7318:EE_|DB5EUR03FT043:EE_|DB7PR08MB3754:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB375443F1CBEB86F0085FC8419EF29@DB7PR08MB3754.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 IDtAFZYscfyL19nTKB+94ZG3jtlRT+VFO8L1ROYbLnveZ0YrzJXc9vhQVSZrT0uo+0mQL1Oo331vlh7nSEzwYCRR3NxtWT8h1EDeD3HnObz1jDrXWX25ZVgJIhKhIzhYigJj7pZnAcMS8LNKFXZEXE4HYuB3NBsCXYpJexdrVx32q3ETGZVC3aCy536Eg0G2xWMu9fPZvpZoQKW795S/EhwqTxkB+X1CCgAmPcghqNcRds+e6CXLzis3Lrc+Gr55iDXZktzuHF7F9y49/TauDT+38lLj1UHdBLa9z8rly9kI4sDcS97UViNEmfUHXVweTVBcxTUYWSNTg3xxjnBhmXOt28VdD6tzNGsNeAOHjmz9zDpbvOXvdCYviB0CjbOYvK4L8VtkJ5hB/836+G7ljWnsdSIAd6hzbuC6JbEphTcLWlUUmmcXgrFxSiPwM+NpDxfsO2kAiWUqHkaz6WeM2iB+ZHQg4JAIocNP6ypvuZNpCckFWqe6SL/wlW0lc3qA0ULz9j5Rj0JGaySKPdrKcvF6FilMAiZR8TZUUxHctqPt4U5TRWOKJZqaLyF25L47UCWZFuqnPXcwkm45JM7GePQhSMHIAKmD0GTLlQyqM57Um7XS1u+twu/G9r2VTxDnGVqcQokPgL1yT2mC/1T42Jzruj6lIak/zOfkLge09axxSA3dSE5Cmcwr762m6OWBloqixW5drieyxM/tYXLpWK5dF12nTH2d4ejPPp063Bofh8la5K7ahZD8YF8NGQ6cIO/3Rc6XG3pqS9m8V80jHJubW2xG8Mh9PJPBoDZnMz4D0O7XOvZEEXRM8FdcmCLFzB5xGnPdVwww3LHRwdYkkAA70dN/CtVPCN0dKVXlrXo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(122000001)(9686003)(5660300002)(55016003)(8936002)(2906002)(30864003)(52536014)(33656002)(316002)(4326008)(76116006)(53546011)(38070700005)(508600001)(71200400001)(7696005)(6506007)(966005)(83380400001)(26005)(186003)(66946007)(66446008)(8676002)(66476007)(86362001)(64756008)(66556008)(54906003)(6916009)(21314003)(579004)(559001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7318
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	33093326-e070-4799-dafe-08da21aed771
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Gs8/5v694l9D7kj6woKVbCaHSdlkldi2C8Zj/Rcv+YzGfGiXprQ/2e3aj9ARXXICyTD4YItFv2CrKPcLcn5rFnwjoXwkkf3jJLQXjcQLI25fDqyXLaoEln0y4cJIc67GVij+uFFbzX9U6rwpOaZUA8qi2hvuEHIkWCR9JDdIYdrU3e1U9bw3x6fzwoYmgpK+MXYZTpz6+ayUsXalSRYwlFlgc7aWdNEGxvxLYUfDwqawVKIJqnSX7LSVUDwDMg6Jn40f6waSHRU7pVCpFPukZQQr4mk6RRqZsoguLYD3D9FAecwYtzrCI15klrmeeTckbe3DlQ0SbN6vCqCcDnCCiPtnZp8XcMekW/cTVEkIsvRUuIrxPT0OIVX97/KnTVqH6uKi90/9S8wXbFbVBbFEapqfSqh7sS+IYrqIZ3GqsT42LU+4YLBxUQGX0vfoFtYYz5flELh9NBKPcZOgwLoRPI6bIAD4fHeu16EfI/pzWTuTKaDpcfKX8CjAGxjRrtFSzMUDmYbKeEzmaymf7hrUXKBdPQskmoHMSjZNOfl7MhAUa2HNokGuDy64je7h/KNZtUk9odblpDAZY2sUq7GSS1zham4YGx9LXv8sS+gGKpUZuW+qw5kYzUYB6gJkIvntbe1v/GMRiMKpcdwGTusvCpYL2IdYYs5nabIDTgrv8BoECV8bH+jucdkYq4CVA6tny/5e31kU/8W64rOh4wUWOqtqDbT/KSZ3lUr1ak6ZAV704CKBPBjNm8E5ES9UJOQ0L98A27tLwBlV11aIWd7Jo94M9O9pGaRVHg6nLZcHDUS2wmz8UHr7GwaUvZ1xgEV2EpiDnc60X9vnWX/32I2oRw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(7696005)(186003)(70206006)(82310400005)(6506007)(30864003)(70586007)(336012)(47076005)(8676002)(52536014)(4326008)(54906003)(53546011)(966005)(33656002)(5660300002)(6862004)(2906002)(83380400001)(26005)(9686003)(8936002)(86362001)(356005)(81166007)(36860700001)(55016003)(40460700003)(316002)(508600001)(21314003)(559001)(579004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 02:46:53.9739
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 914bf55b-cbc3-495c-6b49-08da21aedcdb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3754

SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVm
YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IDIwMjLE6jTU
wjE1yNUgODo0MQ0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiB4ZW4t
ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7IGp1bGllbkB4ZW4ub3JnOyBTdGVmYW5vIFN0YWJl
bGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0
cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNv
bT4NCj4gU3ViamVjdDogUmU6IFByb3Bvc2FsIGZvciBQb3J0aW5nIFhlbiB0byBBcm12OC1SNjQg
LSBEcmFmdEINCj4gDQo+IE9uIEZyaSwgMjUgTWFyIDIwMjIsIFdlaSBDaGVuIHdyb3RlOg0KPiA+
ICMgUHJvcG9zYWwgZm9yIFBvcnRpbmcgWGVuIHRvIEFybXY4LVI2NA0KPiA+DQo+ID4gVGhpcyBw
cm9wb3NhbCB3aWxsIGludHJvZHVjZSB0aGUgUG9DIHdvcmsgb2YgcG9ydGluZyBYZW4gdG8gQXJt
djgtUjY0LA0KPiA+IHdoaWNoIGluY2x1ZGVzOg0KPiA+IC0gVGhlIGNoYW5nZXMgb2YgY3VycmVu
dCBYZW4gY2FwYWJpbGl0eSwgbGlrZSBYZW4gYnVpbGQgc3lzdGVtLCBtZW1vcnkNCj4gPiAgIG1h
bmFnZW1lbnQsIGRvbWFpbiBtYW5hZ2VtZW50LCB2Q1BVIGNvbnRleHQgc3dpdGNoLg0KPiA+IC0g
VGhlIGV4cGFuZGVkIFhlbiBjYXBhYmlsaXR5LCBsaWtlIHN0YXRpYy1hbGxvY2F0aW9uIGFuZCBk
aXJlY3QtbWFwLg0KPiA+DQo+ID4gKioqTm90ZXM6KioqDQo+ID4gMS4gKioqVGhpcyBwcm9wb3Nh
bCBvbmx5IGNvdmVycyB0aGUgd29yayBvZiBwb3J0aW5nIFhlbiB0byBBcm12OC1SNjQqKioNCj4g
PiAgICAqKipzaW5nbGUgQ1BVLlhlbiBTTVAgc3VwcG9ydCBvbiBBcm12OC1SNjQgcmVsYXRlcyB0
byBBcm12OC1SKioqDQo+ID4gICAgKioqVHJ1c3RlZC1Gcmltd2FyZSAoVEYtUikuIFRoaXMgaXMg
YW4gZXh0ZXJuYWwgZGVwZW5kZW5jeSwqKioNCj4gPiAgICAqKipzbyB3ZSB0aGluayB0aGUgZGlz
Y3Vzc2lvbiBvZiBYZW4gU01QIHN1cHBvcnQgb24gQXJtdjgtUjY0KioqDQo+ID4gICAgKioqc2hv
dWxkIGJlIHN0YXJ0ZWQgd2hlbiBzaW5nbGUtQ1BVIHN1cHBvcnQgaXMgY29tcGxldGUuKioqDQo+
ID4gMi4gKioqVGhpcyBwcm9wb3NhbCB3aWxsIG5vdCB0b3VjaCB4ZW4tdG9vbHMuIEluIGN1cnJl
bnQgc3RhbmdlLCoqKg0KPiA+ICAgICoqKlhlbiBvbiBBcm12OC1SNjQgb25seSBzdXBwb3J0IGRv
bTBsZXNzLCBhbGwgZ3Vlc3RzIHNob3VsZCoqKg0KPiA+ICAgICoqKmJlIGJvb3RlZCBmcm9tIGRl
dmljZSB0cmVlLioqKg0KPiA+DQo+ID4gIyMgQ2hhbmdlbG9ncw0KPiA+IERyYWZ0LUEgLT4gRHJh
ZnQtQjoNCj4gPiAxLiBVcGRhdGUgS2NvbmZpZyBvcHRpb25zIHVzYWdlLg0KPiA+IDIuIFVwZGF0
ZSB0aGUgc2VjdGlvbiBmb3IgWEVOX1NUQVJUX0FERFJFU1MuDQo+ID4gMy4gQWRkIGRlc2NyaXB0
aW9uIG9mIE1QVSBpbml0aWFsaXphdGlvbiBiZWZvcmUgcGFyc2luZyBkZXZpY2UgdHJlZS4NCj4g
PiA0LiBSZW1vdmUgQ09ORklHX0FSTV9NUFVfRUwxX1BST1RFQ1RJT05fUkVHSU9OUy4NCj4gPiA1
LiBVcGRhdGUgdGhlIGRlc2NyaXB0aW9uIG9mIGlvcmVtYXBfbm9jYWNoZS9jYWNoZS4NCj4gPiA2
LiBVcGRhdGUgYWJvdXQgdGhlIGZyZWVfaW5pdF9tZW1vcnkgb24gQXJtdjgtUi4NCj4gPiA3LiBE
ZXNjcmliZSB3aHkgd2UgbmVlZCB0byBzd2l0Y2ggdGhlIE1QVSBjb25maWd1cmF0aW9uIGxhdGVy
Lg0KPiA+IDguIEFkZCBhbHRlcm5hdGl2ZSBwcm9wb3NhbCBpbiBUT0RPLg0KPiA+IDkuIEFkZCB1
c2UgdG9vbCB0byBnZW5lcmF0ZSBYZW4gQXJtdjgtUiBkZXZpY2UgdHJlZSBpbiBUT0RPLg0KPiA+
IDEwLiBBZGQgWGVuIFBJQy9QSUUgZGlzY3Vzc2lvbiBpbiBUT0RPLg0KPiA+IDExLiBBZGQgWGVu
IGV2ZW50IGNoYW5uZWwgc3VwcG9ydCBpbiBUT0RPLg0KPiA+DQo+ID4gIyMgQ29udHJpYnV0b3Jz
Og0KPiA+IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiA+IFBlbm55IFpoZW5nIDxQZW5u
eS5aaGVuZ0Bhcm0uY29tPg0KPiA+DQo+ID4gIyMgMS4gRXNzZW50aWFsIEJhY2tncm91bmQNCj4g
Pg0KPiA+ICMjIyAxLjEuIEFybXY4LVI2NCBQcm9maWxlDQo+ID4gVGhlIEFybXYtUiBhcmNoaXRl
Y3R1cmUgcHJvZmlsZSB3YXMgZGVzaWduZWQgdG8gc3VwcG9ydCB1c2UgY2FzZXMgdGhhdA0KPiA+
IGhhdmUgYSBoaWdoIHNlbnNpdGl2aXR5IHRvIGRldGVybWluaXN0aWMgZXhlY3V0aW9uLiAoZS5n
LiBGdWVsIEluamVjdGlvbiwNCj4gPiBCcmFrZSBjb250cm9sLCBEcml2ZSB0cmFpbnMsIE1vdG9y
IGNvbnRyb2wgZXRjKQ0KPiA+DQo+ID4gQXJtIGFubm91bmNlZCBBcm12OC1SIGluIDIwMTMsIGl0
IGlzIHRoZSBsYXRlc3QgZ2VuZXJhdGlvbiBBcm0NCj4gYXJjaGl0ZWN0dXJlDQo+ID4gdGFyZ2V0
ZWQgYXQgdGhlIFJlYWwtdGltZSBwcm9maWxlLiBJdCBpbnRyb2R1Y2VzIHZpcnR1YWxpemF0aW9u
IGF0IHRoZQ0KPiBoaWdoZXN0DQo+ID4gc2VjdXJpdHkgbGV2ZWwgd2hpbGUgcmV0YWluaW5nIHRo
ZSBQcm90ZWN0ZWQgTWVtb3J5IFN5c3RlbSBBcmNoaXRlY3R1cmUNCj4gKFBNU0EpDQo+ID4gYmFz
ZWQgb24gYSBNZW1vcnkgUHJvdGVjdGlvbiBVbml0IChNUFUpLiBJbiAyMDIwLCBBcm0gYW5ub3Vu
Y2VkIENvcnRleC0NCj4gUjgyLA0KPiA+IHdoaWNoIGlzIHRoZSBmaXJzdCBBcm0gNjQtYml0IENv
cnRleC1SIHByb2Nlc3NvciBiYXNlZCBvbiBBcm12OC1SNjQuDQo+ID4NCj4gPiAtIFRoZSBsYXRl
c3QgQXJtdjgtUjY0IGRvY3VtZW50IGNhbiBiZSBmb3VuZCBoZXJlOg0KPiA+ICAgW0FybSBBcmNo
aXRlY3R1cmUgUmVmZXJlbmNlIE1hbnVhbCBTdXBwbGVtZW50IC0gQXJtdjgsIGZvciBBcm12OC1S
DQo+IEFBcmNoNjQgYXJjaGl0ZWN0dXJlDQo+IHByb2ZpbGVdKGh0dHBzOi8vZGV2ZWxvcGVyLmFy
bS5jb20vZG9jdW1lbnRhdGlvbi9kZGkwNjAwL2xhdGVzdC8pLg0KPiA+DQo+ID4gLSBBcm12LVIg
QXJjaGl0ZWN0dXJlIHByb2dyZXNzaW9uOg0KPiA+ICAgQXJtdjctUiAtPiBBcm12OC1SIEFBcmNo
MzIgLT4gQXJtdjggQUFyY2g2NA0KPiA+ICAgVGhlIGZvbGxvd2luZyBmaWd1cmUgaXMgYSBzaW1w
bGUgY29tcGFyaXNvbiBvZiAiUiIgcHJvY2Vzc29ycyBiYXNlZCBvbg0KPiA+ICAgZGlmZmVyZW50
IEFybXYtUiBBcmNoaXRlY3R1cmVzLg0KPiA+ICAgIVtpbWFnZV0oaHR0cHM6Ly9kcml2ZS5nb29n
bGUuY29tL3VjP2V4cG9ydD12aWV3JmlkPTFuRTVSQVhhWDh6WTJLUFo4aQ0KPiBtQnBidklyMmVx
Qmd1RUIpDQo+ID4NCj4gPiAtIFRoZSBBcm12OC1SIGFyY2hpdGVjdHVyZSBldm9sdmVkIGFkZGl0
aW9uYWwgZmVhdHVyZXMgb24gdG9wIG9mIEFybXY3LVI6DQo+ID4gICAgIC0gQW4gZXhjZXB0aW9u
IG1vZGVsIHRoYXQgaXMgY29tcGF0aWJsZSB3aXRoIHRoZSBBcm12OC1BIG1vZGVsDQo+ID4gICAg
IC0gVmlydHVhbGl6YXRpb24gd2l0aCBzdXBwb3J0IGZvciBndWVzdCBvcGVyYXRpbmcgc3lzdGVt
cw0KPiA+ICAgICAgICAgLSBQTVNBIHZpcnR1YWxpemF0aW9uIHVzaW5nIE1QVXMgSW4gRUwyLg0K
PiA+IC0gVGhlIG5ldyBmZWF0dXJlcyBvZiBBcm12OC1SNjQgYXJjaGl0ZWN0dXJlDQo+ID4gICAg
IC0gQWRkcyBzdXBwb3J0IGZvciB0aGUgNjQtYml0IEE2NCBpbnN0cnVjdGlvbiBzZXQsIHByZXZp
b3VzbHkgQXJtdjgtDQo+IFINCj4gPiAgICAgICBvbmx5IHN1cHBvcnRlZCBBMzIuDQo+ID4gICAg
IC0gU3VwcG9ydHMgdXAgdG8gNDgtYml0IHBoeXNpY2FsIGFkZHJlc3NpbmcsIHByZXZpb3VzbHkg
dXAgdG8gMzItYml0DQo+ID4gICAgICAgYWRkcmVzc2luZyB3YXMgc3VwcG9ydGVkLg0KPiA+ICAg
ICAtIE9wdGlvbmFsIEFybSBOZW9uIHRlY2hub2xvZ3kgYW5kIEFkdmFuY2VkIFNJTUQNCj4gPiAg
ICAgLSBTdXBwb3J0cyB0aHJlZSBFeGNlcHRpb24gTGV2ZWxzIChFTHMpDQo+ID4gICAgICAgICAt
IFNlY3VyZSBFTDIgLSBUaGUgSGlnaGVzdCBQcml2aWxlZ2UsIE1QVSBvbmx5LCBmb3IgZmlybXdh
cmUsDQo+IGh5cGVydmlzb3INCj4gPiAgICAgICAgIC0gU2VjdXJlIEVMMSAtIFJpY2hPUyAoTU1V
KSBvciBSVE9TIChNUFUpDQo+ID4gICAgICAgICAtIFNlY3VyZSBFTDAgLSBBcHBsaWNhdGlvbiBX
b3JrbG9hZHMNCj4gPiAgICAgLSBPcHRpb25hbGx5IHN1cHBvcnRzIFZpcnR1YWwgTWVtb3J5IFN5
c3RlbSBBcmNoaXRlY3R1cmUgYXQgUy1FTDEvUy0NCj4gRUwwLg0KPiA+ICAgICAgIFRoaXMgbWVh
bnMgaXQncyBwb3NzaWJsZSB0byBydW4gcmljaCBPUyBrZXJuZWxzIC0gbGlrZSBMaW51eCAtDQo+
IGVpdGhlcg0KPiA+ICAgICAgIGJhcmUtbWV0YWwgb3IgYXMgYSBndWVzdC4NCj4gPiAtIERpZmZl
cmVuY2VzIHdpdGggdGhlIEFybXY4LUEgQUFyY2g2NCBhcmNoaXRlY3R1cmUNCj4gPiAgICAgLSBT
dXBwb3J0cyBvbmx5IGEgc2luZ2xlIFNlY3VyaXR5IHN0YXRlIC0gU2VjdXJlLiBUaGVyZSBpcyBu
b3QgTm9uLQ0KPiBTZWN1cmUNCj4gPiAgICAgICBleGVjdXRpb24gc3RhdGUgc3VwcG9ydGVkLg0K
PiA+ICAgICAtIEVMMyBpcyBub3Qgc3VwcG9ydGVkLCBFTDIgaXMgbWFuZGF0b3J5LiBUaGlzIG1l
YW5zIHNlY3VyZSBFTDIgaXMNCj4gdGhlDQo+ID4gICAgICAgaGlnaGVzdCBFTC4NCj4gPiAgICAg
LSBTdXBwb3J0cyB0aGUgQTY0IElTQSBpbnN0cnVjdGlvbg0KPiA+ICAgICAgICAgLSBXaXRoIGEg
c21hbGwgc2V0IG9mIHdlbGwtZGVmaW5lZCBkaWZmZXJlbmNlcw0KPiA+ICAgICAtIFByb3ZpZGVz
IGEgUE1TQSAoUHJvdGVjdGVkIE1lbW9yeSBTeXN0ZW0gQXJjaGl0ZWN0dXJlKSBiYXNlZA0KPiA+
ICAgICAgIHZpcnR1YWxpemF0aW9uIG1vZGVsLg0KPiA+ICAgICAgICAgLSBBcyBvcHBvc2VkIHRv
IEFybXY4LUEgQUFyY2g2NCdzIFZNU0EgYmFzZWQgVmlydHVhbGl6YXRpb24NCj4gPiAgICAgICAg
IC0gQ2FuIHN1cHBvcnQgYWRkcmVzcyBiaXRzIHVwIHRvIDUyIGlmIEZFQVRfTFBBIGlzIGVuYWJs
ZWQsDQo+ID4gICAgICAgICAgIG90aGVyd2lzZSA0OCBiaXRzLg0KPiA+ICAgICAgICAgLSBEZXRl
cm1pbmVzIHRoZSBhY2Nlc3MgcGVybWlzc2lvbnMgYW5kIG1lbW9yeSBhdHRyaWJ1dGVzIG9mDQo+
ID4gICAgICAgICAgIHRoZSB0YXJnZXQgUEEuDQo+ID4gICAgICAgICAtIENhbiBpbXBsZW1lbnQg
UE1TQXY4LTY0IGF0IEVMMSBhbmQgRUwyDQo+ID4gICAgICAgICAgICAgLSBBZGRyZXNzIHRyYW5z
bGF0aW9uIGZsYXQtbWFwcyB0aGUgVkEgdG8gdGhlIFBBIGZvciBFTDINCj4gU3RhZ2UgMS4NCj4g
PiAgICAgICAgICAgICAtIEFkZHJlc3MgdHJhbnNsYXRpb24gZmxhdC1tYXBzIHRoZSBWQSB0byB0
aGUgUEEgZm9yIEVMMQ0KPiBTdGFnZSAxLg0KPiA+ICAgICAgICAgICAgIC0gQWRkcmVzcyB0cmFu
c2xhdGlvbiBmbGF0LW1hcHMgdGhlIElQQSB0byB0aGUgUEEgZm9yIEVMMQ0KPiBTdGFnZSAyLg0K
PiA+ICAgICAtIFBNU0EgaW4gRUwxICYgRUwyIGlzIGNvbmZpZ3VyYWJsZSwgVk1TQSBpbiBFTDEg
aXMgY29uZmlndXJhYmxlLg0KPiA+DQo+ID4gIyMjIDEuMi4gWGVuIENoYWxsZW5nZXMgd2l0aCBQ
TVNBIFZpcnR1YWxpemF0aW9uDQo+ID4gWGVuIGlzIFBNU0EgdW5hd2FyZSBUeXBlLTEgSHlwZXJ2
aXNvciwgaXQgd2lsbCBuZWVkIG1vZGlmaWNhdGlvbnMgdG8gcnVuDQo+ID4gd2l0aCBhbiBNUFUg
YW5kIGhvc3QgbXVsdGlwbGUgZ3Vlc3QgT1Nlcy4NCj4gPg0KPiA+IC0gTm8gTU1VIGF0IEVMMjoN
Cj4gPiAgICAgLSBObyBFTDIgU3RhZ2UgMSBhZGRyZXNzIHRyYW5zbGF0aW9uDQo+ID4gICAgICAg
ICAtIFhlbiBwcm92aWRlcyBmaXhlZCBBUk02NCB2aXJ0dWFsIG1lbW9yeSBsYXlvdXQgYXMgYmFz
aXMgb2YgRUwyDQo+ID4gICAgICAgICAgIHN0YWdlIDEgYWRkcmVzcyB0cmFuc2xhdGlvbiwgd2hp
Y2ggaXMgbm90IGFwcGxpY2FibGUgb24gTVBVDQo+IHN5c3RlbSwNCj4gPiAgICAgICAgICAgd2hl
cmUgdGhlcmUgaXMgbm8gdmlydHVhbCBhZGRyZXNzaW5nLiBBcyBhIHJlc3VsdCwgYW55DQo+IG9w
ZXJhdGlvbg0KPiA+ICAgICAgICAgICBpbnZvbHZpbmcgdHJhbnNpdGlvbiBmcm9tIFBBIHRvIFZB
LCBsaWtlIGlvcmVtYXAsIG5lZWRzDQo+IG1vZGlmaWNhdGlvbg0KPiA+ICAgICAgICAgICBvbiBN
UFUgc3lzdGVtLg0KPiA+ICAgICAtIFhlbidzIHJ1bi10aW1lIGFkZHJlc3NlcyBhcmUgdGhlIHNh
bWUgYXMgdGhlIGxpbmsgdGltZSBhZGRyZXNzZXMuDQo+ID4gICAgICAgICAtIEVuYWJsZSBQSUMv
UElFIChwb3NpdGlvbi1pbmRlcGVuZGVudCBjb2RlKSBvbiBhIHJlYWwtdGltZQ0KPiB0YXJnZXQN
Cj4gPiAgICAgICAgICAgcHJvY2Vzc29yIHByb2JhYmx5IHZlcnkgcmFyZS4gRnVydGhlciBkaXNj
dXNzaW9uIGluIDIuMSBhbmQNCj4gVE9ETw0KPiA+ICAgICAgICAgICBzZWN0aW9ucy4NCj4gPiAg
ICAgLSBYZW4gd2lsbCBuZWVkIHRvIHVzZSB0aGUgRUwyIE1QVSBtZW1vcnkgcmVnaW9uIGRlc2Ny
aXB0b3JzIHRvDQo+IG1hbmFnZQ0KPiA+ICAgICAgIGFjY2VzcyBwZXJtaXNzaW9ucyBhbmQgYXR0
cmlidXRlcyBmb3IgYWNjZXNzZXMgbWFkZSBieSBWTXMgYXQNCj4gRUwxLzAuDQo+ID4gICAgICAg
ICAtIFhlbiBjdXJyZW50bHkgcmVsaWVzIG9uIE1NVSBFTDEgc3RhZ2UgMiB0YWJsZSB0byBtYW5h
Z2UgdGhlc2UNCj4gPiAgICAgICAgICAgYWNjZXNzZXMuDQo+ID4gLSBObyBNTVUgU3RhZ2UgMiB0
cmFuc2xhdGlvbiBhdCBFTDE6DQo+ID4gICAgIC0gQSBndWVzdCBkb2Vzbid0IGhhdmUgYW4gaW5k
ZXBlbmRlbnQgZ3Vlc3QgcGh5c2ljYWwgYWRkcmVzcyBzcGFjZQ0KPiA+ICAgICAtIEEgZ3Vlc3Qg
Y2FuIG5vdCByZXVzZSB0aGUgY3VycmVudCBJbnRlcm1lZGlhdGUgUGh5c2ljYWwgQWRkcmVzcw0K
PiA+ICAgICAgIG1lbW9yeSBsYXlvdXQNCj4gPiAgICAgLSBBIGd1ZXN0IHVzZXMgcGh5c2ljYWwg
YWRkcmVzc2VzIHRvIGFjY2VzcyBtZW1vcnkgYW5kIGRldmljZXMNCj4gPiAgICAgLSBUaGUgTVBV
IGF0IEVMMiBtYW5hZ2VzIEVMMSBzdGFnZSAyIGFjY2VzcyBwZXJtaXNzaW9ucyBhbmQNCj4gYXR0
cmlidXRlcw0KPiA+IC0gVGhlcmUgYXJlIGEgbGltaXRlZCBudW1iZXIgb2YgTVBVIHByb3RlY3Rp
b24gcmVnaW9ucyBhdCBib3RoIEVMMiBhbmQNCj4gRUwxOg0KPiA+ICAgICAtIEFyY2hpdGVjdHVy
YWxseSwgdGhlIG1heGltdW0gbnVtYmVyIG9mIHByb3RlY3Rpb24gcmVnaW9ucyBpcyAyNTYsDQo+
ID4gICAgICAgdHlwaWNhbCBpbXBsZW1lbnRhdGlvbnMgaGF2ZSAzMi4NCj4gPiAgICAgLSBCeSBj
b250cmFzdCwgWGVuIGRvZXMgbm90IG5lZWQgdG8gY29uc2lkZXIgdGhlIG51bWJlciBvZiBwYWdl
DQo+IHRhYmxlDQo+ID4gICAgICAgZW50cmllcyBpbiB0aGVvcnkgd2hlbiB1c2luZyBNTVUuDQo+
ID4gLSBUaGUgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyBhdCBFTDIgbmVlZCB0byBiZSBzaGFyZWQg
YmV0d2VlbiB0aGUNCj4gaHlwZXJ2aXNvcg0KPiA+ICAgYW5kIHRoZSBndWVzdCBzdGFnZSAyLg0K
PiA+ICAgICAtIFJlcXVpcmVzIGNhcmVmdWwgY29uc2lkZXJhdGlvbiAtIG1heSBpbXBhY3QgZmVh
dHVyZSAnZnVsbG5lc3MnIG9mDQo+IGJvdGgNCj4gPiAgICAgICB0aGUgaHlwZXJ2aXNvciBhbmQg
dGhlIGd1ZXN0DQo+ID4gICAgIC0gQnkgY29udHJhc3QsIHdoZW4gdXNpbmcgTU1VLCBYZW4gaGFz
IHN0YW5kYWxvbmUgUDJNIHRhYmxlIGZvcg0KPiBndWVzdA0KPiA+ICAgICAgIHN0YWdlIDIgYWNj
ZXNzZXMuDQo+ID4NCj4gPiAjIyAyLiBQcm9wb3NlZCBjaGFuZ2VzIG9mIFhlbg0KPiA+ICMjIyAq
KjIuMS4gQ2hhbmdlcyBvZiBidWlsZCBzeXN0ZW06KioNCj4gPg0KPiA+IC0gKioqSW50cm9kdWNl
IG5ldyBLY29uZmlnIG9wdGlvbnMgZm9yIEFybXY4LVI2NCoqKjoNCj4gPiAgIFVubGlrZSBBcm12
OC1BLCBiZWNhdXNlIGxhY2sgb2YgTU1VIHN1cHBvcnQgb24gQXJtdjgtUjY0LCB3ZSBtYXkgbm90
DQo+ID4gICBleHBlY3Qgb25lIFhlbiBiaW5hcnkgdG8gcnVuIG9uIGFsbCBtYWNoaW5lcy4gWGVu
IGltYWdlcyBhcmUgbm90DQo+IGNvbW1vbg0KPiA+ICAgYWNyb3NzIEFybXY4LVI2NCBwbGF0Zm9y
bXMuIFhlbiBtdXN0IGJlIHJlLWJ1aWx0IGZvciBkaWZmZXJlbnQgQXJtdjgtDQo+IFI2NA0KPiA+
ICAgcGxhdGZvcm1zLiBCZWNhdXNlIHRoZXNlIHBsYXRmb3JtcyBtYXkgaGF2ZSBkaWZmZXJlbnQg
bWVtb3J5IGxheW91dA0KPiBhbmQNCj4gPiAgIGxpbmsgYWRkcmVzcy4NCj4gPiAgICAgLSBgQVJN
NjRfVjhSYDoNCj4gPiAgICAgICBUaGlzIG9wdGlvbiBlbmFibGVzIEFybXY4LVIgcHJvZmlsZSBm
b3IgQXJtNjQuIEVuYWJsaW5nIHRoaXMNCj4gb3B0aW9uDQo+ID4gICAgICAgcmVzdWx0cyBpbiBz
ZWxlY3RpbmcgTVBVLiBUaGlzIEtjb25maWcgb3B0aW9uIGlzIHVzZWQgdG8gZ2F0ZSBzb21lDQo+
ID4gICAgICAgQXJtdjgtUjY0IHNwZWNpZmljIGNvZGUgZXhjZXB0IE1QVSBjb2RlLCBsaWtlIHNv
bWUgY29kZSBmb3IgQXJtdjgtDQo+IFI2NA0KPiA+ICAgICAgIG9ubHkgc3lzdGVtIElEIHJlZ2lz
dGVycyBhY2Nlc3MuDQo+ID4NCj4gPiAgICAgLSBgQVJNX01QVWANCj4gPiAgICAgICBUaGlzIG9w
dGlvbiBlbmFibGVzIE1QVSBvbiBBcm12OC1SIGFyY2hpdGVjdHVyZS4gRW5hYmxpbmcgdGhpcw0K
PiBvcHRpb24NCj4gPiAgICAgICByZXN1bHRzIGluIGRpc2FibGluZyBNTVUuIFRoaXMgS2NvbmZp
ZyBvcHRpb24gaXMgdXNlZCB0byBnYXRlIHNvbWUNCj4gPiAgICAgICBBUk1fTVBVIHNwZWNpZmlj
IGNvZGUuIE9uY2Ugd2hlbiB0aGlzIEtjb25maWcgb3B0aW9uIGhhcyBiZWVuDQo+IGVuYWJsZWQs
DQo+ID4gICAgICAgdGhlIE1NVSByZWxhdGUgY29kZSB3aWxsIG5vdCBiZSBidWlsdCBmb3IgQXJt
djgtUjY0LiBUaGUgcmVhc29uDQo+IHdoeQ0KPiA+ICAgICAgIG5vdCBkZXBlbmRzIG9uIHJ1bnRp
bWUgZGV0ZWN0aW9uIHRvIHNlbGVjdCBNTVUgb3IgTVBVIGlzIHRoYXQsIHdlDQo+IGRvbid0DQo+
ID4gICAgICAgdGhpbmsgd2UgY2FuIHVzZSBvbmUgaW1hZ2UgZm9yIGJvdGggQXJtdjgtUjY0IGFu
ZCBBcm12OC1BNjQuDQo+IEFub3RoZXINCj4gPiAgICAgICByZWFzb24gdGhhdCB3ZSBzZXBhcmF0
ZSBNUFUgYW5kIFY4UiBpbiBwcm92aXNpb24gdG8gYWxsb3cgdG8NCj4gc3VwcG9ydCBNUFUNCj4g
PiAgICAgICBvbiAzMmJpdCBBcm0gb25lIGRheS4NCj4gPg0KPiA+ICAgKioqVHJ5IHRvIHVzZSBg
aWYgKCBJU19FTkFCTEVEKENPTkZJR19BUk1YWFhYKSApYCBpbnN0ZWFkIG9mDQo+IHNwcmVhZGlu
ZyoqKg0KPiA+ICAgKioqYCNpZmRlZiBDT05GSUdfQVJNWFhYWGAgZXZlcnl3aGVyZSwgaWYgaXQg
aXMgcG9zc2libGUuKioqDQo+ID4NCj4gPiAtICoqKkFib3V0IFhlbiBzdGFydCBhZGRyZXNzIGZv
ciBBcm12OC1SNjQqKio6DQo+ID4gICBPbiBBcm12OC1BLCBYZW4gaGFzIGEgZml4ZWQgdmlydHVh
bCBzdGFydCBhZGRyZXNzIChsaW5rIGFkZHJlc3MgdG9vKQ0KPiBvbiBhbGwNCj4gPiAgIEFybXY4
LUEgcGxhdGZvcm1zLiBJbiBhbiBNTVUgYmFzZWQgc3lzdGVtLCBYZW4gY2FuIG1hcCBpdHMgbG9h
ZGVkDQo+IGFkZHJlc3MNCj4gPiAgIHRvIHRoaXMgdmlydHVhbCBzdGFydCBhZGRyZXNzLiBPbiBB
cm12OC1BIHBsYXRmb3JtcywgdGhlIFhlbiBzdGFydA0KPiBhZGRyZXNzDQo+ID4gICBkb2VzIG5v
dCBuZWVkIHRvIGJlIGNvbmZpZ3VyYWJsZS4gQnV0IG9uIEFybXY4LVIgcGxhdGZvcm1zLCB0aGV5
IGRvbid0DQo+IGhhdmUNCj4gPiAgIE1NVSB0byBtYXAgbG9hZGVkIGFkZHJlc3MgdG8gYSBmaXhl
ZCB2aXJ0dWFsIGFkZHJlc3MuIEFuZCBkaWZmZXJlbnQNCj4gcGxhdGZvcm1zDQo+ID4gICB3aWxs
IGhhdmUgdmVyeSBkaWZmZXJlbnQgYWRkcmVzcyBzcGFjZSBsYXlvdXQsIHNvIGl0J3MgaW1wb3Nz
aWJsZSBmb3INCj4gWGVuIHRvDQo+ID4gICBzcGVjaWZ5IGEgZml4ZWQgcGh5c2ljYWwgYWRkcmVz
cyBmb3IgYWxsIEFybXY4LVIgcGxhdGZvcm1zJyBzdGFydA0KPiBhZGRyZXNzLg0KPiA+DQo+ID4g
ICAtIGBYRU5fU1RBUlRfQUREUkVTU2ANCj4gPiAgICAgVGhpcyBvcHRpb24gYWxsb3dzIHRvIHNl
dCB0aGUgY3VzdG9tIGFkZHJlc3MgYXQgd2hpY2ggWGVuIHdpbGwgYmUNCj4gPiAgICAgbGlua2Vk
LiBUaGlzIGFkZHJlc3MgbXVzdCBiZSBhbGlnbmVkIHRvIGEgcGFnZSBzaXplLiBYZW4ncyBydW4t
dGltZQ0KPiA+ICAgICBhZGRyZXNzZXMgYXJlIHRoZSBzYW1lIGFzIHRoZSBsaW5rIHRpbWUgYWRk
cmVzc2VzLg0KPiA+ICAgICAqKipOb3RlczogRml4ZWQgbGluayBhZGRyZXNzIG1lYW5zIHRoZSBY
ZW4gYmluYXJ5IGNvdWxkIG5vdCBiZSoqKg0KPiA+ICAgICAqKipyZWxvY2F0ZWQgYnkgRUZJIGxv
YWRlci4gU28gaW4gY3VycmVudCBzdGFnZSwgWGVuIGNvdWxkIG5vdCoqKg0KPiA+ICAgICAqKipi
ZSBsYXVuY2hlZCBhcyBhbiBFRkkgYXBwbGljYXRpb24gb24gQXJtdjgtUjY0LihUT0RPIzMuMykq
KioNCj4gPg0KPiA+ICAgICAtIFByb3ZpZGVkIGJ5IHBsYXRmb3JtIGZpbGVzLg0KPiA+ICAgICAg
IFdlIGNhbiByZXVzZSB0aGUgZXhpc3RlZCBhcm0vcGxhdGZvcm1zIHN0b3JlIHBsYXRmb3JtIHNw
ZWNpZmljDQo+IGZpbGVzLg0KPiA+ICAgICAgIEFuZCBgWEVOX1NUQVJUX0FERFJFU1NgIGlzIG9u
ZSBraW5kIG9mIHBsYXRmb3JtIHNwZWNpZmljDQo+IGluZm9ybWF0aW9uLg0KPiA+ICAgICAgIFNv
IHdlIGNhbiB1c2UgcGxhdGZvcm0gZmlsZSB0byBkZWZpbmUgZGVmYXVsdCBgWEVOX1NUQVJUX0FE
RFJFU1NgDQo+IGZvcg0KPiA+ICAgICAgIGVhY2ggcGxhdGZvcm0uDQo+ID4NCj4gPiAgICAgLSBQ
cm92aWRlZCBieSBLY29uZmlnLg0KPiA+ICAgICAgIFRoaXMgb3B0aW9uIGNhbiBiZSBhbiBpbmRl
cGVuZGVudCBvciBhIHN1cHBseW1lbnRhbCBvcHRpb24uIFVzZXJzDQo+IGNhbg0KPiA+ICAgICAg
IGRlZmluZSBhIGN1c3RvbWl6ZWQgYFhFTl9TVEFSVF9BRERSRVNTYCB0byBvdmVycmlkZSB0aGUg
ZGVmYXVsdA0KPiB2YWx1ZQ0KPiA+ICAgICAgIGluIHBsYXRmb3JtJ3MgZmlsZS4NCj4gPg0KPiA+
ICAgICAtIEdlbmVyYXRlZCBmcm9tIGRldmljZSB0cmVlIGJ5IGJ1aWxkIHNjcmlwdHMgKG9wdGlv
bmFsKQ0KPiA+ICAgICAgIFZlbmRvcnMgd2hvIHdhbnQgdG8gZW5hYmxlIFhlbiBvbiB0aGVpciBB
cm12OC1SIHBsYXRmb3JtcywgdGhleQ0KPiBjYW4NCj4gPiAgICAgICB1c2Ugc29tZSB0b29scy9z
Y3JpcHRzIHRvIHBhcnNlIHRoZWlyIGJvYXJkcyBkZXZpY2UgdHJlZSB0bw0KPiBnZW5lcmF0ZQ0K
PiA+ICAgICAgIHRoZSBiYXNpYyBwbGF0Zm9ybSBpbmZvcm1hdGlvbi4gVGhlc2UgdG9vbHMvc2Ny
aXB0cyBkbyBub3QNCj4gbmVjZXNzYXJpbHkNCj4gPiAgICAgICBuZWVkIHRvIGJlIGludGVncmF0
ZWQgaW4gWGVuLCBidXQgWGVuIGNhbiBnaXZlIHNvbWUgcmVjb21tZW5kZWQNCj4gPiAgICAgICBj
b25maWd1cmF0aW9uLiBGb3IgZXhhbXBsZSwgWGVuIGNhbiByZWNvbW1lbmQgQXJtdjgtUiBwbGF0
Zm9ybXMgdG8NCj4gdXNlDQo+ID4gICAgICAgbG93ZXN0IHJhbSBzdGFydCBhZGRyZXNzICsgMk1C
IGFzIHRoZSBkZWZhdWx0IFhlbiBzdGFydCBhZGRyZXNzLg0KPiA+ICAgICAgIFRoZSBnZW5lcmF0
ZWQgcGxhdGZvcm0gZmlsZXMgY2FuIGJlIHBsYWNlZCB0byBhcm0vcGxhdGZvcm1zIGZvcg0KPiA+
ICAgICAgIG1haW50ZW5hbmNlLg0KPiA+DQo+ID4gICAgIC0gRW5hYmxlIFhlbiBQSUMvUElFIChv
cHRpb25hbCkNCj4gPiAgICAgICBXZSBoYXZlIG1lbnRpb25lZCBhYm91dCBQSUMvUElFIGluIHNl
Y3Rpb24gMS4yLiBXaXRoIFBJQy9QSUUNCj4gc3VwcG9ydCwNCj4gPiAgICAgICBYZW4gY2FuIHJ1
biBmcm9tIGV2ZXJ5d2hlcmUgaXQgaGFzIGJlZW4gbG9hZGVkLiBCdXQgaXQncyByYXJlIHRvDQo+
IHVzZQ0KPiA+ICAgICAgIFBJQy9QSUUgb24gYSByZWFsLXRpbWUgc3lzdGVtIChjb2RlIHNpemUs
IG1vcmUgbWVtb3J5IGFjY2VzcykuIFNvDQo+IGENCj4gPiAgICAgICBwYXJ0aWFsIFBJQy9QSUUg
aW1hZ2UgbWF5YmUgYmV0dGVyIChzZWUgMy4gVE9ETyBzZWN0aW9uKS4gQnV0DQo+IHBhcnRpYWwN
Cj4gPiAgICAgICBQSUMvUElFIGltYWdlIG1heSBub3Qgc29sdmUgdGhpcyBYZW4gc3RhcnQgYWRk
cmVzcyBpc3N1ZS4NCj4gDQo+IEkgbGlrZSB0aGUgZGVzY3JpcHRpb24gb2YgdGhlIFhFTl9TVEFS
VF9BRERSRVNTIHByb2JsZW0gYW5kIHNvbHV0aW9ucy4NCj4gDQo+IEZvciB0aGUgaW5pdGlhbCBp
bXBsZW1lbnRhdGlvbiwgYSBwbGF0Zm9ybSBmaWxlIGlzIGZpbmUuIFdlIG5lZWQgdG8NCj4gc3Rh
cnQgZWFzeS4NCj4gDQo+IEFmdGVyd2FyZHMsIEkgdGhpbmsgaXQgd291bGQgYmUgZmFyIGJldHRl
ciB0byBzd2l0Y2ggdG8gYSBzY3JpcHQgdGhhdA0KPiBhdXRvbWF0aWNhbGx5IGdlbmVyYXRlcyBY
RU5fU1RBUlRfQUREUkVTUyBmcm9tIHRoZSBob3N0IGRldmljZSB0cmVlLg0KPiBBbHNvLCBpZiB3
ZSBwcm92aWRlIGEgd2F5IHRvIGN1c3RvbWl6ZSB0aGUgc3RhcnQgYWRkcmVzcyB2aWEgS2NvbmZp
ZywNCj4gdGhlbiB0aGUgc2NyaXB0IHRoYXQgcmVhZHMgdGhlIGRldmljZSB0cmVlIGNvdWxkIHNp
bXBseSBvdXRwdXQgdGhlIHJpZ2h0DQo+IENPTkZJR18qIG9wdGlvbiBmb3IgWGVuIHRvIGJ1aWxk
LiBJdCB3b3VsZG4ndCBldmVuIGhhdmUgdG8gZ2VuZXJhdGUgYW4NCj4gaGVhZGVyIGZpbGUuDQo+
IA0KPiANCj4gPiAtICoqKkFib3V0IE1QVSBpbml0aWFsaXphdGlvbiBiZWZvcmUgcGFyc2luZyBk
ZXZpY2UgdHJlZSoqKjoNCj4gPiAgICAgICBCZWZvcmUgWGVuIGNhbiBzdGFydCBwYXJzaW5nIGlu
Zm9ybWF0aW9uIGZyb20gZGV2aWNlIHRyZWUgYW5kIHVzZQ0KPiA+ICAgICAgIHRoaXMgaW5mb3Jt
YXRpb24gdG8gc2V0dXAgTVBVLCBYZW4gbmVlZCBhbiBpbml0aWFsIE1QVSBzdGF0ZS4gVGhpcw0K
PiA+ICAgICAgIGlzIGJlY2F1c2U6DQo+ID4gICAgICAgMS4gTW9yZSBkZXRlcm1pbmlzdGljOiBB
cm0gTVBVIHN1cHBvcnRzIGJhY2tncm91bmQgcmVnaW9ucywgaWYgd2UNCj4gPiAgICAgICAgICBk
b24ndCBjb25maWd1cmUgdGhlIE1QVSByZWdpb25zIGFuZCBkb24ndCBlbmFibGUgTVBVLiBUaGUN
Cj4gZGVmYXVsdA0KPiA+ICAgICAgICAgIE1QVSBiYWNrZ3JvdW5kIGF0dHJpYnV0ZXMgd2lsbCB0
YWtlIGVmZmVjdC4gVGhlIGRlZmF1bHQNCj4gYmFja2dyb3VuZA0KPiA+ICAgICAgICAgIGF0dHJp
YnV0ZXMgYXJlIGBJTVBMRU1FTlRBVElPTiBERUZJTkVEYC4gVGhhdCBtZWFucyBhbGwgUkFNDQo+
IHJlZ2lvbnMNCj4gPiAgICAgICAgICBtYXkgYmUgY29uZmlndXJlZCB0byBkZXZpY2UgbWVtb3J5
IGFuZCBSV1guIFJhbmRvbSB2YWx1ZXMgaW4NCj4gUkFNIG9yDQo+ID4gICAgICAgICAgbWFsaWNp
b3VzbHkgZW1iZWRkZWQgZGF0YSBjYW4gYmUgZXhwbG9pdGVkLg0KPiA+ICAgICAgIDIuIE1vcmUg
Y29tcGF0aWJsZTogT24gc29tZSBBcm12OC1SNjQgcGxhdGZvcm1zLCBpZiBNUFUgaXMNCj4gZGlz
YWJsZWQsDQo+ID4gICAgICAgICAgdGhlIGBkYyB6dmFgIGluc3RydWN0aW9uIHdpbGwgbWFrZSB0
aGUgc3lzdGVtIGhhbHQgKFRoaXMgaXMgb25lDQo+ID4gICAgICAgICAgc2lkZSBlZmZlY3Qgb2Yg
TVBVIGJhY2tncm91bmQgYXR0cmlidXRlcywgdGhlIFJBTSBoYXMgYmVlbg0KPiBjb25maWd1cmVk
DQo+ID4gICAgICAgICAgYXMgZGV2aWNlIG1lbW9yeSkuIEFuZCB0aGlzIGluc3RydWN0aW9uIHdp
bGwgYmUgZW1iZWRkZWQgaW4NCj4gc29tZQ0KPiA+ICAgICAgICAgIGJ1aWx0LWluIGZ1bmN0aW9u
cywgbGlrZSBgbWVtb3J5IHNldGAuIElmIHdlIHVzZSBgLQ0KPiBkZG9udF91c2VfZGNgIHRvDQo+
ID4gICAgICAgICAgcmVidWlsZCBHQ0MsIHRoZSBidWlsdC1pbiBmdW5jdGlvbnMgd2lsbCBub3Qg
Y29udGFpbiBgZGMgenZhYC4NCj4gPiAgICAgICAgICBIb3dldmVyLCBpdCBpcyBvYnZpb3VzbHkg
dW5saWtlbHkgdGhhdCB3ZSB3aWxsIGJlIGFibGUgdG8NCj4gcmVjb21waWxlDQo+ID4gICAgICAg
ICAgYWxsIEdDQyBmb3IgQVJNdjgtUjY0Lg0KPiA+DQo+ID4gICAgIC0gUmV1c2UgYFhFTl9TVEFS
VF9BRERSRVNTYA0KPiA+ICAgICAgIEluIHRoZSB2ZXJ5IGJlZ2lubmluZyBvZiBYZW4gYm9vdCwg
WGVuIGp1c3QgbmVlZCB0byBjb3ZlciBhDQo+IGxpbWl0ZWQNCj4gPiAgICAgICBtZW1vcnkgcmFu
Z2UgYW5kIHZlcnkgZmV3IGRldmljZXMgKGFjdHVhbGx5IG9ubHkgVUFSVCBkZXZpY2UpLiBTbw0K
PiB3ZQ0KPiA+ICAgICAgIGNhbiB1c2UgdHdvIE1QVSByZWdpb25zIHRvIG1hcDoNCj4gPiAgICAg
ICAxLiBgWEVOX1NUQVJUX0FERFJFU1NgIHRvIGBYRU5fU1RBUlRfQUREUkVTUyArIDJNQmAgb3Iu
DQo+ID4gICAgICAgICAgYFhFTl9TVEFSVF9BRERSRVNTYCB0byBgWEVOX1NUQVJUX0FERFJFU1Mg
KyBpbWFnZV9zaXplYGFzDQo+ID4gICAgICAgICAgbm9ybWFsIG1lbW9yeS4NCj4gPiAgICAgICAy
LiBgVUFSVGAgTU1JTyByZWdpb24gYmFzZSB0byBgVUFSVGAgTU1JTyByZWdpb24gZW5kIHRvIGRl
dmljZQ0KPiBtZW1vcnkuDQo+ID4gICAgICAgVGhlc2UgdHdvIGFyZSBlbm91Z2ggdG8gc3VwcG9y
dCBYZW4gcnVuIGluIGJvb3QgdGltZS4gQW5kIHdlIGRvbid0DQo+IG5lZWQNCj4gPiAgICAgICB0
byBwcm92aWRlIGFkZGl0aW9uYWwgcGxhdGZvcm0gaW5mb3JtYXRpb24gZm9yIGluaXRpYWwgbm9y
bWFsDQo+IG1lbW9yeQ0KPiA+ICAgICAgIGFuZCBkZXZpY2UgbWVtb3J5IHJlZ2lvbnMuIEluIGN1
cnJlbnQgUG9DIHdlIGhhdmUgdXNlZCB0aGlzIG9wdGlvbg0KPiA+ICAgICAgIGZvciBpbXBsZW1l
bnRhdGlvbiwgYW5kIGl0J3MgdGhlIHNhbWUgYXMgQXJtdjgtQS4NCj4gPg0KPiA+ICAgICAtIEFk
ZGl0aW9uYWwgcGxhdGZvcm0gaW5mb3JtYXRpb24gZm9yIGluaXRpYWwgTVBVIHN0YXRlDQo+ID4g
ICAgICAgSW50cm9kdWNlIHNvbWUgbWFjcm9zIHRvIGFsbG93IHVzZXJzIHRvIHNldCBpbml0aWFs
IG5vcm1hbA0KPiA+ICAgICAgIG1lbW9yeSByZWdpb25zOg0KPiA+ICAgICAgIGBBUk1fTVBVX05P
Uk1BTF9NRU1PUllfU1RBUlRgIGFuZCBgQVJNX01QVV9OT1JNQUxfTUVNT1JZX0VORGANCj4gPiAg
ICAgICBhbmQgZGV2aWNlIG1lbW9yeToNCj4gPiAgICAgICBgQVJNX01QVV9ERVZJQ0VfTUVNT1JZ
X1NUQVJUYCBhbmQgYEFSTV9NUFVfREVWSUNFX01FTU9SWV9FTkRgDQo+ID4gICAgICAgVGhlc2Ug
bWFjcm9zIGFyZSB0aGUgc2FtZSBwbGF0Zm9ybSBzcGVjaWZpYyBpbmZvcm1hdGlvbiBhcw0KPiA+
ICAgICAgIGBYRU5fU1RBUlRfQUREUkVTU2AsIHNvIHRoZSBvcHRpb25zIzEvIzIvIzMgb2YgZ2Vu
ZXJhdGluZw0KPiA+ICAgICAgIGBYRU5fU1RBUlRfQUREUkVTU2AgYWxzbyBjYW4gYmUgYXBwbGll
ZCB0byB0aGVzZSBtYWNyb3MuDQo+ID4gICAgICAgKioqRnJvbSBvdXIgY3VycmVudCBQb0Mgd29y
aywgd2UgdGhpbmsgdGhlc2UgbWFjcm9zIG1heSoqKg0KPiA+ICAgICAgICoqKm5vdCBiZSBuZWNl
c3NhcnkuIEJ1dCB3ZSBzdGlsbCBwbGFjZSB0aGVtIGhlcmUgdG8gc2VlKioqDQo+ID4gICAgICAg
Kioqd2hldGhlciB0aGUgY29tbXVuaXR5IHdpbGwgaGF2ZSBzb21lIGRpZmZlcmVudCBzY2VuYXJp
b3MqKioNCj4gPiAgICAgICAqKip0aGF0IHdlIGhhdmVuJ3QgY29uc2lkZXJlZC4qKioNCj4gDQo+
IEkgdGhpbmsgaXQgaXMgZmluZSBmb3Igbm93LiBBbmQgdGhlaXIgdmFsdWVzIGNvdWxkIGJlIGF1
dG9tYXRpY2FsbHkNCj4gZ2VuZXJhdGVkIGJ5IHRoZSBzYW1lIHNjcmlwdCB0aGF0IHdpbGwgYXV0
b21hdGljYWxseSBnZW5lcmF0ZQ0KPiBYRU5fU1RBUlRfQUREUkVTUyBmcm9tIHRoZSBob3N0IGRl
dmljZSB0cmVlLg0KPiANCj4gDQo+ID4gLSAqKipEZWZpbmUgbmV3IHN5c3RlbSByZWdpc3RlcnMg
Zm9yIGNvbXBpbGllcnMqKio6DQo+ID4gICBBcm12OC1SNjQgaXMgYmFzZWQgb24gQXJtdjguNC4g
VGhhdCBtZWFucyB3ZSB3aWxsIHVzZSBzb21lIEFybXY4LjQNCj4gPiAgIHNwZWNpZmljIHN5c3Rl
bSByZWdpc3RlcnMuIEFzIEFybXY4LVI2NCBvbmx5IGhhdmUgc2VjdXJlIHN0YXRlLCBzbw0KPiA+
ICAgYXQgbGVhc3QsIGBWU1RDUl9FTDJgIGFuZCBgVlNDVExSX0VMMmAgd2lsbCBiZSB1c2VkIGZv
ciBYZW4uIEFuZCB0aGUNCj4gPiAgIGZpcnN0IEdDQyB2ZXJzaW9uIHRoYXQgc3VwcG9ydHMgQXJt
djguNCBpcyBHQ0MgOC4xLiBJbiBhZGRpdGlvbiB0bw0KPiA+ICAgdGhlc2UsIFBNU0Egb2YgQXJt
djgtUjY0IGludHJvZHVjZWQgbG90cyBvZiBNUFUgcmVsYXRlZCBzeXN0ZW0NCj4gcmVnaXN0ZXJz
Og0KPiA+ICAgYFBSQkFSX0VMeGAsIGBQUkJBUnhfRUx4YCwgYFBSTEFSX0VMeGAsIGBQUkxBUnhf
RUx4YCwgYFBSRU5SX0VMeGAgYW5kDQo+ID4gICBgTVBVSVJfRUx4YC4gQnV0IHRoZSBmaXJzdCBH
Q0MgdmVyc2lvbiB0byBzdXBwb3J0IHRoZXNlIHN5c3RlbQ0KPiByZWdpc3RlcnMNCj4gPiAgIGlz
IEdDQyAxMS4gU28gd2UgaGF2ZSB0d28gd2F5cyB0byBtYWtlIGNvbXBpbGVycyB0byB3b3JrIHBy
b3Blcmx5IHdpdGgNCj4gPiAgIHRoZXNlIHN5c3RlbSByZWdpc3RlcnMuDQo+ID4gICAxLiBCdW1w
IEdDQyB2ZXJzaW9uIHRvIEdDQyAxMS4NCj4gPiAgICAgIFRoZSBwcm9zIG9mIHRoaXMgbWV0aG9k
IGlzIHRoYXQsIHdlIGRvbid0IG5lZWQgdG8gZW5jb2RlIHRoZXNlDQo+ID4gICAgICBzeXN0ZW0g
cmVnaXN0ZXJzIGluIG1hY3JvcyBieSBvdXJzZWx2ZXMuIEJ1dCB0aGUgY29ucyBhcmUgdGhhdCwN
Cj4gPiAgICAgIHdlIGhhdmUgdG8gdXBkYXRlIE1ha2VmaWxlcyB0byBzdXBwb3J0IEdDQyAxMSBm
b3IgQXJtdjgtUjY0Lg0KPiA+ICAgICAgMS4xLiBDaGVjayB0aGUgR0NDIHZlcnNpb24gMTEgZm9y
IEFybXY4LVI2NC4NCj4gPiAgICAgIDEuMi4gQWRkIG1hcmNoPWFybXY4ciB0byBDRkxBR1MgZm9y
IEFybXY4LVI2NC4NCj4gPiAgICAgIDEuMy4gU29sdmUgdGhlIGNvbmZsaWN0aW9uIG9mIG1hcmNo
PWFybXY4ciBhbmQgbWNwdT1nZW5lcmljDQo+ID4gICAgIFRoZXNlIGNoYW5nZXMgd2lsbCBhZmZl
Y3QgY29tbW9uIE1ha2VmaWxlcywgbm90IG9ubHkgQXJtIE1ha2VmaWxlcy4NCj4gPiAgICAgQW5k
IEdDQyAxMSBpcyBuZXcsIGxvdHMgb2YgdG9vbGNoYWlucyBhbmQgRGlzdHJvIGhhdmVuJ3Qgc3Vw
cG9ydGVkDQo+IGl0Lg0KPiA+DQo+ID4gICAyLiBFbmNvZGUgbmV3IHN5c3RlbSByZWdpc3RlcnMg
aW4gbWFjcm9zICoqKihwcmVmZXJyZWQpKioqDQo+ID4gICAgICAgICBgYGANCj4gPiAgICAgICAg
IC8qIFZpcnR1YWxpemF0aW9uIFNlY3VyZSBUcmFuc2xhdGlvbiBDb250cm9sIFJlZ2lzdGVyICov
DQo+ID4gICAgICAgICAjZGVmaW5lIFZTVENSX0VMMiAgUzNfNF9DMl9DNl8yDQo+ID4gICAgICAg
ICAvKiBWaXJ0dWFsaXphdGlvbiBTeXN0ZW0gQ29udHJvbCBSZWdpc3RlciAqLw0KPiA+ICAgICAg
ICAgI2RlZmluZSBWU0NUTFJfRUwyIFMzXzRfQzJfQzBfMA0KPiA+ICAgICAgICAgLyogRUwxIE1Q
VSBQcm90ZWN0aW9uIFJlZ2lvbiBCYXNlIEFkZHJlc3MgUmVnaXN0ZXIgZW5jb2RlICovDQo+ID4g
ICAgICAgICAjZGVmaW5lIFBSQkFSX0VMMSAgUzNfMF9DNl9DOF8wDQo+ID4gICAgICAgICAuLi4N
Cj4gPiAgICAgICAgIC8qIEVMMiBNUFUgUHJvdGVjdGlvbiBSZWdpb24gQmFzZSBBZGRyZXNzIFJl
Z2lzdGVyIGVuY29kZSAqLw0KPiA+ICAgICAgICAgI2RlZmluZSBQUkJBUl9FTDIgIFMzXzRfQzZf
QzhfMA0KPiA+ICAgICAgICAgLi4uDQo+ID4gICAgICAgICBgYGANCj4gPiAgICAgIElmIHdlIGVu
Y29kZSBhbGwgYWJvdmUgc3lzdGVtIHJlZ2lzdGVycywgd2UgZG9uJ3QgbmVlZCB0byBidW1wIEdD
Qw0KPiA+ICAgICAgdmVyc2lvbi4gQW5kIHRoZSBjb21tb24gQ0ZMQUdTIFhlbiBpcyB1c2luZyBz
dGlsbCBjYW4gYmUgYXBwbGllZCB0bw0KPiA+ICAgICAgQXJtdjgtUjY0LiBXZSBkb24ndCBuZWVk
IHRvIG1vZGlmeSBNYWtlZmlsZXMgdG8gYWRkIHNwZWNpZmljIENGTEFHUy4NCj4gPiAgICAgICoq
Kk5vdGVzOioqKg0KPiA+ICAgICAgKioqQXJtdjgtUiBBQXJjaDY0IHN1cHBvcnRzIHRoZSBBNjQg
SVNBIGluc3RydWN0aW9uIHNldCB3aXRoKioqDQo+ID4gICAgICAqKipzb21lIG1vZGlmaWNhdGlv
bnM6KioqDQo+ID4gICAgICAqKipSZWRlZmluZXMgRE1CLCBEU0IsIGFuZCBhZGRzIGFuIERGQi4g
QnV0IGFjdHVhbGx5LCB0aGUqKioNCj4gPiAgICAgICoqKmVuY29kaW5ncyBvZiBETUIgYW5kIERT
QiBhcmUgc3RpbGwgdGhlIHNhbWUgd2l0aCBBNjQuKioqDQo+ID4gICAgICAqKipBbmQgREZCIGlz
IGFuIGFsaWFzIG9mIERTQiAjMTIuIEluIHRoaXMgY2FzZSwgd2UgdGhpbmsqKioNCj4gPiAgICAg
ICoqKndlIGRvbid0IG5lZWQgYSBuZXcgYXJjaGl0ZWN0dXJlIHNwZWNpZmljIGZsYWcgdG8qKioN
Cj4gPiAgICAgICoqKmdlbmVyYXRlIG5ldyBpbnN0cnVjdGlvbnMgZm9yIEFybXY4LVIuKioqDQo+
IA0KPiBJIHRoaW5rIHRoYXQgZm9yIHRoZSBpbml0aWFsIGltcGxlbWVudGF0aW9uIGVpdGhlciB3
YXkgaXMgZmluZS4gSSBhZ3JlZQ0KPiB0aGF0IG1hY3JvcyB3b3VsZCBiZSBiZXR0ZXIgdGhhbiBy
ZXF1aXJpbmcgR0NDIDExLg0KPiANCj4gDQo+ID4gIyMjICoqMi4yLiBDaGFuZ2VzIG9mIHRoZSBp
bml0aWFsaXphdGlvbiBwcm9jZXNzKioNCj4gPiBJbiBnZW5lcmFsLCB3ZSBzdGlsbCBleHBlY3Qg
QXJtdjgtUjY0IGFuZCBBcm12OC1BNjQgdG8gaGF2ZSBhIGNvbnNpc3RlbnQNCj4gPiBpbml0aWFs
aXphdGlvbiBwcm9jZXNzLiBJbiBhZGRpdGlvbiB0byBzb21lIGFyY2hpdGVjdXRyZSBkaWZmZXJl
bmNlcywNCj4gdGhlcmUNCj4gPiBpcyBubyBtb3JlIHRoYW4gcmV1c2FibGUgY29kZSB0aGF0IHdl
IHdpbGwgZGlzdGluZ3Vpc2ggdGhyb3VnaA0KPiBDT05GSUdfQVJNX01QVQ0KPiA+IG9yIENPTkZJ
R19BUk02NF9WOFIuIFdlIHdhbnQgbW9zdCBvZiB0aGUgaW5pdGlhbGl6YXRpb24gY29kZSB0byBi
ZQ0KPiByZXVzYWJsZQ0KPiA+IGJldHdlZW4gQXJtdjgtUjY0IGFuZCBBcm12OC1BNjQuDQo+ID4N
Cj4gPiAtIFdlIHdpbGwgcmV1c2UgdGhlIG9yaWdpbmFsIGhlYWQucyBhbmQgc2V0dXAuYyBvZiBB
cm0uIEJ1dCByZXBsYWNlIHRoZQ0KPiA+ICAgTU1VIGFuZCBwYWdlIHRhYmxlIG9wZXJhdGlvbnMg
aW4gdGhlc2UgZmlsZXMgd2l0aCBjb25maWd1cmF0aW9uDQo+IG9wZXJhdGlvbnMNCj4gPiAgIGZv
ciBNUFUgYW5kIE1QVSByZWdpb25zLg0KPiA+DQo+ID4gLSBXZSBwcm92aWRlIGEgYm9vdC10aW1l
IE1QVSBjb25maWd1cmF0aW9uLiBUaGlzIE1QVSBjb25maWd1cmF0aW9uIHdpbGwNCj4gPiAgIHN1
cHBvcnQgWGVuIHRvIGZpbmlzaCBpdHMgaW5pdGlhbGl6YXRpb24uIEFuZCB0aGlzIGJvb3QtdGlt
ZSBNUFUNCj4gPiAgIGNvbmZpZ3VyYXRpb24gd2lsbCByZWNvcmQgdGhlIG1lbW9yeSByZWdpb25z
IHRoYXQgd2lsbCBiZSBwYXJzZWQgZnJvbQ0KPiA+ICAgZGV2aWNlIHRyZWUuDQo+ID4NCj4gPiAg
IEluIHRoZSBlbmQgb2YgWGVuIGluaXRpYWxpemF0aW9uLCB3ZSB3aWxsIHVzZSBhIHJ1bnRpbWUg
TVBVDQo+IGNvbmZpZ3VyYXRpb24NCj4gPiAgIHRvIHJlcGxhY2UgYm9vdC10aW1lIE1QVSBjb25m
aWd1cmF0aW9uLiBUaGUgcnVudGltZSBNUFUgY29uZmlndXJhdGlvbg0KPiB3aWxsDQo+ID4gICBt
ZXJnZSBhbmQgcmVvcmRlciBtZW1vcnkgcmVnaW9ucyB0byBzYXZlIG1vcmUgTVBVIHJlZ2lvbnMg
Zm9yIGd1ZXN0cy4NCj4gPiAgICFbaW1nXShodHRwczovL2RyaXZlLmdvb2dsZS5jb20vdWM/ZXhw
b3J0PXZpZXcmaWQ9MXdURnlLMlhmVTNsVGxIMVBxUkQNCj4gb2FjUVZUd1V0V0lHVSkNCj4gPg0K
PiA+IC0gRGVmZXIgc3lzdGVtIHVucGF1c2luZyBkb21haW4gYWZ0ZXIgZnJlZV9pbml0X21lbW9y
eS4NCj4gPiAgIFdoZW4gWGVuIGluaXRpYWxpemF0aW9uIGlzIGFib3V0IHRvIGVuZCwgWGVuIHVu
cGF1c2VzIGd1ZXN0cyBjcmVhdGVkDQo+ID4gICBkdXJpbmcgaW5pdGlhbGl6YXRpb24uIEJ1dCB0
aGlzIHdpbGwgY2F1c2Ugc29tZSBpc3N1ZXMuIFRoZSB1bnBhdXNlDQo+ID4gICBhY3Rpb24gb2Nj
dXJzIGJlZm9yZSBmcmVlX2luaXRfbWVtb3J5LCBob3dldmVyIHRoZSBydW50aW1lIE1QVQ0KPiA+
ICAgY29uZmlndXJhdGlvbiBpcyBidWlsdCBhZnRlciBmcmVlX2luaXRfbWVtb3J5LiBJbiBEcmFm
dC1BLCB3ZSBoYWQNCj4gPiAgIGRpc2N1c3NlZCB3aGV0aGVyIGEgemVyb2luZyBvcGVyYXRpb24g
Zm9yIGluaXQgY29kZSBhbmQgZGF0YSBpcw0KPiA+ICAgZW5vdWdoIG9yIG5vdC4gQmVjYXVzZSBJ
IGhhZCBqdXN0IGdpdmVuIGEgc2VjdXJpdHkgcmVhc29uIGZvciBkb2luZw0KPiA+ICAgZnJlZV9p
bml0X21lbW9yeSBvbiBBcm12OC1SIChmcmVlX2luaXRfbWVtb3J5IHdpbGwgZHJvcCB0aGUgWGVu
IGluaXQNCj4gPiAgIGNvZGUgJiBkYXRhLCB0aGlzIHdpbGwgcmVkdWNlIHRoZSBjb2RlIGFuIGF0
dGFja2VyIGNhbiBleHBsb2l0KS4NCj4gPiAgIEJ1dCBJIGZvcmdvdCBvdGhlciB2ZXJ5IGltcG9y
dGFudCByZWFzb25zOg0KPiA+ICAgMS4gSW5pdCBjb2RlIGFuZCBkYXRhIHdpbGwgb2NjdXB5IHR3
byBNUFUgcmVnaW9ucywgYmVjYXVzZSB0aGV5DQo+ID4gICAgICBoYXZlIGRpZmZlcmVudCBtZW1v
cnkgYXR0cmlidXRlcy4NCj4gPiAgIDIuIEl0J3Mgbm90IGVhc3kgdG8gemVybyBpbml0IGNvZGUg
c2VjdGlvbiwgYmVjYXVzZSBpdCdzIHJlYWRvbmx5Lg0KPiA+ICAgICAgV2UgaGF2ZSB0byB1cGRh
dGUgaXRzIE1QVSByZWdpb24gdG8gbWFrZSB0aGlzIHNlY3Rpb24gUlcuIFRoaXMNCj4gPiAgICAg
IG9wZXJhdGlvbiBkb2Vzbid0IGRvIG11Y2ggbGVzcyB0aGFuIGZyZWVfaW5pdF9tZW1vcnkuDQo+
ID4gICAzLiBaZXJvaW5nIGluaXQgY29kZSBhbmQgZGF0YSB3aWxsIG5vdCByZWxlYXNlIHRoZSB0
d28gTVBVIHJlZ2lvbnMNCj4gPiAgICAgIHRoZXkgYXJlIHVzaW5nLiBUaGlzIHdvdWxkIGJlIGEg
dmVyeSBiaWcgd2FzdGUgb2YgYSBsaW1pdGVkIE1QVQ0KPiA+ICAgICAgcmVnaW9ucyByZXNvdXJj
ZS4NCj4gPiAgIDQuIEN1cnJlbnQgZnJlZV9pbml0X21lbW9yeSBvcGVyYXRpb24gaXMgcmV1c2lu
ZyBsb3RzIG9mIEFybXY4LUENCj4gPiAgICAgIGNvZGVzLCBleGNlcHQgcmUtYWRkIGluaXQgbWVt
b3J5IHRvIFhlbiBoZWFwLiBCZWN1YXNlIHdlJ3JlIHVzaW5nDQo+ID4gICAgICBzdGF0aWMgaGVh
cCBvbiBBcm12OC1SLg0KPiA+DQo+ID4gICBTbyBpZiB0aGUgdW5wYXVzZWQgZ3Vlc3RzIHN0YXJ0
IGV4ZWN1dGluZyB0aGUgY29udGV4dCBzd2l0Y2ggYXQgdGhpcw0KPiA+ICAgcG9pbnQsIHRoZW4g
aXRzIE1QVSBjb250ZXh0IHdpbGwgYmFzZSBvbiB0aGUgYm9vdC10aW1lIE1QVQ0KPiBjb25maWd1
cmF0aW9uLg0KPiA+ICAgUHJvYmFibHkgaXQgd2lsbCBiZSBpbmNvbnNpc3RlbnQgd2l0aCBydW50
aW1lIE1QVSBjb25maWd1cmF0aW9uLCB0aGlzDQo+ID4gICB3aWxsIGNhdXNlIHVuZXhwZWN0ZWQg
cHJvYmxlbXMgKFRoaXMgbWF5IG5vdCBoYXBwZW4gaW4gYSBzaW5nbGUgY29yZQ0KPiA+ICAgc3lz
dGVtLCBidXQgb24gU01QIHN5c3RlbXMsIHRoaXMgcHJvYmxlbSBpcyBmb3JzZWVhYmxlLCBzbyB3
ZSBob3BlIHRvDQo+ID4gICBzb2x2ZSBpdCBhdCB0aGUgYmVnaW5uaW5nKS4NCj4gPg0KPiA+ICAg
V2h5IHdlIG5lZWQgdG8gc3dpdGNoIHRoZSBNUFUgY29uZmlndXJhdGlvbiB0aGF0IGxhdGU/DQo+
ID4gICBCZWNhdXNlIHdlIG5lZWQgdG8gcmUtb3JkZXIgdGhlIE1QVSByZWdpb25zIHRvIHJlZHVj
ZSBjb21wbGV4aXR5IG9mDQo+IHJ1bnRpbWUNCj4gPiAgIE1QVSByZWdpb25zIG1hbmFnZW1lbnQu
DQo+ID4gICAxLiBJbiB0aGUgYm9vdCBzdGFnZSwgd2UgYWxsb2NhdGUgTVBVIHJlZ2lvbnMgaW4g
c2VxdWVuY2UgdW50aWwgdGhlDQo+IG1heC4NCj4gPiAgICAgIFNpbmNlIGEgZmV3IE1QVSByZWdp
b25zIHdpbGwgZ2V0IHJlbW92ZWQgYWxvbmcgdGhlIHdheSwgdGhleSB3aWxsDQo+IGxlYXZlDQo+
ID4gICAgICBob2xlcyB0aGVyZS4gRm9yIGV4YW1wbGUsIHdoZW4gaGVhcCBpcyByZWFkeSwgZmR0
IHdpbGwgYmUNCj4gcmVhbGxvY2F0ZWQNCj4gPiAgICAgIGluIHRoZSBoZWFwLCB3aGljaCBtZWFu
cyB0aGUgTVBVIHJlZ2lvbiBmb3IgZGV2aWNlIHRyZWUgaXMgbmV2ZXINCj4gbmVlZGVkLg0KPiA+
ICAgICAgQW5kIGFsc28gaW4gZnJlZV9pbml0X21lbW9yeSwgYWx0aG91Z2ggd2UgZG8gbm90IGFk
ZCBpbml0IG1lbW9yeSB0bw0KPiBoZWFwLA0KPiA+ICAgICAgd2Ugc3RpbGwgcmVjbGFpbSB0aGUg
TVBVIHJlZ2lvbnMgdGhleSBhcmUgdXNpbmcuIFdpdGhvdXQgb3JkZXJpbmcsDQo+IHdlDQo+ID4g
ICAgICBtYXkgbmVlZCBhIGJpdG1hcCB0byByZWNvcmQgc3VjaCBpbmZvcm1hdGlvbi4NCj4gPg0K
PiA+ICAgICAgSW4gY29udGV4dCBzd2l0Y2gsIHRoZSBtZW1vcnkgbGF5b3V0IGlzIHF1aXRlIGRp
ZmZlcmVudCBmb3IgZ3Vlc3QNCj4gbW9kZQ0KPiA+ICAgICAgYW5kIGh5cGVydmlzb3IgbW9kZS4g
V2hlbiBzd2l0Y2hpbmcgdG8gZ3Vlc3QgbW9kZSwgb25seSBndWVzdCBSQU0sDQo+ID4gICAgICBl
bXVsYXRlZC9wYXNzdGhyb3VnaCBkZXZpY2VzLCBldGMgY291bGQgYmUgc2VlbiwgYnV0IGluIGh5
cGVydmlzb3INCj4gbW9kZSwNCj4gPiAgICAgIGFsbCBYZW4gdXNlZCBkZXZpY2VzIGFuZCBndWVz
dHMgUkFNIHNoYWxsIGJlIHNlZW4uIEFuZCB3aXRob3V0DQo+IHJlb3JkZXJpbmcsDQo+ID4gICAg
ICB3ZSBuZWVkIHRvIGl0ZXJhdGUgYWxsIE1QVSByZWdpb25zIHRvIGZpbmQgYWNjb3JkaW5nIHJl
Z2lvbnMgdG8NCj4gZGlzYWJsZQ0KPiA+ICAgICAgZHVyaW5nIHJ1bnRpbWUgY29udGV4dCBzd2l0
Y2gsIHRoYXQncyBkZWZpbml0ZWx5IGEgb3ZlcmhlYWQuDQo+ID4NCj4gPiAgICAgIFNvIHdlIHBy
b3Bvc2UgYW4gb3JkZXJpbmcgYXQgdGhlIHRhaWwgb2YgdGhlIGJvb3QgdGltZSwgdG8gcHV0IGFs
bA0KPiBmaXhlZA0KPiA+ICAgICAgTVBVIHJlZ2lvbnMgaW4gdGhlIGhlYWQsIGxpa2UgeGVuIHRl
eHQvZGF0YSwgZXRjLCBhbmQgcHV0IGFsbA0KPiBmbGV4aWJsZQ0KPiA+ICAgICAgb25lcyBhdCB0
YWlsLCBsaWtlIGRldmljZSBtZW1vcnksIGd1ZXN0cyBSQU0uDQo+ID4NCj4gPiAgICAgIFRoZW4g
bGF0ZXIgaW4gcnVudGltZSwgbGlrZSBjb250ZXh0IHN3aXRjaCwgd2UgY291bGQgZWFzaWx5IGp1
c3QNCj4gZGlzYWJsZQ0KPiA+ICAgICAgb25lcyBmcm9tIHRhaWwgYW5kIGluc2VydHMgbmV3IG9u
ZXMgaW4gdGhlIHRhaWwuDQo+ID4NCj4gPiAjIyMgKioyLjMuIENoYW5nZXMgdG8gcmVkdWNlIG1l
bW9yeSBmcmFnbWVudGF0aW9uKioNCj4gPg0KPiA+IEluIGdlbmVyYWwsIG1lbW9yeSBpbiBYZW4g
c3lzdGVtIGNhbiBiZSBjbGFzc2lmaWVkIHRvIDQgY2xhc3NlczoNCj4gPiBgaW1hZ2Ugc2VjdGlv
bnNgLCBgaGVhcCBzZWN0aW9uc2AsIGBndWVzdCBSQU1gLCBgYm9vdCBtb2R1bGVzIChndWVzdA0K
PiBLZXJuZWwsDQo+ID4gaW5pdHJkIGFuZCBkdGIpYA0KPiA+DQo+ID4gQ3VycmVudGx5LCBYZW4g
ZG9lc24ndCBoYXZlIGFueSByZXN0cmljdGlvbiBmb3IgdXNlcnMgaG93IHRvIGFsbG9jYXRlDQo+
ID4gbWVtb3J5IGZvciBkaWZmZXJlbnQgY2xhc3Nlcy4gVGhhdCBtZWFucyB1c2VycyBjYW4gcGxh
Y2UgYm9vdCBtb2R1bGVzDQo+ID4gYW55d2hlcmUsIGNhbiByZXNlcnZlIFhlbiBoZWFwIG1lbW9y
eSBhbnl3aGVyZSBhbmQgY2FuIGFsbG9jYXRlIGd1ZXN0DQo+ID4gbWVtb3J5IGFueXdoZXJlLg0K
PiA+DQo+ID4gSW4gYSBWTVNBIHN5c3RlbSwgdGhpcyB3b3VsZCBub3QgYmUgdG9vIG11Y2ggb2Yg
YSBwcm9ibGVtLCBzaW5jZSB0aGUNCj4gPiBNTVUgY2FuIG1hbmFnZSBtZW1vcnkgYXQgYSBncmFu
dWxhcml0eSBvZiA0S0IgYWZ0ZXIgYWxsLiBCdXQgaW4gYQ0KPiA+IFBNU0Egc3lzdGVtLCB0aGlz
IHdpbGwgYmUgYSBiaWcgcHJvYmxlbS4gT24gQXJtdjgtUjY0LCB0aGUgbWF4IE1QVQ0KPiA+IHBy
b3RlY3Rpb24gcmVnaW9ucyBudW1iZXIgaGFzIGJlZW4gbGltaXRlZCB0byAyNTYuIEJ1dCBpbiB0
eXBpY2FsDQo+ID4gcHJvY2Vzc29yIGltcGxlbWVudGF0aW9ucywgZmV3IHByb2Nlc3NvcnMgd2ls
bCBkZXNpZ24gbW9yZSB0aGFuIDMyDQo+ID4gTVBVIHByb3RlY3Rpb24gcmVnaW9ucy4gQWRkIGlu
IHRoZSBmYWN0IHRoYXQgWGVuIHNoYXJlcyBNUFUgcHJvdGVjdGlvbg0KPiA+IHJlZ2lvbnMgd2l0
aCBndWVzdCdzIEVMMSBTdGFnZSAyLiBJdCBiZWNvbWVzIGV2ZW4gbW9yZSBpbXBvcnRhbnQNCj4g
PiB0byBwcm9wZXJseSBwbGFuIHRoZSB1c2Ugb2YgTVBVIHByb3RlY3Rpb24gcmVnaW9ucy4NCj4g
Pg0KPiA+IC0gQW4gaWRlYWwgb2YgbWVtb3J5IHVzYWdlIGxheW91dCByZXN0cmljdGlvbjoNCj4g
PiAhW2ltZ10oaHR0cHM6Ly9kcml2ZS5nb29nbGUuY29tL3VjP2V4cG9ydD12aWV3JmlkPTFraXJP
TDBUeDJhQXlwVHRkM2tYQXQNCj4gZDc1WHRybmdjblcpDQo+ID4gMS4gUmVzZXJ2ZSBwcm9wZXIg
TVBVIHJlZ2lvbnMgZm9yIFhlbiBpbWFnZSAoY29kZSwgcm9kYXRhIGFuZCBkYXRhICsNCj4gYnNz
KS4NCj4gPiAyLiBSZXNlcnZlIG9uZSBNUFUgcmVnaW9uIGZvciBib290IG1vZHVsZXMuDQo+ID4g
ICAgVGhhdCBtZWFucyB0aGUgcGxhY2VtZW50IG9mIGFsbCBib290IG1vZHVsZXMsIGluY2x1ZGUg
Z3Vlc3Qga2VybmVsLA0KPiA+ICAgIGluaXRyZCBhbmQgZHRiLCB3aWxsIGJlIGxpbWl0ZWQgdG8g
dGhpcyBNUFUgcmVnaW9uIHByb3RlY3RlZCBhcmVhLg0KPiA+IDMuIFJlc2VydmUgb25lIG9yIG1v
cmUgTVBVIHJlZ2lvbnMgZm9yIFhlbiBoZWFwLg0KPiA+ICAgIE9uIEFybXY4LVI2NCwgdGhlIGd1
ZXN0IG1lbW9yeSBpcyBwcmVkZWZpbmVkIGluIGRldmljZSB0cmVlLCBpdCB3aWxsDQo+ID4gICAg
bm90IGJlIGFsbG9jYXRlZCBmcm9tIGhlYXAuIFVubGlrZSBBcm12OC1BNjQsIHdlIHdpbGwgbm90
IG1vdmUgYWxsDQo+ID4gICAgZnJlZSBtZW1vcnkgdG8gaGVhcC4gV2Ugd2FudCBYZW4gaGVhcCBp
cyBkZXJ0ZXJtaXN0aWMgdG9vLCBzbyBYZW4gb24NCj4gPiAgICBBcm12OC1SNjQgYWxzbyByZWx5
IG9uIFhlbiBzdGF0aWMgaGVhcCBmZWF0dXJlLiBUaGUgbWVtb3J5IGZvciBYZW4NCj4gPiAgICBo
ZWFwIHdpbGwgYmUgZGVmaW5lZCBpbiB0cmVlIHRvby4gQ29uc2lkZXJpbmcgdGhhdCBwaHlzaWNh
bCBtZW1vcnkNCj4gPiAgICBjYW4gYWxzbyBiZSBkaXNjb250aW51b3VzLCBvbmUgb3IgbW9yZSBN
UFUgcHJvdGVjdGlvbiByZWdpb25zIG5lZWRzDQo+ID4gICAgdG8gYmUgcmVzZXJ2ZWQgZm9yIFhl
biBIRUFQLg0KPiA+IDQuIElmIHdlIG5hbWUgYWJvdmUgdXNlZCBNUFUgcHJvdGVjdGlvbiByZWdp
b25zIFBBUlRfQSwgYW5kIG5hbWUgbGVmdA0KPiA+ICAgIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMg
UEFSVF9COg0KPiA+ICAgIDQuMS4gSW4gaHlwZXJ2aXNvciBjb250ZXh0LCBYZW4gd2lsbCBtYXAg
bGVmdCBSQU0gYW5kIGRldmljZXMgdG8NCj4gUEFSVF9CLg0KPiA+ICAgICAgICAgVGhpcyB3aWxs
IGdpdmUgWGVuIHRoZSBhYmlsaXR5IHRvIGFjY2VzcyB3aG9sZSBtZW1vcnkuDQo+ID4gICAgNC4y
LiBJbiBndWVzdCBjb250ZXh0LCBYZW4gd2lsbCBjcmVhdGUgRUwxIHN0YWdlIDIgbWFwcGluZyBp
biBQQVJUX0IuDQo+ID4gICAgICAgICBJbiB0aGlzIGNhc2UsIFhlbiBqdXN0IG5lZWQgdG8gdXBk
YXRlIFBBUlRfQiBpbiBjb250ZXh0IHN3aXRjaCwNCj4gPiAgICAgICAgIGJ1dCBrZWVwIFBBUlRf
QSBhcyBmaXhlZC4NCj4gPg0KPiA+ICoqKk5vdGVzOiBTdGF0aWMgYWxsb2NhdGlvbiB3aWxsIGJl
IG1hbmRhdG9yeSBvbiBNUFUgYmFzZWQgc3lzdGVtcyoqKg0KPiA+DQo+ID4gKipBIHNhbXBsZSBk
ZXZpY2UgdHJlZSBvZiBtZW1vcnkgbGF5b3V0IHJlc3RyaWN0aW9uKio6DQo+ID4gYGBgDQo+ID4g
Y2hvc2VuIHsNCj4gPiAgICAgLi4uDQo+ID4gICAgIC8qDQo+ID4gICAgICAqIERlZmluZSBhIHNl
Y3Rpb24gdG8gcGxhY2UgYm9vdCBtb2R1bGVzLA0KPiA+ICAgICAgKiBhbGwgYm9vdCBtb2R1bGVz
IG11c3QgYmUgcGxhY2VkIGluIHRoaXMgc2VjdGlvbi4NCj4gPiAgICAgICovDQo+ID4gICAgIG1w
dSxib290LW1vZHVsZS1zZWN0aW9uID0gPDB4MTAwMDAwMDAgMHgxMDAwMDAwMD47DQo+ID4gICAg
IC8qDQo+ID4gICAgICAqIERlZmluZSBhIHNlY3Rpb24gdG8gY292ZXIgYWxsIGd1ZXN0IFJBTS4g
QWxsIGd1ZXN0IFJBTSBtdXN0IGJlDQo+IGxvY2F0ZWQNCj4gPiAgICAgICogd2l0aGluIHRoaXMg
c2VjdGlvbi4gVGhlIHByb3MgaXMgdGhhdCwgaW4gYmVzdCBjYXNlLCB3ZSBjYW4gb25seQ0KPiBo
YXZlDQo+ID4gICAgICAqIG9uZSBNUFUgcHJvdGVjdGlvbiByZWdpb24gdG8gbWFwIGFsbCBndWVz
dCBSQU0gZm9yIFhlbi4NCj4gPiAgICAgICovDQo+ID4gICAgIG1wdSxndWVzdC1tZW1vcnktc2Vj
dGlvbiA9IDwweDIwMDAwMDAwIDB4MzAwMDAwMDA+Ow0KPiA+ICAgICAvKg0KPiA+ICAgICAgKiBE
ZWZpbmUgYSBtZW1vcnkgc2VjdGlvbiB0aGF0IGNhbiBjb3ZlciBhbGwgZGV2aWNlIG1lbW9yeSB0
aGF0DQo+ID4gICAgICAqIHdpbGwgYmUgdXNlZCBpbiBYZW4uDQo+ID4gICAgICAqLw0KPiA+ICAg
ICBtcHUsZGV2aWNlLW1lbW9yeS1zZWN0aW9uID0gPDB4ODAwMDAwMDAgMHg3ZmZmZjAwMD47DQo+
ID4gICAgIC8qIERlZmluZSBhIHNlY3Rpb24gZm9yIFhlbiBoZWFwICovDQo+ID4gICAgIHhlbixz
dGF0aWMtbWVtID0gPDB4NTAwMDAwMDAgMHgyMDAwMDAwMD47DQo+ID4NCj4gPiAgICAgZG9tVTEg
ew0KPiA+ICAgICAgICAgLi4uDQo+ID4gICAgICAgICAjeGVuLHN0YXRpYy1tZW0tYWRkcmVzcy1j
ZWxscyA9IDwweDAxPjsNCj4gPiAgICAgICAgICN4ZW4sc3RhdGljLW1lbS1zaXplLWNlbGxzID0g
PDB4MDE+Ow0KPiA+ICAgICAgICAgLyogU3RhdGljYWxseSBhbGxvY2F0ZWQgZ3Vlc3QgbWVtb3J5
LCB3aXRoaW4gbXB1LGd1ZXN0LW1lbW9yeS0NCj4gc2VjdGlvbiAqLw0KPiA+ICAgICAgICAgeGVu
LHN0YXRpYy1tZW0gPSA8MHgzMDAwMDAwMCAweDFmMDAwMDAwPjsNCj4gPg0KPiA+ICAgICAgICAg
bW9kdWxlQDExMDAwMDAwIHsNCj4gPiAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm11bHRpYm9v
dCxrZXJuZWxcMG11bHRpYm9vdCxtb2R1bGUiOw0KPiA+ICAgICAgICAgICAgIC8qIEJvb3QgbW9k
dWxlIGFkZHJlc3MsIHdpdGhpbiBtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbiAqLw0KPiA+ICAgICAg
ICAgICAgIHJlZyA9IDwweDExMDAwMDAwIDB4MzAwMDAwMD47DQo+ID4gICAgICAgICAgICAgLi4u
DQo+ID4gICAgICAgICB9Ow0KPiA+DQo+ID4gICAgICAgICBtb2R1bGVAMTBGRjAwMDAgew0KPiA+
ICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm11bHRpYm9vdCxkZXZpY2UtdHJlZVwwbXVs
dGlib290LG1vZHVsZSI7DQo+ID4gICAgICAgICAgICAgICAgIC8qIEJvb3QgbW9kdWxlIGFkZHJl
c3MsIHdpdGhpbiBtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbg0KPiAqLw0KPiA+ICAgICAgICAgICAg
ICAgICByZWcgPSA8MHgxMGZmMDAwMCAweDEwMDAwPjsNCj4gPiAgICAgICAgICAgICAgICAgLi4u
DQo+ID4gICAgICAgICB9Ow0KPiA+ICAgICB9Ow0KPiA+IH07DQo+ID4gYGBgDQo+ID4gSXQncyBs
aXR0bGUgaGFyZCBmb3IgdXNlcnMgdG8gY29tcG9zZSBzdWNoIGEgZGV2aWNlIHRyZWUgYnkgaGFu
ZC4gQmFzZWQNCj4gPiBvbiB0aGUgZGlzY3Vzc2lvbiBvZiBEcmFmdC1BLCBYZW4gY29tbXVuaXR5
IHN1Z2dlc3RlZCB1c2VycyB0byB1c2Ugc29tZQ0KPiA+IHRvb2xzIGxpa2UgW2ltYWdlYnVpbGRl
cl0oaHR0cHM6Ly9naXRsYWIuY29tL1ZpcnlhT1MvaW1hZ2VidWlsZGVyLy0NCj4gL2Jsb2IvbWFz
dGVyL3NjcmlwdHMvdWJvb3Qtc2NyaXB0LWdlbiNMMzkwKSB0byBnZW5lcmF0ZSB0aGUgYWJvdmUg
ZGV2aWNlDQo+IHRyZWUgcHJvcGVydGllcy4NCj4gPiBQbGVhc2UgZ290byBUT0RPIzMuMyBzZWN0
aW9uIHRvIGdldCBtb3JlIGRldGFpbHMgb2YgdGhpcyBzdWdnZXN0aW9uLg0KPiANCj4gWWVzLCBJ
IHRoaW5rIHdlJ2xsIG5lZWQgYW4gSW1hZ2VCdWlsZGVyIHNjcmlwdCB0byBwb3B1bGF0ZSB0aGVz
ZSBlbnRyaWVzDQo+IGF1dG9tYXRpY2FsbHkuIFdpdGggR2VvcmdlJ3MgaGVscCwgSSBtb3ZlZCBJ
bWFnZUJ1aWxkZXIgdG8gWGVuIFByb2plY3QuDQo+IFRoaXMgaXMgdGhlIG5ldyByZXBvc2l0b3J5
OiBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvaW1hZ2VidWlsZGVyDQo+IA0KPiBUaGUg
c2NyaXB0IHRvIGdlbmVyYXRlIG1wdSxib290LW1vZHVsZS1zZWN0aW9uIGFuZCB0aGUgb3RoZXIg
bXB1DQo+IGFkZHJlc3NlcyBjb3VsZCBiZSB0aGUgc2FtZSBJbWFnZUJ1aWxkZXIgc2NyaXB0IHRo
YXQgZ2VuZXJhdGVzIGFsc28NCj4gWEVOX1NUQVJUX0FERFJFU1MuDQo+IA0KPiANCj4gPiAjIyMg
KioyLjQuIENoYW5nZXMgb2YgbWVtb3J5IG1hbmFnZW1lbnQqKg0KPiA+IFhlbiBpcyBjb3VwbGVk
IHdpdGggVk1TQSwgaW4gb3JkZXIgdG8gcG9ydCBYZW4gdG8gQXJtdjgtUjY0LCB3ZSBoYXZlIHRv
DQo+ID4gZGVjb3VwbGUgWGVuIGZyb20gVk1TQS4gQW5kIGdpdmUgWGVuIHRoZSBhYmxpdHkgdG8g
bWFuYWdlIG1lbW9yeSBpbiBQTVNBLg0KPiA+DQo+ID4gMS4gKioqVXNlIGJ1ZGR5IGFsbG9jYXRv
ciB0byBtYW5hZ2UgcGh5c2ljYWwgcGFnZXMgZm9yIFBNU0EqKioNCj4gPiAgICBGcm9tIHRoZSB2
aWV3IG9mIHBoeXNpY2FsIHBhZ2UsIFBNU0EgYW5kIFZNU0EgZG9uJ3QgaGF2ZSBhbnkNCj4gZGlm
ZmVyZW5jZS4NCj4gPiAgICBTbyB3ZSBjYW4gcmV1c2UgYnVkZHkgYWxsb2NhdG9yIG9uIEFybXY4
LVI2NCB0byBtYW5hZ2UgcGh5c2ljYWwgcGFnZXMuDQo+ID4gICAgVGhlIGRpZmZlcmVuY2UgaXMg
dGhhdCwgaW4gVk1TQSwgWGVuIHdpbGwgbWFwIGFsbG9jYXRlZCBwYWdlcyB0bw0KPiB2aXJ0dWFs
DQo+ID4gICAgYWRkcmVzc2VzLiBCdXQgaW4gUE1TQSwgWGVuIGp1c3QgY29udmVydCB0aGUgcGFn
ZXMgdG8gcGh5c2ljYWwNCj4gYWRkcmVzcy4NCj4gPg0KPiA+IDIuICoqKkNhbiBub3QgdXNlIHZp
cnR1YWwgYWRkcmVzcyBmb3IgbWVtb3J5IG1hbmFnZW1lbnQqKioNCj4gPiAgICBBcyBBcm12OC1S
NjQgb25seSBoYXMgUE1TQSBpbiBFTDIsIFhlbiBsb3NlcyB0aGUgYWJpbGl0eSBvZiB1c2luZw0K
PiB2aXJ0dWFsDQo+ID4gICAgYWRkcmVzcyB0byBtYW5hZ2UgbWVtb3J5LiBUaGlzIGJyaW5ncyBz
b21lIHByb2JsZW1zLCBzb21lIHZpcnR1YWwNCj4gYWRkcmVzcw0KPiA+ICAgIGJhc2VkIGZlYXR1
cmVzIGNvdWxkIG5vdCB3b3JrIHdlbGwgb24gQXJtdjgtUjY0LCBsaWtlIGBGSVhNQVBgLA0KPiBg
dm1hcC92dW1hcGAsDQo+ID4gICAgYGlvcmVtYXBgIGFuZCBgYWx0ZXJuYXRpdmVgLg0KPiA+DQo+
ID4gICAgQnV0IHRoZSBmdW5jdGlvbnMgb3IgbWFjcm9zIG9mIHRoZXNlIGZlYXR1cmVzIGFyZSB1
c2VkIGluIGxvdHMgb2YNCj4gY29tbW9uDQo+ID4gICAgY29kZS4gU28gaXQncyBub3QgZ29vZCB0
byB1c2UgYCNpZmRlZiBDT05GSUdfQVJNX01QVWAgdG8gZ2F0ZSByZWxhdGUNCj4gY29kZQ0KPiA+
ICAgIGV2ZXJ5d2hlcmUuIEluIHRoaXMgY2FzZSwgd2UgcHJvcG9zZSB0byB1c2Ugc3R1YiBoZWxw
ZXJzIHRvIG1ha2UgdGhlDQo+IGNoYW5nZXMNCj4gPiAgICB0cmFuc3BhcmVudGx5IHRvIGNvbW1v
biBjb2RlLg0KPiA+ICAgIDEuIEZvciBgRklYTUFQYCwgd2Ugd2lsbCB1c2UgYDBgIGluIGBGSVhN
QVBfQUREUmAgZm9yIGFsbCBmaXhtYXANCj4gb3BlcmF0aW9ucy4NCj4gPiAgICAgICBUaGlzIHdp
bGwgcmV0dXJuIHBoeXNpY2FsIGFkZHJlc3MgZGlyZWN0bHkgb2YgZml4bWFwcGVkIGl0ZW0uDQo+
ID4gICAgMi4gRm9yIGB2bWFwL3Z1bWFwYCwgd2Ugd2lsbCB1c2Ugc29tZSBlbXB0eSBpbmxpbmUg
c3R1YiBoZWxwZXJzOg0KPiA+ICAgICAgICAgYGBgDQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5l
IHZvaWQgdm1faW5pdF90eXBlKC4uLikge30NCj4gPiAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9p
ZCAqX192bWFwKC4uLikNCj4gPiAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICByZXR1cm4gTlVM
TDsNCj4gPiAgICAgICAgIH0NCj4gPiAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9pZCB2dW5tYXAo
Y29uc3Qgdm9pZCAqdmEpIHt9DQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgKnZtYWxs
b2Moc2l6ZV90IHNpemUpDQo+ID4gICAgICAgICB7DQo+ID4gICAgICAgICAgICAgcmV0dXJuIE5V
TEw7DQo+ID4gICAgICAgICB9DQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgKnZtYWxs
b2NfeGVuKHNpemVfdCBzaXplKQ0KPiA+ICAgICAgICAgew0KPiA+ICAgICAgICAgICAgIHJldHVy
biBOVUxMOw0KPiA+ICAgICAgICAgfQ0KPiA+ICAgICAgICAgc3RhdGljIGlubGluZSB2b2lkIHZm
cmVlKHZvaWQgKnZhKSB7fQ0KPiA+ICAgICAgICAgYGBgDQo+ID4NCj4gPiAgICAzLiBGb3IgYGlv
cmVtYXBgLCBpdCBkZXBlbmRzIG9uIGB2bWFwYC4gQXMgd2UgaGF2ZSBtYWtlIGB2bWFwYCB0bw0K
PiBhbHdheXMNCj4gPiAgICAgICByZXR1cm4gYE5VTExgLCB0aGV5IGNvdWxkIG5vdCB3b3JrIHdl
bGwgb24gQXJtdjgtUjY0IHdpdGhvdXQNCj4gY2hhbmdlcy4NCj4gPiAgICAgICBgaW9yZW1hcGAg
d2lsbCByZXR1cm4gaW5wdXQgYWRkcmVzcyBkaXJlY3RseS4gQnV0IGlmIHNvbWUgZXh0ZW5kZWQN
Cj4gPiAgICAgICBmdW5jdGlvbnMgbGlrZSBgaW9yZW1hcF9ub2NhY2hlYCwgYGlvcmVtYXBfY2Fj
aGVgLCBuZWVkIHRvIGFzayBhDQo+IG5ldw0KPiA+ICAgICAgIG1lbW9yeSBhdHRyaWJ1dGVzLiBB
cyBBcm12OC1SIGRvZXNuJ3QgaGF2ZSBpbmZpbml0ZSBNUFUgcmVnaW9ucw0KPiBmb3INCj4gPiAg
ICAgICBYZW4gdG8gc3BsaXQgdGhlIG1lbW9yeSBhcmVhIGZyb20gaXRzIGxvY2F0ZWQgTVBVIHJl
Z2lvbiBhbmQNCj4gYXNzaWduDQo+ID4gICAgICAgdGhlIG5ldyBhdHRyaWJ1dGVzIHRvIGl0LiBT
byBpbiBgaW9yZW1hcF9ub2NhY2hlYCwgYGlvcmVtYXBfY2FjaGVgLA0KPiA+ICAgICAgIGlmIHRo
ZSBpbnB1dCBhdHRyaWJ1dGVzIGFyZSBkaWZmZXJlbnQgZnJvbSBjdXJyZW50IG1lbW9yeQ0KPiBh
dHRyaWJ1dGVzLA0KPiA+ICAgICAgIHRoZXNlIGZ1bmN0aW9ucyB3aWxsIHJldHVybiBgTlVMTGAu
DQo+ID4gICAgICAgICBgYGANCj4gPiAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9pZCAqaW9yZW1h
cF9hdHRyKC4uLikNCj4gPiAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICAvKiBXZSBkb24ndCBo
YXZlIHRoZSBhYmlsaXR5IHRvIGNoYW5nZSBpbnB1dCBQQSBjYWNoZQ0KPiBhdHRyaWJ1dGVzICov
DQo+ID4gICAgICAgICAgICAgaWYgKCBDQUNIRV9BVFRSX25lZWRfY2hhbmdlICkNCj4gPiAgICAg
ICAgICAgICAgICAgcmV0dXJuIE5VTEw7DQo+ID4gICAgICAgICAgICAgcmV0dXJuICh2b2lkICop
cGE7DQo+ID4gICAgICAgICB9DQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgX19pb21l
bSAqaW9yZW1hcF9ub2NhY2hlKC4uLikNCj4gPiAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICBy
ZXR1cm4gaW9yZW1hcF9hdHRyKHN0YXJ0LCBsZW4sIFBBR0VfSFlQRVJWSVNPUl9OT0NBQ0hFKTsN
Cj4gPiAgICAgICAgIH0NCj4gPiAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9pZCBfX2lvbWVtICpp
b3JlbWFwX2NhY2hlKC4uLikNCj4gPiAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICByZXR1cm4g
aW9yZW1hcF9hdHRyKHN0YXJ0LCBsZW4sIFBBR0VfSFlQRVJWSVNPUik7DQo+ID4gICAgICAgICB9
DQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgX19pb21lbSAqaW9yZW1hcF93YyguLi4p
DQo+ID4gICAgICAgICB7DQo+ID4gICAgICAgICAgICAgcmV0dXJuIGlvcmVtYXBfYXR0cihzdGFy
dCwgbGVuLCBQQUdFX0hZUEVSVklTT1JfV0MpOw0KPiA+ICAgICAgICAgfQ0KPiA+ICAgICAgICAg
dm9pZCAqaW9yZW1hcCguLi4pDQo+ID4gICAgICAgICB7DQo+ID4gICAgICAgICAgICAgcmV0dXJu
IGlvcmVtYXBfYXR0cihwYSwgbGVuLCBQQUdFX0hZUEVSVklTT1JfTk9DQUNIRSk7DQo+ID4gICAg
ICAgICB9DQo+ID4NCj4gPiAgICAgICAgIGBgYA0KPiA+ICAgICA0LiBGb3IgYGFsdGVybmF0aXZl
YCwgaXQgaGFzIGJlZW4gbGlzdGVkIGluIFRPRE8sIHdlIHdpbGwgc2ltcGx5DQo+IGRpc2FibGUN
Cj4gPiAgICAgICAgaXQgb24gQXJtdjgtUjY0IGluIGN1cnJlbnQgc3RhZ2UuIEJ1dCBzaW1wbHkg
ZGlzYWJsZQ0KPiBgYWx0ZXJuYXRpdmVgDQo+ID4gICAgICAgIHdpbGwgbWFrZSBgY3B1c19oYXZl
X2NvbnN0X2NhcGAgYWx3YXlzIHJldHVybiBmYWxzZS4NCj4gPiAgICAgICAgIGBgYA0KPiA+ICAg
ICAgICAgKiBTeXN0ZW0gY2FwYWJpbGl0eSBjaGVjayBmb3IgY29uc3RhbnQgY2FwICovDQo+ID4g
ICAgICAgICAjZGVmaW5lIGNwdXNfaGF2ZV9jb25zdF9jYXAobnVtKSAoeyAgICAgICAgICAgICAg
ICBcDQo+ID4gICAgICAgICAgICAgICAgcmVnaXN0ZXJfdCBfX3JldDsgICAgICAgICAgICAgICAg
ICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgYXNtIHZvbGF0aWxlIChB
TFRFUk5BVElWRSgibW92ICUwLCAjMCIsICAgICBcDQo+ID4gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAibW92ICUwLCAjMSIsICAgICBcDQo+ID4gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBudW0pICAgICAgICAgICAgICBcDQo+ID4gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICA6ICI9ciIgKF9fcmV0KSk7ICAgICAgICAgICAgICBc
DQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgIHVubGlrZWx5KF9fcmV0KTsgICAgICAgICAg
ICAgICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgIH0pDQo+ID4gICAgICAgICBg
YGANCj4gPiAgICAgICAgIFNvLCBiZWZvcmUgd2UgaGF2ZSBhbiBQTVNBIGBhbHRlcm5hdGl2ZWAg
aW1wbGVtZW50YXRpb24sIHdlIGhhdmUNCj4gdG8NCj4gPiAgICAgICAgIGltcGxlbWVudCBhIHNl
cGFyYXRlIGBjcHVzX2hhdmVfY29uc3RfY2FwYCBmb3IgQXJtdjgtUjY0Og0KPiA+ICAgICAgICAg
YGBgDQo+ID4gICAgICAgICAjZGVmaW5lIGNwdXNfaGF2ZV9jb25zdF9jYXAobnVtKSBjcHVzX2hh
dmVfY2FwKG51bSkNCj4gPiAgICAgICAgIGBgYA0KPiA+DQo+ID4gIyMjICoqMi41LiBDaGFuZ2Vz
IG9mIGd1ZXN0IG1hbmFnZW1lbnQqKg0KPiA+IEFybXY4LVI2NCBvbmx5IHN1cHBvcnRzIFBNU0Eg
aW4gRUwyLCBidXQgaXQgc3VwcG9ydHMgY29uZmlndXJhYmxlDQo+ID4gVk1TQSBvciBQTVNBIGlu
IEVMMS4gVGhpcyBtZWFucyBYZW4gd2lsbCBoYXZlIGEgbmV3IHR5cGUgZ3Vlc3Qgb24NCj4gPiBB
cm12OC1SNjQgLSBNUFUgYmFzZWQgZ3Vlc3QuDQo+ID4NCj4gPiAxLiAqKkFkZCBhIG5ldyBkb21h
aW4gdHlwZSAtIE1QVV9ET01BSU4qKg0KPiA+ICAgIFdoZW4gdXNlciB3YW50IHRvIGNyZWF0ZSBh
IGd1ZXN0IHRoYXQgd2lsbCBiZSB1c2luZyBNUFUgaW4gRUwxLCB1c2VyDQo+ID4gICAgc2hvdWxk
IGFkZCBhIGBtcHVgIHByb3BlcnR5IGluIGRldmljZSB0cmVlIGBkb21VYCBub2RlLCBsaWtlDQo+
IGZvbGxvd2luZw0KPiA+ICAgIGV4YW1wbGU6DQo+ID4gICAgIGBgYA0KPiA+ICAgICBkb21VMiB7
DQo+ID4gICAgICAgICBjb21wYXRpYmxlID0gInhlbixkb21haW4iOw0KPiA+ICAgICAgICAgZGly
ZWN0LW1hcDsNCj4gPiAgICAgICAgIG1wdTsgLS0+IEluZGljYXRlcyB0aGlzIGRvbWFpbiB3aWxs
IHVzZSBQTVNBIGluIEVMMS4NCj4gPiAgICAgICAgIC4uLg0KPiA+ICAgICB9Ow0KPiA+ICAgICBg
YGANCj4gPiAgICAgQ29ycmVzcG9uZGluZyB0byBgbXB1YCBwcm9wZXJ0eSBpbiBkZXZpY2UgdHJl
ZSwgd2UgYWxzbyBuZWVkIHRvDQo+IGludHJvZHVjZQ0KPiA+ICAgICBhIG5ldyBmbGFnIGBYRU5f
RE9NQ1RMX0NERl9JTlRFUk5BTF9tcHVgIGZvciBkb21haW4gdG8gbWFyayBpdHNlbGYNCj4gYXMg
YW4NCj4gPiAgICAgTVBVIGRvbWFpbi4gVGhpcyBmbGFnIHdpbGwgYmUgdXNlZCBpbiBkb21haW4g
Y3JlYXRpb24gYW5kIGRvbWFpbg0KPiBkb2luZw0KPiA+ICAgICB2Q1BVIGNvbnRleHQgc3dpdGNo
Lg0KPiA+ICAgICAxLiBEb21haW4gY3JlYXRpb24gbmVlZCB0aGlzIGZsYWcgdG8gZGVjaWRlIGVu
YWJsZSBQTVNBIG9yIFZNU0EgaW4NCj4gRUwxLg0KPiA+ICAgICAyLiB2Q1BVIGNvbnRleHQgc3dp
dGNoIG5lZWQgdGhpcyBmbGFnIHRvIGRlY2lkZSBzYXZlL3Jlc3RvcmUgTU1VIG9yDQo+IE1QVQ0K
PiA+ICAgICAgICByZWxhdGVkIHJlZ2lzdGVycy4NCj4gPg0KPiA+IDIuICoqQWRkIE1QVSByZWdp
c3RlcnMgZm9yIHZDUFUgdG8gc2F2ZSBFTDEgTVBVIGNvbnRleHQqKg0KPiA+ICAgIEN1cnJlbnQg
WGVuIG9ubHkgc3VwcG9ydHMgTU1VIGJhc2VkIGd1ZXN0LCBzbyBpdCBoYXNuJ3QgY29uc2lkZXJl
ZCB0bw0KPiA+ICAgIHNhdmUvcmVzdG9yZSBNUFUgY29udGV4dC4gSW4gdGhpcyBjYXNlLCB3ZSBu
ZWVkIHRvIGFkZCBNUFUgcmVnaXN0ZXJzDQo+ID4gICAgdG8gYGFyY2hfdmNwdWA6DQo+ID4gICAg
IGBgYA0KPiA+ICAgICBzdHJ1Y3QgYXJjaF92Y3B1DQo+ID4gICAgIHsNCj4gPiAgICAgICAgIC4u
Lg0KPiA+ICAgICAjaWZkZWYgQ09ORklHX0FSTV9NUFUNCj4gPiAgICAgICAgIC8qIFZpcnR1YWxp
emF0aW9uIFRyYW5zbGF0aW9uIENvbnRyb2wgUmVnaXN0ZXIgKi8NCj4gPiAgICAgICAgIHJlZ2lz
dGVyX3QgdnRjcl9lbDI7DQo+ID4NCj4gPiAgICAgICAgIC8qIEVMMSBNUFUgcmVnaW9ucycgcmVn
aXN0ZXJzICovDQo+ID4gICAgICAgICBwcl90ICptcHVfcmVnaW9uczsNCj4gPiAgICAgI2VuZGlm
DQo+ID4gICAgICAgICAuLi4NCj4gPiAgICAgfQ0KPiA+ICAgICBgYGANCj4gPiAgICAgQXJtdjgt
UjY0IGNhbiBzdXBwb3J0IG1heCB0byAyNTYgTVBVIHJlZ2lvbnMuIEJ1dCB0aGF0J3MganVzdA0K
PiB0aGVvcmV0aWNhbC4NCj4gPiAgICAgU28gd2UgZG9uJ3Qgd2FudCB0byBlbWJlZCBgcHJfdCBt
cHVfcmVnaW9uc1syNTZdYCBpbiBgYXJjaF92Y3B1YA0KPiBkaXJlY3RseSwNCj4gPiAgICAgdGhp
cyB3aWxsIGJlIGEgbWVtb3J5IHdhc3RlIGluIG1vc3QgY2FzZXMuIEluc3RlYWQgd2UgdXNlIGEg
cG9pbnRlcg0KPiBpbg0KPiA+ICAgICBgYXJjaF92Y3B1YCB0byBsaW5rIHdpdGggYSBkeW5hbWlj
YWxseSBhbGxvY2F0ZWQgYG1wdV9yZWdpb25zYDoNCj4gPiAgICAgYGBgDQo+ID4gICAgIHAtPmFy
Y2gubXB1X3JlZ2lvbnMgPSBfeHphbGxvYyhzaXplb2YocHJfdCkgKiBtcHVfcmVnaW9uc19jb3Vu
dF9lbDEsDQo+IFNNUF9DQUNIRV9CWVRFUyk7DQo+ID4gICAgIGBgYA0KPiA+ICAgICBBcyBgYXJj
aF92Y3B1YCBpcyB1c2VkIHZlcnkgZnJlcXVlbnRseSBpbiBjb250ZXh0IHN3aXRjaCwgc28gWGVu
DQo+IGRlZmluZXMNCj4gPiAgICAgYGFyY2hfdmNwdWAgYXMgYSBjYWNoZSBhbGlnbm1lbnQgZGF0
YSBzdHJ1Y3R1cmUuIGBtcHVfcmVnaW9uc2AgYWxzbw0KPiB3aWxsDQo+ID4gICAgIGJlIHVzZWQg
dmVyeSBmcmVxdWVudGx5IGluIEFybXY4LVIgY29udGV4dCBzd2l0Y2guIFNvIHdlIHVzZQ0KPiBg
X3h6YWxsb2NgDQo+ID4gICAgIHRvIGFsbG9jYXRlIGBTTVBfQ0FDSEVfQllURVNgIGFsaWdubWVu
dCBtZW1vcnkgZm9yIGBtcHVfcmVnaW9uc2AuDQo+ID4NCj4gPiAgICAgYG1wdV9yZWdpb25zX2Nv
dW50X2VsMWAgY2FuIGJlIGRldGVjdGVkIGZyb20gYE1QVUlSX0VMMWAgc3lzdGVtDQo+IHJlZ2lz
dGVyDQo+ID4gICAgIGluIFhlbiBib290IHN0YWdlLiBUaGUgbGltaXRhdGlvbiBpcyB0aGF0LCBp
ZiB3ZSBkZWZpbmUgYSBzdGF0aWMNCj4gPiAgICAgYGFyY2hfdmNwdWAsIHdlIGhhdmUgdG8gYWxs
b2NhdGUgYG1wdV9yZWdpb25zYCBiZWZvcmUgdXNpbmcgaXQuDQo+ID4NCj4gPiAzLiAqKk1QVSBi
YXNlZCBQMk0gdGFibGUgbWFuYWdlbWVudCoqDQo+ID4gICAgQXJtdjgtUjY0IEVMMiBkb2Vzbid0
IGhhdmUgRUwxIHN0YWdlIDIgYWRkcmVzcyB0cmFuc2xhdGlvbi4gQnV0DQo+IHRocm91Z2gNCj4g
PiAgICBQTVNBLCBpdCBzdGlsbCBoYXMgdGhlIGFiaWxpdHkgdG8gY29udHJvbCB0aGUgcGVybWlz
c2lvbnMgYW5kDQo+IGF0dHJpYnV0ZXMNCj4gPiAgICBvZiBFTDEgc3RhZ2UgMi4gSW4gdGhpcyBj
YXNlLCB3ZSBzdGlsbCBob3BlIHRvIGtlZXAgdGhlIGludGVyZmFjZQ0KPiA+ICAgIGNvbnNpc3Rl
bnQgd2l0aCBNTVUgYmFzZWQgUDJNIGFzIGZhciBhcyBwb3NzaWJsZS4NCj4gPg0KPiA+ICAgIHAy
bS0+cm9vdCB3aWxsIHBvaW50IHRvIGFuIGFsbG9jYXRlZCBtZW1vcnkuIEluIEFybXY4LUE2NCwg
dGhpcw0KPiBtZW1vcnkNCj4gPiAgICBpcyB1c2VkIHRvIHNhdmUgdGhlIEVMMSBzdGFnZSAyIHRy
YW5zbGF0aW9uIHRhYmxlLiBCdXQgaW4gQXJtdjgtUjY0LA0KPiA+ICAgIHRoaXMgbWVtb3J5IHdp
bGwgYmUgdXNlZCB0byBzdG9yZSBFTDIgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyB0aGF0IGFyZQ0K
PiA+ICAgIHVzZWQgYnkgZ3Vlc3QuIER1cmluZyBkb21haW4gY3JlYXRpb24sIFhlbiB3aWxsIHBy
ZXBhcmUgdGhlIGRhdGEgaW4NCj4gPiAgICB0aGlzIG1lbW9yeSB0byBtYWtlIGd1ZXN0IGNhbiBh
Y2Nlc3MgcHJvcGVyIFJBTSBhbmQgZGV2aWNlcy4gV2hlbiB0aGUNCj4gPiAgICBndWVzdCdzIHZD
UFUgd2lsbCBiZSBzY2hlZHVsZWQgaW4sIHRoaXMgZGF0YSB3aWxsIGJlIHdyaXR0ZW4gdG8gTVBV
DQo+ID4gICAgcHJvdGVjdGlvbiByZWdpb24gcmVnaXN0ZXJzLg0KPiA+DQo+ID4gIyMjICoqMi42
LiBDaGFuZ2VzIG9mIGV4Y2VwdGlvbiB0cmFwKioNCj4gPiBBcyBBcm12OC1SNjQgaGFzIGNvbXBh
dGlibGUgZXhjZXRwaW9uIG1vZGUgd2l0aCBBcm12OC1BNjQsIHNvIHdlIGNhbg0KPiByZXVzZSBt
b3N0DQo+ID4gb2YgQXJtdjgtQTY0J3MgZXhjZXB0aW9uIHRyYXAgJiBoYW5kbGVyIGNvZGUuIEJ1
dCBleGNlcHQgdGhlIHRyYXAgYmFzZWQNCj4gb24gRUwxDQo+ID4gc3RhZ2UgMiB0cmFuc2xhdGlv
biBhYm9ydC4NCj4gPg0KPiA+IEluIEFybXY4LUE2NCwgd2UgdXNlIGBGU0NfRkxUX1RSQU5TYA0K
PiA+IGBgYA0KPiA+ICAgICBjYXNlIEZTQ19GTFRfVFJBTlM6DQo+ID4gICAgICAgICAuLi4NCj4g
PiAgICAgICAgIGlmICggaXNfZGF0YSApDQo+ID4gICAgICAgICB7DQo+ID4gICAgICAgICAgICAg
ZW51bSBpb19zdGF0ZSBzdGF0ZSA9IHRyeV9oYW5kbGVfbW1pbyhyZWdzLCBoc3IsIGdwYSk7DQo+
ID4gICAgICAgICAgICAgLi4uDQo+ID4gICAgICAgICB9DQo+ID4gYGBgDQo+ID4gQnV0IGZvciBB
cm12OC1SNjQsIHdlIGhhdmUgdG8gdXNlIGBGU0NfRkxUX1BFUk1gDQo+ID4gYGBgDQo+ID4gICAg
IGNhc2UgRlNDX0ZMVF9QRVJNOg0KPiA+ICAgICAgICAgLi4uDQo+ID4gICAgICAgICBpZiAoIGlz
X2RhdGEgKQ0KPiA+ICAgICAgICAgew0KPiA+ICAgICAgICAgICAgIGVudW0gaW9fc3RhdGUgc3Rh
dGUgPSB0cnlfaGFuZGxlX21taW8ocmVncywgaHNyLCBncGEpOw0KPiA+ICAgICAgICAgICAgIC4u
Lg0KPiA+ICAgICAgICAgfQ0KPiA+IGBgYA0KPiA+DQo+ID4gIyMjICoqMi41LiBDaGFuZ2VzIG9m
IGRldmljZSBkcml2ZXIqKg0KPiA+IEJlY2F1c2UgQXJtdjgtUjY0IG9ubHkgaGFzIHNpbmdsZSBz
ZWN1cmUgc3RhdGUsIHRoaXMgd2lsbCBhZmZlY3Qgc29tZQ0KPiA+IGRldmljZXMgdGhhdCBoYXZl
IHR3byBzZWN1cmUgc3RhdGUsIGxpa2UgR0lDLiBCdXQgZm9ydHVuYXRlbHksIG1vc3QNCj4gPiB2
ZW5kb3JzIHdpbGwgbm90IGxpbmsgYSB0d28gc2VjdXJlIHN0YXRlIEdJQyB0byBBcm12OC1SNjQg
cHJvY2Vzc29ycy4NCj4gPiBDdXJyZW50IEdJQyBkcml2ZXIgY2FuIHdvcmsgd2VsbCB3aXRoIHNp
bmdsZSBzZWN1cmUgc3RhdGUgR0lDIGZvciBBcm12OC0NCj4gUjY0Lg0KPiA+DQo+ID4gIyMjICoq
Mi43LiBDaGFuZ2VzIG9mIHZpcnR1YWwgZGV2aWNlKioNCj4gPiBDdXJyZW50bHksIHdlIG9ubHkg
c3VwcG9ydCBwYXNzLXRocm91Z2ggZGV2aWNlcyBpbiBndWVzdC4gQmVjdWFzZSBldmVudA0KPiA+
IGNoYW5uZWwsIHhlbi1idXMsIHhlbi1zdG9yYWdlIGFuZCBvdGhlciBhZHZhbmNlZCBYZW4gZmVh
dHVyZXMgaGF2ZW4ndA0KPiBiZWVuDQo+ID4gZW5hYmxlZCBpbiBBcm12OC1SNjQuDQo+ID4NCj4g
PiAjIyAzLiBUT0RPDQo+ID4gVGhpcyBzZWN0aW9uIGRlc2NyaWJlcyBzb21lIGZlYXR1cmVzIHRo
YXQgYXJlIG5vdCBjdXJyZW50bHkgaW1wbGVtZW50ZWQNCj4gaW4NCj4gPiB0aGUgUG9DLiBUaG9z
ZSBmZWF0dXJlcyBhcmUgdGhpbmdzIHRoYXQgc2hvdWxkIGJlIGxvb2tlZCBpbiBhIHNlY29uZA0K
PiBzdGFnZQ0KPiA+IGFuZCB3aWxsIG5vdCBiZSBwYXJ0IG9mIHRoZSBpbml0aWFsIHN1cHBvcnQg
b2YgTVBVL0FybXY4LVIuIFRob3NlIGpvYnMNCj4gY291bGQNCj4gPiBiZSBkb25lIGJ5IEFybSBv
ciBhbnkgWGVuIGNvbnRyaWJ1dG9ycy4NCj4gPg0KPiA+ICMjIyAzLjEuIEFsdGVybmF0aXZlIGZy
YW1ld29yayBzdXBwb3J0DQo+ID4gICAgIE9uIEFybXY4LUEgc3lzdGVtLCBgYWx0ZXJuYXRpdmVg
IGlzIGRlcGVuZGluZyBvbiBgVk1BUGAgZnVuY3Rpb24gdG8NCj4gcmVtYXANCj4gPiAgICAgYSBj
b2RlIHNlY3Rpb24gdG8gYSBuZXcgcmVhZC93cml0ZSB2aXJ0dWFsIGFkZHJlc3MuIEJ1dCBvbiBB
cm12OC1SLA0KPiB3ZSBkbw0KPiA+ICAgICBub3QgaGF2ZSB2aXJ0dWFsIGFkZHJlc3MgdG8gZG8g
cmVtYXAuIFNvIGFzIGFuIGFsdGVybmF0aXZlIG1ldGhvZCwNCj4gd2Ugd2lsbA0KPiA+ICAgICBk
aXNhYmxlIHRoZSBNUFUgdG8gbWFrZSBhbGwgUkFNIGBSV1hgIGluICJhcHBseSBhbHRlcm5hdGl2
ZSBhbGwNCj4gcGF0Y2hlcyINCj4gPiAgICAgcHJvZ3Jlc3MgdGVtcG9yYXJpbHkuDQo+ID4NCj4g
PiAgICAgMS4gRGlzYWJsZSBNUFUgLT4gQ29kZSBzZWN0aW9uIGJlY29tZXMgUldYLg0KPiA+ICAg
ICAyLiBBcHBseSBhbHRlcm5hdGl2ZSBwYXRjaGVzIHRvIFhlbiB0ZXh0Lg0KPiA+ICAgICAzLiBF
bmFibGUgTVBVIC0+IENvZGUgc2VjdGlvbiByZXN0b3JlcyB0byBSWC4NCj4gPg0KPiA+ICAgICBB
bGwgbWVtb3J5IGlzIFJXWCwgdGhlcmUgbWF5IGJlIHNvbWUgc2VjdXJpdHkgcmlzay4gQnV0LCBi
ZWNhdXNlDQo+ID4gICAgICJhbHRlcm5hdGl2ZSBhcHBseSBwYXRjaGVzIiBoYXBwZW5zIGluIFhl
biBpbml0IHN0YWdlLCBpdCBwcm9wb2FibHkNCj4gPiAgICAgZG9lc24ndCBtYXR0ZXIgYXMgbXVj
aC4NCj4gPg0KPiA+ICMjIyAzLjIuIFhlbiBFdmVudCBDaGFubmVsIFN1cHBvcnQNCj4gPiAgICAg
SW4gQ3VycmVudCBSRkMgcGF0Y2hlcyB3ZSBoYXZlbid0IGVuYWJsZWQgdGhlIGV2ZW50IGNoYW5u
ZWwgc3VwcG9ydC4NCj4gPiAgICAgQnV0IEkgdGhpbmsgaXQncyBnb29kIG9wcG9ydHVuaXR5IHRv
IGRvIHNvbWUgZGlzY3Vzc2lvbiBpbiBhZHZhbmNlZC4NCj4gPiAgICAgT24gQXJtdjgtUiwgYWxs
IFZNcyBhcmUgbmF0aXZlIGRpcmVjdC1tYXAsIGJlY2F1c2UgdGhlcmUgaXMgbm8NCj4gc3RhZ2Uy
DQo+ID4gICAgIE1NVSB0cmFuc2xhdGlvbi4gQ3VycmVudCBldmVudCBjaGFubmVsIGltcGxlbWVu
dGF0aW9uIGRlcGVuZHMgb24NCj4gc29tZQ0KPiA+ICAgICBzaGFyZWQgcGFnZXMgYmV0d2VlbiBY
ZW4gYW5kIGd1ZXN0OiBgc2hhcmVkX2luZm9gIGFuZCBwZXItY3B1DQo+IGB2Y3B1X2luZm9gLg0K
PiA+DQo+ID4gICAgIEZvciBgc2hhcmVkX2luZm9gLCBpbiBjdXJyZW50IGltcGxlbWVudGF0aW9u
LCBYZW4gd2lsbCBhbGxvY2F0ZSBhDQo+IHBhZ2UNCj4gPiAgICAgZnJvbSBoZWFwIGZvciBgc2hh
cmVkX2luZm9gIHRvIHN0b3JlIGluaXRpYWwgbWV0YSBkYXRhLiBXaGVuIGd1ZXN0DQo+IGlzDQo+
ID4gICAgIHRyeWluZyB0byBzZXR1cCBgc2hhcmVkX2luZm9gLCBpdCB3aWxsIGFsbG9jYXRlIGEg
ZnJlZSBnZm4gYW5kIHVzZSBhDQo+ID4gICAgIGh5cGVyY2FsbCB0byBzZXR1cCBQMk0gbWFwcGlu
ZyBiZXR3ZWVuIGdmbiBhbmQgYHNoYXJlZF9pbmZvYC4NCj4gPg0KPiA+ICAgICBGb3IgZGlyZWN0
LW1hcHBpbmcgVk0sIHRoaXMgd2lsbCBicmVhayB0aGUgZGlyZWN0LW1hcHBpbmcgY29uY2VwdC4N
Cj4gPiAgICAgQW5kIG9uIGFuIE1QVSBiYXNlZCBzeXN0ZW0sIGxpa2UgQXJtdjgtUiBzeXN0ZW0s
IHRoaXMgb3BlcmF0aW9uIHdpbGwNCj4gPiAgICAgYmUgdmVyeSB1bmZyaWVuZGx5LiBYZW4gbmVl
ZCB0byBwb3AgYHNoYXJlZF9pbmZvYCBwYWdlIGZyb20gWGVuIGhlYXANCj4gPiAgICAgYW5kIGlu
c2VydCBpdCB0byBWTSBQMk0gcGFnZXMuIElmIHRoaXMgcGFnZSBpcyBpbiB0aGUgbWlkZGxlIG9m
DQo+ID4gICAgIFhlbiBoZWFwLCB0aGlzIG1lYW5zIFhlbiBuZWVkIHRvIHNwbGl0IGN1cnJlbnQg
aGVhcCBhbmQgdXNlIGV4dHJhDQo+ID4gICAgIE1QVSByZWdpb25zLiBBbHNvIGZvciB0aGUgUDJN
IHBhcnQsIHRoaXMgcGFnZSBpcyB1bmxpa2VseSB0byBmb3JtDQo+ID4gICAgIGEgbmV3IGNvbnRp
bnVvdXMgbWVtb3J5IHJlZ2lvbiB3aXRoIHRoZSBleGlzdGluZyBwMm0gcGFnZXMsIGFuZCBYZW4N
Cj4gPiAgICAgaXMgbGlrZWx5IHRvIG5lZWQgYW5vdGhlciBhZGRpdGlvbmFsIE1QVSByZWdpb24g
dG8gc2V0IGl0IHVwLCB3aGljaA0KPiA+ICAgICBpcyBvYnZpb3VzbHkgYSB3YXN0ZSBmb3IgbGlt
aXRlZCBNUFUgcmVnaW9ucy4gQW5kIFRoaXMga2luZCBvZg0KPiBkeW5hbWljDQo+ID4gICAgIGlz
IHF1aXRlIGhhcmQgdG8gaW1hZ2luZSBvbiBhbiBNUFUgc3lzdGVtLg0KPiANCj4gWWVhaCwgaXQg
ZG9lc24ndCBtYWtlIGFueSBzZW5zZSBmb3IgTVBVIHN5c3RlbXMNCj4gDQo+IA0KPiA+ICAgICBG
b3IgYHZjcHVfaW5mb2AsIGluIGN1cnJlbnQgaW1wbGVtZW50YXRpb24sIFhlbiB3aWxsIHN0b3Jl
DQo+IGB2Y3B1X2luZm9gDQo+ID4gICAgIG1ldGEgZGF0YSBmb3IgYWxsIHZDUFVzIGluIGBzaGFy
ZWRfaW5mb2AuIFdoZW4gZ3Vlc3QgaXMgdHJ5aW5nIHRvDQo+IHNldHVwDQo+ID4gICAgIGB2Y3B1
X2luZm9gLCBpdCB3aWxsIGFsbG9jYXRlIG1lbW9yeSBmb3IgYHZjcHVfaW5mb2AgZnJvbSBndWVz
dCBzaWRlLg0KPiA+ICAgICBBbmQgdGhlbiBndWVzdCB3aWxsIHVzZSBoeXBlcmNhbGwgdG8gY29w
eSBtZXRhIGRhdGEgZnJvbQ0KPiBgc2hhcmVkX2luZm9gDQo+ID4gICAgIHRvIGd1ZXN0IHBhZ2Uu
IEFmdGVyIHRoYXQgYm90aCBYZW4gYHZjcHVfaW5mb2AgYW5kIGd1ZXN0IGB2Y3B1X2luZm9gDQo+
ID4gICAgIGFyZSBwb2ludGVkIHRvIHRoZSBzYW1lIHBhZ2UgdGhhdCBhbGxvY2F0ZWQgYnkgZ3Vl
c3QuDQo+ID4NCj4gPiAgICAgVGhpcyBpbXBsZW1lbnRhdGlvbiBoYXMgc2VydmFsIGJlbmlmaXRz
Og0KPiA+ICAgICAxLiBUaGVyZSBpcyBubyB3YXN0ZSBtZW1vcnkuIE5vIGV4dHJhIG1lbW9yeSB3
aWxsIGJlIGFsbG9jYXRlZCBmcm9tDQo+IFhlbiBoZWFwLg0KPiA+ICAgICAyLiBUaGVyZSBpcyBu
byBQMk0gcmVtYXAuIFRoaXMgd2lsbCBub3QgYnJlYWsgdGhlIGRpcmVjdC1tYXBwaW5nLA0KPiBh
bmQNCj4gPiAgICAgICAgaXMgTVBVIHN5c3RlbSBmcmllbmRseS4NCj4gPiAgICAgU28sIG9uIEFy
bXY4LVIgc3lzdGVtLCB3ZSBjYW4gc3RpbGwga2VlcCBjdXJyZW50IGltcGxlbWVudGF0aW9uIGZv
cg0KPiA+ICAgICBwZXItY3B1IGB2Y3B1X2luZm9gLg0KPiA+DQo+ID4gICAgIFNvLCBvdXIgcHJv
cG9zYWwgaXMgdGhhdCwgY2FuIHdlIHJldXNlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gaWRlYQ0K
PiBvZg0KPiA+ICAgICBgdmNwdV9pbmZvYCBmb3IgYHNoYXJlZF9pbmZvYD8gV2Ugc3RpbGwgYWxs
b2NhdGUgb25lIHBhZ2UgZm9yDQo+ID4gICAgIGBkLT5zaGFyZWRfaW5mb2AgYXQgZG9tYWluIGNv
bnN0cnVjdGlvbiBmb3IgaG9sZGluZyBzb21lIGluaXRpYWwNCj4gbWV0YS1kYXRhLA0KPiA+ICAg
ICB1c2luZyBhbGxvY19kb21oZWFwX3BhZ2VzIGluc3RlYWQgb2YgYWxsb2NfeGVuaGVhcF9wYWdl
cyBhbmQNCj4gPiAgICAgc2hhcmVfeGVuX3BhZ2Vfd2l0aF9ndWVzdC4gQW5kIHdoZW4gZ3Vlc3Qg
YWxsb2NhdGVzIGEgcGFnZSBmb3INCj4gPiAgICAgYHNoYXJlZF9pbmZvYCBhbmQgdXNlIGh5cGVy
Y2FsbCB0byBzZXR1cCBpdCwgIFdlIGNvcHkgdGhlIGluaXRpYWwNCj4gZGF0YSBmcm9tDQo+ID4g
ICAgIGBkLT5zaGFyZWRfaW5mb2AgdG8gaXQuIEFuZCBhZnRlciBjb3B5IHdlIGNhbiB1cGRhdGUg
YGQtDQo+ID5zaGFyZWRfaW5mb2AgdG8gcG9pbnQNCj4gPiAgICAgdG8gZ3Vlc3QgYWxsb2NhdGVk
ICdzaGFyZWRfaW5mbycgcGFnZS4gSW4gdGhpcyBjYXNlLCB3ZSBkb24ndCBoYXZlDQo+IHRvIHRo
aW5rDQo+ID4gICAgIGFib3V0IHRoZSBmcmFnbWVudGF0aW9uIG9mIFhlbiBoZWFwIGFuZCBwMm0g
YW5kIHRoZSBleHRyYSBNUFUNCj4gcmVnaW9ucy4NCj4gDQo+IFllcywgSSB0aGluayB0aGF0IHdv
dWxkIHdvcmsuDQo+IA0KPiBBbHNvIEkgdGhpbmsgaXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGdl
dCByaWQgb2YgdGhlIGluaXRpYWwNCj4gZC0+c2hhcmVkX2luZm8gYWxsb2NhdGlvbiBpbiBYZW4s
IGdpdmVuIHRoYXQgZC0+c2hhcmVkX2luZm8gaXMgZm9yIHRoZQ0KPiBiZW5lZml0IG9mIHRoZSBn
dWVzdCBhbmQgdGhlIGd1ZXN0IGNhbm5vdCBhY2Nlc3MgaXQgdW50aWwgaXQgbWFrZXMgdGhlDQo+
IFhFTk1BUFNQQUNFX3NoYXJlZF9pbmZvIGh5cGVyY2FsbC4NCj4gDQoNCldoaWxlIHdlJ3JlIHdv
cmtpbmcgb24gZXZlbnQgY2hhbm5lbCBQb0Mgd29yayBvbiBYZW4gQXJtdjgtUiwgd2UgZm91bmQN
CmFub3RoZXIgaXNzdWUgYWZ0ZXIgd2UgZHJvcHBlZCBkLT5zaGFyZWRfaW5mbyBhbGxvY2F0aW9u
IGluIFhlbi4gQm90aA0Kc2hhcmVkX2luZm8gYW5kIHZjcHVfaW5mbyBhcmUgYWxsb2NhdGVkIGZy
b20gR3Vlc3QgaW4gcnVudGltZS4gVGhhdA0KbWVhbnMgdGhlIGFkZHJlc3NlcyBvZiBzaGFyZWRf
aW5mbyBhbmQgdmNwdV9pbmZvIGFyZSByYW5kb20uIEZvciBNTVUNCnN5c3RlbSwgdGhpcyBpcyBP
SywgYmVjYXVzZSBYZW4gaGFzIGEgZnVsbCB2aWV3IG9mIHN5c3RlbSBtZW1vcnkgaW4NCnJ1bnRp
bWUuIEJ1dCBmb3IgTVBVIHN5c3RlbSwgdGhlIHNpdHVhdGlvbiBiZWNvbWVzIGEgbGl0dGxlIHRy
aWNreS4NCldlIGhhdmUgdG8gc2V0dXAgZXh0cmEgTVBVIHJlZ2lvbnMgZm9yIHJlbW90ZSBkb21h
aW5zJyBzaGFyZWRfaW5mbw0KYW5kIHZjcHVfaW5mbyBpbiBldmVudCBjaGFubmVsIGh5cGVyY2Fs
bCBydW50aW1lLiBUaGF0J3MgYmVjYXVzZQ0KaW4gY3VycmVudCBYZW4gaHlwZXJjYWxsIGNvbmNl
cHQsIGh5cGVyY2FsbCB3aWxsIG5vdCBjYXVzZSB2Q1BVDQpjb250ZXh0IHN3aXRjaC4gV2hlbiBo
eXBlcmNhbGwgdHJhcCB0byBFTDIsIGl0IHdpbGwga2VlcCB2Q1BVJ3MNClAyTSB2aWV3LiBGb3Ig
TU1VIHN5c3RlbSwgd2UgaGF2ZSB2dHRicl9lbDIgZm9yIHZDUFUgUDJNIHZpZXcgYW5kDQp0dGJy
X2VsMiBmb3IgWGVuIHZpZXcuIFNvIGluIEVMMiBYZW4gaGFzIGZ1bGwgcGVybWlzc2lvbnMgdG8g
YWNjZXNzDQphbnkgbWVtb3J5IGl0IHdhbnRzLiBCdXQgZm9yIE1QVSBzeXN0ZW0sIHdlIG9ubHkg
aGF2ZSBvbmUgRUwyIE1QVS4NCkJlZm9yZSBlbnRlcmluZyBndWVzdCwgWGVuIHdpbGwgc2V0dXAg
dkNQVSBQMk0gdmlldyBpbiBFTDIgTVBVLg0KSW4gdGhpcyBjYXNlLCB3aGVuIHN5c3RlbSBlbnRy
eSBFTDIgdGhyb3VnaCBoeXBlcmNhbGwsIHRoZSBFTDINCk1QVSBzdGlsbCBrZWVwcyBjdXJyZW50
IHZDUFUgUDJNIHZpZXcgYW5kIHdpdGggWGVuIGVzc2VudGlhbA0KbWVtb3J5IChjb2RlLCBkYXRh
LCBoZWFwKSBhY2Nlc3MgcGVybWlzc2lvbnMuIEJ1dCBjdXJyZW50IEVMMiBNUFUNCmRvZXNuJ3Qg
aGF2ZSB0aGUgYWNjZXNzIHBlcm1pc3Npb25zIGZvciBFTDIgdG8gYWNjZXNzIG90aGVyDQpkb21h
aW4ncyBtZW1vcnkuIEZvciBhbiBldmVudCBjaGFubmVsIGh5cGVyY2FsbCwgaWYgd2Ugd2FudCB0
bw0KdXBkYXRlIHRoZSBwZW5kaW5nIGJpdG1hcCBpbiByZW1vdGUgZG9tYWluJ3MgdmNwdV9pbmZv
LCBpdCB3aWxsDQpjYXVzZSBhIGRhdGFhYm9ydCBpbiBFTDIuIFRvIHNvbHZlIHRoaXMgZGF0YWFi
b3J0LCB3ZSBtYXkgaGF2ZQ0KdHdvIG1ldGhvZHM6DQoxLiBNYXAgcmVtb3RlIGRvbWFpbidzIHdo
b2xlIG1lbW9yeSBvciBwYWdlcyBmb3Igc2hhcmVkX2luZm8gKw0KICAgdmNwdV9pbmZvIGluIEVM
MiBNUFUgdGVtcG9yYXJpbHkgZm9yIGh5cGVyY2FsbCB0byB1cGRhdGUNCiAgIHBlbmRpbmcgYml0
cyBvciBvdGhlciBhY2Nlc3Nlcy4NCg0KICAgVGhpcyBtZXRob2QgZG9lc24ndCBuZWVkIHRvIGRv
IGNvbnRleHQgc3dpdGNoIGZvciBFTDIgTVBVLA0KICAgQnV0IHRoaXMgbWV0aG9kIGhhcyBzb21l
IGRpc2FkdmFudGFnZXM6DQogICAxLiBXZSBoYXZlIHRvIHJlc2VydmUgTVBVIHJlZ2lvbnMgZm9y
IGh5cGVyY2FsbC4NCiAgIDIuIERpZmZlcmVudCBoeXBlcmNhbGwgbWF5IGhhdmUgZGlmZmVyZW50
IHJlc2VydmF0aW9uIG9mDQogICAgICBNUFUgcmVnaW9ucy4NCiAgIDMuIFdlIGhhdmUgdG8gaGFu
ZGxlIGh5cGVyY2FsbCBvbmUgYnkgb25lIGZvciBleGlzdGVkIGFuZA0KICAgICAgbmV3IGluIGZ1
dHVyZS4NCg0KMi4gU3dpdGNoIHRvIFhlbidzIG1lbW9yeSB2aWV3IGluIEVMMiBNUFUgd2hlbiB0
cmFwIGZyb20gRUwxIHRvDQogICBFTDIuIEluIHRoaXMgY2FzZSwgWGVuIHdpbGwgaGF2ZSBmdWxs
IG1lbW9yeSBhY2Nlc3MgcGVybWlzc2lvbnMNCiAgIHRvIHVwZGF0ZSBwZW5kaW5nIGJpdHMgaW4g
RUwyLiBUaGlzIG9ubHkgY2hhbmdlcyB0aGUgRUwyIE1QVQ0KICAgY29udGV4dCwgZG9lcyBub3Qg
bmVlZCB0byBkbyB2Q1BVIGNvbnRleHQgc3dpdGNoLiBCZWNhdXNlIHRoZQ0KICAgdHJhcHBlZCB2
Q1BVIHdpbGwgYmUgdXNlZCBpbiB0aGUgZnVsbCBmbG93IG9mIGh5cGVyY2FsbC4gQWZ0ZXINCiAg
IHRoZSBoeXBlcmNhbGwsIGJlZm9yZSByZXR1cm5pbmcgdG8gRUwyLCB0aGUgRUwyIE1QVSB3aWxs
IHN3aXRjaA0KICAgdG8gc2NoZWR1bGVkIHZDUFUnIFAyTSB2aWV3Lg0KICAgVGhpcyBtZXRob2Qg
bmVlZHMgdG8gZG8gRUwyIE1QVSBjb250ZXh0IHN3aXRjaCwgYnV0Og0KICAgMS4gV2UgZG9uJ3Qg
bmVlZCB0byByZXNlcnZlIE1QVSByZWdpb25zIGZvciBYZW4ncyBtZW1vcnkgdmlldy4NCiAgICAg
IChYZW4ncyBtZW1vcnkgdmlldyBoYXMgYmVlbiBzZXR1cCB3aGlsZSBpbml0aWFsaXphdGlvbikN
CiAgIDIuIFdlIGRvbid0IG5lZWQgdG8gaGFuZGxlIHBhZ2VzJyBtYXBwaW5nIGluIGh5cGVyY2Fs
bCBsZXZlbC4NCiAgIDMuIEFwcGx5IHRvIG90aGVyIEVMMSB0byBFTDIgdHJhcHMsIGxpa2UgZGF0
YWFib3J0LCBJUlEsIGV0Yy4gDQoNCiAgIEJ1dCB0aGlzIG1ldGhvZCBpbnRyb2R1Y2VzIGFub3Ro
ZXIgc2VjdXJpdHkgY29uY2VybjoNCiAgIEdpdmluZyBmdWxsIG1lbW9yeSB2aWV3IHRvIFhlbiBh
dCBhbnkgRUwyIHJ1bnRpbWUgd2lsbCBjYXVzZQ0KICAgYW55IHNlY3VyaXR5IGlzc3VlPyBBbHRo
b3VnaCBYZW4gaGFzIGRvbmUgaW4gdGhpcyB3YXkgaW4gTU1VDQogICBzeXN0ZW0gYWxyZWFkeS4N
Cg0KPiANCj4gPiAgICAgQnV0IGhlcmUgc3RpbGwgaGFzIHNvbWUgY29uY2VybnM6DQo+ID4gICAg
IGBkLT5zaGFyZWRfaW5mb2AgaW4gWGVuIGlzIGFjY2Vzc2VkIHdpdGhvdXQgYW55IGxvY2suIFNv
IGl0IHdpbGwgbm90DQo+IGJlDQo+ID4gICAgIHRoYXQgc2ltcGxlIHRvIHVwZGF0ZSBgZC0+c2hh
cmVkX2luZm9gLiBJdCBtaWdodCBiZSBwb3NzaWJsZSB0bw0KPiBwcm90ZWN0DQo+ID4gICAgIGQt
PnNoYXJlZF9pbmZvIChvciBvdGhlciBzdHJ1Y3R1cmUpIHdpdGggYSByZWFkLXdyaXRlIGxvY2su
DQo+ID4NCj4gPiAgICAgRG8gd2UgbmVlZCB0byBhZGQgUEdUX3h4eCBmbGFncyB0byBtYWtlIGl0
IGdsb2JhbCBhbmQgc3RheSBhcyBtdWNoDQo+IHRoZQ0KPiA+ICAgICBzYW1lIHdpdGggdGhlIG9y
aWdpbmFsIG9wLCBhIHNpbXBsZSBpbnZlc3RpZ2F0aW9uIHRlbGxzIHVzIHRoYXQgaXQNCj4gb25s
eQ0KPiA+ICAgICBiZSByZWZlcnJlZCBpbiBgZ2V0X3BhZ2VfdHlwZWAuIFNpbmNlIEFSTSBkb2Vz
bid0IGNhcmUgYWJvdXQNCj4gdHlwZWNvdW50cw0KPiA+ICAgICBhbmQgYWx3YXlzIHJldHVybiAx
LCBpdCBkb2Vzbid0IGhhdmUgdG9vIG11Y2ggaW1wYWN0Lg0KPiA+DQo+ID4gIyMjIDMuMy4gWGVu
IFBhcnRpYWwgUElDL1BJRQ0KPiA+ICAgICBBcyB3ZSBoYXZlIGRlc2NyaWJlZCBpbiBgWEVOX1NU
QVJUX0FERFJFU1NgIHNlY3Rpb24uIFBJQy9QSUUgY2FuDQo+IHNvbHZlDQo+ID4gICAgIGRpZmZl
cmVudCBwbGF0Zm9ybXMgaGF2ZSBkaWZmZXJlbnQgYFhFTl9TVEFSVF9BRERSRVNTYCBpc3N1ZS4g
QnV0IHdlDQo+ID4gICAgIGFsc28gZGVzY3JpYmUgc29tZSBpc3N1ZXMgdG8gdXNlIFBJQy9QSUUg
aW4gcmVhbCB0aW1lIHN5c3RlbXMgbGlrZQ0KPiA+ICAgICBBcm12OC1SIHBsYXRmb3Jtcy4NCj4g
Pg0KPiA+ICAgICBCdXQgYSBwYXJ0aWFsIFBJQy9QSUUgc3VwcG9ydCBtYXkgYmUgbmVlZGVkIGZv
ciBBcm12OC1SLiBCZWNhdXNlIEFybQ0KPiA+ICAgICBbRUJCUl0oaHR0cHM6Ly9hcm0tc29mdHdh
cmUuZ2l0aHViLmlvL2ViYnIvaW5kZXguaHRtbCkgcmVxdWlyZSBYZW4NCj4gPiAgICAgb24gQXJt
djgtUiB0byBzdXBwb3J0IEVGSSBib290IHNlcnZpY2UuIER1ZSB0byBsYWNrIG9mIHJlbG9jYXRp
b24NCj4gPiAgICAgY2FwYWJpbGl0eSwgRUZJIGxvYWRlciBjb3VsZCBub3QgbGF1bmNoIHhlbi5l
Zmkgb24gQXJtdjgtUi4gU28gbWF5YmUNCj4gPiAgICAgd2Ugc3RpbGwgbmVlZCBhIHBhcnRpYWxs
eSBzdXBwb3J0ZWQgUElDL1BJRS4gT25seSBzb21lIGJvb3QgY29kZQ0KPiA+ICAgICBzdXBwb3J0
IFBJQy9QSUUgdG8gbWFrZSBFRkkgcmVsb2NhdGlvbiBoYXBweS4gVGhpcyBib290IGNvZGUgd2ls
bA0KPiA+ICAgICBoZWxwIFhlbiB0byBjaGVjayBpdHMgbG9hZGVkIGFkZHJlc3MgYW5kIHJlbG9j
YXRlIFhlbiBpbWFnZSB0byBYZW4ncw0KPiA+ICAgICBydW4tdGltZSBhZGRyZXNzIGlmIG5lZWQu
DQo+ID4NCj4gPiAjIyMgMy40LiBBIHRvb2wgdG8gZ2VuZXJhdGUgQXJtdjgtUiBYZW4gZGV2aWNl
IHRyZWUNCj4gPiAxLiBVc2UgYSB0b29sIHRvIGdlbmVyYXRlIGFib3ZlIGRldmljZSB0cmVlIHBy
b3BlcnR5Lg0KPiA+ICAgIFRoaXMgdG9vbCB3aWxsIGhhdmUgc29tZSBzaW1pbGFyIGlucHV0cyBh
cyBiZWxvdzoNCj4gPiAgICAtLS0NCj4gPiAgICBERVZJQ0VfVFJFRT0iZnZwX2JhcmVtZXRhbC5k
dGIiDQo+ID4gICAgWEVOPSI0LjE2LTIwMjIuMS94ZW4iDQo+ID4NCj4gPiAgICBOVU1fRE9NVVM9
MQ0KPiA+ICAgIERPTVVfS0VSTkVMWzBdPSI0LjE2LTIwMjIuMS9JbWFnZS1kb21VIg0KPiA+ICAg
IERPTVVfUkFNRElTS1swXT0iNC4xNi0yMDIyLjEvaW5pdHJkLmNwaW8iDQo+ID4gICAgRE9NVV9Q
QVNTVEhST1VHSF9EVEJbMF09IjQuMTYtMjAyMi4xL3Bhc3N0aHJvdWdoLWV4YW1wbGUtZGV2LmR0
YiINCj4gPiAgICBET01VX1JBTV9CQVNFWzBdPTB4MzAwMDAwMDANCj4gPiAgICBET01VX1JBTV9T
SVpFWzBdPTB4MWYwMDAwMDANCj4gPiAgICAtLS0NCj4gPiAgICBVc2luZyBhYm92ZSBpbnB1dHMs
IHRoZSB0b29sIGNhbiBnZW5lcmF0ZSBhIGRldmljZSB0cmVlIHNpbWlsYXIgYXMNCj4gPiAgICB3
ZSBoYXZlIGRlc2NyaWJlZCBpbiBzYW1wbGUuDQo+ID4NCj4gPiAgICAtIGBtcHUsZ3Vlc3QtbWVt
b3J5LXNlY3Rpb25gOg0KPiA+ICAgIFRoaXMgc2VjdGlvbiB3aWxsIGNvdmVyIGFsbCBndWVzdHMn
IFJBTSAoYHhlbixzdGF0aWMtbWVtYCBkZWZpbmVkDQo+IHJlZ2lvbnMNCj4gPiAgICBpbiBhbGwg
RG9tVSBub2RlcykuIEFsbCBndWVzdCBSQU0gbXVzdCBiZSBsb2NhdGVkIHdpdGhpbiB0aGlzIHNl
Y3Rpb24uDQo+ID4gICAgSW4gdGhlIGJlc3QgY2FzZSwgd2UgY2FuIG9ubHkgaGF2ZSBvbmUgTVBV
IHByb3RlY3Rpb24gcmVnaW9uIHRvIG1hcA0KPiBhbGwNCj4gPiAgICBndWVzdHMnIFJBTSBmb3Ig
WGVuLg0KPiA+DQo+ID4gICAgSWYgdXNlcnMgc2V0IGBET01VX1JBTV9CQVNFYCBhbmQgYERPTVVf
UkFNX1NJWkVgLCB0aGVzZSB3aWxsIGJlDQo+IGNvbnZlcnRlZA0KPiA+ICAgIHRvIHRoZSBiYXNl
IGFuZCBzaXplIG9mIGB4ZW4sc3RhdGljLW1lbWAuIFRoaXMgdG9vbCB3aWxsIHNjYW4gYWxsDQo+
ID4gICAgYHhlbiwgc3RhdGljLW1lbWAgaW4gRG9tVSBub2RlcyB0byBkZXRlcm1pbiB0aGUgYmFz
ZSBhbmQgc2l6ZSBvZg0KPiA+ICAgIGBtcHUsZ3Vlc3QtbWVtb3J5LXNlY3Rpb25gLiBJZiB0aGVy
ZSBpcyBhbnkgb3RoZXIga2luZCBvZiBtZW1vcnkNCj4gdXNhZ2UNCj4gPiAgICBoYXMgYmVlbiBk
ZXRlY3RlZCBpbiB0aGlzIHNlY3Rpb24sIHRoaXMgdG9vbCBjYW4gcmVwb3J0IGFuIGVycm9yLg0K
PiA+ICAgIEV4Y2VwdCBidWlsZCB0aW1lIGNoZWNrLCBYZW4gYWxzbyBuZWVkIHRvIGRvIHJ1bnRp
bWUgY2hlY2sgdG8gcHJldmVudA0KPiBhDQo+ID4gICAgYmFkIGRldmljZSB0cmVlIHRoYXQgZ2Vu
ZXJhdGVkIGJ5IG1hbGljaW91cyB0b29scy4NCj4gPg0KPiA+ICAgIElmIHVzZXJzIHNldCBgRE9N
VV9SQU1fU0laRWAgb25seSwgdGhpcyB3aWxsIGJlIGNvbnZlcnRlZCB0byB0aGUgc2l6ZQ0KPiBv
Zg0KPiA+ICAgIGB4ZW4sc3RhdGljLW1lbWAgb25seS4gWGVuIHdpbGwgYWxsb2NhdGUgdGhlIGd1
ZXN0IG1lbW9yeSBpbiBydW50aW1lLA0KPiBidXQNCj4gPiAgICBub3QgZnJvbSBYZW4gaGVhcC4g
YG1wdSxndWVzdC1tZW1vcnktc2VjdGlvbmAgd2lsbCBiZSBjYWN1bGF0ZWQgaW4NCj4gcnVudGlt
ZQ0KPiA+ICAgIHRvby4gVGhlIHByb3BlcnR5IGluIGRldmljZSB0cmVlIGRvZXNuJ3QgbmVlZCBv
ciB3aWxsIGJlIGlnbm9yZWQgYnkNCj4gWGVuLg0KPiANCj4gSSBhbSBmaW5lIHdpdGggdGhpcy4g
WW91IHNob3VsZCBhbHNvIGtub3cgdGhhdCB0aGVyZSB3YXMgYSByZWNlbnQNCj4gZGlzY3Vzc2lv
biBhYm91dCBhZGRpbmcgc29tZXRoaW5nIGxpa2U6DQo+IA0KPiAjIGFkZHJlc3Mgc2l6ZSBhZGRy
ZXNzIHNpemUgLi4uDQo+IERPTVVfU1RBVElDX01FTV9SQU5HRVNbMF09IjB4ZTAwMDAwMCAweDEw
MDAwMDAgMHhhMDAwMDAwMCAweDMwMDAwMDAwIg0KPiANCj4gdG8gdGhlIEltYWdlQnVpbGRlciBj
b25maWcgZmlsZS4NCj4gDQo+IA0KPiA+ICAgIC0gYG1wdSxib290LW1vZHVsZS1zZWN0aW9uYDoN
Cj4gPiAgICBUaGlzIHNlY3Rpb24gd2lsbCBiZSB1c2VkIHRvIHN0b3JlIHRoZSBib290IG1vZHVs
ZXMgbGlrZSBET01VX0tFUk5FTCwNCj4gPiAgICBET01VX1JBTURJU0ssIGFuZCBET01VX1BBU1NU
SFJPVUdIX0RUQi4gWGVuIGtlZXBzIGFsbCBib290IG1vZHVsZXMgaW4NCj4gPiAgICB0aGlzIHNl
Y3Rpb24gdG8gbWVldCB0aGUgcmVxdWlybWVudCBvZiBEb21VIHJlc3RhcnQgb24gQXJtdjgtUi4g
SW4NCj4gPiAgICBjdXJyZW50IHN0YWdlLCB3ZSBkb24ndCBoYXZlIGEgcHJpdmlsZWdlIGRvbWFp
biBsaWtlIERvbTAgdGhhdCBjYW4NCj4gPiAgICBhY2Nlc3MgZmlsZXN5c3RlbSB0byByZWxvYWQg
RG9tVSBpbWFnZXMuDQo+ID4NCj4gPiAgICBBbmQgaW4gY3VycmVudCBYZW4gY29kZSwgdGhlIGJh
c2UgYW5kIHNpemUgYXJlIG1hbmRhdG9yeSBmb3IgYm9vdA0KPiBtb2R1bGVzDQo+ID4gICAgSWYg
dXNlcnMgZG9uJ3Qgc3BlY2lmeSB0aGUgYmFzZSBvZiBlYWNoIGJvb3QgbW9kdWxlLCB0aGUgdG9v
bCB3aWxsDQo+ID4gICAgYWxsb2N0ZSBhIGJhc2UgZm9yIGVhY2ggbW9kdWxlLiBBbmQgdGhlIHRv
b2wgd2lsbCBnZW5lcmF0ZSB0aGUNCj4gPiAgICBgbXB1LGJvb3QtbW9kdWxlLXNlY3Rpb25gIHJl
Z2lvbiwgd2hlbiBpdCBmaW5pc2hzIGJvb3QgbW9kdWxlIG1lbW9yeQ0KPiA+ICAgIGFsbG9jYXRp
b24uDQo+ID4NCj4gPiAgICBVc2VycyBhbHNvIGNhbiBzcGVjaWZ5IHRoZSBiYXNlIGFuZCBzaXpl
IG9mIGVhY2ggYm9vdCBtb2R1bGUsIHRoZXNlDQo+IHdpbGwNCj4gPiAgICBiZSBjb252ZXJ0ZWQg
dG8gdGhlIGJhc2UgYW5kIHNpemUgb2YgbW9kdWxlJ3MgYHJlZ2AgZGlyZWN0bHkuIFRoZQ0KPiB0
b29sDQo+ID4gICAgd2lsbCBzY2FuIGFsbCBtb2R1bGVzIGByZWdgIGluIERvbVUgbm9kZXMgdG8g
Z2VuZXJhdGUgdGhlIGJhc2UgYW5kDQo+IHNpemUgb2YNCj4gPiAgICBgbXB1LGJvb3QtbW9kdWxl
LXNlY3Rpb25gLiBJZiB0aGVyZSBpcyBhbnkga2luZCBvZiBvdGhlciBtZW1vcnkgdXNhZ2UNCj4g
PiAgICBoYXMgYmVlbiBkZXRlY3RlZCBpbiB0aGlzIHNlY3Rpb24sIHRoaXMgdG9vbCBjYW4gcmVw
b3J0IGFuIGVycm9yLg0KPiA+ICAgIEV4Y2VwdCBidWlsZCB0aW1lIGNoZWNrLCBYZW4gYWxzbyBu
ZWVkIHRvIGRvIHJ1bnRpbWUgY2hlY2sgdG8gcHJldmVudA0KPiBhDQo+ID4gICAgYmFkIGRldmlj
ZSB0cmVlIHRoYXQgZ2VuZXJhdGVkIGJ5IG1hbGljaW91cyB0b29scy4NCj4gDQo+IFhlbiBzaG91
bGQgYWx3YXlzIGNoZWNrIGZvciB0aGUgdmFsaWRpdHkgb2YgaXRzIGlucHV0LiBIb3dldmVyIEkg
c2hvdWxkDQo+IHBvaW50IG91dCB0aGF0IHRoZXJlIGlzIG5vICJtYWxpY2lvdXMgdG9vbCIgaW4g
dGhpcyBwaWN0dXJlIGJlY2F1c2UgYQ0KPiBtYWxpY2lvdXMgZW50aXR5IHdpdGggYWNjZXNzIHRv
IHRoZSB0b29sIHdvdWxkIGFsc28gaGF2ZSBhY2Nlc3MgdG8gWGVuDQo+IGRpcmVjdGx5LCBzbyB0
aGV5IG1pZ2h0IGFzIHdlbGwgcmVwbGFjZSB0aGUgWGVuIGJpbmFyeS4NCj4gDQo+IA0KPiA+ICAg
IC0gYG1wdSxkZXZpY2UtbWVtb3J5LXNlY3Rpb25gOg0KPiA+ICAgIFRoaXMgc2VjdGlvbiB3aWxs
IGNvdmVyIGFsbCBkZXZpY2UgbWVtb3J5IHRoYXQgd2lsbCBiZSB1c2VkIGluIFhlbi4NCj4gTGlr
ZQ0KPiA+ICAgIGBVQVJUYCwgYEdJQ2AsIGBTTU1VYCBhbmQgb3RoZXIgZGV2aWNlcy4gV2UgaGF2
ZW4ndCBjb25zaWRlcmVkDQo+IG11bHRpcGxlDQo+ID4gICAgYG1wdSxkZXZpY2UtbWVtb3J5LXNl
Y3Rpb25gIHNjZW5hcmlvcy4gVGhlIGRldmljZXMnIG1lbW9yeSBhbmQgUkFNDQo+IGFyZQ0KPiA+
ICAgIGludGVybGVhdmluZyBpbiBwaHlzaWNhbCBhZGRyZXNzIHNwYWNlLCBpdCB3b3VsZCBiZSBy
ZXF1aXJlZCB0byB1c2UNCj4gPiAgICBtdWx0aXBsZSBgbXB1LGRldmljZS1tZW1vcnktc2VjdGlv
bmAgdG8gY292ZXIgYWxsIGRldmljZXMuIFRoaXMNCj4gbGF5b3V0DQo+ID4gICAgaXMgY29tbW9u
IG9uIEFybXY4LUEgc3lzdGVtLCBlc3BlY2lhbGx5IGluIHNlcnZlci4gQnV0IGl0J3MgcmFyZSBp
bg0KPiA+ICAgIEFybXY4LVIuIFNvIGluIGN1cnJlbnQgc3RhZ2UsIHdlIGRvbid0IHdhbnQgdG8g
YWxsb3cgbXVsdGlwbGUNCj4gPiAgICBgbXB1LGRldmljZS1tZW1vcnktc2VjdGlvbmAuIFRoZSB0
b29sIGNhbiBzY2FuIGJhcmVtZXRhbCBkZXZpY2UgdHJlZQ0KPiA+ICAgIHRvIHNvcnQgYWxsIGRl
dmljZXMnIG1lbW9yeSByYW5nZXMuIEFuZCBjYWxjdWxhdGUgYSBwcm9wZXIgcmVnaW9uIGZvcg0K
PiA+ICAgIGBtcHUsZGV2aWNlLW1lbW9yeS1zZWN0aW9uYC4gSWYgaXQgZmluZCBYZW4gbmVlZCBt
dWx0aXBsZQ0KPiA+ICAgIGBtcHUsZGV2aWNlLW1lbW9yeS1zZWN0aW9uYCwgaXQgY2FuIHJlcG9y
dCBhbiB1bnN1cHBvcnRlZCBlcnJvci4NCj4gPg0KPiA+IDIuIFVzZSBhIHRvb2wgdG8gZ2VuZXJh
dGUgZGV2aWNlIHRyZWUgcHJvcGVydHkgYW5kIHBsYXRmb3JtIGZpbGVzDQo+ID4gICAgVGhpcyBv
cGluaW9uIHN0aWxsIHVzZXMgdGhlIHNhbWUgaW5wdXRzIGFzIG9waW5pb24jMS4gQnV0IHRoaXMg
dG9vbA0KPiBvbmx5DQo+ID4gICAgZ2VuZXJhdGVzIGB4ZW4sc3RhdGljLW1lbWAgYW5kIGBtb2R1
bGVgIG5vZGVzIGluIERvbVUgbm9kZXMsIGl0IHdpbGwNCj4gbm90DQo+ID4gICAgZ2VuZXJhdGUg
YG1wdSxndWVzdC1tZW1vcnktc2VjdGlvbmAsIGBtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbmAgYW5k
DQo+ID4gICAgYG1wdSxkZXZpY2UtbWVtb3J5LXNlY3Rpb25gIHByb3BlcnRpZXMgaW4gZGV2aWNl
IHRyZWUuIFRoaXMgd2lsbA0KPiA+ICAgIGdlbmVyYXRlIGZvbGxvd2luZyBtYWNyb3M6DQo+ID4g
ICAgYE1QVV9HVUVTVF9NRU1PUllfU0VDVElPTl9CQVNFYCwgYE1QVV9HVUVTVF9NRU1PUllfU0VD
VElPTl9TSVpFYA0KPiA+ICAgIGBNUFVfQk9PVF9NT0RVTEVfU0VDVElPTl9CQVNFYCwgYE1QVV9C
T09UX01PRFVMRV9TRUNUSU9OX1NJWkVgDQo+ID4gICAgYE1QVV9ERVZJQ0VfTUVNT1JZX1NFQ1RJ
T05fQkFTRWAsIGBNUFVfREVWSUNFX01FTU9SWV9TRUNUSU9OX1NJWkVgDQo+ID4gICAgaW4gcGxh
dGZvcm0gZmlsZXMgaW4gYnVpbGQgdGltZS4gSW4gcnVudGltZSwgWGVuIHdpbGwgc2tpcCB0aGUg
ZGV2aWNlDQo+ID4gICAgdHJlZSBwYXJzaW5nIGZvciBgbXB1LGd1ZXN0LW1lbW9yeS1zZWN0aW9u
YCwgYG1wdSxib290LW1vZHVsZS0NCj4gc2VjdGlvbmANCj4gPiAgICBhbmQgYG1wdSxkZXZpY2Ut
bWVtb3J5LXNlY3Rpb25gLiBBbmQgaW5zdGVhZCBYZW4gd2lsbCB1c2UgdGhlc2UNCj4gbWFjcm9z
DQo+ID4gICAgdG8gZG8gcnVudGltZSBjaGVjay4NCj4gPiAgICBCdXQsIHRoaXMgYWxzbyBtZWFu
cyB0aGVzZSBtYWNyb3Mgb25seSBleGlzdCBpbiBsb2NhbCBidWlsZCBzeXN0ZW0sDQo+ID4gICAg
dGhlc2UgbWFjcm9zIHdpbGwgbm90IGJlIG1haW50YWluZWQgaW4gWGVuIHJlcG8uDQo+IA0KPiBZ
ZXMgdGhpcyBtYWtlcyBzZW5zZSB0byBtZS4NCj4gDQo+IEkgdGhpbmsgd2Ugc2hvdWxkIGFkZCBi
b3RoIHNjcmlwdHMgdG8gdGhlIGltYWdlYnVpbGRlciByZXBvc2l0b3J5LiBUaGlzDQo+IHdheSwg
dGhleSBjb3VsZCBzaGFyZSBjb2RlIGVhc2lseSwgYW5kIHdlIGNhbiBrZWVwIHRoZSBkb2N1bWVu
dGF0aW9uIGluDQo+IGEgc2luZ2xlIHBsYWNlLg0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 02:58:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 02:58:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307698.522939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nge47-00034y-Q3; Tue, 19 Apr 2022 02:58:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307698.522939; Tue, 19 Apr 2022 02:58:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nge47-00034r-M8; Tue, 19 Apr 2022 02:58:07 +0000
Received: by outflank-mailman (input) for mailman id 307698;
 Tue, 19 Apr 2022 02:58:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nge47-00034h-5w; Tue, 19 Apr 2022 02:58:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nge47-0002tv-3X; Tue, 19 Apr 2022 02:58:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nge46-0004Nf-IB; Tue, 19 Apr 2022 02:58:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nge46-0008Lo-Hi; Tue, 19 Apr 2022 02:58:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wsiC9gGk7s2ViKdTfTFWE1PIYjpqGL2p5OPcnj8bonc=; b=FAS3B8fwCVGVxumvNfJtNekDeD
	GwyOrqNbxaHiT1VylwZqRgK/e+lF5VeWXUUxJ2sa9+d86hTF0/UorELxV2c9oSRTgnpITJfyP7CuY
	lS2SXQ4i8JUIJFUNfLkwBoFZMBPgjOeoZ3dKz5HYo76GFaLUYE/Xud2rYLZ5Tf/7l1dM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169527-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169527: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 02:58:06 +0000

flight 169527 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169527/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  496 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 03:58:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 03:58:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307706.522950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngf0L-000192-1k; Tue, 19 Apr 2022 03:58:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307706.522950; Tue, 19 Apr 2022 03:58:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngf0K-00018v-Ux; Tue, 19 Apr 2022 03:58:16 +0000
Received: by outflank-mailman (input) for mailman id 307706;
 Tue, 19 Apr 2022 03:58:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Qar=U5=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ngf0K-00018p-1Q
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 03:58:16 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on060b.outbound.protection.outlook.com
 [2a01:111:f400:fe07::60b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id edd78f53-bf94-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 05:58:13 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB6PR0401MB2280.eurprd04.prod.outlook.com (2603:10a6:4:48::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 03:58:08 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 03:58:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: edd78f53-bf94-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ms5MPjiKHs/bSApzkHqv1Ogk0aPJb2izRpxIikKp5v4RkBfwANCf4jO03cLaUXDaoI+m/92DUrhHqrUC03/TphhJcbVLFFssDiNGmsNISMSgrzYz7XPgki+aZT2M1egjImXfznuVroJF6RojdbN4BhZN09d7z5hgky6yCB0ffTJ4+cMBeAVer/F/X8JESiZ4nE7rajCPTdDMGVCo2MSFAqD3MfLoc+Ji0ptPNkJwWV0qRQTMVZBR1A59wzI5EfHUkE8CT77tJ+jYl2sEy/rO3nflYxJ4Sl4cRwAIoWKgS2DvF2+b34n2MTDAOIxJ8Ug5sp6SnFc8+Qt9bzp1NK/c0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NW+IeDtv+aHj2fsuq/n5j2nV/+ehu+PafuZidkG7D6s=;
 b=P8fdRKT2SP0BW9Y1KK4TaIN//+QyOi4XEje12NY84k6FJ5MP5U/WF1dMcXVpDTYzfjzddCvNafp0RK/TA34oExbvIGHJ1VFuYLleXATe0rAbulC1Mx7OO1TdgM3vuan+F7AsbsvLbi3tPimyqoZuvQW11rd0SqD5FWDlrmYk75bupeeRG32gUo9L5gXLcoXAdyUmqLrd2w0B1bVxtqgfUy1foi94QgAD7KZNHpPhY+9QzegvzghdyoEVF0/zTB9kYtxhw1W5oPYJhsQJ+HqavUhSv0lIQRvFYePP1KO364BXKY6JJAZ8Kv1Y4wRdPSw0RXXSuwQhwHdXTMQlgIBKwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NW+IeDtv+aHj2fsuq/n5j2nV/+ehu+PafuZidkG7D6s=;
 b=UL3xsmXhqSlKkPZI3hdtFr2BmrUAyRZthIn6K3vZ/4vt3VAnt0vTUluBUQy5KB/+AI2LGN9XVmfbzpQJUxRYlpsiYas/sRzI6bYhS17lcJR5R7s5VHBH/F1nNBkL6R507cfN3++VwsD3Cl3r7kSOgI2wesGltGzrk+LsWaW0qUw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V6 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial support
Date: Tue, 19 Apr 2022 12:39:25 +0800
Message-Id: <20220419043927.23542-1-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR01CA0052.apcprd01.prod.exchangelabs.com
 (2603:1096:4:193::11) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5646a5d4-e64b-4a48-a4e9-08da21b8d061
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2280:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB2280189935967ACD6306D75DC9F29@DB6PR0401MB2280.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3si1hs+XLkBHZd9JHFoXkZvO96/b82V+lTSE8iXhXEXo5jQK3jwCYnIasrYbXthbxayD6LnUPrKareZfOZXMmcuVhSslqFOT/TKSUVXAZSPsDmHJRwu714Ncc0hY5VrwqeqgijGlj3pSrhMYhq0GTVObytmgUXgRhQ++c7rY1E3UZ8oViiVTzhl6NSGBarxMi1fmaOj+KXTmCFVNekGESXG4GzqUEMCsU4QLGO6qvpraLSBvKzKapCNkrN5AY2R2Gnhk2RgaZ7WAeC+j/wPo+ARveJkYt3TVrB6sOM52CVUuPA6UAl4jfN4WKN8ppfjoVlBzfRO4uSMqjJYCXD9v0LcMCoSMURc7pwWRzj89AT/vbZboAnBGx6FldJV3WMu6r5ustg9CnMQoFKdIY+xCngvo9S2HEJman/gf6GROI74Xi8UwxxjNb6jEdvfo3Koupt9VsU2WAyOaInpOhCbmH/X72giqgrlO2Neoz5D6OIU7udGhKOazcXYlb/wes3NxijC3uMMuI9405VR30VOdultcGBmJxHr20fq4nxQIja4/2LaX4fSBDfYaPTrpFx2THJ6RReWEj4rB5eYt3dxYYISdgfVS7zw6yJzE5wg5J8Xc8oU6EIS6BD+h0c0QoYxjdBCht2mEP2sJB5RuYzqpPNkjRnw5kr9+BUD+mZ7KTDcp4ZBnqgypvW4Gm5l3TYgfgKsnpFAvkDo0VOO03JpGNQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66946007)(316002)(38100700002)(38350700002)(66556008)(4326008)(8676002)(1076003)(2616005)(86362001)(6486002)(6512007)(508600001)(186003)(26005)(8936002)(5660300002)(7416002)(6506007)(52116002)(6666004)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9D9fPAE6eq0e5k86EyWY2pQUCxZxt77+J28LPX5NhO/thxauuaQm4QbUneiP?=
 =?us-ascii?Q?vEo34r3dYSg5EaNqqHN7QKYRSRfFe3dSBgXJBZKeUkPYqzERJDr5LNbO6cQ6?=
 =?us-ascii?Q?lPogXjYVRSPzwkdI86WVmKDstpCDZkMLYEy0g8wBKmE9ZeLeyzEgbISUlVVt?=
 =?us-ascii?Q?4ssshZP/l/u3DKbZdGaRUs3uaNfxuJrmx9ezwNti+Y3M8syst9zohakeYBIX?=
 =?us-ascii?Q?oSAq1M7hpD8hao4CGzTpOz/Sagaw9BM0WJEX87TTbUJ/GDM4242Ca2OIuVPW?=
 =?us-ascii?Q?PIdx6vbGeofBjLQXtSqCd0h0F4zj1F1Lmj0l4ECebcwdiDxN0ivqwPE1YtKw?=
 =?us-ascii?Q?1X7kGmTZobMFSY1QCZiZKHiZ/QF7F2NZX/DsxFIFv0bf+sHc+1ZN91PC4t7+?=
 =?us-ascii?Q?GYzaPvy7DESi8Z437CYpNHDyz46qsf81rdNbiuikFP1psA/LwpHn0qXXXvUC?=
 =?us-ascii?Q?v2SOq/g3crzXDuthzjyoNdWxY4j1t8d7Ewf//V7dkURSUiMEU0Fi6SP9RVzR?=
 =?us-ascii?Q?R1HbeSYF4uw9PxpMg5WVAYDcnc3AcASLOsakE8yENffXazpLRPFIy5MPOmJf?=
 =?us-ascii?Q?CJYcL8NuvkVpth1ZaQnuEIM//mTc74msmmMD4SPISLozZs6BY9jJ8lLzAe/M?=
 =?us-ascii?Q?61ImXBRbDTS03xszlq+TCqc2BDIHU49DRCBkAbIt/1OJznl2kgZvxUKMqzHb?=
 =?us-ascii?Q?1RGJ5AJ5OlrFg1PwZo6djmoJm2DUKNWlh+a5eB1n+VV6mE1tjW6CqMpuaZUk?=
 =?us-ascii?Q?PNRIALLUuzuY8iCcu7cfjz2TIyRxTak+pObHW5EilfFocdr16GUMvKwHS9Vg?=
 =?us-ascii?Q?OBId46RYmVH6hlEAwvS9bV/M5uxOYxDjXJ98+ucjRB8xC0xuS/BZfj2ck5kY?=
 =?us-ascii?Q?10tCkOyrg+8KxJq3ksgYIi1+z2xyOUMhHITvA3nUccGhfEsFwSdwNWPeNhNj?=
 =?us-ascii?Q?6PzT+4QubMdlzoTTaveGrdz7lTbQ51Ewq/qHEcyPH2BGpfMn7AXEW3uagNfQ?=
 =?us-ascii?Q?e4KivFl+qjkiMfm4km3r9zizi81rnwhg3vyC48edEmPFzlaSalmVimvRpq/K?=
 =?us-ascii?Q?tdIWXuG4zxlRgFEzmXcQZ48wttXSofE+JXV2h0heJzDueaiP/0h+7bTkBK4c?=
 =?us-ascii?Q?EA9yYUruT3cznSnLCoChG825i03NUmQbgH/RRayGo7M245nnHg2thb8827gU?=
 =?us-ascii?Q?h/brPNMYObnARDXZ5hpbAcrSKY6FcFrk6Hav5+OQYcMyRf1koBznnr6xbz2C?=
 =?us-ascii?Q?6BowPIKEMCVCm9mmTRacD1ObdllLk9rUZv0ighG8FwrU8OCfcVM5kSEYEd67?=
 =?us-ascii?Q?F3QfxhX/WBKCuKE/rmXCLbZvUf8CAjLArPR78d+c04Led05Tgw0FQorPucNW?=
 =?us-ascii?Q?QuXoDU9IEPznwXhjvoEX0p1Tjpt8Hg2pmHfnMmTeagNoKLz8Tz+HTbMhXV33?=
 =?us-ascii?Q?jyg3PmvWyjxr0W1GHIKOmmptspZk/Lpn8b1bQFf4+VMI2OFNqhoNi/82Bah7?=
 =?us-ascii?Q?omw/MGyafQGu8w4urwnGhEJwqFRXLn5jNkYqW96yXhRj+r/wnAhrQaisEMst?=
 =?us-ascii?Q?i/Bzl/fAaD2bI1JRStomuoE0sV06ITThKG3B1JLxYR523YmGGuNEWiuomIX3?=
 =?us-ascii?Q?ENXpLNC0s6cQCOI1xyaBWO1ddpxRR4GgwCtIdIz3r0fBZ5C/85PQ7z+6i9xZ?=
 =?us-ascii?Q?M2JEcHCkhpkPYMUGRuuBzavjimwYhOUU6FOXaDdMTXUBDELMWwZpnH2/uDMH?=
 =?us-ascii?Q?3qbvS2NTmg=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5646a5d4-e64b-4a48-a4e9-08da21b8d061
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 03:58:08.3542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UFrm+teSHxIacgwGVLLNPb5x72qWRGu/s/7KW11/0DGK6fcvgwmidvRNLm+RpimduCgPuHokXwpnlDwjnr4TOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2280

From: Peng Fan <peng.fan@nxp.com>

V6:
 Fix a stale variable check per Stefano's comments.

V5:
 Align code
 drop early_uart_init

V4:
 Wrong v3 version, some BIT definition are mixed in patch 1,2. 

V3:
 Addressed Michal's comments.
 Add Henry's T-b

V2:
 Per Julien's comments, fix coding style issue, drop unneeded code

Add i.MX lpuart driver and i.MX8QM platform support.
 - lpuart is the uart IP used in i.MX8QM/QXP/93.
 - Very basic i.MX8QM platform support.

Peng Fan (2):
  xen/arm: Add i.MX lpuart driver
  xen/arm: Add i.MX lpuart early printk support

 xen/arch/arm/Kconfig.debug              |  14 ++
 xen/arch/arm/arm64/debug-imx-lpuart.inc |  48 +++++
 xen/arch/arm/include/asm/imx-lpuart.h   |  64 ++++++
 xen/drivers/char/Kconfig                |   7 +
 xen/drivers/char/Makefile               |   1 +
 xen/drivers/char/imx-lpuart.c           | 275 ++++++++++++++++++++++++
 6 files changed, 409 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
 create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
 create mode 100644 xen/drivers/char/imx-lpuart.c

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 03:58:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 03:58:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307708.522972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngf0S-0001iY-MF; Tue, 19 Apr 2022 03:58:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307708.522972; Tue, 19 Apr 2022 03:58:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngf0S-0001iP-IV; Tue, 19 Apr 2022 03:58:24 +0000
Received: by outflank-mailman (input) for mailman id 307708;
 Tue, 19 Apr 2022 03:58:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Qar=U5=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ngf0R-0001gE-Bl
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 03:58:23 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on0612.outbound.protection.outlook.com
 [2a01:111:f400:fe07::612])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f32f76e3-bf94-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 05:58:20 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB6PR0401MB2280.eurprd04.prod.outlook.com (2603:10a6:4:48::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 03:58:17 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 03:58:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f32f76e3-bf94-11ec-8fbe-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NokNkjQgXjeU0q4+ieTn2/tYXsOVscHqhLIkkc8DnMTivIhHd/GdlT4Ik5jUS+A/sSRnKM8iXhXWn44ihoaxD8MZc8VJqs1mrCceWF2EUMA7W5/rcV2TzZ0Uf6IXZ2yKbHi3BjPvGWvfWOV78dCJij8PQk/IM7qp/STV0CEQg+K+KJ1T3NcApCZNayuVfv3AHK5PiS2h3hzvcTOYJCBmY7gO1gznSVeecQQa04/y71fNulC03V0KBMNHVF+Z8HcEn+UTmElWeLDs5kkjJR4LxVQ3W8QNP4h1CmdcDrG6J4ojDVNH2epp4KQJq2URXzA9QQ9BKXqs4RIYIbOmJ7EmIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1QqFMtw5JqTtw6Jd6dkBHTwFJGE0lWl5lR8Rfrbsrcs=;
 b=aDD18Rg8nFeSZ3UyhM/y+RA7ttSFruXJYwXWxnZtWpIJSBkJAi+cq+Y8HL3a84kBN3Qm7yF+zAACbg8QGpNPJFvHvzujuOwyxNH00MHFIkBhwTpOjkmR2icFwZqhETg9eEQ648ZPizkIsRzFTCjwHBrla6kNkQ2L8VOOkbmnZAvnVET1lDSl7YCiaOuwFMWZjD8Oab/M3hYH7OnH4kMfkPOR5kx8o2H8Zfhdjsc379Axv/OZ8W9LjK41/7O/rI+2DZw3bTuNzdiMnJ9X5Xem0I6v7Ft4aoEMkf7gIMFJ9hjJLykKBadewG0NsZJklBofgENoNWU/VU3TOrt6aqsXlg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1QqFMtw5JqTtw6Jd6dkBHTwFJGE0lWl5lR8Rfrbsrcs=;
 b=UhhbzYelBYXvXpWMcKkr93zuRqaygNKCYL3hW/Pe5RbhoUPMeG2lfXbdfWS5qz5fewe7nqj7TvMwAXKXtlFM/kZM8bRdN2hoR/OSB0jn+3nGrlU4oQqtOeWtmqdPRcLLfhUgedEC4rbV8DKXHQxp+jaqdnrr9JyoBu+vJPQ8RXk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V6 2/2] xen/arm: Add i.MX lpuart early printk support
Date: Tue, 19 Apr 2022 12:39:27 +0800
Message-Id: <20220419043927.23542-3-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220419043927.23542-1-peng.fan@oss.nxp.com>
References: <20220419043927.23542-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR01CA0052.apcprd01.prod.exchangelabs.com
 (2603:1096:4:193::11) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a50d6403-c86f-4e33-dccc-08da21b8d624
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2280:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB228060EC1A3123872E467DADC9F29@DB6PR0401MB2280.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EmWWVXJfKTOfceRLFZ2s2G7Y1P2LFh/hAvODm5fiNH3gggDVWySMJMNTBbiyP+8XC19AzwG8uFmGieN7svG02Y7/t/r+Af1ffPaAYyewlTjBRYkEUCM/p14Rm5GxK9ttJAYlLogcgq/fH22hPGHibZQ5X46vpd+2z6SKBnClNfeAf+BJRhgzho12f8ilVfBYjanVRRiFJhPHooSn1ZRb/xtANv3OQutcHhi7WuHsT0S6A3daMdANFqDoAwB3zagclFYlK4d42jHXjPNdRxmML7cKN7PEwFZx4hOp9VgLBLDpjBosU/u9QtftPhczAUh9L1Lh0FOrgCyKuq2xQA6cig8pE9Rd7hoxuvXTNuCTYFwgtk8Qq40qSY1FX6uuXANqtb8B+k4BI0DFWSHkQ3GCBumY697mFPMlf/MfSVEpISVGDnmlMU+c16GlHdZS2qzv5uqYu2R7+XBAkHtKxM/AZig/VAEPw7TAhZq8hpbvBmMVDldmlUs9F8ILTljFYp5KERaB3hbCntMyZ+HjEuCmrFJcwXN3SDAijYXwBkyccOMcLfd9VDBC3SSyFzSFRk85f+eCR7M0vCVMlJor2eet0GxwZsmrA/LWBGGiD5VIjC/2lXuyQeTkCjcBV2EreXCzADWOl3g1O6jL6TqsEcyfC5nYxd4D6N6y5NNgXezKKHZS918q9gmVolLD4RvEgDG12s3BSKkI2u2lnOqywaEC3r08sEnA55MsxR7J9KlSJ2M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66946007)(316002)(38100700002)(38350700002)(66556008)(4326008)(8676002)(1076003)(2616005)(86362001)(6486002)(6512007)(508600001)(186003)(26005)(8936002)(5660300002)(7416002)(6506007)(52116002)(6666004)(2906002)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cFfs4C0rjaAXJdhbVcZIfKu/WwtfYAFfaQzgGIHYQHKQKgtuaPhe7VAvcl/4?=
 =?us-ascii?Q?9GF2S0QjC2XVZavfdyBGldZ2dr3Sr845Pow8PrE0uxIeZh8Wvs+24yqpRFoN?=
 =?us-ascii?Q?L5ckKdMEjW57mhQFVo0nvDzaCVViR2tcTLpps9U4nkHwoevgCrs7eYnrcsCA?=
 =?us-ascii?Q?NUrjTrEdw2HFe6ptkmMsqqTbcpn37zfKsmKnBZAQbC8Ze1o12tLVBUhxElNH?=
 =?us-ascii?Q?W8qdRYxJb2kHmYTJDllTJQWTAWKrFqdor1tIPTKdPcDI8bVz1Y+YdmnRJEeb?=
 =?us-ascii?Q?4UfSMOuYMn+wJmLRB/EceZdRHT3SjzkoFSHfSWWVcmvZiJHI/65wJIAYpGpY?=
 =?us-ascii?Q?rwTEVsYWwx+t4e6qysLJd9aYgrfPMv8FqtK7chDECy8ifmAMMHqzrpNrijrI?=
 =?us-ascii?Q?7zyKdsfUtQduhBInw2WlmQcPdIraERxNZelV0/G7bo4uTSUFMwJ3YlSoxpev?=
 =?us-ascii?Q?VU8BlLdqRr/STHZ8W23HtriAmwydT2+Z1xFBmhJAXA92JZ5z1zhNVIXu6WG4?=
 =?us-ascii?Q?CdEyeTb3wdq21Lnzv532KJvjPhdTCO2zJR8At+PLNoHcxceb3Nqg17D3TRqe?=
 =?us-ascii?Q?ct6C1/gx+UZLtswfLF9ZQNd4go1TDnzZkg24Pz7/HKBgNzWG6TSg7qF3e+mb?=
 =?us-ascii?Q?Mo4AnccZR+Au7os20uksUMwRx+F/1FxkkBQwYBDEu+HY2A21ocToN1LcHtP/?=
 =?us-ascii?Q?xS+/FaScFlb4AZZ6/xqKKn4GVBwhIyMDDorqsxQlc2Jxd/f230C5H+F+3o9S?=
 =?us-ascii?Q?BjoBreWZ5E94R2ryXWIpZHDdFUaP0H8p7jbURRc9VLcXET7eSvBzKa02jUUR?=
 =?us-ascii?Q?XfdcRmKQTuY/tnSayRZjgxy4AlmJPNam86V2agq6siZfCmezT0YMmlIqADNl?=
 =?us-ascii?Q?KIp75m18YiYelC24i3JUSDLPbuGkpFig2inMqu7W78A2oC+Ul/+69WtPq9Ew?=
 =?us-ascii?Q?dq3YuyExr2CtLSG7nJLbbJN8BUODofHXmTp4HZLATQyxo7dHVb2q9FWrqycm?=
 =?us-ascii?Q?D5Ib3MWp8IhFTqjcz7FMdAIJuE8YCTPLYdtx182AX1qbEFjNZAibbwzrEyrz?=
 =?us-ascii?Q?ADXmcfIBaS3g+yNfcXXH15vVz85OMCnEHO5586sti1jpS45sidG3a8qztMu4?=
 =?us-ascii?Q?756gDwJ6Lr41S81jyGA0/wpJgM+qjQRDhEz8KCRVlkx09UXCg4NE4DfIpG0c?=
 =?us-ascii?Q?A6CYlzS34wGgZvwQAPNUOvj5PXhg5C0d/opX7Gh5v/SIOvyXCOwzlLEixPem?=
 =?us-ascii?Q?n4TW7CYfHZ3H6CninpvjB3k3AUlKgCRFPqNjm9DXIoxC7pbSOOONn0ueJ3Jf?=
 =?us-ascii?Q?dgixTw30MHeSH2rcEAdIC5i21zJ2e8wF/xQ6dXNIWvgO/ZrEdZ1BCLKTKZvE?=
 =?us-ascii?Q?1MlAiwcL35YFVTcX8y+NtnNpwRGa1aDBazXuyeFI8IKzBnumwvjGXio/py0a?=
 =?us-ascii?Q?KJStVk2OCT//K1weDse5p6ksixbC0RQOaDicp3MkR8YBuV4kTQebNPbJF+Gv?=
 =?us-ascii?Q?L79owxCZyBlYKXEEcoY1Qb/sXLHrEds6M0ifxEa7L6+F6VFrcYnEyWGZfoaS?=
 =?us-ascii?Q?9+GO2KFs4ybdytFcCXsRSXvRhp/YQQSeBqlM6/lSU9gu+Mtu7eG67dt6nybw?=
 =?us-ascii?Q?zHkuC9ULAGhvmjKrJwtenpEtEmjvX/Q8tl869wkgv2p7ktOvBcKBy/EgDyVR?=
 =?us-ascii?Q?/VkOC71Bgao3ChqhoGdwxKej5mwIhUz8Vkf5rGjw5NQLepT7uMkgurYN0m4X?=
 =?us-ascii?Q?v4UaH3rpLA=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a50d6403-c86f-4e33-dccc-08da21b8d624
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 03:58:17.8805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MSsgpO+r5e5W6DLtFyj8O7aU3k+CA1EPn858AOoVbKu5rl+at+oQXjJgPgmXa9bQJl2KjasrIpIXNt8AavM6Jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2280

From: Peng Fan <peng.fan@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/Kconfig.debug              | 14 ++++++++
 xen/arch/arm/arm64/debug-imx-lpuart.inc | 48 +++++++++++++++++++++++++
 2 files changed, 62 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index 35ccd13273..842d768280 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -58,6 +58,16 @@ choice
 			This option is preferred over the platform specific
 			options; the platform specific options are deprecated
 			and will soon be removed.
+	config EARLY_UART_CHOICE_IMX_LPUART
+		select EARLY_UART_IMX_LPUART
+		depends on ARM_64
+		bool "Early printk via i.MX LPUART"
+		help
+			Say Y here if you wish the early printk to direct their
+			output to a i.MX LPUART. You can use this option to
+			provide the parameters for the i.MX LPUART rather than
+			selecting one of the platform specific options below if
+			you know the parameters for the port.
 	config EARLY_UART_CHOICE_MESON
 		select EARLY_UART_MESON
 		depends on ARM_64
@@ -186,6 +196,9 @@ config EARLY_UART_CADENCE
 config EARLY_UART_EXYNOS4210
 	select EARLY_PRINTK
 	bool
+config EARLY_UART_IMX_LPUART
+	select EARLY_PRINTK
+	bool
 config EARLY_UART_MESON
 	select EARLY_PRINTK
 	bool
@@ -283,6 +296,7 @@ config EARLY_PRINTK_INC
 	default "debug-8250.inc" if EARLY_UART_8250
 	default "debug-cadence.inc" if EARLY_UART_CADENCE
 	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
+	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
 	default "debug-meson.inc" if EARLY_UART_MESON
 	default "debug-mvebu.inc" if EARLY_UART_MVEBU
 	default "debug-pl011.inc" if EARLY_UART_PL011
diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
new file mode 100644
index 0000000000..b169332932
--- /dev/null
+++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
@@ -0,0 +1,48 @@
+/*
+ * xen/arch/arm/arm64/debug-imx-lpuart.inc
+ *
+ * i.MX8QM specific debug code
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <asm/imx-lpuart.h>
+
+/*
+ * Wait LPUART to be ready to transmit
+ * rb: register which contains the UART base address
+ * rc: scratch register
+ */
+.macro early_uart_ready xb, c
+1:
+        ldr   w\c, [\xb, #UARTSTAT]   /* <- Flag register */
+        tst   w\c, #UARTSTAT_TDRE     /* Check FIFO EMPTY bit */
+        beq   1b                      /* Wait for the UART to be ready */
+.endm
+
+/*
+ * LPUART transmit character
+ * rb: register which contains the UART base address
+ * rt: register which contains the character to transmit
+ */
+.macro early_uart_transmit xb, wt
+        str   \wt, [\xb, #UARTDATA]  /* -> Data Register */
+.endm
+
+/*
+ * Local variables:
+ * mode: ASM
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 03:58:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 03:58:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307707.522961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngf0N-0001Oc-Ap; Tue, 19 Apr 2022 03:58:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307707.522961; Tue, 19 Apr 2022 03:58:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngf0N-0001OT-62; Tue, 19 Apr 2022 03:58:19 +0000
Received: by outflank-mailman (input) for mailman id 307707;
 Tue, 19 Apr 2022 03:58:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Qar=U5=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1ngf0L-00018p-El
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 03:58:17 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on0601.outbound.protection.outlook.com
 [2a01:111:f400:fe07::601])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f0da61bf-bf94-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 05:58:16 +0200 (CEST)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB6PR0401MB2280.eurprd04.prod.outlook.com (2603:10a6:4:48::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 03:58:14 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 03:58:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0da61bf-bf94-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lFiHHvj9ejnuAhU7kyrWgpG2Gc6YMHm3y+EQKikp6L4eI5guNyyxiRhNAoMH6stxuYbRWny5AJDVnzht21iHnN3OEXSh1kIvA1DyCD+Li6eI1hSWw6iypeWT/D0eLthiKbxdoLWUVE05bwKKRIAYQ6CsRfBw86ELycT9i2yUVn9o3DewdoSDm8uhuEHjoQb+/St1N1meCCMa1rB6oefGUmeGgr4OzUQVUMDVfIMLFM0uUuurF7DG0GMATmexDSCvq6M+RRU9gkmd1lefhY3AL89sBz9Mbnoyqouco5mJ7i+/JIgacJhEYLiCG5cyD8AQJLpYq3v2X4FzPDDbaYDWyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HB7FHGMy0DRrx8MRkr42iYpWGBdzJjb/gHU7cgqfC0o=;
 b=DXbNpagu9QV+CSPQnyOSxAecxX9LMYjGzaC/17rP3yHy8V1Zh5bMTZjrVTY64yBTbrGmGdopJ8kynHvBslFZt1Cv8GmLK+DBf1DKpvoNnf76POjseCAWSDxXLD9mEC7q86R/uPpixMHBLMpIay7R7YXC34+0auc1Y1tkHnfVa4Rw/Hkt+cOnRKLut9UjXSa3GY5yKRxIzDOiP9UXIG5iwNwShz06fOrlmNkcIr9Xz2AsYWJRorkbya+hZ8e6/d8bvVNsn6Fc2tAi6ACQnQjidJT3Ge0Pq1Ndpe1EB0MDOeyX/X5LK2CmPZlW7h5GQDyx3gdl0ogBN4JgGQ7mB2QWhA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HB7FHGMy0DRrx8MRkr42iYpWGBdzJjb/gHU7cgqfC0o=;
 b=hZO6dYzW3iZzimY6k4+v/WCutuijtdt5BW8dfN1Chctp6J8kIgqt1YombYOuB/cI5y2JLAU+gPtkFCssoteqhPHwerJYRSPW43KXkh6eizX+Gx+a2BIIMyhBEuTu9ys6RiH++fCtk3c3fDs/9EShePsYMveBrvRA1hPTXsLswpI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	michal.orzel@arm.com,
	Peng Fan <peng.fan@nxp.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH V6 1/2] xen/arm: Add i.MX lpuart driver
Date: Tue, 19 Apr 2022 12:39:26 +0800
Message-Id: <20220419043927.23542-2-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220419043927.23542-1-peng.fan@oss.nxp.com>
References: <20220419043927.23542-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR01CA0052.apcprd01.prod.exchangelabs.com
 (2603:1096:4:193::11) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 98db2f6a-6d8e-4a67-7e16-08da21b8d3bd
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2280:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB2280E19DD1148EF81FE45A61C9F29@DB6PR0401MB2280.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ty4ggYOJ6M+CGyC6f8D9HXVZ6g6Z3FSWIa38b5atzcIUQhYxaNtUGtw6/SmhHFPhc8g3lHcVmWTC1GS36estMcenfIbiRvDTsfSJR9WcFMHs7h/H6fvP4i21aSiZK1FmbcCgIY3hDPi2WRFBSl5TsSD8Mg6LWrS7oGY6z2QhGFLSnwJFy7sVkMcHGjRMx0d6vs+XTL8eWpcTRCUCN3QmESUp1DRSJmTAHv8TjU90EUiK9fcSxphV2Nnhi0mhyIfwiRGs1HiLGwiVDjxbV3MJyzuIzFevObttzNduzbH/cxFO7/ly3CBOHkabnT3c+2IvCC6Q4HjtvSlD85dh7dRz8ZE8ebAGv2GfAy1zxWLxb8Yu2FAg0tQSYIveIU+mMcIbtf8y8uQSKIIuOe/ciPObyHcXIpJF6x7sk/vu4L0kUz193KQAEvhDOS1Fkz5Udz0mD+ooWw6XVEdL0u9oAeGWe0UrQE3UFC9OEtciuS7LjR30HzitS+FoNHx+RDaQ9dHCFxDzfvRda+AqBUwgJAYJeEvcRbRjeNslpvfY7jlvGlq4GsyxiKf9JMil3vZMTmYdaqhPReztof1XYt+dOKC9qqf4lRiCBSiXlV6LsOHXSdm45luIP0egI4LsIJYP9RZ2Xk7GEXhrHiAo9K8gxwmF5wPuPFSfa3pkwHexEbviao0XgabLl2t+XYiHOJ1DNKukYagVfcEwL3ANz3ueDwhe2ZmI3HVIOjnJjQufIR+U+Tmnqhu74rmA+l+0SJaPOVSvnZaWPGKIHeN6ET0kMuNqluTx0z1LgO+JikdU+Z9S5QIcM/Icq5F0wzgj2CDOP2k8
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66946007)(30864003)(316002)(38100700002)(38350700002)(66556008)(4326008)(8676002)(54906003)(1076003)(2616005)(86362001)(6486002)(966005)(6512007)(508600001)(186003)(26005)(8936002)(5660300002)(7416002)(6506007)(52116002)(6666004)(83380400001)(2906002)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?X4fT9t3aA05AbZB55klRlED/0zH0jx4xd8gEnoPUCATQdiz4LkwV3M0fr9g1?=
 =?us-ascii?Q?nCLmpsO1ejIKv0Z/DeG5wqDPjEFGyGpzyBBxmSDtLSmYO0sObyHlWShbHVnX?=
 =?us-ascii?Q?SrlsJbORVeIaTuJ+Q5JwLpepi89ii+cMsIReydgdY0vXVFdLt8ZuW5hTw6o4?=
 =?us-ascii?Q?gGoe9vZQwsrjsH24faVxorpk4dmxTZUYfMm/s0myCy4vziBFbSKDxPG7NN4V?=
 =?us-ascii?Q?yz3XM3pQiS7D+RoycQ5HaSoNYVGUfGM9fF7O9qs47BNsgQI1q6+fOVfyXo1W?=
 =?us-ascii?Q?A0ltZaGwbzQplo/8KsyKUmXkkTAFvowD7hWb59itxvYOVcFupsdIjWGPOTCw?=
 =?us-ascii?Q?uJ8vGuuugRFvvAqv02fQlCjAf26txko4WiFT6JX/Ktf7XDjumHpOOLhq9ub7?=
 =?us-ascii?Q?kh3ldux332QOqWEKFngjtC6izkjh5a8Cdq22SDOLRbbtyGEWP/g9rIQY/oPU?=
 =?us-ascii?Q?VzyJ/XHghXOeqae4FJjWHrWkE1fV+r2AZGpbdlvFJskkv0vM9zEfxWNnYqCK?=
 =?us-ascii?Q?T6q9MqYjyWyVbPDUU6o9AguJg+RQEhkpuyQeMef3JsxMPf1xqGGWDBQjoFWm?=
 =?us-ascii?Q?FXA/XfmoOSr9wEQt3A3HrVu4ueZvTETHkQybsclrMWH2QGBj8kNg3o7XaVAW?=
 =?us-ascii?Q?9FSg9h87fnO2ZOHXq/AXLxN7fAmLRIUYftTaQH8cJa4/VZiwKSBzYsxpALBC?=
 =?us-ascii?Q?c8WqSRvjI8wVelv2OC5u4dHMSbx+Y3Qba+VRREvl1tLskugZQ+y39gZbDVqE?=
 =?us-ascii?Q?tQP/+QtJulnNDQTnEI2N+Z8pEXN0gfIS+wt9vSfiXOJ3qroDJMDum+go44rM?=
 =?us-ascii?Q?QBPUImtquepId3v0Hz4BBU7h+peowVYV9H6hGl1/Pltcjb7+Lo+l5K06vL3N?=
 =?us-ascii?Q?RIoZj/qAiPHughg9lhrsMRZ72COrJR01xaoDdcje6LSNGARkBfq5he1FMjsF?=
 =?us-ascii?Q?KdEixNRQMe1gkLFBeKUH2zWlDZHg3aYqZfmFIWZQ5f1GwXW+vkT/jsuve2pN?=
 =?us-ascii?Q?9SL0nBB08TtDG4UZh0gbwZ+oUmFjcKwqCovTEpLluNSqLwOd/hgfY+CNICz7?=
 =?us-ascii?Q?xBGqaISCZQLqHa4548APf2ZO8qMpd9bUPItzncuGjtybY5mDS+GYHg2jfpFJ?=
 =?us-ascii?Q?VOV9n+6YLzd0o3f5SXKfVHF9w/afw4c6G9p7YR/9cqOsYYTsVL497XqFVVfs?=
 =?us-ascii?Q?dWwwikEKB6Yd8+voF+TncUrIdjNRcYSKIupMu91OjbNOGlahZyWJZqwI205Z?=
 =?us-ascii?Q?7mTxjflQKjnwJ6aFSsrKcFDJNVFxWUhUDahJVil7rwm/4DMJHhiO/GXIBeWE?=
 =?us-ascii?Q?wIzLfUMbPSQV8XRZXesm0DTbX+hGBurwKzsx3aIOSaAFYDiuXN3e6riE8sPT?=
 =?us-ascii?Q?WXv2JGcqEJROaaK/OoNWrTNscccNLCXWfvcTXu0h+cdiLsFX0Ha1WQnyAKyU?=
 =?us-ascii?Q?luXJRBcgjOWO35KzKLF99+AJ7rgaBJYGxt9Xpv7ZhMTOP3C45OPXOdMdRXqd?=
 =?us-ascii?Q?IqKRidwkO3PLQr0FFvldYHOjcbsMp/Y6yDEPHb2l0oQmSMHeQCNq3jD0Fw4A?=
 =?us-ascii?Q?ImVzGAdKWBJXQY73exF8LgOsgMf+W4mr+EsgbDUGEzrspgeeeNFGxU1xUaSI?=
 =?us-ascii?Q?JBiWU2GJXsrGWzdVxvGoWFk/PhRpVMHidOkbtv7um++uoPPlUDSMCExfxYXu?=
 =?us-ascii?Q?IZgSFLqTNTuY3cw/17PmuAdkeKL02LLrYxpNwacidbGcP/0eLX4Um3u95n6U?=
 =?us-ascii?Q?croumJrutQ=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98db2f6a-6d8e-4a67-7e16-08da21b8d3bd
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 03:58:13.9580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1d6qE92Wpybxzwe2D+UmCTzsZFHBiplIP9ZAnjYhaGKtK2rCMBOOC7SWgVUXWwFh/eJ32JXxwk4I+jtE5p+Yag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2280

From: Peng Fan <peng.fan@nxp.com>

The i.MX LPUART Documentation:
https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
Chatper 13.6 Low Power Universal Asynchronous Receiver/
Transmitter (LPUART)

Tested-by: Henry Wang <Henry.Wang@arm.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/include/asm/imx-lpuart.h |  64 ++++++
 xen/drivers/char/Kconfig              |   7 +
 xen/drivers/char/Makefile             |   1 +
 xen/drivers/char/imx-lpuart.c         | 275 ++++++++++++++++++++++++++
 4 files changed, 347 insertions(+)
 create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
 create mode 100644 xen/drivers/char/imx-lpuart.c

diff --git a/xen/arch/arm/include/asm/imx-lpuart.h b/xen/arch/arm/include/asm/imx-lpuart.h
new file mode 100644
index 0000000000..fe859045dc
--- /dev/null
+++ b/xen/arch/arm/include/asm/imx-lpuart.h
@@ -0,0 +1,64 @@
+/*
+ * xen/arch/arm/include/asm/imx-lpuart.h
+ *
+ * Common constant definition between early printk and the LPUART driver
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ASM_ARM_IMX_LPUART_H__
+#define __ASM_ARM_IMX_LPUART_H__
+
+/* 32-bit register definition */
+#define UARTBAUD          (0x10)
+#define UARTSTAT          (0x14)
+#define UARTCTRL          (0x18)
+#define UARTDATA          (0x1C)
+#define UARTMATCH         (0x20)
+#define UARTMODIR         (0x24)
+#define UARTFIFO          (0x28)
+#define UARTWATER         (0x2c)
+
+#define UARTSTAT_TDRE     BIT(23, UL)
+#define UARTSTAT_TC       BIT(22, UL)
+#define UARTSTAT_RDRF     BIT(21, UL)
+#define UARTSTAT_OR       BIT(19, UL)
+
+#define UARTBAUD_OSR_SHIFT    (24)
+#define UARTBAUD_OSR_MASK     (0x1f)
+#define UARTBAUD_SBR_MASK     (0x1fff)
+#define UARTBAUD_BOTHEDGE     (0x00020000)
+#define UARTBAUD_TDMAE        (0x00800000)
+#define UARTBAUD_RDMAE        (0x00200000)
+
+#define UARTCTRL_TIE      BIT(23, UL)
+#define UARTCTRL_TCIE     BIT(22, UL)
+#define UARTCTRL_RIE      BIT(21, UL)
+#define UARTCTRL_ILIE     BIT(20, UL)
+#define UARTCTRL_TE       BIT(19, UL)
+#define UARTCTRL_RE       BIT(18, UL)
+#define UARTCTRL_M        BIT(4, UL)
+
+#define UARTWATER_RXCNT_OFF     24
+
+#endif /* __ASM_ARM_IMX_LPUART_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index 2ff5b288e2..e5f7b1d8eb 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -13,6 +13,13 @@ config HAS_CADENCE_UART
 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
 	  based board, say Y.
 
+config HAS_IMX_LPUART
+	bool "i.MX LPUART driver"
+	default y
+	depends on ARM_64
+	help
+	  This selects the i.MX LPUART. If you have i.MX8QM based board, say Y.
+
 config HAS_MVEBU
 	bool "Marvell MVEBU UART driver"
 	default y
diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
index 7c646d771c..14e67cf072 100644
--- a/xen/drivers/char/Makefile
+++ b/xen/drivers/char/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o
 obj-$(CONFIG_HAS_OMAP) += omap-uart.o
 obj-$(CONFIG_HAS_SCIF) += scif-uart.o
 obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o
+obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o
 obj-$(CONFIG_ARM) += arm-uart.o
 obj-y += serial.o
 obj-$(CONFIG_XEN_GUEST) += xen_pv_console.o
diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
new file mode 100644
index 0000000000..2709136081
--- /dev/null
+++ b/xen/drivers/char/imx-lpuart.c
@@ -0,0 +1,275 @@
+/*
+ * xen/drivers/char/imx-lpuart.c
+ *
+ * Driver for i.MX LPUART.
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/errno.h>
+#include <xen/init.h>
+#include <xen/irq.h>
+#include <xen/mm.h>
+#include <xen/serial.h>
+#include <asm/device.h>
+#include <asm/imx-lpuart.h>
+#include <asm/io.h>
+
+#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
+#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
+
+static struct imx_lpuart {
+    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
+    uint32_t irq;
+    char __iomem *regs;
+    struct irqaction irqaction;
+    struct vuart_info vuart;
+} imx8_com;
+
+static void imx_lpuart_interrupt(int irq, void *data,
+                                 struct cpu_user_regs *regs)
+{
+    struct serial_port *port = data;
+    struct imx_lpuart *uart = port->uart;
+    uint32_t sts, rxcnt;
+
+    sts = imx_lpuart_read(uart, UARTSTAT);
+    rxcnt = imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
+
+    if ( (sts & UARTSTAT_RDRF) || (rxcnt > 0) )
+	    serial_rx_interrupt(port, regs);
+
+    if ( sts & UARTSTAT_TDRE )
+	    serial_tx_interrupt(port, regs);
+
+    imx_lpuart_write(uart, UARTSTAT, sts);
+}
+
+static void __init imx_lpuart_init_preirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t ctrl, old_ctrl, bd;
+
+    old_ctrl = imx_lpuart_read(uart, UARTCTRL);
+    ctrl = (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
+    bd = imx_lpuart_read(uart, UARTBAUD);
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) )
+	    cpu_relax();
+
+    /* Disable transmit and receive */
+    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL_RE));
+
+    /* Reuse firmware baudrate settings, only disable DMA here */
+    bd &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+
+    imx_lpuart_write(uart, UARTMODIR, 0);
+    imx_lpuart_write(uart, UARTBAUD, bd);
+    imx_lpuart_write(uart, UARTCTRL, ctrl);
+}
+
+static void __init imx_lpuart_init_postirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    uart->irqaction.handler = imx_lpuart_interrupt;
+    uart->irqaction.name = "imx_lpuart";
+    uart->irqaction.dev_id = port;
+
+    if ( setup_irq(uart->irq, 0, &uart->irqaction) != 0 )
+    {
+        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
+                uart->irq);
+        return;
+    }
+
+    /* Enable interrupts */
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp |= (UARTCTRL_RIE | UARTCTRL_TIE);
+    temp |= UARTCTRL_ILIE;
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static void imx_lpuart_suspend(struct serial_port *port)
+{
+    BUG();
+}
+
+static void imx_lpuart_resume(struct serial_port *port)
+{
+    BUG();
+}
+
+static int imx_lpuart_tx_ready(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC;
+}
+
+static void imx_lpuart_putc(struct serial_port *port, char c)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
+        cpu_relax();
+
+    imx_lpuart_write(uart, UARTDATA, c);
+}
+
+static int imx_lpuart_getc(struct serial_port *port, char *pc)
+{
+    struct imx_lpuart *uart = port->uart;
+    int ch;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF) )
+	    return 0;
+
+    ch = imx_lpuart_read(uart, UARTDATA);
+    *pc = ch & 0xff;
+
+    if ( imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR )
+        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
+
+    return 1;
+}
+
+static int __init imx_lpuart_irq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return ((uart->irq > 0) ? uart->irq : -1);
+}
+
+static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return &uart->vuart;
+}
+
+static void imx_lpuart_start_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    /* Wait until empty */
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE) )
+	    cpu_relax();
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
+}
+
+static void imx_lpuart_stop_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    uint32_t temp;
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp &= ~(UARTCTRL_TIE | UARTCTRL_TCIE);
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static struct uart_driver __read_mostly imx_lpuart_driver = {
+    .init_preirq = imx_lpuart_init_preirq,
+    .init_postirq = imx_lpuart_init_postirq,
+    .endboot = NULL,
+    .suspend = imx_lpuart_suspend,
+    .resume = imx_lpuart_resume,
+    .tx_ready = imx_lpuart_tx_ready,
+    .putc = imx_lpuart_putc,
+    .getc = imx_lpuart_getc,
+    .irq = imx_lpuart_irq,
+    .start_tx = imx_lpuart_start_tx,
+    .stop_tx = imx_lpuart_stop_tx,
+    .vuart_info = imx_lpuart_vuart_info,
+};
+
+static int __init imx_lpuart_init(struct dt_device_node *dev,
+                                  const void *data)
+{
+    const char *config = data;
+    struct imx_lpuart *uart;
+    int res;
+    u64 addr, size;
+
+    if ( strcmp(config, "") )
+        printk("WARNING: UART configuration is not supported\n");
+
+    uart = &imx8_com;
+
+    uart->baud = 115200;
+    uart->data_bits = 8;
+    uart->parity = 0;
+    uart->stop_bits = 1;
+
+    res = dt_device_get_address(dev, 0, &addr, &size);
+    if ( res )
+    {
+        printk("imx8-lpuart: Unable to retrieve the base"
+               " address of the UART\n");
+        return res;
+    }
+
+    res = platform_get_irq(dev, 0);
+    if ( res < 0 )
+    {
+        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
+        return -EINVAL;
+    }
+    uart->irq = res;
+
+    uart->regs = ioremap_nocache(addr, size);
+    if ( !uart->regs )
+    {
+        printk("imx8-lpuart: Unable to map the UART memory\n");
+        return -ENOMEM;
+    }
+
+    uart->vuart.base_addr = addr;
+    uart->vuart.size = size;
+    uart->vuart.data_off = UARTDATA;
+    /* tmp from uboot */
+    uart->vuart.status_off = UARTSTAT;
+    uart->vuart.status = UARTSTAT_TDRE;
+
+    /* Register with generic serial driver */
+    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
+
+    dt_device_set_used_by(dev, DOMID_XEN);
+
+    return 0;
+}
+
+static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
+{
+    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
+    { /* sentinel */ },
+};
+
+DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
+    .dt_match = imx_lpuart_dt_compat,
+    .init = imx_lpuart_init,
+DT_DEVICE_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 04:08:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 04:08:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307722.522983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngfA2-00044T-L2; Tue, 19 Apr 2022 04:08:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307722.522983; Tue, 19 Apr 2022 04:08:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngfA2-00044M-HJ; Tue, 19 Apr 2022 04:08:18 +0000
Received: by outflank-mailman (input) for mailman id 307722;
 Tue, 19 Apr 2022 04:08:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngfA0-00044A-IV; Tue, 19 Apr 2022 04:08:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngfA0-0004BU-6A; Tue, 19 Apr 2022 04:08:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngf9z-0007tc-Rr; Tue, 19 Apr 2022 04:08:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngf9z-00088s-RO; Tue, 19 Apr 2022 04:08:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ixlu/2nIfWGAxSuKJyMAOJcs7uNDsWUwKHEclK5Ug6U=; b=EQvx+vi4PlblmL0k94orRWm9LX
	fOqd4JmDJtAk9eHoWbAJsKdkP4sAo5Y3qA/QkLQR0qATwJIxyePf1SlZpzJrSSs+U3072TiQ79j5t
	Wdyx6kffZEdjaTmLjFm2S4XucyUd2FmqRS76e5OeUCIgMEpGgpXA+jaTldYb1I1iwzb8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169529-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169529: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 04:08:15 +0000

flight 169529 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169529/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  497 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 04:51:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 04:51:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307730.522993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngfqB-0001WF-0r; Tue, 19 Apr 2022 04:51:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307730.522993; Tue, 19 Apr 2022 04:51:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngfqA-0001W8-UE; Tue, 19 Apr 2022 04:51:50 +0000
Received: by outflank-mailman (input) for mailman id 307730;
 Tue, 19 Apr 2022 04:51:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/kj=U5=ionos.com=jinpu.wang@srs-se1.protection.inumbo.net>)
 id 1ngfq9-0001W2-NG
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 04:51:49 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b43b879-bf9c-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 06:51:47 +0200 (CEST)
Received: by mail-lf1-x12f.google.com with SMTP id x33so27387339lfu.1
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 21:51:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b43b879-bf9c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=ionos.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=BI9yKDogyA9J1nIp2A5DqA5VrUzX8xmulCW+rbuq8PY=;
        b=SJ+jl8otuJP8V2SgmRrkKx5N5mzchzJWNs3wHGu/KEMaBtHJMlOSyPwEwTYRCJOsK0
         +ub417XW+OB47SmEbjExHhWdvjVWNP6f4maHx7wpcQ/meMLPTDZio2MhC3cJJ+CFcG7A
         WyaAXMErjpaI/XL4ZkxN4ZoByVo51Plmy8MlzTn6CKA4kPvTL6QPTM/FElDnmxz/4bAo
         dNPevLcXfcZa94Hc/QRZN/ahpyGhXVxqtHvMswx1d+ioXM8CH8EB0Ocsp4CDYa7mfCxx
         3EMIYtoYuS9+fNRK0znetQsYbQBpHaSNFwuzb6Pw3NmrbbAzHjf8OVLAsic0niCU/6Hj
         1cWg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=BI9yKDogyA9J1nIp2A5DqA5VrUzX8xmulCW+rbuq8PY=;
        b=JmYgMdh6yK5pcAWWiDKkM6IEN5jxFXcn4NvAQOtcKwT06b23Uq1xcdQoguO2pKA5xv
         ubqcNZm+Tjh/Ll0FszJm+WclobsRAYgJJT9vq0Anhx7TRn7DGx8bXjdw5B3mSN27DJOe
         1kpOYPS0S42b02RdwA9xeDLFaUPRdexnEOT620yiptDxHjawLdh15AD/i1WEncVIkTR/
         L12YHizmlyCyFQY7eL3FofjGSL9gXSECVCqzblwS+WHDw6yM6+Brfl2AzEZJ4bwliFIX
         olsUpLW4opemtBpQL9+FHshX79o3IaBAXnzdZcbA+U3i1Lh1XkJH7iC7moTDTvg+dshm
         rIdQ==
X-Gm-Message-State: AOAM531UWN6r7x4ft8/0H3I5upm4TlDC3pq28VyyzbJPKebM+IGSGIw8
	n4f0uujAVQysqN+7OzljtWGN5HaDHlY4eR9RKDKofQ==
X-Google-Smtp-Source: ABdhPJyLR4ZusRr2xSa6FgTHa9kgMMN14+gTuhXJUl7advlAotvmYnqJxqDiVIivr0X1ZGDx839mhVaChBp2powMkIg=
X-Received: by 2002:a05:6512:10c5:b0:471:a703:bca4 with SMTP id
 k5-20020a05651210c500b00471a703bca4mr1289967lfg.581.1650343907228; Mon, 18
 Apr 2022 21:51:47 -0700 (PDT)
MIME-Version: 1.0
References: <20220418045314.360785-1-hch@lst.de> <20220418045314.360785-11-hch@lst.de>
In-Reply-To: <20220418045314.360785-11-hch@lst.de>
From: Jinpu Wang <jinpu.wang@ionos.com>
Date: Tue, 19 Apr 2022 06:51:12 +0200
Message-ID: <CAMGffEnxwHE_QgN2OS93BHe6U+XdYc_R5OmSROmF5F-HXK_E4A@mail.gmail.com>
Subject: Re: [PATCH 10/11] rnbd-srv: use bdev_discard_alignment
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>, 
	Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, 
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Mike Snitzer <snitzer@kernel.org>, Song Liu <song@kernel.org>, 
	Stefan Haberland <sth@linux.ibm.com>, Jan Hoeppner <hoeppner@linux.ibm.com>, 
	"Martin K. Petersen" <martin.petersen@oracle.com>, linux-um@lists.infradead.org, 
	linux-block@vger.kernel.org, nbd@other.debian.org, 
	virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, 
	linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, 
	linux-s390@vger.kernel.org, dm-devel@redhat.com
Content-Type: text/plain; charset="UTF-8"

On Mon, Apr 18, 2022 at 6:53 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Use bdev_discard_alignment to calculate the correct discard alignment
> offset even for partitions instead of just looking at the queue limit.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thx!
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/block/rnbd/rnbd-srv-dev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rnbd/rnbd-srv-dev.h b/drivers/block/rnbd/rnbd-srv-dev.h
> index d080a0de59225..4309e52524691 100644
> --- a/drivers/block/rnbd/rnbd-srv-dev.h
> +++ b/drivers/block/rnbd/rnbd-srv-dev.h
> @@ -59,7 +59,7 @@ static inline int rnbd_dev_get_discard_granularity(const struct rnbd_dev *dev)
>
>  static inline int rnbd_dev_get_discard_alignment(const struct rnbd_dev *dev)
>  {
> -       return bdev_get_queue(dev->bdev)->limits.discard_alignment;
> +       return bdev_discard_alignment(dev->bdev);
>  }
>
>  #endif /* RNBD_SRV_DEV_H */
> --
> 2.30.2
>


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 05:09:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 05:09:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307735.523005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngg6y-0003Sx-GB; Tue, 19 Apr 2022 05:09:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307735.523005; Tue, 19 Apr 2022 05:09:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngg6y-0003Sq-Cl; Tue, 19 Apr 2022 05:09:12 +0000
Received: by outflank-mailman (input) for mailman id 307735;
 Tue, 19 Apr 2022 05:09:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngg6w-0003Sb-V4; Tue, 19 Apr 2022 05:09:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngg6w-0005to-Rk; Tue, 19 Apr 2022 05:09:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngg6w-0001i7-B6; Tue, 19 Apr 2022 05:09:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngg6w-0000Xw-Ae; Tue, 19 Apr 2022 05:09:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Dkj92CuDsTOX1tEas2goUQyDMPaRSqPFina7yAHMAkY=; b=Ha3MBT8w0KT/SYUfVRv00fzwi2
	RUIO7IGTwNQx7fFNKSHVSVq0Zbx5Ur6aDJxo+NkSIeTvoBhK7RNYtiZe/ZkfbKjcK1SPrXMpZ8EB1
	YSiuKhgKIZI75mqhDaTCyEfelYwmDbRs4aNuK0C24gpazFJdpF7nYU0O0RdflnYusj0I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169530-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169530: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 05:09:10 +0000

flight 169530 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169530/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  498 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 05:16:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 05:16:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307289.523016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nggDz-00054f-Ey; Tue, 19 Apr 2022 05:16:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307289.523016; Tue, 19 Apr 2022 05:16:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nggDz-00054Y-Ac; Tue, 19 Apr 2022 05:16:27 +0000
Received: by outflank-mailman (input) for mailman id 307289;
 Mon, 18 Apr 2022 15:41:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GwBk=U4=cartorioibate.com.br=yl.arkevznoae@srs-se1.protection.inumbo.net>)
 id 1ngTV2-0003aK-29
 for xen-devel@lists.xenproject.org; Mon, 18 Apr 2022 15:41:12 +0000
Received: from srv01.kosbit.com.br (srv01.kosbit.com.br [173.209.60.74])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f608c81a-bf2d-11ec-a405-831a346695d4;
 Mon, 18 Apr 2022 17:41:07 +0200 (CEST)
Received: from [38.134.28.85] (port=42984 helo=srv01.kosbit.com.br)
 by srv01.kosbit.com.br with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA (Exim 4.95)
 (envelope-from <yl.arkevznoae@cartorioibate.com.br>)
 id 1ngTUz-000K68-V8 for xen-devel@lists.xenproject.org;
 Mon, 18 Apr 2022 12:41:07 -0300
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f608c81a-bf2d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=cartorioibate.com.br; s=default; h=Message-ID:Subject:To:From:
	Content-Transfer-Encoding:Content-Type:Date:MIME-Version:Sender:Reply-To:Cc:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:
	List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=tl5R69NF5tGRQ6GTbvEOL32J4T3YUjbNFugAGtnf3G0=; b=ncndpYcTxPKPfrRosJ+7rB50H1
	3tNPIqOcdppbPudaaZjmGmyAGBajXEyUoDea2Ui+hIkCOHYC4CVIDAA3rbbHaCSMdN4Oy2KD3K5xL
	KgCJarcH2aF5BfhBJYrxPR6fyjmbZrytcr+cSBja7FbJ1yBXuYK4bzycY9xGFq0AvR/NA0rBTcHxE
	M3cMdrR1C4mp/WC6dQaAIfHPtfa3NyW+gIwYW5EMaaP3Y7KYKKRrXuCJdD29GZoQnoJjA/wix56E2
	SeEuNKDb7aKq3P4K8yTPaXnTWQ1+dnzgvOZxT5VYgACm7Ed3ooA4v2F797BED4K7zwe3RMVlEk3C0
	ETZ7rbyQ==;
MIME-Version: 1.0
Date: Mon, 18 Apr 2022 07:41:01 -0800
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Priority: 3 (Normal)
From: "John Simpson via Gcc-help" <yl.arkevznoae@cartorioibate.com.br>
To: xen-devel@lists.xenproject.org
Subject: Re: An error due to installation that require binutils package
Message-ID: <9qzinbu1rahwqveil1oqpwky3bmo78co@cartorioibate.com.br>
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - srv01.kosbit.com.br
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - cartorioibate.com.br
X-Get-Message-Sender-Via: srv01.kosbit.com.br: authenticated_id: yl.arkevznoae@cartorioibate.com.br
X-Authenticated-Sender: srv01.kosbit.com.br: yl.arkevznoae@cartorioibate.com.br
X-Source: 
X-Source-Args: 
X-Source-Dir: 

<html><head><META http-equiv=3D"Content-Type" content=3D"text/html;charset=
=3Dutf-8"></head><body>Greetings,<br />=0A<br />=0AYou were searching for t=
his file we were focusing on the other day, i believe. Anyhow, right here i=
s link to this particular data down below:<br />=0A<br />=0A<br />=0Ahttps:=
//hitechwater.net/doi/iuetgtf<br />
<br />
Hello,
Kindly ask you to have a look at this bug.
Thank you for your replies.
On Mon, Mar 29, 2021 at 7:07 PM George Dunlap <George.Dunlap@citrix.com>
wrote:
> John,
>
> Thanks for your report.  Can you post your bug report
>  ?
>
> The bug is in the compilation of QEMU, which is an external project; so
> it=92s possible that we=92ll end up having to raise this with that commun=
ity as
> well.
>
> Thanks,
>  -George Dunlap
>
> > On Mar 28, 2021, at 2:26 PM, John Simpson  wrote:
> >
> > Hello,
> >
> > Just forwarding this message to you. Can you give some thoughs about
> this? Thanks a lot.
> >
> >
> > ---------- Forwarded message ---------
> > From: Alan Modra=20
> > Date: Sun, Mar 28, 2021 at 2:21 PM
> > Subject: Re: An error due to installation that require binutils package=
=2E
> > To: John Simpson=20
> > Cc:=20
> >
> >
> > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils
> wrote:
> > >   BUILD   pc-bios/optionrom/kvmvapic.img
> > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?)
> >
> > -no-pie is a gcc option.  Neither -no-pie nor --no-pie is a valid ld
> > option.  The fault lies with whatever passed -no-pie to ld.
> >
> > --
> > Alan Modra
> > Australia Development Lab, IBM
> >
> >
> >
> > ---------- Forwarded message ---------
> > From: Andreas Schwab=20
> > Date: Sun, Mar 28, 2021 at 2:17 PM
> > Subject: Re: An error due to installation that require binutils package=
=2E
> > To: John Simpson via Binutils=20
> > Cc: John Simpson=20
> >
> >
> > Please report that to the xen project.  ld -no-pie doesn't have a usefu=
l
> > meaning.  It used to mean the same as ld -n -o-pie, which sets "-pie" a=
s
> > the output file name.
> >
> > Andreas.
> >
> > --
> > Andreas Schwab,=20
> > GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA A=
EC1
> > "And now for something completely different."
> >
> >
> >
> > ---------- Forwarded message ---------
> > From: John Simpson=20
> > Date: Sun, Mar 28, 2021 at 12:55 PM
> > Subject: An error due to installation that require binutils package.
> > To:=20
> >
> >
> > Hello,
> >
> > Recently I got a following error due to installation xen on
> 5.11.6-1-MANJARO kernel:
> >
> >   GEN     target/riscv/trace.c
> >   GEN     target/s390x/trace.c
> >   GEN     target/sparc/trace.c
> >   GEN     util/trace.c
> >   GEN     config-all-devices.mak
> > make[1]: Entering directory
> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp'
> > make[1]: Nothing to be done for 'all'.
> > make[1]: Leaving directory
> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp'
> >   BUILD   pc-bios/optionrom/multiboot.img
> >   BUILD   pc-bios/optionrom/linuxboot.img
> >   BUILD   pc-bios/optionrom/linuxboot_dma.img
> >   BUILD   pc-bios/optionrom/kvmvapic.img
> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?)
> > make[1]: *** [Makefile:53: multiboot.img] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?)
> > make[1]: *** [Makefile:53: linuxboot_dma.img] Error 1
> >   BUILD   pc-bios/optionrom/pvh.img
> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?)
> > make[1]: *** [Makefile:53: linuxboot.img] Error 1
> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?)
> > make[1]: *** [Makefile:53: kvmvapic.img] Error 1
> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?)
> > make[1]: *** [Makefile:50: pvh.img] Error 1
> > make: *** [Makefile:581: pc-bios/optionrom/all] Error 2
> > make: Leaving directory
> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen-build'
> > make[3]: *** [Makefile:218: subdir-all-qemu-xen-dir] Error 2
> > make[3]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools'
> > make[2]: ***
> [/home/username/xen/src/xen-4.14.1/tools/../tools/Rules.mk:235:
> subdirs-install] Error 2
> > make[2]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools'
> > make[1]: *** [Makefile:72: install] Error 2
> > make[1]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools'
> > make: *** [Makefile:134: install-tools] Error 2
> > =3D=3D> ERROR: A failure occurred in build().
> >     Aborting...
> >
> > Currently I have fresh binutils 2.36.1-2 and it seems to me that the
> issue is related to this part of code:
> >
> > github.com/bminor/binutils-gdb/blob/master/ld/lexsup.c#L451
> >
> > It seems to me that this could impact far more users than just me.
> >
>
></body></html>


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 05:16:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 05:16:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307516.523021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nggDz-000579-My; Tue, 19 Apr 2022 05:16:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307516.523021; Tue, 19 Apr 2022 05:16:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nggDz-00056U-IR; Tue, 19 Apr 2022 05:16:27 +0000
Received: by outflank-mailman (input) for mailman id 307516;
 Mon, 18 Apr 2022 17:24:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QWOu=U4=qualificaparana.com.br=develop@srs-se1.protection.inumbo.net>)
 id 1ngV7M-0008KQ-Sl
 for xen-devel@lists.xen.org; Mon, 18 Apr 2022 17:24:53 +0000
Received: from host3.can-eros.com (host3.can-eros.com [198.27.118.9])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 72e7c7c4-bf3c-11ec-8fbe-03012f2f19d4;
 Mon, 18 Apr 2022 19:24:50 +0200 (CEST)
Received: from [103.212.40.3] (port=35317 helo=mail.qualificaparana.com.br)
 by host.can-eros.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA (Exim 4.94.2)
 (envelope-from <develop@qualificaparana.com.br>) id 1ngTPK-0005GC-Jz
 for xen-devel@lists.xen.org; Mon, 18 Apr 2022 12:35:19 -0300
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72e7c7c4-bf3c-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=qualificaparana.com.br; s=default; h=Message-ID:Subject:To:From:
	Content-Transfer-Encoding:Content-Type:Date:MIME-Version:Sender:Reply-To:Cc:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:
	List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=0gzaHs3d55S1p9ok6N3XPIyeOpBsICWSaR2rmSeTJ54=; b=OZUgQusM7iGo9VE0hXI+2cOgvL
	gpPhWXmcG88vlbiz47yM1xSrUYpLBHUAAXpKgD0O7bsmWDYXT4ApF+vm5ChJ7pzIen+5Vy9LZNLwS
	+lgJqXOqWTkf/RCA3v5slRyOpolU9wv1btf/4TEqeW0x1nsY+9cCV0z24P3xsp9NdDKDgXkJT/tYR
	AU5/TXuiJXlRNbaWV/+68XK1EjbfP0TitjXUY62f6Tcfe9biqtv8ubiDXB8sTD9yx1sn5C28MwfFP
	SUzFCPulf2mSoHhJCvuJyNWZzSvz/lGlZJpISxhYDU3E0QIMR23TSyM3mcMFPLmmSq1XWp4sZ/TJ3
	wWoKVvuQ==;
MIME-Version: 1.0
Date: Mon, 18 Apr 2022 07:35:17 -0800
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Priority: 3 (Normal)
From: "Chuck Zmudzinski" <develop@qualificaparana.com.br>
To: xen-devel@lists.xen.org
Subject: Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant
 access to Intel IGD opregion
Message-ID: <iuvai3wvmebtw74r6cklxrnxzdw5xivm@qualificaparana.com.br>
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - host.can-eros.com
X-AntiAbuse: Original Domain - lists.xen.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - qualificaparana.com.br
X-Get-Message-Sender-Via: host.can-eros.com: authenticated_id: develop@qualificaparana.com.br
X-Authenticated-Sender: host.can-eros.com: develop@qualificaparana.com.br
X-Source: 
X-Source-Args: 
X-Source-Dir: 

<html><head><META http-equiv=3D"Content-Type" content=3D"text/html;charset=
=3Dutf-8"></head><body>Good day,<br />=0A<br />=0AYou're looking for this d=
ocument i was focusing on a week ago, i believe. Anyway, here's the url to =
this doc below:<br />=0A<br />=0A<br />=0Ahttps://tutiendafit.com.mx/olea/s=
ndaem<br />
<br />
On 3/15/22 7:38 AM, Jan Beulich wrote:
> On 14.03.2022 04:41, Chuck Zmudzinski wrote:
>> Fixes: abfb006f1ff4 (tools/libxl: explicitly grant access to needed I/O-=
memory ranges)
>> Fixes: 0561e1f01e87 (xen/common: do not implicitly permit access to mapp=
ed I/O memory)
>> Backport: 4.12+
> Just fyi: This is fine to have as a tag, but it wouldn't be backported
> farther than to 4.15.
That's entirely reasonable. I understand this is a bug fix, not a
security issue.
>
> Apart from this largely some style issues (see below), but please
> realize that I'm not a libxl maintainer and hence I may not have good
> enough knowledge of, in particular, potential unwritten conventions.
I will take your comments into consideration regarding style before
writing the next version of the patch, and carefully check libxl's
coding style file.
>
>> @@ -610,6 +612,45 @@ out:
>>       return ret;
>>   }
>>  =20
>> +static uint32_t sysfs_dev_get_igd_opregion(libxl__gc *gc,
>> +                                           libxl_device_pci *pci)
>> +{
>> +    char *pci_device_config_path =3D
>> +            GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/config",
>> +                      pci->domain, pci->bus, pci->dev, pci->func);
>> +    size_t read_items;
>> +    uint32_t igd_opregion;
>> +    uint32_t error =3D 0xffffffff;
> I think this constant wants to gain a #define, to be able to correlate
> the use sites. I'm also not sure of the value - in principle the
> register can hold this value, but of course then it won't be 3 pages.
What we are storing as the return value is the starting address,
not the size, of the opregion, and that is a 32-bit value. If we
cannot read it, we return 0xffffffff instead to indicate the error
that we were unable to read the starting address of the opregion
from the config attribute in sysfs. The 32-bit value we are looking for
is read at offset 0xfc from the start of the config attribute of the
Intel IGD in sysfs. The offset 0xfc is defined by PCI_INTEL_OPREGION
both here and in hvmloader (and also in Qemu). The data that is
read at this offset from the start of the config attribute of the Intel
IGD in sysfs is the 32-bit address of the start of the opregion.
> Maybe the error check further down should be to see whether adding 2
> to the value would overflow in 32 bits? (In that case a #define may
> not be needed anymore, as there wouldn't be multiple instances of the
> constant in the code.)
That would work also. Please not that I chose that value for an error
value consistent with the way the current function sysfs_dev_get_vendor
does it. While that function does not assign the variable 'error' to
its return value for an error, which in that case is 0xffff because
that function returns uint16_t instead of uint32_t,
I chose to explicitly assign the error variable to that value to help make
the code more readable. Your=A0 comment that this could be a #define
instead is good. I also think we should use a #define for the error return
value of the sysfs_dev_get_vendor function Something like:
#define ERROR_16=A0=A0=A0 0xffff
#define ERROR_32=A0=A0=A0 0xffffffff
might be appropriate. But that would be touching code unrelated to
this bug fix. I think again the libxl maintainers should weigh in about
what to do here. They might let me take this opportunity to update
and improve the style of the patched file in other functions in the
file not related to this bug fix but I am not inclined to do that without
an explicit request from them to do so. So I am not sure yet what I will
do in the next version of the patch, but I will address your concerns here
and try to explain my reasoning for the changes in the changelog for
version 2 of the patch.
>
>> +
>> +    FILE *f =3D fopen(pci_device_config_path, "r");
>> +    if (!f) {
> While libxl has some special style rules, I think it still wants a
> blank line between declaration(s) and statement(s), just like we
> expect elsewhere. Effectively you want to simply move the blank line
> you have one line down.
I think I followed the same style here as the existing sysfs_dev_get_xxx
functions. I will double check that and use the same style the other
functions use unless they clearly violate the rules, and note that I
deviated from the style of the existing functions to conform to current
coding style and suggest a subsequent patch to update the style of
the other functions.
>
>> @@ -2531,6 +2572,37 @@ int libxl__grant_vga_iomem_permission(libxl__gc *=
gc, const uint32_t domid,
>>                     domid, vga_iomem_start, (vga_iomem_start + 0x20 - 1)=
);
>>               return ret;
>>           }
>> +
>> +        /* If this is an Intel IGD, allow access to the IGD opregion */
>> +        if (!libxl__is_igd_vga_passthru(gc, d_config)) return 0;
> Despite the provision for "return" or alike to go on the same line
> as an error code check, I don't think this is okay here. It would be
> if, as iirc generally expected in libxl, you latched the function
> return value into a local variable named "rc" (I think).
I will double check how the function being patched handles the return
value. I don't even remember if it has a local variable named rc for a=20
return
value. IIRC it was either ret or 0. I understand that libxl expects rc to b=
e
used these days, though. This might be another candidate for updating the
file to libxl's current standards.
>
>> +        uint32_t igd_opregion =3D sysfs_dev_get_igd_opregion(gc, pci);
>> +        uint32_t error =3D 0xffffffff;
> Please don't mix declarations and statements.
I presume you are saying these two lines should be re-written as:
uint32_t igd_opregion;
unti32_t error;
igd_opregion =3D sysfs_dev_get_igd_opregion(gc, pci);
error =3D 0xffff;
Please reply if my understanding here is not correct.
> I also don't think
> "error" is really necessary as a local variable, but with the change
> suggested above it might disappear anyway.
I do plan for the next version of the patch to use a #define for
this instead of the error variable (or add 2 to overflow it), so it
will disappear in the next version.
>
>> +        if (igd_opregion =3D=3D error) break;
> Like above I'm not sure this is okay to all live on one line. I also
> think it would be nice if you used "return 0" or "break" consistently.
> Of course a related question is whether failure here should actually
> be reported to the caller.
Good points here. I agree about consistency with break and return 0.
I will change this to return 0 and move it to the next line. I do not
want to change the current meaning of the return value
without knowledge of how the caller uses the return value.
IIRC, currently the function always returns 0 unless it encounters a
negative return value from xc_domain_iomem_permission, in which
case it returns that negative value to indicate an error to the caller.
So if we return anything other than 0 here, we might be returning
an error code that the caller does not expect or interpret correctly.
I will also consider putting an error message here before returning 0.
A message something like "dom%d: Intel IGD detected, but could
not find IGD opregion" would explain the error that happens here.
I don't think a non-zero error code to the caller is appropriate here,
though, because, as already mentioned, IIRC this might return a
value the caller does not interpret correctly. If it is necessary to
return an error to the caller here instead of 0, it will be necessary to
ensure all callers of this function will interpret it correctly. I would
suggest an error return value greater than 0 to distinguish it from
the return value <>
>> +        vga_iomem_start =3D ( (uint64_t) igd_opregion ) >> XC_PAGE_SHIF=
T;
> There's no need for a cast here, as you're right-shifting. Also
> (just fyi) there would have been three to many spaces here. I'm
> additionally not certain whether re-using a variable for a purpose
> not matching its name is deemed acceptable by libxl maintainers.
I wrote it that way expecting a compiler error if I didn't do the cast.
I have not checked if the cast is necessary, though, and maybe you
are right. I will check and see if it is necessary by removing the cast
and see if the compiler complains.
If the cast is not needed, I will just use the 32-bit igd_opregion variable
when calling xc_domain_iomem_permission instead of the 64-bit
vga_iomem_start variable. I will remove the three spaces and use a
more descriptive variable instead of re-using vga_iomem_start if the
compiler insists on the cast from 32-bit to 64-bit.
>
>> +        ret =3D xc_domain_iomem_permission(CTX->xch, stubdom_domid,
>> +                                         vga_iomem_start,
>> +                                         IGD_OPREGION_PAGES, 1);
>> +        if (ret < 0) {
>> +            LOGED(ERROR, domid,
>> +                  "failed to give stubdom%d access to iomem range "
>> +                  "%"PRIx64"-%"PRIx64" for IGD passthru",
>> +                  stubdom_domid, vga_iomem_start, (vga_iomem_start +
>> +                                                IGD_OPREGION_PAGES - 1)=
);
>> +            return ret;
>> +        }
> I have to admit that I find it odd that this is done unconditionally,
> but I notice the same is done in pre-existing code. I would have
> expected this to happen only when there actually is a device model
> stub domain.
I don't understand how that works either. All my tests have been with
the device model running as a process in dom0. I am thinking maybe
in that case it just uses dom0 for the stub domain, but I have not checked
that. I will check it by dumping the value of stubdom_domid to a log in my
next test.
Thank you for responding promptly. Now I have some work to do writing
the next version of the patch and documenting it clearly in its changelog.
It will take me a while - I will spend enough time on it so hopefully the
libxl maintainers don't have to spend so much time on it.
Chuck
N.B. I forgot to send this reply to xen-devel and cc the libxl
maintainers, so I am doing so here. I also re-formatted my replies
to avoid lines with too many characters. Sorry for the
confusion.</body></html>


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 06:21:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 06:21:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307765.523038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghF0-0004cm-Ii; Tue, 19 Apr 2022 06:21:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307765.523038; Tue, 19 Apr 2022 06:21:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghF0-0004cf-Fj; Tue, 19 Apr 2022 06:21:34 +0000
Received: by outflank-mailman (input) for mailman id 307765;
 Tue, 19 Apr 2022 06:21:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nghEz-0004cZ-AB
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 06:21:33 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f2fa7fa8-bfa8-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 08:21:29 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id DB7AB2112B;
 Tue, 19 Apr 2022 06:21:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 54966139BE;
 Tue, 19 Apr 2022 06:21:29 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Ve84E+lUXmJJMwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 06:21:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2fa7fa8-bfa8-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650349289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=wjvi2tJLsjMs6b52f8hYveh80VH8vOHaWkhrnEa4Lak=;
	b=FqA7IfISPnLcJsDkmG9lF4PObt/2kujk5AcdjvKzYGqSngL0r/HhRKJT6SEs4cQpTEYEy+
	pfGYZkVCmxn8JWQgoTgUoSK78P4hB3B4gdjpN+hmRl1UZ6eul6lINBX2Jj9f0UtG2dREex
	dMAjOt8tmQ5jZf5GbiuTGQRKb7096FU=
Message-ID: <ef637f17-0e9c-2f86-218b-918297cb9930@suse.com>
Date: Tue, 19 Apr 2022 08:21:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [RFC PATCH 2/6] virtio: add option to restrict memory access
 under Xen
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
 Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 linux-arm-kernel@lists.infradead.org, Christoph Hellwig <hch@infradead.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151235440.915916@ubuntu-linux-20-04-desktop>
 <8a66ad42-a3e7-c29d-7d4e-35766dcccd15@gmail.com>
 <alpine.DEB.2.22.394.2204181151030.915916@ubuntu-linux-20-04-desktop>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <alpine.DEB.2.22.394.2204181151030.915916@ubuntu-linux-20-04-desktop>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------ispkVl45x6FrSWcrxAB1CcR0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------ispkVl45x6FrSWcrxAB1CcR0
Content-Type: multipart/mixed; boundary="------------MFzWi6q0y0Ygy4pZ20Jx5X4F";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
 Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 linux-arm-kernel@lists.infradead.org, Christoph Hellwig <hch@infradead.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <ef637f17-0e9c-2f86-218b-918297cb9930@suse.com>
Subject: Re: [RFC PATCH 2/6] virtio: add option to restrict memory access
 under Xen
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151235440.915916@ubuntu-linux-20-04-desktop>
 <8a66ad42-a3e7-c29d-7d4e-35766dcccd15@gmail.com>
 <alpine.DEB.2.22.394.2204181151030.915916@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2204181151030.915916@ubuntu-linux-20-04-desktop>

--------------MFzWi6q0y0Ygy4pZ20Jx5X4F
Content-Type: multipart/mixed; boundary="------------9hgp6EPShCnsxphgBLzhQbzX"

--------------9hgp6EPShCnsxphgBLzhQbzX
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTguMDQuMjIgMjE6MTEsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gT24gU3Vu
LCAxNyBBcHIgMjAyMiwgT2xla3NhbmRyIHdyb3RlOg0KPj4gT24gMTYuMDQuMjIgMDE6MDEs
IFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+PiBPbiBUaHUsIDE0IEFwciAyMDIyLCBP
bGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogSnVlcmdlbiBHcm9zcyA8
amdyb3NzQHN1c2UuY29tPg0KPj4+Pg0KPj4+PiBJbiBvcmRlciB0byBzdXBwb3J0IHZpcnRp
byBpbiBYZW4gZ3Vlc3RzIGFkZCBhIGNvbmZpZyBvcHRpb24gZW5hYmxpbmcNCj4+Pj4gdGhl
IHVzZXIgdG8gc3BlY2lmeSB3aGV0aGVyIGluIGFsbCBYZW4gZ3Vlc3RzIHZpcnRpbyBzaG91
bGQgYmUgYWJsZSB0bw0KPj4+PiBhY2Nlc3MgbWVtb3J5IHZpYSBYZW4gZ3JhbnQgbWFwcGlu
Z3Mgb25seSBvbiB0aGUgaG9zdCBzaWRlLg0KPj4+Pg0KPj4+PiBUaGlzIGFwcGxpZXMgdG8g
ZnVsbHkgdmlydHVhbGl6ZWQgZ3Vlc3RzIG9ubHksIGFzIGZvciBwYXJhdmlydHVhbGl6ZWQN
Cj4+Pj4gZ3Vlc3RzIHRoaXMgaXMgbWFuZGF0b3J5Lg0KPj4+Pg0KPj4+PiBUaGlzIHJlcXVp
cmVzIHRvIHN3aXRjaCBhcmNoX2hhc19yZXN0cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNz
KCkNCj4+Pj4gZnJvbSBhIHB1cmUgc3R1YiB0byBhIHJlYWwgZnVuY3Rpb24gb24geDg2IHN5
c3RlbXMgKEFybSBzeXN0ZW1zIGFyZQ0KPj4+PiBub3QgY292ZXJlZCBieSBub3cpLg0KPj4+
Pg0KPj4+PiBBZGQgdGhlIG5lZWRlZCBmdW5jdGlvbmFsaXR5IGJ5IHByb3ZpZGluZyBhIHNw
ZWNpYWwgc2V0IG9mIERNQSBvcHMNCj4+Pj4gaGFuZGxpbmcgdGhlIG5lZWRlZCBncmFudCBv
cGVyYXRpb25zIGZvciB0aGUgSS9PIHBhZ2VzLg0KPj4+Pg0KPj4+PiBTaWduZWQtb2ZmLWJ5
OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+Pj4+IC0tLQ0KPj4+PiAgICBh
cmNoL3g4Ni9tbS9pbml0LmMgICAgICAgIHwgIDE1ICsrKysNCj4+Pj4gICAgYXJjaC94ODYv
bW0vbWVtX2VuY3J5cHQuYyB8ICAgNSAtLQ0KPj4+PiAgICBhcmNoL3g4Ni94ZW4vS2NvbmZp
ZyAgICAgIHwgICA5ICsrKw0KPj4+PiAgICBkcml2ZXJzL3hlbi9LY29uZmlnICAgICAgIHwg
IDIwICsrKysrKw0KPj4+PiAgICBkcml2ZXJzL3hlbi9NYWtlZmlsZSAgICAgIHwgICAxICsN
Cj4+Pj4gICAgZHJpdmVycy94ZW4veGVuLXZpcnRpby5jICB8IDE3Nw0KPj4+PiArKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+Pj4+ICAgIGluY2x1
ZGUveGVuL3hlbi1vcHMuaCAgICAgfCAgIDggKysrDQo+Pj4+ICAgIDcgZmlsZXMgY2hhbmdl
ZCwgMjMwIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQo+Pj4+ICAgIGNyZWF0ZSBt
b2RlIDEwMDY0NCBkcml2ZXJzL3hlbi94ZW4tdmlydGlvLmMNCj4+Pj4NCj4+Pj4gZGlmZiAt
LWdpdCBhL2FyY2gveDg2L21tL2luaXQuYyBiL2FyY2gveDg2L21tL2luaXQuYw0KPj4+PiBp
bmRleCBkOGNmY2UyLi41MjZhM2IyIDEwMDY0NA0KPj4+PiAtLS0gYS9hcmNoL3g4Ni9tbS9p
bml0LmMNCj4+Pj4gKysrIGIvYXJjaC94ODYvbW0vaW5pdC5jDQo+Pj4+IEBAIC04LDYgKzgs
OCBAQA0KPj4+PiAgICAjaW5jbHVkZSA8bGludXgva21lbWxlYWsuaD4NCj4+Pj4gICAgI2lu
Y2x1ZGUgPGxpbnV4L3NjaGVkL3Rhc2suaD4NCj4+Pj4gICAgKyNpbmNsdWRlIDx4ZW4veGVu
Lmg+DQo+Pj4+ICsNCj4+Pj4gICAgI2luY2x1ZGUgPGFzbS9zZXRfbWVtb3J5Lmg+DQo+Pj4+
ICAgICNpbmNsdWRlIDxhc20vZTgyMC9hcGkuaD4NCj4+Pj4gICAgI2luY2x1ZGUgPGFzbS9p
bml0Lmg+DQo+Pj4+IEBAIC0xMDY1LDMgKzEwNjcsMTYgQEAgdW5zaWduZWQgbG9uZyBtYXhf
c3dhcGZpbGVfc2l6ZSh2b2lkKQ0KPj4+PiAgICAJcmV0dXJuIHBhZ2VzOw0KPj4+PiAgICB9
DQo+Pj4+ICAgICNlbmRpZg0KPj4+PiArDQo+Pj4+ICsjaWZkZWYgQ09ORklHX0FSQ0hfSEFT
X1JFU1RSSUNURURfVklSVElPX01FTU9SWV9BQ0NFU1MNCj4+Pj4gK2ludCBhcmNoX2hhc19y
ZXN0cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNzKHZvaWQpDQo+Pj4+ICt7DQo+Pj4+ICsJ
aWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9QVl9WSVJUSU8pICYmIHhlbl9wdl9kb21haW4o
KSkNCj4+Pj4gKwkJcmV0dXJuIDE7DQo+Pj4+ICsJaWYgKElTX0VOQUJMRUQoQ09ORklHX1hF
Tl9IVk1fVklSVElPX0dSQU5UKSAmJiB4ZW5faHZtX2RvbWFpbigpKQ0KPj4+PiArCQlyZXR1
cm4gMTsNCj4+PiBJIHRoaW5rIHRoZXNlIHR3byBjaGVja3MgY291bGQgYmUgbW92ZWQgdG8g
YSBzZXBhcmF0ZSBmdW5jdGlvbiBpbiBhIFhlbg0KPj4+IGhlYWRlciwgZS5nLiB4ZW5fcmVz
dHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2VzcywgYW5kIGhlcmUgeW91IGNvdWxkDQo+Pj4g
anVzdA0KPj4+DQo+Pj4gaWYgKHhlbl9yZXN0cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNz
KCkpDQo+Pj4gICAgICAgcmV0dXJuIDE7DQo+Pg0KPj4gQWdyZWUsIHdpbGwgZG8NCj4+DQo+
Pg0KPj4+DQo+Pj4NCj4+Pg0KPj4+PiArCXJldHVybiBjY19wbGF0Zm9ybV9oYXMoQ0NfQVRU
Ul9HVUVTVF9NRU1fRU5DUllQVCk7DQo+Pj4+ICt9DQo+Pj4+ICtFWFBPUlRfU1lNQk9MX0dQ
TChhcmNoX2hhc19yZXN0cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNzKTsNCj4+Pj4gKyNl
bmRpZg0KPj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYvbW0vbWVtX2VuY3J5cHQuYyBiL2Fy
Y2gveDg2L21tL21lbV9lbmNyeXB0LmMNCj4+Pj4gaW5kZXggNTBkMjA5OS4uZGRhMDIwZiAx
MDA2NDQNCj4+Pj4gLS0tIGEvYXJjaC94ODYvbW0vbWVtX2VuY3J5cHQuYw0KPj4+PiArKysg
Yi9hcmNoL3g4Ni9tbS9tZW1fZW5jcnlwdC5jDQo+Pj4+IEBAIC03Nyw4ICs3NywzIEBAIHZv
aWQgX19pbml0IG1lbV9lbmNyeXB0X2luaXQodm9pZCkNCj4+Pj4gICAgCXByaW50X21lbV9l
bmNyeXB0X2ZlYXR1cmVfaW5mbygpOw0KPj4+PiAgICB9DQo+Pj4+ICAgIC1pbnQgYXJjaF9o
YXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vzcyh2b2lkKQ0KPj4+PiAtew0KPj4+
PiAtCXJldHVybiBjY19wbGF0Zm9ybV9oYXMoQ0NfQVRUUl9HVUVTVF9NRU1fRU5DUllQVCk7
DQo+Pj4+IC19DQo+Pj4+IC1FWFBPUlRfU1lNQk9MX0dQTChhcmNoX2hhc19yZXN0cmljdGVk
X3ZpcnRpb19tZW1vcnlfYWNjZXNzKTsNCj4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L3hl
bi9LY29uZmlnIGIvYXJjaC94ODYveGVuL0tjb25maWcNCj4+Pj4gaW5kZXggODUyNDZkZC4u
ZGZmZGZmZCAxMDA2NDQNCj4+Pj4gLS0tIGEvYXJjaC94ODYveGVuL0tjb25maWcNCj4+Pj4g
KysrIGIvYXJjaC94ODYveGVuL0tjb25maWcNCj4+Pj4gQEAgLTkyLDMgKzkyLDEyIEBAIGNv
bmZpZyBYRU5fRE9NMA0KPj4+PiAgICAJc2VsZWN0IFg4Nl9YMkFQSUMgaWYgWEVOX1BWSCAm
JiBYODZfNjQNCj4+Pj4gICAgCWhlbHANCj4+Pj4gICAgCSAgU3VwcG9ydCBydW5uaW5nIGFz
IGEgWGVuIERvbTAgZ3Vlc3QuDQo+Pj4+ICsNCj4+Pj4gK2NvbmZpZyBYRU5fUFZfVklSVElP
DQo+Pj4+ICsJYm9vbCAiWGVuIHZpcnRpbyBzdXBwb3J0IGZvciBQViBndWVzdHMiDQo+Pj4+
ICsJZGVwZW5kcyBvbiBYRU5fVklSVElPICYmIFhFTl9QVg0KPj4+PiArCWRlZmF1bHQgeQ0K
Pj4+PiArCWhlbHANCj4+Pj4gKwkgIFN1cHBvcnQgdmlydGlvIGZvciBydW5uaW5nIGFzIGEg
cGFyYXZpcnR1YWxpemVkIGd1ZXN0LiBUaGlzIHdpbGwNCj4+Pj4gKwkgIG5lZWQgc3VwcG9y
dCBvbiB0aGUgYmFja2VuZCBzaWRlIChxZW11IG9yIGtlcm5lbCwgZGVwZW5kaW5nIG9uIHRo
ZQ0KPj4+PiArCSAgdmlydGlvIGRldmljZSB0eXBlcyB1c2VkKS4NCj4+Pj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMveGVuL0tjb25maWcgYi9kcml2ZXJzL3hlbi9LY29uZmlnDQo+Pj4+IGlu
ZGV4IDEyMGQzMmYuLmZjNjFmN2EgMTAwNjQ0DQo+Pj4+IC0tLSBhL2RyaXZlcnMveGVuL0tj
b25maWcNCj4+Pj4gKysrIGIvZHJpdmVycy94ZW4vS2NvbmZpZw0KPj4+PiBAQCAtMzM1LDQg
KzMzNSwyNCBAQCBjb25maWcgWEVOX1VOUE9QVUxBVEVEX0FMTE9DDQo+Pj4+ICAgIAkgIGhh
dmluZyB0byBiYWxsb29uIG91dCBSQU0gcmVnaW9ucyBpbiBvcmRlciB0byBvYnRhaW4gcGh5
c2ljYWwgbWVtb3J5DQo+Pj4+ICAgIAkgIHNwYWNlIHRvIGNyZWF0ZSBzdWNoIG1hcHBpbmdz
Lg0KPj4+PiAgICArY29uZmlnIFhFTl9WSVJUSU8NCj4+Pj4gKwlib29sICJYZW4gdmlydGlv
IHN1cHBvcnQiDQo+Pj4+ICsJZGVmYXVsdCBuDQo+Pj4+ICsJZGVwZW5kcyBvbiBWSVJUSU8g
JiYgRE1BX09QUw0KPj4+PiArCXNlbGVjdCBBUkNIX0hBU19SRVNUUklDVEVEX1ZJUlRJT19N
RU1PUllfQUNDRVNTDQo+Pj4+ICsJaGVscA0KPj4+PiArCSAgRW5hYmxlIHZpcnRpbyBzdXBw
b3J0IGZvciBydW5uaW5nIGFzIFhlbiBndWVzdC4gRGVwZW5kaW5nIG9uIHRoZQ0KPj4+PiAr
CSAgZ3Vlc3QgdHlwZSB0aGlzIHdpbGwgcmVxdWlyZSBzcGVjaWFsIHN1cHBvcnQgb24gdGhl
IGJhY2tlbmQgc2lkZQ0KPj4+PiArCSAgKHFlbXUgb3Iga2VybmVsLCBkZXBlbmRpbmcgb24g
dGhlIHZpcnRpbyBkZXZpY2UgdHlwZXMgdXNlZCkuDQo+Pj4+ICsNCj4+Pj4gK2NvbmZpZyBY
RU5fSFZNX1ZJUlRJT19HUkFOVA0KPj4+PiArCWJvb2wgIlJlcXVpcmUgdmlydGlvIGZvciBm
dWxseSB2aXJ0dWFsaXplZCBndWVzdHMgdG8gdXNlIGdyYW50DQo+Pj4+IG1hcHBpbmdzIg0K
Pj4+PiArCWRlcGVuZHMgb24gWEVOX1ZJUlRJTyAmJiBYODZfNjQNCj4+Pj4gKwlkZWZhdWx0
IHkNCj4+Pj4gKwloZWxwDQo+Pj4+ICsJICBSZXF1aXJlIHZpcnRpbyBmb3IgZnVsbHkgdmly
dHVhbGl6ZWQgZ3Vlc3RzIHRvIHVzZSBncmFudCBtYXBwaW5ncy4NCj4+Pj4gKwkgIFRoaXMg
d2lsbCBhdm9pZCB0aGUgbmVlZCB0byBnaXZlIHRoZSBiYWNrZW5kIHRoZSByaWdodCB0byBt
YXAgYWxsDQo+Pj4+ICsJICBvZiB0aGUgZ3Vlc3QgbWVtb3J5LiBUaGlzIHdpbGwgbmVlZCBz
dXBwb3J0IG9uIHRoZSBiYWNrZW5kIHNpZGUNCj4+Pj4gKwkgIChxZW11IG9yIGtlcm5lbCwg
ZGVwZW5kaW5nIG9uIHRoZSB2aXJ0aW8gZGV2aWNlIHR5cGVzIHVzZWQpLg0KPj4+IEkgZG9u
J3QgdGhpbmsgd2UgbmVlZCAzIHZpc2libGUga2NvbmZpZyBvcHRpb25zIGZvciB0aGlzLg0K
Pj4+DQo+Pj4gSW4gZmFjdCwgSSB3b3VsZCBvbmx5IGFkZCBvbmU6IFhFTl9WSVJUSU8uIFdl
IGNhbiBoYXZlIGFueSBYODYgKG9yIEFSTSkNCj4+PiBzcGVjaWZpYyBkZXBlbmRlbmNpZXMg
aW4gdGhlICJkZXBlbmRzIiBsaW5lIHVuZGVyIFhFTl9WSVJUSU8uIEFuZCBJDQo+Pj4gZG9u
J3QgdGhpbmsgd2UgbmVlZCBYRU5fSFZNX1ZJUlRJT19HUkFOVCBhcyBhIGtjb25maWcgb3B0
aW9uDQo+Pj4gbmVjZXNzYXJlbHkuIEl0IGRvZXNuJ3Qgc2VlbSBsaWtlIHNvbWUgd2Ugd2Fu
dCBhcyBidWlsZCB0aW1lIG9wdGlvbi4gQXQNCj4+PiBtb3N0LCBpdCBjb3VsZCBiZSBhIHJ1
bnRpbWUgb3B0aW9uIChsaWtlIGEgY29tbWFuZCBsaW5lKSBvciBhIGRlYnVnDQo+Pj4gb3B0
aW9uIChsaWtlIGFuICNkZWZpbmUgYXQgdGhlIHRvcCBvZiB0aGUgc291cmNlIGZpbGUuKQ0K
Pj4NCj4+DQo+PiBJIGRvbid0IGtub3cgd2hhdCB3YXMgdGhlIGluaXRpYWwgaWRlYSBvZiBo
YXZpbmcgYW5kIGV4dHJhIFhFTl9IVk1fVklSVElPIGFuZA0KPj4gWEVOX1BWX1ZJUlRJTyBv
cHRpb25zLCBidXQgdGFraW5nIGludG8gdGhlIGFjY291bnQgdGhhdA0KPj4gdGhleSBhcmUg
b25seSB1c2VkIGluIGFyY2hfaGFzX3Jlc3RyaWN0ZWRfdmlydGlvX21lbW9yeV9hY2Nlc3Mo
KSBjdXJyZW50bHksIEkNCj4+IHNoYXJlIHlvdXIgb3BpbmlvbiByZWdhcmRpbmcgYSBzaW5n
bGUgWEVOX1ZJUlRJTyBvcHRpb24uDQo+Pg0KPj4gTG9va2luZyBhaGVhZCAoaW5jbHVkaW5n
IGNoYW5nZXMgaW4gdGhlIGNvbW1pdCAjNCksIHdlIGNhbiBpbWFnaW5lIHRoZQ0KPj4gcmVz
dWx0aW5nIG9wdGlvbjoNCj4+DQo+PiBjb25maWcgWEVOX1ZJUlRJTw0KPj4gIMKgwqDCoCBi
b29sICJYZW4gdmlydGlvIHN1cHBvcnQiDQo+PiAgwqDCoMKgIGRlZmF1bHQgbg0KPj4gIMKg
wqDCoCBkZXBlbmRzIG9uIFZJUlRJTyAmJiBETUFfT1BTDQo+PiAgwqDCoMKgIGRlcGVuZHMg
b24gKFg4Nl82NCB8fCBBUk0gfHwgQVJNNjQpDQo+PiAgwqDCoMKgIHNlbGVjdCBBUkNIX0hB
U19SRVNUUklDVEVEX1ZJUlRJT19NRU1PUllfQUNDRVNTDQo+PiAgwqDCoMKgIGhlbHANCj4+
ICDCoMKgwqAgwqAgRW5hYmxlIHZpcnRpbyBzdXBwb3J0IGZvciBydW5uaW5nIGFzIFhlbiBn
dWVzdC4gRGVwZW5kaW5nIG9uIHRoZQ0KPj4gIMKgwqDCoCDCoCBndWVzdCB0eXBlIHRoaXMg
d2lsbCByZXF1aXJlIHNwZWNpYWwgc3VwcG9ydCBvbiB0aGUgYmFja2VuZCBzaWRlDQo+PiAg
wqDCoMKgIMKgIChxZW11IG9yIGtlcm5lbCwgZGVwZW5kaW5nIG9uIHRoZSB2aXJ0aW8gZGV2
aWNlIHR5cGVzIHVzZWQpLg0KPj4NCj4+DQo+PiBhbmQgdGhlbiBhcmNoX2hhc19yZXN0cmlj
dGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNzKCkgcGVyIGFyY2g6DQo+Pg0KPj4NCj4+IDEuIHg4
NjoNCj4+DQo+PiBpbnQgYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vz
cyh2b2lkKQ0KPj4gew0KPj4gIMKgwqDCoCByZXR1cm4gKHhlbl9oYXNfcmVzdHJpY3RlZF92
aXJ0aW9fbWVtb3J5X2FjY2VzcygpIHx8DQo+PiAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgY2Nf
cGxhdGZvcm1faGFzKENDX0FUVFJfR1VFU1RfTUVNX0VOQ1JZUFQpKTsNCj4+IH0NCj4+DQo+
Pg0KPj4gMi4gQXJtOg0KPj4NCj4+IGludCBhcmNoX2hhc19yZXN0cmljdGVkX3ZpcnRpb19t
ZW1vcnlfYWNjZXNzKHZvaWQpDQo+PiB7DQo+PiAgwqDCoMKgIHJldHVybiB4ZW5faGFzX3Jl
c3RyaWN0ZWRfdmlydGlvX21lbW9yeV9hY2Nlc3MoKTsNCj4+IH0NCj4+DQo+Pg0KPj4gMy4g
eGVuLmg6DQo+Pg0KPj4gc3RhdGljIGlubGluZSBpbnQgeGVuX2hhc19yZXN0cmljdGVkX3Zp
cnRpb19tZW1vcnlfYWNjZXNzKHZvaWQpDQo+PiB7DQo+PiAgwqDCoMKgIGlmIChJU19FTkFC
TEVEKENPTkZJR19YRU5fVklSVElPKSAmJiAoeGVuX3B2X2RvbWFpbigpIHx8DQo+PiB4ZW5f
aHZtX2RvbWFpbigpKSkNCj4+ICDCoMKgwqAgwqDCoMKgIHJldHVybiAxOw0KPj4NCj4+ICDC
oMKgwqAgcmV0dXJuIDA7DQo+PiB9DQo+Pg0KPj4NCj4+IEFjdHVhbGx5LCBhcyBkb21haW4g
dHlwZSBvbiBBcm0gaXMgYWx3YXlzIFhFTl9IVk1fRE9NQUlOLCB3ZSBjb3VsZCBwcm9iYWJs
eQ0KPj4gaGF2ZSB0aGUgZm9sbG93aW5nIG9uIEFybToNCj4+DQo+PiBpbnQgYXJjaF9oYXNf
cmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vzcyh2b2lkKQ0KPj4gew0KPj4gIMKgwqDC
oCByZXR1cm4gSVNfRU5BQkxFRChDT05GSUdfWEVOX1ZJUlRJTyk7DQo+PiB9DQo+Pg0KPj4g
YnV0IEkgd291bGQgcHJlZmVyIG5vdCB0byBkaXZlcmdlIGFuZCB1c2UgY29tbW9uDQo+PiB4
ZW5faGFzX3Jlc3RyaWN0ZWRfdmlydGlvX21lbW9yeV9hY2Nlc3MoKS4NCj4+DQo+PiBBbnkg
dGhvdWdodHM/DQo+IA0KPiBZZXMsIEkgd291bGQgYWxzbyBwcmVmZXIgbm90IHRvIGRpdmVy
Z2UgYmV0d2VlbiB0aGUgeDg2IGFuZCBhcm0gdmVyc2lvbnMNCj4gb2YgeGVuX2hhc19yZXN0
cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNzLiBCdXQgd2hhdCBjYXNlIGFyZSB3ZSB0cnlp
bmcNCj4gdG8gY2F0Y2ggd2l0aCAoeGVuX3B2X2RvbWFpbigpIHx8IHhlbl9odm1fZG9tYWlu
KCkpID8gRXZlbiBvbiB4ODYsIGl0IGlzDQo+IG5vdCBnb2luZyB0byBsZWF2ZSBtdWNoIG91
dC4gSXMgaXQgcmVhbGx5IG1lYW50IG9ubHkgdG8gZXhjbHVkZSBwdmgNCj4gZG9tYWlucz8N
Cg0KSXQgd291bGRuJ3QgZXhjbHVkZSBwdmggZG9tYWlucy4NCg0KPiANCj4gSSBoYXZlIHRo
ZSBmZWVsaW5nIHRoYXQgd2UgY291bGQgdHVybiB0aGlzIGNoZWNrIGludG86DQo+IA0KPiBz
dGF0aWMgaW5saW5lIGludCB4ZW5faGFzX3Jlc3RyaWN0ZWRfdmlydGlvX21lbW9yeV9hY2Nl
c3Modm9pZCkNCj4gew0KPiAgICAgIHJldHVybiBJU19FTkFCTEVEKENPTkZJR19YRU5fVklS
VElPKSAmJiB4ZW5fZG9tYWluKCk7DQo+IH0NCj4gDQo+IGV2ZW4gb24geDg2LCBidXQgb25l
IG9mIHRoZSB4ZW4veDg2IG1haW50YWluZXJzIHNob3VsZCBjb25maXJtLg0KDQpJIGRvIGNv
bmZpcm0gdGhpcyBpcyBiZXR0ZXIgYW5kIGZ1bmN0aW9uYWxseSBlcXVpdmFsZW50Lg0KDQoN
Ckp1ZXJnZW4NCg==
--------------9hgp6EPShCnsxphgBLzhQbzX
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------9hgp6EPShCnsxphgBLzhQbzX--

--------------MFzWi6q0y0Ygy4pZ20Jx5X4F--

--------------ispkVl45x6FrSWcrxAB1CcR0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJeVOgFAwAAAAAACgkQsN6d1ii/Ey+i
wwf+PZN/+STHtk1BQfOx18wax94IJ9kZXW3mihzciSJ4NiH9b9ViCZjwBh62HG4WdNpCKy09JIRO
6oA87NyizTGiHfZceUwgRdXfB+PwOSSFitEwGULiVwRhccTjn1qrVtBMEJOfBBZA3FssiIjaoobp
7rpC9Nun0KskK1xLJtrbneX3u+ylalrZSiwDLiJd8hCpWhkt2He+SYkRNe3udVDwlEZfwi/iCfvf
XcQJXopNmUFaCo369IAXVRY1xy5KDt/ofvBqiS3Ojzv0GUZ53HbNtDvcSKMXMgIA+dooqbK+YLai
OMoNczJKrEGPdqkbrqoSvyzCli21gy3r5j8F/iOagw==
=L0/z
-----END PGP SIGNATURE-----

--------------ispkVl45x6FrSWcrxAB1CcR0--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 06:28:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 06:28:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307772.523049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghLQ-0005SJ-Bz; Tue, 19 Apr 2022 06:28:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307772.523049; Tue, 19 Apr 2022 06:28:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghLQ-0005SC-8s; Tue, 19 Apr 2022 06:28:12 +0000
Received: by outflank-mailman (input) for mailman id 307772;
 Tue, 19 Apr 2022 06:28:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uEip=U5=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nghLO-0005S6-Rh
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 06:28:10 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id e0ee5fd5-bfa9-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 08:28:09 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 358C51042;
 Mon, 18 Apr 2022 23:28:08 -0700 (PDT)
Received: from [10.57.11.171] (unknown [10.57.11.171])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D64D13F766;
 Mon, 18 Apr 2022 23:28:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0ee5fd5-bfa9-11ec-a405-831a346695d4
Message-ID: <c2030fd0-8aed-6a68-e275-77d22f972dfc@arm.com>
Date: Tue, 19 Apr 2022 08:28:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] xen/arm: Make use of DT_MATCH_TIMER in make_timer_node
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220414095843.102305-1-michal.orzel@arm.com>
 <alpine.DEB.2.22.394.2204151609140.915916@ubuntu-linux-20-04-desktop>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <alpine.DEB.2.22.394.2204151609140.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 16.04.2022 01:10, Stefano Stabellini wrote:
> On Thu, 14 Apr 2022, Michal Orzel wrote:
>> DT_MATCH_TIMER stores the compatible timer ids and as such should be
>> used in all the places where we need to refer to them. make_timer_node
>> explicitly lists the same ids as the ones defined in DT_MATCH_TIMER so
>> make use of this macro instead.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> 
> This is a good cleanup, thanks! time.h is not currently included by
> domain_build.c, I think we should add:
> 
> #include <asm/time.h>
> 
> to domain_build.c 
> 
asm/time.h is included by xen/time.h which is included by xen/irq.h.
That is why there is no build failure and the patch itself is correct.

Furthermore DT_MATCH_TIMER is already used in domain_build.c (handle_node)
together with other constructs like TIMER_PHYS_SECURE_PPI defined in asm/time.h.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 06:31:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 06:31:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307776.523060 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghOq-0006pi-S2; Tue, 19 Apr 2022 06:31:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307776.523060; Tue, 19 Apr 2022 06:31:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghOq-0006pb-OL; Tue, 19 Apr 2022 06:31:44 +0000
Received: by outflank-mailman (input) for mailman id 307776;
 Tue, 19 Apr 2022 06:31:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uEip=U5=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nghOp-0006pV-7z
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 06:31:43 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 5f9ec291-bfaa-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 08:31:41 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A767E1042;
 Mon, 18 Apr 2022 23:31:41 -0700 (PDT)
Received: from [10.57.11.171] (unknown [10.57.11.171])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB0BB3F766;
 Mon, 18 Apr 2022 23:31:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f9ec291-bfaa-11ec-8fbe-03012f2f19d4
Message-ID: <6e01871e-9e47-2d92-617e-952dde2df3b2@arm.com>
Date: Tue, 19 Apr 2022 08:31:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v5 2/2] gitlab-ci: add an ARM32 qemu-based smoke test
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: cardoe@cardoe.com, wl@xen.org, andrew.cooper3@citrix.com,
 anthony.perard@citrix.com, bertrand.marquis@arm.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop>
 <20220416001701.1301324-2-sstabellini@kernel.org>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220416001701.1301324-2-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 16.04.2022 02:17, Stefano Stabellini wrote:
> Add a minimal ARM32 smoke test based on qemu-system-arm, as provided by
> the test-artifacts qemu container. The minimal test simply boots Xen
> (built from previous build stages) and Dom0.
> 
> The test needs a working kernel and minimal initrd for dom0. Instead of
> building our own kernel and initrd, which would mean maintaining one or
> two more builting scripts under automation/, we borrow a kernel and
> initrd from distros.
> 
> For the kernel we pick the Debian Bullseye kernel, which has everything
> we need already built-in. However, we cannot use the Debian Bullseye
> initrd because it is 22MB and the large size causes QEMU to core dump.
> 
> Instead, use the tiny busybox-based rootfs provided by Alpine Linux,
> which is really minimal: just 2.5MB. Note that we cannot use the Alpine
> Linux kernel because that doesn't boot on Xen.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> ---
> Changes in v5:
> - use "virt" machine in QEMU

> +# For Xen, we need a couple of more node. Dump the DT from QEMU and add them
> +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded
> +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom
> +./qemu-system-arm \
> +   -machine virt \
You changed machine to virt here, but ...

> +rm -f smoke.serial
> +set +e
> +timeout -k 1 240 \
> +./qemu-system-arm \
> +   -machine virt-6.0 \
forgot to change it here as well.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 06:37:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 06:37:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307781.523071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghUX-0007au-GR; Tue, 19 Apr 2022 06:37:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307781.523071; Tue, 19 Apr 2022 06:37:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghUX-0007an-DK; Tue, 19 Apr 2022 06:37:37 +0000
Received: by outflank-mailman (input) for mailman id 307781;
 Tue, 19 Apr 2022 06:37:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tr1R=U5=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nghUV-0007ah-Uz
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 06:37:36 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 32434430-bfab-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 08:37:34 +0200 (CEST)
Received: by mail-lf1-x134.google.com with SMTP id y32so27653535lfa.6
 for <xen-devel@lists.xenproject.org>; Mon, 18 Apr 2022 23:37:34 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 b15-20020ac2562f000000b004437f2667bfsm1418167lff.308.2022.04.18.23.37.32
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 18 Apr 2022 23:37:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32434430-bfab-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=5XKHbxSoKgLV4l6KLfHSllkOSuhO/yQcH7URIe/RXvI=;
        b=BYPkS0mpRwyVL9+QysC/keXryrD+pxuYOK+l6BJJIivxNikhJ0VtOVqV0+B0uiYhaL
         DjZ23GRUAgibnxdNIYb+7rrBrziMLsMzetdRhrLEVUeEoQQrNLNYHbscuspqA1h/nqmj
         6M48Lcp3KfrE1wn39oOaq5AA0prsFcogF73dVS8jB3fLuFfhoI040zgnqPgm3giiysBx
         1yVaxxA5Dic0aV4U5zVVFA/g2Sx6Me5dYB4w5CpojlKhQwWaF2nLmKspLwI7WeV3yXms
         kHxkI4gz+mi4riP69GlEkJdFijXXH8B+xc8x3GERO8+4CKKcLBqxOHAbnZeJriADnkHn
         Sn5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=5XKHbxSoKgLV4l6KLfHSllkOSuhO/yQcH7URIe/RXvI=;
        b=Z/kLCknNPgc4CCWRS53ov3wXGoiIY4HtDNILwbmaMKUeiEWz12zpki/w5B4vqb1xXK
         DJdE5A44t6PauLBE1/RWmU2CY8yO7RYbYgEeUhZbc16F2Uetje67WbBeW9kf9G4dNbmQ
         7JtLcld1wQVZZ2nLmSavlllgqVlTFpQpOp/RzqhTOwOgB82+/eSS4gRh1JMP6gMlytIT
         YIo6WJpPSfa6TPgZwKxQK+3Hxf9bZg1odHLgn+XsPB+b7XBVJibR2vmJtaik91/A7onS
         N0OlrMEsm+oML8uwFJocdKhew58y1orc0L7IsDBNAhHhPhczcyoFL169ycXBSaw6r5c0
         h/tQ==
X-Gm-Message-State: AOAM530Uq4HIjPST7xm6193NchIFjckcHMcHfjnOKj+ibwQMg9hzwrYY
	tcqKUEjEQn1OOsyj+k54An8=
X-Google-Smtp-Source: ABdhPJx0KZwoC2ACm+X1wAjeDTfX3UjujeGdQe8hMMbvoAvvFDS4CUtPuCSHarytJl83njjUXCAAng==
X-Received: by 2002:a05:6512:23a8:b0:470:77ac:64b1 with SMTP id c40-20020a05651223a800b0047077ac64b1mr9346732lfv.322.1650350253959;
        Mon, 18 Apr 2022 23:37:33 -0700 (PDT)
Subject: Re: [RFC PATCH 2/6] virtio: add option to restrict memory access
 under Xen
To: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
 Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 linux-arm-kernel@lists.infradead.org, Christoph Hellwig <hch@infradead.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151235440.915916@ubuntu-linux-20-04-desktop>
 <8a66ad42-a3e7-c29d-7d4e-35766dcccd15@gmail.com>
 <alpine.DEB.2.22.394.2204181151030.915916@ubuntu-linux-20-04-desktop>
 <ef637f17-0e9c-2f86-218b-918297cb9930@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <5b6f8f1c-1ffd-9582-89b4-54f73ec4f5c4@gmail.com>
Date: Tue, 19 Apr 2022 09:37:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <ef637f17-0e9c-2f86-218b-918297cb9930@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hello Stefano, Juergen


On 19.04.22 09:21, Juergen Gross wrote:
> On 18.04.22 21:11, Stefano Stabellini wrote:
>> On Sun, 17 Apr 2022, Oleksandr wrote:
>>> On 16.04.22 01:01, Stefano Stabellini wrote:
>>>> On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
>>>>> From: Juergen Gross <jgross@suse.com>
>>>>>
>>>>> In order to support virtio in Xen guests add a config option enabling
>>>>> the user to specify whether in all Xen guests virtio should be 
>>>>> able to
>>>>> access memory via Xen grant mappings only on the host side.
>>>>>
>>>>> This applies to fully virtualized guests only, as for paravirtualized
>>>>> guests this is mandatory.
>>>>>
>>>>> This requires to switch arch_has_restricted_virtio_memory_access()
>>>>> from a pure stub to a real function on x86 systems (Arm systems are
>>>>> not covered by now).
>>>>>
>>>>> Add the needed functionality by providing a special set of DMA ops
>>>>> handling the needed grant operations for the I/O pages.
>>>>>
>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>> ---
>>>>>    arch/x86/mm/init.c        |  15 ++++
>>>>>    arch/x86/mm/mem_encrypt.c |   5 --
>>>>>    arch/x86/xen/Kconfig      |   9 +++
>>>>>    drivers/xen/Kconfig       |  20 ++++++
>>>>>    drivers/xen/Makefile      |   1 +
>>>>>    drivers/xen/xen-virtio.c  | 177
>>>>> ++++++++++++++++++++++++++++++++++++++++++++++
>>>>>    include/xen/xen-ops.h     |   8 +++
>>>>>    7 files changed, 230 insertions(+), 5 deletions(-)
>>>>>    create mode 100644 drivers/xen/xen-virtio.c
>>>>>
>>>>> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
>>>>> index d8cfce2..526a3b2 100644
>>>>> --- a/arch/x86/mm/init.c
>>>>> +++ b/arch/x86/mm/init.c
>>>>> @@ -8,6 +8,8 @@
>>>>>    #include <linux/kmemleak.h>
>>>>>    #include <linux/sched/task.h>
>>>>>    +#include <xen/xen.h>
>>>>> +
>>>>>    #include <asm/set_memory.h>
>>>>>    #include <asm/e820/api.h>
>>>>>    #include <asm/init.h>
>>>>> @@ -1065,3 +1067,16 @@ unsigned long max_swapfile_size(void)
>>>>>        return pages;
>>>>>    }
>>>>>    #endif
>>>>> +
>>>>> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>>>>> +int arch_has_restricted_virtio_memory_access(void)
>>>>> +{
>>>>> +    if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain())
>>>>> +        return 1;
>>>>> +    if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
>>>>> +        return 1;
>>>> I think these two checks could be moved to a separate function in a 
>>>> Xen
>>>> header, e.g. xen_restricted_virtio_memory_access, and here you could
>>>> just
>>>>
>>>> if (xen_restricted_virtio_memory_access())
>>>>       return 1;
>>>
>>> Agree, will do
>>>
>>>
>>>>
>>>>
>>>>
>>>>> +    return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
>>>>> +}
>>>>> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>>>>> +#endif
>>>>> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
>>>>> index 50d2099..dda020f 100644
>>>>> --- a/arch/x86/mm/mem_encrypt.c
>>>>> +++ b/arch/x86/mm/mem_encrypt.c
>>>>> @@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
>>>>>        print_mem_encrypt_feature_info();
>>>>>    }
>>>>>    -int arch_has_restricted_virtio_memory_access(void)
>>>>> -{
>>>>> -    return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
>>>>> -}
>>>>> -EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>>>>> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
>>>>> index 85246dd..dffdffd 100644
>>>>> --- a/arch/x86/xen/Kconfig
>>>>> +++ b/arch/x86/xen/Kconfig
>>>>> @@ -92,3 +92,12 @@ config XEN_DOM0
>>>>>        select X86_X2APIC if XEN_PVH && X86_64
>>>>>        help
>>>>>          Support running as a Xen Dom0 guest.
>>>>> +
>>>>> +config XEN_PV_VIRTIO
>>>>> +    bool "Xen virtio support for PV guests"
>>>>> +    depends on XEN_VIRTIO && XEN_PV
>>>>> +    default y
>>>>> +    help
>>>>> +      Support virtio for running as a paravirtualized guest. This 
>>>>> will
>>>>> +      need support on the backend side (qemu or kernel, depending 
>>>>> on the
>>>>> +      virtio device types used).
>>>>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>>>>> index 120d32f..fc61f7a 100644
>>>>> --- a/drivers/xen/Kconfig
>>>>> +++ b/drivers/xen/Kconfig
>>>>> @@ -335,4 +335,24 @@ config XEN_UNPOPULATED_ALLOC
>>>>>          having to balloon out RAM regions in order to obtain 
>>>>> physical memory
>>>>>          space to create such mappings.
>>>>>    +config XEN_VIRTIO
>>>>> +    bool "Xen virtio support"
>>>>> +    default n
>>>>> +    depends on VIRTIO && DMA_OPS
>>>>> +    select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>>>>> +    help
>>>>> +      Enable virtio support for running as Xen guest. Depending 
>>>>> on the
>>>>> +      guest type this will require special support on the backend 
>>>>> side
>>>>> +      (qemu or kernel, depending on the virtio device types used).
>>>>> +
>>>>> +config XEN_HVM_VIRTIO_GRANT
>>>>> +    bool "Require virtio for fully virtualized guests to use grant
>>>>> mappings"
>>>>> +    depends on XEN_VIRTIO && X86_64
>>>>> +    default y
>>>>> +    help
>>>>> +      Require virtio for fully virtualized guests to use grant 
>>>>> mappings.
>>>>> +      This will avoid the need to give the backend the right to 
>>>>> map all
>>>>> +      of the guest memory. This will need support on the backend 
>>>>> side
>>>>> +      (qemu or kernel, depending on the virtio device types used).
>>>> I don't think we need 3 visible kconfig options for this.
>>>>
>>>> In fact, I would only add one: XEN_VIRTIO. We can have any X86 (or 
>>>> ARM)
>>>> specific dependencies in the "depends" line under XEN_VIRTIO. And I
>>>> don't think we need XEN_HVM_VIRTIO_GRANT as a kconfig option
>>>> necessarely. It doesn't seem like some we want as build time 
>>>> option. At
>>>> most, it could be a runtime option (like a command line) or a debug
>>>> option (like an #define at the top of the source file.)
>>>
>>>
>>> I don't know what was the initial idea of having and extra 
>>> XEN_HVM_VIRTIO and
>>> XEN_PV_VIRTIO options, but taking into the account that
>>> they are only used in arch_has_restricted_virtio_memory_access() 
>>> currently, I
>>> share your opinion regarding a single XEN_VIRTIO option.
>>>
>>> Looking ahead (including changes in the commit #4), we can imagine the
>>> resulting option:
>>>
>>> config XEN_VIRTIO
>>>      bool "Xen virtio support"
>>>      default n
>>>      depends on VIRTIO && DMA_OPS
>>>      depends on (X86_64 || ARM || ARM64)
>>>      select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>>>      help
>>>        Enable virtio support for running as Xen guest. Depending on the
>>>        guest type this will require special support on the backend side
>>>        (qemu or kernel, depending on the virtio device types used).
>>>
>>>
>>> and then arch_has_restricted_virtio_memory_access() per arch:
>>>
>>>
>>> 1. x86:
>>>
>>> int arch_has_restricted_virtio_memory_access(void)
>>> {
>>>      return (xen_has_restricted_virtio_memory_access() ||
>>>              cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
>>> }
>>>
>>>
>>> 2. Arm:
>>>
>>> int arch_has_restricted_virtio_memory_access(void)
>>> {
>>>      return xen_has_restricted_virtio_memory_access();
>>> }
>>>
>>>
>>> 3. xen.h:
>>>
>>> static inline int xen_has_restricted_virtio_memory_access(void)
>>> {
>>>      if (IS_ENABLED(CONFIG_XEN_VIRTIO) && (xen_pv_domain() ||
>>> xen_hvm_domain()))
>>>          return 1;
>>>
>>>      return 0;
>>> }
>>>
>>>
>>> Actually, as domain type on Arm is always XEN_HVM_DOMAIN, we could 
>>> probably
>>> have the following on Arm:
>>>
>>> int arch_has_restricted_virtio_memory_access(void)
>>> {
>>>      return IS_ENABLED(CONFIG_XEN_VIRTIO);
>>> }
>>>
>>> but I would prefer not to diverge and use common
>>> xen_has_restricted_virtio_memory_access().
>>>
>>> Any thoughts?
>>
>> Yes, I would also prefer not to diverge between the x86 and arm versions
>> of xen_has_restricted_virtio_memory_access. But what case are we trying
>> to catch with (xen_pv_domain() || xen_hvm_domain()) ? Even on x86, it is
>> not going to leave much out. Is it really meant only to exclude pvh
>> domains?

Good question. By leaving (xen_pv_domain() || xen_hvm_domain()) here I 
tried to retain what the *initial* version of 
arch_has_restricted_virtio_memory_access() covered.


>
> It wouldn't exclude pvh domains.


ok


>
>>
>> I have the feeling that we could turn this check into:
>>
>> static inline int xen_has_restricted_virtio_memory_access(void)
>> {
>>      return IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain();
>> }
>>
>> even on x86, but one of the xen/x86 maintainers should confirm.
>
> I do confirm this is better and functionally equivalent.


Perfect, thank you for confirming. Will use that check.


>
>
> Juergen

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 06:57:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 06:57:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307785.523082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghnP-0001jU-51; Tue, 19 Apr 2022 06:57:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307785.523082; Tue, 19 Apr 2022 06:57:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghnP-0001jN-1O; Tue, 19 Apr 2022 06:57:07 +0000
Received: by outflank-mailman (input) for mailman id 307785;
 Tue, 19 Apr 2022 06:57:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uEip=U5=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nghnO-0001jH-CP
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 06:57:06 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id eb2c8f8d-bfad-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 08:57:04 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3DCAF1042;
 Mon, 18 Apr 2022 23:57:04 -0700 (PDT)
Received: from [10.57.11.171] (unknown [10.57.11.171])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B47343F766;
 Mon, 18 Apr 2022 23:57:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb2c8f8d-bfad-11ec-8fbe-03012f2f19d4
Message-ID: <c8b9385b-1b91-9009-f5f7-991ce5f3ecd5@arm.com>
Date: Tue, 19 Apr 2022 08:56:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V6 2/2] xen/arm: Add i.MX lpuart early printk support
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220419043927.23542-1-peng.fan@oss.nxp.com>
 <20220419043927.23542-3-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220419043927.23542-3-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Peng,

On 19.04.2022 06:39, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

In the v5, I gave you R-by and Bertrand gave A-by so you should have
carried them as you haven't done any modificiation in this patch since v5.

Anyway,
Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 06:58:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 06:58:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307792.523093 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghoe-0002Hh-EQ; Tue, 19 Apr 2022 06:58:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307792.523093; Tue, 19 Apr 2022 06:58:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghoe-0002Ha-BW; Tue, 19 Apr 2022 06:58:24 +0000
Received: by outflank-mailman (input) for mailman id 307792;
 Tue, 19 Apr 2022 06:58:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nghod-0002GO-41
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 06:58:23 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 19bdb7b0-bfae-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 08:58:22 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 97BB51F383;
 Tue, 19 Apr 2022 06:58:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 439B9132E7;
 Tue, 19 Apr 2022 06:58:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ec8gD41dXmJXQAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 06:58:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19bdb7b0-bfae-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650351501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=e+Y693yg71upH0P/35+ersl3llCGE9Kuiod2s7Spix8=;
	b=nzzYfgPGWhUoa58qLYAjdJ4PvFpHfBtJC1InTNgVLUcbJ1zwLQKyQLY9Uz6yUoHSofG15F
	rJdRxrKzJFai9qVXG5hsnXrVSovBENLeS5QFaKG+YrItCydDjId6O4nxF+kuMDF4dTfwMx
	r5HBMz+g6jSIgX9B1BMmnS98tVu/Qmg=
Message-ID: <de61ab3a-a6e9-0209-f06a-dc04d3b14f5d@suse.com>
Date: Tue, 19 Apr 2022 08:58:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Russell King <linux@armlinux.org.uk>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151302350.915916@ubuntu-linux-20-04-desktop>
 <84f5264c-6b98-6d56-b7ca-61c19dc502ca@gmail.com>
 <alpine.DEB.2.22.394.2204181156280.915916@ubuntu-linux-20-04-desktop>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops
 layer
In-Reply-To: <alpine.DEB.2.22.394.2204181156280.915916@ubuntu-linux-20-04-desktop>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------zEq0HDPLD0VYb57K7jEjRPEq"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------zEq0HDPLD0VYb57K7jEjRPEq
Content-Type: multipart/mixed; boundary="------------oInpg5CSFyyPOeZGwl5wBsnf";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Russell King <linux@armlinux.org.uk>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
Message-ID: <de61ab3a-a6e9-0209-f06a-dc04d3b14f5d@suse.com>
Subject: Re: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops
 layer
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151302350.915916@ubuntu-linux-20-04-desktop>
 <84f5264c-6b98-6d56-b7ca-61c19dc502ca@gmail.com>
 <alpine.DEB.2.22.394.2204181156280.915916@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2204181156280.915916@ubuntu-linux-20-04-desktop>

--------------oInpg5CSFyyPOeZGwl5wBsnf
Content-Type: multipart/mixed; boundary="------------C00KGA3BvOs6gJrFK0A8HNCb"

--------------C00KGA3BvOs6gJrFK0A8HNCb
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTguMDQuMjIgMjE6MTEsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gT24gU3Vu
LCAxNyBBcHIgMjAyMiwgT2xla3NhbmRyIHdyb3RlOg0KPj4gT24gMTYuMDQuMjIgMDE6MDIs
IFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+PiBPbiBUaHUsIDE0IEFwciAyMDIyLCBP
bGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3NhbmRyIFR5c2hj
aGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pg0KPj4+PiBJbiB0
aGUgY29udGV4dCBvZiBjdXJyZW50IHBhdGNoIGRvIHRoZSBmb2xsb3dpbmc6DQo+Pj4+IDEu
IFVwZGF0ZSBjb2RlIHRvIHN1cHBvcnQgdmlydGlvLW1taW8gZGV2aWNlcw0KPj4+PiAyLiBJ
bnRyb2R1Y2Ugc3RydWN0IHhlbl92aXJ0aW9fZGF0YSBhbmQgYWNjb3VudCBwYXNzZWQgdmly
dGlvIGRldmljZXMNCj4+Pj4gICAgICAodXNpbmcgbGlzdCkgYXMgd2UgbmVlZCB0byBzdG9y
ZSBzb21lIHBlci1kZXZpY2UgZGF0YQ0KPj4+PiAzLiBBZGQgbXVsdGktcGFnZSBzdXBwb3J0
IGZvciB4ZW5fdmlydGlvX2RtYV9tYXAodW5tYXApX3BhZ2UgY2FsbGJhY2tzDQo+Pj4+IDQu
IEhhcmRlbiBjb2RlIGFnYWluc3QgbWFsaWNpb3VzIGJhY2tlbmQNCj4+Pj4gNS4gQ2hhbmdl
IHRvIHVzZSBhbGxvY19wYWdlc19leGFjdCgpIGluc3RlYWQgb2YgX19nZXRfZnJlZV9wYWdl
cygpDQo+Pj4+IDYuIEludHJvZHVjZSBsb2NraW5nIHNjaGVtZSB0byBwcm90ZWN0IG1hcHBp
bmdzIChJIGFtIG5vdCAxMDAlIHN1cmUNCj4+Pj4gICAgICB3aGV0aGVyIHBlci1kZXZpY2Ug
bG9jayBpcyByZWFsbHkgbmVlZGVkKQ0KPj4+PiA3LiBIYW5kbGUgdmlydGlvIGRldmljZSdz
IERNQSBtYXNrDQo+Pj4+IDguIFJldHJpZXZlIHRoZSBJRCBvZiBiYWNrZW5kIGRvbWFpbiBm
cm9tIERUIGZvciB2aXJ0aW8tbW1pbyBkZXZpY2UNCj4+Pj4gICAgICBpbnN0ZWFkIG9mIGhh
cmRjb2RpbmcgaXQuDQo+Pj4+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNo
Y2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+
ICAgIGFyY2gvYXJtL3hlbi9lbmxpZ2h0ZW4uYyB8ICAxMSArKysNCj4+Pj4gICAgZHJpdmVy
cy94ZW4vS2NvbmZpZyAgICAgIHwgICAyICstDQo+Pj4+ICAgIGRyaXZlcnMveGVuL3hlbi12
aXJ0aW8uYyB8IDIwMA0KPj4+PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKystLS0tLQ0KPj4+PiAgICBpbmNsdWRlL3hlbi94ZW4tb3BzLmggICAgfCAgIDUg
KysNCj4+Pj4gICAgNCBmaWxlcyBjaGFuZ2VkLCAxOTYgaW5zZXJ0aW9ucygrKSwgMjIgZGVs
ZXRpb25zKC0pDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS94ZW4vZW5saWdo
dGVuLmMgYi9hcmNoL2FybS94ZW4vZW5saWdodGVuLmMNCj4+Pj4gaW5kZXggZWM1YjA4Mi4u
ODcwZDkyZiAxMDA2NDQNCj4+Pj4gLS0tIGEvYXJjaC9hcm0veGVuL2VubGlnaHRlbi5jDQo+
Pj4+ICsrKyBiL2FyY2gvYXJtL3hlbi9lbmxpZ2h0ZW4uYw0KPj4+PiBAQCAtNDA5LDYgKzQw
OSwxNyBAQCBpbnQgX19pbml0IGFyY2hfeGVuX3VucG9wdWxhdGVkX2luaXQoc3RydWN0IHJl
c291cmNlDQo+Pj4+ICoqcmVzKQ0KPj4+PiAgICB9DQo+Pj4+ICAgICNlbmRpZg0KPj4+PiAg
ICArI2lmZGVmIENPTkZJR19BUkNIX0hBU19SRVNUUklDVEVEX1ZJUlRJT19NRU1PUllfQUND
RVNTDQo+Pj4+ICtpbnQgYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vz
cyh2b2lkKQ0KPj4+PiArew0KPj4+PiArCWlmIChJU19FTkFCTEVEKENPTkZJR19YRU5fSFZN
X1ZJUlRJT19HUkFOVCkgJiYgeGVuX2h2bV9kb21haW4oKSkNCj4+Pj4gKwkJcmV0dXJuIDE7
DQo+Pj4gSW5zdGVhZCBvZiB4ZW5faHZtX2RvbWFpbigpLCB5b3UgY2FuIGp1c3QgdXNlIHhl
bl9kb21haW4oKS4gQWxzbyB0aGVyZQ0KPj4+IGlzIG5vIG5lZWQgZm9yIHRoZSAjaWZkZWYN
Cj4+PiBDT05GSUdfQVJDSF9IQVNfUkVTVFJJQ1RFRF9WSVJUSU9fTUVNT1JZX0FDQ0VTUywg
Z2l2ZW4gdGhhdDoNCj4+Pg0KPj4+IENPTkZJR19YRU5fSFZNX1ZJUlRJT19HUkFOVCBkZXBl
bmRzIG9uIFhFTl9WSVJUSU8gd2hpY2ggc2VsZWN0cw0KPj4+IEFSQ0hfSEFTX1JFU1RSSUNU
RURfVklSVElPX01FTU9SWV9BQ0NFU1MNCj4+DQo+Pg0KPj4gWWVzLCBidXQgcGxlYXNlIHNl
ZSBteSBjb21tZW50cyBpbiBjb21taXQgIzIgcmVnYXJkaW5nDQo+PiBDT05GSUdfWEVOX0hW
TV9WSVJUSU9fR1JBTlQgb3B0aW9uIGFuZA0KPj4gYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0
aW9fbWVtb3J5X2FjY2VzcygpIG9uIEFybS4NCj4+DQo+PiBJIHByb3Bvc2UgdG8gaGF2ZSB0
aGUgZm9sbG93aW5nIG9uIEFybToNCj4+DQo+PiBpbnQgYXJjaF9oYXNfcmVzdHJpY3RlZF92
aXJ0aW9fbWVtb3J5X2FjY2Vzcyh2b2lkKQ0KPj4gew0KPj4gIMKgwqDCoMKgIHJldHVybiB4
ZW5faGFzX3Jlc3RyaWN0ZWRfdmlydGlvX21lbW9yeV9hY2Nlc3MoKTsNCj4+IH0NCj4+DQo+
Pg0KPj4gd2hlcmUgY29tbW9uIHhlbi5oIGNvbnRhaW4gYSBoZWxwZXIgdG8gYmUgdXNlZCBi
eSBib3RoIEFybSBhbmQgeDg2Og0KPj4NCj4+IHN0YXRpYyBpbmxpbmUgaW50IHhlbl9oYXNf
cmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vzcyh2b2lkKQ0KPj4gew0KPj4gIMKgwqDC
oMKgIGlmIChJU19FTkFCTEVEKENPTkZJR19YRU5fVklSVElPKSAmJiAoeGVuX3B2X2RvbWFp
bigpIHx8DQo+PiB4ZW5faHZtX2RvbWFpbigpKSkNCj4+ICDCoMKgwqDCoMKgwqDCoMKgIHJl
dHVybiAxOw0KPj4NCj4+ICDCoMKgwqDCoCByZXR1cm4gMDsNCj4+IH0NCj4+DQo+Pg0KPj4g
QnV0IEkgd291bGQgYmUgaGFwcHkgd2l0aCB3aGF0IHlvdSBwcm9wb3NlIGFzIHdlbGwuDQo+
IA0KPiBBcyBJIHdyb3RlIGluIHRoZSBwcmV2aW91cyByZXBseSwgSSBhbHNvIHByZWZlciB0
byBzaGFyZSB0aGUgY29kZQ0KPiBiZXR3ZWVuIHg4NiBhbmQgQVJNLCBhbmQgSSB0aGluayBp
dCBjb3VsZCBsb29rIGxpa2U6DQo+IA0KPiBpbnQgYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0
aW9fbWVtb3J5X2FjY2Vzcyh2b2lkKQ0KPiB7DQo+ICDCoMKgwqDCoCByZXR1cm4geGVuX2hh
c19yZXN0cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNzKCk7DQo+IH0NCj4gWy4uLl0NCj4g
c3RhdGljIGlubGluZSBpbnQgeGVuX2hhc19yZXN0cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNj
ZXNzKHZvaWQpDQo+IHsNCj4gIMKgwqDCoMKgIHJldHVybiAoSVNfRU5BQkxFRChDT05GSUdf
WEVOX1ZJUlRJTykgJiYgeGVuX2RvbWFpbigpKTsNCj4gfQ0KPiANCj4gQnV0IGxldCdzIGNo
ZWNrIHdpdGggSnVlcmdlbiBhbmQgQm9yaXMuDQo+IA0KPiANCj4+Pj4gKwlyZXR1cm4gMDsN
Cj4+Pj4gK30NCj4+Pj4gK0VYUE9SVF9TWU1CT0xfR1BMKGFyY2hfaGFzX3Jlc3RyaWN0ZWRf
dmlydGlvX21lbW9yeV9hY2Nlc3MpOw0KPj4+PiArI2VuZGlmDQo+Pj4+ICsNCj4+Pj4gICAg
c3RhdGljIHZvaWQgX19pbml0IHhlbl9kdF9ndWVzdF9pbml0KHZvaWQpDQo+Pj4+ICAgIHsN
Cj4+Pj4gICAgCXN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX25vZGU7DQo+Pj4+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL3hlbi9LY29uZmlnIGIvZHJpdmVycy94ZW4vS2NvbmZpZw0KPj4+PiBp
bmRleCBmYzYxZjdhLi41NmFmZTZhIDEwMDY0NA0KPj4+PiAtLS0gYS9kcml2ZXJzL3hlbi9L
Y29uZmlnDQo+Pj4+ICsrKyBiL2RyaXZlcnMveGVuL0tjb25maWcNCj4+Pj4gQEAgLTM0Nyw3
ICszNDcsNyBAQCBjb25maWcgWEVOX1ZJUlRJTw0KPj4+PiAgICAgIGNvbmZpZyBYRU5fSFZN
X1ZJUlRJT19HUkFOVA0KPj4+PiAgICAJYm9vbCAiUmVxdWlyZSB2aXJ0aW8gZm9yIGZ1bGx5
IHZpcnR1YWxpemVkIGd1ZXN0cyB0byB1c2UgZ3JhbnQNCj4+Pj4gbWFwcGluZ3MiDQo+Pj4+
IC0JZGVwZW5kcyBvbiBYRU5fVklSVElPICYmIFg4Nl82NA0KPj4+PiArCWRlcGVuZHMgb24g
WEVOX1ZJUlRJTyAmJiAoWDg2XzY0IHx8IEFSTSB8fCBBUk02NCkNCj4+PiB5b3UgY2FuIHJl
bW92ZSB0aGUgYXJjaGl0ZWN0dXJhbCBkZXBlbmRlbmNpZXMNCj4+DQo+Pg0KPj4gQWNjb3Jk
aW5nIHRvIHRoZSBjb252ZXJzYXRpb24gaW4gY29tbWl0ICMyIHdlIGFyZSBjb25zaWRlcmlu
ZyBqdXN0IGEgc2luZ2xlDQo+PiBYRU5fVklSVElPIG9wdGlvbiwgYnV0IGl0IGlzIGdvaW5n
IHRvIGhhcyB0aGUNCj4+IHNhbWUgYXJjaGl0ZWN0dXJhbCBkZXBlbmRlbmNpZXM6IChYODZf
NjQgfHwgQVJNIHx8IEFSTTY0KQ0KPj4NCj4+IEJ5IHJlbW92aW5nIHRoZSBhcmNoaXRlY3R1
cmFsIGRlcGVuZGVuY2llcyBoZXJlLCB3ZSB3aWxsIGxlYXZlIGFsc28gWDg2XzMyDQo+PiBj
b3ZlcmVkIChuZWl0aGVyIFhFTl9IVk1fVklSVElPX0dSQU5UIG5vciBYRU5fUFZfVklSVElP
IGNvdmVyZWQgaXQpLiBJIGRvbid0DQo+PiBrbm93IHdoZXRoZXIgaXQgaXMgb2sgb3Igbm90
Lg0KPj4NCj4+IFNoYWxsIEkgcmVtb3ZlIGRlcGVuZGVuY2llcyBhbnl3YXk/DQo+IA0KPiBO
bywgZ29vZCBwb2ludC4gSSBkb24ndCBrbm93IGFib3V0IFg4Nl8zMi4gVGhpcyBpcyBhbm90
aGVyIGRldGFpbCB3aGVyZQ0KPiBKdWVyZ2VuIG9yIEJvcmlzIHNob3VsZCBjb21tZW50Lg0K
DQpYODZfMzIgc2hvdWxkIGluIHRoZW9yeSB3b3JrIChpdCBpcyBIVk0vUFZIIG9ubHksIGFz
IFBWIDMyLWJpdCBndWVzdHMgYXJlIG5vDQpsb25nZXIgc3VwcG9ydGVkKS4NCg0KDQpKdWVy
Z2VuDQo=
--------------C00KGA3BvOs6gJrFK0A8HNCb
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------C00KGA3BvOs6gJrFK0A8HNCb--

--------------oInpg5CSFyyPOeZGwl5wBsnf--

--------------zEq0HDPLD0VYb57K7jEjRPEq
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJeXYwFAwAAAAAACgkQsN6d1ii/Ey/3
4Af8Ct0w/A3LzGDKWGOwBkhlVk2NrF7FtszRGIW+XjZ8CMo1rc70gUBhygLV1+miHavVBqq6AMIs
RQN8fyeRdokoYxkaynj33Rparagz5pFQU5UscTdWRZefS8oo2yU5rTfV3Tr1C2isiYjg/1nWps83
jgv+1pNW/pscABoYu9fmXxD+05ZMrAwgmSS+T+dkT/6m8to0jltJG1EtA8GJrzEjJiq+NPb9/iBU
bRxp4+FZgy7QNpk5znoA6T28dSTdFG/wLaAtFPPzdrP92uH0G8nLUZXa4ekvbbUHLQY1IIk92+dz
vZkOEMetdfeVqlxsBhjJ3Mq9rGewesyrJG83tiQPTw==
=CL7E
-----END PGP SIGNATURE-----

--------------zEq0HDPLD0VYb57K7jEjRPEq--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 06:58:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 06:58:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307793.523104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghon-0002cn-Rz; Tue, 19 Apr 2022 06:58:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307793.523104; Tue, 19 Apr 2022 06:58:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghon-0002ce-On; Tue, 19 Apr 2022 06:58:33 +0000
Received: by outflank-mailman (input) for mailman id 307793;
 Tue, 19 Apr 2022 06:58:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uEip=U5=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nghom-0002bg-Bq
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 06:58:32 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 1f351a45-bfae-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 08:58:31 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ABAE1042;
 Mon, 18 Apr 2022 23:58:30 -0700 (PDT)
Received: from [10.57.11.171] (unknown [10.57.11.171])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DB9DF3F766;
 Mon, 18 Apr 2022 23:58:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f351a45-bfae-11ec-8fbe-03012f2f19d4
Message-ID: <622c2361-c8e2-eca8-14b3-1051845bba59@arm.com>
Date: Tue, 19 Apr 2022 08:58:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V6 1/2] xen/arm: Add i.MX lpuart driver
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>, Henry Wang <Henry.Wang@arm.com>
References: <20220419043927.23542-1-peng.fan@oss.nxp.com>
 <20220419043927.23542-2-peng.fan@oss.nxp.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <20220419043927.23542-2-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Peng,

On 19.04.2022 06:39, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The i.MX LPUART Documentation:
> https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC
> Chatper 13.6 Low Power Universal Asynchronous Receiver/
> Transmitter (LPUART)
> 
> Tested-by: Henry Wang <Henry.Wang@arm.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 07:07:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 07:07:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307809.523114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghxG-0004am-Nj; Tue, 19 Apr 2022 07:07:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307809.523114; Tue, 19 Apr 2022 07:07:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nghxG-0004af-Ke; Tue, 19 Apr 2022 07:07:18 +0000
Received: by outflank-mailman (input) for mailman id 307809;
 Tue, 19 Apr 2022 07:07:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tr1R=U5=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nghxF-0004aZ-WA
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 07:07:18 +0000
Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com
 [2a00:1450:4864:20::12d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5893d690-bfaf-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 09:07:16 +0200 (CEST)
Received: by mail-lf1-x12d.google.com with SMTP id bu29so27834294lfb.0
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 00:07:16 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 bj8-20020a2eaa88000000b0024c8f61c960sm1409303ljb.41.2022.04.19.00.07.15
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 00:07:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5893d690-bfaf-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=g3qSZKngG45zSw5fBOwAtc0YdEsjG3JU5BfHsaq0LiQ=;
        b=bkXlqnuB/kolbwrMRuelZiUz+bjx4L1bO1ZqN8R+28AZ++I5eKCYHBe1xjBXzlWiCy
         tm2xx3/ZIRQQK5r4LjrpGfHPN90P6P+9sF0lniTjU6rb8NzW3VE7v3ie9SebGbsiOL+y
         pEepcyfENM5C12Vsb+ymllAq+g0F6PwAeHKyAfP2HJkl6jLQy65jtpQmgBQEyYIiKzac
         W3sduDxvIbcHDN7T8n33cqZlbwD4LI4iOhmDIdiSwcy/FSQrwbJcv5/RrBn4YsOWlxN/
         iUcbpMc9lyj0umNQzvA3RTnJ5QxCCFxjuw5iRc9mlCLNlkTwXdkcAcgA7owwPMu5PF1p
         7n9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=g3qSZKngG45zSw5fBOwAtc0YdEsjG3JU5BfHsaq0LiQ=;
        b=xjMdrLqCEl3OxQ/D4VRpfCr5apvMSklzvXBwG6IfVLVzdOhhyAHGLOZU775rflsLVs
         f77yNUbEsMIrfEWDexdeMZAICc2dNvW4r5BTntKwjAnSCGDxJxdnzNPvrgiIEkX4RyBp
         X9C1mrvRdVJeQpFx/HVfxbw79rnXQ1AvaB2VJK2w+Wxb+dRprMg2M8QPmjeIxtWEFJGr
         GTDx/9aVvPxMUx+ck/cMqn5bLKX36Xr5hmFKi3+cwRS+hr9wScd68YVTeiyOHOgqIA74
         jn6OEBNCBAYTTAVcgBnolSXY+3NZBmKLG9VRVzvXhJGVBXEEfNuE6gy5UwQcE4quJUQC
         HVwQ==
X-Gm-Message-State: AOAM530bvKvmsQL3/RfrV8p2/nTshjG6XTenlRmBYRdg4HjzwnnBvA7Y
	j5FwN65ED9K30tg5OtupcHU=
X-Google-Smtp-Source: ABdhPJwDlGWpSl1i/brX4urC/IsF/MofoGsuVdPTpja8M3Fb4G4QIrCtIfbTCa+qgQ0eevhFxEs4AQ==
X-Received: by 2002:a05:6512:b0b:b0:44a:f4a5:b519 with SMTP id w11-20020a0565120b0b00b0044af4a5b519mr10591701lfu.287.1650352036268;
        Tue, 19 Apr 2022 00:07:16 -0700 (PDT)
Subject: Re: [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops
 layer
To: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Russell King <linux@armlinux.org.uk>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-5-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151302350.915916@ubuntu-linux-20-04-desktop>
 <84f5264c-6b98-6d56-b7ca-61c19dc502ca@gmail.com>
 <alpine.DEB.2.22.394.2204181156280.915916@ubuntu-linux-20-04-desktop>
 <de61ab3a-a6e9-0209-f06a-dc04d3b14f5d@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <5d2ba980-5efc-e2cb-1962-2056e1fffe7c@gmail.com>
Date: Tue, 19 Apr 2022 10:07:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <de61ab3a-a6e9-0209-f06a-dc04d3b14f5d@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hello Stefano, Juergen


On 19.04.22 09:58, Juergen Gross wrote:
> On 18.04.22 21:11, Stefano Stabellini wrote:
>> On Sun, 17 Apr 2022, Oleksandr wrote:
>>> On 16.04.22 01:02, Stefano Stabellini wrote:
>>>> On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>
>>>>> In the context of current patch do the following:
>>>>> 1. Update code to support virtio-mmio devices
>>>>> 2. Introduce struct xen_virtio_data and account passed virtio devices
>>>>>      (using list) as we need to store some per-device data
>>>>> 3. Add multi-page support for xen_virtio_dma_map(unmap)_page 
>>>>> callbacks
>>>>> 4. Harden code against malicious backend
>>>>> 5. Change to use alloc_pages_exact() instead of __get_free_pages()
>>>>> 6. Introduce locking scheme to protect mappings (I am not 100% sure
>>>>>      whether per-device lock is really needed)
>>>>> 7. Handle virtio device's DMA mask
>>>>> 8. Retrieve the ID of backend domain from DT for virtio-mmio device
>>>>>      instead of hardcoding it.
>>>>>
>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>> ---
>>>>>    arch/arm/xen/enlighten.c |  11 +++
>>>>>    drivers/xen/Kconfig      |   2 +-
>>>>>    drivers/xen/xen-virtio.c | 200
>>>>> ++++++++++++++++++++++++++++++++++++++++++-----
>>>>>    include/xen/xen-ops.h    |   5 ++
>>>>>    4 files changed, 196 insertions(+), 22 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
>>>>> index ec5b082..870d92f 100644
>>>>> --- a/arch/arm/xen/enlighten.c
>>>>> +++ b/arch/arm/xen/enlighten.c
>>>>> @@ -409,6 +409,17 @@ int __init arch_xen_unpopulated_init(struct 
>>>>> resource
>>>>> **res)
>>>>>    }
>>>>>    #endif
>>>>>    +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>>>>> +int arch_has_restricted_virtio_memory_access(void)
>>>>> +{
>>>>> +    if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain())
>>>>> +        return 1;
>>>> Instead of xen_hvm_domain(), you can just use xen_domain(). Also there
>>>> is no need for the #ifdef
>>>> CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, given that:
>>>>
>>>> CONFIG_XEN_HVM_VIRTIO_GRANT depends on XEN_VIRTIO which selects
>>>> ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>>>
>>>
>>> Yes, but please see my comments in commit #2 regarding
>>> CONFIG_XEN_HVM_VIRTIO_GRANT option and
>>> arch_has_restricted_virtio_memory_access() on Arm.
>>>
>>> I propose to have the following on Arm:
>>>
>>> int arch_has_restricted_virtio_memory_access(void)
>>> {
>>>       return xen_has_restricted_virtio_memory_access();
>>> }
>>>
>>>
>>> where common xen.h contain a helper to be used by both Arm and x86:
>>>
>>> static inline int xen_has_restricted_virtio_memory_access(void)
>>> {
>>>       if (IS_ENABLED(CONFIG_XEN_VIRTIO) && (xen_pv_domain() ||
>>> xen_hvm_domain()))
>>>           return 1;
>>>
>>>       return 0;
>>> }
>>>
>>>
>>> But I would be happy with what you propose as well.
>>
>> As I wrote in the previous reply, I also prefer to share the code
>> between x86 and ARM, and I think it could look like:
>>
>> int arch_has_restricted_virtio_memory_access(void)
>> {
>>       return xen_has_restricted_virtio_memory_access();
>> }
>> [...]
>> static inline int xen_has_restricted_virtio_memory_access(void)
>> {
>>       return (IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain());
>> }
>>
>> But let's check with Juergen and Boris.


for the record, it is already clarified in commit #2, I will use this 
variant.


>>
>>
>>
>>>>> +    return 0;
>>>>> +}
>>>>> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
>>>>> +#endif
>>>>> +
>>>>>    static void __init xen_dt_guest_init(void)
>>>>>    {
>>>>>        struct device_node *xen_node;
>>>>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>>>>> index fc61f7a..56afe6a 100644
>>>>> --- a/drivers/xen/Kconfig
>>>>> +++ b/drivers/xen/Kconfig
>>>>> @@ -347,7 +347,7 @@ config XEN_VIRTIO
>>>>>      config XEN_HVM_VIRTIO_GRANT
>>>>>        bool "Require virtio for fully virtualized guests to use grant
>>>>> mappings"
>>>>> -    depends on XEN_VIRTIO && X86_64
>>>>> +    depends on XEN_VIRTIO && (X86_64 || ARM || ARM64)
>>>> you can remove the architectural dependencies
>>>
>>>
>>> According to the conversation in commit #2 we are considering just a 
>>> single
>>> XEN_VIRTIO option, but it is going to has the
>>> same architectural dependencies: (X86_64 || ARM || ARM64)
>>>
>>> By removing the architectural dependencies here, we will leave also 
>>> X86_32
>>> covered (neither XEN_HVM_VIRTIO_GRANT nor XEN_PV_VIRTIO covered it). 
>>> I don't
>>> know whether it is ok or not.
>>>
>>> Shall I remove dependencies anyway?
>>
>> No, good point. I don't know about X86_32. This is another detail where
>> Juergen or Boris should comment.
>
> X86_32 should in theory work (it is HVM/PVH only, as PV 32-bit guests 
> are no
> longer supported).


ok, thank you for confirming. I will drop architectural dependencies then.


>
>
>
> Juergen

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 07:35:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 07:35:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307815.523126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngiO8-00087Z-Th; Tue, 19 Apr 2022 07:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307815.523126; Tue, 19 Apr 2022 07:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngiO8-00087S-P1; Tue, 19 Apr 2022 07:35:04 +0000
Received: by outflank-mailman (input) for mailman id 307815;
 Tue, 19 Apr 2022 07:35:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngiO7-00087I-Q3; Tue, 19 Apr 2022 07:35:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngiO7-00005q-Ma; Tue, 19 Apr 2022 07:35:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngiO7-0001LK-A3; Tue, 19 Apr 2022 07:35:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngiO7-00028i-9Y; Tue, 19 Apr 2022 07:35:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NfcBygAgTOUlePTs0h+DgcvIM9uI5W3ASGs0IFuaQEQ=; b=ydkhQZPrD//U4jZUm/T47iCjDZ
	cbeso2/OO1AFwkF+VYRhmNKcR5eXcBMzHVLcZsoZ4P5PcscORw2RecMzghVoqqg8lvG0IWRvo2hQO
	2Q5b+pmNbKwZ3ncrbXA3nuORM7MUyOyxGu+9sgLP02srFu1YQvMsj0LCzskmoU3mmjiA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169531-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169531: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 07:35:03 +0000

flight 169531 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169531/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6be7beb3bdb9ad611a5598dad7edfbd2a836fd2e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  648 days
Failing since        151818  2020-07-11 04:18:52 Z  647 days  629 attempts
Testing same since   169415  2022-04-15 04:18:55 Z    4 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104670 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:01:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:01:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307830.523137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nginM-0003kL-Fh; Tue, 19 Apr 2022 08:01:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307830.523137; Tue, 19 Apr 2022 08:01:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nginM-0003kE-Ca; Tue, 19 Apr 2022 08:01:08 +0000
Received: by outflank-mailman (input) for mailman id 307830;
 Tue, 19 Apr 2022 08:01:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nginK-0003k8-KQ
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 08:01:06 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dbdd933d-bfb6-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 10:01:03 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3593E210F5;
 Tue, 19 Apr 2022 08:01:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C5140139BE;
 Tue, 19 Apr 2022 08:01:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id We/RLj5sXmIEWwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 08:01:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dbdd933d-bfb6-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650355263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=IAHVyZh9M1yn3uyFX0Q4UeRtgTRg365FY7m2GYk9oCY=;
	b=DjLOzxF3cyir/0kWRt1Fs3ew3uIdKJqJlhPqYGtEY/OvuGL5r+7fdXtEVPF+r2ZpHUnbc/
	ABZULYMo5mXmF0Fi3U45puIglH5j9j0ej2jbiHp3rOtnkaKg5UthJMqMfiK00UOirlsKr+
	+5JtXkZ58snpPIyMa64kmHP/M5hBzd4=
Message-ID: <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com>
Date: Tue, 19 Apr 2022 10:01:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v6 0/9] xen: drop hypercall function tables
Content-Language: en-US
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>,
 Dario Faggioli <dfaggioli@suse.com>, Daniel De Graaf
 <dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20220324140139.5899-1-jgross@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220324140139.5899-1-jgross@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------jab0lu4vYhIgPHd2XwkkHXO5"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------jab0lu4vYhIgPHd2XwkkHXO5
Content-Type: multipart/mixed; boundary="------------2yl3GC04CGvGtrIaahRaFddn";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>,
 Dario Faggioli <dfaggioli@suse.com>, Daniel De Graaf
 <dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com>
Subject: Re: [PATCH v6 0/9] xen: drop hypercall function tables
References: <20220324140139.5899-1-jgross@suse.com>
In-Reply-To: <20220324140139.5899-1-jgross@suse.com>

--------------2yl3GC04CGvGtrIaahRaFddn
Content-Type: multipart/mixed; boundary="------------H4LdJhjyGQtwbpBwYW0oMf51"

--------------H4LdJhjyGQtwbpBwYW0oMf51
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMDMuMjIgMTU6MDEsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IEluIG9yZGVyIHRv
IGF2b2lkIGluZGlyZWN0IGZ1bmN0aW9uIGNhbGxzIG9uIHRoZSBoeXBlcmNhbGwgcGF0aCBh
cw0KPiBtdWNoIGFzIHBvc3NpYmxlIHRoaXMgc2VyaWVzIGlzIHJlbW92aW5nIHRoZSBoeXBl
cmNhbGwgZnVuY3Rpb24gdGFibGVzDQo+IGFuZCBpcyByZXBsYWNpbmcgdGhlIGh5cGVyY2Fs
bCBoYW5kbGVyIGNhbGxzIHZpYSB0aGUgZnVuY3Rpb24gYXJyYXkNCj4gYnkgYXV0b21hdGlj
YWxseSBnZW5lcmF0ZWQgY2FsbCBtYWNyb3MuDQo+IA0KPiBBbm90aGVyIGJ5LXByb2R1Y3Qg
b2YgZ2VuZXJhdGluZyB0aGUgY2FsbCBtYWNyb3MgaXMgdGhlIGF1dG9tYXRpYw0KPiBnZW5l
cmF0aW5nIG9mIHRoZSBoeXBlcmNhbGwgaGFuZGxlciBwcm90b3R5cGVzIGZyb20gdGhlIHNh
bWUgZGF0YSBiYXNlDQo+IHdoaWNoIGlzIHVzZWQgdG8gZ2VuZXJhdGUgdGhlIG1hY3Jvcy4N
Cj4gDQo+IFRoaXMgaGFzIHRoZSBhZGRpdGlvbmFsIGFkdmFudGFnZSBvZiB1c2luZyB0eXBl
IHNhZmUgY2FsbHMgb2YgdGhlDQo+IGhhbmRsZXJzIGFuZCB0byBlbnN1cmUgcmVsYXRlZCBo
YW5kbGVyIChlLmcuIFBWIGFuZCBIVk0gb25lcykgc2hhcmUNCj4gdGhlIHNhbWUgcHJvdG90
eXBlcy4NCj4gDQo+IEEgdmVyeSBicmllZiBwZXJmb3JtYW5jZSB0ZXN0IChwYXJhbGxlbCBi
dWlsZCBvZiB0aGUgWGVuIGh5cGVydmlzb3INCj4gaW4gYSA2IHZjcHUgZ3Vlc3QpIHNob3dl
ZCBhIHZlcnkgc2xpbSBpbXByb3ZlbWVudCAobGVzcyB0aGFuIDElKSBvZg0KPiB0aGUgcGVy
Zm9ybWFuY2Ugd2l0aCB0aGUgcGF0Y2hlcyBhcHBsaWVkLiBUaGUgdGVzdCB3YXMgcGVyZm9y
bWVkIHVzaW5nDQo+IGEgUFYgYW5kIGEgUFZIIGd1ZXN0Lg0KDQpBIGdlbnRsZSBwaW5nIHJl
Z2FyZGluZyB0aGlzIHNlcmllcy4NCg0KSSB0aGluayBwYXRjaCAxIHN0aWxsIGxhY2tzIGFu
IEFjayBmcm9tIHg4NiBzaWRlLiBPdGhlciB0aGFuIHRoYXQNCnBhdGNoZXMgMSwgMiBhbmQg
NCBzaG91bGQgYmUgZmluZSB0byBnbyBpbiwgYXMgdGhleSBhcmUgY2xlYW51cHMgd2hpY2gN
CmFyZSBmaW5lIG9uIHRoZWlyIG93biBJTUhPLg0KDQpBbmRyZXcsIHlvdSB3YW50ZWQgdG8g
Z2V0IHNvbWUgcGVyZm9ybWFuY2UgbnVtYmVycyBvZiB0aGUgc2VyaWVzIHVzaW5nDQp0aGUg
Q2l0cml4IHRlc3QgZW52aXJvbm1lbnQuIEFueSBuZXdzIG9uIHRoZSBwcm9ncmVzcyBoZXJl
Pw0KDQoNCkp1ZXJnZW4NCg==
--------------H4LdJhjyGQtwbpBwYW0oMf51
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------H4LdJhjyGQtwbpBwYW0oMf51--

--------------2yl3GC04CGvGtrIaahRaFddn--

--------------jab0lu4vYhIgPHd2XwkkHXO5
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJebD4FAwAAAAAACgkQsN6d1ii/Ey93
YAf/RX7t7SpBZZVbbiHDfLzqP3XoEBC+iB8MICxbv/DIkMkQy91gjwanHwdD5BZNAMBtH7cnGH7l
xDsrC77RbZ+cQkhaqeja6VGV3Ded/qgPP9bPNahNjxK7AZ8HPe8R1ewYJpXMnFROOvV+4gxYNaEP
Jbqmy6iZ9bAkeXZDjDXgJxvOSlWmh98kHIM7ySlY5/Fuwy3/k0P55ety4qNRXH/uaNYJhmx/9Ffc
bOb0Z/fBaWTIkbzHr2kQO0MDLM5Q/CDnFT5Adbxtior3KaD63RnYZhj6YOnJtvV4whewQWZJMDmH
WDMWhIbbnawbdRcFETjOea+XooWijcGGl7FF2uiUcg==
=Irrv
-----END PGP SIGNATURE-----

--------------jab0lu4vYhIgPHd2XwkkHXO5--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:07:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:07:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307835.523148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngitj-0004Vm-6d; Tue, 19 Apr 2022 08:07:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307835.523148; Tue, 19 Apr 2022 08:07:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngitj-0004Vf-37; Tue, 19 Apr 2022 08:07:43 +0000
Received: by outflank-mailman (input) for mailman id 307835;
 Tue, 19 Apr 2022 08:07:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngiti-0004VV-FS; Tue, 19 Apr 2022 08:07:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngiti-0001E9-5h; Tue, 19 Apr 2022 08:07:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngith-0002Rl-M5; Tue, 19 Apr 2022 08:07:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngith-0005PT-Lc; Tue, 19 Apr 2022 08:07:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=g1kYtOqqoYTO6oAjEw4csyuSE1I4RLJ/0vUwVm91+ww=; b=JkD/IrKVkHfwReNF0rW6yvF6yH
	IBFiBKM+ucOiV3b9FQtPoFmmW1PzWFGqIyr8ujaEEQ7vxLxCjxCT1mzFd3EeFODZFsRo6QsP5V7l6
	hOIuE+vuLyw9TphZaeGNESTwurDaP8T2uiSYj5riNMnHsqrQV29CuPp12bERCannagBs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169532-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169532: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 08:07:41 +0000

flight 169532 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169532/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  499 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:10:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:10:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307843.523159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngiw7-0005rK-Kz; Tue, 19 Apr 2022 08:10:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307843.523159; Tue, 19 Apr 2022 08:10:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngiw7-0005rD-HO; Tue, 19 Apr 2022 08:10:11 +0000
Received: by outflank-mailman (input) for mailman id 307843;
 Tue, 19 Apr 2022 08:10:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngiw6-0005r7-E4
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 08:10:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 211104f4-bfb8-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 10:10:09 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-Zd7JhvgcO3SCehH2y2uUBg-1; Tue, 19 Apr 2022 10:10:07 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB8352.eurprd04.prod.outlook.com (2603:10a6:102:1cd::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 08:10:06 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 08:10:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 211104f4-bfb8-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650355809;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zF/OE+Y3rr6iM/XxMP4ir7Vp9xquV5aHacM2tYu/eqM=;
	b=MkIp6XwWdiHyYm+BSVqem55X0pzTA1dwFcND6A+7pXHgTfT2sjqya6Q1utHD0XmLlhXae3
	Z15NfLDaIYAB3EAzQgAMROBlYNCL5mRvPij20cQzAJdeUHqB5VXB9ju37Lff3wJaOHkreL
	sCkq7gXPP5HsE7+UDPdYVxNPcl3pcV8=
X-MC-Unique: Zd7JhvgcO3SCehH2y2uUBg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XfR9ymNg9FNK3nwo8AqJsIWHPZ17m+4Uppb3PrLNAr4BnemEhfT4c15nYfst83Y3bsMaLejuPE4n7psIIyPbV7YwjZ5+9rGtQPFW4TUBDUS9bJJhH5sFtLOkoag7q+6DZCEwFWsFMcjUVQnFfZJtDP/uH/oXEKQ8WHffjWbvOOorCIcw/qjcWA0oKIVM+J71vcBTUX89gCQEeeqkIhno+uE6y7Q8VrLD69ngI7ICXAkE276gGKoaFr8vyzJCKxPB+ceFWLJNF1dBwtegz02TfkrpjK3UvtYxU+z12txxfgQVv5M+mXU6uUZfS3X9T5/iCxaHuQjUC6PBX7vh14ZFRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zF/OE+Y3rr6iM/XxMP4ir7Vp9xquV5aHacM2tYu/eqM=;
 b=JWn3EghmrPk0FtURO7e1Cq8tpRwnruxCnIOLQyxVzSSH/Wum5sDf8gPjM2Dc1tRsWF1tEwxmhfPs73TfivW5bKiQmOHEFGXYsixNof3hrP+01ZJ4Epb7xYhbgookwKXu3FxLZmir8+Dti9JfZCQhN1bONq1gV8af89SOE+l1Qv5+OxMvwNwG9VYr8Si+Lmdktd+p93HlxooxEMigFn39QbzNjMi/uE3LyPC3eUd+iVL7PPtuYo1nPhhbnQVgytXZcQ8NIvy17xZl+lqb03UUWk28NrxqCLenIVGtuDA3KMZZyNETig5i2AMo0M3JiqGz+8ZI0XaA0D9RHtY2ukUNZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1d0d3161-525c-cb47-34b5-b5202692cbcb@suse.com>
Date: Tue, 19 Apr 2022 10:10:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1 02/13] xen/arm: introduce a special domain DOMID_SHARED
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: nd <nd@arm.com>, Penny Zheng <penzhe01@a011292.shanghai.arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Chen <Wei.Chen@arm.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-3-Penny.Zheng@arm.com>
 <eefa9cf2-a04c-ba8d-74cb-0d2aaa35badb@suse.com>
 <DU2PR08MB7325265A2356A09AC1DA5FDDF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DU2PR08MB7325265A2356A09AC1DA5FDDF7EE9@DU2PR08MB7325.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0759.eurprd06.prod.outlook.com
 (2603:10a6:20b:484::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1121f48a-58ee-484d-5864-08da21dc032c
X-MS-TrafficTypeDiagnostic: PAXPR04MB8352:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB835279C12D478353BF084D00B3F29@PAXPR04MB8352.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	24e+Uo6MDmemIyV8KRGUX1Cw8wQwpiDYSHah4ZP53H9NLmy5gU9P6wkPYa67Ht3AqKOXcxHjcEBXb5uE10a/VWVnfpyDcIaro1tbmuZRKTF4wHjR7y4+vr7XOrAB690xxwKHV6LSQwpQRnuyClnRcl07X3l62tdIe7e0K9ANk0ggAk2lCffauA6JnoNOhWIONtOeABsE+Ea0hjUzh1vWes+pFHsSEI16ixwNAHpZD1FZIh/C7PHI03Za7p3MPXt2cIbYdueX9rRQwkk06B7s3Nol8E9FNB5VjLbXEjMoCHAd7bf2Rnf3AZLvBw473fhAee8l/2NMpymf3/ZedqaFZaYGR0v9/ZDOzDYIDDMGgHEdfVjjApCVlzsrF7jKrmMEKy/RayOVKL/kf8w9E+9/dESgnQvhQ0Oepf9LmXy/u5AR4OAXqDUpTfPnJynkKQByRxRXJTvLwdvv4XDkDWAHVHLM7TK8gg2l/nylSAej4Y+RjGOR8mDEIe9azpJ+dfskYremnOPW4u5Dc/nYbhg2G9Rd1ySFqXnatv4N+dpt8KKgir0uOrJXJLlYJ5sfeDun3dWn2PtoApJ9ewwksWPpP+35vYulOZLEqUstGhLf5jQOeGmPkroQKq1Ct9zpWAAgwmt6lYq7BBs4vTrvR1mY1MY2VD7a2f6po9tiAOO5teM+cVzmyM+A51yFPyWt5Gox+rt0epcNlDEYe9ADIYEQSKHJMW4lTt5VIQbN247R8ozAl+ALDA2ioodVNIGQszsf
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(508600001)(2616005)(5660300002)(8676002)(66476007)(66556008)(7416002)(6916009)(54906003)(2906002)(53546011)(6512007)(31686004)(8936002)(6506007)(36756003)(31696002)(66946007)(86362001)(6486002)(38100700002)(316002)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U1U2ZTBBS3NQMHVrTFhLWTZYdnFFVUc2Y3FRZFpEU3FtOTc0bFViUm5BeG1n?=
 =?utf-8?B?QndvZ3ZRTnBsNmU5eDZsa0xsVVU5Rk9MYi9RNEx6TzZJd0FmVW9adEtaM2sw?=
 =?utf-8?B?THhjUU0wcjBhbUlZY3BUOWdjclJUT0ZQZ05UUFRDWmhIQW5NaHNaZWVvZmsx?=
 =?utf-8?B?UENNRXc3U1hxcmRIU0JiQ2RqSy9pRklJK3FmMGFHWWdNbGdsK1RidnorL2Vw?=
 =?utf-8?B?TEk2SlVHUzJjRy9ETG8ya1cvUFVSQWZJdnhNRkpGN0E2Uk5pVm85SUdCWlRU?=
 =?utf-8?B?VDJqNWdTVjNSZTBJV3hHZWlwVDhuQm9QN1VrMnRGczdBWUpDQWpnSGs5R2RV?=
 =?utf-8?B?RUxnZFZIaDdlaXViVmRXamlXUFl6UFVON2I3MnY5bDBqQ1NqT1FQQ0h1d2No?=
 =?utf-8?B?ODByblRvRitwcmdkSlRQc0VDVFB2dGhiMXVyaG1iTG5PNUxBa2J1aHAvNnVG?=
 =?utf-8?B?L2EzcW11OURFV2VKWmVvQ2h5WVB2ckt2aWM3SEJZb3pPQlJ1NHZmSnltWDhq?=
 =?utf-8?B?c0dIZExEWHNMUEJaV0k4UEpaaDhCNU9peGpscFBmL0pRUFUzcUtWejYzM3hB?=
 =?utf-8?B?V0VjdUkxbGVjeVNBWG43MURaVkk2Z0lkdnVUN3o1VGFjRFJEUUM1djBrZEZD?=
 =?utf-8?B?R3ZZYXl2azBhMkhtTHVQYjU5RXBZZENmSjJyNkJLQ0NRUmlhWk1hOTVvYkFY?=
 =?utf-8?B?eUtXMk9hMTQ5OE9zaDV0aVkyWi81TVd3bm1FeVBTZ0k3NlhmTUpPOSs5dlQ1?=
 =?utf-8?B?ZkRBUHplSjdnSGlPb3pEYyt0Szc4aEREWUZ6THNkT3E1cnQ4UkRyczhjdGc5?=
 =?utf-8?B?NWIzUEg2ZThWa09qZ3ViY25QNHFrbTIxVVo2b2tDTGVwOVZ3Zm5BTzkrdUFr?=
 =?utf-8?B?VVF2R0cwbld2RVYxTVNsWXhYa21wNzVZUHNLZ2VyVzBSZXUweVlaY01ENjB6?=
 =?utf-8?B?VnQ2TUJWdk5hMmMrdDhVa1B6VTdKSXh6MzAvNGEwc3NKT0ZDekY3MnJQNUZo?=
 =?utf-8?B?anNCNE56anBvWTlGd0owODlmRGYrQ1M5S09oWmZ2eDhXM0c5Q04wMzJrdkZ4?=
 =?utf-8?B?Qjgwa0FVaVNZYk1pV0tJVElRMVNOQUNKUlRMeWpWbkIweFpHY2cvblNqdkZW?=
 =?utf-8?B?SHRCYU5uT0dOdHZoTFRnOUpnZ243WFBBc2pkSXgzNWhnditLbVFFaVN4Mzdv?=
 =?utf-8?B?Q09vMFp4cnQ2VWhBVTUvQmZ4TUt2WFRoZWN2ald4d2Uybzk0bFJZVS9DZTl5?=
 =?utf-8?B?YjJ6Y3BkNnZ6OHdVb1hKbkNVTkh2ZWxQNlZ1cGFSa2gxTlZYa1kwYjBqSzN2?=
 =?utf-8?B?TlVid3gwdlFGQWlSNDRoZnZuRUhzS3hNUVA1ckFVbmp2b2duK2VoUkNiMVRN?=
 =?utf-8?B?eHZCRDg3ZkFEVUhnSzlXUUpqNXA5VXAzdlRsV2FCSXJ3RkZjRE9Wb1Nka3NW?=
 =?utf-8?B?MmhOQmFoeGFuMFRmQkNJVStMV2hMbDBka3pYaUtGSnBZRjRaM0hZeXJaMnZU?=
 =?utf-8?B?aktqVFI3S3RxV2RaREc0OHpBalZ6L082ckpLSFlVazdkUU93TmFkcnlJRHVu?=
 =?utf-8?B?ZjVlNFBISEpBWDlPMnVzOEFQajVNaTRZSUpBbi9wNklvZURDQ1o4Z3NLWk9m?=
 =?utf-8?B?N01PZGh1Y0pBdFJ6V2Q0SGZUeElSYmVtRTVWY0dyTG5aRmpLME45Q3Iwakp2?=
 =?utf-8?B?NEZQcTVuRWI1STlwQkRLYUFtZG96Nk12N3JoeGF6UjQxdUliWUwwRXNIWVF5?=
 =?utf-8?B?aTg0YlU3aVQ3UEYwTW1ZREFXbjJ1eWRQZ2ZpTDdreXNsc1gvMExYNEhybmtE?=
 =?utf-8?B?NGgvZUp6UmpmTG85aWRvWXNQM25xNkVncS9Qb3ZGVnpHSE02ZEFtK1FvM1Fr?=
 =?utf-8?B?VHFVTFpPUzRNYXhhYlJkcWtNcjZZQ1NGeGtGQ0o1UDFncGwzSk8yZTJwSU5q?=
 =?utf-8?B?Y2RtVkNaTXNOaEtBeWVuK1NBbWlKRWJMVjljVlVKbmJwOHZQcWNLMHcyM0pJ?=
 =?utf-8?B?UXBPSlVaQ1BXRVI1RmRsOXhoM05JL09UN2pRaktqZGhnVWZVVXp2MXMrTEVu?=
 =?utf-8?B?SEtoZk9rd1ZaQ01DQUxGbU9ndXlncTc3aC8wa2J3c0I0NHJEVVpXMFJhTmVk?=
 =?utf-8?B?d3BWbUxlSHowZzA2cDVtZXd0OHRqb3NlZFd3aTVjUytnTy90QTc5VEJMdWhK?=
 =?utf-8?B?VWpWVTBXaWN0bEFqWlBKQjRVUG04SzhJdmVhVk5NejhsdmNoTzIvZGVDc0hE?=
 =?utf-8?B?UzdwcHhNYjRGMHVSSHlnVy9reStCWVNyd3RtMHFVZC9wc21LMk9wS3Bwc1ky?=
 =?utf-8?B?RDVLNThWcDhhM3BrUlN0UnVVbXZPdFkrVUpDNlhBR2daeWZGWXZOdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1121f48a-58ee-484d-5864-08da21dc032c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 08:10:05.8761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mdj8FDA0qUjkl0d5SmlgDbd50CjmF9P6QPuDi7eVepoa46T6h2uVlekKjh0sx8k88xPJDvQdHtSPnlf2XyWw+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8352

On 15.04.2022 11:52, Penny Zheng wrote:
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Friday, March 18, 2022 4:53 PM
>>
>> On 11.03.2022 07:11, Penny Zheng wrote:
>>> --- a/xen/arch/arm/setup.c
>>> +++ b/xen/arch/arm/setup.c
>>> @@ -855,6 +855,20 @@ static bool __init is_dom0less_mode(void)
>>>      return ( !dom0found && domUfound );  }
>>>
>>> +#ifdef CONFIG_STATIC_SHM
>>> +static void __init setup_shared_domain(void) {
>>> +    /*
>>> +     * Initialise our DOMID_SHARED domain.
>>> +     * This domain owns statically shared pages when owner domain is not
>>> +     * explicitly defined.
>>> +     */
>>> +    dom_shared = domain_create(DOMID_SHARED, NULL, CDF_directmap);
>>> +    if ( IS_ERR(dom_shared) )
>>> +        panic("Failed to create d[SHARED]: %ld\n",
>>> +PTR_ERR(dom_shared));
>>
>> I don't think this should be a panic - the system ought to be able to come up
>> fine, just without actually using this domain. After all this is an optional
>> feature which may not actually be used.
>>
>> Also, along the lines of what Stefano has said, this setting up of the domain
>> would also better live next to where the other special domains are set up. And
>> even if it was to remain here, ...
>>
> 
> The reason why I place the setting up here is that DOMID_SHARED needs to map
> pre-configured static shared memory in its p2m table, so it must be set up
> after system P2M initialization(setup_virt_paging()). setup_system_domains()
> is called before system P2M initialization on xen/arch/arm/setup.c, which
> can't meet the requirement.

While possibly moot with the plan to use DomIO (and my hope that you don't
mean to move DomIO's creation), I'd like to point out that there can't be
"too early" setting up of something. If it happens earlier than where you
need it, all you need to do is arrange for the further setup you mean to
add to be invoked separately, whenever it's time to do so.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:30:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:30:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307848.523170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjFy-0008Tj-GJ; Tue, 19 Apr 2022 08:30:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307848.523170; Tue, 19 Apr 2022 08:30:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjFy-0008Tc-Bz; Tue, 19 Apr 2022 08:30:42 +0000
Received: by outflank-mailman (input) for mailman id 307848;
 Tue, 19 Apr 2022 08:30:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngjFw-0008TS-Oe; Tue, 19 Apr 2022 08:30:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngjFw-0001dh-H4; Tue, 19 Apr 2022 08:30:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngjFw-0003Cd-13; Tue, 19 Apr 2022 08:30:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngjFw-0008UH-0c; Tue, 19 Apr 2022 08:30:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gQ8NNdrLVj651PvGbmHw3lTGFfy4BIjWBMAjSR1xhGk=; b=d/ZxV54TYDwqHMXHLouLkCSGIy
	i2UFiNcBdVtIWiKCZPmcsQ+cIocTAP3vCSesmgB9eEbb3tvl/Xf2BTs+OTBLS0CVZ95XuBxl02BS4
	jR3fI+tSqc+++KWE7odIYQ+VGuNhYWG8fgJKOBw4PjURG6JKp3P30LJDos3OqhYvR7dQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169533-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169533: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 08:30:40 +0000

flight 169533 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169533/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  500 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:34:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:34:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307855.523181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjJK-0000nd-1v; Tue, 19 Apr 2022 08:34:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307855.523181; Tue, 19 Apr 2022 08:34:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjJJ-0000nW-TD; Tue, 19 Apr 2022 08:34:09 +0000
Received: by outflank-mailman (input) for mailman id 307855;
 Tue, 19 Apr 2022 08:34:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngjJH-0000nK-Ur
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 08:34:07 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 79edd89d-bfbb-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 10:34:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 856191F74D
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 08:34:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 73A91139BE
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 08:34:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id NnbWGv5zXmKebwAAMHmgww
 (envelope-from <jgross@suse.com>)
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 08:34:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79edd89d-bfbb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650357246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=M+dyq8NDhaklA8OTK/uOevXhK7ZJOgkPcPUjfRKO/Lg=;
	b=MIutdNCmRAp/FUjJl9H6ECM7VZ4dR3DAe96DCtmUyIhPaIcmvCwnB2bNgX7dXdY0dCFdLP
	eQUhGaDVo5CfqexwSOGXDnur2ibUcEnZG0WYrdH1X3SIAT1OTve2rMnLKBI2YT6k/TJAd+
	jua0tT7fivzOmXupKfU1VKS8jPXuq2U=
Message-ID: <73498b4a-2175-32e1-13d3-2aa0a4ed197c@suse.com>
Date: Tue, 19 Apr 2022 10:34:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] include/public: add command result definitions to
 vscsiif.h
Content-Language: en-US
To: xen-devel@lists.xenproject.org
References: <20220323085831.27057-1-jgross@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220323085831.27057-1-jgross@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------YhzFxh5RbdDhS10y5lOacHpG"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------YhzFxh5RbdDhS10y5lOacHpG
Content-Type: multipart/mixed; boundary="------------IyT0wBcxtthg0ZdZKqooNc5Z";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Message-ID: <73498b4a-2175-32e1-13d3-2aa0a4ed197c@suse.com>
Subject: Re: [PATCH v2] include/public: add command result definitions to
 vscsiif.h
References: <20220323085831.27057-1-jgross@suse.com>
In-Reply-To: <20220323085831.27057-1-jgross@suse.com>

--------------IyT0wBcxtthg0ZdZKqooNc5Z
Content-Type: multipart/mixed; boundary="------------Z2W1WF7pgtCgDouic2FpT2le"

--------------Z2W1WF7pgtCgDouic2FpT2le
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

UGluZz8NCg0KT24gMjMuMDMuMjIgMDk6NTgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IFRo
ZSByZXN1bHQgZmllbGQgb2Ygc3RydWN0IHZzY3NpaWZfcmVzcG9uc2UgaXMgbGFja2luZyBh
IGRldGFpbGVkDQo+IGRlZmluaXRpb24uIFRvZGF5IHRoZSBMaW51eCBrZXJuZWwgaW50ZXJu
YWwgc2NzaSBkZWZpbml0aW9ucyBhcmUgYmVpbmcNCj4gdXNlZCwgd2hpY2ggaXMgbm90IGEg
c2FuZSBpbnRlcmZhY2UgZm9yIGEgUFYgZGV2aWNlIGRyaXZlci4NCj4gDQo+IEFkZCBtYWNy
b3MgdG8gY2hhbmdlIHRoYXQgYnkgdXNpbmcgdG9kYXkncyB2YWx1ZXMgaW4gdGhlIFhFTiBu
YW1lc3BhY2UuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA
c3VzZS5jb20+DQo+IC0tLQ0KPiBWMjoNCj4gLSBwdXQgbWFjcm8gcGFyYW1ldGVycyBpbiBw
YXJlbnRoZXNlcyAoSmFuIEJldWxpY2gpDQo+IC0gY29ycmVjdCBYRU5fVlNDU0lJRl9SU0xU
X0hPU1QoKSAoSmFuIEJldWxpY2gpDQo+IC0gbW9yZSB2ZXJib3NlIHJlc3VsdCBkZWZpbmVz
IChKYW4gQmV1bGljaCkNCj4gLSBhZGQgcmVzZXQgcmVzdWx0IGRlZmluZXMgKEphbiBCZXVs
aWNoKQ0KPiAtLS0NCj4gICB4ZW4vaW5jbHVkZS9wdWJsaWMvaW8vdnNjc2lpZi5oIHwgNTEg
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ICAgMSBmaWxlIGNoYW5nZWQs
IDUxIGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJs
aWMvaW8vdnNjc2lpZi5oIGIveGVuL2luY2x1ZGUvcHVibGljL2lvL3ZzY3NpaWYuaA0KPiBp
bmRleCBjOWNlYjE4ODRkLi44NTUzYjE3Y2M2IDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5jbHVk
ZS9wdWJsaWMvaW8vdnNjc2lpZi5oDQo+ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9pby92
c2NzaWlmLmgNCj4gQEAgLTMxNSw2ICszMTUsNTcgQEAgc3RydWN0IHZzY3NpaWZfcmVzcG9u
c2Ugew0KPiAgIH07DQo+ICAgdHlwZWRlZiBzdHJ1Y3QgdnNjc2lpZl9yZXNwb25zZSB2c2Nz
aWlmX3Jlc3BvbnNlX3Q7DQo+ICAgDQo+ICsvKiBTQ1NJIEkvTyBzdGF0dXMgZnJvbSB2c2Nz
aWlmX3Jlc3BvbnNlLT5yc2x0ICovDQo+ICsjZGVmaW5lIFhFTl9WU0NTSUlGX1JTTFRfU1RB
VFVTKHgpICAoKHgpICYgMHgwMGZmKQ0KPiArDQo+ICsvKiBIb3N0IEkvTyBzdGF0dXMgZnJv
bSB2c2NzaWlmX3Jlc3BvbnNlLT5yc2x0ICovDQo+ICsjZGVmaW5lIFhFTl9WU0NTSUlGX1JT
TFRfSE9TVCh4KSAgICAoKCh4KSAmIDB4MDBmZjAwMDApID4+IDE2KQ0KPiArI2RlZmluZSBY
RU5fVlNDU0lJRl9SU0xUX0hPU1RfT0sgICAgICAgICAgICAgICAgICAgMA0KPiArLyogQ291
bGRuJ3QgY29ubmVjdCBiZWZvcmUgdGltZW91dCAqLw0KPiArI2RlZmluZSBYRU5fVlNDU0lJ
Rl9SU0xUX0hPU1RfTk9fQ09OTkVDVCAgICAgICAgICAgMQ0KPiArLyogQnVzIGJ1c3kgdGhy
b3VnaCB0aW1lb3V0ICovDQo+ICsjZGVmaW5lIFhFTl9WU0NTSUlGX1JTTFRfSE9TVF9CVVNf
QlVTWSAgICAgICAgICAgICAyDQo+ICsvKiBUaW1lZCBvdXQgZm9yIG90aGVyIHJlYXNvbiAq
Lw0KPiArI2RlZmluZSBYRU5fVlNDU0lJRl9SU0xUX0hPU1RfVElNRV9PVVQgICAgICAgICAg
ICAgMw0KPiArLyogQmFkIHRhcmdldCAqLw0KPiArI2RlZmluZSBYRU5fVlNDU0lJRl9SU0xU
X0hPU1RfQkFEX1RBUkdFVCAgICAgICAgICAgNA0KPiArLyogQWJvcnQgZm9yIHNvbWUgb3Ro
ZXIgcmVhc29uICovDQo+ICsjZGVmaW5lIFhFTl9WU0NTSUlGX1JTTFRfSE9TVF9BQk9SVCAg
ICAgICAgICAgICAgICA1DQo+ICsvKiBQYXJpdHkgZXJyb3IgKi8NCj4gKyNkZWZpbmUgWEVO
X1ZTQ1NJSUZfUlNMVF9IT1NUX1BBUklUWSAgICAgICAgICAgICAgIDYNCj4gKy8qIEludGVy
bmFsIGVycm9yICovDQo+ICsjZGVmaW5lIFhFTl9WU0NTSUlGX1JTTFRfSE9TVF9FUlJPUiAg
ICAgICAgICAgICAgICA3DQo+ICsvKiBSZXNldCBieSBzb21lYm9keSAqLw0KPiArI2RlZmlu
ZSBYRU5fVlNDU0lJRl9SU0xUX0hPU1RfUkVTRVQgICAgICAgICAgICAgICAgOA0KPiArLyog
VW5leHBlY3RlZCBpbnRlcnJ1cHQgKi8NCj4gKyNkZWZpbmUgWEVOX1ZTQ1NJSUZfUlNMVF9I
T1NUX0JBRF9JTlRSICAgICAgICAgICAgIDkNCj4gKy8qIEZvcmNlIGNvbW1hbmQgcGFzdCBt
aWQtbGF5ZXIgKi8NCj4gKyNkZWZpbmUgWEVOX1ZTQ1NJSUZfUlNMVF9IT1NUX1BBU1NUSFJP
VUdIICAgICAgICAgMTANCj4gKy8qIFJldHJ5IHJlcXVlc3RlZCAqLw0KPiArI2RlZmluZSBY
RU5fVlNDU0lJRl9SU0xUX0hPU1RfU09GVF9FUlJPUiAgICAgICAgICAxMQ0KPiArLyogSGlk
ZGVuIHJldHJ5IHJlcXVlc3RlZCAqLw0KPiArI2RlZmluZSBYRU5fVlNDU0lJRl9SU0xUX0hP
U1RfSU1NX1JFVFJZICAgICAgICAgICAxMg0KPiArLyogUmVxdWV1ZSBjb21tYW5kIHJlcXVl
c3RlZCAqLw0KPiArI2RlZmluZSBYRU5fVlNDU0lJRl9SU0xUX0hPU1RfUkVRVUVVRSAgICAg
ICAgICAgICAxMw0KPiArLyogVHJhbnNwb3J0IGVycm9yIGRpc3J1cHRlZCBJL08gKi8NCj4g
KyNkZWZpbmUgWEVOX1ZTQ1NJSUZfUlNMVF9IT1NUX1RSQU5TUE9SVF9ESVNSVVBURUQgMTQN
Cj4gKy8qIFRyYW5zcG9ydCBjbGFzcyBmYXN0ZmFpbGVkICovDQo+ICsjZGVmaW5lIFhFTl9W
U0NTSUlGX1JTTFRfSE9TVF9UUkFOU1BPUlRfRkFJTEZBU1QgIDE1DQo+ICsvKiBQZXJtYW5l
bnQgdGFyZ2V0IGZhaWx1cmUgKi8NCj4gKyNkZWZpbmUgWEVOX1ZTQ1NJSUZfUlNMVF9IT1NU
X1RBUkdFVF9GQUlMVVJFICAgICAgMTYNCj4gKy8qIFBlcm1hbmVudCBuZXh1cyBmYWlsdXJl
IG9uIHBhdGggKi8NCj4gKyNkZWZpbmUgWEVOX1ZTQ1NJSUZfUlNMVF9IT1NUX05FWFVTX0ZB
SUxVUkUgICAgICAgMTcNCj4gKy8qIFNwYWNlIGFsbG9jYXRpb24gb24gZGV2aWNlIGZhaWxl
ZCAqLw0KPiArI2RlZmluZSBYRU5fVlNDU0lJRl9SU0xUX0hPU1RfQUxMT0NfRkFJTFVSRSAg
ICAgICAxOA0KPiArLyogTWVkaXVtIGVycm9yICovDQo+ICsjZGVmaW5lIFhFTl9WU0NTSUlG
X1JTTFRfSE9TVF9NRURJVU1fRVJST1IgICAgICAgIDE5DQo+ICsvKiBUcmFuc3BvcnQgbWFy
Z2luYWwgZXJyb3JzICovDQo+ICsjZGVmaW5lIFhFTl9WU0NTSUlGX1JTTFRfSE9TVF9UUkFO
U1BPUlRfTUFSR0lOQUwgIDIwDQo+ICsNCj4gKy8qIFJlc3VsdCB2YWx1ZXMgb2YgcmVzZXQg
b3BlcmF0aW9ucyAqLw0KPiArI2RlZmluZSBYRU5fVlNDU0lJRl9SU0xUX1JFU0VUX1NVQ0NF
U1MgIDB4MjAwMg0KPiArI2RlZmluZSBYRU5fVlNDU0lJRl9SU0xUX1JFU0VUX0ZBSUxFRCAg
IDB4MjAwMw0KPiArDQo+ICAgREVGSU5FX1JJTkdfVFlQRVModnNjc2lpZiwgc3RydWN0IHZz
Y3NpaWZfcmVxdWVzdCwgc3RydWN0IHZzY3NpaWZfcmVzcG9uc2UpOw0KPiAgIA0KPiAgIA0K
DQo=
--------------Z2W1WF7pgtCgDouic2FpT2le
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Z2W1WF7pgtCgDouic2FpT2le--

--------------IyT0wBcxtthg0ZdZKqooNc5Z--

--------------YhzFxh5RbdDhS10y5lOacHpG
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJec/4FAwAAAAAACgkQsN6d1ii/Ey8c
eQf/bQMkknTQZG3NxjxcDIO9m4XDd3PTxiMPwdTyEiL7jc49kWOq/95drIipEiMTQqOHfGHbTo92
wfEUOnd3mTB/um2VblfM4E7Y4glFrDXxMML9f5CGVgO+QL266lIk7TFbMwxfANHIJbXUSp4Ybati
b4hxotcGx56X8EBtpCB2Sd3PTNTKQ4RFmFBhz8C/tvcr8vKvllIvTyg+7pYlPUkmLjyx13fVbSQH
eF/93zSYcpKyMOPx79PxnO3qFE9JJ0lPgdLUh3opvsrVN9tZQdM1lVTWLjVlndzlWhqtm1OC840q
PMQEiMK7wZZJWEZ11oEfISNsvWVDmUZ1MFc8yZuKrg==
=09u3
-----END PGP SIGNATURE-----

--------------YhzFxh5RbdDhS10y5lOacHpG--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:41:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:41:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307860.523192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjQM-0002F0-QC; Tue, 19 Apr 2022 08:41:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307860.523192; Tue, 19 Apr 2022 08:41:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjQM-0002Et-Lc; Tue, 19 Apr 2022 08:41:26 +0000
Received: by outflank-mailman (input) for mailman id 307860;
 Tue, 19 Apr 2022 08:41:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=abXu=U5=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngjQL-0002En-Tj
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 08:41:26 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02on0619.outbound.protection.outlook.com
 [2a01:111:f400:fe06::619])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7cf3cce2-bfbc-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 10:41:24 +0200 (CEST)
Received: from DU2P251CA0026.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::28)
 by AS4PR08MB7782.eurprd08.prod.outlook.com (2603:10a6:20b:516::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 19 Apr
 2022 08:41:19 +0000
Received: from DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:230:cafe::85) by DU2P251CA0026.outlook.office365.com
 (2603:10a6:10:230::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25 via Frontend
 Transport; Tue, 19 Apr 2022 08:41:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT060.mail.protection.outlook.com (10.152.21.231) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 08:41:19 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Tue, 19 Apr 2022 08:41:19 +0000
Received: from 3365da07ef86.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AF6BD8C6-7682-42F6-8B85-127173D7295C.1; 
 Mon, 18 Apr 2022 09:09:29 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3365da07ef86.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Apr 2022 09:09:28 +0000
Received: from AM0PR02CA0188.eurprd02.prod.outlook.com (2603:10a6:20b:28e::25)
 by AS8PR08MB6903.eurprd08.prod.outlook.com (2603:10a6:20b:39e::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr
 2022 09:09:27 +0000
Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:28e:cafe::86) by AM0PR02CA0188.outlook.office365.com
 (2603:10a6:20b:28e::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.21 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:27 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:09:26 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr
 2022 09:09:25 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Mon, 18 Apr 2022 09:09:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7cf3cce2-bfbc-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p7tS9ML08zDxjl47hmFDH/GGJS3XOkcDbsDVCb+URRE=;
 b=ophlSkyirVWZp6K5Kd3j4XzwEF3tUz/x+En54lL/dfh9To2lRZJAtiz88CHf5JB3IFTxpca6p0YH8I2rplqSTaqDFMUTXLWo41CiDEm4zhEYYkRW29xs0rrXeBMLNuv7wO4f42XYyIgpMpNEJp2A/LRuFllevCnIlo2mxiHKOo8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 759d7a6716b78d46
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M8+EqGHmU1+ZedttPSni5tCucyt4TCUM1SpOF5naxAku3MwFsms6aa/hza9SPP6PZ+iOOGX2w9IZmsYujYnes376visrkOq0xCNIBdU2gyWJZsdjYm2mVGn2/TexOYdbjvH8DdUjPhrX+LaPbN4suJ2dMCCKQBzDWkD9OmB16Dk6EIpyQPntc7QpZQZ1x+MUSvfrnSG9WbN2Xa3gGdXTAmpLRg3tc8Oexqye7whrwXvoKDlVTaNFIlaCuLywehJKFCzl5u/AsheUkrGI7hGVa9xVSrOitpNZEpzZtwdYhH1ybMB8u4s7Q5tccvrQ2edVQL0SuOse5vT3x5ojLdXWfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p7tS9ML08zDxjl47hmFDH/GGJS3XOkcDbsDVCb+URRE=;
 b=Nr6y8EKFB86xRa9yuHG1lhHAShNhFaqBfqT8yfbTH90CpUExSO+Brnz48OuQnkbrahUZTmZN5W42SMWz9w/ytcTklBxf2JHOwQKiPVCv3xRXMtydB3lVMkGhX12spaRTL1yJVy1fkmhVa2YZ9LkKuR3mmOb2L6P26Pz60nQKaRM52YmTrDO37yX/C6QoiHjtjoOHfk6Y3e0FCtzO3bsW4aUOVisUHSs494gXVIRqaK6J6zyQXeczWZCQSEZEcO/CVXFRY+BuFFQeDyAlnYw2YhbtKQDZeOtK5B0TtmwefU3jCXHLuq/j3bH+eNHotNWparD8tlmoJ1/mJsEJyemwiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p7tS9ML08zDxjl47hmFDH/GGJS3XOkcDbsDVCb+URRE=;
 b=ophlSkyirVWZp6K5Kd3j4XzwEF3tUz/x+En54lL/dfh9To2lRZJAtiz88CHf5JB3IFTxpca6p0YH8I2rplqSTaqDFMUTXLWo41CiDEm4zhEYYkRW29xs0rrXeBMLNuv7wO4f42XYyIgpMpNEJp2A/LRuFllevCnIlo2mxiHKOo8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Wei Chen <wei.chen@arm.com>
To: <--to=xen-devel@lists.xenproject.org>, <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v2 09/10] xen/x86: use paddr_t for addresses in NUMA node structure
Date: Mon, 18 Apr 2022 17:07:34 +0800
Message-ID: <20220418090735.3940393-10-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 767ffcf6-bf7e-403f-801c-08da21e06022
X-MS-TrafficTypeDiagnostic:
	AS8PR08MB6903:EE_|DB5EUR03FT060:EE_|AS4PR08MB7782:EE_
X-Microsoft-Antispam-PRVS:
	<AS4PR08MB77827DFA80BFC61E22FC21BA9EF29@AS4PR08MB7782.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 AMqSS0+fCfqaVC27wyHNgTl1/1i5GpGNEYQundD5iZsGld5mywSsTbtcbaMmaBb4gkYp7NFnGWUWMK/ItLYPM8SH7m7+qPGG8SjnS3xACnNIXva6GlJjaocX86urk1fxIFN0ybFb3r8sZoo/V7oy4VurgB5j5l6kSfpBJt0t9HWGOOXLy/zne+mVrqTFTH7nTyR6CWqmn7F61dvBK4kx6Bp5XtRpnQkZIzdYzzDWs8kQz6A2ffx/F6t7Q60ItKmWk76/0lZBznDFeCIRd+yR2pkBmBtjvigX8VRMmgXHZJPkXiDHrWg9HXIeTADKgnA1B1EDiuloLkIQ33T3ZqMVcvAHHfYOFjxMWwV50wf6zC/TGzzbrdlPqLnXbWYDjWDAzASq6juTRRTFJdRQtVzsWfQ0zrW3LAGyJgczF32Gkbk9YELSwtk6Et2IsN1dRHVxaje96OIZ+YUcu3Zd88lMDUl5wz8lAjlu8cTQHignV7/BJtPOEf5mcLmrQX/wfdMKhhNStx9zszU3Oas0Vw8AqLADx0y/CCO98GxF+lo3ZjfJjyM0V2atHAcshBILeOuv7VnRhe3RUg1S4xQ3MZImCv+Y838/JPjOItloyXvhYTxFb503/5MFFFGdzaAQ/rhM13k2KsJ2zEk1CSnzDwFCs3rE3ynQZqyxw4wbI908qAxZM2iJ8i3AODkvxfKJGHW9MmFXs4IRcFsw1h+EDrrrLA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(356005)(40460700003)(110136005)(26005)(47076005)(7696005)(36860700001)(8936002)(6666004)(5660300002)(54906003)(336012)(70586007)(70206006)(81166007)(36756003)(8676002)(2616005)(83380400001)(4326008)(1076003)(82310400005)(86362001)(426003)(316002)(44832011)(508600001)(2906002)(186003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6903
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	40d31bc9-b61b-48fc-1074-08da211b2370
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OEDOW+7ZD/gYj1kvhdC6mCpuCALUuar241SfJ+H5dDkybekn/R2Z+OcIY/nLC+jxG1pi17pDUOMr3eNd9dAUI0Gyx3WXNZeFzlHI8KBOcjzkmXA8JO8honH10nQ0Ngi1T2w7n04uZwgbxjjkgG7BV1lFctBBL2LUXU0Kvqk28QYWmDFitJtLzkpcXhoEnmdOZ76u8GB6oVpeBjQpG4AO2mvkwHa0PVtoEbL9y0ELHI6TPf+TNHmkzZHawDLAUULpqOGvLqcvrM2GFCWAI+AQpcyVy3bKXZqhC4oahBCrzaNzV+ybuXsMQ2LklSKVd7/nSfmacPSva23Sz+pkbWsTkKYZ+oW0xUbbSiLJqTT+J7Z5eZIXYisBgbL4fFvcs7zTffInP7mvDUehiHxynrPpZKUPkM4eMpWpgZKZHporfSbM+teE6Zz+7fWOU5n0ZXdXqJLjt+i8PvP22czQFrB3jQEu1YHBxL4RwR7iGD962sixyrR2YOztruu7XtF/BaJXugly8bWkauE3iguAODvmFXVco0METtjj2CcM3l0gHJKK9bJoqUalH3MK6la5du+Pt/+gipN3cZ4ImIV9+ybjKkPml3grsx680KLWBZtxUJGxWjpy0fp6wSXueRJfgmSg8uIAvl0kDOf2Oeo7le0UhZ3UFo+/8Pull8gHDyBrFwR9Amcbmuf9O6ZwOWHgF8AS
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(2616005)(47076005)(5660300002)(426003)(82310400005)(70206006)(70586007)(44832011)(8676002)(36756003)(450100002)(4326008)(508600001)(316002)(8936002)(2906002)(36860700001)(81166007)(83380400001)(26005)(1076003)(336012)(186003)(6666004)(54906003)(40460700003)(110136005)(7696005)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 08:41:19.5454
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 767ffcf6-bf7e-403f-801c-08da21e06022
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7782

NUMA node structure "struct node" is using u64 as node memory
range. In order to make other architectures can reuse this
NUMA node relative code, we replace the u64 to paddr_t. And
use pfn_to_paddr and paddr_to_pfn to replace explicit shift
operations. The relate PRIx64 in print messages have been
replaced by PRIpaddr at the same time. And some being-phased-out
types like u64 in the lines we have touched also have been
converted to uint64_t or unsigned long.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v1 ->v2:
1. Drop useless cast.
2. Use initializers of the variables.
3. Replace u64 by uint64_t.
4. Use unsigned long for start_pfn and end_pfn.
---
 xen/arch/x86/include/asm/numa.h |  8 ++++----
 xen/arch/x86/numa.c             | 30 +++++++++++++++---------------
 xen/arch/x86/srat.c             | 25 +++++++++++++------------
 3 files changed, 32 insertions(+), 31 deletions(-)

diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index 6eeae02060..1239f017c2 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -19,7 +19,7 @@ extern cpumask_t     node_to_cpumask[];
 #define node_to_cpumask(node)    (node_to_cpumask[node])
 
 struct node { 
-	u64 start,end; 
+	paddr_t start, end;
 };
 
 extern int compute_hash_shift(struct node *nodes, int numnodes,
@@ -38,7 +38,7 @@ extern void numa_set_node(int cpu, nodeid_t node);
 extern nodeid_t setup_node(unsigned int pxm);
 extern void srat_detect_node(int cpu);
 
-extern void setup_node_bootmem(nodeid_t nodeid, u64 start, u64 end);
+extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end);
 extern nodeid_t apicid_to_node[];
 extern void init_cpu_to_node(void);
 
@@ -76,9 +76,9 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr)
 				 NODE_DATA(nid)->node_spanned_pages)
 #define arch_have_default_dmazone() (num_online_nodes() > 1)
 
-extern int valid_numa_range(u64 start, u64 end, nodeid_t node);
+extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node);
 
-void srat_parse_regions(u64 addr);
+void srat_parse_regions(paddr_t addr);
 extern u8 __node_distance(nodeid_t a, nodeid_t b);
 unsigned int arch_get_dma_bitsize(void);
 
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 680b7d9002..2b3a51afd0 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -162,12 +162,12 @@ int __init compute_hash_shift(struct node *nodes, int numnodes,
     return shift;
 }
 /* initialize NODE_DATA given nodeid and start/end */
-void __init setup_node_bootmem(nodeid_t nodeid, u64 start, u64 end)
-{ 
+void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end)
+{
     unsigned long start_pfn, end_pfn;
 
-    start_pfn = start >> PAGE_SHIFT;
-    end_pfn = end >> PAGE_SHIFT;
+    start_pfn = paddr_to_pfn(start);
+    end_pfn = paddr_to_pfn(end);
 
     NODE_DATA(nodeid)->node_start_pfn = start_pfn;
     NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn;
@@ -198,11 +198,12 @@ void __init numa_init_array(void)
 static int numa_fake __initdata = 0;
 
 /* Numa emulation */
-static int __init numa_emulation(u64 start_pfn, u64 end_pfn)
+static int __init numa_emulation(unsigned long start_pfn,
+                                 unsigned long end_pfn)
 {
     int i;
     struct node nodes[MAX_NUMNODES];
-    u64 sz = ((end_pfn - start_pfn)<<PAGE_SHIFT) / numa_fake;
+    uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake;
 
     /* Kludge needed for the hash function */
     if ( hweight64(sz) > 1 )
@@ -218,9 +219,9 @@ static int __init numa_emulation(u64 start_pfn, u64 end_pfn)
     memset(&nodes,0,sizeof(nodes));
     for ( i = 0; i < numa_fake; i++ )
     {
-        nodes[i].start = (start_pfn<<PAGE_SHIFT) + i*sz;
+        nodes[i].start = pfn_to_paddr(start_pfn) + i*sz;
         if ( i == numa_fake - 1 )
-            sz = (end_pfn<<PAGE_SHIFT) - nodes[i].start;
+            sz = pfn_to_paddr(end_pfn) - nodes[i].start;
         nodes[i].end = nodes[i].start + sz;
         printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n",
                i,
@@ -246,6 +247,8 @@ static int __init numa_emulation(u64 start_pfn, u64 end_pfn)
 void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
 { 
     int i;
+    paddr_t start = pfn_to_paddr(start_pfn);
+    paddr_t end = pfn_to_paddr(end_pfn);
 
 #ifdef CONFIG_NUMA_EMU
     if ( numa_fake && !numa_emulation(start_pfn, end_pfn) )
@@ -253,17 +256,15 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
 #endif
 
 #ifdef CONFIG_ACPI_NUMA
-    if ( !numa_off && !acpi_scan_nodes((u64)start_pfn << PAGE_SHIFT,
-         (u64)end_pfn << PAGE_SHIFT) )
+    if ( !numa_off && !acpi_scan_nodes(start, end) )
         return;
 #endif
 
     printk(KERN_INFO "%s\n",
            numa_off ? "NUMA turned off" : "No NUMA configuration found");
 
-    printk(KERN_INFO "Faking a node at %016"PRIx64"-%016"PRIx64"\n",
-           (u64)start_pfn << PAGE_SHIFT,
-           (u64)end_pfn << PAGE_SHIFT);
+    printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n",
+           start, end);
     /* setup dummy node covering all memory */
     memnode_shift = BITS_PER_LONG - 1;
     memnodemap = _memnodemap;
@@ -276,8 +277,7 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
     for ( i = 0; i < nr_cpu_ids; i++ )
         numa_set_node(i, 0);
     cpumask_copy(&node_to_cpumask[0], cpumask_of(0));
-    setup_node_bootmem(0, (u64)start_pfn << PAGE_SHIFT,
-                    (u64)end_pfn << PAGE_SHIFT);
+    setup_node_bootmem(0, start, end);
 }
 
 void numa_add_cpu(int cpu)
diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index cfe24c7e78..c3e13059e9 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -104,7 +104,7 @@ nodeid_t setup_node(unsigned pxm)
 	return node;
 }
 
-int valid_numa_range(u64 start, u64 end, nodeid_t node)
+int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node)
 {
 	int i;
 
@@ -119,7 +119,7 @@ int valid_numa_range(u64 start, u64 end, nodeid_t node)
 	return 0;
 }
 
-static __init int conflicting_memblks(u64 start, u64 end)
+static __init int conflicting_memblks(paddr_t start, paddr_t end)
 {
 	int i;
 
@@ -135,7 +135,7 @@ static __init int conflicting_memblks(u64 start, u64 end)
 	return -1;
 }
 
-static __init void cutoff_node(int i, u64 start, u64 end)
+static __init void cutoff_node(int i, paddr_t start, paddr_t end)
 {
 	struct node *nd = &nodes[i];
 	if (nd->start < start) {
@@ -275,7 +275,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 void __init
 acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 {
-	u64 start, end;
+	paddr_t start, end;
 	unsigned pxm;
 	nodeid_t node;
 	int i;
@@ -318,7 +318,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 		bool mismatch = !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) !=
 		                !test_bit(i, memblk_hotplug);
 
-		printk("%sSRAT: PXM %u (%"PRIx64"-%"PRIx64") overlaps with itself (%"PRIx64"-%"PRIx64")\n",
+		printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself (%"PRIpaddr"-%"PRIpaddr")\n",
 		       mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end,
 		       node_memblk_range[i].start, node_memblk_range[i].end);
 		if (mismatch) {
@@ -327,7 +327,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 		}
 	} else {
 		printk(KERN_ERR
-		       "SRAT: PXM %u (%"PRIx64"-%"PRIx64") overlaps with PXM %u (%"PRIx64"-%"PRIx64")\n",
+		       "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%"PRIpaddr"-%"PRIpaddr")\n",
 		       pxm, start, end, node_to_pxm(memblk_nodeid[i]),
 		       node_memblk_range[i].start, node_memblk_range[i].end);
 		bad_srat();
@@ -346,7 +346,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 				nd->end = end;
 		}
 	}
-	printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIx64"-%"PRIx64"%s\n",
+	printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIpaddr"-%"PRIpaddr"%s\n",
 	       node, pxm, start, end,
 	       ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : "");
 
@@ -369,7 +369,7 @@ static int __init nodes_cover_memory(void)
 
 	for (i = 0; i < e820.nr_map; i++) {
 		int j, found;
-		unsigned long long start, end;
+		paddr_t start, end;
 
 		if (e820.map[i].type != E820_RAM) {
 			continue;
@@ -396,7 +396,7 @@ static int __init nodes_cover_memory(void)
 
 		if (start < end) {
 			printk(KERN_ERR "SRAT: No PXM for e820 range: "
-				"%016Lx - %016Lx\n", start, end);
+				"%"PRIpaddr" - %"PRIpaddr"\n", start, end);
 			return 0;
 		}
 	}
@@ -432,7 +432,7 @@ static int __init cf_check srat_parse_region(
 	return 0;
 }
 
-void __init srat_parse_regions(u64 addr)
+void __init srat_parse_regions(paddr_t addr)
 {
 	u64 mask;
 	unsigned int i;
@@ -457,7 +457,7 @@ void __init srat_parse_regions(u64 addr)
 }
 
 /* Use the information discovered above to actually set up the nodes. */
-int __init acpi_scan_nodes(u64 start, u64 end)
+int __init acpi_scan_nodes(paddr_t start, paddr_t end)
 {
 	int i;
 	nodemask_t all_nodes_parsed;
@@ -489,7 +489,8 @@ int __init acpi_scan_nodes(u64 start, u64 end)
 	/* Finally register nodes */
 	for_each_node_mask(i, all_nodes_parsed)
 	{
-		u64 size = nodes[i].end - nodes[i].start;
+		paddr_t size = nodes[i].end - nodes[i].start;
+
 		if ( size == 0 )
 			printk(KERN_WARNING "SRAT: Node %u has no memory. "
 			       "BIOS Bug or mis-configured hardware?\n", i);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:42:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:42:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307865.523202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjRV-0002wl-6u; Tue, 19 Apr 2022 08:42:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307865.523202; Tue, 19 Apr 2022 08:42:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjRV-0002we-3v; Tue, 19 Apr 2022 08:42:37 +0000
Received: by outflank-mailman (input) for mailman id 307865;
 Tue, 19 Apr 2022 08:42:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngjRT-0002w6-OH
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 08:42:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a8b970a0-bfbc-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 10:42:35 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-WUc-B0ijP26bWt4kRQXkpg-1; Tue, 19 Apr 2022 10:42:33 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5278.eurprd04.prod.outlook.com (2603:10a6:803:59::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 08:42:30 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 08:42:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8b970a0-bfbc-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650357754;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=p/woneOYshgtmIMld/+jQHXDH1F7e042Iv3EGlBwRic=;
	b=iM0dCjtTt90Atf0IE0N4V4XianMRB4aljTGstIQMlRA+r0z+9/V8cootF17bPvT+mLik+0
	vzDYd+Z4vZGnepi+Q19uzVDCHrdVvxqCALc2qiGqaFbIJPK5cQmpPwJkWnylEyAY4gqQqu
	RbEKwiD20B6JIyNBJSDwi3YkubYwUMI=
X-MC-Unique: WUc-B0ijP26bWt4kRQXkpg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SlSgiuVEA4Xa9RFzZZhal39lKlAGnKfexY5y7ODxShQaYKGzTP7zsC2HMALa3c7wGIqpBQQ3GsKl/goG47FgTWSP/YnxwBrsepLYhnm+E4+EzsQyV6psrEuSapvyMy6x/QddjoS2CBa5fcno+8KgAjMkSuRAXqTHp4/FQSP4brdLalKx8CZ2IHgdEMmnBSELIVKskkVErHUPoMrrKnKgSueSvH5UW8itnDSybpfmTse9ILViqKVRbmA2fCnsVyicQZ8oi+JJWD0JzW7RYM9omO1zuSjxHsAoaJwJOPvaSa1PV/BatO1e+IPF9VwiDtnS+b67p7JojvrFdeF4br/9zg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p/woneOYshgtmIMld/+jQHXDH1F7e042Iv3EGlBwRic=;
 b=RxkT5ANujIG+6d2ED8a3/m+8cE6la28XSvhGOzZy9HpJ+Do8Xp+ymFoshghIjTy75aMACRQ/btBrFxMuhtn2Et9j2ZCF6nzjUTZcockSz7XjoTUc8jjzafVFhqDSPele+GEX6a84J0xHUruJ5MP9R+uK0pwc0vd1hzzOLDVBtapNaX6/Z0nkjtiEP90ruR4dhEOUVIngKNqJXFKF+38Nv5c+5J4dhWjPDzucoS+mOsVpsvSnrV5zIsnWun0z35Y70up4LpBGjAAawuwpCKDXl4WaskdXnhgU4/6Siq78MeEN/HmE/zlKSJXYPwT2soouaoLI68/y2ob8ikym+54aMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fb19f5ac-b8e9-7cdb-4f72-71b73e6f4b8e@suse.com>
Date: Tue, 19 Apr 2022 10:42:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>, xen-devel@lists.xenproject.org
References: <20220416133158.16162-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220416133158.16162-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0028.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:14::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7beb9812-e459-4a2a-beb0-08da21e08a44
X-MS-TrafficTypeDiagnostic: VI1PR04MB5278:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB52781CAC3BE2C281B865A15DB3F29@VI1PR04MB5278.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A54oHw53XUuh22u1DrapLmaig9m02kUQrEA3bwquQeb0IHGPvbmhMwi4IWgR/iPEupXASVPQoYAmifGjiCaUo6kckM7MlytTxIe/wnV9e52V3Rqvi9OP2zkXEttlnSuCN/Mos6V/ZLNAEOCEL7wG+khNCLYNWo2KoghbzdaDSjPPtQ8Efxsu9sBX91sdpBX9C7QgkSt7IontDzJgSwrxrEfV8/cb1aXONJwRzoIZHwGZD4VjtIoa2Z6tCshYKwc3Br+z/WUF4J0ZHutN1iZuS2Qikr9ARbBYGet16nCfnhxA40PViV4b/v5BFM74/X0OyAYTjd4Htxsnrc2c0zd4a37TUHI0b43OUlOmWFDDUmx2MqCexTUFYXy6F3jj6VrWsmfo72TlbjSHMQlbJ2aXFORZuVc126S7vldrpjSU2oDq3grTE65shE6BdiAVGnUE29SI9+XyPL4YyFn43HWP94KIrf5vHX62Qu1HQpfo29yDTZnfN5Yb97ubAiWqmSpdyB+R/Zh7vm3aW9guDCEV1voCn32hiUHnqU0+LXapQzDDUh/TR6+5EZ3QPr1wNWqyB5kSs2F9ax3PHJf5ZqAP06fibHTZ1kkWNUqOBAWsyntE2ZLrFWWTnGQwGIq5XlfNj1EOBv9727rnWaJyNcyFLZ0Hahlt56Scr+dqehJebh4ehQMxO3PvPJg6b5p4Dx3HVD9oDylzMQNkWukmQEoNdhtxqqdV2sAiPJFjjTipoPU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(316002)(83380400001)(54906003)(6862004)(4326008)(36756003)(66946007)(8676002)(66556008)(66476007)(31686004)(6636002)(37006003)(38100700002)(6512007)(53546011)(2616005)(6486002)(508600001)(186003)(2906002)(6506007)(86362001)(8936002)(26005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QzcwWThDM0Jka01YS0RRWUp5Nys1bGMrcStOQUFUdTlIemE1Rzd5dmhvSHJE?=
 =?utf-8?B?TU5XM0N5TTV2eHV0cUt4VTJ6L2s2bm9kcHBoN3ByWFNpVnBaYkQwYm45aUlM?=
 =?utf-8?B?SHVLVXJwUk5ZVnJpM2pRamhraU1TTE9zRUhMY0x6R20vbDJDRHllbFZUMmJl?=
 =?utf-8?B?VHpmMFRSZnp0R2xRZ2QxYzhjaHR4N1A2TExmY0NkUGYzNkVKVjNnSWV3Tkx2?=
 =?utf-8?B?VDJqZ25uSkFBMWpYS0hTUGx3ZzBqVnR1SVZ6ZWRYVW5kZXhKTFRVNkhORUEz?=
 =?utf-8?B?STZZNUZuL21kaXNYVWpZQUZla00ycVNwL0tOUFZ2Z1ZQN3JBc1QzRW5TV2NL?=
 =?utf-8?B?NUNnSCtMR01zLzM4RXZKZHZzcWkwVkNOSHVwV3EyWFJscVpqUEZkWGtJd2ll?=
 =?utf-8?B?NDBPVGZ5SUhkSDBLZ1hHa2sybzBjdmUyVHpBdE9xVTJERkVoWkplOVVqanp1?=
 =?utf-8?B?K29DU3pDbUJ2am56N1hXL3Vac1lnTHl2R0tsUmVid2psZHhEaFJLNXhkY0ZS?=
 =?utf-8?B?Ukp4UTU4OVVCUTdqUzBKYzFNcU1qdEdPb3UwTU5SVEZHallxQ0ppWUl6R2da?=
 =?utf-8?B?bkdLQkpzWUtmekZMNnRoM3RUNUV4am1sVVVRbkRPSmM4c0diTllLNmtNUS9P?=
 =?utf-8?B?dEFaK2tKMkh2bnNRQkUxbS9weUFPMkZINVEwQjZ1Q2ZKN1ltNkNqNlhBaFNG?=
 =?utf-8?B?TUFZcVJEZkFJZXp6ajBpSWNsUGlzY2daZkJKMHlUY0dCZitORkZPd3p2Sk9S?=
 =?utf-8?B?TXNmalIzUU01WE1QTDZJUlpwYUZvZzBtYm5BMUJPTjRqd3NwdWtOYzFmUEJy?=
 =?utf-8?B?bC91TENKa3REUmpmVXBCTEdVOVNha1UzWVI5Y1dBQS9VNm4xaXRVcDNwbkhL?=
 =?utf-8?B?MEJoOGFmRTVaeTBDKyszb2pqTlN5cmxMRXpOL2hTSFpRSmE3Zm5RNWtsaDRq?=
 =?utf-8?B?aXhUdzdzU3ZscHBjS1VFL1hFTHV1alRHWnFDVTc1dE5iajkxVElEdkZYTGxo?=
 =?utf-8?B?K1Ruc096MDYyWk9RRGtnc0drUXUxSWVqOGZoRHVEOXdFdHVxQ0s0bHdsZVVF?=
 =?utf-8?B?VkVBQU9La3BkeWE4Q3RFVHhYTWZLL1FSQ095dVJmTytTc28xbGd4b1p6M1Nu?=
 =?utf-8?B?ZHQwd0ZUSk1IQUg0Y3hiZVprZTNtSjZZR1RLa0RYYldkK1d2SEM4L0IvSWgr?=
 =?utf-8?B?NHdSZXdidUNEZjFSaEk5YkdTZ24yRDdYT05YYjluMVozVVBQcmtoQkVJOHA1?=
 =?utf-8?B?LytTS0RPaXlJdFdyRHU1cWRDWDZsQk0zV1dtcFcvTnhOa3JEOGVCcU9vM3lQ?=
 =?utf-8?B?N0kvTFB3YTZIVmMvMk9lenU5L3NldFdMeTN1QWZxTUVKbTRkUlJZMmt1S3ln?=
 =?utf-8?B?eis3bGpNN215QjBHY3Q0aW1sRFFtcWFWazZFVCtOV3FoNUIxeHFVOXdpMHRj?=
 =?utf-8?B?UlJpdFJOUlpnMll2UFFPRlRLb2g4b1RIbThscm9jTEg0cm5vaUkxaXRBaVdj?=
 =?utf-8?B?Z1p0bXNBM0pJeXY2YmpJeXBQYzF0ait5dnBKUkNDTHNxaEJLZFZNWHR1YmdS?=
 =?utf-8?B?ZS9rYTNETFYyQTRLSkpPUkR5Qk1BVlo0dWNseGdwZ2xraVhkTXpmWHlvdysv?=
 =?utf-8?B?YXFnOUsweGxVcTM0V3h4TDZ2K2Y5cEw1OWFZVXVUYnBLMStGRFNWb3UzS1RG?=
 =?utf-8?B?NDRiRHFsT1N1V3dXSmhBbG1XQ3BBQXFGRWpNSWxHVENSbCtQb0lIQk14K1kx?=
 =?utf-8?B?cTZIclVQaFpGZWpRVDJiODRYS05IQlAzbElCaTI4b1phM0NmSWVYTzgrQ080?=
 =?utf-8?B?QXdSYm1UekdvRWI1Unc5cERBUG8vK25JMTNOd3Qxd0dQTDl1RFhOZ3BnbElY?=
 =?utf-8?B?WWF4eE5aZW5nTk5IcnhOMkQvdVFIMFBFWlJFbFMwYmR2blgwcFFoM3dKT2RS?=
 =?utf-8?B?VEpMODJGdTJKbXNheVpTTFgvaFhLUEIyVDY3MkpxVFRId2RmMVpyWktlMUxL?=
 =?utf-8?B?blE1c3VkRXJLZks2YzhROU9SNS8zYTJ5Qk9CS1g3MFQvdDhZanFPLzBqUkRw?=
 =?utf-8?B?aWgvQmVjWUNmbTg1Q0tzRHc3WXRuNDlhL2wxaGgrWGpoaHg5YzdtQ3BXSThs?=
 =?utf-8?B?RjI0VmZDdXB1d0dwejl4ZEZxYkJvMzE4bDJiRGYwdThlaGZWdXJXMGh5VzBs?=
 =?utf-8?B?OEhCeGNibVpzYnNTbVhkQ2xJMEhlcmsrQjA5V09LTUM1S1ArWVMzeTI5bFFr?=
 =?utf-8?B?cFF5THl6QlF0MEhTVlNtSDV0aVJUOTRtTE8xWUpFeHRDWlRUckVUelpFRjU4?=
 =?utf-8?B?eDhsRXZzM0drQTRpRE5vaHNQMlFqUEg1L2dFdjVLOFFPeTh1eUxGUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7beb9812-e459-4a2a-beb0-08da21e08a44
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 08:42:30.3591
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f/aXVtanQ6QzVDWS/fXU2D8ozYsY/D7meBD4lo45Fe305kpJd6IdBld5l4X5jZ3taNEJyQt+3vJi9SdmOhjdxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5278

On 16.04.2022 15:31, Juergen Gross wrote:
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -308,7 +308,9 @@ long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>          if ( op->domain == DOMID_INVALID )
>          {
>      case XEN_DOMCTL_createdomain:
> +#ifdef CONFIG_GDBSX
>      case XEN_DOMCTL_gdbsx_guestmemio:
> +#endif
>              d = NULL;
>              break;
>          }

Wouldn't we be better off simply deleting this case label? dbg_rw_mem()
resolves the domid anyway (exactly as done a few lines down from here),
so I don't see why we couldn't pass a struct domain * there instead of
a domid_t.

This would also reduce the risk of further similar "overrides" appearing
here (taking existing instances as "excuse"), and breaking things again
in a similar way.

And finally I think iommu_do_domctl() needs making resilient against d
coming in as NULL. This isn't just to cover the issue here, but perhaps
more importantly because XEN_DOMCTL_test_assign_device can legitimately
end up having NULL passed here (when the caller passed DOMID_INVALID).
We've simply been lucky that libxl doesn't use this variant of calling
this domctl. I guess when d is NULL we ought to check the global flag
there rather than the per-domain one.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:46:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:46:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307871.523214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjVS-0003dj-Pd; Tue, 19 Apr 2022 08:46:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307871.523214; Tue, 19 Apr 2022 08:46:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjVS-0003dc-Mf; Tue, 19 Apr 2022 08:46:42 +0000
Received: by outflank-mailman (input) for mailman id 307871;
 Tue, 19 Apr 2022 08:46:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngjVR-0003dW-Ba
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 08:46:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b0788d9-bfbd-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 10:46:40 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-30kMAKx-ME69Q3IEkq9Xbg-1; Tue, 19 Apr 2022 10:46:35 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB6318.eurprd04.prod.outlook.com (2603:10a6:803:f3::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 08:46:33 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 08:46:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b0788d9-bfbd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650358000;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=u7PxaHUOrgYXxz8Eg25NMAmP24bRqiAmVQlVEwg2qVk=;
	b=UUEs9jd2V8keZHboo75dz8w6yLih+9CfBJnbjcLC7AM18smdbJiV+fl/SJb33c+NxjZ4Tk
	QINZocNUzErRNnIxVob0s/Ty76sWvKVyuA1nbygsbzg1g5iNNAYt9/biiOWdPM2wDVGRRp
	Le9rK3ytfmm1I2CV9LARlpAx+8heWlc=
X-MC-Unique: 30kMAKx-ME69Q3IEkq9Xbg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K4gk/5AjEc6xmnf/TsAhPlNUhanmqu+Kh8HKZbJjdMBJTE+YtMIK90ls312f6OSU25qR5RuV/k2oddHo8c2YwylMSKG99ase/tZO/JDjHmkrdpQohski5YziJmR7FOm8HxGxrik6xi5LlRYBOKT6heo0icd8Cylvhscj1+AcRcx4eELTLxOtrHdveNAov92xRMfrgppW9jfUqevqa7s5auf8ZuMkGat5jA48VtK6bg3ACjMDodkKYrRyPbouNuDSjLxcMVcG4ktrXvD2XxYMPKXZsK0crbOhjUN8rK+/r1zydXLza9TGwXE2xGJ2ZHiVZ3bh4/cWkG6x68KBvXKsgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u7PxaHUOrgYXxz8Eg25NMAmP24bRqiAmVQlVEwg2qVk=;
 b=KZEmQqvhcH/ND0/eDGegIKFrGIX74wWDEj5druJvv9VlcisIGxjv91KGHglZKg/0YeYIqgA13oO+gGTffTAAxJR5GKjSSSx8ciuqDl71HylJ9oByNmYYawFs3MfFCjfl+kL/dsoXn3uWJWZppCGMn94LQkc2bhMS8hCSSwKxJtNDAjxO13dB5IdM03rrnVyBA1RQNleobff7YaYGxJOQdJTxv2OJoYa3z465YFQoMB2syOJjOhUp6iBKOPLKKpKGroOWGUno3DS38Wd7jz2zQzaiBRGgODKdFZoekSF25ACRfiGWsUulwDQ8699GYj/kUxt7Mo1bw/oP1FtElcl0KA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <505f2900-4f0b-e3ca-93c3-705028c1e826@suse.com>
Date: Tue, 19 Apr 2022 10:46:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V2 0/6] populate/unpopulate memory when domain on static
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: wei.chen@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418122251.3583049-1-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0036.eurprd03.prod.outlook.com
 (2603:10a6:206:14::49) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2427c996-22e7-48b9-563e-08da21e11b51
X-MS-TrafficTypeDiagnostic: VI1PR04MB6318:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB631838A0C299E9D629D7E57DB3F29@VI1PR04MB6318.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D+0JlO2JjmG/D5oZpJWvF2biemaA5ztG+UcVvfCnwR8QeIzPGEOfNX/p1r1dogQTuAy+hdgJOS/0aosLY/PZn0FI4KfOS4oYoHaLytsH4EJQk0nyOe+xjam2aKiAgTreaNDNWUAUH4EggMVGxtZGLR9TrV/mnXLRHd3BFNPZBqPARyhUOdf0aXwRLT4ZF81zBHUUlej9wOaenwUISFNy01YZym0Ex8oAKJkS9t/EOMya1OobmUFbPbptq/GxLuSUD18lGwqD3juAt2ngXgkWBpZ6ZqWhyZiwf8emJHkWmfK6zEGCOohkx8NWlekSJKuICprfb9u2x6uMyWC3o2LwoLOqhsU6GOhHFVou4UxNT6IIfwrxTnbLSbeZvWscIjpC9kRnt8dOkpRkJuF1f66MipCP2RDWYEBfxtYEVnLeiPytzEnGacFn6tpnavoy3+Ts56GxWL8PF2aciJ4yMJDC9NFo3NFEaPNK3uBOfJgFVprPV3Zf8R46Pds6o1azTjt/d4AWB/hBMsMb1ZGB0MeiqMiEgFnWFQFSoxXzXe6DHa5fuAamjqALBR7xPhYjBwYVdMaIcYw1SiB+PYBp9Ch5XqzV/RbzidpQkpdDvm4O67G1R7j21U8q6rmGV19TpjblZNb/qv2ULWVflxoqw6DVBtOXSf7NXyAKwTbPeTRVWK6crp2nhYmfJ9LWWtQWvrpQ1/8A1HAK1pybpEy2bongVb9kdtZpasOGfpwQ0MMo5FVrj79HiYv41TYgCQAQuq0W
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(86362001)(508600001)(186003)(6486002)(6512007)(8936002)(2616005)(2906002)(5660300002)(53546011)(6506007)(31696002)(7416002)(36756003)(66476007)(66946007)(4326008)(8676002)(66556008)(31686004)(54906003)(6916009)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b0R3Rzk1dUdPNmt0ZDVaZjAwNE5sajd1SW0wQlJQRW9nS3BQQzBoc21qQVNk?=
 =?utf-8?B?Sm95cXdweVI5YjR5THRKVkJrQ3FGeVNYMzVMSUFHb0NTYzlSZ0cyUERxNGxh?=
 =?utf-8?B?K3FvTFVOQnNSYU85QkIvaGdTdXI1dDI0QUFLRFFMSXFRM05vbXBLMWFzMnQw?=
 =?utf-8?B?b25ySHh2TFRRSHVEclpkQ0JCNXVZc1RYb1JIayttTFVGdlJkb3RybC83OEs3?=
 =?utf-8?B?WE4rRUI2Ymw5bTMxRlhHZlhxaFB2TStZWFpmMThmdnNwTitYbXA5L0xoQUFi?=
 =?utf-8?B?dmJmOVVXYytQU0lIVGlNTzd2SFlaeWVZWEVUSUpYSDJwMTQxQ1NSRjNMYXp6?=
 =?utf-8?B?MVFXUWMxTndMTG1TbklMWjdLR1hPRi9nRHRJcUV3QndXdWVQaUg5SmthWVp0?=
 =?utf-8?B?VXVyMDhhQTlTYXpINVdvUlNqcnJxNXZPL2tEZ2JtelNqakdpQXMrUmRucXJk?=
 =?utf-8?B?dmpjbmtjZ3UyT2VYYi9mMWp5eFh0T3NKZ2x6OVlORVNwd1ZBdXY5OHVWOHF5?=
 =?utf-8?B?clZrd0tIOHNaS2VIeGR6MGZNNVhwME92Q21GMFErMjhkZjFBcnlyVHZrbnpK?=
 =?utf-8?B?YmV4NXFKdm9vcDV5Sld0SEVkeDFnSGpLeGxzam9IT1F6QVVPQXpudUdMUDdu?=
 =?utf-8?B?eUljNFg5RlV6Q2NValpFdDZCQUNKcmdZY2pCeGpJZnNEbTBPWTFKbXFVRjB2?=
 =?utf-8?B?eUk3U1R3K2NQWWVqaksxTzdaTjA3ZUs1aTJsT2wrRHVZMzRNelFYeVpSUkNR?=
 =?utf-8?B?SDQ4SFREOTgvVGxKTXFnUk5iMGxyVms1alBsZG9hdVJBNitFcC83V1ZTRStF?=
 =?utf-8?B?RDI0VklQdFdvYzU4emF3L3l2TnVabEs1RHRtMjlxT2NKSTkzKzdNSElFMGw0?=
 =?utf-8?B?NW5hb2VqdmMvSDk1Ym5WWFNXNnVFaVczK2JESC9KZFVXVEhRS2dpdWkwZGV5?=
 =?utf-8?B?c0wvV05SVnhxS2NmK0lpcTdiMnFmWnA1di9NR29Cems0OTZZMEFCYmp6Vmha?=
 =?utf-8?B?M1VycGRkQkROUUJkOVhmekhsZUdlckZMbWZja3RoWWhHUDd5S1JpdnNVVysy?=
 =?utf-8?B?QWF3Q09OSlB3VzhrZnJLS1krV2t3ZkZYd0JUc3VZT0ZaVzUxbFNndEthUFg2?=
 =?utf-8?B?b1pUdjBoM25ydHR5ckxjTW9CNVp4OWZCdU1jeTdXN2J2TitIc1h6NkIwdURv?=
 =?utf-8?B?OURvakJDWXhzT0U1Zm1hL3c2dFBKeG9YS2FFNGFmTldJczZqTGwvYmRZcS85?=
 =?utf-8?B?bFY1bDlESXZ4ZXA4Vm1nTkc5NGNwSTFwNENya2FIbk9tZVdUUFVabXduNm14?=
 =?utf-8?B?L1ZBUXoyTkpCWnhjQ1RVSzVrcGNiaTBqY3Zsb2JjSkd0ejViTWJpbmN3bkts?=
 =?utf-8?B?OFgwYkpsVnhlMGVRVWIvcmU2OTJHY3Z6NkZZd0wzNVJKUjQwR1VUWkp0cjhi?=
 =?utf-8?B?ZFFrQUIwVEtJcnIxWWE2dnY4ZDlNdTg1MUdaOXBDa2RQS0JiNE9xcWJYUXRl?=
 =?utf-8?B?TjU5U1kycGJCLzFRZ0xuTTQrZjhKWk5UM0drSEZ6cnZDaFRvRHh4RHpITytw?=
 =?utf-8?B?M25na21FcGpSNTdPclBpKytrS0hxZXk2VVhEekhVSHl1dXRxWlRSc29UTmIy?=
 =?utf-8?B?RnVkaVpjcHNEdnZsWmNPMlFFcGZEKysrOW9KY2hCc05LeGhwTi9udVlzMExO?=
 =?utf-8?B?TzZFVkhsQWw3WTg2Ylp3NldHRDA1RjNiQWNZOFRmT09XcmlFQW9GT1B2cEtk?=
 =?utf-8?B?TWdXYTNZSHVmZjRXSVgraWVJZWxZd1g4ZXlGdHlkZ3YvZFBLZnpLSm5EcGh6?=
 =?utf-8?B?d1JMQitVZllRZEFkQzNlbEcvMVNna3dWSTl5djZsY3BlT3pKclJNZ2ZCZGR1?=
 =?utf-8?B?cVBIa1A3Q2lKYkFlN29zL1FHaDBWc2FYeURTcHN4OHdVV2Q5N2l6cHphcWky?=
 =?utf-8?B?SmNMY05uRDdTVDl5QmllTUtEVElSSmRLd2JBSkRQVFlwS3hubEh5eU9zZjFq?=
 =?utf-8?B?b0l5Y21KT1JEZi9SVmR4TFBvU3lkdGkrZTMrMnBuenp5MnpHRHZGaENPblBC?=
 =?utf-8?B?SHZGQ0VOQmxxMUJ4Z3hlaGFUNkJwdU93c1V6ZG55djFUYjh6cjFEcjFxOHBG?=
 =?utf-8?B?WnRWbTVsZDBBS3RWc1E2NVFUekRlNi9VRTVXZFJWOHlyQTNhVWdmRndrcnBp?=
 =?utf-8?B?YnlhSVhaWDJPTVc0a1I0SW1PVXJiQTJ1MHlOTnUzaWVMd0NRSTdIS1pwam01?=
 =?utf-8?B?aUl6ZEZKVVFiZEpERWIycTZUTmF2Z3hQWHN5a1BPMFlDeXpWNFM2VFUwUzNt?=
 =?utf-8?B?aU9VcDVtaWh6R241N2NBZS9OMlJGdXRlWjQxZ2tFTFNsUDJqQVo3QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2427c996-22e7-48b9-563e-08da21e11b51
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 08:46:33.7582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JUNmUmsfmfRvV8g2WUsRiBmem5h7QF0uPAeM7pjxkpvFL3WBuoi7Nv3eaDDtc43Q9JM3mq7AkYaz/LsvCC0+ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6318

On 18.04.2022 14:22, Penny Zheng wrote:
> Today when a domain unpopulates the memory on runtime, they will always
> hand the memory over to the heap allocator. And it will be a problem if it
> is a static domain. Pages as guest RAM for static domain shall always be
> reserved to only this domain and not be used for any other purposes, so
> they shall never go back to heap allocator.
> 
> This patch serie intends to fix this issue, by adding pages on the new list
> resv_page_list after having taken them off the "normal" list, when unpopulating
> memory, and retrieving pages from resv page list(resv_page_list) when
> populating memory.
> 
> ---
> v2 changes:
> - let "flags" live in the struct domain. So other arch can take
> advantage of it in the future
> - change name from "is_domain_on_static_allocation" to "is_domain_static()"

I have reservations against this new name: This could mean far more aspects
of the domain are static than just its memory assignment. Was this intended
(or at least considered)?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:59:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:59:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307877.523236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjhw-0005WM-AJ; Tue, 19 Apr 2022 08:59:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307877.523236; Tue, 19 Apr 2022 08:59:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjhw-0005WF-7N; Tue, 19 Apr 2022 08:59:36 +0000
Received: by outflank-mailman (input) for mailman id 307877;
 Tue, 19 Apr 2022 08:59:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngjhv-0005Vs-Nn; Tue, 19 Apr 2022 08:59:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngjhv-0002AA-LM; Tue, 19 Apr 2022 08:59:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngjhv-0003pn-7x; Tue, 19 Apr 2022 08:59:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngjhv-0007Xw-7W; Tue, 19 Apr 2022 08:59:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0g6rMVsuz5S1qZbmL08l1XOpRHEFMTyPqwdV6aI2Rmc=; b=Iz1ZAtY0nJ9I0eSLL3hdSnED2r
	bWJknPeJ3tjRA0qEwIGa1uwd7KFfmGTjmA1bow+Trin2QcIFDzdr5BV3U4/+im6bn2h/CVFFPJLjm
	QFQ7xjOq/ZLWY2GF9oosKtFVaJC7vPuY9Ue1MLMdJLDw/xWrzFrHvxdmsokcCtzEspSY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169534-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169534: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 08:59:35 +0000

flight 169534 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169534/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  501 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 08:59:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 08:59:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307876.523225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjhr-0005F0-Vp; Tue, 19 Apr 2022 08:59:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307876.523225; Tue, 19 Apr 2022 08:59:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjhr-0005Et-S8; Tue, 19 Apr 2022 08:59:31 +0000
Received: by outflank-mailman (input) for mailman id 307876;
 Tue, 19 Apr 2022 08:59:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngjhq-0005En-2p
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 08:59:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 04eea3b6-bfbf-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 10:59:28 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-M5ir4RM_MKyb8PalXaBHSQ-1; Tue, 19 Apr 2022 10:59:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB7001.eurprd04.prod.outlook.com (2603:10a6:10:11f::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 08:59:16 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 08:59:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04eea3b6-bfbf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650358768;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=48XwLC/W+Kxl27AAaNKf45XWcc22vF10YUV+IQVqgko=;
	b=GECtrDynlsazhh0zGEiAyY4Pmq0x5RfcOLAyFBq0eGMl8orLLfdOkrdLWrCMZTxSqL9rOl
	Lyy0kP9g92DN61DpraxNYTUXVCUWcTFWZ9vtk7qd1dZqOG3okYS6g+yHadctM40xwHUa48
	D7mW6FqoaHL2B3zIo+PRHmzpOskWczY=
X-MC-Unique: M5ir4RM_MKyb8PalXaBHSQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Iphg67w0/3CQFbun3gUfRxGjTX6iooNEBF9STPx9DCpJTQm1o2G9jE2AfSuQDG4D3Es/1+jqRyCg9PdR7uRYYnEvhQmwCltvPNWNKxdC4YBh9MDYwK5qaYfyLM+TLFT11SeOmPSoTO3vlriQv0hnrmgjApuixXTJ3Tynf3BwIBCiFcyq3C4YgDxsCsgUGNejQB6brltMs8hvFL4fUo9klkBGPmrhg+EcHdK9ZzfnqHvLJY4q919/+zmTZqvqpe/oXAZig7PqGdTaVS5N8JgH8s31aS4Qgs7Ce60X4hiawkW2CpiZA82jdOtRKbVNEHj/BRlGdA0xsWaSDhjDM0BpCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=48XwLC/W+Kxl27AAaNKf45XWcc22vF10YUV+IQVqgko=;
 b=kSQoemizx6QL2ARWpdXlhGu7y9329KtK+rX1bFrnFZ3LV1n9bqDsMslOIJmSv5jjgksoE9fpTY3Sm2y/uilSqmUhlImkII/IkrJW7upKPYBBjzZ2kqw9vsL6iFHhsRe/0SZXG2WRQRA/rmQutbKFGzvwhYeB242iwKEc+4j8Yzl0o1+xP317wXbUIWvwHit4EyhBZb9ZZhXXvk+Kcu4SJpOXBQ+9+n8IIoNg43qrQOnJKC0FmWuv6bRZuezEzxFC2nKMY4Fhz7EwEqT2XvJT6XPokavcgjqKl+KjNaPDLIybP/1lamKUuYBFORlTctp0dZmN0QSWUMvMW7+eIHn9qA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <328723bb-1e24-7d3a-8fe0-ef433a96b360@suse.com>
Date: Tue, 19 Apr 2022 10:59:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 1/6] xen/arm: do not free reserved memory into heap
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: wei.chen@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <20220418122251.3583049-2-Penny.Zheng@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418122251.3583049-2-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0182.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 63404839-6eb0-453a-7058-08da21e2e21f
X-MS-TrafficTypeDiagnostic: DB8PR04MB7001:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB7001DC0E15137D7CC11B652AB3F29@DB8PR04MB7001.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	crKm6mkWdwpCC8TSkko0TqbC6rkmg31a/nHiqvsuRXXQWTfK45Di6OpGYH9w6uMYC89kVYjILRNa8kBdsFpCZ3/EL+YVDoJH4RmmbrkV+qc1q1E2UD86AKk+IGcH7xo8K8Wdn6/LlWqUnE/E+vOFnmgGVO4PcRzWF7XpuPRFpm9ZTvrBDcXKRe3CBirIvgbtGJ13vc5bBxHryLGb97M43WtTB+N1CGliCjs8xRUBR7z9gdbJrXnqQGtVL0oZxdXWBbLmlobHcNoePQ+jmZHZTXlEqbcVPMzo5kM9/jZxIoitI6a5PK3I/dDTjBjQYGRS9sD4ip9qVU8Yl2+eu7hFA7fnJaT7qf2RG5khgybmQIbFo4NEFCHHI2LdFM0BBVORuQBR0oc3sAsq4dUoXaI82j8cMNJYPtloI8F/AHfwX5YyMckkdpElfQwd/1npb6OlOrilJNhr8DB3pMNl96x68dS62uGYc263bvoN0BxPEgkgQYQmjG6MDzSwAd4le5tgeZJNenbF2/Q/6PSQHrTV0KtI78AE9Lr8COVXt8gUhUKXOONXshnd0LBI16oXRbC4+oDSNrKJzmQdgsDbAkE9EHlsW6rJdHuoE5Lqp+CzdbMdArz6coEnsKMX4o0bUX8Hczr+SfnES/81TzrS8b1py9M3GSM3djCSnFtGmOZBNMUh98h3TaDZA8xa8F6BRfvCrnbpouCYEJqab3uFar+ZIGuwbUFKBCUTVnbiWWJdEyECZjcChTXVuFvGu6g3Uq93
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66946007)(36756003)(316002)(38100700002)(31686004)(66556008)(4326008)(8676002)(6916009)(54906003)(6506007)(2616005)(86362001)(508600001)(186003)(6486002)(6512007)(26005)(8936002)(53546011)(5660300002)(31696002)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aUcwNHJrdjFKNHRwN0JmSHlSbEU1MnVYTllBeHhvTTg5MEpCUElGSEhRZVAz?=
 =?utf-8?B?QnRxaVFDb1ZxTFRaRmV4Z1RCZkpPWlhhY1dFU0FjbzIwTEZNYUNSRm4yR0VY?=
 =?utf-8?B?Z3lLeWQ4SVpPZi9vR2VmbTJ6bTM2ZEdwbDhJRk4rQzRWNVRHRGtINjFvazYz?=
 =?utf-8?B?MUdqbFg0U3YrTEZpY242R2taVnlleHFCUHMxU3VCZDFhdkxRNXgvdFRtNlRy?=
 =?utf-8?B?bE9UK0tQeCswVFJvUmU3QUpnQ0tPdlB4MVF6VS9yQzBUMDZTb1kya09zZUJE?=
 =?utf-8?B?UXJoVUxmTVBlYzl4NFc2TUR6MzRVVjYvdUxxMWV4L2F4dDYybU1PNDJZcjZ6?=
 =?utf-8?B?VWhkVHZ4TlFoYWVOWFFRc0VwYWFxSld1OFBiSGtjU0o0QWduRGpwMEEvbFkv?=
 =?utf-8?B?cGhJWUVtWnZEQVc5b0NoVEhaWUg4aHd3ZUc0MDdEbDkreHB6Tm1Rc0grd3VM?=
 =?utf-8?B?Q3d0S3NrUW92MFdhdDJNQ2hUVzIwQmtka3oyWnk1Rkx3clNjWUVtUU5ZUEZC?=
 =?utf-8?B?enlDMFA2Wi9HUGZxSzM1WUo3eTJPV2ZBM3J0Yks5YU5JWVlwSUhtQkdzM3Zx?=
 =?utf-8?B?NUFJN3I4QTJzNE10bENkN21GUFRCRnVUcFhVb3prcXNzb3JUR0RsT0xUQ3ZQ?=
 =?utf-8?B?ZHcxTVN6REpzcWFVbVcvcG00SFpQWENFdEVpdkwwUWU5S1htY1h2RmlBNC8z?=
 =?utf-8?B?K3VDQ1dFRGd1ZHRXWk1MSDV0KzVUNitTMkUwU2doQUM0TDUrSTl1aHZkZ09D?=
 =?utf-8?B?OHhyOTQ1YjRrWlRVL1MwbkdRS2drdWkwTm54UEZJMnNMZWhUcGU0dGRnTFhj?=
 =?utf-8?B?YzJrQ3ROMUFKWnRLYkh0M0hNemFHa1ZRRklqQmxMSlA3dC9Bb2RaUFVpUnpR?=
 =?utf-8?B?VVlLNHM0Q3AwWTBoMkRHUDVIanprSHBMNzNrVFdkcUl3RUNxeDAzZGtzYk9R?=
 =?utf-8?B?TWprblFLM0syZlNVZXk0a0NBaTF4Z0pWQnNScmZodHIrbktUWGl1VGQvZ3or?=
 =?utf-8?B?S1NNbmRLMVFEeWh5NHg0TC90SnpncTRvbkNRTFIzU05Ha0JldG1NYmNTaG9h?=
 =?utf-8?B?cjJRb1c1SUI4cXJ6dlhzZWJqWjBpRGI5cllBY0gwSGh5Q2xENWJYelR0R3BX?=
 =?utf-8?B?MmdydlJzSk5nUElaN0o3US9SQU90dlMyOG92eUx5WGh4em96ZU9aUlZsMUUr?=
 =?utf-8?B?SzNqeFUvdWVNK0U4YVNjUlI1VWpEblZrRktTT2p0ajFaMzRDMGlEdFpTUXZH?=
 =?utf-8?B?VnkrVy9hV0c3R0Z4K2tnSVFOZzB2cFhZVVQ2c1pPOU1pWm9XWWJDZGZ0OWND?=
 =?utf-8?B?ZGZJQm14bmdRR2ZPSU9PTTFONXB0VlNnRzhpRGcwbk1WUGF5T2hiMVFiWlBs?=
 =?utf-8?B?d2FUTEtrWisvUWdzbDNxTnFhdHVDYlRsOHMxK3ErTjdIVk5hRXZqQ2JEWGZP?=
 =?utf-8?B?ZGZsRHN5VGFPVy93OXRQMkxCallUZTh6VUx2cUNnNW9CK0c1ZnlEZXN4S1Bh?=
 =?utf-8?B?VjZ3aW01bUtUSHJCZ0x1UUZNV1l3QmVZODFoYkpjN1ZJZ2hnQnE4VjVZOWxY?=
 =?utf-8?B?S1J4b2xDRDhiU2lreXBuZ2kxZlpROEVZMU9yR2lUWTM4QUJvbUs5Y3VyNFV6?=
 =?utf-8?B?K0JweDVjUUJHbWFlajZNWmc2VjZrY2NvWEdhRFc3VmN0eHdSNmdWYWpOL0NH?=
 =?utf-8?B?bm1LOXpPSGk5UG5SVFQrWkNhOTlvaUJVcUk4SzJJZzBTbDBkQmpUN2lrTFVq?=
 =?utf-8?B?N2V0OGVrNWtwVC9zNkM2emcyR1BkcTlRSmxBV1NScUdJam5ka0UraENkVS93?=
 =?utf-8?B?VlU0WTBFZiswcmt6YS9QcWJ2ZUtVckR4L3JsNHEvQzRXdG5VcFVCMHZUWEx1?=
 =?utf-8?B?ZkdjNHc0NVV1S1VWWCt2UVNGT3c0VnFwV3laMU9NSS9vR2wzbDVZWkNWKzVx?=
 =?utf-8?B?RnV2RkN6R1F3NjdxblJ1YUlJdElzc3VPUTk3YS9mcUNvRTBTNE14eGJiUi9J?=
 =?utf-8?B?SzRyREhKV1EwSDZFY1dWVTdUdXJXdUZMOGN1d2ZmYkZ6ZmZuVUlOMW9NUkNt?=
 =?utf-8?B?VVNkeVpIUE5RM3kxNGlXOGt3OERES2RVWDUvcDdGWmdUQnBKRWxMSFhXTkVO?=
 =?utf-8?B?SHc1MFpUYnhGcXVPc3J5MFNPNkxlYVFkbjRUZnNRYVlwTXhSdVF2ako1VWVP?=
 =?utf-8?B?NTlWNmc3WXFzaFdqVkcrRWlCcXpkVXYrVEY3TDFhVHZ3RGZFUnlZQVpoM0d6?=
 =?utf-8?B?OHM2YTVXM1ZLLzVFZUt0RUo0eVJia3BZMXk0dXgyZjJkMjdTTHl2T0tGOEVX?=
 =?utf-8?B?elpDZXRTWlZwYkZVdU1HQjRMYkRTVm1LVzBxMkEyQnZZRytGOFV5QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63404839-6eb0-453a-7058-08da21e2e21f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 08:59:16.7945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tdXJgWkK1HfyudgGU9yiJbo5hPKS7kox0mfATfipuXEb4VnH6Pgmx/6ZXetfxrTNyZqBOpNjsmTa6M6K8sNaRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7001

On 18.04.2022 14:22, Penny Zheng wrote:
> Pages as guest RAM for static domain, shall be reserved to this domain only.

Is there "used" missing as the 2nd word of the sentence?

> So in case reserved pages being used for other purpose, users
> shall not free them back to heap, even when last ref gets dropped.
> 
> free_staticmem_pages will be called by free_domheap_pages in runtime
> for static domain freeing memory resource, so let's drop the __init
> flag.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
> v2 changes:
> - new commit
> ---
>  xen/common/page_alloc.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

With this diffstat the patch subject prefix is somewhat misleading;
I first thought I could skip this patch.

> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -2488,7 +2488,13 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
>              scrub = 1;
>          }
>  
> -        free_heap_pages(pg, order, scrub);
> +#ifdef CONFIG_STATIC_MEMORY
> +        if ( pg->count_info & PGC_reserved )
> +            /* Reserved page shall not go back to the heap. */
> +            free_staticmem_pages(pg, 1 << order, scrub);

1UL with, in particular, the function parameter by "unsigned long".

By calling free_staticmem_pages() at runtime, you make the previous race
free (because of init-time only) update of .count_info there racy. Making
a clone of that function just for this difference would likely be
excessive, so I'd suggest to change the code there to

        /* In case initializing page of static memory, mark it PGC_reserved. */
        if ( !(pg[i].count_info & PGC_reserved) )
            pg[i].count_info |= PGC_reserved;

> +        else
> +#endif
> +            free_heap_pages(pg, order, scrub);

Of course it would be nice to avoid the #ifdef-ary here. May I ask
that you introduce a stub free_staticmem_pages() for the
!CONFIG_STATIC_MEMORY case, such that the construct can become

        if ( !(pg->count_info & PGC_reserved) )
            free_heap_pages(pg, order, scrub);
        else
            /* Reserved page shall not go back to the heap. */
            free_staticmem_pages(pg, 1 << order, scrub);

Another question is whether the distinction should be made here in
the first place. Would it perhaps better belong in free_heap_pages()
itself, thus also covering other potential call sites? Of course
this depends on where, long term, reserved pages can / will be used.
For domains to be truly static, Xen's own allocations to manage the
domain may also want to come from the reserved set ...

> @@ -2636,7 +2642,7 @@ struct domain *get_pg_owner(domid_t domid)
>  
>  #ifdef CONFIG_STATIC_MEMORY
>  /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */
> -void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
> +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
>                                   bool need_scrub)

This line now wants its indentation adjusted.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:02:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:02:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307889.523247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjkx-0007L9-Sp; Tue, 19 Apr 2022 09:02:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307889.523247; Tue, 19 Apr 2022 09:02:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjkx-0007L2-OX; Tue, 19 Apr 2022 09:02:43 +0000
Received: by outflank-mailman (input) for mailman id 307889;
 Tue, 19 Apr 2022 09:02:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngjkx-0007Km-1V
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:02:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 785b93ce-bfbf-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:02:42 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-NEtZZWjNMOexFFhwAEJvmQ-1; Tue, 19 Apr 2022 11:02:37 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM5PR0402MB2930.eurprd04.prod.outlook.com (2603:10a6:203:9a::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:02:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 09:02:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 785b93ce-bfbf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650358962;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jt0RknuV99Mj9cCd8QTaNFDAERTxKaglg8gBpbdXbLg=;
	b=Wsqk0vAaVJhJLNQENwU/UC4IKgnUP+gAWdHg7ssG8aXru07rX34W4B9HDiv9QtnXITkoDB
	Nt2pYPNtolCg1ULs6Sbi6Ng/2tTkDrzxhjDG81z7le1EDD6f/GaYgZARDFrgWQJU2fNldG
	Ps9qDUX7xZkR1BHcHHz6qflY6GSFGCU=
X-MC-Unique: NEtZZWjNMOexFFhwAEJvmQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DFPKad2H9bmWgsH8IjxEhrStB47Ag8U4ouOL5ByWwBdcqyVxhI0/fwMC1f5QeY+KE8O70P6UqhZ1cRtVukjve+cl2Rnbz57g6xbzUDzSA3aJluE06VS+kRMMkWrl5CVnjkABQLp6blRcIpCTT1S9lTJFO/px7McO2XYipYQa+qick0ZJI/TxkFNs+1BfpYMXW8K1ziY3NJWR4QoQUo5+mbAnwnh29LKbS5zq3Gg5x0ARngoosFMIBRt4Bw2nrHnZ36UudZk7YNRptZyiUpdu8vqAmKJIV9hzWnUX0I9SKhu7tvQD3yf6qpDZfaBzZTIo0d9BjmDZ3JMM/qXnPISFHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jt0RknuV99Mj9cCd8QTaNFDAERTxKaglg8gBpbdXbLg=;
 b=nI2rHQF7Y8qCJPmbTJpTx2Y20M6saKwabmT3+Vf6LyiW3ld1wwKpBW9WGG7bQruw70J7fY53kkhHgEKW+NBMlY/GIuFWOa+1sVRxIYXO1IVqUOYNtllPh95jjNSLBedI3iNtAxtkilHRdIHsX5TRb16WgJgDfm0o4wq8fqjRMB0k/3Ii8/oUJ5Y7Sidh90ppMk7WA9HduE0nL9psNOBTRa5B+TCRijBS0YgfbHElMwTuqEL+ywY8kKYlOopGNJEuCWNZVgrtTd5Khj+/2G1YQzqa+a2Wn1nrnCspP5YSqngtK2W/w0r2FUqmVfTLG1LFvHzFneTUGsuQsMU0a1AHgQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cc74f91a-ce7b-205e-d3d7-35bbcb5c9504@suse.com>
Date: Tue, 19 Apr 2022 11:02:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 3/6] xen: add field "flags" to cover all internal
 CDF_XXX
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: wei.chen@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <20220418122251.3583049-4-Penny.Zheng@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418122251.3583049-4-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0273.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8610cac2-b5e5-4b5c-5dce-08da21e358c3
X-MS-TrafficTypeDiagnostic: AM5PR0402MB2930:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0402MB29304A40C010863B13EBDF57B3F29@AM5PR0402MB2930.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ij+bscQOza60biQuWMMcyqXVS3oiND61avM40BZo4Hu1b8aN/0DKUNc7VjoB8cL4MaJnaK7KE34AK1yIAXwQ1MIe8bmTTp9BAS/O8dYUflTBiFhkncajSr8dX6j1Msq480NRwI5oQryITBsPNmPc1IgNSLRiHoobu5LYoHmLjsC3+TJuT7gwAOQrJxHdTuqwLXUf5uTZ9FkcX5TYFtEf2xHsI+OjohGl9MMEbjk3oWg8EpuAWq7bymibbuzpnRS3OiDTJEJRahlR5YtyKG4AVlGzcJJBW5v6w9dro7+I3dYSPE/z+hfUk0ALy/yvXS1Gh55NgcG190ou7fHVR/AZMLe86hhgk6GhxAkl9CK2Kg88Px4usVKHvtaIGKlGtOWyyhq0mS53Ce2FawRZRtS0gYijeiQhny+wMKhAhOjRVygrteBlnNofce+2XZ/QhhDEuqTdGmBQpi8C8N3A1yOCgy4xrglWGZHort1kOqecCIc0rR6l20Ew1fRnmGxfQwIMgl09+3lNRREh3Emo3XXsbJV+tbhn2rG6MkS0zWrefRaGq545yYv1dJsqQ1japPa0BsAKL5gTw3V7xJ6tYQPQ9ga822NHAVE6/+wci07JFm33rL0dDiGNKoZblkAXCercLOTdYcNMeG114i7+13lPbDka9v/5Rqu4je/CrmruN0ElSbSCFssXvHpIvUAs1Sa8jt+NjKN4+E7pjHEsn++UWoI6TDoS6XfV5oVOg5XkOJxqzfb5V5+Qj/zMUOiYtifw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(7416002)(26005)(186003)(4744005)(66476007)(6916009)(31686004)(4326008)(66556008)(54906003)(86362001)(316002)(66946007)(8676002)(36756003)(2616005)(6512007)(5660300002)(38100700002)(508600001)(6486002)(8936002)(53546011)(2906002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZmJTNmZQMWdXcFlUSjlvSW5oTktjTUtIYmNzdDRIZ29rVksyekUxQ21zZ0xm?=
 =?utf-8?B?Q3NCWWt4S2ZONUw1Yk91MmdCS3dYYUd2VXJLWXBvWHVkdHhyeVUxbi93bVJl?=
 =?utf-8?B?QUh0SWJraXRTcmI4S09aZ0ZBVVFmNkxXVE55NE5jeTlMOFJ1ZmlIMXB0NVF2?=
 =?utf-8?B?ZE1kSGU1bWVhZitzSkxJa0h6dC84aUI5cktSZU1sZWpJVHNlRFFoZkllaEZY?=
 =?utf-8?B?eTlxMUw4RjVzWWNVUHFGOTJ3aUhLQ1pLSWxXTjhUaWhaMVV1czBmWmF5YlFi?=
 =?utf-8?B?bERkc0dyVE85M0g2V1pIZm5HVGpKVnBoa0JiY3gzZE5jRWFUSkR6aC8xT0o1?=
 =?utf-8?B?WTNhSXZBSlZYRDdNa2d5L1lsbGRucHZ4dWlxTUJkWEdkU2gyMUV4QkxNRUYv?=
 =?utf-8?B?c1Vxb2dKdnU1SzRMQlBlcDU0SXl0TFFVeTA2QWRWMmdvYXQ5WHlQNU85MjA3?=
 =?utf-8?B?eXFsVHE5dGhuV0tzWnNlN3dDZURpWmhtU09xQkIzOGt1azg5S0dKUkxSYTJm?=
 =?utf-8?B?S2N3b3ZOUjlWUWFiUVQ0ZWRQOG5yZmZ6YkQwMENqTXppcndhWGZwbHB4Y3Aw?=
 =?utf-8?B?d1ZNZHBuMmxONXE5Q25ubExyWVRPSW1abVdOZmhHQnk2ampBZWc4UjFqSkRG?=
 =?utf-8?B?ZWhnUXJUNG1MNTZnK3dPNmQyNkVlTDBpOWM4UHhRNG1NSnN5aHZUVE5SMFNM?=
 =?utf-8?B?dkhlNHNOL2VsMTdxeWEvOTNqT3Q1aVBQcmpQOGg5bDRBWWtRcTVkdytaaUh3?=
 =?utf-8?B?czdiUXdRNG5NNWVIM1Zlc1BSdVdDV1c3eUUrMHhPQytpbmp2bnFZeFM0am8v?=
 =?utf-8?B?SGtlYXZhWThmeWNGbXZ6Rkt6TzdHWHRzL0ZDTXg1UVFYSUQyNkIzdEF6d3o0?=
 =?utf-8?B?endTMGdDMm9WNlpWbzNDdnZLNEJpRi8rKzRDWUVaUzN6RDNqaGhmdVFUd1Uv?=
 =?utf-8?B?eUVVNmcwZDFDY01YbVNrWXZ4SFZhOGZxTU8rVlM1bE12dWtMRlpxQ2M1S3lG?=
 =?utf-8?B?LzdKMmt3bXQvVm00WmdtL0RJZEpHS08xTHVzNmwxNHB4RVM5dUxmMXEwaWJ4?=
 =?utf-8?B?OHFaQkhNakFYK2luQ215RndWMHN5L3J3WXVrd0gvN0toZnFZV1IraTZjS1ox?=
 =?utf-8?B?dkI5YnlGb0ZFY3gxc0NtMmRzUDZvdlJteXlNK0tvY3I0N2l0amI3TDBabmpM?=
 =?utf-8?B?QWovcFBtanQzaXR1YWJBSUU5Y2djaGViTG53NXl4SkxOMzdsaW9pcE5OdXN3?=
 =?utf-8?B?WlVjSDNuRXNrenZESml6c25xSVdvWENPUkNGanBtTzBzMWNqd2ZCLzhVNldv?=
 =?utf-8?B?YmY4ekxTSE95MTQvenFRQ01OKzRpdlZud0o3TVUvNGRRbCtab1FwM2xhUlBZ?=
 =?utf-8?B?bHZ1M2w1S0JqRGlJVzZudkI3bnExSEN0MnNVL21qMTcvYkVvOVBVRnhtWVBs?=
 =?utf-8?B?V2tPRXp0aGE2b0ZUNXU3QlF3NFI4czdhQ0hIN2RWeWY3KzRPbm9GejAxejN2?=
 =?utf-8?B?eG81b3hyUWV4WEF1SzRxS2Rna1lNbUVNajFxVjFleE8rSDE3YWI4R2s2ZHZP?=
 =?utf-8?B?OGhvQTlaUXRwTGRuN3R3ZFJhVTNKMHpiZDVPRy95M3FOWHR2ckdPOE8rdHlU?=
 =?utf-8?B?RU5vSGI5M2NhR1R0VnBtazkrRk01NDN5VFpJVlFWNVpCMU10VkY4bmV4Y09j?=
 =?utf-8?B?TGp3M1NqWkx5Qzg1ait2ck0weCsxbE1LdjNlcDFFUnJzMU1zOWRuSkhZa01s?=
 =?utf-8?B?UGlOVkZUTHB1UVVjRk9hdTRtZWQyRXdRamU1S1VoaGxpdXRicjVqcXdXbFBY?=
 =?utf-8?B?TTdMRHI5WVB6SngwVENGaEJBVmlOTzI3aEJmZiszZnJ2SHpKUW05QUFKMGNB?=
 =?utf-8?B?a1ZSZzNIbm5nRXJRS0FqWldpTitXRnpNcUdTRTlSaUJHVjV4a2V6MlFlRGdM?=
 =?utf-8?B?RXBHcFk0eUYxNWFWclNYZDNYdmg4WlN4Z0RjcHloZVB3NGdXWm0zS3BEUDhp?=
 =?utf-8?B?MmN4SjhFR3E1NmJaeC93U0V3MXhvNnVyNXVrNmhmTHVCSHdIS0Vva0k5bk12?=
 =?utf-8?B?a0dkWlBrR0JJYVBiMW1tVmwxQ1hjeVl5ZTlNRWdxbDE5dFhhVi9VRm1wT1BR?=
 =?utf-8?B?aDEwdGg1TTdtUi9nS2pHZUkyeDlvRUc3ZS92WUhYUUZhb2EvNjd6SWxoTU1r?=
 =?utf-8?B?ZUQraUdocFlVaTA4U1FsbnhmZ2x6WVpteSt6Vmg2MmpBV1doYXZzSU9MaDg3?=
 =?utf-8?B?QjlzeVNGM2dTNFlTbzlyNEo2MHRQNmVHV2htUHVKc2VGUzZjcUoyNy85b0tM?=
 =?utf-8?B?S2UvVmJOWWs2TjRCVUR4NWRlNEtRdkpZVmJnWU1icnIwNk0xZ05NQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8610cac2-b5e5-4b5c-5dce-08da21e358c3
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:02:35.9024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QXPnrnjynu93LbLFJFLEpLqeN+/tdcPRJroURoW1aX4TaInUCdxnwCihnvZSMuiy5HkPREmiRS15nv58SDa0sQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2930

On 18.04.2022 14:22, Penny Zheng wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -591,6 +591,9 @@ struct domain
>          struct ioreq_server     *server[MAX_NR_IOREQ_SERVERS];
>      } ioreq_server;
>  #endif
> +
> +    /* Holding CDF_* constant. Internal flags for domain creation. */
> +    uint32_t flags;

There's no need to use a fixed width type here; unsigned int will do.
See ./CODING_STYLE.

I'd also like to ask for the field to be given a more descriptive name.
Just "flags" can mean about anything. Maybe simply "cdf"?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:11:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:11:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307894.523258 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjsz-0000QT-Nk; Tue, 19 Apr 2022 09:11:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307894.523258; Tue, 19 Apr 2022 09:11:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjsz-0000QM-Jp; Tue, 19 Apr 2022 09:11:01 +0000
Received: by outflank-mailman (input) for mailman id 307894;
 Tue, 19 Apr 2022 09:11:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngjsy-0000QG-IO
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:11:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a094ec30-bfc0-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:10:59 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-nOQza2sDMu6QOvhZuPEjNw-1; Tue, 19 Apr 2022 11:10:57 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB5178.eurprd04.prod.outlook.com (2603:10a6:10:19::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:10:55 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 09:10:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a094ec30-bfc0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650359458;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FH75j/gPxIjG4KcoeKe+OwXwmNiI3S9NHVYhjyKE1ts=;
	b=R1t0wvK45aIJXXcdDOIXK036SwfdfSi6uvwCNc5Pgu1zaOb+Q9C/F3IWE///pLdxFd8QSk
	mBde4FQeBGPl6wE8CqUAFJuX/T+DPJdFLK1J1DcYdea9qnFZ1XfJ9HSpqCgSUItL3afwNW
	d7pkzFg7IBd2KI7mmyxrC2WxOrb0OCQ=
X-MC-Unique: nOQza2sDMu6QOvhZuPEjNw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KTnYG8DfVO3BAjvPwN0NF9xCbLUeeZSxnMAUIxGQ+fYw192sn0DrL/S8eW+KhvERFLeQkSHcnbErHqId0bzY5CUMWdXpWGfIwtqKdNFAyVz4FN1kwVekgFhiJVVd3pYym8hAU4oFp/QAhPQKjyIfrrwzMpEVz4qkyCy1CMManhSl4vQ/psHKpwtqYoqSbianPqPcX1qjrRqbSALba7Q42yQdI+B6mCRZMvepVFFqM4rh/ks7lSRAwXNBPjxhKt77Fa0AGtNPbsd/HSISnmqomZaTj/vO1FrRU2Xgzcvx4WJb1xRqZYDx+eXBv+m0m3oFGqRMSwJeXxt+uPwV1fKYRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FH75j/gPxIjG4KcoeKe+OwXwmNiI3S9NHVYhjyKE1ts=;
 b=kTbtXxewn4Medl9fssvYp0Ht5TYFwh6xjLEcY9bRjo/MiJYQAay/+EXFjWSYqhrx73kdOKVqeJgalD+pAZVhP1Q4RQsOhVF9WhVaQncbjJENy4XX31D/fOavnHbM7n6Mp81awQ6KpoypP6Q/uCSrW7c3WawuBXTOumyJQ94wumaXpG0m0oswdpi41PDlXJYj4XJzUePanq9Qewm4wzeH14XwIWR4sQXOgqR02AgdifVumC/DoppBnLqTwicZt+cKK8vxL6R2W8wV+BMD9GixbzK+gPR5PHLKgXItsVnQea3rE7NgfuYnU1LxKNqrPsMFgK4sxvMUE+4baIDsp5tpWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b76b3207-4eb7-5236-6812-d64cd4dad17f@suse.com>
Date: Tue, 19 Apr 2022 11:10:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 5/6] xen/arm: unpopulate memory when domain is static
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: wei.chen@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <20220418122251.3583049-6-Penny.Zheng@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418122251.3583049-6-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0082.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d536637f-fb5a-4c21-e7fa-08da21e48253
X-MS-TrafficTypeDiagnostic: DB7PR04MB5178:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB51789C7ED17A8B3C8071B9D4B3F29@DB7PR04MB5178.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XnGNAFOQU6tmrCl0hjxHZLPFjbnwtE7tuyA8yeeoSZbeqL2BSwuOa8avzvDwlQe87oqNBw39IKg2Wd3rbQwmAPscHvUCIfUKX5gflZSU8pMWaV0yW6/f/eZHxjxzwCH9bh6NM0UzgAdsSsahti2DG3hrCvSYnviWjLV2SVun5orgsDsB3xP1G2bhzeUA+qFHfDCJN9FJdeuWpzKlQ+5tgqPBzYT7yDqzcnEy7r3QkR8vKcXIIR9yb0wrspvvNyPb8eBz3PLVTgwmUoq2roX3fhHKjJT8zM4iBg7qKc/4HAUe0EBR3lg/CyUjTzmBP0jqvdMfrX/yXXJlBY+75LN/ua5JCiOEn0EYnHG2nVyNAbOlmoNSLKH6pPuU5oCfePPk+iBO2GuoSvy5lHMpxRLXEcAJNwqVh9fcJPWBpqbnX3I2ksiwahjGwtF/iy1UQYS4V8DNBw1bkuZheoEYgbDlyewNECGcx/W4wSKV1+DIBpTFtypcgEo/uFG0G7k34EqTolETYDUt70RlS5kqiqhNTLKBRKvy5fMTgsp8KSo1694PcuLoJjoWsnEZcdCk7BIC67BN+47u7aD33OuVhdOA4mvLZ5J79DLQK6dCBpPU1ah2WyYzUEaJB/RONR6oyNES7qODhtAJmNkbO2ursgaSTN2gFgjpYoyttx0sSXIsRPAaPt7iGttBlOivdEwigHyZXxNOlZ9zIydxlPeY2z8q9JVmHZE7/O2Xvi2SBFe4W+DkOnOfJ/aeYM7eCQozAMdA
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(4326008)(2616005)(8676002)(186003)(36756003)(5660300002)(53546011)(508600001)(26005)(66946007)(31696002)(66556008)(2906002)(6512007)(66476007)(6506007)(86362001)(31686004)(7416002)(54906003)(8936002)(6916009)(6486002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aUdoRXppcHlmSDk1MUEwMERkdnhPeExFem5MalpqMENsZ2JVYmZQdE1OTyts?=
 =?utf-8?B?WG1rU0JGN2tMam0rZzQ5SU53UVV6RzdkeUZ4OWh6eGkrTTJ3dVlvbjlkaGR3?=
 =?utf-8?B?RE9UNkRnYkVJM0o2QmtzUzl5ZW9XcW9WbVk4RTBuZUE0dldXYVpoL3g4THpx?=
 =?utf-8?B?QTVKMmFkcTArL0prRTV1V013eE9majJXUzdZcTJ2UUpWWVRjVndFVnJpc2hr?=
 =?utf-8?B?R29VdWUrN3Zpb1VVdWNzOThNNWxlK3AwV05rWGpXUElrS3BoSjBCNHpFQXVr?=
 =?utf-8?B?L2VzWlN1b0xhdmtYMmRtL1l1Z2pTMXJoNThSaEpQNWNZRlc5Z0pnTk1oK1Rh?=
 =?utf-8?B?dGJwV0lDNCtQckZKbzV2a3dHK1Q4MytVejJwUnZJcW9kSmtxMytzYjRzZm8w?=
 =?utf-8?B?RUdiS29PNVJHUzBSRmVESURTcUlxVHdWb2dnTlBhbGdlcytpV0tMQmE1U1lZ?=
 =?utf-8?B?ZWlwdmNJVjRwZ3IxVGc5VXdOVTVjRmRkL05NMkZWa3IrR2dJcFppL0JrcHk5?=
 =?utf-8?B?ODhlSVRiZ2pwRHZoMUcxWjZkdElzaTYwTm9QZ1NwUDhJY3RJV1A1cUttMFY0?=
 =?utf-8?B?ZG5CYkt0SW5sSU1ibGdadjg1cW5qMWFaeStGZEl1OStPVmhzWkFOdTJQaWt0?=
 =?utf-8?B?aXVRTFA3ZGhJaUJhZkprblBsbHA5bExKdXRYNmpCendnWngxMFRpZ3ZITkMy?=
 =?utf-8?B?WFY4Q1B0NDM3ZFBjWFpGSHEzL2Q1VnFQeS8rQi9hR1BKRnIxWXJKM1dCM1pG?=
 =?utf-8?B?ZmFFbVZaMnFHR2d1aStXU0l1UzNhWk01ZWpmN2N4RklYczVla01mY2I2alFv?=
 =?utf-8?B?VUI0YXhHdFRrMVo4VHJGam0zclNwZWUwZzNZY3l0d1JLWG5Na0k5MlFIK3pa?=
 =?utf-8?B?YXpLVFA4YzVBSGkvbEdoMnZrQ1lPWVh6RklkRDJsVk04S3VVMHFuZ1MycWt1?=
 =?utf-8?B?R3pvWmVLaDRqSE4rVlhpSXdrTlNqRUFJT0VCTE9jSmN3dEQ2NjZVaTdNSzRD?=
 =?utf-8?B?SkpxaG1JNVNCTFZkU1dzTVZrWkdJTGd1M1A0V3Rkd3hlLysveGlVczZ6V0tn?=
 =?utf-8?B?NU5WQkxRZjdQU3diVERqSm9aZUZsT3dhbkx4bElvZ245TEJKUWtqc29oK1g2?=
 =?utf-8?B?bzRLeUozMHo4aGMxUFNrRXJhZkRkenBwNFRGb3RuOHM5djVQSXdyNXJzYkpk?=
 =?utf-8?B?VktmZzRobDZOT080Wjh0VldWTFo1WFo4SVAwd0ZyZkswQjJDU3lvRnc0YlBx?=
 =?utf-8?B?aVhrQ1JLM1ZoYnNXWWtHOTNhck1GZ0RXL2hLQXlRTFQ4ZTlIM0RVdnlBRE5i?=
 =?utf-8?B?TVpKejJkdTBNY2lsVXBCMHZuWXNONzgyQ3czbXBnL0xueEVHNUFIUk9GY2dL?=
 =?utf-8?B?Wnh5RE92YVl3dGl6Q1ZSaDdLeUxCWHYxZjhhRmd4bUE4emJlcitpWUVvMlNk?=
 =?utf-8?B?NnlkNWo3STduWDZET2hDS1ZZQmdDKzB4TkpOTG9rMDNobEJKVXdRU3FtRFJX?=
 =?utf-8?B?K09tOG9CWXJYQllycnpPdk5LMXdFNWZ2aHRBRjJHR3VsZE1ob1E3NFk5SVRx?=
 =?utf-8?B?RTdpYlV4UG1waDRKUzZJQXNiSnhJb2F0VjNWRjFxNk5SeU1JYnJ6VE1VazNL?=
 =?utf-8?B?VEEyK2xzOFlNOGJkbDh5WTRBRDhyd0lRWFE1SlkrMnpDVGxFTjNvdFBVcGxp?=
 =?utf-8?B?dk1vQnFlZVJxbzQra1VVUVlLTkhhcWw2WERlYnBCdU5VMmUxbS9hNVJFQXgv?=
 =?utf-8?B?dmJFUFE3WXF5MFVXcjF6ZVFnbEhWeUlQQTYxaEhmRks4Smgvd1NpcWUzbU8r?=
 =?utf-8?B?Z1p5M2U3R0krZCtYSitPWkRsYkhRSXBISVAvNld4T3ZaZWdCR1FabEZzMVpv?=
 =?utf-8?B?dE1YVkZ5Vk45NDlmR0xMNS81RTBBVGVUSVhnbVJUc1ZvTlRlUjRqTDN2TVJ1?=
 =?utf-8?B?SmhQNmpOejFDdFZRN1NHQjZkeWY1cUVGT0RDK1NwMWl3eGxDRmZtYXRsNEZ6?=
 =?utf-8?B?by96Q3p6ak5Samg0aWdQYnBPdlhWamV1bGtCKzhMQVVMSU9zZDFjN2pDbVFy?=
 =?utf-8?B?ZkZoaURyMWZtcWN0Ry9KdjV1b1Z2blI5aDJCckFYTjdwTGNBcm4zcGRLUjhr?=
 =?utf-8?B?NUo5a1JOamJyWlZId01wa2RlbFV1ZFRqRmZSeFJkdC9VUjRSWmczQ2VWcjBI?=
 =?utf-8?B?M0ZYQVNHRVNhZ29ncEQ4MzNKbG1mcHpOejBaODdlbjh0MGdnZXFoem5EK2sv?=
 =?utf-8?B?VDJ1MFpJeUd2aVBHdVZZUjZYWGh6ZnlMbHRHYzM0VWx2RUwzbSsvM3VYK21q?=
 =?utf-8?B?bVdMNGpZTGJFNXRHcWFGNkNNTFlnS002YXh5RkZLWng5VkN5SEtuQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d536637f-fb5a-4c21-e7fa-08da21e48253
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:10:55.1329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Kjk/6eYertfOE/aWGVI72vkacbT1xn34ILKv1ItQtVKFxVwhRp3auc8w6RrLnDX7Iy7/VTlB4T+SILXgYPsgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5178

On 18.04.2022 14:22, Penny Zheng wrote:
> --- a/xen/arch/arm/include/asm/mm.h
> +++ b/xen/arch/arm/include/asm/mm.h
> @@ -358,6 +358,23 @@ void clear_and_clean_page(struct page_info *page);
>  
>  unsigned int arch_get_dma_bitsize(void);
>  
> +/*
> + * Put free pages on the resv page list after having taken them
> + * off the "normal" page list, when pages from static memory
> + */
> +#ifdef CONFIG_STATIC_MEMORY
> +#define arch_free_heap_page(d, pg) {                    \
> +    if ( (pg)->count_info & PGC_reserved )              \
> +    {                                                   \
> +        page_list_del(pg, page_to_list(d, pg));         \
> +        page_list_add_tail(pg, &(d)->resv_page_list);   \
> +        (d)->resv_pages++;                              \

There's no consumer of this counter, so I'd like to ask that it be
introduced once a consumer appears.

> +    }                                                   \
> +    else                                                \
> +        page_list_del(pg, page_to_list(d, pg));         \

Is there a particular reason to have this page_list_del() twice,
instead of just once ahead of the if()?

> +}

Also this entire construct want to be an expression, not a
(compound) statement. And it probably would better evaluate its
parameters just once.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:11:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:11:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307899.523269 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjtr-00019P-65; Tue, 19 Apr 2022 09:11:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307899.523269; Tue, 19 Apr 2022 09:11:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjtr-00019I-1w; Tue, 19 Apr 2022 09:11:55 +0000
Received: by outflank-mailman (input) for mailman id 307899;
 Tue, 19 Apr 2022 09:11:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dnw2=U5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngjtp-00015j-9J
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:11:53 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2061d.outbound.protection.outlook.com
 [2a01:111:f400:7d00::61d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf99813d-bfc0-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:11:51 +0200 (CEST)
Received: from AM6P195CA0059.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::36)
 by DB6PR0802MB2616.eurprd08.prod.outlook.com (2603:10a6:4:a1::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:11:49 +0000
Received: from AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:87:cafe::a0) by AM6P195CA0059.outlook.office365.com
 (2603:10a6:209:87::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.21 via Frontend
 Transport; Tue, 19 Apr 2022 09:11:48 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT016.mail.protection.outlook.com (10.152.16.142) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 09:11:48 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Tue, 19 Apr 2022 09:11:48 +0000
Received: from 07582ea60787.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A7F9C95A-CF8B-4D27-A4A1-E15DD0568E37.1; 
 Tue, 19 Apr 2022 09:11:42 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 07582ea60787.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Apr 2022 09:11:42 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by VI1PR08MB3183.eurprd08.prod.outlook.com (2603:10a6:803:47::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:11:40 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%7]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 09:11:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf99813d-bfc0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nP7B4g1CQ7Hls5tgmaddDBfVEV3wloXf8QdYLFc7WWM=;
 b=gUMDynTTaETf5g11Z8U45We86eT82L1/0iHvD1wlnKiXZLrmS2Ve8A0hRJ6V2AyNzhpgqycy8dVgJ0mDwMtjfjk6iq3FAMOkWRw4XAjQnd7c3fECMCRSex6tETYApWTFMHOdWLpEFAO+KdYabkFwPYQtrZZFXASPX7E8mlbgIFU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JVjvWmJ8E0Mvs9h2xuVmd3rsRrq9glks0NEGqELgNIsKkdjPn74/K61QW9dHSXGaUZVdJfErz9f1N8JCGK5Zb7d+GY6w2kZA5kEibLHZm4XkGy7pKWAQswFMMnmqzOcIKL817IQYrtmIARaxfKMoX1K9oYpyntpQ4tAYFw9Q7DVWlLmt31BM7QiRQFN5nFaR1BCva5fOWC6PWFEc+heyV29EwQkads/zq7kN3QGTsp65D3y9xPODbxXDl6UoF+M+KiHkUCaToRNexpUNQ+GD+fHR+7wpMKiA3WDZH66nwY7he/CI7wQK9MLpGkCQje5HLK9GyaCLMnwIC6t9G48Ipg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nP7B4g1CQ7Hls5tgmaddDBfVEV3wloXf8QdYLFc7WWM=;
 b=JDZPzFEan/xfMk6k94jp7qpjMemWyWNBCaxu1O/ivfZHyexBkdt8QJmzxqtVw2XeB0uTbo/N3LBe4WbO+S5ZMZEGuK0Y47/AG34WsNZQxFFZto+JNE1RFPyMVF0l1pl14AK+HD+aKrgdYGgbcGfq8DQKnMGStmmzbEwMEHJU8aJG6t2KTtiuy2Xxv+eWcq44fpDfDNpx5GoHfbJ+0KZ+FgKTL9tB51devaRWia3ELCMg9KRRAPezOuksWgd5Ag8lqxO5TH4DtVkRJ85o5YtmSgwuX5+bxSUEDuS1dWIxbNiAIlZpPWv4m9olwyndsE6VV0MfAM9mcbFSstKP7l9czA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nP7B4g1CQ7Hls5tgmaddDBfVEV3wloXf8QdYLFc7WWM=;
 b=gUMDynTTaETf5g11Z8U45We86eT82L1/0iHvD1wlnKiXZLrmS2Ve8A0hRJ6V2AyNzhpgqycy8dVgJ0mDwMtjfjk6iq3FAMOkWRw4XAjQnd7c3fECMCRSex6tETYApWTFMHOdWLpEFAO+KdYabkFwPYQtrZZFXASPX7E8mlbgIFU=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Chen <Wei.Chen@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH V2 0/6] populate/unpopulate memory when domain on static
Thread-Topic: [PATCH V2 0/6] populate/unpopulate memory when domain on static
Thread-Index: AQHYUx8fG8TKp+50a0uuNwFvLPqiqKz27bYAgAABRyA=
Date: Tue, 19 Apr 2022 09:11:40 +0000
Message-ID:
 <DU2PR08MB7325B0B941E74A6EB794798BF7F29@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <505f2900-4f0b-e3ca-93c3-705028c1e826@suse.com>
In-Reply-To: <505f2900-4f0b-e3ca-93c3-705028c1e826@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 0657D45F7A1AC44C949106950748AA3F.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: fdcc4472-e4c8-4f03-6a16-08da21e4a22f
x-ms-traffictypediagnostic:
	VI1PR08MB3183:EE_|AM5EUR03FT016:EE_|DB6PR0802MB2616:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0802MB26164EDCEF279D7B07D4F944F7F29@DB6PR0802MB2616.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Q4NRq4bjwnxpMxsO4xF+eYLoacPjVSPf9caCdYU5ZCXtYVjxHbaLoKg6Nt8c81iEokko36mWYMtl09d0Y3qXnC2UpUXXRrNYpLZTAlcE3/Ve1FwvijhIItXgPcy5pYQm+KrmELcp7S6HptZ+PBQzz7wZ2qOAkj1auVltADSWzvVFwnxF2+7h+oi9htguVq7fJraPpJwGhu3lrRDObNj2vRfntu8Qq/M+uO/jIe+EL1mxZb32ciWHl28fcNcSDNnAaxnHffcs7FEUVsON/XvIT23upQjrERLNPfG3R5Kf1tpH381RkdMM6SBncIGFy0HQl31gJcF5pu8n3sNWp/IX2F0WGujGDdutC/DyC7YqQzfirB7BfKycSbwV+niFvug8XaUgMz6JeK/xAlYNB+3dIM7dbYnopIwRv1zqW2+PLWNWGfUbKc+Je8ZGUAgAHbQrT+9pFlN7PHBaxgxXSHjyxNvRSlgF5jmZZXcP/W7zs+TPEvYrekbUKVldiHL+b2GbMlPf/YrsamTTsAfN80azxk0VSWx7aFXlazw2DMwA3OKSfOXy8g2phSpfp+0ZZKIMlzVQmgQP2i+mdppfSSkHLdwqJLz20GalmR2bAnsHKptHTHVZfYSEdFY6h3qDrDtYylN18ICCw+RnMPqHrKiPZgy9CtgJRW5YInMD8jl7iEi3dSiTa+rYkzKiNjJQyLZXUdoOf54LaEVbvafImOAIKA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(4326008)(316002)(122000001)(38070700005)(33656002)(8936002)(52536014)(55016003)(71200400001)(54906003)(6506007)(7696005)(186003)(6916009)(5660300002)(53546011)(26005)(508600001)(8676002)(66556008)(66946007)(66476007)(66446008)(64756008)(76116006)(86362001)(9686003)(83380400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3183
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c13cd8a7-7934-403d-f543-08da21e49d85
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	z8L28+nGM14OEsiCrPA0Oqg/jJCyVbuOt/nd8TFZmR7qSDsgEcrw9dv1CVUqdcmSyCoij4/PK4wSh0SpSCOjLGQw0uzvM6OLhDfaX+g2Z6xOsAfs+8vu7jv5dS7YBXAnnGYrZjjs8ZNU3qMQoYltSjCbLeokYLqz+KbtNQ9WAOAUg6K6yt0v0A7tvuAe0rJC/gW++KtTLKVnSWIOVG/vfLVjPS/Voa9yFnh5mCiicpnQkTKzB9/jHGz1h0kgA8Ol2RAtUwbTGmARef5fL/nv6ohFZtxFfmZUUvRmnBDco7tFg78ArgoBijs/GH/qkR4Mn4B96ktA8eUnQXgQ0lABQUGa/hp5767T7NARdFBF+PH0Wj7Kls3NQjIyhX2bD/gprTgkDzqWUm1SllQAcpxspdyJlNSzE7F0TjdCQWhJdLub/GThXjQC43/Dysa0BjLNw+p1nEp/U1KpAxtj6uGBeWlMDjVBGm4vAnWYxkZcJAKDzjhSYbNecxpkTnxfB967n1T85uXJocgYdkR9GA/8fUQmDt6Q0UbepULEtnNznO3dNAB1JwApmQoPQWJtImSB8R9xVcKaRO7+BpVWCldTcfOKCAZfJQV+mBpmuWZGph3INpeSN61VHDz++NWGL8WSh59FxE9a7NwW4NS+dp5sZd67y0MdHX3xGW4V0IAOY7fxsrVWnpw6tzLr4Pqqp3L7
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(55016003)(186003)(26005)(83380400001)(86362001)(5660300002)(70206006)(70586007)(336012)(356005)(6506007)(2906002)(9686003)(7696005)(47076005)(40460700003)(54906003)(53546011)(82310400005)(36860700001)(316002)(52536014)(8936002)(4326008)(8676002)(81166007)(6862004)(508600001)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:11:48.2997
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fdcc4472-e4c8-4f03-6a16-08da21e4a22f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2616

SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUdWVzZGF5LCBBcHJpbCAxOSwgMjAyMiA0
OjQ3IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IFdl
aSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgQW5kcmV3IENvb3Blcg0KPiA8YW5kcmV3LmNvb3Bl
cjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47
DQo+IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNz
dGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBXZWkNCj4gTGl1IDx3bEB4ZW4ub3JnPjsgQmVydHJhbmQg
TWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsNCj4gVm9sb2R5bXlyIEJhYmNodWsg
PFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPjsgeGVuLQ0KPiBkZXZlbEBsaXN0cy54ZW5wcm9q
ZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIFYyIDAvNl0gcG9wdWxhdGUvdW5wb3B1bGF0
ZSBtZW1vcnkgd2hlbiBkb21haW4gb24NCj4gc3RhdGljDQo+IA0KPiBPbiAxOC4wNC4yMDIyIDE0
OjIyLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBUb2RheSB3aGVuIGEgZG9tYWluIHVucG9wdWxh
dGVzIHRoZSBtZW1vcnkgb24gcnVudGltZSwgdGhleSB3aWxsDQo+ID4gYWx3YXlzIGhhbmQgdGhl
IG1lbW9yeSBvdmVyIHRvIHRoZSBoZWFwIGFsbG9jYXRvci4gQW5kIGl0IHdpbGwgYmUgYQ0KPiA+
IHByb2JsZW0gaWYgaXQgaXMgYSBzdGF0aWMgZG9tYWluLiBQYWdlcyBhcyBndWVzdCBSQU0gZm9y
IHN0YXRpYyBkb21haW4NCj4gPiBzaGFsbCBhbHdheXMgYmUgcmVzZXJ2ZWQgdG8gb25seSB0aGlz
IGRvbWFpbiBhbmQgbm90IGJlIHVzZWQgZm9yIGFueQ0KPiA+IG90aGVyIHB1cnBvc2VzLCBzbyB0
aGV5IHNoYWxsIG5ldmVyIGdvIGJhY2sgdG8gaGVhcCBhbGxvY2F0b3IuDQo+ID4NCj4gPiBUaGlz
IHBhdGNoIHNlcmllIGludGVuZHMgdG8gZml4IHRoaXMgaXNzdWUsIGJ5IGFkZGluZyBwYWdlcyBv
biB0aGUgbmV3DQo+ID4gbGlzdCByZXN2X3BhZ2VfbGlzdCBhZnRlciBoYXZpbmcgdGFrZW4gdGhl
bSBvZmYgdGhlICJub3JtYWwiIGxpc3QsDQo+ID4gd2hlbiB1bnBvcHVsYXRpbmcgbWVtb3J5LCBh
bmQgcmV0cmlldmluZyBwYWdlcyBmcm9tIHJlc3YgcGFnZQ0KPiA+IGxpc3QocmVzdl9wYWdlX2xp
c3QpIHdoZW4gcG9wdWxhdGluZyBtZW1vcnkuDQo+ID4NCj4gPiAtLS0NCj4gPiB2MiBjaGFuZ2Vz
Og0KPiA+IC0gbGV0ICJmbGFncyIgbGl2ZSBpbiB0aGUgc3RydWN0IGRvbWFpbi4gU28gb3RoZXIg
YXJjaCBjYW4gdGFrZQ0KPiA+IGFkdmFudGFnZSBvZiBpdCBpbiB0aGUgZnV0dXJlDQo+ID4gLSBj
aGFuZ2UgbmFtZSBmcm9tICJpc19kb21haW5fb25fc3RhdGljX2FsbG9jYXRpb24iIHRvDQo+ICJp
c19kb21haW5fc3RhdGljKCkiDQo+IA0KPiBJIGhhdmUgcmVzZXJ2YXRpb25zIGFnYWluc3QgdGhp
cyBuZXcgbmFtZTogVGhpcyBjb3VsZCBtZWFuIGZhciBtb3JlIGFzcGVjdHMgb2YNCj4gdGhlIGRv
bWFpbiBhcmUgc3RhdGljIHRoYW4ganVzdCBpdHMgbWVtb3J5IGFzc2lnbm1lbnQuIFdhcyB0aGlz
IGludGVuZGVkIChvcg0KPiBhdCBsZWFzdCBjb25zaWRlcmVkKT8NCj4gDQoNCk9rLiBKdWxpZW4g
Z2F2ZSBtZSB0d28gc3VnZ2VzdGlvbnMgYmFjayB0aGUgZGF5LCBtYXliZSB0aGUgb3RoZXIgImlz
X2RvbWFpbl91c2luZ19zdGF0aWNtZW0oKSINCmlzIGJldHRlciBhbmQgdG8gdGhlIHBvaW50LiBJ
J2xsIGNoYW5nZSBpdCBpbiB0aGUgbmV4dCBzZXJpZS4NCg0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:13:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:13:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307905.523280 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjvj-0001mv-HY; Tue, 19 Apr 2022 09:13:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307905.523280; Tue, 19 Apr 2022 09:13:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjvj-0001mo-Ei; Tue, 19 Apr 2022 09:13:51 +0000
Received: by outflank-mailman (input) for mailman id 307905;
 Tue, 19 Apr 2022 09:13:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VZjr=U5=arm.com=Jiamei.Xie@srs-se1.protection.inumbo.net>)
 id 1ngjvi-0001mi-UE
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:13:50 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20618.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::618])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 05f38f43-bfc1-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:13:49 +0200 (CEST)
Received: from AS9PR06CA0201.eurprd06.prod.outlook.com (2603:10a6:20b:45d::19)
 by AM0PR08MB3873.eurprd08.prod.outlook.com (2603:10a6:208:10c::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:13:47 +0000
Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45d:cafe::26) by AS9PR06CA0201.outlook.office365.com
 (2603:10a6:20b:45d::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Tue, 19 Apr 2022 09:13:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 09:13:46 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Tue, 19 Apr 2022 09:13:46 +0000
Received: from 671e97d1e186.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6BF9EF64-D2DA-4ABB-9310-DBC4F3014161.1; 
 Tue, 19 Apr 2022 09:13:37 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 671e97d1e186.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Apr 2022 09:13:37 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com (2603:10a6:803:3d::28)
 by DB6PR0802MB2245.eurprd08.prod.outlook.com (2603:10a6:4:84::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:13:32 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::f42e:ad87:44e:2f67]) by VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::f42e:ad87:44e:2f67%7]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 09:13:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05f38f43-bfc1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P9P+xp+IcnKE4O658EWQd+dMh+/cBd1SJHXG0Om9Rng=;
 b=1+KZK4UEm6xGpoylIctfI1Ikn3406mhjMWvyvCcpjY83ulace1YQkDhO+C2w9zuF0t1LjRVJL5q9liqB+YrVZkl78eMO3aRQWwCW5LXuz1wRI1QuMn+LxFKJytlx7eelWmKDZeZO5ygX/tUbD5WHS0S0ytOlV1+xPSLM3ZMIfK4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kbUxTDmFIe0x8POLehPbH6k2e2gsvnSsvAn2WBFnyWK85Fbu5c/DNoz7x0J4lUiUnEPiHLwMsRdUVHfrRLTiWvYp/LfeZgasc2+Z5wMRe2ziZQsdvPnuvufo6DiuxiZ0wXbZecLV9wfqMEIKDMBmGgp9UtSG+0TAN/ewK5tBAsc6fzRMsw03aUbiX442sBAFo5MNg3/QenktovPzCSyWZq1j+taDLWPXETyyqUWYtzrtdClN4TQN0oUZbiN24zlaQYtz7P5KUbWqySx+2ZoByIzzFvKRXFidf87rWIFoWYWBDzbaxU5dDSlzHcR/Pyjxj0D34bTBuNzmSYftQ+svcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P9P+xp+IcnKE4O658EWQd+dMh+/cBd1SJHXG0Om9Rng=;
 b=Pjh1Ld9hOp1gj14kPlW6hwY1nHsB926m5QnJX9hKeUt4npTyLK8oSOqY8LhEZ5vD5cXWYqs+MgP6XBEQo+S+GjcyEMVM+2JkQKjBql9RvgxzartUj39Nle2wtG7QAQgfFzvEzb6RbYWIBrj04zcNQU+9aS5Ix6IaXleMJrvp9RKrm+SgsV/efeuo1a8BL8ddZyiP81YhEq4SdOxj7+t9mcaCEBq7fIdCkB9eVY9aICuUk8hsy/1scaxFlt5GhAnjQAJjzsdrBTV8onZcHjtEyA18RHmUEB18aJPCdnE8A+KIexvd+vMMX/zV5yYhb2zTrbVibFqwLiSl6x0lwT2Vnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P9P+xp+IcnKE4O658EWQd+dMh+/cBd1SJHXG0Om9Rng=;
 b=1+KZK4UEm6xGpoylIctfI1Ikn3406mhjMWvyvCcpjY83ulace1YQkDhO+C2w9zuF0t1LjRVJL5q9liqB+YrVZkl78eMO3aRQWwCW5LXuz1wRI1QuMn+LxFKJytlx7eelWmKDZeZO5ygX/tUbD5WHS0S0ytOlV1+xPSLM3ZMIfK4=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Wei Chen <Wei.Chen@arm.com>, "--to=xen-devel@lists.xenproject.org"
	<--to=xen-devel@lists.xenproject.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: nd <nd@arm.com>, Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: RE: [PATCH v2 01/10] xen/arm: Print a 64-bit number in hex from early
 uart
Thread-Topic: [PATCH v2 01/10] xen/arm: Print a 64-bit number in hex from
 early uart
Thread-Index: AQHYUwQRz8pnnvd0IkKIsXaKM40+fqz28iGQ
Date: Tue, 19 Apr 2022 09:13:31 +0000
Message-ID:
 <VI1PR08MB3056693E070014DD4F7A885F92F29@VI1PR08MB3056.eurprd08.prod.outlook.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-2-wei.chen@arm.com>
In-Reply-To: <20220418090735.3940393-2-wei.chen@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 8A9593940DA0BB4CA83875AD015D3D4E.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 13823f55-6270-448b-9157-08da21e4e8c9
x-ms-traffictypediagnostic:
	DB6PR0802MB2245:EE_|VE1EUR03FT033:EE_|AM0PR08MB3873:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3873095491508844082F319592F29@AM0PR08MB3873.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ubrMRwEHlc8s7SaF8ZMkcyvZOEMXtvCKujZNKKLGgOtJOJAdtHiNGIwYpSF73p6LrNQu3vUVgKnr9tNVbyAWhdfRIxY27q02VLiU0IN1L42XFKQkGpWiF/KpQzZmjvX5Od2k3XZKAtAtoqBKbjMuH9o732uFTE2oblA+S9u+7DNDJW+ksBmHOFduHGe8AwOn48is8hoMy96hrRJrXfWr5VXtX+9XJggGA8jXKtwOPNpSWxW8ijXSlEBOlmCZJY3Z//hg7QYcQ1dpFTELdeCo4FFuNPaigxLnbK3W9OW+hGYr+wLYgSL/t0BpBsHRkCzHQUxmetUMzyC0KmHvkbuISyh+sNoZjZ0rFgUhsw/w4/5BTXGeEE1dKF9ldRf64b6FAZacoqiUwTv1rqhzPxuO0aPqPrqFL5A5s3oGcV6/WtmMdmf3X9Bqc8xSDiIejbGkkJp2B5EBoPl2nGcqmvAngvn40mXxOiTQvurZAM5uBxqaGnaLkYwUNr8WplHjtThbBFaSH8Scw5ec/ElSDHiSMkAsC122i3NI7YEKpgVKJv8SbQ4QyNbNeC5iyohLwiU+ZGvJ3kZiZe6uUHOB849IV6FNIa1EmYgDUTqbkngWvHAkSTzMZ56f7FXVhii6c84My9A/wghaslTui1wyih6fZm6Z2CbQI9j5aPFbNUPxRZN60gTU/dSHBttVjSj/otfjdVBbtnT3UAOCyQ/HHNwMSA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3056.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55016003)(33656002)(9686003)(7696005)(83380400001)(8936002)(52536014)(5660300002)(71200400001)(2906002)(53546011)(86362001)(122000001)(6506007)(38070700005)(316002)(508600001)(186003)(38100700002)(26005)(8676002)(110136005)(64756008)(66446008)(66476007)(76116006)(66946007)(66556008)(54906003)(4326008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2245
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e52551f7-1997-416e-927f-08da21e4e010
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gbklwiZuw8gXGXrb8yU0hnzfrWrlSZwuSnp79SonSD+gaR/c+p3shQdxwttTEuzyh1WapZW+qb1+iT4a6dBZVPEz9hNJtZZU5durZU4ZN7p18ZtSkrYs3O5EnnMiupcopTnb/eQAy7ZzYo/0PljUGmGD0ikvcGjZjhKpMPkXyWjQvgDzEgbnpIhxfxI4Zd/J14E2+e3PgW1nKJdR62vCNJm3FhPPglvkxOGo69Y61VRruQBzP+Ep2JeY+e7BnZtJ5S3xgoROUuXmzAY8w+3f38mJ0HGSS5eVKMsl6UjJvOgwPBu0ANREXOHwzeZT4lBd6LX1dJ2lOT39mSFXakMw7Z/MzTDE7qZTHarRes/rz1gVjxxF5MHthV4wPKUJwHYDnBCLVy8oCei/7B6Pn06bSiBSDxl3jhgWtTfUd2scoCelNz66IgLA5yHEkBrdjWVXqmS3hHR7HF5p+DTttp+F7QP09mt8r8yNpkpmdLONd/I6DsiACJHz0bAUtBHWbXOPsaxWNFBzzrvAzLyibKWCRZs3ZuUb6822uCrqD7Yg4aZ7R65XLREKTRdlSK1OwBQtkECdyRhROPjbBnCcCV1n4QhAdwR2dMI4wpfkQQBW1LA98tzS7dMgvcdx/U9tTqNHt7DHsGTID/Vg+klq0Ek0CQKJM1afL7HRRyHh9okQb9iaNSGc2U7SYBUVZjoUygUQ
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(81166007)(52536014)(83380400001)(26005)(47076005)(5660300002)(54906003)(6506007)(508600001)(36860700001)(2906002)(9686003)(7696005)(53546011)(107886003)(186003)(336012)(356005)(316002)(4326008)(8676002)(70586007)(70206006)(450100002)(33656002)(55016003)(86362001)(82310400005)(40460700003)(8936002)(110136005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:13:46.6568
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 13823f55-6270-448b-9157-08da21e4e8c9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3873

Hi Wei,

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Wei Chen
> Sent: 2022=1B$BG/=1B(B4=1B$B7n=1B(B18=1B$BF|=1B(B 17:07
> To: --to=3Dxen-devel@lists.xenproject.org; xen-devel@lists.xenproject.org
> Cc: nd <nd@arm.com>; Wei Chen <Wei.Chen@arm.com>; Stefano Stabellini
> <sstabellini@kernel.org>; Julien Grall <julien@xen.org>; Bertrand Marquis
> <Bertrand.Marquis@arm.com>; Volodymyr Babchuk
> <Volodymyr_Babchuk@epam.com>; Julien Grall <jgrall@amazon.com>
> Subject: [PATCH v2 01/10] xen/arm: Print a 64-bit number in hex from earl=
y
> uart
>=20
> Current putn function that is using for early print
> only can print low 32-bit of AArch64 register. This
> will lose some important messages while debugging
> with early console. For example:
> (XEN) Bringing up CPU5
> - CPU 0000000100000100 booting -
> Will be truncated to
> (XEN) Bringing up CPU5
> - CPU 00000100 booting -
>=20
> In this patch, we increased the print loops and shift
> bits to make putn print 64-bit number.
>=20
> Signed-off-by: Wei Chen <wei.chen@arm.com>
> Acked-by: Julien Grall <jgrall@amazon.com>
> ---
>  xen/arch/arm/arm64/head.S | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>=20
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index e62c48ec1c..2bb7906f69 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -866,17 +866,19 @@ puts:
>          ret
>  ENDPROC(puts)
>=20
> -/* Print a 32-bit number in hex.  Specific to the PL011 UART.
> +/*
> + * Print a 64-bit number in hex.
>   * x0: Number to print.
>   * x23: Early UART base address
> - * Clobbers x0-x3 */
> + * Clobbers x0-x3
> + */
>  putn:
>          adr   x1, hex
> -        mov   x3, #8
> +        mov   x3, #16
>  1:
>          early_uart_ready x23, 2
> -        and   x2, x0, #0xf0000000    /* Mask off the top nybble */
> -        lsr   x2, x2, #28
> +        and   x2, x0, #(0xf<<60)     /* Mask off the top nybble */
> +        lsr   x2, x2, #60
>          ldrb  w2, [x1, x2]           /* Convert to a char */
>          early_uart_transmit x23, w2
>          lsl   x0, x0, #4             /* Roll it through one nybble at a =
time */
> --
> 2.25.1
>=20

I have tested the whole patch series on Armv8A(config without NUMA) and X86=
(config with NUMA), both can enter Dom0 successfully and the X86 NUMA works=
 normally.

Tested-by: Jiamei Xie <jiamei.xie@arm.com>=20

Regards,
Jiamei Xie


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:15:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:15:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307909.523291 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjwp-0002M7-Tm; Tue, 19 Apr 2022 09:14:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307909.523291; Tue, 19 Apr 2022 09:14:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjwp-0002M0-QA; Tue, 19 Apr 2022 09:14:59 +0000
Received: by outflank-mailman (input) for mailman id 307909;
 Tue, 19 Apr 2022 09:14:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngjwo-0002Lk-7s
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:14:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2e7b727a-bfc1-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 11:14:57 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-2dumpEFVNkCEXD-E-xUnVw-1; Tue, 19 Apr 2022 11:14:53 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB9125.eurprd04.prod.outlook.com (2603:10a6:20b:448::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:14:52 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 09:14:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e7b727a-bfc1-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650359697;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0GkGb3tsZKp7cwVLodyek/nmMqvzXVknfmvXj7A655g=;
	b=I9f9RcRO86m9/cgQC4sXT9j3bZfsfKEfq6/LflWq2w/P62/uOaMNbbg6p2Ku2+/YL0RTuw
	hpceZ85D3zbPNnj+j6mFWwfbEYdNkdT7gg3ZUQLa5/PwwoqOrFVg4zcf3+0G68BWRQq6rs
	Bb+TUNy+zZhcNDkDdj7cTsv240i4Xgo=
X-MC-Unique: 2dumpEFVNkCEXD-E-xUnVw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZlEdzF+LIINjmbQq9xjEExf6mv15DxqxnRTMht6+onwslCljVhSJzedWEpUgNoORvEBEcLcMG0MYIzd83QbVdPmvoYdzPtFMIes3hOZzysn75bCiuL7RLEaDL5jGTWILETfnhREtp+290Pyu5xNl4BtoHz+/N2fGCJjzQYcyti4xUDjDGSFo8kkCba6huq7ZdNwhJzRSvba2nKEy+uCgPuO3rFcOtd1Q9XI4GC86YiiRGFwIviJR1rrTVVNY77Iqg6jdc2egXUggcO7micF2pRYCYKMXHb6vJc3LqVt/rf1GiqRifw4v6KpDBKwN2/muyodjBfBl7eQhuc3oibh5Ow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0GkGb3tsZKp7cwVLodyek/nmMqvzXVknfmvXj7A655g=;
 b=AY6AyTrFvfcwBaiN1C2Fqh5dV+N4vryccn/+uFnk3GuBogX2PkT1J4TWj6hBl9m7TMmj4QpDVHe4DPQal+WVXMao2FKbHi4dGpH9F0w6Bx2dhEQ4LP0kWd7GbW6l8Qnb+ZBgT5XfiOrBS2QzA2HiggOwYhgJh/ZkueYhPv4DMbC0sl2fCbPsICRjYy3LtGBs/FVZcsQw6P1eLetINkcR4wuwtoB6hUrbaPuP+Otqkga6dIU+y7uMFh8B3BE0kFjrWMPiUxDSLBSjuYZS465ZdEdS84bWCnUbDVU4/R0OTNz83vEY30fZf0tEa0qPjgxDytochG0OkEW2ipFPQbL4Ow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c204a98a-2988-b85e-20e7-a77e77e6f39a@suse.com>
Date: Tue, 19 Apr 2022 11:14:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 6/6] xen/arm: retrieve reserved pages on
 populate_physmap
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: wei.chen@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <20220418122251.3583049-7-Penny.Zheng@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418122251.3583049-7-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0065.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::42) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ebc6014-38ec-4fa7-accc-08da21e50fe8
X-MS-TrafficTypeDiagnostic: AS8PR04MB9125:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB91256FF38359B68FA790CA11B3F29@AS8PR04MB9125.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WeS5Gucn9Wcf/ThNXhcgr+snlZxyHV0zZ0XBnnnnr8LWm7hRBIfQSWcYFwxSSquiCFznVRlMx8xtkZiZjZiKvwt3AMn/V3mZ0/Z6DRRHTbWoemCnZtTp7o9eqa0wneEcw0+wIhnJWOwr4rbHtmANiMVDGcfJ0t57Q6U2O6DdQVMOstPhnRnytc5VY5ASi0ZZ7JmE0hYfc3bOfduIdaOuSEYGsiy5jalpBinGYvp65eUsme3Hqljw//Kbt6fYZJPihcose2MHD+DW5iIPzXjRug5ObqqeKFB5l+yTfWWgMxPH4k53l9o2FbSzo8x96m3n4Ij+M1wNHH2R2eCcP2yK3OEpFKtNXHIO7WHY247eKuRt6ZvcyrcpKslqnxB5lgUaGNBFpKuMguSIXP1+x1bp4Q7/SEfJA6ZkW7dfasRU3yMnRt3xelFY/7BFwkG6aqB5TSiJtdG5LK+hY8jrMlOwdkBsyY/5kv/5BgmGWb6iUqwclF9RbppWG4gYOecKDD+0lx1xPMm1PKRLSShCZP9t5Viu7ew4AGHW548NMmB0Y3nTahJHomiHmeuZDc/r5Ui8EOzTEBK22wuVJaUHHcxKApfxtHWnnqN5Hv9yMSoiqT25P3VrgSuCRpmAg3/FCpqRdFZTOy1q0q59wN/Zn62hxut2++2GmyHDjmp5XaJkcVabvSSizGxclRfR1FGx+VA1VqbbblIkYsg56lZ5vdq752r68pUAkC6HYvixDqoW1jw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66476007)(508600001)(5660300002)(53546011)(6506007)(6486002)(31696002)(86362001)(6512007)(26005)(2616005)(186003)(38100700002)(8676002)(66556008)(6916009)(4326008)(316002)(54906003)(36756003)(31686004)(66946007)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QXgyQnkvYXBVM0pvWVVtaUNxT2xhMlNrQmdGbWZRY0k4Z0tiZ2Q0OUdRWHF4?=
 =?utf-8?B?alB3dTZ2SU15bmVRRU92YVViY3BIMUJVWFNMWTRvamxvSWdRZFh5bmRmd0Jj?=
 =?utf-8?B?NWlaZ0RnbmtJZGZiT0prL1o1WWNwNWExL0JVQjR4bjV5VFZoMml4QmYxVGJQ?=
 =?utf-8?B?UjNuTWpyL2d6Q0gvSGRmS0hWQkZRS0pVS2hnVTNnVFhQbWVDdVZFdjVCcTZk?=
 =?utf-8?B?dGZteDRhNWM0ZTE3cUJHQU0zY2pHZEdsY20xTWNxNWNKNnhoYktoQ2NHalp4?=
 =?utf-8?B?TWRkMTdNcWN1OFJKeEsxaStzSStnS2htSHNiS1plQWd5VXBSY29abTE3bXZj?=
 =?utf-8?B?L01SNGE1N1hkRy85MEhScUd1N25aZ0pnTUVwbU1weWlzU3JLUzdZQ1JtYXZ3?=
 =?utf-8?B?ckZOeStXUWxqRGFPVDNzcy9jRU5ROGFLcHp4cForM2hLUFBBRWZ6b1Z2TXgy?=
 =?utf-8?B?eTd1M3BJY09ROElSRWVEdTlJSUJwY1BmQkVJUHRsNGkwdWxmT3EwRW9JVmtr?=
 =?utf-8?B?OHZwNExXcnZublBWc0pJMG9GckNCa1hkS0NsZ0dOR1hRWnBBVTV2Tk80RktL?=
 =?utf-8?B?bGxSb0RnZlhIUExtdHk1N2dUMTlRKzlRMUJ3bG01NkROVnA5cnp1Y1hMNTlF?=
 =?utf-8?B?c0pvZlZRR3VsQkxScEZvTklIem5YT2lTQmJ1MXljRnl6dHowOXJVYlNQbUlj?=
 =?utf-8?B?aHRuNXUxbWk1YTYxbENJSVE2N2FlSjl0TnZ5b0IzOGM1L2FLajNGa3VaTmhE?=
 =?utf-8?B?QjlBNGQxLzFRamdVZzFyRWVkZTJVWXZxRjAyMGVrZW5kak9tMzdBUlNIcE9O?=
 =?utf-8?B?SXJUS29tQStQUEhQUG4rSDB0bTI2Mi9ucU1BbzU4V0lxYjlHMzdDSmdpQTRX?=
 =?utf-8?B?cUpLMEx6eFVDOVFONXNTSUJyK2NVMUlNc3FRRlUyd2h4Wm1KdjNkelFLVkRP?=
 =?utf-8?B?VnpGc1BtU1JBN2hVUHBLRW5TbkMvNG1IT2s3MFJ2RFRwMXBDb0dobEZnUlVs?=
 =?utf-8?B?amNHUDRIT1Rvbm9vUHdwNWlZeThQNDB6RERGcU9XQUFCcElPbnh5cXdyY3pK?=
 =?utf-8?B?Z2J2L1VzeW5GcGZZcDV5WXMvZ2haUkJ2a2VEVUM2NGJJQjZVZDBpdEZTbkJV?=
 =?utf-8?B?WWlCWFJ2c09rdklKVkhzODJ2SDdtK2dWRUhWT256Ui9Cb01xUFc3Y3JDOXF2?=
 =?utf-8?B?TG9MblJtTGNPSWgzWk9KN2JNaVo5bHRwYmJEdzhaRkFMU1FoNlR0MXFWUzZZ?=
 =?utf-8?B?bk1QQ1IyYVVIQ0k0Z3lTa1h0ZHRlSU1XU1MwTlRTYnVtMEVwR1A2NG9SZHFu?=
 =?utf-8?B?cFBwcGJTRE53WlRXZnRnRGU3WWVRd3BLbEZqMldIN2drdkNmK3ZBcFZDUDBE?=
 =?utf-8?B?MXd3OWtxZXNKMGVBbmlZNDBKRCtVYmxKUEU0WHRjSnhteVMyU1ZxT2NUb2ZT?=
 =?utf-8?B?QUJwUDZNeTZKZmY2ZFZmRW96UFczMFdYbCt6dXBlTmdCeUpVS1hrdExNenln?=
 =?utf-8?B?NWU4dXJzbnlIZXZ0aldGRFcvZ0k5SnlHZTlUd3Bhbm4wMlJrVUxkTUtmVUZ2?=
 =?utf-8?B?RnJ6U2I5NUgwQ3hsNGRhajlqeE9IblptaS93RGNVOUpBQUorN05DTHZxZENq?=
 =?utf-8?B?NWRiOGM1Um0xYlRNVkRuMkJDdWFlcVRNSjBydGlFcUV2TkNEZHNNekFYOHZ4?=
 =?utf-8?B?T05GNG9WOW5NZGNySCtUamZISW10UU52WnZwQ2JGSjFSWDE5U29XQWZscWRW?=
 =?utf-8?B?ZG8yaW44bFRwN2hGYzlNZHg5UXZ6S2FIcDVPMDdiaWVxdVRXZENsb1Nyd1Fq?=
 =?utf-8?B?QzhZTTViME1GbUVqM1ladlBWNGt6VnBwOTBXUnkvcFNuQWFEK2djQU1pbVFQ?=
 =?utf-8?B?cWRndzRzYUZ5aWVSMlFYV3FOQlBpKzd4QlB1RmpIUjJBV0dzMkFmQzJqZUt4?=
 =?utf-8?B?UmpuRERZVkRDK1hWa3JsUWwycEZpQ3RpLzdNM2ZSb3RTVk1VaEVQeGNadlhR?=
 =?utf-8?B?dXdMOFBKTVJkdkI3S0ZBREFxYWdRczZnaU5BbTRSQyszc252MjRZYkZmY3RK?=
 =?utf-8?B?RDNmZFBZeUhqcDMveTNsRGFqVGJUSVU4NHg5ZHRXZ2hhMitYNGJZeSs3MDVa?=
 =?utf-8?B?UXpiMkFYOGhTQnlLV21rdUhGd3M5YVEybE44SmJneXdTdmtsa05UMkFDbEJs?=
 =?utf-8?B?TUtsSE1Ld1FrVzc1MDczYzR4ejRVb0R2R3N5TzM4UFdNcFFzbkswV1pqTTRR?=
 =?utf-8?B?RWlZRmR4NVJXZVByMkJ1S29MNnNMc09vWElha3cwNTNZTHVZaFYvZWNveCtk?=
 =?utf-8?B?aDYzTDI4eXo5QWdwdzFydkNRWDFYY0ZkRmZhQzBCOEpvNW8rM3dVQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebc6014-38ec-4fa7-accc-08da21e50fe8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:14:52.5586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X2JAjz6r6dybrvSFOqD3xVc8N95mAjvrWASzQasDEnV4i38xRukSCW0IIhRYH37xtFEM5wI9b8PmH4KWXiSEGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9125

On 18.04.2022 14:22, Penny Zheng wrote:
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -35,6 +35,10 @@
>  #include <asm/guest.h>
>  #endif
>  
> +#ifndef is_domain_static
> +#define is_domain_static(d) ((void)(d), false)
> +#endif

I think this might better live in a header. I wonder why you add it
though, considering ...

> @@ -245,6 +249,31 @@ static void populate_physmap(struct memop_args *a)
>  
>                  mfn = _mfn(gpfn);
>              }
> +#ifdef CONFIG_STATIC_MEMORY
> +            else if ( is_domain_static(d) )

... its use sits inside an #ifdef which ought to guarantee it's defined.
That said, even better would imo be if no new #ifdef-ary appeared here.

> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -2770,6 +2770,34 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
>  
>      return 0;
>  }
> +
> +/*
> + * Acquire a page from reserved page list(resv_page_list), when populating
> + * memory for static domain on runtime.
> + */
> +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags)
> +{
> +    struct page_info *page;
> +    mfn_t smfn;
> +
> +    /* Acquire a page from reserved page list(resv_page_list). */
> +    page = page_list_remove_head(&d->resv_page_list);
> +    if ( unlikely(!page) )
> +    {
> +        printk(XENLOG_ERR
> +               "%pd: failed to acquire a reserved page %"PRI_mfn".\n",
> +               d, mfn_x(page_to_mfn(page)));

"page" is NULL, so page_to_mfn(page) is meaningless.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:16:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:16:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307915.523301 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjyN-00032y-C0; Tue, 19 Apr 2022 09:16:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307915.523301; Tue, 19 Apr 2022 09:16:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngjyN-00032r-8u; Tue, 19 Apr 2022 09:16:35 +0000
Received: by outflank-mailman (input) for mailman id 307915;
 Tue, 19 Apr 2022 09:16:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngjyL-00032j-VC
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:16:33 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6778eca9-bfc1-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:16:33 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 62195210F4;
 Tue, 19 Apr 2022 09:16:32 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28E9B132E7;
 Tue, 19 Apr 2022 09:16:32 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Y8iOCPB9XmKaCgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 09:16:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6778eca9-bfc1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650359792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tpJbvqgQUJ8X2kcphBh+0uKSEVkbF9cJfYcLIzuVqyA=;
	b=hDul1sqy58qB9kficlyggAc8SgDIhrlLzjE3rX0oWjFD3BfL86cuE2+5KgFADUhxG6N5kE
	LtpS9EKc1f++W5n8u6/Sa40utnibS+JQp5R89n2G8EDE8Z31J1cTygmNq2sSepwFMjUHwS
	IxOdiDE5F1FUdQ0gCSSmLrM5OIgOydA=
Message-ID: <cc7e517a-b1e7-95f1-d230-a635f7d84ef5@suse.com>
Date: Tue, 19 Apr 2022 11:16:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] xen: gntalloc.c: Convert kmap() to kmap_local_page()
Content-Language: en-US
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
 outreachy@lists.linux.dev
Cc: boris.ostrovsky@oracle.com, sstabellini@kernel.org,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 ira.weiny@intel.com
References: <20220418061927.6833-1-eng.alaamohamedsoliman.am@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220418061927.6833-1-eng.alaamohamedsoliman.am@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------9vkSMHlYMu8moakU4AvthWPm"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------9vkSMHlYMu8moakU4AvthWPm
Content-Type: multipart/mixed; boundary="------------S5XLYnp6xrs0fDIWycnnF3TJ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
 outreachy@lists.linux.dev
Cc: boris.ostrovsky@oracle.com, sstabellini@kernel.org,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 ira.weiny@intel.com
Message-ID: <cc7e517a-b1e7-95f1-d230-a635f7d84ef5@suse.com>
Subject: Re: [PATCH] xen: gntalloc.c: Convert kmap() to kmap_local_page()
References: <20220418061927.6833-1-eng.alaamohamedsoliman.am@gmail.com>
In-Reply-To: <20220418061927.6833-1-eng.alaamohamedsoliman.am@gmail.com>

--------------S5XLYnp6xrs0fDIWycnnF3TJ
Content-Type: multipart/mixed; boundary="------------QEG3IN2lZzp121HpNvmVs0ze"

--------------QEG3IN2lZzp121HpNvmVs0ze
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTguMDQuMjIgMDg6MTksIEFsYWEgTW9oYW1lZCB3cm90ZToNCj4gVGhlIHVzZSBvZiBr
bWFwKCkgaXMgYmVpbmcgZGVwcmVjYXRlZCBpbiBmYXZvciBvZiBrbWFwX2xvY2FsX3BhZ2Uo
KQ0KPiB3aGVyZSBpdCBpcyBmZWFzaWJsZS4NCj4gDQo+IFdpdGgga21hcF9sb2NhbF9wYWdl
KCksIHRoZSBtYXBwaW5nIGlzIHBlciB0aHJlYWQsIENQVSBsb2NhbCBhbmQgbm90DQo+IGds
b2JhbGx5IHZpc2libGUuIFRoZXJlZm9yZSBfX2RlbF9ncmVmKCkgaXMgYSBmdW5jdGlvbg0K
PiB3aGVyZSB0aGUgdXNlIG9mIGttYXBfbG9jYWxfcGFnZSgpIGluIHBsYWNlIG9mIGttYXAo
KSBpcyBjb3JyZWN0bHkNCj4gc3VpdGVkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQWxhYSBN
b2hhbWVkIDxlbmcuYWxhYW1vaGFtZWRzb2xpbWFuLmFtQGdtYWlsLmNvbT4NCg0KUmV2aWV3
ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo=

--------------QEG3IN2lZzp121HpNvmVs0ze
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------QEG3IN2lZzp121HpNvmVs0ze--

--------------S5XLYnp6xrs0fDIWycnnF3TJ--

--------------9vkSMHlYMu8moakU4AvthWPm
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJefe8FAwAAAAAACgkQsN6d1ii/Ey8S
wgf/YdYBK3TJNqEFYhYzob4kXXTI/Q7kjJSzXiu5Nag8Sl8TC9nVthn7m35+2s7/l5oNDp6j4sn4
HhEdNvmsWptIfy95yxQdCbzoTkD2Vz6NXFi1lbTJvmpUp6y2yTtoE4mOhCsqNCcdCKKw0+gWbqbD
cH7sRAiGNlj4RCUR4TaTqbhJIvZUgzTfLwVbOVZDiK9x76Ua58DAh44qm4G+A7s53woIljMcD7Y/
vDYurOJJeQ+TPro4K7ass7aIQQfisdg7mMqnUsdtZ0fljdqss0ufJSK4Wyx7pdZj40YDyJL0Da7+
Ft/Kd38C4ddUurRyQqNJ3hkk8WztoR6OGAVD66Kgcg==
=vt7X
-----END PGP SIGNATURE-----

--------------9vkSMHlYMu8moakU4AvthWPm--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:18:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:18:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307921.523313 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk0Z-0003eE-MH; Tue, 19 Apr 2022 09:18:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307921.523313; Tue, 19 Apr 2022 09:18:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk0Z-0003e7-JB; Tue, 19 Apr 2022 09:18:51 +0000
Received: by outflank-mailman (input) for mailman id 307921;
 Tue, 19 Apr 2022 09:18:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngk0X-0003e1-KZ
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:18:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b86b425b-bfc1-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:18:48 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-PlKU9Jg_Mf6-bsKTenwDOg-1; Tue, 19 Apr 2022 11:18:44 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5311.eurprd04.prod.outlook.com (2603:10a6:803:60::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:18:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 09:18:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b86b425b-bfc1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650359928;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9/eKHA1VPKRbfAN23U1roDzl2rc0BI/5cpXLR7sEMkQ=;
	b=WHniqNuN09SzB9Gd1aztpiba0uT54nxOLyFVJ6R+A5AB6kcSnwq3UV6rxDTE8QxDnaCbW0
	mjYdKOlQXYX6pewYcBPkqTMZyIDbjVf5tibzJTFz5NXDf+rypxr0Fwh6YIqr52/jqAaAkt
	yQ80YGMASH1oTj3L2C/5ngpEo+knSCY=
X-MC-Unique: PlKU9Jg_Mf6-bsKTenwDOg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bMX4NSzUrTv4AS9k0NUga5wrzsI7iCJRWlw9EsHv+7SDIBCwd2FqwpeQy/OwczFrCMa9NHvch1nPkwA1vztF47a4+ceNvF4JLiPLlsmHPPRRdIoINcPPRqr9In5NXx8YNr4NHuBTj6KCEQ7nsIi5EpXWQ5R4nHMYlxRGj0mm49Tx8q6tt1qDbX9Lq6365RNNZiYSxowr/8XeZd0sgALhqNMk+fUPIwqzO7MhSxCXdsyMKumXi71oZTuCF6CmpxqO3HlPI2P/3jdSehY0FbpNjlI8oS4q6Mj21MHmM5HxT+9MJ0NiubfLqJV8tWgmZpY5A065xJsHRTXlp38zIb9xLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9/eKHA1VPKRbfAN23U1roDzl2rc0BI/5cpXLR7sEMkQ=;
 b=SX2wGUIyTs0nTcQTTSLW9De3zSZfjgUPlXuD2XF+fMTm0AtjtA3FC3McFyjPIQ79A3YtHv0eyJjyXjajVQ35oPtX/kclT5We2fp8l7OpYbsI90Wamd/vtdMi5XBtd7u5LzDpBZj/9IENMf79epGMDKtH4XxgKDhBrXh5tRneWRvkyWs0O1vtKbEZeHGglBdi4bThPd4sGTGgDjK2d8WI2Gvuf0d+gfEIRUjmg1lmpQnoawAIKmmCAfJ4CMHEQwUdO5+dO1YVGrcfLEyECETxeazywlhyrLJ+E+I0u+G7gllTgYopn+0Oj4V5GRfSjGHrF3ehxjtq4BaM+nGdTuKbkg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9ab21bd5-7208-0000-5274-3c970ec6768e@suse.com>
Date: Tue, 19 Apr 2022 11:18:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 06/10] xen: introduce an arch helper for default dma
 zone status
Content-Language: en-US
To: Wei Chen <wei.chen@arm.com>
Cc: nd@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-7-wei.chen@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418090735.3940393-7-wei.chen@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0125.eurprd04.prod.outlook.com
 (2603:10a6:20b:531::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 39bd9465-afe2-44a1-91fe-08da21e5985b
X-MS-TrafficTypeDiagnostic: VI1PR04MB5311:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5311A377E67C635C441B8897B3F29@VI1PR04MB5311.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gSFaDlijHFktjLUzdUxPsAj1IxYHTsFiEoKUjAkPmxu16BS2wEp5XPW0MSQjf2PCrk6IatnKoHrwjblKAQqWEfLXsRas6bZ6H7bN+mJCZOmBeF2s2RhVuWJLbV+Eq61DpHo6G4C4zlJTQQ4AI4TEagSTUnQd3stueJukU0/VezdD/b+a/3m4Sv8QNZUzEhFhE+NcbMkiZbBWN9H/FnnYOR7cZeeKJyWFLwasH+oBrheDnU5Jqp0W4Oex1XXJEp/S7c1iBjnl/+LhVrJg7TBh/OIHj+cG10R0/lMlioYESTcOIGsV2JTvXczHFXQGtkJsfnQz40jbQ2yqjhTCMeCP5Xpl8cN0aKffZdlP9KnNp1yA8d6DV2MSB5O/VKrQyQ7hsMBY0y3sXOdzlowsdWkndQJUSWxCj9KlnpeffipOEmN6V5coGoHK3QL5Do/N6ntJLTU9mtOsGX/wbHMVVKgQFJc5JGZHTALDQoeKImBsjFmUzWY4esqTqM49wHt5Ww4XmngwOTRyABhwk1v61389M/fzYrDW0lSMj4FvrpwgatvQXZmaDBDRLLei+dNzQzazNnvnZVMBGVCaCNxciPKbV/uRgR/yGoaae9mgF7t5JgtjxWy3IUWq4mKbkG9piKk9WWpDFeOLReEPQcGgYqGRLO4LCaxxH4iNHQ/3xUGons5QxnvuK1gTaAXWIax9C+EzslQfYzCVvdmKiGh07/tQTq+wMcHEas+6pU0WMI9Nygs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(4744005)(2616005)(6916009)(6506007)(53546011)(38100700002)(6512007)(26005)(186003)(316002)(83380400001)(86362001)(31696002)(36756003)(2906002)(66476007)(66946007)(31686004)(8676002)(4326008)(66556008)(508600001)(6486002)(7416002)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEJQWHkrK3ZaVXNFQjVQR2oxbi91a2xhSTBBV2lJVFYxTWlnNkdoOThzYXpE?=
 =?utf-8?B?YldMUkJBZHdZSEtpc3pmNHhVdndhVlNpbm9rUVQzN3FoODE4OWZ3dFVQQVd6?=
 =?utf-8?B?bmUvS01ybDhLV1pFdVJodDJiV3NUUThQSm1wdEFwWFhtZ2RDbVQ4UXRBblpi?=
 =?utf-8?B?Qno3U1JYcWtLZ3VoZHd6NmUzSisyQ0tyUkQ1VWdqRHI2TUFzanZXaDFNNlQ0?=
 =?utf-8?B?R2w4dlVyQ1ZxZjVWVFZ0UENPdnRqamt5OEdTY2I1Mlkvdml4VFVhd1JwTFJ0?=
 =?utf-8?B?K2FTd1JUMzdMUmMyVVRuenB6cFY3QnFjNFNnZmRtMjA0TjhURGJSVUg1VnlV?=
 =?utf-8?B?UWU2Rmw4YnJWcGxHN2xPbnVDdTA0K096MEZ6djhaeHRaNGxqYWpjVnZaNEZG?=
 =?utf-8?B?QTRUbm5Nbm9lQXlqczErZmJjVWJtcDVhMEY4bXdFSHROb21TcVMydFJsMmJD?=
 =?utf-8?B?bWlhRGlENUoxaW9sdzl2b1I4bjEzN0hkTVY2OHFBNmlmZEwrbzN2QWIrY2cv?=
 =?utf-8?B?RWJNeWhZcWRPS2J5V21rTHZqL0dad0xZNTkxL05GK2MxMFk3TWF1ZmNTYXlT?=
 =?utf-8?B?ZC9rYWR1V3hYMWJxbElJZ09aSnU3RVpqM0p4WmsxOXRkeWFRdm9pUEpjUCtk?=
 =?utf-8?B?NkliYlh5ZFlzZ0NhRnpHK2hpN3ZOakdvYnlpYXhqUWFNSjJ2QURIelZpUlAy?=
 =?utf-8?B?REdSeTJoRjdOSVRUWE05cUt3ZXVjbGVNSGc0TURjaW1zeDNUMi9zUTRyREtZ?=
 =?utf-8?B?NDc2OE5XOW1hczNGeDhnSEpQdEswRHJhSGtHOHdvNWl1RkpwZTA2dnhYdmZ4?=
 =?utf-8?B?OERWSStFZUpGQ1NYNE5nejd5KzYyVzBhNzYwY2daZE5hRWVzaXdxYXl5OUxF?=
 =?utf-8?B?YkFMQ3pudDZiMk1DeWxDNEVMNlJrcDFkRFBGYVVBMDFsSmdKemhtdENTbm1q?=
 =?utf-8?B?cURGMENnbTZGRU1jTXk5N2VLeGtBa1lpeGt5R3M5NVBUS1JmNktmbTVqZEZK?=
 =?utf-8?B?Y1lrb0RMSjVVYXU4VXozanFIOXFuTHhtVHk1VXdmWDZlbFBjbVZZYjRyVkRi?=
 =?utf-8?B?TEd2QVhveUV1WmV6UjY3MTdnWVI4YU1SODVVcjBhekhCemVKeWhZN0g1YjBr?=
 =?utf-8?B?aURKK1V0S0JTVFpwd1A2azNjTWJ3eFBOdFFFZFBwYjhJRnd1TUxodWFVbG40?=
 =?utf-8?B?SWlRb0hMSGRYS3UrSWtmaTdZaWhWYlBEQy94M0R4MjRFcGNOenhhOGxQaFZi?=
 =?utf-8?B?eldleFhHTVBPSTNURUFaWlNaaDlmMmFmUEJuN3hITy93S1g1cHRsY0xDRkdp?=
 =?utf-8?B?dEt4Mk1WeDVmVXRYSkx1UW1JRXl1VUlKdkd0NThtMnZSa1BqRWFOVGg2OW9h?=
 =?utf-8?B?UFVhLzd1K0pRQVYzbHpnY1dNb0VhaVZIdDl5Y3F0bnA3dy90bEptOVJOb1Za?=
 =?utf-8?B?WWUyS3I5anBTOEVWR1BEV0NUcmVLVk5TVktQQ2M2djliQXRVR1BXZUEvYmt3?=
 =?utf-8?B?Vnk0R01IckQvOW53VXlKaUtheFhXWTZ2QlNzLzBOdlRFem9aN3J0eUlWdmtm?=
 =?utf-8?B?RkpLWGZqQTA3MXZqYmtkVERRVm9jOWVwZTZISXdSbzNmWkVCdkV2elp5SXlI?=
 =?utf-8?B?TUhSQTVweXNKdEpraDhLSGtZbG42NTE3bWNOVGRwN1h1VkNuMGZqTUNWcU1U?=
 =?utf-8?B?VE15Ty9ic1kyL3B4aW9OL0JUNVBRUGhzbmo0U1FhL0R0M01lYlQ3WC9adld1?=
 =?utf-8?B?ajFEbHo5elFrRm9IbjdpMFFEazlSZnh1Uk5Tb2cvYUFEbzNxRUhmQmFRbm5N?=
 =?utf-8?B?YjNKbkFjVVRmbk5tQzNXa2JIUVBJU0Y3MTlteGZLTitwbkRaYTdXbEIwbWJ6?=
 =?utf-8?B?WmVuQm9UbXlibHJDc25ZSG5jc0w3YmZJTnMzRWl0UWM1NDRHVUNaamZQWjJs?=
 =?utf-8?B?bkhJY2FxcG1BOFBoYTIxb3FLem9ldnEwaUllS1lWWUhVdWN3cTg3N2hlb3Zi?=
 =?utf-8?B?NHhYWjRYVytpeXhMQWZIbTQxVzhsckcrS0VZUkZQRDJBVFQ3dlh5NWVYVjFW?=
 =?utf-8?B?MHRBbVdqU3FvaFMrVk5RQzd2VjZJZ0xEMTNtbC96TUNJcE85MnUwWHNZNzdn?=
 =?utf-8?B?WEVUQ0U5NHBjbElUeCswT296K2xRSG5USDFlK0pDdDRyQndQbDlveGxwdzRr?=
 =?utf-8?B?aCt6MUw4cDVnREVUSDkrUmRJZS9YTW1wYmgyQ3Q2TUhkYjFGTUk3ZUY1YkZw?=
 =?utf-8?B?dUpXdURuN2QxdkQ1eW5Rek1qcldTMkMzVlBiaGF4bWQwNGF1bTVBc3dOZHAx?=
 =?utf-8?B?dCtmb3VEcVpPZFB5Tk1Fdldudm0zNHB1TXVhUy9oMGhLNmFOa0xhUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39bd9465-afe2-44a1-91fe-08da21e5985b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:18:41.4805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zDL+iSWGKU+Mo6FkDIM40qFmwX8Qzhb4w5cHa0Q2v5YbJz1WPXitnE06EzD8fyya3UCJFyQ/QyOOBpV82Bdiqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5311

On 18.04.2022 11:07, Wei Chen wrote:
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -1889,7 +1889,7 @@ void __init end_boot_allocator(void)
>      }
>      nr_bootmem_regions = 0;
>  
> -    if ( !dma_bitsize && (num_online_nodes() > 1) )
> +    if ( !dma_bitsize && arch_have_default_dmazone() )
>          dma_bitsize = arch_get_dma_bitsize();

Considering its purpose, may I suggest "want" instead of "have" in the
hook name?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:22:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:22:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307926.523324 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk4H-0005An-8C; Tue, 19 Apr 2022 09:22:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307926.523324; Tue, 19 Apr 2022 09:22:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk4H-0005Ag-3c; Tue, 19 Apr 2022 09:22:41 +0000
Received: by outflank-mailman (input) for mailman id 307926;
 Tue, 19 Apr 2022 09:22:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngk4F-0005AX-H8
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:22:39 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 415a303e-bfc2-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 11:22:38 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EF31A210FD;
 Tue, 19 Apr 2022 09:22:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A4E3E132E7;
 Tue, 19 Apr 2022 09:22:37 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id nvPsJl1/XmKqDQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 09:22:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 415a303e-bfc2-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650360157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=oT6cpzs5kAcRX8N26eYbViBKolb/NleOVQ5LSfBVkSI=;
	b=j4MQ4dvfTn/DzvFj7P9jfEXb0LXbXvbxjnOJsHJFgoW9uDDI9kZYXANYjiIUMY3zDbftFZ
	mMU6icUYhiHVaISCdl6YyK8XunRR4dhzklf5hwGA2PSxRRy3f71sCWEZ13j8kwA4wbRdU0
	7ogtMg5A9lg2noLBolb6nidgHLDkOIg=
Message-ID: <eae4f0db-0dbf-44fe-fa37-74aeaa6bc04a@suse.com>
Date: Tue, 19 Apr 2022 11:22:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>, xen-devel@lists.xenproject.org
References: <20220416133158.16162-1-jgross@suse.com>
 <fb19f5ac-b8e9-7cdb-4f72-71b73e6f4b8e@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <fb19f5ac-b8e9-7cdb-4f72-71b73e6f4b8e@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------ssjmJhrXMdlGSHlz2ng25N6z"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------ssjmJhrXMdlGSHlz2ng25N6z
Content-Type: multipart/mixed; boundary="------------0gJ8Civc5B8EBwA0mADfFzns";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>, xen-devel@lists.xenproject.org
Message-ID: <eae4f0db-0dbf-44fe-fa37-74aeaa6bc04a@suse.com>
Subject: Re: [PATCH] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
References: <20220416133158.16162-1-jgross@suse.com>
 <fb19f5ac-b8e9-7cdb-4f72-71b73e6f4b8e@suse.com>
In-Reply-To: <fb19f5ac-b8e9-7cdb-4f72-71b73e6f4b8e@suse.com>

--------------0gJ8Civc5B8EBwA0mADfFzns
Content-Type: multipart/mixed; boundary="------------lp8vsfq0ve3DIdInHpKGdujA"

--------------lp8vsfq0ve3DIdInHpKGdujA
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMDQuMjIgMTA6NDIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxNi4wNC4yMDIy
IDE1OjMxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEveGVuL2NvbW1vbi9kb21j
dGwuYw0KPj4gKysrIGIveGVuL2NvbW1vbi9kb21jdGwuYw0KPj4gQEAgLTMwOCw3ICszMDgs
OSBAQCBsb25nIGNmX2NoZWNrIGRvX2RvbWN0bChYRU5fR1VFU1RfSEFORExFX1BBUkFNKHhl
bl9kb21jdGxfdCkgdV9kb21jdGwpDQo+PiAgICAgICAgICAgaWYgKCBvcC0+ZG9tYWluID09
IERPTUlEX0lOVkFMSUQgKQ0KPj4gICAgICAgICAgIHsNCj4+ICAgICAgIGNhc2UgWEVOX0RP
TUNUTF9jcmVhdGVkb21haW46DQo+PiArI2lmZGVmIENPTkZJR19HREJTWA0KPj4gICAgICAg
Y2FzZSBYRU5fRE9NQ1RMX2dkYnN4X2d1ZXN0bWVtaW86DQo+PiArI2VuZGlmDQo+PiAgICAg
ICAgICAgICAgIGQgPSBOVUxMOw0KPj4gICAgICAgICAgICAgICBicmVhazsNCj4+ICAgICAg
ICAgICB9DQo+IA0KPiBXb3VsZG4ndCB3ZSBiZSBiZXR0ZXIgb2ZmIHNpbXBseSBkZWxldGlu
ZyB0aGlzIGNhc2UgbGFiZWw/IGRiZ19yd19tZW0oKQ0KPiByZXNvbHZlcyB0aGUgZG9taWQg
YW55d2F5IChleGFjdGx5IGFzIGRvbmUgYSBmZXcgbGluZXMgZG93biBmcm9tIGhlcmUpLA0K
PiBzbyBJIGRvbid0IHNlZSB3aHkgd2UgY291bGRuJ3QgcGFzcyBhIHN0cnVjdCBkb21haW4g
KiB0aGVyZSBpbnN0ZWFkIG9mDQo+IGEgZG9taWRfdC4NCg0KU2VlbXMgbGlrZSBhIGdvb2Qg
aWRlYS4NCg0KV2lsbCBzZW5kIFYyLg0KDQo+IFRoaXMgd291bGQgYWxzbyByZWR1Y2UgdGhl
IHJpc2sgb2YgZnVydGhlciBzaW1pbGFyICJvdmVycmlkZXMiIGFwcGVhcmluZw0KPiBoZXJl
ICh0YWtpbmcgZXhpc3RpbmcgaW5zdGFuY2VzIGFzICJleGN1c2UiKSwgYW5kIGJyZWFraW5n
IHRoaW5ncyBhZ2Fpbg0KPiBpbiBhIHNpbWlsYXIgd2F5Lg0KPiANCj4gQW5kIGZpbmFsbHkg
SSB0aGluayBpb21tdV9kb19kb21jdGwoKSBuZWVkcyBtYWtpbmcgcmVzaWxpZW50IGFnYWlu
c3QgZA0KPiBjb21pbmcgaW4gYXMgTlVMTC4gVGhpcyBpc24ndCBqdXN0IHRvIGNvdmVyIHRo
ZSBpc3N1ZSBoZXJlLCBidXQgcGVyaGFwcw0KPiBtb3JlIGltcG9ydGFudGx5IGJlY2F1c2Ug
WEVOX0RPTUNUTF90ZXN0X2Fzc2lnbl9kZXZpY2UgY2FuIGxlZ2l0aW1hdGVseQ0KPiBlbmQg
dXAgaGF2aW5nIE5VTEwgcGFzc2VkIGhlcmUgKHdoZW4gdGhlIGNhbGxlciBwYXNzZWQgRE9N
SURfSU5WQUxJRCkuDQo+IFdlJ3ZlIHNpbXBseSBiZWVuIGx1Y2t5IHRoYXQgbGlieGwgZG9l
c24ndCB1c2UgdGhpcyB2YXJpYW50IG9mIGNhbGxpbmcNCj4gdGhpcyBkb21jdGwuIEkgZ3Vl
c3Mgd2hlbiBkIGlzIE5VTEwgd2Ugb3VnaHQgdG8gY2hlY2sgdGhlIGdsb2JhbCBmbGFnDQo+
IHRoZXJlIHJhdGhlciB0aGFuIHRoZSBwZXItZG9tYWluIG9uZS4NCg0KSSB0aGluayB0aGlz
IHNob3VsZCBiZSBhbm90aGVyIHBhdGNoLCB0aG91Z2guDQoNCg0KSnVlcmdlbg0K
--------------lp8vsfq0ve3DIdInHpKGdujA
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------lp8vsfq0ve3DIdInHpKGdujA--

--------------0gJ8Civc5B8EBwA0mADfFzns--

--------------ssjmJhrXMdlGSHlz2ng25N6z
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJef10FAwAAAAAACgkQsN6d1ii/Ey+6
Agf+O4nuRx02TJ4BtAprYpFEIl5VgYoSh+eiJPLT8mo/ISGTqS39WTXskmEstp+sFh6oPHldKVzY
6lhw8qWA2wdb+Flqfl3ysUjLyjq4ESb4AgearE34DeHoYta2UssncyVkwjnY8kAhHdC2P+KVOSDF
+Fm3qFRQq3vvGLeqh+E58I1gy3ySgFwKxb6UhYRuM10ukubUu+BINt/ebANUTRI3/4OtIJjhafZV
USCO+lJjMrkkMURoXw7wGBmFYXfGS/k+9n5jLddb4L2s2oUZj63XiH/DEnQjPD1TgM72UtUrjg3W
GfIMpRgvsKftmAGRE1bbQ9B61CTt3BUP5Nxtxf8NSQ==
=eXTq
-----END PGP SIGNATURE-----

--------------ssjmJhrXMdlGSHlz2ng25N6z--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:24:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:24:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307931.523335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk5t-0005oM-N6; Tue, 19 Apr 2022 09:24:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307931.523335; Tue, 19 Apr 2022 09:24:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk5t-0005oF-JK; Tue, 19 Apr 2022 09:24:21 +0000
Received: by outflank-mailman (input) for mailman id 307931;
 Tue, 19 Apr 2022 09:24:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngk5s-0005o9-AI
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:24:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d6d4142-bfc2-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:24:19 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-qsDK-B2oODO0X1tJYHm-xQ-1; Tue, 19 Apr 2022 11:24:17 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by GV1PR04MB9088.eurprd04.prod.outlook.com (2603:10a6:150:23::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:24:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 09:24:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d6d4142-bfc2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650360259;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=AXDhlTyJD652SwmNSxvKUIOuVlIov+Elq5BJ7hIWKpw=;
	b=P8v1GX+UdNhcrJ4uzkXOVFkM/ErmRtRrXhZAy514fRFX2l46LurdlhpLiKBM3+JQ7Dpxhw
	M6ZuAkoG+Qg7dEgJ712LdjwlNue4Ye7rXvW3WZM0y09+eWxtJc9YepaPnWQxMd3wqf5Fvz
	Ydd3x8qN23nYOiwYXFda2tcn1HZ6dlo=
X-MC-Unique: qsDK-B2oODO0X1tJYHm-xQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HL53cwLVKZMhASBsLNuli6ICqz/Yi11GxdpAlQepDAKtpcB6sUahB/doaNOBpaTX6KNNJzsz2qNJVZNat3tqzawqB+xkm2rRPy7NnU56oUGEk9vfr4HFtG33YVqxAbv4C6mF3s53nPqR4S/cRKw2WVH6duwsrYYb3NV4Q/jCtK0ZI4/tET0B775VlHGlr3HK78MF4WIrmiwzgkBqh1tJASevUFP+THFsy//N4kh1aKzeSo9Zq3gZ1KExT18GCBR5l9hLLo5lZ7+6c+wgit9QQb1gnMEq3pXF+lYbRTcsYKNweW13RNM9f0QxKLMFp4y5rxbTRV/XktSnEFi13U9O1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AXDhlTyJD652SwmNSxvKUIOuVlIov+Elq5BJ7hIWKpw=;
 b=kyQ50AgDwKM/+QkCvrTiB6gpYP7bXArKzYAsWOwuW/HmzbRIFlOaXelhBA1jwtxcUB3Hv1MA+Z6oyu6uSb2/4HvBRjl1Q8SCPAtUmkxro8xwSRJpzYxjaPDffUANDZvq2E6Stvky73RrT8qMeAnIyBAAPpqGHi9mq9r8DGJSDVxxw5UqNU6E1QZZxxRTOkFtKeQOwl2Gdw0mhU5kQDurT3WOwKnmHaRlCPJqeEP9Tu9uzMvSCUzvsCkI37At5//D7/VaUo94jVXg7m2W/Ffj/RjfwqsnJx0sY70RsW6N2YYKUeIwSsSLdVdF+Rmcf73CXTeCj28N44W8sVxLTYhsXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ac74e26d-7274-3d7a-1143-6d9329214b41@suse.com>
Date: Tue, 19 Apr 2022 11:24:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] include/public: add command result definitions to
 vscsiif.h
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
References: <20220323085831.27057-1-jgross@suse.com>
 <73498b4a-2175-32e1-13d3-2aa0a4ed197c@suse.com>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <73498b4a-2175-32e1-13d3-2aa0a4ed197c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0071.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 265644a9-066c-46cf-8bc4-08da21e65f81
X-MS-TrafficTypeDiagnostic: GV1PR04MB9088:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<GV1PR04MB9088CFFE85936E0ABD5533EDB3F29@GV1PR04MB9088.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	g2kYUJNX37GR1piLt5a9r5zpyWw5+6gAetr8bDn95IN+tLeC7/5+R1T/XlcnNiR7xf13o8Z08JiJ+fXQx5y3KmkOpJfR+kESB2o/nHDT8IrhZjN7cLj6p8IJHGvLEX11TPsJf7lmfhDi6oPPw8KpDRXzoBEH8H1kGOMo6yTAnx9fklBjPQWeeltrNN60gffmHw+zRn+VTFOsubuWxbpD5XQ0b/uZmAK9Y0t++AgEHpChH3lE5WB6EF19ksjjZsEF5Be8cK4bzTH7qyT02k6TRZJ5ZUjo6vnhRzAD98tZ1DymYGh7LNJ4XAR4CG8utUshRSGlf/+mGn912n7XfEhi8cs3kBmOFvvV98N9lanabT0afkkvU6+yD/LphpuIxN0nGPbEM9KCy+m9LWptr8gpONqrCIqicw9MCV8ZB0ISVnW6uUgODdhMwew87usCX2ljIiUN72hXIlH1RsdmGljlG8btTrTZP/IbPWn5UaMQSYaeojOWqdtdLxNXhV4Rn3o41ONdgnEf20pRs18hWYHxbyLJiznGYABLa5CRNRTN5DbCnm9zHFlqOhEj9a02BDiqFGoOmQE7W1bYLxf4JD+iV2Mm6iNyXTchFwjt1/JRPhSmY1hsoiuUjtgJhLXU0vnn70u74Ae/ek4cagIow4o8WebP9/mzZrOug5T1wxmTrrKdZLruRl4X0FmFTiRV47Wyh10waXpRyodFsbsEuNoygmCH58CCRmegAaoj2SnICPE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(37006003)(558084003)(508600001)(6512007)(5660300002)(6636002)(66556008)(2906002)(26005)(6486002)(83380400001)(53546011)(186003)(36756003)(66476007)(8676002)(6862004)(4326008)(38100700002)(6506007)(2616005)(66946007)(8936002)(31686004)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UVdzOXd2cUNtVlo1cWY4bFdrRlN6SHI4a2FTVlF6UHZNOEhCbnpOOFhYd0tR?=
 =?utf-8?B?a0dabjV6K3gySEs1c1Y2V2M3UFVwNk84aXFiUDBydE1oZFdlZHRBZGxPbWcy?=
 =?utf-8?B?SFVGNWs2YnZmOVR6SkdtdVplRDlKTWx2MXptN0VQRVE4TWtNcFZhWUp6eWtO?=
 =?utf-8?B?b2lSYkgvSHdJMy8wUWZZRzVHT0xWaHRRelVtbzNyZmFoTmpHck1zSW1DRTRN?=
 =?utf-8?B?RThNTGlQUU1wTlJyM0gxZ2F5ckkzZExIT1RDRlk5VWpoSWZ5bmJQUUN4UTlX?=
 =?utf-8?B?MHFzOWdjWGdLcFpvcWNDRjlWODh2RmkveDZsSVZjdEpUMEl6cFg4TFZRbGJD?=
 =?utf-8?B?eWQ5aWFRd0VLM1VxMlUwcXJlcmFYa1RLdzRCaTJKNWliT3pMbldTeENzOGtL?=
 =?utf-8?B?UUIxL21ZbnM5S0lUamJlVUozTVR3Ry9pRnB3SGVrejhjUmpENm9mWUsxc2RU?=
 =?utf-8?B?YnZsK1BIV2hMSS9rVGRaV29Ld3I0UUpMVGo4aTdHeXZ4R2ZwOFc3VXFUbkg1?=
 =?utf-8?B?bE1hUVIvSG5EWmZ6VkZmVGo1dEwrTGk3d2xHTlgwYk0va1RoYTY0bUIyMU9t?=
 =?utf-8?B?YkxQQXcydmN4UjgrdU1pem1RL0Ivcnl4ZnY2dUQ5L3FrSk9UUnY3Vm4xQXJY?=
 =?utf-8?B?RlBFRHNZS3d5Qmlwb0ozWHkzM3BPL2dUN3NwOFlKdENtS0NsNWRkUGgzQ25a?=
 =?utf-8?B?Mkt6QXdnMTJkeUVqREhJUDYxWDBZY2dHNjU3TFBKci9YYTBFSFVaWUdIK3Z0?=
 =?utf-8?B?d0ZIcjBSNmhEZ2R1dTBvUHB5RGM2OVIrT2Uzc0g0dXpFbWZXZEo0UFBzM3Bv?=
 =?utf-8?B?Y0psanRKb0ViTEZEWjlxRzA1dTdDWnNQTTNmRndFUEJ0ZTE4aHBnaDd3WHpB?=
 =?utf-8?B?NWNmb3hpTmxTUy9RRFNvOE42RTkxUGp4L0VQQzk2aEhtOUJrSFNkNmhySDBW?=
 =?utf-8?B?UjNYVCt3VFRvbVNadElwNEF6Ti9mRlZza0hkMWNzRlF0ZnQ0SU1rWnBHZVZO?=
 =?utf-8?B?L0Q5U3hBUGIzbnp0Ui9HNWVRUDVIbGFGQUs1WGQ3Y0FGNGFDNzNzRlEzV1lD?=
 =?utf-8?B?TkVJNThEaXpMQnh4eDlEemwxMWRVc1pNWkJQUTBjMzdQdWM4ZjYyb1VKM0ta?=
 =?utf-8?B?dkxQc29WWklDNldWdlhGbWdVbmkrMEEzR3NZaVVGVEhNcjkyNmRBZXBzNlJU?=
 =?utf-8?B?UFNrM2s5Q2U2VWNPOU84ZTBlNDhpa2lNN2FxSTVHeVNyM0xTZ2Y1anAzUW5y?=
 =?utf-8?B?Y1RjUHhReFd0OXF5NU9Jb1pndmpwQlV1aEtzZy82V3dpaTF4UHhBZTMvQ1Uy?=
 =?utf-8?B?dGM5SGoxWk5mVTZWYnJab1N3WUZXUUNGVTRPdHJNOVFxcXRpM3JkS29yY2JW?=
 =?utf-8?B?WC9OcG1BQ2RxRTdjamdBMEczdVVwSk1lbzVhVzg4L3Rhai8wNllTWFh0MFZQ?=
 =?utf-8?B?ZUtLUEZwQVRmNmVzbjkyR3NuRkIzZXNRdTNsclh0dWVQelR3cEwrRXordUlC?=
 =?utf-8?B?ZGlDT3A1dElqQmdMSGIzLzc5N0N5bzNCOWZ5eDdXSEVuQ3dHalllT0E5R0pE?=
 =?utf-8?B?VXcwV3c1eVY0SVNZT3A4eEVDRTNuZnRTTlpxR2tpVCtIcXNUcGtFRUdRTnE2?=
 =?utf-8?B?a2grUVNxYWxocUN4UmxwcWw3ZWY1QVpIT0NpVWloSUx3VGJuQUhhdnRESGIw?=
 =?utf-8?B?UTlZcDlIVVovZ25xYWRJQThOZTNjN2dhcmkvOGV1aVRHSnRiYWlhcDM0VS8y?=
 =?utf-8?B?VTJTN3c1L2hJNkt2a3l2Zm5jVkR1SzZNVXduekU4WkhicHJodk93WnZLVGdJ?=
 =?utf-8?B?S0dQelJMZHc2cGVxMW40TitjNStTVG5FNHNnbGoyaGNKNmRQMytYc0VQSm9B?=
 =?utf-8?B?Ly80UjBnbC9tL1dDYmtZVE9FZTNWUWdFaWRSNXo3SGNPeFJUMDJzYmZUaFNC?=
 =?utf-8?B?cWxlb09HdklSOU9rc2p0MXkvaU1ubytIRUxmOHlBSzN6dDRyS1hGRG16d3dz?=
 =?utf-8?B?RG10Q2NLZXFWNW8zb3hTYStza1ZjZDExYzJLTDkwaEJMbU9haUF1ditZT3RZ?=
 =?utf-8?B?T042VmtQakMxN2FiK0NhbENyUjF6ZWQ4VWxTUkozMDMyNzIvYmRMT1FPc3BV?=
 =?utf-8?B?eGdFdHM0UHA2RG9yN1pESUlNb3RTWlRVNkhpM2tta0RBZDZ1c2EzMjRoOEJy?=
 =?utf-8?B?THozb0hFVlJwT1RZdnN2VVVZMWRBL2FDUk9sL2R3eHRzTlFVL1g5eUMzVmZh?=
 =?utf-8?B?MFh0ckVJZjYva2dCZGE4cTB1R3BXQ0kwekxBekNiSC9LRFpZN1ptN2ovQnNP?=
 =?utf-8?B?NTRmNk1MdW9kSDlGMzJnd1RhY3NwK0cvNzVKK3BNMUxmZWU5L2pPZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 265644a9-066c-46cf-8bc4-08da21e65f81
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:24:15.7209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tqFpPbq+8q+rg64syNKTuqQsD6hFldM2UU5g15zOtUCCJKwflLJy6WcMojDtsIEhnJWRhqvUZtQC3+LbqBUkIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9088

On 19.04.2022 10:34, Juergen Gross wrote:
> Ping?

Actually this patch is ready for committing - you have got an R-b already.
I merely failed to tag it as such in my respective folder, and hence I've
overlooked it during earlier commit swipes. Will include it next time
round.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:25:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:25:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307936.523346 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk75-0006OL-2A; Tue, 19 Apr 2022 09:25:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307936.523346; Tue, 19 Apr 2022 09:25:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk74-0006OC-Tp; Tue, 19 Apr 2022 09:25:34 +0000
Received: by outflank-mailman (input) for mailman id 307936;
 Tue, 19 Apr 2022 09:25:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngk73-0006O1-A1
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:25:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a901812e-bfc2-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 11:25:32 +0200 (CEST)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-MoS0c98HPFqcGvhOPLjRJA-2; Tue, 19 Apr 2022 11:25:30 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB5946.eurprd04.prod.outlook.com (2603:10a6:10:82::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:25:25 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 09:25:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a901812e-bfc2-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650360332;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=s4SRGsT3WsC/afQ7S+TOAetnWSUu5B4GZ271bnn/29A=;
	b=KgnfU0krScbd1QTkrDh2ytv3NZD/ehGjNEkTVIGC7ZYq+096aN1C6/tBGEz2pMxc5tclQ8
	Q4uVU/f/sbcvlDDegEmsoRTgtuDeTEPPPQ837NOgDGPeFsbYT3QiSdyEbAElS0O7xe3GcL
	2P486QwNugfelT0FnnR4XVbXBATFch8=
X-MC-Unique: MoS0c98HPFqcGvhOPLjRJA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A/acbrCzJx9zkn3c/v9axoi0a9m9EWgdpVAljXsbw8CdLZxEqi3cvQl/D+Udph0ksKfQNImTmHSxzkiYEKjw9kpsKaXC7vEq+u8yVNf3dFS2iffKs2lFcBJ7ILq+NPkfCey2KFOdNwQT0w2cq9nC0i+vhKKzi7zaehQEeqTsoZtQehaD3n6h94RIJciLlkPf/ALC5deIUsd5ULb9LqMgwdyH5E1bNumO3wOsxqAygefa/EXf8tD9kOJVqD8MksLYANWpnV3TnQ9oXlzWmB1joLkQGaFmHZLFwhAP+vPBxUYhlbcPOFiPWKUeyXBfdhQ4iiX4zw629PGcUzuGuZQ88Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s4SRGsT3WsC/afQ7S+TOAetnWSUu5B4GZ271bnn/29A=;
 b=j7ciDeGr/eGb6v+lUlcH2ES55IIVLETh9R8TBwULBldvrROkNhiGGwClV1eoyklw9I23fYT8RkUdqx/oNChtztmbe16Ti8cQsYBgX6wwm4xtA46Qqt6l49ranaTwnBPCzvkdo5a3Uic69W01GLinFmmNgWQET5kfxSTVwrP19d8H79WvOJc3+LOTMCn2WthMDcMFXfJq9cMGIY44wtR6m37pyzLPb3X1J5tRgNh9c7ClAVzT4FAAKKMV6/5lV5Mz2s+MaSmbUcYyvrnRULU9LGf0rN4/s2ch+QKiKo+smTVdLFISQEe49N3ta2es+ERex7yMeELH7bCtiEy0oEWwDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c25c4c9e-b2aa-889b-53d8-b396d323c9ae@suse.com>
Date: Tue, 19 Apr 2022 11:25:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>, xen-devel@lists.xenproject.org
References: <20220416133158.16162-1-jgross@suse.com>
 <fb19f5ac-b8e9-7cdb-4f72-71b73e6f4b8e@suse.com>
 <eae4f0db-0dbf-44fe-fa37-74aeaa6bc04a@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <eae4f0db-0dbf-44fe-fa37-74aeaa6bc04a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0001.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 20e43348-e937-4401-3c7e-08da21e6895b
X-MS-TrafficTypeDiagnostic: DB7PR04MB5946:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB594614FAE7070B39571F7775B3F29@DB7PR04MB5946.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DxfVfAbPHAYohEn4c8snljVUp7dhlxSdV3BQ7ttNd4EfNY0xyu/uRmmbEAWbK9giOr2bd4rUPI0JiZSGlrHJ1t63Rx0DEjxWtqQEbLCK2aACXzkinZMLaBEw1yqyjHmtDKki/3p8pkrFX6T/WEHiCXzBOrmbE133h3gJNmR7/eFsS1g3kFRLw8Ad5/Ctr0e7aBEQPH4KD7G4lscX+oTyv1PZPUe9o3Kw/rCvY2YLaIVGIsufkf6JxEQaOpRKeaJ0ryQVjSw4EQ6sSIzhmJGBWq6N1puOdw66CV8SObOpe/6Sct+5HmauPmmOV1kKWpTLaBG8CgmnhZ3tkSt+JvxLqdwP1xTPAkIYUxzShO2beVqrQbWDCJ75a+cC0c+OrLWS1HAzjohUYiQNhMMxXVa+9JNvUFTrzVhKYJKUTlvqQkzPAfoD/If+zIwVshIWWUeoSYC6aN1hGfVsww8+F64EEhC+m6ByqLSUy1UPVzekKnKt1EvWZSeqGZb3C2Ghxksn+t7D2/Zpwe8OeangsPeXmWWipXoWat7Orc8baNB0UgNmAUi7mJ1YX1OEDGzcbIYLqcVoegRvT1zrOm6PZnkGnsPqY9HJ+StdjMB6QE7huH+lHzSGVdcQ/IXyyKhXi1+zjJSblTN7ud/yKhLrBMvnEsv195Q7o08R2H76l9vp5q6tOgecnbX6Pcbydu5SsSZl77rwiAw4nygC53cMSWVjr0cshvLonhTz1gygeIocgps=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(37006003)(316002)(54906003)(508600001)(8936002)(36756003)(6512007)(53546011)(6506007)(2906002)(5660300002)(38100700002)(6636002)(26005)(2616005)(186003)(6486002)(86362001)(4744005)(6862004)(4326008)(8676002)(31686004)(66556008)(66946007)(66476007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U3UvbHFvSlo2UnZYSGJ2dHFWZWtHSnVkWlVOTWtVOFRsY252RERiWnpMeVdL?=
 =?utf-8?B?TDZtZ3U2bmRSVnhJMGJUUU1BY0ZMK3lmMXBTVjkwaEtMZUxVNTV2MDRnSmJT?=
 =?utf-8?B?WTlDMi9QUFM1UGZhU2xBQ1piUm5KcnR5Z0FvcVU3dk5BM1RPR3JDb0h1VWdu?=
 =?utf-8?B?Q3RBSDJpVnA5RTVmcjU5WVFaN1JUOFpxZGFUL2VMM2VyTUFYMGNUQUdSOVlG?=
 =?utf-8?B?WTVxd2NHUzh3enNDalRwTUZna3RCZnRaME5haXhCTFFmL1NpR1VyME1CT1hx?=
 =?utf-8?B?Tk1NZ0laL0VBL3NJR0pjVy9hWGtzYUI2T2k0MVMvY3RSZEpmRGVRMVZlNldu?=
 =?utf-8?B?NmZqeVBCZHVLSmZNeThrUGJPRE5uTWx2MHBHUHZQRVFKNWhhSEtnVDBRZkNi?=
 =?utf-8?B?enpPbGJsSitxNkpROFBDSFhML05TbGJXR2RIUWl1REtQNHVXckMway9pUmFH?=
 =?utf-8?B?UmwxamtwUXg5TGhSZy9yUURLelhvNnkzRFZXM29TdzR4dGhvMUtHUUR5SHh4?=
 =?utf-8?B?RkIraEowQWh0MWdiSnBTWUhBdzBENzYwTVZKWFkzYXZaeDE0ZEFjS25wQlpr?=
 =?utf-8?B?ZjR4Z1VPMHlvZTJ5NUpOVTlwVldiTnFDbkovZDhrYmlVZTBYMGNmQUxtdWxK?=
 =?utf-8?B?ZzRMMFlTSW1PNkFJdDhBRFlzcXJOeEpBelUzd1o4dkFrSXhpKzdHT0tpY3hk?=
 =?utf-8?B?VXB3OFpPdnQyRlpTaHNoRU1IZ1FESHRXRkpFbk5WSHIzdjNRKzV3R2ZUT1kx?=
 =?utf-8?B?cjZ0MkdsVlp4dFFURmNSK1kwNDI1bkIxUDVVVCtSNUNGNStZNWszZGR0dEt0?=
 =?utf-8?B?NkhQQ3JYZDhLUDd5Q3FiOHBIZmR4bUdyQWovUVByZGgxU0NOR3UxQnB6ZjNI?=
 =?utf-8?B?ME9JbERrS00yT3VNbFFEUFVvVEl2R1BFSExiZG91QTE0dFByWlV6QVJVNXV6?=
 =?utf-8?B?S0UwWVk0T25OZVJURzdyMXBhN2EzQk1QSS85TjM1cnY4RUVrTURQbkpxcVFI?=
 =?utf-8?B?MzEzRnByOG1YVXdvQWErK3BxYldNU0d1MEh0SWFjWUJBeUhUZDhlVTJVaWZ4?=
 =?utf-8?B?MWRnSlJyWnBSeEU5ZkwzUm9xRXZNZEtySTdrckNPU01IWHVIVVV3bXpJUFo4?=
 =?utf-8?B?dHh4bDJ1M2NibE5remZ3d09zc0kvVC8vZVR6OUZuOXo5blJQSDJuazF0UWkx?=
 =?utf-8?B?N0hhbUt3RWhlYWxFNlpQOTB2d0xRSU1LWFB6TXRRZy9zeHpUU0J6K3V5TzVq?=
 =?utf-8?B?RGRncExzZXZmbWhFMGNIUlhhMnI0MFJ4TTgwNTlhMkd6Y2ozcWRwZVNOZkRq?=
 =?utf-8?B?M3Z2RCtEdmwwNXIzYWdmbTYzWE02SndOeUt0S2J2MmhUYXQrSlBmQlVLbGhF?=
 =?utf-8?B?YThsMkc5QjdWNWhMWURtMFNIKzFyeStKc0hNWHdXVmNTb3VxSXNjeFdUbFZO?=
 =?utf-8?B?YVI3OEI5KzVNdEk2MFFDOU1ZT3QrQkVxcU5oS3d0aDIyaHlEWjBZTjlxZnE3?=
 =?utf-8?B?UlIwV1ZUcWZUL09jN2dZLzZUQXdpd3E3Nk03bHhJZTF3SWdWVGs3NVlFTGtl?=
 =?utf-8?B?QXhjNDV0VUNJZFVtVTlSSTIzVllhQ0pEUm9ZcEM1dkhDSS80S1cwNFc4ZHJJ?=
 =?utf-8?B?MWFCTGpMaFlua0dZLzV3RnZuL25Wc3VyME5kU0pDU1NZOWFqNEpManpYVC90?=
 =?utf-8?B?VnEvVTJ3RC9SUEZIS2xsRXNoU21vM3NFdFFSKzBpVVB6dmd3KytTWGhCdXFu?=
 =?utf-8?B?djhOTzRoSVlrWk9ud3VjT2F6blhDSGVYeEl6VVA0aGZPVzhJSmdBWG90TDVS?=
 =?utf-8?B?aEV0bmFOOEhMZ3drS2gxQnA2L096bFBRbnZWTlpvVTlsZXJqVmp6Vk1uektW?=
 =?utf-8?B?bDB2Q05EanN2WWNheXBtN0Ezc1NlT0ZlM0JvdmJtMVFKR2VjVGpydUc1YWhi?=
 =?utf-8?B?c0IvVjZWNnpteG9aRFRVZG9uN1h1ZCtZNXpNRldxNzZCTm9tMk1pNVkzeksy?=
 =?utf-8?B?RllkdlcxR3dCNW52YWF3MWlFeHJzYjNvRXRiUEJ6QzQwTitBaXYwdS9wMWx6?=
 =?utf-8?B?a3M3SGQzdG1ZMEg5cmVmVFpiakhVWG1yL2dhU2txeXBaSXp2U24vZEVTZVZa?=
 =?utf-8?B?eWduVDlJUnZQWjVmd2hNd3dCY1JYaFI5dENGWmx1QTc0alFhZnRwK055Q1hz?=
 =?utf-8?B?bHR6R1N2c3llNEFncnJJSXJESnBhQlNSTFFzbmhRM1F3ZzFrUVM1cmlDZ1pI?=
 =?utf-8?B?RU1PM2pmY3VrVVdrdXJUZmplN2FCYW4rQkFQZUZlM09ka3VLT2lxd3dPWjNX?=
 =?utf-8?B?cEltOTRERHlWemlEczFEZlhyR05lQ1YzT0lTakJCOG40cHg5eDM4QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20e43348-e937-4401-3c7e-08da21e6895b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:25:25.8248
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 25T0xjp9pf2dzH0JzoghuxGHKZ5+XzLCs1B4OfyVDdcGx/8n0cuwba7oEyIJ6P1FmvIu728JvS1oHC3BCvxkgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5946

On 19.04.2022 11:22, Juergen Gross wrote:
> On 19.04.22 10:42, Jan Beulich wrote:
>> On 16.04.2022 15:31, Juergen Gross wrote:
>> And finally I think iommu_do_domctl() needs making resilient against d
>> coming in as NULL. This isn't just to cover the issue here, but perhaps
>> more importantly because XEN_DOMCTL_test_assign_device can legitimately
>> end up having NULL passed here (when the caller passed DOMID_INVALID).
>> We've simply been lucky that libxl doesn't use this variant of calling
>> this domctl. I guess when d is NULL we ought to check the global flag
>> there rather than the per-domain one.
> 
> I think this should be another patch, though.

Sure. I'm happy to make one.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:25:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:25:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307938.523357 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk7J-0006n1-99; Tue, 19 Apr 2022 09:25:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307938.523357; Tue, 19 Apr 2022 09:25:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngk7J-0006mq-5e; Tue, 19 Apr 2022 09:25:49 +0000
Received: by outflank-mailman (input) for mailman id 307938;
 Tue, 19 Apr 2022 09:25:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngk7I-0006kt-4R; Tue, 19 Apr 2022 09:25:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngk7I-0002mQ-1G; Tue, 19 Apr 2022 09:25:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngk7H-0004PC-Ji; Tue, 19 Apr 2022 09:25:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngk7H-0005WM-JE; Tue, 19 Apr 2022 09:25:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zkQKqWyYnLcwNvmaO9Os1sHPJp46WTNo6lUver2BFfk=; b=p+8hIeXW6iQug+/S0yVIcLlrLU
	tj3HFCyO1mW4QKin43wcQ+7dIK2WKEWaAK4sSbGqwuSJ760c9WSAXJtx9ljplTm/TyUmapg+kLlul
	qB8mAwbKnjmpgvKvYV3eeZbxyK3ZwtseQle/qhsJ6VLujmKtfKbjOcEfceZaNjxUbzwU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169528-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169528: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
X-Osstest-Versions-That:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 09:25:47 +0000

flight 169528 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169528/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169499
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169499
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169499
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169499
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169499
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169499
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169499
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169499
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169499
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169499
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169499
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169499
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647
baseline version:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647

Last test of basis   169528  2022-04-19 01:52:02 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:29:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:29:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307950.523368 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkAq-0007gw-UW; Tue, 19 Apr 2022 09:29:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307950.523368; Tue, 19 Apr 2022 09:29:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkAq-0007gp-RY; Tue, 19 Apr 2022 09:29:28 +0000
Received: by outflank-mailman (input) for mailman id 307950;
 Tue, 19 Apr 2022 09:29:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngkAp-0007gf-32; Tue, 19 Apr 2022 09:29:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngkAp-0002qq-0S; Tue, 19 Apr 2022 09:29:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngkAo-0004Tu-Hp; Tue, 19 Apr 2022 09:29:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngkAo-0006lV-HP; Tue, 19 Apr 2022 09:29:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=91HOGXzIKMXgUaUp7BFlXWwzhle/5xob5ZGUD3CVrPk=; b=JK/VbV3MCSpO8yOSCsfIwnM0Sg
	POzqDDvAfbnGORxiVBxuR9S/i+B8Eo4S+wrj6dYDkjIdhHdGDjVJAGWca5K/lQk2wzX+UEj2pyxly
	/rovlwcd6ceuSGeGMFttPbrTXBCMAUi+UQDWKbbuk9cG9Gz0NN/Qtzl2v4HQd0ukWPSw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169535-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169535: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 09:29:26 +0000

flight 169535 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169535/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  502 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:29:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:29:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307956.523379 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkBL-0008DZ-9g; Tue, 19 Apr 2022 09:29:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307956.523379; Tue, 19 Apr 2022 09:29:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkBL-0008DS-6Z; Tue, 19 Apr 2022 09:29:59 +0000
Received: by outflank-mailman (input) for mailman id 307956;
 Tue, 19 Apr 2022 09:29:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=abXu=U5=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngkBK-0008DH-Ba
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:29:58 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0615.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::615])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4663e64d-bfc3-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:29:56 +0200 (CEST)
Received: from DB6PR0301CA0027.eurprd03.prod.outlook.com (2603:10a6:4:3e::37)
 by DB7PR08MB3450.eurprd08.prod.outlook.com (2603:10a6:10:41::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:29:53 +0000
Received: from DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:3e:cafe::84) by DB6PR0301CA0027.outlook.office365.com
 (2603:10a6:4:3e::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Tue, 19 Apr 2022 09:29:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT060.mail.protection.outlook.com (10.152.21.231) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 09:29:53 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Tue, 19 Apr 2022 09:29:53 +0000
Received: from 53ddf43e1e63.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BEBFFECA-41E6-49DD-8B5A-EA2365A506F8.1; 
 Tue, 19 Apr 2022 09:29:42 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 53ddf43e1e63.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Apr 2022 09:29:42 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM6PR08MB3910.eurprd08.prod.outlook.com (2603:10a6:20b:6f::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:29:40 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 09:29:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4663e64d-bfc3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lYB1xsnZrfBvXM4s2nBQ5KwVbxk5S5TrOZDf1jh+21w=;
 b=GPsrJGLSEfamGCYM+XcCQRx8Vp7s/4V6lGMg/HJfXc3PspMqtK4Vx2Z6q2C0YD5H1DzVEXO0oBOuiF/kRtXQtrnlXmhcwBRrB8otWXjb/WAQ9NlZcK4f7iPQr6ZFimq5gxHFJ1N7qaLUfYg4iM2i7rNpu8+zhgjuD3YWA3sX8AM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N5l7kDf8gRM0uDOrxQzAJIvGBKId197IE1Zd9twVG/fMEuHZYa3wX4TLAVhB9KAQnQaAQ52xYsgixHuS0Ho5I7XrOhfHSjs4bRpu0Yrm4jhFSQIuHZvAKjmSxCiyfJSdXsXdK8jLQ5afx4AM5v6fK4G0ze89ZPys47MtmNVAARGx74IY42MmCg3+fxZ5qMZj2XuM9bv3O4p+PVL3P6G/x9GtBMKmAti5Csbdsr6ZOFPSsuhaXyIT/c3fPb1ytggMk/x7fOv6lo8paty+EJfVlha02wdu2YIYQnASVxPTuk5A9ZZpNDxMYFDWE/s3TjHPDWWZ03YVqvn0zmwAV95qzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lYB1xsnZrfBvXM4s2nBQ5KwVbxk5S5TrOZDf1jh+21w=;
 b=T0k5Kmqe60MCBbRZIxDSbhCSLtElZQT/MdD5OExYadxH6/ENgWpwFLZ6ztVdChcBQEb4LK/eq77a52mKJA6S8abbdmggYSn01H945BhVt5SjEWFPNXbH6nGH/adpavH9wAUY+O82JuPmq2b9nk2FDCxcvHb3nmuZ5UBPUUfh9bEl3evf2Ci5lDZL5qLcqaFVwF59kwvQCz/r8EF0aPznztV7KZFuK4KYbCzC5QD8nGEoN7UUYIwIjGxiO+VljNYCIJraMdmddfou7iRESC1S2Zx0TdAWxwYt/GI4t4+a4wKsvW57UIHhoQxqPz6ytS+2CyEVLEWYQb+rPhztIq63dw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lYB1xsnZrfBvXM4s2nBQ5KwVbxk5S5TrOZDf1jh+21w=;
 b=GPsrJGLSEfamGCYM+XcCQRx8Vp7s/4V6lGMg/HJfXc3PspMqtK4Vx2Z6q2C0YD5H1DzVEXO0oBOuiF/kRtXQtrnlXmhcwBRrB8otWXjb/WAQ9NlZcK4f7iPQr6ZFimq5gxHFJ1N7qaLUfYg4iM2i7rNpu8+zhgjuD3YWA3sX8AM=
From: Wei Chen <Wei.Chen@arm.com>
To: Wei Chen <Wei.Chen@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: nd <nd@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Subject: RE: [PATCH v2 00/10] Device tree based NUMA support for Arm - Part#1
Thread-Topic: [PATCH v2 00/10] Device tree based NUMA support for Arm - Part#1
Thread-Index: AQHYUwPmql26OclSj0Gd0xQ7ylUCkaz2+O3g
Date: Tue, 19 Apr 2022 09:29:39 +0000
Message-ID:
 <PAXPR08MB7420F854241B245C4F0F60029EF29@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
In-Reply-To: <20220418090735.3940393-1-wei.chen@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B0D29BCBCC8F894FB573066EDFA0A9C9.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 79f99f35-6998-4be0-bfc7-08da21e728f3
x-ms-traffictypediagnostic:
	AM6PR08MB3910:EE_|DB5EUR03FT060:EE_|DB7PR08MB3450:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3450E2E519B37DBF1B159ED09EF29@DB7PR08MB3450.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 GKQ23ku2MLbiU2B4DIkDeTTX7qH5nCZEBWDCJYalhAe0xCPf8pcCgTxNJ1kV/m5ghjb8AHeB8FWJbXkk9wI6d1mJ2WvGR1BK/exqOUvg3+bi3tsoUdhHX6RTWzCcAF2h2Qs212/tY2P07ySDsuUsPbjPqMkNJeicsi/fGhCHMofHBCWM8moo3g/H/NFu5QHtQm5SnSHeJGJOF21DIQd/uk0X16+ZAHTXzRm2PGO8qCBOseNowhsaYAgLKoQW8jL4gCCvlt8Li9+hFerGFC+JfuE2+bQ59ajQdz0HdgPIseTMI+N3Yh1U8Myq6noO8GVweiQTmNACTOgi4iY+exj+Dp5jCkx74pM3yKwKHJBWUd509sDQdock+HugBGe1YMfZwOunsXj2YvOlgQPyTFC21cbD/wPADgWSl9mgUGohtSDKjyImv3KNI9YnLBjh8MbIKCmkoktTMQoVjpslzIQnXvj3TFVcu5J/IrQI1L9Hb88Ik1hJPmKDi4fc7uvrRQnmr6IwCC40sE1mYUSYSIiaOG4D1Z2nijqVmqxuCNj8zOYytzyJJMfLmL6xA2ldP62XiEj4s7YoocvEjqsLxwRVUQoGXqOy21j3cbVM/lya+MGgazHBQ0PcBDNfvUsQqTiHPXreERWkf/jWgp1C+bAXfw01Pszf8w0W3vKmVh4aAb6+7LbEUNNY0vGIsa70VUIOPsAmukR6xcx305KnGYQDpp3WwmQEPGIHF7/1w7SMTEE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(55016003)(66446008)(8676002)(64756008)(26005)(76116006)(9686003)(38100700002)(38070700005)(8936002)(7696005)(52536014)(6506007)(33656002)(54906003)(66946007)(4326008)(66556008)(110136005)(5660300002)(83380400001)(66476007)(53546011)(86362001)(71200400001)(508600001)(2906002)(316002)(186003)(17413003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3910
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	32f19ebb-e43b-4c84-e165-08da21e720c7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ssD42tI6Pbd73vyAWkfTLVJNZz9jwR2r8L32+wFRfJFvM9tlYnfDzxoGWaGkZDJvWO75ZhoRgg1SB8GgZTrrgYGpONH9Kx+aTRKZcgDzGKwCZfNx/wtRWrxuZIX1FBGnW6oBVY8aNYelZtkKSTPloeZfxTBe4ILPILEv0O7gL/mBCziJS7qudvnIuf5cA5ywlCNM6Q3H534NRq9uU0xV6vOsfl1OLlc0yaL8oV6IE7OHxjc3/ldilNOpPojY/hZXHMDW2tW7hV1dnJwfrqb8amMdW3cGIkMgTtz6egKIeJNGjvsZXONxdIZhTdltNWD2wda40dXACQi1FDv1J4pITiAm+rNvRYbhpdpRLSF2uMiC2pCX0J7cYpH2mw3xkTPHZgJzB+ZaQqim5ARoxNAowMNh+nHEGGbvvpTlJd34yQDyLEMbXeQ5nRfFZQCw/zgz3Vj7bj3YbXzhVmbnkKfY4XbEK8yxMkd5iTKh4ksA5tH/v3zZhibTZDywtktZy2pDLBoG2nXR9ZbyZehAEUE+8gZ7vpcSaUaXBRQZmMsQKBp7w/12mZOlpSYvWt8goAs7mzaY706eGfikwf7zA7PUnLkrDrTJbtcMW/ZTPA8m0Gj1E1L9azCaNmPb8as7tIXw60bKse2pYLrCqIxIc+DocxXFbbAo1ayXreNbKooyQ4mRcUlUcaeAuGq3JZGmOBWMmNSnrYXkpQ9N6aQO4AyEXg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(356005)(81166007)(186003)(2906002)(7696005)(36860700001)(40460700003)(53546011)(52536014)(26005)(8936002)(5660300002)(498600001)(9686003)(6506007)(33656002)(4326008)(83380400001)(86362001)(55016003)(47076005)(336012)(54906003)(110136005)(107886003)(70206006)(8676002)(70586007)(82310400005)(17413003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:29:53.4415
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 79f99f35-6998-4be0-bfc7-08da21e728f3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3450

SGksDQoNCkkgYW0gc29ycnksIEkgaGFkIGFkZGVkIGEgd3JvbmcgYWRkcmVzcy0tdG89eGVuLWRl
dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQppbiB0aGlzIHNlcmllcycgcmVjaXBpZW50IGFkZHJl
c3MgYnkgbWlzdGFrZS4gV2hlbiB5b3UgcmVwbHkgdG8gdGhpcyBzZXJpZXMsDQpwbGVhc2UgcmVt
ZW1iZXIgdG8gcmVtb3ZlIGl0LiBJJ20gc29ycnkgZm9yIHRoZSBpbmNvbnZlbmllbmNlIGFnYWlu
IQ0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+
IEZyb206IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiBTZW50OiAyMDIyxOo01MIxOMjV
IDE3OjA3DQo+IFRvOiAtLXRvPXhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgeGVuLWRl
dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBuZCA8bmRAYXJtLmNvbT47IFdlaSBDaGVu
IDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBr
ZXJuZWwub3JnPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IEphbiBCZXVsaWNoDQo+
IDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIIHYyIDAwLzEwXSBEZXZpY2Ug
dHJlZSBiYXNlZCBOVU1BIHN1cHBvcnQgZm9yIEFybSAtIFBhcnQjMQ0KPiANCj4gKFRoZSBBcm0g
ZGV2aWNlIHRyZWUgYmFzZWQgTlVNQSBzdXBwb3J0IHBhdGNoIHNldCBjb250YWlucyAzNQ0KPiBw
YXRjaGVzLiBJbiBvcmRlciB0byBtYWtlIHN0dWZmIGVhc2llciBmb3IgcmV2aWV3ZXJzLCBJIHNw
bGl0DQo+IHRoZW0gaW50byAzIHBhcnRzOg0KPiAxLiBQcmVwYXJhdGlvbi4gSSBoYXZlIHJlLXNv
cnRlZCB0aGUgcGF0Y2ggc2VyaWVzLiBBbmQgbW92ZWQNCj4gICAgaW5kZXBlbmRlbnQgcGF0Y2hl
cyB0byB0aGUgaGVhZCBvZiB0aGUgc2VyaWVzLg0KPiAyLiBNb3ZlIGdlbmVyaWNhbGx5IHVzYWJs
ZSBjb2RlIGZyb20geDg2IHRvIGNvbW1vbi4NCj4gMy4gQWRkIG5ldyBjb2RlIHRvIHN1cHBvcnQg
QXJtLg0KPiANCj4gVGhpcyBzZXJpZXMgb25seSBjb250YWlucyB0aGUgZmlyc3QgcGFydCBwYXRj
aGVzLg0KPiBUaGUgZnVsbCBwYXRjaCBsaXN0IGNhbiBiZSBmb3VuZCBpbiB0aGlzIGNvdmVyIGxl
dHRlci4pDQo+IA0KPiBYZW4gbWVtb3J5IGFsbG9jYXRpb24gYW5kIHNjaGVkdWxlciBtb2R1bGVz
IGFyZSBOVU1BIGF3YXJlLg0KPiBCdXQgYWN0dWFsbHksIG9uIHg4NiBoYXMgaW1wbGVtZW50ZWQg
dGhlIGFyY2hpdGVjdHVyZSBBUElzDQo+IHRvIHN1cHBvcnQgTlVNQS4gQXJtIHdhcyBwcm92aWRp
bmcgYSBzZXQgb2YgZmFrZSBhcmNoaXRlY3R1cmUNCj4gQVBJcyB0byBtYWtlIGl0IGNvbXBhdGli
bGUgd2l0aCBOVU1BIGF3YXJlZCBtZW1vcnkgYWxsb2NhdGlvbg0KPiBhbmQgc2NoZWR1bGVyLg0K
PiANCj4gQXJtIHN5c3RlbSB3YXMgd29ya2luZyB3ZWxsIGFzIGEgc2luZ2xlIG5vZGUgTlVNQSBz
eXN0ZW0gd2l0aA0KPiB0aGVzZSBmYWtlIEFQSXMsIGJlY2F1c2Ugd2UgZGlkbid0IGhhdmUgbXVs
dGlwbGUgbm9kZXMgTlVNQQ0KPiBzeXN0ZW0gb24gQXJtLiBCdXQgaW4gcmVjZW50IHllYXJzLCBt
b3JlIGFuZCBtb3JlIEFybSBkZXZpY2VzDQo+IHN1cHBvcnQgbXVsdGlwbGUgbm9kZXMgTlVNQSBz
eXN0ZW0uDQo+IA0KPiBTbyBub3cgd2UgaGF2ZSBhIG5ldyBwcm9ibGVtLiBXaGVuIFhlbiBpcyBy
dW5uaW5nIG9uIHRoZXNlIEFybQ0KPiBkZXZpY2VzLCBYZW4gc3RpbGwgdHJlYXQgdGhlbSBhcyBz
aW5nbGUgbm9kZSBTTVAgc3lzdGVtcy4gVGhlDQo+IE5VTUEgYWZmaW5pdHkgY2FwYWJpbGl0eSBv
ZiBYZW4gbWVtb3J5IGFsbG9jYXRpb24gYW5kIHNjaGVkdWxlcg0KPiBiZWNvbWVzIG1lYW5pbmds
ZXNzLiBCZWNhdXNlIHRoZXkgcmVseSBvbiBpbnB1dCBkYXRhIHRoYXQgZG9lcw0KPiBub3QgcmVm
bGVjdCByZWFsIE5VTUEgbGF5b3V0Lg0KPiANCj4gWGVuIHN0aWxsIHRoaW5rIHRoZSBhY2Nlc3Mg
dGltZSBmb3IgYWxsIG9mIHRoZSBtZW1vcnkgaXMgdGhlDQo+IHNhbWUgZm9yIGFsbCBDUFVzLiBI
b3dldmVyLCBYZW4gbWF5IGFsbG9jYXRlIG1lbW9yeSB0byBhIFZNDQo+IGZyb20gZGlmZmVyZW50
IE5VTUEgbm9kZXMgd2l0aCBkaWZmZXJlbnQgYWNjZXNzIHNwZWVkcy4gVGhpcw0KPiBkaWZmZXJl
bmNlIGNhbiBiZSBhbXBsaWZpZWQgaW4gd29ya2xvYWRzIGluc2lkZSBWTSwgY2F1c2luZw0KPiBw
ZXJmb3JtYW5jZSBpbnN0YWJpbGl0eSBhbmQgdGltZW91dHMuDQo+IA0KPiBTbyBpbiB0aGlzIHBh
dGNoIHNlcmllcywgd2UgaW1wbGVtZW50IGEgc2V0IG9mIE5VTUEgQVBJIHRvIHVzZQ0KPiBkZXZp
Y2UgdHJlZSB0byBkZXNjcmliZSB0aGUgTlVNQSBsYXlvdXQuIFdlIHJldXNlIG1vc3Qgb2YgdGhl
DQo+IGNvZGUgb2YgeDg2IE5VTUEgdG8gY3JlYXRlIGFuZCBtYWludGFpbiB0aGUgbWFwcGluZyBi
ZXR3ZWVuDQo+IG1lbW9yeSBhbmQgQ1BVLCBjcmVhdGUgdGhlIG1hdHJpeCBiZXR3ZWVuIGFueSB0
d28gTlVNQSBub2Rlcy4NCj4gRXhjZXB0IEFDUEkgYW5kIHNvbWUgeDg2IHNwZWNpZmllZCBjb2Rl
LCB3ZSBoYXZlIG1vdmVkIG90aGVyDQo+IGNvZGUgdG8gY29tbW9uLiBJbiBuZXh0IHN0YWdlLCB3
aGVuIHdlIGltcGxlbWVudCBBQ1BJIGJhc2VkDQo+IE5VTUEgZm9yIEFybTY0LCB3ZSBtYXkgbW92
ZSB0aGUgQUNQSSBOVU1BIGNvZGUgdG8gY29tbW9uIHRvbywNCj4gYnV0IGluIGN1cnJlbnQgc3Rh
Z2UsIHdlIGtlZXAgaXQgYXMgeDg2IG9ubHkuDQo+IA0KPiBUaGlzIHBhdGNoIHNlcmlyZXMgaGFz
IGJlZW4gdGVzdGVkIGFuZCBib290ZWQgd2VsbCBvbiBvbmUNCj4gQXJtNjQgTlVNQSBtYWNoaW5l
IGFuZCBvbmUgSFBFIHg4NiBOVU1BIG1hY2hpbmUuDQo+IA0KPiAtLS0NCj4gUGFydDEgdjEtPnYy
Og0KPiAxLiBNb3ZlIGluZGVwZW5kZW50IHBhdGNoZXMgZnJvbSBsYXRlciB0byBlYXJseSBvZiB0
aGlzIHNlcmllcy4NCj4gMi4gRHJvcCB0aGUgY29weSBvZiBFRkkgc3R1Yi5jIGZyb20gQXJtLiBT
aGFyZSBjb21tb24gY29kZXMgb2YNCj4gICAgeDg2IEVGSSBzdHViIGZvciBBcm0uDQo+IDMuIFVz
ZSBDT05GSUdfQVJNX0VGSSB0byByZXBsYWNlIENPTkZJR19FRkkgYW5kIHJlbW92ZSBoZWxwIHRl
eHQNCj4gICAgYW5kIG1ha2UgQ09ORklHX0FSTV9FRkkgaW52aXNpYmxlLg0KPiA0LiBVc2UgQVNT
RVJUIHRvIHJlcGxhY2UgVklSVFVBTF9CVUdfT04gaW4gcGh5c190b19uaWQuDQo+IDUuIE1vdmUg
TUFYX05VTU5PREVTIGZyb20geGVuL251bWEuaCB0byBhc20vbnVtYS5oIGZvciB4ODYuDQo+IDYu
IEV4dGVuZCB0aGUgZGVzY3JpcHRpb24gb2YgQXJtJ3Mgd29ya2Fyb3VuZCBmb3IgcmVzZXJ2ZSBE
TUENCj4gICAgYWxsb2NhdGlvbnMgdG8gYXZvaWQgdGhlIHNhbWUgZGlzY3Vzc2lvbiBldmVyeSB0
aW1lIGZvcg0KPiAgICBhcmNoX2hhdmVfZGVmYXVsdF9kbWF6b25lLg0KPiA3LiBVcGRhdGUgY29t
bWl0IG1lc3NhZ2VzLg0KPiANCj4gV2VpIENoZW4gKDEwKToNCj4gICB4ZW4vYXJtOiBQcmludCBh
IDY0LWJpdCBudW1iZXIgaW4gaGV4IGZyb20gZWFybHkgdWFydA0KPiAgIHhlbi94ODY6IG1vdmUg
cmV1c2FibGUgRUZJIHN0dWIgZnVuY3Rpb25zIGZyb20geDg2IHRvIGNvbW1vbg0KPiAgIHhlbi9h
cm06IGFkZCBDT05GSUdfQVJNX0VGSSB0byBzdHViIEVGSSBBUEkNCj4gICB4ZW4vYXJtOiBLZWVw
IG1lbW9yeSBub2RlcyBpbiBkZXZpY2UgdHJlZSB3aGVuIFhlbiBib290cyBmcm9tIEVGSQ0KPiAg
IHhlbi94ODY6IFVzZSBBU1NFUlQgaW5zdGVhZCBvZiBWSVJUVUFMX0JVR19PTiBmb3IgcGh5c190
b19uaWQNCj4gICB4ZW46IGludHJvZHVjZSBhbiBhcmNoIGhlbHBlciBmb3IgZGVmYXVsdCBkbWEg
em9uZSBzdGF0dXMNCj4gICB4ZW46IGRlY291cGxlIE5VTUEgZnJvbSBBQ1BJIGluIEtjb25maWcN
Cj4gICB4ZW4vYXJtOiB1c2UgIUNPTkZJR19OVU1BIHRvIGtlZXAgZmFrZSBOVU1BIEFQSQ0KPiAg
IHhlbi94ODY6IHVzZSBwYWRkcl90IGZvciBhZGRyZXNzZXMgaW4gTlVNQSBub2RlIHN0cnVjdHVy
ZQ0KPiAgIHhlbi94ODY6IGFkZCBkZXRlY3Rpb24gb2YgbWVtb3J5IGludGVybGVhdmVzIGZvciBk
aWZmZXJlbnQgbm9kZXMNCj4gDQo+IFBBUlQyOg0KPiAgIHhlbi94ODY6IGludHJvZHVjZSBhIGhl
bHBlciB0byB1cGRhdGUgbWVtb3J5IGhvdHBsdWcgZW5kDQo+ICAgeGVuL3g4NjogVXNlIGVudW1l
cmF0aW9ucyB0byBpbmRpY2F0ZSBOVU1BIHN0YXR1cw0KPiAgIHhlbi94ODY6IG1vdmUgZ2VuZXJp
Y2FsbHkgdXNhYmxlIE5VTUEgY29kZSBmcm9tIHg4NiB0byBjb21tb24NCj4gICB4ZW4veDg2OiB1
c2UgYXJjaF9nZXRfbWVtb3J5X21hcCB0byBnZXQgaW5mb3JtYXRpb24gZnJvbSBFODIwIG1hcA0K
PiAgIHhlbi94ODY6IG1vdmUgTlVNQSBzY2FuIG5vZGVzIGNvZGVzIGZyb20geDg2IHRvIGNvbW1v
bg0KPiAgIHhlbi94ODY6IHJlbmFtZSBiYWRfc3JhdCB0byBudW1hX2JhZA0KPiANCj4gUEFSVDM6
DQo+ICAgeGVuOiByZW5hbWUgYWNwaV9zY2FuX25vZGVzIHRvIG51bWFfc2Nhbl9ub2Rlcw0KPiAg
IHhlbjogaW50cm9kdWNlIGEgS2NvbmZpZyBvcHRpb24gdG8gY29uZmlndXJlIE5VTUEgbm9kZXMg
bnVtYmVyDQo+ICAgeGVuL2FybTogdXNlIE5SX01FTV9CQU5LUyB0byBvdmVycmlkZSBkZWZhdWx0
IE5SX05PREVfTUVNQkxLUw0KPiAgIHhlbi9hcm06IGltcGxlbWVudCBoZWxwZXJzIHRvIGdldCBh
bmQgdXBkYXRlIE5VTUEgc3RhdHVzDQo+ICAgeGVuL2FybTogaW1wbGVtZW50IG5vZGUgZGlzdGFu
Y2UgaGVscGVycyBmb3IgQXJtDQo+ICAgeGVuL2FybTogdXNlIGFyY2hfZ2V0X21lbW9yeV9tYXAg
dG8gbWVtb3J5IGJhbmsgZnJvbSBib290aW5mbw0KPiAgIHhlbi9hcm06IGJ1aWxkIE5VTUEgY3B1
X3RvX25vZGUgbWFwIGluIGR0X3NtcF9pbml0X2NwdXMNCj4gICB4ZW4vYXJtOiBBZGQgYm9vdCBh
bmQgc2Vjb25kYXJ5IENQVSB0byBOVU1BIHN5c3RlbQ0KPiAgIHhlbi9hcm06IHN0dWIgbWVtX2hv
dHBsdWdfdXBkYXRlX2JvdW5kYXJ5IGZvciBBcm0NCj4gICB4ZW4vYXJtOiBpbnRyb2R1Y2UgYSBo
ZWxwZXIgdG8gcGFyc2UgZGV2aWNlIHRyZWUgcHJvY2Vzc29yIG5vZGUNCj4gICB4ZW4vYXJtOiBp
bnRyb2R1Y2UgYSBoZWxwZXIgdG8gcGFyc2UgZGV2aWNlIHRyZWUgbWVtb3J5IG5vZGUNCj4gICB4
ZW4vYXJtOiBpbnRyb2R1Y2UgYSBoZWxwZXIgdG8gcGFyc2UgZGV2aWNlIHRyZWUgTlVNQSBkaXN0
YW5jZSBtYXANCj4gICB4ZW4vYXJtOiB1bmlmaWVkIGVudHJ5IHRvIHBhcnNlIGFsbCBOVU1BIGRh
dGEgZnJvbSBkZXZpY2UgdHJlZQ0KPiAgIHhlbi9hcm06IGtlZXAgZ3Vlc3Qgc3RpbGwgYmUgTlVN
QSB1bndhcmUNCj4gICB4ZW4vYXJtOiBlbmFibGUgZGV2aWNlIHRyZWUgYmFzZWQgTlVNQSBpbiBz
eXN0ZW0gaW5pdA0KPiAgIHhlbi9hcm06IGltcGxlbWVudCBhIGR1bW15IDE6MSBub2RlIHRvIHB4
bSBtYXBwaW5nDQo+ICAgeGVuL2FybTogdXNlIENPTkZJR19OVU1BIHRvIGdhdGUgbm9kZV9vbmxp
bmVfbWFwIGluIHNtcGJvb3QNCj4gICB4ZW4vYXJtOiBQcm92aWRlIEtjb25maWcgb3B0aW9ucyBm
b3IgQXJtIHRvIGVuYWJsZSBOVU1BDQo+ICAgZG9jczogdXBkYXRlIG51bWEgY29tbWFuZCBsaW5l
IHRvIHN1cHBvcnQgQXJtDQo+IA0KPiAgeGVuL2FyY2gvYXJtL0tjb25maWcgICAgICAgICAgICAg
ICAgICAgIHwgIDUgKysNCj4gIHhlbi9hcmNoL2FybS9NYWtlZmlsZSAgICAgICAgICAgICAgICAg
ICB8ICAyICstDQo+ICB4ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5TICAgICAgICAgICAgICAgfCAx
MiArKy0tDQo+ICB4ZW4vYXJjaC9hcm0vYm9vdGZkdC5jICAgICAgICAgICAgICAgICAgfCAgOCAr
Ky0NCj4gIHhlbi9hcmNoL2FybS9lZmkvTWFrZWZpbGUgICAgICAgICAgICAgICB8ICA1ICsrDQo+
ICB4ZW4vYXJjaC9hcm0vZWZpL2VmaS1ib290LmggICAgICAgICAgICAgfCAyNSAtLS0tLS0tLS0N
Cj4gIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9udW1hLmggICAgICAgICB8ICA2ICsrDQo+ICB4
ZW4vYXJjaC94ODYvS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgfCAgMiArLQ0KPiAgeGVuL2Fy
Y2gveDg2L2VmaS9NYWtlZmlsZSAgICAgICAgICAgICAgIHwgIDQgKy0NCj4gIHhlbi9hcmNoL3g4
Ni9lZmkve3N0dWIuYyA9PiBzdHViLXg4Ni5jfSB8IDM3IC0tLS0tLS0tLS0tLS0NCj4gIHhlbi9h
cmNoL3g4Ni9pbmNsdWRlL2FzbS9jb25maWcuaCAgICAgICB8ICAxIC0NCj4gIHhlbi9hcmNoL3g4
Ni9pbmNsdWRlL2FzbS9udW1hLmggICAgICAgICB8IDE1ICsrLS0tDQo+ICB4ZW4vYXJjaC94ODYv
bnVtYS5jICAgICAgICAgICAgICAgICAgICAgfCAzMCArKysrKy0tLS0tDQo+ICB4ZW4vYXJjaC94
ODYvc3JhdC5jICAgICAgICAgICAgICAgICAgICAgfCA3NCArKysrKysrKysrKysrKysrKysrLS0t
LS0tDQo+ICB4ZW4vY29tbW9uL0tjb25maWcgICAgICAgICAgICAgICAgICAgICAgfCAgMyArDQo+
ICB4ZW4vY29tbW9uL2VmaS9zdHViLmMgICAgICAgICAgICAgICAgICAgfCAzOCArKysrKysrKysr
KysrDQo+ICB4ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYyAgICAgICAgICAgICAgICAgfCAgMiArLQ0K
PiAgeGVuL2RyaXZlcnMvYWNwaS9LY29uZmlnICAgICAgICAgICAgICAgIHwgIDMgKy0NCj4gIHhl
bi9kcml2ZXJzL2FjcGkvTWFrZWZpbGUgICAgICAgICAgICAgICB8ICAyICstDQo+ICB4ZW4vaW5j
bHVkZS94ZW4vbnVtYS5oICAgICAgICAgICAgICAgICAgfCAgMiArDQo+ICAyMCBmaWxlcyBjaGFu
Z2VkLCAxNjIgaW5zZXJ0aW9ucygrKSwgMTE0IGRlbGV0aW9ucygtKQ0KPiAgcmVuYW1lIHhlbi9h
cmNoL3g4Ni9lZmkve3N0dWIuYyA9PiBzdHViLXg4Ni5jfSAoNzElKQ0KPiAgY3JlYXRlIG1vZGUg
MTAwNjQ0IHhlbi9jb21tb24vZWZpL3N0dWIuYw0KPiANCj4gLS0NCj4gMi4yNS4xDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 09:39:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 09:39:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307964.523394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkKD-0001V4-7Y; Tue, 19 Apr 2022 09:39:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307964.523394; Tue, 19 Apr 2022 09:39:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkKD-0001Ux-4E; Tue, 19 Apr 2022 09:39:09 +0000
Received: by outflank-mailman (input) for mailman id 307964;
 Tue, 19 Apr 2022 09:39:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngkKB-0001Ur-Ub
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:39:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e5ecdd3-bfc4-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 11:39:06 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-OTSCuYS-NNO6nJgkuH7isA-1; Tue, 19 Apr 2022 11:39:05 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR0402MB3651.eurprd04.prod.outlook.com (2603:10a6:208:5::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 09:39:03 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 09:39:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e5ecdd3-bfc4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650361146;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=8IB4UsuGr6nOaXGYqGr/XjpHpdc46ZSgT5vo4vAcxZc=;
	b=IdN+qkH4arxPtJ9ChOlSCxwZt8UrFDqxkMq3MZZTrYKG66zX3XRFRgzu8LYuCB6zhizGsu
	YelOhKDjDhY/rqkKzKN1aZNia2dRkULwQx3QzXXiD+GlDG0iFf1Pu70fHsk4Vu1QLd9oUM
	UkyUpbT5TUYZH5BwwIecMlD2g19PFao=
X-MC-Unique: OTSCuYS-NNO6nJgkuH7isA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=StD1eZnyjb8BemLR6ngAYb6foIajHvliufCCoquI+mvgBgebV/imiRAQrUfJciXl8RNCr+QN/CkHcWAtsVEdTWITL3euEuFpkCAktEZB4BQgFSBXLuRXV+JcS7WFW3GejnESNnnJeZQzZEE+Eb6shopfw2QEAaMYTbl9Kf7Cb88RME4K6hYFc7L0W/00zt7534w/ZX+/2i/U+mr82WpAKr92cRdMaccqGK+yZ6iXEog2JO1v3Px931LVypPf/Idy+fappN2uuXIBPJnHmVxns9Ilj0Yqd0Gm0Bf4HUNooa3kWv5i/MBoCN9m4PKyDSW30HBPepPW9wFN8LXMyLEmJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8IB4UsuGr6nOaXGYqGr/XjpHpdc46ZSgT5vo4vAcxZc=;
 b=aACtUyXWtZJNOSYXjfSUjhhnTdxAzdh8mmA18jDnC2CZNdHDpcdjRqlHGcwlwHvpHBIP0DpObteM4uud3owc1+Uz4f9GmSGDE/hwba2ALsd0aEzB2gcqDYxG/LzpUEnQpjpVzMiZOf2RYwUdzRdap7Srsq8i3fTlKP+WsiRC0oJS4oPjbS6nFbJnKGYPYxuk5ROAbAzdV93YvrRHcA/b11rdZDcve14nIUGDYKETsc5ECya9zJKLMTBoU2QltKuBks66ksAPTZK5qr7ylV52kBHp09mwbtqvP4kr4OSf7NAHYHtYr7bve4cdzoOj9/9j6oLyybZxKaOghRy+hqR0Ww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
Date: Tue, 19 Apr 2022 11:39:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0038.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0f4e531e-6833-4ec8-aea1-08da21e870d4
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3651:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3651532604D2A5D82AE98DB0B3F29@AM0PR0402MB3651.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	f8u/jEM1GHsM3cIXqDwtKtZz2fK/i7vkinR+JBadogJaQGoDsiwj0FQyruYpnmCZUQ51BxAFddi31mYMBNP6TywVOxfmTwo5XU4DvVthqRbADMA4DqosTmBSLwgkKZtOPj9a3BIFWBQ+rGyNtyP0h1HnXKU8QtWlKzWPTK+/MbOj7ktNWOzjWm1jJdx+JX5PRRdrpFGR09OeUAtO1caBsFL+mFjmOGVi161761uXtekK52IaAp77GQaw33RenDvC9iOdpjrqlOqilPjiF93YFpzEQltgMexU+IDqPkpR5Jrtnh0qyFxBY5hIRySxnFj3Fv6tt8Ll5bjJHBeKffb+3UvUgIanlQ48xQYwpZUNbH8xnexaJZ2eLgnAfbfyhT9yMdR6eqm1Aj8Xs47KaQfKIRgxKtKSu/I7hu4sx9AKubcpcx+R8i3l2/d3LoBd1aB7IbvPyOp+PuSqtAVPBR0Y6A0gKIBekHLzJYedfLjp0GVa+jBMJMyHGxcnON40HkU79HC5R1yqYC7cyebTdwdOcOlcMP7l6VJ2QgYUFmVcZM7h7fWBjYwzFOYDV/sBJnZ7SJ9ffhCvSRaSqV34BQt+C9ZCo3v9aV8lUNSboeT1QBxPFUdR9PdSHN61vE7Q6GyLDi8tmT/T89giNsMBfQU5Ib47UUo15WND/QgsdvYGzLz01fUIxwZZCLI7/0Bfnd0hpc8Mph4VSqzSdM1F5nrk5SWFGesZGKI6LVFpTZ2zeAo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(66476007)(66946007)(6512007)(38100700002)(2906002)(6506007)(508600001)(6486002)(26005)(36756003)(8676002)(66556008)(6916009)(186003)(4326008)(5660300002)(4744005)(86362001)(8936002)(2616005)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VWVvRDI1K2FrdVAxOXAyTXZqazFEalJyTkhtUGRKYmpKTFd4MnROWDVyQmpo?=
 =?utf-8?B?OHhEZmRwMWhVeDg1YnE5blpWS1ViK3M3c2NxaGt5aTIvN1RtL2E4NytkSE9M?=
 =?utf-8?B?alpqeStta2toanhKbU9IVysrNlhFeThLbmNRSG9qcXUvVlBxazc0TFo5MEVG?=
 =?utf-8?B?RlhSdzYvMDRuNnVVY0xJRFR3VjN0TXVrbFhvS1RIZllPOW81YUZuNjRMWWY5?=
 =?utf-8?B?UC9LcWx2dWlDQzY4ekFUQ3JzNGMreDBNeE50by9jL0tCUXNVMWJwcVYxVFB0?=
 =?utf-8?B?ZVFHVXVDbEF2MHNoalVOZ1EzMDJIYWdHejZhaU0wcmZyZ2RqRG9FRjY2d0Fu?=
 =?utf-8?B?SVhSR01IMHEzeUJHTFZidU1nSDZuMHlzQlRuTTh3Q2Q5MlV4TGxZb0s5QXlO?=
 =?utf-8?B?SEQyK2ljVCsvNm95WWZ3eTl2Q3lmWHpNMkN5ODFLSTFXMnFqREdqU213Tjlx?=
 =?utf-8?B?UUZnMW5GY2N5eVUxYjc4MEpmdzdCL1ZDalIweUYyOHlNMFRlaEIwUk9rODJm?=
 =?utf-8?B?SkVreGNWV1k2WlBqQm1uclNBYlBwcHdpNFFDdUhJRzlkelN4Ulc5dXNQQUhl?=
 =?utf-8?B?T2M3bzAxYWtnWWQ2VHZ6bmZUMFVoR3R6TEF4RDN6NFdBbFJzZmRUekhObFZ1?=
 =?utf-8?B?eHVDQ3pPSmVGR2k2dnJiUkgwOElGdEs4S3Rvc1lTWVp1NjlYOG9FSld0Z3hu?=
 =?utf-8?B?aWNwTkhIdlh0Z0l3NnRDZ2xVVGlWaDF1bEh0QmNqa25FeCsrSkJGVHNPdU9Y?=
 =?utf-8?B?ZmNEalA3UkFUZkU5cE5qckh6c0RNdTlSeWNSbkR1b0VPY1lXQyszSlI2MmY3?=
 =?utf-8?B?aGNYWHZjZzNFS1kwRFQ4bUM0NDlUazA1YS9GUWZyVmVTZExoR0xXUUZBbkZt?=
 =?utf-8?B?ZUFseHo2ZkUzRWVwSkpaOG51YWE1ZzgrNlB1RGJGRktybnRhdmMzR0VDTDV0?=
 =?utf-8?B?NWsxdGhBWCs3VUxGNms1QnFpTzNaZ3BjSUdtT0JIRlJvZ1BzbkxIREFiK1Rp?=
 =?utf-8?B?T25SYXRLTktZaDYrYklGUjRyRE81MXpyK1gwSG5jbUthcWRMVmx5ZWl1V2t1?=
 =?utf-8?B?c0s2L01INXltMCtNajhOWEE1RWduSktvR2h0SGRmQ3pzSnJyTTZTRFhWNFVI?=
 =?utf-8?B?KzI0OFBJb1dYZDZNU2QvcTRlKzFwVGthUGxkbitzUFJVYWFqc2VqSUFuRUxV?=
 =?utf-8?B?MmNGQldQWmhMd1VVVHV3ay91T2RIWUNPTW82bnBxOFloZnZYTWVIMStZUm9o?=
 =?utf-8?B?alVBaXduSlNSeThkSXZHRVFsR3lnRzN2MXNyYWtoOUZqempEc0s0Ty8rL1Zw?=
 =?utf-8?B?bzZaRmFROFRHNmltU21UQkdOZmY0eWVQaDg3TERwdWRVYUhRUnlFb1pKbktP?=
 =?utf-8?B?RzZ4SGppQ09LSEY2MS9tSVFwVktzdHBvT1BtUmR4ZkxCWGJtTDEyWTg5RzRC?=
 =?utf-8?B?NzY2RnZSNmpiQ0V5TWdzMlJISkVid0pSKytzdEROYmJyd0hMNWxTTVRCTFZL?=
 =?utf-8?B?dDl5SXYyQkdDZG5kbThWRjlSMUxtQnU0bThvalpOOXkrTVZSdGtJQ1Zrb29m?=
 =?utf-8?B?NnVPSnVIQkQrcWZhSm50RmMwUmxDMDE4aDNKa3ErUE9qRXg2WnFyb1JOQXZq?=
 =?utf-8?B?MGF6eEdkbmc1L3NLdjk2UFhJUlJncmd1bUJsZFZsVDI0VU5yTFJIcyt1UG1p?=
 =?utf-8?B?WnZsSTBlYjd4MnRSSlhhWWFra0dIN3RjdXR1eXoySHZnMzVhTU4rTzBOanVz?=
 =?utf-8?B?OVY2K2VwQWVpZjZlblM3eTJLYzNadlRDc01DNTZhZExFeC9lVVlPQ09weFVL?=
 =?utf-8?B?MVNpcGRveVRIdVlJNXRncUdIaVI5b3BEQjk5Tjh3TjlOR1NUenh5eUFKVXZY?=
 =?utf-8?B?and2dzZhV2RlOGxLYndnNDU1UktNekZRdDZpRlEzSkhOTnpxa3J1OXV0VkxS?=
 =?utf-8?B?NXREOXo0RkZnZ3BGSmVnQUNyZS9JSWRiQWk0c2prOTBJY25zL1B5RWx1RFZE?=
 =?utf-8?B?WnhFbnBlUXpvRVQxSkhiRitQZHFkRit6cElScVBWYkFXYkVrVW96K0Y1emp0?=
 =?utf-8?B?Q3RPbTUzSDdxMUNYVXl5K3BVRjFUU1V4VWZpMXhDamdjZGZPbkhzaGlxTXFs?=
 =?utf-8?B?VUJ1VFZ1aU9jdDNoSWFLbTV3K1ZKY1hmeERUMFBBYS90UVlFR1RIRUQrZVJx?=
 =?utf-8?B?Z0lDbEdTd1lQUjNjYk43bkg2emJvSGdjUE4wbUN4Uyt3c0NKM2U2b0pVSjZt?=
 =?utf-8?B?d2ZUdDlZODNoSmIxc3ZxNzRIWHFScktrMjJzNWt6UVM3aXlGR0s3QWM0NDg4?=
 =?utf-8?B?ZndJT0I1VjZEalA0S3p4Y3VjYVQrQlRsQk5TeE5sSmVTL09ZQTNvZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f4e531e-6833-4ec8-aea1-08da21e870d4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:39:03.7181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SevL1HqaIJCJjpBwBNUpV9UG5HTxPe42h7UGruPtd6gnC7f/dxCO3UPzd215FsOeGNcAN5KIgHd9zRQisjeGAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3651

Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX,
XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed
here, when the domctl was passed DOMID_INVALID.

Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...")
Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -558,7 +558,7 @@ int iommu_do_domctl(
 {
     int ret = -ENODEV;
 
-    if ( !is_iommu_enabled(d) )
+    if ( !(d ? is_iommu_enabled(d) : iommu_enabled) )
         return -EOPNOTSUPP;
 
 #ifdef CONFIG_HAS_PCI



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:06:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:06:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307969.523405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkku-0005Cw-MY; Tue, 19 Apr 2022 10:06:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307969.523405; Tue, 19 Apr 2022 10:06:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkku-0005Cp-IK; Tue, 19 Apr 2022 10:06:44 +0000
Received: by outflank-mailman (input) for mailman id 307969;
 Tue, 19 Apr 2022 10:06:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RCdx=U5=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1ngkks-0005Cj-Uo
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:06:43 +0000
Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com
 [2a00:1450:4864:20::32c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 68bee55c-bfc8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 12:06:41 +0200 (CEST)
Received: by mail-wm1-x32c.google.com with SMTP id
 o20-20020a05600c511400b0038ebbbb2ad8so1154572wms.0
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 03:06:41 -0700 (PDT)
Received: from [10.7.237.14] (54-240-197-231.amazon.com. [54.240.197.231])
 by smtp.gmail.com with ESMTPSA id
 i7-20020a5d5587000000b00207a8cde900sm12105557wrv.19.2022.04.19.03.06.39
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 03:06:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68bee55c-bfc8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=3mt7mOFZJb2BomB+X9UDKgv1Z1dwvs1e1sh0ADJD7TE=;
        b=mIjPoARufNtPdPLvLJT4F7c6A68GsVVgOruZfbtD4sLmZBmRt9yoIPCstihc91juUv
         c7vNRnHUJB3+qoVFM2SEceNgTZAQ3eu8+ZqwEhj7/LBbGdbqgaxDsNc2mjKYNnBDY8DK
         hmANgfuUBz5xpW1IWO6I9x/nkuSSY1QynNiXY+kIMEH0k8P0X+857YbJKEqiFg6LjOvP
         8APTRLtaWT7T9fMvUw6p4Toeu0gy4Ui3TGcAbrda2fWENSfO5ok9rXAKkaUb+UlmLZuT
         JOTcpCgzzgILqblHcqeBCTxH/u3UbfsbWKuFniIFHNObP9JXxuFgwU9lVFPYkXxv7tYP
         UVWg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=3mt7mOFZJb2BomB+X9UDKgv1Z1dwvs1e1sh0ADJD7TE=;
        b=5CPz+f6sW8+7JRJcFQXZ8vl7671X3U+rH9i/3fUuuQAaX7ZwFsc1oYV8U3Sc6r1GBJ
         7YbyKcqghvdU2rHZ01iSqt9+pYB+b4RmMWkEXxIf9slBgWkHW755g7Ze85CH7YPr6OBk
         r5Mjb6zqkbjHFvj8gjHLdY09G3KEGrmJuO3G/YR9eKq4ioBkJSeBXkFOBuh5qGxjkdV1
         66sWts2i5c1cnEknqemkxKazkA77zivJqMElxOLLHnJd22bXudyjMoh++wowl4sqNIOF
         VeyOR6XE5RApR+FFfHGZm2zT1FtN79BYCe/ZV1VpExpIMrXiFGIL5A+XBZUCUSC5JFOv
         naSA==
X-Gm-Message-State: AOAM532zuE1a31nOB1VWwxLv8mQtzPa7MfxYaSrlAezgkXKOhgra+mVl
	KhOBVGoGmyBwg4oNYpTTzdM=
X-Google-Smtp-Source: ABdhPJxXEXNVcE0YvhDx0cTraXOy56bdxwUACJi/7OtqmN+4UWPij4JIgJKdEiqNZbvotUJpbF8UZg==
X-Received: by 2002:a1c:7408:0:b0:38e:b7af:c503 with SMTP id p8-20020a1c7408000000b0038eb7afc503mr19301922wmc.58.1650362800997;
        Tue, 19 Apr 2022 03:06:40 -0700 (PDT)
Message-ID: <c97c6909-83f9-fbde-21aa-ce027c4a653e@gmail.com>
Date: Tue, 19 Apr 2022 11:06:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Reply-To: paul@xen.org
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 19/04/2022 10:39, Jan Beulich wrote:
> Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX,
> XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed
> here, when the domctl was passed DOMID_INVALID.
> 
> Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...")
> Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:08:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:08:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307972.523416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkmN-0005kh-2D; Tue, 19 Apr 2022 10:08:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307972.523416; Tue, 19 Apr 2022 10:08:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkmM-0005ka-Tx; Tue, 19 Apr 2022 10:08:14 +0000
Received: by outflank-mailman (input) for mailman id 307972;
 Tue, 19 Apr 2022 10:08:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngkmM-0005kQ-AX
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:08:14 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f7cc078-bfc8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 12:08:13 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id F3ED12112B;
 Tue, 19 Apr 2022 10:08:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D84C7132E7;
 Tue, 19 Apr 2022 10:08:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ycqRMwyKXmI3JwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 10:08:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f7cc078-bfc8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650362893; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Zd7lV449emOdPR1cf2NdRZtyY+Tg4aSmhBI3JXmL61c=;
	b=C4JilPmG5tV3dUCSW+h5gDqv+E227bwmipBHRbNc7K97MOOKJGF0RtInrZkJ3BGY2JRC78
	4FbJMxHMOj2BllQM4Ei7agtLPDLH+dexHbq5dDBYhJmYI4kpXBi/7PxvDRjhIqy/GcAAvR
	WAHbHhWETDyQW70r4TMfYQFKtfyqRx0=
Message-ID: <df5ffed0-bdba-dd8b-ec79-5ad45d9263cb@suse.com>
Date: Tue, 19 Apr 2022 12:08:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------rbkquxGP6ItAapPNUMhhEj2z"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------rbkquxGP6ItAapPNUMhhEj2z
Content-Type: multipart/mixed; boundary="------------2zvC9NN1KEmQ0wvW5pd003i0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>
Message-ID: <df5ffed0-bdba-dd8b-ec79-5ad45d9263cb@suse.com>
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
In-Reply-To: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>

--------------2zvC9NN1KEmQ0wvW5pd003i0
Content-Type: multipart/mixed; boundary="------------4vetR5DqWMKcD4Ww9nbJY7IM"

--------------4vetR5DqWMKcD4Ww9nbJY7IM
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMDQuMjIgMTE6MzksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBCZXNpZGVzIHRoZSBy
ZXBvcnRlcidzIGlzc3VlIG9mIGhpdHRpbmcgYSBOVUxMIGRlcmVmIHdoZW4gIUNPTkZJR19H
REJTWCwNCj4gWEVOX0RPTUNUTF90ZXN0X2Fzc2lnbl9kZXZpY2UgY2FuIGxlZ2l0aW1hdGVs
eSBlbmQgdXAgaGF2aW5nIE5VTEwgcGFzc2VkDQo+IGhlcmUsIHdoZW4gdGhlIGRvbWN0bCB3
YXMgcGFzc2VkIERPTUlEX0lOVkFMSUQuDQo+IA0KPiBGaXhlczogNzFlNjE3YTZiOGY2ICgi
dXNlIGlzX2lvbW11X2VuYWJsZWQoKSB3aGVyZSBhcHByb3ByaWF0ZS4uLiIpDQo+IFJlcG9y
dGVkLWJ5OiBDaGV5ZW5uZSBXaWxscyA8Y2hleWVubmUud2lsbHNAZ21haWwuY29tPg0KPiBT
aWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmll
d2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K

--------------4vetR5DqWMKcD4Ww9nbJY7IM
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------4vetR5DqWMKcD4Ww9nbJY7IM--

--------------2zvC9NN1KEmQ0wvW5pd003i0--

--------------rbkquxGP6ItAapPNUMhhEj2z
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJeigwFAwAAAAAACgkQsN6d1ii/Ey+i
awgAgqS2VuLWfDPdjRdzRwiRUYFeAyK7peDUUrTDJi2n/hxp2oMYHUiWo+uEKgrinsuOAe9VYqGq
THWzfeSgKoHW+p6oLD2xc97BUnzHOtaCM6w//3qzutEjSqxAxVYbnsy4IU2y+dKCNTguKGmqhwvS
3I/r2Iy45WUs21wUq7gm1h1gBwkMx2lVhBkrpzCa2IE/awhrUCjSQeMce4TOJhEI6dp2S66L1y8d
OduGafwxz61hBo+tMLDBnriGlpFImPK530gdNnsC2+u0Zkn19/d06fjr6DRA5m4hvfAO38W+Vija
ZowMiIk6uM2M6L5RNUT5DLgy2qyEmvSDKaghfRZFlA==
=nVYy
-----END PGP SIGNATURE-----

--------------rbkquxGP6ItAapPNUMhhEj2z--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:16:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:16:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307978.523427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkuW-0007M4-TG; Tue, 19 Apr 2022 10:16:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307978.523427; Tue, 19 Apr 2022 10:16:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkuW-0007Lx-Q1; Tue, 19 Apr 2022 10:16:40 +0000
Received: by outflank-mailman (input) for mailman id 307978;
 Tue, 19 Apr 2022 10:16:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngkuV-0007Ln-J6; Tue, 19 Apr 2022 10:16:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngkuV-0003lI-HN; Tue, 19 Apr 2022 10:16:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngkuV-0005WE-9l; Tue, 19 Apr 2022 10:16:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngkuV-0000F9-9H; Tue, 19 Apr 2022 10:16:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XBmzPztEUDcidJKwRCREQlMV+SSEdGETHfKvijJ6x+Y=; b=LG0sl1mJjbPRmEajYunE6avbZU
	AThC+Baf6CYxEi/SzmXK9XUbvWk8wdVgO1yPK75qQzqZvUlVLFbA6Mq3CroYGVsisaTw26lkcFBK1
	l2F3Tgd47Mvk/z0B/iFfYS3GzDFmxDzGaqE6/rlky2aRX+VcD5tAGT/OYQnmO4rEY1nQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169536-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169536: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 10:16:39 +0000

flight 169536 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169536/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   49 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  503 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:18:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:18:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307986.523437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkwj-0007xC-Ag; Tue, 19 Apr 2022 10:18:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307986.523437; Tue, 19 Apr 2022 10:18:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngkwj-0007x5-7D; Tue, 19 Apr 2022 10:18:57 +0000
Received: by outflank-mailman (input) for mailman id 307986;
 Tue, 19 Apr 2022 10:18:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngkwh-0007wz-Ny
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:18:55 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d9d986b-bfca-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 12:18:54 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0F8AE1F38D;
 Tue, 19 Apr 2022 10:18:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B9A3F139BE;
 Tue, 19 Apr 2022 10:18:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 26m7K42MXmKFLAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 10:18:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d9d986b-bfca-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650363534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=v0gLa5Y6O/P0/0TgCgwdis7Q/sd27l3CARbbhyx3ybA=;
	b=rxbKx9DmOjNjtcqeYKjgoGD6jNWse7Ro5GquN5m+ylvHS0BTI7vRvJQk1lCRB0HnxTdeDr
	qn1ZS+kRrKJihML5GWKtqB44m+UqjyTn/LuhDVaWAQLJuCV8BWaAK2+M0f3EHZFw6qPbqz
	I/Ymxsk3ceKee8G4fky4hxR7fdo2Kw8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Elena Ufimtseva <elena.ufimtseva@oracle.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Cheyenne Wills <cheyenne.wills@gmail.com>
Subject: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Date: Tue, 19 Apr 2022 12:18:50 +0200
Message-Id: <20220419101850.3045-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

A hypervisor built without CONFIG_GDBSX will crash in case the
XEN_DOMCTL_gdbsx_guestmemio domctl is being called, as the call will
end up in iommu_do_domctl() with d == NULL:

(XEN) CPU:    6
(XEN) RIP:    e008:[<ffff82d040269984>] iommu_do_domctl+0x4/0x30
(XEN) RFLAGS: 0000000000010202   CONTEXT: hypervisor (d0v0)
(XEN) rax: 00000000000003e8   rbx: ffff830856277ef8   rcx: ffff830856277fff
...
(XEN) Xen call trace:
(XEN)    [<ffff82d040269984>] R iommu_do_domctl+0x4/0x30
(XEN)    [<ffff82d04035cd5f>] S arch_do_domctl+0x7f/0x2330
(XEN)    [<ffff82d040239e46>] S do_domctl+0xe56/0x1930
(XEN)    [<ffff82d040238ff0>] S do_domctl+0/0x1930
(XEN)    [<ffff82d0402f8c59>] S pv_hypercall+0x99/0x110
(XEN)    [<ffff82d0402f5161>] S arch/x86/pv/domain.c#_toggle_guest_pt+0x11/0x90
(XEN)    [<ffff82d040366288>] S lstar_enter+0x128/0x130
(XEN)
(XEN) Pagetable walk from 0000000000000144:
(XEN)  L4[0x000] = 0000000000000000 ffffffffffffffff
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 6:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=0000]
(XEN) Faulting linear address: 0000000000000144

Fix this issue by modifying the interface of gdbsx_guest_mem_io() to
take the already known domain pointer instead of the domid.

Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
Fixes: e726a82ca0dc ("xen: make gdbsx support configurable")
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- use gdbsx_guest_mem_io() interface modification (Jan Beulich)
---
 xen/arch/x86/debug.c                | 10 ++--------
 xen/arch/x86/domctl.c               |  6 +++---
 xen/arch/x86/include/asm/debugger.h |  2 +-
 xen/common/domctl.c                 |  1 -
 4 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/xen/arch/x86/debug.c b/xen/arch/x86/debug.c
index d90dc93056..c0dd6eaf15 100644
--- a/xen/arch/x86/debug.c
+++ b/xen/arch/x86/debug.c
@@ -159,17 +159,11 @@ static unsigned int dbg_rw_guest_mem(struct domain *dp, unsigned long addr,
  * Returns: number of bytes remaining to be copied.
  */
 unsigned int dbg_rw_mem(unsigned long gva, XEN_GUEST_HANDLE_PARAM(void) buf,
-                        unsigned int len, domid_t domid, bool toaddr,
+                        unsigned int len, struct domain *d, bool toaddr,
                         uint64_t pgd3)
 {
-    struct domain *d = rcu_lock_domain_by_id(domid);
-
-    if ( d )
-    {
-        if ( !d->is_dying )
+    if ( d && !d->is_dying )
             len = dbg_rw_guest_mem(d, gva, buf, len, toaddr, pgd3);
-        rcu_unlock_domain(d);
-    }
 
     return len;
 }
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index e49f9e91b9..a6aae500a3 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -38,10 +38,10 @@
 #include <asm/cpuid.h>
 
 #ifdef CONFIG_GDBSX
-static int gdbsx_guest_mem_io(domid_t domid, struct xen_domctl_gdbsx_memio *iop)
+static int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop)
 {
     iop->remain = dbg_rw_mem(iop->gva, guest_handle_from_ptr(iop->uva, void),
-                             iop->len, domid, iop->gwr, iop->pgd3val);
+                             iop->len, d, iop->gwr, iop->pgd3val);
 
     return iop->remain ? -EFAULT : 0;
 }
@@ -828,7 +828,7 @@ long arch_do_domctl(
 #ifdef CONFIG_GDBSX
     case XEN_DOMCTL_gdbsx_guestmemio:
         domctl->u.gdbsx_guest_memio.remain = domctl->u.gdbsx_guest_memio.len;
-        ret = gdbsx_guest_mem_io(domctl->domain, &domctl->u.gdbsx_guest_memio);
+        ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
         if ( !ret )
            copyback = true;
         break;
diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/arch/x86/include/asm/debugger.h
index 99803bfd0c..221bcde137 100644
--- a/xen/arch/x86/include/asm/debugger.h
+++ b/xen/arch/x86/include/asm/debugger.h
@@ -94,7 +94,7 @@ static inline bool debugger_trap_entry(
 
 #ifdef CONFIG_GDBSX
 unsigned int dbg_rw_mem(unsigned long gva, XEN_GUEST_HANDLE_PARAM(void) buf,
-                        unsigned int len, domid_t domid, bool toaddr,
+                        unsigned int len, struct domain *d, bool toaddr,
                         uint64_t pgd3);
 #endif
 
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 57135d4478..5879117580 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -308,7 +308,6 @@ long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
         if ( op->domain == DOMID_INVALID )
         {
     case XEN_DOMCTL_createdomain:
-    case XEN_DOMCTL_gdbsx_guestmemio:
             d = NULL;
             break;
         }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:26:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:26:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307991.523449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngl3c-00015y-3W; Tue, 19 Apr 2022 10:26:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307991.523449; Tue, 19 Apr 2022 10:26:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngl3b-00015p-VF; Tue, 19 Apr 2022 10:26:03 +0000
Received: by outflank-mailman (input) for mailman id 307991;
 Tue, 19 Apr 2022 10:26:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dnw2=U5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1ngl3a-00015h-DF
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:26:02 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on062a.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::62a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1b3fd899-bfcb-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 12:26:00 +0200 (CEST)
Received: from DB6PR07CA0002.eurprd07.prod.outlook.com (2603:10a6:6:2d::12) by
 DB7PR08MB2969.eurprd08.prod.outlook.com (2603:10a6:5:20::18) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.18; Tue, 19 Apr 2022 10:25:42 +0000
Received: from DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2d:cafe::73) by DB6PR07CA0002.outlook.office365.com
 (2603:10a6:6:2d::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Tue, 19 Apr 2022 10:25:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT054.mail.protection.outlook.com (10.152.20.248) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 10:25:42 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Tue, 19 Apr 2022 10:25:42 +0000
Received: from 3a8d0aa3c415.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 93EADB2D-8C2B-432D-A399-BC55FC0B3E35.1; 
 Tue, 19 Apr 2022 10:25:33 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3a8d0aa3c415.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Apr 2022 10:25:33 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by AM9PR08MB6228.eurprd08.prod.outlook.com (2603:10a6:20b:281::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 10:25:28 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%7]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 10:25:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b3fd899-bfcb-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LPi+q1CWGCQhQUPBbqMq308QQMXez93yaYQSelWo0RA=;
 b=KQ38EmdY6Nc+lPSkumyKelbxsqrnZtkwtC8B9X6SvQGmmctZca6MFqKzrmFgUsr2xZOVWRF9AV3qEjuK3MaTP27x55pLChCPXT6T0iiGnQH61IG4LAqPFiR6lwbbFC7bUrSnFPN0OBB8DrnlneST9XxPZaRYfhI96uylRIR7eWA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nKbFJLhideQu+Y9LBmYGxILC98h/IKzOZncLf58icfTa80W+KYc/+fQ+0/lZ1xM4z4ILZ0XjayOv2EkDu77kTxVKgRT/Wn7KBYyCZZvzV6Avky+HNhVmaEfcYMX2s+6XxvBi37EA8ob7TvdKD3js1E+rlFz3rrVcXi1896ChvEt8Q9gLkB9SsGeFSKw4JTa7z9sGN9hH6pRKVNp/hd03cXnkamNLSv2wulA0xkhQmO7B3JaKxDUY28+oVaq9MVyx1uqRH1akHFH5biVEOhMdma5KONLNniH6yZO5iHHN1uiMuU3WvusD7WhX0PGPFkVwsMukcDewAFeDQ8vj63fofw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LPi+q1CWGCQhQUPBbqMq308QQMXez93yaYQSelWo0RA=;
 b=ExidRzMK93GLpD2fspkWmhylUdWcoAbBJ3Fqq575ilnrXBf4m6SH6rcoNDv+TIX6x9/Ox/xaOKNKgFemgwdT372T3A4kJ9gGEopHayqfLN+DHDRhEhfSNJLfVgxdkcYDa+IXFoTE6nr++lrL4Zxz91uYxpnCfKNxUZwkyjI5MDOE7txcdujRUjzmzOprg1z53MK+ACGhd83eFqm/o945n7XjGsm9uIJ5Noluzn0/wNDRv9LH6/Qc2IiDoXSeROEgZj11wkqBFDtihsR+IEe+rO/qhdA2GjFwSpU8TDBpSj6xZnanxJ1cOnGCfCYtzm2mafnkMg+9B7DPtcNT418BlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LPi+q1CWGCQhQUPBbqMq308QQMXez93yaYQSelWo0RA=;
 b=KQ38EmdY6Nc+lPSkumyKelbxsqrnZtkwtC8B9X6SvQGmmctZca6MFqKzrmFgUsr2xZOVWRF9AV3qEjuK3MaTP27x55pLChCPXT6T0iiGnQH61IG4LAqPFiR6lwbbFC7bUrSnFPN0OBB8DrnlneST9XxPZaRYfhI96uylRIR7eWA=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Chen <Wei.Chen@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2 1/6] xen/arm: do not free reserved memory into heap
Thread-Topic: [PATCH v2 1/6] xen/arm: do not free reserved memory into heap
Thread-Index: AQHYUx8YNmarGsMpyEa7fYOjD7Fukaz28UOAgAAN1cA=
Date: Tue, 19 Apr 2022 10:25:28 +0000
Message-ID:
 <DU2PR08MB73258D4ABDB8F866480933E0F7F29@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <20220418122251.3583049-2-Penny.Zheng@arm.com>
 <328723bb-1e24-7d3a-8fe0-ef433a96b360@suse.com>
In-Reply-To: <328723bb-1e24-7d3a-8fe0-ef433a96b360@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: C0BB0F677766344AB9A50BD7AF373D45.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 0c92fa29-a40a-4094-6b2a-08da21eef4ef
x-ms-traffictypediagnostic:
	AM9PR08MB6228:EE_|DB5EUR03FT054:EE_|DB7PR08MB2969:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB2969D3D1E2449FB90C9A1641F7F29@DB7PR08MB2969.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 eYOgR7xYAETnkB34BsUcrCD6rU/i6Pt20DRgvtZn0k3l+7/1DRIiB6OBDXm35HkBte3Gj0RvU1Tdz9JrCwOjqOgXCKUU/lFysUivtkWGx9MY2axOZcna0xmDenBEfzClYSTewzXTNhLbyNUZzUvn8iwWrF0bD19HM95YLZ6R9x8sv9LyMxdyi4LgJo8KBL7SnGExRwa1gtAV1vu9pKnoOMpD0qOi+ud6zZ/2ou6MsWEowSQ8IYTqOehORJF1I/A1hIOge/EuhYIwHiD+kuoC/hzkKnzZWuMQGpYXlE7/Xa1yKb6SDRial/NvvFkQnmR/+tycwVtJo2CEbq33NqpXYXo0EmhdPqcvjYaH904Lv/h0tCHd7BzLWVBfpYkQia+oijw0bj8KYTtmQRAAbRQ85b/BP1L8Cj//ixCD559GxKm3m9Kn5pGVcdZ26osHTimmlNygihgnHDmtOWrOtYIRZE905a0OInGHO+ZV40LxakhL2CsWX4+zQqaiX5Ak5ZYhwkHlAAt5DAOxw/r8aCyd1rOHt8lNNf20XtugadHZOXgBBYPIDN0OUStQuT+d2OUIW7vPQlDbz6w79/yhEjghsnP9XZnFfESPKFMMcnzIB4KUQoANUDOUSwMrNi9JPgxd/dCUpivVMndxVOpqKRi9BeKY8O927p4Duyv06re0uHMxnMGvTApPQQ3A649Jv2ynbVd5QPdKvBgEwGrO3zaC8g==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55016003)(38100700002)(5660300002)(508600001)(38070700005)(122000001)(52536014)(33656002)(8936002)(83380400001)(71200400001)(186003)(7696005)(2906002)(6506007)(26005)(86362001)(53546011)(9686003)(316002)(66556008)(66476007)(66446008)(66946007)(76116006)(64756008)(8676002)(54906003)(6916009)(4326008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6228
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2eb8e6a3-afda-47fc-89a5-08da21eeecee
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QGT+oxZtzjJ1jXtHBcHHUVXgBSP8z4FGBuqrUEiE/Fhv3jwqVFfZPOOYz0QzBiOr/ZXaR05Lcr1K7auT1NwrmcHamqdNNc2yWCdFLmxDozX+BSxzFCPeCJLm7A+j8ari8mV/bUbEluQSHHNrgbwzQxaEY71CmW0o65DnLPOtyvYPPOn+kn1iOOswjOe225kNXyCm12RCvG6tX74wfY35BADe/oZs0F9nsxbpw6ONbwx8plcOh07+NFJBsKB8CtymuZGEbHKHczwGNrWNyKt+G/AOhaqQa6YCfvX+R2iAqTqZO4a5yYTyu3epGuzYHCPqVSj53GlnR5oIdH3aex2+oGWn6JkXZNopnAiDZ5vQhm6VRzNQqYjJZGnj/ZJKEOEH7FIYuf8aKiXByTAs8hPw4khnwJQpe/jgl9o0vMLZdu6jKX9gAYtHSEcalmlFNhxtP/FSTqbICgH47eAGvXnJiMlJv+8uPVEbShiMdft+o4kbkn4TS9JKfIGq6873sjRTATbj2n7TtW5B6QQmlbQYGe2NznHsknH1cofJ9fMKHCEOyA8+wCuuYI6iwyAJJ91/l5wO1PuJpWQSDqYYoA04W9NfnOkpOneQaZlZoJwj7VROKL/9K0HVEQqyBUfsu6pqRcWOScIVerRok0mgIlzKzbxXfj9W3B4cHnHMp0oaDXmU35GGYpryRnCqy+/+1kpl
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(4326008)(6862004)(52536014)(36860700001)(70206006)(54906003)(70586007)(8676002)(7696005)(316002)(82310400005)(8936002)(5660300002)(40460700003)(83380400001)(356005)(2906002)(186003)(86362001)(81166007)(47076005)(336012)(26005)(9686003)(55016003)(33656002)(6506007)(53546011)(508600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 10:25:42.1505
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c92fa29-a40a-4094-6b2a-08da21eef4ef
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2969

SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUdWVzZGF5LCBBcHJpbCAxOSwgMjAyMiA0
OjU5IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IFdl
aSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgQW5kcmV3IENvb3Blcg0KPiA8YW5kcmV3LmNvb3Bl
cjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47
DQo+IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNz
dGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBXZWkNCj4gTGl1IDx3bEB4ZW4ub3JnPjsgeGVuLWRldmVs
QGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS82XSB4ZW4v
YXJtOiBkbyBub3QgZnJlZSByZXNlcnZlZCBtZW1vcnkgaW50byBoZWFwDQo+IA0KPiBPbiAxOC4w
NC4yMDIyIDE0OjIyLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBQYWdlcyBhcyBndWVzdCBSQU0g
Zm9yIHN0YXRpYyBkb21haW4sIHNoYWxsIGJlIHJlc2VydmVkIHRvIHRoaXMgZG9tYWluIG9ubHku
DQo+IA0KPiBJcyB0aGVyZSAidXNlZCIgbWlzc2luZyBhcyB0aGUgMm5kIHdvcmQgb2YgdGhlIHNl
bnRlbmNlPw0KPiANCj4gPiBTbyBpbiBjYXNlIHJlc2VydmVkIHBhZ2VzIGJlaW5nIHVzZWQgZm9y
IG90aGVyIHB1cnBvc2UsIHVzZXJzIHNoYWxsDQo+ID4gbm90IGZyZWUgdGhlbSBiYWNrIHRvIGhl
YXAsIGV2ZW4gd2hlbiBsYXN0IHJlZiBnZXRzIGRyb3BwZWQuDQo+ID4NCj4gPiBmcmVlX3N0YXRp
Y21lbV9wYWdlcyB3aWxsIGJlIGNhbGxlZCBieSBmcmVlX2RvbWhlYXBfcGFnZXMgaW4gcnVudGlt
ZQ0KPiA+IGZvciBzdGF0aWMgZG9tYWluIGZyZWVpbmcgbWVtb3J5IHJlc291cmNlLCBzbyBsZXQn
cyBkcm9wIHRoZSBfX2luaXQNCj4gPiBmbGFnLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogUGVu
bnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+ID4gLS0tDQo+ID4gdjIgY2hhbmdlczoN
Cj4gPiAtIG5ldyBjb21taXQNCj4gPiAtLS0NCj4gPiAgeGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMg
fCAxMCArKysrKysrKy0tDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDIg
ZGVsZXRpb25zKC0pDQo+IA0KPiBXaXRoIHRoaXMgZGlmZnN0YXQgdGhlIHBhdGNoIHN1YmplY3Qg
cHJlZml4IGlzIHNvbWV3aGF0IG1pc2xlYWRpbmc7IEkgZmlyc3QNCj4gdGhvdWdodCBJIGNvdWxk
IHNraXAgdGhpcyBwYXRjaC4NCj4gDQoNCk9oLCBzb3JyeS4gV2lsbCBjaGFuZ2UgdGhlICd4ZW4v
YXJtJyB0byAneGVuJw0KDQo+ID4gLS0tIGEveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMNCj4gPiAr
KysgYi94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYw0KPiA+IEBAIC0yNDg4LDcgKzI0ODgsMTMgQEAg
dm9pZCBmcmVlX2RvbWhlYXBfcGFnZXMoc3RydWN0IHBhZ2VfaW5mbyAqcGcsDQo+IHVuc2lnbmVk
IGludCBvcmRlcikNCj4gPiAgICAgICAgICAgICAgc2NydWIgPSAxOw0KPiA+ICAgICAgICAgIH0N
Cj4gPg0KPiA+IC0gICAgICAgIGZyZWVfaGVhcF9wYWdlcyhwZywgb3JkZXIsIHNjcnViKTsNCj4g
PiArI2lmZGVmIENPTkZJR19TVEFUSUNfTUVNT1JZDQo+ID4gKyAgICAgICAgaWYgKCBwZy0+Y291
bnRfaW5mbyAmIFBHQ19yZXNlcnZlZCApDQo+ID4gKyAgICAgICAgICAgIC8qIFJlc2VydmVkIHBh
Z2Ugc2hhbGwgbm90IGdvIGJhY2sgdG8gdGhlIGhlYXAuICovDQo+ID4gKyAgICAgICAgICAgIGZy
ZWVfc3RhdGljbWVtX3BhZ2VzKHBnLCAxIDw8IG9yZGVyLCBzY3J1Yik7DQo+IA0KPiAxVUwgd2l0
aCwgaW4gcGFydGljdWxhciwgdGhlIGZ1bmN0aW9uIHBhcmFtZXRlciBieSAidW5zaWduZWQgbG9u
ZyIuDQo+IA0KPiBCeSBjYWxsaW5nIGZyZWVfc3RhdGljbWVtX3BhZ2VzKCkgYXQgcnVudGltZSwg
eW91IG1ha2UgdGhlIHByZXZpb3VzIHJhY2UgZnJlZQ0KPiAoYmVjYXVzZSBvZiBpbml0LXRpbWUg
b25seSkgdXBkYXRlIG9mIC5jb3VudF9pbmZvIHRoZXJlIHJhY3kuIE1ha2luZyBhIGNsb25lIG9m
DQo+IHRoYXQgZnVuY3Rpb24ganVzdCBmb3IgdGhpcyBkaWZmZXJlbmNlIHdvdWxkIGxpa2VseSBi
ZSBleGNlc3NpdmUsIHNvIEknZCBzdWdnZXN0IHRvDQo+IGNoYW5nZSB0aGUgY29kZSB0aGVyZSB0
bw0KPiANCj4gICAgICAgICAvKiBJbiBjYXNlIGluaXRpYWxpemluZyBwYWdlIG9mIHN0YXRpYyBt
ZW1vcnksIG1hcmsgaXQgUEdDX3Jlc2VydmVkLiAqLw0KPiAgICAgICAgIGlmICggIShwZ1tpXS5j
b3VudF9pbmZvICYgUEdDX3Jlc2VydmVkKSApDQo+ICAgICAgICAgICAgIHBnW2ldLmNvdW50X2lu
Zm8gfD0gUEdDX3Jlc2VydmVkOw0KPiANCg0KTGVhcm5lZCENCg0KPiA+ICsgICAgICAgIGVsc2UN
Cj4gPiArI2VuZGlmDQo+ID4gKyAgICAgICAgICAgIGZyZWVfaGVhcF9wYWdlcyhwZywgb3JkZXIs
IHNjcnViKTsNCj4gDQo+IE9mIGNvdXJzZSBpdCB3b3VsZCBiZSBuaWNlIHRvIGF2b2lkIHRoZSAj
aWZkZWYtYXJ5IGhlcmUuIE1heSBJIGFzayB0aGF0IHlvdQ0KPiBpbnRyb2R1Y2UgYSBzdHViIGZy
ZWVfc3RhdGljbWVtX3BhZ2VzKCkgZm9yIHRoZSAhQ09ORklHX1NUQVRJQ19NRU1PUlkNCj4gY2Fz
ZSwgc3VjaCB0aGF0IHRoZSBjb25zdHJ1Y3QgY2FuIGJlY29tZQ0KPiANCg0KU3VyZSwgd2lsbCBk
by4NCg0KPiAgICAgICAgIGlmICggIShwZy0+Y291bnRfaW5mbyAmIFBHQ19yZXNlcnZlZCkgKQ0K
PiAgICAgICAgICAgICBmcmVlX2hlYXBfcGFnZXMocGcsIG9yZGVyLCBzY3J1Yik7DQo+ICAgICAg
ICAgZWxzZQ0KPiAgICAgICAgICAgICAvKiBSZXNlcnZlZCBwYWdlIHNoYWxsIG5vdCBnbyBiYWNr
IHRvIHRoZSBoZWFwLiAqLw0KPiAgICAgICAgICAgICBmcmVlX3N0YXRpY21lbV9wYWdlcyhwZywg
MSA8PCBvcmRlciwgc2NydWIpOw0KPiANCj4gQW5vdGhlciBxdWVzdGlvbiBpcyB3aGV0aGVyIHRo
ZSBkaXN0aW5jdGlvbiBzaG91bGQgYmUgbWFkZSBoZXJlIGluIHRoZSBmaXJzdA0KPiBwbGFjZS4g
V291bGQgaXQgcGVyaGFwcyBiZXR0ZXIgYmVsb25nIGluIGZyZWVfaGVhcF9wYWdlcygpIGl0c2Vs
ZiwgdGh1cyBhbHNvDQo+IGNvdmVyaW5nIG90aGVyIHBvdGVudGlhbCBjYWxsIHNpdGVzPyBPZiBj
b3Vyc2UgdGhpcyBkZXBlbmRzIG9uIHdoZXJlLCBsb25nIHRlcm0sDQo+IHJlc2VydmVkIHBhZ2Vz
IGNhbiAvIHdpbGwgYmUgdXNlZC4NCj4gRm9yIGRvbWFpbnMgdG8gYmUgdHJ1bHkgc3RhdGljLCBY
ZW4ncyBvd24gYWxsb2NhdGlvbnMgdG8gbWFuYWdlIHRoZSBkb21haW4NCj4gbWF5IGFsc28gd2Fu
dCB0byBjb21lIGZyb20gdGhlIHJlc2VydmVkIHNldCAuLi4NCj4gDQoNClllcywgeW91J3JlIHJp
Z2h0LiBJJ2xsIGRlZmVyIHRoZSBkaXN0aW5jdGlvbiB0byBmcmVlX2hlYXBfcGFnZXMuIEFuZCBy
ZWZpbmUgdGhlDQppbi1jb2RlIGNvbW1lbnQgYWJvdmUgZnJlZV9zdGF0aWNtZW1fcGFnZXMsIGlu
IHRoZSBmaXJzdCBwbGFjZSwgSSB3YXMgaW50ZW5kaW5nDQp0byBtYWtlIGl0IGVxdWl2YWxlbnQg
b2YgZnJlZV9oZWFwX3BhZ2VzIHRvIGZyZWUgc3RhdGljIG1lbW9yeS4NCg0KSG93ZXZlciBhcyB5
b3Ugc2FpZCwgaWYgbGV0dGluZyBmcmVlX2hlYXBfcGFnZXMgY2FsbCBmcmVlX3N0YXRpY21lbV9w
YWdlcywgaXQgd2lsbCANCmNvdmVyIG90aGVyIHBvdGVudGlhbCBjYWxsIHNpdGUuIFdlJ3ZlIGFs
cmVhZHkgYmVlbiB0cnlpbmcgdG8gZW5hYmxlIHAybSBwb29sIG9uIGFybSwNCmFuZCBpbiB0aGUg
ZnV0dXJlLCBtYXliZSB0aGUgcGFnZXMgY29uc3RpdHV0aW5nIHRoZSBwb29sIHNoYWxsIG5vdCBj
b21lIGZyb20gaGVhcCwgYnV0DQpmcm9tIHJlc2VydmVkIHNldCwgaWYgdGhlIGRvbWFpbiBpcyBm
dWxseSBzdGF0aWMNCg0KPiA+IEBAIC0yNjM2LDcgKzI2NDIsNyBAQCBzdHJ1Y3QgZG9tYWluICpn
ZXRfcGdfb3duZXIoZG9taWRfdCBkb21pZCkNCj4gPg0KPiA+ICAjaWZkZWYgQ09ORklHX1NUQVRJ
Q19NRU1PUlkNCj4gPiAgLyogRXF1aXZhbGVudCBvZiBmcmVlX2hlYXBfcGFnZXMgdG8gZnJlZSBu
cl9tZm5zIHBhZ2VzIG9mIHN0YXRpYw0KPiA+IG1lbW9yeS4gKi8gLXZvaWQgX19pbml0IGZyZWVf
c3RhdGljbWVtX3BhZ2VzKHN0cnVjdCBwYWdlX2luZm8gKnBnLA0KPiA+IHVuc2lnbmVkIGxvbmcg
bnJfbWZucywNCj4gPiArdm9pZCBmcmVlX3N0YXRpY21lbV9wYWdlcyhzdHJ1Y3QgcGFnZV9pbmZv
ICpwZywgdW5zaWduZWQgbG9uZw0KPiA+ICtucl9tZm5zLA0KPiA+ICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBib29sIG5lZWRfc2NydWIpDQo+IA0KPiBUaGlzIGxpbmUgbm93IHdh
bnRzIGl0cyBpbmRlbnRhdGlvbiBhZGp1c3RlZC4NCj4gDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:31:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:31:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.307997.523460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngl8m-0002Z8-RU; Tue, 19 Apr 2022 10:31:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 307997.523460; Tue, 19 Apr 2022 10:31:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngl8m-0002Z1-O2; Tue, 19 Apr 2022 10:31:24 +0000
Received: by outflank-mailman (input) for mailman id 307997;
 Tue, 19 Apr 2022 10:31:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngl8m-0002Yv-5Y
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:31:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dbe47b97-bfcb-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 12:31:23 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-uqS0L_JsP_y4lpV4ZG2avA-1; Tue, 19 Apr 2022 12:31:18 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB5706.eurprd04.prod.outlook.com (2603:10a6:10:a5::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 10:31:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 10:31:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dbe47b97-bfcb-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650364282;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=23YmRU8g3j7av44iXJcTeB2zyaSXSTHD+Pl6Jf/3atU=;
	b=IoPLqhsxWrZPIx2NfQbCtQ611b1hbG2I1EHDvwHVHjZ/vxE/I1bagfLTUYAD2i//Xl/xIR
	X1o3y2CAeuw3NW2DY04/oKJtUMcflj0ENboYRSJO+F9sgzbxD+15HIdO7zlZ5XM4ZqBTdE
	mDgY3nv3AFyOzEZbH3n1BgVJ7H6SlbU=
X-MC-Unique: uqS0L_JsP_y4lpV4ZG2avA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TNpYu8DFucnrdaYgZxpIf6Hjrnw+4XMtdWHWMuxEvXt9F0zfkBIU8eKKg+VBMdnQB8/pMBjBg5CnYwoX2vKyH5dCnfcQoarZDFk68d7a/jFVI7IJDf0Au88N5Gj5jY526Yj5DUnmSmGPOVQafDvOEJQenHuvDYRkS4AyRFpBeSanZoGFR32gx0zppfoQuwqLHek4z1gMjiyQk429T3pyEMiOCbswdhMv8FLiSKbpEeZzDgQPySqbevjSsK+LxxvoHS/hkE09FmdrXnMbt2XbfPdN9kfaU/lLX+QWWmSXmiAeV+2/eDwGScnNy+/js8+hKshHEaFcNXO62rcyvFPb+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=23YmRU8g3j7av44iXJcTeB2zyaSXSTHD+Pl6Jf/3atU=;
 b=BjZH2AiJPmnS1ZEySRKvZLtGrctBR7ykEnQT8piDGBwm1iSze8SarXhQSnay86xnSxlxFCpoKbNo5SSj8vkrdjsoo/LcdLRYDFp5HFx6jPNUfVNGwQjyBctbzZ7N3WSxhfjaA915BKIScDxpDhfGQbziWMXEb9iWRZP4x8rbmBewvIozSUmQKBZJOj34Cutcf9GbW4c4SqjCBwl56o+mlmlVCIyAFT0ujKuM0BZc85RCfyIUygvrRjjXiKIZGvclJpPbM5ejku27Uf3pJGZLIQIJFU0aoqW5ty3WYQW/i5NEO16WR2KqJGm8uOoIyAmLzeFaAbY1/Jr+7XqD3BZG0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5c884c16-ab97-f4db-2e8c-c34586fa0e81@suse.com>
Date: Tue, 19 Apr 2022 12:31:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>, xen-devel@lists.xenproject.org
References: <20220419101850.3045-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220419101850.3045-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0116.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c0ac69bd-9c87-4e1c-e830-08da21efbb8a
X-MS-TrafficTypeDiagnostic: DB8PR04MB5706:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB5706C3EBA377ACBCC77B539CB3F29@DB8PR04MB5706.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fAAstkSPyKgbDbaN9nPgxcwCQR6fL+45bRygb7drnT1gU28nzn6XaGXqbcPcEWcPbg6+iVlCPR9Kdd2OxHkrrbbMSnpBWntor8k1iinoM3tMWSG6q05U7PPCkNMAXsEuWjz6Vclg7OFG1IMoxM7+TgxlUsPHF95RDp3+LxvyQatl7R/HFX+66q1xvoqBqjzRclgBBvooqYD4ZLoTFFKBh2rRo/Or2/Zt8TvLbyvIRx9QnK37bwc4uZCFF7+ONUpkxEFrRJFCTZy3jCXG1Mneoj7xdhe8Ff+ZXHGTFPZ13ZgvRL/ts3JON76ZUSTaZ4krq0KvzkyTo7puLpEEbrZa4EwkoiiVdeOqY4Fo97bQGBA62hbejT6I+IjEOLxGz+AfPUi7bLYAam4l7gBATwyHRFQgnk4ZwxNlqc1KmwWl94PpK8g0agQX68XIdukoNc5HSMHKo68XyQBUrgEz2fpTuPwykDBZvJ1mYVnQoqqZ0IFSbKfV5GrdAWzZh3TSoZAWibKkk6F5LNjtRm7BIgkv/qHYFRTxQnl1Lkd6TffaSabfz7Wpl6tebTIHpG+MRGcywKoRzqc2WJXgW8lYPyFD1P4F4KFkaUQEbCT20lSrzcTd+D0MQ1fQjl7ReqFAdoxsVWwe5V1VS+yL0KnlL40uuurBbt6SvkdewFcAM/itLxu0Fs3+tNmiy8fmz/rmsJi/pTZFhQ77t6O6Pu82iS9AiSdkzIvoW8f0U72ahFq7fhEYj6/j5AxApUA2TIePXg+S
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(38100700002)(66946007)(31696002)(86362001)(66476007)(6862004)(4326008)(66556008)(8676002)(6636002)(508600001)(83380400001)(54906003)(37006003)(186003)(6512007)(6506007)(26005)(316002)(53546011)(2616005)(5660300002)(2906002)(8936002)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TTZPV1F1clhHU3dYVlVXMFF6OVdkSGZOZVlvdmtXTk5rMVZocmprZXpIOElk?=
 =?utf-8?B?M1FYSkN6NnJ3L096bS9CS2l1Q2FDRDMyOXVYa1IzbCs3L2NBeEFZdGw0ZG5u?=
 =?utf-8?B?UFhPMUJlak9BNkh3OENsYjZsWTlFaXBJbmZYK3VQaU1DL2ZQa1FwNnJFdEM1?=
 =?utf-8?B?ZXk1clFaNkRlUlliWENjTStnc1NTOVNGa2I4RnIwRmZ3UCtDL3EwUUVvYjln?=
 =?utf-8?B?YThQMXJJY1VLelI1NnN1Vk42Sm85dFAzSTAwQjl2eFAybUVBaWlKSXpZWlhX?=
 =?utf-8?B?TE9MZ013OW4rRjlSaHVQVm42Z00zSXpNaHZOY2M2Z2M3SjMyVUhieFRvR05j?=
 =?utf-8?B?NFVmTEhVZVZXS3ErM2RHV2c4Wld4eVFaL24xVEpDZjNYQlBqM0ZMRC8wd0x5?=
 =?utf-8?B?RG01bmVFLzEwWW5hWXdHU3REMkV5dnlQYTlTa3VDNlcwTS9LVW5HeTk1K25T?=
 =?utf-8?B?ZmErWlJyVm1rTWRhdC9WWW0wR0p4alZZMnpUYWlSS2k1VmRPWkdHN0ZELzU1?=
 =?utf-8?B?ejQ3V3NudTJlekE2L1VQSFlrc2tmQ21wbWJlQmJQZ1BzSXJLR1d3VnlWK0FY?=
 =?utf-8?B?TWZQeFRQNlpXMlJxSGRuNHNmQk5nRER0azBJM2o4MnhGZEJpbGFhWXJoVFdJ?=
 =?utf-8?B?YnBDUjF0eStRS0JYRmY2QnB3OWt4YmJSVHZqVzJraUhHRzFkTFVTR1k1SmU2?=
 =?utf-8?B?UjJOdnIvUlhBanU5SjlZN0kyRU9JU0toU3NVbEtDOWpnbytqZWxJZ2E1b1o2?=
 =?utf-8?B?L2xiVVU3WjNJenV2QmxHVXVWMHJvNWQyMSt5dGx5aENCbnBaTnoxL0xyakM5?=
 =?utf-8?B?a2o0TFlMaGNXQ1JOdGJtVXRCMVBYZHkvME5BcmxrMDVkaWVrM25LOXpyY3VL?=
 =?utf-8?B?d1RJeVdVOE14Q1ZIbm0zYmVjU1oxMy82bDJRMTdDbmlCK0JCRklheE44ZmxS?=
 =?utf-8?B?VHRLWGVzNm9WcllsSWp2eXdUODFwWTVwRlQ1YzN3dkJjZllEczh4bW92N1BV?=
 =?utf-8?B?QndHV0JkOWF0MmFyeDlyb090eWFPL0FMWk1KTFZJWDR1SnZSUlpCcW9zclJk?=
 =?utf-8?B?OHEzUmRyZWFKbEMvbFRzQzcxZmVNZzVONXNIMlJwSjZhRVpoUjlyTElsaFFR?=
 =?utf-8?B?ZUZNcjdxRmQ5dWNQd2hWaEdrWXgvV2hCQ1JZcFZTa05DVWJwVHdhVzJKUVh5?=
 =?utf-8?B?bTFNM3lyNGZnK090dEJ6R1BJV3BTVGZkZ25wTjIrMWhmeUNtTkpuM1IycmFX?=
 =?utf-8?B?S3IrZG5lWUlNUlVPM0tOWGJjeHJUMHFSa0JQbjY3UnVveVZoTXN1emR2aGxh?=
 =?utf-8?B?VGVlMWpleVI2bG1zUjNZa1FVNTRiVk1iMDVtVWNHQzVYa2c5MGFhZnV1aUVM?=
 =?utf-8?B?TUw0L2lxaThkL1VKTXVyazBKUEllY2ZDZThoallIT3l5bjZsdGdkRmNWQ1hS?=
 =?utf-8?B?ZTFkZVprd0FqSC9Rcjg0ZnprNC9CVGY0ZmlJOVVaYmdQNjl3d0NKb1lGUFZY?=
 =?utf-8?B?VHJ4L0NFbmZOa0Y3aTdNM3BuSHA2VGxLVVY3WDNnOC8yY3c4OWhQeXJ0SUFL?=
 =?utf-8?B?L3R1dTlpZ2FjVnM2YnREUTI4LzlLeEV0Z1JRYmJQOEF1QmdDaFhsb2lyR24z?=
 =?utf-8?B?ckZNQVptOWJjT0tNb29yT0ZRRFBGYXhVei9QRXNhTHpVOVd4Rldzby9GZVNX?=
 =?utf-8?B?UXJBT0d0WE9weFVhWW5sU1pUa01sN1RNZEpKL0JuVy91bjg4bTBQbmxFRkRx?=
 =?utf-8?B?OFpPK1lWQW5ydE5PN0FjSC9XV0FDeE5PMWI2TjBoZjlBR01zMFRpVlY2YVUz?=
 =?utf-8?B?WWloQU9BT3RBRXJ1aUJydkU2VFRYcDFLNmFoODJjUFgwZTF2cDViQ1B4Zmh4?=
 =?utf-8?B?NUxhODR4QzRHOVVUaU5RdThaNmtIc0pDSHhPbUQzRmYvNnltU0pvOXNMZVJR?=
 =?utf-8?B?aXd2MGFKb0FPRmlQRmVXTnByMzRQQ3hyOWRnTUVScTFMcEdIQ1U0U0YrNTZP?=
 =?utf-8?B?SVpyYVNXY3BGTHRaSHBuaFo1bkRic2RoVk5ENGhDWHkwaTRzUC9NaVZuM1dj?=
 =?utf-8?B?T2I0aWNNZlQzaUNqSGc0OGFrQlppTjRhVEdja25ZY2Rqa2hLNjRwVzZObTFk?=
 =?utf-8?B?WFVKbnVpM0lJZGhaR01TbldNUGhJd045bVp2TXVRQUJ5MGwrcWppT29ISC9O?=
 =?utf-8?B?V29LcTBxMlBPWEh3WWVtdkpSKzIwNTZpOWIzS2IwUVMzVDNmT1ZxRzJVbVZK?=
 =?utf-8?B?Zk9uSTJIZjlFMkRaTERzbTBBQVFSbDFHc21pVzM5dTVsU240YzI3R2FRWWZt?=
 =?utf-8?B?QmkwSWpuVnlHbkVFNnpYa1RVNkJyUWpBS1g4MDJUa2lDQzZRbTdoZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0ac69bd-9c87-4e1c-e830-08da21efbb8a
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 10:31:15.4939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o95JZzPzO1BfgQc8Z5QjwRkJN1zSxVs237OEk+1bUhbtEEeie12kH5HBOgH/Kv2CaZnb+Slx2tE3dwHForcJXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5706

On 19.04.2022 12:18, Juergen Gross wrote:
> A hypervisor built without CONFIG_GDBSX will crash in case the
> XEN_DOMCTL_gdbsx_guestmemio domctl is being called, as the call will
> end up in iommu_do_domctl() with d == NULL:
> 
> (XEN) CPU:    6
> (XEN) RIP:    e008:[<ffff82d040269984>] iommu_do_domctl+0x4/0x30
> (XEN) RFLAGS: 0000000000010202   CONTEXT: hypervisor (d0v0)
> (XEN) rax: 00000000000003e8   rbx: ffff830856277ef8   rcx: ffff830856277fff
> ...
> (XEN) Xen call trace:
> (XEN)    [<ffff82d040269984>] R iommu_do_domctl+0x4/0x30
> (XEN)    [<ffff82d04035cd5f>] S arch_do_domctl+0x7f/0x2330
> (XEN)    [<ffff82d040239e46>] S do_domctl+0xe56/0x1930
> (XEN)    [<ffff82d040238ff0>] S do_domctl+0/0x1930
> (XEN)    [<ffff82d0402f8c59>] S pv_hypercall+0x99/0x110
> (XEN)    [<ffff82d0402f5161>] S arch/x86/pv/domain.c#_toggle_guest_pt+0x11/0x90
> (XEN)    [<ffff82d040366288>] S lstar_enter+0x128/0x130
> (XEN)
> (XEN) Pagetable walk from 0000000000000144:
> (XEN)  L4[0x000] = 0000000000000000 ffffffffffffffff
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 6:
> (XEN) FATAL PAGE FAULT
> (XEN) [error_code=0000]
> (XEN) Faulting linear address: 0000000000000144
> 
> Fix this issue by modifying the interface of gdbsx_guest_mem_io() to
> take the already known domain pointer instead of the domid.
> 
> Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
> Fixes: e726a82ca0dc ("xen: make gdbsx support configurable")
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with one nit (which can be taken care of while committing):

> --- a/xen/arch/x86/debug.c
> +++ b/xen/arch/x86/debug.c
> @@ -159,17 +159,11 @@ static unsigned int dbg_rw_guest_mem(struct domain *dp, unsigned long addr,
>   * Returns: number of bytes remaining to be copied.
>   */
>  unsigned int dbg_rw_mem(unsigned long gva, XEN_GUEST_HANDLE_PARAM(void) buf,
> -                        unsigned int len, domid_t domid, bool toaddr,
> +                        unsigned int len, struct domain *d, bool toaddr,
>                          uint64_t pgd3)
>  {
> -    struct domain *d = rcu_lock_domain_by_id(domid);
> -
> -    if ( d )
> -    {
> -        if ( !d->is_dying )
> +    if ( d && !d->is_dying )
>              len = dbg_rw_guest_mem(d, gva, buf, len, toaddr, pgd3);

This line now wants its indentation adjusted.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:40:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308010.523475 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglHv-0004BZ-Rk; Tue, 19 Apr 2022 10:40:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308010.523475; Tue, 19 Apr 2022 10:40:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglHv-0004BS-NG; Tue, 19 Apr 2022 10:40:51 +0000
Received: by outflank-mailman (input) for mailman id 308010;
 Tue, 19 Apr 2022 10:40:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nglHu-0004B7-Lj
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:40:51 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2b8f2237-bfcd-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 12:40:49 +0200 (CEST)
Received: from mail-co1nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 06:40:44 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM6PR03MB3897.namprd03.prod.outlook.com (2603:10b6:5:49::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 10:40:42 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 10:40:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b8f2237-bfcd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650364849;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=XHl5zMVUI9JQj3qnO004w1N0WeBh1P6ZMNp8VXwha3o=;
  b=gI3XEmFvZVMzt2S4xYVbiqzc+QV22GZ9lDJkWqO0hO65esR44wrk/Uh/
   E5osRlVVPOpAzfDfXBht0vEAbpxcgyjLo4pO0VRy/yY4hSEkRiiJjBNip
   IPB+lEa83mTy/1qmSYT66IsILbvDnL3U2Hx2l1XSrW25VaR7gGpWVjjRx
   E=;
X-IronPort-RemoteIP: 104.47.56.168
X-IronPort-MID: 69797790
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:L2AcvKkg08zrlvvxEXtvE63o5gxhJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJOCjzTPPnYY2enfI1/PtmzoEIF656DytRrTAVprHw8HyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWlLV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYdCgQEoPFp/UhVgRSKzt7eq9ix+7tGC3q2SCT5xWun3rE5dxLVRhzFqpBv+F9DCdJ6
 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXu5kBgmdYasNmRJ4yY
 +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfRmvDmMk10puFTrGMX8e9C1TMJ7pUi7i
 2vc023dLxYiDeXKnFJp9Vrp3IcjhxjTWo0IE6aj3uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHOAsxgVHcdeEugm8wyTw4LT+Q+SAmVCRTlEAPQkvsIrQT0h1
 neSgsjkQzdotdW9Vna15rqS6zSoNkA9L3IGZCICZRsI5Z/kuo5bpgnUUt9pHaqxj9v0MTL92
 TaHqG45nbp7pcUL2rS2+1bKxS2topzSZgEw7wTTGGmi62tEiJWNYoWp7R3Q6q9GJYPAF12Z5
 iFay46Z8fwECoyLmGqVWuIREbq15vGDdjrBnVpoGJpn/DOok5K+Qb1tDPhFDB8BGq45lfXBO
 Sc/ZSs5CEdvAUaX
IronPort-HdrOrdr: A9a23:ThXG9KwLecosll8NRQskKrPxdegkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD
 AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2RYUh27D3xnklWavo3RiKmrwPAa
 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66
 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4
 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+
 qvOfttcoreEVc=
X-IronPort-AV: E=Sophos;i="5.90,272,1643691600"; 
   d="scan'208";a="69797790"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mLWBfiVab6VPaxtxu6hUL4dS5r+6RJGAeDC1AzL9Ov0F10gfOFw3av6w5uov8vHbXerXV9Vlq+r/n5Y6dCcIceUGvc2I5f55M0I3a2kZvIT44wRqgETNMZ2Iw+V3Po9HapdguOERHgpSIZHA6spDANdOL5DVSh4fdS5WGW8lLdEZj/SWl/NLxRztHu7mJf19x0RrmxM9o5g3BXzUiNXv8TE0Y1OBNI98S3unvAQ8aK7dZOEaiwkCbRhYSqBxe2ltIjiVZvyAH3p87vVueiRVqRnk1PlDw/KLXJzopRLTgXQhsqFufXwp0Drf84Ut3K1VlkkBr2Uwb7qF9O6AAbl3iA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XHl5zMVUI9JQj3qnO004w1N0WeBh1P6ZMNp8VXwha3o=;
 b=DtCyR1fWRqkc71Z9zvg8iFEhZzJUHucdjAuCcRjfvUc7aiCQ/QSIfgx5PA3A4Cj23GRR1JmhrvPNZF44+AFCTU/FBfbugd1dFCDd5b9pfKpbi0qGsRvnbgPVgTlIKkd1dofRy8s7k7MQS7iHvJ6KDSI+TBrkA/LFtujfs6FfXlTUR94XWFHXb8E4wcOYOLMRFaJA9XaST4PGaClcYXWbxm2VIe081YaV0Z/vZlYSk7+WS1ZQw6tRW0DxlInx/KYUd2BE35OmmCFpGqBxdg9T/iyKYiNy4W6+5KlpsU8/294T7s+gYs2RWsATU4Q2zJfHQRJegKpO/j3SBglVMLKVQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XHl5zMVUI9JQj3qnO004w1N0WeBh1P6ZMNp8VXwha3o=;
 b=g9FIRwNmxHtiswuPCB6c+dumiSuIp9Yoxc3z1v/qk+Xu4bHNA54OWi71q5pXJ2i13J8t7Fw50JRQ8YxQ3f0BLe/jrkI5kQxRNVxUt4DgSFynHx1zyUJCRPWHFWg9IrU+XHOh3ftEnhuApuw8hj+VZKBGP620mmL5yelVQQlVDvo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Elena Ufimtseva <elena.ufimtseva@oracle.com>, Jan Beulich
	<jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <George.Dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Cheyenne Wills
	<cheyenne.wills@gmail.com>
Subject: Re: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Topic: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Index: AQHYU9bjmHO326ELbkuQmQOwkh6+0Kz3DCaA
Date: Tue, 19 Apr 2022 10:40:42 +0000
Message-ID: <5c6f75d7-d5d1-856f-c8d0-da1bd823be63@citrix.com>
References: <20220419101850.3045-1-jgross@suse.com>
In-Reply-To: <20220419101850.3045-1-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2a90934f-7599-4b46-55c7-08da21f10d6e
x-ms-traffictypediagnostic: DM6PR03MB3897:EE_
x-microsoft-antispam-prvs:
 <DM6PR03MB389791D75E07C312615DDC11BAF29@DM6PR03MB3897.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 5afWwdGzeaSW7ftU97ATZrAXaidb58XBwveHPxGKZFBLeYAHYHyiJnRLfAPMZNLvJ/snGV1EDCSHBGYw/yyjrT0S0h+1Xv5iHM0kM17/x58Ybl8BYmPKTe4p0IbqamwEpJ5Krl/ZtWHxx47Zeh5LYeFbUFF2He9VghMiWijo6a9hAl8dhitI4EaTlC7T4+hJuwDODBvZaLvnaPv1xi1V7QODVxGoSmnHNe9+OHYhqCP6OyNKrtgCmN/9MP0mRchvt4woselHVUaphxzzsCPNp7Fesz3IAWPxB0Af8XSJe5W+K8RJgzn4b1QT/bhnhYqeBIzPS0UMKC0sQOcFMGO+/VYJcfxEWsVa9wmRRm+FNQrPa44ZnTR+6EdqNUUvLYl+kX5B789naiIJqvA9I0IOXaOuhYhH89PUrG65UHkm5aFfJ8t3Jjcl9nhcyWUWlOjwAzF7AAfHPHlvuh6wFRrIWQImsAY/p4nN5v9hXx4YoGiPSBqynqhvTPAEtwSq7PxwiRuS8Ba0NdE8f2MQk6Xqlz09cYF5Tzy352RfPQVh5l4201pjtmqtF4maeKBs572jGcR6frQI+g2gsoAXq8Z6+iv8ISbWxoXKxuOinEXf2XPXUJJpjtTAS7PGNNuMuyJOaOFqwcxVyqbf97FAUN9nOktnJATgil6tyxzMj6EHW4mYVF84Ct/rbBzuWFr9Vb7rsBrDoWgqYtOC/MEcTDWTL2SdfmPCN6O8VuIDKv/nKJCN8Y/7JCCvyVuExYePNexGVl4lapaEamynDKHFFAZGjw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(186003)(508600001)(86362001)(6486002)(6512007)(8936002)(2616005)(71200400001)(2906002)(83380400001)(5660300002)(53546011)(6506007)(31696002)(36756003)(76116006)(66946007)(91956017)(66476007)(31686004)(4326008)(66446008)(64756008)(66556008)(8676002)(110136005)(54906003)(82960400001)(122000001)(38070700005)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bkttUFJBMHVEMG10VDJMZUpCTmV0enZwZWRGSEZabkRMMjBWMVY5MjlkanNW?=
 =?utf-8?B?SytsNDk0SFBMSG9HY2JFUEliM091VFBqOWVDQkZieDN3UFhqSzF0VXlnNXd4?=
 =?utf-8?B?bHZ3RE5BUllHa2RnSXE5K2d5TFhaUGZUeVY2SExKWTM4Q2QwcjlJWTNCekJs?=
 =?utf-8?B?UENCMXhiMDJKei9BK1M1WS9RZ0Q3U1JtZkpCRWo4bjYrMWxtRWc3dGl6bTFB?=
 =?utf-8?B?S05TUDlTalpYRTVScTUvdXQ1RkwzazZzb01kZTF1QWtLeldKOUZneEtVZEtZ?=
 =?utf-8?B?enBOSjVXQlNNMUlmMzVxT0h1Qi9qSERNbzkvTGpzcVo1ZHd4VElaV1R0dHRS?=
 =?utf-8?B?YWpMdFRjSmFrRXNiZ2thL1pHRWMxOEZhcEZyZHFlMHdvUGtnNnNKMGYvU1Vs?=
 =?utf-8?B?U09iS1ovSXpucmg4eEllUHBsRDJGbExKTnJOM1FvaEpQN0UyTHFISnlVYjVp?=
 =?utf-8?B?SkQvb1dmb2ZpM2MxTGgyMnhuZWJqOTJmZ3NOTkhsekZPTTVZek0yRVJSY051?=
 =?utf-8?B?Z0xIUjI5dlVOYldTV0o4aEd2aVBGQ3VSVDBCMC8rTWNhK09nRFRjVFNQS0dB?=
 =?utf-8?B?TVJTQ0pMUUJ1WW9ObDZvWGh4OWk2dkI1NGtKSy8wZENuUytJNmxPeDY2d1Fr?=
 =?utf-8?B?b2ZJS1ZDSjVieWdVS1RxRmpvWjBzODE5VHRIZ000R3d6TFdOM1hweTdzd2dR?=
 =?utf-8?B?Q2ZVbVNJRVhyY2RZTEQxYU1mUmZmUTRQb3M5cS93cERuNEs4a2ZIanFxTlRn?=
 =?utf-8?B?aWhkcUdJeDJDZkRlU2o1NHU1WjlpMGE1VzA0RzJmYUtna29qNWVrZ1pvZzFo?=
 =?utf-8?B?K1Qxd3EzNGFsS2tVV1oycE9MT3YvOUZZS3p6YlJQbVN0VGtFMVg4enFUY1ZL?=
 =?utf-8?B?Mkp2K2tzcVRjK1JCRmEvdHlmdmlpODdUUGhvdnhaWnNURkF0eXVWQkVrSHdJ?=
 =?utf-8?B?UzZmVXlZRTZXS3htNFFqQzlwUi9ieUE1RGFJbmZSM1VCOWM0Tzh1U2NqajBH?=
 =?utf-8?B?V2NBR3hHamN0SjNnbTYxbnEyV0JmV00rdVlvYXFOcVozUmNVTXc5U3hScVlU?=
 =?utf-8?B?RW5YajZtbVk0VUErNXA3SzdjVE5KTUQ0WGRidWRhNGxSM095U2JsNWJyV3VB?=
 =?utf-8?B?V1ZNM09SRG5lT05oSjVXQ3ZSRms4c055VjgyM1dOajdBdmViZlZBZGRmS2p4?=
 =?utf-8?B?TlNDQUNET2R4NnhXS3NJenFnZlRkNUJMREV5bk0xZ3YrdTA4SnBvR1RYVzd1?=
 =?utf-8?B?VFBmVHY5dkE1MEFTTGREVVlNRTBPdEIwMjExODQwZTljV1FjWnhNU25hdE9W?=
 =?utf-8?B?WjAzRHdDVlZ4YXByWFVBVSs0UFBYNzNQU2EvcldYUVBhOStqMkh4WUtOUlQ2?=
 =?utf-8?B?YlpZQVR4bG9iRkFic3RVbmJva2pudnNtZStKWDZYTUU5VHlBR1NJZWtZcHdT?=
 =?utf-8?B?Y0hnVW1rbm5Lc3F5Q3hJTVI3SzN0U3pxd0VjNVB0YTBxdUJCMnhBSnAvaHl0?=
 =?utf-8?B?YzlJVUdMSXpHcDJvN3FVYkZYTVdiTFVNNlNwb2pHWG8ydHJEZ3VHdmhqUDZS?=
 =?utf-8?B?QUtmbXhBdlArOTlUeUp2MHNXRVdzcU1vc3ZIZ2tIVW9VcmlaaDBjSUlEVDV6?=
 =?utf-8?B?QWJ4U1VwcU5HNGFmQ3VYbTY2aGhRYTBYU0FDRjBDODlEY0c0TmxuM3ZVRzhS?=
 =?utf-8?B?SmkxVS9lNkQ4ZjJGMWNsRWQxNy9WdzZkMHhiSmcxNmtGT2prcE1vK2dWZkFB?=
 =?utf-8?B?M2pKSVMyRExFOEt5MzRKWFlJbWhsRGNkTHNaczJvbGxUUzRXRGYrdVdDeTRa?=
 =?utf-8?B?ZUxEMWtSbHpDUDUvMFZtZ3RFYmdxckxnQVltRTJUemhFNUhjeitTbVNtWGJN?=
 =?utf-8?B?U0ZSMkhrK1NlQkN4ajhqVjJGSk5kb3E2TERkWTdtRWV6M2ZMZ3QwWEZLZ2lM?=
 =?utf-8?B?WEJQVlNjbnFxT21iS1hiWWRXMkpFRUhQaWhPMVFFTUtCbnpxcUM1a0ZWdFRR?=
 =?utf-8?B?OFdyS2IvQkxkRDlUYW8rU295UVdhbkt6QWVXazM1enhPWHJMSXFkRTNkdnA3?=
 =?utf-8?B?VDVZN2pXQ3pRdWhGL0t3VThrenlyaXYvKzNTZGFOTnZWQnAzNkNDWXY3MGZi?=
 =?utf-8?B?cjJoZ09LTlJZVk5Pc2VmNlpHQjZsbElhUjJ3Z05SU1NPRXNVZ3V6ZnF3WmdV?=
 =?utf-8?B?L0JOR3VyQUc5NDRXa3J4VTdnZFduS0tPOHg5d1BqYnVMV3FwQWk2NHpVVEFh?=
 =?utf-8?B?Ri8yaWs4dTlHaGhzV3daREhKMTc0TEZUandNM0YrTzdzK3dhMCtLbGNtRkxa?=
 =?utf-8?B?dlVrTjJGOGVvM2wyamRpRUlQV0o1alNRR0R6c1lHa0ZFbjlDNnJhQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <490B5D0497AD5540AF7D2A41FD3AB4CC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a90934f-7599-4b46-55c7-08da21f10d6e
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 10:40:42.1422
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: k+ceVgegdC+AEwYVXJtgqNQWh/ZP9KO35v6TUHAO1cb+4tqS7PiNGvk1Yxm4OB/pRcYuMhI8S+OlCG4UBysOyMq5zVWgLmBgGRrtw/MewtY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3897

T24gMTkvMDQvMjAyMiAxMToxOCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gQSBoeXBlcnZpc29y
IGJ1aWx0IHdpdGhvdXQgQ09ORklHX0dEQlNYIHdpbGwgY3Jhc2ggaW4gY2FzZSB0aGUNCj4gWEVO
X0RPTUNUTF9nZGJzeF9ndWVzdG1lbWlvIGRvbWN0bCBpcyBiZWluZyBjYWxsZWQsIGFzIHRoZSBj
YWxsIHdpbGwNCj4gZW5kIHVwIGluIGlvbW11X2RvX2RvbWN0bCgpIHdpdGggZCA9PSBOVUxMOg0K
Pg0KPiAoWEVOKSBDUFU6ICAgIDYNCj4gKFhFTikgUklQOiAgICBlMDA4Ols8ZmZmZjgyZDA0MDI2
OTk4ND5dIGlvbW11X2RvX2RvbWN0bCsweDQvMHgzMA0KPiAoWEVOKSBSRkxBR1M6IDAwMDAwMDAw
MDAwMTAyMDIgICBDT05URVhUOiBoeXBlcnZpc29yIChkMHYwKQ0KPiAoWEVOKSByYXg6IDAwMDAw
MDAwMDAwMDAzZTggICByYng6IGZmZmY4MzA4NTYyNzdlZjggICByY3g6IGZmZmY4MzA4NTYyNzdm
ZmYNCj4gLi4uDQo+IChYRU4pIFhlbiBjYWxsIHRyYWNlOg0KPiAoWEVOKSAgICBbPGZmZmY4MmQw
NDAyNjk5ODQ+XSBSIGlvbW11X2RvX2RvbWN0bCsweDQvMHgzMA0KPiAoWEVOKSAgICBbPGZmZmY4
MmQwNDAzNWNkNWY+XSBTIGFyY2hfZG9fZG9tY3RsKzB4N2YvMHgyMzMwDQo+IChYRU4pICAgIFs8
ZmZmZjgyZDA0MDIzOWU0Nj5dIFMgZG9fZG9tY3RsKzB4ZTU2LzB4MTkzMA0KPiAoWEVOKSAgICBb
PGZmZmY4MmQwNDAyMzhmZjA+XSBTIGRvX2RvbWN0bCswLzB4MTkzMA0KPiAoWEVOKSAgICBbPGZm
ZmY4MmQwNDAyZjhjNTk+XSBTIHB2X2h5cGVyY2FsbCsweDk5LzB4MTEwDQo+IChYRU4pICAgIFs8
ZmZmZjgyZDA0MDJmNTE2MT5dIFMgYXJjaC94ODYvcHYvZG9tYWluLmMjX3RvZ2dsZV9ndWVzdF9w
dCsweDExLzB4OTANCj4gKFhFTikgICAgWzxmZmZmODJkMDQwMzY2Mjg4Pl0gUyBsc3Rhcl9lbnRl
cisweDEyOC8weDEzMA0KPiAoWEVOKQ0KPiAoWEVOKSBQYWdldGFibGUgd2FsayBmcm9tIDAwMDAw
MDAwMDAwMDAxNDQ6DQo+IChYRU4pICBMNFsweDAwMF0gPSAwMDAwMDAwMDAwMDAwMDAwIGZmZmZm
ZmZmZmZmZmZmZmYNCj4gKFhFTikNCj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKg0KPiAoWEVOKSBQYW5pYyBvbiBDUFUgNjoNCj4gKFhFTikgRkFUQUwgUEFH
RSBGQVVMVA0KPiAoWEVOKSBbZXJyb3JfY29kZT0wMDAwXQ0KPiAoWEVOKSBGYXVsdGluZyBsaW5l
YXIgYWRkcmVzczogMDAwMDAwMDAwMDAwMDE0NA0KPg0KPiBGaXggdGhpcyBpc3N1ZSBieSBtb2Rp
ZnlpbmcgdGhlIGludGVyZmFjZSBvZiBnZGJzeF9ndWVzdF9tZW1faW8oKSB0bw0KPiB0YWtlIHRo
ZSBhbHJlYWR5IGtub3duIGRvbWFpbiBwb2ludGVyIGluc3RlYWQgb2YgdGhlIGRvbWlkLg0KDQpU
aGVyZSBpcyBzb21lIGV4cGxhbmF0aW9uIG1pc3NpbmcgaGVyZS7CoCBUaGUgYWRqdXN0bWVudHMg
eW91IG1ha2UgYXJlDQp3aXRoaW4gQ09ORklHX0dEQlNYLCB3aXRoIHRoZSBleGNlcHRpb24gb2Yg
dGhlIGZpbmFsIGh1bmsuDQoNCg0KVGhlIGFjdHVhbCBidWcgaXMgdGhhdCBub24tSU9NTVUgc3Vi
b3BzIGVuZCB1cCBpbiBpb21tdV9kb19kb21jdGwoKSwgc28NCndoaWxlIHRoaXMgaXMgZ29vZCBj
bGVhbnVwIHRvIGdkYnN4X2d1ZXN0X21lbV9pbygpIGl0LCBhbG9uZyB3aXRoIEphbidzDQphZGp1
c3RtZW50IHRvIGlvbW11X2RvX2RvbWN0bCgpLCBhcmUgbm90IHN1aXRhYmxlIGZpeGVzIHRvIHRo
ZSBjcmFzaCBhcw0KcmVwb3J0ZWQuDQoNClNvIHNvbWVvbmUncyBnb2luZyB0byBoYXZlIHRvIHdy
aXRlIGEgM3JkIHBhdGNoIHdoaWNoIGFjdHVhbGx5IGZpeGVzIHRoZQ0Kcm9vdCBvZiB0aGUgY3Jh
c2gsIGFuZCB0aGlzIHdpbGwgYmVjb21lIGNsZWFudXAuDQoNCn5BbmRyZXcNCg0KPiBkaWZmIC0t
Z2l0IGEveGVuL2FyY2gveDg2L2RlYnVnLmMgYi94ZW4vYXJjaC94ODYvZGVidWcuYw0KPiBpbmRl
eCBkOTBkYzkzMDU2Li5jMGRkNmVhZjE1IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvZGVi
dWcuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvZGVidWcuYw0KPiBAQCAtMTU5LDE3ICsxNTksMTEg
QEAgc3RhdGljIHVuc2lnbmVkIGludCBkYmdfcndfZ3Vlc3RfbWVtKHN0cnVjdCBkb21haW4gKmRw
LCB1bnNpZ25lZCBsb25nIGFkZHIsDQo+ICAgKiBSZXR1cm5zOiBudW1iZXIgb2YgYnl0ZXMgcmVt
YWluaW5nIHRvIGJlIGNvcGllZC4NCj4gICAqLw0KPiAgdW5zaWduZWQgaW50IGRiZ19yd19tZW0o
dW5zaWduZWQgbG9uZyBndmEsIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0odm9pZCkgYnVmLA0KPiAt
ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGxlbiwgZG9taWRfdCBkb21pZCwg
Ym9vbCB0b2FkZHIsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgbGVu
LCBzdHJ1Y3QgZG9tYWluICpkLCBib29sIHRvYWRkciwNCj4gICAgICAgICAgICAgICAgICAgICAg
ICAgIHVpbnQ2NF90IHBnZDMpDQo+ICB7DQo+IC0gICAgc3RydWN0IGRvbWFpbiAqZCA9IHJjdV9s
b2NrX2RvbWFpbl9ieV9pZChkb21pZCk7DQo+IC0NCj4gLSAgICBpZiAoIGQgKQ0KPiAtICAgIHsN
Cj4gLSAgICAgICAgaWYgKCAhZC0+aXNfZHlpbmcgKQ0KPiArICAgIGlmICggZCAmJiAhZC0+aXNf
ZHlpbmcgKQ0KPiAgICAgICAgICAgICAgbGVuID0gZGJnX3J3X2d1ZXN0X21lbShkLCBndmEsIGJ1
ZiwgbGVuLCB0b2FkZHIsIHBnZDMpOw0KDQpUaGlzIG5lZWRzIHJlLWluZGVudGluZy4NCg0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:49:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:49:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308016.523486 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglPz-00050y-LA; Tue, 19 Apr 2022 10:49:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308016.523486; Tue, 19 Apr 2022 10:49:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglPz-00050r-I9; Tue, 19 Apr 2022 10:49:11 +0000
Received: by outflank-mailman (input) for mailman id 308016;
 Tue, 19 Apr 2022 10:49:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nglPy-00050l-7p
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:49:10 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 55f58e1f-bfce-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 12:49:08 +0200 (CEST)
Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 06:49:06 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM4PR03MB6015.namprd03.prod.outlook.com (2603:10b6:5:38a::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Tue, 19 Apr
 2022 10:49:03 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 10:49:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55f58e1f-bfce-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650365349;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=/iJe2aOTMqAbfWIsolVNit0xXp/+UJO3grns/FTuwIU=;
  b=FyVF2eR5fXoc6Q9qr/2p7y5PlHfgEwGkPgpwfPDUbdf1odzz5Km9IoLb
   RYB6zjNWM2KRghJDcWgF5YAMqzOJq7bJqLBdf9VcVKAVG35KH3yehRp9K
   E0kZ8rNwn/FBinODzsmS1kZ0qVbuN06s4NQHdNrFw9wP9gnANGZsnpYr6
   M=;
X-IronPort-RemoteIP: 104.47.57.176
X-IronPort-MID: 69396903
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Z+w91qP5WpFtqzrvrR3YlsFynXyQoLVcMsEvi/4bfWQNrUp0hGAEn
 2sfC2nVbv+CYTDxeo8kbd+x8R4GvJLVn9RkSAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl298w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 fQVqZORUlcVEZbLmMM6S0d+KnxTMvgTkFPHCSDXXc276WTjKiKp79AwSUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HtaaHPuiCdxwhV/cguhnG/rEa
 tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2MJ8wPL9PJsi4TV5C164J2qL/TZRvG1FPUJrGexg
 Vv3w02sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVRxSlpFaUsxhaXMBfe9DW8ymIw6vQpgqcWG4NS2cYbMR87ZBoAzs3y
 lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obs5jEpMVkcG
 wy3kRU=
IronPort-HdrOrdr: A9a23:SKVgcaCEIYzK6tblHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U
 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca
 Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G
 DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z
 /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkmlGy0TtegPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59as5Vza/ppVFZql/1XwKqVKuZzIAvqrIQ8VO
 V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u
 TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ
 zEFEhVsGYjEniefvFmHKc7hiwlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.90,272,1643691600"; 
   d="scan'208";a="69396903"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IsU0SufeZ9c0hSjsKs78/X85gU4JVM7+dHeFG0JzK/LFUXIDGA50dL+YJwhp3wBUWNZLBtwqHbMFsgY7jI+7cRE1cLUZdAQizRTFBxS+Vh8bkFr52r5+rTxQQnQLBGhw/nhFFZA/fG9W1LjeEBhaTzrxbR0v6gpw1grinqlZEoONFXkLC/VVTGAD22HdKyZ2aCbDoI+LCdhuL50lfhfhAtWm0TpbPwmtZDLBQzTTK37f9Bz+RpttgjE4ZNTLvncfa2YIDZJ/D41MCszb8vPlqrb6UtfDOJ/wl0SB/7Rvc0cBFtd+EsgNQqNqXg7fmkGwJ6/3p8KUo/ocr9lv1NSxaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/iJe2aOTMqAbfWIsolVNit0xXp/+UJO3grns/FTuwIU=;
 b=ONPNApyyjQxBE5xrR1xxuAQi4Gd/iCevYUfMmO+3NVpmX2vYych/qQjBxyFhR1E8pWqkZ2Wu3/Cdyc0jtbumQp42AJWl0ksYPeBIiZo+4HYmPclx5A8sguixhf3svxA4uAEwCaS4X5OrDXyYpQPNrI0HCRhGZCN8EeahTUXNB6SYv5bYm81x+yhmc+r8Hg5zpM2HQf4M4/AcGHWPtqubNjYtzosntmJTwDwmb8fdBEiy0p/rQ1e2fghmjWr28ryC0XEg53/U7OUNlbGJlbADt2w0ITqkqUEpaYvlergwlc9ayZejNMWfOSPNoXoyb2EXnVPoiSWwKKvXQcim3e8Rhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/iJe2aOTMqAbfWIsolVNit0xXp/+UJO3grns/FTuwIU=;
 b=Xd5QYUFt+KjupQBdmizkuqpS4DMPEJys4EEOOtQwkH2Hxms21WUhikuZq0yAIWDzWFYnuN1zSZ0ftvC6selTqgl9dIhDSYfk2m098rzEDRzuo0Awv7DkTaNjY6N1vpvlPuLXhLzkmB4q57GzVZB0MnIDnbhtoTuHOG/AIdjPgg0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Topic: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Index: AQHYU9FUwjuogeCS0EWgGeBVFIanqKz3DoiA
Date: Tue, 19 Apr 2022 10:49:03 +0000
Message-ID: <6732a3c3-fc19-cbdf-7483-9f5946f1935a@citrix.com>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
In-Reply-To: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 819a64f1-f581-4ef0-9376-08da21f2385f
x-ms-traffictypediagnostic: DM4PR03MB6015:EE_
x-microsoft-antispam-prvs:
 <DM4PR03MB6015DE6C1D91AF6AEA855DC5BAF29@DM4PR03MB6015.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 32RlAlx/jZRPnyVGVdMEmez8bXRrZqvUoqiSV8afqgPnUdLtJW92ZezRJIlVh5DhMkDc8fnIYYrKkMzeFIpMQE7nGUMmFo5yE94rDgfVg6PfCjX9yfnvKo/uybC58yUGUQ9j7eivvf1XpgaRbscPJDIEeLvwe95Buj+a8Izt47MhH+4nPwmwtKUdf1ZraNi8b63Qmle4wrUwWs6kTpfbU8KnwHJBqfZZtzgcgZ5FBJcrjXgwnygN+3takhlTBKSXui5AClcr5E0I2qDVbPXL0QtXsjN0r6Wlp88/Mj5s/WShQFff1MYiGSIJONJ0bDJdr+ePs0w8oMka3gvAifZ+1CxbgVAtqbISHnJ4DABwHpXswTjF9FiC3dnn13Ba3yhJ2DFjW7PBlH5nS6+gkDMOA+e50sK2qO/XvMhOzNoeH/cnM3eVACj73h0eiqIaWuYXj0a8eeaNj7WexvrGN82qoU/SYwUIH08tLZWIbQdrTMrqzXOTr1S8mMKmhpKQSLXPv0oEKP/lMwfRIUBuQnjjJklqmveGcG7gzu+h0+IE94AILEuShXwTO6ywlMylqVf4PX4Bt66gg0wBJf4iux+4oo2Kjda8EllHkW5GaTUsS16JFzA0QDLB2W73pcoMXtXbAOREVqkCVUpEAlNnGweDo4FoA5jRocERdeeMf9Zh/n2FTNufUmGEehMwGQ3CWs1+qPYxY2XkzA+REiRr5PBkQ1NxNUEvqiWrLABy8CihXY83JwZXGfrg6ZuREetRxbVJbrIlS2w2NArYe9x+GPONnQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(110136005)(36756003)(8676002)(66476007)(64756008)(76116006)(66946007)(6506007)(2616005)(91956017)(66556008)(4744005)(31686004)(5660300002)(8936002)(316002)(122000001)(38100700002)(38070700005)(186003)(71200400001)(83380400001)(6486002)(31696002)(53546011)(86362001)(4326008)(66446008)(26005)(82960400001)(2906002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZWtRbzNRa0U1Vjh3alBtNGh3bHBaWVBmNWpjZ1R1endMR2dXL2MwQjhENGR6?=
 =?utf-8?B?MXIzNldYK1VoOGtkb3FybFdqQXU4cXJtdi8vRVd1Z0hONU5WcFFFaW9NU09K?=
 =?utf-8?B?K3J3ZExuQ0NTU0hwWHJ0RWRmTGNoWEJVMTJYNVUwZkdlYUlWOUZGaDZ2eTRX?=
 =?utf-8?B?SWlPSkdtampXSUw1N0tsYlFnRS9sV2JhZHZnWk5RZSs5bnNBc0IzcGZxU1Mv?=
 =?utf-8?B?MDJLWnl4aVpkN3RLT3VlRUdQRGZ2NjNQRkdheVhGVHVOQ29LTHIzcTJ5a0Ri?=
 =?utf-8?B?enB3Nk1iV3JWRkpiMkwzUzh5aVJyL3hRbml1RlFmelBCMklXWE5kZmczaUIy?=
 =?utf-8?B?ZDB3ZUxMZ0NjYnQvZTJISzVHQnFYMFhiSDJlQVJ5OWNCczdHMFEydUlQUU9p?=
 =?utf-8?B?aDNvSHNlUzJTTTVHU0J2VzVsTnM2TnJyYXlwYXBUeXZQcGhnbG9BTk5OOW9n?=
 =?utf-8?B?YVl1b3NQb3NDWkp5S2EwNGJDTDVUNHg2OVVuZWtkYXhOa3VjdElGa25Rc1BP?=
 =?utf-8?B?T0ttT0VyWkxKM1ZwMHVyUnQzR2FFc0lSU2RBQ0U1UzdwaDhmMEVDT2NrQllM?=
 =?utf-8?B?MUZwMVZzaWJCNndndklFbENPVFJiaTVTNHFhMzBnOGhtTFBmd2gxcFVGcmxF?=
 =?utf-8?B?MmlQL0phOEMrSUtkOTJHeXE3M2RiVUZaQ2RERTBTT1l0anJDQkh2ZDczSlEv?=
 =?utf-8?B?a1hBZ2t6QW9RNmN6TWVmZ3RIQUFacjNHcUNSSHRIdzdtZGVPSzZQK2xjTXBX?=
 =?utf-8?B?UXdXK3NuaEZ5Wk5ucTBDZWxzWFc1WFhpeXFUSklFR2loVnRUVi93UFdyNkJ0?=
 =?utf-8?B?OG8yYjJDTVlDTEdiZzZQZ3VIMVd3Z0grUFArMjluWGYxRzQvWmhYY1czMFhy?=
 =?utf-8?B?a0RTMkdJRnVoazluVThWTG5WdDlKTUJZSHNDMmZJNHhUN3FSQjdTSEgyZkpt?=
 =?utf-8?B?UDd1YXJDREluaitNalY5N1NrbkZTaXdrKzNPaElPMjhBN21LRE0wTTc5TUNP?=
 =?utf-8?B?Q3ZlS3lIalRDc1VXb05XdlQrNEZFVGFJUWhya2VIVXhoMFFKbU9rSXJDS0xM?=
 =?utf-8?B?Ym93K3Rodk9hanpHMDUvaVF2dUs2RGo0OGQzMnBoR3FVUDJnU2dNWjM4b3Yx?=
 =?utf-8?B?VHNLemVFU2N2LytLUDUyK0UwKzNlOU9HeUd2Tys0RzFPQUhYRzV4alN2MEww?=
 =?utf-8?B?NmsyQnNWNFkyTDZoTEp0SUdMWVRZZndaMUNUZjlPSVgxVXNKUWhJSFVOOTlB?=
 =?utf-8?B?Rk5VVENPYWE1ZkJtWU4xQk9uTjJEZzg1dGd2QTZPOXpzV3pMU0Z0WTRzeVJG?=
 =?utf-8?B?RXVqcFJTK0pWSFZyUW10M0YvV1drQ0krOTlVQzVGVmZtVmhKc2R2czY5eUh1?=
 =?utf-8?B?QkZhcG5KNmVRNUNYbTJ0c0s3MVFNb1VnTnhaM1JLSmpkOHVISnlTWnVCN2FQ?=
 =?utf-8?B?OVI5eTJqVzRYdkQ1UlJXNE4rNWNHdlpLWW1ld1g0UEFRa0dhT05kTUoxeUV3?=
 =?utf-8?B?WTJ3Q1A0MzdXZWlML09nc2dPRzVRcm9jRVNJa0VjTGpkWWg1Y2JtMEdBT0hh?=
 =?utf-8?B?d0FibnFQQVdIN2VoV05lNmUrSFNxbDhVcjNJejcvZEJHT0JPYnBON0JYdGtv?=
 =?utf-8?B?R2tXdWVZRWlaeXFKanZTTE0wN3BxZGhoU2FxMUtHRGg0VUNiQW1GcXpENlhQ?=
 =?utf-8?B?aEVRZXo3Y2o5dTM5MmJtK3JtbHVTM1N0MDBrOGZhY2x6bFlOYXQwTUVYbUVy?=
 =?utf-8?B?T2hpZk5FNnVNU3ZpUXB1WG5oY2UzNlhWZlRBZ2Foeksva1RyOEtQM3ArTFk5?=
 =?utf-8?B?dDNocUt0cU1yQnJPSXRZZTAwSG5IWHduKzNuT2tSL1hSRUhITi8yODJmdUNq?=
 =?utf-8?B?NUtvMUh5SWdvb1ZwdmNWa2cyeks4cnkyTWRDai9vRjh4YzVMcldJb2c5dWdx?=
 =?utf-8?B?ejBBcld4T09EM1hVZlNQQ2lkMUIwMW9BdjZNMGo1dERuVWxYeHNqc2JqVUI1?=
 =?utf-8?B?bDhFb210bmp1RzZxK1hab3ZGa3NEc1RVR2tLZHJnNjJmc0RNMlZ3WHpndWda?=
 =?utf-8?B?Njc3RWYraWphS2VUNVNodWdQQ2FxZ3hROVZuNUtka0FXc1F4WFp1bWk0NXdE?=
 =?utf-8?B?eVNnOHM3UUtCYm4xSlhGQ0xZR2t1VkFQa1AyZDZJMExFaUs1MWdnNk5QL3M5?=
 =?utf-8?B?Yk1seTdaVWp0NENML1VEWXpYSDNyQno4S2pUYVNZRW5lczVwYWExdXpLa0hj?=
 =?utf-8?B?dE9lbGc3SndmWE9uM1RObDMwLzRLQW8wSXIrKy9VU0lZdDdZZldwVTRKQzd5?=
 =?utf-8?B?dytsWndhNjhSOFJjZVpTZ21vajVjZDVrQTFpN3B6MFMwTmtUNHdPUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <71317D0892200648B53DBE61F2BFA9A7@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 819a64f1-f581-4ef0-9376-08da21f2385f
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 10:49:03.6686
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tm/Nr6eeFrimz2HrNh1OIyL1JZOGQHhqBwczeprlbop52auk/5BLavVD8dJAFv1fSqfk21OatbZUP4S/8LO8tlDdBp8k2vfh/orAoOv7vkA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6015

T24gMTkvMDQvMjAyMiAxMDozOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEJlc2lkZXMgdGhlIHJl
cG9ydGVyJ3MgaXNzdWUgb2YgaGl0dGluZyBhIE5VTEwgZGVyZWYgd2hlbiAhQ09ORklHX0dEQlNY
LA0KPiBYRU5fRE9NQ1RMX3Rlc3RfYXNzaWduX2RldmljZSBjYW4gbGVnaXRpbWF0ZWx5IGVuZCB1
cCBoYXZpbmcgTlVMTCBwYXNzZWQNCj4gaGVyZSwgd2hlbiB0aGUgZG9tY3RsIHdhcyBwYXNzZWQg
RE9NSURfSU5WQUxJRC4NCj4NCj4gRml4ZXM6IDcxZTYxN2E2YjhmNiAoInVzZSBpc19pb21tdV9l
bmFibGVkKCkgd2hlcmUgYXBwcm9wcmlhdGUuLi4iKQ0KPiBSZXBvcnRlZC1ieTogQ2hleWVubmUg
V2lsbHMgPGNoZXllbm5lLndpbGxzQGdtYWlsLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpJIGRpc2FncmVlIHdpdGggdGhlIFJlcG9ydGVk
LWJ5IHRhZyBoZXJlLsKgIEF0IGJlc3QsIGl0J3MgImFsc28gbm90aWNlZA0Kd2hpbGUgaW52ZXN0
aWdhdGluZyIuDQoNCkZ1cnRoZXJtb3JlLCB1bmRlciB3aGF0IGNpcmN1bXN0YW5jZXMgaXMgdGVz
dF9hc3NpZ25fZGV2aWNlIGxlZ2l0aW1hdGUNCndoZW4gcGFzc2luZyBET01JRF9JTlZBTElEID/C
oCBUaGlzIGhhcyBiZWVuIGJyb2tlbiBmb3IgMyB5ZWFycyBub3cNCndpdGhvdXQgcmVwb3J0LCBz
byBpdCdzIGNsZWFybHkgYW4gdW51c2VkIGNvZGVwYXRoIHVuZGVyIGJvdGggeGwncyBhbmQNCnhh
cGkncyBpZGVhIG9mIHBhc3N0aHJvdWdoLg0KDQpGaW5hbGx5LCBhcyBJIHNhaWQgaW4gSnVlcmdl
bidzIGVtYWlsLsKgIFRoZSByb290IGNhdXNlIG9mIHRoZSBidWcNCnJlcG9ydGVkIGlzIHRoYXQg
bm9uLUlPTU1NVSBzdWJvcHMgYXJlIGVuZGluZyB1cCBoZXJlLsKgIFRoYXQgbmVlZHMNCmZpeGlu
ZyBhdCB0aGUgY2FsbGVyIHRvIGlvbW11X2RvX2RvbWN0bCgpLCBub3QgaW5zaWRlIGl0Lg0KDQp+
QW5kcmV3DQoNCg0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:51:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:51:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308021.523496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglSI-0006R3-6R; Tue, 19 Apr 2022 10:51:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308021.523496; Tue, 19 Apr 2022 10:51:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglSI-0006Qw-3T; Tue, 19 Apr 2022 10:51:34 +0000
Received: by outflank-mailman (input) for mailman id 308021;
 Tue, 19 Apr 2022 10:51:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nglSG-0006Qo-1d
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:51:32 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id abcd5b86-bfce-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 12:51:31 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 948E021100;
 Tue, 19 Apr 2022 10:51:30 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4865F139BE;
 Tue, 19 Apr 2022 10:51:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id DAgpEDKUXmKrOwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 10:51:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: abcd5b86-bfce-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650365490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0KXDOlOAsbfRkUsP9+BhcYu9O+w7nHCoNL3lK1Qw0/k=;
	b=W6SbBAKjEt5kstoGANYjYJnz2xDOcBtYB+fkhGnz9Tm3XGeQPXBDic8c7/tIuWZYV6/Wzt
	3D7MnjnmGpT+zs3qA7VeRIzVBj4wqzYhyqdTIaHQbhIO0cJdpXb6t9bX6NEmv6tkbAQVQs
	xmk3DsFHR7ofYEO6+u5ROUsI1pwiX0I=
Message-ID: <b10ad983-de3e-029c-6fa4-6aa646671fc5@suse.com>
Date: Tue, 19 Apr 2022 12:51:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
 Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, George Dunlap <George.Dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>
References: <20220419101850.3045-1-jgross@suse.com>
 <5c6f75d7-d5d1-856f-c8d0-da1bd823be63@citrix.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
In-Reply-To: <5c6f75d7-d5d1-856f-c8d0-da1bd823be63@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------Y2Ln0wTLdp7PiMy7E00vVYCY"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------Y2Ln0wTLdp7PiMy7E00vVYCY
Content-Type: multipart/mixed; boundary="------------esl6dE34kW9zwp5zUqFjuXnO";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
 Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, George Dunlap <George.Dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>
Message-ID: <b10ad983-de3e-029c-6fa4-6aa646671fc5@suse.com>
Subject: Re: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
References: <20220419101850.3045-1-jgross@suse.com>
 <5c6f75d7-d5d1-856f-c8d0-da1bd823be63@citrix.com>
In-Reply-To: <5c6f75d7-d5d1-856f-c8d0-da1bd823be63@citrix.com>

--------------esl6dE34kW9zwp5zUqFjuXnO
Content-Type: multipart/mixed; boundary="------------Xy9LY9zJk6M7F6A7jbaHMel0"

--------------Xy9LY9zJk6M7F6A7jbaHMel0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMDQuMjIgMTI6NDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDE5LzA0LzIw
MjIgMTE6MTgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBBIGh5cGVydmlzb3IgYnVpbHQg
d2l0aG91dCBDT05GSUdfR0RCU1ggd2lsbCBjcmFzaCBpbiBjYXNlIHRoZQ0KPj4gWEVOX0RP
TUNUTF9nZGJzeF9ndWVzdG1lbWlvIGRvbWN0bCBpcyBiZWluZyBjYWxsZWQsIGFzIHRoZSBj
YWxsIHdpbGwNCj4+IGVuZCB1cCBpbiBpb21tdV9kb19kb21jdGwoKSB3aXRoIGQgPT0gTlVM
TDoNCj4+DQo+PiAoWEVOKSBDUFU6ICAgIDYNCj4+IChYRU4pIFJJUDogICAgZTAwODpbPGZm
ZmY4MmQwNDAyNjk5ODQ+XSBpb21tdV9kb19kb21jdGwrMHg0LzB4MzANCj4+IChYRU4pIFJG
TEFHUzogMDAwMDAwMDAwMDAxMDIwMiAgIENPTlRFWFQ6IGh5cGVydmlzb3IgKGQwdjApDQo+
PiAoWEVOKSByYXg6IDAwMDAwMDAwMDAwMDAzZTggICByYng6IGZmZmY4MzA4NTYyNzdlZjgg
ICByY3g6IGZmZmY4MzA4NTYyNzdmZmYNCj4+IC4uLg0KPj4gKFhFTikgWGVuIGNhbGwgdHJh
Y2U6DQo+PiAoWEVOKSAgICBbPGZmZmY4MmQwNDAyNjk5ODQ+XSBSIGlvbW11X2RvX2RvbWN0
bCsweDQvMHgzMA0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMzVjZDVmPl0gUyBhcmNoX2Rv
X2RvbWN0bCsweDdmLzB4MjMzMA0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMjM5ZTQ2Pl0g
UyBkb19kb21jdGwrMHhlNTYvMHgxOTMwDQo+PiAoWEVOKSAgICBbPGZmZmY4MmQwNDAyMzhm
ZjA+XSBTIGRvX2RvbWN0bCswLzB4MTkzMA0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMmY4
YzU5Pl0gUyBwdl9oeXBlcmNhbGwrMHg5OS8weDExMA0KPj4gKFhFTikgICAgWzxmZmZmODJk
MDQwMmY1MTYxPl0gUyBhcmNoL3g4Ni9wdi9kb21haW4uYyNfdG9nZ2xlX2d1ZXN0X3B0KzB4
MTEvMHg5MA0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMzY2Mjg4Pl0gUyBsc3Rhcl9lbnRl
cisweDEyOC8weDEzMA0KPj4gKFhFTikNCj4+IChYRU4pIFBhZ2V0YWJsZSB3YWxrIGZyb20g
MDAwMDAwMDAwMDAwMDE0NDoNCj4+IChYRU4pICBMNFsweDAwMF0gPSAwMDAwMDAwMDAwMDAw
MDAwIGZmZmZmZmZmZmZmZmZmZmYNCj4+IChYRU4pDQo+PiAoWEVOKSAqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqDQo+PiAoWEVOKSBQYW5pYyBvbiBDUFUgNjoN
Cj4+IChYRU4pIEZBVEFMIFBBR0UgRkFVTFQNCj4+IChYRU4pIFtlcnJvcl9jb2RlPTAwMDBd
DQo+PiAoWEVOKSBGYXVsdGluZyBsaW5lYXIgYWRkcmVzczogMDAwMDAwMDAwMDAwMDE0NA0K
Pj4NCj4+IEZpeCB0aGlzIGlzc3VlIGJ5IG1vZGlmeWluZyB0aGUgaW50ZXJmYWNlIG9mIGdk
YnN4X2d1ZXN0X21lbV9pbygpIHRvDQo+PiB0YWtlIHRoZSBhbHJlYWR5IGtub3duIGRvbWFp
biBwb2ludGVyIGluc3RlYWQgb2YgdGhlIGRvbWlkLg0KPiANCj4gVGhlcmUgaXMgc29tZSBl
eHBsYW5hdGlvbiBtaXNzaW5nIGhlcmUuwqAgVGhlIGFkanVzdG1lbnRzIHlvdSBtYWtlIGFy
ZQ0KPiB3aXRoaW4gQ09ORklHX0dEQlNYLCB3aXRoIHRoZSBleGNlcHRpb24gb2YgdGhlIGZp
bmFsIGh1bmsuDQoNClllYWgsIGFuZCB0aGlzIGlzIHRoZSBvbmUgcmVhbGx5IGZpeGluZyB0
aGUgaXNzdWUsIHdoaWxlIHRoZQ0Kb3RoZXIgaHVua3MgYXJlIG5lZWRlZCB0byBjb3BlIHdp
dGggdGhlIHdheSB0aGUgcHJvYmxlbSBpcw0KZml4ZWQuDQoNCj4gVGhlIGFjdHVhbCBidWcg
aXMgdGhhdCBub24tSU9NTVUgc3Vib3BzIGVuZCB1cCBpbiBpb21tdV9kb19kb21jdGwoKSwg
c28NCj4gd2hpbGUgdGhpcyBpcyBnb29kIGNsZWFudXAgdG8gZ2Ric3hfZ3Vlc3RfbWVtX2lv
KCkgaXQsIGFsb25nIHdpdGggSmFuJ3MNCj4gYWRqdXN0bWVudCB0byBpb21tdV9kb19kb21j
dGwoKSwgYXJlIG5vdCBzdWl0YWJsZSBmaXhlcyB0byB0aGUgY3Jhc2ggYXMNCj4gcmVwb3J0
ZWQuDQoNClRoZSBzYW1lIHdheSBub24tYXJjaCBzdWJvcHMgbWlnaHQgZW5kIHVwIGluIGFy
Y2hfZG9fZG9tY3RsKCkuDQoNCldoYXQgd291bGQgYmUgdGhlIHJpZ2h0IHdheSB0byBmaXgg
dGhhdCBpbiB5b3VyIG9waW5pb24/DQoNCklNTyBhbnkgc3Vib3AgaGFuZGxlciBjYWxsZWQg
dW5kZXIgdGhlIGRlZmF1bHQgbGFiZWwgb2YgYSBzd2l0Y2goKSBzaG91bGQNCmJlIGFibGUg
dG8gaGFuZGxlIHVua25vd24gc3Vib3BzLiBUaGlzIGlzIGRvbmUgZm9yIGlvbW11X2RvX2Rv
bWN0bCgpIGluDQpKYW4ncyBwYXRjaCBieSBub3QgZGVyZWZlcmVuY2luZyBkIHVuY29uZGl0
aW9uYWxseS4NCg0KTXkgcGF0Y2ggaXMgZml4aW5nIHRoZSBvcmlnaW5hbCBwYXRjaCByZWZl
cnJlZCB0byBpbiB0aGUgRml4ZXM6IHRhZy4NClYxIHdhcyBhbm90aGVyIHdheSB0byBmaXgg
dGhhdCwgYnV0IFYyIGlzIElNTyB0aGUgYmV0dGVyIHZhcmlhbnQsIGFzIGl0DQppcyBldmVu
IHNpbXBsaWZ5aW5nIHRoZSBjb2RlLg0KDQoNCkp1ZXJnZW4NCg==
--------------Xy9LY9zJk6M7F6A7jbaHMel0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Xy9LY9zJk6M7F6A7jbaHMel0--

--------------esl6dE34kW9zwp5zUqFjuXnO--

--------------Y2Ln0wTLdp7PiMy7E00vVYCY
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJelDEFAwAAAAAACgkQsN6d1ii/Ey+O
Nwf+JNOG4Z3JdOq4z0jkXDSulV/m1RiT65/a0PhEz5+acscEds7Tp5Elx8OinFjFTbqav6+oIsRG
6ayhfdPOvd9RJcSjJg4F+aerAZtoVFhmzznDPbhJv/yEttedCUBmrWo2xib5a3THZX6257IQLmpP
/2yBeJp+vQ8VRbXJccYgOIRRyEc9ywg5kf5Am9mWJCXdThI0hcrz4moh3g/H8WMbdIUkHtUJzE49
M/E6U3L1nsPKXijM4Ar9pbbzIq+fg4dSWkF6q8XDgBVfqMD5lGINVEHwa0xDKB88qK0vU9kUbxKi
abgUvZnZZXb/zqH+6jDt9C4r80Bm3FLvcQxOcoQtHw==
=jHc9
-----END PGP SIGNATURE-----

--------------Y2Ln0wTLdp7PiMy7E00vVYCY--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:54:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:54:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308027.523508 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglUn-0007B0-Mb; Tue, 19 Apr 2022 10:54:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308027.523508; Tue, 19 Apr 2022 10:54:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglUn-0007At-Hh; Tue, 19 Apr 2022 10:54:09 +0000
Received: by outflank-mailman (input) for mailman id 308027;
 Tue, 19 Apr 2022 10:54:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nglUm-0007Ah-Uz
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:54:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 09645d59-bfcf-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 12:54:08 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-u_EAGbj1OrKxVgDgG071JA-2; Tue, 19 Apr 2022 12:54:02 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4097.eurprd04.prod.outlook.com (2603:10a6:208:60::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 10:53:59 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 10:53:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09645d59-bfcf-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650365647;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7h+da+QdWxygBAW2R25rF/7lk6rFTbxvXXUPBaw9IBg=;
	b=RpYb4Lp8qoNKLfHnleNU1yHm2j/JQXeLT7dhCvDY+SlfO7LQ6KtGUNjfSw0y7FXnpxzvjs
	l04liptKuwkABNo5EmLSMNbGITUFaxKVzxYC81NRdVaK1SBfx6FGRtB7GNIGuzafgJikqV
	Ntyg2HiE362ze/ZLXfXEtWFjwJZBJ6c=
X-MC-Unique: u_EAGbj1OrKxVgDgG071JA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oAxfRj8QT0FtEhQbUwzQ5e8g5yzvvczW9rz5bjwNpXR1j7Aqz+yZEH21V9fXYzKIRqwlSmRcVDXYBtn8KZE/qcL846klYsQWqzR2syFl9EihmSJEu481xJCqeseNpwzC3Rs5+/w3PKYwQt+yb+6OuGpUKXajGpAsoVBclyV5/RuD4aQpcjAcofsIM4GVQ40LTUM+dlRrlekQDUpXB4iScIFT3XjPWJ8VGzyBD3uSAB4gUDFFxWN6eVazdTtpX2VLvqWFMPXaffi89wIEIcuoGqzvXRG4TBsYgocKBf83fu3wJbAVMe4VMEbBG31oBTw8xGXnf5zp8OBSrppDz0cxVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zoxhfr82Occigyy5m+24ZIHn+JCHCGZqZG110RjXNHE=;
 b=VYRrk4KnEnZmShOIwSslyqFpnBB41twvPgjFt2A3/w0plHzVX1sjd9bVIMojt0uBF1Z6kcQH1HY2AePtYx7ODKQwjShrFdpV8wCd6obDXRMzzaKfHscBUMtX5oD89uiaoE8NTBd2NqxVZu7wK6BXJQfzmxsXrI8VCAp7uuht561j/6YHeM7FON1ZlHURTRXzAUUyuTEv47Prp6O84jPBCyy3If92xqtOdcUm/jnUbdVuvB5yEwEaDA/MeS8GqFsokC/gNYs8FtqgiqxYaROlyE3cdj7RB1ZVdN1HEKwpQL8So4Ny22bNkH87CGDGV3GlTa1LA6CEV6xDWktw57vYfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9bb52891-08b1-eac7-7bee-7d6038d12e40@suse.com>
Date: Tue, 19 Apr 2022 12:54:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
 Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>, Juergen Gross <jgross@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220419101850.3045-1-jgross@suse.com>
 <5c6f75d7-d5d1-856f-c8d0-da1bd823be63@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5c6f75d7-d5d1-856f-c8d0-da1bd823be63@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR07CA0050.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::7) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89c565dd-3936-49b3-09e5-08da21f2e891
X-MS-TrafficTypeDiagnostic: AM0PR04MB4097:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB40979764A227994051D6160EB3F29@AM0PR04MB4097.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MxaZKtp0qfohAZ/6RHivrWgCgrYFb0cd8pAeapDbhLnkPOnclm4hVRVB8V6KH9PpWL4v0r3WuPjH7t30ffls5nEFeEPg5kAnj52tdUOY2I4+iSYKnzKTxanzEaEA5pK+V/gXy6pWnex3th2P+K38LWiaQLIil4Dyr2GcpedEQYUAvfm8GZk8iyCqEpA4rulGQpJW+HjSUP6OUpItzwH6UcaAb3OIwd3pOWnstV0l9C9TPe1d1KetJrRCjt5HNXxgQ1H/4u8sDzoqLrkgm2gKomfQRm92ygPsqMaGvn6B/402pZ+aTCPaKO9JaysFl6PMO566AJCIRR5fybbTxUq2gduhKHKJau2VKVXRTXA2GWPf25skuo0vQsUJb4TNE45jc03ztIcJVtxBjdwfdgIjGOb8mSbWf/hkz6wUrGUU2cxkFa/LrA6rB1kxBCGytwtF46hjGSdZOaDSrjHxPNR4YpTsm0/pM7phNMkFiCiUQQxwyNlL78K4KAu+dw6mctKbKmXYEkjpWJnXnRoeWZWf+aGgCskhnJJEx+usv9prKsnewXSJ9f/t+PGVG6yWqyK+uO8iJBvSmzln2+gjPkeujuxe2UaniGiZBDhXFeBvMtSMLgNajG7Lk9LYH0yaUl+Vj2vWeKYH1j2S2wQMHeMEISkUTsna9z6fbVWajRKZNxfRjFJ1/xNrOrVixAG7mz9wqY61oiuYOU0IAF1h0p3n04zQui8kL9LYbp9/Aztysko=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(6512007)(186003)(4326008)(66946007)(8936002)(31686004)(36756003)(6486002)(2616005)(5660300002)(508600001)(2906002)(66556008)(54906003)(86362001)(66476007)(26005)(6916009)(31696002)(8676002)(6666004)(6506007)(316002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Ez1iDW+3c04mYlXAZynjWwhSZO9ZMoHZvRz5T2EJrcM7VhCFY9Qd0WNYxcIn?=
 =?us-ascii?Q?X622+XW+EnVuS4kekmYCcawLZ9cPSTq5qcx5gTRdhSjD8OlZCsmILuwzwofH?=
 =?us-ascii?Q?t4v0ZTxQnfz3MYrrzGM+Q3bnlE7N/3MNTffw0ojUH+X/bvsv4f0DjM2Hq+wI?=
 =?us-ascii?Q?C4Raa0oZGlGhiHOx/9YiTWwxu7ubona0jV0QYDvaRZJwkxU2nt3r3nG6EcP9?=
 =?us-ascii?Q?OpLHsMDWOND8peNENQnHfLwthbfPqIGrxDPb2tlXfdv4+48y88DeMI/3lZrh?=
 =?us-ascii?Q?WdvRn0heODXHoBDh0tKotnDcS+Tbl1v68xvTrKqtJ7pozvwdgZXNYzN7XMG+?=
 =?us-ascii?Q?8umZ0+3eSfjQ2xVTmS+UvwATSMlX4HKRItYYkiVkXwlYgk1ekaWr2RwHxuQg?=
 =?us-ascii?Q?3DAuY04iFswlbs+9O3P18aLhb+hr32RC5CHZtdcUBtooSjSr22zCqFDn2s3W?=
 =?us-ascii?Q?6uKWiuaxkueGyf0EwadQ9jPSWIBvAvNh635sfGNruXFwpLTC9LxtYggWVjrq?=
 =?us-ascii?Q?0kr1eH7ZKDYX/PCoaLDPyGRj8AO2KD45axW5dM907Lk4dPSfGnIJ3qJh1V9A?=
 =?us-ascii?Q?1/aEH9K30VHkya5UUNbOjT4yuGS+KBVEo141F8RcFdbyQbP1V960BJ+IkEuT?=
 =?us-ascii?Q?5Rch/4qMRIEJTTQFDGiz4wDytzfFdTrqCJEwI40/EyxvDrDvleo6XNYuAAmk?=
 =?us-ascii?Q?6d0u9tLrh9l7SGf1U1B0X4HH89nGAodZDIKGXLMFdsEzVUm++io80DPwVR+t?=
 =?us-ascii?Q?zJBz5nBuiMbzt8cx2ACdqmb1Mks//vMJjGkbk/lk6cz2T0gdAdaHP/uEbzkj?=
 =?us-ascii?Q?D3Hrkt8StCezLk9QgJf1GstJvhxhageLiY6un7ywIPCqO2lodasFuZfqjPHS?=
 =?us-ascii?Q?dGk2OIsTEuhwyvX17kIZmYCHjCmkGMRfm1l6bMB2HXIP8fnHKPs9cpvg82cj?=
 =?us-ascii?Q?mwKsNe9Qjt7uaNkTqC6peQQuNorTHtbDLWb4JB3jiT0F+NXgKGZUAQCXb6MH?=
 =?us-ascii?Q?LuNdhglw2g2rp33gKFHljQ0ceJAbYV7xYxvO5Ja+RvfGGr5YrRziVXUNws75?=
 =?us-ascii?Q?VfXmEZ5ZkVK9ilBFbtCZKcpJg2g9x3ZW9wI9+bzF5aopH5EHReAmUQzOD+Ba?=
 =?us-ascii?Q?1BfnbtR8eT+JeuF7z0gJJenMmNyC1IEQWGskFQOs3dAl4ndjpgDBxj6SV4fe?=
 =?us-ascii?Q?NIqEnYZhwoTB+0ZVcTIqzbOl0XwHzvYwpvXu/uL4Ozhb7QbpAM7A5G5Bblw5?=
 =?us-ascii?Q?iSa9pMBl33ErHZxVQdYrc9GhIQccjqs883G6xtLl/wrLTHI05Vfy3UoNVZTD?=
 =?us-ascii?Q?+0GmVGaVIqPgFiKVt1C4wQZQl8uz0Aoa+Ok9C254PnCA5H7oHzLQCtHNUHDu?=
 =?us-ascii?Q?mWtBzgtMQmL5VbW0qEkRmM8Y790Va90Mso4nyJsc4MsjoqaPFEs3FiXPxq49?=
 =?us-ascii?Q?ghg6ITmpfSiuYqvjhOV/Ddw4e6fb3LJ/rh8kgTIcIgq+/UckvPRK6+c025/K?=
 =?us-ascii?Q?5mPpIGflUidF4L4M7j4Wo2KSJvYZ6cRwYDzwFu4HBjS1Pr8bQhAJBQm0SVmN?=
 =?us-ascii?Q?zs1WLI6OOgOcYeI43N4L8tdYStBJgXeahpIikcHl7rPZxgVNayOVPRZMG3E3?=
 =?us-ascii?Q?/qGg7N7PAnyJd0V8vaHj2+GT5k9PIk+16EoXkdz3Ky3KHPv9vrkvCRPwYXQj?=
 =?us-ascii?Q?gaXrKv77Eap28cEd4lJF+LBk79jcpplnAoruzSZWvnkAc9lQZq+wjAun44Jw?=
 =?us-ascii?Q?cW9zxdSVvw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89c565dd-3936-49b3-09e5-08da21f2e891
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 10:53:59.5530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +6vzw9LNMX3IC51cI8c6uDv4feFzDIPQznZZT1pGARjFRV89KgpvT3TYZxdH0V362N0GiRE+s2nbzYivmIpYFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4097

On 19.04.2022 12:40, Andrew Cooper wrote:
> On 19/04/2022 11:18, Juergen Gross wrote:
>> A hypervisor built without CONFIG_GDBSX will crash in case the
>> XEN_DOMCTL_gdbsx_guestmemio domctl is being called, as the call will
>> end up in iommu_do_domctl() with d =3D=3D NULL:
>>
>> (XEN) CPU:    6
>> (XEN) RIP:    e008:[<ffff82d040269984>] iommu_do_domctl+0x4/0x30
>> (XEN) RFLAGS: 0000000000010202   CONTEXT: hypervisor (d0v0)
>> (XEN) rax: 00000000000003e8   rbx: ffff830856277ef8   rcx: ffff830856277=
fff
>> ...
>> (XEN) Xen call trace:
>> (XEN)    [<ffff82d040269984>] R iommu_do_domctl+0x4/0x30
>> (XEN)    [<ffff82d04035cd5f>] S arch_do_domctl+0x7f/0x2330
>> (XEN)    [<ffff82d040239e46>] S do_domctl+0xe56/0x1930
>> (XEN)    [<ffff82d040238ff0>] S do_domctl+0/0x1930
>> (XEN)    [<ffff82d0402f8c59>] S pv_hypercall+0x99/0x110
>> (XEN)    [<ffff82d0402f5161>] S arch/x86/pv/domain.c#_toggle_guest_pt+0x=
11/0x90
>> (XEN)    [<ffff82d040366288>] S lstar_enter+0x128/0x130
>> (XEN)
>> (XEN) Pagetable walk from 0000000000000144:
>> (XEN)  L4[0x000] =3D 0000000000000000 ffffffffffffffff
>> (XEN)
>> (XEN) ****************************************
>> (XEN) Panic on CPU 6:
>> (XEN) FATAL PAGE FAULT
>> (XEN) [error_code=3D0000]
>> (XEN) Faulting linear address: 0000000000000144
>>
>> Fix this issue by modifying the interface of gdbsx_guest_mem_io() to
>> take the already known domain pointer instead of the domid.
>=20
> There is some explanation missing here.=C2=A0 The adjustments you make ar=
e
> within CONFIG_GDBSX, with the exception of the final hunk.
>=20
>=20
> The actual bug is that non-IOMMU subops end up in iommu_do_domctl(), so
> while this is good cleanup to gdbsx_guest_mem_io() it, along with Jan's
> adjustment to iommu_do_domctl(), are not suitable fixes to the crash as
> reported.

Whether non-IOMMU subops ending up in iommu_do_domctl() is a bug is a
matter of the position you take: Considering how we chain common -> arch
-> IOMMU domctls, this can also be viewed as intentional, with further
chaining going to be added anywhere in this set. The downside of your
approach (which otherwise I think would have been the way to go already
when the IOMMU domctls gained their own function) is that at least one
higher layer will need to know which specific sub-ops the function is
going to handle. If that was acceptable, I'd then question whether the
top layer shouldn't also know which sub-ops the per-arch functions are
going to handle.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 10:59:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 10:59:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308032.523519 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglZW-0007oR-82; Tue, 19 Apr 2022 10:59:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308032.523519; Tue, 19 Apr 2022 10:59:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglZW-0007oK-4I; Tue, 19 Apr 2022 10:59:02 +0000
Received: by outflank-mailman (input) for mailman id 308032;
 Tue, 19 Apr 2022 10:59:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nglZV-0007oE-AS
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:59:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b79de497-bfcf-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 12:59:00 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-QdnaEASgOPWPRc2WzdjMMg-1; Tue, 19 Apr 2022 12:58:59 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR04MB3080.eurprd04.prod.outlook.com (2603:10a6:6:5::21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.20; Tue, 19 Apr 2022 10:58:58 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 10:58:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b79de497-bfcf-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650365940;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=651Ir3xi2t9bra1dRu8jqR7TRzXHsGcij0UhxH5zzDU=;
	b=h0F4v5+U1A/iewqNN2x7Rd7ZQ3iTH70edIoYSZWBABISr83dypOTd2ht+nxU/HSDX7R9PJ
	R5h/seiDXn1Vt5lOLfavlJQM7/UUADhCD2W1rB2rp6HCKneuk/HAH70xJ9RC0+aoA0DcVF
	ijhldX6LFAMgNme6y3STdQ8ttwIfjeM=
X-MC-Unique: QdnaEASgOPWPRc2WzdjMMg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=btUVPc9DhI36+LZgxeth6rJAyr6C35xdc77OyYpCSIEv5wofh5PiQRYKUoWkWQpPaty8rbTb0H52vtm8evwnHAnf24u7pE1GpovQS4yIuyrl22equ+qdPlTXOR83TFV7SCDeOK4XmPJlYVzmN4s1UiNtOf4T3ewyDhc4KfD3WMB4kaJw4YlA7z6ed4eJvTb/i6UJeeQsQVdya+oLu88J8rC6bHZE9A6lbuO47WUiHEbWbUc0k3UQklAcUqJ3II+v//vX2i62Jpa8LKtv+5y5P3w8MU0nOPm8r8A+fOkg2hGc4NRb4f/whW5MHOwChA/wd5dQ4lJGNRUKUQ5mDLCwWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XMF2QP4JiD6lAd5TY/BvJitjdqmdkDexMhqRSsWikug=;
 b=d0um1ys+EK4uf3pONYQLQoi60eywYFiCqI5r94ekck1wgM1Ocud5PgodLSArAiX8IANoKjImdNx6FTNUKjXgmRhD6+FHMJ9SruGdmIntsTbVErZKu/iGdZcM6p/7cS0oolD+mfcInSEA9Tjmi6KqJhn/5rQEAUYDc/Lt/8LBtRjpa0FavD+fNVcA6GaTk0UZARWvwEUVTZ7dNJsR7gx1AFX2CMMf6xtgbxDZK8GFoTYNQ4YWYV36D4JJKQIgu/7XQ6GFxxiWXQINQDOlD2tbHvB5WjLlfDutWsWx8+WGj90V4mxFxPAvEcZK/IVSlEZSqiCdAGpRqYb8p1uObWoFeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <48fe2a98-98de-8aa5-8d3b-e70427008edb@suse.com>
Date: Tue, 19 Apr 2022 12:59:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
 <6732a3c3-fc19-cbdf-7483-9f5946f1935a@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6732a3c3-fc19-cbdf-7483-9f5946f1935a@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0226.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d22b18ad-1dc4-49c1-0c9d-08da21f39a81
X-MS-TrafficTypeDiagnostic: DB6PR04MB3080:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB30801EA04B05AEEC828A5692B3F29@DB6PR04MB3080.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9lkuIJr9fyujfboJV6UdBewN3wQa9+mNiQ2nooHTTcBjeCVx2ynQV+EuPhBhOp5v+qce2nUeYcq0NYJ9H/2kgA2MC6/A1/+zFA6F6Dpa8ETkNDonPkJFaIbHSnW/37meID9N+OsTHmFpRbJ/rAlE5nhCRjgiCoCdWotDj0HjmSvVhJp5f9xa6utQ+91ol6b+nIcdVNZQkCcr521QX5EESZsqSKt3zeKMDOasu5nZ/HIa7wzR+aw00gqWGG0i9N/AyBiCOfY4HC3h7B+38hqdaBj6kMKERH9gVSPCrhCDb6gv3/vciIngkFIxfOzgYjLmTjEksW0QSrIKpjZA1WY2H0FZDmy2z0CPpqlPRD1pIA+0riJgQVuAU/zoPFuuHlhIYHZiFCZ/gfF+0mkgsStxvLpKj32XHdtsgy2nX/g9fHZ2/Pu0lFHAx319DRq7tYanxcvPUr6VumN1U3SV+enXR7ZvkkO6iQ/nFGk95DOVAY4y7mg2K6hK8fQR/M+xGyCTmqCFD4MEqrA1/mwE8fou3xbClORelHCbj8hpNCT1Vl606yI6jNYTKa2wX5RdyOHJ7/r8lgu0etDG4OABQ7hKaLEIiXpzjjBNNwraKYF1T47fN9yEp+GYox6U0YjUhXHXiF8aksXd9uwNMCMof4zE9kefjmJ4cdUcm+LLi/sBlzSrYv1oP79I36X6BpTGAX5ADtqLdx5N5eaYNDGhtWFvMKyuYM6SWVvM6XImkzxURj/gERrouP83j7thtMIjN4+a
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(316002)(508600001)(6486002)(36756003)(31696002)(5660300002)(86362001)(8936002)(66946007)(4326008)(66476007)(66556008)(8676002)(53546011)(6666004)(6506007)(38100700002)(31686004)(83380400001)(54906003)(6916009)(2616005)(6512007)(186003)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?niaKALgkQfdI2VlMPHAnIWBGWpCRwc21DT7LSNB3jLyoFVXSNprdWHQIzX17?=
 =?us-ascii?Q?5lUlci8l4b4tAll2Em96rwF8InUMLVZ6/sfJhq4epwtWyRLXTUW7k61hszZP?=
 =?us-ascii?Q?NQEDBUrzcoAztJjP0JRTkNZvpnoFAweqbWuzZVttOiEuwVv2P8Veo9O8zN8U?=
 =?us-ascii?Q?suqxrTq2qQq+Y4G6gz85ergJWYWP6OmXEXuKx9whWGiHWKXl7Ai+YIUAy2t2?=
 =?us-ascii?Q?ns+xRu8R9mFMU1bop7wOGsDZOfezz/gv4SJojrU+u9Hvbf/ZEYDXe2NQ+5s0?=
 =?us-ascii?Q?gKUpOicRskIU5IQR5VUkTF8rOY3WV2xHeUIN5gD8E4Jo0Ve9mjhFBTnVPXq3?=
 =?us-ascii?Q?iNVIBB7GL5qh/OnUQztWu2VNFMqnzxxpsX52kItg3zVv85zvPr3ZY8uFWUqU?=
 =?us-ascii?Q?SseGiii52NJ4Ti6yNGRGIikNWrq4BK2fUMZKZ0hXY81/ysNcpI7RyStJHoB+?=
 =?us-ascii?Q?rtSqAWTQEXuF7f/YoP+knX7yq2sNSarBRZxtrxx4d98uxx7ddtXVkHk0R6E1?=
 =?us-ascii?Q?biobFJE5FWxP2q9pQmEMecKJwbDKRWdtWLuNzQRCpgtYD+j4vjSJd+qpLI5b?=
 =?us-ascii?Q?YNuSqip7tnHCvFp3SzaKoI9ZSgJjwHguFt0tcHpjZ+ElEyJRuPIwRhMPrnow?=
 =?us-ascii?Q?ln2HPQx//JqEu7WR6s1gp+DbUdtn5SdWtr9eTZAdD9Rf2KEe9gTCD8S/iOKd?=
 =?us-ascii?Q?etZ6UHVXYMPlrIqCVtIZ+LTwtNpAJPSeMYlVq9MT0P4KEoH/Wv8xWXDaS+61?=
 =?us-ascii?Q?9+Q/MM4OhSnTW3t+zj5pqR8mqSECV1GiLKRM7138fVMZZp7zmLNDcy3Adzbt?=
 =?us-ascii?Q?guofVYHmgkWGQAQhd0dx7YWEhcOUu/h/dMTgEU49R7BWOV9L5G+ASrEGYRUq?=
 =?us-ascii?Q?nwh7jUZnJpWjaDtmLBBOqePQazccA+Vr8v9ZdSdofDEoqzjbruRsx40ztoNZ?=
 =?us-ascii?Q?9jhDBRM1RIe9vcWt7bcTlZYiPLK5Fd861+VcJ8tVR3yucsq92M+S65Oupy2i?=
 =?us-ascii?Q?RXhQthf5dtqfNrlEkEILxODGXUVjpf9rOA7M59jeswNSIQgtyEzeTUuqMPBe?=
 =?us-ascii?Q?wZPkR69pLGc7itZuSNOVj7/B8WoVce7klTQK6V6yjTJPPZX8hcKvqZV/M5OQ?=
 =?us-ascii?Q?g/n0OgXsFtmlif8i+Iax8ojV8Ww74jP3a7YUeIC6R2TsjG4XypeOlZmTLDJT?=
 =?us-ascii?Q?FUDlXbhtndhoDshA3H2mPi4ApXJJZ6l0KM5dW3OXWn7snE+p+C0Z7yOpjxGF?=
 =?us-ascii?Q?7FEvVb4f4JRx53yy5W5Q8scJmPKp1yUocyo4falJPhtHyIlbcJ+yChe4Zjm7?=
 =?us-ascii?Q?02nIGmjHneMzaxR5g9pY11ZxKtPFoMXNtBvT0et8kc4D1PqAURdunUaAlCvM?=
 =?us-ascii?Q?FphBhEMPDyKpNh/dXgbNEBpJjGTpPCom7OtIc8natVoxGUt7LUwAXRm3muKy?=
 =?us-ascii?Q?ekJclmGV20vii4DRlVSnUxQ1AaO1eeWrpmHF0HSKX+S/daJ8FuadFhKmpWtl?=
 =?us-ascii?Q?N3+HdY1ES8f7k1WLJ/TVdd70qUDQ+uPf/QdNqXk9pw5FTrHJlDR1+2kFJIL/?=
 =?us-ascii?Q?+A/w9YAZFbhVC7F8luhtM8ISYJClMLRhIq3qRYa2QghdEXOIEasqLIEYv+fQ?=
 =?us-ascii?Q?hUfVdXX93mqUixKrG+g8t9yyJNXoAnytRC/ETBSLJrt4oEpbdxhpvlyqvjo4?=
 =?us-ascii?Q?cZzp7KKOGV7xbjV0Tvb1QkebI6LzolC99vAQ+WFt3Eb7Lwrip2E5Ev/xjPxC?=
 =?us-ascii?Q?sSDy4wwMSQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d22b18ad-1dc4-49c1-0c9d-08da21f39a81
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 10:58:58.1139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nvieDfRyMWOU8fcCmabrfPNucQLxllsBh5OlLPRF/0wVOoM86rotQ4PvKudZ8XXFPvH/zT4hckTkjH6X5kRj+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3080

On 19.04.2022 12:49, Andrew Cooper wrote:
> On 19/04/2022 10:39, Jan Beulich wrote:
>> Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX,
>> XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed
>> here, when the domctl was passed DOMID_INVALID.
>>
>> Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...")
>> Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> I disagree with the Reported-by tag here.=C2=A0 At best, it's "also notic=
ed
> while investigating".

One can view that way as well, sure. But this change alone would be
sufficient to address the report. (As would be J=C3=BCrgen's change alone.)

> Furthermore, under what circumstances is test_assign_device legitimate
> when passing DOMID_INVALID ?=C2=A0 This has been broken for 3 years now
> without report, so it's clearly an unused codepath under both xl's and
> xapi's idea of passthrough.

I guess xend had a way to drive the domctl this way. Iirc this was
to find out whether a device is assignable at all, without needing
to know of any particular valid domain.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 11:15:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 11:15:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308039.523530 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglpE-00021r-LQ; Tue, 19 Apr 2022 11:15:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308039.523530; Tue, 19 Apr 2022 11:15:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nglpE-00021k-IP; Tue, 19 Apr 2022 11:15:16 +0000
Received: by outflank-mailman (input) for mailman id 308039;
 Tue, 19 Apr 2022 11:15:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nglpD-00021a-Hz; Tue, 19 Apr 2022 11:15:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nglpD-0004oo-CA; Tue, 19 Apr 2022 11:15:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nglpD-0006rK-3P; Tue, 19 Apr 2022 11:15:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nglpD-00073F-2v; Tue, 19 Apr 2022 11:15:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PccBM9I+yzgIRKGBI6XgdKkunllcNeIWdqVzFvqXai8=; b=Mk6pD8htgAT7QDLud8CvXxwCS1
	xO45m5TVNlqplEdT+M7vSfN0wydr6WblKYPXKHU4UZqLJ+WSZuSjq11breWwbhxr1MZ355ZyZkctz
	oAh8zSxSML3hnE9Q4a7tXIo5AHdLduEurrgTDswrD1f/yfZd0Tu5tLEYVPDmdZBhU2f0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169538-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169538: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 11:15:15 +0000

flight 169538 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169538/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  504 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 11:42:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 11:42:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308048.523541 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmFV-0005bu-QO; Tue, 19 Apr 2022 11:42:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308048.523541; Tue, 19 Apr 2022 11:42:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmFV-0005bn-NL; Tue, 19 Apr 2022 11:42:25 +0000
Received: by outflank-mailman (input) for mailman id 308048;
 Tue, 19 Apr 2022 11:42:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngmFT-0005bh-En
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 11:42:23 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c4b33195-bfd5-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 13:42:20 +0200 (CEST)
Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 07:42:17 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CO1PR03MB5922.namprd03.prod.outlook.com (2603:10b6:303:6d::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 11:42:12 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 11:42:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4b33195-bfd5-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650368541;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=qcSjmxtDOAjsYOSIkWfBt4XvmdTtGb2BWbNkcowgQ6o=;
  b=dAoi4+8wNeiFkHmz5nwKFat8c1vdUGyCA4x7M/5VPkpDnID4cHV2AjqL
   qyceJTCdnxhTK0Uuu9JOAuuHSBMU56UcT8utJ5E1/rNkJ0VH7yAUI6W76
   OU41fOO28IGTwkYYUnPMg74skgNjtEwmeaFIRI9Ix6EwUF0EoWIJyyQHb
   E=;
X-IronPort-RemoteIP: 104.47.70.101
X-IronPort-MID: 69399794
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Pdt3LavPAf7MRJHJ4Ayf1sz+FefnVNZfMUV32f8akzHdYApBsoF/q
 tZmKW6DPqzcM2v9fdhzady1pElSupTdmtMySFdv+Ho0FClE+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/U6
 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi80A6vioLUjSCN2LBB0Oaoa3ZbYK1uW5Jn7I03uKxMAwt1IJWRvZcgy3LkyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4AAmm5o36iiHt6HD
 yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvTmInV0ugeSF3Nz9IvmPR/13uXmhu
 0XJ/j3kJCkBEN7E8G/Qmp6rrqqV9c/hY6oQDLq58/RtjXWJy2ATAQFQXly+ydGp2hCWWN9FL
 UEQvC00osAa7EG3Q8Pvdxy+rmSNshMVV5xXCeJSwAWMzLfEpgWUHG4JShZfZ9E88sw7Xzon0
 hmOhdyBLTllvbuYUlqG66yZ6zigUQAfKnUDfmkDVhcf5Mf4o5AbiQjGRdJuVqWyi7XdGz7qx
 CuRhDMjnLhVhskOv42g5kzOiT+oopnPTyY26x/RU2bj6Rl2DKa1aort5VXF4PJoKIeCUkLHr
 HUCg9KZ7u0FEdeKjiPlfQkWNLSg5vLAOjuDh1dqRsEl7270oyflep1M6jZjIksvKtwDZTLif
 E7Uv0VW+YNXO3ypK6RwZupdFvgX8EQpLvy9Pti8UzaESsEZmNOvlM22WXOt4g==
IronPort-HdrOrdr: A9a23:4lXt6aniA7N8LDFeHrddo+S9nV/pDfN1iWdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee
 r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp
 gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e
 XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5
 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe
 q1NdZfH+LjRFGebLp04w==
X-IronPort-AV: E=Sophos;i="5.90,272,1643691600"; 
   d="scan'208";a="69399794"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HkMD9vSZPzzp7S6b41xgGUKBloVIn19S88uk2DAMk7Jm5sMYClpVSqbeWGsTnLNMR38QBf0CJQPtob+D1y/YwRLeDvyNDxX6s/0ezAYhN7/bhIuIrzL0l6UaCHpbsKxRKHIXy6kMkYMgcXjjl+tG//KAVnkJTTUm0oItYGOJ/XZ80Nelpn+70l5npBHTH3iVxdv1y2WyQN5Zdb12r4bC1GiA5iByccEiJtp02qtI+XHfJMfczq8gfneCumxuostUvsIuHNRaXMGDRXvRdRieRid7dJvQeOs2mDgWuqbnDiecp9cpysx1AzKmYOCbPH9kYnxl9jRxyhS/gk/Tt+aSvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qcSjmxtDOAjsYOSIkWfBt4XvmdTtGb2BWbNkcowgQ6o=;
 b=SFnpoIgApVF5roWbU7QLexA5/dhlkJoeyO/Kr6p2xFr80bxrk5du9UNBy1/THHhCyU0bHV/cG1Pj0qdwee3tgGzfvZ3P1mcMkFFcNFjKC4bUlIOrUFIb8MKBjsai5NAT7RJsGeXZ4vyeuICrB5XP1cN7zR0MYbVD1l2fa0sndQyjyZ5LcmDfKfAOvy9w687JuF7HqIn81ZkFUDfAVgY3+9j9p0WcNeFFSSLYk8O63Cj5UogIdHq+uMS5WYmTQOmF7hs2dLk/ridznun3OanEnieDZxn/eciaLNTjmuDP9Hpqtmq+haebgGgH6GO6SMf6mAQOuYc6vKOdtL21wqeMSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qcSjmxtDOAjsYOSIkWfBt4XvmdTtGb2BWbNkcowgQ6o=;
 b=pTqckYFOUsai9RsPyloa+5Yv7l69BYAoM3TkG19Jw1FYti174AMIYUuhk1EBy3/twXT9DgM3Ak1GOHmaBhM24dsW36v36uJ2ZkRBXJUKEUdxYlktYK09W8AZlUknp+PcH6NQ2pY6nhgnZl0YHtFDPJqAnxlbcMd1tr56YR0oFsI=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>, "x86@kernel.org" <x86@kernel.org>
CC: Peter Zijlstra <peterz@infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Miroslav Benes <mbenes@suse.cz>, Boris
 Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Thread-Topic: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Thread-Index: AQHYU0SHTqWJMApeME+vJqcoJU7NiKz3HnsA
Date: Tue, 19 Apr 2022 11:42:12 +0000
Message-ID: <b94cbac6-0a4d-8e4a-ec58-bbd46e385d45@citrix.com>
References: <cover.1650300597.git.jpoimboe@redhat.com>
 <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
In-Reply-To:
 <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9a583dfb-0bea-4305-c9c0-08da21f9a504
x-ms-traffictypediagnostic: CO1PR03MB5922:EE_
x-microsoft-antispam-prvs:
 <CO1PR03MB59228D13F48F381A9950B475BAF29@CO1PR03MB5922.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 8DJcbLeDFxHR4R0qBsGht7bl4BcEvMipS8WCEDc+r1SDVI//jvAnUz6zgPIuIpM1Fwdj52kUR8OYW1SbgTkT17/qjqq8VS0XSgBfhdebpC6sb2s2iNmsiJhd8sQ5UaERqyXA79gOrPZM8iXa1rEpJz9s2WHqkpOXQHqz1ZMeB615HHrGKqQJKr40U2ZUMM8A5vQyMnGfgDSfsOi3I0+e0gjUcOaWT4a2dlJfexcODCDPn4a4USGhSnwgeKNYT66tAwC8W8vyhWI0lGUFqwkaQBjx3P3Qy2yl84X+S+ZvZqkFk4rFr2XE/GFtvYuHsqAp30lvcDqj1Zs+zDWL6OkRtdqrgRhY65rJzRY82P0DiC8d5xDGOIpzFWm17bQHsCFpB8Bklk7NO9vWFC8Nl+8ts/9odYlsBPp0WitTZgRpQ6rwJ9UaJYoy4tbF0aaIgwvYGyXxHFFQEy3CYSEfIxAptkGCjqBh3S+S3Sui7AidJHQlxP+jwl8JqEoVOiv7x5l8jOqpLmf4byILoj79FCevmezHrn/KVNZ92ewafEEJhVrLZD6TIYeiWJdIEHFFvH/qn2V11zhQHO1Q3CZM3kO5+I3E5FZwWX3MIFLrw8FOHfb8iHq/umQLRnkRll+MYZiH4TvTn/i876kNiQ3PB8Rsx/XSzuD5bGEIB7p5os7kxlg0L+kGA4kTpMQQlXsibdEdFepEhQVeAzN2+eDYnZkGt+x6IyAdxKOqUC/2v7kQVe7rAn8EJ5he+ZmmW74GwTiOryp6XrLEJ/bVrCQVC2MaaQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(8676002)(76116006)(66946007)(91956017)(31696002)(86362001)(66476007)(66556008)(4326008)(8936002)(66446008)(5660300002)(38100700002)(122000001)(4744005)(64756008)(38070700005)(82960400001)(83380400001)(6512007)(6506007)(508600001)(53546011)(26005)(186003)(110136005)(316002)(54906003)(6486002)(71200400001)(2616005)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?NytCbWlGSDQ1N0tOM2VhSnFXVjBGRHlwNElFTFJLSVRBNDR3L0Z6YXNIYlU4?=
 =?utf-8?B?ekNrUktxVFZSaWpNUHdNbHdQRzBsSFZadmJ4R3Y3V0NtbHZ1RjVMYUpZOHVJ?=
 =?utf-8?B?VTFVNG9mVHArYm5tbGw1dVZzMnQ0NnRaMUVtMUhlNTk1RVJoSExROTRqU1Z4?=
 =?utf-8?B?WXVpK1hGT2w0MDVYcFNUQXd6NU1EbXNwTkhudnJLMzk3YTNlbFRIcWNzcVJK?=
 =?utf-8?B?NEtycTFYb0x0MFp6V2N5bkx0MGgxS1Y0dFVEeUlZSFltSG9mQitzRlkvbGth?=
 =?utf-8?B?bHArRmdNcUtqcGYyM2plNVJ0VGR5WFk1SWRlU3BZVG5HeG92bUEya3gvd0tx?=
 =?utf-8?B?d09JZkx0V3BNaFJDQ3htV0lGakx4eUZnNmtPejNHOHAxdU9WVERvcU1yYWFz?=
 =?utf-8?B?NkowNXRodWxBTmNkdG0vQjNlUlg0SVlmSU5WRGlTdyswemJra1FVNVI0Ym1x?=
 =?utf-8?B?L1N1cTlBcVpjYjBjaEYrVzJDNXMwQTVQOTREdHc1ZmZNbU5rQnhPZEU3UUl4?=
 =?utf-8?B?d3BrQXhMaXBYYmpTVExKcTlsam9DN1dMT2tySEQ0UVN2ekdQMXdsMWlkZUpH?=
 =?utf-8?B?c3FKUVRDeUluN2Q3LzNMRmFMcEdzQzlGK0ZEQnVnNkp0VGtSV0tHQm55b1pW?=
 =?utf-8?B?dnRWODVqRDJhWTBNUVlvOTBnNlV5V0hMY3hCYVhmNGgyT01HOWxkQmlSdUFl?=
 =?utf-8?B?YmlQMjhkOVhGN2M5dlhNL2RTVERtK254STc3Y0ZpTW5PaG1KZlA1ajhZQzVz?=
 =?utf-8?B?U1hON1dOSUhPZk1WMXNXYUw5UG1iY2JZVFpUMEVhc2pNSnA0eUY1WVdUTmZB?=
 =?utf-8?B?UXIxQTV0eTRHTjRDUG9ONUYwell6V211ck9PVHJwdU1HL1FwbUlpU3dTVkRa?=
 =?utf-8?B?Q2NlTnJrRXZjUFFDOVRjYW45NEM1WDJJNjZGQjhLR0xiS1R3NUZZdUdsU2xm?=
 =?utf-8?B?VXVhMnpFbUxWcE5zYXdqR0RUMGxaeGt0S3RQWkY5RXhtNytLaXBTNVBYNVlG?=
 =?utf-8?B?d3N0eXZpc3pEdWFOeVhQZGQxMHRYMThaRmpPbXFqZGJvZVlWc20xNGVjWi95?=
 =?utf-8?B?RmFoR2dIQ3ljQy81eWZHcUtIbW5UZ2cvcWp3T0w0dFFiRE0zK0J2RlZoUTRn?=
 =?utf-8?B?cFhjK0ZjTk5LZDZ0ajMzWk96allWQTQ1RlBDL0dMbVRBOUgrK3F5aTUzQnY2?=
 =?utf-8?B?MzlvN1hRZEtITWJQS1U5VTJpTStWU0xteFBGNVVNdEhTNDk0UktqRDBmRUVp?=
 =?utf-8?B?VFJwWDNDaWRhUnZsMXRwdHpvbkNPRnUwdGpwckRjK1RRMTM2NWk0WkVJS1VN?=
 =?utf-8?B?VGNuZ0hhM1JDdTA0dEVoVkQ1MzFZUmoxUjVkTnVwb0hTVCsvS3VBcFFubE9G?=
 =?utf-8?B?WXFORy9odUZLTFQyRnE4TjRhTmlqbjNBUWo5Z2taK0NmcDJoS2w2ekRBVEpk?=
 =?utf-8?B?dzhoSWVnZFFjNmxXODRocjBiR01uQlplcjhSM2FEajdUb3JEZ2IxSDlZcThE?=
 =?utf-8?B?QkJzM2pRNVQ3NCs4b1p2emxvQWptaUpjbXJJdnFHQVVKSmIxWDhRYS8rdXla?=
 =?utf-8?B?NkM5QS9IUGgzVnM1MzZlTjhPWmVOZU93czExNCtJMENqVUFwaEJTZmV3R2RR?=
 =?utf-8?B?azNHbFlLQis4VTA0K3NvVUd1V2ovYS9aOGt0RnRVamlyQ0k5bitEUE5PWEh3?=
 =?utf-8?B?WlVNYy9oOE1IbElxTnpuUlhyRWxpK3NuR0hwWXpTVnZmTGtTOUx6TU81WGtw?=
 =?utf-8?B?VzkzZWpqZFdWWis3VzBrUFRmSEhNMnprZDRmZ0xTQnlGWUQ3YWVST1BZS0F3?=
 =?utf-8?B?NTkwczBadnRjWmx4UUxldzUvd1VsN1hZYkh5UzhyT2FLWUVTM0hObVV1Y09m?=
 =?utf-8?B?ekgrYTBOL3pUQ0Y4d1BGSEQ2UnI5UzA5ZWk0V1g3S25pM0lKblAyT2NiandB?=
 =?utf-8?B?aHlhK0pIMkNhSzU1MnFvYjRXMTN3cUZQbXFhUS9aWEZLY2gzRkJPWG9WRnFY?=
 =?utf-8?B?WGFsUjlXaUVYc0hDZVpKSjMvZHVaYnZHbENYNVpJdE9PbGY0MXpta2hTRVUv?=
 =?utf-8?B?OEs1ZVBzVXpJcTA0R1VVMm0xdFcxK0NIZkFreVpTbGt6dit1amE0RHg1bkpm?=
 =?utf-8?B?ancrTXovUzA4OTJkSFNYQUZOWDlFS0doYjBGV2dkWmphU0Yrc1FZaGFhenVS?=
 =?utf-8?B?K3pKWEF6Ykp4K2hkazM3eEN1K1VwWGtUNUNJZUQ1RHJBdGpQWjRHeTB3VklU?=
 =?utf-8?B?K2tJdFZrQ2lIaGlFWkZMRjdEUmFWWUVZSEQ4bTNESVc1c2RrYjMvaXBqN3gy?=
 =?utf-8?B?c2l3TTBzcnpHTFVNaFl6c0RIVERmc1hFVlIwaXNOT3ByazNPL0pHUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D3CB7422250AFC4189676580C0D65D81@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a583dfb-0bea-4305-c9c0-08da21f9a504
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 11:42:12.4693
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iaAKoIdXYqA4c+NRlQIaFpnurO+X3peEWi5tBP/J0C1belDvdQBg4MU4lGhYQ1UIYgmvGqwOr3i50g48V7Y0lu05Ah0oUTocd1NH6eyXNhE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5922

T24gMTgvMDQvMjAyMiAxNzo1MCwgSm9zaCBQb2ltYm9ldWYgd3JvdGU6DQo+IFRoZSBzdGFydHVw
X3hlbigpIGtlcm5lbCBlbnRyeSBwb2ludCBpcyByZWZlcmVuY2VkIGJ5IHRoZSAiLm5vdGUuWGVu
Ig0KPiBzZWN0aW9uLCBidXQgaXMgcHJlc3VtYWJseSBub3QgaW5kaXJlY3QtYnJhbmNoZWQgdG8u
DQoNCkl0J3MgdGhlIHJlYWwgZW50cnlwb2ludCBvZiB0aGUgVk0uwqAgSXQncyAiZ290IHRvIiBi
eSBzZXR0aW5nICVyaXANCmR1cmluZyB2Y3B1IHNldHVwLg0KDQpXZSBjb3VsZCBpbiBwcmluY2lw
bGUgc3VwcG9ydCBzdGFydGluZyBhIFBWIFZNIHdpdGggQ0VUIGFjdGl2ZSwgYnV0IHRoYXQNCnNv
dW5kcyBsaWtlIGFuIGVub3Jtb3VzIHF1YW50aXR5IG9mIGVmZm9ydCBmb3IgdmVyeSBsaXR0bGUg
Z2Fpbi7CoCBDRVQNCmZvciBYZW4gUFYgcmVxdWlyZXMgcGFyYXZpcnQgYW55d2F5IChiZWNhdXNl
IHRoZSBrZXJuZWwgcnVucyBpbiBDUEwhPTApDQpzbyBkZWNpc2lvbnMgbGlrZSB0aGlzIGNhbiB3
YWl0IHVudGlsIHNvbWVvbmUgZmVlbHMgbGlrZSBkb2luZyB0aGUgd29yay4NCg0KPiAgIEFkZCBB
Tk5PVEFURV9FTkRCUg0KPiB0byBzaWxlbmNlIGZ1dHVyZSBvYmp0b29sIHdhcm5pbmdzLg0KPg0K
PiBDYzogQm9yaXMgT3N0cm92c2t5IDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT4NCj4gQ2M6
IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGlu
aSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9q
ZWN0Lm9yZw0KPiBTaWduZWQtb2ZmLWJ5OiBKb3NoIFBvaW1ib2V1ZiA8anBvaW1ib2VAcmVkaGF0
LmNvbT4NCg0KRldJVywgUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz
QGNpdHJpeC5jb20+LCBwcmVmZXJhYmx5DQp3aXRoIHRoZSBjb21taXQgbWVzc2FnZSB0d2Vha2Vk
IHRvIHJlbW92ZSB0aGUgdW5jZXJ0YWludHkuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 11:58:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 11:58:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308054.523551 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmUX-0007GT-4r; Tue, 19 Apr 2022 11:57:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308054.523551; Tue, 19 Apr 2022 11:57:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmUX-0007GM-25; Tue, 19 Apr 2022 11:57:57 +0000
Received: by outflank-mailman (input) for mailman id 308054;
 Tue, 19 Apr 2022 11:57:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F37o=U5=infradead.org=peterz@srs-se1.protection.inumbo.net>)
 id 1ngmUV-0007GG-5F
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 11:57:55 +0000
Received: from desiato.infradead.org (desiato.infradead.org
 [2001:8b0:10b:1:d65d:64ff:fe57:4e05])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb446323-bfd7-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 13:57:45 +0200 (CEST)
Received: from j217100.upc-j.chello.nl ([24.132.217.100]
 helo=worktop.programming.kicks-ass.net)
 by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngmUF-006oN1-7J; Tue, 19 Apr 2022 11:57:39 +0000
Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000)
 id A3E4B986195; Tue, 19 Apr 2022 13:57:37 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb446323-bfd7-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:
	Sender:Reply-To:Content-ID:Content-Description;
	bh=DzuI/hP4j8qyKw02hy+UWxmxPErK21aY6wcTdlY7vX0=; b=dYA53jEasPAswBQt9fprgbs7Q6
	Pr1tFn/7z5/Q1Q901av7xURJmYYp5Es4BaV7Tcnowc/kX8mmc9S/NdwlGtjcY2YiDE4G3LKanvS7B
	wLmYO1TIUFsmwKEkKVmsT7awSo0MtIWQjX7HIWu6S+CQA08Ml2uaPmxr427ZgqeqEFrBfHJj+W2BT
	mLDfsoN5tsUe63kLOA1Lzd1OZZElV4ku6xScEaEkuO37s/wLg/9JM8/4yKcJRyqzClDJ9qvaqsYD3
	632Ihd6pLS0RdjcDGfgjOomBVlV/cEtKR31yUOp33Gy9tC6QvzejJUyooy4b/muCHrqjRaLywR+X1
	LhcoX+qw==;
Date: Tue, 19 Apr 2022 13:57:37 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Miroslav Benes <mbenes@suse.cz>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Message-ID: <20220419115737.GU2731@worktop.programming.kicks-ass.net>
References: <cover.1650300597.git.jpoimboe@redhat.com>
 <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
 <b94cbac6-0a4d-8e4a-ec58-bbd46e385d45@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b94cbac6-0a4d-8e4a-ec58-bbd46e385d45@citrix.com>

On Tue, Apr 19, 2022 at 11:42:12AM +0000, Andrew Cooper wrote:
> On 18/04/2022 17:50, Josh Poimboeuf wrote:
> > The startup_xen() kernel entry point is referenced by the ".note.Xen"
> > section, but is presumably not indirect-branched to.
> 
> It's the real entrypoint of the VM.� It's "got to" by setting %rip
> during vcpu setup.
> 
> We could in principle support starting a PV VM with CET active, but that
> sounds like an enormous quantity of effort for very little gain.� CET
> for Xen PV requires paravirt anyway (because the kernel runs in CPL!=0)
> so decisions like this can wait until someone feels like doing the work.
> 
> >   Add ANNOTATE_ENDBR
> > to silence future objtool warnings.
> >
> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Cc: Juergen Gross <jgross@suse.com>
> > Cc: Stefano Stabellini <sstabellini@kernel.org>
> > Cc: xen-devel@lists.xenproject.org
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> 
> FWIW, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, preferably
> with the commit message tweaked to remove the uncertainty.

Something like so then?

---
Subject: x86/xen: Add ANNOTATE_ENDBR to startup_xen()
From: Josh Poimboeuf <jpoimboe@redhat.com>
Date: Mon, 18 Apr 2022 09:50:25 -0700

From: Josh Poimboeuf <jpoimboe@redhat.com>

The startup_xen() kernel entry point is referenced by the ".note.Xen"
section, and is the real entry point of the VM. It *will* be
indirectly branched to, *however* currently Xen doesn't support PV VM
with CET active.

Add ANNOTATE_ENDBR to silence future objtool warnings.

Fixes: ed53a0d97192 ("x86/alternative: Use .ibt_endbr_seal to seal indirect calls")
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Link: https://lkml.kernel.org/r/a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:04:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:04:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308064.523563 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmar-0000UZ-5E; Tue, 19 Apr 2022 12:04:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308064.523563; Tue, 19 Apr 2022 12:04:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmar-0000US-0k; Tue, 19 Apr 2022 12:04:29 +0000
Received: by outflank-mailman (input) for mailman id 308064;
 Tue, 19 Apr 2022 12:04:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=n3km=U5=dingwall.me.uk=james@srs-se1.protection.inumbo.net>)
 id 1ngmap-0000UM-O8
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 12:04:27 +0000
Received: from smarthost01c.sbp.mail.zen.net.uk
 (smarthost01c.sbp.mail.zen.net.uk [212.23.1.5])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d9f18a4a-bfd8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 14:04:23 +0200 (CEST)
Received: from [217.155.64.189] (helo=mail0.xen.dingwall.me.uk)
 by smarthost01c.sbp.mail.zen.net.uk with esmtpsa
 (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1)
 (envelope-from <james@dingwall.me.uk>)
 id 1ngmai-0002GT-VS; Tue, 19 Apr 2022 12:04:21 +0000
Received: from localhost (localhost [IPv6:::1])
 by mail0.xen.dingwall.me.uk (Postfix) with ESMTP id 4E30A3736E9;
 Tue, 19 Apr 2022 13:04:20 +0100 (BST)
Received: from mail0.xen.dingwall.me.uk ([IPv6:::1])
 by localhost (mail0.xen.dingwall.me.uk [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id kOPXFhE8aXnS; Tue, 19 Apr 2022 13:04:20 +0100 (BST)
Received: from behemoth.dingwall.me.uk (behemoth.dingwall.me.uk [192.168.1.5])
 by dingwall.me.uk (Postfix) with ESMTP id 13E3E3736E4;
 Tue, 19 Apr 2022 13:04:20 +0100 (BST)
Received: by behemoth.dingwall.me.uk (Postfix, from userid 1000)
 id D91B2441D96; Tue, 19 Apr 2022 13:04:18 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9f18a4a-bfd8-11ec-a405-831a346695d4
X-Virus-Scanned: Debian amavisd-new at dingwall.me.uk
Date: Tue, 19 Apr 2022 13:04:18 +0100
From: James Dingwall <james-xen@dingwall.me.uk>
To: xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@citrix.com>, pdurrant@amazon.com
Subject: Re: [PATCH] fix invalid frontend path for set_mtu
Message-ID: <20220419120418.GA232637@dingwall.me.uk>
References: <20220301093513.GA3187840@dingwall.me.uk>
 <YlV4lXZHz52xPBzt@perard.uk.xensource.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="Qxx1br4bt0+wmkIi"
Content-Disposition: inline
In-Reply-To: <YlV4lXZHz52xPBzt@perard.uk.xensource.com>
X-Originating-smarthost01c-IP: [217.155.64.189]
Feedback-ID: 217.155.64.189


--Qxx1br4bt0+wmkIi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Anthony,

On Tue, Apr 12, 2022 at 02:03:17PM +0100, Anthony PERARD wrote:
> Hi James,
> 
> On Tue, Mar 01, 2022 at 09:35:13AM +0000, James Dingwall wrote:
> > The set_mtu() function of xen-network-common.sh currently has this code:
> > 
> >         if [ ${type_if} = vif ]
> >         then
> >             local dev_=${dev#vif}
> >             local domid=${dev_%.*}
> >             local devid=${dev_#*.}
> > 
> >             local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid"
> > 
> >             xenstore_write "$FRONTEND_PATH/mtu" ${mtu}
> >         fi
> > 
> > This works fine if the device has its default name but if the xen config
> > defines the vifname parameter the FRONTEND_PATH is incorrectly constructed.
> > Learn the frontend path by reading the appropriate value from the backend.
> 
> The patch looks fine, thanks. It is only missing a line
> "Signed-off-by: your_name <your_email>" at the end of the description.
> The meaning of this line is described in the file CONTRIBUTING, section
> "Developer's Certificate of Origin".
> 

Thank you for your feedback.  I've updated the patch as suggested.  I've also
incorporated two other changes, one is a simple style change for consistency,
the other is to change a the test for a valid mtu from > 0 to >= 68.  I can
resubmit the original patch if either of these are a problem.

Thanks,
James

--Qxx1br4bt0+wmkIi
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="xen-network-common-frontend.patch"

commit 03ad5670f8a7402e30b288a55d088e87685cd1a1
Author: James Dingwall <james@dingwall.me.uk>
Date:   Tue Apr 19 12:45:31 2022 +0100

    The set_mtu() function of xen-network-common.sh currently has this code:
    
            if [ ${type_if} = vif ]
            then
                local dev_=${dev#vif}
                local domid=${dev_%.*}
                local devid=${dev_#*.}
    
                local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid"
    
                xenstore_write "$FRONTEND_PATH/mtu" ${mtu}
            fi
    
    This works fine if the device has its default name but if the xen config
    defines the vifname parameter the FRONTEND_PATH is incorrectly constructed.
    Learn the frontend path by reading the appropriate value from the backend.
    
    Also change use of `...` to $(...) for a consistent style in the script
    and adjust the valid check from `mtu > 0` to `mtu >= 68` per RFC 791.
    
    Signed-off-by: James Dingwall <james@dingwall.me.uk>

diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh
index 42fa704e8d..9a382c39f4 100644
--- a/tools/hotplug/Linux/xen-network-common.sh
+++ b/tools/hotplug/Linux/xen-network-common.sh
@@ -171,24 +171,20 @@ set_mtu () {
     local mtu=$(xenstore_read_default "$XENBUS_PATH/mtu" "")
     if [ -z "$mtu" ]
     then
-        mtu="`ip link show dev ${bridge}| awk '/mtu/ { print $5 }'`"
+        mtu="$(ip link show dev ${bridge}| awk '/mtu/ { print $5 }')"
         if [ -n "$mtu" ]
         then
             log debug "$bridge MTU is $mtu"
         fi
     fi
-    if [ -n "$mtu" ] && [ "$mtu" -gt 0 ]
+    if [ -n "$mtu" ] && [ "$mtu" -ge 68 ]
     then
         log debug "setting $dev MTU to $mtu"
         ip link set dev ${dev} mtu ${mtu} || :
 
         if [ ${type_if} = vif ]
         then
-            local dev_=${dev#vif}
-            local domid=${dev_%.*}
-            local devid=${dev_#*.}
-
-            local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid"
+            local FRONTEND_PATH="$(xenstore_read "$XENBUS_PATH/frontend")"
 
             xenstore_write "$FRONTEND_PATH/mtu" ${mtu}
         fi

--Qxx1br4bt0+wmkIi--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:05:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:05:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308062.523573 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmbT-000111-DC; Tue, 19 Apr 2022 12:05:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308062.523573; Tue, 19 Apr 2022 12:05:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmbT-00010u-9u; Tue, 19 Apr 2022 12:05:07 +0000
Received: by outflank-mailman (input) for mailman id 308062;
 Tue, 19 Apr 2022 12:03:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F7iW=U5=oracle.com=anand.jain@srs-se1.protection.inumbo.net>)
 id 1ngmZm-0000T8-Nb
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 12:03:23 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b43537d2-bfd8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 14:03:20 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23JBsRJ4019231; 
 Tue, 19 Apr 2022 12:02:44 GMT
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ffmk2nsrf-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Apr 2022 12:02:44 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23JC1i8b035322; Tue, 19 Apr 2022 12:02:43 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3ffm81y1rq-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Apr 2022 12:02:43 +0000
Received: from PH0PR10MB5706.namprd10.prod.outlook.com (2603:10b6:510:148::10)
 by MWHPR1001MB2141.namprd10.prod.outlook.com (2603:10b6:301:35::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Tue, 19 Apr
 2022 12:02:41 +0000
Received: from PH0PR10MB5706.namprd10.prod.outlook.com
 ([fe80::d414:7654:e1b8:4306]) by PH0PR10MB5706.namprd10.prod.outlook.com
 ([fe80::d414:7654:e1b8:4306%9]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 12:02:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b43537d2-bfd8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=QL9zAEXce69OmwiuUcwiOZYD9isqw84nxmQFM4fYLsk=;
 b=tYv38/gUZGvY8Q0ZcvGgatPdfoez9sVIV8bC4fBr8Pqf8t4feErmToGS0FLdSqUeRoFZ
 dBiAhV1/gugjQ8Q+GsESK60oyrqa6LpMRyFVZ9foHOnTx+t8V3gl8NfK3XoEdhPv17LF
 NweEH2a3vChBkZiccHaTLeqUvTpY03+bKMQGYaQ12ckgSWPl5pUK5KsWLgwqHSGUiDj2
 0kgG+neCjqWWbVTD18nHFSjJYAxyTXzkUPJntA58YhdwZcEb9ZlZVhpLHXxhY4djjEP6
 NfAyU8bpRJG2F7ix/eGzB+R25mqyYKtPHmV/fkjAj1cJnn9659Z2MswMUQT0Iqj3A/sc qw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LQLrh726Iz0npUEBkcLLPHrC0r90OcTtzhkiSTw0ZRoC3P+ZvAQc+056vgrKNhHI00L6HNcAkC3e/sDNmGPvmcJGfYaHfapLG38021TnnYvsR+iDFkkyj6JndvFPGi7hdD6cUenYhbXsJdYl4AvW8yDYLToKNo/o3xVZ7tRCLWcyZzlYF4HWErjqE/JNXJlBmapL2BCAKd2O9g55Y3W/vHOF5T2UyE9LjbdTg2wsdq7g7x5YCfsRhxjucHiJ1ItLiMsQomT7Q4nYOBpiVV5hs/WGh0dk0RajlrP6w6CL/2KrSxTqS8sMB6VyyXZDTyDKiqwrSo9i9HzWs8NGjhiOVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QL9zAEXce69OmwiuUcwiOZYD9isqw84nxmQFM4fYLsk=;
 b=V4yvdLxS4bHsn+VnzBvk17dhwQFMpw8uq9sDZdhQxTzS3weq7/TpTgRtp17CwGyHDPQDj6+7sBfJ2MrTF/BQRWUvNTg/pgtISX8qYwOphQCOUbTtE+BSWzX14NSuO9DiyQB7GujpXQOsEVOmLPGhwRczsGcDTB8rm7fSwvRXuARlf9hHXMsD0oe6b4TLxpm0M8pgyBVoRtLiRT1Y9jLMkraLXCoN3U0S83gegEcmeaqJyMxeUyXwKvZ83oV8yXKUZ9beTtyjP4zwXkKI+7dL2Dz32oHsCP0yyfIrOHI6a5qReoqDH68X29PRP5mEKDFaHKtI/tXfymUDCaxj2TVw4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QL9zAEXce69OmwiuUcwiOZYD9isqw84nxmQFM4fYLsk=;
 b=zxdzb2HTii8g58+L1L83JBE90J7uRfh1GJLoCuEJKgIdo1IdIl/XZ3aGP6rfcaeLftjVwst+5/ykLP4HQV1/EVBpngk/xCYcaMQoN/M+j/NYcPOVH32bkxdneSP2GzaxmQ02HpVRMbyiVw0uKPwpoIGMwDBIo2fixchDtRE2V1Y=
Message-ID: <530b0d48-96fc-e157-38f5-a87d85c7d2c6@oracle.com>
Date: Tue, 19 Apr 2022 20:02:18 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open
 coding it
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
        linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
        nbd@other.debian.org, ceph-devel@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
        linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
        linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
        linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
        linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
        ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
        Johannes Thumshirn <johannes.thumshirn@wdc.com>,
        David Sterba <dsterba@suse.com>
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-9-hch@lst.de>
From: Anand Jain <anand.jain@oracle.com>
In-Reply-To: <20220415045258.199825-9-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SG2PR06CA0201.apcprd06.prod.outlook.com (2603:1096:4:1::33)
 To PH0PR10MB5706.namprd10.prod.outlook.com (2603:10b6:510:148::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a98a6d3b-c5d2-4693-77c8-08da21fc8146
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2141:EE_
X-Microsoft-Antispam-PRVS: 
	<MWHPR1001MB2141CE67EFCF4B26A2BEF1BCE5F29@MWHPR1001MB2141.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	hVWl70YvV4YC4v0m6s7HzgZEWKv3Fonhd5nUgli1TOROMgki53u9O+TeX60rWcxhlM7ItoOO6iOYJVLq65CJp5+Fvr7qBn32D69JTN/BGMHpEba4e2A9fivk2EryxnvfwMvkdhiM6mhQnl+AQFPWGt0JtKikaHWa8VbwyFPcN2ynMxOztmw7S9M7XgaF3cUCBqlNNAdjFeZvcZvjbFxhv+FweFoQWYotzQt05e9sYMP9kKzHoZpXQK20WmTQUqgvKvQ/9bx7JHKm+PjaGyfUP+MFsq3pmIB0Vny3qGaVQ6lelm+7SKjlx1+AHfPBfKz6p09RLjiMjzPLOwwk1ha9LDg+wZ7sziwpPmaR9FewzXLrkOgoz/nZ3+qPz94Br7UMOCxXfNf/VTrPE5KvzvJ4/BPghnb8y/vntjlI6FZ3+8h7VPRdwzO84LJYlwOdXSev65/hKiSVRX4t9+OSUlmn9vjXzlkyGpVRyxxvT2AJvc/i+zHoqXkk+OH+tQ5GDR7f9W8cHpTaJ+HwkA8NrnI10raLMQm7z4J6MoqQKO0oJUtODNlAJjgFCZzWaW8pZ5F4J5o7GJtKoFTQSaITzQZ7zef66yeg3Ot2cZr9l1VR9sIUW9++KPe+y6DFGMyGhIVD6Tc9mL7IJNvy8rWwB6QTGk/hS71Uosbcph/eMMgsmcGq/8JJC1uWMH2ZtRDWtiY1TOg22mZZkG3PyFdaxjstMAXutzYUSn0z00AD4GwOzug=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5706.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(110136005)(4326008)(36756003)(38100700002)(31686004)(7406005)(26005)(508600001)(66476007)(316002)(66946007)(186003)(6486002)(5660300002)(2616005)(54906003)(8676002)(31696002)(86362001)(7416002)(83380400001)(44832011)(2906002)(8936002)(6506007)(6512007)(6666004)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MmhoV3N4Y1dhanlWMG9nc0ZSMUpvTEF3T281cXZhL21mY081RXBtQXpONWpx?=
 =?utf-8?B?NGZhS3ZqRWtnVFVLejM0VlRTQWxTRmJyY0lDQi9VcE14QzBkTHY4dXdHakww?=
 =?utf-8?B?S2JZS2VVOUxzR1B1ZTFvQWxVYzVYNVl3ZE5iNVpyYVMySnQvSnA1aVFnMDBX?=
 =?utf-8?B?bVBTSjBkcS84Zlc4RmFKRUdJcW1xc2pFcGY3dE53VEJnTkpJQXdkNW50N1B5?=
 =?utf-8?B?bTB5ZUJ2M3dYZm5XTXYwMndKVkhjWGw4R1IzQWNmZk9iTHJWOWFrVGoreGVY?=
 =?utf-8?B?WUNLOHh3NW85VlpaaHdzbFdyd3U4azkzU080bFd6Ni8wM0preGRmNzIySjJD?=
 =?utf-8?B?LzBrUXZOTnNZdVR3ak1zcGVnYzMvQ1BWK3VZWkFyT0dsTmYrQUVMd3pTb2E5?=
 =?utf-8?B?S3lKRk9VRTJIY1ZBN0Z6WFM5NFYvSEJ2R2pTcTBaQ0ZPVkg5dVQwanlCZEJF?=
 =?utf-8?B?UW5wU0NIK2t0bXRRNUhyUmpUMUlmMUVmb0gvNXIxVjNUZi9NZnNBZ1pheEJL?=
 =?utf-8?B?a2wxU2VPYXFyeHN3MUdsRjRvY1VDK2FhNVdqLzE0cmt2NFNHQ1V2aE4xMjVD?=
 =?utf-8?B?Qmw1YUZrWnloWWx1TmlzKzZ4SUdRSXV3dnA5amxaRFU1NVoySEJaQXB3Y2dC?=
 =?utf-8?B?cVJJUWJRRWhQYzBscHIyRXpCUCs0WnA3YTJLczNqSU5DME5qbThnZVRRamlx?=
 =?utf-8?B?U1N6QUROUmt4UCtCNUx1TEplSHlLaVRyNmN0cnlGUjlLdkgrU3Qwc3UxMWZv?=
 =?utf-8?B?TWxPdEFxdXROMFAxajBhTjZGVkhjYXVyTm5qVjZBajRaYXB3bFNYSzdxR3J5?=
 =?utf-8?B?aTJJcU1QQUp4YUMyb0JKa1hrcEZyTGhVdmlHZEhncC9UR3c2SlowRGJSTEZY?=
 =?utf-8?B?ZDZLREVrMjViU1c5VExpYkdPQVhBNkR4RkV0WkQ2M2hyZXB6Kzk2dTdaT1NJ?=
 =?utf-8?B?VlBIQUw2WjF5WmhNbjc3OHNHVG9qaGZhS25RUXpodGIwcmNlQ1FrR0FSWjJB?=
 =?utf-8?B?ZjFLSFNKTGpzYjVITlZLdEQ5WjI5VXpzVFhKay8rRlduZlVaQllCNDJZamlN?=
 =?utf-8?B?eEVGOUYwMWhjaGV2TjBZbTAvTVFRdTNnUTd3Qksva2RRRzRQTkh3K2RLdGJC?=
 =?utf-8?B?QjFiRWJCb0p0SmhORWdJRWxYYld3b09jRTFlOExJK0VZQ2E3VlJvQWIreW5a?=
 =?utf-8?B?NXR2V1hYcTMwMHBBODdZOFE4MXFMQmVEamNYOEwwaVAzQ292UGpyYWlOSmQ4?=
 =?utf-8?B?SFpJN2ZFeEZ1ZGVJT3U3dVUzdEdFS3dlU3plSTdleGF5QzVxck02cHlxWm8w?=
 =?utf-8?B?NG1ZYWpxUXVxL3hOUll1TnpWUGQ2ZlFHRmlRS0oxWTgxdlNUMzM5WGJSTHZq?=
 =?utf-8?B?dWh3bTR4T29lbExVZVpEcWRabWlhRHlXMVpIV1JUVVRZWVdzRWEwSWEvQ3V4?=
 =?utf-8?B?RERHNWN3UWloMG9CaGlCZEg3TDg4ZU8wR3FOQ1JlazJLQWpQL0NkYnpNSS9Z?=
 =?utf-8?B?Y0FZUEw0dGZ1MXJpTGE1VHFuRXBjaG1qSldTTG9ybDVMUi9ycVp2MU5XbUs1?=
 =?utf-8?B?c3lhRTRXSzBvU2k2SDVDZEFmbUxJRVUyUEZaTFc5MCtwenB5c3ZDanJET3hl?=
 =?utf-8?B?ZVVrVUFHUjRRd0RGZlRqMjRVMktDWGlVZ0VneHA3T3NoUUI0YkU3QlRnUDhi?=
 =?utf-8?B?UlJIdjh1Slg1Z0RobkVtQ3RXeHJ2SGVNTGkvSFdtdjJ0aDVYMFlHeXVZdmdX?=
 =?utf-8?B?QlJaem4zUlpQQnA0SnZIakIrZGo5YkxpN3dvUGRCakJVNVpiYjZPNThrS25m?=
 =?utf-8?B?VGRWR0ptWERrdzl3UlE5eTA1WTR1QlNzdnY5dmpEcm0vZHR4UlByMlg3bnhw?=
 =?utf-8?B?WlpRMEhQVzF3cUtpZkd6SXJuVC9iemhPT3FJOER5OCszUzFCM1U2MVBsdlRW?=
 =?utf-8?B?TkpYNEdoemZVMHdIb1ZsaVl6YnptNUxEVU5ZR2dSZ21tYTMvTzM2YWxvKzAx?=
 =?utf-8?B?ZnRidnhla2ZTZ1BCcEhyT0pnb2o0VTUzck5hZ3U4ZnBmQVVqOHV5Z0ozREVM?=
 =?utf-8?B?bGVkNEwvQWY3NG94azVNdWtjQmkyQUNNMlZCVWtqb3hnL1BzejdzaEE0bHow?=
 =?utf-8?B?TG5HRnJ0Rys1c3VYenpDVFNROEVNd3Q1c0dCSk1rNzQrR2pSc1kzWXgwWE50?=
 =?utf-8?B?SjhROThCV1VQdTVlNUxGd3htaG91Q3JReThaVWYvV0RYZUVxZXRCMFNFcUxs?=
 =?utf-8?B?MVBVUnpxUjMxZUxETnJrblNOdTBIYU5lNTVQN2NqbmRoNWhFK2d5TDdUaWhI?=
 =?utf-8?B?dm5MUjNQUnc1QlJvdVQxM2kwdEY1RWoyd2VuVGM1SmRjcjFIVXFPQT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a98a6d3b-c5d2-4693-77c8-08da21fc8146
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5706.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 12:02:41.3368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KRd3SV4vTdL/imdzW81rXDlLgVZQ5jI4QZcN7QsQKr+Cc4vkDsCT7Q0McNeiM4a/YB2BICphkrENA/rtDs3e8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2141
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-19_05:2022-04-15,2022-04-19 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204190068
X-Proofpoint-GUID: eIAsdRiq0QDKLhGFS0Ei-awijsDU5A4I
X-Proofpoint-ORIG-GUID: eIAsdRiq0QDKLhGFS0Ei-awijsDU5A4I

On 4/15/22 12:52, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Acked-by: David Sterba <dsterba@suse.com>

LGTM.

Reviewed-by: Anand Jain <anand.jain@oracle.com>


> ---
>   fs/btrfs/zoned.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
> index 1b1b310c3c510..f72cad7391a11 100644
> --- a/fs/btrfs/zoned.c
> +++ b/fs/btrfs/zoned.c
> @@ -350,7 +350,6 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
>   	struct btrfs_fs_info *fs_info = device->fs_info;
>   	struct btrfs_zoned_device_info *zone_info = NULL;
>   	struct block_device *bdev = device->bdev;
> -	struct request_queue *queue = bdev_get_queue(bdev);
>   	unsigned int max_active_zones;
>   	unsigned int nactive;
>   	sector_t nr_sectors;
> @@ -410,7 +409,7 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
>   	if (!IS_ALIGNED(nr_sectors, zone_sectors))
>   		zone_info->nr_zones++;
>   
> -	max_active_zones = queue_max_active_zones(queue);
> +	max_active_zones = bdev_max_active_zones(bdev);
>   	if (max_active_zones && max_active_zones < BTRFS_MIN_ACTIVE_ZONES) {
>   		btrfs_err_in_rcu(fs_info,
>   "zoned: %s: max active zones %u is too small, need at least %u active zones",



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:06:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:06:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308072.523584 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmcg-0001fJ-Nh; Tue, 19 Apr 2022 12:06:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308072.523584; Tue, 19 Apr 2022 12:06:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmcg-0001fC-Kq; Tue, 19 Apr 2022 12:06:22 +0000
Received: by outflank-mailman (input) for mailman id 308072;
 Tue, 19 Apr 2022 12:06:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngmce-0001er-VB
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 12:06:20 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 192e3b26-bfd9-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 14:06:09 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6434D210F1;
 Tue, 19 Apr 2022 12:06:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1EB38132E7;
 Tue, 19 Apr 2022 12:06:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id dE/7BbulXmKyXwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 12:06:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 192e3b26-bfd9-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650369979; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=17cvwrP1W/YrOePsFyFZ04xlKrMaEQxDlJS+zIqc9pc=;
	b=dvkfmdPPA2uAscpybZVMbycuKZHRII/zIQnfMZqacuqyBg1HOEDMTRApvl8F9jNVen09YF
	fruRdZL9HI75u8x+sBPWt1aYHQxEKDOod2/9D4C/WfnrVyVlXbVUQWGUEfBqE2DW6asJvI
	rFmnWmWiohFBi6W3zDYnSpBJi8HxtRk=
Message-ID: <e1e11062-f528-ea06-cb94-fd4dadf2c5aa@suse.com>
Date: Tue, 19 Apr 2022 14:06:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Content-Language: en-US
To: Peter Zijlstra <peterz@infradead.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Miroslav Benes <mbenes@suse.cz>, Boris Ostrovsky
 <boris.ostrovsky@oracle.com>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1650300597.git.jpoimboe@redhat.com>
 <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
 <b94cbac6-0a4d-8e4a-ec58-bbd46e385d45@citrix.com>
 <20220419115737.GU2731@worktop.programming.kicks-ass.net>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220419115737.GU2731@worktop.programming.kicks-ass.net>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------2IeIEE5xYPveCwBVs3J5n4B3"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------2IeIEE5xYPveCwBVs3J5n4B3
Content-Type: multipart/mixed; boundary="------------GryZTSvTkZhEETy5NZDwJoeo";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Peter Zijlstra <peterz@infradead.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Miroslav Benes <mbenes@suse.cz>, Boris Ostrovsky
 <boris.ostrovsky@oracle.com>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <e1e11062-f528-ea06-cb94-fd4dadf2c5aa@suse.com>
Subject: Re: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
References: <cover.1650300597.git.jpoimboe@redhat.com>
 <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
 <b94cbac6-0a4d-8e4a-ec58-bbd46e385d45@citrix.com>
 <20220419115737.GU2731@worktop.programming.kicks-ass.net>
In-Reply-To: <20220419115737.GU2731@worktop.programming.kicks-ass.net>

--------------GryZTSvTkZhEETy5NZDwJoeo
Content-Type: multipart/mixed; boundary="------------jz6euTCJTtrrKm2dUKP9mACi"

--------------jz6euTCJTtrrKm2dUKP9mACi
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMDQuMjIgMTM6NTcsIFBldGVyIFppamxzdHJhIHdyb3RlOg0KPiBPbiBUdWUsIEFw
ciAxOSwgMjAyMiBhdCAxMTo0MjoxMkFNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0K
Pj4gT24gMTgvMDQvMjAyMiAxNzo1MCwgSm9zaCBQb2ltYm9ldWYgd3JvdGU6DQo+Pj4gVGhl
IHN0YXJ0dXBfeGVuKCkga2VybmVsIGVudHJ5IHBvaW50IGlzIHJlZmVyZW5jZWQgYnkgdGhl
ICIubm90ZS5YZW4iDQo+Pj4gc2VjdGlvbiwgYnV0IGlzIHByZXN1bWFibHkgbm90IGluZGly
ZWN0LWJyYW5jaGVkIHRvLg0KPj4NCj4+IEl0J3MgdGhlIHJlYWwgZW50cnlwb2ludCBvZiB0
aGUgVk0uwqAgSXQncyAiZ290IHRvIiBieSBzZXR0aW5nICVyaXANCj4+IGR1cmluZyB2Y3B1
IHNldHVwLg0KPj4NCj4+IFdlIGNvdWxkIGluIHByaW5jaXBsZSBzdXBwb3J0IHN0YXJ0aW5n
IGEgUFYgVk0gd2l0aCBDRVQgYWN0aXZlLCBidXQgdGhhdA0KPj4gc291bmRzIGxpa2UgYW4g
ZW5vcm1vdXMgcXVhbnRpdHkgb2YgZWZmb3J0IGZvciB2ZXJ5IGxpdHRsZSBnYWluLsKgIENF
VA0KPj4gZm9yIFhlbiBQViByZXF1aXJlcyBwYXJhdmlydCBhbnl3YXkgKGJlY2F1c2UgdGhl
IGtlcm5lbCBydW5zIGluIENQTCE9MCkNCj4+IHNvIGRlY2lzaW9ucyBsaWtlIHRoaXMgY2Fu
IHdhaXQgdW50aWwgc29tZW9uZSBmZWVscyBsaWtlIGRvaW5nIHRoZSB3b3JrLg0KPj4NCj4+
PiAgICBBZGQgQU5OT1RBVEVfRU5EQlINCj4+PiB0byBzaWxlbmNlIGZ1dHVyZSBvYmp0b29s
IHdhcm5pbmdzLg0KPj4+DQo+Pj4gQ2M6IEJvcmlzIE9zdHJvdnNreSA8Ym9yaXMub3N0cm92
c2t5QG9yYWNsZS5jb20+DQo+Pj4gQ2M6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNv
bT4NCj4+PiBDYzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3Jn
Pg0KPj4+IENjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4+PiBTaWduZWQt
b2ZmLWJ5OiBKb3NoIFBvaW1ib2V1ZiA8anBvaW1ib2VAcmVkaGF0LmNvbT4NCj4+DQo+PiBG
V0lXLCBSZXZpZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4
LmNvbT4sIHByZWZlcmFibHkNCj4+IHdpdGggdGhlIGNvbW1pdCBtZXNzYWdlIHR3ZWFrZWQg
dG8gcmVtb3ZlIHRoZSB1bmNlcnRhaW50eS4NCj4gDQo+IFNvbWV0aGluZyBsaWtlIHNvIHRo
ZW4/DQo+IA0KPiAtLS0NCj4gU3ViamVjdDogeDg2L3hlbjogQWRkIEFOTk9UQVRFX0VOREJS
IHRvIHN0YXJ0dXBfeGVuKCkNCj4gRnJvbTogSm9zaCBQb2ltYm9ldWYgPGpwb2ltYm9lQHJl
ZGhhdC5jb20+DQo+IERhdGU6IE1vbiwgMTggQXByIDIwMjIgMDk6NTA6MjUgLTA3MDANCj4g
DQo+IEZyb206IEpvc2ggUG9pbWJvZXVmIDxqcG9pbWJvZUByZWRoYXQuY29tPg0KPiANCj4g
VGhlIHN0YXJ0dXBfeGVuKCkga2VybmVsIGVudHJ5IHBvaW50IGlzIHJlZmVyZW5jZWQgYnkg
dGhlICIubm90ZS5YZW4iDQo+IHNlY3Rpb24sIGFuZCBpcyB0aGUgcmVhbCBlbnRyeSBwb2lu
dCBvZiB0aGUgVk0uIEl0ICp3aWxsKiBiZQ0KPiBpbmRpcmVjdGx5IGJyYW5jaGVkIHRvLCAq
aG93ZXZlciogY3VycmVudGx5IFhlbiBkb2Vzbid0IHN1cHBvcnQgUFYgVk0NCj4gd2l0aCBD
RVQgYWN0aXZlLg0KDQpIbW0sIFhlbiB3aWxsIGFsd2F5cyB1c2UgSVJFVCB0byBhY3RpdmF0
ZSB0aGUgZ3Vlc3QuDQoNCg0KSnVlcmdlbg0K
--------------jz6euTCJTtrrKm2dUKP9mACi
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------jz6euTCJTtrrKm2dUKP9mACi--

--------------GryZTSvTkZhEETy5NZDwJoeo--

--------------2IeIEE5xYPveCwBVs3J5n4B3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJepboFAwAAAAAACgkQsN6d1ii/Ey8T
oQf9EKmmEZaYjIYHk88yOKwhNPMeFNvXCN0ouhp+PLvjb3g1bSYo1nQyyWFaOEMiMhJAiAlzW7/y
sr8DkBa+LqzwCQjWux6RxMP5Cmi4BSehiPr1Gf/6mGGPt1zX6sC5DrWQbzPUgYvfiMU5YsU6thx1
YSdPGp81IV/S4vmLStF2xb+k5TN8hK4ndNAJrOzlglL+OoN8ni9I1403SUngp0EqM212ljzpWKAF
oXTSO8HvDxpdce5yKh5tmXlmuq1ncij1DasrN8ZXtCc2SjfkzelXPMru/JyVy/H7osydMmL9ZZ7x
moRE+glctru1pRnCRKR9g6UpuAW2dAFwAWri1XLOEw==
=aF2B
-----END PGP SIGNATURE-----

--------------2IeIEE5xYPveCwBVs3J5n4B3--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:12:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:12:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308079.523596 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmii-0003Ir-IE; Tue, 19 Apr 2022 12:12:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308079.523596; Tue, 19 Apr 2022 12:12:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmii-0003Ik-Ew; Tue, 19 Apr 2022 12:12:36 +0000
Received: by outflank-mailman (input) for mailman id 308079;
 Tue, 19 Apr 2022 12:12:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=dp8H=U5=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1ngmih-0003Ie-II
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 12:12:35 +0000
Received: from ppsw-41.csi.cam.ac.uk (ppsw-41.csi.cam.ac.uk [131.111.8.141])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7fde820-bfd9-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 14:12:23 +0200 (CEST)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:56344)
 by ppsw-41.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1ngmiN-000usy-QF (Exim 4.95) (return-path <amc96@srcf.net>);
 Tue, 19 Apr 2022 13:12:15 +0100
Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 7565F1FAD5;
 Tue, 19 Apr 2022 13:12:14 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7fde820-bfd9-11ec-8fbe-03012f2f19d4
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <8fbbd4ca-54b1-8c1c-19bc-3d0e6044ff5d@srcf.net>
Date: Tue, 19 Apr 2022 13:12:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Content-Language: en-GB
To: Peter Zijlstra <peterz@infradead.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Miroslav Benes <mbenes@suse.cz>, Boris Ostrovsky
 <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1650300597.git.jpoimboe@redhat.com>
 <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
 <b94cbac6-0a4d-8e4a-ec58-bbd46e385d45@citrix.com>
 <20220419115737.GU2731@worktop.programming.kicks-ass.net>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20220419115737.GU2731@worktop.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 19/04/2022 12:57, Peter Zijlstra wrote:
> On Tue, Apr 19, 2022 at 11:42:12AM +0000, Andrew Cooper wrote:
>> On 18/04/2022 17:50, Josh Poimboeuf wrote:
>>> The startup_xen() kernel entry point is referenced by the ".note.Xen"
>>> section, but is presumably not indirect-branched to.
>> It's the real entrypoint of the VM.  It's "got to" by setting %rip
>> during vcpu setup.
>>
>> We could in principle support starting a PV VM with CET active, but that
>> sounds like an enormous quantity of effort for very little gain.  CET
>> for Xen PV requires paravirt anyway (because the kernel runs in CPL!=0)
>> so decisions like this can wait until someone feels like doing the work.
>>
>>>   Add ANNOTATE_ENDBR
>>> to silence future objtool warnings.
>>>
>>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>> Cc: Juergen Gross <jgross@suse.com>
>>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>>> Cc: xen-devel@lists.xenproject.org
>>> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
>> FWIW, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, preferably
>> with the commit message tweaked to remove the uncertainty.
> Something like so then?
>
> ---
> Subject: x86/xen: Add ANNOTATE_ENDBR to startup_xen()
> From: Josh Poimboeuf <jpoimboe@redhat.com>
> Date: Mon, 18 Apr 2022 09:50:25 -0700
>
> From: Josh Poimboeuf <jpoimboe@redhat.com>
>
> The startup_xen() kernel entry point is referenced by the ".note.Xen"
> section, and is the real entry point of the VM. It *will* be
> indirectly branched to, *however* currently Xen doesn't support PV VM
> with CET active.

Technically it's always IRET'd to, but the point is that it's never
"branched to" by the execution context of the VM.

So it would be better to say that it's never indirectly branched to. 
That's what the IBT checks care about.

>
> Add ANNOTATE_ENDBR to silence future objtool warnings.

Only just spotted.  All text in the subject and commit message needs
s/ENDBR/NOENDBR/

~Andrew


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:17:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:17:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308084.523607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmnS-0003wC-5E; Tue, 19 Apr 2022 12:17:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308084.523607; Tue, 19 Apr 2022 12:17:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmnS-0003w5-21; Tue, 19 Apr 2022 12:17:30 +0000
Received: by outflank-mailman (input) for mailman id 308084;
 Tue, 19 Apr 2022 12:17:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tr1R=U5=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ngmnQ-0003vz-Et
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 12:17:28 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ad388f2c-bfda-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 14:17:27 +0200 (CEST)
Received: by mail-lf1-x130.google.com with SMTP id bq30so29059182lfb.3
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 05:17:27 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 e15-20020a19500f000000b0046bb76678bcsm1497380lfb.131.2022.04.19.05.17.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 05:17:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad388f2c-bfda-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=c4jLu+nEjW6ZyZXVzGI5SDD7yHtnUvhBe/fmRqUVNIQ=;
        b=XHTyOUDABQ14gZmVv1k6ZT33I2aAbve42wB0HyHQxv7GIG6L7ZAKcuW2rGSxXu/ygr
         JnWzRmFHo9x1ZE21q1MdOXNxgM0G6U0dzM3232itmYKA3MVrjrU/MLuccHMgIGDrN3hH
         D3+yMStuFAvLXza9j2W/bcrz9OIx2WmpcXkiVEVsqxbasDR23Ydv/wFqPV9IL4cz2XuP
         +09gFQTuxn7+b56CTrbPi8/Pq6zYk0zHk6sQvCLKjT9J2p/G9SV4KjVtjs3cOMisAS2O
         mivwFNQc84cRhVQafMN71BdlBSk1jKUOclNnS4aoAd2n+l9UOg0Iyj5GA7Yfjtxo1el9
         KIRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=c4jLu+nEjW6ZyZXVzGI5SDD7yHtnUvhBe/fmRqUVNIQ=;
        b=D5WbHCOyQdRF3ojaqKoXOupBHxuMbrptEgFN5+b/EBbRZL/qx+ZB/qiBZJ6U/zpO4f
         4T9h6S5S8MBGEDvCGFugtzQytxoIgCbYxh8gsQ9WoUO+SbwMwmdWN1PevR/E0cSaHTZS
         2g8F/Mzer52WYRJUqE/mwRj9Fd/hICRbMoO8vg32uh4MEzSsC84Bso2V6y+ITuP5b/w7
         k9ct3b2fgIjJyorYr3BkWfwH8OptCX1HRvm3RiYU/RETYlftPeYbZaOgm+ZK3h3DvugE
         lea8DYRdxs/ptM199e+kDFd/IzCyfgQRFd+tE+tQs8rilYGbaK/kqw7Aqu2EL9pzWN4x
         BBWw==
X-Gm-Message-State: AOAM533IyUhWrF5uM6Q4zFOdz8CiJJlCIEMhw+f75DSiEHVCIcQzwCMB
	7dmfIhNGXgmswQohXx1SSIU=
X-Google-Smtp-Source: ABdhPJwkKAkPv72l8VLD2wXgvdqXMSxh5RJKyI64dvC+KXpqtAP43wJmw6LIPT1nv21iuUsXGSy77w==
X-Received: by 2002:a05:6512:c28:b0:471:9a7d:de9e with SMTP id z40-20020a0565120c2800b004719a7dde9emr5320943lfu.440.1650370646660;
        Tue, 19 Apr 2022 05:17:26 -0700 (PDT)
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
To: Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
 <YlpdBHKT1bYzZe2e@infradead.org>
 <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
 <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com>
Date: Tue, 19 Apr 2022 15:17:25 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


Hello Stefano, Juergen


On 18.04.22 22:11, Stefano Stabellini wrote:
> On Mon, 18 Apr 2022, Oleksandr wrote:
>> On 16.04.22 09:07, Christoph Hellwig wrote:
>>
>> Hello Christoph
>>
>>> On Fri, Apr 15, 2022 at 03:02:45PM -0700, Stefano Stabellini wrote:
>>>> This makes sense overall. Considering that the swiotlb-xen case and the
>>>> virtio case are mutually exclusive, I would write it like this:
>>> Curious question:  Why can't the same grant scheme also be used for
>>> non-virtio devices?  I really hate having virtio hooks in the arch
>>> dma code.  Why can't Xen just say in DT/ACPI that grants can be used
>>> for a given device?
> [...]
>
>> This patch series tries to make things work with "virtio" devices in Xen
>> system without introducing any modifications to code under drivers/virtio.
>
> Actually, I think Christoph has a point.
>
> There is nothing inherently virtio specific in this patch series or in
> the "xen,dev-domid" device tree binding.


Although the main intention of this series was to enable using virtio 
devices in Xen guests, I agree that nothing in new DMA ops layer 
(xen-virtio.c) is virtio specific (at least at the moment). Regarding 
the whole patch series I am not quite sure, as it uses 
arch_has_restricted_virtio_memory_access().


>   Assuming a given device is
> emulated by a Xen backend, it could be used with grants as well.
>
> For instance, we could provide an emulated e1000 NIC with a
> "xen,dev-domid" property in device tree. Linux could use grants with it
> and the backend could map the grants. It would work the same way as
> virtio-net/block/etc. Passthrough devices wouldn't have the
> "xen,dev-domid" property, so no problems.
>
> So I think we could easily generalize this work and expand it to any
> device. We just need to hook on the "xen,dev-domid" device tree
> property.
>
> I think it is just a matter of:
> - remove the "virtio,mmio" check from xen_is_virtio_device
> - rename xen_is_virtio_device to something more generic, like
>    xen_is_grants_device
> - rename xen_virtio_setup_dma_ops to something more generic, like
>    xen_grants_setup_dma_ops
>
> And that's pretty much it.

+ likely renaming everything in that patch series not to mention virtio 
(mostly related to xen-virtio.c internals).


Stefano, thank you for clarifying Christoph's point.

Well, I am not against going this direction. Could we please make a 
decision on this? @Juergen, what is your opinion?



-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:29:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:29:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308089.523618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmzH-0005d7-8B; Tue, 19 Apr 2022 12:29:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308089.523618; Tue, 19 Apr 2022 12:29:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngmzH-0005d0-5G; Tue, 19 Apr 2022 12:29:43 +0000
Received: by outflank-mailman (input) for mailman id 308089;
 Tue, 19 Apr 2022 12:29:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngmzG-0005cq-0i; Tue, 19 Apr 2022 12:29:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngmzF-0006AY-Sn; Tue, 19 Apr 2022 12:29:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngmzF-0008UN-If; Tue, 19 Apr 2022 12:29:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngmzF-00082q-IB; Tue, 19 Apr 2022 12:29:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xevWI31KgAUDTzOFTlzt0fqDsSvR3NnuAxzqL7V7qhQ=; b=MzbwW2ZH2nzWCANA7csJK7xrT6
	GKekCGIlHbUDdxSDvf30eMimx9aQu31UsDOdVnNVbsTy19+2OVDFCf4yQkk4ALeG0blXivWXXU4GX
	1Wn1g+cX30SlGgAxCxi8o6lvaWdqcoc7MtHq+Tuou3SaOoDs5eOi30Vdfcw2u+9zTv04=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169539-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169539: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 12:29:41 +0000

flight 169539 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169539/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  505 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:37:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:37:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308097.523628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngn6w-0007RY-2v; Tue, 19 Apr 2022 12:37:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308097.523628; Tue, 19 Apr 2022 12:37:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngn6w-0007RR-06; Tue, 19 Apr 2022 12:37:38 +0000
Received: by outflank-mailman (input) for mailman id 308097;
 Tue, 19 Apr 2022 12:37:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tr1R=U5=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ngn6u-0007RI-M1
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 12:37:36 +0000
Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com
 [2a00:1450:4864:20::12d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d63112d-bfdd-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 14:37:35 +0200 (CEST)
Received: by mail-lf1-x12d.google.com with SMTP id w1so5753037lfa.4
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 05:37:35 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 i18-20020a198c52000000b0046fbc14aaf0sm1221784lfj.114.2022.04.19.05.37.34
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 05:37:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d63112d-bfdd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=jiC7Im7AQQbt7mNyNWlASOoQbbmpWO5m1GeN9ukK2DA=;
        b=HsrTiQ9TVtBpRqfvZhhAc3Pzgr6sG/FOHGeX5vFZdhDT4BTaXoYKaZHyynAWuHlioF
         5pvSPNb7V+dOFwDnOTrND8a2eEwQAVfGdMaTCTtJJGukbTE5dFVSUrVEAMJLwpSpJHX4
         roH0Nz22DS1k0j5U50rgFw+jFG4CHWQOuWjMKl+a1LDNGXKy0SrAZWs5fclsuvy6jlkh
         CSLd68aBoo9Ana6pOW8VyyhkgzFkoMh4Npg9GUzhyGQDF3OQF9KERkAXvQy3p4RJp/7F
         N4z4A+UDQ1jsIRjphNmdUTlU6ADmyThHwYY5rB2tt34NcO4h1KP9V3qnDcgBbv+Zo9JJ
         tJsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=jiC7Im7AQQbt7mNyNWlASOoQbbmpWO5m1GeN9ukK2DA=;
        b=W8AVAiQ0T+9ZV79APgVFZhDhg+vt5ZbwP77nfkhYzrJl/aJKd6cTmtKzEhtMffyqXf
         dtdvUWxlMF5jDSJWunAlbWMe7ilJhJk/JSkF5eL5qoiySdFoywea6lhWUXqiASBCe8Tx
         TFrzYKm73s3D4Vg2cKnaKcPOhLUxMU8VHtdWJ9jRYtlXR94jllKI4i49WgKGXqmYvSOi
         h6IhwCKSUPcoG4ztJ5aSnPnoVawm2tgv6TaxO2Agwk8nmcUWSFj3sO7k4z1tpqe/vcJE
         Z5U2G5USUIhdfVqpjgbd+VR+6X/z1Ku2d9Dwt/V7D7wHvAPyEtLShKFV2+oVZFL4Y1ct
         nhbw==
X-Gm-Message-State: AOAM533g/bK0VNpfUsIy3AELm8E5tV77AoAkQNE7kVilKnAyaCR0KTqp
	nQjS7NVx3HC4W4hPp29nhpY=
X-Google-Smtp-Source: ABdhPJzWT8ctc8ahHLqpBj1vfyk1hMfUozdSXRqu+YRd5PbOofVw5OQheI2VbYnNTLmIrsa4/QZeug==
X-Received: by 2002:ac2:4c49:0:b0:46d:db3:98cb with SMTP id o9-20020ac24c49000000b0046d0db398cbmr11002352lfk.516.1650371855153;
        Tue, 19 Apr 2022 05:37:35 -0700 (PDT)
Subject: Re: [RFC PATCH] libxl/arm: Insert "xen,dev-domid" property to
 virtio-mmio device node
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
 Kaly Xin <Kaly.Xin@arm.com>, Jiamei Xie <Jiamei.Xie@arm.com>,
 =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>
References: <1649964960-24864-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204181445300.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <89655e41-d9f6-06b6-1e63-f810689d154f@gmail.com>
Date: Tue, 19 Apr 2022 15:37:33 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204181445300.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 19.04.22 00:47, Stefano Stabellini wrote:


Hello Stefano

> On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> This is needed for grant table based DMA ops layer (CONFIG_XEN_VIRTIO)
>> at the guest side to retrieve the ID of Xen domain where the corresponding
>> backend resides (it is used as an argument to the grant table APIs).
>>
>> This is a part of restricted memory access under Xen feature.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> I think this looks good overall.

thank you


>   Instead of mentioning details of the
> Linux implementation, we should mention the device tree binding instead,
> including a link to it. The device tree binding is the relevant spec in
> this case.

I got it, while new device tree binding is not approved yet, I should 
have inserted a link to the corresponding Linux commit.

https://lore.kernel.org/xen-devel/1649963973-22879-4-git-send-email-olekstysh@gmail.com/


>
>
>> ---
>> !!! This patch is based on non upstreamed yet “Virtio support for toolstack
>> on Arm” series which is on review now:
>> https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/
>>
>> All details are at:
>> https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-olekstysh@gmail.com/
>> ---
>>   tools/libs/light/libxl_arm.c | 14 ++++++++++++--
>>   1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>> index 8132a47..d9b26fc 100644
>> --- a/tools/libs/light/libxl_arm.c
>> +++ b/tools/libs/light/libxl_arm.c
>> @@ -875,7 +875,8 @@ static int make_vpci_node(libxl__gc *gc, void *fdt,
>>   
>>   
>>   static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
>> -                                 uint64_t base, uint32_t irq)
>> +                                 uint64_t base, uint32_t irq,
>> +                                 uint32_t backend_domid)
>>   {
>>       int res;
>>       gic_interrupt intr;
>> @@ -900,6 +901,14 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
>>       res = fdt_property(fdt, "dma-coherent", NULL, 0);
>>       if (res) return res;
>>   
>> +    if (backend_domid != LIBXL_TOOLSTACK_DOMID) {
>> +        uint32_t domid[1];
>> +
>> +        domid[0] = cpu_to_fdt32(backend_domid);
>> +        res = fdt_property(fdt, "xen,dev-domid", domid, sizeof(domid));
>> +        if (res) return res;
>> +    }
>> +
>>       res = fdt_end_node(fdt);
>>       if (res) return res;
>>   
>> @@ -1218,7 +1227,8 @@ next_resize:
>>               libxl_device_disk *disk = &d_config->disks[i];
>>   
>>               if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
>> -                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) );
>> +                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq,
>> +                                           disk->backend_domid) );
>>           }
>>   
>>           if (pfdt)
>> -- 
>> 2.7.4

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:59:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:59:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308103.523640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnS0-0002YQ-N3; Tue, 19 Apr 2022 12:59:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308103.523640; Tue, 19 Apr 2022 12:59:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnS0-0002YJ-Jx; Tue, 19 Apr 2022 12:59:24 +0000
Received: by outflank-mailman (input) for mailman id 308103;
 Tue, 19 Apr 2022 12:59:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=swvq=U5=suse.cz=dsterba@srs-se1.protection.inumbo.net>)
 id 1ngnRy-0002YD-Lc
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 12:59:22 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 87a0a171-bfe0-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 14:59:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C99F51F38D;
 Tue, 19 Apr 2022 12:59:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 550DC139BE;
 Tue, 19 Apr 2022 12:59:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id BH7rEyiyXmLxeQAAMHmgww
 (envelope-from <dsterba@suse.cz>); Tue, 19 Apr 2022 12:59:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87a0a171-bfe0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1650373160;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=VfBYsPW8LdFmKxr65w1hdhdV60yv3YMcCbpJWSrqKvk=;
	b=NvUNYJ0aijygZaycEKANEzrLj5OpFXGbpMkv75nQ6FnXKgRf9EXcV4+9POedJBZkOwU5S7
	5pILnN4Shqgf3JhLxLgoR5OWcJL0pDDsuxwB46NB53CVYSYKQtDfU6ZcMenkfu3sqHVTkW
	IM2WCbvx+MAK2WLHjSdOm9gfT/yomU4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1650373160;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=VfBYsPW8LdFmKxr65w1hdhdV60yv3YMcCbpJWSrqKvk=;
	b=R3XLspmIJ8AmIyyP6ZGhyQkfkNAvIfydJiDrLZbCwnLmc9AnAFEIt/H4vRE7D3uxeV/uH+
	hd0WY76/Imja80AA==
Date: Tue, 19 Apr 2022 14:55:17 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 27/27] direct-io: remove random prefetches
Message-ID: <20220419125517.GB2348@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	drbd-dev@lists.linbit.com, nbd@other.debian.org,
	ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
References: <20220415045258.199825-1-hch@lst.de>
 <20220415045258.199825-28-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220415045258.199825-28-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Fri, Apr 15, 2022 at 06:52:58AM +0200, Christoph Hellwig wrote:
> Randomly poking into block device internals for manual prefetches isn't
> exactly a very maintainable thing to do.  And none of the performance
> criticil direct I/O implementations still use this library function
> anyway, so just drop it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

That the direct io function needed a valid bdev just for the prefetch
but nothing else was one of the reasons we had to keep the latest_bdev
in btrfs, so good riddance.

You may want to add the reference to the patch that added the prefetch,
65dd2aa90aa1 ("dio: optimize cache misses in the submission path") and
also remove #include <linux/prefetch.h> as there are no more uses of
prefetch in the file.

With that

Reviewed-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:59:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:59:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308104.523651 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnSC-0002sk-49; Tue, 19 Apr 2022 12:59:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308104.523651; Tue, 19 Apr 2022 12:59:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnSC-0002sd-1C; Tue, 19 Apr 2022 12:59:36 +0000
Received: by outflank-mailman (input) for mailman id 308104;
 Tue, 19 Apr 2022 12:59:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngnSA-0002YD-M0
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 12:59:35 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8d2097cc-bfe0-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 14:59:33 +0200 (CEST)
Received: from mail-mw2nam10lp2106.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.106])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 08:59:29 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BYAPR03MB4454.namprd03.prod.outlook.com (2603:10b6:a03:d2::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 12:59:26 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022
 12:59:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d2097cc-bfe0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650373173;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=5ICpOObHlHH/dvab1Vd/nThqagLI2LtlAVVgs+J/SSA=;
  b=PQIoZKueRIMWYmjhyh2iAFz/W2wPmJZOgzfpZ4X5VwIXkbQ2x+vcU45R
   4Axegb4ePab9qUquW5GoBse1pw2r9pWwDeZHGr2d3POF50+T/pIFUguJZ
   EJidXW3u5uDr4T3O1q5d93CmfnnQiyglnP40QNXJhsQdv3C/CO8ONXDO3
   E=;
X-IronPort-RemoteIP: 104.47.55.106
X-IronPort-MID: 68804197
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:mD6VD60/+g9MmlSMQfbD5TNwkn2cJEfYwER7XKvMYLTBsI5bp2dWn
 GIbXGmPaPyKZmL9eNhxYNyzoxsE6pTSydNmGgRspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIx0IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1JvL6zchsEP5frs70XYjtdGHpSI41JreqvzXiX6aR/zmXgWl61m7BLMxtzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfySu7e03x9p7ixKNd/Ya
 9AUdnxEaxPYbgcUElwWFIg/jKGjgXyXnzhw9gLF/fZusje7IApZ17LBMYLoRdGxSupTnmWgg
 D/f8E/oHURPXDCY4X/fmp62vcfNkjn8Q5k6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVUhm1pnfCoxAdXsZLHvMzwAaXw6HQ7kCSAW1sZjxLZcEitcQ2bSc3z
 VLPlNTsbRRwtJWFRHTb8a2bxRuwJCwUIGkqdSICCwwf7LHLu5ovhxjCStJiFq+djdDvHzz0h
 TeQo0AWjLUenMMN0aj94lHDhymEqZ3ATwpz7QLSNl9J9St8bY+hIom3s17S6K8YKJ7DFwHf+
 n8Zh8KZ8eYCS4mXkzCAS/kMG7fv4OuZNDrbghhkGJxJGymRxkNPtLt4uFlWTHqF+O5dEdM1S
 Cc/YT9s2aI=
IronPort-HdrOrdr: A9a23:Jk+8vKueoIbQbaWCCSEYfom97skCL4Aji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPuftXrdyRGVxeZZnMTfKlzbamDDH4tmuZ
 uIHJIOb+EYYWIasS++2njBLz9C+qjIzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf
 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIO/Z4StU
 z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfqWG0hYczBgNkGmpDq1L8Yqq
 iKn/7mBbU015rlRBDxnfIq4Xi47N9h0Q679bbSuwqfnSWwfkNHNyMGv/MZTvKR0TtfgDk3up
 g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIIO5gLZvin+9Kq1wVR4SKbpXYt
 VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFojvA3jzMF7tYwWpNE7+
 PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94KLf8fEw/qWnaZYIxJw9lN
 DIV05Zr3c7fwb0BciHzPRwg2fwqaWGLEDQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP
 v2MI5KApbYXB7TJbo=
X-IronPort-AV: E=Sophos;i="5.90,272,1643691600"; 
   d="scan'208";a="68804197"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SDzom3zTSTyzANHBVUz6yoTfpDQP1IDOVn3M/7Ji8aduIwBUPK0vkI3eW1TkFittxur1hwBpTcqqLhIS5bVWzZWjznJ8wEidLhSdBQ2WQP5UAATpa5rUBkjCxYdB+TbxYmZj1/QgKHIdPlIpP9Xo4EP9jdjJvByV0qPkiraewupT18pfI/dSTTXq3k8GSBU/4y7SqQEzXJJgeSKYS7TxoySW4I8X30iLjdLBpNpospstwbzIdv24Y9Ckhemiz2jNAaWTbC0pSQnJk+A8KoMVLXvOqZD3+pghBYVch2YspxUDtrZay2z/iPp4A89sVbaCN3HL7dGxrOTJ1rW/PioIow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5ICpOObHlHH/dvab1Vd/nThqagLI2LtlAVVgs+J/SSA=;
 b=P7L6uFhQ4z1Y5uCyk0QDiiYJ4yp7h/yT9YiCIPHrPRtqu1NhTCqek1Fq+Vpy6FfmGUzxMA6E1t6FjrYbkVpbs2CFPCMqwGCFtUc/nDA8H5jWjJtdWOxqEchRpgYFUbGikQfMBq3JK/fqSXrZU+qQ48vb1YoJiiWacPNaG3tScRMtcuug177o4exRRYIHUnH9nfnCvJBdo2tMV9ZK4W1K1fkUsYdb8377oQNLgASSocIatDmmvXX6a+iHDFV7mlrahibYXPzXFLuNfhdMMVkkKzH5FShbjXPpG5t2X+dztPpiULAuAXB8D+s90Gg06JjTdRkHbKwvT8FBOosCgyet9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5ICpOObHlHH/dvab1Vd/nThqagLI2LtlAVVgs+J/SSA=;
 b=tMquilAdM+c1xQw/B9Pw7GTjDnyssTktbdUPB3GcHtcgQivgXDp5SwkRzGja9iShmjeMJwHX6XkWW5ZjwoRCV4pHoYiDoK789vJl0xuMKFs6X9n9r3w0hj2u4WtUbB0UeG3qms8xdEh6g47xJ+s0bOEriDfxqcYGrRhbjgWi/AY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Elena Ufimtseva <elena.ufimtseva@oracle.com>, Jan Beulich
	<jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <George.Dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Cheyenne Wills
	<cheyenne.wills@gmail.com>
Subject: Re: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Topic: [PATCH v2] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Index: AQHYU9bjmHO326ELbkuQmQOwkh6+0Kz3DCaAgAADBYCAACONAA==
Date: Tue, 19 Apr 2022 12:59:24 +0000
Message-ID: <453b9e26-2a04-5990-bf9b-5dae862e33fa@citrix.com>
References: <20220419101850.3045-1-jgross@suse.com>
 <5c6f75d7-d5d1-856f-c8d0-da1bd823be63@citrix.com>
 <b10ad983-de3e-029c-6fa4-6aa646671fc5@suse.com>
In-Reply-To: <b10ad983-de3e-029c-6fa4-6aa646671fc5@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a995f764-e73b-45e6-49af-08da22046e1b
x-ms-traffictypediagnostic: BYAPR03MB4454:EE_
x-microsoft-antispam-prvs:
 <BYAPR03MB4454D5539B38A4F05F685907BAF29@BYAPR03MB4454.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 xLr23wtxk07hBWe0oLoghTJlx4JaS16sPFqr6jrHuTt6pflinjAfxKJbC35XF87Yh1rzVyI+T6/XLPKdZCHCQbo/+9PzUGtAicagmk8KoIpNdW7DCpLKfzYbRxqaCgmnPT4R7nLaeISrQRFFJoMw198PaY+KSYmOiwlFLDv1kYYuF4IhlRfYCLmwx6IlmkYHUTw+OZACc6ho7e7PsOsekXerlJy+XRV4+KUrsYBeIqWEx9munlyoUrMlGXsL5SLsGr92Dxp8o6lhU2IboJdG/Ra4jTwmon/Obqib2GAkp8FRZJ03TFHGdGNhc9Ro20mHjOZHsNURHyDQJfpa+qHlpuSh9bFUveibYQiviDb5z59He6aEK+FwiCdKx7IFX/miwZtASlU40hh0bVSFrSsVe8hBONTOKHtz0ostlHa7jQCi3JAkYu25L/dxNg+uSGoEKD3OjjXPjJvAg2KYqvwtz8GMShUu2X5EwlJQXFFx2KmHw5bSRBEGH8DTaCbvYAA96dBzbL+C1doeg9oW2l3lLGHGQypPS3zdv2YBEeeKyd1o4Ybnpu5DEN0ScupvBVDgLc3AbBuEOmxwvwJbi7ejomdopc0acp+6hZHFEjmnhH3CM61f/mnNyK4pcvRV58nbM22j/BuO649uceev7MmABYOmyGzinQxwWRrJbFQoH2ykj5KtrfCRzfo0l5qJd1YMwNPz/wlzK4h3a+AYSUCoIVzXmnG6NwbrSSjy3+CFnXkQwD14CbO6F1puIUbQJh8E07/ESBBQ0+aqSeQRRk1ru3cN/nt7drG7QFSeenUpXG8=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(2616005)(186003)(2906002)(91956017)(71200400001)(6486002)(86362001)(31686004)(4326008)(508600001)(83380400001)(6512007)(26005)(6506007)(31696002)(36756003)(8936002)(122000001)(66946007)(66556008)(66476007)(76116006)(5660300002)(316002)(64756008)(8676002)(66446008)(82960400001)(38070700005)(38100700002)(54906003)(110136005)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?WTZTTFVqWjBUQWppMDdtT0toSHR6aEJQeUI2K05reGU0Y01JMVpNSW1oUXNN?=
 =?utf-8?B?SUtUd1NoQXgvN0M0aWZXNWJXc0NZZ3RvZVVlYnliVEJLbkp3R0tGdHVNRnRh?=
 =?utf-8?B?S1lMTnEyOVNzalIyMGtsVkk0S085bGgwRUx6VjVJWC9nc0drdFprRnJ1b2Zz?=
 =?utf-8?B?b3pEWnNzL2dreXZMZGxxZ3I5ZjRVb1pZTmNYRUhOZEhiU0lmb1ovMExRLytl?=
 =?utf-8?B?V2hndzVlWXczTEVZSC9VY25zNUNrbTJrTGRqelhuRWczUnRxamV2eXRTSzNt?=
 =?utf-8?B?Mm11QXJUTXJLWC9PZlJNdjZvNng3bFZ4L1RMZEdyMkNHNjJpKzd6b0ZNR0NU?=
 =?utf-8?B?ajRMV0ZYdDBUaTNaN1J5NlVVeVg0d0lSSFJHR0FYQjhIV0lnSmFuRHV3cGQ0?=
 =?utf-8?B?UGVEMzdtcXQ1RmpUYXFDTytKQU9xT2dIREhSRkFRU0pIeXU2bzVIK3hQVUkr?=
 =?utf-8?B?RzV0TXZwZ0YxQSt1RmlGcVZaY3lXV3FsaG1CanR5ekV4ZWcyc0NuMzZHQlhm?=
 =?utf-8?B?UW10eG5LMGhvaWhaMnVyb3R2UElvY3hsSTVPV011emU5YThNWkkyMGtGM3A2?=
 =?utf-8?B?MmN3RTJsRm1DRzI1bk1kclhMcE5UUzFSZ25RbFY2TGdPWTUwU0xYc2lYZS95?=
 =?utf-8?B?cGhnNlZSN1phZkNqV0xZajIyOFBJTGtaSjBxOXpqNHdON3N1TERLY1F6MmZa?=
 =?utf-8?B?ZmlxR2M1WGRROXRsQVpjb3hOVE1aNGh2UDBaY3hTRjZPUGFxNFJjdXNQTGNJ?=
 =?utf-8?B?UUxmTElGLzRmZXk3TE82L0ZXcUhZYzg4SURhZ1RXSGN5RW4xTTNocGU2a0hR?=
 =?utf-8?B?ajBxSU1WenBBNkVVT0xLRW9VYnVWU0VaSzNxQWVvZzFJOTIwd2ZNNUtqNHlE?=
 =?utf-8?B?UnIvUUJiajg1VXJtU2FqQjNCK2R4YXlEajNMVDZXVldXZVJoOTBaREdDbU41?=
 =?utf-8?B?elFNMHJtZDF1a25RcHl2dGNzUjRjKzJSdFlwcFlNeWt4N2E5eFhkczBzcDkr?=
 =?utf-8?B?Z0hmR0F3WHcrSGtwNWhDZk9hcStsVnVFNVN5d085Z1hzRjVTN01HQUd3dzJ5?=
 =?utf-8?B?RStidmtKakpZRjdNN1MxN0VKUFM3eGZKTzFEVThTQWVaUXpvSGs3aWlJWDdQ?=
 =?utf-8?B?ekFHMk85ZGZsbXBzZjNRcTQzWFV5a0J2bDlweWppb0diaUdpQVFqQzBUcEdG?=
 =?utf-8?B?TjhKd05lcUI1dlVrSEFubEJoNkVUQXhNR0ZPbmk3T0s4M0ZkWlhEZkV3RzVz?=
 =?utf-8?B?OE5tQUlBdmYwMGRORkg0azRsUUNJYjc5dWM2NUxmU2FhdDh1UFlMNWFHVTFO?=
 =?utf-8?B?T3ErNVJnWGI1TnRCSUM3blpCTkhtZGJQS0lMNzB3aWFjeEMyTFRsREVPQ09G?=
 =?utf-8?B?bDNTUUZFMmVwVm1xRWJBTTMxeThENU5WMUFIWWVHVDhEeGQ1Nm54YWdhMVJ6?=
 =?utf-8?B?eUVoSWh4SWhydnlNMHJOZjREZUNyajJyVGZrNTkzNVQxYUJnRzQ3R1NOc25X?=
 =?utf-8?B?Q3lManVIaWxUWFdEdDUvUk9WWVljVDhnQm40TlNYYWJDZnE1eWlMSVVta3Zy?=
 =?utf-8?B?eWRlN1hKODNVdXVsVFQ0blY1UTBiMGIrYUFzS1FleHlGaVB6UEdNclRIZmZv?=
 =?utf-8?B?dG9IdjdlMmd6cW9JbXJGMnFGeWV4dkphL3YwSElpcCtZdVZVYXJybmN0MThp?=
 =?utf-8?B?MWt3OGx0YWVjdGZxK1VhWlpPZ2Y2eXB1UzMrdmtvaXV5Ly8ySjA5UzFncWlB?=
 =?utf-8?B?V2NxcnBKWWhmbmF3NzVsdmxOWFdLLzJ5Umd2Tm5tSVhzbjRWRXFJM21IeGVG?=
 =?utf-8?B?Wk1TME9XRVo5eHk2TktVczhDZm5aWUlVWlhULzdjNWREZU5yMlN4UFgwUExI?=
 =?utf-8?B?MmVJQkQyVXZyT05YNkd1WGNTdS9UVlQ2ejN3ZkFjeTc2K0VySGdMZU1JWks4?=
 =?utf-8?B?Q2lZMmNyZ3dFUHcrTlVjZDdUNGRLRnB4Y0I0OTA5dHczUElrdy9UY0dQTzhi?=
 =?utf-8?B?Y0V4d0JURm5DV2w5eDJ6Q2tnYXBERUNVdWJwdDJOc1lCaEpQZnNNMU41WFJT?=
 =?utf-8?B?UE42cnNIY0plTmc3SnE3UnBnYnk5UmVoc1hoVHAvLzV1ZlQ5NU85dlNrbHN1?=
 =?utf-8?B?RldwMm1VaXM5NzZNTUgwZ1dWaHpjbkVxKzRFUjdyUTRObHY1NER0VDdnRm5J?=
 =?utf-8?B?ODFCcFVrZHpwWUNIbWQ3U1pQZW4xV2k3ZzJtc0h6N1kyc3I1TDdUMlgwd0VT?=
 =?utf-8?B?cTFzaWdMMko1SUNmbWhTYXVqNmJDNVlteEM4QjJVWW1Gc2hVZ2EzVU5Jd3Fv?=
 =?utf-8?B?Ti9JN2d0SXlGMS8vb3Z0andNaHBWSEhFeWZrS29UUmdEZGtVUzJQZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D8DA544010D5A54791A3E7DBC81A3188@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a995f764-e73b-45e6-49af-08da22046e1b
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 12:59:24.4623
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ONn2jK4vmhFwdlCy1jpV2F4R6jPvVg8aqhlcGYHrhp43G7fvLo5BELRxo1EOljtUnSMPrOX5+SOUIly93gw8ZTSc2Sr8tfCoW/2uMoPIUcA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4454

T24gMTkvMDQvMjAyMiAxMTo1MSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gT24gMTkuMDQuMjIg
MTI6NDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxOS8wNC8yMDIyIDExOjE4LCBKdWVy
Z2VuIEdyb3NzIHdyb3RlOg0KPj4+IEEgaHlwZXJ2aXNvciBidWlsdCB3aXRob3V0IENPTkZJR19H
REJTWCB3aWxsIGNyYXNoIGluIGNhc2UgdGhlDQo+Pj4gWEVOX0RPTUNUTF9nZGJzeF9ndWVzdG1l
bWlvIGRvbWN0bCBpcyBiZWluZyBjYWxsZWQsIGFzIHRoZSBjYWxsIHdpbGwNCj4+PiBlbmQgdXAg
aW4gaW9tbXVfZG9fZG9tY3RsKCkgd2l0aCBkID09IE5VTEw6DQo+Pj4NCj4+PiAoWEVOKSBDUFU6
wqDCoMKgIDYNCj4+PiAoWEVOKSBSSVA6wqDCoMKgIGUwMDg6WzxmZmZmODJkMDQwMjY5OTg0Pl0g
aW9tbXVfZG9fZG9tY3RsKzB4NC8weDMwDQo+Pj4gKFhFTikgUkZMQUdTOiAwMDAwMDAwMDAwMDEw
MjAywqDCoCBDT05URVhUOiBoeXBlcnZpc29yIChkMHYwKQ0KPj4+IChYRU4pIHJheDogMDAwMDAw
MDAwMDAwMDNlOMKgwqAgcmJ4OiBmZmZmODMwODU2Mjc3ZWY4wqDCoCByY3g6DQo+Pj4gZmZmZjgz
MDg1NjI3N2ZmZg0KPj4+IC4uLg0KPj4+IChYRU4pIFhlbiBjYWxsIHRyYWNlOg0KPj4+IChYRU4p
wqDCoMKgIFs8ZmZmZjgyZDA0MDI2OTk4ND5dIFIgaW9tbXVfZG9fZG9tY3RsKzB4NC8weDMwDQo+
Pj4gKFhFTinCoMKgwqAgWzxmZmZmODJkMDQwMzVjZDVmPl0gUyBhcmNoX2RvX2RvbWN0bCsweDdm
LzB4MjMzMA0KPj4+IChYRU4pwqDCoMKgIFs8ZmZmZjgyZDA0MDIzOWU0Nj5dIFMgZG9fZG9tY3Rs
KzB4ZTU2LzB4MTkzMA0KPj4+IChYRU4pwqDCoMKgIFs8ZmZmZjgyZDA0MDIzOGZmMD5dIFMgZG9f
ZG9tY3RsKzAvMHgxOTMwDQo+Pj4gKFhFTinCoMKgwqAgWzxmZmZmODJkMDQwMmY4YzU5Pl0gUyBw
dl9oeXBlcmNhbGwrMHg5OS8weDExMA0KPj4+IChYRU4pwqDCoMKgIFs8ZmZmZjgyZDA0MDJmNTE2
MT5dIFMNCj4+PiBhcmNoL3g4Ni9wdi9kb21haW4uYyNfdG9nZ2xlX2d1ZXN0X3B0KzB4MTEvMHg5
MA0KPj4+IChYRU4pwqDCoMKgIFs8ZmZmZjgyZDA0MDM2NjI4OD5dIFMgbHN0YXJfZW50ZXIrMHgx
MjgvMHgxMzANCj4+PiAoWEVOKQ0KPj4+IChYRU4pIFBhZ2V0YWJsZSB3YWxrIGZyb20gMDAwMDAw
MDAwMDAwMDE0NDoNCj4+PiAoWEVOKcKgIEw0WzB4MDAwXSA9IDAwMDAwMDAwMDAwMDAwMDAgZmZm
ZmZmZmZmZmZmZmZmZg0KPj4+IChYRU4pDQo+Pj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKg0KPj4+IChYRU4pIFBhbmljIG9uIENQVSA2Og0KPj4+IChYRU4p
IEZBVEFMIFBBR0UgRkFVTFQNCj4+PiAoWEVOKSBbZXJyb3JfY29kZT0wMDAwXQ0KPj4+IChYRU4p
IEZhdWx0aW5nIGxpbmVhciBhZGRyZXNzOiAwMDAwMDAwMDAwMDAwMTQ0DQo+Pj4NCj4+PiBGaXgg
dGhpcyBpc3N1ZSBieSBtb2RpZnlpbmcgdGhlIGludGVyZmFjZSBvZiBnZGJzeF9ndWVzdF9tZW1f
aW8oKSB0bw0KPj4+IHRha2UgdGhlIGFscmVhZHkga25vd24gZG9tYWluIHBvaW50ZXIgaW5zdGVh
ZCBvZiB0aGUgZG9taWQuDQo+Pg0KPj4gVGhlcmUgaXMgc29tZSBleHBsYW5hdGlvbiBtaXNzaW5n
IGhlcmUuwqAgVGhlIGFkanVzdG1lbnRzIHlvdSBtYWtlIGFyZQ0KPj4gd2l0aGluIENPTkZJR19H
REJTWCwgd2l0aCB0aGUgZXhjZXB0aW9uIG9mIHRoZSBmaW5hbCBodW5rLg0KPg0KPiBZZWFoLCBh
bmQgdGhpcyBpcyB0aGUgb25lIHJlYWxseSBmaXhpbmcgdGhlIGlzc3VlLCB3aGlsZSB0aGUNCj4g
b3RoZXIgaHVua3MgYXJlIG5lZWRlZCB0byBjb3BlIHdpdGggdGhlIHdheSB0aGUgcHJvYmxlbSBp
cw0KPiBmaXhlZC4NCg0KSW4gd2hpY2ggY2FzZSB0aGUgc2FsaWVudCBwb2ludCBuZWVkZWQgaW4g
dGhlIGNvbW1pdCBtZXNzYWdlIGlzICJyZWplY3QNCnRoZSB1c2Ugb2YgWEVOX0RPTUNUTF9nZGJz
eF9ndWVzdG1lbWlvIHdpdGhvdXQgYSB2YWxpZCBkb21haW4iLg0KDQpJJ2QgZ28gc28gZmFyIGFz
IHRvIHNheSB0aGF0IHRoYXQgb3VnaHQgdG8gYmUgYSBvbmVsaW5lciBmaXgsIHdoaWNoIGFsc28N
CmRpc2N1c3NlcyB3aHkgaXQncyBzYWZlIG5vdyAoaXQgZGlkbid0IHVzZWQgdG8gYmUgSUlSQyks
IGFuZCB0aGUgY2xlYW51cA0KaW4gYSBzZXBhcmF0ZSBwYXRjaC4NCg0KVGhpcyBhbHNvIHJlbWlu
ZHMgbWUgdGhhdCB0aGVyZSdzIGEgcGlsZSBvZiBhbG1vc3QgY29tcGxldGUgc2VyaWVzIG9mDQpk
ZWJ1Z2dlci9nZGJzeC90cmFwcyBjbGVhbnVwIGluIG5lZWQgb2YgcHVzaGluZyBvdmVyIHRoZSBs
aW5lLg0KDQo+DQo+PiBUaGUgYWN0dWFsIGJ1ZyBpcyB0aGF0IG5vbi1JT01NVSBzdWJvcHMgZW5k
IHVwIGluIGlvbW11X2RvX2RvbWN0bCgpLCBzbw0KPj4gd2hpbGUgdGhpcyBpcyBnb29kIGNsZWFu
dXAgdG8gZ2Ric3hfZ3Vlc3RfbWVtX2lvKCkgaXQsIGFsb25nIHdpdGggSmFuJ3MNCj4+IGFkanVz
dG1lbnQgdG8gaW9tbXVfZG9fZG9tY3RsKCksIGFyZSBub3Qgc3VpdGFibGUgZml4ZXMgdG8gdGhl
IGNyYXNoIGFzDQo+PiByZXBvcnRlZC4NCj4NCj4gVGhlIHNhbWUgd2F5IG5vbi1hcmNoIHN1Ym9w
cyBtaWdodCBlbmQgdXAgaW4gYXJjaF9kb19kb21jdGwoKS4NCj4NCj4gV2hhdCB3b3VsZCBiZSB0
aGUgcmlnaHQgd2F5IHRvIGZpeCB0aGF0IGluIHlvdXIgb3Bpbmlvbj8NCj4NCj4gSU1PIGFueSBz
dWJvcCBoYW5kbGVyIGNhbGxlZCB1bmRlciB0aGUgZGVmYXVsdCBsYWJlbCBvZiBhIHN3aXRjaCgp
IHNob3VsZA0KPiBiZSBhYmxlIHRvIGhhbmRsZSB1bmtub3duIHN1Ym9wcy4gVGhpcyBpcyBkb25l
IGZvciBpb21tdV9kb19kb21jdGwoKSBpbg0KPiBKYW4ncyBwYXRjaCBieSBub3QgZGVyZWZlcmVu
Y2luZyBkIHVuY29uZGl0aW9uYWxseS4NCg0KVGhlIHByb2JsZW0gaXNuJ3QgKHNwZWNpZmljYWxs
eSkgaG93IHRoZXkncmUgY2hhaW5lZDsgaXQncyB0aGUgbmFtZS7CoA0KYXJjaF9kb19kb21jdGwo
KSBpcyBjbGVhcmx5IGEgZHVtcGluZyBncm91bmQgZm9yIGFyYml0cmFyeSBzdWJvcHMuwqANCmlv
bW11X2RvX2RvbWN0bCgpIGlzIGNsZWFybHkgbm90Lg0KDQpUaGUgYnVnIHdhcyB1bHRpbWF0ZWx5
IGNoYWluaW5nIGlvbW11X2RvX2RvbWN0bCgpIGluIGEgZGVmYXVsdCwgd2hpY2ggaXMNCndoeSBp
dCAqd2FzKiByZWFzb25hYmxlIGZvciAidXNlIGlzX2lvbW11X2VuYWJsZWQoKSB3aGVyZQ0KYXBw
cm9wcmlhdGUuLi4iIHRvIGFzc3VtZSB0aGF0IG9ubHkgaW9tbXUgc3Vib3BzIHdvdWxkIHJlYWNo
IHRoZSBmdW5jdGlvbi4NCg0KaW9tbXVfZG9fZG9tY3RsKCkgZWl0aGVyIG5lZWRzIHJlLWNoYWlu
aW5nIHVuZGVyIHNldmVyYWwgY2FzZSB4eHg6LCBvcg0KaXQgbmVlZHMgcmVuYW1pbmcgdG8gc29t
ZXRoaW5nIGdlbmVyaWMgbGlrZSBhcmNoX2RvX2RvbWN0bDIoKS4NCg0KTm90aGluZyBlbHNlIGlz
IGdvaW5nIHRvIGxlYXZlIHRoZSBjb2RlIGluIGEgcG9zaXRpb24gd2hlcmUgaXQncyBoYXJkZXIN
CnRvIG1ha2UgbWlzdGFrZXMgbGlrZSB0aGlzLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 12:59:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 12:59:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308105.523662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnSD-00039i-DY; Tue, 19 Apr 2022 12:59:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308105.523662; Tue, 19 Apr 2022 12:59:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnSD-00039Q-9W; Tue, 19 Apr 2022 12:59:37 +0000
Received: by outflank-mailman (input) for mailman id 308105;
 Tue, 19 Apr 2022 12:59:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngnSC-00031H-JW; Tue, 19 Apr 2022 12:59:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngnSC-0006ff-GX; Tue, 19 Apr 2022 12:59:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngnSB-0000l5-WB; Tue, 19 Apr 2022 12:59:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngnSB-0007CM-Vk; Tue, 19 Apr 2022 12:59:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zGmujEL+tQlv6AQyHtnxYKYfTWLRyKVdoDLGzIx/zRI=; b=S7qnbdEY3qiGse1rEPWQwZUVI8
	aZg9sRT3mVchhICE3Ojgcjryl+vrGirLAJLIFSvgy9ERGtpx8cJDwiHsDTz36mqRx93QC7DCW1dLH
	bNe3E53a5Qnzu4Js+PmM2+pv7Cu17/fRdxD8JW+KvlWdt4CRSxiE5B+rLa6HEQ91Eqzc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169540-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169540: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 12:59:35 +0000

flight 169540 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169540/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  506 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 13:02:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 13:02:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308122.523672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnUg-0005JX-U0; Tue, 19 Apr 2022 13:02:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308122.523672; Tue, 19 Apr 2022 13:02:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnUg-0005JQ-Qy; Tue, 19 Apr 2022 13:02:10 +0000
Received: by outflank-mailman (input) for mailman id 308122;
 Tue, 19 Apr 2022 13:02:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngnUf-0005JG-QN; Tue, 19 Apr 2022 13:02:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngnUf-0006kJ-Pa; Tue, 19 Apr 2022 13:02:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngnUf-0000pa-Jf; Tue, 19 Apr 2022 13:02:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngnUf-0007Kz-JH; Tue, 19 Apr 2022 13:02:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=O2pfSsS/qw+KRVvWy6X0kPV6zgm3TPi4n0os8QjU5hY=; b=ZkbEf8zVV5dVV5X2QG8PK2rnf6
	5tPosI821ZKrF4QDpUyj9S6hjfKoYiKYNgptqXVU20EAIssSEUWu+ciDpL5wsYZL28k14ro3iICTG
	7worfOfvodFSHwTHntxj+iTTI8zAJ3eSBvfnCNQgrC2Lm8at6+27LyAi2TR68C1ycnlE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169537-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169537: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b881cb95cb034466d3dd9be52f5a7e6594148a90
X-Osstest-Versions-That:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 13:02:09 +0000

flight 169537 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169537/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b881cb95cb034466d3dd9be52f5a7e6594148a90
baseline version:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647

Last test of basis   169368  2022-04-13 15:00:25 Z    5 days
Testing same since   169537  2022-04-19 10:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e509b5f932..b881cb95cb  b881cb95cb034466d3dd9be52f5a7e6594148a90 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 13:10:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 13:10:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308132.523684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngncy-0006oR-Sy; Tue, 19 Apr 2022 13:10:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308132.523684; Tue, 19 Apr 2022 13:10:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngncy-0006oK-P7; Tue, 19 Apr 2022 13:10:44 +0000
Received: by outflank-mailman (input) for mailman id 308132;
 Tue, 19 Apr 2022 13:10:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F37o=U5=infradead.org=peterz@srs-se1.protection.inumbo.net>)
 id 1ngncx-0006oE-Af
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 13:10:43 +0000
Received: from desiato.infradead.org (desiato.infradead.org
 [2001:8b0:10b:1:d65d:64ff:fe57:4e05])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1cde6a7f-bfe2-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 15:10:41 +0200 (CEST)
Received: from j217100.upc-j.chello.nl ([24.132.217.100]
 helo=worktop.programming.kicks-ass.net)
 by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1ngncl-006pDV-GG; Tue, 19 Apr 2022 13:10:31 +0000
Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000)
 id 3704A986195; Tue, 19 Apr 2022 15:10:29 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1cde6a7f-bfe2-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:
	Sender:Reply-To:Content-ID:Content-Description;
	bh=DmKV20mrS057BFjgATIFfZZcbYOc9ROzIdfK5243MKM=; b=mjrfG+wkWhTeI0dI2U3/RqSdqu
	JoEaZ6bbl++VC4ETSUfRnKxCv6dr1hOw+XrwTv4Ait7LcnTbVcAEtrFWMRnh9yoRhKXY4frfOgGbb
	WRNdWc0IHmp5CpK7GWAYLZbVXP/vtkU1UBtssh2G+cjh5mO1i6RnyjK8A83skYrT65Rhysx/LXvre
	CUahQjroG2a0As//v7wBm/gJiP24DK5hQMeHT1FrRe7hbWNQSh1xrTHR30i0eFoZYgiF46/PMslHf
	4VaCpC3D9WOKP5xaWO72w1gsnZ2ld22v3EacVlCoKir72iUhhezdGKMRAHBZjDpa8mBgcJVydYGV4
	f/URuBWw==;
Date: Tue, 19 Apr 2022 15:10:29 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Cooper <amc96@srcf.net>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Miroslav Benes <mbenes@suse.cz>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Message-ID: <20220419131029.GV2731@worktop.programming.kicks-ass.net>
References: <cover.1650300597.git.jpoimboe@redhat.com>
 <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
 <b94cbac6-0a4d-8e4a-ec58-bbd46e385d45@citrix.com>
 <20220419115737.GU2731@worktop.programming.kicks-ass.net>
 <8fbbd4ca-54b1-8c1c-19bc-3d0e6044ff5d@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8fbbd4ca-54b1-8c1c-19bc-3d0e6044ff5d@srcf.net>

On Tue, Apr 19, 2022 at 01:12:14PM +0100, Andrew Cooper wrote:

> > Subject: x86/xen: Add ANNOTATE_ENDBR to startup_xen()
> > From: Josh Poimboeuf <jpoimboe@redhat.com>
> > Date: Mon, 18 Apr 2022 09:50:25 -0700
> >
> > From: Josh Poimboeuf <jpoimboe@redhat.com>
> >
> > The startup_xen() kernel entry point is referenced by the ".note.Xen"
> > section, and is the real entry point of the VM. It *will* be
> > indirectly branched to, *however* currently Xen doesn't support PV VM
> > with CET active.
> 
> Technically it's always IRET'd to, but the point is that it's never
> "branched to" by the execution context of the VM.
> 
> So it would be better to say that it's never indirectly branched to.�
> That's what the IBT checks care about.

Right, so I was thinking the IRET could set the NEED_ENDBR bit, but
yeah, that might be stretching the definition of an indirect-branch a
wee bit.

How about so then?

---
Subject: x86/xen: Add ANNOTATE_NOENDBR to startup_xen()
From: Josh Poimboeuf <jpoimboe@redhat.com>
Date: Mon, 18 Apr 2022 09:50:25 -0700

From: Josh Poimboeuf <jpoimboe@redhat.com>

The startup_xen() kernel entry point is referenced by the ".note.Xen"
section, and is the real entry point of the VM. Control transfer is
through IRET, which *could* set NEED_ENDBR, however Xen currently does
no such thing.

Add ANNOTATE_NOENDBR to silence future objtool warnings.

Fixes: ed53a0d97192 ("x86/alternative: Use .ibt_endbr_seal to seal indirect calls")
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Link: https://lkml.kernel.org/r/a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 13:19:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 13:19:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308137.523694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnla-0007dh-JG; Tue, 19 Apr 2022 13:19:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308137.523694; Tue, 19 Apr 2022 13:19:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngnla-0007da-GJ; Tue, 19 Apr 2022 13:19:38 +0000
Received: by outflank-mailman (input) for mailman id 308137;
 Tue, 19 Apr 2022 13:19:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MQ6T=U5=gmail.com=robherring2@srs-se1.protection.inumbo.net>)
 id 1ngnlY-0007dU-Tm
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 13:19:36 +0000
Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com
 [209.85.210.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5ad5e2d4-bfe3-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 15:19:35 +0200 (CEST)
Received: by mail-ot1-f53.google.com with SMTP id
 c11-20020a9d684b000000b00603307cef05so8353759oto.3
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 06:19:35 -0700 (PDT)
Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net.
 [66.90.144.107]) by smtp.gmail.com with ESMTPSA id
 o64-20020acad743000000b002ef3b249b9esm5002838oig.58.2022.04.19.06.19.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Apr 2022 06:19:33 -0700 (PDT)
Received: (nullmailer pid 2323034 invoked by uid 1000);
 Tue, 19 Apr 2022 13:19:32 -0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ad5e2d4-bfe3-11ec-a405-831a346695d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=hYORCeWbeix4J5CxHYndk8/zWspzxFUk4CcUI2nGMhg=;
        b=abj5N4EnP0wOp+NqFxi9fDdBNpIUr1fjwVia3NUiRXUJqkT/kIJy6ouoejcGqtcKXB
         HIFgKP9V5jpMEbuUE34v8OS8n+BhdSSin10GaPiQPpQ5SXgAoZNFr7tZqZXSbZj17BlD
         hISu3pE++t11VUXkM1j+dvHFE2M9U0QcrScUTIJbzqJV0uVSIYrcrb1+LffmSHtHINV2
         vx6aRf8YkyT9KLTqvajRwpm3xiuD2dBqmxd//qnbc8MEDEmGZ1oUd3da+bVplxjOqkaU
         zOo4yEDUkmvhyaUiPt7ZPtBBY3M0RNjdy7HwqWJw+68eJiV7td2HlL704S+T6uFArmBK
         nfKw==
X-Gm-Message-State: AOAM532TkRDi0f3KCpUqMUTdbk/tFqh7Zaafj9jSnJajc6cLadCoTvyj
	18mJB5L1Zt/C0wWveT9Lww==
X-Google-Smtp-Source: ABdhPJz95PNkSHrePsY47MQUDBbqQF6249VaMMsqV2Yk41XDjy6ZzbVnMxC2DSC071gfjYWvuQ90cA==
X-Received: by 2002:a9d:12a9:0:b0:603:d1cc:68eb with SMTP id g38-20020a9d12a9000000b00603d1cc68ebmr5741572otg.326.1650374373912;
        Tue, 19 Apr 2022 06:19:33 -0700 (PDT)
Date: Tue, 19 Apr 2022 08:19:32 -0500
From: Rob Herring <robh@kernel.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: devicetree@vger.kernel.org, xen-devel@lists.xenproject.org, Stefano Stabellini <stefano.stabellini@xilinx.com>, robh+dt@kernel.org, julien@xen.org, frowand.list@gmail.com
Subject: Re: [PATCH v2] of: of_property_read_string return -ENODATA when
 !length
Message-ID: <Yl625EnFl0/MChux@robh.at.kernel.org>
References: <20220416003028.1315268-1-sstabellini@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220416003028.1315268-1-sstabellini@kernel.org>

On Fri, 15 Apr 2022 17:30:28 -0700, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> When the length of the string is zero of_property_read_string should
> return -ENODATA according to the description of the function.
> 
> However, of_property_read_string doesn't check prop->length. If
> prop->length is zero, return -ENODATA.
> 
> Without this patch the following command in u-boot:
> 
> fdt set /chosen/node property-name
> 
> results in of_property_read_string returning -EILSEQ when attempting to
> read property-name. With this patch, it returns -ENODATA as expected.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> ---
> Changes in v2:
> - use prop instead pp
> - drop value check
> - update function header documentation
> ---
>  drivers/of/property.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Applied, thanks!


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 13:53:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 13:53:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308149.523739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoHu-0004VP-9C; Tue, 19 Apr 2022 13:53:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308149.523739; Tue, 19 Apr 2022 13:53:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoHu-0004V8-5Q; Tue, 19 Apr 2022 13:53:02 +0000
Received: by outflank-mailman (input) for mailman id 308149;
 Tue, 19 Apr 2022 13:53:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngoHs-0003n9-1V
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 13:53:00 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 053ec57a-bfe8-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 15:52:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3886C1F750;
 Tue, 19 Apr 2022 13:52:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DF56D132E7;
 Tue, 19 Apr 2022 13:52:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qB5ZNbm+XmL/EgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 13:52:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 053ec57a-bfe8-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650376378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6/VWhQSdoCzBqVa8x/quqgeEjSXetNd8IJxjXUoErU4=;
	b=M3cz+pB2CCUNe8C1A95O1lap4xXxEgJXnIhJva5g0Czvy8QIjRm4AVBN2V41i/jHVYaKQM
	qff3o6VRyCjFgOJDEMedddRdAIswQXmsyxyo7kbXiAijOsMh8Njq8WBQxfkQvum2Y6UoNa
	p0R2TGqhEdgPeYfl34L9V1G5S/jg1yQ=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v3 3/3] xen/iommu: cleanup iommu related domctl handling
Date: Tue, 19 Apr 2022 15:52:54 +0200
Message-Id: <20220419135254.21729-4-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220419135254.21729-1-jgross@suse.com>
References: <20220419135254.21729-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today iommu_do_domctl() is being called from arch_do_domctl() in the
"default:" case of a switch statement. This has led already to crashes
due to unvalidated parameters.

Fix that by moving the call of iommu_do_domctl() to the main switch
statement of do_domctl().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
Another possibility would even be to merge iommu_do_domctl() completely
into do_domctl(), but I wanted to start with a less intrusive variant.
V3:
- new patch
---
 xen/arch/arm/domctl.c | 11 +----------
 xen/arch/x86/domctl.c |  2 +-
 xen/common/domctl.c   |  7 +++++++
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 6245af6d0b..1baf25c3d9 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -176,16 +176,7 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
         return rc;
     }
     default:
-    {
-        int rc;
-
-        rc = subarch_do_domctl(domctl, d, u_domctl);
-
-        if ( rc == -ENOSYS )
-            rc = iommu_do_domctl(domctl, d, u_domctl);
-
-        return rc;
-    }
+        return subarch_do_domctl(domctl, d, u_domctl);
     }
 }
 
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index a6aae500a3..c9699bb868 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -1380,7 +1380,7 @@ long arch_do_domctl(
         break;
 
     default:
-        ret = iommu_do_domctl(domctl, d, u_domctl);
+        ret = -ENOSYS;
         break;
     }
 
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 5879117580..0a866e3132 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -871,6 +871,13 @@ long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
             copyback = 1;
         break;
 
+    case XEN_DOMCTL_assign_device:
+    case XEN_DOMCTL_test_assign_device:
+    case XEN_DOMCTL_deassign_device:
+    case XEN_DOMCTL_get_device_group:
+        ret = iommu_do_domctl(op, d, u_domctl);
+        break;
+
     default:
         ret = arch_do_domctl(op, d, u_domctl);
         break;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 13:53:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 13:53:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308148.523718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoHt-0003xv-3W; Tue, 19 Apr 2022 13:53:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308148.523718; Tue, 19 Apr 2022 13:53:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoHs-0003vt-SQ; Tue, 19 Apr 2022 13:53:00 +0000
Received: by outflank-mailman (input) for mailman id 308148;
 Tue, 19 Apr 2022 13:53:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngoHr-0003n8-W7
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 13:52:59 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 04db1180-bfe8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 15:52:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5D08421115;
 Tue, 19 Apr 2022 13:52:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DB791132E7;
 Tue, 19 Apr 2022 13:52:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iSgbNLi+XmL/EgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 13:52:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04db1180-bfe8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650376377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=Ll2L1V6q8NZn8/JqOsU4pqS0bFns/4R0D70JW/DGZeI=;
	b=dhKl+/szZfTJVsMqem+E61stA8sIw0VfVk5k/DaHmDMKreCB3twkD4TutqoWXHEhpKVp/D
	jzE+3CnPRFLrFIfhIbgfM7x69nG02rqZoObWo0ppXF0BYLa+SDzxHPRxulTPrNiG+jGFZ2
	CBgZflMUT3u/sK1Ef9SmZturB5oZIDE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Elena Ufimtseva <elena.ufimtseva@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 0/3] xen: fix and cleanup domctl handling
Date: Tue, 19 Apr 2022 15:52:51 +0200
Message-Id: <20220419135254.21729-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

A fix of a hypervisor crash in domctl handling and some related cleanup.

Juergen Gross (3):
  xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
  xen: cleanup gdbsx_guest_mem_io() call
  xen/iommu: cleanup iommu related domctl handling

 xen/arch/arm/domctl.c               | 11 +----------
 xen/arch/x86/debug.c                | 12 +++---------
 xen/arch/x86/domctl.c               |  8 ++++----
 xen/arch/x86/include/asm/debugger.h |  2 +-
 xen/common/domctl.c                 |  8 +++++++-
 5 files changed, 16 insertions(+), 25 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 13:53:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 13:53:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308146.523705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoHs-0003nb-EP; Tue, 19 Apr 2022 13:53:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308146.523705; Tue, 19 Apr 2022 13:53:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoHs-0003nU-BS; Tue, 19 Apr 2022 13:53:00 +0000
Received: by outflank-mailman (input) for mailman id 308146;
 Tue, 19 Apr 2022 13:52:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngoHr-0003n8-7U
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 13:52:59 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 04ee214f-bfe8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 15:52:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 99CC12112B;
 Tue, 19 Apr 2022 13:52:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 52884139F6;
 Tue, 19 Apr 2022 13:52:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qIzvErm+XmL/EgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 13:52:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04ee214f-bfe8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650376377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=U4wJ7ITwhPEI/c6FS563E3yxL+vilAPqU1YHXYgdh9M=;
	b=Hf6Slkfb596jSsL3JpkD7yHvevxLV4Qye9KDHHZ/dDIveP3Ydu2S3uG2BMPWYjShF7hr//
	b2WPKajFuirm/rkkY0+WSALlMYvz2yySc2cxBP1+6Jl8nmLjgaJT+D1J6aDCC8ZmF3EAZ9
	Pc/xwSB3toL7eopkTTrpsWGYanuwNlQ=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Cheyenne Wills <cheyenne.wills@gmail.com>
Subject: [PATCH v3 1/3] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Date: Tue, 19 Apr 2022 15:52:52 +0200
Message-Id: <20220419135254.21729-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220419135254.21729-1-jgross@suse.com>
References: <20220419135254.21729-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

A hypervisor built without CONFIG_GDBSX will crash in case the
XEN_DOMCTL_gdbsx_guestmemio domctl is being called, as the call will
end up in iommu_do_domctl() with d == NULL:

(XEN) CPU:    6
(XEN) RIP:    e008:[<ffff82d040269984>] iommu_do_domctl+0x4/0x30
(XEN) RFLAGS: 0000000000010202   CONTEXT: hypervisor (d0v0)
(XEN) rax: 00000000000003e8   rbx: ffff830856277ef8   rcx: ffff830856277fff
...
(XEN) Xen call trace:
(XEN)    [<ffff82d040269984>] R iommu_do_domctl+0x4/0x30
(XEN)    [<ffff82d04035cd5f>] S arch_do_domctl+0x7f/0x2330
(XEN)    [<ffff82d040239e46>] S do_domctl+0xe56/0x1930
(XEN)    [<ffff82d040238ff0>] S do_domctl+0/0x1930
(XEN)    [<ffff82d0402f8c59>] S pv_hypercall+0x99/0x110
(XEN)    [<ffff82d0402f5161>] S arch/x86/pv/domain.c#_toggle_guest_pt+0x11/0x90
(XEN)    [<ffff82d040366288>] S lstar_enter+0x128/0x130
(XEN)
(XEN) Pagetable walk from 0000000000000144:
(XEN)  L4[0x000] = 0000000000000000 ffffffffffffffff
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 6:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=0000]
(XEN) Faulting linear address: 0000000000000144

Fix this issue by making sure the domain pointer has a sane value.

Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
Fixes: e726a82ca0dc ("xen: make gdbsx support configurable")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- use gdbsx_guest_mem_io() interface modification (Jan Beulich)
V3:
- avoid d being NULL (Andrew Cooper)
---
 xen/common/domctl.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 57135d4478..5879117580 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -308,7 +308,6 @@ long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
         if ( op->domain == DOMID_INVALID )
         {
     case XEN_DOMCTL_createdomain:
-    case XEN_DOMCTL_gdbsx_guestmemio:
             d = NULL;
             break;
         }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 13:53:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 13:53:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308147.523710 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoHs-0003qn-Mb; Tue, 19 Apr 2022 13:53:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308147.523710; Tue, 19 Apr 2022 13:53:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoHs-0003q8-Ir; Tue, 19 Apr 2022 13:53:00 +0000
Received: by outflank-mailman (input) for mailman id 308147;
 Tue, 19 Apr 2022 13:52:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngoHr-0003n9-94
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 13:52:59 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0515609d-bfe8-11ec-8fbe-03012f2f19d4;
 Tue, 19 Apr 2022 15:52:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id DA6AA1F74E;
 Tue, 19 Apr 2022 13:52:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A1228132E7;
 Tue, 19 Apr 2022 13:52:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ANwbJrm+XmL/EgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 13:52:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0515609d-bfe8-11ec-8fbe-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650376377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=L4AQsF0qS2f7XQ0Ro2SIxitX/SjtNc2JqVh6FUtqIEw=;
	b=Sn0cIqdU25k6LU5Xq0tjR2hNggQ5idFBTMTSHFb+cdV+iAVHw9HqsRzQXjwQOgTo/IjHp2
	mKKdgfoqSLEkghtzRl8Ofx1m0E1oyO37SLK9kQl0v+reN9mAZuDMSW0MAW6inV0DGa0pZ1
	5IlCxWRRiDk3vcreY8Oq7bfA9rG1yk8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Elena Ufimtseva <elena.ufimtseva@oracle.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 2/3] xen: cleanup gdbsx_guest_mem_io() call
Date: Tue, 19 Apr 2022 15:52:53 +0200
Message-Id: <20220419135254.21729-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220419135254.21729-1-jgross@suse.com>
References: <20220419135254.21729-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Modify the gdbsx_guest_mem_io() interface to take the already known
domain pointer as parameter instead of the domid. This enables to
remove some more code further down the call tree.

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- split off from previous patch (Andrew Cooper)
---
 xen/arch/x86/debug.c                | 12 +++---------
 xen/arch/x86/domctl.c               |  6 +++---
 xen/arch/x86/include/asm/debugger.h |  2 +-
 3 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/xen/arch/x86/debug.c b/xen/arch/x86/debug.c
index d90dc93056..62fbabb084 100644
--- a/xen/arch/x86/debug.c
+++ b/xen/arch/x86/debug.c
@@ -159,17 +159,11 @@ static unsigned int dbg_rw_guest_mem(struct domain *dp, unsigned long addr,
  * Returns: number of bytes remaining to be copied.
  */
 unsigned int dbg_rw_mem(unsigned long gva, XEN_GUEST_HANDLE_PARAM(void) buf,
-                        unsigned int len, domid_t domid, bool toaddr,
+                        unsigned int len, struct domain *d, bool toaddr,
                         uint64_t pgd3)
 {
-    struct domain *d = rcu_lock_domain_by_id(domid);
-
-    if ( d )
-    {
-        if ( !d->is_dying )
-            len = dbg_rw_guest_mem(d, gva, buf, len, toaddr, pgd3);
-        rcu_unlock_domain(d);
-    }
+    if ( d && !d->is_dying )
+        len = dbg_rw_guest_mem(d, gva, buf, len, toaddr, pgd3);
 
     return len;
 }
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index e49f9e91b9..a6aae500a3 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -38,10 +38,10 @@
 #include <asm/cpuid.h>
 
 #ifdef CONFIG_GDBSX
-static int gdbsx_guest_mem_io(domid_t domid, struct xen_domctl_gdbsx_memio *iop)
+static int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop)
 {
     iop->remain = dbg_rw_mem(iop->gva, guest_handle_from_ptr(iop->uva, void),
-                             iop->len, domid, iop->gwr, iop->pgd3val);
+                             iop->len, d, iop->gwr, iop->pgd3val);
 
     return iop->remain ? -EFAULT : 0;
 }
@@ -828,7 +828,7 @@ long arch_do_domctl(
 #ifdef CONFIG_GDBSX
     case XEN_DOMCTL_gdbsx_guestmemio:
         domctl->u.gdbsx_guest_memio.remain = domctl->u.gdbsx_guest_memio.len;
-        ret = gdbsx_guest_mem_io(domctl->domain, &domctl->u.gdbsx_guest_memio);
+        ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
         if ( !ret )
            copyback = true;
         break;
diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/arch/x86/include/asm/debugger.h
index 99803bfd0c..221bcde137 100644
--- a/xen/arch/x86/include/asm/debugger.h
+++ b/xen/arch/x86/include/asm/debugger.h
@@ -94,7 +94,7 @@ static inline bool debugger_trap_entry(
 
 #ifdef CONFIG_GDBSX
 unsigned int dbg_rw_mem(unsigned long gva, XEN_GUEST_HANDLE_PARAM(void) buf,
-                        unsigned int len, domid_t domid, bool toaddr,
+                        unsigned int len, struct domain *d, bool toaddr,
                         uint64_t pgd3);
 #endif
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:07:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:07:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308142.523750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoVj-0007Js-Q5; Tue, 19 Apr 2022 14:07:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308142.523750; Tue, 19 Apr 2022 14:07:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoVj-0007Jl-Kf; Tue, 19 Apr 2022 14:07:19 +0000
Received: by outflank-mailman (input) for mailman id 308142;
 Tue, 19 Apr 2022 13:37:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mE7q=U5=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1ngo2b-0001oN-IH
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 13:37:14 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0611.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::611])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d06f675a-bfe5-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 15:37:11 +0200 (CEST)
Received: from AS9PR06CA0042.eurprd06.prod.outlook.com (2603:10a6:20b:463::27)
 by AM9PR08MB6708.eurprd08.prod.outlook.com (2603:10a6:20b:30e::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 13:37:06 +0000
Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:463:cafe::de) by AS9PR06CA0042.outlook.office365.com
 (2603:10a6:20b:463::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Tue, 19 Apr 2022 13:37:06 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 13:37:05 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Tue, 19 Apr 2022 13:37:05 +0000
Received: from b46786c1c3dd.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 374CF6CA-6CED-4399-B845-00B009A204C6.1; 
 Tue, 19 Apr 2022 13:36:53 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b46786c1c3dd.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Apr 2022 13:36:53 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM0PR08MB5282.eurprd08.prod.outlook.com
 (2603:10a6:208:129::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Tue, 19 Apr
 2022 13:36:49 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::7cce:cf19:817f:57a0%11]) with mapi id 15.20.5164.026; Tue, 19 Apr
 2022 13:36:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d06f675a-bfe5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Bnf9tjioEtVi95BBr9uz8icPnVlahpHkPLvXzsAuXXA=;
 b=5T3dnLMEdXcPLMmOUmrVAjYAgbXXiqEUxrO1hUAIpYL7ajAj30TZ8m9nI6JMcALyvE80n4SyaDT4uz4WXE3T8yEyi/uF7pziDRrkqRqllkk4eyaAAxEcvTgigOqcS5kKcd+gcJABODUhJdd969LINqzEslm2YEo8fqzHPebHbBQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2a5f70344c0e2560
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UKik9FUDU4RMjRg07aikyhrOavfibutm/6BAtNljoSRcJAs0NC2vmWBakOrdzrHlS4AQOTMsiPGwvDjh7EhzYTlIapqVqwcZI8Fc4Cd9++cFrW3dICT37cXU0gyHps2h++ZIlCXv0w73ykvnC4MWqIjZ4RPI9bNwzeKKfCwoE/6Xg9bkItiEBDUU4CNoRo2Ts61sekyHFTV0ulE9KIWyQmmFbOMpgY7C9tsqwHUT5d4jWZC/fGfRlVTpK/OBay4owhIas9Y0UYCk365WrkomARuvsWEfvkT9rm2bpRkkkLR8650jXauSbh5t0QqDD+JOzvVzGUfbkkbyKalvcmbvzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Bnf9tjioEtVi95BBr9uz8icPnVlahpHkPLvXzsAuXXA=;
 b=d3lyquhdKfE0M17xzVSZ60Ff2COawT7c3tPUR49i3Oj7jV//AUxVaE08P8djRxskDDJllySAX/Mn0zMSbN8jaz3tz314M13rPsG9CMcRRnF2dyJWoc7ifOsKdaVnCJhRQvZ4E+dT/gt9jLilGD32nv18z6DjaimWj95v4iZke4cS8d200yFXXYGp7RccmuRBlKlYiOvih6RC65SdquKon/2k+J32e/fvsm2R18WrmZ7JkirBmnTwtfP9CIlbUWvnWb6ZTDbB7gsnd4fiF8INMsAoxbdcPj0D9jbt0j+RWfOj08JEBN2wjU8HnJYPk/NzcLIyxmuk4IoTsLvrkf60RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Bnf9tjioEtVi95BBr9uz8icPnVlahpHkPLvXzsAuXXA=;
 b=5T3dnLMEdXcPLMmOUmrVAjYAgbXXiqEUxrO1hUAIpYL7ajAj30TZ8m9nI6JMcALyvE80n4SyaDT4uz4WXE3T8yEyi/uF7pziDRrkqRqllkk4eyaAAxEcvTgigOqcS5kKcd+gcJABODUhJdd969LINqzEslm2YEo8fqzHPebHbBQ=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Christoph Hellwig <hch@lst.de>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Jan Beulich
	<jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Topic: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Index:
 AQHYTzcUggEUWxM2006iot1qnYxlIKzuW0oAgAFU1ACAADDmgIAApv+AgAC5dQCAAp7ugIACQDIAgAEmAYA=
Date: Tue, 19 Apr 2022 13:36:49 +0000
Message-ID: <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com>
 <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop>
 <8C511888-6183-421E-A4C7-B271DAF46696@arm.com>
 <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de>
 <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
 <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
 <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 16f2d272-cd09-4e06-63d4-08da2209b1bc
x-ms-traffictypediagnostic:
	AM0PR08MB5282:EE_|VE1EUR03FT006:EE_|AM9PR08MB6708:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB670807E730F7E3E5BC11BFE7FCF29@AM9PR08MB6708.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KnEZjRLRw+8jmpzTfS5n+bd5mpods6Z0BvmLTogGFzU2Aj+uYMjfsuvDznhmAXER69wmL7ZKFUIFj096r5Ig/mpa8CrbWP0Wf/ZUv15x/x+YpDlUHRME101cDGwksIc/bQOu2CFsdArYeBpqNfJzwuTCkeI6NG+Y2y2ndgKLwpi/TBQZY0enNbV0lbD5GORZtLS7SZtR/t+88BNb/OEQMjoNLwYLSG+zO7JLG3cHmSFBYRI2MxC+cAED1oYc+szKH/Syllp/dWenHS8D61pJsqyUibHRs7fIFganbp1bItqLAv4mjQt9kfZ20wDmRfjax+E9UzPNPQevABwfcv9J5LR9XA+7wtuclHf/rfTbdBxNo8dXFglLBV7CQF3XDmdvSZ0uzBk9VGyc9nth4D1bLxqccpjUiooCdOQuTirLczpjlVap2PqjcRP6jEXTrCgpHr3w+ZS5XigrQ3p4YrkQzNTify96DTIragpa+NYf+Ys4wc3hxiEf6LeldLG4Gi3rkaQW/s5CzHuKtXtJsVlBYCFNcC6p+C9DvFqEm1qAqF+vPAY5BkOsX99s52X1ZGa4g8LPMJOaSxCwIl6phZSfN796GOH/xWVT2Z4q7yrARKQlUbky9kv8C6UhO9t9xxixIbnob3ydLNdtgKTXiCa4B1zmq5G8hQidwb2wzLKnyAiQXnSNmm+ED4UO9msUHNU/SNJp+fYSVv1gcY0TeLEDk1rSCPTwKpgx2EwuqO+cm2Kupl/EuiAlD7Mp0n1xqRu/
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(71200400001)(64756008)(66556008)(8676002)(66476007)(66446008)(6486002)(99936003)(38100700002)(6506007)(86362001)(8936002)(53546011)(91956017)(76116006)(33656002)(2616005)(4326008)(122000001)(5660300002)(38070700005)(2906002)(6512007)(498600001)(36756003)(83380400001)(26005)(6916009)(54906003)(186003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: multipart/mixed;
	boundary="_005_49E3535A56724047AF8605D5597C7019armcom_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5282
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a4a39565-619d-4282-3157-08da2209a812
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/PdXZafvvU9RT4TeCykA+RgZFQ0OksZI0lQe/wEuKAx+6O+6qW6mbo8BXSmaU9Vi1BVQiE2/bh/+glr8PUPJPAo9SuJvheBbi2aI8BgpJ+zsTA8l1FEwZU16vlGQwFGK5e78imb2HXN5RbV7971AbW5YfB7rfkXW5ulj0u8163Q8JFMnU348p9u0VwvLM5wzazwZ1XlmO6LaINIv82EzywoVEwcqTN1aVc5KWHpCRoFWvAcc/DSRiWqqs2BfrAJ0KwAmfMXx6KTm3oOkbv+uFLuex3jONirF7gmnSmHypTDkYufjuFT6nJcM3kk+ZJh64WUiKCfBeaoPm1j2zTOUoJbXC801Kqan82UyJAEfsV3C3DiIjHstmFYAFfzEtZ0VWbxtwD33w4Mh4gVfWOtFo24xzM5HTMaosPGeJGyDPRheUy72/szGILL5t5bVcqj+istRSNsCsvJAEz9iz3/omt8Vmzcr3LT2ZCoBDB6h0SGh5RWSHGh1yIs/MnPJEXAXwEAHoyztQ623Zv8qOSdYlFLm5yHwF8oCntaURaLuHnRZ/8c38DuhAckJKfEf+Zxs8W/OlFJcjC3TQcVPIfQlIxFkD7j0gHqwaTheHKmcxxpG7po274kRzvrGXgY58ci/3xBCNu9XeYuUWNc5tJ16e84pMpdynjrOA1CqDuENiyQRkKAp8SDKeK2mxaOVPMGU
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6506007)(235185007)(99936003)(81166007)(26005)(53546011)(6512007)(5660300002)(8936002)(316002)(508600001)(6486002)(54906003)(70206006)(70586007)(4326008)(6862004)(86362001)(8676002)(356005)(45080400002)(21480400003)(47076005)(336012)(107886003)(186003)(40460700003)(36860700001)(83380400001)(33656002)(36756003)(2906002)(2616005)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 13:37:05.6747
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 16f2d272-cd09-4e06-63d4-08da2209b1bc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6708

--_005_49E3535A56724047AF8605D5597C7019armcom_
Content-Type: multipart/alternative;
	boundary="_000_49E3535A56724047AF8605D5597C7019armcom_"

--_000_49E3535A56724047AF8605D5597C7019armcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Stefano,

> On 18 Apr 2022, at 9:04 pm, Stefano Stabellini <sstabellini@kernel.org> w=
rote:
>
> On Sun, 17 Apr 2022, Rahul Singh wrote:
>>> On 15 Apr 2022, at 6:40 pm, Stefano Stabellini <sstabellini@kernel.org>=
 wrote:
>>> On Fri, 15 Apr 2022, Christoph Hellwig wrote:
>>>> On Thu, Apr 14, 2022 at 01:39:23PM -0700, Stefano Stabellini wrote:
>>>>> OK, now we know that the code path with Xen is correct and it is the
>>>>> same code path taken (dma_alloc_direct) as when !CONFIG_XEN and !SMMU=
.
>>>>> That is how it should be.
>>>>>
>>>>> I cannot explain why dma_alloc_direct() would fail when called from
>>>>> xen_swiotlb_alloc_coherent(), but it would succeed when called from
>>>>> dma_alloc_attrs() without Xen.
>>>>>
>>>>> I am not aware of any restrictions that xen or swiotlb-xen would
>>>>> introduce in that regard. Unless you are just running out of memory
>>>>> because dom0_mem too low.
>>>>
>>>> The crash is deep down in the page allocator.  Even if memory was low
>>>> it should no crash.  So there is some odd interaction between Xen
>>>> and the page allocator going on.  I think nvme and dma-direct really
>>>> are only the messenger here.
>>>
>>>
>>> I cannot think of anything but if that is the case I guess it is more
>>> likely related to reserved-memory not properly advertised or ACPI table=
s
>>> not properly populated.
>>
>> I am not sure if it is true as we are able to boot with the same reserve=
d memory or
>> the same ACPI table populated if we boot without swiotlb-xen dma ops.
>>
>>>
>>>
>>> Rahul,
>>>
>>> What happens if you boot Linux on Xen with swiotlb-xen disabled?
>>
>> Linux boots fine without any issue if we disable swiotlb-xen as mentione=
d below.
>
> The plot thinkens.
>
> Without swiotlb-xen, Linux boots fine. With swiotlb-xen it crashes.
> However, in both cases, the very same memory allocation function is
> used: dma_direct_alloc. In one case it works, in the other case it
> crashes.  Everything else is the same.
>
> There are a couple of questionable things with dma masks in
> xen_swiotlb_alloc_coherent, but they are *after* the call to
> xen_alloc_coherent_pages, which is the one that crashes. So they cannot
> be the cause of the crash.
>
> Before the call to xen_alloc_coherent_pages, there is only:
>
>  1) flags &=3D ~(__GFP_DMA | __GFP_HIGHMEM);
>  2) size =3D 1UL << (order + XEN_PAGE_SHIFT);
>
>
> 1) is already done by dma_alloc_attrs, so it is superfluous. I couldn't
> explain how 2) could possibly trigger the crash.  XEN_PAGE_SHIFT is
> always 12 even on 64K pages kernels. You can try removing 2) from
> xen_swiotlb_alloc_coherent, but we are really wandering in the dark
> here.

I tried removing the 2) but after that also issue remains.

>
> Then there is xen_swiotlb_init() which allocates some memory for
> swiotlb-xen at boot. It could lower the total amount of memory
> available, but if you disabled swiotlb-xen like I suggested,
> xen_swiotlb_init() still should get called and executed anyway at boot
> (it is called from arch/arm/xen/mm.c:xen_mm_init). So xen_swiotlb_init()
> shouldn't be the one causing problems.
>
> That's it -- there is nothing else in swiotlb-xen that I can think of.
>
> I don't have any good ideas, so I would only suggest to add more printks
> and report the results, for instance:

As suggested I added the more printks but only difference I see is the size=
 apart
from that everything looks same .

Please find the attached logs for xen and native linux boot.



Regards
Rahul

--_000_49E3535A56724047AF8605D5597C7019armcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <FE684E3D3EECEE4AA405ED94BA069220@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText">Hi Stefano,<br>
<br>
&gt; On 18 Apr 2022, at 9:04 pm, Stefano Stabellini &lt;sstabellini@kernel.=
org&gt; wrote:<br>
&gt; <br>
&gt; On Sun, 17 Apr 2022, Rahul Singh wrote:<br>
&gt;&gt;&gt; On 15 Apr 2022, at 6:40 pm, Stefano Stabellini &lt;sstabellini=
@kernel.org&gt; wrote:<br>
&gt;&gt;&gt; On Fri, 15 Apr 2022, Christoph Hellwig wrote:<br>
&gt;&gt;&gt;&gt; On Thu, Apr 14, 2022 at 01:39:23PM -0700, Stefano Stabelli=
ni wrote:<br>
&gt;&gt;&gt;&gt;&gt; OK, now we know that the code path with Xen is correct=
 and it is the<br>
&gt;&gt;&gt;&gt;&gt; same code path taken (dma_alloc_direct) as when !CONFI=
G_XEN and !SMMU.<br>
&gt;&gt;&gt;&gt;&gt; That is how it should be.<br>
&gt;&gt;&gt;&gt;&gt; <br>
&gt;&gt;&gt;&gt;&gt; I cannot explain why dma_alloc_direct() would fail whe=
n called from<br>
&gt;&gt;&gt;&gt;&gt; xen_swiotlb_alloc_coherent(), but it would succeed whe=
n called from<br>
&gt;&gt;&gt;&gt;&gt; dma_alloc_attrs() without Xen.<br>
&gt;&gt;&gt;&gt;&gt; <br>
&gt;&gt;&gt;&gt;&gt; I am not aware of any restrictions that xen or swiotlb=
-xen would<br>
&gt;&gt;&gt;&gt;&gt; introduce in that regard. Unless you are just running =
out of memory<br>
&gt;&gt;&gt;&gt;&gt; because dom0_mem too low.<br>
&gt;&gt;&gt;&gt; <br>
&gt;&gt;&gt;&gt; The crash is deep down in the page allocator.&nbsp; Even i=
f memory was low<br>
&gt;&gt;&gt;&gt; it should no crash.&nbsp; So there is some odd interaction=
 between Xen<br>
&gt;&gt;&gt;&gt; and the page allocator going on.&nbsp; I think nvme and dm=
a-direct really<br>
&gt;&gt;&gt;&gt; are only the messenger here.<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; I cannot think of anything but if that is the case I guess it =
is more<br>
&gt;&gt;&gt; likely related to reserved-memory not properly advertised or A=
CPI tables<br>
&gt;&gt;&gt; not properly populated.<br>
&gt;&gt; <br>
&gt;&gt; I am not sure if it is true as we are able to boot with the same r=
eserved memory or<br>
&gt;&gt; the same ACPI table populated if we boot without swiotlb-xen dma o=
ps.<br>
&gt;&gt; <br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; Rahul,<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; What happens if you boot Linux on Xen with swiotlb-xen disable=
d?<br>
&gt;&gt; <br>
&gt;&gt; Linux boots fine without any issue if we disable swiotlb-xen as me=
ntioned below.<br>
&gt; <br>
&gt; The plot thinkens.<br>
&gt; <br>
&gt; Without swiotlb-xen, Linux boots fine. With swiotlb-xen it crashes.<br=
>
&gt; However, in both cases, the very same memory allocation function is<br=
>
&gt; used: dma_direct_alloc. In one case it works, in the other case it<br>
&gt; crashes.&nbsp; Everything else is the same.<br>
&gt; <br>
&gt; There are a couple of questionable things with dma masks in<br>
&gt; xen_swiotlb_alloc_coherent, but they are *after* the call to<br>
&gt; xen_alloc_coherent_pages, which is the one that crashes. So they canno=
t<br>
&gt; be the cause of the crash.<br>
&gt; <br>
&gt; Before the call to xen_alloc_coherent_pages, there is only:<br>
&gt; <br>
&gt;&nbsp; 1) flags &amp;=3D ~(__GFP_DMA | __GFP_HIGHMEM);<br>
&gt;&nbsp; 2) size =3D 1UL &lt;&lt; (order + XEN_PAGE_SHIFT);<br>
&gt; <br>
&gt; <br>
&gt; 1) is already done by dma_alloc_attrs, so it is superfluous. I couldn'=
t<br>
&gt; explain how 2) could possibly trigger the crash.&nbsp; XEN_PAGE_SHIFT =
is<br>
&gt; always 12 even on 64K pages kernels. You can try removing 2) from<br>
&gt; xen_swiotlb_alloc_coherent, but we are really wandering in the dark<br=
>
&gt; here.<br>
<br>
I tried removing the 2) but after that also issue remains.<br>
<br>
&gt; <br>
&gt; Then there is xen_swiotlb_init() which allocates some memory for<br>
&gt; swiotlb-xen at boot. It could lower the total amount of memory<br>
&gt; available, but if you disabled swiotlb-xen like I suggested,<br>
&gt; xen_swiotlb_init() still should get called and executed anyway at boot=
<br>
&gt; (it is called from arch/arm/xen/mm.c:xen_mm_init). So xen_swiotlb_init=
()<br>
&gt; shouldn't be the one causing problems.<br>
&gt; <br>
&gt; That's it -- there is nothing else in swiotlb-xen that I can think of.=
<br>
&gt; <br>
&gt; I don't have any good ideas, so I would only suggest to add more print=
ks<br>
&gt; and report the results, for instance:<br>
<br>
As suggested I added the more printks but only difference I see is the size=
 apart<br>
from that everything looks same .<br>
<br>
Please find the attached logs for xen and native linux boot. <br>
<br>
</div>
</span></font></div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText"><br>
<br>
Regards<br>
Rahul</div>
</span></font></div>
</body>
</html>

--_000_49E3535A56724047AF8605D5597C7019armcom_--

--_005_49E3535A56724047AF8605D5597C7019armcom_
Content-Type: application/octet-stream; name="xen_boot_with_debug.log"
Content-Description: xen_boot_with_debug.log
Content-Disposition: attachment; filename="xen_boot_with_debug.log";
	size=163040; creation-date="Tue, 19 Apr 2022 13:36:49 GMT";
	modification-date="Tue, 19 Apr 2022 13:36:49 GMT"
Content-ID: <BD56D7AB2876E648AEC237A97D2567B7@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogVHVlIEFwciAxOSAxMTo1Mzo0NSBvbiB0dHlzMDAxDQpyYWhzaW4wMUBDMDJa
WDBHOUxWRE4gfiAlIHRlbG5ldCBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29tIDEwMDIwDQpUcnlp
bmcgMTAuMS4xOTQuMjUuLi4NCkNvbm5lY3RlZCB0byBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29t
Lg0KRXNjYXBlIGNoYXJhY3RlciBpcyAnXl0nLg0KDQpBSVMgdGFyZ2V0IHN5c3RlbSBwb3J0IDEw
MDIwIGRldmljZSAvZGV2L3R0eVVTQjEgWzExNTIwMCBOODFdDQoNCg0KRlMwOlw+IA0KRlMwOlw+
IHhlbi5lZmkNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0K
DQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KWGVuIDQuMTUuMSAoYy9zIEZy
aSBTZXAgMTAgMDk6MDM6MjQgMjAyMSArMDIwMCBnaXQ6ODRmYTk5MDk5Yi1kaXJ0eSkgRUZJIGxv
YWRlcg0KVXNpbmcgY29uZmlndXJhdGlvbiBmaWxlICd4ZW4uY2ZnJw0KSW1hZ2UteGVuOiAweDAw
MDAwMDAwZmU0N2MwMDAtMHgwMDAwMDAwMGZmYjNmMjAwDQpQUk9HUkVTUyBDT0RFOiBWMDMxMDEw
MTkgSTANCiBYZW4gNC4xNS4xDQooWEVOKSBYZW4gdmVyc2lvbiA0LjE1LjEgKHhlbi00LjE1K3N0
YWJsZUFVVE9JTkMrODRmYTk5MDk5Yi1yMEBld2FvbCkgKGFhcmNoNjQtcG9reS1saW51eC1nY2Mg
KEdDQykgMTEuMi4wKSBkZWJ1Zz1uIDIwMjEtMDktMTANCihYRU4pIExhdGVzdCBDaGFuZ2VTZXQ6
IEZyaSBTZXAgMTAgMDk6MDM6MjQgMjAyMSArMDIwMCBnaXQ6ODRmYTk5MDk5Yi1kaXJ0eQ0KKFhF
TikgYnVpbGQtaWQ6IDc4MzQ0OGMzOGFhNmZmNDY1ZTZiNDYzMTg1M2JjNzMwNzZiY2Y3ZTQNCihY
RU4pIFByb2Nlc3NvcjogNDEzZmQwYzE6ICJBUk0gTGltaXRlZCIsIHZhcmlhbnQ6IDB4MywgcGFy
dCAweGQwYywgcmV2IDB4MQ0KKFhFTikgNjQtYml0IEV4ZWN1dGlvbjoNCihYRU4pICAgUHJvY2Vz
c29yIEZlYXR1cmVzOiAxMTAwMDAwMDExMTExMTEyIDAwMDAwMDAwMDAwMDAwMjANCihYRU4pICAg
ICBFeGNlcHRpb24gTGV2ZWxzOiBFTDM6NjQgRUwyOjY0IEVMMTo2NCBFTDA6NjQrMzINCihYRU4p
ICAgICBFeHRlbnNpb25zOiBGbG9hdGluZ1BvaW50IEFkdmFuY2VkU0lNRCBHSUN2My1TeXNSZWcN
CihYRU4pICAgRGVidWcgRmVhdHVyZXM6IDAwMDAwMDAxMTAzMDU0MDggMDAwMDAwMDAwMDAwMDAw
MA0KKFhFTikgICBBdXhpbGlhcnkgRmVhdHVyZXM6IDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAw
MDAwMDAwMA0KKFhFTikgICBNZW1vcnkgTW9kZWwgRmVhdHVyZXM6IDAwMDAwMDAwMDAxMDExMjUg
MDAwMDAwMDAxMDIxMjEyMg0KKFhFTikgICBJU0EgRmVhdHVyZXM6ICAwMDAwMTAwMDEwMjExMTIw
IDAwMDAwMDAwMDAxMDAwMDENCihYRU4pIDMyLWJpdCBFeGVjdXRpb246DQooWEVOKSAgIFByb2Nl
c3NvciBGZWF0dXJlczogMTAwMTAxMzE6MTAwMTAwMDANCihYRU4pICAgICBJbnN0cnVjdGlvbiBT
ZXRzOiBBQXJjaDMyIEEzMiBUaHVtYiBUaHVtYi0yIEphemVsbGUNCihYRU4pICAgICBFeHRlbnNp
b25zOiBHZW5lcmljVGltZXINCihYRU4pICAgRGVidWcgRmVhdHVyZXM6IDA0MDEwMDg4DQooWEVO
KSAgIEF1eGlsaWFyeSBGZWF0dXJlczogMDAwMDAwMDANCihYRU4pICAgTWVtb3J5IE1vZGVsIEZl
YXR1cmVzOiAxMDIwMTEwNSA0MDAwMDAwMCAwMTI2MDAwMCAwMjEyMjIxMQ0KKFhFTikgIElTQSBG
ZWF0dXJlczogMDIxMDExMTAgMTMxMTIxMTEgMjEyMzIwNDIgMDExMTIxMzEgMDAwMTAxNDIgMDEw
MTExMjENCihYRU4pIFVzaW5nIFNNQyBDYWxsaW5nIENvbnZlbnRpb24gdjEuMg0KKFhFTikgVXNp
bmcgUFNDSSB2MS4xDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTAwMF0gYWRkcmVzc1sw
eDBdIE1QSURSWzB4MTAwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsw
eDE4MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDE4MDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6
IEdJQ0MgKGFjcGlfaWRbMHgxNjAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxNjAwMDBdIGVuYWJs
ZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MWUwMF0gYWRkcmVzc1sweDBdIE1QSURS
WzB4MWUwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDA4MDBdIGFk
ZHJlc3NbMHgwXSBNUElEUlsweDgwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNw
aV9pZFsweDIwMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDIwMDAwMF0gZW5hYmxlZCkNCihYRU4p
IEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgwZTAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHhlMDAwMF0g
ZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgyNjAwXSBhZGRyZXNzWzB4MF0g
TVBJRFJbMHgyNjAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTEw
MF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTEwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lD
QyAoYWNwaV9pZFsweDE5MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDE5MDAwMF0gZW5hYmxlZCkN
CihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxNzAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgx
NzAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MWYwMF0gYWRkcmVz
c1sweDBdIE1QSURSWzB4MWYwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9p
ZFsweDA5MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDkwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQ
STogR0lDQyAoYWNwaV9pZFsweDIxMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDIxMDAwMF0gZW5h
YmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgwZjAwXSBhZGRyZXNzWzB4MF0gTVBJ
RFJbMHhmMDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgyNzAwXSBh
ZGRyZXNzWzB4MF0gTVBJRFJbMHgyNzAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChh
Y3BpX2lkWzB4MTAwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTAwMTAwXSBlbmFibGVkKQ0KKFhF
TikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDE4MDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDE4MDEw
MF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxNjAxXSBhZGRyZXNzWzB4
MF0gTVBJRFJbMHgxNjAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4
MWUwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MWUwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTog
R0lDQyAoYWNwaV9pZFsweDA4MDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDgwMTAwXSBlbmFibGVk
KQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDIwMDFdIGFkZHJlc3NbMHgwXSBNUElEUlsw
eDIwMDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgwZTAxXSBhZGRy
ZXNzWzB4MF0gTVBJRFJbMHhlMDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlf
aWRbMHgyNjAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgyNjAxMDBdIGVuYWJsZWQpDQooWEVOKSBB
Q1BJOiBHSUNDIChhY3BpX2lkWzB4MTEwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTEwMTAwXSBl
bmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDE5MDFdIGFkZHJlc3NbMHgwXSBN
UElEUlsweDE5MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxNzAx
XSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxNzAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUND
IChhY3BpX2lkWzB4MWYwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MWYwMTAwXSBlbmFibGVkKQ0K
KFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDA5MDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDkw
MTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDIxMDFdIGFkZHJlc3Nb
MHgwXSBNUElEUlsweDIxMDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRb
MHgwZjAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHhmMDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6
IEdJQ0MgKGFjcGlfaWRbMHgyNzAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgyNzAxMDBdIGVuYWJs
ZWQpDQooWEVOKSAzMiBDUFVzIGVuYWJsZWQsIDMyIENQVXMgdG90YWwNCihYRU4pIFNNUDogQWxs
b3dpbmcgMzIgQ1BVcw0KKFhFTikgR2VuZXJpYyBUaW1lciBJUlE6IHBoeXM9MzAgaHlwPTI2IHZp
cnQ9MjcgRnJlcTogMjUwMDAgS0h6DQooWEVOKSBHSUN2MyBpbml0aWFsaXphdGlvbjoNCihYRU4p
ICAgICAgIGdpY19kaXN0X2FkZHI9MHgwMDEwMDEwMDAwMDAwMA0KKFhFTikgICAgICAgZ2ljX21h
aW50ZW5hbmNlX2lycT0yNQ0KKFhFTikgICAgICAgZ2ljX3JkaXN0X3N0cmlkZT0wDQooWEVOKSAg
ICAgICBnaWNfcmRpc3RfcmVnaW9ucz0xDQooWEVOKSAgICAgICByZWRpc3RyaWJ1dG9yIHJlZ2lv
bnM6DQooWEVOKSAgICAgICAgIC0gcmVnaW9uIDA6IDB4MDAxMDAxMDAxNDAwMDAgLSAweDAwMTAw
MTAxMTQwMDAwDQooWEVOKSBHSUN2MzogdXNpbmcgYXQgbW9zdCA1NzM0NCBMUElzIG9uIHRoZSBo
b3N0Lg0KKFhFTikgR0lDdjM6IDcwNCBsaW5lcywgKElJRCAwMjAxNzQzYikuDQooWEVOKSBHSUN2
MzogRm91bmQgSVRTIEAweDEwMDEwMDA0MDAwMA0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBAMHgx
MDAxMDAwNjAwMDANCihYRU4pIEdJQ3YzOiBGb3VuZCBJVFMgQDB4MTAwMTAwMDgwMDAwDQooWEVO
KSBHSUN2MzogRm91bmQgSVRTIEAweDEwMDEwMDBhMDAwMA0KKFhFTikgR0lDdjM6IEZvdW5kIElU
UyBAMHgxMDAxMDAwYzAwMDANCihYRU4pIEdJQ3YzOiBGb3VuZCBJVFMgQDB4MTAwMTAwMGUwMDAw
DQooWEVOKSBHSUN2MzogRm91bmQgSVRTIEAweDEwMDEwMDEwMDAwMA0KKFhFTikgR0lDdjM6IEZv
dW5kIElUUyBAMHgxMDAxMDAxMjAwMDANCihYRU4pIEdJQ3YzOiBDUFUwOiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNDM0MDAwDQooWEVOKSBYU00gRnJhbWV3b3Jr
IHYxLjAuMCBpbml0aWFsaXplZA0KKFhFTikgSW5pdGlhbGlzaW5nIFhTTSBTSUxPIG1vZGUNCihY
RU4pIFVzaW5nIHNjaGVkdWxlcjogU01QIENyZWRpdCBTY2hlZHVsZXIgcmV2MiAoY3JlZGl0MikN
CihYRU4pIEluaXRpYWxpemluZyBDcmVkaXQyIHNjaGVkdWxlcg0KKFhFTikgIGxvYWRfcHJlY2lz
aW9uX3NoaWZ0OiAxOA0KKFhFTikgIGxvYWRfd2luZG93X3NoaWZ0OiAzMA0KKFhFTikgIHVuZGVy
bG9hZF9iYWxhbmNlX3RvbGVyYW5jZTogMA0KKFhFTikgIG92ZXJsb2FkX2JhbGFuY2VfdG9sZXJh
bmNlOiAtMw0KKFhFTikgIHJ1bnF1ZXVlcyBhcnJhbmdlbWVudDogc29ja2V0DQooWEVOKSAgY2Fw
IGVuZm9yY2VtZW50IGdyYW51bGFyaXR5OiAxMG1zDQooWEVOKSBsb2FkIHRyYWNraW5nIHdpbmRv
dyBsZW5ndGggMTA3Mzc0MTgyNCBucw0KKFhFTikgRGVmYXVsdGluZyB0byBhbHRlcm5hdGl2ZSBr
ZXkgaGFuZGxpbmc7IHNlbmQgJ0EnIHRvIHN3aXRjaCB0byBub3JtYWwgbW9kZS4NCihYRU4pIEFs
bG9jYXRlZCBjb25zb2xlIHJpbmcgb2YgMjU2IEtpQi4NCihYRU4pIENQVTA6IEd1ZXN0IGF0b21p
Y3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQnJp
bmdpbmcgdXAgQ1BVMQ0KKFhFTikgR0lDdjM6IENQVTE6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4g
cmVnaW9uIDAgQDAwMDAwMDAwNDA2MzQwMDANCihYRU4pIENQVTE6IEd1ZXN0IGF0b21pY3Mgd2ls
bCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDEgYm9v
dGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMg0KKFhFTikgR0lDdjM6IENQVTI6IEZvdW5kIHJl
ZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA1YjQwMDANCihYRU4pIENQVTI6IEd1
ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0K
KFhFTikgQ1BVIDIgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMw0KKFhFTikgR0lDdjM6
IENQVTM6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA3YjQwMDAN
CihYRU4pIENQVTM6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNp
bmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDMgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BV
NA0KKFhFTikgR0lDdjM6IENQVTQ6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAw
MDAwMDAwNDAyMzQwMDANCihYRU4pIENQVTQ6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGlt
ZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDQgYm9vdGVkLg0KKFhFTikg
QnJpbmdpbmcgdXAgQ1BVNQ0KKFhFTikgR0lDdjM6IENQVTU6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA4MzQwMDANCihYRU4pIENQVTU6IEd1ZXN0IGF0b21pY3Mg
d2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDUg
Ym9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVNg0KKFhFTikgR0lDdjM6IENQVTY6IEZvdW5k
IHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDAzYjQwMDANCihYRU4pIENQVTY6
IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFp
bg0KKFhFTikgQ1BVIDYgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVNw0KKFhFTikgR0lD
djM6IENQVTc6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA5YjQw
MDANCihYRU4pIENQVTc6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBh
dXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDcgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAg
Q1BVOA0KKFhFTikgR0lDdjM6IENQVTg6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDA0NzQwMDANCihYRU4pIENQVTg6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTgg
dGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDggYm9vdGVkLg0KKFhF
TikgQnJpbmdpbmcgdXAgQ1BVOQ0KKFhFTikgR0lDdjM6IENQVTk6IEZvdW5kIHJlZGlzdHJpYnV0
b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA2NzQwMDANCihYRU4pIENQVTk6IEd1ZXN0IGF0b21p
Y3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BV
IDkgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTANCihYRU4pIEdJQ3YzOiBDUFUxMDog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDVmNDAwMA0KKFhFTikg
Q1BVMTA6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl
IGRvbWFpbg0KKFhFTikgQ1BVIDEwIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTExDQoo
WEVOKSBHSUN2MzogQ1BVMTE6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAw
MDAwNDA3ZjQwMDANCihYRU4pIENQVTExOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxMSBib290ZWQuDQooWEVOKSBC
cmluZ2luZyB1cCBDUFUxMg0KKFhFTikgR0lDdjM6IENQVTEyOiBGb3VuZCByZWRpc3RyaWJ1dG9y
IGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwMjc0MDAwDQooWEVOKSBDUFUxMjogR3Vlc3QgYXRvbWlj
cyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg
MTIgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTMNCihYRU4pIEdJQ3YzOiBDUFUxMzog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDg3NDAwMA0KKFhFTikg
Q1BVMTM6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTcgdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl
IGRvbWFpbg0KKFhFTikgQ1BVIDEzIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTE0DQoo
WEVOKSBHSUN2MzogQ1BVMTQ6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAw
MDAwNDAzZjQwMDANCihYRU4pIENQVTE0OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxNCBib290ZWQuDQooWEVOKSBC
cmluZ2luZyB1cCBDUFUxNQ0KKFhFTikgR0lDdjM6IENQVTE1OiBGb3VuZCByZWRpc3RyaWJ1dG9y
IGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwOWY0MDAwDQooWEVOKSBDUFUxNTogR3Vlc3QgYXRvbWlj
cyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg
MTUgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTYNCihYRU4pIEdJQ3YzOiBDUFUxNjog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDQ1NDAwMA0KKFhFTikg
Q1BVMTY6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl
IGRvbWFpbg0KKFhFTikgQ1BVIDE2IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTE3DQoo
WEVOKSBHSUN2MzogQ1BVMTc6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAw
MDAwNDA2NTQwMDANCihYRU4pIENQVTE3OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxNyBib290ZWQuDQooWEVOKSBC
cmluZ2luZyB1cCBDUFUxOA0KKFhFTikgR0lDdjM6IENQVTE4OiBGb3VuZCByZWRpc3RyaWJ1dG9y
IGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNWQ0MDAwDQooWEVOKSBDUFUxODogR3Vlc3QgYXRvbWlj
cyB3aWxsIHRyeSAxNyB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg
MTggYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTkNCihYRU4pIEdJQ3YzOiBDUFUxOTog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDdkNDAwMA0KKFhFTikg
Q1BVMTk6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTcgdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl
IGRvbWFpbg0KKFhFTikgQ1BVIDE5IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTIwDQoo
WEVOKSBHSUN2MzogQ1BVMjA6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAw
MDAwNDAyNTQwMDANCihYRU4pIENQVTIwOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyMCBib290ZWQuDQooWEVOKSBC
cmluZ2luZyB1cCBDUFUyMQ0KKFhFTikgR0lDdjM6IENQVTIxOiBGb3VuZCByZWRpc3RyaWJ1dG9y
IGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwODU0MDAwDQooWEVOKSBDUFUyMTogR3Vlc3QgYXRvbWlj
cyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg
MjEgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjINCihYRU4pIEdJQ3YzOiBDUFUyMjog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDNkNDAwMA0KKFhFTikg
Q1BVMjI6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl
IGRvbWFpbg0KKFhFTikgQ1BVIDIyIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTIzDQoo
WEVOKSBHSUN2MzogQ1BVMjM6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAw
MDAwNDA5ZDQwMDANCihYRU4pIENQVTIzOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyMyBib290ZWQuDQooWEVOKSBC
cmluZ2luZyB1cCBDUFUyNA0KKFhFTikgR0lDdjM6IENQVTI0OiBGb3VuZCByZWRpc3RyaWJ1dG9y
IGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNDk0MDAwDQooWEVOKSBDUFUyNDogR3Vlc3QgYXRvbWlj
cyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg
MjQgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjUNCihYRU4pIEdJQ3YzOiBDUFUyNTog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDY5NDAwMA0KKFhFTikg
Q1BVMjU6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl
IGRvbWFpbg0KKFhFTikgQ1BVIDI1IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTI2DQoo
WEVOKSBHSUN2MzogQ1BVMjY6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAw
MDAwNDA2MTQwMDANCihYRU4pIENQVTI2OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyNiBib290ZWQuDQooWEVOKSBC
cmluZ2luZyB1cCBDUFUyNw0KKFhFTikgR0lDdjM6IENQVTI3OiBGb3VuZCByZWRpc3RyaWJ1dG9y
IGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwODE0MDAwDQooWEVOKSBDUFUyNzogR3Vlc3QgYXRvbWlj
cyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg
MjcgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjgNCihYRU4pIEdJQ3YzOiBDUFUyODog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDI5NDAwMA0KKFhFTikg
Q1BVMjg6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl
IGRvbWFpbg0KKFhFTikgQ1BVIDI4IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTI5DQoo
WEVOKSBHSUN2MzogQ1BVMjk6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAw
MDAwNDA4OTQwMDANCihYRU4pIENQVTI5OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyOSBib290ZWQuDQooWEVOKSBC
cmluZ2luZyB1cCBDUFUzMA0KKFhFTikgR0lDdjM6IENQVTMwOiBGb3VuZCByZWRpc3RyaWJ1dG9y
IGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNDE0MDAwDQooWEVOKSBDUFUzMDogR3Vlc3QgYXRvbWlj
cyB3aWxsIHRyeSAxNyB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg
MzAgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMzENCihYRU4pIEdJQ3YzOiBDUFUzMTog
Rm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MGExNDAwMA0KKFhFTikg
Q1BVMzE6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl
IGRvbWFpbg0KKFhFTikgQnJvdWdodCB1cCAzMiBDUFVzDQooWEVOKSBDUFUgMzEgYm9vdGVkLg0K
KFhFTikgSS9PIHZpcnR1YWxpc2F0aW9uIGRpc2FibGVkDQooWEVOKSBQMk06IDQ4LWJpdCBJUEEg
d2l0aCA0OC1iaXQgUEEgYW5kIDE2LWJpdCBWTUlEDQooWEVOKSBQMk06IDQgbGV2ZWxzIHdpdGgg
b3JkZXItMCByb290LCBWVENSIDB4ODAwZDM1OTANCihYRU4pIFNjaGVkdWxpbmcgZ3JhbnVsYXJp
dHk6IGNwdSwgMSBDUFUgcGVyIHNjaGVkLXJlc291cmNlDQooWEVOKSBBZGRpbmcgY3B1IDAgdG8g
cnVucXVldWUgMA0KKFhFTikgIEZpcnN0IGNwdSBvbiBydW5xdWV1ZSwgYWN0aXZhdGluZw0KKFhF
TikgQWRkaW5nIGNwdSAxIHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMiB0byBydW5x
dWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDMgdG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNw
dSA0IHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgNSB0byBydW5xdWV1ZSAwDQooWEVO
KSBBZGRpbmcgY3B1IDYgdG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSA3IHRvIHJ1bnF1
ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgOCB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1
IDkgdG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSAxMCB0byBydW5xdWV1ZSAwDQooWEVO
KSBBZGRpbmcgY3B1IDExIHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMTIgdG8gcnVu
cXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSAxMyB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcg
Y3B1IDE0IHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMTUgdG8gcnVucXVldWUgMA0K
KFhFTikgQWRkaW5nIGNwdSAxNiB0byBydW5xdWV1ZSAxDQooWEVOKSAgRmlyc3QgY3B1IG9uIHJ1
bnF1ZXVlLCBhY3RpdmF0aW5nDQooWEVOKSBBZGRpbmcgY3B1IDE3IHRvIHJ1bnF1ZXVlIDENCihY
RU4pIEFkZGluZyBjcHUgMTggdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAxOSB0byBy
dW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDIwIHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGlu
ZyBjcHUgMjEgdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyMiB0byBydW5xdWV1ZSAx
DQooWEVOKSBBZGRpbmcgY3B1IDIzIHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjQg
dG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyNSB0byBydW5xdWV1ZSAxDQooWEVOKSBB
ZGRpbmcgY3B1IDI2IHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjcgdG8gcnVucXVl
dWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyOCB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcgY3B1
IDI5IHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMzAgdG8gcnVucXVldWUgMQ0KKFhF
TikgQWRkaW5nIGNwdSAzMSB0byBydW5xdWV1ZSAxDQooWEVOKSBhbHRlcm5hdGl2ZXM6IFBhdGNo
aW5nIHdpdGggYWx0IHRhYmxlIDAwMDAwMDAwMDAyY2QwYjAgLT4gMDAwMDAwMDAwMDJjZDllMA0K
KFhFTikgKioqIExPQURJTkcgRE9NQUlOIDAgKioqDQooWEVOKSBMb2FkaW5nIGQwIGtlcm5lbCBm
cm9tIGJvb3QgbW9kdWxlIEAgMDAwMDAwMDBmZTQ3YzAwMA0KKFhFTikgQWxsb2NhdGluZyAxOjEg
bWFwcGluZ3MgdG90YWxsaW5nIDgxOTJNQiBmb3IgZG9tMDoNCihYRU4pIEJBTktbMF0gMHgwMDAw
MDA5ODAwMDAwMC0weDAwMDAwMGY4MDAwMDAwICgxNTM2TUIpDQooWEVOKSBCQU5LWzFdIDB4MDAw
ODAwMDAwMDAwMDAtMHgwMDA4MDA4MDAwMDAwMCAoMjA0OE1CKQ0KKFhFTikgQkFOS1syXSAweDAw
MDgwNjgwMDAwMDAwLTB4MDAwODA3YTAwMDAwMDAgKDQ2MDhNQikNCihYRU4pIEdyYW50IHRhYmxl
IHJhbmdlOiAweDAwMDgwN2Y2NmNmMDAwLTB4MDAwODA3ZjY3MGYwMDANCihYRU4pIEFsbG9jYXRp
bmcgUFBJIDE2IGZvciBldmVudCBjaGFubmVsIGludGVycnVwdA0KKFhFTikgTG9hZGluZyB6SW1h
Z2UgZnJvbSAwMDAwMDAwMGZlNDdjMDAwIHRvIDAwMDAwMDAwOTgwMDAwMDAtMDAwMDAwMDA5OTZj
MzIwMA0KKFhFTikgTG9hZGluZyBkMCBEVEIgdG8gMHgwMDAwMDAwMGEwMDAwMDAwLTB4MDAwMDAw
MDBhMDAwMDI3Zg0KKFhFTikgSW5pdGlhbCBsb3cgbWVtb3J5IHZpcnEgdGhyZXNob2xkIHNldCBh
dCAweDQwMDAgcGFnZXMuDQooWEVOKSBTdGQuIExvZ2xldmVsOiBBbGwNCihYRU4pIEd1ZXN0IExv
Z2xldmVsOiBFcnJvcnMNCihYRU4pICoqKiBTZXJpYWwgaW5wdXQgdG8gRE9NMCAodHlwZSAnQ1RS
TC1hJyB0aHJlZSB0aW1lcyB0byBzd2l0Y2ggaW5wdXQpDQooWEVOKSBGcmVlZCAzNjBrQiBpbml0
IG1lbW9yeS4NCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAw
MGZmZmZmZmZmIHRvIElDQUNUSVZFUjQNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29y
ZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjgNCihYRU4pIGQwdjA6IHZHSUNE
OiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjEyDQoo
WEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0
byBJQ0FDVElWRVIxNg0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4
MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMjANCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRs
ZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjI0DQooWEVOKSBkMHYw
OiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElW
RVIyOA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZm
ZmZmZmYgdG8gSUNBQ1RJVkVSMzINCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3
cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjM2DQooWEVOKSBkMHYwOiB2R0lDRDog
dW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0MA0KKFhF
TikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8g
SUNBQ1RJVkVSNDQNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAw
MDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjQ4DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVk
IHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI1Mg0KKFhFTikgZDB2MDog
dkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVS
NTYNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZm
ZmZmIHRvIElDQUNUSVZFUjYwDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3Jp
dGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI2NA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVu
aGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNjgNCihYRU4p
IGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElD
QUNUSVZFUjcyDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAw
MDBmZmZmZmZmZiB0byBJQ0FDVElWRVI3Ng0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3
b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSODANCihYRU4pIGQwdjA6IHZH
SUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjg0
DQooWEVOKSBkMHYwOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZm
ZmZmZmZmIHRvIElDQUNUSVZFUjANClsgICAgMC4wMDAwMDBdIEJvb3RpbmcgTGludXggb24gcGh5
c2ljYWwgQ1BVIDB4MDAwMDAwMDAwMCBbMHg0MTNmZDBjMV0NClsgICAgMC4wMDAwMDBdIExpbnV4
IHZlcnNpb24gNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAob2UtdXNlckBvZS1ob3N0KSAo
YWFyY2g2NC1wb2t5LWxpbnV4LWdjYyAoR0NDKSAxMS4yLjAsIEdOVSBsZCAoR05VIEJpbnV0aWxz
KSAyLjM3LjIwMjEwNzIxKSAjMSBTTVAgUFJFRU1QVCBTYXQgU2VwIDE4IDA2OjAxOjU5IFVUQyAy
MDIxDQpbICAgIDAuMDAwMDAwXSBYZW4gWEVOX1ZFUlNJT04uWEVOX1NVQlZFUlNJT04gc3VwcG9y
dCBmb3VuZA0KWyAgICAwLjAwMDAwMF0gZWZpOiBFRkkgdjIuNTAgYnkgWGVuDQpbICAgIDAuMDAw
MDAwXSBlZmk6IEFDUEkgMi4wPTB4ODA3ZjY2Y2ZjZTggDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBF
YXJseSB0YWJsZSBjaGVja3N1bSB2ZXJpZmljYXRpb24gZGlzYWJsZWQNClsgICAgMC4wMDAwMDBd
IEFDUEk6IFJTRFAgMHgwMDAwMDgwN0Y2NkNGQ0U4IDAwMDAyNCAodjAyIEFtcGVyZSkNClsgICAg
MC4wMDAwMDBdIEFDUEk6IFhTRFQgMHgwMDAwMDgwN0Y2NkNGQzM4IDAwMDBBQyAodjAxIEFtcGVy
ZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTog
RkFDUCAweDAwMDAwODA3RjY2Q0YwMDAgMDAwMTE0ICh2MDYgQW1wZXJlIEFsdHJhICAgIDAwMDAw
MDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBEU0RUIDB4MDAwMDA4MDdG
OERCMDAxOCAwMkMxOUUgKHYwMiBBbXBlcmUgSmFkZSAgICAgMDAwMDAwMDEgSU5UTCAyMDIwMTIx
NykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEJFUlQgMHgwMDAwMDgwN0ZBMERGRjk4IDAwMDAzMCAo
djAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAw
MF0gQUNQSTogREJHMiAweDAwMDAwODA3RkEwREZBOTggMDAwMDVDICh2MDAgQW1wZXJlIEFsdHJh
ICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBHVERUIDB4
MDAwMDA4MDdGQTBERTk5OCAwMDAxMTAgKHYwMyBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1Q
LiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1IgMHgwMDAwMDgwN0ZBMERGRTE4
IDAwMDA1MCAodjAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAg
ICAwLjAwMDAwMF0gQUNQSTogRUlOSiAweDAwMDAwODA3RkEwREY1OTggMDAwMTUwICh2MDEgQW1w
ZXJlIEFsdHJhICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQpbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBIRVNUIDB4MDAwMDA4MDdGQTBERUIxOCAwMDAxRjQgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAw
MDAwMDEgSU5UTCAyMDIwMTIxNykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFNTRFQgMHgwMDAwMDgw
N0ZBMERGQTE4IDAwMDAyRCAodjAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAx
MjE3KQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogVFBNMiAweDAwMDAwODA3RkEwREZEMTggMDAwMDRD
ICh2MDQgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAw
MDAwXSBBQ1BJOiBNQ0ZHIDB4MDAwMDA4MDdGQTBERjcxOCAwMDAwN0MgKHYwMSBBbXBlcmUgQWx0
cmEgICAgMDAwMDAwMDEgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IElPUlQg
MHgwMDAwMDgwN0ZBMERFRjE4IDAwMDNEQyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBB
TVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogQVBJQyAweDAwMDAwODA3RjY2Q0Yx
MTggMDAwQUY0ICh2MDUgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpb
ICAgIDAuMDAwMDAwXSBBQ1BJOiBQUFRUIDB4MDAwMDA4MDdGQTBEODYxOCAwMDQ1MjAgKHYwMiBB
bXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFD
UEk6IFNMSVQgMHgwMDAwMDgwN0ZBMERGRDk4IDAwMDAyRCAodjAxIEFtcGVyZSBBbHRyYSAgICAw
MDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVCAweDAwMDAw
ODA3RkEwRENFMTggMDAwMzcwICh2MDMgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEw
MDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBQQ0NUIDB4MDAwMDA4MDdGQTBERTMxOCAwMDA1
NzYgKHYwMiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4w
MDAwMDBdIEFDUEk6IFNUQU8gMHgwMDAwMDgwN0Y2NkNGQzEwIDAwMDAyNSAodjAxIEFtcGVyZSBB
bHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1BD
UjogY29uc29sZTogcGwwMTEsbW1pbzMyLDB4MTAwMDAyNjAwMDAwLDExNTIwMA0KWyAgICAwLjAw
MDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4ODMwMDAwMC0weDg4M2ZmZmZm
XQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg5MDAwMDAw
MC0weGZmZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFtt
ZW0gMHg4MDAwMDAwMDAwMC0weDgwMDdmZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JB
VDogTm9kZSAwIFBYTSAwIFttZW0gMHg4MDEwMDAwMDAwMC0weDgwN2ZmZmZmZmZmXQ0KWyAgICAw
LjAwMDAwMF0gTlVNQTogTk9ERV9EQVRBIFttZW0gMHg4MDc5ZWZlZWUwMC0weDgwNzllZmYwZmZm
XQ0KWyAgICAwLjAwMDAwMF0gWm9uZSByYW5nZXM6DQpbICAgIDAuMDAwMDAwXSAgIERNQSAgICAg
IFttZW0gMHgwMDAwMDAwMDk4MDAwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0NClsgICAgMC4wMDAw
MDBdICAgRE1BMzIgICAgZW1wdHkNClsgICAgMC4wMDAwMDBdICAgTm9ybWFsICAgW21lbSAweDAw
MDAwMDAxMDAwMDAwMDAtMHgwMDAwMDgwN2ZhMGRmZmZmXQ0KWyAgICAwLjAwMDAwMF0gTW92YWJs
ZSB6b25lIHN0YXJ0IGZvciBlYWNoIG5vZGUNClsgICAgMC4wMDAwMDBdIEVhcmx5IG1lbW9yeSBu
b2RlIHJhbmdlcw0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwOTgw
MDAwMDAtMHgwMDAwMDAwMGY3ZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21l
bSAweDAwMDAwODAwMDAwMDAwMDAtMHgwMDAwMDgwMDdmZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0g
ICBub2RlICAgMDogW21lbSAweDAwMDAwODA2ODAwMDAwMDAtMHgwMDAwMDgwNzlmZmZmZmZmXQ0K
WyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjY2Y2YwMDAtMHgwMDAw
MDgwN2Y2NmNmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3
ZjhkYjAwMDAtMHgwMDAwMDgwN2Y4ZGRmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDog
W21lbSAweDAwMDAwODA3ZmEwZDAwMDAtMHgwMDAwMDgwN2ZhMGRmZmZmXQ0KWyAgICAwLjAwMDAw
MF0gSW5pdG1lbSBzZXR1cCBub2RlIDAgW21lbSAweDAwMDAwMDAwOTgwMDAwMDAtMHgwMDAwMDgw
N2ZhMGRmZmZmXQ0KWyAgICAwLjAwMDAwMF0gcHNjaTogcHJvYmluZyBmb3IgY29uZHVpdCBtZXRo
b2QgZnJvbSBBQ1BJLg0KWyAgICAwLjAwMDAwMF0gcHNjaTogUFNDSXYxLjEgZGV0ZWN0ZWQgaW4g
ZmlybXdhcmUuDQpbICAgIDAuMDAwMDAwXSBwc2NpOiBVc2luZyBzdGFuZGFyZCBQU0NJIHYwLjIg
ZnVuY3Rpb24gSURzDQpbICAgIDAuMDAwMDAwXSBwc2NpOiBUcnVzdGVkIE9TIG1pZ3JhdGlvbiBu
b3QgcmVxdWlyZWQNClsgICAgMC4wMDAwMDBdIHBzY2k6IFNNQyBDYWxsaW5nIENvbnZlbnRpb24g
djEuMQ0KWyAgICAwLjAwMDAwMF0gcGVyY3B1OiBFbWJlZGRlZCAzMSBwYWdlcy9jcHUgczg5MjQw
IHI4MTkyIGQyOTU0NCB1MTI2OTc2DQpbICAgIDAuMDAwMDAwXSBEZXRlY3RlZCBQSVBUIEktY2Fj
aGUgb24gQ1BVMA0KWyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogR0lDIHN5
c3RlbSByZWdpc3RlciBDUFUgaW50ZXJmYWNlDQpbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6
IGRldGVjdGVkOiBIYXJkd2FyZSBkaXJ0eSBiaXQgbWFuYWdlbWVudA0KWyAgICAwLjAwMDAwMF0g
Q1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3RyZS12NA0KWyAgICAwLjAwMDAwMF0gQ1BVIGZl
YXR1cmVzOiBkZXRlY3RlZDogQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAwLjAwMDAwMF0gQnVp
bHQgMSB6b25lbGlzdHMsIG1vYmlsaXR5IGdyb3VwaW5nIG9uLiAgVG90YWwgcGFnZXM6IDIwNjQ0
NDcNClsgICAgMC4wMDAwMDBdIFBvbGljeSB6b25lOiBOb3JtYWwNClsgICAgMC4wMDAwMDBdIEtl
cm5lbCBjb21tYW5kIGxpbmU6IGNvbnNvbGU9aHZjMCBlYXJseWNvbj14ZW4gcm9vdHdhaXQgcm9v
dD1QQVJUVVVJRD02YTYwNTI0ZC0wNjFkLTQ1NGEtYmZkMS0zODk4OTkxMGVjY2QNClsgICAgMC4w
MDAwMDBdIHByaW50azogbG9nX2J1Zl9sZW4gaW5kaXZpZHVhbCBtYXggY3B1IGNvbnRyaWJ1dGlv
bjogNDA5NiBieXRlcw0KWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbiB0b3RhbCBj
cHVfZXh0cmEgY29udHJpYnV0aW9uczogMTI2OTc2IGJ5dGVzDQpbICAgIDAuMDAwMDAwXSBwcmlu
dGs6IGxvZ19idWZfbGVuIG1pbiBzaXplOiAxMzEwNzIgYnl0ZXMNClsgICAgMC4wMDAwMDBdIHBy
aW50azogbG9nX2J1Zl9sZW46IDI2MjE0NCBieXRlcw0KWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBl
YXJseSBsb2cgYnVmIGZyZWU6IDEyNTkzNig5NiUpDQpbICAgIDAuMDAwMDAwXSBEZW50cnkgY2Fj
aGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAxMDQ4NTc2IChvcmRlcjogMTEsIDgzODg2MDggYnl0ZXMs
IGxpbmVhcikNClsgICAgMC4wMDAwMDBdIElub2RlLWNhY2hlIGhhc2ggdGFibGUgZW50cmllczog
NTI0Mjg4IChvcmRlcjogMTAsIDQxOTQzMDQgYnl0ZXMsIGxpbmVhcikNClsgICAgMC4wMDAwMDBd
IG1lbSBhdXRvLWluaXQ6IHN0YWNrOm9mZiwgaGVhcCBhbGxvYzpvZmYsIGhlYXAgZnJlZTpvZmYN
ClsgICAgMC4wMDAwMDBdIHNvZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgwMDAwMDAwMGY0
MDAwMDAwLTB4MDAwMDAwMDBmODAwMDAwMF0gKDY0TUIpDQpbICAgIDAuMDAwMDAwXSBNZW1vcnk6
IDgxMDA3NjRLLzgzODg4NjhLIGF2YWlsYWJsZSAoMTM1NjhLIGtlcm5lbCBjb2RlLCAxOTk2SyBy
d2RhdGEsIDM0NzZLIHJvZGF0YSwgNDE2MEsgaW5pdCwgODIySyBic3MsIDI4ODEwNEsgcmVzZXJ2
ZWQsIDBLIGNtYS1yZXNlcnZlZCkNClsgICAgMC4wMDAwMDBdIFNMVUI6IEhXYWxpZ249NjQsIE9y
ZGVyPTAtMywgTWluT2JqZWN0cz0wLCBDUFVzPTMyLCBOb2Rlcz0xDQpbICAgIDAuMDAwMDAwXSBm
dHJhY2U6IGFsbG9jYXRpbmcgNDEzMDYgZW50cmllcyBpbiAxNjIgcGFnZXMNClsgICAgMC4wMDAw
MDBdIGZ0cmFjZTogYWxsb2NhdGVkIDE2MiBwYWdlcyB3aXRoIDMgZ3JvdXBzDQpbICAgIDAuMDAw
MDAwXSByY3U6IFByZWVtcHRpYmxlIGhpZXJhcmNoaWNhbCBSQ1UgaW1wbGVtZW50YXRpb24uDQpb
ICAgIDAuMDAwMDAwXSByY3U6IAlSQ1UgZXZlbnQgdHJhY2luZyBpcyBlbmFibGVkLg0KWyAgICAw
LjAwMDAwMF0gcmN1OiAJUkNVIHJlc3RyaWN0aW5nIENQVXMgZnJvbSBOUl9DUFVTPTI1NiB0byBu
cl9jcHVfaWRzPTMyLg0KWyAgICAwLjAwMDAwMF0gCVRyYW1wb2xpbmUgdmFyaWFudCBvZiBUYXNr
cyBSQ1UgZW5hYmxlZC4NClsgICAgMC4wMDAwMDBdIAlSdWRlIHZhcmlhbnQgb2YgVGFza3MgUkNV
IGVuYWJsZWQuDQpbICAgIDAuMDAwMDAwXSAJVHJhY2luZyB2YXJpYW50IG9mIFRhc2tzIFJDVSBl
bmFibGVkLg0KWyAgICAwLjAwMDAwMF0gcmN1OiBSQ1UgY2FsY3VsYXRlZCB2YWx1ZSBvZiBzY2hl
ZHVsZXItZW5saXN0bWVudCBkZWxheSBpcyAyNSBqaWZmaWVzLg0KWyAgICAwLjAwMDAwMF0gcmN1
OiBBZGp1c3RpbmcgZ2VvbWV0cnkgZm9yIHJjdV9mYW5vdXRfbGVhZj0xNiwgbnJfY3B1X2lkcz0z
Mg0KWyAgICAwLjAwMDAwMF0gTlJfSVJRUzogNjQsIG5yX2lycXM6IDY0LCBwcmVhbGxvY2F0ZWQg
aXJxczogMA0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IDY3MiBTUElzIGltcGxlbWVudGVkDQpbICAg
IDAuMDAwMDAwXSBHSUN2MzogMCBFeHRlbmRlZCBTUElzIGltcGxlbWVudGVkDQpbICAgIDAuMDAw
MDAwXSBHSUN2MzogRGlzdHJpYnV0b3IgaGFzIG5vIFJhbmdlIFNlbGVjdG9yIHN1cHBvcnQNClsg
ICAgMC4wMDAwMDBdIEdJQ3YzOiAxNiBQUElzIGltcGxlbWVudGVkDQpbICAgIDAuMDAwMDAwXSBH
SUN2MzogQ1BVMDogZm91bmQgcmVkaXN0cmlidXRvciAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDE0
MDAwMA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDAgLT4gTm9kZSAwDQpbICAg
IDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMSAtPiBOb2RlIDANClsgICAgMC4wMDAwMDBd
IFNSQVQ6IFBYTSAwIC0+IElUUyAyIC0+IE5vZGUgMA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhN
IDAgLT4gSVRTIDMgLT4gTm9kZSAwDQpbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMg
NCAtPiBOb2RlIDANClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA1IC0+IE5vZGUg
MA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDYgLT4gTm9kZSAwDQpbICAgIDAu
MDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNyAtPiBOb2RlIDANClsgICAgMC4wMDAwMDBdIElU
UyBbbWVtIDB4MTAwMTAwMDQwMDAwLTB4MTAwMTAwMDVmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRT
QDB4MDAwMDEwMDEwMDA0MDAwMDogRGV2aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMg
MjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQg
NTI0Mjg4IERldmljZXMgQDgwMDAwODAwMDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEp
DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgMzI3Njgg
SW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDIyMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEss
IHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwNjAwMDAtMHgxMDAxMDAw
N2ZmZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDYwMDAwOiBEZXZpY2VzIFRh
YmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAyMC0+MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAwNjAwMDA6IGFsbG9jYXRlZCA1MjQyODggRGV2aWNlcyBAODAwMDBjMDAwMDAgKGZs
YXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAx
MDAwNjAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMjQw
MDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFMgW21l
bSAweDEwMDEwMDA4MDAwMC0weDEwMDEwMDA5ZmZmZl0NClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAwODAwMDA6IERldmljZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRzIDIwLT4x
OQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDUyNDI4
OCBEZXZpY2VzIEA4MDAwMTAwMDAwMCAoZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQ0KWyAg
ICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVy
cnVwdCBDb2xsZWN0aW9ucyBAODAwMDAyNjAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIg
MSkNClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMGEwMDAwLTB4MTAwMTAwMGJmZmZm
XQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBhMDAwMDogRGV2aWNlcyBUYWJsZSB0
b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMGEwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMgQDgwMDAxNDAwMDAwIChmbGF0LCBl
c3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGEw
MDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDI4MDAwMCAo
ZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgx
MDAxMDAwYzAwMDAtMHgxMDAxMDAwZGZmZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMGMwMDAwOiBEZXZpY2VzIFRhYmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAyMC0+MTkNClsg
ICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCA1MjQyODggRGV2
aWNlcyBAODAwMDE4MDAwMDAgKGZsYXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4w
MDAwMDBdIElUU0AweDAwMDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQg
Q29sbGVjdGlvbnMgQDgwMDAwMmEwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpDQpb
ICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDBlMDAwMC0weDEwMDEwMDBmZmZmZl0NClsg
ICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwZTAwMDA6IERldmljZXMgVGFibGUgdG9vIGxh
cmdlLCByZWR1Y2UgaWRzIDIwLT4xOQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBl
MDAwMDogYWxsb2NhdGVkIDUyNDI4OCBEZXZpY2VzIEA4MDAwMWMwMDAwMCAoZmxhdCwgZXN6IDgs
IHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBlMDAwMDog
YWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAyYzAwMDAgKGZsYXQs
IGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAw
MTAwMDAwLTB4MTAwMTAwMTFmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEw
MDAwMDogRGV2aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAu
MDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMTAwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMg
QDgwMDAyMDAwMDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAw
XSBJVFNAMHgwMDAwMTAwMTAwMTAwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxl
Y3Rpb25zIEA4MDAwMDJlMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAw
LjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAxMjAwMDAtMHgxMDAxMDAxM2ZmZmZdDQpbICAgIDAu
MDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMTIwMDAwOiBEZXZpY2VzIFRhYmxlIHRvbyBsYXJnZSwg
cmVkdWNlIGlkcyAyMC0+MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMjAwMDA6
IGFsbG9jYXRlZCA1MjQyODggRGV2aWNlcyBAODAwMDI0MDAwMDAgKGZsYXQsIGVzeiA4LCBwc3og
NjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMjAwMDA6IGFsbG9j
YXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMzAwMDAwIChmbGF0LCBlc3og
MiwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJl
IF0tLS0tLS0tLS0tLS0NClsgICAgMC4wMDAwMDBdIFdBUk5JTkc6IENQVTogMCBQSUQ6IDAgYXQg
ZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MjI0NyBpdHNfaW5pdCsweDM5OC8weDY5
MA0KWyAgICAwLjAwMDAwMF0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDAuMDAwMDAwXSBDUFU6
IDAgUElEOiAwIENvbW06IHN3YXBwZXIvMCBOb3QgdGFpbnRlZCA1LjEwLjI3LWFtcGVyZS1sdHMt
c3RhbmRhcmQrICMxDQpbICAgIDAuMDAwMDAwXSBwc3RhdGU6IDYwMDAwMDg1IChuWkN2IGRhSWYg
LVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDAuMDAwMDAwXSBwYyA6IGl0c19pbml0KzB4
Mzk4LzB4NjkwDQpbICAgIDAuMDAwMDAwXSBsciA6IGl0c19pbml0KzB4Mzk0LzB4NjkwDQpbICAg
IDAuMDAwMDAwXSBzcCA6IGZmZmY4MDAwMTE0ZDNjNTANClsgICAgMC4wMDAwMDBdIHgyOTogZmZm
ZjgwMDAxMTRkM2M1MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4Mjc6
IGZmZmY4MDAwMTE0ZGM5YzAgeDI2OiBmZmZmMDdmZjgwMWU1NTAwIA0KWyAgICAwLjAwMDAwMF0g
eDI1OiAwMDAwMDAwMDAwMDAwMDAwIHgyNDogZmZmZjA4MDcxZWMxYzBjMCANClsgICAgMC4wMDAw
MDBdIHgyMzogZmZmZjgwMDAxMTYyMjM1MCB4MjI6IGZmZmYwN2ZmODAxMWI2MDAgDQpbICAgIDAu
MDAwMDAwXSB4MjE6IGZmZmY4MDAwMTE0ZGM5YzAgeDIwOiBmZmZmODAwMDExNjIyMDAwIA0KWyAg
ICAwLjAwMDAwMF0geDE5OiBmZmZmODAwMDExNzY4OWY4IHgxODogZmZmZmZmZmZmZmZmZmZmZiAN
ClsgICAgMC4wMDAwMDBdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAw
MWYgDQpbICAgIDAuMDAwMDAwXSB4MTU6IGZmZmYwN2ZmODAyMDQ3MWQgeDE0OiAwMDAwMDAwMDAw
MDAwMDU4IA0KWyAgICAwLjAwMDAwMF0geDEzOiAwMDAwMDAwMDAwMDAwMGMwIHgxMjogMDAwMDAw
MDAwMDAwMDAwMCANClsgICAgMC4wMDAwMDBdIHgxMTogMDAwMDAwMDAwMDAwMDAxMCB4MTA6IGZm
ZmYwODA3MWVhZTNhYzAgDQpbICAgIDAuMDAwMDAwXSB4OSA6IGZmZmY4MDAwMTBkMzRjYzAgeDgg
OiBmZmZmMDdmZjgwMzIwMDAwIA0KWyAgICAwLjAwMDAwMF0geDcgOiBhMmEyYTJhMmEyYTJhMmEy
IHg2IDogZmZmZjAwMDAwMDAwMDAwMCANClsgICAgMC4wMDAwMDBdIHg1IDogZmZmZmZkZmZmZmUw
MDAwMCB4NCA6IGZmZmY4MDAwMTE0ZGM5YzAgDQpbICAgIDAuMDAwMDAwXSB4MyA6IGZmZmY4MDAw
MTE0ZGRhZjAgeDIgOiAwMDAwMDAwMDAwMDAwMDNkIA0KWyAgICAwLjAwMDAwMF0geDEgOiAwMDAw
MDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMC4wMDAwMDBdIENhbGwg
dHJhY2U6DQpbICAgIDAuMDAwMDAwXSAgaXRzX2luaXQrMHgzOTgvMHg2OTANClsgICAgMC4wMDAw
MDBdICBnaWNfaW5pdF9iYXNlcysweDUyNC8weDU4NA0KWyAgICAwLjAwMDAwMF0gIGdpY19hY3Bp
X2luaXQrMHgxMzQvMHgyNzgNClsgICAgMC4wMDAwMDBdICBhY3BpX21hdGNoX21hZHQrMHg1MC8w
eDg4DQpbICAgIDAuMDAwMDAwXSAgYWNwaV90YWJsZV9wYXJzZV9lbnRyaWVzX2FycmF5KzB4MTY0
LzB4MjRjDQpbICAgIDAuMDAwMDAwXSAgYWNwaV90YWJsZV9wYXJzZV9lbnRyaWVzKzB4NDgvMHg3
MA0KWyAgICAwLjAwMDAwMF0gIGFjcGlfdGFibGVfcGFyc2VfbWFkdCsweDM0LzB4NDANClsgICAg
MC4wMDAwMDBdICBfX2FjcGlfcHJvYmVfZGV2aWNlX3RhYmxlKzB4OTAvMHhlYw0KWyAgICAwLjAw
MDAwMF0gIGlycWNoaXBfaW5pdCsweDQwLzB4NGMNClsgICAgMC4wMDAwMDBdICBpbml0X0lSUSsw
eGQwLzB4MTA0DQpbICAgIDAuMDAwMDAwXSAgc3RhcnRfa2VybmVsKzB4MzU0LzB4NTU0DQpbICAg
IDAuMDAwMDAwXSByYW5kb206IGdldF9yYW5kb21fYnl0ZXMgY2FsbGVkIGZyb20gX193YXJuKzB4
MTI4LzB4MWMwIHdpdGggY3JuZ19pbml0PTANClsgICAgMC4wMDAwMDBdIC0tLVsgZW5kIHRyYWNl
IDAwMDAwMDAwMDAwMDAwMDAgXS0tLQ0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IHVzaW5nIExQSSBw
cm9wZXJ0eSB0YWJsZSBAMHgwMDAwMDgwMDAwMzEwMDAwDQpbICAgIDAuMDAwMDAwXSAtLS0tLS0t
LS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMC4wMDAwMDBdIFdBUk5JTkc6IENQ
VTogMCBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMC4wMDAwMDBdIE1vZHVsZXMgbGlua2VkIGluOg0K
WyAgICAwLjAwMDAwMF0gQ1BVOiAwIFBJRDogMCBDb21tOiBzd2FwcGVyLzAgVGFpbnRlZDogRyAg
ICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMC4w
MDAwMDBdIHBzdGF0ZTogNjAwMDAwODUgKG5aQ3YgZGFJZiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0t
LSkNClsgICAgMC4wMDAwMDBdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDAu
MDAwMDAwXSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAwLjAwMDAwMF0gc3Ag
OiBmZmZmODAwMDExNGQzYzgwDQpbICAgIDAuMDAwMDAwXSB4Mjk6IGZmZmY4MDAwMTE0ZDNjODAg
eDI4OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDI3OiAwMDAwMDAwMDAwMDAw
MDAxIHgyNjogZmZmZjgwMDAxMjAwMDA3MCANClsgICAgMC4wMDAwMDBdIHgyNTogZmZmZmZlMWZm
ZGUwYzgwMCB4MjQ6IGZmZmY4MDAwMTIwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4MjM6IGZmZmY4
MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAwLjAwMDAwMF0geDIxOiBm
ZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMC4wMDAwMDBdIHgx
OTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDAuMDAwMDAw
XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDFmIA0KWyAgICAwLjAw
MDAwMF0geDE1OiBmZmZmODAwMDkxNGQzOTY3IHgxNDogMDAwMDAwMDAwMDAwMDA1OCANClsgICAg
MC4wMDAwMDBdIHgxMzogMDAwMDAwMDAwMDAwMDBjMCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpb
ICAgIDAuMDAwMDAwXSB4MTE6IDAwMDAwMDAwMDAwMDAwMTAgeDEwOiAwMDAwMDAwMDAwMDAwMDBj
IA0KWyAgICAwLjAwMDAwMF0geDkgOiBmZmZmODAwMDEwZDM0Y2MwIHg4IDogMDAwMDAwMDAwMDAw
MDAwMCANClsgICAgMC4wMDAwMDBdIHg3IDogZmZmZjA4MDcxZWZlZmJjMCB4NiA6IDAwMDAwMDAw
MDAwMDAwMDMgDQpbICAgIDAuMDAwMDAwXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZm
ZmRmZmZmZTAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDog
MDAwMDAwMDAwMDAwZmZmZiANClsgICAgMC4wMDAwMDBdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4
MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDAuMDAwMDAwXSBDYWxsIHRyYWNlOg0KWyAgICAw
LjAwMDAwMF0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAwLjAwMDAwMF0gIGdpY19p
bml0X2Jhc2VzKzB4NTI4LzB4NTg0DQpbICAgIDAuMDAwMDAwXSAgZ2ljX2FjcGlfaW5pdCsweDEz
NC8weDI3OA0KWyAgICAwLjAwMDAwMF0gIGFjcGlfbWF0Y2hfbWFkdCsweDUwLzB4ODgNClsgICAg
MC4wMDAwMDBdICBhY3BpX3RhYmxlX3BhcnNlX2VudHJpZXNfYXJyYXkrMHgxNjQvMHgyNGMNClsg
ICAgMC4wMDAwMDBdICBhY3BpX3RhYmxlX3BhcnNlX2VudHJpZXMrMHg0OC8weDcwDQpbICAgIDAu
MDAwMDAwXSAgYWNwaV90YWJsZV9wYXJzZV9tYWR0KzB4MzQvMHg0MA0KWyAgICAwLjAwMDAwMF0g
IF9fYWNwaV9wcm9iZV9kZXZpY2VfdGFibGUrMHg5MC8weGVjDQpbICAgIDAuMDAwMDAwXSAgaXJx
Y2hpcF9pbml0KzB4NDAvMHg0Yw0KWyAgICAwLjAwMDAwMF0gIGluaXRfSVJRKzB4ZDAvMHgxMDQN
ClsgICAgMC4wMDAwMDBdICBzdGFydF9rZXJuZWwrMHgzNTQvMHg1NTQNClsgICAgMC4wMDAwMDBd
IC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTIgXS0tLQ0KWyAgICAwLjAwMDAwMF0gR0lD
djM6IENQVTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAw
MzIwMDAwDQpbICAgIDAuMDAwMDAwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJv
dW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDAuMDAwMDAwXSBBQ1BJIEdURFQ6IGZv
dW5kIDEgbWVtb3J5LW1hcHBlZCB0aW1lciBibG9jayhzKS4NClsgICAgMC4wMDAwMDBdIGFyY2hf
dGltZXI6IGNwMTUgYW5kIG1taW8gdGltZXIocykgcnVubmluZyBhdCAyNS4wME1IeiAodmlydC9w
aHlzKS4NClsgICAgMC4wMDAwMDBdIGNsb2Nrc291cmNlOiBhcmNoX3N5c19jb3VudGVyOiBtYXNr
OiAweGZmZmZmZmZmZmZmZmZmIG1heF9jeWNsZXM6IDB4NWM0MDkzOWI1LCBtYXhfaWRsZV9uczog
NDQwNzk1MjAyNjQ2IG5zDQpbICAgIDAuMDAwMDAxXSBzY2hlZF9jbG9jazogNTYgYml0cyBhdCAy
NU1IeiwgcmVzb2x1dGlvbiA0MG5zLCB3cmFwcyBldmVyeSA0Mzk4MDQ2NTExMTAwbnMNClsgICAg
MC4wMDAwNTVdIENvbnNvbGU6IGNvbG91ciBkdW1teSBkZXZpY2UgODB4MjUNClsgICAgMS4yNzE3
NjJdIHByaW50azogY29uc29sZSBbaHZjMF0gZW5hYmxlZA0KWyAgICAxLjI3NTk0OV0gQUNQSTog
Q29yZSByZXZpc2lvbiAyMDIwMDkyNQ0KWyAgICAxLjI4MDI1OV0gQUNQSSBCSU9TIFdhcm5pbmcg
KGJ1Zyk6IEluY29ycmVjdCBjaGVja3N1bSBpbiB0YWJsZSBbSU9SVF0gLSAweEYyLCBzaG91bGQg
YmUgMHgwQiAoMjAyMDA5MjUvdGJwcmludC0xNzMpDQpbICAgIDEuMjkwODQ0XSBDYWxpYnJhdGlu
ZyBkZWxheSBsb29wIChza2lwcGVkKSwgdmFsdWUgY2FsY3VsYXRlZCB1c2luZyB0aW1lciBmcmVx
dWVuY3kuLiA1MC4wMCBCb2dvTUlQUyAobHBqPTEwMDAwMCkNClsgICAgMS4zMDExODNdIHBpZF9t
YXg6IGRlZmF1bHQ6IDMyNzY4IG1pbmltdW06IDMwMQ0KWyAgICAxLjMwNTg5OF0gTFNNOiBTZWN1
cml0eSBGcmFtZXdvcmsgaW5pdGlhbGl6aW5nDQpbICAgIDEuMzEwNjIzXSBNb3VudC1jYWNoZSBo
YXNoIHRhYmxlIGVudHJpZXM6IDE2Mzg0IChvcmRlcjogNSwgMTMxMDcyIGJ5dGVzLCBsaW5lYXIp
DQpbICAgIDEuMzE4MjE3XSBNb3VudHBvaW50LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMTYz
ODQgKG9yZGVyOiA1LCAxMzEwNzIgYnl0ZXMsIGxpbmVhcikNClsgICAgMS4zMjY2MDddIEFDUEkg
UFBUVDogUFBUVCB0YWJsZSBmb3VuZCwgYnV0IHVuYWJsZSB0byBsb2NhdGUgY29yZSAyICgyKQ0K
WyAgICAxLjMzMzYxNV0geGVuOmdyYW50X3RhYmxlOiBHcmFudCB0YWJsZXMgdXNpbmcgdmVyc2lv
biAxIGxheW91dA0KWyAgICAxLjMzOTUzNV0gR3JhbnQgdGFibGUgaW5pdGlhbGl6ZWQNClsgICAg
MS4zNDMxMDNdIHhlbjpldmVudHM6IFVzaW5nIEZJRk8tYmFzZWQgQUJJDQpbICAgIDEuMzQ3NDMx
XSBYZW46IGluaXRpYWxpemluZyBjcHUwDQpbICAgIDEuMzUwOTIyXSByY3U6IEhpZXJhcmNoaWNh
bCBTUkNVIGltcGxlbWVudGF0aW9uLg0KWyAgICAxLjM1NTg5M10gUGxhdGZvcm0gTVNJOiBJVFNA
MHgxMDAxMDAwNDAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS4zNjE0MDFdIFBsYXRmb3JtIE1T
STogSVRTQDB4MTAwMTAwMDYwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzY3MDYzXSBQbGF0
Zm9ybSBNU0k6IElUU0AweDEwMDEwMDA4MDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjM3MjY5
Ml0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwYTAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAg
MS4zNzgzMjJdIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAwMGMwMDAwIGRvbWFpbiBjcmVhdGVk
DQpbICAgIDEuMzgzOTY2XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDBlMDAwMCBkb21haW4g
Y3JlYXRlZA0KWyAgICAxLjM4OTYwNV0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMDAwMDAg
ZG9tYWluIGNyZWF0ZWQNClsgICAgMS4zOTUyNDddIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAw
MTIwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuNDAwODkyXSBQQ0kvTVNJOiBJVFNAMHgxMDAx
MDAwNDAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40MDYwOThdIFBDSS9NU0k6IElUU0AweDEw
MDEwMDA2MDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjQxMTMwNl0gUENJL01TSTogSVRTQDB4
MTAwMTAwMDgwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuNDE2NTE1XSBQQ0kvTVNJOiBJVFNA
MHgxMDAxMDAwYTAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40MjE3MjNdIFBDSS9NU0k6IElU
U0AweDEwMDEwMDBjMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjQyNjkzMV0gUENJL01TSTog
SVRTQDB4MTAwMTAwMGUwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuNDMyMTM5XSBQQ0kvTVNJ
OiBJVFNAMHgxMDAxMDAxMDAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40MzczNDhdIFBDSS9N
U0k6IElUU0AweDEwMDEwMDEyMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjQ0MjU1OV0gRUZJ
IHJ1bnRpbWUgc2VydmljZXMgYWNjZXNzIHZpYSBwYXJhdmlydC4NClsgICAgMS40NDgwMTFdIHNt
cDogQnJpbmdpbmcgdXAgc2Vjb25kYXJ5IENQVXMgLi4uDQooWEVOKSBkMHYxOiB2R0lDUjogU0dJ
OiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihY
RU4pIGQwdjI6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZm
ZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MzogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQg
d3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHY0OiB2R0lDUjog
U0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjAN
CihYRU4pIGQwdjU6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZm
ZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2NjogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdv
cmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHY3OiB2R0lD
UjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZF
UjANCihYRU4pIGQwdjg6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAw
ZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2OTogdkdJQ1I6IFNHSTogdW5oYW5kbGVk
IHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYxMDog
dkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FD
VElWRVIwDQooWEVOKSBkMHYxMTogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgw
MDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYxMjogdkdJQ1I6IFNHSTogdW5o
YW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBk
MHYxMzogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0
byBJQ0FDVElWRVIwDQooWEVOKSBkMHYxNDogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3Jp
dGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYxNTogdkdJQ1I6IFNH
STogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQoo
WEVOKSBkMHYxNjogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZm
ZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYxNzogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdv
cmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYxODogdkdJ
Q1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElW
RVIwDQooWEVOKSBkMHYxOTogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAw
MDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYyMDogdkdJQ1I6IFNHSTogdW5oYW5k
bGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYy
MTogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJ
Q0FDVElWRVIwDQooWEVOKSBkMHYyMjogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUg
MHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYyMzogdkdJQ1I6IFNHSTog
dW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVO
KSBkMHYyNDogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZm
ZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYyNTogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQg
d3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYyNjogdkdJQ1I6
IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIw
DQooWEVOKSBkMHYyNzogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBm
ZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYyODogdkdJQ1I6IFNHSTogdW5oYW5kbGVk
IHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYyOTog
dkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FD
VElWRVIwDQooWEVOKSBkMHYzMDogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgw
MDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQooWEVOKSBkMHYzMTogdkdJQ1I6IFNHSTogdW5o
YW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQpbICAgIDEu
NDUyNjQwXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMQ0KWyAgICAxLjQ1MjY2NV0gR0lD
djM6IENQVTE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMSByZWdpb24gMDoweDAwMDAxMDAxMDAxNjAw
MDANClsgICAgMS40NTkxOTddIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0K
WyAgICAxLjQ1OTIwMl0gV0FSTklORzogQ1BVOiAxIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAv
aXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ1
OTIwM10gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNDU5MjA3XSBDUFU6IDEgUElEOiAwIENv
bW06IHN3YXBwZXIvMSBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUt
bHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjQ1OTIwOV0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBk
QUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjQ1OTIxMF0gcGMgOiBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NTkyMTJdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIw
LzB4YjIwDQpbICAgIDEuNDU5MjEzXSBzcCA6IGZmZmY4MDAwMTFhM2JlODANClsgICAgMS40NTky
MTRdIHgyOTogZmZmZjgwMDAxMWEzYmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEu
NDU5MjE2XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMDIwMDcwIA0KWyAg
ICAxLjQ1OTIxOF0geDI1OiBmZmZmZmUxZmZkZTBjYzAwIHgyNDogZmZmZjgwMDAxMjAyMDAwMCAN
ClsgICAgMS40NTkyMjBdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkw
MDAgDQpbICAgIDEuNDU5MjIyXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDEx
NjIyMzUwIA0KWyAgICAxLjQ1OTIyNF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZm
ZmZmZmZmZmZmZiANClsgICAgMS40NTkyMjZdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAw
MDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDU5MjI4XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0
OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjQ1OTIzMF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0
IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40NTkyMzJdIHgxMTogMDAwMDAwMDAwMDAw
MDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNDU5MjM0XSB4OSA6IGZmZmY4MDAw
MTA2ZDY4MzAgeDggOiAzMDMwMzAzMDM2MzEzMDMwIA0KWyAgICAxLjQ1OTIzNV0geDcgOiAzMTMw
MzAzMTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40NTkyMzddIHg1IDog
MDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDU5MjM5XSB4
MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ1OTI0
MV0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40
NTkyNDRdIENhbGwgdHJhY2U6DQpbICAgIDEuNDU5MjQ1XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNDU5MjQ5XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40
NTkyNTFdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ1OTI1NF0g
IG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNDU5MjU3XSAgc2Vjb25kYXJ5
X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNDU5MjU4XSAtLS1bIGVuZCB0cmFjZSBm
Njg3MjhhMGQzMDUzYjUzIF0tLS0NClsgICAgMS40NTkyNjNdIEdJQ3YzOiBDUFUxOiB1c2luZyBh
bGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDMzMDAwMA0KWyAgICAxLjQ1
OTMyMF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0
dW0gMTQxODA0MA0KWyAgICAxLjQ1OTMyOF0gWGVuOiBpbml0aWFsaXppbmcgY3B1MQ0KWyAgICAx
LjQ1OTM0OF0gQ1BVMTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDAxIFsw
eDQxM2ZkMGMxXQ0KWyAgICAxLjQ1OTY3Nl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTIN
ClsgICAgMS40NTk3MDRdIEdJQ3YzOiBDUFUyOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDIgcmVnaW9u
IDA6MHgwMDAwMTAwMTAwMTgwMDAwDQpbICAgIDEuNDY2MjM5XSAtLS0tLS0tLS0tLS1bIGN1dCBo
ZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS40NjYyNDZdIFdBUk5JTkc6IENQVTogMiBQSUQ6IDAg
YXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS40NjYyNDddIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ2NjI1
Ml0gQ1BVOiAyIFBJRDogMCBDb21tOiBzd2FwcGVyLzIgVGFpbnRlZDogRyAgICAgICAgVyAgICAg
ICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS40NjYyNTRdIHBzdGF0
ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS40
NjYyNTZdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDY2MjU4XSBsciA6
IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjQ2NjI1OV0gc3AgOiBmZmZmODAwMDEx
YTQzZTgwDQpbICAgIDEuNDY2MjYwXSB4Mjk6IGZmZmY4MDAwMTFhNDNlODAgeDI4OiAwMDAwMDAw
MDAwMDAwMDAyIA0KWyAgICAxLjQ2NjI2Ml0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZm
ZjgwMDAxMjA0MDA3MCANClsgICAgMS40NjYyNjRdIHgyNTogZmZmZmZlMWZmZGUwZDAwMCB4MjQ6
IGZmZmY4MDAwMTIwNDAwMDAgDQpbICAgIDEuNDY2MjY2XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAg
eDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjQ2NjI2OF0geDIxOiBmZmZmODAwMDExNzY4
OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS40NjYyNzBdIHgxOTogZmZmZjgwMDAx
MTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNDY2MjcyXSB4MTc6IDAwMDAw
MDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjQ2NjI3NF0geDE1OiBm
ZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS40NjYyNzZdIHgx
MzogZmZmZjgwMDAxMTZkNGNmNCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDY2Mjc4
XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjQ2
NjI3OV0geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzMDMwMzAzODMxMzAzMCANClsgICAg
MS40NjYyODFdIHg3IDogMzEzMDMwMzEzMDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpb
ICAgIDEuNDY2MjgzXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAw
IA0KWyAgICAxLjQ2NjI4NV0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAw
ZmZmZiANClsgICAgMS40NjYyODddIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAw
ZmZmZmZmZWQgDQpbICAgIDEuNDY2Mjg5XSBDYWxsIHRyYWNlOg0KWyAgICAxLjQ2NjI5MV0gIGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ2NjI5NF0gIGdpY19zdGFydGluZ19jcHUr
MHg0OC8weDkwDQpbICAgIDEuNDY2Mjk4XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0
NjANClsgICAgMS40NjYzMDBdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAx
LjQ2NjMwM10gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjQ2NjMw
NF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I1NCBdLS0tDQpbICAgIDEuNDY2MzEwXSBH
SUN2MzogQ1BVMjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAw
MDAzNDAwMDANClsgICAgMS40NjYzNzddIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS40NjYzODhdIFhlbjogaW5pdGlh
bGl6aW5nIGNwdTINClsgICAgMS40NjY0MTFdIENQVTI6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vz
c29yIDB4MDAwMDAwMDAwMiBbMHg0MTNmZDBjMV0NClsgICAgMS40NjY3MDddIERldGVjdGVkIFBJ
UFQgSS1jYWNoZSBvbiBDUFUzDQpbICAgIDEuNDY2NzMzXSBHSUN2MzogQ1BVMzogZm91bmQgcmVk
aXN0cmlidXRvciAzIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDFhMDAwMA0KWyAgICAxLjQ3MzI2NV0g
LS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNDczMjcwXSBXQVJO
SU5HOiBDUFU6IDMgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMw
NjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDczMjcxXSBNb2R1bGVzIGxpbmtl
ZCBpbjoNClsgICAgMS40NzMyNzVdIENQVTogMyBQSUQ6IDAgQ29tbTogc3dhcHBlci8zIFRhaW50
ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpb
ICAgIDEuNDczMjc3XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08g
QlRZUEU9LS0pDQpbICAgIDEuNDczMjgwXSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjQ3MzI4MV0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS40NzMy
ODJdIHNwIDogZmZmZjgwMDAxMWE0YmU4MA0KWyAgICAxLjQ3MzI4M10geDI5OiBmZmZmODAwMDEx
YTRiZTgwIHgyODogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40NzMyODVdIHgyNzogMDAwMDAw
MDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIwNjAwNzAgDQpbICAgIDEuNDczMjg3XSB4MjU6IGZm
ZmZmZTFmZmRlMGQ0MDAgeDI0OiBmZmZmODAwMDEyMDYwMDAwIA0KWyAgICAxLjQ3MzI4OV0geDIz
OiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS40NzMyOTFd
IHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNDcz
MjkzXSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAx
LjQ3MzI5NV0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsg
ICAgMS40NzMyOTddIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAg
DQpbICAgIDEuNDczMjk5XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAw
MDAwIA0KWyAgICAxLjQ3MzMwMV0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAw
MDAwMDAwMSANClsgICAgMS40NzMzMDNdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAz
MDMwNjEzMTMwMzAgDQpbICAgIDEuNDczMzA1XSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAw
MDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjQ3MzMwN10geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0
IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS40NzMzMDldIHgzIDogMDAwMDAwMDAwMDAwMDAx
MCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNDczMzExXSB4MSA6IDAwMDAwMDAwMDAw
MTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjQ3MzMxM10gQ2FsbCB0cmFjZToN
ClsgICAgMS40NzMzMTVdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NzMzMThd
ICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjQ3MzMyMF0gIGNwdWhwX2ludm9r
ZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNDczMzIyXSAgbm90aWZ5X2NwdV9zdGFydGlu
ZysweGEwLzB4ZTANClsgICAgMS40NzMzMjRdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgv
MHgxOTANClsgICAgMS40NzMzMjZdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTUgXS0t
LQ0KWyAgICAxLjQ3MzMzMV0gR0lDdjM6IENQVTM6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGlu
ZyB0YWJsZSBAMHgwMDAwMDgwMDAwMzUwMDAwDQpbICAgIDEuNDczMzkxXSBhcmNoX3RpbWVyOiBF
bmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEu
NDczMzk5XSBYZW46IGluaXRpYWxpemluZyBjcHUzDQpbICAgIDEuNDczNDIwXSBDUFUzOiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMDMgWzB4NDEzZmQwYzFdDQpbICAgIDEu
NDczNjc1XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVNA0KWyAgICAxLjQ3MzcwNF0gR0lD
djM6IENQVTQ6IGZvdW5kIHJlZGlzdHJpYnV0b3IgNCByZWdpb24gMDoweDAwMDAxMDAxMDAxYzAw
MDANClsgICAgMS40ODAyMzZdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0K
WyAgICAxLjQ4MDI0MF0gV0FSTklORzogQ1BVOiA0IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAv
aXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ4
MDI0MV0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNDgwMjQ1XSBDUFU6IDQgUElEOiAwIENv
bW06IHN3YXBwZXIvNCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUt
bHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjQ4MDI0N10gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBk
QUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjQ4MDI0OF0gcGMgOiBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40ODAyNTBdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIw
LzB4YjIwDQpbICAgIDEuNDgwMjUxXSBzcCA6IGZmZmY4MDAwMTFhNTNlODANClsgICAgMS40ODAy
NTJdIHgyOTogZmZmZjgwMDAxMWE1M2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDQgDQpbICAgIDEu
NDgwMjU0XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMDgwMDcwIA0KWyAg
ICAxLjQ4MDI1Nl0geDI1OiBmZmZmZmUxZmZkZTBkODAwIHgyNDogZmZmZjgwMDAxMjA4MDAwMCAN
ClsgICAgMS40ODAyNThdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkw
MDAgDQpbICAgIDEuNDgwMjYwXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDEx
NjIyMzUwIA0KWyAgICAxLjQ4MDI2Ml0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZm
ZmZmZmZmZmZmZiANClsgICAgMS40ODAyNjRdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAw
MDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDgwMjY2XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0
OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjQ4MDI2OF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0
IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40ODAyNzBdIHgxMTogMDAwMDAwMDAwMDAw
MDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNDgwMjcyXSB4OSA6IGZmZmY4MDAw
MTA2ZDY4MzAgeDggOiAzMDMwMzAzMDYzMzEzMDMwIA0KWyAgICAxLjQ4MDI3NF0geDcgOiAzMTMw
MzAzMTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40ODAyNzZdIHg1IDog
MDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDgwMjc4XSB4
MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ4MDI4
MF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40
ODAyODJdIENhbGwgdHJhY2U6DQpbICAgIDEuNDgwMjg0XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNDgwMjg3XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40
ODAyODldICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ4MDI5MV0g
IG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNDgwMjk0XSAgc2Vjb25kYXJ5
X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNDgwMjk1XSAtLS1bIGVuZCB0cmFjZSBm
Njg3MjhhMGQzMDUzYjU2IF0tLS0NClsgICAgMS40ODAzMDFdIEdJQ3YzOiBDUFU0OiB1c2luZyBh
bGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDM2MDAwMA0KWyAgICAxLjQ4
MDM2Nl0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0
dW0gMTQxODA0MA0KWyAgICAxLjQ4MDM3NV0gWGVuOiBpbml0aWFsaXppbmcgY3B1NA0KWyAgICAx
LjQ4MDM5NV0gQ1BVNDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA0IFsw
eDQxM2ZkMGMxXQ0KWyAgICAxLjQ4MDc0M10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTUN
ClsgICAgMS40ODA3NzNdIEdJQ3YzOiBDUFU1OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDUgcmVnaW9u
IDA6MHgwMDAwMTAwMTAwMWUwMDAwDQpbICAgIDEuNDg3MzA1XSAtLS0tLS0tLS0tLS1bIGN1dCBo
ZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS40ODczMTBdIFdBUk5JTkc6IENQVTogNSBQSUQ6IDAg
YXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS40ODczMTFdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ4NzMx
NV0gQ1BVOiA1IFBJRDogMCBDb21tOiBzd2FwcGVyLzUgVGFpbnRlZDogRyAgICAgICAgVyAgICAg
ICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS40ODczMTddIHBzdGF0
ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS40
ODczMTldIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDg3MzIwXSBsciA6
IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjQ4NzMyMV0gc3AgOiBmZmZmODAwMDEx
YTViZTgwDQpbICAgIDEuNDg3MzIyXSB4Mjk6IGZmZmY4MDAwMTFhNWJlODAgeDI4OiAwMDAwMDAw
MDAwMDAwMDA1IA0KWyAgICAxLjQ4NzMyNV0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZm
ZjgwMDAxMjBhMDA3MCANClsgICAgMS40ODczMjddIHgyNTogZmZmZmZlMWZmZGUwZGMwMCB4MjQ6
IGZmZmY4MDAwMTIwYTAwMDAgDQpbICAgIDEuNDg3MzI5XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAg
eDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjQ4NzMzMV0geDIxOiBmZmZmODAwMDExNzY4
OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS40ODczMzNdIHgxOTogZmZmZjgwMDAx
MTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNDg3MzM1XSB4MTc6IDAwMDAw
MDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjQ4NzMzN10geDE1OiBm
ZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS40ODczMzldIHgx
MzogZmZmZjgwMDAxMTZkNGNmNCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDg3MzQx
XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjQ4
NzM0Ml0geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzMDMwMzA2NTMxMzAzMCANClsgICAg
MS40ODczNDVdIHg3IDogMzEzMDMwMzEzMDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpb
ICAgIDEuNDg3MzQ2XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAw
IA0KWyAgICAxLjQ4NzM0OF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAw
ZmZmZiANClsgICAgMS40ODczNTFdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAw
ZmZmZmZmZWQgDQpbICAgIDEuNDg3MzUzXSBDYWxsIHRyYWNlOg0KWyAgICAxLjQ4NzM1NF0gIGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ4NzM1N10gIGdpY19zdGFydGluZ19jcHUr
MHg0OC8weDkwDQpbICAgIDEuNDg3MzYwXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0
NjANClsgICAgMS40ODczNjJdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAx
LjQ4NzM2NF0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjQ4NzM2
Nl0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I1NyBdLS0tDQpbICAgIDEuNDg3MzcyXSBH
SUN2MzogQ1BVNTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAw
MDAzNzAwMDANClsgICAgMS40ODc0MzNdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS40ODc0NDFdIFhlbjogaW5pdGlh
bGl6aW5nIGNwdTUNClsgICAgMS40ODc0NjJdIENQVTU6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vz
c29yIDB4MDAwMDAwMDAwNSBbMHg0MTNmZDBjMV0NClsgICAgMS40ODc4MjJdIERldGVjdGVkIFBJ
UFQgSS1jYWNoZSBvbiBDUFU2DQpbICAgIDEuNDg3ODU0XSBHSUN2MzogQ1BVNjogZm91bmQgcmVk
aXN0cmlidXRvciA2IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDIwMDAwMA0KWyAgICAxLjQ5NDM4N10g
LS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNDk0MzkyXSBXQVJO
SU5HOiBDUFU6IDYgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMw
NjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDk0MzkzXSBNb2R1bGVzIGxpbmtl
ZCBpbjoNClsgICAgMS40OTQzOTddIENQVTogNiBQSUQ6IDAgQ29tbTogc3dhcHBlci82IFRhaW50
ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpb
ICAgIDEuNDk0Mzk5XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08g
QlRZUEU9LS0pDQpbICAgIDEuNDk0NDAxXSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjQ5NDQwMl0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS40OTQ0
MDNdIHNwIDogZmZmZjgwMDAxMWE2M2U4MA0KWyAgICAxLjQ5NDQwNF0geDI5OiBmZmZmODAwMDEx
YTYzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAwNiANClsgICAgMS40OTQ0MDZdIHgyNzogMDAwMDAw
MDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIwYzAwNzAgDQpbICAgIDEuNDk0NDA5XSB4MjU6IGZm
ZmZmZTFmZmRlMGUwMDAgeDI0OiBmZmZmODAwMDEyMGMwMDAwIA0KWyAgICAxLjQ5NDQxMV0geDIz
OiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS40OTQ0MTJd
IHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNDk0
NDE0XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAx
LjQ5NDQxNl0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsg
ICAgMS40OTQ0MThdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAg
DQpbICAgIDEuNDk0NDIwXSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAw
MDAwIA0KWyAgICAxLjQ5NDQyMl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAw
MDAwMDAwMSANClsgICAgMS40OTQ0MjRdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAz
MDMwMzAzMjMwMzAgDQpbICAgIDEuNDk0NDI2XSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAw
MDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjQ5NDQyOF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0
IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS40OTQ0MzBdIHgzIDogMDAwMDAwMDAwMDAwMDAx
MCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNDk0NDMyXSB4MSA6IDAwMDAwMDAwMDAw
MTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjQ5NDQzNF0gQ2FsbCB0cmFjZToN
ClsgICAgMS40OTQ0MzVdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40OTQ0Mzhd
ICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjQ5NDQ0MF0gIGNwdWhwX2ludm9r
ZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNDk0NDQyXSAgbm90aWZ5X2NwdV9zdGFydGlu
ZysweGEwLzB4ZTANClsgICAgMS40OTQ0NDVdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgv
MHgxOTANClsgICAgMS40OTQ0NDZdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTggXS0t
LQ0KWyAgICAxLjQ5NDQ1Ml0gR0lDdjM6IENQVTY6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGlu
ZyB0YWJsZSBAMHgwMDAwMDgwMDAwMzgwMDAwDQpbICAgIDEuNDk0NTE5XSBhcmNoX3RpbWVyOiBF
bmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEu
NDk0NTI4XSBYZW46IGluaXRpYWxpemluZyBjcHU2DQpbICAgIDEuNDk0NTUxXSBDUFU2OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMDYgWzB4NDEzZmQwYzFdDQpbICAgIDEu
NDk0ODcxXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVNw0KWyAgICAxLjQ5NDkwNl0gR0lD
djM6IENQVTc6IGZvdW5kIHJlZGlzdHJpYnV0b3IgNyByZWdpb24gMDoweDAwMDAxMDAxMDAyMjAw
MDANClsgICAgMS41MDE0MzhdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0K
WyAgICAxLjUwMTQ0M10gV0FSTklORzogQ1BVOiA3IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAv
aXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUw
MTQ0NF0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTAxNDQ4XSBDUFU6IDcgUElEOiAwIENv
bW06IHN3YXBwZXIvNyBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUt
bHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjUwMTQ1MF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBk
QUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjUwMTQ1Ml0gcGMgOiBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MDE0NTNdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIw
LzB4YjIwDQpbICAgIDEuNTAxNDU0XSBzcCA6IGZmZmY4MDAwMTFhNmJlODANClsgICAgMS41MDE0
NTVdIHgyOTogZmZmZjgwMDAxMWE2YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDcgDQpbICAgIDEu
NTAxNDU4XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMGUwMDcwIA0KWyAg
ICAxLjUwMTQ2MF0geDI1OiBmZmZmZmUxZmZkZTBlNDAwIHgyNDogZmZmZjgwMDAxMjBlMDAwMCAN
ClsgICAgMS41MDE0NjFdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkw
MDAgDQpbICAgIDEuNTAxNDYzXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDEx
NjIyMzUwIA0KWyAgICAxLjUwMTQ2NV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZm
ZmZmZmZmZmZmZiANClsgICAgMS41MDE0NjddIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAw
MDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTAxNDcwXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0
OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjUwMTQ3MV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0
IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MDE0NzNdIHgxMTogMDAwMDAwMDAwMDAw
MDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTAxNDc1XSB4OSA6IGZmZmY4MDAw
MTA2ZDY4MzAgeDggOiAzMDMwMzAzMDMyMzIzMDMwIA0KWyAgICAxLjUwMTQ3N10geDcgOiAzMTMw
MzAzMTMwMzAzMDMwIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41MDE0NzldIHg1IDog
MDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTAxNDgxXSB4
MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjUwMTQ4
M10geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41
MDE0ODVdIENhbGwgdHJhY2U6DQpbICAgIDEuNTAxNDg2XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNTAxNDkwXSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41
MDE0OTJdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjUwMTQ5NF0g
IG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTAxNDk3XSAgc2Vjb25kYXJ5
X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTAxNDk4XSAtLS1bIGVuZCB0cmFjZSBm
Njg3MjhhMGQzMDUzYjU5IF0tLS0NClsgICAgMS41MDE1MDRdIEdJQ3YzOiBDUFU3OiB1c2luZyBh
bGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDM5MDAwMA0KWyAgICAxLjUw
MTU2M10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0
dW0gMTQxODA0MA0KWyAgICAxLjUwMTU3MV0gWGVuOiBpbml0aWFsaXppbmcgY3B1Nw0KWyAgICAx
LjUwMTU5Ml0gQ1BVNzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA3IFsw
eDQxM2ZkMGMxXQ0KWyAgICAxLjUwMTg0OV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTgN
ClsgICAgMS41MDE4ODZdIEdJQ3YzOiBDUFU4OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDggcmVnaW9u
IDA6MHgwMDAwMTAwMTAwMjQwMDAwDQpbICAgIDEuNTA4NDE5XSAtLS0tLS0tLS0tLS1bIGN1dCBo
ZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41MDg0MjNdIFdBUk5JTkc6IENQVTogOCBQSUQ6IDAg
YXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS41MDg0MjVdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjUwODQy
OV0gQ1BVOiA4IFBJRDogMCBDb21tOiBzd2FwcGVyLzggVGFpbnRlZDogRyAgICAgICAgVyAgICAg
ICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS41MDg0MzFdIHBzdGF0
ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41
MDg0MzNdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTA4NDM0XSBsciA6
IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjUwODQzNV0gc3AgOiBmZmZmODAwMDEx
YTczZTgwDQpbICAgIDEuNTA4NDM2XSB4Mjk6IGZmZmY4MDAwMTFhNzNlODAgeDI4OiAwMDAwMDAw
MDAwMDAwMDA4IA0KWyAgICAxLjUwODQzOF0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZm
ZjgwMDAxMjEwMDA3MCANClsgICAgMS41MDg0NDBdIHgyNTogZmZmZmZlMWZmZGUwZTgwMCB4MjQ6
IGZmZmY4MDAwMTIxMDAwMDAgDQpbICAgIDEuNTA4NDQzXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAg
eDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjUwODQ0NV0geDIxOiBmZmZmODAwMDExNzY4
OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41MDg0NDddIHgxOTogZmZmZjgwMDAx
MTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTA4NDQ5XSB4MTc6IDAwMDAw
MDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjUwODQ1MF0geDE1OiBm
ZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41MDg0NTJdIHgx
MzogZmZmZjgwMDAxMTZkNGNmNCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTA4NDU0
XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjUw
ODQ1Nl0geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzMDMwMzAzNDMyMzAzMCANClsgICAg
MS41MDg0NThdIHg3IDogMzEzMDMwMzEzMDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpb
ICAgIDEuNTA4NDYwXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAw
IA0KWyAgICAxLjUwODQ2Ml0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAw
ZmZmZiANClsgICAgMS41MDg0NjRdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAw
ZmZmZmZmZWQgDQpbICAgIDEuNTA4NDY2XSBDYWxsIHRyYWNlOg0KWyAgICAxLjUwODQ2OF0gIGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUwODQ3MF0gIGdpY19zdGFydGluZ19jcHUr
MHg0OC8weDkwDQpbICAgIDEuNTA4NDczXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0
NjANClsgICAgMS41MDg0NzRdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAx
LjUwODQ3N10gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjUwODQ3
OF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I1YSBdLS0tDQpbICAgIDEuNTA4NDg0XSBH
SUN2MzogQ1BVODogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAw
MDAzYTAwMDANClsgICAgMS41MDg1NTBdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41MDg1NThdIFhlbjogaW5pdGlh
bGl6aW5nIGNwdTgNClsgICAgMS41MDg1ODFdIENQVTg6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vz
c29yIDB4MDAwMDAwMDAwOCBbMHg0MTNmZDBjMV0NClsgICAgMS41MDg5MzJdIERldGVjdGVkIFBJ
UFQgSS1jYWNoZSBvbiBDUFU5DQpbICAgIDEuNTA4OTcwXSBHSUN2MzogQ1BVOTogZm91bmQgcmVk
aXN0cmlidXRvciA5IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDI2MDAwMA0KWyAgICAxLjUxNTUwM10g
LS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTE1NTA4XSBXQVJO
SU5HOiBDUFU6IDkgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMw
NjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTE1NTA5XSBNb2R1bGVzIGxpbmtl
ZCBpbjoNClsgICAgMS41MTU1MTNdIENQVTogOSBQSUQ6IDAgQ29tbTogc3dhcHBlci85IFRhaW50
ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpb
ICAgIDEuNTE1NTE1XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08g
QlRZUEU9LS0pDQpbICAgIDEuNTE1NTE2XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjUxNTUxOF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41MTU1
MTldIHNwIDogZmZmZjgwMDAxMWE3YmU4MA0KWyAgICAxLjUxNTUyMF0geDI5OiBmZmZmODAwMDEx
YTdiZTgwIHgyODogMDAwMDAwMDAwMDAwMDAwOSANClsgICAgMS41MTU1MjJdIHgyNzogMDAwMDAw
MDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIxMjAwNzAgDQpbICAgIDEuNTE1NTI0XSB4MjU6IGZm
ZmZmZTFmZmRlMGVjMDAgeDI0OiBmZmZmODAwMDEyMTIwMDAwIA0KWyAgICAxLjUxNTUyNl0geDIz
OiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41MTU1Mjhd
IHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTE1
NTMwXSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAx
LjUxNTUzMl0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsg
ICAgMS41MTU1MzRdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAg
DQpbICAgIDEuNTE1NTM2XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAw
MDAwIA0KWyAgICAxLjUxNTUzN10geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAw
MDAwMDAwMSANClsgICAgMS41MTU1MzldIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAz
MDMwMzYzMjMwMzAgDQpbICAgIDEuNTE1NTQxXSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAw
MDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjUxNTU0M10geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0
IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41MTU1NDVdIHgzIDogMDAwMDAwMDAwMDAwMDAx
MCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTE1NTQ3XSB4MSA6IDAwMDAwMDAwMDAw
MTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjUxNTU0OV0gQ2FsbCB0cmFjZToN
ClsgICAgMS41MTU1NTFdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MTU1NTRd
ICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjUxNTU1Nl0gIGNwdWhwX2ludm9r
ZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTE1NTU4XSAgbm90aWZ5X2NwdV9zdGFydGlu
ZysweGEwLzB4ZTANClsgICAgMS41MTU1NjBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgv
MHgxOTANClsgICAgMS41MTU1NjFdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNWIgXS0t
LQ0KWyAgICAxLjUxNTU2N10gR0lDdjM6IENQVTk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGlu
ZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2IwMDAwDQpbICAgIDEuNTE1NjI3XSBhcmNoX3RpbWVyOiBF
bmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEu
NTE1NjM1XSBYZW46IGluaXRpYWxpemluZyBjcHU5DQpbICAgIDEuNTE1NjU3XSBDUFU5OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMDkgWzB4NDEzZmQwYzFdDQpbICAgIDEu
NTE2MDA3XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTANClsgICAgMS41MTYwNDldIEdJ
Q3YzOiBDUFUxMDogZm91bmQgcmVkaXN0cmlidXRvciBhIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDI4
MDAwMA0KWyAgICAxLjUyMjY2OV0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0t
DQpbICAgIDEuNTIyNjczXSBXQVJOSU5HOiBDUFU6IDEwIFBJRDogMCBhdCBkcml2ZXJzL2lycWNo
aXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjUyMjY3NF0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTIyNjc4XSBDUFU6IDEwIFBJRDog
MCBDb21tOiBzd2FwcGVyLzEwIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFt
cGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTIyNjgxXSBwc3RhdGU6IDYwMDAwMWM1IChu
WkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNTIyNjgyXSBwYyA6IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUyMjY4NF0gbHIgOiBpdHNfY3B1X2luaXQr
MHg4MjAvMHhiMjANClsgICAgMS41MjI2ODVdIHNwIDogZmZmZjgwMDAxMWE4M2U4MA0KWyAgICAx
LjUyMjY4Nl0geDI5OiBmZmZmODAwMDExYTgzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAwYSANClsg
ICAgMS41MjI2ODhdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIxNDAwNzAg
DQpbICAgIDEuNTIyNjkwXSB4MjU6IGZmZmZmZTFmZmRlMGYwMDAgeDI0OiBmZmZmODAwMDEyMTQw
MDAwIA0KWyAgICAxLjUyMjY5Ml0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAx
MGZmOTAwMCANClsgICAgMS41MjI2OTRdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4
MDAwMTE2MjIzNTAgDQpbICAgIDEuNTIyNjk2XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBm
ZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjUyMjY5OF0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgx
NjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MjI3MDBdIHgxNTogZmZmZjgwMDAxMTZkNTBh
MCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTIyNzAyXSB4MTM6IGZmZmY4MDAwMTE2
ZDRjZjUgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjUyMjcwNF0geDExOiAwMDAwMDAw
MDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41MjI3MDZdIHg5IDogZmZm
ZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzMDM4MzIzMDMwMzEgDQpbICAgIDEuNTIyNzA4XSB4NyA6
IDMwMzAzMTMwMzAzMDMwNzggeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjUyMjcwOV0g
eDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41MjI3
MTFdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEu
NTIyNzEzXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAg
ICAxLjUyMjcxNl0gQ2FsbCB0cmFjZToNClsgICAgMS41MjI3MTddICBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS41MjI3MjBdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAg
ICAxLjUyMjcyM10gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTIy
NzI1XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS41MjI3MjddICBzZWNv
bmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41MjI3MjhdIC0tLVsgZW5kIHRy
YWNlIGY2ODcyOGEwZDMwNTNiNWMgXS0tLQ0KWyAgICAxLjUyMjczNF0gR0lDdjM6IENQVTEwOiB1
c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNjMDAwMA0KWyAg
ICAxLjUyMjgwMF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjUyMjgwOV0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTAN
ClsgICAgMS41MjI4MzNdIENQVTEwOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAw
MDAwMGEgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTIzMTkxXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUg
b24gQ1BVMTENClsgICAgMS41MjMyMzNdIEdJQ3YzOiBDUFUxMTogZm91bmQgcmVkaXN0cmlidXRv
ciBiIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDJhMDAwMA0KWyAgICAxLjUyOTg1M10gLS0tLS0tLS0t
LS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTI5ODU4XSBXQVJOSU5HOiBDUFU6
IDExIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUyOTg1OF0gTW9kdWxlcyBsaW5rZWQgaW46DQpb
ICAgIDEuNTI5ODYzXSBDUFU6IDExIFBJRDogMCBDb21tOiBzd2FwcGVyLzExIFRhaW50ZWQ6IEcg
ICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEu
NTI5ODY1XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9
LS0pDQpbICAgIDEuNTI5ODY2XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjUyOTg2OF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41Mjk4NjldIHNw
IDogZmZmZjgwMDAxMWE4YmU4MA0KWyAgICAxLjUyOTg3MF0geDI5OiBmZmZmODAwMDExYThiZTgw
IHgyODogMDAwMDAwMDAwMDAwMDAwYiANClsgICAgMS41Mjk4NzJdIHgyNzogMDAwMDAwMDAwMDAw
MDAwMCB4MjY6IGZmZmY4MDAwMTIxNjAwNzAgDQpbICAgIDEuNTI5ODc0XSB4MjU6IGZmZmZmZTFm
ZmRlMGY0MDAgeDI0OiBmZmZmODAwMDEyMTYwMDAwIA0KWyAgICAxLjUyOTg3Nl0geDIzOiBmZmZm
ODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41Mjk4NzhdIHgyMTog
ZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTI5ODgwXSB4
MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjUyOTg4
Ml0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41
Mjk4ODRdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAg
IDEuNTI5ODg2XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjUgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0K
WyAgICAxLjUyOTg4OF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAw
MSANClsgICAgMS41Mjk4OTBdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzMDYxMzIz
MDMwMzEgDQpbICAgIDEuNTI5ODkxXSB4NyA6IDMwMzAzMTMwMzAzMDMwNzggeDYgOiAwMDAwMDAw
MDAwMDAwMDAzIA0KWyAgICAxLjUyOTg5M10geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZm
ZmZkZmZmZmUwMDAwMCANClsgICAgMS41Mjk4OTVdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6
IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTI5ODk3XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAg
eDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjUyOTg5OV0gQ2FsbCB0cmFjZToNClsgICAg
MS41Mjk5MDFdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41Mjk5MDRdICBnaWNf
c3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjUyOTkwN10gIGNwdWhwX2ludm9rZV9jYWxs
YmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTI5OTA5XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEw
LzB4ZTANClsgICAgMS41Mjk5MTFdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTAN
ClsgICAgMS41Mjk5MTJdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNWQgXS0tLQ0KWyAg
ICAxLjUyOTkxOF0gR0lDdjM6IENQVTExOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFi
bGUgQDB4MDAwMDA4MDAwMDNkMDAwMA0KWyAgICAxLjUyOTk3OF0gYXJjaF90aW1lcjogRW5hYmxp
bmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjUyOTk4
Nl0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTENClsgICAgMS41MzAwMDddIENQVTExOiBCb290ZWQg
c2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMGIgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTMw
MjYyXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTINClsgICAgMS41MzAzMDddIEdJQ3Yz
OiBDUFUxMjogZm91bmQgcmVkaXN0cmlidXRvciBjIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDJjMDAw
MA0KWyAgICAxLjUzNjkyN10gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpb
ICAgIDEuNTM2OTMyXSBXQVJOSU5HOiBDUFU6IDEyIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAv
aXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUz
NjkzMl0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTM2OTM2XSBDUFU6IDEyIFBJRDogMCBD
b21tOiBzd2FwcGVyLzEyIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVy
ZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTM2OTM4XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2
IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNTM2OTQxXSBwYyA6IGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUzNjk0Ml0gbHIgOiBpdHNfY3B1X2luaXQrMHg4
MjAvMHhiMjANClsgICAgMS41MzY5NDNdIHNwIDogZmZmZjgwMDAxMWE5M2U4MA0KWyAgICAxLjUz
Njk0NF0geDI5OiBmZmZmODAwMDExYTkzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAwYyANClsgICAg
MS41MzY5NDZdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIxODAwNzAgDQpb
ICAgIDEuNTM2OTQ5XSB4MjU6IGZmZmZmZTFmZmRlMGY4MDAgeDI0OiBmZmZmODAwMDEyMTgwMDAw
IA0KWyAgICAxLjUzNjk1MV0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZm
OTAwMCANClsgICAgMS41MzY5NTNdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAw
MTE2MjIzNTAgDQpbICAgIDEuNTM2OTU1XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZm
ZmZmZmZmZmZmZmZmIA0KWyAgICAxLjUzNjk1N10geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjog
MDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MzY5NThdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4
MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTM2OTYwXSB4MTM6IGZmZmY4MDAwMTE2ZDRj
ZjUgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjUzNjk2Ml0geDExOiAwMDAwMDAwMDAw
MDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41MzY5NjRdIHg5IDogZmZmZjgw
MDAxMDZkNjgzMCB4OCA6IDMwMzAzMDYzMzIzMDMwMzEgDQpbICAgIDEuNTM2OTY2XSB4NyA6IDMw
MzAzMTMwMzAzMDMwNzggeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjUzNjk2OF0geDUg
OiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41MzY5NzBd
IHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTM2
OTcyXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAx
LjUzNjk3NF0gQ2FsbCB0cmFjZToNClsgICAgMS41MzY5NzZdICBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMS41MzY5NzldICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAx
LjUzNjk4MV0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTM2OTgz
XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS41MzY5ODVdICBzZWNvbmRh
cnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41MzY5ODddIC0tLVsgZW5kIHRyYWNl
IGY2ODcyOGEwZDMwNTNiNWUgXS0tLQ0KWyAgICAxLjUzNjk5Ml0gR0lDdjM6IENQVTEyOiB1c2lu
ZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNlMDAwMA0KWyAgICAx
LjUzNzA1OV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVy
cmF0dW0gMTQxODA0MA0KWyAgICAxLjUzNzA2OV0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTINClsg
ICAgMS41MzcwOTJdIENQVTEyOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAw
MGMgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTM3MzQ0XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24g
Q1BVMTMNClsgICAgMS41MzczOTFdIEdJQ3YzOiBDUFUxMzogZm91bmQgcmVkaXN0cmlidXRvciBk
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDJlMDAwMA0KWyAgICAxLjU0NDAxMV0gLS0tLS0tLS0tLS0t
WyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTQ0MDE1XSBXQVJOSU5HOiBDUFU6IDEz
IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVf
aW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU0NDAxNl0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAg
IDEuNTQ0MDIwXSBDUFU6IDEzIFBJRDogMCBDb21tOiBzd2FwcGVyLzEzIFRhaW50ZWQ6IEcgICAg
ICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTQ0
MDIyXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0p
DQpbICAgIDEuNTQ0MDI0XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU0
NDAyNl0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41NDQwMjddIHNwIDog
ZmZmZjgwMDAxMWE5YmU4MA0KWyAgICAxLjU0NDAyOF0geDI5OiBmZmZmODAwMDExYTliZTgwIHgy
ODogMDAwMDAwMDAwMDAwMDAwZCANClsgICAgMS41NDQwMzBdIHgyNzogMDAwMDAwMDAwMDAwMDAw
MCB4MjY6IGZmZmY4MDAwMTIxYTAwNzAgDQpbICAgIDEuNTQ0MDMyXSB4MjU6IGZmZmZmZTFmZmRl
MGZjMDAgeDI0OiBmZmZmODAwMDEyMWEwMDAwIA0KWyAgICAxLjU0NDAzNF0geDIzOiBmZmZmODAw
MDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41NDQwMzZdIHgyMTogZmZm
ZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTQ0MDM4XSB4MTk6
IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjU0NDA0MF0g
eDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41NDQw
NDJdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEu
NTQ0MDQ0XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjUgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAg
ICAxLjU0NDA0Nl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSAN
ClsgICAgMS41NDQwNDldIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzMDY1MzIzMDMw
MzEgDQpbICAgIDEuNTQ0MDUxXSB4NyA6IDMwMzAzMTMwMzAzMDMwNzggeDYgOiAwMDAwMDAwMDAw
MDAwMDAzIA0KWyAgICAxLjU0NDA1Ml0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZk
ZmZmZmUwMDAwMCANClsgICAgMS41NDQwNTRdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAw
MDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTQ0MDU2XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAg
OiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjU0NDA1OF0gQ2FsbCB0cmFjZToNClsgICAgMS41
NDQwNjBdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NDQwNjNdICBnaWNfc3Rh
cnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjU0NDA2NV0gIGNwdWhwX2ludm9rZV9jYWxsYmFj
aysweGE0LzB4NDYwDQpbICAgIDEuNTQ0MDY3XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4
ZTANClsgICAgMS41NDQwNzBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsg
ICAgMS41NDQwNzFdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNWYgXS0tLQ0KWyAgICAx
LjU0NDA3N10gR0lDdjM6IENQVTEzOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUg
QDB4MDAwMDA4MDAwMDNmMDAwMA0KWyAgICAxLjU0NDEzN10gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjU0NDE0NV0g
WGVuOiBpbml0aWFsaXppbmcgY3B1MTMNClsgICAgMS41NDQxNjZdIENQVTEzOiBCb290ZWQgc2Vj
b25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMGQgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTQ0NDgy
XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTQNClsgICAgMS41NDQ1MzBdIEdJQ3YzOiBD
UFUxNDogZm91bmQgcmVkaXN0cmlidXRvciBlIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDMwMDAwMA0K
WyAgICAxLjU1MTE1MF0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAg
IDEuNTUxMTU1XSBXQVJOSU5HOiBDUFU6IDE0IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJx
LWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU1MTE1
Nl0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTUxMTYwXSBDUFU6IDE0IFBJRDogMCBDb21t
OiBzd2FwcGVyLzE0IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1s
dHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTUxMTYyXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRB
SUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNTUxMTY0XSBwYyA6IGl0c19jcHVf
aW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU1MTE2NV0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAv
MHhiMjANClsgICAgMS41NTExNjZdIHNwIDogZmZmZjgwMDAxMWFhM2U4MA0KWyAgICAxLjU1MTE2
N10geDI5OiBmZmZmODAwMDExYWEzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAwZSANClsgICAgMS41
NTExNzBdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIxYzAwNzAgDQpbICAg
IDEuNTUxMTcyXSB4MjU6IGZmZmZmZTFmZmRlYTAwMDAgeDI0OiBmZmZmODAwMDEyMWMwMDAwIA0K
WyAgICAxLjU1MTE3NF0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAw
MCANClsgICAgMS41NTExNzZdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2
MjIzNTAgDQpbICAgIDEuNTUxMTc4XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZm
ZmZmZmZmZmZmIA0KWyAgICAxLjU1MTE4MF0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAw
MDAwMDAwMDAwMDAwMCANClsgICAgMS41NTExODJdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6
IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTUxMTg0XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjUg
eDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU1MTE4Nl0geDExOiAwMDAwMDAwMDAwMDAw
MDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41NTExODhdIHg5IDogZmZmZjgwMDAx
MDZkNjgzMCB4OCA6IDMwMzAzMDMwMzMzMDMwMzEgDQpbICAgIDEuNTUxMTg5XSB4NyA6IDMwMzAz
MTMwMzAzMDMwNzggeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjU1MTE5MV0geDUgOiAw
MDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41NTExOTNdIHgz
IDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTUxMTk1
XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjU1
MTE5N10gQ2FsbCB0cmFjZToNClsgICAgMS41NTExOTldICBpdHNfY3B1X2luaXQrMHg4MjQvMHhi
MjANClsgICAgMS41NTEyMDJdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjU1
MTIwNF0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTUxMjA2XSAg
bm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS41NTEyMDhdICBzZWNvbmRhcnlf
c3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41NTEyMTBdIC0tLVsgZW5kIHRyYWNlIGY2
ODcyOGEwZDMwNTNiNjAgXS0tLQ0KWyAgICAxLjU1MTIxNV0gR0lDdjM6IENQVTE0OiB1c2luZyBh
bGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjgwMDAwMA0KWyAgICAxLjU1
MTI4MV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0
dW0gMTQxODA0MA0KWyAgICAxLjU1MTI5MF0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTQNClsgICAg
MS41NTEzMTNdIENQVTE0OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMGUg
WzB4NDEzZmQwYzFdDQpbICAgIDEuNTUxNjU0XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MTUNClsgICAgMS41NTE3MDRdIEdJQ3YzOiBDUFUxNTogZm91bmQgcmVkaXN0cmlidXRvciBmIHJl
Z2lvbiAwOjB4MDAwMDEwMDEwMDMyMDAwMA0KWyAgICAxLjU1ODMyNF0gLS0tLS0tLS0tLS0tWyBj
dXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTU4MzI4XSBXQVJOSU5HOiBDUFU6IDE1IFBJ
RDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5p
dCsweDgyNC8weGIyMA0KWyAgICAxLjU1ODMyOV0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEu
NTU4MzMzXSBDUFU6IDE1IFBJRDogMCBDb21tOiBzd2FwcGVyLzE1IFRhaW50ZWQ6IEcgICAgICAg
IFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTU4MzM1
XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpb
ICAgIDEuNTU4MzM3XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU1ODMz
OV0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41NTgzMzldIHNwIDogZmZm
ZjgwMDAxMWFhYmU4MA0KWyAgICAxLjU1ODM0MF0geDI5OiBmZmZmODAwMDExYWFiZTgwIHgyODog
MDAwMDAwMDAwMDAwMDAwZiANClsgICAgMS41NTgzNDNdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4
MjY6IGZmZmY4MDAwMTIxZTAwNzAgDQpbICAgIDEuNTU4MzQ1XSB4MjU6IGZmZmZmZTFmZmRlYTA0
MDAgeDI0OiBmZmZmODAwMDEyMWUwMDAwIA0KWyAgICAxLjU1ODM0N10geDIzOiBmZmZmODAwMDEx
NGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41NTgzNDldIHgyMTogZmZmZjgw
MDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTU4MzUxXSB4MTk6IGZm
ZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjU1ODM1M10geDE3
OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41NTgzNTVd
IHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTU4
MzU3XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjUgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAx
LjU1ODM1OV0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsg
ICAgMS41NTgzNjBdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzMDMyMzMzMDMwMzEg
DQpbICAgIDEuNTU4MzYyXSB4NyA6IDMwMzAzMTMwMzAzMDMwNzggeDYgOiAwMDAwMDAwMDAwMDAw
MDAzIA0KWyAgICAxLjU1ODM2NF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZm
ZmUwMDAwMCANClsgICAgMS41NTgzNjZdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAw
MDAwMDAwMGZmZmYgDQpbICAgIDEuNTU4MzY4XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAw
MDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjU1ODM3MF0gQ2FsbCB0cmFjZToNClsgICAgMS41NTgz
NzJdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NTgzNzVdICBnaWNfc3RhcnRp
bmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjU1ODM3N10gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysw
eGE0LzB4NDYwDQpbICAgIDEuNTU4Mzc5XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTAN
ClsgICAgMS41NTgzODJdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAg
MS41NTgzODNdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNjEgXS0tLQ0KWyAgICAxLjU1
ODM4OV0gR0lDdjM6IENQVTE1OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4
MDAwMDA4MDAwMjgxMDAwMA0KWyAgICAxLjU1ODQ0OF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9j
YWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjU1ODQ1Nl0gWGVu
OiBpbml0aWFsaXppbmcgY3B1MTUNClsgICAgMS41NTg0NzhdIENQVTE1OiBCb290ZWQgc2Vjb25k
YXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMGYgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTU4ODI2XSBE
ZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTYNClsgICAgMS41NTg4NzldIEdJQ3YzOiBDUFUx
NjogZm91bmQgcmVkaXN0cmlidXRvciAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMzQwMDAwDQpb
ICAgIDEuNTY1NDk5XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAg
MS41NjU1MDNdIFdBUk5JTkc6IENQVTogMTYgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEt
Z2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTY1NTA0
XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41NjU1MDhdIENQVTogMTYgUElEOiAwIENvbW06
IHN3YXBwZXIvMTYgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0
cy1zdGFuZGFyZCsgIzENClsgICAgMS41NjU1MTBdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJ
RiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41NjU1MTJdIHBjIDogaXRzX2NwdV9p
bml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTY1NTEzXSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8w
eGIyMA0KWyAgICAxLjU2NTUxNF0gc3AgOiBmZmZmODAwMDExYWIzZTgwDQpbICAgIDEuNTY1NTE1
XSB4Mjk6IGZmZmY4MDAwMTFhYjNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjU2
NTUxOF0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjIwMDA3MCANClsgICAg
MS41NjU1MjBdIHgyNTogZmZmZmZlMWZmZGVhMDgwMCB4MjQ6IGZmZmY4MDAwMTIyMDAwMDAgDQpb
ICAgIDEuNTY1NTIyXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAw
IA0KWyAgICAxLjU2NTUyNF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYy
MjM1MCANClsgICAgMS41NjU1MjZdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZm
ZmZmZmZmZmYgDQpbICAgIDEuNTY1NTI4XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAw
MDAwMDAwMDAwMDAwIA0KWyAgICAxLjU2NTUzMF0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDog
MDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41NjU1MzJdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4
MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTY1NTM0XSB4MTE6IDAwMDAwMDAwMDAwMDAw
MDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjU2NTUzNV0geDkgOiBmZmZmODAwMDEw
NmQ2ODMwIHg4IDogMzAzNDMzMzAzMDMxMzAzMCANClsgICAgMS41NjU1MzddIHg3IDogMzEzMDMw
MzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTY1NTM5XSB4NSA6IDAw
MDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjU2NTU0MV0geDMg
OiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS41NjU1NDNd
IHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTY1
NTQ1XSBDYWxsIHRyYWNlOg0KWyAgICAxLjU2NTU0N10gIGl0c19jcHVfaW5pdCsweDgyNC8weGIy
MA0KWyAgICAxLjU2NTU1MF0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTY1
NTUyXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41NjU1NTRdICBu
b3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjU2NTU1Nl0gIHNlY29uZGFyeV9z
dGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjU2NTU1OF0gLS0tWyBlbmQgdHJhY2UgZjY4
NzI4YTBkMzA1M2I2MiBdLS0tDQpbICAgIDEuNTY1NTYzXSBHSUN2MzogQ1BVMTY6IHVzaW5nIGFs
bG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyODIwMDAwDQpbICAgIDEuNTY1
NjI5XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1
bSAxNDE4MDQwDQpbICAgIDEuNTY1NjM4XSBYZW46IGluaXRpYWxpemluZyBjcHUxNg0KWyAgICAx
LjU2NTY2MV0gQ1BVMTY6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwMCBb
MHg0MTNmZDBjMV0NClsgICAgMS41NjU5MDldIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUx
Nw0KWyAgICAxLjU2NTk2Ml0gR0lDdjM6IENQVTE3OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwMSBy
ZWdpb24gMDoweDAwMDAxMDAxMDAzNjAwMDANClsgICAgMS41NzI1ODNdIC0tLS0tLS0tLS0tLVsg
Y3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjU3MjU4N10gV0FSTklORzogQ1BVOiAxNyBQ
SUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2lu
aXQrMHg4MjQvMHhiMjANClsgICAgMS41NzI1ODhdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAx
LjU3MjU5Ml0gQ1BVOiAxNyBQSUQ6IDAgQ29tbTogc3dhcHBlci8xNyBUYWludGVkOiBHICAgICAg
ICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjU3MjU5
NF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0K
WyAgICAxLjU3MjU5Nl0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NzI1
OThdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTcyNTk5XSBzcCA6IGZm
ZmY4MDAwMTFhYmJlODANClsgICAgMS41NzI2MDBdIHgyOTogZmZmZjgwMDAxMWFiYmU4MCB4Mjg6
IDAwMDAwMDAwMDAwMDAwMTEgDQpbICAgIDEuNTcyNjAyXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAg
eDI2OiBmZmZmODAwMDEyMjIwMDcwIA0KWyAgICAxLjU3MjYwNF0geDI1OiBmZmZmZmUxZmZkZWEw
YzAwIHgyNDogZmZmZjgwMDAxMjIyMDAwMCANClsgICAgMS41NzI2MDZdIHgyMzogZmZmZjgwMDAx
MTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTcyNjA4XSB4MjE6IGZmZmY4
MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjU3MjYxMF0geDE5OiBm
ZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41NzI2MTJdIHgx
NzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTcyNjE0
XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjU3
MjYxNl0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAg
MS41NzI2MThdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpb
ICAgIDEuNTcyNjIwXSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDM2MzMzMDMwMzEzMDMw
IA0KWyAgICAxLjU3MjYyMl0geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAw
MDAwMyANClsgICAgMS41NzI2MjRdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZm
ZmZlMDAwMDAgDQpbICAgIDEuNTcyNjI1XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAw
MDAwMDAwMDBmZmZmIA0KWyAgICAxLjU3MjYyOF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDog
MDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41NzI2MzBdIENhbGwgdHJhY2U6DQpbICAgIDEuNTcy
NjMyXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTcyNjM1XSAgZ2ljX3N0YXJ0
aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41NzI2MzddICBjcHVocF9pbnZva2VfY2FsbGJhY2sr
MHhhNC8weDQ2MA0KWyAgICAxLjU3MjYzOV0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUw
DQpbICAgIDEuNTcyNjQxXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAg
IDEuNTcyNjQzXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjYzIF0tLS0NClsgICAgMS41
NzI2NDldIEdJQ3YzOiBDUFUxNzogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAw
eDAwMDAwODAwMDI4MzAwMDANClsgICAgMS41NzI3MDhdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxv
Y2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41NzI3MTddIFhl
bjogaW5pdGlhbGl6aW5nIGNwdTE3DQpbICAgIDEuNTcyNzM5XSBDUFUxNzogQm9vdGVkIHNlY29u
ZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTAxIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjU3MzA2Nl0g
RGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE4DQpbICAgIDEuNTczMTIzXSBHSUN2MzogQ1BV
MTg6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTAyIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDM4MDAwMA0K
WyAgICAxLjU3OTc0NF0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAg
IDEuNTc5NzQ4XSBXQVJOSU5HOiBDUFU6IDE4IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJx
LWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU3OTc0
OV0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTc5NzUzXSBDUFU6IDE4IFBJRDogMCBDb21t
OiBzd2FwcGVyLzE4IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1s
dHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTc5NzU1XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRB
SUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNTc5NzU3XSBwYyA6IGl0c19jcHVf
aW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU3OTc1OF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAv
MHhiMjANClsgICAgMS41Nzk3NTldIHNwIDogZmZmZjgwMDAxMWFjM2U4MA0KWyAgICAxLjU3OTc2
MF0geDI5OiBmZmZmODAwMDExYWMzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxMiANClsgICAgMS41
Nzk3NjNdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIyNDAwNzAgDQpbICAg
IDEuNTc5NzY1XSB4MjU6IGZmZmZmZTFmZmRlYTEwMDAgeDI0OiBmZmZmODAwMDEyMjQwMDAwIA0K
WyAgICAxLjU3OTc2N10geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAw
MCANClsgICAgMS41Nzk3NjldIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2
MjIzNTAgDQpbICAgIDEuNTc5NzcxXSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZm
ZmZmZmZmZmZmIA0KWyAgICAxLjU3OTc3M10geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAw
MDAwMDAwMDAwMDAwMCANClsgICAgMS41Nzk3NzVdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6
IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTc5Nzc3XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcg
eDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU3OTc3OF0geDExOiAwMDAwMDAwMDAwMDAw
MDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41Nzk3ODBdIHg5IDogZmZmZjgwMDAx
MDZkNjgzMCB4OCA6IDMwMzgzMzMwMzAzMTMwMzAgDQpbICAgIDEuNTc5NzgyXSB4NyA6IDMxMzAz
MDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjU3OTc4NF0geDUgOiAw
MDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41Nzk3ODZdIHgz
IDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTc5Nzg4
XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjU3
OTc5MF0gQ2FsbCB0cmFjZToNClsgICAgMS41Nzk3OTJdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhi
MjANClsgICAgMS41Nzk3OTVdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjU3
OTc5N10gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTc5Nzk5XSAg
bm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS41Nzk4MDJdICBzZWNvbmRhcnlf
c3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41Nzk4MDNdIC0tLVsgZW5kIHRyYWNlIGY2
ODcyOGEwZDMwNTNiNjQgXS0tLQ0KWyAgICAxLjU3OTgwOV0gR0lDdjM6IENQVTE4OiB1c2luZyBh
bGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjg0MDAwMA0KWyAgICAxLjU3
OTg3Nl0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0
dW0gMTQxODA0MA0KWyAgICAxLjU3OTg4NV0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTgNClsgICAg
MS41Nzk5MTBdIENQVTE4OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMDIg
WzB4NDEzZmQwYzFdDQpbICAgIDEuNTgwMjQ2XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MTkNClsgICAgMS41ODAzMDRdIEdJQ3YzOiBDUFUxOTogZm91bmQgcmVkaXN0cmlidXRvciAxMDMg
cmVnaW9uIDA6MHgwMDAwMTAwMTAwM2EwMDAwDQpbICAgIDEuNTg2OTI1XSAtLS0tLS0tLS0tLS1b
IGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41ODY5MzBdIFdBUk5JTkc6IENQVTogMTkg
UElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9p
bml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTg2OTMxXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAg
MS41ODY5MzVdIENQVTogMTkgUElEOiAwIENvbW06IHN3YXBwZXIvMTkgVGFpbnRlZDogRyAgICAg
ICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS41ODY5
MzddIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkN
ClsgICAgMS41ODY5MzldIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTg2
OTQwXSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjU4Njk0MV0gc3AgOiBm
ZmZmODAwMDExYWNiZTgwDQpbICAgIDEuNTg2OTQyXSB4Mjk6IGZmZmY4MDAwMTFhY2JlODAgeDI4
OiAwMDAwMDAwMDAwMDAwMDEzIA0KWyAgICAxLjU4Njk0NF0geDI3OiAwMDAwMDAwMDAwMDAwMDAw
IHgyNjogZmZmZjgwMDAxMjI2MDA3MCANClsgICAgMS41ODY5NDZdIHgyNTogZmZmZmZlMWZmZGVh
MTQwMCB4MjQ6IGZmZmY4MDAwMTIyNjAwMDAgDQpbICAgIDEuNTg2OTQ4XSB4MjM6IGZmZmY4MDAw
MTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjU4Njk1MF0geDIxOiBmZmZm
ODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41ODY5NTJdIHgxOTog
ZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTg2OTU0XSB4
MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU4Njk1
Nl0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41
ODY5NThdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAg
IDEuNTg2OTYwXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0K
WyAgICAxLjU4Njk2Ml0geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzA2MTMzMzAzMDMxMzAz
MCANClsgICAgMS41ODY5NjNdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAw
MDAwMDMgDQpbICAgIDEuNTg2OTY1XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRm
ZmZmZTAwMDAwIA0KWyAgICAxLjU4Njk2N10geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAw
MDAwMDAwMDAwZmZmZiANClsgICAgMS41ODY5NjldIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6
IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTg2OTcxXSBDYWxsIHRyYWNlOg0KWyAgICAxLjU4
Njk3M10gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU4Njk3Nl0gIGdpY19zdGFy
dGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTg2OTc4XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNr
KzB4YTQvMHg0NjANClsgICAgMS41ODY5ODBdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhl
MA0KWyAgICAxLjU4Njk4M10gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAg
ICAxLjU4Njk4NF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2NSBdLS0tDQpbICAgIDEu
NTg2OTkwXSBHSUN2MzogQ1BVMTk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBA
MHgwMDAwMDgwMDAyODUwMDAwDQpbICAgIDEuNTg3MDUwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBs
b2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTg3MDU5XSBY
ZW46IGluaXRpYWxpemluZyBjcHUxOQ0KWyAgICAxLjU4NzA4MV0gQ1BVMTk6IEJvb3RlZCBzZWNv
bmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwMyBbMHg0MTNmZDBjMV0NClsgICAgMS41ODc0Mzdd
IERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMA0KWyAgICAxLjU4NzQ5OF0gR0lDdjM6IENQ
VTIwOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwNCByZWdpb24gMDoweDAwMDAxMDAxMDAzYzAwMDAN
ClsgICAgMS41OTQxMThdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAg
ICAxLjU5NDEyMl0gV0FSTklORzogQ1BVOiAyMCBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2ly
cS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41OTQx
MjNdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjU5NDEyN10gQ1BVOiAyMCBQSUQ6IDAgQ29t
bTogc3dhcHBlci8yMCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUt
bHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjU5NDEyOV0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBk
QUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjU5NDEzMV0gcGMgOiBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41OTQxMzJdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIw
LzB4YjIwDQpbICAgIDEuNTk0MTMzXSBzcCA6IGZmZmY4MDAwMTFhZDNlODANClsgICAgMS41OTQx
MzRdIHgyOTogZmZmZjgwMDAxMWFkM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTQgDQpbICAgIDEu
NTk0MTM3XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMjgwMDcwIA0KWyAg
ICAxLjU5NDEzOV0geDI1OiBmZmZmZmUxZmZkZWExODAwIHgyNDogZmZmZjgwMDAxMjI4MDAwMCAN
ClsgICAgMS41OTQxNDFdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkw
MDAgDQpbICAgIDEuNTk0MTQzXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDEx
NjIyMzUwIA0KWyAgICAxLjU5NDE0NV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZm
ZmZmZmZmZmZmZiANClsgICAgMS41OTQxNDddIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAw
MDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTk0MTQ5XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0
OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjU5NDE1MV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3
IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41OTQxNTNdIHgxMTogMDAwMDAwMDAwMDAw
MDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTk0MTU1XSB4OSA6IGZmZmY4MDAw
MTA2ZDY4MzAgeDggOiAzMDYzMzMzMDMwMzEzMDMwIA0KWyAgICAxLjU5NDE1N10geDcgOiAzMTMw
MzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41OTQxNThdIHg1IDog
MDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTk0MTYwXSB4
MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjU5NDE2
Ml0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41
OTQxNjRdIENhbGwgdHJhY2U6DQpbICAgIDEuNTk0MTY2XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4
YjIwDQpbICAgIDEuNTk0MTY5XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41
OTQxNzFdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU5NDE3M10g
IG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTk0MTc1XSAgc2Vjb25kYXJ5
X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTk0MTc3XSAtLS1bIGVuZCB0cmFjZSBm
Njg3MjhhMGQzMDUzYjY2IF0tLS0NClsgICAgMS41OTQxODNdIEdJQ3YzOiBDUFUyMDogdXNpbmcg
YWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4NjAwMDANClsgICAgMS41
OTQyNDhdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJh
dHVtIDE0MTgwNDANClsgICAgMS41OTQyNThdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTIwDQpbICAg
IDEuNTk0MjgzXSBDUFUyMDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTA0
IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjU5NDU5OV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQ
VTIxDQpbICAgIDEuNTk0NjYwXSBHSUN2MzogQ1BVMjE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTA1
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDNlMDAwMA0KWyAgICAxLjYwMTI4MV0gLS0tLS0tLS0tLS0t
WyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNjAxMjg2XSBXQVJOSU5HOiBDUFU6IDIx
IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVf
aW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYwMTI4N10gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAg
IDEuNjAxMjkxXSBDUFU6IDIxIFBJRDogMCBDb21tOiBzd2FwcGVyLzIxIFRhaW50ZWQ6IEcgICAg
ICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNjAx
MjkzXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0p
DQpbICAgIDEuNjAxMjk0XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYw
MTI5Nl0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS42MDEyOTddIHNwIDog
ZmZmZjgwMDAxMWFkYmU4MA0KWyAgICAxLjYwMTI5OF0geDI5OiBmZmZmODAwMDExYWRiZTgwIHgy
ODogMDAwMDAwMDAwMDAwMDAxNSANClsgICAgMS42MDEzMDFdIHgyNzogMDAwMDAwMDAwMDAwMDAw
MCB4MjY6IGZmZmY4MDAwMTIyYTAwNzAgDQpbICAgIDEuNjAxMzAzXSB4MjU6IGZmZmZmZTFmZmRl
YTFjMDAgeDI0OiBmZmZmODAwMDEyMmEwMDAwIA0KWyAgICAxLjYwMTMwNV0geDIzOiBmZmZmODAw
MDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS42MDEzMDddIHgyMTogZmZm
ZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNjAxMzA5XSB4MTk6
IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjYwMTMxMF0g
eDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42MDEz
MTJdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEu
NjAxMzE0XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAg
ICAxLjYwMTMxNl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSAN
ClsgICAgMS42MDEzMThdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwNjUzMzMwMzAzMTMw
MzAgDQpbICAgIDEuNjAxMzIwXSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAw
MDAwMDAzIA0KWyAgICAxLjYwMTMyMl0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZk
ZmZmZmUwMDAwMCANClsgICAgMS42MDEzMjRdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAw
MDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjAxMzI2XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAg
OiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjYwMTMyOF0gQ2FsbCB0cmFjZToNClsgICAgMS42
MDEzMjldICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MDEzMzJdICBnaWNfc3Rh
cnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjYwMTMzNV0gIGNwdWhwX2ludm9rZV9jYWxsYmFj
aysweGE0LzB4NDYwDQpbICAgIDEuNjAxMzM3XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4
ZTANClsgICAgMS42MDEzNDBdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsg
ICAgMS42MDEzNDFdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNjcgXS0tLQ0KWyAgICAx
LjYwMTM0N10gR0lDdjM6IENQVTIxOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUg
QDB4MDAwMDA4MDAwMjg3MDAwMA0KWyAgICAxLjYwMTQwNl0gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjYwMTQxNV0g
WGVuOiBpbml0aWFsaXppbmcgY3B1MjENClsgICAgMS42MDE0MzddIENQVTIxOiBCb290ZWQgc2Vj
b25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMDUgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjAxNjg5
XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjINClsgICAgMS42MDE3NTVdIEdJQ3YzOiBD
UFUyMjogZm91bmQgcmVkaXN0cmlidXRvciAxMDYgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNDAwMDAw
DQpbICAgIDEuNjA4Mzc2XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsg
ICAgMS42MDgzODFdIFdBUk5JTkc6IENQVTogMjIgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9p
cnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjA4
MzgyXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS42MDgzODZdIENQVTogMjIgUElEOiAwIENv
bW06IHN3YXBwZXIvMjIgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJl
LWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS42MDgzODhdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3Yg
ZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS42MDgzOTBdIHBjIDogaXRzX2Nw
dV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjA4MzkxXSBsciA6IGl0c19jcHVfaW5pdCsweDgy
MC8weGIyMA0KWyAgICAxLjYwODM5Ml0gc3AgOiBmZmZmODAwMDExYWUzZTgwDQpbICAgIDEuNjA4
MzkzXSB4Mjk6IGZmZmY4MDAwMTFhZTNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDE2IA0KWyAgICAx
LjYwODM5Nl0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjJjMDA3MCANClsg
ICAgMS42MDgzOThdIHgyNTogZmZmZmZlMWZmZGVhMjAwMCB4MjQ6IGZmZmY4MDAwMTIyYzAwMDAg
DQpbICAgIDEuNjA4NDAwXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5
MDAwIA0KWyAgICAxLjYwODQwMV0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAx
MTYyMjM1MCANClsgICAgMS42MDg0MDNdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZm
ZmZmZmZmZmZmZmYgDQpbICAgIDEuNjA4NDA1XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAw
MDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYwODQwN10geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgx
NDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS42MDg0MDldIHgxMzogZmZmZjgwMDAxMTZkNGNm
NyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjA4NDExXSB4MTE6IDAwMDAwMDAwMDAw
MDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjYwODQxM10geDkgOiBmZmZmODAw
MDEwNmQ2ODMwIHg4IDogMzAzMDM0MzAzMDMxMzAzMCANClsgICAgMS42MDg0MTVdIHg3IDogMzEz
MDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjA4NDE3XSB4NSA6
IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjYwODQxOV0g
eDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42MDg0
MjFdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEu
NjA4NDIzXSBDYWxsIHRyYWNlOg0KWyAgICAxLjYwODQyNV0gIGl0c19jcHVfaW5pdCsweDgyNC8w
eGIyMA0KWyAgICAxLjYwODQyN10gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEu
NjA4NDMwXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42MDg0MzJd
ICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjYwODQzNF0gIHNlY29uZGFy
eV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjYwODQzNl0gLS0tWyBlbmQgdHJhY2Ug
ZjY4NzI4YTBkMzA1M2I2OCBdLS0tDQpbICAgIDEuNjA4NDQxXSBHSUN2MzogQ1BVMjI6IHVzaW5n
IGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyODgwMDAwDQpbICAgIDEu
NjA4NTA3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJy
YXR1bSAxNDE4MDQwDQpbICAgIDEuNjA4NTE2XSBYZW46IGluaXRpYWxpemluZyBjcHUyMg0KWyAg
ICAxLjYwODU0Ml0gQ1BVMjI6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEw
NiBbMHg0MTNmZDBjMV0NClsgICAgMS42MDg4NzBdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBD
UFUyMw0KWyAgICAxLjYwODkzNl0gR0lDdjM6IENQVTIzOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEw
NyByZWdpb24gMDoweDAwMDAxMDAxMDA0MjAwMDANClsgICAgMS42MTU1NThdIC0tLS0tLS0tLS0t
LVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjYxNTU2M10gV0FSTklORzogQ1BVOiAy
MyBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1
X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MTU1NjNdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAg
ICAxLjYxNTU2OF0gQ1BVOiAyMyBQSUQ6IDAgQ29tbTogc3dhcHBlci8yMyBUYWludGVkOiBHICAg
ICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjYx
NTU3MF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0t
KQ0KWyAgICAxLjYxNTU3MV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42
MTU1NzNdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjE1NTc0XSBzcCA6
IGZmZmY4MDAwMTFhZWJlODANClsgICAgMS42MTU1NzVdIHgyOTogZmZmZjgwMDAxMWFlYmU4MCB4
Mjg6IDAwMDAwMDAwMDAwMDAwMTcgDQpbICAgIDEuNjE1NTc3XSB4Mjc6IDAwMDAwMDAwMDAwMDAw
MDAgeDI2OiBmZmZmODAwMDEyMmUwMDcwIA0KWyAgICAxLjYxNTU3OV0geDI1OiBmZmZmZmUxZmZk
ZWEyNDAwIHgyNDogZmZmZjgwMDAxMjJlMDAwMCANClsgICAgMS42MTU1ODFdIHgyMzogZmZmZjgw
MDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNjE1NTgzXSB4MjE6IGZm
ZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjYxNTU4NV0geDE5
OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS42MTU1ODdd
IHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjE1
NTg5XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAx
LjYxNTU5MV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsg
ICAgMS42MTU1OTNdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEg
DQpbICAgIDEuNjE1NTk1XSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDMyMzQzMDMwMzEz
MDMwIA0KWyAgICAxLjYxNTU5N10geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAw
MDAwMDAwMyANClsgICAgMS42MTU1OTldIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZm
ZGZmZmZlMDAwMDAgDQpbICAgIDEuNjE1NjAxXSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAw
MDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjYxNTYwMl0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgw
IDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS42MTU2MDVdIENhbGwgdHJhY2U6DQpbICAgIDEu
NjE1NjA2XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjE1NjA5XSAgZ2ljX3N0
YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS42MTU2MTJdICBjcHVocF9pbnZva2VfY2FsbGJh
Y2srMHhhNC8weDQ2MA0KWyAgICAxLjYxNTYxNF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8w
eGUwDQpbICAgIDEuNjE1NjE2XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpb
ICAgIDEuNjE1NjE4XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjY5IF0tLS0NClsgICAg
MS42MTU2MjNdIEdJQ3YzOiBDUFUyMzogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDI4OTAwMDANClsgICAgMS42MTU2ODJdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS42MTU2OTFd
IFhlbjogaW5pdGlhbGl6aW5nIGNwdTIzDQpbICAgIDEuNjE1NzEzXSBDUFUyMzogQm9vdGVkIHNl
Y29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTA3IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjYxNjA1
Nl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI0DQpbICAgIDEuNjE2MTI1XSBHSUN2Mzog
Q1BVMjQ6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTA4IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDQ0MDAw
MA0KWyAgICAxLjYyMjc0Nl0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpb
ICAgIDEuNjIyNzUxXSBXQVJOSU5HOiBDUFU6IDI0IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAv
aXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYy
Mjc1Ml0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNjIyNzU2XSBDUFU6IDI0IFBJRDogMCBD
b21tOiBzd2FwcGVyLzI0IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVy
ZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNjIyNzU4XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2
IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNjIyNzYwXSBwYyA6IGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYyMjc2MV0gbHIgOiBpdHNfY3B1X2luaXQrMHg4
MjAvMHhiMjANClsgICAgMS42MjI3NjJdIHNwIDogZmZmZjgwMDAxMWFmM2U4MA0KWyAgICAxLjYy
Mjc2M10geDI5OiBmZmZmODAwMDExYWYzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxOCANClsgICAg
MS42MjI3NjZdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIzMDAwNzAgDQpb
ICAgIDEuNjIyNzY4XSB4MjU6IGZmZmZmZTFmZmRlYTI4MDAgeDI0OiBmZmZmODAwMDEyMzAwMDAw
IA0KWyAgICAxLjYyMjc3MF0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZm
OTAwMCANClsgICAgMS42MjI3NzJdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAw
MTE2MjIzNTAgDQpbICAgIDEuNjIyNzc0XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZm
ZmZmZmZmZmZmZmZmIA0KWyAgICAxLjYyMjc3Nl0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjog
MDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42MjI3NzhdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4
MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNjIyNzgwXSB4MTM6IGZmZmY4MDAwMTE2ZDRj
ZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYyMjc4Ml0geDExOiAwMDAwMDAwMDAw
MDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS42MjI3ODRdIHg5IDogZmZmZjgw
MDAxMDZkNjgzMCB4OCA6IDMwMzQzNDMwMzAzMTMwMzAgDQpbICAgIDEuNjIyNzg2XSB4NyA6IDMx
MzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjYyMjc4N10geDUg
OiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS42MjI3ODld
IHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjIy
NzkxXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAx
LjYyMjc5M10gQ2FsbCB0cmFjZToNClsgICAgMS42MjI3OTVdICBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMS42MjI3OThdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAx
LjYyMjgwMF0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjIyODAz
XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS42MjI4MDVdICBzZWNvbmRh
cnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS42MjI4MDddIC0tLVsgZW5kIHRyYWNl
IGY2ODcyOGEwZDMwNTNiNmEgXS0tLQ0KWyAgICAxLjYyMjgxMl0gR0lDdjM6IENQVTI0OiB1c2lu
ZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjhhMDAwMA0KWyAgICAx
LjYyMjg4MV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVy
cmF0dW0gMTQxODA0MA0KWyAgICAxLjYyMjg5MF0gWGVuOiBpbml0aWFsaXppbmcgY3B1MjQNClsg
ICAgMS42MjI5MTZdIENQVTI0OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAx
MDggWzB4NDEzZmQwYzFdDQpbICAgIDEuNjIzMjUzXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24g
Q1BVMjUNClsgICAgMS42MjMzMjNdIEdJQ3YzOiBDUFUyNTogZm91bmQgcmVkaXN0cmlidXRvciAx
MDkgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNDYwMDAwDQpbICAgIDEuNjI5OTQ0XSAtLS0tLS0tLS0t
LS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS42Mjk5NDldIFdBUk5JTkc6IENQVTog
MjUgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2Nw
dV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjI5OTUwXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsg
ICAgMS42Mjk5NTRdIENQVTogMjUgUElEOiAwIENvbW06IHN3YXBwZXIvMjUgVGFpbnRlZDogRyAg
ICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS42
Mjk5NTZdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0t
LSkNClsgICAgMS42Mjk5NThdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEu
NjI5OTU5XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjYyOTk2MF0gc3Ag
OiBmZmZmODAwMDExYWZiZTgwDQpbICAgIDEuNjI5OTYxXSB4Mjk6IGZmZmY4MDAwMTFhZmJlODAg
eDI4OiAwMDAwMDAwMDAwMDAwMDE5IA0KWyAgICAxLjYyOTk2M10geDI3OiAwMDAwMDAwMDAwMDAw
MDAwIHgyNjogZmZmZjgwMDAxMjMyMDA3MCANClsgICAgMS42Mjk5NjVdIHgyNTogZmZmZmZlMWZm
ZGVhMmMwMCB4MjQ6IGZmZmY4MDAwMTIzMjAwMDAgDQpbICAgIDEuNjI5OTY3XSB4MjM6IGZmZmY4
MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjYyOTk2OV0geDIxOiBm
ZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42Mjk5NzFdIHgx
OTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjI5OTcz
XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYy
OTk3NV0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAg
MS42Mjk5NzddIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpb
ICAgIDEuNjI5OTc5XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAx
IA0KWyAgICAxLjYyOTk4MV0geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzNjM0MzAzMDMx
MzAzMCANClsgICAgMS42Mjk5ODNdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAw
MDAwMDAwMDMgDQpbICAgIDEuNjI5OTg1XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZm
ZmRmZmZmZTAwMDAwIA0KWyAgICAxLjYyOTk4N10geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDog
MDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42Mjk5ODldIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4
MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNjI5OTkxXSBDYWxsIHRyYWNlOg0KWyAgICAx
LjYyOTk5M10gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYyOTk5Nl0gIGdpY19z
dGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNjI5OTk4XSAgY3B1aHBfaW52b2tlX2NhbGxi
YWNrKzB4YTQvMHg0NjANClsgICAgMS42MzAwMDBdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAv
MHhlMA0KWyAgICAxLjYzMDAwM10gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0K
WyAgICAxLjYzMDAwNF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2YiBdLS0tDQpbICAg
IDEuNjMwMDEwXSBHSUN2MzogQ1BVMjU6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwMDAyOGIwMDAwDQpbICAgIDEuNjMwMDY5XSBhcmNoX3RpbWVyOiBFbmFibGlu
ZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjMwMDc4
XSBYZW46IGluaXRpYWxpemluZyBjcHUyNQ0KWyAgICAxLjYzMDEwMV0gQ1BVMjU6IEJvb3RlZCBz
ZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwOSBbMHg0MTNmZDBjMV0NClsgICAgMS42MzAz
NThdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyNg0KWyAgICAxLjYzMDQzMV0gR0lDdjM6
IENQVTI2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwYSByZWdpb24gMDoweDAwMDAxMDAxMDA0ODAw
MDANClsgICAgMS42MzcwNTNdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0K
WyAgICAxLjYzNzA1N10gV0FSTklORzogQ1BVOiAyNiBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlw
L2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42
MzcwNThdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjYzNzA2Ml0gQ1BVOiAyNiBQSUQ6IDAg
Q29tbTogc3dhcHBlci8yNiBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBl
cmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjYzNzA2NF0gcHN0YXRlOiA2MDAwMDFjNSAoblpD
diBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjYzNzA2Nl0gcGMgOiBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MzcwNjddIGxyIDogaXRzX2NwdV9pbml0KzB4
ODIwLzB4YjIwDQpbICAgIDEuNjM3MDY4XSBzcCA6IGZmZmY4MDAwMTFiMDNlODANClsgICAgMS42
MzcwNjldIHgyOTogZmZmZjgwMDAxMWIwM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMWEgDQpbICAg
IDEuNjM3MDcxXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMzQwMDcwIA0K
WyAgICAxLjYzNzA3NF0geDI1OiBmZmZmZmUxZmZkZWEzMDAwIHgyNDogZmZmZjgwMDAxMjM0MDAw
MCANClsgICAgMS42MzcwNzVdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBm
ZjkwMDAgDQpbICAgIDEuNjM3MDc3XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAw
MDExNjIyMzUwIA0KWyAgICAxLjYzNzA3OV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZm
ZmZmZmZmZmZmZmZmZiANClsgICAgMS42MzcwODFdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6
IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjM3MDgzXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAg
eDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjYzNzA4NV0geDEzOiBmZmZmODAwMDExNmQ0
Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42MzcwODddIHgxMTogMDAwMDAwMDAw
MDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjM3MDg5XSB4OSA6IGZmZmY4
MDAwMTA2ZDY4MzAgeDggOiAzMDM4MzQzMDMwMzEzMDMwIA0KWyAgICAxLjYzNzA5MV0geDcgOiAz
MTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS42MzcwOTNdIHg1
IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNjM3MDk1
XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjYz
NzA5N10geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAg
MS42MzcwOTldIENhbGwgdHJhY2U6DQpbICAgIDEuNjM3MTAwXSAgaXRzX2NwdV9pbml0KzB4ODI0
LzB4YjIwDQpbICAgIDEuNjM3MTAzXSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAg
MS42MzcxMDZdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjYzNzEw
OF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNjM3MTEwXSAgc2Vjb25k
YXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNjM3MTEyXSAtLS1bIGVuZCB0cmFj
ZSBmNjg3MjhhMGQzMDUzYjZjIF0tLS0NClsgICAgMS42MzcxMTddIEdJQ3YzOiBDUFUyNjogdXNp
bmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4YzAwMDANClsgICAg
MS42MzcxODRdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBl
cnJhdHVtIDE0MTgwNDANClsgICAgMS42MzcxOTNdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTI2DQpb
ICAgIDEuNjM3MjE5XSBDUFUyNjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAw
MTBhIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjYzNzQ3Ml0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9u
IENQVTI3DQpbICAgIDEuNjM3NTQ2XSBHSUN2MzogQ1BVMjc6IGZvdW5kIHJlZGlzdHJpYnV0b3Ig
MTBiIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDRhMDAwMA0KWyAgICAxLjY0NDE2OF0gLS0tLS0tLS0t
LS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNjQ0MTczXSBXQVJOSU5HOiBDUFU6
IDI3IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY0NDE3NF0gTW9kdWxlcyBsaW5rZWQgaW46DQpb
ICAgIDEuNjQ0MTc4XSBDUFU6IDI3IFBJRDogMCBDb21tOiBzd2FwcGVyLzI3IFRhaW50ZWQ6IEcg
ICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEu
NjQ0MTgwXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9
LS0pDQpbICAgIDEuNjQ0MTgyXSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjY0NDE4M10gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS42NDQxODRdIHNw
IDogZmZmZjgwMDAxMWIwYmU4MA0KWyAgICAxLjY0NDE4NV0geDI5OiBmZmZmODAwMDExYjBiZTgw
IHgyODogMDAwMDAwMDAwMDAwMDAxYiANClsgICAgMS42NDQxODddIHgyNzogMDAwMDAwMDAwMDAw
MDAwMCB4MjY6IGZmZmY4MDAwMTIzNjAwNzAgDQpbICAgIDEuNjQ0MTg5XSB4MjU6IGZmZmZmZTFm
ZmRlYTM0MDAgeDI0OiBmZmZmODAwMDEyMzYwMDAwIA0KWyAgICAxLjY0NDE5MV0geDIzOiBmZmZm
ODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS42NDQxOTRdIHgyMTog
ZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNjQ0MTk2XSB4
MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjY0NDE5
OF0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42
NDQyMDBdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAg
IDEuNjQ0MjAyXSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0K
WyAgICAxLjY0NDIwNF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAw
MSANClsgICAgMS42NDQyMDZdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwNjEzNDMwMzAz
MTMwMzAgDQpbICAgIDEuNjQ0MjA4XSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAw
MDAwMDAwMDAzIA0KWyAgICAxLjY0NDIxMF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZm
ZmZkZmZmZmUwMDAwMCANClsgICAgMS42NDQyMTJdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6
IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjQ0MjEzXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAg
eDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjY0NDIxNl0gQ2FsbCB0cmFjZToNClsgICAg
MS42NDQyMThdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NDQyMjFdICBnaWNf
c3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjY0NDIyM10gIGNwdWhwX2ludm9rZV9jYWxs
YmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjQ0MjI2XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEw
LzB4ZTANClsgICAgMS42NDQyMjhdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTAN
ClsgICAgMS42NDQyMjldIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNmQgXS0tLQ0KWyAg
ICAxLjY0NDIzNV0gR0lDdjM6IENQVTI3OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFi
bGUgQDB4MDAwMDA4MDAwMjhkMDAwMA0KWyAgICAxLjY0NDI5NV0gYXJjaF90aW1lcjogRW5hYmxp
bmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjY0NDMw
M10gWGVuOiBpbml0aWFsaXppbmcgY3B1MjcNClsgICAgMS42NDQzMjZdIENQVTI3OiBCb290ZWQg
c2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMGIgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjQ0
NjYwXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjgNClsgICAgMS42NDQ3MzddIEdJQ3Yz
OiBDUFUyODogZm91bmQgcmVkaXN0cmlidXRvciAxMGMgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNGMw
MDAwDQpbICAgIDEuNjUxMzU5XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0N
ClsgICAgMS42NTEzNjNdIFdBUk5JTkc6IENQVTogMjggUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hp
cC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEu
NjUxMzY0XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS42NTEzNjhdIENQVTogMjggUElEOiAw
IENvbW06IHN3YXBwZXIvMjggVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1w
ZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS42NTEzNzBdIHBzdGF0ZTogNjAwMDAxYzUgKG5a
Q3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS42NTEzNzJdIHBjIDogaXRz
X2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjUxMzczXSBsciA6IGl0c19jcHVfaW5pdCsw
eDgyMC8weGIyMA0KWyAgICAxLjY1MTM3NF0gc3AgOiBmZmZmODAwMDExYjEzZTgwDQpbICAgIDEu
NjUxMzc1XSB4Mjk6IGZmZmY4MDAwMTFiMTNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDFjIA0KWyAg
ICAxLjY1MTM3OF0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjM4MDA3MCAN
ClsgICAgMS42NTEzODBdIHgyNTogZmZmZmZlMWZmZGVhMzgwMCB4MjQ6IGZmZmY4MDAwMTIzODAw
MDAgDQpbICAgIDEuNjUxMzgyXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEw
ZmY5MDAwIA0KWyAgICAxLjY1MTM4M10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgw
MDAxMTYyMjM1MCANClsgICAgMS42NTEzODVdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZm
ZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjUxMzg3XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2
OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjY1MTM4OV0geDE1OiBmZmZmODAwMDExNmQ1MGEw
IHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS42NTEzOTFdIHgxMzogZmZmZjgwMDAxMTZk
NGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjUxMzkzXSB4MTE6IDAwMDAwMDAw
MDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjY1MTM5NV0geDkgOiBmZmZm
ODAwMDEwNmQ2ODMwIHg4IDogMzA2MzM0MzAzMDMxMzAzMCANClsgICAgMS42NTEzOTddIHg3IDog
MzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjUxMzk5XSB4
NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjY1MTQw
MV0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42
NTE0MDNdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAg
IDEuNjUxNDA1XSBDYWxsIHRyYWNlOg0KWyAgICAxLjY1MTQwNl0gIGl0c19jcHVfaW5pdCsweDgy
NC8weGIyMA0KWyAgICAxLjY1MTQwOV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAg
IDEuNjUxNDEyXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42NTE0
MTNdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjY1MTQxNl0gIHNlY29u
ZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjY1MTQxN10gLS0tWyBlbmQgdHJh
Y2UgZjY4NzI4YTBkMzA1M2I2ZSBdLS0tDQpbICAgIDEuNjUxNDIzXSBHSUN2MzogQ1BVMjg6IHVz
aW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyOGUwMDAwDQpbICAg
IDEuNjUxNDkwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0g
ZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjUxNDk5XSBYZW46IGluaXRpYWxpemluZyBjcHUyOA0K
WyAgICAxLjY1MTUyN10gQ1BVMjg6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAw
MDEwYyBbMHg0MTNmZDBjMV0NClsgICAgMS42NTE4NjZdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBv
biBDUFUyOQ0KWyAgICAxLjY1MTk0NV0gR0lDdjM6IENQVTI5OiBmb3VuZCByZWRpc3RyaWJ1dG9y
IDEwZCByZWdpb24gMDoweDAwMDAxMDAxMDA0ZTAwMDANClsgICAgMS42NTg1NjhdIC0tLS0tLS0t
LS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjY1ODU3Ml0gV0FSTklORzogQ1BV
OiAyOSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NTg1NzRdIE1vZHVsZXMgbGlua2VkIGluOg0K
WyAgICAxLjY1ODU3N10gQ1BVOiAyOSBQSUQ6IDAgQ29tbTogc3dhcHBlci8yOSBUYWludGVkOiBH
ICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAx
LjY1ODU4MF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBF
PS0tKQ0KWyAgICAxLjY1ODU4MV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS42NTg1ODNdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjU4NTg0XSBz
cCA6IGZmZmY4MDAwMTFiMWJlODANClsgICAgMS42NTg1ODVdIHgyOTogZmZmZjgwMDAxMWIxYmU4
MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMWQgDQpbICAgIDEuNjU4NTg3XSB4Mjc6IDAwMDAwMDAwMDAw
MDAwMDAgeDI2OiBmZmZmODAwMDEyM2EwMDcwIA0KWyAgICAxLjY1ODU4OV0geDI1OiBmZmZmZmUx
ZmZkZWEzYzAwIHgyNDogZmZmZjgwMDAxMjNhMDAwMCANClsgICAgMS42NTg1OTFdIHgyMzogZmZm
ZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNjU4NTkzXSB4MjE6
IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjY1ODU5NF0g
eDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS42NTg1
OTZdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEu
NjU4NTk4XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAg
ICAxLjY1ODYwMF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS42NTg2MDJdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAw
MDEgDQpbICAgIDEuNjU4NjA0XSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDY1MzQzMDMw
MzEzMDMwIA0KWyAgICAxLjY1ODYwNV0geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAw
MDAwMDAwMDAwMyANClsgICAgMS42NTg2MDddIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZm
ZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNjU4NjA5XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIg
OiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjY1ODYxMV0geDEgOiAwMDAwMDAwMDAwMDEwMDAw
IHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS42NTg2MTNdIENhbGwgdHJhY2U6DQpbICAg
IDEuNjU4NjE1XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjU4NjE3XSAgZ2lj
X3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS42NTg2MjBdICBjcHVocF9pbnZva2VfY2Fs
bGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjY1ODYyMl0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhh
MC8weGUwDQpbICAgIDEuNjU4NjI0XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkw
DQpbICAgIDEuNjU4NjI1XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjZmIF0tLS0NClsg
ICAgMS42NTg2MzFdIEdJQ3YzOiBDUFUyOTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRh
YmxlIEAweDAwMDAwODAwMDI4ZjAwMDANClsgICAgMS42NTg2OTddIGFyY2hfdGltZXI6IEVuYWJs
aW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS42NTg3
MDZdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTI5DQpbICAgIDEuNjU4NzMzXSBDUFUyOTogQm9vdGVk
IHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTBkIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjY1
OTA2M10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTMwDQpbICAgIDEuNjU5MTQzXSBHSUN2
MzogQ1BVMzA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTBlIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDUw
MDAwMA0KWyAgICAxLjY2NTc2Nl0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0t
DQpbICAgIDEuNjY1NzcxXSBXQVJOSU5HOiBDUFU6IDMwIFBJRDogMCBhdCBkcml2ZXJzL2lycWNo
aXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjY2NTc3Ml0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNjY1Nzc2XSBDUFU6IDMwIFBJRDog
MCBDb21tOiBzd2FwcGVyLzMwIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFt
cGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNjY1Nzc4XSBwc3RhdGU6IDYwMDAwMWM1IChu
WkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNjY1NzgwXSBwYyA6IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY2NTc4MV0gbHIgOiBpdHNfY3B1X2luaXQr
MHg4MjAvMHhiMjANClsgICAgMS42NjU3ODJdIHNwIDogZmZmZjgwMDAxMWIyM2U4MA0KWyAgICAx
LjY2NTc4NF0geDI5OiBmZmZmODAwMDExYjIzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxZSANClsg
ICAgMS42NjU3ODZdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIzYzAwNzAg
DQpbICAgIDEuNjY1Nzg4XSB4MjU6IGZmZmZmZTFmZmRlYTQwMDAgeDI0OiBmZmZmODAwMDEyM2Mw
MDAwIA0KWyAgICAxLjY2NTc5MF0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAx
MGZmOTAwMCANClsgICAgMS42NjU3OTJdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4
MDAwMTE2MjIzNTAgDQpbICAgIDEuNjY1Nzk0XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBm
ZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjY2NTc5Nl0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgx
NjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42NjU3OThdIHgxNTogZmZmZjgwMDAxMTZkNTBh
MCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNjY1Nzk5XSB4MTM6IGZmZmY4MDAwMTE2
ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjY2NTgwMV0geDExOiAwMDAwMDAw
MDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS42NjU4MDNdIHg5IDogZmZm
ZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzNTMwMzAzMTMwMzAgDQpbICAgIDEuNjY1ODA1XSB4NyA6
IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjY2NTgwN10g
eDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS42NjU4
MDldIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEu
NjY1ODExXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAg
ICAxLjY2NTgxM10gQ2FsbCB0cmFjZToNClsgICAgMS42NjU4MTVdICBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS42NjU4MThdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAg
ICAxLjY2NTgyMF0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjY1
ODIyXSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS42NjU4MjVdICBzZWNv
bmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS42NjU4MjZdIC0tLVsgZW5kIHRy
YWNlIGY2ODcyOGEwZDMwNTNiNzAgXS0tLQ0KWyAgICAxLjY2NTgzMl0gR0lDdjM6IENQVTMwOiB1
c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjkwMDAwMA0KWyAg
ICAxLjY2NTg5OF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjY2NTkwN10gWGVuOiBpbml0aWFsaXppbmcgY3B1MzAN
ClsgICAgMS42NjU5MzVdIENQVTMwOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAw
MDAxMGUgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjY2MTk2XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUg
b24gQ1BVMzENClsgICAgMS42NjYyNzhdIEdJQ3YzOiBDUFUzMTogZm91bmQgcmVkaXN0cmlidXRv
ciAxMGYgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNTIwMDAwDQpbICAgIDEuNjcyOTAwXSAtLS0tLS0t
LS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS42NzI5MDVdIFdBUk5JTkc6IENQ
VTogMzEgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRz
X2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjcyOTA2XSBNb2R1bGVzIGxpbmtlZCBpbjoN
ClsgICAgMS42NzI5MTBdIENQVTogMzEgUElEOiAwIENvbW06IHN3YXBwZXIvMzEgVGFpbnRlZDog
RyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAg
MS42NzI5MTJdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQ
RT0tLSkNClsgICAgMS42NzI5MTRdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAg
IDEuNjcyOTE1XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjY3MjkxNl0g
c3AgOiBmZmZmODAwMDExYjJiZTgwDQpbICAgIDEuNjcyOTE3XSB4Mjk6IGZmZmY4MDAwMTFiMmJl
ODAgeDI4OiAwMDAwMDAwMDAwMDAwMDFmIA0KWyAgICAxLjY3MjkyMF0geDI3OiAwMDAwMDAwMDAw
MDAwMDAwIHgyNjogZmZmZjgwMDAxMjNlMDA3MCANClsgICAgMS42NzI5MjJdIHgyNTogZmZmZmZl
MWZmZGVhNDQwMCB4MjQ6IGZmZmY4MDAwMTIzZTAwMDAgDQpbICAgIDEuNjcyOTI0XSB4MjM6IGZm
ZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjY3MjkyNl0geDIx
OiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42NzI5Mjhd
IHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjcy
OTMwXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAx
LjY3MjkzMl0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsg
ICAgMS42NzI5MzRdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAg
DQpbICAgIDEuNjcyOTM2XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAw
MDAxIA0KWyAgICAxLjY3MjkzN10geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzMjM1MzAz
MDMxMzAzMCANClsgICAgMS42NzI5MzldIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAw
MDAwMDAwMDAwMDMgDQpbICAgIDEuNjcyOTQxXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBm
ZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjY3Mjk0M10geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgy
IDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42NzI5NDVdIHgxIDogMDAwMDAwMDAwMDAxMDAw
MCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNjcyOTQ3XSBDYWxsIHRyYWNlOg0KWyAg
ICAxLjY3Mjk0OV0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY3Mjk1Ml0gIGdp
Y19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNjcyOTU1XSAgY3B1aHBfaW52b2tlX2Nh
bGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42NzI5NTddICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4
YTAvMHhlMA0KWyAgICAxLjY3Mjk1OV0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5
MA0KWyAgICAxLjY3Mjk2MV0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I3MSBdLS0tDQpb
ICAgIDEuNjcyOTY3XSBHSUN2MzogQ1BVMzE6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0
YWJsZSBAMHgwMDAwMDgwMDAyOTEwMDAwDQpbICAgIDEuNjczMDM1XSBhcmNoX3RpbWVyOiBFbmFi
bGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjcz
MDQzXSBYZW46IGluaXRpYWxpemluZyBjcHUzMQ0KWyAgICAxLjY3MzA3MV0gQ1BVMzE6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwZiBbMHg0MTNmZDBjMV0NClsgICAgMS42
NzMxNjRdIHNtcDogQnJvdWdodCB1cCAxIG5vZGUsIDMyIENQVXMNClsgICAgNy41MTg3MzldIFNN
UDogVG90YWwgb2YgMzIgcHJvY2Vzc29ycyBhY3RpdmF0ZWQuDQpbICAgIDcuNTIzNTcyXSBDUFUg
ZmVhdHVyZXM6IGRldGVjdGVkOiBQcml2aWxlZ2VkIEFjY2VzcyBOZXZlcg0KWyAgICA3LjUyOTIy
N10gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogTFNFIGF0b21pYyBpbnN0cnVjdGlvbnMNClsgICAg
Ny41MzQ4NTZdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFVzZXIgQWNjZXNzIE92ZXJyaWRlDQpb
ICAgIDcuNTQwMjM3XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiAzMi1iaXQgRUwwIFN1cHBvcnQN
ClsgICAgNy41NDU0NDVdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IENvbW1vbiBub3QgUHJpdmF0
ZSB0cmFuc2xhdGlvbnMNClsgICAgNy41NTE3ODJdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IERh
dGEgY2FjaGUgY2xlYW4gdG8gdGhlIFBvVSBub3QgcmVxdWlyZWQgZm9yIEkvRCBjb2hlcmVuY2UN
ClsgICAgNy41NjA0NjJdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IENSQzMyIGluc3RydWN0aW9u
cw0KWyAgICA3LjU2NTY3MF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3VsYXRpdmUgU3Rv
cmUgQnlwYXNzaW5nIFNhZmUgKFNTQlMpDQpbICAgIDcuNjAzMzg4XSBDUFU6IEFsbCBDUFUocykg
c3RhcnRlZCBhdCBFTDENClsgICAgNy42MDc1NDRdIGFsdGVybmF0aXZlczogcGF0Y2hpbmcga2Vy
bmVsIGNvZGUNClsgICAgNy42MTI4NzFdIGRldnRtcGZzOiBpbml0aWFsaXplZA0KWyAgICA3LjYx
NjQwN10gY2xvY2tzb3VyY2U6IGppZmZpZXM6IG1hc2s6IDB4ZmZmZmZmZmYgbWF4X2N5Y2xlczog
MHhmZmZmZmZmZiwgbWF4X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnMNClsgICAgNy42MjYw
NDldIGZ1dGV4IGhhc2ggdGFibGUgZW50cmllczogODE5MiAob3JkZXI6IDcsIDUyNDI4OCBieXRl
cywgbGluZWFyKQ0KWyAgICA3LjYzMzI1Ml0gRE1JIG5vdCBwcmVzZW50IG9yIGludmFsaWQuDQpb
ICAgIDcuNjM3MjUyXSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDE2DQpbICAgIDcu
NjQyNzQ1XSBETUE6IHByZWFsbG9jYXRlZCAxMDI0IEtpQiBHRlBfS0VSTkVMIHBvb2wgZm9yIGF0
b21pYyBhbGxvY2F0aW9ucw0KWyAgICA3LjY0OTgyOV0gRE1BOiBwcmVhbGxvY2F0ZWQgMTAyNCBL
aUIgR0ZQX0tFUk5FTHxHRlBfRE1BIHBvb2wgZm9yIGF0b21pYyBhbGxvY2F0aW9ucw0KWyAgICA3
LjY1NzcxOV0gRE1BOiBwcmVhbGxvY2F0ZWQgMTAyNCBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BMzIg
cG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zDQpbICAgIDcuNjY2MDE3XSB0aGVybWFsX3N5czog
UmVnaXN0ZXJlZCB0aGVybWFsIGdvdmVybm9yICdzdGVwX3dpc2UnDQpbICAgIDcuNjY2MTQ3XSBE
ZXRlY3RlZCAxNSBQQ0MgU3Vic3BhY2VzDQpbICAgIDcuNjc1ODAyXSBSZWdpc3RlcmluZyBQQ0Mg
ZHJpdmVyIGFzIE1haWxib3ggY29udHJvbGxlcg0KWyAgICA3LjY4MTE5M10gaHctYnJlYWtwb2lu
dDogZm91bmQgNiBicmVha3BvaW50IGFuZCA0IHdhdGNocG9pbnQgcmVnaXN0ZXJzLg0KWyAgICA3
LjY4OTQyNF0gQVNJRCBhbGxvY2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVzDQpb
ICAgIDcuNjk0NzI4XSBBQ1BJOiBidXMgdHlwZSBQQ0kgcmVnaXN0ZXJlZA0KWyAgICA3LjY5ODgw
MV0gU2VyaWFsOiBBTUJBIFBMMDExIFVBUlQgZHJpdmVyDQpbICAgIDcuNzA1MjgxXSBIdWdlVExC
IHJlZ2lzdGVyZWQgMS4wMCBHaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMNClsg
ICAgNy43MTE4OTJdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAzMi4wIE1pQiBwYWdlIHNpemUsIHByZS1h
bGxvY2F0ZWQgMCBwYWdlcw0KWyAgICA3LjcxODY1MV0gSHVnZVRMQiByZWdpc3RlcmVkIDIuMDAg
TWlCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzDQpbICAgIDcuNzI1NDMyXSBIdWdl
VExCIHJlZ2lzdGVyZWQgNjQuMCBLaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMN
ClsgICAgNy43MzM1NzldIGNyeXB0ZDogbWF4X2NwdV9xbGVuIHNldCB0byAxMDAwDQpbICAgIDcu
ODA1ODA0XSByYWlkNjogbmVvbng4ICAgZ2VuKCkgIDc3MjkgTUIvcw0KWyAgICA3Ljg3ODAyOF0g
cmFpZDY6IG5lb254OCAgIHhvcigpICA2MDU4IE1CL3MNClsgICAgNy45NTAyNDldIHJhaWQ2OiBu
ZW9ueDQgICBnZW4oKSAgNzYyOCBNQi9zDQpbICAgIDguMDIyNDcyXSByYWlkNjogbmVvbng0ICAg
eG9yKCkgIDYzMDUgTUIvcw0KWyAgICA4LjA5NDY5Nl0gcmFpZDY6IG5lb254MiAgIGdlbigpICA3
MzMwIE1CL3MNClsgICAgOC4xNjY5MTddIHJhaWQ2OiBuZW9ueDIgICB4b3IoKSAgNTc1NiBNQi9z
DQpbICAgIDguMjM5MTQxXSByYWlkNjogbmVvbngxICAgZ2VuKCkgIDU5ODYgTUIvcw0KWyAgICA4
LjMxMTM2OV0gcmFpZDY6IG5lb254MSAgIHhvcigpICA0OTE2IE1CL3MNClsgICAgOC4zODM1OTNd
IHJhaWQ2OiBpbnQ2NHg4ICBnZW4oKSAgMzYwMCBNQi9zDQpbICAgIDguNDU1ODE3XSByYWlkNjog
aW50NjR4OCAgeG9yKCkgIDIwMTcgTUIvcw0KWyAgICA4LjUyODIwM10gcmFpZDY6IGludDY0eDQg
IGdlbigpICA0MTI2IE1CL3MNClsgICAgOC42MDA0MzhdIHJhaWQ2OiBpbnQ2NHg0ICB4b3IoKSAg
MjE5MCBNQi9zDQpbICAgIDguNjcyNjU4XSByYWlkNjogaW50NjR4MiAgZ2VuKCkgIDM1MDIgTUIv
cw0KWyAgICA4Ljc0NDg3Nl0gcmFpZDY6IGludDY0eDIgIHhvcigpICAxODg4IE1CL3MNClsgICAg
OC44MTcwOTNdIHJhaWQ2OiBpbnQ2NHgxICBnZW4oKSAgMjg3MyBNQi9zDQpbICAgIDguODg5MzEy
XSByYWlkNjogaW50NjR4MSAgeG9yKCkgIDE1MDcgTUIvcw0KWyAgICA4Ljg5MzQ3OV0gcmFpZDY6
IHVzaW5nIGFsZ29yaXRobSBuZW9ueDggZ2VuKCkgNzcyOSBNQi9zDQpbICAgIDguODk4OTQ2XSBy
YWlkNjogLi4uLiB4b3IoKSA2MDU4IE1CL3MsIHJtdyBlbmFibGVkDQpbICAgIDguOTAzOTgyXSBy
YWlkNjogdXNpbmcgbmVvbiByZWNvdmVyeSBhbGdvcml0aG0NClsgICAgOC45MDg3NTFdIEFDUEk6
IEFkZGVkIF9PU0koTW9kdWxlIERldmljZSkNClsgICAgOC45MTI5MjVdIEFDUEk6IEFkZGVkIF9P
U0koUHJvY2Vzc29yIERldmljZSkNClsgICAgOC45MTc0MzddIEFDUEk6IEFkZGVkIF9PU0koMy4w
IF9TQ1AgRXh0ZW5zaW9ucykNClsgICAgOC45MjIyMTFdIEFDUEk6IEFkZGVkIF9PU0koUHJvY2Vz
c29yIEFnZ3JlZ2F0b3IgRGV2aWNlKQ0KWyAgICA4LjkyNzY4MF0gQUNQSTogQWRkZWQgX09TSShM
aW51eC1EZWxsLVZpZGVvKQ0KWyAgICA4LjkzMjE5NF0gQUNQSTogQWRkZWQgX09TSShMaW51eC1M
ZW5vdm8tTlYtSERNSS1BdWRpbykNClsgICAgOC45Mzc1NzZdIEFDUEk6IEFkZGVkIF9PU0koTGlu
dXgtSFBJLUh5YnJpZC1HcmFwaGljcykNClsgICAgOC45NjMzMTddIEFDUEk6IDIgQUNQSSBBTUwg
dGFibGVzIHN1Y2Nlc3NmdWxseSBhY3F1aXJlZCBhbmQgbG9hZGVkDQpbICAgIDguOTc1ODQ4XSBB
Q1BJOiBJbnRlcnByZXRlciBlbmFibGVkDQpbICAgIDguOTc5NDEyXSBBQ1BJOiBVc2luZyBHSUMg
Zm9yIGludGVycnVwdCByb3V0aW5nDQpbICAgIDguOTg0MTk4XSBBQ1BJOiBNQ0ZHIHRhYmxlIGRl
dGVjdGVkLCA1IGVudHJpZXMNClsgICAgOC45ODg5NjFdIEhFU1Q6IFRhYmxlIHBhcnNpbmcgaGFz
IGJlZW4gaW5pdGlhbGl6ZWQuDQpbICAgIDkuMDQxNTAyXSBBUk1IMDAxMTowMDogdHR5QU1BMCBh
dCBNTUlPIDB4MTAwMDAyNjAwMDAwIChpcnEgPSA3OSwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNB
DQpbICAgIDkuMTMyMjM0XSBwcmludGs6IGNvbnNvbGUgW3R0eUFNQTBdIGVuYWJsZWQNClsgICAg
OS4xMzgyODNdIEFSTUgwMDExOjAxOiB0dHlBTUExIGF0IE1NSU8gMHgxMDAwMDI2MjAwMDAgKGly
cSA9IDgwLCBiYXNlX2JhdWQgPSAwKSBpcyBhIFNCU0ENClsgICAgOS4xNDg2NDFdIEFDUEk6IFBD
SSBSb290IEJyaWRnZSBbUENJMF0gKGRvbWFpbiAwMDBjIFtidXMgMDAtZmZdKQ0KWyAgICA5LjE1
NDgwOF0gYWNwaSBQTlAwQTA4OjAwOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcg
QVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgIDkuMTY0MDA5XSBhY3Bp
IFBOUDBBMDg6MDA6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3Rpbmcg
X09TQyBjb250cm9sDQpbICAgIDkuMTcxODMyXSBhY3BpIFBOUDBBMDg6MDA6IE1DRkcgcXVpcms6
IEVDQU0gYXQgW21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAt
ZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwDQpbICAgIDkuMTg0NzUzXSBhY3BpIFBOUDBBMDg6
MDA6IEVDQU0gYXJlYSBbbWVtIDB4MzNmZmYwMDAwMDAwLTB4MzNmZmZmZmZmZmZmXSByZXNlcnZl
ZCBieSBQTlAwQzAyOjAwDQpbICAgIDkuMTkzNjM4XSBhY3BpIFBOUDBBMDg6MDA6IEVDQU0gYXQg
W21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpbICAg
IDkuMjAxODYwXSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGM6MDANClsgICAgOS4yMDU5MDVd
IHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDQwMDAwMDAwLTB4NGZm
ZmZmZmYgd2luZG93XQ0KWyAgICA5LjIxMzU2NV0gcGNpX2J1cyAwMDBjOjAwOiByb290IGJ1cyBy
ZXNvdXJjZSBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzNmZmRmZmZmZmZmIHdpbmRvd10NClsgICAg
OS4yMjE4MTFdIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0N
ClsgICAgOS4yMjc0MDhdIHBjaSAwMDBjOjAwOjAwLjA6IFsxZGVmOmUxMDBdIHR5cGUgMDAgY2xh
c3MgMHgwNjAwMDANClsgICAgOS4yMzM1MTNdIHBjaSAwMDBjOjAwOjAwLjA6IEZhaWxlZCB0byBh
ZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS4yNDEwOTld
IHBjaSAwMDBjOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsg
ICAgOS4yNDcxNzddIHBjaSAwMDBjOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgIDkuMjUx
NDQ3XSBwY2kgMDAwYzowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpb
ICAgIDkuMjU3MzIwXSBwY2kgMDAwYzowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91
Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuMjY2MDU5XSBwY2kgMDAwYzowMDow
MS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMV0gYWRkX3Np
emUgMTAwMA0KWyAgICA5LjI3NDIzMV0gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBb
bWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxXSBhZGRfc2l6
ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgICA5LjI4NTgxNV0gcGNpIDAwMGM6MDA6MDEu
MDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAwMV0g
YWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAgOS4yOTYzOTddIHBjaSAwMDBj
OjAwOjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0NClsg
ICAgOS4zMDMyMTVdIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MzAw
MDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuMzExNzMzXSBwY2kg
MDAwYzowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAg
IDkuMzE4MDQzXSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8g
IHNpemUgMHgxMDAwXQ0KWyAgICA5LjMyNDczMl0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6IG5v
IHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA5LjMzMTA2OV0gcGNpIDAwMGM6MDA6
MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAgOS4z
Mzc3NTZdIHBjaSAwMDBjOjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMV0NClsgICAgOS4z
NDI3NjddIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NDAwMDAwMDAt
MHg0MDFmZmZmZl0NClsgICAgOS4zNDk2NDhdIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdDQpbICAg
IDkuMzU4MTc1XSBwY2lfYnVzIDAwMGM6MDA6IHJlc291cmNlIDQgW21lbSAweDQwMDAwMDAwLTB4
NGZmZmZmZmYgd2luZG93XQ0KWyAgICA5LjM2NTA5OF0gcGNpX2J1cyAwMDBjOjAwOiByZXNvdXJj
ZSA1IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzM2ZmZGZmZmZmZmYgd2luZG93XQ0KWyAgICA5LjM3
Mjc0NV0gcGNpX2J1cyAwMDBjOjAxOiByZXNvdXJjZSAxIFttZW0gMHg0MDAwMDAwMC0weDQwMWZm
ZmZmXQ0KWyAgICA5LjM3OTA2OV0gcGNpX2J1cyAwMDBjOjAxOiByZXNvdXJjZSAyIFttZW0gMHgz
MDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS4zODcxMzBdIEFD
UEk6IFBDSSBSb290IEJyaWRnZSBbUENJMV0gKGRvbWFpbiAwMDBkIFtidXMgMDAtZmZdKQ0KWyAg
ICA5LjM5MzMxNF0gYWNwaSBQTlAwQTA4OjAxOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRD
b25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgIDkuNDAyNTM0
XSBhY3BpIFBOUDBBMDg6MDE6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVl
c3RpbmcgX09TQyBjb250cm9sDQpbICAgIDkuNDEwMzU4XSBhY3BpIFBOUDBBMDg6MDE6IE1DRkcg
cXVpcms6IEVDQU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZmZl0gZm9yIFti
dXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwDQpbICAgIDkuNDIzMzUxXSBhY3BpIFBO
UDBBMDg6MDE6IEVDQU0gYXJlYSBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZmXSBy
ZXNlcnZlZCBieSBQTlAwQzAyOjAwDQpbICAgIDkuNDMyMjQ1XSBhY3BpIFBOUDBBMDg6MDE6IEVD
QU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZd
DQpbICAgIDkuNDQwNDYwXSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGQ6MDANClsgICAgOS40
NDQ1MDVdIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDUwMDAwMDAw
LTB4NWZmZmZmZmYgd2luZG93XQ0KWyAgICA5LjQ1MjA5NF0gcGNpX2J1cyAwMDBkOjAwOiByb290
IGJ1cyByZXNvdXJjZSBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzdmZmRmZmZmZmZmIHdpbmRvd10N
ClsgICAgOS40NjAzNDldIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAw
MC1mZl0NClsgICAgOS40NjU5MTRdIHBjaSAwMDBkOjAwOjAwLjA6IFsxZGVmOmUxMDBdIHR5cGUg
MDAgY2xhc3MgMHgwNjAwMDANClsgICAgOS40NzIwMTNdIHBjaSAwMDBkOjAwOjAwLjA6IEZhaWxl
ZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS40
Nzk2MjldIHBjaSAwMDBkOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0
MDANClsgICAgOS40ODU3MDddIHBjaSAwMDBkOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAg
IDkuNDg5OTkxXSBwY2kgMDAwZDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQz
aG90DQpbICAgIDkuNDk1ODU4XSBwY2kgMDAwZDowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFz
c3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuNTAzNTYyXSBwY2kgMDAw
ZDowMTowMC4wOiBbMTBkZToxZTg5XSB0eXBlIDAwIGNsYXNzIDB4MDMwMDAwDQpbICAgIDkuNTA5
NTUyXSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxMDogW21lbSAweDUwMDAwMDAwLTB4NTBmZmZm
ZmZdDQpbICAgIDkuNTE1ODkwXSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxNDogW21lbSAweDM0
MDAwMDAwMDAwMC0weDM0MDAwZmZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjUyMzg5Nl0gcGNp
IDAwMGQ6MDE6MDAuMDogcmVnIDB4MWM6IFttZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAwMTFmZmZm
ZmYgNjRiaXQgcHJlZl0NClsgICAgOS41MzE4NzldIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDI0
OiBbaW8gIDB4NTdmZmUwMDAtMHg1N2ZmZTA3Zl0NClsgICAgOS41MzgxOTZdIHBjaSAwMDBkOjAx
OjAwLjA6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQ0KWyAgICA5
LjU0NTAyOV0gcGNpIDAwMGQ6MDE6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBE
M2NvbGQNClsgICAgOS41NTExODFdIHBjaSAwMDBkOjAxOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBw
YXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS41NTg3OTldIHBjaSAw
MDBkOjAxOjAwLjE6IFsxMGRlOjEwZjhdIHR5cGUgMDAgY2xhc3MgMHgwNDAzMDANClsgICAgOS41
NjQ4NDddIHBjaSAwMDBkOjAxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4NTEwMDAwMDAtMHg1MTAw
M2ZmZl0NClsgICAgOS41NzEyODVdIHBjaSAwMDBkOjAxOjAwLjE6IEZhaWxlZCB0byBhZGQgLSBw
YXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS41Nzg4NTldIHBjaSAw
MDBkOjAxOjAwLjI6IFsxMGRlOjFhZDhdIHR5cGUgMDAgY2xhc3MgMHgwYzAzMzANClsgICAgOS41
ODQ5MTJdIHBjaSAwMDBkOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4MzQwMDEyMDAwMDAwLTB4
MzQwMDEyMDNmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuNTkyOTE5XSBwY2kgMDAwZDowMTowMC4y
OiByZWcgMHgxYzogW21lbSAweDM0MDAxMjA0MDAwMC0weDM0MDAxMjA0ZmZmZiA2NGJpdCBwcmVm
XQ0KWyAgICA5LjYwMDk1MF0gcGNpIDAwMGQ6MDE6MDAuMjogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE
MCBEM2hvdCBEM2NvbGQNClsgICAgOS42MDcwNzddIHBjaSAwMDBkOjAxOjAwLjI6IEZhaWxlZCB0
byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgOS42MTQ3
MTJdIHBjaSAwMDBkOjAxOjAwLjM6IFsxMGRlOjFhZDldIHR5cGUgMDAgY2xhc3MgMHgwYzgwMDAN
ClsgICAgOS42MjA3NjVdIHBjaSAwMDBkOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVtIDB4NTEwMDQw
MDAtMHg1MTAwNGZmZl0NClsgICAgOS42MjcxNTldIHBjaSAwMDBkOjAxOjAwLjM6IFBNRSMgc3Vw
cG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAgIDkuNjMzMjg4XSBwY2kgMDAwZDowMTow
MC4zOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwh
DQpbICAgIDkuNjQwOTM0XSBwY2kgMDAwZDowMDowMS4wOiBBU1BNOiBjdXJyZW50IGNvbW1vbiBj
bG9jayBjb25maWd1cmF0aW9uIGlzIGluY29uc2lzdGVudCwgcmVjb25maWd1cmluZw0KWyAgICA5
LjY2MjMxNl0gcGNpIDAwMGQ6MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgzNDAwMDAw
MDAwMDAtMHgzNDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS42NzA3NTRdIHBjaSAwMDBk
OjAwOjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0NClsg
ICAgOS42Nzc1OTBdIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBz
aXplIDB4MTAwMF0NClsgICAgOS42ODM5MjFdIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDkuNjkwNjEyXSBwY2kgMDAwZDow
MTowMC4wOiBCQVIgMTogYXNzaWduZWQgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAwZmZmZmZm
ZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjY5OTE0NF0gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDM6IGFz
c2lnbmVkIFttZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAwMTFmZmZmZmYgNjRiaXQgcHJlZl0NClsg
ICAgOS43MDc2NTFdIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4NTAw
MDAwMDAtMHg1MGZmZmZmZl0NClsgICAgOS43MTQ0ODldIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiA2
OiBhc3NpZ25lZCBbbWVtIDB4NTEwMDAwMDAtMHg1MTA3ZmZmZiBwcmVmXQ0KWyAgICA5LjcyMTc4
Ml0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTIwMDAwMDAt
MHgzNDAwMTIwM2ZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS43MzAzMDhdIHBjaSAwMDBkOjAxOjAw
LjI6IEJBUiAzOiBhc3NpZ25lZCBbbWVtIDB4MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRmZmZmIDY0
Yml0IHByZWZdDQpbICAgIDkuNzM4ODE1XSBwY2kgMDAwZDowMTowMC4xOiBCQVIgMDogYXNzaWdu
ZWQgW21lbSAweDUxMDgwMDAwLTB4NTEwODNmZmZdDQpbICAgIDkuNzQ1NjQ5XSBwY2kgMDAwZDow
MTowMC4zOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDUxMDg0MDAwLTB4NTEwODRmZmZdDQpbICAg
IDkuNzUyNTA2XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNTogbm8gc3BhY2UgZm9yIFtpbyAgc2l6
ZSAweDAwODBdDQpbICAgIDkuNzU4ODM1XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNTogZmFpbGVk
IHRvIGFzc2lnbiBbaW8gIHNpemUgMHgwMDgwXQ0KWyAgICA5Ljc2NTUyNF0gcGNpIDAwMGQ6MDA6
MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQ0KWyAgICA5Ljc3MDUzOF0gcGNpIDAwMGQ6MDA6
MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHg1MDAwMDAwMC0weDUxN2ZmZmZmXQ0KWyAgICA5
Ljc3NzQxOF0gcGNpIDAwMGQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzNDAwMDAw
MDAwMDAtMHgzNDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS43ODU5NDVdIHBjaV9idXMg
MDAwZDowMDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5IGJv
b3Rpbmcgd2l0aCBwY2k9cmVhbGxvYw0KWyAgICA5Ljc5NTA2Nl0gcGNpX2J1cyAwMDBkOjAwOiBy
ZXNvdXJjZSA0IFttZW0gMHg1MDAwMDAwMC0weDVmZmZmZmZmIHdpbmRvd10NClsgICAgOS44MDE5
ODNdIHBjaV9idXMgMDAwZDowMDogcmVzb3VyY2UgNSBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4Mzdm
ZmRmZmZmZmZmIHdpbmRvd10NClsgICAgOS44MDk2MjldIHBjaV9idXMgMDAwZDowMTogcmVzb3Vy
Y2UgMSBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0NClsgICAgOS44MTU5NTJdIHBjaV9idXMg
MDAwZDowMTogcmVzb3VyY2UgMiBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0
Yml0IHByZWZdDQpbICAgIDkuODI0MDE0XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTNdIChk
b21haW4gMDAwMCBbYnVzIDAwLWZmXSkNClsgICAgOS44MzAxOThdIGFjcGkgUE5QMEEwODowMzog
X09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBN
U0kgSFBYLVR5cGUzXQ0KWyAgICA5LjgzOTQwNl0gYWNwaSBQTlAwQTA4OjAzOiBQQ0llIHBvcnQg
c2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbA0KWyAgICA5Ljg0
NzIyOV0gYWNwaSBQTlAwQTA4OjAzOiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgzZmZmZjAw
MDAwMDAtMHgzZmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRl
MGZjMA0KWyAgICA5Ljg2MDE0Nl0gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGFyZWEgW21lbSAweDNm
ZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMA0KWyAgICA5
Ljg2OTAzM10gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGF0IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgz
ZmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQ0KWyAgICA5Ljg3NzI0OV0gUENJIGhvc3QgYnJp
ZGdlIHRvIGJ1cyAwMDAwOjAwDQpbICAgIDkuODgxMzE1XSBwY2lfYnVzIDAwMDA6MDA6IHJvb3Qg
YnVzIHJlc291cmNlIFttZW0gMHg3MDAwMDAwMC0weDdmZmZmZmZmIHdpbmRvd10NClsgICAgOS44
ODg4ODVdIHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDNjMDAwMDAw
MDAwMC0weDNmZmZkZmZmZmZmZiB3aW5kb3ddDQpbICAgIDkuODk3MTM5XSBwY2lfYnVzIDAwMDA6
MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdDQpbICAgIDkuOTAyNzA5XSBwY2kgMDAw
MDowMDowMC4wOiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwDQpbICAgIDkuOTA4
ODA0XSBwY2kgMDAwMDowMDowMC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJ
L01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuOTE2NDIwXSBwY2kgMDAwMDowMDowMS4wOiBbMWRl
ZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgIDkuOTIyNDk3XSBwY2kgMDAwMDow
MDowMS4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgICA5LjkyNjc4MF0gcGNpIDAwMDA6MDA6MDEuMDog
UE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgICA5LjkzMjY1M10gcGNpIDAwMDA6
MDA6MDEuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBm
YWlsIQ0KWyAgICA5Ljk0MDM0OV0gcGNpIDAwMDA6MDE6MDAuMDogWzgwODY6MTU4OV0gdHlwZSAw
MCBjbGFzcyAweDAyMDAwMA0KWyAgICA5Ljk0NjM0Nl0gcGNpIDAwMDA6MDE6MDAuMDogcmVnIDB4
MTA6IFttZW0gMHgzYzAwMDMwMDAwMDAtMHgzYzAwMDNmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAg
OS45NTQzNTRdIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODE4MDAw
LTB4M2MwMDA0ODFmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuOTYyMzM2XSBwY2kgMDAwMDowMTow
MC4wOiByZWcgMHgzMDogW21lbSAweGZmZjgwMDAwLTB4ZmZmZmZmZmYgcHJlZl0NClsgICAgOS45
NjkxNTZdIHBjaSAwMDAwOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNj
b2xkDQpbICAgIDkuOTc1Mjg0XSBwY2kgMDAwMDowMTowMC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFz
c3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuOTgyOTMyXSBwY2kgMDAw
MDowMTowMC4xOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwDQpbICAgIDkuOTg4
OTY3XSBwY2kgMDAwMDowMTowMC4xOiByZWcgMHgxMDogW21lbSAweDNjMDAwMjAwMDAwMC0weDNj
MDAwMmZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5Ljk5Njk3NV0gcGNpIDAwMDA6MDE6MDAuMTog
cmVnIDB4MWM6IFttZW0gMHgzYzAwMDQ4MTAwMDAtMHgzYzAwMDQ4MTdmZmYgNjRiaXQgcHJlZl0N
ClsgICAxMC4wMDQ5NTddIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAw
MDAtMHhmZmZmZmZmZiBwcmVmXQ0KWyAgIDEwLjAxMTc3NF0gcGNpIDAwMDA6MDE6MDAuMTogUE1F
IyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMC4wMTc4OThdIHBjaSAwMDAw
OjAxOjAwLjE6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQg
ZmFpbCENClsgICAxMC4wMjU1NDZdIHBjaSAwMDAwOjAxOjAwLjI6IFs4MDg2OjE1ODldIHR5cGUg
MDAgY2xhc3MgMHgwMjAwMDANClsgICAxMC4wMzE1ODddIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAw
eDEwOiBbbWVtIDB4M2MwMDAxMDAwMDAwLTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdDQpbICAg
MTAuMDM5NTk2XSBwY2kgMDAwMDowMTowMC4yOiByZWcgMHgxYzogW21lbSAweDNjMDAwNDgwODAw
MC0weDNjMDAwNDgwZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjA0NzU3OV0gcGNpIDAwMDA6MDE6
MDAuMjogcmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdDQpbICAgMTAu
MDU0Mzk2XSBwY2kgMDAwMDowMTowMC4yOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQz
Y29sZA0KWyAgIDEwLjA2MDUyMV0gcGNpIDAwMDA6MDE6MDAuMjogRmFpbGVkIHRvIGFkZCAtIHBh
c3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjA2ODE2N10gcGNpIDAw
MDA6MDE6MDAuMzogWzgwODY6MTU4OV0gdHlwZSAwMCBjbGFzcyAweDAyMDAwMA0KWyAgIDEwLjA3
NDIxMF0gcGNpIDAwMDA6MDE6MDAuMzogcmVnIDB4MTA6IFttZW0gMHgzYzAwMDAwMDAwMDAtMHgz
YzAwMDBmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4wODIyMTldIHBjaSAwMDAwOjAxOjAwLjM6
IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODAwMDAwLTB4M2MwMDA0ODA3ZmZmIDY0Yml0IHByZWZd
DQpbICAgMTAuMDkwMjAxXSBwY2kgMDAwMDowMTowMC4zOiByZWcgMHgzMDogW21lbSAweGZmZjgw
MDAwLTB4ZmZmZmZmZmYgcHJlZl0NClsgICAxMC4wOTcwMTddIHBjaSAwMDAwOjAxOjAwLjM6IFBN
RSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAgMTAuMTAzMTQ4XSBwY2kgMDAw
MDowMTowMC4zOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0
IGZhaWwhDQpbICAgMTAuMTEwODAzXSBwY2kgMDAwMDowMDowMS4wOiBicmlkZ2Ugd2luZG93IFtp
byAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMS0wMl0gYWRkX3NpemUgMTAwMA0KWyAgIDEwLjEx
OTI4Ml0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDAwMDAw
MDAtMHgzYzAwMDQ3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4xMjc3ODZdIHBjaSAwMDAwOjAw
OjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NzAwMDAwMDAtMHg3MDFmZmZmZl0NClsgICAx
MC4xMzQ2MjRdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0NClsgICAxMC4xNDA5NTVdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuMTQ3NjQ0XSBwY2kgMDAwMDowMDow
MS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuMTUzOTcz
XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgx
MDAwXQ0KWyAgIDEwLjE2MDY2NV0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFtt
ZW0gMHgzYzAwMDAwMDAwMDAtMHgzYzAwMDBmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4xNjkx
OThdIHBjaSAwMDAwOjAxOjAwLjE6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAxMDAwMDAw
LTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMTc3NzA0XSBwY2kgMDAwMDowMTow
MC4yOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMjAwMDAwMC0weDNjMDAwMmZmZmZmZiA2
NGJpdCBwcmVmXQ0KWyAgIDEwLjE4NjIxMl0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDA6IGFzc2ln
bmVkIFttZW0gMHgzYzAwMDMwMDAwMDAtMHgzYzAwMDNmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAx
MC4xOTQ3MThdIHBjaSAwMDAwOjAxOjAwLjA6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4NzAwMDAw
MDAtMHg3MDA3ZmZmZiBwcmVmXQ0KWyAgIDEwLjIwMTk5MF0gcGNpIDAwMDA6MDE6MDAuMTogQkFS
IDY6IGFzc2lnbmVkIFttZW0gMHg3MDA4MDAwMC0weDcwMGZmZmZmIHByZWZdDQpbICAgMTAuMjA5
MjgyXSBwY2kgMDAwMDowMTowMC4yOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMTAwMDAwLTB4
NzAxN2ZmZmYgcHJlZl0NClsgICAxMC4yMTY1NzNdIHBjaSAwMDAwOjAxOjAwLjM6IEJBUiA2OiBh
c3NpZ25lZCBbbWVtIDB4NzAxODAwMDAtMHg3MDFmZmZmZiBwcmVmXQ0KWyAgIDEwLjIyMzg2NV0g
cGNpIDAwMDA6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDAwMDAtMHgz
YzAwMDQwMDdmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4yMzIzOTJdIHBjaSAwMDAwOjAxOjAwLjE6
IEJBUiAzOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDA0MDA4MDAwLTB4M2MwMDA0MDBmZmZmIDY0Yml0
IHByZWZdDQpbICAgMTAuMjQwODk5XSBwY2kgMDAwMDowMTowMC4yOiBCQVIgMzogYXNzaWduZWQg
W21lbSAweDNjMDAwNDAxMDAwMC0weDNjMDAwNDAxN2ZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjI0
OTQwNl0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMTgw
MDAtMHgzYzAwMDQwMWZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4yNTc5MTNdIHBjaSAwMDAwOjAw
OjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMS0wMl0NClsgICAxMC4yNjMxNjhdIHBjaSAwMDAw
OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NzAwMDAwMDAtMHg3MDFmZmZmZl0NClsg
ICAxMC4yNzAwNDFdIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4M2Mw
MDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMjc4NTY3XSBwY2lf
YnVzIDAwMDA6MDA6IHJlc291cmNlIDQgW21lbSAweDcwMDAwMDAwLTB4N2ZmZmZmZmYgd2luZG93
XQ0KWyAgIDEwLjI4NTQ5MV0gcGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSA1IFttZW0gMHgzYzAw
MDAwMDAwMDAtMHgzZmZmZGZmZmZmZmYgd2luZG93XQ0KWyAgIDEwLjI5MzE0M10gcGNpX2J1cyAw
MDAwOjAxOiByZXNvdXJjZSAxIFttZW0gMHg3MDAwMDAwMC0weDcwMWZmZmZmXQ0KWyAgIDEwLjI5
OTQ2MF0gcGNpX2J1cyAwMDAwOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzYzAwMDAwMDAwMDAtMHgz
YzAwMDQ3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4zMDc1MjhdIEFDUEk6IFBDSSBSb290IEJy
aWRnZSBbUENJNl0gKGRvbWFpbiAwMDA0IFtidXMgMDAtZmZdKQ0KWyAgIDEwLjMxMzcwNV0gYWNw
aSBQTlAwQTA4OjA2OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9j
a1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgMTAuMzIyOTE5XSBhY3BpIFBOUDBBMDg6
MDY6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250
cm9sDQpbICAgMTAuMzMwNzQxXSBhY3BpIFBOUDBBMDg6MDY6IE1DRkcgcXVpcms6IEVDQU0gYXQg
W21lbSAweDJiZmZmMDAwMDAwMC0weDJiZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGgg
MHhmZmZmODAwMDEwZGUwZmMwDQpbICAgMTAuMzQzNjYxXSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0g
YXJlYSBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAw
QzAyOjAwDQpbICAgMTAuMzUyNTQ4XSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0gYXQgW21lbSAweDJi
ZmZmMDAwMDAwMC0weDJiZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpbICAgMTAuMzYwNzYz
XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMDQ6MDANClsgICAxMC4zNjQ4MDhdIHBjaV9idXMg
MDAwNDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2lu
ZG93XQ0KWyAgIDEwLjM3MjM5OV0gcGNpX2J1cyAwMDA0OjAwOiByb290IGJ1cyByZXNvdXJjZSBb
bWVtIDB4MjgwMDAwMDAwMDAwLTB4MmJmZmRmZmZmZmZmIHdpbmRvd10NClsgICAxMC4zODA2NTNd
IHBjaV9idXMgMDAwNDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0NClsgICAxMC4z
ODYyMTldIHBjaSAwMDA0OjAwOjAwLjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3MgMHgwNjAw
MDANClsgICAxMC4zOTIzMTVdIHBjaSAwMDA0OjAwOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNz
dGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC4zOTk5MzVdIHBjaSAwMDA0
OjAwOjAxLjA6IFsxZGVmOmUxMTFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAxMC40MDYw
MTNdIHBjaSAwMDA0OjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTAuNDEwMjk1XSBwY2kg
MDAwNDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgMTAuNDE2
MTYzXSBwY2kgMDAwNDowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJ
L01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTAuNDIzODA4XSBwY2kgMDAwNDowMDowMy4wOiBbMWRl
ZjplMTEzXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgMTAuNDI5ODg0XSBwY2kgMDAwNDow
MDowMy4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgIDEwLjQzNDE2Nl0gcGNpIDAwMDQ6MDA6MDMuMDog
UE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgIDEwLjQ0MDAzNl0gcGNpIDAwMDQ6
MDA6MDMuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBm
YWlsIQ0KWyAgIDEwLjQ0NzY3OV0gcGNpIDAwMDQ6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlwZSAw
MSBjbGFzcyAweDA2MDQwMA0KWyAgIDEwLjQ1Mzc2NF0gcGNpIDAwMDQ6MDA6MDUuMDogc3VwcG9y
dHMgRDEgRDINClsgICAxMC40NTgwMzddIHBjaSAwMDA0OjAwOjA1LjA6IFBNRSMgc3VwcG9ydGVk
IGZyb20gRDAgRDEgRDNob3QNClsgICAxMC40NjM5MDddIHBjaSAwMDA0OjAwOjA1LjA6IEZhaWxl
ZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC40
NzE2MDRdIHBjaSAwMDA0OjAxOjAwLjA6IFsxYTAzOjExNTBdIHR5cGUgMDEgY2xhc3MgMHgwNjA0
MDANClsgICAxMC40Nzc2NDBdIHBjaSAwMDA0OjAxOjAwLjA6IGVuYWJsaW5nIEV4dGVuZGVkIFRh
Z3MNClsgICAxMC40ODI2NzhdIHBjaSAwMDA0OjAxOjAwLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAg
MTAuNDg2OTQ0XSBwY2kgMDAwNDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQy
IEQzaG90IEQzY29sZA0KWyAgIDEwLjQ5MzcwOF0gcGNpIDAwMDQ6MDE6MDAuMDogRmFpbGVkIHRv
IGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjUwMTM1
OV0gcGNpX2J1cyAwMDA0OjAyOiBleHRlbmRlZCBjb25maWcgc3BhY2Ugbm90IGFjY2Vzc2libGUN
ClsgICAxMC41MDc0NzhdIHBjaSAwMDA0OjAyOjAwLjA6IFsxYTAzOjIwMDBdIHR5cGUgMDAgY2xh
c3MgMHgwMzAwMDANClsgICAxMC41MTM1NDVdIHBjaSAwMDA0OjAyOjAwLjA6IHJlZyAweDEwOiBb
bWVtIDB4MjAwMDAwMDAtMHgyMGZmZmZmZl0NClsgICAxMC41MTk4NzhdIHBjaSAwMDA0OjAyOjAw
LjA6IHJlZyAweDE0OiBbbWVtIDB4MjEwMDAwMDAtMHgyMTAxZmZmZl0NClsgICAxMC41MjYyMTRd
IHBjaSAwMDA0OjAyOjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmYwMDAtMHgyN2ZmZjA3Zl0N
ClsgICAxMC41MzI2MjldIHBjaSAwMDA0OjAyOjAwLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTAu
NTM2ODU2XSBwY2kgMDAwNDowMjowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQyIEQz
aG90IEQzY29sZA0KWyAgIDEwLjU0MzYxNV0gcGNpIDAwMDQ6MDI6MDAuMDogRmFpbGVkIHRvIGFk
ZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjU1MTM0Nl0g
cGNpIDAwMDQ6MDM6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBjbGFzcyAweDBjMDMzMA0KWyAg
IDEwLjU1NzM0MF0gcGNpIDAwMDQ6MDM6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMTIwMDAwMC0w
eDIxMjAxZmZmIDY0Yml0XQ0KWyAgIDEwLjU2NDI5M10gcGNpIDAwMDQ6MDM6MDAuMDogUE1FIyBz
dXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMC41NzA0MTVdIHBjaSAwMDA0OjAz
OjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFp
bCENClsgICAxMC41NzgxMDBdIHBjaSAwMDA0OjA0OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUgMDAg
Y2xhc3MgMHgwMjAwMDANClsgICAxMC41ODQxMDNdIHBjaSAwMDA0OjA0OjAwLjA6IHJlZyAweDEw
OiBbbWVtIDB4MjExMDAwMDAtMHgyMTE3ZmZmZl0NClsgICAxMC41OTA0NDVdIHBjaSAwMDA0OjA0
OjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmUwMDAtMHgyN2ZmZTAxZl0NClsgICAxMC41OTY4
MThdIHBjaSAwMDA0OjA0OjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MjExODAwMDAtMHgyMTE4M2Zm
Zl0NClsgICAxMC42MDMzMTNdIHBjaSAwMDA0OjA0OjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20g
RDAgRDNob3QgRDNjb2xkDQpbICAgMTAuNjA5NDcyXSBwY2kgMDAwNDowNDowMC4wOiBGYWlsZWQg
dG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTAuNjE3
MDg3XSBwY2kgMDAwNDowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAw
MGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDEtMDJdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxp
Z24gMTAwMDAwDQpbICAgMTAuNjI4ODg4XSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93
IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMA0KWyAgIDEwLjYz
NzA5MV0gcGNpIDAwMDQ6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgw
MDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAzXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWdu
IDEwMDAwMA0KWyAgIDEwLjY0ODY3Nl0gcGNpIDAwMDQ6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBb
bWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMDAwIGFk
ZF9hbGlnbiAxMDAwMDANClsgICAxMC42NTkyNTRdIHBjaSAwMDA0OjAwOjA1LjA6IGJyaWRnZSB3
aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0g
YWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMC42NzA4MTFdIHBjaSAwMDA0
OjAwOjA1LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFti
dXMgMDRdIGFkZF9zaXplIDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTAuNjgxMzk1XSBw
Y2kgMDAwNDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZm
ZmZdDQpbICAgMTAuNjg4MjA0XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21l
bSAweDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjY5Njcz
MF0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMTgwMDAwMC0weDIx
OWZmZmZmXQ0KWyAgIDEwLjcwMzU3M10gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDk6IGFzc2lnbmVk
IFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC43
MTIwOTRdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjFhMDAwMDAt
MHgyMWJmZmZmZl0NClsgICAxMC43MTg5MzNdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA5OiBhc3Np
Z25lZCBbbWVtIDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAg
MTAuNzI3NDU5XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6
ZSAweDEwMDBdDQpbICAgMTAuNzMzNzcwXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVk
IHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjc0MDQ2MV0gcGNpIDAwMDQ6MDA6
MDMuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjc0Njc5
MF0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4
MTAwMF0NClsgICAxMC43NTM0ODRdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFjZSBm
b3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC43NTk4MTNdIHBjaSAwMDA0OjAwOjA1LjA6IEJB
UiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuNzY2NTAyXSBw
Y2kgMDAwNDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpb
ICAgMTAuNzcyODM4XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjc3OTUyMV0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDc6
IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjc4NTg1M10gcGNpIDAwMDQ6
MDA6MDUuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAx
MC43OTI1NDZdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0NClsgICAxMC43OTg4NzRdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuODA1NTY0XSBwY2kgMDAwNDowMTow
MC4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZmZmZdDQpbICAgMTAu
ODEyNDIxXSBwY2kgMDAwNDowMTowMC4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAw
eDEwMDBdDQpbICAgMTAuODE4NzUyXSBwY2kgMDAwNDowMTowMC4wOiBCQVIgNzogZmFpbGVkIHRv
IGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjgyNTQ0Ml0gcGNpIDAwMDQ6MDI6MDAu
MDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIwZmZmZmZmXQ0KWyAgIDEwLjgz
MjMwM10gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFttZW0gMHgyMTAwMDAwMC0w
eDIxMDFmZmZmXQ0KWyAgIDEwLjgzOTE2Ml0gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDI6IG5vIHNw
YWNlIGZvciBbaW8gIHNpemUgMHgwMDgwXQ0KWyAgIDEwLjg0NTQ4OF0gcGNpIDAwMDQ6MDI6MDAu
MDogQkFSIDI6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0NClsgICAxMC44NTIx
NzhdIHBjaSAwMDA0OjAxOjAwLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMl0NClsgICAxMC44NTcx
OThdIHBjaSAwMDA0OjAxOjAwLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjAwMDAwMDAtMHgy
MTdmZmZmZl0NClsgICAxMC44NjQwODRdIHBjaSAwMDA0OjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8g
W2J1cyAwMS0wMl0NClsgICAxMC44NjkzNTBdIHBjaSAwMDA0OjAwOjAxLjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0NClsgICAxMC44NzYyMjVdIHBjaSAwMDA0
OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MjgwMDAwMWZm
ZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuODg0NzUzXSBwY2kgMDAwNDowMzowMC4wOiBCQVIgMDog
YXNzaWduZWQgW21lbSAweDIxODAwMDAwLTB4MjE4MDFmZmYgNjRiaXRdDQpbICAgMTAuODkyMTI1
XSBwY2kgMDAwNDowMDowMy4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDNdDQpbICAgMTAuODk3MTI0
XSBwY2kgMDAwNDowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIxODAwMDAwLTB4MjE5
ZmZmZmZdDQpbICAgMTAuOTA0MDA4XSBwY2kgMDAwNDowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cg
W21lbSAweDI4MDAwMDIwMDAwMC0weDI4MDAwMDNmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjkx
MjUzMF0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMWEwMDAwMC0w
eDIxYTdmZmZmXQ0KWyAgIDEwLjkxOTM3Ml0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDM6IGFzc2ln
bmVkIFttZW0gMHgyMWE4MDAwMC0weDIxYTgzZmZmXQ0KWyAgIDEwLjkyNjIzMF0gcGNpIDAwMDQ6
MDQ6MDAuMDogQkFSIDI6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgwMDIwXQ0KWyAgIDEwLjkz
MjU1NF0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDI6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXpl
IDB4MDAyMF0NClsgICAxMC45MzkyNDNdIHBjaSAwMDA0OjAwOjA1LjA6IFBDSSBicmlkZ2UgdG8g
W2J1cyAwNF0NClsgICAxMC45NDQyNjBdIHBjaSAwMDA0OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MjFhMDAwMDAtMHgyMWJmZmZmZl0NClsgICAxMC45NTExMzhdIHBjaSAwMDA0OjAw
OjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZm
IDY0Yml0IHByZWZdDQpbICAgMTAuOTU5NjY1XSBwY2lfYnVzIDAwMDQ6MDA6IFNvbWUgUENJIGRl
dmljZSByZXNvdXJjZXMgYXJlIHVuYXNzaWduZWQsIHRyeSBib290aW5nIHdpdGggcGNpPXJlYWxs
b2MNClsgICAxMC45Njg3ODZdIHBjaV9idXMgMDAwNDowMDogcmVzb3VyY2UgNCBbbWVtIDB4MjAw
MDAwMDAtMHgyZmZmZmZmZiB3aW5kb3ddDQpbICAgMTAuOTc1NzA3XSBwY2lfYnVzIDAwMDQ6MDA6
IHJlc291cmNlIDUgW21lbSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZmZmZmZiB3aW5kb3ddDQpb
ICAgMTAuOTgzMzU5XSBwY2lfYnVzIDAwMDQ6MDE6IHJlc291cmNlIDEgW21lbSAweDIwMDAwMDAw
LTB4MjE3ZmZmZmZdDQpbICAgMTAuOTg5NjczXSBwY2lfYnVzIDAwMDQ6MDE6IHJlc291cmNlIDIg
W21lbSAweDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjk5
NzY3OV0gcGNpX2J1cyAwMDA0OjAyOiByZXNvdXJjZSAxIFttZW0gMHgyMDAwMDAwMC0weDIxN2Zm
ZmZmXQ0KWyAgIDExLjAwMzk5Nl0gcGNpX2J1cyAwMDA0OjAzOiByZXNvdXJjZSAxIFttZW0gMHgy
MTgwMDAwMC0weDIxOWZmZmZmXQ0KWyAgIDExLjAxMDMzM10gcGNpX2J1cyAwMDA0OjAzOiByZXNv
dXJjZSAyIFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsg
ICAxMS4wMTgzMzldIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMSBbbWVtIDB4MjFhMDAwMDAt
MHgyMWJmZmZmZl0NClsgICAxMS4wMjQ2NTZdIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMiBb
bWVtIDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuMDMy
NzM1XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTddIChkb21haW4gMDAwNSBbYnVzIDAwLWZm
XSkNClsgICAxMS4wMzg5MDFdIGFjcGkgUE5QMEEwODowNzogX09TQzogT1Mgc3VwcG9ydHMgW0V4
dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQ0KWyAgIDEx
LjA0ODExNl0gYWNwaSBQTlAwQTA4OjA3OiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5v
dCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbA0KWyAgIDExLjA1NTkzN10gYWNwaSBQTlAwQTA4OjA3
OiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZmZmZmZmZmZmZd
IGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMA0KWyAgIDExLjA2ODg5Nl0g
YWNwaSBQTlAwQTA4OjA3OiBFQ0FNIGFyZWEgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZm
ZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMA0KWyAgIDExLjA3Nzc4OF0gYWNwaSBQTlAwQTA4
OjA3OiBFQ0FNIGF0IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZmZmZmZmZmZmZdIGZvciBbYnVz
IDAwLWZmXQ0KWyAgIDExLjA4NjAwN10gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDA1OjAwDQpb
ICAgMTEuMDkwMDUxXSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgz
MDAwMDAwMC0weDNmZmZmZmZmIHdpbmRvd10NClsgICAxMS4wOTc2NDFdIHBjaV9idXMgMDAwNTow
MDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3
aW5kb3ddDQpbICAgMTEuMTA1ODk1XSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNl
IFtidXMgMDAtZmZdDQpbICAgMTEuMTExNDY0XSBwY2kgMDAwNTowMDowMC4wOiBbMWRlZjplMTEw
XSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwDQpbICAgMTEuMTE3NTYyXSBwY2kgMDAwNTowMDowMC4w
OiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpb
ICAgMTEuMTI1MTgxXSBwY2kgMDAwNTowMDowMS4wOiBbMWRlZjplMTExXSB0eXBlIDAxIGNsYXNz
IDB4MDYwNDAwDQpbICAgMTEuMTMxMjYzXSBwY2kgMDAwNTowMDowMS4wOiBzdXBwb3J0cyBEMSBE
Mg0KWyAgIDExLjEzNTUzNl0gcGNpIDAwMDU6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE
MCBEMSBEM2hvdA0KWyAgIDExLjE0MTQwOV0gcGNpIDAwMDU6MDA6MDEuMDogRmFpbGVkIHRvIGFk
ZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDExLjE0OTA0Nl0g
cGNpIDAwMDU6MDA6MDMuMDogWzFkZWY6ZTExM10gdHlwZSAwMSBjbGFzcyAweDA2MDQwMA0KWyAg
IDExLjE1NTEyN10gcGNpIDAwMDU6MDA6MDMuMDogc3VwcG9ydHMgRDEgRDINClsgICAxMS4xNTk0
MDddIHBjaSAwMDA1OjAwOjAzLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QNClsg
ICAxMS4xNjUyNzldIHBjaSAwMDA1OjAwOjAzLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3Vn
aCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMS4xNzI5MjVdIHBjaSAwMDA1OjAwOjA1
LjA6IFsxZGVmOmUxMTVdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAxMS4xNzkwMDZdIHBj
aSAwMDA1OjAwOjA1LjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgMTEuMTgzMjc5XSBwY2kgMDAwNTow
MDowNS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgMTEuMTg5MTQ2XSBw
Y2kgMDAwNTowMDowNS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1Y
IG1pZ2h0IGZhaWwhDQpbICAgMTEuMTk2Nzg5XSBwY2kgMDAwNTowMDowNy4wOiBbMWRlZjplMTE3
XSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgMTEuMjAyODcwXSBwY2kgMDAwNTowMDowNy4w
OiBzdXBwb3J0cyBEMSBEMg0KWyAgIDExLjIwNzE1MV0gcGNpIDAwMDU6MDA6MDcuMDogUE1FIyBz
dXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgIDExLjIxMzAyM10gcGNpIDAwMDU6MDA6MDcu
MDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0K
WyAgIDExLjIyMTc4NF0gcGNpIDAwMDU6MDI6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBjbGFz
cyAweDBjMDMzMA0KWyAgIDExLjIyNzc3OV0gcGNpIDAwMDU6MDI6MDAuMDogcmVnIDB4MTA6IFtt
ZW0gMHgzMDEwMDAwMC0weDMwMTAxZmZmIDY0Yml0XQ0KWyAgIDExLjIzNDczMF0gcGNpIDAwMDU6
MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAxMS4yNDA4
NDldIHBjaSAwMDA1OjAyOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kv
TVNJLVggbWlnaHQgZmFpbCENClsgICAxMS4yNDk1ODBdIHBjaSAwMDA1OjA0OjAwLjA6IFsxMjZm
OjIyNjNdIHR5cGUgMDAgY2xhc3MgMHgwMTA4MDINClsgICAxMS4yNTU1NzJdIHBjaSAwMDA1OjA0
OjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4MzAwMDAwMDAtMHgzMDAwM2ZmZiA2NGJpdF0NClsgICAx
MS4yNjI1NjddIHBjaSAwMDA1OjA0OjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBv
ciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMS4yNzAxNThdIHBjaSAwMDA1OjAwOjAxLjA6
IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAx
MDAwDQpbICAgMTEuMjc4Mzc2XSBwY2kgMDAwNTowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0g
MHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDIw
MDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMjg5OTYwXSBwY2kgMDAwNTowMDowMS4wOiBi
cmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBhZGRf
c2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjMwMDU0MF0gcGNpIDAwMDU6MDA6
MDMuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDJdIGFkZF9z
aXplIDEwMDANClsgICAxMS4zMDg3NThdIHBjaSAwMDA1OjAwOjAzLjA6IGJyaWRnZSB3aW5kb3cg
W21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMl0gYWRkX3Np
emUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMS4zMjAzNDJdIHBjaSAwMDA1OjAwOjAz
LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDJd
IGFkZF9zaXplIDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMzMwOTIwXSBwY2kgMDAw
NTowMDowNS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10g
YWRkX3NpemUgMTAwMA0KWyAgIDExLjMzOTEzOV0gcGNpIDAwMDU6MDA6MDUuMDogYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAzXSBh
ZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjM1MDcyNF0gcGNpIDAwMDU6
MDA6MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1
cyAwM10gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMS4zNjEzMDFdIHBj
aSAwMDA1OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVz
IDA0XSBhZGRfc2l6ZSAxMDAwDQpbICAgMTEuMzY5NTI0XSBwY2kgMDAwNTowMDowNy4wOiBicmlk
Z2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMg
MDRdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMzgxMTA3XSBwY2kg
MDAwNTowMDowNy4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0
byBbYnVzIDA0XSBhZGRfc2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjM5MTY4
OV0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMC0weDMw
MWZmZmZmXQ0KWyAgIDExLjM5ODQ5OV0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVk
IFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS40
MDcwMjVdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzAyMDAwMDAt
MHgzMDNmZmZmZl0NClsgICAxMS40MTM4NjldIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA5OiBhc3Np
Z25lZCBbbWVtIDB4MmMwMDAwMjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdDQpbICAg
MTEuNDIyMzg5XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwNDAw
MDAwLTB4MzA1ZmZmZmZdDQpbICAgMTEuNDI5MjI3XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgOTog
YXNzaWduZWQgW21lbSAweDJjMDAwMDQwMDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQ0K
WyAgIDExLjQzNzc1NF0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgz
MDYwMDAwMC0weDMwN2ZmZmZmXQ0KWyAgIDExLjQ0NDU5M10gcGNpIDAwMDU6MDA6MDcuMDogQkFS
IDk6IGFzc2lnbmVkIFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZmZmYgNjRiaXQgcHJl
Zl0NClsgICAxMS40NTMxMThdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3Ig
W2lvICBzaXplIDB4MTAwMF0NClsgICAxMS40NTk0MjldIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3
OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNDY2MTE4XSBwY2kg
MDAwNTowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAg
MTEuNDcyNDUwXSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8g
IHNpemUgMHgxMDAwXQ0KWyAgIDExLjQ3OTEzOV0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5v
IHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjQ4NTQ3MV0gcGNpIDAwMDU6MDA6
MDUuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS40
OTIxNzBdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4
MTAwMF0NClsgICAxMS40OTg0OTJdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBmYWlsZWQgdG8g
YXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTA1MTgzXSBwY2kgMDAwNTowMDowNy4w
OiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTExNTEzXSBw
Y2kgMDAwNTowMDowNy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAw
XQ0KWyAgIDExLjUxODIwMl0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBb
aW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjUyNDUzM10gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6
IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS41MzEyMjFdIHBjaSAw
MDA1OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAx
MS41Mzc1NTRdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAg
c2l6ZSAweDEwMDBdDQpbICAgMTEuNTQ0MjQ0XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgNzogbm8g
c3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTUwNTc1XSBwY2kgMDAwNTowMDow
MS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjU1
NzI2NF0gcGNpIDAwMDU6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQ0KWyAgIDExLjU2
MjI4MV0gcGNpIDAwMDU6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAwMC0w
eDMwMWZmZmZmXQ0KWyAgIDExLjU2OTE1OV0gcGNpIDAwMDU6MDA6MDEuMDogICBicmlkZ2Ugd2lu
ZG93IFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAx
MS41Nzc2ODZdIHBjaSAwMDA1OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MzAyMDAw
MDAtMHgzMDIwMWZmZiA2NGJpdF0NClsgICAxMS41ODUwNTldIHBjaSAwMDA1OjAwOjAzLjA6IFBD
SSBicmlkZ2UgdG8gW2J1cyAwMl0NClsgICAxMS41OTAwNTldIHBjaSAwMDA1OjAwOjAzLjA6ICAg
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MzAyMDAwMDAtMHgzMDNmZmZmZl0NClsgICAxMS41OTY5Mzdd
IHBjaSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMjAwMDAwLTB4
MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuNjA1NDYzXSBwY2kgMDAwNTowMDowNS4w
OiBQQ0kgYnJpZGdlIHRvIFtidXMgMDNdDQpbICAgMTEuNjEwNDU4XSBwY2kgMDAwNTowMDowNS4w
OiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZmZmZdDQpbICAgMTEuNjE3
MzM2XSBwY2kgMDAwNTowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDQwMDAw
MC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjYyNTg2NF0gcGNpIDAwMDU6MDQ6
MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAwMC0weDMwNjAzZmZmIDY0Yml0XQ0K
WyAgIDExLjYzMzI0MF0gcGNpIDAwMDU6MDA6MDcuMDogUENJIGJyaWRnZSB0byBbYnVzIDA0XQ0K
WyAgIDExLjYzODIzN10gcGNpIDAwMDU6MDA6MDcuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgz
MDYwMDAwMC0weDMwN2ZmZmZmXQ0KWyAgIDExLjY0NTExNV0gcGNpIDAwMDU6MDA6MDcuMDogICBi
cmlkZ2Ugd2luZG93IFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZmZmYgNjRiaXQgcHJl
Zl0NClsgICAxMS42NTM2NjFdIHBjaV9idXMgMDAwNTowMDogcmVzb3VyY2UgNCBbbWVtIDB4MzAw
MDAwMDAtMHgzZmZmZmZmZiB3aW5kb3ddDQpbICAgMTEuNjYwNTY4XSBwY2lfYnVzIDAwMDU6MDA6
IHJlc291cmNlIDUgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3aW5kb3ddDQpb
ICAgMTEuNjY4MjE0XSBwY2lfYnVzIDAwMDU6MDE6IHJlc291cmNlIDEgW21lbSAweDMwMDAwMDAw
LTB4MzAxZmZmZmZdDQpbICAgMTEuNjc0NTM0XSBwY2lfYnVzIDAwMDU6MDE6IHJlc291cmNlIDIg
W21lbSAweDJjMDAwMDAwMDAwMC0weDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjY4
MjUzOV0gcGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAxIFttZW0gMHgzMDIwMDAwMC0weDMwM2Zm
ZmZmXQ0KWyAgIDExLjY4ODg1N10gcGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAyIFttZW0gMHgy
YzAwMDAyMDAwMDAtMHgyYzAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS42OTY4NjNdIHBj
aV9idXMgMDAwNTowMzogcmVzb3VyY2UgMSBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0NClsg
ICAxMS43MDM0NzhdIHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMiBbbWVtIDB4MmMwMDAwNDAw
MDAwLTB4MmMwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuNzExMzk0XSBwY2lfYnVzIDAw
MDU6MDQ6IHJlc291cmNlIDEgW21lbSAweDMwNjAwMDAwLTB4MzA3ZmZmZmZdDQpbICAgMTEuNzE3
NzA3XSBwY2lfYnVzIDAwMDU6MDQ6IHJlc291cmNlIDIgW21lbSAweDJjMDAwMDYwMDAwMC0weDJj
MDAwMDdmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjcyNTk2M10geGVuOmJhbGxvb246IEluaXRp
YWxpc2luZyBiYWxsb29uIGRyaXZlcg0KWyAgIDExLjczMDkzN10gaW9tbXU6IERlZmF1bHQgZG9t
YWluIHR5cGU6IFRyYW5zbGF0ZWQgDQpbICAgMTEuNzM1ODk0XSBwY2kgMDAwZDowMTowMC4wOiB2
Z2FhcmI6IFZHQSBkZXZpY2UgYWRkZWQ6IGRlY29kZXM9aW8rbWVtLG93bnM9bm9uZSxsb2Nrcz1u
b25lDQpbICAgMTEuNzQ0MzExXSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IFZHQSBkZXZpY2Ug
YWRkZWQ6IGRlY29kZXM9aW8rbWVtLG93bnM9bm9uZSxsb2Nrcz1ub25lDQpbICAgMTEuNzUyNzE3
XSBwY2kgMDAwZDowMTowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxlDQpbICAg
MTEuNzU4NDk4XSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3Np
YmxlDQpbICAgMTEuNzY0MzE1XSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IHNldHRpbmcgYXMg
Ym9vdCBkZXZpY2UgKFZHQSBsZWdhY3kgcmVzb3VyY2VzIG5vdCBhdmFpbGFibGUpDQpbICAgMTEu
NzczMjk1XSB2Z2FhcmI6IGxvYWRlZA0KWyAgIDExLjc3NjA4N10gU0NTSSBzdWJzeXN0ZW0gaW5p
dGlhbGl6ZWQNClsgICAxMS43Nzk4MzNdIEFDUEk6IGJ1cyB0eXBlIFVTQiByZWdpc3RlcmVkDQpb
ICAgMTEuNzgzOTM1XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVz
YmZzDQpbICAgMTEuNzg5NDkyXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJp
dmVyIGh1Yg0KWyAgIDExLjc5NDg3OF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgZGV2aWNlIGRy
aXZlciB1c2INClsgICAxMS43OTk5OTldIHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAxIHJl
Z2lzdGVyZWQNClsgICAxMS44MDUwMTddIHBwc19jb3JlOiBTb2Z0d2FyZSB2ZXIuIDUuMy42IC0g
Q29weXJpZ2h0IDIwMDUtMjAwNyBSb2RvbGZvIEdpb21ldHRpIDxnaW9tZXR0aUBsaW51eC5pdD4N
ClsgICAxMS44MTQyNzBdIFBUUCBjbG9jayBzdXBwb3J0IHJlZ2lzdGVyZWQNClsgICAxMS44MTgz
MzRdIFJlZ2lzdGVyZWQgZWZpdmFycyBvcGVyYXRpb25zDQpbICAgMTEuODIyMzA1XSBObyBBQ1BJ
IFBNVSBJUlEgZm9yIENQVTANClsgICAxMS44MjU5MjJdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BV
MQ0KWyAgIDExLjgyOTU3NF0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUyDQpbICAgMTEuODMzMjE4
XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTMNClsgICAxMS44MzY4NjZdIE5vIEFDUEkgUE1VIElS
USBmb3IgQ1BVNA0KWyAgIDExLjg0MDUwNV0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFU1DQpbICAg
MTEuODQ0MTU3XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTYNClsgICAxMS44NDc3OTZdIE5vIEFD
UEkgUE1VIElSUSBmb3IgQ1BVNw0KWyAgIDExLjg1MTQ0OF0gTm8gQUNQSSBQTVUgSVJRIGZvciBD
UFU4DQpbICAgMTEuODU1MDg4XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTkNClsgICAxMS44NTg3
NDJdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTANClsgICAxMS44NjI0NjddIE5vIEFDUEkgUE1V
IElSUSBmb3IgQ1BVMTENClsgICAxMS44NjYyMDddIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTIN
ClsgICAxMS44Njk5MzJdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTMNClsgICAxMS44NzM2Nzdd
IE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTQNClsgICAxMS44NzczOThdIE5vIEFDUEkgUE1VIElS
USBmb3IgQ1BVMTUNClsgICAxMS44ODExMzddIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTYNClsg
ICAxMS44ODQ4NjNdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMTcNClsgICAxMS44ODg2MDJdIE5v
IEFDUEkgUE1VIElSUSBmb3IgQ1BVMTgNClsgICAxMS44OTIzMjhdIE5vIEFDUEkgUE1VIElSUSBm
b3IgQ1BVMTkNClsgICAxMS44OTYwNjhdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjANClsgICAx
MS44OTk3OTNdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjENClsgICAxMS45MDM1MzhdIE5vIEFD
UEkgUE1VIElSUSBmb3IgQ1BVMjINClsgICAxMS45MDcyNTldIE5vIEFDUEkgUE1VIElSUSBmb3Ig
Q1BVMjMNClsgICAxMS45MTA5OThdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjQNClsgICAxMS45
MTQ3MjRdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjUNClsgICAxMS45MTg0NjVdIE5vIEFDUEkg
UE1VIElSUSBmb3IgQ1BVMjYNClsgICAxMS45MjIxOTBdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BV
MjcNClsgICAxMS45MjU5MzBdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjgNClsgICAxMS45Mjk2
NTVdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMjkNClsgICAxMS45MzM0MDBdIE5vIEFDUEkgUE1V
IElSUSBmb3IgQ1BVMzANClsgICAxMS45MzcxMjBdIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMzEN
ClsgICAxMS45NDIyMjRdIGNsb2Nrc291cmNlOiBTd2l0Y2hlZCB0byBjbG9ja3NvdXJjZSBhcmNo
X3N5c19jb3VudGVyDQpbICAgMTIuMTIzNTc0XSBwbnA6IFBuUCBBQ1BJIGluaXQNClsgICAxMi4x
Mjc5NjddIHN5c3RlbSAwMDowMDogW21lbSAweDNiZmZmMDAwMDAwMC0weDNiZmZmZmZmZmZmZiB3
aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgMTIuMTM1ODgxXSBzeXN0ZW0gMDA6MDA6IFtt
ZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVz
ZXJ2ZWQNClsgICAxMi4xNDQyMTNdIHN5c3RlbSAwMDowMDogW21lbSAweDIzZmZmMDAwMDAwMC0w
eDIzZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgMTIuMTUyMTkzXSBz
eXN0ZW0gMDA6MDA6IFttZW0gMHgyN2ZmZjAwMDAwMDAtMHgyN2ZmZmZmZmZmZmYgd2luZG93XSBo
YXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjE2MDE3OV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MmJm
ZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkDQpb
ICAgMTIuMTY4NTIxXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZmZmZm
ZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQNClsgICAxMi4xNzY4NTFdIHN5c3Rl
bSAwMDowMDogW21lbSAweDdiZmZmMDAwMDAwMC0weDdiZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBi
ZWVuIHJlc2VydmVkDQpbICAgMTIuMTg0ODMyXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg3ZmZmZjAw
MDAwMDAtMHg3ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjE5
MjgxOF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4NjNmZmYwMDAwMDAwLTB4NjNmZmZmZmZmZmZmIHdp
bmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsgICAxMi4yMDA4MDRdIHN5c3RlbSAwMDowMDogW21l
bSAweDY3ZmZmMDAwMDAwMC0weDY3ZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVk
DQpbICAgMTIuMjA4NzkzXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2YmZmZjAwMDAwMDAtMHg2YmZm
ZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjIxNjc3N10gc3lzdGVt
IDAwOjAwOiBbbWVtIDB4NmZmZmYwMDAwMDAwLTB4NmZmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJl
ZW4gcmVzZXJ2ZWQNClsgICAxMi4yMjQ3NjRdIHN5c3RlbSAwMDowMDogW21lbSAweDMzZmZmMDAw
MDAwMC0weDMzZmZmZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZA0KWyAgIDEy
LjIzMzEwMF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZm
IHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkDQpbICAgMTIuMjQxNDQzXSBwbnA6IFBuUCBB
Q1BJOiBmb3VuZCAxIGRldmljZXMNClsgICAxMi4yNDg3ODZdIE5FVDogUmVnaXN0ZXJlZCBwcm90
b2NvbCBmYW1pbHkgMg0KWyAgIDEyLjI1MzI5Nl0gdGNwX2xpc3Rlbl9wb3J0YWRkcl9oYXNoIGhh
c2ggdGFibGUgZW50cmllczogNDA5NiAob3JkZXI6IDQsIDY1NTM2IGJ5dGVzLCBsaW5lYXIpDQpb
ICAgMTIuMjYxODk0XSBUQ1AgZXN0YWJsaXNoZWQgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAo
b3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQ0KWyAgIDEyLjI3MDAzOV0gVENQIGJpbmQg
aGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDgsIDEwNDg1NzYgYnl0ZXMsIGxpbmVh
cikNClsgICAxMi4yNzc5MDNdIFRDUDogSGFzaCB0YWJsZXMgY29uZmlndXJlZCAoZXN0YWJsaXNo
ZWQgNjU1MzYgYmluZCA2NTUzNikNClsgICAxMi4yODQ0NzhdIFVEUCBoYXNoIHRhYmxlIGVudHJp
ZXM6IDQwOTYgKG9yZGVyOiA1LCAxMzEwNzIgYnl0ZXMsIGxpbmVhcikNClsgICAxMi4yOTEzNTVd
IFVEUC1MaXRlIGhhc2ggdGFibGUgZW50cmllczogNDA5NiAob3JkZXI6IDUsIDEzMTA3MiBieXRl
cywgbGluZWFyKQ0KWyAgIDEyLjI5ODc4MF0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZhbWls
eSAxDQpbICAgMTIuMzAzMzgxXSBSUEM6IFJlZ2lzdGVyZWQgbmFtZWQgVU5JWCBzb2NrZXQgdHJh
bnNwb3J0IG1vZHVsZS4NClsgICAxMi4zMDkyNzZdIFJQQzogUmVnaXN0ZXJlZCB1ZHAgdHJhbnNw
b3J0IG1vZHVsZS4NClsgICAxMi4zMTQwMjhdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgdHJhbnNwb3J0
IG1vZHVsZS4NClsgICAxMi4zMTg4MDJdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgTkZTdjQuMSBiYWNr
Y2hhbm5lbCB0cmFuc3BvcnQgbW9kdWxlLg0KWyAgIDEyLjMyNTM4Ml0gcGNpIDAwMGQ6MDE6MDAu
MTogRDAgcG93ZXIgc3RhdGUgZGVwZW5kcyBvbiAwMDBkOjAxOjAwLjANClsgICAxMi4zMzE4MTRd
IHBjaSAwMDBkOjAxOjAwLjI6IEQwIHBvd2VyIHN0YXRlIGRlcGVuZHMgb24gMDAwZDowMTowMC4w
DQpbICAgMTIuMzM4MjIyXSBwY2kgMDAwZDowMTowMC4yOiBlbmFibGluZyBkZXZpY2UgKDAwMDAg
LT4gMDAwMikNClsgICAxMi4zNDM5NjJdIHBjaSAwMDBkOjAxOjAwLjM6IEQwIHBvd2VyIHN0YXRl
IGRlcGVuZHMgb24gMDAwZDowMTowMC4wDQpbICAgMTIuMzUwMzk0XSBwY2kgMDAwNDowMzowMC4w
OiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikNClsgICAxMi4zNTYwOThdIHBjaSAwMDA1
OjAyOjAwLjA6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQ0KWyAgIDEyLjM2MTgwOV0g
UENJOiBDTFMgMTI4IGJ5dGVzLCBkZWZhdWx0IDY0DQpbICAgMTIuMzY4NDI3XSBodyBwZXJmZXZl
bnRzOiBlbmFibGVkIHdpdGggYXJtdjhfcG11djNfMCBQTVUgZHJpdmVyLCAxIGNvdW50ZXJzIGF2
YWlsYWJsZQ0KWyAgIDEyLjM3ODUwMl0gd29ya2luZ3NldDogdGltZXN0YW1wX2JpdHM9NDIgbWF4
X29yZGVyPTIxIGJ1Y2tldF9vcmRlcj0wDQpbICAgMTIuMzg2Njk2XSBORlM6IFJlZ2lzdGVyaW5n
IHRoZSBpZF9yZXNvbHZlciBrZXkgdHlwZQ0KWyAgIDEyLjM5MTcxNl0gS2V5IHR5cGUgaWRfcmVz
b2x2ZXIgcmVnaXN0ZXJlZA0KWyAgIDEyLjM5NTk0OF0gS2V5IHR5cGUgaWRfbGVnYWN5IHJlZ2lz
dGVyZWQNClsgICAxMi40MDAzNTNdIEtleSB0eXBlIGNpZnMuaWRtYXAgcmVnaXN0ZXJlZA0KWyAg
IDEyLjQxODk3NF0geG9yOiBtZWFzdXJpbmcgc29mdHdhcmUgY2hlY2tzdW0gc3BlZWQNClsgICAx
Mi40MjQ3MjddICAgIDhyZWdzICAgICAgICAgICA6ICA5Nzk2IE1CL3NlYw0KWyAgIDEyLjQyOTg2
OF0gICAgMzJyZWdzICAgICAgICAgIDogMTE3NjEgTUIvc2VjDQpbICAgMTIuNDM0ODkwXSAgICBh
cm02NF9uZW9uICAgICAgOiAxMzg1OCBNQi9zZWMNClsgICAxMi40MzkxOTRdIHhvcjogdXNpbmcg
ZnVuY3Rpb246IGFybTY0X25lb24gKDEzODU4IE1CL3NlYykNClsgICAxMi40NDQ3NzNdIEJsb2Nr
IGxheWVyIFNDU0kgZ2VuZXJpYyAoYnNnKSBkcml2ZXIgdmVyc2lvbiAwLjQgbG9hZGVkIChtYWpv
ciAyNDkpDQpbICAgMTIuNDUyMjUzXSBpbyBzY2hlZHVsZXIgbXEtZGVhZGxpbmUgcmVnaXN0ZXJl
ZA0KWyAgIDEyLjQ1NjgxOV0gaW8gc2NoZWR1bGVyIGt5YmVyIHJlZ2lzdGVyZWQNClsgICAxMi40
NjIyNzddIGdwaW8tZHdhcGIgQVBNQzBEMDc6MDI6IG5vIElSUSBmb3IgcG9ydDANClsgICAxMi40
NjgxMjNdIGlucHV0OiBQb3dlciBCdXR0b24gYXMgL2RldmljZXMvTE5YU1lTVE06MDAvTE5YU1lC
VVM6MDAvUE5QMEMwQzowMC9pbnB1dC9pbnB1dDANClsgICAxMi40NzY1MDRdIEFDUEk6IFBvd2Vy
IEJ1dHRvbiBbUFdSQl0NClsgICAxMi40ODA5MDddIEdIRVM6IEFQRUkgZmlybXdhcmUgZmlyc3Qg
bW9kZSBpcyBlbmFibGVkIGJ5IEFQRUkgYml0Lg0KWyAgIDEyLjQ4NzEwNl0gRUlOSjogRXJyb3Ig
SU5KZWN0aW9uIGlzIGluaXRpYWxpemVkLg0KWyAgIDEyLjQ5MTg1OF0gQUNQSSBHVERUOiBmb3Vu
ZCAxIFNCU0EgZ2VuZXJpYyBXYXRjaGRvZyhzKS4NClsgICAxMi40OTc2OThdIHhlbjp4ZW5fZXZ0
Y2huOiBFdmVudC1jaGFubmVsIGRldmljZSBpbnN0YWxsZWQNClsgICAxMi41MDM4ODldIGFzdCAw
MDA0OjAyOjAwLjA6IFtkcm1dIHBsYXRmb3JtIGhhcyBubyBJTyBzcGFjZSwgdHJ5aW5nIE1NSU8N
ClsgICAxMi41MTA2NzhdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIFVzaW5nIFAyQSBicmlkZ2Ug
Zm9yIGNvbmZpZ3VyYXRpb24NClsgICAxMi41MTcyNTZdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1d
IEFTVCAyNTAwIGRldGVjdGVkDQpbICAgMTIuNTIyMzYwXSBhc3QgMDAwNDowMjowMC4wOiBbZHJt
XSBBbmFsb2cgVkdBIG9ubHkNClsgICAxMi41MjczMDldIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1d
IGRyYW0gTUNMSz04MDAgTWh6IHR5cGU9OCBidXNfd2lkdGg9MTYNClsgICAxMi41MzQyOThdIFtU
VE1dIFpvbmUgIGtlcm5lbDogQXZhaWxhYmxlIGdyYXBoaWNzIG1lbW9yeTogNDA1MDI1NCBLaUIN
ClsgICAxMi41NDA4MDFdIFtUVE1dIFpvbmUgICBkbWEzMjogQXZhaWxhYmxlIGdyYXBoaWNzIG1l
bW9yeTogMjA5NzE1MiBLaUINClsgICAxMi41NDczOTZdIFtUVE1dIEluaXRpYWxpemluZyBwb29s
IGFsbG9jYXRvcg0KWyAgIDEyLjU1MTgwMl0gW1RUTV0gSW5pdGlhbGl6aW5nIERNQSBwb29sIGFs
bG9jYXRvcg0KWyAgIDEyLjU1Njg0M10gW2RybV0gSW5pdGlhbGl6ZWQgYXN0IDAuMS4wIDIwMTIw
MjI4IGZvciAwMDA0OjAyOjAwLjAgb24gbWlub3IgMA0KWyAgIDEyLjU4MTYzNV0gQ29uc29sZTog
c3dpdGNoaW5nIHRvIGNvbG91ciBmcmFtZSBidWZmZXIgZGV2aWNlIDEyOHg0OA0KWyAgIDEyLjU5
MDA3MF0gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gZmIwOiBhc3Rkcm1mYiBmcmFtZSBidWZmZXIg
ZGV2aWNlDQpbICAgMTIuNjExMDYzXSBicmQ6IG1vZHVsZSBsb2FkZWQNClsgICAxMi42MTg1MDRd
IGxvb3A6IG1vZHVsZSBsb2FkZWQNClsgICAxMi42MjIxMDZdIG52bWUgbnZtZTA6IHBjaSBmdW5j
dGlvbiAwMDA1OjA0OjAwLjANClsgICAxMi42MjcwODJdIGlnYjogSW50ZWwoUikgR2lnYWJpdCBF
dGhlcm5ldCBOZXR3b3JrIERyaXZlcg0KWyAgIDEyLjYyOTAwMF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTUxMiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuNjMyNDQ4XSBpZ2I6IENv
cHlyaWdodCAoYykgMjAwNy0yMDE0IEludGVsIENvcnBvcmF0aW9uLg0KWyAgIDEyLjY0NDY3M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTUxMiBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTIuNjUwNTYwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT01MTIg
ZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjY1ODEzOV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2Nf
Y29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuNjY1MDgxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9MjA0OCBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTIuNjc0MjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9MjA0OCBmbGFncz1jYzAg
YXR0cj0wDQpbICAgMTIuNjc3MTg4XSBwcHMgcHBzMDogbmV3IFBQUyBzb3VyY2UgcHRwMA0KWyAg
IDEyLjY4MDI0N10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9MjA0
OCBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuNjg0MzYxXSBpZ2IgMDAwNDowNDowMC4wOiBhZGRl
ZCBQSEMgb24gZXRoMA0KWyAgIDEyLjY5MTM2M10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29o
ZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuNzAzMDExXSBpZ2Ig
MDAwNDowNDowMC4wOiBJbnRlbChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgQ29ubmVjdGlv
bg0KWyAgIDEyLjcwMzAyOF0gbnZtZSBudm1lMDogbWlzc2luZyBvciBpbnZhbGlkIFNVQk5RTiBm
aWVsZC4NClsgICAxMi43MDk5MzddIGlnYiAwMDA0OjA0OjAwLjA6IGV0aDA6IChQQ0llOjIuNUdi
L3M6V2lkdGggeDEpIDAwOjMwOjY0OjNiOjUwOjUyDQpbICAgMTIuNzA5OTk2XSBpZ2IgMDAwNDow
NDowMC4wOiBldGgwOiBQQkEgTm86IDAwMDMwMC0wMDANClsgICAxMi43MjI1NjFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT0yNTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjcyNzcx
MV0gaWdiIDAwMDQ6MDQ6MDAuMDogVXNpbmcgTVNJLVggaW50ZXJydXB0cy4gNCByeCBxdWV1ZShz
KSwgNCB0eCBxdWV1ZShzKQ0KWyAgIDEyLjcyNzc3Ml0gaWdidmY6IEludGVsKFIpIEdpZ2FiaXQg
VmlydHVhbCBGdW5jdGlvbiBOZXR3b3JrIERyaXZlcg0KWyAgIDEyLjczMzcxNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTI1NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuNzQxMzcy
XSBpZ2J2ZjogQ29weXJpZ2h0IChjKSAyMDA5IC0gMjAxMiBJbnRlbCBDb3Jwb3JhdGlvbi4NClsg
ICAxMi43NDc2OTJdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTI1
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuNzUzNjkzXSBpNDBlOiBJbnRlbChSKSBFdGhlcm5l
dCBDb25uZWN0aW9uIFhMNzEwIE5ldHdvcmsgRHJpdmVyDQpbICAgMTIuNzU5NjY4XSBERUJVRyB4
ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxMi43NjY2MjFdIGk0MGU6IENvcHlyaWdodCAoYykgMjAxMyAtIDIwMTkgSW50ZWwgQ29y
cG9yYXRpb24uDQpbICAgMTIuNzY2NzgzXSBpNDBlIDAwMDA6MDE6MDAuMDogZW5hYmxpbmcgZGV2
aWNlICgwMDAwIC0+IDAwMDIpDQpbICAgMTIuNzcyOTU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTANClsgICAxMi43NzI5NTZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMA0KWyAg
IDEyLjc3Mjk2MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDE5
NDMwNCBmbGFncz1jYzAgYXR0cj0xMTANClsgICAxMi43OTEyNzJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi43OTE3MDJdIERFQlVH
IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0
dHI9MTEwDQpbICAgMTIuNzk4MjE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9ODE5
MiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuNzk4MjE5XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCAyODYgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi44MDQ5ODBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTEx
MA0KWyAgIDEyLjgxMjE5OV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNp
emU9ODE5MiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODEyMjA0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODE4MjYwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTANClsg
ICAxMi44MTgyNjRdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQx
OTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwDQpbICAgMTIuODI1NzQ3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODMxODA1XSBERUJV
RyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBh
dHRyPTExMA0KWyAgIDEyLjgzODg0NV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
Mjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODM4ODQ5XSBERUJVRyB4ZW5f
c3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxMi44NDUzNjJdIFVuYWJsZSB0byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVy
ZW5jZSBhdCB2aXJ0dWFsIGFkZHJlc3MgMDAwMDAwMDAwMDAwMDAwOA0KWyAgIDEyLjg1MjM5MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
IDEyLjg1ODQ1MV0gTWVtIGFib3J0IGluZm86DQpbICAgMTIuODU4NDUyXSAgIEVTUiA9IDB4OTYw
MDAwNDQNClsgICAxMi44NTg0NTVdICAgRUMgPSAweDI1OiBEQUJUIChjdXJyZW50IEVMKSwgSUwg
PSAzMiBiaXRzDQpbICAgMTIuODY0OTc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODcyNDQzXSAgIFNFVCA9IDAsIEZuViA9IDAN
ClsgICAxMi44NzI0NDRdICAgRUEgPSAwLCBTMVBUVyA9IDANClsgICAxMi44NzI0NDhdIERhdGEg
YWJvcnQgaW5mbzoNClsgICAxMi44Nzg1MTFdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVy
ZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjg4NTk4N10gICBJU1Yg
PSAwLCBJU1MgPSAweDAwMDAwMDQ0DQpbICAgMTIuODg1OTg4XSAgIENNID0gMCwgV25SID0gMQ0K
WyAgIDEyLjg4NTk5Ml0gWzAwMDAwMDAwMDAwMDAwMDhdIHVzZXIgYWRkcmVzcyBidXQgYWN0aXZl
X21tIGlzIHN3YXBwZXINClsgICAxMi44OTMwMThdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjkwMDA0M10gSW50
ZXJuYWwgZXJyb3I6IE9vcHM6IDk2MDAwMDQ0IFsjMV0gUFJFRU1QVCBTTVANClsgICAxMi45MDAw
NDddIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgIDEyLjkwODkyOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjkxNDk2MV0gDQpbICAg
MTIuOTE0OTY1XSBDUFU6IDIgUElEOiA3IENvbW06IGt3b3JrZXIvdTY0OjAgVGFpbnRlZDogRyAg
ICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAxMi45
MTc3ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxMi45MTc3OTBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjkyMDkyM10gV29ya3F1ZXVlOiBudm1l
LXJlc2V0LXdxIG52bWVfcmVzZXRfd29yaw0KWyAgIDEyLjkyNjMzMl0gREVCVUcgeGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIu
OTMyNDA5XSANClsgICAxMi45MzI0MTFdIHBzdGF0ZTogNjBjMDAwODUgKG5aQ3YgZGFJZiArUEFO
ICtVQU8gLVRDTyBCVFlQRT0tLSkNClsgICAxMi45MzI0MTddIHBjIDogc3RlYWxfc3VpdGFibGVf
ZmFsbGJhY2srMHgxMzgvMHgyZjANClsgICAxMi45MzU1MDRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi45Mzg3MTJdIGxyIDogc3Rl
YWxfc3VpdGFibGVfZmFsbGJhY2srMHgxYmMvMHgyZjANClsgICAxMi45Mzg3MTVdIHNwIDogZmZm
ZjgwMDAxMTk2YjgyMA0KWyAgIDEyLjk0MTY1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjk0MTY2M10gREVCVUcgeGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIu
OTQ4NzQwXSB4Mjk6IGZmZmY4MDAwMTE5NmI4MjAgeDI4OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAg
IDEyLjk0ODc0Ml0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMTRkYmNiMCAN
ClsgICAxMi45NDg3NDRdIHgyNTogZmZmZmZkZmZmZmUwMDAwMCB4MjQ6IDAwMDAwMDAwMDAwMDAw
MDEgDQpbICAgMTIuOTQ4NzQ1XSB4MjM6IDAwMDAwMDAwMDAwMDAwMDAgeDIyOiBmZmZmZmUxZmZk
ZjcwMDAwIA0KWyAgIDEyLjk0ODc0N10geDIxOiBmZmZmMDgwNzFlZmVmOTgwIHgyMDogMDAwMDAw
MDAwMDAwMDkwMSANClsgICAxMi45NTI2MTRdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVy
ZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjk1NTYzNl0gDQpbICAg
MTIuOTU1NjM3XSB4MTk6IDAwMDAwMDAwMDAwODAwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0K
WyAgIDEyLjk2MjEwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDEyLjk2OTEzOV0gDQpbICAgMTIuOTY5MTQwXSB4MTc6IDAwMDAwMDAw
MDAwMDAwMGUgeDE2OiAwMDAwMDAwMDAwMDAwMDEyIA0KWyAgIDEyLjk3NDc3Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjk3Nzg1
OV0gDQpbICAgMTIuOTc3ODYyXSB4MTU6IGZmZmY4MDAwOTE5NmI4ZDcgDQpbICAgMTIuOTgzOTgw
XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxMi45ODU0ODBdIHgxNDogMDAwMDAwMDAwMDAwMDAwNiANClsgICAxMi45
OTUyMjFdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjAwMTI0Nl0geDEzOiBmZmZmODAwMDExOTZiOGRmIHgxMjog
MzAzMzM0MzkzMTM0M2Q2NSANClsgICAxMy4wMDgyOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4wMTMyOTldIHgxMTogN2E2OTcz
MjAzNzM5MzIyMCB4MTA6IDAwMDAwMDAwMDAwMDAwMGMgDQpbICAgMTMuMDIwMzYzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMDIx
ODUxXSB4OSA6IGZmZmY4MDAwMTAwMzlkNTggeDggOiAwMDAwMDAwMDgwMDAwMDAwIA0KWyAgIDEz
LjAyNzk5MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMDMzMTA3XSANClsgICAxMy4wMzMxMTVdIHg3IDogMDAw
MDAwMDAwMDAwMDAxOCANClsgICAxMy4wMzkxMDBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjA0NDEyMF0geDYg
OiBmZmZmODAwMDExNzUwODkwIA0KWyAgIDEzLjA0NDEyNF0geDUgOiBmZmZmODAwMDExNzUwODc4
IA0KWyAgIDEzLjA0NzQ4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjA1MzU5NV0geDQgOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAg
IDEzLjA1MzYwMF0geDMgOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgIDEzLjA2MDY0MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjA2
NjAwMl0geDIgOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgIDEzLjA2NjAwNl0geDEgOiAwMDAwMDAw
MDAwMDAwMjAwIA0KWyAgIDEzLjA3MTM4M10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJl
bnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMDc2NzY2XSB4MCA6IDAw
MDAwMDAwMDAwMDAwMDAgDQpbICAgMTMuMDc2NzcwXSBDYWxsIHRyYWNlOg0KWyAgIDEzLjA4MjE0
Nl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTMuMDg3NTMwXSAgc3RlYWxfc3VpdGFibGVfZmFsbGJhY2srMHgxMzgv
MHgyZjANClsgICAxMy4wODc1MzZdICBnZXRfcGFnZV9mcm9tX2ZyZWVsaXN0KzB4ZTMwLzB4MTJh
MA0KWyAgIDEzLjA5NDU4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjA5NjA3Ml0gIF9fYWxsb2NfcGFnZXNfbm9kZW1hc2srMHgx
NDgvMHhlMDANClsgICAxMy4wOTYwNzhdICBfX2RtYV9kaXJlY3RfYWxsb2NfcGFnZXMrMHhhNC8w
eDFkMA0KWyAgIDEzLjEwMTUwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjEwNzU4OV0gIGRtYV9kaXJlY3RfYWxsb2MrMHgxZDgv
MHgzNDANClsgICAxMy4xMDc1OTZdICB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCsweGMwLzB4
MzRjDQpbICAgMTMuMTA5MDkxXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4xMDkwOTRdIERFQlVHIHhlbl9zd2lv
dGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEz
LjExNDUyNV0gIGRtYV9hbGxvY19hdHRycysweDE0NC8weDE2MA0KWyAgIDEzLjExNDUzMV0gIG52
bWVfcmVzZXRfd29yaysweDEwMzAvMHgxNTIwDQpbICAgMTMuMTIwNjExXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMTIyMTE1XSAg
cHJvY2Vzc19vbmVfd29yaysweDFkYy8weDRiYw0KWyAgIDEzLjEyMjExOV0gIHdvcmtlcl90aHJl
YWQrMHgxNDQvMHg0NzANClsgICAxMy4xMjU2MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4xMzI2ODldICBrdGhyZWFkKzB4MTRj
LzB4MTYwDQpbICAgMTMuMTMyNjk0XSAgcmV0X2Zyb21fZm9yaysweDEwLzB4MzgNClsgICAxMy4x
MzYxMTZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjE0MzE5M10gQ29kZTogYTk0MDgyYzQgZDM3ZWY0NjMgY2Iz
YzQwNjMgOGIzYzQwNDIgKGY5MDAwNDgwKSANClsgICAxMy4xNDg1NTNdIERFQlVHIHhlbl9zd2lv
dGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEz
LjE1NDYzOF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I3MiBdLS0tDQpbICAgMTMuMTU0
NjQyXSBub3RlOiBrd29ya2VyL3U2NDowWzddIGV4aXRlZCB3aXRoIHByZWVtcHRfY291bnQgMQ0K
WyAgIDEzLjE2MDAxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDEzLjM2OTQ4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjM3NTU2MF0gREVCVUcgeGVuX3N3aW90bGJf
YWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMzgy
NjAxXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAxMy4zODk2MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4zOTU2OThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy40MDE3NzRdIERFQlVH
IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MA0KWyAgIDEzLjQwODgxNl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNDE1ODQ4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNDIxOTEzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMu
NDI3OTkwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxMy40MzUwMzFdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjQ0MjA2NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEz
LjQ0ODEyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDEzLjQ1NDIwNF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNDYxMjQ3XSBERUJVRyB4ZW5fc3dp
b3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAx
My40NjgyNzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxMy40NzQzNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy40ODA0MjBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9j
X2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjQ4NzQ2NF0g
REVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wDQpbICAgMTMuNDk0NDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNTAwNTU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNTA2NjM3XSBERUJVRyB4ZW5f
c3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxMy41MTM2NzddIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjUyMDcwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjUyNjc3N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjUzMjg1
MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTMuNTM5ODkzXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVu
dCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy41NDY5MjhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy41NTI5
OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxMy41NTkwNjZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjU2NjEwOF0gREVCVUcgeGVuX3N3aW90bGJf
YWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNTcz
MTQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
DQpbICAgMTMuNTc5MjA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgMTMuNTg1MjgxXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hl
cmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy41OTIzMjNdIERFQlVH
IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MA0KWyAgIDEzLjU5OTM1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjYwNTQyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjYxMTQ5Nl0gREVCVUcgeGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMu
NjE4NTM5XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxMy42MjU1NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy42MzE2MzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy42Mzc3MTJdIERF
QlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDEzLjY0NDc1NF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNjUxNzg2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNjU3ODUxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTMuNjYzOTI3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy42NzA5NjldIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9j
X2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjY3ODAwMV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
IDEzLjY4NDA2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDEzLjY5MDE0M10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
Mjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNjk3MTg3XSBERUJVRyB4ZW5f
c3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxMy43MDQyMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxMy43MTAyODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy43MTYzNjBdIERFQlVHIHhlbl9zd2lvdGxiX2Fs
bG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjcyMzQw
MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTMuNzMwNDMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNzM2NTAwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNzQyNTczXSBERUJVRyB4
ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxMy43NDk2MTVdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjc1NjY1MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjc2MjcxM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjc2
ODc4OF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgMTMuNzc1ODMwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hl
cmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy43ODI4NjJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy43
ODg5MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxMy43OTUwMDNdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjgwMjA0Nl0gREVCVUcgeGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMu
ODA5MDc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wDQpbICAgMTMuODE1MTQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTMuODIxMjE5XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19j
b2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy44MjgyNjFdIERF
QlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDEzLjgzNTI5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjg0MTM1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjg0NzQzNF0gREVCVUcgeGVuX3N3
aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTMuODU0NDc2XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy44NjE1MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy44Njc1NzNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy44NzM2NTBd
IERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDEzLjg4MDY5Ml0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
Mjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuODg3NzI2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuODkzNzg4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpb
ICAgMTMuODk5ODY1XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy45MDY5MTBdIERFQlVHIHhlbl9zd2lvdGxiX2Fs
bG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjkxMzkz
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0K
WyAgIDEzLjkyMDAwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDEzLjkyNjA4MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJl
bnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuOTMzMTIyXSBERUJVRyB4
ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxMy45NDAxNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAxMy45NDYyMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy45NTIyOTVdIERFQlVHIHhlbl9zd2lvdGxi
X2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjk1
OTMzN10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgMTMuOTY2MzczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuOTcyNDM0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuOTc4NTExXSBERUJV
RyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxMy45ODU1NTNdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjk5MjU4NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjk5ODY1MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0
LjAwNDcyNl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMDExNzY5XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19j
b2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4wMTg4MDBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAx
NC4wMjQ4NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxNC4wMzA5NDJdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjAzNzk4NF0gREVCVUcgeGVuX3N3
aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTQuMDQ1MDE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wDQpbICAgMTQuMDUxMDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMDU3MTU3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4wNjQxOTld
IERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDE0LjA3MTIzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjA3NzI5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjA4MzM3Ml0gREVCVUcgeGVu
X3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpb
ICAgMTQuMDkwNDE0XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4wOTc0NDldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4xMDM1MTFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4xMDk1
ODhdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDE0LjExNjYzM10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJl
bnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMTIzNjYyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMTI5
NzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
DQpbICAgMTQuMTM1ODAzXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4xNDI4NDVdIERFQlVHIHhlbl9zd2lvdGxi
X2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjE0
OTg3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MA0KWyAgIDE0LjE1NTk0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjE2MjAxOF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29o
ZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMTY5MDYwXSBERUJV
RyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxNC4xNzYwOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxNC4xODIxNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4xODgyMzRdIERFQlVHIHhlbl9zd2lv
dGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0
LjE5NTI3Nl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMjAyMzA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMjA4MzcyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMjE0NDQ5XSBE
RUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxNC4yMjE0OTBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5
NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjIyODUyM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjIzNDU4OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
IDE0LjI0MDY2NV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMjQ3NzA4XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4yNTQ3Mzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxNC4yNjA4MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxNC4yNjY4ODBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50
IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjI3MzkyMV0gREVCVUcgeGVu
X3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpb
ICAgMTQuMjgwOTU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTQuMjg3MDE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMjkzMDk1XSBERUJVRyB4ZW5fc3dpb3RsYl9h
bGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4zMDAx
MzddIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDE0LjMwNzE3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjMxMzI0MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjMxOTMxMF0gREVCVUcg
eGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
DQpbICAgMTQuMzI2MzU2XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4zMzMzODRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4zMzk0NDldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4z
NDU1MjVdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjM1MjU2N10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29o
ZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMzU5NjAwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQu
MzY1NjY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wDQpbICAgMTQuMzcxNzQxXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4zNzg3ODNdIERFQlVHIHhlbl9zd2lv
dGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0
LjM4NTgxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDE0LjM5MTg4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjM5Nzk1Nl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2Nf
Y29oZXJlbnQgMjg2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNDA0OTk4XSBE
RUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxNC40MTIwMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC40MTgwOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC40MjQxNzFdIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
IDE0LjQzMTIxM10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNDM4MjQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNDQ0MzEwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNDUwMzg3
XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxNC40NTc0MzJdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50
IDI5NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjQ2NDQ2MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjQ3MDUy
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0K
WyAgIDE0LjQ3NjYwNV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNDgzNjQ0XSBERUJVRyB4ZW5fc3dpb3RsYl9h
bGxvY19jb2hlcmVudCAyOTcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC40OTA2
NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxNC40OTY3NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAxNC41MDI4MTddIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVy
ZW50IDI4NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjUwOTg1OV0gREVCVUcg
eGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjk3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
DQpbICAgMTQuNTE2ODk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgMTQuNTIyOTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNTI5MDMzXSBERUJVRyB4ZW5fc3dpb3Rs
Yl9hbGxvY19jb2hlcmVudCAyODYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC41
MzYwNzRdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI5NyBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDM0LjE3NDIyNl0gcmN1OiBJTkZPOiByY3VfcHJlZW1wdCBkZXRl
Y3RlZCBzdGFsbHMgb24gQ1BVcy90YXNrczoNClsgICAzNC4xODAzMDVdIHJjdTogCTUtLi4uITog
KDUgR1BzIGJlaGluZCkgaWRsZT0wYzYvMS8weDQwMDAwMDAwMDAwMDAwMDAgc29mdGlycT0zOS8z
OSBmcXM9NTY5IA0KWyAgIDM0LjE4ODkzMl0gCShkZXRlY3RlZCBieSAyLCB0PTUyNTIgamlmZmll
cywgZz0tMTA3MSwgcT0yKQ0KDQo=

--_005_49E3535A56724047AF8605D5597C7019armcom_
Content-Type: application/octet-stream; name="native_linux_boot_debug.log"
Content-Description: native_linux_boot_debug.log
Content-Disposition: attachment; filename="native_linux_boot_debug.log";
	size=384090; creation-date="Tue, 19 Apr 2022 13:36:49 GMT";
	modification-date="Tue, 19 Apr 2022 13:36:49 GMT"
Content-ID: <38F0BB9955672C49B8E525341F56B74C@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogVHVlIEFwciAxOSAxNDowOToyMiBvbiB0dHlzMDAxCnJhaHNpbjAxQEMwMlpY
MEc5TFZETiB+ICUgdGVsbmV0IGUxMjMzNDMuY2FtYnJpZGdlLmFybS5jb20gMTAwMjAKVHJ5aW5n
IDEwLjEuMTk0LjI1Li4uCkNvbm5lY3RlZCB0byBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29tLgpF
c2NhcGUgY2hhcmFjdGVyIGlzICdeXScuCgpBSVMgdGFyZ2V0IHN5c3RlbSBwb3J0IDEwMDIwIGRl
dmljZSAvZGV2L3R0eVVTQjEgWzExNTIwMCBOODFdCgoKRlMwOlxFRklcQk9PVFw+IApGUzA6XEVG
SVxCT09UXD4gCkZTMDpcRUZJXEJPT1RcPiBib290YWE2NC5lZmkKV2VsY29tZSB0byBHUlVCIQoK
ZXJyb3I6IG5vIHN1Y2ggZGV2aWNlOiAoKGhkMCxncHQxKS9FRkkvQk9PVCkvRUZJL0JPT1QvZ3J1
Yi5jZmcuCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBHTlUgR1JVQiAgdmVyc2lvbiAyLjA2CgogLy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS1cCiB8IFBBUlRV
VUlEIEJvb3Q6IENPTS1IUEMgWW9jdG8gSW1hZ2UgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHwgCiB8IE5WTWUgTS4yICBTU0QgQm9vdDogQ09NLUhQQyBZb2N0byBJbWFn
ZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwqVVNCIEJvb3QgKElmIERy
aXZlIGlzIHByZXNlbnQpOiBDT00tSFBDIFlvY3RvIEltYWdlICAgICAgICAgICAgICAgICAgICAg
ICAgfAogfCBDT00tSFBDIFlvY3RvIEltYWdlIChYZW4pICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB8IAogXC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0vCgogICAgICBVc2UgdGhlIF4gYW5kIHYga2V5
cyB0byBzZWxlY3Qgd2hpY2ggZW50cnkgaXMgaGlnaGxpZ2h0ZWQuICAgICAgICAgIAogICAgICBQ
cmVzcyBlbnRlciB0byBib290IHRoZSBzZWxlY3RlZCBPUywgYGUnIHRvIGVkaXQgdGhlIGNvbW1h
bmRzICAgICAgIAogICAgICBiZWZvcmUgYm9vdGluZyBvciBgYycgZm9yIGEgY29tbWFuZC1saW5l
LiAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoK
CgoKCgoKCgoKCgpFRkkgc3R1YjogQm9vdGluZyBMaW51eCBLZXJuZWwuLi4KRUZJIHN0dWI6IFVz
aW5nIERUQiBmcm9tIGNvbmZpZ3VyYXRpb24gdGFibGUKRUZJIHN0dWI6IEV4aXRpbmcgYm9vdCBz
ZXJ2aWNlcyBhbmQgaW5zdGFsbGluZyB2aXJ0dWFsIGFkZHJlc3MgbWFwLi4uClBST0dSRVNTIENP
REU6IFYwMzEwMTAxOSBJMApbICAgIDAuMDAwMDAwXSBCb290aW5nIExpbnV4IG9uIHBoeXNpY2Fs
IENQVSAweDAwMDAxMDAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDAwMDBdIExpbnV4IHZlcnNp
b24gNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAob2UtdXNlckBvZS1ob3N0KSAoYWFyY2g2
NC1wb2t5LWxpbnV4LWdjYyAoR0NDKSAxMS4yLjAsIEdOVSBsZCAoR05VIEJpbnV0aWxzKSAyLjM3
LjIwMjEwNzIxKSAjMSBTTVAgUFJFRU1QVCBTYXQgU2VwIDE4IDA2OjAxOjU5IFVUQyAyMDIxClsg
ICAgMC4wMDAwMDBdIGVmaTogRUZJIHYyLjcwIGJ5IEVESyBJSQpbICAgIDAuMDAwMDAwXSBlZmk6
IFRQTUZpbmFsTG9nPTB4ODA3ZjllZjAwMDAgQUNQSSAyLjA9MHg4MDdmYTBkMDAxOCBTTUJJT1Mg
My4wPTB4ODA3ZjhlMzAwMDAgTUVNQVRUUj0weDgwN2Y3MmUxMDE4IEVTUlQ9MHg4MDdmN2Y2Y2Ex
OCBUUE1FdmVudExvZz0weDgwN2Y3MjJkMDE4IFJORz0weGZmYjRiYTk4IE1FTVJFU0VSVkU9MHg4
MDdmN2VkM2U5OCAKWyAgICAwLjAwMDAwMF0gZWZpOiBzZWVkaW5nIGVudHJvcHkgcG9vbApbICAg
IDAuMDAwMDAwXSBlc3J0OiBSZXNlcnZpbmcgRVNSVCBzcGFjZSBmcm9tIDB4MDAwMDA4MDdmN2Y2
Y2ExOCB0byAweDAwMDAwODA3ZjdmNmNhNTAuClsgICAgMC4wMDAwMDBdIEFDUEk6IEVhcmx5IHRh
YmxlIGNoZWNrc3VtIHZlcmlmaWNhdGlvbiBkaXNhYmxlZApbICAgIDAuMDAwMDAwXSBBQ1BJOiBS
U0RQIDB4MDAwMDA4MDdGQTBEMDAxOCAwMDAwMjQgKHYwMiBBbXBlcmUpClsgICAgMC4wMDAwMDBd
IEFDUEk6IFhTRFQgMHgwMDAwMDgwN0ZBMERGRTk4IDAwMDBBNCAodjAxIEFtcGVyZSBBbHRyYSAg
ICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBGQUNQIDB4MDAw
MDA4MDdGQTBERkI5OCAwMDAxMTQgKHYwNiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAw
MTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogRFNEVCAweDAwMDAwODA3RjhEQjAwMTggMDJD
MTlFICh2MDIgQW1wZXJlIEphZGUgICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpClsgICAgMC4w
MDAwMDBdIEFDUEk6IEJFUlQgMHgwMDAwMDgwN0ZBMERGRjk4IDAwMDAzMCAodjAxIEFtcGVyZSBB
bHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBEQkcy
IDB4MDAwMDA4MDdGQTBERkE5OCAwMDAwNUMgKHYwMCBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIg
QU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogR1REVCAweDAwMDAwODA3RkEwREU5
OTggMDAwMTEwICh2MDMgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsg
ICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1IgMHgwMDAwMDgwN0ZBMERGRTE4IDAwMDA1MCAodjAyIEFt
cGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBFSU5KIDB4MDAwMDA4MDdGQTBERjU5OCAwMDAxNTAgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAw
MDAwMDEgSU5UTCAyMDIwMTIxNykKWyAgICAwLjAwMDAwMF0gQUNQSTogSEVTVCAweDAwMDAwODA3
RkEwREVCMTggMDAwMUY0ICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIElOVEwgMjAyMDEy
MTcpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNTRFQgMHgwMDAwMDgwN0ZBMERGQTE4IDAwMDAyRCAo
djAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAxMjE3KQpbICAgIDAuMDAwMDAw
XSBBQ1BJOiBUUE0yIDB4MDAwMDA4MDdGQTBERkQxOCAwMDAwNEMgKHYwNCBBbXBlcmUgQWx0cmEg
ICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogTUNGRyAweDAw
MDAwODA3RkEwREY3MTggMDAwMDdDICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIEFNUC4g
MDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IElPUlQgMHgwMDAwMDgwN0ZBMERFRjE4IDAw
MDNEQyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBBUElDIDB4MDAwMDA4MDdGQTBENzUxOCAwMDBBRjQgKHYwNSBBbXBlcmUg
QWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogUFBU
VCAweDAwMDAwODA3RkEwRDg2MTggMDA0NTIwICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAy
IEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNMSVQgMHgwMDAwMDgwN0ZBMERG
RDk4IDAwMDAyRCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpb
ICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUIDB4MDAwMDA4MDdGQTBEQ0UxOCAwMDAzNzAgKHYwMyBB
bXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQ
STogUENDVCAweDAwMDAwODA3RkEwREUzMTggMDAwNTc2ICh2MDIgQW1wZXJlIEFsdHJhICAgIDAw
MDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1I6IGNvbnNvbGU6
IHBsMDExLG1taW8zMiwweDEwMDAwMjYwMDAwMCwxMTUyMDAKWyAgICAwLjAwMDAwMF0gQUNQSTog
U1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4ODMwMDAwMC0weDg4M2ZmZmZmXQpbICAgIDAuMDAw
MDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDkwMDAwMDAwLTB4ZmZmZmZmZmZd
ClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODAwMDAwMDAw
MDAtMHg4MDA3ZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAw
IFttZW0gMHg4MDEwMDAwMDAwMC0weDgwN2ZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSBOVU1BOiBO
T0RFX0RBVEEgW21lbSAweDgwN2ZjMDcwZTAwLTB4ODA3ZmMwNzJmZmZdClsgICAgMC4wMDAwMDBd
IFpvbmUgcmFuZ2VzOgpbICAgIDAuMDAwMDAwXSAgIERNQSAgICAgIFttZW0gMHgwMDAwMDAwMDg4
MzAwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBETUEzMiAgICBlbXB0
eQpbICAgIDAuMDAwMDAwXSAgIE5vcm1hbCAgIFttZW0gMHgwMDAwMDAwMTAwMDAwMDAwLTB4MDAw
MDA4MDdmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gTW92YWJsZSB6b25lIHN0YXJ0IGZvciBlYWNo
IG5vZGUKWyAgICAwLjAwMDAwMF0gRWFybHkgbWVtb3J5IG5vZGUgcmFuZ2VzClsgICAgMC4wMDAw
MDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMDg4MzAwMDAwLTB4MDAwMDAwMDA4ODNmZmZm
Zl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwOTAwMDAwMDAtMHgw
MDAwMDAwMDkxZmZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAw
MDA5MjAwMDAwMC0weDAwMDAwMDAwOTI3YmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6
IFttZW0gMHgwMDAwMDAwMDkyN2MwMDAwLTB4MDAwMDAwMDBmZmIzZmZmZl0KWyAgICAwLjAwMDAw
MF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwZmZiNDAwMDAtMHgwMDAwMDAwMGZmYjRmZmZm
XQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAwMDBmZmI1MDAwMC0weDAw
MDAwMDAwZmZmZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgw
MDAwMDAwMDAwLTB4MDAwMDA4MDA3ZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDog
W21lbSAweDAwMDAwODAxMDAwMDAwMDAtMHgwMDAwMDgwN2Y1ZmMzZmZmXQpbICAgIDAuMDAwMDAw
XSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmNWZjNDAwMC0weDAwMDAwODA3ZjY2ODZmZmZd
ClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y2Njg3MDAwLTB4MDAw
MDA4MDdmNzIzZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3
ZjcyNDAwMDAtMHgwMDAwMDgwN2Y3MmRmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBb
bWVtIDB4MDAwMDA4MDdmNzJlMDAwMC0weDAwMDAwODA3ZjdlOWZmZmZdClsgICAgMC4wMDAwMDBd
ICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y3ZWEwMDAwLTB4MDAwMDA4MDdmN2ViZmZmZl0K
WyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjdlYzAwMDAtMHgwMDAw
MDgwN2Y3ZjBmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdm
N2YxMDAwMC0weDAwMDAwODA3ZjdmNGZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFtt
ZW0gMHgwMDAwMDgwN2Y3ZjUwMDAwLTB4MDAwMDA4MDdmODdlZmZmZl0KWyAgICAwLjAwMDAwMF0g
ICBub2RlICAgMDogW21lbSAweDAwMDAwODA3Zjg3ZjAwMDAtMHgwMDAwMDgwN2Y4ODJmZmZmXQpb
ICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmODgzMDAwMC0weDAwMDAw
ODA3ZjhhNmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4
YTcwMDAwLTB4MDAwMDA4MDdmOGFhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21l
bSAweDAwMDAwODA3ZjhhYjAwMDAtMHgwMDAwMDgwN2Y4ZTFmZmZmXQpbICAgIDAuMDAwMDAwXSAg
IG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOGUyMDAwMC0weDAwMDAwODA3ZjhlM2ZmZmZdClsg
ICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4ZTQwMDAwLTB4MDAwMDA4
MDdmOGU2ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3Zjhl
NzAwMDAtMHgwMDAwMDgwN2Y5ZTdmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVt
IDB4MDAwMDA4MDdmOWU4MDAwMC0weDAwMDAwODA3ZjllZWZmZmZdClsgICAgMC4wMDAwMDBdICAg
bm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y5ZWYwMDAwLTB4MDAwMDA4MDdmOWYxZmZmZl0KWyAg
ICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjlmMjAwMDAtMHgwMDAwMDgw
N2Y5ZmJmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOWZj
MDAwMC0weDAwMDAwODA3ZjlmZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0g
MHgwMDAwMDgwN2ZhMDAwMDAwLTB4MDAwMDA4MDdmYTBmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBu
b2RlICAgMDogW21lbSAweDAwMDAwODA3ZmExMDAwMDAtMHgwMDAwMDgwN2ZhMTlmZmZmXQpbICAg
IDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTFhMDAwMC0weDAwMDAwODA3
ZmEyNmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhMjcw
MDAwLTB4MDAwMDA4MDdmYTRhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAw
eDAwMDAwODA3ZmE0YjAwMDAtMHgwMDAwMDgwN2ZhNzFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5v
ZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTcyMDAwMC0weDAwMDAwODA3ZmE3NWZmZmZdClsgICAg
MC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhNzYwMDAwLTB4MDAwMDA4MDdm
YThjZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmE4ZDAw
MDAtMHgwMDAwMDgwN2ZhOTZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4
MDAwMDA4MDdmYTk3MDAwMC0weDAwMDAwODA3ZmE5ZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9k
ZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhYTAwMDAwLTB4MDAwMDA4MDdmYmFhZmZmZl0KWyAgICAw
LjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmJhYjAwMDAtMHgwMDAwMDgwN2Zi
YjNmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmI0MDAw
MC0weDAwMDAwODA3ZmJiZGZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgw
MDAwMDgwN2ZiYmUwMDAwLTB4MDAwMDA4MDdmYmNhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2Rl
ICAgMDogW21lbSAweDAwMDAwODA3ZmJjYjAwMDAtMHgwMDAwMDgwN2ZiY2VmZmZmXQpbICAgIDAu
MDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmNmMDAwMC0weDAwMDAwODA3ZmJk
NWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZiZDYwMDAw
LTB4MDAwMDA4MDdmYmRmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAw
MDAwODA3ZmJlMDAwMDAtMHgwMDAwMDgwN2ZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSBJbml0bWVt
IHNldHVwIG5vZGUgMCBbbWVtIDB4MDAwMDAwMDA4ODMwMDAwMC0weDAwMDAwODA3ZmZmZmZmZmZd
ClsgICAgMC4wMDAwMDBdIHBzY2k6IHByb2JpbmcgZm9yIGNvbmR1aXQgbWV0aG9kIGZyb20gQUNQ
SS4KWyAgICAwLjAwMDAwMF0gcHNjaTogUFNDSXYxLjEgZGV0ZWN0ZWQgaW4gZmlybXdhcmUuClsg
ICAgMC4wMDAwMDBdIHBzY2k6IFVzaW5nIHN0YW5kYXJkIFBTQ0kgdjAuMiBmdW5jdGlvbiBJRHMK
WyAgICAwLjAwMDAwMF0gcHNjaTogTUlHUkFURV9JTkZPX1RZUEUgbm90IHN1cHBvcnRlZC4KWyAg
ICAwLjAwMDAwMF0gcHNjaTogU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4yClsgICAgMC4wMDAw
MDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ODAwMDAgLT4gTm9kZSAwClsg
ICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ODAxMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
OTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+
IE1QSURSIDB4OTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6
IFBYTSAwIC0+IE1QSURSIDB4ZTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5V
TUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBd
IEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZjAwMDAgLT4gTm9kZSAwClsgICAg
MC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZjAxMDAgLT4gTm9k
ZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTAw
MDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBN
UElEUiAweDEwMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDog
UFhNIDAgLT4gTVBJRFIgMHgxMTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5V
TUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTEwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAw
XSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE2MDAwMCAtPiBOb2RlIDAKWyAg
ICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxNjAxMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
MTcwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAt
PiBNUElEUiAweDE3MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JB
VDogUFhNIDAgLT4gTVBJRFIgMHgxODAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6
IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTgwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAw
MDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE5MDAwMCAtPiBOb2RlIDAK
WyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxOTAxMDAg
LT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURS
IDB4MWUwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0g
MCAtPiBNUElEUiAweDFlMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTog
U1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxZjAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFD
UEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MWYwMTAwIC0+IE5vZGUgMApbICAgIDAu
MDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDIwMDAwMCAtPiBOb2Rl
IDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgyMDAx
MDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1Q
SURSIDB4MjEwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQ
WE0gMCAtPiBNUElEUiAweDIxMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVN
QTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgyNjAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBd
IEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MjYwMTAwIC0+IE5vZGUgMApbICAg
IDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDI3MDAwMCAtPiBO
b2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgy
NzAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIHBlcmNwdTogRW1iZWRkZWQgMzEgcGFnZXMv
Y3B1IHM4OTI0MCByODE5MiBkMjk1NDQgdTEyNjk3NgpbICAgIDAuMDAwMDAwXSBEZXRlY3RlZCBQ
SVBUIEktY2FjaGUgb24gQ1BVMApbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVk
OiBHSUMgc3lzdGVtIHJlZ2lzdGVyIENQVSBpbnRlcmZhY2UKWyAgICAwLjAwMDAwMF0gQ1BVIGZl
YXR1cmVzOiBkZXRlY3RlZDogVmlydHVhbGl6YXRpb24gSG9zdCBFeHRlbnNpb25zClsgICAgMC4w
MDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEhhcmR3YXJlIGRpcnR5IGJpdCBtYW5hZ2Vt
ZW50ClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFNwZWN0cmUtdjQKWyAg
ICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQVJNIGVycmF0dW0gMTQxODA0MApb
ICAgIDAuMDAwMDAwXSBhbHRlcm5hdGl2ZXM6IHBhdGNoaW5nIGtlcm5lbCBjb2RlClsgICAgMC4w
MDAwMDBdIEJ1aWx0IDEgem9uZWxpc3RzLCBtb2JpbGl0eSBncm91cGluZyBvbi4gIFRvdGFsIHBh
Z2VzOiA4MTkzMjc2ClsgICAgMC4wMDAwMDBdIFBvbGljeSB6b25lOiBOb3JtYWwKWyAgICAwLjAw
MDAwMF0gS2VybmVsIGNvbW1hbmQgbGluZTogQk9PVF9JTUFHRT0vSW1hZ2Ugcm9vdHdhaXQgcncg
cm9vdD0vZGV2L3NkYTIKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbiBpbmRpdmlk
dWFsIG1heCBjcHUgY29udHJpYnV0aW9uOiA0MDk2IGJ5dGVzClsgICAgMC4wMDAwMDBdIHByaW50
azogbG9nX2J1Zl9sZW4gdG90YWwgY3B1X2V4dHJhIGNvbnRyaWJ1dGlvbnM6IDEyNjk3NiBieXRl
cwpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVuIG1pbiBzaXplOiAxMzEwNzIgYnl0
ZXMKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbjogMjYyMTQ0IGJ5dGVzClsgICAg
MC4wMDAwMDBdIHByaW50azogZWFybHkgbG9nIGJ1ZiBmcmVlOiAxMjEyNDgoOTIlKQpbICAgIDAu
MDAwMDAwXSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA0MTk0MzA0IChvcmRlcjog
MTMsIDMzNTU0NDMyIGJ5dGVzLCBsaW5lYXIpClsgICAgMC4wMDAwMDBdIElub2RlLWNhY2hlIGhh
c2ggdGFibGUgZW50cmllczogMjA5NzE1MiAob3JkZXI6IDEyLCAxNjc3NzIxNiBieXRlcywgbGlu
ZWFyKQpbICAgIDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBzdGFjazpvZmYsIGhlYXAgYWxsb2M6
b2ZmLCBoZWFwIGZyZWU6b2ZmClsgICAgMC4wMDAwMDBdIHNvZnR3YXJlIElPIFRMQjogbWFwcGVk
IFttZW0gMHgwMDAwMDAwMGZiYjQwMDAwLTB4MDAwMDAwMDBmZmI0MDAwMF0gKDY0TUIpClsgICAg
MC4wMDAwMDBdIE1lbW9yeTogMzI1MDIxODhLLzMzMjkzMzEySyBhdmFpbGFibGUgKDEzNTY4SyBr
ZXJuZWwgY29kZSwgMTk5NksgcndkYXRhLCAzNDc2SyByb2RhdGEsIDQxNjBLIGluaXQsIDgyMksg
YnNzLCA3OTExMjRLIHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2ZWQpClsgICAgMC4wMDAwMDBdIFNM
VUI6IEhXYWxpZ249NjQsIE9yZGVyPTAtMywgTWluT2JqZWN0cz0wLCBDUFVzPTMyLCBOb2Rlcz0x
ClsgICAgMC4wMDAwMDBdIGZ0cmFjZTogYWxsb2NhdGluZyA0MTMwNiBlbnRyaWVzIGluIDE2MiBw
YWdlcwpbICAgIDAuMDAwMDAwXSBmdHJhY2U6IGFsbG9jYXRlZCAxNjIgcGFnZXMgd2l0aCAzIGdy
b3VwcwpbICAgIDAuMDAwMDAwXSByY3U6IFByZWVtcHRpYmxlIGhpZXJhcmNoaWNhbCBSQ1UgaW1w
bGVtZW50YXRpb24uClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSBldmVudCB0cmFjaW5nIGlzIGVu
YWJsZWQuClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSByZXN0cmljdGluZyBDUFVzIGZyb20gTlJf
Q1BVUz0yNTYgdG8gbnJfY3B1X2lkcz0zMi4KWyAgICAwLjAwMDAwMF0gCVRyYW1wb2xpbmUgdmFy
aWFudCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gCVJ1ZGUgdmFyaWFudCBv
ZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gCVRyYWNpbmcgdmFyaWFudCBvZiBU
YXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gcmN1OiBSQ1UgY2FsY3VsYXRlZCB2YWx1
ZSBvZiBzY2hlZHVsZXItZW5saXN0bWVudCBkZWxheSBpcyAyNSBqaWZmaWVzLgpbICAgIDAuMDAw
MDAwXSByY3U6IEFkanVzdGluZyBnZW9tZXRyeSBmb3IgcmN1X2Zhbm91dF9sZWFmPTE2LCBucl9j
cHVfaWRzPTMyClsgICAgMC4wMDAwMDBdIE5SX0lSUVM6IDY0LCBucl9pcnFzOiA2NCwgcHJlYWxs
b2NhdGVkIGlycXM6IDAKWyAgICAwLjAwMDAwMF0gR0lDdjM6IEdJQzogVXNpbmcgc3BsaXQgRU9J
L0RlYWN0aXZhdGUgbW9kZQpbICAgIDAuMDAwMDAwXSBHSUN2MzogNjcyIFNQSXMgaW1wbGVtZW50
ZWQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IDAgRXh0ZW5kZWQgU1BJcyBpbXBsZW1lbnRlZApbICAg
IDAuMDAwMDAwXSBHSUN2MzogRGlzdHJpYnV0b3IgaGFzIG5vIFJhbmdlIFNlbGVjdG9yIHN1cHBv
cnQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IDE2IFBQSXMgaW1wbGVtZW50ZWQKWyAgICAwLjAwMDAw
MF0gR0lDdjM6IENQVTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTAwMDAwIHJlZ2lvbiAwOjB4MDAw
MDEwMDEwMDU0MDAwMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMCAtPiBOb2Rl
IDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDEgLT4gTm9kZSAwClsgICAgMC4w
MDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyAyIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBTUkFU
OiBQWE0gMCAtPiBJVFMgMyAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4g
SVRTIDQgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA1IC0+IE5v
ZGUgMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNiAtPiBOb2RlIDAKWyAgICAw
LjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDcgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIElU
UyBbbWVtIDB4MTAwMTAwMDQwMDAwLTB4MTAwMTAwMDVmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNA
MHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDIyMDAwMCAo
aW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAw
MDEwMDEwMDA0MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAw
MDAyMzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRT
IFttZW0gMHgxMDAxMDAwNjAwMDAtMHgxMDAxMDAwN2ZmZmZdClsgICAgMC4wMDAwMDBdIElUU0Aw
eDAwMDAxMDAxMDAwNjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMjUwMDAwIChp
bmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAw
MTAwMTAwMDYwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAw
MDI2MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFMg
W21lbSAweDEwMDEwMDA4MDAwMC0weDEwMDEwMDA5ZmZmZl0KWyAgICAwLjAwMDAwMF0gSVRTQDB4
MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAyODAwMDAgKGlu
ZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAx
MDAxMDAwODAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAw
MjkwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUUyBb
bWVtIDB4MTAwMTAwMGEwMDAwLTB4MTAwMTAwMGJmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNAMHgw
MDAwMTAwMTAwMGEwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDJiMDAwMCAoaW5k
aXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEw
MDEwMDBhMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAy
YzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTIFtt
ZW0gMHgxMDAxMDAwYzAwMDAtMHgxMDAxMDAwZGZmZmZdClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMmUwMDAwIChpbmRp
cmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMGMwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDJm
MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFMgW21l
bSAweDEwMDEwMDBlMDAwMC0weDEwMDEwMDBmZmZmZl0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAw
MDEwMDEwMDBlMDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAzMTAwMDAgKGluZGly
ZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAx
MDAwZTAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMzIw
MDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUUyBbbWVt
IDB4MTAwMTAwMTAwMDAwLTB4MTAwMTAwMTFmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAw
MTAwMTAwMTAwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDM0MDAwMCAoaW5kaXJl
Y3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEw
MDEwMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAzNTAw
MDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTIFttZW0g
MHgxMDAxMDAxMjAwMDAtMHgxMDAxMDAxM2ZmZmZdClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAx
MDAxMDAxMjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMzcwMDAwIChpbmRpcmVj
dCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAw
MTIwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDM4MDAw
MCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBHSUN2MzogdXNp
bmcgTFBJIHByb3BlcnR5IHRhYmxlIEAweDAwMDAwODAwMDAzOTAwMDAKWyAgICAwLjAwMDAwMF0g
R0lDdjM6IENQVTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwM2EwMDAwClsgICAgMC4wMDAwMDBdIHJhbmRvbTogZ2V0X3JhbmRvbV9ieXRlcyBjYWxsZWQg
ZnJvbSBzdGFydF9rZXJuZWwrMHgzOTQvMHg1NTQgd2l0aCBjcm5nX2luaXQ9MApbICAgIDAuMDAw
MDAwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1
bSAxNDE4MDQwClsgICAgMC4wMDAwMDBdIEFDUEkgR1REVDogZm91bmQgMSBtZW1vcnktbWFwcGVk
IHRpbWVyIGJsb2NrKHMpLgpbICAgIDAuMDAwMDAwXSBhcmNoX3RpbWVyOiBjcDE1IGFuZCBtbWlv
IHRpbWVyKHMpIHJ1bm5pbmcgYXQgMjUuMDBNSHogKHBoeXMvcGh5cykuClsgICAgMC4wMDAwMDBd
IGNsb2Nrc291cmNlOiBhcmNoX3N5c19jb3VudGVyOiBtYXNrOiAweGZmZmZmZmZmZmZmZmZmIG1h
eF9jeWNsZXM6IDB4NWM0MDkzOWI1LCBtYXhfaWRsZV9uczogNDQwNzk1MjAyNjQ2IG5zClsgICAg
MC4wMDAwMDFdIHNjaGVkX2Nsb2NrOiA1NiBiaXRzIGF0IDI1TUh6LCByZXNvbHV0aW9uIDQwbnMs
IHdyYXBzIGV2ZXJ5IDQzOTgwNDY1MTExMDBucwpbICAgIDAuMDAwMDU0XSBDb25zb2xlOiBjb2xv
dXIgZHVtbXkgZGV2aWNlIDgweDI1ClsgICAgMC4wMDAwNzRdIEFDUEk6IENvcmUgcmV2aXNpb24g
MjAyMDA5MjUKWyAgICAwLjAwMDQ5MF0gQ2FsaWJyYXRpbmcgZGVsYXkgbG9vcCAoc2tpcHBlZCks
IHZhbHVlIGNhbGN1bGF0ZWQgdXNpbmcgdGltZXIgZnJlcXVlbmN5Li4gNTAuMDAgQm9nb01JUFMg
KGxwaj0xMDAwMDApClsgICAgMC4wMDA0OTRdIHBpZF9tYXg6IGRlZmF1bHQ6IDMyNzY4IG1pbmlt
dW06IDMwMQpbICAgIDAuMDAwNTIyXSBMU006IFNlY3VyaXR5IEZyYW1ld29yayBpbml0aWFsaXpp
bmcKWyAgICAwLjAwMDY1MF0gTW91bnQtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAo
b3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAgIDAuMDAwNzM0XSBNb3VudHBvaW50
LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA3LCA1MjQyODggYnl0ZXMs
IGxpbmVhcikKWyAgICAwLjAwMTU4M10gcmN1OiBIaWVyYXJjaGljYWwgU1JDVSBpbXBsZW1lbnRh
dGlvbi4KWyAgICAwLjAwMTcxMF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwNDAwMDAgZG9t
YWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxNF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwNjAw
MDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxN10gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAx
MDAwODAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyMF0gUGxhdGZvcm0gTVNJOiBJVFNA
MHgxMDAxMDAwYTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyM10gUGxhdGZvcm0gTVNJ
OiBJVFNAMHgxMDAxMDAwYzAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyNl0gUGxhdGZv
cm0gTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyOV0g
UGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMDAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAw
MTczM10gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMjAwMDAgZG9tYWluIGNyZWF0ZWQKWyAg
ICAwLjAwMTc0MF0gUENJL01TSTogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkClsg
ICAgMC4wMDE3NDNdIFBDSS9NU0k6IElUU0AweDEwMDEwMDA2MDAwMCBkb21haW4gY3JlYXRlZApb
ICAgIDAuMDAxNzQ1XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9tYWluIGNyZWF0ZWQK
WyAgICAwLjAwMTc0OF0gUENJL01TSTogSVRTQDB4MTAwMTAwMGEwMDAwIGRvbWFpbiBjcmVhdGVk
ClsgICAgMC4wMDE3NTFdIFBDSS9NU0k6IElUU0AweDEwMDEwMDBjMDAwMCBkb21haW4gY3JlYXRl
ZApbICAgIDAuMDAxNzU0XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0
ZWQKWyAgICAwLjAwMTc1N10gUENJL01TSTogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBjcmVh
dGVkClsgICAgMC4wMDE3NjFdIFBDSS9NU0k6IElUU0AweDEwMDEwMDEyMDAwMCBkb21haW4gY3Jl
YXRlZApbICAgIDAuMDAxNzY4XSBSZW1hcHBpbmcgYW5kIGVuYWJsaW5nIEVGSSBzZXJ2aWNlcy4K
WyAgICAwLjAwMzYwOF0gc21wOiBCcmluZ2luZyB1cCBzZWNvbmRhcnkgQ1BVcyAuLi4KWyAgICAw
LjAwMzg1NV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEKWyAgICAwLjAwMzg4NF0gR0lD
djM6IENQVTE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTgwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDc0MDAwMApbICAgIDAuMDAzOTA4XSBHSUN2MzogQ1BVMTogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzYjAwMDAKWyAgICAwLjAwMzk1M10gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDAzOTY5XSBDUFUxOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxODAwMDAg
WzB4NDEzZmQwYzFdClsgICAgMC4wMDQzNTVdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUy
ClsgICAgMC4wMDQzODJdIEdJQ3YzOiBDUFUyOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDE2MDAwMCBy
ZWdpb24gMDoweDAwMDAxMDAxMDA2YzAwMDAKWyAgICAwLjAwNDQwNl0gR0lDdjM6IENQVTI6IHVz
aW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2MwMDAwClsgICAg
MC4wMDQ0NTNdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBl
cnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwNDQ2OV0gQ1BVMjogQm9vdGVkIHNlY29uZGFyeSBwcm9j
ZXNzb3IgMHgwMDAwMTYwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA0NzY0XSBEZXRlY3RlZCBQ
SVBUIEktY2FjaGUgb24gQ1BVMwpbICAgIDAuMDA0NzkyXSBHSUN2MzogQ1BVMzogZm91bmQgcmVk
aXN0cmlidXRvciAxZTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOGMwMDAwClsgICAgMC4wMDQ4
MTZdIEdJQ3YzOiBDUFUzOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAw
MDA4MDAwMDNkMDAwMApbICAgIDAuMDA0ODY0XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3
b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDQ4ODBdIENQVTM6IEJv
b3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDFlMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAw
LjAwNTE1OF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTQKWyAgICAwLjAwNTE3OF0gR0lD
djM6IENQVTQ6IGZvdW5kIHJlZGlzdHJpYnV0b3IgODAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
MzQwMDAwClsgICAgMC4wMDUyMDNdIEdJQ3YzOiBDUFU0OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNlMDAwMApbICAgIDAuMDA1MjUxXSBhcmNoX3RpbWVy
OiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAg
MC4wMDUyNjNdIENQVTQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDA4MDAwMCBb
MHg0MTNmZDBjMV0KWyAgICAwLjAwNTU1Nl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTUK
WyAgICAwLjAwNTU4NV0gR0lDdjM6IENQVTU6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjAwMDAwIHJl
Z2lvbiAwOjB4MDAwMDEwMDEwMDk0MDAwMApbICAgIDAuMDA1NjEwXSBHSUN2MzogQ1BVNTogdXNp
bmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzZjAwMDAKWyAgICAw
LjAwNTY1N10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVy
cmF0dW0gMTQxODA0MApbICAgIDAuMDA1NjczXSBDUFU1OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nl
c3NvciAweDAwMDAyMDAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDU5NTFdIERldGVjdGVkIFBJ
UFQgSS1jYWNoZSBvbiBDUFU2ClsgICAgMC4wMDU5NzRdIEdJQ3YzOiBDUFU2OiBmb3VuZCByZWRp
c3RyaWJ1dG9yIGUwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDRjMDAwMApbICAgIDAuMDA2MDAw
XSBHSUN2MzogQ1BVNjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAw
ODAwMDA4MDAwMDAKWyAgICAwLjAwNjA1MF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29y
a2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA2MDY0XSBDUFU2OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwZTAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4w
MDYzNjBdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFU3ClsgICAgMC4wMDYzOTJdIEdJQ3Yz
OiBDUFU3OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDI2MDAwMCByZWdpb24gMDoweDAwMDAxMDAxMDBh
YzAwMDAKWyAgICAwLjAwNjQxN10gR0lDdjM6IENQVTc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVu
ZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODEwMDAwClsgICAgMC4wMDY0NjZdIGFyY2hfdGltZXI6
IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAw
LjAwNjQ4NF0gQ1BVNzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjYwMDAwIFsw
eDQxM2ZkMGMxXQpbICAgIDAuMDA2NzYyXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVOApb
ICAgIDAuMDA2Nzg2XSBHSUN2MzogQ1BVODogZm91bmQgcmVkaXN0cmlidXRvciAxMTAwMDAgcmVn
aW9uIDA6MHgwMDAwMTAwMTAwNTgwMDAwClsgICAgMC4wMDY4MTFdIEdJQ3YzOiBDUFU4OiB1c2lu
ZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDgyMDAwMApbICAgIDAu
MDA2ODU5XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJy
YXR1bSAxNDE4MDQwClsgICAgMC4wMDY4NzJdIENQVTg6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vz
c29yIDB4MDAwMDExMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNzE3MF0gRGV0ZWN0ZWQgUElQ
VCBJLWNhY2hlIG9uIENQVTkKWyAgICAwLjAwNzE5Nl0gR0lDdjM6IENQVTk6IGZvdW5kIHJlZGlz
dHJpYnV0b3IgMTkwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDc4MDAwMApbICAgIDAuMDA3MjIy
XSBHSUN2MzogQ1BVOTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAw
ODAwMDA4MzAwMDAKWyAgICAwLjAwNzI2OV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29y
a2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA3Mjg0XSBDUFU5OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxOTAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4w
MDc1NTddIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxMApbICAgIDAuMDA3NTg0XSBHSUN2
MzogQ1BVMTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTcwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDcwMDAwMApbICAgIDAuMDA3NjExXSBHSUN2MzogQ1BVMTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkg
cGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODQwMDAwClsgICAgMC4wMDc2NTldIGFyY2hfdGlt
ZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAg
ICAwLjAwNzY3NV0gQ1BVMTA6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDE3MDAw
MCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNzk2Ml0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQ
VTExClsgICAgMC4wMDc5OTFdIEdJQ3YzOiBDUFUxMTogZm91bmQgcmVkaXN0cmlidXRvciAxZjAw
MDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOTAwMDAwClsgICAgMC4wMDgwMTddIEdJQ3YzOiBDUFUx
MTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4NTAwMDAK
WyAgICAwLjAwODA2NF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3Ig
QVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA4MDgyXSBDUFUxMTogQm9vdGVkIHNlY29uZGFy
eSBwcm9jZXNzb3IgMHgwMDAwMWYwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA4NDM4XSBEZXRl
Y3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTIKWyAgICAwLjAwODQ1OF0gR0lDdjM6IENQVTEyOiBm
b3VuZCByZWRpc3RyaWJ1dG9yIDkwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDM4MDAwMApbICAg
IDAuMDA4NDg0XSBHSUN2MzogQ1BVMTI6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwMDAwODYwMDAwClsgICAgMC4wMDg1MzJdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwODU1MF0g
Q1BVMTI6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDA5MDAwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAwODg1MV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEzClsgICAgMC4w
MDg4ODBdIEdJQ3YzOiBDUFUxMzogZm91bmQgcmVkaXN0cmlidXRvciAyMTAwMDAgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwOTgwMDAwClsgICAgMC4wMDg5MDddIEdJQ3YzOiBDUFUxMzogdXNpbmcgYWxs
b2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4NzAwMDAKWyAgICAwLjAwODk1
Ml0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0g
MTQxODA0MApbICAgIDAuMDA4OTcwXSBDUFUxMzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3Ig
MHgwMDAwMjEwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA5MjY0XSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVMTQKWyAgICAwLjAwOTI4N10gR0lDdjM6IENQVTE0OiBmb3VuZCByZWRpc3Ry
aWJ1dG9yIGYwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDUwMDAwMApbICAgIDAuMDA5MzE0XSBH
SUN2MzogQ1BVMTQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwODgwMDAwClsgICAgMC4wMDkzNjNdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwOTM4Ml0gQ1BVMTQ6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDBmMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAw
OTg0M10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE1ClsgICAgMC4wMDk4NzVdIEdJQ3Yz
OiBDUFUxNTogZm91bmQgcmVkaXN0cmlidXRvciAyNzAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
YjAwMDAwClsgICAgMC4wMDk5MDJdIEdJQ3YzOiBDUFUxNTogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4OTAwMDAKWyAgICAwLjAwOTk1Ml0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDA5OTcyXSBDUFUxNTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjcwMDAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDEwMjcwXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MTYKWyAgICAwLjAxMDI5M10gR0lDdjM6IENQVTE2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwMDEw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA1NjAwMDAKWyAgICAwLjAxMDMyMF0gR0lDdjM6IENQVTE2
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhhMDAwMApb
ICAgIDAuMDEwMzY4XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTAzODZdIENQVTE2OiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAxMDAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTA4MzFdIERldGVj
dGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxNwpbICAgIDAuMDEwODU4XSBHSUN2MzogQ1BVMTc6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgMTgwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDc2MDAwMApbICAg
IDAuMDEwODg2XSBHSUN2MzogQ1BVMTc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwMDAwOGIwMDAwClsgICAgMC4wMTA5MzNdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxMDk1Ml0g
Q1BVMTc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDE4MDEwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAxMTI1M10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE4ClsgICAgMC4w
MTEyODBdIEdJQ3YzOiBDUFUxODogZm91bmQgcmVkaXN0cmlidXRvciAxNjAxMDAgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwNmUwMDAwClsgICAgMC4wMTEzMDhdIEdJQ3YzOiBDUFUxODogdXNpbmcgYWxs
b2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4YzAwMDAKWyAgICAwLjAxMTM1
Nl0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0g
MTQxODA0MApbICAgIDAuMDExMzc2XSBDUFUxODogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3Ig
MHgwMDAwMTYwMTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDExNzQ5XSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVMTkKWyAgICAwLjAxMTc3OF0gR0lDdjM6IENQVTE5OiBmb3VuZCByZWRpc3Ry
aWJ1dG9yIDFlMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA4ZTAwMDAKWyAgICAwLjAxMTgwN10g
R0lDdjM6IENQVTE5OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4
MDAwMDhkMDAwMApbICAgIDAuMDExODU1XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3Jr
YXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTE4NzVdIENQVTE5OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxZTAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4w
MTIyMzhdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMApbICAgIDAuMDEyMjU5XSBHSUN2
MzogQ1BVMjA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgODAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
MzYwMDAwClsgICAgMC4wMTIyODddIEdJQ3YzOiBDUFUyMDogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4ZTAwMDAKWyAgICAwLjAxMjMzNV0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDEyMzU1XSBDUFUyMDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDgwMTAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDEyNjUwXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MjEKWyAgICAwLjAxMjY4MF0gR0lDdjM6IENQVTIxOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDIwMDEw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA5NjAwMDAKWyAgICAwLjAxMjcxMF0gR0lDdjM6IENQVTIx
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhmMDAwMApb
ICAgIDAuMDEyNzU3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTI3NzhdIENQVTIxOiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAyMDAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTMyMzFdIERldGVj
dGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMgpbICAgIDAuMDEzMjU0XSBHSUN2MzogQ1BVMjI6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgZTAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNGUwMDAwClsgICAg
MC4wMTMyODVdIEdJQ3YzOiBDUFUyMjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDA5MDAwMDAKWyAgICAwLjAxMzMzNV0gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDEzMzU2XSBD
UFUyMjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMGUwMTAwIFsweDQxM2ZkMGMx
XQpbICAgIDAuMDEzNjY2XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjMKWyAgICAwLjAx
MzY5OF0gR0lDdjM6IENQVTIzOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDI2MDEwMCByZWdpb24gMDow
eDAwMDAxMDAxMDBhZTAwMDAKWyAgICAwLjAxMzcyOF0gR0lDdjM6IENQVTIzOiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDkxMDAwMApbICAgIDAuMDEzNzc1
XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAx
NDE4MDQwClsgICAgMC4wMTM3OTddIENQVTIzOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAyNjAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTQyNDddIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUyNApbICAgIDAuMDE0MjcyXSBHSUN2MzogQ1BVMjQ6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMTEwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDVhMDAwMApbICAgIDAuMDE0MzAyXSBH
SUN2MzogQ1BVMjQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwOTIwMDAwClsgICAgMC4wMTQzNDldIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNDM3MV0gQ1BVMjQ6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDExMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAx
NDY3MV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI1ClsgICAgMC4wMTQ2OThdIEdJQ3Yz
OiBDUFUyNTogZm91bmQgcmVkaXN0cmlidXRvciAxOTAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
N2EwMDAwClsgICAgMC4wMTQ3MjhdIEdJQ3YzOiBDUFUyNTogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA5MzAwMDAKWyAgICAwLjAxNDc3NV0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDE0Nzk3XSBDUFUyNTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMTkwMTAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDE1MjQxXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MjYKWyAgICAwLjAxNTI2N10gR0lDdjM6IENQVTI2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDE3MDEw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA3MjAwMDAKWyAgICAwLjAxNTI5OF0gR0lDdjM6IENQVTI2
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk0MDAwMApb
ICAgIDAuMDE1MzQ3XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTUzNjhdIENQVTI2OiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAxNzAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTU2NzNdIERldGVj
dGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyNwpbICAgIDAuMDE1NzAzXSBHSUN2MzogQ1BVMjc6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgMWYwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDkyMDAwMApbICAg
IDAuMDE1NzM0XSBHSUN2MzogQ1BVMjc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwMDAwOTUwMDAwClsgICAgMC4wMTU3ODFdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNTgwM10g
Q1BVMjc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDFmMDEwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAxNjIzOF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI4ClsgICAgMC4w
MTYyNTldIEdJQ3YzOiBDUFUyODogZm91bmQgcmVkaXN0cmlidXRvciA5MDEwMCByZWdpb24gMDow
eDAwMDAxMDAxMDAzYTAwMDAKWyAgICAwLjAxNjI5Ml0gR0lDdjM6IENQVTI4OiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk2MDAwMApbICAgIDAuMDE2MzQx
XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAx
NDE4MDQwClsgICAgMC4wMTYzNjJdIENQVTI4OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAwOTAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTY2NzZdIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUyOQpbICAgIDAuMDE2NzA2XSBHSUN2MzogQ1BVMjk6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMjEwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDlhMDAwMApbICAgIDAuMDE2NzM4XSBH
SUN2MzogQ1BVMjk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwOTcwMDAwClsgICAgMC4wMTY3ODZdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNjgwOF0gQ1BVMjk6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDIxMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAx
NzIzOV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTMwClsgICAgMC4wMTcyNjRdIEdJQ3Yz
OiBDUFUzMDogZm91bmQgcmVkaXN0cmlidXRvciBmMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA1
MjAwMDAKWyAgICAwLjAxNzI5NV0gR0lDdjM6IENQVTMwOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk4MDAwMApbICAgIDAuMDE3MzQzXSBhcmNoX3RpbWVy
OiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAg
MC4wMTczNjZdIENQVTMwOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwZjAxMDAg
WzB4NDEzZmQwYzFdClsgICAgMC4wMTc2NjZdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUz
MQpbICAgIDAuMDE3Njk5XSBHSUN2MzogQ1BVMzE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjcwMTAw
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMGIyMDAwMApbICAgIDAuMDE3NzMxXSBHSUN2MzogQ1BVMzE6
IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTkwMDAwClsg
ICAgMC4wMTc3NzhdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNzc5OV0gQ1BVMzE6IEJvb3RlZCBzZWNvbmRhcnkg
cHJvY2Vzc29yIDB4MDAwMDI3MDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAxNzg4M10gc21wOiBC
cm91Z2h0IHVwIDEgbm9kZSwgMzIgQ1BVcwpbICAgIDAuMDE3OTgwXSBTTVA6IFRvdGFsIG9mIDMy
IHByb2Nlc3NvcnMgYWN0aXZhdGVkLgpbICAgIDAuMDE3OTgyXSBDUFUgZmVhdHVyZXM6IGRldGVj
dGVkOiBQcml2aWxlZ2VkIEFjY2VzcyBOZXZlcgpbICAgIDAuMDE3OTg0XSBDUFUgZmVhdHVyZXM6
IGRldGVjdGVkOiBMU0UgYXRvbWljIGluc3RydWN0aW9ucwpbICAgIDAuMDE3OTg2XSBDUFUgZmVh
dHVyZXM6IGRldGVjdGVkOiBVc2VyIEFjY2VzcyBPdmVycmlkZQpbICAgIDAuMDE3OTg4XSBDUFUg
ZmVhdHVyZXM6IGRldGVjdGVkOiAzMi1iaXQgRUwwIFN1cHBvcnQKWyAgICAwLjAxNzk4OV0gQ1BV
IGZlYXR1cmVzOiBkZXRlY3RlZDogQ29tbW9uIG5vdCBQcml2YXRlIHRyYW5zbGF0aW9ucwpbICAg
IDAuMDE3OTkxXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBSQVMgRXh0ZW5zaW9uIFN1cHBvcnQK
WyAgICAwLjAxNzk5M10gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogRGF0YSBjYWNoZSBjbGVhbiB0
byB0aGUgUG9VIG5vdCByZXF1aXJlZCBmb3IgSS9EIGNvaGVyZW5jZQpbICAgIDAuMDE3OTk1XSBD
UFUgZmVhdHVyZXM6IGRldGVjdGVkOiBDUkMzMiBpbnN0cnVjdGlvbnMKWyAgICAwLjAxNzk5N10g
Q1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3VsYXRpdmUgU3RvcmUgQnlwYXNzaW5nIFNhZmUg
KFNTQlMpClsgICAgMC4wNDk5MDVdIENQVTogQWxsIENQVShzKSBzdGFydGVkIGF0IEVMMgpbICAg
IDAuMDUwNzAwXSBkZXZ0bXBmczogaW5pdGlhbGl6ZWQKWyAgICAwLjA1MDk3MF0gY2xvY2tzb3Vy
Y2U6IGppZmZpZXM6IG1hc2s6IDB4ZmZmZmZmZmYgbWF4X2N5Y2xlczogMHhmZmZmZmZmZiwgbWF4
X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnMKWyAgICAwLjA1MDk3Nl0gZnV0ZXggaGFzaCB0
YWJsZSBlbnRyaWVzOiA4MTkyIChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIpClsgICAg
MC4wNTEyMDhdIFNNQklPUyAzLjMuMCBwcmVzZW50LgpbICAgIDAuMDUxMjE0XSBETUk6IEFETElO
SyBDT00tSFBDLUFMVC9DT00tSFBDLUFMVCwgQklPUyBUaWFub0NvcmUgRURLSUkgMTEvMjMvMjAy
MQpbICAgIDAuMDUxNDQ0XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDE2ClsgICAg
MC4wNTE5NDhdIERNQTogcHJlYWxsb2NhdGVkIDQwOTYgS2lCIEdGUF9LRVJORUwgcG9vbCBmb3Ig
YXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wNTIxMjJdIERNQTogcHJlYWxsb2NhdGVkIDQwOTYg
S2lCIEdGUF9LRVJORUx8R0ZQX0RNQSBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMKWyAgICAw
LjA1MjI4Nl0gRE1BOiBwcmVhbGxvY2F0ZWQgNDA5NiBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BMzIg
cG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wNTIzODRdIHRoZXJtYWxfc3lzOiBS
ZWdpc3RlcmVkIHRoZXJtYWwgZ292ZXJub3IgJ3N0ZXBfd2lzZScKWyAgICAwLjA1MjQ2Nl0gY3B1
aWRsZTogdXNpbmcgZ292ZXJub3IgbWVudQpbICAgIDAuMDUyNjA0XSBEZXRlY3RlZCAxNSBQQ0Mg
U3Vic3BhY2VzClsgICAgMC4wNTI2MjVdIFJlZ2lzdGVyaW5nIFBDQyBkcml2ZXIgYXMgTWFpbGJv
eCBjb250cm9sbGVyClsgICAgMC4wNTI2NjJdIGh3LWJyZWFrcG9pbnQ6IGZvdW5kIDYgYnJlYWtw
b2ludCBhbmQgNCB3YXRjaHBvaW50IHJlZ2lzdGVycy4KWyAgICAwLjA1Mjk2NV0gQVNJRCBhbGxv
Y2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVzClsgICAgMC4wNTI5NzFdIEFDUEk6
IGJ1cyB0eXBlIFBDSSByZWdpc3RlcmVkClsgICAgMC4wNTI5NzNdIFNlcmlhbDogQU1CQSBQTDAx
MSBVQVJUIGRyaXZlcgpbICAgIDAuMDU1MTIwXSBIdWdlVExCIHJlZ2lzdGVyZWQgMS4wMCBHaUIg
cGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAgICAwLjA1NTEyM10gSHVnZVRMQiBy
ZWdpc3RlcmVkIDMyLjAgTWlCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzClsgICAg
MC4wNTUxMjVdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAyLjAwIE1pQiBwYWdlIHNpemUsIHByZS1hbGxv
Y2F0ZWQgMCBwYWdlcwpbICAgIDAuMDU1MTI3XSBIdWdlVExCIHJlZ2lzdGVyZWQgNjQuMCBLaUIg
cGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAgICAwLjA1NTgyNF0gY3J5cHRkOiBt
YXhfY3B1X3FsZW4gc2V0IHRvIDEwMDAKWyAgICAwLjEyNDA1N10gcmFpZDY6IG5lb254OCAgIGdl
bigpICA3NzM3IE1CL3MKWyAgICAwLjE5MjA4NV0gcmFpZDY6IG5lb254OCAgIHhvcigpICA2MDY2
IE1CL3MKWyAgICAwLjI2MDExNl0gcmFpZDY6IG5lb254NCAgIGdlbigpICA3NjMxIE1CL3MKWyAg
ICAwLjMyODE0Nl0gcmFpZDY6IG5lb254NCAgIHhvcigpICA2MzI2IE1CL3MKWyAgICAwLjM5NjE3
N10gcmFpZDY6IG5lb254MiAgIGdlbigpICA3MjgxIE1CL3MKWyAgICAwLjQ2NDIwM10gcmFpZDY6
IG5lb254MiAgIHhvcigpICA1NzI2IE1CL3MKWyAgICAwLjUzMjIzNF0gcmFpZDY6IG5lb254MSAg
IGdlbigpICA1OTE0IE1CL3MKWyAgICAwLjYwMDI2NF0gcmFpZDY6IG5lb254MSAgIHhvcigpICA0
OTM2IE1CL3MKWyAgICAwLjY2ODI5Ml0gcmFpZDY6IGludDY0eDggIGdlbigpICAzNjAzIE1CL3MK
WyAgICAwLjczNjMyMF0gcmFpZDY6IGludDY0eDggIHhvcigpICAyMDE3IE1CL3MKWyAgICAwLjgw
NDM0N10gcmFpZDY6IGludDY0eDQgIGdlbigpICA0MTI0IE1CL3MKWyAgICAwLjg3MjQyM10gcmFp
ZDY6IGludDY0eDQgIHhvcigpICAyMTkwIE1CL3MKWyAgICAwLjk0MDQwMV0gcmFpZDY6IGludDY0
eDIgIGdlbigpICAzNTAzIE1CL3MKWyAgICAxLjAwODQyOF0gcmFpZDY6IGludDY0eDIgIHhvcigp
ICAxODg3IE1CL3MKWyAgICAxLjA3NjQ1N10gcmFpZDY6IGludDY0eDEgIGdlbigpICAyODc0IE1C
L3MKWyAgICAxLjE0NDQ4NV0gcmFpZDY6IGludDY0eDEgIHhvcigpICAxNTA4IE1CL3MKWyAgICAx
LjE0NDQ4N10gcmFpZDY6IHVzaW5nIGFsZ29yaXRobSBuZW9ueDggZ2VuKCkgNzczNyBNQi9zClsg
ICAgMS4xNDQ0ODhdIHJhaWQ2OiAuLi4uIHhvcigpIDYwNjYgTUIvcywgcm13IGVuYWJsZWQKWyAg
ICAxLjE0NDQ5MF0gcmFpZDY6IHVzaW5nIG5lb24gcmVjb3ZlcnkgYWxnb3JpdGhtClsgICAgMS4x
NDQ1NjVdIEFDUEk6IEFkZGVkIF9PU0koTW9kdWxlIERldmljZSkKWyAgICAxLjE0NDU2OF0gQUNQ
STogQWRkZWQgX09TSShQcm9jZXNzb3IgRGV2aWNlKQpbICAgIDEuMTQ0NTcwXSBBQ1BJOiBBZGRl
ZCBfT1NJKDMuMCBfU0NQIEV4dGVuc2lvbnMpClsgICAgMS4xNDQ1NzJdIEFDUEk6IEFkZGVkIF9P
U0koUHJvY2Vzc29yIEFnZ3JlZ2F0b3IgRGV2aWNlKQpbICAgIDEuMTQ0NTc0XSBBQ1BJOiBBZGRl
ZCBfT1NJKExpbnV4LURlbGwtVmlkZW8pClsgICAgMS4xNDQ1NzZdIEFDUEk6IEFkZGVkIF9PU0ko
TGludXgtTGVub3ZvLU5WLUhETUktQXVkaW8pClsgICAgMS4xNDQ1NzhdIEFDUEk6IEFkZGVkIF9P
U0koTGludXgtSFBJLUh5YnJpZC1HcmFwaGljcykKWyAgICAxLjE2NTA4OF0gQUNQSTogMiBBQ1BJ
IEFNTCB0YWJsZXMgc3VjY2Vzc2Z1bGx5IGFjcXVpcmVkIGFuZCBsb2FkZWQKWyAgICAxLjE3MTI5
OV0gQUNQSTogSW50ZXJwcmV0ZXIgZW5hYmxlZApbICAgIDEuMTcxMzAyXSBBQ1BJOiBVc2luZyBH
SUMgZm9yIGludGVycnVwdCByb3V0aW5nClsgICAgMS4xNzEzMTddIEFDUEk6IE1DRkcgdGFibGUg
ZGV0ZWN0ZWQsIDUgZW50cmllcwpbICAgIDEuMTcxMzIzXSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzMz
ZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcxMzQ4XSBB
Q1BJOiBJT1JUOiBTTU1VLXYzWzM3ZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21h
aW4gMApbICAgIDEuMTcxMzYwXSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzNmZmZlMDAwMDAwMF0gTWFw
cGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcxMzc0XSBBQ1BJOiBJT1JUOiBTTU1V
LXYzWzJiZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcx
Mzg2XSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzJmZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0
eSBkb21haW4gMApbICAgIDEuMTcxNDczXSBIRVNUOiBUYWJsZSBwYXJzaW5nIGhhcyBiZWVuIGlu
aXRpYWxpemVkLgpbICAgIDEuMjA2MjYxXSBBUk1IMDAxMTowMDogdHR5QU1BMCBhdCBNTUlPIDB4
MTAwMDAyNjAwMDAwIChpcnEgPSA3OSwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBClsgICAgNC4w
MjEwNzhdIHByaW50azogY29uc29sZSBbdHR5QU1BMF0gZW5hYmxlZApbICAgIDQuMDI3MTM2XSBB
Uk1IMDAxMTowMTogdHR5QU1BMSBhdCBNTUlPIDB4MTAwMDAyNjIwMDAwIChpcnEgPSA4MCwgYmFz
ZV9iYXVkID0gMCkgaXMgYSBTQlNBClsgICAgNC4wMzcyNTVdIEFDUEk6IFBDSSBSb290IEJyaWRn
ZSBbUENJMF0gKGRvbWFpbiAwMDBjIFtidXMgMDAtZmZdKQpbICAgIDQuMDQzNDM3XSBhY3BpIFBO
UDBBMDg6MDA6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0g
U2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICA0LjA1MjU0MV0gYWNwaSBQTlAwQTA4OjAwOiBQ
Q0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbApb
ICAgIDQuMDYwMzY0XSBhY3BpIFBOUDBBMDg6MDA6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAw
eDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZm
ODAwMDEwZGUwZmMwClsgICAgNC4wNzMxNzJdIGFjcGkgUE5QMEEwODowMDogRUNBTSBhcmVhIFtt
ZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDAK
WyAgICA0LjA4MjA0NF0gYWNwaSBQTlAwQTA4OjAwOiBFQ0FNIGF0IFttZW0gMHgzM2ZmZjAwMDAw
MDAtMHgzM2ZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQpbICAgIDQuMDkwMjAyXSBQQ0kgaG9z
dCBicmlkZ2UgdG8gYnVzIDAwMGM6MDAKWyAgICA0LjA5NDI5MF0gcGNpX2J1cyAwMDBjOjAwOiBy
b290IGJ1cyByZXNvdXJjZSBbbWVtIDB4NDAwMDAwMDAtMHg0ZmZmZmZmZiB3aW5kb3ddClsgICAg
NC4xMDE3NjJdIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDMwMDAw
MDAwMDAwMC0weDMzZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNC4xMDk5MjhdIHBjaV9idXMgMDAw
YzowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0KWyAgICA0LjExNTQzOV0gcGNpIDAw
MGM6MDA6MDAuMDogWzFkZWY6ZTEwMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMApbICAgIDQuMTIx
NTE2XSBwY2kgMDAwYzowMDowMS4wOiBbMWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAw
ClsgICAgNC4xMjc1NjNdIHBjaSAwMDBjOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNC4x
MzE4MjNdIHBjaSAwMDBjOjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QK
WyAgICA0LjEzODY4MF0gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAw
MC0weDBmZmZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDEwMDAKWyAgICA0LjE0Njg0OF0gcGNpIDAw
MGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJp
dCBwcmVmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAg
IDQuMTU4MzEzXSBwY2kgMDAwYzowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAw
MC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAw
MApbICAgIDQuMTY4ODI2XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAw
eDQwMDAwMDAwLTB4NDAxZmZmZmZdClsgICAgNC4xNzU2MDRdIHBjaSAwMDBjOjAwOjAxLjA6IEJB
UiA5OiBhc3NpZ25lZCBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNC4xODQwMzBdIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3Ig
W2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjE5MDI4N10gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6
IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjE5Njg5MF0gcGNpIDAw
MGM6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQu
MjAzMTQ2XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNp
emUgMHgxMDAwXQpbICAgIDQuMjA5NzUwXSBwY2kgMDAwYzowMDowMS4wOiBQQ0kgYnJpZGdlIHRv
IFtidXMgMDFdClsgICAgNC4yMTQ3MDVdIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRv
dyBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0KWyAgICA0LjIyMTQ4M10gcGNpIDAwMGM6MDA6
MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZmZmYg
NjRiaXQgcHJlZl0KWyAgICA0LjIyOTkxMl0gcGNpX2J1cyAwMDBjOjAwOiByZXNvdXJjZSA0IFtt
ZW0gMHg0MDAwMDAwMC0weDRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjIzNjc3Nl0gcGNpX2J1cyAw
MDBjOjAwOiByZXNvdXJjZSA1IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzM2ZmZGZmZmZmZmYgd2lu
ZG93XQpbICAgIDQuMjQ0MzM0XSBwY2lfYnVzIDAwMGM6MDE6IHJlc291cmNlIDEgW21lbSAweDQw
MDAwMDAwLTB4NDAxZmZmZmZdClsgICAgNC4yNTA1OTFdIHBjaV9idXMgMDAwYzowMTogcmVzb3Vy
Y2UgMiBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdClsgICAg
NC4yNTg1MzZdIEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJMV0gKGRvbWFpbiAwMDBkIFtidXMg
MDAtZmZdKQpbICAgIDQuMjY0NzE0XSBhY3BpIFBOUDBBMDg6MDE6IF9PU0M6IE9TIHN1cHBvcnRz
IFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAg
ICA0LjI3MzgxM10gYWNwaSBQTlAwQTA4OjAxOiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7
IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbApbICAgIDQuMjgxNjM1XSBhY3BpIFBOUDBBMDg6
MDE6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZm
Zl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwClsgICAgNC4yOTQ0Mjdd
IGFjcGkgUE5QMEEwODowMTogRUNBTSBhcmVhIFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZm
ZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDAKWyAgICA0LjMwMzI5OV0gYWNwaSBQTlAwQTA4
OjAxOiBFQ0FNIGF0IFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZmZmZmZmZdIGZvciBbYnVz
IDAwLWZmXQpbICAgIDQuMzExNDUzXSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGQ6MDAKWyAg
ICA0LjMxNTU0MF0gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4NTAw
MDAwMDAtMHg1ZmZmZmZmZiB3aW5kb3ddClsgICAgNC4zMjMwMTJdIHBjaV9idXMgMDAwZDowMDog
cm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDM0MDAwMDAwMDAwMC0weDM3ZmZkZmZmZmZmZiB3aW5k
b3ddClsgICAgNC4zMzExNzhdIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1
cyAwMC1mZl0KWyAgICA0LjMzNjY4Nl0gcGNpIDAwMGQ6MDA6MDAuMDogWzFkZWY6ZTEwMF0gdHlw
ZSAwMCBjbGFzcyAweDA2MDAwMApbICAgIDQuMzQyNzUxXSBwY2kgMDAwZDowMDowMS4wOiBbMWRl
ZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNC4zNDg3ODNdIHBjaSAwMDBkOjAw
OjAxLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNC4zNTMwNDNdIHBjaSAwMDBkOjAwOjAxLjA6IFBN
RSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA0LjM1ODg2NV0gcGNpIDAwMGQ6MDE6
MDAuMDogWzEwZGU6MWU4OV0gdHlwZSAwMCBjbGFzcyAweDAzMDAwMApbICAgIDQuMzY0ODcyXSBw
Y2kgMDAwZDowMTowMC4wOiByZWcgMHgxMDogW21lbSAweDUwMDAwMDAwLTB4NTBmZmZmZmZdClsg
ICAgNC4zNzExMzZdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDE0OiBbbWVtIDB4MzQwMDAwMDAw
MDAwLTB4MzQwMDBmZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC4zNzkwNDldIHBjaSAwMDBkOjAx
OjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MzQwMDEwMDAwMDAwLTB4MzQwMDExZmZmZmZmIDY0Yml0
IHByZWZdClsgICAgNC4zODY5NTldIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDI0OiBbaW8gIDB4
NTdmZmUwMDAtMHg1N2ZmZTA3Zl0KWyAgICA0LjM5MzIxOF0gcGNpIDAwMGQ6MDE6MDAuMDogcmVn
IDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAgNC4zOTk5NjldIHBj
aSAwMDBkOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAg
NC40MDYxMTldIHBjaSAwMDBkOjAxOjAwLjE6IFsxMGRlOjEwZjhdIHR5cGUgMDAgY2xhc3MgMHgw
NDAzMDAKWyAgICA0LjQxMjEyNF0gcGNpIDAwMGQ6MDE6MDAuMTogcmVnIDB4MTA6IFttZW0gMHg1
MTAwMDAwMC0weDUxMDAzZmZmXQpbICAgIDQuNDE4NTAzXSBwY2kgMDAwZDowMTowMC4yOiBbMTBk
ZToxYWQ4XSB0eXBlIDAwIGNsYXNzIDB4MGMwMzMwClsgICAgNC40MjQ1MTJdIHBjaSAwMDBkOjAx
OjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4MzQwMDEyMDAwMDAwLTB4MzQwMDEyMDNmZmZmIDY0Yml0
IHByZWZdClsgICAgNC40MzI0MzBdIHBjaSAwMDBkOjAxOjAwLjI6IHJlZyAweDFjOiBbbWVtIDB4
MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRmZmZmIDY0Yml0IHByZWZdClsgICAgNC40NDAzODZdIHBj
aSAwMDBkOjAxOjAwLjI6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAg
NC40NDY1MjRdIHBjaSAwMDBkOjAxOjAwLjM6IFsxMGRlOjFhZDldIHR5cGUgMDAgY2xhc3MgMHgw
YzgwMDAKWyAgICA0LjQ1MjUzMF0gcGNpIDAwMGQ6MDE6MDAuMzogcmVnIDB4MTA6IFttZW0gMHg1
MTAwNDAwMC0weDUxMDA0ZmZmXQpbICAgIDQuNDU4ODU1XSBwY2kgMDAwZDowMTowMC4zOiBQTUUj
IHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuNDY0OTkxXSBwY2kgMDAwZDow
MDowMS4wOiBBU1BNOiBjdXJyZW50IGNvbW1vbiBjbG9jayBjb25maWd1cmF0aW9uIGlzIGluY29u
c2lzdGVudCwgcmVjb25maWd1cmluZwpbICAgIDQuNDg2MjcyXSBwY2kgMDAwZDowMDowMS4wOiBC
QVIgOTogYXNzaWduZWQgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAxN2ZmZmZmZiA2NGJpdCBw
cmVmXQpbICAgIDQuNDk0NzAwXSBwY2kgMDAwZDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21l
bSAweDUwMDAwMDAwLTB4NTE3ZmZmZmZdClsgICAgNC41MDE0NzddIHBjaSAwMDBkOjAwOjAxLjA6
IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjUwNzczM10gcGNp
IDAwMGQ6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0K
WyAgICA0LjUxNDMzOF0gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFttZW0gMHgz
NDAwMDAwMDAwMDAtMHgzNDAwMGZmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjUyMjc3MV0gcGNp
IDAwMGQ6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAw
MTFmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjUzMTIwM10gcGNpIDAwMGQ6MDE6MDAuMDogQkFS
IDA6IGFzc2lnbmVkIFttZW0gMHg1MDAwMDAwMC0weDUwZmZmZmZmXQpbICAgIDQuNTM3OTgyXSBw
Y2kgMDAwZDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDUxMDAwMDAwLTB4NTEwN2Zm
ZmYgcHJlZl0KWyAgICA0LjU0NTE5NF0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDA6IGFzc2lnbmVk
IFttZW0gMHgzNDAwMTIwMDAwMDAtMHgzNDAwMTIwM2ZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjU1
MzYyN10gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTIwNDAw
MDAtMHgzNDAwMTIwNGZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjU2MjA2MF0gcGNpIDAwMGQ6MDE6
MDAuMTogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MTA4MDAwMC0weDUxMDgzZmZmXQpbICAgIDQu
NTY4ODM5XSBwY2kgMDAwZDowMTowMC4zOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDUxMDg0MDAw
LTB4NTEwODRmZmZdClsgICAgNC41NzU2MTddIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiA1OiBubyBz
cGFjZSBmb3IgW2lvICBzaXplIDB4MDA4MF0KWyAgICA0LjU4MTg3M10gcGNpIDAwMGQ6MDE6MDAu
MDogQkFSIDU6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0KWyAgICA0LjU4ODQ3
OV0gcGNpIDAwMGQ6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQpbICAgIDQuNTkzNDM0
XSBwY2kgMDAwZDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDUwMDAwMDAwLTB4NTE3
ZmZmZmZdClsgICAgNC42MDAyMTFdIHBjaSAwMDBkOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBb
bWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC42MDg2
MzhdIHBjaV9idXMgMDAwZDowMDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3Np
Z25lZCwgdHJ5IGJvb3Rpbmcgd2l0aCBwY2k9cmVhbGxvYwpbICAgIDQuNjE3NjcyXSBwY2lfYnVz
IDAwMGQ6MDA6IHJlc291cmNlIDQgW21lbSAweDUwMDAwMDAwLTB4NWZmZmZmZmYgd2luZG93XQpb
ICAgIDQuNjI0NTM2XSBwY2lfYnVzIDAwMGQ6MDA6IHJlc291cmNlIDUgW21lbSAweDM0MDAwMDAw
MDAwMC0weDM3ZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNC42MzIwOTRdIHBjaV9idXMgMDAwZDow
MTogcmVzb3VyY2UgMSBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0KWyAgICA0LjYzODM1MF0g
cGNpX2J1cyAwMDBkOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgzNDAwMTdm
ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjY0NjMwN10gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQ
Q0kzXSAoZG9tYWluIDAwMDAgW2J1cyAwMC1mZl0pClsgICAgNC42NTI0ODVdIGFjcGkgUE5QMEEw
ODowMzogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdt
ZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDQuNjYxNTg1XSBhY3BpIFBOUDBBMDg6MDM6IFBDSWUg
cG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsgICAg
NC42Njk0MDddIGFjcGkgUE5QMEEwODowMzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4M2Zm
ZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAw
MTBkZTBmYzAKWyAgICA0LjY4MjIwN10gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGFyZWEgW21lbSAw
eDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApbICAg
IDQuNjkxMDc5XSBhY3BpIFBOUDBBMDg6MDM6IEVDQU0gYXQgW21lbSAweDNmZmZmMDAwMDAwMC0w
eDNmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdClsgICAgNC42OTkyMzZdIFBDSSBob3N0IGJy
aWRnZSB0byBidXMgMDAwMDowMApbICAgIDQuNzAzMzI0XSBwY2lfYnVzIDAwMDA6MDA6IHJvb3Qg
YnVzIHJlc291cmNlIFttZW0gMHg3MDAwMDAwMC0weDdmZmZmZmZmIHdpbmRvd10KWyAgICA0Ljcx
MDc5Nl0gcGNpX2J1cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4M2MwMDAwMDAw
MDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjcxODk2Ml0gcGNpX2J1cyAwMDAwOjAw
OiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQpbICAgIDQuNzI0NDY5XSBwY2kgMDAwMDow
MDowMC4wOiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwClsgICAgNC43MzA1MzVd
IHBjaSAwMDAwOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAg
ICA0LjczNjU2N10gcGNpIDAwMDA6MDA6MDEuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA0Ljc0MDgy
N10gcGNpIDAwMDA6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAg
IDQuNzQ2NjQzXSBwY2kgMDAwMDowMTowMC4wOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4
MDIwMDAwClsgICAgNC43NTI2NTJdIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4
M2MwMDAzMDAwMDAwLTB4M2MwMDAzZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC43NjA1NjldIHBj
aSAwMDAwOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODE4MDAwLTB4M2MwMDA0ODFm
ZmZmIDY0Yml0IHByZWZdClsgICAgNC43Njg0ODJdIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDMw
OiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuNzc1MjQ0XSBwY2kgMDAw
MDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuNzgx
NDAyXSBwY2kgMDAwMDowMTowMC4xOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAw
ClsgICAgNC43ODc0MTFdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAy
MDAwMDAwLTB4M2MwMDAyZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC43OTUzMjldIHBjaSAwMDAw
OjAxOjAwLjE6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODEwMDAwLTB4M2MwMDA0ODE3ZmZmIDY0
Yml0IHByZWZdClsgICAgNC44MDMyNDJdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDMwOiBbbWVt
IDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODEwMDAxXSBwY2kgMDAwMDowMTow
MC4xOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODE2MTUwXSBw
Y2kgMDAwMDowMTowMC4yOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAg
NC44MjIxNTldIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAxMDAwMDAw
LTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC44MzAwNzZdIHBjaSAwMDAwOjAxOjAw
LjI6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODA4MDAwLTB4M2MwMDA0ODBmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNC44Mzc5ODldIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDMwOiBbbWVtIDB4ZmZm
ODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODQ0NzQ4XSBwY2kgMDAwMDowMTowMC4yOiBQ
TUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODUwODk1XSBwY2kgMDAw
MDowMTowMC4zOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAgNC44NTY5
MDNdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4M2Mw
MDAwZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC44NjQ4MjBdIHBjaSAwMDAwOjAxOjAwLjM6IHJl
ZyAweDFjOiBbbWVtIDB4M2MwMDA0ODAwMDAwLTB4M2MwMDA0ODA3ZmZmIDY0Yml0IHByZWZdClsg
ICAgNC44NzI3MzNdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAt
MHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODc5NDkxXSBwY2kgMDAwMDowMTowMC4zOiBQTUUjIHN1
cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODg1NjU1XSBwY2kgMDAwMDowMDow
MS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMS0wMl0gYWRk
X3NpemUgMTAwMApbICAgIDQuODk0MDg1XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgOTogYXNzaWdu
ZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQu
OTAyNTEyXSBwY2kgMDAwMDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDcwMDAwMDAw
LTB4NzAxZmZmZmZdClsgICAgNC45MDkyODldIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBubyBz
cGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjkxNTU0NV0gcGNpIDAwMDA6MDA6MDEu
MDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjkyMjE0
OV0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAw
XQpbICAgIDQuOTI4NDA1XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuOTM1MDExXSBwY2kgMDAwMDowMTowMC4wOiBCQVIg
MDogYXNzaWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwMGZmZmZmZiA2NGJpdCBwcmVm
XQpbICAgIDQuOTQzNDQzXSBwY2kgMDAwMDowMTowMC4xOiBCQVIgMDogYXNzaWduZWQgW21lbSAw
eDNjMDAwMTAwMDAwMC0weDNjMDAwMWZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTUxODc2XSBw
Y2kgMDAwMDowMTowMC4yOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMjAwMDAwMC0weDNj
MDAwMmZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTYwMzA4XSBwY2kgMDAwMDowMTowMC4zOiBC
QVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMzAwMDAwMC0weDNjMDAwM2ZmZmZmZiA2NGJpdCBw
cmVmXQpbICAgIDQuOTY4NzQwXSBwY2kgMDAwMDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQgW21l
bSAweDcwMDAwMDAwLTB4NzAwN2ZmZmYgcHJlZl0KWyAgICA0Ljk3NTk1MV0gcGNpIDAwMDA6MDE6
MDAuMTogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg3MDA4MDAwMC0weDcwMGZmZmZmIHByZWZdClsg
ICAgNC45ODMxNjJdIHBjaSAwMDAwOjAxOjAwLjI6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4NzAx
MDAwMDAtMHg3MDE3ZmZmZiBwcmVmXQpbICAgIDQuOTkwMzczXSBwY2kgMDAwMDowMTowMC4zOiBC
QVIgNjogYXNzaWduZWQgW21lbSAweDcwMTgwMDAwLTB4NzAxZmZmZmYgcHJlZl0KWyAgICA0Ljk5
NzU4NF0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDAw
MDAtMHgzYzAwMDQwMDdmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAwNjAxNl0gcGNpIDAwMDA6MDE6
MDAuMTogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDgwMDAtMHgzYzAwMDQwMGZmZmYg
NjRiaXQgcHJlZl0KWyAgICA1LjAxNDQ0OV0gcGNpIDAwMDA6MDE6MDAuMjogQkFSIDM6IGFzc2ln
bmVkIFttZW0gMHgzYzAwMDQwMTAwMDAtMHgzYzAwMDQwMTdmZmYgNjRiaXQgcHJlZl0KWyAgICA1
LjAyMjg4Ml0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQw
MTgwMDAtMHgzYzAwMDQwMWZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAzMTMxNF0gcGNpIDAwMDA6
MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxLTAyXQpbICAgIDUuMDM2NTI5XSBwY2kgMDAw
MDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZmZmZdClsg
ICAgNS4wNDMzMDddIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4M2Mw
MDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS4wNTE3MzRdIHBjaV9i
dXMgMDAwMDowMDogcmVzb3VyY2UgNCBbbWVtIDB4NzAwMDAwMDAtMHg3ZmZmZmZmZiB3aW5kb3dd
ClsgICAgNS4wNTg1OThdIHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNSBbbWVtIDB4M2MwMDAw
MDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA1LjA2NjE1N10gcGNpX2J1cyAwMDAw
OjAxOiByZXNvdXJjZSAxIFttZW0gMHg3MDAwMDAwMC0weDcwMWZmZmZmXQpbICAgIDUuMDcyNDEz
XSBwY2lfYnVzIDAwMDA6MDE6IHJlc291cmNlIDIgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAw
NDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDgwMzc0XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2Ug
W1BDSTZdIChkb21haW4gMDAwNCBbYnVzIDAwLWZmXSkKWyAgICA1LjA4NjU1Ml0gYWNwaSBQTlAw
QTA4OjA2OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9ja1BNIFNl
Z21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAgNS4wOTU2NTFdIGFjcGkgUE5QMEEwODowNjogUENJ
ZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNvbnRyb2wKWyAg
ICA1LjEwMzQ3Ml0gYWNwaSBQTlAwQTA4OjA2OiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgy
YmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgw
MDAxMGRlMGZjMApbICAgIDUuMTE2MjYzXSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0gYXJlYSBbbWVt
IDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAwQzAyOjAwClsg
ICAgNS4xMjUxMzVdIGFjcGkgUE5QMEEwODowNjogRUNBTSBhdCBbbWVtIDB4MmJmZmYwMDAwMDAw
LTB4MmJmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0KWyAgICA1LjEzMzI4OF0gUENJIGhvc3Qg
YnJpZGdlIHRvIGJ1cyAwMDA0OjAwClsgICAgNS4xMzczNzZdIHBjaV9idXMgMDAwNDowMDogcm9v
dCBidXMgcmVzb3VyY2UgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpbICAgIDUu
MTQ0ODQ3XSBwY2lfYnVzIDAwMDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgyODAwMDAw
MDAwMDAtMHgyYmZmZGZmZmZmZmYgd2luZG93XQpbICAgIDUuMTUzMDE0XSBwY2lfYnVzIDAwMDQ6
MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdClsgICAgNS4xNTg1MjJdIHBjaSAwMDA0
OjAwOjAwLjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDAKWyAgICA1LjE2NDU4
M10gcGNpIDAwMDQ6MDA6MDEuMDogWzFkZWY6ZTExMV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApb
ICAgIDUuMTcwNjE3XSBwY2kgMDAwNDowMDowMS4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDUuMTc0
ODc3XSBwY2kgMDAwNDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90Clsg
ICAgNS4xODA2NTldIHBjaSAwMDA0OjAwOjAzLjA6IFsxZGVmOmUxMTNdIHR5cGUgMDEgY2xhc3Mg
MHgwNjA0MDAKWyAgICA1LjE4NjY5M10gcGNpIDAwMDQ6MDA6MDMuMDogc3VwcG9ydHMgRDEgRDIK
WyAgICA1LjE5MDk1M10gcGNpIDAwMDQ6MDA6MDMuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBE
MSBEM2hvdApbICAgIDUuMTk2NzM5XSBwY2kgMDAwNDowMDowNS4wOiBbMWRlZjplMTE1XSB0eXBl
IDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNS4yMDI3ODFdIHBjaSAwMDA0OjAwOjA1LjA6IHN1cHBv
cnRzIEQxIEQyClsgICAgNS4yMDcwNDFdIHBjaSAwMDA0OjAwOjA1LjA6IFBNRSMgc3VwcG9ydGVk
IGZyb20gRDAgRDEgRDNob3QKWyAgICA1LjIxMjg2MF0gcGNpIDAwMDQ6MDE6MDAuMDogWzFhMDM6
MTE1MF0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUuMjE4OTA2XSBwY2kgMDAwNDowMTow
MC4wOiBlbmFibGluZyBFeHRlbmRlZCBUYWdzClsgICAgNS4yMjM5MjBdIHBjaSAwMDA0OjAxOjAw
LjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS4yMjgxODBdIHBjaSAwMDA0OjAxOjAwLjA6IFBNRSMg
c3VwcG9ydGVkIGZyb20gRDAgRDEgRDIgRDNob3QgRDNjb2xkClsgICAgNS4yMzQ4ODNdIHBjaV9i
dXMgMDAwNDowMjogZXh0ZW5kZWQgY29uZmlnIHNwYWNlIG5vdCBhY2Nlc3NpYmxlClsgICAgNS4y
NDA5ODldIHBjaSAwMDA0OjAyOjAwLjA6IFsxYTAzOjIwMDBdIHR5cGUgMDAgY2xhc3MgMHgwMzAw
MDAKWyAgICA1LjI0NzAwNF0gcGNpIDAwMDQ6MDI6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMDAw
MDAwMC0weDIwZmZmZmZmXQpbICAgIDUuMjUzMjcwXSBwY2kgMDAwNDowMjowMC4wOiByZWcgMHgx
NDogW21lbSAweDIxMDAwMDAwLTB4MjEwMWZmZmZdClsgICAgNS4yNTk1MzVdIHBjaSAwMDA0OjAy
OjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmYwMDAtMHgyN2ZmZjA3Zl0KWyAgICA1LjI2NTg3
NF0gcGNpIDAwMDQ6MDI6MDAuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjI3MDEzNV0gcGNpIDAw
MDQ6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEMiBEM2hvdCBEM2NvbGQKWyAg
ICA1LjI3Njg3Nl0gcGNpIDAwMDQ6MDM6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBjbGFzcyAw
eDBjMDMzMApbICAgIDUuMjgyODkxXSBwY2kgMDAwNDowMzowMC4wOiByZWcgMHgxMDogW21lbSAw
eDIxMjAwMDAwLTB4MjEyMDFmZmYgNjRiaXRdClsgICAgNS4yODk3NzFdIHBjaSAwMDA0OjAzOjAw
LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAgNS4yOTU5OTRdIHBj
aSAwMDA0OjA0OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUgMDAgY2xhc3MgMHgwMjAwMDAKWyAgICA1
LjMwMjAxOV0gcGNpIDAwMDQ6MDQ6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMTEwMDAwMC0weDIx
MTdmZmZmXQpbICAgIDUuMzA4MzA1XSBwY2kgMDAwNDowNDowMC4wOiByZWcgMHgxODogW2lvICAw
eDI3ZmZlMDAwLTB4MjdmZmUwMWZdClsgICAgNS4zMTQ1NzddIHBjaSAwMDA0OjA0OjAwLjA6IHJl
ZyAweDFjOiBbbWVtIDB4MjExODAwMDAtMHgyMTE4M2ZmZl0KWyAgICA1LjMyMTAwOF0gcGNpIDAw
MDQ6MDQ6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAgICA1LjMy
NzIwNF0gcGNpIDAwMDQ6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgw
MDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxLTAyXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2Fs
aWduIDEwMDAwMApbICAgIDUuMzM4OTMxXSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93
IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMApbICAgIDUuMzQ3
MDk3XSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAw
MGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24g
MTAwMDAwClsgICAgNS4zNTg1NjNdIHBjaSAwMDA0OjAwOjAzLjA6IGJyaWRnZSB3aW5kb3cgW21l
bSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDEwMDAwMCBhZGRf
YWxpZ24gMTAwMDAwClsgICAgNS4zNjkwNzRdIHBjaSAwMDA0OjAwOjA1LjA6IGJyaWRnZSB3aW5k
b3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0gYWRk
X3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjM4MDUzOV0gcGNpIDAwMDQ6MDA6
MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAw
NF0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjM5MTA1M10gcGNpIDAw
MDQ6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpb
ICAgIDUuMzk3ODMyXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDI4
MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuNDA2MjU4XSBwY2kg
MDAwNDowMDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIxODAwMDAwLTB4MjE5ZmZmZmZd
ClsgICAgNS40MTMwMzZdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4
MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS40MjE0NjJdIHBj
aSAwMDA0OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjFhMDAwMDAtMHgyMWJmZmZm
Zl0KWyAgICA1LjQyODIzOV0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0g
MHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjQzNjY2NV0g
cGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDUuNDQyOTIxXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDQ5NTI1XSBwY2kgMDAwNDowMDowMy4wOiBCQVIgNzog
bm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS40NTU3ODBdIHBjaSAwMDA0OjAw
OjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS40
NjIzODRdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4
MTAwMF0KWyAgICA1LjQ2ODY0MF0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDc6IGZhaWxlZCB0byBh
c3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjQ3NTI0NV0gcGNpIDAwMDQ6MDA6MDEuMDog
QkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDgxNTAxXSBwY2kg
MDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDUuNDg4MTA0XSBwY2kgMDAwNDowMDowNS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAg
c2l6ZSAweDEwMDBdClsgICAgNS40OTQzNjBdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS41MDA5NjRdIHBjaSAwMDA0OjAw
OjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjUwNzIy
MF0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4
MTAwMF0KWyAgICA1LjUxMzgyNF0gcGNpIDAwMDQ6MDE6MDAuMDogQkFSIDg6IGFzc2lnbmVkIFtt
ZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNTIwNjAxXSBwY2kgMDAwNDowMTowMC4w
OiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS41MjY4NTddIHBj
aSAwMDA0OjAxOjAwLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBd
ClsgICAgNS41MzM0NjFdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4
MjAwMDAwMDAtMHgyMGZmZmZmZl0KWyAgICA1LjU0MDI0MF0gcGNpIDAwMDQ6MDI6MDAuMDogQkFS
IDE6IGFzc2lnbmVkIFttZW0gMHgyMTAwMDAwMC0weDIxMDFmZmZmXQpbICAgIDUuNTQ3MDIwXSBw
Y2kgMDAwNDowMjowMC4wOiBCQVIgMjogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDAwODBdClsg
ICAgNS41NTMyNzZdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAyOiBmYWlsZWQgdG8gYXNzaWduIFtp
byAgc2l6ZSAweDAwODBdClsgICAgNS41NTk4NzldIHBjaSAwMDA0OjAxOjAwLjA6IFBDSSBicmlk
Z2UgdG8gW2J1cyAwMl0KWyAgICA1LjU2NDgzNl0gcGNpIDAwMDQ6MDE6MDAuMDogICBicmlkZ2Ug
d2luZG93IFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNTcxNjIwXSBwY2kgMDAw
NDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDEtMDJdClsgICAgNS41NzY4MzRdIHBjaSAw
MDA0OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0K
WyAgICA1LjU4MzYxMl0gcGNpIDAwMDQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgy
ODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjU5MjA0MF0gcGNp
IDAwMDQ6MDM6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMTgwMDAwMC0weDIxODAxZmZm
IDY0Yml0XQpbICAgIDUuNTk5MzQ3XSBwY2kgMDAwNDowMDowMy4wOiBQQ0kgYnJpZGdlIHRvIFti
dXMgMDNdClsgICAgNS42MDQzMDFdIHBjaSAwMDA0OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBb
bWVtIDB4MjE4MDAwMDAtMHgyMTlmZmZmZl0KWyAgICA1LjYxMTA3OV0gcGNpIDAwMDQ6MDA6MDMu
MDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRi
aXQgcHJlZl0KWyAgICA1LjYxOTUwN10gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDA6IGFzc2lnbmVk
IFttZW0gMHgyMWEwMDAwMC0weDIxYTdmZmZmXQpbICAgIDUuNjI2Mjg5XSBwY2kgMDAwNDowNDow
MC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDIxYTgwMDAwLTB4MjFhODNmZmZdClsgICAgNS42
MzMwNzBdIHBjaSAwMDA0OjA0OjAwLjA6IEJBUiAyOiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4
MDAyMF0KWyAgICA1LjYzOTMyNl0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDI6IGZhaWxlZCB0byBh
c3NpZ24gW2lvICBzaXplIDB4MDAyMF0KWyAgICA1LjY0NTkyOV0gcGNpIDAwMDQ6MDA6MDUuMDog
UENJIGJyaWRnZSB0byBbYnVzIDA0XQpbICAgIDUuNjUwOTA2XSBwY2kgMDAwNDowMDowNS4wOiAg
IGJyaWRnZSB3aW5kb3cgW21lbSAweDIxYTAwMDAwLTB4MjFiZmZmZmZdClsgICAgNS42NTc2ODVd
IHBjaSAwMDA0OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwNDAwMDAwLTB4
MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNS42NjYxMTJdIHBjaV9idXMgMDAwNDowMDog
U29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5IGJvb3Rpbmcgd2l0
aCBwY2k9cmVhbGxvYwpbICAgIDUuNjc1MTQ2XSBwY2lfYnVzIDAwMDQ6MDA6IHJlc291cmNlIDQg
W21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpbICAgIDUuNjgyMDEwXSBwY2lfYnVz
IDAwMDQ6MDA6IHJlc291cmNlIDUgW21lbSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZmZmZmZiB3
aW5kb3ddClsgICAgNS42ODk1NjhdIHBjaV9idXMgMDAwNDowMTogcmVzb3VyY2UgMSBbbWVtIDB4
MjAwMDAwMDAtMHgyMTdmZmZmZl0KWyAgICA1LjY5NTgyNV0gcGNpX2J1cyAwMDA0OjAxOiByZXNv
dXJjZSAyIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAg
ICA1LjcwMzczMF0gcGNpX2J1cyAwMDA0OjAyOiByZXNvdXJjZSAxIFttZW0gMHgyMDAwMDAwMC0w
eDIxN2ZmZmZmXQpbICAgIDUuNzA5OTg2XSBwY2lfYnVzIDAwMDQ6MDM6IHJlc291cmNlIDEgW21l
bSAweDIxODAwMDAwLTB4MjE5ZmZmZmZdClsgICAgNS43MTYyNDJdIHBjaV9idXMgMDAwNDowMzog
cmVzb3VyY2UgMiBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHByZWZd
ClsgICAgNS43MjQxNDddIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMSBbbWVtIDB4MjFhMDAw
MDAtMHgyMWJmZmZmZl0KWyAgICA1LjczMDQwM10gcGNpX2J1cyAwMDA0OjA0OiByZXNvdXJjZSAy
IFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1Ljcz
ODM1N10gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0k3XSAoZG9tYWluIDAwMDUgW2J1cyAwMC1m
Zl0pClsgICAgNS43NDQ1MzZdIGFjcGkgUE5QMEEwODowNzogX09TQzogT1Mgc3VwcG9ydHMgW0V4
dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDUu
NzUzNjM2XSBhY3BpIFBOUDBBMDg6MDc6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90
IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsgICAgNS43NjE0NThdIGFjcGkgUE5QMEEwODowNzog
TUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4MmZmZmZmZmZmZmZmXSBm
b3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzAKWyAgICA1Ljc3NDI1MV0gYWNw
aSBQTlAwQTA4OjA3OiBFQ0FNIGFyZWEgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZmZmZm
Zl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApbICAgIDUuNzgzMTIzXSBhY3BpIFBOUDBBMDg6MDc6
IEVDQU0gYXQgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAt
ZmZdClsgICAgNS43OTEyNzRdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwNTowMApbICAgIDUu
Nzk1MzYyXSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgzMDAwMDAw
MC0weDNmZmZmZmZmIHdpbmRvd10KWyAgICA1LjgwMjgzM10gcGNpX2J1cyAwMDA1OjAwOiByb290
IGJ1cyByZXNvdXJjZSBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmZmZmRmZmZmZmZmIHdpbmRvd10K
WyAgICA1LjgxMDk5OV0gcGNpX2J1cyAwMDA1OjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAw
LWZmXQpbICAgIDUuODE2NTA2XSBwY2kgMDAwNTowMDowMC4wOiBbMWRlZjplMTEwXSB0eXBlIDAw
IGNsYXNzIDB4MDYwMDAwClsgICAgNS44MjI1NzFdIHBjaSAwMDA1OjAwOjAxLjA6IFsxZGVmOmUx
MTFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA1LjgyODYxNV0gcGNpIDAwMDU6MDA6MDEu
MDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjgzMjg3NF0gcGNpIDAwMDU6MDA6MDEuMDogUE1FIyBz
dXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDUuODM4NjYxXSBwY2kgMDAwNTowMDowMy4w
OiBbMWRlZjplMTEzXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNS44NDQ2OTVdIHBjaSAw
MDA1OjAwOjAzLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS44NDg5NTVdIHBjaSAwMDA1OjAwOjAz
LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA1Ljg1NDczOF0gcGNpIDAw
MDU6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUuODYw
NzgxXSBwY2kgMDAwNTowMDowNS4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDUuODY1MDQwXSBwY2kg
MDAwNTowMDowNS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90ClsgICAgNS44NzA4
MjNdIHBjaSAwMDA1OjAwOjA3LjA6IFsxZGVmOmUxMTddIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAK
WyAgICA1Ljg3Njg1M10gcGNpIDAwMDU6MDA6MDcuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1Ljg4
MTExMl0gcGNpIDAwMDU6MDA6MDcuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApb
ICAgIDUuODg3OTkzXSBwY2kgMDAwNTowMjowMC4wOiBbMTkxMjowMDE0XSB0eXBlIDAwIGNsYXNz
IDB4MGMwMzMwClsgICAgNS44OTQwMDldIHBjaSAwMDA1OjAyOjAwLjA6IHJlZyAweDEwOiBbbWVt
IDB4MzAxMDAwMDAtMHgzMDEwMWZmZiA2NGJpdF0KWyAgICA1LjkwMDg5MV0gcGNpIDAwMDU6MDI6
MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAgICA1LjkwODE1Ml0g
cGNpIDAwMDU6MDQ6MDAuMDogWzEyNmY6MjI2M10gdHlwZSAwMCBjbGFzcyAweDAxMDgwMgpbICAg
IDUuOTE0MTY2XSBwY2kgMDAwNTowNDowMC4wOiByZWcgMHgxMDogW21lbSAweDMwMDAwMDAwLTB4
MzAwMDNmZmYgNjRiaXRdClsgICAgNS45MjExMjNdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRnZSB3
aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAxMDAwClsgICAg
NS45MjkyOTFdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAw
LTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMjAwMDAwIGFkZF9h
bGlnbiAxMDAwMDAKWyAgICA1Ljk0MDc1Nl0gcGNpIDAwMDU6MDA6MDEuMDogYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMjAwMDAw
IGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1Ljk1MTI2Nl0gcGNpIDAwMDU6MDA6MDMuMDogYnJpZGdl
IHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDJdIGFkZF9zaXplIDEwMDAKWyAg
ICA1Ljk1OTQzMl0gcGNpIDAwMDU6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAw
MDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAyXSBhZGRfc2l6ZSAyMDAwMDAgYWRk
X2FsaWduIDEwMDAwMApbICAgIDUuOTcwODk5XSBwY2kgMDAwNTowMDowMy4wOiBicmlkZ2Ugd2lu
ZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBbYnVzIDAyXSBhZGRfc2l6ZSAxMDAw
MDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuOTgxNDA4XSBwY2kgMDAwNTowMDowNS4wOiBicmlk
Z2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMApb
ICAgIDUuOTg5NTc0XSBwY2kgMDAwNTowMDowNS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEw
MDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBh
ZGRfYWxpZ24gMTAwMDAwClsgICAgNi4wMDEwMzldIHBjaSAwMDA1OjAwOjA1LjA6IGJyaWRnZSB3
aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIw
MDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNi4wMTE1NDldIHBjaSAwMDA1OjAwOjA3LjA6IGJy
aWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDA0XSBhZGRfc2l6ZSAxMDAw
ClsgICAgNi4wMTk3MTVdIHBjaSAwMDA1OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAw
MTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUgMjAwMDAw
IGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjAzMTE4MF0gcGNpIDAwMDU6MDA6MDcuMDogYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUg
MTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjA0MTY5NF0gcGNpIDAwMDU6MDA6MDEuMDog
QkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMC0weDMwMWZmZmZmXQpbICAgIDYuMDQ4NDcy
XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAwMDAwMDAwMC0w
eDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMDU2ODk5XSBwY2kgMDAwNTowMDowMy4w
OiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdClsgICAgNi4wNjM2
NzddIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MmMwMDAwMjAwMDAw
LTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4wNzIxMDNdIHBjaSAwMDA1OjAwOjA1
LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0KWyAgICA2LjA3
ODg4MV0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyYzAwMDA0MDAw
MDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjA4NzMwOF0gcGNpIDAwMDU6MDA6
MDcuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAwMC0weDMwN2ZmZmZmXQpbICAgIDYu
MDk0MDg2XSBwY2kgMDAwNTowMDowNy4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAwMDYw
MDAwMC0weDJjMDAwMDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMTAyNTEyXSBwY2kgMDAwNTow
MDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xMDg3
NjhdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAw
eDEwMDBdClsgICAgNi4xMTUzNzFdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBm
b3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjEyMTYyN10gcGNpIDAwMDU6MDA6MDMuMDogQkFS
IDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjEyODIzMF0gcGNp
IDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAg
IDYuMTM0NDg2XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8g
IHNpemUgMHgxMDAwXQpbICAgIDYuMTQxMDg5XSBwY2kgMDAwNTowMDowNy4wOiBCQVIgNzogbm8g
c3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xNDczNDVdIHBjaSAwMDA1OjAwOjA3
LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xNTM5
NTBdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAw
MF0KWyAgICA2LjE2MDIwNl0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDc6IGZhaWxlZCB0byBhc3Np
Z24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE2NjgwOV0gcGNpIDAwMDU6MDA6MDUuMDogQkFS
IDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTczMDY1XSBwY2kgMDAw
NTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAg
IDYuMTc5NjY4XSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6
ZSAweDEwMDBdClsgICAgNi4xODU5MjVdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xOTI1MjhdIHBjaSAwMDA1OjAwOjAx
LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE5ODc4NV0g
cGNpIDAwMDU6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAw
MF0KWyAgICA2LjIwNTM4OV0gcGNpIDAwMDU6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAx
XQpbICAgIDYuMjEwMzQ0XSBwY2kgMDAwNTowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAw
eDMwMDAwMDAwLTB4MzAxZmZmZmZdClsgICAgNi4yMTcxMjFdIHBjaSAwMDA1OjAwOjAxLjA6ICAg
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmMwMDAwMWZmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNi4yMjU1NDldIHBjaSAwMDA1OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVt
IDB4MzAyMDAwMDAtMHgzMDIwMWZmZiA2NGJpdF0KWyAgICA2LjIzMjg1Nl0gcGNpIDAwMDU6MDA6
MDMuMDogUENJIGJyaWRnZSB0byBbYnVzIDAyXQpbICAgIDYuMjM3ODEwXSBwY2kgMDAwNTowMDow
My4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdClsgICAgNi4y
NDQ1ODddIHBjaSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMjAw
MDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4yNTMwMTRdIHBjaSAwMDA1OjAw
OjA1LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwM10KWyAgICA2LjI1Nzk2OV0gcGNpIDAwMDU6MDA6
MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDQwMDAwMC0weDMwNWZmZmZmXQpbICAgIDYu
MjY0NzQ3XSBwY2kgMDAwNTowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDQw
MDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMjczMTc1XSBwY2kgMDAwNTow
NDowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDMwNjAwMDAwLTB4MzA2MDNmZmYgNjRiaXRd
ClsgICAgNi4yODA0ODhdIHBjaSAwMDA1OjAwOjA3LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwNF0K
WyAgICA2LjI4NTQ0Ml0gcGNpIDAwMDU6MDA6MDcuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgz
MDYwMDAwMC0weDMwN2ZmZmZmXQpbICAgIDYuMjkyMjIwXSBwY2kgMDAwNTowMDowNy4wOiAgIGJy
aWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDYwMDAwMC0weDJjMDAwMDdmZmZmZiA2NGJpdCBwcmVm
XQpbICAgIDYuMzAwNjQ4XSBwY2lfYnVzIDAwMDU6MDA6IHJlc291cmNlIDQgW21lbSAweDMwMDAw
MDAwLTB4M2ZmZmZmZmYgd2luZG93XQpbICAgIDYuMzA3NTEyXSBwY2lfYnVzIDAwMDU6MDA6IHJl
c291cmNlIDUgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3aW5kb3ddClsgICAg
Ni4zMTUwNzBdIHBjaV9idXMgMDAwNTowMTogcmVzb3VyY2UgMSBbbWVtIDB4MzAwMDAwMDAtMHgz
MDFmZmZmZl0KWyAgICA2LjMyMTMyNl0gcGNpX2J1cyAwMDA1OjAxOiByZXNvdXJjZSAyIFttZW0g
MHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjMyOTIzMl0g
cGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAxIFttZW0gMHgzMDIwMDAwMC0weDMwM2ZmZmZmXQpb
ICAgIDYuMzM1NDg4XSBwY2lfYnVzIDAwMDU6MDI6IHJlc291cmNlIDIgW21lbSAweDJjMDAwMDIw
MDAwMC0weDJjMDAwMDNmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMzQzMzkzXSBwY2lfYnVzIDAw
MDU6MDM6IHJlc291cmNlIDEgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZmZmZdClsgICAgNi4zNDk2
NTBdIHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMiBbbWVtIDB4MmMwMDAwNDAwMDAwLTB4MmMw
MDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4zNTc1NTVdIHBjaV9idXMgMDAwNTowNDogcmVz
b3VyY2UgMSBbbWVtIDB4MzA2MDAwMDAtMHgzMDdmZmZmZl0KWyAgICA2LjM2MzgxMF0gcGNpX2J1
cyAwMDA1OjA0OiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZmZmYg
NjRiaXQgcHJlZl0KWyAgICA2LjM3MTkyNF0gaW9tbXU6IERlZmF1bHQgZG9tYWluIHR5cGU6IFRy
YW5zbGF0ZWQgClsgICAgNi4zNzY4MzBdIHBjaSAwMDBkOjAxOjAwLjA6IHZnYWFyYjogVkdBIGRl
dmljZSBhZGRlZDogZGVjb2Rlcz1pbyttZW0sb3ducz1ub25lLGxvY2tzPW5vbmUKWyAgICA2LjM4
NTE3N10gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBWR0EgZGV2aWNlIGFkZGVkOiBkZWNvZGVz
PWlvK21lbSxvd25zPW5vbmUsbG9ja3M9bm9uZQpbICAgIDYuMzkzNTIwXSBwY2kgMDAwZDowMTow
MC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxlClsgICAgNi4zOTkyNTVdIHBjaSAw
MDA0OjAyOjAwLjA6IHZnYWFyYjogYnJpZGdlIGNvbnRyb2wgcG9zc2libGUKWyAgICA2LjQwNDk5
Ml0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBzZXR0aW5nIGFzIGJvb3QgZGV2aWNlIChWR0Eg
bGVnYWN5IHJlc291cmNlcyBub3QgYXZhaWxhYmxlKQpbICAgIDYuNDEzODUzXSB2Z2FhcmI6IGxv
YWRlZApbICAgIDYuNDE2NjMzXSBTQ1NJIHN1YnN5c3RlbSBpbml0aWFsaXplZApbICAgIDYuNDIw
Mzc3XSBBQ1BJOiBidXMgdHlwZSBVU0IgcmVnaXN0ZXJlZApbICAgIDYuNDI0MzkyXSB1c2Jjb3Jl
OiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmZzClsgICAgNi40Mjk4NzVdIHVz
YmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgaHViClsgICAgNi40MzUxOTBd
IHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGRldmljZSBkcml2ZXIgdXNiClsgICAgNi40NDAyNDld
IHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAxIHJlZ2lzdGVyZWQKWyAgICA2LjQ0NTIwM10g
cHBzX2NvcmU6IFNvZnR3YXJlIHZlci4gNS4zLjYgLSBDb3B5cmlnaHQgMjAwNS0yMDA3IFJvZG9s
Zm8gR2lvbWV0dGkgPGdpb21ldHRpQGxpbnV4Lml0PgpbICAgIDYuNDU0MzI1XSBQVFAgY2xvY2sg
c3VwcG9ydCByZWdpc3RlcmVkClsgICAgNi40NTgzNTZdIFJlZ2lzdGVyZWQgZWZpdmFycyBvcGVy
YXRpb25zClsgICAgNi40NjMwNTZdIGNsb2Nrc291cmNlOiBTd2l0Y2hlZCB0byBjbG9ja3NvdXJj
ZSBhcmNoX3N5c19jb3VudGVyClsgICAgNi42NDQzMzldIHBucDogUG5QIEFDUEkgaW5pdApbICAg
IDYuNjQ4NzYxXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzYmZmZjAwMDAwMDAtMHgzYmZmZmZmZmZm
ZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNjU2NjcyXSBzeXN0ZW0gMDA6MDA6
IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUg
cmVzZXJ2ZWQKWyAgICA2LjY2NDkyNV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MjNmZmYwMDAwMDAw
LTB4MjNmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA2LjY3MjgzMV0g
c3lzdGVtIDAwOjAwOiBbbWVtIDB4MjdmZmYwMDAwMDAwLTB4MjdmZmZmZmZmZmZmIHdpbmRvd10g
aGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA2LjY4MDczN10gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MmJm
ZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkClsg
ICAgNi42ODg5OTFdIHN5c3RlbSAwMDowMDogW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZm
ZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZApbICAgIDYuNjk3MjQ1XSBzeXN0ZW0g
MDA6MDA6IFttZW0gMHg3YmZmZjAwMDAwMDAtMHg3YmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVl
biByZXNlcnZlZApbICAgIDYuNzA1MTUxXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg3ZmZmZjAwMDAw
MDAtMHg3ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzEzMDU2
XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2M2ZmZjAwMDAwMDAtMHg2M2ZmZmZmZmZmZmYgd2luZG93
XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzIwOTYzXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2
N2ZmZjAwMDAwMDAtMHg2N2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAg
IDYuNzI4ODY5XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2YmZmZjAwMDAwMDAtMHg2YmZmZmZmZmZm
ZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzM2Nzc2XSBzeXN0ZW0gMDA6MDA6
IFttZW0gMHg2ZmZmZjAwMDAwMDAtMHg2ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNl
cnZlZApbICAgIDYuNzQ0NjgyXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgz
M2ZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQKWyAgICA2Ljc1MjkzNV0g
c3lzdGVtIDAwOjAwOiBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZmIHdpbmRvd10g
Y291bGQgbm90IGJlIHJlc2VydmVkClsgICAgNi43NjExOTddIHBucDogUG5QIEFDUEk6IGZvdW5k
IDEgZGV2aWNlcwpbICAgIDYuNzY2OTg4XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5
IDIKWyAgICA2Ljc3MTUyMl0gdGNwX2xpc3Rlbl9wb3J0YWRkcl9oYXNoIGhhc2ggdGFibGUgZW50
cmllczogMTYzODQgKG9yZGVyOiA2LCAyNjIxNDQgYnl0ZXMsIGxpbmVhcikKWyAgICA2Ljc4MDQw
M10gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUgZW50cmllczogMjYyMTQ0IChvcmRlcjogOSwg
MjA5NzE1MiBieXRlcywgbGluZWFyKQpbICAgIDYuNzg5NDE1XSBUQ1AgYmluZCBoYXNoIHRhYmxl
IGVudHJpZXM6IDY1NTM2IChvcmRlcjogOCwgMTA0ODU3NiBieXRlcywgbGluZWFyKQpbICAgIDYu
Nzk3Mjc5XSBUQ1A6IEhhc2ggdGFibGVzIGNvbmZpZ3VyZWQgKGVzdGFibGlzaGVkIDI2MjE0NCBi
aW5kIDY1NTM2KQpbICAgIDYuODAzOTUwXSBVRFAgaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAo
b3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAgIDYuODExMTU5XSBVRFAtTGl0ZSBo
YXNoIHRhYmxlIGVudHJpZXM6IDE2Mzg0IChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIp
ClsgICAgNi44MTg5MjFdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMQpbICAgIDYu
ODIzNDQ2XSBSUEM6IFJlZ2lzdGVyZWQgbmFtZWQgVU5JWCBzb2NrZXQgdHJhbnNwb3J0IG1vZHVs
ZS4KWyAgICA2LjgyOTM1OF0gUlBDOiBSZWdpc3RlcmVkIHVkcCB0cmFuc3BvcnQgbW9kdWxlLgpb
ICAgIDYuODM0MDUxXSBSUEM6IFJlZ2lzdGVyZWQgdGNwIHRyYW5zcG9ydCBtb2R1bGUuClsgICAg
Ni44Mzg3NDVdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgTkZTdjQuMSBiYWNrY2hhbm5lbCB0cmFuc3Bv
cnQgbW9kdWxlLgpbICAgIDYuODQ1MjIyXSBwY2kgMDAwZDowMTowMC4xOiBEMCBwb3dlciBzdGF0
ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDYuODUxNjIzXSBwY2kgMDAwZDowMTowMC4y
OiBEMCBwb3dlciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDYuODU4MDAxXSBw
Y2kgMDAwZDowMTowMC4yOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAgICA2Ljg2
MzcwMV0gcGNpIDAwMGQ6MDE6MDAuMzogRDAgcG93ZXIgc3RhdGUgZGVwZW5kcyBvbiAwMDBkOjAx
OjAwLjAKWyAgICA2Ljg3MDEwMl0gcGNpIDAwMDQ6MDM6MDAuMDogZW5hYmxpbmcgZGV2aWNlICgw
MDAwIC0+IDAwMDIpClsgICAgNi44NzU3OTBdIHBjaSAwMDA1OjAyOjAwLjA6IGVuYWJsaW5nIGRl
dmljZSAoMDAwMCAtPiAwMDAyKQpbICAgIDYuODgxNDYyXSBQQ0k6IENMUyAxMjggYnl0ZXMsIGRl
ZmF1bHQgNjQKWyAgICA2Ljg4NjgxNV0gaHcgcGVyZmV2ZW50czogZW5hYmxlZCB3aXRoIGFybXY4
X3BtdXYzXzAgUE1VIGRyaXZlciwgNyBjb3VudGVycyBhdmFpbGFibGUKWyAgICA2Ljg5NjIxOF0g
d29ya2luZ3NldDogdGltZXN0YW1wX2JpdHM9NDIgbWF4X29yZGVyPTIzIGJ1Y2tldF9vcmRlcj0w
ClsgICAgNi45MDQ0MzBdIE5GUzogUmVnaXN0ZXJpbmcgdGhlIGlkX3Jlc29sdmVyIGtleSB0eXBl
ClsgICAgNi45MDk0ODRdIEtleSB0eXBlIGlkX3Jlc29sdmVyIHJlZ2lzdGVyZWQKWyAgICA2Ljkx
MzY1N10gS2V5IHR5cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQKWyAgICA2LjkxNzkzN10gS2V5IHR5
cGUgY2lmcy5pZG1hcCByZWdpc3RlcmVkClsgICAgNi45MzY2MTNdIHhvcjogbWVhc3VyaW5nIHNv
ZnR3YXJlIGNoZWNrc3VtIHNwZWVkClsgICAgNi45NDI0MDJdICAgIDhyZWdzICAgICAgICAgICA6
ICA5Nzk3IE1CL3NlYwpbICAgIDYuOTQ3NTg2XSAgICAzMnJlZ3MgICAgICAgICAgOiAxMTc2MSBN
Qi9zZWMKWyAgICA2Ljk1MjYzNl0gICAgYXJtNjRfbmVvbiAgICAgIDogMTM5NzIgTUIvc2VjClsg
ICAgNi45NTY5ODJdIHhvcjogdXNpbmcgZnVuY3Rpb246IGFybTY0X25lb24gKDEzOTcyIE1CL3Nl
YykKWyAgICA2Ljk2MjQ2Nl0gQmxvY2sgbGF5ZXIgU0NTSSBnZW5lcmljIChic2cpIGRyaXZlciB2
ZXJzaW9uIDAuNCBsb2FkZWQgKG1ham9yIDI0OSkKWyAgICA2Ljk2OTg1Ml0gaW8gc2NoZWR1bGVy
IG1xLWRlYWRsaW5lIHJlZ2lzdGVyZWQKWyAgICA2Ljk3NDM3Ml0gaW8gc2NoZWR1bGVyIGt5YmVy
IHJlZ2lzdGVyZWQKWyAgICA2Ljk3OTA3Ml0gZ3Bpby1kd2FwYiBBUE1DMEQwNzowMjogbm8gSVJR
IGZvciBwb3J0MApbICAgIDYuOTg0ODM5XSBpbnB1dDogUG93ZXIgQnV0dG9uIGFzIC9kZXZpY2Vz
L0xOWFNZU1RNOjAwL0xOWFNZQlVTOjAwL1BOUDBDMEM6MDAvaW5wdXQvaW5wdXQwClsgICAgNi45
OTMyMzRdIEFDUEk6IFBvd2VyIEJ1dHRvbiBbUFdSQl0KWyAgICA3LjAwMDA0M10gR0hFUzogQVBF
SSBmaXJtd2FyZSBmaXJzdCBtb2RlIGlzIGVuYWJsZWQgYnkgQVBFSSBiaXQuClsgICAgNy4wMDYy
NjFdIEVJTko6IEVycm9yIElOSmVjdGlvbiBpcyBpbml0aWFsaXplZC4KWyAgICA3LjAxMDk5M10g
QUNQSSBHVERUOiBmb3VuZCAxIFNCU0EgZ2VuZXJpYyBXYXRjaGRvZyhzKS4KWyAgICA3LjAxNzAz
NV0gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gcGxhdGZvcm0gaGFzIG5vIElPIHNwYWNlLCB0cnlp
bmcgTU1JTwpbICAgIDcuMDIzODIzXSBhc3QgMDAwNDowMjowMC4wOiBbZHJtXSBVc2luZyBQMkEg
YnJpZGdlIGZvciBjb25maWd1cmF0aW9uClsgICAgNy4wMzAzNDJdIGFzdCAwMDA0OjAyOjAwLjA6
IFtkcm1dIEFTVCAyNTAwIGRldGVjdGVkClsgICAgNy4wMzUzODddIGFzdCAwMDA0OjAyOjAwLjA6
IFtkcm1dIEFuYWxvZyBWR0Egb25seQpbICAgIDcuMDQwMjYwXSBhc3QgMDAwNDowMjowMC4wOiBb
ZHJtXSBkcmFtIE1DTEs9ODAwIE1oeiB0eXBlPTggYnVzX3dpZHRoPTE2ClsgICAgNy4wNDcxMzJd
IFtUVE1dIFpvbmUgIGtlcm5lbDogQXZhaWxhYmxlIGdyYXBoaWNzIG1lbW9yeTogMTYyNTEwOTQg
S2lCClsgICAgNy4wNTM3MzddIFtUVE1dIFpvbmUgICBkbWEzMjogQXZhaWxhYmxlIGdyYXBoaWNz
IG1lbW9yeTogMjA5NzE1MiBLaUIKWyAgICA3LjA2MDI1NV0gW1RUTV0gSW5pdGlhbGl6aW5nIHBv
b2wgYWxsb2NhdG9yClsgICAgNy4wNjQ2MDRdIFtUVE1dIEluaXRpYWxpemluZyBETUEgcG9vbCBh
bGxvY2F0b3IKWyAgICA3LjA2OTU0OF0gW2RybV0gSW5pdGlhbGl6ZWQgYXN0IDAuMS4wIDIwMTIw
MjI4IGZvciAwMDA0OjAyOjAwLjAgb24gbWlub3IgMApbICAgIDcuMDkzOTk5XSBDb25zb2xlOiBz
d2l0Y2hpbmcgdG8gY29sb3VyIGZyYW1lIGJ1ZmZlciBkZXZpY2UgMTI4eDQ4ClsgICAgNy4xMDI0
NTFdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIGZiMDogYXN0ZHJtZmIgZnJhbWUgYnVmZmVyIGRl
dmljZQpbICAgIDcuMTIzMDA3XSBicmQ6IG1vZHVsZSBsb2FkZWQKWyAgICA3LjEzMDUzMF0gbG9v
cDogbW9kdWxlIGxvYWRlZApbICAgIDcuMTM0MTU5XSBudm1lIG52bWUwOiBwY2kgZnVuY3Rpb24g
MDAwNTowNDowMC4wClsgICAgNy4xMzkxMjJdIGlnYjogSW50ZWwoUikgR2lnYWJpdCBFdGhlcm5l
dCBOZXR3b3JrIERyaXZlcgpbICAgIDcuMTQxMDI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NTEyIGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjE0NDUxM10gaWdiOiBDb3B5cmlnaHQg
KGMpIDIwMDctMjAxNCBJbnRlbCBDb3Jwb3JhdGlvbi4KWyAgICA3LjE1MDQyMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTUxMiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4xNjI0MzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT0yMDQ4IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjE2ODQzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTIwNDggZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuMTgyMDE4XSBudm1lIG52bWUwOiBtaXNzaW5nIG9yIGludmFsaWQgU1VC
TlFOIGZpZWxkLgpbICAgIDcuMTkyMzY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
MjU2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjE5ODY1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTI1NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4yMDQ1NzRdIHBwcyBwcHMwOiBu
ZXcgUFBTIHNvdXJjZSBwdHAwClsgICAgNy4yMDg1OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcuMjE1MDMzXSBpZ2IgMDAw
NDowNDowMC4wOiBhZGRlZCBQSEMgb24gZXRoMApbICAgIDcuMjE5NTUzXSBpZ2IgMDAwNDowNDow
MC4wOiBJbnRlbChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgQ29ubmVjdGlvbgpbICAgIDcu
MjI2NDE3XSBpZ2IgMDAwNDowNDowMC4wOiBldGgwOiAoUENJZToyLjVHYi9zOldpZHRoIHgxKSAw
MDozMDo2NDozYjo1MDo1MgpbICAgIDcuMjMzNTQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjI0MDA5M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy4y
NDY1ODFdIGlnYiAwMDA0OjA0OjAwLjA6IGV0aDA6IFBCQSBObzogMDAwMzAwLTAwMApbICAgIDcu
MjUxNzA4XSBpZ2IgMDAwNDowNDowMC4wOiBVc2luZyBNU0ktWCBpbnRlcnJ1cHRzLiA0IHJ4IHF1
ZXVlKHMpLCA0IHR4IHF1ZXVlKHMpClsgICAgNy4yNTkyNjZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcuMjY1NzcwXSBpZ2J2
ZjogSW50ZWwoUikgR2lnYWJpdCBWaXJ0dWFsIEZ1bmN0aW9uIE5ldHdvcmsgRHJpdmVyClsgICAg
Ny4yNjU4ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MTk0MzA0IGZsYWdzPWNj
MCBhdHRyPTExMApbICAgIDcuMjcyMDMxXSBpZ2J2ZjogQ29weXJpZ2h0IChjKSAyMDA5IC0gMjAx
MiBJbnRlbCBDb3Jwb3JhdGlvbi4KWyAgICA3LjI3ODQ2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy4yODQzODFdIGk0MGU6
IEludGVsKFIpIEV0aGVybmV0IENvbm5lY3Rpb24gWEw3MTAgTmV0d29yayBEcml2ZXIKWyAgICA3
LjI5MDkxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQxOTQzMDQgZmxhZ3M9Y2Mw
IGF0dHI9MTEwClsgICAgNy4yOTcwNTRdIGk0MGU6IENvcHlyaWdodCAoYykgMjAxMyAtIDIwMTkg
SW50ZWwgQ29ycG9yYXRpb24uClsgICAgNy4yOTcyMDldIGk0MGUgMDAwMDowMTowMC4wOiBlbmFi
bGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAgICA3LjMwMzQ4Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy4zMjA2NTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjMyMTU4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQxOTQzMDQgZmxhZ3M9
Y2MwIGF0dHI9MTEwClsgICAgNy4zMjc0NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjMyNzQ2N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMzMzODkyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3
LjMzNDAxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQxOTQzMDQgZmxhZ3M9Y2Mw
IGF0dHI9MTEwClsgICAgNy4zMzk4ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjMzOTg5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMzQ1ODg1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjM0
NjAwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0
dHI9MTEwClsgICAgNy4zNTIzMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjM1ODc0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy4zNTg4NjNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcu
MzY0NzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgNy4zNzA3MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MTk0MzA0
IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcuMzcwODU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjM3NzE2N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMzc3
MTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgNy4zODM1OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MTk0MzA0IGZs
YWdzPWNjMCBhdHRyPTExMApbICAgIDcuMzg5NTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4zODk1OTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjM5NjE0MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsg
ICAgNy40MDI0NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA3LjQwMjQ1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDA4NDQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjQwODU2N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAg
Ny40MTQ4NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA3LjQxNDg4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDIxMzA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjQyNzMwMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDI3MzA1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgNy40MzM0MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MTk0MzA0IGZsYWdz
PWNjMCBhdHRyPTExMApbICAgIDcuNDM5NzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy40Mzk3MjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQ0NTcyNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAg
Ny40NDU4NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MTk0MzA0IGZsYWdzPWNj
MCBhdHRyPTExMApbICAgIDcuNDUxNzIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy40NTE3MjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQ1ODE1MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy40
NjQxNDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA3LjQ2NDE0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDcuNDcwMjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjQ3NjU2OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDc2NTcxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
Ny40ODMwMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MTk0MzA0IGZsYWdzPWNj
MCBhdHRyPTExMApbICAgIDcuNDgzMTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjQ4ODk5OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDk0OTkyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAg
ICA3LjUwMTQyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuNTA3NTMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDE5
NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjUxMzQwOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNTEzNDEyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41MTk4
NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRy
PTExMApbICAgIDcuNTE5OTYxXSBudm1lIG52bWUwOiBhbGxvY2F0ZWQgNjQgTWlCIGhvc3QgbWVt
b3J5IGJ1ZmZlci4KWyAgICA3LjUyNTgzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNTI1ODM4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41NDUwMDddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT0xNjM4NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41NTA2
OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA3LjU1MDY5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDcuNTUwNjk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41NTA2OTVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjU1MDY5OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNTU2Njk0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDcuNTYzMTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgNy41NjkxMjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT02
NTUzNiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41NzUxMTVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjU4MTU0NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjU4NzUz
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDcuNTkzNTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9MTYzODQgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDcuNTk5OTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42MDYzOTNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT0xNjM4NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42MTIzODldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjYxODgx
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA3LjYyNDgxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDcuNjMxMjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NjU1MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjMxMjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjM3MjM5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42NDMy
MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT0xNjM4NCBmbGFncz1jYzAgYXR0cj0w
ClsgICAgNy42NDk2NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA3LjY1NTMxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjY2MTMwN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjY3MzAyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NjU1MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjY3
MzA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDcuNjczMzg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgNy42NzMzOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjY3MzM5Ml0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjc5Mzg2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjc5
MzkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NjU1MzYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDcuNjg1MzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgNy42OTEzNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT02NTUzNiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42OTEzODFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT0xNjM4NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42OTczNzRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljcw
MzM2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTE2Mzg0IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA3LjcwMzM3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTY1NTM2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA3LjcwOTQ1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzE1NDQ0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NjU1MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzE1NDQ5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcu
NzIxNTI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgNy43Mjc1MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT0xNjM4NCBm
bGFncz1jYzAgYXR0cj0wClsgICAgNy43Mjc1MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT02NTUzNiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43MzM2MDZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjczOTYwMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3
LjczOTYwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTE2Mzg0IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA3Ljc0NTY4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzUxNjc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzUxNjgwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NjU1MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzU3NzYxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
Ny43NjM3NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT02NTUzNiBmbGFncz1jYzAg
YXR0cj0wClsgICAgNy43NjM3NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT0xNjM4
NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43Njk4MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljc2OTgzOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzc1ODMzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDcuNzc1ODM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NjU1MzYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuNzgxOTE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43ODc5OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT02NTUzNiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy44ODQ2NjldIG52bWUgbnZtZTA6
IDgvMC8wIGRlZmF1bHQvcmVhZC9wb2xsIHF1ZXVlcwpbICAgIDcuODkwNzIxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy44OTA3MjNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3Ljk4MTU2N10gIG52bWUwbjE6IHAxIHAyIHAzClsgICAgNy45ODc2MjddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjA1MDAxMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguMDU2MDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC4wNjIwMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjA2ODAwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMDczOTk3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4wNzk5OTVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
LjA4NTk5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguMDkxOTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC4wOTc5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjEwMzk4MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTA5OTc5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4x
MTU5NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4LjEyMTk3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDguMTI3OTY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4xMzM5NjRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjEzOTk2Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTQ1
OTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC4xNTE5NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4LjE1Nzk0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTYzOTQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4xNjk5NDJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjE3NTkz
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguMTgxOTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC4xODc5MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjE5MzkyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTk5OTI0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yMDU5MjBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4LjIxMTkxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguMjE3OTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yMjM5MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjIyOTkwN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjM1OTA0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC4yNDE5MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4LjI0Nzg5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjUzODkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yNTk4ODddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjI2NTg4Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
MjcxODc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC4yNzc4NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4LjI4Mzg3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjg5ODY1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yOTU4NjBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjMw
MTg1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguMzA3ODU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC4zMTM4NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjMxOTg1MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzI1ODQ1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zMzE4
NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA4LjMzNzgzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDguMzQzODMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zNDk4MjldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjM1NTgyNV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzYxODE5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOC4zNjc4MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA4LjM3MzgxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzc5ODA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zODU4MDJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjM5MTc5OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguMzk3NzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC40MDM3ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQwOTc4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDE1NzgwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40MjE3NzRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
LjQyNzc3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguNDMzNzY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC40Mzk3NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQ0NTc1OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDUxNzU0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40
NTc3NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4LjQ2Mzc0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDguNDY5NzM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40NzU3MzZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQ4MTczMV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDg3
NzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC40OTM3MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4LjQ5OTcxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTA1NzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41MTE3MDldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjUxNzcw
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguNTIzNzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC41Mjk2OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjUzNTY5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTQxNjg3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41NDc2ODNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4LjU1MzY3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguNTU5Njc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41NjU2NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjU3MTY2NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTc3NjYwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC41ODM2NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4LjU4OTY1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTk1NjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42MDE2NDJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjYwNzYzN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
NjEzNjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC42MTk2MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4LjYyNTYyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNjMxNjE5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42Mzc2MTRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjY0
MzYxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguNjQ5NjA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC42NTU2MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjY2MTU5NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNjY3NTkxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42NzM1
ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA4LjY3OTU4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDguNjg1NTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42OTE1NzJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjY5NzU2N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzAzNTYz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOC43MDk1NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA4LjcxNTU1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzIxNTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43Mjc1NDRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjczMzU0MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguNzM5NTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC43NDU1MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljc1MTUyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzU3NTIxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43NjM1MTZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
Ljc2OTUxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguNzc1NTA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC43ODE1MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljc4NzQ5N10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzkzNDkyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43
OTk0OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4LjgwNTQ4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDguODExNDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44MTc0NzhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjgyMzQ3M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODI5
NDY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC44MzU0NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4Ljg0MTQ1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODQ3NDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44NTM0NDldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljg1OTQ0
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguODY1NDQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC44NzE0MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljg3NzQzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODgzNDI5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44ODk0MjVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4Ljg5NTQyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguOTAxNDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45MDc0MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjkxMzQwNl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTE5NDAyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC45MjUzOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4LjkzMTM5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTM3Mzg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45NDMzODRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk0OTM3OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
OTU1Mzc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC45NjEzNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk2NzM2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTczMzYwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45NzkzNTVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk4
NTM1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguOTkxMzQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC45OTczNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjAwMzMzNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDA5MzMxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wMTUz
MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5LjAyMTMyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuMDI3MzE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wMzMzMTNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjAzOTMwOV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDQ1MzA0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS4wNTEyOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5LjA1NzI5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDYzMjkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wNjkyODVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjA3NTI4MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuMDgxMjc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS4wODcyNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjA5MzI2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDk5MjYzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4xMDUyNThdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
LjExMTI1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuMTE3MjQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS4xMjMyNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjEyOTIzOV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTM1MjM1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4x
NDEyMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA5LjE0NzIyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuMTUzMjIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4xNTkyMTddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjE2NTIxMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTcx
MjA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS4xNzcyMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5LjE4MzE5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTg5MTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4xOTUxODldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjIwMTE4
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuMjA3MTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS4yMTMxNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjIxOTE3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjI1MTY2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yMzExNjFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5LjIzNzE1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuMjQzMTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yNDkxNDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjI1NTE0M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjYxMTM4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS4yNjcxMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5LjI3MzEyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjc5MTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yODUxMTldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjI5MTExNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
Mjk3MTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS4zMDMxMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5LjMwOTEwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzE1MDk2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4zMjEwOTFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjMy
NzA5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDkuMzMzMDg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOS4zMzkwODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjM0NTA3OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzUxMDc1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4zNTcw
NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5LjM2MzA2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuMzY5MDYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4zNzUwNTddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjM4MTA1Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzg3MDQ3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS4zOTMwNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5LjM5OTA0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDA1MDM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40MTEwMzFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQxNzAyNl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuNDIzMDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS40MjkwMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQzNTAxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDQxMDA3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40NDcwMDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
LjQ1Mjk5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuNDU4OTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS40NjQ5ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQ3MDk4NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDc2OTc5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40
ODI5NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA5LjQ4ODk3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuNDk0OTY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41MDA5NjFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjUwNjk1Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTEy
OTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS41MTg5NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5LjUyNDk0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTMwOTM4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41MzY5MzNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjU0Mjky
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuNTQ4OTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS41NTQ5MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjU2MDkxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTY2OTE0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41NzI5MDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5LjU3ODkwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuNTg0OTAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41OTA4OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjU5Njg5MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjAyODg2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS42MDg4ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5LjYxNDg3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjIwODcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42MjY4NjhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjYzMjg2M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
NjM4ODU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS42NDQ4NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5LjY1MDg0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjU2ODQ0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42NjI4MzldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjY2
ODgzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDkuNjc0ODMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOS42ODA4MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjY4NjgyMV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjkyODE2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42OTg4
MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5LjcwNDgwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuNzEwODAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43MTY3OTddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjcyMjc5M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzI4Nzg4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS43MzQ3ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5Ljc0MDc3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzQ2Nzc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43NTI3NjldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljc1ODc2NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuNzY0NzYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS43NzA3NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljc3Njc1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzgyNzQ2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43ODg3NDFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
Ljc5NDczN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuODAwNzMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS44MDY3MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjgxMjcyMl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODE4NzE4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44
MjQ3MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA5LjgzMDcwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuODM2NzA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44NDI3MDBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljg0ODY5NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODU0
NjkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS44NjA2ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5Ljg2NjY4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODcyNjc3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44Nzg2NzJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljg4NDY2
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuODkwNjYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS44OTY2NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjkwMjY1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTA4NjUxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45MTQ2NDdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5LjkyMDY0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuOTI2NjM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45MzI2MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjkzODYyOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTQ0NjI0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS45NTA2MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5Ljk1NjYxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTYyNjEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45Njg2MDVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljk3NDYwMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
OTgwNTk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS45ODY1OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5Ljk5MjU4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTk4NTgzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wMDQ1NzhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjAx
MDU3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuMDE2NTY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC4wMjI1NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjAyODU1OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDM0NTU1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wNDA1
NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjA0NjU0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuMDUyNTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wNTg1MzZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjA2NDUzMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDcwNTI5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC4wNzY1MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjA4MjUyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDg4NTE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wOTQ1MTBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjEwMDUwNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuMTA2NTAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC4xMTI0OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjExODQ5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTI0NDg3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4xMzA0ODJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEw
LjEzNjQ3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTAuMTQyNDczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMC4xNDg0NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjE1NDQ2NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTYwNDU5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4x
NjY0NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjE3MjQ0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuMTc4NDQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4xODQ0NDBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjE5MDQzNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTk2
NDMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC4yMDI0MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjIwODQyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjE0NDE3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yMjA0MTJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjIyNjQw
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuMjMyNDAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC4yMzgzOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjI0NDM5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjUwMzg5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yNTYzODVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjI2MjM4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuMjY4Mzc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yNzQzNzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjI4MDM2Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjg2MzYyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC4yOTIzNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjI5ODM1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzA0MzQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zMTAzNDZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjMxNjM0MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAu
MzIyMzM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMC4zMjgzMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEwLjMzNDMyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzQwMzIyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zNDYzMThdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjM1
MjMxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuMzU4MzE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC4zNjQzMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjM3MDMwNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzc2MzAxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zODIy
OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjM4ODI5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuMzk0Mjg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC40MDAyODNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQwNjI3OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDEyMjcz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC40MTgyNzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjQyNDI2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDMwMjYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC40MzYyNTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQ0MjI1Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuNDQ4MjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC40NTQyNDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQ2MDIzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDY2MjMzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC40NzIyMjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEw
LjQ3ODIyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTAuNDg0MjE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMC40OTAyMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQ5NjIwOV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTAyMjA1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41
MDgyMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjUxNDE5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuNTIwMTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41MjYxODddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjUzMjE4Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTM4
MTc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC41NDQxNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjU1MDE2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTU2MTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41NjIxNjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjU2ODE1
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuNTc0MTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC41ODAxNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjU4NjE0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTkyMTM3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41OTgxMzJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjYwNDEyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuNjEwMTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42MTYxMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjYyMjExNF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjI4MTA5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC42MzQxMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjY0MDA5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjQ2MDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42NTIwOTBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjY1ODA4Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAu
NjY0MDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMC42NzAwNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEwLjY3NjA3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjgyMDY3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42ODgwNjJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjY5
NDA1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuNzAwMDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC43MDYwNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjcxMjA0M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzE4MDM5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43MjQw
MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjczMDAzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuNzM2MDI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43NDIwMjBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjc0ODAxNV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzU0MDEx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC43NjAwMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjc2NjAwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTgx
OTIgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzcxOTk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43Nzc5OTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjc4Mzk5MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuNzg5OTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC43OTU5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjgwMTk3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODA3OTcyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44MTM5NjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEw
LjgxOTk2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTAuODI1OTU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMC44MzE5NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjgzNzk0OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODQzOTQ0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44
NDk5NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjg1NTkzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuODYxOTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44Njc5MjVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjg3MzkyMV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODc5
OTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC44ODU5MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjg5MTkwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODk3OTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45MDM4OThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjkwOTg5
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuOTE1ODg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC45MjE4ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjkyNzg4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTMzODc3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45Mzk4NzJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjk0NTg2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuOTUxODYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45NTc4NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjk2Mzg1M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTY5ODQ5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC45NzU4NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjk4MTgzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTg3ODM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45OTM4MzBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjk5OTgyNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
MDA1ODIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS4wMTE4MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjAxNzgxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDIzODA3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wMjk4MDJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjAz
NTc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuMDQxNzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS4wNDc3ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjA1Mzc4M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDU5Nzc4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wNjU3
NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjA3MTc2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuMDc3NzY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wODM3NjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjA4OTc1OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDk1NzUz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS4xMDE3NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjEwNzc0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTEzNzM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4xMTk3MzRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjEyNTczMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTEuMTMxNzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMS4xMzc3MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjE0MzcxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTQ5NzExXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4xNTU3MDddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
LjE2MTcwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuMTY3Njk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS4xNzM2OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjE3OTY4OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTg1Njg0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4x
OTE2NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjE5NzY3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuMjAzNjcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yMDk2NjVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjIxNTY2MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjIx
NjU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS4yMjc2NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjIzMzY0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjM5NjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yNDU2MzhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjI1MTYz
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuMjU3NjI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS4yNjM2MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjI2OTYxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjc1NjE0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yODE2MDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjI4NzYwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuMjkzNjAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yOTk1OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjMwNTU5MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzExNTg2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MS4zMTc1ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDExLjMyMzU3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzI5NTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4zMzU1NjddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjM0MTU2M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
MzQ3NTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS4zNTM1NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjM1OTU0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzY1NTQ1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4zNzE1NDZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjM3
NzU0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuMzgzNTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS4zODk1MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjM5NTUyOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDAxNTIzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40MDc1
MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjQxMzUxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuNDE5NTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40MjU1MDVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQzMTQ5OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDM3NDk1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS40NDM0OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjQ0OTQ4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDU1NDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40NjE0NzldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQ2NzQ3NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTEuNDczNDcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMS40Nzk0NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQ4NTQ2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDkxNDU1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40OTc0NTFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
LjUwMzQ0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuNTA5NDQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS41MTU0MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjUyMTQzMl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTI3NDI3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41
MzM0MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjUzOTQxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuNTQ1NDE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41NTE0MDldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjU1NzQwNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTYz
Mzk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS41NjkzOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjU3NTM5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTgxMzg2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41ODczODFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjU5MzM3
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuNTk5MzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS42MDUzNjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjYxMTM2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjE3MzU4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42MjMzNTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjYyOTM0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuNjM1MzQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42NDEzNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjY0NzMzNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjUzMzMxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MS42NTkzMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDExLjY2NTMyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjcxMzE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42NzczMTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjY4MzMwN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
Njg5MzAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS42OTUyOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjcwMTI5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzA3Mjg5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43MTMyODRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjcx
OTI3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuNzI1Mjc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS43MzEyNzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjczNzI2Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzQzMjYwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43NDky
NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjc1NTI1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuNzYxMjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43NjcyNDJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjc3MzIzN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzc5MjMz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS43ODUyMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjc5MTIyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzk3MjE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44MDMyMTRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjgwOTIxMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTEuODE1MjA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMS44MjEyMDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjgyNzE5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuODMzMTk0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44MzkxODldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
Ljg0NTE4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuODUxMTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS44NTcxNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjg2MzE3MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuODY5MTY2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44
NzUxNjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjg4MTE1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuODg3MTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44OTMxNDddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjg5OTE0M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTA1
MTM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS45MTExMzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjkxNzEyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTIzMTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45MjkxMjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjkzNTEx
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuOTQxMTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS45NDcxMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjk1MzEwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTU5MDk4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45NjUwOTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjk3MTA4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuOTc3MDg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45ODMwODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjk4OTA3Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTk1MDcxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Mi4wMDEwNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEyLjAwNzA2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDEzMDU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4wMTkwNTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjAyNTA0OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIu
MDMxMDQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi4wMzcwMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEyLjA0MzAzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDQ5MDI5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4wNTUwMjRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjA2
MTAyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTIuMDY3MDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMi4wNzMwMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjA3OTAwNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDg1MDAyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4wOTA5
OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEyLjA5Njk5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTIuMTAyOTg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xMDg5ODRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjExNDk3OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTIwOTc0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMi4xMjY5NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEyLjEzMjk2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTM4OTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xNDQ5NTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjE1MDk1MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTIuMTU2OTQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMi4xNjI5NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjE2ODkzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTc0OTMzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xODA5MjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEy
LjE4NjkyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTIuMTkyOTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi4xOTg5MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjIwNDkxMF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjEwOTA1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4y
MTY5MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEyLjIyMjg5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTIuMjI4ODkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4yMzQ4ODddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjI0MDg4Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjQ2
ODc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMi4yNTI4NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEyLjI1ODg2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjY0ODY0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4yNzA4NTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjI3Njg1
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTIuMjgyODQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMi4yODg4NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjI5NDg0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzAwODM2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zMDY4MzFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEyLjMxMjgyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTIuMzE4ODIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zMjQ4MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjMzMDgxMl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzM2ODA4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Mi4zNDI4MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEyLjM0ODc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzU0NzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zNjA3ODldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjM2Njc4NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIu
MzcyNzg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi4zNzg3ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEyLjM4NDc4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzkwNzc1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zOTY3NzddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQw
Mjc3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTIuNDA4NzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMi40MTQ3NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQyMDc1OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDI2NzUzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40MzI3
NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEyLjQzODc0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTIuNDQ0NzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40NTA3MzRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQ1NjczMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDYyNzI1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMi40Njg3MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEyLjQ3NDcxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDgwNzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40ODY3MDldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQ5MjcwNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTIuNDk4NzAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMi41MDQ2OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjUxMDY5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTE2Njg3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41MjI2ODJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEy
LjUyODY3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTIuNTM0NjcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi41NDA2NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjU0NjY2M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTUyNjU5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41
NTg2NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEyLjU2NDY1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTIuNTcwNjQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41NzY2NDBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjU4MjYzNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTg4
NjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMi41OTQ2MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEyLjYwMDYyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjA2NjIxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42MTI2MTZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjYxODYx
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTIuNjI0NjA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMi42MzA2MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjYzNjU5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjQyNTkyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42NDg1ODhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEyLjY1NDU4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTIuNjYwNTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42NjY1NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjY3MjU2OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjc4NTY0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Mi42ODQ1NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEyLjY5MDU1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjk2NTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi43MDI1NDVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjcwODU0MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIu
NzE0NTM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi43MjA1MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEyLjcyNjUyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNzMyNTIzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi43Mzg1MThdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjc0
NDUxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTIuNzUwNTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMi43NTY1MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjc2MjUwMF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNzY4NDk1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi43NzQ0
OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEyLjc4MDQ4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTIuNzg2NDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi43OTI0NzddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjc5ODQ3Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuODA0NDY4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMi44MTA0NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEyLjgxNjQ1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuODIyNDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi44Mjg0NDldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjgzNDQ0NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTIuODQwNDM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMi44NDY0MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjg1MjQzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuODU4NDI1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi44NjQ0MjFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEy
Ljg3MDQxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTIuODc2NDExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi44ODI0MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjg4ODQwNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuODk0Mzk5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi45
MDAzOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEyLjkwNjM4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTIuOTEyMzg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi45MTgzODBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjkyNDM3Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuOTMw
MzcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMi45MzYzNjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEyLjk0MjM2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuOTQ4MzU3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi45NTQzNTJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjk2MDM0
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTIuOTY2MzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMi45NzIzMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjk3ODMzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuOTg0MzMxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi45OTAzMjZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEyLjk5NjMyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTMuMDAyMzE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4wMDgzMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjAxNDMwOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMDIwMzA0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My4wMjYyOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjAzMjI5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMDM4Mjg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4wNDQyODVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA1MDI4MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
MDU2Mjc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy4wNjIyNzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA2ODI2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMDc0MjYxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4wODAyNTddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA4
NjI1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuMDkyMjQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy4wOTgyNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjEwNDIzOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTEwMjM0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xMTYy
MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjEyMjIyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuMTI4MjIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xMzQyMTVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjE0MDIxM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTQ2MjA5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMy4xNTIyMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEzLjE1ODE5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTY0MTk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xNzAxOTBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjE3NjE4N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTMuMTgyMTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMy4xODgxNzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjE5NDE3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjAwMTY5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yMDYxNjRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEz
LjIxMjE2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTMuMjE4MTU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMy4yMjQxNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjIzMDE0Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjM2MTQyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4y
NDIxMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEzLjI0ODEzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTMuMjU0MTI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yNjAxMjVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjI2NjEyMF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjcy
MTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMy4yNzgxMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEzLjI4NDEwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjkwMTAyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yOTYwOThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjMwMjA5
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTMuMzA4MDg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMy4zMTQwODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjMyMDA4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzI2MDc1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zMzIwNzFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEzLjMzODA2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTMuMzQ0MDY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zNTAwNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjM1NjA1Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzYyMDUxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My4zNjgwNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjM3NDA0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzgwMDM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zODYwMzNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjM5MjAyOV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
Mzk4MDI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy40MDQwMjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQxMDAxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDE2MDE4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40MjIwMTNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQy
ODAwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuNDM0MDAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy40Mzk5OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQ0NTk5NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDUxOTg5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40NTc5
ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjQ2Mzk4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuNDY5OTc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40NzU5NzFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQ4MTk2Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDg3OTYz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMy40OTM5NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEzLjQ5OTk1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTA1OTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41MTE5NDVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjUxNzk0MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTMuNTIzOTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMy41Mjk5MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjUzNTkyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTQxOTIyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41NDc5MTddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEz
LjU1MzkxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTMuNTU5OTA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMy41NjU5MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjU3MTg5OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTc3ODk0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41
ODM4OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEzLjU4OTg4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTMuNTk1ODgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42MDE4NzVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjYwNzg3MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjEz
ODY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMy42MTk4NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEzLjYyNTg1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjMxODUzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42Mzc4NDhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjY0Mzg0
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTMuNjQ5ODM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMy42NTU4MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjY2MTgzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjY3ODI1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42NzM4MjBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEzLjY3OTgxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTMuNjg1ODExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42OTE4MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjY5NzgwMV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzAzNzk4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My43MDk3OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjcxNTc4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzIxNzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43Mjc3NzldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjczMzc3NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
NzM5NzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy43NDU3NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjc1MTc2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzU3NzU2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43NjM3NTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjc2
OTc0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuNzc1NzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy43ODE3MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjc4NzczNF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzkzNzI5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43OTk3
MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjgwNTcxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuODExNzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy44MTc3MTBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjgyMzcwNl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuODI5NzAx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMy44MzU2OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEzLjg0MTY5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuODQ4NjQxXSBpNDBlIDAwMDA6MDE6MDAuMDogZncg
Ni4wLjQ4NDQyIGFwaSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5
XSBbODA4NjowMDAyXQpbICAgMTQuMTM2NDQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NjE0NDAgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTQyNTI0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NjE0NDAgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTQ4NzE5XSBpNDBl
IDAwMDA6MDE6MDAuMDogTUFDIGFkZHJlc3M6IDNjOmZkOmZlOjZiOmU5OmMwClsgICAxNC4xNTQ2
MDldIGk0MGUgMDAwMDowMTowMC4wOiBGVyBMTERQIGlzIGVuYWJsZWQKWyAgIDE0LjE2NTI3Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuMTcxMjc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC4xNzcyNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjE4MzI2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTkyODQzXSBpNDBlIDAwMDA6MDE6
MDAuMDogUENJLUV4cHJlc3M6IFNwZWVkIDguMEdUL3MgV2lkdGggeDgKWyAgIDE0LjIwMDEwMl0g
aTQwZSAwMDAwOjAxOjAwLjA6IEZlYXR1cmVzOiBQRi1pZFswXSBWU0lzOiAzNCBRUDogMzIgUlNT
IEZEX0FUUiBGRF9TQiBOVFVQTEUgVnhMQU4gR2VuZXZlIFBUUCBWRVBBClsgICAxNC4yMTAyODFd
IGk0MGUgMDAwMDowMTowMC4xOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAgIDE0
LjIyNjQ5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTgxOTIgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuMjMyNDkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9ODE5MiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC4yMzg0OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjI0NDQ4Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMjUwNDgyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4y
NTY0NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0LjI2MjQ3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuMjY4NDY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4yNzQ0NjRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjI4MDQ1OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMjg2
NDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC4yOTI0NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0LjI5ODQ0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzA0NDQxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zMTA0MzddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjMxNjQz
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTQuMzIyNDI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNC4zMjg0MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjMzNDQxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzQwNDEzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zNDY0MDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE0LjM1MjQwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTQuMzU4NDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zNjQzOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjM3MDM5MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzc2Mzg1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NC4zODIzODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE0LjM4ODM3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzk0MzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40MDAzNjddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQwNjM2M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQu
NDEyMzU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNC40MTgzNTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQyNDM0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNDMwMzQ1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40MzYzNDBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQ0
MjMzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTQuNDQ4MzMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNC40NTQzMzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQ2MDMyN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNDY2MzIyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40NzIz
MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE0LjQ3ODMxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTQuNDg0MzA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40OTAzMDRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQ5NjI5OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTAyMjk0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNC41MDgyODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE0LjUxNDI4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTIwMjgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC41MjYyNzhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjUzMjI3M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuNTM4MjY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC41NDQyNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjU1MDI1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTU2MjU0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC41NjIyNTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0
LjU2ODI0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuNTc0MjQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC41ODAyMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjU4NjIzMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTkyMjI2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC41
OTgyMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0LjYwNDIxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuNjEwMjEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42MTYyMDhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjYyMjIwNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjI4
MTk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC42MzQxOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0LjY0MDE5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjQ2MTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42NTIxODFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjY1ODE3
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTQuNjY0MTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNC42NzAxNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjY3NjE2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjgyMTU3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42ODgxNTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE0LjY5NDE0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTQuNzAwMTQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43MDYxMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjcxMjEzNF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzE4MTMwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NC43MjQxMjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE0LjczMDEyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzM2MTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43NDIxMTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljc0ODEwNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQu
NzU0MTAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNC43NjAwOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljc2NjA5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzcyMDg3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43NzgwODRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljc4
NDA3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTQuNzkwMDc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNC43OTYwNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjgwMjA2NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODA4MDYwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44MTQw
NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE0LjgyMDA1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTQuODI2MDQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44MzIwNDFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjgzODAzN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODQ0MDMz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNC44NTAwMjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE0Ljg1NjAyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODYyMDE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44NjgwMTRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljg3NDAxMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuODgwMDA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC44ODYwMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljg5MTk5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODk3OTkxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45MDM5ODddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0
LjkwOTk4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuOTE1OTc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC45MjE5NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjkyNzk2OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTMzOTYzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45
Mzk5NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0Ljk0NTk1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuOTUxOTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45NTc5NDVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljk2Mzk0MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTY5
OTM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC45NzU5MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0Ljk4MTkyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTg3OTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45OTM5MjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljk5OTkx
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuMDA1OTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS4wMTE5MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjAxNzkwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDIzODk3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wMjk4OTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjAzNTg5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuMDQxODg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wNDc4ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjA1Mzg3N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDU5ODcyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS4wNjU4NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1LjA3MTg2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDc3ODU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wODM4NTNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjA4OTg0OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
MDk1ODQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS4xMDE4MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1LjEwNzgzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTEzODMwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4xMTk4MjVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjEy
NTgyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuMTMxODE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNS4xMzc4MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjE0MzgwNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTQ5ODAxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4xNTU3
OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1LjE2MTc5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuMTY3Nzg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4xNzM3ODNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjE3OTc3OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTg1Nzcz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS4xOTE3NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1LjE5Nzc2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjAzNzU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4yMDk3NTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjIxNTc1MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuMjIxNzQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS4yMjc3NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjIzMzczOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjM5NzM5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4yNDU3MzZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
LjI1MTczMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuMjU3NzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS4yNjM3MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjI2OTcxN10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjc1NzEyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4y
ODE3MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1LjI4NzcwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuMjkzNjk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4yOTk2OTNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjMwNTY4OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzEx
Njg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNS4zMTc2ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE1LjMyMzY3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzI5NjcwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zMzU2NjVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjM0MTY2
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuMzQ3NjU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS4zNTM2NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjM1OTY0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzY1NjQzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zNzE2Mzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjM3NzYzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuMzgzNjI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zODk2MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjM5NTYxOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDAxNjE1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS40MDc2MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1LjQxMzYwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDE5NjAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS40MjU1OTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQzMTU5MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
NDM3NTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS40NDM1ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQ0OTU3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDU1NTczXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS40NjE1NjldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQ2
NzU2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuNDczNTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNS40Nzk1NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQ4NTU1MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDkxNTQ2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS40OTc1
NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1LjUwMzUzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuNTA5NTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41MTU1MjddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjUyMTUyM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTI3NTE4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS41MzM1MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1LjUzOTUxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTQ1NTA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41NTE1MDNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjU1NzQ5OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuNTYzNDkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS41Njk0ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjU3NTQ4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTgxNDgwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41ODc0NzVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
LjU5MzQ3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuNTk5NDY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS42MDU0NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjYxMTQ1Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjE3NDUyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42
MjM0NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1LjYyOTQ0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuNjM1NDM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42NDE0MzNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjY0NzQyOF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjUz
NDI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNS42NTk0MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE1LjY2NTQxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjcxNDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42Nzc0MDZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjY4MzQw
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuNjg5Mzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS42OTUzOTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjcwMTM4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzA3MzgyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS43MTMzNzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjcxOTM3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuNzI1MzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS43MzEzNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjczNzM1OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzQzMzU0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS43NDkzNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1Ljc1NTM0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzYxMzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS43NjczMzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljc3MzMzMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
Nzc5MzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS43ODUzMjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljc5MTMxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzk3MzEyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44MDMzMDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljgw
OTMwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuODE1Mjk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNS44MjEyOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjgyNzI4OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODMzMjg0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44Mzky
NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1Ljg0NTI3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuODUxMjY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44NTcyNjZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljg2MzI2MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODY5MjU3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS44NzUyNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1Ljg4MTI0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODg3MjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44OTMyMzldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljg5OTIzM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuOTA1MjI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS45MTEyMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjkxNzIyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuOTIzMjE1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45MjkyMTFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
LjkzNTIwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuOTQxMjAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS45NDcxOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljk1MzE5Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuOTU5MTg3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45
NjUxODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1Ljk3MTE4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuOTc3MTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45ODMxNzJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljk4OTE2N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuOTk1
MTYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi4wMDExNThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2LjAwNzE1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDEzMTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wMTkxNDRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjAyNTE0
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuMDMxMTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi4wMzcxMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjA0MzEyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDQ5MTIyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wNTUxMTld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2LjA2MTExNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuMDY3MTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wNzMxMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjA3OTEwMV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDg1MDk2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni4wOTEwOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2LjA5NzA4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTAzMDgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xMDkwNzhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjExNTA3M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
MTIxMDY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi4xMjcwNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE2LjEzMzA1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTM5MDU0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xNDUwNTBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjE1
MTA0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTYuMTU3MDQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi4xNjMwMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjE2OTAzM10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTc1MDI4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xODEw
MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2LjE4NzAxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuMTkzMDE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xOTkwMDldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjIwNTAwNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjExMDAw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi4yMTY5OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2LjIyMjk5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjI4OTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yMzQ5ODJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjI0MDk3OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuMjQ2OTczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi4yNTI5NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjI1ODk2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjY0OTY1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yNzA5NjFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
LjI3Njk1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuMjgyOTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi4yODg5NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjI5NDk0M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzAwOTM4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4z
MDY5MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE2LjMxMjkyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTYuMzE4OTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4zMjQ5MjBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjMzMDkxNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzM2
OTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi4zNDI5MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2LjM0ODkwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzU0ODk2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4zNjA4OTJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjM2Njg4
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuMzcyODgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi4zNzg4NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjM4NDg3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzkwODY4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4zOTY4NjVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2LjQwMjg1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuNDA4ODU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40MTQ4NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQyMDg0Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDI2ODQxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni40MzI4MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2LjQzODgzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDQ0ODI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40NTA4MjJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQ1NjgxOV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
NDYyODEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi40Njg4MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQ3NDgwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDgwODAxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40ODY3OTZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQ5
Mjc5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTYuNDk4Nzg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi41MDQ3ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjUxMDc3OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTE2Nzc0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41MjI3
NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2LjUyODc2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuNTM0NzYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41NDA3NTVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjU0Njc1MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTUyNzQ2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi41NTg3NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2LjU2NDczOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTcwNzM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41NzY3MzJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjU4MjcyN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuNTg4NzIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi41OTQ3MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjYwMDcxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjA2NzA5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi42MTI3MDRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
LjYxODY5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuNjI0Njk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi42MzA2OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjYzNjY4Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjQyNjgxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi42
NDg2NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE2LjY1NDY3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTYuNjYwNjY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi42NjY2NjJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjY3MjY1OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjc4
NjUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi42ODQ2NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2LjY5MDY0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjk2NjM5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43MDI2MzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjcwODYz
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuNzE0NjI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi43MjA2MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjcyNjYxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzMyNjE0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43Mzg2MDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2Ljc0NDYwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuNzUwNjAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43NTY1OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljc2MjU5MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzY4NTg2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni43NzQ1ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2Ljc4MDU3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzg2NTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43OTI1NjhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljc5ODU2M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
ODA0NTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi44MTA1NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE2LjgxNjU0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODIyNTQ0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44Mjg1NDBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljgz
NDUzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTYuODQwNTMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi44NDY1MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljg1MjUyMV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODU4NTE2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44NjQ1
MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2Ljg3MDUwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuODc2NTAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44ODI0OTddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljg4ODQ5M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODk0NDg4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi45MDA0ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2LjkwNjQ3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTEyNDc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45MTg0NjldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjkyNDQ2Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuOTMwNDYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi45MzY0NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljk0MjQ1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTQ4NDQ3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45NTQ0NDJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
Ljk2MDQzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuOTY2NDMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi45NzI0MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljk3ODQyNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTg0NDE5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45
OTA0MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE2Ljk5NjQxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuMDAyNDA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wMDg0MDFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjAxNDM5Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDIw
MzkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy4wMjYzODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3LjAzMjM4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDM4Mzc3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wNDQzNzNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjA1MDM2
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuMDU2MzY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy4wNjIzNTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjA2ODM1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDc0MzUxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wODAzNDhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3LjA4NjM0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuMDkyMzM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wOTgzMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjEwNDMzMV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMTEwMzI2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny4xMTYzMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3LjEyMjMxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMTI4MzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4xMzQzMDddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE0MDMwM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcu
MTQ2Mjk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNy4xNTIyOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE1ODI4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMTY0Mjg1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4xNzAyNzldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE3
NjI3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuMTgyMjcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy4xODgyNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE5NDI2MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjAwMjU2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yMDYy
NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3LjIxMjI0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuMjE4MjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yMjQyMzhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjIzMDIzM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjM2MjI4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy4yNDIyMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3LjI0ODIxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjU0MjE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yNjAyMTBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjI2NjIwNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuMjcyMjAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy4yNzgxOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjI4NDE5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjkwMTkyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yOTYxODldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
LjMwMjE4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuMzA4MTgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9ODE5MiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNy4zMTQxNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjMyMDE3Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzI2MTcxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4z
MzIxNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE3LjMzODE2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuMzQ0MTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4zNTAxNTJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjM1NjE0OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzYy
MTQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy4zNjgxMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3LjM3NDEzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzgwMTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4zODYxMjVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjM5MjEy
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuMzk4MTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy40MDQxMTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQxMDEwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDE2MTAyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40MjIwOTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3LjQyODA5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuNDM0MDg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40NDAwODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQ0NjA3OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDUyMDc1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny40NTgwNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3LjQ2NDA2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDcwMDYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40NzYwNTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQ4MjA1MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcu
NDg4MDQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNy40OTQwNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3LjUwMDA0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTA2MDM1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41MTIwMzBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjUx
ODAyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuNTI0MDIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy41MzAwMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjUzNjAxMV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTQyMDA2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41NDgw
MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3LjU1Mzk5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuNTU5OTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41NjU5ODhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjU3MTk4NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTc3OTc5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy41ODM5NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3LjU4OTk3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTk1OTY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42MDE5NjJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjYwNzk1N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuNjEzOTUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy42MTk5NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjYyNTk0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNjMxOTQwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42Mzc5MzRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
LjY0MzkzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuNjQ5OTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNy42NTU5MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjY2MTkxNl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNjY3OTEyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42
NzM5MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE3LjY3OTkwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuNjg1ODk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42OTE4OTNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjY5Nzg4OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzAz
ODg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy43MDk4NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3LjcxNTg3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzIxODcwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43Mjc4NjVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjczMzg2
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuNzM5ODU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy43NDU4NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljc1MTg0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzU3ODQyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43NjM4Mzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3Ljc2OTgzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuNzc1ODI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43ODE4MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljc4NzgxOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzkzODE0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny43OTk4MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3LjgwNTgwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODExODAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44MTc3OTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjgyMzc5MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcu
ODI5Nzg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNy44MzU3ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljg0MTc3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODQ3NzczXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44NTM3NjhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljg1
OTc2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuODY1NzU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy44NzE3NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljg3Nzc0OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODgzNzQ1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44ODk3
NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3Ljg5NTczNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuOTAxNzMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45MDc3MjddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjkxMzcyMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTE5NzE3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy45MjU3MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3LjkzMTcwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTM3NzAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45NDM2OTldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljk0OTY5M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuOTU1Njg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy45NjE2ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljk2NzY4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTczNjc1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45Nzk2NzBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
Ljk4NTY2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuOTkxNjYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNy45OTc2NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjAwMzY1Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDA5NjQ3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4w
MTU2NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4LjAyMTYzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguMDI3NjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4wMzM2MjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjAzOTYyNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDQ1
NjE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC4wNTE2MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4LjA1NzYxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDYzNjA1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4wNjk2MDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjA3NTU5
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguMDgxNTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC4wODc1ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjA5MzU4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDk5NTgxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xMDU1NzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4LjExMTU3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguMTE3NTY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xMjM1NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjEyOTU1OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTM1NTU0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OC4xNDE1NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE4LjE0NzU0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTUzNTQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xNTk1MzZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjE2NTUzMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
MTcxNTI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC4xNzc1MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4LjE4MzUxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTg5NTEyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xOTU1MDhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjIw
MTUwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguMjA3NDk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC4yMTM0OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjIxOTQ5MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjI1NDg0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yMzE0
ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4LjIzNzQ3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguMjQzNDczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yNDk0NjhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjI1NTQ2NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjYxNDU5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC4yNjc0NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4LjI3MzQ0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjc5NDQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yODU0NDBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjI5MTQzNl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguMjk3NDMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC4zMDM0MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjMwOTQyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzE1NDI0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4zMjE0MTldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4
LjMyNzQxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTguMzMzNDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOC4zMzk0MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjM0NTQwMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzUxMzk3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4z
NTczOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4LjM2MzM4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguMzY5MzgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4zNzUzNzhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjM4MTM3M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzg3
MzY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC4zOTMzNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4LjM5OTM2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDA1MzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40MTEzNTBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQxNzM0
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguNDIzMzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC40MjkzMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQzNTMzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDQxMzI4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40NDczMjNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4LjQ1MzMxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguNDU5MzE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40NjUzMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQ3MTMwNF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDc3Mjk5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OC40ODMyOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE4LjQ4OTI5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDk1Mjg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41MDEyODFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjUwNzI3N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
NTEzMjcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC41MTkyNjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4LjUyNTI2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNTMxMjU5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41MzcyNTRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjU0
MzI0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguNTQ5MjQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC41NTUyNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjU2MTIzNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNTY3MjMwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41NzMy
MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4LjU3OTIyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguNTg1MjE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41OTEyMTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjU5NzIwN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjAzMjAz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC42MDkxOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4LjYxNTE5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjIxMTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC42MjcxODddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjYzMzE4Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguNjM5MTc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC42NDUxNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjY1MTE2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjU3MTYzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC42NjMxNTldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4
LjY2OTE1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTguNjc1MTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOC42ODExNDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjY4NzE0MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjkzMTM2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC42
OTkxMzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4LjcwNTEyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguNzExMTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43MTcxMTddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjcyMzExM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzI5
MTA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC43MzUxMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4Ljc0MTA5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzQ3MDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43NTMwOTBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljc1OTA4
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguNzY1MDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC43NzEwNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljc3NzA3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzgzMDY3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43ODkwNjJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4Ljc5NTA1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguODAxMDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44MDcwNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjgxMzA0NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODE5MDM5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OC44MjUwMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE4LjgzMTAzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODM3MDI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44NDMwMjFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljg0OTAxNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
ODU1MDExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC44NjEwMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljg2NzAwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODcyOTk3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44Nzg5OTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljg4
NDk4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguODkwOTgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC44OTY5NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjkwMjk3NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTA4OTY5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45MTQ5
NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4LjkyMDk1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguOTI2OTU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45MzI5NTFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjkzODk0N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTQ0OTQx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC45NTA5MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4Ljk1NjkzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTYyOTI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45Njg5MjNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljk3NDkxOF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguOTgwOTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC45ODY5MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljk5MjkwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTk4OTAzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wMDQ4OThdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5
LjAxMDg5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTkuMDE2ODg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOS4wMjI4ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjAyODg3OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDM0ODc1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4w
NDA4NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE5LjA0Njg2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTkuMDUyODYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wNTg4NTZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjA2NDg1MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDcw
ODQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOS4wNzY4NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE5LjA4MjgzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDg4ODMyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wOTQ4MjhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjEwMDgy
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTkuMTA2ODE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOS4xMTI4MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjExODgwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTI0ODA3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xMzA4MDNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE5LjEzNjc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTkuMTQyNzk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xNDg3ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjE1NDc4NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTYwNzgwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OS4xNjY3NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE5LjE3Mjc3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTc4NzY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xODQ3NjJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjE5MDc1OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTku
MTk2NzUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOS4yMDI3NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE5LjIwODc0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMjE0NzM5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4yMjA3MzRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjIy
NjczMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTkuMjMyNzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOS4yMzg3MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjI0NDcxNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMjUwNzEyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4yNTY3
MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE5LjI2MjcwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuMjY4Njk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4yNzQ2OTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjI4MDY4OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMjg2Njg0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS4yOTI2NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5LjI5ODY3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMzA0NjcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4zMTA2NjVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjMxNjY2MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTkuMzIyNjU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOS4zMjg2NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjMzNDY1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMzQwNjQ5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4zNDY2NDRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5
LjM1MjYzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTkuMzU4NjM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOS4zNjQ2MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjM3MDYyNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMzc2NjIwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4z
ODI2MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE5LjM4ODYxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTkuMzk0NjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS40MDA2MDFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjQwNjU5N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNDEy
NTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOS40MTg1ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE5LjQyNDU4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNDMwNTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS40MzY1NzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjQ0MjU2
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTkuNDQ4NTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOS40NTQ1NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjQ2MDU1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNDY2NTUxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS40NzI1NDZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE5LjQ3ODU0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTkuNDg0NTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS40OTA1MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjQ5NjUyN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNTAyNTIzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OS41MDg1MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE5LjUxNDUxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNTIwNTA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS41MjY1MDRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjUzMjQ5OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTku
NTM4NDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOS41NDQ0OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE5LjU1MDQ4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNTU2NDgxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS41NjI0NzddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjU2
ODQ3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTkuNTc0NDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOS41ODA0NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjU4NjQ1OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNTkyNDUzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS41OTg0
NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE5LjYwNDQ0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuNjEwNDQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42MTY0MzVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjYyMjQzMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjI4NDI1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS42MzQ0MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5LjY0MDQxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjQ2NDE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42NTI0MDhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjY1ODQwNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTkuNjY0Mzk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOS42NzAzOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjY3NjM5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjgyMzg2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42ODgzODFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5
LjY5NDM3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTkuNzAwMzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOS43MDYzNjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjcxMjM2Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzE4MzU4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43
MjQzNTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE5LjczMDM0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTkuNzM2MzQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43NDIzMzldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljc0ODMzNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzU0
MzMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOS43NjAzMjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE5Ljc2NjMyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzcyMzE5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43NzgzMTVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljc4NDMx
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTkuNzkwMzA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOS43OTYzMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjgwMjI5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODA4MjkyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44MTQyODhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE5LjgyMDI4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTkuODI2Mjc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44MzIyNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjgzODI3MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODQ0MjY1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OS44NTAyNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE5Ljg1NjI1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODYyMjUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44NjgyNDddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljg3NDI0Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTku
ODgwMjM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOS44ODYyMzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljg5MjIyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODk4MjIzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45MDQyMTldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljkx
MDIxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTkuOTE2MjA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOS45MjIyMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjkyODIwMF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTM0MTk1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45NDAx
OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE5Ljk0NjE4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuOTUyMTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45NTgxNzhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljk2NDE3M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTcwMTY4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS45NzYxNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5Ljk4MjE1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTg4MTU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45OTQxNTBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjAwMDE0NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjAuMDA2MTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMC4wMTIxMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjAxODEzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMDI0MTI2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4wMzAxMjJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIw
LjAzNjExN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjAuMDQyMTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMC4wNDgxMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjA1NDEwNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMDYwMDk5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4w
NjYwOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIwLjA3MjA5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjAuMDc4MDg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4wODQwODBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjA5MDA3Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMDk2
MDcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMC4xMDIwNjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIwLjEwODA2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTE0MDU3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xMjAwNTJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjEyNjA0
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjAuMTMyMDQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMC4xMzgwMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjE0NDAzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTUwMDMyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xNTYwMjhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIwLjE2MjAyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjAuMTY4MDE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xNzQwMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjE4MDAwOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTg2MDA0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MC4xOTE5OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIwLjE5Nzk5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjAzOTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yMDk5ODVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjIxNTk4MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAu
MjIxOTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMC4yMjc5NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIwLjIzMzk2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjM5OTYyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yNDU5NThdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjI1
MTk1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjAuMjU3OTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMC4yNjM5NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjI2OTkzOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjc1OTM0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yODE5
MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIwLjI4NzkyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjAuMjkzOTIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yOTk5MTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjMwNTkxMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzExOTA2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMC4zMTc5MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIwLjMyMzg5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzI5ODkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4zMzU4ODddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjM0MTg4M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjAuMzQ3ODg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMC4zNTM4ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjM1OTg3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzY1ODcxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4zNzE4NjVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIw
LjM3Nzg2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjAuMzgzODU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMC4zOTA3OTldIGk0MGUgMDAwMDowMTowMC4xOiBmdyA2LjAu
NDg0NDIgYXBpIDEuNyBudm0gNi4wMSAweDgwMDAzNDg1IDEuMTc0Ny4wIFs4MDg2OjE1ODldIFs4
MDg2OjAwMDBdClsgICAyMC42NzgzNTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT02
MTQ0MCBmbGFncz1jYzAgYXR0cj0wClsgICAyMC42ODQ0NDFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT02MTQ0MCBmbGFncz1jYzAgYXR0cj0wClsgICAyMC42OTA2MzZdIGk0MGUgMDAw
MDowMTowMC4xOiBNQUMgYWRkcmVzczogM2M6ZmQ6ZmU6NmI6ZTk6YzEKWyAgIDIwLjY5NjUyMl0g
aTQwZSAwMDAwOjAxOjAwLjE6IEZXIExMRFAgaXMgZW5hYmxlZApbICAgMjAuNzA3NjQ1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43
MTM2NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIwLjcxOTYzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjAuNzI1NjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43MzQzOTRdIGk0MGUgMDAwMDowMTowMC4x
OiBQQ0ktRXhwcmVzczogU3BlZWQgOC4wR1QvcyBXaWR0aCB4OApbICAgMjAuNzQxNjUyXSBpNDBl
IDAwMDA6MDE6MDAuMTogRmVhdHVyZXM6IFBGLWlkWzFdIFZTSXM6IDM0IFFQOiAzMiBSU1MgRkRf
QVRSIEZEX1NCIE5UVVBMRSBWeExBTiBHZW5ldmUgUFRQIFZFUEEKWyAgIDIwLjc1MTgyMl0gaTQw
ZSAwMDAwOjAxOjAwLjI6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAgMjAuNzY4
MTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMC43NzQxMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT04MTkyIGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIwLjc4MDEyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNzg2MTIxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43OTIxMThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjc5ODEx
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjAuODA0MTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMC44MTAxMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjgxNjEwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODIyMDk1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44MjgwOTFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIwLjgzNDA4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjAuODQwMDg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44NDYwODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjg1MjA3Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODU4MDcxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MC44NjQwNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIwLjg3MDA2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODc2MDU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44ODIwNTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjg4ODA0OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAu
ODk0MDQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMC45MDAwMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIwLjkwNjAzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTEyMDI5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45MTgwMjRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjky
NDAyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjAuOTMwMDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMC45MzYwMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjk0MjAwNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTQ4MDAxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45NTM5
OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIwLjk1OTk5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjAuOTY1OTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45NzE5ODNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjk3Nzk3OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTgzOTc0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMC45ODk5NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIwLjk5NTk2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDAxOTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4wMDc5NTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjAxMzk1M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuMDE5OTQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS4wMjU5NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjAzMTkzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDM3OTM0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4wNDM5MzBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
LjA0OTkyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuMDU1OTIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS4wNjE5MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjA2NzkxMl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDczOTA3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4w
Nzk5MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjA4NTg5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuMDkxODkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4wOTc4ODhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjEwMzg4M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTA5
ODc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS4xMTU4NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjEyMTg2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTI3ODY1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xMzM4NjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjEzOTg1
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuMTQ1ODUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS4xNTE4NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjE1Nzg0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTYzODM3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xNjk4MzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjE3NTgzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuMTgxODI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xODc4MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjE5MzgxN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTk5ODEzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS4yMDU4MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjIxMTgwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjE3Nzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4yMjM3OTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjIyOTc4OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
MjM1Nzg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS4yNDE3ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI0Nzc3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjUzNzcxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4yNTk3NjddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI2
NTc2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuMjcxNzU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS4yNzc3NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI4Mzc0OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjg5NzQ0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4yOTU3
NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjMwMTczNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjEuMzA3NzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zMTM3MjVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjMxOTcyMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzI1NzE2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMS4zMzE3MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIxLjMzNzcwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzQzNzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zNDk2OTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjM1NTY5M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuMzYxNjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS4zNjc2ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjM3MzY3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzc5Njc1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zODU2NzBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
LjM5MTY2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuMzk3NjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS40MDM2NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQwOTY1MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDE1NjQ2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40
MjE2NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjQyNzYzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuNDMzNjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40Mzk2MjhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQ0NTYyM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDUx
NjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS40NTc2MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjQ2MzYwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDY5NjA0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40NzU2MDBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQ4MTU5
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuNDg3NTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS40OTM1ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQ5OTU4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTA1NTc3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41MTE1NzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjUxNzU2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuNTIzNTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41Mjk1NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjUzNTU1NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTQxNTUwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS41NDc1NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjU1MzU0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTU5NTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41NjU1MzJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjU3MTUyN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
NTc3NTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS41ODM1MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjU4OTUxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTk1NTEyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42MDE1MDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjYw
NzUwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuNjEzNDk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS42MTk0OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjYyNTQ4OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjMxNDgzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42Mzc0
NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjY0MzQ3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjEuNjQ5NDcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42NTU0NjVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjY2MTQ2MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjY3NDU2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMS42NzM0NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIxLjY3OTQ0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjg1NDQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42OTE0MzldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjY5NzQzNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuNzAzNDMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS43MDk0MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjcxNTQyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNzIxNDE1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43Mjc0MTFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
LjczMzQwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuNzM5NDAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS43NDUzOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjc1MTM5M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNzU3Mzg4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43
NjMzODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjc2OTM3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuNzc1Mzc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43ODEzNzZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjc4NzM3M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNzkz
MzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS43OTkzNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjgwNTM1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODExMzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44MTczNTBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjgyMzM0
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuODI5MzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS44MzUzMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjg0MTMzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODQ3MzI3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44NTMzMjJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjg1OTMxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuODY1MzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44NzEzMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjg3NzMwM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODgzMjk5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS44ODkyOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjg5NTI4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTAxMjg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45MDcyODBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjkxMzI3NV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
OTE5MjcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS45MjUyNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjkzMTI2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTM3MjU2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45NDMyNTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjk0
OTI0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuOTU1MjQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS45NjEyMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjk2NzIzNF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTczMjI5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45Nzky
MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjk4NTIxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjEuOTkxMjE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45OTcyMTFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjAwMzIwOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDA5MjAz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi4wMTUxOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjAyMTE5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDI3MTg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4wMzMxODRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjAzOTE4MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuMDQ1MTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi4wNTExNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjA1NzE2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDYzMTYyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4wNjkxNThdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
LjA3NTE1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuMDgxMTQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi4wODcxNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjA5MzEzOV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDk5MTM1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4x
MDUxMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjExMTEyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuMTE3MTIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4xMjMxMTddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjEyOTExMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTM1
MTA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi4xNDExMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjE0NzA5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTUzMDkzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4xNTkwODhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjE2NTA4
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuMTcxMDc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi4xNzcwNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjE4MzA3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTg5MDY1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4xOTUwNjRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjIwMTA2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuMjA3MDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yMTMwNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjIxOTA0OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjI1MDQzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi4yMzEwMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjIzNzAzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjQzMDI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yNDkwMjRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjI1NTAyMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
MjYxMDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi4yNjcwMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjI3MzAwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjc5MDAxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yODQ5OTZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjI5
MDk5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuMjk2OTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi4zMDI5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjMwODk3N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzE0OTczXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zMjA5
NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIyLjMyNjk2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjIuMzMyOTU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zMzg5NTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjM0NDk0OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzUwOTQ3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi4zNTY5NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjM2MjkzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzY4OTMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zNzQ5MjldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjM4MDkyNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuMzg2OTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi4zOTI5MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjM5ODkxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDA0OTA2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40MTA5MDFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
LjQxNjg5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuNDIyODkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi40Mjg4ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjQzNDg4M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDQwODc3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40
NDY4NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjQ1Mjg2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuNDU4ODY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40NjQ4NjBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjQ3MDg1NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDc2
ODUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi40ODI4NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjQ4ODg0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDk0ODM3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41MDA4MzJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjUwNjgy
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuNTEyODIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi41MTg4MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjUyNDgxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTMwODA5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41MzY4MDRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjU0MjgwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuNTQ4Nzk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41NTQ3OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjU2MDc4Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTY2NzgyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi41NzI3NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjU3ODc3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTg0NzY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41OTA3NjNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjU5Njc1OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
NjAyNzUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi42MDg3NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjYxNDc0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNjIwNzQwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42MjY3MzZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjYz
MjczMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuNjM4NzI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi42NDQ3MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjY1MDcxN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNjU2NzEyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42NjI3
MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIyLjY2ODcwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjIuNjc0Njk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42ODA2OTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjY4NjY4OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNjkyNjg0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi42OTg2ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjcwNDY3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzEwNjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43MTY2NjhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjcyMjY2NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuNzI4NjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi43MzQ2NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjc0MDY1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzQ2NjQ1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43NTI2NDBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
Ljc1ODYzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuNzY0NjMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi43NzA2MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjc3NjYyMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzgyNjE3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43
ODg2MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjc5NDYwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuODAwNjA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44MDY2MDVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjgxMjYwMV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODE4
NTk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi44MjQ1OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjgzMDU4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODM2NTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44NDI1NzhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjg0ODU3
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuODU0NTY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi44NjA1NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjg2NjU1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODcyNTU0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44Nzg1NTBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjg4NDU0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuODkwNTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44OTY1MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjkwMjUzMl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTA4NTI2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi45MTQ1MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjkyMDUxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTI2NTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi45MzI1MDhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjkzODUwM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
OTQ0NDk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi45NTA0OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk1NjQ4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTYyNDg0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi45Njg0NzldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk3
NDQ3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuOTgwNDcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi45ODY0NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk5MjQ2MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTk4NDU3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wMDQ0
NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjAxMDQ0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuMDE2NDQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wMjI0NDBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjAyODQzNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDM0NDMx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy4wNDA0MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjA0NjQyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDUyNDE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wNTg0MTJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjA2NDQwN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuMDcwNDAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy4wNzYzOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjA4MjM5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDg4Mzg5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wOTQzODVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
LjEwMDM3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuMTA2Mzc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy4xMTIzNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjExODM2OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTI0MzYzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4x
MzAzNTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjEzNjM1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuMTQyMzUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4xNDgzNDVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjE1NDM0MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTYw
MzM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy4xNjYzMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjE3MjMyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTc4MzIyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4xODQzMTddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjE5MDMx
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuMTk2MzA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy4yMDIzMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjIwODI5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjE0Mjk1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yMjAyOTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjIyNjI4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuMjMyMjg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yMzgyODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjI0NDI3NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjUwMjcwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My4yNTYyNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjI2MjI2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjY4MjU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yNzQyNTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjI4MDI0Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
Mjg2MjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy4yOTIyMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjI5ODIzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzA0MjI3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zMTAyMjNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjMx
NjIxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjMuMzIyMjE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMy4zMjgyMDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjMzNDIwNF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzQwMTk5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zNDYx
OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjM1MjE5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuMzU4MTg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zNjQxODBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjM3MDE3Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzc2MTcy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy4zODIxNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjM4ODE2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzk0MTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40MDAxNTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQwNjE1MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuNDEyMTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy40MTgxNDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQyNDEzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNDMwMTMzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40MzYxMjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
LjQ0MjEyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuNDQ4MTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy40NTQxMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQ2MDEwOV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNDY2MTA1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40
NzIxMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjQ3ODA5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuNDg0MDkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40OTAwODddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQ5NjA4Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTAy
MDc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy41MDgwNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjUxNDA2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTIwMDYzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41MjYwNThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjUzMjA1
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuNTM4MDQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy41NDQwNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjU1MDA0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTU2MDM1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41NjIwMzBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjU2ODAyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuNTc0MDIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41ODAwMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjU4NjAxMV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTkyMDA2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My41OTgwMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjYwMzk5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjA5OTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42MTU5ODddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjYyMTk4M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
NjI3OTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy42MzM5NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjYzOTk2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjQ1OTY1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42NTE5NjBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjY1
Nzk1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjMuNjYzOTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMy42Njk5NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjY3NTk0MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjgxOTM3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42ODc5
MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjY5MzkyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuNjk5OTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43MDU5MTldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjcxMTkxNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzE3OTA5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy43MjM5MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjcyOTkwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzM1ODk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43NDE4OTNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjc0Nzg4OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuNzUzODg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy43NTk4NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjc2NTg3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzcxODY5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43Nzc4NjVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
Ljc4Mzg2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuNzg5ODU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy43OTU4NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjgwMTg0Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODA3ODQxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44
MTM4MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjgxOTgzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuODI1ODM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44MzE4MzBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjgzNzgyNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODQz
ODIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy44NDk4MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT04MTkyIGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjg1NTgxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTgxOTIgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODYxODExXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44Njc4MDVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjg3Mzgw
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuODc5ODAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy44ODU3OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjg5MTc5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODk3Nzg3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45MDM3ODJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjkwOTc3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuOTE1NzczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45MjE3NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjkyNzc2NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTMzNzU5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My45Mzk3NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjk0NTc1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTUxNzQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45NTc3NDFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjk2MzczNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
OTY5NzMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy45NzU3MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjk4MTcyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTg3NzE3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45OTM3MTNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjk5
OTcwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuMDA1NzAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC4wMTE2OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjAxNzY5NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDIzNjg5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wMjk2
ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjAzNTY4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuMDQxNjc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wNDc2NzFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjA1MzY2N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDU5NjYy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC4wNjU2NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0LjA3MTY1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDc3NjQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wODM2NDNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjA4OTYzOV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuMDk1NjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC4xMDE2MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjEwNzYyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTEzNjIwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4xMTk2MTZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjEyNTYxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuMTMxNjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC4xMzc2MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjE0MzU5N10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTQ5NTkyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4x
NTU1ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0LjE2MTU4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuMTY3NTc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4xNzM1NzRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjE3OTU2OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTg1
NTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC4xOTE1NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0LjE5NzU1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjAzNTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yMDk1NDVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjIxNTU0
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuMjIxNTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC4yMjc1MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjIzMzUyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjM5NTI0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yNDU1MjFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0LjI1MTUxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuMjU3NTEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yNjM1MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjI2OTUwMl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjc1NDk3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC4yODE0OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0LjI4NzQ4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjkzNDg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yOTk0NzldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjMwNTQ3NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQu
MzExNDY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNC4zMTc0NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI0LjMyMzQ2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMzI5NDU2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zMzU0NTFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjM0
MTQ0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuMzQ3NDQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC4zNTM0MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjM1OTQzMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMzY1NDI4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zNzE0
MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjM3NzQxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuMzgzNDEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zODk0MDldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjM5NTQwNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDAxNDAw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC40MDczOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0LjQxMzM5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDE5Mzg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40MjUzODFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQzMTM3Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuNDM3MzcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC40NDMzNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQ0OTM2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDU1MzU4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40NjEzNTRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjQ2NzM0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuNDczMzQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC40NzkzNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQ4NTMzNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDkxMzMwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40
OTczMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0LjUwMzMyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuNTA5MzE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41MTUzMTJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjUyMTMwOF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTI3
MzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC41MzMyOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0LjUzOTI5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTQ1Mjg5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41NTEyODRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjU1NzI4
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuNTYzMjc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC41NjkyNzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjU3NTI2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTgxMjYxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41ODcyNTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0LjU5MzI1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuNTk5MjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42MDUyNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjYxMTIzOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjE3MjM0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC42MjMyMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0LjYyOTIyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjM1MjIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42NDEyMTldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY0NzIxNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQu
NjUzMjEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNC42NTkyMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY2NTIwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjcxMTk2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42NzcxOTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY4
MzE4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuNjg5MTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC42OTUxNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjcwMTE3M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzA3MTY4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43MTMx
NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjcxOTE1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuNzI1MTU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43MzExNDldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjczNzE0Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzQzMTQw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC43NDkxMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0Ljc1NTEzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzYxMTI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43NjcxMjRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljc3MzEyMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuNzc5MTE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC43ODUxMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljc5MTEwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzk3MTAyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44MDMwOTddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjgwOTA5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuODE1MDg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC44MjEwODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjgyNzA3OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODMzMDc0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44
MzkwNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0Ljg0NTA3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuODUxMDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44NTcwNjNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljg2MzA1OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODY5
MDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC44NzUwNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0Ljg4MTA0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODg3MDM5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44OTMwMzVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljg5OTAz
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuOTA1MDI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC45MTEwMjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjkxNzAxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTIzMDExXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45MjkwMDdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0LjkzNTAwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuOTQwOTk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45NDY5OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljk1Mjk4OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTU4OTg0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC45NjQ5ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0Ljk3MDk3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTc2OTcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45ODI5NjZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljk4ODk2Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQu
OTk0OTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS4wMDA5NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjAwNjk0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDEyOTQ0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wMTg5MzldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjAy
NDkzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuMDMwOTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS4wMzY5MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjA0MjkyMV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDQ4OTE2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wNTQ5
MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1LjA2MDkwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuMDY2OTAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wNzI4OThdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjA3ODg5M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDg0ODg5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNS4wOTA4ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI1LjA5Njg4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTAyODc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4xMDg4NzBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjExNDg2NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjUuMTIwODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNS4xMjY4NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjEzMjg1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTM4ODQ3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4xNDQ4NDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1
LjE1MDgzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjUuMTU2ODM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNS4xNjI4MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjE2ODgyNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTc0ODIwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4x
ODA4MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI1LjE4NjgxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjUuMTkyODA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4xOTg4MDFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjIwNDc5N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjEw
NzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNS4yMTY3ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI1LjIyMjc4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjI4Nzc5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yMzQ3NzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjI0MDc3
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjUuMjQ2NzY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNS4yNTI3NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjI1ODc1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjY0NzUzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yNzA3NDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI1LjI3Njc0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjUuMjgyNzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yODg3MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjI5NDczMF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzAwNzI2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NS4zMDY3MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI1LjMxMjcxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzE4NzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zMjQ3MDhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjMzMDcwM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUu
MzM2Njk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS4zNDI2OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM0ODY4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzU0Njg1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zNjA2ODBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM2
NjY3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuMzcyNjcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS4zNzg2NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM4NDY2NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzkwNjU4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zOTY2
NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1LjQwMjY0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuNDA4NjQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40MTQ2MzldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQyMDYzNV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDI2NjMw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNS40MzI2MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI1LjQzODYyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDQ0NjE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40NTA2MTJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQ1NjYwOF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjUuNDYyNjAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNS40Njg1OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQ3NDU5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDgwNTkwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40ODY1ODVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1
LjQ5MjU4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjUuNDk4NTc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNS41MDQ1NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjUxMDU2Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTE2NTYxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41
MjI1NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI1LjUyODU1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjUuNTM0NTQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41NDA1NDNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjU0NjUzOV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTUy
NTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNS41NTg1MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI1LjU2NDUyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTcwNTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41NzY1MTVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjU4MjUx
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjUuNTg4NTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNS41OTQ1MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjYwMDQ5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjA2NDkxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42MTI0ODdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI1LjYxODQ4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjUuNjI0NDc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42MzA0NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjYzNjQ2OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjQyNDY0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NS42NDg0NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI1LjY1NDQ1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjYwNDUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42NjY0NDVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjY3MjQ0Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUu
Njc4NDM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS42ODQ0MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjY5MDQyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjk2NDIzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43MDI0MThdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljcw
ODQxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuNzE0NDA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS43MjA0MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjcyNjM5OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNzMyMzk1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43Mzgz
OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1Ljc0NDM4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuNzUwMzgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43NTYzNzddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljc2MjM3Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNzY4MzY3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNS43NzQzNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI1Ljc4MDM2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNzg2MzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43OTIzNTJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljc5ODM0N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjUuODA0MzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNS44MTAzMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjgxNjMzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuODIyMzI4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS44MjgzMjRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1
LjgzNDMxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjUuODQwMzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNS44NDYzMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljg1MjMwNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuODU4MzAwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS44
NjQzMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI1Ljg3MDI5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjUuODc2MjkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS44ODIyODhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljg4ODI4M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuODk0
Mjc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNS45MDAyNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI1LjkwNjI2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuOTEyMjY1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS45MTgyNjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjkyNDI1
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjUuOTMwMjUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNS45MzYyNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljk0MjI0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuOTQ4MjM2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS45NTQyMzFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI1Ljk2MDIyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjUuOTY2MjIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS45NzIyMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljk3ODIxM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuOTg0MjA5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NS45OTAyMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI1Ljk5NjIwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMDAyMTk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wMDgxOTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjAxNDE4Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
MDIwMTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi4wMjYxNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2LjAzMjE3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMDM4MTY4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wNDQxNjRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjA1
MDE1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuMDU2MTU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi4wNjIxNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjA2ODE0NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMDc0MTQwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wODAx
MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2LjA4NjEzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuMDkyMTI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wOTgxMjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjEwNDExOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMTEwMTEz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi4xMTYxMDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjEyMjEwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMTI4MDk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4xMzQwOTRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjE0MDA5Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuMTQ2MDg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi4xNTIwODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjE1ODA3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMTY0MDczXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4xNzAwNjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2
LjE3NjA2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjYuMTgyMDU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNi4xODgwNTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjE5NDA0OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjAwMDQ1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4y
MDYwNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI2LjIxMjAzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjYuMjE4MDMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4yMjQwMjddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjIzMDAyMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjM2
MDE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNi4yNDIwMTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI2LjI0ODAwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjU0MDAzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4yNTk5OThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjI2NTk5
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjYuMjcxOTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNi4yNzc5ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjI4Mzk4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjg5OTc3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4yOTU5NzRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI2LjMwMTk2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjYuMzA3OTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zMTM5NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjMxOTk1NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzI1OTUwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ni4zMzE5NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI2LjMzNzk0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzQzOTM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zNDk5MzFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjM1NTkyN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
MzYxOTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi4zNjc5MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2LjM3MzkxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzc5OTA4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zODU5MDNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjM5
MTg5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuMzk3ODk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi40MDM4OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQwOTg4NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDE1ODgxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40MjE4
NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2LjQyNzg3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuNDMzODY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40Mzk4NjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQ0NTg1N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDUxODUz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi40NTc4NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjQ2Mzg0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDY5ODM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40NzU4MzRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQ4MTgyOV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuNDg3ODI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi40OTM4MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQ5OTgxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTA1ODEyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41MTE4MDhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2
LjUxNzgwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjYuNTIzNzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNi41Mjk3OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjUzNTc4OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTQxNzg0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41
NDc3NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI2LjU1Mzc3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjYuNTU5NzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41NjU3NjVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjU3MTc2MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTc3
NzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNi41ODM3NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI2LjU4OTc0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTk1NzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42MDE3MzhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjYwNzcz
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjYuNjEzNzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNi42MTk3MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjYyNTcxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjMxNzE1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42Mzc3MDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI2LjY0MzcwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjYuNjQ5NzAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42NTU2OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjY2MTY5MV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjY3Njg2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ni42NzM2ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI2LjY3OTY3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjg1NjcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42OTE2NjhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjY5NzY2M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
NzAzNjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi43MDk2NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2LjcxNTY1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNzIxNjQ2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43Mjc2NDFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljcz
MzYzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuNzM5NjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi43NDU2MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljc1MTYyM10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNzU3NjE5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43NjM2
MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2Ljc2OTYwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuNzc1NjA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43ODE2MDBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljc4NzU5Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNzkzNTkx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi43OTk1ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjgwNTU4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODExNTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi44MTc1NzRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjgyMzU3MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuODI5NTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi44MzU1NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljg0MTU1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODQ3NTUyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi44NTM1NDZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2
Ljg1OTU0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjYuODY1NTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNi44NzE1MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljg3NzUyOF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODgzNTI5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi44
ODk1MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI2Ljg5NTUyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjYuOTAxNTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi45MDc1MTRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjkxMzUwOV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuOTE5
NTA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNi45MjU1MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI2LjkzMjQ0OF0gaTQwZSAwMDAwOjAxOjAwLjI6IGZ3IDYuMC40ODQ0
MiBhcGkgMS43IG52bSA2LjAxIDB4ODAwMDM0ODUgMS4xNzQ3LjAgWzgwODY6MTU4OV0gWzgwODY6
MDAwMF0KWyAgIDI3LjIyMDM0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTYxNDQw
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjIyNjQyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTYxNDQwIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjIzMjYxOF0gaTQwZSAwMDAwOjAx
OjAwLjI6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMgpbICAgMjcuMjM4NTA0XSBpNDBl
IDAwMDA6MDE6MDAuMjogRlcgTExEUCBpcyBlbmFibGVkClsgICAyNy4yNDk2NDldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjI1NTY0
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuMjYxNjQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy4yNjc2NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjI3NTkzOV0gaTQwZSAwMDAwOjAxOjAwLjI6IFBD
SS1FeHByZXNzOiBTcGVlZCA4LjBHVC9zIFdpZHRoIHg4ClsgICAyNy4yODMxOTddIGk0MGUgMDAw
MDowMTowMC4yOiBGZWF0dXJlczogUEYtaWRbMl0gVlNJczogMzQgUVA6IDMyIFJTUyBGRF9BVFIg
RkRfU0IgTlRVUExFIFZ4TEFOIEdlbmV2ZSBQVFAgVkVQQQpbICAgMjcuMjkzMzY3XSBpNDBlIDAw
MDA6MDE6MDAuMzogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAyNy4zMTA0MjFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI3LjMxNjQyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTgxOTIgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjcuMzIyNDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4zMjg0MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjMzNDQxM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMzQwNDA5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ny4zNDY0MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI3LjM1MjQwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMzU4Mzk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4zNjQzOTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjM3MDM4OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcu
Mzc2MzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNy4zODIzNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI3LjM4ODM3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMzk0MzcwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40MDAzNjVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQw
NjM2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjcuNDEyMzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNy40MTgzNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQyNDM0Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDMwMzQyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40MzYz
MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI3LjQ0MjMzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjcuNDQ4MzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40NTQzMjNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQ2MDMxOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDY2MzE0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNy40NzIzMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI3LjQ3ODMwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDg0Mjk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40OTAyOTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQ5NjI5MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjcuNTAyMjg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNy41MDgyODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjUxNDI3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTIwMjczXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41MjYyNjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3
LjUzMjI2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjcuNTM4MjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNy41NDQyNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjU1MDI1MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTU2MjQ1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41
NjIyNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI3LjU2ODIzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjcuNTc0MjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41ODAyMjddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjU4NjIyMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTky
MjE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNy41OTgyMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI3LjYwNDIwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjEwMjA0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42MTYxOTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjYyMjE5
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuNjI4MTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy42MzQxODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjY0MDE4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjQ2MTc3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42NTIxNzJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI3LjY1ODE2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjcuNjY0MTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42NzAxNThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjY3NjE1M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjgyMTQ5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ny42ODgxNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI3LjY5NDE0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzAwMTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43MDYxMzFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjcxMjEyNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcu
NzE4MTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNy43MjQxMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI3LjczMDExM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzM2MTA4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43NDIxMDRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljc0
ODA5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjcuNzU0MDk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNy43NjAwODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljc2NjA4NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzcyMDgwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43Nzgw
NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI3Ljc4NDA3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjcuNzkwMDY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43OTYwNjFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjgwMjA1N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODA4MDUy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNy44MTQwNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI3LjgyMDA0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODI2MDQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy44MzIwMzZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjgzODAzMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjcuODQ0MDI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNy44NTAwMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljg1NjAxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODYyMDEzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy44NjgwMDhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3
Ljg3NDAwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjcuODc5OTk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNy44ODU5OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljg5MTk5MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODk3OTg2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45
MDM5ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI3LjkwOTk3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjcuOTE1OTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45MjE5NjddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjkyNzk2Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTMz
OTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNy45Mzk5NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI3Ljk0NTk0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTUxOTQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45NTc5NDBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljk2Mzkz
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuOTY5OTMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy45NzU5MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljk4MTkyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTg3OTIyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45OTM5MThd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI3Ljk5OTkxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguMDA1OTA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4wMTE5MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjAxNzg5OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDIzODkzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC4wMjk4ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4LjAzNTg4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDQxODgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4wNDc4NzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjA1Mzg3MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
MDU5ODY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC4wNjU4NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4LjA3MTg1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDc3ODUxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4wODM4NDZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjA4
OTg0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguMDk1ODM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC4xMDE4MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjEwNzgyN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTEzODIzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xMTk4
MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4LjEyNTgxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguMTMxODEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xMzc4MDZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjE0MzgwMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTQ5Nzk2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOC4xNTU3OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI4LjE2MTc4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTY3NzgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xNzM3NzhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjE3OTc3M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguMTg1NzY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC4xOTE3NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjE5Nzc1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjAzNzU0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yMDk3NTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
LjIxNTc0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguMjIxNzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC4yMjc3MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjIzMzczMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjM5NzI2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4y
NDU3MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4LjI1MTcxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguMjU3NzEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yNjM3MDhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjI2OTcwM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjc1
Njk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC4yODE2OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4LjI4NzY4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjkzNjg1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yOTk2NzldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjMwNTY3
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjguMzExNjcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOC4zMTc2NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjMyMzY2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzI5NjY0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4zMzU2NjBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI4LjM0MTY1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguMzQ3NjUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4zNTM2NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjM1OTY0M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzY1NjM5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC4zNzE2MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4LjM3NzYzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzgzNjI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4zODk2MjBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjM5NTYxNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
NDAxNjEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC40MDc2MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQxMzYwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDE5NTk3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40MjU1OTNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQz
MTU4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguNDM3NTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC40NDM1NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQ0OTU3NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDU1NTcwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40NjE1
NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4LjQ2NzU2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguNDczNTU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40Nzk1NTFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQ4NTU0N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDkxNTQy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOC40OTc1MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI4LjUwMzUzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTA5NTI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC41MTU1MjNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjUyMTUxOV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguNTI3NTE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC41MzM1MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjUzOTUwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTQ1NTAyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC41NTE0OTddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
LjU1NzQ5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguNTYzNDg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC41Njk0ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjU3NTQ3OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTgxNDc1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC41
ODc0NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4LjU5MzQ2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguNTk5NDYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42MDU0NTZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjYxMTQ1MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjE3
NDQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC42MjM0NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4LjYyOTQzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjM1NDMzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42NDE0MjldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjY0NzQy
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjguNjUzNDIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOC42NTk0MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjY2NTQxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjcxNDA1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42Nzc0MDFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI4LjY4MzM5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguNjg5MzkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42OTUzODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjcwMTM4M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzA3Mzc4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC43MTMzNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4LjcxOTM2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzI1MzY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC43MzEzNTldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjczNzM1OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
NzQzMzUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC43NDkzNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljc1NTM0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzYxMzQwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC43NjczMzVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljc3
MzMzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguNzc5MzI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC43ODUzMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljc5MTMxN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzk3MzEyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44MDMz
MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4LjgwOTMwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguODE1Mjk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44MjEyOTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjgyNzI4OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODMzMjg0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOC44MzkyNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI4Ljg0NTI3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODUxMjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44NTcyNjldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljg2MzI2NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguODY5MjYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC44NzUyNTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljg4MTI1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODg3MjQ2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44OTMyNDJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
Ljg5OTIzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguOTA1MjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC45MTEyMjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjkxNzIyM10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTIzMjE4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45
MjkyMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4LjkzNTIwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguOTQxMjA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45NDcyMDBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljk1MzE5Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTU5
MTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC45NjUxODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4Ljk3MTE4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTc3MTc4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45ODMxNzNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljk4OTE2
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjguOTk1MTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS4wMDExNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjAwNzE1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDEzMTUyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wMTkxNDdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5LjAyNTE0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuMDMxMTM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wMzcxMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjA0MzEyOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDQ5MTI1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS4wNTUxMjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5LjA2MTExNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDY3MTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wNzMxMDddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjA3OTEwMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
MDg1MDk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS4wOTEwOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5LjA5NzA4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTAzMDgzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xMDkwNzldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjEx
NTA3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuMTIxMDcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS4xMjcwNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjEzMzA2MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTM5MDU2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xNDUw
NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5LjE1MTA0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjkuMTU3MDQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xNjMwMzhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjE2OTAzNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTc1MDI5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS4xODEwMjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5LjE4NzAyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTkzMDE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xOTkwMTJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjIwNTAwN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuMjExMDAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS4yMTY5OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjIyMjk5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMjI4OTg4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4yMzQ5ODNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
LjI0MDk3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuMjQ2OTc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS4yNTI5NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjI1ODk2NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMjY0OTYwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4y
NzA5NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5LjI3Njk1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuMjgyOTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4yODg5NDJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjI5NDkzN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzAw
OTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOS4zMDY5MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI5LjMxMjkyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzE4OTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zMjQ5MTVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjMzMDkx
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjkuMzM2OTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS4zNDI5MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjM0ODkwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzU0ODk4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zNjA4OTZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5LjM2Njg5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuMzcyODg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zNzg4ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjM4NDg3OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzkwODc0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS4zOTY4NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5LjQwMjg2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDA4ODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS40MTQ4NTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQyMDg1MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
NDI2ODQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS40MzI4NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQzODgzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDQ0ODMyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS40NTA4MjddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQ1
NjgyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuNDYyODE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS40Njg4MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQ3NDgwOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDgwODA0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS40ODY4
MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5LjQ5Mjc5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjkuNDk4NzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41MDQ3ODldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjUxMDc4NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTE2Nzgw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS41MjI3NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5LjUyODc3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTM0NzY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41NDA3NjFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjU0Njc1Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuNTUyNzUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS41NTg3NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjU2NDc0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTcwNzM4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41NzY3MzVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
LjU4MjcyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuNTg4NzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS41OTQ3MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjYwMDcxNl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjA2NzExXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42
MTI3MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5LjYxODcwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuNjI0Njk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42MzA2OTJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjYzNjY4N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjQy
NjgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOS42NDg2NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI5LjY1NDY3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjYwNjY5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42NjY2NjRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjY3MjY2
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjkuNjc4NjU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS42ODQ2NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjY5MDY0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjk2NjQxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43MDI2MzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5LjcwODYzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuNzE0NjI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43MjA2MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjcyNjYxOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNzMyNjEzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS43Mzg2MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5Ljc0NDYwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNzUwNTk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43NTY1OTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljc2MjU5MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
NzY4NTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS43NzQ1ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljc4MDU3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNzg2NTcxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43OTI1NjhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljc5
ODU2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuODA0NTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS44MTA1NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjgxNjU0OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODIyNTQ0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44Mjg1
MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5LjgzNDUzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjkuODQwNTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44NDY1MjVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljg1MjUyMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODU4NTE2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS44NjQ1MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5Ljg3MDUwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODc2NTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44ODI1MDBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljg4ODQ5Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuODk0NDkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS45MDA0ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjkwNjQ4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuOTEyNDc4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45MTg0NzNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
LjkyNDQ2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuOTMwNDYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS45MzY0NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljk0MjQ1NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuOTQ4NDQ5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45
NTQ0NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5Ljk2MDQ0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuOTY2NDM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45NzI0MzJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljk3ODQyN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuOTg0
NDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOS45OTA0MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI5Ljk5NjQxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDAyNDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wMDg0MDVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjAxNDQw
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuMDIwMzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC4wMjYzOTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjAzMjM4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDM4MzgyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wNDQzNzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjA1MDM3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuMDU2MzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wNjIzNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjA2ODM1OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDc0MzU0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC4wODAzNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjA4NjM0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDkyMzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wOTgzMzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjEwNDMzMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
MTEwMzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC4xMTYzMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjEyMjMxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMTI4MzEyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4xMzQzMDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjE0
MDMwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuMTQ2Mjk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC4xNTIyOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjE1ODI4OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMTY0Mjg1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4xNzAy
NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMwLjE3NjI3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuMTgyMjcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4xODgyNjZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjE5NDI2MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjAwMjU3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC4yMDYyNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjIxMjI0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjE4MjQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yMjQyMzhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjIzMDIzM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuMjM2MjI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC4yNDIyMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjI0ODIyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjU0MjE4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yNjAyMTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
LjI2NjIwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuMjcyMjA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC4yNzgxOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjI4NDE5NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjkwMTkwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4y
OTYxODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMwLjMwMjE4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzAuMzA4MTc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4zMTQxNzNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjMyMDE2OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzI2
MTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMC4zMzIxNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMwLjMzODE1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzQ0MTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4zNTAxNDZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjM1NjE0
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuMzYyMTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC4zNjgxMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjM3NDEzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzgwMTMwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4zODYxMjZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjM5MjEyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTgxOTIgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuMzk4MTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9ODE5
MiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40MDQxMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQxMDExM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDE2MTA4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC40MjIxMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjQyODA5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDM0MDk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40NDAwODldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQ0NjA4NV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
NDUyMDgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC40NTgwNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQ2NDA3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDcwMDY2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40NzYwNjJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQ4
MjA1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuNDg4MDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC40OTQwNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjUwMDA0NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTA2MDM5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41MTIw
MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMwLjUxODAyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuNTI0MDI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41MzAwMjFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjUzNjAxNl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTQyMDEx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC41NDgwMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjU1NDAwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTU5OTk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41NjU5OTNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjU3MTk4OV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuNTc3OTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC41ODM5ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjU4OTk3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTk1OTcxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42MDE5NjZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
LjYwNzk2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuNjEzOTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC42MTk5NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjYyNTk0OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNjMxOTQ0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42
Mzc5MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMwLjY0MzkzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzAuNjQ5OTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42NTU5MjVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjY2MTkyMF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNjY3
OTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMC42NzM5MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMwLjY3OTkwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNjg1OTAxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42OTE4OTddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjY5Nzg5
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuNzAzODg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC43MDk4ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjcxNTg3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzIxODczXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43Mjc4Njld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjczMzg2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuNzM5ODYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43NDU4NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjc1MTg1MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzU3ODQ2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC43NjM4NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjc2OTgzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzc1ODMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43ODE4MjddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjc4NzgyM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
NzkzODE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC43OTk4MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjgwNTgwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuODExODA0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44MTc3OTldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjgy
Mzc5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuODI5NzkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC44MzU3ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjg0MTc4MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuODQ3Nzc3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44NTM3
NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMwLjg1OTc2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuODY1NzYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44NzE3NThdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjg3Nzc1M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuODgzNzQ4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC44ODk3NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjg5NTc0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTAxNzM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45MDc3MzJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjkxMzcyN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuOTE5NzIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC45MjU3MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjkzMTcxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTM3NzA4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45NDM3MDRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
Ljk0OTY5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuOTU1Njk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC45NjE2OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjk2NzY4Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTczNjgxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45
Nzk2NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMwLjk4NTY3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzAuOTkxNjY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45OTc2NjRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjAwMzY2MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDA5
NjU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS4wMTU2NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjAyMTY0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDI3NjQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wMzM2MzhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjAzOTYz
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuMDQ1NjI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS4wNTE2MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjA1NzYyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDYzNjE2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wNjk2MTFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjA3NTYwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuMDgxNjAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wODc1OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjA5MzU5Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDk5NTg4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS4xMDU1ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjExMTU3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTE3NTczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xMjM1NjldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjEyOTU2NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
MTM1NTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS4xNDE1NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjE0NzU1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTUzNTQ1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xNTk1NDFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjE2
NTUzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzEuMTcxNTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMS4xNzc1MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjE4MzUyM10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTg5NTE4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xOTU1
MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjIwMTUwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuMjA3NTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yMTM0OTldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjIxOTQ5NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjI1NDg5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS4yMzE0ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjIzNzQ4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjQzNDc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yNDk0NzBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjI1NTQ2Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuMjYxNDYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS4yNjc0NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjI3MzQ1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjc5NDQ3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yODU0NDJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
LjI5MTQzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuMjk3NDMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMS4zMDM0MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjMwOTQyM10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzE1NDE5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4z
MjE0MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMxLjMyNzQxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzEuMzMzNDA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4zMzk0MDFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjM0NTM5Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzUx
MzkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS4zNTczODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjM2MzM4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzY5Mzc4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4zNzUzNzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjM4MTM2
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuMzg3MzcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS4zOTMzNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjM5OTM2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDA1MzU4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40MTEzNTZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjQxNzM1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuNDIzMzQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40MjkzNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQzNTMzOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDQxMzMzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS40NDczMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjQ1MzMyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDU5MzIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40NjUzMTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQ3MTMxMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
NDc3MzA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS40ODMzMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQ4OTI5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDk1MjkyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41MDEyODddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjUw
NzI4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzEuNTEzMjc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMS41MTkyNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjUyNTI2OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTMxMjY1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41Mzcy
NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjU0MzI1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuNTQ5MjUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41NTUyNDZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjU2MTI0MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTY3MjM2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS41NzMyMzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjU3OTIyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTg1MjIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41OTEyMThdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjU5NzIxM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuNjAzMjA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS42MDkyMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjYxNTE5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjIxMTk1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42MjcxOTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
LjYzMzE4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuNjM5MTgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMS42NDUxNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjY1MTE3Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjU3MTY2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42
NjMxNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMxLjY2OTE1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzEuNjc1MTUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42ODExNDhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjY4NzE0NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjkz
MTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS42OTkxMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjcwNTEzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzExMTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43MTcxMjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjcyMzEx
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuNzI5MTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS43MzUxMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjc0MTEwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzQ3MDk4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43NTMwOTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjc1OTA4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuNzY1MDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43NzEwODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjc3NzA3OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzgzMDczXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS43ODkwNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjc5NTA2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODAxMDYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44MDcwNTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjgxMzA1MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
ODE5MDQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS44MjUwNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjgzMTAzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODM3MDMzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44NDMwMjldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjg0
OTAyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzEuODU1MDIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMS44NjEwMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjg2NzAxMF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODczMDA1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44Nzkw
MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjg4NDk5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuODkwOTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44OTY5ODZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjkwMjk4Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTA4OTc3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS45MTQ5NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjkyMDk2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTI2OTY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS45MzI5NjFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjkzODk1Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuOTQ0OTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS45NTA5NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjk1Njk0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTYyOTM4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS45Njg5MzNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
Ljk3NDkyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuOTgwOTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMS45ODY5MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjk5MjkxNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTk4OTExXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4w
MDQ5MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMyLjAxMDkwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzIuMDE2ODk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wMjI4OTNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjAyODg4N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDM0
ODgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMi4wNDA4NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMyLjA0Njg3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDUyODY5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wNTg4NjRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjA2NDg1
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzIuMDcwODU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMi4wNzY4NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjA4Mjg0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDg4ODQwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wOTQ4MzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMyLjEwMDgzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzIuMTA2ODI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4xMTI4MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjExODgxN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTI0ODEyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
Mi4xMzA4MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMyLjEzNjgwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTQyNzk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4xNDg3OTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjE1NDc5MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIu
MTYwNzg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMi4xNjY3ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMyLjE3Mjc3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTc4NzcyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4xODQ3NjddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjE5
MDc2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzIuMTk2NzU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMi4yMDI3NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjIwODc1MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjE0NzQ2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yMjA3
NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMyLjIyNjczN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzIuMjMyNzMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yMzg3MjhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjI0NDcyM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjUwNzE4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi4yNTY3MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjI2MjcwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjY4NzA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yNzQ3MDBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjI4MDY5NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzIuMjg2NjkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMi4yOTI2ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjI5ODY4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMzA0Njc2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4zMTA2NzFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMy
LjMxNjY2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzIuMzIyNjYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMi4zMjg2NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjMzNDY1Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMzQwNjQ3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4z
NDY2NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMyLjM1MjYzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzIuMzU4NjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4zNjQ2MjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjM3MDYyNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMzc2
NjIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMi4zODI2MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMyLjM4ODYxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMzk0NjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi40MDA2MDJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjQwNjU5
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzIuNDEyNTk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMi40MTg1OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjQyNDU5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNDMwNTg3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi40MzY1ODRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMyLjQ0MjU4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzIuNDQ4NTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi40NTQ1NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjQ2MDU2N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNDY2NTYyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
Mi40NzI1NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMyLjQ3ODU1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNDg0NTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi40OTA1NDVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjQ5NjU0MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIu
NTAyNTM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMi41MDg1MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMyLjUxNDUyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNTIwNTIxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi41MjY1MjBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjUz
MjUxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzIuNTM4NTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMi41NDQ1MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjU1MDUwMV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNTU2NDk2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi41NjI0
OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMyLjU2ODQ4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzIuNTc0NDgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi41ODA0NzddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjU4NjQ3M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNTkyNDY4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi41OTg0NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjYwNDQ1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjEwNDU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi42MTY0NDldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjYyMjQ0NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzIuNjI4NDQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMi42MzQ0MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjY0MDQzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjQ2NDI2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi42NTI0MjFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMy
LjY1ODQxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzIuNjY0NDExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMi42NzA0MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjY3NjQwMl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjgyMzk4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi42
ODgzOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMyLjY5NDM4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzIuNzAwMzg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43MDYzNzldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjcxMjM3NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzE4
MzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMi43MjQzNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMyLjczMDM2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzM2MzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43NDIzNTJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjc0ODM0
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzIuNzU0MzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMi43NjAzMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjc2NjMzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzcyMzI5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43NzgzMjVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMyLjc4NDMyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzIuNzkwMzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43OTYzMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjgwMjMwNl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuODA4MzAxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
Mi44MTQyOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMyLjgyMDI5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuODI2Mjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi44MzIyODNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjgzODI3OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIu
ODQ0MjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMi44NTAyNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMyLjg1NjI2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuODYyMjYwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi44NjgyNTVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjg3
NDI1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzIuODgwMjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMi44ODYyNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjg5MjIzNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuODk4MjMyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45MDQy
MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMyLjkxMDIyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzIuOTE2MjE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45MjIyMTNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjkyODIwOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuOTM0MjA0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi45NDAxOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjk0NjE5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuOTUyMTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45NTgxODhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjk2NDE4M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzIuOTcwMTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMi45NzYxNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjk4MjE2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuOTg4MTY0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45OTQxNjBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMz
LjAwMDE1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzMuMDA2MTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMy4wMTIxNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjAxODE0Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMDI0MTM3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4w
MzAxMzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMzLjAzNjEyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzMuMDQyMTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4wNDgxMThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjA1NDExNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMDYw
MTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMy4wNjYxMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMzLjA3MjEwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMDc4MDk2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4wODQwOTBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjA5MDA4
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzMuMDk2MDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMy4xMDIwNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjEwODA3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMTE0MDY3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4xMjAwNjJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMzLjEyNjA1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzMuMTMyMDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4xMzgwNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjE0NDA0M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMTUwMDM5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
My4xNTYwMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMzLjE2MjAzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMTY4MDI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4xNzQwMjFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjE4MDAxNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMu
MTg2MDEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMy4xOTIwMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMzLjE5ODAwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjAzOTk4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yMDk5OTNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjIx
NTk4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzMuMjIxOTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMy4yMjc5ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjIzMzk3Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjM5OTcxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yNDU5
NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMzLjI1MTk2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzMuMjU3OTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yNjM5NTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjI2OTk0OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjc1OTQz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMy4yODE5NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMzLjI4NzkzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjkzOTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yOTk5MjddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjMwNTkyMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzMuMzExOTE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMy4zMTc5MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjMyMzkwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMzI5OTA0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4zMzU4OTldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMz
LjM0MTg5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzMuMzQ3ODkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMy4zNTM4ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjM1OTg4MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMzY1ODc2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4z
NzE4NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMzLjM3Nzg2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzMuMzgzODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4zODk4NTddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjM5NTg1Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNDAx
ODQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMy40MDc4NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMzLjQxMzgzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNDE5ODMzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy40MjU4MjldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjQzMTgz
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzMuNDM3ODI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMy40NDM4MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjQ0OTgxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNDU1ODE0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy40NjE4MTFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMzLjQ2NzgwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzMuNDc0NzU1XSBpNDBlIDAwMDA6MDE6MDAuMzogZncgNi4wLjQ4NDQyIGFw
aSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5XSBbODA4NjowMDAw
XQpbICAgMzMuNzYyNjQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NjE0NDAgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzMuNzY4NzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NjE0NDAgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNzc0OTIyXSBpNDBlIDAwMDA6MDE6MDAu
MzogTUFDIGFkZHJlc3M6IDNjOmZkOmZlOjZiOmU5OmMzClsgICAzMy43ODA4MDhdIGk0MGUgMDAw
MDowMTowMC4zOiBGVyBMTERQIGlzIGVuYWJsZWQKWyAgIDMzLjc5MjAxMl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNzk4MDA5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
My44MDQwMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMzLjgxMDAwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuODE3NTM4XSBpNDBlIDAwMDA6MDE6MDAuMzogUENJLUV4
cHJlc3M6IFNwZWVkIDguMEdUL3MgV2lkdGggeDgKWyAgIDMzLjgyNDg0N10gaTQwZSAwMDAwOjAx
OjAwLjM6IEZlYXR1cmVzOiBQRi1pZFszXSBWU0lzOiAzNCBRUDogMzIgUlNTIEZEX0FUUiBGRF9T
QiBOVFVQTEUgVnhMQU4gR2VuZXZlIFBUUCBWRVBBClsgICAzMy44MzQ5NjddIGVoY2lfaGNkOiBV
U0IgMi4wICdFbmhhbmNlZCcgSG9zdCBDb250cm9sbGVyIChFSENJKSBEcml2ZXIKWyAgIDMzLjg0
MTQ4OF0gZWhjaS1wY2k6IEVIQ0kgUENJIHBsYXRmb3JtIGRyaXZlcgpbICAgMzMuODQ2MDUzXSB4
aGNpX2hjZCAwMDBkOjAxOjAwLjI6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAg
MzMuODUyMTcyXSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IHhIQ0kgSG9zdCBDb250cm9sbGVyClsg
ICAzMy44NTczOTNdIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogbmV3IFVTQiBidXMgcmVnaXN0ZXJl
ZCwgYXNzaWduZWQgYnVzIG51bWJlciAxClsgICAzMy44NjUzMTldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT0yMDU2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjg3MTMxNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTIwNTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuODc3
MzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMy44ODMzMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMzLjg4OTMwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuODk1MzA0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy45MDEzMDNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjkwNzI5
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzMuOTEzMjk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9MTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzMuOTE5MTE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9MTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTI0OTU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMx
IHNpemU9MjQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTMwNzc4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9MjQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTM2NjAwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy45NDI1
OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMzLjk0ODU5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzMuOTU0NTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy45NjA1ODNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjk2NjU3OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTcyNTk4
XSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IGhjYyBwYXJhbXMgMHgwMTgwZmYwNSBoY2kgdmVyc2lv
biAweDExMCBxdWlya3MgMHgwMDAwMDAwMDAwMDAwMDEwClsgICAzMy45ODIwNTFdIGh1YiAxLTA6
MS4wOiBVU0IgaHViIGZvdW5kClsgICAzMy45ODU4MDJdIGh1YiAxLTA6MS4wOiAyIHBvcnRzIGRl
dGVjdGVkClsgICAzMy45ODk5MjZdIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogeEhDSSBIb3N0IENv
bnRyb2xsZXIKWyAgIDMzLjk5NTE0NF0geGhjaV9oY2QgMDAwZDowMTowMC4yOiBuZXcgVVNCIGJ1
cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDIKWyAgIDM0LjAwMjUzNF0geGhjaV9o
Y2QgMDAwZDowMTowMC4yOiBIb3N0IHN1cHBvcnRzIFVTQiAzLjEgRW5oYW5jZWQgU3VwZXJTcGVl
ZApbICAgMzQuMDA5NTk1XSB1c2IgdXNiMjogV2UgZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGhtcyBm
b3IgTFBNIGZvciB0aGlzIGhvc3QsIGRpc2FibGluZyBMUE0uClsgICAzNC4wMTc3OTBdIGh1YiAy
LTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC4wMjE1NDBdIGh1YiAyLTA6MS4wOiA0IHBvcnRz
IGRldGVjdGVkClsgICAzNC4wMjU4MThdIHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogeEhDSSBIb3N0
IENvbnRyb2xsZXIKWyAgIDM0LjAzMTAzOF0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBuZXcgVVNC
IGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDMKWyAgIDM0LjA0MzcyNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTIwNTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQu
MDQ5NzIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9MjA1NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzNC4wNTU3MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDM0LjA2MTcxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMDY3NzE3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4wNzM3MTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjA3
OTcxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzQuMDg1NzA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzNC4wOTE3MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT0xNiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4wOTc1MjZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT0xNiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4xMDMzNjJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT0zMiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4xMDkxODRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT0zMiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4x
MTUwMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDM0LjEyMTAwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzQuMTI2OTk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4xMzI5OTRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjEzODk5MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMTQ0
OTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzNC4xNTA5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDM0LjE1Njk3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMTYzMDA3XSB4aGNpX2hjZCAwMDA0OjAzOjAw
LjA6IGhjYyBwYXJhbXMgMHgwMTQwNTFjZiBoY2kgdmVyc2lvbiAweDEwMCBxdWlya3MgMHgwMDAw
MDAxMTAwMDAwNDEwClsgICAzNC4xNzQwMjhdIGh1YiAzLTA6MS4wOiBVU0IgaHViIGZvdW5kClsg
ICAzNC4xNzc3ODNdIGh1YiAzLTA6MS4wOiA0IHBvcnRzIGRldGVjdGVkClsgICAzNC4xODE5NjVd
IHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgIDM0LjE4NzE4
NV0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25l
ZCBidXMgbnVtYmVyIDQKWyAgIDM0LjE5NDU3OV0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBIb3N0
IHN1cHBvcnRzIFVTQiAzLjAgU3VwZXJTcGVlZApbICAgMzQuMjAwODc2XSB1c2IgdXNiNDogV2Ug
ZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGhtcyBmb3IgTFBNIGZvciB0aGlzIGhvc3QsIGRpc2FibGlu
ZyBMUE0uClsgICAzNC4yMDkwNzRdIGh1YiA0LTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC4y
MTI4MjZdIGh1YiA0LTA6MS4wOiA0IHBvcnRzIGRldGVjdGVkClsgICAzNC4yMTcwOTZdIHhoY2lf
aGNkIDAwMDU6MDI6MDAuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgIDM0LjIyMjMxNl0geGhj
aV9oY2QgMDAwNTowMjowMC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMg
bnVtYmVyIDUKWyAgIDM0LjM0MDYxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTIw
NTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMzQ2NjA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM0IHNpemU9MjA1NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4zNTI2MDVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjM1ODYwMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzQuMzY0NjAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzNC4zNzA1OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjM3NjU5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMzgyNTg5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4zODg1ODVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT0xNiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4z
OTQ0MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT0xNiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzNC40MDAyNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT0zMiBmbGFncz1j
YzAgYXR0cj0wClsgICAzNC40MDYwNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT0z
MiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC40MTE4ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjQxNzg4M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuNDIzODc5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
NC40Mjk4NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDM0LjQzNTg3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuNDQxODY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC40NDc4NjBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjQ1Mzg1Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQu
NDU5ODg1XSB4aGNpX2hjZCAwMDA1OjAyOjAwLjA6IGhjYyBwYXJhbXMgMHgwMTQwNTFjZiBoY2kg
dmVyc2lvbiAweDEwMCBxdWlya3MgMHgwMDAwMDAxMTAwMDAwNDEwClsgICAzNC40Njk3OTddIGh1
YiA1LTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC40NzM1NTJdIGh1YiA1LTA6MS4wOiA0IHBv
cnRzIGRldGVjdGVkClsgICAzNC40Nzc3MzBdIHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogeEhDSSBI
b3N0IENvbnRyb2xsZXIKWyAgIDM0LjQ4Mjk0N10geGhjaV9oY2QgMDAwNTowMjowMC4wOiBuZXcg
VVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDYKWyAgIDM0LjQ5MDMzNl0g
eGhjaV9oY2QgMDAwNTowMjowMC4wOiBIb3N0IHN1cHBvcnRzIFVTQiAzLjAgU3VwZXJTcGVlZApb
ICAgMzQuNDk2NjMxXSB1c2IgdXNiNjogV2UgZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGhtcyBmb3Ig
TFBNIGZvciB0aGlzIGhvc3QsIGRpc2FibGluZyBMUE0uClsgICAzNC41MDQ4MjddIGh1YiA2LTA6
MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC41MDg1NzddIGh1YiA2LTA6MS4wOiA0IHBvcnRzIGRl
dGVjdGVkClsgICAzNC41MTI5MzhdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBk
cml2ZXIgdXNiLXN0b3JhZ2UKWyAgIDM0LjUxOTc5MV0gcnRjLWVmaSBydGMtZWZpLjA6IHJlZ2lz
dGVyZWQgYXMgcnRjMApbICAgMzQuNTI0OTI1XSBydGMtZWZpIHJ0Yy1lZmkuMDogc2V0dGluZyBz
eXN0ZW0gY2xvY2sgdG8gMjAyMi0wNC0xOVQxMzozMzowMyBVVEMgKDE2NTAzNzUxODMpClsgICAz
NC41MzMzODhdIHNic2EtZ3dkdCBzYnNhLWd3ZHQuMDogSW5pdGlhbGl6ZWQgd2l0aCAxMHMgdGlt
ZW91dCBAIDI1MDAwMDAwIEh6LCBhY3Rpb249MC4KWyAgIDM0LjU0MTYxOV0gZGV2aWNlLW1hcHBl
cjogaW9jdGw6IDQuNDMuMC1pb2N0bCAoMjAyMC0xMC0wMSkgaW5pdGlhbGlzZWQ6IGRtLWRldmVs
QHJlZGhhdC5jb20KWyAgIDM0LjU1MTIxOF0gcHN0b3JlOiBSZWdpc3RlcmVkIGVmaSBhcyBwZXJz
aXN0ZW50IHN0b3JlIGJhY2tlbmQKWyAgIDM0LjU1NzA2NV0gU01DQ0M6IFNPQ19JRDogSUQgPSBq
ZXAxMDY6MGExNjowMDAxIFJldmlzaW9uID0gMHgwMDAwMDBhMQpbICAgMzQuNTYzNjg5XSB1c2Jj
b3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmhpZApbICAgMzQuNTY5MjUz
XSB1c2JoaWQ6IFVTQiBISUQgY29yZSBkcml2ZXIKWyAgIDM0LjU3MTY1NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuNTczMTA1XSB1
MzIgY2xhc3NpZmllcgpbICAgMzQuNTc5MDcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC41NzkwNzVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjU4MTc2N10gICAgIGlu
cHV0IGRldmljZSBjaGVjayBvbgpbICAgMzQuNTgxNzY5XSAgICAgQWN0aW9ucyBjb25maWd1cmVk
ClsgICAzNC41ODc3NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWMwMCBhdHRyPTAKWyAgIDM0LjU5NDEzN10gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZhbWls
eSAxMApbICAgMzQuNTk3NDEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jMDAgYXR0cj0wClsgICAzNC41OTc0MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjYwMTIxOF0gU2VnbWVudCBSb3V0aW5n
IHdpdGggSVB2NgpbICAgMzQuNjA2ODAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC42MDY4MDZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjYxMTI2NF0gc2l0OiBJUHY2
LCBJUHY0IGFuZCBNUExTIG92ZXIgSVB2NCB0dW5uZWxpbmcgZHJpdmVyClsgICAzNC42NDQ5MTJd
IE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMTcKWyAgIDM0LjY0OTM2Nl0gQnJpZGdl
IGZpcmV3YWxsaW5nIHJlZ2lzdGVyZWQKWyAgIDM0LjY1MzM4OF0gS2V5IHR5cGUgZG5zX3Jlc29s
dmVyIHJlZ2lzdGVyZWQKWyAgIDM0LjY1NzY4M10gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZh
bWlseSA0MApbICAgMzQuNjYyMjA1XSBLZXkgdHlwZSAuX2ZzY3J5cHQgcmVnaXN0ZXJlZApbICAg
MzQuNjY2MjExXSBLZXkgdHlwZSAuZnNjcnlwdCByZWdpc3RlcmVkClsgICAzNC42NzAxMjNdIEtl
eSB0eXBlIGZzY3J5cHQtcHJvdmlzaW9uaW5nIHJlZ2lzdGVyZWQKWyAgIDM0LjY3NTI4OV0gQnRy
ZnMgbG9hZGVkLCBjcmMzMmM9Y3JjMzJjLWdlbmVyaWMKWyAgIDM0LjY3OTg5N10gcHN0b3JlOiBV
c2luZyBjcmFzaCBkdW1wIGNvbXByZXNzaW9uOiBkZWZsYXRlClsgICAzNC42ODU3NTddIEtleSB0
eXBlIGVuY3J5cHRlZCByZWdpc3RlcmVkClsgICAzNC42OTAwMjZdIEJFUlQ6IEVycm9yIHJlY29y
ZHMgZnJvbSBwcmV2aW91cyBib290OgpbICAgMzQuNjk0ODk2XSBbSGFyZHdhcmUgRXJyb3JdOiBl
dmVudCBzZXZlcml0eTogcmVjb3ZlcmFibGUKWyAgIDM0LjcwMDI4NV0gW0hhcmR3YXJlIEVycm9y
XTogIEVycm9yIDAsIHR5cGU6IGZhdGFsClsgICAzNC43MDUxNTRdIFtIYXJkd2FyZSBFcnJvcl06
ICAgc2VjdGlvbiB0eXBlOiB1bmtub3duLCBlOGVkODk4ZC1kZjE2LTQzY2MtOGVjYy01NGYwNjBl
ZjE1N2YKWyAgIDM0LjcxMzQ5M10gW0hhcmR3YXJlIEVycm9yXTogICBzZWN0aW9uIGxlbmd0aDog
MHgzMQpbICAgMzQuNzE4NDQ5XSBbSGFyZHdhcmUgRXJyb3JdOiAgIDAwMDAwMDAwOiAwMDAwMDA3
ZiA2ZTZiNmU1NSAyMDZlNzc2ZiA2ZjYyNjU3MiAgLi4uLlVua25vd24gcmVibwpbICAgMzQuNzE5
NDUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0w
ClsgICAzNC43MjcxMzhdIFtIYXJkd2FyZSBFcnJvcl06ICAgMDAwMDAwMTA6IDcyMjA3NDZmIDZm
NzM2MTY1IDAwMDAwMDZlIDAwMDAwMDAwICBvdCByZWFzb24uLi4uLi4uClsgICAzNC43MjcxNDBd
IFtIYXJkd2FyZSBFcnJvcl06ICAgMDAwMDAwMjA6IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAw
IDAwMDAwMDAwICAuLi4uLi4uLi4uLi4uLi4uClsgICAzNC43MjcxNDFdIFtIYXJkd2FyZSBFcnJv
cl06ICAgMDAwMDAwMzA6IDExICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAuClsgICAzNC43NTg5NDNdIHVzYiAzLTQ6IG5ldyBoaWdoLXNwZWVkIFVTQiBkZXZp
Y2UgbnVtYmVyIDIgdXNpbmcgeGhjaV9oY2QKWyAgIDM0Ljc1ODk0OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuNzU4OTU0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC43
NjU0NzddIHByaW50azogY29uc29sZSBbbmV0Y29uMF0gZW5hYmxlZApbICAgMzQuNzcxNDc5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAz
NC43Nzc0NjldIG5ldGNvbnNvbGU6IG5ldHdvcmsgbG9nZ2luZyBzdGFydGVkClsgICAzNC43OTIz
NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAK
WyAgIDM0Ljc5ODM0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
YzAwIGF0dHI9MApbICAgMzQuODA0MzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC44MTAzMzhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjgxMDM1M10gbWQ6IFdhaXRp
bmcgZm9yIGFsbCBkZXZpY2VzIHRvIGJlIGF2YWlsYWJsZSBiZWZvcmUgYXV0b2RldGVjdApbICAg
MzQuODIzMTExXSBtZDogSWYgeW91IGRvbid0IHVzZSByYWlkLCB1c2UgcmFpZD1ub2F1dG9kZXRl
Y3QKWyAgIDM0LjgyODc1OV0gbWQ6IEF1dG9kZXRlY3RpbmcgUkFJRCBhcnJheXMuClsgICAzNC44
MzI4NDVdIG1kOiBhdXRvcnVuIC4uLgpbICAgMzQuODM1NjI5XSBtZDogLi4uIGF1dG9ydW4gRE9O
RS4KWyAgIDM0LjgzODk2N10gV2FpdGluZyBmb3Igcm9vdCBkZXZpY2UgL2Rldi9zZGEyLi4uClsg
ICAzNC45NDY1NDZdIHVzYiA2LTE6IG5ldyBTdXBlclNwZWVkIEdlbiAxIFVTQiBkZXZpY2UgbnVt
YmVyIDIgdXNpbmcgeGhjaV9oY2QKWyAgIDM0Ljk2MjQzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuOTY4NDMzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC45NzQ0MzFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAg
IDM0Ljk4MDQzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9YzAw
IGF0dHI9MApbICAgMzQuOTg4MzY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz04MDAgYXR0cj0wClsgICAzNC45OTQzNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1LjAxMDMyM10gaHViIDMtNDoxLjA6
IFVTQiBodWIgZm91bmQKWyAgIDM1LjAxNDEyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBz
aXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuMDIwMTI4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS4wMjYxMjhdIGh1YiAz
LTQ6MS4wOiA1IHBvcnRzIGRldGVjdGVkClsgICAzNS4wMzAxMzJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjAzNjEyOF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuMDQy
MTI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0w
ClsgICAzNS4wNDgxMjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdz
PWMwMCBhdHRyPTAKWyAgIDM1LjA1NDE4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXpl
PTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuMDYwMTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS4wNjgxMDRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1LjA3NDEx
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9ODAwIGF0dHI9MApb
ICAgMzUuMDkwNzIxXSB1c2Itc3RvcmFnZSA2LTE6MS4wOiBVU0IgTWFzcyBTdG9yYWdlIGRldmlj
ZSBkZXRlY3RlZApbICAgMzUuMDk2OTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNS4xMDI5NDhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM1LjEwOTAwOF0gc2NzaSBob3N0
MDogdXNiLXN0b3JhZ2UgNi0xOjEuMApbICAgMzUuMjk4NjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS4zMDQ2MDRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjMxMDYw
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApb
ICAgMzUuMzE2NTk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1j
MDAgYXR0cj0wClsgICAzNS4zMjI1OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00
MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjMyODU4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNCBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuNDIzMTA3XSB1c2IgMy00LjE6
IG5ldyBoaWdoLXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDMgdXNpbmcgeGhjaV9oY2QKWyAgIDM1
LjU0ODA2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0
dHI9MApbICAgMzUuNTU0MDY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBm
bGFncz1jMDAgYXR0cj0wClsgICAzNS41NjAwNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjU2NjA1OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuNTcyMDU3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS41
NzgwNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRy
PTAKWyAgIDM1LjU4NDA0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxh
Z3M9YzAwIGF0dHI9MApbICAgMzUuNTkwMDQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNp
emU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS41OTgwNDJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1LjYwNDA0Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9ODAwIGF0dHI9MApbICAgMzUuNjI0
MzE4XSB1c2Itc3RvcmFnZSAzLTQuMToxLjA6IFVTQiBNYXNzIFN0b3JhZ2UgZGV2aWNlIGRldGVj
dGVkClsgICAzNS42MzA3MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDM1LjYzNjcxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzUuNjQyNzc1XSBzY3NpIGhvc3QxOiB1c2It
c3RvcmFnZSAzLTQuMToxLjAKWyAgIDM1LjY0ODExNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MSBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuNjU0MTEyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS42NjAxMDldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1
LjY2NjEwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0
dHI9MApbICAgMzUuNjcyMTAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBm
bGFncz1jMDAgYXR0cj0wClsgICAzNS42NzgwOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1Ljc3MTEwOF0gdXNiIDMtNC4yOiBuZXcg
aGlnaC1zcGVlZCBVU0IgZGV2aWNlIG51bWJlciA0IHVzaW5nIHhoY2lfaGNkClsgICAzNS44OTE5
NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAK
WyAgIDM1Ljg5Nzk3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9
YzAwIGF0dHI9MApbICAgMzUuOTAzOTc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9
NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS45MDk5NjldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzQgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjkxNTk2Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuOTIxOTYy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsg
ICAzNS45Mjc5NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWMw
MCBhdHRyPTAKWyAgIDM1LjkzMzk1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQw
OTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuOTQxODgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMxIHNpemU9NDA5NiBmbGFncz04MDAgYXR0cj0wClsgICAzNS45NDc4ODJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1Ljk2NjEyMF0g
dXNiLXN0b3JhZ2UgMy00LjI6MS4wOiBVU0IgTWFzcyBTdG9yYWdlIGRldmljZSBkZXRlY3RlZApb
ICAgMzUuOTcyNTg3XSBzY3NpIGhvc3QyOiB1c2Itc3RvcmFnZSAzLTQuMjoxLjAKWyAgIDM1Ljk3
Nzk5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9
MApbICAgMzUuOTgzOTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFn
cz1jMDAgYXR0cj0wClsgICAzNS45ODk5ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6
ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1Ljk5NTk4M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzYuMDAxOTc5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNi4wMDc5
NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAK
WyAgIDM2LjEwMzEwN10gdXNiIDMtNC4zOiBuZXcgbG93LXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVy
IDUgdXNpbmcgeGhjaV9oY2QKWyAgIDM2LjE0ODkxNl0gc2NzaSAwOjA6MDowOiBEaXJlY3QtQWNj
ZXNzICAgICAgVVNCICAgICAgU2FuRGlzayAzLjJHZW4xIDEuMDAgUFE6IDAgQU5TSTogNgpbICAg
MzYuMTU3NDAwXSBzZCAwOjA6MDowOiBbc2RhXSAxMjAxNzY2NDAgNTEyLWJ5dGUgbG9naWNhbCBi
bG9ja3M6ICg2MS41IEdCLzU3LjMgR2lCKQpbICAgMzYuMTY3MDYyXSBzZCAwOjA6MDowOiBbc2Rh
XSBXcml0ZSBQcm90ZWN0IGlzIG9mZgpbICAgMzYuMTc0MzUzXSBzZCAwOjA6MDowOiBbc2RhXSBX
cml0ZSBjYWNoZTogZGlzYWJsZWQsIHJlYWQgY2FjaGU6IGVuYWJsZWQsIGRvZXNuJ3Qgc3VwcG9y
dCBEUE8gb3IgRlVBClsgICAzNi4yMDIwNTRdIEdQVDpQcmltYXJ5IGhlYWRlciB0aGlua3MgQWx0
LiBoZWFkZXIgaXMgbm90IGF0IHRoZSBlbmQgb2YgdGhlIGRpc2suClsgICAzNi4yMDk0NDRdIEdQ
VDoxNzE4MTk1MSAhPSAxMjAxNzY2MzkKWyAgIDM2LjIxMzA5OF0gR1BUOkFsdGVybmF0ZSBHUFQg
aGVhZGVyIG5vdCBhdCB0aGUgZW5kIG9mIHRoZSBkaXNrLgpbICAgMzYuMjE5MDkzXSBHUFQ6MTcx
ODE5NTEgIT0gMTIwMTc2NjM5ClsgICAzNi4yMjI3NDJdIEdQVDogVXNlIEdOVSBQYXJ0ZWQgdG8g
Y29ycmVjdCBHUFQgZXJyb3JzLgpbICAgMzYuMjI3ODc3XSAgc2RhOiBzZGExIHNkYTIKWyAgIDM2
LjIzNTIwMF0gc2QgMDowOjA6MDogW3NkYV0gQXR0YWNoZWQgU0NTSSByZW1vdmFibGUgZGlzawpb
ICAgMzYuMjQ0NDQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5NiBmbGFncz1j
MDAgYXR0cj0wClsgICAzNi4yNTA0NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzQgc2l6ZT00
MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM2LjI1NjQ0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMSBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzYuMjYyNDQzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNi4yNjg0NDFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzEgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAg
IDM2LjI3NDQzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNCBzaXplPTQwOTYgZmxhZ3M9YzAw
IGF0dHI9MApbICAgMzYuMjgwNDM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMxIHNpemU9NDA5
NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNi4yODY0MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzQgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM2LjI5NDc0Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMSBzaXplPTQwOTYgZmxhZ3M9ODAwIGF0dHI9MApbICAgMzYuMzAwNzQzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM0IHNpemU9NDA5NiBmbGFncz04MDAgYXR0cj0wClsgICAz
Ni4zMzIyMDVdIGlucHV0OiBBbWVyaWNhbiBNZWdhdHJlbmRzIEluYy4gVmlydHVhbCBLZXlib2Fy
ZCBhbmQgTW91c2UgYXMgL2RldmljZXMvcGNpMDAwNDowMC8wMDA0OjAwOjAzLjAvMDAwNDowMzow
MC4wL3VzYjMvMy00LzMtNC4zLzMtNC4zOjEuMC8wMDAzOjA0NkI6RkYxMC4wMDAxL2lucHV0L2lu
cHV0MQpbICAgMzYuMzQ4MDYzXSBoaWQtZ2VuZXJpYyAwMDAzOjA0NkI6RkYxMC4wMDAxOiBpbnB1
dDogVVNCIEhJRCB2MS4xMCBLZXlib2FyZCBbQW1lcmljYW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1
YWwgS2V5Ym9hcmQgYW5kIE1vdXNlXSBvbiB1c2ItMDAwNDowMzowMC4wLTQuMy9pbnB1dDAKWyAg
IDM2LjM3MzgwM10gaW5wdXQ6IEFtZXJpY2FuIE1lZ2F0cmVuZHMgSW5jLiBWaXJ0dWFsIEtleWJv
YXJkIGFuZCBNb3VzZSBhcyAvZGV2aWNlcy9wY2kwMDA0OjAwLzAwMDQ6MDA6MDMuMC8wMDA0OjAz
OjAwLjAvdXNiMy8zLTQvMy00LjMvMy00LjM6MS4xLzAwMDM6MDQ2QjpGRjEwLjAwMDIvaW5wdXQv
aW5wdXQyClsgICAzNi4zODk2NTRdIGhpZC1nZW5lcmljIDAwMDM6MDQ2QjpGRjEwLjAwMDI6IGlu
cHV0OiBVU0IgSElEIHYxLjEwIE1vdXNlIFtBbWVyaWNhbiBNZWdhdHJlbmRzIEluYy4gVmlydHVh
bCBLZXlib2FyZCBhbmQgTW91c2VdIG9uIHVzYi0wMDA0OjAzOjAwLjAtNC4zL2lucHV0MQpbICAg
MzYuNDExODg4XSByYW5kb206IGZhc3QgaW5pdCBkb25lClsgICAzNi42NjEwOTZdIHNjc2kgMTow
OjA6MDogQ0QtUk9NICAgICAgICAgICAgQU1JICAgICAgVmlydHVhbCBDRFJPTTAgICAxLjAwIFBR
OiAwIEFOU0k6IDAgQ0NTClsgICAzNi42NzAwNzhdIHNjc2kgMTowOjA6MTogQ0QtUk9NICAgICAg
ICAgICAgQU1JICAgICAgVmlydHVhbCBDRFJPTTEgICAxLjAwIFBROiAwIEFOU0k6IDAgQ0NTClsg
ICAzNi42Nzg4ODZdIHNjc2kgMTowOjA6MjogQ0QtUk9NICAgICAgICAgICAgQU1JICAgICAgVmly
dHVhbCBDRFJPTTIgICAxLjAwIFBROiAwIEFOU0k6IDAgQ0NTClsgICAzNi42ODc1OTBdIHNjc2kg
MTowOjA6MzogQ0QtUk9NICAgICAgICAgICAgQU1JICAgICAgVmlydHVhbCBDRFJPTTMgICAxLjAw
IFBROiAwIEFOU0k6IDAgQ0NTClsgICAzNy4wMTEwOTJdIHNjc2kgMjowOjA6MDogRGlyZWN0LUFj
Y2VzcyAgICAgQU1JICAgICAgVmlydHVhbCBIRGlzazAgICAxLjAwIFBROiAwIEFOU0k6IDAgQ0NT
ClsgICAzNy4wMjAwNjFdIHNjc2kgMjowOjA6MTogRGlyZWN0LUFjY2VzcyAgICAgQU1JICAgICAg
VmlydHVhbCBIRGlzazEgICAxLjAwIFBROiAwIEFOU0k6IDAgQ0NTClsgICAzNy4wMjA4NDFdIHNk
IDI6MDowOjA6IFtzZGJdIEF0dGFjaGVkIFNDU0kgcmVtb3ZhYmxlIGRpc2sKWyAgIDM3LjAyODgw
MF0gc2NzaSAyOjA6MDoyOiBEaXJlY3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNr
MiAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM3LjA0MjY1NF0gc2NzaSAyOjA6MDozOiBE
aXJlY3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrMyAgIDEuMDAgUFE6IDAgQU5T
STogMCBDQ1MKWyAgIDM3LjA0MzQ4M10gc2QgMjowOjA6MTogW3NkY10gQXR0YWNoZWQgU0NTSSBy
ZW1vdmFibGUgZGlzawpbICAgMzcuMDUxMzUwXSBzY3NpIDI6MDowOjQ6IERpcmVjdC1BY2Nlc3Mg
ICAgIEFNSSAgICAgIFZpcnR1YWwgSERpc2s0ICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAg
MzcuMDU3NzA2XSBzZCAyOjA6MDoyOiBbc2RkXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNr
ClsgICAzNy4wNzQ5MTFdIHNkIDI6MDowOjM6IFtzZGVdIEF0dGFjaGVkIFNDU0kgcmVtb3ZhYmxl
IGRpc2sKWyAgIDM3LjA4MDgwM10gc2QgMjowOjA6NDogW3NkZl0gQXR0YWNoZWQgU0NTSSByZW1v
dmFibGUgZGlzawpbICAgMzcuMDg4Mjc4XSBFWFQ0LWZzIChzZGEyKTogcmVjb3ZlcnkgY29tcGxl
dGUKWyAgIDM3LjA5OTg0Ml0gRVhUNC1mcyAoc2RhMik6IG1vdW50ZWQgZmlsZXN5c3RlbSB3aXRo
IG9yZGVyZWQgZGF0YSBtb2RlLiBPcHRzOiAobnVsbCkKWyAgIDM3LjEwNzUxNF0gVkZTOiBNb3Vu
dGVkIHJvb3QgKGV4dDQgZmlsZXN5c3RlbSkgb24gZGV2aWNlIDg6Mi4KWyAgIDM3LjExNjY5M10g
ZGV2dG1wZnM6IG1vdW50ZWQKWyAgIDM3LjEyMTMyMF0gRnJlZWluZyB1bnVzZWQga2VybmVsIG1l
bW9yeTogNDE2MEsKWyAgIDM3LjEyNTkwMF0gUnVuIC9zYmluL2luaXQgYXMgaW5pdCBwcm9jZXNz
ClsgICAzNy4zOTMyMzJdIHN5c3RlbWRbMV06IHN5c3RlbWQgMjQ5LjcrIHJ1bm5pbmcgaW4gc3lz
dGVtIG1vZGUgKC1QQU0gLUFVRElUIC1TRUxJTlVYIC1BUFBBUk1PUiArSU1BIC1TTUFDSyArU0VD
Q09NUCAtR0NSWVBUIC1HTlVUTFMgLU9QRU5TU0wgK0FDTCArQkxLSUQgLUNVUkwgLUVMRlVUSUxT
IC1GSURPMiAtSUROMiAtSUROIC1JUFRDICtLTU9EIC1MSUJDUllQVFNFVFVQICtMSUJGRElTSyAt
UENSRTIgLVBXUVVBTElUWSAtUDExS0lUIC1RUkVOQ09ERSAtQlpJUDIgLUxaNCAtWFogLVpMSUIg
K1pTVEQgK1hLQkNPTU1PTiArVVRNUCArU1lTVklOSVQgZGVmYXVsdC1oaWVyYXJjaHk9aHlicmlk
KQpbICAgMzcuNDIzNjYzXSBzeXN0ZW1kWzFdOiBEZXRlY3RlZCBhcmNoaXRlY3R1cmUgYXJtNjQu
CgpXZWxjb21lIHRvIEVXQU9MIChFZGdlIFdvcmtsb2FkIEFic3RyYWN0aW9uIGFuZCBPcmNoZXN0
cmF0aW9uIExheWVyKSB1bnN0YWJsZSAoaG9uaXN0ZXIpIQoKWyAgIDM3LjQ3ODM4Nl0gc3lzdGVt
ZFsxXTogSG9zdG5hbWUgc2V0IHRvIDxjb21ocGM+LgpbICAgMzcuNTI4NjM1XSBzeXN0ZW1kLXN5
c3YtZ2VuZXJhdG9yWzMyOV06IFN5c1Ygc2VydmljZSAnL2V0Yy9pbml0LmQvY29ubnRyYWNrZCcg
bGFja3MgYSBuYXRpdmUgc3lzdGVtZCB1bml0IGZpbGUuIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGlu
ZyBhIHVuaXQgZmlsZSBmb3IgY29tcGF0aWJpbGl0eS4gUGxlYXNlIHVwZGF0ZSBwYWNrYWdlIHRv
IGluY2x1ZGUgYSBuYXRpdmUgc3lzdGVtZCB1bml0IGZpbGUsIGluIG9yZGVyIHRvIG1ha2UgaXQg
bW9yZSBzYWZlIGFuZCByb2J1c3QuClsgICAzNy41NTI2NTBdIHN5c3RlbWQtc3lzdi1nZW5lcmF0
b3JbMzI5XTogU3lzViBzZXJ2aWNlICcvZXRjL2luaXQuZC9jb25udHJhY2stZmFpbG92ZXInIGxh
Y2tzIGEgbmF0aXZlIHN5c3RlbWQgdW5pdCBmaWxlLiBBdXRvbWF0aWNhbGx5IGdlbmVyYXRpbmcg
YSB1bml0IGZpbGUgZm9yIGNvbXBhdGliaWxpdHkuIFBsZWFzZSB1cGRhdGUgcGFja2FnZSB0byBp
bmNsdWRlIGEgbmF0aXZlIHN5c3RlbWQgdW5pdCBmaWxlLCBpbiBvcmRlciB0byBtYWtlIGl0IG1v
cmUgc2FmZSBhbmQgcm9idXN0LgpbICAgMzcuNzI1MzUxXSBzeXN0ZW1kWzFdOiAvbGliL3N5c3Rl
bWQvc3lzdGVtL3hlbi1xZW11LWRvbTAtZGlzay1iYWNrZW5kLnNlcnZpY2U6MTE6IFBJREZpbGU9
IHJlZmVyZW5jZXMgYSBwYXRoIGJlbG93IGxlZ2FjeSBkaXJlY3RvcnkgL3Zhci9ydW4vLCB1cGRh
dGluZyAvdmFyL3J1bi94ZW4vcWVtdS1kb20wLnBpZCDihpIgL3J1bi94ZW4vcWVtdS1kb20wLnBp
ZDsgcGxlYXNlIHVwZGF0ZSB0aGUgdW5pdCBmaWxlIGFjY29yZGluZ2x5LgpbICAgMzcuOTAzODU3
XSBzeXN0ZW1kWzFdOiBRdWV1ZWQgc3RhcnQgam9iIGZvciBkZWZhdWx0IHRhcmdldCBNdWx0aS1V
c2VyIFN5c3RlbS4KWyAgIDM3LjkxMTQ1M10gcmFuZG9tOiBzeXN0ZW1kOiB1bmluaXRpYWxpemVk
IHVyYW5kb20gcmVhZCAoMTYgYnl0ZXMgcmVhZCkKWyAgIDM3Ljk0MjgxM10gc3lzdGVtZFsxXTog
Q3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVtL2dldHR5LgpbICBPSyAgXSBDcmVhdGVkIHNsaWNl
IFNsaWNlIC9zeXN0ZW0vZ2V0dHkuClsgICAzNy45NTU5NjFdIHJhbmRvbTogc3lzdGVtZDogdW5p
bml0aWFsaXplZCB1cmFuZG9tIHJlYWQgKDE2IGJ5dGVzIHJlYWQpClsgICAzNy45NjMyNzZdIHN5
c3RlbWRbMV06IENyZWF0ZWQgc2xpY2UgU2xpY2UgL3N5c3RlbS9tb2Rwcm9iZS4KWyAgT0sgIF0g
Q3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVtL21vZHByb2JlLgpbICAgMzcuOTgzMTk5XSByYW5k
b206IHN5c3RlbWQ6IHVuaW5pdGlhbGl6ZWQgdXJhbmRvbSByZWFkICgxNiBieXRlcyByZWFkKQpb
ICAgMzcuOTkwMzk5XSBzeXN0ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vc2Vy
aWFsLWdldHR5LgpbICBPSyAgXSBDcmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vc2VyaWFsLWdl
dHR5LgpbICAgMzguMDEyMDMzXSBzeXN0ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIFVzZXIgYW5kIFNl
c3Npb24gU2xpY2UuClsgIE9LICBdIENyZWF0ZWQgc2xpY2UgVXNlciBhbmQgU2Vzc2lvbiBTbGlj
ZS4KWyAgIDM4LjAzNTQwM10gc3lzdGVtZFsxXTogU3RhcnRlZCBEaXNwYXRjaCBQYXNzd29yZCBS
ZXF1ZXN0cyB0byBDb25zb2xlIERpcmVjdG9yeSBXYXRjaC4KWyAgT0sgIF0gU3RhcnRlZCBEaXNw
YXRjaCBQYXNzd29yZCDigKZ0cyB0byBDb25zb2xlIERpcmVjdG9yeSBXYXRjaC4KWyAgIDM4LjA2
MzMzNV0gc3lzdGVtZFsxXTogU3RhcnRlZCBGb3J3YXJkIFBhc3N3b3JkIFJlcXVlc3RzIHRvIFdh
bGwgRGlyZWN0b3J5IFdhdGNoLgpbICBPSyAgXSBTdGFydGVkIEZvcndhcmQgUGFzc3dvcmQgUuKA
pnVlc3RzIHRvIFdhbGwgRGlyZWN0b3J5IFdhdGNoLgpbICAgMzguMDg3MzM2XSBzeXN0ZW1kWzFd
OiBSZWFjaGVkIHRhcmdldCBQYXRoIFVuaXRzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBQYXRo
IFVuaXRzLgpbICAgMzguMTAzMjE0XSBzeXN0ZW1kWzFdOiBSZWFjaGVkIHRhcmdldCBSZW1vdGUg
RmlsZSBTeXN0ZW1zLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBSZW1vdGUgRmlsZSBTeXN0ZW1z
LgpbICAgMzguMTIzMTk3XSBzeXN0ZW1kWzFdOiBSZWFjaGVkIHRhcmdldCBTbGljZSBVbml0cy4K
WyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU2xpY2UgVW5pdHMuClsgICAzOC4xNDMyMTJdIHN5c3Rl
bWRbMV06IFJlYWNoZWQgdGFyZ2V0IFN3YXBzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTd2Fw
cy4KWyAgIDM4LjE2NzkzOF0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIFJQQ2JpbmQgU2VydmVy
IEFjdGl2YXRpb24gU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gUlBDYmluZCBTZXJ2ZXIg
QWN0aXZhdGlvbiBTb2NrZXQuClsgICAzOC4xOTEyNjFdIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFy
Z2V0IFJQQyBQb3J0IE1hcHBlci4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgUlBDIFBvcnQgTWFw
cGVyLgpbICAgMzguMjExNDc0XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gU3lzbG9nIFNvY2tl
dC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIFN5c2xvZyBTb2NrZXQuClsgICAzOC4yMzEzMzZdIHN5
c3RlbWRbMV06IExpc3RlbmluZyBvbiBpbml0Y3RsIENvbXBhdGliaWxpdHkgTmFtZWQgUGlwZS4K
WyAgT0sgIF0gTGlzdGVuaW5nIG9uIGluaXRjdGwgQ29tcGF0aWJpbGl0eSBOYW1lZCBQaXBlLgpb
ICAgMzguMjUyNDAxXSBzeXN0ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gSm91
cm5hbCBBdWRpdCBTb2NrZXQgYmVpbmcgc2tpcHBlZC4KWyAgIDM4LjI2MDUxNF0gc3lzdGVtZFsx
XTogTGlzdGVuaW5nIG9uIEpvdXJuYWwgU29ja2V0ICgvZGV2L2xvZykuClsgIE9LICBdIExpc3Rl
bmluZyBvbiBKb3VybmFsIFNvY2tldCAoL2Rldi9sb2cpLgpbICAgMzguMjgzMzk1XSBzeXN0ZW1k
WzFdOiBMaXN0ZW5pbmcgb24gSm91cm5hbCBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiBK
b3VybmFsIFNvY2tldC4KWyAgIDM4LjMwMzQ2OV0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIE5l
dHdvcmsgU2VydmljZSBOZXRsaW5rIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIE5ldHdv
cmsgU2VydmljZSBOZXRsaW5rIFNvY2tldC4KWyAgIDM4LjMyNzQ0Nl0gc3lzdGVtZFsxXTogTGlz
dGVuaW5nIG9uIHVkZXYgQ29udHJvbCBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiB1ZGV2
IENvbnRyb2wgU29ja2V0LgpbICAgMzguMzQwNDg4XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24g
dWRldiBLZXJuZWwgU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gdWRldiBLZXJuZWwgU29j
a2V0LgpbICAgMzguMzUyNjQyXSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gVXNlciBEYXRhYmFz
ZSBNYW5hZ2VyIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIFVzZXIgRGF0YWJhc2UgTWFu
YWdlciBTb2NrZXQuClsgICAzOC4zNzY2ODddIHN5c3RlbWRbMV06IE1vdW50aW5nIEh1Z2UgUGFn
ZXMgRmlsZSBTeXN0ZW0uLi4KICAgICAgICAgTW91bnRpbmcgSHVnZSBQYWdlcyBGaWxlIFN5c3Rl
bS4uLgpbICAgMzguMzk2NTY0XSBzeXN0ZW1kWzFdOiBNb3VudGluZyBQT1NJWCBNZXNzYWdlIFF1
ZXVlIEZpbGUgU3lzdGVtLi4uCiAgICAgICAgIE1vdW50aW5nIFBPU0lYIE1lc3NhZ2UgUXVldWUg
RmlsZSBTeXN0ZW0uLi4KWyAgIDM4LjQxOTI0NV0gc3lzdGVtZFsxXTogQ29uZGl0aW9uIGNoZWNr
IHJlc3VsdGVkIGluIE1vdW50IC9wcm9jL3hlbiBmaWxlcyBiZWluZyBza2lwcGVkLgpbICAgMzgu
NDI4MzcxXSBzeXN0ZW1kWzFdOiBNb3VudGluZyBLZXJuZWwgRGVidWcgRmlsZSBTeXN0ZW0uLi4K
ICAgICAgICAgTW91bnRpbmcgS2VybmVsIERlYnVnIEZpbGUgU3lzdGVtLi4uClsgICAzOC40NDg1
NDldIHN5c3RlbWRbMV06IE1vdW50aW5nIEtlcm5lbCBUcmFjZSBGaWxlIFN5c3RlbS4uLgogICAg
ICAgICBNb3VudGluZyBLZXJuZWwgVHJhY2UgRmlsZSBTeXN0ZW0uLi4KWyAgIDM4LjQ3MjAxN10g
c3lzdGVtZFsxXTogTW91bnRpbmcgVGVtcG9yYXJ5IERpcmVjdG9yeSAvdG1wLi4uCiAgICAgICAg
IE1vdW50aW5nIFRlbXBvcmFyeSBEaXJlY3RvcnkgL3RtcC4uLgpbICAgMzguNDkxNDc5XSBzeXN0
ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gQ3JlYXRlIExpc3Qgb2YgU3RhdGlj
IERldmljZSBOb2RlcyBiZWluZyBza2lwcGVkLgpbICAgMzguNTAxNzEyXSBzeXN0ZW1kWzFdOiBT
dGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgY29uZmlnZnMuLi4KICAgICAgICAgU3RhcnRpbmcg
TG9hZCBLZXJuZWwgTW9kdWxlIGNvbmZpZ2ZzLi4uClsgICAzOC41MjA1MzFdIHN5c3RlbWRbMV06
IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBkcm0uLi4KICAgICAgICAgU3RhcnRpbmcgTG9h
ZCBLZXJuZWwgTW9kdWxlIGRybS4uLgpbICAgMzguNTQwNjAyXSBzeXN0ZW1kWzFdOiBTdGFydGlu
ZyBMb2FkIEtlcm5lbCBNb2R1bGUgZnVzZS4uLgogICAgICAgICBTdGFydGluZyBMb2FkIEtlcm5l
bCBNb2R1bGUgZnVzZS4uLgpbICAgMzguNTY0Nzk3XSBzeXN0ZW1kWzFdOiBTdGFydGluZyBSUEMg
QmluZC4uLgogICAgICAgICBTdGFydGluZyBSUEMgQmluZC4uLgpbICAgMzguNTc5MTA4XSBzeXN0
ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gRmlsZSBTeXN0ZW0gQ2hlY2sgb24g
Um9vdCBEZXZpY2UgYmVpbmcgc2tpcHBlZC4KWyAgIDM4LjU5MDAwMl0gc3lzdGVtZFsxXTogU3Rh
cnRpbmcgSm91cm5hbCBTZXJ2aWNlLi4uCiAgICAgICAgIFN0YXJ0aW5nIEpvdXJuYWwgU2Vydmlj
ZS4uLgpbICAgMzguNjExOTgyXSBzeXN0ZW1kWzFdOiBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1
bGVzLi4uCiAgICAgICAgIFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZXMuLi4KWyAgIDM4LjYz
MjM0NV0gc3lzdGVtZFsxXTogU3RhcnRpbmcgUmVtb3VudCBSb290IGFuZCBLZXJuZWwgRmlsZSBT
eXN0ZW1zLi4uClsgICAzOC42MzgxMjddIEVYVDQtZnMgKHNkYTIpOiByZS1tb3VudGVkLiBPcHRz
OiAobnVsbCkKICAgICAgICAgU3RhcnRpbmcgUmVtb3VudCBSb290IGFuZCBLZXJuZWwgRmlsZSBT
eXN0ZW1zLi4uClsgICAzOC42NjAzNjhdIHN5c3RlbWRbMV06IFN0YXJ0aW5nIENvbGRwbHVnIEFs
bCB1ZGV2IERldmljZXMuLi4KICAgICAgICAgU3RhcnRpbmcgQ29sZHBsdWcgQWxsIHVkZXYgRGV2
aWNlcy4uLgpbICAgMzguNjgxMDA1XSBzeXN0ZW1kWzFdOiBTdGFydGVkIFJQQyBCaW5kLgpbICBP
SyAgXSBTdGFydGVkIFJQQyBCaW5kLgpbICAgMzguNzAwMTQzXSBzeXN0ZW1kWzFdOiBTdGFydGVk
IEpvdXJuYWwgU2VydmljZS4KWyAgT0sgIF0gU3RhcnRlZCBKb3VybmFsIFNlcnZpY2UuClsgIE9L
ICBdIE1vdW50ZWQgSHVnZSBQYWdlcyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91bnRlZCBQT1NJ
WCBNZXNzYWdlIFF1ZXVlIEZpbGUgU3lzdGVtLgpbICBPSyAgXSBNb3VudGVkIEtlcm5lbCBEZWJ1
ZyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91bnRlZCBLZXJuZWwgVHJhY2UgRmlsZSBTeXN0ZW0u
ClsgIE9LICBdIE1vdW50ZWQgVGVtcG9yYXJ5IERpcmVjdG9yeSAvdG1wLgpbICBPSyAgXSBGaW5p
c2hlZCBMb2FkIEtlcm5lbCBNb2R1bGUgY29uZmlnZnMuClsgIE9LICBdIEZpbmlzaGVkIExvYWQg
S2VybmVsIE1vZHVsZSBkcm0uClsgIE9LICBdIEZpbmlzaGVkIExvYWQgS2VybmVsIE1vZHVsZSBm
dXNlLgpbRkFJTEVEXSBGYWlsZWQgdG8gc3RhcnQgTG9hZCBLZXJuZWwgTW9kdWxlcy4KU2VlICdz
eXN0ZW1jdGwgc3RhdHVzIHN5c3RlbWQtbW9kdWxlcy1sb2FkLnNlcnZpY2UnIGZvciBkZXRhaWxz
LgpbICBPSyAgXSBGaW5pc2hlZCBSZW1vdW50IFJvb3QgYW5kIEtlcm5lbCBGaWxlIFN5c3RlbXMu
CiAgICAgICAgIE1vdW50aW5nIEtlcm5lbCBDb25maWd1cmF0aW9uIEZpbGUgU3lzdGVtLi4uCiAg
ICAgICAgIFN0YXJ0aW5nIEZsdXNoIEpvdXJuYWwgdG8gUGVyc2lzdGVudCBTdG9yYWdlLi4uClsg
ICAzOC45MDQxMTldIHN5c3RlbWQtam91cm5hbGRbMzUxXTogUmVjZWl2ZWQgY2xpZW50IHJlcXVl
c3QgdG8gZmx1c2ggcnVudGltZSBqb3VybmFsLgogICAgICAgICBTdGFydGluZyBBcHBseSBLZXJu
ZWwgVmFyaWFibGVzLi4uCiAgICAgICAgIFN0YXJ0aW5nIENyZWF0ZSBTdGF0aWMgRGV2aWNlIE5v
ZGVzIGluIC9kZXYuLi4KWyAgT0sgIF0gTW91bnRlZCBLZXJuZWwgQ29uZmlndXJhdGlvbiBGaWxl
IFN5c3RlbS4KWyAgT0sgIF0gRmluaXNoZWQgRmx1c2ggSm91cm5hbCB0byBQZXJzaXN0ZW50IFN0
b3JhZ2UuClsgIE9LICBdIEZpbmlzaGVkIEFwcGx5IEtlcm5lbCBWYXJpYWJsZXMuClsgIE9LICBd
IEZpbmlzaGVkIENvbGRwbHVnIEFsbCB1ZGV2IERldmljZXMuClsgIE9LICBdIEZpbmlzaGVkIENy
ZWF0ZSBTdGF0aWMgRGV2aWNlIE5vZGVzIGluIC9kZXYuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0
IFByZXBhcmF0aW9uIGZvciBMb2NhbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIE1vdW50aW5nIC92
YXIvdm9sYXRpbGUuLi4KICAgICAgICAgU3RhcnRpbmcgV2FpdCBmb3IgdWRldiBUbyDigKZwbGV0
ZSBEZXZpY2UgSW5pdGlhbGl6YXRpb24uLi4KICAgICAgICAgU3RhcnRpbmcgUnVsZS1iYXNlZCBN
YW5hZ2XigKZmb3IgRGV2aWNlIEV2ZW50cyBhbmQgRmlsZXMuLi4KWyAgT0sgIF0gTW91bnRlZCAv
dmFyL3ZvbGF0aWxlLgogICAgICAgICBTdGFydGluZyBMb2FkL1NhdmUgUmFuZG9tIFNlZWQuLi4K
WyAgT0sgIF0gU3RhcnRlZCBSdWxlLWJhc2VkIE1hbmFnZXIgZm9yIERldmljZSBFdmVudHMgYW5k
IEZpbGVzLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gTG9hZC9TYXZlIFJGIOKApml0Y2ggU3RhdHVz
IC9kZXYvcmZraWxsIFdhdGNoLgpbICBPSyAgXSBGb3VuZCBkZXZpY2UgU2FuRGlza18zLjJHZW4x
IG1zZG9zLgogICAgICAgICBNb3VudGluZyAvYm9vdC4uLgpbICBPSyAgXSBNb3VudGVkIC9ib290
LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBMb2NhbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIFN0
YXJ0aW5nIENyZWF0ZSBWb2xhdGlsZSBGaWxlcyBhbmQgRGlyZWN0b3JpZXMuLi4KWyAgT0sgIF0g
RmluaXNoZWQgV2FpdCBmb3IgdWRldiBUbyBDb21wbGV0ZSBEZXZpY2UgSW5pdGlhbGl6YXRpb24u
ClsgIE9LICBdIEZpbmlzaGVkIENyZWF0ZSBWb2xhdGlsZSBGaWxlcyBhbmQgRGlyZWN0b3JpZXMu
ClsgIE9LICBdIFN0YXJ0ZWQgSGFyZHdhcmUgUk5HIEVudHJvcHkgR2F0aGVyZXIgRGFlbW9uLgog
ICAgICAgICBTdGFydGluZyBOZXR3b3JrIFRpbWUgU3luY2hyb25pemF0aW9uLi4uCiAgICAgICAg
IFN0YXJ0aW5nIFJlY29yZCBTeXN0ZW0gQm9vdC9TaHV0ZG93biBpbiBVVE1QLi4uClsgIE9LICBd
IEZpbmlzaGVkIFJlY29yZCBTeXN0ZW0gQm9vdC9TaHV0ZG93biBpbiBVVE1QLgpbICBPSyAgXSBT
dGFydGVkIE5ldHdvcmsgVGltZSBTeW5jaHJvbml6YXRpb24uClsgIE9LICBdIFJlYWNoZWQgdGFy
Z2V0IFN5c3RlbSBJbml0aWFsaXphdGlvbi4KWyAgT0sgIF0gU3RhcnRlZCBEYWlseSBDbGVhbnVw
IG9mIFRlbXBvcmFyeSBEaXJlY3Rvcmllcy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU3lzdGVt
IFRpbWUgU2V0LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBUaW1lciBVbml0cy4KWyAgT0sgIF0g
TGlzdGVuaW5nIG9uIEF2YWhpIG1ETlMvRE5TLVNEIFN0YWNrIEFjdGl2YXRpb24gU29ja2V0Lgpb
ICBPSyAgXSBMaXN0ZW5pbmcgb24gRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVzIFNvY2tldC4KICAg
ICAgICAgU3RhcnRpbmcgRG9ja2VyIFNvY2tldCBmb3IgdGhlIEFQSS4uLgogICAgICAgICBTdGFy
dGluZyBzc2hkLnNvY2tldC4uLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gRG9ja2VyIFNvY2tldCBm
b3IgdGhlIEFQSS4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIHNzaGQuc29ja2V0LgpbICBPSyAgXSBS
ZWFjaGVkIHRhcmdldCBTb2NrZXQgVW5pdHMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEJhc2lj
IFN5c3RlbS4KICAgICAgICAgU3RhcnRpbmcgQUNQSSBFdmVudCBEYWVtb24uLi4KWyAgT0sgIF0g
U3RhcnRlZCBLZXJuZWwgTG9nZ2luZyBTZXJ2aWNlLgpbICBPSyAgXSBTdGFydGVkIFN5c3RlbSBM
b2dnaW5nIFNlcnZpY2UuClsgIE9LICBdIFN0YXJ0ZWQgRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVz
LgpbICBPSyAgXSBTdGFydGVkIEdldHR5IG9uIHR0eTEuCiAgICAgICAgIFN0YXJ0aW5nIElQdjYg
UGFja2V0IEZpbHRlcmluZyBGcmFtZXdvcmsuLi4KICAgICAgICAgU3RhcnRpbmcgSVB2NCBQYWNr
ZXQgRmlsdGVyaW5nIEZyYW1ld29yay4uLgogICAgICAgICBTdGFydGluZyBUZWxlcGhvbnkgc2Vy
dmljZS4uLgpbICBPSyAgXSBTdGFydGVkIFNlcmlhbCBHZXR0eSBvbiB0dHlBTUEwLgpbICBPSyAg
XSBSZWFjaGVkIHRhcmdldCBMb2dpbiBQcm9tcHRzLgogICAgICAgICBTdGFydGluZyBVc2VyIExv
Z2luIE1hbmFnZW1lbnQuLi4KICAgICAgICAgU3RhcnRpbmcgT3BlblNTSCBLZXkgR2VuZXJhdGlv
bi4uLgpbICBPSyAgXSBTdGFydGVkIEFDUEkgRXZlbnQgRGFlbW9uLgpbICBPSyAgXSBGaW5pc2hl
ZCBJUHY2IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3JrLgpbICBPSyAgXSBGaW5pc2hlZCBJUHY0
IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3JrLgpbICBPSyAgXSBGaW5pc2hlZCBPcGVuU1NIIEtl
eSBHZW5lcmF0aW9uLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBQcmVwYXJhdGlvbiBmb3IgTmV0
d29yay4KICAgICAgICAgU3RhcnRpbmcgTmV0d29yayBDb25maWd1cmF0aW9uLi4uClsgIE9LICBd
IFN0YXJ0ZWQgVGVsZXBob255IHNlcnZpY2UuClsgIE9LICBdIFN0YXJ0ZWQgVXNlciBMb2dpbiBN
YW5hZ2VtZW50LgpbICBPSyAgXSBTdGFydGVkIE5ldHdvcmsgQ29uZmlndXJhdGlvbi4KICAgICAg
ICAgU3RhcnRpbmcgV2FpdCBmb3IgTmV0d29yayB0byBiZSBDb25maWd1cmVkLi4uCiAgICAgICAg
IFN0YXJ0aW5nIE5ldHdvcmsgTmFtZSBSZXNvbHV0aW9uLi4uClsgIE9LICBdIFN0YXJ0ZWQgTmV0
d29yayBOYW1lIFJlc29sdXRpb24uClsgIE9LICBdIEZpbmlzaGVkIExvYWQvU2F2ZSBSYW5kb20g
U2VlZC4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgTmV0d29yay4KWyAgT0sgIF0gUmVhY2hlZCB0
YXJnZXQgSG9zdCBhbmQgTmV0d29yayBOYW1lIExvb2t1cHMuCiAgICAgICAgIFN0YXJ0aW5nIEF2
YWhpIG1ETlMvRE5TLVNEIFN0YWNrLi4uCiAgICAgICAgIFN0YXJ0aW5nIGNvbnRhaW5lcmQgY29u
dGFpbmVyIHJ1bnRpbWUuLi4KWyAgT0sgIF0gU3RhcnRlZCBBdmFoaSBtRE5TL0ROUy1TRCBTdGFj
ay4KWyAgT0sgIF0gU3RhcnRlZCBjb250YWluZXJkIGNvbnRhaW5lciBydW50aW1lLgpbICBPSyAg
XSBGaW5pc2hlZCBXYWl0IGZvciBOZXR3b3JrIHRvIGJlIENvbmZpZ3VyZWQuClsgIE9LICBdIFJl
YWNoZWQgdGFyZ2V0IE5ldHdvcmsgaXMgT25saW5lLgogICAgICAgICBTdGFydGluZyBMaWdodHdl
aWdodCBLdWJlcm5ldGVzLi4uCgpFV0FPTCAoRWRnZSBXb3JrbG9hZCBBYnN0cmFjdGlvbiBhbmQg
T3JjaGVzdHJhdGlvbiBMYXllcikgdW5zdGFibGUgY29taHBjIHR0eUFNQTAKCmNvbWhwYyBsb2dp
bjogcm9vdApyb290QGNvbWhwYzp+IyAK

--_005_49E3535A56724047AF8605D5597C7019armcom_--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:26:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:26:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308173.523761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoo4-0001Yw-Mg; Tue, 19 Apr 2022 14:26:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308173.523761; Tue, 19 Apr 2022 14:26:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoo4-0001Yp-He; Tue, 19 Apr 2022 14:26:16 +0000
Received: by outflank-mailman (input) for mailman id 308173;
 Tue, 19 Apr 2022 14:26:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngoo3-0001Yj-6Z
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:26:15 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9dc1f1af-bfec-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 16:25:54 +0200 (CEST)
Received: from mail-mw2nam08lp2171.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 10:25:55 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BYAPR03MB4808.namprd03.prod.outlook.com (2603:10b6:a03:137::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 14:25:53 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022
 14:25:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9dc1f1af-bfec-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650378358;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=E1/McT8rCeGGCPtHkVKInE6GXMkxR9fg9F7EF0SmErE=;
  b=WdM5slQ0nYyZoGqv5013G8H22dH7sw15mKI9FBPcfJaSXO38bMin/bYt
   Hh5exvRkzVrcebumFGuZ0121nGKff3KohxBH4wP+Jd8SeIuYGzG6njas4
   vciM64HYZ/XENGY3EyXPuV2ng8EaVKTicBbb5Xog7RQOkGhKHAvSJo44x
   g=;
X-IronPort-RemoteIP: 104.47.73.171
X-IronPort-MID: 71836638
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:z2k1rqM1xcdf3XTvrR01lsFynXyQoLVcMsEvi/4bfWQNrUol0zwHx
 mVLCm6BOK6NY2qjLdB1Pty/o00C7MfRzNc3SQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl298w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 dRC6LOaYDYQZIrsgNRAAiVyEQ9vBPgTkFPHCSDXXc276WTjKyep5so0SUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB5GtaaHPyiCdxwhV/cguhnG/rEa
 tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2IB+AnL+/Fni4TV5B5w+7TqLYPXQNvQY9VolVaE9
 mDW3XusV3n2M/Tak1Jp6EmEnuLTkDnpcIMUGqex+vNjjBuU3GN7IBQTXgrlieKjgUD4Xd9DQ
 2QW4i0vqKI1+WSxQ9X9VgH+q3mB1jYMC4R4EOAg7gyJjK3O7G6xAmkCUy4Ea9E8ssIybSIl2
 0XPnN7zAzFr9rqPRhq1872Zqz6pETMINmJEbj1sZQEC+dj45oYokgjIUM1gAYaylNT+HTy2y
 DePxAA8iK8UltUjzLig8BbMhDfEjoPSUgc/6wHTX2SkxgB0foioY8qv81ezxeZNKsOVQ0eMu
 FAAmtOC96YeAJeVjiuPTe4RWraz6J643Cb0hFduG9wk6G6r8nv7LYRIumghfQFuL9oOfiLvb
 AnLowRN6ZRPPXysK6hqf4a2DMdsxq/lfTj4as3pghN1SsAZXGe6EOtGPCZ8A0iFfJAQrJwC
IronPort-HdrOrdr: A9a23:2e4LV6+By//r7KHiRNBuk+GBdr1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79
 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6
 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1cjegIK5Y1n3X
 nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3bRY0eTFcZcso+5zXQISdKUmREXeR
 730lEd1vFImjbsl6eO0ELQMkfboW4TAjTZuCKlaDPY0LDErXQBeot8bMtiA2XkAwBLhqAC7I
 tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOJ1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+
 uzUagmdsPeEQ==
X-IronPort-AV: E=Sophos;i="5.90,272,1643691600"; 
   d="scan'208";a="71836638"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BmtZxo/EjEurIGkSSmPA4n6k1QksYHWwVBrvlR2nOqVrfNZU651ed3/jYo7VMqvQCD4CEZ7Q3V8xPp+0qFmgFapZw4quOxKvsN27bBbTvc1ZIj1IfhShkLdqsOLvLtpPnyOXvkA5xPJbJ2TgGlH0odUw1HyP1znlNcOGRwLLU8yOTNSYdq0wXBKRl/1D1P6iTvG8XR8P0bUd6sAcaYjSqBdPE9opYD2oB7DSGrDDsMnPBHn3V8ZsdR79+G/XCpEcG1rbGK83hyZAN2NAOxsfY5aGdWoosQkl28P8SJf8ad+0MCG9W2CrkQ+VwwKrqsjxcVMBXD16AjyWZgWfYA9DLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E1/McT8rCeGGCPtHkVKInE6GXMkxR9fg9F7EF0SmErE=;
 b=OjWWKS/6mfBDVJsb3+9yQDceYBEEVqlSF6+dIZtTpE5jpAKtR634NMsJl967wr5LK9dOMOUs0AdJT4BEvy1Z66OBCZtQP0qQYb8YUoGKjV55c+qFzpgqkpuyiH436X3BIgkkHHCWQsVyinHzsWzawAZzYr7Um8Nistel6GCiID/lAbK8RqSMDrPblhb+1MTidRcqNs26gK8PE6vTYCu0R1UnsPqSoPFvgFagp16cS0pnawcqstBLorzrv7reOEq/okFq7sRrTL85PA0Mu87i4pxJSko8idgRzs/Bb5PonlthrbslAGx+UdNTnvNOE2rE8EjJfTLBicIWv7qUu7tfgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E1/McT8rCeGGCPtHkVKInE6GXMkxR9fg9F7EF0SmErE=;
 b=D5ulUtPJaLyEEUU8gyqUqQYdVNPqQiFhXc19+q/f0PYpVeBBEUkXbkxs4L6ZR2FepGD6bJNutcaT6JwxDoJU7htB7gTy0X8rbhj9Uq5caiD0Vq19Y2JGhee+XKns5Q7Obe09rt8APfZ8vg0DPsD/S2jtwPjA3+mpAwQu4VOGjL8=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Peter Zijlstra <peterz@infradead.org>, Andrew Cooper <amc96@srcf.net>
CC: Josh Poimboeuf <jpoimboe@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Miroslav Benes
	<mbenes@suse.cz>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Thread-Topic: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
Thread-Index: AQHYU0SHTqWJMApeME+vJqcoJU7NiKz3HnsAgAAET4CAAAQVAIAAEEaAgAAVEAA=
Date: Tue, 19 Apr 2022 14:25:53 +0000
Message-ID: <77cad36d-0b02-cb30-496a-e7738ad52206@citrix.com>
References: <cover.1650300597.git.jpoimboe@redhat.com>
 <a87bd48b06d11ec4b98122a429e71e489b4e48c3.1650300597.git.jpoimboe@redhat.com>
 <b94cbac6-0a4d-8e4a-ec58-bbd46e385d45@citrix.com>
 <20220419115737.GU2731@worktop.programming.kicks-ass.net>
 <8fbbd4ca-54b1-8c1c-19bc-3d0e6044ff5d@srcf.net>
 <20220419131029.GV2731@worktop.programming.kicks-ass.net>
In-Reply-To: <20220419131029.GV2731@worktop.programming.kicks-ass.net>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: beea1e34-cebe-45d8-1940-08da221082af
x-ms-traffictypediagnostic: BYAPR03MB4808:EE_
x-microsoft-antispam-prvs:
 <BYAPR03MB4808184702884949E9491C5DBAF29@BYAPR03MB4808.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 hc/eK32nFCvXFtUcq7ctLeEZ+PWtomf83ozh3LLLH0GcCOho1ORHBP4xY3S723soM3nhdQP7PdOGSqAWC25wzKdvoKFXcZWkei2B9HA2Xeq1nhmWQlC4Qxx6d1Y2Q8GmGUBr5Poq5gCtTBCQ1/q6iJdurAiImX9kU28lpNJrx+EHn6Mf/mtabBiq3eRHJgRhr9OvnT+HkDEeJZ7RZmMKajyNFxe3IPqqMZ+RZ+JApBaSoHfLDZsOar6qZPwL3FIN/tWdg6z5mpID2g7P+V3FxaC4xfirvtKMywtFlbariGCS9CxPUVuL+JhSnT5ciEtFf1IAA1a6gIyp6nXESdDiMn9INbgWpPXR3BfsKcnUdGJYfQojQnohS/ipS8YZ3BGmKfWnqToSOUCdw7CqgRSTx+Tp43W4BElDON5M9KW8Jz0ybSgXT/FkBMXSVd90JjbHephWb6Ij9SApnIMHXC7zAB8V/NCmy9+NefP3LcZQWJJf74WTnyCHcPU/AtuGY4BWGTnIfPmd5gKiVMnPbtG11NITDc2c6tAzUfpalboi7Su8Yt32W8rriawFPtmV1unWmbh9CwUYMdno72ROgrkRHgMkfj6WrD18vLL1VF8QxJs6yHbcD7nfRi5Y0/Is38Udpo5NNLp8wBhn1kxJ8vACPZHf2jFkNzcOsCvKAobpQ6by61oxhU7buKKysU11zOM7j3f7AVICrD1RjPfoMDlthGayY7zqTZyn4b6t2gNHYMzjcNZgAvBo1eUoi593gyPKopWnypxmlNWiv0iSJh0Hp1pObKGATFEZvZu7UbdIFgt9LKo7hwhk9bRFRlatfOJxruAvtye4rb9wTuiCVAGk+rxt8lI1ARy5RQ6RqQaPJG4=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(82960400001)(2906002)(66556008)(8936002)(6506007)(6486002)(38070700005)(966005)(316002)(508600001)(4326008)(31696002)(64756008)(66446008)(86362001)(66476007)(6512007)(91956017)(186003)(8676002)(26005)(66946007)(122000001)(38100700002)(53546011)(31686004)(5660300002)(83380400001)(7416002)(36756003)(110136005)(54906003)(2616005)(71200400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bm5ZMWNIMzYyeFl0a2QwaytYYkltdFZmWnNYR2ZqVEllYzlubFVVNG5ZSWta?=
 =?utf-8?B?aHdkUkZHOHB2Q0t4UWNEOTJTSU92VGs1QzNhZG53T1loWjliaEZycE9tQ2ts?=
 =?utf-8?B?VE1HOFI0c2lwODRNaFFrNDRRSndwRVJBT3pzV0ljdU9DNXU0MktKSXBPVUVj?=
 =?utf-8?B?WlR3MWNScldCN1R0a3Fiem82YXhsWE5DeVQzQUc1T2NXdnM1YWtkUndtVnUx?=
 =?utf-8?B?ZjlDZGJVVmRDbXNJRGVka1ZpUnBtZTNENDdMalZvMkpUbTFsdGloR0Jldi80?=
 =?utf-8?B?VlZPaXcrSS9qNjRidVVOU2NoNnR3Yjh3TjlIQ0x4TnBURjB0aE8vR2hmSG9Q?=
 =?utf-8?B?L1pSRjlGaWdHMDVOZkVkbmVYd2dkZjFXcEwzWjQ1K3JUUmVFMDdVc053bDc4?=
 =?utf-8?B?L2NhTGJYRTNEMHpFUFJDdVV4NUNKY1c5aTJSOEU3a3p4NVphenpHV3kxMVVm?=
 =?utf-8?B?QVFlSXFROVIrSWRBSFFncldabEFaSi8yTVpmWW9adFFjQ3p0cXEvNzlsT0Zs?=
 =?utf-8?B?QjNZNi8rMDNyZkpiUVVhQmM2SzJ2VnJXSzlkaE5DemFDa084RkRtQTUyUU5D?=
 =?utf-8?B?NUd2cmZ6amFzQkN2ZERPaGRLUERabmQ5MFRyU2VveWhpSW0vSGlEOGxqQTNs?=
 =?utf-8?B?NGxBSWVYVGtuMGNRRTZRVCtMNjVKV2loUU5tTlUxMG1QUHdSUWowL0tmSTA4?=
 =?utf-8?B?QVU0akZrN1YyeldkNzBvSTFsTVpSQWhxVERkdWVlZkZoWExJblVlVmZpQnZr?=
 =?utf-8?B?WXFGYVhmOEE2TERsa29vTk5tTlJESGRUMWozK0theGZwaXdsZ2hQcGxxQVVZ?=
 =?utf-8?B?N3ZXaVFwSXVPWTF1Wk9GdG02clM1aXg5UDJlSXBJSWtRTzd1QXF2a3ZKYmVU?=
 =?utf-8?B?WGREcEQvM3R4a2N1Y01wbHUxODFseW4vVml6OWxBMU4wV1NpYlhPayt3cEs1?=
 =?utf-8?B?YllFc0hwc2ZLbGFBTEVNandobW5aUlcyMVJkS3RwUWg1S2xDd3ovWkkwNGVx?=
 =?utf-8?B?M00yMzV5SkpTUzV2NW5xMkJ6dUNsMy94L0lhSnkxZTErRWR2U0ZwMUFjck84?=
 =?utf-8?B?eVhZQ2l5djNyUUliZHhvcEZFN21wdjRDbWkrMEhycU5rZExwV09hZjZSN1lX?=
 =?utf-8?B?MnpMV3Vwbm16ZXVFV0YzSnh5dkthb0t5ZHdwa2EvZ0o4RWZDV2NkbFIwVUNM?=
 =?utf-8?B?NTNQb0xFVnc2MUhiOGFCREkwM1p1VE5mQVN4RmtiNE1UUzlQKzU5bWNJSWxG?=
 =?utf-8?B?M3FSRys4Yk5DZWZjTDMxUHlMWnlrRHpoT2ZmME5XTkh6R3hHMXFEb3k3dkNt?=
 =?utf-8?B?N2E5S2xFa1dqQWhmbUZZOEV3R0c3S2FBYWxmZGZmTnBmZGx0UTlQZE5DSjQ2?=
 =?utf-8?B?Mm1kMzdBSXJQd0NZaUIrUDVSYjZZRTZNYXpSK0RrcFRiLy83WHZtMWdRSkJt?=
 =?utf-8?B?WUpNaGx0U2VYdUxuUjFpN1ZCcUVVa25qVmRlNjlZMHc2U0ppZlFxK3dWbjQ2?=
 =?utf-8?B?c2p6TWlWTEsrZnE3NktDNXBvTjBKTklYSGk3RW1rcldiL0kvUUM0UGw0Ri8v?=
 =?utf-8?B?eEtwMlVFendvMHZIa0wwNUdaT1pxbzVYb2Vwa0JlSmVRd1FFdlRueEk1aTJ5?=
 =?utf-8?B?aXhvTTRqcGtUMENJMU4xS08waUMwZVM5eHd2UklWazh0Z2xVOXMrSS9DTEVx?=
 =?utf-8?B?RWNiTUNZU0xKTmQwY0Y4NXBNclFtcWtpUGszYy8xUlNCanhuS0xCeVVaVDZW?=
 =?utf-8?B?clRYNEhWWkFLOTVRdy9LRXFJNG45bUh5Qm91MGk5WDU4ODlnQ1F5UVZwbDdz?=
 =?utf-8?B?UFQ1VHd6dVYwakFDcW0yL0ZPT2lsTkUrV2NOb1hqR2hzMEprL1g5cUMwVzN6?=
 =?utf-8?B?c29VV1VEZUtuYzh5WWJkVXBLRWlQclZHKytSVnhTY2NWSjJGejJOc2ZENno3?=
 =?utf-8?B?RDMvTE1RSi96eUxKUElZY2VYZ3M0K2VzUDVNRUJxblRGTXd4SC9zbWh3b2xF?=
 =?utf-8?B?aDdEZnZkTzBwRk5yang2R01FbitlK01GV1prVWdDYzQ1L1I3LzUrK2tXbDNp?=
 =?utf-8?B?WXVnRTJOUWEvRHhHQUZkRW5Vd3RwVGZsWmNYem95dmR5OWozSWtCL3J1bUVY?=
 =?utf-8?B?b00zQzhjYktEZS8xR0R3OEU0UzM3eWNXNyt2NmRqRENTN0tqallaZkRkbE9R?=
 =?utf-8?B?QUREQ3dJbkl6cVNYOUZqRTNHaEhBZXUwNEJiSGMzak82VWhsVC82ZU9uV2Vj?=
 =?utf-8?B?V21QdklwZExLdUtJTUdld0xUR3VyQ3Y3L2J5TFNuL1dvbVpJWkYrVjZWejlk?=
 =?utf-8?B?bWY3ZmVBWmtuQ3M5V2VZallLTk1zb0RLYVBvTExqMXpKZXc1SVZodz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0FD537FC682F1D45B594F73A9BCE5FB4@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: beea1e34-cebe-45d8-1940-08da221082af
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 14:25:53.2587
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YSiIyinfF9msLJxN1gxCmxxFRN2kmUhbbCtTHy9+ztnG6pcmLEjXbwNpjMT5q9DmayqvE7+HrTEUV4fofnuKOvDX3mnSCoY83sVQNEJpMuA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4808

T24gMTkvMDQvMjAyMiAxNDoxMCwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6DQo+IE9uIFR1ZSwgQXBy
IDE5LCAyMDIyIGF0IDAxOjEyOjE0UE0gKzAxMDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+DQo+
Pj4gU3ViamVjdDogeDg2L3hlbjogQWRkIEFOTk9UQVRFX0VOREJSIHRvIHN0YXJ0dXBfeGVuKCkN
Cj4+PiBGcm9tOiBKb3NoIFBvaW1ib2V1ZiA8anBvaW1ib2VAcmVkaGF0LmNvbT4NCj4+PiBEYXRl
OiBNb24sIDE4IEFwciAyMDIyIDA5OjUwOjI1IC0wNzAwDQo+Pj4NCj4+PiBGcm9tOiBKb3NoIFBv
aW1ib2V1ZiA8anBvaW1ib2VAcmVkaGF0LmNvbT4NCj4+Pg0KPj4+IFRoZSBzdGFydHVwX3hlbigp
IGtlcm5lbCBlbnRyeSBwb2ludCBpcyByZWZlcmVuY2VkIGJ5IHRoZSAiLm5vdGUuWGVuIg0KPj4+
IHNlY3Rpb24sIGFuZCBpcyB0aGUgcmVhbCBlbnRyeSBwb2ludCBvZiB0aGUgVk0uIEl0ICp3aWxs
KiBiZQ0KPj4+IGluZGlyZWN0bHkgYnJhbmNoZWQgdG8sICpob3dldmVyKiBjdXJyZW50bHkgWGVu
IGRvZXNuJ3Qgc3VwcG9ydCBQViBWTQ0KPj4+IHdpdGggQ0VUIGFjdGl2ZS4NCj4+IFRlY2huaWNh
bGx5IGl0J3MgYWx3YXlzIElSRVQnZCB0bywgYnV0IHRoZSBwb2ludCBpcyB0aGF0IGl0J3MgbmV2
ZXINCj4+ICJicmFuY2hlZCB0byIgYnkgdGhlIGV4ZWN1dGlvbiBjb250ZXh0IG9mIHRoZSBWTS4N
Cj4+DQo+PiBTbyBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gc2F5IHRoYXQgaXQncyBuZXZlciBpbmRp
cmVjdGx5IGJyYW5jaGVkIHRvLsKgDQo+PiBUaGF0J3Mgd2hhdCB0aGUgSUJUIGNoZWNrcyBjYXJl
IGFib3V0Lg0KPiBSaWdodCwgc28gSSB3YXMgdGhpbmtpbmcgdGhlIElSRVQgY291bGQgc2V0IHRo
ZSBORUVEX0VOREJSIGJpdCwgYnV0DQo+IHllYWgsIHRoYXQgbWlnaHQgYmUgc3RyZXRjaGluZyB0
aGUgZGVmaW5pdGlvbiBvZiBhbiBpbmRpcmVjdC1icmFuY2ggYQ0KPiB3ZWUgYml0Lg0KPg0KPiBI
b3cgYWJvdXQgc28gdGhlbj8NCj4NCj4gLS0tDQo+IFN1YmplY3Q6IHg4Ni94ZW46IEFkZCBBTk5P
VEFURV9OT0VOREJSIHRvIHN0YXJ0dXBfeGVuKCkNCj4gRnJvbTogSm9zaCBQb2ltYm9ldWYgPGpw
b2ltYm9lQHJlZGhhdC5jb20+DQo+IERhdGU6IE1vbiwgMTggQXByIDIwMjIgMDk6NTA6MjUgLTA3
MDANCj4NCj4gRnJvbTogSm9zaCBQb2ltYm9ldWYgPGpwb2ltYm9lQHJlZGhhdC5jb20+DQo+DQo+
IFRoZSBzdGFydHVwX3hlbigpIGtlcm5lbCBlbnRyeSBwb2ludCBpcyByZWZlcmVuY2VkIGJ5IHRo
ZSAiLm5vdGUuWGVuIg0KPiBzZWN0aW9uLCBhbmQgaXMgdGhlIHJlYWwgZW50cnkgcG9pbnQgb2Yg
dGhlIFZNLiBDb250cm9sIHRyYW5zZmVyIGlzDQo+IHRocm91Z2ggSVJFVCwgd2hpY2ggKmNvdWxk
KiBzZXQgTkVFRF9FTkRCUiwgaG93ZXZlciBYZW4gY3VycmVudGx5IGRvZXMNCj4gbm8gc3VjaCB0
aGluZy4NCj4NCj4gQWRkIEFOTk9UQVRFX05PRU5EQlIgdG8gc2lsZW5jZSBmdXR1cmUgb2JqdG9v
bCB3YXJuaW5ncy4NCj4NCj4gRml4ZXM6IGVkNTNhMGQ5NzE5MiAoIng4Ni9hbHRlcm5hdGl2ZTog
VXNlIC5pYnRfZW5kYnJfc2VhbCB0byBzZWFsIGluZGlyZWN0IGNhbGxzIikNCj4gU2lnbmVkLW9m
Zi1ieTogSm9zaCBQb2ltYm9ldWYgPGpwb2ltYm9lQHJlZGhhdC5jb20+DQo+IFNpZ25lZC1vZmYt
Ynk6IFBldGVyIFppamxzdHJhIChJbnRlbCkgPHBldGVyekBpbmZyYWRlYWQub3JnPg0KPiBSZXZp
ZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gTGlu
azogaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci9hODdiZDQ4YjA2ZDExZWM0Yjk4MTIyYTQyOWU3
MWU0ODliNGU0OGMzLjE2NTAzMDA1OTcuZ2l0Lmpwb2ltYm9lQHJlZGhhdC5jb20NCg0KTEdUTS4N
Cg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:26:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:26:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308175.523771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngood-00022n-VC; Tue, 19 Apr 2022 14:26:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308175.523771; Tue, 19 Apr 2022 14:26:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngood-00022g-SF; Tue, 19 Apr 2022 14:26:51 +0000
Received: by outflank-mailman (input) for mailman id 308175;
 Tue, 19 Apr 2022 14:26:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cMjw=U5=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ngooc-0001yb-UC
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:26:51 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0624.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::624])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c024b541-bfec-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 16:26:50 +0200 (CEST)
Received: from AS8PR04CA0105.eurprd04.prod.outlook.com (2603:10a6:20b:31e::20)
 by AM5PR0802MB2545.eurprd08.prod.outlook.com (2603:10a6:203:a2::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 14:26:46 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:31e:cafe::18) by AS8PR04CA0105.outlook.office365.com
 (2603:10a6:20b:31e::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Tue, 19 Apr 2022 14:26:46 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 14:26:46 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Tue, 19 Apr 2022 14:26:45 +0000
Received: from afb58c3190ac.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E1717C65-320B-469C-AA32-0004BE83CD94.1; 
 Tue, 19 Apr 2022 14:26:34 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id afb58c3190ac.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Apr 2022 14:26:34 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB3894.eurprd08.prod.outlook.com (2603:10a6:20b:90::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Tue, 19 Apr
 2022 14:26:30 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 14:26:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c024b541-bfec-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R/sEm9IIohiWWXKc+yqBbYPbZNzTeBD8jFU4kUTx/Ik=;
 b=peL/kQBBfTsagiMaBk6KHyIFQYKJCGzhMI/vivaotWuX0gGzJ7MvLHzxKAPA1sv2pQbqpys7ajaVll3Duf+IU7ol6L1HVSB/wLuB/BSejC2hMn95tpJxLKMFVxvSdbF2gIOfWJR28wI++rFBmL/3BqlhpwYv2bseVHBuBJOk1DU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5568e7a29f7c7e4d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JgE0lnNIU5GaCQiL+RDrRaVlB4zMeXCJQEyMG0759/uJzT3hwQRkEbThK2VxQuwuND7HaFaT62cxkkOuFXAcWVXbzYruZDy8n0y9E5/JyfU2UUrjZjREAZi5EH+twBmsf8NE5DGjo4sofZuPaieIQuyNkVxGtZGaNZhRGAKL5qyrzfQVxBIuy5DHb8xgWoQ7vifq/RL05djiDjM5dvC+dUzVmMP+CRdrx55DP2VwsL1HzisX1aNn/4MerHIqYm9ir3ZYgIiIhfsBPpgxfNPLWUz7yEIHDEag+nRxr+qf5SSMjiApd46V5E8P+5nTL+p33WtIOsRhhuRJX5pZEfw2sQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R/sEm9IIohiWWXKc+yqBbYPbZNzTeBD8jFU4kUTx/Ik=;
 b=MxckrjQO4Ptz42F6LZar1tRc9CFj9EpfvO3jj+6xBTM2ZiFz6a+g2rWjKwc8IvV/NjzTwBXNg2TUMuMg90KosbuYrZoDT/tCnT7UY1US+J3hHtaZza0PahsIEQ74Ha/wuhQEQeVS17Fjxx1t5KGv68Sj793PB7OJ3LhljA69V8tYHfKw39JMgJNdVsARrTDrkOdOCSbwgDG2vO6GH/zFetfDUnhamOp2mDh3OKN+o8ZUwwpnuWSfaDeheLKFaFijlTAziM/krZZUZ5YdH3mlT0a5VhaRcCNbUxRS+ZkJVBIUNk5Kd3h7k3uiy14W/8UMbZZ/eNvED+Y31KDmYZgStg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R/sEm9IIohiWWXKc+yqBbYPbZNzTeBD8jFU4kUTx/Ik=;
 b=peL/kQBBfTsagiMaBk6KHyIFQYKJCGzhMI/vivaotWuX0gGzJ7MvLHzxKAPA1sv2pQbqpys7ajaVll3Duf+IU7ol6L1HVSB/wLuB/BSejC2hMn95tpJxLKMFVxvSdbF2gIOfWJR28wI++rFBmL/3BqlhpwYv2bseVHBuBJOk1DU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Michal Orzel
	<Michal.Orzel@arm.com>
Subject: Re: [PATCH v2] xen/build: Add cppcheck and cppcheck-html make rules
Thread-Topic: [PATCH v2] xen/build: Add cppcheck and cppcheck-html make rules
Thread-Index: AQHYTzgLTKPDa7AQGEehVzKugb9ky6zxpoUAgAWt9AA=
Date: Tue, 19 Apr 2022 14:26:29 +0000
Message-ID: <D2065054-201D-4C4D-B96E-AEE6A00C594A@arm.com>
References:
 <74b35aab0706fc977a3c5c3dfa20b52fda6f4698.1649855186.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2204151637350.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204151637350.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: be302828-f50d-4a0a-ba91-08da2210a237
x-ms-traffictypediagnostic:
	AM6PR08MB3894:EE_|VE1EUR03FT044:EE_|AM5PR0802MB2545:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0802MB254586902118E732E3E69B039DF29@AM5PR0802MB2545.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 szMEG2Z2uD/BcyJO+KuSpJrMWpTnKRfVxL+DHMh9csBJQP7BluPI0Ys8+VoLMVmSPrZLp9+VhR6bhybEItiSWPea1qEmP3yskCkvdCYKWKL8TXKZPv3kObwmIdS+u5y+Y12LaTaD3eHedUrYgY/tY2a2bZSGxnT9U/5k8exmjMSs5j5WPPB6N7oF3ur3xyiE3vCQ/8T9FxBqQbJck/JMNa3dW3cj/L++6KKIz1MgSCB4cSM/GHX70zv1jqF0E4EuJyjhT0SYgUEJoKZLTn3ogzfpdCOAvAUL/EnjFvgiWI2fEj9SvHPuiJ5hpe/1O7n2DCuNnihpXiliELr+W5G4lwUX1x9DDlR8BWTgsMC6TmrQNciutcX6cbZl7Z373fzxt7BDpGcXPmDz13ti9UL/GGy/F4Li/nt625f/rjS4aTqN4NTOttfV2H+Gfl6bneJ5h467MLW4m2AtlhjoG32KCGTXHOdzcXenYP3YRfm+AO6SxuvtzGtUOoSdc7EvEeVWt7r/KuCBtTrbVJSCvoZny82b4KhLDknSe2or9haCocMbQ8JsN0Vo6fXCtJuFZyYi4nf//3qAVa2UoJcHVYNYfF7872N6oY4frikJ2T69P+J1a2C+ofXHCWOEffdeigyCCBSZReGopqUEpA0NLK+5Nk6FwAP1u8edXxbsKPowpkTBc9MqK7XEZX8sSPGaCL/H+x9mrqEljnBzRU0VuY8RZ3azVtnUiejaG0X488x8JOFWv21Aa258i/1Cao4gbpFgeL7yPB5nn3CbzWSOuF7ZmEPuS/8NAEm8NHEW8LAlT37AaZG857zpkCVzoJE0JbFr
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(6916009)(316002)(30864003)(38070700005)(6486002)(38100700002)(86362001)(508600001)(6512007)(122000001)(91956017)(6506007)(5660300002)(8676002)(53546011)(2906002)(66446008)(66476007)(64756008)(66946007)(76116006)(966005)(4326008)(8936002)(66574015)(33656002)(2616005)(186003)(26005)(83380400001)(66556008)(36756003)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E7F2516F4D9A064F979B54011FDC08A8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3894
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7ecd619a-cb94-4ac7-6708-08da22109870
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	njSo3Fuz5H4ltcfwM4sCM8NEI3nO9ksiwN6XoAJAYtIs3POvjqloeMnil6z/hODRFeR/OKtYr7NA6citFIhrIBIYw8lp/OZ40JLl3La3ww3jLbtnS2OifFH0Wu7at38Dt2EP6P8L5LGfADxtS7hIC8Q0n4RMR9QNz9VEyXs5s32zFQdDXwBHGJ5AdfOM7G1selUaWkFPFdTLRFlI7rWMTgfNCYvwgiYdTbsLoXYCWXktr6ldwfBm0ggSXyk7lVASgRC2eh0AFvKtcrJoiAr3f2mK8yfNcAt//20IDSTTIpARYPNG66RaEUUk0vo9M4BQKMao3dD2AWDFLRzSMKgwLzHIBteh8BXAks5pKrlBK2RGwZMe4csGDa3nP/w9CH1uwqh9OQeZYQNG0Z9Q4dFgVej5CeP6q51JWfNgKGG0Xmey77vVaRpOvYWtr3GNHboeILPrHyGVaW4r92RXw3BdYlOXWnrwEAuGlN4ShUdIkIKSIviBH/E9RAArug9p8mgYUjEd38e25nJ0uVapAtF53EkX5OC743tV4K8baE/kLOa/jIODy0VuxVK8U/UQvOWUh88no7PtkrFOCPbab+m8k5n/qaf25cYulUZOaZ7e+CpzhK+LkExDpYolrpKBRrp/XaeZSGK9pFFgk3k5HY3esDSQvCCPSgSkFFL6pkNJTPn74Gg2/8U2rjnSYOw09HxrrR85ynoJemHXJXTXW1hAs3OWEQkLbI5eyCloVp9K3HDdXsfSIKvKmCyZ9SDX82klxh2Zog4wy2q+HIVGLLxT4g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(356005)(316002)(8676002)(6862004)(4326008)(2906002)(186003)(33656002)(36756003)(30864003)(70206006)(70586007)(36860700001)(83380400001)(40460700003)(8936002)(5660300002)(81166007)(508600001)(86362001)(6512007)(82310400005)(66574015)(336012)(2616005)(54906003)(47076005)(53546011)(26005)(966005)(6486002)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 14:26:46.1246
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: be302828-f50d-4a0a-ba91-08da2210a237
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2545

Hi Stefano,

> On 16 Apr 2022, at 00:42, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Wed, 13 Apr 2022, Bertrand Marquis wrote:
>> cppcheck can be used to check Xen code quality.
>>=20
>> To create a report do "make cppcheck" on a built tree adding any options
>> you added during the process you used to build xen (like CROSS_COMPILE
>> or XEN_TARGET_ARCH). This will generate an xml report xen-cppcheck.xml.
>>=20
>> To create a html report do "make cppcheck-html" in the same way and a
>> full report to be seen in a browser will be generated in
>> cppcheck-htmlreport/index.html.
>>=20
>> For better results it is recommended to build your own cppcheck from the
>> latest sources that you can find at [1].
>> Development and result analysis has been done with cppcheck 2.7.
>>=20
>> The Makefile rule is searching for all C files which have been compiled
>> (ie which have a generated .o file) and is running cppcheck on all of
>> them using the current configuration of xen so only the code actually
>> compiled is checked.
>>=20
>> A new tool is introduced to merge all cppcheck reports into one global
>> report including all findings and removing duplicates.
>>=20
>> Some extra variables can be used to customize the report:
>> - CPPCHECK can be used to give the full path to the cppcheck binary to
>> use (default is to use the one from the standard path).
>> - CPPCHECK_HTMLREPORT can be used to give the full path to
>> cppcheck-htmlreport (default is to use the one from the standard path).
>>=20
>> This has been tested on several arm configurations (x86 should work but
>> has not been tested).
>>=20
>> [1] https://cppcheck.sourceforge.io/
>>=20
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>=20
> This is better, thanks! I don't have a lot of comments as it looks
> pretty OK to me already. Only one comment on the python script.
>=20
>=20
>> ---
>> Changes in v2:
>> - catch parsing errors during merge and tell the user to update cppcheck
>> - fix alignments in Makefile
>> - use srctree and objtree instead of BASEDIR
>> - remove SCTLR invalid change
>> - add a check of cppcheck version and mandate version 2.7 or greater
>> - rework the merge script to make it faster and display progress
>> ---
>> .gitignore                           |  3 +
>> xen/Makefile                         | 84 +++++++++++++++++++++++++++-
>> xen/arch/arm/include/asm/processor.h |  2 +
>> xen/include/xen/config.h             |  4 ++
>> xen/include/xen/kconfig.h            |  5 ++
>> xen/tools/merge_cppcheck_reports.py  | 83 +++++++++++++++++++++++++++
>> 6 files changed, 179 insertions(+), 2 deletions(-)
>> create mode 100755 xen/tools/merge_cppcheck_reports.py
>>=20
>> diff --git a/.gitignore b/.gitignore
>> index d425be4bd9..0d2d60b8f1 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -7,6 +7,7 @@
>> *.o
>> *.d
>> *.d2
>> +*.c.cppcheck
>> *.opic
>> *.a
>> *.so
>> @@ -296,6 +297,7 @@ xen/.banner
>> xen/.config
>> xen/.config.old
>> xen/.xen.elf32
>> +xen/xen-cppcheck.xml
>> xen/System.map
>> xen/arch/x86/boot/mkelf32
>> xen/arch/x86/boot/cmdline.S
>> @@ -316,6 +318,7 @@ xen/arch/*/efi/runtime.c
>> xen/arch/*/include/asm/asm-offsets.h
>> xen/common/config_data.S
>> xen/common/config.gz
>> +xen/cppcheck-htmlreport
>> xen/include/headers*.chk
>> xen/include/compat/*
>> xen/include/config/
>> diff --git a/xen/Makefile b/xen/Makefile
>> index ebc7854c08..734f9f2b4f 100644
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -335,7 +335,7 @@ export CFLAGS_UBSAN
>>=20
>> endif # need-config
>>=20
>> -main-targets :=3D build install uninstall clean distclean MAP
>> +main-targets :=3D build install uninstall clean distclean MAP cppcheck =
cppcheck-html
>> .PHONY: $(main-targets)
>> ifneq ($(XEN_TARGET_ARCH),x86_32)
>> $(main-targets): %: _% ;
>> @@ -423,15 +423,17 @@ _clean:
>> 	$(Q)$(MAKE) $(clean)=3Dtools/kconfig
>> 	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
>> 		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
>> -		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
>> +		-o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \
>> 		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {}=
 \;
>> 	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.ma=
p $(TARGET)-syms $(TARGET)-syms.map
>> 	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
>> 	rm -f .banner .allconfig.tmp include/xen/compile.h
>> +	rm -f xen-cppcheck.xml
>>=20
>> .PHONY: _distclean
>> _distclean: clean
>> 	rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTA=
GS GPATH GRTAGS GSYMS .config
>> +	rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR)
>>=20
>> $(TARGET).gz: $(TARGET)
>> 	gzip -n -f -9 < $< > $@.new
>> @@ -505,6 +507,84 @@ cloc:
>> 	    done; \
>> 	done | cloc --list-file=3D-
>>=20
>> +# What cppcheck command to use.
>> +# To get proper results, it is recommended to build cppcheck manually f=
rom the
>> +# latest source and use CPPCHECK to give the full path to the built ver=
sion.
>> +CPPCHECK ?=3D cppcheck
>> +
>> +# What cppcheck-htmlreport to use.
>> +# If you give the full path to a self compiled cppcheck, this should be=
 set
>> +# to the full path to cppcheck-html in the htmlreport directory of cppc=
heck.
>> +# On recent distribution, this is available in the standard path.
>> +CPPCHECK_HTMLREPORT ?=3D cppcheck-htmlreport
>> +
>> +# By default we generate the report in cppcheck-htmlreport directory in=
 the
>> +# build directory. This can be changed by giving a directory in this va=
riable.
>> +CPPCHECK_HTMLREPORT_OUTDIR ?=3D cppcheck-htmlreport
>> +
>> +# Compile flags to pass to cppcheck:
>> +# - include directories and defines Xen Makefile is passing (from CFLAG=
S)
>> +# - include config.h as this is passed directly to the compiler.
>> +# - define CPPCHECK as we use to disable or enable some specific part o=
f the
>> +#   code to solve some cppcheck issues.
>> +# - explicitely enable some cppcheck checks as we do not want to use "a=
ll"
>> +#   which includes unusedFunction which gives wrong positives as we che=
ck file
>> +#   per file.
>> +#
>> +# Compiler defines are in compiler-def.h which is included in config.h
>> +#
>> +CPPCHECKFLAGS :=3D -DCPPCHECK --max-ctu-depth=3D10 \
>> +                 --enable=3Dstyle,information,missingInclude \
>> +                 --include=3D$(srctree)/include/xen/config.h \
>> +                 -I $(srctree)/xsm/flask/include \
>> +                 -I $(srctree)/include/xen/libfdt \
>> +                 $(filter -D% -I%,$(CFLAGS))
>> +
>> +# We need to find all C files (as we are not checking assembly files) s=
o
>> +# we find all generated .o files which have a .c corresponding file.
>> +CPPCHECKFILES :=3D $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c,=
 \
>> +                 $(filter-out $(objtree)/tools/%, \
>> +                 $(shell find $(objtree) -name "*.o"))))
>> +
>> +quiet_cmd_cppcheck_xml =3D CPPCHECK $(patsubst $(srctree)/%,%,$<)
>> +cmd_cppcheck_xml =3D $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \
>> +                   --output-file=3D$@ $<
>> +
>> +quiet_cmd_merge_cppcheck_reports =3D CPPCHECK-MERGE $@
>> +cmd_merge_cppcheck_reports =3D $(srctree)/tools/merge_cppcheck_reports.=
py $^ $@
>> +
>> +quiet_cmd_cppcheck_html =3D CPPCHECK-HTML $<
>> +cmd_cppcheck_html =3D $(CPPCHECK_HTMLREPORT) --file=3D$< --source-dir=
=3D$(srctree) \
>> +                    --report-dir=3D$(CPPCHECK_HTMLREPORT_OUTDIR) --titl=
e=3DXen
>> +
>> +PHONY +=3D _cppcheck _cppcheck-html cppcheck-version
>> +
>> +_cppcheck-html: xen-cppcheck.xml
>> +	$(call if_changed,cppcheck_html)
>> +
>> +_cppcheck: xen-cppcheck.xml
>> +
>> +xen-cppcheck.xml: $(patsubst $(srctree)/%.c,$(objtree)/%.c.cppcheck,$(C=
PPCHECKFILES))
>> +ifeq ($(CPPCHECKFILES),)
>> +	$(error Please build Xen before running cppcheck)
>> +endif
>> +	$(call if_changed,merge_cppcheck_reports)
>> +
>> +$(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/au=
toconf.h $(objtree)/include/generated/compiler-def.h | cppcheck-version
>> +	$(call if_changed,cppcheck_xml)
>> +
>> +cppcheck-version:
>> +ifeq ($(shell which $(CPPCHECK)),)
>> +	$(error Cannot find cppcheck executable: $(CPPCHECK))
>> +endif
>> +ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1)
>> +	$(error Please upgrade your cppcheck to version 2.7 or greater)
>> +endif
>> +
>> +# Put this in generated headers this way it is cleaned by include/Makef=
ile
>> +$(objtree)/include/generated/compiler-def.h:
>> +	$(Q)$(CC) -dM -E -o $@ - < /dev/null
>> +
>> endif #config-build
>>=20
>> PHONY +=3D FORCE
>> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include=
/asm/processor.h
>> index 852b5f3c24..ef37cfa16f 100644
>> --- a/xen/arch/arm/include/asm/processor.h
>> +++ b/xen/arch/arm/include/asm/processor.h
>> @@ -219,9 +219,11 @@
>>                          SCTLR_Axx_ELx_A    | SCTLR_Axx_ELx_C   |\
>>                          SCTLR_Axx_ELx_WXN  | SCTLR_Axx_ELx_EE)
>>=20
>> +#ifndef CPPCHECK
>> #if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) !=3D 0xffffffffffffffffUL
>> #error "Inconsistent SCTLR_EL2 set/clear bits"
>> #endif
>> +#endif
>>=20
>> #endif
>>=20
>> diff --git a/xen/include/xen/config.h b/xen/include/xen/config.h
>> index 85c6f59be9..d888b2314d 100644
>> --- a/xen/include/xen/config.h
>> +++ b/xen/include/xen/config.h
>> @@ -7,6 +7,10 @@
>> #ifndef __XEN_CONFIG_H__
>> #define __XEN_CONFIG_H__
>>=20
>> +#ifdef CPPCHECK
>> +#include <generated/compiler-def.h>
>> +#endif
>> +
>> #include <xen/kconfig.h>
>>=20
>> #ifndef __ASSEMBLY__
>> diff --git a/xen/include/xen/kconfig.h b/xen/include/xen/kconfig.h
>> index 4d58c5bb3c..a717b0819c 100644
>> --- a/xen/include/xen/kconfig.h
>> +++ b/xen/include/xen/kconfig.h
>> @@ -8,6 +8,10 @@
>>  * these only work with boolean option.
>>  */
>>=20
>> +/* cppcheck is failing to parse the macro so use a dummy one */
>> +#ifdef CPPCHECK
>> +#define IS_ENABLED(option) option
>> +#else
>> /*
>>  * Getting something that works in C and CPP for an arg that may or may
>>  * not be defined is tricky.  Here, if we have "#define CONFIG_BOOGER 1"
>> @@ -27,5 +31,6 @@
>>  * otherwise.
>>  */
>> #define IS_ENABLED(option) config_enabled(option)
>> +#endif
>>=20
>> #endif /* __XEN_KCONFIG_H */
>> diff --git a/xen/tools/merge_cppcheck_reports.py b/xen/tools/merge_cppch=
eck_reports.py
>> new file mode 100755
>> index 0000000000..eabf558768
>> --- /dev/null
>> +++ b/xen/tools/merge_cppcheck_reports.py
>> @@ -0,0 +1,83 @@
>> +#!/usr/bin/env python
>> +
>> +"""
>> +This script acts as a tool to merge XML files created by cppcheck.
>> +Usage:
>> +    merge_cppcheck_reports.py [FILES] [OUTPUT]
>> +
>> +    FILES  - list of XML files with extension .cppcheck
>> +    OUTPUT - file to store results (with .xml extension).
>> +             If not specified, the script will print results to stdout.
>> +"""
>> +
>> +import sys
>> +from xml.etree import ElementTree
>> +
>> +def elements_equal(el1, el2):
>> +    if type(el1) !=3D type(el2): return False
>> +
>> +    el1_location =3D str(el1.find('location').attrib)
>> +    el2_location =3D str(el2.find('location').attrib)
>=20
> I managed to repro another stacktrace:
>=20
>  CPPCHECK-MERGE xen-cppcheck.xml
> 123 / 191Traceback (most recent call last):
>  File "./tools/merge_cppcheck_reports.py", line 83, in <module>
>    run()
>  File "./tools/merge_cppcheck_reports.py", line 72, in run
>    result =3D merge(files)
>  File "./tools/merge_cppcheck_reports.py", line 53, in merge
>    if not contain_element(xml_error_elem, curr_elem_list):
>  File "./tools/merge_cppcheck_reports.py", line 28, in contain_element
>    if elements_equal(new, elem):
>  File "./tools/merge_cppcheck_reports.py", line 19, in elements_equal
>    el1_location =3D str(el1.find('location').attrib)
> AttributeError: 'NoneType' object has no attribute 'attrib'
> make: *** [Makefile:685: xen-cppcheck.xml] Error 1
>=20
> It must be a natural talent :-)
>=20
> Should we have a try/except also here as well?
>=20
> FYI I added:
>=20
>    if el1.find('location') is None: return False
>    if el2.find('location') is None: return False
>=20
> And that solved the issue for me

You are very talented to trigger the errors (I do not have any on my side).
Anyway I will include this and make the try/except to catch any kind of err=
ors in v3.

Thanks a lot for the deep testing :-)

Cheers
Bertrand



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:31:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:31:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308185.523783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngotJ-0003as-N3; Tue, 19 Apr 2022 14:31:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308185.523783; Tue, 19 Apr 2022 14:31:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngotJ-0003al-JJ; Tue, 19 Apr 2022 14:31:41 +0000
Received: by outflank-mailman (input) for mailman id 308185;
 Tue, 19 Apr 2022 14:31:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngotI-0003ab-Ep; Tue, 19 Apr 2022 14:31:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngotI-0008Ri-DH; Tue, 19 Apr 2022 14:31:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngotH-0002mm-TW; Tue, 19 Apr 2022 14:31:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngotH-0001nc-T6; Tue, 19 Apr 2022 14:31:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ys3NvzAM5vJstoOpRx8nOAWSWWSlTyCbvF3lkq08bRI=; b=frLisla/2AV2UvOH889lZ2lxSA
	HUd246f5DKoLc9XhpMh4vS+18NSNcSL+v5paKJMNdL2Xs8Ke14giyvAFQATx0HTNS03Cm33U0jthB
	EmdFyBwrxrcm1MR2wqAGJiBB7ePlQjw4Hfbt0NEMpphX8tMSm6QDnYL3tmqPu6nMPJbc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169542-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169542: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 14:31:39 +0000

flight 169542 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169542/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  507 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:32:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:32:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308192.523794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngouG-0004Hy-2e; Tue, 19 Apr 2022 14:32:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308192.523794; Tue, 19 Apr 2022 14:32:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngouF-0004Hq-Uf; Tue, 19 Apr 2022 14:32:39 +0000
Received: by outflank-mailman (input) for mailman id 308192;
 Tue, 19 Apr 2022 14:32:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngouE-0004Hj-MU
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:32:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c9badde-bfed-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 16:32:33 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-Qvogej9ONy6io9_vhd0jdA-1; Tue, 19 Apr 2022 16:32:32 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR04MB2968.eurprd04.prod.outlook.com (2603:10a6:6:b::15) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.13; Tue, 19 Apr 2022 14:32:30 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 14:32:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c9badde-bfed-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650378757;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jyUVBA/RyGgqAt0kBQqMaTjuuJfYNowncXU9CRendHQ=;
	b=VT2iDfKDk21HXuacDhBOnA5r4UYrAaESayWaPiXAQcK5t+SfLf8tgS6Ixjgdb80NOIfLx4
	qnmvIXnirJ2YheT5NWMNuP1f7E1czmq9WssxF1jg66YNvcyR6Bo1aKo8BNOMwICNPKTmF1
	dfwfhc6mrtg1bHGNCNA98H0eFqmAZUU=
X-MC-Unique: Qvogej9ONy6io9_vhd0jdA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TiA+V9aLCeIjoOnVMT8Nfg/XJVQEM26ZJyWbEQB+oBZQTfoNUaFO47ibe12FsJ4sfLxOT4dQYqeK260Pd0JFZOj0NDLvBcSqAXaX+6cpU/xOusavWEofIi9OIUQ4Jo9IzdFCUhn6YOQYblCKs2HQ3msOPmxviyHdfc1to0WEybP9FRu7lMalcsSDzp786QHchI0CJlAaZXon9ykM0MirZIWtNuv2pwUGiX8oUwscz3SRNYCFeaNEW5B+lCDrjdCI0wbWR75YCvkRNrPYfShDWzMHpz6kuLs2o+EEnn3xiX2vA4DbsRegzUQ1v+YT6K6217L8PJTBqA0GjzUlppZfGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jyUVBA/RyGgqAt0kBQqMaTjuuJfYNowncXU9CRendHQ=;
 b=YbL0imiQDFtW8pQdOGJnyMk4wvMrqxLt2rTQRGYeHhzGHlHhgcCkvW12rGHywkp3+aT9KNTmoRxM/kxcCo6ag3VRz7Fitf7kzMDprV64NgtaX1NMUYeGJUeVNaobBs0jesdLUysDca+69lvYutbdaBOr6zLyZMl1yuuYfJ7JVam5dlufvVRvXOEfX2huTo2wd8FysHeMYgKxzTAvG1FxzwBjCklxa4+VOd7o11517HFNnkMLPAi+a0ek9yL8EMW8hcFdQ0laC4/aMtdDbdnPbLJMsP44QJIqTFmDJ93mBXFCDSTPILp4FGc1+hQN+hWrHW8MOBFNizFHS42uVjIHUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ff76eeb4-33fc-e427-9e38-fbe151256828@suse.com>
Date: Tue, 19 Apr 2022 16:32:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 1/3] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>, xen-devel@lists.xenproject.org
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-2-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220419135254.21729-2-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0563.eurprd06.prod.outlook.com
 (2603:10a6:20b:485::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b6ff747b-f9cd-4cb3-a3f2-08da22116f41
X-MS-TrafficTypeDiagnostic: DB6PR04MB2968:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB2968BB822C5996D65BDF5724B3F29@DB6PR04MB2968.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N8GnYS4ez+9bBlvNMqq7ixxD2q7U97rqadeNkKEAuZNVcKhdUij9lwWufIynixt8hE8Bpkc/VXWOp7SJVvh3CtFMey1so6AymS0inKDKhuv0cs1GV8F8M3+dveWLjsJtvMctAE3mj/bkV5QmkRDtiGGiHLEAkIemVyHW3EIVuHN/n0dbBQzGGKvYnEIWCYl2SHfaJPM9CumgMh67WZ+NusPUAcvWS5R122wwYu+AR9z9r+JqUPggMrnurr+vl8OB59MFmmgurkfbXUq1cnyjx7YWp2EM+UZNj897eBnJLqwztJ62bCLu6wsmFaOqnV1YAbK/HEPylGWzDI3MHMdqRNnaxinTJtJJRpL7+crTbRhI8hbMfTqd4UrIu64IY14Jd1XPiy53SaRDQFQGaYCikeINGb20JggrWS2ZywL24PZz6tJyfNGuZjJmruxPyT9lGapqpKG/5ODpVHdzm8xbT+7l7zICneXpqYg4KUogtca3/24jqLTWHeBM9bpdhQZ3vPwCj3WmBUMRCELDYE727/zVSHpAOjZFXxeU9GYDZcSkXUwEMZE/Gx5T728PVwVJz/BjuheC0mo2y4FEhKlWlphEhN37HR2GtnILU6+9oxZe9KgOCt9UYdhefavj0K2N/L46ZWM4kiqto/g9sJ5i94nSs9d1a6XGp2M69l0ms9+kYa0B4ofpptQBxUwNko4DbfifvlZ5KfRu6m3BqFiraqivcofHJSS6ynDdi5qQllI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6506007)(26005)(6512007)(37006003)(36756003)(53546011)(54906003)(2906002)(316002)(66946007)(38100700002)(4326008)(66556008)(6636002)(6486002)(508600001)(8676002)(5660300002)(66476007)(31686004)(2616005)(186003)(86362001)(31696002)(6862004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cjFIV05Id0ZxL1RBTXNHS24yWEh6cHF6ZXRqSk5uTWJ4MmpBYWlUT0pMZFNV?=
 =?utf-8?B?RW5Ca0x4Y3p6Y3hPSnRqNGliWjdnZ1dlZzMyV0ZMOTFySno2dUJBbE5MVTVh?=
 =?utf-8?B?bWVpUDVxOHpibmNqcWpxM1Nxb3RmTVVNeldybTJDdTBtY2VuYzgyMnJxN1Ri?=
 =?utf-8?B?YmtWcFBSaHRlRDBJTG9vRDBMSXllNjEyaGY0SVhrSGpLKzB3OXBHTVU4UlZ1?=
 =?utf-8?B?cC9XemhVOUZhZ2VqTkJTY3RZdDByeEJoT1pkRGtYYndONXo1VWtHRk9FVmNM?=
 =?utf-8?B?eFIzYVNHU2JkYTYzemM2TXNJRTBJN01nYjFrOWM2VTN1Nm96ZlVacmVJRzJT?=
 =?utf-8?B?VGZyS005Z0V1NnNkZUFKTVk2U0ExQytYRFo2WjdYM1Z1RVE4b3lYektSTElL?=
 =?utf-8?B?QkszdFYzVGZiRFY1OHdrN2JIbGJRR2FlVTFRZU1NMndya1pENFZpR0JXUW9w?=
 =?utf-8?B?UGdnMi9pUmxzYkxyL0laOXBsNTk1dEdUVHUrdzdVNHA1M1pNSWV0QVEyOU1u?=
 =?utf-8?B?MWdQNjBTOEpQS1UvT0c3RUQ2aXhLdU8xYnMwMUJEK0JyMUNyNFFjVjJtVHdn?=
 =?utf-8?B?dVMvRzNKa3hYVWdmU0dVbjVmVERzRkpJR3MzTU5qSkZGT1FlVVhsdmhhdXdj?=
 =?utf-8?B?ZUJJOGFNU3JmRDJNYXhkaGVRRVgvVjRzREhoNlozb3JrajRaQnF5d3kzTCtI?=
 =?utf-8?B?VndnWkRRdGt3T2hSKzNNOHlDSUxCYzBzdGdoRWVxTzdRR0xuKy9TZGxPTC9M?=
 =?utf-8?B?Tms1NjNmL0lvZStoSHV0NXZLRngvaElEK1lJNXRpQXNoRUNwNjZkWVNwOHJE?=
 =?utf-8?B?eGt5eDdScWw2dHgrVW85eHNLQnNtdlJCeUg3SHFFenR4cCtZVEVXNEo0MDNm?=
 =?utf-8?B?RzM5WXNTeGpGcm9RVlBnN083K3gzU1ZiVDJtSDAzUGN0Nk9xekw1SFNjNzVk?=
 =?utf-8?B?NEFRUjE4WjZXVHYxYWIvMVR0c0lLaWM4VWxueVZiSmh4QUtJdUFsVWdZNE1C?=
 =?utf-8?B?ODArcGhqdlBzTFJUb0h5dmc5aUhZSjRBSVM3aC9oTXczV3YxWkRKNjRzL2dK?=
 =?utf-8?B?bjNyOE5sV0pXc0RTb28xNGVzNGtxUWw4TTZ1S0lzY3l4ZkNEdTYzcmthVS9Y?=
 =?utf-8?B?cVNTRmdPU2xKVW8rSFNEbDlZS3NRc051a0Z0aHdOZUdldGoxRlk1YmlLdnN1?=
 =?utf-8?B?a2RoQW9CRVNkM21ZRDQ2MjBaNDI1d1crbWZ4eDZab01EU2VaazBkQkpxcDhs?=
 =?utf-8?B?Q1pXQllZZTl0WCt5a1REaHZrQ1JLV0hBdXJKNmhaazMxbUE0ZHRLRm9ScDlU?=
 =?utf-8?B?WmVpc2xoYkpnVERuSFkrcmpyamJFMXlNNzRmaXVjME5ObFl0S2RIUTc4eGdt?=
 =?utf-8?B?WjdDZnp5eW05MFVTWFF4b2h5K3F2ZnIyY2VNcFViNGdsRnB3MWErKzJWaXVX?=
 =?utf-8?B?SngxeXR2dm1mN01uSzhuMVMrVUJGak1NNm84Vi8zSFV5eEMwRVRQK2xDenNG?=
 =?utf-8?B?RUsvN1Fyd0VoL3ZyRXppRkZlQ2pyeDZPMG1PYlVYckdaaUt2Q0ZvUURWZ3o5?=
 =?utf-8?B?YlFNZFZJWllhUkxJSTB4MkZNVExhcEdRb1JmTk9zUE0rc2UwdVpEdWlBSER2?=
 =?utf-8?B?eE4vU2lZdjcweHRuSmlQVzE4OVQ3aXFnTkdHaUpESGRlVUNNdm9vd3k0dTVB?=
 =?utf-8?B?dE5YSzIvQ0ZqZ3d1cDcvQnJlQzVNMEdJZzBidy9KalRmNTlTQ0xmRUQwS29j?=
 =?utf-8?B?dW5FenlpSERpQWdVSHZhOGswN1FFM0p6VWwrOWpnUkR1Z255VGlxaU9IYnhu?=
 =?utf-8?B?WGszVFpPcHU4dmQrdkFlVm1ma3FxT29BRjExTGRWazBLVGwrRWNmUjRpUjBq?=
 =?utf-8?B?OHVKL2Z5dDYrd3pKczBLbzhIQUlPR0FJWS9yS2JnRW02Y1czYjhuTTdLdlls?=
 =?utf-8?B?MG1oRnRpdU9IOEFrb1FyTEpJVmdWeHR1cTVZNzc1TTllenIxM1Q0Y1dqQkNv?=
 =?utf-8?B?aG9MaTJVMlU3U1NvdlBvQStFc1BsZUQ5OWQ2bUhjcHpTbHU3Q2o3NmRaRnd0?=
 =?utf-8?B?U3dUQmJYamZjTnFSaU5mby9Sanp1d0NSVXNnSDRqWWFpNzZaUVZOREpYUFg3?=
 =?utf-8?B?eTJlbFdZRHZybUZUSHV3RWpwTHNEQ2NtanZYN0tLazdQOWJ0YVgrNFNVVnV3?=
 =?utf-8?B?TSsxWmh2L2dWREFoeDZNSlR0NE5ERjFTczl3eDJkckdpK3BOQkhrYkpRUEpp?=
 =?utf-8?B?ZWJjL2dEdHVMUXlrd0gxRHJCRXdhZ2x3Y1k2Y2F4M1RDZUIxOWhHSDRvQy9i?=
 =?utf-8?B?bHh5VDhOTTJGWlhCekh1ODJUNjdva1R2cWFUOUp3MzlPOGVUWE93Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6ff747b-f9cd-4cb3-a3f2-08da22116f41
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 14:32:30.3801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6ZZatglzvElbDzmbfkwCqWSbnBDpj62OS/xkCpil7dntueSJBHF5jHMlVpTkY5ri3Yhg5g4tpoepEh1N9f7G7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB2968

On 19.04.2022 15:52, Juergen Gross wrote:
> A hypervisor built without CONFIG_GDBSX will crash in case the
> XEN_DOMCTL_gdbsx_guestmemio domctl is being called, as the call will
> end up in iommu_do_domctl() with d == NULL:
> 
> (XEN) CPU:    6
> (XEN) RIP:    e008:[<ffff82d040269984>] iommu_do_domctl+0x4/0x30
> (XEN) RFLAGS: 0000000000010202   CONTEXT: hypervisor (d0v0)
> (XEN) rax: 00000000000003e8   rbx: ffff830856277ef8   rcx: ffff830856277fff
> ...
> (XEN) Xen call trace:
> (XEN)    [<ffff82d040269984>] R iommu_do_domctl+0x4/0x30
> (XEN)    [<ffff82d04035cd5f>] S arch_do_domctl+0x7f/0x2330
> (XEN)    [<ffff82d040239e46>] S do_domctl+0xe56/0x1930
> (XEN)    [<ffff82d040238ff0>] S do_domctl+0/0x1930
> (XEN)    [<ffff82d0402f8c59>] S pv_hypercall+0x99/0x110
> (XEN)    [<ffff82d0402f5161>] S arch/x86/pv/domain.c#_toggle_guest_pt+0x11/0x90
> (XEN)    [<ffff82d040366288>] S lstar_enter+0x128/0x130
> (XEN)
> (XEN) Pagetable walk from 0000000000000144:
> (XEN)  L4[0x000] = 0000000000000000 ffffffffffffffff
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 6:
> (XEN) FATAL PAGE FAULT
> (XEN) [error_code=0000]
> (XEN) Faulting linear address: 0000000000000144
> 
> Fix this issue by making sure the domain pointer has a sane value.
> 
> Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
> Fixes: e726a82ca0dc ("xen: make gdbsx support configurable")
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:33:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:33:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308195.523805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngour-0004pB-Bl; Tue, 19 Apr 2022 14:33:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308195.523805; Tue, 19 Apr 2022 14:33:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngour-0004p4-7r; Tue, 19 Apr 2022 14:33:17 +0000
Received: by outflank-mailman (input) for mailman id 308195;
 Tue, 19 Apr 2022 14:33:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngoup-0004nY-Ti
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:33:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99a68a4b-bfed-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 16:32:55 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-u_huJRDpNjGtcGAcch6UuQ-1; Tue, 19 Apr 2022 16:32:53 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR04MB2968.eurprd04.prod.outlook.com (2603:10a6:6:b::15) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.13; Tue, 19 Apr 2022 14:32:52 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 14:32:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99a68a4b-bfed-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650378774;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wNoTc6Lxd1UaM4Rgoa/wAPOPcVvuByaA/Ul5UoBxyKk=;
	b=GQw5Yqsv8sz5/d5u36HiIxUzVf/4RYw5xogK9alRgKc1LMQdMlvrn1A04B/4xPsRDJVXL9
	q4bDdcLH8Qiztxs+LILmYPfyi3a8oBJeFPzRQznKp2ihGgku8PbvVniOgG/l64AXXjTkys
	x7XzCYSitVLxX/91KJA0wNZm+4JAVsU=
X-MC-Unique: u_huJRDpNjGtcGAcch6UuQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AZ98zdCdpoF5sgO4ayPf31Hp4CjiWJ1FxsklNlhFhUP+aPWQ+NSYD6EjBMnRXjsixaVBh1VAdo7YPmeBk9n2OkBgfL1gQz6TxuuIe30hV6h/JTuNCrQvS01ISZ8+aopVsV4lufV4xMu4Ztk6VwuH/SojJ4E6qUwfhu3FImaq7umRqzj52j7GFhL/TcmfzYQmMUE3q2VOlxyrUeSAV3VNzpDVMl9udPrAbfqBrKk9XwDsfU7TaV32wAFRZyUaLV13JkHlzetTTvqetNB0QVeuTWsTpj8Sy6eG2XftK4ueh4niVhM7BGXTlrj8Ep+U6xt+B91gASvaj1sbXleQ4Xrxag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wNoTc6Lxd1UaM4Rgoa/wAPOPcVvuByaA/Ul5UoBxyKk=;
 b=Vg+gg+WXB35ATm9HbD2lcjz3EdM3NE1okbb8fwQQt7VSNA5mbXx5G6z1gY2YDLV2IQ0m5t3Ll/0s/ZnKYpSkg1z//Ox/fMRnOKIkGCZZ3n38tpxi2yfyf4FsvlnYkudq8JcLudZGRk/0dnEE8j21EzJOlFXLqNq3YCrgZGqRqGlsi96OQsWYDxqOOv4vvZ448cYRAAwg4V2+h8zNaNBX6IsVUVIJQNR38BFpHXIcqj5o401jxvJsxyKYpTXNbEeRDBBqDZxZA5nctDzw2tZWuGkiv7GVZ2KbQLdu253a5QRzvadVyGGVYr2hWRrsiKUJcnUqWWvhf7fqCKs+vB2NxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1b6b0f0f-795f-d37e-6f59-e6946872361d@suse.com>
Date: Tue, 19 Apr 2022 16:32:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 2/3] xen: cleanup gdbsx_guest_mem_io() call
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-3-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220419135254.21729-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0546.eurprd06.prod.outlook.com
 (2603:10a6:20b:485::7) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 251b928f-6cd9-44eb-dab3-08da22117bfd
X-MS-TrafficTypeDiagnostic: DB6PR04MB2968:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB2968942994C7823496EC164AB3F29@DB6PR04MB2968.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UdexMZWeWzAoNGPOtUFJmie0UFHvcbf54ONilb6zECJL6CquEL+9hBaoObE8IrPQNL+nEWNs1RwiVAGyPaskP686KULoKSXExwWa81sKEiJDuG9ZA0xJQp+6KB4LcRcQJN9A3FVBHJD8gWLsUAGKQWk3esvVL5Pys4311RC1ZBX/NYJdF5QfIGxx3VwUDf8fbDs4ULPUgpdfnL/G3hX9Lekd/tQFmXdswCq0lgo8NyBHKJRDAO8wK0Q3NK76jjO61SWV35Zgi5iQAwS1ikLWny4xHCP5JI1sHkVxqsBYsAVZHEzG8jdkvP4ZRfTxkITUmt2W/HOwlGN4VblrGQWt3M3oh/Ti8bQOGpmmG8XP8/I3inlGBmYmGTA2QVWKP1uslD7RgItG43IjJRJPnf62i4yMI7Q0wvl6jTTF8TEwIP32CTjW1EgZtiaMxbfXZxhsUiaEwDNOVW3UhIeABc5Inkhp+l+KXIM1MZEaaXXQJZ9sHe6eAH4gLmB2eDSV/bsgR4mkc9J3JfT3RBMK0CglPO9dOtoO8K9BrSbbGUiI2IvV2B6LoRmgyDyfpIRAEkMscRz2SVKFPvNSnHw3/n7hpw+qoDq8BHzTzmuhZ0aPxbDgtFtzhqhj9ebNirNg0F5KJRCkmA3ZrY/YPqsXM3i0ZhmtF/MJgYqpeGwvwQHKG57G57QpeQGSaf4Y/QTjZIfYUQ3LSDQfEu5ECKzAumDQRTAdpx+Idq4Tjwn7Pk24z6RWkk4PvTXI3DkuqGuBvp/K
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6506007)(4744005)(26005)(6512007)(37006003)(36756003)(53546011)(54906003)(2906002)(316002)(66946007)(38100700002)(4326008)(66556008)(6636002)(6486002)(508600001)(8676002)(5660300002)(66476007)(31686004)(2616005)(186003)(86362001)(31696002)(6862004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VmRGQkhidEZaTGpCRXVCVDRyaGVqMmsxaTFkSzh5NEFzdnBWRm1QR0RvSUhC?=
 =?utf-8?B?NFFLc2JNNUhXcWFYMk0yQjUwc2JHOTN1Z2xJcjhRNmU3TlJDQWZwMlUwWFZh?=
 =?utf-8?B?UElTVjE3dHV3eDQ0QVN0SEdvNWNJdU1mNTRXdENzTy9paU9vMDgweGtyVGxz?=
 =?utf-8?B?TUgyeUhyZXhzY3NORlNraGt3anFZa09xVFl4MVE2ZG5lVjBQellPemxvbC9I?=
 =?utf-8?B?OS9lN0FRWjVEbUlqaTQ1WEkwZ0NTZVlKcnR2eURxSzRTQm4waUJINFRYS3Rj?=
 =?utf-8?B?WTEyWnJXMTcvR1RFVHdnUzFkM0JSZWpMNEF1NjdWMzhhY3ZPSWxDOEdCeldr?=
 =?utf-8?B?RXZaRThSeEFjWXZ4ZTVuaThibnRGbDlmS2lvYjFKRndYUTQ3dHB3cFkvck5t?=
 =?utf-8?B?aFo1Y08xUFdobmJsK0NGeE5tSktLRlVuNzZNZ2FHdHFOTm5xbkZsVFFLL1pR?=
 =?utf-8?B?NmttMXNKUitJdUZRSGdpU1gxM21EWHh0ZUJJTFJqK1IwamdQRWw0T1JGMHFP?=
 =?utf-8?B?cDgyKyt0QTI1cjVvQWxZa290bkNvS0RaZnlla2o3bkpJUGVxTnhUNlRUNll6?=
 =?utf-8?B?ZGxRd1FETVVSS25SY1pJQUhNYk8zWlJnR2l5WnYwUzNkUUVtR1owRmZrTXN0?=
 =?utf-8?B?c3psY0JSR1VmQXo4YUJYOXlOWjkyMEx1alNmSUsvK2JEMTB0Y1cvSXU0SXNU?=
 =?utf-8?B?cU52NDErUjZGbnZTWUlacjN6RnY3YXllVUNnOGN4T0w0ZGlLMGNncHBRL2dG?=
 =?utf-8?B?VmJpY1JwNEpOUFM4YlBJckFhRUdpTmJBMVM0ajJycURjY2ZZNkJSYi9nbTIx?=
 =?utf-8?B?Zys5cW1sVXJqRzQrRnIzNGNkbDlnR0RXeWRMeXhOSXBzdS84VHpKMkhGZURM?=
 =?utf-8?B?dG4vNFZ0cThCdzQzZ3Z1b3RwWFB4blVLL0xKdmVvMlkxVTdpZmwxK1hCejYx?=
 =?utf-8?B?a1MyWnpma2VkWThlcUpoMy9CZ1UxQVl6R09sdTMvUkdpd3dnRUlXQzdkbkk1?=
 =?utf-8?B?NkVBaDlPaUIyTE9MZ2F5a2FtTysyTEV1VkJrZ2lkd3cyLzVyV2NMYmFaQzM5?=
 =?utf-8?B?Y3JVVEozalQ5aTQySml0WXFFSWt6VVpuYW5jTXViVm43blRhL2c0RnRWd3Vv?=
 =?utf-8?B?Y0hWYno3VmNuZU83U2pydW84cExwcmExQ1dYbUtadnFnN2RhazN6bWpOSUt2?=
 =?utf-8?B?blRZOFBmbG5KZ3pkMGQvb0ZNZVFGc0VUSkR1YlErNUZ5azE3VWduUHErNEFm?=
 =?utf-8?B?ODlNOHVjODdTWktuYTBIclZEaHJYZWt6YjJCZWJaSHU3NlNNMTNJQjdxQyts?=
 =?utf-8?B?bXBXK3BhdkxiUkovZk5hejVqb0EwUHNNTjJKeS9VOWFIZkxnSVF6c1ZQbHda?=
 =?utf-8?B?Y1l6ZE5KNHNBQ3dlL2tjVVpnYlJJd3k4eHc0cmh4UEI1TzQ0S2FxWXM0dEpw?=
 =?utf-8?B?M3V5aUJSeWdlYTlJRXlscGtlb3RoVS9jYTJZMDdzbDF0blg1WS9JaWpPK1hZ?=
 =?utf-8?B?TG1xelFuU0dLcEpld0dJcGtYQ1NxNnlYOXdwWWZlM0M3cnRJY2VrMUdISm5m?=
 =?utf-8?B?aWkyYTV5VkQvaDNtekZOUU9leGM0b09hVkhGdXhDVXZUbmVMZjhLN1hGZFhS?=
 =?utf-8?B?L2xDVXkzVjA1cG01NWJQaGpPMXR5aFlMOVk5KytjVXQxamppVEZuaktpOVFp?=
 =?utf-8?B?SGs5bmZSb0d3SW1BanNDMzZuRFhoR3JnNVNUendLdlBWMDYzeGpYdlE2U3I1?=
 =?utf-8?B?VllvNzhtU1ZmZ21rTE1tb1BnMjJsMnArSFB4aDMyY1oraU1BY0xGYVRFOHFI?=
 =?utf-8?B?TUNoc3hSVXFSMmFUMnNZZGExUXZCamxrMjFtczltaVlKdFpIODZveFFtWmpG?=
 =?utf-8?B?eGxqQXNFNXhSeDZDbFd3VzArb3hYN1RGejFLdnI4NlViRHMxL0I0aDU4b21j?=
 =?utf-8?B?c3RNamJRdDJWVjlFUS9HY091NitvaGhyUWdHdlo3aG1kaUpSUk1MNFliV0hW?=
 =?utf-8?B?d2FKVFdJL0ZOMHNYelZqWFR5eWxFSHVkVFc2VEZLTkZJQ2h5TDBvRG9ReXlO?=
 =?utf-8?B?cStzeEVZV2RpRnJ2TjRpRGFYQ3hHck5scEpzZ3VmVHRrRmh1eHduOFlLb1pJ?=
 =?utf-8?B?VHM4cXkzb0s0WGNNTGt1enBrdHNnL0d2R0RWSVBMMGlyaEM4UjRxT1BrRE51?=
 =?utf-8?B?NkoraVNpeTRNYUJ0RWg5dnVIQXZCaDBoaEpqdmZYait1M3IxUEhjY1FNLzFO?=
 =?utf-8?B?UEFvRTc3U1BsblVQWDhFeHBNdzViVStyaFBheW92QjNuUWtDaXZWaEUwc3ly?=
 =?utf-8?B?ZWVHMkRPYXNPVEFvOEZxY1o5SmNGOXh1ekdoZzRrVTNTT0Y0ZXZLdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 251b928f-6cd9-44eb-dab3-08da22117bfd
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 14:32:51.7931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6tQaBvBdkWQ7gdbS8qzl3BjVz+7kvvP/F6fhDfM5neLl9IAzvvgekN8I2O/GSovQu9pJR9HyDaAVz6OFSdy9nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB2968

On 19.04.2022 15:52, Juergen Gross wrote:
> Modify the gdbsx_guest_mem_io() interface to take the already known
> domain pointer as parameter instead of the domid. This enables to
> remove some more code further down the call tree.
> 
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:37:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:37:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308204.523816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoyc-0005c5-1Z; Tue, 19 Apr 2022 14:37:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308204.523816; Tue, 19 Apr 2022 14:37:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngoyb-0005by-Uj; Tue, 19 Apr 2022 14:37:09 +0000
Received: by outflank-mailman (input) for mailman id 308204;
 Tue, 19 Apr 2022 14:37:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngoyb-0005bs-5c
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:37:09 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c8b6995-bfee-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 16:37:02 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 10:37:04 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BY5PR03MB5153.namprd03.prod.outlook.com (2603:10b6:a03:22c::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 14:37:02 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022
 14:37:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c8b6995-bfee-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650379027;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=t2VtGFmwRPmuqTfnbDl0Am+3sZbzCgD4fvum6MSiFWI=;
  b=iPbFq30/pDMJBR5W2SIi4XLzFLsMPlt4gjwcJCrIByfjIH9iZcGuJaZh
   YnI7yYiDoGJoo+IbwE6l6irUUXE9nIlDPSjjWNwjHGV8hA6GqRDUTkacz
   WiuAO8QrbUPPbFSVK/wDD790all3+oTWG6wNI6DTIi6Qbm5WegKyvv8Qq
   I=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 69432854
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:E8QKBavyminSV4S50LzMegGZP+fnVJtfMUV32f8akzHdYApBsoF/q
 tZmKW3XOPzeMTDxKth2Ptmw9RsHvcOExoRrTgQ4/HthEisQ+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/U6
 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi94O6TDhLRMeiVeEmZGIY532JzgLiKG5Jn7I03uKxMAwt1IJWRvZ8g9xbwyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4EGmmts7ixNNa+2i
 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJpsjSIllwsjNABNvKOf/+IGelLw3qkm
 T3XwnbAWS0+NNiQnG/tHnWEw7WncTnAcIAdDrqj7dZxnUaegGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yFaGtBMBX9tbE8Uh9RqAjKHT5m6xBHUATzNHQMwrsokxXzNC/
 kSSg9rjCDhrsbuUYXGQ7LGZqXW1Iyd9BXAGTT8JS00C+daLiIozgwPCSNBuVrG0itnuMT71y
 jGO6iM5gt0uYdUj0qy6+RXCnGiqr52QFAotvF2LAiSi8x9zY5Oja8qw81/H4P1cLYGfCF6co
 HwDnMvY5+cLZX2QqBGwrCw2NOnBz5643Pf02zaDw7FJG+yRxkOe
IronPort-HdrOrdr: A9a23:eXvXOqpFIYelBmAvTHPEak0aV5tyLNV00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcYtKLzOWwldAS7sSorcKogeQVhEWk9Qw6U
 4OSdkYNDSdNzlHZIPBkXGF+rUbsZe6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK
 Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInNy6IZn1V
 KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0WVjcVaKv+/VQIO0aWSAWUR4Z
 7xStAbToJOAkbqDySISN3WqlDdOXgVmiffIBSj8AbeSITCNU4H4ox69MNkm1LimjQdVJsX6t
 M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pXVFZ9l/1owKpuKuZIIMs60vFULM
 B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpT+OUP2nMbsJ4tQZhN4O
 rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOHl7fnpLEuoO26cp0By5U/3J
 zHTVNDrGY3P1njDMWftac7hSwlgF/NKQgF5vsul6SR4IeMNYYDGRfzO2wGgo+nv+gVBNHdVr
 K6JI9WasWTWFfTJQ==
X-IronPort-AV: E=Sophos;i="5.90,272,1643691600"; 
   d="scan'208";a="69432854"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Oj1xJS4eUBQx2Xy4sSOmMDC1YRppBa2nPgxg1T/OlnkDUkcsM1g0C0yrXGl4DoD81ElZ1pljayBRHNR16VZiPjeftbGCGfwibhJbTJ+3ofP5L3Mg9m2WHUnsMS+MjWKYxjRQlowNN7Ys0YrX+673ed+2RB5dZUho2bH3oDnoi6fAUV9B1OPuFk0F03EgNcafVZh61zc1DOafstGNOOg+UCC4O7pXje9ZQnjKary+KL0f/UQh6mBgvRCpxQPxSQjcPC1ugcXeqmLEdnMl5c9b7T2RfyE2n+PbZFUniHcUGm+iqP1SaV2V3nrlwMsxCSbQO12l4YgIb6BuBtvTHPXSMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=t2VtGFmwRPmuqTfnbDl0Am+3sZbzCgD4fvum6MSiFWI=;
 b=ceGyzipaiVHu4ozS5r0uOFbSWOFZSl9RxJH+LFRt+wHFqeVQ9Lpa5+D903LLK4y0cARaXH59jdedlYn/Ghuo0SSF00MBqzU1xxmT8hJ3OI+xHnJrq3Oo+eorQidPeFISfMuYkN03PS/tbH8hIdxpz1g55FZVKyDrItc0zR03Wj1FFsW1kGuB3vdcATIVwwOal0S5Cgzk8aqs/6erik3E1M4cUQTEgY1RRZl7WQzDmYohuUDDzDE9EsMsVTXpCKkpURCCVZ1ObX2mXSGmIlVDydhzRYliBfpAw/GyFbKTSm39OhSWKpDVJy1CYEOpPUVN3tl1iNL7O1fWslUpjFRMZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=t2VtGFmwRPmuqTfnbDl0Am+3sZbzCgD4fvum6MSiFWI=;
 b=dMOBGr1yR4oL0e0hTszfyv9eBhAYdCMF+vqmJRyVo8mlaRNGgY7Zxuj6ZEFr3jS8NPPrkRQaxjbx0sBZsEkTW8CT33kEyOwbRZ740A8ugc8CDTY5Q6fuKEyUzRGWDpvDY9Q3XwXhn5rtHJp+F0XoUw6M08rGc87CoJmjpbLSvkg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, Cheyenne Wills <cheyenne.wills@gmail.com>
Subject: Re: [PATCH v3 1/3] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Topic: [PATCH v3 1/3] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Index: AQHYU/TJb6Q1Q9CJy0G0bOkg81j9/qz3TfKA
Date: Tue, 19 Apr 2022 14:37:02 +0000
Message-ID: <ceb80e3b-d8a5-de29-5041-ffa1ad071ed8@citrix.com>
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-2-jgross@suse.com>
In-Reply-To: <20220419135254.21729-2-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e98d8f03-7598-480e-7077-08da2212115f
x-ms-traffictypediagnostic: BY5PR03MB5153:EE_
x-microsoft-antispam-prvs:
 <BY5PR03MB5153C31418B8D83AD1E576BEBAF29@BY5PR03MB5153.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 TmuqaJ7nHyp50DBWWf1wUB5KWw+mrFvN5ziMCV0l02IBuYP6tmiIerMNPLsHKHhIdl4bR+c5e6pX+8HXcbOz/B8RwWNUp2U5V9BIMQXzEVNHfOO96k0stQ68fYNGUNesxO9GQ4DsRPMMZAfMFN9S9NyITLVgIXHwj8UI0BSPaxEje3pBhSrThtzYnuptPnGzF6XP1bUYWHHzQocjbeDvc9SjqfxRzc7GdvJZtHTFtD1dMXW+GfeK2K3O66ChTjjcFjcgO5f4QgLJUwtrcsaOxmeJQ8gUsi/fMj+eGbEHkqZYZXe8Kez9gegV/lh+F2/fUPxl7ytxsjPUKj0pEnCz67zJayDgHKW1frJFIqvDsbTywSLpZjyv8Eheeb9hckzDOS23lVaREW4OQ8eGrD9OgwCcTvrLjIY1c1zB9DvFeidZngMWoAangNp/TpURk3k7BRNGnX8SDasOWKfq4M0wI9p1Ob5nQoF6uoQ0mXuEcXYPTQC88LGesJ/CoTWtlO8a8lgzwGWynZT/aKVpgM2Mdm77yvw/D0u9S7kbwk9TTp/sn7CB6MMFQAYKO2FpeXBjZSFwoPA+JFmjqZngARpT6MYdKKvfjSqNih/ZcSluFgxfoXdxBJDRPNi08pGGiwdjDFwxBXyyFRPKeFgMglsdAFQRCVc41kbR+t24yA0YZVSt9ZfDu+6KX5mZYxZqKr/0JHzxvjrB2Hxh+Cut+sJQVdAvEimSUgBSKM3Omery/jIup+uEkQBcLOvJwtjINmy44RkvLz/WnVIWtL2C44WB7w==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(6486002)(54906003)(8676002)(122000001)(508600001)(83380400001)(66556008)(71200400001)(8936002)(91956017)(66946007)(31696002)(76116006)(31686004)(64756008)(66446008)(66476007)(316002)(186003)(53546011)(82960400001)(4326008)(36756003)(2616005)(26005)(2906002)(6506007)(5660300002)(6512007)(38100700002)(38070700005)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?enRBQXF5emxSaGc1YklJZ1M2YkJkdEhkWGw2dlA1Qjh3Z1BoQ09RSy9nU1hu?=
 =?utf-8?B?Q0szTTBGVi9jcnFXbDVmS3NtT1hzWUdaR1pVMGV5WStLc1RRUFBNYk91aysz?=
 =?utf-8?B?ZzRMallvNkduYTlQNFBXUWFvZUN3YnNLUzR5V0pRbnVrcThvbk5ZTlZYYW9n?=
 =?utf-8?B?OERmYkZaY3NmaU53ZzN3aFR3N1hEcFpNMGh3amZ6c0xkS3V3TytUWjM0VmFV?=
 =?utf-8?B?ZC9wdGRXZWp6ODBUOFlnb1ZCZmVHR2MxbkJUeU9RZnRzWkp1SDMzenpnMlRa?=
 =?utf-8?B?Y2wrYnp1bjFNNWFRYXkrbVRVSy85c0JJamNybk5JYm1tSGxOSUorMVZKeUZQ?=
 =?utf-8?B?cjhHY0F2WDFzYkoza3c5NjVXVThNcDRnUjFSS0E5Vk5RK1R3TFZ0b0ZkdzBu?=
 =?utf-8?B?NDRhRHRMNUdlZWRpRmFIeGpZTE1LeGZjQUQxTThLald5WjZYK0xCQ3pJeG5E?=
 =?utf-8?B?YnpqeFV3d21mTmhUS25ZdEZtRGpNREdpL0NnOEluanllWDgwYXkwRWlGTTFS?=
 =?utf-8?B?emdhbUN1ZktyV0pvMk9saGRyN3VtRHN3dzZSZTlIQy9GSS9lZkxaSGVUdEli?=
 =?utf-8?B?M2Z1WngvOEhqSkxYVHorc1R2eVpOcGxsT3hFSVJMSTk0RUozSkY4ZVp0ZUhn?=
 =?utf-8?B?OFdOOU9jTEZ4VEMvSnlvYU1PS2RoLzhERytvb3BiSk00Wmt2QmFRQjNBVi9V?=
 =?utf-8?B?ckFIVFhvYU00UzlKUGluVFVFZTFQZ3FKYVpXYnppeklTdjIwNFEweUVNZXJl?=
 =?utf-8?B?OEJoMnNIQ0REa3QvREhwMWYyNXRzTE1wdDVoZWFtTDB6bzFyVDBUN1hib3JM?=
 =?utf-8?B?V3A0c0crdFNOc2FtcnNNaVR0WVpjeVJUblpUa3MwbFdUUG1GNC8wczJxeEV2?=
 =?utf-8?B?bXYvYWVpNHYzOVZYKzh1cGd5VjMyYlptYXduaEZWclpTOGZKN3RyajFMWk5C?=
 =?utf-8?B?b0g0cFh3dW9qek5HSmNzWlg3Mmt0VXYyb3RVVTVHU2N6RUNSNEdNOFRNNHpG?=
 =?utf-8?B?L0t0MllVeHdTQXpqZkVsM3NFQUNtRXBlUFNGdlZhSU5qa05zRSs4Tk80UUlK?=
 =?utf-8?B?V3dGL1NLV3Q0MmdFU0ljLzA0bzAzMEdNNEJjaEVXU2lERVIySUFPYUVLR25h?=
 =?utf-8?B?ajY0NEo2VElkSVl4M0dzd0t5SmVRS1NtdWJrRnZ4bXJ3Sjk5UVNjcnJ4UU1V?=
 =?utf-8?B?UTUvR2JzRnZ1Um5TVVJya3YrU0tlZlcyY0RmK0l4T2tqT1QwelpRY2Jvdm5P?=
 =?utf-8?B?VTNEaWwwWG5sbFhPeWp1VVlRelh0cmxidlcyUmZRd0x1NE9jVXZTeDdDUDBR?=
 =?utf-8?B?YUZUOTV6VmU2UHZVM0ZsNW1pb1MyREV5Y1IwV0dLbUd6bUZrZE52bGJBT2lC?=
 =?utf-8?B?MDc0Wlg4TkppUTFTMlFzbWtOOXpOd1Npb2JhNDVrZW5VR3JOY1UyWVFDT3Fu?=
 =?utf-8?B?eDBETkM0c0JwcWV5a1VENStLY3J3UEhOTXRlVG11dktKUnRzUkYvOWpZcGE0?=
 =?utf-8?B?dXprRldmdC9OWGh3NGpqcStWaXdEYjNEQzNGZ2xOZ1VNeU55bTZnK2hVU1E1?=
 =?utf-8?B?ek1zSGZpNmkveU5RRGVDV3Y2WmFacVdFTUQ3a1BvVXltUit1VFVpQTJkcTZ4?=
 =?utf-8?B?aFBOVEpPcjJDNG1sNHJCM2VBSkFrL1JxSXZXQnlFRElISmRXdEZyZUNpT3lS?=
 =?utf-8?B?Y0hZWXpXOVNhd1NkdHp0MFhnU3dJQm9rdzhyZURxUnduYVkyRm9ndmN2SG0y?=
 =?utf-8?B?Zzgzck84aE1sdml5VWs0aEZvdElnVEtnRUU4TDNFZ29nczc1OFBsbkJ1UFIr?=
 =?utf-8?B?NVJMUTNFcHBqbDFPWXBjVUZRYUQ4d3Y4T1ZXTTVndlh1SWRkblE4d2t1SlBU?=
 =?utf-8?B?MmllTzFGVUV0U0wvalhFdXNrZmM1Y0E3YURURGFuWWUzNmlMM21zbXVJY05v?=
 =?utf-8?B?RkNibEZSb3JlTkhFRHZWVjhCRExwSG1FY3Z5OS8vSElVeitSRU9lbEhjRE53?=
 =?utf-8?B?aEhBTFFDcnpuVmRoejVTSnUzamd5YlhUTUxESG8yOXJycTl6UnpjNDk0MTlC?=
 =?utf-8?B?UVIyOXVDbVdhRFAxSXYwbFZsYmpnZGRkR0dMcmExTW9QOERQa29kcXMxYVI2?=
 =?utf-8?B?cU1ORVdBY3lDQUJGY0pXMjQzVWJpYkhhdUhTd3B0Rzd5UTZiaGczS0I4ZDJB?=
 =?utf-8?B?NkJSK2l6WEFYREZOa2NDVFA1Y01PSitzQzhFVkdWNHFqUnlwOC9DUWFnMnhn?=
 =?utf-8?B?MkhlRThUMWVkUmprR1c4RDQ0dlpBbXJFdC96MUMvVWF3N3ZTR3ZKeThGWnZv?=
 =?utf-8?B?WVBXbHd4L3VpTlZHd3h6NnN1VXBMTnhyN0o5bVFPR1ppUHdONFgvQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BE17A259CDED4B41AD383CB3DAA6A854@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e98d8f03-7598-480e-7077-08da2212115f
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 14:37:02.1163
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8Obd1PsJJfhxfZ4boekNMue0MXT77DMRuLIWaGqrvlaHvEvU+DDWUdvOCCHlmv2oSYfzbqG+HtqAu1U1Gr/tofurZ0JsoAZbTWZtYWOk+wM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5153

T24gMTkvMDQvMjAyMiAxNDo1MiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gQSBoeXBlcnZpc29y
IGJ1aWx0IHdpdGhvdXQgQ09ORklHX0dEQlNYIHdpbGwgY3Jhc2ggaW4gY2FzZSB0aGUNCj4gWEVO
X0RPTUNUTF9nZGJzeF9ndWVzdG1lbWlvIGRvbWN0bCBpcyBiZWluZyBjYWxsZWQsIGFzIHRoZSBj
YWxsIHdpbGwNCj4gZW5kIHVwIGluIGlvbW11X2RvX2RvbWN0bCgpIHdpdGggZCA9PSBOVUxMOg0K
Pg0KPiAoWEVOKSBDUFU6ICAgIDYNCj4gKFhFTikgUklQOiAgICBlMDA4Ols8ZmZmZjgyZDA0MDI2
OTk4ND5dIGlvbW11X2RvX2RvbWN0bCsweDQvMHgzMA0KPiAoWEVOKSBSRkxBR1M6IDAwMDAwMDAw
MDAwMTAyMDIgICBDT05URVhUOiBoeXBlcnZpc29yIChkMHYwKQ0KPiAoWEVOKSByYXg6IDAwMDAw
MDAwMDAwMDAzZTggICByYng6IGZmZmY4MzA4NTYyNzdlZjggICByY3g6IGZmZmY4MzA4NTYyNzdm
ZmYNCj4gLi4uDQo+IChYRU4pIFhlbiBjYWxsIHRyYWNlOg0KPiAoWEVOKSAgICBbPGZmZmY4MmQw
NDAyNjk5ODQ+XSBSIGlvbW11X2RvX2RvbWN0bCsweDQvMHgzMA0KPiAoWEVOKSAgICBbPGZmZmY4
MmQwNDAzNWNkNWY+XSBTIGFyY2hfZG9fZG9tY3RsKzB4N2YvMHgyMzMwDQo+IChYRU4pICAgIFs8
ZmZmZjgyZDA0MDIzOWU0Nj5dIFMgZG9fZG9tY3RsKzB4ZTU2LzB4MTkzMA0KPiAoWEVOKSAgICBb
PGZmZmY4MmQwNDAyMzhmZjA+XSBTIGRvX2RvbWN0bCswLzB4MTkzMA0KPiAoWEVOKSAgICBbPGZm
ZmY4MmQwNDAyZjhjNTk+XSBTIHB2X2h5cGVyY2FsbCsweDk5LzB4MTEwDQo+IChYRU4pICAgIFs8
ZmZmZjgyZDA0MDJmNTE2MT5dIFMgYXJjaC94ODYvcHYvZG9tYWluLmMjX3RvZ2dsZV9ndWVzdF9w
dCsweDExLzB4OTANCj4gKFhFTikgICAgWzxmZmZmODJkMDQwMzY2Mjg4Pl0gUyBsc3Rhcl9lbnRl
cisweDEyOC8weDEzMA0KPiAoWEVOKQ0KPiAoWEVOKSBQYWdldGFibGUgd2FsayBmcm9tIDAwMDAw
MDAwMDAwMDAxNDQ6DQo+IChYRU4pICBMNFsweDAwMF0gPSAwMDAwMDAwMDAwMDAwMDAwIGZmZmZm
ZmZmZmZmZmZmZmYNCj4gKFhFTikNCj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKg0KPiAoWEVOKSBQYW5pYyBvbiBDUFUgNjoNCj4gKFhFTikgRkFUQUwgUEFH
RSBGQVVMVA0KPiAoWEVOKSBbZXJyb3JfY29kZT0wMDAwXQ0KPiAoWEVOKSBGYXVsdGluZyBsaW5l
YXIgYWRkcmVzczogMDAwMDAwMDAwMDAwMDE0NA0KPg0KPiBGaXggdGhpcyBpc3N1ZSBieSBtYWtp
bmcgc3VyZSB0aGUgZG9tYWluIHBvaW50ZXIgaGFzIGEgc2FuZSB2YWx1ZS4NCj4NCj4gUmVwb3J0
ZWQtYnk6IENoZXllbm5lIFdpbGxzIDxjaGV5ZW5uZS53aWxsc0BnbWFpbC5jb20+DQo+IEZpeGVz
OiBlNzI2YTgyY2EwZGMgKCJ4ZW46IG1ha2UgZ2Ric3ggc3VwcG9ydCBjb25maWd1cmFibGUiKQ0K
PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNClRoYW5r
cywgYnV0IEkgd2FzIGhvcGluZyBmb3IgYSBiaXQgb2YgZGlzY3Vzc2lvbiBvbiB0aGUgdXNlIG9m
IERPTUlEX0lETEUuDQoNCkl0IHVzZWQgdG8gYmUgcGVybWl0dGVkIHRvIHBhc3MgRE9NSURfSURM
RSB0byBkYmdfcndfbWVtKCkgdG8gYWNjZXNzIFhlbg0KbWVtb3J5LCB3aGljaCBpcyB3aHkgdGhl
IFhFTl9ET01DVExfZ2Ric3hfZ3Vlc3RtZW1pbyBzcGVjaWFsIGNhc2UgZXhpc3RlZC4NCg0KSXQg
dHVybnMgb3V0IHRoYXQgaXQgd2FzIGFsc28gZTcyNmE4MmNhMGRjIHdoaWNoIGRyb3BwZWQgdGhl
IGFiaWxpdHkgdG8NCnVzZSBET01JRF9JRExFLCBtZWFuaW5nIHRoYXQgdGhpcyBmaXggaXMgYSBt
aXNzaW5nIGh1bmsgZnJvbSB0aGUNCm9yaWdpbmFsIGNoYW5nZSB0b28uDQoNClRoaXMgaXMgcmVs
ZXZhbnQgYmFja3BvcnQgaW5mb3JtYXRpb24sIGFuZCB3b3VsZCBoYXZlIGNyZWF0ZWQNCmNvbXBs
ZXhpdGllcyBpZiB0aGV5IGhhZG4ndCBiZWVuIHRoZSBzYW1lIGNoYW5nZXNldC4NCg0KU28sIG5v
dyBhYm91dDoNCg0KIkl0IHVzZWQgdG8gYmUgcGVybWl0dGVkIHRvIHBhc3MgRE9NSURfSURMRSB0
byBkYmdfcndfbWVtKCksIHdoaWNoIGlzDQp3aHkgdGhlIHNwZWNpYWwgY2FzZSBleGNsdWRpbmcg
ZG9taWQgY2hlY2tzIGV4aXN0cy7CoCBOb3cgdGhhdCBpdCBpcyBvbmx5DQpwZXJtaXR0ZWQgdG8g
cGFzcyBwcm9wZXIgZG9taWRzLCByZW1vdmUgdGhlIHNwZWNpYWwgY2FzZSwgdGh1cyBtYWtpbmcN
CidkJyBhbHdheXMgdmFsaWQuIg0KDQo/DQoNCkNhbiBiZSBmaXhlZCBvbiBjb21taXQsIHNvIFJl
dmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyDQo8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gZm9y
IGV2ZXJ5dGhpbmcgZWxzZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:41:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:41:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308210.523827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngp32-00070B-Jv; Tue, 19 Apr 2022 14:41:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308210.523827; Tue, 19 Apr 2022 14:41:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngp32-000704-GW; Tue, 19 Apr 2022 14:41:44 +0000
Received: by outflank-mailman (input) for mailman id 308210;
 Tue, 19 Apr 2022 14:41:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngp31-0006zy-MN
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:41:43 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3278937-bfee-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 16:41:42 +0200 (CEST)
Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 10:41:39 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN7PR03MB3489.namprd03.prod.outlook.com (2603:10b6:406:bf::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 14:41:36 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022
 14:41:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3278937-bfee-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650379302;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=gMo6hutR0hEBf7C2oenOjhDdkMMK41o9n0zrs/2QlOo=;
  b=OsXgW21Xpbumer1VdRwJI1eHfJf0HT9DRV7PRzw28AYmcN7QCrMa29T2
   5OIIA0JwSQnOSIwbKgYaMNKmy8N5jFq2HfyDs/cxibKy3M7orX6azvJwB
   LwVXP4fblNSRkNFVIi8ihKAgIvo19u/rglNyx/XRPqzSCNhp7j3V7gxxI
   Y=;
X-IronPort-RemoteIP: 104.47.58.109
X-IronPort-MID: 69433224
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:SlOeVKCnsxoBPRVW/w/iw5YqxClBgxIJ4kV8jS/XYbTApDJ21DBUn
 TBKDD+DbqveYTfxedtwPoXg9BgO7MLcndBqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jg09Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhY0
 tRiqa3tSj4WFYH+2+c3WSB0PhpHaPguFL/veRBTsOS15mifKz7A5qsrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mbEs0m5vcBtNs0rulIEezTe
 Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLWwE8wnP//ZfD277xjcqzqKwOd7vc9XRVelLkRemj
 zji4DGsav0dHJnFodafyVquifXIhjjTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySDQ93wWRT+vXCFuwIHVsRZO+og4QqJx+zf5APxLmoOQyNFadcmnNQrXjFs3
 ViM9/v2ARR/vbvTTmiSnop4thu3MCkRaGMHOykNSFJd58G5+dliyBXSUtxkDai5yMXvHi39y
 CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsjDGJ5T+REMWTm0Ms=
IronPort-HdrOrdr: A9a23:BxtNH6HEqRRQfGf9pLqFsZLXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq
 iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq
 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P
 nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo
 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp
 +ISedrP8M=
X-IronPort-AV: E=Sophos;i="5.90,272,1643691600"; 
   d="scan'208";a="69433224"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K+OI25m5A3zf/8N2skojC+JZFQZDOq6lX6gZWxozpk/uaVTzivIwXqJFw19LBuMXPQR2lwUkcLPDF6rEvPQt2f5l5k3FLNfN0nd2uU/ewcFu1RaevuoyHmb+mvVcbPbWBZxPiyt6xx0chPdb/jwDN+uNU3XHysLlFRuM+mK8ktCP/rdgvkD3moLu32PoGwFwnL1s9dwzqJSwLKR63o3djFdzrTyujSyUg19hwFf4dHEr2kxTrxc2jzINS2k+pszmVahDcsvuuqwHptNOW9tTjIZ0kwPa3pDhJ6kmdDdsVBdM7ZpzYQyq3AYXjm0cW4HWKMGlIgVS6SimxuDNzz64RQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gMo6hutR0hEBf7C2oenOjhDdkMMK41o9n0zrs/2QlOo=;
 b=f0w236OCM7gvR71Bh9DakeSMVnk7KB2hnknbP+U4+rSswkNpsKwplzR51gLNeBFwFPIAW5paheJ9FXoJsllebydCMGOT+wpTkzuDyJULKb0kfUR8wcCW2kLL04B+yKuiPAROaw1Oq68iX2ExvEFoX8gkFv3XscbUmBLx/9V5zUNxZRBfki0aXMsWLGOUVQf+7I3v8qz4XAyyUcanAunYmP/g3vGnbZzjl4IhNZCtG1KU3/WvlH0u+eYOWg9Wm4ectMiR7+dYURKv/ouuLIMKR4gKfSJHie0X73e3Boq7fRk2vIWydovB33KU4z344KVDpjOwrbZcb4AxKUk6c7zPUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gMo6hutR0hEBf7C2oenOjhDdkMMK41o9n0zrs/2QlOo=;
 b=dPdTrvmaBH7eDxHiqfGgbePE6iDExe2hP4QJ3jUS8sf+bgz/xyVOH9XXYPlNY4EmAwNCKgKUFW2VOoGohH47uwkOleC2vQay6DfjPEwG0Yxg+nai/SQSUwa8kL1hxO49MdIEtys+7uN2pEv6kIN3WUJiV0yW2VRNs0KJYK7UBIA=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Elena Ufimtseva <elena.ufimtseva@oracle.com>, Jan Beulich
	<jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v3 2/3] xen: cleanup gdbsx_guest_mem_io() call
Thread-Topic: [PATCH v3 2/3] xen: cleanup gdbsx_guest_mem_io() call
Thread-Index: AQHYU/TKb9uyvM67ckKrRx0R1hRAjqz3TzoA
Date: Tue, 19 Apr 2022 14:41:36 +0000
Message-ID: <41b47fc4-05dc-ae8a-262e-94513042adad@citrix.com>
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-3-jgross@suse.com>
In-Reply-To: <20220419135254.21729-3-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0e2c359f-9c40-466c-a271-08da2212b4d3
x-ms-traffictypediagnostic: BN7PR03MB3489:EE_
x-microsoft-antispam-prvs:
 <BN7PR03MB3489ACE5F37A99707F28791ABAF29@BN7PR03MB3489.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 S0TP9Iwy/HzqTjx9xpt/m5vF50BIL+JOE8I5ioZ8TyI/s8hoYl2eZhVP6wWHNJS80xPYfS7hbA7OndakBw98yVHVax/yTTivKP3oVmjAsxJZ+eXe5WZPjwxVoekFJNnk3XgXRS5tN0cXGK7ffqikP9dlgdSJ8guFZvWr6E7BtQtbbRCrjiKep5XEXJwTMi9VvxCtlpfnlCDr6WXv/lQJh/uBmpGCvOu7UKAcnoDmdUKfLY4/cUljnuWHn3kt0CCdmBGW4Lph0iPLuR8KgcJqpEiJbenxBtxUO2Tl2IPW+INlrsU5TpXhQ3daWuA1s29MIdzE5HqJW/ftjC1XmMTCvSNZeCAQuCE3UWKLRambLPzeFzicutlUAUxEk/kgtfgPPri7o7tv5EGop0ArMnngMcpU1cp4U45+6mWfHj3LakVcY8l0al1Dqqv6RC3khz5mGC1lV1+hVTidemr2awg3zDlD7bg/Va+sONT6yQi8C/+za+BnAugF0qc9TaamAGh2RrmK1wiElaV7P4dbC8Z5ya9ujVD/KZ0ERh7g/hWasTHwifDc77qTZXsMVaDrhQKLKEoZHOl6/3bRXVdpG2ISViazzlxD8qNZJYYEDLaWmq8Zy9jt1vozyZFmcDewiCjH6Mw/SwuX7kSTcseSzkGlopjReTb4me1gFi+Vit9QPorqOU0kwOko8WrMkaFClkii2Ubolol13B69WvOPlDp+BzyOWD0pDixhHNwoG9dtFD82x7s91xdXRajYCFAL5Hor3A5eUsKmzCmyQUh1oLSFlg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(186003)(26005)(66556008)(4326008)(36756003)(8676002)(110136005)(31686004)(86362001)(2616005)(8936002)(5660300002)(4744005)(82960400001)(31696002)(6512007)(122000001)(316002)(54906003)(91956017)(76116006)(66946007)(66476007)(66446008)(64756008)(508600001)(6506007)(6486002)(38070700005)(38100700002)(2906002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?R1hLV295VDRQVElaQjB4SUcreVpVTlNmUnQyN2YwdjgzQUFuc0xSYmdFNGht?=
 =?utf-8?B?dlVNUTZtMkFyREtyMTk3Y1QydHhIeG52Z3QzNFc1dmZIK0p6SlpOVEd5Mk9I?=
 =?utf-8?B?U1V0Y1VHMkZnMG1IekJva2xMdEZiZHlMaWRTLzJwcG5EcWZRRENjWHNGdlkv?=
 =?utf-8?B?MmpzUS9qanFwU2RjenIyRzdWM1ZSajVoRUVJMElyZU1nY2hYb1dQcm5HN1Q3?=
 =?utf-8?B?YVNGaVpGQUU3dm1ZbDJqOE82djJNMEFlTEh4bS9iajBYMVA5VUViUmR5dTVS?=
 =?utf-8?B?ck9renFKcVNsUndaMnFzbkpHZ2hBc3UrOVJLZmMwV1Y2c2N5OVFmNGczc3lG?=
 =?utf-8?B?OGVLRGh4cWxkbUtzcjBWdG1lTDFKdU02ckhrS3g4UlR5MzkwSnhlRnJaOWxJ?=
 =?utf-8?B?bHp4UTB5YmVWUVU2R05manhHRy9UMXViM1BVYjQyVWdXSUltc3VDOXV1cG9V?=
 =?utf-8?B?SElSb3FFTVpabXcxRFA1UEVBREwvNWhmR3pnSUxhWFZmZ2JKLzF3eGhBSEZB?=
 =?utf-8?B?WWlDNG03YVFRUjB6ejZvYnV5aTZtR3FOZFhhdGpNS3FKa0NybVd0bGxhZWs4?=
 =?utf-8?B?N25CT09tNkxubjJVUWtqZ3ZoWDNPMkdNQVZWTTBMRmVnUjlSS0NsWTJJd3U2?=
 =?utf-8?B?TlQ2bXFaanF2RTRzWWZlYnZSL2FsQmJVcldhUHpqc2ZDUDRaUmhxT0Q0MUkx?=
 =?utf-8?B?Q0J5dWVYZzdXUkJtODBiQW5WVlpzeFQzQllFK3I1My9WQ3l5SDNuZUhaUktZ?=
 =?utf-8?B?anhpdjBPckQraTFLUHkvOURMWFA3T280VDZmaE9xVUVUcWJkU0Y2VHdlVVdk?=
 =?utf-8?B?MTZ4cGw2N0RYL1FvcjMxNmF0d2czTDdzNm9CV0pHbWRuVHNmQzI2MDRYMXYy?=
 =?utf-8?B?Z0VZdEt5alNUQzBNYVdGejRGZTkxRFhrdUhIdkV2RU5hNXN4NHRNeDlzbkRQ?=
 =?utf-8?B?aGNnbE5ybnhYWTUxRmUvN1U2TCt3M3JQTW44dnBNcm9tRTRwVjJlcW91Z0tl?=
 =?utf-8?B?OFNMQm5INU13M0JWOXdiTTMraytuSzVpeTExU2tmTnhJbk5HREIrNTZEbHRO?=
 =?utf-8?B?V2ZwR0s2YUFiR2tPcHNrVXhLc0dxayttUlAwZmRrUVc1SUZvOE5sdk1wWUhz?=
 =?utf-8?B?MGc4VEgvSnkvZjFTb2l4b3VIQnM2aGJGWCtSS1Q0VUZ5aEJXOEZHT29hOW1L?=
 =?utf-8?B?TWNkbzlsTXpzcVZjVUZPUm12VVVVSEdhUk1kcFNzTWFxd2lxZkl3V0IxeDI5?=
 =?utf-8?B?VTM0NlZqbzcrUzhKd1krczVmc2lNOGpBcW42aW91bFBhWkJHdDV2b0FSZFp6?=
 =?utf-8?B?RC9oNVpGTGs3dk1IQUEweW5NVmdRODR5OVRXUGVadm9jYjVzeU1qaWlvZFhD?=
 =?utf-8?B?Zk1XYXpjRll0K1hLMDZmZGl5Ni9lcTg0Y3Bua0ZzWDdNbXovUXI1SUdLOHJT?=
 =?utf-8?B?QUJjejJOK1NtVTVsWkd0QU4za0lULzcwczZwK2FibHpQOUI5cTNiWlpxMWNa?=
 =?utf-8?B?NE9PeVNBSmZrU2wrTFIwMm0zRHl1MTFaeWlzZ0NoN2toOEVJSmplUWQvV0c0?=
 =?utf-8?B?eGxsODNGZU1Uck9iR3lpYnRNaWNNNEhsbTl4NjgyUkJyRlhKUFlCUm5wbWta?=
 =?utf-8?B?RGhhdENMZ01kRHNSckNYOHp4b2NLUThZL2VHdDFpeWJqaGdKVkM0Q1pvWEFn?=
 =?utf-8?B?aW0ySE5CTDRTYXV0UEdhSXI4YlBYVDNwR2gwd24yalBNdXQ2QnZKQ1paOEtV?=
 =?utf-8?B?S1VyR0o2dUFVZ0FhRktQdklJUmlnOTVENUZuaTNZMHNOcTVrQTZRbFhRRkhQ?=
 =?utf-8?B?ajZhaHY1VU0rZ1krcGxYMEZVdEk3eGxBNmFCVTJ1SE5OVC8xWVRQU0daUVNp?=
 =?utf-8?B?UlBlWEpmb0FjYjFWbTZQUFhiWEUra3MxQ1lTWnQ3bHpPUllOd0pWTzB2K2xL?=
 =?utf-8?B?NFh5L0xGTVA4Y1k1ZGsyWnUrQ1NGSWIvTnM1VHo0RXpmTkxCVkRNMVMxTXQx?=
 =?utf-8?B?RDJxUGtsaXE0U09US1NuQkxhaDdQOVFwK2Nwb0UxRGlxSDJobHNhbVlGRkI3?=
 =?utf-8?B?QkZsR2JLK1U3ZE81bUhFVkJ2K2hUMmp5NWZkS0FtQWwycXgvblJOSGMwQWtz?=
 =?utf-8?B?UEc1ZVdNQjh5elBVY3h0WnBBRG0xd0EyZWpNek50dEpvbVJ1ejhHdkZLc0xF?=
 =?utf-8?B?eWZDWGNMQk5XdlJ1MjNoOE9EVi9acGc2QVkzRllPZGFweVd1Yjl1dnN4SEJi?=
 =?utf-8?B?amJFZ0lvR2hIWkxPeDcrbWhySFI0RVZuSm5ZY1plMkk0NWsySkY2UzY0dGpV?=
 =?utf-8?B?MTlpdlFORm1rVnVmSS84NUIvVXRZdldjVHJiUGNacUZhSWt0YUdnQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <74F50357D23BE54EA0D7AD4D0ED38ADD@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e2c359f-9c40-466c-a271-08da2212b4d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 14:41:36.3777
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EqCvOW0hr/UNR9zVXOiEkyPCkFqtZy008UpAjaZmhmbOsSfNx5dqJ0RtpzU64Mx9SKiHhiHa5VSBzYDQfCoVhbO1djv4iU13vTWB9q3A30E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3489

T24gMTkvMDQvMjAyMiAxNDo1MiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gTW9kaWZ5IHRoZSBn
ZGJzeF9ndWVzdF9tZW1faW8oKSBpbnRlcmZhY2UgdG8gdGFrZSB0aGUgYWxyZWFkeSBrbm93bg0K
PiBkb21haW4gcG9pbnRlciBhcyBwYXJhbWV0ZXIgaW5zdGVhZCBvZiB0aGUgZG9taWQuIFRoaXMg
ZW5hYmxlcyB0bw0KPiByZW1vdmUgc29tZSBtb3JlIGNvZGUgZnVydGhlciBkb3duIHRoZSBjYWxs
IHRyZWUuDQo+DQo+IFN1Z2dlc3RlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
Pg0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNClJl
dmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpJ
J2xsIHJlYmFzZSB0aGUgb3RoZXIgZGVidWdnZXIgY2xlYW51cCBvdmVyIHRoaXMuDQo=


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:41:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:41:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308212.523838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngp3F-0007Uh-Rw; Tue, 19 Apr 2022 14:41:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308212.523838; Tue, 19 Apr 2022 14:41:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngp3F-0007UT-Oe; Tue, 19 Apr 2022 14:41:57 +0000
Received: by outflank-mailman (input) for mailman id 308212;
 Tue, 19 Apr 2022 14:41:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngp3E-0007Sd-G9
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:41:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d8a47346-bfee-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 16:41:50 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-bPgPPefyNSamYu_xie2HPQ-1; Tue, 19 Apr 2022 16:41:53 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR0402MB3877.eurprd04.prod.outlook.com (2603:10a6:209:1d::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 14:41:48 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 14:41:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8a47346-bfee-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650379314;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MmelHo0xMZYMjkYdRuVUuqugozkzocb33PhVnrTykgE=;
	b=bEVjOjCa2inMXZbaAkb17FLz4V/eo6Iy63+AILxGzcw0S/LjFRW93uyIqgcs0H618Hy1sD
	sjk/OyQ57DbVxDSIiJltHlwL1cVBzsXqso3r8XphzJwSTXQA06D1PKzN4OHZBAtHFLeIsa
	wGs0WTivBS/2VmgoxOuW+HGrQEjnXfU=
X-MC-Unique: bPgPPefyNSamYu_xie2HPQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pp8qp4lbb6G9rXK3IhEb8CC4gNvKdEYOU+iLI/jIO0h+Rl38vR8+9zzMzGXDWMp3lBA2yK2ca5Kvu8gTfR+PRVCr1ful1MbqhKppd03CUEemWXdcH2iXWC2+TiA0+OfNhyblC2fotkhK5qBSE3wfYsA3H46IeOPAA7UZjNDJrUVZkYTdMQnb/SyrK+F0bip5wYXXrUPPd93af5PW52IBh/+vwT4Q9RnsxQjzvpO0HDie7LQtMMNomEPbnhlD1xtMfZTAI4XCSMhpFPhSpP9gZ87PFjxAfK4TlVQWFtosvXA+7d+4mzmieBqd7L3Q4Yai4BfeA9zFmCRVYYIygzY6mA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MmelHo0xMZYMjkYdRuVUuqugozkzocb33PhVnrTykgE=;
 b=F1Dir4cU+cbS/9BsS6UqefrLNrjwi7zcPu29ifIsozgLTsOTCyO76H6SK+nhAKKmWdoNhPn+xvH73/rdVvDBzljngkgjbGVEu4+6t3UfBDIUIekWwJmHY5Ae1EMwwYeGG+hNJb7YfveGDbKdlDA1yVUfoShUysuQFjJk+toAvj+h8WMydfFM/lKGCsJ8pF6FEqvxMg3ejF0YWn5l4B/9VVZyRjoglX+FyGR91gJHzmC81VN1e4aodZbgT7/qJVsgRdlW9BhOhO1UzJAu2HOTqrrdxlywHwb9cDEll+LqUsk8HM6LObqfqUHqU0Qk4PK988TXi7t40pnA3yyJyPxcPQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a78b37eb-410c-8764-9225-8685bf231543@suse.com>
Date: Tue, 19 Apr 2022 16:41:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 3/3] xen/iommu: cleanup iommu related domctl handling
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-4-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220419135254.21729-4-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::23)
 To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2e878e82-2376-48df-2625-08da2212bba7
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3877:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB38774977A8D31DA2A4846DA3B3F29@AM6PR0402MB3877.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6scTr704M2qdKNpfsS4a7oUCDIdJJktVixJX+YWeBLQupA5buhUYyDi6fkenmwUALue0Djig31lkD0kUalWHQd96BFuTvK6sWvmGMSeMSEhh6EN5KJR2BYodfWlIY4D+HwiJ3qCnRN2+AHhy4Zi0DnHWxMWj/jRIQSxyYTViAsWXdJeo2p+AUGiOflN6w2hUgpm/e87TyAhiYkhh4xtxoSMgao0Ef8QvOAhAop7e4aL9ESapQ8mQQqIw5BIGQTr1Z2YpZCx6GqaNYLNuKaDAzyOxbWytazO0LyixA++od+e3lFIXDXsVHNeBG1+d0rqn6uDhGl7iguhUvMoTdr3QM9CK15DsMFHxNzYEkiVmmcpWCRhTBEv4ZaEO9OGMZ9Tf3tm4PEB0KQMgmvl0sErTF8MM+FwtYDe5ObMseLMX1rhjdaASu6K5lTpG21ZJzdP2asJqmEkVw5fFgXAMEVEQjc0+4+lhODi7lMwNpl8F3rdtWlUEEGGfhI9Ef2LPlxEAHgwYFfMpMeGfMnai/deEGmP0DZ5keiuoxFdSxj0p5AUtljECKw5Ve7/fj/Advcdv5k9ZgLaoCAT3sDXhS+uP7FkwY1dPcHCHWmGcVAkn5SgKFOcLcFlAFvUytqvAtm1ngHjSIv1RUtTOO860rJ2h1qhrriJBD3FpHtf9m+57ySJacIA1j3i1IZPGaBCq/bxU0mzNgaUqTWGUNlQrNfDP5jkOXZCL3BKCUJuDkjCJ/gjq3v+68fD/DS1VAt+mocNQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31686004)(31696002)(4326008)(6862004)(66476007)(6512007)(66946007)(66556008)(36756003)(6636002)(8676002)(53546011)(6666004)(186003)(4744005)(54906003)(316002)(26005)(6486002)(38100700002)(2616005)(5660300002)(508600001)(37006003)(8936002)(6506007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cG1ualBkSi9Jdjc1dWZPejJrOEhvSzNHdllGNnJKWldNeEg4cFZFdVBtUEYv?=
 =?utf-8?B?MERDRWR0YS9xS082c3o4b2J6aEpUOWVrY1ZNYitFK2N5RTV4N2R2OE1RRUtQ?=
 =?utf-8?B?WEtXZzNkL2hxNHlRZEdkVDMxVWRRc2RQRWg5eVVWYjBOUVRGcEkrTjZSVFFQ?=
 =?utf-8?B?SGkzOE5lYXFsMXdUZjdYbW9Fdjl6T2lCcmFianp3bEdHQWJtd2pLVVlYc0RW?=
 =?utf-8?B?Wk9qUHBSOWo4Y00rNFY5K05vSkIxMnF0TlBVWEF5TGZQRks1SEhVSW00bWU1?=
 =?utf-8?B?c3dMNlpuQ0ZacEFiWDR5SHd1UzBmbWhzb0pxT1FyZCtDZTliMGZDNFNvdDds?=
 =?utf-8?B?cFhmS0t5SEQwbFdDUzRyUWNEV3Z2NFJKcVo5NWUxTXJ1SXVMeFVZMENvK3JH?=
 =?utf-8?B?Vm1veEVGLzh3ZzVsMUQwa201VkxybGQ0M1pRM1ZIcHRuOUVrM05yc1hVSWVE?=
 =?utf-8?B?OGFCWEJ0RjFiNGRucko0SnBsVEREbmJQM3Y4a0dmYWJFKzBlcEx3NlptRnhs?=
 =?utf-8?B?a1hBR1FPbWVCVDF1UzRjaWw5L29nSklveTNVaEtSNm1Mdm5OZStYdlkyU0pC?=
 =?utf-8?B?cVFqYjQwZFkyQU9HbkV0aEdGTTVpT2hTWktLUy9QZmtWVU9mNVFiT1JhNEJK?=
 =?utf-8?B?U0V5SFhkelRnMkJUN3lpR1FWRHE1d1ZKR25PZzNmc2RGUGVpMzcrViszYk43?=
 =?utf-8?B?N1RnR3BSZWFzK3g4UU14NUtoMHVVY09zRWxaaGFpVVNwcGg1S05ROHBJQXJE?=
 =?utf-8?B?WjFyRjlEMVZOSFhpQkRkN2sxcURObEFRaE9aQ2pLTHRNam5EVjFwQWFmUXI2?=
 =?utf-8?B?b1RHTGVDODU0ZGphdjRhMHgraHlQRzdmeHpZZ1JrNVEzRkdTVWUxM1E5c2NL?=
 =?utf-8?B?STkxeGNnbGVBM0VSWWwwUFpXOVlTOS9TQTBReFVuSHlNeFlOMVpFMDkybUpG?=
 =?utf-8?B?blozWmJpYUZ5OW5MMWRHYlNkYUlhRklZTkUzL0hJMkV1YmhiKzdYL3QrTEhr?=
 =?utf-8?B?SWt3dDA1THlFOUM0NjhxdEpKbVVaSEJXY0hLUytDb0FMSk8rZEI1MFFPM3NH?=
 =?utf-8?B?NTJScUZlR3FEcUM3aS9TM1NKUkhGWWgvN0tWa0ljV1V0c1Ivbmc1U2dxSFFC?=
 =?utf-8?B?Y2lNbjh2ZWRBcTlzNFJoOU5oTkVCcU4yRW4zOWJaTWRlUGZZaXdBZDBCQW5R?=
 =?utf-8?B?RUcwZENaMzVRQVBTaGxhek1ncjhNRDczVmdMOVMvaGtzWk5hRFdHVy9MUWtO?=
 =?utf-8?B?aWpGWFh4STM4citab0VFOWg0dWJKRDlnUWpUZDFmaktodkU0NWJSTW1NQU5Q?=
 =?utf-8?B?TEpDUXJjbEVuQ0FkU0RpZ3djZnJ4cXdrS1JncGJNVVB3clJHR2NpbWF5NW1n?=
 =?utf-8?B?d3BEelJDU21veTNjZ3hSMVo2ajk3Wm5OSi9ud2FpZHhBMjlZMjNqYWxTS1hX?=
 =?utf-8?B?eTNSK2dBODNHSnVRTmVHUWRTU29pQk8wLzNab0JsVHNOMGEvK05tR3ByVVJG?=
 =?utf-8?B?R3VrQzh0NzJBd0xBN3Rxay9BSFN4MzBXTHhrNkhaOE05SzR0dzM0a0s2MHEz?=
 =?utf-8?B?QXdnUGNVczdIbUdOeG1UU0xCallBdWNNcWxjcElaRVNiOCtWZGw0a0VjZmxC?=
 =?utf-8?B?Qy9GczIrdWtTTDNSTy9nSnhzZXZKYXZndTFBanl2dU41SHhMSVlNNzA3cWZW?=
 =?utf-8?B?ZTQzUjNXVUZMOWxCQTZCajRhSnpuOXJISWs4OERHeXdINE5CZlBtdlpJYTMr?=
 =?utf-8?B?b29YR05FUDJjaXIrN3g0UVNNZmppUTUrYjFZVTBIMFZpeDRVbnZkK0JTMnR6?=
 =?utf-8?B?d211T3ZKUHc4UExpbjA0L3NxYXJ4MUhlajQ4ZWZMaDkzWHV2RmUyeGxST2Rh?=
 =?utf-8?B?NFVOQm9VNW5uV0JsMzhvQ3pOalk4Wm9vRkdnK0VibEpqd1RDcjhtYk5WcmhL?=
 =?utf-8?B?VjdHTUNpalZKWml6azBYY3ZpUU1tMHdOSC9rRzZYbXM5cXhuVE9MQy9iaVBK?=
 =?utf-8?B?ZmliOFNqaVZySmgwdnk3UVp6U0hMMzNiNTc0QTRiemEvc2JOeEtSaGtsbXNB?=
 =?utf-8?B?SUVqVks4U3JlUnlXd2RPdmd4Ly94bFpPWXlnL3BXdFlka1JqTU1NQVJYNVB3?=
 =?utf-8?B?czRvVC9NMjVSOCt4TXBLemc4d0Q3aTE1WWszZGtQUi83N0xpa3laSXBIQ0NO?=
 =?utf-8?B?a0xBQmNFajRMRGtRVnhiSkQwSHZ1S0pCOEZFZEdEZ3poZnJZK09IcTh0a1dL?=
 =?utf-8?B?Q1REWkNYVVZldVZMNU9RZ09aOVVHSXZqeWNLYWhnb1pBN1kxbUQ4ZE1hTjBU?=
 =?utf-8?B?U21jblY4K29vVzBwd1poUkgzMFpSdVN2NU5leVk4VnFCU0tMMG96dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e878e82-2376-48df-2625-08da2212bba7
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 14:41:48.0488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: puoLqjFQyygyhJUejzr8Q29cNkFyjsZlS3uRVAhcBMrhg8rfhI4nMX7aNlKjqLovTGsHqwhnEvywZldWVUM25A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3877

On 19.04.2022 15:52, Juergen Gross wrote:
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -871,6 +871,13 @@ long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>              copyback = 1;
>          break;
>  
> +    case XEN_DOMCTL_assign_device:
> +    case XEN_DOMCTL_test_assign_device:
> +    case XEN_DOMCTL_deassign_device:
> +    case XEN_DOMCTL_get_device_group:

As said in reply to Andrew, I'm not convinced having these enumerated here
is a good idea. But in any event the whole addition wants framing by
#ifdef CONFIG_HAS_PASSTHROUGH now.

For x86 I wonder whether the adjustment wouldn't allow to drop domctl.c's
including of xen/iommu.h (but perhaps it's included indirectly anyway).

Jan

> +        ret = iommu_do_domctl(op, d, u_domctl);
> +        break;
> +
>      default:
>          ret = arch_do_domctl(op, d, u_domctl);
>          break;



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:48:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:48:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308222.523849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngp9D-0008SR-Ko; Tue, 19 Apr 2022 14:48:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308222.523849; Tue, 19 Apr 2022 14:48:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngp9D-0008SK-HL; Tue, 19 Apr 2022 14:48:07 +0000
Received: by outflank-mailman (input) for mailman id 308222;
 Tue, 19 Apr 2022 14:48:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngp9B-0008SE-N7
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:48:05 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7ba38ab-bfef-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 16:48:04 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 021461F752;
 Tue, 19 Apr 2022 14:48:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A9532132E7;
 Tue, 19 Apr 2022 14:48:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id nGoQKKPLXmKPKQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 14:48:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7ba38ab-bfef-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650379684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=2qHyop+1P6vNk74wS/Hu4HCEXxTm5BKFFllbFWg7vQs=;
	b=ldJbhLGrdUr4FGbted2k9hgkyX14dIjflBU0YZMpDDe0g+fQ7Vwl/GL4Qy7fz+Pc8TSRh/
	ejm+RKhWb1BJwCy86Z6SxUl2bpStCl8zq0R4A2bGdgwBiWrbToiHC6w3TFICmT9QwTi9uO
	h8Ypz3bYxN3+k91Qd2wuJlZcIXJhdTU=
Message-ID: <b68163be-ad43-7773-22ff-e83191886626@suse.com>
Date: Tue, 19 Apr 2022 16:48:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
 <YlpdBHKT1bYzZe2e@infradead.org>
 <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
 <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop>
 <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
In-Reply-To: <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------oIIxPuFY5WvnE0tBaUGfzFWJ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------oIIxPuFY5WvnE0tBaUGfzFWJ
Content-Type: multipart/mixed; boundary="------------tYbLJuhukeFgUoH3LwEWStTL";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr <olekstysh@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <b68163be-ad43-7773-22ff-e83191886626@suse.com>
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
 <YlpdBHKT1bYzZe2e@infradead.org>
 <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
 <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop>
 <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com>
In-Reply-To: <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com>

--------------tYbLJuhukeFgUoH3LwEWStTL
Content-Type: multipart/mixed; boundary="------------IytZh70LUF3jeF0x0ClKbXOS"

--------------IytZh70LUF3jeF0x0ClKbXOS
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMDQuMjIgMTQ6MTcsIE9sZWtzYW5kciB3cm90ZToNCj4gDQo+IEhlbGxvIFN0ZWZh
bm8sIEp1ZXJnZW4NCj4gDQo+IA0KPiBPbiAxOC4wNC4yMiAyMjoxMSwgU3RlZmFubyBTdGFi
ZWxsaW5pIHdyb3RlOg0KPj4gT24gTW9uLCAxOCBBcHIgMjAyMiwgT2xla3NhbmRyIHdyb3Rl
Og0KPj4+IE9uIDE2LjA0LjIyIDA5OjA3LCBDaHJpc3RvcGggSGVsbHdpZyB3cm90ZToNCj4+
Pg0KPj4+IEhlbGxvIENocmlzdG9waA0KPj4+DQo+Pj4+IE9uIEZyaSwgQXByIDE1LCAyMDIy
IGF0IDAzOjAyOjQ1UE0gLTA3MDAsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+Pj4+
IFRoaXMgbWFrZXMgc2Vuc2Ugb3ZlcmFsbC4gQ29uc2lkZXJpbmcgdGhhdCB0aGUgc3dpb3Rs
Yi14ZW4gY2FzZSBhbmQgdGhlDQo+Pj4+PiB2aXJ0aW8gY2FzZSBhcmUgbXV0dWFsbHkgZXhj
bHVzaXZlLCBJIHdvdWxkIHdyaXRlIGl0IGxpa2UgdGhpczoNCj4+Pj4gQ3VyaW91cyBxdWVz
dGlvbjrCoCBXaHkgY2FuJ3QgdGhlIHNhbWUgZ3JhbnQgc2NoZW1lIGFsc28gYmUgdXNlZCBm
b3INCj4+Pj4gbm9uLXZpcnRpbyBkZXZpY2VzP8KgIEkgcmVhbGx5IGhhdGUgaGF2aW5nIHZp
cnRpbyBob29rcyBpbiB0aGUgYXJjaA0KPj4+PiBkbWEgY29kZS7CoCBXaHkgY2FuJ3QgWGVu
IGp1c3Qgc2F5IGluIERUL0FDUEkgdGhhdCBncmFudHMgY2FuIGJlIHVzZWQNCj4+Pj4gZm9y
IGEgZ2l2ZW4gZGV2aWNlPw0KPj4gWy4uLl0NCj4+DQo+Pj4gVGhpcyBwYXRjaCBzZXJpZXMg
dHJpZXMgdG8gbWFrZSB0aGluZ3Mgd29yayB3aXRoICJ2aXJ0aW8iIGRldmljZXMgaW4gWGVu
DQo+Pj4gc3lzdGVtIHdpdGhvdXQgaW50cm9kdWNpbmcgYW55IG1vZGlmaWNhdGlvbnMgdG8g
Y29kZSB1bmRlciBkcml2ZXJzL3ZpcnRpby4NCj4+DQo+PiBBY3R1YWxseSwgSSB0aGluayBD
aHJpc3RvcGggaGFzIGEgcG9pbnQuDQo+Pg0KPj4gVGhlcmUgaXMgbm90aGluZyBpbmhlcmVu
dGx5IHZpcnRpbyBzcGVjaWZpYyBpbiB0aGlzIHBhdGNoIHNlcmllcyBvciBpbg0KPj4gdGhl
ICJ4ZW4sZGV2LWRvbWlkIiBkZXZpY2UgdHJlZSBiaW5kaW5nLg0KPiANCj4gDQo+IEFsdGhv
dWdoIHRoZSBtYWluIGludGVudGlvbiBvZiB0aGlzIHNlcmllcyB3YXMgdG8gZW5hYmxlIHVz
aW5nIHZpcnRpbyBkZXZpY2VzIGluIA0KPiBYZW4gZ3Vlc3RzLCBJIGFncmVlIHRoYXQgbm90
aGluZyBpbiBuZXcgRE1BIG9wcyBsYXllciAoeGVuLXZpcnRpby5jKSBpcyB2aXJ0aW8gDQo+
IHNwZWNpZmljIChhdCBsZWFzdCBhdCB0aGUgbW9tZW50KS4gUmVnYXJkaW5nIHRoZSB3aG9s
ZSBwYXRjaCBzZXJpZXMgSSBhbSBub3QgDQo+IHF1aXRlIHN1cmUsIGFzIGl0IHVzZXMgYXJj
aF9oYXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2VzcygpLiA+DQo+PiDCoCBBc3N1
bWluZyBhIGdpdmVuIGRldmljZSBpcw0KPj4gZW11bGF0ZWQgYnkgYSBYZW4gYmFja2VuZCwg
aXQgY291bGQgYmUgdXNlZCB3aXRoIGdyYW50cyBhcyB3ZWxsLg0KPj4NCj4+IEZvciBpbnN0
YW5jZSwgd2UgY291bGQgcHJvdmlkZSBhbiBlbXVsYXRlZCBlMTAwMCBOSUMgd2l0aCBhDQo+
PiAieGVuLGRldi1kb21pZCIgcHJvcGVydHkgaW4gZGV2aWNlIHRyZWUuIExpbnV4IGNvdWxk
IHVzZSBncmFudHMgd2l0aCBpdA0KPj4gYW5kIHRoZSBiYWNrZW5kIGNvdWxkIG1hcCB0aGUg
Z3JhbnRzLiBJdCB3b3VsZCB3b3JrIHRoZSBzYW1lIHdheSBhcw0KPj4gdmlydGlvLW5ldC9i
bG9jay9ldGMuIFBhc3N0aHJvdWdoIGRldmljZXMgd291bGRuJ3QgaGF2ZSB0aGUNCj4+ICJ4
ZW4sZGV2LWRvbWlkIiBwcm9wZXJ0eSwgc28gbm8gcHJvYmxlbXMuDQo+Pg0KPj4gU28gSSB0
aGluayB3ZSBjb3VsZCBlYXNpbHkgZ2VuZXJhbGl6ZSB0aGlzIHdvcmsgYW5kIGV4cGFuZCBp
dCB0byBhbnkNCj4+IGRldmljZS4gV2UganVzdCBuZWVkIHRvIGhvb2sgb24gdGhlICJ4ZW4s
ZGV2LWRvbWlkIiBkZXZpY2UgdHJlZQ0KPj4gcHJvcGVydHkuDQo+Pg0KPj4gSSB0aGluayBp
dCBpcyBqdXN0IGEgbWF0dGVyIG9mOg0KPj4gLSByZW1vdmUgdGhlICJ2aXJ0aW8sbW1pbyIg
Y2hlY2sgZnJvbSB4ZW5faXNfdmlydGlvX2RldmljZQ0KPj4gLSByZW5hbWUgeGVuX2lzX3Zp
cnRpb19kZXZpY2UgdG8gc29tZXRoaW5nIG1vcmUgZ2VuZXJpYywgbGlrZQ0KPj4gwqDCoCB4
ZW5faXNfZ3JhbnRzX2RldmljZQ0KDQp4ZW5faXNfZ3JhbnRzX2RtYV9kZXZpY2UsIHBsZWFz
ZS4gTm9ybWFsIFhlbiBQViBkZXZpY2VzIGFyZSBjb3ZlcmVkIGJ5DQpncmFudHMsIHRvbywg
YW5kIEknZCBsaWtlIHRvIGF2b2lkIHRoZSBjb25mdXNpb24gYXJpc2luZyBmcm9tIHRoaXMu
DQoNCj4+IC0gcmVuYW1lIHhlbl92aXJ0aW9fc2V0dXBfZG1hX29wcyB0byBzb21ldGhpbmcg
bW9yZSBnZW5lcmljLCBsaWtlDQo+PiDCoMKgIHhlbl9ncmFudHNfc2V0dXBfZG1hX29wcw0K
Pj4NCj4+IEFuZCB0aGF0J3MgcHJldHR5IG11Y2ggaXQuDQo+IA0KPiArIGxpa2VseSByZW5h
bWluZyBldmVyeXRoaW5nIGluIHRoYXQgcGF0Y2ggc2VyaWVzIG5vdCB0byBtZW50aW9uIHZp
cnRpbyAobW9zdGx5IA0KPiByZWxhdGVkIHRvIHhlbi12aXJ0aW8uYyBpbnRlcm5hbHMpLg0K
PiANCj4gDQo+IFN0ZWZhbm8sIHRoYW5rIHlvdSBmb3IgY2xhcmlmeWluZyBDaHJpc3RvcGgn
cyBwb2ludC4NCj4gDQo+IFdlbGwsIEkgYW0gbm90IGFnYWluc3QgZ29pbmcgdGhpcyBkaXJl
Y3Rpb24uIENvdWxkIHdlIHBsZWFzZSBtYWtlIGEgZGVjaXNpb24gb24gDQo+IHRoaXM/IEBK
dWVyZ2VuLCB3aGF0IGlzIHlvdXIgb3Bpbmlvbj8NCg0KWWVzLCB3aHkgbm90Lg0KDQpNYXli
ZSByZW5hbWUgeGVuLXZpcnRpby5jIHRvIGdyYW50LWRtYS5jPw0KDQpJJ2Qga2VlcCB0aGUg
WEVOX1ZJUlRJTyByZWxhdGVkIGNvbmZpZyBvcHRpb24sIGFzIHRoaXMgd2lsbCBiZSB0aGUg
bm9ybWFsIHVzZQ0KY2FzZS4gZ3JhbnQtZG1hLmMgc2hvdWxkIGJlIGNvdmVyZWQgYnkgYSBu
ZXcgaGlkZGVuIGNvbmZpZyBvcHRpb24gWEVOX0dSQU5UX0RNQQ0Kc2VsZWN0ZWQgYnkgWEVO
X1ZJUlRJTy4NCg0KQ09ORklHX1hFTl9WSVJUSU8gc2hvdWxkIHN0aWxsIGd1YXJkIHhlbl9o
YXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2VzcygpLg0KDQoNCkp1ZXJnZW4NCg==

--------------IytZh70LUF3jeF0x0ClKbXOS
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------IytZh70LUF3jeF0x0ClKbXOS--

--------------tYbLJuhukeFgUoH3LwEWStTL--

--------------oIIxPuFY5WvnE0tBaUGfzFWJ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJey6MFAwAAAAAACgkQsN6d1ii/Ey8Y
Cgf/fa3dM1JSR5n0u1qSuc6yvsRsjmsRbqYjGztYsmAk/gr+mMoSNZJgki9lC+flyJnexUJie5/T
FJB5nrXRyMVElNxHKHYfZIgNTDG5m8NO3y+JzxJuQiJiJERh6z+gK8J/NTl1CFW6X51ExDvSp095
CF+0CDOHicqoEWHMRHTk7GgQrzrVvQWi9KDv6Vpc3R3eXLry6jZL6926MCoElNygF+hbvmJBYyAS
qSvz+SHGvPlJiAi3cERgCGov8yQkintOerQGjjclITFHptbefHin+9JSdAEoBh2nIJcMxl1b3/2/
9gcoc4aefQluT4BFB1CzqQMCHyvJF/I9wPzvgFhCuQ==
=MsFz
-----END PGP SIGNATURE-----

--------------oIIxPuFY5WvnE0tBaUGfzFWJ--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:50:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:50:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308227.523859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpBy-0001QJ-2H; Tue, 19 Apr 2022 14:50:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308227.523859; Tue, 19 Apr 2022 14:50:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpBx-0001QC-Vb; Tue, 19 Apr 2022 14:50:57 +0000
Received: by outflank-mailman (input) for mailman id 308227;
 Tue, 19 Apr 2022 14:50:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngpBw-0001Q6-Vq
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:50:56 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e16b656-bff0-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 16:50:56 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C07B61F74E;
 Tue, 19 Apr 2022 14:50:55 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8A6EF132E7;
 Tue, 19 Apr 2022 14:50:55 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2HFTIE/MXmKmKgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 14:50:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e16b656-bff0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650379855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=57GDIDN6tOSuzipaOftHURS8mi9IPw1o6aPNdmgnG5c=;
	b=HTOyShl3omV+tsIikxFfaQ8ZfoRNOUM7iOfupl54W5Zai4b1RD9+DyubXhHE02rPaOXjdo
	YfYAM5fZhcKrUimGLj+q8fWLamjkHWFcogeQkBE+ta6rWaqzwnxt5YenkxmjLhK6Dog2O2
	dN8TJFS0j5j9ixakCQXNt4mfZ85Tybo=
Message-ID: <d9842554-449e-c289-5dce-d4ffc46c20ec@suse.com>
Date: Tue, 19 Apr 2022 16:50:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 1/3] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich
 <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-2-jgross@suse.com>
 <ceb80e3b-d8a5-de29-5041-ffa1ad071ed8@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <ceb80e3b-d8a5-de29-5041-ffa1ad071ed8@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------vOwXIOnI4DGlVf1d5s4qC3x0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------vOwXIOnI4DGlVf1d5s4qC3x0
Content-Type: multipart/mixed; boundary="------------nixv9Dis7OFVVKN8Clffm7G1";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich
 <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Cheyenne Wills <cheyenne.wills@gmail.com>
Message-ID: <d9842554-449e-c289-5dce-d4ffc46c20ec@suse.com>
Subject: Re: [PATCH v3 1/3] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-2-jgross@suse.com>
 <ceb80e3b-d8a5-de29-5041-ffa1ad071ed8@citrix.com>
In-Reply-To: <ceb80e3b-d8a5-de29-5041-ffa1ad071ed8@citrix.com>

--------------nixv9Dis7OFVVKN8Clffm7G1
Content-Type: multipart/mixed; boundary="------------QNYC69YFsN2qJN6nqM497wcW"

--------------QNYC69YFsN2qJN6nqM497wcW
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMDQuMjIgMTY6MzcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDE5LzA0LzIw
MjIgMTQ6NTIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBBIGh5cGVydmlzb3IgYnVpbHQg
d2l0aG91dCBDT05GSUdfR0RCU1ggd2lsbCBjcmFzaCBpbiBjYXNlIHRoZQ0KPj4gWEVOX0RP
TUNUTF9nZGJzeF9ndWVzdG1lbWlvIGRvbWN0bCBpcyBiZWluZyBjYWxsZWQsIGFzIHRoZSBj
YWxsIHdpbGwNCj4+IGVuZCB1cCBpbiBpb21tdV9kb19kb21jdGwoKSB3aXRoIGQgPT0gTlVM
TDoNCj4+DQo+PiAoWEVOKSBDUFU6ICAgIDYNCj4+IChYRU4pIFJJUDogICAgZTAwODpbPGZm
ZmY4MmQwNDAyNjk5ODQ+XSBpb21tdV9kb19kb21jdGwrMHg0LzB4MzANCj4+IChYRU4pIFJG
TEFHUzogMDAwMDAwMDAwMDAxMDIwMiAgIENPTlRFWFQ6IGh5cGVydmlzb3IgKGQwdjApDQo+
PiAoWEVOKSByYXg6IDAwMDAwMDAwMDAwMDAzZTggICByYng6IGZmZmY4MzA4NTYyNzdlZjgg
ICByY3g6IGZmZmY4MzA4NTYyNzdmZmYNCj4+IC4uLg0KPj4gKFhFTikgWGVuIGNhbGwgdHJh
Y2U6DQo+PiAoWEVOKSAgICBbPGZmZmY4MmQwNDAyNjk5ODQ+XSBSIGlvbW11X2RvX2RvbWN0
bCsweDQvMHgzMA0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMzVjZDVmPl0gUyBhcmNoX2Rv
X2RvbWN0bCsweDdmLzB4MjMzMA0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMjM5ZTQ2Pl0g
UyBkb19kb21jdGwrMHhlNTYvMHgxOTMwDQo+PiAoWEVOKSAgICBbPGZmZmY4MmQwNDAyMzhm
ZjA+XSBTIGRvX2RvbWN0bCswLzB4MTkzMA0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMmY4
YzU5Pl0gUyBwdl9oeXBlcmNhbGwrMHg5OS8weDExMA0KPj4gKFhFTikgICAgWzxmZmZmODJk
MDQwMmY1MTYxPl0gUyBhcmNoL3g4Ni9wdi9kb21haW4uYyNfdG9nZ2xlX2d1ZXN0X3B0KzB4
MTEvMHg5MA0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMzY2Mjg4Pl0gUyBsc3Rhcl9lbnRl
cisweDEyOC8weDEzMA0KPj4gKFhFTikNCj4+IChYRU4pIFBhZ2V0YWJsZSB3YWxrIGZyb20g
MDAwMDAwMDAwMDAwMDE0NDoNCj4+IChYRU4pICBMNFsweDAwMF0gPSAwMDAwMDAwMDAwMDAw
MDAwIGZmZmZmZmZmZmZmZmZmZmYNCj4+IChYRU4pDQo+PiAoWEVOKSAqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqDQo+PiAoWEVOKSBQYW5pYyBvbiBDUFUgNjoN
Cj4+IChYRU4pIEZBVEFMIFBBR0UgRkFVTFQNCj4+IChYRU4pIFtlcnJvcl9jb2RlPTAwMDBd
DQo+PiAoWEVOKSBGYXVsdGluZyBsaW5lYXIgYWRkcmVzczogMDAwMDAwMDAwMDAwMDE0NA0K
Pj4NCj4+IEZpeCB0aGlzIGlzc3VlIGJ5IG1ha2luZyBzdXJlIHRoZSBkb21haW4gcG9pbnRl
ciBoYXMgYSBzYW5lIHZhbHVlLg0KPj4NCj4+IFJlcG9ydGVkLWJ5OiBDaGV5ZW5uZSBXaWxs
cyA8Y2hleWVubmUud2lsbHNAZ21haWwuY29tPg0KPj4gRml4ZXM6IGU3MjZhODJjYTBkYyAo
InhlbjogbWFrZSBnZGJzeCBzdXBwb3J0IGNvbmZpZ3VyYWJsZSIpDQo+PiBTaWduZWQtb2Zm
LWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IA0KPiBUaGFua3MsIGJ1
dCBJIHdhcyBob3BpbmcgZm9yIGEgYml0IG9mIGRpc2N1c3Npb24gb24gdGhlIHVzZSBvZiBE
T01JRF9JRExFLg0KPiANCj4gSXQgdXNlZCB0byBiZSBwZXJtaXR0ZWQgdG8gcGFzcyBET01J
RF9JRExFIHRvIGRiZ19yd19tZW0oKSB0byBhY2Nlc3MgWGVuDQo+IG1lbW9yeSwgd2hpY2gg
aXMgd2h5IHRoZSBYRU5fRE9NQ1RMX2dkYnN4X2d1ZXN0bWVtaW8gc3BlY2lhbCBjYXNlIGV4
aXN0ZWQuDQo+IA0KPiBJdCB0dXJucyBvdXQgdGhhdCBpdCB3YXMgYWxzbyBlNzI2YTgyY2Ew
ZGMgd2hpY2ggZHJvcHBlZCB0aGUgYWJpbGl0eSB0bw0KPiB1c2UgRE9NSURfSURMRSwgbWVh
bmluZyB0aGF0IHRoaXMgZml4IGlzIGEgbWlzc2luZyBodW5rIGZyb20gdGhlDQo+IG9yaWdp
bmFsIGNoYW5nZSB0b28uDQo+IA0KPiBUaGlzIGlzIHJlbGV2YW50IGJhY2twb3J0IGluZm9y
bWF0aW9uLCBhbmQgd291bGQgaGF2ZSBjcmVhdGVkDQo+IGNvbXBsZXhpdGllcyBpZiB0aGV5
IGhhZG4ndCBiZWVuIHRoZSBzYW1lIGNoYW5nZXNldC4NCj4gDQo+IFNvLCBub3cgYWJvdXQ6
DQo+IA0KPiAiSXQgdXNlZCB0byBiZSBwZXJtaXR0ZWQgdG8gcGFzcyBET01JRF9JRExFIHRv
IGRiZ19yd19tZW0oKSwgd2hpY2ggaXMNCj4gd2h5IHRoZSBzcGVjaWFsIGNhc2UgZXhjbHVk
aW5nIGRvbWlkIGNoZWNrcyBleGlzdHMuwqAgTm93IHRoYXQgaXQgaXMgb25seQ0KPiBwZXJt
aXR0ZWQgdG8gcGFzcyBwcm9wZXIgZG9taWRzLCByZW1vdmUgdGhlIHNwZWNpYWwgY2FzZSwg
dGh1cyBtYWtpbmcNCj4gJ2QnIGFsd2F5cyB2YWxpZC4iDQo+IA0KPiA/DQoNCkZpbmUgd2l0
aCBtZS4NCg0KPiANCj4gQ2FuIGJlIGZpeGVkIG9uIGNvbW1pdCwgc28gUmV2aWV3ZWQtYnk6
IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+IGZvciBldmVy
eXRoaW5nIGVsc2UuDQoNClRoYW5rcywNCg0KDQpKdWVyZ2VuDQo=
--------------QNYC69YFsN2qJN6nqM497wcW
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------QNYC69YFsN2qJN6nqM497wcW--

--------------nixv9Dis7OFVVKN8Clffm7G1--

--------------vOwXIOnI4DGlVf1d5s4qC3x0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJezE8FAwAAAAAACgkQsN6d1ii/Ey9a
fAf+LoRcVEw2RzZ4E2Uu/Pi/lawAQGTb8pF5IZMPxsiYN2rzm7YGnyR6h7IL+6zbrtZALzfT7HB0
vDPjlHM4+YDc06kG89S3xoEfeOqcc6L/zRPCkfEsS23rlippos3ur7QpOC6xTA3y9X+CyF+BdvQi
1Q4bBifhUY8NwI9T5CeH97H0PWJaCYDka+mJ5pUEtHOlTHRY+d1C9Y9A/laVwj8XscE8Dy5zh6qD
k05PuCFsoupgL9NvQIuHa+5J/GYYr7qByGPvzXrKn0SBBG+djIw2aktn5FzXJonkDXB5RrnXflzT
YV1yIGUYReuI5ibql+Qj0b0FJ2nZNTCAmyv/8sWUNw==
=Ks2K
-----END PGP SIGNATURE-----

--------------vOwXIOnI4DGlVf1d5s4qC3x0--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:51:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:51:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308230.523871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpCb-0001vg-D3; Tue, 19 Apr 2022 14:51:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308230.523871; Tue, 19 Apr 2022 14:51:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpCb-0001vZ-8e; Tue, 19 Apr 2022 14:51:37 +0000
Received: by outflank-mailman (input) for mailman id 308230;
 Tue, 19 Apr 2022 14:51:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngpCa-0001Q6-8m
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:51:36 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 34425bac-bff0-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 16:51:34 +0200 (CEST)
Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 10:51:31 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN3PR03MB2276.namprd03.prod.outlook.com (2a01:111:e400:7bbf::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 14:51:29 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022
 14:51:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34425bac-bff0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650379894;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=1bGjvuGeCAJgCVQvm2LlKcqO3Lx3z96RbJej+sRv9BQ=;
  b=FLRUi/RFW8rC7khEqxWs56c22M8emg1kXJOtcTZOAFV1fL0mpodeHOGC
   DjRVtFIIQQqQqRp5Mfzfaq6JarGGFC6ek4UP0PjBgnSQb47GdHTijjmga
   SV1bFAaTQqdDRMmtH+3lRUQ83DJGFdFFXIe8WrrJGrULD8DP3oaJ3CNzd
   c=;
X-IronPort-RemoteIP: 104.47.57.173
X-IronPort-MID: 69293554
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:9O5Jy6DRVfFfDxVW/8niw5YqxClBgxIJ4kV8jS/XYbTApGwhhjJVz
 mIfCmqOMv2IM2qkL9EnPdyz/EkOu5bSytc1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jg09Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPggy
 95vnMaWSj0DBZbIgO0cdydqLx5XaPguFL/veRBTsOS15mifKj7A5qsrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t5B8mcGM0m5vcBtNs0rulIEezTe
 Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLWwC+QnI+PZfD277zSV9l6PoE/zvasWQY+J2hlnf/
 07qxjGsav0dHJnFodafyVquifXIhjjTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySDVcLhVhe1pHqFuB80WNdKFeA+rgaXxcL84RudB2UCZi5MbpohrsBebTYnz
 EOTltXlQzlmqqSISGm1/62R6zi1PEA9E2gGYiMVSBof1PPqqoozkxHnQ85qFei+ididMTP6z
 i2OrSM+r64OlsNN3KK+lXjYhxq8q56PSRQ6jjg7RUqg5wJ9IYKgOYqh7AGC6e4addnCCF6co
 HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8wWirYUVcFu
 HPuhD4=
IronPort-HdrOrdr: A9a23:DdHqj6nTy7junIudVdmBuqSk8WrpDfLW3DAbv31ZSRFFG/Fw9/
 rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM
 xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv
 Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
X-IronPort-AV: E=Sophos;i="5.90,272,1643691600"; 
   d="scan'208";a="69293554"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gSwUShQ2ZWhdXdyMgfPDQWSWfAu6ebU0PQ55+tHTrFojh1LHpHg2eG69Dht0lCskPCvnTtwC4fbdXHKxAttPijb6NyReTqsfKM2OzgDLaMOEeGNumKwoSzt7qEqGYtI0tTPGRvTxFQJdayYh/+B5PMQEjqLolNX3Z2nsQBrJ+IU4+fFNtlULz3nIXbfzGqXDKTGww/tcJooxwVBtkGGLMFbZYvuq8NK9qpBCnZpFEySenLmsL3+SdkUEk4BlPwMoNErtRMMS24QxOkcnQiFkOU3rcAhzslWJ4UHZZp8YLrtL6+wCRcoYH/Pz7kArHyyDRiZqIiD28fLtrvKbRUS8ZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1bGjvuGeCAJgCVQvm2LlKcqO3Lx3z96RbJej+sRv9BQ=;
 b=nAvTHYbFWnwHxiyKzvLwkMDOBLqIUaG2E9s/zm/mrU8GKqUgZ0bcbHpNBvx5Xa/whDR9BjDyRFYNz9OCVPgRbMgUEV5cdKQgvKnczOX8BSJoZiFhD7NErxYlJHh9x+VFUdNoVQAKZLJwqOAmumwxzGQUHoG22zuJS2iJ8KYScMvKlUUMwgCbVR9iB1Mf+JFfYtOutUiQM26dzHpbnXeLcEIrrHe0LV+wXeviOmTpnr8fEG9+F9KVGpqLcpTaouK4/VDLMKeD24n2M1gyOPi/e0gJbT5UhSo/usSYcFtkyFvDTdMt4LKK/TAKHMUtIPppnEdPrleyEAw82Tk8FxNgJQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1bGjvuGeCAJgCVQvm2LlKcqO3Lx3z96RbJej+sRv9BQ=;
 b=DFto1nYwHWoc3fYddUVIhjQeEqP3/SRBbgeilbS8pCeVAMB19P/0czaQ36Zb6XubyBzxS7yiU4IvkxJe9HT8OG28N5I85+YbxgLA+VKfLvCtlkBS//2IEQVr3yHNGS6amdyvdDeR2xyd3wBzwS6zCDVkdNHBgbHRCXbl25PspyM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v3 3/3] xen/iommu: cleanup iommu related domctl handling
Thread-Topic: [PATCH v3 3/3] xen/iommu: cleanup iommu related domctl handling
Thread-Index: AQHYU/TJLaBiHx5iEEKhPVMRqRiW+az3UfwA
Date: Tue, 19 Apr 2022 14:51:29 +0000
Message-ID: <1d1dfeec-6268-1be1-48e1-44b38eed36fd@citrix.com>
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-4-jgross@suse.com>
In-Reply-To: <20220419135254.21729-4-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c3e8ac06-1b14-4ee7-4f46-08da2214163f
x-ms-traffictypediagnostic: BN3PR03MB2276:EE_
x-microsoft-antispam-prvs:
 <BN3PR03MB2276700B73476714B5C4DB58BAF29@BN3PR03MB2276.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 PlRHzFuMthDHRKo+VQNpzaCYh2PGpu02dbJHuBZ88d+yEkG5VhNJ7v7v0jPsVh1MShI2hAB/fG8tNze3MYWh6yg8ZrXX1lpo/ATzeMOWXYrp3KFXYGqmTXpz++pZEdnpO+qexKIe1cD2dywzuzPqkxKXiP8IYpD2BoUHLAtYYhVQ2GaX1X8lyWpVKw00JmVDdpq18l0Yp5lD4lKcWJxlz+3TgWBht0XuM1r3v1KFvblPs6Ku3TZ027R0fX13EmLJ3aXm+B2CdRSjSRIc/8SKEHGi4MKgrYdZ8o9GyDuFNsZjT2vwV19ElMCU5n0Tc5ESQyD26QVunN5GHafQTWMIOVPaWsOF2NOmBbZDs2O8eZ8gZSJnucnN4OPX01Kk8HCAZozlWwFCf37MwMITJV6tjehGcjCJv07YwvtHmfUC/mjeiYopBUJ7mb7BAdCV+ni5T+hOYgUHmKXJ1jyQWvs0nnj+oM1Wu8dF6qyjeaYw9UrQ/Zk5TiPwe0ZWX3CtRvBJ5McBIos8EsiXZIHLP7Gy8k4U9q8U3OWaxaoWAHvkUtFmwSpAaexHdppeWqB4DWxzmrvjiZiMUR3rTs1tXj83yQ7/O/+zsi8Lmm/iFtubkU8ytO9ZqIgF0PPAfwhDALni4jw0aGGj+uTmLk8K307CYkq5W7KUPdvu6wWEBZK6ZNvoaerNQCBK3BhpD6wuMc9f05PfPv537tLfFPS3Dt6izPLPnEPRC4PHoofb+WVB6ZH5jSl8PvMtQmb75k/LIylGQU1M3udIQc8NdJgDYhjvjw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66946007)(76116006)(91956017)(4744005)(36756003)(82960400001)(316002)(38070700005)(122000001)(38100700002)(66556008)(4326008)(66446008)(64756008)(8676002)(31686004)(54906003)(110136005)(71200400001)(6486002)(6512007)(107886003)(86362001)(26005)(508600001)(186003)(8936002)(5660300002)(53546011)(31696002)(6506007)(2616005)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dGRTN2UvRXNZVGUwSzlLeGpRM2RvcUZwM2NVREZXWFFoOUExU2lyUkl5M2tT?=
 =?utf-8?B?YzBWYWxqcHJ1ellxR21kVy80ZDZ6MUhwUGZpbCtYL01DTmhBdXNZaFJUWkFM?=
 =?utf-8?B?Z2p4bEthN3VsbDdyZEFHVFpjSDlXaUFtSWZQVis2ZXltazVhVXBveW41UVNI?=
 =?utf-8?B?NkI2ZzdVdldFUGNoRlRVYXBLcmljSk5RTkVMbTcvS3RqdklpNHpvM1FZRDhG?=
 =?utf-8?B?NWIwUGQva0tJZkhlQnVTNFduRFg4bmRhMysyWW5sb0ZVemJkY2NSZG5SSWgy?=
 =?utf-8?B?UW9NRHA1QVd4VTgwWXFmRHVKUDB1YWRvNGZOWnJ5TVVOcmFrZG5PbWJjVFd5?=
 =?utf-8?B?SjYvNDVkZHVWcUVySmVwai84YVRZSDZvZE9vdTZ1aHh0Um0xSUxZazlNQ1o5?=
 =?utf-8?B?UmRBbjhKbmdDSnlJYUpqRW1ITFlSOXF6WEhRQ3dXVEkrb1JhY2M5YXNKN29r?=
 =?utf-8?B?RmdFR2ZUbEQwb3VMMkVTc0M4RmZIQVpMSTlXV2NLZkdkU0RNZDljbHhzZk1t?=
 =?utf-8?B?UVdEaUFHUjdUeWNEdGVBemprNnFMbG5Dc09nMWxIL2QzazVsTTU4d0lqQWpO?=
 =?utf-8?B?SzBxTFVqS2JpUStTdXBUZ2FHWUlTRjFwMFNqeXF1QzJjTVNyL0VKb1F1ckJ3?=
 =?utf-8?B?YTM4YTVNNDNDakJFOHQrc0MveUNqd3Y4T1F1MndNZ2dPY3RQZzBEbGhTN3pI?=
 =?utf-8?B?NmhXS204V1QvUFZLM2xJcW9OOE9DOXY5WGR6cG9oVmR5REZLRTd4WERERXVz?=
 =?utf-8?B?d1YydEN4L3VWc3g1RS9ISjIxVDFVOU1YdUR6V09kMi9OMTdLeHNCWDY4WHZG?=
 =?utf-8?B?bkc1bmk3UkpZV0tXdEwzQ3BxZVVIM0tSa2FLUTlKaXFGenRKbkppTVR4TFJT?=
 =?utf-8?B?NHlTYWppSml5N2RXemFWRFRYNk5mZmszVWdiakV3alpGWjZ5SWVyY1pjTk82?=
 =?utf-8?B?dkdGd2hhSzgvRlJEeXRwRSthSmtrOFA4eDZGay9Nd3dlcnBZVUZrNGJuS2pG?=
 =?utf-8?B?S3JUeDc2OVU5aEw2YTRXWmFOb0F2eWRWL3ZOcmtLY1V5Q2ZRWVBveTZzY09i?=
 =?utf-8?B?NlJ3NlBEYWEwR1k3YjFJTTFWYW5mbWtYMjFTakQycXRMVy95d01OMHREMDh3?=
 =?utf-8?B?WlBNMVordUorUklnUVhKZEFtWndnSmFDb0Jta0pPZkt2QWRsdkhZcGJDRlRD?=
 =?utf-8?B?ZitzTzZsYjgweEd0YlA4dTgycm5RUFp4S2t5KzZzV2JOenlKNVU1VUhPQzRH?=
 =?utf-8?B?T0pUWDU2bzlVZ05FaVBSMjBTcFNGankwb3FyMHdHU3J2QVkrNEpzcnBNczNK?=
 =?utf-8?B?OXhQeXA1Z3A0Q3lvdVk5UUZlbndVWkV0M3phL056ZGQ5UVdUanlzOEFMSlNG?=
 =?utf-8?B?TWV3aitHK3BNajd1NE5yR25oOXN2eDlacE9VRVppUG5yU3gzNlNXUmFQUHhi?=
 =?utf-8?B?Q3R1cktqOE9PdXRnVE1TcEdRM2JkRmxnNC9TaWYzeExidVl3VGM1M2ZrSzBJ?=
 =?utf-8?B?V0hDRmNZbnVIQjdWeHJHUGtXbmxDbGx4cTE1U3hicU9PMEpRb2NYOFJGcXp6?=
 =?utf-8?B?dEVmQk1YQWdTY0JqM0RaSk0zc0xVc05zU2loVkc3NWlDRHo2WGJaR2h2b1JN?=
 =?utf-8?B?alpDMVlWZmh0RGZlRW0wOW54NHkvRHpwQldxaHVZaEM1Mno0ajdzNmFFYzhz?=
 =?utf-8?B?SG4xMUdPNXdENjFmeVNQUFN6R0pnQ3NJTUwxcWVrQ2gwR0tPU3lZUU1QQTJ6?=
 =?utf-8?B?Rm5qM3IreU1KRStKT3BLemRXV2xQM2tKUmRsazlNSWZISE5ldUdKeENOb1h5?=
 =?utf-8?B?WVBER0hrV1JJZjRyRjh0WEUrZzNVbTgzN1NGc1NjcTV4c0hQVHBLZVhiSncx?=
 =?utf-8?B?UGJKazFWQWRFWEtuMmxKeWNoRjdkUjhpMzdFVWF6ZTlqRkRpakFSR2JhOWdJ?=
 =?utf-8?B?NjVDVnp3NjdIT04wYUpQaE1sbERmTWJnV1VQRS9CZ0VaT1VWbTBObXlLQmxa?=
 =?utf-8?B?T2Y2MkZvcEF5b0NsNGt6M0JtMDZhbUJwTnIxemhGYUc4NXVMeFkvU0hjeWs3?=
 =?utf-8?B?TU8vQWRsR205a2pVTVNCcWU2ekJsVzhISW9Ub244cTlQMm5FM3g4SFJHY0Qx?=
 =?utf-8?B?cStzbFFBMThUMktKeVdFQjVyUEZSdkRTOHM0Y0xDMkZlcmpBUVdYeFd1RFZh?=
 =?utf-8?B?cmt4VG5JZW9PSTJaaHZISnhWUmxpM0VwZjZPUnpGWUhwR1IzNi9oMlgvekpL?=
 =?utf-8?B?cndlYWcrZWhUTnFtdnBsWTNhQUpQQk1GbUtFVURRN2tVcEpRczkzbFlmOGsz?=
 =?utf-8?B?MjZFYVR3N05oeEg3QUdPV0JoeEEzOWU4MGxhWFlKMlZGMTdCdEFQZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <61CF49E8E128EF4E80A84D3BA53EA2AE@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3e8ac06-1b14-4ee7-4f46-08da2214163f
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 14:51:29.3034
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i8hxkFSFUWY0sEZpFLInCqLTtV9Wri1QyVOk+9LVGzGTGVluBMYy8zL4iKod8j1p9hdJ+h20+KcqlWW1Vjn4h5f9k+uFXT1MblJAhDw8qwg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2276

T24gMTkvMDQvMjAyMiAxNDo1MiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gVG9kYXkgaW9tbXVf
ZG9fZG9tY3RsKCkgaXMgYmVpbmcgY2FsbGVkIGZyb20gYXJjaF9kb19kb21jdGwoKSBpbiB0aGUN
Cj4gImRlZmF1bHQ6IiBjYXNlIG9mIGEgc3dpdGNoIHN0YXRlbWVudC4gVGhpcyBoYXMgbGVkIGFs
cmVhZHkgdG8gY3Jhc2hlcw0KPiBkdWUgdG8gdW52YWxpZGF0ZWQgcGFyYW1ldGVycy4NCj4NCj4g
Rml4IHRoYXQgYnkgbW92aW5nIHRoZSBjYWxsIG9mIGlvbW11X2RvX2RvbWN0bCgpIHRvIHRoZSBt
YWluIHN3aXRjaA0KPiBzdGF0ZW1lbnQgb2YgZG9fZG9tY3RsKCkuDQo+DQo+IFNpZ25lZC1vZmYt
Ynk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gLS0tDQo+IEFub3RoZXIgcG9z
c2liaWxpdHkgd291bGQgZXZlbiBiZSB0byBtZXJnZSBpb21tdV9kb19kb21jdGwoKSBjb21wbGV0
ZWx5DQo+IGludG8gZG9fZG9tY3RsKCksIGJ1dCBJIHdhbnRlZCB0byBzdGFydCB3aXRoIGEgbGVz
cyBpbnRydXNpdmUgdmFyaWFudC4NCj4gVjM6DQo+IC0gbmV3IHBhdGNoDQoNCkkgZGVmaW5pdGVs
eSBwcmVmZXIgdGhpcyBhcHByb2FjaCwgdGhhbmtzLsKgIEluIGFkZGl0aW9uIHRvIGJlaW5nDQpj
bGVhcmVyLCBpdCdzIGFsc28gZmFzdGVyIGJlY2F1c2UgdGhlcmUgaXNuJ3QgYSBsb25nIGxpbmUg
b2YgImRvIHlvdQ0KdW5kZXJzdGFuZCB0aGlzIHN1Ym9wPyIgY2FsbHMgd2hlbiB3ZSBrbm93IGV4
YWN0bHkgd2hhdCBpdCBpcy4NCg0KSG93ZXZlciwgSSB0aGluayB3ZSBuZWVkIHN0dWIgZm9yIHRo
ZSAhSEFTX1BBU1NUSFJPVUdIIGNhc2Ugbm93IHRoYXQgaXQNCmlzIGJlaW5nIGNhbGxlZCBmcm9t
IGNvbW1vbiBjb2RlLg0KDQpJJ2QgZm9yZ290dGVuIHRoYXQgaXQgd2FzIHVzZWQgb24gQVJNIG5v
dywgYW5kIHllcyAtIGl0IGFic29sdXRlbHkNCnNob3VsZCBiZSBjYWxsZWQgZnJvbSBzb21ld2hl
cmUgY29tbW9uLCBub3QgZnJvbSB0aGUgYXJjaCBob29rcy4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 14:56:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 14:56:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308239.523882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpHK-0002ji-2y; Tue, 19 Apr 2022 14:56:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308239.523882; Tue, 19 Apr 2022 14:56:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpHK-0002jb-01; Tue, 19 Apr 2022 14:56:30 +0000
Received: by outflank-mailman (input) for mailman id 308239;
 Tue, 19 Apr 2022 14:56:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngpHI-0002jV-AL
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 14:56:28 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e38bb880-bff0-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 16:56:27 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id E5D66210ED;
 Tue, 19 Apr 2022 14:56:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A4DD8139BE;
 Tue, 19 Apr 2022 14:56:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id +vsVJ5rNXmLwLAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 14:56:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e38bb880-bff0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650380186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=M6rMU2PX27ALjPb21UoOmGD7knmyGClA6GL0BOOXZpQ=;
	b=oLCfeNjQJ7Q7xtHzDdsLcIPu85UxKX1CCGVHmC/ee8sHUpqz4BxslYPx56Ifx58H1X42nm
	qwNwF/3v78MF0LEY4UBN+EOsl6WdUVJLelSQKyTPemtmvLlE62exPxHKoF/fX5WtjzZQbj
	Ih+Z2lfG3BvpildzphipF0Xy75PR66c=
Message-ID: <93390fcd-4bef-588a-a8e4-ae0a5278acd1@suse.com>
Date: Tue, 19 Apr 2022 16:56:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 3/3] xen/iommu: cleanup iommu related domctl handling
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-4-jgross@suse.com>
 <1d1dfeec-6268-1be1-48e1-44b38eed36fd@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <1d1dfeec-6268-1be1-48e1-44b38eed36fd@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------rCov8yll0gKavLIpJ3xhqrcz"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------rCov8yll0gKavLIpJ3xhqrcz
Content-Type: multipart/mixed; boundary="------------Lh9003DIksB5bUK0500eenqH";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Message-ID: <93390fcd-4bef-588a-a8e4-ae0a5278acd1@suse.com>
Subject: Re: [PATCH v3 3/3] xen/iommu: cleanup iommu related domctl handling
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-4-jgross@suse.com>
 <1d1dfeec-6268-1be1-48e1-44b38eed36fd@citrix.com>
In-Reply-To: <1d1dfeec-6268-1be1-48e1-44b38eed36fd@citrix.com>

--------------Lh9003DIksB5bUK0500eenqH
Content-Type: multipart/mixed; boundary="------------rCeKdXYHK9g5v9Hd13ri0ry0"

--------------rCeKdXYHK9g5v9Hd13ri0ry0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMDQuMjIgMTY6NTEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDE5LzA0LzIw
MjIgMTQ6NTIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBUb2RheSBpb21tdV9kb19kb21j
dGwoKSBpcyBiZWluZyBjYWxsZWQgZnJvbSBhcmNoX2RvX2RvbWN0bCgpIGluIHRoZQ0KPj4g
ImRlZmF1bHQ6IiBjYXNlIG9mIGEgc3dpdGNoIHN0YXRlbWVudC4gVGhpcyBoYXMgbGVkIGFs
cmVhZHkgdG8gY3Jhc2hlcw0KPj4gZHVlIHRvIHVudmFsaWRhdGVkIHBhcmFtZXRlcnMuDQo+
Pg0KPj4gRml4IHRoYXQgYnkgbW92aW5nIHRoZSBjYWxsIG9mIGlvbW11X2RvX2RvbWN0bCgp
IHRvIHRoZSBtYWluIHN3aXRjaA0KPj4gc3RhdGVtZW50IG9mIGRvX2RvbWN0bCgpLg0KPj4N
Cj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+
IC0tLQ0KPj4gQW5vdGhlciBwb3NzaWJpbGl0eSB3b3VsZCBldmVuIGJlIHRvIG1lcmdlIGlv
bW11X2RvX2RvbWN0bCgpIGNvbXBsZXRlbHkNCj4+IGludG8gZG9fZG9tY3RsKCksIGJ1dCBJ
IHdhbnRlZCB0byBzdGFydCB3aXRoIGEgbGVzcyBpbnRydXNpdmUgdmFyaWFudC4NCj4+IFYz
Og0KPj4gLSBuZXcgcGF0Y2gNCj4gDQo+IEkgZGVmaW5pdGVseSBwcmVmZXIgdGhpcyBhcHBy
b2FjaCwgdGhhbmtzLsKgIEluIGFkZGl0aW9uIHRvIGJlaW5nDQo+IGNsZWFyZXIsIGl0J3Mg
YWxzbyBmYXN0ZXIgYmVjYXVzZSB0aGVyZSBpc24ndCBhIGxvbmcgbGluZSBvZiAiZG8geW91
DQo+IHVuZGVyc3RhbmQgdGhpcyBzdWJvcD8iIGNhbGxzIHdoZW4gd2Uga25vdyBleGFjdGx5
IHdoYXQgaXQgaXMuDQo+IA0KPiBIb3dldmVyLCBJIHRoaW5rIHdlIG5lZWQgc3R1YiBmb3Ig
dGhlICFIQVNfUEFTU1RIUk9VR0ggY2FzZSBub3cgdGhhdCBpdA0KPiBpcyBiZWluZyBjYWxs
ZWQgZnJvbSBjb21tb24gY29kZS4NCg0KT2theSwgSSdsbCBhZGQgaXQuIEphbiwgYXJlIHlv
dSBmaW5lIHdpdGggYSBzdHViPw0KDQoNCkp1ZXJnZW4NCg==
--------------rCeKdXYHK9g5v9Hd13ri0ry0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------rCeKdXYHK9g5v9Hd13ri0ry0--

--------------Lh9003DIksB5bUK0500eenqH--

--------------rCov8yll0gKavLIpJ3xhqrcz
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJezZoFAwAAAAAACgkQsN6d1ii/Ey+D
9wf7BYyfLD0ImPqVZmmIBpFqlTN6yXy68CWv8PaWXz6JzZZlCGxBv1ZRI9KHQ+jUSCCVWB5vUiQ0
JFCikPRzJRoknYaIoJZPI8stHgO3Ew4ueBQ7UALFXaiD5gsRVVSKm5OdT9KyWKAIE9IJjen5Fvmq
hLTGuf4mRb2EYcheWebsvyhX5WHxFzQqciwAf24xKLYQIM3WRPWx9/yRGcHxfnXurb+fJsCw9D0T
1TzX4uyqvB7WhKCRLiCRI1IYHJ1YTiWa73SL8tp0wCt9HKfmLS3F4xceYXCssCi0+3Dpy61ccpSb
pWxL1gyG49foJWrF7NKat7g7ePf9SZJSladz6rKpoQ==
=9+lx
-----END PGP SIGNATURE-----

--------------rCov8yll0gKavLIpJ3xhqrcz--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:01:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:01:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308244.523893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpMW-0004Pe-Mw; Tue, 19 Apr 2022 15:01:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308244.523893; Tue, 19 Apr 2022 15:01:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpMW-0004PX-JT; Tue, 19 Apr 2022 15:01:52 +0000
Received: by outflank-mailman (input) for mailman id 308244;
 Tue, 19 Apr 2022 15:01:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nWVz=U5=gmail.com=d.vrabel.98@srs-se1.protection.inumbo.net>)
 id 1ngpMV-0004PR-4p
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:01:51 +0000
Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com
 [2a00:1450:4864:20::430])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a377e4fb-bff1-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:01:49 +0200 (CEST)
Received: by mail-wr1-x430.google.com with SMTP id bv16so5689409wrb.9
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 08:01:49 -0700 (PDT)
Received: from pear.davidvrabel.org.uk (pear.davidvrabel.org.uk.
 [82.70.146.41]) by smtp.googlemail.com with ESMTPSA id
 v2-20020adf8b42000000b0020aa790a258sm1711097wra.8.2022.04.19.08.01.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Apr 2022 08:01:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: a377e4fb-bff1-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=sender:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=fa+nO+5zTXoHHur3q9qSPwyJI+3Au1WEuHLSiLtbamw=;
        b=jAEw/Z5vB1WmvUvoA5ChnPexJrjueoVeKWDFMygZmsbswQ2HBCG3U1JVDnTYYd3hw4
         x9l1dAkL3fAGuQHMxtqZBgMpmNMRIFgdLDsf43c7Jik8LRgtYWRWynciDeDpr3f5tRXc
         Qlrmgm6Fatqv/XqTG+pVTfE/swdmlik9EHs1l5kTnsDReTfiXiF9Y7N0XE+e+NyouuzP
         idC1SODdX0RPTIzNx7E7ZrFKHX0F/3bZ0765rV0gpAEUOpQZzvqwXkj0I1o2kW6L4ySB
         VwpsYE1y9OpxSTv3W7/opNTnd3nY5c3htfDs4Dz6ZLKI6frKcRKyvyNastwzwSYEGpDl
         q6ag==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
         :mime-version:content-transfer-encoding;
        bh=fa+nO+5zTXoHHur3q9qSPwyJI+3Au1WEuHLSiLtbamw=;
        b=to0KvoO4MSad1RWByrF2UyeZyrjVF3+Mm1bxrB8QCaBkQ4ykmyNkqczzTkeI+ayK+a
         YPAXp2hU4Vz6SNAUYDNW+LqtB7iE8tMquSn1ktH5l2tHDZk8sYwiUcgkybI1X530voyp
         1+973TMZ0GXl7izzyXX/maX+fyO622Pzr8lC3te67DlQf03dX6CYyIEbtdr+omCTOdX4
         +ghKnELiiWeocdLWpsT/16NJzIrG+mqsh/TlOt9afyfwFKeWrtmN5LD4j+Cw3HD3B3dk
         0xy6DcBp4ayzRCAb2SbEr1G5wj7HkDaPNYW2FmtzTqQ1Y7MxHFCJkmmlnXAzMM4a8p7G
         Tf7Q==
X-Gm-Message-State: AOAM533uA7tM3JETHh7I+y/QQHRG9ULmkVIGVabLUsYxtrlncF3raX5u
	lwAjVCZ/AUIwxroqUfuaH6SuHWsW+4M0Mg==
X-Google-Smtp-Source: ABdhPJxAmz6hhl/WIerRhwTNzcHgtazTyyyRMrTZVqSqOx++AJ6uL7ovxbaCjypKbekFp4m+0YB/Ag==
X-Received: by 2002:a5d:658f:0:b0:207:9c0e:1364 with SMTP id q15-20020a5d658f000000b002079c0e1364mr12107299wru.632.1650380508844;
        Tue, 19 Apr 2022 08:01:48 -0700 (PDT)
Sender: David Vrabel <d.vrabel.98@gmail.com>
From: David Vrabel <dvrabel@cantab.net>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	David Vrabel <dvrabel@amazon.co.uk>
Subject: [PATCH v1] page_alloc: assert IRQs are enabled in heap alloc/free
Date: Tue, 19 Apr 2022 16:01:34 +0100
Message-Id: <20220419150134.64704-1-dvrabel@cantab.net>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: David Vrabel <dvrabel@amazon.co.uk>

Heap pages can only be safely allocated and freed with interuupts
enabled as they may require a TLB flush which will send IPIs.

Enhance the assertions in alloc_xenheap_pages() and
alloc_domheap_pages() to check interrupts are enabled. For consistency
the same asserts are used when freeing heap pages.

As an exception, during early boot when only 1 PCPU is online,
allocations are permitted with interrupts disabled.

Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
---
 xen/common/page_alloc.c | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..e1ce38df13 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -162,6 +162,14 @@
 static char __initdata opt_badpage[100] = "";
 string_param("badpage", opt_badpage);
 
+/*
+ * Heap allocations may need TLB flushes which require IRQs to be
+ * enabled (except during early boot when only 1 PCPU is online).
+ */
+#define ASSERT_ALLOC_CONTEXT()                                          \
+    ASSERT(!in_irq() && (local_irq_is_enabled()                         \
+                         || system_state < SYS_STATE_smp_boot))
+
 /*
  * no-bootscrub -> Free pages are not zeroed during boot.
  */
@@ -2160,7 +2168,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 {
     struct page_info *pg;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     pg = alloc_heap_pages(MEMZONE_XEN, MEMZONE_XEN,
                           order, memflags | MEMF_no_scrub, NULL);
@@ -2173,7 +2181,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 
 void free_xenheap_pages(void *v, unsigned int order)
 {
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( v == NULL )
         return;
@@ -2202,7 +2210,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
     struct page_info *pg;
     unsigned int i;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( xenheap_bits && (memflags >> _MEMF_bits) > xenheap_bits )
         memflags &= ~MEMF_bits(~0U);
@@ -2224,7 +2232,7 @@ void free_xenheap_pages(void *v, unsigned int order)
     struct page_info *pg;
     unsigned int i;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( v == NULL )
         return;
@@ -2249,7 +2257,7 @@ void init_domheap_pages(paddr_t ps, paddr_t pe)
 {
     mfn_t smfn, emfn;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     smfn = maddr_to_mfn(round_pgup(ps));
     emfn = maddr_to_mfn(round_pgdown(pe));
@@ -2369,7 +2377,7 @@ struct page_info *alloc_domheap_pages(
     unsigned int bits = memflags >> _MEMF_bits, zone_hi = NR_ZONES - 1;
     unsigned int dma_zone;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
                                       bits ? : (BITS_PER_LONG+PAGE_SHIFT));
@@ -2419,7 +2427,7 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
     unsigned int i;
     bool drop_dom_ref;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( unlikely(is_xen_heap_page(pg)) )
     {
@@ -2738,7 +2746,7 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
 {
     struct page_info *pg;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     pg = acquire_staticmem_pages(smfn, nr_mfns, memflags);
     if ( !pg )
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:03:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:03:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308247.523904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpO6-0004zK-1w; Tue, 19 Apr 2022 15:03:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308247.523904; Tue, 19 Apr 2022 15:03:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpO5-0004zD-V2; Tue, 19 Apr 2022 15:03:29 +0000
Received: by outflank-mailman (input) for mailman id 308247;
 Tue, 19 Apr 2022 15:03:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nWVz=U5=gmail.com=d.vrabel.98@srs-se1.protection.inumbo.net>)
 id 1ngpO4-0004z7-AU
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:03:28 +0000
Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com
 [2a00:1450:4864:20::430])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dddc03be-bff1-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:03:27 +0200 (CEST)
Received: by mail-wr1-x430.google.com with SMTP id b19so22809394wrh.11
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 08:03:27 -0700 (PDT)
Received: from pear.davidvrabel.org.uk (pear.davidvrabel.org.uk.
 [82.70.146.41]) by smtp.googlemail.com with ESMTPSA id
 b5-20020adfd1c5000000b0020a7954a974sm12215010wrd.34.2022.04.19.08.03.26
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Apr 2022 08:03:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: dddc03be-bff1-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=sender:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=5ClOMvzXUkEMDZ0b8UX4E1pNgQWl3nMR7i1rQInvtkA=;
        b=l4Vm7kfYuqYnkN+yNN1YEBG+gVk2Z2v5+UD+QlI2xxQYbg04DbKA8rG/wA3Zf1V7Dl
         HP0At6uk4b3bKNgA0k2yZHrxUMSKWi+Ms8Wh9e+C6Dq6N1kB0ZNgAX/AVvyrpaXPfoHD
         WAlwHZhJb1wKy4b3WZjSob2GNfYvey6V014O/pWjFB82aue+oTVQC4xE7zPmrn03I0HB
         XmC+VrrCAHCWi2RvOWDaacq37aiW0se6nh5HXpt0+uTtyodg2GAB+O7D6RMAqfHe2QfP
         hfC2J7CHnTItmHk6wsx0pbWEySVDB2Gp+QD4QVloYsR3W6EXiJv2xtc0JS8NDDULR2bZ
         Wfcg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
         :mime-version:content-transfer-encoding;
        bh=5ClOMvzXUkEMDZ0b8UX4E1pNgQWl3nMR7i1rQInvtkA=;
        b=Y86LvhmuSnT4kV4sqMso8HuLcYl6m87x+9eqQlVbeBQYzDpgCzMqHjK6Rodm9LtOH+
         uMbIQCj1JZItfvDWOBgIgGUOW2tRJ/x7JrDp5CvcZj3mBMTcTp50XBlSWbE0E5BXtWZm
         PuZKHIRQzLCPv3Igu6FuFEesEDlfPNwx+MECSOgGdnXHDwv9aByN0QF3eQc7fe3iqadW
         OFlkKt67UTazUkeWRgNJ05+fGc5DcU54fbCmAZ/UUikd9xcXDIIGU+4mIKEy3uZSYD7e
         ru+hieaqzuE/oU2SHioGvglmmK46VOtjKi/d5opNoMDi3jnv9CU7Jmm83bQDNsCHF1if
         u61g==
X-Gm-Message-State: AOAM530kGmo88Jcm9Cm8uWc7Gsz0+pF0KuP/v5DHXvhxKtNKvnEtrl/7
	1z+fjOCRaozrdzYGP/mQsoQhoTq3iotouw==
X-Google-Smtp-Source: ABdhPJxKiy/MO4DHrk2AtR3HqnzpF0BXjLoj/y89IrNGazTUrbnRVgCpjbztsfjfDcxs9EzcDpVbVA==
X-Received: by 2002:adf:ba8f:0:b0:1e9:4afb:179b with SMTP id p15-20020adfba8f000000b001e94afb179bmr12257122wrg.57.1650380606754;
        Tue, 19 Apr 2022 08:03:26 -0700 (PDT)
Sender: David Vrabel <d.vrabel.98@gmail.com>
From: David Vrabel <dvrabel@cantab.net>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	David Vrabel <dvrabel@amazon.co.uk>
Subject: [PATCH v1] x86/mm: avoid inadvertently degrading a TLB flush to local only
Date: Tue, 19 Apr 2022 16:03:20 +0100
Message-Id: <20220419150320.64783-1-dvrabel@cantab.net>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: David Vrabel <dvrabel@amazon.co.uk>

If the direct map is incorrectly modified with interrupts disabled,
the required TLB flushes are degraded to flushing the local CPU only.

This could lead to very hard to diagnose problems as different CPUs will
end up with different views of memory. Although, no such issues have yet
been identified.

Change the check in the flush_area() macro to look at system_state
instead. This defers the switch from local to all later in the boot
(see xen/arch/x86/setup.c:__start_xen()). This is fine because
additional PCPUs are not brought up until after the system state is
SYS_STATE_smp_boot.

Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
---
 xen/arch/x86/mm.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index c271e383b5..72dbce43b1 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -5071,11 +5071,10 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v)
 #define lNf_to_l1f(f) (((f) & _PAGE_PRESENT) ? ((f) & ~_PAGE_PSE) : (f))
 
 /*
- * map_pages_to_xen() can be called with interrupts disabled during
- * early bootstrap. In this case it is safe to use flush_area_local()
- * and avoid locking because only the local CPU is online.
+ * map_pages_to_xen() can be called early in boot before any other
+ * CPUs are online. Use flush_area_local() in this case.
  */
-#define flush_area(v,f) (!local_irq_is_enabled() ?              \
+#define flush_area(v,f) (system_state < SYS_STATE_smp_boot ?    \
                          flush_area_local((const void *)v, f) : \
                          flush_area_all((const void *)v, f))
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:33:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:33:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308255.523914 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpqY-0000DM-Bq; Tue, 19 Apr 2022 15:32:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308255.523914; Tue, 19 Apr 2022 15:32:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpqY-0000DF-92; Tue, 19 Apr 2022 15:32:54 +0000
Received: by outflank-mailman (input) for mailman id 308255;
 Tue, 19 Apr 2022 15:32:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lfI/=U5=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ngpqW-0000D6-LE
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:32:52 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f809e7c7-bff5-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:32:50 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id C79395C00F7;
 Tue, 19 Apr 2022 11:32:48 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Tue, 19 Apr 2022 11:32:48 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 19 Apr 2022 11:32:47 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f809e7c7-bff5-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:message-id:mime-version:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm1; t=1650382368; x=1650468768; bh=of63eWPuDEYsw
	D9VFk/UpPjX4fxK7mSjw3zQWtJ8FuE=; b=Dd4VW1xnuqewU17gKmsMq/Ja106ec
	2Iyqb2PHieTicO1fT5qCXG76dQi/i21T7BqBaYjVu0ZrsnX12T8lxOISax321xaA
	Y1horh3HBwY7aGdRMzBxmFni13qHctznzClsjZrBABnthmayOz7DEfM8gNO+Uc1a
	n+j1VAthw5bdS8hsZoYKNqmzmEKoUoSezSf2z0uBJtPTfvQcxSUtHSIC/gqpxZQK
	6Wumq9LtUzCiy2GG+3VDDprG6tjT3+jWB2RMXZY3LhI52ALno9KeYCT6zQurxJ6S
	mBPy4CTgF4Yg/T80q2RaK7B4yVPVXeQ4kdnGDTKtYu1Mx/Peghfw/AMKQ==
X-ME-Sender: <xms:INZeYhRKMvuNi0lJHJJwOmSHi9ENG6MAeGkWcXrsqa98loL4otTzjQ>
    <xme:INZeYqyeXQ0fz99E2UHIjNGquaRn3xBoU8MNJ3h7yamKD-DrNbzvPYoCKT3Yb_Vkt
    LVzLpr0M7khSEA>
X-ME-Received: <xmr:INZeYm1vWzNpKK6rLQqMEWoHliV57RZomkkYQf2YuNyqyTD95L1Od5Q0kTFd>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgkeelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfggtggusehgtderredttddvnecuhfhrohhmpeffvghmihcuofgr
    rhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg
    gsrdgtohhmqeenucggtffrrghtthgvrhhnpedujefgjeeggeelhfevkeeltdekvdeuhfet
    iefffefhkeehhfevhefhkefgudegkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh
    grmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggs
    rdgtohhm
X-ME-Proxy: <xmx:INZeYpDLaYfsAKbDsKupWUqaYJVKE8TpvOesJJdSK922lMSRbNw_lg>
    <xmx:INZeYqjQ8nl-ejkmU_bivxcJ2a2dEmxpiESK0yybf-qt-61YfPGrnA>
    <xmx:INZeYtpjoJ-gzcMTwO1EIChvgQVrQE3K2RHu9tlNEZVmJ1D83z_uxw>
    <xmx:INZeYugrXHgIh8vu9U0X-OMs_9k35VXGO0KKqKg7bs2FVW-Ht6srPA>
Date: Tue, 19 Apr 2022 11:32:23 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH v3 0/4] EFI System Resource Table support
Message-ID: <Yl7WHv6+M+eJwQep@itl-email>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="2wCPjxNWfxWFtXWq"
Content-Disposition: inline


--2wCPjxNWfxWFtXWq
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Apr 2022 11:32:23 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH v3 0/4] EFI System Resource Table support

This adds support for the EFI System Resource Table.  This involves
reserving the table in Xen and adding a new hypercall so that dom0 can
access it.

Changes since v2:

- Use the esrt_desc global variable instead of passing it as a function
  parameter
- Add an overflow check for the ESRT size
- Create a new memory region for the ESRT to avoid wasting memory
- Add hypercall to retrieve the ESRT
- Add file local variables used during development
- Remove extra consts
- Follow the EFI naming convention in struct definitions
- Move struct definitions to header file
- Fix inverted logic in overflow check
- Remove BUILD_BUG_ON()s
- Avoid overriding attribute of memory descriptor containing ESRT

Changes since v1:

- Remove the esrt_status enum
- Use EFI types
- Fix style nits
- Remove an unused overflow check


Demi Marie Obenour (4):
  Grab the EFI System Resource Table and check it
  Add a dedicated memory region for the ESRT
  Add a new hypercall to get the ESRT
  Add emacs file-local variables

 xen/arch/arm/efi/efi-boot.h     |  1 +
 xen/arch/x86/efi/efi-boot.h     | 67 +++++++++++++++++++++++++--------
 xen/arch/x86/include/asm/e820.h |  2 +-
 xen/common/efi/boot.c           | 65 ++++++++++++++++++++++++++++++--
 xen/common/efi/efi.h            | 20 ++++++++++
 xen/common/efi/runtime.c        | 27 ++++++++++++-
 xen/include/efi/efiapi.h        |  3 ++
 xen/include/public/platform.h   |  7 ++++
 8 files changed, 172 insertions(+), 20 deletions(-)

--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--2wCPjxNWfxWFtXWq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJe1h0ACgkQsoi1X/+c
IsEr7hAAsAjtZsbGL5/mSvGSJn/rrTqwuq5tKN4wpxNVe7Z14rFnsb9NLrMa2Qz5
qDcNe3njClHYJjSArpOvU6gsfXODs8EVONYGO90iUC4ounue1v+UiLvq/kP0inaM
j2f49a6gPNDO+OU35BdT1zzkhQVoA+yN2izisMp0KMFK+g+TWvsOtg/l1UhLT6Fo
w/rIosqWomIOF81ORPXS5qQUyIOYJchQDtIOheDpZ5KHxi23UFmjkNNogauRJAUa
GYa3hN8C05TCLN0QH3uKViI2h2UD3p5HZ0ha7mP1rRSZ/N2s4lyFx+GDjB0cRcfk
BQ4BeIe56BW6SJt5B9oNOiJh4BWarm99GBSNK6u3ADFmovV5v7PA4fdhRSqgeAHm
S/xpeiyj8bhv6+8XcMYZSxfs7jW+yjMnmIrT7aQ1gTAdv1N6lPMqQVBXdVnrpi1D
JIAIHSC/ihAYHtuNBO9qXLoljsHyjmP9OITC3bnVNBFPwbaggjQTbEB5ePoozUL4
aTskS5a0w4rmUY2+4sUp9IdmIMJ/2QA3K7EZAWAkTCSyqwf7HtpAjTxRIG4Jx/EA
Hi0Gfqs9gnnd+KyK+EvPBiBcZvmskZxyz4Q9BpqCoiQWuyfH75gZyzmtSz5rPinp
xuUR62Gv8aTBzes1dkcbEuF0G6CJQ2ZkWFQT2IrJ0anNF9XaSP0=
=+x46
-----END PGP SIGNATURE-----

--2wCPjxNWfxWFtXWq--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:34:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:34:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308260.523926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpsR-0000qW-R7; Tue, 19 Apr 2022 15:34:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308260.523926; Tue, 19 Apr 2022 15:34:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpsR-0000qP-OB; Tue, 19 Apr 2022 15:34:51 +0000
Received: by outflank-mailman (input) for mailman id 308260;
 Tue, 19 Apr 2022 15:34:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lfI/=U5=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ngpsR-0000qH-0t
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:34:51 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3f7dbf9f-bff6-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:34:49 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id CF8DA5C00CD;
 Tue, 19 Apr 2022 11:34:48 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Tue, 19 Apr 2022 11:34:48 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 19 Apr 2022 11:34:48 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f7dbf9f-bff6-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:message-id:mime-version:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm1; t=1650382488; x=1650468888; bh=pDF5lIUPyRqlP
	/JhuV0ZhW01cjaNMztjWYSbTJ2f/NM=; b=o/1MiSGDCiJJ46eTFM9lCwNbiAvE+
	i2+pe/C/5d3JlpqmUagiRPCIim7AcPRIhRtyq3YypEesFFJER5jDahGTezqk1yLo
	gTE7IfvlY6At94LiHa8kOb5vCln4TQYQJWoRL1as79+N9TpJcL5ZtsHJdRpW9BxU
	zgVGG82WInRfKMqwIf2tV8WO/ZkX8cWG3jscE8V8EWu4WON2C67cDCDZWWr6Rkq0
	gHCqgvV9gD15DGqZ09QOCYp2PBYC5+q5V99WydNng9qHB/rUi4q4QLFd5HDXwb1e
	jQ03rnetUnUYfA4J1ED7qnA8sK1tXdnFOWijR18k1e9OcjDKK788oPyTA==
X-ME-Sender: <xms:mNZeYtLglo4-idT0JkLSvpF4RxZv3I8dJoRLLoIHGkgMWD-uSt1ZtQ>
    <xme:mNZeYpKByOl2T-zVCY_aVpUB7hLL3JtF2_ScHdLtQHaXLZGh-3j8dUNIB0Eo-EnyP
    g-cwHg9sjNQWk0>
X-ME-Received: <xmr:mNZeYluvwLTkSg6JG_iCPvxamaMN2fsBUs4jkW5WCra36U-n986OZjjDo7J8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgledtucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfggtggusehgtderredttddunecuhfhrohhmpeffvghmihcuofgr
    rhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg
    gsrdgtohhmqeenucggtffrrghtthgvrhhnpeeuveeguefgvdeiueejfedugeevleefteek
    udefheetuddvtdduvefggfeghedtffenucffohhmrghinhepkhgvrhhnvghlrdhorhhgne
    cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhi
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:mNZeYubXXepC_q51TTbUCLeh-IEaH_prrjtLhHzjXl_EFnPSMcIkZA>
    <xmx:mNZeYkZVOdLrvDVV1KSN5fxBU2DY_hefVS5JL3ftU532_oH-irMXVg>
    <xmx:mNZeYiDPdNZ76iAlCWgCp59TJBRp7UHI-jtHVKQEVtAI-IcN455Vzw>
    <xmx:mNZeYpMepqzCHm5gGN52cEyD4fbQwxIHGZBaqZOHLSArOh6CEQQL_Q>
Date: Tue, 19 Apr 2022 11:34:46 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 1/4] Grab the EFI System Resource Table and check it
Message-ID: <Yl7Wlm8Ljx6vGhI9@itl-email>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="6fndWT1Hd0pt5QFy"
Content-Disposition: inline


--6fndWT1Hd0pt5QFy
Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Apr 2022 11:34:46 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 1/4] Grab the EFI System Resource Table and check it

The EFI System Resource Table (ESRT) is necessary for fwupd to identify
firmware updates to install.  According to the UEFI specification =A723.4,
the table shall be stored in memory of type EfiBootServicesData.
Therefore, Xen must avoid reusing that memory for other purposes, so
that Linux can access the ESRT.  Additionally, Xen must mark the memory
as reserved, so that Linux knows accessing it is safe.

See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/
for details.

Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
---
 xen/arch/arm/efi/efi-boot.h |  1 +
 xen/arch/x86/efi/efi-boot.h |  2 +-
 xen/common/efi/boot.c       | 50 ++++++++++++++++++++++++++++++++++---
 xen/common/efi/efi.h        | 18 +++++++++++++
 xen/common/efi/runtime.c    |  3 ++-
 xen/include/efi/efiapi.h    |  3 +++
 6 files changed, 72 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index e452b687d8..ab2ad3dfe0 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -188,6 +188,7 @@ static EFI_STATUS __init efi_process_memory_map_bootinf=
o(EFI_MEMORY_DESCRIPTOR *
               desc_ptr->Type =3D=3D EfiLoaderCode ||
               desc_ptr->Type =3D=3D EfiLoaderData ||
               (!map_bs &&
+               desc_ptr !=3D esrt_desc &&
                (desc_ptr->Type =3D=3D EfiBootServicesCode ||
                 desc_ptr->Type =3D=3D EfiBootServicesData))) )
         {
diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
index 6e65b569b0..75937c8a11 100644
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -171,7 +171,7 @@ static void __init efi_arch_process_memory_map(EFI_SYST=
EM_TABLE *SystemTable,
         {
         case EfiBootServicesCode:
         case EfiBootServicesData:
-            if ( map_bs )
+            if ( map_bs || desc =3D=3D (EFI_MEMORY_DESCRIPTOR *)esrt_desc )
             {
         default:
                 type =3D E820_RESERVED;
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index ac1b235372..31664818c1 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -567,6 +567,38 @@ static int __init efi_check_dt_boot(const EFI_LOADED_I=
MAGE *loaded_image)
 }
 #endif
=20
+static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR;
+
+static bool __init is_esrt_valid(
+    const EFI_MEMORY_DESCRIPTOR *const desc)
+{
+    size_t available_len, len;
+    const UINTN physical_start =3D desc->PhysicalStart;
+    const ESRT *esrt_ptr;
+
+    len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
+    if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR )
+        return false;
+    if ( physical_start > esrt || esrt - physical_start >=3D len )
+        return false;
+    /*
+     * The specification requires EfiBootServicesData, but accept
+     * EfiRuntimeServicesData for compatibility
+     */
+    if ( (desc->Type !=3D EfiRuntimeServicesData) &&
+         (desc->Type !=3D EfiBootServicesData) )
+        return false;
+    available_len =3D len - (esrt - physical_start);
+    if ( available_len < sizeof(*esrt_ptr) )
+        return false;
+    esrt_ptr =3D (const ESRT *)esrt;
+    if ( esrt_ptr->Version !=3D 1 || !esrt_ptr->Count )
+        return false;
+    return esrt_ptr->Count <=3D
+           (available_len - sizeof(*esrt_ptr)) /
+           sizeof(esrt_ptr->Entries[0]);
+}
+
 /*
  * Include architecture specific implementation here, which references the
  * static globals defined above.
@@ -857,6 +889,7 @@ static void __init efi_tables(void)
         static EFI_GUID __initdata mps_guid =3D MPS_TABLE_GUID;
         static EFI_GUID __initdata smbios_guid =3D SMBIOS_TABLE_GUID;
         static EFI_GUID __initdata smbios3_guid =3D SMBIOS3_TABLE_GUID;
+        static EFI_GUID __initdata esrt_guid =3D ESRT_GUID;
=20
         if ( match_guid(&acpi2_guid, &efi_ct[i].VendorGuid) )
             efi.acpi20 =3D (unsigned long)efi_ct[i].VendorTable;
@@ -868,6 +901,8 @@ static void __init efi_tables(void)
             efi.smbios =3D (unsigned long)efi_ct[i].VendorTable;
         if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) )
             efi.smbios3 =3D (unsigned long)efi_ct[i].VendorTable;
+        if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) )
+            esrt =3D (UINTN)efi_ct[i].VendorTable;
     }
=20
 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */
@@ -1056,19 +1091,19 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHa=
ndle, EFI_SYSTEM_TABLE *Syste
     EFI_STATUS status;
     UINTN info_size =3D 0, map_key;
     bool retry;
-#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
     unsigned int i;
-#endif
=20
     efi_bs->GetMemoryMap(&info_size, NULL, &map_key,
                          &efi_mdesc_size, &mdesc_ver);
-    info_size +=3D 8 * efi_mdesc_size;
+    info_size +=3D 8 * (efi_mdesc_size + 1);
     efi_memmap =3D efi_arch_allocate_mmap_buffer(info_size);
     if ( !efi_memmap )
         blexit(L"Unable to allocate memory for EFI memory map");
=20
     for ( retry =3D false; ; retry =3D true )
     {
+        esrt_desc =3D (const EFI_MEMORY_DESCRIPTOR *)EFI_INVALID_TABLE_ADD=
R;
+
         efi_memmap_size =3D info_size;
         status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_siz=
e,
                                                          efi_memmap, &map_=
key,
@@ -1077,6 +1112,15 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHan=
dle, EFI_SYSTEM_TABLE *Syste
         if ( EFI_ERROR(status) )
             PrintErrMesg(L"Cannot obtain memory map", status);
=20
+        for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
+        {
+            if ( is_esrt_valid(efi_memmap + i) )
+            {
+                esrt_desc =3D efi_memmap + i;
+                break;
+            }
+        }
+
         efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_si=
ze,
                                     efi_mdesc_size, mdesc_ver);
=20
diff --git a/xen/common/efi/efi.h b/xen/common/efi/efi.h
index c9aa65d506..02f499071a 100644
--- a/xen/common/efi/efi.h
+++ b/xen/common/efi/efi.h
@@ -10,6 +10,23 @@
 #include <xen/spinlock.h>
 #include <asm/page.h>
=20
+typedef struct _ESRT_ENTRY {
+    EFI_GUID FwClass;
+    UINT32 FwType;
+    UINT32 FwVersion;
+    UINT32 FwLowestSupportedVersion;
+    UINT32 FwCapsuleFlags;
+    UINT32 FwLastAttemptVersion;
+    UINT32 FwLastAttemptStatus;
+} ESRT_ENTRY;
+
+typedef struct _ESRT {
+    UINT32 Count;
+    UINT32 Max;
+    UINT64 Version;
+    ESRT_ENTRY Entries[];
+} ESRT;
+
 struct efi_pci_rom {
     const struct efi_pci_rom *next;
     u16 vendor, devid, segment;
@@ -28,6 +45,7 @@ extern const EFI_RUNTIME_SERVICES *efi_rs;
=20
 extern UINTN efi_memmap_size, efi_mdesc_size;
 extern void *efi_memmap;
+extern const EFI_MEMORY_DESCRIPTOR *esrt_desc;
=20
 #ifdef CONFIG_X86
 extern mfn_t efi_l4_mfn;
diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
index 13b0975866..0d09647952 100644
--- a/xen/common/efi/runtime.c
+++ b/xen/common/efi/runtime.c
@@ -52,6 +52,7 @@ static unsigned int efi_rs_on_cpu =3D NR_CPUS;
 UINTN __read_mostly efi_memmap_size;
 UINTN __read_mostly efi_mdesc_size;
 void *__read_mostly efi_memmap;
+const EFI_MEMORY_DESCRIPTOR *__read_mostly esrt_desc;
=20
 UINT64 __read_mostly efi_boot_max_var_store_size;
 UINT64 __read_mostly efi_boot_remain_var_store_size;
@@ -269,7 +270,7 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info *in=
fo)
     case XEN_FW_EFI_MEM_INFO:
         for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
         {
-            EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
+            const EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
             u64 len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
=20
             if ( info->mem.addr >=3D desc->PhysicalStart &&
diff --git a/xen/include/efi/efiapi.h b/xen/include/efi/efiapi.h
index a616d1238a..42ef3e1c8c 100644
--- a/xen/include/efi/efiapi.h
+++ b/xen/include/efi/efiapi.h
@@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES {
 #define SAL_SYSTEM_TABLE_GUID    \
     { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1=
, 0x4d} }
=20
+#define ESRT_GUID    \
+    { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x2=
1, 0x80} }
+
=20
 typedef struct _EFI_CONFIGURATION_TABLE {
     EFI_GUID                VendorGuid;
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--6fndWT1Hd0pt5QFy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJe1pUACgkQsoi1X/+c
IsGPQxAAxsZVCYYTvdJhTNgRYq1pkjv+AOUMdymUQKXffX84MM8eMF8yHwysJ6N3
LciAgKaQTmaU7RQu2pNt6lu0ySzQADVQkgQYqRJogkOkPylz9tRm0VmLoTIS3P9B
rV7P24XBU2hWmm60ynM2nVofC7qE/vgOv4O4xplk9x+0Pc+Fb6cna/tCRgNdFg7c
6fX9gca7JYhav0hw61jZUqDhh3G/1UwzF7qapxdjCHw8hy15709XNz3BzAbzUsa1
Qq1YsfHR57KXEDPRAk/qVdAFuTggUaw5E5x/fFGqsVG8h3U2XV3JfhgLOVUz50u0
U9lwBV/8nWl5BT+Elk3rsQR6YNkgQ3nT92H6KDaXkNvXqlsORVPSJrVKyQ3yEYcm
eQijlifXrRjmXGyRcP9WJSdWIG1vv+2KbABhCn6PQPdoG+lppA5HhzufiwncBhO0
DitwoGv9HN3610/T9Ru/3AZbxlQe7tJrjLkimKl+kR73t3qJWBwYdiIWXz55NPjh
oZfWEX/XE74UHzxEkhPZ7CrxUU+YOsFDqBULx/U/SQWdcS+Lz0yu9cMQJi0sjFg2
JSoDIERvpNq4fRVbizT9CTbtPmwmldseAlfYmaxmh/AU45bWj3HENS3I8j5Cux/G
zU96DEDiTVa2z6ES84tnejeczhUCxQEus+2LHkyZegVohZCjKq4=
=km7a
-----END PGP SIGNATURE-----

--6fndWT1Hd0pt5QFy--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:39:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:39:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308272.523937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpx2-0001XH-Cz; Tue, 19 Apr 2022 15:39:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308272.523937; Tue, 19 Apr 2022 15:39:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpx2-0001XA-9w; Tue, 19 Apr 2022 15:39:36 +0000
Received: by outflank-mailman (input) for mailman id 308272;
 Tue, 19 Apr 2022 15:39:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngpx0-0001X4-F9
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:39:34 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e4d1a8f8-bff6-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:39:32 +0200 (CEST)
Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 11:39:17 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CH0PR03MB5985.namprd03.prod.outlook.com (2603:10b6:610:e0::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 15:39:14 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022
 15:39:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4d1a8f8-bff6-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650382772;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=PAwZASUasGY0RMM6nJT+C6GVW5YFgqKorJo3o8ipHOY=;
  b=B7KeTwJ7OEnenH/QVNHpfVNnijGB3hUQLD75tTW04KZUWIR1Uk1UZ6Ly
   vnWthsTGH1xlg/F+oDnMbbrETnWLucHf0jxGueYwc+ED+XcpumKaDT70n
   1I4neNzSNLOwxyeDROHMXSOm/d3r61SpT7rkL+JGJX2NpRJDWO9qRV54j
   g=;
X-IronPort-RemoteIP: 104.47.70.105
X-IronPort-MID: 71845912
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:wk+DHKkfXWszyZYA/kxa5CHo5gz9J0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIdCGjSb/+CYzDxe48ia9iwoUIE75GHytJjHQo9+C08RiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWlLV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYajoCG7LRsdQnfkdISCZPL5RUx4T4CC3q2SCT5xWun3rE5dxLVRlzF6tHv+F9DCdJ6
 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOVvZkBhGpYasNmRJ4yY
 +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVuszSOnVUruFTrGPrJIezQQZ8EpUSJl
 ETc7UPwUh4FO8PKnFJp9Vrp3IcjhxjTWogfCbm5/f5Cm0CIyyoYDxh+fUOyvP2RmkO4HdVFJ
 CQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCopc4+C6cD2kACzRHN9ovsZZuQSRwj
 wfU2dT0GTZorbuZD2qH8auZpi+zPi5TKnIeYSgDTk0O5NyLTJwPsy8jh+1LSMad5uAZ0xmqk
 1hmcABWa20vsPM2
IronPort-HdrOrdr: A9a23:mhaBraEbz9cXi1FRpLqFsZLXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq
 iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq
 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P
 nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo
 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp
 +ISedrP8M=
X-IronPort-AV: E=Sophos;i="5.90,273,1643691600"; 
   d="scan'208";a="71845912"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QaxKK7QFRdY6QW/phFJwTUcQABfA8aTeicilQgZdoaOxRFxtm33DFzH78LRFfmRbTC7VgUak3Sd0Zdfn9escmq95CaPvgbdSz4oLVfGN2kotFT4m24W1txlDy10wbUfGgmZlvPtqfCv/P/NEdDYC0K9JmUc+ImT1nVSVLMUFbAmLDrccfPwuu3tSOonwqHBbKDaT348AHn5KzZZiVDdwXqsPwqLbvswxMSVQ8WLZOyDdRcidf9o8yj8Ugn1E9WBjfMclo4QezmH10VfPXwigdYBBmUUpakyfgH1enncPtTyyi+Mv6DaPXTZXa6Ytxjxk84+NqaXlcvuQ41o598JhnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PAwZASUasGY0RMM6nJT+C6GVW5YFgqKorJo3o8ipHOY=;
 b=TpaDcgqFFoOJAlzICG3vDsKDWi6L9driq07LtqN02A4xBV5WjkIYXH3EcjjTuj+yTjih1+oESb1nI50qrzOpJwTekmhJXT5ORgD9Oqz/5S1KyxRHmqAnwL1AZwEK135pAQZ3IILol0/Syb1oENkTz2nANSV8adUiFDjBaSvuTku4GQwr0YVvsZonwqLAROaWEXxhy/vFV4gdKAbVub+HO1GGHnlZhuc/Oqi34GY5tgb7iT16MDamXaB+LkaQnWVOYCEkbNhKGQX/Yos4GGHkBJO13n07ap9ozZH43xodhyq7vcTetzTvu62RLyNYW9MrsWo7P87YsdFCnLLQAUAGjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PAwZASUasGY0RMM6nJT+C6GVW5YFgqKorJo3o8ipHOY=;
 b=abiSeNt5lJ0p/F1O0vutcFspXFgI9Vmoi9vhQ/v62JrBK2rLM1wShg13MskJnUhS9QW/bKtaAn0y66Pj8QjHf0+B6zaPAP5gqK58Bvjkl6guZRpryTUYDI9KGJ6WMsZUdHUdb7MwRsDTPvt1thInmyws+dXBTKDlHZDkLQtfVro=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Paul Durrant <paul@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Topic: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Index: AQHYU9FUwjuogeCS0EWgGeBVFIanqKz3DoiAgAACxwCAAE5MAA==
Date: Tue, 19 Apr 2022 15:39:14 +0000
Message-ID: <cbbd3bb9-c76e-7ba6-7cef-66d47e6d367b@citrix.com>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
 <6732a3c3-fc19-cbdf-7483-9f5946f1935a@citrix.com>
 <48fe2a98-98de-8aa5-8d3b-e70427008edb@suse.com>
In-Reply-To: <48fe2a98-98de-8aa5-8d3b-e70427008edb@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c2b62176-e459-4924-019a-08da221ac1fe
x-ms-traffictypediagnostic: CH0PR03MB5985:EE_
x-microsoft-antispam-prvs:
 <CH0PR03MB5985BCAC3B3078D346EEECFABAF29@CH0PR03MB5985.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 cid0RemNujOaGdNXsozCPljlG7edl8AwD+WlS0Z8sH2o2DVhohJosNhNHmS9f6gpTlwpJjZJdJJh/2W2q/q5g+xoaKP8b4VV+NWJsXBxnIKWzaw2e/rDXdqiFx1dUophxetgIjsNgIc/eIXovALC03zC2CUoW+3Eqh/RHbGHHbK35XPiK7+V81IO/nFTByhyLCYhc/PjqyBYHaCZAt84gbEVBA+lfkQhnCtCK6t6bUqyoPS2jqTjvWSsAPnvOMH424hJ71ba2AeoS53m9cQdSTw8zkPDSwVJ9V/ioSrTJSF3xj+J4cR1RCmcsFU+3MXewMO90QUpS2QzQ/DcF4z9RsAjP/KpZ6BS3WsDbFnx4G7ByZqS/cLQ270vT4PsTdgSyjqt2QPZ/6ZfKRxC2T1flzL1J21R2hKuNzCsbkz6dHq6GBdTTtqBBX46+PZUtfhVDE5KhtOo1we6mjVqQ/WpXSRCkqoe5TFFc6bIRg5cemvTTvL7J5FKfK2sT3t538/4jjCRWh1hsWgiClvealrvZqXfbVOebln/HLBVSmcKQqRN7ozAdcVYD2DzvvYkCy2cBgBBbMWW+RQovskLUIDZxjyl4Y1Z9UwxmvU/R5gJnk1VAI4rQ5nw66linHIqkQJmGDFF4ImoSaYP11wxc9PiMwAr8Ck519SHqIcdDVKhLiFgN9Di311WaooObRPu5OdS9gjEUe7fSiNwTUVNh7opgEUmFiFE/1JHbtxsNoXC592YG8DeE2rpFI3qSKYqzPo+AW274lXxoJzAn3nZXA2ueg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(186003)(508600001)(6486002)(6512007)(86362001)(8936002)(71200400001)(2616005)(2906002)(5660300002)(53546011)(6506007)(31696002)(91956017)(76116006)(66946007)(66476007)(36756003)(31686004)(4326008)(66446008)(64756008)(66556008)(8676002)(6916009)(54906003)(122000001)(82960400001)(38070700005)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MHlTZlIzOUJ5cjZsMzNIRUZScGtKQjBpSktCZ3NuRy9FbU1ZYXZYSFM4VlZj?=
 =?utf-8?B?TTQ4bU5QUnc0UW9qL2JJRjBRNjFma2ZVN3ZseHZiWUR6U1c3TzVDUnVYZERw?=
 =?utf-8?B?Nmd3bHUrQUd1cE1na1hNR0NQT1c0a1h5djFwdWo2dDV6SHg1UnVaem1nL1Bt?=
 =?utf-8?B?NXVjeXE5TWxDQ1loRjl6N3hpRVdmRXNkZEJPc0pTdXNMOG14U085a2ZRdXBt?=
 =?utf-8?B?S2dMWE9CMWJYdW83VWRaNngyYlU2cG15U1d6aHJ1WlNKYVV2eFpWU0xiaW5I?=
 =?utf-8?B?UlUyT2V2U1lWbGdwYTA1QkFINzNCRHYvQ0Q2WTNVMG9kQlhaUVA2RnB1T29s?=
 =?utf-8?B?US85Ym9pVTlkSG40WUpaZXlPSDdvaFJtQUxieGRKZzNXMVZqV0JaZlJobnE0?=
 =?utf-8?B?UU1IYkNEUTZrWFZUTFJqck03eWxuU09UN3lkUGNUeW0zSXB0R242NW1MOHow?=
 =?utf-8?B?ZXQybTBUUE1jaGdhejNDNFFzRjgrSmcrTXFTZzk2ck1nMVF1K1hhR011eHJP?=
 =?utf-8?B?dnNHYjB3MkNpa0hHUUlRL3lkWEhNd1lUK2o4dXJTWUNmYmNDQjRjekF3a09s?=
 =?utf-8?B?NUQyU0hCVzdJQVdaUmVHb1poY1FiUUZCNUVVaTU2TzlPdjFvZWh1ZER3NjA2?=
 =?utf-8?B?aUx5cUtCU0s0VFl2VHB2YUNjVUdCdEJwd09qOXVGdm9qeURhdGswQXRydGN1?=
 =?utf-8?B?ZHF0KzYzaWpEUDdJMS9JVnF4aUwweXJWTUx6ejJNRnh0R3I5dzFnU0IyN0dW?=
 =?utf-8?B?YUgwSi9MbFZXYWU5WGphaG91TnpYaVlmOFNjZEx4ZTdacUVKRWhvMU9vNjlY?=
 =?utf-8?B?bjNUVFk3d0FmdG51dTFGRGErVjNKWjB1R0ttbWo4NU4vZklmQUVReGdDNlMv?=
 =?utf-8?B?bkphMElaWm0vRlhZZjdIdFBHVVR4SmVOeVFjb0dGeHlpbXU4cCtLVDhJTU5C?=
 =?utf-8?B?TStXVFI3Rmp6R0ZwMUdCQzYyRlYvRWFiRnJEbGhRcHo5NlZQaTJYMXRHZHFq?=
 =?utf-8?B?VUtLYzhwT1NrUHdzZE1hSnlaVkJCYTljOHpJcXJHZVdTRmozekIyU2E4TE9i?=
 =?utf-8?B?dkxvWlJaVVkwbDRyZENjTnVxZGxMNzBmSjNXNVpnVy9ucTlDTFVwSjBuMnVk?=
 =?utf-8?B?dlNYVFU4alV1RHNIZkNtNktiK0ttdVpoa1VDRGJyak1YVGFKalBHZ216ZUo1?=
 =?utf-8?B?WFYvaFRJcmovTWp3UURDL2luYVBjZGNZWUh5RGFGRytEczM2NjUxSkVsdUVi?=
 =?utf-8?B?VUtWK2xjNGx5Rml1bC9uVWZqM1ZkV0FrSWNMamovUlJqcHdyU2NHWVFHS1dz?=
 =?utf-8?B?ZUQ1MXNZbHQyaVp5cWhYWlZyZHBEam4wOHJyOFcweE1weURMUTdDOTd4eFpy?=
 =?utf-8?B?cTA4WmlHRzdUUHJ3NG5xUFB6SEdpc3NXb1V2VTNYMlVrb1BrWWc4RWJKZ2Ny?=
 =?utf-8?B?Ny91TGNQbFlpTlVidENLekZXYUM5N3pJMW44V1lXdnB6cUx2bmZoQithVDdE?=
 =?utf-8?B?WlM5WEd4M05tTDBxTE1WUUF3OHJFTUN4VkladUhVTUVlVEhWREJ1NkN1Skpw?=
 =?utf-8?B?bmMzSzNwRGhKOElFd0czK2NtSGEwOEdSK2ZxdSsyTGhndSthZERqeEZYQ1hE?=
 =?utf-8?B?cGRIalZ2Q2prRDVPK0FITUFPbnFUMS9QOGVINTJVU0FiU3ZIam1qc29PaUEy?=
 =?utf-8?B?eFlEYmZjRW5VT1huTU5pU2U5c3Y2WS9IdXVxWDFmb3NQV1JOQ3Q2U3Jkd2hW?=
 =?utf-8?B?OWNIRG1XZy9sWW1oTXVyUHhyYnFONmtwOEFvQU5ldGswUTRWem9qdU83cnpT?=
 =?utf-8?B?VmJXODBJYVFrdUJreEVIU3pEbFgyRlR6SVozTEdtWmVrYVBOU2pIZmRORUxs?=
 =?utf-8?B?T3JGS282aEZJSHBIQUZGdHdWbUlVWWhVTzEzNEErMzAwUTlLbkxTbEgzcHZU?=
 =?utf-8?B?cjNSK0t3VDIvdTJNS0VUWVhxNStzT3psaUNJUkR1cGlESDNFdE0zWGprZHBI?=
 =?utf-8?B?aFAxQWVFSTNqUVBQbnhTVUthTVRvVG1wSmZvd3RaVXJqV0lhMEdxaEhLVWdx?=
 =?utf-8?B?TE9XWUJaVFBPMUYwdW4vc0laWWpzdDRCTnJ1Q28vcXBvckZORE5mblNjd1Rt?=
 =?utf-8?B?aWtoRnpydHhCaG1GMDZhc3ZadWgydHROYUdPYkt2M2VrZXhybkV3NG5nV1pr?=
 =?utf-8?B?VEkxTStKMG50S1NOaTdZOVhVWHhVVy9zQ1NxY21WQmVuYjhwcEZNVWVhK2N1?=
 =?utf-8?B?QnlBc3I5Yjl4V3lBTXNnR29qNFp0RVg2R1dUT1RpRFNvNm1SK3h2TjNBU0gr?=
 =?utf-8?B?c0NQM2lxL2EwQ1BobWxoOG9nQWNSb0cyTEpoUHdleGhFUERSUXgxdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <18C482F7B1C13C41A21CCE2D38206D45@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2b62176-e459-4924-019a-08da221ac1fe
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 15:39:14.4708
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TzXU5ZwSyQZeRJD+5aCdhBtaou+c4mbsLe0y/dx6L6G/PajYAd5k23/7/hBQ0Yxw9KQ1X6HzyD2lyfmaEU2HhY8Dbm65jHlwiJ0vZLFeyDE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5985

T24gMTkvMDQvMjAyMiAxMTo1OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE5LjA0LjIwMjIg
MTI6NDksIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxOS8wNC8yMDIyIDEwOjM5LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+IEZ1cnRoZXJtb3JlLCB1bmRlciB3aGF0IGNpcmN1bXN0YW5jZXMg
aXMgdGVzdF9hc3NpZ25fZGV2aWNlIGxlZ2l0aW1hdGUNCj4+IHdoZW4gcGFzc2luZyBET01JRF9J
TlZBTElEID/CoCBUaGlzIGhhcyBiZWVuIGJyb2tlbiBmb3IgMyB5ZWFycyBub3cNCj4+IHdpdGhv
dXQgcmVwb3J0LCBzbyBpdCdzIGNsZWFybHkgYW4gdW51c2VkIGNvZGVwYXRoIHVuZGVyIGJvdGgg
eGwncyBhbmQNCj4+IHhhcGkncyBpZGVhIG9mIHBhc3N0aHJvdWdoLg0KPiBJIGd1ZXNzIHhlbmQg
aGFkIGEgd2F5IHRvIGRyaXZlIHRoZSBkb21jdGwgdGhpcyB3YXkuDQoNCkxvb2tpbmcgYXQgdGhl
IHhlbmQgY29kZSwgaXQgYWx3YXlzIGNhbGxlZCB3aXRoIGRvbWlkIDAuDQoNCkkgY2FuJ3Qgc2Vl
IGFueSBldmlkZW5jZSB0aGF0IHRoZXJlIGhhcyBhY3R1YWxseSBiZWVuIGEgY2FsbGVyIHBhc3Np
bmcNCkRPTUlEX0lOVkFMSUQsIGJ1dCB0aGlzIGlzIGFuIHV0dGVyIG1lc3MuDQoNCj4gIElpcmMg
dGhpcyB3YXMNCj4gdG8gZmluZCBvdXQgd2hldGhlciBhIGRldmljZSBpcyBhc3NpZ25hYmxlIGF0
IGFsbCwgd2l0aG91dCBuZWVkaW5nDQo+IHRvIGtub3cgb2YgYW55IHBhcnRpY3VsYXIgdmFsaWQg
ZG9tYWluLg0KDQpJbiBhIGNvcnJlY3RseSBhcmNoaXRlY3RlZCBJT01NVSBzdWJzeXN0ZW0gKHdo
aWNoIFhlbiBtb3N0IGRlZmluaXRlbHkNCmRvZXMgbm90IGhhdmUgYXQgdGhpcyBqdW5jdHVyZSks
IHRoYXQgcXVlc3Rpb24gaXMgIkRvZXMgdGhlIGRldmljZSBoYXZlDQphbiB1cHN0cmVhbSBJT01N
VSIuDQoNClhlbiBkb2Vzbid0IGN1cnJlbnRseSBoYXZlIGEgd29ya2luZyBpZGVhIG9mIGFuIHg4
NiBzeXN0ZW0gd2l0aCBJT01NVXMNCmJ1dCBub3QgY292ZXJpbmcgYWxsIGRldmljZXMuwqAgV2hp
bGUgc3VjaCBhIHN5c3RlbSBpcyB1bmxpa2VseSB0byBleGlzdA0KaW4gcmVhbGl0eSwgdGhlcmUg
YXJlIGNhc2VzIHdoZXJlIHF1aXJrcyBjcmVhdGUgYXN5bW1ldHJpYyBjb3ZlcmFnZS7CoA0KRWl0
aGVyIHdheSwgdGhpcyBpcyBmdWxseSBzdWJzdW1lZCBieSB0aGUgZnV0dXJlIHdvcmsgdG8gYXNz
aWduIElPTU1VDQpncm91cHMuDQoNCkFsc28gYXQgdGhlIG1vbWVudCwgYmVjYXVzZSBYZW4gZG9l
c24ndCBzdXBwb3J0IHBlci1kZXZpY2UgSU9NTVUNCmNvbnRleHRzLCBhbm90aGVyIGNoZWNrIG5v
dCBwZXJmb3JtZWQgaXMgd2hldGhlciB0aGlzIGRldmljZXMgaWRlbnRpdHkNCm1hcHMgYXJlIGNv
bXBhdGlibGUgd2l0aCB0aGUgaWRlbnRpdHkgbWFwcyBpbiB0aGUgdGFyZ2V0IGRvbWFpbi7CoCBF
eHRyYQ0KY29tcGxleGl0eSBoZXJlIGlzIHRoYXQgaXQgd2lsbCBub3Qgb2NjdXIgb24gYSBzaW5n
bGUgc3lzdGVtDQooQ29uZmxpY3RpbmcgUk1SUnMvSVZIRHMgb24gYSBzaW5nbGUgc3lzdGVtIGlz
IGRlZmluaXRlbHkgYSBmaXJtd2FyZQ0KYnVnLCBub3QgYW4gYWNjdXJhdGUgZGVzY3JpcHRpb24g
b2YgdGhlIHN5c3RlbSk7IG9ubHkgd2l0aCBtaWdyYXRpb24NCmJldHdlZW4gc3lzdGVtcyB3aGVy
ZSBlcXVpdmFsZW50IGxvZ2ljYWwgZGV2aWNlcyBoYXZlIGRpZmZlcmluZyBpZGVudGl0eQ0KcmVx
dWlyZW1lbnRzIG9uIGRpZmZlcmVudCBzeXN0ZW1zLg0KDQoNCkkgZG9uJ3Qgc2VlIGFueXRoaW5n
IHVzZWZ1bCB0aGUgIndpdGggYSBkb21pZCIgdmVyc2lvbiBnZXRzIHlvdS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:40:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:40:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308276.523947 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpxe-0002nV-MD; Tue, 19 Apr 2022 15:40:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308276.523947; Tue, 19 Apr 2022 15:40:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpxe-0002nO-JC; Tue, 19 Apr 2022 15:40:14 +0000
Received: by outflank-mailman (input) for mailman id 308276;
 Tue, 19 Apr 2022 15:40:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngpxd-0002nA-BW; Tue, 19 Apr 2022 15:40:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngpxd-0001HA-9v; Tue, 19 Apr 2022 15:40:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngpxc-0006Fs-Vm; Tue, 19 Apr 2022 15:40:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngpxc-0008E2-VL; Tue, 19 Apr 2022 15:40:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MitSINBBYGsEN/skQCm72/g1DAU8C3uQngQ2t0ADu5Y=; b=aBAQDZhG9ghjRXiZcYMUmmXTKS
	8v29V9dbYGtR+bQypWHQhxJ+AUsSCir8TOrI6pDVv40DikXiUFyg8ZddIzOp5zqPpIzlk1tdPQfAT
	O1BBYDP82fB2sqt7Z8ryCWQhSiOEhD8VpO/9rGVgdHQs/GqRfqk/GGK4f0ypKcD6zxHA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169543-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169543: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 15:40:12 +0000

flight 169543 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169543/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  508 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:40:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:40:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308279.523959 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpxk-000387-47; Tue, 19 Apr 2022 15:40:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308279.523959; Tue, 19 Apr 2022 15:40:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpxk-00037y-0G; Tue, 19 Apr 2022 15:40:20 +0000
Received: by outflank-mailman (input) for mailman id 308279;
 Tue, 19 Apr 2022 15:40:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lfI/=U5=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ngpxi-0001X4-Mx
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:40:18 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02fca4bd-bff7-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:40:17 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id AC34F5C01A7;
 Tue, 19 Apr 2022 11:40:16 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Tue, 19 Apr 2022 11:40:16 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 19 Apr 2022 11:40:15 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02fca4bd-bff7-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650382816; x=
	1650469216; bh=y8YXkeeQ9GgwyGmaIEG/es/LlJnAcVQcC9VWjF18iw8=; b=k
	DqbBiwXLWZUu1Nitz4+JinnRFGiAsrST4QYi8bwctJD9v5OMPNCVj25Jd7UFGAGP
	+QNDpi7I/CxIP+tNuOz4L8ncTHgLDZqODX3Wi3SFsiEomHrwGOjgH32zrhGpXGZO
	j9KKl31AVoLzEO4GvFNERKdGbizNp8vPIiKOuTHzpICn0X0ZjaZGERar8+JVbnuO
	cPGbmUwO+Ag69ru6g0wNBAR8SJGZ8Z6a2vIFcAjEOF90Tq/Y0Uim5O7RDjW/F+/1
	j5wTtF6Wom/k7Lj6ZNCea2qIjlrlAZfdRATjiyyq1zhqQMCPKFPXdq+WIAbI6VyE
	MNn9DCvMogs+KuUCHQUtg==
X-ME-Sender: <xms:4NdeYoiiS57t8JYe7cYM57A8gauNviEDw3BZq7wsyfj-OI_E0S30Tg>
    <xme:4NdeYhCAkGf66m8iDQYUoZWoYpN4UQV4OH0Xc55MZzX2I6bYXpAc35ZFt3MnqNWDJ
    BvpHw9MLBUYG2c>
X-ME-Received: <xmr:4NdeYgE_tdHNQuhdOXMmX2kEoEZ3jglovu2xaIPFS3Qb1y1B-bvbvn4WaBQh>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgleduucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeffvghmihcu
    ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh
    hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetgeeuieehvdfhfefgtedvjeehtdei
    geduheeljeduveejheefvdeifeeuvddthfenucffohhmrghinhepkhgvrhhnvghlrdhorh
    hgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggv
    mhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:4NdeYpQlllga1Z_LsSMIxmVHAtm12VqHiDTsWag9hBmdwxN0IBJOqA>
    <xmx:4NdeYly8ZNalKqxclX6fcwDZ9Wb9A6wDgx2LykZLpkTMnjehWK0OYw>
    <xmx:4NdeYn531bcIInCci4-ThztEiqEd4bfb4tIeS24GMxTqSRrPHBmS_g>
    <xmx:4NdeYsm5hhlHxMxsySMvVWHawqB8dk_Xdz_2JblP7fnUmWcaP96mmQ>
Date: Tue, 19 Apr 2022 11:40:12 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 1/4] Grab the EFI System Resource Table and check it
Message-ID: <Yl7X3mAJhR5ENSpl@itl-email>
References: <Yl7WHv6+M+eJwQep@itl-email>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="L3mDJzuE5U39uQuT"
Content-Disposition: inline
In-Reply-To: <Yl7WHv6+M+eJwQep@itl-email>


--L3mDJzuE5U39uQuT
Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Apr 2022 11:40:12 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 1/4] Grab the EFI System Resource Table and check it

The EFI System Resource Table (ESRT) is necessary for fwupd to identify
firmware updates to install.  According to the UEFI specification =A723.4,
the table shall be stored in memory of type EfiBootServicesData.
Therefore, Xen must avoid reusing that memory for other purposes, so
that Linux can access the ESRT.  Additionally, Xen must mark the memory
as reserved, so that Linux knows accessing it is safe.

See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/
for details.

Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
---
 xen/arch/arm/efi/efi-boot.h |  1 +
 xen/arch/x86/efi/efi-boot.h |  2 +-
 xen/common/efi/boot.c       | 50 ++++++++++++++++++++++++++++++++++---
 xen/common/efi/efi.h        | 18 +++++++++++++
 xen/common/efi/runtime.c    |  3 ++-
 xen/include/efi/efiapi.h    |  3 +++
 6 files changed, 72 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index e452b687d8..ab2ad3dfe0 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -188,6 +188,7 @@ static EFI_STATUS __init efi_process_memory_map_bootinf=
o(EFI_MEMORY_DESCRIPTOR *
               desc_ptr->Type =3D=3D EfiLoaderCode ||
               desc_ptr->Type =3D=3D EfiLoaderData ||
               (!map_bs &&
+               desc_ptr !=3D esrt_desc &&
                (desc_ptr->Type =3D=3D EfiBootServicesCode ||
                 desc_ptr->Type =3D=3D EfiBootServicesData))) )
         {
diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
index 6e65b569b0..75937c8a11 100644
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -171,7 +171,7 @@ static void __init efi_arch_process_memory_map(EFI_SYST=
EM_TABLE *SystemTable,
         {
         case EfiBootServicesCode:
         case EfiBootServicesData:
-            if ( map_bs )
+            if ( map_bs || desc =3D=3D (EFI_MEMORY_DESCRIPTOR *)esrt_desc )
             {
         default:
                 type =3D E820_RESERVED;
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index ac1b235372..31664818c1 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -567,6 +567,38 @@ static int __init efi_check_dt_boot(const EFI_LOADED_I=
MAGE *loaded_image)
 }
 #endif
=20
+static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR;
+
+static bool __init is_esrt_valid(
+    const EFI_MEMORY_DESCRIPTOR *const desc)
+{
+    size_t available_len, len;
+    const UINTN physical_start =3D desc->PhysicalStart;
+    const ESRT *esrt_ptr;
+
+    len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
+    if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR )
+        return false;
+    if ( physical_start > esrt || esrt - physical_start >=3D len )
+        return false;
+    /*
+     * The specification requires EfiBootServicesData, but accept
+     * EfiRuntimeServicesData for compatibility
+     */
+    if ( (desc->Type !=3D EfiRuntimeServicesData) &&
+         (desc->Type !=3D EfiBootServicesData) )
+        return false;
+    available_len =3D len - (esrt - physical_start);
+    if ( available_len < sizeof(*esrt_ptr) )
+        return false;
+    esrt_ptr =3D (const ESRT *)esrt;
+    if ( esrt_ptr->Version !=3D 1 || !esrt_ptr->Count )
+        return false;
+    return esrt_ptr->Count <=3D
+           (available_len - sizeof(*esrt_ptr)) /
+           sizeof(esrt_ptr->Entries[0]);
+}
+
 /*
  * Include architecture specific implementation here, which references the
  * static globals defined above.
@@ -857,6 +889,7 @@ static void __init efi_tables(void)
         static EFI_GUID __initdata mps_guid =3D MPS_TABLE_GUID;
         static EFI_GUID __initdata smbios_guid =3D SMBIOS_TABLE_GUID;
         static EFI_GUID __initdata smbios3_guid =3D SMBIOS3_TABLE_GUID;
+        static EFI_GUID __initdata esrt_guid =3D ESRT_GUID;
=20
         if ( match_guid(&acpi2_guid, &efi_ct[i].VendorGuid) )
             efi.acpi20 =3D (unsigned long)efi_ct[i].VendorTable;
@@ -868,6 +901,8 @@ static void __init efi_tables(void)
             efi.smbios =3D (unsigned long)efi_ct[i].VendorTable;
         if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) )
             efi.smbios3 =3D (unsigned long)efi_ct[i].VendorTable;
+        if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) )
+            esrt =3D (UINTN)efi_ct[i].VendorTable;
     }
=20
 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */
@@ -1056,19 +1091,19 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHa=
ndle, EFI_SYSTEM_TABLE *Syste
     EFI_STATUS status;
     UINTN info_size =3D 0, map_key;
     bool retry;
-#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
     unsigned int i;
-#endif
=20
     efi_bs->GetMemoryMap(&info_size, NULL, &map_key,
                          &efi_mdesc_size, &mdesc_ver);
-    info_size +=3D 8 * efi_mdesc_size;
+    info_size +=3D 8 * (efi_mdesc_size + 1);
     efi_memmap =3D efi_arch_allocate_mmap_buffer(info_size);
     if ( !efi_memmap )
         blexit(L"Unable to allocate memory for EFI memory map");
=20
     for ( retry =3D false; ; retry =3D true )
     {
+        esrt_desc =3D (const EFI_MEMORY_DESCRIPTOR *)EFI_INVALID_TABLE_ADD=
R;
+
         efi_memmap_size =3D info_size;
         status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_siz=
e,
                                                          efi_memmap, &map_=
key,
@@ -1077,6 +1112,15 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHan=
dle, EFI_SYSTEM_TABLE *Syste
         if ( EFI_ERROR(status) )
             PrintErrMesg(L"Cannot obtain memory map", status);
=20
+        for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
+        {
+            if ( is_esrt_valid(efi_memmap + i) )
+            {
+                esrt_desc =3D efi_memmap + i;
+                break;
+            }
+        }
+
         efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_si=
ze,
                                     efi_mdesc_size, mdesc_ver);
=20
diff --git a/xen/common/efi/efi.h b/xen/common/efi/efi.h
index c9aa65d506..02f499071a 100644
--- a/xen/common/efi/efi.h
+++ b/xen/common/efi/efi.h
@@ -10,6 +10,23 @@
 #include <xen/spinlock.h>
 #include <asm/page.h>
=20
+typedef struct _ESRT_ENTRY {
+    EFI_GUID FwClass;
+    UINT32 FwType;
+    UINT32 FwVersion;
+    UINT32 FwLowestSupportedVersion;
+    UINT32 FwCapsuleFlags;
+    UINT32 FwLastAttemptVersion;
+    UINT32 FwLastAttemptStatus;
+} ESRT_ENTRY;
+
+typedef struct _ESRT {
+    UINT32 Count;
+    UINT32 Max;
+    UINT64 Version;
+    ESRT_ENTRY Entries[];
+} ESRT;
+
 struct efi_pci_rom {
     const struct efi_pci_rom *next;
     u16 vendor, devid, segment;
@@ -28,6 +45,7 @@ extern const EFI_RUNTIME_SERVICES *efi_rs;
=20
 extern UINTN efi_memmap_size, efi_mdesc_size;
 extern void *efi_memmap;
+extern const EFI_MEMORY_DESCRIPTOR *esrt_desc;
=20
 #ifdef CONFIG_X86
 extern mfn_t efi_l4_mfn;
diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
index 13b0975866..0d09647952 100644
--- a/xen/common/efi/runtime.c
+++ b/xen/common/efi/runtime.c
@@ -52,6 +52,7 @@ static unsigned int efi_rs_on_cpu =3D NR_CPUS;
 UINTN __read_mostly efi_memmap_size;
 UINTN __read_mostly efi_mdesc_size;
 void *__read_mostly efi_memmap;
+const EFI_MEMORY_DESCRIPTOR *__read_mostly esrt_desc;
=20
 UINT64 __read_mostly efi_boot_max_var_store_size;
 UINT64 __read_mostly efi_boot_remain_var_store_size;
@@ -269,7 +270,7 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info *in=
fo)
     case XEN_FW_EFI_MEM_INFO:
         for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size )
         {
-            EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
+            const EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i;
             u64 len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
=20
             if ( info->mem.addr >=3D desc->PhysicalStart &&
diff --git a/xen/include/efi/efiapi.h b/xen/include/efi/efiapi.h
index a616d1238a..42ef3e1c8c 100644
--- a/xen/include/efi/efiapi.h
+++ b/xen/include/efi/efiapi.h
@@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES {
 #define SAL_SYSTEM_TABLE_GUID    \
     { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1=
, 0x4d} }
=20
+#define ESRT_GUID    \
+    { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x2=
1, 0x80} }
+
=20
 typedef struct _EFI_CONFIGURATION_TABLE {
     EFI_GUID                VendorGuid;
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--L3mDJzuE5U39uQuT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJe190ACgkQsoi1X/+c
IsHNJQ//W2d8jOibu72naOLhu6PCNGKzdJOgRptgSMXUrEhVFELuw/WcXVlV5afX
ghnINwp9GjVyKDZ9Pv52P4aJmBRzfdxApFbjTGraJ8Yz6cUZs3z1M56nMlQFylEa
U0Gu4ZXtBR/IeU/rPO83AeRv0FoIxUmECmS5+mphutwlcc8skdD8moWX8ptx4oMJ
nZjdjjC+yA78wFVoEJiwFHni1M5G4o6rK4/hOWSg95Qu0FYkYtt79VvS01+WA1dO
S/0EbmXSDzGg+b0tEGnUDv6bnV0oDDA7LNJZMKvnjNUPdGBVwN6lnzCXWtr6BGT3
LF9U3uDeD7Vr9jJ6nMotL8AMc7xbuGIZfbEFj2jYFeMOJXX48dmVTTVUNuyAw4Kf
WcR4kc9MdW3mkgaRRfVlO9lpBCJ9Kx/Ouuddwcbwq4ojMWbfXL6obLbhEjTWdP0b
jOWSA5v6tiqPQIUuiiGKMD+Sg2lGmmSaT82CnmSAZeKBb5gkpfwO4vn1+gtGONSQ
7/rJDwDIvoGnydU6/ALQFAr1e4+OTWs+1p1pQLGg8rCDSIJrIpOsJCl9u2PfoQkU
HFmCfvBcb+uC2S30WFt6UO2aC3rvxD7OU2rx5pksWaJjmquzKhsGOHE56LSUTxXp
tSTWg5veY48n7RxiwCye2zcFTzD3Jb5yiZoXbJIVBpsw5LtQPLc=
=3GHb
-----END PGP SIGNATURE-----

--L3mDJzuE5U39uQuT--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:40:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:40:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308291.523969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpyE-0003uZ-DI; Tue, 19 Apr 2022 15:40:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308291.523969; Tue, 19 Apr 2022 15:40:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpyE-0003uS-AS; Tue, 19 Apr 2022 15:40:50 +0000
Received: by outflank-mailman (input) for mailman id 308291;
 Tue, 19 Apr 2022 15:40:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lfI/=U5=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ngpyD-0001X4-4Z
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:40:49 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 153e9ac8-bff7-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:40:48 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 731F15C017F;
 Tue, 19 Apr 2022 11:40:47 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Tue, 19 Apr 2022 11:40:47 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 19 Apr 2022 11:40:46 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 153e9ac8-bff7-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender
	:subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender
	:x-me-sender:x-sasl-enc; s=fm1; t=1650382847; x=1650469247; bh=3
	arqv03JGEGVKFR5SMcDPvfcQfJd+3ZKaEx4TULio5U=; b=qKNxCblSJz6gsng7G
	YoUR2s1K3Y2gRE0PZA7hmzMaeE0bqbiB1v0EvMyPWkqwRU3PQ8Zto7cL0hBiGuDb
	i1QFmcMp3w9JWYla75ac+cWalloxZ7fVv1Cd4XmGGFehWIJGLCeClFrJfvfHZ54x
	gkP6heZYzMBZTHl4W1pUHf59cB6YH62/BIJn8/uMiSe11NY9FlTi/UTFZIwj6qsT
	rYiW54QsxfPDmBV0Q3QYNkTqIvgpGxmd9dS9vKgqxJR1m+iXV58B8eJPmLjGnqrr
	rYu00HGEP7LRCPTNNUUaYJA+xcuL8posXX9o87r5u3E7U4Tw1nX79IqG2NSL531s
	GGrRg==
X-ME-Sender: <xms:_tdeYnstA60vZOalsoerbzGiOE2HSaoiYYvM_vweRfMOnnShNDjbIQ>
    <xme:_tdeYof7kGSvZH2kRojNGTi7JbBBWnJfZE6mtxufHy6-iYqFdZAHxgq6TqfBYEsas
    vavKQxhUj76HIU>
X-ME-Received: <xmr:_tdeYqy6iv2NEhQY0cm-g89Oj1MbipDw6oVcWJpHOoK20QyP5-Uqwb2E8gIx>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgledvucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhiucfo
    rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomheqnecuggftrfgrthhtvghrnhepveefleduheekhfdtfffffedukeevtedu
    leekfffgudfhtdduhfevueefueegtefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrg
    hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr
    sgdrtghomh
X-ME-Proxy: <xmx:_9deYmNvOxtqP_qBBhmnSnXDIIyZCDYoxbUF-gBRsIzZRpLy3v3yEg>
    <xmx:_9deYn8j6cNRrFpNvipfT6VXVfKyuSTza3IL7_mJ8F3NjD-9qXd1hw>
    <xmx:_9deYmXTIjx-jw5Ap7fl7LSFWMDSdupj71Z4LVXVHHI5OSBzNDhvgA>
    <xmx:_9deYpKBP81Mr0fqgniwSTJrX_nzCCTdaIjL-Isc5LUSq4YhWFXe4A>
Date: Tue, 19 Apr 2022 11:40:44 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 2/4] Add a dedicated memory region for the ESRT
Message-ID: <Yl7X/dT39vvhZmho@itl-email>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="weNRqal4jiKrbyKp"
Content-Disposition: inline
In-Reply-To: <Yl7WHv6+M+eJwQep@itl-email>


--weNRqal4jiKrbyKp
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Apr 2022 11:40:44 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 2/4] Add a dedicated memory region for the ESRT

This allows the ESRT to be marked as reserved without having to waste a
potentially large amount of memory.  This patch assumes that Xen can
handle memory regions that are not page-aligned.  If it cannot,
additional code will need to be added to align the regions.
---
 xen/arch/x86/efi/efi-boot.h     | 69 +++++++++++++++++++++++++--------
 xen/arch/x86/include/asm/e820.h |  2 +-
 2 files changed, 54 insertions(+), 17 deletions(-)

diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
index 75937c8a11..edf1fea3e0 100644
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -165,13 +165,14 @@ static void __init efi_arch_process_memory_map(EFI_SY=
STEM_TABLE *SystemTable,
     {
         EFI_MEMORY_DESCRIPTOR *desc =3D map + i;
         u64 len =3D desc->NumberOfPages << EFI_PAGE_SHIFT;
+        UINTN physical_start =3D desc->PhysicalStart;
         u32 type;
=20
         switch ( desc->Type )
         {
         case EfiBootServicesCode:
         case EfiBootServicesData:
-            if ( map_bs || desc =3D=3D (EFI_MEMORY_DESCRIPTOR *)esrt_desc )
+            if ( map_bs )
             {
         default:
                 type =3D E820_RESERVED;
@@ -179,9 +180,9 @@ static void __init efi_arch_process_memory_map(EFI_SYST=
EM_TABLE *SystemTable,
             }
             /* fall through */
         case EfiConventionalMemory:
-            if ( !trampoline_phys && desc->PhysicalStart + len <=3D 0x1000=
00 &&
-                 len >=3D cfg.size && desc->PhysicalStart + len > cfg.addr=
 )
-                cfg.addr =3D (desc->PhysicalStart + len - cfg.size) & PAGE=
_MASK;
+            if ( !trampoline_phys && physical_start + len <=3D 0x100000 &&
+                 len >=3D cfg.size && physical_start + len > cfg.addr )
+                cfg.addr =3D (physical_start + len - cfg.size) & PAGE_MASK;
             /* fall through */
         case EfiLoaderCode:
         case EfiLoaderData:
@@ -198,21 +199,57 @@ static void __init efi_arch_process_memory_map(EFI_SY=
STEM_TABLE *SystemTable,
             type =3D E820_NVS;
             break;
         }
-        if ( e820_raw.nr_map && type =3D=3D e->type &&
-             desc->PhysicalStart =3D=3D e->addr + e->size )
-            e->size +=3D len;
-        else if ( !len || e820_raw.nr_map >=3D ARRAY_SIZE(e820_raw.map) )
-            continue;
-        else
+
+#define ADD_ENTRY(len, type_, physical_start)                           \
+        if ( len )                                                      \
+        {                                                               \
+            if ( e820_raw.nr_map && (type_) =3D=3D e->type &&             =
  \
+                 (physical_start) =3D=3D e->addr + e->size )              =
  \
+                e->size +=3D (len);                                       \
+            else if ( e820_raw.nr_map < ARRAY_SIZE(e820_raw.map) )      \
+                continue;                                               \
+            else                                                        \
+            {                                                           \
+                ++e;                                                    \
+                e->addr =3D (physical_start);                             \
+                e->size =3D (len);                                        \
+                e->type =3D (type_);                                      \
+                ++e820_raw.nr_map;                                      \
+            }                                                           \
+        }                                                               \
+        else                                                            \
+            do {} while (0)
+
+        if ( desc =3D=3D (EFI_MEMORY_DESCRIPTOR *)esrt_desc )
         {
-            ++e;
-            e->addr =3D desc->PhysicalStart;
-            e->size =3D len;
-            e->type =3D type;
-            ++e820_raw.nr_map;
+            const ESRT *esrt_ptr;
+            UINTN esrt_offset, esrt_len;
+
+            BUG_ON(physical_start > esrt);
+            BUG_ON(len < sizeof(*esrt_ptr));
+            esrt_offset =3D esrt - physical_start;
+
+            BUG_ON(len - sizeof(*esrt_ptr) < esrt_offset);
+            esrt_ptr =3D (const ESRT *)esrt;
+
+            BUG_ON(esrt_ptr->Version !=3D 1);
+            BUG_ON(esrt_ptr->Count < 1);
+
+            esrt_len =3D (esrt_ptr->Count + 1) * sizeof(*esrt_ptr);
+
+            BUG_ON( len - esrt_offset < esrt_len );
+
+            ADD_ENTRY(esrt_offset, type, physical_start);
+
+            ADD_ENTRY(esrt_len, E820_RESERVED, esrt);
+
+            physical_start =3D esrt + esrt_len;
+            len -=3D esrt_offset + esrt_len;
         }
-    }
=20
+        ADD_ENTRY(len, type, physical_start);
+    }
+#undef ADD_ENTRY
 }
=20
 static void *__init efi_arch_allocate_mmap_buffer(UINTN map_size)
diff --git a/xen/arch/x86/include/asm/e820.h b/xen/arch/x86/include/asm/e82=
0.h
index 92f5efa4f5..98eca96425 100644
--- a/xen/arch/x86/include/asm/e820.h
+++ b/xen/arch/x86/include/asm/e820.h
@@ -16,7 +16,7 @@ struct __packed e820entry {
     uint32_t type;
 };
=20
-#define E820MAX	1024
+#define E820MAX	1026
=20
 struct e820map {
     unsigned int nr_map;
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--weNRqal4jiKrbyKp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJe1/wACgkQsoi1X/+c
IsHFtxAAp1e2QIOgX1bpt7qNcCU5Zsz899u1wSFeVNkiZXPfrfE8D4H8ORJZIl88
27e0V68HVQkE4uaJ9XgX9/WVCmSOrCGcX3frrJCbUHS7AvVDkEoxR9En0txPGX7q
rWuk3EpGrGdeaKYq2Ze6iQs4H7kPKmgi95fwyY/8pqw9gQAniHiJ3adSxBUafFfH
Ez/7LesMXKHLRUTWAUQzKNwQnH6VVBYarKap3DQCZOz0i9C9gWGrEt4CK3ygWipx
5b6lx+dOE5HbILaW5LbTFbdVZPaZ5dXPEDPJw5QPFK03AY8Q8L51O0f7M2K7Zue+
KWojkSWYtACQsisU0UYHcrYdMEFP69GjHfhPev7cAuchrRV56RCiXs1Mt9U3+mI6
htsW+Us0wIGyxElXfyEptPyQU/POeQ5KSaZjQ3DoBctCK7K3+8kBpFBQZ9jfQeER
uOUpXb5dQ0kG3boBiGrfNJFvmWSAX+2PDXEa7uLr0ryfc9o6L9vdYGab9mA9DEiF
VB6qmAQfnVpMkDRz4JWn3yYUJGBd0PDFv+Tpl/cmMvEuQj6s05P6m7PmPIGhilC7
HwNfPkZ7FBpT3mFGFpaczuS4/AWNWlQk5RcpdcrKw8jCTlhrajqyFF6SM+5TWRGg
JIxC7d2EvDVFKGxN+wbp6kksRPG+JGWEU4ECiqROELsAmoFPcFA=
=LKhS
-----END PGP SIGNATURE-----

--weNRqal4jiKrbyKp--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:41:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:41:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308298.523980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpzC-0004l7-NL; Tue, 19 Apr 2022 15:41:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308298.523980; Tue, 19 Apr 2022 15:41:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngpzC-0004l0-KW; Tue, 19 Apr 2022 15:41:50 +0000
Received: by outflank-mailman (input) for mailman id 308298;
 Tue, 19 Apr 2022 15:41:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hN/8=U5=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1ngpyu-0001X4-JK
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:41:32 +0000
Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com
 [2607:f8b0:4864:20::102d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2f03aa31-bff7-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:41:31 +0200 (CEST)
Received: by mail-pj1-x102d.google.com with SMTP id
 n33-20020a17090a5aa400b001d28f5ee3f9so2245766pji.4
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 08:41:31 -0700 (PDT)
Received: from localhost ([118.33.58.98]) by smtp.gmail.com with ESMTPSA id
 96-20020a17090a09e900b001cb62ee05besm20097807pjo.55.2022.04.19.08.41.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Apr 2022 08:41:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f03aa31-bff7-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding;
        bh=wkNciCU0DR7oGRSLBP7eFv/OfMFHpp+CXl9buHoOGYU=;
        b=ZzIryjPvICslU/syA+9rw+BgGs7UB2r1IdRyW6WFOI/sZ34b1kBNg2LcqKnFtObgh+
         VcT4zbjhXNSaOI/40J3EA0bMcxJ2Sanqpcgq/H8ZJRm5BJFec6+TonlAhXeIVF0NwgaN
         u36qrP1veorVNnAil4e/tCGdm2DhX+SeVo9nk+UjMnVqF3HJMS3yfyU5hCkFzzyc3vE1
         Qo0aAz8cuSCzorS1U2NiPmeMzr+gclsBjzNmjY5fbRPN9Y6MyXPML0zxVHWiTsnRJefj
         mzKrlsYC2Oq1qaQpF3ECVjzLd7qega2OIa9GthiBXFgY6Z9motmeYcwRz8nh6JM25WEV
         pGNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding;
        bh=wkNciCU0DR7oGRSLBP7eFv/OfMFHpp+CXl9buHoOGYU=;
        b=fzO1UKnkP5ankKBj0riQYwXOehzIzT4zfw9ahIoj/6zVgn3ALbQtq47nQmST8WgNxR
         KXMdV1vZsK4EN6cU8xZeTbHEqUjWtrpqnihBzKJlNpu8R7mDb6OYKDkMBBDaM0JzsXHQ
         us9UdmtEnGVwa4hZG0ghur0tLAKMZmPEn2iQYctI7UI2q/DUVojARBFQW+g9bvk950HU
         pVcvHn+xXcDN8kvfpqsGEYvIEqYTA5xxjifYVnmkvQDhjI0zZaC1VkORmV/0hNlT2lLw
         mtsLhsqL5n2WYDZHEwKQr7MCvtNKFzqmLh3fOD/j/4uqDkwbNtYOShAcAs5BbkoxTYow
         NEvg==
X-Gm-Message-State: AOAM531KhPXe5Nf69AbWXK0XOH0uVKI9wONx4NMwxE2ILYkxBFM188dq
	c3vpjydC4V8OzAFcl6/Ez50=
X-Google-Smtp-Source: ABdhPJy7zpzuVn45q/UVu6GvXVrBV3Yd1937AHPs+ddYtAp2+/PQmex67JZPVoOo5UQEIuvABy/oqQ==
X-Received: by 2002:a17:90b:38c4:b0:1d2:66cf:568f with SMTP id nn4-20020a17090b38c400b001d266cf568fmr17224404pjb.18.1650382890185;
        Tue, 19 Apr 2022 08:41:30 -0700 (PDT)
Date: Wed, 20 Apr 2022 00:41:26 +0900
From: Paran Lee <p4ranlee@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Austin Kim <austindh.kim@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: [PATCH] xen/arm: silence ambiguous integer casting warning error
Message-ID: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

GCC with "-g -Wall -Wextra" option throws warning message as below:

error: comparison of integer expressions of different signedness:
 ‘int’ and ‘unsigned int’ [-Werror=sign-compare]

Silence the warning by correcting the integer type.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 xen/arch/arm/gic-v3.c | 5 +++--
 xen/arch/arm/setup.c  | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 3c472ed768..81ac25f528 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)
     isb();
 }
 
-static u16 gicv3_compute_target_list(int *base_cpu, const struct cpumask *mask,
+static u16 gicv3_compute_target_list(unsigned int *base_cpu,
+                                     const struct cpumask *mask,
                                      uint64_t cluster_id)
 {
     int cpu = *base_cpu;
@@ -953,7 +954,7 @@ out:
 
 static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t *cpumask)
 {
-    int cpu = 0;
+    unsigned int cpu = 0;
     uint64_t val;
 
     for_each_cpu(cpu, cpumask)
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..5ab2aaecaf 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -862,7 +862,7 @@ void __init start_xen(unsigned long boot_phys_offset,
                       unsigned long fdt_paddr)
 {
     size_t fdt_size;
-    int cpus, i;
+    unsigned int cpus, i;
     const char *cmdline;
     struct bootmodule *xen_bootmodule;
     struct domain *d;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:46:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:46:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308310.523992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq3f-0005Zl-Dg; Tue, 19 Apr 2022 15:46:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308310.523992; Tue, 19 Apr 2022 15:46:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq3f-0005Ze-Af; Tue, 19 Apr 2022 15:46:27 +0000
Received: by outflank-mailman (input) for mailman id 308310;
 Tue, 19 Apr 2022 15:46:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hN/8=U5=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1ngq3d-0005ZY-7U
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:46:25 +0000
Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com
 [2607:f8b0:4864:20::52e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dd35f2ab-bff7-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:46:24 +0200 (CEST)
Received: by mail-pg1-x52e.google.com with SMTP id h5so24434302pgc.7
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 08:46:24 -0700 (PDT)
Received: from localhost ([118.33.58.98]) by smtp.gmail.com with ESMTPSA id
 d139-20020a621d91000000b00505aa0d10desm17001194pfd.0.2022.04.19.08.46.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Apr 2022 08:46:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd35f2ab-bff7-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding;
        bh=6BG+RIksgbZTEj/9zUG9lgF5QU8jZwsywEaD/+BOtvM=;
        b=FzWAF9GgsnGSSbOr3x4q7dLveuqFq9PvQdzhBro+/ZYJJ5ro1rUdgNPd63IusHP1vj
         V3wj9BBNC4CDwBdkEORDcUsbwos06DjcGku8h2FoXdKNJUGOL0D8kFAQsGQ9qjE81/B3
         iunuVO8HFB/X7IzDWM+ZHiGlnrjFdGyvDtZOKaCeTMRBzZbV0WuXyMyY7hf4QdXfnghy
         wdN1O06IGw/LY+I6mPmgpgCzf2hxM6eLRZhTv2G0n4aKOBUybX89Fw2Bd7dnM0GNqg22
         bMp+IjC4mda6R9GSZvMGqAvJYgOR1QaOvbI01lBbUcrefYk4UDHxFHHKANpeUbvtlVVq
         D6Yw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding;
        bh=6BG+RIksgbZTEj/9zUG9lgF5QU8jZwsywEaD/+BOtvM=;
        b=Wbkki+9ONeoQ0ZgI0EKC/DX7i9LtSf/iUf+yockAp+gIqkptgQoyde489hzWCJ3zJ6
         Uzg26XbYRG5YgS0jHr50hrs5P+Lb4surLGYBeALEsJs9Wd/oPDsffYYQnnabl+cK2+s1
         GOfXAUb/4bnpJiDWpnsHGhWIT1gUuOxVOFzAzqpyB3xX20FrjdMlhzT5sTBtF4c2rUIG
         F4fPyvAb68wjQnxZp7JK/Pbqlh121t9JpXNuPz3v2ASiDRD8W7eJCHUrhYc53f/fxAdT
         kRiPhgFjO0A4bpOcBa1CrTeOkr4jgvhPR2ZmSw6UvxlDqozKzZqnBLGcFrvHbBSX4jtP
         1l8g==
X-Gm-Message-State: AOAM533tRBpl0KeAbeZBYWevWTaQ74xkeDf8lqOPUAkQ3xv3N06zUBVp
	b8Ej7lKYikgBfSEiy7RShyg=
X-Google-Smtp-Source: ABdhPJzcbmbLOeCiojnBYy2e5lIdM8/t9skNUIJFGVWqAiWoyTyedrtKtdqxUIHVJXv1iXGShWDeVw==
X-Received: by 2002:a62:5287:0:b0:505:651c:ffae with SMTP id g129-20020a625287000000b00505651cffaemr18171393pfb.13.1650383182481;
        Tue, 19 Apr 2022 08:46:22 -0700 (PDT)
Date: Wed, 20 Apr 2022 00:46:19 +0900
From: Paran Lee <p4ranlee@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Cc: austindh.kim@gmail.com, xen-devel@lists.xenproject.org
Subject: [PATCH] xen/device_tree: silence ambiguous integer casting warning
 error
Message-ID: <20220419154619.GA3136@DESKTOP-NK4TH6S.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

GCC with "-g -Wall -Wextra" option throws warning message as below:

error: comparison of integer expressions of different signedness:
 ‘int’ and ‘unsigned int’ [-Werror=sign-compare]

Silence the warning by correcting the integer type.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 xen/common/device_tree.c | 31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 4aae281e89..402e465c7a 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -79,7 +79,7 @@ struct dt_bus
     const char *addresses;
     bool_t (*match)(const struct dt_device_node *node);
     void (*count_cells)(const struct dt_device_node *child,
-                        int *addrc, int *sizec);
+                        unsigned int *addrc, unsigned int *sizec);
     u64 (*map)(__be32 *addr, const __be32 *range, int na, int ns, int pna);
     int (*translate)(__be32 *addr, u64 offset, int na);
     unsigned int (*get_flags)(const __be32 *addr);
@@ -569,7 +569,7 @@ static bool_t dt_bus_default_match(const struct dt_device_node *node)
 }
 
 static void dt_bus_default_count_cells(const struct dt_device_node *dev,
-                                int *addrc, int *sizec)
+                                       unsigned int *addrc, unsigned int *sizec)
 {
     if ( addrc )
         *addrc = dt_n_addr_cells(dev);
@@ -649,7 +649,7 @@ static bool_t dt_bus_pci_match(const struct dt_device_node *np)
 }
 
 static void dt_bus_pci_count_cells(const struct dt_device_node *np,
-				   int *addrc, int *sizec)
+				   unsigned int *addrc, unsigned int *sizec)
 {
     if (addrc)
         *addrc = 3;
@@ -737,7 +737,7 @@ static const struct dt_bus dt_busses[] =
 
 static const struct dt_bus *dt_match_bus(const struct dt_device_node *np)
 {
-    int i;
+    long unsigned int i;
 
     for ( i = 0; i < ARRAY_SIZE(dt_busses); i++ )
         if ( !dt_busses[i].match || dt_busses[i].match(np) )
@@ -754,7 +754,8 @@ static const __be32 *dt_get_address(const struct dt_device_node *dev,
     u32 psize;
     const struct dt_device_node *parent;
     const struct dt_bus *bus;
-    int onesize, i, na, ns;
+    unsigned int i;
+    unsigned int onesize, na, ns;
 
     /* Get parent & match bus type */
     parent = dt_get_parent(dev);
@@ -797,8 +798,7 @@ static int dt_translate_one(const struct dt_device_node *parent,
                             int pna, const char *rprop)
 {
     const __be32 *ranges;
-    unsigned int rlen;
-    int rone;
+    unsigned int rlen, rone;
     u64 offset = DT_BAD_ADDR;
 
     ranges = dt_get_property(parent, rprop, &rlen);
@@ -857,7 +857,7 @@ static u64 __dt_translate_address(const struct dt_device_node *dev,
     const struct dt_device_node *parent = NULL;
     const struct dt_bus *bus, *pbus;
     __be32 addr[DT_MAX_ADDR_CELLS];
-    int na, ns, pna, pns;
+    unsigned int na, ns, pna, pns;
     u64 result = DT_BAD_ADDR;
 
     dt_dprintk("DT: ** translation for device %s **\n", dev->full_name);
@@ -966,8 +966,7 @@ int dt_for_each_range(const struct dt_device_node *dev,
     const struct dt_bus *bus, *pbus;
     const __be32 *ranges;
     __be32 addr[DT_MAX_ADDR_CELLS];
-    unsigned int rlen;
-    int na, ns, pna, pns, rone;
+    unsigned int rlen, na, ns, pna, pns, rone;
 
     bus = dt_match_bus(dev);
     if ( !bus )
@@ -1134,7 +1133,7 @@ unsigned int dt_number_of_address(const struct dt_device_node *dev)
     u32 psize;
     const struct dt_device_node *parent;
     const struct dt_bus *bus;
-    int onesize, na, ns;
+    unsigned int onesize, na, ns;
 
     /* Get parent & match bus type */
     parent = dt_get_parent(dev);
@@ -1169,8 +1168,8 @@ int dt_for_each_irq_map(const struct dt_device_node *dev,
     const struct dt_device_node *ipar, *tnode, *old = NULL;
     const __be32 *tmp, *imap;
     u32 intsize = 1, addrsize, pintsize = 0, paddrsize = 0;
-    u32 imaplen;
-    int i, ret;
+    u32 i, imaplen;
+    int ret;
 
     struct dt_raw_irq dt_raw_irq;
     struct dt_irq dt_irq;
@@ -1354,8 +1353,8 @@ static int dt_irq_map_raw(const struct dt_device_node *parent,
     const struct dt_device_node *ipar, *tnode, *old = NULL, *newpar = NULL;
     const __be32 *tmp, *imap, *imask;
     u32 intsize = 1, addrsize, newintsize = 0, newaddrsize = 0;
-    u32 imaplen;
-    int match, i;
+    u32 i, imaplen;
+    int match;
 
     dt_dprintk("dt_irq_map_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n",
                parent->full_name, be32_to_cpup(intspec),
@@ -1737,7 +1736,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np,
 
             if ( out_args )
             {
-                int i;
+                u32 i;
 
                 WARN_ON(count > MAX_PHANDLE_ARGS);
                 if (count > MAX_PHANDLE_ARGS)
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:49:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:49:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308316.524002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq69-0006AK-Ru; Tue, 19 Apr 2022 15:49:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308316.524002; Tue, 19 Apr 2022 15:49:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq69-0006AD-On; Tue, 19 Apr 2022 15:49:01 +0000
Received: by outflank-mailman (input) for mailman id 308316;
 Tue, 19 Apr 2022 15:49:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngq68-0006A7-LI
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:49:00 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3981191f-bff8-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 17:48:59 +0200 (CEST)
Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 11:48:56 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BY5PR03MB5045.namprd03.prod.outlook.com (2603:10b6:a03:1e6::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 15:48:53 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022
 15:48:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3981191f-bff8-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650383339;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=CN7iJu3+WgRtQBoa4LugFHQmLBVb+qeMz0d7acpQ1DI=;
  b=EJ7j17OB4TDIjdsfjAzUztHDCTmBYgCiXsneUsbDnM0nuTZRQ2oYWvVF
   7pB7VaW4FlUt7uMngO7arhcLgDENIeTle5ExiHUvkHeWO4it6BH/mqHKh
   Jq1LGtG9TLXBZ0izr0hUAoAQcHp++4pm2pVojShBCpmd0CQVa6ws/F5a0
   4=;
X-IronPort-RemoteIP: 104.47.58.102
X-IronPort-MID: 69299652
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:CsnKHq6SztKQmqu33Ly11wxRtDfGchMFZxGqfqrLsTDasY5as4F+v
 jBKC23VPPnYamKmfN0gaYW1pB9T7JOEn99mTQdk/y08Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTgUlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSyTTkvD62dyd86WjJ7CDpPJ6BL2aP+dC3XXcy7lyUqclPK6tA3VAQaGNNd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YAhl/chegXdRraT
 +MfZSBic1LrZBpXN01MIJk/gP2plj/0dDgwRFe9+/ttsjmNkVYZPL7FEerFW4Cqd8Fsp3nDh
 CXj2lbIXwlZDYnKodaC2jf27gPVpgv5Uo8PELyz9tZxnUaegGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yFactwMYc8pdFas98g7l4qjb+QGCHUAfUyVMLtchsacLqScC0
 1aIm5blAGJpubjMEXaFrO7M93W1JDQfKnIEaWkcVwwZ7tL/oYY1yBXSUtJkF63zhdrwcd3t/
 w23QOEFr+17paY2O2+TpAmvb+6EznQRcjMI2w==
IronPort-HdrOrdr: A9a23:1wZtF6/9yPQnoX/qZwRuk+GBdr1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79
 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6
 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1cjegIK5Y1n3X
 nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3bRY0eTFcZcso+5zXQISdKUmREXeR
 730lEd1vFImjbsl6eO0ELQMkfboW4TAjTZuCKlaDPY0LDErXQBeot8bMtiA2XkAwBLhqAC7I
 tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOJ1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+
 uzUagmdsPeEQ==
X-IronPort-AV: E=Sophos;i="5.90,273,1643691600"; 
   d="scan'208";a="69299652"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OviiamYew0XevVa7kSZTlDjT6mAbIBF8Kxlr0GNS1ACqap7J7ykc9y/e//LkWleoWUfN/8KB9mMK9YB1P4/+hNzifW/pWYdBQ5SI4b+XM/tKn1IBqoqhJBIyLvMF5pf6ijKvN6bECFxQGgEgs7EGRwmX6Y+jkgWGxFks7NJ2LiT2MgDkZTho9mdL9xj0yGqBe7cWpo1asGOjhnxutugnh7II7eZ5AbBfexabyLRsy/HKv9g7cmdxrSO0vUr+ZqPnkeNaEtNECIXgCSTAQcq1epe5l++8l360KVl2n1RbKtDYsbB5+4dML8B7mzoCOvknaO4QjjulFTfB66BGWplYqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CN7iJu3+WgRtQBoa4LugFHQmLBVb+qeMz0d7acpQ1DI=;
 b=n1HBYqmTlk0UyyhytHQE5nkR8x1UhR2L4FFCRC9tVZUXLsxDDxalK20CAyTJVfxETLGJcq1KqmHRg5gNPdVLgfsVkKSNyKQgBaTRRmBTctQW2l24jdt/cwQSH501mTVuWm8ySPWOaJhefZG0QxVCVvdykIWDKXF2VGzKBngXtlt5n3IwA9KoDDRxC7wAoarjUrwUyH76rnoxseXOXTAxdSK2yD3kHCeIEJwa9VOyyQFXq277ydeyLRaGRi+JW+L0FBfdvVJxGalC+tZzZRVMzHVtaavDcqoUlnmzmxRQ++rrplzKHvwrGNqkPSe2yfkmshJF3UU8vy/KZa/LfE8kng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CN7iJu3+WgRtQBoa4LugFHQmLBVb+qeMz0d7acpQ1DI=;
 b=T9ZeO67aw8jr1P2qmT9tPwtt8nRDA/OwjHqmLbdhTjc4YHDBeE55HnQOegSNQbjezKSBTnNNxRPKeltOWuejmy4Yz3JWZBmfiC/CwQfy8RhBecHkCSugQ8AMx5L+S2CB7wD1zi4GZkz/bwpG1ZiZy+3P7+vxHXVdCr+YadAJDhQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Topic: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Index: AQHYU9FUwjuogeCS0EWgGeBVFIanqKz3Yk2A
Date: Tue, 19 Apr 2022 15:48:53 +0000
Message-ID: <8a8aa0c1-e6f3-2dc0-77d4-282af89f4ed6@citrix.com>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
In-Reply-To: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f45b9b4f-3102-4c3d-8809-08da221c1b1d
x-ms-traffictypediagnostic: BY5PR03MB5045:EE_
x-microsoft-antispam-prvs:
 <BY5PR03MB50456E0C519FA1C67007A5F2BAF29@BY5PR03MB5045.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 rR4WixcqE0j3j3B4NUdXoLwQvN6PypVJGrdXhA0BeYS3UmQQKWIEFmSTwwkFH5hquy+WMG0t7s9JawDGIYPHhXKjUem+mYunswHQKbtLuFCMfAqDMBoHSaownRgUrb5NTsB1YAqx+ScQJj2CRhXqsQDmZVEmm8UNyXCUKA60hYoG7ewKa6DNMtJ8gzVOeu/iuAE2kCrw4IWxB2SrYVfVWXzcd+0ABkzuUMONIu58ZyXn6RAXQbHCgsdTSiRsOGian/s8fvr/IkUW7w5leZ+4JXhctP3RpQbpvrnGEhKiOKanPBw8/IvKc0BqMXKJJd3NUFVolI7qF6quFl5olPBtB4zeL8kvloNg2MOloZItvGGM6/P+ryZZ/iEHr2TCl9i9YCvj14tClos5rge3JFwGZjdWdFrA90K9d4D3sbc4RuVW0uGMwyCmXvN1nmCmBDsAxhZ6KjmNsAh/ClxXV1CnCBCjw66Qmc7IpvUELwr/heStc05wO78ewM20oviH4NKaOJERJ/vCo+SHUdsyPTE9Wq3djnB+WAg960tSo/MdraWixLfKQAleTK6K+tGDf5rrVe1V/hRbTcSSMXd+CAzHRF/Jjri2R23AFEIMmTAVYMx7907sbZE9kcVMlesGfYQYLWTiZHadlV/77cZPgwgfBECViJ5iS4nERFBYf0dKiUIV+T/AEMn3MMnRjthoOH9pku3hVr6SdCjgdifrhIGaJBVKzfxNjDiDbtozVHNrY5HvvvhSa5/ZADd0T/9TjadFpiTuXP6qRPMfWDXiVC6pOw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(38100700002)(66446008)(91956017)(76116006)(54906003)(66556008)(6486002)(316002)(2616005)(31696002)(71200400001)(66476007)(8936002)(110136005)(8676002)(4326008)(4744005)(122000001)(64756008)(53546011)(5660300002)(2906002)(38070700005)(508600001)(186003)(26005)(36756003)(82960400001)(86362001)(6512007)(6506007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?NnRZVXNNUEpHRVpQeDMrT0F1Q2NSbDJRbk13OGsxcWhoT2lreXJyQnNvbzlm?=
 =?utf-8?B?cXZJY1R2NWNPSFUxRGVBSnhPU1lUYVF4KzUrZGxkS0J5cURSMGdPaWoxMmVF?=
 =?utf-8?B?ZllTRk5mU2NaamhXMjNBRi9pbXMvNXpUMk9oblRPR0JiZmZHaE9oaVI2MjdE?=
 =?utf-8?B?MnE2ajFEbUxZaG5WdGZWaXFJQmh3ZVU0TE1DYXBDN2ZLR3ZTVFJlejlKdzdw?=
 =?utf-8?B?cTR5cmZMclZGbm8ycWhWcmxNeFhRNi82N1krUGdkL0R3aGlEcmR4K0twNzRl?=
 =?utf-8?B?MnlMenJLNEF2UnY0TDBKUGRBZHN5Tm9PdVZDRjRWQ2ZwUzdTc0VGOXZzelNr?=
 =?utf-8?B?dWxyZDdzcy9NODB0L1hLQ1R2NzU2M2ZpM05PWFRhVFljREIwK2xhK0c1aG84?=
 =?utf-8?B?dy9aUENNME1GNFBhYjg3WVJKSXVMMDkxNk8zNmJ6RmRqczlIMzI2QUF3SFp0?=
 =?utf-8?B?MGhidm14VEFFaU81eEVXQ1g1d1dTcmN3TjNpeVdyUzNROFlQWmU5a3BlMi9N?=
 =?utf-8?B?bUprajRwSXBFUHlmVkVwK1A5Nys5NkJQak1hRm05MzlSQUZ1c3Q1cEJ1NjVo?=
 =?utf-8?B?Ujl6SVJyNm9Eb1FQWmcvR0VRSmdBRzVpVTdqLzVVWnhqQ3BiUWtJdGhaMHl0?=
 =?utf-8?B?VGtEV21zLytWOTlGQTV3ekZrVlc1V3h4ZHJ6dEJwT09sakp3eHR6MTZ2QjB2?=
 =?utf-8?B?bVM0RFA4SFFtWkZpVE1WdUVsRDkzSTQ2N21QYmk0NGYraVlwTmVraHJtY1Ex?=
 =?utf-8?B?TjVMemt2dUtCS0luUmZyMTNka2R0VkV6VW5QUDh6RE1VVnVRV2dBSmVMVjJZ?=
 =?utf-8?B?eng5ak1ZTHUwRjlZTW84QkVyUXg0NjdWcmpIZDgzd2FQVnJBeXNJRFUyWE56?=
 =?utf-8?B?eTcvdzZhblpDaCtPeThSSEZlT0dxd3JnZitDek5DRkFaTkFmY2V1ZDVqUjJR?=
 =?utf-8?B?UXRkVjhnN0NRRHF5RGdNR0V0VHgyMnI5dDJ1RjNYZTF1VjB6S1NxMWZRcGV6?=
 =?utf-8?B?ZXJNeE5SVG5tMFZTUWFRb0lKeTBmemViTzMwckhVMmNnSDVuS0F0c0lSeHdM?=
 =?utf-8?B?ZXYrQ2RaQzJqNWUyd1FuRmpNVi9CbHNZNUQ3S0xjbHhyOWlzV09GZ0I3ZnhO?=
 =?utf-8?B?NFd4cWNDWlhKTFdEOFVlcS95V2VlZEpnaWU0V1pUK0o5eXZLRE5pOURlSUNx?=
 =?utf-8?B?SW1FRkZtZEpsaFhIWWR3MG5jZmREQWxQTVlkU1J4amkrU09vdUtwUUtudU9H?=
 =?utf-8?B?amRDY3l6c3BIai9YeUx0OExmWUtpNVlEemtaOUtNTURMMUF0WHpTa0gwWnM4?=
 =?utf-8?B?UU1EOGs5ajRwMG9JRE5TUkg5ZUVLZmcxbkRkMjQ4Wlp5QnppWUIxVjhXTlFK?=
 =?utf-8?B?VlpzdVdBcENldzcrYnhBZWtSa1NXaWkyR2VIZ2FrZVludUFhQ1JIK1NMV3dP?=
 =?utf-8?B?K0J4bk9aVytOQlgzc3RodE5QdjNHZXRJZFVxNmQrLytpMXp1aDVxbytnYUY3?=
 =?utf-8?B?RU1uSkI1bmpMS3o0RnlTTDltZmE2aUpPaFlEQzFMWjh5WC9BSC9KUkVsc2tl?=
 =?utf-8?B?YzlVUHgzeHY3dldQMWRBL0ZEaTJPWnV3ZEtONUhMTHdxRDhPKzNma3lBUjd2?=
 =?utf-8?B?aExheS9aQ2NMZjdwNHZpVTdHd08vUWN5RmdkWVFaMGNmU2xibWdxTW1LRDF0?=
 =?utf-8?B?R25xVTRUR2U5TTBXUTE3b1NVNDN4blVicEVuTzFEWFlPNnFPZmpYZjIyL2JT?=
 =?utf-8?B?dVBnOVhRS3RZcU9teEswWDBIMXV0bXJnMjNqVExWL2xzNHdNbHZBR1R6QXhD?=
 =?utf-8?B?bVk0NlZNZjVJYjRIYVZOTnAySXNwZUxqYTlXTWpBY211VkZWUEFPL3ZhU3BW?=
 =?utf-8?B?RHpyeXlPTml3bUZUMzVGbHhtZFAxNmVtNW81WUFFYlVSV29TOU9jY0lZdTRk?=
 =?utf-8?B?NTRIV1FUaWZVN21sNWZvUUxUcmRzT24zc2dsSk9wVVREU0NHYjl5eEdpVUtP?=
 =?utf-8?B?NmR5MWwyck5EaFNpTDFqcDlLbXJJZDhjUS82YTl0UXdxbTJBbG82QXlJWTZr?=
 =?utf-8?B?Qi9Pa0xuMTNYVCtKOE5pU2Zyd3dvbEFTUzFsNllmYUExbGFiWVFRNjF2VEdG?=
 =?utf-8?B?cU5tYzJ4VEJ6RUdOYTdIaDhFd2VYMGdBbzRTYithdlhvMkZaR0c4MS9ESmE4?=
 =?utf-8?B?UmJKZEFZMElmOU84Qzh4Y1lSN1VKWWFBNFcxMlYvNU1TYWV5aGFUUmM3NW9t?=
 =?utf-8?B?Yyt1NjJGV2hOclBwZFdTWVArVnpLTXluVm5MYStBeld1UmZEMUtDdFZyZ0I0?=
 =?utf-8?B?eStRWXJRVmF5QXltN3FuRWZUMHRzWE5Tc1I4aXQ2cTRMNThqVlVSUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <643225A77020764B9FC16182B67ED1BC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f45b9b4f-3102-4c3d-8809-08da221c1b1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 15:48:53.4757
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2db6fGgtB4s1bXt12AGLMwkpyk7KxLoONSYNOIK+ruZ8KilC2EiTYxrdwqZo9LuI6ysB46KCoJN1XC+iZTy7LPQY3B22tFwig6X3YlI+lJQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5045

T24gMTkvMDQvMjAyMiAxMDozOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEJlc2lkZXMgdGhlIHJl
cG9ydGVyJ3MgaXNzdWUgb2YgaGl0dGluZyBhIE5VTEwgZGVyZWYgd2hlbiAhQ09ORklHX0dEQlNY
LA0KPiBYRU5fRE9NQ1RMX3Rlc3RfYXNzaWduX2RldmljZSBjYW4gbGVnaXRpbWF0ZWx5IGVuZCB1
cCBoYXZpbmcgTlVMTCBwYXNzZWQNCj4gaGVyZSwgd2hlbiB0aGUgZG9tY3RsIHdhcyBwYXNzZWQg
RE9NSURfSU5WQUxJRC4NCj4NCj4gRml4ZXM6IDcxZTYxN2E2YjhmNiAoInVzZSBpc19pb21tdV9l
bmFibGVkKCkgd2hlcmUgYXBwcm9wcmlhdGUuLi4iKQ0KPiBSZXBvcnRlZC1ieTogQ2hleWVubmUg
V2lsbHMgPGNoZXllbm5lLndpbGxzQGdtYWlsLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPg0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9pb21tdS5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMNCj4g
QEAgLTU1OCw3ICs1NTgsNyBAQCBpbnQgaW9tbXVfZG9fZG9tY3RsKA0KPiAgew0KPiAgICAgIGlu
dCByZXQgPSAtRU5PREVWOw0KPiAgDQo+IC0gICAgaWYgKCAhaXNfaW9tbXVfZW5hYmxlZChkKSAp
DQo+ICsgICAgaWYgKCAhKGQgPyBpc19pb21tdV9lbmFibGVkKGQpIDogaW9tbXVfZW5hYmxlZCkg
KQ0KPiAgICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7DQoNCkhhdmluZyBzcGVudCB0aGUgYmV0
dGVyIHBhcnQgb2YgYSBkYXkgZGVidWdnaW5nIHRoaXMgbWVzcywgdGhpcyBwYXRjaCBpcw0KcGxh
aW4gYnJva2VuLg0KDQpJdCBkZXBlbmRzIG9uIEp1ZXJnZW4ncyAieGVuL2lvbW11OiBjbGVhbnVw
IGlvbW11IHJlbGF0ZWQgZG9tY3RsDQpoYW5kbGluZyIgcGF0Y2gsIGJlY2F1c2Ugb3RoZXJ3aXNl
IGl0IGVycm9uZW91c2x5IGZhaWxzIG5vbi1JT01NVSBzdWJvcHMuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:49:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:49:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308318.524013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq6j-0006eY-5L; Tue, 19 Apr 2022 15:49:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308318.524013; Tue, 19 Apr 2022 15:49:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq6j-0006eO-28; Tue, 19 Apr 2022 15:49:37 +0000
Received: by outflank-mailman (input) for mailman id 308318;
 Tue, 19 Apr 2022 15:49:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lfI/=U5=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ngq6h-0006bg-OZ
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:49:35 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f1a3660-bff8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 17:49:34 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id C8CA75C01B9;
 Tue, 19 Apr 2022 11:49:33 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Tue, 19 Apr 2022 11:49:33 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 19 Apr 2022 11:49:33 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f1a3660-bff8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender
	:subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender
	:x-me-sender:x-sasl-enc; s=fm1; t=1650383373; x=1650469773; bh=/
	sHDqu5TR+my1VccR9iUf0aiaYoUSa126jvmh3CA+Xk=; b=c8FvKmdLc6lFlXIaX
	1GbBfeZgu60Wek4Z5Pvxw3wIflxj6k+jsBGqWu4tUnv4XtOTOMB/i7uPwpj/e/oO
	Pcexr7nx6G7BNREGg4AZ9oINFVaqsja657tvmusXByrTRI6ypXmG0kYBS4FJ1H3I
	hJc7Q372MpgdvM4YSEXSHTdTp7gytWmIh86Q1E84OMrBkYrB51GyN5P5yy/aL1Y7
	biFLVaWf4b2AvMgSwDPnfDgYmqU5Gd7oyjay/tuwKOdjLMuf3AgWuHIGIfeihjCq
	BExjc3bqlhbAD0bXrwTXPYRLp5Of8Ps2cvj10OMr73zEPIVovaFL0IuqrIC927GI
	0lGxA==
X-ME-Sender: <xms:DdpeYuZMSnWccLTrYWBMiHLlIkynI8SgzDqkcAbRa1my_Xarx2XhSQ>
    <xme:DdpeYhZ-t1HuXsCpz8J-e4P5-N_Ql-p9DH5D0tKEtSFnsF1BBsAStFfPLDVw57ii6
    nT3k6NJZJO_lP4>
X-ME-Received: <xmr:DdpeYo_LEO7zTXIa0k-xbVmZ0tQSV_CB6ox37iKeCt9YJ_CdYcyHWoWjL0hG>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgleegucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhiucfo
    rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomheqnecuggftrfgrthhtvghrnhepveefleduheekhfdtfffffedukeevtedu
    leekfffgudfhtdduhfevueefueegtefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrg
    hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr
    sgdrtghomh
X-ME-Proxy: <xmx:DdpeYgqSwGK7g3ZjHpJWDdT6nJacY-cmJFUlMcl34RIiTivxsWHrAg>
    <xmx:DdpeYprurpi6baO5zon--AMdjASE81lF8r0Uhz_Kb2uL4dNcdntpOA>
    <xmx:DdpeYuSPuC-n2luslH1Llr1O14h64m6lfxsh21klkbXWePH2oUYREw>
    <xmx:DdpeYqmV5d0aTd4M8bwY2ZifmdXZZ1C6PtLxdb96i_-mj-eZFjSXTw>
Date: Tue, 19 Apr 2022 11:49:29 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 3/4] Add a new hypercall to get the ESRT
Message-ID: <Yl7aC2a+TtOaFtqZ@itl-email>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="i0aPqryS6w7vx+4i"
Content-Disposition: inline
In-Reply-To: <Yl7WHv6+M+eJwQep@itl-email>


--i0aPqryS6w7vx+4i
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Apr 2022 11:49:29 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 3/4] Add a new hypercall to get the ESRT

This hypercall can be used to get the ESRT from the hypervisor.  It
returning successfully also indicates that Xen has reserved the ESRT and
it can safely be parsed by dom0.
---
 xen/common/efi/boot.c         | 15 ++++++++++-----
 xen/common/efi/efi.h          |  2 ++
 xen/common/efi/runtime.c      | 14 ++++++++++++++
 xen/include/public/platform.h |  7 +++++++
 4 files changed, 33 insertions(+), 5 deletions(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 31664818c1..01b2409c5e 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -567,8 +567,6 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IM=
AGE *loaded_image)
 }
 #endif
=20
-static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR;
-
 static bool __init is_esrt_valid(
     const EFI_MEMORY_DESCRIPTOR *const desc)
 {
@@ -594,9 +592,13 @@ static bool __init is_esrt_valid(
     esrt_ptr =3D (const ESRT *)esrt;
     if ( esrt_ptr->Version !=3D 1 || !esrt_ptr->Count )
         return false;
-    return esrt_ptr->Count <=3D
-           (available_len - sizeof(*esrt_ptr)) /
-           sizeof(esrt_ptr->Entries[0]);
+    if ( esrt_ptr->Count >
+	 (available_len - sizeof(*esrt_ptr)) /
+	 sizeof(esrt_ptr->Entries[0]) )
+        return false;
+    esrt_size =3D sizeof(*esrt_ptr) +
+        esrt_ptr->Count * sizeof(esrt_ptr->Entries[0]);
+    return true;
 }
=20
 /*
@@ -1121,6 +1123,9 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHand=
le, EFI_SYSTEM_TABLE *Syste
             }
         }
=20
+	if ( esrt_desc =3D=3D (const EFI_MEMORY_DESCRIPTOR *)EFI_INVALID_TABLE_AD=
DR )
+	    esrt =3D EFI_INVALID_TABLE_ADDR;
+
         efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_si=
ze,
                                     efi_mdesc_size, mdesc_ver);
=20
diff --git a/xen/common/efi/efi.h b/xen/common/efi/efi.h
index 02f499071a..0736662ebc 100644
--- a/xen/common/efi/efi.h
+++ b/xen/common/efi/efi.h
@@ -46,6 +46,8 @@ extern const EFI_RUNTIME_SERVICES *efi_rs;
 extern UINTN efi_memmap_size, efi_mdesc_size;
 extern void *efi_memmap;
 extern const EFI_MEMORY_DESCRIPTOR *esrt_desc;
+extern UINTN esrt;
+extern UINTN esrt_size;
=20
 #ifdef CONFIG_X86
 extern mfn_t efi_l4_mfn;
diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
index 0d09647952..4466d5379c 100644
--- a/xen/common/efi/runtime.c
+++ b/xen/common/efi/runtime.c
@@ -227,6 +227,12 @@ const CHAR16 *wmemchr(const CHAR16 *s, CHAR16 c, UINTN=
 n)
 #endif /* COMPAT */
=20
 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */
+
+#ifndef COMPAT
+UINTN esrt =3D EFI_INVALID_TABLE_ADDR;
+UINTN esrt_size =3D 0;
+#endif
+
 int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
 {
     unsigned int i, n;
@@ -311,6 +317,14 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info *i=
nfo)
         info->apple_properties.size =3D efi_apple_properties_len;
         break;
=20
+    case XEN_FW_EFI_ESRT:
+        if ( esrt_desc =3D=3D (const EFI_MEMORY_DESCRIPTOR *)EFI_INVALID_T=
ABLE_ADDR )
+            return -ENODATA;
+        if ( info->esrt.size < esrt_size )
+            return -ERANGE;
+        if ( copy_to_guest(info->esrt.table, (const ESRT *)esrt, esrt_size=
) )
+            return -EFAULT;
+        break;
     default:
         return -EINVAL;
     }
diff --git a/xen/include/public/platform.h b/xen/include/public/platform.h
index 8100133509..a848df2066 100644
--- a/xen/include/public/platform.h
+++ b/xen/include/public/platform.h
@@ -243,6 +243,7 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_efi_runtime_call_t);
 #define  XEN_FW_EFI_RT_VERSION     4
 #define  XEN_FW_EFI_PCI_ROM        5
 #define  XEN_FW_EFI_APPLE_PROPERTIES 6
+#define  XEN_FW_EFI_ESRT           7
 #define XEN_FW_KBD_SHIFT_FLAGS    5
 struct xenpf_firmware_info {
     /* IN variables. */
@@ -307,6 +308,12 @@ struct xenpf_firmware_info {
                 uint64_t address;
                 xen_ulong_t size;
             } apple_properties;
+            struct {
+                /* IN variables */
+                uint64_t size;
+                /* OUT variables */
+                XEN_GUEST_HANDLE(void) table;
+            } esrt;
         } efi_info; /* XEN_FW_EFI_INFO */
=20
         /* Int16, Fn02: Get keyboard shift flags. */
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--i0aPqryS6w7vx+4i
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJe2goACgkQsoi1X/+c
IsHj2xAAxd80MtCKJV/pn9p8JOQoS7zPDoXYsikhyFi7e9HVcGzFm9P5GkA7ymis
CVy1LrPNaqPPa0GugnmTvBXV0BCvZc1IRZGU+vXQuPfYga+hATQjAMToybrrWJNM
h2WHqp41GE81bICGVcRrw13giqjs5Sy7/1+RJoRh02H5+gjewcg+0cqoRKCwZtvY
JwRpe0sHNnQDdJwRRcez4YmGqclrVrwt4+QATlvBk88pmwBYxPMfzrXfIO0WL5jx
krX9BT4wnPeE5ApRe4daYJMxXM6/ZrMyXViJjuHkYLnNha8U4mhHzkU9JRp96Ge5
arcO4ea+3TKIN23Ujy7eSeFrKvrCXDMGRFK3sAFQtZhmRrl3S+46S2AuYhhPLP27
e57ICEMAVlnr0JrKYuow/8LgToWPUfLc97vBWhy4Jjtxlvd36gRT0iXu6OojaBDO
0Rpe4pfMdv0nKENiL9RD8V75RrMg84urga422U4T3ro3WNrN/WsygDgXMHQpJO/G
mhl5g9MjTLT/oqREBHwBYWUYIsctupKCkD5IZ5EoczGQgkSQWoSmmiNisF+6xb2X
P+cGXSX5HOKfEt0PPxm3FGyewwZTwBnJoPmNJE6b16kMHGu1oPrpO/I0WRl+EKe+
40TbkZRk7RQh+EFpjLx8OQxDhofnCpC+6qwx+a6tjgAEXp2Eo1Q=
=EnvI
-----END PGP SIGNATURE-----

--i0aPqryS6w7vx+4i--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:50:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:50:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308328.524025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq7r-00087N-LL; Tue, 19 Apr 2022 15:50:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308328.524025; Tue, 19 Apr 2022 15:50:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq7r-00087G-I0; Tue, 19 Apr 2022 15:50:47 +0000
Received: by outflank-mailman (input) for mailman id 308328;
 Tue, 19 Apr 2022 15:50:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WtTZ=U5=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1ngq7p-0006bg-G1
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:50:45 +0000
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com
 [2a00:1450:4864:20::42b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 78f2b3ce-bff8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 17:50:44 +0200 (CEST)
Received: by mail-wr1-x42b.google.com with SMTP id u3so23053642wrg.3
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 08:50:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78f2b3ce-bff8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=nitqz4REuWupqJr2pZw4T+8sSCanTDQzjYvK7AeSxbI=;
        b=RrG7UP+t2MzMwnlZEg82c3r/2eIcp+rqamjCouRN3WC4sfCHC9q+WVv/N+cZvqY2WV
         xLQynxFeKOfJTJfdeJ4dj2fmUDMklPFOxhwS91WoxBz8yJLAruNDxACQIhcjNDztkIeY
         PpJTFQ3Z2rDL4+0mq+ZlegShL2drrn6L3GWhxgkmUrQRCjC5tWekjOwxnAKTcASR2qf2
         b0qjzpJ6D+KBdpDmcPUjPGWAobpVpV11nqFjXsXBOaC8PyxLv6ak6ks8WyHnQd1HXqVq
         MOvAS0pT8yd1njiVYxOTOV9yf0xHEzyJi8+TLR12FcD5hvlSKceU8AzXV5IwfnXoZsHo
         mdZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=nitqz4REuWupqJr2pZw4T+8sSCanTDQzjYvK7AeSxbI=;
        b=i+2pHygj1QvMB+k8mdrMxte+sXcysJpN6pb5jYu7vgxNtN0zQsJ4Z1FqPg7RCHp5gj
         btbo0vXCKKysjXkioOvSYmfnyiU3s/4QVcLCqWTCREuub1+o9pazx5BLB6jJs2kOP8Zg
         jt3EFegB2dr49AjoOInQWdqAAZrAkBsxXscUhF9bB2Nb6hJ/3+8bTTLvubQuRcq0NHo8
         8trD3gh85Wi/ntg8xpNOrA304c9qb+k+Jy8iKcdMWNDBDV62apubCrc6J/BmwDUKDnO2
         7NgB26MF2RSNOSykyMeg/dTWQJk8iYGR5Iql6aI2ab6muY8d328SubYb1VRTOGc9jS5m
         nY+g==
X-Gm-Message-State: AOAM531vubJct7h36CunaF6wU7ETZV5tvo7A7CvyKLtyAITupKMKpvFu
	Go9R7Q9wvILTxPNVXjY81lHCS6BfZNXFiSZBmFQ=
X-Google-Smtp-Source: ABdhPJyKsF+nYPH0EnYSYzIln5QpflczoO9pyqS3MhtPDb8IRwiQczq5jTc6h9o7bphEzGJEPNIGEfbZ3ZChfCtHOzA=
X-Received: by 2002:adf:fb52:0:b0:206:1477:ba27 with SMTP id
 c18-20020adffb52000000b002061477ba27mr12322075wrs.230.1650383443925; Tue, 19
 Apr 2022 08:50:43 -0700 (PDT)
MIME-Version: 1.0
References: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
In-Reply-To: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Tue, 19 Apr 2022 15:50:31 +0000
Message-ID: <CAJ=z9a37_y3B4aAfiK5C-bHJYyWqCo0+g+jB6cdDCmOzLuXLJw@mail.gmail.com>
Subject: Re: [PATCH] xen/arm: silence ambiguous integer casting warning error
To: Paran Lee <p4ranlee@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Austin Kim <austindh.kim@gmail.com>, 
	xen-devel <xen-devel@lists.xenproject.org>
Content-Type: multipart/alternative; boundary="000000000000eb1f4f05dd03d6f3"

--000000000000eb1f4f05dd03d6f3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 19 Apr 2022, 15:41 Paran Lee, <p4ranlee@gmail.com> wrote:

> GCC with "-g -Wall -Wextra" option throws warning message as below:


Which version of the compiler? Also you specify the exact cflags, did you
tweak Xen?


> error: comparison of integer expressions of different signedness:
>  =E2=80=98int=E2=80=99 and =E2=80=98unsigned int=E2=80=99 [-Werror=3Dsign=
-compare]
>

GCC should give you a line/file. Can you provide it?

Cheers,


> Silence the warning by correcting the integer type.
>
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> ---
>  xen/arch/arm/gic-v3.c | 5 +++--
>  xen/arch/arm/setup.c  | 2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 3c472ed768..81ac25f528 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)
>      isb();
>  }
>
> -static u16 gicv3_compute_target_list(int *base_cpu, const struct cpumask
> *mask,
> +static u16 gicv3_compute_target_list(unsigned int *base_cpu,
> +                                     const struct cpumask *mask,
>                                       uint64_t cluster_id)
>  {
>      int cpu =3D *base_cpu;
> @@ -953,7 +954,7 @@ out:
>
>  static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t
> *cpumask)
>  {
> -    int cpu =3D 0;
> +    unsigned int cpu =3D 0;
>      uint64_t val;
>
>      for_each_cpu(cpu, cpumask)
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index d5d0792ed4..5ab2aaecaf 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -862,7 +862,7 @@ void __init start_xen(unsigned long boot_phys_offset,
>                        unsigned long fdt_paddr)
>  {
>      size_t fdt_size;
> -    int cpus, i;
> +    unsigned int cpus, i;
>      const char *cmdline;
>      struct bootmodule *xen_bootmodule;
>      struct domain *d;
> --
> 2.25.1
>
>

--000000000000eb1f4f05dd03d6f3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Hi,<br><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Tue, 19 Apr 2022, 15:41 Paran Lee, &lt;<a href=
=3D"mailto:p4ranlee@gmail.com">p4ranlee@gmail.com</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex">GCC with &quot;-g -Wall -Wextra&quot; option =
throws warning message as below:</blockquote></div></div><div dir=3D"auto">=
<br></div><div dir=3D"auto">Which version of the compiler? Also you specify=
 the exact cflags, did you tweak Xen?</div><div dir=3D"auto"><br></div><div=
 dir=3D"auto"></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquot=
e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol=
id;padding-left:1ex">
<br>
error: comparison of integer expressions of different signedness:<br>
=C2=A0=E2=80=98int=E2=80=99 and =E2=80=98unsigned int=E2=80=99 [-Werror=3Ds=
ign-compare]<br></blockquote></div></div><div dir=3D"auto"><br></div><div d=
ir=3D"auto">GCC should give you a line/file. Can you provide it?</div><div =
dir=3D"auto"><br></div><div dir=3D"auto">Cheers,</div><div dir=3D"auto"><br=
></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex">
<br>
Silence the warning by correcting the integer type.<br>
<br>
Signed-off-by: Paran Lee &lt;<a href=3D"mailto:p4ranlee@gmail.com" target=
=3D"_blank" rel=3D"noreferrer">p4ranlee@gmail.com</a>&gt;<br>
---<br>
=C2=A0xen/arch/arm/gic-v3.c | 5 +++--<br>
=C2=A0xen/arch/arm/setup.c=C2=A0 | 2 +-<br>
=C2=A02 files changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c<br>
index 3c472ed768..81ac25f528 100644<br>
--- a/xen/arch/arm/gic-v3.c<br>
+++ b/xen/arch/arm/gic-v3.c<br>
@@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)<br>
=C2=A0 =C2=A0 =C2=A0isb();<br>
=C2=A0}<br>
<br>
-static u16 gicv3_compute_target_list(int *base_cpu, const struct cpumask *=
mask,<br>
+static u16 gicv3_compute_target_list(unsigned int *base_cpu,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0const struct cpu=
mask *mask,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 uint64_t cluste=
r_id)<br>
=C2=A0{<br>
=C2=A0 =C2=A0 =C2=A0int cpu =3D *base_cpu;<br>
@@ -953,7 +954,7 @@ out:<br>
<br>
=C2=A0static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t *cp=
umask)<br>
=C2=A0{<br>
-=C2=A0 =C2=A0 int cpu =3D 0;<br>
+=C2=A0 =C2=A0 unsigned int cpu =3D 0;<br>
=C2=A0 =C2=A0 =C2=A0uint64_t val;<br>
<br>
=C2=A0 =C2=A0 =C2=A0for_each_cpu(cpu, cpumask)<br>
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c<br>
index d5d0792ed4..5ab2aaecaf 100644<br>
--- a/xen/arch/arm/setup.c<br>
+++ b/xen/arch/arm/setup.c<br>
@@ -862,7 +862,7 @@ void __init start_xen(unsigned long boot_phys_offset,<b=
r>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0unsigned long fdt_paddr)<br>
=C2=A0{<br>
=C2=A0 =C2=A0 =C2=A0size_t fdt_size;<br>
-=C2=A0 =C2=A0 int cpus, i;<br>
+=C2=A0 =C2=A0 unsigned int cpus, i;<br>
=C2=A0 =C2=A0 =C2=A0const char *cmdline;<br>
=C2=A0 =C2=A0 =C2=A0struct bootmodule *xen_bootmodule;<br>
=C2=A0 =C2=A0 =C2=A0struct domain *d;<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div></div></div>

--000000000000eb1f4f05dd03d6f3--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:52:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:52:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308338.524036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq90-0000NB-VF; Tue, 19 Apr 2022 15:51:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308338.524036; Tue, 19 Apr 2022 15:51:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq90-0000N4-S5; Tue, 19 Apr 2022 15:51:58 +0000
Received: by outflank-mailman (input) for mailman id 308338;
 Tue, 19 Apr 2022 15:51:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lfI/=U5=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ngq8y-0000Lk-Qx
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:51:56 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a32fde1a-bff8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 17:51:55 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 0AAFE5C00D2;
 Tue, 19 Apr 2022 11:51:55 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Tue, 19 Apr 2022 11:51:55 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 19 Apr 2022 11:51:54 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a32fde1a-bff8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender
	:subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender
	:x-me-sender:x-sasl-enc; s=fm1; t=1650383515; x=1650469915; bh=f
	JfW3aNKUP1YaiRHgeQrsvL4jbiMKjBZMM/ztfq6U7M=; b=kFMW+HXhRpX7lvUYj
	TRNUsGwMjm5zSuJ1pHFFuZQjXWnJA2MVrUCmKVUAmq1z7Q1B3whrLimroK323zLU
	HLcg5n1rXPGY2qVOHztvOyQP+yu7WkbWLdkCtT4H/94gJffxMBNbJTu4hiDP0TVi
	xJMoNFbh46FvarjbnhNsuB3ETSeOmE7nvsViwebxhndzsUNfnB+CnP25rqds5L3w
	l5J903R6dwmS8T89HOJcm4T6wJkDyA6I+Sx2gscRMMgSx41q4rkBcVADueVuWTu9
	UtKevyb84nYfQa5irm9LGyPRiDcwEA83ARdv2raH3T854jc4j/3yRfOp59c/86GG
	47+AQ==
X-ME-Sender: <xms:mtpeYiYo2AMOTKDBDQMOQyhu3bdzKeLb_P9Sksw9-RfAR3bnjtq1lw>
    <xme:mtpeYlZYGRbqOlaTrtwVk_CA_5l85KhO5VOBUgbudoxdNMhSJkVSAtYP-tS3W3J1C
    L3HPJrL6j94-Oo>
X-ME-Received: <xmr:mtpeYs840ChYyh-bPESp7R85ZD6PgmMcoc6ZIF-CLQ0OFJk4u8XNmjcoEd4i>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgleefucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhiucfo
    rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomheqnecuggftrfgrthhtvghrnhepveefleduheekhfdtfffffedukeevtedu
    leekfffgudfhtdduhfevueefueegtefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrg
    hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr
    sgdrtghomh
X-ME-Proxy: <xmx:mtpeYkqWaZltgz8ahDp54Cy3qwTIC01ffiPqe2I5OhoHkEcFCMOzIA>
    <xmx:mtpeYto9dyOuJXZjgRrr5WaoUfEftYvHVCGHg5g0M7TMOVCAAGh-Zg>
    <xmx:mtpeYiTONc3KufY-et_zsxj_BezyDE6ThL99UJkKxcMaEuZ7_i3efw>
    <xmx:m9peYvH_UzVfuY42CjmBrwi6sfXLZao4jKoJczCTp2NwogCblAz5qw>
Date: Tue, 19 Apr 2022 11:51:52 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 4/4] Add emacs file-local variables
Message-ID: <Yl7amclsnCl6aNws@itl-email>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="XKTcRyePo7OpsmLl"
Content-Disposition: inline
In-Reply-To: <Yl7WHv6+M+eJwQep@itl-email>


--XKTcRyePo7OpsmLl
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Apr 2022 11:51:52 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 4/4] Add emacs file-local variables

These were very helpful for me when I was working on the code.
---
 xen/common/efi/boot.c    | 10 ++++++++++
 xen/common/efi/runtime.c | 10 ++++++++++
 2 files changed, 20 insertions(+)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 01b2409c5e..5415785bef 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1802,3 +1802,13 @@ void __init efi_init_memory(void)
     unmap_domain_page(efi_l4t);
 }
 #endif
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
index 4466d5379c..8021ecaecc 100644
--- a/xen/common/efi/runtime.c
+++ b/xen/common/efi/runtime.c
@@ -719,3 +719,13 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op)
     return rc;
 }
 #endif
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--XKTcRyePo7OpsmLl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJe2pgACgkQsoi1X/+c
IsFk6g/8CngbYCHCGA8SU+crsh1r6B2PvhdbDrgIM2jLjR2j09xRhNDnoDSCtBV4
aSgOwd46GIjGq9ZTvoOgFelFN33gnE7Mf5l7+3QzAQrEx2tAo2e/+f0/zqNx1EXw
Kvoy5yYkcNwagONc96pl4MOLyFR9tPdbnDFyA/lg8BQW+T7WPalYLen45jvAHIZ0
EGViDyKVb0zL1dqLuW7LxbLD3cmjYOj581za50K6ijuxH/1FVKxBBY2iscHJf2R6
1661hb56fgeqPOOA2SLFjK+v34NnXRVNuBvQ1OVK3yXbROrIqHfwEZ+DrhpRv1XJ
EV4REasRY0RYoPM3V3f4CbwMoKmfQYCHrSzKrJof+556GH8FnZLfZUDLwTGUgzAz
89HygJQoNSQ6ajrYylNxIPphpnIZYWf9yMxH8//49FCxYxar0qecNv2uzX66OeDm
EcERpUxCu8TP1BRiLtqPl3F9x0q7ImiW5vEfRNTq/nsEpTNTSiG8yZtSqaqQ2fwj
wDFX+svA0d/wR6u7MgCvAEdUoJUk/OhwWZA7UNX82xruACt/Aa/SOG7fJ3w1YPCH
QdQeNa2WWK1LdWRj42pCpvm0BbVR9ud0RoFi8JZSy2jxK50bebjiXK6I3J/wk2Dm
SOLO7NdoxBBBbinplXavAxEJK9fO5DqwZ1ME/VhTWSEvZsVqH1M=
=tbQV
-----END PGP SIGNATURE-----

--XKTcRyePo7OpsmLl--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 15:52:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 15:52:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308342.524047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq9I-0000sh-8i; Tue, 19 Apr 2022 15:52:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308342.524047; Tue, 19 Apr 2022 15:52:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngq9I-0000sa-3O; Tue, 19 Apr 2022 15:52:16 +0000
Received: by outflank-mailman (input) for mailman id 308342;
 Tue, 19 Apr 2022 15:52:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Io9b=U5=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ngq9H-0000Lk-4j
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 15:52:15 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae692991-bff8-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 17:52:14 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C7D5221118;
 Tue, 19 Apr 2022 15:52:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A721C139BE;
 Tue, 19 Apr 2022 15:52:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1IanJ63aXmJARAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Apr 2022 15:52:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae692991-bff8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650383533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Rtr7Hvd3Cy9exIqtS2n2EwunDKE/wU9yRJBm1EAYCFg=;
	b=noN9ej1o1SmnZgE9uJSyD53ecvWiI0OUKk+RRnwGyBoLOAJkAxBz1dLJF4FQWw/AfwL7T2
	lVI2z5O3ZvWm4Y3c8HMXfpQlbskdIQ5OoCuJt6NCCWkYAMykBFy855r0Z0/acNm61VrgQa
	UPKT//Y6wl1WyEiXRsyO3CxksuDNb/E=
Message-ID: <bd446b5b-49ea-3d6f-6792-7d785586ea69@suse.com>
Date: Tue, 19 Apr 2022 17:52:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich
 <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
 <8a8aa0c1-e6f3-2dc0-77d4-282af89f4ed6@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <8a8aa0c1-e6f3-2dc0-77d4-282af89f4ed6@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------9fVKk5cVDzapF4T0gupMQ28S"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------9fVKk5cVDzapF4T0gupMQ28S
Content-Type: multipart/mixed; boundary="------------gPf1bZNqDMTtK7Itj10UpTaM";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich
 <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>
Message-ID: <bd446b5b-49ea-3d6f-6792-7d785586ea69@suse.com>
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
 <8a8aa0c1-e6f3-2dc0-77d4-282af89f4ed6@citrix.com>
In-Reply-To: <8a8aa0c1-e6f3-2dc0-77d4-282af89f4ed6@citrix.com>

--------------gPf1bZNqDMTtK7Itj10UpTaM
Content-Type: multipart/mixed; boundary="------------g0Wtpe4qxRR82tl2KLkh9wtl"

--------------g0Wtpe4qxRR82tl2KLkh9wtl
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMDQuMjIgMTc6NDgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDE5LzA0LzIw
MjIgMTA6MzksIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gQmVzaWRlcyB0aGUgcmVwb3J0ZXIn
cyBpc3N1ZSBvZiBoaXR0aW5nIGEgTlVMTCBkZXJlZiB3aGVuICFDT05GSUdfR0RCU1gsDQo+
PiBYRU5fRE9NQ1RMX3Rlc3RfYXNzaWduX2RldmljZSBjYW4gbGVnaXRpbWF0ZWx5IGVuZCB1
cCBoYXZpbmcgTlVMTCBwYXNzZWQNCj4+IGhlcmUsIHdoZW4gdGhlIGRvbWN0bCB3YXMgcGFz
c2VkIERPTUlEX0lOVkFMSUQuDQo+Pg0KPj4gRml4ZXM6IDcxZTYxN2E2YjhmNiAoInVzZSBp
c19pb21tdV9lbmFibGVkKCkgd2hlcmUgYXBwcm9wcmlhdGUuLi4iKQ0KPj4gUmVwb3J0ZWQt
Ynk6IENoZXllbm5lIFdpbGxzIDxjaGV5ZW5uZS53aWxsc0BnbWFpbC5jb20+DQo+PiBTaWdu
ZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+Pg0KPj4gLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvaW9tbXUuYw0KPj4gKysrIGIveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvaW9tbXUuYw0KPj4gQEAgLTU1OCw3ICs1NTgsNyBAQCBpbnQgaW9t
bXVfZG9fZG9tY3RsKA0KPj4gICB7DQo+PiAgICAgICBpbnQgcmV0ID0gLUVOT0RFVjsNCj4+
ICAgDQo+PiAtICAgIGlmICggIWlzX2lvbW11X2VuYWJsZWQoZCkgKQ0KPj4gKyAgICBpZiAo
ICEoZCA/IGlzX2lvbW11X2VuYWJsZWQoZCkgOiBpb21tdV9lbmFibGVkKSApDQo+PiAgICAg
ICAgICAgcmV0dXJuIC1FT1BOT1RTVVBQOw0KPiANCj4gSGF2aW5nIHNwZW50IHRoZSBiZXR0
ZXIgcGFydCBvZiBhIGRheSBkZWJ1Z2dpbmcgdGhpcyBtZXNzLCB0aGlzIHBhdGNoIGlzDQo+
IHBsYWluIGJyb2tlbi4NCj4gDQo+IEl0IGRlcGVuZHMgb24gSnVlcmdlbidzICJ4ZW4vaW9t
bXU6IGNsZWFudXAgaW9tbXUgcmVsYXRlZCBkb21jdGwNCj4gaGFuZGxpbmciIHBhdGNoLCBi
ZWNhdXNlIG90aGVyd2lzZSBpdCBlcnJvbmVvdXNseSBmYWlscyBub24tSU9NTVUgc3Vib3Bz
Lg0KDQpXaGljaCBpcyBub3QgYSByZWFsIHByb2JsZW0sIGFzIGl0IGlzIGJlaW5nIGNhbGxl
ZCBhZnRlciBhbGwgb3RoZXINCnN1Ym9wcyBkaWRuJ3QgbWF0Y2guIE9yIHdpdGggbXkgM3Jk
IHBhdGNoIGFwcGxpZWQgaXQgaXMgY2FsbGVkIG9ubHkNCmZvciBJT01NVSBzdWJvcHMuDQoN
Cg0KSnVlcmdlbg0K
--------------g0Wtpe4qxRR82tl2KLkh9wtl
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------g0Wtpe4qxRR82tl2KLkh9wtl--

--------------gPf1bZNqDMTtK7Itj10UpTaM--

--------------9fVKk5cVDzapF4T0gupMQ28S
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJe2q0FAwAAAAAACgkQsN6d1ii/Ey9Z
uwf/R9J4bS+cn8R80bVukp3KHXR7QBlbEghuBu+ncf6z039dgSi9J2Qgj9JMp/eL3GQqyn1+kDBY
GsaAZ7WRLVbwNXUkUttsAgAMiV6IwlAAUnzUW6fd10R9PWFyE+uxbxX5VoL7Xm8aywsQQuxFIF9I
17h+XwiQdbg4PE+Glghe3DAz3LSh+3awM+TiuLgLlcRPnv7LGHgLDQJzotIAqWZxnVJWlSGOZya9
281GSyoh0k+cui+WXBKa3RhftV96xZCEMQwEGqxaNOL23LwbH7AvmnMPAsF3P1txxRIZz/ytNjVi
CSxRXFbXbBClYXg5dmBPWUOYgtw8VcX1qN6+osv6/Q==
=Pqnk
-----END PGP SIGNATURE-----

--------------9fVKk5cVDzapF4T0gupMQ28S--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 16:06:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 16:06:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308353.524058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqN1-0003IQ-FJ; Tue, 19 Apr 2022 16:06:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308353.524058; Tue, 19 Apr 2022 16:06:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqN1-0003IJ-Bw; Tue, 19 Apr 2022 16:06:27 +0000
Received: by outflank-mailman (input) for mailman id 308353;
 Tue, 19 Apr 2022 16:06:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mThm=U5=citrix.com=prvs=101c57682=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ngqN0-0003ID-Bi
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 16:06:26 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a7cb405e-bffa-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 18:06:24 +0200 (CEST)
Received: from mail-dm3nam07lp2042.outbound.protection.outlook.com (HELO
 NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Apr 2022 12:06:20 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DS7PR03MB5432.namprd03.prod.outlook.com (2603:10b6:5:2c5::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 16:06:19 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5164.026; Tue, 19 Apr 2022
 16:06:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7cb405e-bffa-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650384384;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=K18yJa0mvn0c4nvHjp2+PMA/6b9XrRtukNIp6LQK1tw=;
  b=hbRTPPUSeEcKp/3xlYWt7INgnqesU+swzufPYOx1EWTk5GtwEgOxE2/T
   Rmx/vtjSQpnFan9qabC7Lr3ay80w0S4StvsGnXWLkOBxW/Ra5/Mf2QxfH
   5JTcbcDBRgPv/oGPK4MsT6z6Y+ncBV9ofqQQ9kMkK2VztR3UlEZo2slZW
   A=;
X-IronPort-RemoteIP: 104.47.56.42
X-IronPort-MID: 69827412
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:DFaEvqmPwQ55eMQ1vvWT2X/o5gyMJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIbWDvTPfyCYjD1KY13OY3kphkAsJbRyoVqGVZt/n1jQSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWlLV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYZgV5Ban+vcUhWTJmDTpgZYJ685bBPi3q2SCT5xWun3rE5dxLVBtzEahDv+F9DCdJ6
 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXu5kEhl/chegXdRraT
 +MfZSBic1LrZBpXN01MIJk/gP2plj/0dDgwRFe9+/tnuTePlVYZPL7FOdyLV4KzQdpuuW3fg
 1za83jFOkwTDYnKodaC2jf27gPVpgv5V5gVD6aQ7eNxjRuYwWl7IB8cWEa/oPK5olWjQN8ZI
 EsRkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8yx6QG2wsXjNHLts8u6cLqScC0
 1aIm5blAGdpubjNFnaFrO/I93W1JDQfKnIEaWkcVwwZ7tL/oYY1yBXSUtJkF63zhdrwcd3t/
 w23QOEFr+17paY2O2+TpzgrXxrESkD1czMI
IronPort-HdrOrdr: A9a23:0mqUwqrnENkdanKNPTPxAjAaV5tyLNV00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcYtKLzOWwldAS7sSorcKogeQVhEWk9Qw6U
 4OSdkYNDSdNzlHZIPBkXGF+rUbsZe6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK
 Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInNy6IZn1V
 KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0WVjcVaKv+/VQIO0aWSAWUR4Z
 7xStAbToJOAkbqDySISN3WqlDdOXgVmiffIBSj8AbeSITCNU4H4ox69MNkm1LimjQdVJsX6t
 M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pXVFZ9l/1owKpuKuZIIMs60vFULM
 B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpT+OUP2nMbsJ4tQZhN4O
 rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOHl7fnpLEuoO26cp0By5U/3J
 zHTVNDrGY3P1njDMWftac7hSwlgF/NKQgF5vsul6SR4IeMNYYDGRfzO2wGgo+nv+gVBNHdVr
 K6JI9WasWTWFfTJQ==
X-IronPort-AV: E=Sophos;i="5.90,273,1643691600"; 
   d="scan'208";a="69827412"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lp05NfTjYpMiUH6j+qBrSQIgr2IiREwQEnH266DKUL8PAmdRB8f++uIsSca219efwWPZxDI3dlFnwE9g2Ov4dv8BbNI3fEtjhHMmBJi4E3q/f7l5d5jBUCVzu2Ry4hyCrpjIeuBHMTyfpZvk5aeMIFsi+G0HYTdDCUSnJmDtUk0A0SyU8KYh/8wgTG7oGCBJ5iSRYKi94U25KikR95HytppzoEuOUV0Y5CaO38FcyzMZKwTrQ9eAaj2sXGaEhVWIPKCBgJJO4Z87d+3T6dpmlr46aGYe5c1l5MScQX6tUop4KY3DkozZ/6irZxFz78Hbit2IlR/Do7X5WYuhvDowRw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K18yJa0mvn0c4nvHjp2+PMA/6b9XrRtukNIp6LQK1tw=;
 b=h9EyQWjlkFKZQRHzspMsh3bE/0MyR0to4OVAlhMgup4MsG21EhzmwrHV5XZnzm8QPEJ4a7BvFfoWiOIhY9d5JkNLfoOJgfYZ4TuJZvrif12A0RQgd5LnvYLPMQjYzBpdgAr17iTNYk5PcxnS84kLxizpjFRtPwRw8duNz8wtjFuZFhaD4fFs0NlmERO8A219pIVUZN/2su6/Lsvk+z1Cw55XILiOZE9LRN7rJtFviWsoeb7FeufRMcdg5oiUnKh2P8+Mq3+858vYMajMy3CsJkN7/POh8QjUeO0uFETcDpHqlBneQn4wGweLFpnoPUmCU/hr2Zdxva59NtQJICBS1g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K18yJa0mvn0c4nvHjp2+PMA/6b9XrRtukNIp6LQK1tw=;
 b=s4JticngbjWhp/SKFpERPGQRKgowjVDcEM63AIN4Gg6AXuorZMW/ofwH+OK3aygwGDESegq2X4NTSovZrHHQQigqzqCP0x250ugTIwg9sK8ebnQ8x9p9tKQBy2s4RZxL6w/f+ABqq9jZjtx50Z1X/d4Nm43QNNNWyGgz2n2GTYc=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Topic: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Index: AQHYU9FUwjuogeCS0EWgGeBVFIanqKz3Yk2AgAAA74CAAAPwgA==
Date: Tue, 19 Apr 2022 16:06:19 +0000
Message-ID: <226afabd-ea07-dd60-474f-c594d7468de3@citrix.com>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
 <8a8aa0c1-e6f3-2dc0-77d4-282af89f4ed6@citrix.com>
 <bd446b5b-49ea-3d6f-6792-7d785586ea69@suse.com>
In-Reply-To: <bd446b5b-49ea-3d6f-6792-7d785586ea69@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c4217271-ee60-490b-6d94-08da221e8a92
x-ms-traffictypediagnostic: DS7PR03MB5432:EE_
x-microsoft-antispam-prvs:
 <DS7PR03MB5432718D4C671A78FF7A827FBAF29@DS7PR03MB5432.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 waTVcWdtQNGLKJQxxrm+2bfNuX10XyIVdpvVB5RF1G3zBzfQpYrGfMgdPHGe8RfTjAplgbgfkbjJ2RIrh0evb8gx4D6GrxJS1WPWcdQGuyZBmjtURIMzDWSPeLgCxFWHcZAvoL0Sp/kk+HNnqwDew3pp1lh0zFW5asWLqu7olAZpLLkpDM3rK8qpLZhLdwDqfpbBfNYOKNR4wZiD/e0QNK1RnMMbcVzGk1mPoszrN7V7j2tIph63rInvxIkEBf1/sh2P02et9ijPavX4bMbOuEoiTZu045ZRRJ6IbTrsvoUwtCdhKp7/Bom2fYNaAlxRboCKzB9/mLgAPXkm8Lp2yB4xlK6tzxVVu4hr89JvAIlbXtFtKrnPSixJZTiA/u5+wQTAPDtCKvkFIEVYpqV9EJ8N5G2PsLVpuhr5ZJHlP/ydC/kwv2tanZyIROvAM100TSykahGV6fNU0ZG0efhCcarStgU2vQKTO59orUEVVuvmzhm3BcdgPU2OFLg7U2wggrMV1bXv+xVfaWPdui/m7UrWuu4gs2M9rF8KUKhwavasjTKf/hWzlIPrTyFixzREejekYkyeaWNz2ZltFkKIz4puSLvulJ2xEal1Fo9k7UoNUp8VpXmioUhzIpwdNGzBUD2Tr8LMcaVwHVTS/NcJwrGQeI06Aibj/84LXnJ63AKG7QTXhH6z9BhUO6tasEkke7rkoKe6XvKA/Uj0D4Nzy7LE7f2JnNg3V9pRcCHu2qOLkMrl3AOT4ghJbUtTBaaD6c1YvqEiXVlm/Rawuv3hcQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(53546011)(122000001)(64756008)(5660300002)(83380400001)(2906002)(186003)(6512007)(6506007)(38070700005)(86362001)(31686004)(36756003)(82960400001)(26005)(6486002)(66556008)(316002)(66946007)(38100700002)(66446008)(91956017)(76116006)(8676002)(4326008)(110136005)(2616005)(66476007)(71200400001)(8936002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bkZHWWNKOFNaWlEwYm1VSjY0dW9SUjlKUG9nUGVCR0JhNDRBWVlMTVFvaWpl?=
 =?utf-8?B?ZnA2Yjk2Tllkck1nWHUvYVlwT29QWmcrNG1McVNGVkJSNFN3TXpTVWxDUkQv?=
 =?utf-8?B?NE14NjZoNzBWdThVcEJNVGE3a2tQWlJ4UlU0OHRzV1NQTU1hTllTK1hrcVFN?=
 =?utf-8?B?N0dzRng0SzR3bDd5ZGx6Ulk2bnpyRmFCeEp0QktkdGRwR0VVeGxiRjNXdXJS?=
 =?utf-8?B?UnhkYlFXMHA1M0hSVzg0amZ5dHcrTUxvNlRVSDB4NzRmMjE0aHlzaC9WcFNH?=
 =?utf-8?B?VldRRXpuWnhydVg5OG1iYkFjbll4L0MxZm1HbUlmK1ZtODFnNXQvaXJZeUtz?=
 =?utf-8?B?emt2UG5FNkpNUi9GN2Y5Wm5UUE9vMG1HQ09zZ0VOZjNJRTNUcVFPbGVKaFAr?=
 =?utf-8?B?SDZOOVdPRXplVFFxTm9LWENqckVpdlBvUGV1dGFydmdtbGF5L3U0S29nUXpU?=
 =?utf-8?B?QUUvRFVBMnFSdkdwTWtQd0RaK01Bd3hDL1BuTSswOGI3K2M4b054YlNOaXFn?=
 =?utf-8?B?QVA3QVVaUnNFVmdsRWxBallTWENGVFlqRllRblBXcmgwODFNeWdLV3IrUVND?=
 =?utf-8?B?eDQ4R2UvRU1rZFNlWTRrSXVkdmZ0eVJRYVdCanJ3eU85NldXTks3MU9BcXl6?=
 =?utf-8?B?V0FpRjF0Vy9vTlVTS21OcVRwRG1SSFZoYlowUXhXRXhpMDN3VHVOQ0xBNDV1?=
 =?utf-8?B?VDYyQzcrcVRrRGhOYVkzVGFhbW5wSGdiOEpYQlNUWDg5aGN3dlp0M0NobEcz?=
 =?utf-8?B?VU5SWllmNEtJRHhVbGR3dkZTN3pVKzZxU25Cc2NsRGNUcUhtQ3NleWtxdTd1?=
 =?utf-8?B?ZEdRVW1YR3RMeWE1ellvRTlZQm9Yc3VBQ1VmWFhhdGF2dTd1eWFJeUZGVUov?=
 =?utf-8?B?R2tsaFcva3B3YVl6WEdYV3h4Zk1MWGdMMTNNTjJnV2RGS0EzWUVsb0FlSGlB?=
 =?utf-8?B?VmFIeTdWOGV1dEdGSU1vcGgzdHlDNGVEM2F2dkR2T0hldFdLRlB4c0dpRU5v?=
 =?utf-8?B?eVYwRnJWdm82VHEvVFFRVE42OFZJTFhVOUIzb0dUK3QzTVRIOExMMFViRUFl?=
 =?utf-8?B?cjJSVlJoK2pxK3JtandUTTJPUlNxeG00SzdTbWw1Vk8wcWQrZ29rRDFCTDRJ?=
 =?utf-8?B?M1BoR0FTbks2OUhNU0JxRlhYSWFORGJSYWh2cDdBd1JyMFJVUS83RXNDVGph?=
 =?utf-8?B?U2hXSDloSk5iN1YxN3FBQ21uRVB3am5scUNIbHRJNmY0M2lpcXBvSnhMbVhS?=
 =?utf-8?B?OEJwR21xWkYwTjZCMDc5bzY4djdpU01YbCtWbHlPNGRpV3J5SFBzYmRweW1h?=
 =?utf-8?B?RGZwS3VJR0lpWG5pd0N3djdHS3Q0TnJtY1ZrSGpvNURDdW5CSlBSUUZyVlFT?=
 =?utf-8?B?c3VpTmFwTVpWc012b2xtY2t0ZVQrSlRzeGpMWi9Qa2RyQ0JYa01EQWNBbkFy?=
 =?utf-8?B?bE1lek5ialpRUkp3U2IreDEwNEI2Sm9PZ2J5NXMycDlTM2lhWGdsUlNWWTJI?=
 =?utf-8?B?MGRJQnhndVhmbndoZUduNmFsTEV2UnZvclk2M0V3R1JHM2c5NHA2c1Z3K1d5?=
 =?utf-8?B?OHA3THZzems3QSt2dUpGdnVEZ0RLNUVZNEQzU0RRVUF6aWh1QURIS1BhRjBn?=
 =?utf-8?B?WXNSWGhNSmhUZFZIdTdKMWpxNm9WSU51VUhGZ25tM0Z6VGt5V28wcFltVGtS?=
 =?utf-8?B?R0lLaCtiMGphMDVybktTTzA5a2dGdHBFSUdSdzl1NVY1Rk5ubWg3cjB4ZVhB?=
 =?utf-8?B?cGIwbW5rMzdpMHgyWkpxRTlFR1dhbk80bDcxZjdwREpha3RmeVZZNElxNlhs?=
 =?utf-8?B?aUxHenZmb2l6eEFmSUh3T3pFS01vK0Jzd0dHbXE5WU12MjdWWTAwQm5LdkNF?=
 =?utf-8?B?WUQvUU1WdnVPVG9jY1BlZ28rQ2RiSEM1QTM0MmZIQXJmbXg3SnpDSFQ5Q3A5?=
 =?utf-8?B?ZzlYbi9HN1J6VGhFMjRsR2w2blJFNjE4UDlSRjJvS2RiUXVRM1ZIdFZOdDVE?=
 =?utf-8?B?MDY5cnBNK2xVZVpkaGhyUHN1M0gyQktheDZXN1lZRVBTRnUxdFhnRFZsV1dM?=
 =?utf-8?B?enEzeis1NTU1dC9nQXVVcWZTVVZ3bTVHb3BaVzFWNldpT1Zyb0hGYVUwOHU4?=
 =?utf-8?B?R1BNaHNJUS9KM2xtMm0vb3RydjZmOVlNM1I5K3NoNjRaY2htNVIyUGtvalhi?=
 =?utf-8?B?bVJZVUhsS1B6QjcwQ3pWOGF0THdyNFZpc3A4Q0hZRVZOeUFwdXhKS3ppMlNF?=
 =?utf-8?B?V1ZJVm1vWWN4RkxhNWNJMzlMUUdVZEg0NkV0TnYvbGtZMzBMc25NbjZXUVRx?=
 =?utf-8?B?YjU4dFlqSUJyQzFpR3k4WjlHQk82OHNoODdZN1VKUzh4bWljMndGV3RCL1JL?=
 =?utf-8?Q?HyflKUSZRbMIJnzQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9CA53AD6387D1F449412174C54FD4C4E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4217271-ee60-490b-6d94-08da221e8a92
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 16:06:19.4936
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xn7miA+I50OvsMwcLDtW9Pbw96scI3b71JVEgtBif6YZoThkF3flAqFKmX+aFDHu+Mv7dHv/xLDL/DggRMc7fp4EVExXrZvp3dL/Bn4AjLA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5432

T24gMTkvMDQvMjAyMiAxNjo1MiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gT24gMTkuMDQuMjIg
MTc6NDgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxOS8wNC8yMDIyIDEwOjM5LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBCZXNpZGVzIHRoZSByZXBvcnRlcidzIGlzc3VlIG9mIGhpdHRp
bmcgYSBOVUxMIGRlcmVmIHdoZW4NCj4+PiAhQ09ORklHX0dEQlNYLA0KPj4+IFhFTl9ET01DVExf
dGVzdF9hc3NpZ25fZGV2aWNlIGNhbiBsZWdpdGltYXRlbHkgZW5kIHVwIGhhdmluZyBOVUxMDQo+
Pj4gcGFzc2VkDQo+Pj4gaGVyZSwgd2hlbiB0aGUgZG9tY3RsIHdhcyBwYXNzZWQgRE9NSURfSU5W
QUxJRC4NCj4+Pg0KPj4+IEZpeGVzOiA3MWU2MTdhNmI4ZjYgKCJ1c2UgaXNfaW9tbXVfZW5hYmxl
ZCgpIHdoZXJlIGFwcHJvcHJpYXRlLi4uIikNCj4+PiBSZXBvcnRlZC1ieTogQ2hleWVubmUgV2ls
bHMgPGNoZXllbm5lLndpbGxzQGdtYWlsLmNvbT4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1
bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+Pj4NCj4+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC9pb21tdS5jDQo+Pj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvaW9tbXUu
Yw0KPj4+IEBAIC01NTgsNyArNTU4LDcgQEAgaW50IGlvbW11X2RvX2RvbWN0bCgNCj4+PiDCoCB7
DQo+Pj4gwqDCoMKgwqDCoCBpbnQgcmV0ID0gLUVOT0RFVjsNCj4+PiDCoCAtwqDCoMKgIGlmICgg
IWlzX2lvbW11X2VuYWJsZWQoZCkgKQ0KPj4+ICvCoMKgwqAgaWYgKCAhKGQgPyBpc19pb21tdV9l
bmFibGVkKGQpIDogaW9tbXVfZW5hYmxlZCkgKQ0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1
cm4gLUVPUE5PVFNVUFA7DQo+Pg0KPj4gSGF2aW5nIHNwZW50IHRoZSBiZXR0ZXIgcGFydCBvZiBh
IGRheSBkZWJ1Z2dpbmcgdGhpcyBtZXNzLCB0aGlzIHBhdGNoIGlzDQo+PiBwbGFpbiBicm9rZW4u
DQo+Pg0KPj4gSXQgZGVwZW5kcyBvbiBKdWVyZ2VuJ3MgInhlbi9pb21tdTogY2xlYW51cCBpb21t
dSByZWxhdGVkIGRvbWN0bA0KPj4gaGFuZGxpbmciIHBhdGNoLCBiZWNhdXNlIG90aGVyd2lzZSBp
dCBlcnJvbmVvdXNseSBmYWlscyBub24tSU9NTVUNCj4+IHN1Ym9wcy4NCj4NCj4gV2hpY2ggaXMg
bm90IGEgcmVhbCBwcm9ibGVtLCBhcyBpdCBpcyBiZWluZyBjYWxsZWQgYWZ0ZXIgYWxsIG90aGVy
DQo+IHN1Ym9wcyBkaWRuJ3QgbWF0Y2guDQoNCkl0IGlzIGEgcmVhbCBwcm9ibGVtIGV2ZW4gbm93
LCBiZWNhdXNlIGl0IGlzIGJvZ3VzIGZvciB0aGUgaG9zdCBvcg0KZG9tYWluJ3MgSU9NTVUgc3Rh
dHVzIHRvIGhhdmUgYW55IGFsdGVyYXRpb24gdG8gdGhlDQpYRU5fRE9NQ1RMX2dkYnN4X2d1ZXN0
bWVtaW8gcGF0aC7CoCBUaGUgcm9vdCBjYXVzZSBvZiB0aGlzIGJ1ZyBpcyB0aGUNCmV4aXN0aW5n
IFhFTl9ET01DVExfZ2Ric3hfZ3Vlc3RtZW1pbyBjYXNlIGJlaW5nIGNvbXBpbGVkIG91dCBpbiB0
aGUNCiFHREJTWCBjYXNlLg0KDQpJdCB3b3VsZCBiZSBhIG1vcmUgb2J2aW91cyBwcm9ibGVtIGlm
IHRoZXJlIHdlcmUgY2FsbHMgY2hhaW5lZCBhZnRlcg0KaW9tbXVfZG9fZG9tY3RsKCkgaW4gdGhl
IGFyY2hfZG9tY3RsKCkgZGVmYXVsdDogYmxvY2tzLCBiZWNhdXNlIHRoZW4gaXQNCndvdWxkbid0
IG9ubHkgYmUgY29tcGlsZWQtb3V0IGZ1bmN0aW9uYWxpdHkgd2hpY2ggaGl0IHRoaXMgY2hlY2su
DQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 16:07:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 16:07:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308358.524069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqNk-0003s2-UZ; Tue, 19 Apr 2022 16:07:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308358.524069; Tue, 19 Apr 2022 16:07:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqNk-0003rt-Rc; Tue, 19 Apr 2022 16:07:12 +0000
Received: by outflank-mailman (input) for mailman id 308358;
 Tue, 19 Apr 2022 16:07:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tr1R=U5=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ngqNj-0003dY-G3
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 16:07:11 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c49a7b8e-bffa-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 18:07:10 +0200 (CEST)
Received: by mail-lf1-x12f.google.com with SMTP id t25so30227730lfg.7
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 09:07:10 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 a31-20020a05651c211f00b0024b6d5b5fcbsm1481765ljq.3.2022.04.19.09.07.08
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 09:07:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c49a7b8e-bffa-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=9dmG7W9zp1kq7XBNzCHfO8hR9Fm2rHVSLavsB+HOb/Y=;
        b=Z/6Sz6bcyRTYPnPZ1PdFN9ZY5Ly9p9KJitA5sO34tukgz0XNT8+Uap+Ka5a/HZVRs4
         jJWshiBUS+8Lm6orvl7pyke7Jz44WdVN3wqsRrJAnaDIY8EZPNhopOWtjea0fUTVDWnH
         1EC1+ty1rLdu4mkzy8dGlkDFMtIiRhcQjxfAjNw2Fyy5bBTeCRVkcbcDx6osaw1P/RRz
         TjwaF5HReas/JVK+jTyCWo69KX44M6uSBQJD1noRRLtgyrekMZwZavoJbdqKrpeEH3v6
         /uh6tpbEw2f+bETzlVFgczsCPV59a55W9tcFfy4+O6pBUH0c39eIeXK6IQQUvqxyigGb
         nxWA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=9dmG7W9zp1kq7XBNzCHfO8hR9Fm2rHVSLavsB+HOb/Y=;
        b=OzwKakZk1QCLAilLaNgorVFUnwZS8H1Nnx4uKD7SRqyEX/zTsZYug74/9KZnITYgXh
         beBrvgInTwOiBUFRYKLnySjB4sNCsaj8mIaeNEWZ92HBulbvBH+rP9S3oHYymAY367QZ
         pewjigB6pXs7Ex2ZrFK0dl3WVZv29FJU/Rt9BGrAFMo1+gXb/2hpwxdC7HQOYpn1BcER
         3WOO6GsOr0L0drinOHY24D4CJNnr5BwWn211rF4XqVg3do2mgFCkDn2RcUNP4gN2tdLY
         wnYQVGyikE8tOp9SL56aDj/6WC7nbNvJ3uyqNjHr2QMghP1iT8BZ1HVgdO5V3s7T1RkG
         1nYg==
X-Gm-Message-State: AOAM532/Ubk63yOJBY1C5H7DPIuQld+5f3GyP70tKGcuOPdxIAEpOclX
	N4mmkubVfFqJsgyWXoAwaI4=
X-Google-Smtp-Source: ABdhPJx7Q1ckwSUyY3tt6IZtLnWa0mr/YOkugIp4zoIabshWYAr9PyjpuAY7ICNZDCrOBHhuHmrPXg==
X-Received: by 2002:ac2:4c21:0:b0:46b:b7d0:72dd with SMTP id u1-20020ac24c21000000b0046bb7d072ddmr11785679lfq.0.1650384429671;
        Tue, 19 Apr 2022 09:07:09 -0700 (PDT)
Subject: Re: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jiamei Xie <Jiamei.Xie@arm.com>, Henry Wang <Henry.Wang@arm.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204181417370.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6f2a970e-36b4-b2d4-a0ee-04f3ab31b985@gmail.com>
Date: Tue, 19 Apr 2022 19:07:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204181417370.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 19.04.22 00:41, Stefano Stabellini wrote:


Hello Stefano

> On Fri, 8 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Julien Grall <julien.grall@arm.com>
>>
>> This patch introduces helpers to allocate Virtio MMIO params
>> (IRQ and memory region) and create specific device node in
>> the Guest device-tree with allocated params. In order to deal
>> with multiple Virtio devices, reserve corresponding ranges.
>> For now, we reserve 1MB for memory regions and 10 SPIs.
>>
>> As these helpers should be used for every Virtio device attached
>> to the Guest, call them for Virtio disk(s).
>>
>> Please note, with statically allocated Virtio IRQs there is
>> a risk of a clash with a physical IRQs of passthrough devices.
>> For the first version, it's fine, but we should consider allocating
>> the Virtio IRQs automatically. Thankfully, we know in advance which
>> IRQs will be used for passthrough to be able to choose non-clashed
>> ones.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> Tested-by: Jiamei Xie <Jiamei.xie@arm.com>
>> Reviewed-by: Henry Wang <Henry.Wang@arm.com>
> I realize that we are at v7 and I haven't reviewed this before, so I'll
> limit my comments. I'll clarify the ones that I think are more important
> from the one that are less important.

thank you


>
>
>> ---
>> @Jiamei, @Henry I decided to leave your T-b and R-b tags with the minor
>> change I made, are you still happy with that?
>>
>> s/if (disk->virtio)/if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
>>
>> Please note, this is a split/cleanup/hardening of Julien's PoC:
>> "Add support for Guest IO forwarding to a device emulator"
>>
>> Changes RFC -> V1:
>>     - was squashed with:
>>       "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way"
>>       "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node"
>>       "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT"
>>     - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h
>>
>> Changes V1 -> V2:
>>     - update the author of a patch
>>
>> Changes V2 -> V3:
>>     - no changes
>>
>> Changes V3 -> V4:
>>     - no changes
>>
>> Changes V4 -> V5:
>>     - split the changes, change the order of the patches
>>     - drop an extra "virtio" configuration option
>>     - update patch description
>>     - use CONTAINER_OF instead of own implementation
>>     - reserve ranges for Virtio MMIO params and put them
>>       in correct location
>>     - create helpers to allocate Virtio MMIO params, add
>>       corresponding sanity-сhecks
>>     - add comment why MMIO size 0x200 is chosen
>>     - update debug print
>>     - drop Wei's T-b
>>
>> Changes V5 -> V6:
>>     - rebase on current staging
>>
>> Changes V6 -> V7:
>>     - rebase on current staging
>>     - add T-b and R-b tags
>>     - update according to the recent changes to
>>       "libxl: Add support for Virtio disk configuration"
>> ---
>>   tools/libs/light/libxl_arm.c  | 131 +++++++++++++++++++++++++++++++++++++++++-
>>   xen/include/public/arch-arm.h |   7 +++
>>   2 files changed, 136 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>> index eef1de0..8132a47 100644
>> --- a/tools/libs/light/libxl_arm.c
>> +++ b/tools/libs/light/libxl_arm.c
>> @@ -8,6 +8,56 @@
>>   #include <assert.h>
>>   #include <xen/device_tree_defs.h>
>>   
>> +/*
>> + * There is no clear requirements for the total size of Virtio MMIO region.
>> + * The size of control registers is 0x100 and device-specific configuration
>> + * registers starts at the offset 0x100, however it's size depends on the device
>> + * and the driver. Pick the biggest known size at the moment to cover most
>> + * of the devices (also consider allowing the user to configure the size via
>> + * config file for the one not conforming with the proposed value).
>> + */
>> +#define VIRTIO_MMIO_DEV_SIZE   xen_mk_ullong(0x200)
> Actually, I don't think we need to make this generic. We only support
> virtio-disk now and I think it is fine if this was called
> VIRTIO_DISK_MMIO_DEV_SIZE and the size was exactly the size needed by
> virtio-disk. When/if we support another virtio protocol we can add set
> the appropriate size of that one as well.

I would prefer if we keep this generic, although we are going to support 
virtio-blk as the first virtio-mmio device, there is nothing disk 
specific in that value. The same value (0x200) is used
by SW which also generates virtio-mmio device tree nodes like we do in 
Xen libxl, I am speaking about kvmtool, Qemu here.


>
> At the moment as you can see below:
>
>       */
>      for (i = 0; i < d_config->num_disks; i++) {
>          libxl_device_disk *disk = &d_config->disks[i];
>
>          if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO) {
>
> it is all very virtio-disk specific, so we might as well exploit it for
> the better :-)
>
> Given that we are at v7 of this series, I don't think this is very
> important, so I think it is OK if we keep the code as is.

ok


>
>
>> +static uint64_t virtio_mmio_base;
>> +static uint32_t virtio_mmio_irq;
> No need for these two variables to be global in this file, they could be
> local variables in libxl__arch_domain_prepare_config.
>
> I think that this is a change we should make if possible before
> committing these patches.


I agree with that, will do


>
>
>
>> +static void init_virtio_mmio_params(void)
>> +{
>> +    virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE;
>> +    virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST;
>> +}
>> +
>> +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc)
>> +{
>> +    uint64_t base = virtio_mmio_base;
> If virtio_mmio_base is local in libxl__arch_domain_prepare_config, then
> it could be passed here as parameter (as pointer).


yes, good point, will do


>
> If we make the dev MMIO size (GUEST_VIRTIO_MMIO_SIZE) specific to
> virtio-disk, then we could pass it also as argument to this function:
>
> static uint64_t alloc_virtio_mmio_base(libxl__gc *gc,
>                                         uint64 *virtio_mmio_base,
>                                         uint64_t dev_mmio_size)


Please see my comment regarding VIRTIO_MMIO_DEV_SIZE above



>
>
>> +    /* Make sure we have enough reserved resources */
>> +    if ((virtio_mmio_base + VIRTIO_MMIO_DEV_SIZE >
>> +        GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) {
>> +        LOG(ERROR, "Ran out of reserved range for Virtio MMIO BASE 0x%"PRIx64"\n",
>> +            virtio_mmio_base);
>> +        return 0;
>> +    }
>> +    virtio_mmio_base += VIRTIO_MMIO_DEV_SIZE;
>> +
>> +    return base;
>> +}
>> +
>> +static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc)
>> +{
>> +    uint32_t irq = virtio_mmio_irq;
>> +
>> +    /* Make sure we have enough reserved resources */
>> +    if (virtio_mmio_irq > GUEST_VIRTIO_MMIO_SPI_LAST) {
>> +        LOG(ERROR, "Ran out of reserved range for Virtio MMIO IRQ %u\n",
>> +            virtio_mmio_irq);
>> +        return 0;
>> +    }
>> +    virtio_mmio_irq++;
>> +
>> +    return irq;
>> +}
>> +
>>   static const char *gicv_to_string(libxl_gic_version gic_version)
>>   {
>>       switch (gic_version) {
>> @@ -26,8 +76,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>>   {
>>       uint32_t nr_spis = 0;
>>       unsigned int i;
>> -    uint32_t vuart_irq;
>> -    bool vuart_enabled = false;
>> +    uint32_t vuart_irq, virtio_irq = 0;
>> +    bool vuart_enabled = false, virtio_enabled = false;
>>   
>>       /*
>>        * If pl011 vuart is enabled then increment the nr_spis to allow allocation
>> @@ -39,6 +89,35 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>>           vuart_enabled = true;
>>       }
>>   
>> +    /*
>> +     * Virtio MMIO params are non-unique across the whole system and must be
>> +     * initialized for every new guest.
>> +     */
>> +    init_virtio_mmio_params();
> No need to initialize them in init_virtio_mmio_params, you could just
> do:
>
>    uint64_t virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE;
>    uint32_t virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST;
>
> at the top of libxl__arch_domain_prepare_config


yes, will do


>
>
>> +    for (i = 0; i < d_config->num_disks; i++) {
>> +        libxl_device_disk *disk = &d_config->disks[i];
>> +
>> +        if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO) {
>> +            disk->base = alloc_virtio_mmio_base(gc);
>> +            if (!disk->base)
>> +                return ERROR_FAIL;
>> +
>> +            disk->irq = alloc_virtio_mmio_irq(gc);
>> +            if (!disk->irq)
>> +                return ERROR_FAIL;
>> +
>> +            if (virtio_irq < disk->irq)
>> +                virtio_irq = disk->irq;
>> +            virtio_enabled = true;
>> +
>> +            LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64,
>> +                disk->vdev, disk->irq, disk->base);
>> +        }
>> +    }
>> +
>> +    if (virtio_enabled)
>> +        nr_spis += (virtio_irq - 32) + 1;
>> +
>>       for (i = 0; i < d_config->b_info.num_irqs; i++) {
>>           uint32_t irq = d_config->b_info.irqs[i];
>>           uint32_t spi;
>> @@ -58,6 +137,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>>               return ERROR_FAIL;
>>           }
>>   
>> +        /* The same check as for vpl011 */
>> +        if (virtio_enabled &&
>> +           (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) {
> NIT: alignment:
>
>          if (virtio_enabled &&
>              (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) {


ok


>
>
>
>> +            LOG(ERROR, "Physical IRQ %u conflicting with Virtio MMIO IRQ range\n", irq);
>> +            return ERROR_FAIL;
>> +        }
>> +
>>           if (irq < 32)
>>               continue;
>>   
>> @@ -787,6 +873,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt,
>>       return 0;
>>   }
>>   
>> +
>> +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
>> +                                 uint64_t base, uint32_t irq)
>> +{
>> +    int res;
>> +    gic_interrupt intr;
>> +    /* Placeholder for virtio@ + a 64-bit number + \0 */
>> +    char buf[24];
>> +
>> +    snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base);
>> +    res = fdt_begin_node(fdt, buf);
>> +    if (res) return res;
>> +
>> +    res = fdt_property_compat(gc, fdt, 1, "virtio,mmio");
>> +    if (res) return res;
>> +
>> +    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
>> +                            1, base, VIRTIO_MMIO_DEV_SIZE);
>> +    if (res) return res;
>> +
>> +    set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING);
>> +    res = fdt_property_interrupts(gc, fdt, &intr, 1);
>> +    if (res) return res;
>> +
>> +    res = fdt_property(fdt, "dma-coherent", NULL, 0);
>> +    if (res) return res;
>> +
>> +    res = fdt_end_node(fdt);
>> +    if (res) return res;
>> +
>> +    return 0;
>> +}
>> +
>>   static const struct arch_info *get_arch_info(libxl__gc *gc,
>>                                                const struct xc_dom_image *dom)
>>   {
>> @@ -988,6 +1107,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config,
>>       size_t fdt_size = 0;
>>       int pfdt_size = 0;
>>       libxl_domain_build_info *const info = &d_config->b_info;
>> +    unsigned int i;
>>   
>>       const libxl_version_info *vers;
>>       const struct arch_info *ainfo;
>> @@ -1094,6 +1214,13 @@ next_resize:
>>           if (d_config->num_pcidevs)
>>               FDT( make_vpci_node(gc, fdt, ainfo, dom) );
>>   
>> +        for (i = 0; i < d_config->num_disks; i++) {
>> +            libxl_device_disk *disk = &d_config->disks[i];
>> +
>> +            if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
>> +                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) );
>> +        }
>> +
>>           if (pfdt)
>>               FDT( copy_partial_fdt(gc, fdt, pfdt) );
>>   
>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
>> index ab05fe1..c8b6058 100644
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -407,6 +407,10 @@ typedef uint64_t xen_callback_t;
>>   
>>   /* Physical Address Space */
>>   
>> +/* Virtio MMIO mappings */
>> +#define GUEST_VIRTIO_MMIO_BASE   xen_mk_ullong(0x02000000)
>> +#define GUEST_VIRTIO_MMIO_SIZE   xen_mk_ullong(0x00100000)
>> +
>>   /*
>>    * vGIC mappings: Only one set of mapping is used by the guest.
>>    * Therefore they can overlap.
>> @@ -493,6 +497,9 @@ typedef uint64_t xen_callback_t;
>>   
>>   #define GUEST_VPL011_SPI        32
>>   
>> +#define GUEST_VIRTIO_MMIO_SPI_FIRST   33
>> +#define GUEST_VIRTIO_MMIO_SPI_LAST    43
>> +
>>   /* PSCI functions */
>>   #define PSCI_cpu_suspend 0
>>   #define PSCI_cpu_off     1
>> -- 
>> 2.7.4

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 16:10:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 16:10:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308365.524080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqQa-0005IW-CU; Tue, 19 Apr 2022 16:10:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308365.524080; Tue, 19 Apr 2022 16:10:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqQa-0005IP-9L; Tue, 19 Apr 2022 16:10:08 +0000
Received: by outflank-mailman (input) for mailman id 308365;
 Tue, 19 Apr 2022 16:10:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngqQY-0005E1-5K
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 16:10:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2cb725ce-bffb-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 18:10:05 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-Ea-c1LPSMgi1P9QhXHsqAA-2; Tue, 19 Apr 2022 18:10:03 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB6381.eurprd04.prod.outlook.com (2603:10a6:803:119::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr
 2022 16:10:01 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 16:10:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2cb725ce-bffb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650384604;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dCDYEKUCO+dMtuodMiTYj5Y+Ayt7E5b8580ldvcs6XM=;
	b=BdeNBtNvyNX2y1heGYkjtMygDQfd5qSyFA4FT+Rlac8Y3+TBrdJPumhledJW8nfYyD4Iy4
	cAT1gScgjKRIJdCcFgICI2+K0+YlrYRRgA/i7K57k2zZ0BaA0CfNKpHxdzAPDOBnLtBZF9
	49Jor6GMaKYQ1ifPfTBPq5uC0iUspX8=
X-MC-Unique: Ea-c1LPSMgi1P9QhXHsqAA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RnOedifyUeTDNLUuZuIQXr+YlNB16xgfsV9UHaccBxUsbSSKLA6xNQS1IeY+jzDr/ZVlgVIRn2GV6bGZP0DVEYtv/i5Lv6Sqzc4Dnfmr40J6H5s6u+htePRpvHXWY4oF73NaOHJfuLVExAVg0JceaKeRDpvvW7BELImIpXztiW4DaBZREI80Mkw8owV8t/7slWsO6vxQZdMkxrYm1jELDZugC3ueOToUDnLPJ5trQfgoWj/a4XvufTfiTEJSnG/HTtHVRPllqBM07ysX40LpO03GezvvyiF/hCz4o0IFo5eho/ETdJogh7t+q2oQbJWeRURMwvp25+7dlFEWpPDcTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gvGw7Hb4+0vYtzFeEsJZSnAYfW4hflet8Jt85t+40xM=;
 b=nW29xzVYHpi6L+d4o7LZIhQQ60jRgsEwaO5ghssE3UKHT1N6CvZx411ZkBWQn7NAVr/5MgNYtYMn0vVseUVoUXBfni9MnmtZlfn+pb7m8kz28jPzATNmUIPVd0fLD/vZ+VvlEtbbzJvaq9037ER2eU+PqFZXJAiQN4Vl+dITuOKXyrLA6TKA4zVmFt3oeLmjmUtpZw/WNpgzqeB70MY8LzpaxQkZeOmv/QcN8zzwwpC4/EB/+d7bGSewE4cjqryETmUqYubLuJ1hgFKR7D4SbO+Uuh4+qWwD8ZWdRDPyZWh5RXHy4+VpMAH7yRKPC1/FcdkFaM2AU/6B6FJlbsJ9VA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b0d5d7fc-42ff-0e8e-7314-b90a15289b6e@suse.com>
Date: Tue, 19 Apr 2022 18:09:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
 <6732a3c3-fc19-cbdf-7483-9f5946f1935a@citrix.com>
 <48fe2a98-98de-8aa5-8d3b-e70427008edb@suse.com>
 <cbbd3bb9-c76e-7ba6-7cef-66d47e6d367b@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <cbbd3bb9-c76e-7ba6-7cef-66d47e6d367b@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0004.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::17) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a76aa747-d157-4ed4-0f02-08da221f0e61
X-MS-TrafficTypeDiagnostic: VE1PR04MB6381:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6381B8564B80A6AB75AC29A9B3F29@VE1PR04MB6381.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MoFI1nyc3MkJis89M2Ny/Z4VoVnBJE4YxHvFAMKmFS9YIF2+TuR8rDly8HuyFR4xHJeaPnn8gjzcMfdc++6R87c5HJ19uj34c1xgRg9D/A+wILOfNPYvNfYfp+vLdn4vaIF6DvTr6FfCybTiW4XMmPgFPtcyatsCmTWSn51rROZuHWlUYK6Y+UsKoMO+Vxs0PMt434PUptAoFekr9Z4TIzJjuu+bZApS9WW/4R2E8+Uwwxc9anbP3RA3DHYJslXaC/tJvEBOH/oXf4ULWVQ0NL6u9ZwvmyeP5nUdr1utIzDYGuyj49C94vF2YrrkiKjw7r3L77LKUEoxu4pU/T03kltIIcMutqeG3ZaEuX8l7LRcDDy7TvWrqksFR02iad0XVpfSMWkh3tRNzFXTjL2wUXBM4wAmfDLP2k4Rb/A4/z2M6e7HW4QVbsyjAFhCdkYGcet9caAcjQZDb7yErdUx1BPBag6uAXc2O8OpEdXESFEjJ77C0bealO5pUPaeLTMm0wQSVB2K0AysbNEBgRGFHj2K7MCWyLIqLxM7WREYRo/7WUBcueq+CtywNj7NuPyUBSJLzwv/FU46q0kajF1ArNmPRpYeOAGLC7AFLNbaKj2uhl56m1FnMZ11sa8F/Br65RLyukCIGuc53nGKyeHQdzifnlDk83sQtfADCiL/REYV/uIdRPIa1aHYCZ/fKPlj/EkrhH7sWv8pwrkZYCO+lgq2xp/pYM5xiGN72Veq8P4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(508600001)(4326008)(66476007)(66556008)(8676002)(54906003)(2616005)(5660300002)(2906002)(53546011)(8936002)(6512007)(6506007)(31686004)(36756003)(31696002)(66946007)(38100700002)(86362001)(6486002)(316002)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TqpHx34CoV3K4508EVNtLi/4rYfPUfIfjp96jkRGr8xCMPZlTf3vxRRaR4wP?=
 =?us-ascii?Q?O2KcbVe8ynj3mujw5T89+9P1b9NnSu0lpPIal9og4RUzdgac/+XjpOhytNON?=
 =?us-ascii?Q?aIIHVstBARFOgE/0aVo/UgiVomkV61xTKv8tRSiJvo2UE9MwAcZPHkaI49Mt?=
 =?us-ascii?Q?FVjkgN/3C2ncp7efVHAoAwTvLCaSYDdDnj/GMNNgsEcaYucprZP+zWIy+lUs?=
 =?us-ascii?Q?U1MYyBYEo1PdJt9C4F5IYbSIdQjn3cmwpqLAeAs4QL9koNUqY9vGs0GdT1RC?=
 =?us-ascii?Q?HH2pAcasTTt9RFXvR5o8mLeqzepnyD4fZIsAY5chRjpZw2AA7uaRbdR4lZtE?=
 =?us-ascii?Q?X8QfTAO11R0p7qYZ9NOA0qKftw4w9kZwXTN/Br9Wy8vKk56XWH8Is1XTwPr6?=
 =?us-ascii?Q?gstrnm2Drj+BP+QNmJ3vfneLkOin+3V4Ty51f0yqs8MEMcDPnOrIXWy/muo2?=
 =?us-ascii?Q?/PqG/v3acetz1NtH+Lehs2VoroNig97SYIIZPmZr8XyJcTMs3QNYrhWyUpqC?=
 =?us-ascii?Q?C5YgpiDUpviEv0fQq4u6urRdrQ2wwCHUTVibRM0dNeyVf3TbCnqKFANJ43eR?=
 =?us-ascii?Q?ta7KGGmLTD3GxL4GkrqMOwWm966IWTme3ii/96htH2ZxvHkTW9O8Y8hOgyZK?=
 =?us-ascii?Q?PFHXFDXV9ql9t7XP5IcqQavXRhqk23nD4T+cR0mad0NhPdxPeSGvV1iRfqO9?=
 =?us-ascii?Q?HaekGNdfitrxgsy8OiBbnm37cFefSylcdEb/CtSZK62N+fzWcKjor7rz5ywd?=
 =?us-ascii?Q?ef6lr0eHqWXhHyWBRlzbqJjHmBm0XvpsriNhUxX8vQ5nbUvE129ppJB7CCdd?=
 =?us-ascii?Q?BwL/Bz1uuYONHQo0loGE7LZjMlUvpcVjHLGnQgyi4fneJQWoIJSfQY+CaUxr?=
 =?us-ascii?Q?agMwA7qY1B83hzNYFw6dwuPYM/p5C5gh2awdLJTgyoB2TpnCMC5gjPU+fsij?=
 =?us-ascii?Q?HQmYuEkHEBVJuiVKj/Ky88pfwm5+P++U+cnwPn/+zZBo2lX964EEphCVO78L?=
 =?us-ascii?Q?/UaHEmVCep1lTcpkGBk8QGKpTknQTo9tzA8OjapGaf70rIEJwZYGeBGXpF50?=
 =?us-ascii?Q?A9VuYux+skihCaxzu1S4dv/4O4Jgo9/nboIDaK6UMiWY0AM5yBe0KxIRlCFl?=
 =?us-ascii?Q?gov2U5GR7ZdngQmWgHtlkBulgarmOKdBG5OXit+5j0awdq/GZfwh1IRHNe/S?=
 =?us-ascii?Q?mwY7bIhenQ/TrhQO3fQToavzckB/Abn6KiXx3GHZjg25XIb5nWXXdnqRvJUg?=
 =?us-ascii?Q?jHGxqbKu/q7LFZwmK1yj/oizPrONXWtjbL+PVM7bB6A1nqPJi5AhNMFU7dlL?=
 =?us-ascii?Q?UOFb5iSmlMHGSL8RvikYnH71naCEc0xqlBx4NEJwnqAejwfu4Ou8X2kbNa59?=
 =?us-ascii?Q?MqiKW54dalKB8wWL5JTmZ8scCK0dnBQZ4Bx8pjOWkhIduwXZg6XftB2Kt425?=
 =?us-ascii?Q?2+i/sTx/Qa3OFZM3/PmJw1oDcTsy1/odb3RMTF3ahii+Pw8H7JWCJO1KTu3u?=
 =?us-ascii?Q?/vwvC6qnYfvUrgwODIvwGYk7/F+jL8oY/Z6HjzXAPejovQSuavCcUOK5pnPM?=
 =?us-ascii?Q?PnxHW4LQlKXb2jXcX83siCKcoSciXOY5lR2ygsZO+xmWVx/mEh3SWMDb+HD8?=
 =?us-ascii?Q?rYCXxJ2iFarDVUT8otAfXSK+th0AIiiqyY0sLYPufKcSQvcf5jxZktwr3whu?=
 =?us-ascii?Q?HH//+dqBf+UA8ILRU07nKVeYuSpnCBm3rII1y+79A2aIIU0AtLFbGEDU/g4h?=
 =?us-ascii?Q?4raWNpADcw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a76aa747-d157-4ed4-0f02-08da221f0e61
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 16:10:00.8637
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c8XN0Uxtel6VSmV9T5PCzrxMpTqv71tIuXvcscK1UO8UZdqJRr7JPFEt/LsLDsq0kFu4ovcxxKlHf5YYyo//+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6381

On 19.04.2022 17:39, Andrew Cooper wrote:
> On 19/04/2022 11:59, Jan Beulich wrote:
>> On 19.04.2022 12:49, Andrew Cooper wrote:
>>> On 19/04/2022 10:39, Jan Beulich wrote:
>>> Furthermore, under what circumstances is test_assign_device legitimate
>>> when passing DOMID_INVALID ?=C2=A0 This has been broken for 3 years now
>>> without report, so it's clearly an unused codepath under both xl's and
>>> xapi's idea of passthrough.
>> I guess xend had a way to drive the domctl this way.
>=20
> Looking at the xend code, it always called with domid 0.
>=20
> I can't see any evidence that there has actually been a caller passing
> DOMID_INVALID, but this is an utter mess.
>=20
>>  Iirc this was
>> to find out whether a device is assignable at all, without needing
>> to know of any particular valid domain.
>=20
> In a correctly architected IOMMU subsystem (which Xen most definitely
> does not have at this juncture), that question is "Does the device have
> an upstream IOMMU".
>=20
> Xen doesn't currently have a working idea of an x86 system with IOMMUs
> but not covering all devices.=C2=A0 While such a system is unlikely to ex=
ist
> in reality, there are cases where quirks create asymmetric coverage.=C2=
=A0
> Either way, this is fully subsumed by the future work to assign IOMMU
> groups.
>=20
> Also at the moment, because Xen doesn't support per-device IOMMU
> contexts, another check not performed is whether this devices identity
> maps are compatible with the identity maps in the target domain.=C2=A0 Ex=
tra
> complexity here is that it will not occur on a single system
> (Conflicting RMRRs/IVHDs on a single system is definitely a firmware
> bug, not an accurate description of the system); only with migration
> between systems where equivalent logical devices have differing identity
> requirements on different systems.
>=20
>=20
> I don't see anything useful the "with a domid" version gets you.

Hence I guess someone thought allowing DOMID_INVALID there would be a
good idea, irrespective of whether xend actually did things this way.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 16:11:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 16:11:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308368.524091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqS9-0005tP-OA; Tue, 19 Apr 2022 16:11:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308368.524091; Tue, 19 Apr 2022 16:11:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqS9-0005tI-L0; Tue, 19 Apr 2022 16:11:45 +0000
Received: by outflank-mailman (input) for mailman id 308368;
 Tue, 19 Apr 2022 16:11:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TFaJ=U5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1ngqS9-0005tC-4h
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 16:11:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 67b41b99-bffb-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 18:11:44 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-_OJbGZblMEunJvArff3yjw-1; Tue, 19 Apr 2022 18:11:41 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB6692.eurprd04.prod.outlook.com (2603:10a6:208:178::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 16:11:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022
 16:11:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67b41b99-bffb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650384703;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HFmZqkcXGhKN6K6YuRYlFKj2+yOjbq+whtO4ONUfnKA=;
	b=a+t9cvrKsJdH3L08ZgziDOG0NRg5vFupCKB1AfeRJM6Ycv2MYFp/pClObRQzrEV2BTfyGh
	96XDLakGCZCwE38Zf5cHvSfdUE420qZNDicSUB7PIkiHcPcDnzje6driMByLit8ny2jkSe
	2a1CifhJwktVN21Ys+eEWD2A/00u8oI=
X-MC-Unique: _OJbGZblMEunJvArff3yjw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Hs6AHmNvjG+SmkqrhfHKD2n+FPWyWSWeXVW2II8yE4VlOKM756VjerMH0/gSbZFDDX+CwgSEN0FPnrRHL2Y3wuXrTJ+qRh/ZrtseQeRKw+WjgHjLIzwEzK60WsSuNJYv2jPjTejSe8anew6VfhEpukd3SkuLkmObSwohnJ64DxOi6zvziRCZO62kZb2qukVJDMLinbxy05YfVe4J5hMI2uOkOJgp7xCmZwYdDhceoD9oX2xkxoQRl8RTYDHxL5VGz8Q4S9m8dXsv60rgYkSKxCP0LR8BCdU9jnMr2OOCyDf15iKbpfEAlZq7H8cSNBd1CeEvVkyRJrBeVaIfPMfuMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vilVxsJ+tP9LA+TwxYNqiVL7yWsVR68kFLREE+H37Rk=;
 b=Ip52erZispz/GD6wxQI03uVUfElVe9pdnzxsgjNDIjOMMCWq6do+atszgk2AhY0GaKJz+x85R6QFSIZTurYmxQnWdvVUnHqgb7307lCJ1/FiUplPTyKGvCunOKjLTg8jw691oZlxZxih0rWe3qJwkltUo6PR0RAp9yI31SvNwVQohFchFupxqA8q7aA1Cs6KNDMW9shp+qECfnItCSvKbd5SyK2s9GLVusiZyOurNPYFalpcfOZQzlxuv5WuKyDHSMmDrblNGUfvUksQeOcpyMPfPeAc17PeLsvOxWHX7/zsSNdaca1Dkab0HohQyNFtW+Rt64BhDm5FCVgXwfRFKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <677f8b53-0a62-a76e-cebb-db8532f3ee45@suse.com>
Date: Tue, 19 Apr 2022 18:11:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 3/3] xen/iommu: cleanup iommu related domctl handling
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <George.Dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <20220419135254.21729-1-jgross@suse.com>
 <20220419135254.21729-4-jgross@suse.com>
 <1d1dfeec-6268-1be1-48e1-44b38eed36fd@citrix.com>
 <93390fcd-4bef-588a-a8e4-ae0a5278acd1@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <93390fcd-4bef-588a-a8e4-ae0a5278acd1@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0037.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::14) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 298043bd-d871-42ee-43cf-08da221f4713
X-MS-TrafficTypeDiagnostic: AM0PR04MB6692:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB66927913445DE856EA5E25DAB3F29@AM0PR04MB6692.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2rLInjf1xJspMsovFaBkZUpah1YZObqpkAPgOUjY4lIwgdd8adbmtJWpoXvq1YhvOOMW2QbDPF4bBcDNARZbdkhJ47B8WVCRcGzs2BYEgJkGgs1vS0JIjo73p8b4XG6PbA38pagBOe6kiFpeL4/STytgpG/JY6f0bS7pGhgGCsGIm5VwX0CmZSFP+B/t84eW50k3WKJDsZwv8KjCN6P8RrY/tqgVF44hsKpYe5roLsy2d5c+9MrYSNj5WmwHPEvvEzhv9ffETmNb4+uljZ60RLxISUG4PxDlTGK6ISuvcO/Qpdc7EI+WwMY3Bsn3NgufSwko4qBNGmgMBtLF3KXOAPtBnvMuqblA+JG1614r79pZZOlA8wvcjfZbTJmhUyowOhJOkCsZOPwsma6jHxsiNqfC0J5pqel6Cu0SLyZIhsCJmiXqPUkeRFX5pdG0NPGOyl8fTZlj5Sab1v3kE1QVJt6bzTvJZGo5iGbgLkr4t42MSx0QpDczhu8X8WFzwXHxlCmo42ubQp2N2JgzGJjbnpTPoAwobuY1iOUPbjsEtmHPOJcyXapzwbp7APek15vt8UbnikkZxs7dZepXSsycgWQuBJ+oLI458zRK7oAQmupqgZiFOINEi9umiwi5l9KXh2fFqEL+/NdoHiOg6/DlS11uHW2F+8IjFbo1xjvNspHlKDCcZ3YkwtCiEqjZ5G+6EgRkch2c5tuLdcJocQDpUw/1DqelIZnJss445Enl7HZVzyu8lte+bVOmZ0D4xbJa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66476007)(26005)(6862004)(66946007)(66556008)(8676002)(38100700002)(5660300002)(8936002)(2906002)(508600001)(6486002)(6512007)(86362001)(31696002)(6506007)(53546011)(316002)(6636002)(36756003)(31686004)(37006003)(54906003)(186003)(2616005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/Hpr+S5NZ9SsRtvNHUEdlA/o43cANdDquIbxa+9aaBpxr5Zy8JASKLISyiCc?=
 =?us-ascii?Q?jO3GnwQlyV0JOvr+290s4zeuqjoAXhPpoqajS95yCg6b+bzyqm1AV62jmVBX?=
 =?us-ascii?Q?feIDkbYDzGi5kgpr/2hT7gMSa/6tKWy6ejxCEHyZJGEPfriNSfMuGnwrtpyC?=
 =?us-ascii?Q?Io/DyurJrlsbErhNstELMY9lHod/eiF0YyNtQRhXwfc3r5yJyCtKSxhA56vm?=
 =?us-ascii?Q?Yyay1V8Wd4RibWdYMdEmIq+ThPn/22ju/VHqMPsEqHInO4he9i1lZSe8Yqir?=
 =?us-ascii?Q?bWhZj9Liuy+qiIADgT81kWvHZWVydp4Zmcjtpw6CIIfx1gOwEQsrzeRTBw1Z?=
 =?us-ascii?Q?++FO6BvDl5UagdIL977Z+sELQ2YpF3rCpDmZWSelEMmM+ALIwscxMER0t6Xu?=
 =?us-ascii?Q?kVlUj46wz14rxf9nk8aJpWFq19exsscJhLIJjXgV3iZ9RdBdTvsvCSlKrdlu?=
 =?us-ascii?Q?DDT8i7hh1U4I48NZSm2SIWngLlIU+AOVZfcM6agxCPUMZpkvF99pJ/hYI8xG?=
 =?us-ascii?Q?iXm1xPEi1GN0ajBKJqVTpdBNEs6Hd00m4610o/bqtwqU+SHcOxBp+9SiwD0i?=
 =?us-ascii?Q?l4MKznZv+wKYnuvNNecdM62V0/3Vf+KWak2iqg1kwMDFjPBMEqnbLB8Epaf9?=
 =?us-ascii?Q?ubXMfQoXdCgEByaq8DE/+CmdiXLrmhMoOssb3meejagaxXJCYy89ZZuwqQsa?=
 =?us-ascii?Q?MlDYsss6sq5B+XQ8Qxt0qVyWf9Hl6hG9MhomvhqfQNkgY6HGR7RWNBAibFGN?=
 =?us-ascii?Q?pOaUyWHZMCXialEzXKaFycn1CobtW4yvTIeaVTXZfpqn91PlnaMqShmsiNIC?=
 =?us-ascii?Q?S8MSdDysVaQeRzst8BuL73RtAoCwTbM/Qvy3LV9pc+7U1K4fl8rchfk1sMLi?=
 =?us-ascii?Q?7VhRfiscKLda8IBlI/6EHOlpg765AR9mOGKAFoccl3NGE6gCM8Z0AdKqz7Vu?=
 =?us-ascii?Q?F60ikD76Fqfl7lJLqaS5rGsGRDAwFy3DsS5ZzO5/bE6Ou1FzfB+ZP9x6CbNk?=
 =?us-ascii?Q?P8Tnoj91X8a7aXE8rADuRlboEy8NwyV6S7tjxyfV1d1AlRe9yVYBYMUYGrH+?=
 =?us-ascii?Q?jnhP41ZT/I7TlNrMlE11GxHOhJ1E/w8a6ozndUiZnGpnxBWwb/EadlPwQQ1/?=
 =?us-ascii?Q?G9+l5Tca09pOFfoiK46Bv6938/T3IZoFNTsEsPsKLFb9IFJEK8qA31bJRYWQ?=
 =?us-ascii?Q?nCMBWA20R+xINirjWVKoKzZYxntCNM6kp68lVdJeyhc5U9I1l6eDirbPuSnf?=
 =?us-ascii?Q?nGjINfPaeRfXSi065+9jDdpDEGNpULlWs4I5xST8w/SayUze9qdsV4CktlPN?=
 =?us-ascii?Q?nzsoAX3gK5U97cC2s/1cvs/blsCw+CQYW9TvJLduEOaBH+r81onYu1RslXJd?=
 =?us-ascii?Q?Cx6XW4gaKyXrbtnilKnAKAyiODWD7BRi+IiyPi/V0119WR4tYl/FzQJ+hN8N?=
 =?us-ascii?Q?jxPaOtF6bPWiYR7cnbCXAODQLf+Fo3ZaRwn2Ejh7J8HXScJCLuXC6mqw44oS?=
 =?us-ascii?Q?OWdpi5FZ5dIDsESTCZaCvpWPnnWSwoqAW++/2wpSwRXmvzGw7O7SsEd+2ELZ?=
 =?us-ascii?Q?o6sZ/AWJJqjHJRoRSLCSSvWwRq8BYZlLxqH4XiB3ohHadhVKhVvcdEyTPcFP?=
 =?us-ascii?Q?PMEnbm091+JpCqh8EFNIUZykYoxu6/cUTsYwzkM9uNBn1imnjK6+0e8195sM?=
 =?us-ascii?Q?66cPcXM+FKFR+Ra7epQyFA/GGioWR8Sthai7yH80hYsiO48/A/gbGGhwuXiY?=
 =?us-ascii?Q?/uUgwwG3Og=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 298043bd-d871-42ee-43cf-08da221f4713
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 16:11:35.9059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kZnK965oB4tj+xon+2ht3ZqjTzgDRt6nmRuNC/6EHQ4s9mUwnCeXKYrlcq95DUTTYF0n0uNUWcY0VvGehbvuYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6692

On 19.04.2022 16:56, Juergen Gross wrote:
> On 19.04.22 16:51, Andrew Cooper wrote:
>> On 19/04/2022 14:52, Juergen Gross wrote:
>>> Today iommu_do_domctl() is being called from arch_do_domctl() in the
>>> "default:" case of a switch statement. This has led already to crashes
>>> due to unvalidated parameters.
>>>
>>> Fix that by moving the call of iommu_do_domctl() to the main switch
>>> statement of do_domctl().
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> ---
>>> Another possibility would even be to merge iommu_do_domctl() completely
>>> into do_domctl(), but I wanted to start with a less intrusive variant.
>>> V3:
>>> - new patch
>>
>> I definitely prefer this approach, thanks.=C2=A0 In addition to being
>> clearer, it's also faster because there isn't a long line of "do you
>> understand this subop?" calls when we know exactly what it is.
>>
>> However, I think we need stub for the !HAS_PASSTHROUGH case now that it
>> is being called from common code.
>=20
> Okay, I'll add it. Jan, are you fine with a stub?

Sure.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 16:31:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 16:31:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308376.524101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqlW-00009c-D4; Tue, 19 Apr 2022 16:31:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308376.524101; Tue, 19 Apr 2022 16:31:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngqlW-00009V-A4; Tue, 19 Apr 2022 16:31:46 +0000
Received: by outflank-mailman (input) for mailman id 308376;
 Tue, 19 Apr 2022 16:31:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hN/8=U5=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1ngqlV-00009P-0o
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 16:31:45 +0000
Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com
 [2607:f8b0:4864:20::1029])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3210c679-bffe-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 18:31:43 +0200 (CEST)
Received: by mail-pj1-x1029.google.com with SMTP id
 n11-20020a17090a73cb00b001d1d3a7116bso2010146pjk.0
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 09:31:43 -0700 (PDT)
Received: from [192.168.0.18] ([118.33.58.98])
 by smtp.gmail.com with ESMTPSA id
 y9-20020aa78f29000000b005098201d2f5sm16748313pfr.205.2022.04.19.09.31.40
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 09:31:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3210c679-bffe-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:to:references:from
         :cc:in-reply-to:content-transfer-encoding;
        bh=Aj4BcQWJTSiyqk48xgH1z3685F70s75Z0C6GtdN4G5Q=;
        b=eYuG73vkbejEY44RC3Il2Ny6MkZQ6xjfKvV4U/YDJA23Hz9UGUuDeGagFzX9ok9FR1
         qmc4LPLM5eaHoU48NPt6xQa5u0ImidfayzC8/mMJmfvOP0Bypy178F8CWuRYDjY6FRVv
         JWD2vQFnS/04fayOOCWMT1h4FirJ+Jnp2BO1FLqxVdRvyB83N2R0UYzkaqH7VIVULRUc
         32xS/PLinvjV7TbqMPIAM2E6QvKiCHvr/S7DJNMYOmt/U4SqGp1jdI3Kmt/hW8P1RKcE
         lCjQwpN3zgzlgZglUw87rj3EyDSQWXIdZBFnnOFBesy+hbRoqM6gHoT/EyNddFPGTDo3
         onBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :to:references:from:cc:in-reply-to:content-transfer-encoding;
        bh=Aj4BcQWJTSiyqk48xgH1z3685F70s75Z0C6GtdN4G5Q=;
        b=eKe3AoJwD9/0lzQrM5CXXAa/V/z9dTLsh/7f7bURyJMiEm6mHLiI2cPu26DnsnkcHF
         SAaAXQ0yWHVXf61b/bx6uZ+Os/Vtftbpt60mAsWTgGq538m9xyHamj/PvR7SZCujvpT1
         ouTclDCWR0/mqZFvvBOzj2mktisovia7f1J9eRytMv8M0B/YYcsvj4OVik3L/c5NdvIR
         t/rm7zgjYjdf1FLkdGHwxVt+IWj7aLJCk22JRU/CamOh56PJo612So0qCW1lrI4iSQB6
         g8bm+A2b3bFmF29PHiOaIY2hGY1QNXEjs6ZqC5AaNMnnEbVZUs+r3pNZxd3VQolI6lc8
         5qrw==
X-Gm-Message-State: AOAM530Mdbhf8VBGBz66G5NKsKjpGBnc/ehZE0yPLOwl6T8nGyTgMcl/
	UexD+NR1YVEaOoWcdhSyqWJ7O8SHRGaeQgXD
X-Google-Smtp-Source: ABdhPJzTPOdGV9EsO53VElVcS7h/WrT1cWT7NVT1TlZtmN+6o2+mqObgdG3DmQUoFsQ3h7bDOb29Vw==
X-Received: by 2002:a17:90a:8d82:b0:1d2:cd8c:ed6 with SMTP id d2-20020a17090a8d8200b001d2cd8c0ed6mr5176505pjo.63.1650385901861;
        Tue, 19 Apr 2022 09:31:41 -0700 (PDT)
Message-ID: <925421bc-680b-df61-5a75-681d752c4820@gmail.com>
Date: Wed, 20 Apr 2022 01:31:38 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] xen/arm: silence ambiguous integer casting warning error
To: Julien Grall <julien.grall.oss@gmail.com>
References: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
 <CAJ=z9a37_y3B4aAfiK5C-bHJYyWqCo0+g+jB6cdDCmOzLuXLJw@mail.gmail.com>
From: Paran Lee <p4ranlee@gmail.com>
Cc: austindh.kim@gmail.com, xen-devel@lists.xenproject.org
In-Reply-To: <CAJ=z9a37_y3B4aAfiK5C-bHJYyWqCo0+g+jB6cdDCmOzLuXLJw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi, Julien Grall.

Thank you for checking it out. I'm sorry I forgot to attach the make log
as well.

My build configuration (include CFLGAS)

export ARCH=arm64
export XEN_TARGET_ARCH=arm64
export $(dpkg-architecture -aarm64);
export CROSS_COMPILE=aarch64-linux-gnu-
export CFLAGS="-g -Wall -Wextra -Wno-unused-parameter"

And i did     make dist-xen

my arm64 compiler information are here.
gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)

~/xen$ aarch64-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=aarch64-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc-cross/aarch64-linux-gnu/9/lto-wrapper
Target: aarch64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu
9.4.0-1ubuntu1~20.04.1'
--with-bugurl=file:///usr/share/doc/gcc-9/README.Bugs
--enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,gm2 --prefix=/usr
--with-gcc-major-version-only --program-suffix=-9 --enable-shared
--enable-linker-build-id --libexecdir=/usr/lib
--without-included-gettext --enable-threads=posix --libdir=/usr/lib
--enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-libstdcxx-time=yes
--with-default-libstdcxx-abi=new --enable-gnu-unique-object
--disable-libquadmath --disable-libquadmath-support --enable-plugin
--enable-default-pie --with-system-zlib --without-target-system-zlib
--enable-libpth-m2 --enable-multiarch --enable-fix-cortex-a53-843419
--disable-werror --enable-checking=release --build=x86_64-linux-gnu
--host=x86_64-linux-gnu --target=aarch64-linux-gnu
--program-prefix=aarch64-linux-gnu-
--includedir=/usr/aarch64-linux-gnu/include
Thread model: posix
gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)

In arch/arm/gic-v3.c files.

arch/arm/gic-v3.c: In function ‘gicv3_compute_target_list’:
arch/arm/gic-v3.c:926:17: error: comparison of integer expressions of
different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
  926 |     while ( cpu < nr_cpu_ids )
      |                 ^
arch/arm/gic-v3.c:936:18: error: comparison of integer expressions of
different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
  936 |         if ( cpu == nr_cpu_ids )
      |                  ^~                           ^

In arch/arm/setup.c files.

arch/arm/setup.c: In function ‘start_xen’:
./include/xen/cpumask.h:374:13: error: comparison of integer expressions
of different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
  374 |       (cpu) < nr_cpu_ids;  \
      |             ^
./include/xen/cpumask.h:459:36: note: in expansion of macro ‘for_each_cpu’
  459 | #define for_each_present_cpu(cpu)  for_each_cpu(cpu,
&cpu_present_map)
      |                                    ^~~~~~~~~~~~
arch/arm/setup.c:989:5: note: in expansion of macro ‘for_each_present_cpu’
  989 |     for_each_present_cpu ( i )
      |     ^~~~~~~~~~~~~~~~~~~~             ^

Thank you!

2022-04-20 오전 12:50에 Julien Grall 이(가) 쓴 글:
> Hi,
> 
> On Tue, 19 Apr 2022, 15:41 Paran Lee, <p4ranlee@gmail.com> wrote:
> 
>> GCC with "-g -Wall -Wextra" option throws warning message as below:
> 
> 
> Which version of the compiler? Also you specify the exact cflags, did you
> tweak Xen?
> 
> 
>> error: comparison of integer expressions of different signedness:
>>  ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>>
> 
> GCC should give you a line/file. Can you provide it?
> 
> Cheers,
> 
> 
>> Silence the warning by correcting the integer type.
>>
>> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
>> ---
>>  xen/arch/arm/gic-v3.c | 5 +++--
>>  xen/arch/arm/setup.c  | 2 +-
>>  2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>> index 3c472ed768..81ac25f528 100644
>> --- a/xen/arch/arm/gic-v3.c
>> +++ b/xen/arch/arm/gic-v3.c
>> @@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)
>>      isb();
>>  }
>>
>> -static u16 gicv3_compute_target_list(int *base_cpu, const struct cpumask
>> *mask,
>> +static u16 gicv3_compute_target_list(unsigned int *base_cpu,
>> +                                     const struct cpumask *mask,
>>                                       uint64_t cluster_id)
>>  {
>>      int cpu = *base_cpu;
>> @@ -953,7 +954,7 @@ out:
>>
>>  static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t
>> *cpumask)
>>  {
>> -    int cpu = 0;
>> +    unsigned int cpu = 0;
>>      uint64_t val;
>>
>>      for_each_cpu(cpu, cpumask)
>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>> index d5d0792ed4..5ab2aaecaf 100644
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -862,7 +862,7 @@ void __init start_xen(unsigned long boot_phys_offset,
>>                        unsigned long fdt_paddr)
>>  {
>>      size_t fdt_size;
>> -    int cpus, i;
>> +    unsigned int cpus, i;
>>      const char *cmdline;
>>      struct bootmodule *xen_bootmodule;
>>      struct domain *d;
>> --
>> 2.25.1
>>
>>
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 16:51:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 16:51:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308396.524112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngr43-0002pd-00; Tue, 19 Apr 2022 16:50:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308396.524112; Tue, 19 Apr 2022 16:50:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngr42-0002pW-TI; Tue, 19 Apr 2022 16:50:54 +0000
Received: by outflank-mailman (input) for mailman id 308396;
 Tue, 19 Apr 2022 16:50:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WtTZ=U5=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1ngr41-0002os-95
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 16:50:53 +0000
Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com
 [2a00:1450:4864:20::32f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df427cb0-c000-11ec-8fbf-03012f2f19d4;
 Tue, 19 Apr 2022 18:50:52 +0200 (CEST)
Received: by mail-wm1-x32f.google.com with SMTP id r19so5178426wmq.0
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 09:50:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df427cb0-c000-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=nSgQIztKzemVABHDhvN9/cvAvjXWOT7vnGgR2KGrhZc=;
        b=Vz/X9y6g+dewkm+Voqh58Lkg2H+XlDW4De4st0pRvhXfy/SnD9TXolzEcKlmde31+F
         Ik92791NZ9ug1Sz7JuvBM4dfw0XGkRGBiVmiCUkfiF+IoqA79BHClAzyRPWezm7K0SMY
         ulnX7hxcvn29uei8TkmyB/6oAmimL+tklkd9j+0R6JyEko7hUA+yHAxZRAGoBCqIj/4m
         fdH4dwJwcWRwae6i74iLXpdd/F5dR8XykBHQTD+3HWCcW29DzSc8Mc9liCjiMrWgaox2
         xenQeLjrfqv5vQHatEFfEPkJqxHAhZWfvrLCy69mV4CknHkPKvDhrOp9BXpq5byMcluD
         S8Sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=nSgQIztKzemVABHDhvN9/cvAvjXWOT7vnGgR2KGrhZc=;
        b=fZYazJ6wpx4wwX2AZ5JJG1Z++emBZwBWjGmRenbLqkF0yquvWeHGw5UsnTIfwS7GaF
         5vMxD0GkrAuRpQrUgSsnXl0cO5ow8Bnh+okCPXRmepQe7SZZmtFCu4AxsMftbrcQeLIW
         MhuwyS2EDo9GOsHuQuoihlmcaTFjIy0DeKCVsV31+3eJhttaJRC8OGmNUy/b9PxQxQtk
         fxVVTU9R55Of9LZNWvM+pXHip9YzkO25bYnJbIB/EJPWDAoO396sEniu+kEAG9EnLWSX
         Ng47+FoY+d2Ap36768oBpk52Es5fopYrNxpfU3bl4z6OR/tQowMIXgDZU4kV8TW4RV/P
         /e4g==
X-Gm-Message-State: AOAM531xku64wsEizwFnJ/RBBLoRxT+aF0k7jKJbcxAXCKBu+GaYJPl7
	ZDLTHUH97bQjtYrcdjI3muEBzXgB5OiKYQhlAWmACw9d
X-Google-Smtp-Source: ABdhPJxPNwqwrI/XvQgId0ytCG53gbW9GA6npzpeeiFiUh6kwJY8yX1nyylye3YDfIXgy4zntFk5W4yfK3UUxU+VU68=
X-Received: by 2002:a1c:2947:0:b0:391:8d5a:69b7 with SMTP id
 p68-20020a1c2947000000b003918d5a69b7mr16987884wmp.113.1650387051591; Tue, 19
 Apr 2022 09:50:51 -0700 (PDT)
MIME-Version: 1.0
References: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
 <CAJ=z9a37_y3B4aAfiK5C-bHJYyWqCo0+g+jB6cdDCmOzLuXLJw@mail.gmail.com> <925421bc-680b-df61-5a75-681d752c4820@gmail.com>
In-Reply-To: <925421bc-680b-df61-5a75-681d752c4820@gmail.com>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Tue, 19 Apr 2022 16:50:39 +0000
Message-ID: <CAJ=z9a025PGxvdh-Yhwf342B7rVq9kZ8obgmxQmOtG8Kvu70pQ@mail.gmail.com>
Subject: Re: [PATCH] xen/arm: silence ambiguous integer casting warning error
To: Paran Lee <p4ranlee@gmail.com>
Cc: austindh.kim@gmail.com, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: multipart/alternative; boundary="000000000000f3bc8005dd04ad8c"

--000000000000f3bc8005dd04ad8c
Content-Type: text/plain; charset="UTF-8"

On Tue, 19 Apr 2022, 16:31 Paran Lee, <p4ranlee@gmail.com> wrote:

> Hi, Julien Grall.
>
> Thank you for checking it out. I'm sorry I forgot to attach the make log
> as well.
>

Thanks for the logs!



> My build configuration (include CFLGAS)
>
> export ARCH=arm64
> export XEN_TARGET_ARCH=arm64
> export $(dpkg-architecture -aarm64);
> export CROSS_COMPILE=aarch64-linux-gnu-
> export CFLAGS="-g -Wall -Wextra -Wno-unused-parameter"
>

May I ask why you are modifying the flags? What's your end goal?

There reason I am asking is a lot of the helper for cpumask are using
signed int. So switching only the local variables to unsigned sounds wrong
to me.

Cheers,

--000000000000f3bc8005dd04ad8c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Tue, 19 Apr 2022, 16:31 Paran Lee, &lt;<a href=3D"m=
ailto:p4ranlee@gmail.com">p4ranlee@gmail.com</a>&gt; wrote:<br></div><block=
quote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc=
 solid;padding-left:1ex">Hi, Julien Grall.<br>
<br>
Thank you for checking it out. I&#39;m sorry I forgot to attach the make lo=
g<br>
as well.<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=
=3D"auto">Thanks for the logs!</div><div dir=3D"auto"><br></div><div dir=3D=
"auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;=
padding-left:1ex">
<br>
My build configuration (include CFLGAS)<br>
<br>
export ARCH=3Darm64<br>
export XEN_TARGET_ARCH=3Darm64<br>
export $(dpkg-architecture -aarm64);<br>
export CROSS_COMPILE=3Daarch64-linux-gnu-<br>
export CFLAGS=3D&quot;-g -Wall -Wextra -Wno-unused-parameter&quot;<br></blo=
ckquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">May I ask=
 why you are modifying the flags? What&#39;s your end goal?</div><div dir=
=3D"auto"><br></div><div dir=3D"auto">There reason I am asking is a lot of =
the helper for cpumask are using signed int. So switching only the local va=
riables to unsigned sounds wrong to me.</div><div dir=3D"auto"><br></div><d=
iv dir=3D"auto">Cheers,</div></div>

--000000000000f3bc8005dd04ad8c--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 17:10:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 17:10:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308401.524124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrMU-0004kS-LT; Tue, 19 Apr 2022 17:09:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308401.524124; Tue, 19 Apr 2022 17:09:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrMU-0004kL-Hp; Tue, 19 Apr 2022 17:09:58 +0000
Received: by outflank-mailman (input) for mailman id 308401;
 Tue, 19 Apr 2022 17:09:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hN/8=U5=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1ngrMS-0004jw-P9
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 17:09:56 +0000
Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com
 [2607:f8b0:4864:20::62d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 885da80b-c003-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 19:09:55 +0200 (CEST)
Received: by mail-pl1-x62d.google.com with SMTP id c23so16424786plo.0
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 10:09:55 -0700 (PDT)
Received: from [192.168.0.18] ([118.33.58.98])
 by smtp.gmail.com with ESMTPSA id
 p1-20020a17090a0e4100b001ce188720e5sm16340158pja.53.2022.04.19.10.09.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 10:09:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 885da80b-c003-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:from:to:references
         :cc:in-reply-to:content-transfer-encoding;
        bh=DCzhmz/4cQQnX73E5Ilu9RqLgmLe/yGX4F7Eamu7Pjo=;
        b=eEQ0N8O3pMdkTqVMlAUkrzUmoibgDg/s9IPKbkpu5a/IYGRJuKIPEoiKGykUz4ZjKd
         y4oOzwXmBUWmeRpvhSPk6N06Qp+l3nS9ER3QYWBQeneNpTb0hQk79B5z1/bQR9FJ/SdE
         8JRWN7Yy2r3TMw68BbeB9r2JAIKv/voHGFoMm6JCux/svs2OjANRnVW7ng4IkRKhMZ2G
         LxjsupZn4C1kHcIcRvjNdgGVO/3OOGqg2kCdRPGUNAzJMTQwG5xO26sfK4JGDsxmbtKC
         wfMFaSUPPEGToLMZGTEVps7nQa8S/7FwMX/yG0KVrsD/VuZnvHHOPdTDXZLTeflS79uH
         EfKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :from:to:references:cc:in-reply-to:content-transfer-encoding;
        bh=DCzhmz/4cQQnX73E5Ilu9RqLgmLe/yGX4F7Eamu7Pjo=;
        b=zIbM14kopLs4udmkTwBCet/WQW8qEEFUm8nwzu7uMpzl/g0gC/OYm+iARrwUvZj1Rg
         gVkkXi1IOX/Jyjkmk11Ytu020oAZICGHGRXucm8QB7xoHbPSH867fW+DBYDOvVxOgh6p
         7Medsy7OtQjyl7F8CuxO/M86wUFcodKrr9r1eI0njEtGK0az2OZirfzC3QBhDQYOTumK
         yNTV25iMmL3j/BX6+5Kf53h6WnE0T8n8E5ZVuAkhpfGryMpFS0DSu3Cx1aVk/WF/Yd83
         do++QYDjSyPXtsAplezdzTpuTocp7JqgPRDKOTA+OEZkw51k1UcFhFanTvZruAr9oXbk
         0XeA==
X-Gm-Message-State: AOAM5329Mizf7H9TPFImMHgiP2nWIlU3rePzyjQLSO46yhB9mMD/uSGI
	LFSxukUxfuMGhsg/X4RLBP451vR4p8Syiu7x
X-Google-Smtp-Source: ABdhPJwmqT0urknfrmRMpr0tvSlbOUnqB0juHtH9Hl7WVLML8Jh7x5hgfX+TRtHY+32FdFC1g9qtDQ==
X-Received: by 2002:a17:903:2c7:b0:158:2f26:6016 with SMTP id s7-20020a17090302c700b001582f266016mr16849919plk.154.1650388193945;
        Tue, 19 Apr 2022 10:09:53 -0700 (PDT)
Message-ID: <b8a0feed-1dde-3b36-646e-1e5413de8395@gmail.com>
Date: Wed, 20 Apr 2022 02:09:50 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] xen/arm: silence ambiguous integer casting warning error
From: Paran Lee <p4ranlee@gmail.com>
To: Julien Grall <julien.grall.oss@gmail.com>
References: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
 <CAJ=z9a37_y3B4aAfiK5C-bHJYyWqCo0+g+jB6cdDCmOzLuXLJw@mail.gmail.com>
 <925421bc-680b-df61-5a75-681d752c4820@gmail.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
In-Reply-To: <925421bc-680b-df61-5a75-681d752c4820@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Debugging with GDB from head.S with QEMU runtime was very convenient for
analysis(linux). so I have trying it in Xen. As I built it.

Wouldn't it be helpful if I fixed the code little by little?

2022-04-20 오전 1:31에 Paran Lee 이(가) 쓴 글:
> Hi, Julien Grall.
> 
> Thank you for checking it out. I'm sorry I forgot to attach the make log
> as well.
> 
> My build configuration (include CFLGAS)
> 
> export ARCH=arm64
> export XEN_TARGET_ARCH=arm64
> export $(dpkg-architecture -aarm64);
> export CROSS_COMPILE=aarch64-linux-gnu-
> export CFLAGS="-g -Wall -Wextra -Wno-unused-parameter"
> 
> And i did     make dist-xen
> 
> my arm64 compiler information are here.
> gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
> 
> ~/xen$ aarch64-linux-gnu-gcc -v
> Using built-in specs.
> COLLECT_GCC=aarch64-linux-gnu-gcc
> COLLECT_LTO_WRAPPER=/usr/lib/gcc-cross/aarch64-linux-gnu/9/lto-wrapper
> Target: aarch64-linux-gnu
> Configured with: ../src/configure -v --with-pkgversion='Ubuntu
> 9.4.0-1ubuntu1~20.04.1'
> --with-bugurl=file:///usr/share/doc/gcc-9/README.Bugs
> --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,gm2 --prefix=/usr
> --with-gcc-major-version-only --program-suffix=-9 --enable-shared
> --enable-linker-build-id --libexecdir=/usr/lib
> --without-included-gettext --enable-threads=posix --libdir=/usr/lib
> --enable-nls --with-sysroot=/ --enable-clocale=gnu
> --enable-libstdcxx-debug --enable-libstdcxx-time=yes
> --with-default-libstdcxx-abi=new --enable-gnu-unique-object
> --disable-libquadmath --disable-libquadmath-support --enable-plugin
> --enable-default-pie --with-system-zlib --without-target-system-zlib
> --enable-libpth-m2 --enable-multiarch --enable-fix-cortex-a53-843419
> --disable-werror --enable-checking=release --build=x86_64-linux-gnu
> --host=x86_64-linux-gnu --target=aarch64-linux-gnu
> --program-prefix=aarch64-linux-gnu-
> --includedir=/usr/aarch64-linux-gnu/include
> Thread model: posix
> gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
> 
> In arch/arm/gic-v3.c files.
> 
> arch/arm/gic-v3.c: In function ‘gicv3_compute_target_list’:
> arch/arm/gic-v3.c:926:17: error: comparison of integer expressions of
> different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>   926 |     while ( cpu < nr_cpu_ids )
>       |                 ^
> arch/arm/gic-v3.c:936:18: error: comparison of integer expressions of
> different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>   936 |         if ( cpu == nr_cpu_ids )
>       |                  ^~                           ^
> 
> In arch/arm/setup.c files.
> 
> arch/arm/setup.c: In function ‘start_xen’:
> ./include/xen/cpumask.h:374:13: error: comparison of integer expressions
> of different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>   374 |       (cpu) < nr_cpu_ids;  \
>       |             ^
> ./include/xen/cpumask.h:459:36: note: in expansion of macro ‘for_each_cpu’
>   459 | #define for_each_present_cpu(cpu)  for_each_cpu(cpu,
> &cpu_present_map)
>       |                                    ^~~~~~~~~~~~
> arch/arm/setup.c:989:5: note: in expansion of macro ‘for_each_present_cpu’
>   989 |     for_each_present_cpu ( i )
>       |     ^~~~~~~~~~~~~~~~~~~~             ^
> 
> Thank you!
> 
> 2022-04-20 오전 12:50에 Julien Grall 이(가) 쓴 글:
>> Hi,
>>
>> On Tue, 19 Apr 2022, 15:41 Paran Lee, <p4ranlee@gmail.com> wrote:
>>
>>> GCC with "-g -Wall -Wextra" option throws warning message as below:
>>
>>
>> Which version of the compiler? Also you specify the exact cflags, did you
>> tweak Xen?
>>
>>
>>> error: comparison of integer expressions of different signedness:
>>>  ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>>>
>>
>> GCC should give you a line/file. Can you provide it?
>>
>> Cheers,
>>
>>
>>> Silence the warning by correcting the integer type.
>>>
>>> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
>>> ---
>>>  xen/arch/arm/gic-v3.c | 5 +++--
>>>  xen/arch/arm/setup.c  | 2 +-
>>>  2 files changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>>> index 3c472ed768..81ac25f528 100644
>>> --- a/xen/arch/arm/gic-v3.c
>>> +++ b/xen/arch/arm/gic-v3.c
>>> @@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)
>>>      isb();
>>>  }
>>>
>>> -static u16 gicv3_compute_target_list(int *base_cpu, const struct cpumask
>>> *mask,
>>> +static u16 gicv3_compute_target_list(unsigned int *base_cpu,
>>> +                                     const struct cpumask *mask,
>>>                                       uint64_t cluster_id)
>>>  {
>>>      int cpu = *base_cpu;
>>> @@ -953,7 +954,7 @@ out:
>>>
>>>  static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t
>>> *cpumask)
>>>  {
>>> -    int cpu = 0;
>>> +    unsigned int cpu = 0;
>>>      uint64_t val;
>>>
>>>      for_each_cpu(cpu, cpumask)
>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>>> index d5d0792ed4..5ab2aaecaf 100644
>>> --- a/xen/arch/arm/setup.c
>>> +++ b/xen/arch/arm/setup.c
>>> @@ -862,7 +862,7 @@ void __init start_xen(unsigned long boot_phys_offset,
>>>                        unsigned long fdt_paddr)
>>>  {
>>>      size_t fdt_size;
>>> -    int cpus, i;
>>> +    unsigned int cpus, i;
>>>      const char *cmdline;
>>>      struct bootmodule *xen_bootmodule;
>>>      struct domain *d;
>>> --
>>> 2.25.1
>>>
>>>
>>


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 17:11:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 17:11:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308407.524143 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrNm-00068K-42; Tue, 19 Apr 2022 17:11:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308407.524143; Tue, 19 Apr 2022 17:11:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrNl-00068D-V1; Tue, 19 Apr 2022 17:11:17 +0000
Received: by outflank-mailman (input) for mailman id 308407;
 Tue, 19 Apr 2022 17:11:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tr1R=U5=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ngrNl-00067p-Fn
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 17:11:17 +0000
Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com
 [2a00:1450:4864:20::231])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b9106021-c003-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 19:11:16 +0200 (CEST)
Received: by mail-lj1-x231.google.com with SMTP id o16so21347744ljp.3
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 10:11:16 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 s10-20020a19ad4a000000b0044826a25a2esm1559012lfd.292.2022.04.19.10.11.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 10:11:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9106021-c003-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=rxPYmQa0Egn1mqp1mSydb9Om/nZ3dlYXqwZ9ZJ/h6io=;
        b=dyWdHQ6Lc1rlJ6pELKH/xYiaKPOXoQ/YcCodyE8U8e8bJBI77zlMVC+Ki6HcNSpIeZ
         hJhP6IRzUA4XCB0CBu49/DWNC2kDBRY6Pb2V4fXowbHziawlTEuj1pobxjq4/74XRzHZ
         P04N+J4pxJESMwwUZ/O2VvJMUiPQiB31BKyfGR5KU7rbwgKt2kpcI8QRn/jUpuEzNlQZ
         BF26p8IN65HWr/A4mTBhF0ZoyuOAyjgP2gt0p0gmutZfrzGiFS/zwsWUARmd/Tsv9Yab
         gn1QKQyQzIc/sGsGr4aW/kVp0yTL+K/d22SwqK1Urv8YmJlhqe2Ogkij7yMTxIpxpxDV
         wp1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=rxPYmQa0Egn1mqp1mSydb9Om/nZ3dlYXqwZ9ZJ/h6io=;
        b=RC7Ap+HJqCo5G/mgBlp3Xujk0yj6WMb4dMNOcKUKG81xojg0kTRqpW3Qcv529KdTxJ
         X066Uvt0wy8KUZWlifLK1m6hfFboeg3dCNsP378P1tNCdbkOyBQ7EEUvmXAs0Zh+fjQY
         vqINgtzgdH1BDe1Dv5gl+sAeo3/zombYqkd3Iq8kS7zZ7B0S1Xdv6ucP6s+8SlcnP4k5
         CAXihGrvQDySIz/JD1W1kago2EHg1eLylZPt49t+79hoGIg34wFTAI7/X4KDkV7sJnJt
         qKB6qFZMCDtptWQBL7iNEoXcnW790+O0K4jIzaBadMHnhg2/tX/dAY6+xgadQu/Je/W6
         qwpA==
X-Gm-Message-State: AOAM531SpZcvaymMgKNkHd+nNCb526ujymZoVmEr4aeS07LOlA67TEjQ
	9dkHSr79P1j698A+fYknPDc=
X-Google-Smtp-Source: ABdhPJwgqbLh/VuZRiEY2WTuxX7nyZVaNDxdTGSqSrhHfcljZTAensAc3R99HsPQkc5LdCgC/gCgEw==
X-Received: by 2002:a2e:9c43:0:b0:24b:469:2bb6 with SMTP id t3-20020a2e9c43000000b0024b04692bb6mr11327140ljj.248.1650388274392;
        Tue, 19 Apr 2022 10:11:14 -0700 (PDT)
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
To: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
 <YlpdBHKT1bYzZe2e@infradead.org>
 <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
 <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop>
 <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com>
 <b68163be-ad43-7773-22ff-e83191886626@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <5afb9e61-4164-9cc9-278a-911fc21f4f6c@gmail.com>
Date: Tue, 19 Apr 2022 20:11:12 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <b68163be-ad43-7773-22ff-e83191886626@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hello Stefano, Juergen


On 19.04.22 17:48, Juergen Gross wrote:
> On 19.04.22 14:17, Oleksandr wrote:
>>
>> Hello Stefano, Juergen
>>
>>
>> On 18.04.22 22:11, Stefano Stabellini wrote:
>>> On Mon, 18 Apr 2022, Oleksandr wrote:
>>>> On 16.04.22 09:07, Christoph Hellwig wrote:
>>>>
>>>> Hello Christoph
>>>>
>>>>> On Fri, Apr 15, 2022 at 03:02:45PM -0700, Stefano Stabellini wrote:
>>>>>> This makes sense overall. Considering that the swiotlb-xen case 
>>>>>> and the
>>>>>> virtio case are mutually exclusive, I would write it like this:
>>>>> Curious question:  Why can't the same grant scheme also be used for
>>>>> non-virtio devices?  I really hate having virtio hooks in the arch
>>>>> dma code.  Why can't Xen just say in DT/ACPI that grants can be used
>>>>> for a given device?
>>> [...]
>>>
>>>> This patch series tries to make things work with "virtio" devices 
>>>> in Xen
>>>> system without introducing any modifications to code under 
>>>> drivers/virtio.
>>>
>>> Actually, I think Christoph has a point.
>>>
>>> There is nothing inherently virtio specific in this patch series or in
>>> the "xen,dev-domid" device tree binding.
>>
>>
>> Although the main intention of this series was to enable using virtio 
>> devices in Xen guests, I agree that nothing in new DMA ops layer 
>> (xen-virtio.c) is virtio specific (at least at the moment). Regarding 
>> the whole patch series I am not quite sure, as it uses 
>> arch_has_restricted_virtio_memory_access(). >
>>>   Assuming a given device is
>>> emulated by a Xen backend, it could be used with grants as well.
>>>
>>> For instance, we could provide an emulated e1000 NIC with a
>>> "xen,dev-domid" property in device tree. Linux could use grants with it
>>> and the backend could map the grants. It would work the same way as
>>> virtio-net/block/etc. Passthrough devices wouldn't have the
>>> "xen,dev-domid" property, so no problems.
>>>
>>> So I think we could easily generalize this work and expand it to any
>>> device. We just need to hook on the "xen,dev-domid" device tree
>>> property.
>>>
>>> I think it is just a matter of:
>>> - remove the "virtio,mmio" check from xen_is_virtio_device
>>> - rename xen_is_virtio_device to something more generic, like
>>>    xen_is_grants_device
>
> xen_is_grants_dma_device, please. Normal Xen PV devices are covered by
> grants, too, and I'd like to avoid the confusion arising from this.


yes, this definitely makes sense as we need to distinguish


>
>
>>> - rename xen_virtio_setup_dma_ops to something more generic, like
>>>    xen_grants_setup_dma_ops
>>>
>>> And that's pretty much it.
>>
>> + likely renaming everything in that patch series not to mention 
>> virtio (mostly related to xen-virtio.c internals).
>>
>>
>> Stefano, thank you for clarifying Christoph's point.
>>
>> Well, I am not against going this direction. Could we please make a 
>> decision on this? @Juergen, what is your opinion?
>
> Yes, why not.


ok, thank you for confirming.


>
>
> Maybe rename xen-virtio.c to grant-dma.c?


Personally I don't mind.


>
> I'd keep the XEN_VIRTIO related config option, as this will be the 
> normal use
> case. grant-dma.c should be covered by a new hidden config option 
> XEN_GRANT_DMA
> selected by XEN_VIRTIO.


I got it, ok


>
>
> CONFIG_XEN_VIRTIO should still guard 
> xen_has_restricted_virtio_memory_access().


ok


So a few questions to clarify:

1. What is the best place to keep "xen,dev-domid" binding's description 
now? I think that proposed in current series place 
(Documentation/devicetree/bindings/virtio/) is not good fit now.

2. I assume the logic in the current patch will remain the same, I mean 
we will still assign Xen grant DMA ops from xen_setup_dma_ops() here?


>
>
>
> Juergen

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 17:15:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 17:15:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308414.524153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrS7-00071V-OA; Tue, 19 Apr 2022 17:15:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308414.524153; Tue, 19 Apr 2022 17:15:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrS7-00071O-L7; Tue, 19 Apr 2022 17:15:47 +0000
Received: by outflank-mailman (input) for mailman id 308414;
 Tue, 19 Apr 2022 17:15:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tr1R=U5=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ngrS6-00071I-LD
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 17:15:46 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59795740-c004-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 19:15:45 +0200 (CEST)
Received: by mail-lf1-x136.google.com with SMTP id o2so30515562lfu.13
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 10:15:45 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 r9-20020a2e8e29000000b0024da2131ed9sm1464256ljk.100.2022.04.19.10.15.44
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 19 Apr 2022 10:15:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59795740-c004-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=IEIkHtF9OK4EglJtk5NkkYIfQgmSypjXF46RNxhi5RE=;
        b=k6aGnfX2Pqy0GUbLeB/Z/EafhQc/cEI4DgdMg01n/f7SaY6qbAsd2tgpfYAMNiB8S+
         zvTo4soPr5cUn8WL8RhmsdtZBPrQZsoaRkGtTUyT6u5lGSaeXPknFgiX4HSzMoLu3ET3
         1P7P/vQNCwoRub09Nf7gm7d0YDtlbHhWHToLVP614inbkxO/FOdwX9kdBd4oTJh2qIMQ
         5TxxGXvIFyE/yOuYUJucw5lqRbSNGsmLds3qQa4oqizaf39wYcWS52TTp6jwY676aQBl
         jWdldFHHjki/k98G13iz32BG03vGQ4uAS83NceJrRwhBSxJX4+jIsQZIv58A8qeyO2qt
         c3/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=IEIkHtF9OK4EglJtk5NkkYIfQgmSypjXF46RNxhi5RE=;
        b=fiLcSh6a1I+9EH+5Y6vNX8xSAxWGy3rIqEOPBjNf9a55+PKFHa6MBOrRtJ2E4HAwsC
         uKBdwFfq7pdYI0XY/AiNx24A1om0iJ/BRgW3q5SCxzjonP0B6A1UwBj2KfhUBmlJgADJ
         gIzFov2Rh7UP911N42BAooG0YxOf1dwzPKlPEMnxN8156eCyJRNIbACi9nBp/SeqzYyg
         aOcXQO/orewoMjKqfu4Y4iIui67YTr3MFgGwvHkUnLsIBgWReYAycQUFeYVaP13vjvLe
         69pO3nhtCaFuCqGbX9ZeWyzgLsdJEOCOaK81QIiE0Lxsi4RmuqZwYyQ+Q/EBWQXS6ttN
         DdRg==
X-Gm-Message-State: AOAM532lT6+s/oEx1WokQskRevuThiRLAcnybcrozhsRfxIxIhmqWNyK
	8A1wZoEdG7biZblmTh7ucjM=
X-Google-Smtp-Source: ABdhPJzZgOwigV5NF34b7KXW7x0t8jZuVfrPF/GeZNJB5lrf/ygeJhC+iwcTT4H03Ja87fEIFVsO+A==
X-Received: by 2002:a05:6512:2208:b0:46b:82c7:677b with SMTP id h8-20020a056512220800b0046b82c7677bmr12233880lfu.24.1650388545250;
        Tue, 19 Apr 2022 10:15:45 -0700 (PDT)
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204181405160.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <4f94e255-ff38-9648-4330-2b7d5e459aae@gmail.com>
Date: Tue, 19 Apr 2022 20:15:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204181405160.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 19.04.22 00:38, Stefano Stabellini wrote:

Hello Stefano

>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> This patch adds basic support for configuring and assisting virtio-mmio
>> based virtio-disk backend (emualator) which is intended to run out of
>                               ^ emulator

ok)


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 17:16:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 17:16:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308417.524165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrSs-0007aQ-3R; Tue, 19 Apr 2022 17:16:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308417.524165; Tue, 19 Apr 2022 17:16:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrSr-0007aI-VQ; Tue, 19 Apr 2022 17:16:33 +0000
Received: by outflank-mailman (input) for mailman id 308417;
 Tue, 19 Apr 2022 17:16:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mE7q=U5=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1ngrSq-00071I-Cp
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 17:16:32 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0615.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::615])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 73c62a21-c004-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 19:16:30 +0200 (CEST)
Received: from DU2P251CA0028.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::32)
 by DB8PR08MB5292.eurprd08.prod.outlook.com (2603:10a6:10:a6::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 17:16:26 +0000
Received: from DB5EUR03FT032.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:230:cafe::5d) by DU2P251CA0028.outlook.office365.com
 (2603:10a6:10:230::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Tue, 19 Apr 2022 17:16:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT032.mail.protection.outlook.com (10.152.20.162) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Tue, 19 Apr 2022 17:16:26 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Tue, 19 Apr 2022 17:16:26 +0000
Received: from 199cbda7e914.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 347864DC-4C5D-422D-92C0-253F77777B7C.1; 
 Tue, 19 Apr 2022 17:16:15 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 199cbda7e914.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Apr 2022 17:16:15 +0000
Received: from DB6PR0801MB2022.eurprd08.prod.outlook.com (2603:10a6:4:76::15)
 by AM5PR0802MB2499.eurprd08.prod.outlook.com (2603:10a6:203:a1::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr
 2022 17:16:13 +0000
Received: from DB6PR0801MB2022.eurprd08.prod.outlook.com
 ([fe80::556f:106a:aa3:42f6]) by DB6PR0801MB2022.eurprd08.prod.outlook.com
 ([fe80::556f:106a:aa3:42f6%3]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022
 17:16:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73c62a21-c004-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XgBLaVZfZ3OyeXxYBvIGjlWj29KWJyZKTKiIU+VO6JE=;
 b=llaF3P0BWSeqqvVlupuIzUvvnuXILUyG3D3MOTeG4HXFyhqqA72NCMu3ubAxjM/gHNtQHR2SvCK6tK+OMjRNIKp/qw/Vpgfj+L1r8lhh+g2C1c3paFwPCe5GPL96ttO2CuMoTXK//KMryZJGMq3FVRSqNbVHukYuKW9HtBhB9Sg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6f841434df4a7b64
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZI2JicU/Kw78PS42z2wDnyYJNg1ITlSCWS0z9uCocr0T8rBcAmtRKk82PNulQEKCyf5loVUrJlLnowkUgbVsVgrL5mvHegbHs36JvxeDk5W/Mpf0RfkTG2iki+JpkWR+O7jpPwiozc+qr2SZzla/8SJrNva/vPDmXCkL5G/ySV1yILw1cPyKXj902Fe1jxl9Nb0GzR3QaGhZeDb2u4xAf9DkcqiuX/TaJrU9szNeatsjET6Zvz8zXXrjkcb5u7pddYG+UMOexEOL2rlJQo8XYMOmMH7Bl+RZ/7+dYw1qAIc+3IuST+i4syj87bYj0RNH2t7iXfANx147ggLDh2UgjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XgBLaVZfZ3OyeXxYBvIGjlWj29KWJyZKTKiIU+VO6JE=;
 b=kFiyTCjanf0BGOs9kR4ohlD20rrPNvoQxDXsHtwm76azpDmf9X11rNgRDMCQGrDi5E2s9V/BmvLn1O2UEHN7MRZ0K/QISp4GGrh7m8Gcy3VThBQGC7tLnkogjhSdnKeoG+qBnN/DZywQZyjC9i7fgQE58WKhA5LgsYnYQQmo23oSNvk3jJ2iaaNBVGQH0vIS9xbRGkMqgoGgj4k6+HsZl7T5MX+ALdZYppP4UmChY6wnoT9BgmQ70mHg4BbP/094MbDVPDhA+K2+jf9zKqyhhl2HLOXMmtBIzhyGZmjHxy2WzszglMZYf0HhtSpr8w0ZOBzgqAIaKu9c4NhqLN+FIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XgBLaVZfZ3OyeXxYBvIGjlWj29KWJyZKTKiIU+VO6JE=;
 b=llaF3P0BWSeqqvVlupuIzUvvnuXILUyG3D3MOTeG4HXFyhqqA72NCMu3ubAxjM/gHNtQHR2SvCK6tK+OMjRNIKp/qw/Vpgfj+L1r8lhh+g2C1c3paFwPCe5GPL96ttO2CuMoTXK//KMryZJGMq3FVRSqNbVHukYuKW9HtBhB9Sg=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, xen-devel
	<xen-devel@lists.xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
Thread-Topic: [PATCH] xen/evtchn: Add design for static event channel
 signaling for domUs..
Thread-Index: AQHYPsy9MfyfmFhecEGJuSNYyusIgKzm3KwAgAAMjACAA7tUgIAEF8cAgAjoaQA=
Date: Tue, 19 Apr 2022 17:16:13 +0000
Message-ID: <076C6D09-C0DA-41BD-84CA-AD595B5AF0A2@arm.com>
References:
 <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com>
 <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2204081837410.3066615@ubuntu-linux-20-04-desktop>
 <D24074F6-E6CF-440A-9E9B-A10783C273D7@arm.com>
 <alpine.DEB.2.22.394.2204131657200.3066615@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204131657200.3066615@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: cc238e1a-0435-44f3-49f9-08da22285603
x-ms-traffictypediagnostic:
	AM5PR0802MB2499:EE_|DB5EUR03FT032:EE_|DB8PR08MB5292:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB5292239CF7C5E342913AE27DFCF29@DB8PR08MB5292.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 oRBW7W3e5x/smorS+bNP9Kwe0dz2HQw6CI/eNwViNfzzsHlqfqQxDPPTC9r6eRNQQFrr9TwB4+KObp45NWUHvK6SXDA8GusbGiXPMBld0NfV0F7c3HROo5dILsAh03llGd2n60Qw9TUjNtTVQdC2HkvxI0l3OKCtfS9uLuU1ieuBPoRTakLSPxSeZFZg9Kl0T7L6V4LB92gpINK+z3n6Vl+++ZDHkxtDVmjWgW9EOxXHeiwkRNMPcXPttB6ndqDF5mvQ0zjVCY/dn2E7jLBxh0d4/xAON2qcU5lxNf4I+zCQDeceDfXmVnWwVCD1xY2A3bN7/57ljwYsKIHyLC8E385VxEOG9AyNHasi620PcF9uqF5IzlEaG7xY0JIG+hhO7saLxgc9p74c+ugCyuvnm/6n+5IoVU8HUVHFvOTdxXUVMLOjWloA8g5uqeP+F/qbxGzHSQq5OcN3aHyjTif7E77Ojx0puF0iNOXN8wuyCv4qMBkcBR31LQhIBpyfjaNRCQNudbkj41h13rE8KyWzSBuL5YPQnQb+/Hk7zqs7ZCPmLHsMsPgk8tOFZ+rA43QjYHicwYTz+mLYz2z+xzyWPg1Dqh65Xr1fsTtmSjwH81G+zjShTf7jACYAzsfS8htvhd5yEqO40t2og5YCGjkBm/yOzPg579KsXOTOQ/wNuwrrDSQ5f1jihJR/HPzU77LOx0tA8qTV5Imn2OCfSoBNXAyr7zWD2myul4GW0rk2LCkEJB6AhoeCXqjK2Z1jQ4VjEJ10cA/3C4hzsGQ99hCg7ssc1sIHHI1lUrMnE4IAvWwDTP9PMbPsZI3cKGM0KShzy6Do3yAPLY6ryahFH0NTNQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2022.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(76116006)(66946007)(66556008)(4326008)(91956017)(66446008)(66476007)(64756008)(8676002)(6486002)(966005)(26005)(6512007)(71200400001)(508600001)(6506007)(53546011)(316002)(2616005)(186003)(6916009)(54906003)(2906002)(36756003)(33656002)(86362001)(8936002)(5660300002)(122000001)(38100700002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <742A4116076DA54A87BC7166E2D6933E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2499
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4aedbfbe-c50e-4de8-786d-08da22284e5e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	urTPMHDf+xHLBVCpX9TlfjTuKAcututXoF52zAk4n3gFf7KQP/+0+xTT4MpJWRlNWSl947gZH63x4RHJPx21fRj2fxvapj7WMwy+7Tb2bbpfuKyvFMSPoTfj7b7aT8he1nAagLdmuJpuW94RBeojYP3e22Qqiv7Su4YtPUTOQoSg/cMiY4YoL6AOxs80lgVYHFyzeIKXq/Qyo9uPfHXe25NcKvo6JVjE9Qu31RPyNjht6aLOYNBXjxt2if2eQH7rppv15AyVgBIqXD+pLqc4n6EPWcpKrxl5nKt743eIdC3gw7tK9eaE+8bkq0zieeJDxLCSjpu/qiKOc76ewZhvGiB/qdos8YAhXfEQlRMfeYj9x1MPJ63oVZ3+dZSHR/MNcupngwSphRvcex8rvQmnd/DIK5KYQ8uQ8SWVQrI36WbFxljkpKQ0bOxsoZSx98ZPNhE3te60EAQ4ffNH/S+0Yz9l7tQ+aPH3E98mcLaKUCqDUJxjeEjEu+nTjwQKfYpyc798rEfsO+HtjcJrgLVd5Y945evnlLPUXqy+cnypSZe8j2r1f6cXXPBitrwrdAzL9mYuhrYunAJp/CzlY9AVTUTqs7S8lYlX1jLBvPs1RzIt+2BOX0Tkm36J9Q5/TJ+SVsigViiET6txtYkeObF19Heh5aymzd3H6GmrbNU/a9etUoX+ox3zLIoSGSKRj7uB4JdSXbvxuSbMokeW+defpw+r7J04P8NvJZqjRhCKJYl71QC0Md1Y4UJUx9OBfbMpI2jpqgoVPlyGa7bfrlIKUA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(83380400001)(54906003)(26005)(47076005)(336012)(186003)(40460700003)(82310400005)(86362001)(2616005)(5660300002)(36756003)(4326008)(8676002)(6862004)(966005)(498600001)(8936002)(6486002)(70206006)(6506007)(81166007)(6512007)(33656002)(2906002)(356005)(53546011)(70586007)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 17:16:26.3282
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cc238e1a-0435-44f3-49f9-08da22285603
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5292

Hello Stefano,

> On 14 Apr 2022, at 2:14 am, Stefano Stabellini <sstabellini@kernel.org> w=
rote:
>=20
> On Mon, 11 Apr 2022, Bertrand Marquis wrote:
>> What you mention here is actually combining 2 different solutions inside
>> Xen to build a custom communication solution.
>> My assumption here is that the user will actually create the device tree
>> nodes he wants to do that and we should not create guest node entries
>> as it would enforce some design.
>>=20
>> If everything can be statically defined for Xen then the user can also
>> statically define node entries inside his guest to make use of the event=
s
>> and the shared memories.
>>=20
>> For example one might need more than one event to build a communication
>> system, or more than one shared memory or could build something
>> communicating with multiple guest thus requiring even more events and
>> shared memories.
>=20
> Hi Bertrand, Rahul,
>=20
> If the guests are allowed some level of dynamic discovery, this feature
> is not needed. They can discover the shared memory location from the
> domU device tree, then proceed to allocate evtchns as needed and tell
> the other end the evtchn numbers over shared memory. I already have an
> example of it here:
>=20
> https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/2251030537/Xen+Shar=
ed+Memory+and+Interrupts+Between+VMs
>=20
> What if the guest doesn't support device tree at runtime, like baremetal
> or Zephyr? The shared memory address can be hardcoded or generated from
> device tree at build time. That's no problem. Then, the event channels
> can still be allocated at runtime and passed to the other end over
> shared memory. That's what the example on the wikipage does.
>=20
>=20
> When are static event channels actually useful? When the application
> cannot allocate the event channels at runtime at all. The reason for the
> restriction could be related to safety (no dynamic allocations at
> runtime) or convenience (everything else is fully static, why should the
> event channel numbers be dynamic?)
>=20
> Given the above, I can see why there is no need to describe the static
> event channel info in the domU device tree: static event channels are
> only useful in fully static configurations, and in those configurations
> the domU device tree dynamically generated by Xen is not needed. I can
> see where you are coming from.
>=20
>=20
> The workflow that we have been trying to enable with the System Device
> Tree effort (System Device Tree is similar to a normal Device Tree plus
> the xen,domains nodes) is the following:
>=20
> S-DT ---[lopper]---> Linux DT
>                L--> Zephyr DT ---[Zephyr build]---> Zephyr .h files
>=20
> S-DT contains all the needed information for both the regular Linux DT
> generation and also the Zephyr/RTOS/baremetal header files generation,
> that happens at build time.
>=20
> S-DT is not the same as the Xen device tree, but so far it has been
> conceptually and practically similar. I always imagine that the bindings
> we have in Xen we'll also have corresponding bindings in System Device
> Tree.
>=20
> For this workflow to work S-DT needs all the info so that both Linux DT
> and Zephyr DT and Zephyr .h files can be generated.
>=20
> Does this proposal contain enough information so that Zephyr .h files
> could be statically generated with the event channel numbers and static
> shared memory regions addresses?
>=20
> I am not sure. Maybe not?
>=20
>=20
> It is possible that the shared memory usage is so application specific
> that there is no point in even talking about it. But I think that
> introducing a simple bundle of both event channels and shared memory
> would help a lot.
>=20
> Something like the following in the Xen device tree would be enough to
> specify an arbitrary number of event channels connected with the same
> domains sharing the memory region.
>=20
> It looks like that if we did the below, we would carry a lot more useful
> information compared to the original proposal alone. We could add a
> similar xen,notificaiton property to the domU reserved-memory region in
> device tree generated by Xen for consistency, so that everything
> available to the domU is described fully in device tree.
>=20
>=20
>    domU1 {
>        compatible =3D "xen,domain";
>=20
>        /* one sub-node per local event channel */
>        ec1: evtchn@1 {
>            compatible =3D "xen,evtchn-v1";
>            /* local-evtchn link-to-foreign-evtchn */
>            xen,evtchn =3D <0x1 &ec3>
>        };
>        ec2: evtchn@2 {
>            compatible =3D "xen,evtchn-v1";
>            xen,evtchn =3D <0x2 &ec4>
>        };
>        /*
>         * shared memory region between DomU1 and DomU2.
>         */
>        domU1-shared-mem@50000000 {
>            compatible =3D "xen,domain-shared-memory-v1";
>            xen,shm-id =3D <0x1>;
>            xen,shared-mem =3D <0x50000000 0x20000000 0x60000000>;
>            /* this is new */
>            xen,notification =3D <&ec1 &ec2>;
>        }
>    };
>=20
>    domU2 {
>        compatible =3D "xen,domain";
>=20
>        /* one sub-node per local event channel */
>        ec3: evtchn@3 {
>            compatible =3D "xen,evtchn-v1";
>            /* local-evtchn link-to-foreign-evtchn */
>            xen,evtchn =3D <0x3 &ec1>
>        };
>        ec4: evtchn@4 {
>            compatible =3D "xen,evtchn-v1";
>            xen,evtchn =3D <0x4 &ec2>
>        };
>        /*
>         * shared memory region between domU1 and domU2.
>         */
>        domU2-shared-mem@50000000 {
>            compatible =3D "xen,domain-shared-memory-v1";
>            xen,shm-id =3D <0x1>;
>            xen,shared-mem =3D <0x50000000 0x20000000 0x70000000>;
>            /* this is new */
>            xen,notification =3D <&ec3 &ec4>;
>        }
>    };
>=20
>=20
>=20
> The good thing about this is that:
>=20
> - it is very flexible
> - nothing to do in this series, except switching to the
>  one-subnode-per-evtchn model, which we called 2) in the previous email
> - there were good reasons to use the one-subnode-per-evtchn model anyway
> - the xen,notification property can be added later without issues, after =
Penny's series
>=20
> There are a couple of ways to implement the xen,notification property
> but we don't need to discuss them now.
>=20
>=20
> Short Summary
> ------------
> I think it is fine to only introduce the Xen device tree binding for
> static event channels without domU binding, but I prefer if we switched
> to using proposal 2) "one subnode per event channel".

Thanks for detailed explanation.I just did the basic implementation of the =
2) proposal and
it looks simple and not very complex as I thought earlier.Therefore I am ok=
 to switch to proposal 2).

If everyone is ok with the 2) proposal I will send the v2 of design doc aft=
er fixing all the comments.

Regards,
Rahul



From xen-devel-bounces@lists.xenproject.org Tue Apr 19 17:31:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 17:31:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308424.524176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrh9-0001dC-C9; Tue, 19 Apr 2022 17:31:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308424.524176; Tue, 19 Apr 2022 17:31:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngrh9-0001d5-92; Tue, 19 Apr 2022 17:31:19 +0000
Received: by outflank-mailman (input) for mailman id 308424;
 Tue, 19 Apr 2022 17:31:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WtTZ=U5=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1ngrh7-0001cz-TR
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 17:31:18 +0000
Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com
 [2a00:1450:4864:20::32e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 841a9c5a-c006-11ec-a405-831a346695d4;
 Tue, 19 Apr 2022 19:31:16 +0200 (CEST)
Received: by mail-wm1-x32e.google.com with SMTP id
 o20-20020a05600c511400b0038ebbbb2ad8so1995809wms.0
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 10:31:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 841a9c5a-c006-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=/v2X/IWEkNMqAvV2DAnl/r/uJBQ8nv5MJNPp35CwEWM=;
        b=qQjGfz56IlbFmugfznWhmGFVY+fxLRGYudPpTqx6hBxAz2mBQ29ZftiZkZWov05EFZ
         mDn/0IbHyzRX+i8xdSrPD49Tc4cRIW2BhBUsHTvfoiPXIhvcwF4Af9L8CbYPTSXBy4kL
         mTfEhJRnPXJXi0HwSUX1ha0xWgkGaENGSGPdUUAiI8IGcgKQwWysCejMKJ6OAKg7qaHv
         /eJSYwnl0wXUCzzPqjeKI47rHOM1ugcO8si9ILMR8G9MK1SA7OoeqcM+jUsA7fYSlJii
         ywVcdZtDsR+fskv0Nn/3dODSyylxBM+f/TzDGmX3NqYEvoJCYgsbx/cjZfk8+VeM/7sE
         ifRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=/v2X/IWEkNMqAvV2DAnl/r/uJBQ8nv5MJNPp35CwEWM=;
        b=x5iHnKUnu9G3mSAt6gjSgzkJGupW0It8JkBwVc0ZsZwhvjR33rzSX8zk1WlC1W5HMS
         2TWu+5F5BC4yVsUONXMJkZZay+gCog3s7JtTr2y3BAIqENabS2y4eo+MTCJjf3/T6MJe
         JOgMfXttL5XiM+i8eHvdcm+A1WyAfENnqr5gYD1oxEfbizgkOzgHayzMvOv/PhGLSH+R
         VyG7FGJ0rfSz0dATWlx0+qCYSfieFqs5TRZhd7D2XAUZPZPp4V68S0n7NjbvLHa7/cYM
         mICF5nVIRdn98qLEOkiV6ieYdfmnyh4i2u336OMMfkV0/yfpCy3vSpgsIjaZU2tvUVaA
         bF0A==
X-Gm-Message-State: AOAM530eaW9sHXgHlBvMGbGKJwULcyQsyZmn1FWK2+lJ/p48GUJizRw9
	vIlYwk0Jp57Tz8zUxSDC2dcfC+2ecTeDkd9g7v0JoIuS
X-Google-Smtp-Source: ABdhPJxb7HOiHFivsd8jVuyhThpUPGqrWYOy/SgM5YR3tmOh2GAwN36rH4mZSyHh/RQ9jZslvSSPYSQo0yjbLxyh0nU=
X-Received: by 2002:a1c:ed01:0:b0:38b:5a39:220c with SMTP id
 l1-20020a1ced01000000b0038b5a39220cmr20738700wmh.167.1650389475639; Tue, 19
 Apr 2022 10:31:15 -0700 (PDT)
MIME-Version: 1.0
References: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
 <CAJ=z9a37_y3B4aAfiK5C-bHJYyWqCo0+g+jB6cdDCmOzLuXLJw@mail.gmail.com>
 <925421bc-680b-df61-5a75-681d752c4820@gmail.com> <b8a0feed-1dde-3b36-646e-1e5413de8395@gmail.com>
In-Reply-To: <b8a0feed-1dde-3b36-646e-1e5413de8395@gmail.com>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Tue, 19 Apr 2022 17:31:03 +0000
Message-ID: <CAJ=z9a2n0bWEk-7cpOj2q_4fUqetjkQdkgBGYKoQeGeDJ8MxTQ@mail.gmail.com>
Subject: Re: [PATCH] xen/arm: silence ambiguous integer casting warning error
To: Paran Lee <p4ranlee@gmail.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: multipart/alternative; boundary="0000000000006fc46305dd053e72"

--0000000000006fc46305dd053e72
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 19 Apr 2022, 17:09 Paran Lee, <p4ranlee@gmail.com> wrote:

> Debugging with GDB from head.S with QEMU runtime was very convenient for
> analysis(linux). so I have trying it in Xen. As I built it.
>

I don't understand how this is related to adding extra cflags. Can you
clarify it?


> Wouldn't it be helpful if I fixed the code little by little?


I am all to make Xen more robust. However, you are now implicitly casting a
signed int to unsigned int. I am not convinced this is a good move.

I think it would be better to fix the other side of the equation or
properly modify the function return.

Cheers,


> 2022-04-20 =EC=98=A4=EC=A0=84 1:31=EC=97=90 Paran Lee =EC=9D=B4(=EA=B0=80=
) =EC=93=B4 =EA=B8=80:
> > Hi, Julien Grall.
> >
> > Thank you for checking it out. I'm sorry I forgot to attach the make lo=
g
> > as well.
> >
> > My build configuration (include CFLGAS)
> >
> > export ARCH=3Darm64
> > export XEN_TARGET_ARCH=3Darm64
> > export $(dpkg-architecture -aarm64);
> > export CROSS_COMPILE=3Daarch64-linux-gnu-
> > export CFLAGS=3D"-g -Wall -Wextra -Wno-unused-parameter"
> >
> > And i did     make dist-xen
> >
> > my arm64 compiler information are here.
> > gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
> >
> > ~/xen$ aarch64-linux-gnu-gcc -v
> > Using built-in specs.
> > COLLECT_GCC=3Daarch64-linux-gnu-gcc
> > COLLECT_LTO_WRAPPER=3D/usr/lib/gcc-cross/aarch64-linux-gnu/9/lto-wrappe=
r
> > Target: aarch64-linux-gnu
> > Configured with: ../src/configure -v --with-pkgversion=3D'Ubuntu
> > 9.4.0-1ubuntu1~20.04.1'
> > --with-bugurl=3Dfile:///usr/share/doc/gcc-9/README.Bugs
> > --enable-languages=3Dc,ada,c++,go,d,fortran,objc,obj-c++,gm2 --prefix=
=3D/usr
> > --with-gcc-major-version-only --program-suffix=3D-9 --enable-shared
> > --enable-linker-build-id --libexecdir=3D/usr/lib
> > --without-included-gettext --enable-threads=3Dposix --libdir=3D/usr/lib
> > --enable-nls --with-sysroot=3D/ --enable-clocale=3Dgnu
> > --enable-libstdcxx-debug --enable-libstdcxx-time=3Dyes
> > --with-default-libstdcxx-abi=3Dnew --enable-gnu-unique-object
> > --disable-libquadmath --disable-libquadmath-support --enable-plugin
> > --enable-default-pie --with-system-zlib --without-target-system-zlib
> > --enable-libpth-m2 --enable-multiarch --enable-fix-cortex-a53-843419
> > --disable-werror --enable-checking=3Drelease --build=3Dx86_64-linux-gnu
> > --host=3Dx86_64-linux-gnu --target=3Daarch64-linux-gnu
> > --program-prefix=3Daarch64-linux-gnu-
> > --includedir=3D/usr/aarch64-linux-gnu/include
> > Thread model: posix
> > gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
> >
> > In arch/arm/gic-v3.c files.
> >
> > arch/arm/gic-v3.c: In function =E2=80=98gicv3_compute_target_list=E2=80=
=99:
> > arch/arm/gic-v3.c:926:17: error: comparison of integer expressions of
> > different signedness: =E2=80=98int=E2=80=99 and =E2=80=98unsigned int=
=E2=80=99 [-Werror=3Dsign-compare]
> >   926 |     while ( cpu < nr_cpu_ids )
> >       |                 ^
> > arch/arm/gic-v3.c:936:18: error: comparison of integer expressions of
> > different signedness: =E2=80=98int=E2=80=99 and =E2=80=98unsigned int=
=E2=80=99 [-Werror=3Dsign-compare]
> >   936 |         if ( cpu =3D=3D nr_cpu_ids )
> >       |                  ^~                           ^
> >
> > In arch/arm/setup.c files.
> >
> > arch/arm/setup.c: In function =E2=80=98start_xen=E2=80=99:
> > ./include/xen/cpumask.h:374:13: error: comparison of integer expression=
s
> > of different signedness: =E2=80=98int=E2=80=99 and =E2=80=98unsigned in=
t=E2=80=99 [-Werror=3Dsign-compare]
> >   374 |       (cpu) < nr_cpu_ids;  \
> >       |             ^
> > ./include/xen/cpumask.h:459:36: note: in expansion of macro
> =E2=80=98for_each_cpu=E2=80=99
> >   459 | #define for_each_present_cpu(cpu)  for_each_cpu(cpu,
> > &cpu_present_map)
> >       |                                    ^~~~~~~~~~~~
> > arch/arm/setup.c:989:5: note: in expansion of macro
> =E2=80=98for_each_present_cpu=E2=80=99
> >   989 |     for_each_present_cpu ( i )
> >       |     ^~~~~~~~~~~~~~~~~~~~             ^
> >
> > Thank you!
> >
> > 2022-04-20 =EC=98=A4=EC=A0=84 12:50=EC=97=90 Julien Grall =EC=9D=B4(=EA=
=B0=80) =EC=93=B4 =EA=B8=80:
> >> Hi,
> >>
> >> On Tue, 19 Apr 2022, 15:41 Paran Lee, <p4ranlee@gmail.com> wrote:
> >>
> >>> GCC with "-g -Wall -Wextra" option throws warning message as below:
> >>
> >>
> >> Which version of the compiler? Also you specify the exact cflags, did
> you
> >> tweak Xen?
> >>
> >>
> >>> error: comparison of integer expressions of different signedness:
> >>>  =E2=80=98int=E2=80=99 and =E2=80=98unsigned int=E2=80=99 [-Werror=3D=
sign-compare]
> >>>
> >>
> >> GCC should give you a line/file. Can you provide it?
> >>
> >> Cheers,
> >>
> >>
> >>> Silence the warning by correcting the integer type.
> >>>
> >>> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> >>> ---
> >>>  xen/arch/arm/gic-v3.c | 5 +++--
> >>>  xen/arch/arm/setup.c  | 2 +-
> >>>  2 files changed, 4 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> >>> index 3c472ed768..81ac25f528 100644
> >>> --- a/xen/arch/arm/gic-v3.c
> >>> +++ b/xen/arch/arm/gic-v3.c
> >>> @@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)
> >>>      isb();
> >>>  }
> >>>
> >>> -static u16 gicv3_compute_target_list(int *base_cpu, const struct
> cpumask
> >>> *mask,
> >>> +static u16 gicv3_compute_target_list(unsigned int *base_cpu,
> >>> +                                     const struct cpumask *mask,
> >>>                                       uint64_t cluster_id)
> >>>  {
> >>>      int cpu =3D *base_cpu;
> >>> @@ -953,7 +954,7 @@ out:
> >>>
> >>>  static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t
> >>> *cpumask)
> >>>  {
> >>> -    int cpu =3D 0;
> >>> +    unsigned int cpu =3D 0;
> >>>      uint64_t val;
> >>>
> >>>      for_each_cpu(cpu, cpumask)
> >>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> >>> index d5d0792ed4..5ab2aaecaf 100644
> >>> --- a/xen/arch/arm/setup.c
> >>> +++ b/xen/arch/arm/setup.c
> >>> @@ -862,7 +862,7 @@ void __init start_xen(unsigned long
> boot_phys_offset,
> >>>                        unsigned long fdt_paddr)
> >>>  {
> >>>      size_t fdt_size;
> >>> -    int cpus, i;
> >>> +    unsigned int cpus, i;
> >>>      const char *cmdline;
> >>>      struct bootmodule *xen_bootmodule;
> >>>      struct domain *d;
> >>> --
> >>> 2.25.1
> >>>
> >>>
> >>
>

--0000000000006fc46305dd053e72
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Hi,<br><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Tue, 19 Apr 2022, 17:09 Paran Lee, &lt;<a href=
=3D"mailto:p4ranlee@gmail.com">p4ranlee@gmail.com</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex">Debugging with GDB from head.S with QEMU runt=
ime was very convenient for<br>
analysis(linux). so I have trying it in Xen. As I built it.<br></blockquote=
></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">I don&#39;t unde=
rstand how this is related to adding extra cflags. Can you clarify it?</div=
><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex">
<br>
Wouldn&#39;t it be helpful if I fixed the code little by little?</blockquot=
e></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">I am all to mak=
e Xen more robust. However, you are now implicitly casting a signed int to =
unsigned int. I am not convinced this is a good move.</div><div dir=3D"auto=
"><br></div><div dir=3D"auto">I think it would be better to fix the other s=
ide of the equation or properly modify the function return.</div><div dir=
=3D"auto"><br></div><div dir=3D"auto">Cheers,</div><div dir=3D"auto"><br></=
div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail=
_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:=
1ex">
<br>
2022-04-20 =EC=98=A4=EC=A0=84 1:31=EC=97=90 Paran Lee =EC=9D=B4(=EA=B0=80) =
=EC=93=B4 =EA=B8=80:<br>
&gt; Hi, Julien Grall.<br>
&gt; <br>
&gt; Thank you for checking it out. I&#39;m sorry I forgot to attach the ma=
ke log<br>
&gt; as well.<br>
&gt; <br>
&gt; My build configuration (include CFLGAS)<br>
&gt; <br>
&gt; export ARCH=3Darm64<br>
&gt; export XEN_TARGET_ARCH=3Darm64<br>
&gt; export $(dpkg-architecture -aarm64);<br>
&gt; export CROSS_COMPILE=3Daarch64-linux-gnu-<br>
&gt; export CFLAGS=3D&quot;-g -Wall -Wextra -Wno-unused-parameter&quot;<br>
&gt; <br>
&gt; And i did=C2=A0 =C2=A0 =C2=A0make dist-xen<br>
&gt; <br>
&gt; my arm64 compiler information are here.<br>
&gt; gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)<br>
&gt; <br>
&gt; ~/xen$ aarch64-linux-gnu-gcc -v<br>
&gt; Using built-in specs.<br>
&gt; COLLECT_GCC=3Daarch64-linux-gnu-gcc<br>
&gt; COLLECT_LTO_WRAPPER=3D/usr/lib/gcc-cross/aarch64-linux-gnu/9/lto-wrapp=
er<br>
&gt; Target: aarch64-linux-gnu<br>
&gt; Configured with: ../src/configure -v --with-pkgversion=3D&#39;Ubuntu<b=
r>
&gt; 9.4.0-1ubuntu1~20.04.1&#39;<br>
&gt; --with-bugurl=3Dfile:///usr/share/doc/gcc-9/README.Bugs<br>
&gt; --enable-languages=3Dc,ada,c++,go,d,fortran,objc,obj-c++,gm2 --prefix=
=3D/usr<br>
&gt; --with-gcc-major-version-only --program-suffix=3D-9 --enable-shared<br=
>
&gt; --enable-linker-build-id --libexecdir=3D/usr/lib<br>
&gt; --without-included-gettext --enable-threads=3Dposix --libdir=3D/usr/li=
b<br>
&gt; --enable-nls --with-sysroot=3D/ --enable-clocale=3Dgnu<br>
&gt; --enable-libstdcxx-debug --enable-libstdcxx-time=3Dyes<br>
&gt; --with-default-libstdcxx-abi=3Dnew --enable-gnu-unique-object<br>
&gt; --disable-libquadmath --disable-libquadmath-support --enable-plugin<br=
>
&gt; --enable-default-pie --with-system-zlib --without-target-system-zlib<b=
r>
&gt; --enable-libpth-m2 --enable-multiarch --enable-fix-cortex-a53-843419<b=
r>
&gt; --disable-werror --enable-checking=3Drelease --build=3Dx86_64-linux-gn=
u<br>
&gt; --host=3Dx86_64-linux-gnu --target=3Daarch64-linux-gnu<br>
&gt; --program-prefix=3Daarch64-linux-gnu-<br>
&gt; --includedir=3D/usr/aarch64-linux-gnu/include<br>
&gt; Thread model: posix<br>
&gt; gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)<br>
&gt; <br>
&gt; In arch/arm/gic-v3.c files.<br>
&gt; <br>
&gt; arch/arm/gic-v3.c: In function =E2=80=98gicv3_compute_target_list=E2=
=80=99:<br>
&gt; arch/arm/gic-v3.c:926:17: error: comparison of integer expressions of<=
br>
&gt; different signedness: =E2=80=98int=E2=80=99 and =E2=80=98unsigned int=
=E2=80=99 [-Werror=3Dsign-compare]<br>
&gt;=C2=A0 =C2=A0926 |=C2=A0 =C2=A0 =C2=A0while ( cpu &lt; nr_cpu_ids )<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0^<br>
&gt; arch/arm/gic-v3.c:936:18: error: comparison of integer expressions of<=
br>
&gt; different signedness: =E2=80=98int=E2=80=99 and =E2=80=98unsigned int=
=E2=80=99 [-Werror=3Dsign-compare]<br>
&gt;=C2=A0 =C2=A0936 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( cpu =3D=3D nr_=
cpu_ids )<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 ^~=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^<br>
&gt; <br>
&gt; In arch/arm/setup.c files.<br>
&gt; <br>
&gt; arch/arm/setup.c: In function =E2=80=98start_xen=E2=80=99:<br>
&gt; ./include/xen/cpumask.h:374:13: error: comparison of integer expressio=
ns<br>
&gt; of different signedness: =E2=80=98int=E2=80=99 and =E2=80=98unsigned i=
nt=E2=80=99 [-Werror=3Dsign-compare]<br>
&gt;=C2=A0 =C2=A0374 |=C2=A0 =C2=A0 =C2=A0 =C2=A0(cpu) &lt; nr_cpu_ids;=C2=
=A0 \<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0^<br>
&gt; ./include/xen/cpumask.h:459:36: note: in expansion of macro =E2=80=98f=
or_each_cpu=E2=80=99<br>
&gt;=C2=A0 =C2=A0459 | #define for_each_present_cpu(cpu)=C2=A0 for_each_cpu=
(cpu,<br>
&gt; &amp;cpu_present_map)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 ^~~~~~~~~~~~<br>
&gt; arch/arm/setup.c:989:5: note: in expansion of macro =E2=80=98for_each_=
present_cpu=E2=80=99<br>
&gt;=C2=A0 =C2=A0989 |=C2=A0 =C2=A0 =C2=A0for_each_present_cpu ( i )<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~~~~~~~=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^<br>
&gt; <br>
&gt; Thank you!<br>
&gt; <br>
&gt; 2022-04-20 =EC=98=A4=EC=A0=84 12:50=EC=97=90 Julien Grall =EC=9D=B4(=
=EA=B0=80) =EC=93=B4 =EA=B8=80:<br>
&gt;&gt; Hi,<br>
&gt;&gt;<br>
&gt;&gt; On Tue, 19 Apr 2022, 15:41 Paran Lee, &lt;<a href=3D"mailto:p4ranl=
ee@gmail.com" target=3D"_blank" rel=3D"noreferrer">p4ranlee@gmail.com</a>&g=
t; wrote:<br>
&gt;&gt;<br>
&gt;&gt;&gt; GCC with &quot;-g -Wall -Wextra&quot; option throws warning me=
ssage as below:<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; Which version of the compiler? Also you specify the exact cflags, =
did you<br>
&gt;&gt; tweak Xen?<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt;&gt; error: comparison of integer expressions of different signedne=
ss:<br>
&gt;&gt;&gt;=C2=A0 =E2=80=98int=E2=80=99 and =E2=80=98unsigned int=E2=80=99=
 [-Werror=3Dsign-compare]<br>
&gt;&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; GCC should give you a line/file. Can you provide it?<br>
&gt;&gt;<br>
&gt;&gt; Cheers,<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt;&gt; Silence the warning by correcting the integer type.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; Signed-off-by: Paran Lee &lt;<a href=3D"mailto:p4ranlee@gmail.=
com" target=3D"_blank" rel=3D"noreferrer">p4ranlee@gmail.com</a>&gt;<br>
&gt;&gt;&gt; ---<br>
&gt;&gt;&gt;=C2=A0 xen/arch/arm/gic-v3.c | 5 +++--<br>
&gt;&gt;&gt;=C2=A0 xen/arch/arm/setup.c=C2=A0 | 2 +-<br>
&gt;&gt;&gt;=C2=A0 2 files changed, 4 insertions(+), 3 deletions(-)<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c<br>
&gt;&gt;&gt; index 3c472ed768..81ac25f528 100644<br>
&gt;&gt;&gt; --- a/xen/arch/arm/gic-v3.c<br>
&gt;&gt;&gt; +++ b/xen/arch/arm/gic-v3.c<br>
&gt;&gt;&gt; @@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 isb();<br>
&gt;&gt;&gt;=C2=A0 }<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; -static u16 gicv3_compute_target_list(int *base_cpu, const str=
uct cpumask<br>
&gt;&gt;&gt; *mask,<br>
&gt;&gt;&gt; +static u16 gicv3_compute_target_list(unsigned int *base_cpu,<=
br>
&gt;&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0co=
nst struct cpumask *mask,<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0uint64_t cluster_id)<br>
&gt;&gt;&gt;=C2=A0 {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 int cpu =3D *base_cpu;<br>
&gt;&gt;&gt; @@ -953,7 +954,7 @@ out:<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt;=C2=A0 static void gicv3_send_sgi_list(enum gic_sgi sgi, const =
cpumask_t<br>
&gt;&gt;&gt; *cpumask)<br>
&gt;&gt;&gt;=C2=A0 {<br>
&gt;&gt;&gt; -=C2=A0 =C2=A0 int cpu =3D 0;<br>
&gt;&gt;&gt; +=C2=A0 =C2=A0 unsigned int cpu =3D 0;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 uint64_t val;<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 for_each_cpu(cpu, cpumask)<br>
&gt;&gt;&gt; diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c<br>
&gt;&gt;&gt; index d5d0792ed4..5ab2aaecaf 100644<br>
&gt;&gt;&gt; --- a/xen/arch/arm/setup.c<br>
&gt;&gt;&gt; +++ b/xen/arch/arm/setup.c<br>
&gt;&gt;&gt; @@ -862,7 +862,7 @@ void __init start_xen(unsigned long boot_p=
hys_offset,<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 unsigned long fdt_paddr)<br>
&gt;&gt;&gt;=C2=A0 {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 size_t fdt_size;<br>
&gt;&gt;&gt; -=C2=A0 =C2=A0 int cpus, i;<br>
&gt;&gt;&gt; +=C2=A0 =C2=A0 unsigned int cpus, i;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 const char *cmdline;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 struct bootmodule *xen_bootmodule;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 struct domain *d;<br>
&gt;&gt;&gt; --<br>
&gt;&gt;&gt; 2.25.1<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt;<br>
&gt;&gt;<br>
</blockquote></div></div></div>

--0000000000006fc46305dd053e72--


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 19:59:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 19:59:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308436.524187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngu03-0000Du-00; Tue, 19 Apr 2022 19:58:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308436.524187; Tue, 19 Apr 2022 19:58:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngu02-0000Di-Ss; Tue, 19 Apr 2022 19:58:58 +0000
Received: by outflank-mailman (input) for mailman id 308436;
 Tue, 19 Apr 2022 19:58:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngu01-0000DI-5y; Tue, 19 Apr 2022 19:58:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngu00-0006kh-RN; Tue, 19 Apr 2022 19:58:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngu00-0003HK-Be; Tue, 19 Apr 2022 19:58:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngu00-0006qG-B7; Tue, 19 Apr 2022 19:58:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JOeT1z2P4bbdRodlAiEbwetMcy6nCjxWLWG2Y3y6jb0=; b=OrC4YGPWUTLQa3eicSfE50bqNX
	xY4q47CV5oxiN90ExcJ275tQatpSXkRLxogzl4PeocWTFFD48Lr2HESlhrNyM4PnnwtDGBpfUeHPv
	TB3bAJ9QnLn1EX4Wwnk3LxaZT9wX6xiSx/wgYlZdFDR5VcD/jC33kX2c0KEpMt3Yb9O0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169544-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169544: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 19:58:56 +0000

flight 169544 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169544/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  509 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 20:45:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 20:45:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308447.524201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngujK-00062J-LM; Tue, 19 Apr 2022 20:45:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308447.524201; Tue, 19 Apr 2022 20:45:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngujK-00062C-IW; Tue, 19 Apr 2022 20:45:46 +0000
Received: by outflank-mailman (input) for mailman id 308447;
 Tue, 19 Apr 2022 20:45:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngujI-000622-Jq; Tue, 19 Apr 2022 20:45:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngujI-0007fP-HI; Tue, 19 Apr 2022 20:45:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngujH-0005AX-VH; Tue, 19 Apr 2022 20:45:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngujH-0000PW-Up; Tue, 19 Apr 2022 20:45:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TfoaVlinyCwtqAk0SeApI1OBJp6dmo0LwTQQQ8uKaU8=; b=aGxS8KmqPhbcl2W3ndS9JN0SjU
	aUw915QGcV11+X1Np4egYwSW3CWfJXUXI7Cp34x5GLce4FQMMrBuwtr4PNvwgG0Lo9/6QL+dL4Jot
	wsa12D7gb5z9ipk1V/YWq6iveCGz+aG30gxhHA12bYraM/NtZFO925QAWLSRiO9Tre04=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169541-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169541: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b881cb95cb034466d3dd9be52f5a7e6594148a90
X-Osstest-Versions-That:
    xen=e509b5f932608e74deac96048b28a5e9b210c647
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 20:45:43 +0000

flight 169541 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169541/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 169412
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169528
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169528
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169528
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169528
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169528
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169528
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169528
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169528
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169528
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169528
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169528
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169528
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  b881cb95cb034466d3dd9be52f5a7e6594148a90
baseline version:
 xen                  e509b5f932608e74deac96048b28a5e9b210c647

Last test of basis   169528  2022-04-19 01:52:02 Z    0 days
Testing same since   169541  2022-04-19 13:06:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e509b5f932..b881cb95cb  b881cb95cb034466d3dd9be52f5a7e6594148a90 -> master


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 20:46:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 20:46:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308451.524213 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngujg-0006TR-Vy; Tue, 19 Apr 2022 20:46:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308451.524213; Tue, 19 Apr 2022 20:46:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngujg-0006TK-SS; Tue, 19 Apr 2022 20:46:08 +0000
Received: by outflank-mailman (input) for mailman id 308451;
 Tue, 19 Apr 2022 20:46:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngujf-0006RW-9q; Tue, 19 Apr 2022 20:46:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngujf-0007fm-91; Tue, 19 Apr 2022 20:46:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nguje-0005B7-V1; Tue, 19 Apr 2022 20:46:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nguje-0000ht-UX; Tue, 19 Apr 2022 20:46:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OaJwBGORDdOpCnUTocHB+jCxcd2L24XTcQ50vCd6JGs=; b=W2YGN29BfcWf51qyEXy0B8XZhO
	SHwkLbfLEj5a7/WzK7xDzjRj55tr+B/RVpNplUYbIn298gsxVppN4Gw1WnThWjpIsGVXqTCMjG4aq
	IXfChpSr6Xg65IRt8Kskhe9DGp2bzZSei7Y8JM5Kt82ErabYb1sdq+zWyxqBPlXNTAwc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169548-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169548: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 20:46:06 +0000

flight 169548 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169548/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  510 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 23:21:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 23:21:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308474.524224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngx9d-0006k0-V1; Tue, 19 Apr 2022 23:21:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308474.524224; Tue, 19 Apr 2022 23:21:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngx9d-0006jt-Rl; Tue, 19 Apr 2022 23:21:05 +0000
Received: by outflank-mailman (input) for mailman id 308474;
 Tue, 19 Apr 2022 23:21:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngx9c-0006jj-Oz; Tue, 19 Apr 2022 23:21:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngx9c-0001tH-N4; Tue, 19 Apr 2022 23:21:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngx9c-0005oh-BM; Tue, 19 Apr 2022 23:21:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngx9c-0007Cg-Ay; Tue, 19 Apr 2022 23:21:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kRmxmrJxSHcjDmkQybkgB4tLtkOAuD1rPDjxt3S5huQ=; b=D98WpnaWk3kzJjp1bviWuJ5jiP
	MjfK1J8NC1II4lR8oQz9klSrWOdaVk9XGc7wF3GUn8NWL4YehddgSJEE6SJsOuvgPSo2UK0AsOlK5
	c8glO9AI8j+P2LebLbywPwGkQgBnsbod6lXMFCK7e/IOUqnZfLPUGv0iXabUqdV+by0Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169546-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169546: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2ce9afd68e0bacc15b5570a983fa626cc4de9dbd
X-Osstest-Versions-That:
    xen=b881cb95cb034466d3dd9be52f5a7e6594148a90
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Apr 2022 23:21:04 +0000

flight 169546 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169546/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2ce9afd68e0bacc15b5570a983fa626cc4de9dbd
baseline version:
 xen                  b881cb95cb034466d3dd9be52f5a7e6594148a90

Last test of basis   169537  2022-04-19 10:00:26 Z    0 days
Testing same since   169546  2022-04-19 18:00:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b881cb95cb..2ce9afd68e  2ce9afd68e0bacc15b5570a983fa626cc4de9dbd -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Apr 19 23:43:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Apr 2022 23:43:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308484.524234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngxVQ-00016Q-OK; Tue, 19 Apr 2022 23:43:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308484.524234; Tue, 19 Apr 2022 23:43:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngxVQ-00016J-LY; Tue, 19 Apr 2022 23:43:36 +0000
Received: by outflank-mailman (input) for mailman id 308484;
 Tue, 19 Apr 2022 23:43:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RvD2=U5=gmail.com=eng.alaamohamedsoliman.am@srs-se1.protection.inumbo.net>)
 id 1ngxVP-00016D-B9
 for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 23:43:35 +0000
Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com
 [2a00:1450:4864:20::430])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 852d3d66-c03a-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 01:43:32 +0200 (CEST)
Received: by mail-wr1-x430.google.com with SMTP id q3so23811775wrj.7
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 16:43:32 -0700 (PDT)
Received: from alaa-emad ([102.41.109.205]) by smtp.gmail.com with ESMTPSA id
 x4-20020adfdd84000000b00207b60ed68esm13255849wrl.100.2022.04.19.16.43.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Apr 2022 16:43:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 852d3d66-c03a-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=HKQLOdPaQ3Mw3cBSPXtTxWv22p46uaNKqi/2UnH+TaU=;
        b=W+DL2plQDmeF6M+8AnbzgopnqINjz5xpZNqMbikOKgoHFPRR+2r5EWaHfQkEeeyh8Y
         4x3B0Cqy4qQjSieeCV93kllUXHcH1UEDOyJ4H3wi3nGkncyyG69gMCxdhJrYyUgoMASs
         byoRivqsbbPGEE5WgsXzZwjw4W9tp8cTrS2PGq8BAEhXE767YJOJn1HZSX0oG6fO7+gi
         xLn3V8FkF2M8NwqWPNExwEjR/LxGIsYI7oaOyzgmVo32APXgz+OmYl1Y48HnpBXCupPQ
         yXxgbu5sru6YT/MpEjkix0vIoBcBKYwhlN6gKA5aSrgKRu9UJZxn3uW2VAIeWPPrevdr
         3hHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=HKQLOdPaQ3Mw3cBSPXtTxWv22p46uaNKqi/2UnH+TaU=;
        b=d5CcPaOBbeKWhWdWpV2LD2ZqVKgD0e1bNjbd0nXIsLSmYYjjHtG767/x+iuAlYo06I
         deAt+BIRdgS4MyB1Q0PkeKE+U6jhKBmY/ijYGBCoYVZdNasIkVknMae59bXwSU2nrhbE
         4Y+4uleEdEDMUODQ74ZpqYRwpznudy1FGs0oimvagpzXLa3ygui5oE6fFGJyhCp616Ic
         DLnZqF52wYQycOl/Ub9nARIDWuzto08SPLNrNC5AWOcXq8LcoqcQWcEBtSMBKcila6Rt
         IvL5i9nJW6v5vJhbQycf4jMERZGqUHf0+yvTujOEcc4xlp4Pgj3r8+Jg7pyA9VEDkN4L
         kMEQ==
X-Gm-Message-State: AOAM532PCVkp6c1qxReOvGd/skMwLDnkqqtzFgeppwtda0jKillbOIG/
	qZ2uW8PJHylkbPOYqQqFyqo=
X-Google-Smtp-Source: ABdhPJwAIcFXMCqod1EDSxcxDLBq3kQdWuUNKRazc7JRrvo6vjc1W5NvWFPzXoUkm5DwO/gOBUTKUg==
X-Received: by 2002:a5d:45ce:0:b0:207:9e7e:9a4b with SMTP id b14-20020a5d45ce000000b002079e7e9a4bmr13248177wrs.559.1650411811661;
        Tue, 19 Apr 2022 16:43:31 -0700 (PDT)
From: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
To: outreachy@lists.linux.dev
Cc: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	ira.weiny@intel.com,
	eng.alaamohamedsoliman.am@gmail.com
Subject: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
Date: Wed, 20 Apr 2022 01:43:28 +0200
Message-Id: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com>
X-Mailer: git-send-email 2.35.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

kmap() is being deprecated and these usages are all local to the thread
so there is no reason kmap_local_page() can't be used.

Replace kmap() calls with kmap_local_page().

Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
changes in V2:
	-edit commit subject
	-edit commit message
---
 drivers/xen/gntalloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c
index 4849f94372a4..55acb32842a3 100644
--- a/drivers/xen/gntalloc.c
+++ b/drivers/xen/gntalloc.c
@@ -178,9 +178,9 @@ static void __del_gref(struct gntalloc_gref *gref)
 	unsigned long addr;
 
 	if (gref->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) {
-		uint8_t *tmp = kmap(gref->page);
+		uint8_t *tmp = kmap_local_page(gref->page);
 		tmp[gref->notify.pgoff] = 0;
-		kunmap(gref->page);
+		kunmap_local(tmp);
 	}
 	if (gref->notify.flags & UNMAP_NOTIFY_SEND_EVENT) {
 		notify_remote_via_evtchn(gref->notify.event);
-- 
2.35.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 00:13:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 00:13:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308492.524246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngxyA-0005Nk-8m; Wed, 20 Apr 2022 00:13:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308492.524246; Wed, 20 Apr 2022 00:13:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngxyA-0005Nd-5m; Wed, 20 Apr 2022 00:13:18 +0000
Received: by outflank-mailman (input) for mailman id 308492;
 Wed, 20 Apr 2022 00:13:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngxy8-0005NX-Lm
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 00:13:16 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ab5b812a-c03e-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 02:13:14 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1B0E26130B;
 Wed, 20 Apr 2022 00:13:13 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEFEFC385A7;
 Wed, 20 Apr 2022 00:13:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab5b812a-c03e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650413592;
	bh=13XZdxnntjNGDo+tym68pISCyqOzumLbemYUC8PseRY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=jYIohIdv4SNyImYHqZh13OB3arIsnobjAq016ucb1NfnlcbUwEno8q78fwiGhoLOX
	 kNnu8jvJxW7bRm413yfS2hH0CdK9RMFRzkNLv2X3zjQruFbeI7N8jVXdknS/bnMo8M
	 z0BK7YSwlHMDu4FdunUIIwVY4AIMDCqrJJSDbkRuNo6Cyg42Uz+zQFXmdmE1gEoIKi
	 BABiC5yJKjaEqlZbsp37aPXgy458LWP1cw1Y2FjvWHA1V0VXwKkdypUDw+dLYrFB71
	 e2aCqSZzGYf5KyFkQkqzdi/dtGXKVm3TcI1fytVSQzVZZYYH79t2vb/YYSt088WnAX
	 E3O3QbP/2qx7w==
Date: Tue, 19 Apr 2022 17:13:09 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Julien Grall <julien.grall@arm.com>, 
    Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Jiamei Xie <Jiamei.Xie@arm.com>, Henry Wang <Henry.Wang@arm.com>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on
 Arm
In-Reply-To: <6f2a970e-36b4-b2d4-a0ee-04f3ab31b985@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204191712560.915916@ubuntu-linux-20-04-desktop>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com> <1649442065-8332-3-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2204181417370.915916@ubuntu-linux-20-04-desktop> <6f2a970e-36b4-b2d4-a0ee-04f3ab31b985@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1890296696-1650413593=:915916"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1890296696-1650413593=:915916
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Tue, 19 Apr 2022, Oleksandr wrote:
> On 19.04.22 00:41, Stefano Stabellini wrote:
> Hello Stefano
> 
> > On Fri, 8 Apr 2022, Oleksandr Tyshchenko wrote:
> > > From: Julien Grall <julien.grall@arm.com>
> > > 
> > > This patch introduces helpers to allocate Virtio MMIO params
> > > (IRQ and memory region) and create specific device node in
> > > the Guest device-tree with allocated params. In order to deal
> > > with multiple Virtio devices, reserve corresponding ranges.
> > > For now, we reserve 1MB for memory regions and 10 SPIs.
> > > 
> > > As these helpers should be used for every Virtio device attached
> > > to the Guest, call them for Virtio disk(s).
> > > 
> > > Please note, with statically allocated Virtio IRQs there is
> > > a risk of a clash with a physical IRQs of passthrough devices.
> > > For the first version, it's fine, but we should consider allocating
> > > the Virtio IRQs automatically. Thankfully, we know in advance which
> > > IRQs will be used for passthrough to be able to choose non-clashed
> > > ones.
> > > 
> > > Signed-off-by: Julien Grall <julien.grall@arm.com>
> > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > Tested-by: Jiamei Xie <Jiamei.xie@arm.com>
> > > Reviewed-by: Henry Wang <Henry.Wang@arm.com>
> > I realize that we are at v7 and I haven't reviewed this before, so I'll
> > limit my comments. I'll clarify the ones that I think are more important
> > from the one that are less important.
> 
> thank you
> 
> 
> > 
> > 
> > > ---
> > > @Jiamei, @Henry I decided to leave your T-b and R-b tags with the minor
> > > change I made, are you still happy with that?
> > > 
> > > s/if (disk->virtio)/if (disk->protocol == LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
> > > 
> > > Please note, this is a split/cleanup/hardening of Julien's PoC:
> > > "Add support for Guest IO forwarding to a device emulator"
> > > 
> > > Changes RFC -> V1:
> > >     - was squashed with:
> > >       "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct
> > > way"
> > >       "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into
> > > virtio-mmio device node"
> > >       "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT"
> > >     - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h
> > > 
> > > Changes V1 -> V2:
> > >     - update the author of a patch
> > > 
> > > Changes V2 -> V3:
> > >     - no changes
> > > 
> > > Changes V3 -> V4:
> > >     - no changes
> > > 
> > > Changes V4 -> V5:
> > >     - split the changes, change the order of the patches
> > >     - drop an extra "virtio" configuration option
> > >     - update patch description
> > >     - use CONTAINER_OF instead of own implementation
> > >     - reserve ranges for Virtio MMIO params and put them
> > >       in correct location
> > >     - create helpers to allocate Virtio MMIO params, add
> > >       corresponding sanity-сhecks
> > >     - add comment why MMIO size 0x200 is chosen
> > >     - update debug print
> > >     - drop Wei's T-b
> > > 
> > > Changes V5 -> V6:
> > >     - rebase on current staging
> > > 
> > > Changes V6 -> V7:
> > >     - rebase on current staging
> > >     - add T-b and R-b tags
> > >     - update according to the recent changes to
> > >       "libxl: Add support for Virtio disk configuration"
> > > ---
> > >   tools/libs/light/libxl_arm.c  | 131
> > > +++++++++++++++++++++++++++++++++++++++++-
> > >   xen/include/public/arch-arm.h |   7 +++
> > >   2 files changed, 136 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> > > index eef1de0..8132a47 100644
> > > --- a/tools/libs/light/libxl_arm.c
> > > +++ b/tools/libs/light/libxl_arm.c
> > > @@ -8,6 +8,56 @@
> > >   #include <assert.h>
> > >   #include <xen/device_tree_defs.h>
> > >   +/*
> > > + * There is no clear requirements for the total size of Virtio MMIO
> > > region.
> > > + * The size of control registers is 0x100 and device-specific
> > > configuration
> > > + * registers starts at the offset 0x100, however it's size depends on the
> > > device
> > > + * and the driver. Pick the biggest known size at the moment to cover
> > > most
> > > + * of the devices (also consider allowing the user to configure the size
> > > via
> > > + * config file for the one not conforming with the proposed value).
> > > + */
> > > +#define VIRTIO_MMIO_DEV_SIZE   xen_mk_ullong(0x200)
> > Actually, I don't think we need to make this generic. We only support
> > virtio-disk now and I think it is fine if this was called
> > VIRTIO_DISK_MMIO_DEV_SIZE and the size was exactly the size needed by
> > virtio-disk. When/if we support another virtio protocol we can add set
> > the appropriate size of that one as well.
> 
> I would prefer if we keep this generic, although we are going to support
> virtio-blk as the first virtio-mmio device, there is nothing disk specific in
> that value. The same value (0x200) is used
> by SW which also generates virtio-mmio device tree nodes like we do in Xen
> libxl, I am speaking about kvmtool, Qemu here.

OK
--8323329-1890296696-1650413593=:915916--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 00:24:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 00:24:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308501.524257 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngy8J-0006yx-6u; Wed, 20 Apr 2022 00:23:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308501.524257; Wed, 20 Apr 2022 00:23:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngy8J-0006yq-3s; Wed, 20 Apr 2022 00:23:47 +0000
Received: by outflank-mailman (input) for mailman id 308501;
 Wed, 20 Apr 2022 00:23:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngy8H-0006yk-MV
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 00:23:45 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 223c8625-c040-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 02:23:43 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4EB71B815A1;
 Wed, 20 Apr 2022 00:23:42 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E10DC385A7;
 Wed, 20 Apr 2022 00:23:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 223c8625-c040-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650414221;
	bh=aTlM2Tp8RNtiGc5s4RUzm0VyJsCB1Pdx2yfO4cSCkdc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=tfupncDT0EfvO8f++UYSaFQrKMOzuqvCcrXXHy3SpGd7juEWTG4XFNQJORuBF3upn
	 GTMddd7Y5y2fFufNEFcH4j4BL4JI/aqzp8egM0yZ47KZYFjiOZw7p00G/hJP1N3ofB
	 ZvQitQoiSPjasTUwbirwIx+uIDRhABEsNPZhHEBIqW/gmTP+Vh0feQTzvOL1ZLksdZ
	 yaGBY+od6Nem/JBq4HAeRXOv2Oaz8Oj+JqvheIGVy8l8g2W8Mv4GPeBcoo/q8zGZZE
	 Osdo5mtijkzRKUtdnWM2P5ZqCXh/Rinoi/0+gXegn9qAhe8G9M0c/xeT4IxPXPTwjx
	 xr5CBnUsA3jvQ==
Date: Tue, 19 Apr 2022 17:23:40 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr <olekstysh@gmail.com>
cc: Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Christoph Hellwig <hch@infradead.org>, xen-devel@lists.xenproject.org, 
    linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Julien Grall <julien@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
In-Reply-To: <5afb9e61-4164-9cc9-278a-911fc21f4f6c@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204191717020.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-7-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop> <YlpdBHKT1bYzZe2e@infradead.org> <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
 <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop> <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com> <b68163be-ad43-7773-22ff-e83191886626@suse.com> <5afb9e61-4164-9cc9-278a-911fc21f4f6c@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-65868541-1650414142=:915916"
Content-ID: <alpine.DEB.2.22.394.2204191723180.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-65868541-1650414142=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204191723181.915916@ubuntu-linux-20-04-desktop>

On Tue, 19 Apr 2022, Oleksandr wrote:
> On 19.04.22 17:48, Juergen Gross wrote:
> > On 19.04.22 14:17, Oleksandr wrote:
> > > 
> > > Hello Stefano, Juergen
> > > 
> > > 
> > > On 18.04.22 22:11, Stefano Stabellini wrote:
> > > > On Mon, 18 Apr 2022, Oleksandr wrote:
> > > > > On 16.04.22 09:07, Christoph Hellwig wrote:
> > > > > 
> > > > > Hello Christoph
> > > > > 
> > > > > > On Fri, Apr 15, 2022 at 03:02:45PM -0700, Stefano Stabellini wrote:
> > > > > > > This makes sense overall. Considering that the swiotlb-xen case
> > > > > > > and the
> > > > > > > virtio case are mutually exclusive, I would write it like this:
> > > > > > Curious question:  Why can't the same grant scheme also be used for
> > > > > > non-virtio devices?  I really hate having virtio hooks in the arch
> > > > > > dma code.  Why can't Xen just say in DT/ACPI that grants can be used
> > > > > > for a given device?
> > > > [...]
> > > > 
> > > > > This patch series tries to make things work with "virtio" devices in
> > > > > Xen
> > > > > system without introducing any modifications to code under
> > > > > drivers/virtio.
> > > > 
> > > > Actually, I think Christoph has a point.
> > > > 
> > > > There is nothing inherently virtio specific in this patch series or in
> > > > the "xen,dev-domid" device tree binding.
> > > 
> > > 
> > > Although the main intention of this series was to enable using virtio
> > > devices in Xen guests, I agree that nothing in new DMA ops layer
> > > (xen-virtio.c) is virtio specific (at least at the moment). Regarding the
> > > whole patch series I am not quite sure, as it uses
> > > arch_has_restricted_virtio_memory_access(). >
> > > >   Assuming a given device is
> > > > emulated by a Xen backend, it could be used with grants as well.
> > > > 
> > > > For instance, we could provide an emulated e1000 NIC with a
> > > > "xen,dev-domid" property in device tree. Linux could use grants with it
> > > > and the backend could map the grants. It would work the same way as
> > > > virtio-net/block/etc. Passthrough devices wouldn't have the
> > > > "xen,dev-domid" property, so no problems.
> > > > 
> > > > So I think we could easily generalize this work and expand it to any
> > > > device. We just need to hook on the "xen,dev-domid" device tree
> > > > property.
> > > > 
> > > > I think it is just a matter of:
> > > > - remove the "virtio,mmio" check from xen_is_virtio_device
> > > > - rename xen_is_virtio_device to something more generic, like
> > > >    xen_is_grants_device
> > 
> > xen_is_grants_dma_device, please. Normal Xen PV devices are covered by
> > grants, too, and I'd like to avoid the confusion arising from this.
> 
> 
> yes, this definitely makes sense as we need to distinguish
> 
> 
> > 
> > 
> > > > - rename xen_virtio_setup_dma_ops to something more generic, like
> > > >    xen_grants_setup_dma_ops
> > > > 
> > > > And that's pretty much it.
> > > 
> > > + likely renaming everything in that patch series not to mention virtio
> > > (mostly related to xen-virtio.c internals).
> > > 
> > > 
> > > Stefano, thank you for clarifying Christoph's point.
> > > 
> > > Well, I am not against going this direction. Could we please make a
> > > decision on this? @Juergen, what is your opinion?
> > 
> > Yes, why not.
> 
> 
> ok, thank you for confirming.
> 
> 
> > 
> > 
> > Maybe rename xen-virtio.c to grant-dma.c?
> 
> 
> Personally I don't mind.
> 
> 
> > 
> > I'd keep the XEN_VIRTIO related config option, as this will be the normal
> > use
> > case. grant-dma.c should be covered by a new hidden config option
> > XEN_GRANT_DMA
> > selected by XEN_VIRTIO.
> 
> 
> I got it, ok
> 
> 
> > 
> > 
> > CONFIG_XEN_VIRTIO should still guard
> > xen_has_restricted_virtio_memory_access().
> 
> 
> ok
> 
> 
> So a few questions to clarify:
> 
> 1. What is the best place to keep "xen,dev-domid" binding's description now? I
> think that proposed in current series place
> (Documentation/devicetree/bindings/virtio/) is not good fit now.

I would probably add it to the existing
Documentation/devicetree/bindings/arm/xen.txt.


> 2. I assume the logic in the current patch will remain the same, I mean we
> will still assign Xen grant DMA ops from xen_setup_dma_ops() here?

Yes I think so
--8323329-65868541-1650414142=:915916--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 00:25:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 00:25:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308505.524268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngy9x-0007Y7-Ix; Wed, 20 Apr 2022 00:25:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308505.524268; Wed, 20 Apr 2022 00:25:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngy9x-0007Y0-Fk; Wed, 20 Apr 2022 00:25:29 +0000
Received: by outflank-mailman (input) for mailman id 308505;
 Wed, 20 Apr 2022 00:25:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngy9w-0007Xr-Cb
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 00:25:28 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5fa96b40-c040-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 02:25:26 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 3E09FCE1AC1;
 Wed, 20 Apr 2022 00:25:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1940AC385A5;
 Wed, 20 Apr 2022 00:25:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fa96b40-c040-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650414320;
	bh=Iy+kAeZv1ZtQ8L2MtESntcdoy5vtuelI++Igl50uL4w=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=bOBJGvFtc/9tb3BpTwMLGlkDz9lHVOZrQVvyqmW2SKGeo/TYh85uPLdjkGqW+LaZU
	 ayTVBYVwH+S/0/IMHtjIwlLQBR79ZcdVYisjdYc34qOgTxnIQPbCEApPZBz/coNeT9
	 2JlQSv4fGfJNKX/XfrOACdDpa7H08aquDgHGtVcuZBMRWUqW5+x++wh8kWL22gFNi5
	 5fHHOVXgsDt66clxT9jLJNv5E/O2qFsB67FqXCU9QA0KRu7vA8spMYndR6a17UzWK9
	 RzdwbLovWnmCTuF/0KDzwiTp3VHFcDXx9NliXchNX17RojqIRZ7FHazgdTQn9TPHAe
	 3Rm/hELufCFAQ==
Date: Tue, 19 Apr 2022 17:25:20 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <Rahul.Singh@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/evtchn: Add design for static event channel signaling
 for domUs..
In-Reply-To: <076C6D09-C0DA-41BD-84CA-AD595B5AF0A2@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204191725080.915916@ubuntu-linux-20-04-desktop>
References: <4836304496e6fbbea41348ed8cc9fcf6b0f3e893.1648049827.git.rahul.singh@arm.com> <alpine.DEB.2.22.394.2204081649370.3066615@ubuntu-linux-20-04-desktop> <alpine.DEB.2.22.394.2204081837410.3066615@ubuntu-linux-20-04-desktop> <D24074F6-E6CF-440A-9E9B-A10783C273D7@arm.com>
 <alpine.DEB.2.22.394.2204131657200.3066615@ubuntu-linux-20-04-desktop> <076C6D09-C0DA-41BD-84CA-AD595B5AF0A2@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 19 Apr 2022, Rahul Singh wrote:
> > On 14 Apr 2022, at 2:14 am, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > On Mon, 11 Apr 2022, Bertrand Marquis wrote:
> >> What you mention here is actually combining 2 different solutions inside
> >> Xen to build a custom communication solution.
> >> My assumption here is that the user will actually create the device tree
> >> nodes he wants to do that and we should not create guest node entries
> >> as it would enforce some design.
> >> 
> >> If everything can be statically defined for Xen then the user can also
> >> statically define node entries inside his guest to make use of the events
> >> and the shared memories.
> >> 
> >> For example one might need more than one event to build a communication
> >> system, or more than one shared memory or could build something
> >> communicating with multiple guest thus requiring even more events and
> >> shared memories.
> > 
> > Hi Bertrand, Rahul,
> > 
> > If the guests are allowed some level of dynamic discovery, this feature
> > is not needed. They can discover the shared memory location from the
> > domU device tree, then proceed to allocate evtchns as needed and tell
> > the other end the evtchn numbers over shared memory. I already have an
> > example of it here:
> > 
> > https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/2251030537/Xen+Shared+Memory+and+Interrupts+Between+VMs
> > 
> > What if the guest doesn't support device tree at runtime, like baremetal
> > or Zephyr? The shared memory address can be hardcoded or generated from
> > device tree at build time. That's no problem. Then, the event channels
> > can still be allocated at runtime and passed to the other end over
> > shared memory. That's what the example on the wikipage does.
> > 
> > 
> > When are static event channels actually useful? When the application
> > cannot allocate the event channels at runtime at all. The reason for the
> > restriction could be related to safety (no dynamic allocations at
> > runtime) or convenience (everything else is fully static, why should the
> > event channel numbers be dynamic?)
> > 
> > Given the above, I can see why there is no need to describe the static
> > event channel info in the domU device tree: static event channels are
> > only useful in fully static configurations, and in those configurations
> > the domU device tree dynamically generated by Xen is not needed. I can
> > see where you are coming from.
> > 
> > 
> > The workflow that we have been trying to enable with the System Device
> > Tree effort (System Device Tree is similar to a normal Device Tree plus
> > the xen,domains nodes) is the following:
> > 
> > S-DT ---[lopper]---> Linux DT
> >                L--> Zephyr DT ---[Zephyr build]---> Zephyr .h files
> > 
> > S-DT contains all the needed information for both the regular Linux DT
> > generation and also the Zephyr/RTOS/baremetal header files generation,
> > that happens at build time.
> > 
> > S-DT is not the same as the Xen device tree, but so far it has been
> > conceptually and practically similar. I always imagine that the bindings
> > we have in Xen we'll also have corresponding bindings in System Device
> > Tree.
> > 
> > For this workflow to work S-DT needs all the info so that both Linux DT
> > and Zephyr DT and Zephyr .h files can be generated.
> > 
> > Does this proposal contain enough information so that Zephyr .h files
> > could be statically generated with the event channel numbers and static
> > shared memory regions addresses?
> > 
> > I am not sure. Maybe not?
> > 
> > 
> > It is possible that the shared memory usage is so application specific
> > that there is no point in even talking about it. But I think that
> > introducing a simple bundle of both event channels and shared memory
> > would help a lot.
> > 
> > Something like the following in the Xen device tree would be enough to
> > specify an arbitrary number of event channels connected with the same
> > domains sharing the memory region.
> > 
> > It looks like that if we did the below, we would carry a lot more useful
> > information compared to the original proposal alone. We could add a
> > similar xen,notificaiton property to the domU reserved-memory region in
> > device tree generated by Xen for consistency, so that everything
> > available to the domU is described fully in device tree.
> > 
> > 
> >    domU1 {
> >        compatible = "xen,domain";
> > 
> >        /* one sub-node per local event channel */
> >        ec1: evtchn@1 {
> >            compatible = "xen,evtchn-v1";
> >            /* local-evtchn link-to-foreign-evtchn */
> >            xen,evtchn = <0x1 &ec3>
> >        };
> >        ec2: evtchn@2 {
> >            compatible = "xen,evtchn-v1";
> >            xen,evtchn = <0x2 &ec4>
> >        };
> >        /*
> >         * shared memory region between DomU1 and DomU2.
> >         */
> >        domU1-shared-mem@50000000 {
> >            compatible = "xen,domain-shared-memory-v1";
> >            xen,shm-id = <0x1>;
> >            xen,shared-mem = <0x50000000 0x20000000 0x60000000>;
> >            /* this is new */
> >            xen,notification = <&ec1 &ec2>;
> >        }
> >    };
> > 
> >    domU2 {
> >        compatible = "xen,domain";
> > 
> >        /* one sub-node per local event channel */
> >        ec3: evtchn@3 {
> >            compatible = "xen,evtchn-v1";
> >            /* local-evtchn link-to-foreign-evtchn */
> >            xen,evtchn = <0x3 &ec1>
> >        };
> >        ec4: evtchn@4 {
> >            compatible = "xen,evtchn-v1";
> >            xen,evtchn = <0x4 &ec2>
> >        };
> >        /*
> >         * shared memory region between domU1 and domU2.
> >         */
> >        domU2-shared-mem@50000000 {
> >            compatible = "xen,domain-shared-memory-v1";
> >            xen,shm-id = <0x1>;
> >            xen,shared-mem = <0x50000000 0x20000000 0x70000000>;
> >            /* this is new */
> >            xen,notification = <&ec3 &ec4>;
> >        }
> >    };
> > 
> > 
> > 
> > The good thing about this is that:
> > 
> > - it is very flexible
> > - nothing to do in this series, except switching to the
> >  one-subnode-per-evtchn model, which we called 2) in the previous email
> > - there were good reasons to use the one-subnode-per-evtchn model anyway
> > - the xen,notification property can be added later without issues, after Penny's series
> > 
> > There are a couple of ways to implement the xen,notification property
> > but we don't need to discuss them now.
> > 
> > 
> > Short Summary
> > ------------
> > I think it is fine to only introduce the Xen device tree binding for
> > static event channels without domU binding, but I prefer if we switched
> > to using proposal 2) "one subnode per event channel".
> 
> Thanks for detailed explanation.I just did the basic implementation of the 2) proposal and
> it looks simple and not very complex as I thought earlier.Therefore I am ok to switch to proposal 2).
> 
> If everyone is ok with the 2) proposal I will send the v2 of design doc after fixing all the comments.

That's great, thank you Rahul!


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 00:31:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 00:31:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308512.524278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngyFe-0000cx-A0; Wed, 20 Apr 2022 00:31:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308512.524278; Wed, 20 Apr 2022 00:31:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngyFe-0000cq-73; Wed, 20 Apr 2022 00:31:22 +0000
Received: by outflank-mailman (input) for mailman id 308512;
 Wed, 20 Apr 2022 00:31:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngyFc-0000cc-Vh; Wed, 20 Apr 2022 00:31:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngyFc-0003h1-Sn; Wed, 20 Apr 2022 00:31:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngyFc-0007mW-H7; Wed, 20 Apr 2022 00:31:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngyFc-0006Er-Gf; Wed, 20 Apr 2022 00:31:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+XCeRLV5tZAjzl9bJ/rEtEDN9DzZwWp/pYXEz1xLDF4=; b=SOOo+/btbqfASZ0TEEXkVQW668
	8jss/Qc0xF2QMDyq86gKcpcFWkpAuCZMOBoTj3r5RKOE7KLLZMFVZ6hcYInYLGqSbZFzPiYlD+D/6
	HcXUAD/wud7UFnIwaMscjf6Zk90tU91bjPJ1m67Xk3ErL1VHVATRmHduhwFlYvow2/WI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169549-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169549: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 00:31:20 +0000

flight 169549 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169549/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   49 days  511 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 00:34:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 00:34:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308522.524290 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngyJ6-0001O7-QO; Wed, 20 Apr 2022 00:34:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308522.524290; Wed, 20 Apr 2022 00:34:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngyJ6-0001O0-NO; Wed, 20 Apr 2022 00:34:56 +0000
Received: by outflank-mailman (input) for mailman id 308522;
 Wed, 20 Apr 2022 00:34:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngyJ5-0001Nu-F9
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 00:34:55 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b258ad80-c041-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 02:34:54 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 9BED1B811C7;
 Wed, 20 Apr 2022 00:34:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9548C385A7;
 Wed, 20 Apr 2022 00:34:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b258ad80-c041-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650414892;
	bh=iRq8BXl9iMFT+K6WlY9Njhg/Dz0k3u7vlWsm6hS6vHs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=D4Znh4nc2FtQ0RWdPtMVVElHDQanv0jzV6kykOdphWzAiYQudMwSJO+b1NW7PcRRl
	 1/oLcM4fpyYqPdAiu+7hm6ZLfC4KbHcguzvGs3S04cfaGo8Osncc4WcE3XoDODTYQ8
	 Y13Ev4aQ9/xFOeg/xHP4r4o8jFxpPvIbUmyvcjCom+SlEQGpxAurw3zTZH/Wokdpmo
	 csDG9VcFZrhSFrbEg0+1QZGXmXN8nzTybCGr+DHaa3O0qs598FVuy9m3SrlqQjRuOZ
	 PlHGrse8KPAozz8mQDAwqrXy2uq9G0Kp9Espp5zkhymvJiwjHTnKiY8egI7XQL3BR/
	 4vUJvKLwpLXig==
Date: Tue, 19 Apr 2022 17:34:51 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: Make use of DT_MATCH_TIMER in make_timer_node
In-Reply-To: <c2030fd0-8aed-6a68-e275-77d22f972dfc@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204191729120.915916@ubuntu-linux-20-04-desktop>
References: <20220414095843.102305-1-michal.orzel@arm.com> <alpine.DEB.2.22.394.2204151609140.915916@ubuntu-linux-20-04-desktop> <c2030fd0-8aed-6a68-e275-77d22f972dfc@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 19 Apr 2022, Michal Orzel wrote:
> Hi Stefano,
> 
> On 16.04.2022 01:10, Stefano Stabellini wrote:
> > On Thu, 14 Apr 2022, Michal Orzel wrote:
> >> DT_MATCH_TIMER stores the compatible timer ids and as such should be
> >> used in all the places where we need to refer to them. make_timer_node
> >> explicitly lists the same ids as the ones defined in DT_MATCH_TIMER so
> >> make use of this macro instead.
> >>
> >> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> > 
> > This is a good cleanup, thanks! time.h is not currently included by
> > domain_build.c, I think we should add:
> > 
> > #include <asm/time.h>
> > 
> > to domain_build.c 
> > 
> asm/time.h is included by xen/time.h which is included by xen/irq.h.
> That is why there is no build failure and the patch itself is correct.
> 
> Furthermore DT_MATCH_TIMER is already used in domain_build.c (handle_node)
> together with other constructs like TIMER_PHYS_SECURE_PPI defined in asm/time.h.

OK, fair point. We should disentangle the headers at some point but
given that this patch is not making anything worse:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

and committed


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 00:40:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 00:40:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308527.524301 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngyO6-0002i8-Ek; Wed, 20 Apr 2022 00:40:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308527.524301; Wed, 20 Apr 2022 00:40:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngyO6-0002i1-9x; Wed, 20 Apr 2022 00:40:06 +0000
Received: by outflank-mailman (input) for mailman id 308527;
 Wed, 20 Apr 2022 00:40:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngyO5-0002dl-FI
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 00:40:05 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6afdcca8-c042-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 02:40:04 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2B6DF6133F;
 Wed, 20 Apr 2022 00:40:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0D76C385A7;
 Wed, 20 Apr 2022 00:40:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6afdcca8-c042-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650415202;
	bh=K2FBWb/8nE/lrSgzAocZDyO2NmBIVVu0RX2Sv80eftE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ON4tfGIgtNrqxAAAoaI2XD3TCWE3jaAADV9GnNhEk68rY38NhpLmRvYjTDo/Y2H3k
	 Wsy0dmK2LXspkv4+0w13Co8c5aTxD7em0joHaO6VQfYo8/7GRDKe2twpRcu5BN1vkk
	 ZgRxLR5WM00eaHwoN5QrIuYYAYP8OzGcdNPJSHbCo0iXN/rPRZMwxhZPPbH+EOaSf6
	 9YNqJKT9in5zv754tD+eV3lwDnO3c4/qpnnt5GiimPUvFfPPoA+AcZpsEoqaP1g7U1
	 jV6cy4eJyY8O30H5pcZnp6cnAhMVxWuBc50JpcY1Xt5yrT+iKsmuAZItPS2qqvKwSx
	 Eyn/1dpF6i1Yw==
Date: Tue, 19 Apr 2022 17:40:01 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
cc: sstabellini@kernel.org, julien@xen.org, Volodymyr_Babchuk@epam.com, 
    bertrand.marquis@arm.com, andrew.cooper3@citrix.com, 
    george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, 
    xen-devel@lists.xenproject.org, van.freenix@gmail.com, 
    michal.orzel@arm.com, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V6 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial
 support
In-Reply-To: <20220419043927.23542-1-peng.fan@oss.nxp.com>
Message-ID: <alpine.DEB.2.22.394.2204191739460.915916@ubuntu-linux-20-04-desktop>
References: <20220419043927.23542-1-peng.fan@oss.nxp.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

I committed both patches, thanks!

On Tue, 19 Apr 2022, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> V6:
>  Fix a stale variable check per Stefano's comments.
> 
> V5:
>  Align code
>  drop early_uart_init
> 
> V4:
>  Wrong v3 version, some BIT definition are mixed in patch 1,2. 
> 
> V3:
>  Addressed Michal's comments.
>  Add Henry's T-b
> 
> V2:
>  Per Julien's comments, fix coding style issue, drop unneeded code
> 
> Add i.MX lpuart driver and i.MX8QM platform support.
>  - lpuart is the uart IP used in i.MX8QM/QXP/93.
>  - Very basic i.MX8QM platform support.
> 
> Peng Fan (2):
>   xen/arm: Add i.MX lpuart driver
>   xen/arm: Add i.MX lpuart early printk support
> 
>  xen/arch/arm/Kconfig.debug              |  14 ++
>  xen/arch/arm/arm64/debug-imx-lpuart.inc |  48 +++++
>  xen/arch/arm/include/asm/imx-lpuart.h   |  64 ++++++
>  xen/drivers/char/Kconfig                |   7 +
>  xen/drivers/char/Makefile               |   1 +
>  xen/drivers/char/imx-lpuart.c           | 275 ++++++++++++++++++++++++
>  6 files changed, 409 insertions(+)
>  create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
>  create mode 100644 xen/arch/arm/include/asm/imx-lpuart.h
>  create mode 100644 xen/drivers/char/imx-lpuart.c
> 
> -- 
> 2.35.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 01:49:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 01:49:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308537.524324 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngzTB-000892-N2; Wed, 20 Apr 2022 01:49:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308537.524324; Wed, 20 Apr 2022 01:49:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngzTB-00088b-Ff; Wed, 20 Apr 2022 01:49:25 +0000
Received: by outflank-mailman (input) for mailman id 308537;
 Wed, 20 Apr 2022 01:49:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZnnQ=U6=gmail.com=linmq006@srs-se1.protection.inumbo.net>)
 id 1ngzT9-00088V-Ky
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 01:49:23 +0000
Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com
 [2607:f8b0:4864:20::536])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18b2eeb9-c04c-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 03:49:21 +0200 (CEST)
Received: by mail-pg1-x536.google.com with SMTP id 203so194238pgb.3
 for <xen-devel@lists.xenproject.org>; Tue, 19 Apr 2022 18:49:21 -0700 (PDT)
Received: from localhost.localdomain ([159.226.95.43])
 by smtp.googlemail.com with ESMTPSA id
 x20-20020aa79574000000b005061f4782c5sm17543755pfq.183.2022.04.19.18.49.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Apr 2022 18:49:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18b2eeb9-c04c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=/UuWmXAeK3wDg34COXqd7JHzyxxdodWHUXeYP3t+DVM=;
        b=jNy+tVOlKTuaYase1uWbsaybUMzAQOYmfdHlgLhP/+zTF8xCAUk/rP1NoLEGiss6Ci
         8qkBAnee5LdixG9PAXR78Oh8mQtv1kvTWP7aD6/ans2MUS8VItAiXi29L6eVczGyZ5Gk
         O9Qyer2uqerzeN7dx4kFdxCkpGRACMwyQmfXq9KmBIv5s6TxXgXU3PpOziZzKuX5PLik
         9ciG9eSVuwEK8pTOA4H+l7gR4xJegCf7bUg2hDXyi8H6nGdC/fypU7slc7C2UTtKBBa4
         naCTHZbfiuCV7cDhsc64yGZCVU7gLq8M7oy4C2pkMiGKaNe3L6SmTIuAh9u21UEuE1rU
         2q+g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=/UuWmXAeK3wDg34COXqd7JHzyxxdodWHUXeYP3t+DVM=;
        b=HmPj6xp0x+181KhOdRq4W7bPnLMM48aZ3rT31ZxDzEE4xUOY1yg0mhjnDRZQxbzRGq
         nTI0Nd+DnIcDDows5pnSE97HmT3KBQFQEshxdRCxDL66DlgvWeA1ZCwd4LB1rzyJ0gOJ
         5Pbv13AZdn+fHqdHGXFhIIlLDlgx6DA1vhu5IHoqrM7e0PPPrOgzO0pusyWEqoKeTWOC
         JM56zfByFPcpaz2YmGbBninrJDtDYlJuVik+EwA6XEYgm+MF2t49kyKBvRC+EvaPQQ9w
         qWHMHj5hYLy1iFszpgdYD4IVPzZMYlZnbnyfKnXuul30xoglnk3zVQa7j3BG6O1iTJaw
         Gfww==
X-Gm-Message-State: AOAM533aw0ACPaTS9wvwJlwzgq9CnnrUJqF9MkSHe0Vgsq+C5Lw7S1tA
	0ZsUym/WQ2/7QkASe6eWsF8=
X-Google-Smtp-Source: ABdhPJw58IDvs8PX3F7lrr3iHelhvA0R312SWs14z9YL08C1HaVgt0xmXyKbe63xjiK6qsGJlYlidA==
X-Received: by 2002:a05:6a00:2489:b0:50a:754c:c557 with SMTP id c9-20020a056a00248900b0050a754cc557mr13590297pfv.37.1650419359982;
        Tue, 19 Apr 2022 18:49:19 -0700 (PDT)
From: Miaoqian Lin <linmq006@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Shannon Zhao <shannon.zhao@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Julien Grall <julien.grall@arm.com>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: linmq006@gmail.com
Subject: [PATCH v2] arm/xen: Fix some refcount leaks
Date: Wed, 20 Apr 2022 01:49:13 +0000
Message-Id: <20220420014913.2586-1-linmq006@gmail.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220406021905.GA30436@8345e2a12d0c>
References: <20220406021905.GA30436@8345e2a12d0c>

The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Fixes: 9b08aaa3199a ("ARM: XEN: Move xen_early_init() before efi_init()")
Fixes: b2371587fe0c ("arm/xen: Read extended regions from DT and init Xen resource")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
changes in v2:
- call of_node_put in non-error path in xen_dt_guest_init
- fix same refcount leak error in arch_xen_unpopulated_init
---
 arch/arm/xen/enlighten.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index ec5b082f3de6..07eb69f9e7df 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -337,12 +337,15 @@ int __init arch_xen_unpopulated_init(struct resource **res)
 
 	if (!nr_reg) {
 		pr_err("No extended regions are found\n");
+		of_node_put(np);
 		return -EINVAL;
 	}
 
 	regs = kcalloc(nr_reg, sizeof(*regs), GFP_KERNEL);
-	if (!regs)
+	if (!regs) {
+		of_node_put(np);
 		return -ENOMEM;
+	}
 
 	/*
 	 * Create resource from extended regions provided by the hypervisor to be
@@ -403,8 +406,8 @@ int __init arch_xen_unpopulated_init(struct resource **res)
 	*res = &xen_resource;
 
 err:
+	of_node_put(np);
 	kfree(regs);
-
 	return rc;
 }
 #endif
@@ -424,8 +427,10 @@ static void __init xen_dt_guest_init(void)
 
 	if (of_address_to_resource(xen_node, GRANT_TABLE_INDEX, &res)) {
 		pr_err("Xen grant table region is not found\n");
+		of_node_put(xen_node);
 		return;
 	}
+	of_node_put(xen_node);
 	xen_grant_frames = res.start;
 }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 01:49:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 01:49:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308539.524335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngzTU-0008W2-T5; Wed, 20 Apr 2022 01:49:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308539.524335; Wed, 20 Apr 2022 01:49:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngzTU-0008Vt-Ng; Wed, 20 Apr 2022 01:49:44 +0000
Received: by outflank-mailman (input) for mailman id 308539;
 Wed, 20 Apr 2022 01:49:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ngzTS-0008S8-Ot
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 01:49:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 23c76669-c04c-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 03:49:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 84BD0B81244;
 Wed, 20 Apr 2022 01:49:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5E3AC385A7;
 Wed, 20 Apr 2022 01:49:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23c76669-c04c-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650419377;
	bh=Gqe2L2FMfeVpyxTF4JZTLi9Se5FD0uzshVLOLZmituY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=R5fL8aDQQkaSxCcG86xOizgjhYZCN1JJtFw1+uIvDbCt1SZraVhy4fKF3N2z1Jlr7
	 Hl1b0NcLkSjmf4cYopIt+CcDLJ6nn+wpKPyUMFfFhl5bvYB6+2jk18F8BJ8qX30duo
	 Bou+l9JnoDQlfFPUM19KHdyr7zAqeZcxllSe9r9aoO4kuv8llLAza099RvFIh4sUCD
	 mKFSe/HzEnOsrdU0OddNoFxg+TScGVLptvMhJPzT9yyE/kUcQ7QAsF9E4xUN4Rlg/D
	 w1KpEXQhYfp/NnMx4eG3nieLiFGYlEIuurg3JY+Lkq21JGGEjNOuNkS8N9OjUSaWnJ
	 iIMc7q/h23Lvg==
Date: Tue, 19 Apr 2022 18:49:35 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <Wei.Chen@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "julien@xen.org" <julien@xen.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Penny Zheng <Penny.Zheng@arm.com>
Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftB
In-Reply-To: <PAXPR08MB7420786607A15FA5027BF4579EF29@PAXPR08MB7420.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2204191752390.915916@ubuntu-linux-20-04-desktop>
References: <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com> <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop> <PAXPR08MB7420786607A15FA5027BF4579EF29@PAXPR08MB7420.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 19 Apr 2022, Wei Chen wrote:
> > > ### 3.2. Xen Event Channel Support
> > >     In Current RFC patches we haven't enabled the event channel support.
> > >     But I think it's good opportunity to do some discussion in advanced.
> > >     On Armv8-R, all VMs are native direct-map, because there is no
> > stage2
> > >     MMU translation. Current event channel implementation depends on
> > some
> > >     shared pages between Xen and guest: `shared_info` and per-cpu
> > `vcpu_info`.
> > >
> > >     For `shared_info`, in current implementation, Xen will allocate a
> > page
> > >     from heap for `shared_info` to store initial meta data. When guest
> > is
> > >     trying to setup `shared_info`, it will allocate a free gfn and use a
> > >     hypercall to setup P2M mapping between gfn and `shared_info`.
> > >
> > >     For direct-mapping VM, this will break the direct-mapping concept.
> > >     And on an MPU based system, like Armv8-R system, this operation will
> > >     be very unfriendly. Xen need to pop `shared_info` page from Xen heap
> > >     and insert it to VM P2M pages. If this page is in the middle of
> > >     Xen heap, this means Xen need to split current heap and use extra
> > >     MPU regions. Also for the P2M part, this page is unlikely to form
> > >     a new continuous memory region with the existing p2m pages, and Xen
> > >     is likely to need another additional MPU region to set it up, which
> > >     is obviously a waste for limited MPU regions. And This kind of
> > dynamic
> > >     is quite hard to imagine on an MPU system.
> > 
> > Yeah, it doesn't make any sense for MPU systems
> > 
> > 
> > >     For `vcpu_info`, in current implementation, Xen will store
> > `vcpu_info`
> > >     meta data for all vCPUs in `shared_info`. When guest is trying to
> > setup
> > >     `vcpu_info`, it will allocate memory for `vcpu_info` from guest side.
> > >     And then guest will use hypercall to copy meta data from
> > `shared_info`
> > >     to guest page. After that both Xen `vcpu_info` and guest `vcpu_info`
> > >     are pointed to the same page that allocated by guest.
> > >
> > >     This implementation has serval benifits:
> > >     1. There is no waste memory. No extra memory will be allocated from
> > Xen heap.
> > >     2. There is no P2M remap. This will not break the direct-mapping,
> > and
> > >        is MPU system friendly.
> > >     So, on Armv8-R system, we can still keep current implementation for
> > >     per-cpu `vcpu_info`.
> > >
> > >     So, our proposal is that, can we reuse current implementation idea
> > of
> > >     `vcpu_info` for `shared_info`? We still allocate one page for
> > >     `d->shared_info` at domain construction for holding some initial
> > meta-data,
> > >     using alloc_domheap_pages instead of alloc_xenheap_pages and
> > >     share_xen_page_with_guest. And when guest allocates a page for
> > >     `shared_info` and use hypercall to setup it,  We copy the initial
> > data from
> > >     `d->shared_info` to it. And after copy we can update `d-
> > >shared_info` to point
> > >     to guest allocated 'shared_info' page. In this case, we don't have
> > to think
> > >     about the fragmentation of Xen heap and p2m and the extra MPU
> > regions.
> > 
> > Yes, I think that would work.
> > 
> > Also I think it should be possible to get rid of the initial
> > d->shared_info allocation in Xen, given that d->shared_info is for the
> > benefit of the guest and the guest cannot access it until it makes the
> > XENMAPSPACE_shared_info hypercall.
> > 
> 
> While we're working on event channel PoC work on Xen Armv8-R, we found
> another issue after we dropped d->shared_info allocation in Xen. Both
> shared_info and vcpu_info are allocated from Guest in runtime. That
> means the addresses of shared_info and vcpu_info are random. For MMU
> system, this is OK, because Xen has a full view of system memory in
> runtime. But for MPU system, the situation becomes a little tricky.
> We have to setup extra MPU regions for remote domains' shared_info
> and vcpu_info in event channel hypercall runtime. That's because
> in current Xen hypercall concept, hypercall will not cause vCPU
> context switch. When hypercall trap to EL2, it will keep vCPU's
> P2M view. For MMU system, we have vttbr_el2 for vCPU P2M view and
> ttbr_el2 for Xen view. So in EL2 Xen has full permissions to access
> any memory it wants. But for MPU system, we only have one EL2 MPU.
> Before entering guest, Xen will setup vCPU P2M view in EL2 MPU.
> In this case, when system entry EL2 through hypercall, the EL2
> MPU still keeps current vCPU P2M view and with Xen essential
> memory (code, data, heap) access permissions. But current EL2 MPU
> doesn't have the access permissions for EL2 to access other
> domain's memory. For an event channel hypercall, if we want to
> update the pending bitmap in remote domain's vcpu_info, it will
> cause a dataabort in EL2. To solve this dataabort, we may have
> two methods:
> 1. Map remote domain's whole memory or pages for shared_info +
>    vcpu_info in EL2 MPU temporarily for hypercall to update
>    pending bits or other accesses.
> 
>    This method doesn't need to do context switch for EL2 MPU,
>    But this method has some disadvantages:
>    1. We have to reserve MPU regions for hypercall.
>    2. Different hypercall may have different reservation of
>       MPU regions.
>    3. We have to handle hypercall one by one for existed and
>       new in future.
>
> 2. Switch to Xen's memory view in EL2 MPU when trap from EL1 to
>    EL2. In this case, Xen will have full memory access permissions
>    to update pending bits in EL2. This only changes the EL2 MPU
>    context, does not need to do vCPU context switch. Because the
>    trapped vCPU will be used in the full flow of hypercall. After
>    the hypercall, before returning to EL2, the EL2 MPU will switch
>    to scheduled vCPU' P2M view.
>    This method needs to do EL2 MPU context switch, but:
>    1. We don't need to reserve MPU regions for Xen's memory view.
>       (Xen's memory view has been setup while initialization)
>    2. We don't need to handle pages' mapping in hypercall level.
>    3. Apply to other EL1 to EL2 traps, like dataabort, IRQ, etc. 


Both approach 1) and 2) are acceptable and in fact I think we'll
probably have to do a combination of both.

We don't need to do a full MPU context switch every time we enter Xen.
We can be flexible. Only when Xen needs to access another guest memory,
if the memory is not mappable using approach 1), Xen could do a full MPU
context switch. Basically, try 1) first, if it is not possible, do 2).

This also solves the problem of "other hypercalls". We can always do 2)
if we cannot do 1).

So do we need to do 1) at all? It really depends on performance data.
Not all hypercalls are made equal. Some are very rare and it is fine if
they are slow. Some hypercalls are actually on the hot path. The event
channels hypercalls are on the hot path so they need to be fast. It
makes sense to implement 1) just for event channels hypercalls if the
MPU context switch is slow.

Data would help a lot here to make a good decision. Specifically, how
much more expensive is an EL2 MPU context switch compared to add/remove
of an MPU region in nanosec or cpu cycles?


The other aspect is how many extra MPU regions do we need for each guest
to implement 1). Do we need one extra MPU region for each domU? If so, I
don't think approach 1) if feasible unless we come up with a smart
memory allocation scheme for shared_info and vcpu_info. For instance, if
shared_info and vcpu_info of all guests were part of the Xen data or
heap region, or 1 other special MPU region, then they could become
immediately accessible without need for extra mappings when switching to
EL2.

One idea is to change the interface and have Xen allocate
shared_info/vcpu_info instead of the guest and provide the address on
device tree. That way, the guest doesn't need to allocate the memory.
Xen can choose where the memory comes from and it could be allocated
from a suitable MPU region so that it becomes automatically accessible
to Xen when entering EL2 without needed a full context switch.



>    But this method introduces another security concern:
>    Giving full memory view to Xen at any EL2 runtime will cause
>    any security issue? Although Xen has done in this way in MMU
>    system already.

It wouldn't be a security issue given the current design and security
definition.


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 01:55:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 01:55:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308548.524345 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngzZ8-0001w0-Fh; Wed, 20 Apr 2022 01:55:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308548.524345; Wed, 20 Apr 2022 01:55:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngzZ8-0001vt-Cb; Wed, 20 Apr 2022 01:55:34 +0000
Received: by outflank-mailman (input) for mailman id 308548;
 Wed, 20 Apr 2022 01:55:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Vn5Q=U6=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ngzZ7-0001vn-40
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 01:55:33 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0602.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::602])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f5005c64-c04c-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 03:55:30 +0200 (CEST)
Received: from DB6PR07CA0083.eurprd07.prod.outlook.com (2603:10a6:6:2b::21) by
 AM9PR08MB6130.eurprd08.prod.outlook.com (2603:10a6:20b:2d8::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 01:55:28 +0000
Received: from DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2b:cafe::e4) by DB6PR07CA0083.outlook.office365.com
 (2603:10a6:6:2b::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Wed, 20 Apr 2022 01:55:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT026.mail.protection.outlook.com (10.152.20.159) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 20 Apr 2022 01:55:28 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Wed, 20 Apr 2022 01:55:28 +0000
Received: from 01d66172b896.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F94CD320-86B6-402A-B416-82BA2C634761.1; 
 Wed, 20 Apr 2022 01:55:21 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 01d66172b896.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 01:55:21 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by VI1PR0802MB2398.eurprd08.prod.outlook.com (2603:10a6:800:af::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 01:55:19 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 01:55:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5005c64-c04c-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VT0Zyj6iMhdTStnZmYDJbpUXMnxE8HAHQ1pHsAwbroc=;
 b=GkbNs4Jl+6b0vfH1yLj187rFTk5ir01VHJqqdClVmTYmkH9yyeKrKkCFj1Nqp3aYDkLBwCg/G8uZ/EHZjJ4/AM2Tk29LNH+VJ5JxWHCmRsimGrYURlkxz5TGUwFQhdMQCw/GkVsNLelYcPlJEVNiKFOcEhd62RkS7K4ig3Z7F4Q=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b4ccd73e9dbb3119
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fiNPWJHnjaBTkzXV8L7WPcaE2tu2MYqfdbcBgejzocQAPLLtiRg+ShRdzRaQ0I7TANG1Cz1URw2w2kqS/mJXdkTKCNHSAW2wIVRMVVpUM00IULyImv4SvHPTU0eqB83+jEbtRYBkC+PT3Y4MSzxSKgyewE2koZo0nBTwaJYzbpmQ3YscKbPb0QqXlnqUAse6SJ1hU1asFJXZXAC73YJ/KGIs+uC99pHRPizjYzjNhLWoynVw1nuRGbOxe7f0xCxmuoyJk/zW+RuJjaDPqv0/KDqbFAvJhwLmiYq10j2ZSxicsYL+xhl9zu0E3+MYel/xVbllu7qH66E9ijWVxlB+IA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VT0Zyj6iMhdTStnZmYDJbpUXMnxE8HAHQ1pHsAwbroc=;
 b=oPVHKRYqsktDVoVPGPq1asJ0YqRk1e/M7odqEshdYl45qJKVQbQhTpghsg6Nvjh85FIbi8cOF+ZBF68yTrAFsQwRX8YS0/eHwbUzryb6YDB2UyB2PQkxZu5c9NRJ7jqP7fWPvu7ddNN/P11MxzNIYgXATBB8O8aQC2yu3ZQK/X33bvil9nR0LnV9fjuw/+OONt3L4xrHS/DRkHuWKOS583OnSoSrQ6wxks4YtiO+OLSBhKRGQqI1vO9VMF+F0BaahT7Lx4j+QPR4Ngbd/wQutoEc2GvPmFOwUE1j1Kur/BzS0xZU/pWGbrK4yj4cNFy+7RqWLPeh4hGCzvjKYOjAfA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VT0Zyj6iMhdTStnZmYDJbpUXMnxE8HAHQ1pHsAwbroc=;
 b=GkbNs4Jl+6b0vfH1yLj187rFTk5ir01VHJqqdClVmTYmkH9yyeKrKkCFj1Nqp3aYDkLBwCg/G8uZ/EHZjJ4/AM2Tk29LNH+VJ5JxWHCmRsimGrYURlkxz5TGUwFQhdMQCw/GkVsNLelYcPlJEVNiKFOcEhd62RkS7K4ig3Z7F4Q=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <5e7ded0e-36f6-2a0a-4dab-30d39e649c05@arm.com>
Date: Wed, 20 Apr 2022 09:55:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: Problem creating domU guest on arm64
Content-Language: en-US
To: Marco Cacre <marco.cacre@gmail.com>, xen-devel@lists.xenproject.org
References: <CAGHctbYx6sspA__OmKyumU+WkhzEsDpLstyhRDM9Kbc696Co7Q@mail.gmail.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <CAGHctbYx6sspA__OmKyumU+WkhzEsDpLstyhRDM9Kbc696Co7Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SG3P274CA0018.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::30)
 To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 3dfdbc7b-f9ac-4657-bca3-08da2270d836
X-MS-TrafficTypeDiagnostic:
	VI1PR0802MB2398:EE_|DB5EUR03FT026:EE_|AM9PR08MB6130:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB6130DC069B48C24F01CF34DF9EF59@AM9PR08MB6130.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 /fyiE+H8JFWxjB8Srai7QXJgqprA7xA+U2RBKTXPZCJLikMQ3m4FVrEkjsbFqUMx9bGdP0a+Z/0VaBjlkRWvEs4aRu7xO8B7QrRB3hkgVQrs4jZj/He1OU6cN2WBF7ZX1JLUZieBxhcdUf0rMK8gRECf06/Iiag9VVVEL3P0z1RvNgoO9UeAiFM3K92fa2Q1nEa3kwkyk866va+pLMwlX9Bp8Q26Coh+jD9JzUGASKPev6YtEckkw635ZoeiNSGAAAbWsstr+0xKx7Ls4mled48HI8O/gGQZtN6sdHWhyXsJ/dUUEEWbvNz2bK3ZrqTmSRGf9ffhlmXRhP7miVrgDurfOiGOliZUAhsrhFx3Hy7NtrzwXYDPkOxhcVVt7t3tbmGjr4s9OweymIvuEljigGFEo8nTB5r1OL5DMMO3TbVKijPxNO5KHbHE5VlWnNazSDCdHBF5MYyLzdnfNWYl34pROLY2IMnWG2SflRHkSaxXlaIo7Yx6pQ3scYP/S2Cw24gA+h63U00znDxKmpdYQNnZgzyQELIaj11H+OWimukaCgcTgyf/a59CCSKMRheK/xMUo7Jddho9GkPNlcvoDFbxreZ7LILNScvnWv+Xt7BCjk6My7m8+VRCHUwWGfSGukhNFaXwaM07nLaetKDkNR9bajliptSwR3iZjMLw3jgdosjKr/4fSQKWqxYPemUxiuopsTgMMxQQEnYnFH271l0m56t2ho78FA9JbaNmfZUA4DYRTETTbKfrHoii1gAn
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(2616005)(8936002)(38100700002)(5660300002)(2906002)(53546011)(316002)(66556008)(186003)(6512007)(26005)(6506007)(6666004)(6486002)(66946007)(31686004)(508600001)(83380400001)(66476007)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2398
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e6242ea6-0ea4-43d3-ba5b-08da2270d244
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Xbsa5tFIM6y+ZmHPClYDMgVWKjqDKIPhnNecm1CVL1dLO0K375I5nd+7MivjfS4+6gqT5j1EEa2vebxvpSeqYzUfg73QkIWGgFLLgIqflzZ4JKULQW/KLwkSQp6KOoYnRolHkfGPau9yK34phuDY5BpBUzQgC0UEC1WqBXXQ3Bx4XFo/7yusDhFehJNiJDYGxP93JXjrpcRNwJR9R9Mxeag7FW5Pz+AHUT5pI7Q9nNpvoG8bj2L8yFDCOKnr675FSyxrwqHWkJnMcfbbXYVakjZ6NPi+w9Dgiux/YSKsMc3046RQ2l8W4WzEBC1dwaHDSaDGQWiozoDIpH9msrrw+uVEIHufa5aPFbPzj8X4ElLlMXGEsnLRJ1a15YuNOIvEWxiSB6yh30bDWUaBUcNfWWODK8Lvbo1ZoVbBcmZfrA0CWwrAVjglYhBJqGWgvyckC9JPDwhtTx/hWE5k6G55E6vVWAgrgUDgZDRqephRf3EPejgcQS1qGvIcEw0amsT/h76jRwc+hlUHxM4YhIsQpAEGrseSO1yNIQ8a1tdUItNhkiasAJoDEN0a8a/7e5v+pb16y2RGFrLzaGvQnVA0yLWFLM/FiUWEQDM8M9tQ6DUAcCbwY2kijLFzod8sUmq9bN/r5WFHSVhU9iOu6Goy30eUYzcfYLhDKa2YLLpiJGm8znxN91+xLntgPkRNOPgBYSZvLZSIMkUYfDBSEA4hKA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(336012)(8676002)(70586007)(36860700001)(53546011)(31686004)(47076005)(186003)(6512007)(82310400005)(26005)(70206006)(2616005)(356005)(2906002)(8936002)(6506007)(316002)(83380400001)(31696002)(6486002)(36756003)(86362001)(81166007)(5660300002)(6666004)(40460700003)(508600001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 01:55:28.5493
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dfdbc7b-f9ac-4657-bca3-08da2270d836
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6130

Hi Marco,

On 2022/4/15 18:56, Marco Cacre wrote:
> Hi all,
> 
> I'm facing always the same problem (described below) trying to create a 
> Xen guest domain on rockpro64 (arm64).
> 
> I have successfully built uboot, xen (4.14.4) and dom0 linux kernel with 
> xen tool stack, these two last starting from buildroot (with linux 
> kernel version 5.15.33 and xen toolstack version 4.14.4)
> 
> These are the process of Xen:
> 
> 177 root    /usr/sbin/xenwatchdogd 30 15
> 203 root    /usr/sbin/xenstored --pid-file /var/run/xen/xenstored.pid
> 208 root    /usr/sbin/xenconsoled --pid-file=/var/run/xen/xenconsoled.pid
> 214 root    /usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 -xen-attach 
> -name dom0 -nographic -M xenpv -daemonize -monitor /dev/null 
> -serial/dev/nul -parallel/dev/null -pidfile/var/run/xen/qemu-dom0.pid
> 
> and the drivers loaded as a module:
> # lsmod
> Module                  Size  Used by    Tainted: G
> xen_netback            65536  0
> xen_blkback            49152  0
> 
> Xen and dom0 Image boot up successfully, at the end:
> ================================================
>  >xl list
> Name                                        ID  Mem VCPUs State Time(s)
> Domain-0                                    0  1024    2    r-----    4000.3
> 
> # uname -a
> Linux rockpro64 5.15.33 #3 SMP PREEMPT Fri Apr 15 11:01:37 CEST 2022 
> aarch64 GNU/Linux
> ================================================
> 
> when I try to create a domU domain I have problem with disk backend, I 
> have made several attempts trying with different domU linux and I always 
> get the following error :
> 
> ================================================
> Parsing config from ./alpine_xen_domu.config
> 
> libxl: error: libxl_aoutils.c:539:async_exec_timeout: killing execution 
> of /etc/xen/scripts/block add because of timeout
> libxl: error: libxl_create.c:1608:domcreate_launch_dm: Domain 2:unable 
> to add disk devices
> libxl: error: libxl_aoutils.c:539:async_exec_timeout: killing execution 
> of /etc/xen/scripts/block remove because of timeout
> libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain 
> 2:Non-existant domain
> libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 
> 2:Unable to destroy guest
> libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 
> 2:Destruction of domain failed
> ================================================
> 
> The last try was with alpine domU linux with the following config:
> ================================================
> 
> # Alpine Linux PV DomU
> # Kernel paths for install
> kernel = "/home/xen/vmlinuz-virt"
> ramdisk = "/home/xen/initramfs-virt"
> extra="modules=loop,squashfs console=hvc0"
> # Path to HDD and iso file
> disk = [ 'format=raw, vdev=xvda, access=w, target=/data/a1.img',
>          'format=raw, vdev=xvdc, access=r, devtype=cdrom, 

Have you tried to remove cdrom from your DomU config? I am not sure
cdrom can work well for Arm without device model.

Cheers,
Wei Chen
> target=/home/xen/alpine-virt-3.15.3-armv7.iso'  ]
> # Network configuration
> vif = ['bridge=br0']
> # DomU settings
> memory = 512
> name = "alpine-a1"
> vcpus = 1
> maxvcpus = 1
> ================================================
> 
> thanks a lot in advance
> Best regards
> Marco


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:06:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:06:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308553.524356 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngzjV-0003x0-HN; Wed, 20 Apr 2022 02:06:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308553.524356; Wed, 20 Apr 2022 02:06:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ngzjV-0003wt-ED; Wed, 20 Apr 2022 02:06:17 +0000
Received: by outflank-mailman (input) for mailman id 308553;
 Wed, 20 Apr 2022 02:06:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngzjU-0003wj-4q; Wed, 20 Apr 2022 02:06:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngzjU-0003fU-3o; Wed, 20 Apr 2022 02:06:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ngzjT-0003RB-LA; Wed, 20 Apr 2022 02:06:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ngzjT-0000S9-KO; Wed, 20 Apr 2022 02:06:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=43BzIYDHLkWwsmKyYwd1uBkPoXaJD9y5ZuRDGwnDDpk=; b=Jt3g0dzT9gQONY6MoxvTn+/wvM
	oIO5YBUyZKt+kotjRZ2WivaB8ROSkybAreeriiZtVZ0TJsXQg6OUh2JniR0OJdFlNtiLvyoPCUnzw
	/5b38t3c6LU9+K196FWU7WD845QcshgpZ/xF9qTq5n5mtjrJljrEPII/CZeVTEYsrqCM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169551-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169551: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 02:06:15 +0000

flight 169551 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169551/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  512 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:30:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:30:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308561.524367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh07C-0007Le-Gr; Wed, 20 Apr 2022 02:30:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308561.524367; Wed, 20 Apr 2022 02:30:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh07C-0007LX-E3; Wed, 20 Apr 2022 02:30:46 +0000
Received: by outflank-mailman (input) for mailman id 308561;
 Wed, 20 Apr 2022 02:30:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh07B-0007LR-FX
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:30:45 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dfcb7de8-c051-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 04:30:43 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2UTfS092930
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:30:35 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2USH2092929;
 Tue, 19 Apr 2022 19:30:28 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfcb7de8-c051-11ec-8fbf-03012f2f19d4
Message-Id: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Tue, 19 Apr 2022 19:10:17 -0700
Subject: [PATCH 00/10] Increase consistency of domain examples
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

The "xlexample.*" files have drifted apart rather distinctly.  This may
cause puzzlement at why the distinct choices were made.  Worse, I have an
unpleasant suspicion a naive user could benchmark with these files and
not realize performance differences were due to different settings, not
the domain type.

I chose 3 vCPUs and 384MB of memory.  This is in-between the values
currently in the examples.  I wonder whether I should have used the
values from pvhlinux as those may better reflect typical small VMs now.

Elliott Mitchell (10):
  docs: xlexample.hvm: Mention this isn't useful for other guests
  docs: xlexample.*: Use consistent vCPU count
  docs: xlexample.*: Use consistent initial memory
  docs: xlexample.pvhlinux: Add commented maxmem setting
  docs: xlexample.hvm: Fix maxmem value
  docs: xlexample.hvm: Add reference to nographic option
  docs: xlexample.pvhlinux: Make disk setting consistent with other
    examples
  docs: xlexample.hvm: Fix grammmer
  docs: xlexample.pvlinux: Add "type" setting
  docs: xlexample.pvhlinux: Use similar text to other examples

 tools/examples/xlexample.hvm      | 19 ++++++++++---------
 tools/examples/xlexample.pvhlinux | 13 +++++++++----
 tools/examples/xlexample.pvlinux  |  7 +++++--
 3 files changed, 24 insertions(+), 15 deletions(-)

-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:31:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:31:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308571.524379 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh08M-00084V-U1; Wed, 20 Apr 2022 02:31:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308571.524379; Wed, 20 Apr 2022 02:31:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh08M-00084O-Ps; Wed, 20 Apr 2022 02:31:58 +0000
Received: by outflank-mailman (input) for mailman id 308571;
 Wed, 20 Apr 2022 02:31:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh08L-00084B-7s
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:31:57 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0a666418-c052-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:31:55 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2VhCK092942
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:31:49 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2VhSj092941;
 Tue, 19 Apr 2022 19:31:43 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a666418-c052-11ec-a405-831a346695d4
Message-Id: <c1373ba89550461f9dc3e450fc643dee187d63ba.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 09:52:06 -0800
Subject: [PATCH 01/10] docs: xlexample.hvm: Mention this isn't useful for
 other guests
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

I dislike the implication this default is valuable for all guests, need
some mention of trade-off.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.hvm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index df9fe07653..c2db4f237a 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -18,7 +18,7 @@ name = "example.hvm"
 
 # Enable Microsoft Hyper-V compatibile paravirtualisation /
 # enlightenment interfaces. Turning this on can improve Windows guest
-# performance and is therefore recommended
+# performance and is therefore recommended for Windows guests
 #viridian = 1
 
 # Initial memory allocation (MB)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:32:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:32:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308580.524390 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh09A-0000DA-6E; Wed, 20 Apr 2022 02:32:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308580.524390; Wed, 20 Apr 2022 02:32:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh09A-0000D3-3P; Wed, 20 Apr 2022 02:32:48 +0000
Received: by outflank-mailman (input) for mailman id 308580;
 Wed, 20 Apr 2022 02:32:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh098-0000Cr-AV
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:32:46 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28b0d0ee-c052-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 04:32:45 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2WZ6v092952
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:32:41 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2WZlW092951;
 Tue, 19 Apr 2022 19:32:35 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28b0d0ee-c052-11ec-8fbf-03012f2f19d4
Message-Id: <c5351daa5561e143efa4613104246a248438af0b.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 09:54:16 -0800
Subject: [PATCH 02/10] docs: xlexample.*: Use consistent vCPU count
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Make all examples use the same number of vCPUs.  Hopefully this avoids
confusing attempts at benchmarking during installation.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.hvm      | 2 +-
 tools/examples/xlexample.pvhlinux | 2 +-
 tools/examples/xlexample.pvlinux  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index c2db4f237a..ed821fea87 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -30,7 +30,7 @@ memory = 128
 #maxmem = 512
 
 # Number of VCPUS
-vcpus = 2
+vcpus = 3
 
 # Network devices
 # A list of 'vifspec' entries as described in
diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index 18305b80af..49961e4687 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -29,7 +29,7 @@ extra = "root=/dev/xvda1"
 memory = 512
 
 # Number of VCPUS
-vcpus = 4
+vcpus = 3
 
 # Network devices
 # A list of 'vifspec' entries as described in
diff --git a/tools/examples/xlexample.pvlinux b/tools/examples/xlexample.pvlinux
index bb5996b29f..0c7a535f39 100644
--- a/tools/examples/xlexample.pvlinux
+++ b/tools/examples/xlexample.pvlinux
@@ -31,7 +31,7 @@ memory = 128
 #maxmem = 512
 
 # Number of VCPUS
-vcpus = 2
+vcpus = 3
 
 # Network devices
 # A list of 'vifspec' entries as described in
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:33:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:33:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308592.524400 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh09y-0000qm-JG; Wed, 20 Apr 2022 02:33:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308592.524400; Wed, 20 Apr 2022 02:33:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh09y-0000qd-GV; Wed, 20 Apr 2022 02:33:38 +0000
Received: by outflank-mailman (input) for mailman id 308592;
 Wed, 20 Apr 2022 02:33:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh09x-0000qV-Ju
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:33:37 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4739dd0e-c052-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 04:33:36 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2XRDf092969
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:33:32 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2XRJp092968;
 Tue, 19 Apr 2022 19:33:27 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4739dd0e-c052-11ec-8fbf-03012f2f19d4
Message-Id: <bc0af95068ae9f97d07c18aea0dd7f848883dabe.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 09:58:46 -0800
Subject: [PATCH 03/10] docs: xlexample.*: Use consistent initial memory
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Avoid confusing benchmarking during initial installation by using
consistent amounts of memory for examples.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.hvm      | 2 +-
 tools/examples/xlexample.pvhlinux | 2 +-
 tools/examples/xlexample.pvlinux  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index ed821fea87..26ae1c2fb4 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -22,7 +22,7 @@ name = "example.hvm"
 #viridian = 1
 
 # Initial memory allocation (MB)
-memory = 128
+memory = 384
 
 # Maximum memory (MB)
 # If this is greater than `memory' then the slack will start ballooned
diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index 49961e4687..1e9bcb9de5 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -26,7 +26,7 @@ kernel = "/boot/vmlinuz"
 extra = "root=/dev/xvda1"
 
 # Initial memory allocation (MB)
-memory = 512
+memory = 384
 
 # Number of VCPUS
 vcpus = 3
diff --git a/tools/examples/xlexample.pvlinux b/tools/examples/xlexample.pvlinux
index 0c7a535f39..be6931549a 100644
--- a/tools/examples/xlexample.pvlinux
+++ b/tools/examples/xlexample.pvlinux
@@ -23,7 +23,7 @@ kernel = "/boot/vmlinuz"
 extra = "root=/dev/xvda1"
 
 # Initial memory allocation (MB)
-memory = 128
+memory = 384
 
 # Maximum memory (MB)
 # If this is greater than `memory' then the slack will start ballooned
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:34:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:34:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308601.524411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Ao-0001SQ-SY; Wed, 20 Apr 2022 02:34:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308601.524411; Wed, 20 Apr 2022 02:34:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Ao-0001SJ-Pk; Wed, 20 Apr 2022 02:34:30 +0000
Received: by outflank-mailman (input) for mailman id 308601;
 Wed, 20 Apr 2022 02:34:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0An-0000qV-QK
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:34:29 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 667d4823-c052-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 04:34:29 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2YJKV092979
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:34:24 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2YJQm092978;
 Tue, 19 Apr 2022 19:34:19 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 667d4823-c052-11ec-8fbf-03012f2f19d4
Message-Id: <c1308b575fa73710488527e7817668ff68b922f7.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 10:01:07 -0800
Subject: [PATCH 04/10] docs: xlexample.pvhlinux: Add commented maxmem setting
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Avoid confusion caused by differing example configuration files.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.pvhlinux | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index 1e9bcb9de5..e1bf845093 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -28,6 +28,11 @@ extra = "root=/dev/xvda1"
 # Initial memory allocation (MB)
 memory = 384
 
+# Maximum memory (MB)
+# If this is greater than `memory' then the slack will start ballooned
+# (this assumes guest kernel support for ballooning)
+#maxmem = 512
+
 # Number of VCPUS
 vcpus = 3
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:37:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:37:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308619.524423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0DL-00029o-9j; Wed, 20 Apr 2022 02:37:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308619.524423; Wed, 20 Apr 2022 02:37:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0DL-00029f-6L; Wed, 20 Apr 2022 02:37:07 +0000
Received: by outflank-mailman (input) for mailman id 308619;
 Wed, 20 Apr 2022 02:37:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0DJ-00028y-CY
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:37:05 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c33ec1bc-c052-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 04:37:04 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2askH093003
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:37:00 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2asXK093002;
 Tue, 19 Apr 2022 19:36:54 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c33ec1bc-c052-11ec-8fbf-03012f2f19d4
Message-Id: <2510649c390ee59f79f4be797cdd8af7aaca8f3c.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 12:11:14 -0800
Subject: [PATCH 07/10] docs: xlexample.pvhlinux: Make disk setting consistent
 with other examples
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

While storing images on ZFS is now quite common, such isn't required
at all.  As such the example should be as generic as possible and
consistent with other examples.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.pvhlinux | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index e1bf845093..a6a52c336c 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -44,4 +44,4 @@ vif = [ '' ]
 # Disk Devices
 # A list of `diskspec' entries as described in
 # docs/misc/xl-disk-configuration.txt
-disk = [ '/dev/zvol/tank/guest-volume,raw,xvda,rw' ]
+disk = [ '/dev/vg/guest-volume,raw,xvda,rw' ]
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:37:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:37:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308627.524434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0EA-0002i1-JR; Wed, 20 Apr 2022 02:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308627.524434; Wed, 20 Apr 2022 02:37:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0EA-0002hu-GB; Wed, 20 Apr 2022 02:37:58 +0000
Received: by outflank-mailman (input) for mailman id 308627;
 Wed, 20 Apr 2022 02:37:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0E9-00028y-B9
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:37:57 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e233b4d8-c052-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 04:37:56 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2bkI2093013
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:37:52 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2bkFO093012;
 Tue, 19 Apr 2022 19:37:46 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e233b4d8-c052-11ec-8fbf-03012f2f19d4
Message-Id: <20496e1f17c59af7a58a14201f230b51c896fc7e.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 12:13:33 -0800
Subject: [PATCH 08/10] docs: xlexample.hvm: Fix grammmer
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

This is correct and makes comparing the files with `diff` easier.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.hvm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index 7afb7c731d..df82280531 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -2,10 +2,10 @@
 # Example HVM guest configuration
 # =====================================================================
 #
-# This is a fairly minimal example of what is required for an
+# This is a fairly minimal example of what is required for a
 # HVM guest. For a more complete guide see xl.cfg(5)
 
-# This configures an HVM rather than PV guest
+# This configures a HVM guest instead of PV or PVH
 type = "hvm"
 
 # Guest name
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:38:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:38:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308633.524445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Ez-0003In-T9; Wed, 20 Apr 2022 02:38:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308633.524445; Wed, 20 Apr 2022 02:38:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Ez-0003Ig-Pb; Wed, 20 Apr 2022 02:38:49 +0000
Received: by outflank-mailman (input) for mailman id 308633;
 Wed, 20 Apr 2022 02:38:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0Ez-0003HJ-3g
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:38:49 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0102f791-c053-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:38:48 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2ccVS093023
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:38:44 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2ccUp093022;
 Tue, 19 Apr 2022 19:38:38 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0102f791-c053-11ec-a405-831a346695d4
Message-Id: <b8e7efa18e28f5fe7cdea478304bc4a1c64e8e01.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 12:16:24 -0800
Subject: [PATCH 09/10] docs: xlexample.pvlinux: Add "type" setting
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Some environments will prefer to explicitly include this setting
despite being the default.  This also increases consistency with other
examples.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.pvlinux | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/examples/xlexample.pvlinux b/tools/examples/xlexample.pvlinux
index be6931549a..19dac50fcd 100644
--- a/tools/examples/xlexample.pvlinux
+++ b/tools/examples/xlexample.pvlinux
@@ -5,6 +5,9 @@
 # This is a fairly minimal example of what is required for a
 # Paravirtualised Linux guest. For a more complete guide see xl.cfg(5)
 
+# This configures a PV guest instead of HVM or PVH
+#type = "pv"	# "pv" is default
+
 # Guest name
 name = "example.pvlinux"
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:39:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:39:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308647.524456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Fq-0003u1-5r; Wed, 20 Apr 2022 02:39:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308647.524456; Wed, 20 Apr 2022 02:39:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Fq-0003tu-2T; Wed, 20 Apr 2022 02:39:42 +0000
Received: by outflank-mailman (input) for mailman id 308647;
 Wed, 20 Apr 2022 02:39:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0Fp-0003ta-Ac
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:39:41 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2004098c-c053-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:39:40 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2dU4r093033
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:39:36 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2dUx1093032;
 Tue, 19 Apr 2022 19:39:30 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2004098c-c053-11ec-a405-831a346695d4
Message-Id: <d8c6e2150f037253242fa5774551014b5326bbc6.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 12:20:43 -0800
Subject: [PATCH 10/10] docs: xlexample.pvhlinux: Use similar text to other
 examples
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Simply making the word choice match the other examples.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.pvhlinux | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index a6a52c336c..7685fb67b6 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -5,7 +5,7 @@
 # This is a fairly minimal example of what is required for a
 # PVH Linux guest. For a more complete guide see xl.cfg(5)
 
-# This configures a PVH rather than PV guest
+# This configures a PVH guest instead of HVM or PV
 type = "pvh"
 
 # Guest name
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:41:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:41:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308664.524467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Ht-0005MX-L4; Wed, 20 Apr 2022 02:41:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308664.524467; Wed, 20 Apr 2022 02:41:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Ht-0005MH-Fz; Wed, 20 Apr 2022 02:41:49 +0000
Received: by outflank-mailman (input) for mailman id 308664;
 Wed, 20 Apr 2022 02:41:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0Bd-0000eu-1j
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:35:21 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85040090-c052-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:35:20 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2ZB2W092991
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:35:16 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2ZBk1092990;
 Tue, 19 Apr 2022 19:35:11 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85040090-c052-11ec-a405-831a346695d4
Message-Id: <f3f72c2a42a0e2b682221f7914ff90fc3365fc19.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 14:44:07 -0800
Subject: [PATCH 05/10] docs: xlexample.hvm: Fix maxmem value
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

HVM doesn't balloon and so it makes no sense to specify maxmem.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.hvm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index 26ae1c2fb4..a6cafcbf9f 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -25,9 +25,9 @@ name = "example.hvm"
 memory = 384
 
 # Maximum memory (MB)
-# If this is greater than `memory' then the slack will start ballooned
-# (this assumes guest kernel support for ballooning)
-#maxmem = 512
+# Unlike PV or PVH, HVM cannot balloon memory and hence this should match
+# `memory' or simply be left unset.
+#maxmem =
 
 # Number of VCPUS
 vcpus = 3
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:41:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:41:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308670.524478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Hv-0005kG-Sj; Wed, 20 Apr 2022 02:41:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308670.524478; Wed, 20 Apr 2022 02:41:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Hv-0005k2-OD; Wed, 20 Apr 2022 02:41:51 +0000
Received: by outflank-mailman (input) for mailman id 308670;
 Wed, 20 Apr 2022 02:41:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nh0Cv-0000eu-1W
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:36:41 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b43f5801-c052-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:36:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 01C0F615A4;
 Wed, 20 Apr 2022 02:36:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8762C385A5;
 Wed, 20 Apr 2022 02:36:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b43f5801-c052-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650422197;
	bh=n6fUiwY5cUeV/2+c5RHqtGzf+nZ4s2cGnOrO1GfdEe8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=D0xlD03sW7FW+35G64kb/KoosNEJ2tvPRcy7dG/mcBZqzHccRtpcHctWY+UmHr/Tm
	 O8lLEtro+48WAcOOi2ryfmqk++SPnTYjHzr5xGyLQ+xgIsaSUcLyAv4juStMOV+jZ9
	 g40LFZL1qNqUFMVKiYTrnKzA3+LG+6ydxSXH+m0bgQkAhN/xik4IcXDVX7JXQCEYDI
	 nMhqO70kPicUQPc2N6UiB2TMgA8PXGWWb+hjNw9nZJWD0S5ycE+wmmKCJowk1a+opK
	 axASYlIfgmouow1x2OngjI922JSFIPSwPp5CmOOmYRZAL1+q9XTznhizDPSi2HXbsZ
	 YMo6akpfd628g==
Date: Tue, 19 Apr 2022 19:36:36 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <Rahul.Singh@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Christoph Hellwig <hch@lst.de>, xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>, 
    "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
In-Reply-To: <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com> <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop> <8C511888-6183-421E-A4C7-B271DAF46696@arm.com> <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de> <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop> <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com> <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
 <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

> > Then there is xen_swiotlb_init() which allocates some memory for
> > swiotlb-xen at boot. It could lower the total amount of memory
> > available, but if you disabled swiotlb-xen like I suggested,
> > xen_swiotlb_init() still should get called and executed anyway at boot
> > (it is called from arch/arm/xen/mm.c:xen_mm_init). So xen_swiotlb_init()
> > shouldn't be the one causing problems.
> >
> > That's it -- there is nothing else in swiotlb-xen that I can think of.
> >
> > I don't have any good ideas, so I would only suggest to add more printks
> > and report the results, for instance:
> 
> As suggested I added the more printks but only difference I see is the size apart
> from that everything looks same .
> 
> Please find the attached logs for xen and native linux boot.

One difference is that the order of the allocations is significantly
different after the first 3 allocations. It is very unlikely but
possible that this is an unrelated concurrency bug that only occurs on
Xen. I doubt it.

I think you could try booting native and Xen with only 1 CPU enabled in
both cases.

For native, you can do that with maxcpus, e.g. maxcpus=1.
For Xen, you can do that with dom0_max_vcpus=1. I don't think we need to
reduce the number of pCPUs seen by Xen, but it could be useful to pass
sched=null to avoid any scheduler effects. This is just for debugging of
course.


In reality, the most likely explanation is that the issue is a memory
corruption. Something somewhere is corrupting Linux memory and it just
happens that we see it when calling dma_direct_alloc. This means it is
going to be difficult to find as the only real clue is that it is
swiotlb-xen that is causing it.


I added more printks with the goal of detecting swiotlb-xen code paths
that shouldn't be taken in a normal dom0 boot without domUs. For
instance, range_straddles_page_boundary should always return zero and
the dma_mask check in xen_swiotlb_alloc_coherent should always succeed.

Fingers crossed we'll notice that the wrong path is taken just before
the crash.


diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 2b385c1b4a99..aab45ba4e9ef 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -284,6 +284,7 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	phys_addr_t phys;
 	dma_addr_t dev_addr;
 
+	printk("DEBUG %s %d size=%lu flags=%x attr=%lx\n",__func__,__LINE__,size,flags,attrs);
 	/*
 	* Ignore region specifiers - the kernel's ideas of
 	* pseudo-phys memory layout has nothing to do with the
@@ -295,6 +296,8 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	/* Convert the size to actually allocated. */
 	size = 1UL << (order + XEN_PAGE_SHIFT);
 
+	printk("DEBUG %s %d size=%lu flags=%x attr=%lx\n",__func__,__LINE__,size,flags,attrs);
+
 	/* On ARM this function returns an ioremap'ped virtual address for
 	 * which virt_to_phys doesn't return the corresponding physical
 	 * address. In fact on ARM virt_to_phys only works for kernel direct
@@ -315,15 +318,18 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	phys = dma_to_phys(hwdev, *dma_handle);
 	dev_addr = xen_phys_to_dma(hwdev, phys);
 	if (((dev_addr + size - 1 <= dma_mask)) &&
-	    !range_straddles_page_boundary(phys, size))
+	    !range_straddles_page_boundary(phys, size)) {
 		*dma_handle = dev_addr;
-	else {
+		printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,phys,dev_addr);
+	} else {
+		printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,phys,dev_addr);
 		if (xen_create_contiguous_region(phys, order,
 						 fls64(dma_mask), dma_handle) != 0) {
 			xen_free_coherent_pages(hwdev, size, ret, (dma_addr_t)phys, attrs);
 			return NULL;
 		}
 		*dma_handle = phys_to_dma(hwdev, *dma_handle);
+		printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,phys,*dma_handle);
 		SetPageXenRemapped(virt_to_page(ret));
 	}
 	memset(ret, 0, size);
@@ -388,8 +394,12 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
 	    !range_straddles_page_boundary(phys, size) &&
 		!xen_arch_need_swiotlb(dev, phys, dev_addr) &&
 		swiotlb_force != SWIOTLB_FORCE)
+	{
+		printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,phys,dev_addr);
 		goto done;
+	}
 
+	printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,phys,dev_addr);
 	/*
 	 * Oh well, have to allocate and map a bounce buffer.
 	 */
@@ -413,10 +423,13 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
 
 done:
 	if (!dev_is_dma_coherent(dev) && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
-		if (pfn_valid(PFN_DOWN(dma_to_phys(dev, dev_addr))))
+		if (pfn_valid(PFN_DOWN(dma_to_phys(dev, dev_addr)))) {
+			printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,phys,dev_addr);
 			arch_sync_dma_for_device(phys, size, dir);
-		else
+		} else {
+			printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,phys,dev_addr);
 			xen_dma_sync_for_device(dev, dev_addr, size, dir);
+		}
 	}
 	return dev_addr;
 }
@@ -437,15 +450,20 @@ static void xen_swiotlb_unmap_page(struct device *hwdev, dma_addr_t dev_addr,
 	BUG_ON(dir == DMA_NONE);
 
 	if (!dev_is_dma_coherent(hwdev) && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
-		if (pfn_valid(PFN_DOWN(dma_to_phys(hwdev, dev_addr))))
+		if (pfn_valid(PFN_DOWN(dma_to_phys(hwdev, dev_addr)))) {
+			printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,paddr,dev_addr);
 			arch_sync_dma_for_cpu(paddr, size, dir);
-		else
+		} else {
+			printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,paddr,dev_addr);
 			xen_dma_sync_for_cpu(hwdev, dev_addr, size, dir);
+		}
 	}
 
 	/* NOTE: We use dev_addr here, not paddr! */
-	if (is_xen_swiotlb_buffer(hwdev, dev_addr))
+	if (is_xen_swiotlb_buffer(hwdev, dev_addr)) {
+		printk("DEBUG %s %d phys=%llx dev_addr=%llx\n",__func__,__LINE__,paddr,dev_addr);
 		swiotlb_tbl_unmap_single(hwdev, paddr, size, size, dir, attrs);
+	}
 }
 
 static void
diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
index 51bb8fa8eb89..fdddeaf1b7cd 100644
--- a/kernel/dma/mapping.c
+++ b/kernel/dma/mapping.c
@@ -429,9 +429,11 @@ void *dma_alloc_attrs(struct device *dev, size_t size, dma_addr_t *dma_handle,
 	if (dma_alloc_from_dev_coherent(dev, size, dma_handle, &cpu_addr))
 		return cpu_addr;
 
+	printk("DEBUG %s %d size=%lu flags=%x attr=%lx\n",__func__,__LINE__,size,flag,attrs);
 	/* let the implementation decide on the zone to allocate from: */
 	flag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM);
 
+	printk("DEBUG %s %d size=%lu flags=%x attr=%lx\n",__func__,__LINE__,size,flag,attrs);
 	if (dma_alloc_direct(dev, ops))
 		cpu_addr = dma_direct_alloc(dev, size, dma_handle, flag, attrs);
 	else if (ops->alloc)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:41:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:41:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308674.524485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Hw-0005t0-EF; Wed, 20 Apr 2022 02:41:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308674.524485; Wed, 20 Apr 2022 02:41:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Hw-0005qq-7o; Wed, 20 Apr 2022 02:41:52 +0000
Received: by outflank-mailman (input) for mailman id 308674;
 Wed, 20 Apr 2022 02:41:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0CT-0000eu-OO
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:36:13 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a451cf37-c052-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:36:12 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2a2xK092997
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:36:08 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2a2M3092996;
 Tue, 19 Apr 2022 19:36:02 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a451cf37-c052-11ec-a405-831a346695d4
Message-Id: <f41e431bf877dfa3b545d8fad65b71ceb3e6f008.1650420617.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650420617.git.ehem+xen@m5p.com>
References: <cover.1650420617.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Sat, 9 Jan 2021 12:08:00 -0800
Subject: [PATCH 06/10] docs: xlexample.hvm: Add reference to nographic option
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Running without any display device is a completely legal configuration.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/examples/xlexample.hvm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index a6cafcbf9f..7afb7c731d 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -42,6 +42,7 @@ vif = [ '' ]
 # docs/misc/xl-disk-configuration.txt
 disk = [ '/dev/vg/guest-volume,raw,xvda,rw' ]
 
-# Guest VGA console configuration, either SDL or VNC
+# Guest VGA console configuration, SDL, VNC, or none
 sdl = 1
 #vnc = 1
+#nographic = 1
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:47:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:47:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308704.524500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Nc-0007N8-1M; Wed, 20 Apr 2022 02:47:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308704.524500; Wed, 20 Apr 2022 02:47:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Nb-0007N1-TL; Wed, 20 Apr 2022 02:47:43 +0000
Received: by outflank-mailman (input) for mailman id 308704;
 Wed, 20 Apr 2022 02:47:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh0Na-0007Mr-LW; Wed, 20 Apr 2022 02:47:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh0Na-0004Pp-Id; Wed, 20 Apr 2022 02:47:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh0Na-0005VM-40; Wed, 20 Apr 2022 02:47:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh0Na-0004xC-3W; Wed, 20 Apr 2022 02:47:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=U78hzo7khoQWkRnEUZXpteibCmltcGHftEf5YYeU9bU=; b=axHuGT8hSheUNox8rr0yO5YcgS
	35U8Ro6gUpCYR8z4IXdqob9OCFGz+UaWh24Lk3TDi9VP7jBWdFELR86hlIef9dw71iyipa5PhZZzT
	tYRaLfeFnwcsOWlgnRxbFQJU/3QhWtUpMUWMDtbE0PoSWGKPlmsdabuM4T9t+o1iW1Mk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169553-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169553: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 02:47:42 +0000

flight 169553 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169553/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  513 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:51:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:51:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308712.524511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0RU-0000Ki-Jm; Wed, 20 Apr 2022 02:51:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308712.524511; Wed, 20 Apr 2022 02:51:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0RU-0000Kb-Fv; Wed, 20 Apr 2022 02:51:44 +0000
Received: by outflank-mailman (input) for mailman id 308712;
 Wed, 20 Apr 2022 02:51:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0RT-0000KV-7V
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:51:43 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce4a77b6-c054-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:51:42 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2pWaH093128
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:51:38 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2pWbm093127;
 Tue, 19 Apr 2022 19:51:32 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce4a77b6-c054-11ec-a405-831a346695d4
Message-Id: <cover.1650422517.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Tue, 19 Apr 2022 19:41:57 -0700
Subject: [PATCH 0/2] Allow use of JSON in domain configuration files
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

While the traditional domain configuration file format works acceptably,
I can see uses for having full JSON support.  As such add "-j" and "-J"
to `xl create` to specify format.  The traditional format is the current
default.

While attempting this, it came up that options for `xl create` aren't in
a consistent order.  I'm concerned about moving the VNC options apart,
but the others have been sorted.

Elliott Mitchell (2):
  tools/xl: Sort create command options
  tools/xl: Allow specifying JSON for domain configuration file format

 tools/xl/xl.h           |  5 ++++
 tools/xl/xl_cmdtable.c  | 12 ++++++----
 tools/xl/xl_vmcontrol.c | 51 ++++++++++++++++++++++++-----------------
 3 files changed, 42 insertions(+), 26 deletions(-)

-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:53:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:53:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308718.524521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Sh-00012h-TK; Wed, 20 Apr 2022 02:52:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308718.524521; Wed, 20 Apr 2022 02:52:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Sh-00012a-QL; Wed, 20 Apr 2022 02:52:59 +0000
Received: by outflank-mailman (input) for mailman id 308718;
 Wed, 20 Apr 2022 02:52:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0Sg-00012Q-EA
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:52:58 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb0a3102-c054-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:52:57 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2qlpN093140
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:52:53 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2ql8U093139;
 Tue, 19 Apr 2022 19:52:47 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb0a3102-c054-11ec-a405-831a346695d4
Message-Id: <c145a7648025e9bbc2f47ab8bd5839c80c01933f.1650422518.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650422517.git.ehem+xen@m5p.com>
References: <cover.1650422517.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Tue, 19 Apr 2022 18:56:03 -0700
Subject: [PATCH 1/2] tools/xl: Sort create command options
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Hopefully simplify future changes by sorting options lists for
`xl create`.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/xl/xl_cmdtable.c  | 10 +++++-----
 tools/xl/xl_vmcontrol.c | 40 ++++++++++++++++++++--------------------
 2 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
index 661323d488..f546beaceb 100644
--- a/tools/xl/xl_cmdtable.c
+++ b/tools/xl/xl_cmdtable.c
@@ -24,16 +24,16 @@ const struct cmd_spec cmd_table[] = {
       &main_create, 1, 1,
       "Create a domain from config file <filename>",
       "<ConfigFile> [options] [vars]",
+      "-c                      Connect to the console after the domain is created.\n"
+      "-d                      Enable debug messages.\n"
+      "-e                      Do not wait in the background for the death of the domain.\n"
+      "-F                      Run in foreground until death of the domain.\n"
       "-h                      Print this help.\n"
       "-p                      Leave the domain paused after it is created.\n"
-      "-c                      Connect to the console after the domain is created.\n"
       "-f FILE, --defconfig=FILE\n                     Use the given configuration file.\n"
-      "-q, --quiet             Quiet.\n"
       "-n, --dryrun            Dry run - prints the resulting configuration\n"
       "                         (deprecated in favour of global -N option).\n"
-      "-d                      Enable debug messages.\n"
-      "-F                      Run in foreground until death of the domain.\n"
-      "-e                      Do not wait in the background for the death of the domain.\n"
+      "-q, --quiet             Quiet.\n"
       "-V, --vncviewer         Connect to the VNC display after the domain is created.\n"
       "-A, --vncviewer-autopass\n"
       "                        Pass VNC password to viewer via stdin.\n"
diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
index 435155a033..2ec4140258 100644
--- a/tools/xl/xl_vmcontrol.c
+++ b/tools/xl/xl_vmcontrol.c
@@ -1169,13 +1169,13 @@ int main_create(int argc, char **argv)
     int paused = 0, debug = 0, daemonize = 1, console_autoconnect = 0,
         quiet = 0, monitor = 1, vnc = 0, vncautopass = 0, ignore_masks = 0;
     int opt, rc;
-    static struct option opts[] = {
+    static const struct option opts[] = {
+        {"defconfig", 1, 0, 'f'},
         {"dryrun", 0, 0, 'n'},
+        {"ignore-global-affinity-masks", 0, 0, 'i'},
         {"quiet", 0, 0, 'q'},
-        {"defconfig", 1, 0, 'f'},
         {"vncviewer", 0, 0, 'V'},
         {"vncviewer-autopass", 0, 0, 'A'},
-        {"ignore-global-affinity-masks", 0, 0, 'i'},
         COMMON_LONG_OPTS
     };
 
@@ -1186,12 +1186,15 @@ int main_create(int argc, char **argv)
         argc--; argv++;
     }
 
-    SWITCH_FOREACH_OPT(opt, "Fnqf:pcdeVAi", opts, "create", 0) {
-    case 'f':
-        filename = optarg;
+    SWITCH_FOREACH_OPT(opt, "Ffnq:AVcdeip", opts, "create", 0) {
+    case 'A':
+        vnc = vncautopass = 1;
         break;
-    case 'p':
-        paused = 1;
+    case 'F':
+        daemonize = 0;
+        break;
+    case 'V':
+        vnc = 1;
         break;
     case 'c':
         console_autoconnect = 1;
@@ -1199,28 +1202,25 @@ int main_create(int argc, char **argv)
     case 'd':
         debug = 1;
         break;
-    case 'F':
-        daemonize = 0;
-        break;
     case 'e':
         daemonize = 0;
         monitor = 0;
         break;
+    case 'f':
+        filename = optarg;
+        break;
+    case 'i':
+        ignore_masks = 1;
+        break;
     case 'n':
         dryrun_only = 1;
         break;
+    case 'p':
+        paused = 1;
+        break;
     case 'q':
         quiet = 1;
         break;
-    case 'V':
-        vnc = 1;
-        break;
-    case 'A':
-        vnc = vncautopass = 1;
-        break;
-    case 'i':
-        ignore_masks = 1;
-        break;
     }
 
     memset(&dom_info, 0, sizeof(dom_info));
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:54:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:54:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308731.524532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Ts-0001eq-6l; Wed, 20 Apr 2022 02:54:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308731.524532; Wed, 20 Apr 2022 02:54:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0Ts-0001eh-3v; Wed, 20 Apr 2022 02:54:12 +0000
Received: by outflank-mailman (input) for mailman id 308731;
 Wed, 20 Apr 2022 02:54:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0Tq-000126-NK
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:54:10 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 264b3875-c055-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 04:54:09 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2s0Uu093150
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:54:06 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2s0EU093149;
 Tue, 19 Apr 2022 19:54:00 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 264b3875-c055-11ec-8fbf-03012f2f19d4
Message-Id: <09213ac26738ee51401b454534c6b437766481b7.1650422518.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650422517.git.ehem+xen@m5p.com>
References: <cover.1650422517.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Tue, 19 Apr 2022 18:23:41 -0700
Subject: [PATCH 2/2] tools/xl: Allow specifying JSON for domain configuration
 file format
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

JSON is currently used when saving domains to mass storage.  Being able
to use JSON as the normal input to `xl create` has potential to be
valuable.  Add the functionality.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/xl/xl.h           |  5 +++++
 tools/xl/xl_cmdtable.c  |  2 ++
 tools/xl/xl_vmcontrol.c | 13 +++++++++++--
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index c5c4bedbdd..a0c03f96df 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -49,6 +49,11 @@ struct domain_create {
     int migrate_fd; /* -1 means none */
     int send_back_fd; /* -1 means none */
     char **migration_domname_r; /* from malloc */
+    enum {
+        FORMAT_DEFAULT,
+        FORMAT_JSON,
+        FORMAT_LEGACY,
+    } format;
 };
 
 int create_domain(struct domain_create *dom_info);
diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
index f546beaceb..04d579a596 100644
--- a/tools/xl/xl_cmdtable.c
+++ b/tools/xl/xl_cmdtable.c
@@ -31,6 +31,8 @@ const struct cmd_spec cmd_table[] = {
       "-h                      Print this help.\n"
       "-p                      Leave the domain paused after it is created.\n"
       "-f FILE, --defconfig=FILE\n                     Use the given configuration file.\n"
+      "-j, --json              Interpret configuration file as JSON format\n"
+      "-J                      Use traditional configuration file format (current default)\n"
       "-n, --dryrun            Dry run - prints the resulting configuration\n"
       "                         (deprecated in favour of global -N option).\n"
       "-q, --quiet             Quiet.\n"
diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
index 2ec4140258..41bd919d1d 100644
--- a/tools/xl/xl_vmcontrol.c
+++ b/tools/xl/xl_vmcontrol.c
@@ -789,7 +789,7 @@ int create_domain(struct domain_create *dom_info)
                 extra_config);
         }
         config_source=config_file;
-        config_in_json = false;
+        config_in_json = dom_info.format == FORMAT_JSON ? true : false;
     } else {
         if (!config_data) {
             fprintf(stderr, "Config file not specified and"
@@ -1173,6 +1173,7 @@ int main_create(int argc, char **argv)
         {"defconfig", 1, 0, 'f'},
         {"dryrun", 0, 0, 'n'},
         {"ignore-global-affinity-masks", 0, 0, 'i'},
+        {"json", 0, 0, 'j'},
         {"quiet", 0, 0, 'q'},
         {"vncviewer", 0, 0, 'V'},
         {"vncviewer-autopass", 0, 0, 'A'},
@@ -1181,18 +1182,23 @@ int main_create(int argc, char **argv)
 
     dom_info.extra_config = NULL;
 
+    dom_info.format = FORMAT_DEFAULT;
+
     if (argv[1] && argv[1][0] != '-' && !strchr(argv[1], '=')) {
         filename = argv[1];
         argc--; argv++;
     }
 
-    SWITCH_FOREACH_OPT(opt, "Ffnq:AVcdeip", opts, "create", 0) {
+    SWITCH_FOREACH_OPT(opt, "FJfjnq:AVcdeip", opts, "create", 0) {
     case 'A':
         vnc = vncautopass = 1;
         break;
     case 'F':
         daemonize = 0;
         break;
+    case 'J':
+        dom_info.format = FORMAT_LEGACY;
+        break;
     case 'V':
         vnc = 1;
         break;
@@ -1212,6 +1218,9 @@ int main_create(int argc, char **argv)
     case 'i':
         ignore_masks = 1;
         break;
+    case 'j':
+        dom_info.format = FORMAT_JSON;
+        break;
     case 'n':
         dryrun_only = 1;
         break;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 02:56:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 02:56:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308744.524543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0WY-0002JU-Lo; Wed, 20 Apr 2022 02:56:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308744.524543; Wed, 20 Apr 2022 02:56:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh0WY-0002JN-Iw; Wed, 20 Apr 2022 02:56:58 +0000
Received: by outflank-mailman (input) for mailman id 308744;
 Wed, 20 Apr 2022 02:56:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=80Cj=U6=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nh0WX-0002JH-RV
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 02:56:57 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 899bd0f0-c055-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 04:56:56 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23K2ukFJ093193
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 19 Apr 2022 22:56:52 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23K2uk7N093192;
 Tue, 19 Apr 2022 19:56:46 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 899bd0f0-c055-11ec-a405-831a346695d4
Date: Tue, 19 Apr 2022 19:56:46 -0700
From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH 0/2] Allow use of JSON in domain configuration files
Message-ID: <Yl92bueEn3Krh30G@mattapan.m5p.com>
References: <cover.1650422517.git.ehem+xen@m5p.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1650422517.git.ehem+xen@m5p.com>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

On Tue, Apr 19, 2022 at 07:41:57PM -0700, Elliott Mitchell wrote:
> While the traditional domain configuration file format works acceptably,
> I can see uses for having full JSON support.  As such add "-j" and "-J"
> to `xl create` to specify format.  The traditional format is the current
> default.

Crucial note here, this hasn't been properly tested yet.  Hopefully I
got this right on the first try, but since that never works I need to
advise actually testing.   %-/


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Wed Apr 20 04:33:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 04:33:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308767.524555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh21U-0004yl-SB; Wed, 20 Apr 2022 04:33:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308767.524555; Wed, 20 Apr 2022 04:33:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh21U-0004ye-Og; Wed, 20 Apr 2022 04:33:00 +0000
Received: by outflank-mailman (input) for mailman id 308767;
 Wed, 20 Apr 2022 04:32:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh21T-0004yU-PT; Wed, 20 Apr 2022 04:32:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh21T-0006OQ-Mp; Wed, 20 Apr 2022 04:32:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh21T-0003H7-7H; Wed, 20 Apr 2022 04:32:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh21T-000230-6s; Wed, 20 Apr 2022 04:32:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vovVSOe758Q5w+jOqsO4OQ1JPc51qcLqcN69iDEXsyY=; b=cy3fzOz5jVKp4FRCalVOzUL7K6
	sAca6RCUnj6yRyMb7U0WnXdRcoUUzeMabriAvW3xi6bogXH7O2nN9ADZ9vWiVFoNMCwbjj8V8/JLm
	IGblw4md4wUrfwE5tBVhL18wK+dRH7HvrMYwGYHS/heoYlH82FA/IrwtesE4J4WrCH34=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169552-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169552: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e9935146cd695188e70c10a6dda9f24ef9b63e30
X-Osstest-Versions-That:
    xen=2ce9afd68e0bacc15b5570a983fa626cc4de9dbd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 04:32:59 +0000

flight 169552 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169552/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e9935146cd695188e70c10a6dda9f24ef9b63e30
baseline version:
 xen                  2ce9afd68e0bacc15b5570a983fa626cc4de9dbd

Last test of basis   169546  2022-04-19 18:00:30 Z    0 days
Testing same since   169552  2022-04-20 01:01:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bertrand Marquis <bertrand.marquis@arm.com>
  Henry Wang <Henry.Wang@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Peng Fan <peng.fan@nxp.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2ce9afd68e..e9935146cd  e9935146cd695188e70c10a6dda9f24ef9b63e30 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 05:21:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 05:21:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308778.524566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh2lr-0002ZL-J4; Wed, 20 Apr 2022 05:20:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308778.524566; Wed, 20 Apr 2022 05:20:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh2lr-0002ZE-G1; Wed, 20 Apr 2022 05:20:55 +0000
Received: by outflank-mailman (input) for mailman id 308778;
 Wed, 20 Apr 2022 05:20:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vhSL=U6=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1nh2lp-0002Yx-Qd
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 05:20:54 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2060a.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::60a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a3e1b63a-c069-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 07:20:51 +0200 (CEST)
Received: from AM6P191CA0053.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::30)
 by DB7PR08MB4217.eurprd08.prod.outlook.com (2603:10a6:10:7d::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 05:20:46 +0000
Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:7f:cafe::72) by AM6P191CA0053.outlook.office365.com
 (2603:10a6:209:7f::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Wed, 20 Apr 2022 05:20:46 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5164.19 via Frontend Transport; Wed, 20 Apr 2022 05:20:46 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Wed, 20 Apr 2022 05:20:46 +0000
Received: from 753e7e94aab8.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1342B96E-E41D-4049-B731-89AF7C950345.1; 
 Wed, 20 Apr 2022 05:20:36 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 753e7e94aab8.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 05:20:36 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by DB9PR08MB7400.eurprd08.prod.outlook.com (2603:10a6:10:370::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 05:20:32 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::757a:6418:db32:ef54]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::757a:6418:db32:ef54%5]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 05:20:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3e1b63a-c069-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sCRvPT5tGqVtiSgddC/uOQHw4vYXTqMXlCZj29+Cv04=;
 b=YP1lDhrhSb5T0llu81CLxBa4gbHZp3lNMBiy5fnwJwj15mteVIsKY3ceK4a3PUpk7Q9CrfeRQWDlecsjfyN4fWB1Ke5KUOX7NmrAQXzju/nThpBvY4d+87SsG6vCI7pkfZmHVefMCvJ8YfIiCqV5iJIUjIK5AU3ShIPpW2h9kz4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e8854Oz1L/P0mFyLo46uFTq89q/oYz2T2OelvxOOVQrDastDabJ8MHiPRLxcBGzCK1rkH4gomFFl3coikjLQUc8ijPGUaBDaM6A4T+p+T8yrRGniW12ocTRxRtXZm5DAf2mw4oe/7p9F+1oeoTIbFNJWDImL0mFs7XjzRQQpYSi3RdBWEzEkNYBNnRfzq7Vs+goo78JjxtZ7XuBY1nu37/H+Qi5dMKmf7AO5PswTjIJGAC6PTQA+3lv3V92JaJ+pCEplgOR5Ok65oYVYLtm2M+O/gclIP67TiaUwHwESxvpG/CNMKiNgzBDJEYIekLCG1jr1ma+D6/+88+A1gE5ymA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sCRvPT5tGqVtiSgddC/uOQHw4vYXTqMXlCZj29+Cv04=;
 b=Hkib1xfTbd9261fos459RRLDUjXO46VarsUUtDQo/V9/o3KlFrQZfkMMsStDenVl5s613q+fw6xjMntHTBw0IJLxcfgHA0+Hz30FkiLBrKs/MQHGwWCQg3XoqjTEzbTjr3/sDOZjWeTsiMJsZ2E3l6LIXM0PMD+CU52ZVJgmAqfl6gkEkCWsrvBAC81NQ10dJNawgNbpGDVMMbL+ycZUGOJkeW0/cM9SBcx5njC3vIsjBDrZvPtHzj2x08m4p6TwllEbTapdyRWLeNcXCm13BDcsCPjfh2lEbU1IZaQ4ahnMoUjkks+G69Kio9SSVjy1mjxhVDrj2ldfUX75TGhatw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sCRvPT5tGqVtiSgddC/uOQHw4vYXTqMXlCZj29+Cv04=;
 b=YP1lDhrhSb5T0llu81CLxBa4gbHZp3lNMBiy5fnwJwj15mteVIsKY3ceK4a3PUpk7Q9CrfeRQWDlecsjfyN4fWB1Ke5KUOX7NmrAQXzju/nThpBvY4d+87SsG6vCI7pkfZmHVefMCvJ8YfIiCqV5iJIUjIK5AU3ShIPpW2h9kz4=
From: Henry Wang <Henry.Wang@arm.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Julien Grall <Julien.Grall@arm.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jiamei Xie <Jiamei.Xie@arm.com>, Oleksandr
 Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: RE: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
Thread-Topic: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
Thread-Index: AQHYS3WQHsQlT+jCYUK0AMl/K/Wipqz4VTPg
Date: Wed, 20 Apr 2022 05:20:32 +0000
Message-ID:
 <PA4PR08MB6253F275EE7374EA556A076B92F59@PA4PR08MB6253.eurprd08.prod.outlook.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: DF1593E98A87E0469420CBBBDA3D3C45.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: f03339e0-419b-4e8d-f98b-08da228d864a
x-ms-traffictypediagnostic:
	DB9PR08MB7400:EE_|VE1EUR03FT008:EE_|DB7PR08MB4217:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB421749806D398C95FEF7321F92F59@DB7PR08MB4217.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 m6mQQ9i0b8qgj0h19XHEenmwTMDuo6pD9hl5xPoF3zQEE5W3xUWc6PwdsoeUQH2xEtIYbiJ6PHqakWKeA9+qq8nuL6Y5NvmHLdjMSoci6Vp9qyEJxlG0ZcCBdjyLA+15P3TPhRAm0L97KROTkIt7sHBdCX+lbNYWDTefcT5XU0F2Bun8smQzLN9b7rUyTupXB+/LKonyHMa6K9qi9Zb+koCLt9wiSWN7e3gImhJtMP6v0DknPxAT2vSPMImGZFlTyKJ9qUHHXFENtX+2NESxj3uqe4O2fr7rDpkLGk2LI8bygM+/ccpLshAqlk7S6Yo+7vcPnDsTR1khr/tKDl9jf2zM/88JAeXWDpBlsCoFuRecYWQ3shvSlIbD/I9jS68IwXHrLUIiEajOnB70MRzPMTqO1mtPqsR1vhDbjk7b5kvETiiJG1Eg1yG19Zm9hFOoaXnBhBZspmKlSYOctS+1Ib5e01HjZU2rI6zERCQu1Tvo/okrb2TLXq0otOrB5oGimDkYCMs5cSfS48NfuuEBTSYeT11KSk9h5hTMj0kwsc4z7x0uhf6cWhqks3pT/2MrWhTUhhxmcNag/BowSZxi5YFYX0N98Owov5XTsy8iR6Qy2EKSGoBre/82d7Zg3Fc7keyV/06qtMkRbr/g+kQRE35QTLnvqNtMfwz+euldIzdA02LmWY1CZ0GMWc8rNdy1SXxWdf7sIpcJGRhjV4I9fw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(76116006)(52536014)(66556008)(83380400001)(9686003)(66476007)(33656002)(66446008)(8936002)(5660300002)(66946007)(8676002)(4326008)(64756008)(110136005)(26005)(54906003)(6506007)(7696005)(55016003)(71200400001)(122000001)(38100700002)(38070700005)(2906002)(316002)(86362001)(508600001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7400
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b7575981-0564-446f-59cd-08da228d7dbc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	i8hZVktg4CI7huPmaK6dXdqePMmi3+P5NLzI1aJUgTCzz0BPzDJFt5BQV3qiMO4lN5PHIhiYdsF/DgnnbtT0AzvQu9ODJ+g06EHBBYcdnPE7q8PdbKJoNw0kEqHYdBxehnytzzdSXA3nmlXuQxNXkfzH/TK0IehrB4LEs4rQkIF9xRBbWk8fSJZWoEaNy5sE2c37FdWJwuDuZL2ivU9UhTJNUB5n/XrLvx51m1bPc5xIa/lxG8WbavWJsKOalpFpNl5+Hz1GaIERAyMf1+pNIkeuwNyg3pNNBKnw+NLW0rh3Azj3TcrEs2H0UGgNoTHQjYYjdtifmubcFPp8RFf+hzd+GV9x7gF4OTgsiSNpE8WDTU7VqptYIAcu2xtcqaYv7MEmXBOVHtAeBuOB7G6paPs/+0BD4j+rjDoVtpD+9Qr5gNUaXZPPYYKxPaQ0rwC7WYGW4I21aumkVj72Mwmx5zSpcjR4SXmZbR02wB19h5tuyRWjx/is/EtuD+bkTEhswzqW/YYR52hRhxd+rutY4RgX0pRPqilVN1WPqLKax4MnDyGy04b5CFDXRLwweUnnEJLfqAzfZNJdsvOFs+npVfHzHOShK7r7ExTTBe0yfyuSDdhazrK2LdEkw2PBeZXD+wqS1rgbXTRSYE5nxghuEppQuH685qGCQnZ9MX79JGGxE0swuqWuvWLK/vp2vh4d
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(356005)(52536014)(33656002)(81166007)(5660300002)(2906002)(107886003)(316002)(86362001)(8936002)(40460700003)(83380400001)(110136005)(54906003)(186003)(70206006)(508600001)(4326008)(47076005)(9686003)(70586007)(26005)(6506007)(336012)(7696005)(8676002)(55016003)(82310400005)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 05:20:46.4202
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f03339e0-419b-4e8d-f98b-08da228d864a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4217

SGkgT2xla3NhbmRyLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE9s
ZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hAZ21haWwuY29tPg0KPiBTdWJqZWN0OiBbUEFU
Q0ggVjcgMi8yXSBsaWJ4bDogSW50cm9kdWNlIGJhc2ljIHZpcnRpby1tbWlvIHN1cHBvcnQgb24g
QXJtDQo+IA0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPg0KPiAN
Cj4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGhlbHBlcnMgdG8gYWxsb2NhdGUgVmlydGlvIE1NSU8g
cGFyYW1zDQo+IChJUlEgYW5kIG1lbW9yeSByZWdpb24pIGFuZCBjcmVhdGUgc3BlY2lmaWMgZGV2
aWNlIG5vZGUgaW4NCj4gdGhlIEd1ZXN0IGRldmljZS10cmVlIHdpdGggYWxsb2NhdGVkIHBhcmFt
cy4gSW4gb3JkZXIgdG8gZGVhbA0KPiB3aXRoIG11bHRpcGxlIFZpcnRpbyBkZXZpY2VzLCByZXNl
cnZlIGNvcnJlc3BvbmRpbmcgcmFuZ2VzLg0KPiBGb3Igbm93LCB3ZSByZXNlcnZlIDFNQiBmb3Ig
bWVtb3J5IHJlZ2lvbnMgYW5kIDEwIFNQSXMuDQo+IA0KPiBBcyB0aGVzZSBoZWxwZXJzIHNob3Vs
ZCBiZSB1c2VkIGZvciBldmVyeSBWaXJ0aW8gZGV2aWNlIGF0dGFjaGVkDQo+IHRvIHRoZSBHdWVz
dCwgY2FsbCB0aGVtIGZvciBWaXJ0aW8gZGlzayhzKS4NCj4gDQo+IFBsZWFzZSBub3RlLCB3aXRo
IHN0YXRpY2FsbHkgYWxsb2NhdGVkIFZpcnRpbyBJUlFzIHRoZXJlIGlzDQo+IGEgcmlzayBvZiBh
IGNsYXNoIHdpdGggYSBwaHlzaWNhbCBJUlFzIG9mIHBhc3N0aHJvdWdoIGRldmljZXMuDQo+IEZv
ciB0aGUgZmlyc3QgdmVyc2lvbiwgaXQncyBmaW5lLCBidXQgd2Ugc2hvdWxkIGNvbnNpZGVyIGFs
bG9jYXRpbmcNCj4gdGhlIFZpcnRpbyBJUlFzIGF1dG9tYXRpY2FsbHkuIFRoYW5rZnVsbHksIHdl
IGtub3cgaW4gYWR2YW5jZSB3aGljaA0KPiBJUlFzIHdpbGwgYmUgdXNlZCBmb3IgcGFzc3Rocm91
Z2ggdG8gYmUgYWJsZSB0byBjaG9vc2Ugbm9uLWNsYXNoZWQNCj4gb25lcy4NCj4gDQo+IFNpZ25l
ZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+DQo+IFNpZ25lZC1v
ZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNv
bT4NCj4gVGVzdGVkLWJ5OiBKaWFtZWkgWGllIDxKaWFtZWkueGllQGFybS5jb20+DQo+IFJldmll
d2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IC0tLQ0KPiBASmlhbWVp
LCBASGVucnkgSSBkZWNpZGVkIHRvIGxlYXZlIHlvdXIgVC1iIGFuZCBSLWIgdGFncyB3aXRoIHRo
ZSBtaW5vcg0KPiBjaGFuZ2UgSSBtYWRlLCBhcmUgeW91IHN0aWxsIGhhcHB5IHdpdGggdGhhdD8N
Cg0KU29ycnkgZm9yIHRoZSBsYXRlIHJlc3BvbnNlLCBqdXN0IGNoZWNrZWQgdGhlIGNvZGUgYW5k
IHllcyBJIGFtIGhhcHB5IHdpdGgNCmtlZXBpbmcgbXkgUmV2aWV3ZWQtYnkuIFRoYW5rcyBmb3Ig
eW91ciBlZmZvcnQgaW4gcmViYXNpbmcgdGhlIHBhdGNoIQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5y
eQ0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 05:21:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 05:21:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308781.524577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh2mq-0003Gc-Ur; Wed, 20 Apr 2022 05:21:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308781.524577; Wed, 20 Apr 2022 05:21:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh2mq-0003GV-Rf; Wed, 20 Apr 2022 05:21:56 +0000
Received: by outflank-mailman (input) for mailman id 308781;
 Wed, 20 Apr 2022 05:21:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh2mq-0003GJ-80; Wed, 20 Apr 2022 05:21:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh2mq-0007XD-4l; Wed, 20 Apr 2022 05:21:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh2mp-00059W-OK; Wed, 20 Apr 2022 05:21:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh2mp-00081w-Nu; Wed, 20 Apr 2022 05:21:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6GizaCQIvtCW5rD2dQU+ymdnkayTXn/P6hq0Y9W2sgY=; b=vcMMpxcllLn91roZutrPrujKEw
	S2FtZiLHy4Y8F5biYvlNy4UBSDHY16Qf4+oWp0QNMQeptaAIIuMFImu2IU6mZhU7wwQA5CMZEPgm4
	AHEoyi3bOGBx6cGbdNATyVdSatDPgTDltq5uMeRKlgra9mccA/Zpuho7XMaB67JG4toc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169554-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169554: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 05:21:55 +0000

flight 169554 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169554/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  514 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 05:47:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 05:47:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308791.524588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3Az-000616-2a; Wed, 20 Apr 2022 05:46:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308791.524588; Wed, 20 Apr 2022 05:46:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3Ay-00060z-UE; Wed, 20 Apr 2022 05:46:52 +0000
Received: by outflank-mailman (input) for mailman id 308791;
 Wed, 20 Apr 2022 05:46:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BWYm=U6=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nh3Ax-00060t-7M
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 05:46:51 +0000
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4331fa75-c06d-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 07:46:47 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Apr 2022 22:46:45 -0700
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
 by FMSMGA003.fm.intel.com with ESMTP; 19 Apr 2022 22:46:44 -0700
Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by
 ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 22:46:44 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
 orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 22:46:44 -0700
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174)
 by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 19 Apr 2022 22:46:43 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BYAPR11MB3544.namprd11.prod.outlook.com (2603:10b6:a03:b5::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 05:46:40 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 05:46:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4331fa75-c06d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650433607; x=1681969607;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=kfZMaU2QwMVCrM0pkLG060VabKmuKgmoqiJJDcp7+nE=;
  b=Z8CBSxGJVz1Rw0ioMnUdARe5D3syaxHRqQ4Swy1Zfpi8Veap6Z7p5SR4
   DGPQncVX/DkgI0w5Uh1rhGubHq1tkAdG9bdXIYGSlfZ39nZmjnxa/G4Cc
   Z6odSgZX2yQR4FCec4HYXJLbbRLRKRzEAJ0Mjb9witcw701lDxDpEHhgo
   r9QcXS8FnDgQ2JckYhp6BF2rht0LCElbo7QoiqhbjejgZ7m/DU8MZAF4S
   DIZxTP5I6qePanTVU4mMmy3OrzPymaf0f1URwO8h/laoRAyV+nJUwgeDb
   8n0FztfoAzTJOXH+JLT2YvVmoCZtm1Q3Qs47wh/Fg05mehOSZcf1+20//
   w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="264117544"
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="264117544"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="647536045"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eTIQ8RdEVMQh2OxDR3AabjNRpIqvuC6EpinMYbGnvBP+80d3zglFPBlFxr1nWh5zb3cu33OrNZtk5uJw0PfAJSvZ5tI46XixppxJsVXAWxPCdOIIpIflpFfiEXIWxnSuXO18DkP0Ypxsmhs5d5tGx59u/d7R5u+IT1yPu7Z9E2wUVr2uiZuru9TPtsF0a+0CC+1Cevaob2W7soC6qh6ia4XDAdZkIWxi4zhhqsfH8GyPaRu/FAyg0+Xp/hgDv+W/pHQNG/YOtrFt/AHjyT2t+nkKGzddkRBunEnPQmGYhxlg4cYy/pHrBBi/W/sFR8rxoSC2Yu9yQwmBAPS+P7wjrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kfZMaU2QwMVCrM0pkLG060VabKmuKgmoqiJJDcp7+nE=;
 b=nWYtfDT9yXZKUMDCne+QZexqw+8zrLxUHkv/gjHRa6Rhjba12phtWLqfYCRTUEmj64h1LdbS2h7L0YG0vwR/ux1ZshkAUO7oRRDlsls5UeasB7Eqjh6TVizdwsn0RbKPMByUvgVUWeL6g0WxsekKhm+uEwjKCFEpZGLVWwf1yse7kow0oqmyu2mduacPLj5sFR/oAkpobPdhnSmBNa47ls1YABs1SuewZeRjaK8rco+H3Bw9l9FGoZJm1kwcigPGX548jQweF7wtPlCTywpaT5UHIjc1RKEA8BHuHLpYCFhB3rQ9qJGks4y8MkU2sd+neCV5o8Od1DdOHFg5NZiUUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jane Malalane <jane.malalane@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, "Gross,
 Jurgen" <jgross@suse.com>, "Cooper, Andrew" <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, "Beulich, Jan" <JBeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, "Nakajima, Jun" <jun.nakajima@intel.com>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH v9 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v9 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYRbX0UWJTzhxgikOagn+kbFuB6az4aGTg
Date: Wed, 20 Apr 2022 05:46:39 +0000
Message-ID: <BN9PR11MB52765DCCA9977444516EF9AD8CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220401104713.22291-1-jane.malalane@citrix.com>
 <20220401104713.22291-2-jane.malalane@citrix.com>
In-Reply-To: <20220401104713.22291-2-jane.malalane@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 014f297c-5161-4dda-0c8b-08da22912431
x-ms-traffictypediagnostic: BYAPR11MB3544:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BYAPR11MB3544972466AB07641E4FA1488CF59@BYAPR11MB3544.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: jO3LwDeBa0ZAIe4bmlhoGe3sm85uMTJc5V+yyHBZH6/NvSjDeojZUjDp3+PBkwXsQgtJ9x1VGE7f+GmEj/KdMYOJsKUks5ps3AqEWbudPUK81TfU6QCiFWHncw4rdavusRjAzJvLVQzSXmoEEK2mDkg/n2NoDTYV/w49hpmsM91ivT9ggpgqqiEut+da5fEREBIj6mRII7zkaxZac/YqknLMOGQ1J9XTDAayM1VCWXUILwYH9Gpw6NoG3iX7UZ3BZSk0mjiIqjJcJW1lV64OGPPMkSILhmFbSt4nP2fyUq8UCMyv1fQxH/hnlATAA2ZCVeoX78hNTFRmLo3d8I1Gr9/vgpAAOz9D3nlYP7s2i9LNVvwTKQ2uxqGCcSoOcpaJfg9FSOtmW3sQ6yzNAlHpXBat57I5VBke3b1k/vKOwkcXIcbcF7l1yfP0WhrItOkVRvwvvsZwPtYTbdtUJQ9giMVitWPULnsySmh1ma7kRv8OhDw+CiIsAOScWbSJ48PD+vfFF2CzGrUunpuwWWfWmPiDhMDRr0cPWOCb+NkxjoiStEP92jpk9wZn7x7oWcWlF1rGJySp0mB9f9GvCZvisdwwmT5p2GIlZZ7cQyesYp5GipJ4UEzz9Mnup07k4aHsQDFnK823gtetQqVBc4KTa8092t0S6FPIb6Yn2kWJouvad+dRjqIb8B5+aDR31sksqrV8OJLMSa3KLK0no7MjLvRjMQDgClyensAt3oVb33k=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(71200400001)(54906003)(122000001)(38070700005)(82960400001)(33656002)(66476007)(66446008)(186003)(38100700002)(8676002)(66556008)(4326008)(316002)(64756008)(66946007)(76116006)(26005)(508600001)(6506007)(30864003)(7696005)(55016003)(110136005)(52536014)(7416002)(9686003)(86362001)(8936002)(5660300002)(83380400001)(2906002)(21314003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R1ZYQTk0WWYySEtHQXMwK0MvSEZRSzFHclBDZGZtT2tjYksrNXgzZlBaSDB0?=
 =?utf-8?B?MlFwcFJzeGl6WFZxTEZlRWZOVkR1Zi9wcldiZ0dPTXVjQXc2eWtmSXVZMCtY?=
 =?utf-8?B?MnUrYkpVczFxY3lRMzBkaS9zYmNMVGlXa0JSazJldk9hNHJ2SXF0WTh0SzdE?=
 =?utf-8?B?aDF0RXRvTmtuelFSa1EzWVYvYTlhYUlhOGs2cE5MdU1iVHIrejJOQTJ0RmVI?=
 =?utf-8?B?SUlOd0ZzRmdMa0t0K011ZDk5eEZiS1JjZk9ReHIrSzJ3T0lzN1F6NmlxdGhP?=
 =?utf-8?B?YkJRV2lCMktWcHRWWEQwVExveXRsbmVXK1B0YjJHcXQwS2dzN0NzdDBPKy82?=
 =?utf-8?B?YVNhUUtzZzFjSEIzaFVZKzk3dDhzdmdlbm1HVy9nV1dpclh3b21sSGJka0cx?=
 =?utf-8?B?Q2xrM3VEd3RRcHRISFJxc2FjTnd3VzQ3VFVRQm1MQXg2ZDVuZmt3eUEvRy9D?=
 =?utf-8?B?S2dnT0RqWXBSczZHL2xVTnBNZXVYbmdpNUFoNGxjUEg0Q0FsU3hzQUhJc2hT?=
 =?utf-8?B?NFJ4Zy9ra1g4RzZ1SzRTT0pKeGx2QUNicGFQQWxQYkNOMEN6TzFWVnlKWm5i?=
 =?utf-8?B?Z2F3NjgydXc5RThkN0dWTmhwcEFSMEZCOXZMZHhwYUZmTzFQWUZGcGx4c2ox?=
 =?utf-8?B?RGxtdWtmbjR0OWkySVE5NlR4QkZveGFXWlhSSUpQL0l4L3FvaGtGTU5rVXFH?=
 =?utf-8?B?dkxnU0pndzhsekI5TzF3dVpSeEF4dGNIZHFVQkdtUUFOWHdVQ0w0T3dNRU9H?=
 =?utf-8?B?K3RkSDJybjQyZWp0cmlmemxsRlVKK2xYZ3I2RzhzaXpCdFN2N0g1QnZJZDRx?=
 =?utf-8?B?YmhXdnFjdzF0Ni9EOEZYTlNISGNLNmNaQTNnVUJKY05TOW1SbTM3WUI2ZUc1?=
 =?utf-8?B?ai9Pc3NBbzh3YUxkWEh5YzdqYks4Y0t0aXJZL29qT0NjUERraWNPMG9LeGZ0?=
 =?utf-8?B?a1Zoc1ErMXc0Z3daUzBkVTNtbUZIUlZZTXBoYmlxNWM1OUVoSUJlQ1FkeFBL?=
 =?utf-8?B?OHJjM0RuVERWN2VUQjJnSFhQemgwZDRNdEJ6VWRYLytLdmVHOUFTQ0VNbjRp?=
 =?utf-8?B?U1Rha0F5N29oWTRKRWFsUXVUYW1LVFJQVDZOZ0R0MldjQjZQWGJGNU9heW1i?=
 =?utf-8?B?WUY3QTF5WWZpaXhoK2lsZC9zNGNpVVpCYi9ZK1FlZnRSRERGWmhianE5cy9Q?=
 =?utf-8?B?eS8ybDZrT1R2bG0wNFVsM3NLK2x5d1NRQjdJdFNpVXdrVmtqWTNzNmU3UEMx?=
 =?utf-8?B?QUxrWVZMNGJxQjg3RjEyVzBKNGVqWVpJRWZqN2tuSWU3WFBqdzNKeis4ck9K?=
 =?utf-8?B?NCtiT0pHYW9scjVhTWxDUnlDbEE5M2h2S05JV24yNi9lS1dSSzdxTWZmNHc0?=
 =?utf-8?B?V2xmNnFLWFhKUXRSbXh0eUlyVUcvUnlQcFJmb0lrbEtTc1F3WDFVNCt3V3Vs?=
 =?utf-8?B?Q0dCOG9xSzhWeXVMVGtSeEFnSGVaTGZaT0FOanBLSFZLdjAyUW5xdE1mTHNx?=
 =?utf-8?B?SmNyQWZILytFN0JFRmxianNCSXBQYVlrNmtKNzByM0h0UklZLy9GWFNja2dQ?=
 =?utf-8?B?WEtrTjllcWptS1czUUY0ajh4ZG1MUk9pRVViZG5VZVRTKzJtbFVBZFRtaWRw?=
 =?utf-8?B?S0tBaFZEQjRHckJnK2RnRDJwWlR0V2JrelhlU0hJRDd2czE1V09rdGN5K3J3?=
 =?utf-8?B?d0kxZ1ZiV2ZsVFB2SU9KYXhPTUFQVTcyVi9KaG1xTzJ4R1lWY21FSTVXUVho?=
 =?utf-8?B?dWdudkVNQVNvS1RuSENvOGh2MTlKb2pjNi9UdFZuY0x0N0M4ZjBXQjB3RkVa?=
 =?utf-8?B?dVBuNHUwRVVrTXpudmlJQ0hGdFJndjUzQnc2c0hkQXc1RkpjU0tvaHpWTVN3?=
 =?utf-8?B?ZXUvYkpldEx4ZnNSSjdMODIwb2ZOYWJKeXZrVVJORW1TenM1MWl3RE1wUVJx?=
 =?utf-8?B?anFhQXBMNnJEZVRQcGYxNjBQQlRvc2JsLzBXTkdPaVIyR2s2bkU1dWwxMmhy?=
 =?utf-8?B?SUZGVTkwcXpmTDZnWmpQMzhYLzJmV2NXbUhhRUxvRVF3TlBGOFhFSk9WTEM2?=
 =?utf-8?B?cHJJb0c4Uzd3dEoyL0tuV2dJTnVQU1hEdUVvU1ZFd3ZiNmMrZVZobGRSNTl2?=
 =?utf-8?B?ZmhHREwyVnBlL1hQZThRQm9WMjZDRXJJSkxwTUszVGd0b3o4RWFNYXExUXhC?=
 =?utf-8?B?dWdIckNZMG4wQ1huclpKZmphbkNpSFZ5TDBmeTVtSFA5dTRyZ0FXVUZMYzBP?=
 =?utf-8?B?b1BTeVRiaVg0RjEvb3R2OWpibm83VmpIcnpUZENacXlqUHI5Rk0rVzIrY1JX?=
 =?utf-8?B?UzFleVhmMU5vVnN0RHA5ZGhsWE5CcjJvc21IMmQ3NnlJQ0RrRHJQQT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 014f297c-5161-4dda-0c8b-08da22912431
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 05:46:39.7122
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VvJyIBUj4UYiQR0xZOA8Outtb7It5rSvm7DNWZN5DQyYDpizlU8kInFKq5cLLeX2t+sOkRleaoM0IMMj/zL7uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3544
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW5lIE1hbGFsYW5lIDxqYW5lLm1hbGFsYW5lQGNpdHJpeC5jb20+DQo+IFNlbnQ6
IEZyaWRheSwgQXByaWwgMSwgMjAyMiA2OjQ3IFBNDQo+IA0KPiBBZGQgWEVOX1NZU0NUTF9QSFlT
Q0FQX1g4Nl9BU1NJU1RFRF9YQVBJQyBhbmQNCj4gWEVOX1NZU0NUTF9QSFlTQ0FQX1g4Nl9BU1NJ
U1RFRF9YMkFQSUMgdG8gcmVwb3J0IGFjY2VsZXJhdGVkIHhBUElDDQo+IGFuZA0KPiB4MkFQSUMs
IG9uIHg4NiBoYXJkd2FyZS4gVGhpcyBpcyBzbyB0aGF0IHhBUElDIGFuZCB4MkFQSUMgdmlydHVh
bGl6YXRpb24NCj4gY2FuIHN1YnNlcXVlbnRseSBiZSBlbmFibGVkIG9uIGEgcGVyLWRvbWFpbiBi
YXNpcy4NCj4gTm8gc3VjaCBmZWF0dXJlcyBhcmUgY3VycmVudGx5IGltcGxlbWVudGVkIG9uIEFN
RCBoYXJkd2FyZS4NCj4gDQo+IEhXIGFzc2lzdGVkIHhBUElDIHZpcnR1YWxpemF0aW9uIHdpbGwg
YmUgcmVwb3J0ZWQgaWYgSFcsIGF0IHRoZQ0KPiBtaW5pbXVtLCBzdXBwb3J0cyB2aXJ0dWFsaXpl
X2FwaWNfYWNjZXNzZXMgYXMgdGhpcyBmZWF0dXJlIGFsb25lIG1lYW5zDQo+IHRoYXQgYW4gYWNj
ZXNzIHRvIHRoZSBBUElDIHBhZ2Ugd2lsbCBjYXVzZSBhbiBBUElDLWFjY2VzcyBWTSBleGl0LiBB
bg0KPiBBUElDLWFjY2VzcyBWTSBleGl0IHByb3ZpZGVzIGEgVk1NIHdpdGggaW5mb3JtYXRpb24g
YWJvdXQgdGhlIGFjY2Vzcw0KPiBjYXVzaW5nIHRoZSBWTSBleGl0LCB1bmxpa2UgYSByZWd1bGFy
IEVQVCBmYXVsdCwgdGh1cyBzaW1wbGlmeWluZyBzb21lDQo+IGludGVybmFsIGhhbmRsaW5nLg0K
PiANCj4gSFcgYXNzaXN0ZWQgeDJBUElDIHZpcnR1YWxpemF0aW9uIHdpbGwgYmUgcmVwb3J0ZWQg
aWYgSFcgc3VwcG9ydHMNCj4gdmlydHVhbGl6ZV94MmFwaWNfbW9kZSBhbmQsIGF0IGxlYXN0LCBl
aXRoZXIgYXBpY19yZWdfdmlydCBvcg0KPiB2aXJ0dWFsX2ludHJfZGVsaXZlcnkuIFRoaXMgYWxz
byBtZWFucyB0aGF0DQo+IHN5c2N0bCBmb2xsb3dzIHRoZSBjb25kaXRpb25hbHMgaW4gdm14X3Zs
YXBpY19tc3JfY2hhbmdlZCgpLg0KPiANCj4gRm9yIHRoYXQgcHVycG9zZSwgYWxzbyBhZGQgYW4g
YXJjaC1zcGVjaWZpYyAiY2FwYWJpbGl0aWVzIiBwYXJhbWV0ZXINCj4gdG8gc3RydWN0IHhlbl9z
eXNjdGxfcGh5c2luZm8uDQo+IA0KPiBOb3RlIHRoYXQgdGhpcyBpbnRlcmZhY2UgaXMgaW50ZW5k
ZWQgdG8gYmUgY29tcGF0aWJsZSB3aXRoIEFNRCBzbyB0aGF0DQo+IEFWSUMgc3VwcG9ydCBjYW4g
YmUgaW50cm9kdWNlZCBpbiBhIGZ1dHVyZSBwYXRjaC4gVW5saWtlIEludGVsIHRoYXQNCj4gaGFz
IG11bHRpcGxlIGNvbnRyb2xzIGZvciBBUElDIFZpcnR1YWxpemF0aW9uLCBBTUQgaGFzIG9uZSBn
bG9iYWwNCj4gJ0FWSUMgRW5hYmxlJyBjb250cm9sIGJpdCwgc28gZmluZS1ncmFpbmluZyBvZiBB
UElDIHZpcnR1YWxpemF0aW9uDQo+IGNvbnRyb2wgY2Fubm90IGJlIGRvbmUgb24gYSBjb21tb24g
aW50ZXJmYWNlLg0KPiANCj4gU3VnZ2VzdGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v
cGVyM0BjaXRyaXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW5lIE1hbGFsYW5lIDxqYW5lLm1h
bGFsYW5lQGNpdHJpeC5jb20+DQoNClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFu
QGludGVsLmNvbT4NCg0KPiAtLS0NCj4gQ0M6IFdlaSBMaXUgPHdsQHhlbi5vcmc+DQo+IENDOiBB
bnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCj4gQ0M6IEp1ZXJnZW4g
R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gQ0M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w
ZXIzQGNpdHJpeC5jb20+DQo+IENDOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJp
eC5jb20+DQo+IENDOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IENDOiBKdWxp
ZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh
YmVsbGluaUBrZXJuZWwub3JnPg0KPiBDQzogVm9sb2R5bXlyIEJhYmNodWsgPFZvbG9keW15cl9C
YWJjaHVrQGVwYW0uY29tPg0KPiBDQzogQmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVp
c0Bhcm0uY29tPg0KPiBDQzogSnVuIE5ha2FqaW1hIDxqdW4ubmFrYWppbWFAaW50ZWwuY29tPg0K
PiBDQzogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQo+IENDOiAiUm9nZXIgUGF1
IE1vbm7DqSIgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiANCj4gdjk6DQo+ICAqIE1vdmUgYXNz
aXN0ZWRfeHsyfWFwaWNfYXZhaWxhYmxlIHRvIHZteF92bWNzX2luaXQoKSBzbyB0aGV5IGdldA0K
PiAgICBkZWNsYXJlZCBhdCBib290IHRpbWUsIGFmdGVyIHZteF9zZWNvbmRhcnlfZXhlY19jb250
cm9sIGlzIHNldA0KPiANCj4gdjg6DQo+ICAqIEltcHJvdmUgY29tbWl0IG1lc3NhZ2UNCj4gDQo+
IHY3Og0KPiAgKiBNYWtlIHN1cmUgYXNzaXN0ZWRfeHsyfWFwaWNfYXZhaWxhYmxlIGV2YWx1YXRl
cyB0byBmYWxzZSwgdG8gZW5zdXJlDQo+ICAgIFhlbiBidWlsZHMsIHdoZW4gIUNPTkZJR19IVk0N
Cj4gICogRml4IGNvZGluZyBzdHlsZSBpc3N1ZXMNCj4gDQo+IHY2Og0KPiAgKiBMaW1pdCBhYmkg
Y2hlY2sgdG8geDg2DQo+ICAqIEZpeCBjb2Rpbmcgc3R5bGUgaXNzdWUNCj4gDQo+IHY1Og0KPiAg
KiBIYXZlIGFzc2lzdGVkX3hhcGljX2F2YWlsYWJsZSBzb2xlbHkgZGVwZW5kIG9uDQo+ICAgIGNw
dV9oYXNfdm14X3ZpcnR1YWxpemVfYXBpY19hY2Nlc3NlcyBhbmQgYXNzaXN0ZWRfeDJhcGljX2F2
YWlsYWJsZQ0KPiAgICBkZXBlbmQgb24gY3B1X2hhc192bXhfdmlydHVhbGl6ZV94MmFwaWNfbW9k
ZSBhbmQNCj4gICAgY3B1X2hhc192bXhfYXBpY19yZWdfdmlydCBPUiBjcHVfaGFzX3ZteF92aXJ0
dWFsX2ludHJfZGVsaXZlcnkNCj4gDQo+IHY0Og0KPiAgKiBGYWxsYmFjayB0byB0aGUgb3JpZ2lu
YWwgdjIvdjEgY29uZGl0aW9ucyBmb3Igc2V0dGluZw0KPiAgICBhc3Npc3RlZF94YXBpY19hdmFp
bGFibGUgYW5kIGFzc2lzdGVkX3gyYXBpY19hdmFpbGFibGUgc28gdGhhdCBpbg0KPiAgICB0aGUg
ZnV0dXJlIEFQSUMgdmlydHVhbGl6YXRpb24gY2FuIGJlIGV4cG9zZWQgb24gQU1EIGhhcmR3YXJl
DQo+ICAgIHNpbmNlIGZpbmUtZ3JhaW5pbmcgb2YgIkFWSUMiIGlzIG5vdCBzdXBwb3J0ZWQsIGku
ZS4sIEFNRCBzb2xlbHkNCj4gICAgdXNlcyAiQVZJQyBFbmFibGUiLiBUaGlzIGFsc28gbWVhbnMg
dGhhdCBzeXNjdGwgbWltaWNzIHdoYXQncw0KPiAgICBleHBvc2VkIGluIENQVUlEDQo+IA0KPiB2
MzoNCj4gICogRGVmaW5lIFhFTl9TWVNDVExfUEhZU0NBUF9BUkNIX01BWCBmb3IgQUJJIGNoZWNr
aW5nIGFuZCBhY3R1YWxseQ0KPiAgICBzZXQgImFyY2hfY2FwYmlsaXRpZXMiLCB2aWEgYSBjYWxs
IHRvIGNfYml0bWFwX3RvX29jYW1sX2xpc3QoKQ0KPiAgKiBIYXZlIGFzc2lzdGVkX3gyYXBpY19h
dmFpbGFibGUgb25seSBkZXBlbmQgb24NCj4gICAgY3B1X2hhc192bXhfdmlydHVhbGl6ZV94MmFw
aWNfbW9kZQ0KPiANCj4gdjI6DQo+ICAqIFVzZSBvbmUgbWFjcm8gTElCWExfSEFWRV9QSFlTSU5G
T19BU1NJU1RFRF9BUElDIGluc3RlYWQgb2YgdHdvDQo+ICAqIFBhc3MgeGNweXNoaW5mbyBhcyBh
IHBvaW50ZXIgaW4gbGlieGxfX2FyY2hfZ2V0X3BoeXNpbmZvDQo+ICAqIFNldCBhc3Npc3RlZF94
ezJ9YXBpY19hdmFpbGFibGUgdG8gYmUgY29uZGl0aW9uYWwgdXBvbiAiYnNwIiBhbmQNCj4gICAg
YW5ub3RhdGUgaXQgd2l0aCBfX3JvX2FmdGVyX2luaXQNCj4gICogQ2hhbmdlIFhFTl9TWVNDVExf
UEhZU0NBUF9BUkNIX0FTU0lTVEVEX1h7Mn1BUElDIHRvDQo+ICAgIF9YODZfQVNTSVNURURfWHsy
fUFQSUMNCj4gICogS2VlcCBYRU5fU1lTQ1RMX1BIWVNDQVBfWDg2X0FTU0lTVEVEX1h7Mn1BUElD
IGNvbnRhaW5lZCB3aXRoaW4NCj4gICAgc3lzY3RsLmgNCj4gICogRml4IHBhZGRpbmcgaW50cm9k
dWNlZCBpbiBzdHJ1Y3QgeGVuX3N5c2N0bF9waHlzaW5mbyBhbmQgYnVtcA0KPiAgICBYRU5fU1lT
Q1RMX0lOVEVSRkFDRV9WRVJTSU9ODQo+IC0tLQ0KPiAgdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hl
bHBlcnMuZ2VuLmdvIHwgIDQgKysrKw0KPiAgdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdl
bi5nbyAgIHwgIDIgKysNCj4gIHRvb2xzL2luY2x1ZGUvbGlieGwuaCAgICAgICAgICAgICAgICB8
ICA3ICsrKysrKysNCj4gIHRvb2xzL2xpYnMvbGlnaHQvbGlieGwuYyAgICAgICAgICAgICB8ICAz
ICsrKw0KPiAgdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcmNoLmggICAgICAgIHwgIDQgKysrKw0K
PiAgdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYyAgICAgICAgIHwgIDUgKysrKysNCj4gIHRv
b2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsICAgICB8ICAyICsrDQo+ICB0b29scy9saWJz
L2xpZ2h0L2xpYnhsX3g4Ni5jICAgICAgICAgfCAxMSArKysrKysrKysrKw0KPiAgdG9vbHMvb2Nh
bWwvbGlicy94Yy94ZW5jdHJsLm1sICAgICAgIHwgIDUgKysrKysNCj4gIHRvb2xzL29jYW1sL2xp
YnMveGMveGVuY3RybC5tbGkgICAgICB8ICA1ICsrKysrDQo+ICB0b29scy9vY2FtbC9saWJzL3hj
L3hlbmN0cmxfc3R1YnMuYyAgfCAxNSArKysrKysrKysrKysrLS0NCj4gIHRvb2xzL3hsL3hsX2lu
Zm8uYyAgICAgICAgICAgICAgICAgICB8ICA2ICsrKystLQ0KPiAgeGVuL2FyY2gveDg2L2h2bS9o
dm0uYyAgICAgICAgICAgICAgIHwgIDMgKysrDQo+ICB4ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNz
LmMgICAgICAgICAgfCAgNiArKysrKysNCj4gIHhlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9odm0v
aHZtLmggICB8ICA1ICsrKysrDQo+ICB4ZW4vYXJjaC94ODYvc3lzY3RsLmMgICAgICAgICAgICAg
ICAgfCAgNCArKysrDQo+ICB4ZW4vaW5jbHVkZS9wdWJsaWMvc3lzY3RsLmggICAgICAgICAgfCAx
MSArKysrKysrKysrLQ0KPiAgMTcgZmlsZXMgY2hhbmdlZCwgOTMgaW5zZXJ0aW9ucygrKSwgNSBk
ZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy9nb2xhbmcveGVubGlnaHQvaGVs
cGVycy5nZW4uZ28NCj4gYi90b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28NCj4g
aW5kZXggYjc0NmZmMTA4MS4uZGQ0ZTZjOWYxNCAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvZ29sYW5n
L3hlbmxpZ2h0L2hlbHBlcnMuZ2VuLmdvDQo+ICsrKyBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9o
ZWxwZXJzLmdlbi5nbw0KPiBAQCAtMzM3Myw2ICszMzczLDggQEAgeC5DYXBWbXRyYWNlID0gYm9v
bCh4Yy5jYXBfdm10cmFjZSkNCj4gIHguQ2FwVnBtdSA9IGJvb2woeGMuY2FwX3ZwbXUpDQo+ICB4
LkNhcEdudHRhYlYxID0gYm9vbCh4Yy5jYXBfZ250dGFiX3YxKQ0KPiAgeC5DYXBHbnR0YWJWMiA9
IGJvb2woeGMuY2FwX2dudHRhYl92MikNCj4gK3guQ2FwQXNzaXN0ZWRYYXBpYyA9IGJvb2woeGMu
Y2FwX2Fzc2lzdGVkX3hhcGljKQ0KPiAreC5DYXBBc3Npc3RlZFgyQXBpYyA9IGJvb2woeGMuY2Fw
X2Fzc2lzdGVkX3gyYXBpYykNCj4gDQo+ICAgcmV0dXJuIG5pbH0NCj4gDQo+IEBAIC0zNDA3LDYg
KzM0MDksOCBAQCB4Yy5jYXBfdm10cmFjZSA9IEMuYm9vbCh4LkNhcFZtdHJhY2UpDQo+ICB4Yy5j
YXBfdnBtdSA9IEMuYm9vbCh4LkNhcFZwbXUpDQo+ICB4Yy5jYXBfZ250dGFiX3YxID0gQy5ib29s
KHguQ2FwR250dGFiVjEpDQo+ICB4Yy5jYXBfZ250dGFiX3YyID0gQy5ib29sKHguQ2FwR250dGFi
VjIpDQo+ICt4Yy5jYXBfYXNzaXN0ZWRfeGFwaWMgPSBDLmJvb2woeC5DYXBBc3Npc3RlZFhhcGlj
KQ0KPiAreGMuY2FwX2Fzc2lzdGVkX3gyYXBpYyA9IEMuYm9vbCh4LkNhcEFzc2lzdGVkWDJBcGlj
KQ0KPiANCj4gICByZXR1cm4gbmlsDQo+ICAgfQ0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvZ29sYW5n
L3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPiBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC90eXBlcy5n
ZW4uZ28NCj4gaW5kZXggYjFlODRkNTI1OC4uODdiZTQ2Yzc0NSAxMDA2NDQNCj4gLS0tIGEvdG9v
bHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPiArKysgYi90b29scy9nb2xhbmcveGVu
bGlnaHQvdHlwZXMuZ2VuLmdvDQo+IEBAIC0xMDE0LDYgKzEwMTQsOCBAQCBDYXBWbXRyYWNlIGJv
b2wNCj4gIENhcFZwbXUgYm9vbA0KPiAgQ2FwR250dGFiVjEgYm9vbA0KPiAgQ2FwR250dGFiVjIg
Ym9vbA0KPiArQ2FwQXNzaXN0ZWRYYXBpYyBib29sDQo+ICtDYXBBc3Npc3RlZFgyQXBpYyBib29s
DQo+ICB9DQo+IA0KPiAgdHlwZSBDb25uZWN0b3JpbmZvIHN0cnVjdCB7DQo+IGRpZmYgLS1naXQg
YS90b29scy9pbmNsdWRlL2xpYnhsLmggYi90b29scy9pbmNsdWRlL2xpYnhsLmgNCj4gaW5kZXgg
NTFhOWI2Y2ZhYy4uOTRlNjM1NTgyMiAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvaW5jbHVkZS9saWJ4
bC5oDQo+ICsrKyBiL3Rvb2xzL2luY2x1ZGUvbGlieGwuaA0KPiBAQCAtNTI4LDYgKzUyOCwxMyBA
QA0KPiAgI2RlZmluZSBMSUJYTF9IQVZFX01BWF9HUkFOVF9WRVJTSU9OIDENCj4gDQo+ICAvKg0K
PiArICogTElCWExfSEFWRV9QSFlTSU5GT19BU1NJU1RFRF9BUElDIGluZGljYXRlcyB0aGF0IGxp
YnhsX3BoeXNpbmZvIGhhcw0KPiArICogY2FwX2Fzc2lzdGVkX3hhcGljIGFuZCBjYXBfYXNzaXN0
ZWRfeDJhcGljIGZpZWxkcywgd2hpY2ggaW5kaWNhdGVzDQo+ICsgKiB0aGUgYXZhaWxhYmlsaXR5
IG9mIHh7Mn1BUElDIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uLg0KPiArICovDQo+
ICsjZGVmaW5lIExJQlhMX0hBVkVfUEhZU0lORk9fQVNTSVNURURfQVBJQyAxDQo+ICsNCj4gKy8q
DQo+ICAgKiBsaWJ4bCBBQkkgY29tcGF0aWJpbGl0eQ0KPiAgICoNCj4gICAqIFRoZSBvbmx5IGd1
YXJhbnRlZSB3aGljaCBsaWJ4bCBtYWtlcyByZWdhcmRpbmcgQUJJIGNvbXBhdGliaWxpdHkNCj4g
ZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGwuYyBiL3Rvb2xzL2xpYnMvbGlnaHQv
bGlieGwuYw0KPiBpbmRleCBhMGJmN2QxODZmLi42ZDY5OTk1MWUyIDEwMDY0NA0KPiAtLS0gYS90
b29scy9saWJzL2xpZ2h0L2xpYnhsLmMNCj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bC5j
DQo+IEBAIC0xNSw2ICsxNSw3IEBADQo+ICAjaW5jbHVkZSAibGlieGxfb3NkZXBzLmgiDQo+IA0K
PiAgI2luY2x1ZGUgImxpYnhsX2ludGVybmFsLmgiDQo+ICsjaW5jbHVkZSAibGlieGxfYXJjaC5o
Ig0KPiANCj4gIGludCBsaWJ4bF9jdHhfYWxsb2MobGlieGxfY3R4ICoqcGN0eCwgaW50IHZlcnNp
b24sDQo+ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGZsYWdzLCB4ZW50b29sbG9nX2xv
Z2dlciAqIGxnKQ0KPiBAQCAtNDEwLDYgKzQxMSw4IEBAIGludCBsaWJ4bF9nZXRfcGh5c2luZm8o
bGlieGxfY3R4ICpjdHgsIGxpYnhsX3BoeXNpbmZvDQo+ICpwaHlzaW5mbykNCj4gICAgICBwaHlz
aW5mby0+Y2FwX2dudHRhYl92MiA9DQo+ICAgICAgICAgICEhKHhjcGh5c2luZm8uY2FwYWJpbGl0
aWVzICYgWEVOX1NZU0NUTF9QSFlTQ0FQX2dudHRhYl92Mik7DQo+IA0KPiArICAgIGxpYnhsX19h
cmNoX2dldF9waHlzaW5mbyhwaHlzaW5mbywgJnhjcGh5c2luZm8pOw0KPiArDQo+ICAgICAgR0Nf
RlJFRTsNCj4gICAgICByZXR1cm4gMDsNCj4gIH0NCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMv
bGlnaHQvbGlieGxfYXJjaC5oIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcmNoLmgNCj4gaW5k
ZXggMTUyMmVjYjk3Zi4uMjA3Y2VhYzZhMSAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvbGlicy9saWdo
dC9saWJ4bF9hcmNoLmgNCj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcmNoLmgNCj4g
QEAgLTg2LDYgKzg2LDEwIEBAIGludCBsaWJ4bF9fYXJjaF9leHRyYV9tZW1vcnkobGlieGxfX2dj
ICpnYywNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3QgKm91dCk7DQo+
IA0KPiAgX2hpZGRlbg0KPiArdm9pZCBsaWJ4bF9fYXJjaF9nZXRfcGh5c2luZm8obGlieGxfcGh5
c2luZm8gKnBoeXNpbmZvLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg
eGNfcGh5c2luZm9fdCAqeGNwaHlzaW5mbyk7DQo+ICsNCj4gK19oaWRkZW4NCj4gIHZvaWQgbGli
eGxfX2FyY2hfdXBkYXRlX2RvbWFpbl9jb25maWcobGlieGxfX2djICpnYywNCj4gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX2NvbmZpZyAqZHN0LA0K
PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBsaWJ4bF9kb21h
aW5fY29uZmlnICpzcmMpOw0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9h
cm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4gaW5kZXggZWVmMWRlMDkzOS4u
MzlmZGNhMWI0OSAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYw0K
PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+IEBAIC0xNDMxLDYgKzE0MzEs
MTEgQEAgaW50DQo+IGxpYnhsX19hcmNoX3Bhc3N0aHJvdWdoX21vZGVfc2V0ZGVmYXVsdChsaWJ4
bF9fZ2MgKmdjLA0KPiAgICAgIHJldHVybiByYzsNCj4gIH0NCj4gDQo+ICt2b2lkIGxpYnhsX19h
cmNoX2dldF9waHlzaW5mbyhsaWJ4bF9waHlzaW5mbyAqcGh5c2luZm8sDQo+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBjb25zdCB4Y19waHlzaW5mb190ICp4Y3BoeXNpbmZvKQ0KPiAr
ew0KPiArfQ0KPiArDQo+ICB2b2lkIGxpYnhsX19hcmNoX3VwZGF0ZV9kb21haW5fY29uZmlnKGxp
YnhsX19nYyAqZ2MsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxp
YnhsX2RvbWFpbl9jb25maWcgKmRzdCwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgY29uc3QgbGlieGxfZG9tYWluX2NvbmZpZyAqc3JjKQ0KPiBkaWZmIC0tZ2l0IGEv
dG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgYi90b29scy9saWJzL2xpZ2h0L2xpYnhs
X3R5cGVzLmlkbA0KPiBpbmRleCAyYTQyZGEyZjdkLi40MmFjNmMzNTdiIDEwMDY0NA0KPiAtLS0g
YS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPiArKysgYi90b29scy9saWJzL2xp
Z2h0L2xpYnhsX3R5cGVzLmlkbA0KPiBAQCAtMTA2OCw2ICsxMDY4LDggQEAgbGlieGxfcGh5c2lu
Zm8gPSBTdHJ1Y3QoInBoeXNpbmZvIiwgWw0KPiAgICAgICgiY2FwX3ZwbXUiLCBib29sKSwNCj4g
ICAgICAoImNhcF9nbnR0YWJfdjEiLCBib29sKSwNCj4gICAgICAoImNhcF9nbnR0YWJfdjIiLCBi
b29sKSwNCj4gKyAgICAoImNhcF9hc3Npc3RlZF94YXBpYyIsIGJvb2wpLA0KPiArICAgICgiY2Fw
X2Fzc2lzdGVkX3gyYXBpYyIsIGJvb2wpLA0KPiAgICAgIF0sIGRpcj1ESVJfT1VUKQ0KPiANCj4g
IGxpYnhsX2Nvbm5lY3RvcmluZm8gPSBTdHJ1Y3QoImNvbm5lY3RvcmluZm8iLCBbDQo+IGRpZmYg
LS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3g4Ni5jIGIvdG9vbHMvbGlicy9saWdodC9s
aWJ4bF94ODYuYw0KPiBpbmRleCAxZmVhZGViYjE4Li5lMGEwNmVjZmUzIDEwMDY0NA0KPiAtLS0g
YS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3g4Ni5jDQo+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQv
bGlieGxfeDg2LmMNCj4gQEAgLTg2Niw2ICs4NjYsMTcgQEAgaW50DQo+IGxpYnhsX19hcmNoX3Bh
c3N0aHJvdWdoX21vZGVfc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPiAgICAgIHJldHVybiBy
YzsNCj4gIH0NCj4gDQo+ICt2b2lkIGxpYnhsX19hcmNoX2dldF9waHlzaW5mbyhsaWJ4bF9waHlz
aW5mbyAqcGh5c2luZm8sDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCB4
Y19waHlzaW5mb190ICp4Y3BoeXNpbmZvKQ0KPiArew0KPiArICAgIHBoeXNpbmZvLT5jYXBfYXNz
aXN0ZWRfeGFwaWMgPQ0KPiArICAgICAgICAhISh4Y3BoeXNpbmZvLT5hcmNoX2NhcGFiaWxpdGll
cyAmDQo+ICsgICAgICAgICAgIFhFTl9TWVNDVExfUEhZU0NBUF9YODZfQVNTSVNURURfWEFQSUMp
Ow0KPiArICAgIHBoeXNpbmZvLT5jYXBfYXNzaXN0ZWRfeDJhcGljID0NCj4gKyAgICAgICAgISEo
eGNwaHlzaW5mby0+YXJjaF9jYXBhYmlsaXRpZXMgJg0KPiArICAgICAgICAgICBYRU5fU1lTQ1RM
X1BIWVNDQVBfWDg2X0FTU0lTVEVEX1gyQVBJQyk7DQo+ICt9DQo+ICsNCj4gIHZvaWQgbGlieGxf
X2FyY2hfdXBkYXRlX2RvbWFpbl9jb25maWcobGlieGxfX2djICpnYywNCj4gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX2NvbmZpZyAqZHN0LA0KPiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBsaWJ4bF9kb21haW5f
Y29uZmlnICpzcmMpDQo+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwu
bWwgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwNCj4gaW5kZXggNzUwMzAzMWQ4Zi4u
NzEyNDU2ZTA5OCAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1s
DQo+ICsrKyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KPiBAQCAtMTI3LDYgKzEy
NywxMCBAQCB0eXBlIHBoeXNpbmZvX2NhcF9mbGFnID0NCj4gIAl8IENBUF9HbnR0YWJfdjENCj4g
IAl8IENBUF9HbnR0YWJfdjINCj4gDQo+ICt0eXBlIHBoeXNpbmZvX2FyY2hfY2FwX2ZsYWcgPQ0K
PiArCXwgQ0FQX1g4Nl9BU1NJU1RFRF9YQVBJQw0KPiArCXwgQ0FQX1g4Nl9BU1NJU1RFRF9YMkFQ
SUMNCj4gKw0KPiAgdHlwZSBwaHlzaW5mbyA9DQo+ICB7DQo+ICAJdGhyZWFkc19wZXJfY29yZSA6
IGludDsNCj4gQEAgLTE0MCw2ICsxNDQsNyBAQCB0eXBlIHBoeXNpbmZvID0NCj4gIAkoKiBYWFgg
aHdfY2FwICopDQo+ICAJY2FwYWJpbGl0aWVzICAgICA6IHBoeXNpbmZvX2NhcF9mbGFnIGxpc3Q7
DQo+ICAJbWF4X25yX2NwdXMgICAgICA6IGludDsNCj4gKwlhcmNoX2NhcGFiaWxpdGllcyA6IHBo
eXNpbmZvX2FyY2hfY2FwX2ZsYWcgbGlzdDsNCj4gIH0NCj4gDQo+ICB0eXBlIHZlcnNpb24gPQ0K
PiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saSBiL3Rvb2xzL29j
YW1sL2xpYnMveGMveGVuY3RybC5tbGkNCj4gaW5kZXggZDFkOWM5MjQ3YS4uYjAzNDQzNGY2OCAx
MDA2NDQNCj4gLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saQ0KPiArKysgYi90
b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpDQo+IEBAIC0xMTIsNiArMTEyLDEwIEBAIHR5
cGUgcGh5c2luZm9fY2FwX2ZsYWcgPQ0KPiAgICB8IENBUF9HbnR0YWJfdjENCj4gICAgfCBDQVBf
R250dGFiX3YyDQo+IA0KPiArdHlwZSBwaHlzaW5mb19hcmNoX2NhcF9mbGFnID0NCj4gKyAgfCBD
QVBfWDg2X0FTU0lTVEVEX1hBUElDDQo+ICsgIHwgQ0FQX1g4Nl9BU1NJU1RFRF9YMkFQSUMNCj4g
Kw0KPiAgdHlwZSBwaHlzaW5mbyA9IHsNCj4gICAgdGhyZWFkc19wZXJfY29yZSA6IGludDsNCj4g
ICAgY29yZXNfcGVyX3NvY2tldCA6IGludDsNCj4gQEAgLTEyMyw2ICsxMjcsNyBAQCB0eXBlIHBo
eXNpbmZvID0gew0KPiAgICBzY3J1Yl9wYWdlcyAgICAgIDogbmF0aXZlaW50Ow0KPiAgICBjYXBh
YmlsaXRpZXMgICAgIDogcGh5c2luZm9fY2FwX2ZsYWcgbGlzdDsNCj4gICAgbWF4X25yX2NwdXMg
ICAgICA6IGludDsgKCoqIGNvbXBpbGUtdGltZSBtYXggcG9zc2libGUgbnVtYmVyIG9mIG5yX2Nw
dXMgKikNCj4gKyAgYXJjaF9jYXBhYmlsaXRpZXMgOiBwaHlzaW5mb19hcmNoX2NhcF9mbGFnIGxp
c3Q7DQo+ICB9DQo+ICB0eXBlIHZlcnNpb24gPSB7IG1ham9yIDogaW50OyBtaW5vciA6IGludDsg
ZXh0cmEgOiBzdHJpbmc7IH0NCj4gIHR5cGUgY29tcGlsZV9pbmZvID0gew0KPiBkaWZmIC0tZ2l0
IGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMNCj4gYi90b29scy9vY2FtbC9s
aWJzL3hjL3hlbmN0cmxfc3R1YnMuYw0KPiBpbmRleCA1YjRmZTcyYzhkLi43ZTljMzJhZDFiIDEw
MDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYw0KPiArKysg
Yi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYw0KPiBAQCAtNzEyLDcgKzcxMiw3
IEBAIENBTUxwcmltIHZhbHVlIHN0dWJfeGNfc2VuZF9kZWJ1Z19rZXlzKHZhbHVlDQo+IHhjaCwg
dmFsdWUga2V5cykNCj4gIENBTUxwcmltIHZhbHVlIHN0dWJfeGNfcGh5c2luZm8odmFsdWUgeGNo
KQ0KPiAgew0KPiAgCUNBTUxwYXJhbTEoeGNoKTsNCj4gLQlDQU1MbG9jYWwyKHBoeXNpbmZvLCBj
YXBfbGlzdCk7DQo+ICsJQ0FNTGxvY2FsMyhwaHlzaW5mbywgY2FwX2xpc3QsIGFyY2hfY2FwX2xp
c3QpOw0KPiAgCXhjX3BoeXNpbmZvX3QgY19waHlzaW5mbzsNCj4gIAlpbnQgcjsNCj4gDQo+IEBA
IC03MzEsNyArNzMxLDcgQEAgQ0FNTHByaW0gdmFsdWUgc3R1Yl94Y19waHlzaW5mbyh2YWx1ZSB4
Y2gpDQo+ICAJCS8qICEgWEVOX1NZU0NUTF9QSFlTQ0FQXyBYRU5fU1lTQ1RMX1BIWVNDQVBfTUFY
IG1heA0KPiAqLw0KPiAgCQkoY19waHlzaW5mby5jYXBhYmlsaXRpZXMpOw0KPiANCj4gLQlwaHlz
aW5mbyA9IGNhbWxfYWxsb2NfdHVwbGUoMTApOw0KPiArCXBoeXNpbmZvID0gY2FtbF9hbGxvY190
dXBsZSgxMSk7DQo+ICAJU3RvcmVfZmllbGQocGh5c2luZm8sIDAsIFZhbF9pbnQoY19waHlzaW5m
by50aHJlYWRzX3Blcl9jb3JlKSk7DQo+ICAJU3RvcmVfZmllbGQocGh5c2luZm8sIDEsIFZhbF9p
bnQoY19waHlzaW5mby5jb3Jlc19wZXJfc29ja2V0KSk7DQo+ICAJU3RvcmVfZmllbGQocGh5c2lu
Zm8sIDIsIFZhbF9pbnQoY19waHlzaW5mby5ucl9jcHVzKSk7DQo+IEBAIC03NDMsNiArNzQzLDE3
IEBAIENBTUxwcmltIHZhbHVlIHN0dWJfeGNfcGh5c2luZm8odmFsdWUgeGNoKQ0KPiAgCVN0b3Jl
X2ZpZWxkKHBoeXNpbmZvLCA4LCBjYXBfbGlzdCk7DQo+ICAJU3RvcmVfZmllbGQocGh5c2luZm8s
IDksIFZhbF9pbnQoY19waHlzaW5mby5tYXhfY3B1X2lkICsgMSkpOw0KPiANCj4gKyNpZiBkZWZp
bmVkKF9faTM4Nl9fKSB8fCBkZWZpbmVkKF9feDg2XzY0X18pDQo+ICsJLyoNCj4gKwkgKiBhcmNo
X2NhcGFiaWxpdGllczogcGh5c2luZm9fYXJjaF9jYXBfZmxhZyBsaXN0Ow0KPiArCSAqLw0KPiAr
CWFyY2hfY2FwX2xpc3QgPSBjX2JpdG1hcF90b19vY2FtbF9saXN0DQo+ICsJCS8qICEgcGh5c2lu
Zm9fYXJjaF9jYXBfZmxhZyBDQVBfIG5vbmUgKi8NCj4gKwkJLyogISBYRU5fU1lTQ1RMX1BIWVND
QVBfIFhFTl9TWVNDVExfUEhZU0NBUF9YODZfTUFYDQo+IG1heCAqLw0KPiArCQkoY19waHlzaW5m
by5hcmNoX2NhcGFiaWxpdGllcyk7DQo+ICsJU3RvcmVfZmllbGQocGh5c2luZm8sIDEwLCBhcmNo
X2NhcF9saXN0KTsNCj4gKyNlbmRpZg0KPiArDQo+ICAJQ0FNTHJldHVybihwaHlzaW5mbyk7DQo+
ICB9DQo+IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMveGwveGxfaW5mby5jIGIvdG9vbHMveGwveGxf
aW5mby5jDQo+IGluZGV4IDcxMmI3NjM4YjAuLjMyMDUyNzA3NTQgMTAwNjQ0DQo+IC0tLSBhL3Rv
b2xzL3hsL3hsX2luZm8uYw0KPiArKysgYi90b29scy94bC94bF9pbmZvLmMNCj4gQEAgLTIxMCw3
ICsyMTAsNyBAQCBzdGF0aWMgdm9pZCBvdXRwdXRfcGh5c2luZm8odm9pZCkNCj4gICAgICAgICAg
IGluZm8uaHdfY2FwWzRdLCBpbmZvLmh3X2NhcFs1XSwgaW5mby5od19jYXBbNl0sIGluZm8uaHdf
Y2FwWzddDQo+ICAgICAgICAgICk7DQo+IA0KPiAtICAgIG1heWJlX3ByaW50ZigidmlydF9jYXBz
ICAgICAgICAgICAgICA6JXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwNCj4gKyAgICBtYXliZV9w
cmludGYoInZpcnRfY2FwcyAgICAgICAgICAgICAgOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVz
XG4iLA0KPiAgICAgICAgICAgaW5mby5jYXBfcHYgPyAiIHB2IiA6ICIiLA0KPiAgICAgICAgICAg
aW5mby5jYXBfaHZtID8gIiBodm0iIDogIiIsDQo+ICAgICAgICAgICBpbmZvLmNhcF9odm0gJiYg
aW5mby5jYXBfaHZtX2RpcmVjdGlvID8gIiBodm1fZGlyZWN0aW8iIDogIiIsDQo+IEBAIC0yMjEs
NyArMjIxLDkgQEAgc3RhdGljIHZvaWQgb3V0cHV0X3BoeXNpbmZvKHZvaWQpDQo+ICAgICAgICAg
ICBpbmZvLmNhcF92bXRyYWNlID8gIiB2bXRyYWNlIiA6ICIiLA0KPiAgICAgICAgICAgaW5mby5j
YXBfdnBtdSA/ICIgdnBtdSIgOiAiIiwNCj4gICAgICAgICAgIGluZm8uY2FwX2dudHRhYl92MSA/
ICIgZ250dGFiLXYxIiA6ICIiLA0KPiAtICAgICAgICAgaW5mby5jYXBfZ250dGFiX3YyID8gIiBn
bnR0YWItdjIiIDogIiINCj4gKyAgICAgICAgIGluZm8uY2FwX2dudHRhYl92MiA/ICIgZ250dGFi
LXYyIiA6ICIiLA0KPiArICAgICAgICAgaW5mby5jYXBfYXNzaXN0ZWRfeGFwaWMgPyAiIGFzc2lz
dGVkX3hhcGljIiA6ICIiLA0KPiArICAgICAgICAgaW5mby5jYXBfYXNzaXN0ZWRfeDJhcGljID8g
IiBhc3Npc3RlZF94MmFwaWMiIDogIiINCj4gICAgICAgICAgKTsNCj4gDQo+ICAgICAgdmluZm8g
PSBsaWJ4bF9nZXRfdmVyc2lvbl9pbmZvKGN0eCk7DQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94
ODYvaHZtL2h2bS5jIGIveGVuL2FyY2gveDg2L2h2bS9odm0uYw0KPiBpbmRleCA3MDlhNDE5MWVm
Li5lNWRkZTlmOGNlIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL2h2bS5jDQo+ICsr
KyBiL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMNCj4gQEAgLTExNyw2ICsxMTcsOSBAQCBzdGF0aWMg
Y29uc3QgY2hhciBfX2luaXRjb25zdCB3YXJuaW5nX2h2bV9mZXBbXSA9DQo+ICBzdGF0aWMgYm9v
bF90IF9faW5pdGRhdGEgb3B0X2FsdHAybV9lbmFibGVkID0gMDsNCj4gIGJvb2xlYW5fcGFyYW0o
ImFsdHAybSIsIG9wdF9hbHRwMm1fZW5hYmxlZCk7DQo+IA0KPiArYm9vbCBfX3JvX2FmdGVyX2lu
aXQgYXNzaXN0ZWRfeGFwaWNfYXZhaWxhYmxlOw0KPiArYm9vbCBfX3JvX2FmdGVyX2luaXQgYXNz
aXN0ZWRfeDJhcGljX2F2YWlsYWJsZTsNCj4gKw0KPiAgc3RhdGljIGludCBjZl9jaGVjayBjcHVf
Y2FsbGJhY2soDQo+ICAgICAgc3RydWN0IG5vdGlmaWVyX2Jsb2NrICpuZmIsIHVuc2lnbmVkIGxv
bmcgYWN0aW9uLCB2b2lkICpoY3B1KQ0KPiAgew0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2
L2h2bS92bXgvdm1jcy5jIGIveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jDQo+IGluZGV4IDU2
ZmVkMmRiMDMuLjUzZDk3ZWFmMTMgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14
L3ZtY3MuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4gQEAgLTIxNDUs
NiArMjE0NSwxMiBAQCBpbnQgX19pbml0IHZteF92bWNzX2luaXQodm9pZCkNCj4gDQo+ICAgICAg
cmV0ID0gX3ZteF9jcHVfdXAodHJ1ZSk7DQo+IA0KPiArICAgIC8qIENoZWNrIHdoZXRoZXIgaGFy
ZHdhcmUgc3VwcG9ydHMgYWNjZWxlcmF0ZWQgeGFwaWMgYW5kIHgyYXBpYy4gKi8NCj4gKyAgICBh
c3Npc3RlZF94YXBpY19hdmFpbGFibGUgPSBjcHVfaGFzX3ZteF92aXJ0dWFsaXplX2FwaWNfYWNj
ZXNzZXM7DQo+ICsgICAgYXNzaXN0ZWRfeDJhcGljX2F2YWlsYWJsZSA9IGNwdV9oYXNfdm14X3Zp
cnR1YWxpemVfeDJhcGljX21vZGUgJiYNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgKGNwdV9oYXNfdm14X2FwaWNfcmVnX3ZpcnQgfHwNCj4gKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGNwdV9oYXNfdm14X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSk7DQo+ICsNCj4g
ICAgICBpZiAoICFyZXQgKQ0KPiAgICAgICAgICByZWdpc3Rlcl9rZXloYW5kbGVyKCd2Jywgdm1j
c19kdW1wLCAiZHVtcCBWVC14IFZNQ1NzIiwgMSk7DQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2Fy
Y2gveDg2L2luY2x1ZGUvYXNtL2h2bS9odm0uaA0KPiBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2Fz
bS9odm0vaHZtLmgNCj4gaW5kZXggNWI3ZWMwY2Y2OS4uZTBkOTM0ODg3OCAxMDA2NDQNCj4gLS0t
IGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2h2bS9odm0uaA0KPiArKysgYi94ZW4vYXJjaC94
ODYvaW5jbHVkZS9hc20vaHZtL2h2bS5oDQo+IEBAIC0zNzMsNiArMzczLDkgQEAgaW50IGh2bV9n
ZXRfcGFyYW0oc3RydWN0IGRvbWFpbiAqZCwgdWludDMyX3QgaW5kZXgsDQo+IHVpbnQ2NF90ICp2
YWx1ZSk7DQo+ICAjZGVmaW5lIGh2bV90c2Nfc2NhbGluZ19yYXRpbyhkKSBcDQo+ICAgICAgKChk
KS0+YXJjaC5odm0udHNjX3NjYWxpbmdfcmF0aW8pDQo+IA0KPiArZXh0ZXJuIGJvb2wgYXNzaXN0
ZWRfeGFwaWNfYXZhaWxhYmxlOw0KPiArZXh0ZXJuIGJvb2wgYXNzaXN0ZWRfeDJhcGljX2F2YWls
YWJsZTsNCj4gKw0KPiAgI2RlZmluZSBodm1fZ2V0X2d1ZXN0X3RpbWUodikgaHZtX2dldF9ndWVz
dF90aW1lX2ZpeGVkKHYsIDApDQo+IA0KPiAgI2RlZmluZSBodm1fcGFnaW5nX2VuYWJsZWQodikg
XA0KPiBAQCAtODcyLDYgKzg3NSw4IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBodm1fc2V0X3JlZyhz
dHJ1Y3QgdmNwdSAqdiwNCj4gdW5zaWduZWQgaW50IHJlZywgdWludDY0X3QgdmFsKQ0KPiAgI2Rl
ZmluZSBodm1fdHNjX3NjYWxpbmdfc3VwcG9ydGVkIGZhbHNlDQo+ICAjZGVmaW5lIGhhcF9oYXNf
MWdiIGZhbHNlDQo+ICAjZGVmaW5lIGhhcF9oYXNfMm1iIGZhbHNlDQo+ICsjZGVmaW5lIGFzc2lz
dGVkX3hhcGljX2F2YWlsYWJsZSBmYWxzZQ0KPiArI2RlZmluZSBhc3Npc3RlZF94MmFwaWNfYXZh
aWxhYmxlIGZhbHNlDQo+IA0KPiAgI2RlZmluZSBodm1fcGFnaW5nX2VuYWJsZWQodikgKCh2b2lk
KSh2KSwgZmFsc2UpDQo+ICAjZGVmaW5lIGh2bV93cF9lbmFibGVkKHYpICgodm9pZCkodiksIGZh
bHNlKQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3N5c2N0bC5jIGIveGVuL2FyY2gveDg2
L3N5c2N0bC5jDQo+IGluZGV4IGY4MmFiYzI0ODguLjcxNjUyNWY3MmYgMTAwNjQ0DQo+IC0tLSBh
L3hlbi9hcmNoL3g4Ni9zeXNjdGwuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvc3lzY3RsLmMNCj4g
QEAgLTEzNSw2ICsxMzUsMTAgQEAgdm9pZCBhcmNoX2RvX3BoeXNpbmZvKHN0cnVjdCB4ZW5fc3lz
Y3RsX3BoeXNpbmZvDQo+ICpwaSkNCj4gICAgICAgICAgcGktPmNhcGFiaWxpdGllcyB8PSBYRU5f
U1lTQ1RMX1BIWVNDQVBfaGFwOw0KPiAgICAgIGlmICggSVNfRU5BQkxFRChDT05GSUdfU0hBRE9X
X1BBR0lORykgKQ0KPiAgICAgICAgICBwaS0+Y2FwYWJpbGl0aWVzIHw9IFhFTl9TWVNDVExfUEhZ
U0NBUF9zaGFkb3c7DQo+ICsgICAgaWYgKCBhc3Npc3RlZF94YXBpY19hdmFpbGFibGUgKQ0KPiAr
ICAgICAgICBwaS0+YXJjaF9jYXBhYmlsaXRpZXMgfD0gWEVOX1NZU0NUTF9QSFlTQ0FQX1g4Nl9B
U1NJU1RFRF9YQVBJQzsNCj4gKyAgICBpZiAoIGFzc2lzdGVkX3gyYXBpY19hdmFpbGFibGUgKQ0K
PiArICAgICAgICBwaS0+YXJjaF9jYXBhYmlsaXRpZXMgfD0gWEVOX1NZU0NUTF9QSFlTQ0FQX1g4
Nl9BU1NJU1RFRF9YMkFQSUM7DQo+ICB9DQo+IA0KPiAgbG9uZyBhcmNoX2RvX3N5c2N0bCgNCj4g
ZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9zeXNjdGwuaCBiL3hlbi9pbmNsdWRlL3B1
YmxpYy9zeXNjdGwuaA0KPiBpbmRleCBiMGE0YWY4Nzg5Li43ZjUyMWIzYmViIDEwMDY0NA0KPiAt
LS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvc3lzY3RsLmgNCj4gKysrIGIveGVuL2luY2x1ZGUvcHVi
bGljL3N5c2N0bC5oDQo+IEBAIC0zNSw3ICszNSw3IEBADQo+ICAjaW5jbHVkZSAiZG9tY3RsLmgi
DQo+ICAjaW5jbHVkZSAicGh5c2Rldi5oIg0KPiANCj4gLSNkZWZpbmUgWEVOX1NZU0NUTF9JTlRF
UkZBQ0VfVkVSU0lPTiAweDAwMDAwMDE0DQo+ICsjZGVmaW5lIFhFTl9TWVNDVExfSU5URVJGQUNF
X1ZFUlNJT04gMHgwMDAwMDAxNQ0KPiANCj4gIC8qDQo+ICAgKiBSZWFkIGNvbnNvbGUgY29udGVu
dCBmcm9tIFhlbiBidWZmZXIgcmluZy4NCj4gQEAgLTExMSw2ICsxMTEsMTMgQEAgc3RydWN0IHhl
bl9zeXNjdGxfdGJ1Zl9vcCB7DQo+ICAvKiBNYXggWEVOX1NZU0NUTF9QSFlTQ0FQXyogY29uc3Rh
bnQuICBVc2VkIGZvciBBQkkgY2hlY2tpbmcuICovDQo+ICAjZGVmaW5lIFhFTl9TWVNDVExfUEhZ
U0NBUF9NQVggWEVOX1NZU0NUTF9QSFlTQ0FQX2dudHRhYl92Mg0KPiANCj4gKy8qIFRoZSBwbGF0
Zm9ybSBzdXBwb3J0cyB4ezJ9YXBpYyBoYXJkd2FyZSBhc3Npc3RlZCBlbXVsYXRpb24uICovDQo+
ICsjZGVmaW5lIFhFTl9TWVNDVExfUEhZU0NBUF9YODZfQVNTSVNURURfWEFQSUMgICgxdSA8PCAw
KQ0KPiArI2RlZmluZSBYRU5fU1lTQ1RMX1BIWVNDQVBfWDg2X0FTU0lTVEVEX1gyQVBJQyAoMXUg
PDwgMSkNCj4gKw0KPiArLyogTWF4IFhFTl9TWVNDVExfUEhZU0NBUF9YODZfXyogY29uc3RhbnQu
IFVzZWQgZm9yIEFCSSBjaGVja2luZy4gKi8NCj4gKyNkZWZpbmUgWEVOX1NZU0NUTF9QSFlTQ0FQ
X1g4Nl9NQVgNCj4gWEVOX1NZU0NUTF9QSFlTQ0FQX1g4Nl9BU1NJU1RFRF9YMkFQSUMNCj4gKw0K
PiAgc3RydWN0IHhlbl9zeXNjdGxfcGh5c2luZm8gew0KPiAgICAgIHVpbnQzMl90IHRocmVhZHNf
cGVyX2NvcmU7DQo+ICAgICAgdWludDMyX3QgY29yZXNfcGVyX3NvY2tldDsNCj4gQEAgLTEyMCw2
ICsxMjcsOCBAQCBzdHJ1Y3QgeGVuX3N5c2N0bF9waHlzaW5mbyB7DQo+ICAgICAgdWludDMyX3Qg
bWF4X25vZGVfaWQ7IC8qIExhcmdlc3QgcG9zc2libGUgbm9kZSBJRCBvbiB0aGlzIGhvc3QgKi8N
Cj4gICAgICB1aW50MzJfdCBjcHVfa2h6Ow0KPiAgICAgIHVpbnQzMl90IGNhcGFiaWxpdGllczsv
KiBYRU5fU1lTQ1RMX1BIWVNDQVBfPz8/ICovDQo+ICsgICAgdWludDMyX3QgYXJjaF9jYXBhYmls
aXRpZXM7LyogWEVOX1NZU0NUTF9QSFlTQ0FQX3tYODYsQVJNLC4uLn1fPz8/ICovDQo+ICsgICAg
dWludDMyX3QgcGFkOw0KPiAgICAgIHVpbnQ2NF9hbGlnbmVkX3QgdG90YWxfcGFnZXM7DQo+ICAg
ICAgdWludDY0X2FsaWduZWRfdCBmcmVlX3BhZ2VzOw0KPiAgICAgIHVpbnQ2NF9hbGlnbmVkX3Qg
c2NydWJfcGFnZXM7DQo+IC0tDQo+IDIuMTEuMA0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 05:52:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 05:52:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308798.524599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3Gk-0007d7-Pl; Wed, 20 Apr 2022 05:52:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308798.524599; Wed, 20 Apr 2022 05:52:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3Gk-0007d0-LW; Wed, 20 Apr 2022 05:52:50 +0000
Received: by outflank-mailman (input) for mailman id 308798;
 Wed, 20 Apr 2022 05:52:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh3Gi-0007cu-Oo
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 05:52:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1ab9e28c-c06e-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 07:52:47 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-iuPq8lS8NqigsB_aPBT5Mw-1; Wed, 20 Apr 2022 07:52:44 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB5627.eurprd04.prod.outlook.com (2603:10a6:10:a5::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 05:52:42 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 05:52:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ab9e28c-c06e-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650433966;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=locu4B8SiSaSLd5+lBTxFczVg54W/N4Lr3GQzF8mdGk=;
	b=CHe0P8o9OXgMQGWID/C2xg/ZFBM2mw4fPwmx/zrJ4psWSS7XVC1AJuB4ZHt+2nwg2+BSR5
	nleM1IHHop1MfeVZpeBwvIu0pfG6BMrr8tgsB+8Rfnbac6fBwCGQCZpPLXMsBNXEorC86A
	WGfURW5SkaeaOrwrOoR73LpoYAmQSiU=
X-MC-Unique: iuPq8lS8NqigsB_aPBT5Mw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cKDxO+knrPSSaF0bnUEWeJiELTWPCiStoY4aLK1eINzaw2ilEHNOSDQCYxHQm366q/FGtfiIhV3re7TP5wX7PInF035GRCWKvfCEkuR9Iq68yzwNTfmmmKTkVawUsA52sSTUrTpgpA3FxY/X3C+ozP2Mnb02OV433+SFrTysV9yNn7NClfGiXM6TE6gc0nPQ8wJBZ0OfofbjbHKeQwHOGh43mwtei2hOwoY8ls0QqDbKSGBwsHVh8BMQdhbJ31srTJ7mNhUeKwOe4GweAqYBQdmlSMHtpyyXEsm0zpHidM5IJvplh1g/cq51COB9BChqZYJXUKH51edjQB4UG0MRZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nsSefV48vyqK+Ms8U5KybfCJOn1qlBMyYbDET5XnQ/k=;
 b=CK0jgWEc1uQ+suMCcO1shsGnSuKqDT7FqvvYMRt0rNO1XrpsXFXBDN/QHfPXCP1ClV+DuOONBKVt+QU63IauZDdWmVCfx2dnWScM2kMveWWV1ulOGIayElEB/gRdAx3MyL+mH4+gh6ec5PdVtvIcpskHujrodrt9bOpweWHw7OGq+Y/1BjW4zdg9EeXd8+P11hkWGR51rrU80cuRR0c/Ei+NkIuVu2AQQBHQLE9+MnDAz1bCr5UMvDCVIm7ednpmTabL7yfg04a7vwA5eb+S+roerq4rwWQxDDV0/XVQSWtmqvTIGLag1wKVSypWFRnecclQ85HNVg+AUR6Ywkbv8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7d3e5ed8-dd92-bfd7-6540-fa75965eeed8@suse.com>
Date: Wed, 20 Apr 2022 07:52:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Paul Durrant <paul@xen.org>, Juergen Gross <jgross@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
 <8a8aa0c1-e6f3-2dc0-77d4-282af89f4ed6@citrix.com>
 <bd446b5b-49ea-3d6f-6792-7d785586ea69@suse.com>
 <226afabd-ea07-dd60-474f-c594d7468de3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <226afabd-ea07-dd60-474f-c594d7468de3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR05CA0014.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::19) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c6168c57-7266-4c00-08de-08da2291fbc9
X-MS-TrafficTypeDiagnostic: DB8PR04MB5627:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB56270CEEC278CEB6A9833E22B3F59@DB8PR04MB5627.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oKUd4IPmp/ehgBsm81vYdUGL6HR9R00Zp701X2TblVLMhtHzEZl6Upfc7ZIprBZPs8Niv8xVGlMUMLkkqkbBQ5+rQNmPEXAatCIgC6TwXOgzKIJ+giOaAMtFZbc0BWqPPAClvHlHGj8jH5jpFtKwpG0VnrfzhpKnz6pUqEuWCPAUjA9G3DNEmrYhGTHAcCRtg+eaJKkoar3D6xzcXYaM3pIeHpKNIOuMDaNGlZQp6mWmtuGeLja2P2ppsJzB/UxEn8Gumkv9WfkQUE21j3vHBGq7m/Cg7X2nte37P1xmBYVMXtkCFqNOJAti6jE0uWjahOgcd/E3YN+zEmtEFTezAItDaHGxMSQlCBc7Lz4Qi1DWjt9abP0aSCWxjLLiKvyYvQG8l1SBKQT8o0188W6HMGhE1AHzY5eKP1UDHxqPasgdLVrGv9pqKREHZ37Q4cHag3wBgG1RP2WhVBLkTp7odtL0VMzhAskHTcR67ocJ4R6Z9kOfJlyymUFN7Md2C/qTnGCRWvi2KGszC3+08ayAIiv9ljKUKX8tOPMejm+Sgh/5+CJHH3W9x+iNYoy583qwuRidh52HrCJaJj+92kasQQ4KmDTAw7TEhtnvUnAKGkWDa52Itcs6cemuvM7ixjJQ0+cH1qzAcVfPGtyw9qVRIF4a5rjvRu+/m0uvmrNHvTHLa4zwuCjPeDN/5iBGq7gbyPk7iXn6oUD1l56d6hTaCeuaBkt6YjqBn0OSFQTcfzs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(6506007)(6512007)(2616005)(53546011)(2906002)(26005)(8936002)(31696002)(508600001)(6486002)(86362001)(186003)(5660300002)(316002)(36756003)(38100700002)(6916009)(54906003)(66476007)(8676002)(66946007)(66556008)(31686004)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BqLGtEKCb9UDdAxAHaP0qOfgD44TQGoxIDqUrqVbWadyxqtHyI2kqbxNpNbv?=
 =?us-ascii?Q?tj8Wcz9pDuulWSCxbaXRfX5BR3eZlnKIyzPGHFC4hIf03mu1TWt+X92RP+6L?=
 =?us-ascii?Q?rd0gkyIUbBqVGfUpMOTcu6BAAsz17MgX3NFeWPDjGrFqEXCVV6+erZk/OrZd?=
 =?us-ascii?Q?JV0LNXvkoTmR+abK5unlqmqSjmNvCT7qV210ZizpWJC3EXegFpr4IcTYcS0t?=
 =?us-ascii?Q?tLqZwy980lG++3k5EtZSVFRofW3/Nbln65WLyN4EGqrGV4SB2+88ELbJeuVX?=
 =?us-ascii?Q?d85cEGBmWkDKrW+tETs+BfNDvVar20sZ65DNUxfqK8l1ouXZ7fcInzyOtQxO?=
 =?us-ascii?Q?pJERV6SbQznwMHk/Snh5bGaE5MFSBtGPcD88vNuMf+thNWvTwW2BAcoz7D74?=
 =?us-ascii?Q?03h44MG7fsQdQBRC/6VjJHWSfK11dxcxARN2FVp/Fz1LVf3LBwFBo9/45r1S?=
 =?us-ascii?Q?6eTZaYgDOfthh9w/Rw/wTbMpvi/fiXKTTL11yxulZAo1YqOcyISQkwlAdUXM?=
 =?us-ascii?Q?4k9K8VGGnknwnCMyJIvKRSdN87NWY8q2xXAMdQT3SIcdiwf4EA7Cubi57KZg?=
 =?us-ascii?Q?EWGzCFU1cElPI4hI7hIXLc/7J12Z3RFfxE8nSWl7yn0lUv+ImJFyD1oow61R?=
 =?us-ascii?Q?k44FCaNTn1kUctCbWzU2i6LJu9sB2QpU3v3XlfryXiVsDhM6quxLJvfhYJRJ?=
 =?us-ascii?Q?VYxQ4lWuq+MvjD6UCSgvua0m01JbfbaAduzTYYTNKWGrp/3iKNRRWakPiuZL?=
 =?us-ascii?Q?eiWksT7VP0QIbo7lfeNG9lq94buLjfiebEa6NSEWX1Q1XPMjUzGkQVE2fEmb?=
 =?us-ascii?Q?UyAa2gJZkQiBavtlXnqK1vAVyvaX8YA5w5WjhcUbRkAp7YFpVJudJb1cl6oL?=
 =?us-ascii?Q?Lhw9H8lnziDcZF3airaLhusLw2i+EuUCEpbOi6kvvRrz540nR3sAYMeJA5O8?=
 =?us-ascii?Q?IQRTqrStCsHNahCKOqoYyW32gQb6aXGVjb4eiZfuMPrbif0H6gudio7uxqH2?=
 =?us-ascii?Q?D5ypYFFJW/lPxWSJmiIXGuPU21Hxh26EPbOOooMjfV8NO2v7KiDQqGhDLFWY?=
 =?us-ascii?Q?PUY3fJLIp+0FM9caj1OQTZd5ZmSkdPLYcdVNTZ5rjo1Ep+pKGcSEuqRaIAJO?=
 =?us-ascii?Q?W8ujUyCwSa6NZ/Ak4e2bCjXOjRf/XDTV0NtG/wQNSb8cQYz14vioHDb9bFAk?=
 =?us-ascii?Q?k9THZSrw1ZYatWIFRL7hyRy+2wox4jDxRC/9N7TdO668UiXv6t2iML3CxDrp?=
 =?us-ascii?Q?aBmK+F0jDpDjW9WM+UaegwyZTCgkRemF9DK3IwDLZVuZofiw9x7Vp3xgXSpq?=
 =?us-ascii?Q?K9lliV7VAKlXR5yxHTlsdu+a5eJLwGImelLwhr1Pknnp03TJO5KkctTRj0Xs?=
 =?us-ascii?Q?qvbr6thcFZEq/SNOf/goK/3GMzkf4uUA0T+eEg0AwjhKmKThtL17nnQY9cQA?=
 =?us-ascii?Q?nzDCCmW8viZo/osdgiZO/NDN/G8LwcwmrN7HH3bmWhuvgqvnX5/uQHFxAF5y?=
 =?us-ascii?Q?IpHg7b6mrxXC2Q0reM0qG6NJYXaY86eEpbmB2W47EQDuh22NqC2iE+UAtx9P?=
 =?us-ascii?Q?1q0aQtkzCXXAWfoo5u1dZweJZYOn/JjfQj+IRpvroNsKZTZQfahBcTOYK0Fg?=
 =?us-ascii?Q?VRFl0qPnMUFbzrI8QoYP+veDOKhZVGo1vTkXNJGKklP92VOMGjbg0IZ0GRSQ?=
 =?us-ascii?Q?1xsHfk1zlKmRUky66gf2yAr5fnLAov7aoe9+VokB2l5FshD5exw/QsX+7T1H?=
 =?us-ascii?Q?cGWnnafjdQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6168c57-7266-4c00-08de-08da2291fbc9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 05:52:41.8392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RqA+/rPA7GFyRO1hTZtGGWumt+lTBFvPSoLJUaasp8lnVNvv8LR52c7C0yUYTFeXQCJi4c3knQQY2XlzWr58Ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5627

On 19.04.2022 18:06, Andrew Cooper wrote:
> On 19/04/2022 16:52, Juergen Gross wrote:
>> On 19.04.22 17:48, Andrew Cooper wrote:
>>> On 19/04/2022 10:39, Jan Beulich wrote:
>>>> Besides the reporter's issue of hitting a NULL deref when
>>>> !CONFIG_GDBSX,
>>>> XEN_DOMCTL_test_assign_device can legitimately end up having NULL
>>>> passed
>>>> here, when the domctl was passed DOMID_INVALID.
>>>>
>>>> Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...")
>>>> Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>
>>>> --- a/xen/drivers/passthrough/iommu.c
>>>> +++ b/xen/drivers/passthrough/iommu.c
>>>> @@ -558,7 +558,7 @@ int iommu_do_domctl(
>>>> =C2=A0 {
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret =3D -ENODEV;
>>>> =C2=A0 -=C2=A0=C2=A0=C2=A0 if ( !is_iommu_enabled(d) )
>>>> +=C2=A0=C2=A0=C2=A0 if ( !(d ? is_iommu_enabled(d) : iommu_enabled) )
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -EOPNOTS=
UPP;
>>>
>>> Having spent the better part of a day debugging this mess, this patch i=
s
>>> plain broken.
>>>
>>> It depends on Juergen's "xen/iommu: cleanup iommu related domctl
>>> handling" patch, because otherwise it erroneously fails non-IOMMU
>>> subops.
>>
>> Which is not a real problem, as it is being called after all other
>> subops didn't match.
>=20
> It is a real problem even now, because it is bogus for the host or
> domain's IOMMU status to have any alteration to the
> XEN_DOMCTL_gdbsx_guestmemio path.=C2=A0 The root cause of this bug is the
> existing XEN_DOMCTL_gdbsx_guestmemio case being compiled out in the
> !GDBSX case.

I find your wording ("plain broken" in particular) irritating, to put
it mildly. The change in behavior is that -EOPNOTSUPP may now be
returned for the gdbsx operation instead of -ENOSYS. And that's when
it would better have been -EOPNOTSUPP in the first place.

Apart from this I don't see a dependency on J=C3=BCrgen's patch, so please
let me know if there's anything crucial I'm overlooking. Otherwise,
with two R-b, I'm intending to put in the patch irrespective of your
replies.

> It would be a more obvious problem if there were calls chained after
> iommu_do_domctl() in the arch_domctl() default: blocks, because then it
> wouldn't only be compiled-out functionality which hit this check.

But that's not the case.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 05:57:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 05:57:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308803.524609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3LS-0008Ga-Ac; Wed, 20 Apr 2022 05:57:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308803.524609; Wed, 20 Apr 2022 05:57:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3LS-0008GT-7m; Wed, 20 Apr 2022 05:57:42 +0000
Received: by outflank-mailman (input) for mailman id 308803;
 Wed, 20 Apr 2022 05:57:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh3LQ-0008GK-7a
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 05:57:40 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c8ba9464-c06e-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 07:57:39 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 89D871F380;
 Wed, 20 Apr 2022 05:57:38 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3746813AD5;
 Wed, 20 Apr 2022 05:57:38 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id HIYjDNKgX2JFPAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 05:57:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8ba9464-c06e-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650434258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=FOVZCtdntsh9ZipxoJ5dEjdAyWPUlLf5ST56YjpMrA8=;
	b=hlf9t7txJnR60pzw0uIncPRxtUy3T428M7/Q+hPNCLUVp+GF8liLXOUJQEUatJjvTz9KIL
	D8DEA0ZA/qUGv+gStw0O1i8FcBIJWLZqMTis4aajRLDUaoxHAMn52/VpBN9icBuUGQjp6U
	LdWm6zrk1X1Kr7XXkzQtcC/9/AWG6c8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Date: Wed, 20 Apr 2022 07:57:36 +0200
Message-Id: <20220420055736.27901-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today iommu_do_domctl() is being called from arch_do_domctl() in the
"default:" case of a switch statement. This has led already to crashes
due to unvalidated parameters.

Fix that by moving the call of iommu_do_domctl() to the main switch
statement of do_domctl().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V3:
- new patch
V4:
- add iommu_do_domctl() stub for !CONFIG_HAS_PASSTHROUGH (Andrew Cooper,
  Jan Beulich)
---
 xen/arch/arm/domctl.c   | 11 +----------
 xen/arch/x86/domctl.c   |  2 +-
 xen/common/domctl.c     |  7 +++++++
 xen/include/xen/iommu.h | 12 +++++++++---
 4 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 6245af6d0b..1baf25c3d9 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -176,16 +176,7 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
         return rc;
     }
     default:
-    {
-        int rc;
-
-        rc = subarch_do_domctl(domctl, d, u_domctl);
-
-        if ( rc == -ENOSYS )
-            rc = iommu_do_domctl(domctl, d, u_domctl);
-
-        return rc;
-    }
+        return subarch_do_domctl(domctl, d, u_domctl);
     }
 }
 
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index a6aae500a3..c9699bb868 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -1380,7 +1380,7 @@ long arch_do_domctl(
         break;
 
     default:
-        ret = iommu_do_domctl(domctl, d, u_domctl);
+        ret = -ENOSYS;
         break;
     }
 
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 5879117580..0a866e3132 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -871,6 +871,13 @@ long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
             copyback = 1;
         break;
 
+    case XEN_DOMCTL_assign_device:
+    case XEN_DOMCTL_test_assign_device:
+    case XEN_DOMCTL_deassign_device:
+    case XEN_DOMCTL_get_device_group:
+        ret = iommu_do_domctl(op, d, u_domctl);
+        break;
+
     default:
         ret = arch_do_domctl(op, d, u_domctl);
         break;
diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
index 3a83981464..c6bbb65bbf 100644
--- a/xen/include/xen/iommu.h
+++ b/xen/include/xen/iommu.h
@@ -341,8 +341,17 @@ struct domain_iommu {
 /* Does the IOMMU pagetable need to be kept synchronized with the P2M */
 #ifdef CONFIG_HAS_PASSTHROUGH
 #define need_iommu_pt_sync(d)     (dom_iommu(d)->need_sync)
+
+int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
+                    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
 #else
 #define need_iommu_pt_sync(d)     ({ (void)(d); false; })
+
+static inline int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
+                                  XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+{
+    return -ENOSYS;
+}
 #endif
 
 int __must_check iommu_suspend(void);
@@ -356,9 +365,6 @@ int iommu_do_pci_domctl(struct xen_domctl *, struct domain *d,
                         XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
 #endif
 
-int iommu_do_domctl(struct xen_domctl *, struct domain *d,
-                    XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
-
 void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev);
 
 /*
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:01:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:01:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308808.524621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3P2-0001Id-Ro; Wed, 20 Apr 2022 06:01:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308808.524621; Wed, 20 Apr 2022 06:01:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3P2-0001IW-Om; Wed, 20 Apr 2022 06:01:24 +0000
Received: by outflank-mailman (input) for mailman id 308808;
 Wed, 20 Apr 2022 06:01:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh3P1-0001IM-MG; Wed, 20 Apr 2022 06:01:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh3P1-0008It-KV; Wed, 20 Apr 2022 06:01:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh3P1-0006ZC-5b; Wed, 20 Apr 2022 06:01:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh3P1-0003U0-5B; Wed, 20 Apr 2022 06:01:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1rND5zcB4mnnmX1Rl4vL8v3sfXz6nHw5MsDfSaT7+aE=; b=VajGZmRrQjM8aQzIHWb3K4gGqK
	q6X8xMLUSbF4LZyfFYW0lt/TvLNyXtHGnHGcIhnKgL1DNrglRNTS8jpwytYrEcG8iz8Zj6PQlBw2U
	RflAKMCFvfs1+zRevXhQNlf4QvU82B++ZZbc3B5OWFjrICnqG81Pm52MfPcZL2lvMkIs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169556-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169556: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 06:01:23 +0000

flight 169556 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169556/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  515 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:03:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:03:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308815.524632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3Qj-00022h-8V; Wed, 20 Apr 2022 06:03:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308815.524632; Wed, 20 Apr 2022 06:03:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3Qj-00022a-4v; Wed, 20 Apr 2022 06:03:09 +0000
Received: by outflank-mailman (input) for mailman id 308815;
 Wed, 20 Apr 2022 06:03:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nGXA=U6=inria.fr=julia.lawall@srs-se1.protection.inumbo.net>)
 id 1nh3Qi-00022U-7L
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:03:08 +0000
Received: from mail2-relais-roc.national.inria.fr
 (mail2-relais-roc.national.inria.fr [192.134.164.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8bbc5b4f-c06f-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 08:03:06 +0200 (CEST)
Received: from 203.107.68.85.rev.sfr.net (HELO hadrien) ([85.68.107.203])
 by mail2-relais-roc.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 08:03:05 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bbc5b4f-c06f-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=inria.fr; s=dc;
  h=date:from:to:cc:subject:in-reply-to:message-id:
   references:mime-version;
  bh=AOOcnU+E44vIs+pheMoJXhmNTxpxQArBK8PCjZDPu1k=;
  b=JeAqI8DLZD09zSdr45+0R8EO5Cgdby5+SpBtSnfHFkLwVpvLlmM/8hJ9
   wfe3mkqS1RL5WtqKsk7VTWq8kMEy8kh2kMthaDBOjZovZNbHjvj+M86gZ
   koeT8tRdLUdXrJXhjOnVGaG2G2dAAAAGX9BQtqO3MLoqF5FQ2TTUjsuDn
   A=;
Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr
X-IronPort-AV: E=Sophos;i="5.90,274,1643670000"; 
   d="scan'208";a="32427415"
Date: Wed, 20 Apr 2022 08:03:05 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
X-X-Sender: jll@hadrien
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
cc: outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, 
    sstabellini@kernel.org, xen-devel@lists.xenproject.org, 
    linux-kernel@vger.kernel.org, ira.weiny@intel.com
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
In-Reply-To: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204200759080.2937@hadrien>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII



On Wed, 20 Apr 2022, Alaa Mohamed wrote:

> kmap() is being deprecated and these usages are all local to the thread
> so there is no reason kmap_local_page() can't be used.
>
> Replace kmap() calls with kmap_local_page().

OK, so from a Coccinelle point of view, could we do

@@
expression e1,e2,x,f;
@@

e1 =
- kmap
+ kmap_local_page
    (e2)
... when != x = e1 // not stored in any location and not passed to another function
    when != f(...,e1,...)
    when != x = e2
    when != f(...,e2,...)
-kunmap(e2)
+kunmap_local(e1)

julia

>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> changes in V2:
> 	-edit commit subject
> 	-edit commit message
> ---
>  drivers/xen/gntalloc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c
> index 4849f94372a4..55acb32842a3 100644
> --- a/drivers/xen/gntalloc.c
> +++ b/drivers/xen/gntalloc.c
> @@ -178,9 +178,9 @@ static void __del_gref(struct gntalloc_gref *gref)
>  	unsigned long addr;
>
>  	if (gref->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) {
> -		uint8_t *tmp = kmap(gref->page);
> +		uint8_t *tmp = kmap_local_page(gref->page);
>  		tmp[gref->notify.pgoff] = 0;
> -		kunmap(gref->page);
> +		kunmap_local(tmp);
>  	}
>  	if (gref->notify.flags & UNMAP_NOTIFY_SEND_EVENT) {
>  		notify_remote_via_evtchn(gref->notify.event);
> --
> 2.35.2
>
>
>


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:12:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:12:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308824.524643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3ZP-0003js-5h; Wed, 20 Apr 2022 06:12:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308824.524643; Wed, 20 Apr 2022 06:12:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3ZP-0003jl-2U; Wed, 20 Apr 2022 06:12:07 +0000
Received: by outflank-mailman (input) for mailman id 308824;
 Wed, 20 Apr 2022 06:12:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh3ZN-0003jM-So
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:12:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cc322893-c070-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 08:12:03 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-eZEyROo-MTaFLwYuf6fF5g-1; Wed, 20 Apr 2022 08:11:59 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8081.eurprd04.prod.outlook.com (2603:10a6:20b:3e2::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 06:11:57 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 06:11:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc322893-c070-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650435123;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=b6nTPjwHlcOinJr9lFEiEJx8Z1LsrJ2xWRznUplycrs=;
	b=Z10775Na5CiHav2NCgJw9zIXYmciK1YcDNtA79CC58IA5LJT+rhbhcJ8kwqra2sCMadzOd
	1zKfGzvScd56vKGORiVxpz/QOnu3URd6Bu3QmgsKPol08SJ3Z3evhGxw1jaJ89Sp3QzeYn
	FYByCtuH6ta3loPyDzg6wWiDuV3tMEs=
X-MC-Unique: eZEyROo-MTaFLwYuf6fF5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DT/XaOV6qTlV0fRD/4ycZGR5AQ+r8cUwB+q+aba1FGVWKUXQO/lslqgP1XvTL7ZkWW4zYQhLEnwkAFLlGZ7u9EhtLokLP9DNHiVx8E3lT119cznGc6fm+Y/Ui9of+Opsx6+Yon3sZbf1isGrKrmESVMvxZRMWSvGDSTD7Vqyu1mou3/jkd7Y/oTs3XwrLup6YV5bKuZ50ZelXw9UsaQ4umfzGoiaeJqcRaRzB8susKUkWaRSEIaZTuAVo9QsUHuZ2oe5Of4k3tcIydKPRY4HlX5uOP1fV5Zx85f5uMdMflpMEB1DOTMqCt9rNKoB0yie0I4bBTPUUp51SHy04u+15Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b6nTPjwHlcOinJr9lFEiEJx8Z1LsrJ2xWRznUplycrs=;
 b=lw6BUj1TxyhsYS60o0Sh6BHtsqjjbT3U8Yb7uEUEJ3JHRJQd6GCD30E/awJPXQb+iHJiflmQ3fSvhkvyUPP49WdEPWg5wzgbx8IhHSRL23G7bQOyDDJKc+pRKjfmWBaQPm/L5fHOU+IpZXl9+JjckQeN37zBM4cMCyOFDyw5gzI0WmpAZJC0iOr29DniDaCPKTivkxN6j55zImqUUF/Zb/LOllGVqzw23THytPRK7WhyURhlu5ijRa72wTGKic3NWhI3AiOA0VrcHf6k4YJFFvd6vJF+tF0WnZe+aXvOU/xEpxT8SqBwM7CjO7Z4d+/F0A/lCV4t2fY0+h37FprAKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
Date: Wed, 20 Apr 2022 08:11:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <20220420055736.27901-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420055736.27901-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::8) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71bef4b3-5d9e-4a59-9b2b-08da2294ac4d
X-MS-TrafficTypeDiagnostic: AM9PR04MB8081:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8081F07DBEBC4E5C911467D5B3F59@AM9PR04MB8081.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6LH/pL75ofltKiGr49TZW9Yv5Dr6vTazEHcoXBqox7wm4TC3/pBPJUpclZXph29wKX1G+Y3HF02KBxyZgyJZ0QBF6no2t9XLo3l/mB8dL0SnzWis58kMCltjAWcvnZr0Utll60cotHl7jq76/ravYTYoPLHxOjBZPVRlu7Y6h8b/oc1pxxVvh7NA9lu7frwoLwlEzY50HzauNN5YJ9DM4PNgl2jX8rHEUACdGtESpkqxSvmJf6Qbg3K4Mi+QZfqL7ri3GDn8CHejxrn3uHqfhM/wg/pmu29riStoslHaZ4SPgQdDAn1nm8gHk6wp6qb9tiNw0c4L2SeRoPss6xO8qE0OYcGBIZpGHKknuhTvzhUOk+Wh6Wtf9of72jRDfCDZG3YdMK2SubqB6VLOH6oZFJwzSZQfwuaWHcclaqChDEFUI5/+Zuoy3Nd+PVEZTaJJHLo0g5YBWZexHmXEdBx+ZbfxHPc2Zj71248SNkQpHvYsLotZFYHgho6K1eYzK55XheDrYLq/jkoH5TIxMq31rR/eZlId224g/CBDRZ42ld635VQ8tnxPIvlpEZH2jF2MTVmwgaZh6srm7/8NGR6BGB3HUJ6wuXXwWXT9HwAGW5Fa3Yy6FTzOP6Q6dsvGjO/46Vq2UCGulB7a3OQIddaWAozaD33/jC54eC3eWYEFnvVseOf8YP181ZJtRfjW33wsWFllNcJa0lLysS3tDbfJ01f5yAvzfNAyHgLlLpRyNiE+raqVhQoejiKuRARilFr8
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(8936002)(316002)(86362001)(5660300002)(31696002)(6862004)(37006003)(6636002)(4326008)(66946007)(66476007)(66556008)(54906003)(6512007)(6506007)(8676002)(7416002)(2616005)(186003)(53546011)(26005)(508600001)(6486002)(2906002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WTNKNmdGOVZIYk5kcWxVN3V0UWJxYkZsazhlZ2JibDhwdHBhbVhoZ1o1bmdQ?=
 =?utf-8?B?RC91VWowMENnZTE3d1FBaTNsNzg3RXNGd01DMytDSVJ0bmhzVVVWcklSZGFx?=
 =?utf-8?B?RU0zR3A1Ung4WHdMZTRTTnZ2dVl2NlZvT0tJQXcxNFJOYXo5WmxrdTNCYnpC?=
 =?utf-8?B?OVZoRkVFSXQxckZLMktwVjZ3KzcrQzhZaDZPZ0E5VVVkMS9vRkZZemM4Njd2?=
 =?utf-8?B?YnFBaERFMkJBVnpYYURNZmwxaWJ5cHA1RE9XcGwrNlJDeUpHaWJsN21sVDlY?=
 =?utf-8?B?Y1paZUIwc1BDWXpCSFhXTWRoQ291ZmdYQWZZSXJUOHBKVzl3emNyWGFUdEVK?=
 =?utf-8?B?SzVCblBmTzNoVVM4aDlFZUNBamZlSTFXVk8zNFE4OGZ4OTVpTkRpL3dHdWF6?=
 =?utf-8?B?MWh0ak1MT3NIaHdBVFRnYysxNlR2TUNicmpVeFpBdVRaelhNRE1vbE55Rnlp?=
 =?utf-8?B?cDhHVFFMbjVVUy9OZm5mSzhveWRKNXc4M1ZlSkpldmpiODFHcFNaN2VKRkph?=
 =?utf-8?B?VFVUWUVmZjZVSUxwUmQrTDhpU0t3S0FZdVVqZDJUeWMxZmdvdkdBWVVFY25r?=
 =?utf-8?B?WTZheFNXdi9KYittRXhOc09wWXBBeWxVaGU3UGw4NFVhVEZXZVcySWJQVkk2?=
 =?utf-8?B?UlRLYzA4aGU1T1YwcUxkT0xhclRuVGpNZEVuUFdCbkpieDNDMkVPVEVaL0pl?=
 =?utf-8?B?QmFRMjJTb2pyUFBGS0xFWTBoK2x1NjlNZi9hZVFaSGJKdm5hdVRtdU81LzdB?=
 =?utf-8?B?NklqeXluSmlXQUlrWGdIZkdEREwxdTFsWXZOeE1RRzFpVUZSck1YbDlIeDRw?=
 =?utf-8?B?VGIxYkZZRklmZGRtZzNCa0RmTkNzblR2UXlnUnlPYjlrbE1xR0ZLQXNYOTkr?=
 =?utf-8?B?WmN0anlmOFBsdXdQbmZmc1dGS0xjbDg0SUNZcnZYQlhQNjFaYmlaUXpkUzNz?=
 =?utf-8?B?UksxYis3RWU5b1ErUzhucWMyZklaUUJvMnNvWWRUVGtGbElhTDlhNDVSbUdq?=
 =?utf-8?B?UVVTK1hvQlFaTjZTbEgzZGhPTXlqU2lrVnpEUndEREc5R0NxaTl3cmJoNUZh?=
 =?utf-8?B?Q1NBMG1vcnVZQkU1ZDF2UW5kLzh1cHlqeHpxcnhBakhQNFBsaUJabGJBdldq?=
 =?utf-8?B?OFJNL2UrUUNkK0t5QmQxWGtob2hYQ3dHbUt4RjE3U0toR0lHVEZ4b2N4dytR?=
 =?utf-8?B?NW5OdjRSZ2Z5SmQ2REJTQmkrQmt1MzBNcEw5NU04NkNlSW5HZEN5TWVhUm1n?=
 =?utf-8?B?VHhlbG92ZDFsUGYxbGlpa2JCTUE0Z2M2NlVqb29LODlXRDczY3llMGpDd3pi?=
 =?utf-8?B?ZHU0dzZFWWtuaWFOeGxLOWNxZmdvQk44RlJnQjc2NzZBbk13ZG9kQXdMZGtv?=
 =?utf-8?B?RVdWQkdjYTQzWTNndHFDYzFNZVN1ZnljeDJsMEVUMUNRUUxCY0lJeFo4YmVn?=
 =?utf-8?B?TGpsWGpmUmdRL2ZVNVBXYTI2WXBtTHovVGZiVjZ0REt0MTRMUU5EcU43Nzkz?=
 =?utf-8?B?Q2lyNjRQWjUyY3ZWQ2R5U2NDQnZGQjRXS0hUYzhnTE5UUWdDbnZnaU9MRmlV?=
 =?utf-8?B?dmdVK2FCOVRvdkNldUpQeGVyUmp6dXI5RC9XYXhXR2sxeXRrOVhZTkIya3VW?=
 =?utf-8?B?eE5ZWkR0cGdLZTJEc1pSb25saUVKb2JZVVdEVEY1ZGF6MjZIc2JOcjkra0Rs?=
 =?utf-8?B?azNXUUUxMlJzcGROVXc0R3BRVTNDUFY1bjFadU1SQzcwSU51eE0xNTkxTGRN?=
 =?utf-8?B?ZTdFNGpScGxhcG9FYThRK2I4UmhnUldjSGluTkpEb2pYSHhvdG9KUHpmb2Zm?=
 =?utf-8?B?VTd1NjJFalJDVFpVam9FeFdtS0M3bXpLRmZ5UnN1STlOSjFmME02dW1hZlNK?=
 =?utf-8?B?QVFwV2JsUE9VblhuY2FPUnhuR3AyRWlCU1lFWjRNdy9RRStQMzExVFZ5c01o?=
 =?utf-8?B?d0xWeXhaSVVsL09IRUc2RHFZMytJcDBnQXpqNC9XMW9JSjVWbEVOcGV1RElM?=
 =?utf-8?B?NnN2YzdIYnI5b3lScTlZMkQ5M3FqeVU1Znc4U2p6c3d0R2Mxa2RDa0xEZW40?=
 =?utf-8?B?VXI4a0lJWndRaXhZWHQ1YU9yeXRJYTNSUk42K0huQzZudFlyaWtTQ3VRbHlV?=
 =?utf-8?B?dTJKVE1FeVlyMDdkLytSUitoVDdldjM4SVNYd3NRR2R3cGVURTVNTnhEK3la?=
 =?utf-8?B?S24yUWx5MXlnNldLbmp0SlNyNzllYlMwc05uR21xWXpZMTNIRExwUFdoQURV?=
 =?utf-8?B?U2RmWHJGcTlma1pVTWlkVjdJYjVNeHZTdmhoOUNPeGRDZGNlSG5hWmdsSkx1?=
 =?utf-8?B?aHFvSloybmdZNmx2dEppOFZ6c3FPTG50MHI3MlZISkRyckV4Nmx0QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71bef4b3-5d9e-4a59-9b2b-08da2294ac4d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 06:11:56.9023
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CV8FTTbRx3TR7cWcElgTQWaDFbe9mez4MYGmVtwGZc7hG2ssh2nSjwnTbFYGMlOUiYqL/ThVVqsYWzVJd/6UZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8081

On 20.04.2022 07:57, Juergen Gross wrote:
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -341,8 +341,17 @@ struct domain_iommu {
>  /* Does the IOMMU pagetable need to be kept synchronized with the P2M */
>  #ifdef CONFIG_HAS_PASSTHROUGH
>  #define need_iommu_pt_sync(d)     (dom_iommu(d)->need_sync)
> +
> +int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
> +                    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
>  #else
>  #define need_iommu_pt_sync(d)     ({ (void)(d); false; })
> +
> +static inline int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
> +                                  XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
> +{
> +    return -ENOSYS;
> +}

As said in reply to Andrew as well as in a number or earlier occasions,
I firmly think that this wants to be -EOPNOTSUPP, not -ENOSYS. Views
here may differ of course, but in the absence of objections I consider
this easy enough to adjust while committing. If, of course, the
approach finds a majority in the first place - as indicated before I
don't view it as very desirable to enumerate all the IOMMU related
domctl-s in the common handler.

FTAOD I can accept x86'es arch_do_domctl() returning -ENOSYS, but only
for the purpose of not altering the pre-existing error code which would
be returned if making it there.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:22:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:22:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308829.524653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3j7-0005M5-3b; Wed, 20 Apr 2022 06:22:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308829.524653; Wed, 20 Apr 2022 06:22:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3j7-0005Ly-0d; Wed, 20 Apr 2022 06:22:09 +0000
Received: by outflank-mailman (input) for mailman id 308829;
 Wed, 20 Apr 2022 06:22:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh3j5-0005Ls-0K
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:22:07 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 32afc468-c072-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 08:22:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1A6FC1F74E;
 Wed, 20 Apr 2022 06:22:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C34C713AD5;
 Wed, 20 Apr 2022 06:22:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id MANOLoymX2JIQwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 06:22:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32afc468-c072-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650435725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ojiE3HvreTf0FdCnYzrlxAyv47T9IH/H1FZgRibsKDM=;
	b=VZzAH8SHRduK/MNpUykUUFDymSHfubnPXPxNUKlzj4sm1F8/2uTzjVOzZllEbXAjH5cKRx
	nWWpuPtj3Q5kUwLBAO1t7//CP4TDcjuw92Au/gnJvXn1oczbK2a9iGIqSCIUV705fBErmN
	8nVJmjKhe/H2t4bl6TUOo56kt+N6Lu8=
Message-ID: <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
Date: Wed, 20 Apr 2022 08:22:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <20220420055736.27901-1-jgross@suse.com>
 <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
In-Reply-To: <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------vV3Schdoz5Ipmb5qyNC1l9ut"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------vV3Schdoz5Ipmb5qyNC1l9ut
Content-Type: multipart/mixed; boundary="------------wJB2C0hqQeCw9mZzKdTBvOQe";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
Message-ID: <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
References: <20220420055736.27901-1-jgross@suse.com>
 <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
In-Reply-To: <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>

--------------wJB2C0hqQeCw9mZzKdTBvOQe
Content-Type: multipart/mixed; boundary="------------mUUMomNPzMgHwHhHmtgBoKub"

--------------mUUMomNPzMgHwHhHmtgBoKub
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDQuMjIgMDg6MTEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMC4wNC4yMDIy
IDA3OjU3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEveGVuL2luY2x1ZGUveGVu
L2lvbW11LmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9pb21tdS5oDQo+PiBAQCAtMzQx
LDggKzM0MSwxNyBAQCBzdHJ1Y3QgZG9tYWluX2lvbW11IHsNCj4+ICAgLyogRG9lcyB0aGUg
SU9NTVUgcGFnZXRhYmxlIG5lZWQgdG8gYmUga2VwdCBzeW5jaHJvbml6ZWQgd2l0aCB0aGUg
UDJNICovDQo+PiAgICNpZmRlZiBDT05GSUdfSEFTX1BBU1NUSFJPVUdIDQo+PiAgICNkZWZp
bmUgbmVlZF9pb21tdV9wdF9zeW5jKGQpICAgICAoZG9tX2lvbW11KGQpLT5uZWVkX3N5bmMp
DQo+PiArDQo+PiAraW50IGlvbW11X2RvX2RvbWN0bChzdHJ1Y3QgeGVuX2RvbWN0bCAqZG9t
Y3RsLCBzdHJ1Y3QgZG9tYWluICpkLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgWEVOX0dV
RVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3RsKTsNCj4+ICAgI2Vsc2UN
Cj4+ICAgI2RlZmluZSBuZWVkX2lvbW11X3B0X3N5bmMoZCkgICAgICh7ICh2b2lkKShkKTsg
ZmFsc2U7IH0pDQo+PiArDQo+PiArc3RhdGljIGlubGluZSBpbnQgaW9tbXVfZG9fZG9tY3Rs
KHN0cnVjdCB4ZW5fZG9tY3RsICpkb21jdGwsIHN0cnVjdCBkb21haW4gKmQsDQo+PiArICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0o
eGVuX2RvbWN0bF90KSB1X2RvbWN0bCkNCj4+ICt7DQo+PiArICAgIHJldHVybiAtRU5PU1lT
Ow0KPj4gK30NCj4gDQo+IEFzIHNhaWQgaW4gcmVwbHkgdG8gQW5kcmV3IGFzIHdlbGwgYXMg
aW4gYSBudW1iZXIgb3IgZWFybGllciBvY2Nhc2lvbnMsDQo+IEkgZmlybWx5IHRoaW5rIHRo
YXQgdGhpcyB3YW50cyB0byBiZSAtRU9QTk9UU1VQUCwgbm90IC1FTk9TWVMuIFZpZXdzDQoN
CkluIGxpYnhsIHRoZXJlIGlzIGFuIGV4cGxpY2l0IGNoZWNrIGZvciBFTk9TWVMgYmVpbmcg
cmV0dXJuZWQgZm9yDQphc3NpZ25pbmcvZGVhc3NpZ25pbmcgYSBkZXZpY2UsIHNhbWUgaW4g
dGhlIHhjIHB5dGhvbiBiaW5kaW5ncy4NCg0KDQpKdWVyZ2VuDQo=
--------------mUUMomNPzMgHwHhHmtgBoKub
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------mUUMomNPzMgHwHhHmtgBoKub--

--------------wJB2C0hqQeCw9mZzKdTBvOQe--

--------------vV3Schdoz5Ipmb5qyNC1l9ut
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJfpowFAwAAAAAACgkQsN6d1ii/Ey8V
EAf/WPUpt8GseljHMHGUbZ3yTZnVhkcsgTaoKvUWrlolRGry6Yvxzn1C7bh+o7eX88/jby830zVI
M7ixFWmFvwKZpNZ4yL4PiIyQut3zS7liL/wjJE0qD/LkeAsJK1nU2YRkV8SjoNHZZFywLOy7IrZP
cyju2Wz/9gwM0rcTOO24h0eu51MUZ0WeHCkrZhMuExyfTaSG9mFVkFV0KO27CGvkga9qiu/u7SAn
B8bP/DbgxCEaqjR2djUWHcfrP7cyHorINB6chnV0B3EsJFnaNByreELoIRPlB6leEEpppIn/++zn
H8HshVwreYZ8c1o7zqqc/CPggyaIjxd4HAnU7YJhVQ==
=h7VZ
-----END PGP SIGNATURE-----

--------------vV3Schdoz5Ipmb5qyNC1l9ut--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:22:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:22:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308833.524665 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3jp-0005sb-D7; Wed, 20 Apr 2022 06:22:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308833.524665; Wed, 20 Apr 2022 06:22:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3jp-0005sU-AE; Wed, 20 Apr 2022 06:22:53 +0000
Received: by outflank-mailman (input) for mailman id 308833;
 Wed, 20 Apr 2022 06:22:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BWYm=U6=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nh3jn-0005Ls-DT
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:22:51 +0000
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4b5be7b4-c072-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 08:22:48 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Apr 2022 23:22:46 -0700
Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86])
 by fmsmga006.fm.intel.com with ESMTP; 19 Apr 2022 23:22:46 -0700
Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:22:45 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 23:22:45 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173)
 by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 19 Apr 2022 23:22:45 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB3500.namprd11.prod.outlook.com (2603:10b6:5:6a::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:22:42 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 06:22:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b5be7b4-c072-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650435768; x=1681971768;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=i6tJ708GVSj0+gSZc2TeKfsPoF1n6uzLCmI3y/n+rNU=;
  b=jVoko/QuB0TMoE1WYzlVl2sBqwzhgyrxgzDckbOllcRS6ifF0wZM8nGK
   Nx+E6KlYrVQpGkxD/GJwgdYn939OlbovmXOyN+ApEsnqgzyLRY6Ktz+Km
   pY7rySuGCUI7UavLREFJu7s7nhjBayn7bpZT4jNIOCxtySSCIv2YnJ0uP
   Yf6uBPZADShdNZF2ldf0tyQpukPiUA4hKjoIzGz35VUH+lvjgMTNK1nqm
   CFm8K04XCIbrQc3QvmyEhua+wYsAeVi+zHx2P2rdXyFdeCBCI/yBV7SMA
   39rLwPSYPhqm1KK+b8fZwB8zMakz1ZRJb6vEncequqyIgfhw6Td4Fi+tD
   Q==;
X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="251258233"
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="251258233"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="804935255"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DnzjhNO9kVhLPEWMcQ6cB+Lc93BmB9WxXuECj2uM6Hk+NAFltqapGRVlKH0VxOiljAtAqfFusritS9/Y+WjwDSNBzTwm6Vpa7dZPbbXWAjVV5avmIUfvLSdzDv2L4Ecih+LV/QrKp4wxZnme2KoekQo4afq6FcTLUA0nY96FNAsedxw5wFmqef/NQ5EPO1UZHVaFNDsKHG8MGPEWDBdea/XgmHqffC+r2UFNaqZRObr+FKi4r/CCTT3k8QJd0E1bCml6nHlCXYJEm/MHGygExUDYKFT/33BTpgz7mJXHgauqZTMIB/roe8g3Ta9XTSQdRSIjPo6/guFrB+QrhbVAjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i6tJ708GVSj0+gSZc2TeKfsPoF1n6uzLCmI3y/n+rNU=;
 b=Th+pxJwgPrYsQRFm/auU8gljafu8+xMkoiy8w6S6uwng/0bTmcXrGX6j624XttAfYYWlaG8tPxi9AWkD6sEfHryA6c+GFusur5zdxIYprUgR4mcIwQejjynviYVRx4PA8WdPsZ2Npb7wdu4siQc6bx0H5XxGhtf5fgvgZNZzIkAoHkD/+5RC8CUfeAl0Ul1EO8QVdGDIBj03urJ2KEBxmpwlaBSAjscgN7xvd9cwv2xp1QxJdPgSVn/w5PRSm4ha2v78KrFhKMlTyiXijrfUfQVwwkImdNocKz9c0XPDua4To0jNwXHAa75WMU3RXf7oM10eCAPmLb631znahE7sDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, "Cooper, Andrew" <andrew.cooper3@citrix.com>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Thread-Topic: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks
Thread-Index: AQHYTYeTB5xLKnU08E+muTG4n+sN9qz4W6FQ
Date: Wed, 20 Apr 2022 06:22:42 +0000
Message-ID: <BN9PR11MB5276E8449FF75BE461E7148B8CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
In-Reply-To: <3430b8fa-6700-b5ec-a160-2e7609dd38a3@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0fb00e29-5015-4f99-4a7a-08da22962d4b
x-ms-traffictypediagnostic: DM6PR11MB3500:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB3500F66606A1476F6B407FE38CF59@DM6PR11MB3500.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 3HLQFA4/K8mllLGTtcAbGVNKPCIEO1iTdaPq5zlwbUTXsU7l8BLkY7aW5lFJrclNwi4O1q/F22QK7paC4rVRg8ABrOsf7tihHTmR3KkvXgNvKSfy7rQ2cDjZu6q9A5YtT9vwLASw9BkO/SuGx231zGjdAmbIv5BkGhz8q70IqR5dNb48LsNUrfgmzKJ6cgmG2AMtfxh8ENx5gsPQUpO4bmpkTm8wYQgrfqJzPwEndWyR5UUhH+b15NRqN2qEPJtC6EVZ5GHNKmfrdxiMkMUQys0pSqc/MJEbrdf4m6qz6ZJ/Wvku9/amTn8+XYD1lEmBOyNyXE3IgspqxsJt3fkBCDlMKgMxPBZ7DW98Qs5jL4WDVkpIfNxAJo4riCcrbbKFjTe1DIEzihCi8qETNSZmXQBS9rfDS5WbQL1H4WiK9vdnenPLENWU5bAWW95eAD1wzGy8Q22qtMXL2cQOrLdq2h1NxXYwxxeKsBlagsChwJnJaFqq6+0f09fG1qeHSn6NQG7b8q15Mid8GDp8L+3Ugy09mS2QkHRecXoPcEADND0R1261L7iJX2lUc9ou/6vbIKgysV+BBrdVgpIeFtL/TjI4bkA3WNj7EZHrIZJMBSRAp1AQMbepXX0DcWYPXgbiw8AyhGLxNwDJnueDVjD6zanLrRIUzjvfpQwvYCU8mwARipMMRVCHRAa4elH6l7GI/O2AHFRofFKQwfWVCTYZtA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(83380400001)(54906003)(2906002)(5660300002)(8936002)(52536014)(4744005)(122000001)(38100700002)(33656002)(38070700005)(7696005)(9686003)(4326008)(8676002)(508600001)(6506007)(76116006)(66946007)(86362001)(64756008)(66446008)(66556008)(26005)(66476007)(110136005)(82960400001)(55016003)(316002)(71200400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bVV6eFQwenlXVEtYNGFIT2ViRlpKMEU2Q0NRWmZ1UkhqeVBUcDN4SENRUXlC?=
 =?utf-8?B?QjNvTGdRL0pzWFpIU0kxYk81WkFpaGxXZ1djTWxiK04rZkszV0tPZ0p1VUkw?=
 =?utf-8?B?aklYU1BHZ0h1TDFVNUxRb0h0WDRrVWQvTHpoa1V0NHBGcERyV01JUExXbm5v?=
 =?utf-8?B?NlkzdEkxdUJCNW1mbDQ2dUJ5eVRpWmZ5SzNycndDaWhXd2h5TndKa0VreUhk?=
 =?utf-8?B?WjZnZi9sYTdQa3ZYZlVRb21jZ3ZTcXZUSGpHVUhtS003YmdzSit4bjNkTTRO?=
 =?utf-8?B?ck5uY29aOWR0dkpieWk1WkJCL2ZwTWJJbzRFVk5JOVNNb1J1K2lLVmFZNWov?=
 =?utf-8?B?TXZCcnlrbVR3N0Y2TXZLaEk0d3VQSU9lL1dRUURTOGNqcDFoM0xRKytpUEdO?=
 =?utf-8?B?T0dvS2lnNld3bmdhbWdZVEdxa3ZWYjRLbXJkRkhUNTlsWEVNbXk4T1RqR0V6?=
 =?utf-8?B?V2kwTTlsRkJzTE50a1BvU2YydllGcFdCalJrdFZCckp5ckNXdFpJOE9NWXVu?=
 =?utf-8?B?eUVaVUdsT0lDVTJTZWZSNnpDSXBvRGpyU1JSRXdTRGxxU0ZnUGtvQmcweTR3?=
 =?utf-8?B?eTJTR1ZhWUUzUUNKeVhZeXJzaXlXbGhPNnF6dWo5cWoyTEJ6U21lQXJjY0VF?=
 =?utf-8?B?VGFQREE1R0xObzhNdTdjRGU2TkJoK0t5ckJrM3JjeHpFOUFVLzA2NjFucW5V?=
 =?utf-8?B?b2JmYXFSdFp0L09QRW5qSkFFMEt2aFVacFIwaEZVNmVyazU1R1pqWWFCQWNx?=
 =?utf-8?B?eUJxS3VzRFJOVU5ZaWJveHRIZmpMK3RvZXNpWVdBL1VwcWo4WXk2NjhBMGJU?=
 =?utf-8?B?cUo1MVNSS2N4cko4RVRNSUdPVXFLcEZ4NDk0eGU1djFRckVLRDdSTWZjaXdC?=
 =?utf-8?B?QzU1ZTUzaGhUdlJzSGtJM3JsWFVSQTlkckcweHFJTzMyR25WckhuL1Q3QnFp?=
 =?utf-8?B?bW85OTd2bFk3aGpXZVh5S3JvRWNFTVdWMzFCcHg4ZDJuWitPMGFDeFVIMWVl?=
 =?utf-8?B?aEN6SjVzd3dPckN5MS9sZ0paaUo2UXBuWGNwMGRUUHFaYVJCanNtV0lzbUha?=
 =?utf-8?B?VFg4SHBCU0VSZUo0T3VkdERZZUF6SEY4czFuUit6VThZbjNvMU44TG9CT0Jh?=
 =?utf-8?B?NmtYbFJpWGhLWEJPcXo4YmdNNVJrb1l2ck1oTmRVM3VTTWlTQkpHM0Yvb1hI?=
 =?utf-8?B?YXhoWitMZ0VSb1hVL0xTVWVwT3NOb3hwdWpCYytpZS9UWVRXN01SWm01eGIx?=
 =?utf-8?B?TmcxQXdNOXBSWVViK2o4S2l1RkwwbDkyazhEWHZLQjVpWWk0bFlrdDAxeFJt?=
 =?utf-8?B?UE1GK2dnc0NWb0tlOXlWakd0TTUrNWo2eHA4SWtjVDVKS3JjOVpodkZjU3RM?=
 =?utf-8?B?d0YvanlnM2pkbTluV3E5YXdsRnFBWWNlb0F6NUJQY3B1a2k2SFYxd3RaaUVB?=
 =?utf-8?B?aHpwK0dFMk5nRi9WYmVqdUFsQ0lVK3ZiVXE3d2c3Mjd6RTVDVS9GVW9SSWEy?=
 =?utf-8?B?SklZM1l5Z0k1ZnVFbExZQ3drYWJmNXZkV1BhYnp2RGl3VXF3RE9iSUNtMVV2?=
 =?utf-8?B?K0FZVWc3ZnF1TlE3aytoSGM2S1ZSNStlT2ZTelJsYUtncE1lVkY1NndjQnpP?=
 =?utf-8?B?eVp3clNIUDlJNForNnJlZkgrVXh3L3QrVzk0RlB2U1p1bjVZQUxkb2lpSWhX?=
 =?utf-8?B?MmRQeS9ua2VXRFloL1FWSlZRSXVIcDZicVFCQXBVU2IwMDM2MFBDOGF5Y2Y0?=
 =?utf-8?B?UnNlKzVKendlVEpRVGpXb1hmSW8velFGZWNzN2cwWWJuWjFSNTlHZENSMmE3?=
 =?utf-8?B?bGhsRXp5aHg0YXg0cWNER2tYTlNKNGpoOUczdnpnNXN4bEpHNWxiSDRHTTNO?=
 =?utf-8?B?Q3hqWlpPU2NEM1pwRFhLT3FNZGE5N0VyaXVHTDV0Ui9UZ3pzelBUVUx6RHJ5?=
 =?utf-8?B?T3hxb1Y5cVFmRmlVUUZLdXpaRDltdUxOblhDR2h2dStHVGhtZGdjRk1PQzVM?=
 =?utf-8?B?bHdjSVYwN0lYQ00rVGs4NkJyYkNOZU44Y0o3c0dMcXhSczB1MVdWUkl4Sk1w?=
 =?utf-8?B?NEQzZmRHNzJGMXpmaDBUNFhUUEwxNFpVcENOOVJJb0htOG5YZU5OMHIrdWpq?=
 =?utf-8?B?eWR0WFQxcFd5RjVKYkF4eWdvOFp5dkVDeXVxS0VTcjU0SzNVWldpdVRzRTZB?=
 =?utf-8?B?c0VCTHAxVnBJZm9wV3h2dVU4M2tPelVDZ2lPdzdtZ2JWUHYvckRDYTF3TmM4?=
 =?utf-8?B?TUl6OFlRQWR0MklTWitlUEY1WEU0K2tiOVhDcHk3ekNPQncrTENoQXBCQ1N6?=
 =?utf-8?B?aUpVTjVBYldHSHdtZHJubkc3V0habVkxeGE5R214VmpCUGJtWFl0dz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb00e29-5015-4f99-4a7a-08da22962d4b
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:22:42.5430
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cARzXvizHQnqKbhHFwrm+gG08e0qcbZj2gljpOmeIkEBBVqrVNhX5XIpbA9KvKDxrh6F/RbBA2FJ1vP53Bdw3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3500
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMTEsIDIwMjIgNTozNiBQTQ0KPiANCj4gUHJpb3IgZXh0ZW5zaW9uIG9mIHRoZXNlIGZ1
bmN0aW9ucyB0byBlbmFibGUgcGVyLWRldmljZSBxdWFyYW50aW5lIHBhZ2UNCj4gdGFibGVzIGFs
cmVhZHkgZGlkbid0IGFkZCBtb3JlIGxvY2tpbmcgdGhlcmUsIGJ1dCBtZXJlbHkgbGVmdCBpbiBw
bGFjZQ0KPiB3aGF0IGhhZCBiZWVuIHRoZXJlIGJlZm9yZS4gQnV0IHJlYWxseSBsb2NraW5nIGlz
IHVubmVjZXNzYXJ5IGhlcmU6DQo+IFdlJ3JlIHJ1bm5pbmcgd2l0aCBwY2lkZXZzX2xvY2sgaGVs
ZCAoaS5lLiBtdWx0aXBsZSBpbnZvY2F0aW9ucyBvZiB0aGUNCj4gc2FtZSBmdW5jdGlvbiBbb3Ig
dGhlaXIgdGVhcmRvd24gZXF1aXZhbGVudHNdIGFyZSBpbXBvc3NpYmxlLCBhbmQgaGVuY2UNCj4g
dGhlcmUgYXJlIG5vICJsb2NhbCIgcmFjZXMpLCB3aGlsZSBhbGwgY29uc3VtaW5nIG9mIHRoZSBk
YXRhIGJlaW5nDQo+IHBvcHVsYXRlZCBoZXJlIGNhbid0IHJhY2UgYW55d2F5IGR1ZSB0byBoYXBw
ZW5pbmcgc2VxdWVudGlhbGx5DQo+IGFmdGVyd2FyZHMuIFNlZSBhbHNvIHRoZSBjb21tZW50IGlu
IHN0cnVjdCBhcmNoX3BjaV9kZXYuDQoNCkJldHRlciBhZGQgc29tZSBleHBsYW5hdGlvbiAoYXMg
eW91IGV4cGxhaW5lZCBpbiBvdGhlciByZXBsaWVzKQ0Kd2h5IGFib3ZlIHJhdGlvbmFsZSBhcm91
bmQgcGNpZGV2c19sb2NrIGxlYWRzIHRvIHRoZSBkcm9wIG9mDQphIGRpZmZlcmVudCBsb2NrICht
YXBwaW5nX2xvY2spLg0KDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+DQo+IA0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBp
bnRlbC5jb20+DQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:22:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:22:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308834.524675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3js-00069r-Qc; Wed, 20 Apr 2022 06:22:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308834.524675; Wed, 20 Apr 2022 06:22:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3js-00069i-NH; Wed, 20 Apr 2022 06:22:56 +0000
Received: by outflank-mailman (input) for mailman id 308834;
 Wed, 20 Apr 2022 06:22:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BWYm=U6=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nh3jr-0005Ls-JY
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:22:55 +0000
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4efc88fc-c072-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 08:22:54 +0200 (CEST)
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Apr 2022 23:22:52 -0700
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
 by orsmga007.jf.intel.com with ESMTP; 19 Apr 2022 23:22:52 -0700
Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:22:51 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 23:22:51 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 19 Apr 2022 23:22:51 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB3500.namprd11.prod.outlook.com (2603:10b6:5:6a::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:22:48 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 06:22:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4efc88fc-c072-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650435774; x=1681971774;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=03xnvSEgeZc2kLEIH/lD3I3fUQvE0976IRBRbE2YKPI=;
  b=UjNuOVl5uI0mdFNmTpCNR6R5Kopjcw4bCK55i2epLg5o6Q5NWbKF8nR+
   qLDKOsjc8DUO95MoD4C5WB9a1vWGXXjzlKjBqKhXknBR5IOgPbDBgZsZ+
   VVnrFKh7o6wQY1PLPnw32PLz1uvkP/VaxHBq98hOnyAaW9aITQ+znyV2Y
   9lZLUkwToSUwlI/4rJrkRGymZ/SHqYi2+lXxseSaS60juu8BILL88cB+W
   xemsyf4zE9XVzoIoF+pEcZ2mSq3jdwtfqhXpxcHk7+uK841Rg10pQY3yi
   H5b3qwb8a/RbpwBNMN+GJ9EvnpMm1gx7i7sOgkZZm08C+vjl5UHiD125s
   w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="264122902"
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="264122902"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="555053049"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YMEcQ1xs0zWy4Y6fCf08AZzGHKo+UYD2jKCe0AM+0tx38XTZ8GycGnOS/Lml3yRjILryyaJVI5fOgUYj97CsAKrrPbu9D2BV4Za+VlJQne1kgcbUjF9l1MHs6HFV/CuvlPikRh9/gGgJAIFN4UDq/fqdqT+ViWLebMGpIyqao8ovmPd6IYbdlYKgChKXcNHP57S9Uy1pCCnW9tMhPqVy+u5SrCnUF+Jj2Kiu14VYSibKXK3iIDU77ozNiOca9967WnYQIB7LJg9KOiO7YJQ+WSDyI+11p0VkIJ1B/2jkwMNEmZ73FS25LkUgqJJH+9VTu9knhIteCWJT8Hb6XV3+jQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=03xnvSEgeZc2kLEIH/lD3I3fUQvE0976IRBRbE2YKPI=;
 b=mvPTlOoywlI+01R26Ms3qYv6RCXihWG9I3H7UtI4uP40ee8+i9BlwmhLarQCtObaAF6fUENAdZRGn7ZVOUbnzAYdF0ZQM2BCcbIf+DC2YsKx9+hpDL5sHuhsfxoFauJBpr2iIVIyVIGgiTO8HDenUfFNfnAq2uZ8sLkXdYvwMNLMjt/Sr6UYxRt2rQmhxiu5FM6Ywc1HsD8q3ZLv301p1mBXDcbt7WirgipP6LlrO2v+52K0rMfm7bHAKrUf2Xap1YiCN//5++Zc3FY6bgwCW5A6r8OYrr0QG71EhYYEQBGzEJCmCgSbR7fdrXrDIYEysK9Kx6ibOZrKu1cE1igGYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?=
	<roger.pau@citrix.com>
Subject: RE: [PATCH 2/8] VT-d: drop ROOT_ENTRY_NR
Thread-Topic: [PATCH 2/8] VT-d: drop ROOT_ENTRY_NR
Thread-Index: AQHYTYekX5EMpeqzC0Kga/gFrdxJaaz4XMTg
Date: Wed, 20 Apr 2022 06:22:48 +0000
Message-ID: <BN9PR11MB5276E62B24DC42DE517CCBC78CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <ad944163-e8cb-6ecc-7e6f-400f9e8cd4bd@suse.com>
In-Reply-To: <ad944163-e8cb-6ecc-7e6f-400f9e8cd4bd@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 361ef8b9-248f-4812-45a1-08da229630f9
x-ms-traffictypediagnostic: DM6PR11MB3500:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB35003F77F57C08A8E287C1018CF59@DM6PR11MB3500.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: UJUekOWK7eIkksHMdMC6b3Vf5165sL3S5dXy/PgvC/4yD8wGKEoFjqa/iZRfUOu33JtS8TU2KFz+j9boOIV/XXDNqUa4WpsTZ7x4cBBwCdaeRNngKnVBfUdKZq/u+AvwCZhgtzjuTGZx4EbNd9og7sPHP6xk/8K7Le2DSKUxLgVKy3DxvL8jXMEPAqSkDBbHA9pdziTJeA9hQ+GZeiAx90Fh8XQu2Ty2R4DoxvKA0UD1PBwsE8Nk0Ng8UvVXjK1Wxuc572oEQ9hkNLHvRr/YhXcY97vi0Z4W6ZNPNshyuPRWA4btmlZWHoEIYtx30DbWj/0E8neepIV2OPIYvUNt8/6HFbG6d1BChZaq/6WPgumilBi/ZvcGtKSlNHqq6sYpCPvkZ9sDJEFKj/8ZYYKKjdH2hTtNWpoR/Dy6xbTP8cP2rVGLHXrpPheg63JkpRldySM4jm0W7WK8KSyKC0fSenhFgLShOS7vZI/qyMXaZlt2frPJY9R4XiBLdjK7HOEXE+DBLO6bqI2qX9YrudoK/UdjWHnBcBlLrfj3I7SinkYwPssmj9y9ldKiLiA2yhyl/oBLaiq5lRPqJISkAS9hdJ9Mwj+67vDgEFBsVDGYsv92JNAGvXi4SucV8mL51p87ngpnHx/ytlAanbUfR5iTCYd27RyyBeHZ4NU4lzlfrOP9+n5syHp0kXuWDJRSNRj38AeVvdAZPilUpLt9QETGgQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(54906003)(2906002)(5660300002)(8936002)(52536014)(4744005)(122000001)(38100700002)(33656002)(38070700005)(7696005)(9686003)(4326008)(8676002)(508600001)(6506007)(76116006)(66946007)(86362001)(64756008)(66446008)(66556008)(26005)(66476007)(110136005)(82960400001)(55016003)(316002)(71200400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?byszVzBoTHJRSVB5eFJpc0g5cVhmbS83c1NEZGdFeXdVUGdHOStFcXVjUDZa?=
 =?utf-8?B?WUxWOEVDWDQvRm0xekM5cEllQXUybyt4OVU2UTB4T2wvbTc5WEtGSGFabUlF?=
 =?utf-8?B?UWQxaWR5UEw5WEM5ZE9hZXhsYjYwOXFIS1hWZm1tQWpmTm9TbnBFbThVQUpX?=
 =?utf-8?B?S3lNZ3BUZGpyNUk4QU1EUjg1TmpxVTl5dy9VTzJqanNkejNTQ0NPallUaUFu?=
 =?utf-8?B?NCtqVWhtUmVaUE02Znh1TkplL2ZzNUNmVExMOHI2dWFMRlppMU5ZdzVhTU51?=
 =?utf-8?B?b1pYSUxvR0kyVkxkNzlBa3hJM1JKRWFqMmFVWWFiZGhKWFZaWmNHRnRFakpF?=
 =?utf-8?B?bFdORVpnODlqSmRzR2dTdVhyMWU5SEJSR3JON0pyTUpHRzg3a0c2NnVYbENr?=
 =?utf-8?B?MWxSeDl5ODk5MTFzRzZ2a1FtVFdzbkxPUHhZWVhoWFY3WkVXS2pya2lmRVRM?=
 =?utf-8?B?c09NZFR6dEZWSUlJSXJpSGFUczNSOVVaMVd6Qm8wYkI0RXNNem40YnhhWGdZ?=
 =?utf-8?B?NkNIUXpTRGFoZUpXOTdobGN6L21qWEZ4ZnNHRkFUbUtsblRsNWR0QjNQMWpK?=
 =?utf-8?B?T1ZNaTFhMmZZWDlrNjB6RnNXcFBabmtmMC9xdkFmTTdzU3ZJZng0TVU0RHFW?=
 =?utf-8?B?RFZmaGdHRU11SEpaeHM2YVJ4MmxRY21vQlgrWnBkZDZTTCtmd2Y5SjUxeitR?=
 =?utf-8?B?QUdjQU54N0lWRGpBRWlNY3crejg2SjJaTjYrMXdRWjRkZ3ppVzRzT3ZyUUZ5?=
 =?utf-8?B?ZlRsQjVEM0U2VERPSzd0emVlM3hDWFlvVlRlK2N1azdacU1SMTJqWnFyQlFW?=
 =?utf-8?B?dVJ1dXRxQ1RrS2V5L1pTSS9hRVRjUzhpckQzczdwYkJ2ZUNMRzJCdTNhUml1?=
 =?utf-8?B?aGNRSmJURDFOak1mU0xTVS9JWUMvQWxWaDZ6K0U0M2dhdUcxKzFoei9mTFhP?=
 =?utf-8?B?NTJvZksyMkNxNnVMM3ZpRUJLQmtpMGI0Y29OdW5ZeHVMY3NPWk9OR3VtZGFO?=
 =?utf-8?B?WU5MYm5MWnpCR3BhdXpYOC9yM1JzNEE3OXpHblN3SmYxSEpYVnJCeThQN3pM?=
 =?utf-8?B?SHZlOW82cDFLTUdZSEp0Q3FpUFdVMVhTQkFmbFlEZVVWNjI2R2Fqb2d5QlBs?=
 =?utf-8?B?Yk13ZmVURzVMSjE5V1JHUmw2aDRiMFdDdkY1U0FPcGtoLzFLVUxmWkZQTVJD?=
 =?utf-8?B?aXZKbVdjOGdHeTJFakdmVVV4T09KUVJGUVZZYk8wK3NkRVk2VXdMTlFRU01y?=
 =?utf-8?B?WWh2STZicE1HMklkS2xIaktid2pGdURMMjJVSkxPOGMzWG1KWDZHazdiMUxX?=
 =?utf-8?B?bTc5aEtzbE5vcXhJRmtJTkRRWUNZM3MwL1hPVmdSbVYrSW1WV1FPWGUvQzFW?=
 =?utf-8?B?MXpOeURtendpbmhzK3VqU0IvVTF4K3RSbzRNd05CZlV5aWZLL05mRDRSNURm?=
 =?utf-8?B?RHZEdVY2bkRVK1M4NWVsRjlRNGYxYTE0aWloaDRJODZnK01SMUpyK0dCVkYw?=
 =?utf-8?B?NUUvZndzejdmdzJBOW51b0xiaXNiSUdvMmlHTklZU0FrazNJQU4vcW5GbitT?=
 =?utf-8?B?QWJTRllMalpwTmE1alA3c05KcExZbWYzZ0pzR0srSnRQME1tbjJXNDM4U0d2?=
 =?utf-8?B?SHp2N0RXdFkxakd5MmRsa2RhaE1EbFRwTXJvUnp2RnNqaWx4eExFM0ZhY0lS?=
 =?utf-8?B?aUx0UkVRblNuMWVNWWJHV3REZzBFTXJsWVNRbXZJSituMEgvUkthakNxNWpS?=
 =?utf-8?B?NndXRnVibyswRWVpaHY1WTBYYm8wSGRualFDNml4ZHhqS1ArWTRNRmJSTVVx?=
 =?utf-8?B?eld4dkMxbEluNEsydGZkaU1HN3gzNEZQMWhXQkZuTU5QT1hpVkNKdFd2ZDJQ?=
 =?utf-8?B?T1RwNVNxcUwzYzJrKzJVME0vVHlGR0dZMkZLUU1FcFFHbEM5bHlFWFhxN2hh?=
 =?utf-8?B?QzZla3VWZGVNblltWEtpS3ZyRkFrakJLNWl3VFdMc1EvZHcwLzJJN0NZK2xG?=
 =?utf-8?B?NHh0WTk0MUhqZEl0c0hpSzlVVVd6ck9MQlhPVHpXazJEcTFqVEk1WnRKV1pl?=
 =?utf-8?B?ZXp6QXlxOWM2YTV2bzZMdHhLK0tjK3RaRlBveXhiRjF6ZXVHRnJwc2FhZytk?=
 =?utf-8?B?Q2ZNc3JtRGxsNlZMWHdMK3pxUGp0M1RxN3dGcWRxc0ZBTFo1ODhBOHNlZ1Fy?=
 =?utf-8?B?M3NWejJYZTMvQkVYbGlWM05uZTc5cENINEdOd1lTNEVMNy9WZzJoUDVwYTNR?=
 =?utf-8?B?Skc4S2F2bVFSNTlwemdvbUowUEswdDl0WlJIMUtNOTJHaElOY1VPaFpCZTFJ?=
 =?utf-8?B?TlVxR1YyMFozeXI4ZHJjdm5yYWZHMHQzN056STJlWEh4OGtwYzMyZz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 361ef8b9-248f-4812-45a1-08da229630f9
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:22:48.7021
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yMJgW3AAqm0pRo/SHcngZKWqmUX0TckQFohZU5NIlRf11RHrld1HwFm5QiNKDfa+KjTGa1p88P39uBFyzjDsNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3500
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMTEsIDIwMjIgNTozNiBQTQ0KPiANCj4gSXQncyBub3Qgb25seSBtaXNwbGFjZWQsIGJ1
dCBlbnRpcmVseSB1bnVzZWQuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGlu
dGVsLmNvbT4NCg0KPiANCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11
LmgNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgNCj4gQEAgLTIw
NCw3ICsyMDQsNiBAQCBzdHJ1Y3QgY29udGV4dF9lbnRyeSB7DQo+ICAgICAgICAgIF9fdWludDEy
OF90IGZ1bGw7DQo+ICAgICAgfTsNCj4gIH07DQo+IC0jZGVmaW5lIFJPT1RfRU5UUllfTlIgKFBB
R0VfU0laRV80Sy9zaXplb2Yoc3RydWN0IHJvb3RfZW50cnkpKQ0KPiAgI2RlZmluZSBjb250ZXh0
X3ByZXNlbnQoYykgKChjKS5sbyAmIDEpDQo+ICAjZGVmaW5lIGNvbnRleHRfZmF1bHRfZGlzYWJs
ZShjKSAoKChjKS5sbyA+PiAxKSAmIDEpDQo+ICAjZGVmaW5lIGNvbnRleHRfdHJhbnNsYXRpb25f
dHlwZShjKSAoKChjKS5sbyA+PiAyKSAmIDMpDQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:23:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:23:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308838.524687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3k6-0006gE-3J; Wed, 20 Apr 2022 06:23:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308838.524687; Wed, 20 Apr 2022 06:23:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3k6-0006g7-0A; Wed, 20 Apr 2022 06:23:10 +0000
Received: by outflank-mailman (input) for mailman id 308838;
 Wed, 20 Apr 2022 06:23:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BWYm=U6=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nh3k4-0006Zi-Ii
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:23:08 +0000
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 56778402-c072-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 08:23:07 +0200 (CEST)
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Apr 2022 23:23:04 -0700
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
 by orsmga007.jf.intel.com with ESMTP; 19 Apr 2022 23:23:04 -0700
Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:23:03 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 23:23:03 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168)
 by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 19 Apr 2022 23:23:03 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB3500.namprd11.prod.outlook.com (2603:10b6:5:6a::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:23:01 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 06:23:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56778402-c072-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650435787; x=1681971787;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=BIWWfM9iZH0+bH/FAioA3hD07UHmH0hPVS3+Dk9IaFc=;
  b=k38Oo2tyO+40u1gCCy4gzXq9iE099gGLRcuon+fd+2tUl0jEotXdSJpn
   KQ9xyZduiZfjg961ZVazr2LBMAG8UBLsdHP0FFb/CAebSAMOkq9B56fbk
   KgWo99JDfoJHWaD2A1WNKgebszIbCeih49nJf93UTswQLS/to/s5Phgar
   yRJOWFqJYr0N/UJW6VeHEjRyw1ezRqqjayE5DQGAjTTKha3tjp7KYHEub
   W8Q5lgA2ef2Ov5CulViAT0dNn91nLCFNSSM+lB7ZbKUAOCvtf8Gz0H0U5
   o0dDF/nmszCRfKzq884m9RZ3Ckm23DS9dpvvLbltMRCEcg176RYuBhuac
   w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="350399945"
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="350399945"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="555053117"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QMJfUEhVSzm4yx1NkGLLGHqv3rxUvc/X4X1rEg7DSlBJtJxbCaHshMjmGzEZMHWRX0Sg8zL/sxPqohkFFR60UxUJ+TAhaqDxmd/ynWWBu4+rBZ9avfdn92o219Pvy84X3ADvgurArkKdTzGl1EbUf2r1Q/J4IlXmVNyEs/ftAtmEr3yzvhCBzfDqhh4Wq9b6C2c0WTHAg5nOtj6X4B+isHoj7gUOGijtNF8VixhFtBoIDw4o6vSEyeFtzZuKZFnkQECKfeiGCEQgqjBuCsl/xVarMC5Wafc4gfj/R2jc458e0+fAOoeV6xmPq1o32EjSbuQRftbPZQEZ1eKYXPMPaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BIWWfM9iZH0+bH/FAioA3hD07UHmH0hPVS3+Dk9IaFc=;
 b=WUA8Vbi9aTIGBqb9LLtzNNSbkayauJxceu9r1jV10fz09YX7KQaRUMGv8omFaWZuPaIzgB8nqiolz3V/fMEkdrbuhGNEPYts9X60Ezz4RhjQGwc/JtqDd3rmkSjX7X+birv5MBGbU2f/tjjKxOrw0ZB9cqp1K+JHSkeH62mf8u6sjWw83NtWoBi7uxmxrvgurrsUMFTFUw4UWXbZkwD/4fDe6y068C1Y1xDgOSj/BFWUzVM+PHEPMKPEVEbZ/roAqk+5fY8lp16pdDuHv89Xj3f9wDLrgrxqc5cdhTwng2Yv+HeVrCoumzdNCm51Vpv8I5C+puhVJtPM2CWD1WkwfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?=
	<roger.pau@citrix.com>
Subject: RE: [PATCH 3/8] VT-d: plug memory leaks in iommu_alloc()
Thread-Topic: [PATCH 3/8] VT-d: plug memory leaks in iommu_alloc()
Thread-Index: AQHYTYexZ6cM0C9e8k+mDwbf10797Kz4YUeQ
Date: Wed, 20 Apr 2022 06:23:01 +0000
Message-ID: <BN9PR11MB5276BC531E1BDD930D99F05F8CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <10f43cc4-7a09-9f4f-0a6b-fd7ffd88310d@suse.com>
In-Reply-To: <10f43cc4-7a09-9f4f-0a6b-fd7ffd88310d@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 70466c7c-737a-4909-893f-08da2296386d
x-ms-traffictypediagnostic: DM6PR11MB3500:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB350077457191236328DFDE808CF59@DM6PR11MB3500.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: j7kvcC1kH34rVqv3ecn40ERBLjIKjG1qTxHzQzTu8X/5YALAn809sVoGGmzBf9Mg5aOmUO2M8VJeCVjP18DI8BcoSDGJ6vuzpdoTrinqF/hOCCIq1DbTUysreT3Fvo1XrB7Yv1vC7n6PJ80V3Yxt1S/0kk5NITAIbVHpj7rNgp+0CKxFfNr5/8PcQ9g4HGVgAVHXfCU3iJGCLrkPP3pMSmbqFwUqjJqHKE61ywi1wYVhpJ6eAU4Q7wNeWsZFIAIaV0of1R8JLZZDJOMv71vdxtAFCVXQx5+NJtQaFmw/7xcC8HnFWBAcJn3BwffiCVfdEIhGL1o4uNXd6y/+Uu4Q5FkRluwFrimWPItTr5Z57URO6CWdgPCay45D5LGkGpE401m9KeZiIyjV607sClmCM1WdupbTQJaZZ99xbMj7Om1Og1ZurvRA1tBkwpItthkbLhw4A/nyz95jPKoWrprbWX83Ggnxc3efTLh1M/fJgdfzNbD2tkWdIInP5rYzGTGcniMC+dD6l8JSjEJTrHpI8Jkbb32jXRvzanHvCE+4fmI7HS3kcW2xgGHQiQHPIDoiboYnowtwOoEmaoM2/qLMLJyE+PCrL9fas0eI/UVGYZu/zydnEoy/f34DNzfRDP8kVmd9Q/IUwT6ayqaK5mBgdTbjsg7h8tTuZhZQ9pwH3PVmzHRUgjwmB4P35IsL7P2nAAYFxYxMOGmSGgT/ST6Y4w==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(83380400001)(54906003)(2906002)(5660300002)(8936002)(52536014)(122000001)(38100700002)(33656002)(38070700005)(7696005)(9686003)(4326008)(8676002)(508600001)(6506007)(76116006)(66946007)(86362001)(64756008)(66446008)(66556008)(26005)(66476007)(110136005)(82960400001)(55016003)(316002)(71200400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z2ZDSTFPVndsVFVpUmJlWG5haXBHb2VtYk5zbEdsdUh1RW1FdDUyNEZjd1dw?=
 =?utf-8?B?aTFqc3E3ODRzVm96NHFJNHlyaG1EdHRJbUNpL0tDWUZhWTZ2WVZtWStSNnA3?=
 =?utf-8?B?MXB6RTJpckhXVktuYkJLNVNWcjNGUzFVVnVxaWhxaVZYR3hMUlpMUi9lZytM?=
 =?utf-8?B?WXVjaFRNNUVIVEVEY0ZnOWdqUlQ5Tkg5YWo0VDFpY1psb1huRXIzclJnV0U5?=
 =?utf-8?B?a1V6MnFqWFdsck9wei9kaVQxaElvRm41SXV3QlYycVFEOFB5MHhkTUl5empS?=
 =?utf-8?B?ZGxWWEpma045QU1zc1VlLzFFZ2VZTGRFRTE1U0dxMk5MQ2xYNGlqaTdCL0E1?=
 =?utf-8?B?K2dHUTZmQnpQdHdtUDF1YWFlT0FNNWFnNWxDZzZVdXVZNFBFN2NzVThZeDAv?=
 =?utf-8?B?Z05DVE9EaUthb3V6YTFPanVwZDVsUkd0anFVb2l2WU9Kc1E5RFVlTjREN3kz?=
 =?utf-8?B?NUFZd0NWTWpFOGZwb1d4SVdPWU5jbFpKek5zVlBEWm5xc1lDWVhmUU4zd1JI?=
 =?utf-8?B?ZUtuV0tDSGp6TXFISVJ0TWZXNTdmN0U0Znc0UlV5SmpqblkxdVYwNGNUSlY3?=
 =?utf-8?B?S1A3S29WZHVGZkkySFp4WjdPV0lNalJCT3VZZGdueXNyOU5xR0ozbXlCKzU5?=
 =?utf-8?B?WjdBL1dDYkpiSGlXYzh1YXZmNHRVbFMray9tT1NDRFdhMk5DaXhCVUFTTUEz?=
 =?utf-8?B?c0thNE84aFlJVXlwWHFvSXpCek9YL0ltcWE4cnlCK2pGUGRKeVBvV016MTZv?=
 =?utf-8?B?amVLZm5lV1JTbGtZbnNNemlraTd4T1VhYWtBM0w4U2phOVpTbTg1Snc2ci8y?=
 =?utf-8?B?OXd4c1dKUVJnUzVrblJsRlJpNkVRdDNYTHZnQjNiYmp6ZXowMWRkaFRleVdT?=
 =?utf-8?B?MG9FZEZsR3lqVkhYbStHMEJ4cjZ2cFkzQ0VWK2g5RG9xUm0xMDZ2bUdSRXZY?=
 =?utf-8?B?OTRqK0F2OFZRanl5dEhzWGJlU2gzaFlENmpBYkU3dzVSY0MvRDRBaEhvUlMz?=
 =?utf-8?B?dmU5anlxQVQrNnZaQ1pFSzlZbWxBN0J2Q3lNZVkvMTY2OWtpenY5TjBtblFi?=
 =?utf-8?B?WEU5RldwY0ppTVg1Z1hJZ3BYY1ZwclZ2cVRTaFllakNuY0tJbHcvc0Q1N0hQ?=
 =?utf-8?B?eGZLSUFDdXJXc0h5czYzNkx6U3VWYUdHbkFicDBoU0lyMVEvcjR4ejlsZFBC?=
 =?utf-8?B?L3VnbDFRWnV3SFBycGh0bmh1K1NmQW1HNzB3REJaK3dzY3JQK3lBVnZCNTFj?=
 =?utf-8?B?djdLQlM3U1pqQ0lGZUVPZlRyMkN2SUZGc1pQRkxGNmE3b2dWSFdsWnBwWnBj?=
 =?utf-8?B?WVhpZVcyZjFkclZld1hMWUt6S2R5TXpOeis2VnVFU00vUGpGZEtveE8wQll2?=
 =?utf-8?B?NVUzNzJRbEYrVTc3Um41OFFncm9rcnZ3L2hlek9JOVRCenVDdlVPZTMvSmNL?=
 =?utf-8?B?SythVmpDeE9TajNXZFp5d3pnR0QydGJNQ0UvZEVWOXpmb0ZzRlJUL0ZWUDNY?=
 =?utf-8?B?S3p3OWFHTEJTTjAwTmdNWTh5eEFNNkhPMHl4ZjFCNng0SUlUbGRjT1JHM0RM?=
 =?utf-8?B?QWh0akdrc2d3a3BLaWRHb1NGY3RsaGkxOFdkNGFmVVVmditiUk96ZmhHU1Bu?=
 =?utf-8?B?Lzl4RWxUVzVsWkV0SWpqTmlZbnh1MmR0R2huWkF0UTNKekJIdkg5TUEwcGJB?=
 =?utf-8?B?QWhLTzd5a2NEQ1g4bUZ2YjdiNVBhUjIvS2FKQ3FTWTJPZS9ZczJESGYrZC9H?=
 =?utf-8?B?end1d1luWmdrVFRPUTA2SXNEMUVtWk56YkR0VFFtUHM5VjM2Q1dwOWpYNFRZ?=
 =?utf-8?B?OGhsS3VqTFA3anR6TGVCeU1vWlU5ZFp4RG9XaEpDQVJrV3UxeG8xVjEwdzNv?=
 =?utf-8?B?Q3JBL0NhdEdzS2JET29pejNCSUl4ZWNhTGs2YlloWndtTTB5dytUM25UNVJP?=
 =?utf-8?B?Y0Y1UDl4aDF6SEc0UnVrWTBNSjZoTVlpWW8yOENIaUs1cGF4MkZUK0JnZGd2?=
 =?utf-8?B?MGFTZnRvb3VaRFhVZzgyUE1yRVJTZFhTUi93RHErSlNDUXlyaFozRng2eWo2?=
 =?utf-8?B?QURHek1EYTR0QU8yNGRPdi9xOU5XWVl2QW0zZXlpcnA1NFZhVUFNL1FCNHd3?=
 =?utf-8?B?UkZBdnVJWTQyVVd3anNRRm5CL2E4Nm02M3hnaWw2dU1IRUlpazhYa0dRdzBR?=
 =?utf-8?B?QjlNRXNHMUN6MG13YUdBYXdmdFVqbkRJWVJic1VQekJuRnFFTGxHbDlPcElk?=
 =?utf-8?B?aklLcjZFMGxBUVI1bzlCM3F1MFA1aHF1a05vNGVScHpPSkE5OThDYnlHVE1i?=
 =?utf-8?B?OEZaL2c4MzhuVzNRY0t5bHh1V1gxN2l2UEhNYjBNblZzUUdMR0pwdz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70466c7c-737a-4909-893f-08da2296386d
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:23:01.2081
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fGTrtn9kwwi10WF3qsLgYXX3ZWJJEJHUPVL6EvqKbkEopeTTb25bhkogL17zNsm2uCXtacq/xxKxI7fR9yKJbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3500
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMTEsIDIwMjIgNTozNyBQTQ0KPiANCj4gV2hpbGUgOTdhZjA2MmI4OWQ1ICgiSU9NTVUv
eDg2OiBtYWludGFpbiBhIHBlci1kZXZpY2UgcHNldWRvIGRvbWFpbg0KPiBJRCIpDQo+IHRvb2sg
Y2FyZSBvZiBub3QgbWFraW5nIHRoaW5ncyB3b3JzZSwgcGx1Z2dpbmcgcHJlLWV4aXN0aW5nIGxl
YWtzIHdhc24ndA0KPiB0aGUgcHVycG9zZSBvZiB0aGF0IGNoYW5nZTsgdGhleSdyZSBub3Qgc2Vj
dXJpdHkgcmVsZXZhbnQgYWZ0ZXIgYWxsLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4u
dGlhbkBpbnRlbC5jb20+DQoNCj4gDQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0
ZC9pb21tdS5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+
IEBAIC0xMjM4LDggKzEyMzgsOSBAQCBpbnQgX19pbml0IGlvbW11X2FsbG9jKHN0cnVjdCBhY3Bp
X2RyaGRfDQo+ICAgICAgZHJoZC0+aW9tbXUgPSBpb21tdTsNCj4gDQo+ICAgICAgaW9tbXUtPnJl
ZyA9IGlvcmVtYXAoZHJoZC0+YWRkcmVzcywgUEFHRV9TSVpFKTsNCj4gKyAgICByYyA9IC1FTk9N
RU07DQo+ICAgICAgaWYgKCAhaW9tbXUtPnJlZyApDQo+IC0gICAgICAgIHJldHVybiAtRU5PTUVN
Ow0KPiArICAgICAgICBnb3RvIGZyZWU7DQo+ICAgICAgaW9tbXUtPmluZGV4ID0gbnJfaW9tbXVz
Kys7DQo+IA0KPiAgICAgIGlvbW11LT5jYXAgPSBkbWFyX3JlYWRxKGlvbW11LT5yZWcsIERNQVJf
Q0FQX1JFRyk7DQo+IEBAIC0xMjYwLDggKzEyNjEsOSBAQCBpbnQgX19pbml0IGlvbW11X2FsbG9j
KHN0cnVjdCBhY3BpX2RyaGRfDQo+ICAgICAgICAgIHByaW50ayhWVERQUkVGSVggImNhcCA9ICUi
UFJJeDY0IiBlY2FwID0gJSJQUkl4NjQiXG4iLA0KPiAgICAgICAgICAgICAgICAgaW9tbXUtPmNh
cCwgaW9tbXUtPmVjYXApOw0KPiAgICAgIH0NCj4gKyAgICByYyA9IC1FTk9ERVY7DQo+ICAgICAg
aWYgKCAhKGlvbW11LT5jYXAgKyAxKSB8fCAhKGlvbW11LT5lY2FwICsgMSkgKQ0KPiAtICAgICAg
ICByZXR1cm4gLUVOT0RFVjsNCj4gKyAgICAgICAgZ290byBmcmVlOw0KPiANCj4gICAgICBxdWly
a19pb21tdV9jYXBzKGlvbW11KTsNCj4gDQo+IEBAIC0xMjcyLDcgKzEyNzQsOCBAQCBpbnQgX19p
bml0IGlvbW11X2FsbG9jKHN0cnVjdCBhY3BpX2RyaGRfDQo+ICAgICAgew0KPiAgICAgICAgICBw
cmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVggIklPTU1VOiB1bnN1cHBvcnRlZFxuIik7DQo+ICAg
ICAgICAgIHByaW50X2lvbW11X3JlZ3MoZHJoZCk7DQo+IC0gICAgICAgIHJldHVybiAtRU5PREVW
Ow0KPiArICAgICAgICByYyA9IC1FTk9ERVY7DQo+ICsgICAgICAgIGdvdG8gZnJlZTsNCj4gICAg
ICB9DQo+IA0KPiAgICAgIC8qIENhbGN1bGF0ZSBudW1iZXIgb2YgcGFnZXRhYmxlIGxldmVsczog
MyBvciA0LiAqLw0KPiBAQCAtMTI4Myw3ICsxMjg2LDggQEAgaW50IF9faW5pdCBpb21tdV9hbGxv
YyhzdHJ1Y3QgYWNwaV9kcmhkXw0KPiAgICAgIHsNCj4gICAgICAgICAgcHJpbnRrKFhFTkxPR19F
UlIgVlREUFJFRklYICJJT01NVTogdW5zdXBwb3J0ZWQgc2FnYXcgJXhcbiIsDQo+IHNhZ2F3KTsN
Cj4gICAgICAgICAgcHJpbnRfaW9tbXVfcmVncyhkcmhkKTsNCj4gLSAgICAgICAgcmV0dXJuIC1F
Tk9ERVY7DQo+ICsgICAgICAgIHJjID0gLUVOT0RFVjsNCj4gKyAgICAgICAgZ290byBmcmVlOw0K
PiAgICAgIH0NCj4gICAgICBpb21tdS0+bnJfcHRfbGV2ZWxzID0gYWdhd190b19sZXZlbChhZ2F3
KTsNCj4gDQo+IEBAIC0xMjk4LDggKzEzMDIsOSBAQCBpbnQgX19pbml0IGlvbW11X2FsbG9jKHN0
cnVjdCBhY3BpX2RyaGRfDQo+ICAgICAgICAgIGlvbW11LT5kb21pZF9iaXRtYXAgPSB4emFsbG9j
X2FycmF5KHVuc2lnbmVkIGxvbmcsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIEJJVFNfVE9fTE9OR1MobnJfZG9tKSk7DQo+ICAgICAgICAgIGlvbW11LT5k
b21pZF9tYXAgPSB4emFsbG9jX2FycmF5KGRvbWlkX3QsIG5yX2RvbSk7DQo+ICsgICAgICAgIHJj
ID0gLUVOT01FTTsNCj4gICAgICAgICAgaWYgKCAhaW9tbXUtPmRvbWlkX2JpdG1hcCB8fCAhaW9t
bXUtPmRvbWlkX21hcCApDQo+IC0gICAgICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4gKyAgICAg
ICAgICAgIGdvdG8gZnJlZTsNCj4gDQo+ICAgICAgICAgIC8qDQo+ICAgICAgICAgICAqIElmIENh
Y2hpbmcgbW9kZSBpcyBzZXQsIHRoZW4gaW52YWxpZCB0cmFuc2xhdGlvbnMgYXJlIHRhZ2dlZA0K
DQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:23:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:23:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308841.524698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3kF-0007Dl-Bj; Wed, 20 Apr 2022 06:23:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308841.524698; Wed, 20 Apr 2022 06:23:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3kF-0007Dc-8h; Wed, 20 Apr 2022 06:23:19 +0000
Received: by outflank-mailman (input) for mailman id 308841;
 Wed, 20 Apr 2022 06:23:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BWYm=U6=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nh3kD-0005Ls-8F
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:23:17 +0000
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c14b469-c072-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 08:23:16 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Apr 2022 23:23:14 -0700
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orsmga003.jf.intel.com with ESMTP; 19 Apr 2022 23:23:14 -0700
Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:23:13 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 23:23:13 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 19 Apr 2022 23:23:13 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB3500.namprd11.prod.outlook.com (2603:10b6:5:6a::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:23:11 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 06:23:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c14b469-c072-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650435796; x=1681971796;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=+oUTanEnh2AObnHMuWR4ZPdXYH+k9bN76JETz2KqUek=;
  b=atLK8hKYO54LYVXfzNTK+UC4NTqcE+JJp3qrB0FQyc6HrLcv4jEnUnVd
   odO0xFvW7WBMhRwOX+YaTj7haYLKBgTUp/O7cE42SGgiJYdJRulcvifmC
   0b2qxoViL7YTOCjV5v9D3wIg8q11nfoqRiujcc1O74hTN9U8wDPVPSRyJ
   SZYkumhHvaitxg5g7vdlC2Av/5Rtf5otkNsCmYQbGj/FAhOThrzdmOq1d
   atpOHNSEwKm9V8zFOwx1PWcN0tA++oyMHA1Fv7rDFT3F2o9c05aalJzP8
   7PxC4ufo77B3Mrda5an5rOB6UZrKjGL0exzZMBBNh8/n2SlDHMhip/KFo
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="264122960"
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="264122960"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="510429285"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l2GQ/030/ccWmP2IEf+/KYzyg1U/fjaUlQObA9/uCYV87nZuMX2vif3ZufqWQbJyCiy7I6r9fvmtN86Btz1z4/MWCdVNnIG3nD0P2wgBUjIYLT8kZKlOg3IEZn+Y8ljZDrrRk+JSDtE/rEQrEubGdA6FcKQYG4omiq4PzboR2W9Vv+RiR2975Ik8PtHTOg4MjgEoohjVcLg9olHiJrJpVKuQg6sZFbc3bkXG8Ouh+CIZA1ZQZAS2h+XMgGX0lkD/4Zs3+gCxeH1DuJPNeTch2x8+3iOfa4KmBCOQOkz7yyUWYGZ4Uvlxrv6ehn0blTY9tqwlX0Paw2qx9rJSj5hIJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+oUTanEnh2AObnHMuWR4ZPdXYH+k9bN76JETz2KqUek=;
 b=AOEkKmLlfBb1I+/LvtIQJodwmGScI8ZgZjoEmUVhTdNb5RuLSWAm82VQWTpseA5Yb5clcFRbwl2f7Jwr2qkeSv2D37ieApGuM/BceCvrThPqmZzT259TEwBw0M14SXpni5lKTREqwCkZemaXEqA2yqQTuUjDdQM4wzS1W5oYZIA1+8hEUIHY+FL5NGmWtrdTKhw/8H26EzUgftz9HoYzNgjvNuD/Q4pSlJTXZKlxFgd6z903fxHoGaurV19TAdc5LfFXuTKRs9ZRrYPx+hLidM9v5ayhgqrx6unieGKgzjHxsG9UOW/6AzfCHoSPs1oWrAIm3OJPpZtBqowfkpGOyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?=
	<roger.pau@citrix.com>
Subject: RE: [PATCH 4/8] VT-d: refuse to use IOMMU with reserved CAP.ND value
Thread-Topic: [PATCH 4/8] VT-d: refuse to use IOMMU with reserved CAP.ND value
Thread-Index: AQHYTYfNLLeYzKkfHkCJpFNUAy97oqz4YdEw
Date: Wed, 20 Apr 2022 06:23:11 +0000
Message-ID: <BN9PR11MB527679AB16E82DE7BCE5EF888CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <0f7136ae-0b52-431d-f789-4b7d5bbecb25@suse.com>
In-Reply-To: <0f7136ae-0b52-431d-f789-4b7d5bbecb25@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7c863f4f-f1d7-401b-7131-08da22963e93
x-ms-traffictypediagnostic: DM6PR11MB3500:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB35002B73E2816F540F88B5648CF59@DM6PR11MB3500.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: pg6+6WYOJnpg+hOhUxmJ3PWsRWZAC0f8VYUXcaT7xnBNDAUCQB0e4a17SLO0nBkfmomAqMWJ7SLnHUqm/b08Qsi3vJaiYjxQ9aaZHAL4oYuOAbxRs/Doc7m4r1sjEVI+TCSsWls2xkQ74juQylnz9p5sOPdGzhVNUZlhJdkuGKp0f/02BU7vfHxEKb+rSplrza91PfA1OHC0q9tafVi8ZlJu1NDUrW1dO2gXy98wCIEkIkJP53lF735vqG0aO7RQH69RwyBxLbegNreAJuuJyuXvIqh97c3vDhGqM5xSuoXxEcGWufrhpVMflAKqLfiVTmZTDdnjgF/Z3n8o7pRgrnL2HY9a8LKYCmUXYr/B3XrigVl8Jj8H0/ieEN73gPI7S/PZ7UedX5y+Z7PmJxWoqHd6LOGlJ4Z4+w75FnoEY+W/XTLRY969s46GSKtpYIq+qd7I/sPBJoueqBuwXXV18ClriVx2Raozn8V2W4iuqxdUEr/DlTA4zjcwt545r0M8geZXlwUBQC1bEhXfF5nQ4C4Q5UyGPTvGpk1Z/JL8KMrJv75jJwkTLU6RWpY8cTMAX2hUQp2i3nyOofrteb7NF0l+5/uMX2aoZkPvcpgi4dF5sA2+Z4YdccVEa8M1Izwcx2y0/gANPR8LJYgslo11okAPxs+NexAuGoUbeWis5uo6wuoYf4PFkO6er9lmuiUhQyO7jXCETXY3rgzaci04YA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(54906003)(2906002)(5660300002)(8936002)(52536014)(122000001)(38100700002)(33656002)(38070700005)(7696005)(9686003)(4326008)(8676002)(508600001)(6506007)(76116006)(66946007)(86362001)(64756008)(66446008)(66556008)(26005)(66476007)(110136005)(82960400001)(55016003)(316002)(71200400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SlRNRnV5YnovSzhvZElnOFo3U0Q2ME9NUHhwejZGUDhnSTN3RXdKV2Vqc3Jl?=
 =?utf-8?B?RU1jWTFkUG5QeDh0dVk2VHpDUXhoZFhPTzQzSUU3TzFET002TmRPVWpiU0FV?=
 =?utf-8?B?c2RhQXFUVnNGVDEyRjF5bTJLaUlta3F1a3lTS2tFZ3FxWnp5cGE3V1R6aDZT?=
 =?utf-8?B?WFA1TmxHQmRkOXhWQmZGd0YvWFV1d2o1bEJFbGtDd1lvRUp3K3NJNHNUWUIx?=
 =?utf-8?B?ZW5FM1BZQ2k3TXVkWTE0cjc0STJOWnk5NWxleXRGY2xISEp6YitCUTBKK0ZV?=
 =?utf-8?B?bGM5ZzVaT3U1alFjeU5Ub2JzeEFlWGhjYThmSHIzeTRGZVlOTjMvWmtMLzZt?=
 =?utf-8?B?YldpbTIweDNCeU80QUdjOU9vSzk1NTBXY3d3RSt6ZWdEbVR6VCtrZ3NEN0dT?=
 =?utf-8?B?bHZkMEs4aUVVL2pSaUFCaFR4cy9sOExRaWxMcy8zVC9zc2tFMDFXTEQ2OGI3?=
 =?utf-8?B?QlJDN3BBMUhWcmE0R2dqaDJTU2V2MEwvWWs2NEFUalY5T0RXaXYrQmRNZkVJ?=
 =?utf-8?B?RFdiblZmZVhzdkFHSXJXM3JXZHkzRGxnd3JLNXo4OFdISXBmL2lqS3lweU41?=
 =?utf-8?B?OHY0dmNlbURNS1l4WmljN1doR2pRVXRGRTY3b1k1Y1o4cDRVRThzajNXODNK?=
 =?utf-8?B?ZkRyNEhtTG9IK3R2Skpnb2JtSDFBRi9GTE1vSHprVGwrRzVSeEVFeUtnaVFq?=
 =?utf-8?B?TkRiWlRvUkNiSjhnWmNvdkRubGZWMkd3dk5CMWt3ek92L2xiZE82eDVtWG5v?=
 =?utf-8?B?WklYd3hDV2lLTi9TSEd6NTdFdzA2aG82UFJvMnZKdjZGUXBubFhQS2VFbXVk?=
 =?utf-8?B?NExabTRNL2N6aHRTUS92UGkrTzZlaDd1SmhwOEdmRDViV3hPMW5wWlRMUkpt?=
 =?utf-8?B?ZTVLdUFQSXJGTjlKelhoMURGUktOb3lmckNtZEFtVGF3MFhobTM5Si9jaE4y?=
 =?utf-8?B?SFM0aTBNaFhqc2FtQzVSSlRxZU1yWnBreFA5NXJYQ25zZ3ZteXdFWndXOVJ2?=
 =?utf-8?B?OEFyU2liYy9IUkxPRFUrTjBzSUNvY1pWWWxEUUZ2ZXM1dW1xU2lqcldDMXpZ?=
 =?utf-8?B?eG9MYU0xQW10NUdWdThTRklOVEVxOUM1QWt2bEorSkxmVUpsZU5YLytxWk5O?=
 =?utf-8?B?UlJQOGhRMXo5UUdDRkJraWxaeFdCd1Z6V1ZXYzlLck1pQU8xcDNDS29NOVlS?=
 =?utf-8?B?OUFNWEMzQmxkZ3F0SWladDN2cUV1a2NpYkJIQ3pLcjIzdi9hRmdQQXpDeWcv?=
 =?utf-8?B?SXdHVU5acmQ1NlEvM3FwRThuNEp2TUJtZGl0TzZoU0owK0ZHNm1reVZWZ25t?=
 =?utf-8?B?Q1U4bERiQVZ0KzhUbmV6ZDJWOFg2MXZsQ1BsR2E4eHkxa1RuUElYbG9QQlVV?=
 =?utf-8?B?aHFXUVh5N2JWbTdvNjIvQ2hoNjVCMkhlTk43eUo2dSswbHlDNjZ2U2ZxUXZJ?=
 =?utf-8?B?TktVaFlkRythODI5QUtGc0R1Vldpb3RNQlNoc0VDTzJ1UjFLRGpsUThhS0ZJ?=
 =?utf-8?B?M3JEd0JRWk91L1dzVVBsb2pCNkliWVpZYmZ4Wk9PcDFvbjFSLytOSTI5bXY5?=
 =?utf-8?B?ZzJGZWpEcEVnam9YWjBSR3l6M2R4Ym9DKzdlK2FaZEdCUGxVb0h0STY2OGI2?=
 =?utf-8?B?Ukd3TzhhMWg2RGlKNDdRS1RreUtwWE03cW9JblhCMExsUmhjTTNzZW9PT0g1?=
 =?utf-8?B?UUZmK3RMemxoY2F2Mm1GdkpDRjdsZVNQUjd5T0lyS2lUME5tWW5BTjFmNkhK?=
 =?utf-8?B?STZWR3VXc2VpaEpYWFp3aTJ1cFZZOWhwbTRyc0tCV0c5K09PZ0MwUFhmYUY5?=
 =?utf-8?B?b2hZOXU3MnhwMytkTmVicE1mMnI0ZU9VMFpmN2p0ekFQRVh2K1RNTVVRV3Ey?=
 =?utf-8?B?eHpSbEFicFRkckYzSi9DUUhCVWd2akNRUUxNUXdjYkF3VGtLZjh1L1JxQnRK?=
 =?utf-8?B?WUFuOUoraEU5enpzcGNFT0djS3lHY2NBQStyaUtvZ3lRazN6dUhreUdRRHY0?=
 =?utf-8?B?V05xcUl6Sm40anQrd09vTTNDVkJaNktJTFo1TkgvN0swb25uL2VzK2hZM0ky?=
 =?utf-8?B?SGZyckszRENVRlIyS2hTYUNCdi9POWpCUTNnSHFEU3E0UFg1REg2bDV2SmVE?=
 =?utf-8?B?TG83YmM5QXNtSHRJc01nUzlabjY0TlhrNjAzbWpoeTN4eXhoWXVzUkp0dEJU?=
 =?utf-8?B?d2VYLzh4U2YrTXJXbUdmcENaaXM1RWJhVmxMeUIrb0R6YnZjQ0JaSTAvUjFm?=
 =?utf-8?B?WTcrOC8wb29XYU5IV0MrWWw3S29qTzdPUlRkeE41UVdTc3p6Z2JwZmNkQWtO?=
 =?utf-8?B?QmNYMzBISC9nc3R3L0hzUFVJK1ZQcmQxNFA0eHpCSXYrbDVvMlBkZz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c863f4f-f1d7-401b-7131-08da22963e93
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:23:11.5230
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RlF4ogfQofDYMaKpr4cyopJx5FKUrVoJ2FPtV5sMiQNhd20jf1WVXj6X0CEd2/IQQtH40S+MGrDamC2tnmpjwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3500
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMTEsIDIwMjIgNTozNyBQTQ0KPiANCj4gVGhlIGZpZWxkIHRha2luZyB0aGUgdmFsdWUg
NyAocmVzdWx0aW5nIGluIDE4LWJpdCBESURzIHdoZW4gdXNpbmcgdGhlDQo+IGNhbGN1bGF0aW9u
IGluIGNhcF9uZG9tcygpLCB3aGVuIHRoZSBESUQgZmllbGRzIGFyZSBvbmx5IDE2IGJpdHMgd2lk
ZSkNCj4gaXMgcmVzZXJ2ZWQuIEluc3RlYWQgb2YgbWlzYmVoYXZpbmcgaW4gY2FzZSB3ZSB3b3Vs
ZCBlbmNvdW50ZXIgc3VjaCBhbg0KPiBJT01NVSwgcmVmdXNlIHRvIHVzZSBpdC4NCj4gDQo+IFNp
Z25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmV2aWV3ZWQt
Ynk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KDQo+IA0KPiAtLS0gYS94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC92dGQvaW9tbXUuYw0KPiBAQCAtMTI2Nyw4ICsxMjY3LDExIEBAIGludCBfX2luaXQg
aW9tbXVfYWxsb2Moc3RydWN0IGFjcGlfZHJoZF8NCj4gDQo+ICAgICAgcXVpcmtfaW9tbXVfY2Fw
cyhpb21tdSk7DQo+IA0KPiArICAgIG5yX2RvbSA9IGNhcF9uZG9tcyhpb21tdS0+Y2FwKTsNCj4g
Kw0KPiAgICAgIGlmICggY2FwX2ZhdWx0X3JlZ19vZmZzZXQoaW9tbXUtPmNhcCkgKw0KPiAgICAg
ICAgICAgY2FwX251bV9mYXVsdF9yZWdzKGlvbW11LT5jYXApICogUFJJTUFSWV9GQVVMVF9SRUdf
TEVOID4NCj4gUEFHRV9TSVpFIHx8DQo+ICsgICAgICAgICAoKG5yX2RvbSAtIDEpID4+IDE2KSAv
KiBJLmUuIGNhcC5uZCA+IDYgKi8gfHwNCj4gICAgICAgICAgIChoYXNfcmVnaXN0ZXJfYmFzZWRf
aW52YWxpZGF0aW9uKGlvbW11KSAmJg0KPiAgICAgICAgICAgIGVjYXBfaW90bGJfb2Zmc2V0KGlv
bW11LT5lY2FwKSA+PSBQQUdFX1NJWkUpICkNCj4gICAgICB7DQo+IEBAIC0xMjk0LDggKzEyOTcs
NiBAQCBpbnQgX19pbml0IGlvbW11X2FsbG9jKHN0cnVjdCBhY3BpX2RyaGRfDQo+ICAgICAgaWYg
KCAhZWNhcF9jb2hlcmVudChpb21tdS0+ZWNhcCkgKQ0KPiAgICAgICAgICBpb21tdV9ub25fY29o
ZXJlbnQgPSB0cnVlOw0KPiANCj4gLSAgICBucl9kb20gPSBjYXBfbmRvbXMoaW9tbXUtPmNhcCk7
DQo+IC0NCj4gICAgICBpZiAoIG5yX2RvbSA8PSBET01JRF9NQVNLICogMiArIGNhcF9jYWNoaW5n
X21vZGUoaW9tbXUtPmNhcCkgKQ0KPiAgICAgIHsNCj4gICAgICAgICAgLyogQWxsb2NhdGUgZG9t
YWluIGlkIChiaXQpIG1hcHMuICovDQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:26:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:26:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308856.524708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3nD-0008Q5-UM; Wed, 20 Apr 2022 06:26:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308856.524708; Wed, 20 Apr 2022 06:26:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3nD-0008Py-RQ; Wed, 20 Apr 2022 06:26:23 +0000
Received: by outflank-mailman (input) for mailman id 308856;
 Wed, 20 Apr 2022 06:26:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh3nC-0008Ps-JN
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:26:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb570ec7-c072-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 08:26:21 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-WJJp6WiWM9yGNgmjnJhg1w-1; Wed, 20 Apr 2022 08:26:14 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19; Wed, 20 Apr
 2022 06:26:10 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 06:26:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb570ec7-c072-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650435981;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mE8ftP2l0OUfGr4rw3d+irpMjfRLgo/vGwXH8jh5ELo=;
	b=SBDWFj2QUppQ4VXshyqh8hd4wy4G88DSAAorRguN3PuF21UAZo741Et1/doc6fwXnAm0p0
	SoCWGg4x62hW/NHzPVo5DcurTPoH8xZ/OFeKqpzIpLS8wv3wHKmUzIsWEp3mAXt+B5u5El
	MJaJ4OW+g3D4DDZ8MQhN6jedhBpb81A=
X-MC-Unique: WJJp6WiWM9yGNgmjnJhg1w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EErfmegagevATmGrYZ6D/y6xO8d63DZYuRMPzhL0pxgRKp1wwEN5wNC5cL03U94tYGJL4Vg3ZLAbVGprzkH/mucSVVKR3/t/lH7uMMD5EKJ+am0OKLSEim/meI8E8mM5wTB3U+MHTWFStxMo9bdM1ZXyDDoxR+zpvdOdnfEp8XYmMDlkBiw93igxNMQx30ZKmFDz1O8DKJ+y3/k6qnWAjLrs8UbQJ6EDNuFvZmlTWAyQ0ucX4lGNHDY5ZcVXUwkEwvO19Q0G/IwTavN/OSAkYBaetyHGYrpJ2gS7AunhG4JSin3Vdk2sC3SP92KNN8HPfZFNX8Xc+FNaeG25FIbOAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mE8ftP2l0OUfGr4rw3d+irpMjfRLgo/vGwXH8jh5ELo=;
 b=YJ2E6ENFT9eyxLvj2ePe2zQkH5MI5h62jenJ0S6FV4xUuNq/lXbltFVE77SMQon3ZQkIv6j4AqmTNfBq/qfP8w27xzWh6MaK1Uu6NFUrOmuE6dv8JLOu4W3NVItAQV8D3i1mVilXnu/or5Ht59OabQp5hBfHIaClQdSOvJuSTRsUpB/kswFlRhuc9RaLGQDEM6ftpoIXnz/0Fw0BIfor/acykNTSatE4H8AYVN25oD0kEo44vWZCVq7UZ+byJU02AB/9JWQPfEiCBufneH9/F0/YYoiweP+R/vlHzqaeqBwVZ2e2i5saEnBkhPK1mT3wdipvuxaGlsqQZzTKsTLyMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c65c58d3-e553-4247-680a-4d072b1c7c05@suse.com>
Date: Wed, 20 Apr 2022 08:26:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220419150134.64704-1-dvrabel@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220419150134.64704-1-dvrabel@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR02CA0034.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::47) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b9c6d69e-3a83-446a-76c5-08da2296a8df
X-MS-TrafficTypeDiagnostic: DB9PR04MB8461:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB84619166119044B0C70148F6B3F59@DB9PR04MB8461.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q+J7a4sSFMrapDQK8f6/2Zv/M8jCStGaODoqU/mxADrmamxaALcx7ZLS7YXVGICQ0RHrZWl91iByoSUxjJfSWoks7wn2DFSY9mNo/pzeK1yOsUYvQFswygZiWkwvl5FaDmW1IRdwZDSV0Ll7bSpBPwJKb/UWioSk5AfvEk7Yrp8XoC4KRxRoNSTIHkmT6LYM83DMrQhQtVJC2601tzAfrXNnDORvHnI2o1ZEpaBhDDTYul99n5Fe5q8WtLmwsDFSd7ruz+ZED/zQKGFPxmZTzFO/OozQ3+prUWfVwT5ZQVnGqtB0dT/sn9zxU/0iN6S4zyCO/2Y8G7F32Dpuwwz7lPDc50JPaLqR2XKjT4q1G1KPYNSIW+//UKWeOb93RQtOSz2SUqUyKGLd+9v2cKqMsU9dRVQGcgbuVG/A8vPTDAgfJ+DHNNcDdvNH4c6gGjDsJ6/cwNghuu46baymxqvPRHo82nNWniEN70j3fOr1w6m6nZEag9MILgRZ/z0p7lkd902d84LooJ6z/lSYqXYNh3Jhi4VZc4CyY9VetHJlb0ppb+TIQBf1zaXVEyM/DcQ/EpOLOGNUC2Enku2+FKwEk54ShzHqA6yaf/uDkhR3cS31RFA06v2g1Ohi4wwpOFPAh2OQ8qs1Ozw0IRqd8cBUBerTDWIt7lz0N4wwZwnAqxmyUh+SbAiZBYa50uiZRsK0bE2y1FJMrluhfHTCXDUKZNMVKUAs6FAcjeKe2mky/WU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(54906003)(26005)(6916009)(316002)(83380400001)(6512007)(31696002)(8936002)(5660300002)(86362001)(53546011)(2616005)(2906002)(6486002)(38100700002)(36756003)(66946007)(31686004)(66556008)(66476007)(8676002)(4744005)(6506007)(4326008)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?djFZek5rUkpnQnRxUHk2UkhtcFhZNUR0YmNiVUl1aWFDRy95NFpWV3BVeHlj?=
 =?utf-8?B?dEtyRHVmMlV0ZFdtMHF4OWtmTjdyQ2VsUnBUWGU4WWkrdHRoc1ZkRjlDMWhk?=
 =?utf-8?B?OXVMY1YxNUdKakxSNnFJVWU0ZTNRQ2NySjA5c294Z0hjQVd5WEZwK2xBQkJm?=
 =?utf-8?B?eERubGNtc2UwWmxhbjBpUHUrUGtML2NWSnBEUTRMRnJaZnozdVh0MTNDdzY5?=
 =?utf-8?B?MG1zZitqaVRRUTN1ZlFHYnRNcnJKaTE1aDNrZ09iQ3g5RHNjZlJrSFNnWGZl?=
 =?utf-8?B?aUdlbE5mWWEwNnlZYjNRa1B2TXU1NzhWUGNGYnpZeEhTUzJ0RGQwcDFxRWxJ?=
 =?utf-8?B?cVhaSXk3dXJEazVsTEFhQXFCYjRVMlRLSzVZMkI4TG5RZ2FkRkxPLzloRGhy?=
 =?utf-8?B?Z0xsdS9lNHZ0SEZyU3JhMG8wdGVTdlp2aFc5cUI2K0tQR2FqUnJpS3BkckpS?=
 =?utf-8?B?bWM4TXNYbFZaY1c1OUdXb1BIcGFCSEUrZnRpSnZFR2hqcGJZSDFibXR0UXdr?=
 =?utf-8?B?OEI5L1MvQW1iM1d0WDQyNWwyRGtqdnRUbFA3Uk0yZk9EVnEyTVNpRHJhWEZQ?=
 =?utf-8?B?TkZwY0xDQ2YrRGxDZ0VzNVh2T2JaVWVTQ1MwM21razdHR0drem9EalV3VU5S?=
 =?utf-8?B?cDhjOTI5S1pVeWdBTnU2RGNSK0RpYnBwUG9uUEVoY3pHN1RENmZ2VFFlU2ZX?=
 =?utf-8?B?dlhKL2ZiSVl6bys0bHl2bWNjWEJzK2t6UGg2elNrQWo1WGY4WFFHaHhRa0dF?=
 =?utf-8?B?UE5ZVHNVVHRIUExxSmE5TmZCYldRYXI4elpkV0FvcjhRcXk1QWVZeGJ4UzNt?=
 =?utf-8?B?bm5tb213ejdabVZVNnBsNE9nQmJGbW4vb2lkTDlZZmVhMVVPTVpzWVpnQVlH?=
 =?utf-8?B?U2s1d1haZTFIZDdZdEhVc2lRYkRGT1pIdnl2ZHhZbGdMMWdZQmJ1aS9kc0lZ?=
 =?utf-8?B?Q01GRTVTaXVBMnhtNHU2ZC91TDBOQ0lZNWYwNVA3dVFzaXN3RnNXZ0p1dE56?=
 =?utf-8?B?SU9ONFFTcjJpYk04NkpDM2hMaWFZb3orSTZSbzVQWWN0Y21RN0RaZ0lqcEk0?=
 =?utf-8?B?b0piZ0ozaG9VNmpsL3ZRZk5TVFpmbnZIektSYlZFRGNySTVBZmt1WjFmckZN?=
 =?utf-8?B?Q3NOWW9QODFqNXk0UTFiV0h5R2dtcDJ2ZzZBRnVOTGtneWZ6UkZ5VGpuQ3Zp?=
 =?utf-8?B?SVI0dHV5THpoQVhEOHVKWmxyQk1ISFAyN2pFUE5sU0Nsai90d3Rna3pmdW5p?=
 =?utf-8?B?MnBPVVJ4SUptaDIyRHdHd1hpdkZFRzgzUlgrN1RYUmluUFRRYnAwODBFNlJz?=
 =?utf-8?B?WnZrWEZ0NHhFd20rTHRrc3lRb2FPMDhteDZabzRkNVBOK25TaFdUcGtOM0FZ?=
 =?utf-8?B?STRxaGloNkZibFdKU21xNmFBaDFja2dGeGdDL0YzdDdHZ3RCY1kzR05BV0Qw?=
 =?utf-8?B?SG9WUU1ZSGxsaHhiNGhNeWRRUWxqUDJ5UHRSbGsrWVMrcmRubkkyOHdMYlFr?=
 =?utf-8?B?L21hNy9tUVlGclFPUEU1QUlHK2d1SmZnb25KSHh6MTVUVnUzUDVPVlZCMld1?=
 =?utf-8?B?UWdJZjlXV2VuSnhqN1B4OHdPckRYdjB3ZnZ5ZEVudngwYml2TXhDcktIRHVp?=
 =?utf-8?B?RnFwcVpPZUQ5WllVTWtNYWxYRHJOOFNQWGt1TkVLR2hId2lEV0ZPM1BWeHdr?=
 =?utf-8?B?NHQ2SGxEVjdFcEJGc2czSDRKQWkySlhqMTF0WTZkTU1RcUhHZjkxV3NOYVgx?=
 =?utf-8?B?ODZNWGFXSit6NDhJVEpDcWhsVjZQMndqNEV6NHloZVhDWHRqZ04veVBCb1lr?=
 =?utf-8?B?ZFVsOEltb3hOb2RrYWxmeW1rcnZ1aUFyVHNVditwUVJBZlZ5RFk5bURFdVBR?=
 =?utf-8?B?WTJIUE4zZUlDM3JDOTJkNFB2RzduL1NTQVpKaUR5UUtOYXpJejV1anZLd1VN?=
 =?utf-8?B?TkNOQXRHMGh1SG5rblcxcG8ySUFreXBpeVN4S1pha2RiYUw0amZzditGMnBh?=
 =?utf-8?B?L3owVFRUQkhPLzJ3YW5hd3FQWXNVSmJIVU5vcDc4RTRvd1g3ay9Tc1M0NU8v?=
 =?utf-8?B?dFgrTnkxWTZNekRJRVQyWmZVVDBzc0Q2RkdlcHA2SmIvOVpaYVdtdFp6cURI?=
 =?utf-8?B?STBPUU1wT2JHcjdKR3lzYlhhRWM0RVBvMVg0cnpPTjB0d0RKaUtMZnJrMnJP?=
 =?utf-8?B?eHVHMFF3VUtvS3UrNy9hc09VRThPd1piYXdNUkI5Vnc3YTFPRVlLbXVmc3F3?=
 =?utf-8?B?OWRZcEMyL0xPRHVlb005WUZaOHYzb21LSzRYSVgyaG1mbWhnRVE1ZDFhSWpo?=
 =?utf-8?B?K1N1RGYxRXBwVFlvb1htZkF3ZkcxdTQ3Tlo4VkhBUU9hNjAzeHVwQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9c6d69e-3a83-446a-76c5-08da2296a8df
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 06:26:10.1096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HkoFmEO+++p+p5tNCYu3nQsbCNlXJRnCYad98mNwLztbKMHbmVmNm82NGpMgoMsgxG9UeMN2dVo/V3cxck1dvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8461

On 19.04.2022 17:01, David Vrabel wrote:
> From: David Vrabel <dvrabel@amazon.co.uk>
> 
> Heap pages can only be safely allocated and freed with interuupts
> enabled as they may require a TLB flush which will send IPIs.
> 
> Enhance the assertions in alloc_xenheap_pages() and
> alloc_domheap_pages() to check interrupts are enabled. For consistency
> the same asserts are used when freeing heap pages.
> 
> As an exception, during early boot when only 1 PCPU is online,
> allocations are permitted with interrupts disabled.

This exception is tightly coupled with spin lock checking, i.e. the
point in time when spin_debug_enable() is called. I think this wants
making explicit at least in the code comment, but as a result I also
wonder in how far the extended assertions are really worthwhile: Any
violation would be detected in check_lock() anyway. Thoughts?

Furthermore I'm concerned of Arm not using either SYS_STATE_smp_boot
or spin_debug_enable().

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:27:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:27:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308860.524720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3o6-0000X8-9h; Wed, 20 Apr 2022 06:27:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308860.524720; Wed, 20 Apr 2022 06:27:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3o6-0000X1-53; Wed, 20 Apr 2022 06:27:18 +0000
Received: by outflank-mailman (input) for mailman id 308860;
 Wed, 20 Apr 2022 06:27:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh3o5-0000Wt-6J
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:27:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ec07c335-c072-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 08:27:16 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2053.outbound.protection.outlook.com [104.47.0.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-vFnyL7U6NqKiGPh0e49RoA-2; Wed, 20 Apr 2022 08:27:10 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4998.eurprd04.prod.outlook.com (2603:10a6:20b:f::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:27:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 06:27:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec07c335-c072-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650436036;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mF+8wfBV4l29vYWlrfh5o9Jb8pNiIIu7yo85Nbqj+QE=;
	b=mHlN7C5RyJVPOUGvpRzYU7ezC5LqpLzzRd+egUwA2LVXkaizqu5hT58uS5Sh50F67Hy/H2
	RkUo412qo56YzGPwvnCjWp2+h+FUBYHbYyE/HRPbpUMVGAshCEWpFO91px1jgQ66hPxkeu
	Sa5n201/obfjSGyJPanK2QEnUcCFKd0=
X-MC-Unique: vFnyL7U6NqKiGPh0e49RoA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QHzoub5ypQZYnvrUlT6jRMReyLp2ckiPL+cdUup9rSKg9O7rnl0dveVu6ZjGd3feSIoEZx+D2ZM9C7O0UxgUb0p7ZfDVGbUGQ8YCkJrgtupTAstMESG9svCaYVqX+tSEzgB9sBfj4fVcBO3GQu5sLbIDDJfpNd2XAzjnbpnGvOrsWysxtRyG31hkP2W6TbSnFUfOSjqYDrSYDNrluzMf3YWE/HoTaZ9fjVXZ1sIx6qy44i69lIKbE86IWRYvGkqXxpUFbp1B0qX4rE8QVNdS84t6wKQ8ocqp8r6miUXCq4tghG6IM9Qq1wY0FvNpqvk0qfyjfUfEtKxuHUkRdDx3OQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mF+8wfBV4l29vYWlrfh5o9Jb8pNiIIu7yo85Nbqj+QE=;
 b=crC0cZB/gW+G3S+U1N1yK9MdfknKnKGH5LUy1IryF1/ON0d4oDQk0KyKqBrl9uSrGgEIT8h2HYPKm6xlYHgGYtcIYwOKAf3zxmQ1qT8GL7rjUn3YkVQ97rWrhH5PoKPmD/Qf5bNYML8sJZJ+YdTlpitmyz7pnFhImtcoT/lMI/gr3uB+R72MX2LMbJJNalFMkhuF4JDiBt01sfFWA/CxCrnE9Z6TJntvU1Bhd8T8pDP8RlQdifjR+++Mqdb5lELTEEaFzsd28QN6mfBMyoOtrr27JI9FG7DiqVBsVocPcBDLp3H6Fs6N8Vr4MOP5e09kiDje2E/8AMlluIEQ40Fz/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <74f6105d-d3a3-6508-3c6f-3aac53285c5f@suse.com>
Date: Wed, 20 Apr 2022 08:27:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <20220420055736.27901-1-jgross@suse.com>
 <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
 <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR02CA0008.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::21) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4d448d1c-3321-4f1b-ea46-08da2296cbfc
X-MS-TrafficTypeDiagnostic: AM6PR04MB4998:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB49980BE2293DB70714BF1AC6B3F59@AM6PR04MB4998.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UQ4Fz2KLveuw2zsG9DqRxOjyK1Fy5tU1goFeK4PdofCRmQO4UZJ4pIdUc0FulOxoDBbNC3A//Vw1QU+1jc2BvDmSEJP3QmHhKm+LhGfHFcc/PwW+1Oh4us2r0Wk2ab9ABqC2uewX8VzZHH/tsWhLxVDoJzKmz1VJNA6DvwiUXLVff3hMRAXh83V1A+QhZzHAi5bjRs9Oq9yY7D34qqsYNsXAwOKA6bvjGsGLzvihf4HCXKXtLOxCoN29Cn13tuM9geF0/5PDlQaWAutCKn5MXGtxMpxGwDjZthrCkYIhiw8RSGWynp1V4RwmzAUymdxU2lALIYu58sQMMZ+IX/mGUd7VuDJcWIWJyzzN913hAzHI5ca5fNgVFxTAAWcYOQOuIvO9CfgDCQrgJyV1sF/5x9Nwp03egqz5ShvVjB/gpIQps8Sgy4+UAiv3vgyVRaOUbesBVBwy/5uHyp0o92ygfXqZEcMp8bVtygkejL/Wcoem8F44ItUJ1QQMkdTcs/bfol0KvgM/ShR9HgHT9MDmBScZjiQlvAB3lahjb/zMzYsGbdgJKLXQQIrC23YhjtGC1skoS1xcpqenuOxS/r4l1Q7st8WhBjAeyl6CprSHhrePbJoleydbse7LDZSe2i3jvNAQNfV14A4B0GH3BpXn9l6iXSS2iPTmOryaMZVWbsB6aIgnHeAIQmXhFv9jEaGaNthlyylCjTVHTNYBsZ4O0R06n6c2XFkEP5x7OXi+AHFKbF8XWT+vqqeze+qbPGWZ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(8936002)(66476007)(38100700002)(6512007)(6486002)(8676002)(26005)(31696002)(4326008)(2616005)(186003)(6636002)(6862004)(54906003)(83380400001)(53546011)(2906002)(36756003)(508600001)(6506007)(7416002)(31686004)(316002)(37006003)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c2QwTGs0Z0ltRE9zQTN6MGdzaDJxZ1pOMkxEZVZidk5PbkdMdWhud21ZOTlR?=
 =?utf-8?B?SUZ6UEhpRVV3RUVENjJnbnRBMngybDlZSkkyTUY1TDNrTmR2QkY0M2k3WTBn?=
 =?utf-8?B?a0JJTVJRczBPNklDbkY5bjM4MjJiakxZcmlsODhpY1BocEIxYWc2bmVRUnBr?=
 =?utf-8?B?SHJucnNVYTRCeGVuZ2Z3THRxbHA1cEVFSkNGUVE0Sno4RGlQZEsySll3cy9L?=
 =?utf-8?B?aUhFY0hRZ3NsaCtZWmFSNjhIa0VLUTVEbEJza2lTaXVvN2MrL3BBT2ZkUU10?=
 =?utf-8?B?K0IycVBXRnpmOFpJM0pPd0NUQjdia203aG56cUV2M2d3NTZXZmNKelhLNyt5?=
 =?utf-8?B?K2IzT1JRbVJ5ZkRQR0VQaENYb2tteGgxdUtEajhqWGVqK1NwcVBFUk5LL1Jw?=
 =?utf-8?B?VHVMZ0JaWnl6aFptM1RVUVFtM2dnTzcrL0U0dUE1bitRcDlwaXRKZC9GT2VN?=
 =?utf-8?B?RGFhODZRV1g4eDNtN0wwTzlsL0RhS0dkb3BUK25uTlFHSGpyUWxXMzNEbzdR?=
 =?utf-8?B?MitQdG1kc1hIdEp3Mk5Bc0htaGd5djUxSTJGbCtSeG5LaDU4TzEyNXJ1NFVD?=
 =?utf-8?B?aTBlQ0hXS000VTM5c1hsejJVZThCZmY4VHB5Q2xwbjlveWVDb1B4UW9DL3l0?=
 =?utf-8?B?NmlyZ0g4TFc5ZHhWWmZJYmU3LzNjYTRzUG5TVVJwTURYczZpaUdLM0sxcGN1?=
 =?utf-8?B?Y0JRVElTTXFZcEtEd055bTVTWTI4L1Q0bWJXRjkxWlplZzhLZUt0TVVsWVcz?=
 =?utf-8?B?dHhZSC9WRVg2U1FjKzdCL3h6QWR1Y3NjTDlVTk1oS0NQSzUyamFtZUtjZ09j?=
 =?utf-8?B?enRDVW9Tb1FMQm9LWHYwM05EckkwMi9LMi9CUERUMDJqYjNWNGYrVzRUem5l?=
 =?utf-8?B?MExMMHpqZHZ4ZWxDM2J6TEdGc3d3eFBnVWJTN0l5Z2VGSG5tRzU1Y0hVK2ZX?=
 =?utf-8?B?b1hQMU9VZE9PQVJIN28rZVZJYkFpUFZSbE1RdVlJeE4xajNvekFQZTlzbDJN?=
 =?utf-8?B?Y2NIb0NISXQ0SnhJTmZ1LzZwVU4yTW1qNkF2UTVXeGhja0dlcytaODM1SEhn?=
 =?utf-8?B?TGRFYlNLKzZpdWc3K0ZQTmN5by9EZzRublE3eGIyM3FzK1dzTU5TamdvaS9w?=
 =?utf-8?B?SFdDTTZLbUZnTlJaWFAwNDNKUWFTeXh3clBEOUxUa3loejZTbVVLWXdZYUJN?=
 =?utf-8?B?M1pZM0RpQkpXK1dKaHpTUTU4NllsTEVIY2ZVa2o3YVhzRGpHMVp6N1dkY2FS?=
 =?utf-8?B?elFBbmM0YXRvUE5ZTWhNWEtXU1Znek15aTkxZzh4YkZ3eGR1OHpaVE5yNXlR?=
 =?utf-8?B?N29CTGRyNk5TVXh0YncrcGdxZTcrMFArL2cxTnhhOGtSYTNUbFJkUkpWdFpU?=
 =?utf-8?B?WVRhSURZbExMYm56SncwSkNGb0tod0podi9PQm9MUGFidUlvL0RseVphaVVM?=
 =?utf-8?B?ODVyc0J1cE9SN0QyVmZ4SEM5dUVoN1hBYXhtcFlSL1Y1YmtsVUdtQk5paWNn?=
 =?utf-8?B?Q1JVcGNUY0pHZFllakxVYkx4YktKL0JydWg2dFdtelBtUERZeGZXUlpGQ2hq?=
 =?utf-8?B?bk9ZbGorc2JQRm1Ea1pRVW1nL1htWFdvYTRHNFkrWmpaV291QmlSSFBLMjVM?=
 =?utf-8?B?Z25ielh5MXF3bTNmdDgySWxabU40eGpCaG9CblJ2cTQ3cGdsR2RVd1J2SU1y?=
 =?utf-8?B?YkdVNXlpTW56MUxqbWRIK3ZoR1grSUpZdGo2b1ZqUmYzdHQ3QkY2L2U5WWln?=
 =?utf-8?B?RzRuZExwL01FMWVQazk5R2RjTXhwR0lGR0ZJNDByOUp3eUp2UFp2cE9NSlg1?=
 =?utf-8?B?Tk5TOGZ1QVBML29zdldCQ3RUNmZZTHlGLzZrUFdiTXpQM2ZPTWtNK3k4R3h2?=
 =?utf-8?B?czV6MHJxbUNwc3JoU2RZVC8rU05aTUhabVo3c04rODFqNGhjK0J5QUZFOU1x?=
 =?utf-8?B?NnUwZlZkV29maW9LRkhrcllRZE5FSkVTZCtnanUyRUxacGd3R3lCUUZuWUZB?=
 =?utf-8?B?MkJZTUJVekNJL3pKR1FNVmF6RUdjdlJhWm1vZzFzRVQwUEJIazR5SHh1TVBJ?=
 =?utf-8?B?ZHN0MUFwdFJBbEtDUm5kdFBxZXBGWkNheTNLcmk4QlN0Tzg1aU45RG9KOVBs?=
 =?utf-8?B?Qm5Rb1lrb3RKbnFhdWFIOHd6S1pRSFlwazZsQzkydEh4R3d5ekZmWE9CdkZR?=
 =?utf-8?B?S21LdjVTN1VZNEJFSSt5bS9xdFFsOUg5dThPTHh6SlBYNlZ4QXR3RGhIMnRY?=
 =?utf-8?B?WkVMSHN0cWhGZTc5YzB1cHFWL2FKYjJZdW4zaEdUd2VseENncEhRcTMxWlRM?=
 =?utf-8?B?RGkvL0I2L3laNm9YY1FJMTJ3VFFqajhkZmhkVVhWY0J2U3pvRTJtZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d448d1c-3321-4f1b-ea46-08da2296cbfc
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 06:27:09.0072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wJ5Nx1XXTosi9uOvoakD6/pl/wtyQpSjjdOf+FJG2Ss2Ff8CeEZ4XRy7oBvn/SotwwD4/cg2enNwgfiPZi+t0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4998

On 20.04.2022 08:22, Juergen Gross wrote:
> On 20.04.22 08:11, Jan Beulich wrote:
>> On 20.04.2022 07:57, Juergen Gross wrote:
>>> --- a/xen/include/xen/iommu.h
>>> +++ b/xen/include/xen/iommu.h
>>> @@ -341,8 +341,17 @@ struct domain_iommu {
>>>   /* Does the IOMMU pagetable need to be kept synchronized with the P2M */
>>>   #ifdef CONFIG_HAS_PASSTHROUGH
>>>   #define need_iommu_pt_sync(d)     (dom_iommu(d)->need_sync)
>>> +
>>> +int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
>>> +                    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
>>>   #else
>>>   #define need_iommu_pt_sync(d)     ({ (void)(d); false; })
>>> +
>>> +static inline int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
>>> +                                  XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>>> +{
>>> +    return -ENOSYS;
>>> +}
>>
>> As said in reply to Andrew as well as in a number or earlier occasions,
>> I firmly think that this wants to be -EOPNOTSUPP, not -ENOSYS. Views
> 
> In libxl there is an explicit check for ENOSYS being returned for
> assigning/deassigning a device, same in the xc python bindings.

Urgh.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:30:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:30:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308866.524731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3qh-0001Ag-Mt; Wed, 20 Apr 2022 06:29:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308866.524731; Wed, 20 Apr 2022 06:29:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3qh-0001AZ-Io; Wed, 20 Apr 2022 06:29:59 +0000
Received: by outflank-mailman (input) for mailman id 308866;
 Wed, 20 Apr 2022 06:29:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh3qg-0001AP-0P; Wed, 20 Apr 2022 06:29:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh3qf-0000OP-Ur; Wed, 20 Apr 2022 06:29:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh3qf-0007O0-GS; Wed, 20 Apr 2022 06:29:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh3qf-00039N-G2; Wed, 20 Apr 2022 06:29:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RO3udWPuUAe4xYI6r4w9LZp39rQI2u4AFvGFbPabLZc=; b=tgI3kgP01XsRSmtvwzMeGiMNyi
	AgQAXo66qfZF0We8DT8x6jGV/898jtbnQUa8B9gpZEE9upOC19V4jxWXl7UbxmFrapi4B/cdMRm/Z
	SBp4Iq/lCspww4oT+xKjCRgZqlmBHbIfkw530W50qvIY72b5y/6rjg8gEuYgFjWUVyz4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169558-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169558: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 06:29:57 +0000

flight 169558 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169558/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  516 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   21 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:30:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:30:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308869.524742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3ql-0001b4-2v; Wed, 20 Apr 2022 06:30:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308869.524742; Wed, 20 Apr 2022 06:30:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3qk-0001aD-Um; Wed, 20 Apr 2022 06:30:02 +0000
Received: by outflank-mailman (input) for mailman id 308869;
 Wed, 20 Apr 2022 06:30:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BWYm=U6=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nh3qi-0001NN-ST
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:30:00 +0000
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4c35c36f-c073-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 08:29:59 +0200 (CEST)
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Apr 2022 23:29:57 -0700
Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84])
 by orsmga007.jf.intel.com with ESMTP; 19 Apr 2022 23:29:56 -0700
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:29:56 -0700
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
 fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:29:55 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 23:29:54 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 19 Apr 2022 23:29:54 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB3500.namprd11.prod.outlook.com (2603:10b6:5:6a::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:29:48 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 06:29:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c35c36f-c073-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650436199; x=1681972199;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=x/eKREl69vllJ+U+bZtwaa2nBis5/VWJXqQ0wKa6d/Q=;
  b=I9EnBP41ORgS6PWoOlZW4WcXW8vY9kp/cm0oIXZKsWHkJxTVwcirZhkF
   LgXHPkjxUKGufgg53RAnchsCUte38lYHFyD3XUubpDDjUT4d4bVdtgbEG
   4TGZfWMwYUfMuXZov1fkeNN7f5QsYKhe/a3zCYOJaBdssR+JxPvilLOa3
   iqfoSuWy0zOlo9hkt2uAOONmf860Xo78YpkJDvWnaNQZS/PKP5SQjHQ3T
   WRdNJM1W6ydGVxkpcmd1fQsXoZvGbuu9I8lRGUlwdZ/YnP5qVUcCK3gWS
   rl6D9fnPtBDWP4WWNeg3MuMxYIBOnKtwUDLV2q5nggJixSijjN5Qu2Jgy
   A==;
X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="243884045"
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="243884045"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="555055201"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hHa0LJOJzQ9FRiX9/Q3taPLNAsKGnFOP/7+m7z3a7MtK+RggbrzU9/lQT6M2dGjw/EBk6cSnRDIywY/+aVO7wIWsX05hrrXyVSGpZbEVhEYrHo5fMe1amxGBCdHYA+G0ZT34rPm7TMifZ8DILiY647uya7OLGc88TcHPOz/izlyVA4LgjB78HzE5/Fdewt/FTkCR+1YccJm3VYfUzMDr0rsrImhGtA2zApmFV+sPY/5LeN+6PgKi3YLFDY7PWk+hayVxn0Er/0dTmXeibti/EH+Rg7sC7B8r/QLpenimpV3DTRVM3LzLFRXPHaWZzvN7SimWon2TTfP7+MrwNGQGXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x/eKREl69vllJ+U+bZtwaa2nBis5/VWJXqQ0wKa6d/Q=;
 b=UntJneeaKgwyoaUf3O5eBN13Bsz3VgCQFeIimwMfISG3Xe8hSvWrLonzdBE5omkGDL60UhQ5DuWGYdvFE/+5uX6WFbioG4nMsj3Xqc2/ss2k/7OiBV+4pi7/+sHysQABEVCzdbkxJE+fttTS7mHN/BSNDR2rKI0IaWOn0Lh6xyX5y05VgnJLGn0dA1xHOhXAkHGRxiHw5TCx0gXWVx1Gb9v+YykPaWLyvvCd9qbGssbPM13GROnIxE87o6gIxm0dcQkUL0OKeqCMDVvsNVTXb57SJg8RmYnP1MO+wIF6eSCQTmplsktEypMnXl4vPhm8nEf+TUmBtLNSpP9XSvhX9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<volodymyr_babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	"Cooper, Andrew" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Thread-Topic: [PATCH 7/8] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Thread-Index: AQHYTYg2fJ9LlsxQzUiWYjlpaUlfRqz4ZOWA
Date: Wed, 20 Apr 2022 06:29:47 +0000
Message-ID: <BN9PR11MB52763455AF804EDA3300CE368CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
In-Reply-To: <452b42cb-56a5-3f28-989f-c02e53334447@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0433be2a-e6c2-4a26-50f6-08da22972ae4
x-ms-traffictypediagnostic: DM6PR11MB3500:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB3500397FD09AB7D691E62BA88CF59@DM6PR11MB3500.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: JYuNqxjpeBfdlPvIbOc+zhN1KtWZWe1ZzB0FDfAR4gezPLcFVkdkdlplyJw4icdEr3whv4iDqAfWA01SbFhMr3G6LcdcTi4s9DD/qWZMFqXpTxGDSE1L8q4lwqh3sj6SILug9+G3IbFYUN2u/7LRVNQxqcUPjopvBXbA++ojSQi1OvYPm/3vYGPmckESoay5EOylRTe3HP7+kEN8OL1yDo5aZcAL1NMhh1iUeskIr1FWlSOqETAYAiyJkomSmX8ulWX9ITQ/aH+yBn7wE9QUPY/bVuDs5sTAF31fQz+Ir+L+sawaC5/WXyKf7FS49IiwEgQGafFJFX+n1RMWrYs1rkMOws6Z3/vtpW5s+BOKRPHQDQIa/6B6yutxJcnXNuo1V02fJQdJcFdQekz4Lq2Tv5E1UhjYodg3vCqb45rkpO0y/Ldlc1aoLetqgnMxzf13kef1LkEVee9r0cgTW/ClehQtIqMLw4MSxdvA8OvwIYZb/gljICNR6xxK5RIUX0Us1I7nBDeMw5fuTU+YtAgGvAm2bo0XHim0sHcSNcmpoxSt9YFO/l4DvGzl66Y3ZRP3PSlO1YGIN5kuRkIhT1Zlr5ZjJ81bwAK04Zk9OpLwJO+hIcdbGFv84Ry/ho//h5ZBFYgVuQn8Wi0pdyEyw/wIKh70cwmoj5RiK4skiZpUNpuIZhR/jXMxhP01UZkl5WTtLBX38V293aj2urGERGfx0g==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(54906003)(2906002)(5660300002)(8936002)(52536014)(7416002)(122000001)(38100700002)(33656002)(38070700005)(7696005)(9686003)(4326008)(8676002)(508600001)(6506007)(76116006)(66946007)(86362001)(64756008)(66446008)(66556008)(26005)(66476007)(110136005)(82960400001)(55016003)(316002)(71200400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aktrcHdiM3grVFNidUdFSUdMT3RIU3hYRmVIWFkyK2JZL0lUSE5qc3ZQZVpC?=
 =?utf-8?B?aEJoSTAzazI0U2tkSjYvTmd5OHFLS1pqNU5ETkxoTmFISDdxSGZnNWh5R2dT?=
 =?utf-8?B?aW1JNi9oUDNuMytOWkVaNnNCTUlzNXZIWTgzTnd4aUswWFdGV29abjVYTTN2?=
 =?utf-8?B?bVEwaTlEOUE5L1U0VlhyL1NIRC9ZNHp5UjdTUVpFYm5yeE5Vc3B2Rk1OWmEx?=
 =?utf-8?B?K1BsdlJlckZVQ0JsYlg3TU54RXhMTFBlVld5TS81eVgrWXBnSXJnVSt4Q3l1?=
 =?utf-8?B?Nml3WTZvR2x4SG5TUStCSUNQV1o1Q0tUTmpZRXdubUVSek9ETDFCVHJWK01S?=
 =?utf-8?B?SXE5aE41UGs2NTloZTFFNC9qWmwzMS9BcjloM1k0aHdmQnI0d0M5Ujdqb1hT?=
 =?utf-8?B?MWVVelBFSi9DZnM1bjVNN3I3LzRSZzU0OW1NOFpURytlMGk1RDQ1MElGVEFR?=
 =?utf-8?B?R3N2UVliSEZSeWoxbWd5YWdjYzVDa2hjekdPcnJ5M0k2NnlHNWx1NmtudEpS?=
 =?utf-8?B?ZHdVQjZTS2JxU3JNbFpZTFNINnBlUWd1YjlPKzcxTk5LZ0hqZVVKRnh3T3Bq?=
 =?utf-8?B?clYzYWV6RkJZRDB6QUhHMXJnOU5hMmF4SHhNRUQ0bjdsaVZwQUw5cC9PT1Fj?=
 =?utf-8?B?aE5tNFhDeE0weUdXUkdVYWI5TS85bnhNeUdrSGJpc0N0MWppRi9sOVNqVVAr?=
 =?utf-8?B?NmRUdzFrSVVYNS9nOGJ3b3RHbnNDako1TzRtOHpuRnJRV2NSUWhnS2poREh4?=
 =?utf-8?B?cEhjRW81ZW5uQm5ITUNpeEQvdWIwM2FROXF0MG41MVpabCtmUG92eGxKYWRi?=
 =?utf-8?B?Z1RCUjc0a2kwck9SWGpNbzkrSjQwcXJhbzlXZ3M0NVFOS2pLUTkyYTVmUW0x?=
 =?utf-8?B?bVpoY0gvRU8wdWU0Q0FuR2Ivc3hYK0c0dG1BSEh4Wkl4bElQeXNpNVI5SFJn?=
 =?utf-8?B?eFZQSXdhcUoyTElQTXlvMURNSVgxcWNZNS96VC9RRU12aFFla1Fjc2xGL3hZ?=
 =?utf-8?B?S252TEdENmFHN3NnSW9waVlwdzVhZkxZalhmMUZvNnYxZnZuMklzbmVPcUx4?=
 =?utf-8?B?aWRUOHRPb25hTDFtelZRMXZZcjFZWUpIWWkvdlNDdzh1MDA0MDRGVjFkcXdt?=
 =?utf-8?B?QjJtZXBwaHJZUzJjZXFURENTbTFsb2pPN1pLcXVvaElFdHlrSGlua0dyTk4v?=
 =?utf-8?B?SVNnK2hqdGQ0QzE3Z2FGeW5uZy84YjlnWkN3endnKzdlN0IwZ1BCd0dvaE1v?=
 =?utf-8?B?Ym5GK3NPYWMvVEtYMXJGS1IySGdGK29GelpqSVVCb3dtcldEdGJWRXJFdFkv?=
 =?utf-8?B?TWN5cUJIb1NMWXV5d2VjN3N6TFRpZkwxK0dFNW5CTEplQTh2WHBWWU1iWHlK?=
 =?utf-8?B?dURFVzlCb3Nyek1aakFYRlBxamlUTUVkdGN0ZjN1T0xJekRCRlpUY1NaNVZx?=
 =?utf-8?B?WjJ3SUFOdDcrYkZmcCtUWktWcytVK2JtSjRmL3Jrd1d3YzFvWDJabUVRY21I?=
 =?utf-8?B?K0x3Tlc0ZkF0QjdhQU40SWh2NmJQdEhTeUFVMWVTVnhpOVdnR29NNHEvT3dx?=
 =?utf-8?B?VEZ1ZUpuNnptTVErUnZ2SU1wQUxqREM1bVkrbkY2SGRITXlqOTNFSXhrM1Rh?=
 =?utf-8?B?d3RKWGw2cERMYUpJVk1ONEFDejQvaXlyOHpZOUc3RTlCTjZTTGhEeU11ekVw?=
 =?utf-8?B?RjZleWpzSFV2OVhIWUhMNi9oMG9jckQzV1J3bzZoMStvTDRDa2ZuSFFQQXFw?=
 =?utf-8?B?cDA5OTcyTHpmcnN4eDhBWTM0WGJHdmVmUVdaTkpYTDFwWWp2a2V6SURHekMz?=
 =?utf-8?B?MDhCYlplR3BLRFg0L05jYVg1S2pkTlAxNlA4cHh1bWVYa1FPc2FlWlo1WGJm?=
 =?utf-8?B?OVpCcmVucVpwYTBwcU1NWmFSZTFtZHRMelpLbUtmcElXV2pBRGNQMm9qY0xk?=
 =?utf-8?B?SFMwMzhielZDQWRvT1lUem9RQVpoV0E3RnhMckRwNjMvcG9Lb29CWmVndy9a?=
 =?utf-8?B?T1JvK293UnpLc3N3aTB6VG5mWDBmYmxncFlQcnZVS2dvQUNVeEYvL09EeDc2?=
 =?utf-8?B?OTYzcm9Rd0tocWJWc2pFcGcyVDl6QWZ6MDZzdzBhZFNtMnBCb3ZCT2FBc1Fq?=
 =?utf-8?B?ZEw4ZWdBQkhnR2tNV2RLb2FtbThUdENIazJZWUtLSisycXgxOWhRUHNxRWFW?=
 =?utf-8?B?dlBMTjRKVzJPZ1RsNW9uNHZERmgxdnQ4Wnp1VFUyNTJha2diSVNXc0N0QTBT?=
 =?utf-8?B?eFIrSG5GTVB2V3A4bVVaTnJHVVMxcmhFRzZtTzRDUkdVSkl3dDFnbW1uQVNq?=
 =?utf-8?B?RlF5eGN4bFJGVmhpS2tLUStNSVJwMkw5a2xucE5udEdWQ2RaNWVYQT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0433be2a-e6c2-4a26-50f6-08da22972ae4
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:29:47.5723
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E+depBxIDDacy1I4zlUU7Ii+XQ+xFb1zqzz9rFnS2ZIUo/r3bFWX8ZkmgSgU+87l1I6vZdpRNddBt0v71Oa3AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3500
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMTEsIDIwMjIgNTo0MCBQTQ0KPiANCj4gVGhlcmUncyBubyBnb29kIHJlYXNvbiB0byB1
c2UgdGhlc2Ugd2hlbiB3ZSBhbHJlYWR5IGhhdmUgYSBwY2lfc2JkZl90DQo+IHR5cGUgb2JqZWN0
IGF2YWlsYWJsZS4gVGhpcyBleHRlbmRzIHRvIHRoZSB1c2Ugb2YgUENJX0JVUygpIGluDQo+IHBj
aV9lY2FtX21hcF9idXMoKSBhcyB3ZWxsLg0KPiANCj4gTm8gY2hhbmdlIHRvIGdlbmVyYXRlZCBj
b2RlICh3aXRoIGdjYzExIGF0IGxlYXN0LCBhbmQgSSBoYXZlIHRvIGFkbWl0DQo+IHRoYXQgSSBk
aWRuJ3QgZXhwZWN0IGNvbXBpbGVycyB0byBuZWNlc3NhcmlseSBiZSBhYmxlIHRvIHNwb3QgdGhl
DQo+IG9wdGltaXphdGlvbiBwb3RlbnRpYWwgb24gdGhlIG9yaWdpbmFsIGNvZGUpLg0KPiANCj4g
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdl
ZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQoNCj4gLS0tDQo+IE5vdGUg
dGhhdCB0aGUgQXJtIGNoYW5nZXMgYXJlICJibGluZCI6IEkgaGF2ZW4ndCBiZWVuIGFibGUgdG8g
c3BvdCBhIHdheQ0KPiB0byBhdCBsZWFzdCBjb21waWxlIHRlc3QgdGhlIGNoYW5nZXMgdGhlcmU7
IHRoZSBjb2RlIGxvb2tzIHRvIGJlDQo+IGVudGlyZWx5IGRlYWQuDQo+IA0KPiAtLS0gYS94ZW4v
YXJjaC9hcm0vcGNpL2VjYW0uYw0KPiArKysgYi94ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYw0KPiBA
QCAtMjgsOCArMjgsNyBAQCB2b2lkIF9faW9tZW0gKnBjaV9lY2FtX21hcF9idXMoc3RydWN0IHBj
DQo+ICAgICAgICAgIGNvbnRhaW5lcl9vZihicmlkZ2UtPm9wcywgY29uc3Qgc3RydWN0IHBjaV9l
Y2FtX29wcywgcGNpX29wcyk7DQo+ICAgICAgdW5zaWduZWQgaW50IGRldmZuX3NoaWZ0ID0gb3Bz
LT5idXNfc2hpZnQgLSA4Ow0KPiAgICAgIHZvaWQgX19pb21lbSAqYmFzZTsNCj4gLQ0KPiAtICAg
IHVuc2lnbmVkIGludCBidXNuID0gUENJX0JVUyhzYmRmLmJkZik7DQo+ICsgICAgdW5zaWduZWQg
aW50IGJ1c24gPSBzYmRmLmJ1czsNCj4gDQo+ICAgICAgaWYgKCBidXNuIDwgY2ZnLT5idXNuX3N0
YXJ0IHx8IGJ1c24gPiBjZmctPmJ1c25fZW5kICkNCj4gICAgICAgICAgcmV0dXJuIE5VTEw7DQo+
IEBAIC0zNyw3ICszNiw3IEBAIHZvaWQgX19pb21lbSAqcGNpX2VjYW1fbWFwX2J1cyhzdHJ1Y3Qg
cGMNCj4gICAgICBidXNuIC09IGNmZy0+YnVzbl9zdGFydDsNCj4gICAgICBiYXNlID0gY2ZnLT53
aW4gKyAoYnVzbiA8PCBvcHMtPmJ1c19zaGlmdCk7DQo+IA0KPiAtICAgIHJldHVybiBiYXNlICsg
KFBDSV9ERVZGTjIoc2JkZi5iZGYpIDw8IGRldmZuX3NoaWZ0KSArIHdoZXJlOw0KPiArICAgIHJl
dHVybiBiYXNlICsgKHNiZGYuZGYgPDwgZGV2Zm5fc2hpZnQpICsgd2hlcmU7DQo+ICB9DQo+IA0K
PiAgYm9vbCBfX2luaXQgcGNpX2VjYW1fbmVlZF9wMm1faHdkb21fbWFwcGluZyhzdHJ1Y3QgZG9t
YWluICpkLA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvbXNpLmMNCj4gKysrIGIveGVuL2FyY2gveDg2
L21zaS5jDQo+IEBAIC04MzksNyArODM5LDcgQEAgc3RhdGljIGludCBtc2l4X2NhcGFiaWxpdHlf
aW5pdChzdHJ1Y3QgcA0KPiAgICAgICAgICAgICAgcGJ1cyA9IGRldi0+aW5mby5waHlzZm4uYnVz
Ow0KPiAgICAgICAgICAgICAgcHNsb3QgPSBQQ0lfU0xPVChkZXYtPmluZm8ucGh5c2ZuLmRldmZu
KTsNCj4gICAgICAgICAgICAgIHBmdW5jID0gUENJX0ZVTkMoZGV2LT5pbmZvLnBoeXNmbi5kZXZm
bik7DQo+IC0gICAgICAgICAgICB2ZiA9IFBDSV9CREYyKGRldi0+YnVzLCBkZXYtPmRldmZuKTsN
Cj4gKyAgICAgICAgICAgIHZmID0gZGV2LT5zYmRmLmJkZjsNCj4gICAgICAgICAgfQ0KPiANCj4g
ICAgICAgICAgdGFibGVfcGFkZHIgPSByZWFkX3BjaV9tZW1fYmFyKHNlZywgcGJ1cywgcHNsb3Qs
IHBmdW5jLCBiaXIsIHZmKTsNCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL3Fp
bnZhbC5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xaW52YWwuYw0KPiBA
QCAtMjY3LDcgKzI2Nyw3IEBAIGludCBxaW52YWxfZGV2aWNlX2lvdGxiX3N5bmMoc3RydWN0IHZ0
ZF8NCj4gICAgICBxaW52YWxfZW50cnktPnEuZGV2X2lvdGxiX2ludl9kc2MubG8ucmVzXzEgPSAw
Ow0KPiAgICAgIHFpbnZhbF9lbnRyeS0+cS5kZXZfaW90bGJfaW52X2RzYy5sby5tYXhfaW52c19w
ZW5kID0gcGRldi0NCj4gPmF0cy5xdWV1ZV9kZXB0aDsNCj4gICAgICBxaW52YWxfZW50cnktPnEu
ZGV2X2lvdGxiX2ludl9kc2MubG8ucmVzXzIgPSAwOw0KPiAtICAgIHFpbnZhbF9lbnRyeS0+cS5k
ZXZfaW90bGJfaW52X2RzYy5sby5zaWQgPSBQQ0lfQkRGMihwZGV2LT5idXMsIHBkZXYtDQo+ID5k
ZXZmbik7DQo+ICsgICAgcWludmFsX2VudHJ5LT5xLmRldl9pb3RsYl9pbnZfZHNjLmxvLnNpZCA9
IHBkZXYtPnNiZGYuYmRmOw0KPiAgICAgIHFpbnZhbF9lbnRyeS0+cS5kZXZfaW90bGJfaW52X2Rz
Yy5sby5yZXNfMyA9IDA7DQo+IA0KPiAgICAgIHFpbnZhbF9lbnRyeS0+cS5kZXZfaW90bGJfaW52
X2RzYy5oaS5zaXplID0gc2l6ZTsNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:34:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:34:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308880.524753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3v5-0003NU-LU; Wed, 20 Apr 2022 06:34:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308880.524753; Wed, 20 Apr 2022 06:34:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3v5-0003NN-Hu; Wed, 20 Apr 2022 06:34:31 +0000
Received: by outflank-mailman (input) for mailman id 308880;
 Wed, 20 Apr 2022 06:34:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh3v4-0003NH-TC
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:34:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee456b72-c073-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 08:34:29 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-dI7dYchyNDOg793RUVKpsg-1; Wed, 20 Apr 2022 08:34:25 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0402MB3356.eurprd04.prod.outlook.com (2603:10a6:7:8a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:34:22 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 06:34:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee456b72-c073-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650436469;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MWFDDgg8Nbqzjp77dd7JQVOZiKBHZONaRwwGPMrVjrg=;
	b=Y/SXI/YoETtnguY+cY01g/s4+ymh2l3eYbEb+M14J3hwzzwWgPOcQFYo1wJsKWU2bhRbQT
	v63IId/j/nGXu8do16sWbAFs+3xQQ/3XVPwFlZWs8RxdKYqsRojg1nsEfH+4N84fKolS8R
	UMVELud643CiK3Pj3SHZpKAW+lALFAY=
X-MC-Unique: dI7dYchyNDOg793RUVKpsg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q5/MWbeK6TRJSMFnPjAE8QyR4iwHyitTOKNAYAOSudOyybkfsF6w4bv4r0tunM6RK/23RUGPo3dOb8GzhB4m1wOnJhTrRVFbx87ZNktwap+xHQvVTspaJLyFT1V4PxsNu0e1yCvHfvQ42yQAmWZD700yeZSmfnswhA9MsfOcxMg3FNfQP4A1f0J3xYLr5/i3Uu4H/V1vDafJgrflRKiCfCuL9KAqFNpH6c7ax8oEaiRMGlSepcCfQ2259rPJwHdLi2cDAem6C9LZXNzJxXeezDOurx5usLcvYzN7Kz0ZYw+BcZiQgyUbvrshScxHkRuPlzvHTu+cpQxF+srI9LiI/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MWFDDgg8Nbqzjp77dd7JQVOZiKBHZONaRwwGPMrVjrg=;
 b=a8q6rZSqHJwF7lxhbafe41OaOh+dw6iJt+TudD1tYY7xBw335o59xbJDQLuzEubJ2mfv7aGttSpXqYqnS0IAX8uKa5eDPYCuU91uCKr1LZvhp3niPFKfPfJQgsAow32cfjIwHXWx0cwgL01p3YriqEdrzI6psMVFhOlQvRZrDOrG2OFc/EejFDRPoZpgjd6oMvc38iZ9p/q/ay/RPvYK69Q0nZiRkJajuOm+1+SSygjj2zVi9j48y0AtbHWMoYwPb6oVB0xjQmB56WjiAIY7VfUYuSjuCak1KO2JIKBt0cCg37vNwxBDgDH+6uiCMeKjS9D+Znu/p6THLpfJ4sGiog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e7f51753-a113-086a-16d6-a334095dfee0@suse.com>
Date: Wed, 20 Apr 2022 08:34:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1] x86/mm: avoid inadvertently degrading a TLB flush to
 local only
Content-Language: en-US
To: David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, David Vrabel <dvrabel@amazon.co.uk>,
 xen-devel@lists.xenproject.org
References: <20220419150320.64783-1-dvrabel@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220419150320.64783-1-dvrabel@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0049.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 32075c38-4289-424a-de1d-08da2297ce69
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3356:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB33566E07D25C9EDD65CDF314B3F59@HE1PR0402MB3356.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	L5Z3k4TAA8wYq7AwKtPMLBg2l1p/3b0pLhcX4Asv+v616bjlF3lu6i2f8O/DzlCD1Avg82MSAfnLyPxn9Omh5JsnAp39qnuBwkUI+NRty8zT9WiAwKX2nRdRBHhY/grzWSZEy5jIPH0qVJJV0awoSyKJJFsMj5DoEJO39a5xNWPKunuYralAQt3VbwmjJgljizkHs/M9qCniSlCPKhsiUFRQWjhGBEuRwbb3FTX9zVCkQjH/nYbdN4Z/YGo5X1vaVNUaOa0Bk9EUiFhMS0WhWO8ErQDKb2b7J4pkPgcNwB0nXr+MB5+GlymV5M1afGwjB5BsNDwM1cDk59NIHtspfa8Q3hJJX4gy5TvzjHtc5qbYTkHFguD83thj2BI/8EbBABisubauErCEX/JlA3MeRUW248bFWyX1fJ7/QHr0GbdO8YxkDBeN5IY/Ff6aTBrgijGnZubF4UWIthb75HFSbVb8t5Ez+rRWE9BaRrvgMgPHhMM1ekCmL4ZeuxVvseQgFL7hTZVlV/OxIz6ke4FmOOXNgK8N/4Okd+7aPTbxRwk7C2vqwPi67i4ua0QfWy2zJeib5GLuh6aKQKoOUHg9HAhUBZbQyvYrCP+iCiIaq3e5z9qBx95Eq8e2BmXXlo10mZbEnhWt9qaNdAx/KclR/H4ClDF6D2BQsXlQEADI19q1tNpjK1dqvVmZwl03LVBxQ6bwAcBE4oWMwiJiuMmVk2D6rSBdZsNuLBwI0dXHrLBoIPLTTUFshKDCu8mR9Pc2
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(26005)(2616005)(186003)(86362001)(38100700002)(31696002)(66476007)(66556008)(5660300002)(66946007)(4326008)(8676002)(83380400001)(31686004)(54906003)(8936002)(6916009)(53546011)(2906002)(6506007)(316002)(6512007)(508600001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dXQ3TVZkZTN5VHVpekhNdjJML3d0RExLTDY2L1dKSDBLTTVVTGMwN1BlME9X?=
 =?utf-8?B?emZWSnVMM0dYcDc0WXZwSFgxZG9wSG1mdFZIVmFYSG5RcXFvNlZyOXNVTXYy?=
 =?utf-8?B?ZWZwa296NGpSa3Q0ZkVkbEpmWjZCNm9YZlUvc3lacDYrcnVpSkhMZ2xwaHFP?=
 =?utf-8?B?c1g3VlBDRnVTOGpudmVkMjQ4OVNDNndJeWo2SmpCRlVxL2NWWTA4NnZ2YWpK?=
 =?utf-8?B?ZXpPQjFoK2MvY3NpOVh4VEpTN2NpUnNha1FJa2wyWnRZVExieDhKNng3NmNa?=
 =?utf-8?B?MnZIZElVaU5xODBKUlBBWFdsRE14QlBMdUtBMGF6NjgvZC9WMmUwNzJsbkZN?=
 =?utf-8?B?dGpicklxQ3pGWnY5c2xEK3FCU1o5S3h2SnNnQVlnRjZhWjIzZmFJenpLZTlw?=
 =?utf-8?B?U2xMdVNscTQvS2RuNVk5UWJoVFpsMUpna3hOekZ1ckx4SWIralA2Y1lyN09V?=
 =?utf-8?B?VG9jVnZ6UTdBMHl1UEdWUVhHTEdVUmtQYkl1TVpVSi9YWFZneWVHYVhTbVBF?=
 =?utf-8?B?a0lTK2t0VWEwVWRtOVJvQTZzaUN1dkJLanFoQXR2NS9Kb2FjVUYvUElwRHhF?=
 =?utf-8?B?TENDMXJodXVjcFlFN3JXOFZxTklYUW9UeDN4MHhSL0xhWkNyZk5ZUlJpdW5j?=
 =?utf-8?B?RTE3TE1IaGNjRjdac3U2anZ2TG9SS1BIQnFOSkZza2prSjFZUGJsdER3QTg2?=
 =?utf-8?B?bjh3WE9wYzhLY1FGNEJXaVlKU2IyY3hYd2xuQ0RGeVNkNUQ4ak1CZjcwVlB0?=
 =?utf-8?B?dC9UUldKYWxCc3lweHNWR3RzY2FYbkt3YThPVlBFclVWYlBoR2o2VTBnNWZH?=
 =?utf-8?B?YjVzWWxkZmdMYzRKQXcyTEhlL3RmN1pNU2MwaDRGc1B1a2J2TEF2RWxyVVQx?=
 =?utf-8?B?dFUyalFoTng1VG53eVBRcHJKOExLMklpSFpJdHE5UnpudWJtcVM1enRRc3V1?=
 =?utf-8?B?TDhmNUt5SkNpamRMY0hYQW5mbG9JTVpNeFNSTXJGZ3VXVVo0Yi85U2c0ajRq?=
 =?utf-8?B?eE95Qml1NEJGZEdHd3c4TjI1SlVOZXZxT0padGg2ZzJqeUpxSmtEejRnTGF4?=
 =?utf-8?B?TStJNkxCWnpyNHc1UUdvdE1xUGloV1FnNmplZ1lDQi93dnhiekJaU3phcHhT?=
 =?utf-8?B?Q3Y3TE5SOFN0bzJsZ1J3RVEyNmtsdkV6QkdHMEg1NmFWdnIyZDZiMU8wZW1m?=
 =?utf-8?B?U2luZkFVQmxwaWhxcG5tY1B1QkhUc1ZUQ0hrRWJkTXdvenBqSjJGaHk5Q0Y3?=
 =?utf-8?B?YU5MSFh0MmFsZjRSUlFTZGdoVUYxdnM4V3pSWTZJcXR6Z3JlVjdLYTVFL0Vw?=
 =?utf-8?B?eGxTS0FIZFc2VG1nVUJiampLR0V2T1lEbWdTRkVKK2ZLait4aVp0Ym9xaXhH?=
 =?utf-8?B?cjZOYVZxV2d1dkgwaC9uNXQrQUt6RVFwaks0QXZoSWlWL0NTSUJuMnQwRXhT?=
 =?utf-8?B?VWVmeUllVEUrVXZ4SnZGbTUzSWNQL2xWZldUb3d0R1FNSkp2aXNnWVpoOEpz?=
 =?utf-8?B?ZUZmYWdhaTB4NGdNREVWbVNQNml5bDNSUHZLTFRKbkFmMnN2dUxEbEtDZVJ5?=
 =?utf-8?B?SERGUzNEUi8yRHZNNm5PS1lRUDJmTnJlbE5mOXNURGtDNFNQTUliTkFPZ29a?=
 =?utf-8?B?N09WRThMZ3JVT25sOUdBeDRxWnJRcHdPUVJ4UVZHZTJTMkhvR2JVZUFRbTVk?=
 =?utf-8?B?RlUyQ0ZBbkFGWEJEUTdXTWI4TWVLM1c3WHg1dFNlTXp5R0xRQWZSVW0vOUh6?=
 =?utf-8?B?WFh4bEp1dEZRSzduSjJJTFV3Y0VudGxxOUo5NEVvOW9jWS90ZExMWW1QampN?=
 =?utf-8?B?S2U1QnU4OFI0b2l2N1RMKzRheXhrMWtURHlzTk80TGR1dENONHlsMWhhbUNj?=
 =?utf-8?B?S2RMdFJrNGdQOFprSGoweC8wOUkzZFNnYmZHNFdXd3BkVWFtSzJNWWZ1OUt1?=
 =?utf-8?B?NGVoT005YW84eU9SUVZ6RnZ4dERMYnJQNFR0VXRNdFl4N0IvTktSU1RlZ1Vn?=
 =?utf-8?B?cUNMOHl6NGJLLzJZQVluNnNPVHl6Q21uWnFrK0lNU0w1ajdwNWxrTE0yNklu?=
 =?utf-8?B?MGY5TlQvbFQxZDhHV0hNajZMZ2ZFK3hjQzM4RVl0S2JzRmZCZWZsWU8vWGRF?=
 =?utf-8?B?RHp4TEN4TlVHK0cvMGgyRWt2d2RXTWhuZTAyNEthTWVwd1RtUFdMS1RwNjBI?=
 =?utf-8?B?UVhoTnZXcTZ0V2VMYW5UTTgwb0lPQVY0Sm8zTkNkZEFLWkNwTXdqYjBFOUhX?=
 =?utf-8?B?Q0Z3RkxFZ1BYRi9BV0ZiSjJldjRHcHFjZFNNT1R5N3Axanl5Q0FRQ2g4eXYw?=
 =?utf-8?B?RitkUm43NnlKWklLcFU0NHc0UiszTGZaT3B1OEhNdldFWHU0SnFJUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32075c38-4289-424a-de1d-08da2297ce69
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 06:34:22.6359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zng3WHmqrmm08/BvAXXV8tqbnch5Jd8Fa6jt6KgBRbGb8AvrINIAufgM/ASxKSj6dBR/s7GZ+be43EabSLz/8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3356

On 19.04.2022 17:03, David Vrabel wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -5071,11 +5071,10 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v)
>  #define lNf_to_l1f(f) (((f) & _PAGE_PRESENT) ? ((f) & ~_PAGE_PSE) : (f))
>  
>  /*
> - * map_pages_to_xen() can be called with interrupts disabled during
> - * early bootstrap. In this case it is safe to use flush_area_local()
> - * and avoid locking because only the local CPU is online.
> + * map_pages_to_xen() can be called early in boot before any other
> + * CPUs are online. Use flush_area_local() in this case.
>   */
> -#define flush_area(v,f) (!local_irq_is_enabled() ?              \
> +#define flush_area(v,f) (system_state < SYS_STATE_smp_boot ?    \
>                           flush_area_local((const void *)v, f) : \
>                           flush_area_all((const void *)v, f))
>  

I agree with the change, but I wonder whether it wouldn't better be
accompanied by an assertion proving that IRQs are enabled. But wait -
flush_area_mask() has such an assertion, so all is fine.

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:37:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:37:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308885.524764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3xp-00040T-4n; Wed, 20 Apr 2022 06:37:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308885.524764; Wed, 20 Apr 2022 06:37:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh3xp-00040M-10; Wed, 20 Apr 2022 06:37:21 +0000
Received: by outflank-mailman (input) for mailman id 308885;
 Wed, 20 Apr 2022 06:37:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BWYm=U6=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nh3xo-00040G-2m
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:37:20 +0000
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 513cb210-c074-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 08:37:16 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Apr 2022 23:37:14 -0700
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
 by orsmga005.jf.intel.com with ESMTP; 19 Apr 2022 23:37:14 -0700
Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:37:14 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 23:37:14 -0700
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 19 Apr 2022 23:37:10 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB4690.namprd11.prod.outlook.com (2603:10b6:5:2ae::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 06:37:08 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 06:37:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 513cb210-c074-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650436636; x=1681972636;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=tkJxq3Ag1oEVaAvqqbCwKyYS48EMeWk1sPuYmDm6b9I=;
  b=DtZSuTeU0uHgabzHGWFdf2hwtAmJoo40fWeIoW+KBNHksOD44AWLZqnD
   9a6TiBo357ZXqi6/b+ZkG6trfxhh62UJ/GmwY0wRpHS0fIxDMoTxc//4n
   0IJlRXjhleLwLZoU9FkNZ0+Ud3NRLCiFnFy0dLPlSr6UhA8jNkSTQ1/fN
   qrYbJV92rSAM/5mHz+E5LZwESxPYirpN0oOvpgI51RWBKQG1Pqm+sUmHn
   kL9pKedmrkPRJ6+GKb1sle2YG2rD3fqQRSkMluunY0W76RNrFpJxYZy2B
   lzXPJM4F5gRZn5Z4A+iXVGtekjS6/oD5IG/zU5PMAEPJW/0+BHL34O7o5
   w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="251260471"
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="251260471"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="727362858"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iLxPl9lO6ftXjKC1NgcP9h24/TVY+9UkEByj5xebJAn/t4UKnkRsjzy4ODpfIjEsRtT/jQucvOL1nbG5O89FSddac9PUNeYVS4y8ueUGGYclntVM+RgadyRPtJRvQgV7ZP5Qp3WfeHBOIfCCqzWS6pus/YEt8qOkIWMNXeMQqcfptkB0qvTmdDxZFtfzacXy0w0FaDVoUJShmPpC970xH1uS6/78hW3EdZ+RQNLV0yJ3DlDEp0bR3GNrK4F58kgdC+uxCT+MqKpk8VZEvZD/Hs4Te0VRFYUPQleE40+e6IqZ2O0g8vkQCJxOO7YtemoykRcAzRAQA+anZVBTiHQDlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tkJxq3Ag1oEVaAvqqbCwKyYS48EMeWk1sPuYmDm6b9I=;
 b=AGUs5k8Zddth/lfNOehovTH5l4wxOBnAA+v1cmrAiezRKrsh/Z6KOFVlNC8MbdrtBUDgmeskNgBOQKnQozzmSlahqrnlBXOzfiqJnY7793MwwSlTKFgdEGNRlXRk4UxJexi9rPI+UYd7uB/Pwxjv7sp0wKM1Lq1b+1vp6UQeG2z5/XxGZzlPzaYmmMyFDojJ4zYSu4MrQASSMmgkhVHFGsbJiU/OC/Q8xVDiNY6rbYOQ3Ra/gLOvYTF+JQlvjc3VXdDsSEwtN2huD88iBqWEgM9yhfNX9NUu1q2kNzqpVZBJU5V5pYaSIzwBQ0oUcVTsP1DjvcE2UJbxIf/k3Kf92w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>, "Cooper,
 Andrew" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: RE: [PATCH 8/8] PCI: replace "secondary" flavors of
 PCI_{DEVFN,BDF,SBDF}()
Thread-Topic: [PATCH 8/8] PCI: replace "secondary" flavors of
 PCI_{DEVFN,BDF,SBDF}()
Thread-Index: AQHYTYhxZGB8O9/qvEu23o6Hmc8j1Kz4Zs9A
Date: Wed, 20 Apr 2022 06:37:07 +0000
Message-ID: <BN9PR11MB52762DD4BC3855422AD3344D8CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com>
 <75623ef8-5aa1-b864-7398-b7980accaf32@suse.com>
In-Reply-To: <75623ef8-5aa1-b864-7398-b7980accaf32@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b14a7fc7-20d6-4e8b-3c69-08da22983109
x-ms-traffictypediagnostic: DM6PR11MB4690:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB4690F91F5DFB71577AF20F9B8CF59@DM6PR11MB4690.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Y6FojNsFo4fujO156SzQqLaVN4Tnx8M1h075uv5segMOBoBvi3BZ/AgFktb+NBZcottgEPTJyM2yg187j/m6So0h+WnPhwpXcC+huI/L85aEj4ubDmovg/7woB7BYMkzFarTi7I5uCelqZaLmdJ68hJRk3ovQ3dDV53uHw8gcRqud9mt03uNrf6NVvO2wt9dH3BznABqkzlQRhJBDGRl0LOsAJrfOVsYFiGYYRs96Q5d1wwFCcPj9mWsanOi0jbkOrmSoHpER/thbYv6g2v/7NErOQioLUoAwDwqW07a0yad3383kxWDD5ri6FpUnjMx+HKdvGBehtHa82g+Nnel6sAYZPG3WMQKYIA/P0FdRVLpxuR1Qswd7bfhhavB4qhvxRpKn7xsVuAy5Rhzh3xREnVfKOn+6wChMOFACD3WD6T6NKI5Nc4rjr51Zh0tghWzb0mOSNf53HL/2dX9cj1GD/GokOFApFP9cFTlBzkdgqJWwvYflSfUfvh+2+GVPadZEDyZ6blTIY3Rxwuy39bHJSJvjKapSGiGNJ+l1UOaMBi3qAT+JzQLmt5YIFYBSYObMvXYRdgbW7kbSfmrF/v68jl806t33QIbfNYm3GJfdylOQTJMAUt1s8JDfFix3Dzsf8L6aDV5Po4lV03bCzEDIKY7R10phXZ3Ctwl6E6gA1Wm4MWNnqxZX/zqAtsfejjbmL7LWJTA3hQk8vmX/7B9DZvkZaFEVer6Tc0v+qDMId0=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(64756008)(66446008)(66476007)(66556008)(8676002)(66946007)(4326008)(9686003)(76116006)(83380400001)(7696005)(71200400001)(26005)(508600001)(6506007)(33656002)(316002)(186003)(52536014)(122000001)(8936002)(54906003)(2906002)(86362001)(82960400001)(5660300002)(55016003)(110136005)(38070700005)(30864003)(38100700002)(579004)(559001)(309714004);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ODZKNDZuQXkyd2JXV0VRaG9RVWUxaXg2NURLd0YvdUtEaFFYYTZvU3piTVBS?=
 =?utf-8?B?a3VVeGZkbjlCSGVGSGtzUldpclJ6MVpNNUFtYm9lT1RhbDdSTzlMYXpabzBm?=
 =?utf-8?B?TzQxOG5mSE1jVWx0dENQL25VR0EzZDdxdnlzMGRrQzBTZXhYVU5MR2phN3dL?=
 =?utf-8?B?d1pKNS9PcUFHTDV4UzBSdExkTmdGUnBFbEM5RlptRXo2dk5Gd25RbC9UUVNT?=
 =?utf-8?B?N1BmQitQVFpYM0lIUldLb3owRGVoRXpJejdnTDRwVGYxeG5ZdlgwbVhsRHEr?=
 =?utf-8?B?U21sZ3lvdkNWUlVTSGVsWlUvZ3ZJZitJa0NDcUNkZFd3bUZ2anY2YTJHaGtJ?=
 =?utf-8?B?cWZSTjhNdHhreDJWRG5JMi9nVzVya0xBOGEwZ2thd1pMNkZIOFM4ZHl2dFZZ?=
 =?utf-8?B?d3dQU0dHd2didW4zdk1oN3lWVjJ3V2dOMy94R3dyZEYrVEM5MGh0cUNyS2ts?=
 =?utf-8?B?WmJvYk8xRHU2RlJiN3FWeVNlblBGK0hXZjNLQVVMMDU5bWVlNWdSdGdvaDdk?=
 =?utf-8?B?ZFNCY2NyVmh5d2lJU3NTVmxWVTZPWGRpMXFxMlk1c3NkM3M1S3JJeHBpRmkx?=
 =?utf-8?B?bTVvU0xqWitZZEp5UFVUdDh4NVl3Nzd0d0JXN1VBYTNrRys1L0ZaS2xRd2FQ?=
 =?utf-8?B?VCtsbXZoM0ZRZTFiQUFSS2FWN2tWZU9ORXNGU1RMTGIyb0hjLzF2UFl5K3lM?=
 =?utf-8?B?Qno2MitVRVIwRGdWR2F1U1pyc3oyeks2aTZSdWZLcEhxajRzaUMzc2p4dCtj?=
 =?utf-8?B?L1psa3BrbERsMjVmQVV2RUlobVFYOE16K3l0VUZNRUZrMWUxckwyaGVRbVRU?=
 =?utf-8?B?Z1hDNk54YUVTbVNZNjRtemlmSVVUc0NsK3RHVi9zNzFHbDFkOUl0TVZNR0Vh?=
 =?utf-8?B?aW94VkhBQXFabGFhWFZrYzdyNGlDV1pCeE9WV3pEdW5yRUFPUGxTVTFOUnRu?=
 =?utf-8?B?N0JRZk5uNlZtSE9IellENVFadkRuRXhTRXZCajliTEU5MHZQakRkdE4xT0p4?=
 =?utf-8?B?TENwdjFzRkExMVBqZ1VFM2NrQWdhYVNRZHZPeVVsZkxrOEJrZnk2ODVlRksv?=
 =?utf-8?B?bVU3VkJmYS9wQnRMUTBDZENUNU1zZEVGbE01YVNUMzc1blNaV0NvTm4zL1E2?=
 =?utf-8?B?dE41R25GMjFMNmRPdkU5MmRsdlpKZ1lJZXRnc3VoRlVlMnR5M0NscENjVm51?=
 =?utf-8?B?S3YwSWI2S0pPcks2cWxkMTkxV3BMMVdmNjB4VnE3OWtRUWNoQklQbVlncVpG?=
 =?utf-8?B?SnNES1FwUUJuckJKcUZrLzR1N0g1V2h0VWU3YWVveUY0czZaR0dYV3NuRGNu?=
 =?utf-8?B?WjkwYzcxTVBMWFNwNC9wdEIrVU1BSUw1TEJjcGc1OEgxWnBRVW9QTWNhcXJl?=
 =?utf-8?B?VjloTndmdWxka2tPL1ZoWWtLcmF3WmttaGVPVjhVVDR5dXZZYUR6bDMzWjN4?=
 =?utf-8?B?NDcvajNlZUQweUpxTm1ReFB5a0RFdW1qNWlXOHNUaFlXYUpWL3hseWxidy8z?=
 =?utf-8?B?VGMzeGN2MHhDRTY3WmU3Qk1iUU9PT28rUUhvcDdGMnc1UlgxQ0hvQkxQNkho?=
 =?utf-8?B?cmxDeC9WQTRhdGlPeDg2K3JTL3g0R2NyUE0vR01qamxSL3Z3anM4OUhLb0pL?=
 =?utf-8?B?U1YyV24xSjdzcW5WTW9SS3NCc2Q3RjhDa2ExbC84QXFOWWpCL3RFOTNFZFdu?=
 =?utf-8?B?U2I2dUswUEZqVVlvNStwVlg4UzVZVk5VVjZMU1BmU0tqOW5KU3VtUEUzM3Fu?=
 =?utf-8?B?S0dwM0piT3dxNk14U21ma0g2R0pGejRTTm56YWpDWlNSRFp1cUpldWViOHBl?=
 =?utf-8?B?aXdTUmt5UCtJdTVneFpmT2NqMk5HSDhNR0t5K1lNR1JiZDZRRzA0NENqZWxn?=
 =?utf-8?B?dTJTa0MvTVNBRjlQblNBR3hUbHlkVEx3dks4RlN5TjdLS2RXdzVLaVQvc2pB?=
 =?utf-8?B?c2hyMXFXakNPUjBYQUJ1RlVwM0hZNVNCd0xqM2I4UjFtd25oYVBWaXdTZHJZ?=
 =?utf-8?B?QXlWbUJXczB0Q2tPakhOZDJneWEyL3MrMDdQZkNJOHFHZ0VwamlEUWtlV2Uv?=
 =?utf-8?B?NHRMNzR0UEFxRE1LQm5DZ1RxUHl2K3NidGIyZDNGdThGWEJXa1k2d05vWW5W?=
 =?utf-8?B?ajgzVWpFelcvSDd4VEVtbDVyaWk1Qy9tM210MUhTNGtEdXFUMUllUU9uS2ZN?=
 =?utf-8?B?WFpBdWMzRDFDZHp0WkUybXNITEhzTnV6OXl5cjlIY1BhRTNPTkgzM3JZZ1kz?=
 =?utf-8?B?dmZiTXRqV1B2eVFxaG9lVDRVcnp6Q0hUYjRqbFZrbkFDRUlNYXowblo1aGht?=
 =?utf-8?B?eVpMc293em1HTHR2RS9xZ1hldmQ1dzZjWGx4OENMdkNwb21BaytpUT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b14a7fc7-20d6-4e8b-3c69-08da22983109
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:37:07.8002
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ovWRrRklj9j2OOqWERXmp9LNfjp8UhVxRnuA4LxwM4m/KicyBcuIrp9D+uTu+jABnYgTyQ0hZcIeX+neCs0ogA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4690
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMTEsIDIwMjIgNTo0MiBQTQ0KPiANCj4gQXQgdGhlaXIgdXNlIHNpdGVzIHRoZSBudW1l
cmljIHN1ZmZpeGVzIGFyZSBhdCBsZWFzdCBvZGQgdG8gcmVhZCwgZmlyc3QNCj4gYW5kIGZvcmVt
b3N0IGZvciBQQ0lfREVWRk4yKCkgd2hlcmUgdGhlIHN1ZmZpeCBkb2Vzbid0IGV2ZW4gbWF0Y2gg
dGhlDQo+IG51bWJlciBvZiBhcmd1bWVudHMuIE1ha2UgdXNlIG9mIGNvdW50X2FyZ3MoKSBzdWNo
IHRoYXQgYSBzaW5nbGUgZmxhdm9yDQo+IGVhY2ggc3VmZmljZXMgKGxlYXZpbmcgYXNpZGUgaGVs
cGVyIG1hY3Jvcywgd2hpY2ggYXJlbid0IHN1cHBvc2VkIHRvIGJlDQo+IHVzZWQgZnJvbSB0aGUg
b3V0c2lkZSkuDQo+IA0KPiBJbiBwYXJzZV9wcHJfbG9nX2VudHJ5KCkgdGFrZSB0aGUgb3Bwb3J0
dW5pdHkgYW5kIGRyb3AgdHdvIGxvY2FsDQo+IHZhcmlhYmxlcyBhbmQgY29udmVydCBhbiBhc3Np
Z25tZW50IHRvIGFuIGluaXRpYWxpemVyLg0KPiANCj4gSW4gVlQtZCBjb2RlIGZvbGQgYSBudW1i
ZXIgb2YgYnVzK2RldmZuIGNvbXBhcmlzb24gcGFpcnMgaW50byBhIHNpbmdsZQ0KPiBCREYgY29t
cGFyaXNvbi4NCj4gDQo+IE5vIGNoYW5nZSB0byBnZW5lcmF0ZWQgY29kZSBmb3IgdGhlIHZhc3Qg
bWFqb3JpdHkgb2YgdGhlIGFkanVzdG1lbnRzLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2
aW4udGlhbkBpbnRlbC5jb20+DQoNCj4gDQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS5jDQo+ICsr
KyBiL3hlbi9hcmNoL3g4Ni9tbS5jDQo+IEBAIC00OTAyLDcgKzQ5MDIsNyBAQCBpbnQgY2ZfY2hl
Y2sgbW1jZmdfaW50ZXJjZXB0X3dyaXRlKA0KPiAgICAgIGlmICggcGNpX2NvbmZfd3JpdGVfaW50
ZXJjZXB0KG1taW9fY3R4dC0+c2VnLCBtbWlvX2N0eHQtPmJkZiwNCj4gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBvZmZzZXQsIGJ5dGVzLCBwX2RhdGEpID49IDAgKQ0KPiAgICAg
ICAgICBwY2lfbW1jZmdfd3JpdGUobW1pb19jdHh0LT5zZWcsIFBDSV9CVVMobW1pb19jdHh0LT5i
ZGYpLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgUENJX0RFVkZOMihtbWlvX2N0eHQtPmJk
ZiksIG9mZnNldCwgYnl0ZXMsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfREVWRk4o
bW1pb19jdHh0LT5iZGYpLCBvZmZzZXQsIGJ5dGVzLA0KPiAgICAgICAgICAgICAgICAgICAgICAg
ICAgKih1aW50MzJfdCAqKXBfZGF0YSk7DQo+IA0KPiAgICAgIHJldHVybiBYODZFTVVMX09LQVk7
DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9wY2kuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvcGNpLmMN
Cj4gQEAgLTkwLDcgKzkwLDcgQEAgaW50IHBjaV9jb25mX3dyaXRlX2ludGVyY2VwdCh1bnNpZ25l
ZCBpbg0KPiANCj4gICAgICBwY2lkZXZzX2xvY2soKTsNCj4gDQo+IC0gICAgcGRldiA9IHBjaV9n
ZXRfcGRldihzZWcsIFBDSV9CVVMoYmRmKSwgUENJX0RFVkZOMihiZGYpKTsNCj4gKyAgICBwZGV2
ID0gcGNpX2dldF9wZGV2KHNlZywgUENJX0JVUyhiZGYpLCBQQ0lfREVWRk4oYmRmKSk7DQo+ICAg
ICAgaWYgKCBwZGV2ICkNCj4gICAgICAgICAgcmMgPSBwY2lfbXNpX2NvbmZfd3JpdGVfaW50ZXJj
ZXB0KHBkZXYsIHJlZywgc2l6ZSwgZGF0YSk7DQo+IA0KPiAtLS0gYS94ZW4vYXJjaC94ODYveDg2
XzY0L21tY29uZmlnLXNoYXJlZC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni94ODZfNjQvbW1jb25m
aWctc2hhcmVkLmMNCj4gQEAgLTMxMyw3ICszMTMsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBwY2lf
bW1jZmdfY2hlY2tfaG9zdGJyDQo+ICAgICAgZm9yIChpID0gMDsgIW5hbWUgJiYgaSA8IEFSUkFZ
X1NJWkUocGNpX21tY2ZnX3Byb2Jlcyk7IGkrKykgew0KPiAgICAgICAgICBidXMgPSAgcGNpX21t
Y2ZnX3Byb2Jlc1tpXS5idXM7DQo+ICAgICAgICAgIGRldmZuID0gcGNpX21tY2ZnX3Byb2Jlc1tp
XS5kZXZmbjsNCj4gLSAgICAgICAgbCA9IHBjaV9jb25mX3JlYWQzMihQQ0lfU0JERjMoMCwgYnVz
LCBkZXZmbiksIDApOw0KPiArICAgICAgICBsID0gcGNpX2NvbmZfcmVhZDMyKFBDSV9TQkRGKDAs
IGJ1cywgZGV2Zm4pLCAwKTsNCj4gICAgICAgICAgdmVuZG9yID0gbCAmIDB4ZmZmZjsNCj4gICAg
ICAgICAgZGV2aWNlID0gKGwgPj4gMTYpICYgMHhmZmZmOw0KPiANCj4gLS0tIGEveGVuL2NvbW1v
bi9jb21wYXQvbWVtb3J5LmMNCj4gKysrIGIveGVuL2NvbW1vbi9jb21wYXQvbWVtb3J5LmMNCj4g
QEAgLTI3LDggKzI3LDggQEAgc3RhdGljIGludCBjZl9jaGVjayBnZXRfcmVzZXJ2ZWRfZGV2aWNl
Xw0KPiAgICAgIHhlbl9wZm5fdCBzdGFydCwgeGVuX3Vsb25nX3QgbnIsIHUzMiBpZCwgdm9pZCAq
Y3R4dCkNCj4gIHsNCj4gICAgICBzdHJ1Y3QgZ2V0X3Jlc2VydmVkX2RldmljZV9tZW1vcnkgKmdy
ZG0gPSBjdHh0Ow0KPiAtICAgIHVpbnQzMl90IHNiZGYgPSBQQ0lfU0JERjMoZ3JkbS0+bWFwLmRl
di5wY2kuc2VnLCBncmRtLQ0KPiA+bWFwLmRldi5wY2kuYnVzLA0KPiAtICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgZ3JkbS0+bWFwLmRldi5wY2kuZGV2Zm4pLnNiZGY7DQo+ICsgICAgdWlu
dDMyX3Qgc2JkZiA9IFBDSV9TQkRGKGdyZG0tPm1hcC5kZXYucGNpLnNlZywgZ3JkbS0NCj4gPm1h
cC5kZXYucGNpLmJ1cywNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ3JkbS0+bWFw
LmRldi5wY2kuZGV2Zm4pLnNiZGY7DQo+IA0KPiAgICAgIGlmICggIShncmRtLT5tYXAuZmxhZ3Mg
JiBYRU5NRU1fUkRNX0FMTCkgJiYgKHNiZGYgIT0gaWQpICkNCj4gICAgICAgICAgcmV0dXJuIDA7
DQo+IC0tLSBhL3hlbi9jb21tb24vbWVtb3J5LmMNCj4gKysrIGIveGVuL2NvbW1vbi9tZW1vcnku
Yw0KPiBAQCAtMTA1NSw4ICsxMDU1LDggQEAgc3RhdGljIGludCBjZl9jaGVjayBnZXRfcmVzZXJ2
ZWRfZGV2aWNlXw0KPiAgICAgIHhlbl9wZm5fdCBzdGFydCwgeGVuX3Vsb25nX3QgbnIsIHUzMiBp
ZCwgdm9pZCAqY3R4dCkNCj4gIHsNCj4gICAgICBzdHJ1Y3QgZ2V0X3Jlc2VydmVkX2RldmljZV9t
ZW1vcnkgKmdyZG0gPSBjdHh0Ow0KPiAtICAgIHVpbnQzMl90IHNiZGYgPSBQQ0lfU0JERjMoZ3Jk
bS0+bWFwLmRldi5wY2kuc2VnLCBncmRtLQ0KPiA+bWFwLmRldi5wY2kuYnVzLA0KPiAtICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZ3JkbS0+bWFwLmRldi5wY2kuZGV2Zm4pLnNiZGY7DQo+
ICsgICAgdWludDMyX3Qgc2JkZiA9IFBDSV9TQkRGKGdyZG0tPm1hcC5kZXYucGNpLnNlZywgZ3Jk
bS0NCj4gPm1hcC5kZXYucGNpLmJ1cywNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
Z3JkbS0+bWFwLmRldi5wY2kuZGV2Zm4pLnNiZGY7DQo+IA0KPiAgICAgIGlmICggIShncmRtLT5t
YXAuZmxhZ3MgJiBYRU5NRU1fUkRNX0FMTCkgJiYgKHNiZGYgIT0gaWQpICkNCj4gICAgICAgICAg
cmV0dXJuIDA7DQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9hY3Bp
LmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2FjcGkuYw0KPiBA
QCAtOTYsNyArOTYsNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgYWRkX2l2cnNfbWFwcGluZ19lbnRy
DQo+IA0KPiAgICAgICAgICAgICAgaWYgKCAhaXZyc19tYXBwaW5nc1thbGlhc19pZF0uaW50cmVt
YXBfdGFibGUgKQ0KPiAgICAgICAgICAgICAgICAgIHBhbmljKCJObyBtZW1vcnkgZm9yICVwcCdz
IElSVFxuIiwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAmUENJX1NCREYyKGlvbW11LT5zZWcs
IGFsaWFzX2lkKSk7DQo+ICsgICAgICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGKGlvbW11LT5z
ZWcsIGFsaWFzX2lkKSk7DQo+ICAgICAgICAgIH0NCj4gICAgICB9DQo+IA0KPiBAQCAtNzkwLDcg
Kzc5MCw3IEBAIHN0YXRpYyB1MTYgX19pbml0IHBhcnNlX2l2aGRfZGV2aWNlX3NwZWMNCj4gICAg
ICB9DQo+IA0KPiAgICAgIEFNRF9JT01NVV9ERUJVRygiSVZIRCBTcGVjaWFsOiAlcHAgdmFyaWV0
eSAlI3ggaGFuZGxlICUjeFxuIiwNCj4gLSAgICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGMihz
ZWcsIGJkZiksIHNwZWNpYWwtPnZhcmlldHksIHNwZWNpYWwtPmhhbmRsZSk7DQo+ICsgICAgICAg
ICAgICAgICAgICAgICZQQ0lfU0JERihzZWcsIGJkZiksIHNwZWNpYWwtPnZhcmlldHksIHNwZWNp
YWwtPmhhbmRsZSk7DQo+ICAgICAgYWRkX2l2cnNfbWFwcGluZ19lbnRyeShiZGYsIGJkZiwgc3Bl
Y2lhbC0+aGVhZGVyLmRhdGFfc2V0dGluZywgMCwgdHJ1ZSwNCj4gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIGlvbW11KTsNCj4gDQo+IEBAIC04MTYsNyArODE2LDcgQEAgc3RhdGljIHUxNiBf
X2luaXQgcGFyc2VfaXZoZF9kZXZpY2Vfc3BlYw0KPiAgICAgICAgICAgICAgQU1EX0lPTU1VX0RF
QlVHKCJJVkhEOiBDb21tYW5kIGxpbmUgb3ZlcnJpZGUgcHJlc2VudCBmb3IgSU8tDQo+IEFQSUMg
JSN4Ig0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIoSVZSUzogJSN4IGRldklEICVw
cClcbiIsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW9hcGljX3NiZGZbaWR4XS5p
ZCwgc3BlY2lhbC0+aGFuZGxlLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICZQQ0lf
U0JERjIoc2VnLCBiZGYpKTsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAmUENJX1NC
REYoc2VnLCBiZGYpKTsNCj4gICAgICAgICAgICAgIGJyZWFrOw0KPiAgICAgICAgICB9DQo+IA0K
PiBAQCAtODg4LDcgKzg4OCw3IEBAIHN0YXRpYyB1MTYgX19pbml0IHBhcnNlX2l2aGRfZGV2aWNl
X3NwZWMNCj4gICAgICAgICAgICAgIEFNRF9JT01NVV9ERUJVRygiSVZIRDogQ29tbWFuZCBsaW5l
IG92ZXJyaWRlIHByZXNlbnQgZm9yDQo+IEhQRVQgJSN4ICINCj4gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAiKElWUlM6ICUjeCBkZXZJRCAlcHApXG4iLA0KPiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGhwZXRfc2JkZi5pZCwgc3BlY2lhbC0+aGFuZGxlLA0KPiAtICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICZQQ0lfU0JERjIoc2VnLCBiZGYpKTsNCj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAmUENJX1NCREYoc2VnLCBiZGYpKTsNCj4gICAgICAgICAgICAgIGJy
ZWFrOw0KPiAgICAgICAgICBjYXNlIEhQRVRfTk9ORToNCj4gICAgICAgICAgICAgIC8qIHNldCBk
ZXZpY2UgaWQgb2YgaHBldCAqLw0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQv
aW9tbXVfY21kLmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2Nt
ZC5jDQo+IEBAIC00MCw3ICs0MCw3IEBAIHN0YXRpYyB2b2lkIHNlbmRfaW9tbXVfY29tbWFuZChz
dHJ1Y3QgYW0NCj4gICAgICAgICAgICAgICAgICAgICAgIElPTU1VX1JJTkdfQlVGRkVSX1BUUl9N
QVNLKSApDQo+ICAgICAgew0KPiAgICAgICAgICBwcmludGtfb25jZShYRU5MT0dfRVJSICJBTUQg
SU9NTVUgJXBwOiBubyBjbWQgc2xvdCBhdmFpbGFibGVcbiIsDQo+IC0gICAgICAgICAgICAgICAg
ICAgICZQQ0lfU0JERjIoaW9tbXUtPnNlZywgaW9tbXUtPmJkZikpOw0KPiArICAgICAgICAgICAg
ICAgICAgICAmUENJX1NCREYoaW9tbXUtPnNlZywgaW9tbXUtPmJkZikpOw0KPiAgICAgICAgICBj
cHVfcmVsYXgoKTsNCj4gICAgICB9DQo+IA0KPiBAQCAtODQsNyArODQsNyBAQCBzdGF0aWMgdm9p
ZCBmbHVzaF9jb21tYW5kX2J1ZmZlcihzdHJ1Y3QNCj4gICAgICAgICAgICAgIHRocmVzaG9sZCB8
PSB0aHJlc2hvbGQgPDwgMTsNCj4gICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORw0K
PiAgICAgICAgICAgICAgICAgICAgICJBTUQgSU9NTVUgJXBwOiAlc2NvbXBsZXRpb24gd2FpdCB0
YWtpbmcgdG9vIGxvbmdcbiIsDQo+IC0gICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGMihpb21t
dS0+c2VnLCBpb21tdS0+YmRmKSwNCj4gKyAgICAgICAgICAgICAgICAgICAmUENJX1NCREYoaW9t
bXUtPnNlZywgaW9tbXUtPmJkZiksDQo+ICAgICAgICAgICAgICAgICAgICAgdGltZW91dF9iYXNl
ID8gImlvdGxiICIgOiAiIik7DQo+ICAgICAgICAgICAgICB0aW1lb3V0ID0gMDsNCj4gICAgICAg
ICAgfQ0KPiBAQCAtOTQsNyArOTQsNyBAQCBzdGF0aWMgdm9pZCBmbHVzaF9jb21tYW5kX2J1ZmZl
cihzdHJ1Y3QNCj4gICAgICBpZiAoICF0aW1lb3V0ICkNCj4gICAgICAgICAgcHJpbnRrKFhFTkxP
R19XQVJOSU5HDQo+ICAgICAgICAgICAgICAgICAiQU1EIElPTU1VICVwcDogJXNjb21wbGV0aW9u
IHdhaXQgdG9vayAlbHVtc1xuIiwNCj4gLSAgICAgICAgICAgICAgICZQQ0lfU0JERjIoaW9tbXUt
PnNlZywgaW9tbXUtPmJkZiksDQo+ICsgICAgICAgICAgICAgICAmUENJX1NCREYoaW9tbXUtPnNl
ZywgaW9tbXUtPmJkZiksDQo+ICAgICAgICAgICAgICAgICB0aW1lb3V0X2Jhc2UgPyAiaW90bGIg
IiA6ICIiLA0KPiAgICAgICAgICAgICAgICAgKE5PVygpIC0gc3RhcnQpIC8gMTAwMDAwMDApOw0K
PiAgfQ0KPiBAQCAtMjkyLDE0ICsyOTIsMTQgQEAgdm9pZCBhbWRfaW9tbXVfZmx1c2hfaW90bGIo
dTggZGV2Zm4sIGNvbg0KPiAgICAgIGlmICggIWlvbW11ICkNCj4gICAgICB7DQo+ICAgICAgICAg
IEFNRF9JT01NVV9XQVJOKCJjYW4ndCBmaW5kIElPTU1VIGZvciAlcHBcbiIsDQo+IC0gICAgICAg
ICAgICAgICAgICAgICAgICZQQ0lfU0JERjMocGRldi0+c2VnLCBwZGV2LT5idXMsIGRldmZuKSk7
DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICZQQ0lfU0JERihwZGV2LT5zZWcsIHBkZXYtPmJ1
cywgZGV2Zm4pKTsNCj4gICAgICAgICAgcmV0dXJuOw0KPiAgICAgIH0NCj4gDQo+ICAgICAgaWYg
KCAhaW9tbXVfaGFzX2NhcChpb21tdSwgUENJX0NBUF9JT1RMQl9TSElGVCkgKQ0KPiAgICAgICAg
ICByZXR1cm47DQo+IA0KPiAtICAgIHJlcV9pZCA9IGdldF9kbWFfcmVxdWVzdG9yX2lkKGlvbW11
LT5zZWcsIFBDSV9CREYyKHBkZXYtPmJ1cywNCj4gZGV2Zm4pKTsNCj4gKyAgICByZXFfaWQgPSBn
ZXRfZG1hX3JlcXVlc3Rvcl9pZChpb21tdS0+c2VnLCBQQ0lfQkRGKHBkZXYtPmJ1cywNCj4gZGV2
Zm4pKTsNCj4gICAgICBxdWV1ZWlkID0gcmVxX2lkOw0KPiAgICAgIG1heHBlbmQgPSBwZGV2LT5h
dHMucXVldWVfZGVwdGggJiAweGZmOw0KPiANCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvYW1kL2lvbW11X2RldGVjdC5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft
ZC9pb21tdV9kZXRlY3QuYw0KPiBAQCAtMjMxLDcgKzIzMSw3IEBAIGludCBfX2luaXQgYW1kX2lv
bW11X2RldGVjdF9vbmVfYWNwaSgNCj4gICAgICBydCA9IHBjaV9yb19kZXZpY2UoaW9tbXUtPnNl
ZywgYnVzLCBQQ0lfREVWRk4oZGV2LCBmdW5jKSk7DQo+ICAgICAgaWYgKCBydCApDQo+ICAgICAg
ICAgIHByaW50ayhYRU5MT0dfRVJSICJDb3VsZCBub3QgbWFyayBjb25maWcgc3BhY2Ugb2YgJXBw
IHJlYWQtb25seQ0KPiAoJWQpXG4iLA0KPiAtICAgICAgICAgICAgICAgJlBDSV9TQkRGMihpb21t
dS0+c2VnLCBpb21tdS0+YmRmKSwgcnQpOw0KPiArICAgICAgICAgICAgICAgJlBDSV9TQkRGKGlv
bW11LT5zZWcsIGlvbW11LT5iZGYpLCBydCk7DQo+IA0KPiAgICAgIGxpc3RfYWRkX3RhaWwoJmlv
bW11LT5saXN0LCAmYW1kX2lvbW11X2hlYWQpOw0KPiAgICAgIHJ0ID0gMDsNCj4gLS0tIGEveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2luaXQuYw0KPiArKysgYi94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfaW5pdC5jDQo+IEBAIC01NjIsNyArNTYyLDcgQEAgc3Rh
dGljIHZvaWQgY2ZfY2hlY2sgcGFyc2VfZXZlbnRfbG9nX2VudA0KPiANCj4gICAgICAgICAgcHJp
bnRrKFhFTkxPR19FUlIgIkFNRC1WaTogJXM6ICVwcCBkJXUgYWRkciAlMDE2IlBSSXg2NA0KPiAg
ICAgICAgICAgICAgICAgIiBmbGFncyAlI3glcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwNCj4gLSAg
ICAgICAgICAgICAgIGNvZGVfc3RyLCAmUENJX1NCREYyKGlvbW11LT5zZWcsIGRldmljZV9pZCks
DQo+ICsgICAgICAgICAgICAgICBjb2RlX3N0ciwgJlBDSV9TQkRGKGlvbW11LT5zZWcsIGRldmlj
ZV9pZCksDQo+ICAgICAgICAgICAgICAgICBkb21haW5faWQsIGFkZHIsIGZsYWdzLA0KPiAgICAg
ICAgICAgICAgICAgKGZsYWdzICYgMHhlMDApID8gIiA/PyIgOiAiIiwNCj4gICAgICAgICAgICAg
ICAgIChmbGFncyAmIDB4MTAwKSA/ICIgVFIiIDogIiIsDQo+IEBAIC01NzgsNyArNTc4LDcgQEAg
c3RhdGljIHZvaWQgY2ZfY2hlY2sgcGFyc2VfZXZlbnRfbG9nX2VudA0KPiAgICAgICAgICBmb3Ig
KCBiZGYgPSAwOyBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyApDQo+ICAgICAgICAgICAg
ICBpZiAoIGdldF9kbWFfcmVxdWVzdG9yX2lkKGlvbW11LT5zZWcsIGJkZikgPT0gZGV2aWNlX2lk
ICkNCj4gICAgICAgICAgICAgICAgICBwY2lfY2hlY2tfZGlzYWJsZV9kZXZpY2UoaW9tbXUtPnNl
ZywgUENJX0JVUyhiZGYpLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBQQ0lfREVWRk4yKGJkZikpOw0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBQQ0lfREVWRk4oYmRmKSk7DQo+ICAgICAgfQ0KPiAgICAgIGVsc2UNCj4gICAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIiVzICUwOHggJTA4eCAlMDh4ICUwOHhcbiIsDQo+IEBA
IC02MzEsMTggKzYzMSwxMyBAQCBzdGF0aWMgdm9pZCBpb21tdV9jaGVja19ldmVudF9sb2coc3Ry
dWN0DQo+IA0KPiAgc3RhdGljIHZvaWQgY2ZfY2hlY2sgcGFyc2VfcHByX2xvZ19lbnRyeShzdHJ1
Y3QgYW1kX2lvbW11ICppb21tdSwgdTMyDQo+IGVudHJ5W10pDQo+ICB7DQo+IC0NCj4gLSAgICB1
MTYgZGV2aWNlX2lkOw0KPiAtICAgIHU4IGJ1cywgZGV2Zm47DQo+IC0gICAgc3RydWN0IHBjaV9k
ZXYgKnBkZXY7DQo+IC0NCj4gICAgICAvKiBoZXJlIGRldmljZV9pZCBpcyBwaHlzaWNhbCB2YWx1
ZSAqLw0KPiAtICAgIGRldmljZV9pZCA9IGlvbW11X2dldF9kZXZpZF9mcm9tX2NtZChlbnRyeVsw
XSk7DQo+IC0gICAgYnVzID0gUENJX0JVUyhkZXZpY2VfaWQpOw0KPiAtICAgIGRldmZuID0gUENJ
X0RFVkZOMihkZXZpY2VfaWQpOw0KPiArICAgIHVpbnQxNl90IGRldmljZV9pZCA9IGlvbW11X2dl
dF9kZXZpZF9mcm9tX2NtZChlbnRyeVswXSk7DQo+ICsgICAgc3RydWN0IHBjaV9kZXYgKnBkZXY7
DQo+IA0KPiAgICAgIHBjaWRldnNfbG9jaygpOw0KPiAtICAgIHBkZXYgPSBwY2lfZ2V0X3JlYWxf
cGRldihpb21tdS0+c2VnLCBidXMsIGRldmZuKTsNCj4gKyAgICBwZGV2ID0gcGNpX2dldF9yZWFs
X3BkZXYoaW9tbXUtPnNlZywgUENJX0JVUyhkZXZpY2VfaWQpLA0KPiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBQQ0lfREVWRk4oZGV2aWNlX2lkKSk7DQo+ICAgICAgcGNpZGV2c191bmxv
Y2soKTsNCj4gDQo+ICAgICAgaWYgKCBwZGV2ICkNCj4gQEAgLTc1MSwxMiArNzQ2LDEyIEBAIHN0
YXRpYyBib29sX3QgX19pbml0IHNldF9pb21tdV9pbnRlcnJ1cHQNCj4gDQo+ICAgICAgcGNpZGV2
c19sb2NrKCk7DQo+ICAgICAgaW9tbXUtPm1zaS5kZXYgPSBwY2lfZ2V0X3BkZXYoaW9tbXUtPnNl
ZywgUENJX0JVUyhpb21tdS0+YmRmKSwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBQQ0lfREVWRk4yKGlvbW11LT5iZGYpKTsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBQQ0lfREVWRk4oaW9tbXUtPmJkZikpOw0KPiAgICAgIHBjaWRldnNfdW5sb2Nr
KCk7DQo+ICAgICAgaWYgKCAhaW9tbXUtPm1zaS5kZXYgKQ0KPiAgICAgIHsNCj4gICAgICAgICAg
QU1EX0lPTU1VX1dBUk4oIm5vIHBkZXYgZm9yICVwcFxuIiwNCj4gLSAgICAgICAgICAgICAgICAg
ICAgICAgJlBDSV9TQkRGMihpb21tdS0+c2VnLCBpb21tdS0+YmRmKSk7DQo+ICsgICAgICAgICAg
ICAgICAgICAgICAgICZQQ0lfU0JERihpb21tdS0+c2VnLCBpb21tdS0+YmRmKSk7DQo+ICAgICAg
ICAgIHJldHVybiAwOw0KPiAgICAgIH0NCj4gDQo+IEBAIC03NzgsNyArNzczLDcgQEAgc3RhdGlj
IGJvb2xfdCBfX2luaXQgc2V0X2lvbW11X2ludGVycnVwdA0KPiAgICAgICAgICBod19pcnFfY29u
dHJvbGxlciAqaGFuZGxlcjsNCj4gICAgICAgICAgdTE2IGNvbnRyb2w7DQo+IA0KPiAtICAgICAg
ICBjb250cm9sID0gcGNpX2NvbmZfcmVhZDE2KFBDSV9TQkRGMihpb21tdS0+c2VnLCBpb21tdS0+
YmRmKSwNCj4gKyAgICAgICAgY29udHJvbCA9IHBjaV9jb25mX3JlYWQxNihQQ0lfU0JERihpb21t
dS0+c2VnLCBpb21tdS0+YmRmKSwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBpb21tdS0+bXNpLm1zaV9hdHRyaWIucG9zICsgUENJX01TSV9GTEFHUyk7DQo+IA0KPiAgICAg
ICAgICBpb21tdS0+bXNpLm1zaS5udmVjID0gMTsNCj4gQEAgLTg0MiwyMiArODM3LDIyIEBAIHN0
YXRpYyB2b2lkIGFtZF9pb21tdV9lcnJhdHVtXzc0Nl93b3JrYXINCj4gICAgICAgICAgIChib290
X2NwdV9kYXRhLng4Nl9tb2RlbCA+IDB4MWYpICkNCj4gICAgICAgICAgcmV0dXJuOw0KPiANCj4g
LSAgICBwY2lfY29uZl93cml0ZTMyKFBDSV9TQkRGMihpb21tdS0+c2VnLCBpb21tdS0+YmRmKSwg
MHhmMCwgMHg5MCk7DQo+IC0gICAgdmFsdWUgPSBwY2lfY29uZl9yZWFkMzIoUENJX1NCREYyKGlv
bW11LT5zZWcsIGlvbW11LT5iZGYpLCAweGY0KTsNCj4gKyAgICBwY2lfY29uZl93cml0ZTMyKFBD
SV9TQkRGKGlvbW11LT5zZWcsIGlvbW11LT5iZGYpLCAweGYwLCAweDkwKTsNCj4gKyAgICB2YWx1
ZSA9IHBjaV9jb25mX3JlYWQzMihQQ0lfU0JERihpb21tdS0+c2VnLCBpb21tdS0+YmRmKSwgMHhm
NCk7DQo+IA0KPiAgICAgIGlmICggdmFsdWUgJiAoMSA8PCAyKSApDQo+ICAgICAgICAgIHJldHVy
bjsNCj4gDQo+ICAgICAgLyogU2VsZWN0IE5CIGluZGlyZWN0IHJlZ2lzdGVyIDB4OTAgYW5kIGVu
YWJsZSB3cml0aW5nICovDQo+IC0gICAgcGNpX2NvbmZfd3JpdGUzMihQQ0lfU0JERjIoaW9tbXUt
PnNlZywgaW9tbXUtPmJkZiksIDB4ZjAsIDB4OTAgfCAoMQ0KPiA8PCA4KSk7DQo+ICsgICAgcGNp
X2NvbmZfd3JpdGUzMihQQ0lfU0JERihpb21tdS0+c2VnLCBpb21tdS0+YmRmKSwgMHhmMCwgMHg5
MCB8ICgxIDw8DQo+IDgpKTsNCj4gDQo+IC0gICAgcGNpX2NvbmZfd3JpdGUzMihQQ0lfU0JERjIo
aW9tbXUtPnNlZywgaW9tbXUtPmJkZiksIDB4ZjQsIHZhbHVlIHwgKDENCj4gPDwgMikpOw0KPiAr
ICAgIHBjaV9jb25mX3dyaXRlMzIoUENJX1NCREYoaW9tbXUtPnNlZywgaW9tbXUtPmJkZiksIDB4
ZjQsIHZhbHVlIHwgKDENCj4gPDwgMikpOw0KPiAgICAgIHByaW50ayhYRU5MT0dfSU5GTw0KPiAg
ICAgICAgICAgICAiQU1ELVZpOiBBcHBseWluZyBlcnJhdHVtIDc0NiB3b3JrYXJvdW5kIGZvciBJ
T01NVSBhdCAlcHBcbiIsDQo+IC0gICAgICAgICAgICZQQ0lfU0JERjIoaW9tbXUtPnNlZywgaW9t
bXUtPmJkZikpOw0KPiArICAgICAgICAgICAmUENJX1NCREYoaW9tbXUtPnNlZywgaW9tbXUtPmJk
ZikpOw0KPiANCj4gICAgICAvKiBDbGVhciB0aGUgZW5hYmxlIHdyaXRpbmcgYml0ICovDQo+IC0g
ICAgcGNpX2NvbmZfd3JpdGUzMihQQ0lfU0JERjIoaW9tbXUtPnNlZywgaW9tbXUtPmJkZiksIDB4
ZjAsIDB4OTApOw0KPiArICAgIHBjaV9jb25mX3dyaXRlMzIoUENJX1NCREYoaW9tbXUtPnNlZywg
aW9tbXUtPmJkZiksIDB4ZjAsIDB4OTApOw0KPiAgfQ0KPiANCj4gIHN0YXRpYyB2b2lkIGVuYWJs
ZV9pb21tdShzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSkNCj4gQEAgLTEyODgsNyArMTI4Myw3IEBA
IHN0YXRpYyBpbnQgX19pbml0IGNmX2NoZWNrIGFtZF9pb21tdV9zZXQNCj4gICAgICAgICAgICAg
ICAgICBpZiAoICFwY2lfaW5pdCApDQo+ICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0K
PiAgICAgICAgICAgICAgICAgIHBjaWRldnNfbG9jaygpOw0KPiAtICAgICAgICAgICAgICAgIHBk
ZXYgPSBwY2lfZ2V0X3BkZXYoc2VnLCBQQ0lfQlVTKGJkZiksIFBDSV9ERVZGTjIoYmRmKSk7DQo+
ICsgICAgICAgICAgICAgICAgcGRldiA9IHBjaV9nZXRfcGRldihzZWcsIFBDSV9CVVMoYmRmKSwg
UENJX0RFVkZOKGJkZikpOw0KPiAgICAgICAgICAgICAgICAgIHBjaWRldnNfdW5sb2NrKCk7DQo+
ICAgICAgICAgICAgICB9DQo+IA0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQv
aW9tbXVfaW50ci5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9p
bnRyLmMNCj4gQEAgLTYwNCw3ICs2MDQsNyBAQCBzdGF0aWMgc3RydWN0IGFtZF9pb21tdSAqX2Zp
bmRfaW9tbXVfZm9yDQo+ICAgICAgaWYgKCBpb21tdSApDQo+ICAgICAgICAgIHJldHVybiBpb21t
dTsNCj4gDQo+IC0gICAgQU1EX0lPTU1VX0RFQlVHKCJObyBJT01NVSBmb3IgTVNJIGRldiA9ICVw
cFxuIiwNCj4gJlBDSV9TQkRGMihzZWcsIGJkZikpOw0KPiArICAgIEFNRF9JT01NVV9ERUJVRygi
Tm8gSU9NTVUgZm9yIE1TSSBkZXYgPSAlcHBcbiIsDQo+ICZQQ0lfU0JERihzZWcsIGJkZikpOw0K
PiAgICAgIHJldHVybiBFUlJfUFRSKC1FSU5WQUwpOw0KPiAgfQ0KPiANCj4gQEAgLTgxNCw3ICs4
MTQsNyBAQCBzdGF0aWMgdm9pZCBkdW1wX2ludHJlbWFwX3RhYmxlKGNvbnN0IHN0DQo+ICAgICAg
ICAgIGlmICggaXZyc19tYXBwaW5nICkNCj4gICAgICAgICAgew0KPiAgICAgICAgICAgICAgcHJp
bnRrKCIgICVwcDpcbiIsDQo+IC0gICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGMihpb21tdS0+
c2VnLCBpdnJzX21hcHBpbmctPmR0ZV9yZXF1ZXN0b3JfaWQpKTsNCj4gKyAgICAgICAgICAgICAg
ICAgICAmUENJX1NCREYoaW9tbXUtPnNlZywgaXZyc19tYXBwaW5nLT5kdGVfcmVxdWVzdG9yX2lk
KSk7DQo+ICAgICAgICAgICAgICBpdnJzX21hcHBpbmcgPSBOVUxMOw0KPiAgICAgICAgICB9DQo+
IA0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMNCj4gKysr
IGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jDQo+IEBAIC01MzQsNyAr
NTM0LDcgQEAgaW50IGNmX2NoZWNrIGFtZF9pb21tdV9nZXRfcmVzZXJ2ZWRfZGV2aQ0KPiANCj4g
ICAgICBmb3IgKCBiZGYgPSAwOyBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyArK2JkZiApDQo+ICAg
ICAgew0KPiAtICAgICAgICBwY2lfc2JkZl90IHNiZGYgPSBQQ0lfU0JERjIoc2VnLCBiZGYpOw0K
PiArICAgICAgICBwY2lfc2JkZl90IHNiZGYgPSBQQ0lfU0JERihzZWcsIGJkZik7DQo+ICAgICAg
ICAgIGNvbnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW0gPSBpdnJzX21hcHBpbmdzW2JkZl0u
dW5pdHlfbWFwOw0KPiAgICAgICAgICB1bnNpZ25lZCBpbnQgcmVxID0gaXZyc19tYXBwaW5nc1ti
ZGZdLmR0ZV9yZXF1ZXN0b3JfaWQ7DQo+ICAgICAgICAgIGNvbnN0IHN0cnVjdCBhbWRfaW9tbXUg
KmlvbW11ID0gaXZyc19tYXBwaW5nc1tiZGZdLmlvbW11Ow0KPiBAQCAtNTYzLDcgKzU2Myw3IEBA
IGludCBjZl9jaGVjayBhbWRfaW9tbXVfZ2V0X3Jlc2VydmVkX2RldmkNCj4gICAgICAgICAgICAg
ICAqIHRoZSBzYW1lIGFsaWFzIElELg0KPiAgICAgICAgICAgICAgICovDQo+ICAgICAgICAgICAg
ICBpZiAoIGJkZiAhPSByZXEgJiYgaXZyc19tYXBwaW5nc1tyZXFdLmlvbW11ICYmDQo+IC0gICAg
ICAgICAgICAgICAgIGZ1bmMoMCwgMCwgUENJX1NCREYyKHNlZywgcmVxKS5zYmRmLCBjdHh0KSAp
DQo+ICsgICAgICAgICAgICAgICAgIGZ1bmMoMCwgMCwgUENJX1NCREYoc2VnLCByZXEpLnNiZGYs
IGN0eHQpICkNCj4gICAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4gDQo+ICAgICAgICAgICAg
ICBpZiAoIGdsb2JhbCA9PSBwZW5kaW5nICkNCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9h
bWQvcGNpX2FtZF9pb21tdS5jDQo+IEBAIC01Myw3ICs1Myw3IEBAIHN0cnVjdCBhbWRfaW9tbXUg
KmZpbmRfaW9tbXVfZm9yX2RldmljZSgNCj4gICAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbYmRm
XSA9IHRtcDsNCj4gDQo+ICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcgIiVwcCBu
b3QgZm91bmQgaW4gQUNQSSB0YWJsZXM7Ig0KPiAtICAgICAgICAgICAgICAgICAgICIgdXNpbmcg
c2FtZSBJT01NVSBhcyBmdW5jdGlvbiAwXG4iLCAmUENJX1NCREYyKHNlZywgYmRmKSk7DQo+ICsg
ICAgICAgICAgICAgICAgICAgIiB1c2luZyBzYW1lIElPTU1VIGFzIGZ1bmN0aW9uIDBcbiIsICZQ
Q0lfU0JERihzZWcsIGJkZikpOw0KPiANCj4gICAgICAgICAgICAgIC8qIHdyaXRlIGlvbW11IGZp
ZWxkIGxhc3QgKi8NCj4gICAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbYmRmXS5pb21tdSA9IGl2
cnNfbWFwcGluZ3NbYmQwXS5pb21tdTsNCj4gQEAgLTE0NCw3ICsxNDQsNyBAQCBzdGF0aWMgaW50
IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfDQo+ICAgICAgICAgICAgICAgICB8IChpdnJz
X2Rldi0+dW5pdHlfbWFwID8gU0VUX1JPT1RfV0lUSF9VTklUWV9NQVAgOiAwKTsNCj4gDQo+ICAg
ICAgLyogZ2V0IGRldmljZS10YWJsZSBlbnRyeSAqLw0KPiAtICAgIHJlcV9pZCA9IGdldF9kbWFf
cmVxdWVzdG9yX2lkKGlvbW11LT5zZWcsIFBDSV9CREYyKGJ1cywgZGV2Zm4pKTsNCj4gKyAgICBy
ZXFfaWQgPSBnZXRfZG1hX3JlcXVlc3Rvcl9pZChpb21tdS0+c2VnLCBQQ0lfQkRGKGJ1cywgZGV2
Zm4pKTsNCj4gICAgICB0YWJsZSA9IGlvbW11LT5kZXZfdGFibGUuYnVmZmVyOw0KPiAgICAgIGR0
ZSA9ICZ0YWJsZVtyZXFfaWRdOw0KPiAgICAgIGl2cnNfZGV2ID0gJmdldF9pdnJzX21hcHBpbmdz
KGlvbW11LT5zZWcpW3JlcV9pZF07DQo+IEBAIC0yMDIsNyArMjAyLDcgQEAgc3RhdGljIGludCBf
X211c3RfY2hlY2sgYW1kX2lvbW11X3NldHVwXw0KPiAgICAgICAgICAgKiBwcmVzZW5jZS4gIEJ1
dCBsZXQncyBkZWFsIHdpdGggdGhhdCBjYXNlIG9ubHkgaWYgaXQgaXMgYWN0dWFsbHkNCj4gICAg
ICAgICAgICogZm91bmQgaW4gdGhlIHdpbGQuDQo+ICAgICAgICAgICAqLw0KPiAtICAgICAgICBp
ZiAoIHJlcV9pZCAhPSBQQ0lfQkRGMihidXMsIGRldmZuKSAmJg0KPiArICAgICAgICBpZiAoIHJl
cV9pZCAhPSBQQ0lfQkRGKGJ1cywgZGV2Zm4pICYmDQo+ICAgICAgICAgICAgICAgKHNyX2ZsYWdz
ICYgU0VUX1JPT1RfV0lUSF9VTklUWV9NQVApICkNCj4gICAgICAgICAgICAgIHJjID0gLUVPUE5P
VFNVUFA7DQo+ICAgICAgICAgIGVsc2UNCj4gQEAgLTIzMSw3ICsyMzEsNyBAQCBzdGF0aWMgaW50
IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfc2V0dXBfDQo+ICAgICAgICAgICAgICAgKGFueV9wZGV2
X2JlaGluZF9pb21tdShwZGV2LT5kb21haW4sIHBkZXYsIGlvbW11KSB8fA0KPiAgICAgICAgICAg
ICAgICBwZGV2LT5waGFudG9tX3N0cmlkZSkgKQ0KPiAgICAgICAgICAgICAgQU1EX0lPTU1VX1dB
Uk4oIiAlcHA6IHJlYXNzaWdubWVudCBtYXkgY2F1c2UgJXBkIGRhdGENCj4gY29ycnVwdGlvblxu
IiwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICZQQ0lfU0JERjMocGRldi0+c2VnLCBi
dXMsIGRldmZuKSwgcGRldi0+ZG9tYWluKTsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICZQQ0lfU0JERihwZGV2LT5zZWcsIGJ1cywgZGV2Zm4pLCBwZGV2LT5kb21haW4pOw0KPiANCj4g
ICAgICAgICAgLyoNCj4gICAgICAgICAgICogQ2hlY2sgcmVtYWluaW5nIHNldHRpbmdzIGFyZSBz
dGlsbCBpbiBwbGFjZSBmcm9tIGFuIGVhcmxpZXIgY2FsbA0KPiBAQCAtNDE0LDcgKzQxNCw3IEBA
IHN0YXRpYyB2b2lkIGFtZF9pb21tdV9kaXNhYmxlX2RvbWFpbl9kZXYNCj4gICAgICAgICAgZGlz
YWJsZV9hdHNfZGV2aWNlKHBkZXYpOw0KPiANCj4gICAgICBCVUdfT04gKCBpb21tdS0+ZGV2X3Rh
YmxlLmJ1ZmZlciA9PSBOVUxMICk7DQo+IC0gICAgcmVxX2lkID0gZ2V0X2RtYV9yZXF1ZXN0b3Jf
aWQoaW9tbXUtPnNlZywgUENJX0JERjIoYnVzLCBkZXZmbikpOw0KPiArICAgIHJlcV9pZCA9IGdl
dF9kbWFfcmVxdWVzdG9yX2lkKGlvbW11LT5zZWcsIFBDSV9CREYoYnVzLCBkZXZmbikpOw0KPiAg
ICAgIHRhYmxlID0gaW9tbXUtPmRldl90YWJsZS5idWZmZXI7DQo+ICAgICAgZHRlID0gJnRhYmxl
W3JlcV9pZF07DQo+IA0KPiBAQCAtNDYxLDcgKzQ2MSw3IEBAIHN0YXRpYyBpbnQgY2ZfY2hlY2sg
cmVhc3NpZ25fZGV2aWNlKA0KPiAgICAgIGlmICggIWlvbW11ICkNCj4gICAgICB7DQo+ICAgICAg
ICAgIEFNRF9JT01NVV9XQVJOKCJmYWlsZWQgdG8gZmluZCBJT01NVTogJXBwIGNhbm5vdCBiZSBh
c3NpZ25lZA0KPiB0byAlcGRcbiIsDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICZQQ0lfU0JE
RjMocGRldi0+c2VnLCBwZGV2LT5idXMsIGRldmZuKSwgdGFyZ2V0KTsNCj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgJlBDSV9TQkRGKHBkZXYtPnNlZywgcGRldi0+YnVzLCBkZXZmbiksIHRhcmdl
dCk7DQo+ICAgICAgICAgIHJldHVybiAtRU5PREVWOw0KPiAgICAgIH0NCj4gDQo+IEBAIC00ODgs
NyArNDg4LDcgQEAgc3RhdGljIGludCBjZl9jaGVjayByZWFzc2lnbl9kZXZpY2UoDQo+ICAgICAg
aWYgKCAhaXNfaGFyZHdhcmVfZG9tYWluKHNvdXJjZSkgKQ0KPiAgICAgIHsNCj4gICAgICAgICAg
Y29uc3Qgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBw
aW5ncyhwZGV2LQ0KPiA+c2VnKTsNCj4gLSAgICAgICAgdW5zaWduZWQgaW50IGJkZiA9IFBDSV9C
REYyKHBkZXYtPmJ1cywgZGV2Zm4pOw0KPiArICAgICAgICB1bnNpZ25lZCBpbnQgYmRmID0gUENJ
X0JERihwZGV2LT5idXMsIGRldmZuKTsNCj4gDQo+ICAgICAgICAgIHJjID0gYW1kX2lvbW11X3Jl
c2VydmVfZG9tYWluX3VuaXR5X3VubWFwKA0KPiAgICAgICAgICAgICAgICAgICBzb3VyY2UsDQo+
IEBAIC00OTgsNyArNDk4LDcgQEAgc3RhdGljIGludCBjZl9jaGVjayByZWFzc2lnbl9kZXZpY2Uo
DQo+ICAgICAgfQ0KPiANCj4gICAgICBBTURfSU9NTVVfREVCVUcoIlJlLWFzc2lnbiAlcHAgZnJv
bSAlcGQgdG8gJXBkXG4iLA0KPiAtICAgICAgICAgICAgICAgICAgICAmUENJX1NCREYzKHBkZXYt
PnNlZywgcGRldi0+YnVzLCBkZXZmbiksIHNvdXJjZSwgdGFyZ2V0KTsNCj4gKyAgICAgICAgICAg
ICAgICAgICAgJlBDSV9TQkRGKHBkZXYtPnNlZywgcGRldi0+YnVzLCBkZXZmbiksIHNvdXJjZSwg
dGFyZ2V0KTsNCj4gDQo+ICAgICAgcmV0dXJuIDA7DQo+ICB9DQo+IEBAIC01MDcsNyArNTA3LDcg
QEAgc3RhdGljIGludCBjZl9jaGVjayBhbWRfaW9tbXVfYXNzaWduX2Rldg0KPiAgICAgIHN0cnVj
dCBkb21haW4gKmQsIHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdTMyIGZsYWcpDQo+
ICB7DQo+ICAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBnZXRfaXZy
c19tYXBwaW5ncyhwZGV2LT5zZWcpOw0KPiAtICAgIGludCBiZGYgPSBQQ0lfQkRGMihwZGV2LT5i
dXMsIGRldmZuKTsNCj4gKyAgICB1bnNpZ25lZCBpbnQgYmRmID0gUENJX0JERihwZGV2LT5idXMs
IGRldmZuKTsNCj4gICAgICBpbnQgcmVxX2lkID0gZ2V0X2RtYV9yZXF1ZXN0b3JfaWQocGRldi0+
c2VnLCBiZGYpOw0KPiAgICAgIGludCByYyA9IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0
eV9tYXAoDQo+ICAgICAgICAgICAgICAgICAgIGQsIGl2cnNfbWFwcGluZ3NbcmVxX2lkXS51bml0
eV9tYXAsIGZsYWcpOw0KPiBAQCAtNTc1LDEyICs1NzUsMTIgQEAgc3RhdGljIGludCBjZl9jaGVj
ayBhbWRfaW9tbXVfYWRkX2RldmljZQ0KPiAgICAgICAgICB9DQo+IA0KPiAgICAgICAgICBBTURf
SU9NTVVfV0FSTigibm8gSU9NTVUgZm9yICVwcDsgY2Fubm90IGJlIGhhbmRlZA0KPiB0byAlcGRc
biIsDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAmUENJX1NCREYzKHBkZXYtPnNlZywgcGRl
di0+YnVzLCBkZXZmbiksIHBkZXYtPmRvbWFpbik7DQo+ICsgICAgICAgICAgICAgICAgICAgICAg
ICAmUENJX1NCREYocGRldi0+c2VnLCBwZGV2LT5idXMsIGRldmZuKSwgcGRldi0+ZG9tYWluKTsN
Cj4gICAgICAgICAgcmV0dXJuIC1FTk9ERVY7DQo+ICAgICAgfQ0KPiANCj4gICAgICBpdnJzX21h
cHBpbmdzID0gZ2V0X2l2cnNfbWFwcGluZ3MocGRldi0+c2VnKTsNCj4gLSAgICBiZGYgPSBQQ0lf
QkRGMihwZGV2LT5idXMsIGRldmZuKTsNCj4gKyAgICBiZGYgPSBQQ0lfQkRGKHBkZXYtPmJ1cywg
ZGV2Zm4pOw0KPiAgICAgIGlmICggIWl2cnNfbWFwcGluZ3MgfHwNCj4gICAgICAgICAgICFpdnJz
X21hcHBpbmdzW2l2cnNfbWFwcGluZ3NbYmRmXS5kdGVfcmVxdWVzdG9yX2lkXS52YWxpZCApDQo+
ICAgICAgICAgIHJldHVybiAtRVBFUk07DQo+IEBAIC02MTgsNyArNjE4LDcgQEAgc3RhdGljIGlu
dCBjZl9jaGVjayBhbWRfaW9tbXVfYWRkX2RldmljZQ0KPiAgICAgICAgICAgICAgIGl2cnNfbWFw
cGluZ3NbaXZyc19tYXBwaW5nc1tiZGZdLmR0ZV9yZXF1ZXN0b3JfaWRdLnVuaXR5X21hcCwNCj4g
ICAgICAgICAgICAgICAwKSApDQo+ICAgICAgICAgIEFNRF9JT01NVV9XQVJOKCIlcGQ6IHVuaXR5
IG1hcHBpbmcgZmFpbGVkIGZvciAlcHBcbiIsDQo+IC0gICAgICAgICAgICAgICAgICAgICAgIHBk
ZXYtPmRvbWFpbiwgJlBDSV9TQkRGMihwZGV2LT5zZWcsIGJkZikpOw0KPiArICAgICAgICAgICAg
ICAgICAgICAgICBwZGV2LT5kb21haW4sICZQQ0lfU0JERihwZGV2LT5zZWcsIGJkZikpOw0KPiAN
Cj4gICAgICBpZiAoIGlvbW11X3F1YXJhbnRpbmUgJiYgcGRldi0+YXJjaC5wc2V1ZG9fZG9taWQg
PT0NCj4gRE9NSURfSU5WQUxJRCApDQo+ICAgICAgew0KPiBAQCAtNjUxLDIwICs2NTEsMjAgQEAg
c3RhdGljIGludCBjZl9jaGVjayBhbWRfaW9tbXVfcmVtb3ZlX2Rldg0KPiAgICAgIGlmICggIWlv
bW11ICkNCj4gICAgICB7DQo+ICAgICAgICAgIEFNRF9JT01NVV9XQVJOKCJmYWlsZWQgdG8gZmlu
ZCBJT01NVTogJXBwIGNhbm5vdCBiZSByZW1vdmVkDQo+IGZyb20gJXBkXG4iLA0KPiAtICAgICAg
ICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGMyhwZGV2LT5zZWcsIHBkZXYtPmJ1cywgZGV2Zm4p
LCBwZGV2LT5kb21haW4pOw0KPiArICAgICAgICAgICAgICAgICAgICAgICAgJlBDSV9TQkRGKHBk
ZXYtPnNlZywgcGRldi0+YnVzLCBkZXZmbiksIHBkZXYtPmRvbWFpbik7DQo+ICAgICAgICAgIHJl
dHVybiAtRU5PREVWOw0KPiAgICAgIH0NCj4gDQo+ICAgICAgYW1kX2lvbW11X2Rpc2FibGVfZG9t
YWluX2RldmljZShwZGV2LT5kb21haW4sIGlvbW11LCBkZXZmbiwNCj4gcGRldik7DQo+IA0KPiAg
ICAgIGl2cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBwaW5ncyhwZGV2LT5zZWcpOw0KPiAtICAg
IGJkZiA9IFBDSV9CREYyKHBkZXYtPmJ1cywgZGV2Zm4pOw0KPiArICAgIGJkZiA9IFBDSV9CREYo
cGRldi0+YnVzLCBkZXZmbik7DQo+IA0KPiAgICAgIGlmICggYW1kX2lvbW11X3Jlc2VydmVfZG9t
YWluX3VuaXR5X3VubWFwKA0KPiAgICAgICAgICAgICAgIHBkZXYtPmRvbWFpbiwNCj4gICAgICAg
ICAgICAgICBpdnJzX21hcHBpbmdzW2l2cnNfbWFwcGluZ3NbYmRmXS5kdGVfcmVxdWVzdG9yX2lk
XS51bml0eV9tYXApICkNCj4gICAgICAgICAgQU1EX0lPTU1VX1dBUk4oIiVwZDogdW5pdHkgdW5t
YXBwaW5nIGZhaWxlZCBmb3IgJXBwXG4iLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICBwZGV2
LT5kb21haW4sICZQQ0lfU0JERjIocGRldi0+c2VnLCBiZGYpKTsNCj4gKyAgICAgICAgICAgICAg
ICAgICAgICAgcGRldi0+ZG9tYWluLCAmUENJX1NCREYocGRldi0+c2VnLCBiZGYpKTsNCj4gDQo+
ICAgICAgYW1kX2lvbW11X3F1YXJhbnRpbmVfdGVhcmRvd24ocGRldik7DQo+IA0KPiBAQCAtNjgx
LDcgKzY4MSw3IEBAIHN0YXRpYyBpbnQgY2ZfY2hlY2sgYW1kX2lvbW11X3JlbW92ZV9kZXYNCj4g
DQo+ICBzdGF0aWMgaW50IGNmX2NoZWNrIGFtZF9pb21tdV9ncm91cF9pZCh1MTYgc2VnLCB1OCBi
dXMsIHU4IGRldmZuKQ0KPiAgew0KPiAtICAgIGludCBiZGYgPSBQQ0lfQkRGMihidXMsIGRldmZu
KTsNCj4gKyAgICB1bnNpZ25lZCBpbnQgYmRmID0gUENJX0JERihidXMsIGRldmZuKTsNCj4gDQo+
ICAgICAgcmV0dXJuIChiZGYgPCBpdnJzX2JkZl9lbnRyaWVzKSA/IGdldF9kbWFfcmVxdWVzdG9y
X2lkKHNlZywgYmRmKSA6IGJkZjsNCj4gIH0NCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvYXRzLmgNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYXRzLmgNCj4gQEAgLTM1
LDcgKzM1LDcgQEAgc3RhdGljIGlubGluZSBpbnQgcGNpX2F0c19lbmFibGVkKGludCBzZQ0KPiAg
ICAgIHBvcyA9IHBjaV9maW5kX2V4dF9jYXBhYmlsaXR5KHNlZywgYnVzLCBkZXZmbiwgUENJX0VY
VF9DQVBfSURfQVRTKTsNCj4gICAgICBCVUdfT04oIXBvcyk7DQo+IA0KPiAtICAgIHZhbHVlID0g
cGNpX2NvbmZfcmVhZDE2KFBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pLCBwb3MgKyBBVFNfUkVH
X0NUTCk7DQo+ICsgICAgdmFsdWUgPSBwY2lfY29uZl9yZWFkMTYoUENJX1NCREYoc2VnLCBidXMs
IGRldmZuKSwgcG9zICsgQVRTX1JFR19DVEwpOw0KPiANCj4gICAgICByZXR1cm4gdmFsdWUgJiBB
VFNfRU5BQkxFOw0KPiAgfQ0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0K
PiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPiBAQCAtNTUzLDcgKzU1Myw3
IEBAIGludCBfX2luaXQgcGNpX3JvX2RldmljZShpbnQgc2VnLCBpbnQgYnUNCj4gICAgICAgICAg
bWVtc2V0KHBzZWctPnJvX21hcCwgMCwgc3opOw0KPiAgICAgIH0NCj4gDQo+IC0gICAgX19zZXRf
Yml0KFBDSV9CREYyKGJ1cywgZGV2Zm4pLCBwc2VnLT5yb19tYXApOw0KPiArICAgIF9fc2V0X2Jp
dChQQ0lfQkRGKGJ1cywgZGV2Zm4pLCBwc2VnLT5yb19tYXApOw0KPiAgICAgIF9wY2lfaGlkZV9k
ZXZpY2UocGRldik7DQo+IA0KPiAgICAgIHJldHVybiAwOw0KPiBAQCAtOTU3LDcgKzk1Nyw3IEBA
IHN0YXRpYyBpbnQgZGVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4NCj4gICBvdXQ6DQo+ICAg
ICAgaWYgKCByZXQgKQ0KPiAgICAgICAgICBwcmludGsoWEVOTE9HX0dfRVJSICIlcGQ6IGRlYXNz
aWduICglcHApIGZhaWxlZCAoJWQpXG4iLA0KPiAtICAgICAgICAgICAgICAgZCwgJlBDSV9TQkRG
MyhzZWcsIGJ1cywgZGV2Zm4pLCByZXQpOw0KPiArICAgICAgICAgICAgICAgZCwgJlBDSV9TQkRG
KHNlZywgYnVzLCBkZXZmbiksIHJldCk7DQo+IA0KPiAgICAgIHJldHVybiByZXQ7DQo+ICB9DQo+
IEBAIC0xNDA2LDcgKzE0MDYsNyBAQCBzdGF0aWMgaW50IGlvbW11X2FkZF9kZXZpY2Uoc3RydWN0
IHBjaV9kDQo+ICAgICAgICAgIHJjID0gaW9tbXVfY2FsbChoZC0+cGxhdGZvcm1fb3BzLCBhZGRf
ZGV2aWNlLCBkZXZmbiwNCj4gcGNpX3RvX2RldihwZGV2KSk7DQo+ICAgICAgICAgIGlmICggcmMg
KQ0KPiAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HICJJT01NVTogYWRkICVwcCBm
YWlsZWQgKCVkKVxuIiwNCj4gLSAgICAgICAgICAgICAgICAgICAmUENJX1NCREYzKHBkZXYtPnNl
ZywgcGRldi0+YnVzLCBkZXZmbiksIHJjKTsNCj4gKyAgICAgICAgICAgICAgICAgICAmUENJX1NC
REYocGRldi0+c2VnLCBwZGV2LT5idXMsIGRldmZuKSwgcmMpOw0KPiAgICAgIH0NCj4gIH0NCj4g
DQo+IEBAIC0xNDUyLDcgKzE0NTIsNyBAQCBzdGF0aWMgaW50IGlvbW11X3JlbW92ZV9kZXZpY2Uo
c3RydWN0IHBjDQo+ICAgICAgICAgICAgICBjb250aW51ZTsNCj4gDQo+ICAgICAgICAgIHByaW50
ayhYRU5MT0dfRVJSICJJT01NVTogcmVtb3ZlICVwcCBmYWlsZWQgKCVkKVxuIiwNCj4gLSAgICAg
ICAgICAgICAgICZQQ0lfU0JERjMocGRldi0+c2VnLCBwZGV2LT5idXMsIGRldmZuKSwgcmMpOw0K
PiArICAgICAgICAgICAgICAgJlBDSV9TQkRGKHBkZXYtPnNlZywgcGRldi0+YnVzLCBkZXZmbiks
IHJjKTsNCj4gICAgICAgICAgcmV0dXJuIHJjOw0KPiAgICAgIH0NCj4gDQo+IEBAIC0xNTM2LDcg
KzE1MzYsNyBAQCBzdGF0aWMgaW50IGFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqDQo+ICAg
ZG9uZToNCj4gICAgICBpZiAoIHJjICkNCj4gICAgICAgICAgcHJpbnRrKFhFTkxPR19HX1dBUk5J
TkcgIiVwZDogYXNzaWduICglcHApIGZhaWxlZCAoJWQpXG4iLA0KPiAtICAgICAgICAgICAgICAg
ZCwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pLCByYyk7DQo+ICsgICAgICAgICAgICAgICBk
LCAmUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSwgcmMpOw0KPiAgICAgIC8qIFRoZSBkZXZpY2Ug
aXMgYXNzaWduZWQgdG8gZG9tX2lvIHNvIG1hcmsgaXQgYXMgcXVhcmFudGluZWQgKi8NCj4gICAg
ICBlbHNlIGlmICggZCA9PSBkb21faW8gKQ0KPiAgICAgICAgICBwZGV2LT5xdWFyYW50aW5lID0g
dHJ1ZTsNCj4gQEAgLTE2NDcsNyArMTY0Nyw3IEBAIGludCBpb21tdV9kb19wY2lfZG9tY3RsKA0K
PiANCj4gICAgICAgICAgc2VnID0gZG9tY3RsLT51LmdldF9kZXZpY2VfZ3JvdXAubWFjaGluZV9z
YmRmID4+IDE2Ow0KPiAgICAgICAgICBidXMgPSBQQ0lfQlVTKGRvbWN0bC0+dS5nZXRfZGV2aWNl
X2dyb3VwLm1hY2hpbmVfc2JkZik7DQo+IC0gICAgICAgIGRldmZuID0gUENJX0RFVkZOMihkb21j
dGwtPnUuZ2V0X2RldmljZV9ncm91cC5tYWNoaW5lX3NiZGYpOw0KPiArICAgICAgICBkZXZmbiA9
IFBDSV9ERVZGTihkb21jdGwtPnUuZ2V0X2RldmljZV9ncm91cC5tYWNoaW5lX3NiZGYpOw0KPiAg
ICAgICAgICBtYXhfc2RldnMgPSBkb21jdGwtPnUuZ2V0X2RldmljZV9ncm91cC5tYXhfc2RldnM7
DQo+ICAgICAgICAgIHNkZXZzID0gZG9tY3RsLT51LmdldF9kZXZpY2VfZ3JvdXAuc2Rldl9hcnJh
eTsNCj4gDQo+IEBAIC0xNjk3LDcgKzE2OTcsNyBAQCBpbnQgaW9tbXVfZG9fcGNpX2RvbWN0bCgN
Cj4gDQo+ICAgICAgICAgIHNlZyA9IG1hY2hpbmVfc2JkZiA+PiAxNjsNCj4gICAgICAgICAgYnVz
ID0gUENJX0JVUyhtYWNoaW5lX3NiZGYpOw0KPiAtICAgICAgICBkZXZmbiA9IFBDSV9ERVZGTjIo
bWFjaGluZV9zYmRmKTsNCj4gKyAgICAgICAgZGV2Zm4gPSBQQ0lfREVWRk4obWFjaGluZV9zYmRm
KTsNCj4gDQo+ICAgICAgICAgIHBjaWRldnNfbG9jaygpOw0KPiAgICAgICAgICByZXQgPSBkZXZp
Y2VfYXNzaWduZWQoc2VnLCBidXMsIGRldmZuKTsNCj4gQEAgLTE3MDYsNyArMTcwNiw3IEBAIGlu
dCBpb21tdV9kb19wY2lfZG9tY3RsKA0KPiAgICAgICAgICAgICAgaWYgKCByZXQgKQ0KPiAgICAg
ICAgICAgICAgew0KPiAgICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19JTkZPICIlcHAg
YWxyZWFkeSBhc3NpZ25lZCwgb3Igbm9uLWV4aXN0ZW50XG4iLA0KPiAtICAgICAgICAgICAgICAg
ICAgICAgICAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbikpOw0KPiArICAgICAgICAgICAgICAg
ICAgICAgICAmUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSk7DQo+ICAgICAgICAgICAgICAgICAg
cmV0ID0gLUVJTlZBTDsNCj4gICAgICAgICAgICAgIH0NCj4gICAgICAgICAgfQ0KPiBAQCAtMTc0
Miw3ICsxNzQyLDcgQEAgaW50IGlvbW11X2RvX3BjaV9kb21jdGwoDQo+IA0KPiAgICAgICAgICBz
ZWcgPSBtYWNoaW5lX3NiZGYgPj4gMTY7DQo+ICAgICAgICAgIGJ1cyA9IFBDSV9CVVMobWFjaGlu
ZV9zYmRmKTsNCj4gLSAgICAgICAgZGV2Zm4gPSBQQ0lfREVWRk4yKG1hY2hpbmVfc2JkZik7DQo+
ICsgICAgICAgIGRldmZuID0gUENJX0RFVkZOKG1hY2hpbmVfc2JkZik7DQo+IA0KPiAgICAgICAg
ICBwY2lkZXZzX2xvY2soKTsNCj4gICAgICAgICAgcmV0ID0gZGVhc3NpZ25fZGV2aWNlKGQsIHNl
ZywgYnVzLCBkZXZmbik7DQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9kbWFy
LmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2RtYXIuYw0KPiBAQCAtMjIy
LDcgKzIyMiw3IEBAIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqYWNwaV9maW5kX21hdGNoZWQNCj4g
ICAgICAgICAgICAgIGNvbnRpbnVlOw0KPiANCj4gICAgICAgICAgZm9yIChpID0gMDsgaSA8IGRy
aGQtPnNjb3BlLmRldmljZXNfY250OyBpKyspDQo+IC0gICAgICAgICAgICBpZiAoIGRyaGQtPnNj
b3BlLmRldmljZXNbaV0gPT0gUENJX0JERjIoYnVzLCBkZXZmbikgKQ0KPiArICAgICAgICAgICAg
aWYgKCBkcmhkLT5zY29wZS5kZXZpY2VzW2ldID09IFBDSV9CREYoYnVzLCBkZXZmbikgKQ0KPiAg
ICAgICAgICAgICAgICAgIHJldHVybiBkcmhkOw0KPiANCj4gICAgICAgICAgaWYgKCB0ZXN0X2Jp
dChidXMsIGRyaGQtPnNjb3BlLmJ1c2VzKSApDQo+IEBAIC0xMDYyLDcgKzEwNjIsNyBAQCBpbnQg
Y2ZfY2hlY2sgaW50ZWxfaW9tbXVfZ2V0X3Jlc2VydmVkX2RlDQo+IA0KPiAgICAgICAgICByYyA9
IGZ1bmMoUEZOX0RPV04ocm1yci0+YmFzZV9hZGRyZXNzKSwNCj4gICAgICAgICAgICAgICAgICAg
IFBGTl9VUChybXJyLT5lbmRfYWRkcmVzcykgLSBQRk5fRE9XTihybXJyLT5iYXNlX2FkZHJlc3Mp
LA0KPiAtICAgICAgICAgICAgICAgICAgUENJX1NCREYyKHJtcnItPnNlZ21lbnQsIGJkZikuc2Jk
ZiwgY3R4dCk7DQo+ICsgICAgICAgICAgICAgICAgICBQQ0lfU0JERihybXJyLT5zZWdtZW50LCBi
ZGYpLnNiZGYsIGN0eHQpOw0KPiANCj4gICAgICAgICAgaWYgKCB1bmxpa2VseShyYyA8IDApICkN
Cj4gICAgICAgICAgICAgIHJldHVybiByYzsNCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvdnRkL2ludHJlbWFwLmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lu
dHJlbWFwLmMNCj4gQEAgLTQ5OCw3ICs0OTgsNyBAQCBzdGF0aWMgdm9pZCBzZXRfbXNpX3NvdXJj
ZV9pZChzdHJ1Y3QgcGNpDQo+ICAgICAgICAgIGNhc2UgNDogc3EgPSBTUV8xM19JR05PUkVfMTsg
YnJlYWs7DQo+ICAgICAgICAgIGRlZmF1bHQ6IHNxID0gU1FfQUxMXzE2OyBicmVhazsNCj4gICAg
ICAgICAgfQ0KPiAtICAgICAgICBzZXRfaXJlX3NpZChpcmUsIFNWVF9WRVJJRllfU0lEX1NRLCBz
cSwgUENJX0JERjIoYnVzLCBkZXZmbikpOw0KPiArICAgICAgICBzZXRfaXJlX3NpZChpcmUsIFNW
VF9WRVJJRllfU0lEX1NRLCBzcSwgUENJX0JERihidXMsIGRldmZuKSk7DQo+ICAgICAgICAgIGJy
ZWFrOw0KPiANCj4gICAgICBjYXNlIERFVl9UWVBFX1BDSToNCj4gQEAgLTUwOCw3ICs1MDgsNyBA
QCBzdGF0aWMgdm9pZCBzZXRfbXNpX3NvdXJjZV9pZChzdHJ1Y3QgcGNpDQo+ICAgICAgICAgIGlm
ICggcmV0ID09IDAgKSAvKiBpbnRlZ3JhdGVkIFBDSSBkZXZpY2UgKi8NCj4gICAgICAgICAgew0K
PiAgICAgICAgICAgICAgc2V0X2lyZV9zaWQoaXJlLCBTVlRfVkVSSUZZX1NJRF9TUSwgU1FfQUxM
XzE2LA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgUENJX0JERjIoYnVzLCBkZXZmbikpOw0K
PiArICAgICAgICAgICAgICAgICAgICAgICAgUENJX0JERihidXMsIGRldmZuKSk7DQo+ICAgICAg
ICAgIH0NCj4gICAgICAgICAgZWxzZSBpZiAoIHJldCA9PSAxICkgLyogZmluZCB1cHN0cmVhbSBi
cmlkZ2UgKi8NCj4gICAgICAgICAgew0KPiBAQCAtNTE3LDcgKzUxNyw3IEBAIHN0YXRpYyB2b2lk
IHNldF9tc2lfc291cmNlX2lkKHN0cnVjdCBwY2kNCj4gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAoYnVzIDw8IDgpIHwgcGRldi0+YnVzKTsNCj4gICAgICAgICAgICAgIGVsc2UNCj4gICAg
ICAgICAgICAgICAgICBzZXRfaXJlX3NpZChpcmUsIFNWVF9WRVJJRllfU0lEX1NRLCBTUV9BTExf
MTYsDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJX0JERjIoYnVzLCBkZXZmbikp
Ow0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9CREYoYnVzLCBkZXZmbikpOw0K
PiAgICAgICAgICB9DQo+ICAgICAgICAgIGVsc2UNCj4gICAgICAgICAgICAgIGRwcmludGsoWEVO
TE9HX1dBUk5JTkcgVlREUFJFRklYLA0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92
dGQvaW9tbXUuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0K
PiBAQCAtOTM4LDIxICs5MzgsMjEgQEAgc3RhdGljIGludCBpb21tdV9wYWdlX2ZhdWx0X2RvX29u
ZShzdHJ1Yw0KPiAgICAgICAgICAgICAgICAgIkRNQVI6WyVzXSBSZXF1ZXN0IGRldmljZSBbJXBw
XSAiDQo+ICAgICAgICAgICAgICAgICAiZmF1bHQgYWRkciAlIlBSSXg2NCJcbiIsDQo+ICAgICAg
ICAgICAgICAgICAodHlwZSA/ICJETUEgUmVhZCIgOiAiRE1BIFdyaXRlIiksDQo+IC0gICAgICAg
ICAgICAgICAmUENJX1NCREYyKHNlZywgc291cmNlX2lkKSwgYWRkcik7DQo+ICsgICAgICAgICAg
ICAgICAmUENJX1NCREYoc2VnLCBzb3VyY2VfaWQpLCBhZGRyKTsNCj4gICAgICAgICAga2luZCA9
ICJETUFSIjsNCj4gICAgICAgICAgYnJlYWs7DQo+ICAgICAgY2FzZSBJTlRSX1JFTUFQOg0KPiAg
ICAgICAgICBwcmludGsoWEVOTE9HX0dfV0FSTklORyBWVERQUkVGSVgNCj4gICAgICAgICAgICAg
ICAgICJJTlRSLVJFTUFQOiBSZXF1ZXN0IGRldmljZSBbJXBwXSAiDQo+ICAgICAgICAgICAgICAg
ICAiZmF1bHQgaW5kZXggJSJQUkl4NjQiXG4iLA0KPiAtICAgICAgICAgICAgICAgJlBDSV9TQkRG
MihzZWcsIHNvdXJjZV9pZCksIGFkZHIgPj4gNDgpOw0KPiArICAgICAgICAgICAgICAgJlBDSV9T
QkRGKHNlZywgc291cmNlX2lkKSwgYWRkciA+PiA0OCk7DQo+ICAgICAgICAgIGtpbmQgPSAiSU5U
Ui1SRU1BUCI7DQo+ICAgICAgICAgIGJyZWFrOw0KPiAgICAgIGRlZmF1bHQ6DQo+ICAgICAgICAg
IHByaW50ayhYRU5MT0dfR19XQVJOSU5HIFZURFBSRUZJWA0KPiAgICAgICAgICAgICAgICAgIlVO
S05PV046IFJlcXVlc3QgZGV2aWNlIFslcHBdICINCj4gICAgICAgICAgICAgICAgICJmYXVsdCBh
ZGRyICUiUFJJeDY0IlxuIiwNCj4gLSAgICAgICAgICAgICAgICZQQ0lfU0JERjIoc2VnLCBzb3Vy
Y2VfaWQpLCBhZGRyKTsNCj4gKyAgICAgICAgICAgICAgICZQQ0lfU0JERihzZWcsIHNvdXJjZV9p
ZCksIGFkZHIpOw0KPiAgICAgICAgICBraW5kID0gIlVOS05PV04iOw0KPiAgICAgICAgICBicmVh
azsNCj4gICAgICB9DQo+IEBAIC05NjEsNyArOTYxLDcgQEAgc3RhdGljIGludCBpb21tdV9wYWdl
X2ZhdWx0X2RvX29uZShzdHJ1Yw0KPiAgICAgICAgICAgICBraW5kLCBmYXVsdF9yZWFzb24sIHJl
YXNvbik7DQo+IA0KPiAgICAgIGlmICggaW9tbXVfdmVyYm9zZSAmJiBmYXVsdF90eXBlID09IERN
QV9SRU1BUCApDQo+IC0gICAgICAgIHByaW50X3Z0ZF9lbnRyaWVzKGlvbW11LCBQQ0lfQlVTKHNv
dXJjZV9pZCksIFBDSV9ERVZGTjIoc291cmNlX2lkKSwNCj4gKyAgICAgICAgcHJpbnRfdnRkX2Vu
dHJpZXMoaW9tbXUsIFBDSV9CVVMoc291cmNlX2lkKSwgUENJX0RFVkZOKHNvdXJjZV9pZCksDQo+
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFkZHIgPj4gUEFHRV9TSElGVCk7DQo+IA0KPiAg
ICAgIHJldHVybiAwOw0KPiBAQCAtMTAzOSw3ICsxMDM5LDcgQEAgc3RhdGljIHZvaWQgX19kb19p
b21tdV9wYWdlX2ZhdWx0KHN0cnVjdA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBzb3VyY2VfaWQsIGd1ZXN0X2FkZHIpOw0KPiANCj4gICAgICAgICAgcGNpX2NoZWNrX2Rpc2Fi
bGVfZGV2aWNlKGlvbW11LT5kcmhkLT5zZWdtZW50LA0KPiAtICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgUENJX0JVUyhzb3VyY2VfaWQpLCBQQ0lfREVWRk4yKHNvdXJjZV9pZCkpOw0K
PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJX0JVUyhzb3VyY2VfaWQpLCBQ
Q0lfREVWRk4oc291cmNlX2lkKSk7DQo+IA0KPiAgICAgICAgICBmYXVsdF9pbmRleCsrOw0KPiAg
ICAgICAgICBpZiAoIGZhdWx0X2luZGV4ID4gY2FwX251bV9mYXVsdF9yZWdzKGlvbW11LT5jYXAp
ICkNCj4gQEAgLTE1NDEsNyArMTU0MSw3IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29u
ZSgNCj4gICAgICAgICAgICAgICAgICBjaGVja19jbGVhbnVwX2RvbWlkX21hcChkb21haW4sIHBk
ZXYsIGlvbW11KTsNCj4gICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSDQo+ICAgICAgICAg
ICAgICAgICAgICAgIiVwcDogdW5leHBlY3RlZCBjb250ZXh0IGVudHJ5ICUwMTZseF8lMDE2bHgN
Cj4gKGV4cGVjdGVkICUwMTZseF8lMDE2bHgpXG4iLA0KPiAtICAgICAgICAgICAgICAgICAgICZQ
Q0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSwNCj4gKyAgICAgICAgICAgICAgICAgICAmUENJX1NC
REYoc2VnLCBidXMsIGRldmZuKSwNCj4gICAgICAgICAgICAgICAgICAgICAodWludDY0X3QpKHJl
cyA+PiA2NCksICh1aW50NjRfdClyZXMsDQo+ICAgICAgICAgICAgICAgICAgICAgKHVpbnQ2NF90
KShvbGQgPj4gNjQpLCAodWludDY0X3Qpb2xkKTsNCj4gICAgICAgICAgICAgIHJjID0gLUVJTFNF
UTsNCj4gQEAgLTE1NzEsNyArMTU3MSw3IEBAIGludCBkb21haW5fY29udGV4dF9tYXBwaW5nX29u
ZSgNCj4gICAgICAgICAgaWYgKCAhKG1vZGUgJiAoTUFQX09XTkVSX0RZSU5HIHwgTUFQX1NJTkdM
RV9ERVZJQ0UpKSApDQo+ICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcgVlREUFJF
RklYDQo+ICAgICAgICAgICAgICAgICAgICAgIiAlcHA6IHJlYXNzaWdubWVudCBtYXkgY2F1c2Ug
JXBkIGRhdGEgY29ycnVwdGlvblxuIiwNCj4gLSAgICAgICAgICAgICAgICAgICAmUENJX1NCREYz
KHNlZywgYnVzLCBkZXZmbiksIHByZXZfZG9tKTsNCj4gKyAgICAgICAgICAgICAgICAgICAmUENJ
X1NCREYoc2VnLCBidXMsIGRldmZuKSwgcHJldl9kb20pOw0KPiANCj4gICAgICAgICAgd3JpdGVf
YXRvbWljKCZjb250ZXh0LT5sbywgbGN0eHQubG8pOw0KPiAgICAgICAgICAvKiBObyBiYXJyaWVy
IHNob3VsZCBiZSBuZWVkZWQgYmV0d2VlbiB0aGVzZSB0d28uICovDQo+IEBAIC0xNTgxLDcgKzE1
ODEsNyBAQCBpbnQgZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoDQo+ICAgICAgaW9tbXVfc3lu
Y19jYWNoZShjb250ZXh0LCBzaXplb2Yoc3RydWN0IGNvbnRleHRfZW50cnkpKTsNCj4gICAgICBz
cGluX3VubG9jaygmaW9tbXUtPmxvY2spOw0KPiANCj4gLSAgICByYyA9IGlvbW11X2ZsdXNoX2Nv
bnRleHRfZGV2aWNlKGlvbW11LCBwcmV2X2RpZCwgUENJX0JERjIoYnVzLA0KPiBkZXZmbiksDQo+
ICsgICAgcmMgPSBpb21tdV9mbHVzaF9jb250ZXh0X2RldmljZShpb21tdSwgcHJldl9kaWQsIFBD
SV9CREYoYnVzLCBkZXZmbiksDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBETUFfQ0NNRF9NQVNLX05PQklULCAhcHJldl9kb20pOw0KPiAgICAgIGZsdXNoX2Rldl9pb3Rs
YiA9ICEhZmluZF9hdHNfZGV2X2RyaGQoaW9tbXUpOw0KPiAgICAgIHJldCA9IGlvbW11X2ZsdXNo
X2lvdGxiX2RzaShpb21tdSwgcHJldl9kaWQsICFwcmV2X2RvbSwNCj4gZmx1c2hfZGV2X2lvdGxi
KTsNCj4gQEAgLTE2ODgsNyArMTY4OCw3IEBAIHN0YXRpYyBpbnQgZG9tYWluX2NvbnRleHRfbWFw
cGluZyhzdHJ1Y3QNCj4gICAgICBjYXNlIERFVl9UWVBFX1BDSV9IT1NUX0JSSURHRToNCj4gICAg
ICAgICAgaWYgKCBpb21tdV9kZWJ1ZyApDQo+ICAgICAgICAgICAgICBwcmludGsoVlREUFJFRklY
ICIlcGQ6SG9zdGJyaWRnZTogc2tpcCAlcHAgbWFwXG4iLA0KPiAtICAgICAgICAgICAgICAgICAg
IGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pKTsNCj4gKyAgICAgICAgICAgICAg
ICAgICBkb21haW4sICZQQ0lfU0JERihzZWcsIGJ1cywgZGV2Zm4pKTsNCj4gICAgICAgICAgaWYg
KCAhaXNfaGFyZHdhcmVfZG9tYWluKGRvbWFpbikgKQ0KPiAgICAgICAgICAgICAgcmV0dXJuIC1F
UEVSTTsNCj4gICAgICAgICAgYnJlYWs7DQo+IEBAIC0xNzEyLDcgKzE3MTIsNyBAQCBzdGF0aWMg
aW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3RydWN0DQo+IA0KPiAgICAgICAgICBpZiAoIGlv
bW11X2RlYnVnICkNCj4gICAgICAgICAgICAgIHByaW50ayhWVERQUkVGSVggIiVwZDpQQ0llOiBt
YXAgJXBwXG4iLA0KPiAtICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcs
IGJ1cywgZGV2Zm4pKTsNCj4gKyAgICAgICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERihz
ZWcsIGJ1cywgZGV2Zm4pKTsNCj4gICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGlu
Z19vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwNCj4gcGRldiwNCj4gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgREVWSUNFX0RPTUlEKGRvbWFpbiwg
cGRldiksIHBnZF9tYWRkciwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgbW9kZSk7DQo+IEBAIC0xNzM3LDcgKzE3MzcsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9j
b250ZXh0X21hcHBpbmcoc3RydWN0DQo+IA0KPiAgICAgICAgICBpZiAoIGlvbW11X2RlYnVnICkN
Cj4gICAgICAgICAgICAgIHByaW50ayhWVERQUkVGSVggIiVwZDpQQ0k6IG1hcCAlcHBcbiIsDQo+
IC0gICAgICAgICAgICAgICAgICAgZG9tYWluLCAmUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbikp
Ow0KPiArICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGKHNlZywgYnVzLCBkZXZm
bikpOw0KPiANCj4gICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfbWFwcGluZ19vbmUoZG9t
YWluLCBkcmhkLT5pb21tdSwgYnVzLCBkZXZmbiwNCj4gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgcGRldiwgREVWSUNFX0RPTUlEKGRvbWFpbiwgcGRldiksDQo+IEBA
IC0xODAyLDcgKzE4MDIsNyBAQCBzdGF0aWMgaW50IGRvbWFpbl9jb250ZXh0X21hcHBpbmcoc3Ry
dWN0DQo+IA0KPiAgICAgIGRlZmF1bHQ6DQo+ICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiBW
VERQUkVGSVgsICIlcGQ6dW5rbm93bigldSk6ICVwcFxuIiwNCj4gLSAgICAgICAgICAgICAgICBk
b21haW4sIHBkZXYtPnR5cGUsICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSk7DQo+ICsgICAg
ICAgICAgICAgICAgZG9tYWluLCBwZGV2LT50eXBlLCAmUENJX1NCREYoc2VnLCBidXMsIGRldmZu
KSk7DQo+ICAgICAgICAgIHJldCA9IC1FSU5WQUw7DQo+ICAgICAgICAgIGJyZWFrOw0KPiAgICAg
IH0NCj4gQEAgLTE4NTEsNyArMTg1MSw3IEBAIGludCBkb21haW5fY29udGV4dF91bm1hcF9vbmUo
DQo+ICAgICAgaW9tbXVfc3luY19jYWNoZShjb250ZXh0LCBzaXplb2Yoc3RydWN0IGNvbnRleHRf
ZW50cnkpKTsNCj4gDQo+ICAgICAgcmMgPSBpb21tdV9mbHVzaF9jb250ZXh0X2RldmljZShpb21t
dSwgaW9tbXVfZG9taWQsDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQ
Q0lfQkRGMihidXMsIGRldmZuKSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIFBDSV9CREYoYnVzLCBkZXZmbiksDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBETUFfQ0NNRF9NQVNLX05PQklULCAwKTsNCj4gDQo+ICAgICAgZmx1c2hfZGV2X2lv
dGxiID0gISFmaW5kX2F0c19kZXZfZHJoZChpb21tdSk7DQo+IEBAIC0xOTEwLDcgKzE5MTAsNyBA
QCBzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZHJoZF91bml0ICpkb21hDQo+ICAgICAgY2FzZSBE
RVZfVFlQRV9QQ0lfSE9TVF9CUklER0U6DQo+ICAgICAgICAgIGlmICggaW9tbXVfZGVidWcgKQ0K
PiAgICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiJXBkOkhvc3RicmlkZ2U6IHNraXAgJXBw
IHVubWFwXG4iLA0KPiAtICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhzZWcs
IGJ1cywgZGV2Zm4pKTsNCj4gKyAgICAgICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERihz
ZWcsIGJ1cywgZGV2Zm4pKTsNCj4gICAgICAgICAgcmV0dXJuIEVSUl9QVFIoaXNfaGFyZHdhcmVf
ZG9tYWluKGRvbWFpbikgPyAwIDogLUVQRVJNKTsNCj4gDQo+ICAgICAgY2FzZSBERVZfVFlQRV9Q
Q0llX0JSSURHRToNCj4gQEAgLTE5MjQsNyArMTkyNCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg
YWNwaV9kcmhkX3VuaXQgKmRvbWENCj4gDQo+ICAgICAgICAgIGlmICggaW9tbXVfZGVidWcgKQ0K
PiAgICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiJXBkOlBDSWU6IHVubWFwICVwcFxuIiwN
Cj4gLSAgICAgICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZu
KSk7DQo+ICsgICAgICAgICAgICAgICAgICAgZG9tYWluLCAmUENJX1NCREYoc2VnLCBidXMsIGRl
dmZuKSk7DQo+ICAgICAgICAgIHJldCA9IGRvbWFpbl9jb250ZXh0X3VubWFwX29uZShkb21haW4s
IGlvbW11LCBidXMsIGRldmZuKTsNCj4gICAgICAgICAgaWYgKCAhcmV0ICYmIGRldmZuID09IHBk
ZXYtPmRldmZuICYmIGF0c19kZXZpY2UocGRldiwgZHJoZCkgPiAwICkNCj4gICAgICAgICAgICAg
IGRpc2FibGVfYXRzX2RldmljZShwZGV2KTsNCj4gQEAgLTE5MzcsNyArMTkzNyw3IEBAIHN0YXRp
YyBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRvbWENCj4gDQo+ICAgICAgICAgIGlmICgg
aW9tbXVfZGVidWcgKQ0KPiAgICAgICAgICAgICAgcHJpbnRrKFZURFBSRUZJWCAiJXBkOlBDSTog
dW5tYXAgJXBwXG4iLA0KPiAtICAgICAgICAgICAgICAgICAgIGRvbWFpbiwgJlBDSV9TQkRGMyhz
ZWcsIGJ1cywgZGV2Zm4pKTsNCj4gKyAgICAgICAgICAgICAgICAgICBkb21haW4sICZQQ0lfU0JE
RihzZWcsIGJ1cywgZGV2Zm4pKTsNCj4gICAgICAgICAgcmV0ID0gZG9tYWluX2NvbnRleHRfdW5t
YXBfb25lKGRvbWFpbiwgaW9tbXUsIGJ1cywgZGV2Zm4pOw0KPiAgICAgICAgICBpZiAoIHJldCAp
DQo+ICAgICAgICAgICAgICBicmVhazsNCj4gQEAgLTE5NzAsNyArMTk3MCw3IEBAIHN0YXRpYyBj
b25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRvbWENCj4gDQo+ICAgICAgZGVmYXVsdDoNCj4g
ICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWCwgIiVwZDp1bmtub3duKCV1KTog
JXBwXG4iLA0KPiAtICAgICAgICAgICAgICAgIGRvbWFpbiwgcGRldi0+dHlwZSwgJlBDSV9TQkRG
MyhzZWcsIGJ1cywgZGV2Zm4pKTsNCj4gKyAgICAgICAgICAgICAgICBkb21haW4sIHBkZXYtPnR5
cGUsICZQQ0lfU0JERihzZWcsIGJ1cywgZGV2Zm4pKTsNCj4gICAgICAgICAgcmV0dXJuIEVSUl9Q
VFIoLUVJTlZBTCk7DQo+ICAgICAgfQ0KPiANCj4gQEAgLTIxODEsOSArMjE4MSw3IEBAIHN0YXRp
YyBpbnQgY2ZfY2hlY2sgaW50ZWxfaW9tbXVfYWRkX2RldmkNCj4gDQo+ICAgICAgZm9yX2VhY2hf
cm1ycl9kZXZpY2UgKCBybXJyLCBiZGYsIGkgKQ0KPiAgICAgIHsNCj4gLSAgICAgICAgaWYgKCBy
bXJyLT5zZWdtZW50ID09IHBkZXYtPnNlZyAmJg0KPiAtICAgICAgICAgICAgIFBDSV9CVVMoYmRm
KSA9PSBwZGV2LT5idXMgJiYNCj4gLSAgICAgICAgICAgICBQQ0lfREVWRk4yKGJkZikgPT0gZGV2
Zm4gKQ0KPiArICAgICAgICBpZiAoIHJtcnItPnNlZ21lbnQgPT0gcGRldi0+c2VnICYmIGJkZiA9
PSBQQ0lfQkRGKHBkZXYtPmJ1cywgZGV2Zm4pICkNCj4gICAgICAgICAgew0KPiAgICAgICAgICAg
ICAgLyoNCj4gICAgICAgICAgICAgICAqIGlvbW11X2FkZF9kZXZpY2UoKSBpcyBvbmx5IGNhbGxl
ZCBmb3IgdGhlIGhhcmR3YXJlDQo+IEBAIC0yMjM5LDkgKzIyMzcsNyBAQCBzdGF0aWMgaW50IGNm
X2NoZWNrIGludGVsX2lvbW11X3JlbW92ZV9kDQo+IA0KPiAgICAgIGZvcl9lYWNoX3JtcnJfZGV2
aWNlICggcm1yciwgYmRmLCBpICkNCj4gICAgICB7DQo+IC0gICAgICAgIGlmICggcm1yci0+c2Vn
bWVudCAhPSBwZGV2LT5zZWcgfHwNCj4gLSAgICAgICAgICAgICBQQ0lfQlVTKGJkZikgIT0gcGRl
di0+YnVzIHx8DQo+IC0gICAgICAgICAgICAgUENJX0RFVkZOMihiZGYpICE9IGRldmZuICkNCj4g
KyAgICAgICAgaWYgKCBybXJyLT5zZWdtZW50ICE9IHBkZXYtPnNlZyB8fCBiZGYgIT0gUENJX0JE
RihwZGV2LT5idXMsIGRldmZuKSApDQo+ICAgICAgICAgICAgICBjb250aW51ZTsNCj4gDQo+ICAg
ICAgICAgIC8qDQo+IEBAIC0yNjY4LDggKzI2NjQsNyBAQCBzdGF0aWMgaW50IGNmX2NoZWNrIHJl
YXNzaWduX2RldmljZV9vd25lDQo+IA0KPiAgICAgICAgICBmb3JfZWFjaF9ybXJyX2RldmljZSgg
cm1yciwgYmRmLCBpICkNCj4gICAgICAgICAgICAgIGlmICggcm1yci0+c2VnbWVudCA9PSBwZGV2
LT5zZWcgJiYNCj4gLSAgICAgICAgICAgICAgICAgUENJX0JVUyhiZGYpID09IHBkZXYtPmJ1cyAm
Jg0KPiAtICAgICAgICAgICAgICAgICBQQ0lfREVWRk4yKGJkZikgPT0gZGV2Zm4gKQ0KPiArICAg
ICAgICAgICAgICAgICBiZGYgPT0gUENJX0JERihwZGV2LT5idXMsIGRldmZuKSApDQo+ICAgICAg
ICAgICAgICB7DQo+ICAgICAgICAgICAgICAgICAgLyoNCj4gICAgICAgICAgICAgICAgICAgKiBB
bnkgUk1SUiBmbGFnIGlzIGFsd2F5cyBpZ25vcmVkIHdoZW4gcmVtb3ZlIGEgZGV2aWNlLA0KPiBA
QCAtMjcxMyw5ICsyNzA4LDcgQEAgc3RhdGljIGludCBjZl9jaGVjayBpbnRlbF9pb21tdV9hc3Np
Z25fZA0KPiAgICAgICAqLw0KPiAgICAgIGZvcl9lYWNoX3JtcnJfZGV2aWNlKCBybXJyLCBiZGYs
IGkgKQ0KPiAgICAgIHsNCj4gLSAgICAgICAgaWYgKCBybXJyLT5zZWdtZW50ID09IHNlZyAmJg0K
PiAtICAgICAgICAgICAgIFBDSV9CVVMoYmRmKSA9PSBidXMgJiYNCj4gLSAgICAgICAgICAgICBQ
Q0lfREVWRk4yKGJkZikgPT0gZGV2Zm4gJiYNCj4gKyAgICAgICAgaWYgKCBybXJyLT5zZWdtZW50
ID09IHNlZyAmJiBiZGYgPT0gUENJX0JERihidXMsIGRldmZuKSAmJg0KPiAgICAgICAgICAgICAg
IHJtcnItPnNjb3BlLmRldmljZXNfY250ID4gMSApDQo+ICAgICAgICAgIHsNCj4gICAgICAgICAg
ICAgIGJvb2xfdCByZWxheGVkID0gISEoZmxhZyAmIFhFTl9ET01DVExfREVWX1JETV9SRUxBWEVE
KTsNCj4gQEAgLTI3MjUsNyArMjcxOCw3IEBAIHN0YXRpYyBpbnQgY2ZfY2hlY2sgaW50ZWxfaW9t
bXVfYXNzaWduX2QNCj4gICAgICAgICAgICAgICAgICAgICAiIHdpdGggc2hhcmVkIFJNUlIgYXQg
JSJQUkl4NjQiIGZvciAlcGQuXG4iLA0KPiAgICAgICAgICAgICAgICAgICAgIHJlbGF4ZWQgPyBY
RU5MT0dfV0FSTklORyA6IFhFTkxPR19FUlIsDQo+ICAgICAgICAgICAgICAgICAgICAgcmVsYXhl
ZCA/ICJyaXNreSIgOiAiZGlzYWxsb3dlZCIsDQo+IC0gICAgICAgICAgICAgICAgICAgJlBDSV9T
QkRGMyhzZWcsIGJ1cywgZGV2Zm4pLCBybXJyLT5iYXNlX2FkZHJlc3MsIGQpOw0KPiArICAgICAg
ICAgICAgICAgICAgICZQQ0lfU0JERihzZWcsIGJ1cywgZGV2Zm4pLCBybXJyLT5iYXNlX2FkZHJl
c3MsIGQpOw0KPiAgICAgICAgICAgICAgaWYgKCAhcmVsYXhlZCApDQo+ICAgICAgICAgICAgICAg
ICAgcmV0dXJuIC1FUEVSTTsNCj4gICAgICAgICAgfQ0KPiBAQCAtMjczNyw5ICsyNzMwLDcgQEAg
c3RhdGljIGludCBjZl9jaGVjayBpbnRlbF9pb21tdV9hc3NpZ25fZA0KPiAgICAgIC8qIFNldHVw
IHJtcnIgaWRlbnRpdHkgbWFwcGluZyAqLw0KPiAgICAgIGZvcl9lYWNoX3JtcnJfZGV2aWNlKCBy
bXJyLCBiZGYsIGkgKQ0KPiAgICAgIHsNCj4gLSAgICAgICAgaWYgKCBybXJyLT5zZWdtZW50ID09
IHNlZyAmJg0KPiAtICAgICAgICAgICAgIFBDSV9CVVMoYmRmKSA9PSBidXMgJiYNCj4gLSAgICAg
ICAgICAgICBQQ0lfREVWRk4yKGJkZikgPT0gZGV2Zm4gKQ0KPiArICAgICAgICBpZiAoIHJtcnIt
PnNlZ21lbnQgPT0gc2VnICYmIGJkZiA9PSBQQ0lfQkRGKGJ1cywgZGV2Zm4pICkNCj4gICAgICAg
ICAgew0KPiAgICAgICAgICAgICAgcmV0ID0gaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhkLCBwMm1f
YWNjZXNzX3J3LCBybXJyLQ0KPiA+YmFzZV9hZGRyZXNzLA0KPiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgZmxhZyk7DQo+IEBAIC0y
NzYyLDkgKzI3NTMsNyBAQCBzdGF0aWMgaW50IGNmX2NoZWNrIGludGVsX2lvbW11X2Fzc2lnbl9k
DQo+IA0KPiAgICAgIGZvcl9lYWNoX3JtcnJfZGV2aWNlKCBybXJyLCBiZGYsIGkgKQ0KPiAgICAg
IHsNCj4gLSAgICAgICAgaWYgKCBybXJyLT5zZWdtZW50ID09IHNlZyAmJg0KPiAtICAgICAgICAg
ICAgIFBDSV9CVVMoYmRmKSA9PSBidXMgJiYNCj4gLSAgICAgICAgICAgICBQQ0lfREVWRk4yKGJk
ZikgPT0gZGV2Zm4gKQ0KPiArICAgICAgICBpZiAoIHJtcnItPnNlZ21lbnQgPT0gc2VnICYmIGJk
ZiA9PSBQQ0lfQkRGKGJ1cywgZGV2Zm4pICkNCj4gICAgICAgICAgew0KPiAgICAgICAgICAgICAg
aW50IHJjID0gaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhkLCBwMm1fYWNjZXNzX3gsDQo+ICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmJhc2VfYWRkcmVz
cywNCj4gQEAgLTI3OTEsNyArMjc4MCw3IEBAIHN0YXRpYyBpbnQgY2ZfY2hlY2sgaW50ZWxfaW9t
bXVfZ3JvdXBfaWQNCj4gICAgICBpZiAoIGZpbmRfdXBzdHJlYW1fYnJpZGdlKHNlZywgJmJ1cywg
JmRldmZuLCAmc2VjYnVzKSA8IDAgKQ0KPiAgICAgICAgICByZXR1cm4gLUVOT0RFVjsNCj4gDQo+
IC0gICAgcmV0dXJuIFBDSV9CREYyKGJ1cywgZGV2Zm4pOw0KPiArICAgIHJldHVybiBQQ0lfQkRG
KGJ1cywgZGV2Zm4pOw0KPiAgfQ0KPiANCj4gIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGNmX2No
ZWNrIHZ0ZF9zdXNwZW5kKHZvaWQpDQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0
ZC9xdWlya3MuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvcXVpcmtzLmMN
Cj4gQEAgLTExNSw3ICsxMTUsNyBAQCBib29sIGlzX2F6YWxpYV90bGJfZW5hYmxlZChjb25zdCBz
dHJ1Y3QNCj4gICAgICAgICAgcmV0dXJuIHRydWU7DQo+IA0KPiAgICAgIC8qIENoZWNrIGZvciB0
aGUgc3BlY2lmaWMgZGV2aWNlLiAqLw0KPiAtICAgIHNiZGYgPSBQQ0lfU0JERjIoZHJoZC0+c2Vn
bWVudCwgZHJoZC0+c2NvcGUuZGV2aWNlc1swXSk7DQo+ICsgICAgc2JkZiA9IFBDSV9TQkRGKGRy
aGQtPnNlZ21lbnQsIGRyaGQtPnNjb3BlLmRldmljZXNbMF0pOw0KPiAgICAgIGlmICggcGNpX2Nv
bmZfcmVhZDE2KHNiZGYsIFBDSV9WRU5ET1JfSUQpICE9IFBDSV9WRU5ET1JfSURfSU5URUwgfHwN
Cj4gICAgICAgICAgIHBjaV9jb25mX3JlYWQxNihzYmRmLCBQQ0lfREVWSUNFX0lEKSAhPSAweDNh
M2UgKQ0KPiAgICAgICAgICByZXR1cm4gdHJ1ZTsNCj4gQEAgLTQ0Niw3ICs0NDYsNyBAQCBpbnQg
bWVfd2lmaV9xdWlyayhzdHJ1Y3QgZG9tYWluICpkb21haW4sDQo+ICAgICAgICAgICAgICByZXR1
cm4gMDsNCj4gDQo+ICAgICAgICAgIC8qIGlmIGRldmljZSBpcyBXTEFOIGRldmljZSwgbWFwIE1F
IHBoYW50b20gZGV2aWNlIDA6My43ICovDQo+IC0gICAgICAgIGlkID0gcGNpX2NvbmZfcmVhZDMy
KFBDSV9TQkRGMygwLCBidXMsIGRldmZuKSwgMCk7DQo+ICsgICAgICAgIGlkID0gcGNpX2NvbmZf
cmVhZDMyKFBDSV9TQkRGKDAsIGJ1cywgZGV2Zm4pLCAwKTsNCj4gICAgICAgICAgc3dpdGNoIChp
ZCkNCj4gICAgICAgICAgew0KPiAgICAgICAgICAgICAgY2FzZSAweDQyMzI4MDg2Og0KPiBAQCAt
NDcwLDcgKzQ3MCw3IEBAIGludCBtZV93aWZpX3F1aXJrKHN0cnVjdCBkb21haW4gKmRvbWFpbiwN
Cj4gICAgICAgICAgICAgIHJldHVybiAwOw0KPiANCj4gICAgICAgICAgLyogaWYgZGV2aWNlIGlz
IFdMQU4gZGV2aWNlLCBtYXAgTUUgcGhhbnRvbSBkZXZpY2UgMDoyMi43ICovDQo+IC0gICAgICAg
IGlkID0gcGNpX2NvbmZfcmVhZDMyKFBDSV9TQkRGMygwLCBidXMsIGRldmZuKSwgMCk7DQo+ICsg
ICAgICAgIGlkID0gcGNpX2NvbmZfcmVhZDMyKFBDSV9TQkRGKDAsIGJ1cywgZGV2Zm4pLCAwKTsN
Cj4gICAgICAgICAgc3dpdGNoIChpZCkNCj4gICAgICAgICAgew0KPiAgICAgICAgICAgICAgY2Fz
ZSAweDAwODc4MDg2OiAgICAgICAgLyogS2lsbWVyIFBlYWsgKi8NCj4gLS0tIGEveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvdnRkL3V0aWxzLmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvdnRkL3V0aWxzLmMNCj4gQEAgLTk2LDcgKzk2LDcgQEAgdm9pZCBwcmludF92dGRfZW50cmll
cyhzdHJ1Y3QgdnRkX2lvbW11DQo+ICAgICAgdTMyIGxfaW5kZXgsIGxldmVsOw0KPiANCj4gICAg
ICBwcmludGsoInByaW50X3Z0ZF9lbnRyaWVzOiBpb21tdSAjJXUgZGV2ICVwcCBnbWZuICUiUFJJ
X2dmbiJcbiIsDQo+IC0gICAgICAgICAgIGlvbW11LT5pbmRleCwgJlBDSV9TQkRGMyhpb21tdS0+
ZHJoZC0+c2VnbWVudCwgYnVzLCBkZXZmbiksDQo+ICsgICAgICAgICAgIGlvbW11LT5pbmRleCwg
JlBDSV9TQkRGKGlvbW11LT5kcmhkLT5zZWdtZW50LCBidXMsIGRldmZuKSwNCj4gICAgICAgICAg
ICAgZ21mbik7DQo+IA0KPiAgICAgIGlmICggaW9tbXUtPnJvb3RfbWFkZHIgPT0gMCApDQo+IC0t
LSBhL3hlbi9kcml2ZXJzL3BjaS9wY2kuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wY2kvcGNpLmMN
Cj4gQEAgLTQ2LDEyICs0NiwxMiBAQCBpbnQgcGNpX2ZpbmRfbmV4dF9jYXAodTE2IHNlZywgdTgg
YnVzLCB1DQo+IA0KPiAgICAgIHdoaWxlICggdHRsLS0gKQ0KPiAgICAgIHsNCj4gLSAgICAgICAg
cG9zID0gcGNpX2NvbmZfcmVhZDgoUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbiksIHBvcyk7DQo+
ICsgICAgICAgIHBvcyA9IHBjaV9jb25mX3JlYWQ4KFBDSV9TQkRGKHNlZywgYnVzLCBkZXZmbiks
IHBvcyk7DQo+ICAgICAgICAgIGlmICggcG9zIDwgMHg0MCApDQo+ICAgICAgICAgICAgICBicmVh
azsNCj4gDQo+ICAgICAgICAgIHBvcyAmPSB+MzsNCj4gLSAgICAgICAgaWQgPSBwY2lfY29uZl9y
ZWFkOChQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSwgcG9zICsNCj4gUENJX0NBUF9MSVNUX0lE
KTsNCj4gKyAgICAgICAgaWQgPSBwY2lfY29uZl9yZWFkOChQQ0lfU0JERihzZWcsIGJ1cywgZGV2
Zm4pLCBwb3MgKyBQQ0lfQ0FQX0xJU1RfSUQpOw0KPiANCj4gICAgICAgICAgaWYgKCBpZCA9PSAw
eGZmICkNCj4gICAgICAgICAgICAgIGJyZWFrOw0KPiBAQCAtOTMsNyArOTMsNyBAQCBpbnQgcGNp
X2ZpbmRfbmV4dF9leHRfY2FwYWJpbGl0eShpbnQgc2VnDQo+ICAgICAgaW50IHR0bCA9IDQ4MDsg
LyogMzg0MCBieXRlcywgbWluaW11bSA4IGJ5dGVzIHBlciBjYXBhYmlsaXR5ICovDQo+ICAgICAg
aW50IHBvcyA9IG1heChzdGFydCwgMHgxMDApOw0KPiANCj4gLSAgICBoZWFkZXIgPSBwY2lfY29u
Zl9yZWFkMzIoUENJX1NCREYzKHNlZywgYnVzLCBkZXZmbiksIHBvcyk7DQo+ICsgICAgaGVhZGVy
ID0gcGNpX2NvbmZfcmVhZDMyKFBDSV9TQkRGKHNlZywgYnVzLCBkZXZmbiksIHBvcyk7DQo+IA0K
PiAgICAgIC8qDQo+ICAgICAgICogSWYgd2UgaGF2ZSBubyBjYXBhYmlsaXRpZXMsIHRoaXMgaXMg
aW5kaWNhdGVkIGJ5IGNhcCBJRCwNCj4gQEAgLTEwOSw3ICsxMDksNyBAQCBpbnQgcGNpX2ZpbmRf
bmV4dF9leHRfY2FwYWJpbGl0eShpbnQgc2VnDQo+ICAgICAgICAgIHBvcyA9IFBDSV9FWFRfQ0FQ
X05FWFQoaGVhZGVyKTsNCj4gICAgICAgICAgaWYgKCBwb3MgPCAweDEwMCApDQo+ICAgICAgICAg
ICAgICBicmVhazsNCj4gLSAgICAgICAgaGVhZGVyID0gcGNpX2NvbmZfcmVhZDMyKFBDSV9TQkRG
MyhzZWcsIGJ1cywgZGV2Zm4pLCBwb3MpOw0KPiArICAgICAgICBoZWFkZXIgPSBwY2lfY29uZl9y
ZWFkMzIoUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSwgcG9zKTsNCj4gICAgICB9DQo+ICAgICAg
cmV0dXJuIDA7DQo+ICB9DQo+IEBAIC0xNjIsNyArMTYyLDcgQEAgY29uc3QgY2hhciAqX19pbml0
IHBhcnNlX3BjaV9zZWcoY29uc3QgYw0KPiAgICAgIGVsc2UNCj4gICAgICAgICAgZnVuYyA9IDA7
DQo+ICAgICAgaWYgKCBzZWcgIT0gKHNlZ19wID8gKHUxNilzZWcgOiAwKSB8fA0KPiAtICAgICAg
ICAgYnVzICE9IFBDSV9CVVMoUENJX0JERjIoYnVzLCAwKSkgfHwNCj4gKyAgICAgICAgIGJ1cyAh
PSBQQ0lfQlVTKFBDSV9CREYoYnVzLCAwKSkgfHwNCj4gICAgICAgICAgIGRldiAhPSBQQ0lfU0xP
VChQQ0lfREVWRk4oZGV2LCAwKSkgfHwNCj4gICAgICAgICAgIGZ1bmMgIT0gUENJX0ZVTkMoUENJ
X0RFVkZOKDAsIGZ1bmMpKSApDQo+ICAgICAgICAgIHJldHVybiBOVUxMOw0KPiAtLS0gYS94ZW4v
ZHJpdmVycy92aWRlby92Z2EuYw0KPiArKysgYi94ZW4vZHJpdmVycy92aWRlby92Z2EuYw0KPiBA
QCAtMTIyLDkgKzEyMiw5IEBAIHZvaWQgX19pbml0IHZpZGVvX2VuZGJvb3Qodm9pZCkNCj4gICAg
ICAgICAgICAgICAgICBwY2lkZXZzX3VubG9jaygpOw0KPiANCj4gICAgICAgICAgICAgICAgICBp
ZiAoICFwZGV2IHx8DQo+IC0gICAgICAgICAgICAgICAgICAgICBwY2lfY29uZl9yZWFkMTYoUENJ
X1NCREYzKDAsIGJ1cywgZGV2Zm4pLA0KPiArICAgICAgICAgICAgICAgICAgICAgcGNpX2NvbmZf
cmVhZDE2KFBDSV9TQkRGKDAsIGJ1cywgZGV2Zm4pLA0KPiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIFBDSV9DTEFTU19ERVZJQ0UpICE9IDB4MDMwMCB8fA0KPiAtICAgICAg
ICAgICAgICAgICAgICAgIShwY2lfY29uZl9yZWFkMTYoUENJX1NCREYzKDAsIGJ1cywgZGV2Zm4p
LCBQQ0lfQ09NTUFORCkgJg0KPiArICAgICAgICAgICAgICAgICAgICAgIShwY2lfY29uZl9yZWFk
MTYoUENJX1NCREYoMCwgYnVzLCBkZXZmbiksIFBDSV9DT01NQU5EKSAmDQo+ICAgICAgICAgICAg
ICAgICAgICAgICAgIChQQ0lfQ09NTUFORF9JTyB8IFBDSV9DT01NQU5EX01FTU9SWSkpICkNCj4g
ICAgICAgICAgICAgICAgICAgICAgY29udGludWU7DQo+IA0KPiBAQCAtMTM2LDEyICsxMzYsMTIg
QEAgdm9pZCBfX2luaXQgdmlkZW9fZW5kYm9vdCh2b2lkKQ0KPiAgICAgICAgICAgICAgICAgICAg
ICAgICAgYiA9IDA7DQo+ICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsNCj4gICAgICAg
ICAgICAgICAgICAgICAgY2FzZSAxOg0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgc3dpdGNo
ICggcGNpX2NvbmZfcmVhZDgoUENJX1NCREYzKDAsIGIsIGRmKSwNCj4gKyAgICAgICAgICAgICAg
ICAgICAgICAgIHN3aXRjaCAoIHBjaV9jb25mX3JlYWQ4KFBDSV9TQkRGKDAsIGIsIGRmKSwNCj4g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9IRUFE
RVJfVFlQRSkgKQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgew0KPiAgICAgICAgICAgICAg
ICAgICAgICAgICAgY2FzZSBQQ0lfSEVBREVSX1RZUEVfQlJJREdFOg0KPiAgICAgICAgICAgICAg
ICAgICAgICAgICAgY2FzZSBQQ0lfSEVBREVSX1RZUEVfQ0FSREJVUzoNCj4gLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBpZiAoIHBjaV9jb25mX3JlYWQxNihQQ0lfU0JERjMoMCwgYiwgZGYp
LA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmICggcGNpX2NvbmZfcmVhZDE2KFBD
SV9TQkRGKDAsIGIsIGRmKSwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBQQ0lfQlJJREdFX0NPTlRST0wpICYNCj4gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIFBDSV9CUklER0VfQ1RMX1ZHQSApDQo+ICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vcGNpLmgN
Cj4gKysrIGIveGVuL2luY2x1ZGUveGVuL3BjaS5oDQo+IEBAIC0yOSwxNiArMjksMjEgQEANCj4g
ICNkZWZpbmUgUENJX0JVUyhiZGYpICAgICgoKGJkZikgPj4gOCkgJiAweGZmKQ0KPiAgI2RlZmlu
ZSBQQ0lfU0xPVChiZGYpICAgKCgoYmRmKSA+PiAzKSAmIDB4MWYpDQo+ICAjZGVmaW5lIFBDSV9G
VU5DKGJkZikgICAoKGJkZikgJiAweDA3KQ0KPiAtI2RlZmluZSBQQ0lfREVWRk4oZCxmKSAgKCgo
KGQpICYgMHgxZikgPDwgMykgfCAoKGYpICYgMHgwNykpDQo+IC0jZGVmaW5lIFBDSV9ERVZGTjIo
YmRmKSAoKGJkZikgJiAweGZmKQ0KPiAtI2RlZmluZSBQQ0lfQkRGKGIsZCxmKSAgKCgoKGIpICYg
MHhmZikgPDwgOCkgfCBQQ0lfREVWRk4oZCxmKSkNCj4gLSNkZWZpbmUgUENJX0JERjIoYixkZikg
ICgoKChiKSAmIDB4ZmYpIDw8IDgpIHwgKChkZikgJiAweGZmKSkNCj4gLSNkZWZpbmUgUENJX1NC
REYocyxiLGQsZikgXA0KPiAtICAgICgocGNpX3NiZGZfdCl7IC5zYmRmID0gKCgocykgJiAweGZm
ZmYpIDw8IDE2KSB8IFBDSV9CREYoYiwgZCwgZikgfSkNCj4gLSNkZWZpbmUgUENJX1NCREYyKHMs
YmRmKSBcDQo+ICsNCj4gKyNkZWZpbmUgUENJX0RFVkZOMV8oZGYpICAgKChkZikgJiAweGZmKQ0K
PiArI2RlZmluZSBQQ0lfREVWRk4yXyhkLCBmKSAoKCgoZCkgJiAweDFmKSA8PCAzKSB8ICgoZikg
JiA3KSkNCj4gKyNkZWZpbmUgUENJX1NCREY0XyhzLCBiLCBkLCBmLi4uKSBcDQo+ICsgICAgKChw
Y2lfc2JkZl90KXsgLnNiZGYgPSAoKChzKSAmIDB4ZmZmZikgPDwgMTYpIHwgUENJX0JERihiLCBk
LCAjI2YpIH0pDQo+ICsjZGVmaW5lIFBDSV9TQkRGM18gUENJX1NCREY0Xw0KPiArI2RlZmluZSBQ
Q0lfU0JERjJfKHMsIGJkZikgXA0KPiAgICAgICgocGNpX3NiZGZfdCl7IC5zYmRmID0gKCgocykg
JiAweGZmZmYpIDw8IDE2KSB8ICgoYmRmKSAmIDB4ZmZmZikgfSkNCj4gLSNkZWZpbmUgUENJX1NC
REYzKHMsYixkZikgXA0KPiAtICAgICgocGNpX3NiZGZfdCl7IC5zYmRmID0gKCgocykgJiAweGZm
ZmYpIDw8IDE2KSB8IFBDSV9CREYyKGIsIGRmKSB9KQ0KPiArDQo+ICsjZGVmaW5lIFBDSV9fKHdo
YXQsIG5yKSBQQ0lfIyN3aGF0IyNuciMjXw0KPiArI2RlZmluZSBQQ0lfKHdoYXQsIG5yKSAgUENJ
X18od2hhdCwgbnIpDQo+ICsNCj4gKyNkZWZpbmUgUENJX0RFVkZOKGQsIGYuLi4pICAgUENJXyhE
RVZGTiwgY291bnRfYXJncyhkLCAjI2YpKShkLCAjI2YpDQo+ICsjZGVmaW5lIFBDSV9CREYoYiwg
ZCwgZi4uLikgICgoKChiKSAmIDB4ZmYpIDw8IDgpIHwgUENJX0RFVkZOKGQsICMjZikpDQo+ICsj
ZGVmaW5lIFBDSV9TQkRGKHMsIGIsIGQuLi4pIFBDSV8oU0JERiwgY291bnRfYXJncyhzLCBiLCAj
I2QpKShzLCBiLCAjI2QpDQo+IA0KPiAgI2RlZmluZSBFQ0FNX1JFR19PRkZTRVQoYWRkcikgICgo
YWRkcikgJiAweDAwMDAwZmZmKQ0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:40:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:40:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308891.524775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh40N-0004eh-OB; Wed, 20 Apr 2022 06:39:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308891.524775; Wed, 20 Apr 2022 06:39:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh40N-0004ea-Jb; Wed, 20 Apr 2022 06:39:59 +0000
Received: by outflank-mailman (input) for mailman id 308891;
 Wed, 20 Apr 2022 06:39:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BWYm=U6=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nh40M-0004eS-3S
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:39:58 +0000
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id afef5691-c074-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 08:39:56 +0200 (CEST)
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Apr 2022 23:39:53 -0700
Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85])
 by orsmga007.jf.intel.com with ESMTP; 19 Apr 2022 23:39:53 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:39:53 -0700
Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 19 Apr 2022 23:39:52 -0700
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 23:39:52 -0700
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 19 Apr 2022 23:39:52 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by MN2PR11MB4095.namprd11.prod.outlook.com (2603:10b6:208:150::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:39:50 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::c4ea:a404:b70b:e54e%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 06:39:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afef5691-c074-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650436796; x=1681972796;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=7rBLHHrGkg/4TvPuK3RUJQbKvkw3gMsspWiitP1t69c=;
  b=KiS3z6YTf6xU/9jnnjhQdDM0AHL3xwzToIEdfhNYBdebCEXOaTcJszBZ
   G70dDQLHBuotcPtlpON4lgVKL1ANFee0iUL366s8AW9sbBsZfI2lAdtkA
   TpzCjR7cJyc2xqzp/8LAu/HpdZJNbYaFzGpz7jCS9dIfGtcZaRbPtDNZ3
   KW4hRm3LR0a7gXFG6DNm1l/USzBrt5W0owqCFH/LqIycohGEK7MVbYdg4
   7f4K09BeqVgLuRGNn2Fyjq4r7MSeW5wEvpfv/JKNveGkWNnkk2/4w49GM
   fGk/X062TAgM+u0qiI14y7yrzWZi/PEp8qii5luLs1hdTl7204Xx14E3F
   Q==;
X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="261555351"
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="261555351"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; 
   d="scan'208";a="555059532"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ADuumaRQXH0P66mVaCPMB7jiWjFxA6ugIRZ8ny9iSpr7eBAk+uwgT9PQxKKSMF96qqHHz6sEyyQ2DSFdzPmmsx+4VMv8A/U/OTDe3VNnJuDfG4AiPkzSKevjPmOdV+GjuQ9TwffvO+NGK16yu6aB120DkChk9D39VPaywUz6Kp1udY+RorH2YnFhqm9x79Xqo618Xo/mnlhbpTsEH9L8vr5YP8lLjPKanR93bXRgkEG7OyGZhCIEqs7whsNHanDwZ3TxQyfec2c3ZvCVcRXH+MVxdAPfvKQa+I76lyRQs0d0CKA1fLZmxAmnqML1/AVi8qHoy7w0/ly5pUjxYYgF0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7rBLHHrGkg/4TvPuK3RUJQbKvkw3gMsspWiitP1t69c=;
 b=XU6Ja0atnHnYU9FaXUuN+wmY/swxH7FwOdxa9HAENy+QOQcVVeKgWG5Duv8KK+5IfU9op0+f0+pXyOlBOxDS9mhaF83DAhQqY86hbTeC+Xnn3GdMujysfOIOES977l6JHGXSGcRpxOAaqpiQC7he47+hUD/eJTujgeW012PKTz3U3dTM09vwPp48KuMOfaHI74hY0n/CezrMpXHqmnTWrMr+mxXZ/aE27rPAo3XTKED7CSJzkdXfTjnRkO6emj1epGzAbj7IgYzosrQ7r8fV/iynNImlCNyitQXK2WV4VIsntu2QL/cWjItaJ6Lbbozny51HnCGp1SgImJvO7qyNbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Tamas K Lengyel <tamas@tklengyel.com>, "Lengyel, Tamas"
	<tamas.lengyel@intel.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Nakajima, Jun" <jun.nakajima@intel.com>, "Beulich, Jan" <JBeulich@suse.com>,
	"Cooper, Andrew" <andrew.cooper3@citrix.com>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>
Subject: RE: [PATCH v5] x86/vmx: add hvm functions to get/set non-register
 state
Thread-Topic: [PATCH v5] x86/vmx: add hvm functions to get/set non-register
 state
Thread-Index: AQHYQE0JDO4TZ1lTNEeFxdnKer9Q96z2J8gAgAJaNrA=
Date: Wed, 20 Apr 2022 06:39:50 +0000
Message-ID: <BN9PR11MB527672E1BF038742F290A7798CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
 <CABfawhk-oCAoz-99LOaOYKD-N1FvRnFvM9_AUCgsPEF16F=VCA@mail.gmail.com>
In-Reply-To: <CABfawhk-oCAoz-99LOaOYKD-N1FvRnFvM9_AUCgsPEF16F=VCA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9e02c5df-8e21-40f4-ad15-08da229891f2
x-ms-traffictypediagnostic: MN2PR11MB4095:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <MN2PR11MB4095DAC0CB6597FE23473CFE8CF59@MN2PR11MB4095.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: T4YR8MwGiD5hEOhMDn8FS0+0NhhGQY7ys3F81kUMvc+t50IQFrM+2SJ7NXv0q3mYkOLWLppAKKucwOXpcOVaAAa5crk87yGnaD/KVJS66283ItI0GZdJp8gofvqztRX6DkSrtuTX2Uocx9xdZv04Hv074bgVc53REnBp0gu9NpXRVCgfoqMZPpeRaPjKE/8L6z1bh8EyRunSP1GfCyycvYGMN9yEgrIjR+EWRnw0L/U9G/cFl84Fx9Wt/fwqHxuWP8DbBKM2R/Vw0I0/UFBzV+w8xcEmUJbzNp57r5NT8qUlFUMBfhvy1xTFr2IW2aJNUcAZaLOkxGPPhP81h2mGLHLD9YV1G7UT7zC+nDFLbJvfzOrotyrW5FAVcPDVLlUkvnRWyl8vXa/owg+f18SceMCZJ6YmAhFflfW1XoQ7XyE4OGU5LOu6evnGrxl7Ma+LUktEHWMTH8V7AQYFigOJihUDmwfveEDh9PMNlzCKkizKja9kaeyT+4s6nGRnTWd37inQWh/vOcn81arTiKtZab9/Lx83Hw6pwEw9ayc3R7o1OB8lluWsg3QCdy28TpAqngw/uGDkt6aP796Zdi9FuaHoLY38jYTYnEDXfBTxJRjRJpN1u5jz54cZgni/2VQUg/kKzQAnBfK44SUQVcPal8m04z7ykfWUauYClKTmZrm2Lrmopy6xht5DxapjUwKnHjm9/v6sJiMDPc8aSRCx7w==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66476007)(5660300002)(8936002)(66556008)(66946007)(4744005)(82960400001)(38070700005)(38100700002)(122000001)(52536014)(508600001)(76116006)(6636002)(316002)(26005)(55016003)(71200400001)(64756008)(186003)(66446008)(4326008)(7696005)(9686003)(53546011)(6506007)(33656002)(86362001)(8676002)(54906003)(110136005);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZjVLQlNLQ2RUd1A0SytEZDBYYjRlUWc2TXBtUTR3UTNOcERrL290RnluVGxs?=
 =?utf-8?B?UDdqdytlb0VvemQxZFBFNUg5bW9ubEZDQ29qU1Y1TElDVkxFNGh6cVNWaGtK?=
 =?utf-8?B?KyswVGJTblFhK3hUSklGc2xUbDVhWWFaMHFDQVMxUkxxdzNEamQrZGJtTGN5?=
 =?utf-8?B?MDFlUHdjV2ZUbWc1TUl3aW9lZmVYYmRsZFBhNlN3amUrSmYrMTVMQ2ZKOU9o?=
 =?utf-8?B?WldycW5ON2haWHVKbVJYd0cza0N4MDJWQW0yWUFGQjlYdVUyaDBLdWFwZHdj?=
 =?utf-8?B?Q0xqbVl2WWJrZlFFd3lKakR6RlNZUEhnZmR2SUZvRHVKSUpOcy9XaURQNEJZ?=
 =?utf-8?B?QjFONlZCdFJLVlJ2dzJZdjByYTZiaTBYdlNXaytuVTV1YThObFBGdzkvY09O?=
 =?utf-8?B?RW0yMUN5V0hwVVY3UWFEMHJ0aDJJdUNTRURlZlBmM0VsVkc3VUdzaTdkZEtk?=
 =?utf-8?B?cTlPRGJGQ2lTLzN6Y0cxL1h5U3BXbmtMK2t0c3BMaURuUTMvRkdmT3kvdVQv?=
 =?utf-8?B?cHhPVlJ5dDJock1RUnd4Z2hXMWcyWmtDRmJqRllyT1lkMXFzUHdyUXhTcEFp?=
 =?utf-8?B?R3VQdm05aURCcWFOVDUxZit5bzdobWc1a0hwYkVJbFBML3MrY2ZUenBaeWNM?=
 =?utf-8?B?eXFjUEMxSFZsQ2ZuRVhhRmZKUFlwd2VsWkR2MUNDN3ZwQ1NLZWZieUkrMVlD?=
 =?utf-8?B?VVRUZzU5QndBVi9xNkJVMWRXamY1SmNwcEhVbnBuMEloTVEvdHV5UUoxVUtE?=
 =?utf-8?B?RHdjNmp1bUpVbG00cVBVRUhSRHExOTVuUS9vc0Z2REhQa3A0UThtR0toNDJn?=
 =?utf-8?B?NEVuUVh5R0dDdERxcEpQdzN4WGFRdWNSajhqeUFMVnpHd2xxZmtidnpqdzdH?=
 =?utf-8?B?RU5FOWtkejlReXJVcjNVSlNnNmFOemFCNWsvcEo1Q01zZzVQd0craEl3ZURH?=
 =?utf-8?B?c3FyYk1YOHkrSWcvZFFnbHBCeVd6ZzNFVDhEQSs1Z1NCRkNZOWNnc2tLQ3Y0?=
 =?utf-8?B?WVVPNlZ3V243SEtJU2hIWEplNENMSzZERmR1MlRtV0tVM3JPK2VoUTBIcVpO?=
 =?utf-8?B?MXZBVjd0QkJ3N0I2TjNjb2ZKQ3o5YkU0T2ZDN1JkWktXZzJlLzZXdk9oUTNV?=
 =?utf-8?B?OThGRzdTUzBNcjhudkw5VU11ZURhQ3didTJTSDFvdTlkdnFDZzc2Q1B1QkNM?=
 =?utf-8?B?Q2dhazl4TWN3L0lRc3NLdXJXblV1Z0tKcUpFMkg2SFhEUDBIeTZZNDVQV2xJ?=
 =?utf-8?B?dXlBeDdLbVhldnBXMmFrVHdWaTBKU0k2RGwvMW91dEdVb21FbVk1TUZSYVlz?=
 =?utf-8?B?dmlMYlhObnU3VkNYSWhtTHlwUWZDakN1NlZsRTQ4WDRzRTVwSmhhdS9JVEQw?=
 =?utf-8?B?N1JuMlBOK1F4M2JlWEUzT3VwSDQrelY1d3o1THZzajNRSmMwczc5Y3BWTU9l?=
 =?utf-8?B?RlNaTDN2WUVjWW1ITzYwVmo2bjlwNFcvYnZvSXdsbERUeHY2ejRWUXN5MWtN?=
 =?utf-8?B?MUZ6dmgwNko4R2dLYUNwOWhyZUgwVHowK3M5OXFvWHNhZVpvVk56SDRTdVBE?=
 =?utf-8?B?Vm1Yak9DUWh3YjR5L1BVdWNlOWxRNVozNzQ1c2JBMjNibXpSL2dxVVg5ZHhP?=
 =?utf-8?B?VnRrbCtKcVcybHRTdURaV1llbU1oZ1JOUHVyUUUrV0szdzdwdTBwbG1ZT0xk?=
 =?utf-8?B?T0REWXdMRDQ4UytSV0gxaEZ1SmNET0tpaTFlblAwdnlXNGlXZk5MSm9nZVdZ?=
 =?utf-8?B?aWRBVzh5c2FoNnVla3lKU3QwaU1rU1BEN3kyWmdDa3dwcGFWWFhremU4TGt1?=
 =?utf-8?B?MW11ZFJhT2NwRFdJUWRrb09GcklYS2ZZYnJFR1BRcU9mUmNtYVllbW93dVlT?=
 =?utf-8?B?WmZ3SXhPMGF1ZEdPeXFhZnRkaUVIbjFZcTROZ0sybGlHb2l2VW8xdERISUV5?=
 =?utf-8?B?N1BSYkprN2IzUi9rRnBKRnJjT0pISDgwYnFkYUJ3bldxMk0rUGpJZmRoUzB3?=
 =?utf-8?B?VjQvQnhWK0dXY0NlNkpJSVVZR0FQMTVaWXllVmxoUVhKQ2xZeWNsTkVlNjR5?=
 =?utf-8?B?aUFNSGRncGZGUFprTHM5MkthaXZ1RkRmMWMrYVhYL0ZQWnpTRDBhR3ZWRHo4?=
 =?utf-8?B?aTZFV1RFWFYzR2dYcVZMNzlKUmNDNWZQYlF1OEF1UXZvRmd3Zk5TUXQwRVIw?=
 =?utf-8?B?RXk0SjdvRGtqS2w0WXZLV1lLNlVzS0grcFpueXVmaUVkOHBObVdHVC9IL0lj?=
 =?utf-8?B?MnZVVVhhN1FZaDJYKzQ5b252RlpTSWYrVWNWTWRZTmNoZCsxa3BPZGNDN1dO?=
 =?utf-8?B?THVVZzZLem1vSmd5blVjVFA4dVJHRkxPSFNEeVBNaGgwVFM5M2VrUT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e02c5df-8e21-40f4-ad15-08da229891f2
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:39:50.3289
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cSipIzXbHl6IWvMx80n9oHRIih7X8sej176QpvGh0YfeDLoAPa6H83cbW2tOSFGq/ra1sqRj1d7Abx6sr3uCtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4095
X-OriginatorOrg: intel.com

PiBGcm9tOiBUYW1hcyBLIExlbmd5ZWwgPHRhbWFzQHRrbGVuZ3llbC5jb20+DQo+IFNlbnQ6IFR1
ZXNkYXksIEFwcmlsIDE5LCAyMDIyIDI6NDMgQU0NCj4gDQo+IE9uIEZyaSwgTWFyIDI1LCAyMDIy
IGF0IDk6MzQgQU0gVGFtYXMgSyBMZW5neWVsIDx0YW1hcy5sZW5neWVsQGludGVsLmNvbT4NCj4g
d3JvdGU6DQo+ID4NCj4gPiBEdXJpbmcgVk0gZm9ya2luZyBhbmQgcmVzZXR0aW5nIGEgZmFpbGVk
IHZtZW50cnkgaGFzIGJlZW4gb2JzZXJ2ZWQgZHVlDQo+ID4gdG8gdGhlIGd1ZXN0IG5vbi1yZWdp
c3RlciBzdGF0ZSBnb2luZyBvdXQtb2Ytc3luYyB3aXRoIHRoZSBndWVzdCByZWdpc3Rlcg0KPiA+
IHN0YXRlLiBGb3IgZXhhbXBsZSwgYSBWTSBmb3JrIHJlc2V0IHJpZ2h0IGFmdGVyIGEgU1RJIGlu
c3RydWN0aW9uIGNhbiB0cmlnZ2VyDQo+ID4gdGhlIGZhaWxlZCBlbnRyeS4gVGhpcyBpcyBkdWUg
dG8gdGhlIGd1ZXN0IG5vbi1yZWdpc3RlciBzdGF0ZSBub3QgYmVpbmcgc2F2ZWQNCj4gPiBmcm9t
IHRoZSBwYXJlbnQgVk0sIHRodXMgdGhlIHJlc2V0IG9wZXJhdGlvbiBvbmx5IGNvcGllcyB0aGUg
cmVnaXN0ZXIgc3RhdGUuDQo+ID4NCj4gPiBGaXggdGhpcyBieSBhZGRpbmcgYSBuZXcgcGFpciBv
ZiBodm0gZnVuY3Rpb25zIHRvIGdldC9zZXQgdGhlIGd1ZXN0DQo+ID4gbm9uLXJlZ2lzdGVyIHN0
YXRlIHNvIHRoYXQgdGhlIG92ZXJhbGwgdkNQVSBzdGF0ZSByZW1haW5zIGluIHN5bmMuDQo+ID4N
Cj4gPiBTaWduZWQtb2ZmLWJ5OiBUYW1hcyBLIExlbmd5ZWwgPHRhbWFzLmxlbmd5ZWxAaW50ZWwu
Y29tPg0KPiA+IC0tLQ0KPiA+IHY1OiBTd2l0Y2ggdG8gaW50ZXJuYWwtb25seSBodm0gZnVuY3Mg
aW5zdGVhZCBvZiBhZGRpbmcgdG8gaHZtX2h3X2NwdQ0KPiANCj4gUGF0Y2ggcGluZy4NCg0KSSdk
IGxpa2UgdG8gaGVhciBvcGluaW9ucyBmcm9tIEFuZHJldy9KYW4gZmlyc3QuIE9idmlvdXNseSB0
aGV5IGhhdmUNCmRpZmZlcmVudCB0aG91Z2h0cyB3aGVuIHJldmlld2luZyB0aGUgZWFybGllciB2
ZXJzaW9ucy4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:46:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:46:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308896.524786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh46I-0006Ft-DR; Wed, 20 Apr 2022 06:46:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308896.524786; Wed, 20 Apr 2022 06:46:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh46I-0006Fm-AE; Wed, 20 Apr 2022 06:46:06 +0000
Received: by outflank-mailman (input) for mailman id 308896;
 Wed, 20 Apr 2022 06:46:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh46G-0006FJ-7w; Wed, 20 Apr 2022 06:46:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh46G-0000hM-5M; Wed, 20 Apr 2022 06:46:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh46F-0007mP-Qn; Wed, 20 Apr 2022 06:46:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh46F-0006f9-QM; Wed, 20 Apr 2022 06:46:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zcOPYjex7GcPaWxKg/ajdmZQ+EtL71j1xgpESmAGptA=; b=ej1FtDHlQEOpwI9obCuq6t2N5L
	8TECF/kTvkkIwhr9PXyGIxjEV+/qxTkmWr6RzlQYj3QIi1tfpROK9vx2Z2KD3c3jRLExKnNfVmA0x
	Re15XiHrBwY+ZZ6ar8/jVh88TrlH8NBU5kAj/U5W/LPexBtXt7Ny0XqG9J1cg2KEkMfw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169545-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169545: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-examine:reboot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b7f73403a3e922c20bb278ba3cfcc3c61930d82a
X-Osstest-Versions-That:
    linux=b2d229d4ddb17db541098b83524d901257e93845
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 06:46:03 +0000

flight 169545 linux-linus real [real]
flight 169557 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169545/
http://logs.test-lab.xenproject.org/osstest/logs/169557/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-examine      8 reboot              fail pass in 169557-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 169495
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169495
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169495
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169495
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169495
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169495
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169495
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169495
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                b7f73403a3e922c20bb278ba3cfcc3c61930d82a
baseline version:
 linux                b2d229d4ddb17db541098b83524d901257e93845

Last test of basis   169495  2022-04-17 23:10:37 Z    2 days
Testing same since   169545  2022-04-19 17:41:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Allen-KH Cheng <allen-kh.cheng@mediatek.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christian Brauner <brauner@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mark Brown <broonie@kernel.org>
  Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
  Mika Westerberg <mika.westerberg@linux.intel.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b2d229d4ddb1..b7f73403a3e9  b7f73403a3e922c20bb278ba3cfcc3c61930d82a -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 06:50:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 06:50:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308905.524797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4AW-0007gF-6S; Wed, 20 Apr 2022 06:50:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308905.524797; Wed, 20 Apr 2022 06:50:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4AW-0007g8-2o; Wed, 20 Apr 2022 06:50:28 +0000
Received: by outflank-mailman (input) for mailman id 308905;
 Wed, 20 Apr 2022 06:50:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh4AU-0007g2-Tk
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 06:50:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 285027fb-c076-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 08:50:25 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-75cnCcgePSm5fYSNI15k_w-1; Wed, 20 Apr 2022 08:50:23 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5838.eurprd04.prod.outlook.com (2603:10a6:803:ea::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 06:50:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 06:50:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 285027fb-c076-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650437425;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2eJBJARYiDwISEluRGDzmWVzhkR1YAnlnbvDxmm916o=;
	b=Jyf+LXGSlAdlPqIYwMwOwsAqriYF7AiP/1b3tgrg08zJw7cuuUKG5jWLnixUM4qYrd3UiB
	GM036OaNzJsaV7Bmjg+OuU0Nmv1YKL9plvaWO7J07FvUqYB0yVjVqYzzxoNrwJQEyxcV31
	D+03xKhxGhia/zfH/xxhUO9EDCTYqpE=
X-MC-Unique: 75cnCcgePSm5fYSNI15k_w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RXvG7LhPFgNvqXgK8tTQM1nzPf6KGTIDyZOJBmgAUyouksZcFOIJL8ojwjIGnvDmwcikF8j3m1fDJ2ctxeh9yLrlqW9wSSY6H2gvkXGhOHS2nGrSg6yFuS3GWiEoXlV0oRgYuiUIZsncFrnAJ6vpOWIHBx4ZQ0QyK1L9LSk+QD0xqP/Yn9jWbLQwZoawDgYE96KB9vIX4PlXZKDqzkl5dHDGJWYf5wnVz7CS75pjbO8yfIusFCenPRfJEYZHtn41Xf0Q4TooYGVVWm4MQi+Jy1O8LuA19iVP0RRyZPuyOFYfEuwhOx4XnWDrWBW6fKPhKj91skvAex+5RoGHjCStaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2eJBJARYiDwISEluRGDzmWVzhkR1YAnlnbvDxmm916o=;
 b=g43X2wjloWReYRVnpPUvYD9cWg48/dMpbILv3KT7ekDbgpAOHM6GN8pUkx5GDluqkmChROSJEMBWC/rh0eNyN4fl4vCk5cdUzpZ2nyuVMOQEfGm/sxYnOqVmgLpy49z3TPcR3g/4tHRYGTxU1VWwH/hmE5gbkzTH9kXTMkKkqiJ3fkA1VQ6+FavQCJHHH6NeFupn9HkyNu9I6Hwo0fNpyk8HBp+jYdiWpQz+BGHg1oolxRPPA7Sa4HhR6BlJtpXLj7Xz+j60Z+b5P+9KSIh19zrF4KkOkfW2HeMd83UjepBNOq1eGrboQorUgWoMtXhgj3v7/Mv3utDSEhaXGZDR/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7a9e02b5-e24e-0b55-e52f-0e45e41eafc6@suse.com>
Date: Wed, 20 Apr 2022 08:50:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register
 state
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "Nakajima, Jun" <jun.nakajima@intel.com>,
 "Cooper, Andrew" <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Pau_Monn=c3=a9=2c_Roger?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 "Lengyel, Tamas" <tamas.lengyel@intel.com>
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
 <CABfawhk-oCAoz-99LOaOYKD-N1FvRnFvM9_AUCgsPEF16F=VCA@mail.gmail.com>
 <BN9PR11MB527672E1BF038742F290A7798CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <BN9PR11MB527672E1BF038742F290A7798CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0023.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7511caaa-8258-44e6-2330-08da229a08a4
X-MS-TrafficTypeDiagnostic: VI1PR04MB5838:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB58381AA384B81FF3C4CB0D5BB3F59@VI1PR04MB5838.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JXX+BqPyA3ZVh7zQxSjcH8GTsJa5SxMa6G9anAfLFl8yQkt6HSPf5nNDyO8sNyaRDGMg2u9OmKWt1jbS2a2dI7B7ktTqW9XwiM0o9pwQdNWNVX0V9qZJ4qnb+yndzKnQsKc7Q1IOMmnjmh5VboVFWYtOeNvDICOpUa3MKa9G48op/niZmLOjk3zIKNDwDDmqdrgSFUYhJBvB3lNimWv0tUotLCYshYO2n8CZ6l6Dm5Tz2DMIB8sagD57HT2I3feZeg/ODGkzXhaazpNjhplPFpK0i3QOWnGK5JGTB78urO+LPvAb8RebHVeDzij00Jq8aGA3p7phlf8yJwCRnS9UpbWHWFSnYq+qe++au/uu/uQrlNTEL1utkRV1Jwl7Ulc0J/Xvu6KjjI4AXgotpqyPDDHtbdoaepJ/Ea9El28cVfX6Jz/ngmIGI0guc3OJoj6JWjiTEkvzsDamgJSN+/s49DRCwe2B214B7vBiWYz/6sGyejYilpHo4nciCdnZ/EgC9Z3wEFA9SR1+bCHB/O5+4uZY5DVwhPIwRHCixe0ZpMYZDrNGEZkFHmmbdyMuFlIihK/J5k5kJDQ071TtHyPBxPqfdMkw3830H7hwt02mbRWtXP9Bi4B38DdHWgz41iufblGZ7GDaeBLrX6MEMhxuVHwLCLNR4sH0wpy3aBa3Xccp3P7ET/LWQi11RCmq5yEpN+y4gyBeO59zYAUyhrWIej0XLE0MTdAF4pG20KlXoxIWdGiTaX/89v6U4fnQ5Wnv
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(38100700002)(316002)(31696002)(4326008)(8676002)(31686004)(2906002)(66556008)(66476007)(54906003)(66946007)(36756003)(5660300002)(8936002)(186003)(508600001)(2616005)(26005)(6486002)(6512007)(53546011)(6506007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NHJya2M1RzlsSXcwMTNRVjZlTW5pN0ZueklLMnVJV2xoMGY4L0FWa3JmUWgv?=
 =?utf-8?B?NzJCN0prZWtteGNBM3c0L0E3Z3F5TzA0alR6NWF3T0RQSzlZb1NjbEpWdmNV?=
 =?utf-8?B?YmpjWitOL00vY0wxVldmbzN1VTVoM0wyeTV6SEJ6N2oybnROS3NhTXJHeERP?=
 =?utf-8?B?Vlc0QzdmZ1lYaHRYWVRWSWhFbitDbDlVQnlYdS9nVjVsdEVENTBKSjYzbjlT?=
 =?utf-8?B?OU92SDhVZEF3cHNvb3RyTEZwY2tYYzArN1drUnFNbHdvYUhWdS93TlUwRXU3?=
 =?utf-8?B?cElJT1JXUktJUDNtdHorODlTb3pWbW03R1JqdW1TWWx6SE43b0t3NXdoU09q?=
 =?utf-8?B?Z0ZIT0xzdnd5ZEtpdFJkL0lBakdCc0k0OFJqdFVVdklhNWJZTnZsemErSHJ4?=
 =?utf-8?B?SFcwSG9yNzd1eDd4ZFdCV3FnNlFuYmRNSUJHZXFwNHlScHRjZ1VNQytPLy9y?=
 =?utf-8?B?RWFZUS9jRE54K0NRM2tDVmFCd0lVOUdwTkpidC9rRjkxYzlkbDhVVGdDZ2Vh?=
 =?utf-8?B?bGN2cm1xdVdQVE42MDN2UURnNXNSYWZJL1BUY1BqOUV5Q3N6dllsblVRYVRy?=
 =?utf-8?B?UHQ0eUVaQkFhTFRXc1NNUVVmMVNGUVA5eGFETnltWXlhdExENTZUcS94TVp1?=
 =?utf-8?B?aDVMenVFOXhidysxNmRKUk92YlcvdWpoWVg5bTNXNzhXa2t4VTZONXdHdDJ3?=
 =?utf-8?B?UHppcDZxRisvY1cvakdDL2d4dTg4RUtLeFhMWXVBS0hiaWttemd0cHpoRm9x?=
 =?utf-8?B?TUVCb24xRUhtT3JhTXJTT3EwTDZST2ljamdTdnhNVzJUTHc5MURyTjhIRGY5?=
 =?utf-8?B?cUpack95UlFUaXlsMzBsM20zTWw4YWZlOXNXaU9RUldxejFSWnZFQnZFeWtq?=
 =?utf-8?B?aWZ2NlVBYlJCbDBybDQzM09qQ3ZjY2dESGMwMFZVUnJsMmpiUGdlOWFDZERl?=
 =?utf-8?B?VTVxRGtZY3B6K3BMWlMzZ0h0NTJGTnBzRkV3cWlvMnRKcWw5THNuLzB1Sldy?=
 =?utf-8?B?aUxTS3lZcW8vSkdjcU9YSFV5eE5xVXBwRC9zdUZmZkZQU2wvZllTVmFNUnYr?=
 =?utf-8?B?SGhJbDIrd1Fud3c2OFRBczA4RjNoWThtcEVCTmsxT1BPcVlkTWR1dHZCczhJ?=
 =?utf-8?B?WktWL2pxcTNMSmJEdXNid1ZlYjZvaHNucVN6dWhuTmJscHhHRkwrK3hDT2xW?=
 =?utf-8?B?Z0JCTHh6NmxPY2dOZVVyVzZyZDlMb0hNZy85aGFma2tEMHhjMTZWeXV1a1Nx?=
 =?utf-8?B?d1JUYlhPUDFIdExUM0ZhSnhTM0tHMC9RVjZ3TElMSEhiS2l4NU4ycjNmTzRi?=
 =?utf-8?B?ZUErQ1A3WnR0Mkc0dGpyN2RNNnk2VnpzemNnTTgxdVYzaXJkR0V0RXNQMTU4?=
 =?utf-8?B?bW40SUR2aGRaK2VIbG8rYlh5OTlvb2xNQWlJRWN2VnMvZnlwQ1FjN3M1eU1v?=
 =?utf-8?B?ZmRPY1NOZlhpUCt3ckgwM0NZMWZCNGlZVDA4czJ3TDczTWlpZ3BPYVQyZURP?=
 =?utf-8?B?aHVwcVVRbUp5dGJhcW4zK3ZVdTZnd0JWNXNUMHRuWldLcjdKODUvcnNHc3ZX?=
 =?utf-8?B?ckdwajVrKzhKcUxLNHBNMUZGSFZFbFRlS3MxZHNRUUxJWGU5QzVTZXJwMFBV?=
 =?utf-8?B?NS93Rnh1M1R3WGRTdURJOWRZR0tqMXdUMlY5SWZmMDcrQnFtU0s3TEVZcCtC?=
 =?utf-8?B?UHpTOWNWaWcxV1drQ21FaHlrTkdPM3M5YmtlaUtCVStLS3VaK3BJZkNrWGRR?=
 =?utf-8?B?eVlJNHgzMzE1OXkySExhQW5CNXd0QjExQXBqeWd1eDJhT2FQVGVJZW5MVXQr?=
 =?utf-8?B?a1lGQVFBd1Jza05HZlFobzZBcG9uNXNvREQ0OXI0V2ZLalRhVUdQTXdINk1r?=
 =?utf-8?B?ZU1HRlBxbWtvNzFZSDFYRnUzQmVYZnBiWC9tK2FMcjJkOGVEcFd2WVFST3Ez?=
 =?utf-8?B?NEk4c3JoNVV4bTQ5SlVsNENFVzk4bXlnejZ6eTVGcEJxRDZmTnB1emplblQ3?=
 =?utf-8?B?czlQazI4SmR1TE5HNXlyazhudVhEM1gzc3d6TXR3ZllRa3VYV0tQZ2pHcW16?=
 =?utf-8?B?TzVTczFhOWJMbHhFKzJSaDNpV1NJbDBqYkc4QmQyWThlZUg5RmVqS3pWL0V0?=
 =?utf-8?B?OTZlY25VckZiSEZpN0JrRFpiWjErTWdGQjRDOVltaTI2b3hjdEtzcklnc1Ar?=
 =?utf-8?B?RzRvc3dIVVZZMnlCS3FDZ2Z4dnd1Umt6dlRPM1BBazVEQm1YNDVsUFlUdFBs?=
 =?utf-8?B?eTdHN3VGTGxhdUdtNVFFZ2RqdzZZdHFIei9EWG40aThJeGFiRHlheFFYS0xR?=
 =?utf-8?B?VkVpY3pSc1Qwb0QveHAvdndqcEIrVVFyKzQ1QkNoQVkzN0hUbUUwdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7511caaa-8258-44e6-2330-08da229a08a4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 06:50:19.2878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bJ9ohq7ayBuz3c/tbFGN5uGxHQ8I+FcP+Q1qImWtoqYCszhnk6OqS4f5l72W1DeqIKLyIEWhEkONKRgxy8I8CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5838

On 20.04.2022 08:39, Tian, Kevin wrote:
>> From: Tamas K Lengyel <tamas@tklengyel.com>
>> Sent: Tuesday, April 19, 2022 2:43 AM
>>
>> On Fri, Mar 25, 2022 at 9:34 AM Tamas K Lengyel <tamas.lengyel@intel.com>
>> wrote:
>>>
>>> During VM forking and resetting a failed vmentry has been observed due
>>> to the guest non-register state going out-of-sync with the guest register
>>> state. For example, a VM fork reset right after a STI instruction can trigger
>>> the failed entry. This is due to the guest non-register state not being saved
>>> from the parent VM, thus the reset operation only copies the register state.
>>>
>>> Fix this by adding a new pair of hvm functions to get/set the guest
>>> non-register state so that the overall vCPU state remains in sync.
>>>
>>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>>> ---
>>> v5: Switch to internal-only hvm funcs instead of adding to hvm_hw_cpu
>>
>> Patch ping.
> 
> I'd like to hear opinions from Andrew/Jan first. Obviously they have
> different thoughts when reviewing the earlier versions.

Well, I certainly would prefer if migration was taken care of at the same
time, but I can understand if Tamas doesn't want to put more time into
getting that case working. Plus, aiui, this solution to his problem won't
prevent the eventual wider scope change to be used also for the specific
purpose here, perhaps by simply fully replacing what is being done now.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:01:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:01:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308910.524808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4LC-0000xY-6r; Wed, 20 Apr 2022 07:01:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308910.524808; Wed, 20 Apr 2022 07:01:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4LC-0000xR-40; Wed, 20 Apr 2022 07:01:30 +0000
Received: by outflank-mailman (input) for mailman id 308910;
 Wed, 20 Apr 2022 07:01:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh4LA-0000xH-MF; Wed, 20 Apr 2022 07:01:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh4LA-0000yh-Kz; Wed, 20 Apr 2022 07:01:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh4LA-0008D0-8Y; Wed, 20 Apr 2022 07:01:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh4LA-0004Dz-7r; Wed, 20 Apr 2022 07:01:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uODfsGT7OX0ove3t6AvN8Vd9ttqCwXkES2tNohtx5aY=; b=tUA3rd7rq2f7jn2uZFb8qSiIkr
	1Dz12jVMIf/oBYHBkjjQWsZZFDflulLC0FfrYgg+tj0NNMa2xwL3aaG8Dbfm7QSVzwDkVzE9kf+7k
	9j0XuFdPRz0RdpgGqYWXU44zk5tXkmmeFP3NPlvdhujdkrKfwz6Uzh/5G7QYuVwD7sNc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169559-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169559: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 07:01:28 +0000

flight 169559 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169559/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  517 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   22 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:03:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:03:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308918.524819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4NY-0001ij-MD; Wed, 20 Apr 2022 07:03:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308918.524819; Wed, 20 Apr 2022 07:03:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4NY-0001ic-IG; Wed, 20 Apr 2022 07:03:56 +0000
Received: by outflank-mailman (input) for mailman id 308918;
 Wed, 20 Apr 2022 07:03:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Vn5Q=U6=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nh4NX-0001iW-6O
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:03:55 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0605.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::605])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 093f2700-c078-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 09:03:52 +0200 (CEST)
Received: from AM6P192CA0048.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::25)
 by DU2PR08MB7238.eurprd08.prod.outlook.com (2603:10a6:10:2d1::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 07:03:50 +0000
Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:82:cafe::57) by AM6P192CA0048.outlook.office365.com
 (2603:10a6:209:82::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Wed, 20 Apr 2022 07:03:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Wed, 20 Apr 2022 07:03:49 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Wed, 20 Apr 2022 07:03:49 +0000
Received: from cb71a672a821.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2C4137E2-1020-4C9A-922D-CD21A3C1D215.1; 
 Wed, 20 Apr 2022 07:03:43 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb71a672a821.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 07:03:43 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM5PR0801MB1923.eurprd08.prod.outlook.com (2603:10a6:203:4c::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Wed, 20 Apr
 2022 07:03:41 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 07:03:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 093f2700-c078-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OaV7eoZZnwRZ5tayvm8VzpcDljwkhumPA8OlFSyKC4A=;
 b=Eyd8hJaoE11xSvmWXyPEla/bJgTr7mewVAo0yv/jKF9+RJsKqes5XDWqvlvaqzvRqlp2MxWCetmtjkAVDyDbvu+01hAQgo2U+5EIUUtQYUOhxlzQ6XgVc0FxKq5smFK4ciMiDdSd0fVIVaN0elA0yhbW7++DQNEpYP4GzPafXBU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KjpJ5M63tDqfv+1npY1Z7XyB+5NwoPhfaKq8wevkMgjXMmvdXRSsuH4oBTNsTID+1l31vmwaCuc+2cc6XNZvuTmwA+q9fH0tdkzydvZYFgliApnitON4a8w2T/lho3u4q8SFZnK4aENHRjRK/CYvQ5v+t9AwNM01CiNpsbiUqKig06i2w2kgVcuYNQGmcs6/JvyNOcBBENmt/Mr+r4l823jZ3oIMhfaNabG5sfhsu9OFB818LeUtqUdtorfD0dnVNNS4CCNLde9m92MKkWI8mNBod3gLBnORxatyM6WpFTEnImg8oSmVb3/sm9TLj7CGaE0a7ozE+Bd+73gm022k5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OaV7eoZZnwRZ5tayvm8VzpcDljwkhumPA8OlFSyKC4A=;
 b=SrUyONTMU8WAfWUoSWqq6GLcLYdeuo87gEYpqvBIHOPgNw6ai/ws9W7szCZSprNNAPDkCCjuNWw+hHno5X0ccZQOdyxzd2uFZKwUE/N1U6Yxo6lOvlTZRloHuOrgE/fDjK05GR2OoKq4ZjmW8pufZA/KpFohqaIB78l92cAcg8vYUwkQ32pfFjtoaDXa7JlitLvhFv2ba/HrmH+mbAcIZTki3RG9xQaJDnOPIJ/vUanz2yiqhh8u2Mi5G8FcsBaanSkToPBwHITbvShphpjM4YhMlAXYl4/IEiNu3hz+5qP4pp8PQXK43t9JwFW8for8Z250NoR7bjCzGrxYG7o6Ww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OaV7eoZZnwRZ5tayvm8VzpcDljwkhumPA8OlFSyKC4A=;
 b=Eyd8hJaoE11xSvmWXyPEla/bJgTr7mewVAo0yv/jKF9+RJsKqes5XDWqvlvaqzvRqlp2MxWCetmtjkAVDyDbvu+01hAQgo2U+5EIUUtQYUOhxlzQ6XgVc0FxKq5smFK4ciMiDdSd0fVIVaN0elA0yhbW7++DQNEpYP4GzPafXBU=
From: Wei Chen <Wei.Chen@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftB
Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftB
Thread-Index: Adg/5aAUG5Xb47xpSru14p+HpAimXgQe+V2AAMnR/dAANAVigAABS20A
Date: Wed, 20 Apr 2022 07:03:41 +0000
Message-ID:
 <PAXPR08MB742058D3041BA2D97AA05F1D9EF59@PAXPR08MB7420.eurprd08.prod.outlook.com>
References:
 <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop>
 <PAXPR08MB7420786607A15FA5027BF4579EF29@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204191752390.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204191752390.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 713F648679E7B4418F3EB5700D5690C3.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: c0192ec5-4ab9-4c9c-46b3-08da229bebce
x-ms-traffictypediagnostic:
	AM5PR0801MB1923:EE_|AM5EUR03FT061:EE_|DU2PR08MB7238:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR08MB72386E79026EA0A2E9F439339EF59@DU2PR08MB7238.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 N9bqbSqVFKwovizPNTXA/hRYNVfhSKvTELBnlcZaV7RFKQVUoGlEH2kLahpuQ6swleQuCJUqCZAk42+icoLiCPbVdSSo3zMoz97lyKY6EuxvJvS6sE/UKnX9UFGRM4bLxrP23qRcZ2HAvML7nqd7Vu7CgynynNhhn3wZ9rzFreYDdrPmylm5if9DPPpcFldubbvYkY/ZvZmSI+ZDcmJhuFALhCnLvuMejitUpqGRGQc0asvrpwkL/e81M1jIkM6o1LqkhEYyt54wa2vrTVaLf9caurSUn1VaNrp3ZAdcLTtOtth9vvifRrbpRblnL0VwfborYOuMkNZOA8Gfl1gLNx8V6H4KlUUdxLuMYzVyioyrRIKLYHRNdFmYSBhKvyRwS0gq84tWxKODc8Wizo/eX6RsFUVZE+/8jA0LBo/T3yHV0hzcxqqN0C+wkK/kJjLob6kPh1TFAc1O2Wai0TlobgT8glWJf9/gObDmZRbnJN7ZgmVD1Wcwo4E7vJQ92mQn//J3vtfcZXCUQdWiaP+IyEfBbpr8C0dn1KsjXjCsAl4ASTlYfg03wZf6Ikh7X+Go1/bDEZ9MrMxAA3oLR1tNsr+PQ/o5TX9lQEfTkC7mRXnJxTe+Zm44U14JweS6FZBoDUPoAVEOOcV2+bbvz3zyAWeyM/j3MgpfDkEuCUAzYg1GWeZL4budfvpB+WWFfivImD7kUB2IwVcti8F4O4esjQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(6506007)(9686003)(6916009)(83380400001)(8936002)(53546011)(122000001)(30864003)(71200400001)(316002)(38070700005)(7696005)(66476007)(66556008)(26005)(86362001)(66946007)(64756008)(76116006)(52536014)(66446008)(55016003)(33656002)(508600001)(54906003)(5660300002)(2906002)(8676002)(186003)(4326008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1923
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	96dc5dde-7d1d-4b06-eec0-08da229be6e3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tt2iiRXyTv3T0TePQSiftmEkNza7LW3MgdHKo9jpuLtsRnifFxS6HfQrhqStOpUO1aiegOR1N1wRERCcJ9PvF1wLfwXm+Mt6f41j2Pj8XmKc9MTbb7wqdxI7s0uaNZjCOaSf6yKA7DZFdgDSh1fEKfeqfzy6rQGpQZGQ4W9nAnfcDkJnNY6vJ7o6u8B0//iAGUAs3xLAqKIIebulfEaGJtiytOHPnxqrfijkD1q0SYpDiJ0gc/95sySm/ZlhbT3IHSNUKk6l+b5gVCg5JXLqyAJn8QgaCfteyX0kOFiMevRvxqcrZc3bpAgYdOb1xl+Sa6fEPlYOKh/O8ykEc+B62CB9YfmeF8/FjFkDPG6smZJauJOBrE5vC5CU5nPG9N58g9/P8+5PjYEtKi8KA00/MY3aqJlDrqdx/bS29SwKOE5bt13/tO6xQrCKfsOAcMWL2J9YDcwy2O/Soc5S1gJiZSruQYtN16wXoroALvJLrhZgtSUlNm3VAWQJCRv3R/d8crRxNgjADc50CUpONwkQc+TPv5ASFgCoi7jhFGqqGd8WanjHR4Xu+DFKP1xIAKaiqws76vbBazYIKQuDzI0ZC7OpDtcX8DvTz8VA8i/iraruNAFtkK3KrJERgjsROhJ8vnBAkMnB9o3+G8emMwHaZiLIidVrd+UrXiVNvX2H+G+/siaSbeJ0KQgiCAFc+T15
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(6862004)(70586007)(70206006)(53546011)(83380400001)(82310400005)(4326008)(86362001)(54906003)(5660300002)(316002)(508600001)(81166007)(186003)(30864003)(2906002)(36860700001)(8676002)(26005)(47076005)(356005)(55016003)(9686003)(336012)(33656002)(6506007)(52536014)(40460700003)(7696005)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 07:03:49.7004
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c0192ec5-4ab9-4c9c-46b3-08da229bebce
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7238

SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVm
YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IDIwMjLE6jTU
wjIwyNUgOTo1MA0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBTdGVm
YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyB4ZW4tDQo+IGRldmVsQGxp
c3RzLnhlbnByb2plY3Qub3JnOyBqdWxpZW5AeGVuLm9yZzsgQmVydHJhbmQgTWFycXVpcw0KPiA8
QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5j
b20+DQo+IFN1YmplY3Q6IFJFOiBQcm9wb3NhbCBmb3IgUG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0
IC0gRHJhZnRCDQo+IA0KPiBPbiBUdWUsIDE5IEFwciAyMDIyLCBXZWkgQ2hlbiB3cm90ZToNCj4g
PiA+ID4gIyMjIDMuMi4gWGVuIEV2ZW50IENoYW5uZWwgU3VwcG9ydA0KPiA+ID4gPiAgICAgSW4g
Q3VycmVudCBSRkMgcGF0Y2hlcyB3ZSBoYXZlbid0IGVuYWJsZWQgdGhlIGV2ZW50IGNoYW5uZWwN
Cj4gc3VwcG9ydC4NCj4gPiA+ID4gICAgIEJ1dCBJIHRoaW5rIGl0J3MgZ29vZCBvcHBvcnR1bml0
eSB0byBkbyBzb21lIGRpc2N1c3Npb24gaW4NCj4gYWR2YW5jZWQuDQo+ID4gPiA+ICAgICBPbiBB
cm12OC1SLCBhbGwgVk1zIGFyZSBuYXRpdmUgZGlyZWN0LW1hcCwgYmVjYXVzZSB0aGVyZSBpcyBu
bw0KPiA+ID4gc3RhZ2UyDQo+ID4gPiA+ICAgICBNTVUgdHJhbnNsYXRpb24uIEN1cnJlbnQgZXZl
bnQgY2hhbm5lbCBpbXBsZW1lbnRhdGlvbiBkZXBlbmRzIG9uDQo+ID4gPiBzb21lDQo+ID4gPiA+
ICAgICBzaGFyZWQgcGFnZXMgYmV0d2VlbiBYZW4gYW5kIGd1ZXN0OiBgc2hhcmVkX2luZm9gIGFu
ZCBwZXItY3B1DQo+ID4gPiBgdmNwdV9pbmZvYC4NCj4gPiA+ID4NCj4gPiA+ID4gICAgIEZvciBg
c2hhcmVkX2luZm9gLCBpbiBjdXJyZW50IGltcGxlbWVudGF0aW9uLCBYZW4gd2lsbCBhbGxvY2F0
ZQ0KPiBhDQo+ID4gPiBwYWdlDQo+ID4gPiA+ICAgICBmcm9tIGhlYXAgZm9yIGBzaGFyZWRfaW5m
b2AgdG8gc3RvcmUgaW5pdGlhbCBtZXRhIGRhdGEuIFdoZW4NCj4gZ3Vlc3QNCj4gPiA+IGlzDQo+
ID4gPiA+ICAgICB0cnlpbmcgdG8gc2V0dXAgYHNoYXJlZF9pbmZvYCwgaXQgd2lsbCBhbGxvY2F0
ZSBhIGZyZWUgZ2ZuIGFuZA0KPiB1c2UgYQ0KPiA+ID4gPiAgICAgaHlwZXJjYWxsIHRvIHNldHVw
IFAyTSBtYXBwaW5nIGJldHdlZW4gZ2ZuIGFuZCBgc2hhcmVkX2luZm9gLg0KPiA+ID4gPg0KPiA+
ID4gPiAgICAgRm9yIGRpcmVjdC1tYXBwaW5nIFZNLCB0aGlzIHdpbGwgYnJlYWsgdGhlIGRpcmVj
dC1tYXBwaW5nDQo+IGNvbmNlcHQuDQo+ID4gPiA+ICAgICBBbmQgb24gYW4gTVBVIGJhc2VkIHN5
c3RlbSwgbGlrZSBBcm12OC1SIHN5c3RlbSwgdGhpcyBvcGVyYXRpb24NCj4gd2lsbA0KPiA+ID4g
PiAgICAgYmUgdmVyeSB1bmZyaWVuZGx5LiBYZW4gbmVlZCB0byBwb3AgYHNoYXJlZF9pbmZvYCBw
YWdlIGZyb20gWGVuDQo+IGhlYXANCj4gPiA+ID4gICAgIGFuZCBpbnNlcnQgaXQgdG8gVk0gUDJN
IHBhZ2VzLiBJZiB0aGlzIHBhZ2UgaXMgaW4gdGhlIG1pZGRsZSBvZg0KPiA+ID4gPiAgICAgWGVu
IGhlYXAsIHRoaXMgbWVhbnMgWGVuIG5lZWQgdG8gc3BsaXQgY3VycmVudCBoZWFwIGFuZCB1c2UN
Cj4gZXh0cmENCj4gPiA+ID4gICAgIE1QVSByZWdpb25zLiBBbHNvIGZvciB0aGUgUDJNIHBhcnQs
IHRoaXMgcGFnZSBpcyB1bmxpa2VseSB0bw0KPiBmb3JtDQo+ID4gPiA+ICAgICBhIG5ldyBjb250
aW51b3VzIG1lbW9yeSByZWdpb24gd2l0aCB0aGUgZXhpc3RpbmcgcDJtIHBhZ2VzLCBhbmQNCj4g
WGVuDQo+ID4gPiA+ICAgICBpcyBsaWtlbHkgdG8gbmVlZCBhbm90aGVyIGFkZGl0aW9uYWwgTVBV
IHJlZ2lvbiB0byBzZXQgaXQgdXAsDQo+IHdoaWNoDQo+ID4gPiA+ICAgICBpcyBvYnZpb3VzbHkg
YSB3YXN0ZSBmb3IgbGltaXRlZCBNUFUgcmVnaW9ucy4gQW5kIFRoaXMga2luZCBvZg0KPiA+ID4g
ZHluYW1pYw0KPiA+ID4gPiAgICAgaXMgcXVpdGUgaGFyZCB0byBpbWFnaW5lIG9uIGFuIE1QVSBz
eXN0ZW0uDQo+ID4gPg0KPiA+ID4gWWVhaCwgaXQgZG9lc24ndCBtYWtlIGFueSBzZW5zZSBmb3Ig
TVBVIHN5c3RlbXMNCj4gPiA+DQo+ID4gPg0KPiA+ID4gPiAgICAgRm9yIGB2Y3B1X2luZm9gLCBp
biBjdXJyZW50IGltcGxlbWVudGF0aW9uLCBYZW4gd2lsbCBzdG9yZQ0KPiA+ID4gYHZjcHVfaW5m
b2ANCj4gPiA+ID4gICAgIG1ldGEgZGF0YSBmb3IgYWxsIHZDUFVzIGluIGBzaGFyZWRfaW5mb2Au
IFdoZW4gZ3Vlc3QgaXMgdHJ5aW5nDQo+IHRvDQo+ID4gPiBzZXR1cA0KPiA+ID4gPiAgICAgYHZj
cHVfaW5mb2AsIGl0IHdpbGwgYWxsb2NhdGUgbWVtb3J5IGZvciBgdmNwdV9pbmZvYCBmcm9tIGd1
ZXN0DQo+IHNpZGUuDQo+ID4gPiA+ICAgICBBbmQgdGhlbiBndWVzdCB3aWxsIHVzZSBoeXBlcmNh
bGwgdG8gY29weSBtZXRhIGRhdGEgZnJvbQ0KPiA+ID4gYHNoYXJlZF9pbmZvYA0KPiA+ID4gPiAg
ICAgdG8gZ3Vlc3QgcGFnZS4gQWZ0ZXIgdGhhdCBib3RoIFhlbiBgdmNwdV9pbmZvYCBhbmQgZ3Vl
c3QNCj4gYHZjcHVfaW5mb2ANCj4gPiA+ID4gICAgIGFyZSBwb2ludGVkIHRvIHRoZSBzYW1lIHBh
Z2UgdGhhdCBhbGxvY2F0ZWQgYnkgZ3Vlc3QuDQo+ID4gPiA+DQo+ID4gPiA+ICAgICBUaGlzIGlt
cGxlbWVudGF0aW9uIGhhcyBzZXJ2YWwgYmVuaWZpdHM6DQo+ID4gPiA+ICAgICAxLiBUaGVyZSBp
cyBubyB3YXN0ZSBtZW1vcnkuIE5vIGV4dHJhIG1lbW9yeSB3aWxsIGJlIGFsbG9jYXRlZA0KPiBm
cm9tDQo+ID4gPiBYZW4gaGVhcC4NCj4gPiA+ID4gICAgIDIuIFRoZXJlIGlzIG5vIFAyTSByZW1h
cC4gVGhpcyB3aWxsIG5vdCBicmVhayB0aGUgZGlyZWN0LW1hcHBpbmcsDQo+ID4gPiBhbmQNCj4g
PiA+ID4gICAgICAgIGlzIE1QVSBzeXN0ZW0gZnJpZW5kbHkuDQo+ID4gPiA+ICAgICBTbywgb24g
QXJtdjgtUiBzeXN0ZW0sIHdlIGNhbiBzdGlsbCBrZWVwIGN1cnJlbnQgaW1wbGVtZW50YXRpb24N
Cj4gZm9yDQo+ID4gPiA+ICAgICBwZXItY3B1IGB2Y3B1X2luZm9gLg0KPiA+ID4gPg0KPiA+ID4g
PiAgICAgU28sIG91ciBwcm9wb3NhbCBpcyB0aGF0LCBjYW4gd2UgcmV1c2UgY3VycmVudCBpbXBs
ZW1lbnRhdGlvbg0KPiBpZGVhDQo+ID4gPiBvZg0KPiA+ID4gPiAgICAgYHZjcHVfaW5mb2AgZm9y
IGBzaGFyZWRfaW5mb2A/IFdlIHN0aWxsIGFsbG9jYXRlIG9uZSBwYWdlIGZvcg0KPiA+ID4gPiAg
ICAgYGQtPnNoYXJlZF9pbmZvYCBhdCBkb21haW4gY29uc3RydWN0aW9uIGZvciBob2xkaW5nIHNv
bWUgaW5pdGlhbA0KPiA+ID4gbWV0YS1kYXRhLA0KPiA+ID4gPiAgICAgdXNpbmcgYWxsb2NfZG9t
aGVhcF9wYWdlcyBpbnN0ZWFkIG9mIGFsbG9jX3hlbmhlYXBfcGFnZXMgYW5kDQo+ID4gPiA+ICAg
ICBzaGFyZV94ZW5fcGFnZV93aXRoX2d1ZXN0LiBBbmQgd2hlbiBndWVzdCBhbGxvY2F0ZXMgYSBw
YWdlIGZvcg0KPiA+ID4gPiAgICAgYHNoYXJlZF9pbmZvYCBhbmQgdXNlIGh5cGVyY2FsbCB0byBz
ZXR1cCBpdCwgIFdlIGNvcHkgdGhlDQo+IGluaXRpYWwNCj4gPiA+IGRhdGEgZnJvbQ0KPiA+ID4g
PiAgICAgYGQtPnNoYXJlZF9pbmZvYCB0byBpdC4gQW5kIGFmdGVyIGNvcHkgd2UgY2FuIHVwZGF0
ZSBgZC0NCj4gPiA+ID5zaGFyZWRfaW5mb2AgdG8gcG9pbnQNCj4gPiA+ID4gICAgIHRvIGd1ZXN0
IGFsbG9jYXRlZCAnc2hhcmVkX2luZm8nIHBhZ2UuIEluIHRoaXMgY2FzZSwgd2UgZG9uJ3QNCj4g
aGF2ZQ0KPiA+ID4gdG8gdGhpbmsNCj4gPiA+ID4gICAgIGFib3V0IHRoZSBmcmFnbWVudGF0aW9u
IG9mIFhlbiBoZWFwIGFuZCBwMm0gYW5kIHRoZSBleHRyYSBNUFUNCj4gPiA+IHJlZ2lvbnMuDQo+
ID4gPg0KPiA+ID4gWWVzLCBJIHRoaW5rIHRoYXQgd291bGQgd29yay4NCj4gPiA+DQo+ID4gPiBB
bHNvIEkgdGhpbmsgaXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGdldCByaWQgb2YgdGhlIGluaXRp
YWwNCj4gPiA+IGQtPnNoYXJlZF9pbmZvIGFsbG9jYXRpb24gaW4gWGVuLCBnaXZlbiB0aGF0IGQt
PnNoYXJlZF9pbmZvIGlzIGZvciB0aGUNCj4gPiA+IGJlbmVmaXQgb2YgdGhlIGd1ZXN0IGFuZCB0
aGUgZ3Vlc3QgY2Fubm90IGFjY2VzcyBpdCB1bnRpbCBpdCBtYWtlcyB0aGUNCj4gPiA+IFhFTk1B
UFNQQUNFX3NoYXJlZF9pbmZvIGh5cGVyY2FsbC4NCj4gPiA+DQo+ID4NCj4gPiBXaGlsZSB3ZSdy
ZSB3b3JraW5nIG9uIGV2ZW50IGNoYW5uZWwgUG9DIHdvcmsgb24gWGVuIEFybXY4LVIsIHdlIGZv
dW5kDQo+ID4gYW5vdGhlciBpc3N1ZSBhZnRlciB3ZSBkcm9wcGVkIGQtPnNoYXJlZF9pbmZvIGFs
bG9jYXRpb24gaW4gWGVuLiBCb3RoDQo+ID4gc2hhcmVkX2luZm8gYW5kIHZjcHVfaW5mbyBhcmUg
YWxsb2NhdGVkIGZyb20gR3Vlc3QgaW4gcnVudGltZS4gVGhhdA0KPiA+IG1lYW5zIHRoZSBhZGRy
ZXNzZXMgb2Ygc2hhcmVkX2luZm8gYW5kIHZjcHVfaW5mbyBhcmUgcmFuZG9tLiBGb3IgTU1VDQo+
ID4gc3lzdGVtLCB0aGlzIGlzIE9LLCBiZWNhdXNlIFhlbiBoYXMgYSBmdWxsIHZpZXcgb2Ygc3lz
dGVtIG1lbW9yeSBpbg0KPiA+IHJ1bnRpbWUuIEJ1dCBmb3IgTVBVIHN5c3RlbSwgdGhlIHNpdHVh
dGlvbiBiZWNvbWVzIGEgbGl0dGxlIHRyaWNreS4NCj4gPiBXZSBoYXZlIHRvIHNldHVwIGV4dHJh
IE1QVSByZWdpb25zIGZvciByZW1vdGUgZG9tYWlucycgc2hhcmVkX2luZm8NCj4gPiBhbmQgdmNw
dV9pbmZvIGluIGV2ZW50IGNoYW5uZWwgaHlwZXJjYWxsIHJ1bnRpbWUuIFRoYXQncyBiZWNhdXNl
DQo+ID4gaW4gY3VycmVudCBYZW4gaHlwZXJjYWxsIGNvbmNlcHQsIGh5cGVyY2FsbCB3aWxsIG5v
dCBjYXVzZSB2Q1BVDQo+ID4gY29udGV4dCBzd2l0Y2guIFdoZW4gaHlwZXJjYWxsIHRyYXAgdG8g
RUwyLCBpdCB3aWxsIGtlZXAgdkNQVSdzDQo+ID4gUDJNIHZpZXcuIEZvciBNTVUgc3lzdGVtLCB3
ZSBoYXZlIHZ0dGJyX2VsMiBmb3IgdkNQVSBQMk0gdmlldyBhbmQNCj4gPiB0dGJyX2VsMiBmb3Ig
WGVuIHZpZXcuIFNvIGluIEVMMiBYZW4gaGFzIGZ1bGwgcGVybWlzc2lvbnMgdG8gYWNjZXNzDQo+
ID4gYW55IG1lbW9yeSBpdCB3YW50cy4gQnV0IGZvciBNUFUgc3lzdGVtLCB3ZSBvbmx5IGhhdmUg
b25lIEVMMiBNUFUuDQo+ID4gQmVmb3JlIGVudGVyaW5nIGd1ZXN0LCBYZW4gd2lsbCBzZXR1cCB2
Q1BVIFAyTSB2aWV3IGluIEVMMiBNUFUuDQo+ID4gSW4gdGhpcyBjYXNlLCB3aGVuIHN5c3RlbSBl
bnRyeSBFTDIgdGhyb3VnaCBoeXBlcmNhbGwsIHRoZSBFTDINCj4gPiBNUFUgc3RpbGwga2VlcHMg
Y3VycmVudCB2Q1BVIFAyTSB2aWV3IGFuZCB3aXRoIFhlbiBlc3NlbnRpYWwNCj4gPiBtZW1vcnkg
KGNvZGUsIGRhdGEsIGhlYXApIGFjY2VzcyBwZXJtaXNzaW9ucy4gQnV0IGN1cnJlbnQgRUwyIE1Q
VQ0KPiA+IGRvZXNuJ3QgaGF2ZSB0aGUgYWNjZXNzIHBlcm1pc3Npb25zIGZvciBFTDIgdG8gYWNj
ZXNzIG90aGVyDQo+ID4gZG9tYWluJ3MgbWVtb3J5LiBGb3IgYW4gZXZlbnQgY2hhbm5lbCBoeXBl
cmNhbGwsIGlmIHdlIHdhbnQgdG8NCj4gPiB1cGRhdGUgdGhlIHBlbmRpbmcgYml0bWFwIGluIHJl
bW90ZSBkb21haW4ncyB2Y3B1X2luZm8sIGl0IHdpbGwNCj4gPiBjYXVzZSBhIGRhdGFhYm9ydCBp
biBFTDIuIFRvIHNvbHZlIHRoaXMgZGF0YWFib3J0LCB3ZSBtYXkgaGF2ZQ0KPiA+IHR3byBtZXRo
b2RzOg0KPiA+IDEuIE1hcCByZW1vdGUgZG9tYWluJ3Mgd2hvbGUgbWVtb3J5IG9yIHBhZ2VzIGZv
ciBzaGFyZWRfaW5mbyArDQo+ID4gICAgdmNwdV9pbmZvIGluIEVMMiBNUFUgdGVtcG9yYXJpbHkg
Zm9yIGh5cGVyY2FsbCB0byB1cGRhdGUNCj4gPiAgICBwZW5kaW5nIGJpdHMgb3Igb3RoZXIgYWNj
ZXNzZXMuDQo+ID4NCj4gPiAgICBUaGlzIG1ldGhvZCBkb2Vzbid0IG5lZWQgdG8gZG8gY29udGV4
dCBzd2l0Y2ggZm9yIEVMMiBNUFUsDQo+ID4gICAgQnV0IHRoaXMgbWV0aG9kIGhhcyBzb21lIGRp
c2FkdmFudGFnZXM6DQo+ID4gICAgMS4gV2UgaGF2ZSB0byByZXNlcnZlIE1QVSByZWdpb25zIGZv
ciBoeXBlcmNhbGwuDQo+ID4gICAgMi4gRGlmZmVyZW50IGh5cGVyY2FsbCBtYXkgaGF2ZSBkaWZm
ZXJlbnQgcmVzZXJ2YXRpb24gb2YNCj4gPiAgICAgICBNUFUgcmVnaW9ucy4NCj4gPiAgICAzLiBX
ZSBoYXZlIHRvIGhhbmRsZSBoeXBlcmNhbGwgb25lIGJ5IG9uZSBmb3IgZXhpc3RlZCBhbmQNCj4g
PiAgICAgICBuZXcgaW4gZnV0dXJlLg0KPiA+DQo+ID4gMi4gU3dpdGNoIHRvIFhlbidzIG1lbW9y
eSB2aWV3IGluIEVMMiBNUFUgd2hlbiB0cmFwIGZyb20gRUwxIHRvDQo+ID4gICAgRUwyLiBJbiB0
aGlzIGNhc2UsIFhlbiB3aWxsIGhhdmUgZnVsbCBtZW1vcnkgYWNjZXNzIHBlcm1pc3Npb25zDQo+
ID4gICAgdG8gdXBkYXRlIHBlbmRpbmcgYml0cyBpbiBFTDIuIFRoaXMgb25seSBjaGFuZ2VzIHRo
ZSBFTDIgTVBVDQo+ID4gICAgY29udGV4dCwgZG9lcyBub3QgbmVlZCB0byBkbyB2Q1BVIGNvbnRl
eHQgc3dpdGNoLiBCZWNhdXNlIHRoZQ0KPiA+ICAgIHRyYXBwZWQgdkNQVSB3aWxsIGJlIHVzZWQg
aW4gdGhlIGZ1bGwgZmxvdyBvZiBoeXBlcmNhbGwuIEFmdGVyDQo+ID4gICAgdGhlIGh5cGVyY2Fs
bCwgYmVmb3JlIHJldHVybmluZyB0byBFTDIsIHRoZSBFTDIgTVBVIHdpbGwgc3dpdGNoDQo+ID4g
ICAgdG8gc2NoZWR1bGVkIHZDUFUnIFAyTSB2aWV3Lg0KPiA+ICAgIFRoaXMgbWV0aG9kIG5lZWRz
IHRvIGRvIEVMMiBNUFUgY29udGV4dCBzd2l0Y2gsIGJ1dDoNCj4gPiAgICAxLiBXZSBkb24ndCBu
ZWVkIHRvIHJlc2VydmUgTVBVIHJlZ2lvbnMgZm9yIFhlbidzIG1lbW9yeSB2aWV3Lg0KPiA+ICAg
ICAgIChYZW4ncyBtZW1vcnkgdmlldyBoYXMgYmVlbiBzZXR1cCB3aGlsZSBpbml0aWFsaXphdGlv
bikNCj4gPiAgICAyLiBXZSBkb24ndCBuZWVkIHRvIGhhbmRsZSBwYWdlcycgbWFwcGluZyBpbiBo
eXBlcmNhbGwgbGV2ZWwuDQo+ID4gICAgMy4gQXBwbHkgdG8gb3RoZXIgRUwxIHRvIEVMMiB0cmFw
cywgbGlrZSBkYXRhYWJvcnQsIElSUSwgZXRjLg0KPiANCj4gDQo+IEJvdGggYXBwcm9hY2ggMSkg
YW5kIDIpIGFyZSBhY2NlcHRhYmxlIGFuZCBpbiBmYWN0IEkgdGhpbmsgd2UnbGwNCj4gcHJvYmFi
bHkgaGF2ZSB0byBkbyBhIGNvbWJpbmF0aW9uIG9mIGJvdGguDQo+IA0KPiBXZSBkb24ndCBuZWVk
IHRvIGRvIGEgZnVsbCBNUFUgY29udGV4dCBzd2l0Y2ggZXZlcnkgdGltZSB3ZSBlbnRlciBYZW4u
DQo+IFdlIGNhbiBiZSBmbGV4aWJsZS4gT25seSB3aGVuIFhlbiBuZWVkcyB0byBhY2Nlc3MgYW5v
dGhlciBndWVzdCBtZW1vcnksDQo+IGlmIHRoZSBtZW1vcnkgaXMgbm90IG1hcHBhYmxlIHVzaW5n
IGFwcHJvYWNoIDEpLCBYZW4gY291bGQgZG8gYSBmdWxsIE1QVQ0KPiBjb250ZXh0IHN3aXRjaC4g
QmFzaWNhbGx5LCB0cnkgMSkgZmlyc3QsIGlmIGl0IGlzIG5vdCBwb3NzaWJsZSwgZG8gMikuDQo+
IA0KPiBUaGlzIGFsc28gc29sdmVzIHRoZSBwcm9ibGVtIG9mICJvdGhlciBoeXBlcmNhbGxzIi4g
V2UgY2FuIGFsd2F5cyBkbyAyKQ0KPiBpZiB3ZSBjYW5ub3QgZG8gMSkuDQo+IA0KPiBTbyBkbyB3
ZSBuZWVkIHRvIGRvIDEpIGF0IGFsbD8gSXQgcmVhbGx5IGRlcGVuZHMgb24gcGVyZm9ybWFuY2Ug
ZGF0YS4NCj4gTm90IGFsbCBoeXBlcmNhbGxzIGFyZSBtYWRlIGVxdWFsLiBTb21lIGFyZSB2ZXJ5
IHJhcmUgYW5kIGl0IGlzIGZpbmUgaWYNCj4gdGhleSBhcmUgc2xvdy4gU29tZSBoeXBlcmNhbGxz
IGFyZSBhY3R1YWxseSBvbiB0aGUgaG90IHBhdGguIFRoZSBldmVudA0KPiBjaGFubmVscyBoeXBl
cmNhbGxzIGFyZSBvbiB0aGUgaG90IHBhdGggc28gdGhleSBuZWVkIHRvIGJlIGZhc3QuIEl0DQo+
IG1ha2VzIHNlbnNlIHRvIGltcGxlbWVudCAxKSBqdXN0IGZvciBldmVudCBjaGFubmVscyBoeXBl
cmNhbGxzIGlmIHRoZQ0KPiBNUFUgY29udGV4dCBzd2l0Y2ggaXMgc2xvdy4NCj4gDQo+IERhdGEg
d291bGQgaGVscCBhIGxvdCBoZXJlIHRvIG1ha2UgYSBnb29kIGRlY2lzaW9uLiBTcGVjaWZpY2Fs
bHksIGhvdw0KPiBtdWNoIG1vcmUgZXhwZW5zaXZlIGlzIGFuIEVMMiBNUFUgY29udGV4dCBzd2l0
Y2ggY29tcGFyZWQgdG8gYWRkL3JlbW92ZQ0KPiBvZiBhbiBNUFUgcmVnaW9uIGluIG5hbm9zZWMg
b3IgY3B1IGN5Y2xlcz8NCj4gDQoNCldlIHdpbGwgZG8gaXQgd2hlbiB3ZSBnZXQgYSBwcm9wZXIg
cGxhdGZvcm0uDQoNCj4gDQo+IFRoZSBvdGhlciBhc3BlY3QgaXMgaG93IG1hbnkgZXh0cmEgTVBV
IHJlZ2lvbnMgZG8gd2UgbmVlZCBmb3IgZWFjaCBndWVzdA0KPiB0byBpbXBsZW1lbnQgMSkuIERv
IHdlIG5lZWQgb25lIGV4dHJhIE1QVSByZWdpb24gZm9yIGVhY2ggZG9tVT8gSWYgc28sIEkNCj4g
ZG9uJ3QgdGhpbmsgYXBwcm9hY2ggMSkgaWYgZmVhc2libGUgdW5sZXNzIHdlIGNvbWUgdXAgd2l0
aCBhIHNtYXJ0DQo+IG1lbW9yeSBhbGxvY2F0aW9uIHNjaGVtZSBmb3Igc2hhcmVkX2luZm8gYW5k
IHZjcHVfaW5mby4gRm9yIGluc3RhbmNlLCBpZg0KPiBzaGFyZWRfaW5mbyBhbmQgdmNwdV9pbmZv
IG9mIGFsbCBndWVzdHMgd2VyZSBwYXJ0IG9mIHRoZSBYZW4gZGF0YSBvcg0KPiBoZWFwIHJlZ2lv
biwgb3IgMSBvdGhlciBzcGVjaWFsIE1QVSByZWdpb24sIHRoZW4gdGhleSBjb3VsZCBiZWNvbWUN
Cj4gaW1tZWRpYXRlbHkgYWNjZXNzaWJsZSB3aXRob3V0IG5lZWQgZm9yIGV4dHJhIG1hcHBpbmdz
IHdoZW4gc3dpdGNoaW5nIHRvDQo+IEVMMi4NCj4gDQoNCkFsbG9jYXRlIHNoYXJlZF9pbmZvIGFu
ZCB2Y3B1X2luZm8gZnJvbSBYZW4gZGF0YSBvciBoZWFwIHdpbGwgY2F1c2UgbWVtb3J5DQpmcmFn
bWVudGF0aW9uLiBXZSBoYXZlIHRvIHNwbGl0IHRoZSBYZW4gZGF0YSBvciBoZWFwIGFuZCBwb3B1
bGF0ZSB0aGUgcGFnZXMNCmZvciBzaGFyZWRfaW5mbyBhbmQgdmNwdV9pbmZvLCBBbmQgaW5zZXJ0
IHRoZW0gdG8gR3Vlc3QgUDJNLiBCZWNhdXNlIEFybXY4LVINCk1QVSBkb2Vzbid0IGFsbG93IG1l
bW9yeSBvdmVybGFwLCB0aGlzIHdpbGwgY2F1c2UgYXQgbGVhc3QgMiBleHRyYSBNUFUNCnJlZ2lv
bnMgdXNhZ2UuIE9uZSBwYWdlIGNvdWxkIG5vdCBleGlzdCBpbiBYZW4gTVBVIHJlZ2lvbiBhbmQg
R3Vlc3QgUDJNDQpNUFUgcmVnaW9uIGF0IHRoZSBzYW1lIHRpbWUuIEFuZCB3ZSBkZWZpbml0ZWx5
IGRvbid0IHdhbnQgdG8gbWFrZSB0aGUgZW50aXJlDQpYZW4gZGF0YSBhbmQgaGVhcCBhY2Nlc3Np
YmxlIHRvIEVMMS4gQW5kIHRoaXMgYXBwcm9hY2ggZG9lcyBub3Qgc29sdmUgdGhlDQoxMDAlIGRp
cmVjdCBtYXBwaW5nIHByb2JsZW0uIEEgc3BlY2lhbCBNUFUgcmVnaW9uIG1pZ2h0IGhhdmUgdGhl
IHNhbWUgaXNzdWVzLg0KRXhjZXB0IHdlIG1ha2UgdGhpcyBzcGVjaWFsIE1QVSByZWdpb24gY2Fu
IGJlIGFjY2Vzc2VkIGluIEVMMSBhbmQgRUwyIGF0DQpydW50aW1lIChpdCdzIHVuc2FmZSksIGFu
ZCB1cGRhdGUgaHlwZXJjYWxsIHRvIHVzZSBwYWdlcyBmcm9tIHRoaXMgc3BlY2lhbA0KcmVnaW9u
IGZvciBzaGFyZWRfaW5mbyBhbmQgdmNwdV9pbmZvIChldmVyeSBndWVzdCBjYW4gc2VlIHRoaXMg
cmVnaW9uLCBzbw0KaXQncyBzdGlsbCAxOjEgbWFwcGluZykuDQoNCkZvciAxKSwgdGhlIGNvbmNl
cm4gaXMgY2F1c2VkIGJ5IG91ciBjdXJyZW50IHJvdWdoIFBvQywgd2UgdXNlZCBleHRyYSBNUFUN
CnJlZ2lvbnMgdG8gbWFwIHRoZSB3aG9sZSBtZW1vcnkgb2YgcmVtb3RlIGRvbWFpbiwgd2hvc2Ug
bWF5IGhhdmUgc2VydmFsDQptZW1vcnkgYmxvY2tzIGluIHRoZSB3b3JzdCBjYXNlLiBXZSBoYXZl
IHRob3VnaHQgaXQgZnVydGhlciwgd2UgY2FuIHJlZHVjZQ0KdGhlIG1hcCBncmFudWxhcml0eSB0
byBwYWdlLiBGb3IgZXhhbXBsZSwgWGVuIHdhbnRzIHRvIHVwZGF0ZSBzaGFyZWRfaW5mbw0Kb3Ig
dmNwdV9pbmZvLCBYZW4gbXVzdCBrbm93IHRoZSBhZGRyZXNzIG9mIGl0LiBTbyB3ZSBjYW4ganVz
dCBtYXAgdGhpcw0Kb25lIHBhZ2UgdGVtcG9yYXJpbHkuIFNvIEkgdGhpbmsgb25seSByZXNlcnZl
IDEgTVBVIHJlZ2lvbiBmb3IgcnVudGltZQ0KbWFwcGluZyBpcyBmZWFzaWJsZSBvbiBtb3N0IHBs
YXRmb3Jtcy4gQnV0IHRoZSBhZGRpdGlvbmFsIHByb2JsZW0gd2l0aA0KdGhpcyBpcyB0aGF0IGlm
IHRoZSBoeXBlcmNhbGwgYXJlIG1vZGlmeWluZyBtdWx0aXBsZSB2YXJpYWJsZXMsIFhlbiBtYXkN
Cm5lZWQgdG8gZG8gbXVsdGlwbGUgbWFwcGluZ3MgaWYgdGhleSBhcmUgbm90IG9uIHRoZSBzYW1l
IHBhZ2UgKG9yIGEgcHJvcGVyDQpNUFUgcmVnaW9uIHJhbmdlKS4NCg0KPiBPbmUgaWRlYSBpcyB0
byBjaGFuZ2UgdGhlIGludGVyZmFjZSBhbmQgaGF2ZSBYZW4gYWxsb2NhdGUNCj4gc2hhcmVkX2lu
Zm8vdmNwdV9pbmZvIGluc3RlYWQgb2YgdGhlIGd1ZXN0IGFuZCBwcm92aWRlIHRoZSBhZGRyZXNz
IG9uDQo+IGRldmljZSB0cmVlLiBUaGF0IHdheSwgdGhlIGd1ZXN0IGRvZXNuJ3QgbmVlZCB0byBh
bGxvY2F0ZSB0aGUgbWVtb3J5Lg0KPiBYZW4gY2FuIGNob29zZSB3aGVyZSB0aGUgbWVtb3J5IGNv
bWVzIGZyb20gYW5kIGl0IGNvdWxkIGJlIGFsbG9jYXRlZA0KPiBmcm9tIGEgc3VpdGFibGUgTVBV
IHJlZ2lvbiBzbyB0aGF0IGl0IGJlY29tZXMgYXV0b21hdGljYWxseSBhY2Nlc3NpYmxlDQo+IHRv
IFhlbiB3aGVuIGVudGVyaW5nIEVMMiB3aXRob3V0IG5lZWRlZCBhIGZ1bGwgY29udGV4dCBzd2l0
Y2guDQo+IA0KDQpJIHRoaW5rIHRoaXMgaXMgbm8gZGlmZmVyZW5jZSB0aGVuIGFib3ZlICIxIG90
aGVyIHNwZWNpYWwgTVBVIHJlZ2lvbiINCmFwcHJvYWNoIDogKQ0KDQo+IA0KPiANCj4gPiAgICBC
dXQgdGhpcyBtZXRob2QgaW50cm9kdWNlcyBhbm90aGVyIHNlY3VyaXR5IGNvbmNlcm46DQo+ID4g
ICAgR2l2aW5nIGZ1bGwgbWVtb3J5IHZpZXcgdG8gWGVuIGF0IGFueSBFTDIgcnVudGltZSB3aWxs
IGNhdXNlDQo+ID4gICAgYW55IHNlY3VyaXR5IGlzc3VlPyBBbHRob3VnaCBYZW4gaGFzIGRvbmUg
aW4gdGhpcyB3YXkgaW4gTU1VDQo+ID4gICAgc3lzdGVtIGFscmVhZHkuDQo+IA0KPiBJdCB3b3Vs
ZG4ndCBiZSBhIHNlY3VyaXR5IGlzc3VlIGdpdmVuIHRoZSBjdXJyZW50IGRlc2lnbiBhbmQgc2Vj
dXJpdHkNCj4gZGVmaW5pdGlvbi4NCg0KVGhhbmtzLCBJIHRoaW5rIEknbSBvdmVydGhpbmtpbmcg
dG9vIDogKQ0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:20:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:20:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308924.524830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4dq-0004FR-74; Wed, 20 Apr 2022 07:20:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308924.524830; Wed, 20 Apr 2022 07:20:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4dq-0004FK-3t; Wed, 20 Apr 2022 07:20:46 +0000
Received: by outflank-mailman (input) for mailman id 308924;
 Wed, 20 Apr 2022 07:20:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh4do-0004FA-3v; Wed, 20 Apr 2022 07:20:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh4dn-0001Jt-Vm; Wed, 20 Apr 2022 07:20:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh4dn-0000BR-HF; Wed, 20 Apr 2022 07:20:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh4dn-0007Le-Gq; Wed, 20 Apr 2022 07:20:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HvOIRfLbqw6pgpj/+7Jdg8q+h9tTl0gCcWpMUhaNyLA=; b=uAssI5kh3PWZGGT1mXTYOC88la
	fd8qjzqDieJ+jtWbM0kI+5F1hC89Fk0SPZ6379IwxMsuEEG5sgCXWk7vhWk6nMBUWy3EF7IIjjxbM
	7fU9Er1Ya81KvfrqS/7CPBSilJdnIAtQM7KkqRxEQFPqv/C3TQNgawpyK07idebxo5mc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169547-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169547: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=823a3f11fb8f04c3c3cc0f95f968fef1bfc6534f
X-Osstest-Versions-That:
    qemuu=81c7ed41a1b33031f3e4fe24191a998a492044b8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 07:20:43 +0000

flight 169547 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169547/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169423
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169423
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169423
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169423
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169423
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169423
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 169423
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169423
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169423
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                823a3f11fb8f04c3c3cc0f95f968fef1bfc6534f
baseline version:
 qemuu                81c7ed41a1b33031f3e4fe24191a998a492044b8

Last test of basis   169423  2022-04-15 10:07:08 Z    4 days
Testing same since   169547  2022-04-19 18:07:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Peter Maydell <peter.maydell@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   81c7ed41a1..823a3f11fb  823a3f11fb8f04c3c3cc0f95f968fef1bfc6534f -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:27:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:27:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308932.524841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4kZ-00056E-1N; Wed, 20 Apr 2022 07:27:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308932.524841; Wed, 20 Apr 2022 07:27:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4kY-000567-Tj; Wed, 20 Apr 2022 07:27:42 +0000
Received: by outflank-mailman (input) for mailman id 308932;
 Wed, 20 Apr 2022 07:27:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=glqv=U6=kernel.org=sj@srs-se1.protection.inumbo.net>)
 id 1nh4kY-000561-98
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:27:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5bccc89d-c07b-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 09:27:40 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 5FB0FB81D64;
 Wed, 20 Apr 2022 07:27:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 994ECC385A1;
 Wed, 20 Apr 2022 07:27:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5bccc89d-c07b-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650439658;
	bh=SOilJc5Vxvp6JDI/sAy8cOGRwLrY6YXHjo9rcXuykR0=;
	h=From:To:Cc:Subject:Date:From;
	b=AAoiVkRoimlgphII5KT74LccxQywDwBG6zlj3n/nXZMKq0h/3hKTni+wRFYiLNliH
	 2wdA6wHLs+hRq1qPEVquhcFlO4hcz5SITkyceaZsdjsApJlKgHZjbSgxVaLFVFdykw
	 u6z5sIfBytOwXvr0D0EYU5yNCJUjmjU+mE7lR6PDFCK4USuNy4j/zm1tqGXBV4TB7q
	 gjPdo0F1ZOq+sLDuVP1+wpxehnvgwVEkcsvXHaK5n2/LxpF6zxFOxH136VUFCiIYEl
	 PIZKaXKJJCPecI+kugX5fY6fOQd5fLCU9p9q5WD9DLwHixBKU2D3Y8ECtq8ALV7s9V
	 5dG7FlOpE15ig==
From: SeongJae Park <sj@kernel.org>
To: jgross@suse.com
Cc: roger.pau@citrix.com,
	mheyne@amazon.de,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	SeongJae Park <sj@kernel.org>
Subject: [PATCH v2] xen-blk{back,front}: Update contact points for buffer_squeeze_duration_ms and feature_persistent
Date: Wed, 20 Apr 2022 07:27:34 +0000
Message-Id: <20220420072734.1692-1-sj@kernel.org>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

SeongJae is currently listed as a contact point for some blk{back,front}
features, but he will not work for XEN for a while.  This commit
therefore updates the contact point to his colleague, Maximilian, who is
understanding the context and actively working with the features now.

Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Maximilian Heyne <mheyne@amazon.de>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
---

Changes from v1
(https://lore.kernel.org/xen-devel/20220301144628.2858-1-sj@kernel.org/)
- Add Acked-by from Roger

 Documentation/ABI/testing/sysfs-driver-xen-blkback  | 4 ++--
 Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback b/Documentation/ABI/testing/sysfs-driver-xen-blkback
index a74dfe52dd76..7faf719af165 100644
--- a/Documentation/ABI/testing/sysfs-driver-xen-blkback
+++ b/Documentation/ABI/testing/sysfs-driver-xen-blkback
@@ -29,7 +29,7 @@ Description:
 What:           /sys/module/xen_blkback/parameters/buffer_squeeze_duration_ms
 Date:           December 2019
 KernelVersion:  5.6
-Contact:        SeongJae Park <sj@kernel.org>
+Contact:        Maximilian Heyne <mheyne@amazon.de>
 Description:
                 When memory pressure is reported to blkback this option
                 controls the duration in milliseconds that blkback will not
@@ -39,7 +39,7 @@ Description:
 What:           /sys/module/xen_blkback/parameters/feature_persistent
 Date:           September 2020
 KernelVersion:  5.10
-Contact:        SeongJae Park <sj@kernel.org>
+Contact:        Maximilian Heyne <mheyne@amazon.de>
 Description:
                 Whether to enable the persistent grants feature or not.  Note
                 that this option only takes effect on newly created backends.
diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkfront b/Documentation/ABI/testing/sysfs-driver-xen-blkfront
index 61fd173fabfe..7f646c58832e 100644
--- a/Documentation/ABI/testing/sysfs-driver-xen-blkfront
+++ b/Documentation/ABI/testing/sysfs-driver-xen-blkfront
@@ -12,7 +12,7 @@ Description:
 What:           /sys/module/xen_blkfront/parameters/feature_persistent
 Date:           September 2020
 KernelVersion:  5.10
-Contact:        SeongJae Park <sj@kernel.org>
+Contact:        Maximilian Heyne <mheyne@amazon.de>
 Description:
                 Whether to enable the persistent grants feature or not.  Note
                 that this option only takes effect on newly created frontends.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:31:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:31:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308938.524859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4o7-0006Xk-TS; Wed, 20 Apr 2022 07:31:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308938.524859; Wed, 20 Apr 2022 07:31:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4o7-0006Wx-M8; Wed, 20 Apr 2022 07:31:23 +0000
Received: by outflank-mailman (input) for mailman id 308938;
 Wed, 20 Apr 2022 07:31:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh4o6-0006Tb-HZ
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:22 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dfbc2d0b-c07b-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 09:31:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 50E2A21118;
 Wed, 20 Apr 2022 07:31:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2BDD913A30;
 Wed, 20 Apr 2022 07:31:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uP1yCcm2X2IhXAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 07:31:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfbc2d0b-c07b-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650439881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6FxRXq43vu3ZI41xgmHwfTdmhBdkORLelAm0BLwTOuQ=;
	b=WtuoKBr+cHd3CbctZ9p3xKHGwbLgDxlIEb53eZqpcQxIugMjXgVFWC+Bfh5Sjrjisby+5K
	4vEqxztDDGBcOJtRcRRZ56I80JDP0SCWyBenIFgUHzXlHcDgxNZQUQCWdddvf6Q4AuxID1
	Id3GwYvJqVwnVA9Y3zDh9SZ4C1r6xlI=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH 2/4] tools/libs/ctrl: don't set errno to a negative value
Date: Wed, 20 Apr 2022 09:31:17 +0200
Message-Id: <20220420073119.16974-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420073119.16974-1-jgross@suse.com>
References: <20220420073119.16974-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The claimed reason for setting errno to -1 is wrong. On x86
xc_domain_pod_target() will set errno to a sane value in the error
case.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/ctrl/xc_domain.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index ef62f66009..71608c00e9 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -1293,9 +1293,7 @@ int xc_domain_get_pod_target(xc_interface *xch,
                              uint64_t *pod_cache_pages,
                              uint64_t *pod_entries)
 {
-    /* On x86 (above) xc_domain_pod_target will incorrectly return -1
-     * with errno==-1 on error. Do the same for least surprise. */
-    errno = -1;
+    errno = EOPNOTSUPP;
     return -1;
 }
 #endif
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:31:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:31:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308937.524851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4o7-0006Tx-Gb; Wed, 20 Apr 2022 07:31:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308937.524851; Wed, 20 Apr 2022 07:31:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4o7-0006Tq-D2; Wed, 20 Apr 2022 07:31:23 +0000
Received: by outflank-mailman (input) for mailman id 308937;
 Wed, 20 Apr 2022 07:31:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh4o6-0006Ta-6h
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:22 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dfe4db5d-c07b-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 09:31:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EE0BE1F380;
 Wed, 20 Apr 2022 07:31:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BDE2213A30;
 Wed, 20 Apr 2022 07:31:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ghAgLci2X2IhXAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 07:31:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfe4db5d-c07b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650439880; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=As+I3XR+3ocfIVeZPpOomgQREBczlDKKa12v3cJeq4M=;
	b=reVQNy5NgGUJFI554Hp+gx7q59KPZo3sKXwS+R1y+Jw4aU7hWK7SVw7ETO1zCHPyeHV7A3
	5ZCj+BAOUdDzL0DCjGUAip/O9mgAb2jeHxK7vxLKo7AXKWnsiLt9uCgr3c6xF+r9oheWeX
	G+4Pau4UEnEU+XDWsxQZEC7OOLbIirc=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH 0/4] tools/libs: don't set errno to negative values
Date: Wed, 20 Apr 2022 09:31:15 +0200
Message-Id: <20220420073119.16974-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There are a few places in the libs where errno is set to a negative
value. Fix those.

Juergen Gross (4):
  tools/libs/evtchn: don't set errno to negative values
  tools/libs/ctrl: don't set errno to a negative value
  tools/libs/guest: don't set errno to a negative value
  tools/libs/light: don't set errno to a negative value

 tools/libs/ctrl/xc_domain.c    | 4 +---
 tools/libs/evtchn/freebsd.c    | 2 +-
 tools/libs/evtchn/minios.c     | 2 +-
 tools/libs/evtchn/netbsd.c     | 2 +-
 tools/libs/evtchn/solaris.c    | 2 +-
 tools/libs/guest/xg_dom_core.c | 2 +-
 tools/libs/light/libxl_linux.c | 2 +-
 7 files changed, 7 insertions(+), 9 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:31:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:31:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308939.524874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4o9-0006zz-9C; Wed, 20 Apr 2022 07:31:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308939.524874; Wed, 20 Apr 2022 07:31:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4o9-0006yn-3U; Wed, 20 Apr 2022 07:31:25 +0000
Received: by outflank-mailman (input) for mailman id 308939;
 Wed, 20 Apr 2022 07:31:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh4o7-0006Tb-B8
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:23 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dfa36ac1-c07b-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 09:31:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 268C7210ED;
 Wed, 20 Apr 2022 07:31:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 004C813A30;
 Wed, 20 Apr 2022 07:31:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yNBUOsi2X2IhXAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 07:31:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfa36ac1-c07b-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650439881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CTPiijYWD7yPxL86YUqzoUHVXxb7L5u3k0/gpyUiDjo=;
	b=Hc5mx8MxTTQhGpiczvnm4m7uQF/GzNwq2CccsU0FB/ebKbyfENh17aJ7Hk1/EOiLy7DjmF
	fdO3T5Ii4hMQG/gx+KOzzWF4LVt8Q26iX4Fqzy63VsLR+ed0UQy07v2EzgB5Nt5j+4WTCu
	P0xrU7oZgEOREVzZQ4CZu0fA6akEsa4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH 1/4] tools/libs/evtchn: don't set errno to negative values
Date: Wed, 20 Apr 2022 09:31:16 +0200
Message-Id: <20220420073119.16974-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420073119.16974-1-jgross@suse.com>
References: <20220420073119.16974-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Setting errno to a negative value makes no sense.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/evtchn/freebsd.c | 2 +-
 tools/libs/evtchn/minios.c  | 2 +-
 tools/libs/evtchn/netbsd.c  | 2 +-
 tools/libs/evtchn/solaris.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/libs/evtchn/freebsd.c b/tools/libs/evtchn/freebsd.c
index c4d075350b..422836f1a1 100644
--- a/tools/libs/evtchn/freebsd.c
+++ b/tools/libs/evtchn/freebsd.c
@@ -58,7 +58,7 @@ int osdep_evtchn_close(xenevtchn_handle *xce)
 
 int osdep_evtchn_restrict(xenevtchn_handle *xce, domid_t domid)
 {
-    errno = -EOPNOTSUPP;
+    errno = EOPNOTSUPP;
 
     return -1;
 }
diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
index 65cfccfd09..8ff46de884 100644
--- a/tools/libs/evtchn/minios.c
+++ b/tools/libs/evtchn/minios.c
@@ -143,7 +143,7 @@ int osdep_evtchn_close(xenevtchn_handle *xce)
 
 int osdep_evtchn_restrict(xenevtchn_handle *xce, domid_t domid)
 {
-    errno = -EOPNOTSUPP;
+    errno = EOPNOTSUPP;
 
     return -1;
 }
diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c
index 0b223c4beb..2de9cefc67 100644
--- a/tools/libs/evtchn/netbsd.c
+++ b/tools/libs/evtchn/netbsd.c
@@ -53,7 +53,7 @@ int osdep_evtchn_close(xenevtchn_handle *xce)
 
 int osdep_evtchn_restrict(xenevtchn_handle *xce, domid_t domid)
 {
-    errno = -EOPNOTSUPP;
+    errno = EOPNOTSUPP;
 
     return -1;
 }
diff --git a/tools/libs/evtchn/solaris.c b/tools/libs/evtchn/solaris.c
index 7fef88a73e..375a5f9b4f 100644
--- a/tools/libs/evtchn/solaris.c
+++ b/tools/libs/evtchn/solaris.c
@@ -53,7 +53,7 @@ int osdep_evtchn_close(xenevtchn_handle *xce)
 
 int osdep_evtchn_restrict(xenevtchn_handle *xce, domid_t domid)
 {
-    errno = -EOPNOTSUPP;
+    errno = EOPNOTSUPP;
     return -1;
 }
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:31:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:31:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308940.524878 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4o9-000745-Je; Wed, 20 Apr 2022 07:31:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308940.524878; Wed, 20 Apr 2022 07:31:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4o9-00072n-DY; Wed, 20 Apr 2022 07:31:25 +0000
Received: by outflank-mailman (input) for mailman id 308940;
 Wed, 20 Apr 2022 07:31:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh4o8-0006Tb-BJ
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:24 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dfdddeec-c07b-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 09:31:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 8615D2112B;
 Wed, 20 Apr 2022 07:31:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5694C13A30;
 Wed, 20 Apr 2022 07:31:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wED1E8m2X2IhXAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 07:31:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfdddeec-c07b-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650439881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8ofN2RF9Ov3D5sC5yESVJrU8I3one2H23BuRvfynNlI=;
	b=CFYyAfwKtHfiGQPN8PiSdhC2b12FJrOUyq3casjWcZCNkvp7W9stmazsqnXa4o/RhhTyeb
	MP/iSlvFo1wX/n/wZnwJjJeIbS2HQjVU/qQzGB2Hhj/P/NIyaGKm9k2L964JCsnPGxZTA+
	GeWxLSGo7DqukzpY3u4yJFuYIlGl5tQ=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH 3/4] tools/libs/guest: don't set errno to a negative value
Date: Wed, 20 Apr 2022 09:31:18 +0200
Message-Id: <20220420073119.16974-4-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420073119.16974-1-jgross@suse.com>
References: <20220420073119.16974-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Setting errno to a negative error value makes no sense.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/guest/xg_dom_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/guest/xg_dom_core.c b/tools/libs/guest/xg_dom_core.c
index c17cf9f712..c4f4e7f3e2 100644
--- a/tools/libs/guest/xg_dom_core.c
+++ b/tools/libs/guest/xg_dom_core.c
@@ -855,7 +855,7 @@ int xc_dom_devicetree_file(struct xc_dom_image *dom, const char *filename)
         return -1;
     return 0;
 #else
-    errno = -EINVAL;
+    errno = EINVAL;
     return -1;
 #endif
 }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 07:31:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 07:31:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308941.524895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4oB-0007U6-0C; Wed, 20 Apr 2022 07:31:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308941.524895; Wed, 20 Apr 2022 07:31:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh4oA-0007Se-PX; Wed, 20 Apr 2022 07:31:26 +0000
Received: by outflank-mailman (input) for mailman id 308941;
 Wed, 20 Apr 2022 07:31:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh4o9-0006Tb-Bi
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dffdddbc-c07b-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 09:31:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BA2DA2129B;
 Wed, 20 Apr 2022 07:31:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C00F13A30;
 Wed, 20 Apr 2022 07:31:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4Df0IMm2X2IhXAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 07:31:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dffdddbc-c07b-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650439881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nJP8UFG+Q9kAlZKRDuHPR38rUH2iyFSN6K0QfjZvvLU=;
	b=Ovt4EYJETbGH7VdDHAuTVyN/BTeMneYJiZxMS+aIokt9TIBLIMAXjnFd0Owa3s10y35Qae
	c9EGHttEJi/XCCazDcKM69R8xDJoQxcExc+g/3XzvsbTWCLCusURcU97q90mLlO1Ij6vcI
	aNnXVTV/gqcKSeZegnmti3RaaSlnSlY=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH 4/4] tools/libs/light: don't set errno to a negative value
Date: Wed, 20 Apr 2022 09:31:19 +0200
Message-Id: <20220420073119.16974-5-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420073119.16974-1-jgross@suse.com>
References: <20220420073119.16974-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Setting errno to a negative value makes no sense.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/light/libxl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/light/libxl_linux.c b/tools/libs/light/libxl_linux.c
index 8d62dfd255..27f2bce718 100644
--- a/tools/libs/light/libxl_linux.c
+++ b/tools/libs/light/libxl_linux.c
@@ -288,7 +288,7 @@ int libxl__pci_topology_init(libxl__gc *gc,
         if (i == num_devs) {
             LOG(ERROR, "Too many devices");
             err = ERROR_FAIL;
-            errno = -ENOSPC;
+            errno = ENOSPC;
             goto out;
         }
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 08:04:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 08:04:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308972.524906 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh5KA-0004xC-VX; Wed, 20 Apr 2022 08:04:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308972.524906; Wed, 20 Apr 2022 08:04:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh5KA-0004x5-Sb; Wed, 20 Apr 2022 08:04:30 +0000
Received: by outflank-mailman (input) for mailman id 308972;
 Wed, 20 Apr 2022 08:04:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh5KA-0004wz-Cj
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 08:04:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80743973-c080-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 10:04:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C28761F380;
 Wed, 20 Apr 2022 08:04:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E77313A30;
 Wed, 20 Apr 2022 08:04:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id /hRuJYy+X2JSagAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 08:04:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80743973-c080-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650441868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=OEc5VwXg/asXng3njAe1udGsbyNDGB6ncjnpuOLJcyg=;
	b=dhCIQlBq1C4d/blI+i/S/MUFxe24DyFePXLBW/bNoTQOurIzMZr/Uaee2uEtR0ORTiH/t5
	iAEPBmeh/mK+mTJn0UuX4GvKt283509HcTNmS2L84Gg9y1vIbiB8zvF5Kiih4PzYYBFqiJ
	Ivay+zy9A7wqo1jHNmfQ5qcNFrvm70o=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2] tools/libs/light: update xenstore entry when setting max domain memory
Date: Wed, 20 Apr 2022 10:04:26 +0200
Message-Id: <20220420080426.7036-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

libxl_domain_setmaxmem() called during "xl mem-max" should update the
domain's memory/static-max Xenstore node, as otherwise "xl mem-set"
won't be able to set the memory size to the new maximum.

Adjust the related comments and documentation accordingly.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- adjust comments and docs (Anthony Perard)
---
 tools/libs/light/libxl_mem.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_mem.c b/tools/libs/light/libxl_mem.c
index c739d00f39..92ec09f4cf 100644
--- a/tools/libs/light/libxl_mem.c
+++ b/tools/libs/light/libxl_mem.c
@@ -20,8 +20,7 @@
 /*
  * Set the maximum memory size of the domain in the hypervisor. There is no
  * change of the current memory size involved. The specified memory size can
- * even be above the configured maxmem size of the domain, but the related
- * Xenstore entry memory/static-max isn't modified!
+ * even be above the configured maxmem size of the domain.
  */
 int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t domid, uint64_t max_memkb)
 {
@@ -82,6 +81,15 @@ int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t domid, uint64_t max_memkb)
         goto out;
     }
 
+    rc = libxl__xs_printf(gc, XBT_NULL,
+                          GCSPRINTF("%s/memory/static-max", dompath),
+                          "%"PRIu64, max_memkb);
+    if (rc != 0) {
+        LOGED(ERROR, domid, "Couldn't set %s/memory/static-max, rc=%d\n",
+              dompath, rc);
+        goto out;
+    }
+
     rc = 0;
 out:
     libxl_domain_config_dispose(&d_config);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 08:11:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 08:11:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308977.524919 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh5R0-0006Ny-Pv; Wed, 20 Apr 2022 08:11:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308977.524919; Wed, 20 Apr 2022 08:11:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh5R0-0006Nr-KM; Wed, 20 Apr 2022 08:11:34 +0000
Received: by outflank-mailman (input) for mailman id 308977;
 Wed, 20 Apr 2022 08:11:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh5Qz-0006Nh-Nw; Wed, 20 Apr 2022 08:11:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh5Qz-0002ju-Mv; Wed, 20 Apr 2022 08:11:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh5Qz-00029t-BQ; Wed, 20 Apr 2022 08:11:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh5Qz-0001bp-Af; Wed, 20 Apr 2022 08:11:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qqGgqPImu7X06qszY79lRbRBcTsCn5cUEWNY4snVXa8=; b=Fm+bwUMETnOflAdoX0mfaNPtep
	b375GWOi3h/YuJ6+5fihpY6GP5cfZGnpLXsPXtcINZU1yUplbhYWIyHY8obKvpbeSC3ncH/kYX88/
	FkJct1Q/uS6prL9/uBVbbNLaLJICw7A6zWvgavSfPGa9KzQuwAy/d2/hsqjZfQ/D9Qnk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169561-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169561: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 08:11:33 +0000

flight 169561 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169561/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  518 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   23 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 08:13:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 08:13:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308985.524928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh5Si-000794-4E; Wed, 20 Apr 2022 08:13:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308985.524928; Wed, 20 Apr 2022 08:13:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh5Si-00078x-1N; Wed, 20 Apr 2022 08:13:20 +0000
Received: by outflank-mailman (input) for mailman id 308985;
 Wed, 20 Apr 2022 08:13:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Uk4w=U6=cantab.net=dvrabel@srs-se1.protection.inumbo.net>)
 id 1nh5Sh-00078r-97
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 08:13:19 +0000
Received: from smarthost01c.ixn.mail.zen.net.uk
 (smarthost01c.ixn.mail.zen.net.uk [212.23.1.22])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bbb32ffe-c081-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 10:13:18 +0200 (CEST)
Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk)
 by smarthost01c.ixn.mail.zen.net.uk with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <dvrabel@cantab.net>)
 id 1nh5Sc-0003Ew-E9; Wed, 20 Apr 2022 08:13:14 +0000
Received: from apple.davidvrabel.org.uk ([82.70.146.43])
 by pear.davidvrabel.org.uk with esmtp (Exim 4.94.2)
 (envelope-from <dvrabel@cantab.net>)
 id 1nh5SS-000NMg-EF; Wed, 20 Apr 2022 09:13:13 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbb32ffe-c081-11ec-a405-831a346695d4
Message-ID: <4c40abc3-10b4-a1c1-8bfe-5ac8539f1075@cantab.net>
Date: Wed, 20 Apr 2022 09:13:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220419150134.64704-1-dvrabel@cantab.net>
 <c65c58d3-e553-4247-680a-4d072b1c7c05@suse.com>
From: David Vrabel <dvrabel@cantab.net>
In-Reply-To: <c65c58d3-e553-4247-680a-4d072b1c7c05@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 82.70.146.43
X-SA-Exim-Mail-From: dvrabel@cantab.net
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	pear.davidvrabel.org.uk
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,NICE_REPLY_A,
	SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no
	version=3.4.6
Subject: Re: [PATCH v1] page_alloc: assert IRQs are enabled in heap alloc/free
X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000)
X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk)
X-Originating-smarthost01c-IP: [82.70.146.41]
Feedback-ID: 82.70.146.41



On 20/04/2022 07:26, Jan Beulich wrote:
> On 19.04.2022 17:01, David Vrabel wrote:
>> From: David Vrabel <dvrabel@amazon.co.uk>
>>
>> Heap pages can only be safely allocated and freed with interuupts
>> enabled as they may require a TLB flush which will send IPIs.
>>
>> Enhance the assertions in alloc_xenheap_pages() and
>> alloc_domheap_pages() to check interrupts are enabled. For consistency
>> the same asserts are used when freeing heap pages.
>>
>> As an exception, during early boot when only 1 PCPU is online,
>> allocations are permitted with interrupts disabled.
> 
> This exception is tightly coupled with spin lock checking, i.e. the
> point in time when spin_debug_enable() is called. I think this wants
> making explicit at least in the code comment, but as a result I also
> wonder in how far the extended assertions are really worthwhile: Any
> violation would be detected in check_lock() anyway. Thoughts?

I was caught out by stop_machine_run() disabling both interrupts and 
spin lock debugging when running the action function, so check_lock() 
didn't help in this (admittedly) narrow use case.

> Furthermore I'm concerned of Arm not using either SYS_STATE_smp_boot
> or spin_debug_enable().

David


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 08:44:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 08:44:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.308994.524940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh5we-0002Rb-DM; Wed, 20 Apr 2022 08:44:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 308994.524940; Wed, 20 Apr 2022 08:44:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh5we-0002RU-9a; Wed, 20 Apr 2022 08:44:16 +0000
Received: by outflank-mailman (input) for mailman id 308994;
 Wed, 20 Apr 2022 08:44:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh5wd-0002RO-Bj
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 08:44:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0d089841-c086-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 10:44:12 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2058.outbound.protection.outlook.com [104.47.9.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-YyH2zUmBPhqKo9Iyvfi8jQ-1; Wed, 20 Apr 2022 10:44:10 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4431.eurprd04.prod.outlook.com (2603:10a6:803:6f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 08:44:08 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 08:44:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d089841-c086-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650444252;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NTFusKZ4cbi3kBlkqkpKnfA3hvI9tKTF/dHM/jhK5+Q=;
	b=KIyELKuQlCnXdG7eQk2vFD62vpLUFCgw1MsIb6fFce8g2bh/Eidoagcp+6IX7iiXdPtA65
	QaOoC+Le1+d9a3MCR7wYCX1GmeBt239F46hXRBVj35o2QvcfYSWoWeU007AznqX8kiJeUY
	2bFodVBdzD1maDzkZIe5cl3rb9EZD3U=
X-MC-Unique: YyH2zUmBPhqKo9Iyvfi8jQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bAq7/Z4dPemCpFunou+mMP5caV/9zZNUdHMUlI6q47YfjlN3jPDBu4blJn2DIxxyIWnJxx8uJjsxWLqVgZlgrCEvT9tjE75UhXr1Vmq1MKUjylKCsUwwGTYRrF5sv7pc7Ty8EX2xJT4gTxXWJ8wE9b1vOs7xPdxQVCHKHiJbxgXfu4Q4upC/4MKTkbBeIoEmsG+IxMJXZll8G+ghxjh+ACKXgpfv/JJd+3Qx45Xl5LuG9j8AK5mALypU5KfITyEf6k5ByG7wTGQkC4jvljJqv/IgEF9uIMTWs3omYIU2EqEKw9zmFnAGj84Vyxi3y3p7+KUccSb8nPFaZgdRgB46cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NTFusKZ4cbi3kBlkqkpKnfA3hvI9tKTF/dHM/jhK5+Q=;
 b=Z/Ee/OBkUs/z8DNdopJIoBC5uBxzrnjNDtgIomP9gYmFDUbVB/I0SuAdYrW6j8nghvt5tbLMg1u4X8yF4idCqFsDYHd7mF9B9WBJU4dhKEfsxm1sywm92riX70BchC1M1UoxychiSKzw1nUM4ojtCD5MS76v7QKWnAjUhLz2SW3IE4o37cnJh5t0dofXq2qbj1dd3AOnpV6yfWN/ycFZwInTfOhi+S3ir0ckJFiZZRVxKuDgtk1q6A6m1IJhCYlOASS9ZA3Cv/dtjsqeGjQZqye0ENFc6J56Y058+ER0bRrvIi2+4ejnPc8VLOdNsNe1OEyftdY8/BsAlANV/lzIWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1c6196c2-1faa-efdb-1dc7-6dda3c426dfc@suse.com>
Date: Wed, 20 Apr 2022 10:44:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220419150134.64704-1-dvrabel@cantab.net>
 <c65c58d3-e553-4247-680a-4d072b1c7c05@suse.com>
 <4c40abc3-10b4-a1c1-8bfe-5ac8539f1075@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4c40abc3-10b4-a1c1-8bfe-5ac8539f1075@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0137.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 18d8babf-3022-4f6b-980d-08da22a9eeca
X-MS-TrafficTypeDiagnostic: VI1PR04MB4431:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4431F0970CE1D396CF4914E5B3F59@VI1PR04MB4431.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JjgxEEwOldVptpbh0TwYgCjR8Edkbz6a/P4rstofA8xIPlcLKmLLl8bVnDfs0VDVt/NlgWgnGWcE+ehS/5qhRA17nZyt2rTJt6Zm+xwLgS6B4XP+C2/ZDMNsqnWG0bxFpKjVuFibaNbvllPsNe/F8HPjMXpTccSgrwuhQvt2qwuSACJiG4N1NaSHmpJ7Zr6aMhzHqcDPN0GwIlRHqEIsPtNCMAL0BzFtCu5xNlHntsTz41mHqHndxOtIJtJANNcVkynVkhcLw9Cwt8acGI+KCUsmuqE1dLGZ8iCusBJEmH8hzqrgPwqGZHgGsicu1LJC1T6UjIGXEwPi1ZK4TluQL9kUkBvW+8wYe+CIMw/PV+2z0MMMi9gabH+0kjCtE4zpPqRYab8cGn92rsBcysvCQovmJM8BomU4G2eLUFCf/ABkN5EEsBHi7vEwFpaj5nftj1R3zhXDTozgQI2wrig+DzI0SWnXHo2g4qHOJPMQe5y99vXCdeGQYIXBRLeRxnvxJNTgYjRoSMOtxyNXCJ3xs3K6VBRqOmv1kdfGc2TwwWy78umBfLxkZrwI51Bo5+CP+xGeFoWq7G+v98Ebvfp1wxEcPB9NooYsb0wDnspsZs7ab6lwRskz/LyWUt0bzMk+Q2xaCRtd06Jua3gQefW/KBVd4eLV0sWItVresBVHw6RAS2lJKNZjT5QPWot+KTiWlBvSLU/OxbKJzVlS8znggn6+3IT6kNJFz7Z1RTVm9OA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(4326008)(6916009)(6486002)(66946007)(38100700002)(83380400001)(66556008)(316002)(5660300002)(66476007)(2616005)(31686004)(8676002)(86362001)(31696002)(186003)(26005)(2906002)(36756003)(6512007)(6506007)(6666004)(8936002)(54906003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dUhtMEhVSzRQaXdiR2NPUDRlV01nRkpMNDMreUIzdzJRY1NqVjN3WTRMekJ0?=
 =?utf-8?B?OS9BMWw5enBISDhNRUVOZmJ4Z2h6UGIzUWhDemxNMm1sMUpPWDQwVVUyTGJV?=
 =?utf-8?B?eEZXeHR0bVBnaHI0Q2RHU1FybFlGSFNVRnBTY0xnY3ZCZCtCOVRUZGNrWk9w?=
 =?utf-8?B?VzcvY3F2a2ZIM1B5QWI2bHo0V1Frd2pQeUNhV2M1Z1RyT3Bhenhabk8waGxB?=
 =?utf-8?B?TWUrN2VjM2o1QktOaW5NVXM1SGx2eUk2Zm9xVk9ScExycm9hdkxvL3UvVFpM?=
 =?utf-8?B?RUNINHNKNFdDMTJ1TlpqRzFjSGUyMmQ5dzNlMWVQVU1TcTFHOHV1c3F6ZDFF?=
 =?utf-8?B?ZmkvUHN2WHkwZ2dYMFNSRCt6UTY4bGhGSzUwVjNXRWcveWM4ZHJlSzNvamJW?=
 =?utf-8?B?ck9Wa21nNjQrVmRBVno3dEtZMGViMjFwSHZtazBaY3EvN2paajZRc3pzUFhR?=
 =?utf-8?B?Ym5BOG9HOUFKSlJKdVdjWnBROVNLMmFzc3RHQTc4WVN3S1FSUEIzbDdIRzk1?=
 =?utf-8?B?bkNtN1ArL3djdEdSNUVSOWcybWc5QnJZemNEZXVGalZuQTVlR2FhZ00xTm11?=
 =?utf-8?B?OTJFQVJzWktKbFhZeXAwREU1TE1NR1dUZnR0MDJxU0xJR2tvM1FQTmhGYUdt?=
 =?utf-8?B?RWhPdFZ4Rlo3eGEyMTFqUDJoREUyaHQzRTlGUDc3QlE1NGlsQnNTVW4zTU8v?=
 =?utf-8?B?NFgvSHErbkE0S0s2TitaUTR3WmIyUnBNWTVXNlpLN083RGNZYWFpSGtjUnhh?=
 =?utf-8?B?S1VkQjlwK3VBeWJWK0FjRUVJTzlMYkdLK0M4NXVSVUJEd2Nid3JuVVdPc1hj?=
 =?utf-8?B?VlljUnpFVTFwR1hRTldSaFhEM29JZnhsTUlJOVNZOHJBTW00eStWZUZUeHJu?=
 =?utf-8?B?NU5YM0NQd3lqa0xCc0EvK2dEQzZ2c2xWVVhlTmNKcFNBN01OWlVkS1BxT2tn?=
 =?utf-8?B?bFhOL2ptVzBVUkhnTHNVSG5ZOWo5cEl4ZGJzNHBsYWhQZlBUazFxVHVodGs1?=
 =?utf-8?B?TGEremtaTDA0NUtkWHNjOWdJbmhmQkpyczZaUkhlaHBHZFdvN3B5cXgxR3Rq?=
 =?utf-8?B?MUpac29mS2xVcFViR05sS2ovbUQxQU5RVnVlSm1DRUl2SmNEOTFaTHkrZnhR?=
 =?utf-8?B?WjRaSVppQ09RQUNYQnkxTE9vRlRESGErRG9RbEUvLzcycWFYWTl1VTRCd1Ey?=
 =?utf-8?B?RnZnMjZhd3N3RXZsZ3JYRmpKNlc0Ty9FMkF6ZUppRjVVV0ZSMWQvb201V28z?=
 =?utf-8?B?UW9PcU00VzRnSjU4SEZRUnlWRXM4dER1Wnd6WVcxZWRCZW0yb0h5dkE3SnpR?=
 =?utf-8?B?Unh0MTFkWEIwVjBQNEl5aCtXSWtRdkUzK1JaUCtTd2RNNHpQemFIWk5BZU1M?=
 =?utf-8?B?OHlFWFcxOUtzdE80VWM5cEltOTd6dzhseXROZ0RicHdZa3JaQlFRZ0owNmVH?=
 =?utf-8?B?V1BwcVl1ZDFvd3ZOdDhHWSthSnFwWHJENlpnTTNZVGtzdVNVN3RQQlJrU0xC?=
 =?utf-8?B?Qk5NSkhRcktlSHp5UnV3ZkVyckVWdk9jdTFZRmM0blRXdDZZWTd6Q0RaZWRL?=
 =?utf-8?B?V2lueDBLUnlNdUp4UmFQU043UGFsTDV2VlVNOTlsZWpFaG9mZ1lLdXdYQlYy?=
 =?utf-8?B?TW9yQllKNElrNmREYis4bGVqVW5ENlUvNHZuQVlIN2FQUy9GRndxNU5VQXRL?=
 =?utf-8?B?SUFqYzZHUjVmdE5ML0ZxdVZrNHord0NRQVlESDUxTGRtTUE5NjFpMkl0RGNy?=
 =?utf-8?B?amlMdGx3dmpjbFV3VnQwZEJlcXA0YlBibE5HbWpiTWRkdUFBWE9HWVFxbkxm?=
 =?utf-8?B?UmdVbXJiQXAzbmMwbW9ScFhSd3d1WXFrTVo0MnFVSUJOZEVpbmQzQUdLbzhj?=
 =?utf-8?B?ZUpTYnBsL1lGbUttUjltVWRlU2xTdUZqeUNnRjgxZ0xWNnlFV3ZIQVNHeTIw?=
 =?utf-8?B?R215ckc0NE52RjRCN1ErZmZKZGpaeFI4NjMxM0xDbmZiV3dVTjM3RGI2VzNL?=
 =?utf-8?B?bzlJK3cyK1FUWTE3cUVnRVVTUWNlWHNXMHRmU3ZUSnBZR21qaUI2aE9paWZP?=
 =?utf-8?B?QnUvMlJ3RlIvWGxSUE1KMUNEdlBSZkt2ckNpb3JxM1pOK2JWeXpZaTExM2Zj?=
 =?utf-8?B?NFFIWWphdXY5Ujk0dkdBOS81ZzBuNkRXRk55Q1E4eDBxUklIcVVnTE0xQWYz?=
 =?utf-8?B?eDNzaktoTXpPNEZ0ellpek9YVk5kamE3R0FPSzZDSkE0ODY5ZmgxaDFlY2w2?=
 =?utf-8?B?c0dDbnRkK2lzR2ZLYXhBL0JJbzlkTkIyMFpiMk1IdjdwcWYweGZpN2dSUlk4?=
 =?utf-8?B?YllLTXg2VkNwL253Mkxackc5M0tnZG9BeFZzOTFaYUdHSjF6L3A3UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18d8babf-3022-4f6b-980d-08da22a9eeca
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 08:44:08.0073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AumpMZrEnQN0GVHWr9CwWuzJ1mpHYCXFJoGfyYpM2yjzLyXPPZBKBW51zUhE1pRRVBClPFg81+TDFoJHmOZPug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4431

On 20.04.2022 10:13, David Vrabel wrote:
> 
> 
> On 20/04/2022 07:26, Jan Beulich wrote:
>> On 19.04.2022 17:01, David Vrabel wrote:
>>> From: David Vrabel <dvrabel@amazon.co.uk>
>>>
>>> Heap pages can only be safely allocated and freed with interuupts
>>> enabled as they may require a TLB flush which will send IPIs.
>>>
>>> Enhance the assertions in alloc_xenheap_pages() and
>>> alloc_domheap_pages() to check interrupts are enabled. For consistency
>>> the same asserts are used when freeing heap pages.
>>>
>>> As an exception, during early boot when only 1 PCPU is online,
>>> allocations are permitted with interrupts disabled.
>>
>> This exception is tightly coupled with spin lock checking, i.e. the
>> point in time when spin_debug_enable() is called. I think this wants
>> making explicit at least in the code comment, but as a result I also
>> wonder in how far the extended assertions are really worthwhile: Any
>> violation would be detected in check_lock() anyway. Thoughts?
> 
> I was caught out by stop_machine_run() disabling both interrupts and 
> spin lock debugging when running the action function, so check_lock() 
> didn't help in this (admittedly) narrow use case.

Oh, I see - fair point.

Jan

>> Furthermore I'm concerned of Arm not using either SYS_STATE_smp_boot
>> or spin_debug_enable().
> 
> David
> 



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 08:52:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 08:52:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309001.524951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh645-00049q-8h; Wed, 20 Apr 2022 08:51:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309001.524951; Wed, 20 Apr 2022 08:51:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh645-00049j-5e; Wed, 20 Apr 2022 08:51:57 +0000
Received: by outflank-mailman (input) for mailman id 309001;
 Wed, 20 Apr 2022 08:51:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TcYK=U6=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nh642-00049Z-UF
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 08:51:55 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20611.outbound.protection.outlook.com
 [2a01:111:f400:7d00::611])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1f707463-c087-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 10:51:52 +0200 (CEST)
Received: from DU2PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:10:232::18)
 by DB8PR08MB5244.eurprd08.prod.outlook.com (2603:10a6:10:e6::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 08:51:50 +0000
Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:232:cafe::8d) by DU2PR04CA0073.outlook.office365.com
 (2603:10a6:10:232::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Wed, 20 Apr 2022 08:51:50 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Wed, 20 Apr 2022 08:51:50 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Wed, 20 Apr 2022 08:51:50 +0000
Received: from f76dc26750c8.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 75A265C8-E52E-4A11-92B1-A846EC45A04D.1; 
 Wed, 20 Apr 2022 08:51:44 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f76dc26750c8.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 08:51:44 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by VI1PR08MB4429.eurprd08.prod.outlook.com (2603:10a6:803:100::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 08:51:42 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%7]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 08:51:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f707463-c087-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ag9sMdIW+eSpTefTYnIcUxUWvT7sMU2kL25E7VpC+jg=;
 b=qA1Lhoqy/LHowgGJFjIbaHtf49fgbW1u+2kI1gXbeOfp4QdchyOKr3uvQEic0uHc/HUwGPTLii8+dhwzIQoZqH/HIr6LqPmhgxHXQXEWlLfrpOU+d1vE+8Pdd+joqSAnyRZXYoMKwGK5Pf5XjZrRPAIAyYAl0v+bXTWiYoxwLYw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VY/JQC14i9/cedOFIamqvWiFdXJDyvAY80gSUQciC8ThhJ6TnW/Zuj524ZaqEmeyg972ZZLiZw0IRXO35tgRTLHpWGGvAbHWrXMx0hmO04qJLCsFB6YfixpQFmSOUmqRXvnYu85LoFbUOJKseWqbvTpqI48Zobise63D+WzNPxIz380ZxELcRwa3GZceMX7e9eZh7tkaAf2N/aVMzFWd9kJNgOokE3ifC9jLIC3/nACq3OfS6DxXKpguZU/toTesNpXRqzMvfIygInlTRMMDxO/5myKKVwdzpHhG0Jjz3pt8WdK5SmRke0Z88rLW8tm92+TS0oIW2SEs7TLTY9Cevg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ag9sMdIW+eSpTefTYnIcUxUWvT7sMU2kL25E7VpC+jg=;
 b=XklvlfJvAgupJblcMzsCSwytOPyLkh4Q8RjzI3iQRO529ybJgEDHEsOGZuN3I9N9m037PKV9OJ3QB0Gqu0EI0pyxBgbss4ljYkwAZWDNVXUmx2lhcs2hqXRx4//VUYSNDAG9xBMkoFNixgs3x0/0WTD60/atDhXX2j97alw95Hc00S2ZW+US8bigL3LTSNIJNfWDdcsDYL8p8UgXugtgE7IswLIuDlclnm20EYwjX1ApzEGZEJwJ5I0OjOeXgQ7MeeHrOyGHgAGN2gxI3yXAMBnDJ2cw3DwWYEYGd6E5KmhWFc3gRJHa1RZAczvKUvx2074bykGQmnQPdEwhb9aHOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ag9sMdIW+eSpTefTYnIcUxUWvT7sMU2kL25E7VpC+jg=;
 b=qA1Lhoqy/LHowgGJFjIbaHtf49fgbW1u+2kI1gXbeOfp4QdchyOKr3uvQEic0uHc/HUwGPTLii8+dhwzIQoZqH/HIr6LqPmhgxHXQXEWlLfrpOU+d1vE+8Pdd+joqSAnyRZXYoMKwGK5Pf5XjZrRPAIAyYAl0v+bXTWiYoxwLYw=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: nd <nd@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
Thread-Topic: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
Thread-Index: AQHYNQ8JUHwL/QpeQ0iCIDnkwGGL/6zmznEAgBHpDbA=
Date: Wed, 20 Apr 2022 08:51:41 +0000
Message-ID:
 <DU2PR08MB73254E135A19B413CDC14DCFF7F59@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-7-Penny.Zheng@arm.com>
 <c4a3fb77-1cab-aacf-a2a5-3702f9c4ab97@xen.org>
In-Reply-To: <c4a3fb77-1cab-aacf-a2a5-3702f9c4ab97@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 400414F15EB49247AB5163A93FD79E88.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: a4dd8eeb-c449-4420-806d-08da22ab0282
x-ms-traffictypediagnostic:
	VI1PR08MB4429:EE_|DB5EUR03FT014:EE_|DB8PR08MB5244:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB524445FA5A2DD078DC50E855F7F59@DB8PR08MB5244.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 WPITMJaUAlYL5f1r6wh1fcw/jUBDQtQvyud0EQl9xEU5/Gr3E9bfvzdUOeFQTpg/TU/T7wqOTI0WARWhm4+Pd5ZWwrwZmckxtebuXiGg/CENFCcUjWPYwR90c5JIYhD26REFLnY8B8mjD3eitFNWwd9mdTtsuFopkw+DOCafSPJxYBEa2VTd6f92KbMom27M0OKCqew57lFo8A2MWCCM6vifKyWmyUzOpNSnjXPlFhVKHZLomruM1RsrrWrPsgyv+fmakKs19D4TJgAUTeHGvhM3lL8gP0Dn+lLfe3pD+6QYMwUn8W0tWA+WoiU7+kXZMeiwlVgNZnEjve6iTbVbURBDuEKtoqHVlCkY+F5xRstHKReV/g7j3DYqFyXvMySCpgzxDHvQjv3JxpTu3fvcMZxYTqmN56QN/39eMqHa+/bTLTZN/z/4MQYXNh/tpiGW2IbobGYYIJzOtSz/FdocX6Qtl/C4dHI4IELPCTmmWW4xUh8Y1KGBQghxWRCS1FdA1WIGOOO93z0Ot4hiebkLCqUqNuUm8CvkpyllDIG2eRHYc94nm9lFx1Nb4kxPTHn6HqXIpDG22HNZPop7JDbQ8FMAkcAjN2/t3zFFgFqmA5jqvFrJ4C7Vs7ZsTqb3mmtqaWEuxqdBSPadbV8zU9VDU7Zy2Wd8H0B+KEOCMF96lAk+hZuSvn9AJ0ZepeGtpccoJTzFNG/m5A0ak2FqTUabcQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(38070700005)(38100700002)(508600001)(71200400001)(52536014)(5660300002)(7696005)(8676002)(86362001)(8936002)(55016003)(4326008)(9686003)(53546011)(64756008)(122000001)(33656002)(6506007)(66556008)(66946007)(76116006)(186003)(110136005)(54906003)(26005)(83380400001)(66476007)(316002)(66446008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4429
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5ee2328f-2e35-436b-6d2b-08da22aafd96
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RnEgzwgTw+5p5HsvOK9irG8RecE21IkNInC4XODYtnIyHzrN7gBOjVq2QqRfPxZEk7I0tl/Fkes2NEl65Jz2Lwhqc03Ij3tIlkTsPKUKUF6f2lyGQQTWTAfNQDkgrbNSAWP0f5w7Dn24aUfINC6k7fOnUKuXMkjNgxLfQhG4c7jnFaCMTXimdhekHxQgu+ICmRjIwPNLbMcEnD/SkVcdynnTLznXYnsvu6M+Rrfv5Bf7KeODE1vX0dPnzQ6/FRnBbH6OleboiMJ+RLz/lbO4kM8ZTK/LoDH2MyFFYDAMInaBN1tL5zMc8jhJUbrpKeYBYGuvSlV6m4e+eOllqFx/Kt8RXCrhaHzr+qX77VTuVCHGilvVnboHkiJygqHp46tB8IWHorD6nvZKXgSwSIadqneWgTb+oIkcoe+QK9JbOWt+OUSVB/kx5gfCmeJxHSWYL5xLR56IfxaptJSU69dF3aWlJ+Sz2rwJAtYiECQE4ivJO0w9hxKwOL7we4+M0r90KaATfDrrje8lxop0ZQzp93FwjN2IAliVwqwYLG9ddYngCcWWib5Lnv3Eghk8HtvkfJBBAyoxB61dfbHK3xfvfxK1ZAaSW3AeWaf25uEMc7b1YmghtnhSPCkg7zIlvBC2SwS5BMrF42JkyRR5e9GcIs9b9E33a0J1JOstpI/MJetLda996f/CSaQ89y0Uak/Z
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(70206006)(81166007)(4326008)(8676002)(70586007)(8936002)(186003)(26005)(7696005)(86362001)(9686003)(53546011)(52536014)(5660300002)(33656002)(36860700001)(6506007)(55016003)(2906002)(336012)(508600001)(47076005)(54906003)(110136005)(107886003)(316002)(356005)(40460700003)(82310400005)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 08:51:50.3049
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a4dd8eeb-c449-4420-806d-08da22ab0282
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5244

SGkganVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogU2F0dXJkYXksIEFwcmlsIDksIDIwMjIg
Njo1OSBBTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4tZGV2
ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBT
dGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQNCj4gTWFycXVpcyA8
QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15
cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYxIDA2LzEzXSB4ZW4v
YXJtOiBzZXQgdXAgc2hhcmVkIG1lbW9yeSBmb3JlaWduDQo+IG1hcHBpbmcgZm9yIGJvcnJvd2Vy
IGRvbWFpbg0KPiANCj4gSGkgUGVubnksDQo+IA0KPiBPbiAxMS8wMy8yMDIyIDA2OjExLCBQZW5u
eSBaaGVuZyB3cm90ZToNCj4gPiBGcm9tOiBQZW5ueSBaaGVuZyA8cGVubnkuemhlbmdAYXJtLmNv
bT4NCj4gPg0KPiA+IFRoaXMgY29tbWl0cyBpbnRyb2R1Y2VzIGEgbmV3IGhlbHBlciBndWVzdF9w
aHlzbWFwX2FkZF9zaG0gdG8gc2V0IHVwDQo+ID4gc2hhcmVkIG1lbW9yeSBmb3JlaWduIG1hcHBp
bmcgZm9yIGJvcnJvd2VyIGRvbWFpbi4NCj4gPg0KPiA+IEZpcnN0bHkgaXQgc2hvdWxkIGdldCBh
bmQgdGFrZSByZWZlcmVuY2Ugb2Ygc3RhdGljYWxseSBzaGFyZWQgcGFnZXMNCj4gPiBmcm9tIG93
bmVyIGRvbV9zaGFyZWQuIFRoZW4gaXQgd2lsbCBzZXR1cCBQMk0gZm9yZWlnbiBtZW1vcnkgbWFw
IG9mDQo+ID4gdGhlc2Ugc3RhdGljYWxseSBzaGFyZWQgcGFnZXMgZm9yIGJvcnJvd2VyIGRvbWFp
bi4NCj4gPg0KPiA+IFRoaXMgY29tbWl0cyBvbmx5IGNvbnNpZGVycyBvd25lciBkb21haW4gaXMg
dGhlIGRlZmF1bHQgZG9tX3NoYXJlZCwNCj4gPiB0aGUgb3RoZXIgc2NlbmFyaW8gd2lsbCBiZSBj
b3ZlcmVkIGluIHRoZSBmb2xsb3dpbmcgcGF0Y2hlcy4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6
IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+ICAgeGVuL2Fy
Y2gvYXJtL2RvbWFpbl9idWlsZC5jIHwgNTINCj4gKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKw0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKykNCj4gPg0K
PiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4vYXJjaC9h
cm0vZG9tYWluX2J1aWxkLmMNCj4gPiBpbmRleCA5ODRlNzBlNWZjLi44Y2VlNWZmYmQxIDEwMDY0
NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+ICsrKyBiL3hlbi9h
cmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+IEBAIC03OTgsNiArNzk4LDQ4IEBAIHN0YXRpYyBp
bnQgX19pbml0IGFsbG9jYXRlX3NoYXJlZF9tZW1vcnkoc3RydWN0DQo+IGRvbWFpbiAqZCwNCj4g
PiAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICAgfQ0KPiA+DQo+ID4gK3N0YXRpYyBpbnQgX19pbml0
IGd1ZXN0X3BoeXNtYXBfYWRkX3NobShzdHJ1Y3QgZG9tYWluICpvZCwgc3RydWN0IGRvbWFpbg0K
PiAqYmQsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNp
Z25lZCBsb25nIG9fZ2ZuLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdW5zaWduZWQgbG9uZyBiX2dmbiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbnJfZ2Zucykgew0KPiA+ICsgICAgc3RydWN0
IHBhZ2VfaW5mbyAqKnBhZ2VzID0gTlVMTDsNCj4gPiArICAgIHAybV90eXBlX3QgcDJtdCwgdDsN
Cj4gPiArICAgIGludCByZXQgPSAwOw0KPiANCj4gWW91IGRvbid0IG5lZWQgdG8gaW5pdGlhbGl6
ZSByZXQuDQo+IA0KPiA+ICsNCj4gPiArICAgIHBhZ2VzID0geG1hbGxvY19hcnJheShzdHJ1Y3Qg
cGFnZV9pbmZvICosIG5yX2dmbnMpOw0KPiA+ICsgICAgaWYgKCAhcGFnZXMgKQ0KPiA+ICsgICAg
ICAgIHJldHVybiAtRU5PTUVNOw0KPiA+ICsNCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBUYWtl
IHJlZmVyZW5jZSBvZiBzdGF0aWNhbGx5IHNoYXJlZCBwYWdlcyBmcm9tIG93bmVyIGRvbWFpbi4N
Cj4gPiArICAgICAqIFJlZmVyZW5jZSB3aWxsIGJlIHJlbGVhc2VkIHdoZW4gZGVzdHJveWluZyBz
aGFyZWQgbWVtb3J5IHJlZ2lvbi4NCj4gPiArICAgICAqLw0KPiA+ICsgICAgcmV0ID0gZ2V0X3Bh
Z2VzX2Zyb21fZ2ZuKG9kLCBvX2dmbiwgbnJfZ2ZucywgcGFnZXMsICZwMm10LCBQMk1fQUxMT0Mp
Ow0KPiA+ICsgICAgaWYgKCByZXQgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHJldCA9IC1F
SU5WQUw7DQo+ID4gKyAgICAgICAgZ290byBmYWlsX3BhZ2VzOw0KPiA+ICsgICAgfQ0KPiA+ICsN
Cj4gPiArICAgIGlmICggcDJtX2lzX3JhbShwMm10KSApDQo+ID4gKyAgICAgICAgdCA9IChwMm10
ID09IHAybV9yYW1fcncpID8gcDJtX21hcF9mb3JlaWduX3J3IDoNCj4gcDJtX21hcF9mb3JlaWdu
X3JvOw0KPiA+ICsgICAgZWxzZQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHJldCA9IC1FSU5W
QUw7DQo+ID4gKyAgICAgICAgZ290byBmYWlsX3BhZ2VzOw0KPiANCj4gV2hlcmUgd291bGQgd2Ug
cmVsZWFzZSB0aGUgcmVmZXJlbmNlcz8NCj4gDQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAg
LyogU2V0IHVwIGd1ZXN0IGZvcmVpZ24gbWFwLiAqLw0KPiA+ICsgICAgcmV0ID0gZ3Vlc3RfcGh5
c21hcF9hZGRfcGFnZXMoYmQsIF9nZm4oYl9nZm4pLCBwYWdlX3RvX21mbihwYWdlc1swXSksDQo+
ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBucl9nZm5zLCB0KTsNCj4gDQo+
IEEgZmV3IHRoaW5nczoNCj4gICAgLSBUaGUgYmVnaW5uaW5nIG9mIHRoZSBjb2RlIGFzc3VtZXMg
dGhhdCB0aGUgTUZOIG1heSBiZSBkaXNjb250aWd1b3VzIGluDQo+IHRoZSBwaHlzaWNhbCBtZW1v
cnkuIEJ1dCBoZXJlLCB5b3UgYXJlIGFzc3VtaW5nIHRoZXkgYXJlIGNvbnRpZ3VvdXMuDQo+IElm
IHlvdSB3YW50IHRoZSBsYXR0ZXIsIHRoZW4geW91IHNob3VsZCBjaGVjayB0aGUgTUZOcyBhcmUg
Y29udGlndW91cy4NCj4gVGhhdCBzYWlkLCBJIGFtIG5vdCBzdXJlIGlmIHRoaXMgcmVzdHJpY3Rp
b24gaXMgcmVhbGx5IG5lY2Vzc2FyeS4NCj4gDQoNCk9oLCwgY2F1Z2h0IG1lLCBpdCBuZXZlciBv
Y2N1cnJlZCB0byBtZSB0aGF0IHRoZSBwYWdlcyBpbiBhcnJheSBgcGFnZXNgIGNvdWxkDQpiZSBk
aXNjb250aW51b3VzLg0KSSBkZWZpbml0ZWx5IHdhbnQgdGhlIGxhdHRlci4gVGhpcyBmdW5jdGlv
biBpcyBhbHdheXMgZGVhbGluZyB3aXRoIGEgbWVtb3J5IHJlZ2lvbg0KKGNvbnRpZ3VvdXMgTUZO
UykgZWFjaCB0aW1lLiBTbyBtYXliZSBhIGxvb3AgdG8gY2hlY2sNCnBhZ2VfdG9fbWZuKHBhZ2Vz
W2ldKSA9PSBtZm5fYWRkKHNtZm4sIGkpIGlzIG5lZWRlZC4NCg0KPiAgICAtIElJUkMsIGd1ZXN0
X3BoeXNtYXBfYWRkX3BhZ2VzKCkgZG9lc24ndCByZXZlcnQgdGhlIG1hcHBpbmdzLiBTbyB5b3UN
Cj4gbmVlZCB0byByZXZlcnQgaXQgaW4gY2FzZSBvZiBmYWlsdXJlLg0KPiANCg0KWWVzLCBib3Ro
IGZhaWx1cmUgcG9pbnRzIHlvdSBhcmUgcmVmZXJyaW5nIHRvIGFyZSByZXF1aXJpbmcgcmV2ZXJ0
aW5nIHRoZSBtYXBwaW5ncy4NCg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwN
Cg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 08:53:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 08:53:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309005.524962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh65f-0004je-KA; Wed, 20 Apr 2022 08:53:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309005.524962; Wed, 20 Apr 2022 08:53:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh65f-0004jX-HA; Wed, 20 Apr 2022 08:53:35 +0000
Received: by outflank-mailman (input) for mailman id 309005;
 Wed, 20 Apr 2022 08:53:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TcYK=U6=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nh65d-0004jQ-Rr
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 08:53:33 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20616.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::616])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5a908776-c087-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 10:53:32 +0200 (CEST)
Received: from AS9PR06CA0082.eurprd06.prod.outlook.com (2603:10a6:20b:464::31)
 by VI1PR0802MB2304.eurprd08.prod.outlook.com (2603:10a6:800:9f::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 08:53:28 +0000
Received: from VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:464:cafe::14) by AS9PR06CA0082.outlook.office365.com
 (2603:10a6:20b:464::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Wed, 20 Apr 2022 08:53:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT040.mail.protection.outlook.com (10.152.18.210) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Wed, 20 Apr 2022 08:53:27 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Wed, 20 Apr 2022 08:53:27 +0000
Received: from e103655df317.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 073F469A-7D00-4D90-8ABD-5E6465EEE14C.1; 
 Wed, 20 Apr 2022 08:53:21 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e103655df317.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 08:53:21 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by AM6PR08MB3175.eurprd08.prod.outlook.com (2603:10a6:209:3f::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 08:53:19 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%7]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 08:53:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a908776-c087-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LHuLvhDHe0Uvo5t3pxFzHum+9JqXq1sn83pWAijGLCk=;
 b=4lHKwF6Fdon58euinYwsYezuvgM2nj65/6y3Bgs1J3kY8W7VuBFHOyahcdsAVUjWfdgIx5tJ8miCWAp1Y9NM+X9M6h9bdUcDCn+Zbi0uvOPHyL49gYth6bme7Tb0HZJfT3ZyBLsW3nWLho6bvhFjc4NeCkqr1KIpY4g1nrH+b+M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 56be8d6473a12e14
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XbohvbtBVN+/0XhEoxRXOTHHHEtR9UE0GjpUKgtzJA03HH9AEMxFHoP92tuPJaqY+nOsfBP7nR9LvIFixkWiTioeGGNJiMFteVAVjgO2ihJovh6sZmK87sj4jbckPDtCSmCeAoZc16dQhIv5xVwjpHVAebJTx6PwR2InsK7CjXrffUGDeHZhglT16pvgXt/rrV6QcLOVtm+XZLDiSe6j61clTM/hqBT/G/BEuJ5tMTKELvVx0E7zylQGbFkP1BaYY5QFRsKM+wgQxMt9k/75mRu4Ctyekev7FEAOE8AY+bkTab2Dv9oyJbdTIY0u8QoLWZtVuCMHoFWAEYcrIok+Kw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LHuLvhDHe0Uvo5t3pxFzHum+9JqXq1sn83pWAijGLCk=;
 b=WFkfLbDgBoLgErWw87wWSmm2czGOcV29kRubZizHOnIDhNbkCy2i56UkWg20OvvlQWWQBL3hLUidZja+Vw5ipOs17vByPrxxliWjE098eCJU3Si+APNCwCqGft6AO4lhDkQU3I0mHeIjvGPIw8ZHuxUta1u3x/R1S7wi9ImVnjK4dA/Qxxgmi1ut6tfDFuJJjDl7rz03jUU4XuMAwtbNn9QT68J47sAHtToMXo0IvvEM+cvyOWzCassZGcjhu8Jwy97lwYWNRHqtxTRgEpG7krUCwWnsYbP9l8G9YctRkl0+mFLcT6upWAqvyym+qT095UGWYj1+47fEbG6ByYvPUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LHuLvhDHe0Uvo5t3pxFzHum+9JqXq1sn83pWAijGLCk=;
 b=4lHKwF6Fdon58euinYwsYezuvgM2nj65/6y3Bgs1J3kY8W7VuBFHOyahcdsAVUjWfdgIx5tJ8miCWAp1Y9NM+X9M6h9bdUcDCn+Zbi0uvOPHyL49gYth6bme7Tb0HZJfT3ZyBLsW3nWLho6bvhFjc4NeCkqr1KIpY4g1nrH+b+M=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: nd <nd@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
Thread-Topic: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping
 for borrower domain
Thread-Index: AQHYNQ8JUHwL/QpeQ0iCIDnkwGGL/6zmznEAgACwWoCAET7aAA==
Date: Wed, 20 Apr 2022 08:53:18 +0000
Message-ID:
 <DU2PR08MB7325B86F6BFFE0232D0CEC42F7F59@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-7-Penny.Zheng@arm.com>
 <c4a3fb77-1cab-aacf-a2a5-3702f9c4ab97@xen.org>
 <b34727d4-1e8d-64fd-9d5e-84ed4255c320@xen.org>
In-Reply-To: <b34727d4-1e8d-64fd-9d5e-84ed4255c320@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: EAACE6986DF3764BA84D389A2C375002.0
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: b19bd223-3c99-414a-e0da-08da22ab3cb3
x-ms-traffictypediagnostic:
	AM6PR08MB3175:EE_|VE1EUR03FT040:EE_|VI1PR0802MB2304:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB230425AB0AD312665A4A7A6FF7F59@VI1PR0802MB2304.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 uyVh6CwF+Hl1y06AYEdiI6glEh7zG5D8JbZBMX1I/qLkkh/92lC9XrbFXLZanciJivZX72u7zF20F5+M7WRh5eDOzMKmzkYFUIvbn/cOUsbIfoneunu0bWn2cBldYRbzeANmDjeF4mVzcpVKoFjIlzNpALGIYtU3eGsPsIogB8P9Lm+6eC4rH66aA/uhjCz8cCf3wRpSxx/v8HxU5vWdFDFH9nDH41oKi/xS9ZTG4Nq2EjAMcA1HjCDxESxVNhbLtdD1I0JipShyvQfLWri2pDQqBjBJmiiNDXbgwOgg3caNRmlkboefrEZjJ52ljUvgOEtdBiocmCmQ1jmvAFNDk7K/UfXW0as9VJg6IoOXeqKna/qn52QToBuzKMen2P7tqzy8cAJDJBaR4ybArMG/bbnPuXSSSYljnJ1XfAcIBr87UtqwF5uFcujFRiEXTIrkFy1jMIKTFMmrAftchvucHGm386+ktFx9i+3PLw5BnYklEEyyj5n3CYZUjf1iUvtL8R1GGnlskCnvcKqsbB8NzVQVzgWm0ImyQ+6rBlHUmuYD5DbsJzmgSleOQuOmSqzTpYmrB243DhmCVzW9AzWvhArpAplptuwgHAekO6R3vx6K7zxwAUxl1EPNsS5vfbC0fhH4U6+h9cD2sPDiYA0wVEZz20gijE6C8npOxpJKVaKyTFmFRF/U7CwnDACyP0gZSL0j9P/8hfdEbQLqzmW64Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(66556008)(508600001)(64756008)(66446008)(110136005)(6506007)(9686003)(33656002)(26005)(53546011)(66476007)(86362001)(316002)(76116006)(66946007)(54906003)(7696005)(186003)(8936002)(5660300002)(4326008)(38070700005)(38100700002)(2906002)(52536014)(83380400001)(122000001)(55016003)(8676002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3175
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	52a524af-6f36-4045-3390-08da22ab3768
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wYlYtG5LXKnAlK5opE+WTCGd1NJM975teAQthJUy4Syn5DOPZeUs+PV7qZmVIUMwn7H2FSRSoxM4HxUd8YW1jpnAwBwYDKzpNsC6tWHRyNEANmNGqasLYcM4M1CpmBVJMMu1rfWOVjEFxnlaucv5kFiiBG370XL0G8z3YAQS6G7LGq540TtiKE3AAqMOdi8RyBLXAW+RNDQXehLVl8/sVuMogDnUnYCdB2GfuiJ7eyuHDbWpAgAqc+sb0JmwK99wRzLye608QrVpIRnBdv5ZslrB2pIcLNNnBEDxFvaXWgvg+dhSZUwYlhOisoyoGZeE0/FG9NU6CZOUffWy1E81BBeU7Iqvh76bU8nxIs4Px5xSrL3aEAgUTUa9CyuFzi0+aQlzTabdf+n/+zfn9u5dQUiZLQXpln4OPyFR71eTKqmR72QDKqFmSNzbqqOUeYMcN6DXqa3Z0cW7g9IHhtrE/pmWAbsxCAnmTHHsHAlYyG+tmZSWprzsWIoSV8XJzkTE/3gNyqUcme3HiA5oo2eUeYMGiTam565bEHlL6QTKSCVIbfmyfHEvM9E0ZlHN5IDwEhS4wnWHuvdHowkYd2boVC5c2cSguuSgyiLTdvtySfjIl3bANxl32zYKjZnnQ/YJtbgzwPLKSjxhRcJgmig5Ka+EUacfWPwN+nsGVUtIBWIhX14unOfn0T37ztN4DqOM
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36860700001)(8676002)(70586007)(86362001)(70206006)(83380400001)(52536014)(40460700003)(8936002)(5660300002)(55016003)(82310400005)(336012)(356005)(4326008)(186003)(81166007)(47076005)(2906002)(33656002)(107886003)(508600001)(26005)(7696005)(9686003)(6506007)(110136005)(53546011)(54906003)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 08:53:27.7957
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b19bd223-3c99-414a-e0da-08da22ab3cb3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2304

SGkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwg
PGp1bGllbkB4ZW4ub3JnPg0KPiBTZW50OiBTYXR1cmRheSwgQXByaWwgOSwgMjAyMiA1OjMxIFBN
DQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0
cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogbmQgPG5kQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxp
bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZA0KPiBNYXJxdWlzIDxCZXJ0cmFu
ZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFiY2h1aw0KPiA8Vm9sb2R5bXlyX0JhYmNo
dWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjEgMDYvMTNdIHhlbi9hcm06IHNl
dCB1cCBzaGFyZWQgbWVtb3J5IGZvcmVpZ24NCj4gbWFwcGluZyBmb3IgYm9ycm93ZXIgZG9tYWlu
DQo+IA0KPiBIaSwNCj4gDQo+IE9uIDA4LzA0LzIwMjIgMjM6NTksIEp1bGllbiBHcmFsbCB3cm90
ZToNCj4gPiBPbiAxMS8wMy8yMDIyIDA2OjExLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPj4gRnJv
bTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+ID4+DQo+ID4+IFRoaXMgY29t
bWl0cyBpbnRyb2R1Y2VzIGEgbmV3IGhlbHBlciBndWVzdF9waHlzbWFwX2FkZF9zaG0gdG8gc2V0
IHVwDQo+ID4+IHNoYXJlZCBtZW1vcnkgZm9yZWlnbiBtYXBwaW5nIGZvciBib3Jyb3dlciBkb21h
aW4uDQo+ID4+DQo+ID4+IEZpcnN0bHkgaXQgc2hvdWxkIGdldCBhbmQgdGFrZSByZWZlcmVuY2Ug
b2Ygc3RhdGljYWxseSBzaGFyZWQgcGFnZXMNCj4gPj4gZnJvbSBvd25lciBkb21fc2hhcmVkLiBU
aGVuIGl0IHdpbGwgc2V0dXAgUDJNIGZvcmVpZ24gbWVtb3J5IG1hcCBvZg0KPiA+PiB0aGVzZSBz
dGF0aWNhbGx5IHNoYXJlZCBwYWdlcyBmb3IgYm9ycm93ZXIgZG9tYWluLg0KPiA+Pg0KPiA+PiBU
aGlzIGNvbW1pdHMgb25seSBjb25zaWRlcnMgb3duZXIgZG9tYWluIGlzIHRoZSBkZWZhdWx0IGRv
bV9zaGFyZWQsDQo+ID4+IHRoZSBvdGhlciBzY2VuYXJpbyB3aWxsIGJlIGNvdmVyZWQgaW4gdGhl
IGZvbGxvd2luZyBwYXRjaGVzLg0KPiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBQZW5ueSBaaGVu
ZyA8cGVubnkuemhlbmdAYXJtLmNvbT4NCj4gPj4gLS0tDQo+ID4+IMKgIHhlbi9hcmNoL2FybS9k
b21haW5fYnVpbGQuYyB8IDUyDQo+ID4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysNCj4gPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKykNCj4gPj4NCj4g
Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+PiBiL3hlbi9h
cmNoL2FybS9kb21haW5fYnVpbGQuYyBpbmRleCA5ODRlNzBlNWZjLi44Y2VlNWZmYmQxIDEwMDY0
NA0KPiA+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPj4gKysrIGIveGVu
L2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4+IEBAIC03OTgsNiArNzk4LDQ4IEBAIHN0YXRp
YyBpbnQgX19pbml0IGFsbG9jYXRlX3NoYXJlZF9tZW1vcnkoc3RydWN0DQo+ID4+IGRvbWFpbiAq
ZCwNCj4gPj4gwqDCoMKgwqDCoCByZXR1cm4gcmV0Ow0KPiA+PiDCoCB9DQo+ID4+ICtzdGF0aWMg
aW50IF9faW5pdCBndWVzdF9waHlzbWFwX2FkZF9zaG0oc3RydWN0IGRvbWFpbiAqb2QsIHN0cnVj
dA0KPiA+PiBkb21haW4gKmJkLA0KPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVk
IGxvbmcgb19nZm4sDQo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBi
X2dmbiwNCj4gPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIG5yX2dmbnMp
IHsNCj4gPj4gK8KgwqDCoCBzdHJ1Y3QgcGFnZV9pbmZvICoqcGFnZXMgPSBOVUxMOw0KPiA+PiAr
wqDCoMKgIHAybV90eXBlX3QgcDJtdCwgdDsNCj4gPj4gK8KgwqDCoCBpbnQgcmV0ID0gMDsNCj4g
Pg0KPiA+IFlvdSBkb24ndCBuZWVkIHRvIGluaXRpYWxpemUgcmV0Lg0KPiA+DQo+ID4+ICsNCj4g
Pj4gK8KgwqDCoCBwYWdlcyA9IHhtYWxsb2NfYXJyYXkoc3RydWN0IHBhZ2VfaW5mbyAqLCBucl9n
Zm5zKTsNCj4gPj4gK8KgwqDCoCBpZiAoICFwYWdlcyApDQo+ID4+ICvCoMKgwqDCoMKgwqDCoCBy
ZXR1cm4gLUVOT01FTTsNCj4gPj4gKw0KPiA+PiArwqDCoMKgIC8qDQo+ID4+ICvCoMKgwqDCoCAq
IFRha2UgcmVmZXJlbmNlIG9mIHN0YXRpY2FsbHkgc2hhcmVkIHBhZ2VzIGZyb20gb3duZXIgZG9t
YWluLg0KPiA+PiArwqDCoMKgwqAgKiBSZWZlcmVuY2Ugd2lsbCBiZSByZWxlYXNlZCB3aGVuIGRl
c3Ryb3lpbmcgc2hhcmVkIG1lbW9yeSByZWdpb24uDQo+ID4+ICvCoMKgwqDCoCAqLw0KPiA+PiAr
wqDCoMKgIHJldCA9IGdldF9wYWdlc19mcm9tX2dmbihvZCwgb19nZm4sIG5yX2dmbnMsIHBhZ2Vz
LCAmcDJtdCwNCj4gPj4gUDJNX0FMTE9DKTsNCj4gPj4gK8KgwqDCoCBpZiAoIHJldCApDQo+ID4+
ICvCoMKgwqAgew0KPiA+PiArwqDCoMKgwqDCoMKgwqAgcmV0ID0gLUVJTlZBTDsNCj4gPj4gK8Kg
wqDCoMKgwqDCoMKgIGdvdG8gZmFpbF9wYWdlczsNCj4gPj4gK8KgwqDCoCB9DQo+ID4+ICsNCj4g
Pj4gK8KgwqDCoCBpZiAoIHAybV9pc19yYW0ocDJtdCkgKQ0KPiA+PiArwqDCoMKgwqDCoMKgwqAg
dCA9IChwMm10ID09IHAybV9yYW1fcncpID8gcDJtX21hcF9mb3JlaWduX3J3IDoNCj4gPj4gcDJt
X21hcF9mb3JlaWduX3JvOw0KPiA+PiArwqDCoMKgIGVsc2UNCj4gPj4gK8KgwqDCoCB7DQo+ID4+
ICvCoMKgwqDCoMKgwqDCoCByZXQgPSAtRUlOVkFMOw0KPiA+PiArwqDCoMKgwqDCoMKgwqAgZ290
byBmYWlsX3BhZ2VzOw0KPiA+DQo+ID4gV2hlcmUgd291bGQgd2UgcmVsZWFzZSB0aGUgcmVmZXJl
bmNlcz8NCj4gPg0KPiA+PiArwqDCoMKgIH0NCj4gPj4gKw0KPiA+PiArwqDCoMKgIC8qIFNldCB1
cCBndWVzdCBmb3JlaWduIG1hcC4gKi8NCj4gPj4gK8KgwqDCoCByZXQgPSBndWVzdF9waHlzbWFw
X2FkZF9wYWdlcyhiZCwgX2dmbihiX2dmbiksDQo+ID4+IHBhZ2VfdG9fbWZuKHBhZ2VzWzBdKSwN
Cj4gPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCBucl9nZm5zLCB0KTsNCj4gPg0KPiA+IEEgZmV3IHRoaW5nczoNCj4g
PiAgwqAgLSBUaGUgYmVnaW5uaW5nIG9mIHRoZSBjb2RlIGFzc3VtZXMgdGhhdCB0aGUgTUZOIG1h
eSBiZQ0KPiA+IGRpc2NvbnRpZ3VvdXMgaW4gdGhlIHBoeXNpY2FsIG1lbW9yeS4gQnV0IGhlcmUs
IHlvdSBhcmUgYXNzdW1pbmcgdGhleSBhcmUNCj4gY29udGlndW91cy4NCj4gPiBJZiB5b3Ugd2Fu
dCB0aGUgbGF0dGVyLCB0aGVuIHlvdSBzaG91bGQgY2hlY2sgdGhlIE1GTnMgYXJlIGNvbnRpZ3Vv
dXMuDQo+ID4gVGhhdCBzYWlkLCBJIGFtIG5vdCBzdXJlIGlmIHRoaXMgcmVzdHJpY3Rpb24gaXMg
cmVhbGx5IG5lY2Vzc2FyeS4NCj4gPg0KPiA+ICDCoCAtIElJUkMsIGd1ZXN0X3BoeXNtYXBfYWRk
X3BhZ2VzKCkgZG9lc24ndCByZXZlcnQgdGhlIG1hcHBpbmdzLiBTbw0KPiA+IHlvdSBuZWVkIHRv
IHJldmVydCBpdCBpbiBjYXNlIG9mIGZhaWx1cmUuDQo+IA0KPiANCj4gVGhlcmUgaXMgYW5vdGhl
ciBpc3N1ZSBoZXJlLiBndWVzdF9waHlzbWFwX2FkZF9wYWdlcygpIG1heSB1c2Ugc3VwZXJwYWdl
DQo+IG1hcHBpbmcuIFRoZSBQMk0gY29kZSBpcyBjdXJyZW50bHkgYXNzdW1pbmcgdGhlIGZvcmVp
bmcgbWFwcGluZyB3aWxsIGJlDQo+IHVzaW5nIEwzIG1hcHBpbmcgKDRLQikuDQo+IA0KPiBEbyB5
b3UgbmVlZCB0byB1c2Ugc3VwZXJwYWdlIG1hcHBpbmcgaGVyZT8NCj4gDQoNClJpZ2h0IG5vdywg
dGhlcmUgaXMgbm8gdXNlciBjYXNlIG9uIG15IHNpZGUgbmVlZGluZyBzdXBlcnBhZ2UgbWFwcGlu
Zy4NCg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 08:55:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 08:55:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309012.524977 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh678-0005QL-41; Wed, 20 Apr 2022 08:55:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309012.524977; Wed, 20 Apr 2022 08:55:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh678-0005QC-0v; Wed, 20 Apr 2022 08:55:06 +0000
Received: by outflank-mailman (input) for mailman id 309012;
 Wed, 20 Apr 2022 08:55:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh677-0005Pw-08; Wed, 20 Apr 2022 08:55:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh676-0003Ud-Tw; Wed, 20 Apr 2022 08:55:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh676-0004Cb-JZ; Wed, 20 Apr 2022 08:55:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh676-00083j-Ig; Wed, 20 Apr 2022 08:55:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FUtMzCZvBLebkCACk25rSGmTBS1OKOw1SBEz2LUQ1a0=; b=WQLBmruQGu2ulBZiGjyv1yO4DF
	VDHisfg7rHCfRJrQVaSYzq3HMeHad2zmferdFEY/i9bljw4QtWxoZShVQOn2xPcKZDFRLBQFMym0U
	JnfeGcKybJ1iwin38vBYnlG3pYNIivfHVjFEPVTvFhU98fAj0IwhWsldUzQNkTffR96s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169550-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169550: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2ce9afd68e0bacc15b5570a983fa626cc4de9dbd
X-Osstest-Versions-That:
    xen=b881cb95cb034466d3dd9be52f5a7e6594148a90
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 08:55:04 +0000

flight 169550 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169550/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169541
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169541
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169541
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169541
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 169541
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169541
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169541
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169541
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169541
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169541
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169541
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169541
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169541
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  2ce9afd68e0bacc15b5570a983fa626cc4de9dbd
baseline version:
 xen                  b881cb95cb034466d3dd9be52f5a7e6594148a90

Last test of basis   169541  2022-04-19 13:06:54 Z    0 days
Testing same since   169550  2022-04-19 23:36:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Juergen Gross <jgross@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b881cb95cb..2ce9afd68e  2ce9afd68e0bacc15b5570a983fa626cc4de9dbd -> master


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 09:00:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 09:00:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309028.525016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6Ci-0007FQ-3a; Wed, 20 Apr 2022 09:00:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309028.525016; Wed, 20 Apr 2022 09:00:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6Ci-0007F6-0I; Wed, 20 Apr 2022 09:00:52 +0000
Received: by outflank-mailman (input) for mailman id 309028;
 Wed, 20 Apr 2022 09:00:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+dnl=U6=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nh6Cg-0007Ez-J1
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 09:00:50 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5fa1cc9d-c088-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 11:00:49 +0200 (CEST)
Received: by mail-lj1-x236.google.com with SMTP id r18so1188223ljp.0
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 02:00:49 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 u26-20020ac25bda000000b0046d148d5297sm1758092lfn.184.2022.04.20.02.00.47
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 20 Apr 2022 02:00:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fa1cc9d-c088-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=Mm9IQcuw8CPxlnkWpkD0I9Qiw/wRrYXHRKvtGwqprgE=;
        b=ivPeTHCboPn/S32Q9aXG/tBBtObvdQeSvr/DgdMUDIhrTTfib7CWEy2WYHsLEr9EOf
         0xK2WiO4YGqhyqhKwtPwAX/1kdQO55qX6J7g2fITpr1iYrtJ2JW3ou1h1hXtYdK2tU4B
         +riA1kwnCAkNnb33yi92DSl4nbbNYGrJqztnB6M1royRBYqktgrJhvjnBXTdDeS07PPF
         755BProbUFW+sTKxKArSRHQ+E6IrJxe7KcpYXlaMkdiIQOxUIbLCyVmaZNPRHUT6KiVJ
         AsOc/Lh/YfcsaMeY1PS6r3TqGFJU/GQH7Oz9Q5Kdcn+fH1Z+OtKIVyEYmya04O5+3KDc
         JLTQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=Mm9IQcuw8CPxlnkWpkD0I9Qiw/wRrYXHRKvtGwqprgE=;
        b=zm78QDLt6+mFLniXzSdySOf8NWQHw6Ypa6nbGLeAulAp4ZxiwAugjnrXhdd3WH8+SO
         zT9kZs3TWUz4z+xH2zZUi38qsSrqnQfbZNrq1iXDDDRqEmIguPymlamtapNtFaTUkrfm
         PdZLZjxcg+jcFtKOtwrg3/z6uvic8M1pbTy+lSSF/N5575+C65SPzhZfrmlSLqq9g7TM
         ix90KopFHGz7ExdZ7cXdVjuL1fKubc9S7KQc4wCJ+6neW0zovx+Bz1g7Rj2TTF6ytcyM
         9kDt7gGFi7sbuKv3lx0RIRFFZEHGGmdM6XEyXvd3sWrYob+Em2VJUPwRa9ID9NBq3N28
         F6/w==
X-Gm-Message-State: AOAM533ZEe19OzTq3ewq1VEahq3IPXHeiCML8c+7OnJCP0FDqF9NjCq5
	e7T4ojCoK9oRdix0CpiptXM=
X-Google-Smtp-Source: ABdhPJyQhZBI3AqCt87T7H2gP7s5E2mi3TolDMY1V1To6m/Pl28eDjChTAvh/qulD3kbDt9e/fVCoA==
X-Received: by 2002:a2e:a552:0:b0:24d:c784:4b43 with SMTP id e18-20020a2ea552000000b0024dc7844b43mr4314706ljn.4.1650445248959;
        Wed, 20 Apr 2022 02:00:48 -0700 (PDT)
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
To: Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com>
 <1649963973-22879-7-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop>
 <YlpdBHKT1bYzZe2e@infradead.org>
 <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
 <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop>
 <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com>
 <b68163be-ad43-7773-22ff-e83191886626@suse.com>
 <5afb9e61-4164-9cc9-278a-911fc21f4f6c@gmail.com>
 <alpine.DEB.2.22.394.2204191717020.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <7047c7a7-47a0-d446-3b99-94bd552ec90f@gmail.com>
Date: Wed, 20 Apr 2022 12:00:47 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204191717020.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hello Stefano, Juergen


On 20.04.22 03:23, Stefano Stabellini wrote:
> On Tue, 19 Apr 2022, Oleksandr wrote:
>> On 19.04.22 17:48, Juergen Gross wrote:
>>> On 19.04.22 14:17, Oleksandr wrote:
>>>> Hello Stefano, Juergen
>>>>
>>>>
>>>> On 18.04.22 22:11, Stefano Stabellini wrote:
>>>>> On Mon, 18 Apr 2022, Oleksandr wrote:
>>>>>> On 16.04.22 09:07, Christoph Hellwig wrote:
>>>>>>
>>>>>> Hello Christoph
>>>>>>
>>>>>>> On Fri, Apr 15, 2022 at 03:02:45PM -0700, Stefano Stabellini wrote:
>>>>>>>> This makes sense overall. Considering that the swiotlb-xen case
>>>>>>>> and the
>>>>>>>> virtio case are mutually exclusive, I would write it like this:
>>>>>>> Curious question:  Why can't the same grant scheme also be used for
>>>>>>> non-virtio devices?  I really hate having virtio hooks in the arch
>>>>>>> dma code.  Why can't Xen just say in DT/ACPI that grants can be used
>>>>>>> for a given device?
>>>>> [...]
>>>>>
>>>>>> This patch series tries to make things work with "virtio" devices in
>>>>>> Xen
>>>>>> system without introducing any modifications to code under
>>>>>> drivers/virtio.
>>>>> Actually, I think Christoph has a point.
>>>>>
>>>>> There is nothing inherently virtio specific in this patch series or in
>>>>> the "xen,dev-domid" device tree binding.
>>>>
>>>> Although the main intention of this series was to enable using virtio
>>>> devices in Xen guests, I agree that nothing in new DMA ops layer
>>>> (xen-virtio.c) is virtio specific (at least at the moment). Regarding the
>>>> whole patch series I am not quite sure, as it uses
>>>> arch_has_restricted_virtio_memory_access(). >
>>>>>    Assuming a given device is
>>>>> emulated by a Xen backend, it could be used with grants as well.
>>>>>
>>>>> For instance, we could provide an emulated e1000 NIC with a
>>>>> "xen,dev-domid" property in device tree. Linux could use grants with it
>>>>> and the backend could map the grants. It would work the same way as
>>>>> virtio-net/block/etc. Passthrough devices wouldn't have the
>>>>> "xen,dev-domid" property, so no problems.
>>>>>
>>>>> So I think we could easily generalize this work and expand it to any
>>>>> device. We just need to hook on the "xen,dev-domid" device tree
>>>>> property.
>>>>>
>>>>> I think it is just a matter of:
>>>>> - remove the "virtio,mmio" check from xen_is_virtio_device
>>>>> - rename xen_is_virtio_device to something more generic, like
>>>>>     xen_is_grants_device
>>> xen_is_grants_dma_device, please. Normal Xen PV devices are covered by
>>> grants, too, and I'd like to avoid the confusion arising from this.
>>
>> yes, this definitely makes sense as we need to distinguish
>>
>>
>>>
>>>>> - rename xen_virtio_setup_dma_ops to something more generic, like
>>>>>     xen_grants_setup_dma_ops
>>>>>
>>>>> And that's pretty much it.
>>>> + likely renaming everything in that patch series not to mention virtio
>>>> (mostly related to xen-virtio.c internals).
>>>>
>>>>
>>>> Stefano, thank you for clarifying Christoph's point.
>>>>
>>>> Well, I am not against going this direction. Could we please make a
>>>> decision on this? @Juergen, what is your opinion?
>>> Yes, why not.
>>
>> ok, thank you for confirming.
>>
>>
>>>
>>> Maybe rename xen-virtio.c to grant-dma.c?
>>
>> Personally I don't mind.
>>
>>
>>> I'd keep the XEN_VIRTIO related config option, as this will be the normal
>>> use
>>> case. grant-dma.c should be covered by a new hidden config option
>>> XEN_GRANT_DMA
>>> selected by XEN_VIRTIO.
>>
>> I got it, ok
>>
>>
>>>
>>> CONFIG_XEN_VIRTIO should still guard
>>> xen_has_restricted_virtio_memory_access().
>>
>> ok
>>
>>
>> So a few questions to clarify:
>>
>> 1. What is the best place to keep "xen,dev-domid" binding's description now? I
>> think that proposed in current series place
>> (Documentation/devicetree/bindings/virtio/) is not good fit now.
> I would probably add it to the existing
> Documentation/devicetree/bindings/arm/xen.txt.
>
>
>> 2. I assume the logic in the current patch will remain the same, I mean we
>> will still assign Xen grant DMA ops from xen_setup_dma_ops() here?
> Yes I think so


Stefano, thank you for clarifying!


Regarding new naming scheme...

As there is an existing Kconfig option XEN_GRANT_DMA_ALLOC used for 
different purpose, we need to clarify naming scheme here a bit to avoid 
possible confusion.

For example, I am happy with proposed by Juergen ...

... Kconfig option: XEN_GRANT_DMA_OPS

and

... file: grant-dma-ops.c


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 09:08:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 09:08:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309034.525026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6JN-0008CZ-0K; Wed, 20 Apr 2022 09:07:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309034.525026; Wed, 20 Apr 2022 09:07:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6JM-0008CS-T8; Wed, 20 Apr 2022 09:07:44 +0000
Received: by outflank-mailman (input) for mailman id 309034;
 Wed, 20 Apr 2022 09:07:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+dnl=U6=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nh6JM-0008CM-Db
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 09:07:44 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5662f59f-c089-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 11:07:43 +0200 (CEST)
Received: by mail-lj1-x234.google.com with SMTP id q22so1147839ljh.10
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 02:07:43 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 i6-20020a198c46000000b0044424910c94sm1769859lfj.113.2022.04.20.02.07.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 20 Apr 2022 02:07:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5662f59f-c089-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=VXi3a4LAvsCbWNSOmsDTr1lU/ye1czT52j5wCJ6jh0k=;
        b=mLpYNKvwsqkMj/9tqEWtjmDaTRCa4HcpozXSGctELTE3sR7hMg8trnf3KxBfebEcM/
         c61BKLCbnL4g3NAu3hdyr5Lh6Pwu8m5Lf91doQ5z0yUMKWuHP+17WLuSRagVGRuX6pHG
         ooFmSjBMSf2/2Tzg4Moxw4w1DhXlfsKDMu1pou63ZZwlNCuWTcMJLcwJ+z4C5Jzle5Q1
         Sj1cLuvwIZ/IsXQA4mxDHqaTe+W6SKhCu14f8HVPElsJnWULkCOENfhNxpipx00zKiZI
         jdmspV633O7L5xApNxojXTR7yN2h59a7nwq8RHtySwKlSz7seuCKYpZLjIAEb8BhCijN
         Ng7g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=VXi3a4LAvsCbWNSOmsDTr1lU/ye1czT52j5wCJ6jh0k=;
        b=qABc31IxsOVFGmqt7MUu5+ExKAntumbGD3q23lT7tPCi7d5jtNotb7Mp6R34Vz/vmH
         h8sORdrHnPDchS12TVzxktec4pbLp7WK/tMEtkyI35/Pr9F5FmNddWtGbMfgyoYVTTqe
         0e2ugY7Zt7z8F1XnK+wnm+Jyo4Xfg0bJFnvP7FSC0Z7ahgeB5sw4uQltr9atjmHIWBB8
         VzBh8s6tH+ZDvFE4JIaejDBbwkbdX3hDUs/DmLjInkn4ADLbHM4sjlHUj5244f5/TDTl
         H8G2iDzWsvuxFMtHqMmqevkM1Z4fpWilI+7LCFok1Wrldo3uuoa4Pl75Vnbed8WNyAci
         okFg==
X-Gm-Message-State: AOAM532beMROkuDjtPSUhmUG7J6BNCcqcRKYwBxlzSSkdUtdjRbOGcPk
	ooXQQFqrRP0TfYul3xD6P5I=
X-Google-Smtp-Source: ABdhPJzXJZ/xW4yVeoivvUV+yOQs7loTQxajlY9+N7Kx5LKp8FfwFh63pX7EQY0tVlxQ9n3OawbYFQ==
X-Received: by 2002:a05:651c:54c:b0:249:9d06:24ef with SMTP id q12-20020a05651c054c00b002499d0624efmr12464574ljp.331.1650445662989;
        Wed, 20 Apr 2022 02:07:42 -0700 (PDT)
Subject: Re: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
To: Henry Wang <Henry.Wang@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <Julien.Grall@arm.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jiamei Xie <Jiamei.Xie@arm.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
 <PA4PR08MB6253F275EE7374EA556A076B92F59@PA4PR08MB6253.eurprd08.prod.outlook.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <bc5702e9-0476-b141-4039-6dafeadd6386@gmail.com>
Date: Wed, 20 Apr 2022 12:07:41 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <PA4PR08MB6253F275EE7374EA556A076B92F59@PA4PR08MB6253.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 20.04.22 08:20, Henry Wang wrote:
> Hi Oleksandr,

Hi Henry


>
>> -----Original Message-----
>> From: Oleksandr Tyshchenko <olekstysh@gmail.com>
>> Subject: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
>>
>> From: Julien Grall <julien.grall@arm.com>
>>
>> This patch introduces helpers to allocate Virtio MMIO params
>> (IRQ and memory region) and create specific device node in
>> the Guest device-tree with allocated params. In order to deal
>> with multiple Virtio devices, reserve corresponding ranges.
>> For now, we reserve 1MB for memory regions and 10 SPIs.
>>
>> As these helpers should be used for every Virtio device attached
>> to the Guest, call them for Virtio disk(s).
>>
>> Please note, with statically allocated Virtio IRQs there is
>> a risk of a clash with a physical IRQs of passthrough devices.
>> For the first version, it's fine, but we should consider allocating
>> the Virtio IRQs automatically. Thankfully, we know in advance which
>> IRQs will be used for passthrough to be able to choose non-clashed
>> ones.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> Tested-by: Jiamei Xie <Jiamei.xie@arm.com>
>> Reviewed-by: Henry Wang <Henry.Wang@arm.com>
>> ---
>> @Jiamei, @Henry I decided to leave your T-b and R-b tags with the minor
>> change I made, are you still happy with that?
> Sorry for the late response, just checked the code and yes I am happy with
> keeping my Reviewed-by. Thanks for your effort in rebasing the patch!


Thank you for confirming! Note that I will have to drop tags for the 
next version due to non-minor changes I am currently making to address 
review comments.


>
> Kind regards,
> Henry

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 09:25:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 09:25:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309040.525043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aD-0002VV-QN; Wed, 20 Apr 2022 09:25:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309040.525043; Wed, 20 Apr 2022 09:25:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aD-0002Uk-Jt; Wed, 20 Apr 2022 09:25:09 +0000
Received: by outflank-mailman (input) for mailman id 309040;
 Wed, 20 Apr 2022 09:25:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh6aC-0002RO-IJ
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 09:25:08 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c457569f-c08b-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 11:25:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B77A01F750;
 Wed, 20 Apr 2022 09:25:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7DEE213A30;
 Wed, 20 Apr 2022 09:25:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id AKqDHXLRX2J1EAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 09:25:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c457569f-c08b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650446706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MG3xPy2sxwW3smkj4Gb01xXTe3bOEE9V2zLYcAQe4m4=;
	b=mTCoRgBnFSe/ABmVE51/kFi8GouqGUW//Z5wLebenjt6cdlqmxkVOvUEfBM7Yhq3UKEz7T
	Y711+3n1JipYWf1+s3SR5chkMz/ZiNm3wT54aU212PJMVH+LOycZ6if6UL0b0uCwCrFw/Z
	guGpcd5xfnf8Fd2GGv9DggUWEDD6kQM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 3/4] xen/scsifront: use new command result macros
Date: Wed, 20 Apr 2022 11:25:02 +0200
Message-Id: <20220420092503.11123-4-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420092503.11123-1-jgross@suse.com>
References: <20220420092503.11123-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a translation layer for the command result values.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/scsi/xen-scsifront.c | 64 +++++++++++++++++++++++++++++++-----
 1 file changed, 56 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 12109e4c73d4..8511bfc62963 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -243,6 +243,56 @@ static void scsifront_gnttab_done(struct vscsifrnt_info *info,
 	kfree(shadow->sg);
 }
 
+static unsigned int scsifront_host_byte(int32_t rslt)
+{
+	switch (XEN_VSCSIIF_RSLT_HOST(rslt)) {
+	case XEN_VSCSIIF_RSLT_HOST_OK:
+		return DID_OK;
+	case XEN_VSCSIIF_RSLT_HOST_NO_CONNECT:
+		return DID_NO_CONNECT;
+	case XEN_VSCSIIF_RSLT_HOST_BUS_BUSY:
+		return DID_BUS_BUSY;
+	case XEN_VSCSIIF_RSLT_HOST_TIME_OUT:
+		return DID_TIME_OUT;
+	case XEN_VSCSIIF_RSLT_HOST_BAD_TARGET:
+		return DID_BAD_TARGET;
+	case XEN_VSCSIIF_RSLT_HOST_ABORT:
+		return DID_ABORT;
+	case XEN_VSCSIIF_RSLT_HOST_PARITY:
+		return DID_PARITY;
+	case XEN_VSCSIIF_RSLT_HOST_ERROR:
+		return DID_ERROR;
+	case XEN_VSCSIIF_RSLT_HOST_RESET:
+		return DID_RESET;
+	case XEN_VSCSIIF_RSLT_HOST_BAD_INTR:
+		return DID_BAD_INTR;
+	case XEN_VSCSIIF_RSLT_HOST_PASSTHROUGH:
+		return DID_PASSTHROUGH;
+	case XEN_VSCSIIF_RSLT_HOST_SOFT_ERROR:
+		return DID_SOFT_ERROR;
+	case XEN_VSCSIIF_RSLT_HOST_IMM_RETRY:
+		return DID_IMM_RETRY;
+	case XEN_VSCSIIF_RSLT_HOST_REQUEUE:
+		return DID_REQUEUE;
+	case XEN_VSCSIIF_RSLT_HOST_TRANSPORT_DISRUPTED:
+		return DID_TRANSPORT_DISRUPTED;
+	case XEN_VSCSIIF_RSLT_HOST_TRANSPORT_FAILFAST:
+		return DID_TRANSPORT_FAILFAST;
+	case XEN_VSCSIIF_RSLT_HOST_TARGET_FAILURE:
+		return DID_TARGET_FAILURE;
+	case XEN_VSCSIIF_RSLT_HOST_NEXUS_FAILURE:
+		return DID_NEXUS_FAILURE;
+	case XEN_VSCSIIF_RSLT_HOST_ALLOC_FAILURE:
+		return DID_ALLOC_FAILURE;
+	case XEN_VSCSIIF_RSLT_HOST_MEDIUM_ERROR:
+		return DID_MEDIUM_ERROR;
+	case XEN_VSCSIIF_RSLT_HOST_TRANSPORT_MARGINAL:
+		return DID_TRANSPORT_MARGINAL;
+	default:
+		return DID_ERROR;
+	}
+}
+
 static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
 				   struct vscsiif_response *ring_rsp)
 {
@@ -250,7 +300,6 @@ static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
 	struct scsi_cmnd *sc;
 	uint32_t id;
 	uint8_t sense_len;
-	int result;
 
 	id = ring_rsp->rqid;
 	shadow = info->shadow[id];
@@ -261,12 +310,8 @@ static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
 	scsifront_gnttab_done(info, shadow);
 	scsifront_put_rqid(info, id);
 
-	result = ring_rsp->rslt;
-	if (result >> 24)
-		set_host_byte(sc, DID_ERROR);
-	else
-		set_host_byte(sc, host_byte(result));
-	set_status_byte(sc, result & 0xff);
+	set_host_byte(sc, scsifront_host_byte(ring_rsp->rslt));
+	set_status_byte(sc, XEN_VSCSIIF_RSLT_STATUS(ring_rsp->rslt));
 	scsi_set_resid(sc, ring_rsp->residual_len);
 
 	sense_len = min_t(uint8_t, VSCSIIF_SENSE_BUFFERSIZE,
@@ -290,7 +335,10 @@ static void scsifront_sync_cmd_done(struct vscsifrnt_info *info,
 	shadow->wait_reset = 1;
 	switch (shadow->rslt_reset) {
 	case RSLT_RESET_WAITING:
-		shadow->rslt_reset = ring_rsp->rslt;
+		if (ring_rsp->rslt == XEN_VSCSIIF_RSLT_RESET_SUCCESS)
+			shadow->rslt_reset = SUCCESS;
+		else
+			shadow->rslt_reset = FAILED;
 		break;
 	case RSLT_RESET_ERR:
 		kick = _scsifront_put_rqid(info, id);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 09:25:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 09:25:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309039.525037 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aD-0002Rx-Di; Wed, 20 Apr 2022 09:25:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309039.525037; Wed, 20 Apr 2022 09:25:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aD-0002Rq-Al; Wed, 20 Apr 2022 09:25:09 +0000
Received: by outflank-mailman (input) for mailman id 309039;
 Wed, 20 Apr 2022 09:25:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh6aB-0002RO-Q4
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 09:25:07 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c42c7fe7-c08b-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 11:25:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 769D91F74E;
 Wed, 20 Apr 2022 09:25:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4677713A30;
 Wed, 20 Apr 2022 09:25:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ABXbD3LRX2J1EAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 09:25:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c42c7fe7-c08b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650446706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NzGetu5Tlsv3I1MPmAuHS095rYfTokF5Upsuqhfi0HI=;
	b=toj9BqkiPlCcY7+VyibAoCPmzx/uqduINcjBtzYxO3TFOynfH+Hknsj6Htl4g5SF7U2fsu
	5NLA8e/D6n3fowkQNmFgp9et23oeIHAQokKiihK+SpcwXu+G9yXNZU8Qx1u0++tIVqIs+V
	l/m6a2PcEn8UTAsRpUKtAQiBpWb/RCE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 2/4] xen/scsiback: use new command result macros
Date: Wed, 20 Apr 2022 11:25:01 +0200
Message-Id: <20220420092503.11123-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420092503.11123-1-jgross@suse.com>
References: <20220420092503.11123-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using the kernel's values for the result of PV scsi
operations use the values of the interface definition.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/xen-scsiback.c | 82 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 79 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index 0c5e565aa8cf..673dd73844ff 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -280,6 +280,82 @@ static void scsiback_free_translation_entry(struct kref *kref)
 	kfree(entry);
 }
 
+static int32_t scsiback_result(int32_t result)
+{
+	int32_t host_status;
+
+	switch (result >> 16) {
+	case DID_OK:
+		host_status = XEN_VSCSIIF_RSLT_HOST_OK;
+		break;
+	case DID_NO_CONNECT:
+		host_status = XEN_VSCSIIF_RSLT_HOST_NO_CONNECT;
+		break;
+	case DID_BUS_BUSY:
+		host_status = XEN_VSCSIIF_RSLT_HOST_BUS_BUSY;
+		break;
+	case DID_TIME_OUT:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TIME_OUT;
+		break;
+	case DID_BAD_TARGET:
+		host_status = XEN_VSCSIIF_RSLT_HOST_BAD_TARGET;
+		break;
+	case DID_ABORT:
+		host_status = XEN_VSCSIIF_RSLT_HOST_ABORT;
+		break;
+	case DID_PARITY:
+		host_status = XEN_VSCSIIF_RSLT_HOST_PARITY;
+		break;
+	case DID_ERROR:
+		host_status = XEN_VSCSIIF_RSLT_HOST_ERROR;
+		break;
+	case DID_RESET:
+		host_status = XEN_VSCSIIF_RSLT_HOST_RESET;
+		break;
+	case DID_BAD_INTR:
+		host_status = XEN_VSCSIIF_RSLT_HOST_BAD_INTR;
+		break;
+	case DID_PASSTHROUGH:
+		host_status = XEN_VSCSIIF_RSLT_HOST_PASSTHROUGH;
+		break;
+	case DID_SOFT_ERROR:
+		host_status = XEN_VSCSIIF_RSLT_HOST_SOFT_ERROR;
+		break;
+	case DID_IMM_RETRY:
+		host_status = XEN_VSCSIIF_RSLT_HOST_IMM_RETRY;
+		break;
+	case DID_REQUEUE:
+		host_status = XEN_VSCSIIF_RSLT_HOST_REQUEUE;
+		break;
+	case DID_TRANSPORT_DISRUPTED:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TRANSPORT_DISRUPTED;
+		break;
+	case DID_TRANSPORT_FAILFAST:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TRANSPORT_FAILFAST;
+		break;
+	case DID_TARGET_FAILURE:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TARGET_FAILURE;
+		break;
+	case DID_NEXUS_FAILURE:
+		host_status = XEN_VSCSIIF_RSLT_HOST_NEXUS_FAILURE;
+		break;
+	case DID_ALLOC_FAILURE:
+		host_status = XEN_VSCSIIF_RSLT_HOST_ALLOC_FAILURE;
+		break;
+	case DID_MEDIUM_ERROR:
+		host_status = XEN_VSCSIIF_RSLT_HOST_MEDIUM_ERROR;
+		break;
+	case DID_TRANSPORT_MARGINAL:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TRANSPORT_MARGINAL;
+		break;
+	default:
+		host_status = XEN_VSCSIIF_RSLT_HOST_ERROR;
+		break;
+	}
+
+	return (host_status << 16) | (result & 0x00ff);
+}
+
 static void scsiback_send_response(struct vscsibk_info *info,
 			char *sense_buffer, int32_t result, uint32_t resid,
 			uint16_t rqid)
@@ -295,7 +371,7 @@ static void scsiback_send_response(struct vscsibk_info *info,
 	ring_res = RING_GET_RESPONSE(&info->ring, info->ring.rsp_prod_pvt);
 	info->ring.rsp_prod_pvt++;
 
-	ring_res->rslt   = result;
+	ring_res->rslt   = scsiback_result(result);
 	ring_res->rqid   = rqid;
 
 	if (sense_buffer != NULL &&
@@ -555,7 +631,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
 	struct scsiback_nexus *nexus = tpg->tpg_nexus;
 	struct se_cmd *se_cmd = &pending_req->se_cmd;
 	u64 unpacked_lun = pending_req->v2p->lun;
-	int rc, err = FAILED;
+	int rc, err = XEN_VSCSIIF_RSLT_RESET_FAILED;
 
 	init_completion(&pending_req->tmr_done);
 
@@ -569,7 +645,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
 	wait_for_completion(&pending_req->tmr_done);
 
 	err = (se_cmd->se_tmr_req->response == TMR_FUNCTION_COMPLETE) ?
-		SUCCESS : FAILED;
+		XEN_VSCSIIF_RSLT_RESET_SUCCESS : XEN_VSCSIIF_RSLT_RESET_FAILED;
 
 	scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
 	transport_generic_free_cmd(&pending_req->se_cmd, 0);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 09:25:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 09:25:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309041.525060 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aG-0002xG-0g; Wed, 20 Apr 2022 09:25:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309041.525060; Wed, 20 Apr 2022 09:25:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aF-0002x5-SR; Wed, 20 Apr 2022 09:25:11 +0000
Received: by outflank-mailman (input) for mailman id 309041;
 Wed, 20 Apr 2022 09:25:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh6aD-0002RO-IR
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 09:25:09 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c40d6827-c08b-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 11:25:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3E26E1F385;
 Wed, 20 Apr 2022 09:25:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0FD7F13A30;
 Wed, 20 Apr 2022 09:25:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uIeGAnLRX2J1EAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 09:25:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c40d6827-c08b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650446706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FZ3HQWGQIijrKpRTy/DK1bE6hLtaRKbTQP99RtUeXZU=;
	b=GBOI95QQupEY/yQccYl33Wtlr1a8cXyASJI7+AcIPpFSfS+Hy5T/+EXBHU6iBGyur7ZMYs
	HFjfsesn0AfqHlcz3XvEzyDyhfstb34Ou8C5sYOK47sgScFEljVaKKFXPRdEob/ZE/EC2M
	9SNwj7ZfHlMsuvXIUmsXkdWVJEKCbK8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 1/4] xen: update vscsiif.h
Date: Wed, 20 Apr 2022 11:25:00 +0200
Message-Id: <20220420092503.11123-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420092503.11123-1-jgross@suse.com>
References: <20220420092503.11123-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Update include/xen/interface/io/vscsiif.h to its newest version.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 include/xen/interface/io/vscsiif.h | 133 ++++++++++++++++++++++++++++-
 1 file changed, 129 insertions(+), 4 deletions(-)

diff --git a/include/xen/interface/io/vscsiif.h b/include/xen/interface/io/vscsiif.h
index 1f6047d3de44..7ea4dc9611c4 100644
--- a/include/xen/interface/io/vscsiif.h
+++ b/include/xen/interface/io/vscsiif.h
@@ -43,7 +43,7 @@
  *
  *      A string specifying the backend device: either a 4-tuple "h:c:t:l"
  *      (host, controller, target, lun, all integers), or a WWN (e.g.
- *      "naa.60014054ac780582").
+ *      "naa.60014054ac780582:0").
  *
  * v-dev
  *      Values:         string
@@ -87,6 +87,75 @@
  *      response structures.
  */
 
+/*
+ * Xenstore format in practice
+ * ===========================
+ *
+ * The backend driver uses a single_host:many_devices notation to manage domU
+ * devices. Everything is stored in /local/domain/<backend_domid>/backend/vscsi/.
+ * The xenstore layout looks like this (dom0 is assumed to be the backend_domid):
+ *
+ *     <domid>/<vhost>/feature-host = "0"
+ *     <domid>/<vhost>/frontend = "/local/domain/<domid>/device/vscsi/0"
+ *     <domid>/<vhost>/frontend-id = "<domid>"
+ *     <domid>/<vhost>/online = "1"
+ *     <domid>/<vhost>/state = "4"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/p-dev = "8:0:2:1" or "naa.wwn:lun"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/state = "4"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/v-dev = "0:0:0:0"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/p-dev = "8:0:2:2"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/state = "4"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/v-dev = "0:0:1:0"
+ *
+ * The frontend driver maintains its state in
+ * /local/domain/<domid>/device/vscsi/.
+ *
+ *     <vhost>/backend = "/local/domain/0/backend/vscsi/<domid>/<vhost>"
+ *     <vhost>/backend-id = "0"
+ *     <vhost>/event-channel = "20"
+ *     <vhost>/ring-ref = "43"
+ *     <vhost>/state = "4"
+ *     <vhost>/vscsi-devs/dev-0/state = "4"
+ *     <vhost>/vscsi-devs/dev-1/state = "4"
+ *
+ * In addition to the entries for backend and frontend these flags are stored
+ * for the toolstack:
+ *
+ *     <domid>/<vhost>/vscsi-devs/dev-1/p-devname = "/dev/$device"
+ *     <domid>/<vhost>/libxl_ctrl_index = "0"
+ *
+ *
+ * Backend/frontend protocol
+ * =========================
+ *
+ * To create a vhost along with a device:
+ *     <domid>/<vhost>/feature-host = "0"
+ *     <domid>/<vhost>/frontend = "/local/domain/<domid>/device/vscsi/0"
+ *     <domid>/<vhost>/frontend-id = "<domid>"
+ *     <domid>/<vhost>/online = "1"
+ *     <domid>/<vhost>/state = "1"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/p-dev = "8:0:2:1"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/state = "1"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/v-dev = "0:0:0:0"
+ * Wait for <domid>/<vhost>/state + <domid>/<vhost>/vscsi-devs/dev-0/state become 4
+ *
+ * To add another device to a vhost:
+ *     <domid>/<vhost>/state = "7"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/p-dev = "8:0:2:2"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/state = "1"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/v-dev = "0:0:1:0"
+ * Wait for <domid>/<vhost>/state + <domid>/<vhost>/vscsi-devs/dev-1/state become 4
+ *
+ * To remove a device from a vhost:
+ *     <domid>/<vhost>/state = "7"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/state = "5"
+ * Wait for <domid>/<vhost>/state to become 4
+ * Wait for <domid>/<vhost>/vscsi-devs/dev-1/state become 6
+ * Remove <domid>/<vhost>/vscsi-devs/dev-1/{state,p-dev,v-dev,p-devname}
+ * Remove <domid>/<vhost>/vscsi-devs/dev-1/
+ *
+ */
+
 /* Requests from the frontend to the backend */
 
 /*
@@ -117,7 +186,8 @@
  * (plus the set VSCSIIF_SG_GRANT bit), the number of scsiif_request_segment
  * elements referencing the target data buffers is calculated from the lengths
  * of the seg[] elements (the sum of all valid seg[].length divided by the
- * size of one scsiif_request_segment structure).
+ * size of one scsiif_request_segment structure). The frontend may use a mix of
+ * direct and indirect requests.
  */
 #define VSCSIIF_ACT_SCSI_CDB		1
 
@@ -154,12 +224,14 @@
 
 /*
  * based on Linux kernel 2.6.18, still valid
+ *
  * Changing these values requires support of multiple protocols via the rings
  * as "old clients" will blindly use these values and the resulting structure
  * sizes.
  */
 #define VSCSIIF_MAX_COMMAND_SIZE	16
 #define VSCSIIF_SENSE_BUFFERSIZE	96
+#define VSCSIIF_PAGE_SIZE		4096
 
 struct scsiif_request_segment {
 	grant_ref_t gref;
@@ -167,7 +239,8 @@ struct scsiif_request_segment {
 	uint16_t length;
 };
 
-#define VSCSIIF_SG_PER_PAGE (PAGE_SIZE / sizeof(struct scsiif_request_segment))
+#define VSCSIIF_SG_PER_PAGE	(VSCSIIF_PAGE_SIZE / \
+				 sizeof(struct scsiif_request_segment))
 
 /* Size of one request is 252 bytes */
 struct vscsiif_request {
@@ -207,6 +280,58 @@ struct vscsiif_response {
 	uint32_t reserved[36];
 };
 
+/* SCSI I/O status from vscsiif_response->rslt */
+#define XEN_VSCSIIF_RSLT_STATUS(x)  ((x) & 0x00ff)
+
+/* Host I/O status from vscsiif_response->rslt */
+#define XEN_VSCSIIF_RSLT_HOST(x)    (((x) & 0x00ff0000) >> 16)
+#define XEN_VSCSIIF_RSLT_HOST_OK                   0
+/* Couldn't connect before timeout */
+#define XEN_VSCSIIF_RSLT_HOST_NO_CONNECT           1
+/* Bus busy through timeout */
+#define XEN_VSCSIIF_RSLT_HOST_BUS_BUSY             2
+/* Timed out for other reason */
+#define XEN_VSCSIIF_RSLT_HOST_TIME_OUT             3
+/* Bad target */
+#define XEN_VSCSIIF_RSLT_HOST_BAD_TARGET           4
+/* Abort for some other reason */
+#define XEN_VSCSIIF_RSLT_HOST_ABORT                5
+/* Parity error */
+#define XEN_VSCSIIF_RSLT_HOST_PARITY               6
+/* Internal error */
+#define XEN_VSCSIIF_RSLT_HOST_ERROR                7
+/* Reset by somebody */
+#define XEN_VSCSIIF_RSLT_HOST_RESET                8
+/* Unexpected interrupt */
+#define XEN_VSCSIIF_RSLT_HOST_BAD_INTR             9
+/* Force command past mid-layer */
+#define XEN_VSCSIIF_RSLT_HOST_PASSTHROUGH         10
+/* Retry requested */
+#define XEN_VSCSIIF_RSLT_HOST_SOFT_ERROR          11
+/* Hidden retry requested */
+#define XEN_VSCSIIF_RSLT_HOST_IMM_RETRY           12
+/* Requeue command requested */
+#define XEN_VSCSIIF_RSLT_HOST_REQUEUE             13
+/* Transport error disrupted I/O */
+#define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_DISRUPTED 14
+/* Transport class fastfailed */
+#define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_FAILFAST  15
+/* Permanent target failure */
+#define XEN_VSCSIIF_RSLT_HOST_TARGET_FAILURE      16
+/* Permanent nexus failure on path */
+#define XEN_VSCSIIF_RSLT_HOST_NEXUS_FAILURE       17
+/* Space allocation on device failed */
+#define XEN_VSCSIIF_RSLT_HOST_ALLOC_FAILURE       18
+/* Medium error */
+#define XEN_VSCSIIF_RSLT_HOST_MEDIUM_ERROR        19
+/* Transport marginal errors */
+#define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_MARGINAL  20
+
+/* Result values of reset operations */
+#define XEN_VSCSIIF_RSLT_RESET_SUCCESS  0x2002
+#define XEN_VSCSIIF_RSLT_RESET_FAILED   0x2003
+
 DEFINE_RING_TYPES(vscsiif, struct vscsiif_request, struct vscsiif_response);
 
-#endif /*__XEN__PUBLIC_IO_SCSI_H__*/
+
+#endif  /*__XEN__PUBLIC_IO_SCSI_H__*/
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 09:25:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 09:25:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309042.525065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aG-0002zR-CI; Wed, 20 Apr 2022 09:25:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309042.525065; Wed, 20 Apr 2022 09:25:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aG-0002yQ-4c; Wed, 20 Apr 2022 09:25:12 +0000
Received: by outflank-mailman (input) for mailman id 309042;
 Wed, 20 Apr 2022 09:25:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh6aE-0002RO-Ib
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 09:25:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c47f453f-c08b-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 11:25:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0434D1F752;
 Wed, 20 Apr 2022 09:25:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BDDE413A30;
 Wed, 20 Apr 2022 09:25:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mJcbLXLRX2J1EAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 09:25:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c47f453f-c08b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650446707; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iAfNb+rzirjhSwl4ClW1FKJTnvu8cALY2TvN6HT931g=;
	b=ZQy+kpryquGdTyAVd7Fk4MNIeKP+LpZmDiZBt5LpHx/c4DmT/Fs1UZOcSNZb1v97Ec0kG4
	0IIPWpejvrN/+Ez0IEXPa1FxYFgNClgZft+LDYvJwmwScbmFTcXj9kliJa22SAP7H6J/dw
	GqGeOF30KSlNvhnI2hior/hjkZsMtBs=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 4/4] xen/scsifront: harden driver against malicious backend
Date: Wed, 20 Apr 2022 11:25:03 +0200
Message-Id: <20220420092503.11123-5-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420092503.11123-1-jgross@suse.com>
References: <20220420092503.11123-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of relying on a well behaved PV scsi backend verify all meta
data received from the backend and avoid multiple reads of the same
data from the shared ring page.

In case any illegal data from the backend is detected switch the
PV device to a new "error" state and deactivate it for further use.

Use the "lateeoi" variant for the event channel in order to avoid
event storms blocking the guest.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/scsi/xen-scsifront.c | 104 +++++++++++++++++++++++++----------
 1 file changed, 76 insertions(+), 28 deletions(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 8511bfc62963..761c9c463ecd 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -83,6 +83,8 @@ struct vscsifrnt_shadow {
 	uint16_t rqid;
 	uint16_t ref_rqid;
 
+	bool inflight;
+
 	unsigned int nr_grants;		/* number of grants in gref[] */
 	struct scsiif_request_segment *sg;	/* scatter/gather elements */
 	struct scsiif_request_segment seg[VSCSIIF_SG_TABLESIZE];
@@ -104,7 +106,11 @@ struct vscsifrnt_info {
 	struct xenbus_device *dev;
 
 	struct Scsi_Host *host;
-	int host_active;
+	enum {
+		STATE_INACTIVE,
+		STATE_ACTIVE,
+		STATE_ERROR
+	}  host_active;
 
 	unsigned int evtchn;
 	unsigned int irq;
@@ -217,6 +223,8 @@ static int scsifront_do_request(struct vscsifrnt_info *info,
 	for (i = 0; i < (shadow->nr_segments & ~VSCSIIF_SG_GRANT); i++)
 		ring_req->seg[i] = shadow->seg[i];
 
+	shadow->inflight = true;
+
 	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(ring, notify);
 	if (notify)
 		notify_remote_via_irq(info->irq);
@@ -224,6 +232,13 @@ static int scsifront_do_request(struct vscsifrnt_info *info,
 	return 0;
 }
 
+static void scsifront_set_error(struct vscsifrnt_info *info, const char *msg)
+{
+	shost_printk(KERN_ERR, info->host, KBUILD_MODNAME "%s\n"
+		     "Disabling device for further use\n", msg);
+	info->host_active = STATE_ERROR;
+}
+
 static void scsifront_gnttab_done(struct vscsifrnt_info *info,
 				  struct vscsifrnt_shadow *shadow)
 {
@@ -234,9 +249,8 @@ static void scsifront_gnttab_done(struct vscsifrnt_info *info,
 
 	for (i = 0; i < shadow->nr_grants; i++) {
 		if (unlikely(!gnttab_try_end_foreign_access(shadow->gref[i]))) {
-			shost_printk(KERN_ALERT, info->host, KBUILD_MODNAME
-				     "grant still in use by backend\n");
-			BUG();
+			scsifront_set_error(info, "grant still in use by backend");
+			return;
 		}
 	}
 
@@ -308,6 +322,8 @@ static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
 	BUG_ON(sc == NULL);
 
 	scsifront_gnttab_done(info, shadow);
+	if (info->host_active == STATE_ERROR)
+		return;
 	scsifront_put_rqid(info, id);
 
 	set_host_byte(sc, scsifront_host_byte(ring_rsp->rslt));
@@ -348,9 +364,7 @@ static void scsifront_sync_cmd_done(struct vscsifrnt_info *info,
 			scsifront_wake_up(info);
 		return;
 	default:
-		shost_printk(KERN_ERR, info->host, KBUILD_MODNAME
-			     "bad reset state %d, possibly leaking %u\n",
-			     shadow->rslt_reset, id);
+		scsifront_set_error(info, "bad reset state");
 		break;
 	}
 	spin_unlock_irqrestore(&info->shadow_lock, flags);
@@ -361,28 +375,41 @@ static void scsifront_sync_cmd_done(struct vscsifrnt_info *info,
 static void scsifront_do_response(struct vscsifrnt_info *info,
 				  struct vscsiif_response *ring_rsp)
 {
-	if (WARN(ring_rsp->rqid >= VSCSIIF_MAX_REQS ||
-		 test_bit(ring_rsp->rqid, info->shadow_free_bitmap),
-		 "illegal rqid %u returned by backend!\n", ring_rsp->rqid))
+	struct vscsifrnt_shadow *shadow;
+
+	if (ring_rsp->rqid >= VSCSIIF_MAX_REQS ||
+	    !info->shadow[ring_rsp->rqid]->inflight) {
+		scsifront_set_error(info, "illegal rqid returned by backend!");
 		return;
+	}
+	shadow = info->shadow[ring_rsp->rqid];
+	shadow->inflight = false;
 
-	if (info->shadow[ring_rsp->rqid]->act == VSCSIIF_ACT_SCSI_CDB)
+	if (shadow->act == VSCSIIF_ACT_SCSI_CDB)
 		scsifront_cdb_cmd_done(info, ring_rsp);
 	else
 		scsifront_sync_cmd_done(info, ring_rsp);
 }
 
-static int scsifront_ring_drain(struct vscsifrnt_info *info)
+static int scsifront_ring_drain(struct vscsifrnt_info *info,
+				unsigned int *eoiflag)
 {
-	struct vscsiif_response *ring_rsp;
+	struct vscsiif_response ring_rsp;
 	RING_IDX i, rp;
 	int more_to_do = 0;
 
-	rp = info->ring.sring->rsp_prod;
-	rmb();	/* ordering required respective to dom0 */
+	rp = READ_ONCE(info->ring.sring->rsp_prod);
+	virt_rmb();	/* ordering required respective to backend */
+	if (RING_RESPONSE_PROD_OVERFLOW(&info->ring, rp)) {
+		scsifront_set_error(info, "illegal number of responses");
+		return 0;
+	}
 	for (i = info->ring.rsp_cons; i != rp; i++) {
-		ring_rsp = RING_GET_RESPONSE(&info->ring, i);
-		scsifront_do_response(info, ring_rsp);
+		RING_COPY_RESPONSE(&info->ring, i, &ring_rsp);
+		scsifront_do_response(info, &ring_rsp);
+		if (info->host_active == STATE_ERROR)
+			return 0;
+		*eoiflag = 0;
 	}
 
 	info->ring.rsp_cons = i;
@@ -395,14 +422,15 @@ static int scsifront_ring_drain(struct vscsifrnt_info *info)
 	return more_to_do;
 }
 
-static int scsifront_cmd_done(struct vscsifrnt_info *info)
+static int scsifront_cmd_done(struct vscsifrnt_info *info,
+			      unsigned int *eoiflag)
 {
 	int more_to_do;
 	unsigned long flags;
 
 	spin_lock_irqsave(info->host->host_lock, flags);
 
-	more_to_do = scsifront_ring_drain(info);
+	more_to_do = scsifront_ring_drain(info, eoiflag);
 
 	info->wait_ring_available = 0;
 
@@ -416,20 +444,28 @@ static int scsifront_cmd_done(struct vscsifrnt_info *info)
 static irqreturn_t scsifront_irq_fn(int irq, void *dev_id)
 {
 	struct vscsifrnt_info *info = dev_id;
+	unsigned int eoiflag = XEN_EOI_FLAG_SPURIOUS;
+
+	if (info->host_active == STATE_ERROR) {
+		xen_irq_lateeoi(irq, XEN_EOI_FLAG_SPURIOUS);
+		return IRQ_HANDLED;
+	}
 
-	while (scsifront_cmd_done(info))
+	while (scsifront_cmd_done(info, &eoiflag))
 		/* Yield point for this unbounded loop. */
 		cond_resched();
 
+	xen_irq_lateeoi(irq, eoiflag);
+
 	return IRQ_HANDLED;
 }
 
 static void scsifront_finish_all(struct vscsifrnt_info *info)
 {
-	unsigned i;
+	unsigned int i, dummy;
 	struct vscsiif_response resp;
 
-	scsifront_ring_drain(info);
+	scsifront_ring_drain(info, &dummy);
 
 	for (i = 0; i < VSCSIIF_MAX_REQS; i++) {
 		if (test_bit(i, info->shadow_free_bitmap))
@@ -586,6 +622,9 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,
 	unsigned long flags;
 	int err;
 
+	if (info->host_active == STATE_ERROR)
+		return SCSI_MLQUEUE_HOST_BUSY;
+
 	sc->result = 0;
 
 	shadow->sc  = sc;
@@ -638,6 +677,9 @@ static int scsifront_action_handler(struct scsi_cmnd *sc, uint8_t act)
 	struct vscsifrnt_shadow *shadow, *s = scsi_cmd_priv(sc);
 	int err = 0;
 
+	if (info->host_active == STATE_ERROR)
+		return FAILED;
+
 	shadow = kzalloc(sizeof(*shadow), GFP_NOIO);
 	if (!shadow)
 		return FAILED;
@@ -709,6 +751,9 @@ static int scsifront_sdev_configure(struct scsi_device *sdev)
 	struct vscsifrnt_info *info = shost_priv(sdev->host);
 	int err;
 
+	if (info->host_active == STATE_ERROR)
+		return -EIO;
+
 	if (info && current == info->curr) {
 		err = xenbus_printf(XBT_NIL, info->dev->nodename,
 			      info->dev_state_path, "%d", XenbusStateConnected);
@@ -784,7 +829,7 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info)
 		goto free_gnttab;
 	}
 
-	err = bind_evtchn_to_irq(info->evtchn);
+	err = bind_evtchn_to_irq_lateeoi(info->evtchn);
 	if (err <= 0) {
 		xenbus_dev_fatal(dev, err, "bind_evtchn_to_irq");
 		goto free_gnttab;
@@ -914,7 +959,7 @@ static int scsifront_probe(struct xenbus_device *dev,
 		goto free_sring;
 	}
 	info->host = host;
-	info->host_active = 1;
+	info->host_active = STATE_ACTIVE;
 
 	xenbus_switch_state(dev, XenbusStateInitialised);
 
@@ -982,10 +1027,10 @@ static int scsifront_remove(struct xenbus_device *dev)
 	pr_debug("%s: %s removed\n", __func__, dev->nodename);
 
 	mutex_lock(&scsifront_mutex);
-	if (info->host_active) {
+	if (info->host_active != STATE_INACTIVE) {
 		/* Scsi_host not yet removed */
 		scsi_remove_host(info->host);
-		info->host_active = 0;
+		info->host_active = STATE_INACTIVE;
 	}
 	mutex_unlock(&scsifront_mutex);
 
@@ -1009,9 +1054,9 @@ static void scsifront_disconnect(struct vscsifrnt_info *info)
 	 */
 
 	mutex_lock(&scsifront_mutex);
-	if (info->host_active) {
+	if (info->host_active != STATE_INACTIVE) {
 		scsi_remove_host(host);
-		info->host_active = 0;
+		info->host_active = STATE_INACTIVE;
 	}
 	mutex_unlock(&scsifront_mutex);
 
@@ -1029,6 +1074,9 @@ static void scsifront_do_lun_hotplug(struct vscsifrnt_info *info, int op)
 	unsigned int hst, chn, tgt, lun;
 	struct scsi_device *sdev;
 
+	if (info->host_active == STATE_ERROR)
+		return;
+
 	dir = xenbus_directory(XBT_NIL, dev->otherend, "vscsi-devs", &dir_n);
 	if (IS_ERR(dir))
 		return;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 09:25:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 09:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309043.525081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aa-0004AO-PG; Wed, 20 Apr 2022 09:25:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309043.525081; Wed, 20 Apr 2022 09:25:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6aa-0004AH-MC; Wed, 20 Apr 2022 09:25:32 +0000
Received: by outflank-mailman (input) for mailman id 309043;
 Wed, 20 Apr 2022 09:25:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nh6aZ-00046i-6h
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 09:25:31 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2f20bfbb-c08b-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 11:21:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0849C1F380;
 Wed, 20 Apr 2022 09:25:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B698C13A30;
 Wed, 20 Apr 2022 09:25:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id FzNFK3HRX2J1EAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 09:25:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f20bfbb-c08b-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650446706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=3E7uGHyVSRLlv1q/BP8AWtqLSArF2xlrVNvb53ZZO3Q=;
	b=NMLVxS0XMRvWXReWNfowiUHySlIATTs0qYOx3BLmMovlp82yKFTiB3IwQ4F/agcqzd0JHr
	VFlhKH2x+iPFwtXn4eQ7JsfcC3e4ClBot4vi8F3e+C75NLAw9vAQuyx0PZQpDvYC1ln1AS
	4YxztFMutLngFG/7ISGEdFELcUZmNEc=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 0/4] xen/pv-scsi: update header and harden frontend
Date: Wed, 20 Apr 2022 11:24:59 +0200
Message-Id: <20220420092503.11123-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Update the Xen PV-scsi interface from the Xen tree and adapt the
related drivers to use the new definitions.

Harden the frontend driver to be no longer vulnerable to a malicious
backend.

Juergen Gross (4):
  xen: update vscsiif.h
  xen/scsiback: use new command result macros
  xen/scsifront: use new command result macros
  xen/scsifront: harden driver against malicious backend

 drivers/scsi/xen-scsifront.c       | 168 ++++++++++++++++++++++-------
 drivers/xen/xen-scsiback.c         |  82 +++++++++++++-
 include/xen/interface/io/vscsiif.h | 133 ++++++++++++++++++++++-
 3 files changed, 340 insertions(+), 43 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 09:25:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 09:25:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309046.525093 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6at-0004o0-2O; Wed, 20 Apr 2022 09:25:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309046.525093; Wed, 20 Apr 2022 09:25:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh6as-0004nt-Ut; Wed, 20 Apr 2022 09:25:50 +0000
Received: by outflank-mailman (input) for mailman id 309046;
 Wed, 20 Apr 2022 09:25:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh6ar-0004md-1X; Wed, 20 Apr 2022 09:25:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh6aq-00043C-VP; Wed, 20 Apr 2022 09:25:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh6aq-00063z-H8; Wed, 20 Apr 2022 09:25:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh6aq-0006Gr-Ge; Wed, 20 Apr 2022 09:25:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gDAxrG4WJjFUeThYJd9NHcqfCVSj52odE3p/tFkYNbA=; b=oeQJR0EiDcbXbQDMWY8EyNBkm9
	38p7OAOZw0d8i6p7qr6G3gqMY9qPhvAnYeuIjlygPIMlSR3j0RZmzGmlHOHS2P6OUCbOLwcQBmUZU
	6heNGTT9X6AJ/n+KitgXp1/5BpzJx3hiCrU8zjoNoH9CtDiEmj8G1i2OZbL/PRwL6r44=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169564-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169564: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 09:25:48 +0000

flight 169564 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169564/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   50 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  519 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   24 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 10:07:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 10:07:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309075.525103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh7Ep-0001sY-A7; Wed, 20 Apr 2022 10:07:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309075.525103; Wed, 20 Apr 2022 10:07:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh7Ep-0001sR-7D; Wed, 20 Apr 2022 10:07:07 +0000
Received: by outflank-mailman (input) for mailman id 309075;
 Wed, 20 Apr 2022 10:07:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh7Eo-0001sL-8S
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 10:07:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a02a7355-c091-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 12:07:03 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-HDCpgyIWPzyKxXwxpjFVTw-1; Wed, 20 Apr 2022 12:07:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB7341.eurprd04.prod.outlook.com (2603:10a6:800:1a6::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 10:06:59 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 10:06:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a02a7355-c091-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650449223;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tG+8vnyimSJzaLniMLvuA+E4J04g2IdKBWXm8WqWPpg=;
	b=MyN8fsj3SU5QGWYGitrUynXGPjrOBa5lJK1j7S7ot06jwYGzW/TmIscMiO04WqQdZ7kf0C
	rUf9xcPiHYlEUrjejZeb0jhjuTp9BhHvM5s0fHwnWU1AFsUFEF1JjdYaG7CMStoYLgVTgk
	9DKPs1/zrrZA6cKYKE09kfxS/LaOzdI=
X-MC-Unique: HDCpgyIWPzyKxXwxpjFVTw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Etby1JFuW0vzbDJDWrH8fFCPLB7S+rKpyHxNexmzGpL/H40Co3AW0yCdaIgL+UDukpBx6JzuuHW1eXqTt61mxwHna/08/0vvvM4zSyfDmyRRVdPrUPF01zERYbT7wFHu9n97dv8M6KiT5DXncrn7PymuahHcgz7J6egvKb5Xcpp/oglCxVpHzX0XmOHlgENFQciz8rhpUkbIQSeqlMfunR26zZHxbzztCiANUneH+mMstFlL8wyip3nAeLGNETqP47/kEZLmCvri9bvBPudM/ALqgCyzvdxshqmB50pSYOvYnj4lYWUJiqTm4U0deE0caVJxSzGLLUk5YOCeGqHQwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tG+8vnyimSJzaLniMLvuA+E4J04g2IdKBWXm8WqWPpg=;
 b=JhBJNYCSqRzUMQJuaLS4kwVnqrqLxKoY2DfaSU5DWopISmcgR4HeZCsJMyIuRERC5+QrYNY4J2XAfiVK+NoLwS1NGp6LcyEw2GpOzSbm2Jmh0+VlOlUVPwPxdKkseyz40bTRs3m/xpaPPPGmLFXV+d3vhJo4GnBXl9MCoSu+RyNbrEd4fdp9SDUHf2MqO5C05JVdlITA31Ge2ONb79Nyqgv9Qum+aEyxKYOb2XtPpz6Y2BNPWVpiF3PVnJnYUsB2Z909/hwTXHIx8xuNI2001Pc8ENs182Jyn4fM3b/8Ke3ydh1KpQ38/bTvMhPVlXy2I5tByPCpU3hrE0eC/oE7fw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5f058541-821a-170e-2043-7b32beaf3b98@suse.com>
Date: Wed, 20 Apr 2022 12:06:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] xen/build: Fix dependency for the MAP rule
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220414162348.4808-1-andrew.cooper3@citrix.com>
 <20220414183548.19611-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220414183548.19611-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0041.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0ae04fcf-850b-4194-dd62-08da22b58229
X-MS-TrafficTypeDiagnostic: VE1PR04MB7341:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7341A58EC418C51C0B732334B3F59@VE1PR04MB7341.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mxjbC1DzP+zc6bjexK5rp851/ogkdlm9V0YPdPrMo4Civfk43dUt+IBwQlRAdfzN+aXZzxPMlAPZTNRO4qWTPJhecE8p8dnNx9Z60i0vNoF2lmRzu3u80Mb0rRpR2ClbQQSEavwnAxmaEBcuqu4AMa8bybYLF4tzVFbIGjrWFkBJX1f9KQCoHlqOvujrxx+Rka0OW/03e+crsQ/LRXU6IwVrTQrRb+9M2PjlnGLhZoG8M4rJawnAgbx9TkodPmwFnH7Oo+pbyvDzAyNLkLHOUijrYV7Woi0SdRDOlIXEGcpSmTv17/rdYQf4l2+DKPY5CU4OEjy9qPa9hBgxphGoRhNZ/94XdzRwxRhtbDP4EktzG5ytGTE5KQN4FYWis6uUjTBp4qKIdN50cprCTBicW4hRWRXRBrFdKxPoI4RI1IGh1Tuik7+NGcKnVtD5nFpmLVM+3aVrx3HSQiwAqpaRCp2p8FrqDUE5ipvBGX6pmyAaC4rpeweNyro7f4ZkVlPWPsefh9DNMHuCKWVd8N0Os8J8rM4qP46FoPNWE+mLl6UGR6woufjFjlba9ApAkETVWv04xmySFRhUUucdHDip/Mly+MajxgidVNO/+wotAfKQVjyLeaH9177uzGgW6+iFwzq/GWOsqkx9Za662vTZ+ejovEtizec9BXuqaNexVBO+Ocl7Rpx9q/jPA8rj+ayY4UCdlIfi9/SRetH7JFXbLkm8cj3tuv/i6Kp2VAVCYzk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(558084003)(31686004)(186003)(31696002)(316002)(26005)(8936002)(2616005)(5660300002)(2906002)(508600001)(6506007)(6486002)(86362001)(8676002)(66946007)(6512007)(6916009)(54906003)(36756003)(66556008)(38100700002)(66476007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VkVSNzQzSTJmVTJuVFR6bFJHOHB2Y1ZySHZObndMNlZ5WE52Y285bmpUZkZO?=
 =?utf-8?B?MUpNRkl4T2p6VHpJWm5rODhHMnRsRDNOeEtCamxkOHVxL0NhRDJoYnFIaXo2?=
 =?utf-8?B?cVlHNCtRb3VPSWFHMDdUYmJCUkYzSXhuQTlmeXUwbjdIdnhDR0Q0ZmwyblBt?=
 =?utf-8?B?UkV0NndWYmtuQ1ZQeEV3aDBrRzlxLy9EWGk1MWhQMmkzWWRZQ0grYjlXb0k0?=
 =?utf-8?B?aS9EZ3dTblEwSXk4Q2Z5TjVzeDdicHRXV0lJUmI2TkFVWmU3RGJqK3FBSUd5?=
 =?utf-8?B?cjBEcUxxYTVPK0oxQ05Qa3RWU3FsMDJPcitrOWR3VHRsKzN2YWxpZWFWMVFH?=
 =?utf-8?B?S0dPRXlpQlE1ZVlrazNIamdqYTBjcDJtREFxNU5uL29CZTRHNEtuNWhXZ1l5?=
 =?utf-8?B?d1l1Q1pnVElRLzk0aUp4elJ4aFhsMDRhWm95bEJ2OGJORDZHN1NmMW1ueHQz?=
 =?utf-8?B?OFd3N243eUpjZDRxUkZQbDJlOGdZN3BydWNqYlYwaFZpeHEvaW04a3VyLzg1?=
 =?utf-8?B?bEg3aExnS29rUHFLK04zS0FZUU1EVDVUOTFBKzFyb1RPTEJBVi82dlNkRWg2?=
 =?utf-8?B?enZ3TE05ZTZHMERLZ3M5NUtzSVgxMHk2WlhkNmpqcmFxaXY3amh6S3RBNE8w?=
 =?utf-8?B?ZjdrUUdLOUtJV0djVFRpb1J1THVyR0ZqZUpCTEJwSFo3QjNmYU5ucEc5d3Ay?=
 =?utf-8?B?Z3NuM1A1KzRxOE5Fekt5SUxqR05uYURpN1FrcUE0UVMzVFdLbFZDWVhjd3RK?=
 =?utf-8?B?RHRLUEdjMHdqaWF5UjNrRGs2bzhYejJqZWlkM1lGanVHeGdHUTZrRnlUcDlT?=
 =?utf-8?B?UEtKZTJOL2xhSTFGUGJhaHJrK29NUldtdkVwZVBYZzBzam5DTWpMMDV2TzNz?=
 =?utf-8?B?TFRXVVJZYnU3ZVpmc3dMeXZOQWRzVWpNc2tSTmdSNDF3VFVjMFhOek9POUty?=
 =?utf-8?B?TE11Y21mbXllQlVkaE15b2hyQ3Blc3RzU3c4djM1czFJUjI0anNLSFBkQ1c2?=
 =?utf-8?B?TkZQNm9DdjVtSTh0YktVaUhjNThra1FqZzFqdTA2V2tPL2ZSUlIyMXhRbW1J?=
 =?utf-8?B?b0tmT0FBcWpRMnFlNnlIR0RmYjlOSnNvSWRBY051RUlVTTBwbVhzQjJ0bitE?=
 =?utf-8?B?UW9SL3pyUGV6UElTUlV0amtTU2tFL0hjYzliVVdkTHhic0J0YUswanZJSkZK?=
 =?utf-8?B?VE9PYUd5SDBZN0ErZWJkaFhkTmFlMVBWcm9rR0lOV3I3eXZPSSs5L0piN3I4?=
 =?utf-8?B?cm4vekpXblZSRmNQMDNKNTE4U2RjV2RlR25HeWd5N2xnSjgzb2hVdHIvcmVx?=
 =?utf-8?B?eFF5eWtUcnh0cFAwQUpTcDh2OHdTcXhJczNHZStGdklBUjVycit1VkpVM3Fl?=
 =?utf-8?B?MFRYaTdTangvNGYwZWFvUERRWVQxREw1Z0hsSTdlR3FNbGNXNGRrSWczYTVh?=
 =?utf-8?B?QTNWOVRtaHdZRyt0QlYrS2NMUXhLRXpiRE1wSXI4bXR4QzRGV0ZrMkhhRkVG?=
 =?utf-8?B?cGRRcml2eHI2MVFtRmhvelBDY2ZpWi94WElXeUw4ckRtaVMrSnduSlFKdmtJ?=
 =?utf-8?B?amFCemZyWE5KS3FDSGM3Z2d4UXJnRllGSGh2ek9hR2hCZUJMZlYzMFVZaFBW?=
 =?utf-8?B?di9FUkorZ3dEVVpScHI3eUZLZWM5S0hSVUZTRW5NZDNkRUlqaU0yNWZyNzk0?=
 =?utf-8?B?VUNuM3gxa2RLMTVPVVdzaHNPa1hCREYrQTMzSmc5cUV1ZENsWG9SQWxpd3Nr?=
 =?utf-8?B?Lyt3elZkb09sNWsra0RkZzhjenlEYWVYS0t4UVhYTS81WCs3NEFoQStvT2Nx?=
 =?utf-8?B?dDVUL25IeXhPMnFPbWF1Q1gzdUhDT3JIWENMWmF5V0FmaTY3eG5UNUMvdHVN?=
 =?utf-8?B?NlVaMUV0NEt2RlNJOFMvYVhMSmZSSmdqQnBXMHZjUHNoL3NkeDdmYUNIV3VQ?=
 =?utf-8?B?OG5kNG9LUjRYV2x6aXZ4Ry9SQytOR3kybXF2VWZPNUhUQmtzZi90QU90NklT?=
 =?utf-8?B?OXgxakZMRUtjN0dkM2F5Uk5NeTVlaXlZTll6NWtNSE1HdVZjTHlkaWdtZmtD?=
 =?utf-8?B?VU9zM3lmMEtrSE15Zk5qVlZ5dms0Sjh1aXM0NjNtYzJyUnozZ0xiNnpXT1RY?=
 =?utf-8?B?ZDV0ejRKMHViR0xpTEprNEpTU2QyTWRNWUNYWklLQktYNkd5aGdjUHlOSWxI?=
 =?utf-8?B?MnJwSU1UM2ZDcFJCVzV1bFBWYVQvMVlRczJmdjdrbnNOVEN0TlhIK1NFOFRj?=
 =?utf-8?B?SVBWa3c3QjEyalVGSEdPMVdhVGQ3c0pHSFE4SDBZeWNVOVNiU1U2ZytPcTh0?=
 =?utf-8?B?K2hVOFJiS2g3WmovWWdkeG1Zand5UWhqeXVvN0NlWHZCeG9XN2FlQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ae04fcf-850b-4194-dd62-08da22b58229
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 10:06:59.8302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 89yQWgMqzqCHY1c4gxYkMgvMcM5o2ovJR1fqjE2wqc3qsekpvZupw/FlImHYD+IVld5n6lEAm0l61DQNezX/9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7341

On 14.04.2022 20:35, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

Needless to say that the generated System.map may not represent reality
if xen.efi is what is in actual use.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 10:15:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 10:15:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309082.525115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh7Me-0003Xm-8V; Wed, 20 Apr 2022 10:15:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309082.525115; Wed, 20 Apr 2022 10:15:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh7Me-0003Xf-5Z; Wed, 20 Apr 2022 10:15:12 +0000
Received: by outflank-mailman (input) for mailman id 309082;
 Wed, 20 Apr 2022 10:15:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh7Mc-0003XZ-Ng
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 10:15:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb8b3aa1-c091-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 12:09:09 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-3ok_hlvePsKhFJAtCevB_w-1; Wed, 20 Apr 2022 12:15:07 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR0402MB3505.eurprd04.prod.outlook.com (2603:10a6:208:25::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 10:15:06 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 10:15:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb8b3aa1-c091-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650449708;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5m3438VyS9HHNrGeG1RmloZAWK7+eBdkG3jaGsrzOzk=;
	b=Kb9esCj6LXZqCF5gLYZCRx3bRKka9eJN9bzh69zwiY6WXN/VNGqpiHFDB45gZ9ro4bSIO1
	zOgtqccUIAt8Phztk2TngYW8EtMvzxgD9LOMYaANlVatH9/prIwuETOPQCQX6w1oxL+pNu
	CjPRjbWkD6WdyO1CX1TxXcBMTGYDLaU=
X-MC-Unique: 3ok_hlvePsKhFJAtCevB_w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XMB66/Wh3+E83wOn9L4CizyRyYKXTcCD2SGwLRSUl6TAXmVDgiKdtvgTRlrEjnx8dbZ2HxS7pIsMbioD67CVvMKRf17nE6M7QnLf9fb+ug19Cm9q+lZcKdFohZRoPZCRBls0qN6dP9EM+QvPQD6zN4wxGKra5RXIluZwZVjQzQD/WopcgEq/TJmznm9xjaEpOV5z+uJgeXV7g7stPWVC18AKWUg/OiSkOvY3fUjV4ee7muSaktPGsZuj++xAXck7+rmthFBFyPgKYcOByg2QF9QeSvsjhfh2A6l3j7nt7YNMOGHh3mUa2t9uvBqoz0GaqHEd+t4nPC7oC2hf9xCeSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5m3438VyS9HHNrGeG1RmloZAWK7+eBdkG3jaGsrzOzk=;
 b=gRWr5WxxC9VqjMYPPLlHx14Lskymw9dEzdchv+aklZ28qBUDkD+JIGbROtAYqKD5HbxBVrfNUT7tyTLpp6Uv2peR4cBj4tu5TyTHfp92Fm6KPuL5rqIWLASrSD2XwD5NQjbKwNOGMkP8MHY3bnfp+X2CKVozxv5JP7YBqJ9Vyui0aV7B17h05RIm+mBfhj2mp/6kl+fp+F4ZSKKXTju4CKVi9WBjrrnhX/hGEKWm4Ugkrb//VJPu2ITWFOl15wNgHCfJ3swra1VVHBkfeCVlUWIBWagEwhFFeWGrfCR3JpE9QZK7YUcexBB5opxYB6e8XkcnTyaQCOFqpZNI8kMaig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1365ce99-a195-66ab-45ca-5e85c3fda930@suse.com>
Date: Wed, 20 Apr 2022 12:15:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/3] x86/build: Rework binary conversion for
 boot/{cmdline,reloc}.c
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220414114708.4788-1-andrew.cooper3@citrix.com>
 <20220414114708.4788-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220414114708.4788-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0002.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c7e6308-cc5b-47dc-632a-08da22b6a439
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3505:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3505AD7472FB384068E052BBB3F59@AM0PR0402MB3505.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sDWrfjvd8hfBlfuhvPEu9mrGsdI9rgFYUXb0J4OMKudLbrf+3snOZaHGp3rSsqc0qsUxmb9rwIravI7qJievOdXkOQ0i+dD0nIVCwFLdrfrVuXZtNBTYX13bhs0kL+CR3z5BAyNEy1mEcfkIkCIyoCQ+5QNmCpvPX6ljdLi8VvoWqRyoQendjuk2rhbJEyIwxpoFXdifwiXB8T+GAyjviiOav2EUR2pmqhlbYq9+k2Sfe2lmB5v1QzKHqR1SETlQwtKFHo7SezSksjCaBAqeR/pVG/pnWkIZy5l4BhBsjNlEaieBkOomz5zYl1z2lhEIuMGMT3tY4WZs0SDPF0+JscYV8tUdYuSLtoVyfYqpnc748kCWj8Iaxd/0A7i4L1csw7evJ59TjSSjL9aemkxLgfRKnIpcatqis/Gqv/VxcraWdtcScMmYmri6zp8JwkKUze6tSewYJKvxl6vX+8kggav77QKyNnMFL3PfKCYBkRMgU/3p6lv2cbckhOqWBhc23CtawX5aQxgx/GgQZVB0y1BUC4nKWaJo0pCCbrHJ3XMBv8NTgNJCupT7RShyVzpmyLnTGsWva44H2Va9x1P4xgSop74+zUyDCFxXU6okwVMKp38WOSePosZTZejAnq9A8CmncL8lOGRzGEX5cZBvgzO7Xn21fap913E0esUDPnr8UetjhWiXaDGQPckkMQLzXANSMVlX+aA5vN2YsePqNHmM3Gfd/XiRk2QKEXGO5P1Gbax+gJ0mjCd5SX2LvCLB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(36756003)(38100700002)(31686004)(508600001)(5660300002)(6512007)(6506007)(26005)(53546011)(186003)(6486002)(2616005)(54906003)(86362001)(2906002)(6916009)(31696002)(316002)(66556008)(8676002)(66946007)(4326008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RThucXBIaURRTmNPS2RHY0xURkd4WGkyVjNpUTJCb2J3WjZuSHE1eUMzYUJH?=
 =?utf-8?B?TG1RZWE0RVpKUjJjSXkrZndLYmtNbWFNc0xRazRYSzFZNUErcUpCNW8zSTM1?=
 =?utf-8?B?STJCRk1zbmZRRzEvdUZTSmFvTTJjVDRkM2g5UWJScmdtKzdEME8yYkxBdjVE?=
 =?utf-8?B?NDVpNlhDRFpBSFdIeFlSSzlZcTdtdHJTb2NadUw1NXB5UDl6QUo4M1g2Z0R1?=
 =?utf-8?B?ZU9SMFcveVdRUVFWUWlFUzVTb2FoU2dpS05FNTNmOHh6TkNzNGVidVlNeGVu?=
 =?utf-8?B?bWhtVzRPeFFkSWl3YkdGV0lLN2wwZTdOamV4d1pVWWpOVTBCc0JPRnFkYUJj?=
 =?utf-8?B?Y0UycWpzOUwzUnBERXI3QjZLNEZNTDdHa08xeGV0VU9seHVpcG5OQ1ZRTENY?=
 =?utf-8?B?NGpUN1ZYSEVYb0pXRkM2a3ZvSW9LWEJEQldTZ1NOc2VRWXdCc2U3SmNxVnd0?=
 =?utf-8?B?bHBYQ2dmNWVlNzFhM21WbEFBRDRsbFhteUJuTnc0aGcvTkhKa3lRTGZNKzI2?=
 =?utf-8?B?dkRNejVTZkRiK1RvbC9KMW1EN01zb3JuMFZKK2N1Q2VPSDE0RVdkc09QOHBn?=
 =?utf-8?B?aGxudU5vNzdiUFl5ekxSZWYxa2VORGFNQVFlL0NHcW95dDBRTUJaa05ZWkNE?=
 =?utf-8?B?aksxU0dIUGN3Y09BbFpnc1cra0VzeDFoVFFSem5mYmdvWlZDdHpOUnFIelR5?=
 =?utf-8?B?K1JxaDJwdE53UTJFbU9WaW1KTnZ3YVlNb1AwdzBpS0J3cE5EQUFUbkYzUDNz?=
 =?utf-8?B?ZnFpQkN6QitOazA4VWprVGh3amxiY3BCZjN6U05ZSUIxSmI3THJjWkxMTHZa?=
 =?utf-8?B?STd4WnVPYmVhNlNEbnpJUzhoamErNW9SUkU0VUM5TmhZdmNGbWVhSlR3ck9B?=
 =?utf-8?B?OGVCc0puU2IvTUpFeFlyL0RFbUpZckk0Z0d1dTBhWEU2QkM4eEtvMDFJdVpQ?=
 =?utf-8?B?Y2NkV0JJQ1M4UnQyVFcvbkE2ZjI4ODlFY2cvV2ROenkwcjFDVUZNY3hEaU9Q?=
 =?utf-8?B?cStHUUsyUEdrTlpkWG1nbmorbWEzWGlWWmxXTWxLZUZZK0djQ3A2UnNCdWtw?=
 =?utf-8?B?OEJwbTYzbVFCdGxEUUN2aGxvWkE0dWZESHR0cGVxc010NXRxMDREaFZOTlll?=
 =?utf-8?B?a1lYZVFEcEFwdWJBTnF4YUF6b3B2a21zRmFqSUhkZVBubXhwQlNjZ1k1Tnhx?=
 =?utf-8?B?SXhsYkFUdWk4bUE4ck1hLzNHMlR5aVUxWjQzN3Bqak5teWRRWFpmR1pUdFZR?=
 =?utf-8?B?Z2FUOTJ4NmI3NkdIb0VRY0QwTmx4djZ5NDhtZWVTVGsyaVU0cml4Q1RsZWhu?=
 =?utf-8?B?MzMvNmJZVDh4bGg1d1JuU292S3dtQU1pM0dHSzM3UlZpeHNldTk4SmxhVU9K?=
 =?utf-8?B?WlpoVjRVODdOOFV5YnVkSitUUWcvaE5kRXZXa2dJYUdtOVhMMVgzNEtOeGtN?=
 =?utf-8?B?SjYvakFGTFRVRGdZQ3B1OVdvc1l0Y3RpSDNmN04xVEZVWFJTaTI5MldzdlJ2?=
 =?utf-8?B?aWRLSGtJVi8xZG5JV3JKK0FnUStKdkFZWW9zRE9HYVpUb01qRTQzb0p6Z24x?=
 =?utf-8?B?OXFjTHFsTllsdjhKaCtlc0J2VDNwZXpWZXVVL016aTk5L24wMHhrLzJsMmlK?=
 =?utf-8?B?STZBbkdseWcxRjBOTnkzOU9vTi91SHcrMGQ5K2J4Y1JQbEhQOTZsWE9tMTQw?=
 =?utf-8?B?NklDeGF2cWttWVNEQVVxN0huaS84RnNEVWN2d1ZTWGtsUUsxZGl6SFFUVzkz?=
 =?utf-8?B?MlR0Zi9tellpNFF6c0dCRDQvNmp6bC9ySjcybk5XMmFMbFdCZ1lFYkU5VGpK?=
 =?utf-8?B?QnEvWmNJNWRYcnM4TmxqQXpHMG5sRndlMHo4Rm90N0gvNkR4ZjR5U0Y3Tjgx?=
 =?utf-8?B?VHl5MUZnNlBCV0ltMWc0bDhXTHVCdHAwRnBPaEtiSHA1Ni9PRkJkelp4c1ZH?=
 =?utf-8?B?Rko3T3NBOUdmZUxFSGJKOVlaU1JaSlQ2L1JJWGo3dDlFWGRFVEoyNUU1M2pD?=
 =?utf-8?B?QnNwb0x0YXd3WFcyeno2UXZ4NjFweEREZ2d0WStNZXpaK2JPSlNXQWhhc2ZS?=
 =?utf-8?B?bEJVZUk2dGNOdkJXQUZwWUplOHdjaTkyR3JtQ1BiWGl6T1lyWU91ekhvbWRk?=
 =?utf-8?B?d3NyVDJ5Z3Q4a1pOVkRPSDFvWmVpWnJOb0NETU1OU29HZnhqaktaY2ZrSUgw?=
 =?utf-8?B?aGQydnhkZ1NvajNVeVBzT0Q3dEhMRU10RGFwZDdVTzVuMzdzc3F6LzUzZTcr?=
 =?utf-8?B?ekxkU2loTGxZZThJalpReTBROUUrRHY1TGtKU1NRT2VPYUhRWDZhUk5TNzQy?=
 =?utf-8?B?bjRyZlJhdTNrTTZIRi96bmFWN1FCcVBjb0h6UHNwalFkTzQ4ODFUUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c7e6308-cc5b-47dc-632a-08da22b6a439
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 10:15:06.2057
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N+CbSJmkBL9CCIptGR2t/WX1hK3R1dYo6l3fadmqa8hwiZZvO3zXqwFsb3HUG9On4pIM6rl+ioPsE7EIIWrDgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3505

On 14.04.2022 13:47, Andrew Cooper wrote:
> --- a/xen/arch/x86/boot/build32.lds
> +++ b/xen/arch/x86/boot/build32.lds
> @@ -31,44 +31,36 @@ SECTIONS
>          *(.bss.*)
>    }
>  
> +  /* Dynamic linkage sections.  Collected simply so we can check they're empty. */
> +  .got : {
> +        *(.got)
> +  }
>    .got.plt : {
> -        /*
> -         * PIC/PIE executable contains .got.plt section even if it is not linked
> -         * with dynamic libraries. In such case it is just placeholder for
> -         * _GLOBAL_OFFSET_TABLE_ symbol and .PLT0. .PLT0 is filled by dynamic
> -         * linker and our code is not supposed to be loaded by dynamic linker.
> -         * So, from our point of view .PLT0 is unused. This means that there is
> -         * pretty good chance that we can safely drop .got.plt as a whole here.
> -         * Sadly this is not true. _GLOBAL_OFFSET_TABLE_ is used as a reference
> -         * for relative addressing (and only for that thing) and ld complains if
> -         * we remove .got.plt section here because it cannot find required symbol.
> -         * However, _GLOBAL_OFFSET_TABLE_ is no longer needed in final output.
> -         * So, drop .got.plt section during conversion to plain binary format.
> -         *
> -         * Please check build32.mk for more details.
> -         */
>          *(.got.plt)
>    }
> -
> -  /*
> -   * Discarding .shstrtab is not supported by LLD (LLVM LD) and will trigger an
> -   * error. Also keep the rest of the control sections to match GNU LD behavior.
> -   */
> -  .shstrtab : {
> -        *(.shstrtab)
> +  .igot.plt : {
> +        *(.igot.plt)
>    }
> -  .strtab : {
> -        *(.strtab)
> +  .iplt : {
> +        *(.iplt)
>    }
> -  .symtab : {
> -        *(.symtab)
> +  .plt : {
> +        *(.plt)
>    }
> -
> -  /DISCARD/ : {
> -        /*
> -         * Discard everything else, to prevent linkers from putting
> -         * orphaned sections ahead of .text, which needs to be first.
> -         */
> -        *(*)
> +  .rela : {
> +        *(.rela.*)
>    }
>  }
> +
> +ASSERT(SIZEOF(.got) == 0,         ".got non-empty")
> +/*
> + * At least GNU ld 2.30 and earlier fail to discard the generic part of
> + * .got.plt when no actual entries were allocated. Permit this case alongside
> + * the section being empty.
> + */
> +ASSERT(SIZEOF(.got.plt) == 0 ||
> +       SIZEOF(.got.plt) == 3 * 4, "unexpected .got.plt size")

While here you've adjusted for this being 32-bit code, ...

> +ASSERT(SIZEOF(.igot.plt) == 0,    ".igot.plt non-empty")
> +ASSERT(SIZEOF(.iplt) == 0,        ".iplt non-empty")
> +ASSERT(SIZEOF(.plt) == 0,         ".plt non-empty")
> +ASSERT(SIZEOF(.rela) == 0,        "leftover relocations")

... this (and the construct making the section) would need
converting (or amending) too, as 32-bit uses .rel.*. Then

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 10:46:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 10:46:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309087.525125 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh7qw-0007I2-IE; Wed, 20 Apr 2022 10:46:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309087.525125; Wed, 20 Apr 2022 10:46:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh7qw-0007Hv-FN; Wed, 20 Apr 2022 10:46:30 +0000
Received: by outflank-mailman (input) for mailman id 309087;
 Wed, 20 Apr 2022 10:46:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh7qv-0007Hl-7a; Wed, 20 Apr 2022 10:46:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh7qv-0005Uq-47; Wed, 20 Apr 2022 10:46:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh7qu-0001tn-Ou; Wed, 20 Apr 2022 10:46:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh7qu-000528-O0; Wed, 20 Apr 2022 10:46:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=e/CiuuC0oHDmOkBipp0V2lkSrezdJnYKLyFiDOQmtbo=; b=UNq5ImUqBNPZNgHxMFKFNwfU9I
	ZNMr0F5yoOYqLqGHTaU+Yym3Jb9ESdv9yYaxRwibts8zpL8VcZfcfKy4cPArGItY2drQg+ZK3Nvlh
	I9xDd201W52if4dIK78+4UuJP5UdMLYNm4vNDWvpn9xl4kZZUTg9whsS13/0SrN6nI+4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169567-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169567: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=76fda1def3d1baea3b01ae697687ff478d2d1b42
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 10:46:28 +0000

flight 169567 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169567/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 76fda1def3d1baea3b01ae697687ff478d2d1b42
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  520 attempts
Testing same since   169527  2022-04-19 01:40:37 Z    1 days   25 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5491 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 10:54:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 10:54:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309095.525137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh7yx-0000S2-CA; Wed, 20 Apr 2022 10:54:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309095.525137; Wed, 20 Apr 2022 10:54:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh7yx-0000Rv-8p; Wed, 20 Apr 2022 10:54:47 +0000
Received: by outflank-mailman (input) for mailman id 309095;
 Wed, 20 Apr 2022 10:54:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aiw3=U6=gmail.com=marco.cacre@srs-se1.protection.inumbo.net>)
 id 1nh7yw-0000Rp-6y
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 10:54:46 +0000
Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com
 [2607:f8b0:4864:20::329])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 492fb49d-c098-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 12:54:44 +0200 (CEST)
Received: by mail-ot1-x329.google.com with SMTP id
 l9-20020a056830268900b006054381dd35so842503otu.4
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 03:54:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 492fb49d-c098-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
        bh=fJbB7O5xgMBxAUNVHvYEZu+IEyvWq75AQ/22AeyydQ8=;
        b=ITcTYNtDhVrttns/UrkrjwonupiDda/sVofVaUMpCgcZ4KsIaaaT7esfF+qBLaM/wn
         0PWGUhvIf5TwqO7BQ/EAMo+SHX5DUF9qhOEncoIRHU5rSvsFEQa1DX7RUu33zDks2mlJ
         CH1mcW4khr+99fE/DrijfNwVjd+HZsndVnSshYoJm85ZGjR6G2YUW80j8oCJxO1hrF74
         mrG2xY4Mmig5jP6vd08UbKzMrUHEJtI9sh/GC6Hl+cTa3lfrpaQXT6VK8+Tne+cH3cVN
         o1UcHyiP463bthg0Zw64I2gotM2XvFKTa6igSm/Y//bG5O466IW8gCIOLQVpoBLrdPuk
         TMcQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to;
        bh=fJbB7O5xgMBxAUNVHvYEZu+IEyvWq75AQ/22AeyydQ8=;
        b=dsXQtLnX5d4yn99Zm03AH24TBoGKaAAhsKvMU/HE7YCuUtKmkQlIgDWz0Wr4OATri+
         NT763OTGjnPUKZAdtpUrDECmQW6zuHe35L0n8apOpCVP8LkXFJHVELIX0ukC2RAy4rTM
         UP6yP2Ge9hyHSpPr2I/w5uhLFT+GIKLhG6OfSxHWxZ1+kZF5AeYB21NMPm851VCUsC24
         s8Wr4cAK8siOwkWMzy/c8RZWB6JCLjiLrGN7GSMNBajhTw0Qo9qk/kl91zqGxdNzxB/P
         0B3QXac0qtL+9CqdnuPeeVROKNhVLHO8Ndcr3xSUXNlzP6z2nkNVJypqlsujVsE1fU75
         YRPw==
X-Gm-Message-State: AOAM531NxIuxoWwHswV7tDTp+aEWbIAFGnd7NEeHU9svSkFiKMuNj5RE
	xLgwfi/mfbd5O//uuh5p2aWK1/puohHYKcfve9QmmntHTHI=
X-Google-Smtp-Source: ABdhPJzorug5yZhEx3mkl56tKRB0GXWXSRCyZ42akXYpDdkeGqR8WoAhnobPxnTWv4uxCk0AGBjQuuBzukbO4Eml2Sk=
X-Received: by 2002:a05:6830:1618:b0:605:4793:fac9 with SMTP id
 g24-20020a056830161800b006054793fac9mr6448926otr.48.1650452083219; Wed, 20
 Apr 2022 03:54:43 -0700 (PDT)
MIME-Version: 1.0
References: <CAGHctbYx6sspA__OmKyumU+WkhzEsDpLstyhRDM9Kbc696Co7Q@mail.gmail.com>
In-Reply-To: <CAGHctbYx6sspA__OmKyumU+WkhzEsDpLstyhRDM9Kbc696Co7Q@mail.gmail.com>
From: Marco Cacre <marco.cacre@gmail.com>
Date: Wed, 20 Apr 2022 12:54:32 +0200
Message-ID: <CAGHctbZzRc3PqzTd22_NpN4VHyB3DPyHJF2BoqAgBOcVp5_4ZA@mail.gmail.com>
Subject: Re: Problem creating domU guest on arm64
To: xen-devel@lists.xenproject.org
Content-Type: multipart/mixed; boundary="00000000000023b72d05dd13d25a"

--00000000000023b72d05dd13d25a
Content-Type: multipart/alternative; boundary="00000000000023b72c05dd13d258"

--00000000000023b72c05dd13d258
Content-Type: text/plain; charset="UTF-8"

Hi  all,



I did several attempts but I have always problems with disk backend setup
during creation of domU domain.



The latest attempt was using deban arm64 image with this configuration:



memory = 512
name = "debian"
vcpus = 1
maxvcpus = 1

kernel = "/home/xen/vmlinuz"
ramdisk = "/home/xen/initrd.img"
disk = ["phy:/dev/loop0,xvda,rw"]
extra = "root=/dev/xvda rw console=hvc0 earlyprintk=xen"



kernel and ramdisk boot up successfully and I can attach to the domU
console, but when I try to define the disk backend with the debian rootfs
the creation of the domain fails.



rootfs is attached to loop device as follow:



losetup /dev/loop0 /home/xen/rootfs.img



I attached to this mail the verbose trace of the command xl create



Thanks a lot in advance for any kind of help

Best Regards

Marco

Il giorno ven 15 apr 2022 alle ore 12:56 Marco Cacre <marco.cacre@gmail.com>
ha scritto:

> Hi all,
>
> I'm facing always the same problem (described below) trying to create a
> Xen guest domain on rockpro64 (arm64).
>
> I have successfully built uboot, xen (4.14.4) and dom0 linux kernel with
> xen tool stack, these two last starting from buildroot (with linux kernel
> version 5.15.33 and xen toolstack version 4.14.4)
>
> These are the process of Xen:
>
> 177 root    /usr/sbin/xenwatchdogd 30 15
> 203 root    /usr/sbin/xenstored --pid-file /var/run/xen/xenstored.pid
> 208 root    /usr/sbin/xenconsoled --pid-file=/var/run/xen/xenconsoled.pid
> 214 root    /usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 -xen-attach
> -name dom0 -nographic -M xenpv -daemonize -monitor /dev/null
> -serial/dev/nul -parallel/dev/null -pidfile/var/run/xen/qemu-dom0.pid
>
> and the drivers loaded as a module:
> # lsmod
> Module                  Size  Used by    Tainted: G
> xen_netback            65536  0
> xen_blkback            49152  0
>
> Xen and dom0 Image boot up successfully, at the end:
> ================================================
> >xl list
> Name                                        ID  Mem VCPUs State Time(s)
> Domain-0                                    0  1024    2    r-----
>  4000.3
>
> # uname -a
> Linux rockpro64 5.15.33 #3 SMP PREEMPT Fri Apr 15 11:01:37 CEST 2022
> aarch64 GNU/Linux
> ================================================
>
> when I try to create a domU domain I have problem with disk backend, I
> have made several attempts trying with different domU linux and I always
> get the following error :
>
> ================================================
> Parsing config from ./alpine_xen_domu.config
>
> libxl: error: libxl_aoutils.c:539:async_exec_timeout: killing execution of
> /etc/xen/scripts/block add because of timeout
> libxl: error: libxl_create.c:1608:domcreate_launch_dm: Domain 2:unable to
> add disk devices
> libxl: error: libxl_aoutils.c:539:async_exec_timeout: killing execution of
> /etc/xen/scripts/block remove because of timeout
> libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain
> 2:Non-existant domain
> libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 2:Unable
> to destroy guest
> libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 2:Destruction
> of domain failed
> ================================================
>
> The last try was with alpine domU linux with the following config:
> ================================================
>
> # Alpine Linux PV DomU
> # Kernel paths for install
> kernel = "/home/xen/vmlinuz-virt"
> ramdisk = "/home/xen/initramfs-virt"
> extra="modules=loop,squashfs console=hvc0"
> # Path to HDD and iso file
> disk = [ 'format=raw, vdev=xvda, access=w, target=/data/a1.img',
>         'format=raw, vdev=xvdc, access=r, devtype=cdrom,
> target=/home/xen/alpine-virt-3.15.3-armv7.iso'  ]
> # Network configuration
> vif = ['bridge=br0']
> # DomU settings
>
> memory = 512
>
> name = "alpine-a1"
>
> vcpus = 1
>
> maxvcpus = 1
> ================================================
>
> thanks a lot in advance
> Best regards
> Marco
>

--00000000000023b72c05dd13d258
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><p class=3D"MsoNormal">Hi=C2=A0 all,<u></u><u></u></p><div=
><p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p></div><div><p class=3D"MsoN=
ormal">I did several attempts but I have always problems with disk backend =
setup during creation of domU domain.<u></u><u></u></p></div><div><p class=
=3D"MsoNormal"><u></u>=C2=A0<u></u></p></div><div><p class=3D"MsoNormal">Th=
e latest attempt was using deban arm64 image with this configuration:<u></u=
><u></u></p></div><div><p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p></div=
><div><p class=3D"MsoNormal">memory =3D 512<br>name =3D &quot;debian&quot;<=
br>vcpus =3D 1<br>maxvcpus =3D 1<u></u><u></u></p></div><div><p class=3D"Ms=
oNormal">kernel =3D &quot;/home/xen/vmlinuz&quot;<br>ramdisk =3D &quot;/hom=
e/xen/initrd.img&quot;<br>disk =3D [&quot;phy:/dev/loop0,xvda,rw&quot;]<br>=
extra =3D &quot;root=3D/dev/xvda rw console=3Dhvc0 earlyprintk=3Dxen&quot;<=
u></u><u></u></p></div><div><p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p>=
</div><div><p class=3D"MsoNormal">kernel and ramdisk boot up successfully a=
nd I can attach to the domU console, but when I try to define the disk back=
end with the debian rootfs the creation of the domain fails.<u></u><u></u><=
/p></div><div><p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p></div><div><p =
class=3D"MsoNormal">rootfs is attached to loop device as follow:<u></u><u><=
/u></p></div><div><p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p></div><div=
><p class=3D"MsoNormal">losetup /dev/loop0 /home/xen/rootfs.img<u></u><u></=
u></p></div><div><p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p></div><div>=
<p class=3D"MsoNormal">I attached to this mail the verbose trace of the com=
mand xl create<u></u><u></u></p></div><div><p class=3D"MsoNormal"><u></u>=
=C2=A0<u></u></p></div><div><p class=3D"MsoNormal">Thanks a lot in advance =
for any kind of help<u></u></p></div><div><p class=3D"MsoNormal">Best Regar=
ds<u></u><u></u></p></div><div><p class=3D"MsoNormal">Marco</p></div></div>=
<br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Il gio=
rno ven 15 apr 2022 alle ore 12:56 Marco Cacre &lt;<a href=3D"mailto:marco.=
cacre@gmail.com">marco.cacre@gmail.com</a>&gt; ha scritto:<br></div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi all,<br><br>=
I&#39;m facing always the same problem (described below) trying to create a=
 Xen guest domain on rockpro64 (arm64).<br><br>I have successfully built ub=
oot, xen (4.14.4) and dom0 linux kernel with xen tool stack, these two last=
 starting from buildroot (with linux kernel version 5.15.33 and xen toolsta=
ck version 4.14.4)<br><br>These are the process of Xen:<br><br>177 root =C2=
=A0 =C2=A0/usr/sbin/xenwatchdogd 30 15<br>203 root =C2=A0 =C2=A0/usr/sbin/x=
enstored --pid-file /var/run/xen/xenstored.pid<br>208 root =C2=A0 =C2=A0/us=
r/sbin/xenconsoled --pid-file=3D/var/run/xen/xenconsoled.pid<br>214 root =
=C2=A0 =C2=A0/usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 -xen-attach -na=
me dom0 -nographic -M xenpv -daemonize -monitor /dev/null -serial/dev/nul -=
parallel/dev/null -pidfile/var/run/xen/qemu-dom0.pid<br><br>and the drivers=
 loaded as a module:<br># lsmod<br>Module =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Size =C2=A0Used by =C2=A0 =C2=A0Tainted: G<b=
r>xen_netback =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A065536 =C2=A00<br>xen=
_blkback =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A049152 =C2=A00<br><br>Xen =
and dom0 Image boot up successfully, at the end:<br>=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br>&gt;xl list<br>Name =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ID =C2=A0Mem =
VCPUs State Time(s)<br>Domain-0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A00 =C2=A01024 =C2=A0 =C2=A02 =C2=A0 =C2=A0r----- =C2=A0 =C2=A04000=
.3<br><br># uname -a<br>Linux rockpro64 5.15.33 #3 SMP PREEMPT Fri Apr 15 1=
1:01:37 CEST 2022 aarch64 GNU/Linux<br>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br><br>when I try to create a domU domain=
 I have problem with disk backend, I have made several attempts trying with=
 different domU linux and I always get the following error :<br><br>=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br>Parsing =
config from ./alpine_xen_domu.config<br><br>libxl: error: libxl_aoutils.c:5=
39:async_exec_timeout: killing execution of /etc/xen/scripts/block add beca=
use of timeout<br>libxl: error: libxl_create.c:1608:domcreate_launch_dm: Do=
main 2:unable to add disk devices<br>libxl: error: libxl_aoutils.c:539:asyn=
c_exec_timeout: killing execution of /etc/xen/scripts/block remove because =
of timeout<br>libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domai=
n 2:Non-existant domain<br>libxl: error: libxl_domain.c:1136:domain_destroy=
_callback: Domain 2:Unable to destroy guest<br>libxl: error: libxl_domain.c=
:1063:domain_destroy_cb: Domain 2:Destruction of domain failed<br>=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br><br>The las=
t try was with alpine domU linux with the following config:<br>=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br><br># Alpine L=
inux PV DomU<br># Kernel paths for install<br>kernel =3D &quot;/home/xen/vm=
linuz-virt&quot;<br>ramdisk =3D &quot;/home/xen/initramfs-virt&quot;<br>ext=
ra=3D&quot;modules=3Dloop,squashfs console=3Dhvc0&quot;<br># Path to HDD an=
d iso file<br>disk =3D [ &#39;format=3Draw, vdev=3Dxvda, access=3Dw, target=
=3D/data/a1.img&#39;,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 &#39;format=3Draw, vde=
v=3Dxvdc, access=3Dr, devtype=3Dcdrom, target=3D/home/xen/alpine-virt-3.15.=
3-armv7.iso&#39; =C2=A0]<br># Network configuration =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<br>vif =3D [&#39;bridge=3Dbr0=
&#39;]<br># DomU settings =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0<br>memory =3D 512 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<br>name =3D &quot;alpine-a=
1&quot; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<br>vc=
pus =3D 1 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0<br>maxvcpus =3D 1<br>=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br><br>thanks a lot in advanc=
e<br>Best regards<font color=3D"#888888"><br>Marco</font><br></div>
</blockquote></div>

--00000000000023b72c05dd13d258--
--00000000000023b72d05dd13d25a
Content-Type: text/plain; charset="US-ASCII"; name="xl_create_trace.txt"
Content-Disposition: attachment; filename="xl_create_trace.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_l27gian60>
X-Attachment-Id: f_l27gian60

IyB4bCAtdnZ2IGNyZWF0ZSAuL2xpbnV4LmNvbmZpZyAKUGFyc2luZyBjb25maWcgZnJvbSAuL2xp
bnV4LmNvbmZpZwpsaWJ4bDogZGVidWc6IGxpYnhsX2NyZWF0ZS5jOjIwMTc6ZG9fZG9tYWluX2Ny
ZWF0ZTogYW8gMHg1NWI3ODZlMjgwOiBjcmVhdGU6IGhvdz0obmlsKSBjYWxsYmFjaz0obmlsKSBw
b2xsZXI9MHg1NWI3ODZlM2QwCmxpYnhsOiBkZXRhaWw6IGxpYnhsX2NyZWF0ZS5jOjYyMjpsaWJ4
bF9fZG9tYWluX21ha2U6IHBhc3N0aHJvdWdoOiBkaXNhYmxlZApsaWJ4bDogZGVidWc6IGxpYnhs
X2FybS5jOjcxOmxpYnhsX19hcmNoX2RvbWFpbl9wcmVwYXJlX2NvbmZpZzogQ29uZmlndXJlIHRo
ZSBkb21haW4KbGlieGw6IGRlYnVnOiBsaWJ4bF9hcm0uYzo3NDpsaWJ4bF9fYXJjaF9kb21haW5f
cHJlcGFyZV9jb25maWc6ICAtIEFsbG9jYXRlIDAgU1BJcwpsaWJ4bDogZGVidWc6IGxpYnhsX2Rl
dmljZS5jOjM3OTpsaWJ4bF9fZGV2aWNlX2Rpc2tfc2V0X2JhY2tlbmQ6IERpc2sgdmRldj14dmRh
IHNwZWMuYmFja2VuZD11bmtub3duCmxpYnhsOiBkZWJ1ZzogbGlieGxfZGV2aWNlLmM6NDEzOmxp
YnhsX19kZXZpY2VfZGlza19zZXRfYmFja2VuZDogRGlzayB2ZGV2PXh2ZGEsIHVzaW5nIGJhY2tl
bmQgcGh5CmxpYnhsOiBkZWJ1ZzogbGlieGxfY3JlYXRlLmM6MTI3OTppbml0aWF0ZV9kb21haW5f
Y3JlYXRlOiBEb21haW4gNjpydW5uaW5nIGJvb3Rsb2FkZXIKbGlieGw6IGRlYnVnOiBsaWJ4bF9i
b290bG9hZGVyLmM6MzM0OmxpYnhsX19ib290bG9hZGVyX3J1bjogRG9tYWluIDY6bm8gYm9vdGxv
YWRlciBjb25maWd1cmVkLCB1c2luZyB1c2VyIHN1cHBsaWVkIGtlcm5lbApsaWJ4bDogZGVidWc6
IGxpYnhsX2V2ZW50LmM6ODY0OmxpYnhsX19ldl94c3dhdGNoX2RlcmVnaXN0ZXI6IHdhdGNoIHc9
MHg1NWI3ODZmYTU4OiBkZXJlZ2lzdGVyIHVucmVnaXN0ZXJlZApsaWJ4bDogZGVidWc6IGxpYnhs
X3NjaGVkLmM6ODE6bGlieGxfX3NldF92Y3B1YWZmaW5pdHk6IERvbWFpbiA2Ok5ldyBzb2Z0IGFm
ZmluaXR5IGZvciB2Y3B1IDAgaGFzIHVucmVhY2hhYmxlIGNwdXMKZG9tYWluYnVpbGRlcjogZGV0
YWlsOiB4Y19kb21fYWxsb2NhdGU6IGNtZGxpbmU9InJvb3Q9L2Rldi94dmRhIHJ3IGNvbnNvbGU9
aHZjMCBlYXJseXByaW50az14ZW4iLCBmZWF0dXJlcz0iIgpkb21haW5idWlsZGVyOiBkZXRhaWw6
IHhjX2RvbV9rZXJuZWxfZmlsZTogZmlsZW5hbWU9Ii9ob21lL3hlbi92bWxpbnV6Igpkb21haW5i
dWlsZGVyOiBkZXRhaWw6IHhjX2RvbV9tYWxsb2NfZmlsZW1hcCAgICA6IDI2ODg5IGtCCmRvbWFp
bmJ1aWxkZXI6IGRldGFpbDogeGNfZG9tX21vZHVsZV9maWxlOiBmaWxlbmFtZT0iL2hvbWUveGVu
L2luaXRyZC5pbWciCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogeGNfZG9tX21hbGxvY19maWxlbWFw
ICAgIDogNDAgTUIKZG9tYWluYnVpbGRlcjogZGV0YWlsOiB4Y19kb21fYm9vdF94ZW5faW5pdDog
dmVyIDQuMTQsIGNhcHMgeGVuLTMuMC1hYXJjaDY0IHhlbi0zLjAtYXJtdjdsIApkb21haW5idWls
ZGVyOiBkZXRhaWw6IHhjX2RvbV9yYW1iYXNlX2luaXQ6IFJBTSBzdGFydHMgYXQgNDAwMDAKZG9t
YWluYnVpbGRlcjogZGV0YWlsOiB4Y19kb21fcGFyc2VfaW1hZ2U6IGNhbGxlZApkb21haW5idWls
ZGVyOiBkZXRhaWw6IHhjX2RvbV9maW5kX2xvYWRlcjogdHJ5aW5nIG11bHRpYm9vdC1iaW5hcnkg
bG9hZGVyIC4uLiAKZG9tYWluYnVpbGRlcjogZGV0YWlsOiBsb2FkZXIgcHJvYmUgZmFpbGVkCmRv
bWFpbmJ1aWxkZXI6IGRldGFpbDogeGNfZG9tX2ZpbmRfbG9hZGVyOiB0cnlpbmcgTGludXggeklt
YWdlIChBUk02NCkgbG9hZGVyIC4uLiAKZG9tYWluYnVpbGRlcjogZGV0YWlsOiBsb2FkZXIgcHJv
YmUgT0sKZG9tYWluYnVpbGRlcjogZGV0YWlsOiB4Y19kb21fcGFyc2VfemltYWdlNjRfa2VybmVs
OiBjYWxsZWQKZG9tYWluYnVpbGRlcjogZGV0YWlsOiB4Y19kb21fcGFyc2VfemltYWdlNjRfa2Vy
bmVsOiB4ZW4tMy4wLWFhcmNoNjQ6IDB4NDAwMDAwMDAgLT4gMHg0MWE0Mjc4MApsaWJ4bDogZGVi
dWc6IGxpYnhsX2FybS5jOjg3MjpsaWJ4bF9fcHJlcGFyZV9kdGI6IGNvbnN0cnVjdGluZyBEVEIg
Zm9yIFhlbiB2ZXJzaW9uIDQuMTQgZ3Vlc3QKbGlieGw6IGRlYnVnOiBsaWJ4bF9hcm0uYzo4NzQ6
bGlieGxfX3ByZXBhcmVfZHRiOiAgLSB2R0lDIHZlcnNpb246IFYzCmxpYnhsOiBkZWJ1ZzogbGli
eGxfYXJtLmM6MzEyOm1ha2VfY2hvc2VuX25vZGU6IC9jaG9zZW4vYm9vdGFyZ3MgPSByb290PS9k
ZXYveHZkYSBydyBjb25zb2xlPWh2YzAgZWFybHlwcmludGs9eGVuCmxpYnhsOiBkZWJ1ZzogbGli
eGxfYXJtLmM6MzE5Om1ha2VfY2hvc2VuX25vZGU6IC9jaG9zZW4gYWRkaW5nIHBsYWNlaG9sZGVy
IGxpbnV4LGluaXRyZCBwcm9wZXJ0aWVzCmxpYnhsOiBkZWJ1ZzogbGlieGxfYXJtLmM6NDU5Om1h
a2VfbWVtb3J5X25vZGVzOiBDcmVhdGluZyBwbGFjZWhvbGRlciBub2RlIC9tZW1vcnlANDAwMDAw
MDAKbGlieGw6IGRlYnVnOiBsaWJ4bF9hcm0uYzo0NTk6bWFrZV9tZW1vcnlfbm9kZXM6IENyZWF0
aW5nIHBsYWNlaG9sZGVyIG5vZGUgL21lbW9yeUAyMDAwMDAwMDAKbGlieGw6IGRlYnVnOiBsaWJ4
bF9hcm0uYzo5NzU6bGlieGxfX3ByZXBhcmVfZHRiOiBmZHQgdG90YWwgc2l6ZSAxMzM4CmRvbWFp
bmJ1aWxkZXI6IGRldGFpbDogeGNfZG9tX2RldmljZXRyZWVfbWVtOiBjYWxsZWQKbGlieGw6IGRl
YnVnOiBsaWJ4bF9hcm0uYzoxMDIwOmxpYnhsX19hcmNoX2RvbWFpbl9pbml0X2h3X2Rlc2NyaXB0
aW9uOiBHZW5lcmF0aW5nIEFDUEkgdGFibGVzIGlzIGRpc2FibGVkIGJ5IHVzZXIuCmRvbWFpbmJ1
aWxkZXI6IGRldGFpbDogeGNfZG9tX21lbV9pbml0OiBtZW0gNTEyIE1CLCBwYWdlcyAweDIwMDAw
IHBhZ2VzLCA0ayBlYWNoCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogeGNfZG9tX21lbV9pbml0OiAw
eDIwMDAwIHBhZ2VzCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogeGNfZG9tX2Jvb3RfbWVtX2luaXQ6
IGNhbGxlZApkb21haW5idWlsZGVyOiBkZXRhaWw6IHNldF9tb2RlOiBndWVzdCB4ZW4tMy4wLWFh
cmNoNjQsIGFkZHJlc3Mgc2l6ZSA2NApkb21haW5idWlsZGVyOiBkZXRhaWw6IHBvcHVsYXRlX2d1
ZXN0X21lbW9yeTogcG9wdWxhdGluZyBSQU0gQCAwMDAwMDAwMDQwMDAwMDAwLTAwMDAwMDAwNjAw
MDAwMDAgKDUxMk1CKQpkb21haW5idWlsZGVyOiBkZXRhaWw6IHBvcHVsYXRlX29uZV9zaXplOiBw
b3B1bGF0ZWQgMHgxMDAvMHgxMDAgZW50cmllcyB3aXRoIHNoaWZ0IDkKZG9tYWluYnVpbGRlcjog
ZGV0YWlsOiBtZW1pbml0OiBwbGFjaW5nIGJvb3QgbW9kdWxlcyBhdCAweDQ4MDAwMDAwCmRvbWFp
bmJ1aWxkZXI6IGRldGFpbDogbWVtaW5pdDogcmFtZGlzazogMHg0ODAwMDAwMCAtPiAweDRhODFm
MDAwCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogbWVtaW5pdDogZGV2aWNldHJlZTogMHg0YTgxZjAw
MCAtPiAweDRhODIwMDAwCmxpYnhsOiBkZWJ1ZzogbGlieGxfYXJtLmM6MTA4NzpsaWJ4bF9fYXJj
aF9kb21haW5fZmluYWxpc2VfaHdfZGVzY3JpcHRpb246IC9jaG9zZW4gdXBkYXRpbmcgaW5pdHJk
IHByb3BlcnRpZXMgdG8gY292ZXIgNDgwMDAwMDAtNGE4MWYwMDAKbGlieGw6IGRlYnVnOiBsaWJ4
bF9hcm0uYzoxMDU0OmZpbmFsaXNlX29uZV9ub2RlOiBQb3B1bGF0aW5nIHBsYWNlaG9sZGVyIG5v
ZGUgL21lbW9yeUA0MDAwMDAwMApsaWJ4bDogZGVidWc6IGxpYnhsX2FybS5jOjEwNDg6ZmluYWxp
c2Vfb25lX25vZGU6IE5vcHBpbmcgb3V0IHBsYWNlaG9sZGVyIG5vZGUgL21lbW9yeUAyMDAwMDAw
MDAKZG9tYWluYnVpbGRlcjogZGV0YWlsOiB4Y19kb21fYnVpbGRfaW1hZ2U6IGNhbGxlZApkb21h
aW5idWlsZGVyOiBkZXRhaWw6IHhjX2RvbV9tYWxsb2MgICAgICAgICAgICA6IDE1NyBrQgpkb21h
aW5idWlsZGVyOiBkZXRhaWw6IHhjX2RvbV9wZm5fdG9fcHRyX3JldGNvdW50OiBkb21VIG1hcHBp
bmc6IHBmbiAweDQwMDAwKzB4MWE0MyBhdCAweDdmYTA3M2MwMDAKZG9tYWluYnVpbGRlcjogZGV0
YWlsOiB4Y19kb21fYWxsb2Nfc2VnbWVudDogICBrZXJuZWwgICAgICAgOiAweDQwMDAwMDAwIC0+
IDB4NDFhNDMwMDAgIChwZm4gMHg0MDAwMCArIDB4MWE0MyBwYWdlcykKZG9tYWluYnVpbGRlcjog
ZGV0YWlsOiB4Y19kb21fbG9hZF96aW1hZ2Vfa2VybmVsOiBjYWxsZWQKZG9tYWluYnVpbGRlcjog
ZGV0YWlsOiB4Y19kb21fbG9hZF96aW1hZ2Vfa2VybmVsOiBrZXJuZWwgc2VnIDB4NDAwMDAwMDAt
MHg0MWE0MzAwMApkb21haW5idWlsZGVyOiBkZXRhaWw6IHhjX2RvbV9sb2FkX3ppbWFnZV9rZXJu
ZWw6IGNvcHkgMjc1MzUyMzIgYnl0ZXMgZnJvbSBibG9iIDB4N2ZhNDk5ZTAwMCB0byBkc3QgMHg3
ZmEwNzNjMDAwCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogeGNfZG9tX21hbGxvYyAgICAgICAgICAg
IDogMjQwIGtCCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogeGNfZG9tX3Bmbl90b19wdHJfcmV0Y291
bnQ6IGRvbVUgbWFwcGluZzogcGZuIDB4NDgwMDArMHgyODFmIGF0IDB4N2Y5ZGYxZDAwMApkb21h
aW5idWlsZGVyOiBkZXRhaWw6IHhjX2RvbV9hbGxvY19zZWdtZW50OiAgIG1vZHVsZTAgICAgICA6
IDB4NDgwMDAwMDAgLT4gMHg0YTgxZjAwMCAgKHBmbiAweDQ4MDAwICsgMHgyODFmIHBhZ2VzKQpk
b21haW5idWlsZGVyOiBkZXRhaWw6IHhjX2RvbV9wZm5fdG9fcHRyX3JldGNvdW50OiBkb21VIG1h
cHBpbmc6IHBmbiAweDRhODFmKzB4MSBhdCAweDdmYTY3MTUwMDAKZG9tYWluYnVpbGRlcjogZGV0
YWlsOiB4Y19kb21fYWxsb2Nfc2VnbWVudDogICBkZXZpY2V0cmVlICAgOiAweDRhODFmMDAwIC0+
IDB4NGE4MjAwMDAgIChwZm4gMHg0YTgxZiArIDB4MSBwYWdlcykKZG9tYWluYnVpbGRlcjogZGV0
YWlsOiBhbGxvY19tYWdpY19wYWdlczogY2FsbGVkCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogeGNf
ZG9tX2J1aWxkX2ltYWdlICA6IHZpcnRfYWxsb2NfZW5kIDogMHg0YTgyMDAwMApkb21haW5idWls
ZGVyOiBkZXRhaWw6IHhjX2RvbV9idWlsZF9pbWFnZSAgOiB2aXJ0X3BndGFiX2VuZCA6IDB4MApk
b21haW5idWlsZGVyOiBkZXRhaWw6IHhjX2RvbV9ib290X2ltYWdlOiBjYWxsZWQKZG9tYWluYnVp
bGRlcjogZGV0YWlsOiBib290ZWFybHk6IGRvaW5nIG5vdGhpbmcKZG9tYWluYnVpbGRlcjogZGV0
YWlsOiB4Y19kb21fY29tcGF0X2NoZWNrOiBzdXBwb3J0ZWQgZ3Vlc3QgdHlwZTogeGVuLTMuMC1h
YXJjaDY0IDw9IG1hdGNoZXMKZG9tYWluYnVpbGRlcjogZGV0YWlsOiB4Y19kb21fY29tcGF0X2No
ZWNrOiBzdXBwb3J0ZWQgZ3Vlc3QgdHlwZTogeGVuLTMuMC1hcm12N2wKZG9tYWluYnVpbGRlcjog
ZGV0YWlsOiBzdGFydF9pbmZvX2FybTogY2FsbGVkCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogZG9t
YWluIGJ1aWxkZXIgbWVtb3J5IGZvb3RwcmludApkb21haW5idWlsZGVyOiBkZXRhaWw6ICAgIGFs
bG9jYXRlZApkb21haW5idWlsZGVyOiBkZXRhaWw6ICAgICAgIG1hbGxvYyAgICAgICAgICAgICA6
IDQwMSBrQgpkb21haW5idWlsZGVyOiBkZXRhaWw6ICAgICAgIGFub24gbW1hcCAgICAgICAgICA6
IDAgYnl0ZXMKZG9tYWluYnVpbGRlcjogZGV0YWlsOiAgICBtYXBwZWQKZG9tYWluYnVpbGRlcjog
ZGV0YWlsOiAgICAgICBmaWxlIG1tYXAgICAgICAgICAgOiA2NiBNQgpkb21haW5idWlsZGVyOiBk
ZXRhaWw6ICAgICAgIGRvbVUgbW1hcCAgICAgICAgICA6IDY2IE1CCmRvbWFpbmJ1aWxkZXI6IGRl
dGFpbDogdmNwdV9hcm02NDogY2FsbGVkCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogRFRCIDRhODFm
MDAwCmRvbWFpbmJ1aWxkZXI6IGRldGFpbDogSW5pdGlhbCBzdGF0ZSBDUFNSIDB4MWM1IFBDIDB4
NDAwMDAwMDAKZG9tYWluYnVpbGRlcjogZGV0YWlsOiBjb21wYXRfZ250dGFiX2h2bV9zZWVkOiBk
NjogcGZuPTB4MzgwMDAKZG9tYWluYnVpbGRlcjogZGV0YWlsOiB4Y19kb21fc2V0X2dudHRhYl9l
bnRyeTogZDYgZ250WzBdIC0+IGQwIDB4MzkwMDAKZG9tYWluYnVpbGRlcjogZGV0YWlsOiB4Y19k
b21fc2V0X2dudHRhYl9lbnRyeTogZDYgZ250WzFdIC0+IGQwIDB4MzkwMDEKZG9tYWluYnVpbGRl
cjogZGV0YWlsOiB4Y19kb21fcmVsZWFzZTogY2FsbGVkCmxpYnhsOiBkZWJ1ZzogbGlieGxfZGV2
aWNlLmM6Mzc5OmxpYnhsX19kZXZpY2VfZGlza19zZXRfYmFja2VuZDogRGlzayB2ZGV2PXh2ZGEg
c3BlYy5iYWNrZW5kPXBoeQpsaWJ4bDogZGVidWc6IGxpYnhsX2V2ZW50LmM6ODEzOmxpYnhsX19l
dl94c3dhdGNoX3JlZ2lzdGVyOiB3YXRjaCB3PTB4NTViNzg3NDA1MCB3cGF0aD0vbG9jYWwvZG9t
YWluLzAvYmFja2VuZC92YmQvNi81MTcxMi9zdGF0ZSB0b2tlbj0zLzA6IHJlZ2lzdGVyIHNsb3Ru
dW09MwpsaWJ4bDogZGVidWc6IGxpYnhsX2NyZWF0ZS5jOjIwNTU6ZG9fZG9tYWluX2NyZWF0ZTog
YW8gMHg1NWI3ODZlMjgwOiBpbnByb2dyZXNzOiBwb2xsZXI9MHg1NWI3ODZlM2QwLCBmbGFncz1p
CmxpYnhsOiBkZWJ1ZzogbGlieGxfZXZlbnQuYzo3NTA6d2F0Y2hmZF9jYWxsYmFjazogd2F0Y2gg
dz0weDU1Yjc4NzQwNTAgd3BhdGg9L2xvY2FsL2RvbWFpbi8wL2JhY2tlbmQvdmJkLzYvNTE3MTIv
c3RhdGUgdG9rZW49My8wOiBldmVudCBlcGF0aD0vbG9jYWwvZG9tYWluLzAvYmFja2VuZC92YmQv
Ni81MTcxMi9zdGF0ZQpsaWJ4bDogZGVidWc6IGxpYnhsX2V2ZW50LmM6MTA1MjpkZXZzdGF0ZV9j
YWxsYmFjazogYmFja2VuZCAvbG9jYWwvZG9tYWluLzAvYmFja2VuZC92YmQvNi81MTcxMi9zdGF0
ZSB3YW50ZWQgc3RhdGUgMiBvawpsaWJ4bDogZGVidWc6IGxpYnhsX2V2ZW50LmM6ODUwOmxpYnhs
X19ldl94c3dhdGNoX2RlcmVnaXN0ZXI6IHdhdGNoIHc9MHg1NWI3ODc0MDUwIHdwYXRoPS9sb2Nh
bC9kb21haW4vMC9iYWNrZW5kL3ZiZC82LzUxNzEyL3N0YXRlIHRva2VuPTMvMDogZGVyZWdpc3Rl
ciBzbG90bnVtPTMKbGlieGw6IGRlYnVnOiBsaWJ4bF9kZXZpY2UuYzoxMDkwOmRldmljZV9iYWNr
ZW5kX2NhbGxiYWNrOiBEb21haW4gNjpjYWxsaW5nIGRldmljZV9iYWNrZW5kX2NsZWFudXAKbGli
eGw6IGRlYnVnOiBsaWJ4bF9ldmVudC5jOjg2NDpsaWJ4bF9fZXZfeHN3YXRjaF9kZXJlZ2lzdGVy
OiB3YXRjaCB3PTB4NTViNzg3NDA1MDogZGVyZWdpc3RlciB1bnJlZ2lzdGVyZWQKbGlieGw6IGRl
YnVnOiBsaWJ4bF9saW51eC5jOjE5NDpsaWJ4bF9faG90cGx1Z19kaXNrOiBEb21haW4gNjpBcmdz
IGFuZCBlbnZpcm9ubWVudCByZWFkeQpsaWJ4bDogZGVidWc6IGxpYnhsX2RldmljZS5jOjExOTE6
ZGV2aWNlX2hvdHBsdWc6IERvbWFpbiA2OmNhbGxpbmcgaG90cGx1ZyBzY3JpcHQ6IC9ldGMveGVu
L3NjcmlwdHMvYmxvY2sgYWRkCmxpYnhsOiBkZWJ1ZzogbGlieGxfZGV2aWNlLmM6MTE5MjpkZXZp
Y2VfaG90cGx1ZzogRG9tYWluIDY6ZXh0cmEgYXJnczoKbGlieGw6IGRlYnVnOiBsaWJ4bF9kZXZp
Y2UuYzoxMjAwOmRldmljZV9ob3RwbHVnOiBEb21haW4gNjplbnY6CmxpYnhsOiBkZWJ1ZzogbGli
eGxfZGV2aWNlLmM6MTIwNzpkZXZpY2VfaG90cGx1ZzogRG9tYWluIDY6CXNjcmlwdDogL2V0Yy94
ZW4vc2NyaXB0cy9ibG9jawpsaWJ4bDogZGVidWc6IGxpYnhsX2RldmljZS5jOjEyMDc6ZGV2aWNl
X2hvdHBsdWc6IERvbWFpbiA2OglYRU5CVVNfVFlQRTogdmJkCmxpYnhsOiBkZWJ1ZzogbGlieGxf
ZGV2aWNlLmM6MTIwNzpkZXZpY2VfaG90cGx1ZzogRG9tYWluIDY6CVhFTkJVU19QQVRIOiBiYWNr
ZW5kL3ZiZC82LzUxNzEyCmxpYnhsOiBkZWJ1ZzogbGlieGxfZGV2aWNlLmM6MTIwNzpkZXZpY2Vf
aG90cGx1ZzogRG9tYWluIDY6CVhFTkJVU19CQVNFX1BBVEg6IGJhY2tlbmQKbGlieGw6IGRlYnVn
OiBsaWJ4bF9hb3V0aWxzLmM6NTkzOmxpYnhsX19hc3luY19leGVjX3N0YXJ0OiBmb3JraW5nIHRv
IGV4ZWN1dGU6IC9ldGMveGVuL3NjcmlwdHMvYmxvY2sgYWRkIApsaWJ4bDogZGVidWc6IGxpYnhs
X2V2ZW50LmM6NzIwOndhdGNoZmRfY2FsbGJhY2s6IHdhdGNoIGVwYXRoPS9sb2NhbC9kb21haW4v
MC9iYWNrZW5kL3ZiZC82LzUxNzEyL3N0YXRlIHRva2VuPTMvMDogZW1wdHkgc2xvdApsaWJ4bDog
ZXJyb3I6IGxpYnhsX2FvdXRpbHMuYzo1Mzk6YXN5bmNfZXhlY190aW1lb3V0OiBraWxsaW5nIGV4
ZWN1dGlvbiBvZiAvZXRjL3hlbi9zY3JpcHRzL2Jsb2NrIGFkZCBiZWNhdXNlIG9mIHRpbWVvdXQK
bGlieGw6IGRlYnVnOiBsaWJ4bF9ldmVudC5jOjg2NDpsaWJ4bF9fZXZfeHN3YXRjaF9kZXJlZ2lz
dGVyOiB3YXRjaCB3PTB4NTViNzg3NDE1MDogZGVyZWdpc3RlciB1bnJlZ2lzdGVyZWQKbGlieGw6
IGRlYnVnOiBsaWJ4bF9ldmVudC5jOjg2NDpsaWJ4bF9fZXZfeHN3YXRjaF9kZXJlZ2lzdGVyOiB3
YXRjaCB3PTB4NTViNzg3NDE1MDogZGVyZWdpc3RlciB1bnJlZ2lzdGVyZWQKbGlieGw6IGVycm9y
OiBsaWJ4bF9jcmVhdGUuYzoxNjA4OmRvbWNyZWF0ZV9sYXVuY2hfZG06IERvbWFpbiA2OnVuYWJs
ZSB0byBhZGQgZGlzayBkZXZpY2VzCmxpYnhsOiBkZWJ1ZzogbGlieGxfZXZlbnQuYzo4NjQ6bGli
eGxfX2V2X3hzd2F0Y2hfZGVyZWdpc3Rlcjogd2F0Y2ggdz0weDU1Yjc4NzE0MDg6IGRlcmVnaXN0
ZXIgdW5yZWdpc3RlcmVkCmxpYnhsOiBkZWJ1ZzogbGlieGxfZXZlbnQuYzo4MTM6bGlieGxfX2V2
X3hzd2F0Y2hfcmVnaXN0ZXI6IHdhdGNoIHc9MHg1NWI3ODcyMTAwIHdwYXRoPS9sb2NhbC9kb21h
aW4vMC9iYWNrZW5kL3ZiZC82LzUxNzEyL3N0YXRlIHRva2VuPTMvMTogcmVnaXN0ZXIgc2xvdG51
bT0zCmxpYnhsOiBkZWJ1ZzogbGlieGxfZXZlbnQuYzo3NTA6d2F0Y2hmZF9jYWxsYmFjazogd2F0
Y2ggdz0weDU1Yjc4NzIxMDAgd3BhdGg9L2xvY2FsL2RvbWFpbi8wL2JhY2tlbmQvdmJkLzYvNTE3
MTIvc3RhdGUgdG9rZW49My8xOiBldmVudCBlcGF0aD0vbG9jYWwvZG9tYWluLzAvYmFja2VuZC92
YmQvNi81MTcxMi9zdGF0ZQpsaWJ4bDogZGVidWc6IGxpYnhsX2V2ZW50LmM6MTA1MjpkZXZzdGF0
ZV9jYWxsYmFjazogYmFja2VuZCAvbG9jYWwvZG9tYWluLzAvYmFja2VuZC92YmQvNi81MTcxMi9z
dGF0ZSB3YW50ZWQgc3RhdGUgNiBvawpsaWJ4bDogZGVidWc6IGxpYnhsX2V2ZW50LmM6ODUwOmxp
YnhsX19ldl94c3dhdGNoX2RlcmVnaXN0ZXI6IHdhdGNoIHc9MHg1NWI3ODcyMTAwIHdwYXRoPS9s
b2NhbC9kb21haW4vMC9iYWNrZW5kL3ZiZC82LzUxNzEyL3N0YXRlIHRva2VuPTMvMTogZGVyZWdp
c3RlciBzbG90bnVtPTMKbGlieGw6IGRlYnVnOiBsaWJ4bF9kZXZpY2UuYzoxMDkwOmRldmljZV9i
YWNrZW5kX2NhbGxiYWNrOiBEb21haW4gNjpjYWxsaW5nIGRldmljZV9iYWNrZW5kX2NsZWFudXAK
bGlieGw6IGRlYnVnOiBsaWJ4bF9ldmVudC5jOjg2NDpsaWJ4bF9fZXZfeHN3YXRjaF9kZXJlZ2lz
dGVyOiB3YXRjaCB3PTB4NTViNzg3MjEwMDogZGVyZWdpc3RlciB1bnJlZ2lzdGVyZWQKbGlieGw6
IGRlYnVnOiBsaWJ4bF9saW51eC5jOjE5NDpsaWJ4bF9faG90cGx1Z19kaXNrOiBEb21haW4gNjpB
cmdzIGFuZCBlbnZpcm9ubWVudCByZWFkeQpsaWJ4bDogZGVidWc6IGxpYnhsX2RldmljZS5jOjEx
OTE6ZGV2aWNlX2hvdHBsdWc6IERvbWFpbiA2OmNhbGxpbmcgaG90cGx1ZyBzY3JpcHQ6IC9ldGMv
eGVuL3NjcmlwdHMvYmxvY2sgcmVtb3ZlCmxpYnhsOiBkZWJ1ZzogbGlieGxfZGV2aWNlLmM6MTE5
MjpkZXZpY2VfaG90cGx1ZzogRG9tYWluIDY6ZXh0cmEgYXJnczoKbGlieGw6IGRlYnVnOiBsaWJ4
bF9kZXZpY2UuYzoxMjAwOmRldmljZV9ob3RwbHVnOiBEb21haW4gNjplbnY6CmxpYnhsOiBkZWJ1
ZzogbGlieGxfZGV2aWNlLmM6MTIwNzpkZXZpY2VfaG90cGx1ZzogRG9tYWluIDY6CXNjcmlwdDog
L2V0Yy94ZW4vc2NyaXB0cy9ibG9jawpsaWJ4bDogZGVidWc6IGxpYnhsX2RldmljZS5jOjEyMDc6
ZGV2aWNlX2hvdHBsdWc6IERvbWFpbiA2OglYRU5CVVNfVFlQRTogdmJkCmxpYnhsOiBkZWJ1Zzog
bGlieGxfZGV2aWNlLmM6MTIwNzpkZXZpY2VfaG90cGx1ZzogRG9tYWluIDY6CVhFTkJVU19QQVRI
OiBiYWNrZW5kL3ZiZC82LzUxNzEyCmxpYnhsOiBkZWJ1ZzogbGlieGxfZGV2aWNlLmM6MTIwNzpk
ZXZpY2VfaG90cGx1ZzogRG9tYWluIDY6CVhFTkJVU19CQVNFX1BBVEg6IGJhY2tlbmQKbGlieGw6
IGRlYnVnOiBsaWJ4bF9hb3V0aWxzLmM6NTkzOmxpYnhsX19hc3luY19leGVjX3N0YXJ0OiBmb3Jr
aW5nIHRvIGV4ZWN1dGU6IC9ldGMveGVuL3NjcmlwdHMvYmxvY2sgcmVtb3ZlIApsaWJ4bDogZGVi
dWc6IGxpYnhsX2V2ZW50LmM6ODY0OmxpYnhsX19ldl94c3dhdGNoX2RlcmVnaXN0ZXI6IHdhdGNo
IHc9MHg1NWI3ODcyMjAwOiBkZXJlZ2lzdGVyIHVucmVnaXN0ZXJlZApsaWJ4bDogZGVidWc6IGxp
YnhsX2xpbnV4LmM6MjExOmxpYnhsX19nZXRfaG90cGx1Z19zY3JpcHRfaW5mbzogRG9tYWluIDY6
bnVtX2V4ZWMgMSwgbm90IHJ1bm5pbmcgaG90cGx1ZyBzY3JpcHRzCmxpYnhsOiBkZWJ1ZzogbGli
eGxfZGV2aWNlLmM6MTE3NjpkZXZpY2VfaG90cGx1ZzogRG9tYWluIDY6Tm8gaG90cGx1ZyBzY3Jp
cHQgdG8gZXhlY3V0ZQpsaWJ4bDogZGVidWc6IGxpYnhsX2V2ZW50LmM6ODY0OmxpYnhsX19ldl94
c3dhdGNoX2RlcmVnaXN0ZXI6IHdhdGNoIHc9MHg1NWI3ODcyMjAwOiBkZXJlZ2lzdGVyIHVucmVn
aXN0ZXJlZApsaWJ4bDogZGVidWc6IGxpYnhsX2RvbWFpbi5jOjE1OTY6ZGV2aWNlc19kZXN0cm95
X2NiOiBEb21haW4gNjpGb3JrZWQgcGlkIDI0MTQ1IGZvciBkZXN0cm95IG9mIGRvbWFpbgpsaWJ4
bDogZGVidWc6IGxpYnhsX2V2ZW50LmM6MjA2NjpsaWJ4bF9fYW9fY29tcGxldGU6IGFvIDB4NTVi
Nzg2ZTI4MDogY29tcGxldGUsIHJjPS0zCmxpYnhsOiBkZWJ1ZzogbGlieGxfZXZlbnQuYzoyMDM1
OmxpYnhsX19hb19fZGVzdHJveTogYW8gMHg1NWI3ODZlMjgwOiBkZXN0cm95CmxpYnhsOiBkZWJ1
ZzogbGlieGxfZG9tYWluLmM6MTA0NTpsaWJ4bF9kb21haW5fZGVzdHJveTogRG9tYWluIDY6YW8g
MHg1NWI3ODZlMjgwOiBjcmVhdGU6IGhvdz0obmlsKSBjYWxsYmFjaz0obmlsKSBwb2xsZXI9MHg1
NWI3ODZlM2QwCmxpYnhsOiBlcnJvcjogbGlieGxfZG9tYWluLmM6MTE4MjpsaWJ4bF9fZGVzdHJv
eV9kb21pZDogRG9tYWluIDY6Tm9uLWV4aXN0YW50IGRvbWFpbgpsaWJ4bDogZXJyb3I6IGxpYnhs
X2RvbWFpbi5jOjExMzY6ZG9tYWluX2Rlc3Ryb3lfY2FsbGJhY2s6IERvbWFpbiA2OlVuYWJsZSB0
byBkZXN0cm95IGd1ZXN0CmxpYnhsOiBlcnJvcjogbGlieGxfZG9tYWluLmM6MTA2Mzpkb21haW5f
ZGVzdHJveV9jYjogRG9tYWluIDY6RGVzdHJ1Y3Rpb24gb2YgZG9tYWluIGZhaWxlZApsaWJ4bDog
ZGVidWc6IGxpYnhsX2V2ZW50LmM6MjA2NjpsaWJ4bF9fYW9fY29tcGxldGU6IGFvIDB4NTViNzg2
ZTI4MDogY29tcGxldGUsIHJjPS0yMQpsaWJ4bDogZGVidWc6IGxpYnhsX2RvbWFpbi5jOjEwNTQ6
bGlieGxfZG9tYWluX2Rlc3Ryb3k6IERvbWFpbiA2OmFvIDB4NTViNzg2ZTI4MDogaW5wcm9ncmVz
czogcG9sbGVyPTB4NTViNzg2ZTNkMCwgZmxhZ3M9aWMKbGlieGw6IGRlYnVnOiBsaWJ4bF9ldmVu
dC5jOjIwMzU6bGlieGxfX2FvX19kZXN0cm95OiBhbyAweDU1Yjc4NmUyODA6IGRlc3Ryb3kKeGVu
Y2FsbDpidWZmZXI6IGRlYnVnOiB0b3RhbCBhbGxvY2F0aW9uczoxMTcgdG90YWwgcmVsZWFzZXM6
MTE3CnhlbmNhbGw6YnVmZmVyOiBkZWJ1ZzogY3VycmVudCBhbGxvY2F0aW9uczowIG1heGltdW0g
YWxsb2NhdGlvbnM6Mwp4ZW5jYWxsOmJ1ZmZlcjogZGVidWc6IGNhY2hlIGN1cnJlbnQgc2l6ZToz
CnhlbmNhbGw6YnVmZmVyOiBkZWJ1ZzogY2FjaGUgaGl0czoxMDIgbWlzc2VzOjMgdG9vYmlnOjEy
CnhlbmNhbGw6YnVmZmVyOiBkZWJ1ZzogdG90YWwgYWxsb2NhdGlvbnM6MCB0b3RhbCByZWxlYXNl
czowCnhlbmNhbGw6YnVmZmVyOiBkZWJ1ZzogY3VycmVudCBhbGxvY2F0aW9uczowIG1heGltdW0g
YWxsb2NhdGlvbnM6MAp4ZW5jYWxsOmJ1ZmZlcjogZGVidWc6IGNhY2hlIGN1cnJlbnQgc2l6ZTow
CnhlbmNhbGw6YnVmZmVyOiBkZWJ1ZzogY2FjaGUgaGl0czowIG1pc3NlczowIHRvb2JpZzowCg==
--00000000000023b72d05dd13d25a--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 11:07:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 11:07:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309133.525166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh8Ai-0003Jf-IK; Wed, 20 Apr 2022 11:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309133.525166; Wed, 20 Apr 2022 11:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh8Ai-0003JY-BS; Wed, 20 Apr 2022 11:06:56 +0000
Received: by outflank-mailman (input) for mailman id 309133;
 Wed, 20 Apr 2022 11:05:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8Us=U6=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nh89M-0003Gn-7v
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 11:05:35 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2060f.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::60f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c90a58f8-c099-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 13:05:29 +0200 (CEST)
Received: from AS8PR04CA0206.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::31)
 by DB8PR08MB5308.eurprd08.prod.outlook.com (2603:10a6:10:f9::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 11:05:24 +0000
Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2f3:cafe::68) by AS8PR04CA0206.outlook.office365.com
 (2603:10a6:20b:2f3::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Wed, 20 Apr 2022 11:05:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Wed, 20 Apr 2022 11:05:23 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Wed, 20 Apr 2022 11:05:22 +0000
Received: from 927d255294fa.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F5F6AA2B-E88E-4418-A13C-5E47B74A6264.1; 
 Wed, 20 Apr 2022 11:05:06 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 927d255294fa.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 11:05:06 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM5PR0801MB2003.eurprd08.prod.outlook.com
 (2603:10a6:203:4a::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 11:05:02 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 11:05:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c90a58f8-c099-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jE/UQrN3nLFi42/f5EoR1coYixBmnRP5DboB675wHas=;
 b=geD9a8VtgS0PKbGfotlt0ugSFjPRfNwPankgx1zP9ywhEAr75ke2anCtjVjQZF5nNyitz2TOGE4AtyxED+8D615ZZuIS4E51CNJMup7RdH66Vl63R5jBvkQyYJ3j+JfsZY5cpMb0RZIv9X9AXy1U/OSdy5+ypaG02/AqeV+VOEU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ce9b943ad8f546be
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NtncwlQSONdbSvXMWKFZwaOt2B+tzhNcKf4MvTSIWwTH7yRauCvzEwH46d+TxI3jZbANzFJWxXg/yUczD2DbdF57U2l2bRUFyuUYVmg01wvu6rW2lRnhc6AlRXICF/KZj97gFF60BlwwaIvJRLQYd0c9SLazZTIBxsT9hJQEJL6NwGYw1LyL2TZMhzdoP9BSihGPa2Q/aFIgN4lLY9ThJY9BBdDIrYM/ij22w1zO8+5/weeBfdSOG2xq/0C8uYMUoGNiBW0C66bU51uztKUFCH9We7OIimAZr3xVG/tyr8MKSdV6P5lVuT+2CHg7gnKX2zjTb2Oy6xVoKmdyitW6Dw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jE/UQrN3nLFi42/f5EoR1coYixBmnRP5DboB675wHas=;
 b=JUZG7IKVXY4owmuFvN5VaYoTrOKTNFbKQWLBvsqgeak63Kd3mDLrp8g+sqwWqNVDzyxV7qQoxUsQtWXPhTtk2gNMoYcBGmaAtec+w/z+jfzX9mNSkrs58UN6M7rQxGHy21FHp5+KEGuqaO7J5nB0VejJE9GfrW+MjxU9/6qNiit9TeBpy0HDGCGMSb6atelhgqhPbdUF+rxGOHq/PPHuSo4jrw7TNS12ecsLllN/UqR9/kfC/U7MEGjoPFh76xW6b02LM+GKJ50vaGaKdCRs3ULDNrInUXYpQ1E4k0ITfpmp8HVjFD0PkSh68PB11dsbUckIQwkwo7A21Iqeqv82gg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jE/UQrN3nLFi42/f5EoR1coYixBmnRP5DboB675wHas=;
 b=geD9a8VtgS0PKbGfotlt0ugSFjPRfNwPankgx1zP9ywhEAr75ke2anCtjVjQZF5nNyitz2TOGE4AtyxED+8D615ZZuIS4E51CNJMup7RdH66Vl63R5jBvkQyYJ3j+JfsZY5cpMb0RZIv9X9AXy1U/OSdy5+ypaG02/AqeV+VOEU=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Christoph Hellwig <hch@lst.de>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Jan Beulich
	<jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Topic: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Index:
 AQHYTzcUggEUWxM2006iot1qnYxlIKzuW0oAgAFU1ACAADDmgIAApv+AgAC5dQCAAp7ugIACQDIAgAEmAYCAANnhAIAAjguA
Date: Wed, 20 Apr 2022 11:05:02 +0000
Message-ID: <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com>
 <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop>
 <8C511888-6183-421E-A4C7-B271DAF46696@arm.com>
 <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de>
 <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
 <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
 <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
 <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: a736d5b5-4797-4dea-e2d1-08da22bdaac6
x-ms-traffictypediagnostic:
	AM5PR0801MB2003:EE_|VE1EUR03FT014:EE_|DB8PR08MB5308:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB5308B834525DE9D44E5AC7BDFCF59@DB8PR08MB5308.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Iic8mGjwbwWqOUbONQACy+vDZ4MGmNrkOmvls4qaJX1TW/NWHiMZt6w5jWghiYydH7Ij3MspYFxMEIe7bF5GaiuBjOEve68uGT5eH/YEEBi9Sv0qjKoNZNRb5PTj90246GVPRBAeP5mXRuRK4UQcoNMik4irtCxLpOnwIcI+JEo95k4zR4nIffSf8VqIoRRty6a8pAlxqKYptFlZkVopoxlL+JOKpbN3/tGnJEquFJxZTi/u4FzNl6fBrea+yCL7EzA65b1NfKeApfYZomfc+V2EdSsW80U7DHTOfp/Uxpjd0JguRqnmzONu63/r5Ex3RxMs3NwZKBjjfS6K67c4WU+jAnJ3A52cV4FO/1Ts71rdF4tknF6V7ZsL0qCPAZiiCr5L4NRw/5GjqfP/sCIapdW4yots8fEdzSX7KiVasG3/nyitWMygh5FkY/zHhcc/cG78iF6GqnQ2B6ii2XTpgvGmVdLz/+oPBpiKPluJfZvWqqeZlulD4jKNFcIV2M7pCzsHS/Nnm3qVL9vLmxzeRKCjMJeQkQHECAEeuS15EVG0YFCVroe6OWR9aq4KGXpiRjoLttPbu2xrnzQScOs7n55XqdRLvXdevvXWoJ9+gyxm/KR3yLVJ9bV+oqyqpG+IeikkLTwnbpfbN/DVEeN4+93KaeaCYOg7C7UrXiLoHo9/bdWslthL+jJ6alIte4qIvn5yQQgb45UMQKOYFgONNpcNfIrud1SJGKPtwmhOExwzWglsi7bMVrQLWlK8i7qY
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(53546011)(6506007)(2616005)(6512007)(5660300002)(2906002)(8936002)(26005)(33656002)(508600001)(6486002)(86362001)(186003)(122000001)(38070700005)(316002)(36756003)(6916009)(66476007)(54906003)(99936003)(71200400001)(66556008)(76116006)(64756008)(66946007)(66446008)(91956017)(8676002)(38100700002)(4326008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: multipart/mixed;
	boundary="_007_5C7EC3F4912646E8932160878357F939armcom_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2003
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ec001aa4-78a6-44df-e1f0-08da22bd9e21
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/R0jfOvnZvCw3aIAGZFHZ8a+MQw+Y+q+ZpwS/QU4ChFEsUuBo4YjVrRtyqQjvWrslECgSaGPTjkpzf2hPA3lq+qC0hlrOLw50EQp6DtcpS421ReV+Qdk+Zoyg52eOD+N92j2BhVxt94NhRt2q+LHvENU9nItadR2gd7DJLaDFb1N5n0gW3uYSvFy1u4tnmLglUt/WPafz4jDqih/AB04vPGXTWk2UFD0Kbi8NvfiL1Geb1ivWnWfxefEnyUYzzsFG7/NXIU39qA9Qdn0AcV9KuAJZvV7Zh4KAlOAvXasop+njpYkqvhAi3gn+jXZFGF+rPi40USMi7wlCNNJlqMJ8KrzguZ/IBZqrHwBSSplzDk3mrU4hJ6zIwDkITeSwjkzVp+hvuT+BW41AsYqGd+ZV3AKiqNC/Ch80FHkWSe5c9vwSW0RmvPU1FaSvCYFyVz439iSWqXP4D4vhGCcu7YbZ8sk/B+rZ92rUxc1QWR0srr2HhwH8f201qfhjDK+SAAS9ImT9RR4jNHYmRB7Eft/ukAncE2m6YLUD3RoFJId99OA9rkCgMQsU27YVUGdmB0SVhuyloPfmaWsNFiaw/QRcnhZqIVA0gW6EjWPsJfjuysxi2s11hx/R558e1DuyZwfBGh4R+INZmn8bINwBdZkp84llPzu8V+WBSodQ72RtNn+v3GbtuTe4fcMQ53EVD9q
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(21480400003)(53546011)(26005)(33656002)(70586007)(81166007)(45080400002)(33964004)(47076005)(336012)(36756003)(83380400001)(99936003)(2616005)(82310400005)(6862004)(235185007)(8676002)(70206006)(6512007)(2906002)(6506007)(5660300002)(186003)(4326008)(107886003)(8936002)(36860700001)(508600001)(6486002)(316002)(54906003)(86362001)(356005)(40460700003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 11:05:23.3529
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a736d5b5-4797-4dea-e2d1-08da22bdaac6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5308

--_007_5C7EC3F4912646E8932160878357F939armcom_
Content-Type: multipart/alternative;
	boundary="_000_5C7EC3F4912646E8932160878357F939armcom_"

--_000_5C7EC3F4912646E8932160878357F939armcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

SGkgU3RlZmFubywNCg0KVGhhbmtzIGFnYWluIGZvciBoZWxwaW5nIHVzIHRvIGZpbmQgdGhlIHJv
b3QgY2F1c2Ugb2YgdGhlIGlzc3VlLg0KDQo+IE9uIDIwIEFwciAyMDIyLCBhdCAzOjM2IGFtLCBT
dGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPg0KPj4+
IFRoZW4gdGhlcmUgaXMgeGVuX3N3aW90bGJfaW5pdCgpIHdoaWNoIGFsbG9jYXRlcyBzb21lIG1l
bW9yeSBmb3INCj4+PiBzd2lvdGxiLXhlbiBhdCBib290LiBJdCBjb3VsZCBsb3dlciB0aGUgdG90
YWwgYW1vdW50IG9mIG1lbW9yeQ0KPj4+IGF2YWlsYWJsZSwgYnV0IGlmIHlvdSBkaXNhYmxlZCBz
d2lvdGxiLXhlbiBsaWtlIEkgc3VnZ2VzdGVkLA0KPj4+IHhlbl9zd2lvdGxiX2luaXQoKSBzdGls
bCBzaG91bGQgZ2V0IGNhbGxlZCBhbmQgZXhlY3V0ZWQgYW55d2F5IGF0IGJvb3QNCj4+PiAoaXQg
aXMgY2FsbGVkIGZyb20gYXJjaC9hcm0veGVuL21tLmM6eGVuX21tX2luaXQpLiBTbyB4ZW5fc3dp
b3RsYl9pbml0KCkNCj4+PiBzaG91bGRuJ3QgYmUgdGhlIG9uZSBjYXVzaW5nIHByb2JsZW1zLg0K
Pj4+DQo+Pj4gVGhhdCdzIGl0IC0tIHRoZXJlIGlzIG5vdGhpbmcgZWxzZSBpbiBzd2lvdGxiLXhl
biB0aGF0IEkgY2FuIHRoaW5rIG9mLg0KPj4+DQo+Pj4gSSBkb24ndCBoYXZlIGFueSBnb29kIGlk
ZWFzLCBzbyBJIHdvdWxkIG9ubHkgc3VnZ2VzdCB0byBhZGQgbW9yZSBwcmludGtzDQo+Pj4gYW5k
IHJlcG9ydCB0aGUgcmVzdWx0cywgZm9yIGluc3RhbmNlOg0KPj4NCj4+IEFzIHN1Z2dlc3RlZCBJ
IGFkZGVkIHRoZSBtb3JlIHByaW50a3MgYnV0IG9ubHkgZGlmZmVyZW5jZSBJIHNlZSBpcyB0aGUg
c2l6ZSBhcGFydA0KPj4gZnJvbSB0aGF0IGV2ZXJ5dGhpbmcgbG9va3Mgc2FtZSAuDQo+Pg0KPj4g
UGxlYXNlIGZpbmQgdGhlIGF0dGFjaGVkIGxvZ3MgZm9yIHhlbiBhbmQgbmF0aXZlIGxpbnV4IGJv
b3QuDQo+DQo+IE9uZSBkaWZmZXJlbmNlIGlzIHRoYXQgdGhlIG9yZGVyIG9mIHRoZSBhbGxvY2F0
aW9ucyBpcyBzaWduaWZpY2FudGx5DQo+IGRpZmZlcmVudCBhZnRlciB0aGUgZmlyc3QgMyBhbGxv
Y2F0aW9ucy4gSXQgaXMgdmVyeSB1bmxpa2VseSBidXQNCj4gcG9zc2libGUgdGhhdCB0aGlzIGlz
IGFuIHVucmVsYXRlZCBjb25jdXJyZW5jeSBidWcgdGhhdCBvbmx5IG9jY3VycyBvbg0KPiBYZW4u
IEkgZG91YnQgaXQuDQoNCkkgYW0gbm90IHN1cmUgYnV0IGp1c3QgdG8gY29uZmlybSB3aXRoIHlv
dSwgSSBzZWUgYmVsb3cgbG9ncyBpbiBldmVyeSBzY2VuYXJpby4NClNXSU9UTEIgbWVtb3J5IGFs
bG9jYXRlZCBieSBsaW51eCBzd2lvdGxiIGFuZCB1c2VkIGJ5IHhlbi1zd2lvdGxiLiBJcyB0aGF0
IG9rYXkgb3IgaXQgY2FuIGNhdXNlIHNvbWUgaXNzdWUuDQoNClsgICAgMC4wMDAwMDBdIG1lbSBh
dXRvLWluaXQ6IHN0YWNrOm9mZiwgaGVhcCBhbGxvYzpvZmYsIGhlYXAgZnJlZTpvZmYNClsgICAg
MC4wMDAwMDBdIHNvZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgwMDAwMDAwMGY0MDAwMDAw
LTB4MDAwMDAwMDBmODAwMDAwMF0gKDY0TUIpDQoNCnNuaXAgZnJvbSBpbnQgX19yZWYgeGVuX3N3
aW90bGJfaW5pdChpbnQgdmVyYm9zZSwgYm9vbCBlYXJseSkNCi8qDQogICAgICogSU8gVExCIG1l
bW9yeSBhbHJlYWR5IGFsbG9jYXRlZC4gSnVzdCB1c2UgaXQuDQogICAgICovDQogICAgaWYgKGlv
X3RsYl9zdGFydCAhPSAwKSB7DQogICAgICAgIHhlbl9pb190bGJfc3RhcnQgPSBwaHlzX3RvX3Zp
cnQoaW9fdGxiX3N0YXJ0KTsNCiAgICAgICAgZ290byBlbmQ7DQogICAgfQ0KDQoNCj4NCj4gSSB0
aGluayB5b3UgY291bGQgdHJ5IGJvb3RpbmcgbmF0aXZlIGFuZCBYZW4gd2l0aCBvbmx5IDEgQ1BV
IGVuYWJsZWQgaW4NCj4gYm90aCBjYXNlcy4NCj4NCj4gRm9yIG5hdGl2ZSwgeW91IGNhbiBkbyB0
aGF0IHdpdGggbWF4Y3B1cywgZS5nLiBtYXhjcHVzPTEuDQo+IEZvciBYZW4sIHlvdSBjYW4gZG8g
dGhhdCB3aXRoIGRvbTBfbWF4X3ZjcHVzPTEuIEkgZG9uJ3QgdGhpbmsgd2UgbmVlZCB0bw0KPiBy
ZWR1Y2UgdGhlIG51bWJlciBvZiBwQ1BVcyBzZWVuIGJ5IFhlbiwgYnV0IGl0IGNvdWxkIGJlIHVz
ZWZ1bCB0byBwYXNzDQo+IHNjaGVkPW51bGwgdG8gYXZvaWQgYW55IHNjaGVkdWxlciBlZmZlY3Rz
LiBUaGlzIGlzIGp1c3QgZm9yIGRlYnVnZ2luZyBvZg0KPiBjb3Vyc2UuDQo+DQoNCkkgdHJpZWQg
dG8gYm9vdCB0aGUgWEVOIHdpdGggImRvbTBfbWF4X3ZjcHVzPTHigJ0gJiDigJxzY2hlZHVsZS1u
dWxs4oCdIGFuZA0KaXNzdWUgcmVtYWlucyAuDQoNCj4NCj4gSW4gcmVhbGl0eSwgdGhlIG1vc3Qg
bGlrZWx5IGV4cGxhbmF0aW9uIGlzIHRoYXQgdGhlIGlzc3VlIGlzIGEgbWVtb3J5DQo+IGNvcnJ1
cHRpb24uIFNvbWV0aGluZyBzb21ld2hlcmUgaXMgY29ycnVwdGluZyBMaW51eCBtZW1vcnkgYW5k
IGl0IGp1c3QNCj4gaGFwcGVucyB0aGF0IHdlIHNlZSBpdCB3aGVuIGNhbGxpbmcgZG1hX2RpcmVj
dF9hbGxvYy4gVGhpcyBtZWFucyBpdCBpcw0KPiBnb2luZyB0byBiZSBkaWZmaWN1bHQgdG8gZmlu
ZCBhcyB0aGUgb25seSByZWFsIGNsdWUgaXMgdGhhdCBpdCBpcw0KPiBzd2lvdGxiLXhlbiB0aGF0
IGlzIGNhdXNpbmcgaXQuDQoNCkFncmVlIHdlIG9ic2VydmUgaXNzdWUgd2l0aCB4ZW4tc3dpb3Rs
YiBkbWEgb3BzIG9ubHkuDQo+DQo+DQo+IEkgYWRkZWQgbW9yZSBwcmludGtzIHdpdGggdGhlIGdv
YWwgb2YgZGV0ZWN0aW5nIHN3aW90bGIteGVuIGNvZGUgcGF0aHMNCj4gdGhhdCBzaG91bGRuJ3Qg
YmUgdGFrZW4gaW4gYSBub3JtYWwgZG9tMCBib290IHdpdGhvdXQgZG9tVXMuIEZvcg0KPiBpbnN0
YW5jZSwgcmFuZ2Vfc3RyYWRkbGVzX3BhZ2VfYm91bmRhcnkgc2hvdWxkIGFsd2F5cyByZXR1cm4g
emVybyBhbmQNCj4gdGhlIGRtYV9tYXNrIGNoZWNrIGluIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVy
ZW50IHNob3VsZCBhbHdheXMgc3VjY2VlZC4NCj4NCj4gRmluZ2VycyBjcm9zc2VkIHdlJ2xsIG5v
dGljZSB0aGF0IHRoZSB3cm9uZyBwYXRoIGlzIHRha2VuIGp1c3QgYmVmb3JlDQo+IHRoZSBjcmFz
aC4NCg0KUGxlYXNlIGZpbmQgdGhlIGF0dGFjaGVkIGxvZ3MuDQoNCkkgY2FwdHVyZWQgdGhlIGxv
Z3MgZm9yIFhlbiB3aXRoIGFuZCB3aXRob3V0IChkb20wX21heF92Y3B1cz0xICYgc2NoZWQ9bnVs
bCkgYW5kDQphbHNvIGZvciBuYXRpdmUgbGludXggd2l0aCBhbmQgd2l0aG91dCAobWF4Y3B1cz0x
KQ0KDQoNCg0KUmVnYXJkcywNClJhaHVsDQo=

--_000_5C7EC3F4912646E8932160878357F939armcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <9490A065C3821747BE0ED2D4C8E83AC6@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i
Qm9keUZyYWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQ7
Ij4NCjxkaXYgY2xhc3M9IlBsYWluVGV4dCI+SGkgU3RlZmFubyw8YnI+DQo8YnI+DQpUaGFua3Mg
YWdhaW4gZm9yIGhlbHBpbmcgdXMgdG8gZmluZCB0aGUgcm9vdCBjYXVzZSBvZiB0aGUgaXNzdWUu
PGJyPg0KPGJyPg0KJmd0OyBPbiAyMCBBcHIgMjAyMiwgYXQgMzozNiBhbSwgU3RlZmFubyBTdGFi
ZWxsaW5pICZsdDtzc3RhYmVsbGluaUBrZXJuZWwub3JnJmd0OyB3cm90ZTo8YnI+DQomZ3Q7IDxi
cj4NCiZndDsmZ3Q7Jmd0OyBUaGVuIHRoZXJlIGlzIHhlbl9zd2lvdGxiX2luaXQoKSB3aGljaCBh
bGxvY2F0ZXMgc29tZSBtZW1vcnkgZm9yPGJyPg0KJmd0OyZndDsmZ3Q7IHN3aW90bGIteGVuIGF0
IGJvb3QuIEl0IGNvdWxkIGxvd2VyIHRoZSB0b3RhbCBhbW91bnQgb2YgbWVtb3J5PGJyPg0KJmd0
OyZndDsmZ3Q7IGF2YWlsYWJsZSwgYnV0IGlmIHlvdSBkaXNhYmxlZCBzd2lvdGxiLXhlbiBsaWtl
IEkgc3VnZ2VzdGVkLDxicj4NCiZndDsmZ3Q7Jmd0OyB4ZW5fc3dpb3RsYl9pbml0KCkgc3RpbGwg
c2hvdWxkIGdldCBjYWxsZWQgYW5kIGV4ZWN1dGVkIGFueXdheSBhdCBib290PGJyPg0KJmd0OyZn
dDsmZ3Q7IChpdCBpcyBjYWxsZWQgZnJvbSBhcmNoL2FybS94ZW4vbW0uYzp4ZW5fbW1faW5pdCku
IFNvIHhlbl9zd2lvdGxiX2luaXQoKTxicj4NCiZndDsmZ3Q7Jmd0OyBzaG91bGRuJ3QgYmUgdGhl
IG9uZSBjYXVzaW5nIHByb2JsZW1zLjxicj4NCiZndDsmZ3Q7Jmd0OyA8YnI+DQomZ3Q7Jmd0OyZn
dDsgVGhhdCdzIGl0IC0tIHRoZXJlIGlzIG5vdGhpbmcgZWxzZSBpbiBzd2lvdGxiLXhlbiB0aGF0
IEkgY2FuIHRoaW5rIG9mLjxicj4NCiZndDsmZ3Q7Jmd0OyA8YnI+DQomZ3Q7Jmd0OyZndDsgSSBk
b24ndCBoYXZlIGFueSBnb29kIGlkZWFzLCBzbyBJIHdvdWxkIG9ubHkgc3VnZ2VzdCB0byBhZGQg
bW9yZSBwcmludGtzPGJyPg0KJmd0OyZndDsmZ3Q7IGFuZCByZXBvcnQgdGhlIHJlc3VsdHMsIGZv
ciBpbnN0YW5jZTo8YnI+DQomZ3Q7Jmd0OyA8YnI+DQomZ3Q7Jmd0OyBBcyBzdWdnZXN0ZWQgSSBh
ZGRlZCB0aGUgbW9yZSBwcmludGtzIGJ1dCBvbmx5IGRpZmZlcmVuY2UgSSBzZWUgaXMgdGhlIHNp
emUgYXBhcnQ8YnI+DQomZ3Q7Jmd0OyBmcm9tIHRoYXQgZXZlcnl0aGluZyBsb29rcyBzYW1lIC48
YnI+DQomZ3Q7Jmd0OyA8YnI+DQomZ3Q7Jmd0OyBQbGVhc2UgZmluZCB0aGUgYXR0YWNoZWQgbG9n
cyBmb3IgeGVuIGFuZCBuYXRpdmUgbGludXggYm9vdC48YnI+DQomZ3Q7IDxicj4NCiZndDsgT25l
IGRpZmZlcmVuY2UgaXMgdGhhdCB0aGUgb3JkZXIgb2YgdGhlIGFsbG9jYXRpb25zIGlzIHNpZ25p
ZmljYW50bHk8YnI+DQomZ3Q7IGRpZmZlcmVudCBhZnRlciB0aGUgZmlyc3QgMyBhbGxvY2F0aW9u
cy4gSXQgaXMgdmVyeSB1bmxpa2VseSBidXQ8YnI+DQomZ3Q7IHBvc3NpYmxlIHRoYXQgdGhpcyBp
cyBhbiB1bnJlbGF0ZWQgY29uY3VycmVuY3kgYnVnIHRoYXQgb25seSBvY2N1cnMgb248YnI+DQom
Z3Q7IFhlbi4gSSBkb3VidCBpdC48YnI+DQo8YnI+DQpJIGFtIG5vdCBzdXJlIGJ1dCBqdXN0IHRv
IGNvbmZpcm0gd2l0aCB5b3UsIEkgc2VlIGJlbG93IGxvZ3MgaW4gZXZlcnkgc2NlbmFyaW8uPGJy
Pg0KU1dJT1RMQiBtZW1vcnkgYWxsb2NhdGVkIGJ5IGxpbnV4IHN3aW90bGIgYW5kIHVzZWQgYnkg
eGVuLXN3aW90bGIuIElzIHRoYXQgb2theSBvciBpdCBjYW4gY2F1c2Ugc29tZSBpc3N1ZS48YnI+
DQo8YnI+DQpbJm5ic3A7Jm5ic3A7Jm5ic3A7IDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBzdGFj
azpvZmYsIGhlYXAgYWxsb2M6b2ZmLCBoZWFwIGZyZWU6b2ZmPGJyPg0KWyZuYnNwOyZuYnNwOyZu
YnNwOyAwLjAwMDAwMF0gc29mdHdhcmUgSU8gVExCOiBtYXBwZWQgW21lbSAweDAwMDAwMDAwZjQw
MDAwMDAtMHgwMDAwMDAwMGY4MDAwMDAwXSAoNjRNQik8YnI+DQo8YnI+DQpzbmlwIGZyb20gaW50
IF9fcmVmIHhlbl9zd2lvdGxiX2luaXQoaW50IHZlcmJvc2UsIGJvb2wgZWFybHkpIDxicj4NCi8q
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IDxicj4NCiZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyAqIElPIFRMQiBtZW1vcnkgYWxyZWFkeSBhbGxvY2F0ZWQuIEp1c3QgdXNl
IGl0LiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyA8YnI+
DQombmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgKi8mbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsgPGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7IGlmIChpb190bGJfc3RhcnQgIT0gMCkgeyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyA8YnI+DQombmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsgeGVuX2lvX3RsYl9zdGFydCA9IHBoeXNfdG9fdmlydChpb190bGJfc3RhcnQp
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyA8YnI+DQombmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgZ290byBlbmQ7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7IDxicj4NCiZuYnNwOyZuYnNwOyZuYnNwOyB9IDxicj4NCjxicj4NCjxicj4N
CiZndDsgPGJyPg0KJmd0OyBJIHRoaW5rIHlvdSBjb3VsZCB0cnkgYm9vdGluZyBuYXRpdmUgYW5k
IFhlbiB3aXRoIG9ubHkgMSBDUFUgZW5hYmxlZCBpbjxicj4NCiZndDsgYm90aCBjYXNlcy48YnI+
DQomZ3Q7IDxicj4NCiZndDsgRm9yIG5hdGl2ZSwgeW91IGNhbiBkbyB0aGF0IHdpdGggbWF4Y3B1
cywgZS5nLiBtYXhjcHVzPTEuPGJyPg0KJmd0OyBGb3IgWGVuLCB5b3UgY2FuIGRvIHRoYXQgd2l0
aCBkb20wX21heF92Y3B1cz0xLiBJIGRvbid0IHRoaW5rIHdlIG5lZWQgdG88YnI+DQomZ3Q7IHJl
ZHVjZSB0aGUgbnVtYmVyIG9mIHBDUFVzIHNlZW4gYnkgWGVuLCBidXQgaXQgY291bGQgYmUgdXNl
ZnVsIHRvIHBhc3M8YnI+DQomZ3Q7IHNjaGVkPW51bGwgdG8gYXZvaWQgYW55IHNjaGVkdWxlciBl
ZmZlY3RzLiBUaGlzIGlzIGp1c3QgZm9yIGRlYnVnZ2luZyBvZjxicj4NCiZndDsgY291cnNlLjxi
cj4NCiZndDsgPGJyPg0KPGJyPg0KSSB0cmllZCB0byBib290IHRoZSBYRU4gd2l0aCAmcXVvdDtk
b20wX21heF92Y3B1cz0x4oCdICZhbXA7IOKAnHNjaGVkdWxlLW51bGzigJ0gYW5kPGJyPg0KaXNz
dWUgcmVtYWlucyAuPGJyPg0KPGJyPg0KJmd0OyA8YnI+DQomZ3Q7IEluIHJlYWxpdHksIHRoZSBt
b3N0IGxpa2VseSBleHBsYW5hdGlvbiBpcyB0aGF0IHRoZSBpc3N1ZSBpcyBhIG1lbW9yeTxicj4N
CiZndDsgY29ycnVwdGlvbi4gU29tZXRoaW5nIHNvbWV3aGVyZSBpcyBjb3JydXB0aW5nIExpbnV4
IG1lbW9yeSBhbmQgaXQganVzdDxicj4NCiZndDsgaGFwcGVucyB0aGF0IHdlIHNlZSBpdCB3aGVu
IGNhbGxpbmcgZG1hX2RpcmVjdF9hbGxvYy4gVGhpcyBtZWFucyBpdCBpczxicj4NCiZndDsgZ29p
bmcgdG8gYmUgZGlmZmljdWx0IHRvIGZpbmQgYXMgdGhlIG9ubHkgcmVhbCBjbHVlIGlzIHRoYXQg
aXQgaXM8YnI+DQomZ3Q7IHN3aW90bGIteGVuIHRoYXQgaXMgY2F1c2luZyBpdC48YnI+DQo8YnI+
DQpBZ3JlZSB3ZSBvYnNlcnZlIGlzc3VlIHdpdGggeGVuLXN3aW90bGIgZG1hIG9wcyBvbmx5LiA8
YnI+DQomZ3Q7IDxicj4NCiZndDsgPGJyPg0KJmd0OyBJIGFkZGVkIG1vcmUgcHJpbnRrcyB3aXRo
IHRoZSBnb2FsIG9mIGRldGVjdGluZyBzd2lvdGxiLXhlbiBjb2RlIHBhdGhzPGJyPg0KJmd0OyB0
aGF0IHNob3VsZG4ndCBiZSB0YWtlbiBpbiBhIG5vcm1hbCBkb20wIGJvb3Qgd2l0aG91dCBkb21V
cy4gRm9yPGJyPg0KJmd0OyBpbnN0YW5jZSwgcmFuZ2Vfc3RyYWRkbGVzX3BhZ2VfYm91bmRhcnkg
c2hvdWxkIGFsd2F5cyByZXR1cm4gemVybyBhbmQ8YnI+DQomZ3Q7IHRoZSBkbWFfbWFzayBjaGVj
ayBpbiB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCBzaG91bGQgYWx3YXlzIHN1Y2NlZWQuPGJy
Pg0KJmd0OyA8YnI+DQomZ3Q7IEZpbmdlcnMgY3Jvc3NlZCB3ZSdsbCBub3RpY2UgdGhhdCB0aGUg
d3JvbmcgcGF0aCBpcyB0YWtlbiBqdXN0IGJlZm9yZTxicj4NCiZndDsgdGhlIGNyYXNoLjxicj4N
Cjxicj4NClBsZWFzZSBmaW5kIHRoZSBhdHRhY2hlZCBsb2dzLjxicj4NCjxicj4NCkkgY2FwdHVy
ZWQgdGhlIGxvZ3MgZm9yIFhlbiB3aXRoIGFuZCB3aXRob3V0IChkb20wX21heF92Y3B1cz0xICZh
bXA7IHNjaGVkPW51bGwpIGFuZDxicj4NCmFsc28gZm9yIG5hdGl2ZSBsaW51eCB3aXRoIGFuZCB3
aXRob3V0IChtYXhjcHVzPTEpPGJyPg0KPGJyPg0KPC9kaXY+DQo8L3NwYW4+PC9mb250PjwvZGl2
Pg0KPGRpdiBjbGFzcz0iQm9keUZyYWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0i
Zm9udC1zaXplOjExcHQ7Ij4NCjxkaXYgY2xhc3M9IlBsYWluVGV4dCI+PGJyPg0KJm5ic3A7PGJy
Pg0KUmVnYXJkcyw8YnI+DQpSYWh1bDwvZGl2Pg0KPC9zcGFuPjwvZm9udD48L2Rpdj4NCjwvYm9k
eT4NCjwvaHRtbD4NCg==

--_000_5C7EC3F4912646E8932160878357F939armcom_--

--_007_5C7EC3F4912646E8932160878357F939armcom_
Content-Type: application/octet-stream;
	name="xen_boot_with_dom0_max_vcpus_1_debug.log"
Content-Description: xen_boot_with_dom0_max_vcpus_1_debug.log
Content-Disposition: attachment;
	filename="xen_boot_with_dom0_max_vcpus_1_debug.log"; size=76307;
	creation-date="Wed, 20 Apr 2022 11:05:02 GMT";
	modification-date="Wed, 20 Apr 2022 11:05:02 GMT"
Content-ID: <073056FDCC461242B8A0D73C1B4801EF@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogVHVlIEFwciAxOSAxNzo0MTowNiBvbiB0dHlzMDA2DQpyYWhzaW4wMUBDMDJa
WDBHOUxWRE4gfiAlIHRlbG5ldCBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29tIDEwMDIwDQpUcnlp
bmcgMTAuMS4xOTQuMjUuLi4NCkNvbm5lY3RlZCB0byBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29t
Lg0KRXNjYXBlIGNoYXJhY3RlciBpcyAnXl0nLg0KDQpBSVMgdGFyZ2V0IHN5c3RlbSBwb3J0IDEw
MDIwIGRldmljZSAvZGV2L3R0eVVTQjEgWzExNTIwMCBOODFdDQoNCg0KRlMwOlw+IHhlbi5lZmkN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0K
DQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0K
DQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQpYZW4gNC4xNS4xIChjL3MgRnJpIFNlcCAx
MCAwOTowMzoyNCAyMDIxICswMjAwIGdpdDo4NGZhOTkwOTliLWRpcnR5KSBFRkkgbG9hZGVyDQpV
c2luZyBjb25maWd1cmF0aW9uIGZpbGUgJ3hlbi5jZmcnDQpJbWFnZS14ZW46IDB4MDAwMDAwMDBm
ZTQ3YzAwMC0weDAwMDAwMDAwZmZiM2YyMDANClBST0dSRVNTIENPREU6IFYwMzEwMTAxOSBJMA0K
IFhlbiA0LjE1LjENCihYRU4pIFhlbiB2ZXJzaW9uIDQuMTUuMSAoeGVuLTQuMTUrc3RhYmxlQVVU
T0lOQys4NGZhOTkwOTliLXIwQGV3YW9sKSAoYWFyY2g2NC1wb2t5LWxpbnV4LWdjYyAoR0NDKSAx
MS4yLjApIGRlYnVnPW4gMjAyMS0wOS0xMA0KKFhFTikgTGF0ZXN0IENoYW5nZVNldDogRnJpIFNl
cCAxMCAwOTowMzoyNCAyMDIxICswMjAwIGdpdDo4NGZhOTkwOTliLWRpcnR5DQooWEVOKSBidWls
ZC1pZDogNzgzNDQ4YzM4YWE2ZmY0NjVlNmI0NjMxODUzYmM3MzA3NmJjZjdlNA0KKFhFTikgUHJv
Y2Vzc29yOiA0MTNmZDBjMTogIkFSTSBMaW1pdGVkIiwgdmFyaWFudDogMHgzLCBwYXJ0IDB4ZDBj
LCByZXYgMHgxDQooWEVOKSA2NC1iaXQgRXhlY3V0aW9uOg0KKFhFTikgICBQcm9jZXNzb3IgRmVh
dHVyZXM6IDExMDAwMDAwMTExMTExMTIgMDAwMDAwMDAwMDAwMDAyMA0KKFhFTikgICAgIEV4Y2Vw
dGlvbiBMZXZlbHM6IEVMMzo2NCBFTDI6NjQgRUwxOjY0IEVMMDo2NCszMg0KKFhFTikgICAgIEV4
dGVuc2lvbnM6IEZsb2F0aW5nUG9pbnQgQWR2YW5jZWRTSU1EIEdJQ3YzLVN5c1JlZw0KKFhFTikg
ICBEZWJ1ZyBGZWF0dXJlczogMDAwMDAwMDExMDMwNTQwOCAwMDAwMDAwMDAwMDAwMDAwDQooWEVO
KSAgIEF1eGlsaWFyeSBGZWF0dXJlczogMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAw
DQooWEVOKSAgIE1lbW9yeSBNb2RlbCBGZWF0dXJlczogMDAwMDAwMDAwMDEwMTEyNSAwMDAwMDAw
MDEwMjEyMTIyDQooWEVOKSAgIElTQSBGZWF0dXJlczogIDAwMDAxMDAwMTAyMTExMjAgMDAwMDAw
MDAwMDEwMDAwMQ0KKFhFTikgMzItYml0IEV4ZWN1dGlvbjoNCihYRU4pICAgUHJvY2Vzc29yIEZl
YXR1cmVzOiAxMDAxMDEzMToxMDAxMDAwMA0KKFhFTikgICAgIEluc3RydWN0aW9uIFNldHM6IEFB
cmNoMzIgQTMyIFRodW1iIFRodW1iLTIgSmF6ZWxsZQ0KKFhFTikgICAgIEV4dGVuc2lvbnM6IEdl
bmVyaWNUaW1lcg0KKFhFTikgICBEZWJ1ZyBGZWF0dXJlczogMDQwMTAwODgNCihYRU4pICAgQXV4
aWxpYXJ5IEZlYXR1cmVzOiAwMDAwMDAwMA0KKFhFTikgICBNZW1vcnkgTW9kZWwgRmVhdHVyZXM6
IDEwMjAxMTA1IDQwMDAwMDAwIDAxMjYwMDAwIDAyMTIyMjExDQooWEVOKSAgSVNBIEZlYXR1cmVz
OiAwMjEwMTExMCAxMzExMjExMSAyMTIzMjA0MiAwMTExMjEzMSAwMDAxMDE0MiAwMTAxMTEyMQ0K
KFhFTikgVXNpbmcgU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4yDQooWEVOKSBVc2luZyBQU0NJ
IHYxLjENCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxMDAwXSBhZGRyZXNzWzB4MF0gTVBJ
RFJbMHgxMDAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTgwMF0g
YWRkcmVzc1sweDBdIE1QSURSWzB4MTgwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAo
YWNwaV9pZFsweDE2MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDE2MDAwMF0gZW5hYmxlZCkNCihY
RU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxZTAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxZTAw
MDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MDgwMF0gYWRkcmVzc1sw
eDBdIE1QSURSWzB4ODAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4
MjAwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjAwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTog
R0lDQyAoYWNwaV9pZFsweDBlMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweGUwMDAwXSBlbmFibGVk
KQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDI2MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsw
eDI2MDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxMTAwXSBhZGRy
ZXNzWzB4MF0gTVBJRFJbMHgxMTAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3Bp
X2lkWzB4MTkwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTkwMDAwXSBlbmFibGVkKQ0KKFhFTikg
QUNQSTogR0lDQyAoYWNwaV9pZFsweDE3MDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDE3MDAwMF0g
ZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxZjAwXSBhZGRyZXNzWzB4MF0g
TVBJRFJbMHgxZjAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MDkw
MF0gYWRkcmVzc1sweDBdIE1QSURSWzB4OTAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUND
IChhY3BpX2lkWzB4MjEwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjEwMDAwXSBlbmFibGVkKQ0K
KFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDBmMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweGYw
MDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDI3MDBdIGFkZHJlc3Nb
MHgwXSBNUElEUlsweDI3MDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRb
MHgxMDAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxMDAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJ
OiBHSUNDIChhY3BpX2lkWzB4MTgwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTgwMTAwXSBlbmFi
bGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDE2MDFdIGFkZHJlc3NbMHgwXSBNUElE
UlsweDE2MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxZTAxXSBh
ZGRyZXNzWzB4MF0gTVBJRFJbMHgxZTAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChh
Y3BpX2lkWzB4MDgwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4ODAxMDBdIGVuYWJsZWQpDQooWEVO
KSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MjAwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjAwMTAw
XSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDBlMDFdIGFkZHJlc3NbMHgw
XSBNUElEUlsweGUwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDI2
MDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDI2MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJ
Q0MgKGFjcGlfaWRbMHgxMTAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxMTAxMDBdIGVuYWJsZWQp
DQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTkwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4
MTkwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDE3MDFdIGFkZHJl
c3NbMHgwXSBNUElEUlsweDE3MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlf
aWRbMHgxZjAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxZjAxMDBdIGVuYWJsZWQpDQooWEVOKSBB
Q1BJOiBHSUNDIChhY3BpX2lkWzB4MDkwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4OTAxMDBdIGVu
YWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MjEwMV0gYWRkcmVzc1sweDBdIE1Q
SURSWzB4MjEwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDBmMDFd
IGFkZHJlc3NbMHgwXSBNUElEUlsweGYwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAo
YWNwaV9pZFsweDI3MDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDI3MDEwMF0gZW5hYmxlZCkNCihY
RU4pIDMyIENQVXMgZW5hYmxlZCwgMzIgQ1BVcyB0b3RhbA0KKFhFTikgU01QOiBBbGxvd2luZyAz
MiBDUFVzDQooWEVOKSBHZW5lcmljIFRpbWVyIElSUTogcGh5cz0zMCBoeXA9MjYgdmlydD0yNyBG
cmVxOiAyNTAwMCBLSHoNCihYRU4pIEdJQ3YzIGluaXRpYWxpemF0aW9uOg0KKFhFTikgICAgICAg
Z2ljX2Rpc3RfYWRkcj0weDAwMTAwMTAwMDAwMDAwDQooWEVOKSAgICAgICBnaWNfbWFpbnRlbmFu
Y2VfaXJxPTI1DQooWEVOKSAgICAgICBnaWNfcmRpc3Rfc3RyaWRlPTANCihYRU4pICAgICAgIGdp
Y19yZGlzdF9yZWdpb25zPTENCihYRU4pICAgICAgIHJlZGlzdHJpYnV0b3IgcmVnaW9uczoNCihY
RU4pICAgICAgICAgLSByZWdpb24gMDogMHgwMDEwMDEwMDE0MDAwMCAtIDB4MDAxMDAxMDExNDAw
MDANCihYRU4pIEdJQ3YzOiB1c2luZyBhdCBtb3N0IDU3MzQ0IExQSXMgb24gdGhlIGhvc3QuDQoo
WEVOKSBHSUN2MzogNzA0IGxpbmVzLCAoSUlEIDAyMDE3NDNiKS4NCihYRU4pIEdJQ3YzOiBGb3Vu
ZCBJVFMgQDB4MTAwMTAwMDQwMDAwDQooWEVOKSBHSUN2MzogRm91bmQgSVRTIEAweDEwMDEwMDA2
MDAwMA0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBAMHgxMDAxMDAwODAwMDANCihYRU4pIEdJQ3Yz
OiBGb3VuZCBJVFMgQDB4MTAwMTAwMGEwMDAwDQooWEVOKSBHSUN2MzogRm91bmQgSVRTIEAweDEw
MDEwMDBjMDAwMA0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBAMHgxMDAxMDAwZTAwMDANCihYRU4p
IEdJQ3YzOiBGb3VuZCBJVFMgQDB4MTAwMTAwMTAwMDAwDQooWEVOKSBHSUN2MzogRm91bmQgSVRT
IEAweDEwMDEwMDEyMDAwMA0KKFhFTikgR0lDdjM6IENQVTA6IEZvdW5kIHJlZGlzdHJpYnV0b3Ig
aW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA0MzQwMDANCihYRU4pIFhTTSBGcmFtZXdvcmsgdjEuMC4w
IGluaXRpYWxpemVkDQooWEVOKSBJbml0aWFsaXNpbmcgWFNNIFNJTE8gbW9kZQ0KKFhFTikgVXNp
bmcgc2NoZWR1bGVyOiBudWxsIFNjaGVkdWxlciAobnVsbCkNCihYRU4pIEluaXRpYWxpemluZyBu
dWxsIHNjaGVkdWxlcg0KKFhFTikgV0FSTklORzogVGhpcyBpcyBleHBlcmltZW50YWwgc29mdHdh
cmUgaW4gZGV2ZWxvcG1lbnQuDQooWEVOKSBVc2UgYXQgeW91ciBvd24gcmlzay4NCihYRU4pIERl
ZmF1bHRpbmcgdG8gYWx0ZXJuYXRpdmUga2V5IGhhbmRsaW5nOyBzZW5kICdBJyB0byBzd2l0Y2gg
dG8gbm9ybWFsIG1vZGUuDQooWEVOKSBBbGxvY2F0ZWQgY29uc29sZSByaW5nIG9mIDI1NiBLaUIu
DQooWEVOKSBDUFUwOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIEJyaW5naW5nIHVwIENQVTENCihYRU4pIEdJQ3YzOiBDUFUx
OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjM0MDAwDQooWEVO
KSBDUFUxOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRo
ZSBkb21haW4NCihYRU4pIENQVSAxIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTINCihY
RU4pIEdJQ3YzOiBDUFUyOiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAw
MDQwNWI0MDAwDQooWEVOKSBDUFUyOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE3IHRpbWVzIGJl
Zm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyIGJvb3RlZC4NCihYRU4pIEJyaW5n
aW5nIHVwIENQVTMNCihYRU4pIEdJQ3YzOiBDUFUzOiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJl
Z2lvbiAwIEAwMDAwMDAwMDQwN2I0MDAwDQooWEVOKSBDUFUzOiBHdWVzdCBhdG9taWNzIHdpbGwg
dHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAzIGJvb3Rl
ZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTQNCihYRU4pIEdJQ3YzOiBDUFU0OiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwMjM0MDAwDQooWEVOKSBDUFU0OiBHdWVz
dCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihY
RU4pIENQVSA0IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTUNCihYRU4pIEdJQ3YzOiBD
UFU1OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwODM0MDAwDQoo
WEVOKSBDUFU1OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5n
IHRoZSBkb21haW4NCihYRU4pIENQVSA1IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTYN
CihYRU4pIEdJQ3YzOiBDUFU2OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAw
MDAwMDQwM2I0MDAwDQooWEVOKSBDUFU2OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVz
IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA2IGJvb3RlZC4NCihYRU4pIEJy
aW5naW5nIHVwIENQVTcNCihYRU4pIEdJQ3YzOiBDUFU3OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGlu
IHJlZ2lvbiAwIEAwMDAwMDAwMDQwOWI0MDAwDQooWEVOKSBDUFU3OiBHdWVzdCBhdG9taWNzIHdp
bGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA3IGJv
b3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTgNCihYRU4pIEdJQ3YzOiBDUFU4OiBGb3VuZCBy
ZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNDc0MDAwDQooWEVOKSBDUFU4OiBH
dWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4N
CihYRU4pIENQVSA4IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTkNCihYRU4pIEdJQ3Yz
OiBDUFU5OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjc0MDAw
DQooWEVOKSBDUFU5OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA5IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQ
VTEwDQooWEVOKSBHSUN2MzogQ1BVMTA6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDA1ZjQwMDANCihYRU4pIENQVTEwOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4
IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxMCBib290ZWQuDQoo
WEVOKSBCcmluZ2luZyB1cCBDUFUxMQ0KKFhFTikgR0lDdjM6IENQVTExOiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwN2Y0MDAwDQooWEVOKSBDUFUxMTogR3Vlc3Qg
YXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVO
KSBDUFUgMTEgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTINCihYRU4pIEdJQ3YzOiBD
UFUxMjogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDI3NDAwMA0K
KFhFTikgQ1BVMTI6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNp
bmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDEyIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQ
VTEzDQooWEVOKSBHSUN2MzogQ1BVMTM6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDA4NzQwMDANCihYRU4pIENQVTEzOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4
IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxMyBib290ZWQuDQoo
WEVOKSBCcmluZ2luZyB1cCBDUFUxNA0KKFhFTikgR0lDdjM6IENQVTE0OiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwM2Y0MDAwDQooWEVOKSBDUFUxNDogR3Vlc3Qg
YXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVO
KSBDUFUgMTQgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTUNCihYRU4pIEdJQ3YzOiBD
UFUxNTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDlmNDAwMA0K
KFhFTikgQ1BVMTU6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNp
bmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDE1IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQ
VTE2DQooWEVOKSBHSUN2MzogQ1BVMTY6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDA0NTQwMDANCihYRU4pIENQVTE2OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4
IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxNiBib290ZWQuDQoo
WEVOKSBCcmluZ2luZyB1cCBDUFUxNw0KKFhFTikgR0lDdjM6IENQVTE3OiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjU0MDAwDQooWEVOKSBDUFUxNzogR3Vlc3Qg
YXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVO
KSBDUFUgMTcgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMTgNCihYRU4pIEdJQ3YzOiBD
UFUxODogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDVkNDAwMA0K
KFhFTikgQ1BVMTg6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNp
bmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDE4IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQ
VTE5DQooWEVOKSBHSUN2MzogQ1BVMTk6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDA3ZDQwMDANCihYRU4pIENQVTE5OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE3
IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxOSBib290ZWQuDQoo
WEVOKSBCcmluZ2luZyB1cCBDUFUyMA0KKFhFTikgR0lDdjM6IENQVTIwOiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwMjU0MDAwDQooWEVOKSBDUFUyMDogR3Vlc3Qg
YXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVO
KSBDUFUgMjAgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjENCihYRU4pIEdJQ3YzOiBD
UFUyMTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDg1NDAwMA0K
KFhFTikgQ1BVMjE6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNp
bmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDIxIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQ
VTIyDQooWEVOKSBHSUN2MzogQ1BVMjI6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDAzZDQwMDANCihYRU4pIENQVTIyOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4
IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyMiBib290ZWQuDQoo
WEVOKSBCcmluZ2luZyB1cCBDUFUyMw0KKFhFTikgR0lDdjM6IENQVTIzOiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwOWQ0MDAwDQooWEVOKSBDUFUyMzogR3Vlc3Qg
YXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVO
KSBDUFUgMjMgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjQNCihYRU4pIEdJQ3YzOiBD
UFUyNDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDQ5NDAwMA0K
KFhFTikgQ1BVMjQ6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNp
bmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDI0IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQ
VTI1DQooWEVOKSBHSUN2MzogQ1BVMjU6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDA2OTQwMDANCihYRU4pIENQVTI1OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4
IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyNSBib290ZWQuDQoo
WEVOKSBCcmluZ2luZyB1cCBDUFUyNg0KKFhFTikgR0lDdjM6IENQVTI2OiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjE0MDAwDQooWEVOKSBDUFUyNjogR3Vlc3Qg
YXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVO
KSBDUFUgMjYgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjcNCihYRU4pIEdJQ3YzOiBD
UFUyNzogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDgxNDAwMA0K
KFhFTikgQ1BVMjc6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTcgdGltZXMgYmVmb3JlIHBhdXNp
bmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDI3IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQ
VTI4DQooWEVOKSBHSUN2MzogQ1BVMjg6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDAyOTQwMDANCihYRU4pIENQVTI4OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4
IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyOCBib290ZWQuDQoo
WEVOKSBCcmluZ2luZyB1cCBDUFUyOQ0KKFhFTikgR0lDdjM6IENQVTI5OiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwODk0MDAwDQooWEVOKSBDUFUyOTogR3Vlc3Qg
YXRvbWljcyB3aWxsIHRyeSAxOCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVO
KSBDUFUgMjkgYm9vdGVkLg0KKFhFTikgQnJpbmdpbmcgdXAgQ1BVMzANCihYRU4pIEdJQ3YzOiBD
UFUzMDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDQxNDAwMA0K
KFhFTikgQ1BVMzA6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNp
bmcgdGhlIGRvbWFpbg0KKFhFTikgQ1BVIDMwIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQ
VTMxDQooWEVOKSBHSUN2MzogQ1BVMzE6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAg
QDAwMDAwMDAwNDBhMTQwMDANCihYRU4pIENQVTMxOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4
IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIEJyb3VnaHQgdXAgMzIgQ1BV
cw0KKFhFTikgQ1BVIDMxIGJvb3RlZC4NCihYRU4pIEkvTyB2aXJ0dWFsaXNhdGlvbiBkaXNhYmxl
ZA0KKFhFTikgUDJNOiA0OC1iaXQgSVBBIHdpdGggNDgtYml0IFBBIGFuZCAxNi1iaXQgVk1JRA0K
KFhFTikgUDJNOiA0IGxldmVscyB3aXRoIG9yZGVyLTAgcm9vdCwgVlRDUiAweDgwMGQzNTkwDQoo
WEVOKSBTY2hlZHVsaW5nIGdyYW51bGFyaXR5OiBjcHUsIDEgQ1BVIHBlciBzY2hlZC1yZXNvdXJj
ZQ0KKFhFTikgYWx0ZXJuYXRpdmVzOiBQYXRjaGluZyB3aXRoIGFsdCB0YWJsZSAwMDAwMDAwMDAw
MmNkMGIwIC0+IDAwMDAwMDAwMDAyY2Q5ZTANCihYRU4pICoqKiBMT0FESU5HIERPTUFJTiAwICoq
Kg0KKFhFTikgTG9hZGluZyBkMCBrZXJuZWwgZnJvbSBib290IG1vZHVsZSBAIDAwMDAwMDAwZmU0
N2MwMDANCihYRU4pIEFsbG9jYXRpbmcgMToxIG1hcHBpbmdzIHRvdGFsbGluZyA4MTkyTUIgZm9y
IGRvbTA6DQooWEVOKSBCQU5LWzBdIDB4MDAwMDAwOTgwMDAwMDAtMHgwMDAwMDBmODAwMDAwMCAo
MTUzNk1CKQ0KKFhFTikgQkFOS1sxXSAweDAwMDgwMDAwMDAwMDAwLTB4MDAwODAwODAwMDAwMDAg
KDIwNDhNQikNCihYRU4pIEJBTktbMl0gMHgwMDA4MDY4MDAwMDAwMC0weDAwMDgwN2EwMDAwMDAw
ICg0NjA4TUIpDQooWEVOKSBHcmFudCB0YWJsZSByYW5nZTogMHgwMDA4MDdmNmQ5MjAwMC0weDAw
MDgwN2Y2ZGQyMDAwDQooWEVOKSBBbGxvY2F0aW5nIFBQSSAxNiBmb3IgZXZlbnQgY2hhbm5lbCBp
bnRlcnJ1cHQNCihYRU4pIExvYWRpbmcgekltYWdlIGZyb20gMDAwMDAwMDBmZTQ3YzAwMCB0byAw
MDAwMDAwMDk4MDAwMDAwLTAwMDAwMDAwOTk2YzMyMDANCihYRU4pIExvYWRpbmcgZDAgRFRCIHRv
IDB4MDAwMDAwMDBhMDAwMDAwMC0weDAwMDAwMDAwYTAwMDAyN2YNCihYRU4pIEluaXRpYWwgbG93
IG1lbW9yeSB2aXJxIHRocmVzaG9sZCBzZXQgYXQgMHg0MDAwIHBhZ2VzLg0KKFhFTikgU3RkLiBM
b2dsZXZlbDogQWxsDQooWEVOKSBHdWVzdCBMb2dsZXZlbDogRXJyb3JzDQooWEVOKSAqKiogU2Vy
aWFsIGlucHV0IHRvIERPTTAgKHR5cGUgJ0NUUkwtYScgdGhyZWUgdGltZXMgdG8gc3dpdGNoIGlu
cHV0KQ0KKFhFTikgRnJlZWQgMzYwa0IgaW5pdCBtZW1vcnkuDQooWEVOKSBkMHYwOiB2R0lDRDog
dW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0DQooWEVO
KSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJ
Q0FDVElWRVI4DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAw
MDBmZmZmZmZmZiB0byBJQ0FDVElWRVIxMg0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3
b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMTYNCihYRU4pIGQwdjA6IHZH
SUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjIw
DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZm
ZiB0byBJQ0FDVElWRVIyNA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRl
IDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMjgNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhh
bmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjMyDQooWEVOKSBk
MHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FD
VElWRVIzNg0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAw
ZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNDANCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29y
ZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjQ0DQooWEVOKSBkMHYwOiB2R0lD
RDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0OA0K
KFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYg
dG8gSUNBQ1RJVkVSNTINCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAw
eDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjU2DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5k
bGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI2MA0KKFhFTikgZDB2
MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJ
VkVSNjQNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZm
ZmZmZmZmIHRvIElDQUNUSVZFUjY4DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQg
d3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI3Mg0KKFhFTikgZDB2MDogdkdJQ0Q6
IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNzYNCihY
RU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRv
IElDQUNUSVZFUjgwDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgw
MDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI4NA0KKFhFTikgZDB2MDogdkdJQ1I6IFNHSTogdW5o
YW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQpbICAgIDAu
MDAwMDAwXSBCb290aW5nIExpbnV4IG9uIHBoeXNpY2FsIENQVSAweDAwMDAwMDAwMDAgWzB4NDEz
ZmQwYzFdDQpbICAgIDAuMDAwMDAwXSBMaW51eCB2ZXJzaW9uIDUuMTAuMjctYW1wZXJlLWx0cy1z
dGFuZGFyZCsgKG9lLXVzZXJAb2UtaG9zdCkgKGFhcmNoNjQtcG9reS1saW51eC1nY2MgKEdDQykg
MTEuMi4wLCBHTlUgbGQgKEdOVSBCaW51dGlscykgMi4zNy4yMDIxMDcyMSkgIzEgU01QIFBSRUVN
UFQgU2F0IFNlcCAxOCAwNjowMTo1OSBVVEMgMjAyMQ0KWyAgICAwLjAwMDAwMF0gWGVuIFhFTl9W
RVJTSU9OLlhFTl9TVUJWRVJTSU9OIHN1cHBvcnQgZm91bmQNClsgICAgMC4wMDAwMDBdIGVmaTog
RUZJIHYyLjUwIGJ5IFhlbg0KWyAgICAwLjAwMDAwMF0gZWZpOiBBQ1BJIDIuMD0weDgwN2Y2ZDky
MzM4IA0KWyAgICAwLjAwMDAwMF0gQUNQSTogRWFybHkgdGFibGUgY2hlY2tzdW0gdmVyaWZpY2F0
aW9uIGRpc2FibGVkDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBSU0RQIDB4MDAwMDA4MDdGNkQ5MjMz
OCAwMDAwMjQgKHYwMiBBbXBlcmUpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBYU0RUIDB4MDAwMDA4
MDdGNkQ5MjI4OCAwMDAwQUMgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAw
MDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEZBQ1AgMHgwMDAwMDgwN0Y2RDkyMDAwIDAwMDEx
NCAodjA2IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAw
MDAwMF0gQUNQSTogRFNEVCAweDAwMDAwODA3RjhEQjAwMTggMDJDMTlFICh2MDIgQW1wZXJlIEph
ZGUgICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBCRVJU
IDB4MDAwMDA4MDdGQTBERkY5OCAwMDAwMzAgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIg
QU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IERCRzIgMHgwMDAwMDgwN0ZBMERG
QTk4IDAwMDA1QyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0K
WyAgICAwLjAwMDAwMF0gQUNQSTogR1REVCAweDAwMDAwODA3RkEwREU5OTggMDAwMTEwICh2MDMg
QW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBB
Q1BJOiBTUENSIDB4MDAwMDA4MDdGQTBERkUxOCAwMDAwNTAgKHYwMiBBbXBlcmUgQWx0cmEgICAg
MDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEVJTkogMHgwMDAw
MDgwN0ZBMERGNTk4IDAwMDE1MCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIw
MjAxMjE3KQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogSEVTVCAweDAwMDAwODA3RkEwREVCMTggMDAw
MUY0ICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBTU0RUIDB4MDAwMDA4MDdGQTBERkExOCAwMDAwMkQgKHYwMiBBbXBlcmUg
QWx0cmEgICAgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFRQ
TTIgMHgwMDAwMDgwN0ZBMERGRDE4IDAwMDA0QyAodjA0IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAw
MiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogTUNGRyAweDAwMDAwODA3RkEw
REY3MTggMDAwMDdDICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIEFNUC4gMDEwMDAwMTMp
DQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBJT1JUIDB4MDAwMDA4MDdGQTBERUYxOCAwMDAzREMgKHYw
MCBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBd
IEFDUEk6IEFQSUMgMHgwMDAwMDgwN0Y2RDkyMTE4IDAwMDE0NCAodjA1IEFtcGVyZSBBbHRyYSAg
ICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogUFBUVCAweDAw
MDAwODA3RkEwRDg2MTggMDA0NTIwICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4g
MDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTTElUIDB4MDAwMDA4MDdGQTBERkQ5OCAw
MDAwMkQgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAg
MC4wMDAwMDBdIEFDUEk6IFNSQVQgMHgwMDAwMDgwN0ZBMERDRTE4IDAwMDM3MCAodjAzIEFtcGVy
ZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTog
UENDVCAweDAwMDAwODA3RkEwREUzMTggMDAwNTc2ICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAw
MDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTVEFPIDB4MDAwMDA4MDdG
NkQ5MjI2MCAwMDAwMjUgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAx
MykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1I6IGNvbnNvbGU6IHBsMDExLG1taW8zMiwweDEw
MDAwMjYwMDAwMCwxMTUyMDANClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0g
MCBbbWVtIDB4ODgzMDAwMDAtMHg4ODNmZmZmZl0NClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6
IE5vZGUgMCBQWE0gMCBbbWVtIDB4OTAwMDAwMDAtMHhmZmZmZmZmZl0NClsgICAgMC4wMDAwMDBd
IEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODAwMDAwMDAwMDAtMHg4MDA3ZmZmZmZm
Zl0NClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODAxMDAw
MDAwMDAtMHg4MDdmZmZmZmZmZl0NClsgICAgMC4wMDAwMDBdIE5VTUE6IE5PREVfREFUQSBbbWVt
IDB4ODA3OWVmZWVlMDAtMHg4MDc5ZWZmMGZmZl0NClsgICAgMC4wMDAwMDBdIFpvbmUgcmFuZ2Vz
Og0KWyAgICAwLjAwMDAwMF0gICBETUEgICAgICBbbWVtIDB4MDAwMDAwMDA5ODAwMDAwMC0weDAw
MDAwMDAwZmZmZmZmZmZdDQpbICAgIDAuMDAwMDAwXSAgIERNQTMyICAgIGVtcHR5DQpbICAgIDAu
MDAwMDAwXSAgIE5vcm1hbCAgIFttZW0gMHgwMDAwMDAwMTAwMDAwMDAwLTB4MDAwMDA4MDdmYTBk
ZmZmZl0NClsgICAgMC4wMDAwMDBdIE1vdmFibGUgem9uZSBzdGFydCBmb3IgZWFjaCBub2RlDQpb
ICAgIDAuMDAwMDAwXSBFYXJseSBtZW1vcnkgbm9kZSByYW5nZXMNClsgICAgMC4wMDAwMDBdICAg
bm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMDk4MDAwMDAwLTB4MDAwMDAwMDBmN2ZmZmZmZl0NClsg
ICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwMDAwMDAwMDAwLTB4MDAwMDA4
MDA3ZmZmZmZmZl0NClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwNjgw
MDAwMDAwLTB4MDAwMDA4MDc5ZmZmZmZmZl0NClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFtt
ZW0gMHgwMDAwMDgwN2Y2ZDkyMDAwLTB4MDAwMDA4MDdmNmQ5MmZmZl0NClsgICAgMC4wMDAwMDBd
ICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4ZGIwMDAwLTB4MDAwMDA4MDdmOGRkZmZmZl0N
ClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhMGQwMDAwLTB4MDAw
MDA4MDdmYTBkZmZmZl0NClsgICAgMC4wMDAwMDBdIEluaXRtZW0gc2V0dXAgbm9kZSAwIFttZW0g
MHgwMDAwMDAwMDk4MDAwMDAwLTB4MDAwMDA4MDdmYTBkZmZmZl0NClsgICAgMC4wMDAwMDBdIHBz
Y2k6IHByb2JpbmcgZm9yIGNvbmR1aXQgbWV0aG9kIGZyb20gQUNQSS4NClsgICAgMC4wMDAwMDBd
IHBzY2k6IFBTQ0l2MS4xIGRldGVjdGVkIGluIGZpcm13YXJlLg0KWyAgICAwLjAwMDAwMF0gcHNj
aTogVXNpbmcgc3RhbmRhcmQgUFNDSSB2MC4yIGZ1bmN0aW9uIElEcw0KWyAgICAwLjAwMDAwMF0g
cHNjaTogVHJ1c3RlZCBPUyBtaWdyYXRpb24gbm90IHJlcXVpcmVkDQpbICAgIDAuMDAwMDAwXSBw
c2NpOiBTTUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjENClsgICAgMC4wMDAwMDBdIHBlcmNwdTog
RW1iZWRkZWQgMzEgcGFnZXMvY3B1IHM4OTI0MCByODE5MiBkMjk1NDQgdTEyNjk3Ng0KWyAgICAw
LjAwMDAwMF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTANClsgICAgMC4wMDAwMDBdIENQ
VSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEdJQyBzeXN0ZW0gcmVnaXN0ZXIgQ1BVIGludGVyZmFjZQ0K
WyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogSGFyZHdhcmUgZGlydHkgYml0
IG1hbmFnZW1lbnQNClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFNwZWN0
cmUtdjQNClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEFSTSBlcnJhdHVt
IDE0MTgwNDANClsgICAgMC4wMDAwMDBdIEJ1aWx0IDEgem9uZWxpc3RzLCBtb2JpbGl0eSBncm91
cGluZyBvbi4gIFRvdGFsIHBhZ2VzOiAyMDY0NDQ3DQpbICAgIDAuMDAwMDAwXSBQb2xpY3kgem9u
ZTogTm9ybWFsDQpbICAgIDAuMDAwMDAwXSBLZXJuZWwgY29tbWFuZCBsaW5lOiBjb25zb2xlPWh2
YzAgZWFybHljb249eGVuIHJvb3R3YWl0IHJvb3Q9UEFSVFVVSUQ9NmE2MDUyNGQtMDYxZC00NTRh
LWJmZDEtMzg5ODk5MTBlY2NkDQpbICAgIDAuMDAwMDAwXSBEZW50cnkgY2FjaGUgaGFzaCB0YWJs
ZSBlbnRyaWVzOiAxMDQ4NTc2IChvcmRlcjogMTEsIDgzODg2MDggYnl0ZXMsIGxpbmVhcikNClsg
ICAgMC4wMDAwMDBdIElub2RlLWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogNTI0Mjg4IChvcmRl
cjogMTAsIDQxOTQzMDQgYnl0ZXMsIGxpbmVhcikNClsgICAgMC4wMDAwMDBdIG1lbSBhdXRvLWlu
aXQ6IHN0YWNrOm9mZiwgaGVhcCBhbGxvYzpvZmYsIGhlYXAgZnJlZTpvZmYNClsgICAgMC4wMDAw
MDBdIHNvZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgwMDAwMDAwMGY0MDAwMDAwLTB4MDAw
MDAwMDBmODAwMDAwMF0gKDY0TUIpDQpbICAgIDAuMDAwMDAwXSBNZW1vcnk6IDgxMDU3NjBLLzgz
ODg4NjhLIGF2YWlsYWJsZSAoMTM1NjhLIGtlcm5lbCBjb2RlLCAxOTk2SyByd2RhdGEsIDM0NzZL
IHJvZGF0YSwgNDE2MEsgaW5pdCwgODIySyBic3MsIDI4MzEwOEsgcmVzZXJ2ZWQsIDBLIGNtYS1y
ZXNlcnZlZCkNClsgICAgMC4wMDAwMDBdIFNMVUI6IEhXYWxpZ249NjQsIE9yZGVyPTAtMywgTWlu
T2JqZWN0cz0wLCBDUFVzPTEsIE5vZGVzPTENClsgICAgMC4wMDAwMDBdIGZ0cmFjZTogYWxsb2Nh
dGluZyA0MTMwNiBlbnRyaWVzIGluIDE2MiBwYWdlcw0KWyAgICAwLjAwMDAwMF0gZnRyYWNlOiBh
bGxvY2F0ZWQgMTYyIHBhZ2VzIHdpdGggMyBncm91cHMNClsgICAgMC4wMDAwMDBdIHJjdTogUHJl
ZW1wdGlibGUgaGllcmFyY2hpY2FsIFJDVSBpbXBsZW1lbnRhdGlvbi4NClsgICAgMC4wMDAwMDBd
IHJjdTogCVJDVSBldmVudCB0cmFjaW5nIGlzIGVuYWJsZWQuDQpbICAgIDAuMDAwMDAwXSByY3U6
IAlSQ1UgcmVzdHJpY3RpbmcgQ1BVcyBmcm9tIE5SX0NQVVM9MjU2IHRvIG5yX2NwdV9pZHM9MS4N
ClsgICAgMC4wMDAwMDBdIAlUcmFtcG9saW5lIHZhcmlhbnQgb2YgVGFza3MgUkNVIGVuYWJsZWQu
DQpbICAgIDAuMDAwMDAwXSAJUnVkZSB2YXJpYW50IG9mIFRhc2tzIFJDVSBlbmFibGVkLg0KWyAg
ICAwLjAwMDAwMF0gCVRyYWNpbmcgdmFyaWFudCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4NClsgICAg
MC4wMDAwMDBdIHJjdTogUkNVIGNhbGN1bGF0ZWQgdmFsdWUgb2Ygc2NoZWR1bGVyLWVubGlzdG1l
bnQgZGVsYXkgaXMgMjUgamlmZmllcy4NClsgICAgMC4wMDAwMDBdIHJjdTogQWRqdXN0aW5nIGdl
b21ldHJ5IGZvciByY3VfZmFub3V0X2xlYWY9MTYsIG5yX2NwdV9pZHM9MQ0KWyAgICAwLjAwMDAw
MF0gTlJfSVJRUzogNjQsIG5yX2lycXM6IDY0LCBwcmVhbGxvY2F0ZWQgaXJxczogMA0KWyAgICAw
LjAwMDAwMF0gR0lDdjM6IDY3MiBTUElzIGltcGxlbWVudGVkDQpbICAgIDAuMDAwMDAwXSBHSUN2
MzogMCBFeHRlbmRlZCBTUElzIGltcGxlbWVudGVkDQpbICAgIDAuMDAwMDAwXSBHSUN2MzogRGlz
dHJpYnV0b3IgaGFzIG5vIFJhbmdlIFNlbGVjdG9yIHN1cHBvcnQNClsgICAgMC4wMDAwMDBdIEdJ
Q3YzOiAxNiBQUElzIGltcGxlbWVudGVkDQpbICAgIDAuMDAwMDAwXSBHSUN2MzogQ1BVMDogZm91
bmQgcmVkaXN0cmlidXRvciAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDE0MDAwMA0KWyAgICAwLjAw
MDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDAgLT4gTm9kZSAwDQpbICAgIDAuMDAwMDAwXSBTUkFU
OiBQWE0gMCAtPiBJVFMgMSAtPiBOb2RlIDANClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+
IElUUyAyIC0+IE5vZGUgMA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDMgLT4g
Tm9kZSAwDQpbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNCAtPiBOb2RlIDANClsg
ICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA1IC0+IE5vZGUgMA0KWyAgICAwLjAwMDAw
MF0gU1JBVDogUFhNIDAgLT4gSVRTIDYgLT4gTm9kZSAwDQpbICAgIDAuMDAwMDAwXSBTUkFUOiBQ
WE0gMCAtPiBJVFMgNyAtPiBOb2RlIDANClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAw
MDQwMDAwLTB4MTAwMTAwMDVmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA0
MDAwMDogRGV2aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAu
MDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMg
QDgwMDAwODAwMDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAw
XSBJVFNAMHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxl
Y3Rpb25zIEA4MDAwMDE5MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAw
LjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwNjAwMDAtMHgxMDAxMDAwN2ZmZmZdDQpbICAgIDAu
MDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMDYwMDAwOiBEZXZpY2VzIFRhYmxlIHRvbyBsYXJnZSwg
cmVkdWNlIGlkcyAyMC0+MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwNjAwMDA6
IGFsbG9jYXRlZCA1MjQyODggRGV2aWNlcyBAODAwMDBjMDAwMDAgKGZsYXQsIGVzeiA4LCBwc3og
NjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwNjAwMDA6IGFsbG9j
YXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMWIwMDAwIChmbGF0LCBlc3og
MiwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDA4MDAw
MC0weDEwMDEwMDA5ZmZmZl0NClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwODAwMDA6
IERldmljZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRzIDIwLT4xOQ0KWyAgICAwLjAwMDAw
MF0gSVRTQDB4MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDUyNDI4OCBEZXZpY2VzIEA4MDAw
MTAwMDAwMCAoZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRT
QDB4MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9u
cyBAODAwMDAxZDAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAw
MDBdIElUUyBbbWVtIDB4MTAwMTAwMGEwMDAwLTB4MTAwMTAwMGJmZmZmXQ0KWyAgICAwLjAwMDAw
MF0gSVRTQDB4MDAwMDEwMDEwMDBhMDAwMDogRGV2aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVj
ZSBpZHMgMjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGEwMDAwOiBhbGxv
Y2F0ZWQgNTI0Mjg4IERldmljZXMgQDgwMDAxNDAwMDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0Sywg
c2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGEwMDAwOiBhbGxvY2F0ZWQg
MzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDFmMDAwMCAoZmxhdCwgZXN6IDIsIHBz
eiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwYzAwMDAtMHgx
MDAxMDAwZGZmZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGMwMDAwOiBEZXZp
Y2VzIFRhYmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAyMC0+MTkNClsgICAgMC4wMDAwMDBdIElU
U0AweDAwMDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCA1MjQyODggRGV2aWNlcyBAODAwMDE4MDAw
MDAgKGZsYXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgw
MDAwMjEwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJ
VFMgW21lbSAweDEwMDEwMDBlMDAwMC0weDEwMDEwMDBmZmZmZl0NClsgICAgMC4wMDAwMDBdIElU
U0AweDAwMDAxMDAxMDAwZTAwMDA6IERldmljZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRz
IDIwLT4xOQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBlMDAwMDogYWxsb2NhdGVk
IDUyNDI4OCBEZXZpY2VzIEA4MDAwMWMwMDAwMCAoZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNociAx
KQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBlMDAwMDogYWxsb2NhdGVkIDMyNzY4
IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAyMzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRL
LCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMTAwMDAwLTB4MTAwMTAw
MTFmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEwMDAwMDogRGV2aWNlcyBU
YWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgw
MDAwMTAwMTAwMTAwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMgQDgwMDAyMDAwMDAwIChm
bGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMTAwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDI1
MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTIFtt
ZW0gMHgxMDAxMDAxMjAwMDAtMHgxMDAxMDAxM2ZmZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgw
MDAwMTAwMTAwMTIwMDAwOiBEZXZpY2VzIFRhYmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAyMC0+
MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMjAwMDA6IGFsbG9jYXRlZCA1MjQy
ODggRGV2aWNlcyBAODAwMDI0MDAwMDAgKGZsYXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkNClsg
ICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAxMjAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRl
cnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMjcwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hy
IDEpDQpbICAgIDAuMDAwMDAwXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0N
ClsgICAgMC4wMDAwMDBdIFdBUk5JTkc6IENQVTogMCBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlw
L2lycS1naWMtdjMtaXRzLmM6MjI0NyBpdHNfaW5pdCsweDM5OC8weDY5MA0KWyAgICAwLjAwMDAw
MF0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDAuMDAwMDAwXSBDUFU6IDAgUElEOiAwIENvbW06
IHN3YXBwZXIvMCBOb3QgdGFpbnRlZCA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpb
ICAgIDAuMDAwMDAwXSBwc3RhdGU6IDYwMDAwMDg1IChuWkN2IGRhSWYgLVBBTiAtVUFPIC1UQ08g
QlRZUEU9LS0pDQpbICAgIDAuMDAwMDAwXSBwYyA6IGl0c19pbml0KzB4Mzk4LzB4NjkwDQpbICAg
IDAuMDAwMDAwXSBsciA6IGl0c19pbml0KzB4Mzk0LzB4NjkwDQpbICAgIDAuMDAwMDAwXSBzcCA6
IGZmZmY4MDAwMTE0ZDNjNTANClsgICAgMC4wMDAwMDBdIHgyOTogZmZmZjgwMDAxMTRkM2M1MCB4
Mjg6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4Mjc6IGZmZmY4MDAwMTE0ZGM5
YzAgeDI2OiBmZmZmMDdmZjgwMTBhOTAwIA0KWyAgICAwLjAwMDAwMF0geDI1OiAwMDAwMDAwMDAw
MDAwMDAwIHgyNDogZmZmZjA4MDcxZWZkZDBjMCANClsgICAgMC4wMDAwMDBdIHgyMzogZmZmZjgw
MDAxMTYyMjM1MCB4MjI6IGZmZmYwN2ZmODAxMGU0MDAgDQpbICAgIDAuMDAwMDAwXSB4MjE6IGZm
ZmY4MDAwMTE0ZGM5YzAgeDIwOiBmZmZmODAwMDExNjIyMDAwIA0KWyAgICAwLjAwMDAwMF0geDE5
OiBmZmZmODAwMDExNzY4OWY4IHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMC4wMDAwMDBd
IHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDAuMDAw
MDAwXSB4MTU6IGZmZmYwN2ZmODAxNzZmMWQgeDE0OiAwMDAwMDAwMDAwMDAwMDU4IA0KWyAgICAw
LjAwMDAwMF0geDEzOiAwMDAwMDAwMDAwMDAwMGMwIHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsg
ICAgMC4wMDAwMDBdIHgxMTogMDAwMDAwMDAwMDAwMDAxMCB4MTA6IGZmZmY4MDAwMTE0ZmNmYjAg
DQpbICAgIDAuMDAwMDAwXSB4OSA6IGZmZmY4MDAwMTBkMzZkYzAgeDggOiBmZmZmMDdmZjgwMjkw
MDAwIA0KWyAgICAwLjAwMDAwMF0geDcgOiBhMmEyYTJhMmEyYTJhMmEyIHg2IDogZmZmZjAwMDAw
MDAwMDAwMCANClsgICAgMC4wMDAwMDBdIHg1IDogZmZmZmZkZmZmZmUwMDAwMCB4NCA6IGZmZmY4
MDAwMTE0ZGM5YzAgDQpbICAgIDAuMDAwMDAwXSB4MyA6IGZmZmY4MDAwMTE0ZGRhZjAgeDIgOiAw
MDAwMDAwMDAwMDAwMDNkIA0KWyAgICAwLjAwMDAwMF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgw
IDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMC4wMDAwMDBdIENhbGwgdHJhY2U6DQpbICAgIDAu
MDAwMDAwXSAgaXRzX2luaXQrMHgzOTgvMHg2OTANClsgICAgMC4wMDAwMDBdICBnaWNfaW5pdF9i
YXNlcysweDUyNC8weDU4NA0KWyAgICAwLjAwMDAwMF0gIGdpY19hY3BpX2luaXQrMHgxMzQvMHgy
NzgNClsgICAgMC4wMDAwMDBdICBhY3BpX21hdGNoX21hZHQrMHg1MC8weDg4DQpbICAgIDAuMDAw
MDAwXSAgYWNwaV90YWJsZV9wYXJzZV9lbnRyaWVzX2FycmF5KzB4MTY0LzB4MjRjDQpbICAgIDAu
MDAwMDAwXSAgYWNwaV90YWJsZV9wYXJzZV9lbnRyaWVzKzB4NDgvMHg3MA0KWyAgICAwLjAwMDAw
MF0gIGFjcGlfdGFibGVfcGFyc2VfbWFkdCsweDM0LzB4NDANClsgICAgMC4wMDAwMDBdICBfX2Fj
cGlfcHJvYmVfZGV2aWNlX3RhYmxlKzB4OTAvMHhlYw0KWyAgICAwLjAwMDAwMF0gIGlycWNoaXBf
aW5pdCsweDQwLzB4NGMNClsgICAgMC4wMDAwMDBdICBpbml0X0lSUSsweGQwLzB4MTA0DQpbICAg
IDAuMDAwMDAwXSAgc3RhcnRfa2VybmVsKzB4MzU0LzB4NTU0DQpbICAgIDAuMDAwMDAwXSByYW5k
b206IGdldF9yYW5kb21fYnl0ZXMgY2FsbGVkIGZyb20gX193YXJuKzB4MTI4LzB4MWMwIHdpdGgg
Y3JuZ19pbml0PTANClsgICAgMC4wMDAwMDBdIC0tLVsgZW5kIHRyYWNlIDAwMDAwMDAwMDAwMDAw
MDAgXS0tLQ0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IHVzaW5nIExQSSBwcm9wZXJ0eSB0YWJsZSBA
MHgwMDAwMDgwMDAwMjgwMDAwDQpbICAgIDAuMDAwMDAwXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJl
IF0tLS0tLS0tLS0tLS0NClsgICAgMC4wMDAwMDBdIFdBUk5JTkc6IENQVTogMCBQSUQ6IDAgYXQg
ZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMC4wMDAwMDBdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAwLjAwMDAwMF0g
Q1BVOiAwIFBJRDogMCBDb21tOiBzd2FwcGVyLzAgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAg
IDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMC4wMDAwMDBdIHBzdGF0ZTog
NjAwMDAwODUgKG5aQ3YgZGFJZiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMC4wMDAw
MDBdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDAuMDAwMDAwXSBsciA6IGl0
c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAwLjAwMDAwMF0gc3AgOiBmZmZmODAwMDExNGQz
YzgwDQpbICAgIDAuMDAwMDAwXSB4Mjk6IGZmZmY4MDAwMTE0ZDNjODAgeDI4OiAwMDAwMDAwMDAw
MDAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDI3OiAwMDAwMDAwMDAwMDAwMDAxIHgyNjogZmZmZjgw
MDAxMjAwMDA3MCANClsgICAgMC4wMDAwMDBdIHgyNTogZmZmZmZlMWZmZGUwYTQwMCB4MjQ6IGZm
ZmY4MDAwMTIwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIy
OiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAwLjAwMDAwMF0geDIxOiBmZmZmODAwMDExNzY4OWY4
IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMC4wMDAwMDBdIHgxOTogZmZmZjgwMDAxMTYy
MjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDAuMDAwMDAwXSB4MTc6IDAwMDAwMDAw
MDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDE1OiBmZmZm
ODAwMDkxNGQzOTY3IHgxNDogMDAwMDAwMDAwMDAwMDA1OCANClsgICAgMC4wMDAwMDBdIHgxMzog
MDAwMDAwMDAwMDAwMDBjMCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4
MTE6IDAwMDAwMDAwMDAwMDAwMTAgeDEwOiBmZmZmODAwMDExNGZjZmIwIA0KWyAgICAwLjAwMDAw
MF0geDkgOiBmZmZmODAwMDEwZDM2ZGMwIHg4IDogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMC4w
MDAwMDBdIHg3IDogZmZmZjA4MDcxZWZlZmJjMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAg
IDAuMDAwMDAwXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0K
WyAgICAwLjAwMDAwMF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZm
ZiANClsgICAgMC4wMDAwMDBdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZm
ZmZmZWQgDQpbICAgIDAuMDAwMDAwXSBDYWxsIHRyYWNlOg0KWyAgICAwLjAwMDAwMF0gIGl0c19j
cHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAwLjAwMDAwMF0gIGdpY19pbml0X2Jhc2VzKzB4NTI4
LzB4NTg0DQpbICAgIDAuMDAwMDAwXSAgZ2ljX2FjcGlfaW5pdCsweDEzNC8weDI3OA0KWyAgICAw
LjAwMDAwMF0gIGFjcGlfbWF0Y2hfbWFkdCsweDUwLzB4ODgNClsgICAgMC4wMDAwMDBdICBhY3Bp
X3RhYmxlX3BhcnNlX2VudHJpZXNfYXJyYXkrMHgxNjQvMHgyNGMNClsgICAgMC4wMDAwMDBdICBh
Y3BpX3RhYmxlX3BhcnNlX2VudHJpZXMrMHg0OC8weDcwDQpbICAgIDAuMDAwMDAwXSAgYWNwaV90
YWJsZV9wYXJzZV9tYWR0KzB4MzQvMHg0MA0KWyAgICAwLjAwMDAwMF0gIF9fYWNwaV9wcm9iZV9k
ZXZpY2VfdGFibGUrMHg5MC8weGVjDQpbICAgIDAuMDAwMDAwXSAgaXJxY2hpcF9pbml0KzB4NDAv
MHg0Yw0KWyAgICAwLjAwMDAwMF0gIGluaXRfSVJRKzB4ZDAvMHgxMDQNClsgICAgMC4wMDAwMDBd
ICBzdGFydF9rZXJuZWwrMHgzNTQvMHg1NTQNClsgICAgMC4wMDAwMDBdIC0tLVsgZW5kIHRyYWNl
IGY2ODcyOGEwZDMwNTNiNTIgXS0tLQ0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IENQVTA6IHVzaW5n
IGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwMjkwMDAwDQpbICAgIDAu
MDAwMDAwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJy
YXR1bSAxNDE4MDQwDQpbICAgIDAuMDAwMDAwXSBBQ1BJIEdURFQ6IGZvdW5kIDEgbWVtb3J5LW1h
cHBlZCB0aW1lciBibG9jayhzKS4NClsgICAgMC4wMDAwMDBdIGFyY2hfdGltZXI6IGNwMTUgYW5k
IG1taW8gdGltZXIocykgcnVubmluZyBhdCAyNS4wME1IeiAodmlydC9waHlzKS4NClsgICAgMC4w
MDAwMDBdIGNsb2Nrc291cmNlOiBhcmNoX3N5c19jb3VudGVyOiBtYXNrOiAweGZmZmZmZmZmZmZm
ZmZmIG1heF9jeWNsZXM6IDB4NWM0MDkzOWI1LCBtYXhfaWRsZV9uczogNDQwNzk1MjAyNjQ2IG5z
DQpbICAgIDAuMDAwMDAxXSBzY2hlZF9jbG9jazogNTYgYml0cyBhdCAyNU1IeiwgcmVzb2x1dGlv
biA0MG5zLCB3cmFwcyBldmVyeSA0Mzk4MDQ2NTExMTAwbnMNClsgICAgMC4wMDAwMzRdIENvbnNv
bGU6IGNvbG91ciBkdW1teSBkZXZpY2UgODB4MjUNClsgICAgMS4yNDI4MzZdIHByaW50azogY29u
c29sZSBbaHZjMF0gZW5hYmxlZA0KWyAgICAxLjI0NzAyMV0gQUNQSTogQ29yZSByZXZpc2lvbiAy
MDIwMDkyNQ0KWyAgICAxLjI1MTMzNF0gQUNQSSBCSU9TIFdhcm5pbmcgKGJ1Zyk6IEluY29ycmVj
dCBjaGVja3N1bSBpbiB0YWJsZSBbSU9SVF0gLSAweEYyLCBzaG91bGQgYmUgMHgwQiAoMjAyMDA5
MjUvdGJwcmludC0xNzMpDQpbICAgIDEuMjYxOTA5XSBDYWxpYnJhdGluZyBkZWxheSBsb29wIChz
a2lwcGVkKSwgdmFsdWUgY2FsY3VsYXRlZCB1c2luZyB0aW1lciBmcmVxdWVuY3kuLiA1MC4wMCBC
b2dvTUlQUyAobHBqPTEwMDAwMCkNClsgICAgMS4yNzIyNTddIHBpZF9tYXg6IGRlZmF1bHQ6IDMy
NzY4IG1pbmltdW06IDMwMQ0KWyAgICAxLjI3Njk2MV0gTFNNOiBTZWN1cml0eSBGcmFtZXdvcmsg
aW5pdGlhbGl6aW5nDQpbICAgIDEuMjgxNjkxXSBNb3VudC1jYWNoZSBoYXNoIHRhYmxlIGVudHJp
ZXM6IDE2Mzg0IChvcmRlcjogNSwgMTMxMDcyIGJ5dGVzLCBsaW5lYXIpDQpbICAgIDEuMjg5Mjkx
XSBNb3VudHBvaW50LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMTYzODQgKG9yZGVyOiA1LCAx
MzEwNzIgYnl0ZXMsIGxpbmVhcikNClsgICAgMS4yOTc5ODldIHhlbjpncmFudF90YWJsZTogR3Jh
bnQgdGFibGVzIHVzaW5nIHZlcnNpb24gMSBsYXlvdXQNClsgICAgMS4zMDM5MTZdIEdyYW50IHRh
YmxlIGluaXRpYWxpemVkDQpbICAgIDEuMzA3NDU2XSB4ZW46ZXZlbnRzOiBVc2luZyBGSUZPLWJh
c2VkIEFCSQ0KWyAgICAxLjMxMTgwN10gWGVuOiBpbml0aWFsaXppbmcgY3B1MA0KWyAgICAxLjMx
NTI5Nl0gcmN1OiBIaWVyYXJjaGljYWwgU1JDVSBpbXBsZW1lbnRhdGlvbi4NClsgICAgMS4zMjAy
NTZdIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAg
IDEuMzI1Nzc1XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDA2MDAwMCBkb21haW4gY3JlYXRl
ZA0KWyAgICAxLjMzMTQzM10gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9tYWlu
IGNyZWF0ZWQNClsgICAgMS4zMzcwNjNdIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAwMGEwMDAw
IGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzQyNjk1XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEw
MDBjMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjM0ODMzOF0gUGxhdGZvcm0gTVNJOiBJVFNA
MHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS4zNTM5NzldIFBsYXRmb3JtIE1T
STogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzU5NjIzXSBQbGF0
Zm9ybSBNU0k6IElUU0AweDEwMDEwMDEyMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjM2NTI2
N10gUENJL01TSTogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzcw
NDczXSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwNjAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS4z
NzU2ODFdIFBDSS9NU0k6IElUU0AweDEwMDEwMDA4MDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAx
LjM4MDg4OV0gUENJL01TSTogSVRTQDB4MTAwMTAwMGEwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAg
IDEuMzg2MDk4XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwYzAwMDAgZG9tYWluIGNyZWF0ZWQNClsg
ICAgMS4zOTEzMDZdIFBDSS9NU0k6IElUU0AweDEwMDEwMDBlMDAwMCBkb21haW4gY3JlYXRlZA0K
WyAgICAxLjM5NjUxNF0gUENJL01TSTogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBjcmVhdGVk
DQpbICAgIDEuNDAxNzIzXSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAxMjAwMDAgZG9tYWluIGNyZWF0
ZWQNClsgICAgMS40MDY5MzNdIEVGSSBydW50aW1lIHNlcnZpY2VzIGFjY2VzcyB2aWEgcGFyYXZp
cnQuDQpbICAgIDEuNDEyMDc2XSBzbXA6IEJyaW5naW5nIHVwIHNlY29uZGFyeSBDUFVzIC4uLg0K
WyAgICAxLjQxNjY1NV0gc21wOiBCcm91Z2h0IHVwIDEgbm9kZSwgMSBDUFUNClsgICAgMS40MjA3
MzNdIFNNUDogVG90YWwgb2YgMSBwcm9jZXNzb3JzIGFjdGl2YXRlZC4NClsgICAgMS40MjU1MDhd
IENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFByaXZpbGVnZWQgQWNjZXNzIE5ldmVyDQpbICAgIDEu
NDMxMTQ5XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBMU0UgYXRvbWljIGluc3RydWN0aW9ucw0K
WyAgICAxLjQzNjc5MV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogVXNlciBBY2Nlc3MgT3ZlcnJp
ZGUNClsgICAgMS40NDIxNzNdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IDMyLWJpdCBFTDAgU3Vw
cG9ydA0KWyAgICAxLjQ0NzM4MV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQ29tbW9uIG5vdCBQ
cml2YXRlIHRyYW5zbGF0aW9ucw0KWyAgICAxLjQ1MzcxOV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3Rl
ZDogRGF0YSBjYWNoZSBjbGVhbiB0byB0aGUgUG9VIG5vdCByZXF1aXJlZCBmb3IgSS9EIGNvaGVy
ZW5jZQ0KWyAgICAxLjQ2MjM5OV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQ1JDMzIgaW5zdHJ1
Y3Rpb25zDQpbICAgIDEuNDY3NjA3XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBTcGVjdWxhdGl2
ZSBTdG9yZSBCeXBhc3NpbmcgU2FmZSAoU1NCUykNClsgICAgMS41MDYzODBdIENQVTogQWxsIENQ
VShzKSBzdGFydGVkIGF0IEVMMQ0KWyAgICAxLjUxMDM3OF0gYWx0ZXJuYXRpdmVzOiBwYXRjaGlu
ZyBrZXJuZWwgY29kZQ0KWyAgICAxLjUxNTQzN10gZGV2dG1wZnM6IGluaXRpYWxpemVkDQpbICAg
IDEuNTE4ODkzXSBjbG9ja3NvdXJjZTogamlmZmllczogbWFzazogMHhmZmZmZmZmZiBtYXhfY3lj
bGVzOiAweGZmZmZmZmZmLCBtYXhfaWRsZV9uczogNzY0NTA0MTc4NTEwMDAwMCBucw0KWyAgICAx
LjUyODUzN10gZnV0ZXggaGFzaCB0YWJsZSBlbnRyaWVzOiAyNTYgKG9yZGVyOiAyLCAxNjM4NCBi
eXRlcywgbGluZWFyKQ0KWyAgICAxLjUzNTQ1OF0gRE1JIG5vdCBwcmVzZW50IG9yIGludmFsaWQu
DQpbICAgIDEuNTM5NDA5XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDE2DQpbICAg
IDEuNTQzOTQyXSBETUE6IHByZWFsbG9jYXRlZCAxMDI0IEtpQiBHRlBfS0VSTkVMIHBvb2wgZm9y
IGF0b21pYyBhbGxvY2F0aW9ucw0KWyAgICAxLjU1MTA1NV0gRE1BOiBwcmVhbGxvY2F0ZWQgMTAy
NCBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BIHBvb2wgZm9yIGF0b21pYyBhbGxvY2F0aW9ucw0KWyAg
ICAxLjU1ODk1M10gRE1BOiBwcmVhbGxvY2F0ZWQgMTAyNCBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1B
MzIgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zDQpbICAgIDEuNTY3MTU0XSB0aGVybWFsX3N5
czogUmVnaXN0ZXJlZCB0aGVybWFsIGdvdmVybm9yICdzdGVwX3dpc2UnDQpbICAgIDEuNTY3MjYz
XSBEZXRlY3RlZCAxNSBQQ0MgU3Vic3BhY2VzDQpbICAgIDEuNTc2OTIwXSBSZWdpc3RlcmluZyBQ
Q0MgZHJpdmVyIGFzIE1haWxib3ggY29udHJvbGxlcg0KWyAgICAxLjU4MjMwOF0gaHctYnJlYWtw
b2ludDogZm91bmQgNiBicmVha3BvaW50IGFuZCA0IHdhdGNocG9pbnQgcmVnaXN0ZXJzLg0KWyAg
ICAxLjU4OTE1Ml0gQVNJRCBhbGxvY2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVz
DQpbICAgIDEuNTk0NjEzXSBBQ1BJOiBidXMgdHlwZSBQQ0kgcmVnaXN0ZXJlZA0KWyAgICAxLjU5
ODY4OF0gU2VyaWFsOiBBTUJBIFBMMDExIFVBUlQgZHJpdmVyDQpbICAgIDEuNjA0NTI5XSBIdWdl
VExCIHJlZ2lzdGVyZWQgMS4wMCBHaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMN
ClsgICAgMS42MTExMzldIEh1Z2VUTEIgcmVnaXN0ZXJlZCAzMi4wIE1pQiBwYWdlIHNpemUsIHBy
ZS1hbGxvY2F0ZWQgMCBwYWdlcw0KWyAgICAxLjYxNzkwMl0gSHVnZVRMQiByZWdpc3RlcmVkIDIu
MDAgTWlCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzDQpbICAgIDEuNjI0Njc2XSBI
dWdlVExCIHJlZ2lzdGVyZWQgNjQuMCBLaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFn
ZXMNClsgICAgMS42MzE3OTBdIGNyeXB0ZDogbWF4X2NwdV9xbGVuIHNldCB0byAxMDAwDQpbICAg
IDEuNzA0MDA0XSByYWlkNjogbmVvbng4ICAgZ2VuKCkgIDc3MzkgTUIvcw0KWyAgICAxLjc3NjIx
MV0gcmFpZDY6IG5lb254OCAgIHhvcigpICA2MDY2IE1CL3MNClsgICAgMS44NDg0MTRdIHJhaWQ2
OiBuZW9ueDQgICBnZW4oKSAgNzYzNiBNQi9zDQpbICAgIDEuOTIwNjE1XSByYWlkNjogbmVvbng0
ICAgeG9yKCkgIDYzMjUgTUIvcw0KWyAgICAxLjk5MjgxOF0gcmFpZDY6IG5lb254MiAgIGdlbigp
ICA3MzA2IE1CL3MNClsgICAgMi4wNjUwMjBdIHJhaWQ2OiBuZW9ueDIgICB4b3IoKSAgNTc0NSBN
Qi9zDQpbICAgIDIuMTM3MjI4XSByYWlkNjogbmVvbngxICAgZ2VuKCkgIDU5ODIgTUIvcw0KWyAg
ICAyLjIwOTQyOV0gcmFpZDY6IG5lb254MSAgIHhvcigpICA0OTM1IE1CL3MNClsgICAgMi4yODE2
MzRdIHJhaWQ2OiBpbnQ2NHg4ICBnZW4oKSAgMzYwMyBNQi9zDQpbICAgIDIuMzUzODM4XSByYWlk
NjogaW50NjR4OCAgeG9yKCkgIDIwMTggTUIvcw0KWyAgICAyLjQyNjAzOV0gcmFpZDY6IGludDY0
eDQgIGdlbigpICA0MTMwIE1CL3MNClsgICAgMi40OTgyNDldIHJhaWQ2OiBpbnQ2NHg0ICB4b3Io
KSAgMjE5MyBNQi9zDQpbICAgIDIuNTcwNDU0XSByYWlkNjogaW50NjR4MiAgZ2VuKCkgIDM1MDIg
TUIvcw0KWyAgICAyLjY0MjY1NF0gcmFpZDY6IGludDY0eDIgIHhvcigpICAxODkxIE1CL3MNClsg
ICAgMi43MTQ4NjRdIHJhaWQ2OiBpbnQ2NHgxICBnZW4oKSAgMjg3NSBNQi9zDQpbICAgIDIuNzg3
MDY1XSByYWlkNjogaW50NjR4MSAgeG9yKCkgIDE1MDcgTUIvcw0KWyAgICAyLjc5MTIzMV0gcmFp
ZDY6IHVzaW5nIGFsZ29yaXRobSBuZW9ueDggZ2VuKCkgNzczOSBNQi9zDQpbICAgIDIuNzk2Njk5
XSByYWlkNjogLi4uLiB4b3IoKSA2MDY2IE1CL3MsIHJtdyBlbmFibGVkDQpbICAgIDIuODAxNzM0
XSByYWlkNjogdXNpbmcgbmVvbiByZWNvdmVyeSBhbGdvcml0aG0NClsgICAgMi44MDY0NThdIEFD
UEk6IEFkZGVkIF9PU0koTW9kdWxlIERldmljZSkNClsgICAgMi44MTA2NzddIEFDUEk6IEFkZGVk
IF9PU0koUHJvY2Vzc29yIERldmljZSkNClsgICAgMi44MTUxODldIEFDUEk6IEFkZGVkIF9PU0ko
My4wIF9TQ1AgRXh0ZW5zaW9ucykNClsgICAgMi44MTk5NjNdIEFDUEk6IEFkZGVkIF9PU0koUHJv
Y2Vzc29yIEFnZ3JlZ2F0b3IgRGV2aWNlKQ0KWyAgICAyLjgyNTQzMl0gQUNQSTogQWRkZWQgX09T
SShMaW51eC1EZWxsLVZpZGVvKQ0KWyAgICAyLjgyOTk0Nl0gQUNQSTogQWRkZWQgX09TSShMaW51
eC1MZW5vdm8tTlYtSERNSS1BdWRpbykNClsgICAgMi44MzUzMjhdIEFDUEk6IEFkZGVkIF9PU0ko
TGludXgtSFBJLUh5YnJpZC1HcmFwaGljcykNClsgICAgMi44NjA5NzhdIEFDUEk6IDIgQUNQSSBB
TUwgdGFibGVzIHN1Y2Nlc3NmdWxseSBhY3F1aXJlZCBhbmQgbG9hZGVkDQpbICAgIDIuODczNTA0
XSBBQ1BJOiBJbnRlcnByZXRlciBlbmFibGVkDQpbICAgIDIuODc3MDY3XSBBQ1BJOiBVc2luZyBH
SUMgZm9yIGludGVycnVwdCByb3V0aW5nDQpbICAgIDIuODgxODUyXSBBQ1BJOiBNQ0ZHIHRhYmxl
IGRldGVjdGVkLCA1IGVudHJpZXMNClsgICAgMi44ODY2MTFdIEhFU1Q6IFRhYmxlIHBhcnNpbmcg
aGFzIGJlZW4gaW5pdGlhbGl6ZWQuDQpbICAgIDIuOTM4MjI2XSBBUk1IMDAxMTowMDogdHR5QU1B
MCBhdCBNTUlPIDB4MTAwMDAyNjAwMDAwIChpcnEgPSA3OSwgYmFzZV9iYXVkID0gMCkgaXMgYSBT
QlNBDQpbICAgIDIuOTY1NjMzXSBwcmludGs6IGNvbnNvbGUgW3R0eUFNQTBdIGVuYWJsZWQNClsg
ICAgMi45NzE2MjJdIEFSTUgwMDExOjAxOiB0dHlBTUExIGF0IE1NSU8gMHgxMDAwMDI2MjAwMDAg
KGlycSA9IDgwLCBiYXNlX2JhdWQgPSAwKSBpcyBhIFNCU0ENClsgICAgMi45ODE5MzFdIEFDUEk6
IFBDSSBSb290IEJyaWRnZSBbUENJMF0gKGRvbWFpbiAwMDBjIFtidXMgMDAtZmZdKQ0KWyAgICAy
Ljk4ODA5Nl0gYWNwaSBQTlAwQTA4OjAwOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25m
aWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgIDIuOTk3Mjk3XSBh
Y3BpIFBOUDBBMDg6MDA6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3Rp
bmcgX09TQyBjb250cm9sDQpbICAgIDMuMDA1MTIxXSBhY3BpIFBOUDBBMDg6MDA6IE1DRkcgcXVp
cms6IEVDQU0gYXQgW21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMg
MDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwDQpbICAgIDMuMDE4MDMxXSBhY3BpIFBOUDBB
MDg6MDA6IEVDQU0gYXJlYSBbbWVtIDB4MzNmZmYwMDAwMDAwLTB4MzNmZmZmZmZmZmZmXSByZXNl
cnZlZCBieSBQTlAwQzAyOjAwDQpbICAgIDMuMDI2OTE3XSBhY3BpIFBOUDBBMDg6MDA6IEVDQU0g
YXQgW21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpb
ICAgIDMuMDM1MTM2XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGM6MDANClsgICAgMy4wMzkx
ODBdIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDQwMDAwMDAwLTB4
NGZmZmZmZmYgd2luZG93XQ0KWyAgICAzLjA0Njc3MF0gcGNpX2J1cyAwMDBjOjAwOiByb290IGJ1
cyByZXNvdXJjZSBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzNmZmRmZmZmZmZmIHdpbmRvd10NClsg
ICAgMy4wNTUwMjVdIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1m
Zl0NClsgICAgMy4wNjA1OTVdIHBjaSAwMDBjOjAwOjAwLjA6IFsxZGVmOmUxMDBdIHR5cGUgMDAg
Y2xhc3MgMHgwNjAwMDANClsgICAgMy4wNjY3MDRdIHBjaSAwMDBjOjAwOjAwLjA6IEZhaWxlZCB0
byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgMy4wNzQz
MDldIHBjaSAwMDBjOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAN
ClsgICAgMy4wODAzOTZdIHBjaSAwMDBjOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgIDMu
MDg0NjY1XSBwY2kgMDAwYzowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90
DQpbICAgIDMuMDkwNTMzXSBwY2kgMDAwYzowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Ro
cm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDMuMDk5MjY2XSBwY2kgMDAwYzow
MDowMS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMV0gYWRk
X3NpemUgMTAwMA0KWyAgICAzLjEwNzQzN10gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxXSBhZGRf
c2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgICAzLjExOTAyMV0gcGNpIDAwMGM6MDA6
MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAw
MV0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAgMy4xMjk2MDJdIHBjaSAw
MDBjOjAwOjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0N
ClsgICAgMy4xMzY0MTRdIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4
MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDMuMTQ0OTQwXSBw
Y2kgMDAwYzowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpb
ICAgIDMuMTUxMjUwXSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQ0KWyAgICAzLjE1NzkzOV0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6
IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICAzLjE2NDI3MV0gcGNpIDAwMGM6
MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAg
My4xNzA5NjBdIHBjaSAwMDBjOjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMV0NClsgICAg
My4xNzU5NzRdIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NDAwMDAw
MDAtMHg0MDFmZmZmZl0NClsgICAgMy4xODI4NTRdIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdDQpb
ICAgIDMuMTkxMzgyXSBwY2lfYnVzIDAwMGM6MDA6IHJlc291cmNlIDQgW21lbSAweDQwMDAwMDAw
LTB4NGZmZmZmZmYgd2luZG93XQ0KWyAgICAzLjE5ODMwNF0gcGNpX2J1cyAwMDBjOjAwOiByZXNv
dXJjZSA1IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzM2ZmZGZmZmZmZmYgd2luZG93XQ0KWyAgICAz
LjIwNTk1Ml0gcGNpX2J1cyAwMDBjOjAxOiByZXNvdXJjZSAxIFttZW0gMHg0MDAwMDAwMC0weDQw
MWZmZmZmXQ0KWyAgICAzLjIxMjI3NF0gcGNpX2J1cyAwMDBjOjAxOiByZXNvdXJjZSAyIFttZW0g
MHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgMy4yMjAzMjFd
IEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJMV0gKGRvbWFpbiAwMDBkIFtidXMgMDAtZmZdKQ0K
WyAgICAzLjIyNjUxOF0gYWNwaSBQTlAwQTA4OjAxOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5k
ZWRDb25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgIDMuMjM1
NzI1XSBhY3BpIFBOUDBBMDg6MDE6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJl
cXVlc3RpbmcgX09TQyBjb250cm9sDQpbICAgIDMuMjQzNTQ2XSBhY3BpIFBOUDBBMDg6MDE6IE1D
RkcgcXVpcms6IEVDQU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZmZl0gZm9y
IFtidXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwDQpbICAgIDMuMjU2NDYwXSBhY3Bp
IFBOUDBBMDg6MDE6IEVDQU0gYXJlYSBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZm
XSByZXNlcnZlZCBieSBQTlAwQzAyOjAwDQpbICAgIDMuMjY1MzQ0XSBhY3BpIFBOUDBBMDg6MDE6
IEVDQU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAt
ZmZdDQpbICAgIDMuMjczNTU1XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGQ6MDANClsgICAg
My4yNzc2MDRdIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDUwMDAw
MDAwLTB4NWZmZmZmZmYgd2luZG93XQ0KWyAgICAzLjI4NTE5NV0gcGNpX2J1cyAwMDBkOjAwOiBy
b290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzdmZmRmZmZmZmZmIHdpbmRv
d10NClsgICAgMy4yOTM0NTBdIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1
cyAwMC1mZl0NClsgICAgMy4yOTkwMTVdIHBjaSAwMDBkOjAwOjAwLjA6IFsxZGVmOmUxMDBdIHR5
cGUgMDAgY2xhc3MgMHgwNjAwMDANClsgICAgMy4zMDUxMDddIHBjaSAwMDBkOjAwOjAwLjA6IEZh
aWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAg
My4zMTI3MjldIHBjaSAwMDBkOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgw
NjA0MDANClsgICAgMy4zMTg4MDZdIHBjaSAwMDBkOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpb
ICAgIDMuMzIzMDkwXSBwY2kgMDAwZDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQx
IEQzaG90DQpbICAgIDMuMzI4OTU2XSBwY2kgMDAwZDowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0g
cGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDMuMzM2NjU5XSBwY2kg
MDAwZDowMTowMC4wOiBbMTBkZToxZTg5XSB0eXBlIDAwIGNsYXNzIDB4MDMwMDAwDQpbICAgIDMu
MzQyNjUyXSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxMDogW21lbSAweDUwMDAwMDAwLTB4NTBm
ZmZmZmZdDQpbICAgIDMuMzQ4OTkwXSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxNDogW21lbSAw
eDM0MDAwMDAwMDAwMC0weDM0MDAwZmZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICAzLjM1Njk5Nl0g
cGNpIDAwMGQ6MDE6MDAuMDogcmVnIDB4MWM6IFttZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAwMTFm
ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgMy4zNjQ5NzldIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAw
eDI0OiBbaW8gIDB4NTdmZmUwMDAtMHg1N2ZmZTA3Zl0NClsgICAgMy4zNzEyOTVdIHBjaSAwMDBk
OjAxOjAwLjA6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQ0KWyAg
ICAzLjM3ODEyOV0gcGNpIDAwMGQ6MDE6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hv
dCBEM2NvbGQNClsgICAgMy4zODQyNzVdIHBjaSAwMDBkOjAxOjAwLjA6IEZhaWxlZCB0byBhZGQg
LSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgMy4zOTE5MDFdIHBj
aSAwMDBkOjAxOjAwLjE6IFsxMGRlOjEwZjhdIHR5cGUgMDAgY2xhc3MgMHgwNDAzMDANClsgICAg
My4zOTc5NDddIHBjaSAwMDBkOjAxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4NTEwMDAwMDAtMHg1
MTAwM2ZmZl0NClsgICAgMy40MDQzNzddIHBjaSAwMDBkOjAxOjAwLjE6IEZhaWxlZCB0byBhZGQg
LSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgMy40MTE5NTBdIHBj
aSAwMDBkOjAxOjAwLjI6IFsxMGRlOjFhZDhdIHR5cGUgMDAgY2xhc3MgMHgwYzAzMzANClsgICAg
My40MTgwMDNdIHBjaSAwMDBkOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4MzQwMDEyMDAwMDAw
LTB4MzQwMDEyMDNmZmZmIDY0Yml0IHByZWZdDQpbICAgIDMuNDI2MDEwXSBwY2kgMDAwZDowMTow
MC4yOiByZWcgMHgxYzogW21lbSAweDM0MDAxMjA0MDAwMC0weDM0MDAxMjA0ZmZmZiA2NGJpdCBw
cmVmXQ0KWyAgICAzLjQzNDAzNV0gcGNpIDAwMGQ6MDE6MDAuMjogUE1FIyBzdXBwb3J0ZWQgZnJv
bSBEMCBEM2hvdCBEM2NvbGQNClsgICAgMy40NDAxNjNdIHBjaSAwMDBkOjAxOjAwLjI6IEZhaWxl
ZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgMy40
NDc4MDBdIHBjaSAwMDBkOjAxOjAwLjM6IFsxMGRlOjFhZDldIHR5cGUgMDAgY2xhc3MgMHgwYzgw
MDANClsgICAgMy40NTM4NTBdIHBjaSAwMDBkOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVtIDB4NTEw
MDQwMDAtMHg1MTAwNGZmZl0NClsgICAgMy40NjAyNDldIHBjaSAwMDBkOjAxOjAwLjM6IFBNRSMg
c3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAgIDMuNDY2Mzc3XSBwY2kgMDAwZDow
MTowMC4zOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZh
aWwhDQpbICAgIDMuNDc0MDE3XSBwY2kgMDAwZDowMDowMS4wOiBBU1BNOiBjdXJyZW50IGNvbW1v
biBjbG9jayBjb25maWd1cmF0aW9uIGlzIGluY29uc2lzdGVudCwgcmVjb25maWd1cmluZw0KWyAg
ICAzLjQ5NTM5NV0gcGNpIDAwMGQ6MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgzNDAw
MDAwMDAwMDAtMHgzNDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgMy41MDM4MzFdIHBjaSAw
MDBkOjAwOjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0N
ClsgICAgMy41MTA2NjldIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lv
ICBzaXplIDB4MTAwMF0NClsgICAgMy41MTcwMDVdIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA3OiBm
YWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDMuNTIzNjkwXSBwY2kgMDAw
ZDowMTowMC4wOiBCQVIgMTogYXNzaWduZWQgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAwZmZm
ZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICAzLjUzMjIyMl0gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDM6
IGFzc2lnbmVkIFttZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAwMTFmZmZmZmYgNjRiaXQgcHJlZl0N
ClsgICAgMy41NDA3MjldIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4
NTAwMDAwMDAtMHg1MGZmZmZmZl0NClsgICAgMy41NDc1NjNdIHBjaSAwMDBkOjAxOjAwLjA6IEJB
UiA2OiBhc3NpZ25lZCBbbWVtIDB4NTEwMDAwMDAtMHg1MTA3ZmZmZiBwcmVmXQ0KWyAgICAzLjU1
NDg1OF0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTIwMDAw
MDAtMHgzNDAwMTIwM2ZmZmYgNjRiaXQgcHJlZl0NClsgICAgMy41NjMzODZdIHBjaSAwMDBkOjAx
OjAwLjI6IEJBUiAzOiBhc3NpZ25lZCBbbWVtIDB4MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRmZmZm
IDY0Yml0IHByZWZdDQpbICAgIDMuNTcxODkyXSBwY2kgMDAwZDowMTowMC4xOiBCQVIgMDogYXNz
aWduZWQgW21lbSAweDUxMDgwMDAwLTB4NTEwODNmZmZdDQpbICAgIDMuNTc4NzI2XSBwY2kgMDAw
ZDowMTowMC4zOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDUxMDg0MDAwLTB4NTEwODRmZmZdDQpb
ICAgIDMuNTg1NTg0XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNTogbm8gc3BhY2UgZm9yIFtpbyAg
c2l6ZSAweDAwODBdDQpbICAgIDMuNTkxOTEyXSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNTogZmFp
bGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgwMDgwXQ0KWyAgICAzLjU5ODYwMV0gcGNpIDAwMGQ6
MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQ0KWyAgICAzLjYwMzYxNV0gcGNpIDAwMGQ6
MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHg1MDAwMDAwMC0weDUxN2ZmZmZmXQ0KWyAg
ICAzLjYxMDQ5NV0gcGNpIDAwMGQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzNDAw
MDAwMDAwMDAtMHgzNDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgMy42MTkwMjNdIHBjaV9i
dXMgMDAwZDowMDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5
IGJvb3Rpbmcgd2l0aCBwY2k9cmVhbGxvYw0KWyAgICAzLjYyODE0NF0gcGNpX2J1cyAwMDBkOjAw
OiByZXNvdXJjZSA0IFttZW0gMHg1MDAwMDAwMC0weDVmZmZmZmZmIHdpbmRvd10NClsgICAgMy42
MzUwNjBdIHBjaV9idXMgMDAwZDowMDogcmVzb3VyY2UgNSBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4
MzdmZmRmZmZmZmZmIHdpbmRvd10NClsgICAgMy42NDI3MDddIHBjaV9idXMgMDAwZDowMTogcmVz
b3VyY2UgMSBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0NClsgICAgMy42NDkwMzBdIHBjaV9i
dXMgMDAwZDowMTogcmVzb3VyY2UgMiBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZm
IDY0Yml0IHByZWZdDQpbICAgIDMuNjU3MDkxXSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTNd
IChkb21haW4gMDAwMCBbYnVzIDAwLWZmXSkNClsgICAgMy42NjMyNzVdIGFjcGkgUE5QMEEwODow
MzogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50
cyBNU0kgSFBYLVR5cGUzXQ0KWyAgICAzLjY3MjQ4Ml0gYWNwaSBQTlAwQTA4OjAzOiBQQ0llIHBv
cnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbA0KWyAgICAz
LjY4MDMwNF0gYWNwaSBQTlAwQTA4OjAzOiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgzZmZm
ZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAx
MGRlMGZjMA0KWyAgICAzLjY5MzIxNF0gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGFyZWEgW21lbSAw
eDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMA0KWyAg
ICAzLjcwMjA5OF0gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGF0IFttZW0gMHgzZmZmZjAwMDAwMDAt
MHgzZmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQ0KWyAgICAzLjcxMDMxMl0gUENJIGhvc3Qg
YnJpZGdlIHRvIGJ1cyAwMDAwOjAwDQpbICAgIDMuNzE0MzU5XSBwY2lfYnVzIDAwMDA6MDA6IHJv
b3QgYnVzIHJlc291cmNlIFttZW0gMHg3MDAwMDAwMC0weDdmZmZmZmZmIHdpbmRvd10NClsgICAg
My43MjE5NDldIHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDNjMDAw
MDAwMDAwMC0weDNmZmZkZmZmZmZmZiB3aW5kb3ddDQpbICAgIDMuNzMwMjA0XSBwY2lfYnVzIDAw
MDA6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdDQpbICAgIDMuNzM1NzY4XSBwY2kg
MDAwMDowMDowMC4wOiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwDQpbICAgIDMu
NzQxODY0XSBwY2kgMDAwMDowMDowMC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3Ig
TVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDMuNzQ5NDg0XSBwY2kgMDAwMDowMDowMS4wOiBb
MWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgIDMuNzU1NTYyXSBwY2kgMDAw
MDowMDowMS4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgICAzLjc1OTg0NV0gcGNpIDAwMDA6MDA6MDEu
MDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgICAzLjc2NTcxM10gcGNpIDAw
MDA6MDA6MDEuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdo
dCBmYWlsIQ0KWyAgICAzLjc3MzQxMV0gcGNpIDAwMDA6MDE6MDAuMDogWzgwODY6MTU4OV0gdHlw
ZSAwMCBjbGFzcyAweDAyMDAwMA0KWyAgICAzLjc3OTQxMV0gcGNpIDAwMDA6MDE6MDAuMDogcmVn
IDB4MTA6IFttZW0gMHgzYzAwMDMwMDAwMDAtMHgzYzAwMDNmZmZmZmYgNjRiaXQgcHJlZl0NClsg
ICAgMy43ODc0MTddIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODE4
MDAwLTB4M2MwMDA0ODFmZmZmIDY0Yml0IHByZWZdDQpbICAgIDMuNzk1NDAwXSBwY2kgMDAwMDow
MTowMC4wOiByZWcgMHgzMDogW21lbSAweGZmZjgwMDAwLTB4ZmZmZmZmZmYgcHJlZl0NClsgICAg
My44MDIyMjFdIHBjaSAwMDAwOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3Qg
RDNjb2xkDQpbICAgIDMuODA4MzQ5XSBwY2kgMDAwMDowMTowMC4wOiBGYWlsZWQgdG8gYWRkIC0g
cGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDMuODE1OTkwXSBwY2kg
MDAwMDowMTowMC4xOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwDQpbICAgIDMu
ODIyMDMyXSBwY2kgMDAwMDowMTowMC4xOiByZWcgMHgxMDogW21lbSAweDNjMDAwMjAwMDAwMC0w
eDNjMDAwMmZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICAzLjgzMDAzOV0gcGNpIDAwMDA6MDE6MDAu
MTogcmVnIDB4MWM6IFttZW0gMHgzYzAwMDQ4MTAwMDAtMHgzYzAwMDQ4MTdmZmYgNjRiaXQgcHJl
Zl0NClsgICAgMy44MzgwMjJdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDMwOiBbbWVtIDB4ZmZm
ODAwMDAtMHhmZmZmZmZmZiBwcmVmXQ0KWyAgICAzLjg0NDgzOV0gcGNpIDAwMDA6MDE6MDAuMTog
UE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAgMy44NTA5NjNdIHBjaSAw
MDAwOjAxOjAwLjE6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWln
aHQgZmFpbCENClsgICAgMy44NTg2MDldIHBjaSAwMDAwOjAxOjAwLjI6IFs4MDg2OjE1ODldIHR5
cGUgMDAgY2xhc3MgMHgwMjAwMDANClsgICAgMy44NjQ2NTNdIHBjaSAwMDAwOjAxOjAwLjI6IHJl
ZyAweDEwOiBbbWVtIDB4M2MwMDAxMDAwMDAwLTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdDQpb
ICAgIDMuODcyNjYwXSBwY2kgMDAwMDowMTowMC4yOiByZWcgMHgxYzogW21lbSAweDNjMDAwNDgw
ODAwMC0weDNjMDAwNDgwZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICAzLjg4MDY0M10gcGNpIDAwMDA6
MDE6MDAuMjogcmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdDQpbICAg
IDMuODg3NDU5XSBwY2kgMDAwMDowMTowMC4yOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90
IEQzY29sZA0KWyAgICAzLjg5MzU4NF0gcGNpIDAwMDA6MDE6MDAuMjogRmFpbGVkIHRvIGFkZCAt
IHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICAzLjkwMTIzMV0gcGNp
IDAwMDA6MDE6MDAuMzogWzgwODY6MTU4OV0gdHlwZSAwMCBjbGFzcyAweDAyMDAwMA0KWyAgICAz
LjkwNzI3NF0gcGNpIDAwMDA6MDE6MDAuMzogcmVnIDB4MTA6IFttZW0gMHgzYzAwMDAwMDAwMDAt
MHgzYzAwMDBmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgMy45MTUyODJdIHBjaSAwMDAwOjAxOjAw
LjM6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODAwMDAwLTB4M2MwMDA0ODA3ZmZmIDY0Yml0IHBy
ZWZdDQpbICAgIDMuOTIzMjY1XSBwY2kgMDAwMDowMTowMC4zOiByZWcgMHgzMDogW21lbSAweGZm
ZjgwMDAwLTB4ZmZmZmZmZmYgcHJlZl0NClsgICAgMy45MzAwODFdIHBjaSAwMDAwOjAxOjAwLjM6
IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAgIDMuOTM2MjA1XSBwY2kg
MDAwMDowMTowMC4zOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1p
Z2h0IGZhaWwhDQpbICAgIDMuOTQzODY1XSBwY2kgMDAwMDowMDowMS4wOiBicmlkZ2Ugd2luZG93
IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMS0wMl0gYWRkX3NpemUgMTAwMA0KWyAgICAz
Ljk1MjM0Nl0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDAw
MDAwMDAtMHgzYzAwMDQ3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgMy45NjA4NTBdIHBjaSAwMDAw
OjAwOjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NzAwMDAwMDAtMHg3MDFmZmZmZl0NClsg
ICAgMy45Njc2ODhdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBz
aXplIDB4MTAwMF0NClsgICAgMy45NzQwMThdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDMuOTgwNzE5XSBwY2kgMDAwMDow
MDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDMuOTg3
MDM5XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUg
MHgxMDAwXQ0KWyAgICAzLjk5MzcyOV0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDA6IGFzc2lnbmVk
IFttZW0gMHgzYzAwMDAwMDAwMDAtMHgzYzAwMDBmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgNC4w
MDIyNjJdIHBjaSAwMDAwOjAxOjAwLjE6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAxMDAw
MDAwLTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDQuMDEwNzcwXSBwY2kgMDAwMDow
MTowMC4yOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMjAwMDAwMC0weDNjMDAwMmZmZmZm
ZiA2NGJpdCBwcmVmXQ0KWyAgICA0LjAxOTI3Nl0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDA6IGFz
c2lnbmVkIFttZW0gMHgzYzAwMDMwMDAwMDAtMHgzYzAwMDNmZmZmZmYgNjRiaXQgcHJlZl0NClsg
ICAgNC4wMjc3ODNdIHBjaSAwMDAwOjAxOjAwLjA6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4NzAw
MDAwMDAtMHg3MDA3ZmZmZiBwcmVmXQ0KWyAgICA0LjAzNTA1NF0gcGNpIDAwMDA6MDE6MDAuMTog
QkFSIDY6IGFzc2lnbmVkIFttZW0gMHg3MDA4MDAwMC0weDcwMGZmZmZmIHByZWZdDQpbICAgIDQu
MDQyMzQ3XSBwY2kgMDAwMDowMTowMC4yOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMTAwMDAw
LTB4NzAxN2ZmZmYgcHJlZl0NClsgICAgNC4wNDk2MzhdIHBjaSAwMDAwOjAxOjAwLjM6IEJBUiA2
OiBhc3NpZ25lZCBbbWVtIDB4NzAxODAwMDAtMHg3MDFmZmZmZiBwcmVmXQ0KWyAgICA0LjA1Njky
OV0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDAwMDAt
MHgzYzAwMDQwMDdmZmYgNjRiaXQgcHJlZl0NClsgICAgNC4wNjU0NTddIHBjaSAwMDAwOjAxOjAw
LjE6IEJBUiAzOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDA0MDA4MDAwLTB4M2MwMDA0MDBmZmZmIDY0
Yml0IHByZWZdDQpbICAgIDQuMDczOTY0XSBwY2kgMDAwMDowMTowMC4yOiBCQVIgMzogYXNzaWdu
ZWQgW21lbSAweDNjMDAwNDAxMDAwMC0weDNjMDAwNDAxN2ZmZiA2NGJpdCBwcmVmXQ0KWyAgICA0
LjA4MjQ3MV0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQw
MTgwMDAtMHgzYzAwMDQwMWZmZmYgNjRiaXQgcHJlZl0NClsgICAgNC4wOTA5NzhdIHBjaSAwMDAw
OjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMS0wMl0NClsgICAgNC4wOTYyMjhdIHBjaSAw
MDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NzAwMDAwMDAtMHg3MDFmZmZmZl0N
ClsgICAgNC4xMDMxMDVdIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4
M2MwMDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDQuMTExNjMyXSBw
Y2lfYnVzIDAwMDA6MDA6IHJlc291cmNlIDQgW21lbSAweDcwMDAwMDAwLTB4N2ZmZmZmZmYgd2lu
ZG93XQ0KWyAgICA0LjExODU1Nl0gcGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSA1IFttZW0gMHgz
YzAwMDAwMDAwMDAtMHgzZmZmZGZmZmZmZmYgd2luZG93XQ0KWyAgICA0LjEyNjIwMl0gcGNpX2J1
cyAwMDAwOjAxOiByZXNvdXJjZSAxIFttZW0gMHg3MDAwMDAwMC0weDcwMWZmZmZmXQ0KWyAgICA0
LjEzMjUyNV0gcGNpX2J1cyAwMDAwOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzYzAwMDAwMDAwMDAt
MHgzYzAwMDQ3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgNC4xNDA1OTBdIEFDUEk6IFBDSSBSb290
IEJyaWRnZSBbUENJNl0gKGRvbWFpbiAwMDA0IFtidXMgMDAtZmZdKQ0KWyAgICA0LjE0Njc2OF0g
YWNwaSBQTlAwQTA4OjA2OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBD
bG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdDQpbICAgIDQuMTU1OTc0XSBhY3BpIFBOUDBB
MDg6MDY6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBj
b250cm9sDQpbICAgIDQuMTYzNzk2XSBhY3BpIFBOUDBBMDg6MDY6IE1DRkcgcXVpcms6IEVDQU0g
YXQgW21lbSAweDJiZmZmMDAwMDAwMC0weDJiZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdp
dGggMHhmZmZmODAwMDEwZGUwZmMwDQpbICAgIDQuMTc2NzAzXSBhY3BpIFBOUDBBMDg6MDY6IEVD
QU0gYXJlYSBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQ
TlAwQzAyOjAwDQpbICAgIDQuMTg1NTg1XSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0gYXQgW21lbSAw
eDJiZmZmMDAwMDAwMC0weDJiZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQpbICAgIDQuMTkz
ODAxXSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMDQ6MDANClsgICAgNC4xOTc4NDddIHBjaV9i
dXMgMDAwNDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYg
d2luZG93XQ0KWyAgICA0LjIwNTQzNl0gcGNpX2J1cyAwMDA0OjAwOiByb290IGJ1cyByZXNvdXJj
ZSBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MmJmZmRmZmZmZmZmIHdpbmRvd10NClsgICAgNC4yMTM2
OTFdIHBjaV9idXMgMDAwNDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0NClsgICAg
NC4yMTkyNTVdIHBjaSAwMDA0OjAwOjAwLjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3MgMHgw
NjAwMDANClsgICAgNC4yMjUzNTNdIHBjaSAwMDA0OjAwOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBw
YXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgNC4yMzI5NzJdIHBjaSAw
MDA0OjAwOjAxLjA6IFsxZGVmOmUxMTFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAgNC4y
MzkwNTJdIHBjaSAwMDA0OjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgIDQuMjQzMzM0XSBw
Y2kgMDAwNDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgIDQu
MjQ5MTk5XSBwY2kgMDAwNDowMDowMS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3Ig
TVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDQuMjU2ODQ0XSBwY2kgMDAwNDowMDowMy4wOiBb
MWRlZjplMTEzXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgIDQuMjYyOTI0XSBwY2kgMDAw
NDowMDowMy4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgICA0LjI2NzIwNV0gcGNpIDAwMDQ6MDA6MDMu
MDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgICA0LjI3MzA2OV0gcGNpIDAw
MDQ6MDA6MDMuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdo
dCBmYWlsIQ0KWyAgICA0LjI4MDcxN10gcGNpIDAwMDQ6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlw
ZSAwMSBjbGFzcyAweDA2MDQwMA0KWyAgICA0LjI4NjgwNF0gcGNpIDAwMDQ6MDA6MDUuMDogc3Vw
cG9ydHMgRDEgRDINClsgICAgNC4yOTEwNzZdIHBjaSAwMDA0OjAwOjA1LjA6IFBNRSMgc3VwcG9y
dGVkIGZyb20gRDAgRDEgRDNob3QNClsgICAgNC4yOTY5NDJdIHBjaSAwMDA0OjAwOjA1LjA6IEZh
aWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAg
NC4zMDQ2NDNdIHBjaSAwMDA0OjAxOjAwLjA6IFsxYTAzOjExNTBdIHR5cGUgMDEgY2xhc3MgMHgw
NjA0MDANClsgICAgNC4zMTA2NzldIHBjaSAwMDA0OjAxOjAwLjA6IGVuYWJsaW5nIEV4dGVuZGVk
IFRhZ3MNClsgICAgNC4zMTU3MTJdIHBjaSAwMDA0OjAxOjAwLjA6IHN1cHBvcnRzIEQxIEQyDQpb
ICAgIDQuMzE5OTgzXSBwY2kgMDAwNDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQx
IEQyIEQzaG90IEQzY29sZA0KWyAgICA0LjMyNjc0Ml0gcGNpIDAwMDQ6MDE6MDAuMDogRmFpbGVk
IHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA0LjMz
NDQwMF0gcGNpX2J1cyAwMDA0OjAyOiBleHRlbmRlZCBjb25maWcgc3BhY2Ugbm90IGFjY2Vzc2li
bGUNClsgICAgNC4zNDA1MTRdIHBjaSAwMDA0OjAyOjAwLjA6IFsxYTAzOjIwMDBdIHR5cGUgMDAg
Y2xhc3MgMHgwMzAwMDANClsgICAgNC4zNDY1ODVdIHBjaSAwMDA0OjAyOjAwLjA6IHJlZyAweDEw
OiBbbWVtIDB4MjAwMDAwMDAtMHgyMGZmZmZmZl0NClsgICAgNC4zNTI5MTZdIHBjaSAwMDA0OjAy
OjAwLjA6IHJlZyAweDE0OiBbbWVtIDB4MjEwMDAwMDAtMHgyMTAxZmZmZl0NClsgICAgNC4zNTky
NTJdIHBjaSAwMDA0OjAyOjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmYwMDAtMHgyN2ZmZjA3
Zl0NClsgICAgNC4zNjU2NjNdIHBjaSAwMDA0OjAyOjAwLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAg
IDQuMzY5ODk2XSBwY2kgMDAwNDowMjowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQy
IEQzaG90IEQzY29sZA0KWyAgICA0LjM3NjY0Nl0gcGNpIDAwMDQ6MDI6MDAuMDogRmFpbGVkIHRv
IGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA0LjM4NDM4
MV0gcGNpIDAwMDQ6MDM6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBjbGFzcyAweDBjMDMzMA0K
WyAgICA0LjM5MDM3NF0gcGNpIDAwMDQ6MDM6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMTIwMDAw
MC0weDIxMjAxZmZmIDY0Yml0XQ0KWyAgICA0LjM5NzMyNV0gcGNpIDAwMDQ6MDM6MDAuMDogUE1F
IyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAgNC40MDM0NDFdIHBjaSAwMDA0
OjAzOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQg
ZmFpbCENClsgICAgNC40MTExMjhdIHBjaSAwMDA0OjA0OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUg
MDAgY2xhc3MgMHgwMjAwMDANClsgICAgNC40MTcxMzFdIHBjaSAwMDA0OjA0OjAwLjA6IHJlZyAw
eDEwOiBbbWVtIDB4MjExMDAwMDAtMHgyMTE3ZmZmZl0NClsgICAgNC40MjM0ODFdIHBjaSAwMDA0
OjA0OjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmUwMDAtMHgyN2ZmZTAxZl0NClsgICAgNC40
Mjk3OTRdIHBjaSAwMDA0OjA0OjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MjExODAwMDAtMHgyMTE4
M2ZmZl0NClsgICAgNC40MzYyOTNdIHBjaSAwMDA0OjA0OjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZy
b20gRDAgRDNob3QgRDNjb2xkDQpbICAgIDQuNDQyNDI0XSBwY2kgMDAwNDowNDowMC4wOiBGYWls
ZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDQu
NDUwMDU1XSBwY2kgMDAwNDowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0w
eDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDEtMDJdIGFkZF9zaXplIDIwMDAwMCBhZGRf
YWxpZ24gMTAwMDAwDQpbICAgIDQuNDYxODY4XSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2lu
ZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMA0KWyAgICA0
LjQ3MDA3MV0gcGNpIDAwMDQ6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAt
MHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAzXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2Fs
aWduIDEwMDAwMA0KWyAgICA0LjQ4MTY1NV0gcGNpIDAwMDQ6MDA6MDMuMDogYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMDAw
IGFkZF9hbGlnbiAxMDAwMDANClsgICAgNC40OTIyMzNdIHBjaSAwMDA0OjAwOjA1LjA6IGJyaWRn
ZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAw
NF0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAgNC41MDM3OTBdIHBjaSAw
MDA0OjAwOjA1LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRv
IFtidXMgMDRdIGFkZF9zaXplIDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgIDQuNTE0Mzcx
XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4MjE3
ZmZmZmZdDQpbICAgIDQuNTIxMTgzXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQg
W21lbSAweDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA0LjUy
OTcwOF0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMTgwMDAwMC0w
eDIxOWZmZmZmXQ0KWyAgICA0LjUzNjU0N10gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDk6IGFzc2ln
bmVkIFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsgICAg
NC41NDUwNzNdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjFhMDAw
MDAtMHgyMWJmZmZmZl0NClsgICAgNC41NTE5MTJdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA5OiBh
c3NpZ25lZCBbbWVtIDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpb
ICAgIDQuNTYwNDM4XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAg
c2l6ZSAweDEwMDBdDQpbICAgIDQuNTY2NzQ4XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFp
bGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA0LjU3MzQzN10gcGNpIDAwMDQ6
MDA6MDMuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA0LjU3
OTc3MF0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXpl
IDB4MTAwMF0NClsgICAgNC41ODY0NThdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFj
ZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAgNC41OTI3OTBdIHBjaSAwMDA0OjAwOjA1LjA6
IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDQuNTk5NDgx
XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBd
DQpbICAgIDQuNjA1ODExXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA0LjYxMjQ5OV0gcGNpIDAwMDQ6MDA6MDUuMDogQkFS
IDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA0LjYxODgzMl0gcGNpIDAw
MDQ6MDA6MDUuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsg
ICAgNC42MjU1MjFdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBz
aXplIDB4MTAwMF0NClsgICAgNC42MzE4NTNdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDQuNjM4NTQyXSBwY2kgMDAwNDow
MTowMC4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZmZmZdDQpbICAg
IDQuNjQ1NDAxXSBwY2kgMDAwNDowMTowMC4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6
ZSAweDEwMDBdDQpbICAgIDQuNjUxNzMxXSBwY2kgMDAwNDowMTowMC4wOiBCQVIgNzogZmFpbGVk
IHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA0LjY1ODQyMV0gcGNpIDAwMDQ6MDI6
MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIwZmZmZmZmXQ0KWyAgICA0
LjY2NTI4M10gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFttZW0gMHgyMTAwMDAw
MC0weDIxMDFmZmZmXQ0KWyAgICA0LjY3MjE0MF0gcGNpIDAwMDQ6MDI6MDAuMDogQkFSIDI6IG5v
IHNwYWNlIGZvciBbaW8gIHNpemUgMHgwMDgwXQ0KWyAgICA0LjY3ODQ2N10gcGNpIDAwMDQ6MDI6
MDAuMDogQkFSIDI6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0NClsgICAgNC42
ODUxNTZdIHBjaSAwMDA0OjAxOjAwLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMl0NClsgICAgNC42
OTAxNzNdIHBjaSAwMDA0OjAxOjAwLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjAwMDAwMDAt
MHgyMTdmZmZmZl0NClsgICAgNC42OTcwNTZdIHBjaSAwMDA0OjAwOjAxLjA6IFBDSSBicmlkZ2Ug
dG8gW2J1cyAwMS0wMl0NClsgICAgNC43MDIzMjZdIHBjaSAwMDA0OjAwOjAxLjA6ICAgYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0NClsgICAgNC43MDkyMDRdIHBjaSAw
MDA0OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwMDAwMDAwLTB4MjgwMDAw
MWZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDQuNzE3NzMxXSBwY2kgMDAwNDowMzowMC4wOiBCQVIg
MDogYXNzaWduZWQgW21lbSAweDIxODAwMDAwLTB4MjE4MDFmZmYgNjRiaXRdDQpbICAgIDQuNzI1
MTA0XSBwY2kgMDAwNDowMDowMy4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDNdDQpbICAgIDQuNzMw
MTAxXSBwY2kgMDAwNDowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIxODAwMDAwLTB4
MjE5ZmZmZmZdDQpbICAgIDQuNzM2OTgxXSBwY2kgMDAwNDowMDowMy4wOiAgIGJyaWRnZSB3aW5k
b3cgW21lbSAweDI4MDAwMDIwMDAwMC0weDI4MDAwMDNmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA0
Ljc0NTUwOV0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMWEwMDAw
MC0weDIxYTdmZmZmXQ0KWyAgICA0Ljc1MjM1MF0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDM6IGFz
c2lnbmVkIFttZW0gMHgyMWE4MDAwMC0weDIxYTgzZmZmXQ0KWyAgICA0Ljc1OTIwOF0gcGNpIDAw
MDQ6MDQ6MDAuMDogQkFSIDI6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgwMDIwXQ0KWyAgICA0
Ljc2NTUzNF0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDI6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBz
aXplIDB4MDAyMF0NClsgICAgNC43NzIyMjJdIHBjaSAwMDA0OjAwOjA1LjA6IFBDSSBicmlkZ2Ug
dG8gW2J1cyAwNF0NClsgICAgNC43NzcyMzddIHBjaSAwMDA0OjAwOjA1LjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MjFhMDAwMDAtMHgyMWJmZmZmZl0NClsgICAgNC43ODQxMTddIHBjaSAwMDA0
OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZm
ZmZmIDY0Yml0IHByZWZdDQpbICAgIDQuNzkyNjQ0XSBwY2lfYnVzIDAwMDQ6MDA6IFNvbWUgUENJ
IGRldmljZSByZXNvdXJjZXMgYXJlIHVuYXNzaWduZWQsIHRyeSBib290aW5nIHdpdGggcGNpPXJl
YWxsb2MNClsgICAgNC44MDE3NjVdIHBjaV9idXMgMDAwNDowMDogcmVzb3VyY2UgNCBbbWVtIDB4
MjAwMDAwMDAtMHgyZmZmZmZmZiB3aW5kb3ddDQpbICAgIDQuODA4NjgyXSBwY2lfYnVzIDAwMDQ6
MDA6IHJlc291cmNlIDUgW21lbSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZmZmZmZiB3aW5kb3dd
DQpbICAgIDQuODE2MzI4XSBwY2lfYnVzIDAwMDQ6MDE6IHJlc291cmNlIDEgW21lbSAweDIwMDAw
MDAwLTB4MjE3ZmZmZmZdDQpbICAgIDQuODIyNjUyXSBwY2lfYnVzIDAwMDQ6MDE6IHJlc291cmNl
IDIgW21lbSAweDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA0
LjgzMDY1N10gcGNpX2J1cyAwMDA0OjAyOiByZXNvdXJjZSAxIFttZW0gMHgyMDAwMDAwMC0weDIx
N2ZmZmZmXQ0KWyAgICA0LjgzNjk3NV0gcGNpX2J1cyAwMDA0OjAzOiByZXNvdXJjZSAxIFttZW0g
MHgyMTgwMDAwMC0weDIxOWZmZmZmXQ0KWyAgICA0Ljg0MzMxMl0gcGNpX2J1cyAwMDA0OjAzOiBy
ZXNvdXJjZSAyIFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0N
ClsgICAgNC44NTEzMTddIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMSBbbWVtIDB4MjFhMDAw
MDAtMHgyMWJmZmZmZl0NClsgICAgNC44NTc2MzRdIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2Ug
MiBbbWVtIDB4MjgwMDAwNDAwMDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDQu
ODY1Njg3XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTddIChkb21haW4gMDAwNSBbYnVzIDAw
LWZmXSkNClsgICAgNC44NzE4NzldIGFjcGkgUE5QMEEwODowNzogX09TQzogT1Mgc3VwcG9ydHMg
W0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQ0KWyAg
ICA0Ljg4MTA4NF0gYWNwaSBQTlAwQTA4OjA3OiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7
IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbA0KWyAgICA0Ljg4ODkwNl0gYWNwaSBQTlAwQTA4
OjA3OiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZmZmZmZmZm
ZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMA0KWyAgICA0LjkwMTgx
MF0gYWNwaSBQTlAwQTA4OjA3OiBFQ0FNIGFyZWEgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZm
ZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMA0KWyAgICA0LjkxMDY5M10gYWNwaSBQTlAw
QTA4OjA3OiBFQ0FNIGF0IFttZW0gMHgyZmZmZjAwMDAwMDAtMHgyZmZmZmZmZmZmZmZdIGZvciBb
YnVzIDAwLWZmXQ0KWyAgICA0LjkxODkwN10gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDA1OjAw
DQpbICAgIDQuOTIyOTU1XSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0g
MHgzMDAwMDAwMC0weDNmZmZmZmZmIHdpbmRvd10NClsgICAgNC45MzA1NDVdIHBjaV9idXMgMDAw
NTowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZm
ZiB3aW5kb3ddDQpbICAgIDQuOTM4ODAwXSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291
cmNlIFtidXMgMDAtZmZdDQpbICAgIDQuOTQ0MzY0XSBwY2kgMDAwNTowMDowMC4wOiBbMWRlZjpl
MTEwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwDQpbICAgIDQuOTUwNDYyXSBwY2kgMDAwNTowMDow
MC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwh
DQpbICAgIDQuOTU4MDgyXSBwY2kgMDAwNTowMDowMS4wOiBbMWRlZjplMTExXSB0eXBlIDAxIGNs
YXNzIDB4MDYwNDAwDQpbICAgIDQuOTY0MTY5XSBwY2kgMDAwNTowMDowMS4wOiBzdXBwb3J0cyBE
MSBEMg0KWyAgICA0Ljk2ODQ0MV0gcGNpIDAwMDU6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJv
bSBEMCBEMSBEM2hvdA0KWyAgICA0Ljk3NDMwN10gcGNpIDAwMDU6MDA6MDEuMDogRmFpbGVkIHRv
IGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA0Ljk4MTk1
MV0gcGNpIDAwMDU6MDA6MDMuMDogWzFkZWY6ZTExM10gdHlwZSAwMSBjbGFzcyAweDA2MDQwMA0K
WyAgICA0Ljk4ODAzMV0gcGNpIDAwMDU6MDA6MDMuMDogc3VwcG9ydHMgRDEgRDINClsgICAgNC45
OTIzMTNdIHBjaSAwMDA1OjAwOjAzLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QN
ClsgICAgNC45OTgxNzddIHBjaSAwMDA1OjAwOjAzLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhy
b3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgNS4wMDU4MjRdIHBjaSAwMDA1OjAw
OjA1LjA6IFsxZGVmOmUxMTVdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAgNS4wMTE5MTJd
IHBjaSAwMDA1OjAwOjA1LjA6IHN1cHBvcnRzIEQxIEQyDQpbICAgIDUuMDE2MTg0XSBwY2kgMDAw
NTowMDowNS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgIDUuMDIyMDUw
XSBwY2kgMDAwNTowMDowNS4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01T
SS1YIG1pZ2h0IGZhaWwhDQpbICAgIDUuMDI5NjkzXSBwY2kgMDAwNTowMDowNy4wOiBbMWRlZjpl
MTE3XSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgIDUuMDM1NzcwXSBwY2kgMDAwNTowMDow
Ny4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgICA1LjA0MDA1Nl0gcGNpIDAwMDU6MDA6MDcuMDogUE1F
IyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgICA1LjA0NTkxOV0gcGNpIDAwMDU6MDA6
MDcuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWls
IQ0KWyAgICA1LjA1NDY4OF0gcGNpIDAwMDU6MDI6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBj
bGFzcyAweDBjMDMzMA0KWyAgICA1LjA2MDY4Ml0gcGNpIDAwMDU6MDI6MDAuMDogcmVnIDB4MTA6
IFttZW0gMHgzMDEwMDAwMC0weDMwMTAxZmZmIDY0Yml0XQ0KWyAgICA1LjA2NzYzM10gcGNpIDAw
MDU6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQNClsgICAgNS4w
NzM3NTBdIHBjaSAwMDA1OjAyOjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBN
U0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgNS4wODI0NzhdIHBjaSAwMDA1OjA0OjAwLjA6IFsx
MjZmOjIyNjNdIHR5cGUgMDAgY2xhc3MgMHgwMTA4MDINClsgICAgNS4wODg0NzFdIHBjaSAwMDA1
OjA0OjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4MzAwMDAwMDAtMHgzMDAwM2ZmZiA2NGJpdF0NClsg
ICAgNS4wOTU0NjNdIHBjaSAwMDA1OjA0OjAwLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3Vn
aCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAgNS4xMDMwNTNdIHBjaSAwMDA1OjAwOjAx
LjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6
ZSAxMDAwDQpbICAgIDUuMTExMjcyXSBwY2kgMDAwNTowMDowMS4wOiBicmlkZ2Ugd2luZG93IFtt
ZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDFdIGFkZF9zaXpl
IDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgIDUuMTIyODU2XSBwY2kgMDAwNTowMDowMS4w
OiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBh
ZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgICA1LjEzMzQzNV0gcGNpIDAwMDU6
MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDJdIGFk
ZF9zaXplIDEwMDANClsgICAgNS4xNDE2NTNdIHBjaSAwMDA1OjAwOjAzLjA6IGJyaWRnZSB3aW5k
b3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMl0gYWRk
X3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAgNS4xNTMyMzhdIHBjaSAwMDA1OjAw
OjAzLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMg
MDJdIGFkZF9zaXplIDEwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgIDUuMTYzODE2XSBwY2kg
MDAwNTowMDowNS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAw
M10gYWRkX3NpemUgMTAwMA0KWyAgICA1LjE3MjAzNV0gcGNpIDAwMDU6MDA6MDUuMDogYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAz
XSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgICA1LjE4MzYxOV0gcGNpIDAw
MDU6MDA6MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8g
W2J1cyAwM10gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAgNS4xOTQxOTld
IHBjaSAwMDA1OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBb
YnVzIDA0XSBhZGRfc2l6ZSAxMDAwDQpbICAgIDUuMjAyNDE3XSBwY2kgMDAwNTowMDowNy4wOiBi
cmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFti
dXMgMDRdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgIDUuMjE0MDAxXSBw
Y2kgMDAwNTowMDowNy4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZm
XSB0byBbYnVzIDA0XSBhZGRfc2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgICA1LjIy
NDU4NF0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMC0w
eDMwMWZmZmZmXQ0KWyAgICA1LjIzMTM5NF0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDk6IGFzc2ln
bmVkIFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAg
NS4yMzk5MjBdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzAyMDAw
MDAtMHgzMDNmZmZmZl0NClsgICAgNS4yNDY3NThdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA5OiBh
c3NpZ25lZCBbbWVtIDB4MmMwMDAwMjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdDQpb
ICAgIDUuMjU1Mjg1XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMw
NDAwMDAwLTB4MzA1ZmZmZmZdDQpbICAgIDUuMjYyMTIzXSBwY2kgMDAwNTowMDowNS4wOiBCQVIg
OTogYXNzaWduZWQgW21lbSAweDJjMDAwMDQwMDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVm
XQ0KWyAgICA1LjI3MDY0OV0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0g
MHgzMDYwMDAwMC0weDMwN2ZmZmZmXQ0KWyAgICA1LjI3NzQ4OF0gcGNpIDAwMDU6MDA6MDcuMDog
QkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZmZmYgNjRiaXQg
cHJlZl0NClsgICAgNS4yODYwMTRdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBm
b3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAgNS4yOTIzMjVdIHBjaSAwMDA1OjAwOjAxLjA6IEJB
UiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDUuMjk5MDEzXSBw
Y2kgMDAwNTowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpb
ICAgIDUuMzA1MzQ1XSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQ0KWyAgICA1LjMxMjAzNF0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6
IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA1LjMxODM2Nl0gcGNpIDAwMDU6
MDA6MDUuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAg
NS4zMjUwNTRdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0NClsgICAgNS4zMzEzODddIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDUuMzM4MDc4XSBwY2kgMDAwNTowMDow
Ny4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDUuMzQ0NDA4
XSBwY2kgMDAwNTowMDowNy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgx
MDAwXQ0KWyAgICA1LjM1MTA5Nl0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZv
ciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA1LjM1NzQyOV0gcGNpIDAwMDU6MDA6MDUuMDogQkFS
IDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAgNS4zNjQxMjVdIHBj
aSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsg
ICAgNS4zNzA0NTBdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtp
byAgc2l6ZSAweDEwMDBdDQpbICAgIDUuMzc3MTM4XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgNzog
bm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDUuMzgzNDcxXSBwY2kgMDAwNTow
MDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA1
LjM5MDE1OV0gcGNpIDAwMDU6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQ0KWyAgICA1
LjM5NTE3NF0gcGNpIDAwMDU6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAw
MC0weDMwMWZmZmZmXQ0KWyAgICA1LjQwMjA1NF0gcGNpIDAwMDU6MDA6MDEuMDogICBicmlkZ2Ug
d2luZG93IFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsg
ICAgNS40MTA1ODJdIHBjaSAwMDA1OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MzAy
MDAwMDAtMHgzMDIwMWZmZiA2NGJpdF0NClsgICAgNS40MTc5NTRdIHBjaSAwMDA1OjAwOjAzLjA6
IFBDSSBicmlkZ2UgdG8gW2J1cyAwMl0NClsgICAgNS40MjI5NTJdIHBjaSAwMDA1OjAwOjAzLjA6
ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MzAyMDAwMDAtMHgzMDNmZmZmZl0NClsgICAgNS40Mjk4
MzFdIHBjaSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMjAwMDAw
LTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDUuNDM4MzU5XSBwY2kgMDAwNTowMDow
NS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDNdDQpbICAgIDUuNDQzMzUxXSBwY2kgMDAwNTowMDow
NS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZmZmZdDQpbICAgIDUu
NDUwMjMxXSBwY2kgMDAwNTowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDQw
MDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA1LjQ1ODc2MF0gcGNpIDAwMDU6
MDQ6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAwMC0weDMwNjAzZmZmIDY0Yml0
XQ0KWyAgICA1LjQ2NjEyOV0gcGNpIDAwMDU6MDA6MDcuMDogUENJIGJyaWRnZSB0byBbYnVzIDA0
XQ0KWyAgICA1LjQ3MTEyOF0gcGNpIDAwMDU6MDA6MDcuMDogICBicmlkZ2Ugd2luZG93IFttZW0g
MHgzMDYwMDAwMC0weDMwN2ZmZmZmXQ0KWyAgICA1LjQ3ODAwOV0gcGNpIDAwMDU6MDA6MDcuMDog
ICBicmlkZ2Ugd2luZG93IFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZmZmYgNjRiaXQg
cHJlZl0NClsgICAgNS40ODY1MzZdIHBjaV9idXMgMDAwNTowMDogcmVzb3VyY2UgNCBbbWVtIDB4
MzAwMDAwMDAtMHgzZmZmZmZmZiB3aW5kb3ddDQpbICAgIDUuNDkzNDU5XSBwY2lfYnVzIDAwMDU6
MDA6IHJlc291cmNlIDUgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3aW5kb3dd
DQpbICAgIDUuNTAxMTA2XSBwY2lfYnVzIDAwMDU6MDE6IHJlc291cmNlIDEgW21lbSAweDMwMDAw
MDAwLTB4MzAxZmZmZmZdDQpbICAgIDUuNTA3NDI5XSBwY2lfYnVzIDAwMDU6MDE6IHJlc291cmNl
IDIgW21lbSAweDJjMDAwMDAwMDAwMC0weDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA1
LjUxNTQzNV0gcGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAxIFttZW0gMHgzMDIwMDAwMC0weDMw
M2ZmZmZmXQ0KWyAgICA1LjUyMTc1Ml0gcGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAyIFttZW0g
MHgyYzAwMDAyMDAwMDAtMHgyYzAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgNS41Mjk3NThd
IHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMSBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0N
ClsgICAgNS41MzYwNzVdIHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMiBbbWVtIDB4MmMwMDAw
NDAwMDAwLTB4MmMwMDAwNWZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDUuNTQ0MDgwXSBwY2lfYnVz
IDAwMDU6MDQ6IHJlc291cmNlIDEgW21lbSAweDMwNjAwMDAwLTB4MzA3ZmZmZmZdDQpbICAgIDUu
NTUwMzk4XSBwY2lfYnVzIDAwMDU6MDQ6IHJlc291cmNlIDIgW21lbSAweDJjMDAwMDYwMDAwMC0w
eDJjMDAwMDdmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA1LjU1ODU5NV0geGVuOmJhbGxvb246IElu
aXRpYWxpc2luZyBiYWxsb29uIGRyaXZlcg0KWyAgICA1LjU2MzU2MF0gaW9tbXU6IERlZmF1bHQg
ZG9tYWluIHR5cGU6IFRyYW5zbGF0ZWQgDQpbICAgIDUuNTY4NDkzXSBwY2kgMDAwZDowMTowMC4w
OiB2Z2FhcmI6IFZHQSBkZXZpY2UgYWRkZWQ6IGRlY29kZXM9aW8rbWVtLG93bnM9bm9uZSxsb2Nr
cz1ub25lDQpbICAgIDUuNTc2OTMxXSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IFZHQSBkZXZp
Y2UgYWRkZWQ6IGRlY29kZXM9aW8rbWVtLG93bnM9bm9uZSxsb2Nrcz1ub25lDQpbICAgIDUuNTg1
MzQ0XSBwY2kgMDAwZDowMTowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxlDQpb
ICAgIDUuNTkxMTI4XSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBv
c3NpYmxlDQpbICAgIDUuNTk2OTQ3XSBwY2kgMDAwNDowMjowMC4wOiB2Z2FhcmI6IHNldHRpbmcg
YXMgYm9vdCBkZXZpY2UgKFZHQSBsZWdhY3kgcmVzb3VyY2VzIG5vdCBhdmFpbGFibGUpDQpbICAg
IDUuNjA1OTIzXSB2Z2FhcmI6IGxvYWRlZA0KWyAgICA1LjYwODY4OV0gU0NTSSBzdWJzeXN0ZW0g
aW5pdGlhbGl6ZWQNClsgICAgNS42MTI0NjVdIEFDUEk6IGJ1cyB0eXBlIFVTQiByZWdpc3RlcmVk
DQpbICAgIDUuNjE2NTYwXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVy
IHVzYmZzDQpbICAgIDUuNjIyMTIyXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2Ug
ZHJpdmVyIGh1Yg0KWyAgICA1LjYyNzUwMF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgZGV2aWNl
IGRyaXZlciB1c2INClsgICAgNS42MzI2MjZdIHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAx
IHJlZ2lzdGVyZWQNClsgICAgNS42Mzc2NDddIHBwc19jb3JlOiBTb2Z0d2FyZSB2ZXIuIDUuMy42
IC0gQ29weXJpZ2h0IDIwMDUtMjAwNyBSb2RvbGZvIEdpb21ldHRpIDxnaW9tZXR0aUBsaW51eC5p
dD4NClsgICAgNS42NDY4OThdIFBUUCBjbG9jayBzdXBwb3J0IHJlZ2lzdGVyZWQNClsgICAgNS42
NTA4OTBdIFJlZ2lzdGVyZWQgZWZpdmFycyBvcGVyYXRpb25zDQpbICAgIDUuNjU0OTMwXSBObyBB
Q1BJIFBNVSBJUlEgZm9yIENQVTANClsgICAgNS42NTg3NjddIGNsb2Nrc291cmNlOiBTd2l0Y2hl
ZCB0byBjbG9ja3NvdXJjZSBhcmNoX3N5c19jb3VudGVyDQpbICAgIDUuODQwMjMyXSBwbnA6IFBu
UCBBQ1BJIGluaXQNClsgICAgNS44NDQ1OTBdIHN5c3RlbSAwMDowMDogW21lbSAweDNiZmZmMDAw
MDAwMC0weDNiZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgIDUuODUy
NTA1XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmYgd2lu
ZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQNClsgICAgNS44NjA4MzZdIHN5c3RlbSAwMDowMDog
W21lbSAweDIzZmZmMDAwMDAwMC0weDIzZmZmZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2Vy
dmVkDQpbICAgIDUuODY4ODE5XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgyN2ZmZjAwMDAwMDAtMHgy
N2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgICA1Ljg3NjgwNV0gc3lz
dGVtIDAwOjAwOiBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmIHdpbmRvd10gY291
bGQgbm90IGJlIHJlc2VydmVkDQpbICAgIDUuODg1MTQyXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgy
ZmZmZjAwMDAwMDAtMHgyZmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQN
ClsgICAgNS44OTM0NzVdIHN5c3RlbSAwMDowMDogW21lbSAweDdiZmZmMDAwMDAwMC0weDdiZmZm
ZmZmZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgIDUuOTAxNDU3XSBzeXN0ZW0g
MDA6MDA6IFttZW0gMHg3ZmZmZjAwMDAwMDAtMHg3ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVl
biByZXNlcnZlZA0KWyAgICA1LjkwOTQ0M10gc3lzdGVtIDAwOjAwOiBbbWVtIDB4NjNmZmYwMDAw
MDAwLTB4NjNmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsgICAgNS45MTc0
MjldIHN5c3RlbSAwMDowMDogW21lbSAweDY3ZmZmMDAwMDAwMC0weDY3ZmZmZmZmZmZmZiB3aW5k
b3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgIDUuOTI1NDE1XSBzeXN0ZW0gMDA6MDA6IFttZW0g
MHg2YmZmZjAwMDAwMDAtMHg2YmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0K
WyAgICA1LjkzMzQwMV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4NmZmZmYwMDAwMDAwLTB4NmZmZmZm
ZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsgICAgNS45NDEzODddIHN5c3RlbSAw
MDowMDogW21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5v
dCBiZSByZXNlcnZlZA0KWyAgICA1Ljk0OTcyNV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MzdmZmYw
MDAwMDAwLTB4MzdmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkDQpbICAg
IDUuOTU4MDY4XSBwbnA6IFBuUCBBQ1BJOiBmb3VuZCAxIGRldmljZXMNClsgICAgNS45NjMzNDhd
IE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMg0KWyAgICA1Ljk2NzgzN10gdGNwX2xp
c3Rlbl9wb3J0YWRkcl9oYXNoIGhhc2ggdGFibGUgZW50cmllczogNDA5NiAob3JkZXI6IDQsIDY1
NTM2IGJ5dGVzLCBsaW5lYXIpDQpbICAgIDUuOTc2NDE4XSBUQ1AgZXN0YWJsaXNoZWQgaGFzaCB0
YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQ0KWyAg
ICA1Ljk4NDU3Ml0gVENQIGJpbmQgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDgs
IDEwNDg1NzYgYnl0ZXMsIGxpbmVhcikNClsgICAgNS45OTI0MjhdIFRDUDogSGFzaCB0YWJsZXMg
Y29uZmlndXJlZCAoZXN0YWJsaXNoZWQgNjU1MzYgYmluZCA2NTUzNikNClsgICAgNS45OTg5NzVd
IFVEUCBoYXNoIHRhYmxlIGVudHJpZXM6IDQwOTYgKG9yZGVyOiA1LCAxMzEwNzIgYnl0ZXMsIGxp
bmVhcikNClsgICAgNi4wMDU4ODNdIFVEUC1MaXRlIGhhc2ggdGFibGUgZW50cmllczogNDA5NiAo
b3JkZXI6IDUsIDEzMTA3MiBieXRlcywgbGluZWFyKQ0KWyAgICA2LjAxMzIwOV0gTkVUOiBSZWdp
c3RlcmVkIHByb3RvY29sIGZhbWlseSAxDQpbICAgIDYuMDE3NjExXSBSUEM6IFJlZ2lzdGVyZWQg
bmFtZWQgVU5JWCBzb2NrZXQgdHJhbnNwb3J0IG1vZHVsZS4NClsgICAgNi4wMjM1NDBdIFJQQzog
UmVnaXN0ZXJlZCB1ZHAgdHJhbnNwb3J0IG1vZHVsZS4NClsgICAgNi4wMjgyODNdIFJQQzogUmVn
aXN0ZXJlZCB0Y3AgdHJhbnNwb3J0IG1vZHVsZS4NClsgICAgNi4wMzMwNTZdIFJQQzogUmVnaXN0
ZXJlZCB0Y3AgTkZTdjQuMSBiYWNrY2hhbm5lbCB0cmFuc3BvcnQgbW9kdWxlLg0KWyAgICA2LjAz
OTYzM10gcGNpIDAwMGQ6MDE6MDAuMTogRDAgcG93ZXIgc3RhdGUgZGVwZW5kcyBvbiAwMDBkOjAx
OjAwLjANClsgICAgNi4wNDYwNjZdIHBjaSAwMDBkOjAxOjAwLjI6IEQwIHBvd2VyIHN0YXRlIGRl
cGVuZHMgb24gMDAwZDowMTowMC4wDQpbICAgIDYuMDUyNDc0XSBwY2kgMDAwZDowMTowMC4yOiBl
bmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikNClsgICAgNi4wNTgyMTRdIHBjaSAwMDBkOjAx
OjAwLjM6IEQwIHBvd2VyIHN0YXRlIGRlcGVuZHMgb24gMDAwZDowMTowMC4wDQpbICAgIDYuMDY0
NjQ4XSBwY2kgMDAwNDowMzowMC4wOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikNClsg
ICAgNi4wNzAzNTNdIHBjaSAwMDA1OjAyOjAwLjA6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAw
MDAyKQ0KWyAgICA2LjA3NjA2OF0gUENJOiBDTFMgMTI4IGJ5dGVzLCBkZWZhdWx0IDY0DQpbICAg
IDYuMDgwMjU3XSBodyBwZXJmZXZlbnRzOiBlbmFibGVkIHdpdGggYXJtdjhfcG11djNfMCBQTVUg
ZHJpdmVyLCAxIGNvdW50ZXJzIGF2YWlsYWJsZQ0KWyAgICA2LjA4ODg5Ml0gd29ya2luZ3NldDog
dGltZXN0YW1wX2JpdHM9NDIgbWF4X29yZGVyPTIxIGJ1Y2tldF9vcmRlcj0wDQpbICAgIDYuMDk2
OTkzXSBORlM6IFJlZ2lzdGVyaW5nIHRoZSBpZF9yZXNvbHZlciBrZXkgdHlwZQ0KWyAgICA2LjEw
MjAyMl0gS2V5IHR5cGUgaWRfcmVzb2x2ZXIgcmVnaXN0ZXJlZA0KWyAgICA2LjEwNjI3MV0gS2V5
IHR5cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQNClsgICAgNi4xMTA0NzZdIEtleSB0eXBlIGNpZnMu
aWRtYXAgcmVnaXN0ZXJlZA0KWyAgICA2LjEyODk5MV0geG9yOiBtZWFzdXJpbmcgc29mdHdhcmUg
Y2hlY2tzdW0gc3BlZWQNClsgICAgNi4xMzQ3NTRdICAgIDhyZWdzICAgICAgICAgICA6ICA5Nzk0
IE1CL3NlYw0KWyAgICA2LjEzOTkwMF0gICAgMzJyZWdzICAgICAgICAgIDogMTE3NTQgTUIvc2Vj
DQpbICAgIDYuMTQ0OTE5XSAgICBhcm02NF9uZW9uICAgICAgOiAxMzk2MCBNQi9zZWMNClsgICAg
Ni4xNDkyMjRdIHhvcjogdXNpbmcgZnVuY3Rpb246IGFybTY0X25lb24gKDEzOTYwIE1CL3NlYykN
ClsgICAgNi4xNTQ4MDRdIEJsb2NrIGxheWVyIFNDU0kgZ2VuZXJpYyAoYnNnKSBkcml2ZXIgdmVy
c2lvbiAwLjQgbG9hZGVkIChtYWpvciAyNDkpDQpbICAgIDYuMTYyMjg0XSBpbyBzY2hlZHVsZXIg
bXEtZGVhZGxpbmUgcmVnaXN0ZXJlZA0KWyAgICA2LjE2Njg0OF0gaW8gc2NoZWR1bGVyIGt5YmVy
IHJlZ2lzdGVyZWQNClsgICAgNi4xNzEzMDZdIGdwaW8tZHdhcGIgQVBNQzBEMDc6MDI6IG5vIElS
USBmb3IgcG9ydDANClsgICAgNi4xNzcwMTNdIGlucHV0OiBQb3dlciBCdXR0b24gYXMgL2Rldmlj
ZXMvTE5YU1lTVE06MDAvTE5YU1lCVVM6MDAvUE5QMEMwQzowMC9pbnB1dC9pbnB1dDANClsgICAg
Ni4xODUzOTBdIEFDUEk6IFBvd2VyIEJ1dHRvbiBbUFdSQl0NClsgICAgNi4xODk2NjVdIEdIRVM6
IEFQRUkgZmlybXdhcmUgZmlyc3QgbW9kZSBpcyBlbmFibGVkIGJ5IEFQRUkgYml0Lg0KWyAgICA2
LjE5NjAyOV0gRUlOSjogRXJyb3IgSU5KZWN0aW9uIGlzIGluaXRpYWxpemVkLg0KWyAgICA2LjIw
MDczM10gQUNQSSBHVERUOiBmb3VuZCAxIFNCU0EgZ2VuZXJpYyBXYXRjaGRvZyhzKS4NClsgICAg
Ni4yMDY1MDNdIHhlbjp4ZW5fZXZ0Y2huOiBFdmVudC1jaGFubmVsIGRldmljZSBpbnN0YWxsZWQN
ClsgICAgNi4yMTI1ODBdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIHBsYXRmb3JtIGhhcyBubyBJ
TyBzcGFjZSwgdHJ5aW5nIE1NSU8NClsgICAgNi4yMTkzNzldIGFzdCAwMDA0OjAyOjAwLjA6IFtk
cm1dIFVzaW5nIFAyQSBicmlkZ2UgZm9yIGNvbmZpZ3VyYXRpb24NClsgICAgNi4yMjU5NDVdIGFz
dCAwMDA0OjAyOjAwLjA6IFtkcm1dIEFTVCAyNTAwIGRldGVjdGVkDQpbICAgIDYuMjMxMDQ5XSBh
c3QgMDAwNDowMjowMC4wOiBbZHJtXSBBbmFsb2cgVkdBIG9ubHkNClsgICAgNi4yMzU5OTddIGFz
dCAwMDA0OjAyOjAwLjA6IFtkcm1dIGRyYW0gTUNMSz04MDAgTWh6IHR5cGU9OCBidXNfd2lkdGg9
MTYNClsgICAgNi4yNDI5MTNdIFtUVE1dIFpvbmUgIGtlcm5lbDogQXZhaWxhYmxlIGdyYXBoaWNz
IG1lbW9yeTogNDA1Mjc1MiBLaUINClsgICAgNi4yNDk0NzBdIFtUVE1dIFpvbmUgICBkbWEzMjog
QXZhaWxhYmxlIGdyYXBoaWNzIG1lbW9yeTogMjA5NzE1MiBLaUINClsgICAgNi4yNTYwNjJdIFtU
VE1dIEluaXRpYWxpemluZyBwb29sIGFsbG9jYXRvcg0KWyAgICA2LjI2MDQ2Nl0gW1RUTV0gSW5p
dGlhbGl6aW5nIERNQSBwb29sIGFsbG9jYXRvcg0KWyAgICA2LjI2NTQ4Nl0gW2RybV0gSW5pdGlh
bGl6ZWQgYXN0IDAuMS4wIDIwMTIwMjI4IGZvciAwMDA0OjAyOjAwLjAgb24gbWlub3IgMA0KWyAg
ICA2LjI5MDUyOV0gQ29uc29sZTogc3dpdGNoaW5nIHRvIGNvbG91ciBmcmFtZSBidWZmZXIgZGV2
aWNlIDEyOHg0OA0KWyAgICA2LjI5ODczMF0gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gZmIwOiBh
c3Rkcm1mYiBmcmFtZSBidWZmZXIgZGV2aWNlDQpbICAgIDYuMzE2NDg1XSBicmQ6IG1vZHVsZSBs
b2FkZWQNClsgICAgNi4zMjA5NjVdIGxvb3A6IG1vZHVsZSBsb2FkZWQNClsgICAgNi4zMjQwNjRd
IEludmFsaWQgbWF4X3F1ZXVlcyAoNCksIHdpbGwgdXNlIGRlZmF1bHQgbWF4OiAxLg0KWyAgICA2
LjMzMDA5OF0gbnZtZSBudm1lMDogcGNpIGZ1bmN0aW9uIDAwMDU6MDQ6MDAuMA0KWyAgICA2LjMz
NTAzM10gaWdiOiBJbnRlbChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgRHJpdmVyDQpbICAg
IDYuMzQwMzk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NTEyIGZsYWdzPWNjMCBh
dHRyPTANClsgICAgNi4zNDYzOTZdIGlnYjogQ29weXJpZ2h0IChjKSAyMDA3LTIwMTQgSW50ZWwg
Q29ycG9yYXRpb24uDQpbICAgIDYuMzUyMDI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NTEyIGZsYWdzPWNjMCBhdHRyPTANClsgICAgNi4zNTg2NDRdIERFQlVHIHhlbl9zd2lvdGxi
X2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTUxMiBmbGFncz1jYzAgYXR0cj0wDQpbICAgIDYuMzY1
NDk3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAgNi4zNzMxNjldIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVy
ZW50IDMyMyBwaHlzPTgwMDA0MWY1MDAwIGRldl9hZGRyPTgwMDA0MWY1MDAwDQpbICAgIDYuMzgx
MDc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9MjA0OCBmbGFncz1jYzAgYXR0cj0w
DQpbICAgIDYuMzkwNzM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9MjA0OCBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgIDYuMzk3MDk2XSBwcHMgcHBzMDogbmV3IFBQUyBzb3VyY2UgcHRw
MA0KWyAgICA2LjQwMTA1Ml0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNp
emU9MjA0OCBmbGFncz1jYzAgYXR0cj0wDQpbICAgIDYuNDA4MTQzXSBpZ2IgMDAwNDowNDowMC4w
OiBhZGRlZCBQSEMgb24gZXRoMA0KWyAgICA2LjQxMjY4OF0gaWdiIDAwMDQ6MDQ6MDAuMDogSW50
ZWwoUikgR2lnYWJpdCBFdGhlcm5ldCBOZXR3b3JrIENvbm5lY3Rpb24NClsgICAgNi40MTk2NTld
IERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgICA2LjQyNjY5Ml0gaWdiIDAwMDQ6MDQ6MDAuMDogZXRoMDogKFBDSWU6Mi41
R2IvczpXaWR0aCB4MSkgMDA6MzA6NjQ6M2I6NTA6NTINClsgICAgNi40MzM4OTldIERFQlVHIHhl
bl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA0MjAwMDAwIGRldl9hZGRyPTgw
MDA0MjAwMDAwDQpbICAgIDYuNDQxOTUxXSBpZ2IgMDAwNDowNDowMC4wOiBldGgwOiBQQkEgTm86
IDAwMDMwMC0wMDANClsgICAgNi40NDcwODVdIGlnYiAwMDA0OjA0OjAwLjA6IFVzaW5nIE1TSS1Y
IGludGVycnVwdHMuIDEgcnggcXVldWUocyksIDEgdHggcXVldWUocykNClsgICAgNi40NTQ3OTJd
IERFQlVHIHhlbl9zd2lvdGxiX21hcF9wYWdlIDQwMCBwaHlzPTgwMDAzYzRmMDAwIGRldl9hZGRy
PTgwMDAzYzRmMDAwDQpbICAgIDYuNDYyMjM4XSBpZ2J2ZjogSW50ZWwoUikgR2lnYWJpdCBWaXJ0
dWFsIEZ1bmN0aW9uIE5ldHdvcmsgRHJpdmVyDQpbICAgIDYuNDY4NTQ0XSBpZ2J2ZjogQ29weXJp
Z2h0IChjKSAyMDA5IC0gMjAxMiBJbnRlbCBDb3Jwb3JhdGlvbi4NClsgICAgNi40NzQ1MTRdIERF
QlVHIHhlbl9zd2lvdGxiX21hcF9wYWdlIDQwMCBwaHlzPTgwMDAwMDE5MDAwIGRldl9hZGRyPTgw
MDAwMDE5MDAwDQpbICAgIDYuNDgyMDIzXSBpNDBlOiBJbnRlbChSKSBFdGhlcm5ldCBDb25uZWN0
aW9uIFhMNzEwIE5ldHdvcmsgRHJpdmVyDQpbICAgIDYuNDg4MzMzXSBudm1lIG52bWUwOiBtaXNz
aW5nIG9yIGludmFsaWQgU1VCTlFOIGZpZWxkLg0KWyAgICA2LjQ5MzY4Nl0gaTQwZTogQ29weXJp
Z2h0IChjKSAyMDEzIC0gMjAxOSBJbnRlbCBDb3Jwb3JhdGlvbi4NClsgICAgNi40OTk2MTVdIERF
QlVHIHhlbl9zd2lvdGxiX21hcF9wYWdlIDQwMCBwaHlzPTgwMDA0MjAxNjAwIGRldl9hZGRyPTgw
MDA0MjAxNjAwDQpbICAgIDYuNTA3MTcyXSBpNDBlIDAwMDA6MDE6MDAuMDogZW5hYmxpbmcgZGV2
aWNlICgwMDAwIC0+IDAwMDIpDQpbICAgIDYuNTEyOTEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9MjU2IGZsYWdzPWNjMCBhdHRyPTANClsgICAgNi41MjAxNzddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT0yNTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgICA2LjUyNjA2OF0g
REVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9MjU2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAgNi41MzMwMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT04MTky
IGZsYWdzPWNjMCBhdHRyPTANClsgICAgNi41MzkwODRdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9j
X2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgICA2LjU0NjEyOF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTgxOTIgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
ICA2LjU1MjE5Ml0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAw
MDQyMDkwMDAgZGV2X2FkZHI9ODAwMDQyMDkwMDANClsgICAgNi41NjAyMDFdIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTgxOTIgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
ICA2LjU2NzIyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQxOTQzMDQgZmxhZ3M9
Y2MwIGF0dHI9MTEwDQpbICAgIDYuNTczNzI2XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hl
cmVudCAzMDAgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTANClsgICAgNi41ODA3NjFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMA0KWyAg
ICA2LjU4NzI2OV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAw
MDQyMWUwMDAgZGV2X2FkZHI9ODAwMDQyMWUwMDANClsgICAgNi41OTUyNzBdIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEw
DQpbICAgIDYuNjAyNzM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgIDYuNjA4Nzg5XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hl
cmVudCAzMDAgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMA0KWyAgICA2LjYxNjI3Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
ICA2LjYyMjQ1Ml0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAw
MDQ0MDAwMDAgZGV2X2FkZHI9ODAwMDQ0MDAwMDANClsgICAgNi42MzAzNTldIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
ICA2LjYzNzM3Nl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgIDYuNjQ0NTM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTANClsgICAgNi42NTA5NTBdIERFQlVH
IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA0MjBhMDAwIGRldl9hZGRy
PTgwMDA0MjBhMDAwDQpbICAgIDYuNjU4OTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTANClsgICAgNi42NjU0NDZdIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEw
DQpbICAgIDYuNjcyOTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgIDYuNjc4OTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgIDYuNjg1MDU5XSBERUJVRyB4ZW5fc3dpb3Rs
Yl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMA0KWyAg
ICA2LjY5MjU0MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgIDYuNjk5NTc3XSBVbmFibGUgdG8gaGFuZGxlIGtlcm5l
bCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UgYXQgdmlydHVhbCBhZGRyZXNzIDAwMDAwMDAwMDAw
MDAwMDgNClsgICAgNi43MDg0MzddIE1lbSBhYm9ydCBpbmZvOg0KWyAgICA2LjcxMTIzM10gICBF
U1IgPSAweDk2MDAwMDQ0DQpbICAgIDYuNzE0MzYxXSAgIEVDID0gMHgyNTogREFCVCAoY3VycmVu
dCBFTCksIElMID0gMzIgYml0cw0KWyAgICA2LjcxOTc3MF0gICBTRVQgPSAwLCBGblYgPSAwDQpb
ICAgIDYuNzIyODY4XSAgIEVBID0gMCwgUzFQVFcgPSAwDQpbICAgIDYuNzI2MDgxXSBEYXRhIGFi
b3J0IGluZm86DQpbICAgIDYuNzI5MDI5XSAgIElTViA9IDAsIElTUyA9IDB4MDAwMDAwNDQNClsg
ICAgNi43MzI5NDddICAgQ00gPSAwLCBXblIgPSAxDQpbICAgIDYuNzM1OTc1XSBbMDAwMDAwMDAw
MDAwMDAwOF0gdXNlciBhZGRyZXNzIGJ1dCBhY3RpdmVfbW0gaXMgc3dhcHBlcg0KWyAgICA2Ljc0
MjQzOF0gSW50ZXJuYWwgZXJyb3I6IE9vcHM6IDk2MDAwMDQ0IFsjMV0gUFJFRU1QVCBTTVANClsg
ICAgNi43NDgwNzJdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICA2Ljc1MTE2OF0gQ1BVOiAwIFBJ
RDogOTUgQ29tbToga3dvcmtlci91MjoxIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEw
LjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDYuNzYwODg1XSBXb3JrcXVldWU6IG52
bWUtcmVzZXQtd3EgbnZtZV9yZXNldF93b3JrDQpbICAgIDYuNzY1ODYxXSBwc3RhdGU6IDYwYzAw
MDg1IChuWkN2IGRhSWYgK1BBTiArVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDYuNzcxOTQ5XSBw
YyA6IHN0ZWFsX3N1aXRhYmxlX2ZhbGxiYWNrKzB4MTM4LzB4MmYwDQpbICAgIDYuNzc2OTcwXSBs
ciA6IHN0ZWFsX3N1aXRhYmxlX2ZhbGxiYWNrKzB4MWJjLzB4MmYwDQpbICAgIDYuNzgyMDA0XSBz
cCA6IGZmZmY4MDAwMTFlMGI4MTANClsgICAgNi43ODUzNzFdIHgyOTogZmZmZjgwMDAxMWUwYjgx
MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDYuNzkwNzc1XSB4Mjc6IDAwMDAwMDAwMDAw
MDAwMDAgeDI2OiBmZmZmODAwMDExNGRiY2IwIA0KWyAgICA2Ljc5NjE1N10geDI1OiBmZmZmZmRm
ZmZmZTAwMDAwIHgyNDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgNi44MDE1MzldIHgyMzogMDAw
MDAwMDAwMDAwMDAwMCB4MjI6IGZmZmZmZTFmZmRmMjAwMDAgDQpbICAgIDYuODA2OTIxXSB4MjE6
IGZmZmYwODA3MWVmZWY5ODAgeDIwOiAwMDAwMDAwMDAwMDAwOTAxIA0KWyAgICA2LjgxMjMwM10g
eDE5OiAwMDAwMDAwMDAwMDgwMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgNi44MTc2
ODVdIHgxNzogMDAwMDAwMDAwMDAwMDAwZSB4MTY6IDAwMDAwMDAwMDAwMDAwMTIgDQpbICAgIDYu
ODIzMDY3XSB4MTU6IGZmZmY4MDAwOTE4NGI1ZDcgeDE0OiAwMDAwMDAwMDAwMDAwMDA2IA0KWyAg
ICA2LjgyODQ0OV0geDEzOiBmZmZmODAwMDExODRiNWRmIHgxMjogMzAzMzM0MzkzMTM0M2Q2NSAN
ClsgICAgNi44MzM4MzFdIHgxMTogN2E2OTczMjAzMDMwMzMyMCB4MTA6IDAwMDAwMDAwMDAwMDAw
MGMgDQpbICAgIDYuODM5MjEzXSB4OSA6IGZmZmY4MDAwMTAwMzlkNTggeDggOiAwMDAwMDAwMDgw
MDAwMDAwIA0KWyAgICA2Ljg0NDU5NV0geDcgOiAwMDAwMDAwMDAwMDAwMDE4IHg2IDogZmZmZjgw
MDAxMTc1MDg5MCANClsgICAgNi44NDk5NzddIHg1IDogZmZmZjgwMDAxMTc1MDg3OCB4NCA6IDAw
MDAwMDAwMDAwMDAwMDAgDQpbICAgIDYuODU1MzU5XSB4MyA6IDAwMDAwMDAwMDAwMDAwMDAgeDIg
OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICA2Ljg2MDc0MV0geDEgOiAwMDAwMDAwMDAwMDAwMjAw
IHgwIDogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgNi44NjYxMjNdIENhbGwgdHJhY2U6DQpbICAg
IDYuODY4NjA4XSAgc3RlYWxfc3VpdGFibGVfZmFsbGJhY2srMHgxMzgvMHgyZjANClsgICAgNi44
NzMzMjFdICBnZXRfcGFnZV9mcm9tX2ZyZWVsaXN0KzB4ZTMwLzB4MTJhMA0KWyAgICA2Ljg3ODAw
OF0gIF9fYWxsb2NfcGFnZXNfbm9kZW1hc2srMHgxNDgvMHhlMDANClsgICAgNi44ODI2MDldICBf
X2RtYV9kaXJlY3RfYWxsb2NfcGFnZXMrMHhhNC8weDFkMA0KWyAgICA2Ljg4NzI5Nl0gIGRtYV9k
aXJlY3RfYWxsb2MrMHgxZDgvMHgzNDANClsgICAgNi44OTEzNzBdICB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCsweGMwLzB4MzI4DQpbICAgIDYuODk2MjM5XSAgZG1hX2FsbG9jX2F0dHJzKzB4
MTQ0LzB4MTYwDQpbICAgIDYuOTAwMjIyXSAgbnZtZV9yZXNldF93b3JrKzB4MTAzMC8weDE1MjAN
ClsgICAgNi45MDQzOTJdICBwcm9jZXNzX29uZV93b3JrKzB4MWRjLzB4NGJjDQpbICAgIDYuOTA4
NDcwXSAgd29ya2VyX3RocmVhZCsweDE0NC8weDQ3MA0KWyAgICA2LjkxMjI4N10gIGt0aHJlYWQr
MHgxNGMvMHgxNjANClsgICAgNi45MTU1NzldICByZXRfZnJvbV9mb3JrKzB4MTAvMHgzOA0KWyAg
ICA2LjkxOTIzMF0gQ29kZTogYTk0MDgyYzQgZDM3ZWY0NjMgY2IzYzQwNjMgOGIzYzQwNDIgKGY5
MDAwNDgwKSANClsgICAgNi45MjU0MjNdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTMg
XS0tLQ0KWyAgICA2LjkzMDA5Ml0gbm90ZToga3dvcmtlci91MjoxWzk1XSBleGl0ZWQgd2l0aCBw
cmVlbXB0X2NvdW50IDENClsgICAgNi45MzYwMTZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KDQo=

--_007_5C7EC3F4912646E8932160878357F939armcom_
Content-Type: application/octet-stream;
	name="native_linux_with_ maxcpus_1_debug.log"
Content-Description: native_linux_with_ maxcpus_1_debug.log
Content-Disposition: attachment;
	filename="native_linux_with_ maxcpus_1_debug.log"; size=370952;
	creation-date="Wed, 20 Apr 2022 11:05:02 GMT";
	modification-date="Wed, 20 Apr 2022 11:05:02 GMT"
Content-ID: <7AFA6860E26BC540A80C0C9EBF3654D5@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogV2VkIEFwciAyMCAxMDo1Mjo1NiBvbiB0dHlzMDAwCnJhaHNpbjAxQEMwMlpY
MEc5TFZETiB+ICUgdGVsbmV0IGUxMjMzNDMuY2FtYnJpZGdlLmFybS5jb20gMTAwMjAKVHJ5aW5n
IDEwLjEuMTk0LjI1Li4uCkNvbm5lY3RlZCB0byBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29tLgpF
c2NhcGUgY2hhcmFjdGVyIGlzICdeXScuCgpBSVMgdGFyZ2V0IHN5c3RlbSBwb3J0IDEwMDIwIGRl
dmljZSAvZGV2L3R0eVVTQjEgWzExNTIwMCBOODFdCgoKRlMwOlxFRklcQk9PVFw+IApGUzA6XEVG
SVxCT09UXD4gYm9vdGFhNjQuZWZpCldlbGNvbWUgdG8gR1JVQiEKCmVycm9yOiBubyBzdWNoIGRl
dmljZTogKChoZDAsZ3B0MSkvRUZJL0JPT1QpL0VGSS9CT09UL2dydWIuY2ZnLgoKCgoKCgoKCgoK
CgoKCgoKCgoKCgoKCgogICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdOVSBHUlVCICB2ZXJz
aW9uIDIuMDYKCiAvLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLVwKIHwgUEFSVFVVSUQgQm9vdDogQ09NLUhQ
QyBZb2N0byBJbWFnZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAK
IHwgTlZNZSBNLjIgIFNTRCBCb290OiBDT00tSFBDIFlvY3RvIEltYWdlICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgfAogfCpVU0IgQm9vdCAoSWYgRHJpdmUgaXMgcHJlc2VudCk6
IENPTS1IUEMgWW9jdG8gSW1hZ2UgICAgICAgICAgICAgICAgICAgICAgICB8CiB8IENPTS1IUEMg
WW9jdG8gSW1hZ2UgKFhlbikgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8
CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
fAogfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgCiBcLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS8KCiAgICAgIFVzZSB0aGUgXiBhbmQgdiBrZXlzIHRvIHNlbGVjdCB3aGlj
aCBlbnRyeSBpcyBoaWdobGlnaHRlZC4gICAgICAgICAgCiAgICAgIFByZXNzIGVudGVyIHRvIGJv
b3QgdGhlIHNlbGVjdGVkIE9TLCBgZScgdG8gZWRpdCB0aGUgY29tbWFuZHMgICAgICAgCiAgICAg
IGJlZm9yZSBib290aW5nIG9yIGBjJyBmb3IgYSBjb21tYW5kLWxpbmUuICAgICAgICAgICAgICAg
ICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IAoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCkVGSSBz
dHViOiBCb290aW5nIExpbnV4IEtlcm5lbC4uLgpFRkkgc3R1YjogVXNpbmcgRFRCIGZyb20gY29u
ZmlndXJhdGlvbiB0YWJsZQpFRkkgc3R1YjogRXhpdGluZyBib290IHNlcnZpY2VzIGFuZCBpbnN0
YWxsaW5nIHZpcnR1YWwgYWRkcmVzcyBtYXAuLi4KUFJPR1JFU1MgQ09ERTogVjAzMTAxMDE5IEkw
ClsgICAgMC4wMDAwMDBdIEJvb3RpbmcgTGludXggb24gcGh5c2ljYWwgQ1BVIDB4MDAwMDEwMDAw
MCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwMDAwMF0gTGludXggdmVyc2lvbiA1LjEwLjI3LWFtcGVy
ZS1sdHMtc3RhbmRhcmQrIChvZS11c2VyQG9lLWhvc3QpIChhYXJjaDY0LXBva3ktbGludXgtZ2Nj
IChHQ0MpIDExLjIuMCwgR05VIGxkIChHTlUgQmludXRpbHMpIDIuMzcuMjAyMTA3MjEpICMxIFNN
UCBQUkVFTVBUIFNhdCBTZXAgMTggMDY6MDE6NTkgVVRDIDIwMjEKWyAgICAwLjAwMDAwMF0gZWZp
OiBFRkkgdjIuNzAgYnkgRURLIElJClsgICAgMC4wMDAwMDBdIGVmaTogVFBNRmluYWxMb2c9MHg4
MDdmOWVmMDAwMCBBQ1BJIDIuMD0weDgwN2ZhMGQwMDE4IFNNQklPUyAzLjA9MHg4MDdmOGUzMDAw
MCBNRU1BVFRSPTB4ODA3ZjdkY2MwMTggRVNSVD0weDgwN2Y3ZjY0Yjk4IFRQTUV2ZW50TG9nPTB4
ODA3ZjdkZTAwMTggUk5HPTB4ZmZiNGJhOTggTUVNUkVTRVJWRT0weDgwN2Y3ZTg1ZTk4IApbICAg
IDAuMDAwMDAwXSBlZmk6IHNlZWRpbmcgZW50cm9weSBwb29sClsgICAgMC4wMDAwMDBdIGVzcnQ6
IFJlc2VydmluZyBFU1JUIHNwYWNlIGZyb20gMHgwMDAwMDgwN2Y3ZjY0Yjk4IHRvIDB4MDAwMDA4
MDdmN2Y2NGJkMC4KWyAgICAwLjAwMDAwMF0gQUNQSTogRWFybHkgdGFibGUgY2hlY2tzdW0gdmVy
aWZpY2F0aW9uIGRpc2FibGVkClsgICAgMC4wMDAwMDBdIEFDUEk6IFJTRFAgMHgwMDAwMDgwN0ZB
MEQwMDE4IDAwMDAyNCAodjAyIEFtcGVyZSkKWyAgICAwLjAwMDAwMF0gQUNQSTogWFNEVCAweDAw
MDAwODA3RkEwREZFOTggMDAwMEE0ICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4g
MDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IEZBQ1AgMHgwMDAwMDgwN0ZBMERGQjk4IDAw
MDExNCAodjA2IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBEU0RUIDB4MDAwMDA4MDdGOERCMDAxOCAwMkMxOUUgKHYwMiBBbXBlcmUg
SmFkZSAgICAgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNykKWyAgICAwLjAwMDAwMF0gQUNQSTogQkVS
VCAweDAwMDAwODA3RkEwREZGOTggMDAwMDMwICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAy
IEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IERCRzIgMHgwMDAwMDgwN0ZBMERG
QTk4IDAwMDA1QyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpb
ICAgIDAuMDAwMDAwXSBBQ1BJOiBHVERUIDB4MDAwMDA4MDdGQTBERTk5OCAwMDAxMTAgKHYwMyBB
bXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQ
STogU1BDUiAweDAwMDAwODA3RkEwREZFMTggMDAwMDUwICh2MDIgQW1wZXJlIEFsdHJhICAgIDAw
MDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IEVJTkogMHgwMDAwMDgw
N0ZBMERGNTk4IDAwMDE1MCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAx
MjE3KQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBIRVNUIDB4MDAwMDA4MDdGQTBERUIxOCAwMDAxRjQg
KHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDEgSU5UTCAyMDIwMTIxNykKWyAgICAwLjAwMDAw
MF0gQUNQSTogU1NEVCAweDAwMDAwODA3RkEwREZBMTggMDAwMDJEICh2MDIgQW1wZXJlIEFsdHJh
ICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpClsgICAgMC4wMDAwMDBdIEFDUEk6IFRQTTIgMHgw
MDAwMDgwN0ZBMERGRDE4IDAwMDA0QyAodjA0IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAu
IDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBNQ0ZHIDB4MDAwMDA4MDdGQTBERjcxOCAw
MDAwN0MgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDEgQU1QLiAwMTAwMDAxMykKWyAgICAw
LjAwMDAwMF0gQUNQSTogSU9SVCAweDAwMDAwODA3RkEwREVGMTggMDAwM0RDICh2MDAgQW1wZXJl
IEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IEFQ
SUMgMHgwMDAwMDgwN0ZBMEQ3NTE4IDAwMEFGNCAodjA1IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAw
MiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBQUFRUIDB4MDAwMDA4MDdGQTBE
ODYxOCAwMDQ1MjAgKHYwMiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykK
WyAgICAwLjAwMDAwMF0gQUNQSTogU0xJVCAweDAwMDAwODA3RkEwREZEOTggMDAwMDJEICh2MDEg
QW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFD
UEk6IFNSQVQgMHgwMDAwMDgwN0ZBMERDRTE4IDAwMDM3MCAodjAzIEFtcGVyZSBBbHRyYSAgICAw
MDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBQQ0NUIDB4MDAwMDA4
MDdGQTBERTMxOCAwMDA1NzYgKHYwMiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAw
MDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogU1BDUjogY29uc29sZTogcGwwMTEsbW1pbzMyLDB4
MTAwMDAyNjAwMDAwLDExNTIwMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhN
IDAgW21lbSAweDg4MzAwMDAwLTB4ODgzZmZmZmZdClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6
IE5vZGUgMCBQWE0gMCBbbWVtIDB4OTAwMDAwMDAtMHhmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0g
QUNQSTogU1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4MDAwMDAwMDAwMC0weDgwMDdmZmZmZmZm
XQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDgwMTAwMDAw
MDAwLTB4ODA3ZmZmZmZmZmZdClsgICAgMC4wMDAwMDBdIE5VTUE6IE5PREVfREFUQSBbbWVtIDB4
ODA3ZmMwNmZlMDAtMHg4MDdmYzA3MWZmZl0KWyAgICAwLjAwMDAwMF0gWm9uZSByYW5nZXM6Clsg
ICAgMC4wMDAwMDBdICAgRE1BICAgICAgW21lbSAweDAwMDAwMDAwODgzMDAwMDAtMHgwMDAwMDAw
MGZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIERNQTMyICAgIGVtcHR5ClsgICAgMC4wMDAwMDBd
ICAgTm9ybWFsICAgW21lbSAweDAwMDAwMDAxMDAwMDAwMDAtMHgwMDAwMDgwN2ZmZmZmZmZmXQpb
ICAgIDAuMDAwMDAwXSBNb3ZhYmxlIHpvbmUgc3RhcnQgZm9yIGVhY2ggbm9kZQpbICAgIDAuMDAw
MDAwXSBFYXJseSBtZW1vcnkgbm9kZSByYW5nZXMKWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDog
W21lbSAweDAwMDAwMDAwODgzMDAwMDAtMHgwMDAwMDAwMDg4M2ZmZmZmXQpbICAgIDAuMDAwMDAw
XSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAwMDA5MDAwMDAwMC0weDAwMDAwMDAwOTFmZmZmZmZd
ClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMDkyMDAwMDAwLTB4MDAw
MDAwMDA5MjdiZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAw
OTI3YzAwMDAtMHgwMDAwMDAwMGZmYjNmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBb
bWVtIDB4MDAwMDAwMDBmZmI0MDAwMC0weDAwMDAwMDAwZmZiNGZmZmZdClsgICAgMC4wMDAwMDBd
ICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMGZmYjUwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0K
WyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODAwMDAwMDAwMDAtMHgwMDAw
MDgwMDdmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDEw
MDAwMDAwMC0weDAwMDAwODA3ZjZhN2ZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFtt
ZW0gMHgwMDAwMDgwN2Y2YTgwMDAwLTB4MDAwMDA4MDdmNmIxZmZmZl0KWyAgICAwLjAwMDAwMF0g
ICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjZiMjAwMDAtMHgwMDAwMDgwN2Y2YzFlZmZmXQpb
ICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmNmMxZjAwMC0weDAwMDAw
ODA3ZjcyYzdmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y3
MmM4MDAwLTB4MDAwMDA4MDdmN2ViZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21l
bSAweDAwMDAwODA3ZjdlYzAwMDAtMHgwMDAwMDgwN2Y3ZWRmZmZmXQpbICAgIDAuMDAwMDAwXSAg
IG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmN2VlMDAwMC0weDAwMDAwODA3ZjdlZWZmZmZdClsg
ICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y3ZWYwMDAwLTB4MDAwMDA4
MDdmN2YyZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3Zjdm
MzAwMDAtMHgwMDAwMDgwN2Y4N2VmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVt
IDB4MDAwMDA4MDdmODdmMDAwMC0weDAwMDAwODA3Zjg4MmZmZmZdClsgICAgMC4wMDAwMDBdICAg
bm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4ODMwMDAwLTB4MDAwMDA4MDdmOGE2ZmZmZl0KWyAg
ICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjhhNzAwMDAtMHgwMDAwMDgw
N2Y4YWFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOGFi
MDAwMC0weDAwMDAwODA3ZjhlMWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0g
MHgwMDAwMDgwN2Y4ZTIwMDAwLTB4MDAwMDA4MDdmOGUzZmZmZl0KWyAgICAwLjAwMDAwMF0gICBu
b2RlICAgMDogW21lbSAweDAwMDAwODA3ZjhlNDAwMDAtMHgwMDAwMDgwN2Y4ZTZmZmZmXQpbICAg
IDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOGU3MDAwMC0weDAwMDAwODA3
ZjllN2ZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y5ZTgw
MDAwLTB4MDAwMDA4MDdmOWVlZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAw
eDAwMDAwODA3ZjllZjAwMDAtMHgwMDAwMDgwN2Y5ZjFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5v
ZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOWYyMDAwMC0weDAwMDAwODA3ZjlmYmZmZmZdClsgICAg
MC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y5ZmMwMDAwLTB4MDAwMDA4MDdm
OWZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmEwMDAw
MDAtMHgwMDAwMDgwN2ZhMGZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4
MDAwMDA4MDdmYTEwMDAwMC0weDAwMDAwODA3ZmExOWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9k
ZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhMWEwMDAwLTB4MDAwMDA4MDdmYTI2ZmZmZl0KWyAgICAw
LjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmEyNzAwMDAtMHgwMDAwMDgwN2Zh
NGFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTRiMDAw
MC0weDAwMDAwODA3ZmE3MWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgw
MDAwMDgwN2ZhNzIwMDAwLTB4MDAwMDA4MDdmYTc1ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2Rl
ICAgMDogW21lbSAweDAwMDAwODA3ZmE3NjAwMDAtMHgwMDAwMDgwN2ZhOGNmZmZmXQpbICAgIDAu
MDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYThkMDAwMC0weDAwMDAwODA3ZmE5
NmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhOTcwMDAw
LTB4MDAwMDA4MDdmYTlmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAw
MDAwODA3ZmFhMDAwMDAtMHgwMDAwMDgwN2ZiYWFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUg
ICAwOiBbbWVtIDB4MDAwMDA4MDdmYmFiMDAwMC0weDAwMDAwODA3ZmJiM2ZmZmZdClsgICAgMC4w
MDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZiYjQwMDAwLTB4MDAwMDA4MDdmYmJk
ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmJiZTAwMDAt
MHgwMDAwMDgwN2ZiY2FmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAw
MDA4MDdmYmNiMDAwMC0weDAwMDAwODA3ZmJjZWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAg
IDA6IFttZW0gMHgwMDAwMDgwN2ZiY2YwMDAwLTB4MDAwMDA4MDdmYmQ1ZmZmZl0KWyAgICAwLjAw
MDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmJkNjAwMDAtMHgwMDAwMDgwN2ZiZGZm
ZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmUwMDAwMC0w
eDAwMDAwODA3ZmZmZmZmZmZdClsgICAgMC4wMDAwMDBdIEluaXRtZW0gc2V0dXAgbm9kZSAwIFtt
ZW0gMHgwMDAwMDAwMDg4MzAwMDAwLTB4MDAwMDA4MDdmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0g
cHNjaTogcHJvYmluZyBmb3IgY29uZHVpdCBtZXRob2QgZnJvbSBBQ1BJLgpbICAgIDAuMDAwMDAw
XSBwc2NpOiBQU0NJdjEuMSBkZXRlY3RlZCBpbiBmaXJtd2FyZS4KWyAgICAwLjAwMDAwMF0gcHNj
aTogVXNpbmcgc3RhbmRhcmQgUFNDSSB2MC4yIGZ1bmN0aW9uIElEcwpbICAgIDAuMDAwMDAwXSBw
c2NpOiBNSUdSQVRFX0lORk9fVFlQRSBub3Qgc3VwcG9ydGVkLgpbICAgIDAuMDAwMDAwXSBwc2Np
OiBTTUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjIKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTog
U1JBVDogUFhNIDAgLT4gTVBJRFIgMHg4MDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQ
STogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHg4MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAw
MDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHg5MDAwMCAtPiBOb2RlIDAK
WyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHg5MDEwMCAt
PiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIg
MHhlMDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAg
LT4gTVBJRFIgMHhlMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JB
VDogUFhNIDAgLT4gTVBJRFIgMHhmMDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTog
TlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHhmMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAw
MF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxMDAwMDAgLT4gTm9kZSAwClsg
ICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTAwMTAwIC0+
IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAw
eDExMDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAg
LT4gTVBJRFIgMHgxMTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNS
QVQ6IFBYTSAwIC0+IE1QSURSIDB4MTYwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE2MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAw
MDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxNzAwMDAgLT4gTm9kZSAw
ClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTcwMTAw
IC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElE
UiAweDE4MDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhN
IDAgLT4gTVBJRFIgMHgxODAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6
IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTkwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBB
Q1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE5MDEwMCAtPiBOb2RlIDAKWyAgICAw
LjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxZTAwMDAgLT4gTm9k
ZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MWUw
MTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBN
UElEUiAweDFmMDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDog
UFhNIDAgLT4gTVBJRFIgMHgxZjAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5V
TUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MjAwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAw
XSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDIwMDEwMCAtPiBOb2RlIDAKWyAg
ICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgyMTAwMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
MjEwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAt
PiBNUElEUiAweDI2MDAwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JB
VDogUFhNIDAgLT4gTVBJRFIgMHgyNjAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6
IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MjcwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAw
MDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDI3MDEwMCAtPiBOb2RlIDAK
WyAgICAwLjAwMDAwMF0gcGVyY3B1OiBFbWJlZGRlZCAzMSBwYWdlcy9jcHUgczg5MjQwIHI4MTky
IGQyOTU0NCB1MTI2OTc2ClsgICAgMC4wMDAwMDBdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBD
UFUwClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEdJQyBzeXN0ZW0gcmVn
aXN0ZXIgQ1BVIGludGVyZmFjZQpbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVk
OiBWaXJ0dWFsaXphdGlvbiBIb3N0IEV4dGVuc2lvbnMKWyAgICAwLjAwMDAwMF0gQ1BVIGZlYXR1
cmVzOiBkZXRlY3RlZDogSGFyZHdhcmUgZGlydHkgYml0IG1hbmFnZW1lbnQKWyAgICAwLjAwMDAw
MF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3RyZS12NApbICAgIDAuMDAwMDAwXSBDUFUg
ZmVhdHVyZXM6IGRldGVjdGVkOiBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDAwMDBdIGFs
dGVybmF0aXZlczogcGF0Y2hpbmcga2VybmVsIGNvZGUKWyAgICAwLjAwMDAwMF0gQnVpbHQgMSB6
b25lbGlzdHMsIG1vYmlsaXR5IGdyb3VwaW5nIG9uLiAgVG90YWwgcGFnZXM6IDgxOTMyNzYKWyAg
ICAwLjAwMDAwMF0gUG9saWN5IHpvbmU6IE5vcm1hbApbICAgIDAuMDAwMDAwXSBLZXJuZWwgY29t
bWFuZCBsaW5lOiBCT09UX0lNQUdFPS9JbWFnZSByb290d2FpdCBydyBtYXhjcHVzPTEgcm9vdD0v
ZGV2L3NkYTIKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbiBpbmRpdmlkdWFsIG1h
eCBjcHUgY29udHJpYnV0aW9uOiA0MDk2IGJ5dGVzClsgICAgMC4wMDAwMDBdIHByaW50azogbG9n
X2J1Zl9sZW4gdG90YWwgY3B1X2V4dHJhIGNvbnRyaWJ1dGlvbnM6IDEyNjk3NiBieXRlcwpbICAg
IDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVuIG1pbiBzaXplOiAxMzEwNzIgYnl0ZXMKWyAg
ICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbjogMjYyMTQ0IGJ5dGVzClsgICAgMC4wMDAw
MDBdIHByaW50azogZWFybHkgbG9nIGJ1ZiBmcmVlOiAxMjEyNDAoOTIlKQpbICAgIDAuMDAwMDAw
XSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA0MTk0MzA0IChvcmRlcjogMTMsIDMz
NTU0NDMyIGJ5dGVzLCBsaW5lYXIpClsgICAgMC4wMDAwMDBdIElub2RlLWNhY2hlIGhhc2ggdGFi
bGUgZW50cmllczogMjA5NzE1MiAob3JkZXI6IDEyLCAxNjc3NzIxNiBieXRlcywgbGluZWFyKQpb
ICAgIDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBzdGFjazpvZmYsIGhlYXAgYWxsb2M6b2ZmLCBo
ZWFwIGZyZWU6b2ZmClsgICAgMC4wMDAwMDBdIHNvZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0g
MHgwMDAwMDAwMGZiYjQwMDAwLTB4MDAwMDAwMDBmZmI0MDAwMF0gKDY0TUIpClsgICAgMC4wMDAw
MDBdIE1lbW9yeTogMzI1MDIyODhLLzMzMjkzMzEySyBhdmFpbGFibGUgKDEzNTY4SyBrZXJuZWwg
Y29kZSwgMTk5NksgcndkYXRhLCAzNDc2SyByb2RhdGEsIDQxNjBLIGluaXQsIDgyMksgYnNzLCA3
OTEwMjRLIHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2ZWQpClsgICAgMC4wMDAwMDBdIFNMVUI6IEhX
YWxpZ249NjQsIE9yZGVyPTAtMywgTWluT2JqZWN0cz0wLCBDUFVzPTMyLCBOb2Rlcz0xClsgICAg
MC4wMDAwMDBdIGZ0cmFjZTogYWxsb2NhdGluZyA0MTMwNiBlbnRyaWVzIGluIDE2MiBwYWdlcwpb
ICAgIDAuMDAwMDAwXSBmdHJhY2U6IGFsbG9jYXRlZCAxNjIgcGFnZXMgd2l0aCAzIGdyb3Vwcwpb
ICAgIDAuMDAwMDAwXSByY3U6IFByZWVtcHRpYmxlIGhpZXJhcmNoaWNhbCBSQ1UgaW1wbGVtZW50
YXRpb24uClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSBldmVudCB0cmFjaW5nIGlzIGVuYWJsZWQu
ClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSByZXN0cmljdGluZyBDUFVzIGZyb20gTlJfQ1BVUz0y
NTYgdG8gbnJfY3B1X2lkcz0zMi4KWyAgICAwLjAwMDAwMF0gCVRyYW1wb2xpbmUgdmFyaWFudCBv
ZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gCVJ1ZGUgdmFyaWFudCBvZiBUYXNr
cyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gCVRyYWNpbmcgdmFyaWFudCBvZiBUYXNrcyBS
Q1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gcmN1OiBSQ1UgY2FsY3VsYXRlZCB2YWx1ZSBvZiBz
Y2hlZHVsZXItZW5saXN0bWVudCBkZWxheSBpcyAyNSBqaWZmaWVzLgpbICAgIDAuMDAwMDAwXSBy
Y3U6IEFkanVzdGluZyBnZW9tZXRyeSBmb3IgcmN1X2Zhbm91dF9sZWFmPTE2LCBucl9jcHVfaWRz
PTMyClsgICAgMC4wMDAwMDBdIE5SX0lSUVM6IDY0LCBucl9pcnFzOiA2NCwgcHJlYWxsb2NhdGVk
IGlycXM6IDAKWyAgICAwLjAwMDAwMF0gR0lDdjM6IEdJQzogVXNpbmcgc3BsaXQgRU9JL0RlYWN0
aXZhdGUgbW9kZQpbICAgIDAuMDAwMDAwXSBHSUN2MzogNjcyIFNQSXMgaW1wbGVtZW50ZWQKWyAg
ICAwLjAwMDAwMF0gR0lDdjM6IDAgRXh0ZW5kZWQgU1BJcyBpbXBsZW1lbnRlZApbICAgIDAuMDAw
MDAwXSBHSUN2MzogRGlzdHJpYnV0b3IgaGFzIG5vIFJhbmdlIFNlbGVjdG9yIHN1cHBvcnQKWyAg
ICAwLjAwMDAwMF0gR0lDdjM6IDE2IFBQSXMgaW1wbGVtZW50ZWQKWyAgICAwLjAwMDAwMF0gR0lD
djM6IENQVTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTAwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDU0MDAwMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMCAtPiBOb2RlIDAKWyAg
ICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDEgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBd
IFNSQVQ6IFBYTSAwIC0+IElUUyAyIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0g
MCAtPiBJVFMgMyAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDQg
LT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA1IC0+IE5vZGUgMApb
ICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNiAtPiBOb2RlIDAKWyAgICAwLjAwMDAw
MF0gU1JBVDogUFhNIDAgLT4gSVRTIDcgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIElUUyBbbWVt
IDB4MTAwMTAwMDQwMDAwLTB4MTAwMTAwMDVmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAw
MTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDIyMDAwMCAoaW5kaXJl
Y3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEw
MDA0MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAyMzAw
MDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTIFttZW0g
MHgxMDAxMDAwNjAwMDAtMHgxMDAxMDAwN2ZmZmZdClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAx
MDAxMDAwNjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMjUwMDAwIChpbmRpcmVj
dCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAw
MDYwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDI2MDAw
MCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAw
eDEwMDEwMDA4MDAwMC0weDEwMDEwMDA5ZmZmZl0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEw
MDEwMDA4MDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAyODAwMDAgKGluZGlyZWN0
LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAw
ODAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMjkwMDAw
IChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4
MTAwMTAwMGEwMDAwLTB4MTAwMTAwMGJmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMGEwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDJiMDAwMCAoaW5kaXJlY3Qs
IGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDBh
MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAyYzAwMDAg
KGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgx
MDAxMDAwYzAwMDAtMHgxMDAxMDAwZGZmZmZdClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAx
MDAwYzAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMmUwMDAwIChpbmRpcmVjdCwg
ZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGMw
MDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDJmMDAwMCAo
ZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEw
MDEwMDBlMDAwMC0weDEwMDEwMDBmZmZmZl0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEw
MDBlMDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAzMTAwMDAgKGluZGlyZWN0LCBl
c3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwZTAw
MDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMzIwMDAwIChm
bGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAw
MTAwMTAwMDAwLTB4MTAwMTAwMTFmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAw
MTAwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDM0MDAwMCAoaW5kaXJlY3QsIGVz
eiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEwMDAw
MDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAzNTAwMDAgKGZs
YXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAx
MDAxMjAwMDAtMHgxMDAxMDAxM2ZmZmZdClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAx
MjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMzcwMDAwIChpbmRpcmVjdCwgZXN6
IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMTIwMDAw
OiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDM4MDAwMCAoZmxh
dCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBHSUN2MzogdXNpbmcgTFBJ
IHByb3BlcnR5IHRhYmxlIEAweDAwMDAwODAwMDAzOTAwMDAKWyAgICAwLjAwMDAwMF0gR0lDdjM6
IENQVTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2Ew
MDAwClsgICAgMC4wMDAwMDBdIHJhbmRvbTogZ2V0X3JhbmRvbV9ieXRlcyBjYWxsZWQgZnJvbSBz
dGFydF9rZXJuZWwrMHgzOTQvMHg1NTQgd2l0aCBjcm5nX2luaXQ9MApbICAgIDAuMDAwMDAwXSBh
cmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4
MDQwClsgICAgMC4wMDAwMDBdIEFDUEkgR1REVDogZm91bmQgMSBtZW1vcnktbWFwcGVkIHRpbWVy
IGJsb2NrKHMpLgpbICAgIDAuMDAwMDAwXSBhcmNoX3RpbWVyOiBjcDE1IGFuZCBtbWlvIHRpbWVy
KHMpIHJ1bm5pbmcgYXQgMjUuMDBNSHogKHBoeXMvcGh5cykuClsgICAgMC4wMDAwMDBdIGNsb2Nr
c291cmNlOiBhcmNoX3N5c19jb3VudGVyOiBtYXNrOiAweGZmZmZmZmZmZmZmZmZmIG1heF9jeWNs
ZXM6IDB4NWM0MDkzOWI1LCBtYXhfaWRsZV9uczogNDQwNzk1MjAyNjQ2IG5zClsgICAgMC4wMDAw
MDFdIHNjaGVkX2Nsb2NrOiA1NiBiaXRzIGF0IDI1TUh6LCByZXNvbHV0aW9uIDQwbnMsIHdyYXBz
IGV2ZXJ5IDQzOTgwNDY1MTExMDBucwpbICAgIDAuMDAwMDU0XSBDb25zb2xlOiBjb2xvdXIgZHVt
bXkgZGV2aWNlIDgweDI1ClsgICAgMC4wMDAwNzVdIEFDUEk6IENvcmUgcmV2aXNpb24gMjAyMDA5
MjUKWyAgICAwLjAwMDQ4OV0gQ2FsaWJyYXRpbmcgZGVsYXkgbG9vcCAoc2tpcHBlZCksIHZhbHVl
IGNhbGN1bGF0ZWQgdXNpbmcgdGltZXIgZnJlcXVlbmN5Li4gNTAuMDAgQm9nb01JUFMgKGxwaj0x
MDAwMDApClsgICAgMC4wMDA0OTRdIHBpZF9tYXg6IGRlZmF1bHQ6IDMyNzY4IG1pbmltdW06IDMw
MQpbICAgIDAuMDAwNTIxXSBMU006IFNlY3VyaXR5IEZyYW1ld29yayBpbml0aWFsaXppbmcKWyAg
ICAwLjAwMDY1MF0gTW91bnQtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6
IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAgIDAuMDAwNzMzXSBNb3VudHBvaW50LWNhY2hl
IGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA3LCA1MjQyODggYnl0ZXMsIGxpbmVh
cikKWyAgICAwLjAwMTU4MF0gcmN1OiBIaWVyYXJjaGljYWwgU1JDVSBpbXBsZW1lbnRhdGlvbi4K
WyAgICAwLjAwMTcwOF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwNDAwMDAgZG9tYWluIGNy
ZWF0ZWQKWyAgICAwLjAwMTcxMV0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwNjAwMDAgZG9t
YWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxNF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwODAw
MDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxN10gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAx
MDAwYTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyMF0gUGxhdGZvcm0gTVNJOiBJVFNA
MHgxMDAxMDAwYzAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyMl0gUGxhdGZvcm0gTVNJ
OiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyNl0gUGxhdGZv
cm0gTVNJOiBJVFNAMHgxMDAxMDAxMDAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTczMF0g
UGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMjAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAw
MTczN10gUENJL01TSTogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkClsgICAgMC4w
MDE3NDBdIFBDSS9NU0k6IElUU0AweDEwMDEwMDA2MDAwMCBkb21haW4gY3JlYXRlZApbICAgIDAu
MDAxNzQyXSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAw
LjAwMTc0NV0gUENJL01TSTogSVRTQDB4MTAwMTAwMGEwMDAwIGRvbWFpbiBjcmVhdGVkClsgICAg
MC4wMDE3NDhdIFBDSS9NU0k6IElUU0AweDEwMDEwMDBjMDAwMCBkb21haW4gY3JlYXRlZApbICAg
IDAuMDAxNzUyXSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAg
ICAwLjAwMTc1NV0gUENJL01TSTogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBjcmVhdGVkClsg
ICAgMC4wMDE3NThdIFBDSS9NU0k6IElUU0AweDEwMDEwMDEyMDAwMCBkb21haW4gY3JlYXRlZApb
ICAgIDAuMDAxNzY1XSBSZW1hcHBpbmcgYW5kIGVuYWJsaW5nIEVGSSBzZXJ2aWNlcy4KWyAgICAw
LjAwMzYwN10gc21wOiBCcmluZ2luZyB1cCBzZWNvbmRhcnkgQ1BVcyAuLi4KWyAgICAwLjAwMzYx
MV0gc21wOiBCcm91Z2h0IHVwIDEgbm9kZSwgMSBDUFUKWyAgICAwLjAwMzYxM10gU01QOiBUb3Rh
bCBvZiAxIHByb2Nlc3NvcnMgYWN0aXZhdGVkLgpbICAgIDAuMDAzNjE2XSBDUFUgZmVhdHVyZXM6
IGRldGVjdGVkOiBQcml2aWxlZ2VkIEFjY2VzcyBOZXZlcgpbICAgIDAuMDAzNjE4XSBDUFUgZmVh
dHVyZXM6IGRldGVjdGVkOiBMU0UgYXRvbWljIGluc3RydWN0aW9ucwpbICAgIDAuMDAzNjIwXSBD
UFUgZmVhdHVyZXM6IGRldGVjdGVkOiBVc2VyIEFjY2VzcyBPdmVycmlkZQpbICAgIDAuMDAzNjIy
XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiAzMi1iaXQgRUwwIFN1cHBvcnQKWyAgICAwLjAwMzYy
NV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQ29tbW9uIG5vdCBQcml2YXRlIHRyYW5zbGF0aW9u
cwpbICAgIDAuMDAzNjI3XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBSQVMgRXh0ZW5zaW9uIFN1
cHBvcnQKWyAgICAwLjAwMzYyOV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogRGF0YSBjYWNoZSBj
bGVhbiB0byB0aGUgUG9VIG5vdCByZXF1aXJlZCBmb3IgSS9EIGNvaGVyZW5jZQpbICAgIDAuMDAz
NjMxXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBDUkMzMiBpbnN0cnVjdGlvbnMKWyAgICAwLjAw
MzYzMl0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3VsYXRpdmUgU3RvcmUgQnlwYXNzaW5n
IFNhZmUgKFNTQlMpClsgICAgMC4wMzUzNzZdIENQVTogQWxsIENQVShzKSBzdGFydGVkIGF0IEVM
MgpbICAgIDAuMDM1ODYxXSBkZXZ0bXBmczogaW5pdGlhbGl6ZWQKWyAgICAwLjAzNjEyNl0gY2xv
Y2tzb3VyY2U6IGppZmZpZXM6IG1hc2s6IDB4ZmZmZmZmZmYgbWF4X2N5Y2xlczogMHhmZmZmZmZm
ZiwgbWF4X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnMKWyAgICAwLjAzNjEzMl0gZnV0ZXgg
aGFzaCB0YWJsZSBlbnRyaWVzOiA4MTkyIChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIp
ClsgICAgMC4wMzYzNjJdIFNNQklPUyAzLjMuMCBwcmVzZW50LgpbICAgIDAuMDM2MzY4XSBETUk6
IEFETElOSyBDT00tSFBDLUFMVC9DT00tSFBDLUFMVCwgQklPUyBUaWFub0NvcmUgRURLSUkgMTEv
MjMvMjAyMQpbICAgIDAuMDM2NTg4XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDE2
ClsgICAgMC4wMzY4NTRdIERNQTogcHJlYWxsb2NhdGVkIDQwOTYgS2lCIEdGUF9LRVJORUwgcG9v
bCBmb3IgYXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wMzcwMjBdIERNQTogcHJlYWxsb2NhdGVk
IDQwOTYgS2lCIEdGUF9LRVJORUx8R0ZQX0RNQSBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMK
WyAgICAwLjAzNzE4M10gRE1BOiBwcmVhbGxvY2F0ZWQgNDA5NiBLaUIgR0ZQX0tFUk5FTHxHRlBf
RE1BMzIgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wMzcyNzldIHRoZXJtYWxf
c3lzOiBSZWdpc3RlcmVkIHRoZXJtYWwgZ292ZXJub3IgJ3N0ZXBfd2lzZScKWyAgICAwLjAzNzMy
OV0gY3B1aWRsZTogdXNpbmcgZ292ZXJub3IgbWVudQpbICAgIDAuMDM3NDYxXSBEZXRlY3RlZCAx
NSBQQ0MgU3Vic3BhY2VzClsgICAgMC4wMzc0ODNdIFJlZ2lzdGVyaW5nIFBDQyBkcml2ZXIgYXMg
TWFpbGJveCBjb250cm9sbGVyClsgICAgMC4wMzc1MThdIGh3LWJyZWFrcG9pbnQ6IGZvdW5kIDYg
YnJlYWtwb2ludCBhbmQgNCB3YXRjaHBvaW50IHJlZ2lzdGVycy4KWyAgICAwLjAzNzUyOF0gQVNJ
RCBhbGxvY2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVzClsgICAgMC4wMzc1MzRd
IEFDUEk6IGJ1cyB0eXBlIFBDSSByZWdpc3RlcmVkClsgICAgMC4wMzc1MzddIFNlcmlhbDogQU1C
QSBQTDAxMSBVQVJUIGRyaXZlcgpbICAgIDAuMDM5NjUwXSBIdWdlVExCIHJlZ2lzdGVyZWQgMS4w
MCBHaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAgICAwLjAzOTY1NF0gSHVn
ZVRMQiByZWdpc3RlcmVkIDMyLjAgTWlCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2Vz
ClsgICAgMC4wMzk2NTZdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAyLjAwIE1pQiBwYWdlIHNpemUsIHBy
ZS1hbGxvY2F0ZWQgMCBwYWdlcwpbICAgIDAuMDM5NjU4XSBIdWdlVExCIHJlZ2lzdGVyZWQgNjQu
MCBLaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAgICAwLjA0MDAzNl0gY3J5
cHRkOiBtYXhfY3B1X3FsZW4gc2V0IHRvIDEwMDAKWyAgICAwLjEwODAzM10gcmFpZDY6IG5lb254
OCAgIGdlbigpICA3Nzc4IE1CL3MKWyAgICAwLjE3NjA3OF0gcmFpZDY6IG5lb254OCAgIHhvcigp
ICA2MDYyIE1CL3MKWyAgICAwLjI0NDA2OF0gcmFpZDY6IG5lb254NCAgIGdlbigpICA3NjMwIE1C
L3MKWyAgICAwLjMxMjA4OV0gcmFpZDY6IG5lb254NCAgIHhvcigpICA2MzI2IE1CL3MKWyAgICAw
LjM4MDEwNF0gcmFpZDY6IG5lb254MiAgIGdlbigpICA3MzI5IE1CL3MKWyAgICAwLjQ0ODExOV0g
cmFpZDY6IG5lb254MiAgIHhvcigpICA1NzI4IE1CL3MKWyAgICAwLjUxNjEzOV0gcmFpZDY6IG5l
b254MSAgIGdlbigpICA1OTIzIE1CL3MKWyAgICAwLjU4NDE1OF0gcmFpZDY6IG5lb254MSAgIHhv
cigpICA0OTczIE1CL3MKWyAgICAwLjY1MjE3NF0gcmFpZDY6IGludDY0eDggIGdlbigpICAzNjAy
IE1CL3MKWyAgICAwLjcyMDE5Nl0gcmFpZDY6IGludDY0eDggIHhvcigpICAyMDE5IE1CL3MKWyAg
ICAwLjc4ODIxM10gcmFpZDY6IGludDY0eDQgIGdlbigpICA0MTI3IE1CL3MKWyAgICAwLjg1NjIz
M10gcmFpZDY6IGludDY0eDQgIHhvcigpICAyMTkxIE1CL3MKWyAgICAwLjkyNDI0N10gcmFpZDY6
IGludDY0eDIgIGdlbigpICAzNTA0IE1CL3MKWyAgICAwLjk5MjI2NF0gcmFpZDY6IGludDY0eDIg
IHhvcigpICAxODkyIE1CL3MKWyAgICAxLjA2MDI4NV0gcmFpZDY6IGludDY0eDEgIGdlbigpICAy
ODc1IE1CL3MKWyAgICAxLjEyODMwM10gcmFpZDY6IGludDY0eDEgIHhvcigpICAxNTA3IE1CL3MK
WyAgICAxLjEyODMwNV0gcmFpZDY6IHVzaW5nIGFsZ29yaXRobSBuZW9ueDggZ2VuKCkgNzc3OCBN
Qi9zClsgICAgMS4xMjgzMDddIHJhaWQ2OiAuLi4uIHhvcigpIDYwNjIgTUIvcywgcm13IGVuYWJs
ZWQKWyAgICAxLjEyODMwOF0gcmFpZDY6IHVzaW5nIG5lb24gcmVjb3ZlcnkgYWxnb3JpdGhtClsg
ICAgMS4xMjgzNzZdIEFDUEk6IEFkZGVkIF9PU0koTW9kdWxlIERldmljZSkKWyAgICAxLjEyODM3
OF0gQUNQSTogQWRkZWQgX09TSShQcm9jZXNzb3IgRGV2aWNlKQpbICAgIDEuMTI4MzgwXSBBQ1BJ
OiBBZGRlZCBfT1NJKDMuMCBfU0NQIEV4dGVuc2lvbnMpClsgICAgMS4xMjgzODJdIEFDUEk6IEFk
ZGVkIF9PU0koUHJvY2Vzc29yIEFnZ3JlZ2F0b3IgRGV2aWNlKQpbICAgIDEuMTI4Mzg1XSBBQ1BJ
OiBBZGRlZCBfT1NJKExpbnV4LURlbGwtVmlkZW8pClsgICAgMS4xMjgzODZdIEFDUEk6IEFkZGVk
IF9PU0koTGludXgtTGVub3ZvLU5WLUhETUktQXVkaW8pClsgICAgMS4xMjgzODldIEFDUEk6IEFk
ZGVkIF9PU0koTGludXgtSFBJLUh5YnJpZC1HcmFwaGljcykKWyAgICAxLjE0ODg0Ml0gQUNQSTog
MiBBQ1BJIEFNTCB0YWJsZXMgc3VjY2Vzc2Z1bGx5IGFjcXVpcmVkIGFuZCBsb2FkZWQKWyAgICAx
LjE1NTEwNl0gQUNQSTogSW50ZXJwcmV0ZXIgZW5hYmxlZApbICAgIDEuMTU1MTA5XSBBQ1BJOiBV
c2luZyBHSUMgZm9yIGludGVycnVwdCByb3V0aW5nClsgICAgMS4xNTUxMjddIEFDUEk6IE1DRkcg
dGFibGUgZGV0ZWN0ZWQsIDUgZW50cmllcwpbICAgIDEuMTU1MTMzXSBBQ1BJOiBJT1JUOiBTTU1V
LXYzWzMzZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTU1
MTU3XSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzM3ZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0
eSBkb21haW4gMApbICAgIDEuMTU1MTY5XSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzNmZmZlMDAwMDAw
MF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTU1MTg0XSBBQ1BJOiBJT1JU
OiBTTU1VLXYzWzJiZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAg
IDEuMTU1MTk3XSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzJmZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFBy
b3hpbWl0eSBkb21haW4gMApbICAgIDEuMTU1MjgxXSBIRVNUOiBUYWJsZSBwYXJzaW5nIGhhcyBi
ZWVuIGluaXRpYWxpemVkLgpbICAgIDEuMTkwMjAyXSBBUk1IMDAxMTowMDogdHR5QU1BMCBhdCBN
TUlPIDB4MTAwMDAyNjAwMDAwIChpcnEgPSA3OSwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBClsg
ICAgMy4wMTI4ODZdIHByaW50azogY29uc29sZSBbdHR5QU1BMF0gZW5hYmxlZApbICAgIDMuMDE4
OTI4XSBBUk1IMDAxMTowMTogdHR5QU1BMSBhdCBNTUlPIDB4MTAwMDAyNjIwMDAwIChpcnEgPSA4
MCwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBClsgICAgMy4wMjkwNDhdIEFDUEk6IFBDSSBSb290
IEJyaWRnZSBbUENJMF0gKGRvbWFpbiAwMDBjIFtidXMgMDAtZmZdKQpbICAgIDMuMDM1MjMxXSBh
Y3BpIFBOUDBBMDg6MDA6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENs
b2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICAzLjA0NDMzMV0gYWNwaSBQTlAwQTA4
OjAwOiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29u
dHJvbApbICAgIDMuMDUyMTU1XSBhY3BpIFBOUDBBMDg6MDA6IE1DRkcgcXVpcms6IEVDQU0gYXQg
W21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGgg
MHhmZmZmODAwMDEwZGUwZmMwClsgICAgMy4wNjQ5NjJdIGFjcGkgUE5QMEEwODowMDogRUNBTSBh
cmVhIFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBD
MDI6MDAKWyAgICAzLjA3MzgzM10gYWNwaSBQTlAwQTA4OjAwOiBFQ0FNIGF0IFttZW0gMHgzM2Zm
ZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQpbICAgIDMuMDgxOTkyXSBQ
Q0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGM6MDAKWyAgICAzLjA4NjA3OV0gcGNpX2J1cyAwMDBj
OjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4NDAwMDAwMDAtMHg0ZmZmZmZmZiB3aW5kb3dd
ClsgICAgMy4wOTM1NTBdIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAw
eDMwMDAwMDAwMDAwMC0weDMzZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgMy4xMDE3MTVdIHBjaV9i
dXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0KWyAgICAzLjEwNzIyNV0g
cGNpIDAwMGM6MDA6MDAuMDogWzFkZWY6ZTEwMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMApbICAg
IDMuMTEzMzAyXSBwY2kgMDAwYzowMDowMS4wOiBbMWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4
MDYwNDAwClsgICAgMy4xMTkzNDhdIHBjaSAwMDBjOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyClsg
ICAgMy4xMjM2MDhdIHBjaSAwMDBjOjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEg
RDNob3QKWyAgICAzLjEzMDQ2M10gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbaW8g
IDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDEwMDAKWyAgICAzLjEzODYzMV0g
cGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZm
ZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAw
MApbICAgIDMuMTUwMDk1XSBwY2kgMDAwYzowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgw
MDEwMDAwMC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWdu
IDEwMDAwMApbICAgIDMuMTYwNjA4XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgODogYXNzaWduZWQg
W21lbSAweDQwMDAwMDAwLTB4NDAxZmZmZmZdClsgICAgMy4xNjczODVdIHBjaSAwMDBjOjAwOjAx
LjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0
Yml0IHByZWZdClsgICAgMy4xNzU4MTJdIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFj
ZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICAzLjE4MjA2N10gcGNpIDAwMGM6MDA6MDEuMDog
QkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICAzLjE4ODY3MF0g
cGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDMuMTk0OTI1XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQpbICAgIDMuMjAxNTI5XSBwY2kgMDAwYzowMDowMS4wOiBQQ0kgYnJp
ZGdlIHRvIFtidXMgMDFdClsgICAgMy4yMDY0ODNdIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdl
IHdpbmRvdyBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0KWyAgICAzLjIxMzI2MF0gcGNpIDAw
MGM6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAx
ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICAzLjIyMTY4N10gcGNpX2J1cyAwMDBjOjAwOiByZXNvdXJj
ZSA0IFttZW0gMHg0MDAwMDAwMC0weDRmZmZmZmZmIHdpbmRvd10KWyAgICAzLjIyODU1MF0gcGNp
X2J1cyAwMDBjOjAwOiByZXNvdXJjZSA1IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzM2ZmZGZmZmZm
ZmYgd2luZG93XQpbICAgIDMuMjM2MTA4XSBwY2lfYnVzIDAwMGM6MDE6IHJlc291cmNlIDEgW21l
bSAweDQwMDAwMDAwLTB4NDAxZmZmZmZdClsgICAgMy4yNDIzNjNdIHBjaV9idXMgMDAwYzowMTog
cmVzb3VyY2UgMiBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZd
ClsgICAgMy4yNTAzMDhdIEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJMV0gKGRvbWFpbiAwMDBk
IFtidXMgMDAtZmZdKQpbICAgIDMuMjU2NDg0XSBhY3BpIFBOUDBBMDg6MDE6IF9PU0M6IE9TIHN1
cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBl
M10KWyAgICAzLjI2NTU4M10gYWNwaSBQTlAwQTA4OjAxOiBQQ0llIHBvcnQgc2VydmljZXMgZGlz
YWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbApbICAgIDMuMjczNDA0XSBhY3BpIFBO
UDBBMDg6MDE6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZm
ZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwClsgICAgMy4y
ODYxOTRdIGFjcGkgUE5QMEEwODowMTogRUNBTSBhcmVhIFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgz
N2ZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDAKWyAgICAzLjI5NTA2Nl0gYWNwaSBQ
TlAwQTA4OjAxOiBFQ0FNIGF0IFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZmZmZmZmZdIGZv
ciBbYnVzIDAwLWZmXQpbICAgIDMuMzAzMjE5XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGQ6
MDAKWyAgICAzLjMwNzMwNl0gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVt
IDB4NTAwMDAwMDAtMHg1ZmZmZmZmZiB3aW5kb3ddClsgICAgMy4zMTQ3NzddIHBjaV9idXMgMDAw
ZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDM0MDAwMDAwMDAwMC0weDM3ZmZkZmZmZmZm
ZiB3aW5kb3ddClsgICAgMy4zMjI5NDJdIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3Vy
Y2UgW2J1cyAwMC1mZl0KWyAgICAzLjMyODQ0OF0gcGNpIDAwMGQ6MDA6MDAuMDogWzFkZWY6ZTEw
MF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMApbICAgIDMuMzM0NTEyXSBwY2kgMDAwZDowMDowMS4w
OiBbMWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgMy4zNDA1NDRdIHBjaSAw
MDBkOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgMy4zNDQ4MDNdIHBjaSAwMDBkOjAwOjAx
LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICAzLjM1MDYyNV0gcGNpIDAw
MGQ6MDE6MDAuMDogWzEwZGU6MWU4OV0gdHlwZSAwMCBjbGFzcyAweDAzMDAwMApbICAgIDMuMzU2
NjMwXSBwY2kgMDAwZDowMTowMC4wOiByZWcgMHgxMDogW21lbSAweDUwMDAwMDAwLTB4NTBmZmZm
ZmZdClsgICAgMy4zNjI4OTNdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDE0OiBbbWVtIDB4MzQw
MDAwMDAwMDAwLTB4MzQwMDBmZmZmZmZmIDY0Yml0IHByZWZdClsgICAgMy4zNzA4MDZdIHBjaSAw
MDBkOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MzQwMDEwMDAwMDAwLTB4MzQwMDExZmZmZmZm
IDY0Yml0IHByZWZdClsgICAgMy4zNzg3MTRdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDI0OiBb
aW8gIDB4NTdmZmUwMDAtMHg1N2ZmZTA3Zl0KWyAgICAzLjM4NDk3NF0gcGNpIDAwMGQ6MDE6MDAu
MDogcmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAgMy4zOTE3
MjZdIHBjaSAwMDBkOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xk
ClsgICAgMy4zOTc4NzddIHBjaSAwMDBkOjAxOjAwLjE6IFsxMGRlOjEwZjhdIHR5cGUgMDAgY2xh
c3MgMHgwNDAzMDAKWyAgICAzLjQwMzg4M10gcGNpIDAwMGQ6MDE6MDAuMTogcmVnIDB4MTA6IFtt
ZW0gMHg1MTAwMDAwMC0weDUxMDAzZmZmXQpbICAgIDMuNDEwMjU2XSBwY2kgMDAwZDowMTowMC4y
OiBbMTBkZToxYWQ4XSB0eXBlIDAwIGNsYXNzIDB4MGMwMzMwClsgICAgMy40MTYyNjVdIHBjaSAw
MDBkOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4MzQwMDEyMDAwMDAwLTB4MzQwMDEyMDNmZmZm
IDY0Yml0IHByZWZdClsgICAgMy40MjQxODFdIHBjaSAwMDBkOjAxOjAwLjI6IHJlZyAweDFjOiBb
bWVtIDB4MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRmZmZmIDY0Yml0IHByZWZdClsgICAgMy40MzIx
MzddIHBjaSAwMDBkOjAxOjAwLjI6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xk
ClsgICAgMy40MzgyNzJdIHBjaSAwMDBkOjAxOjAwLjM6IFsxMGRlOjFhZDldIHR5cGUgMDAgY2xh
c3MgMHgwYzgwMDAKWyAgICAzLjQ0NDI3OF0gcGNpIDAwMGQ6MDE6MDAuMzogcmVnIDB4MTA6IFtt
ZW0gMHg1MTAwNDAwMC0weDUxMDA0ZmZmXQpbICAgIDMuNDUwNjAxXSBwY2kgMDAwZDowMTowMC4z
OiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDMuNDU2NzM2XSBwY2kg
MDAwZDowMDowMS4wOiBBU1BNOiBjdXJyZW50IGNvbW1vbiBjbG9jayBjb25maWd1cmF0aW9uIGlz
IGluY29uc2lzdGVudCwgcmVjb25maWd1cmluZwpbICAgIDMuNDc4MDExXSBwY2kgMDAwZDowMDow
MS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAxN2ZmZmZmZiA2
NGJpdCBwcmVmXQpbICAgIDMuNDg2NDM5XSBwY2kgMDAwZDowMDowMS4wOiBCQVIgODogYXNzaWdu
ZWQgW21lbSAweDUwMDAwMDAwLTB4NTE3ZmZmZmZdClsgICAgMy40OTMyMTVdIHBjaSAwMDBkOjAw
OjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICAzLjQ5OTQ3
MF0gcGNpIDAwMGQ6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4
MTAwMF0KWyAgICAzLjUwNjA3NV0gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFtt
ZW0gMHgzNDAwMDAwMDAwMDAtMHgzNDAwMGZmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICAzLjUxNDUw
OF0gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTAwMDAwMDAt
MHgzNDAwMTFmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICAzLjUyMjk0MF0gcGNpIDAwMGQ6MDE6MDAu
MDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MDAwMDAwMC0weDUwZmZmZmZmXQpbICAgIDMuNTI5
NzE4XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDUxMDAwMDAwLTB4
NTEwN2ZmZmYgcHJlZl0KWyAgICAzLjUzNjkyOV0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDA6IGFz
c2lnbmVkIFttZW0gMHgzNDAwMTIwMDAwMDAtMHgzNDAwMTIwM2ZmZmYgNjRiaXQgcHJlZl0KWyAg
ICAzLjU0NTM2MV0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAw
MTIwNDAwMDAtMHgzNDAwMTIwNGZmZmYgNjRiaXQgcHJlZl0KWyAgICAzLjU1Mzc5M10gcGNpIDAw
MGQ6MDE6MDAuMTogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MTA4MDAwMC0weDUxMDgzZmZmXQpb
ICAgIDMuNTYwNTcxXSBwY2kgMDAwZDowMTowMC4zOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDUx
MDg0MDAwLTB4NTEwODRmZmZdClsgICAgMy41NjczNTBdIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiA1
OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MDA4MF0KWyAgICAzLjU3MzYwNV0gcGNpIDAwMGQ6
MDE6MDAuMDogQkFSIDU6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0KWyAgICAz
LjU4MDIwOV0gcGNpIDAwMGQ6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQpbICAgIDMu
NTg1MTYzXSBwY2kgMDAwZDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDUwMDAwMDAw
LTB4NTE3ZmZmZmZdClsgICAgMy41OTE5MzldIHBjaSAwMDBkOjAwOjAxLjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0Yml0IHByZWZdClsgICAg
My42MDAzNjZdIHBjaV9idXMgMDAwZDowMDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUg
dW5hc3NpZ25lZCwgdHJ5IGJvb3Rpbmcgd2l0aCBwY2k9cmVhbGxvYwpbICAgIDMuNjA5Mzk5XSBw
Y2lfYnVzIDAwMGQ6MDA6IHJlc291cmNlIDQgW21lbSAweDUwMDAwMDAwLTB4NWZmZmZmZmYgd2lu
ZG93XQpbICAgIDMuNjE2MjYzXSBwY2lfYnVzIDAwMGQ6MDA6IHJlc291cmNlIDUgW21lbSAweDM0
MDAwMDAwMDAwMC0weDM3ZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgMy42MjM4MjBdIHBjaV9idXMg
MDAwZDowMTogcmVzb3VyY2UgMSBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0KWyAgICAzLjYz
MDA4MF0gcGNpX2J1cyAwMDBkOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgz
NDAwMTdmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICAzLjYzODAzOF0gQUNQSTogUENJIFJvb3QgQnJp
ZGdlIFtQQ0kzXSAoZG9tYWluIDAwMDAgW2J1cyAwMC1mZl0pClsgICAgMy42NDQyMTZdIGFjcGkg
UE5QMEEwODowMzogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQ
TSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDMuNjUzMzE2XSBhY3BpIFBOUDBBMDg6MDM6
IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9s
ClsgICAgMy42NjExMzddIGFjcGkgUE5QMEEwODowMzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVt
IDB4M2ZmZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZm
ZmY4MDAwMTBkZTBmYzAKWyAgICAzLjY3MzkyNV0gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGFyZWEg
W21lbSAweDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjow
MApbICAgIDMuNjgyNzk1XSBhY3BpIFBOUDBBMDg6MDM6IEVDQU0gYXQgW21lbSAweDNmZmZmMDAw
MDAwMC0weDNmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdClsgICAgMy42OTA5NDhdIFBDSSBo
b3N0IGJyaWRnZSB0byBidXMgMDAwMDowMApbICAgIDMuNjk1MDM1XSBwY2lfYnVzIDAwMDA6MDA6
IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHg3MDAwMDAwMC0weDdmZmZmZmZmIHdpbmRvd10KWyAg
ICAzLjcwMjUwNV0gcGNpX2J1cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4M2Mw
MDAwMDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICAzLjcxMDY3MV0gcGNpX2J1cyAw
MDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQpbICAgIDMuNzE2MTc2XSBwY2kg
MDAwMDowMDowMC4wOiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwClsgICAgMy43
MjIyMzhdIHBjaSAwMDAwOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0
MDAKWyAgICAzLjcyODI3MV0gcGNpIDAwMDA6MDA6MDEuMDogc3VwcG9ydHMgRDEgRDIKWyAgICAz
LjczMjUzMF0gcGNpIDAwMDA6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hv
dApbICAgIDMuNzM4MzQ5XSBwY2kgMDAwMDowMTowMC4wOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNs
YXNzIDB4MDIwMDAwClsgICAgMy43NDQzNTddIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDEwOiBb
bWVtIDB4M2MwMDAzMDAwMDAwLTB4M2MwMDAzZmZmZmZmIDY0Yml0IHByZWZdClsgICAgMy43NTIy
NzRdIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODE4MDAwLTB4M2Mw
MDA0ODFmZmZmIDY0Yml0IHByZWZdClsgICAgMy43NjAxODddIHBjaSAwMDAwOjAxOjAwLjA6IHJl
ZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDMuNzY2OTQ5XSBw
Y2kgMDAwMDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAg
IDMuNzczMTA5XSBwY2kgMDAwMDowMTowMC4xOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4
MDIwMDAwClsgICAgMy43NzkxMTddIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4
M2MwMDAyMDAwMDAwLTB4M2MwMDAyZmZmZmZmIDY0Yml0IHByZWZdClsgICAgMy43ODcwMzRdIHBj
aSAwMDAwOjAxOjAwLjE6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODEwMDAwLTB4M2MwMDA0ODE3
ZmZmIDY0Yml0IHByZWZdClsgICAgMy43OTQ5NDddIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDMw
OiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDMuODAxNzA0XSBwY2kgMDAw
MDowMTowMC4xOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDMuODA3
ODUzXSBwY2kgMDAwMDowMTowMC4yOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAw
ClsgICAgMy44MTM4NjJdIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAx
MDAwMDAwLTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdClsgICAgMy44MjE3NzldIHBjaSAwMDAw
OjAxOjAwLjI6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODA4MDAwLTB4M2MwMDA0ODBmZmZmIDY0
Yml0IHByZWZdClsgICAgMy44Mjk2OTFdIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDMwOiBbbWVt
IDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDMuODM2NDQ5XSBwY2kgMDAwMDowMTow
MC4yOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDMuODQyNTk1XSBw
Y2kgMDAwMDowMTowMC4zOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAg
My44NDg2MDRdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAwMDAwMDAw
LTB4M2MwMDAwZmZmZmZmIDY0Yml0IHByZWZdClsgICAgMy44NTY1MjFdIHBjaSAwMDAwOjAxOjAw
LjM6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODAwMDAwLTB4M2MwMDA0ODA3ZmZmIDY0Yml0IHBy
ZWZdClsgICAgMy44NjQ0MzNdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDMwOiBbbWVtIDB4ZmZm
ODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDMuODcxMTkwXSBwY2kgMDAwMDowMTowMC4zOiBQ
TUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDMuODc3MzUyXSBwY2kgMDAw
MDowMDowMS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMS0w
Ml0gYWRkX3NpemUgMTAwMApbICAgIDMuODg1NzgyXSBwY2kgMDAwMDowMDowMS4wOiBCQVIgOTog
YXNzaWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQpb
ICAgIDMuODk0MjA4XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDcw
MDAwMDAwLTB4NzAxZmZmZmZdClsgICAgMy45MDA5ODVdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3
OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICAzLjkwNzI0MF0gcGNpIDAwMDA6
MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICAz
LjkxMzg0NF0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUg
MHgxMDAwXQpbICAgIDMuOTIwMDk5XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRv
IGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDMuOTI2NzA0XSBwY2kgMDAwMDowMTowMC4w
OiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwMGZmZmZmZiA2NGJp
dCBwcmVmXQpbICAgIDMuOTM1MTM2XSBwY2kgMDAwMDowMTowMC4xOiBCQVIgMDogYXNzaWduZWQg
W21lbSAweDNjMDAwMTAwMDAwMC0weDNjMDAwMWZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDMuOTQz
NTY4XSBwY2kgMDAwMDowMTowMC4yOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMjAwMDAw
MC0weDNjMDAwMmZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDMuOTUxOTk5XSBwY2kgMDAwMDowMTow
MC4zOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMzAwMDAwMC0weDNjMDAwM2ZmZmZmZiA2
NGJpdCBwcmVmXQpbICAgIDMuOTYwNDMxXSBwY2kgMDAwMDowMTowMC4wOiBCQVIgNjogYXNzaWdu
ZWQgW21lbSAweDcwMDAwMDAwLTB4NzAwN2ZmZmYgcHJlZl0KWyAgICAzLjk2NzY0Ml0gcGNpIDAw
MDA6MDE6MDAuMTogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg3MDA4MDAwMC0weDcwMGZmZmZmIHBy
ZWZdClsgICAgMy45NzQ4NjRdIHBjaSAwMDAwOjAxOjAwLjI6IEJBUiA2OiBhc3NpZ25lZCBbbWVt
IDB4NzAxMDAwMDAtMHg3MDE3ZmZmZiBwcmVmXQpbICAgIDMuOTgyMDc1XSBwY2kgMDAwMDowMTow
MC4zOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDcwMTgwMDAwLTB4NzAxZmZmZmYgcHJlZl0KWyAg
ICAzLjk4OTI4Nl0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAw
MDQwMDAwMDAtMHgzYzAwMDQwMDdmZmYgNjRiaXQgcHJlZl0KWyAgICAzLjk5NzcxOF0gcGNpIDAw
MDA6MDE6MDAuMTogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDgwMDAtMHgzYzAwMDQw
MGZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjAwNjE1MF0gcGNpIDAwMDA6MDE6MDAuMjogQkFSIDM6
IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMTAwMDAtMHgzYzAwMDQwMTdmZmYgNjRiaXQgcHJlZl0K
WyAgICA0LjAxNDU4Ml0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgz
YzAwMDQwMTgwMDAtMHgzYzAwMDQwMWZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjAyMzAxNF0gcGNp
IDAwMDA6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxLTAyXQpbICAgIDQuMDI4MjI4XSBw
Y2kgMDAwMDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZm
ZmZdClsgICAgNC4wMzUwMDVdIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVt
IDB4M2MwMDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNC4wNDM0MzJd
IHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNCBbbWVtIDB4NzAwMDAwMDAtMHg3ZmZmZmZmZiB3
aW5kb3ddClsgICAgNC4wNTAyOTVdIHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNSBbbWVtIDB4
M2MwMDAwMDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjA1Nzg1Ml0gcGNpX2J1
cyAwMDAwOjAxOiByZXNvdXJjZSAxIFttZW0gMHg3MDAwMDAwMC0weDcwMWZmZmZmXQpbICAgIDQu
MDY0MTA4XSBwY2lfYnVzIDAwMDA6MDE6IHJlc291cmNlIDIgW21lbSAweDNjMDAwMDAwMDAwMC0w
eDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuMDcyMDcxXSBBQ1BJOiBQQ0kgUm9vdCBC
cmlkZ2UgW1BDSTZdIChkb21haW4gMDAwNCBbYnVzIDAwLWZmXSkKWyAgICA0LjA3ODI0OV0gYWNw
aSBQTlAwQTA4OjA2OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9j
a1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAgNC4wODczNDldIGFjcGkgUE5QMEEwODow
NjogUENJZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNvbnRy
b2wKWyAgICA0LjA5NTE3MF0gYWNwaSBQTlAwQTA4OjA2OiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFtt
ZW0gMHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4
ZmZmZjgwMDAxMGRlMGZjMApbICAgIDQuMTA3OTU4XSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0gYXJl
YSBbbWVtIDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAwQzAy
OjAwClsgICAgNC4xMTY4MzZdIGFjcGkgUE5QMEEwODowNjogRUNBTSBhdCBbbWVtIDB4MmJmZmYw
MDAwMDAwLTB4MmJmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0KWyAgICA0LjEyNDk5MV0gUENJ
IGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDA0OjAwClsgICAgNC4xMjkwNzhdIHBjaV9idXMgMDAwNDow
MDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpb
ICAgIDQuMTM2NTQ4XSBwY2lfYnVzIDAwMDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgy
ODAwMDAwMDAwMDAtMHgyYmZmZGZmZmZmZmYgd2luZG93XQpbICAgIDQuMTQ0NzE0XSBwY2lfYnVz
IDAwMDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdClsgICAgNC4xNTAyMjBdIHBj
aSAwMDA0OjAwOjAwLjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDAKWyAgICA0
LjE1NjI4MV0gcGNpIDAwMDQ6MDA6MDEuMDogWzFkZWY6ZTExMV0gdHlwZSAwMSBjbGFzcyAweDA2
MDQwMApbICAgIDQuMTYyMzE2XSBwY2kgMDAwNDowMDowMS4wOiBzdXBwb3J0cyBEMSBEMgpbICAg
IDQuMTY2NTc1XSBwY2kgMDAwNDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQz
aG90ClsgICAgNC4xNzIzNTVdIHBjaSAwMDA0OjAwOjAzLjA6IFsxZGVmOmUxMTNdIHR5cGUgMDEg
Y2xhc3MgMHgwNjA0MDAKWyAgICA0LjE3ODM4OV0gcGNpIDAwMDQ6MDA6MDMuMDogc3VwcG9ydHMg
RDEgRDIKWyAgICA0LjE4MjY0OF0gcGNpIDAwMDQ6MDA6MDMuMDogUE1FIyBzdXBwb3J0ZWQgZnJv
bSBEMCBEMSBEM2hvdApbICAgIDQuMTg4NDMyXSBwY2kgMDAwNDowMDowNS4wOiBbMWRlZjplMTE1
XSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNC4xOTQ0NzVdIHBjaSAwMDA0OjAwOjA1LjA6
IHN1cHBvcnRzIEQxIEQyClsgICAgNC4xOTg3MzRdIHBjaSAwMDA0OjAwOjA1LjA6IFBNRSMgc3Vw
cG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA0LjIwNDU1M10gcGNpIDAwMDQ6MDE6MDAuMDog
WzFhMDM6MTE1MF0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDQuMjEwNTk4XSBwY2kgMDAw
NDowMTowMC4wOiBlbmFibGluZyBFeHRlbmRlZCBUYWdzClsgICAgNC4yMTU2MTNdIHBjaSAwMDA0
OjAxOjAwLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNC4yMTk4NzJdIHBjaSAwMDA0OjAxOjAwLjA6
IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDIgRDNob3QgRDNjb2xkClsgICAgNC4yMjY1NzVd
IHBjaV9idXMgMDAwNDowMjogZXh0ZW5kZWQgY29uZmlnIHNwYWNlIG5vdCBhY2Nlc3NpYmxlClsg
ICAgNC4yMzI2NzldIHBjaSAwMDA0OjAyOjAwLjA6IFsxYTAzOjIwMDBdIHR5cGUgMDAgY2xhc3Mg
MHgwMzAwMDAKWyAgICA0LjIzODY5M10gcGNpIDAwMDQ6MDI6MDAuMDogcmVnIDB4MTA6IFttZW0g
MHgyMDAwMDAwMC0weDIwZmZmZmZmXQpbICAgIDQuMjQ0OTU5XSBwY2kgMDAwNDowMjowMC4wOiBy
ZWcgMHgxNDogW21lbSAweDIxMDAwMDAwLTB4MjEwMWZmZmZdClsgICAgNC4yNTEyMjRdIHBjaSAw
MDA0OjAyOjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmYwMDAtMHgyN2ZmZjA3Zl0KWyAgICA0
LjI1NzU2Ml0gcGNpIDAwMDQ6MDI6MDAuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA0LjI2MTgyMV0g
cGNpIDAwMDQ6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEMiBEM2hvdCBEM2Nv
bGQKWyAgICA0LjI2ODU2M10gcGNpIDAwMDQ6MDM6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBj
bGFzcyAweDBjMDMzMApbICAgIDQuMjc0NTc4XSBwY2kgMDAwNDowMzowMC4wOiByZWcgMHgxMDog
W21lbSAweDIxMjAwMDAwLTB4MjEyMDFmZmYgNjRiaXRdClsgICAgNC4yODE0NTldIHBjaSAwMDA0
OjAzOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAgNC4yODc2
ODJdIHBjaSAwMDA0OjA0OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUgMDAgY2xhc3MgMHgwMjAwMDAK
WyAgICA0LjI5MzcwN10gcGNpIDAwMDQ6MDQ6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMTEwMDAw
MC0weDIxMTdmZmZmXQpbICAgIDQuMjk5OTkzXSBwY2kgMDAwNDowNDowMC4wOiByZWcgMHgxODog
W2lvICAweDI3ZmZlMDAwLTB4MjdmZmUwMWZdClsgICAgNC4zMDYyNjRdIHBjaSAwMDA0OjA0OjAw
LjA6IHJlZyAweDFjOiBbbWVtIDB4MjExODAwMDAtMHgyMTE4M2ZmZl0KWyAgICA0LjMxMjY5Nl0g
cGNpIDAwMDQ6MDQ6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAg
ICA0LjMxODg5MV0gcGNpIDAwMDQ6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAw
MDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxLTAyXSBhZGRfc2l6ZSAyMDAwMDAg
YWRkX2FsaWduIDEwMDAwMApbICAgIDQuMzMwNjE3XSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ug
d2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMApbICAg
IDQuMzM4NzgzXSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAw
MC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBhZGRf
YWxpZ24gMTAwMDAwClsgICAgNC4zNTAyNDhdIHBjaSAwMDA0OjAwOjAzLjA6IGJyaWRnZSB3aW5k
b3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDEwMDAw
MCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNC4zNjA3NTldIHBjaSAwMDA0OjAwOjA1LjA6IGJyaWRn
ZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAw
NF0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA0LjM3MjIyM10gcGNpIDAw
MDQ6MDA6MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8g
W2J1cyAwNF0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA0LjM4MjczNV0g
cGNpIDAwMDQ6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIxN2Zm
ZmZmXQpbICAgIDQuMzg5NTEzXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21l
bSAweDI4MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuMzk3OTM4
XSBwY2kgMDAwNDowMDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIxODAwMDAwLTB4MjE5
ZmZmZmZdClsgICAgNC40MDQ3MTVdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBb
bWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNC40MTMx
NDFdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjFhMDAwMDAtMHgy
MWJmZmZmZl0KWyAgICA0LjQxOTkxOF0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDk6IGFzc2lnbmVk
IFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjQy
ODM0M10gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgx
MDAwXQpbICAgIDQuNDM0NTk5XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFz
c2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuNDQxMjAyXSBwY2kgMDAwNDowMDowMy4wOiBC
QVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNC40NDc0NTddIHBjaSAw
MDA0OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsg
ICAgNC40NTQwNjBdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBz
aXplIDB4MTAwMF0KWyAgICA0LjQ2MDMxNV0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDc6IGZhaWxl
ZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjQ2NjkxOV0gcGNpIDAwMDQ6MDA6
MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuNDczMTc1
XSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgx
MDAwXQpbICAgIDQuNDc5Nzc3XSBwY2kgMDAwNDowMDowNS4wOiBCQVIgNzogbm8gc3BhY2UgZm9y
IFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNC40ODYwMzNdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3
OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNC40OTI2MzVdIHBjaSAw
MDA0OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0
LjQ5ODg5MF0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBz
aXplIDB4MTAwMF0KWyAgICA0LjUwNTQ5NF0gcGNpIDAwMDQ6MDE6MDAuMDogQkFSIDg6IGFzc2ln
bmVkIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDQuNTEyMjcwXSBwY2kgMDAwNDow
MTowMC4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNC41MTg1
MjVdIHBjaSAwMDA0OjAxOjAwLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAw
eDEwMDBdClsgICAgNC41MjUxMjhdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBb
bWVtIDB4MjAwMDAwMDAtMHgyMGZmZmZmZl0KWyAgICA0LjUzMTkxNl0gcGNpIDAwMDQ6MDI6MDAu
MDogQkFSIDE6IGFzc2lnbmVkIFttZW0gMHgyMTAwMDAwMC0weDIxMDFmZmZmXQpbICAgIDQuNTM4
Njk1XSBwY2kgMDAwNDowMjowMC4wOiBCQVIgMjogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDAw
ODBdClsgICAgNC41NDQ5NTFdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAyOiBmYWlsZWQgdG8gYXNz
aWduIFtpbyAgc2l6ZSAweDAwODBdClsgICAgNC41NTE1NTRdIHBjaSAwMDA0OjAxOjAwLjA6IFBD
SSBicmlkZ2UgdG8gW2J1cyAwMl0KWyAgICA0LjU1NjUxMF0gcGNpIDAwMDQ6MDE6MDAuMDogICBi
cmlkZ2Ugd2luZG93IFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDQuNTYzMjkzXSBw
Y2kgMDAwNDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDEtMDJdClsgICAgNC41Njg1MDdd
IHBjaSAwMDA0OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjAwMDAwMDAtMHgyMTdm
ZmZmZl0KWyAgICA0LjU3NTI4NF0gcGNpIDAwMDQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFtt
ZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjU4Mzcx
Ml0gcGNpIDAwMDQ6MDM6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMTgwMDAwMC0weDIx
ODAxZmZmIDY0Yml0XQpbICAgIDQuNTkxMDE4XSBwY2kgMDAwNDowMDowMy4wOiBQQ0kgYnJpZGdl
IHRvIFtidXMgMDNdClsgICAgNC41OTU5NzJdIHBjaSAwMDA0OjAwOjAzLjA6ICAgYnJpZGdlIHdp
bmRvdyBbbWVtIDB4MjE4MDAwMDAtMHgyMTlmZmZmZl0KWyAgICA0LjYwMjc0OF0gcGNpIDAwMDQ6
MDA6MDMuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZm
ZmYgNjRiaXQgcHJlZl0KWyAgICA0LjYxMTE3Nl0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDA6IGFz
c2lnbmVkIFttZW0gMHgyMWEwMDAwMC0weDIxYTdmZmZmXQpbICAgIDQuNjE3OTU4XSBwY2kgMDAw
NDowNDowMC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDIxYTgwMDAwLTB4MjFhODNmZmZdClsg
ICAgNC42MjQ3MzhdIHBjaSAwMDA0OjA0OjAwLjA6IEJBUiAyOiBubyBzcGFjZSBmb3IgW2lvICBz
aXplIDB4MDAyMF0KWyAgICA0LjYzMDk5M10gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDI6IGZhaWxl
ZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDAyMF0KWyAgICA0LjYzNzU5Nl0gcGNpIDAwMDQ6MDA6
MDUuMDogUENJIGJyaWRnZSB0byBbYnVzIDA0XQpbICAgIDQuNjQyNTUwXSBwY2kgMDAwNDowMDow
NS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIxYTAwMDAwLTB4MjFiZmZmZmZdClsgICAgNC42
NDkzMjddIHBjaSAwMDA0OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwNDAw
MDAwLTB4MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNC42NTc3NTRdIHBjaV9idXMgMDAw
NDowMDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5IGJvb3Rp
bmcgd2l0aCBwY2k9cmVhbGxvYwpbICAgIDQuNjY2Nzg3XSBwY2lfYnVzIDAwMDQ6MDA6IHJlc291
cmNlIDQgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpbICAgIDQuNjczNjUwXSBw
Y2lfYnVzIDAwMDQ6MDA6IHJlc291cmNlIDUgW21lbSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZm
ZmZmZiB3aW5kb3ddClsgICAgNC42ODEyMDhdIHBjaV9idXMgMDAwNDowMTogcmVzb3VyY2UgMSBb
bWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0KWyAgICA0LjY4NzQ2M10gcGNpX2J1cyAwMDA0OjAx
OiByZXNvdXJjZSAyIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJl
Zl0KWyAgICA0LjY5NTM2OF0gcGNpX2J1cyAwMDA0OjAyOiByZXNvdXJjZSAxIFttZW0gMHgyMDAw
MDAwMC0weDIxN2ZmZmZmXQpbICAgIDQuNzAxNjI0XSBwY2lfYnVzIDAwMDQ6MDM6IHJlc291cmNl
IDEgW21lbSAweDIxODAwMDAwLTB4MjE5ZmZmZmZdClsgICAgNC43MDc4NzldIHBjaV9idXMgMDAw
NDowMzogcmVzb3VyY2UgMiBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0
IHByZWZdClsgICAgNC43MTU3ODRdIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMSBbbWVtIDB4
MjFhMDAwMDAtMHgyMWJmZmZmZl0KWyAgICA0LjcyMjAzOV0gcGNpX2J1cyAwMDA0OjA0OiByZXNv
dXJjZSAyIFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAg
ICA0LjcyOTk5M10gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0k3XSAoZG9tYWluIDAwMDUgW2J1
cyAwMC1mZl0pClsgICAgNC43MzYxNzFdIGFjcGkgUE5QMEEwODowNzogX09TQzogT1Mgc3VwcG9y
dHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpb
ICAgIDQuNzQ1MjcxXSBhY3BpIFBOUDBBMDg6MDc6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxl
ZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsgICAgNC43NTMwOTJdIGFjcGkgUE5QMEEw
ODowNzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4MmZmZmZmZmZm
ZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzAKWyAgICA0Ljc2NTg4
MF0gYWNwaSBQTlAwQTA4OjA3OiBFQ0FNIGFyZWEgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZm
ZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApbICAgIDQuNzc0NzUxXSBhY3BpIFBOUDBB
MDg6MDc6IEVDQU0gYXQgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZmZmZmZl0gZm9yIFti
dXMgMDAtZmZdClsgICAgNC43ODI5MDFdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwNTowMApb
ICAgIDQuNzg2OTg4XSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgz
MDAwMDAwMC0weDNmZmZmZmZmIHdpbmRvd10KWyAgICA0Ljc5NDQ1OV0gcGNpX2J1cyAwMDA1OjAw
OiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmZmZmRmZmZmZmZmIHdp
bmRvd10KWyAgICA0LjgwMjYyNF0gcGNpX2J1cyAwMDA1OjAwOiByb290IGJ1cyByZXNvdXJjZSBb
YnVzIDAwLWZmXQpbICAgIDQuODA4MTMwXSBwY2kgMDAwNTowMDowMC4wOiBbMWRlZjplMTEwXSB0
eXBlIDAwIGNsYXNzIDB4MDYwMDAwClsgICAgNC44MTQxOTddIHBjaSAwMDA1OjAwOjAxLjA6IFsx
ZGVmOmUxMTFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA0LjgyMDI0MF0gcGNpIDAwMDU6
MDA6MDEuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA0LjgyNDQ5OF0gcGNpIDAwMDU6MDA6MDEuMDog
UE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDQuODMwMjg0XSBwY2kgMDAwNTow
MDowMy4wOiBbMWRlZjplMTEzXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNC44MzYzMThd
IHBjaSAwMDA1OjAwOjAzLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNC44NDA1NzddIHBjaSAwMDA1
OjAwOjAzLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA0Ljg0NjM1OV0g
cGNpIDAwMDU6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAg
IDQuODUyNDAxXSBwY2kgMDAwNTowMDowNS4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDQuODU2NjYw
XSBwY2kgMDAwNTowMDowNS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90ClsgICAg
NC44NjI0NDBdIHBjaSAwMDA1OjAwOjA3LjA6IFsxZGVmOmUxMTddIHR5cGUgMDEgY2xhc3MgMHgw
NjA0MDAKWyAgICA0Ljg2ODQ2OV0gcGNpIDAwMDU6MDA6MDcuMDogc3VwcG9ydHMgRDEgRDIKWyAg
ICA0Ljg3MjcyOF0gcGNpIDAwMDU6MDA6MDcuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBE
M2hvdApbICAgIDQuODc5NjA5XSBwY2kgMDAwNTowMjowMC4wOiBbMTkxMjowMDE0XSB0eXBlIDAw
IGNsYXNzIDB4MGMwMzMwClsgICAgNC44ODU2MjVdIHBjaSAwMDA1OjAyOjAwLjA6IHJlZyAweDEw
OiBbbWVtIDB4MzAxMDAwMDAtMHgzMDEwMWZmZiA2NGJpdF0KWyAgICA0Ljg5MjUwNV0gcGNpIDAw
MDU6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAgICA0Ljg5
OTc2OF0gcGNpIDAwMDU6MDQ6MDAuMDogWzEyNmY6MjI2M10gdHlwZSAwMCBjbGFzcyAweDAxMDgw
MgpbICAgIDQuOTA1NzgyXSBwY2kgMDAwNTowNDowMC4wOiByZWcgMHgxMDogW21lbSAweDMwMDAw
MDAwLTB4MzAwMDNmZmYgNjRiaXRdClsgICAgNC45MTI3MzldIHBjaSAwMDA1OjAwOjAxLjA6IGJy
aWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAxMDAw
ClsgICAgNC45MjA5MDVdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAw
MTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMjAwMDAw
IGFkZF9hbGlnbiAxMDAwMDAKWyAgICA0LjkzMjM2OV0gcGNpIDAwMDU6MDA6MDEuMDogYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUg
MjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA0Ljk0Mjg3OV0gcGNpIDAwMDU6MDA6MDMuMDog
YnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDJdIGFkZF9zaXplIDEw
MDAKWyAgICA0Ljk1MTA0NF0gcGNpIDAwMDU6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4
MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAyXSBhZGRfc2l6ZSAyMDAw
MDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDQuOTYyNTA5XSBwY2kgMDAwNTowMDowMy4wOiBicmlk
Z2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBbYnVzIDAyXSBhZGRfc2l6
ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDQuOTczMDE4XSBwY2kgMDAwNTowMDowNS4w
OiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUg
MTAwMApbICAgIDQuOTgxMTgzXSBwY2kgMDAwNTowMDowNS4wOiBicmlkZ2Ugd2luZG93IFttZW0g
MHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIw
MDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNC45OTI2NDhdIHBjaSAwMDA1OjAwOjA1LjA6IGJy
aWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9z
aXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNS4wMDMxNTddIHBjaSAwMDA1OjAwOjA3
LjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDA0XSBhZGRfc2l6
ZSAxMDAwClsgICAgNS4wMTEzMjJdIHBjaSAwMDA1OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW21l
bSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUg
MjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjAyMjc4N10gcGNpIDAwMDU6MDA6MDcuMDog
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAwNF0gYWRk
X3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjAzMzMwMV0gcGNpIDAwMDU6MDA6
MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMC0weDMwMWZmZmZmXQpbICAgIDUu
MDQwMDc5XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAwMDAw
MDAwMC0weDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDQ4NTA0XSBwY2kgMDAwNTow
MDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdClsgICAg
NS4wNTUyODFdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MmMwMDAw
MjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS4wNjM3MDddIHBjaSAwMDA1
OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0KWyAg
ICA1LjA3MDQ4NF0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyYzAw
MDA0MDAwMDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjA3ODkwOV0gcGNpIDAw
MDU6MDA6MDcuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAwMC0weDMwN2ZmZmZmXQpb
ICAgIDUuMDg1Njg2XSBwY2kgMDAwNTowMDowNy4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJj
MDAwMDYwMDAwMC0weDJjMDAwMDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDk0MTEyXSBwY2kg
MDAwNTowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAg
NS4xMDAzNjddIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAg
c2l6ZSAweDEwMDBdClsgICAgNS4xMDY5NzBdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBubyBz
cGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjExMzIyNV0gcGNpIDAwMDU6MDA6MDMu
MDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjExOTgy
OF0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAw
XQpbICAgIDUuMTI2MDgzXSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuMTMyNjg2XSBwY2kgMDAwNTowMDowNy4wOiBCQVIg
Nzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS4xMzg5NDFdIHBjaSAwMDA1
OjAwOjA3LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAg
NS4xNDU1NDZdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXpl
IDB4MTAwMF0KWyAgICA1LjE1MTgwMV0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDc6IGZhaWxlZCB0
byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjE1ODQwNF0gcGNpIDAwMDU6MDA6MDUu
MDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuMTY0NjU5XSBw
Y2kgMDAwNTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAw
XQpbICAgIDUuMTcxMjYyXSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtp
byAgc2l6ZSAweDEwMDBdClsgICAgNS4xNzc1MThdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBm
YWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS4xODQxMjFdIHBjaSAwMDA1
OjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjE5
MDM3Nl0gcGNpIDAwMDU6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXpl
IDB4MTAwMF0KWyAgICA1LjE5Njk3OV0gcGNpIDAwMDU6MDA6MDEuMDogUENJIGJyaWRnZSB0byBb
YnVzIDAxXQpbICAgIDUuMjAxOTMzXSBwY2kgMDAwNTowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cg
W21lbSAweDMwMDAwMDAwLTB4MzAxZmZmZmZdClsgICAgNS4yMDg3MTBdIHBjaSAwMDA1OjAwOjAx
LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmMwMDAwMWZmZmZmIDY0
Yml0IHByZWZdClsgICAgNS4yMTcxMzhdIHBjaSAwMDA1OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25l
ZCBbbWVtIDB4MzAyMDAwMDAtMHgzMDIwMWZmZiA2NGJpdF0KWyAgICA1LjIyNDQ0NF0gcGNpIDAw
MDU6MDA6MDMuMDogUENJIGJyaWRnZSB0byBbYnVzIDAyXQpbICAgIDUuMjI5Mzk4XSBwY2kgMDAw
NTowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdClsg
ICAgNS4yMzYxNzRdIHBjaSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMw
MDAwMjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS4yNDQ2MDFdIHBjaSAw
MDA1OjAwOjA1LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwM10KWyAgICA1LjI0OTU1NV0gcGNpIDAw
MDU6MDA6MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDQwMDAwMC0weDMwNWZmZmZmXQpb
ICAgIDUuMjU2MzMxXSBwY2kgMDAwNTowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJj
MDAwMDQwMDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMjY0NzU5XSBwY2kg
MDAwNTowNDowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDMwNjAwMDAwLTB4MzA2MDNmZmYg
NjRiaXRdClsgICAgNS4yNzIwNjNdIHBjaSAwMDA1OjAwOjA3LjA6IFBDSSBicmlkZ2UgdG8gW2J1
cyAwNF0KWyAgICA1LjI3NzAxN10gcGNpIDAwMDU6MDA6MDcuMDogICBicmlkZ2Ugd2luZG93IFtt
ZW0gMHgzMDYwMDAwMC0weDMwN2ZmZmZmXQpbICAgIDUuMjgzNzk0XSBwY2kgMDAwNTowMDowNy4w
OiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDYwMDAwMC0weDJjMDAwMDdmZmZmZiA2NGJp
dCBwcmVmXQpbICAgIDUuMjkyMjIwXSBwY2lfYnVzIDAwMDU6MDA6IHJlc291cmNlIDQgW21lbSAw
eDMwMDAwMDAwLTB4M2ZmZmZmZmYgd2luZG93XQpbICAgIDUuMjk5MDgzXSBwY2lfYnVzIDAwMDU6
MDA6IHJlc291cmNlIDUgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3aW5kb3dd
ClsgICAgNS4zMDY2NDFdIHBjaV9idXMgMDAwNTowMTogcmVzb3VyY2UgMSBbbWVtIDB4MzAwMDAw
MDAtMHgzMDFmZmZmZl0KWyAgICA1LjMxMjg5N10gcGNpX2J1cyAwMDA1OjAxOiByZXNvdXJjZSAy
IFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjMy
MDgwMV0gcGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAxIFttZW0gMHgzMDIwMDAwMC0weDMwM2Zm
ZmZmXQpbICAgIDUuMzI3MDU3XSBwY2lfYnVzIDAwMDU6MDI6IHJlc291cmNlIDIgW21lbSAweDJj
MDAwMDIwMDAwMC0weDJjMDAwMDNmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMzM0OTYxXSBwY2lf
YnVzIDAwMDU6MDM6IHJlc291cmNlIDEgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZmZmZdClsgICAg
NS4zNDEyMTddIHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMiBbbWVtIDB4MmMwMDAwNDAwMDAw
LTB4MmMwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNS4zNDkxMjJdIHBjaV9idXMgMDAwNTow
NDogcmVzb3VyY2UgMSBbbWVtIDB4MzA2MDAwMDAtMHgzMDdmZmZmZl0KWyAgICA1LjM1NTM3N10g
cGNpX2J1cyAwMDA1OjA0OiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3
ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjM2MzQ5MV0gaW9tbXU6IERlZmF1bHQgZG9tYWluIHR5
cGU6IFRyYW5zbGF0ZWQgClsgICAgNS4zNjgzOTNdIHBjaSAwMDBkOjAxOjAwLjA6IHZnYWFyYjog
VkdBIGRldmljZSBhZGRlZDogZGVjb2Rlcz1pbyttZW0sb3ducz1ub25lLGxvY2tzPW5vbmUKWyAg
ICA1LjM3Njc0MV0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBWR0EgZGV2aWNlIGFkZGVkOiBk
ZWNvZGVzPWlvK21lbSxvd25zPW5vbmUsbG9ja3M9bm9uZQpbICAgIDUuMzg1MDgzXSBwY2kgMDAw
ZDowMTowMC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxlClsgICAgNS4zOTA4MTdd
IHBjaSAwMDA0OjAyOjAwLjA6IHZnYWFyYjogYnJpZGdlIGNvbnRyb2wgcG9zc2libGUKWyAgICA1
LjM5NjU1M10gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBzZXR0aW5nIGFzIGJvb3QgZGV2aWNl
IChWR0EgbGVnYWN5IHJlc291cmNlcyBub3QgYXZhaWxhYmxlKQpbICAgIDUuNDA1NDEzXSB2Z2Fh
cmI6IGxvYWRlZApbICAgIDUuNDA4MTkzXSBTQ1NJIHN1YnN5c3RlbSBpbml0aWFsaXplZApbICAg
IDUuNDExOTM3XSBBQ1BJOiBidXMgdHlwZSBVU0IgcmVnaXN0ZXJlZApbICAgIDUuNDE1OTUxXSB1
c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmZzClsgICAgNS40MjE0
MzRdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgaHViClsgICAgNS40
MjY3NDhdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGRldmljZSBkcml2ZXIgdXNiClsgICAgNS40
MzE4MDddIHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAxIHJlZ2lzdGVyZWQKWyAgICA1LjQz
Njc2MV0gcHBzX2NvcmU6IFNvZnR3YXJlIHZlci4gNS4zLjYgLSBDb3B5cmlnaHQgMjAwNS0yMDA3
IFJvZG9sZm8gR2lvbWV0dGkgPGdpb21ldHRpQGxpbnV4Lml0PgpbICAgIDUuNDQ1ODgyXSBQVFAg
Y2xvY2sgc3VwcG9ydCByZWdpc3RlcmVkClsgICAgNS40NDk4ODVdIFJlZ2lzdGVyZWQgZWZpdmFy
cyBvcGVyYXRpb25zClsgICAgNS40NTQxOTNdIGNsb2Nrc291cmNlOiBTd2l0Y2hlZCB0byBjbG9j
a3NvdXJjZSBhcmNoX3N5c19jb3VudGVyClsgICAgNS42MzU1NTRdIHBucDogUG5QIEFDUEkgaW5p
dApbICAgIDUuNjM5OTY2XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzYmZmZjAwMDAwMDAtMHgzYmZm
ZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDUuNjQ3ODc3XSBzeXN0ZW0g
MDA6MDA6IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBu
b3QgYmUgcmVzZXJ2ZWQKWyAgICA1LjY1NjEzMF0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MjNmZmYw
MDAwMDAwLTB4MjNmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA1LjY2
NDAzNl0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MjdmZmYwMDAwMDAwLTB4MjdmZmZmZmZmZmZmIHdp
bmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA1LjY3MTk0Ml0gc3lzdGVtIDAwOjAwOiBbbWVt
IDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2Vy
dmVkClsgICAgNS42ODAxOTVdIHN5c3RlbSAwMDowMDogW21lbSAweDJmZmZmMDAwMDAwMC0weDJm
ZmZmZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZApbICAgIDUuNjg4NDQ4XSBz
eXN0ZW0gMDA6MDA6IFttZW0gMHg3YmZmZjAwMDAwMDAtMHg3YmZmZmZmZmZmZmYgd2luZG93XSBo
YXMgYmVlbiByZXNlcnZlZApbICAgIDUuNjk2MzU0XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg3ZmZm
ZjAwMDAwMDAtMHg3ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDUu
NzA0MjYwXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2M2ZmZjAwMDAwMDAtMHg2M2ZmZmZmZmZmZmYg
d2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDUuNzEyMTY2XSBzeXN0ZW0gMDA6MDA6IFtt
ZW0gMHg2N2ZmZjAwMDAwMDAtMHg2N2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZl
ZApbICAgIDUuNzIwMDcyXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2YmZmZjAwMDAwMDAtMHg2YmZm
ZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDUuNzI3OTc3XSBzeXN0ZW0g
MDA6MDA6IFttZW0gMHg2ZmZmZjAwMDAwMDAtMHg2ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVl
biByZXNlcnZlZApbICAgIDUuNzM1ODgzXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzM2ZmZjAwMDAw
MDAtMHgzM2ZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQKWyAgICA1Ljc0
NDEzNl0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZmIHdp
bmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkClsgICAgNS43NTIzOThdIHBucDogUG5QIEFDUEk6
IGZvdW5kIDEgZGV2aWNlcwpbICAgIDUuNzU3Njg3XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wg
ZmFtaWx5IDIKWyAgICA1Ljc2MjI1MV0gdGNwX2xpc3Rlbl9wb3J0YWRkcl9oYXNoIGhhc2ggdGFi
bGUgZW50cmllczogMTYzODQgKG9yZGVyOiA2LCAyNjIxNDQgYnl0ZXMsIGxpbmVhcikKWyAgICA1
Ljc3MTEyN10gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUgZW50cmllczogMjYyMTQ0IChvcmRl
cjogOSwgMjA5NzE1MiBieXRlcywgbGluZWFyKQpbICAgIDUuNzgwMTM4XSBUQ1AgYmluZCBoYXNo
IHRhYmxlIGVudHJpZXM6IDY1NTM2IChvcmRlcjogOCwgMTA0ODU3NiBieXRlcywgbGluZWFyKQpb
ICAgIDUuNzg4MDA1XSBUQ1A6IEhhc2ggdGFibGVzIGNvbmZpZ3VyZWQgKGVzdGFibGlzaGVkIDI2
MjE0NCBiaW5kIDY1NTM2KQpbICAgIDUuNzk0Njc5XSBVRFAgaGFzaCB0YWJsZSBlbnRyaWVzOiAx
NjM4NCAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAgIDUuODAxODg4XSBVRFAt
TGl0ZSBoYXNoIHRhYmxlIGVudHJpZXM6IDE2Mzg0IChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBs
aW5lYXIpClsgICAgNS44MDk1OThdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMQpb
ICAgIDUuODE0MDQ1XSBSUEM6IFJlZ2lzdGVyZWQgbmFtZWQgVU5JWCBzb2NrZXQgdHJhbnNwb3J0
IG1vZHVsZS4KWyAgICA1LjgxOTk2MV0gUlBDOiBSZWdpc3RlcmVkIHVkcCB0cmFuc3BvcnQgbW9k
dWxlLgpbICAgIDUuODI0NjU0XSBSUEM6IFJlZ2lzdGVyZWQgdGNwIHRyYW5zcG9ydCBtb2R1bGUu
ClsgICAgNS44MjkzNDZdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgTkZTdjQuMSBiYWNrY2hhbm5lbCB0
cmFuc3BvcnQgbW9kdWxlLgpbICAgIDUuODM1ODIwXSBwY2kgMDAwZDowMTowMC4xOiBEMCBwb3dl
ciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDUuODQyMjI1XSBwY2kgMDAwZDow
MTowMC4yOiBEMCBwb3dlciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDUuODQ4
NjAzXSBwY2kgMDAwZDowMTowMC4yOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAg
ICA1Ljg1NDMwMF0gcGNpIDAwMGQ6MDE6MDAuMzogRDAgcG93ZXIgc3RhdGUgZGVwZW5kcyBvbiAw
MDBkOjAxOjAwLjAKWyAgICA1Ljg2MDcwMl0gcGNpIDAwMDQ6MDM6MDAuMDogZW5hYmxpbmcgZGV2
aWNlICgwMDAwIC0+IDAwMDIpClsgICAgNS44NjYzOTNdIHBjaSAwMDA1OjAyOjAwLjA6IGVuYWJs
aW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAgIDUuODcyMDY1XSBQQ0k6IENMUyAxMjggYnl0
ZXMsIGRlZmF1bHQgNjQKWyAgICA1Ljg3NjI3Ml0gaHcgcGVyZmV2ZW50czogZW5hYmxlZCB3aXRo
IGFybXY4X3BtdXYzXzAgUE1VIGRyaXZlciwgNyBjb3VudGVycyBhdmFpbGFibGUKWyAgICA1Ljg4
NTE4MV0gd29ya2luZ3NldDogdGltZXN0YW1wX2JpdHM9NDIgbWF4X29yZGVyPTIzIGJ1Y2tldF9v
cmRlcj0wClsgICAgNS44OTMzNDNdIE5GUzogUmVnaXN0ZXJpbmcgdGhlIGlkX3Jlc29sdmVyIGtl
eSB0eXBlClsgICAgNS44OTg0MDNdIEtleSB0eXBlIGlkX3Jlc29sdmVyIHJlZ2lzdGVyZWQKWyAg
ICA1LjkwMjYwMV0gS2V5IHR5cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQKWyAgICA1LjkwNjc3NV0g
S2V5IHR5cGUgY2lmcy5pZG1hcCByZWdpc3RlcmVkClsgICAgNS45MjUxMjddIHhvcjogbWVhc3Vy
aW5nIHNvZnR3YXJlIGNoZWNrc3VtIHNwZWVkClsgICAgNS45MzA5MzJdICAgIDhyZWdzICAgICAg
ICAgICA6ICA5NzkwIE1CL3NlYwpbICAgIDUuOTM2MTE4XSAgICAzMnJlZ3MgICAgICAgICAgOiAx
MTc2MSBNQi9zZWMKWyAgICA1Ljk0MTE2OF0gICAgYXJtNjRfbmVvbiAgICAgIDogMTQwODUgTUIv
c2VjClsgICAgNS45NDU1MTddIHhvcjogdXNpbmcgZnVuY3Rpb246IGFybTY0X25lb24gKDE0MDg1
IE1CL3NlYykKWyAgICA1Ljk1MTAwOF0gQmxvY2sgbGF5ZXIgU0NTSSBnZW5lcmljIChic2cpIGRy
aXZlciB2ZXJzaW9uIDAuNCBsb2FkZWQgKG1ham9yIDI0OSkKWyAgICA1Ljk1ODM5NV0gaW8gc2No
ZWR1bGVyIG1xLWRlYWRsaW5lIHJlZ2lzdGVyZWQKWyAgICA1Ljk2MjkxNF0gaW8gc2NoZWR1bGVy
IGt5YmVyIHJlZ2lzdGVyZWQKWyAgICA1Ljk2NzI2N10gZ3Bpby1kd2FwYiBBUE1DMEQwNzowMjog
bm8gSVJRIGZvciBwb3J0MApbICAgIDUuOTcyOTYwXSBpbnB1dDogUG93ZXIgQnV0dG9uIGFzIC9k
ZXZpY2VzL0xOWFNZU1RNOjAwL0xOWFNZQlVTOjAwL1BOUDBDMEM6MDAvaW5wdXQvaW5wdXQwClsg
ICAgNS45ODEzMzFdIEFDUEk6IFBvd2VyIEJ1dHRvbiBbUFdSQl0KWyAgICA1Ljk4ODA2M10gR0hF
UzogQVBFSSBmaXJtd2FyZSBmaXJzdCBtb2RlIGlzIGVuYWJsZWQgYnkgQVBFSSBiaXQuClsgICAg
NS45OTQ0MzldIEVJTko6IEVycm9yIElOSmVjdGlvbiBpcyBpbml0aWFsaXplZC4KWyAgICA1Ljk5
OTE3Nl0gQUNQSSBHVERUOiBmb3VuZCAxIFNCU0EgZ2VuZXJpYyBXYXRjaGRvZyhzKS4KWyAgICA2
LjAwNTIxOV0gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gcGxhdGZvcm0gaGFzIG5vIElPIHNwYWNl
LCB0cnlpbmcgTU1JTwpbICAgIDYuMDEyMDExXSBhc3QgMDAwNDowMjowMC4wOiBbZHJtXSBVc2lu
ZyBQMkEgYnJpZGdlIGZvciBjb25maWd1cmF0aW9uClsgICAgNi4wMTg1MzBdIGFzdCAwMDA0OjAy
OjAwLjA6IFtkcm1dIEFTVCAyNTAwIGRldGVjdGVkClsgICAgNi4wMjM1NzRdIGFzdCAwMDA0OjAy
OjAwLjA6IFtkcm1dIEFuYWxvZyBWR0Egb25seQpbICAgIDYuMDI4NDQ3XSBhc3QgMDAwNDowMjow
MC4wOiBbZHJtXSBkcmFtIE1DTEs9ODAwIE1oeiB0eXBlPTggYnVzX3dpZHRoPTE2ClsgICAgNi4w
MzUyNjZdIFtUVE1dIFpvbmUgIGtlcm5lbDogQXZhaWxhYmxlIGdyYXBoaWNzIG1lbW9yeTogMTYy
NTExNDQgS2lCClsgICAgNi4wNDE4NzJdIFtUVE1dIFpvbmUgICBkbWEzMjogQXZhaWxhYmxlIGdy
YXBoaWNzIG1lbW9yeTogMjA5NzE1MiBLaUIKWyAgICA2LjA0ODM4OF0gW1RUTV0gSW5pdGlhbGl6
aW5nIHBvb2wgYWxsb2NhdG9yClsgICAgNi4wNTI3MzddIFtUVE1dIEluaXRpYWxpemluZyBETUEg
cG9vbCBhbGxvY2F0b3IKWyAgICA2LjA1NzY2OF0gW2RybV0gSW5pdGlhbGl6ZWQgYXN0IDAuMS4w
IDIwMTIwMjI4IGZvciAwMDA0OjAyOjAwLjAgb24gbWlub3IgMApbICAgIDYuMDgyMTcyXSBDb25z
b2xlOiBzd2l0Y2hpbmcgdG8gY29sb3VyIGZyYW1lIGJ1ZmZlciBkZXZpY2UgMTI4eDQ4ClsgICAg
Ni4wOTAzODddIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIGZiMDogYXN0ZHJtZmIgZnJhbWUgYnVm
ZmVyIGRldmljZQpbICAgIDYuMTA3OTM0XSBicmQ6IG1vZHVsZSBsb2FkZWQKWyAgICA2LjExNTM1
OF0gbG9vcDogbW9kdWxlIGxvYWRlZApbICAgIDYuMTE4ODA1XSBudm1lIG52bWUwOiBwY2kgZnVu
Y3Rpb24gMDAwNTowNDowMC4wClsgICAgNi4xMjM3MTVdIGlnYjogSW50ZWwoUikgR2lnYWJpdCBF
dGhlcm5ldCBOZXR3b3JrIERyaXZlcgpbICAgIDYuMTI5MTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NTEyIGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjEzNTAyOF0gaWdiOiBDb3B5
cmlnaHQgKGMpIDIwMDctMjAxNCBJbnRlbCBDb3Jwb3JhdGlvbi4KWyAgICA2LjE0MDU5MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTUxMiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi4x
NDcwNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT0yMDQ4IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA2LjE1MzA2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTIwNDggZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDYuMTYzMjM1XSBudm1lIG52bWUwOiBtaXNzaW5nIG9yIGludmFs
aWQgU1VCTlFOIGZpZWxkLgpbICAgIDYuMTc0MDAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9MjU2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjE4MDMxMV0gcHBzIHBwczA6IG5ldyBQ
UFMgc291cmNlIHB0cDAKWyAgICA2LjE4NDMxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTI1NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi4xOTAyNTFdIGlnYiAwMDA0OjA0OjAwLjA6
IGFkZGVkIFBIQyBvbiBldGgwClsgICAgNi4xOTQ3NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDYuMjAxMjA0XSBpZ2IgMDAw
NDowNDowMC4wOiBJbnRlbChSKSBHaWdhYml0IEV0aGVybmV0IE5ldHdvcmsgQ29ubmVjdGlvbgpb
ICAgIDYuMjA4MDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFn
cz1jYzAgYXR0cj0xMTAKWyAgICA2LjIxNDQ5OF0gaWdiIDAwMDQ6MDQ6MDAuMDogZXRoMDogKFBD
SWU6Mi41R2IvczpXaWR0aCB4MSkgMDA6MzA6NjQ6M2I6NTA6NTIKWyAgICA2LjIyMTc0Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsg
ICAgNi4yMjgyMzBdIGlnYiAwMDA0OjA0OjAwLjA6IGV0aDA6IFBCQSBObzogMDAwMzAwLTAwMApb
ICAgIDYuMjMzMzU3XSBpZ2IgMDAwNDowNDowMC4wOiBVc2luZyBNU0ktWCBpbnRlcnJ1cHRzLiAx
IHJ4IHF1ZXVlKHMpLCAxIHR4IHF1ZXVlKHMpClsgICAgNi4yNDA5MTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDYuMjQ3NDYz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0x
MTAKWyAgICA2LjI1MzkyNl0gaWdidmY6IEludGVsKFIpIEdpZ2FiaXQgVmlydHVhbCBGdW5jdGlv
biBOZXR3b3JrIERyaXZlcgpbICAgIDYuMjYwMTg1XSBpZ2J2ZjogQ29weXJpZ2h0IChjKSAyMDA5
IC0gMjAxMiBJbnRlbCBDb3Jwb3JhdGlvbi4KWyAgICA2LjI2NjA5NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNi4yNzI1NTJd
IGk0MGU6IEludGVsKFIpIEV0aGVybmV0IENvbm5lY3Rpb24gWEw3MTAgTmV0d29yayBEcml2ZXIK
WyAgICA2LjI3ODkyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQxOTQzMDQgZmxh
Z3M9Y2MwIGF0dHI9MTEwClsgICAgNi4yODUzNTddIGk0MGU6IENvcHlyaWdodCAoYykgMjAxMyAt
IDIwMTkgSW50ZWwgQ29ycG9yYXRpb24uClsgICAgNi4yOTExNzldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDYuMjk3NzIzXSBp
NDBlIDAwMDA6MDE6MDAuMDogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAgNi4z
MDM1ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBh
dHRyPTExMApbICAgIDYuMzExMzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5
NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA2LjMxNzg1Ml0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNi4zMjQyOTFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2
LjMzMDI4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2Mw
IGF0dHI9MTEwClsgICAgNi4zMzY3MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT04
MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjM0MjgzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNi4zNDkyNjRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjM1
NTI2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0
dHI9MTEwClsgICAgNi4zNjE2ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjM2NzgwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNi4zNzQyMzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjM4MDIz
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9
MTEwClsgICAgNi4zODY2NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA2LjM5Mjc3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNi4zOTkyMDVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjQwNTIwMV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEw
ClsgICAgNi40MTE2MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA2LjQxNzYyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNDIzNzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA2LjQzMDE3MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYu
NDM2MTY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAg
YXR0cj0xMTAKWyAgICA2LjQ0MjU5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNDQ4NzExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA2LjQ1NTE0MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNDYx
MTM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0
cj0xMTAKWyAgICA2LjQ2NzU3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNDczNjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA2LjQ4MDEyMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNDg2MTE1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0x
MTAKWyAgICA2LjQ5MjU1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDYuNDk4NjY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA2LjUwNTA5NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNTExMDkwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAK
WyAgICA2LjUxNzUyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDYuNTIzNjM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA2LjUzMDA2NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNTM2MDYxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAg
ICA2LjU0MjQ5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDYuNTQ4NjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDE5
NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA2LjU1NTAzNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNTYxMDMxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA2
LjU2NzQ2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDYuNTczNDU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgNi41Nzk1NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDYuNTg2MDAyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi41OTE5OTld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTEx
MApbICAgIDYuNTk4NDI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgNi42MDQ1NDVdIG52bWUgbnZtZTA6IGFsbG9jYXRlZCA2NCBNaUIg
aG9zdCBtZW1vcnkgYnVmZmVyLgpbICAgIDYuNjEwMTk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi42MTYxOTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjYyMjIwMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDYuNjI4NTE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9MTYzODQgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDYuNjM0NjA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi42NDA2MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT0xNjM4NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNi42NDY3MDZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjY1MjcwNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA2LjY1ODc4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDYuNjY0NzgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NjU1
MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNjcwODY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi42NzY4NjddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjY4Mjg3Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDYuNjg4ODc0XSBudm1lIG52bWUwOiAxLzAvMCBkZWZhdWx0L3JlYWQvcG9sbCBxdWV1ZXMKWyAg
ICA2LjY5NDAwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDYuNzAwMDc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi43MDYwOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjcxMjA5NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNzE4MTM0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
Ni43MjQxMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA2LjczMDEyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNzM2MTIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi43NDIxMTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2Ljc0ODExMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYu
NzU0MTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgNi43NjAxMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA2Ljc2NjA5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuNzcyMDkzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi43NzgwODhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2Ljc4
NDA4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDYuNzkwMDc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgNi43OTYwNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjgwMjA2OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuODA4MDY0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi44MTQw
NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA2LjgyMDA1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDYuODI2MDUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi44MzIwNDZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjgzODA0MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuODQ0MDM3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgNi44NTAwMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA2Ljg1NjAyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuODYyMDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi44NjgwMTldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2Ljg3NDAxNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDYuODgwMDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgNi44ODYwMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2Ljg5MjAwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuODk3OTk2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi45MDM5OTJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2
LjkwOTk4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDYuOTE1OTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgNi45MjE5NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2LjkyNzk3M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuOTMzOTY4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi45
Mzk5NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA2Ljk0NTk1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDYuOTUxOTU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi45NTc5NTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2Ljk2Mzk0Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuOTY5
OTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgNi45NzU5NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA2Ljk4MTkzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDYuOTg3OTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNi45OTM5MjddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA2Ljk5OTky
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDcuMDA1OTE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgNy4wMTE5MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjAxNzkwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMDIzOTAzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4wMjk4OThd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjAzNTg5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuMDQxODg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4wNDc4ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjA1Mzg3OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMDU5ODc2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
Ny4wNjU4NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA3LjA3MTg2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMDc3ODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4wODM4NTddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjA4OTg1Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcu
MDk1ODQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgNy4xMDE4NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA3LjEwNzg0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMTEzODM0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4xMTk4MzFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjEy
NTgyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDcuMTMxODIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgNy4xMzc4MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjE0MzgxMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMTQ5ODA3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4xNTU4
MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA3LjE2MTc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDcuMTY3Nzk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4xNzM3ODhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjE3OTc4NV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMTg1Nzgw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgNy4xOTE3NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA3LjE5Nzc3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMjAzNzY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4yMDk3NjFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjIxNTc1N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDcuMjIxNzUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgNy4yMjc3NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjIzMzc0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMjM5NzM5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4yNDU3MzRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3
LjI1MTcyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDcuMjU3NzI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgNy4yNjM3MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjI2OTcxNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMjc1NzExXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4y
ODE3MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA3LjI4NzcwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDcuMjkzNjk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4yOTk2OThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjMwNTY5M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMzEx
Njg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgNy4zMTc2ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA3LjMyMzY3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMzI5Njc0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4zMzU2NzBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjM0MTY2
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDcuMzQ3NjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgNy4zNTM2NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjM1OTY1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuMzY1NjQ2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4zNzE2NDJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjM3NzYzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuMzgzNjMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4zODk2MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjM5NTYyM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDAxNjE4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
Ny40MDc2MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA3LjQxMzYwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDE5NjA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy40MjU2MDBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQzMTU5Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcu
NDM3NTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgNy40NDM1ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA3LjQ0OTU4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDU1NTc3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy40NjE1NzJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQ2
NzU2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDcuNDczNTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgNy40Nzk1NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQ4NTU1NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDkxNTUyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy40OTc1
NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA3LjUwMzU0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDcuNTA5NTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41MTU1MzVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjUyMTUzMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNTI3NTI2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgNy41MzM1MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA3LjUzOTUxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNTQ1NTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41NTE1MDddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjU1NzUwMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDcuNTYzNDk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgNy41Njk0OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjU3NTQ4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNTgxNDgzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41ODc0NzhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3
LjU5MzQ3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDcuNTk5NDY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgNy42MDU0NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjYxMTQ2MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjE3NDU0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42
MjM0NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA3LjYyOTQ0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDcuNjM1NDQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42NDE0MzZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjY0NzQzMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjUz
NDI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgNy42NTk0MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA3LjY2NTQxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjcxNDEzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42Nzc0MDhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjY4MzQw
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDcuNjg5Mzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgNy42OTUzOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjcwMTM5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzA3Mzg2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43MTMzODFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjcxOTM3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuNzI1MzcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43MzEzNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjczNzM2Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzQzMzU4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
Ny43NDkzNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA3Ljc1NTM0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzYxMzQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43NjczMzldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljc3MzMzNF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcu
Nzc5MzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgNy43ODUzMjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA3Ljc5MTMyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzk3MzE2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy44MDMzMTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljgw
OTMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDcuODE1MzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgNy44MjEyOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjgyNzI5M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuODMzMjg4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy44Mzky
ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA3Ljg0NTI3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDcuODUxMjc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy44NTcyNjldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljg2MzI2NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuODY5MjU5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgNy44NzUyNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA3Ljg4MTI1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuODg3MjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy44OTMyNDFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljg5OTIzN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDcuOTA1MjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgNy45MTEyMjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjkxNzIyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuOTIzMjE4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy45MjkyMTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3
LjkzNTIwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDcuOTQxMjA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgNy45NDcyMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljk1MzE5NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuOTU5MTkxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy45
NjUxODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA3Ljk3MTE4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDcuOTc3MTc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy45ODMxNzJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljk4OTE2N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuOTk1
MTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC4wMDExNjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4LjAwNzE1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMDEzMTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4wMTkxNDhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjAyNTE0
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguMDMxMTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC4wMzcxMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjA0MzEzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMDQ5MTI0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4wNTUxMjVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4LjA2MTEyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguMDY3MTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4wNzMxMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjA3OTEwN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMDg1MTAyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC4wOTEwOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4LjA5NzA5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTAzMDg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4xMDkwODNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjExNTA4MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
MTIxMDc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC4xMjcwNzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4LjEzMzA2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTM5MDYxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4xNDUwNTZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjE1
MTA1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguMTU3MDQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC4xNjMwNDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjE2OTAzN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTc1MDMzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4xODEw
MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA4LjE4NzAyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDguMTkzMDE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4xOTkwMTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjIwNTAxMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjExMDA1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOC4yMTcwMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA4LjIyMjk5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjI4OTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yMzQ5ODddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjI0MDk4Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguMjQ2OTc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC4yNTI5NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjI1ODk2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjY0OTY0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yNzA5NjBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
LjI3Njk1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguMjgyOTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC4yODg5NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjI5NDk0MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzAwOTM2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4z
MDY5MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4LjMxMjkyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDguMzE4OTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zMjQ5MThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjMzMDkxNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzM2
OTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC4zNDI5MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4LjM0ODg5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzU0ODk1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zNjA4OTBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjM2Njg4
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguMzcyODgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC4zNzg4NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjM4NDg3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzkwODY3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zOTY4NjJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4LjQwMjg1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguNDA4ODUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40MTQ4NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQyMDg0M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDI2ODM5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC40MzI4MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4LjQzODgyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDQ0ODI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40NTA4MjBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQ1NjgxNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
NDYyODExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC40Njg4MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4LjQ3NDgwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDgwNzk3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40ODY3OTNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQ5
Mjc4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguNDk4Nzg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC41MDQ3NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjUxMDc3N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTE2NzcyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41MjI3
NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA4LjUyODc2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDguNTM0NzU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41NDA3NTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjU0Njc1MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTUyNzQ1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOC41NTg3NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA4LjU2NDczNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTcwNzMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41NzY3MjddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjU4MjcyMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguNTg4NzE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC41OTQ3MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjYwMDcwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNjA2NzA0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42MTI2OTldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
LjYxODY5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguNjI0Njg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC42MzA2ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjYzNjY4MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNjQyNjc1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42
NDg2NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4LjY1NDY2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDguNjYwNjYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42NjY2NTddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjY3MjY1Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNjc4
NjQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC42ODQ2NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4LjY5MDYzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNjk2NjMzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43MDI2MjldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjcwODYy
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguNzE0NjIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC43MjA2MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjcyNjYxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzMyNjA2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43Mzg2MDFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4Ljc0NDU5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguNzUwNTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43NTY1ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljc2MjU4M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzY4NTc4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC43NzQ1NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4Ljc4MDU2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzg2NTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43OTI1NjBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljc5ODU1Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
ODA0NTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC44MTA1NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4LjgxNjU0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODIyNTM5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44Mjg1MzRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljgz
NDUyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguODQwNTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC44NDY1MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljg1MjUxNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODU4NTExXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44NjQ1
MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA4Ljg3MDUwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDguODc2NDk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44ODI0OTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljg4ODQ4N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODk0NDgz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOC45MDA0NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA4LjkwNjQ3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTEyNDY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45MTg0NjRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjkyNDQ1OV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguOTMwNDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC45MzY0NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk0MjQ0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTQ4NDQxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45NTQ0MzddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
Ljk2MDQzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguOTY2NDI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC45NzI0MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk3ODQxOF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTg0NDEzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45
OTA0MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4Ljk5NjQwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuMDAyNDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wMDgzOTVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjAxNDM5MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDIw
Mzg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS4wMjYzODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5LjAzMjM4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDM4Mzc2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wNDQzNzFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjA1MDM2
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuMDU2MzYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS4wNjIzNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjA2ODM1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDc0MzQ4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wODAzNDNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5LjA4NjMzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuMDkyMzM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wOTgzMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjEwNDMyNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTEwMzIxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS4xMTYzMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5LjEyMjMxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTI4MzA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4xMzQzMDJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjE0MDI5N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
MTQ2MjkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS4xNTIyODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5LjE1ODI4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTY0Mjc5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4xNzAyNzRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjE3
NjI2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDkuMTgyMjY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOS4xODgyNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjE5NDI1NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjAwMjUwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yMDYy
NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5LjIxMjI0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuMjE4MjM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yMjQyMzFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjIzMDIyN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjM2MjIy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS4yNDIyMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5LjI0ODIxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjU0MjA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yNjAyMDNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjI2NjE5OV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuMjcyMTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS4yNzgxOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjI4NDE4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjkwMTgzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yOTYxNzhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
LjMwMjE3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuMzA4MTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS4zMTQxNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjMyMDE1OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzI2MTU1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4z
MzIxNTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA5LjMzODE0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuMzQ0MTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4zNTAxMzddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjM1NjEzMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzYy
MTI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS4zNjgxMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5LjM3NDExOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzgwMTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4zODYxMDldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjM5MjEw
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuMzk4MTAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS40MDQwOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQxMDA5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDE2MDkyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40MjIwODhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5LjQyODA4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuNDM0MDc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40NDAwNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQ0NjA3MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDUyMDY1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS40NTgwNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5LjQ2NDA1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDcwMDUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40NzYwNDZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQ4MjA0Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
NDg4MDM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS40OTQwMzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5LjUwMDAyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTA2MDI0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41MTIwMThdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjUx
ODAxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDkuNTI0MDA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOS41MzAwMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjUzNjAwMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTQxOTk4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41NDc5
OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5LjU1Mzk4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuNTU5OTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41NjU5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjU3MTk3N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTc3OTc1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS41ODM5NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT04MTkyIGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5LjU4OTk2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTk1OTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42MDE5NTldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjYwNzk1NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuNjEzOTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS42MTk5NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjYyNTk0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjMxOTM1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42Mzc5MzFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
LjY0MzkyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuNjQ5OTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS42NTU5MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjY2MTkxMl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjY3OTA3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42
NzM5MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA5LjY3OTg5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuNjg1ODk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42OTE4ODhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjY5Nzg4NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzAz
ODc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS43MDk4NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5LjcxNTg3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzIxODY2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43Mjc4NjFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjczMzg1
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuNzM5ODUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS43NDU4NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljc1MTg0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzU3ODM5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43NjM4MzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5Ljc2OTgyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuNzc1ODI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43ODE4MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljc4NzgxNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzkzODEwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS43OTk4MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5LjgwNTgwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODExNzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44MTc3OTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjgyMzc4Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
ODI5NzgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS44MzU3NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5Ljg0MTc3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODQ3NzY3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44NTM3NjNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljg1
OTc1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDkuODY1NzU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOS44NzE3NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljg3Nzc0NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODgzNzM5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44ODk3
MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5Ljg5NTczMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuOTAxNzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45MDc3MjBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjkxMzcxN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTE5NzEx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS45MjU3MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5LjkzMTcwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTM3Njk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45NDM2OTNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljk0OTY4OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuOTU1Njg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS45NjE2NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljk2NzY3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTczNjY5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45Nzk2NjRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
Ljk4NTY2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuOTkxNjU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS45OTc2NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjAwMzY0Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDA5NjQxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4w
MTU2MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjAyMTYzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuMDI3NjI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wMzM2MjJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjAzOTYxN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDQ1
NjEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC4wNTE2MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjA1NzYwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDYzNjAyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wNjk1OTddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjA3NTU5
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuMDgxNTg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC4wODc1ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjA5MzU3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDk5NTc1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4xMDU1NzBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjExMTU2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuMTE3NTYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4xMjM1NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjEyOTU1Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTM1NTQ3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC4xNDE1NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjE0NzUzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTUzNTMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4xNTk1MjhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjE2NTUyNF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAu
MTcxNTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMC4xNzc1MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEwLjE4MzUxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTg5NTA1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4xOTU1MDBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjIw
MTQ5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuMjA3NDkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC4yMTM0ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjIxOTQ4MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjI1NDc3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yMzE0
NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjIzNzQ2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuMjQzNDYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yNDk0NTldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjI1NTQ1NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjYxNDQ5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC4yNjc0NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjI3MzQ0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjc5NDM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yODU0MzFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjI5MTQyNl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuMjk3NDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC4zMDM0MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjMwOTQxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzE1NDA3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zMjE0MDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEw
LjMyNzM5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTAuMzMzMzk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMC4zMzkzOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjM0NTM4Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzUxMzgxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4z
NTczNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjM2MzM3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuMzY5MzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zNzUzNjNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjM4MTM1OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzg3
MzU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC4zOTMzNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjM5OTM0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDA1MzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC40MTEzMzVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQxNzMz
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuNDIzMzI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC40MjkzMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQzNTMxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDQxMzEyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC40NDczMDdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjQ1MzMwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuNDU5Mjk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC40NjUyOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQ3MTI4OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDc3Mjg0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC40ODMyNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjQ4OTI3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDk1MjY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41MDEyNjZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjUwNzI2MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAu
NTEzMjU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMC41MTkyNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEwLjUyNTI0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTMxMjQyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41MzcyMzhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjU0
MzIzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuNTQ5MjI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC41NTUyMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjU2MTIyMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTY3MjE4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41NzMy
MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjU3OTIwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuNTg1MjAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41OTExOThdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjU5NzE5NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjAzMTg5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC42MDkxODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjYxNTE4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjIxMTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42MjcxNzFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjYzMzE2Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuNjM5MTYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC42NDUxNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjY1MTE1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjU3MTQ4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42NjMxNDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEw
LjY2OTEzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTAuNjc1MTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMC42ODExMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjY4NzEyNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjkzMTIwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42
OTkxMTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjcwNTExMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuNzExMTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43MTcxMDJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjcyMzA5N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzI5
MDkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC43MzUwODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjc0MTA4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzQ3MDc5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43NTMwNzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjc1OTA2
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuNzY1MDY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC43NzEwNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjc3NzA1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzgzMDUxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43ODkwNDdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjc5NTA0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuODAxMDM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44MDcwMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjgxMzAyOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODE5MDIzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC44MjUwMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjgzMTAxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODM3MDA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44NDMwMDRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjg0ODk5OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAu
ODU0OTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMC44NjA5OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEwLjg2Njk4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODcyOTgxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44Nzg5NzZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjg4
NDk3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuODkwOTY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC44OTY5NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjkwMjk1OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTA4OTUzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45MTQ5
NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjkyMDk0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuOTI2OTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45MzI5MzVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjkzODkzMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTQ0OTI2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC45NTA5MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjk1NjkxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTYyOTEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45Njg5MDddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjk3NDkwM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuOTgwODk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC45ODY4OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjk5Mjg4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTk4ODg0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wMDQ4ODBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
LjAxMDg3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuMDE2ODcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS4wMjI4NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjAyODg2MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDM0ODU2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4w
NDA4NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjA0Njg0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuMDUyODQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wNTg4MzddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjA2NDgzM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDcw
ODMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS4wNzY4MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjA4MjgyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDg4ODIxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wOTQ4MTZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjEwMDgx
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuMTA2ODA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS4xMTI4MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjExODc5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTI0NzkzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4xMzA3ODhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjEzNjc4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuMTQyNzc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4xNDg3NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjE1NDc2OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTYwNzY1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MS4xNjY3NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDExLjE3Mjc1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTc4NzUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4xODQ3NDddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjE5MDc0Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
MTk2NzM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS4yMDI3MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjIwODczNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjE0NzMxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yMjA3MjZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjIy
NjcyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuMjMyNzE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS4yMzg3MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjI0NDcwOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjUwNzAzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yNTY2
OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjI2MjY5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuMjY4NjkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yNzQ2ODVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjI4MDY4MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjg2Njc2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS4yOTI2NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjI5ODY2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzA0NjYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4zMTA2NTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjMxNjY1M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTEuMzIyNjQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMS4zMjg2NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjMzNDYzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzQwNjM0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4zNDY2MjldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
LjM1MjYyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuMzU4NjE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS4zNjQ2MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjM3MDYxMF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzc2NjA2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4z
ODI2MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjM4ODU5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuMzk0NTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40MDA1ODhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQwNjU4M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDEy
NTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS40MTg1NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjQyNDU2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDMwNTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40MzY1NjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQ0MjU1
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuNDQ4NTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS40NTQ1NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQ2MDU0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDY2NTM2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40NzI1MzJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjQ3ODUyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuNDg0NTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40OTA1MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQ5NjUxM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTAyNTA4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MS41MDg1MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDExLjUxNDQ5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTIwNDk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41MjY0ODldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjUzMjQ4NV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
NTM4NDgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS41NDQ0NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjU1MDQ3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTU2NDY3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41NjI0NjJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjU2
ODQ1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuNTc0NDUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS41ODA0NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjU4NjQ0Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTkyNDQxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41OTg0
MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjYwNDQzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuNjEwNDI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42MTY0MjNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjYyMjQxOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjI4NDE0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS42MzQ0MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjY0MDQwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjQ2NDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42NTIzOTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjY1ODM5MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTEuNjY0Mzg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMS42NzAzODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjY3NjM3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjgyMzcxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42ODgzNjddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
LjY5NDM2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuNzAwMzU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS43MDYzNTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjcxMjM0OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzE4MzQzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43
MjQzMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjczMDMzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuNzM2MzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43NDIzMjVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjc0ODMyMF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzU0
MzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS43NjAzMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjc2NjMwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzcyMzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43NzgyOTddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjc4NDI5
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuNzkwMjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS43OTYyODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjgwMjI3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuODA4Mjc0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44MTQyNjld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjgyMDI2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuODI2MjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44MzIyNTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjgzODI1MV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuODQ0MjQ5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MS44NTAyNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDExLjg1NjIzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuODYyMjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44NjgyMzBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjg3NDIyNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
ODgwMjIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS44ODYyMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjg5MjIxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuODk4MjA2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45MDQyMDJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjkx
MDE5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuOTE2MTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS45MjIxODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjkyODE4M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTM0MTc4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45NDAx
NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjk0NjE2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuOTUyMTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45NTgxNjBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjk2NDE1Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTcwMTUx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS45NzYxNDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjk4MjE0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTg4MTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45OTQxMzJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjAwMDEyOV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTIuMDA2MTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMi4wMTIxMTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjAxODExNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDI0MTEwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4wMzAxMDVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEy
LjAzNjEwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTIuMDQyMDk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi4wNDgwOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjA1NDA4Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDYwMDgyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4w
NjYwNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEyLjA3MjA3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTIuMDc4MDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4wODQwNjNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjA5MDA1OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDk2
MDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMi4xMDIwNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEyLjEwODA0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTE0MDQyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xMjAwMzhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjEyNjAz
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTIuMTMyMDI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMi4xMzgwMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjE0NDAxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTUwMDE0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xNTYwMTBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEyLjE2MjAwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTIuMTY4MDAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xNzM5OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjE3OTk5Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTg1OTg2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Mi4xOTE5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEyLjE5Nzk3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjAzOTczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4yMDk5NjhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjIxNTk2NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIu
MjIxOTU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi4yMjc5NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEyLjIzMzk1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjM5OTQ2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4yNDU5NDFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjI1
MTkzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTIuMjU3OTMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMi4yNjM5MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjI2OTkyMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjc1OTE4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4yODE5
MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEyLjI4NzkwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTIuMjkzOTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4yOTk4OTldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjMwNTg5NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzExODkw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMi4zMTc4ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEyLjMyMzg4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzI5ODc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zMzU4NzFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjM0MTg2Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTIuMzQ3ODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMi4zNTM4NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjM1OTg1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzY1ODQ3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zNzE4NDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEy
LjM3NzgzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTIuMzgzODM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi4zODk4MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjM5NTgyNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDAxODIwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40
MDc4MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEyLjQxMzgxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTIuNDE5ODA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40MjU4MDFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQzMTc5N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDM3
NzkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMi40NDM3ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEyLjQ0OTc4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDU1Nzc5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40NjE3NzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQ2Nzc3
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTIuNDczNzY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMi40Nzk3NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQ4NTc1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDkxNzUxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40OTc3NDZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEyLjUwMzc0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTIuNTA5NzM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41MTU3MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjUyMTcyN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTI3NzI0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Mi41MzM3MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEyLjUzOTcxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTQ1NzA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41NTE3MDVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjU1NzcwMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIu
NTYzNjk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi41Njk2OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEyLjU3NTY4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTgxNjgxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41ODc2NzddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjU5
MzY3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTIuNTk5NjcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMi42MDU2NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjYxMTY2NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjE3NjYwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42MjM2
NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEyLjYyOTY1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTIuNjM1NjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42NDE2NDFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjY0NzYzN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjUzNjMy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMi42NjA1ODFdIGk0MGUgMDAwMDowMTowMC4wOiBmdyA2LjAuNDg0NDIgYXBpIDEuNyBudm0g
Ni4wMSAweDgwMDAzNDg1IDEuMTc0Ny4wIFs4MDg2OjE1ODldIFs4MDg2OjAwMDJdClsgICAxMi45
NDg4NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT02MTQ0MCBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi45NTQ5MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT02MTQ0MCBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi45NjExMjRdIGk0MGUgMDAwMDowMTowMC4wOiBNQUMgYWRk
cmVzczogM2M6ZmQ6ZmU6NmI6ZTk6YzAKWyAgIDEyLjk2NzAxM10gaTQwZSAwMDAwOjAxOjAwLjA6
IEZXIExMRFAgaXMgZW5hYmxlZApbICAgMTIuOTg2MzIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi45OTIzMjNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjk5ODMxOV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTMuMDA0MzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMy4wMTA0NzNdIGk0MGUgMDAwMDowMTowMC4wOiBQQ0ktRXhwcmVzczogU3Bl
ZWQgOC4wR1QvcyBXaWR0aCB4OApbICAgMTMuMDE3NzMxXSBpNDBlIDAwMDA6MDE6MDAuMDogRmVh
dHVyZXM6IFBGLWlkWzBdIFZTSXM6IDM0IFFQOiAxIFJTUyBGRF9BVFIgRkRfU0IgTlRVUExFIFZ4
TEFOIEdlbmV2ZSBQVFAgVkVQQQpbICAgMTMuMDI3Nzk2XSBpNDBlIDAwMDA6MDE6MDAuMTogZW5h
YmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAxMy4wNDU3MDZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA1MTcxNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTgxOTIgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
MDU3NzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy4wNjM3MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA2OTc0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMDc1NzQ3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4wODE3NTVdICBudm1l
MG4xOiBwMSBwMiBwMwpbICAgMTMuMDg0ODAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4wOTEzNTVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA5NzM2M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTAz
MzYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMy4xMDkzNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEzLjExNTM1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTIxMzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xMjczNTFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjEzMzM0
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTMuMTM5MzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMy4xNDUzMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjE1MTMzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTU3MzI3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xNjMzMjJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEzLjE2OTMxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTMuMTc1MzEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xODEzMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjE4NzMwM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTkzMjk4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My4xOTkyOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjIwNTI4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjExMjgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yMTcyNzldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjIyMzI3NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
MjI5MjY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy4yMzUyNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjI0MTI2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjQ3MjU1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yNTMyNTFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjI1
OTI0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuMjY1MjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy4yNzEyMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjI3NzIzMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjgzMjI3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yODky
MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjI5NTIxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuMzAxMjEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zMDcyMDldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjMxMzIwNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzE5MTk5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMy4zMjUxOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEzLjMzMTE5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzM3MTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zNDMxODFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjM0OTE3N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTMuMzU1MTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMy4zNjExNjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjM2NzE2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzczMTU4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zNzkxNTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEz
LjM4NTE0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTMuMzkxMTQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMy4zOTcxNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQwMzEzNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDA5MTMxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40
MTUxMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEzLjQyMTEyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTMuNDI3MTE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40MzMxMTNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQzOTEwOF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDQ1
MTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMy40NTEwOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEzLjQ1NzA5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDYzMDg5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40NjkwODVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQ3NTA4
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTMuNDgxMDc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMy40ODcwNzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQ5MzA2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDk5MDYxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41MDUwNTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEzLjUxMTA1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTMuNTE3MDQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41MjMwNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjUyOTAzOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTM1MDM0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My41NDEwMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjU0NzAyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTUzMDIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41NTkwMTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjU2NTAxMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
NTcxMDA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy41NzcwMDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjU4Mjk5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTg4OTkyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41OTQ5ODZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjYw
MDk4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuNjA2OTc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy42MTI5NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjYxODk2OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjI0OTYzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42MzA5
NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjYzNjk1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuNjQyOTUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42NDg5NDhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjY1NDk0M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjYwOTM5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMy42NjY5MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEzLjY3MjkzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjc4OTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42ODQ5MjBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjY5MDkxNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTMuNjk2OTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMy43MDI5MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjcwODkwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzE0ODk3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43MjA4OTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEz
LjcyNjg4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTMuNzMyODgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMy43Mzg4NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjc0NDg3NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzUwODY5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43
NTY4NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEzLjc2Mjg2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTMuNzY4ODU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43NzQ4NTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjc4MDg0N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzg2
ODQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMy43OTI4MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEzLjc5ODgzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuODA0ODI4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy44MTA4MjNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjgxNjgx
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTMuODIyODE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMy44Mjg4MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjgzNDgwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuODQwODAwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy44NDY3OTZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEzLjg1Mjc5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTMuODU4Nzg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy44NjQ3ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjg3MDc4MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuODc2Nzc2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My44ODI3NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjg4ODc2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuODk0NzYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy45MDA3NTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjkwNjc1MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
OTEyNzQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy45MTg3NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjkyNDczN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuOTMwNzMxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy45MzY3MjddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjk0
MjcyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuOTQ4NzE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy45NTQ3MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjk2MDcwN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuOTY2NzAyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy45NzI2
OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjk3ODY5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuOTg0Njg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy45OTA2ODJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjk5NjY3OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMDAyNjcz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNC4wMDg2NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE0LjAxNDY2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMDIwNjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4wMjY2NTRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjAzMjY1MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuMDM4NjQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC4wNDQ2NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjA1MDYzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMDU2NjMyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4wNjI2MjddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0
LjA2ODYyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuMDc0NjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC4wODA2MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjA4NjYwOF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMDkyNjA0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4w
OTg1OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0LjEwNDU5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuMTEwNTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4xMTY1ODZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjEyMjU4MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTI4
NTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC4xMzQ1NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0LjE0MDU2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTQ2NTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4xNTI1NjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjE1ODU1
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTQuMTY0NTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNC4xNzA1NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjE3NjU0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTgyNTM3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4xODg1MzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE0LjE5NDUyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTQuMjAwNTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4yMDY1MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjIxMjUxNF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMjE4NTA5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NC4yMjQ1MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE0LjIzMDUwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMjM2NDk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4yNDI0OTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjI0ODQ4N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQu
MjU0NDgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNC4yNjA0NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE0LjI2NjQ3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMjcyNDY5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4yNzg0NjNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjI4
NDQ1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTQuMjkwNDU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNC4yOTY0NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjMwMjQ0NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzA4NDQwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zMTQ0
MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE0LjMyMDQzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTQuMzI2NDI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zMzI0MjFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjMzODQxNl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzQ0NDEy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNC4zNTA0MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE0LjM1NjQwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzYyMzk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zNjgzOTNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjM3NDM4OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuMzgwMzg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC4zODYzNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjM5MjM3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzk4MzcwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40MDQzNjZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0
LjQxMDM2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuNDE2MzU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC40MjIzNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQyODM0N10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNDM0MzQyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40
NDAzMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0LjQ0NjMzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuNDUyMzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40NTgzMjRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQ2NDMxOV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNDcw
MzE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC40NzYzMDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0LjQ4MjMwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNDg4MzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40OTQyOTVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjUwMDI5
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTQuNTA2Mjg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNC41MTIyODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjUxODI3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTI0MjczXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC41MzAyNjhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE0LjUzNjI2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTQuNTQyMjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC41NDgyNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjU1NDI0OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTYwMjQ1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NC41NjYyNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE0LjU3MjIzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTc4MjMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC41ODQyMjZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjU5MDIyM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQu
NTk2MjE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNC42MDIyMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE0LjYwODIwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjE0MjA0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42MjAyMDNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjYy
NjE5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTQuNjMyMTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNC42MzgxODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjY0NDE4Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjUwMTgxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42NTYx
NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE0LjY2MjE3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTQuNjY4MTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42NzQxNjVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjY4MDE2MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjg2MTU2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNC42OTIxNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE0LjY5ODE0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzA0MTQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43MTAxMzhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjcxNjEzM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuNzIyMTI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC43MjgxMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjczNDExOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzQwMTE1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43NDYxMTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0
Ljc1MjEwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuNzU4MTAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC43NjQwOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljc3MDA5Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzc2MDg3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43
ODIwODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0Ljc4ODA3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuNzk0MDczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44MDAwNjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjgwNjA2NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODEy
MDYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC44MTgwNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0LjgyNDA1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODMwMDQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44MzYwNDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljg0MjAz
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTQuODQ4MDMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNC44NTQwMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljg2MDAyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODY2MDE3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44NzIwMTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE0Ljg3ODAwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTQuODg0MDA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44OTAwMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljg5NTk5NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTAxOTkwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NC45MDc5ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE0LjkxMzk4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTE5OTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45MjU5NzFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjkzMTk2OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQu
OTM3OTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNC45NDM5NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljk0OTk1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTU1OTQ5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45NjE5NDRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljk2
Nzk0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTQuOTczOTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNC45Nzk5MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljk4NTkyNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTkxOTIxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45OTc5
MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1LjAwMzkxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuMDA5OTA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wMTU5MDJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjAyMTg5N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDI3ODkz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS4wMzM4ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1LjAzOTg4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDQ1ODc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wNTE4NzRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjA1Nzg2OV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuMDYzODY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS4wNjk4NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjA3NTg1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDgxODUyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wODc4NDddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
LjA5Mzg0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuMDk5ODM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS4xMDU4MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjExMTgyOF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTE3ODIzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4x
MjM4MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1LjEyOTgxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuMTM1ODEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4xNDE4MDVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjE0NzgwMV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTUz
Nzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNS4xNTk3OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE1LjE2NTc4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTcxNzg1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4xNzc3ODBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjE4Mzc3
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuMTg5NzcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS4xOTU3NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjIwMTc2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjA3NzU3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4yMTM3NTJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjIxOTc0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuMjI1NzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4yMzE3MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjIzNzczNF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjQzNzMwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS4yNDk3MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1LjI1NTcyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjYxNzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4yNjc3MTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjI3MzcwNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
Mjc5NzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS4yODU2OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1LjI5MTY5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjk3Njg3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zMDM2ODRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjMw
OTY3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuMzE1Njc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNS4zMjE2NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjMyNzY2NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzMzNjYwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zMzk2
NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1LjM0NTY1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuMzUxNjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zNTc2NDFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjM2MzYzN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzY5NjMz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS4zNzU2MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1LjM4MTYyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzg3NjIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zOTM2MTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjM5OTYxM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuNDA1NjA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS40MTE2MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQxNzU5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDIzNTk0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS40Mjk1ODldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
LjQzNTU4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuNDQxNTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS40NDc1NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQ1MzU3MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDU5NTY2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS40
NjU1NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1LjQ3MTU1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuNDc3NTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS40ODM1NDhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQ4OTU0M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDk1
NTM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNS41MDE1MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE1LjUwNzUyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTEzNTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41MTk1MTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjUyNTUx
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuNTMxNTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS41Mzc1MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjU0MzUwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTQ5NDk2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41NTU0OTFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjU2MTQ4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuNTY3NDgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41NzM0NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjU3OTQ3M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTg1NDY4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS41OTE0NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1LjU5NzQ1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjAzNDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42MDk0NDldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjYxNTQ0Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
NjIxNDQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS42Mjc0MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1LjYzMzQzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjM5NDI3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42NDU0MjJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjY1
MTQxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuNjU3NDEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNS42NjM0MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjY2OTQwM10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjc1Mzk5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42ODEz
OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1LjY4NzM5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuNjkzMzg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42OTkzODRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjcwNTM3OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzExMzc0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS43MTczNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1LjcyMzM2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzI5MzYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS43MzUzNTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljc0MTM1MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuNzQ3MzQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS43NTMzNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljc1OTMzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzY1MzMyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS43NzEzMjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
Ljc3NzMyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuNzgzMzE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS43ODkzMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljc5NTMwOV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODAxMzA0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44
MDczMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1LjgxMzI5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuODE5MjkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44MjUyODZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjgzMTI4Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODM3
Mjc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNS44NDMyNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE1Ljg0OTI2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODU1MjY0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44NjEyNTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljg2NzI1
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuODczMjQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS44NzkyNDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljg4NTI0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODkxMjM2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44OTcyMzFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjkwMzIyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuOTA5MjIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45MTUyMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjkyMTIxM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuOTI3MjA4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS45MzMyMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1LjkzOTE5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuOTQ1MTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45NTExODldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljk1NzE4NV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
OTYzMTgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS45NjkxNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljk3NTE3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuOTgxMTY2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45ODcxNjJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljk5
MzE1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuOTk5MTUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi4wMDUxNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjAxMTE0M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDE3MTM4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wMjMx
MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2LjAyOTEyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuMDM1MTI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wNDExMjFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjA0NzExNl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDUzMTEx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi4wNTkxMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2LjA2NTEwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDcxMDk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wNzcwOTNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjA4MzA4OV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuMDg5MDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi4wOTUwODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjEwMTA3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTA3MDcwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xMTMwNjVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
LjExOTA2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuMTI1MDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi4xMzEwNTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjEzNzA1MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTgxOTIgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTQzMDQ5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4x
NDkwNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE2LjE1NTA0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTYuMTYxMDM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xNjcwMzFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjE3MzAyNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTc5
MDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi4xODUwMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2LjE5MTAxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTk3MDExXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yMDMwMDZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjIwOTAw
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuMjE0OTk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi4yMjA5OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjIyNjk4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjMyOTgyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yMzg5Nzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2LjI0NDk3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuMjUwOTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yNTY5NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjI2Mjk1OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjY4OTU1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni4yNzQ5NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2LjI4MDk0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjg2OTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yOTI5MzZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjI5ODkzMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
MzA0OTI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi4zMTA5MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE2LjMxNjkxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzIyOTE5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4zMjg5MTRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjMz
NDkxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTYuMzQwOTA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi4zNDY5MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjM1Mjg5Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzU4ODkyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4zNjQ4
ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2LjM3MDg4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuMzc2ODc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4zODI4NzNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjM4ODg2OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzk0ODY0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi40MDA4NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2LjQwNjg1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDEyODUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40MTg4NDVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQyNDg0MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuNDMwODM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi40MzY4MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQ0MjgyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDQ4ODIxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40NTQ4MTddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
LjQ2MDgxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuNDY2ODA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi40NzI4MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQ3ODc5OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDg0NzkzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40
OTA3ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE2LjQ5Njc4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTYuNTAyNzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41MDg3NzVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjUxNDc3MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTIw
NzY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi41MjY3NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2LjUzMjc1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTM4NzUyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41NDQ3NDhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjU1MDc0
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuNTU2NzM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi41NjI3MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjU2ODcyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTc0NzI1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41ODA3MjBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2LjU4NjcxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuNTkyNzExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41OTg3MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjYwNDcwMl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjEwNjk4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni42MTY2OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2LjYyMjY4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjI4NjgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi42MzQ2NzldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjY0MDY3NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
NjQ2NjY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi42NTI2NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE2LjY1ODY2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjY0NjU1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi42NzA2NTFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjY3
NjY0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTYuNjgyNjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi42ODg2MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjY5NDYzMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzAwNjI3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43MDY2
MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2LjcxMjYyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuNzE4NjE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43MjQ2MTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjczMDYwN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzM2NjAy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi43NDI1OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2Ljc0ODU5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzU0NTg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43NjA1ODRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljc2NjU4MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuNzcyNTc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi43Nzg1NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljc4NDU2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzkwNTYxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43OTY1NTZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
LjgwMjU1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuODA4NTQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi44MTQ1NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjgyMDUzN10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODI2NTMzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44
MzI1MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE2LjgzODUyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTYuODQ0NTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44NTA1MTRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljg1NjUwOV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODYy
NTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi44Njg0OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2Ljg3NDQ5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODgwNDkwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44ODY0ODZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljg5MjQ4
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuODk4NDc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi45MDQ0NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjkxMDQ3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTE2NDY1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45MjI0NjFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2LjkyODQ1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuOTM0NDUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45NDA0NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljk0NjQ0M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTUyNDM4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni45NTg0MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2Ljk2NDQyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTcwNDI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45NzY0MTldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljk4MjQxNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
OTg4NDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi45OTQ0MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3LjAwMDQwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDA2Mzk3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wMTIzOTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjAx
ODM4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuMDI0MzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy4wMzAzNzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjAzNjM3M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDQyMzY5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wNDgz
NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3LjA1NDM2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuMDYwMzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wNjYzNTFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjA3MjM0Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDc4MzQy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy4wODQzMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3LjA5MDMzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDk2MzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4xMDIzMjNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjEwODMxOF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuMTE0MzE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy4xMjAzMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjEyNjMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMTMyMzAwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4xMzgyOTZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
LjE0NDI5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuMTUwMjg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNy4xNTYyODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE2MjI3OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMTY4MjczXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4x
NzQyNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE3LjE4MDI2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuMTg2MjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4xOTIyNTVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE5ODI1MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjA0
MjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy4yMTAyNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3LjIxNjIzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjIyMjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yMjgyMzBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjIzNDIy
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuMjQwMjIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy4yNDYyMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjI1MjIxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjU4MjA3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yNjQyMDJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3LjI3MDE5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuMjc2MTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yODIxODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjI4ODE4M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjk0MTc5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny4zMDAxNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3LjMwNjE3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzEyMTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4zMTgxNjFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjMyNDE1Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcu
MzMwMTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNy4zMzYxNDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3LjM0MjE0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzQ4MTM3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4zNTQxMzNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjM2
MDEyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuMzY2MTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy4zNzIxMTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjM3ODExNF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzg0MTA5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4zOTAx
MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3LjM5NjEwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuNDAyMDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40MDgwOTBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQxNDA4Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDIwMDgx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy40MjYwNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3LjQzMjA3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDM4MDY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40NDQwNjNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQ1MDA1OV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuNDU2MDU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy40NjIwNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQ2ODA0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDc0MDQwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40ODAwMzVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
LjQ4NjAzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuNDkyMDI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNy40OTgwMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjUwNDAxN10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTEwMDEzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41
MTYwMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE3LjUyMjAwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuNTI3OTk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41MzM5OTRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjUzOTk4OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTQ1
OTg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy41NTE5ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3LjU1Nzk3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTYzOTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41Njk5NjZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjU3NTk2
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuNTgxOTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy41ODc5NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjU5Mzk0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTk5OTQzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42MDU5Mzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3LjYxMTkzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuNjE3OTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42MjM5MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjYyOTkyMF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNjM1OTE1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny42NDE5MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3LjY0NzkwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNjUzOTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42NTk4OThdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjY2NTg5NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcu
NjcxODg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNy42Nzc4ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3LjY4Mzg4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNjg5ODc2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42OTU4NzFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljcw
MTg2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuNzA3ODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy43MTM4NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjcxOTg1Ml0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzI1ODQ4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43MzE4
NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3LjczNzg0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuNzQzODM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43NDk4MzNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljc1NTgyN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzYxODI0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy43Njc4MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3Ljc3MzgxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzc5ODA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43ODU4MDVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljc5MTgwMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuNzk3Nzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy44MDM3OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjgwOTc4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODE1NzgxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44MjE3NzddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
LjgyNzc3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuODMzNzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNy44Mzk3NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljg0NTc1OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODUxNzUzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44
NTc3NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE3Ljg2Mzc0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuODY5NzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44NzU3MzVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljg4MTczMF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODg3
NzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy44OTM3MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3Ljg5OTcxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTA1NzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45MTE3MDddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjkxNzcw
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuOTIzNjk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy45Mjk2OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjkzNTY4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTQxNjg0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45NDc2Nzld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3Ljk1MzY3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuOTU5NjcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45NjU2NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljk3MTY2MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTc3NjU2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny45ODM2NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3Ljk4OTY0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTk1NjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4wMDE2MzhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjAwNzYzM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
MDEzNjI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC4wMTk2MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4LjAyNTYyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDMxNjE0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4wMzc2MTBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjA0
MzYwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguMDQ5NjAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC4wNTU1OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjA2MTU5MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDY3NTg2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4wNzM1
ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4LjA3OTU3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguMDg1NTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4wOTE1NjddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjA5NzU2M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTAzNTU4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC4xMDk1NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4LjExNTU1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTIxNTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xMjc1NDVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjEzMzU0MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguMTM5NTM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC4xNDU1MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjE1MTUyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTU3NTIyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xNjM1MTddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4
LjE2OTUxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTguMTc1NTA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOC4xODE1MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjE4NzQ5OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTkzNDk1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4x
OTk0OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4LjIwNTQ4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguMjExNDgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yMTc0NzZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjIyMzQ3MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjI5
NDY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC4yMzU0NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4LjI0MTQ2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjQ3NDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yNTM0NTFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjI1OTQ0
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguMjY1NDQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC4yNzE0MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjI3NzQzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjgzNDI3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yODk0MjNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4LjI5NTQxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguMzAxNDE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4zMDc0MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjMxMzQwNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzE5NDAwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OC4zMjUzOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE4LjMzMTM5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzM3Mzg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4zNDMzODFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjM0OTM3N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
MzU1MzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC4zNjEzNjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4LjM2NzM2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzczMzU5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4zNzkzNTRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjM4
NTM0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguMzkxMzQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC4zOTczNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQwMzMzNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDA5MzMzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40MTUz
MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4LjQyMTMyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguNDI3MzE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40MzMzMTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQzOTMwOV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDQ1MzA1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC40NTEzMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4LjQ1NzI5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDYzMjkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40NjkyODZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQ3NTI4Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguNDgxMjc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC40ODcyNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQ5MzI2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDk5MjYzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41MDUyNTldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4
LjUxMTI1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTguNTE3MjUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOC41MjMyNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjUyOTI0MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNTM1MjM1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41
NDEyMzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4LjU0NzIyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguNTUzMjIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41NTkyMTddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjU2NTIxMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNTcx
MjA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC41NzcyMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4LjU4MzE5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNTg5MTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41OTUxODldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjYwMTE4
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguNjA3MTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC42MTMxNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjYxOTE3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjI1MTY2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC42MzExNjFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4LjYzNzE1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguNjQzMTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC42NDkxNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjY1NTE0M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjYxMTM5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OC42NjcxMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE4LjY3MzEyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjc5MTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC42ODUxMjBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjY5MTExNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
Njk3MTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC43MDMxMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4LjcwOTEwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzE1MDk2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43MjEwOTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljcy
NzA4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguNzMzMDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC43MzkwNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljc0NTA3NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzUxMDcxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43NTcw
NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4Ljc2MzA2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguNzY5MDU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43NzUwNTNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljc4MTA0OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzg3MDQz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC43OTMwMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4Ljc5OTAzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODA1MDI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44MTEwMjRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjgxNzAyMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguODIzMDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC44MjkwMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjgzNTAwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODQxMDAyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44NDY5OTddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4
Ljg1Mjk5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTguODU4OTg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOC44NjQ5ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljg3MDk3OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODc2OTc0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44
ODI5NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4Ljg4ODk2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguODk0OTU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45MDA5NTVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjkwNjk1MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTEy
OTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC45MTg5NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4LjkyNDkzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTMwOTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45MzY5MjddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljk0Mjky
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguOTQ4OTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC45NTQ5MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljk2MDkxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTY2OTA0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45NzI5MDBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4Ljk3ODg5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguOTg0ODkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45OTA4ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljk5Njg4MV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDAyODc2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OS4wMDg4NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE5LjAxNDg2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDIwODYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wMjY4NThdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjAzMjg1NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTku
MDM4ODQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOS4wNDQ4NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE5LjA1MDg0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDU2ODM2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wNjI4MzFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjA2
ODgyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTkuMDc0ODIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOS4wODA4MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjA4NjgxMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDkyODA4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wOTg4
MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE5LjEwNDc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuMTEwNzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xMTY3ODldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjEyMjc4NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTI4Nzgw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS4xMzQ3NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5LjE0MDc3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTQ2NzY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xNTI3NjJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjE1ODc1N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTkuMTY0NzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOS4xNzA3NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjE3Njc0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTgyNzQwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xODg3MzddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5
LjE5NDczMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTkuMjAwNzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOS4yMDY3MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjIxMzY3MV0gaTQwZSAwMDAwOjAxOjAw
LjE6IGZ3IDYuMC40ODQ0MiBhcGkgMS43IG52bSA2LjAxIDB4ODAwMDM0ODUgMS4xNzQ3LjAgWzgw
ODY6MTU4OV0gWzgwODY6MDAwMF0KWyAgIDE5LjUwMTQxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTYxNDQwIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjUwNzQ5Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTYxNDQwIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjUxMzY4
N10gaTQwZSAwMDAwOjAxOjAwLjE6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMQpbICAg
MTkuNTIzNzQ1XSBpNDBlIDAwMDA6MDE6MDAuMTogRlcgTExEUCBpcyBlbmFibGVkClsgICAxOS41
MzM4MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE5LjUzOTgxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTkuNTQ1ODE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS41NTE4MTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjU1Nzk2N10gaTQwZSAw
MDAwOjAxOjAwLjE6IFBDSS1FeHByZXNzOiBTcGVlZCA4LjBHVC9zIFdpZHRoIHg4ClsgICAxOS41
NjUyMjZdIGk0MGUgMDAwMDowMTowMC4xOiBGZWF0dXJlczogUEYtaWRbMV0gVlNJczogMzQgUVA6
IDEgUlNTIEZEX0FUUiBGRF9TQiBOVFVQTEUgVnhMQU4gR2VuZXZlIFBUUCBWRVBBClsgICAxOS41
NzU3ODNdIGk0MGUgMDAwMDowMTowMC4yOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikK
WyAgIDE5LjU5MjI1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTgxOTIgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuNTk4MjU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
ODE5MiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42MDQyNTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjYxMDI1MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjE2MjQ3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS42MjIyNDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5LjYyODIzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjM0MjMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42NDAyMjhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjY0NjIyM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTkuNjUyMjE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOS42NTgyMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjY2NDIxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjcwMjA1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42NzYyMDFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5
LjY4MjE5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTkuNjg4MTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOS42OTQxODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjcwMDE4Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzA2MTc3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43
MTIxNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE5LjcxODE2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTkuNzI0MTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43MzAxNTldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjczNjE1NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzQy
MTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOS43NDgxNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE5Ljc1NDE0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzYwMTQwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43NjYxMzVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljc3MjEz
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTkuNzc4MTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOS43ODQxMjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljc5MDEyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzk2MTE4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44MDIxMTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE5LjgwODEwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTkuODE0MTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44MjAxMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjgyNjA5NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODMyMDkwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OS44MzgwODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE5Ljg0NDA4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODUwMDc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44NTYwNzFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljg2MjA2Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTku
ODY4MDYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOS44NzQwNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljg4MDA1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODg2MDQ4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44OTIwNDNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljg5
ODAzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTkuOTA0MDM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOS45MTAwMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjkxNjAyOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTIyMDI0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45Mjgw
MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE5LjkzNDAxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuOTQwMDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45NDYwMDVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljk1MjAwMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTU3OTk2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS45NjM5OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5Ljk2OTk4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTc1OTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45ODE5NzddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljk4Nzk3M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTkuOTkzOTY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOS45OTk5NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjAwNTk1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMDExOTU0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4wMTc5NDldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIw
LjAyMzk0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjAuMDI5OTQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMC4wMzU5MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjA0MTkzMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMDQ3OTI3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4w
NTM5MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIwLjA1OTkxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjAuMDY1OTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4wNzE5MDhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjA3NzkwM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMDgz
ODk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMC4wODk4OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIwLjA5NTg5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTAxODg0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xMDc4ODBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjExMzg3
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjAuMTE5ODcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMC4xMjU4NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjEzMTg2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTM3ODU2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xNDM4NTJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIwLjE0OTg0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjAuMTU1ODQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xNjE4MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjE2NzgzM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTczODI4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MC4xNzk4MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIwLjE4NTgxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTkxODE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xOTc4MTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjIwMzgwNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAu
MjA5ODAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMC4yMTU3OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIwLjIyMTc5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjI3Nzg3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yMzM3ODJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjIz
OTc3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjAuMjQ1NzczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMC4yNTE3NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjI1Nzc2NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjYzNzYwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yNjk3
NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIwLjI3NTc1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjAuMjgxNzQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yODc3NDVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjI5Mzc0MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjk5NzM2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMC4zMDU3MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIwLjMxMTcyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzE3NzIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4zMjM3MTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjMyOTcxMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjAuMzM1NzA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMC4zNDE3MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjM0NzY5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzUzNjkzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4zNTk2ODldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIw
LjM2NTY4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjAuMzcxNjc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMC4zNzc2NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjM4MzY3MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzg5NjY1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4z
OTU2NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIwLjQwMTY1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjAuNDA3NjUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC40MTM2NDddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjQxOTY0M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNDI1
NjM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMC40MzE2MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIwLjQzNzYyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNDQzNjI0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC40NDk2MTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjQ1NTYx
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjAuNDYxNjEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMC40Njc2MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjQ3MzYwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNDc5NTk3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC40ODU1OTJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIwLjQ5MTU4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjAuNDk3NTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC41MDM1ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjUwOTU3N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNTE1NTcyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MC41MjE1NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIwLjUyNzU2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNTMzNTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC41Mzk1NTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjU0NTU0OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAu
NTUxNTQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMC41NTc1NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIwLjU2MzUzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNTY5NTMxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC41NzU1MjZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjU4
MTUyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjAuNTg3NTE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMC41OTM1MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjU5OTUwOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNjA1NTAzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC42MTE1
MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIwLjYxNzQ5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjAuNjIzNDkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC42Mjk0ODddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjYzNTQ4M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNjQxNDc4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMC42NDc0NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIwLjY1MzQ2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNjU5NDY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC42NjU0NTldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjY3MTQ1NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjAuNjc3NDUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMC42ODM0NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjY4OTQ0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNjk1NDM3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43MDE0MzJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIw
LjcwNzQyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjAuNzEzNDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMC43MTk0MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjcyNTQxM10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNzMxNDA5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43
Mzc0MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIwLjc0MzM5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjAuNzQ5Mzk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43NTUzOTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjc2MTM4NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNzY3
MzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMC43NzMzNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIwLjc3OTM3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNzg1MzY2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43OTEzNjJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjc5NzM1
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjAuODAzMzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMC44MDkzNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjgxNTM0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODIxMzQyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44MjczMzdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIwLjgzMzMzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjAuODM5MzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44NDUzMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjg1MTMxOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODU3MzE0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MC44NjMzMDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIwLjg2OTMwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODc1MzAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44ODEyOTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjg4NzI5MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAu
ODkzMjg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMC44OTkyODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIwLjkwNTI3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTExMjcyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45MTcyNjddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjky
MzI2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjAuOTI5MjU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMC45MzUyNTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjk0MTI0OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTQ3MjQ0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45NTMy
MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIwLjk1OTIzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjAuOTY1MjMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45NzEyMjZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjk3NzIyMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTgzMjE3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMC45ODkyMTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIwLjk5NTIwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDAxMjAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4wMDcyMDBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjAxMzE5NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuMDE5MTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS4wMjUxODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjAzMTE4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDM3MTc2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4wNDMxNzJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
LjA0OTE2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuMDU1MTYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS4wNjExNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjA2NzE1M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDczMTQ4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4w
NzkxNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjA4NTEzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuMDkxMTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4wOTcxMjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjEwMzEyNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTA5
MTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS4xMTUxMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjEyMTExMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTI3MTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xMzMxMDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjEzOTA5
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuMTQ1MDkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS4xNTEwODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjE1NzA4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTYzMDc4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xNjkwNzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjE3NTA3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuMTgxMDY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xODcwNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjE5MzA1NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTk5MDUxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS4yMDUwNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjIxMTA0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjE3MDM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4yMjMwMzNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjIyOTAyOF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
MjM1MDI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS4yNDEwMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI0NzAxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjUzMDA5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4yNTkwMDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI2
NTAwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuMjcwOTk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS4yNzY5OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI4Mjk4OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjg4OTg0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4yOTQ5
ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjMwMDk3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjEuMzA2OTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zMTI5NjhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjMxODk2NV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzI0OTYw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMS4zMzA5NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIxLjMzNjk1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzQyOTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zNDg5NDFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjM1NDkzN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuMzYwOTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS4zNjY5MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjM3MjkyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzc4OTE5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zODQ5MTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
LjM5MDkwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuMzk2OTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS40MDI5MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQwODg5NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDE0ODkyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40
MjA4ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjQyNjg4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuNDMyODc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40Mzg4NzNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQ0NDg2OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDUw
ODYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS40NTY4NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjQ2Mjg1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDY4ODQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40NzQ4NDVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQ4MDg0
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuNDg2ODM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS40OTI4MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQ5ODgyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTA0ODIxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41MTA4MTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjUxNjgxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuNTIyODA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41Mjg4MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjUzNDc5OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTQwNzkzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS41NDY3ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjU1Mjc4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTU4Nzc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41NjQ3NzRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjU3MDc3MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
NTc2NzY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS41ODI3NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjU4ODc1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTk0NzUxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42MDA3NDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjYw
Njc0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuNjEyNzM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS42MTg3MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjYyNDcyOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjMwNzI1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42MzY3
MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjY0MjcxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjEuNjQ4NzEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42NTQ3MDZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjY2MDcwMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjY2Njk2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMS42NzI2OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIxLjY3ODY4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjg0NjgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42OTA2NzddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjY5NjY3Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuNzAyNjY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS43MDg2NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjcxNDY1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNzIwNjU0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43MjY2NTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
LjczMjY0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuNzM4NjQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS43NDQ2MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjc1MDYzMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNzU2NjI2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43
NjI2MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjc2ODYxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuNzc0NjEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43ODA2MDddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjc4NjYwM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNzky
NTk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS43OTg1OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjgwNDU4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODEwNTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44MTY1NzldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjgyMjU3
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuODI4NTczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS44MzQ1NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjg0MDU2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODQ2NTYwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44NTI1NTVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjg1ODU1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuODY0NTQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44NzA1NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjg3NjUzNl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODgyNTMyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS44ODg1MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjg5NDUyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTAwNTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45MDY1MTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjkxMjUwOV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
OTE4NTA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS45MjQ1MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjkzMDQ5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTM2NDkwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45NDI0ODZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjk0
ODQ4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuOTU0NDc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS45NjA0NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjk2NjQ2OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTcyNDYzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45Nzg0
NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjk4NDQ1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjEuOTkwNDQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45OTY0NDRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjAwMjQ0MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDA4NDM1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi4wMTQ0MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjAyMDQyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDI2NDI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4wMzI0MTldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjAzODQxNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuMDQ0NDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi4wNTA0MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjA1NjQwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDYyMzk2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4wNjgzOTFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
LjA3NDM4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuMDgwMzgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi4wODYzNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjA5MjM3Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDk4MzY4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4x
MDQzNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjExMDM1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuMTE2MzU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4xMjIzNTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjEyODM0NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTM0
MzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi4xNDAzMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjE0NjMzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTUyMzI2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4xNTgzMjFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjE2NDMx
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuMTcwMzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi4xNzYzMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjE4MjMwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTg4Mjk4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4xOTQyOTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjIwMDI4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuMjA2Mjg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yMTIyODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjIxODI3NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjI0MjcwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi4yMzAyNjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjIzNjI2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjQyMjU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yNDgyNTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjI1NDI0OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
MjYwMjQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi4yNjYyMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjI3MjIzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjc4MjMwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yODQyMjRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjI5
MDIyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuMjk2MjE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi4zMDIyMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjMwODIwNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzE0MjAxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zMjAx
OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIyLjMyNjE5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjIuMzMyMTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zMzgxODVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjM0NDE4MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzUwMTc2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi4zNTYxNzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjM2MjE2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzY4MTYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zNzQxNTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjM4MDE1Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuMzg2MTQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi4zOTIxNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjM5ODEzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDA0MTM0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40MTAxMzBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
LjQxNjEyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuNDIyMTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi40MjgxMTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjQzNDExMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDQwMTA3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40
NDYxMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjQ1MjA5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuNDU4MDkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40NjQwODhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjQ3MDA4M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDc2
MDc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi40ODIwNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjQ4ODA2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDk0MDY1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41MDAwNjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjUwNjA1
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuNTEyMDUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi41MTgwNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjUyNDA0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTMwMDM3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41MzYwMzJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjU0MjAyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuNTQ4MDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41NTQwMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjU2MDAxM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTY2MDA5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi41NzIwMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjU3Nzk5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTgzOTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41ODk5OTBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjU5NTk4NV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
NjAxOTgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi42MDc5NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjYxMzk3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNjE5OTY3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42MjU5NjNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjYz
MTk1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuNjM3OTU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi42NDM5NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjY0OTk0NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNjU1OTQwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42NjE5
MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIyLjY2NzkzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjIuNjczOTI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
ODE5MiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42Nzk5MjRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjY4NTkyMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNjkxOTE2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi42OTc5MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjcwMzkwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzA5OTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43MTU4OThdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjcyMTg5M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuNzI3ODg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi43MzM4ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjczOTg3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzQ1ODc1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43NTE4NzBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
Ljc1Nzg2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuNzYzODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi43Njk4NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjc3NTg1Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzgxODUwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43
ODc4NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjc5Mzg0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuNzk5ODM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44MDU4MzFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjgxMTgyNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODE3
ODIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi44MjM4MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjgyOTgxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODM1ODA4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44NDE4MDRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjg0Nzgw
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuODUzNzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi44NTk3OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjg2NTc4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODcxNzg0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44Nzc3Nzld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjg4Mzc3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuODg5NzY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44OTU3NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjkwMTc2MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTA3NzU1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi45MTM3NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjkxOTc0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTI1NzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi45MzE3MzddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjkzNzczMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
OTQzNzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi45NDk3MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk1NTcxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTYxNzE0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi45Njc3MDldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk3
MzcwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuOTc5Njk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi45ODU2OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk5MTY5MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTk3Njg3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wMDM2
ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjAwOTY3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuMDE1NjcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wMjE2NjddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjAyNzY2Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDMzNjU4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy4wMzk2NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjA0NTY0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDUxNjQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wNTc2NDBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjA2MzYzNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuMDY5NjMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy4wNzU2MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjA4MTYyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDg3NjE2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wOTM2MTJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
LjA5OTYwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuMTA1NjAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy4xMTE1OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjExNzU5M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTIzNTg4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4x
Mjk1ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjEzNTU3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuMTQxNTc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4xNDc1NzBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjE1MzU2NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTU5
NTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy4xNjU1NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjE3MTU1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTc3NTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4xODM1NDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjE4OTUz
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuMTk1NTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy4yMDE1MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjIwNzUyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjEzNTE4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yMTk1MTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjIyNTUwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuMjMxNTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yMzc1MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjI0MzQ5NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjQ5NDkxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My4yNTU0ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjI2MTQ4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjY3NDc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yNzM0NzJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjI3OTQ2Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
Mjg1NDYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy4yOTE0NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjI5NzQ1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzAzNDQ4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zMDk0NDNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjMx
NTQzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjMuMzIxNDM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMy4zMjc0MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjMzMzQyNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzM5NDIwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zNDU0
MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjM1MTQxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuMzU3NDA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zNjM0MDRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjM2OTQwMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzc1Mzk1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy4zODEzOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjM4NzM4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzkzMzgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zOTkzNzZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQwNTM3Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuNDExMzY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy40MTczNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQyMzM1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNDI5MzU0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40MzUzNDldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
LjQ0MTM0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuNDQ3MzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy40NTMzMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQ1OTMzMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNDY1MzI2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40
NzEzMjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjQ3NzMxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuNDgzMzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40ODkzMTFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQ5NTMwNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTAx
MzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy41MDcyOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjUxMzI5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTE5Mjg3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41MjUyODNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjUzMTI3
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuNTM3Mjc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy41NDMyNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjU0OTI2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTU1MjYzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41NjEyNjBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjU2NzI1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuNTczMjUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41NzkyNDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjU4NTI0Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTkxMjM2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My41OTcyMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjYwMzIyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjA5MjIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42MTUyMTddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjYyMTIxM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
NjI3MjA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy42MzMyMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjYzOTE5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjQ1MTk0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42NTExODldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjY1
NzE4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjMuNjYzMTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMy42NjkxNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjY3NTE3MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjgxMTY3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42ODcx
NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjY5MzE1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuNjk5MTUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43MDUxNDldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjcxMTE0NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzE3MTM5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy43MjMxMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjcyOTEzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzM1MTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43NDExMjFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjc0NzExNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuNzUzMTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy43NTkxMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjc2NTEwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzcxMDk3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43NzcwOTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
Ljc4MzA4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuNzg5MDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy43OTUwNzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjgwMTA3NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODA3MDY5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44
MTMwNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjgxOTA2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuODI1MDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44MzEwNTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjgzNzA0Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODQz
MDQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy44NDkwMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjg1NTAzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODYxMDI4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44NjcwMjRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjg3MzAy
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuODc5MDE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy44ODUwMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjg5MTAwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODk3MDA0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45MDI5OTld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjkwODk5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuOTE0OTg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45MjA5ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjkyNjk4MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTMyOTc2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My45Mzg5NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjk0NDk2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTUwOTYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45NTY5NTddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjk2Mjk1Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
OTY4OTQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy45NzQ5NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjk4MDkzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTg2OTMzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45OTI5MjldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjk5
ODkyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuMDA0OTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC4wMTA5MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjAxNjkxMF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDIyOTA1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wMjg5
MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjAzNDg5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuMDQwODkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wNDY4ODZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjA1Mjg4Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDU4ODc3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC4wNjQ4NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0LjA3MDg2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDc2ODY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wODI4NjBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjA4ODg1NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuMDk0ODUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC4xMDA4NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjEwNjg0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTEyODM3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4xMTg4MzJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjEyNDgyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuMTMwODIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC4xMzY4MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjE0MjgxNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTQ4ODA5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4x
NTQ4MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0LjE2MDgwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuMTY2Nzk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4xNzI3OTFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjE3ODc4Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTg0
NzgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC4xOTA3NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0LjE5Njc3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjAyNzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yMDg3NjRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjIxNDc1
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuMjIwNzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC4yMjY3NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjIzMjc0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjM4NzQwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yNDQ3MzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0LjI1MDczMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuMjU2NzI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yNjI3MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjI2ODcxN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjc0NzEyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC4yODA3MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0LjI4NjcwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjkyNzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yOTg2OTZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjMwNDY5Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQu
MzEwNjg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNC4zMTY2ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI0LjMyMjY3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMzI4NjczXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zMzQ2NjhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjM0
MDY2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuMzQ2NjU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC4zNTI2NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjM1ODY0OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMzY0NjQ1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zNzA2
MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjM3NjYzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuMzgyNjMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zODg2MjldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjM5NDYyM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDAwNjE5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC40MDY2MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0LjQxMjYxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDE4NjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40MjQ2MDFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQzMDU5Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuNDM2NTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC40NDI1ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQ0ODU4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDU0NTc3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40NjA1NzNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjQ2NjU2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuNDcyNTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC40Nzg1NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQ4NDU1NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDkwNTUwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40
OTY1NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0LjUwMjU0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuNTA4NTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41MTQ1MzJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjUyMDUyN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTI2
NTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC41MzI1MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0LjUzODUxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTQ0NTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41NTA1MDRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjU1NjUw
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuNTYyNDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC41Njg0OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjU3NDQ4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTgwNDgxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41ODY0NzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0LjU5MjQ3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuNTk4NDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42MDQ0NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjYxMDQ1OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjE2NDU0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC42MjI0NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0LjYyODQ0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjM0NDQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42NDA0MzZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY0NjQzMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQu
NjUyNDI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNC42NTg0MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY2NDQxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjcwNDEyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42NzY0MDhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY4
MjQwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuNjg4Mzk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC42OTQzOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjcwMDM4OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzA2Mzg0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43MTIz
ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjcxODM3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuNzI0MzcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43MzAzNjZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjczNjM2Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzQyMzU3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC43NDgzNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0Ljc1NDM0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzYwMzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43NjYzMzhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljc3MjMzM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuNzc4MzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC43ODQzMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljc5MDMxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzk2MzE1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44MDIzMTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjgwODMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuODE0MzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC44MjAyOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjgyNjI5MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODMyMjg3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44
MzgyODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0Ljg0NDI3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuODUwMjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44NTYyNjhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljg2MjI2NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODY4
MjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC44NzQyNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0Ljg4MDI1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODg2MjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44OTIyNDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljg5ODIz
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuOTA0MjM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC45MTAyMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjkxNjIyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTIyMjIxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45MjgyMTZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0LjkzNDIxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuOTQwMjA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45NDYyMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljk1MjE5OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTU4MTkyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC45NjQxODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0Ljk3MDE4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTc2MTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45ODIxNzNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljk4ODE2OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQu
OTk0MTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS4wMDAxNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjAwNjE1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDEyMTUwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wMTgxNDVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjAy
NDE0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuMDMwMTM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS4wMzYxMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjA0MjEyNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDQ4MTI2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wNTQx
MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1LjA2MDExNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuMDY2MTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wNzIxMDhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjA3ODEwMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDg0MDk4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNS4wOTAwOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI1LjA5NjA4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTAyMDg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4xMDgwODBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjExNDA3NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjUuMTIwMDcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNS4xMjYwNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjEzMjA2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTM4MDU3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4xNDQwNTJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1
LjE1MDA0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjUuMTU2MDQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNS4xNjIwMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjE2ODAzNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTc0MDI5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4x
ODAwMjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI1LjE4NjAyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjUuMTkyMDE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4xOTgwMTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjIwNDAwNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjEw
MDAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNS4yMTU5OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI1LjIyMTk5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjI3OTg4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yMzM5ODNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjIzOTk3
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjUuMjQ1OTc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNS4yNTE5NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjI1Nzk2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjYzOTYwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yNjk5NTVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI1LjI3NTk1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjUuMjgxOTQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yODc5NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjI5MzkzOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjk5OTM0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NS4zMDU5MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI1LjMxMTkyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzE3OTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zMjM5MTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjMyOTkxMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUu
MzM1OTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS4zNDE5MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM0Nzg5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzUzODkyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zNTk4ODhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM2
NTg4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuMzcxODc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS4zNzc4NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM4Mzg2OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzg5ODY0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zOTU4
NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1LjQwMTg1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuNDA3ODUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40MTM4NDhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQxOTg0NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDI1ODM4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNS40MzE4MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI1LjQzNzgzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDQzODI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40NDk4MjFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQ1NTgxNl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjUuNDYxODExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNS40Njc4MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQ3MzgwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDc5Nzk4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40ODU3OTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1
LjQ5MTc4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjUuNDk3Nzg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNS41MDM3ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjUwOTc3NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTE1NzcxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41
MjE3NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI1LjUyNzc2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjUuNTMzNzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41Mzk3NTJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjU0NTc0N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTUx
NzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNS41NTc3MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI1LjU2MzczM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTY5NzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41NzU3MjRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjU4MTcx
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjUuNTg3NzE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNS41OTM3MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjU5OTcwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjA1NzAxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42MTE2OTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI1LjYxNzY5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjUuNjIzNjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42Mjk2ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjYzNTY3OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjQxNjczXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NS42NDc2NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI1LjY1MzY2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjU5NjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42NjU2NTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjY3MTY1MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUu
Njc3NjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS42ODM2NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjY4OTYzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjk1NjMzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43MDE2MjddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljcw
NzYyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuNzEzNjE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS43MTk2MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjcyNTYwOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNzMxNjA1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43Mzc2
MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1Ljc0MzU5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuNzQ5NTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43NTY1MzldIGk0MGUgMDAwMDowMTowMC4yOiBm
dyA2LjAuNDg0NDIgYXBpIDEuNyBudm0gNi4wMSAweDgwMDAzNDg1IDEuMTc0Ny4wIFs4MDg2OjE1
ODldIFs4MDg2OjAwMDBdClsgICAyNi4wNDQyMjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT02MTQ0MCBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wNTAzMTBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT02MTQ0MCBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wNjUzMDddIGk0
MGUgMDAwMDowMTowMC4yOiBNQUMgYWRkcmVzczogM2M6ZmQ6ZmU6NmI6ZTk6YzIKWyAgIDI2LjA3
MTE5M10gaTQwZSAwMDAwOjAxOjAwLjI6IEZXIExMRFAgaXMgZW5hYmxlZApbICAgMjYuMDgxMjg0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi4wODcyODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjA5MzI3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMDk5MjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4xMDU0MzddIGk0MGUgMDAwMDow
MTowMC4yOiBQQ0ktRXhwcmVzczogU3BlZWQgOC4wR1QvcyBXaWR0aCB4OApbICAgMjYuMTEyNjk1
XSBpNDBlIDAwMDA6MDE6MDAuMjogRmVhdHVyZXM6IFBGLWlkWzJdIFZTSXM6IDM0IFFQOiAxIFJT
UyBGRF9BVFIgRkRfU0IgTlRVUExFIFZ4TEFOIEdlbmV2ZSBQVFAgVkVQQQpbICAgMjYuMTIzMzIx
XSBpNDBlIDAwMDA6MDE6MDAuMzogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAy
Ni4xNDExNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT04MTkyIGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI2LjE0NzE3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTgxOTIg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMTUzMTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4xNTkxNjhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjE2NTE2M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
MTcxMTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi4xNzcxNTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2LjE4MzE0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMTg5MTQ1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4xOTUxNDBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjIw
MTEzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuMjA3MTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi4yMTMxMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjIxOTEyMV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjI1MTE3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4yMzEx
MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2LjIzNzEwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuMjQzMTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4yNDkwOThdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjI1NTA5M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjYxMDg5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi4yNjcwODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjI3MzA4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjc5MDc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4yODUwNzFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjI5MTA2Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuMjk3MDYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi4zMDMwNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjMwOTA1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzE1MDQ3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zMjEwNDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2
LjMyNzA0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjYuMzMzMDM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNi4zMzkwMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjM0NTAyNl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzUxMDIxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4z
NTcwMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI2LjM2MzAxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjYuMzY5MDA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zNzUwMDJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjM4MDk5OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzg2
OTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNi4zOTI5ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI2LjM5ODk4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDA0OTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40MTA5NzhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQxNjk3
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjYuNDIyOTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNi40Mjg5NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQzNDk2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDQwOTYwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40NDY5NTVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI2LjQ1Mjk1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjYuNDU4OTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40NjQ5NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQ3MDkzN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDc2OTMzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ni40ODI5MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI2LjQ4ODkyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDk0OTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41MDA5MTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjUwNjkwOV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
NTEyOTA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi41MTg5MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2LjUyNDg5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTMwODkxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41MzY4ODddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjU0
Mjg4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuNTQ4ODc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi41NTQ4NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjU2MDg2OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTY2ODYzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41NzI4
NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2LjU3ODg1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuNTg0ODQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41OTA4NDVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjU5Njg0MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjAyODM2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi42MDg4MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjYxNDgyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjIwODIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42MjY4MTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjYzMjgxM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuNjM4ODA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi42NDQ4MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjY1MDc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjU2Nzk0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42NjI3ODldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2
LjY2ODc4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjYuNjc0NzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNi42ODA3NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjY4Njc3MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjkyNzY2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42
OTg3NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI2LjcwNDc1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjYuNzEwNzUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43MTY3NDddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjcyMjc0Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNzI4
NzM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNi43MzQ3MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI2Ljc0MDcyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNzQ2NzI0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43NTI3MTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljc1ODcx
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjYuNzY0NzExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNi43NzA3MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljc3NjcwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNzgyNjk3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43ODg2OTJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI2Ljc5NDY4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjYuODAwNjgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi44MDY2NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjgxMjY3M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODE4NjczXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ni44MjQ2NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI2LjgzMDY2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODM2NjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi44NDI2NTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljg0ODY1MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
ODU0NjQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi44NjA2NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljg2NjYzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODcyNjMyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi44Nzg2MjddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljg4
NDYyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuODkwNjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi44OTY2MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjkwMjYwOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuOTA4NjA1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi45MTQ1
OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2LjkyMDU5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuOTI2NTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi45MzI1ODZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjkzODU4Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuOTQ0NTgw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi45NTA1NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2Ljk1NjU3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuOTYyNTY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi45Njg1NjJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljk3NDU1N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuOTgwNTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi45ODY1NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljk5MjU0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuOTk4NTM4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4wMDQ1MzNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3
LjAxMDUyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjcuMDE2NTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNy4wMjI1MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjAyODUxNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMDM0NTEwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4w
NDA1MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI3LjA0NjUwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjcuMDUyNDk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4wNTg0OTFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjA2NDQ4N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMDcw
NDgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNy4wNzY0NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI3LjA4MjQ3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMDg4NDY5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4wOTQ0NjNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjEwMDQ2
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuMTA2NDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy4xMTI0NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjExODQ0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMTI0NDQxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4xMzA0MzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI3LjEzNjQzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjcuMTQyNDI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4xNDg0MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjE1NDQxOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMTYwNDE3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ny4xNjY0MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI3LjE3MjQwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMTc4NDAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4xODQzOThdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjE5MDM5M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcu
MTk2Mzg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNy4yMDIzODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI3LjIwODM3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMjE0Mzc0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4yMjAzNzBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjIy
NjM2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjcuMjMyMzYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNy4yMzgzNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjI0NDM1MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMjUwMzQ2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4yNTYz
NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI3LjI2MjMzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjcuMjY4MzMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4yNzQzMjddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjI4MDMyM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMjg2MzE4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNy4yOTIzMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI3LjI5ODMwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMzA0MzA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4zMTAyOTldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjMxNjI5NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjcuMzIyMjkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNy4zMjgyODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjMzNDI4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMzQwMjc3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4zNDYyNzJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3
LjM1MjI2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjcuMzU4MjYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNy4zNjQyNThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjM3MDI1M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMzc2MjQ5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4z
ODIyNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI3LjM4ODI0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjcuMzk0MjM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40MDAyMzBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQwNjIyNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDEy
MjIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNy40MTgyMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI3LjQyNDIxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDMwMjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40MzYyMDJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQ0MjE5
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuNDQ4MTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy40NTQxODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQ2MDE4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDY2MTgxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40NzIxNzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI3LjQ3ODE3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjcuNDg0MTY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40OTAxNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQ5NjE1OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTAyMTUzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ny41MDgxNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI3LjUxNDE0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTIwMTQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41MjYxMzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjUzMjEzMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcu
NTM4MTI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNy41NDQxMjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI3LjU1MDExNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTU2MTEzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41NjIxMDhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjU2
ODEwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjcuNTc0MDk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNy41ODAwOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjU4NjA5MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTkyMDg2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41OTgw
ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI3LjYwNDA3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjcuNjEwMDcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42MTYwNjddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjYyMjA2Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjI4MDU4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNy42MzQwNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI3LjY0MDA0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjQ2MDQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42NTIwMzldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjY1ODAzNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjcuNjY0MDI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNy42NzAwMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjY3NjAyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjgyMDE1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42ODgwMTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3
LjY5NDAwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjcuNzAwMDAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNy43MDU5OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjcxMTk5Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzE3OTg3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43
MjM5ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI3LjcyOTk3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjcuNzM1OTc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43NDE5NjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljc0Nzk2NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzUz
OTU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNy43NTk5NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI3Ljc2NTk1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzcxOTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43Nzc5NDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljc4Mzkz
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuNzg5OTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy43OTU5MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjgwMTkyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODA3OTE5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy44MTM5MTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI3LjgxOTkxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjcuODI1OTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy44MzE5MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjgzNzg5NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODQzODkxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ny44NDk4ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI3Ljg1NTg4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODYxODc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy44Njc4NzJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljg3Mzg2N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcu
ODc5ODYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNy44ODU4NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljg5MTg1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODk3ODQ4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45MDM4NDNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljkw
OTgzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjcuOTE1ODM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNy45MjE4MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjkyNzgyOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTMzODIzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45Mzk4
MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI3Ljk0NTgxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjcuOTUxODEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45NTc4MDVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljk2MzgwMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTY5Nzk5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNy45NzU3OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI3Ljk4MTc5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTg3Nzg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45OTM3ODBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljk5OTc3Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguMDA1NzcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC4wMTE3NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjAxNzc2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDIzNzU3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4wMjk3NTJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
LjAzNTc0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguMDQxNzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC4wNDc3MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjA1MzczNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDU5NzMwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4w
NjU3MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4LjA3MTcyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguMDc3NzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4wODM3MTFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjA4OTcwNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDk1
NzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC4xMDE2OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4LjEwNzY5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTEzNjg3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xMTk2ODNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjEyNTY3
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjguMTMxNjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOC4xMzc2NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjE0MzY2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTQ5NjU5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xNTU2NTVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI4LjE2MTY1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguMTY3NjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xNzM2NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjE3OTYzN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTg1NjMyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC4xOTE2MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4LjE5NzYyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjAzNjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yMDk2MTNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjIxNTYwOF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
MjIxNjAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC4yMjc1OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4LjIzMzU5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjM5NTkwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yNDU1ODRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjI1
MTU4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguMjU3NTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC4yNjM1NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjI2OTU2Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjc1NTYyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yODE1
NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4LjI4NzU1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguMjkzNTQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yOTk1NDRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjMwNTUzOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzExNTM0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOC4zMTc1MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI4LjMyMzUyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzI5NTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4zMzU1MTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjM0MTUxMV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguMzQ3NTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC4zNTM1MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjM1OTQ5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzY1NDkyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4zNzE0ODhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
LjM3NzQ4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguMzgzNDc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC4zODk0NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjM5NTQ3MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDAxNDY1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40
MDc0NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4LjQxMzQ1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguNDE5NDUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40MjU0NDZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQzMTQ0MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDM3
NDM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC40NDM0MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4LjQ0OTQyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDU1NDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40NjE0MThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQ2NzQx
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjguNDczNDA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOC40Nzk0MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQ4NTQwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDkxMzk4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40OTczOTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI4LjUwMzM4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguNTA5MzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC41MTUzNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjUyMTM3NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTI3MzY5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC41MzMzNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4LjUzOTM2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTQ1MzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC41NTEzNTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjU1NzM0NV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
NTYzMzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC41NjkzMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4LjU3NTMzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTgxMzI4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC41ODczMjRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjU5
MzMxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguNTk5MzE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC42MDUzMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjYxMTMwNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjE3MzAxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42MjMy
OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4LjYyOTI5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguNjM1Mjg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42NDEyODJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjY0NzI3OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjUzMjcz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOC42NTkyNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI4LjY2NTI2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjcxMjYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42NzcyNThdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjY4MzI1NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguNjg5MjQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC42OTUyNDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjcwMTIzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzA3MjM1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC43MTMyMzBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
LjcxOTIyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguNzI1MjIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC43MzEyMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjczNzIxMl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzQzMjA3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC43
NDkyMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4Ljc1NTE5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguNzYxMTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC43NjcxODldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljc3MzE4NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzc5
MTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC43ODUxNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4Ljc5MTE3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzk3MTY2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44MDMxNjFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjgwOTE1
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjguODE1MTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOC44MjExNDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjgyNzE0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODMzMTM3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44MzkxMzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI4Ljg0NTEyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguODUxMTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44NTcxMTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljg2MzExNF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODY5MTA5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC44NzUxMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4Ljg4MTEwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODg3MDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44OTMwOTBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljg5OTA4Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
OTA1MDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC45MTEwNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4LjkxNzA3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTIzMDY3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45MjkwNjJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljkz
NTA1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguOTQxMDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC45NDcwNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljk1MzA0NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTU5MDQwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45NjUw
MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4Ljk3MTAzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguOTc3MDI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45ODMwMjFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljk4OTAxN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTk1MDE1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS4wMDEwMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5LjAwNzAwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDEzMDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wMTg5OTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjAyNDk5MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuMDMwOTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS4wMzY5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjA0Mjk3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDQ4OTcyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wNTQ5NjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
LjA2MDk2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuMDY2OTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS4wNzI5NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjA3ODk0OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDg0OTQ0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4w
OTA5NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5LjA5NjkzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuMTAyOTMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xMDg5MjZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjExNDkyMV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTIw
OTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOS4xMjY5MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI5LjEzMjkwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTM4OTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xNDQ4OThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjE1MDg5
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjkuMTU2ODg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS4xNjI4ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjE2ODg3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTc0ODc1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xODA4NzBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5LjE4Njg2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuMTkyODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xOTg4NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjIwNDg1Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMjEwODQ3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS4yMTY4NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5LjIyMjg0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTgxOTIg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMjI4ODM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4yMzQ4MzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjI0MDgzMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
MjQ2ODI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS4yNTI4MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5LjI1ODgxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMjY0ODEyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4yNzA4MDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjI3
NjgwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuMjgyNzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS4yODg3OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjI5NDc4OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzAwNzgzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zMDY3
NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5LjMxMjc3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjkuMzE4NzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zMjQ3NjVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjMzMDc2MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzM2NzU1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS4zNDI3NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5LjM0ODc0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzU0NzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zNjA3MzZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjM2NjczMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuMzcyNzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS4zNzg3MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjM4NDcxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzkwNzE0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zOTY3MDldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
LjQwMjcwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuNDA4NzAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS40MTQ2OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQyMDY5MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDI2Njg2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS40
MzI2ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5LjQzODY4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuNDQ0Njc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS40NTA2NzBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQ1NjY2NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDYy
NjYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOS40Njg2NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI5LjQ3NDY1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDgwNjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS40ODY2NDJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQ5MjYz
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjkuNDk4NjMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS41MDQ2MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjUxMDYyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTE2NjIyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41MjI2MTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5LjUyODYxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuNTM0NjA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41NDA2MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjU0NjU5OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTUyNTk0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS41NTg1ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5LjU2NDU4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTcwNTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41NzY1NzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjU4MjU3MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
NTg4NTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS41OTQ1NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5LjYwMDU1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjA2NTUzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42MTI1NDhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjYx
ODU0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuNjI0NTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS42MzA1MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjYzNjUyOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjQyNTI1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42NDg1
MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5LjY1NDUxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjkuNjYwNTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42NjY1MDZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjY3MjUwMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjc4NDk3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS42ODQ0OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5LjY5MDQ4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjk2NDgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43MDI0NzhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjcwODQ3M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuNzE0NDY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS43MjA0NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjcyNjQ1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNzMyNDU0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43Mzg0NTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
Ljc0NDQ0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuNzUwNDQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS43NTY0MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljc2MjQzMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNzY4NDI2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43
NzQ0MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5Ljc4MDQxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuNzg2NDEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43OTI0MDhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljc5ODQwNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODA0
Mzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOS44MTAzOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI5LjgxNjM4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODIyMzg1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44MjgzODBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjgzNDM3
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjkuODQwMzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS44NDYzNjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljg1MjM2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODU4MzU2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44NjQzNTFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5Ljg3MDM0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuODc2MzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44ODIzMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljg4ODMzM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODk0MzI4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS45MDAzMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5LjkwNjMxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuOTEyMzE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45MTgzMTBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjkyNDMwNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
OTMwMzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS45MzYyOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljk0MjI5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuOTQ4Mjg2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45NTQyODJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljk2
MDI3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuOTY2MjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS45NzIyNjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljk3ODI2M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuOTg0MjU4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45OTAy
NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5Ljk5NjI0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuMDAyMjQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wMDgyNDBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjAxNDIzOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDIwMjMz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC4wMjYyMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjAzMjIyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDM4MjIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wNDQyMTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjA1MDIxMV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuMDU2MjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC4wNjIyMDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjA2ODE5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDc0MTkyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wODAxODddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
LjA4NjE4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuMDkyMTc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC4wOTgxNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjEwNDE2OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMTEwMTY0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4x
MTYxNTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMwLjEyMjE1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzAuMTI4MTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4xMzQxNDZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjE0MDE0MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMTQ2
MTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMC4xNTIxMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMwLjE1ODEyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMTY0MTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4xNzAxMThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjE3NjEx
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuMTgyMTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC4xODgxMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjE5NDEwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjAwMDk2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yMDYwOTJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjIxMjA4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuMjE4MDgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yMjQwNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjIzMDA3NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjM2MDY5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC4yNDIwNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjI0ODA1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjU0MDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yNjAwNTBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjI2NjA0NV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
MjcyMDQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC4yNzgwMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjI4NDAzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjkwMDI2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yOTYwMjFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjMw
MjAxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuMzA4MDEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC4zMTQwMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjMyMDAwM10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzI1OTk4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4zMzE5
OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMwLjMzNzk4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuMzQzOTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4zNDk5ODBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjM1NTk3NV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzYxOTcx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC4zNjc5NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjM3Mzk2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzc5OTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4zODU5NTNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjM5MTk0OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuMzk3OTQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC40MDM5NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQwOTkzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDE1OTMzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40MjE5MjldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
LjQyNzkyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuNDMzOTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC40Mzk5MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQ0NTkxMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDUxOTA2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40
NTc5MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMwLjQ2Mzg5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzAuNDY5ODkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40NzU4ODddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQ4MTg4M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDg3
ODc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMC40OTM4NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMwLjQ5OTg2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTA1ODY0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41MTE4NTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjUxNzg1
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuNTIzODUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC41Mjk4NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjUzNTg0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTQxODM5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41NDc4MzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjU1MzgyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuNTU5ODI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41NjU4MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjU3MTgxNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTc3ODExXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC41ODM4MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjU4OTgwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTk1Nzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42MDE3OTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjYwNzc4OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
NjEzNzg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC42MTk3NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjYyNTc3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNjMxNzcwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42Mzc3NjZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjY0
Mzc2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuNjQ5NzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC42NTU3NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjY2MTc0N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNjY3NzQyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42NzM3
MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMwLjY3OTczMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuNjg1NzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42OTE3MjNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjY5NzcxOV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzAzNzE0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC43MDk3MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjcxNTcwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzIxNzAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43Mjc2OTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjczMzY5MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuNzM5Njg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC43NDU2ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjc1MTY3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzU3NjcyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43NjM2NjddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
Ljc2OTY2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuNzc1NjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC43ODE2NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjc4NzY0OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzkzNjQ1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43
OTk2NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMwLjgwNTYzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzAuODExNjMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44MTc2MjddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjgyMzYyMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuODI5
NjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMC44MzU2MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMwLjg0MTYwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuODQ3NjAzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44NTM1OTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjg1OTU5
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuODY1NTg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC44NzE1ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjg3NzU4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuODgzNTc1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44ODk1NzBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjg5NTU2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuOTAxNTYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45MDc1NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjkxMzU1Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTE5NTQ3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC45MjU1NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjkzMTUzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTM3NTMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45NDM1MjldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjk0OTUyOF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
OTU1NTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC45NjE1MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjk2NzUxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTczNTA5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45Nzk1MDRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjk4
NTUwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuOTkxNDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC45OTc0OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjAwMzQ4Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDA5NDgxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wMTU0
NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjAyMTQ3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuMDI3NDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wMzM0NjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjAzOTQ2MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDQ1NDU2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS4wNTE0NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjA1NzQ0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDYzNDQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wNjk0MzhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjA3NTQzM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuMDgxNDI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS4wODc0MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjA5MzQxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDk5NDE0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xMDU0MTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
LjExMTQwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuMTE3NDAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMS4xMjMzOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjEyOTM5Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTM1Mzg3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4x
NDEzODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMxLjE0NzM3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzEuMTUzMzczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xNTkzNjhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjE2NTM2NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTcx
MzU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS4xNzczNTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjE4MzM0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTg5MzQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xOTUzNDBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjIwMTMz
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuMjA3MzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS4yMTMzMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjIxOTMyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjI1MzE3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yMzEzMTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjIzNzMwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuMjQzMzAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yNDkyOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjI1NTI5NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjYxMjkwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS4yNjcyODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjI3MzI4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjc5Mjc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yODUyNzFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjI5MTI2Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
Mjk3MjYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS4zMDMyNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjMwOTI1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzE1MjQ4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4zMjEyNDRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjMy
NzIzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzEuMzMzMjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMS4zMzkyMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjM0NTIyNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzUxMjIwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4zNTcy
MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjM2MzIxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuMzY5MjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4zNzUyMDFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjM4MTE5N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzg3MTky
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS4zOTMxODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjM5OTE4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDA1MTc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40MTExNzNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQxNzE2OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuNDIzMTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS40MjkxNTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQzNTE1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDQxMTUwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40NDcxNDVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
LjQ1MzE0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuNDU5MTM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMS40NjUxMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQ3MTEyN10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDc3MTIzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40
ODMxMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMxLjQ4OTExNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzEuNDk1MTA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41MDExMDRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjUwNzA5OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTEz
MDk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS41MTkwOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjUyNTA4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTMxMDgwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41MzcwNzZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjU0MzA3
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuNTQ5MDY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS41NTUwNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjU2MTA2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTY3MDU1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41NzMwNTBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjU3OTA0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuNTg1MDQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41OTEwMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjU5NzAzM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjAzMDI3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS42MDkwMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjYxNTAxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjIxMDE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42MjcwMDldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjYzMzAwNF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
NjM5MDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS42NDQ5OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjY1MDk5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjU2OTg2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42NjI5ODFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjY2
ODk3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzEuNjc0OTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMS42ODA5NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjY4Njk2M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjkyOTU4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42OTg5
NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjcwNDk1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuNzEwOTQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43MTY5NDNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjcyMjkzOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzI4OTM0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS43MzQ5MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjc0MDkyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzQ2OTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43NTI5MTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjc1ODkxMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuNzY0OTA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS43NzA5MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjc3Njg5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzgyODkxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43ODg4ODddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
Ljc5NDg4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuODAwODc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMS44MDY4NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjgxMjg2OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODE4ODYzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44
MjQ4NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMxLjgzMDg1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzEuODM2ODQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44NDI4NDRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjg0ODg0MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODU0
ODM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS44NjA4MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjg2NjgyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODcyODIxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44Nzg4MTZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjg4NDgx
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuODkwODA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS44OTY4MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjkwMjc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTA4NzkzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS45MTQ3ODhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjkyMDc4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuOTI2NzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS45MzI3NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjkzODc3MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTQ0NzY2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS45NTA3NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjk1Njc1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTYyNzUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS45Njg3NDhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjk3NDc0M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
OTgwNzM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS45ODY3MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjk5MjcyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTk4NzI0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wMDQ3MjBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjAx
MDcxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzIuMDE2NzEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMi4wMjI3MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjAyODcwMV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDM0Njk2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wNDA2
OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMyLjA0NjY4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzIuMDUyNjgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wNTg2NzddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjA2NDY3Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDcwNjcw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi4wNzY2NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjA4MjY2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDg4NjU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wOTQ2NTJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjEwMDY0OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzIuMTA2NjQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMi4xMTI2MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjExODYzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTI0NjI5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4xMzA2MjRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMy
LjEzNjYyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzIuMTQyNjE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMi4xNDg2MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjE1NDYwNl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTYwNjAyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4x
NjY1OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMyLjE3MjU5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzIuMTc4NTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4xODQ1ODNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjE5MDU3OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTk2
NTczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMi4yMDI1NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMyLjIwODU2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjE0NTU5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yMjA1NTVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjIyNjU0
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzIuMjMyNTQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMi4yMzg1NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjI0NDUzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjUwNTMxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yNTY1Mjdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMyLjI2MjUyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzIuMjY4NTE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yNzQ1MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjI4MDUwOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjg2NTAzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
Mi4yOTI0OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMyLjI5ODQ5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMzA1NDQyXSBpNDBlIDAwMDA6MDE6MDAuMzogZncgNi4w
LjQ4NDQyIGFwaSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5XSBb
ODA4NjowMDAwXQpbICAgMzIuNTkzMDQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NjE0NDAgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNTk5MTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NjE0NDAgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjA2OTAyXSBpNDBlIDAw
MDA6MDE6MDAuMzogTUFDIGFkZHJlc3M6IDNjOmZkOmZlOjZiOmU5OmMzClsgICAzMi42MTI3ODhd
IGk0MGUgMDAwMDowMTowMC4zOiBGVyBMTERQIGlzIGVuYWJsZWQKWyAgIDMyLjYyMjg2Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIu
NjI4ODU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMi42MzQ4NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMyLjY0MDg1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjQ3MDA3XSBpNDBlIDAwMDA6MDE6MDAu
MzogUENJLUV4cHJlc3M6IFNwZWVkIDguMEdUL3MgV2lkdGggeDgKWyAgIDMyLjY1NDMxNl0gaTQw
ZSAwMDAwOjAxOjAwLjM6IEZlYXR1cmVzOiBQRi1pZFszXSBWU0lzOiAzNCBRUDogMSBSU1MgRkRf
QVRSIEZEX1NCIE5UVVBMRSBWeExBTiBHZW5ldmUgUFRQIFZFUEEKWyAgIDMyLjY2NDMzMl0gZWhj
aV9oY2Q6IFVTQiAyLjAgJ0VuaGFuY2VkJyBIb3N0IENvbnRyb2xsZXIgKEVIQ0kpIERyaXZlcgpb
ICAgMzIuNjcxNTA3XSBlaGNpLXBjaTogRUhDSSBQQ0kgcGxhdGZvcm0gZHJpdmVyClsgICAzMi42
NzYwNTddIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAw
MDIpClsgICAzMi42ODIxNjldIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogeEhDSSBIb3N0IENvbnRy
b2xsZXIKWyAgIDMyLjY4NzM4OV0geGhjaV9oY2QgMDAwZDowMTowMC4yOiBuZXcgVVNCIGJ1cyBy
ZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDEKWyAgIDMyLjY5NTMwN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTIwNTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzAxMzAy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9MjA1NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi43MDczMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjcxMzI5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzE5Mjk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43MjUyODldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjczMTI4N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzIuNzM3MjgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMi43NDMyODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT0xNiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMi43NDkxMDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT0xNiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43NTQ5NDBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT0yNCBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43NjA3NjJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT0yNCBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43NjY1ODRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMyLjc3MjU3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzIuNzc4NTc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43ODQ1NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjc5MDU2NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzk2NTYwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
Mi44MDI1NzhdIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogaGNjIHBhcmFtcyAweDAxODBmZjA1IGhj
aSB2ZXJzaW9uIDB4MTEwIHF1aXJrcyAweDAwMDAwMDAwMDAwMDAwMTAKWyAgIDMyLjgxMTk4Nl0g
aHViIDEtMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDMyLjgxNTc0Ml0gaHViIDEtMDoxLjA6IDIg
cG9ydHMgZGV0ZWN0ZWQKWyAgIDMyLjgxOTg2OF0geGhjaV9oY2QgMDAwZDowMTowMC4yOiB4SENJ
IEhvc3QgQ29udHJvbGxlcgpbICAgMzIuODI1MDg3XSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IG5l
dyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIgMgpbICAgMzIuODMyNDc0
XSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IEhvc3Qgc3VwcG9ydHMgVVNCIDMuMSBFbmhhbmNlZCBT
dXBlclNwZWVkClsgICAzMi44Mzk1MzNdIHVzYiB1c2IyOiBXZSBkb24ndCBrbm93IHRoZSBhbGdv
cml0aG1zIGZvciBMUE0gZm9yIHRoaXMgaG9zdCwgZGlzYWJsaW5nIExQTS4KWyAgIDMyLjg0Nzcw
M10gaHViIDItMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDMyLjg1MTQ1NV0gaHViIDItMDoxLjA6
IDQgcG9ydHMgZGV0ZWN0ZWQKWyAgIDMyLjg1NTY3Ml0geGhjaV9oY2QgMDAwNDowMzowMC4wOiB4
SENJIEhvc3QgQ29udHJvbGxlcgpbICAgMzIuODYwODkzXSB4aGNpX2hjZCAwMDA0OjAzOjAwLjA6
IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIgMwpbICAgMzIuODcz
NTk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9MjA1NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMi44Nzk1OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT0yMDU2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMyLjg4NTU5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuODkxNTg1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi44OTc1ODZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjkwMzU4
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzIuOTA5NTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMi45MTU1NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjkyMTU3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTE2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjkyNzM5M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTE2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjkzMzIzNV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTMyIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjkz
OTA1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTMyIGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMyLjk0NDg3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzIuOTUwODc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45NTY4NzBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjk2Mjg2NV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuOTY4ODYx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi45NzQ4NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjk4MDg1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuOTg2ODQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45OTI4NzZdIHhoY2lfaGNkIDAw
MDQ6MDM6MDAuMDogaGNjIHBhcmFtcyAweDAxNDA1MWNmIGhjaSB2ZXJzaW9uIDB4MTAwIHF1aXJr
cyAweDAwMDAwMDExMDAwMDA0MTAKWyAgIDMzLjAwMjMzMF0gaHViIDMtMDoxLjA6IFVTQiBodWIg
Zm91bmQKWyAgIDMzLjAwNjA3OV0gaHViIDMtMDoxLjA6IDQgcG9ydHMgZGV0ZWN0ZWQKWyAgIDMz
LjAxMDI2NF0geGhjaV9oY2QgMDAwNDowMzowMC4wOiB4SENJIEhvc3QgQ29udHJvbGxlcgpbICAg
MzMuMDE1NDgxXSB4aGNpX2hjZCAwMDA0OjAzOjAwLjA6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQs
IGFzc2lnbmVkIGJ1cyBudW1iZXIgNApbICAgMzMuMDIyODY3XSB4aGNpX2hjZCAwMDA0OjAzOjAw
LjA6IEhvc3Qgc3VwcG9ydHMgVVNCIDMuMCBTdXBlclNwZWVkClsgICAzMy4wMjkxNjVdIHVzYiB1
c2I0OiBXZSBkb24ndCBrbm93IHRoZSBhbGdvcml0aG1zIGZvciBMUE0gZm9yIHRoaXMgaG9zdCwg
ZGlzYWJsaW5nIExQTS4KWyAgIDMzLjAzNzM1M10gaHViIDQtMDoxLjA6IFVTQiBodWIgZm91bmQK
WyAgIDMzLjA0MTEwNl0gaHViIDQtMDoxLjA6IDQgcG9ydHMgZGV0ZWN0ZWQKWyAgIDMzLjA0NTM0
OF0geGhjaV9oY2QgMDAwNTowMjowMC4wOiB4SENJIEhvc3QgQ29udHJvbGxlcgpbICAgMzMuMDUw
NTY3XSB4aGNpX2hjZCAwMDA1OjAyOjAwLjA6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2ln
bmVkIGJ1cyBudW1iZXIgNQpbICAgMzMuMTY4ODY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9MjA1NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4xNzQ4NjBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT0yMDU2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjE4MDg1OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMu
MTg2ODU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMy4xOTI4NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMzLjE5ODg1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjA0ODQ4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yMTA4NDNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjIx
Njg0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTE2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMzLjIyMjY2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTE2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMzLjIyODQ5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTMy
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjIzNDMyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTMyIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjI0MDE0M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjQ2MTM4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4y
NTIxMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMzLjI1ODEyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzMuMjY0MTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yNzAxMjBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjI3NjExNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjgy
MTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMy4yODgxNDBdIHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogaGNjIHBhcmFtcyAweDAxNDA1
MWNmIGhjaSB2ZXJzaW9uIDB4MTAwIHF1aXJrcyAweDAwMDAwMDExMDAwMDA0MTAKWyAgIDMzLjI5
NzU4OV0gaHViIDUtMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDMzLjMwMTM0N10gaHViIDUtMDox
LjA6IDQgcG9ydHMgZGV0ZWN0ZWQKWyAgIDMzLjMwNTUyM10geGhjaV9oY2QgMDAwNTowMjowMC4w
OiB4SENJIEhvc3QgQ29udHJvbGxlcgpbICAgMzMuMzEwNzQxXSB4aGNpX2hjZCAwMDA1OjAyOjAw
LjA6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIgNgpbICAgMzMu
MzE4MTI4XSB4aGNpX2hjZCAwMDA1OjAyOjAwLjA6IEhvc3Qgc3VwcG9ydHMgVVNCIDMuMCBTdXBl
clNwZWVkClsgICAzMy4zMjQ0MzJdIHVzYiB1c2I2OiBXZSBkb24ndCBrbm93IHRoZSBhbGdvcml0
aG1zIGZvciBMUE0gZm9yIHRoaXMgaG9zdCwgZGlzYWJsaW5nIExQTS4KWyAgIDMzLjMzMjYxNl0g
aHViIDYtMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDMzLjMzNjM2OV0gaHViIDYtMDoxLjA6IDQg
cG9ydHMgZGV0ZWN0ZWQKWyAgIDMzLjM0MDY0MV0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50
ZXJmYWNlIGRyaXZlciB1c2Itc3RvcmFnZQpbICAgMzMuMzQ5MDc5XSBydGMtZWZpIHJ0Yy1lZmku
MDogcmVnaXN0ZXJlZCBhcyBydGMwClsgICAzMy4zNTQxMDBdIHJ0Yy1lZmkgcnRjLWVmaS4wOiBz
ZXR0aW5nIHN5c3RlbSBjbG9jayB0byAyMDIyLTA0LTIwVDEwOjEyOjM0IFVUQyAoMTY1MDQ0OTU1
NCkKWyAgIDMzLjM2MjU2Nl0gc2JzYS1nd2R0IHNic2EtZ3dkdC4wOiBJbml0aWFsaXplZCB3aXRo
IDEwcyB0aW1lb3V0IEAgMjUwMDAwMDAgSHosIGFjdGlvbj0wLgpbICAgMzMuMzcwNzYyXSBkZXZp
Y2UtbWFwcGVyOiBpb2N0bDogNC40My4wLWlvY3RsICgyMDIwLTEwLTAxKSBpbml0aWFsaXNlZDog
ZG0tZGV2ZWxAcmVkaGF0LmNvbQpbICAgMzMuMzc5OTU5XSBwc3RvcmU6IFJlZ2lzdGVyZWQgZWZp
IGFzIHBlcnNpc3RlbnQgc3RvcmUgYmFja2VuZApbICAgMzMuMzg1ODE3XSBTTUNDQzogU09DX0lE
OiBJRCA9IGplcDEwNjowYTE2OjAwMDEgUmV2aXNpb24gPSAweDAwMDAwMGExClsgICAzMy4zOTI0
NTFdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgdXNiaGlkClsgICAz
My4zOTgwMTNdIHVzYmhpZDogVVNCIEhJRCBjb3JlIGRyaXZlcgpbICAgMzMuNDAxODYwXSB1MzIg
Y2xhc3NpZmllcgpbICAgMzMuNDA0NTU3XSAgICAgaW5wdXQgZGV2aWNlIGNoZWNrIG9uClsgICAz
My40MDgyNjBdICAgICBBY3Rpb25zIGNvbmZpZ3VyZWQKWyAgIDMzLjQxMjA0MF0gTkVUOiBSZWdp
c3RlcmVkIHByb3RvY29sIGZhbWlseSAxMApbICAgMzMuNDE2ODExXSBTZWdtZW50IFJvdXRpbmcg
d2l0aCBJUHY2ClsgICAzMy40MjA0OTVdIHNpdDogSVB2NiwgSVB2NCBhbmQgTVBMUyBvdmVyIElQ
djQgdHVubmVsaW5nIGRyaXZlcgpbICAgMzMuNDI2NTU3XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9j
b2wgZmFtaWx5IDE3ClsgICAzMy40MzEwMDhdIEJyaWRnZSBmaXJld2FsbGluZyByZWdpc3RlcmVk
ClsgICAzMy40MzUwMjhdIEtleSB0eXBlIGRuc19yZXNvbHZlciByZWdpc3RlcmVkClsgICAzMy40
MzkzMjVdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgNDAKWyAgIDMzLjQ0Mzg4OV0g
S2V5IHR5cGUgLl9mc2NyeXB0IHJlZ2lzdGVyZWQKWyAgIDMzLjQ0Nzg5Nl0gS2V5IHR5cGUgLmZz
Y3J5cHQgcmVnaXN0ZXJlZApbICAgMzMuNDUxODI3XSBLZXkgdHlwZSBmc2NyeXB0LXByb3Zpc2lv
bmluZyByZWdpc3RlcmVkClsgICAzMy40NTY3OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDMzLjQ2MzAxNl0gQnRyZnMgbG9hZGVkLCBj
cmMzMmM9Y3JjMzJjLWdlbmVyaWMKWyAgIDMzLjQ2NzUzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzMuNDczNjE2XSBwc3RvcmU6IFVz
aW5nIGNyYXNoIGR1bXAgY29tcHJlc3Npb246IGRlZmxhdGUKWyAgIDMzLjQ3OTAwOV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzMuNDg1
MTg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0w
ClsgICAzMy40OTEyMDhdIEtleSB0eXBlIGVuY3J5cHRlZCByZWdpc3RlcmVkClsgICAzMy40OTU0
NjNdIEJFUlQ6IEVycm9yIHJlY29yZHMgZnJvbSBwcmV2aW91cyBib290OgpbICAgMzMuNTAwMzUy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsg
ICAzMy41MDYzNTJdIFtIYXJkd2FyZSBFcnJvcl06IGV2ZW50IHNldmVyaXR5OiByZWNvdmVyYWJs
ZQpbICAgMzMuNTExNzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jMDAgYXR0cj0wClsgICAzMy41MTc3NDJdIFtIYXJkd2FyZSBFcnJvcl06ICBFcnJvciAwLCB0
eXBlOiBmYXRhbApbICAgMzMuNTIyNjExXSBbSGFyZHdhcmUgRXJyb3JdOiAgIHNlY3Rpb24gdHlw
ZTogdW5rbm93biwgZThlZDg5OGQtZGYxNi00M2NjLThlY2MtNTRmMDYwZWYxNTdmClsgICAzMy41
MzA5NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRy
PTAKWyAgIDMzLjUzNjk0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9YzAwIGF0dHI9MApbICAgMzMuNTQyOTQzXSBbSGFyZHdhcmUgRXJyb3JdOiAgIHNlY3Rpb24g
bGVuZ3RoOiAweDMxClsgICAzMy41NDc5NThdIFtIYXJkd2FyZSBFcnJvcl06ICAgMDAwMDAwMDA6
IDAwMDAwMDdmIDZlNmI2ZTU1IDIwNmU3NzZmIDZmNjI2NTcyICAuLi4uVW5rbm93biByZWJvClsg
ICAzMy41NTY2NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMw
MCBhdHRyPTAKWyAgIDMzLjU2MjY2M10gW0hhcmR3YXJlIEVycm9yXTogICAwMDAwMDAxMDogNzIy
MDc0NmYgNmY3MzYxNjUgMDAwMDAwNmUgMDAwMDAwMDAgIG90IHJlYXNvbi4uLi4uLi4KWyAgIDMz
LjU3MTM1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0
dHI9MApbICAgMzMuNTc3MzUwXSBbSGFyZHdhcmUgRXJyb3JdOiAgIDAwMDAwMDIwOiAwMDAwMDAw
MCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAgLi4uLi4uLi4uLi4uLi4uLgpbICAgMzMuNTg2
MDQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0w
ClsgICAzMy41OTIwMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWMwMCBhdHRyPTAKWyAgIDMzLjU5ODAzNl0gW0hhcmR3YXJlIEVycm9yXTogICAwMDAwMDAzMDog
MTEgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC4KWyAgIDMz
LjYwNjQ4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0
dHI9MApbICAgMzMuNjEyNTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jMDAgYXR0cj0wClsgICAzMy42MTg1ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDMzLjYyNDU3N10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzMuNjMxMTQ4XSBwcmlu
dGs6IGNvbnNvbGUgW25ldGNvbjBdIGVuYWJsZWQKWyAgIDMzLjYzNTQ5N10gbmV0Y29uc29sZTog
bmV0d29yayBsb2dnaW5nIHN0YXJ0ZWQKWyAgIDMzLjY0MDA4Ml0gbWQ6IFdhaXRpbmcgZm9yIGFs
bCBkZXZpY2VzIHRvIGJlIGF2YWlsYWJsZSBiZWZvcmUgYXV0b2RldGVjdApbICAgMzMuNjQ2ODY2
XSBtZDogSWYgeW91IGRvbid0IHVzZSByYWlkLCB1c2UgcmFpZD1ub2F1dG9kZXRlY3QKWyAgIDMz
LjY1MjUxN10gbWQ6IEF1dG9kZXRlY3RpbmcgUkFJRCBhcnJheXMuClsgICAzMy42NTY2MDRdIG1k
OiBhdXRvcnVuIC4uLgpbICAgMzMuNjU5Mzk5XSBtZDogLi4uIGF1dG9ydW4gRE9ORS4KWyAgIDMz
LjY2MjczOV0gV2FpdGluZyBmb3Igcm9vdCBkZXZpY2UgL2Rldi9zZGEyLi4uClsgICAzMy42Nzgy
MzJdIHVzYiAzLTQ6IG5ldyBoaWdoLXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDIgdXNpbmcgeGhj
aV9oY2QKWyAgIDMzLjc2MTQxNl0gdXNiIDYtMTogbmV3IFN1cGVyU3BlZWQgR2VuIDEgVVNCIGRl
dmljZSBudW1iZXIgMiB1c2luZyB4aGNpX2hjZApbICAgMzMuODA1NDAzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzMy44MTE0MDFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDMz
LjgxNzQwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0
dHI9MApbICAgMzMuODIzNDE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jMDAgYXR0cj0wClsgICAzMy44Mjk0MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDMzLjgzNTQyMl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzMuODQxNDE5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzMy44
NDc0MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRy
PTAKWyAgIDMzLjg1NTM3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9ODAwIGF0dHI9MApbICAgMzMuODYxMzc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz04MDAgYXR0cj0wClsgICAzMy44NzEwNjBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDMzLjg3NzA2MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzMuODgz
MDcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0w
ClsgICAzMy44ODkwOThdIHVzYi1zdG9yYWdlIDYtMToxLjA6IFVTQiBNYXNzIFN0b3JhZ2UgZGV2
aWNlIGRldGVjdGVkClsgICAzMy44OTUxODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDMzLjkwMTI0MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTA3MjU4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy45MTMy
NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAK
WyAgIDMzLjkxOTI5MV0gc2NzaSBob3N0MDogdXNiLXN0b3JhZ2UgNi0xOjEuMApbICAgMzMuOTIz
NDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz04MDAgYXR0cj0w
ClsgICAzMy45Mzg1MjVdIGh1YiAzLTQ6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzMy45NDQyMTFd
IGh1YiAzLTQ6MS4wOiA1IHBvcnRzIGRldGVjdGVkClsgICAzNC4xNzkyODNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjE4NTI4MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAg
MzQuMTkxMjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAg
YXR0cj0wClsgICAzNC4xOTcyODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjIwMzI4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuMjA5Mjg0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC4zMDIyODJdIHVz
YiAzLTQuMTogbmV3IGhpZ2gtc3BlZWQgVVNCIGRldmljZSBudW1iZXIgMyB1c2luZyB4aGNpX2hj
ZApbICAgMzQuNDI1ODkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jMDAgYXR0cj0wClsgICAzNC40MzE4OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjQzNzg5MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuNDQzODg3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC40NDk4
ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAK
WyAgIDM0LjQ1NTg4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
YzAwIGF0dHI9MApbICAgMzQuNDYxODc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC40Njc4NzVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjQ3NTc0Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9ODAwIGF0dHI9MApbICAgMzQuNDgxNzM5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz04MDAgYXR0cj0wClsg
ICAzNC40OTg3MzddIHVzYi1zdG9yYWdlIDMtNC4xOjEuMDogVVNCIE1hc3MgU3RvcmFnZSBkZXZp
Y2UgZGV0ZWN0ZWQKWyAgIDM0LjUwNTA1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuNTExMDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC41MTcwODBdIHNjc2kgaG9z
dDE6IHVzYi1zdG9yYWdlIDMtNC4xOjEuMApbICAgMzQuNTI1NzkzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC41MzE3OTBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjUz
Nzc5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9
MApbICAgMzQuNTQzNzk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jMDAgYXR0cj0wClsgICAzNC41NDk3OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjU1NTc5NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuNjUwMjYzXSB1c2IgMy00
LjI6IG5ldyBoaWdoLXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDQgdXNpbmcgeGhjaV9oY2QKWyAg
IDM0Ljc4Mjg0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAw
IGF0dHI9MApbICAgMzQuNzg4ODM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC43OTQ4NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjgwMDgzN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuODA2ODM0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAz
NC44MTI4MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBh
dHRyPTAKWyAgIDM0LjgxODgyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuODI0ODIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC44MzI5MTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM0LjgzODkxMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9ODAwIGF0dHI9MApbICAgMzQu
ODUzODIyXSB1c2Itc3RvcmFnZSAzLTQuMjoxLjA6IFVTQiBNYXNzIFN0b3JhZ2UgZGV2aWNlIGRl
dGVjdGVkClsgICAzNC44NjAxNjddIHNjc2kgaG9zdDI6IHVzYi1zdG9yYWdlIDMtNC4yOjEuMApb
ICAgMzQuODY4MTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
MDAgYXR0cj0wClsgICAzNC44NzQxMTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0Ljg4MDEyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuODg2MTE1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC44OTIxMTFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAg
IDM0Ljg5ODExNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAw
IGF0dHI9MApbICAgMzQuOTQ1MzUwXSBzY3NpIDA6MDowOjA6IERpcmVjdC1BY2Nlc3MgICAgICBV
U0IgICAgICBTYW5EaXNrIDMuMkdlbjEgMS4wMCBQUTogMCBBTlNJOiA2ClsgICAzNC45NTM3MDJd
IHNkIDA6MDowOjA6IFtzZGFdIDEyMDE3NjY0MCA1MTItYnl0ZSBsb2dpY2FsIGJsb2NrczogKDYx
LjUgR0IvNTcuMyBHaUIpClsgICAzNC45NjQxNDFdIHNkIDA6MDowOjA6IFtzZGFdIFdyaXRlIFBy
b3RlY3QgaXMgb2ZmClsgICAzNC45NzAwMjldIHNkIDA6MDowOjA6IFtzZGFdIFdyaXRlIGNhY2hl
OiBkaXNhYmxlZCwgcmVhZCBjYWNoZTogZW5hYmxlZCwgZG9lc24ndCBzdXBwb3J0IERQTyBvciBG
VUEKWyAgIDM0Ljk4NjkzNV0gR1BUOlByaW1hcnkgaGVhZGVyIHRoaW5rcyBBbHQuIGhlYWRlciBp
cyBub3QgYXQgdGhlIGVuZCBvZiB0aGUgZGlzay4KWyAgIDM0Ljk5NDMyOF0gdXNiIDMtNC4zOiBu
ZXcgbG93LXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDUgdXNpbmcgeGhjaV9oY2QKWyAgIDM1LjAw
MDkzNF0gR1BUOjE3MTgxOTUxICE9IDEyMDE3NjYzOQpbICAgMzUuMDA0NTkwXSBHUFQ6QWx0ZXJu
YXRlIEdQVCBoZWFkZXIgbm90IGF0IHRoZSBlbmQgb2YgdGhlIGRpc2suClsgICAzNS4wMTA1OTld
IEdQVDoxNzE4MTk1MSAhPSAxMjAxNzY2MzkKWyAgIDM1LjAxNDI2NF0gR1BUOiBVc2UgR05VIFBh
cnRlZCB0byBjb3JyZWN0IEdQVCBlcnJvcnMuClsgICAzNS4wMTkzOTZdICBzZGE6IHNkYTEgc2Rh
MgpbICAgMzUuMDI1MjE4XSBzZCAwOjA6MDowOiBbc2RhXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJs
ZSBkaXNrClsgICAzNS4wNTEzMDNdIHJhbmRvbTogZmFzdCBpbml0IGRvbmUKWyAgIDM1LjE0NTk4
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApb
ICAgMzUuMTUxOTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
MDAgYXR0cj0wClsgICAzNS4xNTgxMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjE2NDEzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuMTcwMTUzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS4xNzYxNTld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAg
IDM1LjE4MjE2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAw
IGF0dHI9MApbICAgMzUuMTg4Mjk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS4xOTc5NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1LjIwMzk2OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9ODAwIGF0dHI9MApbICAgMzUuMjM1NzI4XSBp
bnB1dDogQW1lcmljYW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1YWwgS2V5Ym9hcmQgYW5kIE1vdXNl
IGFzIC9kZXZpY2VzL3BjaTAwMDQ6MDAvMDAwNDowMDowMy4wLzAwMDQ6MDM6MDAuMC91c2IzLzMt
NC8zLTQuMy8zLTQuMzoxLjAvMDAwMzowNDZCOkZGMTAuMDAwMS9pbnB1dC9pbnB1dDEKWyAgIDM1
LjI1MTcyNV0gaGlkLWdlbmVyaWMgMDAwMzowNDZCOkZGMTAuMDAwMTogaW5wdXQ6IFVTQiBISUQg
djEuMTAgS2V5Ym9hcmQgW0FtZXJpY2FuIE1lZ2F0cmVuZHMgSW5jLiBWaXJ0dWFsIEtleWJvYXJk
IGFuZCBNb3VzZV0gb24gdXNiLTAwMDQ6MDM6MDAuMC00LjMvaW5wdXQwClsgICAzNS4yNzgyODld
IGlucHV0OiBBbWVyaWNhbiBNZWdhdHJlbmRzIEluYy4gVmlydHVhbCBLZXlib2FyZCBhbmQgTW91
c2UgYXMgL2RldmljZXMvcGNpMDAwNDowMC8wMDA0OjAwOjAzLjAvMDAwNDowMzowMC4wL3VzYjMv
My00LzMtNC4zLzMtNC4zOjEuMS8wMDAzOjA0NkI6RkYxMC4wMDAyL2lucHV0L2lucHV0MgpbICAg
MzUuMjk0MjgyXSBoaWQtZ2VuZXJpYyAwMDAzOjA0NkI6RkYxMC4wMDAyOiBpbnB1dDogVVNCIEhJ
RCB2MS4xMCBNb3VzZSBbQW1lcmljYW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1YWwgS2V5Ym9hcmQg
YW5kIE1vdXNlXSBvbiB1c2ItMDAwNDowMzowMC4wLTQuMy9pbnB1dDEKWyAgIDM1LjU1Mzg4N10g
c2NzaSAxOjA6MDowOiBDRC1ST00gICAgICAgICAgICBBTUkgICAgICBWaXJ0dWFsIENEUk9NMCAg
IDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM1LjU2MjcwOF0gc2NzaSAxOjA6MDoxOiBDRC1S
T00gICAgICAgICAgICBBTUkgICAgICBWaXJ0dWFsIENEUk9NMSAgIDEuMDAgUFE6IDAgQU5TSTog
MCBDQ1MKWyAgIDM1LjU3MTM4N10gc2NzaSAxOjA6MDoyOiBDRC1ST00gICAgICAgICAgICBBTUkg
ICAgICBWaXJ0dWFsIENEUk9NMiAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM1LjU4MDEw
Ml0gc2NzaSAxOjA6MDozOiBDRC1ST00gICAgICAgICAgICBBTUkgICAgICBWaXJ0dWFsIENEUk9N
MyAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM1Ljg3NDQ3NV0gc2NzaSAyOjA6MDowOiBE
aXJlY3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrMCAgIDEuMDAgUFE6IDAgQU5T
STogMCBDQ1MKWyAgIDM1Ljg4NDQ2M10gc2QgMjowOjA6MDogW3NkYl0gQXR0YWNoZWQgU0NTSSBy
ZW1vdmFibGUgZGlzawpbICAgMzUuODkwMDY4XSBzY3NpIDI6MDowOjE6IERpcmVjdC1BY2Nlc3Mg
ICAgIEFNSSAgICAgIFZpcnR1YWwgSERpc2sxICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAg
MzUuODk5NTcxXSBzZCAyOjA6MDoxOiBbc2RjXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNr
ClsgICAzNS45MDUzNTldIHNjc2kgMjowOjA6MjogRGlyZWN0LUFjY2VzcyAgICAgQU1JICAgICAg
VmlydHVhbCBIRGlzazIgICAxLjAwIFBROiAwIEFOU0k6IDAgQ0NTClsgICAzNS45MTQ4NjNdIHNk
IDI6MDowOjI6IFtzZGRdIEF0dGFjaGVkIFNDU0kgcmVtb3ZhYmxlIGRpc2sKWyAgIDM1LjkyMDYx
Nl0gc2NzaSAyOjA6MDozOiBEaXJlY3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNr
MyAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM1LjkzMDA5MF0gc2QgMjowOjA6MzogW3Nk
ZV0gQXR0YWNoZWQgU0NTSSByZW1vdmFibGUgZGlzawpbICAgMzUuOTM1ODk3XSBzY3NpIDI6MDow
OjQ6IERpcmVjdC1BY2Nlc3MgICAgIEFNSSAgICAgIFZpcnR1YWwgSERpc2s0ICAgMS4wMCBQUTog
MCBBTlNJOiAwIENDUwpbICAgMzUuOTQ1Mzg0XSBzZCAyOjA6MDo0OiBbc2RmXSBBdHRhY2hlZCBT
Q1NJIHJlbW92YWJsZSBkaXNrClsgICAzNi4xOTk0NzFdIEVYVDQtZnMgKHNkYTIpOiByZWNvdmVy
eSBjb21wbGV0ZQpbICAgMzYuMjMyMzk1XSBFWFQ0LWZzIChzZGEyKTogbW91bnRlZCBmaWxlc3lz
dGVtIHdpdGggb3JkZXJlZCBkYXRhIG1vZGUuIE9wdHM6IChudWxsKQpbICAgMzYuMjQwMDY1XSBW
RlM6IE1vdW50ZWQgcm9vdCAoZXh0NCBmaWxlc3lzdGVtKSBvbiBkZXZpY2UgODoyLgpbICAgMzYu
MjQ5ODkxXSBkZXZ0bXBmczogbW91bnRlZApbICAgMzYuMjU0NDc1XSBGcmVlaW5nIHVudXNlZCBr
ZXJuZWwgbWVtb3J5OiA0MTYwSwpbICAgMzYuMjU5MDQ1XSBSdW4gL3NiaW4vaW5pdCBhcyBpbml0
IHByb2Nlc3MKWyAgIDM2LjQzNDAzOF0gc3lzdGVtZFsxXTogc3lzdGVtZCAyNDkuNysgcnVubmlu
ZyBpbiBzeXN0ZW0gbW9kZSAoLVBBTSAtQVVESVQgLVNFTElOVVggLUFQUEFSTU9SICtJTUEgLVNN
QUNLICtTRUNDT01QIC1HQ1JZUFQgLUdOVVRMUyAtT1BFTlNTTCArQUNMICtCTEtJRCAtQ1VSTCAt
RUxGVVRJTFMgLUZJRE8yIC1JRE4yIC1JRE4gLUlQVEMgK0tNT0QgLUxJQkNSWVBUU0VUVVAgK0xJ
QkZESVNLIC1QQ1JFMiAtUFdRVUFMSVRZIC1QMTFLSVQgLVFSRU5DT0RFIC1CWklQMiAtTFo0IC1Y
WiAtWkxJQiArWlNURCArWEtCQ09NTU9OICtVVE1QICtTWVNWSU5JVCBkZWZhdWx0LWhpZXJhcmNo
eT1oeWJyaWQpClsgICAzNi40NjQwNDhdIHN5c3RlbWRbMV06IERldGVjdGVkIGFyY2hpdGVjdHVy
ZSBhcm02NC4KCldlbGNvbWUgdG8gRVdBT0wgKEVkZ2UgV29ya2xvYWQgQWJzdHJhY3Rpb24gYW5k
IE9yY2hlc3RyYXRpb24gTGF5ZXIpIHVuc3RhYmxlIChob25pc3RlcikhCgpbICAgMzYuNTAzNzc2
XSBzeXN0ZW1kWzFdOiBIb3N0bmFtZSBzZXQgdG8gPGNvbWhwYz4uClsgICAzNi41NDU2NzBdIHN5
c3RlbWQtc3lzdi1nZW5lcmF0b3JbMTMwXTogU3lzViBzZXJ2aWNlICcvZXRjL2luaXQuZC9jb25u
dHJhY2tkJyBsYWNrcyBhIG5hdGl2ZSBzeXN0ZW1kIHVuaXQgZmlsZS4gQXV0b21hdGljYWxseSBn
ZW5lcmF0aW5nIGEgdW5pdCBmaWxlIGZvciBjb21wYXRpYmlsaXR5LiBQbGVhc2UgdXBkYXRlIHBh
Y2thZ2UgdG8gaW5jbHVkZSBhIG5hdGl2ZSBzeXN0ZW1kIHVuaXQgZmlsZSwgaW4gb3JkZXIgdG8g
bWFrZSBpdCBtb3JlIHNhZmUgYW5kIHJvYnVzdC4KWyAgIDM2LjU3MDI4MV0gc3lzdGVtZC1zeXN2
LWdlbmVyYXRvclsxMzBdOiBTeXNWIHNlcnZpY2UgJy9ldGMvaW5pdC5kL2Nvbm50cmFjay1mYWls
b3ZlcicgbGFja3MgYSBuYXRpdmUgc3lzdGVtZCB1bml0IGZpbGUuIEF1dG9tYXRpY2FsbHkgZ2Vu
ZXJhdGluZyBhIHVuaXQgZmlsZSBmb3IgY29tcGF0aWJpbGl0eS4gUGxlYXNlIHVwZGF0ZSBwYWNr
YWdlIHRvIGluY2x1ZGUgYSBuYXRpdmUgc3lzdGVtZCB1bml0IGZpbGUsIGluIG9yZGVyIHRvIG1h
a2UgaXQgbW9yZSBzYWZlIGFuZCByb2J1c3QuClsgICAzNi43MTEyMDhdIHN5c3RlbWRbMV06IC9s
aWIvc3lzdGVtZC9zeXN0ZW0veGVuLXFlbXUtZG9tMC1kaXNrLWJhY2tlbmQuc2VydmljZToxMTog
UElERmlsZT0gcmVmZXJlbmNlcyBhIHBhdGggYmVsb3cgbGVnYWN5IGRpcmVjdG9yeSAvdmFyL3J1
bi8sIHVwZGF0aW5nIC92YXIvcnVuL3hlbi9xZW11LWRvbTAucGlkIOKGkiAvcnVuL3hlbi9xZW11
LWRvbTAucGlkOyBwbGVhc2UgdXBkYXRlIHRoZSB1bml0IGZpbGUgYWNjb3JkaW5nbHkuClsgICAz
Ni43OTkxNzFdIHN5c3RlbWRbMV06IFF1ZXVlZCBzdGFydCBqb2IgZm9yIGRlZmF1bHQgdGFyZ2V0
IE11bHRpLVVzZXIgU3lzdGVtLgpbICAgMzYuODA2NzYyXSByYW5kb206IHN5c3RlbWQ6IHVuaW5p
dGlhbGl6ZWQgdXJhbmRvbSByZWFkICgxNiBieXRlcyByZWFkKQpbICAgMzYuODIwMDYzXSBzeXN0
ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vZ2V0dHkuClsgIE9LICBdIENyZWF0
ZWQgc2xpY2UgU2xpY2UgL3N5c3RlbS9nZXR0eS4KWyAgIDM2Ljg0MjQxMV0gcmFuZG9tOiBzeXN0
ZW1kOiB1bmluaXRpYWxpemVkIHVyYW5kb20gcmVhZCAoMTYgYnl0ZXMgcmVhZCkKWyAgIDM2Ljg0
OTYzMl0gc3lzdGVtZFsxXTogQ3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVtL21vZHByb2JlLgpb
ICBPSyAgXSBDcmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vbW9kcHJvYmUuClsgICAzNi44NzAz
ODVdIHJhbmRvbTogc3lzdGVtZDogdW5pbml0aWFsaXplZCB1cmFuZG9tIHJlYWQgKDE2IGJ5dGVz
IHJlYWQpClsgICAzNi44Nzc1NzFdIHN5c3RlbWRbMV06IENyZWF0ZWQgc2xpY2UgU2xpY2UgL3N5
c3RlbS9zZXJpYWwtZ2V0dHkuClsgIE9LICBdIENyZWF0ZWQgc2xpY2UgU2xpY2UgL3N5c3RlbS9z
ZXJpYWwtZ2V0dHkuClsgICAzNi44OTkxODddIHN5c3RlbWRbMV06IENyZWF0ZWQgc2xpY2UgVXNl
ciBhbmQgU2Vzc2lvbiBTbGljZS4KWyAgT0sgIF0gQ3JlYXRlZCBzbGljZSBVc2VyIGFuZCBTZXNz
aW9uIFNsaWNlLgpbICAgMzYuOTIyNTM5XSBzeXN0ZW1kWzFdOiBTdGFydGVkIERpc3BhdGNoIFBh
c3N3b3JkIFJlcXVlc3RzIHRvIENvbnNvbGUgRGlyZWN0b3J5IFdhdGNoLgpbICBPSyAgXSBTdGFy
dGVkIERpc3BhdGNoIFBhc3N3b3JkIOKApnRzIHRvIENvbnNvbGUgRGlyZWN0b3J5IFdhdGNoLgpb
ICAgMzYuOTQ2NTA1XSBzeXN0ZW1kWzFdOiBTdGFydGVkIEZvcndhcmQgUGFzc3dvcmQgUmVxdWVz
dHMgdG8gV2FsbCBEaXJlY3RvcnkgV2F0Y2guClsgIE9LICBdIFN0YXJ0ZWQgRm9yd2FyZCBQYXNz
d29yZCBS4oCmdWVzdHMgdG8gV2FsbCBEaXJlY3RvcnkgV2F0Y2guClsgICAzNi45NzA1MzJdIHN5
c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0IFBhdGggVW5pdHMuClsgIE9LICBdIFJlYWNoZWQgdGFy
Z2V0IFBhdGggVW5pdHMuClsgICAzNi45OTA0MTldIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0
IFJlbW90ZSBGaWxlIFN5c3RlbXMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFJlbW90ZSBGaWxl
IFN5c3RlbXMuClsgICAzNy4wMTAzNjVdIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0IFNsaWNl
IFVuaXRzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTbGljZSBVbml0cy4KWyAgIDM3LjAzMDM4
NF0gc3lzdGVtZFsxXTogUmVhY2hlZCB0YXJnZXQgU3dhcHMuClsgIE9LICBdIFJlYWNoZWQgdGFy
Z2V0IFN3YXBzLgpbICAgMzcuMDU3MTAwXSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gUlBDYmlu
ZCBTZXJ2ZXIgQWN0aXZhdGlvbiBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiBSUENiaW5k
IFNlcnZlciBBY3RpdmF0aW9uIFNvY2tldC4KWyAgIDM3LjA3ODM5OV0gc3lzdGVtZFsxXTogUmVh
Y2hlZCB0YXJnZXQgUlBDIFBvcnQgTWFwcGVyLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBSUEMg
UG9ydCBNYXBwZXIuClsgICAzNy4wOTg1OTNdIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBTeXNs
b2cgU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gU3lzbG9nIFNvY2tldC4KWyAgIDM3LjEx
ODQ2M10gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIGluaXRjdGwgQ29tcGF0aWJpbGl0eSBOYW1l
ZCBQaXBlLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gaW5pdGN0bCBDb21wYXRpYmlsaXR5IE5hbWVk
IFBpcGUuClsgICAzNy4xNDMyNjVdIHN5c3RlbWRbMV06IENvbmRpdGlvbiBjaGVjayByZXN1bHRl
ZCBpbiBKb3VybmFsIEF1ZGl0IFNvY2tldCBiZWluZyBza2lwcGVkLgpbICAgMzcuMTUxNDE3XSBz
eXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gSm91cm5hbCBTb2NrZXQgKC9kZXYvbG9nKS4KWyAgT0sg
IF0gTGlzdGVuaW5nIG9uIEpvdXJuYWwgU29ja2V0ICgvZGV2L2xvZykuClsgICAzNy4xNzQ1NTNd
IHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBKb3VybmFsIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVu
aW5nIG9uIEpvdXJuYWwgU29ja2V0LgpbICAgMzcuMTk0NjYzXSBzeXN0ZW1kWzFdOiBMaXN0ZW5p
bmcgb24gTmV0d29yayBTZXJ2aWNlIE5ldGxpbmsgU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcg
b24gTmV0d29yayBTZXJ2aWNlIE5ldGxpbmsgU29ja2V0LgpbICAgMzcuMjE0NTkxXSBzeXN0ZW1k
WzFdOiBMaXN0ZW5pbmcgb24gdWRldiBDb250cm9sIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5n
IG9uIHVkZXYgQ29udHJvbCBTb2NrZXQuClsgICAzNy4yMzQ1NTNdIHN5c3RlbWRbMV06IExpc3Rl
bmluZyBvbiB1ZGV2IEtlcm5lbCBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiB1ZGV2IEtl
cm5lbCBTb2NrZXQuClsgICAzNy4yNTQ1NjFdIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBVc2Vy
IERhdGFiYXNlIE1hbmFnZXIgU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gVXNlciBEYXRh
YmFzZSBNYW5hZ2VyIFNvY2tldC4KWyAgIDM3LjI3NTcxMl0gc3lzdGVtZFsxXTogTW91bnRpbmcg
SHVnZSBQYWdlcyBGaWxlIFN5c3RlbS4uLgogICAgICAgICBNb3VudGluZyBIdWdlIFBhZ2VzIEZp
bGUgU3lzdGVtLi4uClsgICAzNy4yOTU3MzldIHN5c3RlbWRbMV06IE1vdW50aW5nIFBPU0lYIE1l
c3NhZ2UgUXVldWUgRmlsZSBTeXN0ZW0uLi4KICAgICAgICAgTW91bnRpbmcgUE9TSVggTWVzc2Fn
ZSBRdWV1ZSBGaWxlIFN5c3RlbS4uLgpbICAgMzcuMzE4NDU4XSBzeXN0ZW1kWzFdOiBDb25kaXRp
b24gY2hlY2sgcmVzdWx0ZWQgaW4gTW91bnQgL3Byb2MveGVuIGZpbGVzIGJlaW5nIHNraXBwZWQu
ClsgICAzNy4zMjc1NTddIHN5c3RlbWRbMV06IE1vdW50aW5nIEtlcm5lbCBEZWJ1ZyBGaWxlIFN5
c3RlbS4uLgogICAgICAgICBNb3VudGluZyBLZXJuZWwgRGVidWcgRmlsZSBTeXN0ZW0uLi4KWyAg
IDM3LjM0NzcyMV0gc3lzdGVtZFsxXTogTW91bnRpbmcgS2VybmVsIFRyYWNlIEZpbGUgU3lzdGVt
Li4uCiAgICAgICAgIE1vdW50aW5nIEtlcm5lbCBUcmFjZSBGaWxlIFN5c3RlbS4uLgpbICAgMzcu
MzY4NzgwXSBzeXN0ZW1kWzFdOiBNb3VudGluZyBUZW1wb3JhcnkgRGlyZWN0b3J5IC90bXAuLi4K
ICAgICAgICAgTW91bnRpbmcgVGVtcG9yYXJ5IERpcmVjdG9yeSAvdG1wLi4uClsgICAzNy4zOTA2
MTNdIHN5c3RlbWRbMV06IENvbmRpdGlvbiBjaGVjayByZXN1bHRlZCBpbiBDcmVhdGUgTGlzdCBv
ZiBTdGF0aWMgRGV2aWNlIE5vZGVzIGJlaW5nIHNraXBwZWQuClsgICAzNy40MDA3ODRdIHN5c3Rl
bWRbMV06IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBjb25maWdmcy4uLgogICAgICAgICBT
dGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgY29uZmlnZnMuLi4KWyAgIDM3LjQyMzY0MF0gc3lz
dGVtZFsxXTogU3RhcnRpbmcgTG9hZCBLZXJuZWwgTW9kdWxlIGRybS4uLgogICAgICAgICBTdGFy
dGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgZHJtLi4uClsgICAzNy40NDM2MDldIHN5c3RlbWRbMV06
IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBmdXNlLi4uCiAgICAgICAgIFN0YXJ0aW5nIExv
YWQgS2VybmVsIE1vZHVsZSBmdXNlLi4uClsgICAzNy40NjM3NzhdIHN5c3RlbWRbMV06IFN0YXJ0
aW5nIFJQQyBCaW5kLi4uCiAgICAgICAgIFN0YXJ0aW5nIFJQQyBCaW5kLi4uClsgICAzNy40Nzgy
NzNdIHN5c3RlbWRbMV06IENvbmRpdGlvbiBjaGVjayByZXN1bHRlZCBpbiBGaWxlIFN5c3RlbSBD
aGVjayBvbiBSb290IERldmljZSBiZWluZyBza2lwcGVkLgpbICAgMzcuNDkwMTEwXSBzeXN0ZW1k
WzFdOiBTdGFydGluZyBKb3VybmFsIFNlcnZpY2UuLi4KICAgICAgICAgU3RhcnRpbmcgSm91cm5h
bCBTZXJ2aWNlLi4uClsgICAzNy41MTMzMTJdIHN5c3RlbWRbMV06IFN0YXJ0aW5nIExvYWQgS2Vy
bmVsIE1vZHVsZXMuLi4KICAgICAgICAgU3RhcnRpbmcgTG9hZCBLZXJuZWwgTW9kdWxlcy4uLgpb
ICAgMzcuNTMwNjkyXSBzeXN0ZW1kWzFdOiBTdGFydGluZyBSZW1vdW50IFJvb3QgYW5kIEtlcm5l
bCBGaWxlIFN5c3RlbXMuLi4KICAgICAgICAgU3RhcnRpbmcgUmVtb3VudCBSb290IGFuZCBLZXJu
ZWwgRmlsZSBTeXN0ZW1zLi4uClsgICAzNy41NDg2MDZdIEVYVDQtZnMgKHNkYTIpOiByZS1tb3Vu
dGVkLiBPcHRzOiAobnVsbCkKWyAgIDM3LjU1OTM0NV0gc3lzdGVtZFsxXTogU3RhcnRpbmcgQ29s
ZHBsdWcgQWxsIHVkZXYgRGV2aWNlcy4uLgogICAgICAgICBTdGFydGluZyBDb2xkcGx1ZyBBbGwg
dWRldiBEZXZpY2VzLi4uClsgICAzNy41ODM5ODVdIHN5c3RlbWRbMV06IFN0YXJ0ZWQgUlBDIEJp
bmQuClsgIE9LICBdIFN0YXJ0ZWQgUlBDIEJpbmQuClsgICAzNy42MDIzNzldIHN5c3RlbWRbMV06
IE1vdW50ZWQgSHVnZSBQYWdlcyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91bnRlZCBIdWdlIFBh
Z2VzIEZpbGUgU3lzdGVtLgpbICAgMzcuNjMwMzk3XSBzeXN0ZW1kWzFdOiBNb3VudGVkIFBPU0lY
IE1lc3NhZ2UgUXVldWUgRmlsZSBTeXN0ZW0uClsgIE9LICBdIE1vdW50ZWQgUE9TSVggTWVzc2Fn
ZSBRdWV1ZSBGaWxlIFN5c3RlbS4KWyAgIDM3LjY1ODM1Nl0gc3lzdGVtZFsxXTogTW91bnRlZCBL
ZXJuZWwgRGVidWcgRmlsZSBTeXN0ZW0uClsgIE9LICBdIE1vdW50ZWQgS2VybmVsIERlYnVnIEZp
bGUgU3lzdGVtLgpbICAgMzcuNjg2NTQ0XSBzeXN0ZW1kWzFdOiBTdGFydGVkIEpvdXJuYWwgU2Vy
dmljZS4KWyAgT0sgIF0gU3RhcnRlZCBKb3VybmFsIFNlcnZpY2UuClsgIE9LICBdIE1vdW50ZWQg
S2VybmVsIFRyYWNlIEZpbGUgU3lzdGVtLgpbICBPSyAgXSBNb3VudGVkIFRlbXBvcmFyeSBEaXJl
Y3RvcnkgL3RtcC4KWyAgT0sgIF0gRmluaXNoZWQgTG9hZCBLZXJuZWwgTW9kdWxlIGNvbmZpZ2Zz
LgpbICBPSyAgXSBGaW5pc2hlZCBMb2FkIEtlcm5lbCBNb2R1bGUgZHJtLgpbICBPSyAgXSBGaW5p
c2hlZCBMb2FkIEtlcm5lbCBNb2R1bGUgZnVzZS4KW0ZBSUxFRF0gRmFpbGVkIHRvIHN0YXJ0IExv
YWQgS2VybmVsIE1vZHVsZXMuClNlZSAnc3lzdGVtY3RsIHN0YXR1cyBzeXN0ZW1kLW1vZHVsZXMt
bG9hZC5zZXJ2aWNlJyBmb3IgZGV0YWlscy4KWyAgT0sgIF0gRmluaXNoZWQgUmVtb3VudCBSb290
IGFuZCBLZXJuZWwgRmlsZSBTeXN0ZW1zLgogICAgICAgICBNb3VudGluZyBLZXJuZWwgQ29uZmln
dXJhdGlvbiBGaWxlIFN5c3RlbS4uLgogICAgICAgICBTdGFydGluZyBGbHVzaCBKb3VybmFsIHRv
IFBlcnNpc3RlbnQgU3RvcmFnZS4uLgpbICAgMzcuODYxNTc2XSBzeXN0ZW1kLWpvdXJuYWxkWzE0
NV06IFJlY2VpdmVkIGNsaWVudCByZXF1ZXN0IHRvIGZsdXNoIHJ1bnRpbWUgam91cm5hbC4KICAg
ICAgICAgU3RhcnRpbmcgQXBwbHkgS2VybmVsIFZhcmlhYmxlcy4uLgogICAgICAgICBTdGFydGlu
ZyBDcmVhdGUgU3RhdGljIERldmljZSBOb2RlcyBpbiAvZGV2Li4uClsgIE9LICBdIE1vdW50ZWQg
S2VybmVsIENvbmZpZ3VyYXRpb24gRmlsZSBTeXN0ZW0uClsgIE9LICBdIEZpbmlzaGVkIEZsdXNo
IEpvdXJuYWwgdG8gUGVyc2lzdGVudCBTdG9yYWdlLgpbICBPSyAgXSBGaW5pc2hlZCBBcHBseSBL
ZXJuZWwgVmFyaWFibGVzLgpbICBPSyAgXSBGaW5pc2hlZCBDcmVhdGUgU3RhdGljIERldmljZSBO
b2RlcyBpbiAvZGV2LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBQcmVwYXJhdGlvbiBmb3IgTG9j
YWwgRmlsZSBTeXN0ZW1zLgogICAgICAgICBNb3VudGluZyAvdmFyL3ZvbGF0aWxlLi4uCiAgICAg
ICAgIFN0YXJ0aW5nIFJ1bGUtYmFzZWQgTWFuYWdl4oCmZm9yIERldmljZSBFdmVudHMgYW5kIEZp
bGVzLi4uClsgIE9LICBdIEZpbmlzaGVkIENvbGRwbHVnIEFsbCB1ZGV2IERldmljZXMuClsgIE9L
ICBdIE1vdW50ZWQgL3Zhci92b2xhdGlsZS4KWyAgT0sgIF0gU3RhcnRlZCBSdWxlLWJhc2VkIE1h
bmFnZXIgZm9yIERldmljZSBFdmVudHMgYW5kIEZpbGVzLgogICAgICAgICBTdGFydGluZyBXYWl0
IGZvciB1ZGV2IFRvIOKApnBsZXRlIERldmljZSBJbml0aWFsaXphdGlvbi4uLgogICAgICAgICBT
dGFydGluZyBMb2FkL1NhdmUgUmFuZG9tIFNlZWQuLi4KWyAgT0sgIF0gRm91bmQgZGV2aWNlIFNh
bkRpc2tfMy4yR2VuMSBtc2Rvcy4KICAgICAgICAgTW91bnRpbmcgL2Jvb3QuLi4KWyAgT0sgIF0g
TW91bnRlZCAvYm9vdC4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgTG9jYWwgRmlsZSBTeXN0ZW1z
LgogICAgICAgICBTdGFydGluZyBDcmVhdGUgVm9sYXRpbGUgRmlsZXMgYW5kIERpcmVjdG9yaWVz
Li4uClsgIE9LICBdIEZpbmlzaGVkIENyZWF0ZSBWb2xhdGlsZSBGaWxlcyBhbmQgRGlyZWN0b3Jp
ZXMuCiAgICAgICAgIFN0YXJ0aW5nIE5ldHdvcmsgVGltZSBTeW5jaHJvbml6YXRpb24uLi4KICAg
ICAgICAgU3RhcnRpbmcgUmVjb3JkIFN5c3RlbSBCb290L1NodXRkb3duIGluIFVUTVAuLi4KWyAg
T0sgIF0gRmluaXNoZWQgUmVjb3JkIFN5c3RlbSBCb290L1NodXRkb3duIGluIFVUTVAuClsgIE9L
ICBdIExpc3RlbmluZyBvbiBMb2FkL1NhdmUgUkYg4oCmaXRjaCBTdGF0dXMgL2Rldi9yZmtpbGwg
V2F0Y2guClsgIE9LICBdIFN0YXJ0ZWQgTmV0d29yayBUaW1lIFN5bmNocm9uaXphdGlvbi4KWyAg
T0sgIF0gUmVhY2hlZCB0YXJnZXQgU3lzdGVtIFRpbWUgU2V0LgpbICBPSyAgXSBGaW5pc2hlZCBX
YWl0IGZvciB1ZGV2IFRvIENvbXBsZXRlIERldmljZSBJbml0aWFsaXphdGlvbi4KWyAgT0sgIF0g
U3RhcnRlZCBIYXJkd2FyZSBSTkcgRW50cm9weSBHYXRoZXJlciBEYWVtb24uClsgIE9LICBdIFJl
YWNoZWQgdGFyZ2V0IFN5c3RlbSBJbml0aWFsaXphdGlvbi4KWyAgT0sgIF0gU3RhcnRlZCBEYWls
eSBDbGVhbnVwIG9mIFRlbXBvcmFyeSBEaXJlY3Rvcmllcy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJn
ZXQgVGltZXIgVW5pdHMuClsgIE9LICBdIExpc3RlbmluZyBvbiBBdmFoaSBtRE5TL0ROUy1TRCBT
dGFjayBBY3RpdmF0aW9uIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIEQtQnVzIFN5c3Rl
bSBNZXNzYWdlIEJ1cyBTb2NrZXQuCiAgICAgICAgIFN0YXJ0aW5nIERvY2tlciBTb2NrZXQgZm9y
IHRoZSBBUEkuLi4KICAgICAgICAgU3RhcnRpbmcgc3NoZC5zb2NrZXQuLi4KWyAgT0sgIF0gRmlu
aXNoZWQgTG9hZC9TYXZlIFJhbmRvbSBTZWVkLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gRG9ja2Vy
IFNvY2tldCBmb3IgdGhlIEFQSS4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIHNzaGQuc29ja2V0Lgpb
ICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTb2NrZXQgVW5pdHMuClsgIE9LICBdIFJlYWNoZWQgdGFy
Z2V0IEJhc2ljIFN5c3RlbS4KICAgICAgICAgU3RhcnRpbmcgQUNQSSBFdmVudCBEYWVtb24uLi4K
WyAgT0sgIF0gU3RhcnRlZCBLZXJuZWwgTG9nZ2luZyBTZXJ2aWNlLgpbICBPSyAgXSBTdGFydGVk
IFN5c3RlbSBMb2dnaW5nIFNlcnZpY2UuClsgIE9LICBdIFN0YXJ0ZWQgRC1CdXMgU3lzdGVtIE1l
c3NhZ2UgQnVzLgpbICBPSyAgXSBTdGFydGVkIEdldHR5IG9uIHR0eTEuCiAgICAgICAgIFN0YXJ0
aW5nIElQdjYgUGFja2V0IEZpbHRlcmluZyBGcmFtZXdvcmsuLi4KICAgICAgICAgU3RhcnRpbmcg
SVB2NCBQYWNrZXQgRmlsdGVyaW5nIEZyYW1ld29yay4uLgogICAgICAgICBTdGFydGluZyBUZWxl
cGhvbnkgc2VydmljZS4uLgpbICBPSyAgXSBTdGFydGVkIFNlcmlhbCBHZXR0eSBvbiB0dHlBTUEw
LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBMb2dpbiBQcm9tcHRzLgogICAgICAgICBTdGFydGlu
ZyBVc2VyIExvZ2luIE1hbmFnZW1lbnQuLi4KICAgICAgICAgU3RhcnRpbmcgT3BlblNTSCBLZXkg
R2VuZXJhdGlvbi4uLgpbICBPSyAgXSBTdGFydGVkIEFDUEkgRXZlbnQgRGFlbW9uLgpbICBPSyAg
XSBGaW5pc2hlZCBJUHY2IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3JrLgpbICBPSyAgXSBGaW5p
c2hlZCBJUHY0IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3JrLgpbICBPSyAgXSBGaW5pc2hlZCBP
cGVuU1NIIEtleSBHZW5lcmF0aW9uLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBQcmVwYXJhdGlv
biBmb3IgTmV0d29yay4KICAgICAgICAgU3RhcnRpbmcgTmV0d29yayBDb25maWd1cmF0aW9uLi4u
ClsgIE9LICBdIFN0YXJ0ZWQgVGVsZXBob255IHNlcnZpY2UuClsgIE9LICBdIFN0YXJ0ZWQgVXNl
ciBMb2dpbiBNYW5hZ2VtZW50LgpbICBPSyAgXSBTdGFydGVkIE5ldHdvcmsgQ29uZmlndXJhdGlv
bi4KICAgICAgICAgU3RhcnRpbmcgV2FpdCBmb3IgTmV0d29yayB0byBiZSBDb25maWd1cmVkLi4u
CiAgICAgICAgIFN0YXJ0aW5nIE5ldHdvcmsgTmFtZSBSZXNvbHV0aW9uLi4uClsgIE9LICBdIFN0
YXJ0ZWQgTmV0d29yayBOYW1lIFJlc29sdXRpb24uClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IE5l
dHdvcmsuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEhvc3QgYW5kIE5ldHdvcmsgTmFtZSBMb29r
dXBzLgogICAgICAgICBTdGFydGluZyBBdmFoaSBtRE5TL0ROUy1TRCBTdGFjay4uLgogICAgICAg
ICBTdGFydGluZyBjb250YWluZXJkIGNvbnRhaW5lciBydW50aW1lLi4uClsgIE9LICBdIFN0YXJ0
ZWQgQXZhaGkgbUROUy9ETlMtU0QgU3RhY2suClsgIE9LICBdIFN0YXJ0ZWQgY29udGFpbmVyZCBj
b250YWluZXIgcnVudGltZS4KCkVXQU9MIChFZGdlIFdvcmtsb2FkIEFic3RyYWN0aW9uIGFuZCBP
cmNoZXN0cmF0aW9uIExheWVyKSB1bnN0YWJsZSBjb21ocGMgdHR5QU1BMAoKY29taHBjIGxvZ2lu
OiAKY29taHBjIGxvZ2luOiAKY29taHBjIGxvZ2luOiByb290CnJvb3RAY29taHBjOn4jIAo=

--_007_5C7EC3F4912646E8932160878357F939armcom_
Content-Type: application/octet-stream; name="native_linux_boot_debug.log"
Content-Description: native_linux_boot_debug.log
Content-Disposition: attachment; filename="native_linux_boot_debug.log";
	size=383930; creation-date="Wed, 20 Apr 2022 11:05:02 GMT";
	modification-date="Wed, 20 Apr 2022 11:05:02 GMT"
Content-ID: <76713267F2062747BE71F1B93D44BB4F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogV2VkIEFwciAyMCAxMTo0MTo0MyBvbiB0dHlzMDAwCnJhaHNpbjAxQEMwMlpY
MEc5TFZETiB+ICUgdGVsbmV0IGUxMjMzNDMuY2FtYnJpZGdlLmFybS5jb20gMTAwMjAKVHJ5aW5n
IDEwLjEuMTk0LjI1Li4uCkNvbm5lY3RlZCB0byBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29tLgpF
c2NhcGUgY2hhcmFjdGVyIGlzICdeXScuCgpBSVMgdGFyZ2V0IHN5c3RlbSBwb3J0IDEwMDIwIGRl
dmljZSAvZGV2L3R0eVVTQjEgWzExNTIwMCBOODFdCgoKRlMwOlxFRklcQk9PVFw+IApGUzA6XEVG
SVxCT09UXD4gCkZTMDpcRUZJXEJPT1RcPiBib290YWE2NC5lZmkKV2VsY29tZSB0byBHUlVCIQoK
ZXJyb3I6IG5vIHN1Y2ggZGV2aWNlOiAoKGhkMCxncHQxKS9FRkkvQk9PVCkvRUZJL0JPT1QvZ3J1
Yi5jZmcuCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBHTlUgR1JVQiAgdmVyc2lvbiAyLjA2CgogLy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS1cCiB8IFBBUlRV
VUlEIEJvb3Q6IENPTS1IUEMgWW9jdG8gSW1hZ2UgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHwgCiB8IE5WTWUgTS4yICBTU0QgQm9vdDogQ09NLUhQQyBZb2N0byBJbWFn
ZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwqVVNCIEJvb3QgKElmIERy
aXZlIGlzIHByZXNlbnQpOiBDT00tSFBDIFlvY3RvIEltYWdlICAgICAgICAgICAgICAgICAgICAg
ICAgfAogfCBDT00tSFBDIFlvY3RvIEltYWdlIChYZW4pICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKIHwgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CiB8ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHwKIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAogfCAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB8IAogXC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0vCgogICAgICBVc2UgdGhlIF4gYW5kIHYga2V5
cyB0byBzZWxlY3Qgd2hpY2ggZW50cnkgaXMgaGlnaGxpZ2h0ZWQuICAgICAgICAgIAogICAgICBQ
cmVzcyBlbnRlciB0byBib290IHRoZSBzZWxlY3RlZCBPUywgYGUnIHRvIGVkaXQgdGhlIGNvbW1h
bmRzICAgICAgIAogICAgICBiZWZvcmUgYm9vdGluZyBvciBgYycgZm9yIGEgY29tbWFuZC1saW5l
LiAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoK
CgoKCgoKCgoKCgpFRkkgc3R1YjogQm9vdGluZyBMaW51eCBLZXJuZWwuLi4KRUZJIHN0dWI6IFVz
aW5nIERUQiBmcm9tIGNvbmZpZ3VyYXRpb24gdGFibGUKRUZJIHN0dWI6IEV4aXRpbmcgYm9vdCBz
ZXJ2aWNlcyBhbmQgaW5zdGFsbGluZyB2aXJ0dWFsIGFkZHJlc3MgbWFwLi4uClBST0dSRVNTIENP
REU6IFYwMzEwMTAxOSBJMApbICAgIDAuMDAwMDAwXSBCb290aW5nIExpbnV4IG9uIHBoeXNpY2Fs
IENQVSAweDAwMDAxMDAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDAwMDBdIExpbnV4IHZlcnNp
b24gNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAob2UtdXNlckBvZS1ob3N0KSAoYWFyY2g2
NC1wb2t5LWxpbnV4LWdjYyAoR0NDKSAxMS4yLjAsIEdOVSBsZCAoR05VIEJpbnV0aWxzKSAyLjM3
LjIwMjEwNzIxKSAjMSBTTVAgUFJFRU1QVCBTYXQgU2VwIDE4IDA2OjAxOjU5IFVUQyAyMDIxClsg
ICAgMC4wMDAwMDBdIGVmaTogRUZJIHYyLjcwIGJ5IEVESyBJSQpbICAgIDAuMDAwMDAwXSBlZmk6
IFRQTUZpbmFsTG9nPTB4ODA3ZjllZjAwMDAgQUNQSSAyLjA9MHg4MDdmYTBkMDAxOCBTTUJJT1Mg
My4wPTB4ODA3ZjhlMzAwMDAgTUVNQVRUUj0weDgwN2Y2Yjg1MDE4IEVTUlQ9MHg4MDdmODAzYjM5
OCBUUE1FdmVudExvZz0weDgwN2Y2Yjg5MDE4IFJORz0weGZmYjRiYTk4IE1FTVJFU0VSVkU9MHg4
MDdmN2VjM2U5OCAKWyAgICAwLjAwMDAwMF0gZWZpOiBzZWVkaW5nIGVudHJvcHkgcG9vbApbICAg
IDAuMDAwMDAwXSBlc3J0OiBSZXNlcnZpbmcgRVNSVCBzcGFjZSBmcm9tIDB4MDAwMDA4MDdmODAz
YjM5OCB0byAweDAwMDAwODA3ZjgwM2IzZDAuClsgICAgMC4wMDAwMDBdIEFDUEk6IEVhcmx5IHRh
YmxlIGNoZWNrc3VtIHZlcmlmaWNhdGlvbiBkaXNhYmxlZApbICAgIDAuMDAwMDAwXSBBQ1BJOiBS
U0RQIDB4MDAwMDA4MDdGQTBEMDAxOCAwMDAwMjQgKHYwMiBBbXBlcmUpClsgICAgMC4wMDAwMDBd
IEFDUEk6IFhTRFQgMHgwMDAwMDgwN0ZBMERGRTk4IDAwMDBBNCAodjAxIEFtcGVyZSBBbHRyYSAg
ICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBGQUNQIDB4MDAw
MDA4MDdGQTBERkI5OCAwMDAxMTQgKHYwNiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAw
MTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogRFNEVCAweDAwMDAwODA3RjhEQjAwMTggMDJD
MTlFICh2MDIgQW1wZXJlIEphZGUgICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpClsgICAgMC4w
MDAwMDBdIEFDUEk6IEJFUlQgMHgwMDAwMDgwN0ZBMERGRjk4IDAwMDAzMCAodjAxIEFtcGVyZSBB
bHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBEQkcy
IDB4MDAwMDA4MDdGQTBERkE5OCAwMDAwNUMgKHYwMCBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIg
QU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogR1REVCAweDAwMDAwODA3RkEwREU5
OTggMDAwMTEwICh2MDMgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpClsg
ICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1IgMHgwMDAwMDgwN0ZBMERGRTE4IDAwMDA1MCAodjAyIEFt
cGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBFSU5KIDB4MDAwMDA4MDdGQTBERjU5OCAwMDAxNTAgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAw
MDAwMDEgSU5UTCAyMDIwMTIxNykKWyAgICAwLjAwMDAwMF0gQUNQSTogSEVTVCAweDAwMDAwODA3
RkEwREVCMTggMDAwMUY0ICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIElOVEwgMjAyMDEy
MTcpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNTRFQgMHgwMDAwMDgwN0ZBMERGQTE4IDAwMDAyRCAo
djAyIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAxMjE3KQpbICAgIDAuMDAwMDAw
XSBBQ1BJOiBUUE0yIDB4MDAwMDA4MDdGQTBERkQxOCAwMDAwNEMgKHYwNCBBbXBlcmUgQWx0cmEg
ICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogTUNGRyAweDAw
MDAwODA3RkEwREY3MTggMDAwMDdDICh2MDEgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAxIEFNUC4g
MDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IElPUlQgMHgwMDAwMDgwN0ZBMERFRjE4IDAw
MDNEQyAodjAwIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBBUElDIDB4MDAwMDA4MDdGQTBENzUxOCAwMDBBRjQgKHYwNSBBbXBlcmUg
QWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQSTogUFBU
VCAweDAwMDAwODA3RkEwRDg2MTggMDA0NTIwICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAy
IEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNMSVQgMHgwMDAwMDgwN0ZBMERG
RDk4IDAwMDAyRCAodjAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQpb
ICAgIDAuMDAwMDAwXSBBQ1BJOiBTUkFUIDB4MDAwMDA4MDdGQTBEQ0UxOCAwMDAzNzAgKHYwMyBB
bXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykKWyAgICAwLjAwMDAwMF0gQUNQ
STogUENDVCAweDAwMDAwODA3RkEwREUzMTggMDAwNTc2ICh2MDIgQW1wZXJlIEFsdHJhICAgIDAw
MDAwMDAyIEFNUC4gMDEwMDAwMTMpClsgICAgMC4wMDAwMDBdIEFDUEk6IFNQQ1I6IGNvbnNvbGU6
IHBsMDExLG1taW8zMiwweDEwMDAwMjYwMDAwMCwxMTUyMDAKWyAgICAwLjAwMDAwMF0gQUNQSTog
U1JBVDogTm9kZSAwIFBYTSAwIFttZW0gMHg4ODMwMDAwMC0weDg4M2ZmZmZmXQpbICAgIDAuMDAw
MDAwXSBBQ1BJOiBTUkFUOiBOb2RlIDAgUFhNIDAgW21lbSAweDkwMDAwMDAwLTB4ZmZmZmZmZmZd
ClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODAwMDAwMDAw
MDAtMHg4MDA3ZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gQUNQSTogU1JBVDogTm9kZSAwIFBYTSAw
IFttZW0gMHg4MDEwMDAwMDAwMC0weDgwN2ZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSBOVU1BOiBO
T0RFX0RBVEEgW21lbSAweDgwN2ZjMDZmZTAwLTB4ODA3ZmMwNzFmZmZdClsgICAgMC4wMDAwMDBd
IFpvbmUgcmFuZ2VzOgpbICAgIDAuMDAwMDAwXSAgIERNQSAgICAgIFttZW0gMHgwMDAwMDAwMDg4
MzAwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBETUEzMiAgICBlbXB0
eQpbICAgIDAuMDAwMDAwXSAgIE5vcm1hbCAgIFttZW0gMHgwMDAwMDAwMTAwMDAwMDAwLTB4MDAw
MDA4MDdmZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gTW92YWJsZSB6b25lIHN0YXJ0IGZvciBlYWNo
IG5vZGUKWyAgICAwLjAwMDAwMF0gRWFybHkgbWVtb3J5IG5vZGUgcmFuZ2VzClsgICAgMC4wMDAw
MDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMDg4MzAwMDAwLTB4MDAwMDAwMDA4ODNmZmZm
Zl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwOTAwMDAwMDAtMHgw
MDAwMDAwMDkxZmZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAw
MDA5MjAwMDAwMC0weDAwMDAwMDAwOTI3YmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6
IFttZW0gMHgwMDAwMDAwMDkyN2MwMDAwLTB4MDAwMDAwMDBmZmIzZmZmZl0KWyAgICAwLjAwMDAw
MF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwZmZiNDAwMDAtMHgwMDAwMDAwMGZmYjRmZmZm
XQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDAwMDBmZmI1MDAwMC0weDAw
MDAwMDAwZmZmZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgw
MDAwMDAwMDAwLTB4MDAwMDA4MDA3ZmZmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDog
W21lbSAweDAwMDAwODAxMDAwMDAwMDAtMHgwMDAwMDgwN2Y2YjlmZmZmXQpbICAgIDAuMDAwMDAw
XSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmNmJhMDAwMC0weDAwMDAwODA3ZjZjM2ZmZmZd
ClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y2YzQwMDAwLTB4MDAw
MDA4MDdmNmQzMWZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3
ZjZkMzIwMDAtMHgwMDAwMDgwN2Y3M2RhZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBb
bWVtIDB4MDAwMDA4MDdmNzNkYjAwMC0weDAwMDAwODA3ZjdlN2ZmZmZdClsgICAgMC4wMDAwMDBd
ICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y3ZTgwMDAwLTB4MDAwMDA4MDdmN2U5ZmZmZl0K
WyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjdlYTAwMDAtMHgwMDAw
MDgwN2Y3ZWZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdm
N2YwMDAwMC0weDAwMDAwODA3ZjdmM2ZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFtt
ZW0gMHgwMDAwMDgwN2Y3ZjQwMDAwLTB4MDAwMDA4MDdmODdlZmZmZl0KWyAgICAwLjAwMDAwMF0g
ICBub2RlICAgMDogW21lbSAweDAwMDAwODA3Zjg3ZjAwMDAtMHgwMDAwMDgwN2Y4ODJmZmZmXQpb
ICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmODgzMDAwMC0weDAwMDAw
ODA3ZjhhNmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4
YTcwMDAwLTB4MDAwMDA4MDdmOGFhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21l
bSAweDAwMDAwODA3ZjhhYjAwMDAtMHgwMDAwMDgwN2Y4ZTFmZmZmXQpbICAgIDAuMDAwMDAwXSAg
IG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOGUyMDAwMC0weDAwMDAwODA3ZjhlM2ZmZmZdClsg
ICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y4ZTQwMDAwLTB4MDAwMDA4
MDdmOGU2ZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3Zjhl
NzAwMDAtMHgwMDAwMDgwN2Y5ZTdmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVt
IDB4MDAwMDA4MDdmOWU4MDAwMC0weDAwMDAwODA3ZjllZWZmZmZdClsgICAgMC4wMDAwMDBdICAg
bm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y5ZWYwMDAwLTB4MDAwMDA4MDdmOWYxZmZmZl0KWyAg
ICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZjlmMjAwMDAtMHgwMDAwMDgw
N2Y5ZmJmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmOWZj
MDAwMC0weDAwMDAwODA3ZjlmZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0g
MHgwMDAwMDgwN2ZhMDAwMDAwLTB4MDAwMDA4MDdmYTBmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBu
b2RlICAgMDogW21lbSAweDAwMDAwODA3ZmExMDAwMDAtMHgwMDAwMDgwN2ZhMTlmZmZmXQpbICAg
IDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTFhMDAwMC0weDAwMDAwODA3
ZmEyNmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhMjcw
MDAwLTB4MDAwMDA4MDdmYTRhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAw
eDAwMDAwODA3ZmE0YjAwMDAtMHgwMDAwMDgwN2ZhNzFmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5v
ZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYTcyMDAwMC0weDAwMDAwODA3ZmE3NWZmZmZdClsgICAg
MC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhNzYwMDAwLTB4MDAwMDA4MDdm
YThjZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmE4ZDAw
MDAtMHgwMDAwMDgwN2ZhOTZmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4
MDAwMDA4MDdmYTk3MDAwMC0weDAwMDAwODA3ZmE5ZmZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9k
ZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhYTAwMDAwLTB4MDAwMDA4MDdmYmFhZmZmZl0KWyAgICAw
LjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwODA3ZmJhYjAwMDAtMHgwMDAwMDgwN2Zi
YjNmZmZmXQpbICAgIDAuMDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmI0MDAw
MC0weDAwMDAwODA3ZmJiZGZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgw
MDAwMDgwN2ZiYmUwMDAwLTB4MDAwMDA4MDdmYmNhZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2Rl
ICAgMDogW21lbSAweDAwMDAwODA3ZmJjYjAwMDAtMHgwMDAwMDgwN2ZiY2VmZmZmXQpbICAgIDAu
MDAwMDAwXSAgIG5vZGUgICAwOiBbbWVtIDB4MDAwMDA4MDdmYmNmMDAwMC0weDAwMDAwODA3ZmJk
NWZmZmZdClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZiZDYwMDAw
LTB4MDAwMDA4MDdmYmRmZmZmZl0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAw
MDAwODA3ZmJlMDAwMDAtMHgwMDAwMDgwN2ZmZmZmZmZmXQpbICAgIDAuMDAwMDAwXSBJbml0bWVt
IHNldHVwIG5vZGUgMCBbbWVtIDB4MDAwMDAwMDA4ODMwMDAwMC0weDAwMDAwODA3ZmZmZmZmZmZd
ClsgICAgMC4wMDAwMDBdIHBzY2k6IHByb2JpbmcgZm9yIGNvbmR1aXQgbWV0aG9kIGZyb20gQUNQ
SS4KWyAgICAwLjAwMDAwMF0gcHNjaTogUFNDSXYxLjEgZGV0ZWN0ZWQgaW4gZmlybXdhcmUuClsg
ICAgMC4wMDAwMDBdIHBzY2k6IFVzaW5nIHN0YW5kYXJkIFBTQ0kgdjAuMiBmdW5jdGlvbiBJRHMK
WyAgICAwLjAwMDAwMF0gcHNjaTogTUlHUkFURV9JTkZPX1RZUEUgbm90IHN1cHBvcnRlZC4KWyAg
ICAwLjAwMDAwMF0gcHNjaTogU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4yClsgICAgMC4wMDAw
MDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ODAwMDAgLT4gTm9kZSAwClsg
ICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ODAxMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
OTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+
IE1QSURSIDB4OTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6
IFBYTSAwIC0+IE1QSURSIDB4ZTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5V
TUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZTAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBd
IEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZjAwMDAgLT4gTm9kZSAwClsgICAg
MC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4ZjAxMDAgLT4gTm9k
ZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTAw
MDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBN
UElEUiAweDEwMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDog
UFhNIDAgLT4gTVBJRFIgMHgxMTAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5V
TUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTEwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAw
XSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE2MDAwMCAtPiBOb2RlIDAKWyAg
ICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxNjAxMDAgLT4g
Tm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4
MTcwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAt
PiBNUElEUiAweDE3MDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JB
VDogUFhNIDAgLT4gTVBJRFIgMHgxODAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6
IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MTgwMTAwIC0+IE5vZGUgMApbICAgIDAuMDAw
MDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDE5MDAwMCAtPiBOb2RlIDAK
WyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxOTAxMDAg
LT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURS
IDB4MWUwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0g
MCAtPiBNUElEUiAweDFlMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTog
U1JBVDogUFhNIDAgLT4gTVBJRFIgMHgxZjAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFD
UEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MWYwMTAwIC0+IE5vZGUgMApbICAgIDAu
MDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDIwMDAwMCAtPiBOb2Rl
IDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgyMDAx
MDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1Q
SURSIDB4MjEwMDAwIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQ
WE0gMCAtPiBNUElEUiAweDIxMDEwMCAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVN
QTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgyNjAwMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBd
IEFDUEk6IE5VTUE6IFNSQVQ6IFBYTSAwIC0+IE1QSURSIDB4MjYwMTAwIC0+IE5vZGUgMApbICAg
IDAuMDAwMDAwXSBBQ1BJOiBOVU1BOiBTUkFUOiBQWE0gMCAtPiBNUElEUiAweDI3MDAwMCAtPiBO
b2RlIDAKWyAgICAwLjAwMDAwMF0gQUNQSTogTlVNQTogU1JBVDogUFhNIDAgLT4gTVBJRFIgMHgy
NzAxMDAgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIHBlcmNwdTogRW1iZWRkZWQgMzEgcGFnZXMv
Y3B1IHM4OTI0MCByODE5MiBkMjk1NDQgdTEyNjk3NgpbICAgIDAuMDAwMDAwXSBEZXRlY3RlZCBQ
SVBUIEktY2FjaGUgb24gQ1BVMApbICAgIDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVk
OiBHSUMgc3lzdGVtIHJlZ2lzdGVyIENQVSBpbnRlcmZhY2UKWyAgICAwLjAwMDAwMF0gQ1BVIGZl
YXR1cmVzOiBkZXRlY3RlZDogVmlydHVhbGl6YXRpb24gSG9zdCBFeHRlbnNpb25zClsgICAgMC4w
MDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEhhcmR3YXJlIGRpcnR5IGJpdCBtYW5hZ2Vt
ZW50ClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFNwZWN0cmUtdjQKWyAg
ICAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQVJNIGVycmF0dW0gMTQxODA0MApb
ICAgIDAuMDAwMDAwXSBhbHRlcm5hdGl2ZXM6IHBhdGNoaW5nIGtlcm5lbCBjb2RlClsgICAgMC4w
MDAwMDBdIEJ1aWx0IDEgem9uZWxpc3RzLCBtb2JpbGl0eSBncm91cGluZyBvbi4gIFRvdGFsIHBh
Z2VzOiA4MTkzMjc2ClsgICAgMC4wMDAwMDBdIFBvbGljeSB6b25lOiBOb3JtYWwKWyAgICAwLjAw
MDAwMF0gS2VybmVsIGNvbW1hbmQgbGluZTogQk9PVF9JTUFHRT0vSW1hZ2Ugcm9vdHdhaXQgcncg
cm9vdD0vZGV2L3NkYTIKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbiBpbmRpdmlk
dWFsIG1heCBjcHUgY29udHJpYnV0aW9uOiA0MDk2IGJ5dGVzClsgICAgMC4wMDAwMDBdIHByaW50
azogbG9nX2J1Zl9sZW4gdG90YWwgY3B1X2V4dHJhIGNvbnRyaWJ1dGlvbnM6IDEyNjk3NiBieXRl
cwpbICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVuIG1pbiBzaXplOiAxMzEwNzIgYnl0
ZXMKWyAgICAwLjAwMDAwMF0gcHJpbnRrOiBsb2dfYnVmX2xlbjogMjYyMTQ0IGJ5dGVzClsgICAg
MC4wMDAwMDBdIHByaW50azogZWFybHkgbG9nIGJ1ZiBmcmVlOiAxMjEyNDgoOTIlKQpbICAgIDAu
MDAwMDAwXSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA0MTk0MzA0IChvcmRlcjog
MTMsIDMzNTU0NDMyIGJ5dGVzLCBsaW5lYXIpClsgICAgMC4wMDAwMDBdIElub2RlLWNhY2hlIGhh
c2ggdGFibGUgZW50cmllczogMjA5NzE1MiAob3JkZXI6IDEyLCAxNjc3NzIxNiBieXRlcywgbGlu
ZWFyKQpbICAgIDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBzdGFjazpvZmYsIGhlYXAgYWxsb2M6
b2ZmLCBoZWFwIGZyZWU6b2ZmClsgICAgMC4wMDAwMDBdIHNvZnR3YXJlIElPIFRMQjogbWFwcGVk
IFttZW0gMHgwMDAwMDAwMGZiYjQwMDAwLTB4MDAwMDAwMDBmZmI0MDAwMF0gKDY0TUIpClsgICAg
MC4wMDAwMDBdIE1lbW9yeTogMzI1MDIyODhLLzMzMjkzMzEySyBhdmFpbGFibGUgKDEzNTY4SyBr
ZXJuZWwgY29kZSwgMTk5NksgcndkYXRhLCAzNDc2SyByb2RhdGEsIDQxNjBLIGluaXQsIDgyMksg
YnNzLCA3OTEwMjRLIHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2ZWQpClsgICAgMC4wMDAwMDBdIFNM
VUI6IEhXYWxpZ249NjQsIE9yZGVyPTAtMywgTWluT2JqZWN0cz0wLCBDUFVzPTMyLCBOb2Rlcz0x
ClsgICAgMC4wMDAwMDBdIGZ0cmFjZTogYWxsb2NhdGluZyA0MTMwNiBlbnRyaWVzIGluIDE2MiBw
YWdlcwpbICAgIDAuMDAwMDAwXSBmdHJhY2U6IGFsbG9jYXRlZCAxNjIgcGFnZXMgd2l0aCAzIGdy
b3VwcwpbICAgIDAuMDAwMDAwXSByY3U6IFByZWVtcHRpYmxlIGhpZXJhcmNoaWNhbCBSQ1UgaW1w
bGVtZW50YXRpb24uClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSBldmVudCB0cmFjaW5nIGlzIGVu
YWJsZWQuClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSByZXN0cmljdGluZyBDUFVzIGZyb20gTlJf
Q1BVUz0yNTYgdG8gbnJfY3B1X2lkcz0zMi4KWyAgICAwLjAwMDAwMF0gCVRyYW1wb2xpbmUgdmFy
aWFudCBvZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gCVJ1ZGUgdmFyaWFudCBv
ZiBUYXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gCVRyYWNpbmcgdmFyaWFudCBvZiBU
YXNrcyBSQ1UgZW5hYmxlZC4KWyAgICAwLjAwMDAwMF0gcmN1OiBSQ1UgY2FsY3VsYXRlZCB2YWx1
ZSBvZiBzY2hlZHVsZXItZW5saXN0bWVudCBkZWxheSBpcyAyNSBqaWZmaWVzLgpbICAgIDAuMDAw
MDAwXSByY3U6IEFkanVzdGluZyBnZW9tZXRyeSBmb3IgcmN1X2Zhbm91dF9sZWFmPTE2LCBucl9j
cHVfaWRzPTMyClsgICAgMC4wMDAwMDBdIE5SX0lSUVM6IDY0LCBucl9pcnFzOiA2NCwgcHJlYWxs
b2NhdGVkIGlycXM6IDAKWyAgICAwLjAwMDAwMF0gR0lDdjM6IEdJQzogVXNpbmcgc3BsaXQgRU9J
L0RlYWN0aXZhdGUgbW9kZQpbICAgIDAuMDAwMDAwXSBHSUN2MzogNjcyIFNQSXMgaW1wbGVtZW50
ZWQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IDAgRXh0ZW5kZWQgU1BJcyBpbXBsZW1lbnRlZApbICAg
IDAuMDAwMDAwXSBHSUN2MzogRGlzdHJpYnV0b3IgaGFzIG5vIFJhbmdlIFNlbGVjdG9yIHN1cHBv
cnQKWyAgICAwLjAwMDAwMF0gR0lDdjM6IDE2IFBQSXMgaW1wbGVtZW50ZWQKWyAgICAwLjAwMDAw
MF0gR0lDdjM6IENQVTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTAwMDAwIHJlZ2lvbiAwOjB4MDAw
MDEwMDEwMDU0MDAwMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMCAtPiBOb2Rl
IDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDEgLT4gTm9kZSAwClsgICAgMC4w
MDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyAyIC0+IE5vZGUgMApbICAgIDAuMDAwMDAwXSBTUkFU
OiBQWE0gMCAtPiBJVFMgMyAtPiBOb2RlIDAKWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4g
SVRTIDQgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA1IC0+IE5v
ZGUgMApbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNiAtPiBOb2RlIDAKWyAgICAw
LjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDcgLT4gTm9kZSAwClsgICAgMC4wMDAwMDBdIElU
UyBbbWVtIDB4MTAwMTAwMDQwMDAwLTB4MTAwMTAwMDVmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNA
MHgwMDAwMTAwMTAwMDQwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDIyMDAwMCAo
aW5kaXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAw
MDEwMDEwMDA0MDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAw
MDAyMzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRT
IFttZW0gMHgxMDAxMDAwNjAwMDAtMHgxMDAxMDAwN2ZmZmZdClsgICAgMC4wMDAwMDBdIElUU0Aw
eDAwMDAxMDAxMDAwNjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMjUwMDAwIChp
bmRpcmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAw
MTAwMTAwMDYwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAw
MDI2MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFMg
W21lbSAweDEwMDEwMDA4MDAwMC0weDEwMDEwMDA5ZmZmZl0KWyAgICAwLjAwMDAwMF0gSVRTQDB4
MDAwMDEwMDEwMDA4MDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAyODAwMDAgKGlu
ZGlyZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAx
MDAxMDAwODAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAw
MjkwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUUyBb
bWVtIDB4MTAwMTAwMGEwMDAwLTB4MTAwMTAwMGJmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNAMHgw
MDAwMTAwMTAwMGEwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDJiMDAwMCAoaW5k
aXJlY3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEw
MDEwMDBhMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAy
YzAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTIFtt
ZW0gMHgxMDAxMDAwYzAwMDAtMHgxMDAxMDAwZGZmZmZdClsgICAgMC4wMDAwMDBdIElUU0AweDAw
MDAxMDAxMDAwYzAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMmUwMDAwIChpbmRp
cmVjdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAw
MTAwMGMwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDJm
MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFMgW21l
bSAweDEwMDEwMDBlMDAwMC0weDEwMDEwMDBmZmZmZl0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAw
MDEwMDEwMDBlMDAwMDogYWxsb2NhdGVkIDgxOTIgRGV2aWNlcyBAODAwMDAzMTAwMDAgKGluZGly
ZWN0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAx
MDAwZTAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMzIw
MDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpClsgICAgMC4wMDAwMDBdIElUUyBbbWVt
IDB4MTAwMTAwMTAwMDAwLTB4MTAwMTAwMTFmZmZmXQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAw
MTAwMTAwMTAwMDAwOiBhbGxvY2F0ZWQgODE5MiBEZXZpY2VzIEA4MDAwMDM0MDAwMCAoaW5kaXJl
Y3QsIGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEw
MDEwMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAzNTAw
MDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkKWyAgICAwLjAwMDAwMF0gSVRTIFttZW0g
MHgxMDAxMDAxMjAwMDAtMHgxMDAxMDAxM2ZmZmZdClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAx
MDAxMDAxMjAwMDA6IGFsbG9jYXRlZCA4MTkyIERldmljZXMgQDgwMDAwMzcwMDAwIChpbmRpcmVj
dCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAw
MTIwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDM4MDAw
MCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQpbICAgIDAuMDAwMDAwXSBHSUN2MzogdXNp
bmcgTFBJIHByb3BlcnR5IHRhYmxlIEAweDAwMDAwODAwMDAzOTAwMDAKWyAgICAwLjAwMDAwMF0g
R0lDdjM6IENQVTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwM2EwMDAwClsgICAgMC4wMDAwMDBdIHJhbmRvbTogZ2V0X3JhbmRvbV9ieXRlcyBjYWxsZWQg
ZnJvbSBzdGFydF9rZXJuZWwrMHgzOTQvMHg1NTQgd2l0aCBjcm5nX2luaXQ9MApbICAgIDAuMDAw
MDAwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1
bSAxNDE4MDQwClsgICAgMC4wMDAwMDBdIEFDUEkgR1REVDogZm91bmQgMSBtZW1vcnktbWFwcGVk
IHRpbWVyIGJsb2NrKHMpLgpbICAgIDAuMDAwMDAwXSBhcmNoX3RpbWVyOiBjcDE1IGFuZCBtbWlv
IHRpbWVyKHMpIHJ1bm5pbmcgYXQgMjUuMDBNSHogKHBoeXMvcGh5cykuClsgICAgMC4wMDAwMDBd
IGNsb2Nrc291cmNlOiBhcmNoX3N5c19jb3VudGVyOiBtYXNrOiAweGZmZmZmZmZmZmZmZmZmIG1h
eF9jeWNsZXM6IDB4NWM0MDkzOWI1LCBtYXhfaWRsZV9uczogNDQwNzk1MjAyNjQ2IG5zClsgICAg
MC4wMDAwMDFdIHNjaGVkX2Nsb2NrOiA1NiBiaXRzIGF0IDI1TUh6LCByZXNvbHV0aW9uIDQwbnMs
IHdyYXBzIGV2ZXJ5IDQzOTgwNDY1MTExMDBucwpbICAgIDAuMDAwMDUzXSBDb25zb2xlOiBjb2xv
dXIgZHVtbXkgZGV2aWNlIDgweDI1ClsgICAgMC4wMDAwNzVdIEFDUEk6IENvcmUgcmV2aXNpb24g
MjAyMDA5MjUKWyAgICAwLjAwMDQ4Nl0gQ2FsaWJyYXRpbmcgZGVsYXkgbG9vcCAoc2tpcHBlZCks
IHZhbHVlIGNhbGN1bGF0ZWQgdXNpbmcgdGltZXIgZnJlcXVlbmN5Li4gNTAuMDAgQm9nb01JUFMg
KGxwaj0xMDAwMDApClsgICAgMC4wMDA0OTFdIHBpZF9tYXg6IGRlZmF1bHQ6IDMyNzY4IG1pbmlt
dW06IDMwMQpbICAgIDAuMDAwNTE4XSBMU006IFNlY3VyaXR5IEZyYW1ld29yayBpbml0aWFsaXpp
bmcKWyAgICAwLjAwMDY0NV0gTW91bnQtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAo
b3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAgIDAuMDAwNzI3XSBNb3VudHBvaW50
LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA3LCA1MjQyODggYnl0ZXMs
IGxpbmVhcikKWyAgICAwLjAwMTU3Nl0gcmN1OiBIaWVyYXJjaGljYWwgU1JDVSBpbXBsZW1lbnRh
dGlvbi4KWyAgICAwLjAwMTcwNV0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwNDAwMDAgZG9t
YWluIGNyZWF0ZWQKWyAgICAwLjAwMTcwOV0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwNjAw
MDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxMl0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAx
MDAwODAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxNV0gUGxhdGZvcm0gTVNJOiBJVFNA
MHgxMDAxMDAwYTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcxOF0gUGxhdGZvcm0gTVNJ
OiBJVFNAMHgxMDAxMDAwYzAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyMV0gUGxhdGZv
cm0gTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAwMTcyNF0g
UGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMDAwMDAgZG9tYWluIGNyZWF0ZWQKWyAgICAwLjAw
MTcyOF0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAxMjAwMDAgZG9tYWluIGNyZWF0ZWQKWyAg
ICAwLjAwMTczNV0gUENJL01TSTogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkClsg
ICAgMC4wMDE3MzhdIFBDSS9NU0k6IElUU0AweDEwMDEwMDA2MDAwMCBkb21haW4gY3JlYXRlZApb
ICAgIDAuMDAxNzQwXSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9tYWluIGNyZWF0ZWQK
WyAgICAwLjAwMTc0M10gUENJL01TSTogSVRTQDB4MTAwMTAwMGEwMDAwIGRvbWFpbiBjcmVhdGVk
ClsgICAgMC4wMDE3NDZdIFBDSS9NU0k6IElUU0AweDEwMDEwMDBjMDAwMCBkb21haW4gY3JlYXRl
ZApbICAgIDAuMDAxNzUwXSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAgZG9tYWluIGNyZWF0
ZWQKWyAgICAwLjAwMTc1M10gUENJL01TSTogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBjcmVh
dGVkClsgICAgMC4wMDE3NTZdIFBDSS9NU0k6IElUU0AweDEwMDEwMDEyMDAwMCBkb21haW4gY3Jl
YXRlZApbICAgIDAuMDAxNzYzXSBSZW1hcHBpbmcgYW5kIGVuYWJsaW5nIEVGSSBzZXJ2aWNlcy4K
WyAgICAwLjAwMzYwMF0gc21wOiBCcmluZ2luZyB1cCBzZWNvbmRhcnkgQ1BVcyAuLi4KWyAgICAw
LjAwMzg0OF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEKWyAgICAwLjAwMzg3N10gR0lD
djM6IENQVTE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTgwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDc0MDAwMApbICAgIDAuMDAzOTAxXSBHSUN2MzogQ1BVMTogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzYjAwMDAKWyAgICAwLjAwMzk0Nl0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDAzOTYyXSBDUFUxOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxODAwMDAg
WzB4NDEzZmQwYzFdClsgICAgMC4wMDQzMzldIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUy
ClsgICAgMC4wMDQzNjZdIEdJQ3YzOiBDUFUyOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDE2MDAwMCBy
ZWdpb24gMDoweDAwMDAxMDAxMDA2YzAwMDAKWyAgICAwLjAwNDM4OV0gR0lDdjM6IENQVTI6IHVz
aW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwM2MwMDAwClsgICAg
MC4wMDQ0MzddIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBl
cnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwNDQ1Ml0gQ1BVMjogQm9vdGVkIHNlY29uZGFyeSBwcm9j
ZXNzb3IgMHgwMDAwMTYwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA0NzQzXSBEZXRlY3RlZCBQ
SVBUIEktY2FjaGUgb24gQ1BVMwpbICAgIDAuMDA0NzcyXSBHSUN2MzogQ1BVMzogZm91bmQgcmVk
aXN0cmlidXRvciAxZTAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOGMwMDAwClsgICAgMC4wMDQ3
OTZdIEdJQ3YzOiBDUFUzOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAw
MDA4MDAwMDNkMDAwMApbICAgIDAuMDA0ODQ0XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3
b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMDQ4NjBdIENQVTM6IEJv
b3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDFlMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAw
LjAwNTE0Nl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTQKWyAgICAwLjAwNTE2Nl0gR0lD
djM6IENQVTQ6IGZvdW5kIHJlZGlzdHJpYnV0b3IgODAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
MzQwMDAwClsgICAgMC4wMDUxOTBdIEdJQ3YzOiBDUFU0OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNlMDAwMApbICAgIDAuMDA1MjM4XSBhcmNoX3RpbWVy
OiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAg
MC4wMDUyNDldIENQVTQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDA4MDAwMCBb
MHg0MTNmZDBjMV0KWyAgICAwLjAwNTU0NV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTUK
WyAgICAwLjAwNTU3NF0gR0lDdjM6IENQVTU6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjAwMDAwIHJl
Z2lvbiAwOjB4MDAwMDEwMDEwMDk0MDAwMApbICAgIDAuMDA1NTk4XSBHSUN2MzogQ1BVNTogdXNp
bmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzZjAwMDAKWyAgICAw
LjAwNTY0NF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVy
cmF0dW0gMTQxODA0MApbICAgIDAuMDA1NjYwXSBDUFU1OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nl
c3NvciAweDAwMDAyMDAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMDU5NDVdIERldGVjdGVkIFBJ
UFQgSS1jYWNoZSBvbiBDUFU2ClsgICAgMC4wMDU5NjddIEdJQ3YzOiBDUFU2OiBmb3VuZCByZWRp
c3RyaWJ1dG9yIGUwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDRjMDAwMApbICAgIDAuMDA1OTky
XSBHSUN2MzogQ1BVNjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAw
ODAwMDA4MDAwMDAKWyAgICAwLjAwNjA0MV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29y
a2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA2MDUzXSBDUFU2OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwZTAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4w
MDYzNTRdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFU3ClsgICAgMC4wMDYzODZdIEdJQ3Yz
OiBDUFU3OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDI2MDAwMCByZWdpb24gMDoweDAwMDAxMDAxMDBh
YzAwMDAKWyAgICAwLjAwNjQxMl0gR0lDdjM6IENQVTc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVu
ZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODEwMDAwClsgICAgMC4wMDY0NjFdIGFyY2hfdGltZXI6
IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAw
LjAwNjQ3N10gQ1BVNzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjYwMDAwIFsw
eDQxM2ZkMGMxXQpbICAgIDAuMDA2NzQ0XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVOApb
ICAgIDAuMDA2NzY3XSBHSUN2MzogQ1BVODogZm91bmQgcmVkaXN0cmlidXRvciAxMTAwMDAgcmVn
aW9uIDA6MHgwMDAwMTAwMTAwNTgwMDAwClsgICAgMC4wMDY3OTJdIEdJQ3YzOiBDUFU4OiB1c2lu
ZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDgyMDAwMApbICAgIDAu
MDA2ODQwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJy
YXR1bSAxNDE4MDQwClsgICAgMC4wMDY4NTNdIENQVTg6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vz
c29yIDB4MDAwMDExMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwNzIzMF0gRGV0ZWN0ZWQgUElQ
VCBJLWNhY2hlIG9uIENQVTkKWyAgICAwLjAwNzI1Nl0gR0lDdjM6IENQVTk6IGZvdW5kIHJlZGlz
dHJpYnV0b3IgMTkwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDc4MDAwMApbICAgIDAuMDA3Mjgx
XSBHSUN2MzogQ1BVOTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAw
ODAwMDA4MzAwMDAKWyAgICAwLjAwNzMyOV0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29y
a2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA3MzQ1XSBDUFU5OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxOTAwMDAgWzB4NDEzZmQwYzFdClsgICAgMC4w
MDc2NDldIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxMApbICAgIDAuMDA3Njc1XSBHSUN2
MzogQ1BVMTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTcwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDcwMDAwMApbICAgIDAuMDA3NzAyXSBHSUN2MzogQ1BVMTA6IHVzaW5nIGFsbG9jYXRlZCBMUEkg
cGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwODQwMDAwClsgICAgMC4wMDc3NDldIGFyY2hfdGlt
ZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAg
ICAwLjAwNzc2N10gQ1BVMTA6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDE3MDAw
MCBbMHg0MTNmZDBjMV0KWyAgICAwLjAwODIwNV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQ
VTExClsgICAgMC4wMDgyMzRdIEdJQ3YzOiBDUFUxMTogZm91bmQgcmVkaXN0cmlidXRvciAxZjAw
MDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwOTAwMDAwClsgICAgMC4wMDgyNjBdIEdJQ3YzOiBDUFUx
MTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4NTAwMDAK
WyAgICAwLjAwODMwN10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3Ig
QVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDA4MzI1XSBDUFUxMTogQm9vdGVkIHNlY29uZGFy
eSBwcm9jZXNzb3IgMHgwMDAwMWYwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA4NjI1XSBEZXRl
Y3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMTIKWyAgICAwLjAwODY0NV0gR0lDdjM6IENQVTEyOiBm
b3VuZCByZWRpc3RyaWJ1dG9yIDkwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDM4MDAwMApbICAg
IDAuMDA4NjcyXSBHSUN2MzogQ1BVMTI6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwMDAwODYwMDAwClsgICAgMC4wMDg3MjBdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwODczOF0g
Q1BVMTI6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDA5MDAwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAwOTAzMV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEzClsgICAgMC4w
MDkwNjBdIEdJQ3YzOiBDUFUxMzogZm91bmQgcmVkaXN0cmlidXRvciAyMTAwMDAgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwOTgwMDAwClsgICAgMC4wMDkwODZdIEdJQ3YzOiBDUFUxMzogdXNpbmcgYWxs
b2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4NzAwMDAKWyAgICAwLjAwOTEz
Ml0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0g
MTQxODA0MApbICAgIDAuMDA5MTUwXSBDUFUxMzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3Ig
MHgwMDAwMjEwMDAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDA5NDQwXSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVMTQKWyAgICAwLjAwOTQ2M10gR0lDdjM6IENQVTE0OiBmb3VuZCByZWRpc3Ry
aWJ1dG9yIGYwMDAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDUwMDAwMApbICAgIDAuMDA5NDkxXSBH
SUN2MzogQ1BVMTQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwODgwMDAwClsgICAgMC4wMDk1MzldIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAwOTU1OV0gQ1BVMTQ6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDBmMDAwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAx
MDAxNF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE1ClsgICAgMC4wMTAwNDddIEdJQ3Yz
OiBDUFUxNTogZm91bmQgcmVkaXN0cmlidXRvciAyNzAwMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
YjAwMDAwClsgICAgMC4wMTAwNzRdIEdJQ3YzOiBDUFUxNTogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4OTAwMDAKWyAgICAwLjAxMDEyM10gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDEwMTQyXSBDUFUxNTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMjcwMDAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDEwNDM1XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MTYKWyAgICAwLjAxMDQ1OF0gR0lDdjM6IENQVTE2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwMDEw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA1NjAwMDAKWyAgICAwLjAxMDQ4NF0gR0lDdjM6IENQVTE2
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhhMDAwMApb
ICAgIDAuMDEwNTMxXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTA1NTBdIENQVTE2OiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAxMDAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTA4MzRdIERldGVj
dGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxNwpbICAgIDAuMDEwODYxXSBHSUN2MzogQ1BVMTc6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgMTgwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDc2MDAwMApbICAg
IDAuMDEwODg4XSBHSUN2MzogQ1BVMTc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwMDAwOGIwMDAwClsgICAgMC4wMTA5MzZdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxMDk1NV0g
Q1BVMTc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDE4MDEwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAxMTMyNF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE4ClsgICAgMC4w
MTEzNTBdIEdJQ3YzOiBDUFUxODogZm91bmQgcmVkaXN0cmlidXRvciAxNjAxMDAgcmVnaW9uIDA6
MHgwMDAwMTAwMTAwNmUwMDAwClsgICAgMC4wMTEzNzldIEdJQ3YzOiBDUFUxODogdXNpbmcgYWxs
b2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4YzAwMDAKWyAgICAwLjAxMTQy
N10gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0g
MTQxODA0MApbICAgIDAuMDExNDQ3XSBDUFUxODogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3Ig
MHgwMDAwMTYwMTAwIFsweDQxM2ZkMGMxXQpbICAgIDAuMDExODM0XSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVMTkKWyAgICAwLjAxMTg2NF0gR0lDdjM6IENQVTE5OiBmb3VuZCByZWRpc3Ry
aWJ1dG9yIDFlMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA4ZTAwMDAKWyAgICAwLjAxMTg5M10g
R0lDdjM6IENQVTE5OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4
MDAwMDhkMDAwMApbICAgIDAuMDExOTM5XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3Jr
YXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTE5NTldIENQVTE5OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAxZTAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4w
MTI0MTBdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMApbICAgIDAuMDEyNDMwXSBHSUN2
MzogQ1BVMjA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgODAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
MzYwMDAwClsgICAgMC4wMTI0NThdIEdJQ3YzOiBDUFUyMDogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA4ZTAwMDAKWyAgICAwLjAxMjUwNl0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDEyNTI2XSBDUFUyMDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDgwMTAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDEyODI2XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MjEKWyAgICAwLjAxMjg1NV0gR0lDdjM6IENQVTIxOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDIwMDEw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA5NjAwMDAKWyAgICAwLjAxMjg4N10gR0lDdjM6IENQVTIx
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDhmMDAwMApb
ICAgIDAuMDEyOTM0XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTI5NTRdIENQVTIxOiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAyMDAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTM0MDZdIERldGVj
dGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyMgpbICAgIDAuMDEzNDI5XSBHSUN2MzogQ1BVMjI6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgZTAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNGUwMDAwClsgICAg
MC4wMTM0NThdIEdJQ3YzOiBDUFUyMjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxl
IEAweDAwMDAwODAwMDA5MDAwMDAKWyAgICAwLjAxMzUwOV0gYXJjaF90aW1lcjogRW5hYmxpbmcg
bG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAgIDAuMDEzNTI5XSBD
UFUyMjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMGUwMTAwIFsweDQxM2ZkMGMx
XQpbICAgIDAuMDEzODM3XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjMKWyAgICAwLjAx
Mzg3MF0gR0lDdjM6IENQVTIzOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDI2MDEwMCByZWdpb24gMDow
eDAwMDAxMDAxMDBhZTAwMDAKWyAgICAwLjAxMzkwMF0gR0lDdjM6IENQVTIzOiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDkxMDAwMApbICAgIDAuMDEzOTQ3
XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAx
NDE4MDQwClsgICAgMC4wMTM5NjddIENQVTIzOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAyNjAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTQ0MTRdIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUyNApbICAgIDAuMDE0NDM5XSBHSUN2MzogQ1BVMjQ6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMTEwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDVhMDAwMApbICAgIDAuMDE0NDY3XSBH
SUN2MzogQ1BVMjQ6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwOTIwMDAwClsgICAgMC4wMTQ1MTVdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNDUzNl0gQ1BVMjQ6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDExMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAx
NDgyOV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI1ClsgICAgMC4wMTQ4NTVdIEdJQ3Yz
OiBDUFUyNTogZm91bmQgcmVkaXN0cmlidXRvciAxOTAxMDAgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
N2EwMDAwClsgICAgMC4wMTQ4ODVdIEdJQ3YzOiBDUFUyNTogdXNpbmcgYWxsb2NhdGVkIExQSSBw
ZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDA5MzAwMDAKWyAgICAwLjAxNDkzMl0gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MApbICAg
IDAuMDE0OTUzXSBDUFUyNTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMTkwMTAw
IFsweDQxM2ZkMGMxXQpbICAgIDAuMDE1MjU0XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BV
MjYKWyAgICAwLjAxNTI4MV0gR0lDdjM6IENQVTI2OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDE3MDEw
MCByZWdpb24gMDoweDAwMDAxMDAxMDA3MjAwMDAKWyAgICAwLjAxNTMxMl0gR0lDdjM6IENQVTI2
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk0MDAwMApb
ICAgIDAuMDE1MzYxXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwClsgICAgMC4wMTUzODFdIENQVTI2OiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAxNzAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTU5MzRdIERldGVj
dGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyNwpbICAgIDAuMDE1OTYzXSBHSUN2MzogQ1BVMjc6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgMWYwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDkyMDAwMApbICAg
IDAuMDE1OTk1XSBHSUN2MzogQ1BVMjc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJs
ZSBAMHgwMDAwMDgwMDAwOTUwMDAwClsgICAgMC4wMTYwNDFdIGFyY2hfdGltZXI6IEVuYWJsaW5n
IGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNjA2M10g
Q1BVMjc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDFmMDEwMCBbMHg0MTNmZDBj
MV0KWyAgICAwLjAxNjQyNV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI4ClsgICAgMC4w
MTY0NDZdIEdJQ3YzOiBDUFUyODogZm91bmQgcmVkaXN0cmlidXRvciA5MDEwMCByZWdpb24gMDow
eDAwMDAxMDAxMDAzYTAwMDAKWyAgICAwLjAxNjQ3N10gR0lDdjM6IENQVTI4OiB1c2luZyBhbGxv
Y2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk2MDAwMApbICAgIDAuMDE2NTI1
XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAx
NDE4MDQwClsgICAgMC4wMTY1NDZdIENQVTI4OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAwOTAxMDAgWzB4NDEzZmQwYzFdClsgICAgMC4wMTY4NjFdIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUyOQpbICAgIDAuMDE2ODkwXSBHSUN2MzogQ1BVMjk6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMjEwMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDlhMDAwMApbICAgIDAuMDE2OTIxXSBH
SUN2MzogQ1BVMjk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgw
MDAwOTcwMDAwClsgICAgMC4wMTY5NjldIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmth
cm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNjk5MF0gQ1BVMjk6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDIxMDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAx
NzQyNl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTMwClsgICAgMC4wMTc0NTBdIEdJQ3Yz
OiBDUFUzMDogZm91bmQgcmVkaXN0cmlidXRvciBmMDEwMCByZWdpb24gMDoweDAwMDAxMDAxMDA1
MjAwMDAKWyAgICAwLjAxNzQ4MV0gR0lDdjM6IENQVTMwOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDk4MDAwMApbICAgIDAuMDE3NTMwXSBhcmNoX3RpbWVy
OiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwClsgICAg
MC4wMTc1NTJdIENQVTMwOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwZjAxMDAg
WzB4NDEzZmQwYzFdClsgICAgMC4wMTc4NTJdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUz
MQpbICAgIDAuMDE3ODg2XSBHSUN2MzogQ1BVMzE6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMjcwMTAw
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMGIyMDAwMApbICAgIDAuMDE3OTE4XSBHSUN2MzogQ1BVMzE6
IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAwOTkwMDAwClsg
ICAgMC4wMTc5NjRdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDAKWyAgICAwLjAxNzk4N10gQ1BVMzE6IEJvb3RlZCBzZWNvbmRhcnkg
cHJvY2Vzc29yIDB4MDAwMDI3MDEwMCBbMHg0MTNmZDBjMV0KWyAgICAwLjAxODA3MF0gc21wOiBC
cm91Z2h0IHVwIDEgbm9kZSwgMzIgQ1BVcwpbICAgIDAuMDE4MTY2XSBTTVA6IFRvdGFsIG9mIDMy
IHByb2Nlc3NvcnMgYWN0aXZhdGVkLgpbICAgIDAuMDE4MTY4XSBDUFUgZmVhdHVyZXM6IGRldGVj
dGVkOiBQcml2aWxlZ2VkIEFjY2VzcyBOZXZlcgpbICAgIDAuMDE4MTcwXSBDUFUgZmVhdHVyZXM6
IGRldGVjdGVkOiBMU0UgYXRvbWljIGluc3RydWN0aW9ucwpbICAgIDAuMDE4MTcyXSBDUFUgZmVh
dHVyZXM6IGRldGVjdGVkOiBVc2VyIEFjY2VzcyBPdmVycmlkZQpbICAgIDAuMDE4MTc0XSBDUFUg
ZmVhdHVyZXM6IGRldGVjdGVkOiAzMi1iaXQgRUwwIFN1cHBvcnQKWyAgICAwLjAxODE3Nl0gQ1BV
IGZlYXR1cmVzOiBkZXRlY3RlZDogQ29tbW9uIG5vdCBQcml2YXRlIHRyYW5zbGF0aW9ucwpbICAg
IDAuMDE4MTc4XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBSQVMgRXh0ZW5zaW9uIFN1cHBvcnQK
WyAgICAwLjAxODE4MF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogRGF0YSBjYWNoZSBjbGVhbiB0
byB0aGUgUG9VIG5vdCByZXF1aXJlZCBmb3IgSS9EIGNvaGVyZW5jZQpbICAgIDAuMDE4MTgxXSBD
UFUgZmVhdHVyZXM6IGRldGVjdGVkOiBDUkMzMiBpbnN0cnVjdGlvbnMKWyAgICAwLjAxODE4M10g
Q1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogU3BlY3VsYXRpdmUgU3RvcmUgQnlwYXNzaW5nIFNhZmUg
KFNTQlMpClsgICAgMC4wNTAwODRdIENQVTogQWxsIENQVShzKSBzdGFydGVkIGF0IEVMMgpbICAg
IDAuMDUwODY5XSBkZXZ0bXBmczogaW5pdGlhbGl6ZWQKWyAgICAwLjA1MTE0Nl0gY2xvY2tzb3Vy
Y2U6IGppZmZpZXM6IG1hc2s6IDB4ZmZmZmZmZmYgbWF4X2N5Y2xlczogMHhmZmZmZmZmZiwgbWF4
X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnMKWyAgICAwLjA1MTE1Ml0gZnV0ZXggaGFzaCB0
YWJsZSBlbnRyaWVzOiA4MTkyIChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIpClsgICAg
MC4wNTEzODJdIFNNQklPUyAzLjMuMCBwcmVzZW50LgpbICAgIDAuMDUxMzg4XSBETUk6IEFETElO
SyBDT00tSFBDLUFMVC9DT00tSFBDLUFMVCwgQklPUyBUaWFub0NvcmUgRURLSUkgMTEvMjMvMjAy
MQpbICAgIDAuMDUxNjE4XSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5IDE2ClsgICAg
MC4wNTIxNDBdIERNQTogcHJlYWxsb2NhdGVkIDQwOTYgS2lCIEdGUF9LRVJORUwgcG9vbCBmb3Ig
YXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wNTIzMDVdIERNQTogcHJlYWxsb2NhdGVkIDQwOTYg
S2lCIEdGUF9LRVJORUx8R0ZQX0RNQSBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMKWyAgICAw
LjA1MjQ2N10gRE1BOiBwcmVhbGxvY2F0ZWQgNDA5NiBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BMzIg
cG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zClsgICAgMC4wNTI1NjhdIHRoZXJtYWxfc3lzOiBS
ZWdpc3RlcmVkIHRoZXJtYWwgZ292ZXJub3IgJ3N0ZXBfd2lzZScKWyAgICAwLjA1MjY0OV0gY3B1
aWRsZTogdXNpbmcgZ292ZXJub3IgbWVudQpbICAgIDAuMDUyNzkxXSBEZXRlY3RlZCAxNSBQQ0Mg
U3Vic3BhY2VzClsgICAgMC4wNTI4MTNdIFJlZ2lzdGVyaW5nIFBDQyBkcml2ZXIgYXMgTWFpbGJv
eCBjb250cm9sbGVyClsgICAgMC4wNTI4NDldIGh3LWJyZWFrcG9pbnQ6IGZvdW5kIDYgYnJlYWtw
b2ludCBhbmQgNCB3YXRjaHBvaW50IHJlZ2lzdGVycy4KWyAgICAwLjA1MzE0NV0gQVNJRCBhbGxv
Y2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVzClsgICAgMC4wNTMxNTJdIEFDUEk6
IGJ1cyB0eXBlIFBDSSByZWdpc3RlcmVkClsgICAgMC4wNTMxNTRdIFNlcmlhbDogQU1CQSBQTDAx
MSBVQVJUIGRyaXZlcgpbICAgIDAuMDU1MzEyXSBIdWdlVExCIHJlZ2lzdGVyZWQgMS4wMCBHaUIg
cGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAgICAwLjA1NTMxNV0gSHVnZVRMQiBy
ZWdpc3RlcmVkIDMyLjAgTWlCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzClsgICAg
MC4wNTUzMTddIEh1Z2VUTEIgcmVnaXN0ZXJlZCAyLjAwIE1pQiBwYWdlIHNpemUsIHByZS1hbGxv
Y2F0ZWQgMCBwYWdlcwpbICAgIDAuMDU1MzE5XSBIdWdlVExCIHJlZ2lzdGVyZWQgNjQuMCBLaUIg
cGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMKWyAgICAwLjA1NjAzOV0gY3J5cHRkOiBt
YXhfY3B1X3FsZW4gc2V0IHRvIDEwMDAKWyAgICAwLjEyNDA1N10gcmFpZDY6IG5lb254OCAgIGdl
bigpICA3NzM3IE1CL3MKWyAgICAwLjE5MjA4N10gcmFpZDY6IG5lb254OCAgIHhvcigpICA2MDYy
IE1CL3MKWyAgICAwLjI2MDExOF0gcmFpZDY6IG5lb254NCAgIGdlbigpICA3NjQxIE1CL3MKWyAg
ICAwLjMyODE0Nl0gcmFpZDY6IG5lb254NCAgIHhvcigpICA2MzI3IE1CL3MKWyAgICAwLjM5NjE3
OF0gcmFpZDY6IG5lb254MiAgIGdlbigpICA3MzI1IE1CL3MKWyAgICAwLjQ2NDIwN10gcmFpZDY6
IG5lb254MiAgIHhvcigpICA1NzI0IE1CL3MKWyAgICAwLjUzMjI0MF0gcmFpZDY6IG5lb254MSAg
IGdlbigpICA1OTYwIE1CL3MKWyAgICAwLjYwMDI3MF0gcmFpZDY6IG5lb254MSAgIHhvcigpICA0
OTMxIE1CL3MKWyAgICAwLjY2ODI5OV0gcmFpZDY6IGludDY0eDggIGdlbigpICAzNjAwIE1CL3MK
WyAgICAwLjczNjMyNF0gcmFpZDY6IGludDY0eDggIHhvcigpICAyMDE4IE1CL3MKWyAgICAwLjgw
NDM1NF0gcmFpZDY6IGludDY0eDQgIGdlbigpICA0MTI3IE1CL3MKWyAgICAwLjg3MjQzMl0gcmFp
ZDY6IGludDY0eDQgIHhvcigpICAyMTkxIE1CL3MKWyAgICAwLjk0MDQxNF0gcmFpZDY6IGludDY0
eDIgIGdlbigpICAzNTA0IE1CL3MKWyAgICAxLjAwODQzOF0gcmFpZDY6IGludDY0eDIgIHhvcigp
ICAxODkwIE1CL3MKWyAgICAxLjA3NjQ3Ml0gcmFpZDY6IGludDY0eDEgIGdlbigpICAyODc1IE1C
L3MKWyAgICAxLjE0NDQ5NV0gcmFpZDY6IGludDY0eDEgIHhvcigpICAxNTA4IE1CL3MKWyAgICAx
LjE0NDQ5Nl0gcmFpZDY6IHVzaW5nIGFsZ29yaXRobSBuZW9ueDggZ2VuKCkgNzczNyBNQi9zClsg
ICAgMS4xNDQ0OThdIHJhaWQ2OiAuLi4uIHhvcigpIDYwNjIgTUIvcywgcm13IGVuYWJsZWQKWyAg
ICAxLjE0NDUwMF0gcmFpZDY6IHVzaW5nIG5lb24gcmVjb3ZlcnkgYWxnb3JpdGhtClsgICAgMS4x
NDQ1NzVdIEFDUEk6IEFkZGVkIF9PU0koTW9kdWxlIERldmljZSkKWyAgICAxLjE0NDU3OF0gQUNQ
STogQWRkZWQgX09TSShQcm9jZXNzb3IgRGV2aWNlKQpbICAgIDEuMTQ0NTgwXSBBQ1BJOiBBZGRl
ZCBfT1NJKDMuMCBfU0NQIEV4dGVuc2lvbnMpClsgICAgMS4xNDQ1ODJdIEFDUEk6IEFkZGVkIF9P
U0koUHJvY2Vzc29yIEFnZ3JlZ2F0b3IgRGV2aWNlKQpbICAgIDEuMTQ0NTg0XSBBQ1BJOiBBZGRl
ZCBfT1NJKExpbnV4LURlbGwtVmlkZW8pClsgICAgMS4xNDQ1ODZdIEFDUEk6IEFkZGVkIF9PU0ko
TGludXgtTGVub3ZvLU5WLUhETUktQXVkaW8pClsgICAgMS4xNDQ1ODhdIEFDUEk6IEFkZGVkIF9P
U0koTGludXgtSFBJLUh5YnJpZC1HcmFwaGljcykKWyAgICAxLjE2NTE1OV0gQUNQSTogMiBBQ1BJ
IEFNTCB0YWJsZXMgc3VjY2Vzc2Z1bGx5IGFjcXVpcmVkIGFuZCBsb2FkZWQKWyAgICAxLjE3MTQ2
MF0gQUNQSTogSW50ZXJwcmV0ZXIgZW5hYmxlZApbICAgIDEuMTcxNDYzXSBBQ1BJOiBVc2luZyBH
SUMgZm9yIGludGVycnVwdCByb3V0aW5nClsgICAgMS4xNzE0NzddIEFDUEk6IE1DRkcgdGFibGUg
ZGV0ZWN0ZWQsIDUgZW50cmllcwpbICAgIDEuMTcxNDgzXSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzMz
ZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcxNTA4XSBB
Q1BJOiBJT1JUOiBTTU1VLXYzWzM3ZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21h
aW4gMApbICAgIDEuMTcxNTIxXSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzNmZmZlMDAwMDAwMF0gTWFw
cGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcxNTM1XSBBQ1BJOiBJT1JUOiBTTU1V
LXYzWzJiZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0eSBkb21haW4gMApbICAgIDEuMTcx
NTQ4XSBBQ1BJOiBJT1JUOiBTTU1VLXYzWzJmZmZlMDAwMDAwMF0gTWFwcGVkIHRvIFByb3hpbWl0
eSBkb21haW4gMApbICAgIDEuMTcxNjMzXSBIRVNUOiBUYWJsZSBwYXJzaW5nIGhhcyBiZWVuIGlu
aXRpYWxpemVkLgpbICAgIDEuMjA2NTYxXSBBUk1IMDAxMTowMDogdHR5QU1BMCBhdCBNTUlPIDB4
MTAwMDAyNjAwMDAwIChpcnEgPSA3OSwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBClsgICAgNC4w
MjEzNzVdIHByaW50azogY29uc29sZSBbdHR5QU1BMF0gZW5hYmxlZApbICAgIDQuMDI3NDQ3XSBB
Uk1IMDAxMTowMTogdHR5QU1BMSBhdCBNTUlPIDB4MTAwMDAyNjIwMDAwIChpcnEgPSA4MCwgYmFz
ZV9iYXVkID0gMCkgaXMgYSBTQlNBClsgICAgNC4wMzc1NzNdIEFDUEk6IFBDSSBSb290IEJyaWRn
ZSBbUENJMF0gKGRvbWFpbiAwMDBjIFtidXMgMDAtZmZdKQpbICAgIDQuMDQzNzU2XSBhY3BpIFBO
UDBBMDg6MDA6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0g
U2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICA0LjA1Mjg1OV0gYWNwaSBQTlAwQTA4OjAwOiBQ
Q0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbApb
ICAgIDQuMDYwNjgzXSBhY3BpIFBOUDBBMDg6MDA6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAw
eDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZm
ODAwMDEwZGUwZmMwClsgICAgNC4wNzM0ODZdIGFjcGkgUE5QMEEwODowMDogRUNBTSBhcmVhIFtt
ZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDAK
WyAgICA0LjA4MjM1OF0gYWNwaSBQTlAwQTA4OjAwOiBFQ0FNIGF0IFttZW0gMHgzM2ZmZjAwMDAw
MDAtMHgzM2ZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQpbICAgIDQuMDkwNTE5XSBQQ0kgaG9z
dCBicmlkZ2UgdG8gYnVzIDAwMGM6MDAKWyAgICA0LjA5NDYwN10gcGNpX2J1cyAwMDBjOjAwOiBy
b290IGJ1cyByZXNvdXJjZSBbbWVtIDB4NDAwMDAwMDAtMHg0ZmZmZmZmZiB3aW5kb3ddClsgICAg
NC4xMDIwNzldIHBjaV9idXMgMDAwYzowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDMwMDAw
MDAwMDAwMC0weDMzZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNC4xMTAyNDVdIHBjaV9idXMgMDAw
YzowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC1mZl0KWyAgICA0LjExNTc1Nl0gcGNpIDAw
MGM6MDA6MDAuMDogWzFkZWY6ZTEwMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMApbICAgIDQuMTIx
ODMxXSBwY2kgMDAwYzowMDowMS4wOiBbMWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAw
ClsgICAgNC4xMjc4NzhdIHBjaSAwMDBjOjAwOjAxLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNC4x
MzIxMzhdIHBjaSAwMDBjOjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QK
WyAgICA0LjEzODk5NV0gcGNpIDAwMGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAw
MC0weDBmZmZdIHRvIFtidXMgMDFdIGFkZF9zaXplIDEwMDAKWyAgICA0LjE0NzE2M10gcGNpIDAw
MGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJp
dCBwcmVmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMApbICAg
IDQuMTU4NjI4XSBwY2kgMDAwYzowMDowMS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAw
MC0weDAwMGZmZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAw
MApbICAgIDQuMTY5MTQxXSBwY2kgMDAwYzowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAw
eDQwMDAwMDAwLTB4NDAxZmZmZmZdClsgICAgNC4xNzU5MTldIHBjaSAwMDBjOjAwOjAxLjA6IEJB
UiA5OiBhc3NpZ25lZCBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNC4xODQzNDVdIHBjaSAwMDBjOjAwOjAxLjA6IEJBUiA3OiBubyBzcGFjZSBmb3Ig
W2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjE5MDYwMV0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6
IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjE5NzIwNV0gcGNpIDAw
MGM6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQu
MjAzNDYxXSBwY2kgMDAwYzowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNp
emUgMHgxMDAwXQpbICAgIDQuMjEwMDY1XSBwY2kgMDAwYzowMDowMS4wOiBQQ0kgYnJpZGdlIHRv
IFtidXMgMDFdClsgICAgNC4yMTUwMjBdIHBjaSAwMDBjOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRv
dyBbbWVtIDB4NDAwMDAwMDAtMHg0MDFmZmZmZl0KWyAgICA0LjIyMTc5OF0gcGNpIDAwMGM6MDA6
MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzMDAwMDAxZmZmZmYg
NjRiaXQgcHJlZl0KWyAgICA0LjIzMDIyN10gcGNpX2J1cyAwMDBjOjAwOiByZXNvdXJjZSA0IFtt
ZW0gMHg0MDAwMDAwMC0weDRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjIzNzA5MV0gcGNpX2J1cyAw
MDBjOjAwOiByZXNvdXJjZSA1IFttZW0gMHgzMDAwMDAwMDAwMDAtMHgzM2ZmZGZmZmZmZmYgd2lu
ZG93XQpbICAgIDQuMjQ0NjQ5XSBwY2lfYnVzIDAwMGM6MDE6IHJlc291cmNlIDEgW21lbSAweDQw
MDAwMDAwLTB4NDAxZmZmZmZdClsgICAgNC4yNTA5MDVdIHBjaV9idXMgMDAwYzowMTogcmVzb3Vy
Y2UgMiBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdClsgICAg
NC4yNTg4NTFdIEFDUEk6IFBDSSBSb290IEJyaWRnZSBbUENJMV0gKGRvbWFpbiAwMDBkIFtidXMg
MDAtZmZdKQpbICAgIDQuMjY1MDI5XSBhY3BpIFBOUDBBMDg6MDE6IF9PU0M6IE9TIHN1cHBvcnRz
IFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAg
ICA0LjI3NDEyOF0gYWNwaSBQTlAwQTA4OjAxOiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7
IG5vdCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbApbICAgIDQuMjgxOTUwXSBhY3BpIFBOUDBBMDg6
MDE6IE1DRkcgcXVpcms6IEVDQU0gYXQgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZmZmZm
Zl0gZm9yIFtidXMgMDAtZmZdIHdpdGggMHhmZmZmODAwMDEwZGUwZmMwClsgICAgNC4yOTQ3MzVd
IGFjcGkgUE5QMEEwODowMTogRUNBTSBhcmVhIFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZm
ZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDAKWyAgICA0LjMwMzYwOF0gYWNwaSBQTlAwQTA4
OjAxOiBFQ0FNIGF0IFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZmZmZmZmZdIGZvciBbYnVz
IDAwLWZmXQpbICAgIDQuMzExNzYyXSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMGQ6MDAKWyAg
ICA0LjMxNTg1MF0gcGNpX2J1cyAwMDBkOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4NTAw
MDAwMDAtMHg1ZmZmZmZmZiB3aW5kb3ddClsgICAgNC4zMjMzMjFdIHBjaV9idXMgMDAwZDowMDog
cm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDM0MDAwMDAwMDAwMC0weDM3ZmZkZmZmZmZmZiB3aW5k
b3ddClsgICAgNC4zMzE0ODddIHBjaV9idXMgMDAwZDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1
cyAwMC1mZl0KWyAgICA0LjMzNjk5NV0gcGNpIDAwMGQ6MDA6MDAuMDogWzFkZWY6ZTEwMF0gdHlw
ZSAwMCBjbGFzcyAweDA2MDAwMApbICAgIDQuMzQzMDU5XSBwY2kgMDAwZDowMDowMS4wOiBbMWRl
ZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNC4zNDkwOTJdIHBjaSAwMDBkOjAw
OjAxLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNC4zNTMzNTFdIHBjaSAwMDBkOjAwOjAxLjA6IFBN
RSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA0LjM1OTE3M10gcGNpIDAwMGQ6MDE6
MDAuMDogWzEwZGU6MWU4OV0gdHlwZSAwMCBjbGFzcyAweDAzMDAwMApbICAgIDQuMzY1MTc5XSBw
Y2kgMDAwZDowMTowMC4wOiByZWcgMHgxMDogW21lbSAweDUwMDAwMDAwLTB4NTBmZmZmZmZdClsg
ICAgNC4zNzE0NDNdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDE0OiBbbWVtIDB4MzQwMDAwMDAw
MDAwLTB4MzQwMDBmZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC4zNzkzNTZdIHBjaSAwMDBkOjAx
OjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MzQwMDEwMDAwMDAwLTB4MzQwMDExZmZmZmZmIDY0Yml0
IHByZWZdClsgICAgNC4zODcyNjVdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDI0OiBbaW8gIDB4
NTdmZmUwMDAtMHg1N2ZmZTA3Zl0KWyAgICA0LjM5MzUyNV0gcGNpIDAwMGQ6MDE6MDAuMDogcmVn
IDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAgNC40MDAyNzZdIHBj
aSAwMDBkOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAg
NC40MDY0MjhdIHBjaSAwMDBkOjAxOjAwLjE6IFsxMGRlOjEwZjhdIHR5cGUgMDAgY2xhc3MgMHgw
NDAzMDAKWyAgICA0LjQxMjQzM10gcGNpIDAwMGQ6MDE6MDAuMTogcmVnIDB4MTA6IFttZW0gMHg1
MTAwMDAwMC0weDUxMDAzZmZmXQpbICAgIDQuNDE4ODEzXSBwY2kgMDAwZDowMTowMC4yOiBbMTBk
ZToxYWQ4XSB0eXBlIDAwIGNsYXNzIDB4MGMwMzMwClsgICAgNC40MjQ4MjJdIHBjaSAwMDBkOjAx
OjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4MzQwMDEyMDAwMDAwLTB4MzQwMDEyMDNmZmZmIDY0Yml0
IHByZWZdClsgICAgNC40MzI3MzldIHBjaSAwMDBkOjAxOjAwLjI6IHJlZyAweDFjOiBbbWVtIDB4
MzQwMDEyMDQwMDAwLTB4MzQwMDEyMDRmZmZmIDY0Yml0IHByZWZdClsgICAgNC40NDA2OTVdIHBj
aSAwMDBkOjAxOjAwLjI6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAg
NC40NDY4MzRdIHBjaSAwMDBkOjAxOjAwLjM6IFsxMGRlOjFhZDldIHR5cGUgMDAgY2xhc3MgMHgw
YzgwMDAKWyAgICA0LjQ1Mjg0MF0gcGNpIDAwMGQ6MDE6MDAuMzogcmVnIDB4MTA6IFttZW0gMHg1
MTAwNDAwMC0weDUxMDA0ZmZmXQpbICAgIDQuNDU5MTY0XSBwY2kgMDAwZDowMTowMC4zOiBQTUUj
IHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuNDY1MzAyXSBwY2kgMDAwZDow
MDowMS4wOiBBU1BNOiBjdXJyZW50IGNvbW1vbiBjbG9jayBjb25maWd1cmF0aW9uIGlzIGluY29u
c2lzdGVudCwgcmVjb25maWd1cmluZwpbICAgIDQuNDg2NTgwXSBwY2kgMDAwZDowMDowMS4wOiBC
QVIgOTogYXNzaWduZWQgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAxN2ZmZmZmZiA2NGJpdCBw
cmVmXQpbICAgIDQuNDk1MDA5XSBwY2kgMDAwZDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21l
bSAweDUwMDAwMDAwLTB4NTE3ZmZmZmZdClsgICAgNC41MDE3ODZdIHBjaSAwMDBkOjAwOjAxLjA6
IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjUwODA0Ml0gcGNp
IDAwMGQ6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0K
WyAgICA0LjUxNDY0N10gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFttZW0gMHgz
NDAwMDAwMDAwMDAtMHgzNDAwMGZmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjUyMzA4MF0gcGNp
IDAwMGQ6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTAwMDAwMDAtMHgzNDAw
MTFmZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjUzMTUxM10gcGNpIDAwMGQ6MDE6MDAuMDogQkFS
IDA6IGFzc2lnbmVkIFttZW0gMHg1MDAwMDAwMC0weDUwZmZmZmZmXQpbICAgIDQuNTM4MjkxXSBw
Y2kgMDAwZDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQgW21lbSAweDUxMDAwMDAwLTB4NTEwN2Zm
ZmYgcHJlZl0KWyAgICA0LjU0NTUwM10gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDA6IGFzc2lnbmVk
IFttZW0gMHgzNDAwMTIwMDAwMDAtMHgzNDAwMTIwM2ZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjU1
MzkzNl0gcGNpIDAwMGQ6MDE6MDAuMjogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzNDAwMTIwNDAw
MDAtMHgzNDAwMTIwNGZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjU2MjM2OV0gcGNpIDAwMGQ6MDE6
MDAuMTogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MTA4MDAwMC0weDUxMDgzZmZmXQpbICAgIDQu
NTY5MTQ4XSBwY2kgMDAwZDowMTowMC4zOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDUxMDg0MDAw
LTB4NTEwODRmZmZdClsgICAgNC41NzU5MjddIHBjaSAwMDBkOjAxOjAwLjA6IEJBUiA1OiBubyBz
cGFjZSBmb3IgW2lvICBzaXplIDB4MDA4MF0KWyAgICA0LjU4MjE4M10gcGNpIDAwMGQ6MDE6MDAu
MDogQkFSIDU6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0KWyAgICA0LjU4ODc4
OF0gcGNpIDAwMGQ6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQpbICAgIDQuNTkzNzQz
XSBwY2kgMDAwZDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDUwMDAwMDAwLTB4NTE3
ZmZmZmZdClsgICAgNC42MDA1MTldIHBjaSAwMDBkOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBb
bWVtIDB4MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC42MDg5
NDddIHBjaV9idXMgMDAwZDowMDogU29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3Np
Z25lZCwgdHJ5IGJvb3Rpbmcgd2l0aCBwY2k9cmVhbGxvYwpbICAgIDQuNjE3OTgxXSBwY2lfYnVz
IDAwMGQ6MDA6IHJlc291cmNlIDQgW21lbSAweDUwMDAwMDAwLTB4NWZmZmZmZmYgd2luZG93XQpb
ICAgIDQuNjI0ODQ0XSBwY2lfYnVzIDAwMGQ6MDA6IHJlc291cmNlIDUgW21lbSAweDM0MDAwMDAw
MDAwMC0weDM3ZmZkZmZmZmZmZiB3aW5kb3ddClsgICAgNC42MzI0MDJdIHBjaV9idXMgMDAwZDow
MTogcmVzb3VyY2UgMSBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0KWyAgICA0LjYzODY1OF0g
cGNpX2J1cyAwMDBkOjAxOiByZXNvdXJjZSAyIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgzNDAwMTdm
ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA0LjY0NjYxNF0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQ
Q0kzXSAoZG9tYWluIDAwMDAgW2J1cyAwMC1mZl0pClsgICAgNC42NTI3OTJdIGFjcGkgUE5QMEEw
ODowMzogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdt
ZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDQuNjYxODkzXSBhY3BpIFBOUDBBMDg6MDM6IFBDSWUg
cG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsgICAg
NC42Njk3MTVdIGFjcGkgUE5QMEEwODowMzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4M2Zm
ZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAw
MTBkZTBmYzAKWyAgICA0LjY4MjUwNV0gYWNwaSBQTlAwQTA4OjAzOiBFQ0FNIGFyZWEgW21lbSAw
eDNmZmZmMDAwMDAwMC0weDNmZmZmZmZmZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApbICAg
IDQuNjkxMzc3XSBhY3BpIFBOUDBBMDg6MDM6IEVDQU0gYXQgW21lbSAweDNmZmZmMDAwMDAwMC0w
eDNmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdClsgICAgNC42OTk1MzRdIFBDSSBob3N0IGJy
aWRnZSB0byBidXMgMDAwMDowMApbICAgIDQuNzAzNjIyXSBwY2lfYnVzIDAwMDA6MDA6IHJvb3Qg
YnVzIHJlc291cmNlIFttZW0gMHg3MDAwMDAwMC0weDdmZmZmZmZmIHdpbmRvd10KWyAgICA0Ljcx
MTA5M10gcGNpX2J1cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4M2MwMDAwMDAw
MDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA0LjcxOTI2MF0gcGNpX2J1cyAwMDAwOjAw
OiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQpbICAgIDQuNzI0NzY3XSBwY2kgMDAwMDow
MDowMC4wOiBbMWRlZjplMTAwXSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwClsgICAgNC43MzA4MzJd
IHBjaSAwMDAwOjAwOjAxLjA6IFsxZGVmOmUxMDFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAg
ICA0LjczNjg2NF0gcGNpIDAwMDA6MDA6MDEuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA0Ljc0MTEy
NF0gcGNpIDAwMDA6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAg
IDQuNzQ2OTQwXSBwY2kgMDAwMDowMTowMC4wOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4
MDIwMDAwClsgICAgNC43NTI5NDldIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4
M2MwMDAzMDAwMDAwLTB4M2MwMDAzZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC43NjA4NjZdIHBj
aSAwMDAwOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODE4MDAwLTB4M2MwMDA0ODFm
ZmZmIDY0Yml0IHByZWZdClsgICAgNC43Njg3ODBdIHBjaSAwMDAwOjAxOjAwLjA6IHJlZyAweDMw
OiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuNzc1NTQyXSBwY2kgMDAw
MDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuNzgx
NzAxXSBwY2kgMDAwMDowMTowMC4xOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAw
ClsgICAgNC43ODc3MTBdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAy
MDAwMDAwLTB4M2MwMDAyZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC43OTU2MjhdIHBjaSAwMDAw
OjAxOjAwLjE6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODEwMDAwLTB4M2MwMDA0ODE3ZmZmIDY0
Yml0IHByZWZdClsgICAgNC44MDM1NDJdIHBjaSAwMDAwOjAxOjAwLjE6IHJlZyAweDMwOiBbbWVt
IDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODEwMzAwXSBwY2kgMDAwMDowMTow
MC4xOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODE2NDUwXSBw
Y2kgMDAwMDowMTowMC4yOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAg
NC44MjI0NTldIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAxMDAwMDAw
LTB4M2MwMDAxZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC44MzAzNzZdIHBjaSAwMDAwOjAxOjAw
LjI6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODA4MDAwLTB4M2MwMDA0ODBmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNC44MzgyODldIHBjaSAwMDAwOjAxOjAwLjI6IHJlZyAweDMwOiBbbWVtIDB4ZmZm
ODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODQ1MDQ3XSBwY2kgMDAwMDowMTowMC4yOiBQ
TUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODUxMTk0XSBwY2kgMDAw
MDowMTowMC4zOiBbODA4NjoxNTg5XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAgNC44NTcy
MDJdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4M2Mw
MDAwZmZmZmZmIDY0Yml0IHByZWZdClsgICAgNC44NjUxMTldIHBjaSAwMDAwOjAxOjAwLjM6IHJl
ZyAweDFjOiBbbWVtIDB4M2MwMDA0ODAwMDAwLTB4M2MwMDA0ODA3ZmZmIDY0Yml0IHByZWZdClsg
ICAgNC44NzMwMzNdIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAt
MHhmZmZmZmZmZiBwcmVmXQpbICAgIDQuODc5NzkwXSBwY2kgMDAwMDowMTowMC4zOiBQTUUjIHN1
cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgIDQuODg1OTUzXSBwY2kgMDAwMDowMDow
MS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMS0wMl0gYWRk
X3NpemUgMTAwMApbICAgIDQuODk0MzgzXSBwY2kgMDAwMDowMDowMS4wOiBCQVIgOTogYXNzaWdu
ZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQu
OTAyODEwXSBwY2kgMDAwMDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDcwMDAwMDAw
LTB4NzAxZmZmZmZdClsgICAgNC45MDk1ODddIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA3OiBubyBz
cGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjkxNTg0M10gcGNpIDAwMDA6MDA6MDEu
MDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA0LjkyMjQ0
OF0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAw
XQpbICAgIDQuOTI4NzA0XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDQuOTM1MzA5XSBwY2kgMDAwMDowMTowMC4wOiBCQVIg
MDogYXNzaWduZWQgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAwMGZmZmZmZiA2NGJpdCBwcmVm
XQpbICAgIDQuOTQzNzQzXSBwY2kgMDAwMDowMTowMC4xOiBCQVIgMDogYXNzaWduZWQgW21lbSAw
eDNjMDAwMTAwMDAwMC0weDNjMDAwMWZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTUyMTc1XSBw
Y2kgMDAwMDowMTowMC4yOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMjAwMDAwMC0weDNj
MDAwMmZmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDQuOTYwNjA3XSBwY2kgMDAwMDowMTowMC4zOiBC
QVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAwMzAwMDAwMC0weDNjMDAwM2ZmZmZmZiA2NGJpdCBw
cmVmXQpbICAgIDQuOTY5MDM5XSBwY2kgMDAwMDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQgW21l
bSAweDcwMDAwMDAwLTB4NzAwN2ZmZmYgcHJlZl0KWyAgICA0Ljk3NjI1MF0gcGNpIDAwMDA6MDE6
MDAuMTogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg3MDA4MDAwMC0weDcwMGZmZmZmIHByZWZdClsg
ICAgNC45ODM0NjJdIHBjaSAwMDAwOjAxOjAwLjI6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4NzAx
MDAwMDAtMHg3MDE3ZmZmZiBwcmVmXQpbICAgIDQuOTkwNjczXSBwY2kgMDAwMDowMTowMC4zOiBC
QVIgNjogYXNzaWduZWQgW21lbSAweDcwMTgwMDAwLTB4NzAxZmZmZmYgcHJlZl0KWyAgICA0Ljk5
Nzg4NF0gcGNpIDAwMDA6MDE6MDAuMDogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDAw
MDAtMHgzYzAwMDQwMDdmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAwNjMxN10gcGNpIDAwMDA6MDE6
MDAuMTogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQwMDgwMDAtMHgzYzAwMDQwMGZmZmYg
NjRiaXQgcHJlZl0KWyAgICA1LjAxNDc0OV0gcGNpIDAwMDA6MDE6MDAuMjogQkFSIDM6IGFzc2ln
bmVkIFttZW0gMHgzYzAwMDQwMTAwMDAtMHgzYzAwMDQwMTdmZmYgNjRiaXQgcHJlZl0KWyAgICA1
LjAyMzE4Ml0gcGNpIDAwMDA6MDE6MDAuMzogQkFSIDM6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDQw
MTgwMDAtMHgzYzAwMDQwMWZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjAzMTYxNF0gcGNpIDAwMDA6
MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxLTAyXQpbICAgIDUuMDM2ODMwXSBwY2kgMDAw
MDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZmZmZdClsg
ICAgNS4wNDM2MDddIHBjaSAwMDAwOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4M2Mw
MDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS4wNTIwMzVdIHBjaV9i
dXMgMDAwMDowMDogcmVzb3VyY2UgNCBbbWVtIDB4NzAwMDAwMDAtMHg3ZmZmZmZmZiB3aW5kb3dd
ClsgICAgNS4wNTg4OTldIHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNSBbbWVtIDB4M2MwMDAw
MDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10KWyAgICA1LjA2NjQ1N10gcGNpX2J1cyAwMDAw
OjAxOiByZXNvdXJjZSAxIFttZW0gMHg3MDAwMDAwMC0weDcwMWZmZmZmXQpbICAgIDUuMDcyNzEz
XSBwY2lfYnVzIDAwMDA6MDE6IHJlc291cmNlIDIgW21lbSAweDNjMDAwMDAwMDAwMC0weDNjMDAw
NDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuMDgwNjc1XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2Ug
W1BDSTZdIChkb21haW4gMDAwNCBbYnVzIDAwLWZmXSkKWyAgICA1LjA4Njg1Ml0gYWNwaSBQTlAw
QTA4OjA2OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9ja1BNIFNl
Z21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAgNS4wOTU5NTJdIGFjcGkgUE5QMEEwODowNjogUENJ
ZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNvbnRyb2wKWyAg
ICA1LjEwMzc3M10gYWNwaSBQTlAwQTA4OjA2OiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgy
YmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgw
MDAxMGRlMGZjMApbICAgIDUuMTE2NTU3XSBhY3BpIFBOUDBBMDg6MDY6IEVDQU0gYXJlYSBbbWVt
IDB4MmJmZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmXSByZXNlcnZlZCBieSBQTlAwQzAyOjAwClsg
ICAgNS4xMjU0MzBdIGFjcGkgUE5QMEEwODowNjogRUNBTSBhdCBbbWVtIDB4MmJmZmYwMDAwMDAw
LTB4MmJmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0KWyAgICA1LjEzMzU4M10gUENJIGhvc3Qg
YnJpZGdlIHRvIGJ1cyAwMDA0OjAwClsgICAgNS4xMzc2NzFdIHBjaV9idXMgMDAwNDowMDogcm9v
dCBidXMgcmVzb3VyY2UgW21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpbICAgIDUu
MTQ1MTQzXSBwY2lfYnVzIDAwMDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgyODAwMDAw
MDAwMDAtMHgyYmZmZGZmZmZmZmYgd2luZG93XQpbICAgIDUuMTUzMzEwXSBwY2lfYnVzIDAwMDQ6
MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdClsgICAgNS4xNTg4MThdIHBjaSAwMDA0
OjAwOjAwLjA6IFsxZGVmOmUxMTBdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDAKWyAgICA1LjE2NDg4
MF0gcGNpIDAwMDQ6MDA6MDEuMDogWzFkZWY6ZTExMV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApb
ICAgIDUuMTcwOTE1XSBwY2kgMDAwNDowMDowMS4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDUuMTc1
MTc1XSBwY2kgMDAwNDowMDowMS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90Clsg
ICAgNS4xODA5NThdIHBjaSAwMDA0OjAwOjAzLjA6IFsxZGVmOmUxMTNdIHR5cGUgMDEgY2xhc3Mg
MHgwNjA0MDAKWyAgICA1LjE4Njk5Ml0gcGNpIDAwMDQ6MDA6MDMuMDogc3VwcG9ydHMgRDEgRDIK
WyAgICA1LjE5MTI1MV0gcGNpIDAwMDQ6MDA6MDMuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBE
MSBEM2hvdApbICAgIDUuMTk3MDM3XSBwY2kgMDAwNDowMDowNS4wOiBbMWRlZjplMTE1XSB0eXBl
IDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNS4yMDMwNzldIHBjaSAwMDA0OjAwOjA1LjA6IHN1cHBv
cnRzIEQxIEQyClsgICAgNS4yMDczMzhdIHBjaSAwMDA0OjAwOjA1LjA6IFBNRSMgc3VwcG9ydGVk
IGZyb20gRDAgRDEgRDNob3QKWyAgICA1LjIxMzE1OF0gcGNpIDAwMDQ6MDE6MDAuMDogWzFhMDM6
MTE1MF0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUuMjE5MjA0XSBwY2kgMDAwNDowMTow
MC4wOiBlbmFibGluZyBFeHRlbmRlZCBUYWdzClsgICAgNS4yMjQyMTldIHBjaSAwMDA0OjAxOjAw
LjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS4yMjg0NzhdIHBjaSAwMDA0OjAxOjAwLjA6IFBNRSMg
c3VwcG9ydGVkIGZyb20gRDAgRDEgRDIgRDNob3QgRDNjb2xkClsgICAgNS4yMzUxODJdIHBjaV9i
dXMgMDAwNDowMjogZXh0ZW5kZWQgY29uZmlnIHNwYWNlIG5vdCBhY2Nlc3NpYmxlClsgICAgNS4y
NDEyODddIHBjaSAwMDA0OjAyOjAwLjA6IFsxYTAzOjIwMDBdIHR5cGUgMDAgY2xhc3MgMHgwMzAw
MDAKWyAgICA1LjI0NzMwMV0gcGNpIDAwMDQ6MDI6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMDAw
MDAwMC0weDIwZmZmZmZmXQpbICAgIDUuMjUzNTY3XSBwY2kgMDAwNDowMjowMC4wOiByZWcgMHgx
NDogW21lbSAweDIxMDAwMDAwLTB4MjEwMWZmZmZdClsgICAgNS4yNTk4MzNdIHBjaSAwMDA0OjAy
OjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjdmZmYwMDAtMHgyN2ZmZjA3Zl0KWyAgICA1LjI2NjE3
M10gcGNpIDAwMDQ6MDI6MDAuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjI3MDQzM10gcGNpIDAw
MDQ6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEMiBEM2hvdCBEM2NvbGQKWyAg
ICA1LjI3NzE3M10gcGNpIDAwMDQ6MDM6MDAuMDogWzE5MTI6MDAxNF0gdHlwZSAwMCBjbGFzcyAw
eDBjMDMzMApbICAgIDUuMjgzMTg5XSBwY2kgMDAwNDowMzowMC4wOiByZWcgMHgxMDogW21lbSAw
eDIxMjAwMDAwLTB4MjEyMDFmZmYgNjRiaXRdClsgICAgNS4yOTAwNjldIHBjaSAwMDA0OjAzOjAw
LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAgNS4yOTYyOTJdIHBj
aSAwMDA0OjA0OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUgMDAgY2xhc3MgMHgwMjAwMDAKWyAgICA1
LjMwMjMxN10gcGNpIDAwMDQ6MDQ6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMTEwMDAwMC0weDIx
MTdmZmZmXQpbICAgIDUuMzA4NjA0XSBwY2kgMDAwNDowNDowMC4wOiByZWcgMHgxODogW2lvICAw
eDI3ZmZlMDAwLTB4MjdmZmUwMWZdClsgICAgNS4zMTQ4NzVdIHBjaSAwMDA0OjA0OjAwLjA6IHJl
ZyAweDFjOiBbbWVtIDB4MjExODAwMDAtMHgyMTE4M2ZmZl0KWyAgICA1LjMyMTMwOV0gcGNpIDAw
MDQ6MDQ6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAgICA1LjMy
NzUwNl0gcGNpIDAwMDQ6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgw
MDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxLTAyXSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2Fs
aWduIDEwMDAwMApbICAgIDUuMzM5MjMzXSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93
IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMApbICAgIDUuMzQ3
NDAwXSBwY2kgMDAwNDowMDowMy4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAw
MGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24g
MTAwMDAwClsgICAgNS4zNTg4NjVdIHBjaSAwMDA0OjAwOjAzLjA6IGJyaWRnZSB3aW5kb3cgW21l
bSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDEwMDAwMCBhZGRf
YWxpZ24gMTAwMDAwClsgICAgNS4zNjkzNzVdIHBjaSAwMDA0OjAwOjA1LjA6IGJyaWRnZSB3aW5k
b3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0gYWRk
X3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjM4MDg0MV0gcGNpIDAwMDQ6MDA6
MDUuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAw
NF0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1LjM5MTM1NV0gcGNpIDAw
MDQ6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpb
ICAgIDUuMzk4MTMzXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDI4
MDAwMDAwMDAwMC0weDI4MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDUuNDA2NTYwXSBwY2kg
MDAwNDowMDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIxODAwMDAwLTB4MjE5ZmZmZmZd
ClsgICAgNS40MTMzMzhdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4
MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNS40MjE3NjRdIHBj
aSAwMDA0OjAwOjA1LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjFhMDAwMDAtMHgyMWJmZmZm
Zl0KWyAgICA1LjQyODU0MV0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0g
MHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjQzNjk2N10g
cGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDUuNDQzMjIzXSBwY2kgMDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBb
aW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDQ5ODI2XSBwY2kgMDAwNDowMDowMy4wOiBCQVIgNzog
bm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS40NTYwODJdIHBjaSAwMDA0OjAw
OjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS40
NjI2ODVdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4
MTAwMF0KWyAgICA1LjQ2ODk0Ml0gcGNpIDAwMDQ6MDA6MDUuMDogQkFSIDc6IGZhaWxlZCB0byBh
c3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjQ3NTU0N10gcGNpIDAwMDQ6MDA6MDEuMDog
QkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDUuNDgxODAyXSBwY2kg
MDAwNDowMDowMS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpb
ICAgIDUuNDg4NDA2XSBwY2kgMDAwNDowMDowNS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAg
c2l6ZSAweDEwMDBdClsgICAgNS40OTQ2NjJdIHBjaSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBmYWls
ZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS41MDEyNjVdIHBjaSAwMDA0OjAw
OjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA1LjUwNzUy
MV0gcGNpIDAwMDQ6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4
MTAwMF0KWyAgICA1LjUxNDEyNl0gcGNpIDAwMDQ6MDE6MDAuMDogQkFSIDg6IGFzc2lnbmVkIFtt
ZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNTIwOTAzXSBwY2kgMDAwNDowMTowMC4w
OiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNS41MjcxNThdIHBj
aSAwMDA0OjAxOjAwLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBd
ClsgICAgNS41MzM3NjJdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4
MjAwMDAwMDAtMHgyMGZmZmZmZl0KWyAgICA1LjU0MDU0Ml0gcGNpIDAwMDQ6MDI6MDAuMDogQkFS
IDE6IGFzc2lnbmVkIFttZW0gMHgyMTAwMDAwMC0weDIxMDFmZmZmXQpbICAgIDUuNTQ3MzIxXSBw
Y2kgMDAwNDowMjowMC4wOiBCQVIgMjogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDAwODBdClsg
ICAgNS41NTM1NzddIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAyOiBmYWlsZWQgdG8gYXNzaWduIFtp
byAgc2l6ZSAweDAwODBdClsgICAgNS41NjAxODBdIHBjaSAwMDA0OjAxOjAwLjA6IFBDSSBicmlk
Z2UgdG8gW2J1cyAwMl0KWyAgICA1LjU2NTEzN10gcGNpIDAwMDQ6MDE6MDAuMDogICBicmlkZ2Ug
d2luZG93IFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQpbICAgIDUuNTcxOTIxXSBwY2kgMDAw
NDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDEtMDJdClsgICAgNS41NzcxMzVdIHBjaSAw
MDA0OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjAwMDAwMDAtMHgyMTdmZmZmZl0K
WyAgICA1LjU4MzkxMl0gcGNpIDAwMDQ6MDA6MDEuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgy
ODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1LjU5MjM0MV0gcGNp
IDAwMDQ6MDM6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMTgwMDAwMC0weDIxODAxZmZm
IDY0Yml0XQpbICAgIDUuNTk5NjQ4XSBwY2kgMDAwNDowMDowMy4wOiBQQ0kgYnJpZGdlIHRvIFti
dXMgMDNdClsgICAgNS42MDQ2MDJdIHBjaSAwMDA0OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBb
bWVtIDB4MjE4MDAwMDAtMHgyMTlmZmZmZl0KWyAgICA1LjYxMTM4MF0gcGNpIDAwMDQ6MDA6MDMu
MDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRi
aXQgcHJlZl0KWyAgICA1LjYxOTgwOF0gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDA6IGFzc2lnbmVk
IFttZW0gMHgyMWEwMDAwMC0weDIxYTdmZmZmXQpbICAgIDUuNjI2NTg5XSBwY2kgMDAwNDowNDow
MC4wOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDIxYTgwMDAwLTB4MjFhODNmZmZdClsgICAgNS42
MzMzNzFdIHBjaSAwMDA0OjA0OjAwLjA6IEJBUiAyOiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4
MDAyMF0KWyAgICA1LjYzOTYyN10gcGNpIDAwMDQ6MDQ6MDAuMDogQkFSIDI6IGZhaWxlZCB0byBh
c3NpZ24gW2lvICBzaXplIDB4MDAyMF0KWyAgICA1LjY0NjIzMF0gcGNpIDAwMDQ6MDA6MDUuMDog
UENJIGJyaWRnZSB0byBbYnVzIDA0XQpbICAgIDUuNjUxMjA3XSBwY2kgMDAwNDowMDowNS4wOiAg
IGJyaWRnZSB3aW5kb3cgW21lbSAweDIxYTAwMDAwLTB4MjFiZmZmZmZdClsgICAgNS42NTc5ODRd
IHBjaSAwMDA0OjAwOjA1LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjgwMDAwNDAwMDAwLTB4
MjgwMDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNS42NjY0MTJdIHBjaV9idXMgMDAwNDowMDog
U29tZSBQQ0kgZGV2aWNlIHJlc291cmNlcyBhcmUgdW5hc3NpZ25lZCwgdHJ5IGJvb3Rpbmcgd2l0
aCBwY2k9cmVhbGxvYwpbICAgIDUuNjc1NDQ2XSBwY2lfYnVzIDAwMDQ6MDA6IHJlc291cmNlIDQg
W21lbSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQpbICAgIDUuNjgyMzEwXSBwY2lfYnVz
IDAwMDQ6MDA6IHJlc291cmNlIDUgW21lbSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZmZmZmZiB3
aW5kb3ddClsgICAgNS42ODk4NjhdIHBjaV9idXMgMDAwNDowMTogcmVzb3VyY2UgMSBbbWVtIDB4
MjAwMDAwMDAtMHgyMTdmZmZmZl0KWyAgICA1LjY5NjEyNF0gcGNpX2J1cyAwMDA0OjAxOiByZXNv
dXJjZSAyIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAg
ICA1LjcwNDAyOV0gcGNpX2J1cyAwMDA0OjAyOiByZXNvdXJjZSAxIFttZW0gMHgyMDAwMDAwMC0w
eDIxN2ZmZmZmXQpbICAgIDUuNzEwMjg2XSBwY2lfYnVzIDAwMDQ6MDM6IHJlc291cmNlIDEgW21l
bSAweDIxODAwMDAwLTB4MjE5ZmZmZmZdClsgICAgNS43MTY1NDJdIHBjaV9idXMgMDAwNDowMzog
cmVzb3VyY2UgMiBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHByZWZd
ClsgICAgNS43MjQ0NDddIHBjaV9idXMgMDAwNDowNDogcmVzb3VyY2UgMSBbbWVtIDB4MjFhMDAw
MDAtMHgyMWJmZmZmZl0KWyAgICA1LjczMDcwNF0gcGNpX2J1cyAwMDA0OjA0OiByZXNvdXJjZSAy
IFttZW0gMHgyODAwMDA0MDAwMDAtMHgyODAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA1Ljcz
ODY1OV0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0k3XSAoZG9tYWluIDAwMDUgW2J1cyAwMC1m
Zl0pClsgICAgNS43NDQ4MzddIGFjcGkgUE5QMEEwODowNzogX09TQzogT1Mgc3VwcG9ydHMgW0V4
dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDUu
NzUzOTM4XSBhY3BpIFBOUDBBMDg6MDc6IFBDSWUgcG9ydCBzZXJ2aWNlcyBkaXNhYmxlZDsgbm90
IHJlcXVlc3RpbmcgX09TQyBjb250cm9sClsgICAgNS43NjE3NTldIGFjcGkgUE5QMEEwODowNzog
TUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4MmZmZmZmZmZmZmZmXSBm
b3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzAKWyAgICA1Ljc3NDU1M10gYWNw
aSBQTlAwQTA4OjA3OiBFQ0FNIGFyZWEgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZmZmZm
Zl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMApbICAgIDUuNzgzNDI0XSBhY3BpIFBOUDBBMDg6MDc6
IEVDQU0gYXQgW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZmZmZmZl0gZm9yIFtidXMgMDAt
ZmZdClsgICAgNS43OTE1NzZdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwNTowMApbICAgIDUu
Nzk1NjYzXSBwY2lfYnVzIDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgzMDAwMDAw
MC0weDNmZmZmZmZmIHdpbmRvd10KWyAgICA1LjgwMzEzNV0gcGNpX2J1cyAwMDA1OjAwOiByb290
IGJ1cyByZXNvdXJjZSBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmZmZmRmZmZmZmZmIHdpbmRvd10K
WyAgICA1LjgxMTMwMV0gcGNpX2J1cyAwMDA1OjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAw
LWZmXQpbICAgIDUuODE2ODA4XSBwY2kgMDAwNTowMDowMC4wOiBbMWRlZjplMTEwXSB0eXBlIDAw
IGNsYXNzIDB4MDYwMDAwClsgICAgNS44MjI4NzRdIHBjaSAwMDA1OjAwOjAxLjA6IFsxZGVmOmUx
MTFdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA1LjgyODkxN10gcGNpIDAwMDU6MDA6MDEu
MDogc3VwcG9ydHMgRDEgRDIKWyAgICA1LjgzMzE3N10gcGNpIDAwMDU6MDA6MDEuMDogUE1FIyBz
dXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApbICAgIDUuODM4OTYzXSBwY2kgMDAwNTowMDowMy4w
OiBbMWRlZjplMTEzXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAgNS44NDQ5OTddIHBjaSAw
MDA1OjAwOjAzLjA6IHN1cHBvcnRzIEQxIEQyClsgICAgNS44NDkyNTddIHBjaSAwMDA1OjAwOjAz
LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QKWyAgICA1Ljg1NTA0MF0gcGNpIDAw
MDU6MDA6MDUuMDogWzFkZWY6ZTExNV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMApbICAgIDUuODYx
MDg0XSBwY2kgMDAwNTowMDowNS4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDUuODY1MzQzXSBwY2kg
MDAwNTowMDowNS4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90ClsgICAgNS44NzEx
MjZdIHBjaSAwMDA1OjAwOjA3LjA6IFsxZGVmOmUxMTddIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAK
WyAgICA1Ljg3NzE1Nl0gcGNpIDAwMDU6MDA6MDcuMDogc3VwcG9ydHMgRDEgRDIKWyAgICA1Ljg4
MTQxNV0gcGNpIDAwMDU6MDA6MDcuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdApb
ICAgIDUuODg4Mjk1XSBwY2kgMDAwNTowMjowMC4wOiBbMTkxMjowMDE0XSB0eXBlIDAwIGNsYXNz
IDB4MGMwMzMwClsgICAgNS44OTQzMTFdIHBjaSAwMDA1OjAyOjAwLjA6IHJlZyAweDEwOiBbbWVt
IDB4MzAxMDAwMDAtMHgzMDEwMWZmZiA2NGJpdF0KWyAgICA1LjkwMTE5Ml0gcGNpIDAwMDU6MDI6
MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEM2hvdCBEM2NvbGQKWyAgICA1LjkwODQ1NV0g
cGNpIDAwMDU6MDQ6MDAuMDogWzEyNmY6MjI2M10gdHlwZSAwMCBjbGFzcyAweDAxMDgwMgpbICAg
IDUuOTE0NDY5XSBwY2kgMDAwNTowNDowMC4wOiByZWcgMHgxMDogW21lbSAweDMwMDAwMDAwLTB4
MzAwMDNmZmYgNjRiaXRdClsgICAgNS45MjE0MjZdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRnZSB3
aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAxXSBhZGRfc2l6ZSAxMDAwClsgICAg
NS45Mjk1OTRdIHBjaSAwMDA1OjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAw
LTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMjAwMDAwIGFkZF9h
bGlnbiAxMDAwMDAKWyAgICA1Ljk0MTA1OV0gcGNpIDAwMDU6MDA6MDEuMDogYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAwMV0gYWRkX3NpemUgMjAwMDAw
IGFkZF9hbGlnbiAxMDAwMDAKWyAgICA1Ljk1MTU2OV0gcGNpIDAwMDU6MDA6MDMuMDogYnJpZGdl
IHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDJdIGFkZF9zaXplIDEwMDAKWyAg
ICA1Ljk1OTczNV0gcGNpIDAwMDU6MDA6MDMuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAw
MDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAyXSBhZGRfc2l6ZSAyMDAwMDAgYWRk
X2FsaWduIDEwMDAwMApbICAgIDUuOTcxMjAwXSBwY2kgMDAwNTowMDowMy4wOiBicmlkZ2Ugd2lu
ZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBbYnVzIDAyXSBhZGRfc2l6ZSAxMDAw
MDAgYWRkX2FsaWduIDEwMDAwMApbICAgIDUuOTgxNzEwXSBwY2kgMDAwNTowMDowNS4wOiBicmlk
Z2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMTAwMApb
ICAgIDUuOTg5ODc2XSBwY2kgMDAwNTowMDowNS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEw
MDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBh
ZGRfYWxpZ24gMTAwMDAwClsgICAgNi4wMDEzNDFdIHBjaSAwMDA1OjAwOjA1LjA6IGJyaWRnZSB3
aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDIw
MDAwMCBhZGRfYWxpZ24gMTAwMDAwClsgICAgNi4wMTE4NTFdIHBjaSAwMDA1OjAwOjA3LjA6IGJy
aWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDA0XSBhZGRfc2l6ZSAxMDAw
ClsgICAgNi4wMjAwMTZdIHBjaSAwMDA1OjAwOjA3LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAw
MTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUgMjAwMDAw
IGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjAzMTQ4MV0gcGNpIDAwMDU6MDA6MDcuMDogYnJpZGdl
IHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFmZmZmZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUg
MTAwMDAwIGFkZF9hbGlnbiAxMDAwMDAKWyAgICA2LjA0MTk5Nl0gcGNpIDAwMDU6MDA6MDEuMDog
QkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDAwMDAwMC0weDMwMWZmZmZmXQpbICAgIDYuMDQ4Nzc0
XSBwY2kgMDAwNTowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAwMDAwMDAwMC0w
eDJjMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMDU3MjAwXSBwY2kgMDAwNTowMDowMy4w
OiBCQVIgODogYXNzaWduZWQgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdClsgICAgNi4wNjM5
NzhdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MmMwMDAwMjAwMDAw
LTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4wNzI0MDVdIHBjaSAwMDA1OjAwOjA1
LjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzA0MDAwMDAtMHgzMDVmZmZmZl0KWyAgICA2LjA3
OTE4M10gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyYzAwMDA0MDAw
MDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjA4NzYwOV0gcGNpIDAwMDU6MDA6
MDcuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgzMDYwMDAwMC0weDMwN2ZmZmZmXQpbICAgIDYu
MDk0Mzg3XSBwY2kgMDAwNTowMDowNy4wOiBCQVIgOTogYXNzaWduZWQgW21lbSAweDJjMDAwMDYw
MDAwMC0weDJjMDAwMDdmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMTAyODEzXSBwY2kgMDAwNTow
MDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xMDkw
NjldIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAw
eDEwMDBdClsgICAgNi4xMTU2NzJdIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBm
b3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjEyMTkyOF0gcGNpIDAwMDU6MDA6MDMuMDogQkFS
IDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjEyODUzMV0gcGNp
IDAwMDU6MDA6MDUuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAg
IDYuMTM0Nzg3XSBwY2kgMDAwNTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8g
IHNpemUgMHgxMDAwXQpbICAgIDYuMTQxMzkwXSBwY2kgMDAwNTowMDowNy4wOiBCQVIgNzogbm8g
c3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xNDc2NDZdIHBjaSAwMDA1OjAwOjA3
LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xNTQy
NTJdIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAw
MF0KWyAgICA2LjE2MDUwOF0gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDc6IGZhaWxlZCB0byBhc3Np
Z24gW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE2NzExMl0gcGNpIDAwMDU6MDA6MDUuMDogQkFS
IDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQpbICAgIDYuMTczMzY3XSBwY2kgMDAw
NTowMDowNS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQpbICAg
IDYuMTc5OTcxXSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6
ZSAweDEwMDBdClsgICAgNi4xODYyMjddIHBjaSAwMDA1OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQg
dG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdClsgICAgNi4xOTI4MzBdIHBjaSAwMDA1OjAwOjAx
LjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0KWyAgICA2LjE5OTA4Nl0g
cGNpIDAwMDU6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAw
MF0KWyAgICA2LjIwNTY5MF0gcGNpIDAwMDU6MDA6MDEuMDogUENJIGJyaWRnZSB0byBbYnVzIDAx
XQpbICAgIDYuMjEwNjQ0XSBwY2kgMDAwNTowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAw
eDMwMDAwMDAwLTB4MzAxZmZmZmZdClsgICAgNi4yMTc0MjJdIHBjaSAwMDA1OjAwOjAxLjA6ICAg
YnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmMwMDAwMWZmZmZmIDY0Yml0IHBy
ZWZdClsgICAgNi4yMjU4NTFdIHBjaSAwMDA1OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVt
IDB4MzAyMDAwMDAtMHgzMDIwMWZmZiA2NGJpdF0KWyAgICA2LjIzMzE1N10gcGNpIDAwMDU6MDA6
MDMuMDogUENJIGJyaWRnZSB0byBbYnVzIDAyXQpbICAgIDYuMjM4MTEyXSBwY2kgMDAwNTowMDow
My4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdClsgICAgNi4y
NDQ4ODldIHBjaSAwMDA1OjAwOjAzLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMjAw
MDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4yNTMzMTVdIHBjaSAwMDA1OjAw
OjA1LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwM10KWyAgICA2LjI1ODI3MF0gcGNpIDAwMDU6MDA6
MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDQwMDAwMC0weDMwNWZmZmZmXQpbICAgIDYu
MjY1MDQ4XSBwY2kgMDAwNTowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDQw
MDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMjczNDc2XSBwY2kgMDAwNTow
NDowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDMwNjAwMDAwLTB4MzA2MDNmZmYgNjRiaXRd
ClsgICAgNi4yODA3ODldIHBjaSAwMDA1OjAwOjA3LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwNF0K
WyAgICA2LjI4NTc0NF0gcGNpIDAwMDU6MDA6MDcuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgz
MDYwMDAwMC0weDMwN2ZmZmZmXQpbICAgIDYuMjkyNTIyXSBwY2kgMDAwNTowMDowNy4wOiAgIGJy
aWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDYwMDAwMC0weDJjMDAwMDdmZmZmZiA2NGJpdCBwcmVm
XQpbICAgIDYuMzAwOTQ5XSBwY2lfYnVzIDAwMDU6MDA6IHJlc291cmNlIDQgW21lbSAweDMwMDAw
MDAwLTB4M2ZmZmZmZmYgd2luZG93XQpbICAgIDYuMzA3ODEzXSBwY2lfYnVzIDAwMDU6MDA6IHJl
c291cmNlIDUgW21lbSAweDJjMDAwMDAwMDAwMC0weDJmZmZkZmZmZmZmZiB3aW5kb3ddClsgICAg
Ni4zMTUzNzJdIHBjaV9idXMgMDAwNTowMTogcmVzb3VyY2UgMSBbbWVtIDB4MzAwMDAwMDAtMHgz
MDFmZmZmZl0KWyAgICA2LjMyMTYyN10gcGNpX2J1cyAwMDA1OjAxOiByZXNvdXJjZSAyIFttZW0g
MHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0KWyAgICA2LjMyOTUzM10g
cGNpX2J1cyAwMDA1OjAyOiByZXNvdXJjZSAxIFttZW0gMHgzMDIwMDAwMC0weDMwM2ZmZmZmXQpb
ICAgIDYuMzM1Nzg4XSBwY2lfYnVzIDAwMDU6MDI6IHJlc291cmNlIDIgW21lbSAweDJjMDAwMDIw
MDAwMC0weDJjMDAwMDNmZmZmZiA2NGJpdCBwcmVmXQpbICAgIDYuMzQzNjk0XSBwY2lfYnVzIDAw
MDU6MDM6IHJlc291cmNlIDEgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZmZmZdClsgICAgNi4zNDk5
NTBdIHBjaV9idXMgMDAwNTowMzogcmVzb3VyY2UgMiBbbWVtIDB4MmMwMDAwNDAwMDAwLTB4MmMw
MDAwNWZmZmZmIDY0Yml0IHByZWZdClsgICAgNi4zNTc4NTVdIHBjaV9idXMgMDAwNTowNDogcmVz
b3VyY2UgMSBbbWVtIDB4MzA2MDAwMDAtMHgzMDdmZmZmZl0KWyAgICA2LjM2NDExMV0gcGNpX2J1
cyAwMDA1OjA0OiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDA2MDAwMDAtMHgyYzAwMDA3ZmZmZmYg
NjRiaXQgcHJlZl0KWyAgICA2LjM3MjIyOV0gaW9tbXU6IERlZmF1bHQgZG9tYWluIHR5cGU6IFRy
YW5zbGF0ZWQgClsgICAgNi4zNzcxMzRdIHBjaSAwMDBkOjAxOjAwLjA6IHZnYWFyYjogVkdBIGRl
dmljZSBhZGRlZDogZGVjb2Rlcz1pbyttZW0sb3ducz1ub25lLGxvY2tzPW5vbmUKWyAgICA2LjM4
NTQ4M10gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBWR0EgZGV2aWNlIGFkZGVkOiBkZWNvZGVz
PWlvK21lbSxvd25zPW5vbmUsbG9ja3M9bm9uZQpbICAgIDYuMzkzODI2XSBwY2kgMDAwZDowMTow
MC4wOiB2Z2FhcmI6IGJyaWRnZSBjb250cm9sIHBvc3NpYmxlClsgICAgNi4zOTk1NjFdIHBjaSAw
MDA0OjAyOjAwLjA6IHZnYWFyYjogYnJpZGdlIGNvbnRyb2wgcG9zc2libGUKWyAgICA2LjQwNTI5
OF0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBzZXR0aW5nIGFzIGJvb3QgZGV2aWNlIChWR0Eg
bGVnYWN5IHJlc291cmNlcyBub3QgYXZhaWxhYmxlKQpbICAgIDYuNDE0MTU4XSB2Z2FhcmI6IGxv
YWRlZApbICAgIDYuNDE2OTM4XSBTQ1NJIHN1YnN5c3RlbSBpbml0aWFsaXplZApbICAgIDYuNDIw
NjgyXSBBQ1BJOiBidXMgdHlwZSBVU0IgcmVnaXN0ZXJlZApbICAgIDYuNDI0Njk2XSB1c2Jjb3Jl
OiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmZzClsgICAgNi40MzAxODBdIHVz
YmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgaHViClsgICAgNi40MzU0OTVd
IHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGRldmljZSBkcml2ZXIgdXNiClsgICAgNi40NDA1NTVd
IHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAxIHJlZ2lzdGVyZWQKWyAgICA2LjQ0NTUwOF0g
cHBzX2NvcmU6IFNvZnR3YXJlIHZlci4gNS4zLjYgLSBDb3B5cmlnaHQgMjAwNS0yMDA3IFJvZG9s
Zm8gR2lvbWV0dGkgPGdpb21ldHRpQGxpbnV4Lml0PgpbICAgIDYuNDU0NjMwXSBQVFAgY2xvY2sg
c3VwcG9ydCByZWdpc3RlcmVkClsgICAgNi40NTg2NjNdIFJlZ2lzdGVyZWQgZWZpdmFycyBvcGVy
YXRpb25zClsgICAgNi40NjMzNjVdIGNsb2Nrc291cmNlOiBTd2l0Y2hlZCB0byBjbG9ja3NvdXJj
ZSBhcmNoX3N5c19jb3VudGVyClsgICAgNi42NDQ4MjddIHBucDogUG5QIEFDUEkgaW5pdApbICAg
IDYuNjQ5MjQ5XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzYmZmZjAwMDAwMDAtMHgzYmZmZmZmZmZm
ZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNjU3MTYwXSBzeXN0ZW0gMDA6MDA6
IFttZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUg
cmVzZXJ2ZWQKWyAgICA2LjY2NTQxM10gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MjNmZmYwMDAwMDAw
LTB4MjNmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA2LjY3MzMxOV0g
c3lzdGVtIDAwOjAwOiBbbWVtIDB4MjdmZmYwMDAwMDAwLTB4MjdmZmZmZmZmZmZmIHdpbmRvd10g
aGFzIGJlZW4gcmVzZXJ2ZWQKWyAgICA2LjY4MTIyNl0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MmJm
ZmYwMDAwMDAwLTB4MmJmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkClsg
ICAgNi42ODk0ODBdIHN5c3RlbSAwMDowMDogW21lbSAweDJmZmZmMDAwMDAwMC0weDJmZmZmZmZm
ZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZApbICAgIDYuNjk3NzMzXSBzeXN0ZW0g
MDA6MDA6IFttZW0gMHg3YmZmZjAwMDAwMDAtMHg3YmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVl
biByZXNlcnZlZApbICAgIDYuNzA1NjQwXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg3ZmZmZjAwMDAw
MDAtMHg3ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzEzNTQ2
XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2M2ZmZjAwMDAwMDAtMHg2M2ZmZmZmZmZmZmYgd2luZG93
XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzIxNDUyXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2
N2ZmZjAwMDAwMDAtMHg2N2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAg
IDYuNzI5MzU5XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg2YmZmZjAwMDAwMDAtMHg2YmZmZmZmZmZm
ZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZApbICAgIDYuNzM3MjY2XSBzeXN0ZW0gMDA6MDA6
IFttZW0gMHg2ZmZmZjAwMDAwMDAtMHg2ZmZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNl
cnZlZApbICAgIDYuNzQ1MTcyXSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgz
M2ZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQKWyAgICA2Ljc1MzQyNV0g
c3lzdGVtIDAwOjAwOiBbbWVtIDB4MzdmZmYwMDAwMDAwLTB4MzdmZmZmZmZmZmZmIHdpbmRvd10g
Y291bGQgbm90IGJlIHJlc2VydmVkClsgICAgNi43NjE2ODddIHBucDogUG5QIEFDUEk6IGZvdW5k
IDEgZGV2aWNlcwpbICAgIDYuNzY3NDkzXSBORVQ6IFJlZ2lzdGVyZWQgcHJvdG9jb2wgZmFtaWx5
IDIKWyAgICA2Ljc3MjAyN10gdGNwX2xpc3Rlbl9wb3J0YWRkcl9oYXNoIGhhc2ggdGFibGUgZW50
cmllczogMTYzODQgKG9yZGVyOiA2LCAyNjIxNDQgYnl0ZXMsIGxpbmVhcikKWyAgICA2Ljc4MDkw
N10gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUgZW50cmllczogMjYyMTQ0IChvcmRlcjogOSwg
MjA5NzE1MiBieXRlcywgbGluZWFyKQpbICAgIDYuNzg5OTE5XSBUQ1AgYmluZCBoYXNoIHRhYmxl
IGVudHJpZXM6IDY1NTM2IChvcmRlcjogOCwgMTA0ODU3NiBieXRlcywgbGluZWFyKQpbICAgIDYu
Nzk3Nzg0XSBUQ1A6IEhhc2ggdGFibGVzIGNvbmZpZ3VyZWQgKGVzdGFibGlzaGVkIDI2MjE0NCBi
aW5kIDY1NTM2KQpbICAgIDYuODA0NDU1XSBVRFAgaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAo
b3JkZXI6IDcsIDUyNDI4OCBieXRlcywgbGluZWFyKQpbICAgIDYuODExNjY0XSBVRFAtTGl0ZSBo
YXNoIHRhYmxlIGVudHJpZXM6IDE2Mzg0IChvcmRlcjogNywgNTI0Mjg4IGJ5dGVzLCBsaW5lYXIp
ClsgICAgNi44MTk0MjldIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMQpbICAgIDYu
ODIzOTU4XSBSUEM6IFJlZ2lzdGVyZWQgbmFtZWQgVU5JWCBzb2NrZXQgdHJhbnNwb3J0IG1vZHVs
ZS4KWyAgICA2LjgyOTg2OV0gUlBDOiBSZWdpc3RlcmVkIHVkcCB0cmFuc3BvcnQgbW9kdWxlLgpb
ICAgIDYuODM0NTYzXSBSUEM6IFJlZ2lzdGVyZWQgdGNwIHRyYW5zcG9ydCBtb2R1bGUuClsgICAg
Ni44MzkyNTddIFJQQzogUmVnaXN0ZXJlZCB0Y3AgTkZTdjQuMSBiYWNrY2hhbm5lbCB0cmFuc3Bv
cnQgbW9kdWxlLgpbICAgIDYuODQ1NzMzXSBwY2kgMDAwZDowMTowMC4xOiBEMCBwb3dlciBzdGF0
ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDYuODUyMTM0XSBwY2kgMDAwZDowMTowMC4y
OiBEMCBwb3dlciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMApbICAgIDYuODU4NTEyXSBw
Y2kgMDAwZDowMTowMC4yOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAgICA2Ljg2
NDIxMl0gcGNpIDAwMGQ6MDE6MDAuMzogRDAgcG93ZXIgc3RhdGUgZGVwZW5kcyBvbiAwMDBkOjAx
OjAwLjAKWyAgICA2Ljg3MDYxNF0gcGNpIDAwMDQ6MDM6MDAuMDogZW5hYmxpbmcgZGV2aWNlICgw
MDAwIC0+IDAwMDIpClsgICAgNi44NzYzMDJdIHBjaSAwMDA1OjAyOjAwLjA6IGVuYWJsaW5nIGRl
dmljZSAoMDAwMCAtPiAwMDAyKQpbICAgIDYuODgxOTc0XSBQQ0k6IENMUyAxMjggYnl0ZXMsIGRl
ZmF1bHQgNjQKWyAgICA2Ljg4NzMzMF0gaHcgcGVyZmV2ZW50czogZW5hYmxlZCB3aXRoIGFybXY4
X3BtdXYzXzAgUE1VIGRyaXZlciwgNyBjb3VudGVycyBhdmFpbGFibGUKWyAgICA2Ljg5Njc1NV0g
d29ya2luZ3NldDogdGltZXN0YW1wX2JpdHM9NDIgbWF4X29yZGVyPTIzIGJ1Y2tldF9vcmRlcj0w
ClsgICAgNi45MDQ5NjZdIE5GUzogUmVnaXN0ZXJpbmcgdGhlIGlkX3Jlc29sdmVyIGtleSB0eXBl
ClsgICAgNi45MTAwMTldIEtleSB0eXBlIGlkX3Jlc29sdmVyIHJlZ2lzdGVyZWQKWyAgICA2Ljkx
NDE5M10gS2V5IHR5cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQKWyAgICA2LjkxODQ4M10gS2V5IHR5
cGUgY2lmcy5pZG1hcCByZWdpc3RlcmVkClsgICAgNi45MzcxODVdIHhvcjogbWVhc3VyaW5nIHNv
ZnR3YXJlIGNoZWNrc3VtIHNwZWVkClsgICAgNi45NDI5NzNdICAgIDhyZWdzICAgICAgICAgICA6
ICA5NzkzIE1CL3NlYwpbICAgIDYuOTQ4MTU3XSAgICAzMnJlZ3MgICAgICAgICAgOiAxMTc1OCBN
Qi9zZWMKWyAgICA2Ljk1MzIwOF0gICAgYXJtNjRfbmVvbiAgICAgIDogMTM5NjIgTUIvc2VjClsg
ICAgNi45NTc1NTVdIHhvcjogdXNpbmcgZnVuY3Rpb246IGFybTY0X25lb24gKDEzOTYyIE1CL3Nl
YykKWyAgICA2Ljk2MzAzOV0gQmxvY2sgbGF5ZXIgU0NTSSBnZW5lcmljIChic2cpIGRyaXZlciB2
ZXJzaW9uIDAuNCBsb2FkZWQgKG1ham9yIDI0OSkKWyAgICA2Ljk3MDQyNV0gaW8gc2NoZWR1bGVy
IG1xLWRlYWRsaW5lIHJlZ2lzdGVyZWQKWyAgICA2Ljk3NDk0NV0gaW8gc2NoZWR1bGVyIGt5YmVy
IHJlZ2lzdGVyZWQKWyAgICA2Ljk3OTY0Ml0gZ3Bpby1kd2FwYiBBUE1DMEQwNzowMjogbm8gSVJR
IGZvciBwb3J0MApbICAgIDYuOTg1NDIxXSBpbnB1dDogUG93ZXIgQnV0dG9uIGFzIC9kZXZpY2Vz
L0xOWFNZU1RNOjAwL0xOWFNZQlVTOjAwL1BOUDBDMEM6MDAvaW5wdXQvaW5wdXQwClsgICAgNi45
OTM4MDNdIEFDUEk6IFBvd2VyIEJ1dHRvbiBbUFdSQl0KWyAgICA3LjAwMDYwNV0gR0hFUzogQVBF
SSBmaXJtd2FyZSBmaXJzdCBtb2RlIGlzIGVuYWJsZWQgYnkgQVBFSSBiaXQuClsgICAgNy4wMDY4
MjJdIEVJTko6IEVycm9yIElOSmVjdGlvbiBpcyBpbml0aWFsaXplZC4KWyAgICA3LjAxMTU1NF0g
QUNQSSBHVERUOiBmb3VuZCAxIFNCU0EgZ2VuZXJpYyBXYXRjaGRvZyhzKS4KWyAgICA3LjAxNzU4
N10gYXN0IDAwMDQ6MDI6MDAuMDogW2RybV0gcGxhdGZvcm0gaGFzIG5vIElPIHNwYWNlLCB0cnlp
bmcgTU1JTwpbICAgIDcuMDI0Mzc0XSBhc3QgMDAwNDowMjowMC4wOiBbZHJtXSBVc2luZyBQMkEg
YnJpZGdlIGZvciBjb25maWd1cmF0aW9uClsgICAgNy4wMzA4OTNdIGFzdCAwMDA0OjAyOjAwLjA6
IFtkcm1dIEFTVCAyNTAwIGRldGVjdGVkClsgICAgNy4wMzU5MzhdIGFzdCAwMDA0OjAyOjAwLjA6
IFtkcm1dIEFuYWxvZyBWR0Egb25seQpbICAgIDcuMDQwODEzXSBhc3QgMDAwNDowMjowMC4wOiBb
ZHJtXSBkcmFtIE1DTEs9ODAwIE1oeiB0eXBlPTggYnVzX3dpZHRoPTE2ClsgICAgNy4wNDc2ODZd
IFtUVE1dIFpvbmUgIGtlcm5lbDogQXZhaWxhYmxlIGdyYXBoaWNzIG1lbW9yeTogMTYyNTExNDQg
S2lCClsgICAgNy4wNTQyOTBdIFtUVE1dIFpvbmUgICBkbWEzMjogQXZhaWxhYmxlIGdyYXBoaWNz
IG1lbW9yeTogMjA5NzE1MiBLaUIKWyAgICA3LjA2MDgwNl0gW1RUTV0gSW5pdGlhbGl6aW5nIHBv
b2wgYWxsb2NhdG9yClsgICAgNy4wNjUxNTVdIFtUVE1dIEluaXRpYWxpemluZyBETUEgcG9vbCBh
bGxvY2F0b3IKWyAgICA3LjA3MDEwNF0gW2RybV0gSW5pdGlhbGl6ZWQgYXN0IDAuMS4wIDIwMTIw
MjI4IGZvciAwMDA0OjAyOjAwLjAgb24gbWlub3IgMApbICAgIDcuMDk0NTc1XSBDb25zb2xlOiBz
d2l0Y2hpbmcgdG8gY29sb3VyIGZyYW1lIGJ1ZmZlciBkZXZpY2UgMTI4eDQ4ClsgICAgNy4xMDMw
MjZdIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIGZiMDogYXN0ZHJtZmIgZnJhbWUgYnVmZmVyIGRl
dmljZQpbICAgIDcuMTIzODg4XSBicmQ6IG1vZHVsZSBsb2FkZWQKWyAgICA3LjEzMTQ3NF0gbG9v
cDogbW9kdWxlIGxvYWRlZApbICAgIDcuMTM1MTA1XSBudm1lIG52bWUwOiBwY2kgZnVuY3Rpb24g
MDAwNTowNDowMC4wClsgICAgNy4xNDAwMTldIGlnYjogSW50ZWwoUikgR2lnYWJpdCBFdGhlcm5l
dCBOZXR3b3JrIERyaXZlcgpbICAgIDcuMTQxOTcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NTEyIGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjE0NTQxM10gaWdiOiBDb3B5cmlnaHQg
KGMpIDIwMDctMjAxNCBJbnRlbCBDb3Jwb3JhdGlvbi4KWyAgICA3LjE1MTMxOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTUxMiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4xNTEzMjFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT0yMDQ4IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjE2OTMyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTIwNDggZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuMTgxNDkzXSBudm1lIG52bWUwOiBtaXNzaW5nIG9yIGludmFsaWQgU1VC
TlFOIGZpZWxkLgpbICAgIDcuMTg4NjUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
MjU2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjE5NTM5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTI1NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4xOTk4MDZdIHBwcyBwcHMwOiBu
ZXcgUFBTIHNvdXJjZSBwdHAwClsgICAgNy4yMDEzMTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcuMjA1MzQwXSBpZ2IgMDAw
NDowNDowMC4wOiBhZGRlZCBQSEMgb24gZXRoMApbICAgIDcuMjExNzM3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjIxMTg1
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9
MTEwClsgICAgNy4yMTYyNThdIGlnYiAwMDA0OjA0OjAwLjA6IEludGVsKFIpIEdpZ2FiaXQgRXRo
ZXJuZXQgTmV0d29yayBDb25uZWN0aW9uClsgICAgNy4yMjI2ODZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcuMjIyODA1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAK
WyAgICA3LjIyOTExOF0gaWdiIDAwMDQ6MDQ6MDAuMDogZXRoMDogKFBDSWU6Mi41R2IvczpXaWR0
aCB4MSkgMDA6MzA6NjQ6M2I6NTA6NTIKWyAgICA3LjIzNTk4MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy4yNDI0NjhdIGln
YiAwMDA0OjA0OjAwLjA6IGV0aDA6IFBCQSBObzogMDAwMzAwLTAwMApbICAgIDcuMjQ4OTU1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAK
WyAgICA3LjI1NTk2Ml0gaWdiIDAwMDQ6MDQ6MDAuMDogVXNpbmcgTVNJLVggaW50ZXJydXB0cy4g
NCByeCBxdWV1ZShzKSwgNCB0eCBxdWV1ZShzKQpbICAgIDcuMjYyMzkwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjI2MjUw
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9
MTEwClsgICAgNy4yNjc1NzJdIGlnYnZmOiBJbnRlbChSKSBHaWdhYml0IFZpcnR1YWwgRnVuY3Rp
b24gTmV0d29yayBEcml2ZXIKWyAgICA3LjI3Mzk1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy4yODE1MDddIGlnYnZmOiBD
b3B5cmlnaHQgKGMpIDIwMDkgLSAyMDEyIEludGVsIENvcnBvcmF0aW9uLgpbICAgIDcuMjgxNTIw
XSBpNDBlOiBJbnRlbChSKSBFdGhlcm5ldCBDb25uZWN0aW9uIFhMNzEwIE5ldHdvcmsgRHJpdmVy
ClsgICAgNy4yODgwNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MTk0MzA0IGZs
YWdzPWNjMCBhdHRyPTExMApbICAgIDcuMjk0MzY2XSBpNDBlOiBDb3B5cmlnaHQgKGMpIDIwMTMg
LSAyMDE5IEludGVsIENvcnBvcmF0aW9uLgpbICAgIDcuMjk0NTIyXSBpNDBlIDAwMDA6MDE6MDAu
MDogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAgNy4zMDA2MjRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcu
MzI1Mzg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9ODE5MiBmbGFncz1jYzAgYXR0
cj0wClsgICAgNy4zMjU3NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MTk0MzA0
IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcuMzMxNDY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4zMzcxOTldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcuMzQz
NjMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgNy4zNDk3NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MTk0MzA0IGZs
YWdzPWNjMCBhdHRyPTExMApbICAgIDcuMzU2MDUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4zNTYwNTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjM2MjA0N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsg
ICAgNy4zNjIxNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MTk0MzA0IGZsYWdz
PWNjMCBhdHRyPTExMApbICAgIDcuMzY4NDc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4zNjg0NzldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjM3NDQ3NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAg
Ny4zNzQ1OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MTk0MzA0IGZsYWdzPWNj
MCBhdHRyPTExMApbICAgIDcuMzgwOTA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4zODY5MDBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMApbICAgIDcuMzkyODk1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy4z
OTk0NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBh
dHRyPTExMApbICAgIDcuNDA1NzUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy40MDU3NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQxMTc0OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy40MTE4
NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRy
PTExMApbICAgIDcuNDE3NzQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgNy40MTc3NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQyNDE3NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy40MzA2MDRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjQzMDYwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuNDM2NzE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDE5
NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjQ0MzAyOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDQzMDMxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy40NDkw
MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRy
PTExMApbICAgIDcuNDQ5MTQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDE5NDMw
NCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjQ1NTQ1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDYxNDUwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjQ2
MTU3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0
dHI9MTEwClsgICAgNy40Njc0NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQ3Mzg3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwClsgICAgNy40ODAzMDRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjQ4MDMw
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDcuNDg2NDE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDE5NDMwNCBmbGFn
cz1jYzAgYXR0cj0xMTAKWyAgICA3LjQ5MjI5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNDk4NzI1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTAKWyAgICA3LjQ5ODg0OF0g
bnZtZSBudm1lMDogYWxsb2NhdGVkIDY0IE1pQiBob3N0IG1lbW9yeSBidWZmZXIuClsgICAgNy41
MDQ3MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA3LjUyMzQ3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTE2Mzg0IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA3LjUyOTE0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNTM1NTcyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNTM1NTc2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NjU1MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcu
NTQyMDA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgNy41NDc5OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT02NTUzNiBm
bGFncz1jYzAgYXR0cj0wClsgICAgNy41NTQ0MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjU2MDg2MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTE2Mzg0IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjU2Njg1M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcu
NTczMjgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDcuNTc5Mjc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgNy41ODUyNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT02NTUzNiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy41OTE3MDNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjU5NzY5OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3
LjYwNDEyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDcuNjA5Nzc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9MTYzODQg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjE1NzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42MjE4NTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT0xNjM4NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42Mjc4NDddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3
LjYzMzkzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTY1NTM2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA3LjY0MDAxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjQwMDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42NDYwMTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT02NTUzNiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42NTIwOTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3
LjY1ODA5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTE2Mzg0IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA3LjY2NDE2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjcwMTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjcwMTY2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NjU1MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNjc2MjQ3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
Ny42ODIyNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT02NTUzNiBmbGFncz1jYzAg
YXR0cj0wClsgICAgNy42ODIyNDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT0xNjM4
NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy42ODgzMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjY5NDMxN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTE2Mzg0IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjY5NDMyMV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjcwMDQwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDcuNzA2NDAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NjU1
MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzEyNDc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43MTg0NzVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT0xNjM4NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43MjQ1NTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA3LjczMDU0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTE2Mzg0IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA3LjczMDU1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTY1
NTM2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjczNjYzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzQyNjI1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NjU1MzYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzQyNjMx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDcuNzQ4NjIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgNy43NTQ3MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT0x
NjM4NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43NTQ3MDZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT02NTUzNiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43NjA3MDBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljc2Njc4
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA3Ljc3Mjc3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDcuNzc4ODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
MTYzODQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuNzg0OTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43OTA5MzNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT0xNjM4NCBmbGFncz1jYzAgYXR0cj0wClsgICAgNy43OTA5
MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT02NTUzNiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgNy43OTcwMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA3LjgwMzA5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTY1NTM2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljg5OTk0NF0gbnZtZSBudm1lMDogOC8wLzAg
ZGVmYXVsdC9yZWFkL3BvbGwgcXVldWVzClsgICAgNy45MDU5MTFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3LjkwNTkxM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuOTcx
NDM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgNy45Nzc0MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA3Ljk4MzQzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDcuOTg5NDM2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgNy45OTU0MzVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA3Ljk5NTQ2
Ml0gIG52bWUwbjE6IHAxIHAyIHAzClsgICAgOC4wMDE0MzNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjAwMTQzNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMDAxNDM2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOC4wMDE0MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA4LjAwMTQzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMDM0NDU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4wNDA0NTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjA0NjQ1MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguMDUyNDU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC4wNTg0NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjA2NDQ0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMDcwNDQzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4wNzY0NDBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
LjA4MjQzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguMDg4NDMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC4wOTQ0MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjEwMDQyNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTA2NDIwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4x
MTI0MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4LjExODQxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDguMTI0NDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4xMzA0MTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjEzNjQwN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTQy
NDAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC4xNDg0MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4LjE1NDM5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTYwMzkyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4xNjYzODhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjE3MjM4
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguMTc4MzgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC4xODQzNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjE5MDM3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMTk2MzcxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yMDIzNjdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4LjIwODM2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguMjE0MzYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yMjAzNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjIyNjM1M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjMyMzUxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC4yMzgzNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4LjI0NDM0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjUwMzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yNTYzMzZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjI2MjMzMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
MjY4MzI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC4yNzQzMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4LjI4MDMyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMjg2MzE1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4yOTIzMTFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjI5
ODMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguMzA0MzEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC4zMTAzMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjMxNjMwMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzIyMjk3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zMjgy
OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA4LjMzNDI4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDguMzQwMjg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zNDYyNzldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjM1MjI3NV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzU4Mjcw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOC4zNjQyNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA4LjM3MDI2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguMzc2MjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC4zODIyNTRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjM4ODI0OV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguMzk0MjQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC40MDAyNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQwNjIzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDEyMjMyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40MTgyMjddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
LjQyNDIyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguNDMwMjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC40MzYyMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQ0MjIwOV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDQ4MjA2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40
NTQyMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4LjQ2MDE5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDguNDY2MTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC40NzIxODddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjQ3ODE4Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNDg0
MTc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC40OTAxNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4LjQ5NjE2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTAyMTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41MDgxNTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjUxNDE1
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguNTIwMTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC41MjYxNDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjUzMjE0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTM4MTM3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41NDQxMzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4LjU1MDEyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguNTU2MTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41NjIxMTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjU2ODExNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTc0MTEwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC41ODAxMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4LjU4NjEwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNTkyMDk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC41OTgwOTNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjYwNDA4OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
NjEwMDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC42MTYwNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4LjYyMjA3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNjI4MDY5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42MzQwNjRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjY0
MDA2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguNjQ2MDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC42NTIwNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjY1ODA0Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNjY0MDQyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42NzAw
MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA4LjY3NjAzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDguNjgyMDI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC42ODgwMjRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjY5NDAxOV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzAwMDE1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOC43MDYwMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA4LjcxMjAwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzE4MDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43MjM5OTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjcyOTk5MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDguNzM1OTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOC43NDE5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljc0Nzk3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzUzOTcyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43NTk5NjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4
Ljc2NTk2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDguNzcxOTU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOC43Nzc5NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljc4Mzk1MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguNzg5OTQ1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC43
OTU5NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA4LjgwMTkzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDguODA3OTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44MTM5MjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjgxOTkyNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODI1
OTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOC44MzE5MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA4LjgzNzkxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODQzOTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44NDk5MDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljg1NTg5
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDguODYxODkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOC44Njc4ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljg3Mzg4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguODc5ODgwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC44ODU4NzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA4Ljg5MTg3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDguODk3ODY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45MDM4NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4LjkwOTg1N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTE1ODUzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OC45MjE4NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA4LjkyNzg0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTMzODM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45Mzk4MzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk0NTgzMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDgu
OTUxODI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOC45NTc4MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk2MzgxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDguOTY5ODEyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOC45NzU4MDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk4
MTgwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDguOTg3Nzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOC45OTM3OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA4Ljk5OTc4OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDA1Nzg0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wMTE3
NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5LjAxNzc3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuMDIzNzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wMjk3NjVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjAzNTc2MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDQxNzU1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS4wNDc3NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5LjA1Mzc0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDU5NzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4wNjU3MzddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjA3MTczMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuMDc3NzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS4wODM3MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjA4OTcxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMDk1NzE0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4xMDE3MTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
LjEwNzcwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuMTEzNzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS4xMTk2OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjEyNTY5MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTMxNjg4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4x
Mzc2ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA5LjE0MzY3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuMTQ5Njc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4xNTU2NjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjE2MTY2NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTY3
NjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS4xNzM2NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5LjE3OTY1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMTg1NjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4xOTE2NDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjE5NzYz
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuMjAzNjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS4yMDk2MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjIxNTYyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjIxNjE5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yMjc2MTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5LjIzMzYwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuMjM5NjA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yNDU2MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjI1MTU5Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjU3NTkxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS4yNjM1ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5LjI2OTU4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMjc1NTc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4yODE1NzJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjI4NzU2OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
MjkzNTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS4yOTk1NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5LjMwNTU1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzExNTUwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4zMTc1NDVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjMy
MzU0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDkuMzI5NTQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOS4zMzU1MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjM0MTUzNF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzQ3NTMwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4zNTM1
MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5LjM1OTUyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuMzY1NTE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS4zNzE1MTFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjM3NzUwNl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuMzgzNTAy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS4zODk0OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5LjM5NTQ5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDAxNDkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40MDc0ODddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQxMzQ4Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuNDE5NDc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS40MjU0NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQzMTQ2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDM3NDYzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40NDM0NjBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
LjQ0OTQ1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuNDU1NDUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS40NjE0NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjQ2NzQ0MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNDczNDM2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40
Nzk0MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA5LjQ4NTQyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuNDkxNDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS40OTc0MThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjUwMzQxNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTA5
NDA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS41MTU0MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5LjUyMTQwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTI3Mzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41MzMzOTFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjUzOTM4
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuNTQ1MzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS41NTEzNzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjU1NzM3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTYzMzcyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41NjkzNjdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5LjU3NTM2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuNTgxMzU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS41ODczNTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjU5MzM0OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNTk5MzQzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS42MDUzMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5LjYxMTMzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjE3MzI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42MjMzMjRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjYyOTMxOV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
NjM1MzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS42NDEzMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5LjY0NzMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjUzMzAxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42NTkyOTddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjY2
NTI5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgIDkuNjcxMjg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAgOS42NzcyODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjY4MzI3OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNjg5MjczXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS42OTUy
NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgICA5LjcwMTI2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgIDkuNzA3MjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43MTMyNTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjcxOTI0OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzI1MjQ1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAgOS43MzEyNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgICA5LjczNzIzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzQzMjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43NDkyMjhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljc1NTIyM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
IDkuNzYxMjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAgOS43NjcyMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljc3MzIwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuNzc5MjA1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS43ODUyMDBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5
Ljc5MTE5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgIDkuNzk3MTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAgOS44MDMxODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjgwOTE4Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODE1MTc3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44
MjExNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgICA5LjgyNzE2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgIDkuODMzMTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44MzkxNThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljg0NTE1M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODUx
MTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAgOS44NTcxNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgICA5Ljg2MzE0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuODY5MTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS44NzUxMzBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljg4MTEy
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgIDkuODg3MTIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAgOS44OTMxMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljg5OTExMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTA1MTA3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45MTExMDVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
ICA5LjkxNzEwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgIDkuOTIzMDk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45MjkwOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5LjkzNTA4OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTQxMDg0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAg
OS45NDcwNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgICA5Ljk1MzA3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTU5MDcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAgOS45NjUwNjZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgICA5Ljk3MTA2MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDku
OTc3MDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAgOS45ODMwNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgICA5Ljk4OTA0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgIDkuOTk1MDQzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wMDEwMzhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjAw
NzAzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuMDEzMDI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC4wMTkwMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjAyNTAxOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDMxMDE1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wMzcw
MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjA0MzAwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuMDQ5MDAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wNTQ5OTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjA2MDk5MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDY2OTg5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC4wNzI5ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjA3ODk4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMDg0OTc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4wOTA5NzFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjA5Njk2Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuMTAyOTYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC4xMDg5NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjExNDk1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTIwOTQ3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4xMjY5NDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEw
LjEzMjkzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTAuMTM4OTMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMC4xNDQ5MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjE1MDkyNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTU2OTIwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4x
NjI5MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjE2ODkxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuMTc0OTA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4xODA5MDJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjE4Njg5N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMTky
ODkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC4xOTg4ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjIwNDg4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjEwODc5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yMTY4NzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjIyMjg3
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuMjI4ODY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC4yMzQ4NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjI0MDg1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjQ2ODUyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yNTI4NDdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjI1ODg0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuMjY0ODM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4yNzA4MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjI3NjgyOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMjgyODIzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC4yODg4MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjI5NDgxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzAwODA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zMDY4MDVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjMxMjgwMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAu
MzE4Nzk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMC4zMjQ3OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEwLjMzMDc5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzM2Nzg0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zNDI3ODBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjM0
ODc4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuMzU0Nzc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC4zNjA3NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjM2Njc2OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuMzcyNzY0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zNzg3
NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjM4NDc1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuMzkwNzUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC4zOTY3NDVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQwMjc0MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDA4NzM2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC40MTQ3MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjQyMDcyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDI2NzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC40MzI3MjBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQzODcxNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuNDQ0NzExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC40NTA3MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQ1NjcwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDYyNjk3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC40Njg2OTJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEw
LjQ3NDY4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTAuNDgwNjgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMC40ODY2NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjQ5MjY3M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNDk4NjY4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41
MDQ2NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjUxMDY1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuNTE2NjU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41MjI2NTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjUyODY0NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTM0
NjQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC41NDA2MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjU0NjYzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTUyNjI2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41NTg2MjNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjU2NDYx
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuNTcwNjE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC41NzY2MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjU4MjYwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNTg4NTk5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC41OTQ1OTVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjYwMDU5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuNjA2NTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42MTI1ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjYxODU3Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjI0NTcxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC42MzA1NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjYzNjU2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjQyNTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42NDg1NTNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjY1NDU0OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAu
NjYwNTQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMC42NjY1MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEwLjY3MjUzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNjc4NTMwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC42ODQ1MjVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjY5
MDUyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTAuNjk2NTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMC43MDI1MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjcwODUwN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzE0NTAzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43MjA0
OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEwLjcyNjQ5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTAuNzMyNDg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43Mzg0ODRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjc0NDQ3OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzUwNDc1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMC43NTY0NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEwLjc2MjQ2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTgx
OTIgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuNzY4NDYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC43NzQ0NjFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjc4MDQ1Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTAuNzg2NDUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMC43OTI0NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjc5ODQ0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODA0NDM4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44MTA0MzNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEw
LjgxNjQyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTAuODIyNDI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMC44Mjg0MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjgzNDQxNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODQwNDA5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44
NDY0MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEwLjg1MjQwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTAuODU4Mzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC44NjQzOTFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjg3MDM4N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODc2
MzgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMC44ODIzNzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEwLjg4ODM3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuODk0MzY5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45MDAzNjRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjkwNjM1
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTAuOTEyMzU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMC45MTgzNTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjkyNDM0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTMwMzQyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45MzYzMzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEwLjk0MjMzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTAuOTQ4MzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45NTQzMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjk2MDMyMF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTY2MzE2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MC45NzIzMTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEwLjk3ODMwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTAuOTg0MzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMC45OTAyOThdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEwLjk5NjI5M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
MDAyMjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS4wMDgyODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjAxNDI3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDIwMjc0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wMjYyNzBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjAz
MjI2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuMDM4MjYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS4wNDQyNTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjA1MDI1Ml0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDU2MjQ3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wNjIy
NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjA2ODIzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuMDc0MjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4wODAyMjhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjA4NjIyNl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMDkyMjIx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS4wOTgyMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjEwNDIxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTEwMjA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4xMTYyMDNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjEyMjE5OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTEuMTI4MTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMS4xMzQxODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjE0MDE4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTQ2MTgwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4xNTIxNzVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
LjE1ODE3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuMTY0MTY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS4xNzAxNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjE3NjE1N10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMTgyMTUzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4x
ODgxNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjE5NDE0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuMjAwMTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yMDYxMzRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjIxMjEyOV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjE4
MTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS4yMjQxMjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjIzMDExNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjM2MTExXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yNDIxMDddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjI0ODEw
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuMjU0MDk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS4yNjAwOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjI2NjA4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMjcyMDgzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yNzgwNzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjI4NDA3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuMjkwMDY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4yOTYwNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjMwMjA1OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzA4MDU0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MS4zMTQwNTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDExLjMyMDA0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzI2MDQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4zMzIwMzZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjMzODAzMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
MzQ0MDI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS4zNTAwMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjM1NjAxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzYyMDE1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS4zNjgwMTZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjM3
NDAxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuMzgwMDA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS4zODYwMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjM5MTk5OF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuMzk3OTk0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40MDM5
ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjQwOTk4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuNDE1OTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40MjE5NzVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQyNzk3MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDMzOTY2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS40Mzk5NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjQ0NTk2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDUxOTU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40NTc5NTBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQ2Mzk0NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTEuNDY5OTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMS40NzU5MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjQ4MTkzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNDg3OTI2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS40OTM5MjJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
LjQ5OTkxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuNTA1OTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS41MTE5MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjUxNzkwNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTIzODk5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41
Mjk4OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjUzNTg5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuNTQxODg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41NDc4ODBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjU1Mzg3Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTU5
ODcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS41NjU4NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjU3MTg2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNTc3ODU4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS41ODM4NTNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjU4OTg0
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuNTk1ODQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS42MDE4NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjYwNzgzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjEzODMxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42MTk4MjZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjYyNTgyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuNjMxODE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42Mzc4MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjY0MzgwOF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjQ5ODA0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MS42NTU3OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDExLjY2MTc5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNjY3Nzg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS42NzM3ODZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjY3OTc4MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEu
Njg1Nzc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMS42OTE3NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDExLjY5Nzc2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzAzNzYyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43MDk3NTddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjcx
NTc1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTEuNzIxNzQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMS43Mjc3NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjczMzc0MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzM5NzM1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43NDU3
MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDExLjc1MTcyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTEuNzU3NzIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43NjM3MTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjc2OTcxMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzc1NzA3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMS43ODE3MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDExLjc4NzY5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuNzkzNjk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS43OTk2ODldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjgwNTY4NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTEuODExNjgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMS44MTc2NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjgyMzY3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuODI5NjY2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44MzU2NjFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEx
Ljg0MTY1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTEuODQ3NjU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMS44NTM2NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjg1OTY0NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuODY1NjQxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44
NzE2MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDExLjg3NzYzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTEuODgzNjI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS44ODk2MjJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjg5NTYxN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTAx
NjEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMS45MDc2MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDExLjkxMzYwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTE5NTk5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45MjU1OTRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjkzMTU4
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTEuOTM3NTg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMS45NDM1ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjk0OTU3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTU1NTczXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45NjE1Njld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDExLjk2NzU2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTEuOTczNTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMS45Nzk1NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDExLjk4NTU1MV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTEuOTkxNTQ2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
MS45OTc1NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEyLjAwMzUzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDA5NTMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4wMTU1MjhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjAyMTUyNF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIu
MDI3NTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi4wMzM1MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEyLjAzOTUxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDQ1NTA2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4wNTE1MDBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjA1
NzQ5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTIuMDYzNDkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMi4wNjk0ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjA3NTQ4M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMDgxNDc5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4wODc0
NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEyLjA5MzQ2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTIuMDk5NDY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xMDU0NjBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjExMTQ1NV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTE3NDUx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMi4xMjM0NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEyLjEyOTQ0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTM1NDM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xNDE0MzJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjE0NzQyN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTIuMTUzNDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMi4xNTk0MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjE2NTQxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMTcxNDEwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4xNzc0MDVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEy
LjE4MzQwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTIuMTg5Mzk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi4xOTUzOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjIwMTM4OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjA3MzgzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4y
MTMzNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEyLjIxOTM3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTIuMjI1MzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4yMzEzNjVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjIzNzM2MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjQz
MzU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMi4yNDkzNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEyLjI1NTM0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjYxMzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4yNjczMzhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjI3MzMz
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTIuMjc5MzI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMi4yODUzMjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjI5MTMyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMjk3MzE2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zMDMzMTFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEyLjMwOTMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTIuMzE1MzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zMjEyOTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjMyNzI5Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzMzMjg4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Mi4zMzkyODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEyLjM0NTI3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzUxMjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zNTcyNjldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjM2MzI2NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIu
MzY5MjY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi4zNzUyNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEyLjM4MTI1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuMzg3MjU0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi4zOTMyNTddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjM5
OTI1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTIuNDA1MjQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMi40MTEyNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQxNzIzOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDIzMjMzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40Mjky
MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEyLjQzNTIyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTIuNDQxMjIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40NDcyMTVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQ1MzIxMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDU5MjA2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMi40NjUyMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEyLjQ3MTE5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNDc3MTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi40ODMxODldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjQ4OTE4NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTIuNDk1MTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMi41MDExNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjUwNzE3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTEzMTY3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41MTkxNjJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEy
LjUyNTE1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTIuNTMxMTUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi41MzcxNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjU0MzE0M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTQ5MTM5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41
NTUxMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEyLjU2MTEzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTIuNTY3MTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi41NzMxMjFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjU3OTExNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNTg1
MTEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMi41OTExMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEyLjU5NzEwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjAzMTAwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42MDkwOTZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjYxNTA5
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTIuNjIxMDg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMi42MjcwODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjYzMzA3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjM5MDcyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42NDUwNjdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEyLjY1MTA2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTIuNjU3MDU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42NjMwNTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjY2OTA0OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjc1MDQ0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Mi42ODEwNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEyLjY4NzAzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNjkzMDMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi42OTkwMjVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjcwNTAyMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIu
NzExMDE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMi43MTcwMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEyLjcyMzAwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNzI5MDAyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi43MzQ5OTddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjc0
MDk5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTIuNzQ2OTg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMi43NTI5ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjc1ODk3OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuNzY0OTc1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi43NzA5
NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEyLjc3Njk2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTIuNzgyOTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi43ODg5NTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjc5NDk1Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuODAwOTQ3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMi44MDY5NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEyLjgxMjkzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuODE4OTMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi44MjQ5MjldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjgzMDkyNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTIuODM2OTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMi44NDI5MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjg0ODkxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuODU0OTA1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi44NjA5MDFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEy
Ljg2Njg5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTIuODcyODkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMi44Nzg4ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjg4NDg4NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuODkwODc5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi44
OTY4NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEyLjkwMjg3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTIuOTA4ODY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi45MTQ4NjFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjkyMDg1Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuOTI2
ODUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMi45MzI4NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEyLjkzODg0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuOTQ0ODM3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi45NTA4MzJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjk1Njgy
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTIuOTYyODIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMi45Njg4MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEyLjk3NDgxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTIuOTgwODEyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMi45ODY4MDdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEyLjk5MjgwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTIuOTk4Nzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4wMDQ3OTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjAxMDc4OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMDE2Nzg1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My4wMjI3ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjAyODc3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMDM0NzcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4wNDA3NjZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA0Njc2MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
MDUyNzU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy4wNTg3NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA2NDc0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMDcwNzQzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4wNzY3MzhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjA4
MjczNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuMDg4NzI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy4wOTQ3MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjEwMDcyMF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTA2NzE1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xMTI3
MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjExODcwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuMTI0NzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xMzA2OTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjEzNjY5M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTQyNjg5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMy4xNDg2ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEzLjE1NDY4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTYwNjc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4xNjY2NzBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjE3MjY2N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTMuMTc4NjYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMy4xODQ2NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjE5MDY1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMTk2NjUwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yMDI2NDVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEz
LjIwODY0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTMuMjE0NjM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMy4yMjA2MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjIyNjYyOF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjMyNjIzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4y
Mzg2MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEzLjI0NDYxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTMuMjUwNjEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yNTY2MDVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjI2MjYwMF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjY4
NTk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMy4yNzQ1OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEzLjI4MDU4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMjg2NTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4yOTI1NzldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjI5ODU3
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTMuMzA0NTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMy4zMTA1NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjMxNjU2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzIyNTU2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zMjg1NTJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEzLjMzNDU0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTMuMzQwNTQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zNDY1MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjM1MjUzN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzU4NTMzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My4zNjQ1MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjM3MDUyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuMzc2NTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy4zODI1MTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjM4ODUxMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
Mzk0NTA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy40MDA1MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQwNjQ5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDEyNDk3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40MTg0OTNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQy
NDQ4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuNDMwNDg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy40MzY0ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQ0MjQ3NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDQ4NDcwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40NTQ0
NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjQ2MDQ2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuNDY2NDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy40NzI0NTFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjQ3ODQ0N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNDg0NDQz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMy40OTA0MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEzLjQ5NjQzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTAyNDMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41MDg0MjZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjUxNDQyMV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTMuNTIwNDE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxMy41MjY0MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjUzMjQwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTM4NDAzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41NDQzOThdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEz
LjU1MDM5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTMuNTU2MzkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxMy41NjIzODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjU2ODM4MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNTc0Mzc1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41
ODAzNzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDEzLjU4NjM2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTMuNTkyMzYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy41OTgzNTddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjYwNDM1M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjEw
MzQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxMy42MTYzNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDEzLjYyMjMzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjI4MzM0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42MzQzMjldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjY0MDMy
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTMuNjQ2MzIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxMy42NTIzMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjY1ODMxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNjY0MzA3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42NzAzMDJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDEzLjY3NjI5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTMuNjgyMjkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy42ODgyODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjY5NDI4M10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzAwMjc5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
My43MDYyNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDEzLjcxMjI2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzE4MjY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43MjQyNjFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjczMDI1Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMu
NzM2MjUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxMy43NDIyNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDEzLjc0ODI0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzU0MjM3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43NjAyMzNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjc2
NjIyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTMuNzcyMjIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxMy43NzgyMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjc4NDIxNF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuNzkwMjA5XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy43OTYy
MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDEzLjgwMjIwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTMuODA4MTk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxMy44MTQxOTBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDEzLjgyMDE4Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuODI2MTgx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxMy44MzIxNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDEzLjgzODE3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTMuODQ1MTIyXSBpNDBlIDAwMDA6MDE6MDAuMDogZncg
Ni4wLjQ4NDQyIGFwaSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5
XSBbODA4NjowMDAyXQpbICAgMTQuMTM1NjY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NjE0NDAgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTQxNzQ5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NjE0NDAgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTQ3OTQzXSBpNDBl
IDAwMDA6MDE6MDAuMDogTUFDIGFkZHJlc3M6IDNjOmZkOmZlOjZiOmU5OmMwClsgICAxNC4xNTM4
MzNdIGk0MGUgMDAwMDowMTowMC4wOiBGVyBMTERQIGlzIGVuYWJsZWQKWyAgIDE0LjE3MzY1MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuMTc5NjQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC4xODU2NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjE5MTY0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMTk3ODA4XSBpNDBlIDAwMDA6MDE6
MDAuMDogUENJLUV4cHJlc3M6IFNwZWVkIDguMEdUL3MgV2lkdGggeDgKWyAgIDE0LjIwNTA2OF0g
aTQwZSAwMDAwOjAxOjAwLjA6IEZlYXR1cmVzOiBQRi1pZFswXSBWU0lzOiAzNCBRUDogMzIgUlNT
IEZEX0FUUiBGRF9TQiBOVFVQTEUgVnhMQU4gR2VuZXZlIFBUUCBWRVBBClsgICAxNC4yMTUyNDhd
IGk0MGUgMDAwMDowMTowMC4xOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikKWyAgIDE0
LjIzMTQwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTgxOTIgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuMjM3NDAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9ODE5MiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC4yNDM0MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjI0OTM5OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMjU1Mzk0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4y
NjEzODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0LjI2NzM4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuMjczMzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4yNzkzNzVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjI4NTM3MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMjkx
MzY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC4yOTczNjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0LjMwMzM1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzA5MzUyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zMTUzNDhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjMyMTM0
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTQuMzI3MzM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNC4zMzMzMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjMzOTMzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzQ1MzI1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zNTEzMjBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE0LjM1NzMxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTQuMzYzMzExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC4zNjkzMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjM3NTMwMV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzgxMjk2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NC4zODcyOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE0LjM5MzI4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuMzk5MjgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40MDUyNzhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQxMTI3M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQu
NDE3MjY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNC40MjMyNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQyOTI1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNDM1MjU1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40NDEyNTBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQ0
NzI0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTQuNDUzMjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNC40NTkyMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjQ2NTIzM10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNDcxMjMxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40Nzcy
MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE0LjQ4MzIyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTQuNDg5MjE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC40OTUyMTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjUwMTIwN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTA3MjAz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNC41MTMyMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE0LjUxOTE5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTI1MTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC41MzExODhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjUzNzE4M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuNTQzMTc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC41NDkxNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjU1NTE3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTYxMTY0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC41NjcxNjBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0
LjU3MzE1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuNTc5MTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC41ODUxNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjU5MTE0Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNTk3MTM3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42
MDMxMzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0LjYwOTEyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuNjE1MTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42MjExMTldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjYyNzExNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjMz
MTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC42MzkxMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0LjY0NTEwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjUxMDk2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42NTcwOTFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjY2MzA4
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTQuNjY5MDgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNC42NzUwNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjY4MTA3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNjg3MDY4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC42OTMwNjNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE0LjY5OTA1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTQuNzA1MDU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43MTEwNTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjcxNzA0NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzIzMDQwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NC43MjkwMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE0LjczNTAzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzQxMDI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43NDcwMjFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljc1MzAxNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQu
NzU5MDEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNC43NjUwMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljc3MTAwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuNzc2OTk4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC43ODI5OTRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljc4
ODk4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTQuNzk0OTg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNC44MDA5ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjgwNjk3NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODEyOTcwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44MTg5
NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE0LjgyNDk2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTQuODMwOTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44MzY5NTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljg0Mjk0OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODQ4OTQz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNC44NTQ5MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE0Ljg2MDkzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuODY2OTI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC44NzI5MjRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljg3ODkyMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTQuODg0OTE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNC44OTA5MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljg5NjkwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTAyOTAyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45MDg4OTddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0
LjkxNDg5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTQuOTIwODg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNC45MjY4ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0LjkzMjg3OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTM4ODczXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45
NDQ4NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE0Ljk1MDg2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTQuOTU2ODU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45NjI4NTVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE0Ljk2ODg0OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTc0
ODQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNC45ODA4NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE0Ljk4NjgzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTQuOTkyODM0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNC45OTg4MjldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjAwNDgy
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuMDEwODIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS4wMTY4MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjAyMjgxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDI4ODA5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wMzQ4MDVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjA0MDgwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuMDQ2Nzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wNTI3OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjA1ODc4Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDY0NzgyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS4wNzA3NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1LjA3Njc3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMDgyNzY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4wODg3NjRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjA5NDc1OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
MTAwNzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS4xMDY3NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1LjExMjc0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTE4NzQxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4xMjQ3MzZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjEz
MDczMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuMTM2NzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNS4xNDI3MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjE0ODcxOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTU0NzE0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4xNjA3
MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1LjE2NjcwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuMTcyNzAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4xNzg2OTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjE4NDY5MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMTkwNjg3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS4xOTY2ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1LjIwMjY3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjA4Njc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4yMTQ2NjldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjIyMDY2NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuMjI2NjYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS4yMzI2NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjIzODY1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjQ0NjU1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4yNTA2NTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
LjI1NjY0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuMjYyNjQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS4yNjg2MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjI3NDYzM10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMjgwNjI4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4y
ODY2MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1LjI5MjYxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuMjk4NjE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zMDQ2MDldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjMxMDYwNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzE2
NjAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNS4zMjI1OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE1LjMyODU5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzM0NTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zNDA1ODJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjM0NjU3
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuMzUyNTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS4zNTg1NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjM2NDU2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuMzcwNTU5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zNzY1NTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjM4MjU0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuMzg4NTQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS4zOTQ1NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQwMDUzNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDA2NTMxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS40MTI1MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1LjQxODUyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDI0NTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS40MzA1MTNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQzNjUwOF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
NDQyNTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS40NDg0OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQ1NDQ5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDYwNDg5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS40NjY0ODVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQ3
MjQ4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuNDc4NDc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNS40ODQ0NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjQ5MDQ2Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNDk2NDYxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41MDI0
NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1LjUwODQ1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuNTE0NDQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41MjA0NDNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjUyNjQzOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTMyNDM0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS41Mzg0MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1LjU0NDQyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTUwNDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41NTY0MThdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjU2MjQxM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuNTY4NDA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS41NzQ0MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjU4MDM5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNTg2Mzk1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS41OTIzOTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
LjU5ODM4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuNjA0MzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS42MTAzNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjYxNjM3MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjIyMzY3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42
MjgzNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1LjYzNDM1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuNjQwMzUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42NDYzNDldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjY1MjM0NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjU4
MzQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNS42NjQzMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE1LjY3MDMzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNjc2MzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS42ODIzMjFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjY4ODMx
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTUuNjk0MzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNS43MDAzMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjcwNjMwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzEyMjk4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS43MTgyOTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE1LjcyNDI4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTUuNzMwMjg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS43MzYyNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljc0MjI3NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzQ4MjcwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
NS43NTQyNjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE1Ljc2MDI2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuNzY2MjU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS43NzIyNTFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljc3ODI0N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUu
Nzg0MjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNS43OTAyMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljc5NjIzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODAyMjI4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44MDgyMjNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljgx
NDIxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTUuODIwMjE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNS44MjYyMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjgzMjIwNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODM4MjAwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44NDQx
OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE1Ljg1MDE5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTUuODU2MTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44NjIxODJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljg2ODE3N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODc0MTcz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNS44ODAxNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE1Ljg4NjE2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuODkyMTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS44OTgxNTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjkwNDE1MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTUuOTEwMTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNS45MTYxNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1LjkyMjEzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuOTI4MTMyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45MzQxMjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1
Ljk0MDEyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTUuOTQ2MTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNS45NTIxMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljk1ODExMF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTUuOTY0MTA1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45
NzAxMDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE1Ljk3NjA5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTUuOTgyMDk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNS45ODgwOTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE1Ljk5NDA4NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDAw
MDgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi4wMDYwNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2LjAxMjA3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDE4MDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wMjQwNjJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjAzMDA1
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuMDM2MDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi4wNDIwNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjA0ODA0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDU0MDQyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wNjAwMzdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2LjA2NjAzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuMDcyMDI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4wNzgwMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjA4NDAxOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMDkwMDE1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni4wOTYwMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2LjEwMjAwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTA4MDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xMTM5OTddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjExOTk5Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
MTI1OTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi4xMzE5ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE2LjEzNzk3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTQzOTczXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xNDk5NjldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjE1
NTk2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTYuMTYxOTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi4xNjc5NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjE3Mzk1MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMTc5OTQ1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4xODU5
NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2LjE5MTkzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuMTk3OTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yMDM5MjddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjIwOTkyM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjE1OTE5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi4yMjE5MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2LjIyNzkxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjMzOTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yMzk5MDFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjI0NTg5N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuMjUxODkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi4yNTc4ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjI2Mzg4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMjY5ODg0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4yNzU4ODBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
LjI4MTg3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuMjg3ODcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi4yOTM4NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjI5OTg2Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzA1ODU4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4z
MTE4NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE2LjMxNzg0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTYuMzIzODQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4zMjk4NDBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjMzNTgzNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzQx
ODMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi4zNDc4MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2LjM1MzgyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzU5ODE3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi4zNjU4MTJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjM3MTgw
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuMzc3ODAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi4zODM3OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjM4OTc5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuMzk1Nzg5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40MDE3ODVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2LjQwNzc4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuNDEzNzc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40MTk3NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQyNTc2Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDMxNzYxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni40Mzc3NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2LjQ0Mzc1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDQ5NzQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40NTU3NDNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQ2MTczOV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
NDY3NzM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi40NzM3MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQ3OTcyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNDg1NzIwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi40OTE3MTZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjQ5
NzcxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTYuNTAzNzA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi41MDk3MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjUxNTY5N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTIxNjk0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41Mjc2
ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2LjUzMzY4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuNTM5NjgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41NDU2NzVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjU1MTY3MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTU3NjY2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi41NjM2NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2LjU2OTY2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNTc1NjU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi41ODE2NTFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjU4NzY0Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuNTkzNjQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi41OTk2MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjYwNTYzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjExNjI3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi42MTc2MjNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
LjYyMzYxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuNjI5NjE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi42MzU2MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjY0MTYwNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjQ3NjAwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi42
NTM1OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE2LjY1OTU5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTYuNjY1NTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi42NzE1ODFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjY3NzU3N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNjgz
NTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNi42ODk1NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE2LjY5NTU2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzAxNTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43MDc1NTNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjcxMzU0
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTYuNzE5NTQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNi43MjU1MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjczMTUzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzM3NTMyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43NDM1Mjdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE2Ljc0OTUyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTYuNzU1NTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43NjE1MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljc2NzUwOV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzczNTA1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ni43Nzk1MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE2Ljc4NTQ5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuNzkxNDkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi43OTc0ODddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjgwMzQ4Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYu
ODA5NDc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNi44MTU0NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE2LjgyMTQ2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODI3NDYzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44MzM0NTldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljgz
OTQ1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTYuODQ1NDQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNi44NTE0NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljg1NzQ0MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODYzNDM1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44Njk0
MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE2Ljg3NTQyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTYuODgxNDIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi44ODc0MTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljg5MzQxMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuODk5NDA3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNi45MDU0MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE2LjkxMTM5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTE3MzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45MjMzODhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2LjkyOTM4NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTYuOTM1Mzc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNi45NDEzNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljk0NzM3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTUzMzY2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45NTkzNjFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2
Ljk2NTM1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTYuOTcxMzUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNi45NzczNDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE2Ljk4MzM0Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTYuOTg5MzM4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNi45
OTUzMzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE3LjAwMTMyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuMDA3MzI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wMTMzMjBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjAxOTMxNV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDI1
MzExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy4wMzEzMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3LjAzNzMwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDQzMjk3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wNDkyOTNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjA1NTI4
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuMDYxMjg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy4wNjcyNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjA3MzI3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMDc5MjczXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4wODUyNjhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3LjA5MTI2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuMDk3MjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4xMDMyNTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjEwOTI1MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMTE1MjQ1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny4xMjEyNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3LjEyNzIzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMTMzMjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4xMzkyMjddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE0NTIyM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcu
MTUxMjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNy4xNTcyMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE2MzIwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMTY5MjA1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4xNzUyMDBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE4
MTE5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuMTg3MTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy4xOTMxODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjE5OTE4MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjA1MTc3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yMTEx
NzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3LjIxNzE2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuMjIzMTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yMjkxNTldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjIzNTE1NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjQxMTQ5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy4yNDcxNDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3LjI1MzE0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjU5MTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4yNjUxMzFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjI3MTEyNl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuMjc3MTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy4yODMxMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjI4OTExOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMjk1MTE0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4zMDExMTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
LjMwNzEwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuMzEzMTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9ODE5MiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNy4zMTkwOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjMyNTA5OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzMxMDk0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4z
MzcwOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE3LjM0MzA4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuMzQ5MDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4zNTUwNzZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjM2MTA3MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzY3
MDY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy4zNzMwNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3LjM3OTA1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuMzg1MDUyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy4zOTEwNDddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjM5NzA0
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuNDAzMDM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy40MDkwMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQxNTAyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDIxMDI0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40MjcwMTld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3LjQzMzAxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuNDM5MDEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40NDUwMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQ1MTAwMV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDU2OTk3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny40NjI5OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3LjQ2ODk4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNDc0OTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy40ODA5NzhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjQ4Njk3M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcu
NDkyOTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNy40OTg5NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3LjUwNDk2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTEwOTU4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41MTY5NTRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjUy
Mjk0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuNTI4OTQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy41MzQ5NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjU0MDkzNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTQ2OTMxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41NTI5
MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3LjU1ODkyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuNTY0OTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy41NzA5MTNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjU3NjkwOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNTgyOTAz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy41ODg5MDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3LjU5NDg5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNjAwODkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42MDY4ODhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjYxMjg4NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuNjE4ODc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy42MjQ4NzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjYzMDg2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNjM2ODY1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42NDI4NjBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
LjY0ODg1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuNjU0ODUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxNy42NjA4NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjY2Njg0MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNjcyODM3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42
Nzg4MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE3LjY4NDgyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTcuNjkwODIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy42OTY4MTldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjcwMjgxNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzA4
ODEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxNy43MTQ4MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE3LjcyMDgwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzI2Nzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43MzI3OTFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjczODc4
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTcuNzQ0NzgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxNy43NTA3NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljc1Njc3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzYyNzY3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43Njg3NjNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE3Ljc3NDc1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTcuNzgwNzU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy43ODY3NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljc5Mjc0NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuNzk4NzQwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
Ny44MDQ3MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE3LjgxMDczMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODE2NzI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44MjI3MjFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjgyODcxN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcu
ODM0NzEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxNy44NDA3MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljg0NjcwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODUyNjk4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44NTg2OTNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljg2
NDY4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTcuODcwNjg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxNy44NzY2NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljg4MjY3NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuODg4NjcwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy44OTQ2
NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE3LjkwMDY2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTcuOTA2NjU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45MTI2NTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3LjkxODY0N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTI0NjQz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxNy45MzA2MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE3LjkzNjYzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTQyNjI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45NDg2MjRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljk1NDYxOV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTcuOTYwNjE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxNy45NjY2MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3Ljk3MjYwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTcuOTc4NjAwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxNy45ODQ1OTZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE3
Ljk5MDU5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTcuOTk2NTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOC4wMDI1ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjAwODU3OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDE0NTczXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4w
MjA1NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4LjAyNjU2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguMDMyNTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4wMzg1NTVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjA0NDU1MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDUw
NTQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC4wNTY1NDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4LjA2MjUzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMDY4NTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4wNzQ1MjddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjA4MDUy
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguMDg2NTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC4wOTI1MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjA5ODUxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTA0NTA4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xMTA1MDNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4LjExNjQ5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguMTIyNDk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xMjg0OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjEzNDQ4NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTQwNDgwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OC4xNDY0NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE4LjE1MjQ3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTU4NDY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4xNjQ0NjJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjE3MDQ1N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
MTc2NDUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC4xODI0NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4LjE4ODQ0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMTk0NDM4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yMDA0MzRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjIw
NjQyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguMjEyNDI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC4yMTg0MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjIyNDQxNl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjMwNDExXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yMzY0
MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4LjI0MjQwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguMjQ4Mzk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yNTQzOTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjI2MDM5MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjY2Mzg2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC4yNzIzODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4LjI3ODM3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMjg0MzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4yOTAzNjddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjI5NjM2M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguMzAyMzU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC4zMDgzNjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjMxNDM1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzIwMzUxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4zMjYzNDZdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4
LjMzMjM0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTguMzM4MzM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOC4zNDQzMzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjM1MDMyOF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzU2MzIzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4z
NjIzMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4LjM2ODMxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguMzc0MzEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC4zODAzMDVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjM4NjMwMF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguMzky
Mjk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC4zOTgyOTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4LjQwNDI4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDEwMjgxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40MTYyNzhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQyMjI3
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguNDI4MjY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC40MzQyNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQ0MDI1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDQ2MjU0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40NTIyNTBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4LjQ1ODI0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguNDY0MjQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC40NzAyMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjQ3NjIzMl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNDgyMjI3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OC40ODgyMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE4LjQ5NDIxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNTAwMjEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41MDYyMDhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjUxMjIwNF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
NTE4MTk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC41MjQxOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4LjUzMDE4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNTM2MTg2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41NDIxODFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjU0
ODE3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguNTU0MTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC41NjAxNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjU2NjE2Ml0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNTcyMTU4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41Nzgx
NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4LjU4NDE0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguNTkwMTQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC41OTYxMzldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjYwMjEzNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjA4MTMx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC42MTQxMjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4LjYyMDEyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjI2MTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC42MzIxMTRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjYzODEwOV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguNjQ0MTA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC42NTAwOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjY1NjA5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjYyMDkxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC42NjgwODddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4
LjY3NDA4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTguNjgwMDc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOC42ODYwNzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjY5MjA2OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNjk4MDYzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43
MDQwNTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE4LjcxMDA1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTguNzE2MDUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43MjIwNDVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjcyODA0MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzM0
MDM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOC43NDAwMzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE4Ljc0NjAyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzUyMDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43NTgwMTddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljc2NDAx
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTguNzcwMDA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOC43NzYwMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljc4MTk5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguNzg3OTk0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC43OTM5ODld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE4Ljc5OTk4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTguODA1OTgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44MTE5NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjgxNzk3MV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODIzOTY3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OC44Mjk5NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE4LjgzNTk1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODQxOTUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44NDc5NDldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljg1Mzk0M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTgu
ODU5OTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOC44NjU5MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljg3MTkzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguODc3OTI1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC44ODM5MjFdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljg4
OTkxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTguODk1OTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOC45MDE5MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4LjkwNzkwMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTEzODk3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45MTk4
OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE4LjkyNTg4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTguOTMxODg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45Mzc4NzldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljk0Mzg3NV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTQ5ODcw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOC45NTU4NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE4Ljk2MTg2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTguOTY3ODU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOC45NzM4NTFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljk3OTg0N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTguOTg1ODQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOC45OTE4MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE4Ljk5NzgzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDAzODI5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wMDk4MjRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5
LjAxNTgyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTkuMDIxODE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOS4wMjc4MTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjAzMzgwOF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDM5ODAzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4w
NDU3OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE5LjA1MTc5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTkuMDU3Nzg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wNjM3ODVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjA2OTc4MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDc1
Nzc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOS4wODE3NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE5LjA4Nzc2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMDkzNzYxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4wOTk3NTddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjEwNTc1
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTkuMTExNzQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOS4xMTc3NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjEyMzc0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTI5NzM2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xMzU3MzJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE5LjE0MTcyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTkuMTQ3NzI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xNTM3MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjE1OTcxNF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTY1NzA5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OS4xNzE3MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE5LjE3NzcwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMTgzNjk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4xODk2OTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjE5NTY4N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTku
MjAxNjgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOS4yMDc2NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE5LjIxMzY3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMjE5NjY4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4yMjU2NjNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjIz
MTY1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTkuMjM3NjU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOS4yNDM2NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjI0OTY0NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMjU1NjQxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4yNjE2
MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE5LjI2NzYzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuMjczNjI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4yNzk2MjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjI4NTYxN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMjkxNjEz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS4yOTc2MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5LjMwMzYwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMzA5NTk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4zMTU1OTRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjMyMTU4OV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTkuMzI3NTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOS4zMzM1ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjMzOTU4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMzQ1NTc2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4zNTE1NzJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5
LjM1NzU2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTkuMzYzNTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOS4zNjk1NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjM3NTU1NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuMzgxNTQ4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS4z
ODc1NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE5LjM5MzUzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTkuMzk5NTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS40MDU1MzBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjQxMTUyNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNDE3
NTIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOS40MjM1MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE5LjQyOTUxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNDM1NTA3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS40NDE1MDJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjQ0NzQ5
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTkuNDUzNDkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOS40NTk0ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjQ2NTQ4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNDcxNDc5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS40Nzc0NzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE5LjQ4MzQ2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTkuNDg5NDY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS40OTU0NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjUwMTQ1NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNTA3NDUwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OS41MTM0NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE5LjUxOTQ0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNTI1NDM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS41MzE0MzFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjUzNzQyNl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTku
NTQzNDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOS41NDk0MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE5LjU1NTQxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNTYxNDA4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS41Njc0MDRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjU3
MzM5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTkuNTc5Mzk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOS41ODUzOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjU5MTM4NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNTk3MzgxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42MDMz
NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE5LjYwOTM3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuNjE1MzY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42MjEzNjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjYyNzM1N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjMzMzUz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS42MzkzNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5LjY0NTM0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjUxMzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42NTczMzddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjY2MzMzMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MTkuNjY5MzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAxOS42NzUzMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjY4MTMxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNjg3MzE0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS42OTMzMDldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5
LjY5OTMwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMTkuNzA1MzAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAxOS43MTEyOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjcxNzI5MV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzIzMjg3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43
MjkyODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDE5LjczNTI3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMTkuNzQxMjcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43NDcyNjhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljc1MzI2M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzU5
MjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAxOS43NjUyNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDE5Ljc3MTI1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuNzc3MjQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS43ODMyNDRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljc4OTIz
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMTkuNzk1MjM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAxOS44MDEyMzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjgwNzIyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODEzMjIyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44MTkyMTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDE5LjgyNTIxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMTkuODMxMjA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44MzcyMDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljg0MzE5OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODQ5MTk0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAx
OS44NTUxOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDE5Ljg2MTE4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuODY3MTgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS44NzMxNzZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljg3OTE3Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTku
ODg1MTY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAxOS44OTExNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljg5NzE1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTAzMTUzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45MDkxNDhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljkx
NTE0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMTkuOTIxMTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAxOS45MjcxMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5LjkzMzEyOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTM5MTI1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45NDUx
MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDE5Ljk1MTExNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMTkuOTU3MTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45NjMxMDddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDE5Ljk2OTEwMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTc1MDk5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAxOS45ODEwOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDE5Ljk4NzA5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMTkuOTkzMDg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAxOS45OTkwODFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjAwNTA3Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjAuMDExMDcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMC4wMTcwNjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjAyMzA2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMDI5MDU3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4wMzUwNTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIw
LjA0MTA0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjAuMDQ3MDQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMC4wNTMwMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjA1OTAzNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMDY1MDI5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4w
NzEwMjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIwLjA3NzAyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjAuMDgzMDE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4wODkwMTFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjA5NTAwN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTAx
MDAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMC4xMDY5OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIwLjExMjk5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTE4OTg4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xMjQ5ODRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjEzMDk3
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjAuMTM2OTc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMC4xNDI5NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjE0ODk2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTU0OTY0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xNjA5NTld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIwLjE2Njk1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjAuMTcyOTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4xNzg5NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjE4NDk0Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMTkwOTM4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MC4xOTY5MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIwLjIwMjkyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjA4OTI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yMTQ5MTldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjIyMDkxNF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAu
MjI2OTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMC4yMzI5MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIwLjIzODkwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjQ0ODk2XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yNTA4OTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjI1
Njg4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjAuMjYyODgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMC4yNjg4NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjI3NDg3M10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMjgwODY4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4yODY4
NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIwLjI5Mjg1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjAuMjk4ODU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4zMDQ4NTBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjMxMDg0Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzE2ODQx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMC4zMjI4MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIwLjMyODgzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzM0ODI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4zNDA4MjJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjM0NjgxOF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjAuMzUyODE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMC4zNTg4MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjM2NDgxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuMzcwODA2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC4zNzY4MDJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIw
LjM4Mjc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjAuMzg4NzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMC4zOTk2MDhdIGk0MGUgMDAwMDowMTowMC4xOiBmdyA2LjAu
NDg0NDIgYXBpIDEuNyBudm0gNi4wMSAweDgwMDAzNDg1IDEuMTc0Ny4wIFs4MDg2OjE1ODldIFs4
MDg2OjAwMDBdClsgICAyMC42ODc3OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT02
MTQ0MCBmbGFncz1jYzAgYXR0cj0wClsgICAyMC42OTM4ODBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT02MTQ0MCBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43MDAwNzVdIGk0MGUgMDAw
MDowMTowMC4xOiBNQUMgYWRkcmVzczogM2M6ZmQ6ZmU6NmI6ZTk6YzEKWyAgIDIwLjcxMDI4Nl0g
aTQwZSAwMDAwOjAxOjAwLjE6IEZXIExMRFAgaXMgZW5hYmxlZApbICAgMjAuNzIxMzY0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43
MjczNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIwLjczMzM1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjAuNzM5MzU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC43NDU1MjBdIGk0MGUgMDAwMDowMTowMC4x
OiBQQ0ktRXhwcmVzczogU3BlZWQgOC4wR1QvcyBXaWR0aCB4OApbICAgMjAuNzUyNzc5XSBpNDBl
IDAwMDA6MDE6MDAuMTogRmVhdHVyZXM6IFBGLWlkWzFdIFZTSXM6IDM0IFFQOiAzMiBSU1MgRkRf
QVRSIEZEX1NCIE5UVVBMRSBWeExBTiBHZW5ldmUgUFRQIFZFUEEKWyAgIDIwLjc2Mjk0OV0gaTQw
ZSAwMDAwOjAxOjAwLjI6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAgMjAuNzc5
Mzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMC43ODUzOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT04MTkyIGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIwLjc5MTM5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuNzk3Mzk0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44MDMzOTFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjgwOTM4
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjAuODE1MzgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMC44MjEzNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjgyNzM3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODMzMzY3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44MzkzNjNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIwLjg0NTM1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjAuODUxMzU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44NTczNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjg2MzM0OV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODY5MzQ0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MC44NzUzNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIwLjg4MTMzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuODg3MzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC44OTMzMjVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjg5OTMyMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAu
OTA1MzE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMC45MTEzMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIwLjkxNzMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTIzMzAyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45MjkyOTddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjkz
NTI5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjAuOTQxMjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMC45NDcyODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjk1MzI3OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTU5Mjc1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45NjUy
NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIwLjk3MTI2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjAuOTc3MjYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMC45ODMyNTZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIwLjk4OTI1Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjAuOTk1MjQ4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMS4wMDEyNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIxLjAwNzIzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDEzMjM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4wMTkyMzBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjAyNTIyNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuMDMxMjIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS4wMzcyMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjA0MzIxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDQ5MjA3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4wNTUyMDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
LjA2MTE5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuMDY3MTkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS4wNzMxODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjA3OTE4NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMDg1MTc5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4w
OTExNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjA5NzE3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuMTAzMTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xMDkxNjBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjExNTE1Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTIx
MTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS4xMjcxNDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjEzMzE0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTM5MTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xNDUxMzJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjE1MTEy
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuMTU3MTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS4xNjMxMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjE2OTExNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMTc1MTExXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xODExMDdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjE4NzEwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuMTkzMDk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4xOTkwOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjIwNTA4OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjExMDg0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS4yMTcwNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjIyMzA3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjI5MDY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4yMzUwNjVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI0MTA2MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
MjQ3MDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS4yNTMwNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI1OTA0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMjY1MDQxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4yNzEwMzddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI3
NzAzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuMjgzMDI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS4yODkwMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjI5NTAxOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzAxMDEzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zMDcw
MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjMxMzAwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjEuMzE4OTk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zMjQ5OTRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjMzMDk5MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzM2OTg1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMS4zNDI5ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIxLjM0ODk3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzU0OTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zNjA5NjZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjM2Njk2Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuMzcyOTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS4zNzg5NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjM4NDk0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuMzkwOTQ0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS4zOTY5MzldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
LjQwMjkzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuNDA4OTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS40MTQ5MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQyMDkyMF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDI2OTE2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40
MzI5MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjQzODkwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuNDQ0OTAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40NTA4OThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQ1Njg5M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDYy
ODg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS40Njg4ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjQ3NDg3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNDgwODc0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS40ODY4NzBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjQ5Mjg2
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuNDk4ODYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS41MDQ4NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjUxMDg1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTE2ODQ2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41MjI4NDJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjUyODgzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuNTM0ODMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41NDA4MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjU0NjgyM10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTUyODE4XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS41NTg4MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjU2NDgwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNTcwODA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS41NzY4MDBdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjU4Mjc5Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
NTg4NzkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS41OTQ3ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjYwMDc4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjA2Nzc3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42MTI3NzJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjYx
ODc3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuNjI0NzY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS42MzA3NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjYzNjc1N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjQyNzUyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42NDg3
NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjY1NDc0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjEuNjYwNzM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS42NjY3MzRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjY3MjcyOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjc4NzI0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMS42ODQ3MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIxLjY5MDcxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNjk2NzEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43MDI3MDldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjcwODcwNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjEuNzE0NzAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMS43MjA2OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjcyNjY5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNzMyNjg2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43Mzg2ODJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIx
Ljc0NDY3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjEuNzUwNjcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMS43NTY2NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjc2MjY2M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuNzY4NjU4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43
NzQ2NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIxLjc4MDY0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjEuNzg2NjQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS43OTI2NDZdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjc5ODY0Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODA0
NjM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMS44MTA2MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIxLjgxNjYyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODIyNjI0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44Mjg2MTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjgzNDYx
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjEuODQwNjA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMS44NDY2MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjg1MjYwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODU4NTk2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44NjQ1OTFd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIxLjg3MDU4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjEuODc2NTgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS44ODI1NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjg4ODU3Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuODk0NTY3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
MS45MDA1NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIxLjkwNjU1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTEyNTUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45MTg1NDldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjkyNDU0NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEu
OTMwNTQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMS45MzY1MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIxLjk0MjUzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTQ4NTI1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45NTQ1MjJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjk2
MDUxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjEuOTY2NTEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMS45NzI1MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIxLjk3ODUwM10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjEuOTg0NDk4XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMS45OTA0
OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIxLjk5NjQ5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjIuMDAyNDg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4wMDg0ODNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjAxNDQ3OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDIwNDc0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi4wMjY0NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjAzMjQ2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDM4NDYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4wNDQ0NTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjA1MDQ1MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuMDU2NDQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi4wNjI0NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjA2ODQzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMDc0NDMzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4wODA0MjhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
LjA4NjQyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuMDkyNDE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi4wOTg0MTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjEwNDQwOV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTEwNDA1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4x
MTY0MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjEyMjM5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuMTI4MzkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4xMzQzODddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjE0MDM4Ml0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTQ2
Mzc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi4xNTIzNzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjE1ODM2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMTY0MzY0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4xNzAzNTldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjE3NjM1
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuMTgyMzUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi4xODgzNDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjE5NDM0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjAwMzM4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yMDYzMzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjIxMjMyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuMjE4MzI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yMjQzMjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjIzMDMxNl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjM2MzEwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi4yNDIzMDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjI0ODMwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjU0Mjk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yNjAyOTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjI2NjI4OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
MjcyMjgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi4yNzgyNzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjI4NDI3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMjkwMjY5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4yOTYyNjRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjMw
MjI2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuMzA4MjU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi4zMTQyNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjMyMDI0Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzI2MjQxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zMzIy
MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIyLjMzODIzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjIuMzQ0MjI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zNTAyMjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjM1NjIxN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzYyMjEz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi4zNjgyMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjM3NDIwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuMzgwMjAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi4zODYxOThdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjM5MjE5M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuMzk4MTg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi40MDQxODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjQxMDE4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDE2MTc1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40MjIxNzFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
LjQyODE2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuNDM0MTYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi40NDAxNTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjQ0NjE1Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDUyMTQ3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40
NTgxNDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjQ2NDEzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuNDcwMTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi40NzYxMjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjQ4MjEyNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNDg4
MTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi40OTQxMTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjUwMDExMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTA2MTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41MTIxMDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjUxODA5
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuNTI0MDkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi41MzAwODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjUzNjA4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTQyMDc4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41NDgwNzNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjU1NDA2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuNTYwMDY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi41NjYwNTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjU3MjA1NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTc4MDUwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi41ODQwNDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjU5MDA0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNTk2MDM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42MDIwMzFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjYwODAyN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
NjE0MDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi42MjAwMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjYyNjAxNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNjMyMDA5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42MzgwMDRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjY0
Mzk5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuNjQ5OTk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi42NTU5OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjY2MTk4Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNjY3OTgwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42NzM5
NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIyLjY3OTk3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjIuNjg1OTY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi42OTE5NjJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjY5Nzk1N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzAzOTUz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMi43MDk5NTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIyLjcxNTk0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzIxOTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43Mjc5MzZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjczMzkzMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjIuNzM5OTI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMi43NDU5MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjc1MTkxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzU3OTEzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43NjM5MDldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIy
Ljc2OTkwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjIuNzc1ODk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMi43ODE4OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjc4Nzg4OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuNzkzODg1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi43
OTk4ODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIyLjgwNTg3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjIuODExODc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44MTc4NzNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjgyMzg2OF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODI5
ODY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMi44MzU4NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIyLjg0MTg1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODQ3ODUwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44NTM4NDZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjg1OTg0
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjIuODY1ODM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMi44NzE4MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjg3NzgyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuODgzODIyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi44ODk4MTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIyLjg5NTgxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjIuOTAxODA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi45MDc4MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjkxMzc5OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTE5Nzk0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Mi45MjU3ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIyLjkzMTc4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTM3NzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi45NDM3NzVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk0OTc3MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIu
OTU1NzY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMi45NjE3NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk2Nzc1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjIuOTczNzUyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMi45Nzk3NDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIyLjk4
NTc0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjIuOTkxNzM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMi45OTc3MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjAwMzcyOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDA5NzI1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wMTU3
MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjAyMTcxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuMDI3NzExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wMzM3MDddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjAzOTcwMl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDQ1Njk4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy4wNTE2OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjA1NzY4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDYzNjgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4wNjk2NzldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjA3NTY3NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuMDgxNjY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy4wODc2NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjA5MzY2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMDk5NjU1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4xMDU2NTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
LjExMTY0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuMTE3NjQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy4xMjM2MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjEyOTYzNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTM1NjMwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4x
NDE2MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjE0NzYyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuMTUzNjE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4xNTk2MTJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjE2NTYwN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTcx
NjAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy4xNzc1OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjE4MzU5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMTg5NTg5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4xOTU1ODRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjIwMTU3
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuMjA3NTc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy4yMTM1NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjIxOTU2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjI1NTY0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yMzE1NjBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjIzNzU1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuMjQzNTUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yNDk1NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjI1NTU0MV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjYxNTM3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My4yNjc1MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjI3MzUyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMjc5NTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4yODU1MThdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjI5MTUxM10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
Mjk3NTA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy4zMDM1MDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjMwOTQ5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzE1NDk0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zMjE0ODldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjMy
NzQ4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjMuMzMzNDgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMy4zMzk0NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjM0NTQ3MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzUxNDY2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zNTc0
NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjM2MzQ1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuMzY5NDUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy4zNzU0NDhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjM4MTQ0NV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuMzg3NDQw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy4zOTM0MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjM5OTQzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNDA1NDI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40MTE0MjFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQxNzQxN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuNDIzNDExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy40Mjk0MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQzNTQwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNDQxMzk4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40NDczOTNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
LjQ1MzM4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuNDU5Mzg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy40NjUzODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjQ3MTM3NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNDc3MzcwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy40
ODMzNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjQ4OTM2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuNDk1MzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41MDEzNTJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjUwNzM0N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTEz
MzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy41MTkzMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjUyNTMzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTMxMzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41MzczMjVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjU0MzMy
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuNTQ5MzE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy41NTUzMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjU2MTMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNTY3MzAxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41NzMyOTdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjU3OTI5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuNTg1Mjg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy41OTEyODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjU5NzI3OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjAzMjczXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My42MDkyNjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjYxNTI2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjIxMjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42MjcyNTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjYzMzI1MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
NjM5MjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy42NDUyNDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjY1MTIzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjU3MjMyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42NjMyMjddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjY2
OTIyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjMuNjc1MjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyMy42ODEyMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjY4NzIwOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNjkzMjA1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy42OTkx
OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDIzLjcwNTE5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjMuNzExMTkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43MTcxODZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjcyMzE4MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzI5MTc4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyMy43MzUxNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDIzLjc0MTE2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzQ3MTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43NTMxNjBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjc1OTE1NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjMuNzY1MTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyMy43NzExNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjc3NzE0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuNzgzMTM3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy43ODkxMzJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIz
Ljc5NTEyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjMuODAxMTIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyMy44MDcxMThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjgxMzExNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODE5MTA4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44
MjUxMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDIzLjgzMTEwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjMuODM3MTAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44NDMwOTddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjg0OTA5M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODU1
MDg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyMy44NjEwODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT04MTkyIGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDIzLjg2NzA4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTgxOTIgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuODczMDc5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy44NzkwNzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjg4NTA3
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjMuODkxMDY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyMy44OTcwNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjkwMzA1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTA5MDU0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45MTUwNDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDIzLjkyMTA0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjMuOTI3MDM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45MzMwMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjkzOTAzMF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTQ1MDI1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
My45NTEwMjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDIzLjk1NzAxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTYzMDExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyMy45NjkwMDddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDIzLjk3NTAwMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMu
OTgwOTk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyMy45ODY5OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDIzLjk5Mjk4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjMuOTk4OTg0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wMDQ5ODBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjAx
MDk3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuMDE2OTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC4wMjI5NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjAyODk2MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDM0OTU2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wNDA5
NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjA0Njk0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuMDUyOTQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wNTg5MzhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjA2NDkzNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDcwOTI5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC4wNzY5MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0LjA4MjkyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMDg4OTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4wOTQ5MTFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjEwMDkwNl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuMTA2OTAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC4xMTI4OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjExODg5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTI0ODg4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4xMzA4ODNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjEzNjg3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuMTQyODc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC4xNDg4NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjE1NDg2NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTYwODYwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4x
NjY4NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0LjE3Mjg1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuMTc4ODQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4xODQ4NDJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjE5MDgzN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMTk2
ODMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC4yMDI4MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0LjIwODgyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjE0ODE5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yMjA4MTVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjIyNjgw
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuMjMyODA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC4yMzg4MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjI0NDc5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjUwNzk0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yNTY3OTBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0LjI2Mjc4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuMjY4NzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4yNzQ3NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjI4MDc3MV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMjg2NzY3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC4yOTI3NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0LjI5ODc1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMzA0NzUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zMTA3NDhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjMxNjc0M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQu
MzIyNzM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNC4zMjg3MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI0LjMzNDcyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMzQwNzI0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zNDY3MTldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjM1
MjcxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuMzU4NzEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC4zNjQ3MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjM3MDcwMF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuMzc2Njk2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC4zODI2
OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjM4ODY4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuMzk0NjgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40MDA2NzddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQwNjY3Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDEyNjY4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC40MTg2NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0LjQyNDY1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDMwNjU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40MzY2NTBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQ0MjY0NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuNDQ4NjQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC40NTQ2MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQ2MDYzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNDY2NjI3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC40NzI2MjJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjQ3ODYxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuNDg0NjEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC40OTA2MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjQ5NjYwNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTAyNTk5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41
MDg1OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0LjUxNDU5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuNTIwNTg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41MjY1ODBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjUzMjU3Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTM4
NTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC41NDQ1NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0LjU1MDU2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTU2NTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41NjI1NTNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjU2ODU0
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuNTc0NTQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC41ODA1MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjU4NjUzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNTkyNTI5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC41OTg1MjRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0LjYwNDUyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuNjEwNTE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42MTY1MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjYyMjUwNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjI4NTAxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC42MzQ0OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0LjY0MDQ5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjQ2NDg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42NTI0ODZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY1ODQ4MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQu
NjY0NDc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNC42NzA0NzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY3NjQ2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNjgyNDY0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC42ODg0NTldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjY5
NDQ1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjQuNzAwNDUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNC43MDY0NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjcxMjQ0Ml0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzE4NDM2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43MjQ0
MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI0LjczMDQyN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjQuNzM2NDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43NDI0MThdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljc0ODQxNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzU0NDEw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNC43NjA0MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI0Ljc2NjQwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuNzcyMzk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC43NzgzOTNdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljc4NDM4OF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjQuNzkwMzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNC43OTYzNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjgwMjM3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODA4MzcwXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44MTQzNjVdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0
LjgyMDM2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjQuODI2MzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNC44MzIzNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjgzODM0N10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODQ0MzQyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44
NTAzMzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI0Ljg1NjM0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjQuODYyMzM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC44NjgzMzFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljg3NDMyNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODgw
MzIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNC44ODYzMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI0Ljg5MjMxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuODk4MzA3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45MDQzMDNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjkxMDI5
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjQuOTE2Mjk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNC45MjIyODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0LjkyODI4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTM0Mjc5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45NDAyNzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI0Ljk0NjI3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjQuOTUyMjY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45NTgyNjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI0Ljk2NDI1N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTcwMjUyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NC45NzYyNDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI0Ljk4MjI0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjQuOTg4MjM4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNC45OTQyMzNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjAwMDIyOF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUu
MDA2MjIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS4wMTIyMjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjAxODIxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDI0MjEwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wMzAyMDVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjAz
NjIwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuMDQyMTk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS4wNDgxOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjA1NDE4N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDYwMTgyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wNjYx
NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1LjA3MjE3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuMDc4MTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4wODQxNjVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjA5MDE2MF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMDk2MTU2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNS4xMDIxNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI1LjEwODE0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTE0MTQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4xMjAxMzddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjEyNjEzMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjUuMTMyMTI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNS4xMzgxMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjE0NDExOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTUwMTE0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4xNTYxMTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1
LjE2MjEwNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjUuMTY4MTAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNS4xNzQwOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjE4MDA5Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMTg2MDg3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4x
OTIwODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI1LjE5ODA3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjUuMjA0MDczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yMTAwNjhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjIxNjA2NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjIy
MDU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNS4yMjgwNTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI1LjIzNDA0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjQwMDQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yNDYwNDBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjI1MjAz
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjUuMjU4MDMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNS4yNjQwMjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjI3MDAyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMjc2MDIwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4yODIwMTVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI1LjI4ODAxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjUuMjk0MDA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zMDAwMDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjMwNTk5Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzExOTkxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NS4zMTc5ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI1LjMyMzk4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzI5OTc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zMzU5NzNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM0MTk2OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUu
MzQ3OTY0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS4zNTM5NTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM1OTk1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuMzY1OTQ5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS4zNzE5NDVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM3
Nzk0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuMzgzOTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS4zODk5MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjM5NTkyN10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDAxOTIyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40MDc5
MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1LjQxMzkxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuNDE5OTEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40MjU5MDddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQzMTkwM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDM3ODk4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNS40NDM4OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI1LjQ0OTg4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDU1ODg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40NjE4NzldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQ2Nzg3NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjUuNDczODcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNS40Nzk4NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjQ4NTg2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNDkxODU3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS40OTc4NTJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1
LjUwMzg0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjUuNTA5ODQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNS41MTU4MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjUyMTgzM10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTI3ODI5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41
MzM4MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI1LjUzOTgxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjUuNTQ1ODE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41NTE4MTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjU1NzgwNF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTYz
ODAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNS41Njk3OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI1LjU3NTc5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNTgxNzg2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS41ODc3ODJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjU5Mzc3
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjUuNTk5NzczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNS42MDU3NjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjYxMTc2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjE3NzU4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42MjM3NTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI1LjYyOTc0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjUuNjM1NzQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42NDE3NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjY0NzczNl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjUzNzMxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
NS42NTk3MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI1LjY2NTcyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNjcxNzE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS42Nzc3MTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjY4MzcwOV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUu
Njg5NzA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNS42OTU3MDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI1LjcwMTY5NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNzA3NjkwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43MTM2ODVdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljcx
OTY4MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjUuNzI1Njc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNS43MzE2NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjczNzY2Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNzQzNjYyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43NDk2
NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI1Ljc1NTY1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjUuNzYxNjQ4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS43Njc2NDRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljc3MzYzOV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNzc5NjM3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNS43ODU2MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI1Ljc5MTYyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuNzk3NjI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS44MDM2MTldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjgwOTYxNV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjUuODE1NjEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNS44MjE2MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjgyNzYwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuODMzNTk3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS44Mzk1OTJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1
Ljg0NTU4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjUuODUxNTgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNS44NTc1NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljg2MzU3NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuODY5NTY5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS44
NzU1NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI1Ljg4MTU2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjUuODg3NTYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS44OTM1NThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljg5OTU1NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuOTA1
NTQ5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNS45MTE1NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI1LjkxNzU0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuOTIzNTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS45Mjk1MzBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1LjkzNTUy
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjUuOTQxNTIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNS45NDc1MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljk1MzUxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuOTU5NTA4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS45NjU1MDNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI1Ljk3MTQ5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjUuOTc3NDkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNS45ODM0ODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI1Ljk4OTQ4NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjUuOTk1NDgwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ni4wMDE0NzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI2LjAwNzQ3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMDEzNDY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wMTk0NjJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjAyNTQ1N10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
MDMxNDUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi4wMzc0NDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2LjA0MzQ0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMDQ5NDM4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wNTU0MzRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjA2
MTQyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuMDY3NDI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi4wNzM0MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjA3OTQxNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMDg1NDExXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4wOTE0
MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2LjA5NzQwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuMTAzMzk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4xMDkzOTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjExNTM4OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMTIxMzgz
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi4xMjczNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjEzMzM3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMTM5MzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4xNDUzNjRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjE1MTM2MF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuMTU3MzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi4xNjMzNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjE2OTM1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMTc1MzQ4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4xODEzNDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2
LjE4NzMzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjYuMTkzMzMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNi4xOTkzMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjIwNTMyNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjExMzE5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4y
MTczMTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI2LjIyMzMxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjYuMjI5MzA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4yMzUzMDFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjI0MTI5N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjQ3
MjkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNi4yNTMyODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI2LjI1OTI4NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMjY1Mjc4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4yNzEyNzRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjI3NzI2
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjYuMjgzMjY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNi4yODkyNjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjI5NTI1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzAxMjUzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zMDcyNDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI2LjMxMzI0NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjYuMzE5MjQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zMjUyMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjMzMTIzMF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzM3MjI1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ni4zNDMyMjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI2LjM0OTIxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzU1MjExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zNjEyMDZdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjM2NzIwMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
MzczMTk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi4zNzkxOTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2LjM4NTE4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuMzkxMTgzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi4zOTcxNzhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQw
MzE3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuNDA5MTY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi40MTUxNjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQyMTE1OV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDI3MTU1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40MzMx
NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2LjQzOTE0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuNDQ1MTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40NTExMzZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQ1NzEzMV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDYzMTI3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi40NjkxMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjQ3NTExOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNDgxMTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi40ODcxMDhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjQ5MzEwM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuNDk5MDk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi41MDUwOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjUxMTA5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTE3MDg1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41MjMwODBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2
LjUyOTA3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjYuNTM1MDcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNi41NDEwNjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjU0NzA2Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTUzMDU3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41
NTkwNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI2LjU2NTA0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjYuNTcxMDQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi41NzcwMzhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjU4MzAzM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNTg5
MDI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNi41OTUwMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI2LjYwMTAyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjA3MDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42MTMwMTFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjYxOTAw
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjYuNjI1MDAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNi42MzA5OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjYzNjk5Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjQyOTg4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42NDg5ODNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI2LjY1NDk3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjYuNjYwOTczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi42NjY5NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjY3Mjk2NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjc4OTYwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ni42ODQ5NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI2LjY5MDk1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNjk2OTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43MDI5NDFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjcwODkzOV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYu
NzE0OTM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNi43MjA5MzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI2LjcyNjkyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNzMyOTIwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43Mzg5MTZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljc0
NDkxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjYuNzUwOTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNi43NTY5MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljc2Mjg5N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuNzY4ODkyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43NzQ4
ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI2Ljc4MDg4M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjYuNzg2ODc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi43OTI4NzNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljc5ODg2OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODA0ODY3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNi44MTA4NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI2LjgxNjg1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODIyODU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi44Mjg4NDldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjgzNDg0NV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjYuODQwODQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNi44NDY4MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljg1MjgzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODU4ODI4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi44NjQ4MjJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2
Ljg3MDgxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjYuODc2ODE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNi44ODI4MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2Ljg4ODgwNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuODk0ODAwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi45
MDA4MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI2LjkwNjc5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjYuOTEyNzkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNi45MTg3OTBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI2LjkyNDc4NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjYuOTMw
NzgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNi45MzY3NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI2Ljk0MzcyNF0gaTQwZSAwMDAwOjAxOjAwLjI6IGZ3IDYuMC40ODQ0
MiBhcGkgMS43IG52bSA2LjAxIDB4ODAwMDM0ODUgMS4xNzQ3LjAgWzgwODY6MTU4OV0gWzgwODY6
MDAwMF0KWyAgIDI3LjIzMTgzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTYxNDQw
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjIzNzkyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTYxNDQwIGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjI1MTc5OF0gaTQwZSAwMDAwOjAx
OjAwLjI6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTo2YjplOTpjMgpbICAgMjcuMjU3Njg0XSBpNDBl
IDAwMDA6MDE6MDAuMjogRlcgTExEUCBpcyBlbmFibGVkClsgICAyNy4yNjg4MjhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjI3NDgy
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuMjgwODI0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy4yODY4MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjI5Mjk4MV0gaTQwZSAwMDAwOjAxOjAwLjI6IFBD
SS1FeHByZXNzOiBTcGVlZCA4LjBHVC9zIFdpZHRoIHg4ClsgICAyNy4zMDAyMzldIGk0MGUgMDAw
MDowMTowMC4yOiBGZWF0dXJlczogUEYtaWRbMl0gVlNJczogMzQgUVA6IDMyIFJTUyBGRF9BVFIg
RkRfU0IgTlRVUExFIFZ4TEFOIEdlbmV2ZSBQVFAgVkVQQQpbICAgMjcuMzEwNDA5XSBpNDBlIDAw
MDA6MDE6MDAuMzogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpClsgICAyNy4zMjczOTZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI3LjMzMzM5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTgxOTIgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjcuMzM5Mzk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4zNDUzOTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjM1MTM4Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMzU3MzgzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ny4zNjMzODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI3LjM2OTM3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuMzc1MzcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy4zODEzNjVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjM4NzM2MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcu
MzkzMzU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNy4zOTkzNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQwNTM0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDExMzQzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40MTczMzhdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQy
MzMzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjcuNDI5MzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNy40MzUzMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQ0MTMxOV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDQ3MzE1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40NTMz
MTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI3LjQ1OTMwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjcuNDY1MzAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy40NzEyOTddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjQ3NzI5Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNDgzMjg4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNy40ODkyODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI3LjQ5NTI3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTAxMjczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41MDcyNjldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjUxMzI2NF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjcuNTE5MjU5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNy41MjUyNTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjUzMTI1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTM3MjQ2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41NDMyNDFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3
LjU0OTIzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjcuNTU1MjMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNy41NjEyMjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjU2NzIyM10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNTczMjE4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41
NzkyMTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI3LjU4NTIwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjcuNTkxMjA0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy41OTcyMDBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjYwMzE5NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjA5
MTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNy42MTUxODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI3LjYyMTE4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjI3MTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42MzMxNzFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjYzOTE2
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuNjQ1MTYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy42NTExNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjY1NzE1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjYzMTQ4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42NjkxNDNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI3LjY3NTEzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjcuNjgxMTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy42ODcxMzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjY5MzEyNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNjk5MTIxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
Ny43MDUxMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI3LjcxMTExMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzE3MTA3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43MjMxMDNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjcyOTA5OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcu
NzM1MDk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyNy43NDEwOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljc0NzA4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzUzMDgwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43NTkwNzZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljc2
NTA3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjcuNzcxMDY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyNy43NzcwNjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljc4MzA1N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuNzg5MDUyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy43OTUw
NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI3LjgwMTA0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjcuODA3MDM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy44MTMwMzVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjgxOTAzMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODI1MDI3
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyNy44MzEwMjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI3LjgzNzAxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODQzMDE1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy44NDkwMTBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljg1NTAwNl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjcuODYxMDAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyNy44NjY5OTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljg3Mjk5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuODc4OTg3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy44ODQ5ODJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3
Ljg5MDk3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjcuODk2OTczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyNy45MDI5NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3LjkwODk2NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTE0OTYwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45
MjA5NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI3LjkyNjk1MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjcuOTMyOTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45Mzg5NDFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljk0NDkzNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTUw
OTMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyNy45NTY5MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI3Ljk2MjkyM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjcuOTY4OTE4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyNy45NzQ5MTRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljk4MDkw
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjcuOTg2OTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyNy45OTI5MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI3Ljk5ODg5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDA0ODkxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4wMTA4OTBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI4LjAxNjg4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguMDIyODgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4wMjg4NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjAzNDg3Ml0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDQwODY3XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC4wNDY4NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4LjA1Mjg1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDU4ODU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4wNjQ4NDldIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjA3MDg0NF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
MDc2ODM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC4wODI4MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4LjA4ODgzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMDk0ODI1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xMDA4MjBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjEw
NjgxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguMTEyODExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC4xMTg4MDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjEyNDgwMl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTMwNzk3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xMzY3
OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4LjE0Mjc4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguMTQ4NzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xNTQ3NzldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjE2MDc3NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTY2Nzcw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOC4xNzI3NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI4LjE3ODc2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMTg0NzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4xOTA3NTFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjE5Njc0N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguMjAyNzQyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC4yMDg3MzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjIxNDczM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjIwNzI4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yMjY3MjNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
LjIzMjcxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguMjM4NzE0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC4yNDQ3MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjI1MDcwNF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjU2Njk5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4y
NjI2OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4LjI2ODY5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguMjc0Njg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4yODA2ODFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjI4NjY3Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMjky
NjcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC4yOTg2NjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4LjMwNDY2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzEwNjU4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4zMTY2NTNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjMyMjY0
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjguMzI4NjQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOC4zMzQ2NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjM0MDY0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzQ2NjM5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4zNTI2MzRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI4LjM1ODYzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguMzY0NjI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC4zNzA2MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjM3NjYxNl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguMzgyNjEyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC4zODg2MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4LjM5NDYwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDAwNTk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40MDY1OTNdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQxMjU4OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
NDE4NTg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC40MjQ1NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQzMDU3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDM2NTcwXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40NDI1NjZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQ0
ODU2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguNDU0NTU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC40NjA1NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjQ2NjU0N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNDcyNTQyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40Nzg1
MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4LjQ4NDUzM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguNDkwNTI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC40OTY1MjRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjUwMjUyMF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTA4NTE1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOC41MTQ1MTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI4LjUyMDUwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTI2NTAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC41MzI0OTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjUzODQ5M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguNTQ0NDg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC41NTA0ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjU1NjQ3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTYyNDc2XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC41Njg0NzFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
LjU3NDQ2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguNTgwNDYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC41ODY0NThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjU5MjQ1M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNTk4NDQ5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42
MDQ0NDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4LjYxMDQ0MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguNjE2NDM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42MjI0MzFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjYyODQyNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjM0
NDIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC42NDA0MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4LjY0NjQxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjUyNDA4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42NTg0MDRdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjY2NDQw
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjguNjcwMzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOC42NzYzOTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjY4MjM4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNjg4MzgxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC42OTQzNzdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI4LjcwMDM3Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjguNzA2MzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC43MTIzNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjcxODM1OF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzI0MzUzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OC43MzAzNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI4LjczNjM0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzQyMzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC43NDgzMzddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljc1NDMzMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjgu
NzYwMzI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOC43NjYzMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljc3MjMyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguNzc4MzE3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC43ODQzMTJdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljc5
MDMwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjguNzk2MzAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOC44MDIyOTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjgwODI5NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODE0MjkwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44MjAy
ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI4LjgyNjI4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjguODMyMjc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44MzgyNzJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljg0NDI2N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODUwMjY0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOC44NTYyNjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI4Ljg2MjI1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguODY4MjUyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC44NzQyNDhdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljg4MDI0M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjguODg2MjM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOC44OTIyMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljg5ODIyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTA0MjI0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45MTAyMjBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4
LjkxNjIxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjguOTIyMjExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOC45MjgyMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4LjkzNDIwM10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTQwMTk4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45
NDYxOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI4Ljk1MjE4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjguOTU4MTg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOC45NjQxODFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI4Ljk3MDE3Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTc2
MTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOC45ODIxNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI4Ljk4ODE2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjguOTk0MTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wMDAxNTNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjAwNjE0
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjkuMDEyMTQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS4wMTgxNDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjAyNDEzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDMwMTM0XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wMzYxMjld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5LjA0MjEyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuMDQ4MTIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wNTQxMTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjA2MDExMF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDY2MTA2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS4wNzIxMDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5LjA3ODA5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMDg0MDkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4wOTAwODhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjA5NjA4M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
MTAyMDc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS4xMDgwNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5LjExNDA3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTIwMDY1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xMjYwNjBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjEz
MjA1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuMTM4MDUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS4xNDQwNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjE1MDA0Ml0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTU2MDM3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xNjIw
MzNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5LjE2ODAyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjkuMTc0MDIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4xODAwMTldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjE4NjAxNF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMTkyMDA5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS4xOTgwMDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5LjIwNDAwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMjA5OTk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4yMTU5OTFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjIyMTk4N10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuMjI3OTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS4yMzM5NzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjIzOTk3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMjQ1OTY4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4yNTE5NjNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
LjI1Nzk1OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuMjYzOTU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS4yNjk5NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjI3NTk0NV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMjgxOTQxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4y
ODc5MzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5LjI5MzkzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuMjk5OTI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zMDU5MjJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjMxMTkxN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzE3
OTEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOS4zMjM5MDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI5LjMyOTkwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzM1ODk5XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zNDE4OTVdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjM0Nzg5
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjkuMzUzODg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS4zNTk4ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjM2NTg4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuMzcxODgwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zNzc4NzZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5LjM4Mzg3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuMzg5ODY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS4zOTU4NjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQwMTg1N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDA3ODUyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS40MTM4NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5LjQxOTg0M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDI1ODM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS40MzE4MzRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQzNzgzMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
NDQzODI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS40NDk4MjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQ1NTgxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDYxODExXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS40Njc4MDZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQ3
MzgwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuNDc5Nzk2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS40ODU3OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjQ5MTc4N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNDk3NzgyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41MDM3
NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5LjUwOTc3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjkuNTE1NzY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41MjE3NjddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjUyNzc2Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTMzNzU4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS41Mzk3NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5LjU0NTc0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTUxNzQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41NTc3MzldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjU2MzczNF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuNTY5NzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS41NzU3MjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjU4MTcyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNTg3NzE1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS41OTM3MTFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
LjU5OTcwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuNjA1NzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS42MTE2OTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjYxNzY5M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjIzNjg4XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42
Mjk2ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5LjYzNTY3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuNjQxNjc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42NDc2NjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjY1MzY2NV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjU5
NjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAyOS42NjU2NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDI5LjY3MTY1MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNjc3NjQ2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS42ODM2NDFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjY4OTYz
N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMjkuNjk1NjMyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAyOS43MDE2MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjcwNzYyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNzEzNjE4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43MTk2MTNd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDI5LjcyNTYwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMjkuNzMxNjAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43Mzc1OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljc0MzU5NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNzQ5NTkwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAy
OS43NTU1ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDI5Ljc2MTU4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuNzY3NTc2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS43NzM1NzFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljc3OTU2Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjku
Nzg1NTYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAyOS43OTE1NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljc5NzU1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODAzNTQ3XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44MDk1NDRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljgx
NTUzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMjkuODIxNTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAyOS44Mjc1MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjgzMzUyNV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODM5NTIwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44NDU1
MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDI5Ljg1MTUxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMjkuODU3NTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44NjM1MDFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljg2OTQ5N10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODc1NDk0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAyOS44ODE0OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDI5Ljg4NzQ4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuODkzNDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS44OTk0NzZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjkwNTQ3Ml0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MjkuOTExNDY3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAyOS45MTc0NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5LjkyMzQ1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuOTI5NDU0XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45MzU0NDldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5
Ljk0MTQ0NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMjkuOTQ3NDQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAyOS45NTM0MzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljk1OTQzMF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMjkuOTY1NDI2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45
NzE0MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDI5Ljk3NzQxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMjkuOTgzNDEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAyOS45ODk0MDhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDI5Ljk5NTQwM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDAx
NDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMC4wMDczOTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMwLjAxMzM5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDE5Mzg1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wMjUzODFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjAzMTM3
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuMDM3MzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC4wNDMzNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjA0OTM2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDU1MzU4XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wNjEzNTRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjA2NzM0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuMDczMzQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4wNzkzMzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjA4NTMzNV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMDkxMzMwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC4wOTczMjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjEwMzMyMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMTA5MzE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4xMTUzMTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjEyMTMwN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
MTI3MzAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC4xMzMyOThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjEzOTI5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMTQ1Mjg5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4xNTEyODRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjE1
NzI4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuMTYzMjc0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC4xNjkyNzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjE3NTI2Nl0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMTgxMjYyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4xODcy
NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMwLjE5MzI1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuMTk5MjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yMDUyNDNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjIxMTIzOF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjE3MjM0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC4yMjMyMjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjIyOTIyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjM1MjIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yNDEyMTVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjI0NzIxMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuMjUzMjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC4yNTkyMDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjI2NTE5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMjcxMTkyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4yNzcxOTBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
LjI4MzE4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuMjg5MTgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC4yOTUxNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjMwMTE3Ml0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzA3MTY3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4z
MTMxNjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMwLjMxOTE1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzAuMzI1MTUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4zMzExNDhdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjMzNzE0NF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzQz
MTM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMC4zNDkxMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMwLjM1NTEzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzYxMTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC4zNjcxMjBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjM3MzEx
Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuMzc5MTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC4zODUxMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjM5MTEwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuMzk3MTA1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40MDMxMDBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjQwOTA5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTgxOTIgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuNDE1MDkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9ODE5
MiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40MjEwOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQyNzA4Nl0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDMzMDgyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC40MzkwNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjQ0NTA3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDUxMDY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40NTcwNjRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQ2MzA1OV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
NDY5MDU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC40NzUwNTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQ4MTA0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNDg3MDQxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC40OTMwMzZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjQ5
OTAzMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuNTA1MDI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC41MTEwMjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjUxNzAxOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTIzMDEzXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41Mjkw
MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMwLjUzNTAwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuNTQxMDAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41NDY5OTVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjU1Mjk5MV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTU4OTg2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC41NjQ5ODJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjU3MDk3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNTc2OTcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC41ODI5NjddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjU4ODk2M10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuNTk0OTU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC42MDA5NTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjYwNjk0OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNjEyOTQ1XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42MTg5NDBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
LjYyNDkzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuNjMwOTMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC42MzY5MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjY0MjkyMV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNjQ4OTE3XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42
NTQ5MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMwLjY2MDkwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzAuNjY2OTAzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC42NzI4OThdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjY3ODg5M10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNjg0
ODg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMC42OTA4ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMwLjY5Njg3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzAyODc0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43MDg4NzBdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjcxNDg2
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzAuNzIwODYxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMC43MjY4NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjczMjg1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzM4ODQ3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43NDQ4NDJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMwLjc1MDgzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzAuNzU2ODMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43NjI4MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjc2ODgyNF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzc0ODE5XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MC43ODA4MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMwLjc4NjgxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuNzkyODA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC43OTg4MDFdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjgwNDc5Nl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAu
ODEwNzkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMC44MTY3ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMwLjgyMjc4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuODI4Nzc4XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44MzQ3NzNdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjg0
MDc2OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzAuODQ2NzYzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMC44NTI3NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjg1ODc1NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuODY0NzUwXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44NzA3
NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMwLjg3Njc0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzAuODgyNzM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC44ODg3MzFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjg5NDcyNl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTAwNzI1
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMC45MDY3MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMwLjkxMjcxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTE4NzExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45MjQ3MDddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjkzMDcwMl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzAuOTM2Njk3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMC45NDI2OTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjk0ODY4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTU0NjgzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45NjA2NzldIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMw
Ljk2NjY3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzAuOTcyNjY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMC45Nzg2NjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMwLjk4NDY2MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzAuOTkwNjU1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMC45
OTY2NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMxLjAwMjY0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzEuMDA4NjQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wMTQ2MzddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjAyMDYzM10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDI2
NjI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS4wMzI2MjRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjAzODYxOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDQ0NjE2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wNTA2MTJdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjA1NjYw
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuMDYyNjAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS4wNjg1OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjA3NDU5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMDgwNTg5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4wODY1ODRd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjA5MjU4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuMDk4NTc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xMDQ1NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjExMDU2NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTE2NTYxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS4xMjI1NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjEyODU1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTM0NTQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xNDA1NDJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjE0NjUzN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
MTUyNTMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS4xNTg1MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjE2NDUyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMTcwNTE5XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4xNzY1MTRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjE4
MjUwOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzEuMTg4NTA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMS4xOTQ1MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjIwMDQ5N10gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjA2NDkyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yMTI0
ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjIxODQ4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuMjI0NDc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yMzA0NzNdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjIzNjQ2OV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjQyNDY0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS4yNDg0NjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjI1NDQ1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjYwNDUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4yNjY0NDVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjI3MjQ0MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuMjc4NDM2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS4yODQ0MzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjI5MDQyNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMjk2NDIyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4zMDI0MTddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
LjMwODQxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuMzE0NDA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMS4zMjA0MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjMyNjM5OF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzMyMzk0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4z
MzgzODldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMxLjM0NDM4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzEuMzUwMzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4zNTYzNzVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjM2MjM3MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzY4
MzY2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS4zNzQzNjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjM4MDM1Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuMzg2MzUxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS4zOTIzNDddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjM5ODM0
Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuNDA0MzQ0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS40MTAzNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQxNjMzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDIyMzMzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40MjgzMjld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjQzNDMyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuNDQwMzIwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40NDYzMTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQ1MjMxMV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDU4MzA2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS40NjQzMDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjQ3MDI5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNDc2MjkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS40ODIyODddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjQ4ODI4M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
NDk0Mjc4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS41MDAyNzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjUwNjI2OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTEyMjY1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41MTgyNjBdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjUy
NDI1NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzEuNTMwMjUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMS41MzYyNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjU0MjI0MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTQ4MjM3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41NTQy
MzJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjU2MDIyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuNTY2MjIzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS41NzIyMThdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjU3ODIxM10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNTg0MjA5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS41OTAyMDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjU5NjE5OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjAyMTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42MDgxOTFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjYxNDE4Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuNjIwMTgyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS42MjYxNzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjYzMjE3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjM4MTY4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42NDQxNjNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
LjY1MDE1OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuNjU2MTU0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMS42NjIxNDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjY2ODE0NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNjc0MTM5XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42
ODAxMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMxLjY4NjEzMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzEuNjkyMTI2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS42OTgxMjBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjcwNDExNl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzEw
MTExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMS43MTYxMDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMxLjcyMjEwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzI4MDk4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43MzQwOTNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjc0MDA4
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzEuNzQ2MDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMS43NTIwNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjc1ODA3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuNzY0MDcwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43NzAwNjZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMxLjc3NjA2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzEuNzgyMDU3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS43ODgwNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjc5NDA0N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODAwMDQ1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
MS44MDYwNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMxLjgxMjAzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODE4MDMxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44MjQwMjddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjgzMDAyMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEu
ODM2MDE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMS44NDIwMTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMxLjg0ODAwOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODU0MDAzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44NTk5OThdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjg2
NTk5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzEuODcxOTkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMS44Nzc5ODVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjg4Mzk4MF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuODg5OTc1XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS44OTU5
NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMxLjkwMTk2Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzEuOTA3OTYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS45MTM5NTddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjkxOTk1NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTI1OTUw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMS45MzE5NDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMxLjkzNzk0MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTQzOTM3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS45NDk5MzJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjk1NTkyN10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzEuOTYxOTIyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMS45Njc5MThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMxLjk3MzkxM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzEuOTc5OTA5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMS45ODU5MDRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMx
Ljk5MTkwMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzEuOTk3ODk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMi4wMDM4OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjAwOTg4Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDE1ODgzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4w
MjE4NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMyLjAyNzg3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzIuMDMzODY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wMzk4NjRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjA0NTg1OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDUx
ODU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMi4wNTc4NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMyLjA2Mzg0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMDY5ODQxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4wNzU4MzddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjA4MTgz
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzIuMDg3ODI3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMi4wOTM4MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjA5OTgxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTA1ODEzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4xMTE4MDld
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMyLjExNzgwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzIuMTIzODAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4xMjk3OTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjEzNTc5MF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTQxNzg1XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
Mi4xNDc3ODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMyLjE1Mzc3Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTU5NzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4xNjU3NjddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjE3MTc2M10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIu
MTc3NzU4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMi4xODM3NTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMyLjE4OTc0OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMTk1NzQ0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yMDE3MzldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjIw
NzczNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzIuMjEzNzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMi4yMTk3MjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjIyNTcyMV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjMxNzE3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yMzc3
MTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMyLjI0MzcwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzIuMjQ5NzAyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yNTU2OThdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjI2MTY5M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjY3Njg5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi4yNzM2ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjI3OTY4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMjg1Njc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4yOTE2NzFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjI5NzY2Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzIuMzAzNjYyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMi4zMDk2NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjMxNTY1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMzIxNjQ3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4zMjc2NDNdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMy
LjMzMzYzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzIuMzM5NjM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMi4zNDU2MjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjM1MTYyNV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMzU3NjIwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4z
NjM2MTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMyLjM2OTYxMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzIuMzc1NjA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi4zODE2MDFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjM4NzU5N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuMzkz
NTkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMi4zOTk1ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMyLjQwNTU4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNDExNTc4XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi40MTc1NzNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjQyMzU3
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzIuNDI5NTcxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMi40MzU1NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjQ0MTU2NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNDQ3NTYxXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi40NTM1NTZd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMyLjQ1OTU1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzIuNDY1NTQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi40NzE1NDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjQ3NzUzN10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNDgzNTMzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
Mi40ODk1MjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMyLjQ5NTUyNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNTAxNTE5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi41MDc1MTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjUxMzUxMF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIu
NTE5NTA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMi41MjU1MDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMyLjUzMTQ5Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNTM3NDkyXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi41NDM0ODddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjU0
OTQ4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzIuNTU1NDgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMi41NjE0NzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjU2NzQ3MV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNTczNDY3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi41Nzk0
NjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMyLjU4NTQ1N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzIuNTkxNDUzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi41OTc0NDhdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjYwMzQ0NF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjA5NDM4
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi42MTU0MzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjYyMTQyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjI3NDI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi42MzM0MjBdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjYzOTQxNl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzIuNjQ1NDExXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMi42NTE0MDddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjY1NzQwMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjYzMzk4XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi42NjkzOTJdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMy
LjY3NTM4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzIuNjgxMzg0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMi42ODczNzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjY5MzM3NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNjk5MzcwXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43
MDUzNjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMyLjcxMTM2MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzIuNzE3MzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43MjMzNTFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjcyOTM0Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzM1
MzQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMi43NDEzMzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMyLjc0NzMzMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzUzMzI3XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43NTkzMjNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjc2NTMx
OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzIuNzcxMzEzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMi43NzczMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjc4MzMwNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuNzg5Mjk5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi43OTUyOTVd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMyLjgwMTI5MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzIuODA3Mjg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi44MTMyODFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjgxOTI3N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuODI1MjcyXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
Mi44MzEyNjhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMyLjgzNzI2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuODQzMjYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi44NDkyNTRdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjg1NTI1MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIu
ODYxMjQ1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMi44NjcyNDFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMyLjg3MzIzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuODc5MjMxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi44ODUyMjZdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjg5
MTIyMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzIuODk3MjE3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMi45MDMyMTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjkwOTIwOF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuOTE1MjA0XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45MjEx
OTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMyLjkyNzE5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzIuOTMzMTg5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45MzkxODVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjk0NTE4Ml0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuOTUxMTc5
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMi45NTcxNzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMyLjk2MzE3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzIuOTY5MTY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMi45NzUxNjFdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjk4MTE1Nl0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzIuOTg3MTUxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMi45OTMxNDZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMyLjk5OTE0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMDA1MTM3XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4wMTExMzRdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMz
LjAxNzEyOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzMuMDIzMTI1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMy4wMjkxMjBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjAzNTExNl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMDQxMTEyXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4w
NDcxMDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMzLjA1MzEwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzMuMDU5MDk5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4wNjUwOTRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjA3MTA4OV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMDc3
MDg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMy4wODMwODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMzLjA4OTA3NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMDk1MDcxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4xMDEwNjZdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjEwNzA2
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzMuMTEzMDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMy4xMTkwNTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjEyNTA0N10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMTMxMDQzXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4xMzcwMzhd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMzLjE0MzAzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzMuMTQ5MDI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4xNTUwMjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjE2MTAyMF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMTY3MDE2XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
My4xNzMwMTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMzLjE3OTAwNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMTg1MDAxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4xOTA5OTddIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjE5Njk5Ml0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMu
MjAyOTg4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzMy4yMDg5ODNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDMzLjIxNDk3OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjIwOTc0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yMjY5NjldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjIz
Mjk2NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzMuMjM4OTYwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzMy4yNDQ5NTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjI1MDk1Ml0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjU2OTQ3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yNjI5
NDNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMzLjI2ODkzOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzMuMjc0OTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4yODA5MjldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjI4NjkyNV0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMjkyOTIw
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsg
ICAzMy4yOTg5MTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTAKWyAgIDMzLjMwNDkxMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMzEwOTEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4zMTY5MDVdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjMyMjkwMF0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzMuMzI4ODk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzMy4zMzQ4OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjM0MDg4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMzQ2ODgyXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4zNTI4NzddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMz
LjM1ODg3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MApbICAgMzMuMzY0ODY4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wClsgICAzMy4zNzA4NjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjM3Njg1OV0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuMzgyODU1XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy4z
ODg4NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDMzLjM5NDg0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzMuNDAwODQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy40MDY4MzddIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjQxMjgzMl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNDE4
ODI4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMy40MjQ4MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMzLjQzMDgxOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNDM2ODEzXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy40NDI4MDldIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjQ0ODgx
MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzMuNDU0ODA2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wClsgICAzMy40NjA4MDRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjQ2NjgwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNDcyNzk2XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy40Nzg3OTJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAg
IDMzLjQ4NDc4N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzMuNDkxNzM2XSBpNDBlIDAwMDA6MDE6MDAuMzogZncgNi4wLjQ4NDQyIGFw
aSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4NSAxLjE3NDcuMCBbODA4NjoxNTg5XSBbODA4NjowMDAw
XQpbICAgMzMuNzc5NzA1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NjE0NDAgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzMuNzg1Nzg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NjE0NDAgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuNzkzMzU2XSBpNDBlIDAwMDA6MDE6MDAu
MzogTUFDIGFkZHJlc3M6IDNjOmZkOmZlOjZiOmU5OmMzClsgICAzMy43OTkyNDJdIGk0MGUgMDAw
MDowMTowMC4zOiBGVyBMTERQIGlzIGVuYWJsZWQKWyAgIDMzLjgxMDQ0NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuODE2NDQzXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
My44MjI0MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDMzLjgyODQzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuODM0NTk4XSBpNDBlIDAwMDA6MDE6MDAuMzogUENJLUV4
cHJlc3M6IFNwZWVkIDguMEdUL3MgV2lkdGggeDgKWyAgIDMzLjg0MTkwN10gaTQwZSAwMDAwOjAx
OjAwLjM6IEZlYXR1cmVzOiBQRi1pZFszXSBWU0lzOiAzNCBRUDogMzIgUlNTIEZEX0FUUiBGRF9T
QiBOVFVQTEUgVnhMQU4gR2VuZXZlIFBUUCBWRVBBClsgICAzMy44NTIwMjZdIGVoY2lfaGNkOiBV
U0IgMi4wICdFbmhhbmNlZCcgSG9zdCBDb250cm9sbGVyIChFSENJKSBEcml2ZXIKWyAgIDMzLjg1
ODU1MV0gZWhjaS1wY2k6IEVIQ0kgUENJIHBsYXRmb3JtIGRyaXZlcgpbICAgMzMuODYzMTE4XSB4
aGNpX2hjZCAwMDBkOjAxOjAwLjI6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAwMDAyKQpbICAg
MzMuODY5MjM4XSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IHhIQ0kgSG9zdCBDb250cm9sbGVyClsg
ICAzMy44NzQ0NTldIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogbmV3IFVTQiBidXMgcmVnaXN0ZXJl
ZCwgYXNzaWduZWQgYnVzIG51bWJlciAxClsgICAzMy44ODIzOTVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT0yMDU2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjg4ODM5MV0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTIwNTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuODk0
MzkwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzMy45MDAzODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDMzLjkwNjM4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTEyMzgwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy45MTgzNzddIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjkyNDM3
M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApb
ICAgMzMuOTMwMzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9MTYgZmxhZ3M9Y2Mw
IGF0dHI9MApbICAgMzMuOTM2MTk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9MTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTQyMDMzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9MjQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTQ3ODU0XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9MjQgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTUzNjc2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy45NTk2
NzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAK
WyAgIDMzLjk2NTY2N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MApbICAgMzMuOTcxNjY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzMy45Nzc2NjFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDMzLjk4MzY1Nl0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzMuOTg5Njc0
XSB4aGNpX2hjZCAwMDBkOjAxOjAwLjI6IGhjYyBwYXJhbXMgMHgwMTgwZmYwNSBoY2kgdmVyc2lv
biAweDExMCBxdWlya3MgMHgwMDAwMDAwMDAwMDAwMDEwClsgICAzMy45OTkxMjhdIGh1YiAxLTA6
MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC4wMDI4ODJdIGh1YiAxLTA6MS4wOiAyIHBvcnRzIGRl
dGVjdGVkClsgICAzNC4wMDcwMDRdIHhoY2lfaGNkIDAwMGQ6MDE6MDAuMjogeEhDSSBIb3N0IENv
bnRyb2xsZXIKWyAgIDM0LjAxMjIyM10geGhjaV9oY2QgMDAwZDowMTowMC4yOiBuZXcgVVNCIGJ1
cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDIKWyAgIDM0LjAxOTYwOV0geGhjaV9o
Y2QgMDAwZDowMTowMC4yOiBIb3N0IHN1cHBvcnRzIFVTQiAzLjEgRW5oYW5jZWQgU3VwZXJTcGVl
ZApbICAgMzQuMDI2NjY5XSB1c2IgdXNiMjogV2UgZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGhtcyBm
b3IgTFBNIGZvciB0aGlzIGhvc3QsIGRpc2FibGluZyBMUE0uClsgICAzNC4wMzQ4NzRdIGh1YiAy
LTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC4wMzg2MjVdIGh1YiAyLTA6MS4wOiA0IHBvcnRz
IGRldGVjdGVkClsgICAzNC4wNDI5MDJdIHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogeEhDSSBIb3N0
IENvbnRyb2xsZXIKWyAgIDM0LjA0ODEyMl0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBuZXcgVVNC
IGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDMKWyAgIDM0LjA2MDgxMl0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTIwNTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQu
MDY2ODA4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9MjA1NiBmbGFncz1jYzAgYXR0
cj0wClsgICAzNC4wNzI4MDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDM0LjA3ODgwMV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMDg0ODAzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4wOTA3OTldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjA5
Njc5N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MApbICAgMzQuMTAyNzkzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wClsgICAzNC4xMDg3OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT0xNiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4xMTQ2MTJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT0xNiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4xMjA0NDldIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT0zMiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4xMjYyNzFdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT0zMiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4x
MzIwOTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTAKWyAgIDM0LjEzODA4OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MApbICAgMzQuMTQ0MDg1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4xNTAwODFdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjE1NjA3N10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMTYy
MDcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzNC4xNjgwNjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTAKWyAgIDM0LjE3NDA2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMTgwMDkzXSB4aGNpX2hjZCAwMDA0OjAzOjAw
LjA6IGhjYyBwYXJhbXMgMHgwMTQwNTFjZiBoY2kgdmVyc2lvbiAweDEwMCBxdWlya3MgMHgwMDAw
MDAxMTAwMDAwNDEwClsgICAzNC4xOTExMThdIGh1YiAzLTA6MS4wOiBVU0IgaHViIGZvdW5kClsg
ICAzNC4xOTQ4NzVdIGh1YiAzLTA6MS4wOiA0IHBvcnRzIGRldGVjdGVkClsgICAzNC4xOTkwNTNd
IHhoY2lfaGNkIDAwMDQ6MDM6MDAuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgIDM0LjIwNDI3
Ml0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25l
ZCBidXMgbnVtYmVyIDQKWyAgIDM0LjIxMTY2Nl0geGhjaV9oY2QgMDAwNDowMzowMC4wOiBIb3N0
IHN1cHBvcnRzIFVTQiAzLjAgU3VwZXJTcGVlZApbICAgMzQuMjE3OTYwXSB1c2IgdXNiNDogV2Ug
ZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGhtcyBmb3IgTFBNIGZvciB0aGlzIGhvc3QsIGRpc2FibGlu
ZyBMUE0uClsgICAzNC4yMjYxNjJdIGh1YiA0LTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC4y
Mjk5MTRdIGh1YiA0LTA6MS4wOiA0IHBvcnRzIGRldGVjdGVkClsgICAzNC4yMzQxODNdIHhoY2lf
aGNkIDAwMDU6MDI6MDAuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgIDM0LjIzOTQwNF0geGhj
aV9oY2QgMDAwNTowMjowMC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMg
bnVtYmVyIDUKWyAgIDM0LjM1NzcwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTIw
NTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMzYzNjk4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9MjA1NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC4zNjk2OTZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjM3NTY5MV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAg
MzQuMzgxNjkyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wClsgICAzNC4zODc2ODddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjM5MzY4NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuMzk5NjgxXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC40MDU2NzddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT0xNiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC40
MTE0OThdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT0xNiBmbGFncz1jYzAgYXR0cj0w
ClsgICAzNC40MTczMzVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT0zMiBmbGFncz1j
YzAgYXR0cj0wClsgICAzNC40MjMxNTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT0z
MiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC40Mjg5NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjQzNDk3NV0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuNDQwOTcxXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAz
NC40NDY5NjZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTAKWyAgIDM0LjQ1Mjk2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQuNDU4OTU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNC40NjQ5NTJdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM0LjQ3MDk0OF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzQu
NDc2OTc3XSB4aGNpX2hjZCAwMDA1OjAyOjAwLjA6IGhjYyBwYXJhbXMgMHgwMTQwNTFjZiBoY2kg
dmVyc2lvbiAweDEwMCBxdWlya3MgMHgwMDAwMDAxMTAwMDAwNDEwClsgICAzNC40ODY4OTddIGh1
YiA1LTA6MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC40OTA2NTJdIGh1YiA1LTA6MS4wOiA0IHBv
cnRzIGRldGVjdGVkClsgICAzNC40OTQ4MjhdIHhoY2lfaGNkIDAwMDU6MDI6MDAuMDogeEhDSSBI
b3N0IENvbnRyb2xsZXIKWyAgIDM0LjUwMDA0Nl0geGhjaV9oY2QgMDAwNTowMjowMC4wOiBuZXcg
VVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVyIDYKWyAgIDM0LjUwNzQzM10g
eGhjaV9oY2QgMDAwNTowMjowMC4wOiBIb3N0IHN1cHBvcnRzIFVTQiAzLjAgU3VwZXJTcGVlZApb
ICAgMzQuNTEzNzIzXSB1c2IgdXNiNjogV2UgZG9uJ3Qga25vdyB0aGUgYWxnb3JpdGhtcyBmb3Ig
TFBNIGZvciB0aGlzIGhvc3QsIGRpc2FibGluZyBMUE0uClsgICAzNC41MjE5MjJdIGh1YiA2LTA6
MS4wOiBVU0IgaHViIGZvdW5kClsgICAzNC41MjU2NzRdIGh1YiA2LTA6MS4wOiA0IHBvcnRzIGRl
dGVjdGVkClsgICAzNC41MzAwMzddIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBk
cml2ZXIgdXNiLXN0b3JhZ2UKWyAgIDM0LjUzNjg5NV0gcnRjLWVmaSBydGMtZWZpLjA6IHJlZ2lz
dGVyZWQgYXMgcnRjMApbICAgMzQuNTQyMDI3XSBydGMtZWZpIHJ0Yy1lZmkuMDogc2V0dGluZyBz
eXN0ZW0gY2xvY2sgdG8gMjAyMi0wNC0yMFQxMDo0NjowMiBVVEMgKDE2NTA0NTE1NjIpClsgICAz
NC41NTA1MjldIHNic2EtZ3dkdCBzYnNhLWd3ZHQuMDogSW5pdGlhbGl6ZWQgd2l0aCAxMHMgdGlt
ZW91dCBAIDI1MDAwMDAwIEh6LCBhY3Rpb249MC4KWyAgIDM0LjU1ODc4Ml0gZGV2aWNlLW1hcHBl
cjogaW9jdGw6IDQuNDMuMC1pb2N0bCAoMjAyMC0xMC0wMSkgaW5pdGlhbGlzZWQ6IGRtLWRldmVs
QHJlZGhhdC5jb20KWyAgIDM0LjU2ODI1OV0gcHN0b3JlOiBSZWdpc3RlcmVkIGVmaSBhcyBwZXJz
aXN0ZW50IHN0b3JlIGJhY2tlbmQKWyAgIDM0LjU3NDEwNl0gU01DQ0M6IFNPQ19JRDogSUQgPSBq
ZXAxMDY6MGExNjowMDAxIFJldmlzaW9uID0gMHgwMDAwMDBhMQpbICAgMzQuNTgwNzI4XSB1c2Jj
b3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmhpZApbICAgMzQuNTg2Mjkw
XSB1c2JoaWQ6IFVTQiBISUQgY29yZSBkcml2ZXIKWyAgIDM0LjU4Nzk0NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuNTkwMTQzXSB1
MzIgY2xhc3NpZmllcgpbICAgMzQuNTk2MTA5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC41OTYxMTJdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjU5ODgwNV0gICAgIGlu
cHV0IGRldmljZSBjaGVjayBvbgpbICAgMzQuNTk4ODA3XSAgICAgQWN0aW9ucyBjb25maWd1cmVk
ClsgICAzNC42MDQ4MDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWMwMCBhdHRyPTAKWyAgIDM0LjYxMTE3Nl0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZhbWls
eSAxMApbICAgMzQuNjE0NDUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jMDAgYXR0cj0wClsgICAzNC42MTQ0NTJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjYxODI1N10gU2VnbWVudCBSb3V0aW5n
IHdpdGggSVB2NgpbICAgMzQuNjIzODQwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC42MjM4NDJdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjY1NTkzN10gc2l0OiBJUHY2
LCBJUHY0IGFuZCBNUExTIG92ZXIgSVB2NCB0dW5uZWxpbmcgZHJpdmVyClsgICAzNC42NjE5ODJd
IE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMTcKWyAgIDM0LjY2NjQzNF0gQnJpZGdl
IGZpcmV3YWxsaW5nIHJlZ2lzdGVyZWQKWyAgIDM0LjY3MDQ1M10gS2V5IHR5cGUgZG5zX3Jlc29s
dmVyIHJlZ2lzdGVyZWQKWyAgIDM0LjY3NDc3NF0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZh
bWlseSA0MApbICAgMzQuNjc5MzMyXSBLZXkgdHlwZSAuX2ZzY3J5cHQgcmVnaXN0ZXJlZApbICAg
MzQuNjgzMzMzXSBLZXkgdHlwZSAuZnNjcnlwdCByZWdpc3RlcmVkClsgICAzNC42ODcyNDZdIEtl
eSB0eXBlIGZzY3J5cHQtcHJvdmlzaW9uaW5nIHJlZ2lzdGVyZWQKWyAgIDM0LjY5MjQxM10gQnRy
ZnMgbG9hZGVkLCBjcmMzMmM9Y3JjMzJjLWdlbmVyaWMKWyAgIDM0LjY5NzAyMF0gcHN0b3JlOiBV
c2luZyBjcmFzaCBkdW1wIGNvbXByZXNzaW9uOiBkZWZsYXRlClsgICAzNC43MDMwOTRdIEtleSB0
eXBlIGVuY3J5cHRlZCByZWdpc3RlcmVkClsgICAzNC43MDczNTRdIEJFUlQ6IEVycm9yIHJlY29y
ZHMgZnJvbSBwcmV2aW91cyBib290OgpbICAgMzQuNzEyMjI3XSBbSGFyZHdhcmUgRXJyb3JdOiBl
dmVudCBzZXZlcml0eTogcmVjb3ZlcmFibGUKWyAgIDM0LjcxNzYxNl0gW0hhcmR3YXJlIEVycm9y
XTogIEVycm9yIDAsIHR5cGU6IGZhdGFsClsgICAzNC43MjI0ODZdIFtIYXJkd2FyZSBFcnJvcl06
ICAgc2VjdGlvbiB0eXBlOiB1bmtub3duLCBlOGVkODk4ZC1kZjE2LTQzY2MtOGVjYy01NGYwNjBl
ZjE1N2YKWyAgIDM0LjczMDgyNV0gW0hhcmR3YXJlIEVycm9yXTogICBzZWN0aW9uIGxlbmd0aDog
MHgzMQpbICAgMzQuNzM1NzgyXSBbSGFyZHdhcmUgRXJyb3JdOiAgIDAwMDAwMDAwOiAwMDAwMDA3
ZiA2ZTZiNmU1NSAyMDZlNzc2ZiA2ZjYyNjU3MiAgLi4uLlVua25vd24gcmVibwpbICAgMzQuNzM1
ODEwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0w
ClsgICAzNC43NDQ0NzBdIFtIYXJkd2FyZSBFcnJvcl06ICAgMDAwMDAwMTA6IDcyMjA3NDZmIDZm
NzM2MTY1IDAwMDAwMDZlIDAwMDAwMDAwICBvdCByZWFzb24uLi4uLi4uClsgICAzNC43NDQ0NzNd
IFtIYXJkd2FyZSBFcnJvcl06ICAgMDAwMDAwMjA6IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAw
IDAwMDAwMDAwICAuLi4uLi4uLi4uLi4uLi4uClsgICAzNC43NDQ0NzRdIFtIYXJkd2FyZSBFcnJv
cl06ICAgMDAwMDAwMzA6IDExICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAuClsgICAzNC43NzYyNzddIHVzYiAzLTQ6IG5ldyBoaWdoLXNwZWVkIFVTQiBkZXZp
Y2UgbnVtYmVyIDIgdXNpbmcgeGhjaV9oY2QKWyAgIDM0Ljc3NjI4M10gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuNzc2Mjg2XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC43
NzYyOTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRy
PTAKWyAgIDM0Ljc4MjgxMV0gcHJpbnRrOiBjb25zb2xlIFtuZXRjb24wXSBlbmFibGVkClsgICAz
NC43ODI4MTNdIG5ldGNvbnNvbGU6IG5ldHdvcmsgbG9nZ2luZyBzdGFydGVkClsgICAzNC43ODg4
MTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAK
WyAgIDM0LjgxNTY3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
YzAwIGF0dHI9MApbICAgMzQuODE1NjgxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC44Mjc2NzRdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM0LjgzMzY4OF0gbWQ6IFdhaXRp
bmcgZm9yIGFsbCBkZXZpY2VzIHRvIGJlIGF2YWlsYWJsZSBiZWZvcmUgYXV0b2RldGVjdApbICAg
MzQuODQwNDcwXSBtZDogSWYgeW91IGRvbid0IHVzZSByYWlkLCB1c2UgcmFpZD1ub2F1dG9kZXRl
Y3QKWyAgIDM0Ljg0NjExOF0gbWQ6IEF1dG9kZXRlY3RpbmcgUkFJRCBhcnJheXMuClsgICAzNC44
NTAyMDRdIG1kOiBhdXRvcnVuIC4uLgpbICAgMzQuODUyOTg3XSBtZDogLi4uIGF1dG9ydW4gRE9O
RS4KWyAgIDM0Ljg1NjMyOV0gV2FpdGluZyBmb3Igcm9vdCBkZXZpY2UgL2Rldi9zZGEyLi4uClsg
ICAzNC45NjAxOTBdIHVzYiA2LTE6IG5ldyBTdXBlclNwZWVkIEdlbiAxIFVTQiBkZXZpY2UgbnVt
YmVyIDIgdXNpbmcgeGhjaV9oY2QKWyAgIDM0Ljk4MTI2MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzQuOTg3MjYwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNC45OTMyNjdd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAg
IDM0Ljk5OTI3MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAw
IGF0dHI9MApbICAgMzUuMDA3OTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz04MDAgYXR0cj0wClsgICAzNS4wMTM5NTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1LjAzMjMyNF0gaHViIDMtNDoxLjA6
IFVTQiBodWIgZm91bmQKWyAgIDM1LjAzNjA3OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuMDQyMDc1XSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS4wNDgwNzddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjA1
NDA3Nl0gaHViIDMtNDoxLjA6IDUgcG9ydHMgZGV0ZWN0ZWQKWyAgIDM1LjA1ODA4MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuMDY0
MDgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0w
ClsgICAzNS4wNzAxMzRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWMwMCBhdHRyPTAKWyAgIDM1LjA3NjEzOV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuMDgyMTQxXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS4wOTAwODhdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1LjA5NjA5
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9ODAwIGF0dHI9MApb
ICAgMzUuMTE2MTU2XSB1c2Itc3RvcmFnZSA2LTE6MS4wOiBVU0IgTWFzcyBTdG9yYWdlIGRldmlj
ZSBkZXRlY3RlZApbICAgMzUuMTIyMzg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wClsgICAzNS4xMjgzODVdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAKWyAgIDM1LjEzNDQ0N10gc2NzaSBob3N0
MDogdXNiLXN0b3JhZ2UgNi0xOjEuMApbICAgMzUuMzEyMzYyXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS4zMTgzNjFdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjMyNDM1
OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApb
ICAgMzUuMzMwMzU1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
MDAgYXR0cj0wClsgICAzNS4zMzYzNTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjM0MjM0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuNDM5NDM2XSB1c2IgMy00LjE6
IG5ldyBoaWdoLXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVyIDMgdXNpbmcgeGhjaV9oY2QKWyAgIDM1
LjU3MzM1M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0
dHI9MApbICAgMzUuNTc5MzUwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jMDAgYXR0cj0wClsgICAzNS41ODUzNDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1LjU5MTM0NF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuNTk3MzQxXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS42
MDMzMzddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRy
PTAKWyAgIDM1LjYwOTMzNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9YzAwIGF0dHI9MApbICAgMzUuNjE1MzMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS42MjMzMjldIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1LjYyOTMyN10gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9ODAwIGF0dHI9MApbICAgMzUuNjQz
NTUyXSB1c2Itc3RvcmFnZSAzLTQuMToxLjA6IFVTQiBNYXNzIFN0b3JhZ2UgZGV2aWNlIGRldGVj
dGVkClsgICAzNS42NDk5NTVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTAKWyAgIDM1LjY1NTk1Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MApbICAgMzUuNjYyMDEwXSBzY3NpIGhvc3QxOiB1c2It
c3RvcmFnZSAzLTQuMToxLjAKWyAgIDM1LjY2OTc4Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuNjc1Nzc5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS42ODE3NzhdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1
LjY4Nzc3M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0
dHI9MApbICAgMzUuNjkzNzcyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jMDAgYXR0cj0wClsgICAzNS42OTk3NjldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1Ljc5MTQzN10gdXNiIDMtNC4yOiBuZXcg
aGlnaC1zcGVlZCBVU0IgZGV2aWNlIG51bWJlciA0IHVzaW5nIHhoY2lfaGNkClsgICAzNS45MjQ5
MzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAK
WyAgIDM1LjkzMDkzNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
YzAwIGF0dHI9MApbICAgMzUuOTM2OTM0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNS45NDI5MzBdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM1Ljk0ODkyN10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuOTU0OTI0
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsg
ICAzNS45NjA5MjFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMw
MCBhdHRyPTAKWyAgIDM1Ljk2NjkxN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzUuOTc0NjM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz04MDAgYXR0cj0wClsgICAzNS45ODA2MzRdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM1Ljk5Njg3Nl0g
dXNiLXN0b3JhZ2UgMy00LjI6MS4wOiBVU0IgTWFzcyBTdG9yYWdlIGRldmljZSBkZXRlY3RlZApb
ICAgMzYuMDAzMzM5XSBzY3NpIGhvc3QyOiB1c2Itc3RvcmFnZSAzLTQuMjoxLjAKWyAgIDM2LjAx
Mjg5MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9
MApbICAgMzYuMDE4ODkxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jMDAgYXR0cj0wClsgICAzNi4wMjQ4OTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM2LjAzMDg4NV0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzYuMDM2ODgyXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNi4wNDI4
NzhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAK
WyAgIDM2LjEzOTQzNV0gdXNiIDMtNC4zOiBuZXcgbG93LXNwZWVkIFVTQiBkZXZpY2UgbnVtYmVy
IDUgdXNpbmcgeGhjaV9oY2QKWyAgIDM2LjE1MDc0Ml0gc2NzaSAwOjA6MDowOiBEaXJlY3QtQWNj
ZXNzICAgICAgVVNCICAgICAgU2FuRGlzayAzLjJHZW4xIDEuMDAgUFE6IDAgQU5TSTogNgpbICAg
MzYuMTU5MzUyXSBzZCAwOjA6MDowOiBbc2RhXSAxMjAxNzY2NDAgNTEyLWJ5dGUgbG9naWNhbCBi
bG9ja3M6ICg2MS41IEdCLzU3LjMgR2lCKQpbICAgMzYuMTY5NzIyXSBzZCAwOjA6MDowOiBbc2Rh
XSBXcml0ZSBQcm90ZWN0IGlzIG9mZgpbICAgMzYuMTgwMDc0XSBzZCAwOjA6MDowOiBbc2RhXSBX
cml0ZSBjYWNoZTogZGlzYWJsZWQsIHJlYWQgY2FjaGU6IGVuYWJsZWQsIGRvZXNuJ3Qgc3VwcG9y
dCBEUE8gb3IgRlVBClsgICAzNi4yMzI4ODVdIEdQVDpQcmltYXJ5IGhlYWRlciB0aGlua3MgQWx0
LiBoZWFkZXIgaXMgbm90IGF0IHRoZSBlbmQgb2YgdGhlIGRpc2suClsgICAzNi4yNDAyNzVdIEdQ
VDoxNzE4MTk1MSAhPSAxMjAxNzY2MzkKWyAgIDM2LjI0MzkyOF0gR1BUOkFsdGVybmF0ZSBHUFQg
aGVhZGVyIG5vdCBhdCB0aGUgZW5kIG9mIHRoZSBkaXNrLgpbICAgMzYuMjQ5OTIzXSBHUFQ6MTcx
ODE5NTEgIT0gMTIwMTc2NjM5ClsgICAzNi4yNTM1NzVdIEdQVDogVXNlIEdOVSBQYXJ0ZWQgdG8g
Y29ycmVjdCBHUFQgZXJyb3JzLgpbICAgMzYuMjU4NzA4XSAgc2RhOiBzZGExIHNkYTIKWyAgIDM2
LjI2NzQ5MF0gc2QgMDowOjA6MDogW3NkYV0gQXR0YWNoZWQgU0NTSSByZW1vdmFibGUgZGlzawpb
ICAgMzYuMjg0MzE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
MDAgYXR0cj0wClsgICAzNi4yOTAzMTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAgIDM2LjI5NjMxNl0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9YzAwIGF0dHI9MApbICAgMzYuMzAyMzExXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNi4zMDgzMTBd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAKWyAg
IDM2LjMwODk4OF0gcmFuZG9tOiBmYXN0IGluaXQgZG9uZQpbICAgMzYuMzE0MzA3XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jMDAgYXR0cj0wClsgICAzNi4zMjM2
OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWMwMCBhdHRyPTAK
WyAgIDM2LjMyOTY4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
YzAwIGF0dHI9MApbICAgMzYuMzM3NzQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz04MDAgYXR0cj0wClsgICAzNi4zNDM3NDddIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPTgwMCBhdHRyPTAKWyAgIDM2LjM3MzgxN10gaW5wdXQ6IEFt
ZXJpY2FuIE1lZ2F0cmVuZHMgSW5jLiBWaXJ0dWFsIEtleWJvYXJkIGFuZCBNb3VzZSBhcyAvZGV2
aWNlcy9wY2kwMDA0OjAwLzAwMDQ6MDA6MDMuMC8wMDA0OjAzOjAwLjAvdXNiMy8zLTQvMy00LjMv
My00LjM6MS4wLzAwMDM6MDQ2QjpGRjEwLjAwMDEvaW5wdXQvaW5wdXQxClsgICAzNi4zODk2NzZd
IGhpZC1nZW5lcmljIDAwMDM6MDQ2QjpGRjEwLjAwMDE6IGlucHV0OiBVU0IgSElEIHYxLjEwIEtl
eWJvYXJkIFtBbWVyaWNhbiBNZWdhdHJlbmRzIEluYy4gVmlydHVhbCBLZXlib2FyZCBhbmQgTW91
c2VdIG9uIHVzYi0wMDA0OjAzOjAwLjAtNC4zL2lucHV0MApbICAgMzYuNDE3NjMwXSBpbnB1dDog
QW1lcmljYW4gTWVnYXRyZW5kcyBJbmMuIFZpcnR1YWwgS2V5Ym9hcmQgYW5kIE1vdXNlIGFzIC9k
ZXZpY2VzL3BjaTAwMDQ6MDAvMDAwNDowMDowMy4wLzAwMDQ6MDM6MDAuMC91c2IzLzMtNC8zLTQu
My8zLTQuMzoxLjEvMDAwMzowNDZCOkZGMTAuMDAwMi9pbnB1dC9pbnB1dDIKWyAgIDM2LjQzMzQ3
N10gaGlkLWdlbmVyaWMgMDAwMzowNDZCOkZGMTAuMDAwMjogaW5wdXQ6IFVTQiBISUQgdjEuMTAg
TW91c2UgW0FtZXJpY2FuIE1lZ2F0cmVuZHMgSW5jLiBWaXJ0dWFsIEtleWJvYXJkIGFuZCBNb3Vz
ZV0gb24gdXNiLTAwMDQ6MDM6MDAuMC00LjMvaW5wdXQxClsgICAzNi42OTE5NzldIHNjc2kgMTow
OjA6MDogQ0QtUk9NICAgICAgICAgICAgQU1JICAgICAgVmlydHVhbCBDRFJPTTAgICAxLjAwIFBR
OiAwIEFOU0k6IDAgQ0NTClsgICAzNi43MDA3MTVdIHNjc2kgMTowOjA6MTogQ0QtUk9NICAgICAg
ICAgICAgQU1JICAgICAgVmlydHVhbCBDRFJPTTEgICAxLjAwIFBROiAwIEFOU0k6IDAgQ0NTClsg
ICAzNi43MDk0MzFdIHNjc2kgMTowOjA6MjogQ0QtUk9NICAgICAgICAgICAgQU1JICAgICAgVmly
dHVhbCBDRFJPTTIgICAxLjAwIFBROiAwIEFOU0k6IDAgQ0NTClsgICAzNi43MTgxNTVdIHNjc2kg
MTowOjA6MzogQ0QtUk9NICAgICAgICAgICAgQU1JICAgICAgVmlydHVhbCBDRFJPTTMgICAxLjAw
IFBROiAwIEFOU0k6IDAgQ0NTClsgICAzNi45NDgwNzFdIEVYVDQtZnMgKHNkYTIpOiByZWNvdmVy
eSBjb21wbGV0ZQpbICAgMzYuOTU1MDU5XSBFWFQ0LWZzIChzZGEyKTogbW91bnRlZCBmaWxlc3lz
dGVtIHdpdGggb3JkZXJlZCBkYXRhIG1vZGUuIE9wdHM6IChudWxsKQpbICAgMzYuOTYyNzMwXSBW
RlM6IE1vdW50ZWQgcm9vdCAoZXh0NCBmaWxlc3lzdGVtKSBvbiBkZXZpY2UgODoyLgpbICAgMzYu
OTcxMjY0XSBkZXZ0bXBmczogbW91bnRlZApbICAgMzYuOTc1ODY3XSBGcmVlaW5nIHVudXNlZCBr
ZXJuZWwgbWVtb3J5OiA0MTYwSwpbICAgMzYuOTgwNDQyXSBSdW4gL3NiaW4vaW5pdCBhcyBpbml0
IHByb2Nlc3MKWyAgIDM3LjA0MTYzMl0gc2NzaSAyOjA6MDowOiBEaXJlY3QtQWNjZXNzICAgICBB
TUkgICAgICBWaXJ0dWFsIEhEaXNrMCAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM3LjA1
MDUyOV0gc2NzaSAyOjA6MDoxOiBEaXJlY3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhE
aXNrMSAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM3LjA1OTQ4MF0gc2NzaSAyOjA6MDoy
OiBEaXJlY3QtQWNjZXNzICAgICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrMiAgIDEuMDAgUFE6IDAg
QU5TSTogMCBDQ1MKWyAgIDM3LjA2ODMxOF0gc2NzaSAyOjA6MDozOiBEaXJlY3QtQWNjZXNzICAg
ICBBTUkgICAgICBWaXJ0dWFsIEhEaXNrMyAgIDEuMDAgUFE6IDAgQU5TSTogMCBDQ1MKWyAgIDM3
LjA3NjE5NF0gc2QgMjowOjA6MDogW3NkYl0gQXR0YWNoZWQgU0NTSSByZW1vdmFibGUgZGlzawpb
ICAgMzcuMDgyNDI5XSBzY3NpIDI6MDowOjQ6IERpcmVjdC1BY2Nlc3MgICAgIEFNSSAgICAgIFZp
cnR1YWwgSERpc2s0ICAgMS4wMCBQUTogMCBBTlNJOiAwIENDUwpbICAgMzcuMDk3MTA3XSBzZCAy
OjA6MDoxOiBbc2RjXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNrClsgICAzNy4xMDU2MTld
IHNkIDI6MDowOjI6IFtzZGRdIEF0dGFjaGVkIFNDU0kgcmVtb3ZhYmxlIGRpc2sKWyAgIDM3LjEx
MTM2NV0gc2QgMjowOjA6MzogW3NkZV0gQXR0YWNoZWQgU0NTSSByZW1vdmFibGUgZGlzawpbICAg
MzcuMTEyMzE3XSBzZCAyOjA6MDo0OiBbc2RmXSBBdHRhY2hlZCBTQ1NJIHJlbW92YWJsZSBkaXNr
ClsgICAzNy4xNDYxMTFdIHN5c3RlbWRbMV06IHN5c3RlbWQgMjQ5LjcrIHJ1bm5pbmcgaW4gc3lz
dGVtIG1vZGUgKC1QQU0gLUFVRElUIC1TRUxJTlVYIC1BUFBBUk1PUiArSU1BIC1TTUFDSyArU0VD
Q09NUCAtR0NSWVBUIC1HTlVUTFMgLU9QRU5TU0wgK0FDTCArQkxLSUQgLUNVUkwgLUVMRlVUSUxT
IC1GSURPMiAtSUROMiAtSUROIC1JUFRDICtLTU9EIC1MSUJDUllQVFNFVFVQICtMSUJGRElTSyAt
UENSRTIgLVBXUVVBTElUWSAtUDExS0lUIC1RUkVOQ09ERSAtQlpJUDIgLUxaNCAtWFogLVpMSUIg
K1pTVEQgK1hLQkNPTU1PTiArVVRNUCArU1lTVklOSVQgZGVmYXVsdC1oaWVyYXJjaHk9aHlicmlk
KQpbICAgMzcuMTc2NTQ1XSBzeXN0ZW1kWzFdOiBEZXRlY3RlZCBhcmNoaXRlY3R1cmUgYXJtNjQu
CgpXZWxjb21lIHRvIEVXQU9MIChFZGdlIFdvcmtsb2FkIEFic3RyYWN0aW9uIGFuZCBPcmNoZXN0
cmF0aW9uIExheWVyKSB1bnN0YWJsZSAoaG9uaXN0ZXIpIQoKWyAgIDM3LjIzNzY4Ml0gc3lzdGVt
ZFsxXTogSG9zdG5hbWUgc2V0IHRvIDxjb21ocGM+LgpbICAgMzcuMjg4NzIxXSBzeXN0ZW1kLXN5
c3YtZ2VuZXJhdG9yWzMzMV06IFN5c1Ygc2VydmljZSAnL2V0Yy9pbml0LmQvY29ubnRyYWNrZCcg
bGFja3MgYSBuYXRpdmUgc3lzdGVtZCB1bml0IGZpbGUuIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGlu
ZyBhIHVuaXQgZmlsZSBmb3IgY29tcGF0aWJpbGl0eS4gUGxlYXNlIHVwZGF0ZSBwYWNrYWdlIHRv
IGluY2x1ZGUgYSBuYXRpdmUgc3lzdGVtZCB1bml0IGZpbGUsIGluIG9yZGVyIHRvIG1ha2UgaXQg
bW9yZSBzYWZlIGFuZCByb2J1c3QuClsgICAzNy4zMTI3MzNdIHN5c3RlbWQtc3lzdi1nZW5lcmF0
b3JbMzMxXTogU3lzViBzZXJ2aWNlICcvZXRjL2luaXQuZC9jb25udHJhY2stZmFpbG92ZXInIGxh
Y2tzIGEgbmF0aXZlIHN5c3RlbWQgdW5pdCBmaWxlLiBBdXRvbWF0aWNhbGx5IGdlbmVyYXRpbmcg
YSB1bml0IGZpbGUgZm9yIGNvbXBhdGliaWxpdHkuIFBsZWFzZSB1cGRhdGUgcGFja2FnZSB0byBp
bmNsdWRlIGEgbmF0aXZlIHN5c3RlbWQgdW5pdCBmaWxlLCBpbiBvcmRlciB0byBtYWtlIGl0IG1v
cmUgc2FmZSBhbmQgcm9idXN0LgpbICAgMzcuNDA0MjYxXSBzeXN0ZW1kWzFdOiAvbGliL3N5c3Rl
bWQvc3lzdGVtL3hlbi1xZW11LWRvbTAtZGlzay1iYWNrZW5kLnNlcnZpY2U6MTE6IFBJREZpbGU9
IHJlZmVyZW5jZXMgYSBwYXRoIGJlbG93IGxlZ2FjeSBkaXJlY3RvcnkgL3Zhci9ydW4vLCB1cGRh
dGluZyAvdmFyL3J1bi94ZW4vcWVtdS1kb20wLnBpZCDihpIgL3J1bi94ZW4vcWVtdS1kb20wLnBp
ZDsgcGxlYXNlIHVwZGF0ZSB0aGUgdW5pdCBmaWxlIGFjY29yZGluZ2x5LgpbICAgMzcuNDkxOTA0
XSBzeXN0ZW1kWzFdOiBRdWV1ZWQgc3RhcnQgam9iIGZvciBkZWZhdWx0IHRhcmdldCBNdWx0aS1V
c2VyIFN5c3RlbS4KWyAgIDM3LjQ5OTUwNl0gcmFuZG9tOiBzeXN0ZW1kOiB1bmluaXRpYWxpemVk
IHVyYW5kb20gcmVhZCAoMTYgYnl0ZXMgcmVhZCkKWyAgIDM3LjUzMTUxOV0gc3lzdGVtZFsxXTog
Q3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVtL2dldHR5LgpbICBPSyAgXSBDcmVhdGVkIHNsaWNl
IFNsaWNlIC9zeXN0ZW0vZ2V0dHkuClsgICAzNy41NDM3MTFdIHJhbmRvbTogc3lzdGVtZDogdW5p
bml0aWFsaXplZCB1cmFuZG9tIHJlYWQgKDE2IGJ5dGVzIHJlYWQpClsgICAzNy41NTEwMzNdIHN5
c3RlbWRbMV06IENyZWF0ZWQgc2xpY2UgU2xpY2UgL3N5c3RlbS9tb2Rwcm9iZS4KWyAgT0sgIF0g
Q3JlYXRlZCBzbGljZSBTbGljZSAvc3lzdGVtL21vZHByb2JlLgpbICAgMzcuNTcxNTU4XSByYW5k
b206IHN5c3RlbWQ6IHVuaW5pdGlhbGl6ZWQgdXJhbmRvbSByZWFkICgxNiBieXRlcyByZWFkKQpb
ICAgMzcuNTc4NzY1XSBzeXN0ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vc2Vy
aWFsLWdldHR5LgpbICBPSyAgXSBDcmVhdGVkIHNsaWNlIFNsaWNlIC9zeXN0ZW0vc2VyaWFsLWdl
dHR5LgpbICAgMzcuNjAwMzU2XSBzeXN0ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIFVzZXIgYW5kIFNl
c3Npb24gU2xpY2UuClsgIE9LICBdIENyZWF0ZWQgc2xpY2UgVXNlciBhbmQgU2Vzc2lvbiBTbGlj
ZS4KWyAgIDM3LjYyMzc5OF0gc3lzdGVtZFsxXTogU3RhcnRlZCBEaXNwYXRjaCBQYXNzd29yZCBS
ZXF1ZXN0cyB0byBDb25zb2xlIERpcmVjdG9yeSBXYXRjaC4KWyAgT0sgIF0gU3RhcnRlZCBEaXNw
YXRjaCBQYXNzd29yZCDigKZ0cyB0byBDb25zb2xlIERpcmVjdG9yeSBXYXRjaC4KWyAgIDM3LjY0
MDY1OV0gc3lzdGVtZFsxXTogU3RhcnRlZCBGb3J3YXJkIFBhc3N3b3JkIFJlcXVlc3RzIHRvIFdh
bGwgRGlyZWN0b3J5IFdhdGNoLgpbICBPSyAgXSBTdGFydGVkIEZvcndhcmQgUGFzc3dvcmQgUuKA
pnVlc3RzIHRvIFdhbGwgRGlyZWN0b3J5IFdhdGNoLgpbICAgMzcuNjYzNjMzXSBzeXN0ZW1kWzFd
OiBSZWFjaGVkIHRhcmdldCBQYXRoIFVuaXRzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBQYXRo
IFVuaXRzLgpbICAgMzcuNjgzNTQxXSBzeXN0ZW1kWzFdOiBSZWFjaGVkIHRhcmdldCBSZW1vdGUg
RmlsZSBTeXN0ZW1zLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBSZW1vdGUgRmlsZSBTeXN0ZW1z
LgpbICAgMzcuNjk3OTE4XSBzeXN0ZW1kWzFdOiBSZWFjaGVkIHRhcmdldCBTbGljZSBVbml0cy4K
WyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU2xpY2UgVW5pdHMuClsgICAzNy43MTU1NDRdIHN5c3Rl
bWRbMV06IFJlYWNoZWQgdGFyZ2V0IFN3YXBzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTd2Fw
cy4KWyAgIDM3Ljc0Mjg0OV0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIFJQQ2JpbmQgU2VydmVy
IEFjdGl2YXRpb24gU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gUlBDYmluZCBTZXJ2ZXIg
QWN0aXZhdGlvbiBTb2NrZXQuClsgICAzNy43NjM2NTRdIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFy
Z2V0IFJQQyBQb3J0IE1hcHBlci4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgUlBDIFBvcnQgTWFw
cGVyLgpbICAgMzcuNzc2NTEzXSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gU3lzbG9nIFNvY2tl
dC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIFN5c2xvZyBTb2NrZXQuClsgICAzNy43OTU3MjRdIHN5
c3RlbWRbMV06IExpc3RlbmluZyBvbiBpbml0Y3RsIENvbXBhdGliaWxpdHkgTmFtZWQgUGlwZS4K
WyAgT0sgIF0gTGlzdGVuaW5nIG9uIGluaXRjdGwgQ29tcGF0aWJpbGl0eSBOYW1lZCBQaXBlLgpb
ICAgMzcuODIwODA5XSBzeXN0ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gSm91
cm5hbCBBdWRpdCBTb2NrZXQgYmVpbmcgc2tpcHBlZC4KWyAgIDM3LjgyODk2Nl0gc3lzdGVtZFsx
XTogTGlzdGVuaW5nIG9uIEpvdXJuYWwgU29ja2V0ICgvZGV2L2xvZykuClsgIE9LICBdIExpc3Rl
bmluZyBvbiBKb3VybmFsIFNvY2tldCAoL2Rldi9sb2cpLgpbICAgMzcuODUxODI3XSBzeXN0ZW1k
WzFdOiBMaXN0ZW5pbmcgb24gSm91cm5hbCBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiBK
b3VybmFsIFNvY2tldC4KWyAgIDM3Ljg3MTg5MV0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIE5l
dHdvcmsgU2VydmljZSBOZXRsaW5rIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIE5ldHdv
cmsgU2VydmljZSBOZXRsaW5rIFNvY2tldC4KWyAgIDM3Ljg5MzA5NV0gc3lzdGVtZFsxXTogTGlz
dGVuaW5nIG9uIHVkZXYgQ29udHJvbCBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiB1ZGV2
IENvbnRyb2wgU29ja2V0LgpbICAgMzcuOTExNzM5XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24g
dWRldiBLZXJuZWwgU29ja2V0LgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gdWRldiBLZXJuZWwgU29j
a2V0LgpbICAgMzcuOTI0MTk1XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gVXNlciBEYXRhYmFz
ZSBNYW5hZ2VyIFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIFVzZXIgRGF0YWJhc2UgTWFu
YWdlciBTb2NrZXQuClsgICAzNy45NDUwODRdIHN5c3RlbWRbMV06IE1vdW50aW5nIEh1Z2UgUGFn
ZXMgRmlsZSBTeXN0ZW0uLi4KICAgICAgICAgTW91bnRpbmcgSHVnZSBQYWdlcyBGaWxlIFN5c3Rl
bS4uLgpbICAgMzcuOTY4OTY3XSBzeXN0ZW1kWzFdOiBNb3VudGluZyBQT1NJWCBNZXNzYWdlIFF1
ZXVlIEZpbGUgU3lzdGVtLi4uCiAgICAgICAgIE1vdW50aW5nIFBPU0lYIE1lc3NhZ2UgUXVldWUg
RmlsZSBTeXN0ZW0uLi4KWyAgIDM3Ljk5MTY4OV0gc3lzdGVtZFsxXTogQ29uZGl0aW9uIGNoZWNr
IHJlc3VsdGVkIGluIE1vdW50IC9wcm9jL3hlbiBmaWxlcyBiZWluZyBza2lwcGVkLgpbICAgMzgu
MDAwODY5XSBzeXN0ZW1kWzFdOiBNb3VudGluZyBLZXJuZWwgRGVidWcgRmlsZSBTeXN0ZW0uLi4K
ICAgICAgICAgTW91bnRpbmcgS2VybmVsIERlYnVnIEZpbGUgU3lzdGVtLi4uClsgICAzOC4wMjEw
MDldIHN5c3RlbWRbMV06IE1vdW50aW5nIEtlcm5lbCBUcmFjZSBGaWxlIFN5c3RlbS4uLgogICAg
ICAgICBNb3VudGluZyBLZXJuZWwgVHJhY2UgRmlsZSBTeXN0ZW0uLi4KWyAgIDM4LjA1MjMyNl0g
c3lzdGVtZFsxXTogTW91bnRpbmcgVGVtcG9yYXJ5IERpcmVjdG9yeSAvdG1wLi4uCiAgICAgICAg
IE1vdW50aW5nIFRlbXBvcmFyeSBEaXJlY3RvcnkgL3RtcC4uLgpbICAgMzguMDcxNzk3XSBzeXN0
ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gQ3JlYXRlIExpc3Qgb2YgU3RhdGlj
IERldmljZSBOb2RlcyBiZWluZyBza2lwcGVkLgpbICAgMzguMDgyMDc2XSBzeXN0ZW1kWzFdOiBT
dGFydGluZyBMb2FkIEtlcm5lbCBNb2R1bGUgY29uZmlnZnMuLi4KICAgICAgICAgU3RhcnRpbmcg
TG9hZCBLZXJuZWwgTW9kdWxlIGNvbmZpZ2ZzLi4uClsgICAzOC4xMDQ5NzRdIHN5c3RlbWRbMV06
IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBkcm0uLi4KICAgICAgICAgU3RhcnRpbmcgTG9h
ZCBLZXJuZWwgTW9kdWxlIGRybS4uLgpbICAgMzguMTI0OTAxXSBzeXN0ZW1kWzFdOiBTdGFydGlu
ZyBMb2FkIEtlcm5lbCBNb2R1bGUgZnVzZS4uLgogICAgICAgICBTdGFydGluZyBMb2FkIEtlcm5l
bCBNb2R1bGUgZnVzZS4uLgpbICAgMzguMTQ1MDc5XSBzeXN0ZW1kWzFdOiBTdGFydGluZyBSUEMg
QmluZC4uLgogICAgICAgICBTdGFydGluZyBSUEMgQmluZC4uLgpbICAgMzguMTU5NDI2XSBzeXN0
ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gRmlsZSBTeXN0ZW0gQ2hlY2sgb24g
Um9vdCBEZXZpY2UgYmVpbmcgc2tpcHBlZC4KWyAgIDM4LjE3MDM1OF0gc3lzdGVtZFsxXTogU3Rh
cnRpbmcgSm91cm5hbCBTZXJ2aWNlLi4uCiAgICAgICAgIFN0YXJ0aW5nIEpvdXJuYWwgU2Vydmlj
ZS4uLgpbICAgMzguMTk0MzY1XSBzeXN0ZW1kWzFdOiBTdGFydGluZyBMb2FkIEtlcm5lbCBNb2R1
bGVzLi4uCiAgICAgICAgIFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZXMuLi4KWyAgIDM4LjIx
MjcwMV0gc3lzdGVtZFsxXTogU3RhcnRpbmcgUmVtb3VudCBSb290IGFuZCBLZXJuZWwgRmlsZSBT
eXN0ZW1zLi4uCiAgICAgICAgIFN0YXJ0aW5nIFJlbW91blsgICAzOC4yMjA1MDVdIEVYVDQtZnMg
KHNkYTIpOiByZS1tb3VudGVkLiBPcHRzOiAobnVsbCkKdCBSb290IGFuZCBLZXJuZWwgRmlsZSBT
eXN0ZW1zLi4uClsgICAzOC4yNDA3NDBdIHN5c3RlbWRbMV06IFN0YXJ0aW5nIENvbGRwbHVnIEFs
bCB1ZGV2IERldmljZXMuLi4KICAgICAgICAgU3RhcnRpbmcgQ29sZHBsdWcgQWxsIHVkZXYgRGV2
aWNlcy4uLgpbICAgMzguMjYxMzM1XSBzeXN0ZW1kWzFdOiBTdGFydGVkIFJQQyBCaW5kLgpbICBP
SyAgXSBTdGFydGVkIFJQQyBCaW5kLgpbICAgMzguMjc5NzMyXSBzeXN0ZW1kWzFdOiBTdGFydGVk
IEpvdXJuYWwgU2VydmljZS4KWyAgT0sgIF0gU3RhcnRlZCBKb3VybmFsIFNlcnZpY2UuClsgIE9L
ICBdIE1vdW50ZWQgSHVnZSBQYWdlcyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91bnRlZCBQT1NJ
WCBNZXNzYWdlIFF1ZXVlIEZpbGUgU3lzdGVtLgpbICBPSyAgXSBNb3VudGVkIEtlcm5lbCBEZWJ1
ZyBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gTW91bnRlZCBLZXJuZWwgVHJhY2UgRmlsZSBTeXN0ZW0u
ClsgIE9LICBdIE1vdW50ZWQgVGVtcG9yYXJ5IERpcmVjdG9yeSAvdG1wLgpbICBPSyAgXSBGaW5p
c2hlZCBMb2FkIEtlcm5lbCBNb2R1bGUgY29uZmlnZnMuClsgIE9LICBdIEZpbmlzaGVkIExvYWQg
S2VybmVsIE1vZHVsZSBkcm0uClsgIE9LICBdIEZpbmlzaGVkIExvYWQgS2VybmVsIE1vZHVsZSBm
dXNlLgpbRkFJTEVEXSBGYWlsZWQgdG8gc3RhcnQgTG9hZCBLZXJuZWwgTW9kdWxlcy4KU2VlICdz
eXN0ZW1jdGwgc3RhdHVzIHN5c3RlbWQtbW9kdWxlcy1sb2FkLnNlcnZpY2UnIGZvciBkZXRhaWxz
LgpbICBPSyAgXSBGaW5pc2hlZCBSZW1vdW50IFJvb3QgYW5kIEtlcm5lbCBGaWxlIFN5c3RlbXMu
CiAgICAgICAgIE1vdW50aW5nIEtlcm5lbCBDb25maWd1cmF0aW9uIEZpbGUgU3lzdGVtLi4uCiAg
ICAgICAgIFN0YXJ0aW5nIEZsdXNoIEpvdXJuYWwgdG8gUGVyc2lzdGVudCBTdG9yYWdlLi4uClsg
ICAzOC40NzkyNzFdIHN5c3RlbWQtam91cm5hbGRbMzU0XTogUmVjZWl2ZWQgY2xpZW50IHJlcXVl
c3QgdG8gZmx1c2ggcnVudGltZSBqb3VybmFsLgogICAgICAgICBTdGFydGluZyBBcHBseSBLZXJu
ZWwgVmFyaWFibGVzLi4uCiAgICAgICAgIFN0YXJ0aW5nIENyZWF0ZSBTdGF0aWMgRGV2aWNlIE5v
ZGVzIGluIC9kZXYuLi4KWyAgT0sgIF0gTW91bnRlZCBLZXJuZWwgQ29uZmlndXJhdGlvbiBGaWxl
IFN5c3RlbS4KWyAgT0sgIF0gRmluaXNoZWQgRmx1c2ggSm91cm5hbCB0byBQZXJzaXN0ZW50IFN0
b3JhZ2UuClsgIE9LICBdIEZpbmlzaGVkIEFwcGx5IEtlcm5lbCBWYXJpYWJsZXMuClsgIE9LICBd
IEZpbmlzaGVkIENvbGRwbHVnIEFsbCB1ZGV2IERldmljZXMuClsgIE9LICBdIEZpbmlzaGVkIENy
ZWF0ZSBTdGF0aWMgRGV2aWNlIE5vZGVzIGluIC9kZXYuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0
IFByZXBhcmF0aW9uIGZvciBMb2NhbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIE1vdW50aW5nIC92
YXIvdm9sYXRpbGUuLi4KICAgICAgICAgU3RhcnRpbmcgV2FpdCBmb3IgdWRldiBUbyDigKZwbGV0
ZSBEZXZpY2UgSW5pdGlhbGl6YXRpb24uLi4KICAgICAgICAgU3RhcnRpbmcgUnVsZS1iYXNlZCBN
YW5hZ2XigKZmb3IgRGV2aWNlIEV2ZW50cyBhbmQgRmlsZXMuLi4KWyAgT0sgIF0gTW91bnRlZCAv
dmFyL3ZvbGF0aWxlLgogICAgICAgICBTdGFydGluZyBMb2FkL1NhdmUgUmFuZG9tIFNlZWQuLi4K
WyAgT0sgIF0gU3RhcnRlZCBSdWxlLWJhc2VkIE1hbmFnZXIgZm9yIERldmljZSBFdmVudHMgYW5k
IEZpbGVzLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gTG9hZC9TYXZlIFJGIOKApml0Y2ggU3RhdHVz
IC9kZXYvcmZraWxsIFdhdGNoLgpbICBPSyAgXSBGb3VuZCBkZXZpY2UgU2FuRGlza18zLjJHZW4x
IG1zZG9zLgogICAgICAgICBNb3VudGluZyAvYm9vdC4uLgpbICBPSyAgXSBNb3VudGVkIC9ib290
LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBMb2NhbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIFN0
YXJ0aW5nIENyZWF0ZSBWb2xhdGlsZSBGaWxlcyBhbmQgRGlyZWN0b3JpZXMuLi4KWyAgT0sgIF0g
RmluaXNoZWQgQ3JlYXRlIFZvbGF0aWxlIEZpbGVzIGFuZCBEaXJlY3Rvcmllcy4KICAgICAgICAg
U3RhcnRpbmcgTmV0d29yayBUaW1lIFN5bmNocm9uaXphdGlvbi4uLgogICAgICAgICBTdGFydGlu
ZyBSZWNvcmQgU3lzdGVtIEJvb3QvU2h1dGRvd24gaW4gVVRNUC4uLgpbICBPSyAgXSBGaW5pc2hl
ZCBXYWl0IGZvciB1ZGV2IFRvIENvbXBsZXRlIERldmljZSBJbml0aWFsaXphdGlvbi4KWyAgT0sg
IF0gU3RhcnRlZCBIYXJkd2FyZSBSTkcgRW50cm9weSBHYXRoZXJlciBEYWVtb24uClsgIE9LICBd
IEZpbmlzaGVkIFJlY29yZCBTeXN0ZW0gQm9vdC9TaHV0ZG93biBpbiBVVE1QLgpbICBPSyAgXSBT
dGFydGVkIE5ldHdvcmsgVGltZSBTeW5jaHJvbml6YXRpb24uClsgIE9LICBdIFJlYWNoZWQgdGFy
Z2V0IFN5c3RlbSBJbml0aWFsaXphdGlvbi4KWyAgT0sgIF0gU3RhcnRlZCBEYWlseSBDbGVhbnVw
IG9mIFRlbXBvcmFyeSBEaXJlY3Rvcmllcy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU3lzdGVt
IFRpbWUgU2V0LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBUaW1lciBVbml0cy4KWyAgT0sgIF0g
TGlzdGVuaW5nIG9uIEF2YWhpIG1ETlMvRE5TLVNEIFN0YWNrIEFjdGl2YXRpb24gU29ja2V0Lgpb
ICBPSyAgXSBMaXN0ZW5pbmcgb24gRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVzIFNvY2tldC4KICAg
ICAgICAgU3RhcnRpbmcgRG9ja2VyIFNvY2tldCBmb3IgdGhlIEFQSS4uLgogICAgICAgICBTdGFy
dGluZyBzc2hkLnNvY2tldC4uLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gRG9ja2VyIFNvY2tldCBm
b3IgdGhlIEFQSS4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIHNzaGQuc29ja2V0LgpbICBPSyAgXSBS
ZWFjaGVkIHRhcmdldCBTb2NrZXQgVW5pdHMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEJhc2lj
IFN5c3RlbS4KICAgICAgICAgU3RhcnRpbmcgQUNQSSBFdmVudCBEYWVtb24uLi4KWyAgT0sgIF0g
U3RhcnRlZCBLZXJuZWwgTG9nZ2luZyBTZXJ2aWNlLgpbICBPSyAgXSBTdGFydGVkIFN5c3RlbSBM
b2dnaW5nIFNlcnZpY2UuClsgIE9LICBdIFN0YXJ0ZWQgRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVz
LgpbICBPSyAgXSBTdGFydGVkIEdldHR5IG9uIHR0eTEuCiAgICAgICAgIFN0YXJ0aW5nIElQdjYg
UGFja2V0IEZpbHRlcmluZyBGcmFtZXdvcmsuLi4KICAgICAgICAgU3RhcnRpbmcgSVB2NCBQYWNr
ZXQgRmlsdGVyaW5nIEZyYW1ld29yay4uLgogICAgICAgICBTdGFydGluZyBUZWxlcGhvbnkgc2Vy
dmljZS4uLgpbICBPSyAgXSBTdGFydGVkIFNlcmlhbCBHZXR0eSBvbiB0dHlBTUEwLgpbICBPSyAg
XSBSZWFjaGVkIHRhcmdldCBMb2dpbiBQcm9tcHRzLgogICAgICAgICBTdGFydGluZyBVc2VyIExv
Z2luIE1hbmFnZW1lbnQuLi4KICAgICAgICAgU3RhcnRpbmcgT3BlblNTSCBLZXkgR2VuZXJhdGlv
bi4uLgpbICBPSyAgXSBTdGFydGVkIEFDUEkgRXZlbnQgRGFlbW9uLgpbICBPSyAgXSBGaW5pc2hl
ZCBJUHY2IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3JrLgpbICBPSyAgXSBGaW5pc2hlZCBJUHY0
IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3JrLgpbICBPSyAgXSBGaW5pc2hlZCBPcGVuU1NIIEtl
eSBHZW5lcmF0aW9uLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBQcmVwYXJhdGlvbiBmb3IgTmV0
d29yay4KICAgICAgICAgU3RhcnRpbmcgTmV0d29yayBDb25maWd1cmF0aW9uLi4uClsgIE9LICBd
IFN0YXJ0ZWQgVXNlciBMb2dpbiBNYW5hZ2VtZW50LgpbICBPSyAgXSBTdGFydGVkIFRlbGVwaG9u
eSBzZXJ2aWNlLgpbICBPSyAgXSBTdGFydGVkIE5ldHdvcmsgQ29uZmlndXJhdGlvbi4KICAgICAg
ICAgU3RhcnRpbmcgV2FpdCBmb3IgTmV0d29yayB0byBiZSBDb25maWd1cmVkLi4uCiAgICAgICAg
IFN0YXJ0aW5nIE5ldHdvcmsgTmFtZSBSZXNvbHV0aW9uLi4uClsgIE9LICBdIFN0YXJ0ZWQgTmV0
d29yayBOYW1lIFJlc29sdXRpb24uClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IE5ldHdvcmsuClsg
IE9LICBdIFJlYWNoZWQgdGFyZ2V0IEhvc3QgYW5kIE5ldHdvcmsgTmFtZSBMb29rdXBzLgogICAg
ICAgICBTdGFydGluZyBBdmFoaSBtRE5TL0ROUy1TRCBTdGFjay4uLgogICAgICAgICBTdGFydGlu
ZyBjb250YWluZXJkIGNvbnRhaW5lciBydW50aW1lLi4uClsgIE9LICBdIEZpbmlzaGVkIExvYWQv
U2F2ZSBSYW5kb20gU2VlZC4KWyAgT0sgIF0gU3RhcnRlZCBBdmFoaSBtRE5TL0ROUy1TRCBTdGFj
ay4KWyAgT0sgIF0gU3RhcnRlZCBjb250YWluZXJkIGNvbnRhaW5lciBydW50aW1lLgoKRVdBT0wg
KEVkZ2UgV29ya2xvYWQgQWJzdHJhY3Rpb24gYW5kIE9yY2hlc3RyYXRpb24gTGF5ZXIpIHVuc3Rh
YmxlIGNvbWhwYyB0dHlBTUEwCgpjb21ocGMgbG9naW46IAo=

--_007_5C7EC3F4912646E8932160878357F939armcom_
Content-Type: application/octet-stream; name="xen_boot_debug.log"
Content-Description: xen_boot_debug.log
Content-Disposition: attachment; filename="xen_boot_debug.log"; size=173164;
	creation-date="Wed, 20 Apr 2022 11:05:02 GMT";
	modification-date="Wed, 20 Apr 2022 11:05:02 GMT"
Content-ID: <299B7F7B008C174C86BB230936B3E7F5@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

TGFzdCBsb2dpbjogV2VkIEFwciAyMCAxMToxMToxNSBvbiB0dHlzMDAwDQpyYWhzaW4wMUBDMDJa
WDBHOUxWRE4gfiAlIHRlbG5ldCBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29tIDEwMDIwDQpUcnlp
bmcgMTAuMS4xOTQuMjUuLi4NCkNvbm5lY3RlZCB0byBlMTIzMzQzLmNhbWJyaWRnZS5hcm0uY29t
Lg0KRXNjYXBlIGNoYXJhY3RlciBpcyAnXl0nLg0KDQpBSVMgdGFyZ2V0IHN5c3RlbSBwb3J0IDEw
MDIwIGRldmljZSAvZGV2L3R0eVVTQjEgWzExNTIwMCBOODFdDQoNCg0KRlMwOlw+IA0KRlMwOlw+
IA0KRlMwOlw+IHhlbi5lZmkNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0K
DQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0K
DQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNClhlbiA0LjE1LjEg
KGMvcyBGcmkgU2VwIDEwIDA5OjAzOjI0IDIwMjEgKzAyMDAgZ2l0Ojg0ZmE5OTA5OWItZGlydHkp
IEVGSSBsb2FkZXINClVzaW5nIGNvbmZpZ3VyYXRpb24gZmlsZSAneGVuLmNmZycNCkltYWdlLXhl
bjogMHgwMDAwMDAwMGZlNDdjMDAwLTB4MDAwMDAwMDBmZmIzZjIwMA0KUFJPR1JFU1MgQ09ERTog
VjAzMTAxMDE5IEkwDQogWGVuIDQuMTUuMQ0KKFhFTikgWGVuIHZlcnNpb24gNC4xNS4xICh4ZW4t
NC4xNStzdGFibGVBVVRPSU5DKzg0ZmE5OTA5OWItcjBAZXdhb2wpIChhYXJjaDY0LXBva3ktbGlu
dXgtZ2NjIChHQ0MpIDExLjIuMCkgZGVidWc9biAyMDIxLTA5LTEwDQooWEVOKSBMYXRlc3QgQ2hh
bmdlU2V0OiBGcmkgU2VwIDEwIDA5OjAzOjI0IDIwMjEgKzAyMDAgZ2l0Ojg0ZmE5OTA5OWItZGly
dHkNCihYRU4pIGJ1aWxkLWlkOiA3ODM0NDhjMzhhYTZmZjQ2NWU2YjQ2MzE4NTNiYzczMDc2YmNm
N2U0DQooWEVOKSBQcm9jZXNzb3I6IDQxM2ZkMGMxOiAiQVJNIExpbWl0ZWQiLCB2YXJpYW50OiAw
eDMsIHBhcnQgMHhkMGMsIHJldiAweDENCihYRU4pIDY0LWJpdCBFeGVjdXRpb246DQooWEVOKSAg
IFByb2Nlc3NvciBGZWF0dXJlczogMTEwMDAwMDAxMTExMTExMiAwMDAwMDAwMDAwMDAwMDIwDQoo
WEVOKSAgICAgRXhjZXB0aW9uIExldmVsczogRUwzOjY0IEVMMjo2NCBFTDE6NjQgRUwwOjY0KzMy
DQooWEVOKSAgICAgRXh0ZW5zaW9uczogRmxvYXRpbmdQb2ludCBBZHZhbmNlZFNJTUQgR0lDdjMt
U3lzUmVnDQooWEVOKSAgIERlYnVnIEZlYXR1cmVzOiAwMDAwMDAwMTEwMzA1NDA4IDAwMDAwMDAw
MDAwMDAwMDANCihYRU4pICAgQXV4aWxpYXJ5IEZlYXR1cmVzOiAwMDAwMDAwMDAwMDAwMDAwIDAw
MDAwMDAwMDAwMDAwMDANCihYRU4pICAgTWVtb3J5IE1vZGVsIEZlYXR1cmVzOiAwMDAwMDAwMDAw
MTAxMTI1IDAwMDAwMDAwMTAyMTIxMjINCihYRU4pICAgSVNBIEZlYXR1cmVzOiAgMDAwMDEwMDAx
MDIxMTEyMCAwMDAwMDAwMDAwMTAwMDAxDQooWEVOKSAzMi1iaXQgRXhlY3V0aW9uOg0KKFhFTikg
ICBQcm9jZXNzb3IgRmVhdHVyZXM6IDEwMDEwMTMxOjEwMDEwMDAwDQooWEVOKSAgICAgSW5zdHJ1
Y3Rpb24gU2V0czogQUFyY2gzMiBBMzIgVGh1bWIgVGh1bWItMiBKYXplbGxlDQooWEVOKSAgICAg
RXh0ZW5zaW9uczogR2VuZXJpY1RpbWVyDQooWEVOKSAgIERlYnVnIEZlYXR1cmVzOiAwNDAxMDA4
OA0KKFhFTikgICBBdXhpbGlhcnkgRmVhdHVyZXM6IDAwMDAwMDAwDQooWEVOKSAgIE1lbW9yeSBN
b2RlbCBGZWF0dXJlczogMTAyMDExMDUgNDAwMDAwMDAgMDEyNjAwMDAgMDIxMjIyMTENCihYRU4p
ICBJU0EgRmVhdHVyZXM6IDAyMTAxMTEwIDEzMTEyMTExIDIxMjMyMDQyIDAxMTEyMTMxIDAwMDEw
MTQyIDAxMDExMTIxDQooWEVOKSBVc2luZyBTTUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjINCihY
RU4pIFVzaW5nIFBTQ0kgdjEuMQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDEwMDBdIGFk
ZHJlc3NbMHgwXSBNUElEUlsweDEwMDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFj
cGlfaWRbMHgxODAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxODAwMDBdIGVuYWJsZWQpDQooWEVO
KSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTYwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTYwMDAw
XSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDFlMDBdIGFkZHJlc3NbMHgw
XSBNUElEUlsweDFlMDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgw
ODAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHg4MDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJ
Q0MgKGFjcGlfaWRbMHgyMDAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgyMDAwMDBdIGVuYWJsZWQp
DQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MGUwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4
ZTAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MjYwMF0gYWRkcmVz
c1sweDBdIE1QSURSWzB4MjYwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9p
ZFsweDExMDBdIGFkZHJlc3NbMHgwXSBNUElEUlsweDExMDAwMF0gZW5hYmxlZCkNCihYRU4pIEFD
UEk6IEdJQ0MgKGFjcGlfaWRbMHgxOTAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgxOTAwMDBdIGVu
YWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTcwMF0gYWRkcmVzc1sweDBdIE1Q
SURSWzB4MTcwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDFmMDBd
IGFkZHJlc3NbMHgwXSBNUElEUlsweDFmMDAwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0Mg
KGFjcGlfaWRbMHgwOTAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHg5MDAwMF0gZW5hYmxlZCkNCihY
RU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgyMTAwXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHgyMTAw
MDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MGYwMF0gYWRkcmVzc1sw
eDBdIE1QSURSWzB4ZjAwMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4
MjcwMF0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjcwMDAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTog
R0lDQyAoYWNwaV9pZFsweDEwMDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDEwMDEwMF0gZW5hYmxl
ZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxODAxXSBhZGRyZXNzWzB4MF0gTVBJRFJb
MHgxODAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MTYwMV0gYWRk
cmVzc1sweDBdIE1QSURSWzB4MTYwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQSTogR0lDQyAoYWNw
aV9pZFsweDFlMDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDFlMDEwMF0gZW5hYmxlZCkNCihYRU4p
IEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgwODAxXSBhZGRyZXNzWzB4MF0gTVBJRFJbMHg4MDEwMF0g
ZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgyMDAxXSBhZGRyZXNzWzB4MF0g
TVBJRFJbMHgyMDAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MGUw
MV0gYWRkcmVzc1sweDBdIE1QSURSWzB4ZTAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUND
IChhY3BpX2lkWzB4MjYwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjYwMTAwXSBlbmFibGVkKQ0K
KFhFTikgQUNQSTogR0lDQyAoYWNwaV9pZFsweDExMDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDEx
MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgxOTAxXSBhZGRyZXNz
WzB4MF0gTVBJRFJbMHgxOTAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChhY3BpX2lk
WzB4MTcwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MTcwMTAwXSBlbmFibGVkKQ0KKFhFTikgQUNQ
STogR0lDQyAoYWNwaV9pZFsweDFmMDFdIGFkZHJlc3NbMHgwXSBNUElEUlsweDFmMDEwMF0gZW5h
YmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgwOTAxXSBhZGRyZXNzWzB4MF0gTVBJ
RFJbMHg5MDEwMF0gZW5hYmxlZCkNCihYRU4pIEFDUEk6IEdJQ0MgKGFjcGlfaWRbMHgyMTAxXSBh
ZGRyZXNzWzB4MF0gTVBJRFJbMHgyMTAxMDBdIGVuYWJsZWQpDQooWEVOKSBBQ1BJOiBHSUNDIChh
Y3BpX2lkWzB4MGYwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4ZjAxMDBdIGVuYWJsZWQpDQooWEVO
KSBBQ1BJOiBHSUNDIChhY3BpX2lkWzB4MjcwMV0gYWRkcmVzc1sweDBdIE1QSURSWzB4MjcwMTAw
XSBlbmFibGVkKQ0KKFhFTikgMzIgQ1BVcyBlbmFibGVkLCAzMiBDUFVzIHRvdGFsDQooWEVOKSBT
TVA6IEFsbG93aW5nIDMyIENQVXMNCihYRU4pIEdlbmVyaWMgVGltZXIgSVJROiBwaHlzPTMwIGh5
cD0yNiB2aXJ0PTI3IEZyZXE6IDI1MDAwIEtIeg0KKFhFTikgR0lDdjMgaW5pdGlhbGl6YXRpb246
DQooWEVOKSAgICAgICBnaWNfZGlzdF9hZGRyPTB4MDAxMDAxMDAwMDAwMDANCihYRU4pICAgICAg
IGdpY19tYWludGVuYW5jZV9pcnE9MjUNCihYRU4pICAgICAgIGdpY19yZGlzdF9zdHJpZGU9MA0K
KFhFTikgICAgICAgZ2ljX3JkaXN0X3JlZ2lvbnM9MQ0KKFhFTikgICAgICAgcmVkaXN0cmlidXRv
ciByZWdpb25zOg0KKFhFTikgICAgICAgICAtIHJlZ2lvbiAwOiAweDAwMTAwMTAwMTQwMDAwIC0g
MHgwMDEwMDEwMTE0MDAwMA0KKFhFTikgR0lDdjM6IHVzaW5nIGF0IG1vc3QgNTczNDQgTFBJcyBv
biB0aGUgaG9zdC4NCihYRU4pIEdJQ3YzOiA3MDQgbGluZXMsIChJSUQgMDIwMTc0M2IpLg0KKFhF
TikgR0lDdjM6IEZvdW5kIElUUyBAMHgxMDAxMDAwNDAwMDANCihYRU4pIEdJQ3YzOiBGb3VuZCBJ
VFMgQDB4MTAwMTAwMDYwMDAwDQooWEVOKSBHSUN2MzogRm91bmQgSVRTIEAweDEwMDEwMDA4MDAw
MA0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBAMHgxMDAxMDAwYTAwMDANCihYRU4pIEdJQ3YzOiBG
b3VuZCBJVFMgQDB4MTAwMTAwMGMwMDAwDQooWEVOKSBHSUN2MzogRm91bmQgSVRTIEAweDEwMDEw
MDBlMDAwMA0KKFhFTikgR0lDdjM6IEZvdW5kIElUUyBAMHgxMDAxMDAxMDAwMDANCihYRU4pIEdJ
Q3YzOiBGb3VuZCBJVFMgQDB4MTAwMTAwMTIwMDAwDQooWEVOKSBHSUN2MzogQ1BVMDogRm91bmQg
cmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDQzNDAwMA0KKFhFTikgWFNNIEZy
YW1ld29yayB2MS4wLjAgaW5pdGlhbGl6ZWQNCihYRU4pIEluaXRpYWxpc2luZyBYU00gU0lMTyBt
b2RlDQooWEVOKSBVc2luZyBzY2hlZHVsZXI6IFNNUCBDcmVkaXQgU2NoZWR1bGVyIHJldjIgKGNy
ZWRpdDIpDQooWEVOKSBJbml0aWFsaXppbmcgQ3JlZGl0MiBzY2hlZHVsZXINCihYRU4pICBsb2Fk
X3ByZWNpc2lvbl9zaGlmdDogMTgNCihYRU4pICBsb2FkX3dpbmRvd19zaGlmdDogMzANCihYRU4p
ICB1bmRlcmxvYWRfYmFsYW5jZV90b2xlcmFuY2U6IDANCihYRU4pICBvdmVybG9hZF9iYWxhbmNl
X3RvbGVyYW5jZTogLTMNCihYRU4pICBydW5xdWV1ZXMgYXJyYW5nZW1lbnQ6IHNvY2tldA0KKFhF
TikgIGNhcCBlbmZvcmNlbWVudCBncmFudWxhcml0eTogMTBtcw0KKFhFTikgbG9hZCB0cmFja2lu
ZyB3aW5kb3cgbGVuZ3RoIDEwNzM3NDE4MjQgbnMNCihYRU4pIERlZmF1bHRpbmcgdG8gYWx0ZXJu
YXRpdmUga2V5IGhhbmRsaW5nOyBzZW5kICdBJyB0byBzd2l0Y2ggdG8gbm9ybWFsIG1vZGUuDQoo
WEVOKSBBbGxvY2F0ZWQgY29uc29sZSByaW5nIG9mIDI1NiBLaUIuDQooWEVOKSBDUFUwOiBHdWVz
dCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihY
RU4pIEJyaW5naW5nIHVwIENQVTENCihYRU4pIEdJQ3YzOiBDUFUxOiBGb3VuZCByZWRpc3RyaWJ1
dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjM0MDAwDQooWEVOKSBDUFUxOiBHdWVzdCBhdG9t
aWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQ
VSAxIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTINCihYRU4pIEdJQ3YzOiBDUFUyOiBG
b3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNWI0MDAwDQooWEVOKSBD
UFUyOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBk
b21haW4NCihYRU4pIENQVSAyIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTMNCihYRU4p
IEdJQ3YzOiBDUFUzOiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQw
N2I0MDAwDQooWEVOKSBDUFUzOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9y
ZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAzIGJvb3RlZC4NCihYRU4pIEJyaW5naW5n
IHVwIENQVTQNCihYRU4pIEdJQ3YzOiBDUFU0OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lv
biAwIEAwMDAwMDAwMDQwMjM0MDAwDQooWEVOKSBDUFU0OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5
IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA0IGJvb3RlZC4N
CihYRU4pIEJyaW5naW5nIHVwIENQVTUNCihYRU4pIEdJQ3YzOiBDUFU1OiBGb3VuZCByZWRpc3Ry
aWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwODM0MDAwDQooWEVOKSBDUFU1OiBHdWVzdCBh
dG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4p
IENQVSA1IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTYNCihYRU4pIEdJQ3YzOiBDUFU2
OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwM2I0MDAwDQooWEVO
KSBDUFU2OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRo
ZSBkb21haW4NCihYRU4pIENQVSA2IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTcNCihY
RU4pIEdJQ3YzOiBDUFU3OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAw
MDQwOWI0MDAwDQooWEVOKSBDUFU3OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJl
Zm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA3IGJvb3RlZC4NCihYRU4pIEJyaW5n
aW5nIHVwIENQVTgNCihYRU4pIEdJQ3YzOiBDUFU4OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJl
Z2lvbiAwIEAwMDAwMDAwMDQwNDc0MDAwDQooWEVOKSBDUFU4OiBHdWVzdCBhdG9taWNzIHdpbGwg
dHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIENQVSA4IGJvb3Rl
ZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTkNCihYRU4pIEdJQ3YzOiBDUFU5OiBGb3VuZCByZWRp
c3RyaWJ1dG9yIGluIHJlZ2lvbiAwIEAwMDAwMDAwMDQwNjc0MDAwDQooWEVOKSBDUFU5OiBHdWVz
dCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihY
RU4pIENQVSA5IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTEwDQooWEVOKSBHSUN2Mzog
Q1BVMTA6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA1ZjQwMDAN
CihYRU4pIENQVTEwOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxMCBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBD
UFUxMQ0KKFhFTikgR0lDdjM6IENQVTExOiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAw
IEAwMDAwMDAwMDQwN2Y0MDAwDQooWEVOKSBDUFUxMTogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx
NyB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMTEgYm9vdGVkLg0K
KFhFTikgQnJpbmdpbmcgdXAgQ1BVMTINCihYRU4pIEdJQ3YzOiBDUFUxMjogRm91bmQgcmVkaXN0
cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDI3NDAwMA0KKFhFTikgQ1BVMTI6IEd1ZXN0
IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhF
TikgQ1BVIDEyIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTEzDQooWEVOKSBHSUN2Mzog
Q1BVMTM6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA4NzQwMDAN
CihYRU4pIENQVTEzOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE3IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxMyBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBD
UFUxNA0KKFhFTikgR0lDdjM6IENQVTE0OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAw
IEAwMDAwMDAwMDQwM2Y0MDAwDQooWEVOKSBDUFUxNDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx
OCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMTQgYm9vdGVkLg0K
KFhFTikgQnJpbmdpbmcgdXAgQ1BVMTUNCihYRU4pIEdJQ3YzOiBDUFUxNTogRm91bmQgcmVkaXN0
cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDlmNDAwMA0KKFhFTikgQ1BVMTU6IEd1ZXN0
IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhF
TikgQ1BVIDE1IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTE2DQooWEVOKSBHSUN2Mzog
Q1BVMTY6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA0NTQwMDAN
CihYRU4pIENQVTE2OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE3IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxNiBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBD
UFUxNw0KKFhFTikgR0lDdjM6IENQVTE3OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAw
IEAwMDAwMDAwMDQwNjU0MDAwDQooWEVOKSBDUFUxNzogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx
OCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMTcgYm9vdGVkLg0K
KFhFTikgQnJpbmdpbmcgdXAgQ1BVMTgNCihYRU4pIEdJQ3YzOiBDUFUxODogRm91bmQgcmVkaXN0
cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDVkNDAwMA0KKFhFTikgQ1BVMTg6IEd1ZXN0
IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhF
TikgQ1BVIDE4IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTE5DQooWEVOKSBHSUN2Mzog
Q1BVMTk6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA3ZDQwMDAN
CihYRU4pIENQVTE5OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAxOSBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBD
UFUyMA0KKFhFTikgR0lDdjM6IENQVTIwOiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAw
IEAwMDAwMDAwMDQwMjU0MDAwDQooWEVOKSBDUFUyMDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx
OCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMjAgYm9vdGVkLg0K
KFhFTikgQnJpbmdpbmcgdXAgQ1BVMjENCihYRU4pIEdJQ3YzOiBDUFUyMTogRm91bmQgcmVkaXN0
cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDg1NDAwMA0KKFhFTikgQ1BVMjE6IEd1ZXN0
IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhF
TikgQ1BVIDIxIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTIyDQooWEVOKSBHSUN2Mzog
Q1BVMjI6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDAzZDQwMDAN
CihYRU4pIENQVTIyOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyMiBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBD
UFUyMw0KKFhFTikgR0lDdjM6IENQVTIzOiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAw
IEAwMDAwMDAwMDQwOWQ0MDAwDQooWEVOKSBDUFUyMzogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx
OCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMjMgYm9vdGVkLg0K
KFhFTikgQnJpbmdpbmcgdXAgQ1BVMjQNCihYRU4pIEdJQ3YzOiBDUFUyNDogRm91bmQgcmVkaXN0
cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDQ5NDAwMA0KKFhFTikgQ1BVMjQ6IEd1ZXN0
IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhF
TikgQ1BVIDI0IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTI1DQooWEVOKSBHSUN2Mzog
Q1BVMjU6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDA2OTQwMDAN
CihYRU4pIENQVTI1OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyNSBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBD
UFUyNg0KKFhFTikgR0lDdjM6IENQVTI2OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAw
IEAwMDAwMDAwMDQwNjE0MDAwDQooWEVOKSBDUFUyNjogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx
OCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMjYgYm9vdGVkLg0K
KFhFTikgQnJpbmdpbmcgdXAgQ1BVMjcNCihYRU4pIEdJQ3YzOiBDUFUyNzogRm91bmQgcmVkaXN0
cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDgxNDAwMA0KKFhFTikgQ1BVMjc6IEd1ZXN0
IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhF
TikgQ1BVIDI3IGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTI4DQooWEVOKSBHSUN2Mzog
Q1BVMjg6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDAyOTQwMDAN
CihYRU4pIENQVTI4OiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIENQVSAyOCBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBD
UFUyOQ0KKFhFTikgR0lDdjM6IENQVTI5OiBGb3VuZCByZWRpc3RyaWJ1dG9yIGluIHJlZ2lvbiAw
IEAwMDAwMDAwMDQwODk0MDAwDQooWEVOKSBDUFUyOTogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx
OCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMjkgYm9vdGVkLg0K
KFhFTikgQnJpbmdpbmcgdXAgQ1BVMzANCihYRU4pIEdJQ3YzOiBDUFUzMDogRm91bmQgcmVkaXN0
cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDQxNDAwMA0KKFhFTikgQ1BVMzA6IEd1ZXN0
IGF0b21pY3Mgd2lsbCB0cnkgMTggdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbg0KKFhF
TikgQ1BVIDMwIGJvb3RlZC4NCihYRU4pIEJyaW5naW5nIHVwIENQVTMxDQooWEVOKSBHSUN2Mzog
Q1BVMzE6IEZvdW5kIHJlZGlzdHJpYnV0b3IgaW4gcmVnaW9uIDAgQDAwMDAwMDAwNDBhMTQwMDAN
CihYRU4pIENQVTMxOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDE4IHRpbWVzIGJlZm9yZSBwYXVz
aW5nIHRoZSBkb21haW4NCihYRU4pIEJyb3VnaHQgdXAgMzIgQ1BVcw0KKFhFTikgQ1BVIDMxIGJv
b3RlZC4NCihYRU4pIEkvTyB2aXJ0dWFsaXNhdGlvbiBkaXNhYmxlZA0KKFhFTikgUDJNOiA0OC1i
aXQgSVBBIHdpdGggNDgtYml0IFBBIGFuZCAxNi1iaXQgVk1JRA0KKFhFTikgUDJNOiA0IGxldmVs
cyB3aXRoIG9yZGVyLTAgcm9vdCwgVlRDUiAweDgwMGQzNTkwDQooWEVOKSBTY2hlZHVsaW5nIGdy
YW51bGFyaXR5OiBjcHUsIDEgQ1BVIHBlciBzY2hlZC1yZXNvdXJjZQ0KKFhFTikgQWRkaW5nIGNw
dSAwIHRvIHJ1bnF1ZXVlIDANCihYRU4pICBGaXJzdCBjcHUgb24gcnVucXVldWUsIGFjdGl2YXRp
bmcNCihYRU4pIEFkZGluZyBjcHUgMSB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDIg
dG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSAzIHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFk
ZGluZyBjcHUgNCB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDUgdG8gcnVucXVldWUg
MA0KKFhFTikgQWRkaW5nIGNwdSA2IHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgNyB0
byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDggdG8gcnVucXVldWUgMA0KKFhFTikgQWRk
aW5nIGNwdSA5IHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMTAgdG8gcnVucXVldWUg
MA0KKFhFTikgQWRkaW5nIGNwdSAxMSB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDEy
IHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMTMgdG8gcnVucXVldWUgMA0KKFhFTikg
QWRkaW5nIGNwdSAxNCB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDE1IHRvIHJ1bnF1
ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgMTYgdG8gcnVucXVldWUgMQ0KKFhFTikgIEZpcnN0IGNw
dSBvbiBydW5xdWV1ZSwgYWN0aXZhdGluZw0KKFhFTikgQWRkaW5nIGNwdSAxNyB0byBydW5xdWV1
ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDE4IHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUg
MTkgdG8gcnVucXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyMCB0byBydW5xdWV1ZSAxDQooWEVO
KSBBZGRpbmcgY3B1IDIxIHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjIgdG8gcnVu
cXVldWUgMQ0KKFhFTikgQWRkaW5nIGNwdSAyMyB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcg
Y3B1IDI0IHRvIHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjUgdG8gcnVucXVldWUgMQ0K
KFhFTikgQWRkaW5nIGNwdSAyNiB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDI3IHRv
IHJ1bnF1ZXVlIDENCihYRU4pIEFkZGluZyBjcHUgMjggdG8gcnVucXVldWUgMQ0KKFhFTikgQWRk
aW5nIGNwdSAyOSB0byBydW5xdWV1ZSAxDQooWEVOKSBBZGRpbmcgY3B1IDMwIHRvIHJ1bnF1ZXVl
IDENCihYRU4pIEFkZGluZyBjcHUgMzEgdG8gcnVucXVldWUgMQ0KKFhFTikgYWx0ZXJuYXRpdmVz
OiBQYXRjaGluZyB3aXRoIGFsdCB0YWJsZSAwMDAwMDAwMDAwMmNkMGIwIC0+IDAwMDAwMDAwMDAy
Y2Q5ZTANCihYRU4pICoqKiBMT0FESU5HIERPTUFJTiAwICoqKg0KKFhFTikgTG9hZGluZyBkMCBr
ZXJuZWwgZnJvbSBib290IG1vZHVsZSBAIDAwMDAwMDAwZmU0N2MwMDANCihYRU4pIEFsbG9jYXRp
bmcgMToxIG1hcHBpbmdzIHRvdGFsbGluZyA4MTkyTUIgZm9yIGRvbTA6DQooWEVOKSBCQU5LWzBd
IDB4MDAwMDAwOTgwMDAwMDAtMHgwMDAwMDBmODAwMDAwMCAoMTUzNk1CKQ0KKFhFTikgQkFOS1sx
XSAweDAwMDgwMDAwMDAwMDAwLTB4MDAwODAwODAwMDAwMDAgKDIwNDhNQikNCihYRU4pIEJBTktb
Ml0gMHgwMDA4MDY4MDAwMDAwMC0weDAwMDgwN2EwMDAwMDAwICg0NjA4TUIpDQooWEVOKSBHcmFu
dCB0YWJsZSByYW5nZTogMHgwMDA4MDdmNjgyYzAwMC0weDAwMDgwN2Y2ODZjMDAwDQooWEVOKSBB
bGxvY2F0aW5nIFBQSSAxNiBmb3IgZXZlbnQgY2hhbm5lbCBpbnRlcnJ1cHQNCihYRU4pIExvYWRp
bmcgekltYWdlIGZyb20gMDAwMDAwMDBmZTQ3YzAwMCB0byAwMDAwMDAwMDk4MDAwMDAwLTAwMDAw
MDAwOTk2YzMyMDANCihYRU4pIExvYWRpbmcgZDAgRFRCIHRvIDB4MDAwMDAwMDBhMDAwMDAwMC0w
eDAwMDAwMDAwYTAwMDAyN2YNCihYRU4pIEluaXRpYWwgbG93IG1lbW9yeSB2aXJxIHRocmVzaG9s
ZCBzZXQgYXQgMHg0MDAwIHBhZ2VzLg0KKFhFTikgU3RkLiBMb2dsZXZlbDogQWxsDQooWEVOKSBH
dWVzdCBMb2dsZXZlbDogRXJyb3JzDQooWEVOKSAqKiogU2VyaWFsIGlucHV0IHRvIERPTTAgKHR5
cGUgJ0NUUkwtYScgdGhyZWUgdGltZXMgdG8gc3dpdGNoIGlucHV0KQ0KKFhFTikgRnJlZWQgMzYw
a0IgaW5pdCBtZW1vcnkuDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUg
MHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5k
bGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI4DQooWEVOKSBkMHYw
OiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElW
RVIxMg0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZm
ZmZmZmYgdG8gSUNBQ1RJVkVSMTYNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3
cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjIwDQooWEVOKSBkMHYwOiB2R0lDRDog
dW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIyNA0KKFhF
TikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8g
SUNBQ1RJVkVSMjgNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAw
MDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjMyDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVk
IHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIzNg0KKFhFTikgZDB2MDog
dkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVS
NDANCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZm
ZmZmIHRvIElDQUNUSVZFUjQ0DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3Jp
dGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0OA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVu
aGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNTINCihYRU4p
IGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElD
QUNUSVZFUjU2DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAw
MDBmZmZmZmZmZiB0byBJQ0FDVElWRVI2MA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3
b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNjQNCihYRU4pIGQwdjA6IHZH
SUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjY4
DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZm
ZiB0byBJQ0FDVElWRVI3Mg0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRl
IDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNzYNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhh
bmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjgwDQooWEVOKSBk
MHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FD
VElWRVI4NA0KKFhFTikgZDB2MDogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgw
MDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwDQpbICAgIDAuMDAwMDAwXSBCb290aW5nIExpbnV4
IG9uIHBoeXNpY2FsIENQVSAweDAwMDAwMDAwMDAgWzB4NDEzZmQwYzFdDQpbICAgIDAuMDAwMDAw
XSBMaW51eCB2ZXJzaW9uIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgKG9lLXVzZXJAb2Ut
aG9zdCkgKGFhcmNoNjQtcG9reS1saW51eC1nY2MgKEdDQykgMTEuMi4wLCBHTlUgbGQgKEdOVSBC
aW51dGlscykgMi4zNy4yMDIxMDcyMSkgIzEgU01QIFBSRUVNUFQgU2F0IFNlcCAxOCAwNjowMTo1
OSBVVEMgMjAyMQ0KWyAgICAwLjAwMDAwMF0gWGVuIFhFTl9WRVJTSU9OLlhFTl9TVUJWRVJTSU9O
IHN1cHBvcnQgZm91bmQNClsgICAgMC4wMDAwMDBdIGVmaTogRUZJIHYyLjUwIGJ5IFhlbg0KWyAg
ICAwLjAwMDAwMF0gZWZpOiBBQ1BJIDIuMD0weDgwN2Y2ODJjY2U4IA0KWyAgICAwLjAwMDAwMF0g
QUNQSTogRWFybHkgdGFibGUgY2hlY2tzdW0gdmVyaWZpY2F0aW9uIGRpc2FibGVkDQpbICAgIDAu
MDAwMDAwXSBBQ1BJOiBSU0RQIDB4MDAwMDA4MDdGNjgyQ0NFOCAwMDAwMjQgKHYwMiBBbXBlcmUp
DQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBYU0RUIDB4MDAwMDA4MDdGNjgyQ0MzOCAwMDAwQUMgKHYw
MSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBd
IEFDUEk6IEZBQ1AgMHgwMDAwMDgwN0Y2ODJDMDAwIDAwMDExNCAodjA2IEFtcGVyZSBBbHRyYSAg
ICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogRFNEVCAweDAw
MDAwODA3RjhEQjAwMTggMDJDMTlFICh2MDIgQW1wZXJlIEphZGUgICAgIDAwMDAwMDAxIElOVEwg
MjAyMDEyMTcpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBCRVJUIDB4MDAwMDA4MDdGQTBERkY5OCAw
MDAwMzAgKHYwMSBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAg
MC4wMDAwMDBdIEFDUEk6IERCRzIgMHgwMDAwMDgwN0ZBMERGQTk4IDAwMDA1QyAodjAwIEFtcGVy
ZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTog
R1REVCAweDAwMDAwODA3RkEwREU5OTggMDAwMTEwICh2MDMgQW1wZXJlIEFsdHJhICAgIDAwMDAw
MDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTUENSIDB4MDAwMDA4MDdG
QTBERkUxOCAwMDAwNTAgKHYwMiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAx
MykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEVJTkogMHgwMDAwMDgwN0ZBMERGNTk4IDAwMDE1MCAo
djAxIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMSBJTlRMIDIwMjAxMjE3KQ0KWyAgICAwLjAwMDAw
MF0gQUNQSTogSEVTVCAweDAwMDAwODA3RkEwREVCMTggMDAwMUY0ICh2MDEgQW1wZXJlIEFsdHJh
ICAgIDAwMDAwMDAxIElOVEwgMjAyMDEyMTcpDQpbICAgIDAuMDAwMDAwXSBBQ1BJOiBTU0RUIDB4
MDAwMDA4MDdGQTBERkExOCAwMDAwMkQgKHYwMiBBbXBlcmUgQWx0cmEgICAgMDAwMDAwMDEgSU5U
TCAyMDIwMTIxNykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFRQTTIgMHgwMDAwMDgwN0ZBMERGRDE4
IDAwMDA0QyAodjA0IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAwMDEzKQ0KWyAg
ICAwLjAwMDAwMF0gQUNQSTogTUNGRyAweDAwMDAwODA3RkEwREY3MTggMDAwMDdDICh2MDEgQW1w
ZXJlIEFsdHJhICAgIDAwMDAwMDAxIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAwMDAwXSBBQ1BJ
OiBJT1JUIDB4MDAwMDA4MDdGQTBERUYxOCAwMDAzREMgKHYwMCBBbXBlcmUgQWx0cmEgICAgMDAw
MDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IEFQSUMgMHgwMDAwMDgw
N0Y2ODJDMTE4IDAwMEFGNCAodjA1IEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBBTVAuIDAxMDAw
MDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogUFBUVCAweDAwMDAwODA3RkEwRDg2MTggMDA0NTIw
ICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpbICAgIDAuMDAw
MDAwXSBBQ1BJOiBTTElUIDB4MDAwMDA4MDdGQTBERkQ5OCAwMDAwMkQgKHYwMSBBbXBlcmUgQWx0
cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQg
MHgwMDAwMDgwN0ZBMERDRTE4IDAwMDM3MCAodjAzIEFtcGVyZSBBbHRyYSAgICAwMDAwMDAwMiBB
TVAuIDAxMDAwMDEzKQ0KWyAgICAwLjAwMDAwMF0gQUNQSTogUENDVCAweDAwMDAwODA3RkEwREUz
MTggMDAwNTc2ICh2MDIgQW1wZXJlIEFsdHJhICAgIDAwMDAwMDAyIEFNUC4gMDEwMDAwMTMpDQpb
ICAgIDAuMDAwMDAwXSBBQ1BJOiBTVEFPIDB4MDAwMDA4MDdGNjgyQ0MxMCAwMDAwMjUgKHYwMSBB
bXBlcmUgQWx0cmEgICAgMDAwMDAwMDIgQU1QLiAwMTAwMDAxMykNClsgICAgMC4wMDAwMDBdIEFD
UEk6IFNQQ1I6IGNvbnNvbGU6IHBsMDExLG1taW8zMiwweDEwMDAwMjYwMDAwMCwxMTUyMDANClsg
ICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODgzMDAwMDAtMHg4
ODNmZmZmZl0NClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4
OTAwMDAwMDAtMHhmZmZmZmZmZl0NClsgICAgMC4wMDAwMDBdIEFDUEk6IFNSQVQ6IE5vZGUgMCBQ
WE0gMCBbbWVtIDB4ODAwMDAwMDAwMDAtMHg4MDA3ZmZmZmZmZl0NClsgICAgMC4wMDAwMDBdIEFD
UEk6IFNSQVQ6IE5vZGUgMCBQWE0gMCBbbWVtIDB4ODAxMDAwMDAwMDAtMHg4MDdmZmZmZmZmZl0N
ClsgICAgMC4wMDAwMDBdIE5VTUE6IE5PREVfREFUQSBbbWVtIDB4ODA3OWVmZWVlMDAtMHg4MDc5
ZWZmMGZmZl0NClsgICAgMC4wMDAwMDBdIFpvbmUgcmFuZ2VzOg0KWyAgICAwLjAwMDAwMF0gICBE
TUEgICAgICBbbWVtIDB4MDAwMDAwMDA5ODAwMDAwMC0weDAwMDAwMDAwZmZmZmZmZmZdDQpbICAg
IDAuMDAwMDAwXSAgIERNQTMyICAgIGVtcHR5DQpbICAgIDAuMDAwMDAwXSAgIE5vcm1hbCAgIFtt
ZW0gMHgwMDAwMDAwMTAwMDAwMDAwLTB4MDAwMDA4MDdmYTBkZmZmZl0NClsgICAgMC4wMDAwMDBd
IE1vdmFibGUgem9uZSBzdGFydCBmb3IgZWFjaCBub2RlDQpbICAgIDAuMDAwMDAwXSBFYXJseSBt
ZW1vcnkgbm9kZSByYW5nZXMNClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAw
MDAwMDk4MDAwMDAwLTB4MDAwMDAwMDBmN2ZmZmZmZl0NClsgICAgMC4wMDAwMDBdICAgbm9kZSAg
IDA6IFttZW0gMHgwMDAwMDgwMDAwMDAwMDAwLTB4MDAwMDA4MDA3ZmZmZmZmZl0NClsgICAgMC4w
MDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwNjgwMDAwMDAwLTB4MDAwMDA4MDc5ZmZm
ZmZmZl0NClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDgwN2Y2ODJjMDAw
LTB4MDAwMDA4MDdmNjgyY2ZmZl0NClsgICAgMC4wMDAwMDBdICAgbm9kZSAgIDA6IFttZW0gMHgw
MDAwMDgwN2Y4ZGIwMDAwLTB4MDAwMDA4MDdmOGRkZmZmZl0NClsgICAgMC4wMDAwMDBdICAgbm9k
ZSAgIDA6IFttZW0gMHgwMDAwMDgwN2ZhMGQwMDAwLTB4MDAwMDA4MDdmYTBkZmZmZl0NClsgICAg
MC4wMDAwMDBdIEluaXRtZW0gc2V0dXAgbm9kZSAwIFttZW0gMHgwMDAwMDAwMDk4MDAwMDAwLTB4
MDAwMDA4MDdmYTBkZmZmZl0NClsgICAgMC4wMDAwMDBdIHBzY2k6IHByb2JpbmcgZm9yIGNvbmR1
aXQgbWV0aG9kIGZyb20gQUNQSS4NClsgICAgMC4wMDAwMDBdIHBzY2k6IFBTQ0l2MS4xIGRldGVj
dGVkIGluIGZpcm13YXJlLg0KWyAgICAwLjAwMDAwMF0gcHNjaTogVXNpbmcgc3RhbmRhcmQgUFND
SSB2MC4yIGZ1bmN0aW9uIElEcw0KWyAgICAwLjAwMDAwMF0gcHNjaTogVHJ1c3RlZCBPUyBtaWdy
YXRpb24gbm90IHJlcXVpcmVkDQpbICAgIDAuMDAwMDAwXSBwc2NpOiBTTUMgQ2FsbGluZyBDb252
ZW50aW9uIHYxLjENClsgICAgMC4wMDAwMDBdIHBlcmNwdTogRW1iZWRkZWQgMzEgcGFnZXMvY3B1
IHM4OTI0MCByODE5MiBkMjk1NDQgdTEyNjk3Ng0KWyAgICAwLjAwMDAwMF0gRGV0ZWN0ZWQgUElQ
VCBJLWNhY2hlIG9uIENQVTANClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6
IEdJQyBzeXN0ZW0gcmVnaXN0ZXIgQ1BVIGludGVyZmFjZQ0KWyAgICAwLjAwMDAwMF0gQ1BVIGZl
YXR1cmVzOiBkZXRlY3RlZDogSGFyZHdhcmUgZGlydHkgYml0IG1hbmFnZW1lbnQNClsgICAgMC4w
MDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFNwZWN0cmUtdjQNClsgICAgMC4wMDAwMDBd
IENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMC4wMDAw
MDBdIEJ1aWx0IDEgem9uZWxpc3RzLCBtb2JpbGl0eSBncm91cGluZyBvbi4gIFRvdGFsIHBhZ2Vz
OiAyMDY0NDQ3DQpbICAgIDAuMDAwMDAwXSBQb2xpY3kgem9uZTogTm9ybWFsDQpbICAgIDAuMDAw
MDAwXSBLZXJuZWwgY29tbWFuZCBsaW5lOiBjb25zb2xlPWh2YzAgZWFybHljb249eGVuIHJvb3R3
YWl0IHJvb3Q9UEFSVFVVSUQ9NmE2MDUyNGQtMDYxZC00NTRhLWJmZDEtMzg5ODk5MTBlY2NkDQpb
ICAgIDAuMDAwMDAwXSBwcmludGs6IGxvZ19idWZfbGVuIGluZGl2aWR1YWwgbWF4IGNwdSBjb250
cmlidXRpb246IDQwOTYgYnl0ZXMNClsgICAgMC4wMDAwMDBdIHByaW50azogbG9nX2J1Zl9sZW4g
dG90YWwgY3B1X2V4dHJhIGNvbnRyaWJ1dGlvbnM6IDEyNjk3NiBieXRlcw0KWyAgICAwLjAwMDAw
MF0gcHJpbnRrOiBsb2dfYnVmX2xlbiBtaW4gc2l6ZTogMTMxMDcyIGJ5dGVzDQpbICAgIDAuMDAw
MDAwXSBwcmludGs6IGxvZ19idWZfbGVuOiAyNjIxNDQgYnl0ZXMNClsgICAgMC4wMDAwMDBdIHBy
aW50azogZWFybHkgbG9nIGJ1ZiBmcmVlOiAxMjU5MzYoOTYlKQ0KWyAgICAwLjAwMDAwMF0gRGVu
dHJ5IGNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMTA0ODU3NiAob3JkZXI6IDExLCA4Mzg4NjA4
IGJ5dGVzLCBsaW5lYXIpDQpbICAgIDAuMDAwMDAwXSBJbm9kZS1jYWNoZSBoYXNoIHRhYmxlIGVu
dHJpZXM6IDUyNDI4OCAob3JkZXI6IDEwLCA0MTk0MzA0IGJ5dGVzLCBsaW5lYXIpDQpbICAgIDAu
MDAwMDAwXSBtZW0gYXV0by1pbml0OiBzdGFjazpvZmYsIGhlYXAgYWxsb2M6b2ZmLCBoZWFwIGZy
ZWU6b2ZmDQpbICAgIDAuMDAwMDAwXSBzb2Z0d2FyZSBJTyBUTEI6IG1hcHBlZCBbbWVtIDB4MDAw
MDAwMDBmNDAwMDAwMC0weDAwMDAwMDAwZjgwMDAwMDBdICg2NE1CKQ0KWyAgICAwLjAwMDAwMF0g
TWVtb3J5OiA4MTAwNzY0Sy84Mzg4ODY4SyBhdmFpbGFibGUgKDEzNTY4SyBrZXJuZWwgY29kZSwg
MTk5NksgcndkYXRhLCAzNDc2SyByb2RhdGEsIDQxNjBLIGluaXQsIDgyMksgYnNzLCAyODgxMDRL
IHJlc2VydmVkLCAwSyBjbWEtcmVzZXJ2ZWQpDQpbICAgIDAuMDAwMDAwXSBTTFVCOiBIV2FsaWdu
PTY0LCBPcmRlcj0wLTMsIE1pbk9iamVjdHM9MCwgQ1BVcz0zMiwgTm9kZXM9MQ0KWyAgICAwLjAw
MDAwMF0gZnRyYWNlOiBhbGxvY2F0aW5nIDQxMzA2IGVudHJpZXMgaW4gMTYyIHBhZ2VzDQpbICAg
IDAuMDAwMDAwXSBmdHJhY2U6IGFsbG9jYXRlZCAxNjIgcGFnZXMgd2l0aCAzIGdyb3Vwcw0KWyAg
ICAwLjAwMDAwMF0gcmN1OiBQcmVlbXB0aWJsZSBoaWVyYXJjaGljYWwgUkNVIGltcGxlbWVudGF0
aW9uLg0KWyAgICAwLjAwMDAwMF0gcmN1OiAJUkNVIGV2ZW50IHRyYWNpbmcgaXMgZW5hYmxlZC4N
ClsgICAgMC4wMDAwMDBdIHJjdTogCVJDVSByZXN0cmljdGluZyBDUFVzIGZyb20gTlJfQ1BVUz0y
NTYgdG8gbnJfY3B1X2lkcz0zMi4NClsgICAgMC4wMDAwMDBdIAlUcmFtcG9saW5lIHZhcmlhbnQg
b2YgVGFza3MgUkNVIGVuYWJsZWQuDQpbICAgIDAuMDAwMDAwXSAJUnVkZSB2YXJpYW50IG9mIFRh
c2tzIFJDVSBlbmFibGVkLg0KWyAgICAwLjAwMDAwMF0gCVRyYWNpbmcgdmFyaWFudCBvZiBUYXNr
cyBSQ1UgZW5hYmxlZC4NClsgICAgMC4wMDAwMDBdIHJjdTogUkNVIGNhbGN1bGF0ZWQgdmFsdWUg
b2Ygc2NoZWR1bGVyLWVubGlzdG1lbnQgZGVsYXkgaXMgMjUgamlmZmllcy4NClsgICAgMC4wMDAw
MDBdIHJjdTogQWRqdXN0aW5nIGdlb21ldHJ5IGZvciByY3VfZmFub3V0X2xlYWY9MTYsIG5yX2Nw
dV9pZHM9MzINClsgICAgMC4wMDAwMDBdIE5SX0lSUVM6IDY0LCBucl9pcnFzOiA2NCwgcHJlYWxs
b2NhdGVkIGlycXM6IDANClsgICAgMC4wMDAwMDBdIEdJQ3YzOiA2NzIgU1BJcyBpbXBsZW1lbnRl
ZA0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IDAgRXh0ZW5kZWQgU1BJcyBpbXBsZW1lbnRlZA0KWyAg
ICAwLjAwMDAwMF0gR0lDdjM6IERpc3RyaWJ1dG9yIGhhcyBubyBSYW5nZSBTZWxlY3RvciBzdXBw
b3J0DQpbICAgIDAuMDAwMDAwXSBHSUN2MzogMTYgUFBJcyBpbXBsZW1lbnRlZA0KWyAgICAwLjAw
MDAwMF0gR0lDdjM6IENQVTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMCByZWdpb24gMDoweDAwMDAx
MDAxMDAxNDAwMDANClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyAwIC0+IE5vZGUg
MA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDEgLT4gTm9kZSAwDQpbICAgIDAu
MDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgMiAtPiBOb2RlIDANClsgICAgMC4wMDAwMDBdIFNS
QVQ6IFBYTSAwIC0+IElUUyAzIC0+IE5vZGUgMA0KWyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAg
LT4gSVRTIDQgLT4gTm9kZSAwDQpbICAgIDAuMDAwMDAwXSBTUkFUOiBQWE0gMCAtPiBJVFMgNSAt
PiBOb2RlIDANClsgICAgMC4wMDAwMDBdIFNSQVQ6IFBYTSAwIC0+IElUUyA2IC0+IE5vZGUgMA0K
WyAgICAwLjAwMDAwMF0gU1JBVDogUFhNIDAgLT4gSVRTIDcgLT4gTm9kZSAwDQpbICAgIDAuMDAw
MDAwXSBJVFMgW21lbSAweDEwMDEwMDA0MDAwMC0weDEwMDEwMDA1ZmZmZl0NClsgICAgMC4wMDAw
MDBdIElUU0AweDAwMDAxMDAxMDAwNDAwMDA6IERldmljZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1
Y2UgaWRzIDIwLT4xOQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA0MDAwMDogYWxs
b2NhdGVkIDUyNDI4OCBEZXZpY2VzIEA4MDAwMDgwMDAwMCAoZmxhdCwgZXN6IDgsIHBzeiA2NEss
IHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA0MDAwMDogYWxsb2NhdGVk
IDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAyMjAwMDAgKGZsYXQsIGVzeiAyLCBw
c3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMDYwMDAwLTB4
MTAwMTAwMDdmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDA2MDAwMDogRGV2
aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJ
VFNAMHgwMDAwMTAwMTAwMDYwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMgQDgwMDAwYzAw
MDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgw
MDAwMTAwMTAwMDYwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4
MDAwMDI0MDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0g
SVRTIFttZW0gMHgxMDAxMDAwODAwMDAtMHgxMDAxMDAwOWZmZmZdDQpbICAgIDAuMDAwMDAwXSBJ
VFNAMHgwMDAwMTAwMTAwMDgwMDAwOiBEZXZpY2VzIFRhYmxlIHRvbyBsYXJnZSwgcmVkdWNlIGlk
cyAyMC0+MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwODAwMDA6IGFsbG9jYXRl
ZCA1MjQyODggRGV2aWNlcyBAODAwMDEwMDAwMDAgKGZsYXQsIGVzeiA4LCBwc3ogNjRLLCBzaHIg
MSkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwODAwMDA6IGFsbG9jYXRlZCAzMjc2
OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMjYwMDAwIChmbGF0LCBlc3ogMiwgcHN6IDY0
Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAweDEwMDEwMDBhMDAwMC0weDEwMDEw
MDBiZmZmZl0NClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAwYTAwMDA6IERldmljZXMg
VGFibGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRzIDIwLT4xOQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4
MDAwMDEwMDEwMDBhMDAwMDogYWxsb2NhdGVkIDUyNDI4OCBEZXZpY2VzIEA4MDAwMTQwMDAwMCAo
ZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEw
MDEwMDBhMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVwdCBDb2xsZWN0aW9ucyBAODAwMDAy
ODAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUUyBb
bWVtIDB4MTAwMTAwMGMwMDAwLTB4MTAwMTAwMGRmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSVRTQDB4
MDAwMDEwMDEwMDBjMDAwMDogRGV2aWNlcyBUYWJsZSB0b28gbGFyZ2UsIHJlZHVjZSBpZHMgMjAt
PjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGMwMDAwOiBhbGxvY2F0ZWQgNTI0
Mjg4IERldmljZXMgQDgwMDAxODAwMDAwIChmbGF0LCBlc3ogOCwgcHN6IDY0Sywgc2hyIDEpDQpb
ICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGMwMDAwOiBhbGxvY2F0ZWQgMzI3NjggSW50
ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDJhMDAwMCAoZmxhdCwgZXN6IDIsIHBzeiA2NEssIHNo
ciAxKQ0KWyAgICAwLjAwMDAwMF0gSVRTIFttZW0gMHgxMDAxMDAwZTAwMDAtMHgxMDAxMDAwZmZm
ZmZdDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMGUwMDAwOiBEZXZpY2VzIFRhYmxl
IHRvbyBsYXJnZSwgcmVkdWNlIGlkcyAyMC0+MTkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAx
MDAxMDAwZTAwMDA6IGFsbG9jYXRlZCA1MjQyODggRGV2aWNlcyBAODAwMDFjMDAwMDAgKGZsYXQs
IGVzeiA4LCBwc3ogNjRLLCBzaHIgMSkNClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAxMDAxMDAw
ZTAwMDA6IGFsbG9jYXRlZCAzMjc2OCBJbnRlcnJ1cHQgQ29sbGVjdGlvbnMgQDgwMDAwMmMwMDAw
IChmbGF0LCBlc3ogMiwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFMgW21lbSAw
eDEwMDEwMDEwMDAwMC0weDEwMDEwMDExZmZmZl0NClsgICAgMC4wMDAwMDBdIElUU0AweDAwMDAx
MDAxMDAxMDAwMDA6IERldmljZXMgVGFibGUgdG9vIGxhcmdlLCByZWR1Y2UgaWRzIDIwLT4xOQ0K
WyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEwMDAwMDogYWxsb2NhdGVkIDUyNDI4OCBE
ZXZpY2VzIEA4MDAwMjAwMDAwMCAoZmxhdCwgZXN6IDgsIHBzeiA2NEssIHNociAxKQ0KWyAgICAw
LjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEwMDAwMDogYWxsb2NhdGVkIDMyNzY4IEludGVycnVw
dCBDb2xsZWN0aW9ucyBAODAwMDAyZTAwMDAgKGZsYXQsIGVzeiAyLCBwc3ogNjRLLCBzaHIgMSkN
ClsgICAgMC4wMDAwMDBdIElUUyBbbWVtIDB4MTAwMTAwMTIwMDAwLTB4MTAwMTAwMTNmZmZmXQ0K
WyAgICAwLjAwMDAwMF0gSVRTQDB4MDAwMDEwMDEwMDEyMDAwMDogRGV2aWNlcyBUYWJsZSB0b28g
bGFyZ2UsIHJlZHVjZSBpZHMgMjAtPjE5DQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAw
MTIwMDAwOiBhbGxvY2F0ZWQgNTI0Mjg4IERldmljZXMgQDgwMDAyNDAwMDAwIChmbGF0LCBlc3og
OCwgcHN6IDY0Sywgc2hyIDEpDQpbICAgIDAuMDAwMDAwXSBJVFNAMHgwMDAwMTAwMTAwMTIwMDAw
OiBhbGxvY2F0ZWQgMzI3NjggSW50ZXJydXB0IENvbGxlY3Rpb25zIEA4MDAwMDMwMDAwMCAoZmxh
dCwgZXN6IDIsIHBzeiA2NEssIHNociAxKQ0KWyAgICAwLjAwMDAwMF0gLS0tLS0tLS0tLS0tWyBj
dXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDAuMDAwMDAwXSBXQVJOSU5HOiBDUFU6IDAgUElE
OiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjIyNDcgaXRzX2luaXQrMHgz
OTgvMHg2OTANClsgICAgMC4wMDAwMDBdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAwLjAwMDAw
MF0gQ1BVOiAwIFBJRDogMCBDb21tOiBzd2FwcGVyLzAgTm90IHRhaW50ZWQgNS4xMC4yNy1hbXBl
cmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAwLjAwMDAwMF0gcHN0YXRlOiA2MDAwMDA4NSAoblpD
diBkYUlmIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAwLjAwMDAwMF0gcGMgOiBpdHNf
aW5pdCsweDM5OC8weDY5MA0KWyAgICAwLjAwMDAwMF0gbHIgOiBpdHNfaW5pdCsweDM5NC8weDY5
MA0KWyAgICAwLjAwMDAwMF0gc3AgOiBmZmZmODAwMDExNGQzYzUwDQpbICAgIDAuMDAwMDAwXSB4
Mjk6IGZmZmY4MDAwMTE0ZDNjNTAgeDI4OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAwLjAwMDAw
MF0geDI3OiBmZmZmODAwMDExNGRjOWMwIHgyNjogZmZmZjA3ZmY4MDFlNTUwMCANClsgICAgMC4w
MDAwMDBdIHgyNTogMDAwMDAwMDAwMDAwMDAwMCB4MjQ6IGZmZmYwODA3MWVjMWMwYzAgDQpbICAg
IDAuMDAwMDAwXSB4MjM6IGZmZmY4MDAwMTE2MjIzNTAgeDIyOiBmZmZmMDdmZjgwMTFiNjAwIA0K
WyAgICAwLjAwMDAwMF0geDIxOiBmZmZmODAwMDExNGRjOWMwIHgyMDogZmZmZjgwMDAxMTYyMjAw
MCANClsgICAgMC4wMDAwMDBdIHgxOTogZmZmZjgwMDAxMTc2ODlmOCB4MTg6IGZmZmZmZmZmZmZm
ZmZmZmYgDQpbICAgIDAuMDAwMDAwXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAw
MDAwMDAwMDFmIA0KWyAgICAwLjAwMDAwMF0geDE1OiBmZmZmMDdmZjgwMjA0NzFkIHgxNDogMDAw
MDAwMDAwMDAwMDA1OCANClsgICAgMC4wMDAwMDBdIHgxMzogMDAwMDAwMDAwMDAwMDBjMCB4MTI6
IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4MTE6IDAwMDAwMDAwMDAwMDAwMTAg
eDEwOiBmZmZmMDgwNzFlYWUzYWMwIA0KWyAgICAwLjAwMDAwMF0geDkgOiBmZmZmODAwMDEwZDM2
ZGMwIHg4IDogZmZmZjA3ZmY4MDMyMDAwMCANClsgICAgMC4wMDAwMDBdIHg3IDogYTJhMmEyYTJh
MmEyYTJhMiB4NiA6IGZmZmYwMDAwMDAwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4NSA6IGZmZmZm
ZGZmZmZlMDAwMDAgeDQgOiBmZmZmODAwMDExNGRjOWMwIA0KWyAgICAwLjAwMDAwMF0geDMgOiBm
ZmZmODAwMDExNGRkYWYwIHgyIDogMDAwMDAwMDAwMDAwMDAzZCANClsgICAgMC4wMDAwMDBdIHgx
IDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDAuMDAwMDAw
XSBDYWxsIHRyYWNlOg0KWyAgICAwLjAwMDAwMF0gIGl0c19pbml0KzB4Mzk4LzB4NjkwDQpbICAg
IDAuMDAwMDAwXSAgZ2ljX2luaXRfYmFzZXMrMHg1MjQvMHg1ODQNClsgICAgMC4wMDAwMDBdICBn
aWNfYWNwaV9pbml0KzB4MTM0LzB4Mjc4DQpbICAgIDAuMDAwMDAwXSAgYWNwaV9tYXRjaF9tYWR0
KzB4NTAvMHg4OA0KWyAgICAwLjAwMDAwMF0gIGFjcGlfdGFibGVfcGFyc2VfZW50cmllc19hcnJh
eSsweDE2NC8weDI0Yw0KWyAgICAwLjAwMDAwMF0gIGFjcGlfdGFibGVfcGFyc2VfZW50cmllcysw
eDQ4LzB4NzANClsgICAgMC4wMDAwMDBdICBhY3BpX3RhYmxlX3BhcnNlX21hZHQrMHgzNC8weDQw
DQpbICAgIDAuMDAwMDAwXSAgX19hY3BpX3Byb2JlX2RldmljZV90YWJsZSsweDkwLzB4ZWMNClsg
ICAgMC4wMDAwMDBdICBpcnFjaGlwX2luaXQrMHg0MC8weDRjDQpbICAgIDAuMDAwMDAwXSAgaW5p
dF9JUlErMHhkMC8weDEwNA0KWyAgICAwLjAwMDAwMF0gIHN0YXJ0X2tlcm5lbCsweDM1NC8weDU1
NA0KWyAgICAwLjAwMDAwMF0gcmFuZG9tOiBnZXRfcmFuZG9tX2J5dGVzIGNhbGxlZCBmcm9tIF9f
d2FybisweDEyOC8weDFjMCB3aXRoIGNybmdfaW5pdD0wDQpbICAgIDAuMDAwMDAwXSAtLS1bIGVu
ZCB0cmFjZSAwMDAwMDAwMDAwMDAwMDAwIF0tLS0NClsgICAgMC4wMDAwMDBdIEdJQ3YzOiB1c2lu
ZyBMUEkgcHJvcGVydHkgdGFibGUgQDB4MDAwMDA4MDAwMDMxMDAwMA0KWyAgICAwLjAwMDAwMF0g
LS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDAuMDAwMDAwXSBXQVJO
SU5HOiBDUFU6IDAgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMw
NjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDAuMDAwMDAwXSBNb2R1bGVzIGxpbmtl
ZCBpbjoNClsgICAgMC4wMDAwMDBdIENQVTogMCBQSUQ6IDAgQ29tbTogc3dhcHBlci8wIFRhaW50
ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpb
ICAgIDAuMDAwMDAwXSBwc3RhdGU6IDYwMDAwMDg1IChuWkN2IGRhSWYgLVBBTiAtVUFPIC1UQ08g
QlRZUEU9LS0pDQpbICAgIDAuMDAwMDAwXSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAwLjAwMDAwMF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMC4wMDAw
MDBdIHNwIDogZmZmZjgwMDAxMTRkM2M4MA0KWyAgICAwLjAwMDAwMF0geDI5OiBmZmZmODAwMDEx
NGQzYzgwIHgyODogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMC4wMDAwMDBdIHgyNzogMDAwMDAw
MDAwMDAwMDAwMSB4MjY6IGZmZmY4MDAwMTIwMDAwNzAgDQpbICAgIDAuMDAwMDAwXSB4MjU6IGZm
ZmZmZTFmZmRlMGM4MDAgeDI0OiBmZmZmODAwMDEyMDAwMDAwIA0KWyAgICAwLjAwMDAwMF0geDIz
OiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMC4wMDAwMDBd
IHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDAuMDAw
MDAwXSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAw
LjAwMDAwMF0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAxZiANClsg
ICAgMC4wMDAwMDBdIHgxNTogZmZmZjgwMDA5MTRkMzk2NyB4MTQ6IDAwMDAwMDAwMDAwMDAwNTgg
DQpbICAgIDAuMDAwMDAwXSB4MTM6IDAwMDAwMDAwMDAwMDAwYzAgeDEyOiAwMDAwMDAwMDAwMDAw
MDAwIA0KWyAgICAwLjAwMDAwMF0geDExOiAwMDAwMDAwMDAwMDAwMDEwIHgxMDogMDAwMDAwMDAw
MDAwMDAwYyANClsgICAgMC4wMDAwMDBdIHg5IDogZmZmZjgwMDAxMGQzNmRjMCB4OCA6IDAwMDAw
MDAwMDAwMDAwMDAgDQpbICAgIDAuMDAwMDAwXSB4NyA6IGZmZmYwODA3MWVmZWZiYzAgeDYgOiAw
MDAwMDAwMDAwMDAwMDAzIA0KWyAgICAwLjAwMDAwMF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0
IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMC4wMDAwMDBdIHgzIDogMDAwMDAwMDAwMDAwMDAx
MCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDAuMDAwMDAwXSB4MSA6IDAwMDAwMDAwMDAw
MTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAwLjAwMDAwMF0gQ2FsbCB0cmFjZToN
ClsgICAgMC4wMDAwMDBdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMC4wMDAwMDBd
ICBnaWNfaW5pdF9iYXNlcysweDUyOC8weDU4NA0KWyAgICAwLjAwMDAwMF0gIGdpY19hY3BpX2lu
aXQrMHgxMzQvMHgyNzgNClsgICAgMC4wMDAwMDBdICBhY3BpX21hdGNoX21hZHQrMHg1MC8weDg4
DQpbICAgIDAuMDAwMDAwXSAgYWNwaV90YWJsZV9wYXJzZV9lbnRyaWVzX2FycmF5KzB4MTY0LzB4
MjRjDQpbICAgIDAuMDAwMDAwXSAgYWNwaV90YWJsZV9wYXJzZV9lbnRyaWVzKzB4NDgvMHg3MA0K
WyAgICAwLjAwMDAwMF0gIGFjcGlfdGFibGVfcGFyc2VfbWFkdCsweDM0LzB4NDANClsgICAgMC4w
MDAwMDBdICBfX2FjcGlfcHJvYmVfZGV2aWNlX3RhYmxlKzB4OTAvMHhlYw0KWyAgICAwLjAwMDAw
MF0gIGlycWNoaXBfaW5pdCsweDQwLzB4NGMNClsgICAgMC4wMDAwMDBdICBpbml0X0lSUSsweGQw
LzB4MTA0DQpbICAgIDAuMDAwMDAwXSAgc3RhcnRfa2VybmVsKzB4MzU0LzB4NTU0DQpbICAgIDAu
MDAwMDAwXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjUyIF0tLS0NClsgICAgMC4wMDAw
MDBdIEdJQ3YzOiBDUFUwOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAw
MDA4MDAwMDMyMDAwMA0KWyAgICAwLjAwMDAwMF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwg
d29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAwLjAwMDAwMF0gQUNQSSBH
VERUOiBmb3VuZCAxIG1lbW9yeS1tYXBwZWQgdGltZXIgYmxvY2socykuDQpbICAgIDAuMDAwMDAw
XSBhcmNoX3RpbWVyOiBjcDE1IGFuZCBtbWlvIHRpbWVyKHMpIHJ1bm5pbmcgYXQgMjUuMDBNSHog
KHZpcnQvcGh5cykuDQpbICAgIDAuMDAwMDAwXSBjbG9ja3NvdXJjZTogYXJjaF9zeXNfY291bnRl
cjogbWFzazogMHhmZmZmZmZmZmZmZmZmZiBtYXhfY3ljbGVzOiAweDVjNDA5MzliNSwgbWF4X2lk
bGVfbnM6IDQ0MDc5NTIwMjY0NiBucw0KWyAgICAwLjAwMDAwMV0gc2NoZWRfY2xvY2s6IDU2IGJp
dHMgYXQgMjVNSHosIHJlc29sdXRpb24gNDBucywgd3JhcHMgZXZlcnkgNDM5ODA0NjUxMTEwMG5z
DQpbICAgIDAuMDAwMDU2XSBDb25zb2xlOiBjb2xvdXIgZHVtbXkgZGV2aWNlIDgweDI1DQpbICAg
IDEuMjcxNzYzXSBwcmludGs6IGNvbnNvbGUgW2h2YzBdIGVuYWJsZWQNClsgICAgMS4yNzU5NTFd
IEFDUEk6IENvcmUgcmV2aXNpb24gMjAyMDA5MjUNClsgICAgMS4yODAyNjBdIEFDUEkgQklPUyBX
YXJuaW5nIChidWcpOiBJbmNvcnJlY3QgY2hlY2tzdW0gaW4gdGFibGUgW0lPUlRdIC0gMHhGMiwg
c2hvdWxkIGJlIDB4MEIgKDIwMjAwOTI1L3RicHJpbnQtMTczKQ0KWyAgICAxLjI5MDg0NF0gQ2Fs
aWJyYXRpbmcgZGVsYXkgbG9vcCAoc2tpcHBlZCksIHZhbHVlIGNhbGN1bGF0ZWQgdXNpbmcgdGlt
ZXIgZnJlcXVlbmN5Li4gNTAuMDAgQm9nb01JUFMgKGxwaj0xMDAwMDApDQpbICAgIDEuMzAxMTg1
XSBwaWRfbWF4OiBkZWZhdWx0OiAzMjc2OCBtaW5pbXVtOiAzMDENClsgICAgMS4zMDU4OTddIExT
TTogU2VjdXJpdHkgRnJhbWV3b3JrIGluaXRpYWxpemluZw0KWyAgICAxLjMxMDYyM10gTW91bnQt
Y2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAob3JkZXI6IDUsIDEzMTA3MiBieXRlcywg
bGluZWFyKQ0KWyAgICAxLjMxODIxN10gTW91bnRwb2ludC1jYWNoZSBoYXNoIHRhYmxlIGVudHJp
ZXM6IDE2Mzg0IChvcmRlcjogNSwgMTMxMDcyIGJ5dGVzLCBsaW5lYXIpDQpbICAgIDEuMzI2NjA4
XSBBQ1BJIFBQVFQ6IFBQVFQgdGFibGUgZm91bmQsIGJ1dCB1bmFibGUgdG8gbG9jYXRlIGNvcmUg
MiAoMikNClsgICAgMS4zMzM2MTBdIHhlbjpncmFudF90YWJsZTogR3JhbnQgdGFibGVzIHVzaW5n
IHZlcnNpb24gMSBsYXlvdXQNClsgICAgMS4zMzk1MzBdIEdyYW50IHRhYmxlIGluaXRpYWxpemVk
DQpbICAgIDEuMzQzMDk0XSB4ZW46ZXZlbnRzOiBVc2luZyBGSUZPLWJhc2VkIEFCSQ0KWyAgICAx
LjM0NzQyN10gWGVuOiBpbml0aWFsaXppbmcgY3B1MA0KWyAgICAxLjM1MDkxOF0gcmN1OiBIaWVy
YXJjaGljYWwgU1JDVSBpbXBsZW1lbnRhdGlvbi4NClsgICAgMS4zNTU4ODddIFBsYXRmb3JtIE1T
STogSVRTQDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzYxMzk5XSBQbGF0
Zm9ybSBNU0k6IElUU0AweDEwMDEwMDA2MDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjM2NzA1
N10gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwODAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAg
MS4zNzI2ODZdIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAwMGEwMDAwIGRvbWFpbiBjcmVhdGVk
DQpbICAgIDEuMzc4MzE4XSBQbGF0Zm9ybSBNU0k6IElUU0AweDEwMDEwMDBjMDAwMCBkb21haW4g
Y3JlYXRlZA0KWyAgICAxLjM4Mzk1OV0gUGxhdGZvcm0gTVNJOiBJVFNAMHgxMDAxMDAwZTAwMDAg
ZG9tYWluIGNyZWF0ZWQNClsgICAgMS4zODk2MDBdIFBsYXRmb3JtIE1TSTogSVRTQDB4MTAwMTAw
MTAwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuMzk1MjQzXSBQbGF0Zm9ybSBNU0k6IElUU0Aw
eDEwMDEwMDEyMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjQwMDg4OF0gUENJL01TSTogSVRT
QDB4MTAwMTAwMDQwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuNDA2MDk0XSBQQ0kvTVNJOiBJ
VFNAMHgxMDAxMDAwNjAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40MTEzMDRdIFBDSS9NU0k6
IElUU0AweDEwMDEwMDA4MDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjQxNjUxMF0gUENJL01T
STogSVRTQDB4MTAwMTAwMGEwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuNDIxNzIxXSBQQ0kv
TVNJOiBJVFNAMHgxMDAxMDAwYzAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40MjY5MjddIFBD
SS9NU0k6IElUU0AweDEwMDEwMDBlMDAwMCBkb21haW4gY3JlYXRlZA0KWyAgICAxLjQzMjEzNV0g
UENJL01TSTogSVRTQDB4MTAwMTAwMTAwMDAwIGRvbWFpbiBjcmVhdGVkDQpbICAgIDEuNDM3MzQ0
XSBQQ0kvTVNJOiBJVFNAMHgxMDAxMDAxMjAwMDAgZG9tYWluIGNyZWF0ZWQNClsgICAgMS40NDI1
NTVdIEVGSSBydW50aW1lIHNlcnZpY2VzIGFjY2VzcyB2aWEgcGFyYXZpcnQuDQpbICAgIDEuNDQ4
MDA5XSBzbXA6IEJyaW5naW5nIHVwIHNlY29uZGFyeSBDUFVzIC4uLg0KKFhFTikgZDB2MTogdkdJ
Q1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElW
RVIwDQooWEVOKSBkMHYyOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAw
MGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjM6IHZHSUNSOiBTR0k6IHVuaGFuZGxl
ZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2NDog
dkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FD
VElWRVIwDQooWEVOKSBkMHY1OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAw
MDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjY6IHZHSUNSOiBTR0k6IHVuaGFu
ZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2
NzogdkdJQ1I6IFNHSTogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJ
Q0FDVElWRVIwDQooWEVOKSBkMHY4OiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAw
eDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANCihYRU4pIGQwdjk6IHZHSUNSOiBTR0k6IHVu
aGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikg
ZDB2MTA6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYg
dG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTE6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdy
aXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTI6IHZHSUNSOiBT
R0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0K
KFhFTikgZDB2MTM6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZm
ZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTQ6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3
b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTU6IHZH
SUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJ
VkVSMA0KKFhFTikgZDB2MTY6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAw
MDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MTc6IHZHSUNSOiBTR0k6IHVuaGFu
ZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2
MTg6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8g
SUNBQ1RJVkVSMA0KKFhFTikgZDB2MTk6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRl
IDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjA6IHZHSUNSOiBTR0k6
IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhF
TikgZDB2MjE6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZm
ZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjI6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3Jk
IHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjM6IHZHSUNS
OiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVS
MA0KKFhFTikgZDB2MjQ6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAw
ZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjU6IHZHSUNSOiBTR0k6IHVuaGFuZGxl
ZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MjY6
IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNB
Q1RJVkVSMA0KKFhFTikgZDB2Mjc6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4
MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2Mjg6IHZHSUNSOiBTR0k6IHVu
aGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikg
ZDB2Mjk6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYg
dG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MzA6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdy
aXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0KKFhFTikgZDB2MzE6IHZHSUNSOiBT
R0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMA0K
WyAgICAxLjQ1MjYzN10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTENClsgICAgMS40NTI2
NjJdIEdJQ3YzOiBDUFUxOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwMTYwMDAwDQpbICAgIDEuNDU5MTk0XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0t
LS0tLS0NClsgICAgMS40NTkxOThdIFdBUk5JTkc6IENQVTogMSBQSUQ6IDAgYXQgZHJpdmVycy9p
cnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS40NTkxOTldIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ1OTIwM10gQ1BVOiAxIFBJ
RDogMCBDb21tOiBzd2FwcGVyLzEgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjct
YW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS40NTkyMDVdIHBzdGF0ZTogNjAwMDAxYzUg
KG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS40NTkyMDddIHBjIDog
aXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDU5MjA4XSBsciA6IGl0c19jcHVfaW5p
dCsweDgyMC8weGIyMA0KWyAgICAxLjQ1OTIwOV0gc3AgOiBmZmZmODAwMDExYTNiZTgwDQpbICAg
IDEuNDU5MjEwXSB4Mjk6IGZmZmY4MDAwMTFhM2JlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDAxIA0K
WyAgICAxLjQ1OTIxMl0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjAyMDA3
MCANClsgICAgMS40NTkyMTRdIHgyNTogZmZmZmZlMWZmZGUwY2MwMCB4MjQ6IGZmZmY4MDAwMTIw
MjAwMDAgDQpbICAgIDEuNDU5MjE2XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAw
MDEwZmY5MDAwIA0KWyAgICAxLjQ1OTIxOF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZm
ZjgwMDAxMTYyMjM1MCANClsgICAgMS40NTkyMjBdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6
IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNDU5MjIyXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAg
eDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjQ1OTIyNF0geDE1OiBmZmZmODAwMDExNmQ1
MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS40NTkyMjZdIHgxMzogZmZmZjgwMDAx
MTZkNGNmNCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDU5MjI4XSB4MTE6IDAwMDAw
MDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjQ1OTIzMF0geDkgOiBm
ZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzMDMwMzAzNjMxMzAzMCANClsgICAgMS40NTkyMzJdIHg3
IDogMzEzMDMwMzEzMDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNDU5MjM0
XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjQ1
OTIzNl0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAg
MS40NTkyMzhdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpb
ICAgIDEuNDU5MjQwXSBDYWxsIHRyYWNlOg0KWyAgICAxLjQ1OTI0MV0gIGl0c19jcHVfaW5pdCsw
eDgyNC8weGIyMA0KWyAgICAxLjQ1OTI0NV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpb
ICAgIDEuNDU5MjQ3XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS40
NTkyNTBdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjQ1OTI1M10gIHNl
Y29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjQ1OTI1NF0gLS0tWyBlbmQg
dHJhY2UgZjY4NzI4YTBkMzA1M2I1MyBdLS0tDQpbICAgIDEuNDU5MjU5XSBHSUN2MzogQ1BVMTog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzMzAwMDANClsg
ICAgMS40NTkzMTZdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS40NTkzMjVdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTEN
ClsgICAgMS40NTkzNDRdIENQVTE6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAw
MDAwMSBbMHg0MTNmZDBjMV0NClsgICAgMS40NTk2NDBdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBv
biBDUFUyDQpbICAgIDEuNDU5NjY4XSBHSUN2MzogQ1BVMjogZm91bmQgcmVkaXN0cmlidXRvciAy
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDE4MDAwMA0KWyAgICAxLjQ2NjIwNF0gLS0tLS0tLS0tLS0t
WyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNDY2MjExXSBXQVJOSU5HOiBDUFU6IDIg
UElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9p
bml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDY2MjEyXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAg
MS40NjYyMTddIENQVTogMiBQSUQ6IDAgQ29tbTogc3dhcHBlci8yIFRhaW50ZWQ6IEcgICAgICAg
IFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNDY2MjE5
XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpb
ICAgIDEuNDY2MjIyXSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ2NjIy
M10gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS40NjYyMjRdIHNwIDogZmZm
ZjgwMDAxMWE0M2U4MA0KWyAgICAxLjQ2NjIyNV0geDI5OiBmZmZmODAwMDExYTQzZTgwIHgyODog
MDAwMDAwMDAwMDAwMDAwMiANClsgICAgMS40NjYyMjddIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4
MjY6IGZmZmY4MDAwMTIwNDAwNzAgDQpbICAgIDEuNDY2MjI5XSB4MjU6IGZmZmZmZTFmZmRlMGQw
MDAgeDI0OiBmZmZmODAwMDEyMDQwMDAwIA0KWyAgICAxLjQ2NjIzMV0geDIzOiBmZmZmODAwMDEx
NGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS40NjYyMzNdIHgyMTogZmZmZjgw
MDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNDY2MjM1XSB4MTk6IGZm
ZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjQ2NjIzN10geDE3
OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40NjYyMzld
IHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNDY2
MjQxXSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAx
LjQ2NjI0M10geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsg
ICAgMS40NjYyNDVdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzMDMwMzgzMTMwMzAg
DQpbICAgIDEuNDY2MjQ3XSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAwMDAwMDAwMDAwMDAw
MDAzIA0KWyAgICAxLjQ2NjI0OV0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZm
ZmUwMDAwMCANClsgICAgMS40NjYyNTFdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAw
MDAwMDAwMGZmZmYgDQpbICAgIDEuNDY2MjUzXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAw
MDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjQ2NjI1NV0gQ2FsbCB0cmFjZToNClsgICAgMS40NjYy
NTddICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40NjYyNjFdICBnaWNfc3RhcnRp
bmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjQ2NjI2NF0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysw
eGE0LzB4NDYwDQpbICAgIDEuNDY2MjY2XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTAN
ClsgICAgMS40NjYyNjldICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAg
MS40NjYyNzFdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTQgXS0tLQ0KWyAgICAxLjQ2
NjI3Nl0gR0lDdjM6IENQVTI6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgw
MDAwMDgwMDAwMzQwMDAwDQpbICAgIDEuNDY2MzQzXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2Nh
bCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNDY2MzU1XSBYZW46
IGluaXRpYWxpemluZyBjcHUyDQpbICAgIDEuNDY2MzgwXSBDUFUyOiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAwMDAwMDIgWzB4NDEzZmQwYzFdDQpbICAgIDEuNDY2NjUzXSBEZXRl
Y3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMw0KWyAgICAxLjQ2NjY3OV0gR0lDdjM6IENQVTM6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgMyByZWdpb24gMDoweDAwMDAxMDAxMDAxYTAwMDANClsgICAgMS40
NzMyMTFdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjQ3MzIx
Nl0gV0FSTklORzogQ1BVOiAzIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1p
dHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ3MzIxN10gTW9kdWxl
cyBsaW5rZWQgaW46DQpbICAgIDEuNDczMjIxXSBDUFU6IDMgUElEOiAwIENvbW06IHN3YXBwZXIv
MyBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJk
KyAjMQ0KWyAgICAxLjQ3MzIyM10gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVB
TyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjQ3MzIyNV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMS40NzMyMjZdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAg
IDEuNDczMjI3XSBzcCA6IGZmZmY4MDAwMTFhNGJlODANClsgICAgMS40NzMyMjhdIHgyOTogZmZm
ZjgwMDAxMWE0YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNDczMjMxXSB4Mjc6
IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMDYwMDcwIA0KWyAgICAxLjQ3MzIzM10g
eDI1OiBmZmZmZmUxZmZkZTBkNDAwIHgyNDogZmZmZjgwMDAxMjA2MDAwMCANClsgICAgMS40NzMy
MzVdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEu
NDczMjM3XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAg
ICAxLjQ3MzIzOV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiAN
ClsgICAgMS40NzMyNDFdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAw
MDAgDQpbICAgIDEuNDczMjQzXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAw
MDAwMDEwIA0KWyAgICAxLjQ3MzI0NV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAw
MDAwMDAwMDAwMCANClsgICAgMS40NzMyNDddIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAw
MDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNDczMjQ4XSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDgg
OiAzMDMwMzAzMDYxMzEzMDMwIA0KWyAgICAxLjQ3MzI1MF0geDcgOiAzMTMwMzAzMTMwMzAzMDMw
IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40NzMyNTJdIHg1IDogMDAwMDAwMDAwMDAw
MDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDczMjU0XSB4MyA6IDAwMDAwMDAw
MDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ3MzI1Nl0geDEgOiAwMDAw
MDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40NzMyNTldIENhbGwg
dHJhY2U6DQpbICAgIDEuNDczMjYwXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEu
NDczMjYzXSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40NzMyNjZdICBjcHVo
cF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ3MzI2OF0gIG5vdGlmeV9jcHVf
c3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNDczMjcwXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5l
bCsweGU4LzB4MTkwDQpbICAgIDEuNDczMjcxXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUz
YjU1IF0tLS0NClsgICAgMS40NzMyNzddIEdJQ3YzOiBDUFUzOiB1c2luZyBhbGxvY2F0ZWQgTFBJ
IHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDM1MDAwMA0KWyAgICAxLjQ3MzMzNl0gYXJjaF90
aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0K
WyAgICAxLjQ3MzM0NV0gWGVuOiBpbml0aWFsaXppbmcgY3B1Mw0KWyAgICAxLjQ3MzM2NV0gQ1BV
MzogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDAzIFsweDQxM2ZkMGMxXQ0K
WyAgICAxLjQ3MzYyMl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTQNClsgICAgMS40NzM2
NTBdIEdJQ3YzOiBDUFU0OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDQgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwMWMwMDAwDQpbICAgIDEuNDgwMTgyXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0t
LS0tLS0NClsgICAgMS40ODAxODddIFdBUk5JTkc6IENQVTogNCBQSUQ6IDAgYXQgZHJpdmVycy9p
cnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS40ODAxODhdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjQ4MDE5MV0gQ1BVOiA0IFBJ
RDogMCBDb21tOiBzd2FwcGVyLzQgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjct
YW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS40ODAxOTRdIHBzdGF0ZTogNjAwMDAxYzUg
KG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS40ODAxOTVdIHBjIDog
aXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDgwMTk3XSBsciA6IGl0c19jcHVfaW5p
dCsweDgyMC8weGIyMA0KWyAgICAxLjQ4MDE5OF0gc3AgOiBmZmZmODAwMDExYTUzZTgwDQpbICAg
IDEuNDgwMTk5XSB4Mjk6IGZmZmY4MDAwMTFhNTNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDA0IA0K
WyAgICAxLjQ4MDIwMV0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjA4MDA3
MCANClsgICAgMS40ODAyMDNdIHgyNTogZmZmZmZlMWZmZGUwZDgwMCB4MjQ6IGZmZmY4MDAwMTIw
ODAwMDAgDQpbICAgIDEuNDgwMjA1XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAw
MDEwZmY5MDAwIA0KWyAgICAxLjQ4MDIwN10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZm
ZjgwMDAxMTYyMjM1MCANClsgICAgMS40ODAyMDldIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6
IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNDgwMjExXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAg
eDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjQ4MDIxM10geDE1OiBmZmZmODAwMDExNmQ1
MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS40ODAyMTVdIHgxMzogZmZmZjgwMDAx
MTZkNGNmNCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNDgwMjE3XSB4MTE6IDAwMDAw
MDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjQ4MDIxOV0geDkgOiBm
ZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzMDMwMzA2MzMxMzAzMCANClsgICAgMS40ODAyMjFdIHg3
IDogMzEzMDMwMzEzMDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNDgwMjIz
XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjQ4
MDIyNF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAg
MS40ODAyMjddIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpb
ICAgIDEuNDgwMjI5XSBDYWxsIHRyYWNlOg0KWyAgICAxLjQ4MDIzMF0gIGl0c19jcHVfaW5pdCsw
eDgyNC8weGIyMA0KWyAgICAxLjQ4MDIzM10gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpb
ICAgIDEuNDgwMjM2XSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS40
ODAyMzhdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjQ4MDI0MF0gIHNl
Y29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjQ4MDI0MV0gLS0tWyBlbmQg
dHJhY2UgZjY4NzI4YTBkMzA1M2I1NiBdLS0tDQpbICAgIDEuNDgwMjQ3XSBHSUN2MzogQ1BVNDog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzNjAwMDANClsg
ICAgMS40ODAzMTNdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS40ODAzMjFdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTQN
ClsgICAgMS40ODAzNDJdIENQVTQ6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAw
MDAwNCBbMHg0MTNmZDBjMV0NClsgICAgMS40ODA2OTRdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBv
biBDUFU1DQpbICAgIDEuNDgwNzI0XSBHSUN2MzogQ1BVNTogZm91bmQgcmVkaXN0cmlidXRvciA1
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDFlMDAwMA0KWyAgICAxLjQ4NzI1NV0gLS0tLS0tLS0tLS0t
WyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNDg3MjYwXSBXQVJOSU5HOiBDUFU6IDUg
UElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9p
bml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNDg3MjYxXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAg
MS40ODcyNjVdIENQVTogNSBQSUQ6IDAgQ29tbTogc3dhcHBlci81IFRhaW50ZWQ6IEcgICAgICAg
IFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNDg3MjY3
XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpb
ICAgIDEuNDg3MjY5XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ4NzI3
MF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS40ODcyNzFdIHNwIDogZmZm
ZjgwMDAxMWE1YmU4MA0KWyAgICAxLjQ4NzI3Ml0geDI5OiBmZmZmODAwMDExYTViZTgwIHgyODog
MDAwMDAwMDAwMDAwMDAwNSANClsgICAgMS40ODcyNzRdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4
MjY6IGZmZmY4MDAwMTIwYTAwNzAgDQpbICAgIDEuNDg3Mjc2XSB4MjU6IGZmZmZmZTFmZmRlMGRj
MDAgeDI0OiBmZmZmODAwMDEyMGEwMDAwIA0KWyAgICAxLjQ4NzI3OF0geDIzOiBmZmZmODAwMDEx
NGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS40ODcyODBdIHgyMTogZmZmZjgw
MDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNDg3MjgyXSB4MTk6IGZm
ZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjQ4NzI4NF0geDE3
OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS40ODcyODdd
IHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNDg3
Mjg5XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAx
LjQ4NzI5MF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsg
ICAgMS40ODcyOTJdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzMDMwNjUzMTMwMzAg
DQpbICAgIDEuNDg3Mjk0XSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAwMDAwMDAwMDAwMDAw
MDAzIA0KWyAgICAxLjQ4NzI5Nl0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZm
ZmUwMDAwMCANClsgICAgMS40ODcyOThdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAw
MDAwMDAwMGZmZmYgDQpbICAgIDEuNDg3MzAwXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAw
MDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjQ4NzMwMl0gQ2FsbCB0cmFjZToNClsgICAgMS40ODcz
MDRdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS40ODczMDddICBnaWNfc3RhcnRp
bmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjQ4NzMxMF0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysw
eGE0LzB4NDYwDQpbICAgIDEuNDg3MzEyXSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTAN
ClsgICAgMS40ODczMTRdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAg
MS40ODczMTZdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNTcgXS0tLQ0KWyAgICAxLjQ4
NzMyMV0gR0lDdjM6IENQVTU6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgw
MDAwMDgwMDAwMzcwMDAwDQpbICAgIDEuNDg3MzgwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2Nh
bCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNDg3Mzg5XSBYZW46
IGluaXRpYWxpemluZyBjcHU1DQpbICAgIDEuNDg3NDEwXSBDUFU1OiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAwMDAwMDUgWzB4NDEzZmQwYzFdDQpbICAgIDEuNDg3NzY2XSBEZXRl
Y3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVNg0KWyAgICAxLjQ4Nzc5OV0gR0lDdjM6IENQVTY6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgNiByZWdpb24gMDoweDAwMDAxMDAxMDAyMDAwMDANClsgICAgMS40
OTQzMzJdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjQ5NDMz
N10gV0FSTklORzogQ1BVOiA2IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1p
dHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjQ5NDMzN10gTW9kdWxl
cyBsaW5rZWQgaW46DQpbICAgIDEuNDk0MzQxXSBDUFU6IDYgUElEOiAwIENvbW06IHN3YXBwZXIv
NiBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJk
KyAjMQ0KWyAgICAxLjQ5NDM0M10gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVB
TyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjQ5NDM0NV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMS40OTQzNDddIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAg
IDEuNDk0MzQ3XSBzcCA6IGZmZmY4MDAwMTFhNjNlODANClsgICAgMS40OTQzNDldIHgyOTogZmZm
ZjgwMDAxMWE2M2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDYgDQpbICAgIDEuNDk0MzUxXSB4Mjc6
IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMGMwMDcwIA0KWyAgICAxLjQ5NDM1M10g
eDI1OiBmZmZmZmUxZmZkZTBlMDAwIHgyNDogZmZmZjgwMDAxMjBjMDAwMCANClsgICAgMS40OTQz
NTVdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEu
NDk0MzU3XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAg
ICAxLjQ5NDM1OV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiAN
ClsgICAgMS40OTQzNjFdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAw
MDAgDQpbICAgIDEuNDk0MzYzXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAw
MDAwMDEwIA0KWyAgICAxLjQ5NDM2NF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAw
MDAwMDAwMDAwMCANClsgICAgMS40OTQzNjZdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAw
MDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNDk0MzY4XSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDgg
OiAzMDMwMzAzMDMwMzIzMDMwIA0KWyAgICAxLjQ5NDM3MF0geDcgOiAzMTMwMzAzMTMwMzAzMDMw
IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS40OTQzNzJdIHg1IDogMDAwMDAwMDAwMDAw
MDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNDk0Mzc0XSB4MyA6IDAwMDAwMDAw
MDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjQ5NDM3Nl0geDEgOiAwMDAw
MDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS40OTQzNzhdIENhbGwg
dHJhY2U6DQpbICAgIDEuNDk0MzgwXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEu
NDk0MzgyXSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS40OTQzODVdICBjcHVo
cF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjQ5NDM4N10gIG5vdGlmeV9jcHVf
c3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNDk0Mzg5XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5l
bCsweGU4LzB4MTkwDQpbICAgIDEuNDk0MzkxXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUz
YjU4IF0tLS0NClsgICAgMS40OTQzOTZdIEdJQ3YzOiBDUFU2OiB1c2luZyBhbGxvY2F0ZWQgTFBJ
IHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDM4MDAwMA0KWyAgICAxLjQ5NDQ2M10gYXJjaF90
aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0K
WyAgICAxLjQ5NDQ3Ml0gWGVuOiBpbml0aWFsaXppbmcgY3B1Ng0KWyAgICAxLjQ5NDQ5M10gQ1BV
NjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA2IFsweDQxM2ZkMGMxXQ0K
WyAgICAxLjQ5NDgzOV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTcNClsgICAgMS40OTQ4
NzNdIEdJQ3YzOiBDUFU3OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDcgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwMjIwMDAwDQpbICAgIDEuNTAxNDA1XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0t
LS0tLS0NClsgICAgMS41MDE0MTBdIFdBUk5JTkc6IENQVTogNyBQSUQ6IDAgYXQgZHJpdmVycy9p
cnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS41MDE0MTFdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjUwMTQxNV0gQ1BVOiA3IFBJ
RDogMCBDb21tOiBzd2FwcGVyLzcgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjct
YW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS41MDE0MTddIHBzdGF0ZTogNjAwMDAxYzUg
KG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41MDE0MTldIHBjIDog
aXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTAxNDIxXSBsciA6IGl0c19jcHVfaW5p
dCsweDgyMC8weGIyMA0KWyAgICAxLjUwMTQyMl0gc3AgOiBmZmZmODAwMDExYTZiZTgwDQpbICAg
IDEuNTAxNDIzXSB4Mjk6IGZmZmY4MDAwMTFhNmJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDA3IA0K
WyAgICAxLjUwMTQyNV0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjBlMDA3
MCANClsgICAgMS41MDE0MjddIHgyNTogZmZmZmZlMWZmZGUwZTQwMCB4MjQ6IGZmZmY4MDAwMTIw
ZTAwMDAgDQpbICAgIDEuNTAxNDI5XSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAw
MDEwZmY5MDAwIA0KWyAgICAxLjUwMTQzMV0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZm
ZjgwMDAxMTYyMjM1MCANClsgICAgMS41MDE0MzNdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6
IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTAxNDM1XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAg
eDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjUwMTQzN10geDE1OiBmZmZmODAwMDExNmQ1
MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41MDE0MzldIHgxMzogZmZmZjgwMDAx
MTZkNGNmNCB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTAxNDQxXSB4MTE6IDAwMDAw
MDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjUwMTQ0M10geDkgOiBm
ZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzMDMwMzAzMjMyMzAzMCANClsgICAgMS41MDE0NDRdIHg3
IDogMzEzMDMwMzEzMDMwMzAzMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTAxNDQ2
XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjUw
MTQ0OF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAg
MS41MDE0NTBdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpb
ICAgIDEuNTAxNDUyXSBDYWxsIHRyYWNlOg0KWyAgICAxLjUwMTQ1NF0gIGl0c19jcHVfaW5pdCsw
eDgyNC8weGIyMA0KWyAgICAxLjUwMTQ1N10gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpb
ICAgIDEuNTAxNDYwXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41
MDE0NjJdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjUwMTQ2NF0gIHNl
Y29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjUwMTQ2Nl0gLS0tWyBlbmQg
dHJhY2UgZjY4NzI4YTBkMzA1M2I1OSBdLS0tDQpbICAgIDEuNTAxNDcyXSBHSUN2MzogQ1BVNzog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzOTAwMDANClsg
ICAgMS41MDE1MzFdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41MDE1NDBdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTcN
ClsgICAgMS41MDE1NjFdIENQVTc6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAw
MDAwNyBbMHg0MTNmZDBjMV0NClsgICAgMS41MDE4MThdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBv
biBDUFU4DQpbICAgIDEuNTAxODU1XSBHSUN2MzogQ1BVODogZm91bmQgcmVkaXN0cmlidXRvciA4
IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDI0MDAwMA0KWyAgICAxLjUwODM4OF0gLS0tLS0tLS0tLS0t
WyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTA4MzkzXSBXQVJOSU5HOiBDUFU6IDgg
UElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9p
bml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTA4Mzk0XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAg
MS41MDgzOThdIENQVTogOCBQSUQ6IDAgQ29tbTogc3dhcHBlci84IFRhaW50ZWQ6IEcgICAgICAg
IFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTA4NDAw
XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpb
ICAgIDEuNTA4NDAyXSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUwODQw
NF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41MDg0MDVdIHNwIDogZmZm
ZjgwMDAxMWE3M2U4MA0KWyAgICAxLjUwODQwNl0geDI5OiBmZmZmODAwMDExYTczZTgwIHgyODog
MDAwMDAwMDAwMDAwMDAwOCANClsgICAgMS41MDg0MDhdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4
MjY6IGZmZmY4MDAwMTIxMDAwNzAgDQpbICAgIDEuNTA4NDEwXSB4MjU6IGZmZmZmZTFmZmRlMGU4
MDAgeDI0OiBmZmZmODAwMDEyMTAwMDAwIA0KWyAgICAxLjUwODQxM10geDIzOiBmZmZmODAwMDEx
NGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41MDg0MTVdIHgyMTogZmZmZjgw
MDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTA4NDE3XSB4MTk6IGZm
ZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjUwODQxOF0geDE3
OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MDg0MjBd
IHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTA4
NDIyXSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjQgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAx
LjUwODQyNV0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsg
ICAgMS41MDg0MjddIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzMDMwMzQzMjMwMzAg
DQpbICAgIDEuNTA4NDI5XSB4NyA6IDMxMzAzMDMxMzAzMDMwMzAgeDYgOiAwMDAwMDAwMDAwMDAw
MDAzIA0KWyAgICAxLjUwODQzMF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZm
ZmUwMDAwMCANClsgICAgMS41MDg0MzJdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAw
MDAwMDAwMGZmZmYgDQpbICAgIDEuNTA4NDM0XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAw
MDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjUwODQzNl0gQ2FsbCB0cmFjZToNClsgICAgMS41MDg0
MzhdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MDg0NDFdICBnaWNfc3RhcnRp
bmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjUwODQ0M10gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysw
eGE0LzB4NDYwDQpbICAgIDEuNTA4NDQ1XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTAN
ClsgICAgMS41MDg0NDddICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAg
MS41MDg0NDldIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNWEgXS0tLQ0KWyAgICAxLjUw
ODQ1NF0gR0lDdjM6IENQVTg6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgw
MDAwMDgwMDAwM2EwMDAwDQpbICAgIDEuNTA4NTIwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2Nh
bCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTA4NTMwXSBYZW46
IGluaXRpYWxpemluZyBjcHU4DQpbICAgIDEuNTA4NTUyXSBDUFU4OiBCb290ZWQgc2Vjb25kYXJ5
IHByb2Nlc3NvciAweDAwMDAwMDAwMDggWzB4NDEzZmQwYzFdDQpbICAgIDEuNTA4OTA1XSBEZXRl
Y3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVOQ0KWyAgICAxLjUwODk0M10gR0lDdjM6IENQVTk6IGZv
dW5kIHJlZGlzdHJpYnV0b3IgOSByZWdpb24gMDoweDAwMDAxMDAxMDAyNjAwMDANClsgICAgMS41
MTU0NzZdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjUxNTQ4
MV0gV0FSTklORzogQ1BVOiA5IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1p
dHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjUxNTQ4Ml0gTW9kdWxl
cyBsaW5rZWQgaW46DQpbICAgIDEuNTE1NDg2XSBDUFU6IDkgUElEOiAwIENvbW06IHN3YXBwZXIv
OSBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJk
KyAjMQ0KWyAgICAxLjUxNTQ4OF0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVB
TyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjUxNTQ5MF0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQv
MHhiMjANClsgICAgMS41MTU0OTFdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAg
IDEuNTE1NDkyXSBzcCA6IGZmZmY4MDAwMTFhN2JlODANClsgICAgMS41MTU0OTNdIHgyOTogZmZm
ZjgwMDAxMWE3YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDkgDQpbICAgIDEuNTE1NDk1XSB4Mjc6
IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMTIwMDcwIA0KWyAgICAxLjUxNTQ5N10g
eDI1OiBmZmZmZmUxZmZkZTBlYzAwIHgyNDogZmZmZjgwMDAxMjEyMDAwMCANClsgICAgMS41MTU0
OTldIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEu
NTE1NTAxXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAg
ICAxLjUxNTUwM10geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiAN
ClsgICAgMS41MTU1MDVdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAw
MDAgDQpbICAgIDEuNTE1NTA3XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAw
MDAwMDEwIA0KWyAgICAxLjUxNTUwOV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y0IHgxMjogMDAwMDAw
MDAwMDAwMDAwMCANClsgICAgMS41MTU1MTBdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAw
MDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTE1NTEyXSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDgg
OiAzMDMwMzAzMDM2MzIzMDMwIA0KWyAgICAxLjUxNTUxNF0geDcgOiAzMTMwMzAzMTMwMzAzMDMw
IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41MTU1MTZdIHg1IDogMDAwMDAwMDAwMDAw
MDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTE1NTE4XSB4MyA6IDAwMDAwMDAw
MDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjUxNTUyMF0geDEgOiAwMDAw
MDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41MTU1MjJdIENhbGwg
dHJhY2U6DQpbICAgIDEuNTE1NTI0XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEu
NTE1NTI3XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41MTU1MjldICBjcHVo
cF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjUxNTUzMV0gIG5vdGlmeV9jcHVf
c3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTE1NTM0XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5l
bCsweGU4LzB4MTkwDQpbICAgIDEuNTE1NTM1XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUz
YjViIF0tLS0NClsgICAgMS41MTU1NDFdIEdJQ3YzOiBDUFU5OiB1c2luZyBhbGxvY2F0ZWQgTFBJ
IHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMDNiMDAwMA0KWyAgICAxLjUxNTYwMF0gYXJjaF90
aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0K
WyAgICAxLjUxNTYwOV0gWGVuOiBpbml0aWFsaXppbmcgY3B1OQ0KWyAgICAxLjUxNTYzMV0gQ1BV
OTogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDA5IFsweDQxM2ZkMGMxXQ0K
WyAgICAxLjUxNTk3Ml0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEwDQpbICAgIDEuNTE2
MDEzXSBHSUN2MzogQ1BVMTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgYSByZWdpb24gMDoweDAwMDAx
MDAxMDAyODAwMDANClsgICAgMS41MjI2MzNdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0t
LS0tLS0tLQ0KWyAgICAxLjUyMjYzOF0gV0FSTklORzogQ1BVOiAxMCBQSUQ6IDAgYXQgZHJpdmVy
cy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjAN
ClsgICAgMS41MjI2MzldIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjUyMjY0M10gQ1BVOiAx
MCBQSUQ6IDAgQ29tbTogc3dhcHBlci8xMCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4x
MC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjUyMjY0NV0gcHN0YXRlOiA2MDAw
MDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjUyMjY0N10g
cGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MjI2NDldIGxyIDogaXRzX2Nw
dV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTIyNjUwXSBzcCA6IGZmZmY4MDAwMTFhODNlODAN
ClsgICAgMS41MjI2NTFdIHgyOTogZmZmZjgwMDAxMWE4M2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAw
MGEgDQpbICAgIDEuNTIyNjUzXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEy
MTQwMDcwIA0KWyAgICAxLjUyMjY1NV0geDI1OiBmZmZmZmUxZmZkZTBmMDAwIHgyNDogZmZmZjgw
MDAxMjE0MDAwMCANClsgICAgMS41MjI2NTddIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZm
ZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTIyNjYwXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIw
OiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjUyMjY2Ml0geDE5OiBmZmZmODAwMDExNjIyMDAw
IHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41MjI2NjNdIHgxNzogMDAwMDAwMDAwMDAw
MDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTIyNjY1XSB4MTU6IGZmZmY4MDAw
MTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjUyMjY2N10geDEzOiBmZmZm
ODAwMDExNmQ0Y2Y1IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MjI2NjldIHgxMTog
MDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTIyNjcxXSB4
OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDMwMzAzODMyMzAzMDMxIA0KWyAgICAxLjUyMjY3
M10geDcgOiAzMDMwMzEzMDMwMzAzMDc4IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41
MjI2NzVdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAg
IDEuNTIyNjc3XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0K
WyAgICAxLjUyMjY3OV0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZl
ZCANClsgICAgMS41MjI2ODFdIENhbGwgdHJhY2U6DQpbICAgIDEuNTIyNjgzXSAgaXRzX2NwdV9p
bml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTIyNjg2XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4
OTANClsgICAgMS41MjI2ODhdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAg
ICAxLjUyMjY5MF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTIyNjky
XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTIyNjk0XSAtLS1b
IGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjVjIF0tLS0NClsgICAgMS41MjI3MDBdIEdJQ3YzOiBD
UFUxMDogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzYzAw
MDANClsgICAgMS41MjI3NjZdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQg
Zm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41MjI3NzRdIFhlbjogaW5pdGlhbGl6aW5n
IGNwdTEwDQpbICAgIDEuNTIyNzk3XSBDUFUxMDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3Ig
MHgwMDAwMDAwMDBhIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjUyMzE1Ml0gRGV0ZWN0ZWQgUElQVCBJ
LWNhY2hlIG9uIENQVTExDQpbICAgIDEuNTIzMTk0XSBHSUN2MzogQ1BVMTE6IGZvdW5kIHJlZGlz
dHJpYnV0b3IgYiByZWdpb24gMDoweDAwMDAxMDAxMDAyYTAwMDANClsgICAgMS41Mjk4MTRdIC0t
LS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjUyOTgxOV0gV0FSTklO
RzogQ1BVOiAxMSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2
OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41Mjk4MjBdIE1vZHVsZXMgbGlua2Vk
IGluOg0KWyAgICAxLjUyOTgyNF0gQ1BVOiAxMSBQSUQ6IDAgQ29tbTogc3dhcHBlci8xMSBUYWlu
dGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0K
WyAgICAxLjUyOTgyNl0gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENP
IEJUWVBFPS0tKQ0KWyAgICAxLjUyOTgyOF0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjAN
ClsgICAgMS41Mjk4MjldIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTI5
ODMwXSBzcCA6IGZmZmY4MDAwMTFhOGJlODANClsgICAgMS41Mjk4MzFdIHgyOTogZmZmZjgwMDAx
MWE4YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMGIgDQpbICAgIDEuNTI5ODM0XSB4Mjc6IDAwMDAw
MDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMTYwMDcwIA0KWyAgICAxLjUyOTgzNl0geDI1OiBm
ZmZmZmUxZmZkZTBmNDAwIHgyNDogZmZmZjgwMDAxMjE2MDAwMCANClsgICAgMS41Mjk4MzddIHgy
MzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTI5ODQw
XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjUy
OTg0MV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAg
MS41Mjk4NDNdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpb
ICAgIDEuNTI5ODQ1XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEw
IA0KWyAgICAxLjUyOTg0N10geDEzOiBmZmZmODAwMDExNmQ0Y2Y1IHgxMjogMDAwMDAwMDAwMDAw
MDAwMCANClsgICAgMS41Mjk4NDldIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAw
MDAwMDAwMDEgDQpbICAgIDEuNTI5ODUxXSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDMw
MzA2MTMyMzAzMDMxIA0KWyAgICAxLjUyOTg1M10geDcgOiAzMDMwMzEzMDMwMzAzMDc4IHg2IDog
MDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41Mjk4NTVdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4
NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTI5ODU2XSB4MyA6IDAwMDAwMDAwMDAwMDAw
MTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjUyOTg1OF0geDEgOiAwMDAwMDAwMDAw
MDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41Mjk4NjFdIENhbGwgdHJhY2U6
DQpbICAgIDEuNTI5ODYyXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTI5ODY2
XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41Mjk4NjhdICBjcHVocF9pbnZv
a2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjUyOTg3MF0gIG5vdGlmeV9jcHVfc3RhcnRp
bmcrMHhhMC8weGUwDQpbICAgIDEuNTI5ODczXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4
LzB4MTkwDQpbICAgIDEuNTI5ODc0XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjVkIF0t
LS0NClsgICAgMS41Mjk4ODBdIEdJQ3YzOiBDUFUxMTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5k
aW5nIHRhYmxlIEAweDAwMDAwODAwMDAzZDAwMDANClsgICAgMS41Mjk5MzldIGFyY2hfdGltZXI6
IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAg
MS41Mjk5NDddIFhlbjogaW5pdGlhbGl6aW5nIGNwdTExDQpbICAgIDEuNTI5OTY4XSBDUFUxMTog
Qm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDBiIFsweDQxM2ZkMGMxXQ0KWyAg
ICAxLjUzMDI3Ml0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTEyDQpbICAgIDEuNTMwMzE3
XSBHSUN2MzogQ1BVMTI6IGZvdW5kIHJlZGlzdHJpYnV0b3IgYyByZWdpb24gMDoweDAwMDAxMDAx
MDAyYzAwMDANClsgICAgMS41MzY5MzddIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0t
LS0tLQ0KWyAgICAxLjUzNjk0Ml0gV0FSTklORzogQ1BVOiAxMiBQSUQ6IDAgYXQgZHJpdmVycy9p
cnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS41MzY5NDNdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjUzNjk0N10gQ1BVOiAxMiBQ
SUQ6IDAgQ29tbTogc3dhcHBlci8xMiBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4y
Ny1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjUzNjk0OV0gcHN0YXRlOiA2MDAwMDFj
NSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjUzNjk1MV0gcGMg
OiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41MzY5NTJdIGxyIDogaXRzX2NwdV9p
bml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTM2OTUzXSBzcCA6IGZmZmY4MDAwMTFhOTNlODANClsg
ICAgMS41MzY5NTRdIHgyOTogZmZmZjgwMDAxMWE5M2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMGMg
DQpbICAgIDEuNTM2OTU2XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMTgw
MDcwIA0KWyAgICAxLjUzNjk1OF0geDI1OiBmZmZmZmUxZmZkZTBmODAwIHgyNDogZmZmZjgwMDAx
MjE4MDAwMCANClsgICAgMS41MzY5NjBdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4
MDAwMTBmZjkwMDAgDQpbICAgIDEuNTM2OTYyXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBm
ZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjUzNjk2NV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgx
ODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41MzY5NjddIHgxNzogMDAwMDAwMDAwMDAwMDAw
MCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTM2OTY5XSB4MTU6IGZmZmY4MDAwMTE2
ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjUzNjk3MV0geDEzOiBmZmZmODAw
MDExNmQ0Y2Y1IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41MzY5NzJdIHgxMTogMDAw
MDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTM2OTc0XSB4OSA6
IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDMwMzA2MzMyMzAzMDMxIA0KWyAgICAxLjUzNjk3Nl0g
eDcgOiAzMDMwMzEzMDMwMzAzMDc4IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41MzY5
NzhdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEu
NTM2OTgwXSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAg
ICAxLjUzNjk4Ml0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCAN
ClsgICAgMS41MzY5ODRdIENhbGwgdHJhY2U6DQpbICAgIDEuNTM2OTg2XSAgaXRzX2NwdV9pbml0
KzB4ODI0LzB4YjIwDQpbICAgIDEuNTM2OTg5XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTAN
ClsgICAgMS41MzY5OTFdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAx
LjUzNjk5M10gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTM2OTk1XSAg
c2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTM2OTk3XSAtLS1bIGVu
ZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjVlIF0tLS0NClsgICAgMS41MzcwMDJdIEdJQ3YzOiBDUFUx
MjogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDAzZTAwMDAN
ClsgICAgMS41MzcwNjldIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9y
IEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41MzcwNzhdIFhlbjogaW5pdGlhbGl6aW5nIGNw
dTEyDQpbICAgIDEuNTM3MTAxXSBDUFUxMjogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgw
MDAwMDAwMDBjIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjUzNzM0OV0gRGV0ZWN0ZWQgUElQVCBJLWNh
Y2hlIG9uIENQVTEzDQpbICAgIDEuNTM3Mzk1XSBHSUN2MzogQ1BVMTM6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgZCByZWdpb24gMDoweDAwMDAxMDAxMDAyZTAwMDANClsgICAgMS41NDQwMTVdIC0tLS0t
LS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjU0NDAyMF0gV0FSTklORzog
Q1BVOiAxMyBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBp
dHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NDQwMjFdIE1vZHVsZXMgbGlua2VkIGlu
Og0KWyAgICAxLjU0NDAyNV0gQ1BVOiAxMyBQSUQ6IDAgQ29tbTogc3dhcHBlci8xMyBUYWludGVk
OiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAg
ICAxLjU0NDAyN10gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJU
WVBFPS0tKQ0KWyAgICAxLjU0NDAyOV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS41NDQwMzBdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTQ0MDMx
XSBzcCA6IGZmZmY4MDAwMTFhOWJlODANClsgICAgMS41NDQwMzJdIHgyOTogZmZmZjgwMDAxMWE5
YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMGQgDQpbICAgIDEuNTQ0MDM1XSB4Mjc6IDAwMDAwMDAw
MDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMWEwMDcwIA0KWyAgICAxLjU0NDAzN10geDI1OiBmZmZm
ZmUxZmZkZTBmYzAwIHgyNDogZmZmZjgwMDAxMjFhMDAwMCANClsgICAgMS41NDQwMzldIHgyMzog
ZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTQ0MDQxXSB4
MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjU0NDA0
M10geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41
NDQwNDVdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAg
IDEuNTQ0MDQ2XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0K
WyAgICAxLjU0NDA0OF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y1IHgxMjogMDAwMDAwMDAwMDAwMDAw
MCANClsgICAgMS41NDQwNTBdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAw
MDAwMDEgDQpbICAgIDEuNTQ0MDUyXSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDMwMzA2
NTMyMzAzMDMxIA0KWyAgICAxLjU0NDA1NF0geDcgOiAzMDMwMzEzMDMwMzAzMDc4IHg2IDogMDAw
MDAwMDAwMDAwMDAwMyANClsgICAgMS41NDQwNTZdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6
IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTQ0MDU4XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAg
eDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjU0NDA2MF0geDEgOiAwMDAwMDAwMDAwMDEw
MDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41NDQwNjJdIENhbGwgdHJhY2U6DQpb
ICAgIDEuNTQ0MDY0XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTQ0MDY3XSAg
Z2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41NDQwNjldICBjcHVocF9pbnZva2Vf
Y2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU0NDA3MV0gIG5vdGlmeV9jcHVfc3RhcnRpbmcr
MHhhMC8weGUwDQpbICAgIDEuNTQ0MDc0XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4
MTkwDQpbICAgIDEuNTQ0MDc1XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjVmIF0tLS0N
ClsgICAgMS41NDQwODFdIEdJQ3YzOiBDUFUxMzogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5n
IHRhYmxlIEAweDAwMDAwODAwMDAzZjAwMDANClsgICAgMS41NDQxNDFdIGFyY2hfdGltZXI6IEVu
YWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41
NDQxNTBdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTEzDQpbICAgIDEuNTQ0MTcxXSBDUFUxMzogQm9v
dGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDBkIFsweDQxM2ZkMGMxXQ0KWyAgICAx
LjU0NDUxNl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE0DQpbICAgIDEuNTQ0NTY1XSBH
SUN2MzogQ1BVMTQ6IGZvdW5kIHJlZGlzdHJpYnV0b3IgZSByZWdpb24gMDoweDAwMDAxMDAxMDAz
MDAwMDANClsgICAgMS41NTExODVdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0t
LQ0KWyAgICAxLjU1MTE5MF0gV0FSTklORzogQ1BVOiAxNCBQSUQ6IDAgYXQgZHJpdmVycy9pcnFj
aGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS41NTExOTFdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjU1MTE5NV0gQ1BVOiAxNCBQSUQ6
IDAgQ29tbTogc3dhcHBlci8xNCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1h
bXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjU1MTE5N10gcHN0YXRlOiA2MDAwMDFjNSAo
blpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjU1MTE5OV0gcGMgOiBp
dHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NTEyMDBdIGxyIDogaXRzX2NwdV9pbml0
KzB4ODIwLzB4YjIwDQpbICAgIDEuNTUxMjAxXSBzcCA6IGZmZmY4MDAwMTFhYTNlODANClsgICAg
MS41NTEyMDJdIHgyOTogZmZmZjgwMDAxMWFhM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMGUgDQpb
ICAgIDEuNTUxMjA1XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMWMwMDcw
IA0KWyAgICAxLjU1MTIwN10geDI1OiBmZmZmZmUxZmZkZWEwMDAwIHgyNDogZmZmZjgwMDAxMjFj
MDAwMCANClsgICAgMS41NTEyMDhdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAw
MTBmZjkwMDAgDQpbICAgIDEuNTUxMjEwXSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZm
ODAwMDExNjIyMzUwIA0KWyAgICAxLjU1MTIxMl0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODog
ZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41NTEyMTRdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4
MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTUxMjE2XSB4MTU6IGZmZmY4MDAwMTE2ZDUw
YTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjU1MTIxOF0geDEzOiBmZmZmODAwMDEx
NmQ0Y2Y1IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41NTEyMjBdIHgxMTogMDAwMDAw
MDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTUxMjIyXSB4OSA6IGZm
ZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDMwMzAzMDMzMzAzMDMxIA0KWyAgICAxLjU1MTIyNF0geDcg
OiAzMDMwMzEzMDMwMzAzMDc4IHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41NTEyMjZd
IHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTUx
MjI4XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAx
LjU1MTIzMF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsg
ICAgMS41NTEyMzJdIENhbGwgdHJhY2U6DQpbICAgIDEuNTUxMjM0XSAgaXRzX2NwdV9pbml0KzB4
ODI0LzB4YjIwDQpbICAgIDEuNTUxMjM2XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsg
ICAgMS41NTEyMzldICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU1
MTI0MV0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTUxMjQ0XSAgc2Vj
b25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTUxMjQ1XSAtLS1bIGVuZCB0
cmFjZSBmNjg3MjhhMGQzMDUzYjYwIF0tLS0NClsgICAgMS41NTEyNTFdIEdJQ3YzOiBDUFUxNDog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4MDAwMDANClsg
ICAgMS41NTEzMTddIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41NTEzMjVdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTE0
DQpbICAgIDEuNTUxMzQ4XSBDUFUxNDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAw
MDAwMDBlIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjU1MTcwMl0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hl
IG9uIENQVTE1DQpbICAgIDEuNTUxNzUxXSBHSUN2MzogQ1BVMTU6IGZvdW5kIHJlZGlzdHJpYnV0
b3IgZiByZWdpb24gMDoweDAwMDAxMDAxMDAzMjAwMDANClsgICAgMS41NTgzNzFdIC0tLS0tLS0t
LS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjU1ODM3Nl0gV0FSTklORzogQ1BV
OiAxNSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNf
Y3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41NTgzNzddIE1vZHVsZXMgbGlua2VkIGluOg0K
WyAgICAxLjU1ODM4MV0gQ1BVOiAxNSBQSUQ6IDAgQ29tbTogc3dhcHBlci8xNSBUYWludGVkOiBH
ICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAx
LjU1ODM4M10gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBF
PS0tKQ0KWyAgICAxLjU1ODM4NV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS41NTgzODZdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNTU4Mzg3XSBz
cCA6IGZmZmY4MDAwMTFhYWJlODANClsgICAgMS41NTgzODhdIHgyOTogZmZmZjgwMDAxMWFhYmU4
MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMGYgDQpbICAgIDEuNTU4MzkwXSB4Mjc6IDAwMDAwMDAwMDAw
MDAwMDAgeDI2OiBmZmZmODAwMDEyMWUwMDcwIA0KWyAgICAxLjU1ODM5Ml0geDI1OiBmZmZmZmUx
ZmZkZWEwNDAwIHgyNDogZmZmZjgwMDAxMjFlMDAwMCANClsgICAgMS41NTgzOTRdIHgyMzogZmZm
ZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNTU4Mzk2XSB4MjE6
IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjU1ODM5OF0g
eDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41NTg0
MDBdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEu
NTU4NDAyXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAg
ICAxLjU1ODQwNF0geDEzOiBmZmZmODAwMDExNmQ0Y2Y1IHgxMjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS41NTg0MDZdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAw
MDEgDQpbICAgIDEuNTU4NDA4XSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDMwMzAzMjMz
MzAzMDMxIA0KWyAgICAxLjU1ODQxMF0geDcgOiAzMDMwMzEzMDMwMzAzMDc4IHg2IDogMDAwMDAw
MDAwMDAwMDAwMyANClsgICAgMS41NTg0MTJdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZm
ZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTU4NDE0XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIg
OiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjU1ODQxNV0geDEgOiAwMDAwMDAwMDAwMDEwMDAw
IHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS41NTg0MTddIENhbGwgdHJhY2U6DQpbICAg
IDEuNTU4NDE5XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTU4NDIyXSAgZ2lj
X3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS41NTg0MjVdICBjcHVocF9pbnZva2VfY2Fs
bGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU1ODQyN10gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhh
MC8weGUwDQpbICAgIDEuNTU4NDMwXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkw
DQpbICAgIDEuNTU4NDMxXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjYxIF0tLS0NClsg
ICAgMS41NTg0MzddIEdJQ3YzOiBDUFUxNTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRh
YmxlIEAweDAwMDAwODAwMDI4MTAwMDANClsgICAgMS41NTg0OTZdIGFyY2hfdGltZXI6IEVuYWJs
aW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41NTg1
MDRdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTE1DQpbICAgIDEuNTU4NTI3XSBDUFUxNTogQm9vdGVk
IHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDBmIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjU1
ODg2OV0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTE2DQpbICAgIDEuNTU4OTIxXSBHSUN2
MzogQ1BVMTY6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTAwIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDM0
MDAwMA0KWyAgICAxLjU2NTU0Ml0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0t
DQpbICAgIDEuNTY1NTQ3XSBXQVJOSU5HOiBDUFU6IDE2IFBJRDogMCBhdCBkcml2ZXJzL2lycWNo
aXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAx
LjU2NTU0OF0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNTY1NTUyXSBDUFU6IDE2IFBJRDog
MCBDb21tOiBzd2FwcGVyLzE2IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFt
cGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNTY1NTU0XSBwc3RhdGU6IDYwMDAwMWM1IChu
WkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNTY1NTU1XSBwYyA6IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU2NTU1N10gbHIgOiBpdHNfY3B1X2luaXQr
MHg4MjAvMHhiMjANClsgICAgMS41NjU1NThdIHNwIDogZmZmZjgwMDAxMWFiM2U4MA0KWyAgICAx
LjU2NTU1OV0geDI5OiBmZmZmODAwMDExYWIzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxMCANClsg
ICAgMS41NjU1NjFdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIyMDAwNzAg
DQpbICAgIDEuNTY1NTYzXSB4MjU6IGZmZmZmZTFmZmRlYTA4MDAgeDI0OiBmZmZmODAwMDEyMjAw
MDAwIA0KWyAgICAxLjU2NTU2NV0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAx
MGZmOTAwMCANClsgICAgMS41NjU1NjddIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4
MDAwMTE2MjIzNTAgDQpbICAgIDEuNTY1NTY5XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBm
ZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjU2NTU3MV0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgx
NjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41NjU1NzNdIHgxNTogZmZmZjgwMDAxMTZkNTBh
MCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNTY1NTc1XSB4MTM6IGZmZmY4MDAwMTE2
ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU2NTU3N10geDExOiAwMDAwMDAw
MDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS41NjU1NzldIHg5IDogZmZm
ZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzQzMzMwMzAzMTMwMzAgDQpbICAgIDEuNTY1NTgxXSB4NyA6
IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjU2NTU4Ml0g
eDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41NjU1
ODRdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEu
NTY1NTg2XSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAg
ICAxLjU2NTU4OF0gQ2FsbCB0cmFjZToNClsgICAgMS41NjU1OTBdICBpdHNfY3B1X2luaXQrMHg4
MjQvMHhiMjANClsgICAgMS41NjU1OTNdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAg
ICAxLjU2NTU5NV0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTY1
NTk3XSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS41NjU2MDBdICBzZWNv
bmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS41NjU2MDFdIC0tLVsgZW5kIHRy
YWNlIGY2ODcyOGEwZDMwNTNiNjIgXS0tLQ0KWyAgICAxLjU2NTYwN10gR0lDdjM6IENQVTE2OiB1
c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjgyMDAwMA0KWyAg
ICAxLjU2NTY3Ml0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJN
IGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjU2NTY4MV0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTYN
ClsgICAgMS41NjU3MDVdIENQVTE2OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAw
MDAxMDAgWzB4NDEzZmQwYzFdDQpbICAgIDEuNTY1OTUyXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUg
b24gQ1BVMTcNClsgICAgMS41NjYwMDVdIEdJQ3YzOiBDUFUxNzogZm91bmQgcmVkaXN0cmlidXRv
ciAxMDEgcmVnaW9uIDA6MHgwMDAwMTAwMTAwMzYwMDAwDQpbICAgIDEuNTcyNjI1XSAtLS0tLS0t
LS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS41NzI2MzBdIFdBUk5JTkc6IENQ
VTogMTcgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRz
X2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTcyNjMxXSBNb2R1bGVzIGxpbmtlZCBpbjoN
ClsgICAgMS41NzI2MzVdIENQVTogMTcgUElEOiAwIENvbW06IHN3YXBwZXIvMTcgVGFpbnRlZDog
RyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAg
MS41NzI2MzddIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQ
RT0tLSkNClsgICAgMS41NzI2MzldIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAg
IDEuNTcyNjQxXSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjU3MjY0Ml0g
c3AgOiBmZmZmODAwMDExYWJiZTgwDQpbICAgIDEuNTcyNjQzXSB4Mjk6IGZmZmY4MDAwMTFhYmJl
ODAgeDI4OiAwMDAwMDAwMDAwMDAwMDExIA0KWyAgICAxLjU3MjY0NV0geDI3OiAwMDAwMDAwMDAw
MDAwMDAwIHgyNjogZmZmZjgwMDAxMjIyMDA3MCANClsgICAgMS41NzI2NDddIHgyNTogZmZmZmZl
MWZmZGVhMGMwMCB4MjQ6IGZmZmY4MDAwMTIyMjAwMDAgDQpbICAgIDEuNTcyNjQ5XSB4MjM6IGZm
ZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjU3MjY1MV0geDIx
OiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS41NzI2NTNd
IHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTcy
NjU1XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAx
LjU3MjY1N10geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsg
ICAgMS41NzI2NThdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAg
DQpbICAgIDEuNTcyNjYwXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAw
MDAxIA0KWyAgICAxLjU3MjY2Ml0geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzNjMzMzAz
MDMxMzAzMCANClsgICAgMS41NzI2NjRdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAw
MDAwMDAwMDAwMDMgDQpbICAgIDEuNTcyNjY2XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBm
ZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjU3MjY2OF0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgy
IDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS41NzI2NzBdIHgxIDogMDAwMDAwMDAwMDAxMDAw
MCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNTcyNjcyXSBDYWxsIHRyYWNlOg0KWyAg
ICAxLjU3MjY3NF0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU3MjY3N10gIGdp
Y19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNTcyNjc5XSAgY3B1aHBfaW52b2tlX2Nh
bGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41NzI2ODFdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4
YTAvMHhlMA0KWyAgICAxLjU3MjY4NF0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5
MA0KWyAgICAxLjU3MjY4NV0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2MyBdLS0tDQpb
ICAgIDEuNTcyNjkxXSBHSUN2MzogQ1BVMTc6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0
YWJsZSBAMHgwMDAwMDgwMDAyODMwMDAwDQpbICAgIDEuNTcyNzUxXSBhcmNoX3RpbWVyOiBFbmFi
bGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTcy
NzYwXSBYZW46IGluaXRpYWxpemluZyBjcHUxNw0KWyAgICAxLjU3Mjc4Ml0gQ1BVMTc6IEJvb3Rl
ZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwMSBbMHg0MTNmZDBjMV0NClsgICAgMS41
NzMxMzRdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUxOA0KWyAgICAxLjU3MzE5MV0gR0lD
djM6IENQVTE4OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwMiByZWdpb24gMDoweDAwMDAxMDAxMDAz
ODAwMDANClsgICAgMS41Nzk4MTJdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0t
LQ0KWyAgICAxLjU3OTgxNl0gV0FSTklORzogQ1BVOiAxOCBQSUQ6IDAgYXQgZHJpdmVycy9pcnFj
aGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAg
MS41Nzk4MTddIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjU3OTgyMV0gQ1BVOiAxOCBQSUQ6
IDAgQ29tbTogc3dhcHBlci8xOCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1h
bXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjU3OTgyNF0gcHN0YXRlOiA2MDAwMDFjNSAo
blpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjU3OTgyNV0gcGMgOiBp
dHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41Nzk4MjddIGxyIDogaXRzX2NwdV9pbml0
KzB4ODIwLzB4YjIwDQpbICAgIDEuNTc5ODI4XSBzcCA6IGZmZmY4MDAwMTFhYzNlODANClsgICAg
MS41Nzk4MjldIHgyOTogZmZmZjgwMDAxMWFjM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTIgDQpb
ICAgIDEuNTc5ODMxXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMjQwMDcw
IA0KWyAgICAxLjU3OTgzM10geDI1OiBmZmZmZmUxZmZkZWExMDAwIHgyNDogZmZmZjgwMDAxMjI0
MDAwMCANClsgICAgMS41Nzk4MzVdIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAw
MTBmZjkwMDAgDQpbICAgIDEuNTc5ODM3XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZm
ODAwMDExNjIyMzUwIA0KWyAgICAxLjU3OTgzOV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODog
ZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS41Nzk4NDFdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4
MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTc5ODQzXSB4MTU6IGZmZmY4MDAwMTE2ZDUw
YTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjU3OTg0NV0geDEzOiBmZmZmODAwMDEx
NmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS41Nzk4NDddIHgxMTogMDAwMDAw
MDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNTc5ODQ5XSB4OSA6IGZm
ZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDM4MzMzMDMwMzEzMDMwIA0KWyAgICAxLjU3OTg1MV0geDcg
OiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS41Nzk4NTJd
IHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNTc5
ODU1XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAx
LjU3OTg1N10geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsg
ICAgMS41Nzk4NTldIENhbGwgdHJhY2U6DQpbICAgIDEuNTc5ODYwXSAgaXRzX2NwdV9pbml0KzB4
ODI0LzB4YjIwDQpbICAgIDEuNTc5ODY0XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsg
ICAgMS41Nzk4NjZdICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjU3
OTg2OF0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNTc5ODcwXSAgc2Vj
b25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNTc5ODcyXSAtLS1bIGVuZCB0
cmFjZSBmNjg3MjhhMGQzMDUzYjY0IF0tLS0NClsgICAgMS41Nzk4NzhdIEdJQ3YzOiBDUFUxODog
dXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4NDAwMDANClsg
ICAgMS41Nzk5NDNdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFS
TSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS41Nzk5NTFdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTE4
DQpbICAgIDEuNTc5OTc2XSBDUFUxODogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAw
MDAwMTAyIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjU4MDMxN10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hl
IG9uIENQVTE5DQpbICAgIDEuNTgwMzc1XSBHSUN2MzogQ1BVMTk6IGZvdW5kIHJlZGlzdHJpYnV0
b3IgMTAzIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDNhMDAwMA0KWyAgICAxLjU4Njk5Nl0gLS0tLS0t
LS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNTg3MDAxXSBXQVJOSU5HOiBD
UFU6IDE5IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0
c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjU4NzAwMV0gTW9kdWxlcyBsaW5rZWQgaW46
DQpbICAgIDEuNTg3MDA1XSBDUFU6IDE5IFBJRDogMCBDb21tOiBzd2FwcGVyLzE5IFRhaW50ZWQ6
IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAg
IDEuNTg3MDA4XSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZ
UEU9LS0pDQpbICAgIDEuNTg3MDA5XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAg
ICAxLjU4NzAxMV0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS41ODcwMTJd
IHNwIDogZmZmZjgwMDAxMWFjYmU4MA0KWyAgICAxLjU4NzAxM10geDI5OiBmZmZmODAwMDExYWNi
ZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxMyANClsgICAgMS41ODcwMTVdIHgyNzogMDAwMDAwMDAw
MDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIyNjAwNzAgDQpbICAgIDEuNTg3MDE3XSB4MjU6IGZmZmZm
ZTFmZmRlYTE0MDAgeDI0OiBmZmZmODAwMDEyMjYwMDAwIA0KWyAgICAxLjU4NzAxOV0geDIzOiBm
ZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS41ODcwMjFdIHgy
MTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNTg3MDIz
XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjU4
NzAyNV0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAg
MS41ODcwMjddIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpb
ICAgIDEuNTg3MDI4XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAw
IA0KWyAgICAxLjU4NzAzMF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAw
MDAwMSANClsgICAgMS41ODcwMzJdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwNjEzMzMw
MzAzMTMwMzAgDQpbICAgIDEuNTg3MDM0XSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAw
MDAwMDAwMDAwMDAzIA0KWyAgICAxLjU4NzAzNl0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDog
ZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS41ODcwMzhdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4
MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNTg3MDQwXSB4MSA6IDAwMDAwMDAwMDAwMTAw
MDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjU4NzA0Ml0gQ2FsbCB0cmFjZToNClsg
ICAgMS41ODcwNDRdICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS41ODcwNDZdICBn
aWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjU4NzA0OV0gIGNwdWhwX2ludm9rZV9j
YWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNTg3MDUxXSAgbm90aWZ5X2NwdV9zdGFydGluZysw
eGEwLzB4ZTANClsgICAgMS41ODcwNTRdICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgx
OTANClsgICAgMS41ODcwNTVdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNjUgXS0tLQ0K
WyAgICAxLjU4NzA2MV0gR0lDdjM6IENQVTE5OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcg
dGFibGUgQDB4MDAwMDA4MDAwMjg1MDAwMA0KWyAgICAxLjU4NzEyMF0gYXJjaF90aW1lcjogRW5h
YmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjU4
NzEyOF0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTkNClsgICAgMS41ODcxNTBdIENQVTE5OiBCb290
ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMDMgWzB4NDEzZmQwYzFdDQpbICAgIDEu
NTg3NTA3XSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjANClsgICAgMS41ODc1NjhdIEdJ
Q3YzOiBDUFUyMDogZm91bmQgcmVkaXN0cmlidXRvciAxMDQgcmVnaW9uIDA6MHgwMDAwMTAwMTAw
M2MwMDAwDQpbICAgIDEuNTk0MTg5XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0t
LS0NClsgICAgMS41OTQxOTNdIFdBUk5JTkc6IENQVTogMjAgUElEOiAwIGF0IGRyaXZlcnMvaXJx
Y2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAg
IDEuNTk0MTk0XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS41OTQxOThdIENQVTogMjAgUElE
OiAwIENvbW06IHN3YXBwZXIvMjAgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjct
YW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS41OTQyMDBdIHBzdGF0ZTogNjAwMDAxYzUg
KG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS41OTQyMDFdIHBjIDog
aXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNTk0MjAzXSBsciA6IGl0c19jcHVfaW5p
dCsweDgyMC8weGIyMA0KWyAgICAxLjU5NDIwNF0gc3AgOiBmZmZmODAwMDExYWQzZTgwDQpbICAg
IDEuNTk0MjA1XSB4Mjk6IGZmZmY4MDAwMTFhZDNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDE0IA0K
WyAgICAxLjU5NDIwN10geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjI4MDA3
MCANClsgICAgMS41OTQyMTBdIHgyNTogZmZmZmZlMWZmZGVhMTgwMCB4MjQ6IGZmZmY4MDAwMTIy
ODAwMDAgDQpbICAgIDEuNTk0MjEyXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAw
MDEwZmY5MDAwIA0KWyAgICAxLjU5NDIxM10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZm
ZjgwMDAxMTYyMjM1MCANClsgICAgMS41OTQyMTZdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6
IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNTk0MjE3XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAg
eDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjU5NDIxOV0geDE1OiBmZmZmODAwMDExNmQ1
MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS41OTQyMjFdIHgxMzogZmZmZjgwMDAx
MTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNTk0MjIzXSB4MTE6IDAwMDAw
MDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjU5NDIyNV0geDkgOiBm
ZmZmODAwMDEwNmQ2ODMwIHg4IDogMzA2MzMzMzAzMDMxMzAzMCANClsgICAgMS41OTQyMjddIHg3
IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNTk0MjI5
XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjU5
NDIzMV0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAg
MS41OTQyMzNdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpb
ICAgIDEuNTk0MjM1XSBDYWxsIHRyYWNlOg0KWyAgICAxLjU5NDIzN10gIGl0c19jcHVfaW5pdCsw
eDgyNC8weGIyMA0KWyAgICAxLjU5NDI0MF0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpb
ICAgIDEuNTk0MjQzXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS41
OTQyNDVdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjU5NDI0N10gIHNl
Y29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjU5NDI0OF0gLS0tWyBlbmQg
dHJhY2UgZjY4NzI4YTBkMzA1M2I2NiBdLS0tDQpbICAgIDEuNTk0MjU1XSBHSUN2MzogQ1BVMjA6
IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyODYwMDAwDQpb
ICAgIDEuNTk0MzIwXSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBB
Uk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNTk0MzI5XSBYZW46IGluaXRpYWxpemluZyBjcHUy
MA0KWyAgICAxLjU5NDM1NF0gQ1BVMjA6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAw
MDAwMDEwNCBbMHg0MTNmZDBjMV0NClsgICAgMS41OTQ3MDJdIERldGVjdGVkIFBJUFQgSS1jYWNo
ZSBvbiBDUFUyMQ0KWyAgICAxLjU5NDc2NV0gR0lDdjM6IENQVTIxOiBmb3VuZCByZWRpc3RyaWJ1
dG9yIDEwNSByZWdpb24gMDoweDAwMDAxMDAxMDAzZTAwMDANClsgICAgMS42MDEzODVdIC0tLS0t
LS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjYwMTM5MF0gV0FSTklORzog
Q1BVOiAyMSBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBp
dHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MDEzOTFdIE1vZHVsZXMgbGlua2VkIGlu
Og0KWyAgICAxLjYwMTM5NV0gQ1BVOiAyMSBQSUQ6IDAgQ29tbTogc3dhcHBlci8yMSBUYWludGVk
OiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAg
ICAxLjYwMTM5N10gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJU
WVBFPS0tKQ0KWyAgICAxLjYwMTM5OV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS42MDE0MDBdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjAxNDAx
XSBzcCA6IGZmZmY4MDAwMTFhZGJlODANClsgICAgMS42MDE0MDJdIHgyOTogZmZmZjgwMDAxMWFk
YmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTUgDQpbICAgIDEuNjAxNDA0XSB4Mjc6IDAwMDAwMDAw
MDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMmEwMDcwIA0KWyAgICAxLjYwMTQwNl0geDI1OiBmZmZm
ZmUxZmZkZWExYzAwIHgyNDogZmZmZjgwMDAxMjJhMDAwMCANClsgICAgMS42MDE0MDhdIHgyMzog
ZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNjAxNDEwXSB4
MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjYwMTQx
Ml0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS42
MDE0MTVdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAg
IDEuNjAxNDE3XSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0K
WyAgICAxLjYwMTQxOV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAw
MCANClsgICAgMS42MDE0MjFdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAw
MDAwMDEgDQpbICAgIDEuNjAxNDIyXSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDY1MzMz
MDMwMzEzMDMwIA0KWyAgICAxLjYwMTQyNF0geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAw
MDAwMDAwMDAwMDAwMyANClsgICAgMS42MDE0MjZdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6
IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNjAxNDI4XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAg
eDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjYwMTQzMF0geDEgOiAwMDAwMDAwMDAwMDEw
MDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS42MDE0MzJdIENhbGwgdHJhY2U6DQpb
ICAgIDEuNjAxNDM0XSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjAxNDM3XSAg
Z2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS42MDE0MzldICBjcHVocF9pbnZva2Vf
Y2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjYwMTQ0MV0gIG5vdGlmeV9jcHVfc3RhcnRpbmcr
MHhhMC8weGUwDQpbICAgIDEuNjAxNDQ0XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4
MTkwDQpbICAgIDEuNjAxNDQ2XSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjY3IF0tLS0N
ClsgICAgMS42MDE0NTJdIEdJQ3YzOiBDUFUyMTogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5n
IHRhYmxlIEAweDAwMDAwODAwMDI4NzAwMDANClsgICAgMS42MDE1MTJdIGFyY2hfdGltZXI6IEVu
YWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS42
MDE1MjFdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTIxDQpbICAgIDEuNjAxNTQzXSBDUFUyMTogQm9v
dGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTA1IFsweDQxM2ZkMGMxXQ0KWyAgICAx
LjYwMTgwMF0gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTIyDQpbICAgIDEuNjAxODY1XSBH
SUN2MzogQ1BVMjI6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTA2IHJlZ2lvbiAwOjB4MDAwMDEwMDEw
MDQwMDAwMA0KWyAgICAxLjYwODQ4N10gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0t
LS0tDQpbICAgIDEuNjA4NDkxXSBXQVJOSU5HOiBDUFU6IDIyIFBJRDogMCBhdCBkcml2ZXJzL2ly
cWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAg
ICAxLjYwODQ5Ml0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNjA4NDk2XSBDUFU6IDIyIFBJ
RDogMCBDb21tOiBzd2FwcGVyLzIyIFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3
LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNjA4NDk4XSBwc3RhdGU6IDYwMDAwMWM1
IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNjA4NTAwXSBwYyA6
IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYwODUwMl0gbHIgOiBpdHNfY3B1X2lu
aXQrMHg4MjAvMHhiMjANClsgICAgMS42MDg1MDNdIHNwIDogZmZmZjgwMDAxMWFlM2U4MA0KWyAg
ICAxLjYwODUwNF0geDI5OiBmZmZmODAwMDExYWUzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxNiAN
ClsgICAgMS42MDg1MDZdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIyYzAw
NzAgDQpbICAgIDEuNjA4NTA4XSB4MjU6IGZmZmZmZTFmZmRlYTIwMDAgeDI0OiBmZmZmODAwMDEy
MmMwMDAwIA0KWyAgICAxLjYwODUxMF0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgw
MDAxMGZmOTAwMCANClsgICAgMS42MDg1MTJdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZm
ZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNjA4NTE0XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4
OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjYwODUxNl0geDE3OiAwMDAwMDAwMDAwMDAwMDAw
IHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42MDg1MThdIHgxNTogZmZmZjgwMDAxMTZk
NTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNjA4NTIwXSB4MTM6IGZmZmY4MDAw
MTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYwODUyMV0geDExOiAwMDAw
MDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS42MDg1MjNdIHg5IDog
ZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzAzNDMwMzAzMTMwMzAgDQpbICAgIDEuNjA4NTI1XSB4
NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjYwODUy
N10geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS42
MDg1MjldIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAg
IDEuNjA4NTMxXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0K
WyAgICAxLjYwODUzM10gQ2FsbCB0cmFjZToNClsgICAgMS42MDg1MzVdICBpdHNfY3B1X2luaXQr
MHg4MjQvMHhiMjANClsgICAgMS42MDg1MzddICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0K
WyAgICAxLjYwODU0MF0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEu
NjA4NTQyXSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS42MDg1NDRdICBz
ZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS42MDg1NDZdIC0tLVsgZW5k
IHRyYWNlIGY2ODcyOGEwZDMwNTNiNjggXS0tLQ0KWyAgICAxLjYwODU1Ml0gR0lDdjM6IENQVTIy
OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjg4MDAwMA0K
WyAgICAxLjYwODYxOF0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3Ig
QVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjYwODYyN10gWGVuOiBpbml0aWFsaXppbmcgY3B1
MjINClsgICAgMS42MDg2NTJdIENQVTIyOiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAw
MDAwMDAxMDYgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjA4OTkzXSBEZXRlY3RlZCBQSVBUIEktY2Fj
aGUgb24gQ1BVMjMNClsgICAgMS42MDkwNTldIEdJQ3YzOiBDUFUyMzogZm91bmQgcmVkaXN0cmli
dXRvciAxMDcgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNDIwMDAwDQpbICAgIDEuNjE1NjgwXSAtLS0t
LS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS42MTU2ODVdIFdBUk5JTkc6
IENQVTogMjMgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkg
aXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjE1Njg2XSBNb2R1bGVzIGxpbmtlZCBp
bjoNClsgICAgMS42MTU2OTBdIENQVTogMjMgUElEOiAwIENvbW06IHN3YXBwZXIvMjMgVGFpbnRl
ZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsg
ICAgMS42MTU2OTNdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBC
VFlQRT0tLSkNClsgICAgMS42MTU2OTRdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpb
ICAgIDEuNjE1Njk2XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjYxNTY5
N10gc3AgOiBmZmZmODAwMDExYWViZTgwDQpbICAgIDEuNjE1Njk4XSB4Mjk6IGZmZmY4MDAwMTFh
ZWJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDE3IA0KWyAgICAxLjYxNTcwMF0geDI3OiAwMDAwMDAw
MDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjJlMDA3MCANClsgICAgMS42MTU3MDJdIHgyNTogZmZm
ZmZlMWZmZGVhMjQwMCB4MjQ6IGZmZmY4MDAwMTIyZTAwMDAgDQpbICAgIDEuNjE1NzA0XSB4MjM6
IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjYxNTcwNl0g
eDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42MTU3
MDhdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEu
NjE1NzEwXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAg
ICAxLjYxNTcxMl0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCAN
ClsgICAgMS42MTU3MTRdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAw
MDAgDQpbICAgIDEuNjE1NzE2XSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAw
MDAwMDAxIA0KWyAgICAxLjYxNTcxOF0geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzMjM0
MzAzMDMxMzAzMCANClsgICAgMS42MTU3MjBdIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAw
MDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjE1NzIyXSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQg
OiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjYxNTcyNF0geDMgOiAwMDAwMDAwMDAwMDAwMDEw
IHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42MTU3MjZdIHgxIDogMDAwMDAwMDAwMDAx
MDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNjE1NzI4XSBDYWxsIHRyYWNlOg0K
WyAgICAxLjYxNTcyOV0gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYxNTczMl0g
IGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNjE1NzM1XSAgY3B1aHBfaW52b2tl
X2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42MTU3MzhdICBub3RpZnlfY3B1X3N0YXJ0aW5n
KzB4YTAvMHhlMA0KWyAgICAxLjYxNTc0MF0gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8w
eDE5MA0KWyAgICAxLjYxNTc0MV0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2OSBdLS0t
DQpbICAgIDEuNjE1NzQ3XSBHSUN2MzogQ1BVMjM6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGlu
ZyB0YWJsZSBAMHgwMDAwMDgwMDAyODkwMDAwDQpbICAgIDEuNjE1ODEwXSBhcmNoX3RpbWVyOiBF
bmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEu
NjE1ODE5XSBYZW46IGluaXRpYWxpemluZyBjcHUyMw0KWyAgICAxLjYxNTg0MV0gQ1BVMjM6IEJv
b3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwNyBbMHg0MTNmZDBjMV0NClsgICAg
MS42MTYxODNdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUyNA0KWyAgICAxLjYxNjI1MV0g
R0lDdjM6IENQVTI0OiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwOCByZWdpb24gMDoweDAwMDAxMDAx
MDA0NDAwMDANClsgICAgMS42MjI4NzNdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0t
LS0tLQ0KWyAgICAxLjYyMjg3OF0gV0FSTklORzogQ1BVOiAyNCBQSUQ6IDAgYXQgZHJpdmVycy9p
cnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsg
ICAgMS42MjI4NzldIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjYyMjg4M10gQ1BVOiAyNCBQ
SUQ6IDAgQ29tbTogc3dhcHBlci8yNCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4y
Ny1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjYyMjg4NV0gcHN0YXRlOiA2MDAwMDFj
NSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjYyMjg4N10gcGMg
OiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MjI4ODhdIGxyIDogaXRzX2NwdV9p
bml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjIyODg5XSBzcCA6IGZmZmY4MDAwMTFhZjNlODANClsg
ICAgMS42MjI4OTBdIHgyOTogZmZmZjgwMDAxMWFmM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMTgg
DQpbICAgIDEuNjIyODkyXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMzAw
MDcwIA0KWyAgICAxLjYyMjg5NV0geDI1OiBmZmZmZmUxZmZkZWEyODAwIHgyNDogZmZmZjgwMDAx
MjMwMDAwMCANClsgICAgMS42MjI4OTddIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4
MDAwMTBmZjkwMDAgDQpbICAgIDEuNjIyODk5XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBm
ZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjYyMjkwMF0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgx
ODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS42MjI5MDJdIHgxNzogMDAwMDAwMDAwMDAwMDAw
MCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjIyOTA0XSB4MTU6IGZmZmY4MDAwMTE2
ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjYyMjkwNl0geDEzOiBmZmZmODAw
MDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42MjI5MDhdIHgxMTogMDAw
MDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjIyOTEwXSB4OSA6
IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDM0MzQzMDMwMzEzMDMwIA0KWyAgICAxLjYyMjkxMl0g
eDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS42MjI5
MTRdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEu
NjIyOTE2XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAg
ICAxLjYyMjkxN10geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCAN
ClsgICAgMS42MjI5MjBdIENhbGwgdHJhY2U6DQpbICAgIDEuNjIyOTIxXSAgaXRzX2NwdV9pbml0
KzB4ODI0LzB4YjIwDQpbICAgIDEuNjIyOTI0XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTAN
ClsgICAgMS42MjI5MjddICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAx
LjYyMjkyOV0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNjIyOTMxXSAg
c2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNjIyOTMyXSAtLS1bIGVu
ZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjZhIF0tLS0NClsgICAgMS42MjI5MzhdIEdJQ3YzOiBDUFUy
NDogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI4YTAwMDAN
ClsgICAgMS42MjMwMDRdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9y
IEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS42MjMwMTRdIFhlbjogaW5pdGlhbGl6aW5nIGNw
dTI0DQpbICAgIDEuNjIzMDM5XSBDUFUyNDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgw
MDAwMDAwMTA4IFsweDQxM2ZkMGMxXQ0KWyAgICAxLjYyMzM3N10gRGV0ZWN0ZWQgUElQVCBJLWNh
Y2hlIG9uIENQVTI1DQpbICAgIDEuNjIzNDQ3XSBHSUN2MzogQ1BVMjU6IGZvdW5kIHJlZGlzdHJp
YnV0b3IgMTA5IHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDQ2MDAwMA0KWyAgICAxLjYzMDA2OF0gLS0t
LS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNjMwMDczXSBXQVJOSU5H
OiBDUFU6IDI1IFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5
IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjYzMDA3NF0gTW9kdWxlcyBsaW5rZWQg
aW46DQpbICAgIDEuNjMwMDc4XSBDUFU6IDI1IFBJRDogMCBDb21tOiBzd2FwcGVyLzI1IFRhaW50
ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpb
ICAgIDEuNjMwMDgwXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08g
QlRZUEU9LS0pDQpbICAgIDEuNjMwMDgyXSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjYzMDA4NF0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS42MzAw
ODRdIHNwIDogZmZmZjgwMDAxMWFmYmU4MA0KWyAgICAxLjYzMDA4Nl0geDI5OiBmZmZmODAwMDEx
YWZiZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxOSANClsgICAgMS42MzAwODhdIHgyNzogMDAwMDAw
MDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIzMjAwNzAgDQpbICAgIDEuNjMwMDkwXSB4MjU6IGZm
ZmZmZTFmZmRlYTJjMDAgeDI0OiBmZmZmODAwMDEyMzIwMDAwIA0KWyAgICAxLjYzMDA5Ml0geDIz
OiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS42MzAwOTRd
IHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNjMw
MDk2XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAx
LjYzMDA5OF0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsg
ICAgMS42MzAxMDBdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAg
DQpbICAgIDEuNjMwMTAyXSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAw
MDAwIA0KWyAgICAxLjYzMDEwNF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAw
MDAwMDAwMSANClsgICAgMS42MzAxMDVdIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwMzYz
NDMwMzAzMTMwMzAgDQpbICAgIDEuNjMwMTA3XSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAw
MDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjYzMDEwOV0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0
IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS42MzAxMTFdIHgzIDogMDAwMDAwMDAwMDAwMDAx
MCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjMwMTEzXSB4MSA6IDAwMDAwMDAwMDAw
MTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjYzMDExNV0gQ2FsbCB0cmFjZToN
ClsgICAgMS42MzAxMTddICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42MzAxMjBd
ICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjYzMDEyM10gIGNwdWhwX2ludm9r
ZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjMwMTI1XSAgbm90aWZ5X2NwdV9zdGFydGlu
ZysweGEwLzB4ZTANClsgICAgMS42MzAxMjddICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgv
MHgxOTANClsgICAgMS42MzAxMjhdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNmIgXS0t
LQ0KWyAgICAxLjYzMDEzNF0gR0lDdjM6IENQVTI1OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRp
bmcgdGFibGUgQDB4MDAwMDA4MDAwMjhiMDAwMA0KWyAgICAxLjYzMDE5NF0gYXJjaF90aW1lcjog
RW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAx
LjYzMDIwMl0gWGVuOiBpbml0aWFsaXppbmcgY3B1MjUNClsgICAgMS42MzAyMjVdIENQVTI1OiBC
b290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMDkgWzB4NDEzZmQwYzFdDQpbICAg
IDEuNjMwNDgyXSBEZXRlY3RlZCBQSVBUIEktY2FjaGUgb24gQ1BVMjYNClsgICAgMS42MzA1NTVd
IEdJQ3YzOiBDUFUyNjogZm91bmQgcmVkaXN0cmlidXRvciAxMGEgcmVnaW9uIDA6MHgwMDAwMTAw
MTAwNDgwMDAwDQpbICAgIDEuNjM3MTc3XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0t
LS0tLS0NClsgICAgMS42MzcxODJdIFdBUk5JTkc6IENQVTogMjYgUElEOiAwIGF0IGRyaXZlcnMv
aXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMwNjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpb
ICAgIDEuNjM3MTgyXSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMS42MzcxODZdIENQVTogMjYg
UElEOiAwIENvbW06IHN3YXBwZXIvMjYgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAu
MjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzENClsgICAgMS42MzcxODldIHBzdGF0ZTogNjAwMDAx
YzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNClsgICAgMS42MzcxOTBdIHBj
IDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjM3MTkyXSBsciA6IGl0c19jcHVf
aW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjYzNzE5M10gc3AgOiBmZmZmODAwMDExYjAzZTgwDQpb
ICAgIDEuNjM3MTk0XSB4Mjk6IGZmZmY4MDAwMTFiMDNlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDFh
IA0KWyAgICAxLjYzNzE5N10geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjM0
MDA3MCANClsgICAgMS42MzcxOTldIHgyNTogZmZmZmZlMWZmZGVhMzAwMCB4MjQ6IGZmZmY4MDAw
MTIzNDAwMDAgDQpbICAgIDEuNjM3MjAxXSB4MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZm
ODAwMDEwZmY5MDAwIA0KWyAgICAxLjYzNzIwM10geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDog
ZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42MzcyMDVdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4
MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgIDEuNjM3MjA3XSB4MTc6IDAwMDAwMDAwMDAwMDAw
MDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjYzNzIwOV0geDE1OiBmZmZmODAwMDEx
NmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAxMCANClsgICAgMS42MzcyMTFdIHgxMzogZmZmZjgw
MDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjM3MjEzXSB4MTE6IDAw
MDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAxIA0KWyAgICAxLjYzNzIxNV0geDkg
OiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzAzODM0MzAzMDMxMzAzMCANClsgICAgMS42MzcyMTdd
IHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjM3
MjE5XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAgeDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAx
LjYzNzIyMV0geDMgOiAwMDAwMDAwMDAwMDAwMDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsg
ICAgMS42MzcyMjNdIHgxIDogMDAwMDAwMDAwMDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQg
DQpbICAgIDEuNjM3MjI1XSBDYWxsIHRyYWNlOg0KWyAgICAxLjYzNzIyN10gIGl0c19jcHVfaW5p
dCsweDgyNC8weGIyMA0KWyAgICAxLjYzNzIyOV0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkw
DQpbICAgIDEuNjM3MjMyXSAgY3B1aHBfaW52b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAg
MS42MzcyMzRdICBub3RpZnlfY3B1X3N0YXJ0aW5nKzB4YTAvMHhlMA0KWyAgICAxLjYzNzIzNl0g
IHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhlOC8weDE5MA0KWyAgICAxLjYzNzIzN10gLS0tWyBl
bmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2YyBdLS0tDQpbICAgIDEuNjM3MjQzXSBHSUN2MzogQ1BV
MjY6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVuZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyOGMwMDAw
DQpbICAgIDEuNjM3MzA5XSBhcmNoX3RpbWVyOiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZv
ciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAgIDEuNjM3MzE4XSBYZW46IGluaXRpYWxpemluZyBj
cHUyNg0KWyAgICAxLjYzNzM0Nl0gQ1BVMjY6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4
MDAwMDAwMDEwYSBbMHg0MTNmZDBjMV0NClsgICAgMS42Mzc2MDZdIERldGVjdGVkIFBJUFQgSS1j
YWNoZSBvbiBDUFUyNw0KWyAgICAxLjYzNzY3OV0gR0lDdjM6IENQVTI3OiBmb3VuZCByZWRpc3Ry
aWJ1dG9yIDEwYiByZWdpb24gMDoweDAwMDAxMDAxMDA0YTAwMDANClsgICAgMS42NDQzMDFdIC0t
LS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAxLjY0NDMwNl0gV0FSTklO
RzogQ1BVOiAyNyBQSUQ6IDAgYXQgZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2
OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NDQzMDZdIE1vZHVsZXMgbGlua2Vk
IGluOg0KWyAgICAxLjY0NDMxMF0gQ1BVOiAyNyBQSUQ6IDAgQ29tbTogc3dhcHBlci8yNyBUYWlu
dGVkOiBHICAgICAgICBXICAgICAgICAgNS4xMC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0K
WyAgICAxLjY0NDMxM10gcHN0YXRlOiA2MDAwMDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENP
IEJUWVBFPS0tKQ0KWyAgICAxLjY0NDMxNV0gcGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjAN
ClsgICAgMS42NDQzMTZdIGxyIDogaXRzX2NwdV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjQ0
MzE3XSBzcCA6IGZmZmY4MDAwMTFiMGJlODANClsgICAgMS42NDQzMThdIHgyOTogZmZmZjgwMDAx
MWIwYmU4MCB4Mjg6IDAwMDAwMDAwMDAwMDAwMWIgDQpbICAgIDEuNjQ0MzIxXSB4Mjc6IDAwMDAw
MDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEyMzYwMDcwIA0KWyAgICAxLjY0NDMyM10geDI1OiBm
ZmZmZmUxZmZkZWEzNDAwIHgyNDogZmZmZjgwMDAxMjM2MDAwMCANClsgICAgMS42NDQzMjVdIHgy
MzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZmZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNjQ0MzI3
XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIwOiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjY0
NDMyOV0geDE5OiBmZmZmODAwMDExNjIyMDAwIHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAg
MS42NDQzMzFdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpb
ICAgIDEuNjQ0MzMzXSB4MTU6IGZmZmY4MDAwMTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEw
IA0KWyAgICAxLjY0NDMzNV0geDEzOiBmZmZmODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAw
MDAwMCANClsgICAgMS42NDQzMzddIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAw
MDAwMDAwMDEgDQpbICAgIDEuNjQ0MzM5XSB4OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDYx
MzQzMDMwMzEzMDMwIA0KWyAgICAxLjY0NDM0MF0geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDog
MDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS42NDQzNDJdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4
NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAgIDEuNjQ0MzQ0XSB4MyA6IDAwMDAwMDAwMDAwMDAw
MTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0KWyAgICAxLjY0NDM0Nl0geDEgOiAwMDAwMDAwMDAw
MDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZlZCANClsgICAgMS42NDQzNDhdIENhbGwgdHJhY2U6
DQpbICAgIDEuNjQ0MzUwXSAgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjQ0MzUz
XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4OTANClsgICAgMS42NDQzNTVdICBjcHVocF9pbnZv
a2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAgICAxLjY0NDM1N10gIG5vdGlmeV9jcHVfc3RhcnRp
bmcrMHhhMC8weGUwDQpbICAgIDEuNjQ0MzYwXSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4
LzB4MTkwDQpbICAgIDEuNjQ0MzYyXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjZkIF0t
LS0NClsgICAgMS42NDQzNjhdIEdJQ3YzOiBDUFUyNzogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5k
aW5nIHRhYmxlIEAweDAwMDAwODAwMDI4ZDAwMDANClsgICAgMS42NDQ0MjddIGFyY2hfdGltZXI6
IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQgZm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAg
MS42NDQ0MzZdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTI3DQpbICAgIDEuNjQ0NDU5XSBDUFUyNzog
Qm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMTBiIFsweDQxM2ZkMGMxXQ0KWyAg
ICAxLjY0NDc4N10gRGV0ZWN0ZWQgUElQVCBJLWNhY2hlIG9uIENQVTI4DQpbICAgIDEuNjQ0ODY0
XSBHSUN2MzogQ1BVMjg6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMTBjIHJlZ2lvbiAwOjB4MDAwMDEw
MDEwMDRjMDAwMA0KWyAgICAxLjY1MTQ4N10gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0t
LS0tLS0tDQpbICAgIDEuNjUxNDkxXSBXQVJOSU5HOiBDUFU6IDI4IFBJRDogMCBhdCBkcml2ZXJz
L2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzozMDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0K
WyAgICAxLjY1MTQ5Ml0gTW9kdWxlcyBsaW5rZWQgaW46DQpbICAgIDEuNjUxNDk2XSBDUFU6IDI4
IFBJRDogMCBDb21tOiBzd2FwcGVyLzI4IFRhaW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEw
LjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMxDQpbICAgIDEuNjUxNDk4XSBwc3RhdGU6IDYwMDAw
MWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgIDEuNjUxNTAwXSBw
YyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY1MTUwMV0gbHIgOiBpdHNfY3B1
X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS42NTE1MDJdIHNwIDogZmZmZjgwMDAxMWIxM2U4MA0K
WyAgICAxLjY1MTUwM10geDI5OiBmZmZmODAwMDExYjEzZTgwIHgyODogMDAwMDAwMDAwMDAwMDAx
YyANClsgICAgMS42NTE1MDZdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIz
ODAwNzAgDQpbICAgIDEuNjUxNTA4XSB4MjU6IGZmZmZmZTFmZmRlYTM4MDAgeDI0OiBmZmZmODAw
MDEyMzgwMDAwIA0KWyAgICAxLjY1MTUxMF0geDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZm
ZjgwMDAxMGZmOTAwMCANClsgICAgMS42NTE1MTJdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6
IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEuNjUxNTEzXSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAg
eDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAgICAxLjY1MTUxNV0geDE3OiAwMDAwMDAwMDAwMDAw
MDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42NTE1MTddIHgxNTogZmZmZjgwMDAx
MTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAwMTAgDQpbICAgIDEuNjUxNTIwXSB4MTM6IGZmZmY4
MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgICAxLjY1MTUyMl0geDExOiAw
MDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMSANClsgICAgMS42NTE1MjRdIHg5
IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMwNjMzNDMwMzAzMTMwMzAgDQpbICAgIDEuNjUxNTI2
XSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjY1
MTUyOF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAg
MS42NTE1MzBdIHgzIDogMDAwMDAwMDAwMDAwMDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpb
ICAgIDEuNjUxNTMyXSB4MSA6IDAwMDAwMDAwMDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVk
IA0KWyAgICAxLjY1MTUzNF0gQ2FsbCB0cmFjZToNClsgICAgMS42NTE1MzVdICBpdHNfY3B1X2lu
aXQrMHg4MjQvMHhiMjANClsgICAgMS42NTE1MzhdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5
MA0KWyAgICAxLjY1MTU0MV0gIGNwdWhwX2ludm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAg
IDEuNjUxNTQzXSAgbm90aWZ5X2NwdV9zdGFydGluZysweGEwLzB4ZTANClsgICAgMS42NTE1NDZd
ICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4ZTgvMHgxOTANClsgICAgMS42NTE1NDddIC0tLVsg
ZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNmUgXS0tLQ0KWyAgICAxLjY1MTU1M10gR0lDdjM6IENQ
VTI4OiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBlbmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjhlMDAw
MA0KWyAgICAxLjY1MTYyMl0gYXJjaF90aW1lcjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBm
b3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAgICAxLjY1MTYzMV0gWGVuOiBpbml0aWFsaXppbmcg
Y3B1MjgNClsgICAgMS42NTE2NTldIENQVTI4OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAw
eDAwMDAwMDAxMGMgWzB4NDEzZmQwYzFdDQpbICAgIDEuNjUxOTg4XSBEZXRlY3RlZCBQSVBUIEkt
Y2FjaGUgb24gQ1BVMjkNClsgICAgMS42NTIwNjddIEdJQ3YzOiBDUFUyOTogZm91bmQgcmVkaXN0
cmlidXRvciAxMGQgcmVnaW9uIDA6MHgwMDAwMTAwMTAwNGUwMDAwDQpbICAgIDEuNjU4Njg5XSAt
LS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NClsgICAgMS42NTg2OTRdIFdBUk5J
Tkc6IENQVTogMjkgUElEOiAwIGF0IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jOjMw
NjkgaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjU4Njk1XSBNb2R1bGVzIGxpbmtl
ZCBpbjoNClsgICAgMS42NTg2OTldIENQVTogMjkgUElEOiAwIENvbW06IHN3YXBwZXIvMjkgVGFp
bnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsgIzEN
ClsgICAgMS42NTg3MDFdIHBzdGF0ZTogNjAwMDAxYzUgKG5aQ3YgZEFJRiAtUEFOIC1VQU8gLVRD
TyBCVFlQRT0tLSkNClsgICAgMS42NTg3MDJdIHBjIDogaXRzX2NwdV9pbml0KzB4ODI0LzB4YjIw
DQpbICAgIDEuNjU4NzA0XSBsciA6IGl0c19jcHVfaW5pdCsweDgyMC8weGIyMA0KWyAgICAxLjY1
ODcwNV0gc3AgOiBmZmZmODAwMDExYjFiZTgwDQpbICAgIDEuNjU4NzA2XSB4Mjk6IGZmZmY4MDAw
MTFiMWJlODAgeDI4OiAwMDAwMDAwMDAwMDAwMDFkIA0KWyAgICAxLjY1ODcwOF0geDI3OiAwMDAw
MDAwMDAwMDAwMDAwIHgyNjogZmZmZjgwMDAxMjNhMDA3MCANClsgICAgMS42NTg3MTBdIHgyNTog
ZmZmZmZlMWZmZGVhM2MwMCB4MjQ6IGZmZmY4MDAwMTIzYTAwMDAgDQpbICAgIDEuNjU4NzEyXSB4
MjM6IGZmZmY4MDAwMTE0ZGM5YzAgeDIyOiBmZmZmODAwMDEwZmY5MDAwIA0KWyAgICAxLjY1ODcx
NF0geDIxOiBmZmZmODAwMDExNzY4OWY4IHgyMDogZmZmZjgwMDAxMTYyMjM1MCANClsgICAgMS42
NTg3MTZdIHgxOTogZmZmZjgwMDAxMTYyMjAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAg
IDEuNjU4NzE3XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIA0K
WyAgICAxLjY1ODcxOV0geDE1OiBmZmZmODAwMDExNmQ1MGEwIHgxNDogMDAwMDAwMDAwMDAwMDAx
MCANClsgICAgMS42NTg3MjFdIHgxMzogZmZmZjgwMDAxMTZkNGNmNyB4MTI6IDAwMDAwMDAwMDAw
MDAwMDAgDQpbICAgIDEuNjU4NzIzXSB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAw
MDAwMDAwMDAxIA0KWyAgICAxLjY1ODcyNV0geDkgOiBmZmZmODAwMDEwNmQ2ODMwIHg4IDogMzA2
NTM0MzAzMDMxMzAzMCANClsgICAgMS42NTg3MjddIHg3IDogMzEzMDMwMzAzMDc4MzAzYSB4NiA6
IDAwMDAwMDAwMDAwMDAwMDMgDQpbICAgIDEuNjU4NzI5XSB4NSA6IDAwMDAwMDAwMDAwMDAwMDAg
eDQgOiBmZmZmZmRmZmZmZTAwMDAwIA0KWyAgICAxLjY1ODczMV0geDMgOiAwMDAwMDAwMDAwMDAw
MDEwIHgyIDogMDAwMDAwMDAwMDAwZmZmZiANClsgICAgMS42NTg3MzNdIHgxIDogMDAwMDAwMDAw
MDAxMDAwMCB4MCA6IDAwMDAwMDAwZmZmZmZmZWQgDQpbICAgIDEuNjU4NzM1XSBDYWxsIHRyYWNl
Og0KWyAgICAxLjY1ODczN10gIGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY1ODc0
MF0gIGdpY19zdGFydGluZ19jcHUrMHg0OC8weDkwDQpbICAgIDEuNjU4NzQyXSAgY3B1aHBfaW52
b2tlX2NhbGxiYWNrKzB4YTQvMHg0NjANClsgICAgMS42NTg3NDRdICBub3RpZnlfY3B1X3N0YXJ0
aW5nKzB4YTAvMHhlMA0KWyAgICAxLjY1ODc0N10gIHNlY29uZGFyeV9zdGFydF9rZXJuZWwrMHhl
OC8weDE5MA0KWyAgICAxLjY1ODc0OF0gLS0tWyBlbmQgdHJhY2UgZjY4NzI4YTBkMzA1M2I2ZiBd
LS0tDQpbICAgIDEuNjU4NzU0XSBHSUN2MzogQ1BVMjk6IHVzaW5nIGFsbG9jYXRlZCBMUEkgcGVu
ZGluZyB0YWJsZSBAMHgwMDAwMDgwMDAyOGYwMDAwDQpbICAgIDEuNjU4ODIyXSBhcmNoX3RpbWVy
OiBFbmFibGluZyBsb2NhbCB3b3JrYXJvdW5kIGZvciBBUk0gZXJyYXR1bSAxNDE4MDQwDQpbICAg
IDEuNjU4ODMxXSBYZW46IGluaXRpYWxpemluZyBjcHUyOQ0KWyAgICAxLjY1ODg1OV0gQ1BVMjk6
IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDEwZCBbMHg0MTNmZDBjMV0NClsg
ICAgMS42NTkxOTBdIERldGVjdGVkIFBJUFQgSS1jYWNoZSBvbiBDUFUzMA0KWyAgICAxLjY1OTI3
MF0gR0lDdjM6IENQVTMwOiBmb3VuZCByZWRpc3RyaWJ1dG9yIDEwZSByZWdpb24gMDoweDAwMDAx
MDAxMDA1MDAwMDANClsgICAgMS42NjU4OTJdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0t
LS0tLS0tLQ0KWyAgICAxLjY2NTg5N10gV0FSTklORzogQ1BVOiAzMCBQSUQ6IDAgYXQgZHJpdmVy
cy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmM6MzA2OSBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjAN
ClsgICAgMS42NjU4OThdIE1vZHVsZXMgbGlua2VkIGluOg0KWyAgICAxLjY2NTkwM10gQ1BVOiAz
MCBQSUQ6IDAgQ29tbTogc3dhcHBlci8zMCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgNS4x
MC4yNy1hbXBlcmUtbHRzLXN0YW5kYXJkKyAjMQ0KWyAgICAxLjY2NTkwNV0gcHN0YXRlOiA2MDAw
MDFjNSAoblpDdiBkQUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KWyAgICAxLjY2NTkwN10g
cGMgOiBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NjU5MDldIGxyIDogaXRzX2Nw
dV9pbml0KzB4ODIwLzB4YjIwDQpbICAgIDEuNjY1OTEwXSBzcCA6IGZmZmY4MDAwMTFiMjNlODAN
ClsgICAgMS42NjU5MTFdIHgyOTogZmZmZjgwMDAxMWIyM2U4MCB4Mjg6IDAwMDAwMDAwMDAwMDAw
MWUgDQpbICAgIDEuNjY1OTEzXSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAwMDEy
M2MwMDcwIA0KWyAgICAxLjY2NTkxNV0geDI1OiBmZmZmZmUxZmZkZWE0MDAwIHgyNDogZmZmZjgw
MDAxMjNjMDAwMCANClsgICAgMS42NjU5MTddIHgyMzogZmZmZjgwMDAxMTRkYzljMCB4MjI6IGZm
ZmY4MDAwMTBmZjkwMDAgDQpbICAgIDEuNjY1OTE5XSB4MjE6IGZmZmY4MDAwMTE3Njg5ZjggeDIw
OiBmZmZmODAwMDExNjIyMzUwIA0KWyAgICAxLjY2NTkyMV0geDE5OiBmZmZmODAwMDExNjIyMDAw
IHgxODogZmZmZmZmZmZmZmZmZmZmZiANClsgICAgMS42NjU5MjNdIHgxNzogMDAwMDAwMDAwMDAw
MDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAgIDEuNjY1OTI2XSB4MTU6IGZmZmY4MDAw
MTE2ZDUwYTAgeDE0OiAwMDAwMDAwMDAwMDAwMDEwIA0KWyAgICAxLjY2NTkyN10geDEzOiBmZmZm
ODAwMDExNmQ0Y2Y3IHgxMjogMDAwMDAwMDAwMDAwMDAwMCANClsgICAgMS42NjU5MjldIHgxMTog
MDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDEgDQpbICAgIDEuNjY1OTMxXSB4
OSA6IGZmZmY4MDAwMTA2ZDY4MzAgeDggOiAzMDMwMzUzMDMwMzEzMDMwIA0KWyAgICAxLjY2NTkz
M10geDcgOiAzMTMwMzAzMDMwNzgzMDNhIHg2IDogMDAwMDAwMDAwMDAwMDAwMyANClsgICAgMS42
NjU5MzVdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmZmZGZmZmZlMDAwMDAgDQpbICAg
IDEuNjY1OTM3XSB4MyA6IDAwMDAwMDAwMDAwMDAwMTAgeDIgOiAwMDAwMDAwMDAwMDBmZmZmIA0K
WyAgICAxLjY2NTk0MF0geDEgOiAwMDAwMDAwMDAwMDEwMDAwIHgwIDogMDAwMDAwMDBmZmZmZmZl
ZCANClsgICAgMS42NjU5NDJdIENhbGwgdHJhY2U6DQpbICAgIDEuNjY1OTQzXSAgaXRzX2NwdV9p
bml0KzB4ODI0LzB4YjIwDQpbICAgIDEuNjY1OTQ2XSAgZ2ljX3N0YXJ0aW5nX2NwdSsweDQ4LzB4
OTANClsgICAgMS42NjU5NDldICBjcHVocF9pbnZva2VfY2FsbGJhY2srMHhhNC8weDQ2MA0KWyAg
ICAxLjY2NTk1MV0gIG5vdGlmeV9jcHVfc3RhcnRpbmcrMHhhMC8weGUwDQpbICAgIDEuNjY1OTU0
XSAgc2Vjb25kYXJ5X3N0YXJ0X2tlcm5lbCsweGU4LzB4MTkwDQpbICAgIDEuNjY1OTU1XSAtLS1b
IGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjcwIF0tLS0NClsgICAgMS42NjU5NjFdIEdJQ3YzOiBD
UFUzMDogdXNpbmcgYWxsb2NhdGVkIExQSSBwZW5kaW5nIHRhYmxlIEAweDAwMDAwODAwMDI5MDAw
MDANClsgICAgMS42NjYwMzBdIGFyY2hfdGltZXI6IEVuYWJsaW5nIGxvY2FsIHdvcmthcm91bmQg
Zm9yIEFSTSBlcnJhdHVtIDE0MTgwNDANClsgICAgMS42NjYwMzldIFhlbjogaW5pdGlhbGl6aW5n
IGNwdTMwDQpbICAgIDEuNjY2MDY4XSBDUFUzMDogQm9vdGVkIHNlY29uZGFyeSBwcm9jZXNzb3Ig
MHgwMDAwMDAwMTBlIFsweDQxM2ZkMGMxXQ0KWyAgICAxLjY2NjMyNV0gRGV0ZWN0ZWQgUElQVCBJ
LWNhY2hlIG9uIENQVTMxDQpbICAgIDEuNjY2NDA4XSBHSUN2MzogQ1BVMzE6IGZvdW5kIHJlZGlz
dHJpYnV0b3IgMTBmIHJlZ2lvbiAwOjB4MDAwMDEwMDEwMDUyMDAwMA0KWyAgICAxLjY3MzAzMF0g
LS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQpbICAgIDEuNjczMDM1XSBXQVJO
SU5HOiBDUFU6IDMxIFBJRDogMCBhdCBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYzoz
MDY5IGl0c19jcHVfaW5pdCsweDgyNC8weGIyMA0KWyAgICAxLjY3MzAzNl0gTW9kdWxlcyBsaW5r
ZWQgaW46DQpbICAgIDEuNjczMDQwXSBDUFU6IDMxIFBJRDogMCBDb21tOiBzd2FwcGVyLzMxIFRh
aW50ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjEwLjI3LWFtcGVyZS1sdHMtc3RhbmRhcmQrICMx
DQpbICAgIDEuNjczMDQyXSBwc3RhdGU6IDYwMDAwMWM1IChuWkN2IGRBSUYgLVBBTiAtVUFPIC1U
Q08gQlRZUEU9LS0pDQpbICAgIDEuNjczMDQ0XSBwYyA6IGl0c19jcHVfaW5pdCsweDgyNC8weGIy
MA0KWyAgICAxLjY3MzA0Nl0gbHIgOiBpdHNfY3B1X2luaXQrMHg4MjAvMHhiMjANClsgICAgMS42
NzMwNDddIHNwIDogZmZmZjgwMDAxMWIyYmU4MA0KWyAgICAxLjY3MzA0OF0geDI5OiBmZmZmODAw
MDExYjJiZTgwIHgyODogMDAwMDAwMDAwMDAwMDAxZiANClsgICAgMS42NzMwNTBdIHgyNzogMDAw
MDAwMDAwMDAwMDAwMCB4MjY6IGZmZmY4MDAwMTIzZTAwNzAgDQpbICAgIDEuNjczMDUyXSB4MjU6
IGZmZmZmZTFmZmRlYTQ0MDAgeDI0OiBmZmZmODAwMDEyM2UwMDAwIA0KWyAgICAxLjY3MzA1NF0g
eDIzOiBmZmZmODAwMDExNGRjOWMwIHgyMjogZmZmZjgwMDAxMGZmOTAwMCANClsgICAgMS42NzMw
NTZdIHgyMTogZmZmZjgwMDAxMTc2ODlmOCB4MjA6IGZmZmY4MDAwMTE2MjIzNTAgDQpbICAgIDEu
NjczMDU4XSB4MTk6IGZmZmY4MDAwMTE2MjIwMDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmIA0KWyAg
ICAxLjY3MzA2MF0geDE3OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCAN
ClsgICAgMS42NzMwNjJdIHgxNTogZmZmZjgwMDAxMTZkNTBhMCB4MTQ6IDAwMDAwMDAwMDAwMDAw
MTAgDQpbICAgIDEuNjczMDY0XSB4MTM6IGZmZmY4MDAwMTE2ZDRjZjcgeDEyOiAwMDAwMDAwMDAw
MDAwMDAwIA0KWyAgICAxLjY3MzA2Nl0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAw
MDAwMDAwMDAwMSANClsgICAgMS42NzMwNjddIHg5IDogZmZmZjgwMDAxMDZkNjgzMCB4OCA6IDMw
MzIzNTMwMzAzMTMwMzAgDQpbICAgIDEuNjczMDY5XSB4NyA6IDMxMzAzMDMwMzA3ODMwM2EgeDYg
OiAwMDAwMDAwMDAwMDAwMDAzIA0KWyAgICAxLjY3MzA3MV0geDUgOiAwMDAwMDAwMDAwMDAwMDAw
IHg0IDogZmZmZmZkZmZmZmUwMDAwMCANClsgICAgMS42NzMwNzNdIHgzIDogMDAwMDAwMDAwMDAw
MDAxMCB4MiA6IDAwMDAwMDAwMDAwMGZmZmYgDQpbICAgIDEuNjczMDc1XSB4MSA6IDAwMDAwMDAw
MDAwMTAwMDAgeDAgOiAwMDAwMDAwMGZmZmZmZmVkIA0KWyAgICAxLjY3MzA3N10gQ2FsbCB0cmFj
ZToNClsgICAgMS42NzMwNzldICBpdHNfY3B1X2luaXQrMHg4MjQvMHhiMjANClsgICAgMS42NzMw
ODJdICBnaWNfc3RhcnRpbmdfY3B1KzB4NDgvMHg5MA0KWyAgICAxLjY3MzA4NV0gIGNwdWhwX2lu
dm9rZV9jYWxsYmFjaysweGE0LzB4NDYwDQpbICAgIDEuNjczMDg3XSAgbm90aWZ5X2NwdV9zdGFy
dGluZysweGEwLzB4ZTANClsgICAgMS42NzMwODldICBzZWNvbmRhcnlfc3RhcnRfa2VybmVsKzB4
ZTgvMHgxOTANClsgICAgMS42NzMwOTFdIC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNzEg
XS0tLQ0KWyAgICAxLjY3MzA5N10gR0lDdjM6IENQVTMxOiB1c2luZyBhbGxvY2F0ZWQgTFBJIHBl
bmRpbmcgdGFibGUgQDB4MDAwMDA4MDAwMjkxMDAwMA0KWyAgICAxLjY3MzE2M10gYXJjaF90aW1l
cjogRW5hYmxpbmcgbG9jYWwgd29ya2Fyb3VuZCBmb3IgQVJNIGVycmF0dW0gMTQxODA0MA0KWyAg
ICAxLjY3MzE3Ml0gWGVuOiBpbml0aWFsaXppbmcgY3B1MzENClsgICAgMS42NzMxOTldIENQVTMx
OiBCb290ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAxMGYgWzB4NDEzZmQwYzFdDQpb
ICAgIDEuNjczMjg2XSBzbXA6IEJyb3VnaHQgdXAgMSBub2RlLCAzMiBDUFVzDQpbICAgIDcuNTE4
ODQ5XSBTTVA6IFRvdGFsIG9mIDMyIHByb2Nlc3NvcnMgYWN0aXZhdGVkLg0KWyAgICA3LjUyMzY4
MV0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogUHJpdmlsZWdlZCBBY2Nlc3MgTmV2ZXINClsgICAg
Ny41MjkzMzZdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IExTRSBhdG9taWMgaW5zdHJ1Y3Rpb25z
DQpbICAgIDcuNTM0OTY1XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBVc2VyIEFjY2VzcyBPdmVy
cmlkZQ0KWyAgICA3LjU0MDM0N10gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogMzItYml0IEVMMCBT
dXBwb3J0DQpbICAgIDcuNTQ1NTYwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBDb21tb24gbm90
IFByaXZhdGUgdHJhbnNsYXRpb25zDQpbICAgIDcuNTUxODkyXSBDUFUgZmVhdHVyZXM6IGRldGVj
dGVkOiBEYXRhIGNhY2hlIGNsZWFuIHRvIHRoZSBQb1Ugbm90IHJlcXVpcmVkIGZvciBJL0QgY29o
ZXJlbmNlDQpbICAgIDcuNTYwNTcyXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBDUkMzMiBpbnN0
cnVjdGlvbnMNClsgICAgNy41NjU3ODVdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IFNwZWN1bGF0
aXZlIFN0b3JlIEJ5cGFzc2luZyBTYWZlIChTU0JTKQ0KWyAgICA3LjYwMzQ3M10gQ1BVOiBBbGwg
Q1BVKHMpIHN0YXJ0ZWQgYXQgRUwxDQpbICAgIDcuNjA3NjIwXSBhbHRlcm5hdGl2ZXM6IHBhdGNo
aW5nIGtlcm5lbCBjb2RlDQpbICAgIDcuNjEyOTU0XSBkZXZ0bXBmczogaW5pdGlhbGl6ZWQNClsg
ICAgNy42MTY0OTJdIGNsb2Nrc291cmNlOiBqaWZmaWVzOiBtYXNrOiAweGZmZmZmZmZmIG1heF9j
eWNsZXM6IDB4ZmZmZmZmZmYsIG1heF9pZGxlX25zOiA3NjQ1MDQxNzg1MTAwMDAwIG5zDQpbICAg
IDcuNjI2MTQxXSBmdXRleCBoYXNoIHRhYmxlIGVudHJpZXM6IDgxOTIgKG9yZGVyOiA3LCA1MjQy
ODggYnl0ZXMsIGxpbmVhcikNClsgICAgNy42MzMzMzZdIERNSSBub3QgcHJlc2VudCBvciBpbnZh
bGlkLg0KWyAgICA3LjYzNzMzOV0gTkVUOiBSZWdpc3RlcmVkIHByb3RvY29sIGZhbWlseSAxNg0K
WyAgICA3LjY0MjgzMl0gRE1BOiBwcmVhbGxvY2F0ZWQgMTAyNCBLaUIgR0ZQX0tFUk5FTCBwb29s
IGZvciBhdG9taWMgYWxsb2NhdGlvbnMNClsgICAgNy42NDk5MTddIERNQTogcHJlYWxsb2NhdGVk
IDEwMjQgS2lCIEdGUF9LRVJORUx8R0ZQX0RNQSBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMN
ClsgICAgNy42NTc4MDZdIERNQTogcHJlYWxsb2NhdGVkIDEwMjQgS2lCIEdGUF9LRVJORUx8R0ZQ
X0RNQTMyIHBvb2wgZm9yIGF0b21pYyBhbGxvY2F0aW9ucw0KWyAgICA3LjY2NjExNF0gdGhlcm1h
bF9zeXM6IFJlZ2lzdGVyZWQgdGhlcm1hbCBnb3Zlcm5vciAnc3RlcF93aXNlJw0KWyAgICA3LjY2
NjI0NF0gRGV0ZWN0ZWQgMTUgUENDIFN1YnNwYWNlcw0KWyAgICA3LjY3NTg5OV0gUmVnaXN0ZXJp
bmcgUENDIGRyaXZlciBhcyBNYWlsYm94IGNvbnRyb2xsZXINClsgICAgNy42ODEyOTFdIGh3LWJy
ZWFrcG9pbnQ6IGZvdW5kIDYgYnJlYWtwb2ludCBhbmQgNCB3YXRjaHBvaW50IHJlZ2lzdGVycy4N
ClsgICAgNy42ODk1MDVdIEFTSUQgYWxsb2NhdG9yIGluaXRpYWxpc2VkIHdpdGggNjU1MzYgZW50
cmllcw0KWyAgICA3LjY5NDgwOF0gQUNQSTogYnVzIHR5cGUgUENJIHJlZ2lzdGVyZWQNClsgICAg
Ny42OTg4ODJdIFNlcmlhbDogQU1CQSBQTDAxMSBVQVJUIGRyaXZlcg0KWyAgICA3LjcwNTM0OV0g
SHVnZVRMQiByZWdpc3RlcmVkIDEuMDAgR2lCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBh
Z2VzDQpbICAgIDcuNzExOTU5XSBIdWdlVExCIHJlZ2lzdGVyZWQgMzIuMCBNaUIgcGFnZSBzaXpl
LCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMNClsgICAgNy43MTg3MTldIEh1Z2VUTEIgcmVnaXN0ZXJl
ZCAyLjAwIE1pQiBwYWdlIHNpemUsIHByZS1hbGxvY2F0ZWQgMCBwYWdlcw0KWyAgICA3LjcyNTQ5
OV0gSHVnZVRMQiByZWdpc3RlcmVkIDY0LjAgS2lCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAw
IHBhZ2VzDQpbICAgIDcuNzMzNjM0XSBjcnlwdGQ6IG1heF9jcHVfcWxlbiBzZXQgdG8gMTAwMA0K
WyAgICA3LjgwNTg2MV0gcmFpZDY6IG5lb254OCAgIGdlbigpICA3NzM0IE1CL3MNClsgICAgNy44
NzgwODRdIHJhaWQ2OiBuZW9ueDggICB4b3IoKSAgNjA1OSBNQi9zDQpbICAgIDcuOTUwMzA1XSBy
YWlkNjogbmVvbng0ICAgZ2VuKCkgIDc2MjkgTUIvcw0KWyAgICA4LjAyMjUyNl0gcmFpZDY6IG5l
b254NCAgIHhvcigpICA2MzE5IE1CL3MNClsgICAgOC4wOTQ3NTFdIHJhaWQ2OiBuZW9ueDIgICBn
ZW4oKSAgNzI4NCBNQi9zDQpbICAgIDguMTY2OTczXSByYWlkNjogbmVvbngyICAgeG9yKCkgIDU3
MzIgTUIvcw0KWyAgICA4LjIzOTE5NF0gcmFpZDY6IG5lb254MSAgIGdlbigpICA1OTc2IE1CL3MN
ClsgICAgOC4zMTE0MTJdIHJhaWQ2OiBuZW9ueDEgICB4b3IoKSAgNDkyOSBNQi9zDQpbICAgIDgu
MzgzNjM2XSByYWlkNjogaW50NjR4OCAgZ2VuKCkgIDM2MDEgTUIvcw0KWyAgICA4LjQ1NTg1Nl0g
cmFpZDY6IGludDY0eDggIHhvcigpICAyMDE3IE1CL3MNClsgICAgOC41MjgyNTBdIHJhaWQ2OiBp
bnQ2NHg0ICBnZW4oKSAgNDEyNiBNQi9zDQpbICAgIDguNjAwNDcyXSByYWlkNjogaW50NjR4NCAg
eG9yKCkgIDIxOTAgTUIvcw0KWyAgICA4LjY3MjY5M10gcmFpZDY6IGludDY0eDIgIGdlbigpICAz
NTAyIE1CL3MNClsgICAgOC43NDQ5MTNdIHJhaWQ2OiBpbnQ2NHgyICB4b3IoKSAgMTg4OSBNQi9z
DQpbICAgIDguODE3MTMxXSByYWlkNjogaW50NjR4MSAgZ2VuKCkgIDI4NzQgTUIvcw0KWyAgICA4
Ljg4OTM1OF0gcmFpZDY6IGludDY0eDEgIHhvcigpICAxNDk5IE1CL3MNClsgICAgOC44OTM1Mjdd
IHJhaWQ2OiB1c2luZyBhbGdvcml0aG0gbmVvbng4IGdlbigpIDc3MzQgTUIvcw0KWyAgICA4Ljg5
OTAwMV0gcmFpZDY6IC4uLi4geG9yKCkgNjA1OSBNQi9zLCBybXcgZW5hYmxlZA0KWyAgICA4Ljkw
NDAzMV0gcmFpZDY6IHVzaW5nIG5lb24gcmVjb3ZlcnkgYWxnb3JpdGhtDQpbICAgIDguOTA4ODAx
XSBBQ1BJOiBBZGRlZCBfT1NJKE1vZHVsZSBEZXZpY2UpDQpbICAgIDguOTEyOTczXSBBQ1BJOiBB
ZGRlZCBfT1NJKFByb2Nlc3NvciBEZXZpY2UpDQpbICAgIDguOTE3NDg1XSBBQ1BJOiBBZGRlZCBf
T1NJKDMuMCBfU0NQIEV4dGVuc2lvbnMpDQpbICAgIDguOTIyMjYwXSBBQ1BJOiBBZGRlZCBfT1NJ
KFByb2Nlc3NvciBBZ2dyZWdhdG9yIERldmljZSkNClsgICAgOC45Mjc3MjldIEFDUEk6IEFkZGVk
IF9PU0koTGludXgtRGVsbC1WaWRlbykNClsgICAgOC45MzIyNDNdIEFDUEk6IEFkZGVkIF9PU0ko
TGludXgtTGVub3ZvLU5WLUhETUktQXVkaW8pDQpbICAgIDguOTM3NjI1XSBBQ1BJOiBBZGRlZCBf
T1NJKExpbnV4LUhQSS1IeWJyaWQtR3JhcGhpY3MpDQpbICAgIDguOTYzNDA0XSBBQ1BJOiAyIEFD
UEkgQU1MIHRhYmxlcyBzdWNjZXNzZnVsbHkgYWNxdWlyZWQgYW5kIGxvYWRlZA0KWyAgICA4Ljk3
NTk1MF0gQUNQSTogSW50ZXJwcmV0ZXIgZW5hYmxlZA0KWyAgICA4Ljk3OTUyMV0gQUNQSTogVXNp
bmcgR0lDIGZvciBpbnRlcnJ1cHQgcm91dGluZw0KWyAgICA4Ljk4NDI5OF0gQUNQSTogTUNGRyB0
YWJsZSBkZXRlY3RlZCwgNSBlbnRyaWVzDQpbICAgIDguOTg5MDY5XSBIRVNUOiBUYWJsZSBwYXJz
aW5nIGhhcyBiZWVuIGluaXRpYWxpemVkLg0KWyAgICA5LjA0MTU5NF0gQVJNSDAwMTE6MDA6IHR0
eUFNQTAgYXQgTU1JTyAweDEwMDAwMjYwMDAwMCAoaXJxID0gNzksIGJhc2VfYmF1ZCA9IDApIGlz
IGEgU0JTQQ0KWyAgICA5LjEzMjYwOV0gcHJpbnRrOiBjb25zb2xlIFt0dHlBTUEwXSBlbmFibGVk
DQpbICAgIDkuMTM4NjUzXSBBUk1IMDAxMTowMTogdHR5QU1BMSBhdCBNTUlPIDB4MTAwMDAyNjIw
MDAwIChpcnEgPSA4MCwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBDQpbICAgIDkuMTQ5MDIwXSBB
Q1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTBdIChkb21haW4gMDAwYyBbYnVzIDAwLWZmXSkNClsg
ICAgOS4xNTUxODddIGFjcGkgUE5QMEEwODowMDogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVk
Q29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQ0KWyAgICA5LjE2NDM4
N10gYWNwaSBQTlAwQTA4OjAwOiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1
ZXN0aW5nIF9PU0MgY29udHJvbA0KWyAgICA5LjE3MjIxMV0gYWNwaSBQTlAwQTA4OjAwOiBNQ0ZH
IHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIGZvciBb
YnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMA0KWyAgICA5LjE4NTEzMl0gYWNwaSBQ
TlAwQTA4OjAwOiBFQ0FNIGFyZWEgW21lbSAweDMzZmZmMDAwMDAwMC0weDMzZmZmZmZmZmZmZl0g
cmVzZXJ2ZWQgYnkgUE5QMEMwMjowMA0KWyAgICA5LjE5NDAxOF0gYWNwaSBQTlAwQTA4OjAwOiBF
Q0FNIGF0IFttZW0gMHgzM2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZm
XQ0KWyAgICA5LjIwMjIzN10gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDBjOjAwDQpbICAgIDku
MjA2MjgyXSBwY2lfYnVzIDAwMGM6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHg0MDAwMDAw
MC0weDRmZmZmZmZmIHdpbmRvd10NClsgICAgOS4yMTM4NzJdIHBjaV9idXMgMDAwYzowMDogcm9v
dCBidXMgcmVzb3VyY2UgW21lbSAweDMwMDAwMDAwMDAwMC0weDMzZmZkZmZmZmZmZiB3aW5kb3dd
DQpbICAgIDkuMjIyMTI2XSBwY2lfYnVzIDAwMGM6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMg
MDAtZmZdDQpbICAgIDkuMjI3Njk1XSBwY2kgMDAwYzowMDowMC4wOiBbMWRlZjplMTAwXSB0eXBl
IDAwIGNsYXNzIDB4MDYwMDAwDQpbICAgIDkuMjMzODA5XSBwY2kgMDAwYzowMDowMC4wOiBGYWls
ZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDku
MjQxNDEzXSBwY2kgMDAwYzowMDowMS4wOiBbMWRlZjplMTAxXSB0eXBlIDAxIGNsYXNzIDB4MDYw
NDAwDQpbICAgIDkuMjQ3NDk4XSBwY2kgMDAwYzowMDowMS4wOiBzdXBwb3J0cyBEMSBEMg0KWyAg
ICA5LjI1MTc2OF0gcGNpIDAwMGM6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBE
M2hvdA0KWyAgICA5LjI1NzYzOF0gcGNpIDAwMGM6MDA6MDEuMDogRmFpbGVkIHRvIGFkZCAtIHBh
c3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA5LjI2NjM3MF0gcGNpIDAw
MGM6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDFd
IGFkZF9zaXplIDEwMDANClsgICAgOS4yNzQ1NDJdIHBjaSAwMDBjOjAwOjAxLjA6IGJyaWRnZSB3
aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwMV0g
YWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAgOS4yODYxMjZdIHBjaSAwMDBj
OjAwOjAxLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmZdIHRvIFti
dXMgMDFdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgIDkuMjk2NzA5XSBw
Y2kgMDAwYzowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDQwMDAwMDAwLTB4NDAxZmZm
ZmZdDQpbICAgIDkuMzAzNTI3XSBwY2kgMDAwYzowMDowMS4wOiBCQVIgOTogYXNzaWduZWQgW21l
bSAweDMwMDAwMDAwMDAwMC0weDMwMDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjMxMjA0
M10gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAw
XQ0KWyAgICA5LjMxODM1NF0gcGNpIDAwMGM6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3Np
Z24gW2lvICBzaXplIDB4MTAwMF0NClsgICAgOS4zMjUwNDNdIHBjaSAwMDBjOjAwOjAxLjA6IEJB
UiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAgOS4zMzEzNzddIHBjaSAw
MDBjOjAwOjAxLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpb
ICAgIDkuMzM4MDY0XSBwY2kgMDAwYzowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDFdDQpb
ICAgIDkuMzQzMDgxXSBwY2kgMDAwYzowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDQw
MDAwMDAwLTB4NDAxZmZmZmZdDQpbICAgIDkuMzQ5OTY0XSBwY2kgMDAwYzowMDowMS4wOiAgIGJy
aWRnZSB3aW5kb3cgW21lbSAweDMwMDAwMDAwMDAwMC0weDMwMDAwMDFmZmZmZiA2NGJpdCBwcmVm
XQ0KWyAgICA5LjM1ODQ4NV0gcGNpX2J1cyAwMDBjOjAwOiByZXNvdXJjZSA0IFttZW0gMHg0MDAw
MDAwMC0weDRmZmZmZmZmIHdpbmRvd10NClsgICAgOS4zNjU0MTNdIHBjaV9idXMgMDAwYzowMDog
cmVzb3VyY2UgNSBbbWVtIDB4MzAwMDAwMDAwMDAwLTB4MzNmZmRmZmZmZmZmIHdpbmRvd10NClsg
ICAgOS4zNzMwNjBdIHBjaV9idXMgMDAwYzowMTogcmVzb3VyY2UgMSBbbWVtIDB4NDAwMDAwMDAt
MHg0MDFmZmZmZl0NClsgICAgOS4zNzkzODZdIHBjaV9idXMgMDAwYzowMTogcmVzb3VyY2UgMiBb
bWVtIDB4MzAwMDAwMDAwMDAwLTB4MzAwMDAwMWZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuMzg3
NDI2XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDSTFdIChkb21haW4gMDAwZCBbYnVzIDAwLWZm
XSkNClsgICAgOS4zOTM2MjNdIGFjcGkgUE5QMEEwODowMTogX09TQzogT1Mgc3VwcG9ydHMgW0V4
dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQ0KWyAgICA5
LjQwMjgyOV0gYWNwaSBQTlAwQTA4OjAxOiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5v
dCByZXF1ZXN0aW5nIF9PU0MgY29udHJvbA0KWyAgICA5LjQxMDY1MF0gYWNwaSBQTlAwQTA4OjAx
OiBNQ0ZHIHF1aXJrOiBFQ0FNIGF0IFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZmZmZmZmZd
IGZvciBbYnVzIDAwLWZmXSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMA0KWyAgICA5LjQyMzU2NV0g
YWNwaSBQTlAwQTA4OjAxOiBFQ0FNIGFyZWEgW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZmZmZm
ZmZmZl0gcmVzZXJ2ZWQgYnkgUE5QMEMwMjowMA0KWyAgICA5LjQzMjQ1MF0gYWNwaSBQTlAwQTA4
OjAxOiBFQ0FNIGF0IFttZW0gMHgzN2ZmZjAwMDAwMDAtMHgzN2ZmZmZmZmZmZmZdIGZvciBbYnVz
IDAwLWZmXQ0KWyAgICA5LjQ0MDY3Ml0gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDBkOjAwDQpb
ICAgIDkuNDQ0NzE4XSBwY2lfYnVzIDAwMGQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHg1
MDAwMDAwMC0weDVmZmZmZmZmIHdpbmRvd10NClsgICAgOS40NTIzMDddIHBjaV9idXMgMDAwZDow
MDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDM0MDAwMDAwMDAwMC0weDM3ZmZkZmZmZmZmZiB3
aW5kb3ddDQpbICAgIDkuNDYwNTYxXSBwY2lfYnVzIDAwMGQ6MDA6IHJvb3QgYnVzIHJlc291cmNl
IFtidXMgMDAtZmZdDQpbICAgIDkuNDY2MTI2XSBwY2kgMDAwZDowMDowMC4wOiBbMWRlZjplMTAw
XSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwDQpbICAgIDkuNDcyMjIxXSBwY2kgMDAwZDowMDowMC4w
OiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpb
ICAgIDkuNDc5ODQyXSBwY2kgMDAwZDowMDowMS4wOiBbMWRlZjplMTAxXSB0eXBlIDAxIGNsYXNz
IDB4MDYwNDAwDQpbICAgIDkuNDg1OTIwXSBwY2kgMDAwZDowMDowMS4wOiBzdXBwb3J0cyBEMSBE
Mg0KWyAgICA5LjQ5MDIwNF0gcGNpIDAwMGQ6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE
MCBEMSBEM2hvdA0KWyAgICA5LjQ5NjA2OF0gcGNpIDAwMGQ6MDA6MDEuMDogRmFpbGVkIHRvIGFk
ZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA5LjUwMzc3NF0g
cGNpIDAwMGQ6MDE6MDAuMDogWzEwZGU6MWU4OV0gdHlwZSAwMCBjbGFzcyAweDAzMDAwMA0KWyAg
ICA5LjUwOTc2NV0gcGNpIDAwMGQ6MDE6MDAuMDogcmVnIDB4MTA6IFttZW0gMHg1MDAwMDAwMC0w
eDUwZmZmZmZmXQ0KWyAgICA5LjUxNjEwMl0gcGNpIDAwMGQ6MDE6MDAuMDogcmVnIDB4MTQ6IFtt
ZW0gMHgzNDAwMDAwMDAwMDAtMHgzNDAwMGZmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS41MjQx
MDhdIHBjaSAwMDBkOjAxOjAwLjA6IHJlZyAweDFjOiBbbWVtIDB4MzQwMDEwMDAwMDAwLTB4MzQw
MDExZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuNTMyMDkxXSBwY2kgMDAwZDowMTowMC4wOiBy
ZWcgMHgyNDogW2lvICAweDU3ZmZlMDAwLTB4NTdmZmUwN2ZdDQpbICAgIDkuNTM4NDA4XSBwY2kg
MDAwZDowMTowMC4wOiByZWcgMHgzMDogW21lbSAweGZmZjgwMDAwLTB4ZmZmZmZmZmYgcHJlZl0N
ClsgICAgOS41NDUyNDJdIHBjaSAwMDBkOjAxOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAg
RDNob3QgRDNjb2xkDQpbICAgIDkuNTUxMzg1XSBwY2kgMDAwZDowMTowMC4wOiBGYWlsZWQgdG8g
YWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuNTU5MDE2
XSBwY2kgMDAwZDowMTowMC4xOiBbMTBkZToxMGY4XSB0eXBlIDAwIGNsYXNzIDB4MDQwMzAwDQpb
ICAgIDkuNTY1MDU5XSBwY2kgMDAwZDowMTowMC4xOiByZWcgMHgxMDogW21lbSAweDUxMDAwMDAw
LTB4NTEwMDNmZmZdDQpbICAgIDkuNTcxNDg5XSBwY2kgMDAwZDowMTowMC4xOiBGYWlsZWQgdG8g
YWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgIDkuNTc5MDY4
XSBwY2kgMDAwZDowMTowMC4yOiBbMTBkZToxYWQ4XSB0eXBlIDAwIGNsYXNzIDB4MGMwMzMwDQpb
ICAgIDkuNTg1MTE2XSBwY2kgMDAwZDowMTowMC4yOiByZWcgMHgxMDogW21lbSAweDM0MDAxMjAw
MDAwMC0weDM0MDAxMjAzZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjU5MzEyM10gcGNpIDAwMGQ6
MDE6MDAuMjogcmVnIDB4MWM6IFttZW0gMHgzNDAwMTIwNDAwMDAtMHgzNDAwMTIwNGZmZmYgNjRi
aXQgcHJlZl0NClsgICAgOS42MDExNTBdIHBjaSAwMDBkOjAxOjAwLjI6IFBNRSMgc3VwcG9ydGVk
IGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAgIDkuNjA3Mjc2XSBwY2kgMDAwZDowMTowMC4yOiBG
YWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAg
IDkuNjE0OTE0XSBwY2kgMDAwZDowMTowMC4zOiBbMTBkZToxYWQ5XSB0eXBlIDAwIGNsYXNzIDB4
MGM4MDAwDQpbICAgIDkuNjIwOTYzXSBwY2kgMDAwZDowMTowMC4zOiByZWcgMHgxMDogW21lbSAw
eDUxMDA0MDAwLTB4NTEwMDRmZmZdDQpbICAgIDkuNjI3MzYyXSBwY2kgMDAwZDowMTowMC4zOiBQ
TUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZA0KWyAgICA5LjYzMzQ5MF0gcGNpIDAw
MGQ6MDE6MDAuMzogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdo
dCBmYWlsIQ0KWyAgICA5LjY0MTEyOV0gcGNpIDAwMGQ6MDA6MDEuMDogQVNQTTogY3VycmVudCBj
b21tb24gY2xvY2sgY29uZmlndXJhdGlvbiBpcyBpbmNvbnNpc3RlbnQsIHJlY29uZmlndXJpbmcN
ClsgICAgOS42NjI1MjBdIHBjaSAwMDBkOjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4
MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuNjcwOTYyXSBw
Y2kgMDAwZDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDUwMDAwMDAwLTB4NTE3ZmZm
ZmZdDQpbICAgIDkuNjc3Nzk0XSBwY2kgMDAwZDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9y
IFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgIDkuNjg0MTI0XSBwY2kgMDAwZDowMDowMS4wOiBCQVIg
NzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgICA5LjY5MDgxNV0gcGNp
IDAwMGQ6MDE6MDAuMDogQkFSIDE6IGFzc2lnbmVkIFttZW0gMHgzNDAwMDAwMDAwMDAtMHgzNDAw
MGZmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS42OTkzNDddIHBjaSAwMDBkOjAxOjAwLjA6IEJB
UiAzOiBhc3NpZ25lZCBbbWVtIDB4MzQwMDEwMDAwMDAwLTB4MzQwMDExZmZmZmZmIDY0Yml0IHBy
ZWZdDQpbICAgIDkuNzA3ODU0XSBwY2kgMDAwZDowMTowMC4wOiBCQVIgMDogYXNzaWduZWQgW21l
bSAweDUwMDAwMDAwLTB4NTBmZmZmZmZdDQpbICAgIDkuNzE0Njg5XSBwY2kgMDAwZDowMTowMC4w
OiBCQVIgNjogYXNzaWduZWQgW21lbSAweDUxMDAwMDAwLTB4NTEwN2ZmZmYgcHJlZl0NClsgICAg
OS43MjE5ODNdIHBjaSAwMDBkOjAxOjAwLjI6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MzQwMDEy
MDAwMDAwLTB4MzQwMDEyMDNmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuNzMwNTEwXSBwY2kgMDAw
ZDowMTowMC4yOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDM0MDAxMjA0MDAwMC0weDM0MDAxMjA0
ZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjczOTAxN10gcGNpIDAwMGQ6MDE6MDAuMTogQkFSIDA6
IGFzc2lnbmVkIFttZW0gMHg1MTA4MDAwMC0weDUxMDgzZmZmXQ0KWyAgICA5Ljc0NTg1Ml0gcGNp
IDAwMGQ6MDE6MDAuMzogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg1MTA4NDAwMC0weDUxMDg0ZmZm
XQ0KWyAgICA5Ljc1MjcwOV0gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDU6IG5vIHNwYWNlIGZvciBb
aW8gIHNpemUgMHgwMDgwXQ0KWyAgICA5Ljc1OTAzN10gcGNpIDAwMGQ6MDE6MDAuMDogQkFSIDU6
IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MDA4MF0NClsgICAgOS43NjU3MjddIHBjaSAw
MDBkOjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMV0NClsgICAgOS43NzA3NDNdIHBjaSAw
MDBkOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NTAwMDAwMDAtMHg1MTdmZmZmZl0N
ClsgICAgOS43Nzc2MjJdIHBjaSAwMDBkOjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4
MzQwMDAwMDAwMDAwLTB4MzQwMDE3ZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgIDkuNzg2MTQ3XSBw
Y2lfYnVzIDAwMGQ6MDA6IFNvbWUgUENJIGRldmljZSByZXNvdXJjZXMgYXJlIHVuYXNzaWduZWQs
IHRyeSBib290aW5nIHdpdGggcGNpPXJlYWxsb2MNClsgICAgOS43OTUyNjhdIHBjaV9idXMgMDAw
ZDowMDogcmVzb3VyY2UgNCBbbWVtIDB4NTAwMDAwMDAtMHg1ZmZmZmZmZiB3aW5kb3ddDQpbICAg
IDkuODAyMTk0XSBwY2lfYnVzIDAwMGQ6MDA6IHJlc291cmNlIDUgW21lbSAweDM0MDAwMDAwMDAw
MC0weDM3ZmZkZmZmZmZmZiB3aW5kb3ddDQpbICAgIDkuODA5ODM1XSBwY2lfYnVzIDAwMGQ6MDE6
IHJlc291cmNlIDEgW21lbSAweDUwMDAwMDAwLTB4NTE3ZmZmZmZdDQpbICAgIDkuODE2MTU2XSBw
Y2lfYnVzIDAwMGQ6MDE6IHJlc291cmNlIDIgW21lbSAweDM0MDAwMDAwMDAwMC0weDM0MDAxN2Zm
ZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5LjgyNDIxN10gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQ
Q0kzXSAoZG9tYWluIDAwMDAgW2J1cyAwMC1mZl0pDQpbICAgIDkuODMwNDAwXSBhY3BpIFBOUDBB
MDg6MDM6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2Vn
bWVudHMgTVNJIEhQWC1UeXBlM10NClsgICAgOS44Mzk2MDddIGFjcGkgUE5QMEEwODowMzogUENJ
ZSBwb3J0IHNlcnZpY2VzIGRpc2FibGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNvbnRyb2wNClsg
ICAgOS44NDc0MjldIGFjcGkgUE5QMEEwODowMzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4
M2ZmZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4
MDAwMTBkZTBmYzANClsgICAgOS44NjAzNDBdIGFjcGkgUE5QMEEwODowMzogRUNBTSBhcmVhIFtt
ZW0gMHgzZmZmZjAwMDAwMDAtMHgzZmZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDAN
ClsgICAgOS44NjkyMjVdIGFjcGkgUE5QMEEwODowMzogRUNBTSBhdCBbbWVtIDB4M2ZmZmYwMDAw
MDAwLTB4M2ZmZmZmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0NClsgICAgOS44Nzc0NjhdIFBDSSBo
b3N0IGJyaWRnZSB0byBidXMgMDAwMDowMA0KWyAgICA5Ljg4MTUxOV0gcGNpX2J1cyAwMDAwOjAw
OiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4NzAwMDAwMDAtMHg3ZmZmZmZmZiB3aW5kb3ddDQpb
ICAgIDkuODg5MTAxXSBwY2lfYnVzIDAwMDA6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgz
YzAwMDAwMDAwMDAtMHgzZmZmZGZmZmZmZmYgd2luZG93XQ0KWyAgICA5Ljg5NzM1N10gcGNpX2J1
cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQ0KWyAgICA5LjkwMjkyM10g
cGNpIDAwMDA6MDA6MDAuMDogWzFkZWY6ZTEwMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMA0KWyAg
ICA5LjkwOTAxOV0gcGNpIDAwMDA6MDA6MDAuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdo
IG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA5LjkxNjYzOF0gcGNpIDAwMDA6MDA6MDEu
MDogWzFkZWY6ZTEwMV0gdHlwZSAwMSBjbGFzcyAweDA2MDQwMA0KWyAgICA5LjkyMjcxNV0gcGNp
IDAwMDA6MDA6MDEuMDogc3VwcG9ydHMgRDEgRDINClsgICAgOS45MjcwMDFdIHBjaSAwMDAwOjAw
OjAxLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QNClsgICAgOS45MzI4NjVdIHBj
aSAwMDAwOjAwOjAxLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVgg
bWlnaHQgZmFpbCENClsgICAgOS45NDA1NjVdIHBjaSAwMDAwOjAxOjAwLjA6IFs4MDg2OjE1ODld
IHR5cGUgMDAgY2xhc3MgMHgwMjAwMDANClsgICAgOS45NDY1NjRdIHBjaSAwMDAwOjAxOjAwLjA6
IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAzMDAwMDAwLTB4M2MwMDAzZmZmZmZmIDY0Yml0IHByZWZd
DQpbICAgIDkuOTU0NTcxXSBwY2kgMDAwMDowMTowMC4wOiByZWcgMHgxYzogW21lbSAweDNjMDAw
NDgxODAwMC0weDNjMDAwNDgxZmZmZiA2NGJpdCBwcmVmXQ0KWyAgICA5Ljk2MjU1M10gcGNpIDAw
MDA6MDE6MDAuMDogcmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdDQpb
ICAgIDkuOTY5Mzc0XSBwY2kgMDAwMDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQz
aG90IEQzY29sZA0KWyAgICA5Ljk3NTUwM10gcGNpIDAwMDA6MDE6MDAuMDogRmFpbGVkIHRvIGFk
ZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgICA5Ljk4MzE0Nl0g
cGNpIDAwMDA6MDE6MDAuMTogWzgwODY6MTU4OV0gdHlwZSAwMCBjbGFzcyAweDAyMDAwMA0KWyAg
ICA5Ljk4OTE4NV0gcGNpIDAwMDA6MDE6MDAuMTogcmVnIDB4MTA6IFttZW0gMHgzYzAwMDIwMDAw
MDAtMHgzYzAwMDJmZmZmZmYgNjRiaXQgcHJlZl0NClsgICAgOS45OTcxOTJdIHBjaSAwMDAwOjAx
OjAwLjE6IHJlZyAweDFjOiBbbWVtIDB4M2MwMDA0ODEwMDAwLTB4M2MwMDA0ODE3ZmZmIDY0Yml0
IHByZWZdDQpbICAgMTAuMDA1MTc1XSBwY2kgMDAwMDowMTowMC4xOiByZWcgMHgzMDogW21lbSAw
eGZmZjgwMDAwLTB4ZmZmZmZmZmYgcHJlZl0NClsgICAxMC4wMTE5OTddIHBjaSAwMDAwOjAxOjAw
LjE6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAgMTAuMDE4MTE2XSBw
Y2kgMDAwMDowMTowMC4xOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1Y
IG1pZ2h0IGZhaWwhDQpbICAgMTAuMDI1NzYzXSBwY2kgMDAwMDowMTowMC4yOiBbODA4NjoxNTg5
XSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwDQpbICAgMTAuMDMxODA2XSBwY2kgMDAwMDowMTowMC4y
OiByZWcgMHgxMDogW21lbSAweDNjMDAwMTAwMDAwMC0weDNjMDAwMWZmZmZmZiA2NGJpdCBwcmVm
XQ0KWyAgIDEwLjAzOTgxNF0gcGNpIDAwMDA6MDE6MDAuMjogcmVnIDB4MWM6IFttZW0gMHgzYzAw
MDQ4MDgwMDAtMHgzYzAwMDQ4MGZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4wNDc3OTddIHBjaSAw
MDAwOjAxOjAwLjI6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQ0K
WyAgIDEwLjA1NDYxM10gcGNpIDAwMDA6MDE6MDAuMjogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBE
M2hvdCBEM2NvbGQNClsgICAxMC4wNjA3MzhdIHBjaSAwMDAwOjAxOjAwLjI6IEZhaWxlZCB0byBh
ZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC4wNjgzODRd
IHBjaSAwMDAwOjAxOjAwLjM6IFs4MDg2OjE1ODldIHR5cGUgMDAgY2xhc3MgMHgwMjAwMDANClsg
ICAxMC4wNzQ0MjldIHBjaSAwMDAwOjAxOjAwLjM6IHJlZyAweDEwOiBbbWVtIDB4M2MwMDAwMDAw
MDAwLTB4M2MwMDAwZmZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMDgyNDM2XSBwY2kgMDAwMDow
MTowMC4zOiByZWcgMHgxYzogW21lbSAweDNjMDAwNDgwMDAwMC0weDNjMDAwNDgwN2ZmZiA2NGJp
dCBwcmVmXQ0KWyAgIDEwLjA5MDQxOF0gcGNpIDAwMDA6MDE6MDAuMzogcmVnIDB4MzA6IFttZW0g
MHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdDQpbICAgMTAuMDk3MjM1XSBwY2kgMDAwMDowMTow
MC4zOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZA0KWyAgIDEwLjEwMzM2MF0g
cGNpIDAwMDA6MDE6MDAuMzogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0kt
WCBtaWdodCBmYWlsIQ0KWyAgIDEwLjExMTAyNV0gcGNpIDAwMDA6MDA6MDEuMDogYnJpZGdlIHdp
bmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDEtMDJdIGFkZF9zaXplIDEwMDANClsg
ICAxMC4xMTk1MDBdIHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4M2Mw
MDAwMDAwMDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMTI4MDAzXSBwY2kg
MDAwMDowMDowMS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZmZmZd
DQpbICAgMTAuMTM0ODQyXSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtp
byAgc2l6ZSAweDEwMDBdDQpbICAgMTAuMTQxMTc3XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNzog
ZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjE0Nzg2MF0gcGNpIDAw
MDA6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEw
LjE1NDE5Ml0gcGNpIDAwMDA6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBz
aXplIDB4MTAwMF0NClsgICAxMC4xNjA4ODldIHBjaSAwMDAwOjAxOjAwLjA6IEJBUiAwOiBhc3Np
Z25lZCBbbWVtIDB4M2MwMDAwMDAwMDAwLTB4M2MwMDAwZmZmZmZmIDY0Yml0IHByZWZdDQpbICAg
MTAuMTY5NDE1XSBwY2kgMDAwMDowMTowMC4xOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDNjMDAw
MTAwMDAwMC0weDNjMDAwMWZmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjE3NzkyMl0gcGNpIDAw
MDA6MDE6MDAuMjogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHgzYzAwMDIwMDAwMDAtMHgzYzAwMDJm
ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMC4xODY0MjldIHBjaSAwMDAwOjAxOjAwLjM6IEJBUiAw
OiBhc3NpZ25lZCBbbWVtIDB4M2MwMDAzMDAwMDAwLTB4M2MwMDAzZmZmZmZmIDY0Yml0IHByZWZd
DQpbICAgMTAuMTk0OTM2XSBwY2kgMDAwMDowMTowMC4wOiBCQVIgNjogYXNzaWduZWQgW21lbSAw
eDcwMDAwMDAwLTB4NzAwN2ZmZmYgcHJlZl0NClsgICAxMC4yMDIyMDhdIHBjaSAwMDAwOjAxOjAw
LjE6IEJBUiA2OiBhc3NpZ25lZCBbbWVtIDB4NzAwODAwMDAtMHg3MDBmZmZmZiBwcmVmXQ0KWyAg
IDEwLjIwOTUwMF0gcGNpIDAwMDA6MDE6MDAuMjogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg3MDEw
MDAwMC0weDcwMTdmZmZmIHByZWZdDQpbICAgMTAuMjE2NzkzXSBwY2kgMDAwMDowMTowMC4zOiBC
QVIgNjogYXNzaWduZWQgW21lbSAweDcwMTgwMDAwLTB4NzAxZmZmZmYgcHJlZl0NClsgICAxMC4y
MjQwODNdIHBjaSAwMDAwOjAxOjAwLjA6IEJBUiAzOiBhc3NpZ25lZCBbbWVtIDB4M2MwMDA0MDAw
MDAwLTB4M2MwMDA0MDA3ZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMjMyNjEwXSBwY2kgMDAwMDow
MTowMC4xOiBCQVIgMzogYXNzaWduZWQgW21lbSAweDNjMDAwNDAwODAwMC0weDNjMDAwNDAwZmZm
ZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjI0MTExN10gcGNpIDAwMDA6MDE6MDAuMjogQkFSIDM6IGFz
c2lnbmVkIFttZW0gMHgzYzAwMDQwMTAwMDAtMHgzYzAwMDQwMTdmZmYgNjRiaXQgcHJlZl0NClsg
ICAxMC4yNDk2MjRdIHBjaSAwMDAwOjAxOjAwLjM6IEJBUiAzOiBhc3NpZ25lZCBbbWVtIDB4M2Mw
MDA0MDE4MDAwLTB4M2MwMDA0MDFmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMjU4MTMwXSBwY2kg
MDAwMDowMDowMS4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDEtMDJdDQpbICAgMTAuMjYzMzg1XSBw
Y2kgMDAwMDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDcwMDAwMDAwLTB4NzAxZmZm
ZmZdDQpbICAgMTAuMjcwMjU4XSBwY2kgMDAwMDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21l
bSAweDNjMDAwMDAwMDAwMC0weDNjMDAwNDdmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjI3ODc4
NV0gcGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSA0IFttZW0gMHg3MDAwMDAwMC0weDdmZmZmZmZm
IHdpbmRvd10NClsgICAxMC4yODU3MTJdIHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNSBbbWVt
IDB4M2MwMDAwMDAwMDAwLTB4M2ZmZmRmZmZmZmZmIHdpbmRvd10NClsgICAxMC4yOTMzNTldIHBj
aV9idXMgMDAwMDowMTogcmVzb3VyY2UgMSBbbWVtIDB4NzAwMDAwMDAtMHg3MDFmZmZmZl0NClsg
ICAxMC4yOTk2NzldIHBjaV9idXMgMDAwMDowMTogcmVzb3VyY2UgMiBbbWVtIDB4M2MwMDAwMDAw
MDAwLTB4M2MwMDA0N2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTAuMzA3NzQ0XSBBQ1BJOiBQQ0kg
Um9vdCBCcmlkZ2UgW1BDSTZdIChkb21haW4gMDAwNCBbYnVzIDAwLWZmXSkNClsgICAxMC4zMTM5
MjRdIGFjcGkgUE5QMEEwODowNjogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFT
UE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQ0KWyAgIDEwLjMyMzEyOV0gYWNwaSBQ
TlAwQTA4OjA2OiBQQ0llIHBvcnQgc2VydmljZXMgZGlzYWJsZWQ7IG5vdCByZXF1ZXN0aW5nIF9P
U0MgY29udHJvbA0KWyAgIDEwLjMzMDk1N10gYWNwaSBQTlAwQTA4OjA2OiBNQ0ZHIHF1aXJrOiBF
Q0FNIGF0IFttZW0gMHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZm
XSB3aXRoIDB4ZmZmZjgwMDAxMGRlMGZjMA0KWyAgIDEwLjM0Mzg2Ml0gYWNwaSBQTlAwQTA4OjA2
OiBFQ0FNIGFyZWEgW21lbSAweDJiZmZmMDAwMDAwMC0weDJiZmZmZmZmZmZmZl0gcmVzZXJ2ZWQg
YnkgUE5QMEMwMjowMA0KWyAgIDEwLjM1Mjc0OV0gYWNwaSBQTlAwQTA4OjA2OiBFQ0FNIGF0IFtt
ZW0gMHgyYmZmZjAwMDAwMDAtMHgyYmZmZmZmZmZmZmZdIGZvciBbYnVzIDAwLWZmXQ0KWyAgIDEw
LjM2MDk3MF0gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDA0OjAwDQpbICAgMTAuMzY1MDE1XSBw
Y2lfYnVzIDAwMDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgyMDAwMDAwMC0weDJmZmZm
ZmZmIHdpbmRvd10NClsgICAxMC4zNzI2MDVdIHBjaV9idXMgMDAwNDowMDogcm9vdCBidXMgcmVz
b3VyY2UgW21lbSAweDI4MDAwMDAwMDAwMC0weDJiZmZkZmZmZmZmZiB3aW5kb3ddDQpbICAgMTAu
MzgwODY1XSBwY2lfYnVzIDAwMDQ6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdDQpb
ICAgMTAuMzg2NDI0XSBwY2kgMDAwNDowMDowMC4wOiBbMWRlZjplMTEwXSB0eXBlIDAwIGNsYXNz
IDB4MDYwMDAwDQpbICAgMTAuMzkyNTE5XSBwY2kgMDAwNDowMDowMC4wOiBGYWlsZWQgdG8gYWRk
IC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTAuNDAwMTQwXSBw
Y2kgMDAwNDowMDowMS4wOiBbMWRlZjplMTExXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAg
MTAuNDA2MjE5XSBwY2kgMDAwNDowMDowMS4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgIDEwLjQxMDUw
MV0gcGNpIDAwMDQ6MDA6MDEuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAg
IDEwLjQxNjM2N10gcGNpIDAwMDQ6MDA6MDEuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdo
IG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDEwLjQyNDAxM10gcGNpIDAwMDQ6MDA6MDMu
MDogWzFkZWY6ZTExM10gdHlwZSAwMSBjbGFzcyAweDA2MDQwMA0KWyAgIDEwLjQzMDA5MV0gcGNp
IDAwMDQ6MDA6MDMuMDogc3VwcG9ydHMgRDEgRDINClsgICAxMC40MzQzNzNdIHBjaSAwMDA0OjAw
OjAzLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QNClsgICAxMC40NDAyMzhdIHBj
aSAwMDA0OjAwOjAzLjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVgg
bWlnaHQgZmFpbCENClsgICAxMC40NDc4ODVdIHBjaSAwMDA0OjAwOjA1LjA6IFsxZGVmOmUxMTVd
IHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAxMC40NTM5NzFdIHBjaSAwMDA0OjAwOjA1LjA6
IHN1cHBvcnRzIEQxIEQyDQpbICAgMTAuNDU4MjQ0XSBwY2kgMDAwNDowMDowNS4wOiBQTUUjIHN1
cHBvcnRlZCBmcm9tIEQwIEQxIEQzaG90DQpbICAgMTAuNDY0MTkxXSBwY2kgMDAwNDowMDowNS4w
OiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpb
ICAgMTAuNDcxODg0XSBwY2kgMDAwNDowMTowMC4wOiBbMWEwMzoxMTUwXSB0eXBlIDAxIGNsYXNz
IDB4MDYwNDAwDQpbICAgMTAuNDc3OTA5XSBwY2kgMDAwNDowMTowMC4wOiBlbmFibGluZyBFeHRl
bmRlZCBUYWdzDQpbICAgMTAuNDgyOTQ5XSBwY2kgMDAwNDowMTowMC4wOiBzdXBwb3J0cyBEMSBE
Mg0KWyAgIDEwLjQ4NzIxM10gcGNpIDAwMDQ6MDE6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE
MCBEMSBEMiBEM2hvdCBEM2NvbGQNClsgICAxMC40OTM5NzRdIHBjaSAwMDA0OjAxOjAwLjA6IEZh
aWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAx
MC41MDE2MzRdIHBjaV9idXMgMDAwNDowMjogZXh0ZW5kZWQgY29uZmlnIHNwYWNlIG5vdCBhY2Nl
c3NpYmxlDQpbICAgMTAuNTA3NzUwXSBwY2kgMDAwNDowMjowMC4wOiBbMWEwMzoyMDAwXSB0eXBl
IDAwIGNsYXNzIDB4MDMwMDAwDQpbICAgMTAuNTEzODE0XSBwY2kgMDAwNDowMjowMC4wOiByZWcg
MHgxMDogW21lbSAweDIwMDAwMDAwLTB4MjBmZmZmZmZdDQpbICAgMTAuNTIwMTQ2XSBwY2kgMDAw
NDowMjowMC4wOiByZWcgMHgxNDogW21lbSAweDIxMDAwMDAwLTB4MjEwMWZmZmZdDQpbICAgMTAu
NTI2NDgxXSBwY2kgMDAwNDowMjowMC4wOiByZWcgMHgxODogW2lvICAweDI3ZmZmMDAwLTB4Mjdm
ZmYwN2ZdDQpbICAgMTAuNTMyODkyXSBwY2kgMDAwNDowMjowMC4wOiBzdXBwb3J0cyBEMSBEMg0K
WyAgIDEwLjUzNzEyNV0gcGNpIDAwMDQ6MDI6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBE
MSBEMiBEM2hvdCBEM2NvbGQNClsgICAxMC41NDM4NzhdIHBjaSAwMDA0OjAyOjAwLjA6IEZhaWxl
ZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMC41
NTE2MjJdIHBjaSAwMDA0OjAzOjAwLjA6IFsxOTEyOjAwMTRdIHR5cGUgMDAgY2xhc3MgMHgwYzAz
MzANClsgICAxMC41NTc2MTVdIHBjaSAwMDA0OjAzOjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4MjEy
MDAwMDAtMHgyMTIwMWZmZiA2NGJpdF0NClsgICAxMC41NjQ1NjddIHBjaSAwMDA0OjAzOjAwLjA6
IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAgMTAuNTcwNjg5XSBwY2kg
MDAwNDowMzowMC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2ggb3IgTVNJL01TSS1YIG1p
Z2h0IGZhaWwhDQpbICAgMTAuNTc4MzcyXSBwY2kgMDAwNDowNDowMC4wOiBbODA4NjoxNTMzXSB0
eXBlIDAwIGNsYXNzIDB4MDIwMDAwDQpbICAgMTAuNTg0Mzc1XSBwY2kgMDAwNDowNDowMC4wOiBy
ZWcgMHgxMDogW21lbSAweDIxMTAwMDAwLTB4MjExN2ZmZmZdDQpbICAgMTAuNTkwNzE1XSBwY2kg
MDAwNDowNDowMC4wOiByZWcgMHgxODogW2lvICAweDI3ZmZlMDAwLTB4MjdmZmUwMWZdDQpbICAg
MTAuNTk3MDM3XSBwY2kgMDAwNDowNDowMC4wOiByZWcgMHgxYzogW21lbSAweDIxMTgwMDAwLTB4
MjExODNmZmZdDQpbICAgMTAuNjAzNTM1XSBwY2kgMDAwNDowNDowMC4wOiBQTUUjIHN1cHBvcnRl
ZCBmcm9tIEQwIEQzaG90IEQzY29sZA0KWyAgIDEwLjYwOTY3MV0gcGNpIDAwMDQ6MDQ6MDAuMDog
RmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAg
IDEwLjYxNzI5OF0gcGNpIDAwMDQ6MDA6MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAw
MDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxLTAyXSBhZGRfc2l6ZSAyMDAwMDAg
YWRkX2FsaWduIDEwMDAwMA0KWyAgIDEwLjYyOTEwOF0gcGNpIDAwMDQ6MDA6MDMuMDogYnJpZGdl
IHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDEwMDANClsg
ICAxMC42MzczMTJdIHBjaSAwMDA0OjAwOjAzLjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAw
MDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1cyAwM10gYWRkX3NpemUgMjAwMDAwIGFk
ZF9hbGlnbiAxMDAwMDANClsgICAxMC42NDg4OTZdIHBjaSAwMDA0OjAwOjAzLjA6IGJyaWRnZSB3
aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAxZmZmZmZdIHRvIFtidXMgMDNdIGFkZF9zaXplIDEw
MDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTAuNjU5NDc1XSBwY2kgMDAwNDowMDowNS4wOiBi
cmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFti
dXMgMDRdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTAuNjcxMDM1XSBw
Y2kgMDAwNDowMDowNS4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZm
XSB0byBbYnVzIDA0XSBhZGRfc2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDEwLjY4
MTYyMV0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0w
eDIxN2ZmZmZmXQ0KWyAgIDEwLjY4ODQyNF0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDk6IGFzc2ln
bmVkIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsgICAx
MC42OTY5NTBdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MjE4MDAw
MDAtMHgyMTlmZmZmZl0NClsgICAxMC43MDM3ODldIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA5OiBh
c3NpZ25lZCBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHByZWZdDQpb
ICAgMTAuNzEyMzE0XSBwY2kgMDAwNDowMDowNS4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDIx
YTAwMDAwLTB4MjFiZmZmZmZdDQpbICAgMTAuNzE5MTUzXSBwY2kgMDAwNDowMDowNS4wOiBCQVIg
OTogYXNzaWduZWQgW21lbSAweDI4MDAwMDQwMDAwMC0weDI4MDAwMDVmZmZmZiA2NGJpdCBwcmVm
XQ0KWyAgIDEwLjcyNzY3OV0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBb
aW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjczMzk5MF0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6
IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC43NDA2NzhdIHBjaSAw
MDA0OjAwOjAzLjA6IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAx
MC43NDcwMTFdIHBjaSAwMDA0OjAwOjAzLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAg
c2l6ZSAweDEwMDBdDQpbICAgMTAuNzUzNjk5XSBwY2kgMDAwNDowMDowNS4wOiBCQVIgNzogbm8g
c3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTAuNzYwMDMyXSBwY2kgMDAwNDowMDow
NS4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjc2
NjcyMV0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgx
MDAwXQ0KWyAgIDEwLjc3MzA1NF0gcGNpIDAwMDQ6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBh
c3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC43Nzk3NDBdIHBjaSAwMDA0OjAwOjA1LjA6
IEJBUiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC43ODYwNzNdIHBj
aSAwMDA0OjAwOjA1LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBd
DQpbICAgMTAuNzkyNzYzXSBwY2kgMDAwNDowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtp
byAgc2l6ZSAweDEwMDBdDQpbICAgMTAuNzk5MDk0XSBwY2kgMDAwNDowMDowMy4wOiBCQVIgNzog
ZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDEwLjgwNTc4NF0gcGNpIDAw
MDQ6MDE6MDAuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0gMHgyMDAwMDAwMC0weDIxN2ZmZmZmXQ0K
WyAgIDEwLjgxMjY0NF0gcGNpIDAwMDQ6MDE6MDAuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8g
IHNpemUgMHgxMDAwXQ0KWyAgIDEwLjgxODk3NF0gcGNpIDAwMDQ6MDE6MDAuMDogQkFSIDc6IGZh
aWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMC44MjU2NjRdIHBjaSAwMDA0
OjAyOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MjAwMDAwMDAtMHgyMGZmZmZmZl0NClsg
ICAxMC44MzI1MjddIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAxOiBhc3NpZ25lZCBbbWVtIDB4MjEw
MDAwMDAtMHgyMTAxZmZmZl0NClsgICAxMC44MzkzODRdIHBjaSAwMDA0OjAyOjAwLjA6IEJBUiAy
OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MDA4MF0NClsgICAxMC44NDU3MTBdIHBjaSAwMDA0
OjAyOjAwLjA6IEJBUiAyOiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDAwODBdDQpbICAg
MTAuODUyMzk5XSBwY2kgMDAwNDowMTowMC4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDJdDQpbICAg
MTAuODU3NDE2XSBwY2kgMDAwNDowMTowMC4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIwMDAw
MDAwLTB4MjE3ZmZmZmZdDQpbICAgMTAuODY0MzAxXSBwY2kgMDAwNDowMDowMS4wOiBQQ0kgYnJp
ZGdlIHRvIFtidXMgMDEtMDJdDQpbICAgMTAuODY5NTY5XSBwY2kgMDAwNDowMDowMS4wOiAgIGJy
aWRnZSB3aW5kb3cgW21lbSAweDIwMDAwMDAwLTB4MjE3ZmZmZmZdDQpbICAgMTAuODc2NDQ2XSBw
Y2kgMDAwNDowMDowMS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDI4MDAwMDAwMDAwMC0weDI4
MDAwMDFmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjg4NDk3Nl0gcGNpIDAwMDQ6MDM6MDAuMDog
QkFSIDA6IGFzc2lnbmVkIFttZW0gMHgyMTgwMDAwMC0weDIxODAxZmZmIDY0Yml0XQ0KWyAgIDEw
Ljg5MjM0OF0gcGNpIDAwMDQ6MDA6MDMuMDogUENJIGJyaWRnZSB0byBbYnVzIDAzXQ0KWyAgIDEw
Ljg5NzM0M10gcGNpIDAwMDQ6MDA6MDMuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyMTgwMDAw
MC0weDIxOWZmZmZmXQ0KWyAgIDEwLjkwNDIyNV0gcGNpIDAwMDQ6MDA6MDMuMDogICBicmlkZ2Ug
d2luZG93IFttZW0gMHgyODAwMDAyMDAwMDAtMHgyODAwMDAzZmZmZmYgNjRiaXQgcHJlZl0NClsg
ICAxMC45MTI3NTJdIHBjaSAwMDA0OjA0OjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MjFh
MDAwMDAtMHgyMWE3ZmZmZl0NClsgICAxMC45MTk1OTVdIHBjaSAwMDA0OjA0OjAwLjA6IEJBUiAz
OiBhc3NpZ25lZCBbbWVtIDB4MjFhODAwMDAtMHgyMWE4M2ZmZl0NClsgICAxMC45MjY0NTBdIHBj
aSAwMDA0OjA0OjAwLjA6IEJBUiAyOiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MDAyMF0NClsg
ICAxMC45MzI3NzhdIHBjaSAwMDA0OjA0OjAwLjA6IEJBUiAyOiBmYWlsZWQgdG8gYXNzaWduIFtp
byAgc2l6ZSAweDAwMjBdDQpbICAgMTAuOTM5NDY1XSBwY2kgMDAwNDowMDowNS4wOiBQQ0kgYnJp
ZGdlIHRvIFtidXMgMDRdDQpbICAgMTAuOTQ0NDgwXSBwY2kgMDAwNDowMDowNS4wOiAgIGJyaWRn
ZSB3aW5kb3cgW21lbSAweDIxYTAwMDAwLTB4MjFiZmZmZmZdDQpbICAgMTAuOTUxMzY1XSBwY2kg
MDAwNDowMDowNS4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDI4MDAwMDQwMDAwMC0weDI4MDAw
MDVmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDEwLjk1OTg4N10gcGNpX2J1cyAwMDA0OjAwOiBTb21l
IFBDSSBkZXZpY2UgcmVzb3VyY2VzIGFyZSB1bmFzc2lnbmVkLCB0cnkgYm9vdGluZyB3aXRoIHBj
aT1yZWFsbG9jDQpbICAgMTAuOTY5MDA4XSBwY2lfYnVzIDAwMDQ6MDA6IHJlc291cmNlIDQgW21l
bSAweDIwMDAwMDAwLTB4MmZmZmZmZmYgd2luZG93XQ0KWyAgIDEwLjk3NTkyNV0gcGNpX2J1cyAw
MDA0OjAwOiByZXNvdXJjZSA1IFttZW0gMHgyODAwMDAwMDAwMDAtMHgyYmZmZGZmZmZmZmYgd2lu
ZG93XQ0KWyAgIDEwLjk4MzU3Ml0gcGNpX2J1cyAwMDA0OjAxOiByZXNvdXJjZSAxIFttZW0gMHgy
MDAwMDAwMC0weDIxN2ZmZmZmXQ0KWyAgIDEwLjk4OTg5Nl0gcGNpX2J1cyAwMDA0OjAxOiByZXNv
dXJjZSAyIFttZW0gMHgyODAwMDAwMDAwMDAtMHgyODAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsg
ICAxMC45OTc5MDFdIHBjaV9idXMgMDAwNDowMjogcmVzb3VyY2UgMSBbbWVtIDB4MjAwMDAwMDAt
MHgyMTdmZmZmZl0NClsgICAxMS4wMDQyMThdIHBjaV9idXMgMDAwNDowMzogcmVzb3VyY2UgMSBb
bWVtIDB4MjE4MDAwMDAtMHgyMTlmZmZmZl0NClsgICAxMS4wMTA1NTRdIHBjaV9idXMgMDAwNDow
MzogcmVzb3VyY2UgMiBbbWVtIDB4MjgwMDAwMjAwMDAwLTB4MjgwMDAwM2ZmZmZmIDY0Yml0IHBy
ZWZdDQpbICAgMTEuMDE4NTYwXSBwY2lfYnVzIDAwMDQ6MDQ6IHJlc291cmNlIDEgW21lbSAweDIx
YTAwMDAwLTB4MjFiZmZmZmZdDQpbICAgMTEuMDI0ODc5XSBwY2lfYnVzIDAwMDQ6MDQ6IHJlc291
cmNlIDIgW21lbSAweDI4MDAwMDQwMDAwMC0weDI4MDAwMDVmZmZmZiA2NGJpdCBwcmVmXQ0KWyAg
IDExLjAzMjk2MF0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQ0k3XSAoZG9tYWluIDAwMDUgW2J1
cyAwMC1mZl0pDQpbICAgMTEuMDM5MTIzXSBhY3BpIFBOUDBBMDg6MDc6IF9PU0M6IE9TIHN1cHBv
cnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10N
ClsgICAxMS4wNDgzNDZdIGFjcGkgUE5QMEEwODowNzogUENJZSBwb3J0IHNlcnZpY2VzIGRpc2Fi
bGVkOyBub3QgcmVxdWVzdGluZyBfT1NDIGNvbnRyb2wNClsgICAxMS4wNTYxNzBdIGFjcGkgUE5Q
MEEwODowNzogTUNGRyBxdWlyazogRUNBTSBhdCBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4MmZmZmZm
ZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0gd2l0aCAweGZmZmY4MDAwMTBkZTBmYzANClsgICAxMS4w
NjkxNThdIGFjcGkgUE5QMEEwODowNzogRUNBTSBhcmVhIFttZW0gMHgyZmZmZjAwMDAwMDAtMHgy
ZmZmZmZmZmZmZmZdIHJlc2VydmVkIGJ5IFBOUDBDMDI6MDANClsgICAxMS4wNzgwNTJdIGFjcGkg
UE5QMEEwODowNzogRUNBTSBhdCBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4MmZmZmZmZmZmZmZmXSBm
b3IgW2J1cyAwMC1mZl0NClsgICAxMS4wODYyNjRdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAw
NTowMA0KWyAgIDExLjA5MDMwOV0gcGNpX2J1cyAwMDA1OjAwOiByb290IGJ1cyByZXNvdXJjZSBb
bWVtIDB4MzAwMDAwMDAtMHgzZmZmZmZmZiB3aW5kb3ddDQpbICAgMTEuMDk3OTAxXSBwY2lfYnVz
IDAwMDU6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyZmZmZGZm
ZmZmZmYgd2luZG93XQ0KWyAgIDExLjEwNjE1Nl0gcGNpX2J1cyAwMDA1OjAwOiByb290IGJ1cyBy
ZXNvdXJjZSBbYnVzIDAwLWZmXQ0KWyAgIDExLjExMTcyNl0gcGNpIDAwMDU6MDA6MDAuMDogWzFk
ZWY6ZTExMF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMA0KWyAgIDExLjExNzgyMV0gcGNpIDAwMDU6
MDA6MDAuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1TSS9NU0ktWCBtaWdodCBm
YWlsIQ0KWyAgIDExLjEyNTQzOF0gcGNpIDAwMDU6MDA6MDEuMDogWzFkZWY6ZTExMV0gdHlwZSAw
MSBjbGFzcyAweDA2MDQwMA0KWyAgIDExLjEzMTUyOF0gcGNpIDAwMDU6MDA6MDEuMDogc3VwcG9y
dHMgRDEgRDINClsgICAxMS4xMzU3OTZdIHBjaSAwMDA1OjAwOjAxLjA6IFBNRSMgc3VwcG9ydGVk
IGZyb20gRDAgRDEgRDNob3QNClsgICAxMS4xNDE2NjldIHBjaSAwMDA1OjAwOjAxLjA6IEZhaWxl
ZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgZmFpbCENClsgICAxMS4x
NDkzMDZdIHBjaSAwMDA1OjAwOjAzLjA6IFsxZGVmOmUxMTNdIHR5cGUgMDEgY2xhc3MgMHgwNjA0
MDANClsgICAxMS4xNTUzODVdIHBjaSAwMDA1OjAwOjAzLjA6IHN1cHBvcnRzIEQxIEQyDQpbICAg
MTEuMTU5NjY3XSBwY2kgMDAwNTowMDowMy4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQz
aG90DQpbICAgMTEuMTY1NTM1XSBwY2kgMDAwNTowMDowMy4wOiBGYWlsZWQgdG8gYWRkIC0gcGFz
c3Rocm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTEuMTczMTgwXSBwY2kgMDAw
NTowMDowNS4wOiBbMWRlZjplMTE1XSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwDQpbICAgMTEuMTc5
MjY2XSBwY2kgMDAwNTowMDowNS4wOiBzdXBwb3J0cyBEMSBEMg0KWyAgIDExLjE4MzUzOF0gcGNp
IDAwMDU6MDA6MDUuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEMCBEMSBEM2hvdA0KWyAgIDExLjE4
OTQwN10gcGNpIDAwMDU6MDA6MDUuMDogRmFpbGVkIHRvIGFkZCAtIHBhc3N0aHJvdWdoIG9yIE1T
SS9NU0ktWCBtaWdodCBmYWlsIQ0KWyAgIDExLjE5NzA0OF0gcGNpIDAwMDU6MDA6MDcuMDogWzFk
ZWY6ZTExN10gdHlwZSAwMSBjbGFzcyAweDA2MDQwMA0KWyAgIDExLjIwMzEyNF0gcGNpIDAwMDU6
MDA6MDcuMDogc3VwcG9ydHMgRDEgRDINClsgICAxMS4yMDc0MTBdIHBjaSAwMDA1OjAwOjA3LjA6
IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDEgRDNob3QNClsgICAxMS4yMTMyNzhdIHBjaSAwMDA1
OjAwOjA3LjA6IEZhaWxlZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQg
ZmFpbCENClsgICAxMS4yMjIwNDZdIHBjaSAwMDA1OjAyOjAwLjA6IFsxOTEyOjAwMTRdIHR5cGUg
MDAgY2xhc3MgMHgwYzAzMzANClsgICAxMS4yMjgwNDBdIHBjaSAwMDA1OjAyOjAwLjA6IHJlZyAw
eDEwOiBbbWVtIDB4MzAxMDAwMDAtMHgzMDEwMWZmZiA2NGJpdF0NClsgICAxMS4yMzQ5OTFdIHBj
aSAwMDA1OjAyOjAwLjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkDQpbICAg
MTEuMjQxMTE2XSBwY2kgMDAwNTowMjowMC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Rocm91Z2gg
b3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTEuMjQ5ODQxXSBwY2kgMDAwNTowNDowMC4w
OiBbMTI2ZjoyMjYzXSB0eXBlIDAwIGNsYXNzIDB4MDEwODAyDQpbICAgMTEuMjU1ODMzXSBwY2kg
MDAwNTowNDowMC4wOiByZWcgMHgxMDogW21lbSAweDMwMDAwMDAwLTB4MzAwMDNmZmYgNjRiaXRd
DQpbICAgMTEuMjYyODMxXSBwY2kgMDAwNTowNDowMC4wOiBGYWlsZWQgdG8gYWRkIC0gcGFzc3Ro
cm91Z2ggb3IgTVNJL01TSS1YIG1pZ2h0IGZhaWwhDQpbICAgMTEuMjcwNDIzXSBwY2kgMDAwNTow
MDowMS4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0gdG8gW2J1cyAwMV0gYWRk
X3NpemUgMTAwMA0KWyAgIDExLjI3ODY0MV0gcGNpIDAwMDU6MDA6MDEuMDogYnJpZGdlIHdpbmRv
dyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0byBbYnVzIDAxXSBhZGRf
c2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjI5MDIyNV0gcGNpIDAwMDU6MDA6
MDEuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZl0gdG8gW2J1cyAw
MV0gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMS4zMDA4MDddIHBjaSAw
MDA1OjAwOjAzLjA6IGJyaWRnZSB3aW5kb3cgW2lvICAweDEwMDAtMHgwZmZmXSB0byBbYnVzIDAy
XSBhZGRfc2l6ZSAxMDAwDQpbICAgMTEuMzA5MDI0XSBwY2kgMDAwNTowMDowMy4wOiBicmlkZ2Ug
d2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMGZmZmZmIDY0Yml0IHByZWZdIHRvIFtidXMgMDJd
IGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMzIwNjA4XSBwY2kgMDAw
NTowMDowMy4wOiBicmlkZ2Ugd2luZG93IFttZW0gMHgwMDEwMDAwMC0weDAwMWZmZmZmXSB0byBb
YnVzIDAyXSBhZGRfc2l6ZSAxMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjMzMTE5MV0g
cGNpIDAwMDU6MDA6MDUuMDogYnJpZGdlIHdpbmRvdyBbaW8gIDB4MTAwMC0weDBmZmZdIHRvIFti
dXMgMDNdIGFkZF9zaXplIDEwMDANClsgICAxMS4zMzk0MDRdIHBjaSAwMDA1OjAwOjA1LjA6IGJy
aWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmYgNjRiaXQgcHJlZl0gdG8gW2J1
cyAwM10gYWRkX3NpemUgMjAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAxMS4zNTA5OTFdIHBj
aSAwMDA1OjAwOjA1LjA6IGJyaWRnZSB3aW5kb3cgW21lbSAweDAwMTAwMDAwLTB4MDAwZmZmZmZd
IHRvIFtidXMgMDNdIGFkZF9zaXplIDIwMDAwMCBhZGRfYWxpZ24gMTAwMDAwDQpbICAgMTEuMzYx
NTczXSBwY2kgMDAwNTowMDowNy4wOiBicmlkZ2Ugd2luZG93IFtpbyAgMHgxMDAwLTB4MGZmZl0g
dG8gW2J1cyAwNF0gYWRkX3NpemUgMTAwMA0KWyAgIDExLjM2OTc4OV0gcGNpIDAwMDU6MDA6MDcu
MDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDBmZmZmZiA2NGJpdCBwcmVmXSB0
byBbYnVzIDA0XSBhZGRfc2l6ZSAyMDAwMDAgYWRkX2FsaWduIDEwMDAwMA0KWyAgIDExLjM4MTM3
OV0gcGNpIDAwMDU6MDA6MDcuMDogYnJpZGdlIHdpbmRvdyBbbWVtIDB4MDAxMDAwMDAtMHgwMDFm
ZmZmZl0gdG8gW2J1cyAwNF0gYWRkX3NpemUgMTAwMDAwIGFkZF9hbGlnbiAxMDAwMDANClsgICAx
MS4zOTE5NTldIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4MzAwMDAw
MDAtMHgzMDFmZmZmZl0NClsgICAxMS4zOTg3NjRdIHBjaSAwMDA1OjAwOjAxLjA6IEJBUiA5OiBh
c3NpZ25lZCBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmMwMDAwMWZmZmZmIDY0Yml0IHByZWZdDQpb
ICAgMTEuNDA3MjkwXSBwY2kgMDAwNTowMDowMy4wOiBCQVIgODogYXNzaWduZWQgW21lbSAweDMw
MjAwMDAwLTB4MzAzZmZmZmZdDQpbICAgMTEuNDE0MTI4XSBwY2kgMDAwNTowMDowMy4wOiBCQVIg
OTogYXNzaWduZWQgW21lbSAweDJjMDAwMDIwMDAwMC0weDJjMDAwMDNmZmZmZiA2NGJpdCBwcmVm
XQ0KWyAgIDExLjQyMjY1NF0gcGNpIDAwMDU6MDA6MDUuMDogQkFSIDg6IGFzc2lnbmVkIFttZW0g
MHgzMDQwMDAwMC0weDMwNWZmZmZmXQ0KWyAgIDExLjQyOTQ5Ml0gcGNpIDAwMDU6MDA6MDUuMDog
QkFSIDk6IGFzc2lnbmVkIFttZW0gMHgyYzAwMDA0MDAwMDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQg
cHJlZl0NClsgICAxMS40MzgwMTldIHBjaSAwMDA1OjAwOjA3LjA6IEJBUiA4OiBhc3NpZ25lZCBb
bWVtIDB4MzA2MDAwMDAtMHgzMDdmZmZmZl0NClsgICAxMS40NDQ4NThdIHBjaSAwMDA1OjAwOjA3
LjA6IEJBUiA5OiBhc3NpZ25lZCBbbWVtIDB4MmMwMDAwNjAwMDAwLTB4MmMwMDAwN2ZmZmZmIDY0
Yml0IHByZWZdDQpbICAgMTEuNDUzMzgzXSBwY2kgMDAwNTowMDowMS4wOiBCQVIgNzogbm8gc3Bh
Y2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNDU5Njk1XSBwY2kgMDAwNTowMDowMS4w
OiBCQVIgNzogZmFpbGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjQ2NjM4
M10gcGNpIDAwMDU6MDA6MDMuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAw
XQ0KWyAgIDExLjQ3Mjc1NV0gcGNpIDAwMDU6MDA6MDMuMDogQkFSIDc6IGZhaWxlZCB0byBhc3Np
Z24gW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS40Nzk0MzZdIHBjaSAwMDA1OjAwOjA1LjA6IEJB
UiA3OiBubyBzcGFjZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS40ODU3NjhdIHBjaSAw
MDA1OjAwOjA1LjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpb
ICAgMTEuNDkyNDYzXSBwY2kgMDAwNTowMDowNy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAg
c2l6ZSAweDEwMDBdDQpbICAgMTEuNDk4Nzg4XSBwY2kgMDAwNTowMDowNy4wOiBCQVIgNzogZmFp
bGVkIHRvIGFzc2lnbiBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjUwNTQ4NF0gcGNpIDAwMDU6
MDA6MDcuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjUx
MTgxM10gcGNpIDAwMDU6MDA6MDcuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXpl
IDB4MTAwMF0NClsgICAxMS41MTg0OTZdIHBjaSAwMDA1OjAwOjA1LjA6IEJBUiA3OiBubyBzcGFj
ZSBmb3IgW2lvICBzaXplIDB4MTAwMF0NClsgICAxMS41MjQ4MjldIHBjaSAwMDA1OjAwOjA1LjA6
IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBdDQpbICAgMTEuNTMxNTIy
XSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogbm8gc3BhY2UgZm9yIFtpbyAgc2l6ZSAweDEwMDBd
DQpbICAgMTEuNTM3ODUwXSBwY2kgMDAwNTowMDowMy4wOiBCQVIgNzogZmFpbGVkIHRvIGFzc2ln
biBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjU0NDU0MF0gcGNpIDAwMDU6MDA6MDEuMDogQkFS
IDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQ0KWyAgIDExLjU1MDg3MF0gcGNpIDAw
MDU6MDA6MDEuMDogQkFSIDc6IGZhaWxlZCB0byBhc3NpZ24gW2lvICBzaXplIDB4MTAwMF0NClsg
ICAxMS41NTc1NjFdIHBjaSAwMDA1OjAwOjAxLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMV0NClsg
ICAxMS41NjI1NzhdIHBjaSAwMDA1OjAwOjAxLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MzAw
MDAwMDAtMHgzMDFmZmZmZl0NClsgICAxMS41Njk0NTVdIHBjaSAwMDA1OjAwOjAxLjA6ICAgYnJp
ZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwMDAwMDAwLTB4MmMwMDAwMWZmZmZmIDY0Yml0IHByZWZd
DQpbICAgMTEuNTc3OTgzXSBwY2kgMDAwNTowMjowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAw
eDMwMjAwMDAwLTB4MzAyMDFmZmYgNjRiaXRdDQpbICAgMTEuNTg1MzU0XSBwY2kgMDAwNTowMDow
My4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDJdDQpbICAgMTEuNTkwMzU0XSBwY2kgMDAwNTowMDow
My4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDMwMjAwMDAwLTB4MzAzZmZmZmZdDQpbICAgMTEu
NTk3MjMxXSBwY2kgMDAwNTowMDowMy4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDJjMDAwMDIw
MDAwMC0weDJjMDAwMDNmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjYwNTc1OF0gcGNpIDAwMDU6
MDA6MDUuMDogUENJIGJyaWRnZSB0byBbYnVzIDAzXQ0KWyAgIDExLjYxMDc1M10gcGNpIDAwMDU6
MDA6MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgzMDQwMDAwMC0weDMwNWZmZmZmXQ0KWyAg
IDExLjYxNzYzMV0gcGNpIDAwMDU6MDA6MDUuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgyYzAw
MDA0MDAwMDAtMHgyYzAwMDA1ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS42MjYxNTldIHBjaSAw
MDA1OjA0OjAwLjA6IEJBUiAwOiBhc3NpZ25lZCBbbWVtIDB4MzA2MDAwMDAtMHgzMDYwM2ZmZiA2
NGJpdF0NClsgICAxMS42MzM1MzBdIHBjaSAwMDA1OjAwOjA3LjA6IFBDSSBicmlkZ2UgdG8gW2J1
cyAwNF0NClsgICAxMS42Mzg1MzBdIHBjaSAwMDA1OjAwOjA3LjA6ICAgYnJpZGdlIHdpbmRvdyBb
bWVtIDB4MzA2MDAwMDAtMHgzMDdmZmZmZl0NClsgICAxMS42NDU0MjZdIHBjaSAwMDA1OjAwOjA3
LjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MmMwMDAwNjAwMDAwLTB4MmMwMDAwN2ZmZmZmIDY0
Yml0IHByZWZdDQpbICAgMTEuNjUzOTM2XSBwY2lfYnVzIDAwMDU6MDA6IHJlc291cmNlIDQgW21l
bSAweDMwMDAwMDAwLTB4M2ZmZmZmZmYgd2luZG93XQ0KWyAgIDExLjY2MDg2M10gcGNpX2J1cyAw
MDA1OjAwOiByZXNvdXJjZSA1IFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyZmZmZGZmZmZmZmYgd2lu
ZG93XQ0KWyAgIDExLjY2ODUwOV0gcGNpX2J1cyAwMDA1OjAxOiByZXNvdXJjZSAxIFttZW0gMHgz
MDAwMDAwMC0weDMwMWZmZmZmXQ0KWyAgIDExLjY3NDgyOV0gcGNpX2J1cyAwMDA1OjAxOiByZXNv
dXJjZSAyIFttZW0gMHgyYzAwMDAwMDAwMDAtMHgyYzAwMDAxZmZmZmYgNjRiaXQgcHJlZl0NClsg
ICAxMS42ODI4MzRdIHBjaV9idXMgMDAwNTowMjogcmVzb3VyY2UgMSBbbWVtIDB4MzAyMDAwMDAt
MHgzMDNmZmZmZl0NClsgICAxMS42ODkxNTJdIHBjaV9idXMgMDAwNTowMjogcmVzb3VyY2UgMiBb
bWVtIDB4MmMwMDAwMjAwMDAwLTB4MmMwMDAwM2ZmZmZmIDY0Yml0IHByZWZdDQpbICAgMTEuNjk3
MTU4XSBwY2lfYnVzIDAwMDU6MDM6IHJlc291cmNlIDEgW21lbSAweDMwNDAwMDAwLTB4MzA1ZmZm
ZmZdDQpbICAgMTEuNzAzNDc1XSBwY2lfYnVzIDAwMDU6MDM6IHJlc291cmNlIDIgW21lbSAweDJj
MDAwMDQwMDAwMC0weDJjMDAwMDVmZmZmZiA2NGJpdCBwcmVmXQ0KWyAgIDExLjcxMTQ4Nl0gcGNp
X2J1cyAwMDA1OjA0OiByZXNvdXJjZSAxIFttZW0gMHgzMDYwMDAwMC0weDMwN2ZmZmZmXQ0KWyAg
IDExLjcxNzc5OV0gcGNpX2J1cyAwMDA1OjA0OiByZXNvdXJjZSAyIFttZW0gMHgyYzAwMDA2MDAw
MDAtMHgyYzAwMDA3ZmZmZmYgNjRiaXQgcHJlZl0NClsgICAxMS43MjYwNDVdIHhlbjpiYWxsb29u
OiBJbml0aWFsaXNpbmcgYmFsbG9vbiBkcml2ZXINClsgICAxMS43MzEwMThdIGlvbW11OiBEZWZh
dWx0IGRvbWFpbiB0eXBlOiBUcmFuc2xhdGVkIA0KWyAgIDExLjczNTk3Nl0gcGNpIDAwMGQ6MDE6
MDAuMDogdmdhYXJiOiBWR0EgZGV2aWNlIGFkZGVkOiBkZWNvZGVzPWlvK21lbSxvd25zPW5vbmUs
bG9ja3M9bm9uZQ0KWyAgIDExLjc0NDM4Nl0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBWR0Eg
ZGV2aWNlIGFkZGVkOiBkZWNvZGVzPWlvK21lbSxvd25zPW5vbmUsbG9ja3M9bm9uZQ0KWyAgIDEx
Ljc1Mjc5OF0gcGNpIDAwMGQ6MDE6MDAuMDogdmdhYXJiOiBicmlkZ2UgY29udHJvbCBwb3NzaWJs
ZQ0KWyAgIDExLjc1ODU4Ml0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBicmlkZ2UgY29udHJv
bCBwb3NzaWJsZQ0KWyAgIDExLjc2NDM5OF0gcGNpIDAwMDQ6MDI6MDAuMDogdmdhYXJiOiBzZXR0
aW5nIGFzIGJvb3QgZGV2aWNlIChWR0EgbGVnYWN5IHJlc291cmNlcyBub3QgYXZhaWxhYmxlKQ0K
WyAgIDExLjc3MzM3NV0gdmdhYXJiOiBsb2FkZWQNClsgICAxMS43NzYxNjddIFNDU0kgc3Vic3lz
dGVtIGluaXRpYWxpemVkDQpbICAgMTEuNzc5OTE2XSBBQ1BJOiBidXMgdHlwZSBVU0IgcmVnaXN0
ZXJlZA0KWyAgIDExLjc4NDAxMV0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRy
aXZlciB1c2Jmcw0KWyAgIDExLjc4OTU3NV0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJm
YWNlIGRyaXZlciBodWINClsgICAxMS43OTQ5NjJdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGRl
dmljZSBkcml2ZXIgdXNiDQpbICAgMTEuODAwMDgwXSBwcHNfY29yZTogTGludXhQUFMgQVBJIHZl
ci4gMSByZWdpc3RlcmVkDQpbICAgMTEuODA1MDk3XSBwcHNfY29yZTogU29mdHdhcmUgdmVyLiA1
LjMuNiAtIENvcHlyaWdodCAyMDA1LTIwMDcgUm9kb2xmbyBHaW9tZXR0aSA8Z2lvbWV0dGlAbGlu
dXguaXQ+DQpbICAgMTEuODE0MzQ5XSBQVFAgY2xvY2sgc3VwcG9ydCByZWdpc3RlcmVkDQpbICAg
MTEuODE4NDA0XSBSZWdpc3RlcmVkIGVmaXZhcnMgb3BlcmF0aW9ucw0KWyAgIDExLjgyMjM4NF0g
Tm8gQUNQSSBQTVUgSVJRIGZvciBDUFUwDQpbICAgMTEuODI1OTk2XSBObyBBQ1BJIFBNVSBJUlEg
Zm9yIENQVTENClsgICAxMS44Mjk2NDldIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BVMg0KWyAgIDEx
LjgzMzI4N10gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFUzDQpbICAgMTEuODM2OTQwXSBObyBBQ1BJ
IFBNVSBJUlEgZm9yIENQVTQNClsgICAxMS44NDA1NzldIE5vIEFDUEkgUE1VIElSUSBmb3IgQ1BV
NQ0KWyAgIDExLjg0NDIzMV0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFU2DQpbICAgMTEuODQ3ODcw
XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTcNClsgICAxMS44NTE1MjhdIE5vIEFDUEkgUE1VIElS
USBmb3IgQ1BVOA0KWyAgIDExLjg1NTE2Ml0gTm8gQUNQSSBQTVUgSVJRIGZvciBDUFU5DQpbICAg
MTEuODU4ODE0XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTEwDQpbICAgMTEuODYyNTQyXSBObyBB
Q1BJIFBNVSBJUlEgZm9yIENQVTExDQpbICAgMTEuODY2MjgwXSBObyBBQ1BJIFBNVSBJUlEgZm9y
IENQVTEyDQpbICAgMTEuODcwMDA3XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTEzDQpbICAgMTEu
ODczNzQ2XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTE0DQpbICAgMTEuODc3NDcyXSBObyBBQ1BJ
IFBNVSBJUlEgZm9yIENQVTE1DQpbICAgMTEuODgxMjExXSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQ
VTE2DQpbICAgMTEuODg0OTM3XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTE3DQpbICAgMTEuODg4
Njc2XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTE4DQpbICAgMTEuODkyNDAzXSBObyBBQ1BJIFBN
VSBJUlEgZm9yIENQVTE5DQpbICAgMTEuODk2MTQyXSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTIw
DQpbICAgMTEuODk5ODY4XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTIxDQpbICAgMTEuOTAzNjA4
XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTIyDQpbICAgMTEuOTA3MzMzXSBObyBBQ1BJIFBNVSBJ
UlEgZm9yIENQVTIzDQpbICAgMTEuOTExMDczXSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTI0DQpb
ICAgMTEuOTE0Nzk4XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTI1DQpbICAgMTEuOTE4NTM5XSBO
byBBQ1BJIFBNVSBJUlEgZm9yIENQVTI2DQpbICAgMTEuOTIyMjY0XSBObyBBQ1BJIFBNVSBJUlEg
Zm9yIENQVTI3DQpbICAgMTEuOTI2MDA0XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTI4DQpbICAg
MTEuOTI5NzI5XSBObyBBQ1BJIFBNVSBJUlEgZm9yIENQVTI5DQpbICAgMTEuOTMzNDY5XSBObyBB
Q1BJIFBNVSBJUlEgZm9yIENQVTMwDQpbICAgMTEuOTM3MTk0XSBObyBBQ1BJIFBNVSBJUlEgZm9y
IENQVTMxDQpbICAgMTEuOTQyMzE0XSBjbG9ja3NvdXJjZTogU3dpdGNoZWQgdG8gY2xvY2tzb3Vy
Y2UgYXJjaF9zeXNfY291bnRlcg0KWyAgIDEyLjEyMzc1MF0gcG5wOiBQblAgQUNQSSBpbml0DQpb
ICAgMTIuMTI4MTI5XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgzYmZmZjAwMDAwMDAtMHgzYmZmZmZm
ZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjEzNjA0NV0gc3lzdGVtIDAw
OjAwOiBbbWVtIDB4M2ZmZmYwMDAwMDAwLTB4M2ZmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90
IGJlIHJlc2VydmVkDQpbICAgMTIuMTQ0Mzc2XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgyM2ZmZjAw
MDAwMDAtMHgyM2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjE1
MjM1OV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MjdmZmYwMDAwMDAwLTB4MjdmZmZmZmZmZmZmIHdp
bmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsgICAxMi4xNjAzNDddIHN5c3RlbSAwMDowMDogW21l
bSAweDJiZmZmMDAwMDAwMC0weDJiZmZmZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNl
cnZlZA0KWyAgIDEyLjE2ODY4MV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4MmZmZmYwMDAwMDAwLTB4
MmZmZmZmZmZmZmZmIHdpbmRvd10gY291bGQgbm90IGJlIHJlc2VydmVkDQpbICAgMTIuMTc3MDE0
XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHg3YmZmZjAwMDAwMDAtMHg3YmZmZmZmZmZmZmYgd2luZG93
XSBoYXMgYmVlbiByZXNlcnZlZA0KWyAgIDEyLjE4NDk5NV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4
N2ZmZmYwMDAwMDAwLTB4N2ZmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsg
ICAxMi4xOTI5ODJdIHN5c3RlbSAwMDowMDogW21lbSAweDYzZmZmMDAwMDAwMC0weDYzZmZmZmZm
ZmZmZiB3aW5kb3ddIGhhcyBiZWVuIHJlc2VydmVkDQpbICAgMTIuMjAwOTcxXSBzeXN0ZW0gMDA6
MDA6IFttZW0gMHg2N2ZmZjAwMDAwMDAtMHg2N2ZmZmZmZmZmZmYgd2luZG93XSBoYXMgYmVlbiBy
ZXNlcnZlZA0KWyAgIDEyLjIwODk1NV0gc3lzdGVtIDAwOjAwOiBbbWVtIDB4NmJmZmYwMDAwMDAw
LTB4NmJmZmZmZmZmZmZmIHdpbmRvd10gaGFzIGJlZW4gcmVzZXJ2ZWQNClsgICAxMi4yMTY5NDFd
IHN5c3RlbSAwMDowMDogW21lbSAweDZmZmZmMDAwMDAwMC0weDZmZmZmZmZmZmZmZiB3aW5kb3dd
IGhhcyBiZWVuIHJlc2VydmVkDQpbICAgMTIuMjI0OTI3XSBzeXN0ZW0gMDA6MDA6IFttZW0gMHgz
M2ZmZjAwMDAwMDAtMHgzM2ZmZmZmZmZmZmYgd2luZG93XSBjb3VsZCBub3QgYmUgcmVzZXJ2ZWQN
ClsgICAxMi4yMzMyNjZdIHN5c3RlbSAwMDowMDogW21lbSAweDM3ZmZmMDAwMDAwMC0weDM3ZmZm
ZmZmZmZmZiB3aW5kb3ddIGNvdWxkIG5vdCBiZSByZXNlcnZlZA0KWyAgIDEyLjI0MTYxMF0gcG5w
OiBQblAgQUNQSTogZm91bmQgMSBkZXZpY2VzDQpbICAgMTIuMjQ4ODg4XSBORVQ6IFJlZ2lzdGVy
ZWQgcHJvdG9jb2wgZmFtaWx5IDINClsgICAxMi4yNTM0MDBdIHRjcF9saXN0ZW5fcG9ydGFkZHJf
aGFzaCBoYXNoIHRhYmxlIGVudHJpZXM6IDQwOTYgKG9yZGVyOiA0LCA2NTUzNiBieXRlcywgbGlu
ZWFyKQ0KWyAgIDEyLjI2MjAwMF0gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUgZW50cmllczog
NjU1MzYgKG9yZGVyOiA3LCA1MjQyODggYnl0ZXMsIGxpbmVhcikNClsgICAxMi4yNzAxNDZdIFRD
UCBiaW5kIGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA4LCAxMDQ4NTc2IGJ5dGVz
LCBsaW5lYXIpDQpbICAgMTIuMjc4MDA2XSBUQ1A6IEhhc2ggdGFibGVzIGNvbmZpZ3VyZWQgKGVz
dGFibGlzaGVkIDY1NTM2IGJpbmQgNjU1MzYpDQpbICAgMTIuMjg0NTgyXSBVRFAgaGFzaCB0YWJs
ZSBlbnRyaWVzOiA0MDk2IChvcmRlcjogNSwgMTMxMDcyIGJ5dGVzLCBsaW5lYXIpDQpbICAgMTIu
MjkxNDU5XSBVRFAtTGl0ZSBoYXNoIHRhYmxlIGVudHJpZXM6IDQwOTYgKG9yZGVyOiA1LCAxMzEw
NzIgYnl0ZXMsIGxpbmVhcikNClsgICAxMi4yOTg4ODNdIE5FVDogUmVnaXN0ZXJlZCBwcm90b2Nv
bCBmYW1pbHkgMQ0KWyAgIDEyLjMwMzQ4OF0gUlBDOiBSZWdpc3RlcmVkIG5hbWVkIFVOSVggc29j
a2V0IHRyYW5zcG9ydCBtb2R1bGUuDQpbICAgMTIuMzA5MzgyXSBSUEM6IFJlZ2lzdGVyZWQgdWRw
IHRyYW5zcG9ydCBtb2R1bGUuDQpbICAgMTIuMzE0MTM0XSBSUEM6IFJlZ2lzdGVyZWQgdGNwIHRy
YW5zcG9ydCBtb2R1bGUuDQpbICAgMTIuMzE4OTA3XSBSUEM6IFJlZ2lzdGVyZWQgdGNwIE5GU3Y0
LjEgYmFja2NoYW5uZWwgdHJhbnNwb3J0IG1vZHVsZS4NClsgICAxMi4zMjU0ODldIHBjaSAwMDBk
OjAxOjAwLjE6IEQwIHBvd2VyIHN0YXRlIGRlcGVuZHMgb24gMDAwZDowMTowMC4wDQpbICAgMTIu
MzMxOTE5XSBwY2kgMDAwZDowMTowMC4yOiBEMCBwb3dlciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6
MDE6MDAuMA0KWyAgIDEyLjMzODMyOF0gcGNpIDAwMGQ6MDE6MDAuMjogZW5hYmxpbmcgZGV2aWNl
ICgwMDAwIC0+IDAwMDIpDQpbICAgMTIuMzQ0MDY4XSBwY2kgMDAwZDowMTowMC4zOiBEMCBwb3dl
ciBzdGF0ZSBkZXBlbmRzIG9uIDAwMGQ6MDE6MDAuMA0KWyAgIDEyLjM1MDQ5OF0gcGNpIDAwMDQ6
MDM6MDAuMDogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDIpDQpbICAgMTIuMzU2MjA1XSBw
Y2kgMDAwNTowMjowMC4wOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikNClsgICAxMi4z
NjE5MTRdIFBDSTogQ0xTIDEyOCBieXRlcywgZGVmYXVsdCA2NA0KWyAgIDEyLjM2ODUxNV0gaHcg
cGVyZmV2ZW50czogZW5hYmxlZCB3aXRoIGFybXY4X3BtdXYzXzAgUE1VIGRyaXZlciwgMSBjb3Vu
dGVycyBhdmFpbGFibGUNClsgICAxMi4zNzg3OTNdIHdvcmtpbmdzZXQ6IHRpbWVzdGFtcF9iaXRz
PTQyIG1heF9vcmRlcj0yMSBidWNrZXRfb3JkZXI9MA0KWyAgIDEyLjM4Njk5OF0gTkZTOiBSZWdp
c3RlcmluZyB0aGUgaWRfcmVzb2x2ZXIga2V5IHR5cGUNClsgICAxMi4zOTIwMTddIEtleSB0eXBl
IGlkX3Jlc29sdmVyIHJlZ2lzdGVyZWQNClsgICAxMi4zOTYyNTBdIEtleSB0eXBlIGlkX2xlZ2Fj
eSByZWdpc3RlcmVkDQpbICAgMTIuNDAwNzQwXSBLZXkgdHlwZSBjaWZzLmlkbWFwIHJlZ2lzdGVy
ZWQNClsgICAxMi40MTk1ODhdIHhvcjogbWVhc3VyaW5nIHNvZnR3YXJlIGNoZWNrc3VtIHNwZWVk
DQpbICAgMTIuNDI1MzQyXSAgICA4cmVncyAgICAgICAgICAgOiAgOTc5NyBNQi9zZWMNClsgICAx
Mi40MzA0OTFdICAgIDMycmVncyAgICAgICAgICA6IDExNzQ5IE1CL3NlYw0KWyAgIDEyLjQzNTQ5
N10gICAgYXJtNjRfbmVvbiAgICAgIDogMTQwMzQgTUIvc2VjDQpbICAgMTIuNDM5ODA0XSB4b3I6
IHVzaW5nIGZ1bmN0aW9uOiBhcm02NF9uZW9uICgxNDAzNCBNQi9zZWMpDQpbICAgMTIuNDQ1Mzgx
XSBCbG9jayBsYXllciBTQ1NJIGdlbmVyaWMgKGJzZykgZHJpdmVyIHZlcnNpb24gMC40IGxvYWRl
ZCAobWFqb3IgMjQ5KQ0KWyAgIDEyLjQ1Mjg2MF0gaW8gc2NoZWR1bGVyIG1xLWRlYWRsaW5lIHJl
Z2lzdGVyZWQNClsgICAxMi40NTc0MjZdIGlvIHNjaGVkdWxlciBreWJlciByZWdpc3RlcmVkDQpb
ICAgMTIuNDYyODQyXSBncGlvLWR3YXBiIEFQTUMwRDA3OjAyOiBubyBJUlEgZm9yIHBvcnQwDQpb
ICAgMTIuNDY4NzU4XSBpbnB1dDogUG93ZXIgQnV0dG9uIGFzIC9kZXZpY2VzL0xOWFNZU1RNOjAw
L0xOWFNZQlVTOjAwL1BOUDBDMEM6MDAvaW5wdXQvaW5wdXQwDQpbICAgMTIuNDc3MTM5XSBBQ1BJ
OiBQb3dlciBCdXR0b24gW1BXUkJdDQpbICAgMTIuNDgxNTQzXSBHSEVTOiBBUEVJIGZpcm13YXJl
IGZpcnN0IG1vZGUgaXMgZW5hYmxlZCBieSBBUEVJIGJpdC4NClsgICAxMi40ODc3NDFdIEVJTko6
IEVycm9yIElOSmVjdGlvbiBpcyBpbml0aWFsaXplZC4NClsgICAxMi40OTI0OTFdIEFDUEkgR1RE
VDogZm91bmQgMSBTQlNBIGdlbmVyaWMgV2F0Y2hkb2cocykuDQpbICAgMTIuNDk4MzY0XSB4ZW46
eGVuX2V2dGNobjogRXZlbnQtY2hhbm5lbCBkZXZpY2UgaW5zdGFsbGVkDQpbICAgMTIuNTA0NTA4
XSBhc3QgMDAwNDowMjowMC4wOiBbZHJtXSBwbGF0Zm9ybSBoYXMgbm8gSU8gc3BhY2UsIHRyeWlu
ZyBNTUlPDQpbICAgMTIuNTExMjkzXSBhc3QgMDAwNDowMjowMC4wOiBbZHJtXSBVc2luZyBQMkEg
YnJpZGdlIGZvciBjb25maWd1cmF0aW9uDQpbICAgMTIuNTE3ODcyXSBhc3QgMDAwNDowMjowMC4w
OiBbZHJtXSBBU1QgMjUwMCBkZXRlY3RlZA0KWyAgIDEyLjUyMjk3Nl0gYXN0IDAwMDQ6MDI6MDAu
MDogW2RybV0gQW5hbG9nIFZHQSBvbmx5DQpbICAgMTIuNTI3OTI2XSBhc3QgMDAwNDowMjowMC4w
OiBbZHJtXSBkcmFtIE1DTEs9ODAwIE1oeiB0eXBlPTggYnVzX3dpZHRoPTE2DQpbICAgMTIuNTM0
OTAyXSBbVFRNXSBab25lICBrZXJuZWw6IEF2YWlsYWJsZSBncmFwaGljcyBtZW1vcnk6IDQwNTAy
NTQgS2lCDQpbICAgMTIuNTQxNDAzXSBbVFRNXSBab25lICAgZG1hMzI6IEF2YWlsYWJsZSBncmFw
aGljcyBtZW1vcnk6IDIwOTcxNTIgS2lCDQpbICAgMTIuNTQ4MDAwXSBbVFRNXSBJbml0aWFsaXpp
bmcgcG9vbCBhbGxvY2F0b3INClsgICAxMi41NTI0MDVdIFtUVE1dIEluaXRpYWxpemluZyBETUEg
cG9vbCBhbGxvY2F0b3INClsgICAxMi41NTc0NzhdIFtkcm1dIEluaXRpYWxpemVkIGFzdCAwLjEu
MCAyMDEyMDIyOCBmb3IgMDAwNDowMjowMC4wIG9uIG1pbm9yIDANClsgICAxMi41ODMzOTFdIENv
bnNvbGU6IHN3aXRjaGluZyB0byBjb2xvdXIgZnJhbWUgYnVmZmVyIGRldmljZSAxMjh4NDgNClsg
ICAxMi41OTE4MjddIGFzdCAwMDA0OjAyOjAwLjA6IFtkcm1dIGZiMDogYXN0ZHJtZmIgZnJhbWUg
YnVmZmVyIGRldmljZQ0KWyAgIDEyLjYxMjg2Ml0gYnJkOiBtb2R1bGUgbG9hZGVkDQpbICAgMTIu
NjIwMzUxXSBsb29wOiBtb2R1bGUgbG9hZGVkDQpbICAgMTIuNjI0MDAxXSBudm1lIG52bWUwOiBw
Y2kgZnVuY3Rpb24gMDAwNTowNDowMC4wDQpbICAgMTIuNjI4OTg3XSBpZ2I6IEludGVsKFIpIEdp
Z2FiaXQgRXRoZXJuZXQgTmV0d29yayBEcml2ZXINClsgICAxMi42MzA4OTddIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT01MTIgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjYzNDM1NV0g
aWdiOiBDb3B5cmlnaHQgKGMpIDIwMDctMjAxNCBJbnRlbCBDb3Jwb3JhdGlvbi4NClsgICAxMi42
NDAzODBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT01MTIgZmxhZ3M9Y2MwIGF0dHI9
MA0KWyAgIDEyLjY1MjY1M10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNp
emU9NTEyIGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi42NTk1MDddIERFQlVHIHhlbl9zd2lvdGxi
X2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjY2
NzE4OV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDUyMDAw
MDAgZGV2X2FkZHI9ODAwMDUyMDAwMDANClsgICAxMi42NzUwOTVdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT0yMDQ4IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi42ODIzNDddIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT0yMDQ4IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi42
ODcyNDldIHBwcyBwcHMwOiBuZXcgUFBTIHNvdXJjZSBwdHAwDQpbICAgMTIuNjg4MzI5XSBERUJV
RyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT0yMDQ4IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxMi42OTI0NDNdIGlnYiAwMDA0OjA0OjAwLjA6IGFkZGVkIFBIQyBvbiBldGgwDQpb
ICAgMTIuNjk5NDQ3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi42OTk0NTNdIERFQlVHIHhlbl9zd2lvdGxiX2Fs
bG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NWQzMDAwIGRldl9hZGRyPTgwMDA1NWQzMDAwDQpb
ICAgMTIuNzA0MDIxXSBpZ2IgMDAwNDowNDowMC4wOiBJbnRlbChSKSBHaWdhYml0IEV0aGVybmV0
IE5ldHdvcmsgQ29ubmVjdGlvbg0KWyAgIDEyLjcxMzIzOV0gREVCVUcgeGVuX3N3aW90bGJfbWFw
X3BhZ2UgNDAwIHBoeXM9ODAwMDU2ZjAwMDAgZGV2X2FkZHI9ODAwMDU2ZjAwMDANClsgICAxMi43
MTkwODBdIGlnYiAwMDA0OjA0OjAwLjA6IGV0aDA6IChQQ0llOjIuNUdiL3M6V2lkdGggeDEpIDAw
OjMwOjY0OjNiOjUwOjUyDQpbICAgMTIuNzE5MTM5XSBpZ2IgMDAwNDowNDowMC4wOiBldGgwOiBQ
QkEgTm86IDAwMDMwMC0wMDANClsgICAxMi43MzM1MjJdIERFQlVHIHhlbl9zd2lvdGxiX21hcF9w
YWdlIDQwMCBwaHlzPTgwMDA1NmYxMDAwIGRldl9hZGRyPTgwMDA1NmYxMDAwDQpbICAgMTIuNzQw
NjgyXSBpZ2IgMDAwNDowNDowMC4wOiBVc2luZyBNU0ktWCBpbnRlcnJ1cHRzLiA0IHJ4IHF1ZXVl
KHMpLCA0IHR4IHF1ZXVlKHMpDQpbICAgMTIuNzQwNzQyXSBpZ2J2ZjogSW50ZWwoUikgR2lnYWJp
dCBWaXJ0dWFsIEZ1bmN0aW9uIE5ldHdvcmsgRHJpdmVyDQpbICAgMTIuNzQ2NTc0XSBudm1lIG52
bWUwOiBtaXNzaW5nIG9yIGludmFsaWQgU1VCTlFOIGZpZWxkLg0KWyAgIDEyLjc1MzM2MF0gaWdi
dmY6IENvcHlyaWdodCAoYykgMjAwOSAtIDIwMTIgSW50ZWwgQ29ycG9yYXRpb24uDQpbICAgMTIu
NzUzMzc2XSBpNDBlOiBJbnRlbChSKSBFdGhlcm5ldCBDb25uZWN0aW9uIFhMNzEwIE5ldHdvcmsg
RHJpdmVyDQpbICAgMTIuNzYxMDMxXSBERUJVRyB4ZW5fc3dpb3RsYl9tYXBfcGFnZSA0MDAgcGh5
cz04MDAwM2E2MGEwMCBkZXZfYWRkcj04MDAwM2E2MGEwMA0KWyAgIDEyLjc2NzMyM10gaTQwZTog
Q29weXJpZ2h0IChjKSAyMDEzIC0gMjAxOSBJbnRlbCBDb3Jwb3JhdGlvbi4NClsgICAxMi43Njc0
ODldIGk0MGUgMDAwMDowMTowMC4wOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAwMikNClsg
ICAxMi43Nzg3MTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT0yNTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDEyLjc5NjQ0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTgx
OTIgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjc5ODQwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTI1NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODA0MjA5XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODEwMTk5
XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT0yNTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDEyLjgxNjI3N10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
Mjg3IHNpemU9ODE5MiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODE2MjgwXSBERUJVRyB4ZW5f
c3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT04MTkyIGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxMi44MjIyNjZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjgyODM0NV0gREVCVUcgeGVuX3N3aW90bGJfYWxs
b2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3MTAwMDAgZGV2X2FkZHI9ODAwMDU3MTAwMDANClsg
ICAxMi44MzUzMDBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgw
MDA1NjkzMDAwIGRldl9hZGRyPTgwMDA1NjkzMDAwDQpbICAgMTIuODQyMzMyXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuODQ5MzYy
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0x
MTANClsgICAxMi44NTYzOTRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxMi44NTYzOTddIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEyLjg2NDM5MF0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwDQpb
ICAgMTIuODcyMzgwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi44Nzg0MzBdIERFQlVHIHhlbl9zd2lvdGxiX2Fs
bG9jX2NvaGVyZW50IDI4NyBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwDQpbICAgMTIu
ODg0OTQ2XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTIw
YjAwMCBkZXZfYWRkcj04MDAwNTIwYjAwMA0KWyAgIDEyLjg5MTAxN10gREVCVUcgeGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDE5NDMwNCBmbGFncz1jYzAgYXR0cj0xMTANClsg
ICAxMi44OTgwNTldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxMi44OTgwNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi45MDQ2ODddIERFQlVHIHhlbl9zd2lvdGxiX2Fs
bG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1ODAwMDAwIGRldl9hZGRyPTgwMDA1ODAwMDAwDQpb
ICAgMTIuOTExNjA0XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi45MTkxOTldIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMA0KWyAgIDEyLjkyNzA2M10gREVC
VUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wDQpbICAgMTIuOTI3MDY2XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMg
cGh5cz04MDAwNTIwYzAwMCBkZXZfYWRkcj04MDAwNTIwYzAwMA0KWyAgIDEyLjkzNDUyMV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQxOTQzMDQgZmxhZ3M9Y2MwIGF0dHI9MTEwDQpb
ICAgMTIuOTQwNTgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTIuOTQwNTg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuOTQ2NjYxXSBERUJVRyB4ZW5fc3dpb3RsYl9h
bGxvY19jb2hlcmVudCAyODcgc2l6ZT00MTk0MzA0IGZsYWdzPWNjMCBhdHRyPTExMA0KWyAgIDEy
Ljk1NDY2OV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTIuOTU0NjcyXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19j
b2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMi45NjE2ODhdIERF
QlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQxOTQzMDQgZmxhZ3M9Y2Mw
IGF0dHI9MTEwDQpbICAgMTIuOTY4MTk3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVu
dCAzMjMgcGh5cz04MDAwNTcxMjAwMCBkZXZfYWRkcj04MDAwNTcxMjAwMA0KWyAgIDEyLjk3NTI0
MF0gVW5hYmxlIHRvIGhhbmRsZSBrZXJuZWwgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIGF0IHZp
cnR1YWwgYWRkcmVzcyAwMDAwMDAwMDAwMDAwMDA4DQpbICAgMTIuOTgzMjI3XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTIuOTg5NzE3
XSBNZW0gYWJvcnQgaW5mbzoNClsgICAxMi45ODk3MThdICAgRVNSID0gMHg5NjAwMDA0NA0KWyAg
IDEyLjk4OTcyMF0gICBFQyA9IDB4MjU6IERBQlQgKGN1cnJlbnQgRUwpLCBJTCA9IDMyIGJpdHMN
ClsgICAxMi45OTU3OTFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAxMy4wMDE4NjRdICAgU0VUID0gMCwgRm5WID0gMA0KWyAgIDEzLjAw
MTg2NV0gICBFQSA9IDAsIFMxUFRXID0gMA0KWyAgIDEzLjAwMTg2OV0gRGF0YSBhYm9ydCBpbmZv
Og0KWyAgIDEzLjAwOTM0OV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMDE2Mzc0XSAgIElTViA9IDAsIElTUyA9
IDB4MDAwMDAwNDQNClsgICAxMy4wMTYzNzRdICAgQ00gPSAwLCBXblIgPSAxDQpbICAgMTMuMDE2
Mzc4XSBbMDAwMDAwMDAwMDAwMDAwOF0gdXNlciBhZGRyZXNzIGJ1dCBhY3RpdmVfbW0gaXMgc3dh
cHBlcg0KWyAgIDEzLjAyMzQwNl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAw
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMDMwODc2XSBJbnRlcm5hbCBlcnJv
cjogT29wczogOTYwMDAwNDQgWyMxXSBQUkVFTVBUIFNNUA0KWyAgIDEzLjAzMDg3OV0gTW9kdWxl
cyBsaW5rZWQgaW46DQpbICAgMTMuMDM4ODc1XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hl
cmVudCAzMjMgcGh5cz04MDAwNTcxMzAwMCBkZXZfYWRkcj04MDAwNTcxMzAwMA0KWyAgIDEzLjA0
Nzc0M10gDQpbICAgMTMuMDQ3NzQ1XSBDUFU6IDIgUElEOiA3IENvbW06IGt3b3JrZXIvdTY0OjAg
VGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTAuMjctYW1wZXJlLWx0cy1zdGFuZGFyZCsg
IzENClsgICAxMy4wNDc3NTZdIFdvcmtxdWV1ZTogbnZtZS1yZXNldC13cSBudm1lX3Jlc2V0X3dv
cmsNClsgICAxMy4wNTM3ODZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxMy4wNTY2MDddIA0KWyAgIDEzLjA1NjYwOV0gcHN0YXRlOiA2
MGMwMDA4NSAoblpDdiBkYUlmICtQQU4gK1VBTyAtVENPIEJUWVBFPS0tKQ0KWyAgIDEzLjA1NjYx
NF0gcGMgOiBzdGVhbF9zdWl0YWJsZV9mYWxsYmFjaysweDEzOC8weDJmMA0KWyAgIDEzLjA1OTcz
NV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0K
WyAgIDEzLjA2NTE0NV0gbHIgOiBzdGVhbF9zdWl0YWJsZV9mYWxsYmFjaysweDFiYy8weDJmMA0K
WyAgIDEzLjA2NTE0OF0gc3AgOiBmZmZmODAwMDExOTZiODEwDQpbICAgMTMuMDcxMjMzXSBERUJV
RyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxMy4wNzQzMTddIHgyOTogZmZmZjgwMDAxMTk2YjgxMCB4Mjg6IDAwMDAwMDAwMDAw
MDAwMDAgDQpbICAgMTMuMDc3NTI3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAz
MDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4wNzc1MjldIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzE0MDAwIGRldl9hZGRyPTgwMDA1
NzE0MDAwDQpbICAgMTMuMDgwNDc4XSB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAgeDI2OiBmZmZmODAw
MDExNGRiY2IwIA0KWyAgIDEzLjA4MDQ3OV0geDI1OiBmZmZmZmRmZmZmZTAwMDAwIHgyNDogMDAw
MDAwMDAwMDAwMDAwMSANClsgICAxMy4wODc1NjVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4wOTE0MjddIA0KWyAgIDEzLjA5MTQy
OF0geDIzOiAwMDAwMDAwMDAwMDAwMDAwIHgyMjogZmZmZmZlMWZmZGY3MDAwMCANClsgICAxMy4w
OTQ0NTddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxMy4xMDA5MjNdIHgyMTogZmZmZjA4MDcxZWZlZjk4MCB4MjA6IDAwMDAwMDAwMDAw
MDA5MDEgDQpbICAgMTMuMTA3OTY0XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAy
ODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4xMTM1ODZdIHgxOTogMDAwMDAw
MDAwMDA4MDAwMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYgDQpbICAgMTMuMTE2NjgwXSBERUJVRyB4
ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxMy4xMjQ3MjhdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAw
MTIgDQpbICAgMTMuMTI2MjA1XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMg
cGh5cz04MDAwNTcxNTAwMCBkZXZfYWRkcj04MDAwNTcxNTAwMA0KWyAgIDEzLjEzNTk0N10geDE1
OiBmZmZmODAwMDkxOTZiOGM3IHgxNDogMDAwMDAwMDAwMDAwMDAwNiANClsgICAxMy4xMzU5NTFd
IHgxMzogZmZmZjgwMDAxMTk2YjhjZiANClsgICAxMy4xNDA5MjRdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4xNDcwMTJdIHgxMjog
MzAzMzM0MzkzMTM0M2Q2NSANClsgICAxMy4xNDcwMTNdIHgxMTogN2E2OTczMjAzMDMwMzMyMCB4
MTA6IDAwMDAwMDAwMDAwMDAwMGMgDQpbICAgMTMuMTQ4NTE2XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMTU0NjUwXSANClsgICAx
My4xNTQ2NTFdIHg5IDogZmZmZjgwMDAxMDAzOWQ1OCB4OCA6IDAwMDAwMDAwODAwMDAwMDAgDQpb
ICAgMTMuMTU5Njc0XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4xNjU3NjJdIHg3IDogMDAwMDAwMDAwMDAwMDAx
OCB4NiA6IGZmZmY4MDAwMTE3NTA4OTAgDQpbICAgMTMuMTcwNzg1XSBERUJVRyB4ZW5fc3dpb3Rs
Yl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4x
NzQxNDddIHg1IDogZmZmZjgwMDAxMTc1MDg3OCB4NCA6IDAwMDAwMDAwMDAwMDAwMDAgDQpbICAg
MTMuMTgxMjI5XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAw
NTcxNjAwMCBkZXZfYWRkcj04MDAwNTcxNjAwMA0KWyAgIDEzLjE4NjU4OF0gDQpbICAgMTMuMTg2
NTg5XSB4MyA6IDAwMDAwMDAwMDAwMDAwMDAgeDIgOiAwMDAwMDAwMDAwMDAwMDAwIA0KWyAgIDEz
LjE5MzY0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDEzLjIwMTYzN10geDEgOiAwMDAwMDAwMDAwMDAwMjAwIHgwIDogMDAwMDAwMDAw
MDAwMDAwMCANClsgICAxMy4yMDY5ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4yMTIzNjddIENhbGwgdHJhY2U6DQpbICAgMTMu
MjEyMzY5XSAgc3RlYWxfc3VpdGFibGVfZmFsbGJhY2srMHgxMzgvMHgyZjANClsgICAxMy4yMTIz
NzRdICBnZXRfcGFnZV9mcm9tX2ZyZWVsaXN0KzB4ZTMwLzB4MTJhMA0KWyAgIDEzLjIxODQ1NV0g
REVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wDQpbICAgMTMuMjE5OTU3XSAgX19hbGxvY19wYWdlc19ub2RlbWFzaysweDE0OC8weGUw
MA0KWyAgIDEzLjIxOTk2NF0gIF9fZG1hX2RpcmVjdF9hbGxvY19wYWdlcysweGE0LzB4MWQwDQpb
ICAgMTMuMjI1Mzk0XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4yMzE0NzVdICBkbWFfZGlyZWN0X2FsbG9jKzB4
MWQ4LzB4MzQwDQpbICAgMTMuMjMxNDgxXSAgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQrMHhj
MC8weDMyOA0KWyAgIDEzLjIzNjg1MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
MzIzIHBoeXM9ODAwMDU3MTcwMDAgZGV2X2FkZHI9ODAwMDU3MTcwMDANClsgICAxMy4yNDM5MDFd
ICBkbWFfYWxsb2NfYXR0cnMrMHgxNDQvMHgxNjANClsgICAxMy4yNDM5MDddICBudm1lX3Jlc2V0
X3dvcmsrMHgxMDMwLzB4MTUyMA0KWyAgIDEzLjI0OTI2Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjI1NjMxN10gIHByb2Nlc3Nf
b25lX3dvcmsrMHgxZGMvMHg0YmMNClsgICAxMy4yNTYzMjFdICB3b3JrZXJfdGhyZWFkKzB4MTQ0
LzB4NDcwDQpbICAgMTMuMjYxNjc1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuMjY5Njk1XSAga3RocmVhZCsweDE0Yy8weDE2MA0K
WyAgIDEzLjI2OTcwMF0gIHJldF9mcm9tX2ZvcmsrMHgxMC8weDM4DQpbICAgMTMuMjc1MDQzXSBE
RUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxMy4yNzg0OTJdIENvZGU6IGE5NDA4MmM0IGQzN2VmNDYzIGNiM2M0MDYzIDhi
M2M0MDQyIChmOTAwMDQ4MCkgDQpbICAgMTMuMjg0NjAxXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy4yODgwMzdd
IC0tLVsgZW5kIHRyYWNlIGY2ODcyOGEwZDMwNTNiNzIgXS0tLQ0KWyAgIDEzLjI4ODA0Ml0gbm90
ZToga3dvcmtlci91NjQ6MFs3XSBleGl0ZWQgd2l0aCBwcmVlbXB0X2NvdW50IDENClsgICAxMy4y
OTM0NDddIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzE4
MDAwIGRldl9hZGRyPTgwMDA1NzE4MDAwDQpbICAgMTMuNDg5OTIzXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNDk1OTc0XSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMu
NTAyMDQ5XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxMy41MDkwOTNdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjUxNjEyOV0gREVC
VUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3MTkwMDAgZGV2X2Fk
ZHI9ODAwMDU3MTkwMDANClsgICAxMy41MjQxMjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy41MzAyMjhdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy41MzYyOTZdIERF
QlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDEzLjU0MzMzOF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAw
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNTUwMzczXSBERUJVRyB4ZW5fc3dp
b3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTcxYTAwMCBkZXZfYWRkcj04MDAwNTcx
YTAwMA0KWyAgIDEzLjU1ODM3MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjU2NDQyMF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
NiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjU3MDQ5N10gREVCVUcgeGVuX3N3
aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTMuNTc3NTQwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy41ODQ1NzJdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9j
X2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzFiMDAwIGRldl9hZGRyPTgwMDA1NzFiMDAwDQpbICAg
MTMuNTkyNTcwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wDQpbICAgMTMuNTk4NjIxXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNjA0Njk4XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy42MTE3NDJd
IERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDEzLjYxODc3NF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
MzIzIHBoeXM9ODAwMDU3MWMwMDAgZGV2X2FkZHI9ODAwMDU3MWMwMDANClsgICAxMy42MjY3NzJd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxMy42MzI4MjNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxMy42Mzg4OTldIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50
IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjY0NTk0Nl0gREVCVUcgeGVu
X3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpb
ICAgMTMuNjUyOTc2XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04
MDAwNTcxZDAwMCBkZXZfYWRkcj04MDAwNTcxZDAwMA0KWyAgIDEzLjY2MDk3M10gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjY2NzAy
NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0K
WyAgIDEzLjY3MzEwMV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNjgwMTQ0XSBERUJVRyB4ZW5fc3dpb3RsYl9h
bGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy42ODcx
NzZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzFlMDAw
IGRldl9hZGRyPTgwMDA1NzFlMDAwDQpbICAgMTMuNjk1MTc0XSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNzAxMjI2XSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNzA3
MzAyXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAxMy43MTQzNDZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVy
ZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjcyMTM4MF0gREVCVUcg
eGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3MWYwMDAgZGV2X2FkZHI9
ODAwMDU3MWYwMDANClsgICAxMy43MjkzNzZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy43MzU0MzBdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy43NDE1MDNdIERFQlVH
IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MA0KWyAgIDEzLjc0ODU0OF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuNzU1NTg1XSBERUJVRyB4ZW5fc3dpb3Rs
Yl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTcyMDAwMCBkZXZfYWRkcj04MDAwNTcyMDAw
MA0KWyAgIDEzLjc2MzU3N10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjc2OTYyOF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjc3NTcwOF0gREVCVUcgeGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMu
NzgyNzQ4XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxMy43ODk3ODBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50IDMyMyBwaHlzPTgwMDA1NzIxMDAwIGRldl9hZGRyPTgwMDA1NzIxMDAwDQpbICAgMTMu
Nzk3Nzc5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wDQpbICAgMTMuODAzODMwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTMuODA5OTA2XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19j
b2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy44MTY5NTBdIERF
QlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDEzLjgyMzk4Ml0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIz
IHBoeXM9ODAwMDU3MjIwMDAgZGV2X2FkZHI9ODAwMDU3MjIwMDANClsgICAxMy44MzE5ODBdIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAx
My44MzgwMzFdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxMy44NDQxMDhdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4
NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjg1MTE1Ml0gREVCVUcgeGVuX3N3
aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTMuODU4MTgzXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAw
NTcyMzAwMCBkZXZfYWRkcj04MDAwNTcyMzAwMA0KWyAgIDEzLjg2NjE4NF0gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjg3MjIzM10g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
IDEzLjg3ODMwOV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuODg1MzU3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy44OTIzODVd
IERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzI0MDAwIGRl
dl9hZGRyPTgwMDA1NzI0MDAwDQpbICAgMTMuOTAwMzgzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuOTA2NDM1XSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuOTEyNTEw
XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxMy45MTk1NTRdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50
IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjkyNjU5MF0gREVCVUcgeGVu
X3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3MjUwMDAgZGV2X2FkZHI9ODAw
MDU3MjUwMDANClsgICAxMy45MzQ1ODRdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy45NDA2MzZdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxMy45NDY3MTJdIERFQlVHIHhl
bl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0K
WyAgIDEzLjk1Mzc1Nl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuOTYwNzg4XSBERUJVRyB4ZW5fc3dpb3RsYl9h
bGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTcyNjAwMCBkZXZfYWRkcj04MDAwNTcyNjAwMA0K
WyAgIDEzLjk2ODc4Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDEzLjk3NDgzN10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDEzLjk4MDkxM10gREVCVUcgeGVuX3N3aW90bGJf
YWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTMuOTg3
OTU3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAxMy45OTQ5ODldIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVy
ZW50IDMyMyBwaHlzPTgwMDA1NzI3MDAwIGRldl9hZGRyPTgwMDA1NzI3MDAwDQpbICAgMTQuMDAy
OTg3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
DQpbICAgMTQuMDA5MDM5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgMTQuMDE1MTE1XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hl
cmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4wMjIxNThdIERFQlVH
IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MA0KWyAgIDE0LjAyOTE5MV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBo
eXM9ODAwMDU3MjgwMDAgZGV2X2FkZHI9ODAwMDU3MjgwMDANClsgICAxNC4wMzcxODldIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4w
NDMyNDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxNC4wNDkzMTZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjA1NjM2M10gREVCVUcgeGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQu
MDYzMzkyXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTcy
OTAwMCBkZXZfYWRkcj04MDAwNTcyOTAwMA0KWyAgIDE0LjA3MTM5MF0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjA3NzQ0MV0gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0
LjA4MzUxOF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMDkwNTYyXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19j
b2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4wOTc1OTRdIERF
QlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzJhMDAwIGRldl9h
ZGRyPTgwMDA1NzJhMDAwDQpbICAgMTQuMTA1NTk1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMy
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMTExNjQzXSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMTE3NzE5XSBE
RUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxNC4xMjQ3NjNdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMw
MCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjEzMTc5Nl0gREVCVUcgeGVuX3N3
aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3MmIwMDAgZGV2X2FkZHI9ODAwMDU3
MmIwMDANClsgICAxNC4xMzk3OTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4xNDU4NDhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4xNTE5MjBdIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
IDE0LjE1ODk2NF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMTY2MDAwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxv
Y19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTcyYzAwMCBkZXZfYWRkcj04MDAwNTcyYzAwMA0KWyAg
IDE0LjE3Mzk5NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDE0LjE4MDA0Nl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjE4NjEyMl0gREVCVUcgeGVuX3N3aW90bGJfYWxs
b2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMTkzMTY1
XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxNC4yMDAxOThdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50
IDMyMyBwaHlzPTgwMDA1NzJkMDAwIGRldl9hZGRyPTgwMDA1NzJkMDAwDQpbICAgMTQuMjA4MTk2
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpb
ICAgMTQuMjE0MjQ3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTQuMjIwMzI0XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVu
dCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4yMjczNjddIERFQlVHIHhl
bl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0K
WyAgIDE0LjIzNDM5OV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9
ODAwMDU3MmUwMDAgZGV2X2FkZHI9ODAwMDU3MmUwMDANClsgICAxNC4yNDIzOThdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4yNDg0
NDldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxNC4yNTQ1MjVdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjI2MTU2OV0gREVCVUcgeGVuX3N3aW90bGJf
YWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMjY4
NjAxXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTcyZjAw
MCBkZXZfYWRkcj04MDAwNTcyZjAwMA0KWyAgIDE0LjI3NjYwMF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjI4MjY1MF0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjI4
ODcyNl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgMTQuMjk1NzczXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hl
cmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4zMDI4MDJdIERFQlVH
IHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzMwMDAwIGRldl9hZGRy
PTgwMDA1NzMwMDAwDQpbICAgMTQuMzEwODAwXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMzE2ODUxXSBERUJVRyBkbWFfYWxsb2Nf
YXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMzIyOTI4XSBERUJV
RyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxNC4zMjk5NzldIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjMzNzAwNV0gREVCVUcgeGVuX3N3aW90
bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3MzEwMDAgZGV2X2FkZHI9ODAwMDU3MzEw
MDANClsgICAxNC4zNDUwMDJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxNC4zNTEwNTNdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC4zNTcxMjldIERFQlVHIHhlbl9zd2lv
dGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0
LjM2NDE3M10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMzcxMjA1XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19j
b2hlcmVudCAzMjMgcGh5cz04MDAwNTczMjAwMCBkZXZfYWRkcj04MDAwNTczMjAwMA0KWyAgIDE0
LjM3OTIwM10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDE0LjM4NTI1NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjM5MTMzMV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2Nf
Y29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuMzk4Mzc1XSBE
RUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxNC40MDU0MDldIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMy
MyBwaHlzPTgwMDA1NzMzMDAwIGRldl9hZGRyPTgwMDA1NzMzMDAwDQpbICAgMTQuNDEzNDA0XSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTQuNDE5NDU2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wDQpbICAgMTQuNDI1NTM1XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAy
ODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC40MzI1NzZdIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
IDE0LjQzOTYwOF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAw
MDU3MzQwMDAgZGV2X2FkZHI9ODAwMDU3MzQwMDANClsgICAxNC40NDc2MDZdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC40NTM2NThd
IERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxNC40NTk3MzRdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjQ2Njc4MF0gREVCVUcgeGVuX3N3aW90bGJfYWxs
b2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNDczODA5
XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTczNTAwMCBk
ZXZfYWRkcj04MDAwNTczNTAwMA0KWyAgIDE0LjQ4MTgwN10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjQ4Nzg1OF0gREVCVUcgZG1h
X2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjQ5Mzkz
NV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTQuNTAwOTc5XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVu
dCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC41MDgwMTFdIERFQlVHIHhl
bl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzM2MDAwIGRldl9hZGRyPTgw
MDA1NzM2MDAwDQpbICAgMTQuNTE2MDEyXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNTIyMDYwXSBERUJVRyBkbWFfYWxsb2NfYXR0
cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNTI4MTM3XSBERUJVRyB4
ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxNC41MzUxODBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjU0MjIxM10gREVCVUcgeGVuX3N3aW90bGJf
YWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3MzcwMDAgZGV2X2FkZHI9ODAwMDU3MzcwMDAN
ClsgICAxNC41NTAyMTBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAxNC41NTYyNjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC41NjIzMzldIERFQlVHIHhlbl9zd2lvdGxi
X2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjU2
OTM4MV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgMTQuNTc2NDE3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hl
cmVudCAzMjMgcGh5cz04MDAwNTczODAwMCBkZXZfYWRkcj04MDAwNTczODAwMA0KWyAgIDE0LjU4
NDQxMl0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MA0KWyAgIDE0LjU5MDQ2M10gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjU5NjU0MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29o
ZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNjAzNTgzXSBERUJV
RyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxNC42MTA2MTVdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBw
aHlzPTgwMDA1NzM5MDAwIGRldl9hZGRyPTgwMDA1NzM5MDAwDQpbICAgMTQuNjE4NjEzXSBERUJV
RyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQu
NjI0NjY1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wDQpbICAgMTQuNjMwNzQxXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC42Mzc3ODRdIERFQlVHIHhlbl9zd2lv
dGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0
LjY0NDgxN10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3
M2EwMDAgZGV2X2FkZHI9ODAwMDU3M2EwMDANClsgICAxNC42NTI4MTVdIERFQlVHIGRtYV9hbGxv
Y19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC42NTg4NjddIERF
QlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAx
NC42NjQ5NDJdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjY3MTk4Nl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2Nf
Y29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNjc5MDE4XSBE
RUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTczYjAwMCBkZXZf
YWRkcj04MDAwNTczYjAwMA0KWyAgIDE0LjY4NzAxNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQz
MiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjY5MzA2N10gREVCVUcgZG1hX2Fs
bG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjY5OTE0NF0g
REVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wDQpbICAgMTQuNzA2MTkwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAz
MDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC43MTMyMTldIERFQlVHIHhlbl9z
d2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzNjMDAwIGRldl9hZGRyPTgwMDA1
NzNjMDAwDQpbICAgMTQuNzIxMjE4XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5
NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNzI3MjY5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMg
NDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuNzMzMzQ1XSBERUJVRyB4ZW5f
c3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxNC43NDAzODldIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0Ljc0NzQyMl0gREVCVUcgeGVuX3N3aW90bGJfYWxs
b2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3M2QwMDAgZGV2X2FkZHI9ODAwMDU3M2QwMDANClsg
ICAxNC43NTU0MjJdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNj
MCBhdHRyPTANClsgICAxNC43NjE0NzBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC43Njc1NDZdIERFQlVHIHhlbl9zd2lvdGxiX2Fs
bG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0Ljc3NDU5
MF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTQuNzgxNjIyXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVu
dCAzMjMgcGh5cz04MDAwNTczZTAwMCBkZXZfYWRkcj04MDAwNTczZTAwMA0KWyAgIDE0Ljc4OTYy
MV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0K
WyAgIDE0Ljc5NTY3NF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDE0LjgwMTc0OF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJl
bnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuODA4NzkxXSBERUJVRyB4
ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxNC44MTU4MjZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlz
PTgwMDA1NzNmMDAwIGRldl9hZGRyPTgwMDA1NzNmMDAwDQpbICAgMTQuODIzODIxXSBERUJVRyBk
bWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuODI5
ODczXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
DQpbICAgMTQuODM1OTUwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC44NDI5OTNdIERFQlVHIHhlbl9zd2lvdGxi
X2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0Ljg1
MDAyNV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3NDAw
MDAgZGV2X2FkZHI9ODAwMDU3NDAwMDANClsgICAxNC44NTgwMjNdIERFQlVHIGRtYV9hbGxvY19h
dHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC44NjQwNzRdIERFQlVH
IGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC44
NzAxNTFdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDE0Ljg3NzE5NV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29o
ZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuODg0MjI2XSBERUJV
RyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTc0MTAwMCBkZXZfYWRk
cj04MDAwNTc0MTAwMA0KWyAgIDE0Ljg5MjIyNV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBz
aXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0Ljg5ODI3Nl0gREVCVUcgZG1hX2FsbG9j
X2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0LjkwNDM1Ml0gREVC
VUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wDQpbICAgMTQuOTExMzk2XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAg
c2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC45MTg0MjhdIERFQlVHIHhlbl9zd2lv
dGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzQyMDAwIGRldl9hZGRyPTgwMDA1NzQy
MDAwDQpbICAgMTQuOTI2NDI5XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBm
bGFncz1jYzAgYXR0cj0wDQpbICAgMTQuOTMyNDc3XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTQuOTM4NTU0XSBERUJVRyB4ZW5fc3dp
b3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAx
NC45NDU2MDBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYg
ZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0Ljk1MjYyOV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2Nf
Y29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3NDMwMDAgZGV2X2FkZHI9ODAwMDU3NDMwMDANClsgICAx
NC45NjA2MjddIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBh
dHRyPTANClsgICAxNC45NjY2NzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNC45NzI3NTVdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9j
X2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE0Ljk3OTc5OV0g
REVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAg
YXR0cj0wDQpbICAgMTQuOTg2ODM0XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAz
MjMgcGh5cz04MDAwNTc0NDAwMCBkZXZfYWRkcj04MDAwNTc0NDAwMA0KWyAgIDE0Ljk5NDgyOV0g
REVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAg
IDE1LjAwMDg4MF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDE1LjAwNjk1N10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
Mjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuMDE0MDAwXSBERUJVRyB4ZW5f
c3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsg
ICAxNS4wMjEwMzJdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgw
MDA1NzQ1MDAwIGRldl9hZGRyPTgwMDA1NzQ1MDAwDQpbICAgMTUuMDI5MDMwXSBERUJVRyBkbWFf
YWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuMDM1MDgx
XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpb
ICAgMTUuMDQxMTU4XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4wNDgyMDFdIERFQlVHIHhlbl9zd2lvdGxiX2Fs
bG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjA1NTIz
M10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3NDYwMDAg
ZGV2X2FkZHI9ODAwMDU3NDYwMDANClsgICAxNS4wNjMyMzFdIERFQlVHIGRtYV9hbGxvY19hdHRy
cyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4wNjkyODNdIERFQlVHIGRt
YV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4wNzUz
NjJdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDE1LjA4MjQwM10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJl
bnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuMDg5NDM1XSBERUJVRyB4
ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTc0NzAwMCBkZXZfYWRkcj04
MDAwNTc0NzAwMA0KWyAgIDE1LjA5NzQzNF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXpl
PTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjEwMzQ4NF0gREVCVUcgZG1hX2FsbG9jX2F0
dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjEwOTU2MV0gREVCVUcg
eGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
DQpbICAgMTUuMTE2NjA4XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6
ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4xMjM2MzZdIERFQlVHIHhlbl9zd2lvdGxi
X2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzQ4MDAwIGRldl9hZGRyPTgwMDA1NzQ4MDAw
DQpbICAgMTUuMTMxNjM1XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFn
cz1jYzAgYXR0cj0wDQpbICAgMTUuMTM3Njg2XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuMTQzNzYyXSBERUJVRyB4ZW5fc3dpb3Rs
Yl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4x
NTA4MDZdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxh
Z3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjE1NzgzOV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29o
ZXJlbnQgMzIzIHBoeXM9ODAwMDU3NDkwMDAgZGV2X2FkZHI9ODAwMDU3NDkwMDANClsgICAxNS4x
NjU4MzldIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRy
PTANClsgICAxNS4xNzE4ODhdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZs
YWdzPWNjMCBhdHRyPTANClsgICAxNS4xNzc5NjRdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjE4NTAwN10gREVC
VUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0
cj0wDQpbICAgMTUuMTkyMDQwXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMg
cGh5cz04MDAwNTc0YTAwMCBkZXZfYWRkcj04MDAwNTc0YTAwMA0KWyAgIDE1LjIwMDAzN10gREVC
VUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1
LjIwNjA4OV0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0
dHI9MA0KWyAgIDE1LjIxMjE2NV0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3
IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuMjE5MjA5XSBERUJVRyB4ZW5fc3dp
b3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAx
NS4yMjYyNDNdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1
NzRiMDAwIGRldl9hZGRyPTgwMDA1NzRiMDAwDQpbICAgMTUuMjM0MjM5XSBERUJVRyBkbWFfYWxs
b2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuMjQwMjkwXSBE
RUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAg
MTUuMjQ2MzY3XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2
IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4yNTM0MTBdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9j
X2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjI2MDQ0M10g
REVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzIzIHBoeXM9ODAwMDU3NGMwMDAgZGV2
X2FkZHI9ODAwMDU3NGMwMDANClsgICAxNS4yNjg0NDBdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0
MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4yNzQ0OTJdIERFQlVHIGRtYV9h
bGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4yODA1Njhd
IERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2Mw
IGF0dHI9MA0KWyAgIDE1LjI4NzYxMl0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
MzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuMjk0NjQ0XSBERUJVRyB4ZW5f
c3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5cz04MDAwNTc0ZDAwMCBkZXZfYWRkcj04MDAw
NTc0ZDAwMA0KWyAgIDE1LjMwMjY0Ml0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQw
OTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjMwODY5M10gREVCVUcgZG1hX2FsbG9jX2F0dHJz
IDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjMxNDc2OV0gREVCVUcgeGVu
X3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpb
ICAgMTUuMzIxODEzXSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00
MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4zMjg4NDVdIERFQlVHIHhlbl9zd2lvdGxiX2Fs
bG9jX2NvaGVyZW50IDMyMyBwaHlzPTgwMDA1NzRlMDAwIGRldl9hZGRyPTgwMDA1NzRlMDAwDQpb
ICAgMTUuMzM2ODQzXSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDMyIHNpemU9NDA5NiBmbGFncz1j
YzAgYXR0cj0wDQpbICAgMTUuMzQyODk0XSBERUJVRyBkbWFfYWxsb2NfYXR0cnMgNDM2IHNpemU9
NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuMzQ4OTc2XSBERUJVRyB4ZW5fc3dpb3RsYl9h
bGxvY19jb2hlcmVudCAyODcgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAxNS4zNTYw
MThdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50IDMwMCBzaXplPTQwOTYgZmxhZ3M9
Y2MwIGF0dHI9MA0KWyAgIDE1LjM2MzA0N10gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJl
bnQgMzIzIHBoeXM9ODAwMDU3NGYwMDAgZGV2X2FkZHI9ODAwMDU3NGYwMDANClsgICAxNS4zNzEw
NDVdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzIgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTAN
ClsgICAxNS4zNzcwOTZdIERFQlVHIGRtYV9hbGxvY19hdHRycyA0MzYgc2l6ZT00MDk2IGZsYWdz
PWNjMCBhdHRyPTANClsgICAxNS4zODMxNzJdIERFQlVHIHhlbl9zd2lvdGxiX2FsbG9jX2NvaGVy
ZW50IDI4NyBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjM5MDIxNl0gREVCVUcg
eGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMzAwIHNpemU9NDA5NiBmbGFncz1jYzAgYXR0cj0w
DQpbICAgMTUuMzk3MjQ4XSBERUJVRyB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudCAzMjMgcGh5
cz04MDAwNTc1MDAwMCBkZXZfYWRkcj04MDAwNTc1MDAwMA0KWyAgIDE1LjQwNTI0Nl0gREVCVUcg
ZG1hX2FsbG9jX2F0dHJzIDQzMiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9MA0KWyAgIDE1LjQx
MTI5OF0gREVCVUcgZG1hX2FsbG9jX2F0dHJzIDQzNiBzaXplPTQwOTYgZmxhZ3M9Y2MwIGF0dHI9
MA0KWyAgIDE1LjQxNzM3NF0gREVCVUcgeGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgMjg3IHNp
emU9NDA5NiBmbGFncz1jYzAgYXR0cj0wDQpbICAgMTUuNDI0NDE4XSBERUJVRyB4ZW5fc3dpb3Rs
Yl9hbGxvY19jb2hlcmVudCAzMDAgc2l6ZT00MDk2IGZsYWdzPWNjMCBhdHRyPTANClsgICAzNC4z
MTAzMTZdIHJjdTogSU5GTzogcmN1X3ByZWVtcHQgZGV0ZWN0ZWQgc3RhbGxzIG9uIENQVXMvdGFz
a3M6DQpbICAgMzQuMzE2Mzk5XSByY3U6IAk2LS4uLjA6ICg0IEdQcyBiZWhpbmQpIGlkbGU9NDFl
LzEvMHg0MDAwMDAwMDAwMDAwMDAwIHNvZnRpcnE9MzcvMzcgZnFzPTI2MjYgDQpbICAgMzQuMzI1
MTEzXSAJKGRldGVjdGVkIGJ5IDIsIHQ9NTI1NCBqaWZmaWVzLCBnPS0xMDc5LCBxPTIpDQoNCg==

--_007_5C7EC3F4912646E8932160878357F939armcom_--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 11:40:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 11:40:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309176.525195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh8gn-0000GB-16; Wed, 20 Apr 2022 11:40:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309176.525195; Wed, 20 Apr 2022 11:40:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh8gm-0000FO-SI; Wed, 20 Apr 2022 11:40:04 +0000
Received: by outflank-mailman (input) for mailman id 309176;
 Wed, 20 Apr 2022 11:40:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Vn5Q=U6=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nh8gl-0008L2-Af
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 11:40:03 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2062e.outbound.protection.outlook.com
 [2a01:111:f400:7d00::62e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9c7a682b-c09e-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 13:40:01 +0200 (CEST)
Received: from DB6PR0801CA0057.eurprd08.prod.outlook.com (2603:10a6:4:2b::25)
 by VE1PR08MB5279.eurprd08.prod.outlook.com (2603:10a6:803:105::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 11:39:58 +0000
Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:2b:cafe::5) by DB6PR0801CA0057.outlook.office365.com
 (2603:10a6:4:2b::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Wed, 20 Apr 2022 11:39:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Wed, 20 Apr 2022 11:39:57 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Wed, 20 Apr 2022 11:39:57 +0000
Received: from df13a4d2d43d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 012E1442-3618-4C28-83A1-56A98B29D987.1; 
 Wed, 20 Apr 2022 11:39:51 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id df13a4d2d43d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 11:39:51 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM5PR0801MB2003.eurprd08.prod.outlook.com (2603:10a6:203:4a::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 11:39:49 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 11:39:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c7a682b-c09e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vq29JU5HqLpTKWLUnR//8mgad/hctLEy9EqjMTuIe6c=;
 b=5V30OvavXlK9b8V4E4nvuTEwi3Ld7EtLoD1RqNq7pjqPm8urzcMf7KLISLDFUpMlnl/etDkfSMtUrNXv1J1J66SlyTsyQbPjtZxSRPSWe1IoBDsUw9xlZXClaKhx5Sm71Uc/AfVFzyEEwf5NL/YrrqNHKpBQwPNyBrR/vAP2b2E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UivcGfrdAj/IsQFDTW/F/b2dSQYS1CK8y0JdsherOlMOO0tIwe2Y+e5BzrwgXHZRQ0XVKGmSs+bOR0dR6ua86qm8PzjzuSGPPe8TTrzpNpsNOWJfHJqs7wz6PiIX/NVWJyERLGhnKpc/Zv/eKhS55vurOeIm0Y6UTBfw/iKY8m4MlnbGXHU/OwfeZ+oJMaRWaOS04Go1ZaUCYqMeQnvdGbQQ9KiKQ6wgxUzTdF+M9TgIGc/+oNH+TRYmYMywarPLfAxrsn9wNvZ+p1vwvAFcO/7taC4w57dImEVy+dxnh4iJQ6K2nlpi7ZVXwqqz4AMRIZV3wK93b2ubn6cp3+kI2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vq29JU5HqLpTKWLUnR//8mgad/hctLEy9EqjMTuIe6c=;
 b=I7Bl2J4/39YCiJwVRAoa7vabkhY1Zv7JmSDQ3yBnL02ogMZduOrL+MgW92B3KErnR5bwrUBf35PXpPjY+nfvgeB9nazJhy14MdwS4a4f2EPhqe/jwGq/AfvRe1xzAV859GmvAembccMlMXpVuxT2Svm7t6qDc9vzLHP2NXG49rKe+DEwn3oIKrEDLh9bT2LAaCag0dhD8dQl0QZ0DW+4unq2hrK7/6LbbvACIo1SrNjMqPtmBlzHWFYSLx8pXi/XE13o47b7eNPvR8N2wQyWlgoXKDiQvu+5xIWmH0oUZFc5zdwVhEkaOmE8c14mVO0miW2Z4K2TIei/V00XhNL7VA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vq29JU5HqLpTKWLUnR//8mgad/hctLEy9EqjMTuIe6c=;
 b=5V30OvavXlK9b8V4E4nvuTEwi3Ld7EtLoD1RqNq7pjqPm8urzcMf7KLISLDFUpMlnl/etDkfSMtUrNXv1J1J66SlyTsyQbPjtZxSRPSWe1IoBDsUw9xlZXClaKhx5Sm71Uc/AfVFzyEEwf5NL/YrrqNHKpBQwPNyBrR/vAP2b2E=
From: Wei Chen <Wei.Chen@arm.com>
To: Marco Cacre <marco.cacre@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: Problem creating domU guest on arm64
Thread-Topic: Problem creating domU guest on arm64
Thread-Index: AQHYULecGX3bv6pHW0GOB9JfQ73gEaz4qJgAgAALTxA=
Date: Wed, 20 Apr 2022 11:39:49 +0000
Message-ID:
 <PAXPR08MB742084AA031A1B352E84B0C29EF59@PAXPR08MB7420.eurprd08.prod.outlook.com>
References:
 <CAGHctbYx6sspA__OmKyumU+WkhzEsDpLstyhRDM9Kbc696Co7Q@mail.gmail.com>
 <CAGHctbZzRc3PqzTd22_NpN4VHyB3DPyHJF2BoqAgBOcVp5_4ZA@mail.gmail.com>
In-Reply-To:
 <CAGHctbZzRc3PqzTd22_NpN4VHyB3DPyHJF2BoqAgBOcVp5_4ZA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 2AF8AFCACACB3644B1B3FB42E848592D.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 1682f479-2f08-4db2-0783-08da22c27f17
x-ms-traffictypediagnostic:
	AM5PR0801MB2003:EE_|DB5EUR03FT061:EE_|VE1PR08MB5279:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB52790C9C596D7FE94DF682E49EF59@VE1PR08MB5279.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 PljJhCY/RbHX9osclTAmLNAmAqTV2gl1PQeOVFAIUEMKH/DmTn4LcuJ7F8yRPdf0YI1JEdT0W65bdad3K549ToQVXvUO/oVMh1NozHQsRxirzoTZL9Db7h3e7V2nAJIV5OVGuLmW5wSXNi9Ekf9ILLkkWpqxaK4C94MejoNipuW3MU+I+Nz9u4ijkwZ32wA/mSAFEqE4yiFVdySDrX8wzqKJmEfTa6ZMXZEnnMhLVYgBBcfgbYb0CUqsHpPulIC9T4Q/5D9EZGJWrnU3en5K9omTDm1eiBBGqQ/GIwiN12ccsRHG4kzZSM6xOX5srFipwYeJhUTFQhSVWeh7Eqy9rQ1Xqd/6d43yZjDS1XsP60qaQh7THrzDdCB8gga7WalUR+2MJoyrxgHRFjSEPnECy2djIsewPJBdbbbaFP6z2zpnQbm7Jz4on2OWYeQKUHbBX4EWfxooQHk++Wx7tWIiuv96L8+JXQrYRjJ3zovqfBK6U9iC3OtLs7Qwd75jA9h/hcxUMJ3C6m+mpcUB7n200sz/cbz64l0nB2R9pq39mTm1eVyDRcJaLdHOI+aQvOqw8mdcI43NqFdyfLqYOHkhv0BIXLRrd51z7VvzXbKzbJTl8tPkKtRTmUZewBiVpGJp0TphLpDxWHnnQLCjcKstQTOnEm81LZfOtdF/rOw9zK10Sg71XzPSafKUrZ+LJRsVwlF0IIQGh5e9bmx2OZrL9w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(122000001)(316002)(66556008)(66946007)(64756008)(55016003)(38100700002)(66446008)(8676002)(110136005)(71200400001)(76116006)(66476007)(7696005)(9686003)(2906002)(5660300002)(53546011)(6506007)(83380400001)(52536014)(86362001)(508600001)(186003)(26005)(33656002)(9326002)(8936002);DIR:OUT;SFP:1101;
Content-Type: multipart/alternative;
	boundary="_000_PAXPR08MB742084AA031A1B352E84B0C29EF59PAXPR08MB7420eurp_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2003
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	184fc3ce-af82-4845-e87a-08da22c27a4c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	i1SmkZfzeapVM2O2dkMJ245qbmYQBwKqbsmlCyaXTCNoInCJ3Edpv4JLXnvpWyptHEZr1t5uqxw6ajsHsw5O7DoDWq09Hk3XsUIyglzKDB1BLGs82O+DyD7cDTNre7mshdHHMWkGVbpWUusmGa7+UxUCbAlQtzGuhrtuU+gqCLb6g0rbDW/ZhjIz/ud4fNlagYKBNe7KRSe9RyrMVlMyjNFKEqpFVWvyRIyWEw99euSLCLjYU6j2Q5qQ1dsA9RfriLJ5qIAhstZP2I1xAESt7S/3ESViUFKwGSEcinr0hBy/Qs66GcgGDXFHgKAWS+yxtbYc1GuVKkAT5Siem+N1EGTRFfLuwPP43/4FhY1TwAvs7JX8C1quL8b8xwHTac3nye5e/IGA35sdwaph+7PRxRVXC1doAVDjIEZWCMm1xeXfLXj8s00SO/ved1TCPGW1AfsOg0RwaRFLOZsTNISqHWzWlELEPG2zerdvtiDmC2OSzTrI8uBKNt2FsAiDrrQzrbWi8CEePX4s54MdC1poxzacz7flfuQQKUYJRgtApUx/hxYJhZy1KHfWxwV6moI+xSoWlCt2k8iQoIEwhH11NrcVjDxAUv3gEU2mx8/ntaNB0BJzgAWcrrIKU1fu7i0ReVN2Fe5RkqcW/VQRGxz1/A4Paxh9eSEKC3XwHmxVITG/l22+Jvk5LWB9cvRiqLE+
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(7696005)(356005)(2906002)(8676002)(81166007)(40460700003)(9686003)(82310400005)(6506007)(33964004)(53546011)(26005)(70586007)(70206006)(33656002)(52536014)(9326002)(8936002)(5660300002)(86362001)(336012)(47076005)(55016003)(110136005)(316002)(83380400001)(508600001)(186003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 11:39:57.7405
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1682f479-2f08-4db2-0783-08da22c27f17
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5279

--_000_PAXPR08MB742084AA031A1B352E84B0C29EF59PAXPR08MB7420eurp_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

SGkgTWFyY28sDQoNClRoZSBibG9jayBzY3JpcHQgaXMgdGltZW91dCwgeW91IGNhbiBhZGQgc29t
ZSBsb2cgbWVzc2FnZSB0bw0KY2hlY2sgd2hhdCBoYXBwZW5lZCB0byDigJwvZXRjL3hlbi9zY3Jp
cHRzL2Jsb2NrIGFkZOKAnS4NCllvdSBjYW4gZ29vZ2xlIHRvIGEgbG90IG9mIHBhZ2VzIG9uIGhv
dyB0byBwcmludCBtZXNzYWdlcyBpbg0KTGludXggc2hlbGwgc2NyaXB0cy4NCg0KbGlieGw6IGRl
YnVnOiBsaWJ4bF9hb3V0aWxzLmM6NTkzOmxpYnhsX19hc3luY19leGVjX3N0YXJ0OiBmb3JraW5n
IHRvIGV4ZWN1dGU6IC9ldGMveGVuL3NjcmlwdHMvYmxvY2sgYWRkDQpsaWJ4bDogZGVidWc6IGxp
YnhsX2V2ZW50LmM6NzIwOndhdGNoZmRfY2FsbGJhY2s6IHdhdGNoIGVwYXRoPS9sb2NhbC9kb21h
aW4vMC9iYWNrZW5kL3ZiZC82LzUxNzEyL3N0YXRlIHRva2VuPTMvMDogZW1wdHkgc2xvdA0KbGli
eGw6IGVycm9yOiBsaWJ4bF9hb3V0aWxzLmM6NTM5OmFzeW5jX2V4ZWNfdGltZW91dDoga2lsbGlu
ZyBleGVjdXRpb24gb2YgL2V0Yy94ZW4vc2NyaXB0cy9ibG9jayBhZGQgYmVjYXVzZSBvZiB0aW1l
b3V0DQoNCkJUVzoNCkl04oCZcyBnb29kIHRvIGNvdmVydCB5b3VyIGVtYWlsIGZvcm1hdCB0byBw
bGFpbiB0ZXh0LiBUaGlzIHdpbGwgbWFrZQ0KWGVuIGZvbGtzIHJlYWQgeW91ciBlbWFpbCBlYXNp
bHkuDQoNCkNoZWVycywNCldlaSBDaGVuDQoNCg0KRnJvbTogWGVuLWRldmVsIDx4ZW4tZGV2ZWwt
Ym91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mIE1hcmNvIENhY3JlDQpT
ZW50OiAyMDIy5bm0NOaciDIw5pelIDE4OjU1DQpUbzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2pl
Y3Qub3JnDQpTdWJqZWN0OiBSZTogUHJvYmxlbSBjcmVhdGluZyBkb21VIGd1ZXN0IG9uIGFybTY0
DQoNCkhpICBhbGwsDQoNCkkgZGlkIHNldmVyYWwgYXR0ZW1wdHMgYnV0IEkgaGF2ZSBhbHdheXMg
cHJvYmxlbXMgd2l0aCBkaXNrIGJhY2tlbmQgc2V0dXAgZHVyaW5nIGNyZWF0aW9uIG9mIGRvbVUg
ZG9tYWluLg0KDQpUaGUgbGF0ZXN0IGF0dGVtcHQgd2FzIHVzaW5nIGRlYmFuIGFybTY0IGltYWdl
IHdpdGggdGhpcyBjb25maWd1cmF0aW9uOg0KDQptZW1vcnkgPSA1MTINCm5hbWUgPSAiZGViaWFu
Ig0KdmNwdXMgPSAxDQptYXh2Y3B1cyA9IDENCmtlcm5lbCA9ICIvaG9tZS94ZW4vdm1saW51eiIN
CnJhbWRpc2sgPSAiL2hvbWUveGVuL2luaXRyZC5pbWciDQpkaXNrID0gWyJwaHk6L2Rldi9sb29w
MCx4dmRhLHJ3Il0NCmV4dHJhID0gInJvb3Q9L2Rldi94dmRhIHJ3IGNvbnNvbGU9aHZjMCBlYXJs
eXByaW50az14ZW4iDQoNCmtlcm5lbCBhbmQgcmFtZGlzayBib290IHVwIHN1Y2Nlc3NmdWxseSBh
bmQgSSBjYW4gYXR0YWNoIHRvIHRoZSBkb21VIGNvbnNvbGUsIGJ1dCB3aGVuIEkgdHJ5IHRvIGRl
ZmluZSB0aGUgZGlzayBiYWNrZW5kIHdpdGggdGhlIGRlYmlhbiByb290ZnMgdGhlIGNyZWF0aW9u
IG9mIHRoZSBkb21haW4gZmFpbHMuDQoNCnJvb3RmcyBpcyBhdHRhY2hlZCB0byBsb29wIGRldmlj
ZSBhcyBmb2xsb3c6DQoNCmxvc2V0dXAgL2Rldi9sb29wMCAvaG9tZS94ZW4vcm9vdGZzLmltZw0K
DQpJIGF0dGFjaGVkIHRvIHRoaXMgbWFpbCB0aGUgdmVyYm9zZSB0cmFjZSBvZiB0aGUgY29tbWFu
ZCB4bCBjcmVhdGUNCg0KVGhhbmtzIGEgbG90IGluIGFkdmFuY2UgZm9yIGFueSBraW5kIG9mIGhl
bHANCkJlc3QgUmVnYXJkcw0KTWFyY28NCg0KSWwgZ2lvcm5vIHZlbiAxNSBhcHIgMjAyMiBhbGxl
IG9yZSAxMjo1NiBNYXJjbyBDYWNyZSA8bWFyY28uY2FjcmVAZ21haWwuY29tPG1haWx0bzptYXJj
by5jYWNyZUBnbWFpbC5jb20+PiBoYSBzY3JpdHRvOg0KSGkgYWxsLA0KDQpJJ20gZmFjaW5nIGFs
d2F5cyB0aGUgc2FtZSBwcm9ibGVtIChkZXNjcmliZWQgYmVsb3cpIHRyeWluZyB0byBjcmVhdGUg
YSBYZW4gZ3Vlc3QgZG9tYWluIG9uIHJvY2twcm82NCAoYXJtNjQpLg0KDQpJIGhhdmUgc3VjY2Vz
c2Z1bGx5IGJ1aWx0IHVib290LCB4ZW4gKDQuMTQuNCkgYW5kIGRvbTAgbGludXgga2VybmVsIHdp
dGggeGVuIHRvb2wgc3RhY2ssIHRoZXNlIHR3byBsYXN0IHN0YXJ0aW5nIGZyb20gYnVpbGRyb290
ICh3aXRoIGxpbnV4IGtlcm5lbCB2ZXJzaW9uIDUuMTUuMzMgYW5kIHhlbiB0b29sc3RhY2sgdmVy
c2lvbiA0LjE0LjQpDQoNClRoZXNlIGFyZSB0aGUgcHJvY2VzcyBvZiBYZW46DQoNCjE3NyByb290
ICAgIC91c3Ivc2Jpbi94ZW53YXRjaGRvZ2QgMzAgMTUNCjIwMyByb290ICAgIC91c3Ivc2Jpbi94
ZW5zdG9yZWQgLS1waWQtZmlsZSAvdmFyL3J1bi94ZW4veGVuc3RvcmVkLnBpZA0KMjA4IHJvb3Qg
ICAgL3Vzci9zYmluL3hlbmNvbnNvbGVkIC0tcGlkLWZpbGU9L3Zhci9ydW4veGVuL3hlbmNvbnNv
bGVkLnBpZA0KMjE0IHJvb3QgICAgL3Vzci9saWIveGVuL2Jpbi9xZW11LXN5c3RlbS1pMzg2IC14
ZW4tZG9taWQgMCAteGVuLWF0dGFjaCAtbmFtZSBkb20wIC1ub2dyYXBoaWMgLU0geGVucHYgLWRh
ZW1vbml6ZSAtbW9uaXRvciAvZGV2L251bGwgLXNlcmlhbC9kZXYvbnVsIC1wYXJhbGxlbC9kZXYv
bnVsbCAtcGlkZmlsZS92YXIvcnVuL3hlbi9xZW11LWRvbTAucGlkDQoNCmFuZCB0aGUgZHJpdmVy
cyBsb2FkZWQgYXMgYSBtb2R1bGU6DQojIGxzbW9kDQpNb2R1bGUgICAgICAgICAgICAgICAgICBT
aXplICBVc2VkIGJ5ICAgIFRhaW50ZWQ6IEcNCnhlbl9uZXRiYWNrICAgICAgICAgICAgNjU1MzYg
IDANCnhlbl9ibGtiYWNrICAgICAgICAgICAgNDkxNTIgIDANCg0KWGVuIGFuZCBkb20wIEltYWdl
IGJvb3QgdXAgc3VjY2Vzc2Z1bGx5LCBhdCB0aGUgZW5kOg0KPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09DQo+eGwgbGlzdA0KTmFtZSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBJRCAgTWVtIFZDUFVzIFN0YXRlIFRpbWUocykNCkRv
bWFpbi0wICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMCAgMTAyNCAgICAyICAg
IHItLS0tLSAgICA0MDAwLjMNCg0KIyB1bmFtZSAtYQ0KTGludXggcm9ja3BybzY0IDUuMTUuMzMg
IzMgU01QIFBSRUVNUFQgRnJpIEFwciAxNSAxMTowMTozNyBDRVNUIDIwMjIgYWFyY2g2NCBHTlUv
TGludXgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K
DQp3aGVuIEkgdHJ5IHRvIGNyZWF0ZSBhIGRvbVUgZG9tYWluIEkgaGF2ZSBwcm9ibGVtIHdpdGgg
ZGlzayBiYWNrZW5kLCBJIGhhdmUgbWFkZSBzZXZlcmFsIGF0dGVtcHRzIHRyeWluZyB3aXRoIGRp
ZmZlcmVudCBkb21VIGxpbnV4IGFuZCBJIGFsd2F5cyBnZXQgdGhlIGZvbGxvd2luZyBlcnJvciA6
DQoNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUGFy
c2luZyBjb25maWcgZnJvbSAuL2FscGluZV94ZW5fZG9tdS5jb25maWcNCg0KbGlieGw6IGVycm9y
OiBsaWJ4bF9hb3V0aWxzLmM6NTM5OmFzeW5jX2V4ZWNfdGltZW91dDoga2lsbGluZyBleGVjdXRp
b24gb2YgL2V0Yy94ZW4vc2NyaXB0cy9ibG9jayBhZGQgYmVjYXVzZSBvZiB0aW1lb3V0DQpsaWJ4
bDogZXJyb3I6IGxpYnhsX2NyZWF0ZS5jOjE2MDg6ZG9tY3JlYXRlX2xhdW5jaF9kbTogRG9tYWlu
IDI6dW5hYmxlIHRvIGFkZCBkaXNrIGRldmljZXMNCmxpYnhsOiBlcnJvcjogbGlieGxfYW91dGls
cy5jOjUzOTphc3luY19leGVjX3RpbWVvdXQ6IGtpbGxpbmcgZXhlY3V0aW9uIG9mIC9ldGMveGVu
L3NjcmlwdHMvYmxvY2sgcmVtb3ZlIGJlY2F1c2Ugb2YgdGltZW91dA0KbGlieGw6IGVycm9yOiBs
aWJ4bF9kb21haW4uYzoxMTgyOmxpYnhsX19kZXN0cm95X2RvbWlkOiBEb21haW4gMjpOb24tZXhp
c3RhbnQgZG9tYWluDQpsaWJ4bDogZXJyb3I6IGxpYnhsX2RvbWFpbi5jOjExMzY6ZG9tYWluX2Rl
c3Ryb3lfY2FsbGJhY2s6IERvbWFpbiAyOlVuYWJsZSB0byBkZXN0cm95IGd1ZXN0DQpsaWJ4bDog
ZXJyb3I6IGxpYnhsX2RvbWFpbi5jOjEwNjM6ZG9tYWluX2Rlc3Ryb3lfY2I6IERvbWFpbiAyOkRl
c3RydWN0aW9uIG9mIGRvbWFpbiBmYWlsZWQNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQ0KDQpUaGUgbGFzdCB0cnkgd2FzIHdpdGggYWxwaW5lIGRvbVUg
bGludXggd2l0aCB0aGUgZm9sbG93aW5nIGNvbmZpZzoNCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQ0KDQojIEFscGluZSBMaW51eCBQViBEb21VDQojIEtl
cm5lbCBwYXRocyBmb3IgaW5zdGFsbA0Ka2VybmVsID0gIi9ob21lL3hlbi92bWxpbnV6LXZpcnQi
DQpyYW1kaXNrID0gIi9ob21lL3hlbi9pbml0cmFtZnMtdmlydCINCmV4dHJhPSJtb2R1bGVzPWxv
b3Asc3F1YXNoZnMgY29uc29sZT1odmMwIg0KIyBQYXRoIHRvIEhERCBhbmQgaXNvIGZpbGUNCmRp
c2sgPSBbICdmb3JtYXQ9cmF3LCB2ZGV2PXh2ZGEsIGFjY2Vzcz13LCB0YXJnZXQ9L2RhdGEvYTEu
aW1nJywNCiAgICAgICAgJ2Zvcm1hdD1yYXcsIHZkZXY9eHZkYywgYWNjZXNzPXIsIGRldnR5cGU9
Y2Ryb20sIHRhcmdldD0vaG9tZS94ZW4vYWxwaW5lLXZpcnQtMy4xNS4zLWFybXY3LmlzbycgIF0N
CiMgTmV0d29yayBjb25maWd1cmF0aW9uDQp2aWYgPSBbJ2JyaWRnZT1icjAnXQ0KIyBEb21VIHNl
dHRpbmdzDQptZW1vcnkgPSA1MTINCm5hbWUgPSAiYWxwaW5lLWExIg0KdmNwdXMgPSAxDQptYXh2
Y3B1cyA9IDENCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQ0KDQp0aGFua3MgYSBsb3QgaW4gYWR2YW5jZQ0KQmVzdCByZWdhcmRzDQpNYXJjbw0K

--_000_PAXPR08MB742084AA031A1B352E84B0C29EF59PAXPR08MB7420eurp_
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: base64

PGh0bWwgeG1sbnM6dj0idXJuOnNjaGVtYXMtbWljcm9zb2Z0LWNvbTp2bWwiIHhtbG5zOm89InVy
bjpzY2hlbWFzLW1pY3Jvc29mdC1jb206b2ZmaWNlOm9mZmljZSIgeG1sbnM6dz0idXJuOnNjaGVt
YXMtbWljcm9zb2Z0LWNvbTpvZmZpY2U6d29yZCIgeG1sbnM6bT0iaHR0cDovL3NjaGVtYXMubWlj
cm9zb2Z0LmNvbS9vZmZpY2UvMjAwNC8xMi9vbW1sIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv
VFIvUkVDLWh0bWw0MCI+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIg
Y29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjxtZXRhIG5hbWU9IkdlbmVyYXRv
ciIgY29udGVudD0iTWljcm9zb2Z0IFdvcmQgMTUgKGZpbHRlcmVkIG1lZGl1bSkiPg0KPHN0eWxl
PjwhLS0NCi8qIEZvbnQgRGVmaW5pdGlvbnMgKi8NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6
5a6L5L2TOw0KCXBhbm9zZS0xOjIgMSA2IDAgMyAxIDEgMSAxIDE7fQ0KQGZvbnQtZmFjZQ0KCXtm
b250LWZhbWlseToiQ2FtYnJpYSBNYXRoIjsNCglwYW5vc2UtMToyIDQgNSAzIDUgNCA2IDMgMiA0
O30NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6562J57q/Ow0KCXBhbm9zZS0xOjIgMSA2IDAg
MyAxIDEgMSAxIDE7fQ0KQGZvbnQtZmFjZQ0KCXtmb250LWZhbWlseTpDYWxpYnJpOw0KCXBhbm9z
ZS0xOjIgMTUgNSAyIDIgMiA0IDMgMiA0O30NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6IlxA
562J57q/IjsNCglwYW5vc2UtMToyIDEgNiAwIDMgMSAxIDEgMSAxO30NCkBmb250LWZhY2UNCgl7
Zm9udC1mYW1pbHk6Q29uc29sYXM7DQoJcGFub3NlLTE6MiAxMSA2IDkgMiAyIDQgMyAyIDQ7fQ0K
QGZvbnQtZmFjZQ0KCXtmb250LWZhbWlseTrlvq7ova/pm4Xpu5E7DQoJcGFub3NlLTE6MiAxMSA1
IDMgMiAyIDQgMiAyIDQ7fQ0KQGZvbnQtZmFjZQ0KCXtmb250LWZhbWlseToiXEDlvq7ova/pm4Xp
u5EiO30NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6IlxA5a6L5L2TIjsNCglwYW5vc2UtMToy
IDEgNiAwIDMgMSAxIDEgMSAxO30NCi8qIFN0eWxlIERlZmluaXRpb25zICovDQpwLk1zb05vcm1h
bCwgbGkuTXNvTm9ybWFsLCBkaXYuTXNvTm9ybWFsDQoJe21hcmdpbjowY207DQoJZm9udC1zaXpl
OjExLjBwdDsNCglmb250LWZhbWlseToiQ2FsaWJyaSIsc2Fucy1zZXJpZjt9DQphOmxpbmssIHNw
YW4uTXNvSHlwZXJsaW5rDQoJe21zby1zdHlsZS1wcmlvcml0eTo5OTsNCgljb2xvcjpibHVlOw0K
CXRleHQtZGVjb3JhdGlvbjp1bmRlcmxpbmU7fQ0Kc3Bhbi5FbWFpbFN0eWxlMTgNCgl7bXNvLXN0
eWxlLXR5cGU6cGVyc29uYWwtcmVwbHk7DQoJZm9udC1mYW1pbHk6Q29uc29sYXM7DQoJY29sb3I6
d2luZG93dGV4dDt9DQouTXNvQ2hwRGVmYXVsdA0KCXttc28tc3R5bGUtdHlwZTpleHBvcnQtb25s
eTsNCglmb250LWZhbWlseToiQ2FsaWJyaSIsc2Fucy1zZXJpZjt9DQpAcGFnZSBXb3JkU2VjdGlv
bjENCgl7c2l6ZTo2MTIuMHB0IDc5Mi4wcHQ7DQoJbWFyZ2luOjcyLjBwdCA5MC4wcHQgNzIuMHB0
IDkwLjBwdDt9DQpkaXYuV29yZFNlY3Rpb24xDQoJe3BhZ2U6V29yZFNlY3Rpb24xO30NCi0tPjwv
c3R5bGU+PCEtLVtpZiBndGUgbXNvIDldPjx4bWw+DQo8bzpzaGFwZWRlZmF1bHRzIHY6ZXh0PSJl
ZGl0IiBzcGlkbWF4PSIxMDI2IiAvPg0KPC94bWw+PCFbZW5kaWZdLS0+PCEtLVtpZiBndGUgbXNv
IDldPjx4bWw+DQo8bzpzaGFwZWxheW91dCB2OmV4dD0iZWRpdCI+DQo8bzppZG1hcCB2OmV4dD0i
ZWRpdCIgZGF0YT0iMSIgLz4NCjwvbzpzaGFwZWxheW91dD48L3htbD48IVtlbmRpZl0tLT4NCjwv
aGVhZD4NCjxib2R5IGxhbmc9IkVOLVVTIiBsaW5rPSJibHVlIiB2bGluaz0icHVycGxlIiBzdHls
ZT0id29yZC13cmFwOmJyZWFrLXdvcmQiPg0KPGRpdiBjbGFzcz0iV29yZFNlY3Rpb24xIj4NCjxw
IGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxlPSJmb250LWZhbWlseTpDb25zb2xhcyI+SGkg
TWFyY28sPG86cD48L286cD48L3NwYW4+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4g
c3R5bGU9ImZvbnQtZmFtaWx5OkNvbnNvbGFzIj48bzpwPiZuYnNwOzwvbzpwPjwvc3Bhbj48L3A+
DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBzdHlsZT0iZm9udC1mYW1pbHk6Q29uc29sYXMi
PlRoZSBibG9jayBzY3JpcHQgaXMgdGltZW91dCwgeW91IGNhbiBhZGQgc29tZSBsb2cgbWVzc2Fn
ZSB0bzxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0
eWxlPSJmb250LWZhbWlseTpDb25zb2xhcyI+Y2hlY2sgd2hhdCBoYXBwZW5lZCB0byDigJw8L3Nw
YW4+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkNvbnNvbGFzIj4vZXRjL3hlbi9zY3JpcHRzL2Js
b2NrIGFkZDwvc3Bhbj48c3BhbiBzdHlsZT0iZm9udC1mYW1pbHk6Q29uc29sYXMiPuKAnS48bzpw
PjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBzdHlsZT0iZm9u
dC1mYW1pbHk6Q29uc29sYXMiPllvdSBjYW4gZ29vZ2xlIHRvIGEgbG90IG9mIHBhZ2VzIG9uIGhv
dyB0byBwcmludCBtZXNzYWdlcyBpbjxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJN
c29Ob3JtYWwiPjxzcGFuIHN0eWxlPSJmb250LWZhbWlseTpDb25zb2xhcyI+TGludXggc2hlbGwg
c2NyaXB0cy48bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3Bh
biBzdHlsZT0iZm9udC1mYW1pbHk6Q29uc29sYXMiPjxvOnA+Jm5ic3A7PC9vOnA+PC9zcGFuPjwv
cD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxlPSJmb250LWZhbWlseTpDb25zb2xh
cyI+bGlieGw6IGRlYnVnOiBsaWJ4bF9hb3V0aWxzLmM6NTkzOmxpYnhsX19hc3luY19leGVjX3N0
YXJ0OiBmb3JraW5nIHRvIGV4ZWN1dGU6IC9ldGMveGVuL3NjcmlwdHMvYmxvY2sgYWRkDQo8bzpw
PjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBzdHlsZT0iZm9u
dC1mYW1pbHk6Q29uc29sYXMiPmxpYnhsOiBkZWJ1ZzogbGlieGxfZXZlbnQuYzo3MjA6d2F0Y2hm
ZF9jYWxsYmFjazogd2F0Y2ggZXBhdGg9L2xvY2FsL2RvbWFpbi8wL2JhY2tlbmQvdmJkLzYvNTE3
MTIvc3RhdGUgdG9rZW49My8wOiBlbXB0eSBzbG90PG86cD48L286cD48L3NwYW4+PC9wPg0KPHAg
Y2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkNvbnNvbGFzIj5saWJ4
bDogZXJyb3I6IGxpYnhsX2FvdXRpbHMuYzo1Mzk6YXN5bmNfZXhlY190aW1lb3V0OiBraWxsaW5n
IGV4ZWN1dGlvbiBvZiAvZXRjL3hlbi9zY3JpcHRzL2Jsb2NrIGFkZCBiZWNhdXNlIG9mIHRpbWVv
dXQ8bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBzdHls
ZT0iZm9udC1mYW1pbHk6Q29uc29sYXMiPjxvOnA+Jm5ic3A7PC9vOnA+PC9zcGFuPjwvcD4NCjxw
IGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxlPSJmb250LWZhbWlseTpDb25zb2xhcyI+QlRX
OjxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxl
PSJmb250LWZhbWlseTpDb25zb2xhcyI+SXTigJlzIGdvb2QgdG8gY292ZXJ0IHlvdXIgZW1haWwg
Zm9ybWF0IHRvIHBsYWluIHRleHQuIFRoaXMgd2lsbCBtYWtlPG86cD48L286cD48L3NwYW4+PC9w
Pg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkNvbnNvbGFz
Ij5YZW4gZm9sa3MgcmVhZCB5b3VyIGVtYWlsIGVhc2lseS48bzpwPjwvbzpwPjwvc3Bhbj48L3A+
DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBzdHlsZT0iZm9udC1mYW1pbHk6Q29uc29sYXMi
PjxvOnA+Jm5ic3A7PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFu
IHN0eWxlPSJmb250LWZhbWlseTpDb25zb2xhcyI+Q2hlZXJzLDxvOnA+PC9vOnA+PC9zcGFuPjwv
cD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxlPSJmb250LWZhbWlseTpDb25zb2xh
cyI+V2VpIENoZW48bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48
c3BhbiBzdHlsZT0iZm9udC1mYW1pbHk6Q29uc29sYXMiPjxvOnA+Jm5ic3A7PC9vOnA+PC9zcGFu
PjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxlPSJmb250LWZhbWlseTpDb25z
b2xhcyI+PG86cD4mbmJzcDs8L286cD48L3NwYW4+PC9wPg0KPGRpdiBzdHlsZT0iYm9yZGVyOm5v
bmU7Ym9yZGVyLWxlZnQ6c29saWQgYmx1ZSAxLjVwdDtwYWRkaW5nOjBjbSAwY20gMGNtIDQuMHB0
Ij4NCjxkaXY+DQo8ZGl2IHN0eWxlPSJib3JkZXI6bm9uZTtib3JkZXItdG9wOnNvbGlkICNFMUUx
RTEgMS4wcHQ7cGFkZGluZzozLjBwdCAwY20gMGNtIDBjbSI+DQo8cCBjbGFzcz0iTXNvTm9ybWFs
Ij48Yj5Gcm9tOjwvYj4gWGVuLWRldmVsICZsdDt4ZW4tZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5w
cm9qZWN0Lm9yZyZndDsNCjxiPk9uIEJlaGFsZiBPZiA8L2I+TWFyY28gQ2FjcmU8YnI+DQo8Yj5T
ZW50OjwvYj4gMjAyMjxzcGFuIGxhbmc9IlpILUNOIiBzdHlsZT0iZm9udC1mYW1pbHk65a6L5L2T
Ij7lubQ8L3NwYW4+NDxzcGFuIGxhbmc9IlpILUNOIiBzdHlsZT0iZm9udC1mYW1pbHk65a6L5L2T
Ij7mnIg8L3NwYW4+MjA8c3BhbiBsYW5nPSJaSC1DTiIgc3R5bGU9ImZvbnQtZmFtaWx5OuWui+S9
kyI+5pelPC9zcGFuPiAxODo1NTxicj4NCjxiPlRvOjwvYj4geGVuLWRldmVsQGxpc3RzLnhlbnBy
b2plY3Qub3JnPGJyPg0KPGI+U3ViamVjdDo8L2I+IFJlOiBQcm9ibGVtIGNyZWF0aW5nIGRvbVUg
Z3Vlc3Qgb24gYXJtNjQ8bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPC9kaXY+DQo8cCBjbGFzcz0i
TXNvTm9ybWFsIj48bzpwPiZuYnNwOzwvbzpwPjwvcD4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9y
bWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87bXNvLW1hcmdpbi1ib3R0b20tYWx0
OmF1dG8iPkhpJm5ic3A7IGFsbCw8bzpwPjwvbzpwPjwvcD4NCjxkaXY+DQo8cCBjbGFzcz0iTXNv
Tm9ybWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87bXNvLW1hcmdpbi1ib3R0b20t
YWx0OmF1dG8iPiZuYnNwOzxvOnA+PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0KPHAgY2xhc3M9
Ik1zb05vcm1hbCIgc3R5bGU9Im1zby1tYXJnaW4tdG9wLWFsdDphdXRvO21zby1tYXJnaW4tYm90
dG9tLWFsdDphdXRvIj5JIGRpZCBzZXZlcmFsIGF0dGVtcHRzIGJ1dCBJIGhhdmUgYWx3YXlzIHBy
b2JsZW1zIHdpdGggZGlzayBiYWNrZW5kIHNldHVwIGR1cmluZyBjcmVhdGlvbiBvZiBkb21VIGRv
bWFpbi48bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwi
IHN0eWxlPSJtc28tbWFyZ2luLXRvcC1hbHQ6YXV0bzttc28tbWFyZ2luLWJvdHRvbS1hbHQ6YXV0
byI+Jm5ic3A7PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9y
bWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87bXNvLW1hcmdpbi1ib3R0b20tYWx0
OmF1dG8iPlRoZSBsYXRlc3QgYXR0ZW1wdCB3YXMgdXNpbmcgZGViYW4gYXJtNjQgaW1hZ2Ugd2l0
aCB0aGlzIGNvbmZpZ3VyYXRpb246PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBj
bGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87bXNvLW1hcmdp
bi1ib3R0b20tYWx0OmF1dG8iPiZuYnNwOzxvOnA+PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0K
PHAgY2xhc3M9Ik1zb05vcm1hbCIgc3R5bGU9Im1zby1tYXJnaW4tdG9wLWFsdDphdXRvO21zby1t
YXJnaW4tYm90dG9tLWFsdDphdXRvIj5tZW1vcnkgPSA1MTI8YnI+DQpuYW1lID0gJnF1b3Q7ZGVi
aWFuJnF1b3Q7PGJyPg0KdmNwdXMgPSAxPGJyPg0KbWF4dmNwdXMgPSAxPG86cD48L286cD48L3A+
DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10
b3AtYWx0OmF1dG87bXNvLW1hcmdpbi1ib3R0b20tYWx0OmF1dG8iPmtlcm5lbCA9ICZxdW90Oy9o
b21lL3hlbi92bWxpbnV6JnF1b3Q7PGJyPg0KcmFtZGlzayA9ICZxdW90Oy9ob21lL3hlbi9pbml0
cmQuaW1nJnF1b3Q7PGJyPg0KZGlzayA9IFsmcXVvdDtwaHk6L2Rldi9sb29wMCx4dmRhLHJ3JnF1
b3Q7XTxicj4NCmV4dHJhID0gJnF1b3Q7cm9vdD0vZGV2L3h2ZGEgcncgY29uc29sZT1odmMwIGVh
cmx5cHJpbnRrPXhlbiZxdW90OzxvOnA+PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0KPHAgY2xh
c3M9Ik1zb05vcm1hbCIgc3R5bGU9Im1zby1tYXJnaW4tdG9wLWFsdDphdXRvO21zby1tYXJnaW4t
Ym90dG9tLWFsdDphdXRvIj4mbmJzcDs8bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxw
IGNsYXNzPSJNc29Ob3JtYWwiIHN0eWxlPSJtc28tbWFyZ2luLXRvcC1hbHQ6YXV0bzttc28tbWFy
Z2luLWJvdHRvbS1hbHQ6YXV0byI+a2VybmVsIGFuZCByYW1kaXNrIGJvb3QgdXAgc3VjY2Vzc2Z1
bGx5IGFuZCBJIGNhbiBhdHRhY2ggdG8gdGhlIGRvbVUgY29uc29sZSwgYnV0IHdoZW4gSSB0cnkg
dG8gZGVmaW5lIHRoZSBkaXNrIGJhY2tlbmQgd2l0aCB0aGUgZGViaWFuIHJvb3RmcyB0aGUgY3Jl
YXRpb24gb2YgdGhlIGRvbWFpbiBmYWlscy48bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4N
CjxwIGNsYXNzPSJNc29Ob3JtYWwiIHN0eWxlPSJtc28tbWFyZ2luLXRvcC1hbHQ6YXV0bzttc28t
bWFyZ2luLWJvdHRvbS1hbHQ6YXV0byI+Jm5ic3A7PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxk
aXY+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87
bXNvLW1hcmdpbi1ib3R0b20tYWx0OmF1dG8iPnJvb3RmcyBpcyBhdHRhY2hlZCB0byBsb29wIGRl
dmljZSBhcyBmb2xsb3c6PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0i
TXNvTm9ybWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87bXNvLW1hcmdpbi1ib3R0
b20tYWx0OmF1dG8iPiZuYnNwOzxvOnA+PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0KPHAgY2xh
c3M9Ik1zb05vcm1hbCIgc3R5bGU9Im1zby1tYXJnaW4tdG9wLWFsdDphdXRvO21zby1tYXJnaW4t
Ym90dG9tLWFsdDphdXRvIj5sb3NldHVwIC9kZXYvbG9vcDAgL2hvbWUveGVuL3Jvb3Rmcy5pbWc8
bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiIHN0eWxl
PSJtc28tbWFyZ2luLXRvcC1hbHQ6YXV0bzttc28tbWFyZ2luLWJvdHRvbS1hbHQ6YXV0byI+Jm5i
c3A7PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBz
dHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87bXNvLW1hcmdpbi1ib3R0b20tYWx0OmF1dG8i
PkkgYXR0YWNoZWQgdG8gdGhpcyBtYWlsIHRoZSB2ZXJib3NlIHRyYWNlIG9mIHRoZSBjb21tYW5k
IHhsIGNyZWF0ZTxvOnA+PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0KPHAgY2xhc3M9Ik1zb05v
cm1hbCIgc3R5bGU9Im1zby1tYXJnaW4tdG9wLWFsdDphdXRvO21zby1tYXJnaW4tYm90dG9tLWFs
dDphdXRvIj4mbmJzcDs8bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxwIGNsYXNzPSJN
c29Ob3JtYWwiIHN0eWxlPSJtc28tbWFyZ2luLXRvcC1hbHQ6YXV0bzttc28tbWFyZ2luLWJvdHRv
bS1hbHQ6YXV0byI+VGhhbmtzIGEgbG90IGluIGFkdmFuY2UgZm9yIGFueSBraW5kIG9mIGhlbHA8
bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiIHN0eWxl
PSJtc28tbWFyZ2luLXRvcC1hbHQ6YXV0bzttc28tbWFyZ2luLWJvdHRvbS1hbHQ6YXV0byI+QmVz
dCBSZWdhcmRzPG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9y
bWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87bXNvLW1hcmdpbi1ib3R0b20tYWx0
OmF1dG8iPk1hcmNvPG86cD48L286cD48L3A+DQo8L2Rpdj4NCjwvZGl2Pg0KPHAgY2xhc3M9Ik1z
b05vcm1hbCI+PG86cD4mbmJzcDs8L286cD48L3A+DQo8ZGl2Pg0KPGRpdj4NCjxwIGNsYXNzPSJN
c29Ob3JtYWwiPklsIGdpb3JubyB2ZW4gMTUgYXByIDIwMjIgYWxsZSBvcmUgMTI6NTYgTWFyY28g
Q2FjcmUgJmx0OzxhIGhyZWY9Im1haWx0bzptYXJjby5jYWNyZUBnbWFpbC5jb20iPm1hcmNvLmNh
Y3JlQGdtYWlsLmNvbTwvYT4mZ3Q7IGhhIHNjcml0dG86PG86cD48L286cD48L3A+DQo8L2Rpdj4N
CjxibG9ja3F1b3RlIHN0eWxlPSJib3JkZXI6bm9uZTtib3JkZXItbGVmdDpzb2xpZCAjQ0NDQ0ND
IDEuMHB0O3BhZGRpbmc6MGNtIDBjbSAwY20gNi4wcHQ7bWFyZ2luLWxlZnQ6NC44cHQ7bWFyZ2lu
LXJpZ2h0OjBjbSI+DQo8ZGl2Pg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+SGkgYWxsLDxicj4NCjxi
cj4NCkknbSBmYWNpbmcgYWx3YXlzIHRoZSBzYW1lIHByb2JsZW0gKGRlc2NyaWJlZCBiZWxvdykg
dHJ5aW5nIHRvIGNyZWF0ZSBhIFhlbiBndWVzdCBkb21haW4gb24gcm9ja3BybzY0IChhcm02NCku
PGJyPg0KPGJyPg0KSSBoYXZlIHN1Y2Nlc3NmdWxseSBidWlsdCB1Ym9vdCwgeGVuICg0LjE0LjQp
IGFuZCBkb20wIGxpbnV4IGtlcm5lbCB3aXRoIHhlbiB0b29sIHN0YWNrLCB0aGVzZSB0d28gbGFz
dCBzdGFydGluZyBmcm9tIGJ1aWxkcm9vdCAod2l0aCBsaW51eCBrZXJuZWwgdmVyc2lvbiA1LjE1
LjMzIGFuZCB4ZW4gdG9vbHN0YWNrIHZlcnNpb24gNC4xNC40KTxicj4NCjxicj4NClRoZXNlIGFy
ZSB0aGUgcHJvY2VzcyBvZiBYZW46PGJyPg0KPGJyPg0KMTc3IHJvb3QgJm5ic3A7ICZuYnNwOy91
c3Ivc2Jpbi94ZW53YXRjaGRvZ2QgMzAgMTU8YnI+DQoyMDMgcm9vdCAmbmJzcDsgJm5ic3A7L3Vz
ci9zYmluL3hlbnN0b3JlZCAtLXBpZC1maWxlIC92YXIvcnVuL3hlbi94ZW5zdG9yZWQucGlkPGJy
Pg0KMjA4IHJvb3QgJm5ic3A7ICZuYnNwOy91c3Ivc2Jpbi94ZW5jb25zb2xlZCAtLXBpZC1maWxl
PS92YXIvcnVuL3hlbi94ZW5jb25zb2xlZC5waWQ8YnI+DQoyMTQgcm9vdCAmbmJzcDsgJm5ic3A7
L3Vzci9saWIveGVuL2Jpbi9xZW11LXN5c3RlbS1pMzg2IC14ZW4tZG9taWQgMCAteGVuLWF0dGFj
aCAtbmFtZSBkb20wIC1ub2dyYXBoaWMgLU0geGVucHYgLWRhZW1vbml6ZSAtbW9uaXRvciAvZGV2
L251bGwgLXNlcmlhbC9kZXYvbnVsIC1wYXJhbGxlbC9kZXYvbnVsbCAtcGlkZmlsZS92YXIvcnVu
L3hlbi9xZW11LWRvbTAucGlkPGJyPg0KPGJyPg0KYW5kIHRoZSBkcml2ZXJzIGxvYWRlZCBhcyBh
IG1vZHVsZTo8YnI+DQojIGxzbW9kPGJyPg0KTW9kdWxlICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7U2l6ZSAmbmJzcDtVc2VkIGJ5
ICZuYnNwOyAmbmJzcDtUYWludGVkOiBHPGJyPg0KeGVuX25ldGJhY2sgJm5ic3A7ICZuYnNwOyAm
bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDs2NTUzNiAmbmJzcDswPGJyPg0KeGVuX2Jsa2JhY2sg
Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDs0OTE1MiAmbmJzcDswPGJy
Pg0KPGJyPg0KWGVuIGFuZCBkb20wIEltYWdlIGJvb3QgdXAgc3VjY2Vzc2Z1bGx5LCBhdCB0aGUg
ZW5kOjxicj4NCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PTxicj4NCiZndDt4bCBsaXN0PGJyPg0KTmFtZSAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsg
Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAm
bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7SUQg
Jm5ic3A7TWVtIFZDUFVzIFN0YXRlIFRpbWUocyk8YnI+DQpEb21haW4tMCAmbmJzcDsgJm5ic3A7
ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsg
Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOzAg
Jm5ic3A7MTAyNCAmbmJzcDsgJm5ic3A7MiAmbmJzcDsgJm5ic3A7ci0tLS0tICZuYnNwOyAmbmJz
cDs0MDAwLjM8YnI+DQo8YnI+DQojIHVuYW1lIC1hPGJyPg0KTGludXggcm9ja3BybzY0IDUuMTUu
MzMgIzMgU01QIFBSRUVNUFQgRnJpIEFwciAxNSAxMTowMTozNyBDRVNUIDIwMjIgYWFyY2g2NCBH
TlUvTGludXg8YnI+DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT08YnI+DQo8YnI+DQp3aGVuIEkgdHJ5IHRvIGNyZWF0ZSBhIGRvbVUgZG9tYWluIEkgaGF2
ZSBwcm9ibGVtIHdpdGggZGlzayBiYWNrZW5kLCBJIGhhdmUgbWFkZSBzZXZlcmFsIGF0dGVtcHRz
IHRyeWluZyB3aXRoIGRpZmZlcmVudCBkb21VIGxpbnV4IGFuZCBJIGFsd2F5cyBnZXQgdGhlIGZv
bGxvd2luZyBlcnJvciA6PGJyPg0KPGJyPg0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PGJyPg0KUGFyc2luZyBjb25maWcgZnJvbSAuL2FscGluZV94ZW5f
ZG9tdS5jb25maWc8YnI+DQo8YnI+DQpsaWJ4bDogZXJyb3I6IGxpYnhsX2FvdXRpbHMuYzo1Mzk6
YXN5bmNfZXhlY190aW1lb3V0OiBraWxsaW5nIGV4ZWN1dGlvbiBvZiAvZXRjL3hlbi9zY3JpcHRz
L2Jsb2NrIGFkZCBiZWNhdXNlIG9mIHRpbWVvdXQ8YnI+DQpsaWJ4bDogZXJyb3I6IGxpYnhsX2Ny
ZWF0ZS5jOjE2MDg6ZG9tY3JlYXRlX2xhdW5jaF9kbTogRG9tYWluIDI6dW5hYmxlIHRvIGFkZCBk
aXNrIGRldmljZXM8YnI+DQpsaWJ4bDogZXJyb3I6IGxpYnhsX2FvdXRpbHMuYzo1Mzk6YXN5bmNf
ZXhlY190aW1lb3V0OiBraWxsaW5nIGV4ZWN1dGlvbiBvZiAvZXRjL3hlbi9zY3JpcHRzL2Jsb2Nr
IHJlbW92ZSBiZWNhdXNlIG9mIHRpbWVvdXQ8YnI+DQpsaWJ4bDogZXJyb3I6IGxpYnhsX2RvbWFp
bi5jOjExODI6bGlieGxfX2Rlc3Ryb3lfZG9taWQ6IERvbWFpbiAyOk5vbi1leGlzdGFudCBkb21h
aW48YnI+DQpsaWJ4bDogZXJyb3I6IGxpYnhsX2RvbWFpbi5jOjExMzY6ZG9tYWluX2Rlc3Ryb3lf
Y2FsbGJhY2s6IERvbWFpbiAyOlVuYWJsZSB0byBkZXN0cm95IGd1ZXN0PGJyPg0KbGlieGw6IGVy
cm9yOiBsaWJ4bF9kb21haW4uYzoxMDYzOmRvbWFpbl9kZXN0cm95X2NiOiBEb21haW4gMjpEZXN0
cnVjdGlvbiBvZiBkb21haW4gZmFpbGVkPGJyPg0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PGJyPg0KPGJyPg0KVGhlIGxhc3QgdHJ5IHdhcyB3aXRoIGFs
cGluZSBkb21VIGxpbnV4IHdpdGggdGhlIGZvbGxvd2luZyBjb25maWc6PGJyPg0KPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PGJyPg0KPGJyPg0KIyBBbHBp
bmUgTGludXggUFYgRG9tVTxicj4NCiMgS2VybmVsIHBhdGhzIGZvciBpbnN0YWxsPGJyPg0Ka2Vy
bmVsID0gJnF1b3Q7L2hvbWUveGVuL3ZtbGludXotdmlydCZxdW90Ozxicj4NCnJhbWRpc2sgPSAm
cXVvdDsvaG9tZS94ZW4vaW5pdHJhbWZzLXZpcnQmcXVvdDs8YnI+DQpleHRyYT0mcXVvdDttb2R1
bGVzPWxvb3Asc3F1YXNoZnMgY29uc29sZT1odmMwJnF1b3Q7PGJyPg0KIyBQYXRoIHRvIEhERCBh
bmQgaXNvIGZpbGU8YnI+DQpkaXNrID0gWyAnZm9ybWF0PXJhdywgdmRldj14dmRhLCBhY2Nlc3M9
dywgdGFyZ2V0PS9kYXRhL2ExLmltZycsPGJyPg0KJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7
ICdmb3JtYXQ9cmF3LCB2ZGV2PXh2ZGMsIGFjY2Vzcz1yLCBkZXZ0eXBlPWNkcm9tLCB0YXJnZXQ9
L2hvbWUveGVuL2FscGluZS12aXJ0LTMuMTUuMy1hcm12Ny5pc28nICZuYnNwO108YnI+DQojIE5l
dHdvcmsgY29uZmlndXJhdGlvbiAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5i
c3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7PGJyPg0KdmlmID0g
WydicmlkZ2U9YnIwJ108YnI+DQojIERvbVUgc2V0dGluZ3MgJm5ic3A7ICZuYnNwOyAmbmJzcDsg
Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAm
bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5i
c3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7PGJyPg0KbWVtb3J5ID0gNTEyICZuYnNwOyAmbmJzcDsg
Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAm
bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5i
c3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7PGJyPg0KbmFtZSA9
ICZxdW90O2FscGluZS1hMSZxdW90OyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7
ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsg
Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAm
bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwOzxicj4NCnZjcHVzID0gMSAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5i
c3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJz
cDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNw
OyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDs8YnI+DQptYXh2Y3B1cyA9IDE8YnI+DQo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT08YnI+DQo8YnI+DQp0
aGFua3MgYSBsb3QgaW4gYWR2YW5jZTxicj4NCkJlc3QgcmVnYXJkczxzcGFuIHN0eWxlPSJjb2xv
cjojODg4ODg4Ij48YnI+DQpNYXJjbzwvc3Bhbj48bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPC9i
bG9ja3F1b3RlPg0KPC9kaXY+DQo8L2Rpdj4NCjwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K

--_000_PAXPR08MB742084AA031A1B352E84B0C29EF59PAXPR08MB7420eurp_--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 11:53:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 11:53:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309183.525206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh8ts-0002Sz-C9; Wed, 20 Apr 2022 11:53:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309183.525206; Wed, 20 Apr 2022 11:53:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh8ts-0002Ss-7g; Wed, 20 Apr 2022 11:53:36 +0000
Received: by outflank-mailman (input) for mailman id 309183;
 Wed, 20 Apr 2022 11:53:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh8tq-0002Si-DY; Wed, 20 Apr 2022 11:53:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh8tq-0006fF-Ab; Wed, 20 Apr 2022 11:53:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh8tp-0006N1-Ve; Wed, 20 Apr 2022 11:53:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh8tp-0001zK-VC; Wed, 20 Apr 2022 11:53:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ewCtLefEkAa5mfWGZ0wEwmFfPG/kZGdXzxKKjCWE8EI=; b=PhjI/1vApOUVlpG5bKZDkg8XHk
	B4s0yjlZJrjga92iiq61X6FIxvaoaDG/Y5hocVwGETftwb8xmeSbV8Bi4UV0xhqrqHOFICTp2zSIE
	w2RvT79BopZCzOg7WxpjCpD59Hn0Dp8E3W21ogUhpmZAi1aREsLnAIy5xZmj/7dxZWdc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169555-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169555: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=136b821f183deb0b58c571211f6917985bed3308
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 11:53:33 +0000

flight 169555 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169555/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              136b821f183deb0b58c571211f6917985bed3308
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  649 days
Failing since        151818  2020-07-11 04:18:52 Z  648 days  630 attempts
Testing same since   169555  2022-04-20 04:20:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 104970 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 12:08:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 12:08:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309198.525217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh97r-0004R9-VS; Wed, 20 Apr 2022 12:08:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309198.525217; Wed, 20 Apr 2022 12:08:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh97r-0004R2-S5; Wed, 20 Apr 2022 12:08:03 +0000
Received: by outflank-mailman (input) for mailman id 309198;
 Wed, 20 Apr 2022 12:08:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh97q-0004Qw-OV
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 12:08:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 861918b6-c0a2-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 14:08:01 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-biHv-SU1ML6odw3Mr6nGUA-1; Wed, 20 Apr 2022 14:07:58 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB6247.eurprd04.prod.outlook.com (2603:10a6:20b:be::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 12:07:57 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 12:07:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 861918b6-c0a2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650456480;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RQNgLqHj4lUl/YuwhxSwiIYtXXvqVMvpbSA50HpAcBE=;
	b=mFaKtMNn2sfGtUSx7sk3NUnNShvAbueccqb/nioLvfG4c2OWMojzc01Rwd+mqtELQ6E+XC
	mVtPagxf0Z+IxwkXNtLeozATA8y283pQiPP5v7Q+g0hcXpC/Ta5bsbM0qlBxEq0XUyELRa
	LgNQbQInmFQ54oyEVSfROEIUTmdKTDA=
X-MC-Unique: biHv-SU1ML6odw3Mr6nGUA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O21eGBGUfmO10XhCWKH/98fSe3C1GBxcgrmdK54GhRo2oWl3IYmz28svUc0toeRQfi3rhJENcvqMWiPKBfXMXlRkW4iGg3d2kGuAIb5p/iiVLuosG2PLiylW26YxIyw6Os4Zqz6yK35/s1mNXEa3s9RT5zEv6M1PDzh8XNFJwxAnWmvZUVbwYDZ8KAC/sGYyYJdKBHBbsePCB1KESUlE8+7kD2Q0fiZJboIQZ/gC8062O6ddXm+uiBMMYTItJG4KJ25ofFutbDOALtvX/EalIVylM1y6Oa/PgI+GS04K39tQsmin4nmYT65IeceKLRwKmVjnoFBERPlTsnZIV0juig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4/wn6ejJNHIEeQONgUARuPPeuAi929+fhMrD6sGHKZc=;
 b=AyCAD9B31W2b1WgXUNyXpBuoF3pQYfs+Dae5/ZfSUGf+1eTCy88fOyfoENDFFTBwx6R8pPoExprki0cbD83Ua1lRJVh0kugGanak85nm+RHuBjMaVlgi9XfEAkaVlHNYxJZUfbu1zr/H6ENFE9risYb6OH87pG6d2Zbw2zmD4Omu88vqxJVdEHRDdIaoRM6SE/yatWjkUyirmAgJykO+QMkGAIMl0QZuS79mlAjVdn2I5d5Qw+3rgs2vhT/o+1DREFeQVwKtwrRHIo3jUnmhsaL/QPHcY78Frg+PazJSVCw4NKznU7zXne5dNbgrBHnka4Ri05RSMpaFSovidFzK6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0f3cdf75-e6ae-1c16-a4db-9d7a54bf89ea@suse.com>
Date: Wed, 20 Apr 2022 14:07:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 3/3] x86/build: Clean up boot/Makefile
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220414114708.4788-1-andrew.cooper3@citrix.com>
 <20220414114708.4788-4-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220414114708.4788-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0083.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e76ee1c1-383f-48d3-ba9f-08da22c66830
X-MS-TrafficTypeDiagnostic: AM6PR04MB6247:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6247DF4FC1A45C16D1D33E64B3F59@AM6PR04MB6247.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vYX+XYAmjh9QOng0RMcUmrKPVMeJSK+boXYfE1BcJ03Th4J6lMTqtjsqkotsfBIrIwbB956FZm5ymdxW4+q1ON5vq3VOf46wyzGUFEvPqdZtV79ziLKxkfrKS6pBsIju6o2YawPjAC1jKajNFUiR/mWFW5sAACBv+quDwWDkgNix2J2gmGtVW9llf4TLHXGLyLylw8Jbc4XYPQ/BDGpkXfZupsLJQzH0FUbFc3COrCkidmJThX4FM8rB6VLiQTy+GazJGwFb8CF7SsObDILhrQgQ3JhVEdTuq7aBLhc2W91ymYZXbQd7FgciiCvU327RbwjpyC3Ox8lXJE3zxIW4t0hPTjGuSneFivlIlUyPSPyLSXEXbMh/+6EYtjdEadZjo5OOOJRomujJg14SfYYyw6y8zOTe+ctDl4Lj0oMgYGmQSf0f8JYiPLxsgKRKQV2gykN0JrcDheXy+NYFj21rOgfn6VnlHfF7pUuMmyd/gyoMd3U0KKjqf8vEi5eVZBUuplEOsJYSHrqSBSdR2/hCdoiyKXoB57OisIPr26gt8muzZ3DOKvmsJUrMrEDE1leLZHU35uz0v5z/TeGNYii7zG+RqEE2+GhEgI1JjKqfvxwwR56F0909SLtGsSKYipsvxxbK2BOySct53fzeD8h5CEM0yMhLUIioaICCk7G8oiphyr3QMBvfIyek3dycAUJfjqJkMVd/dEuhsIjEjDdEFZRTiRQNLQjhVxadBKLsmK8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(186003)(6916009)(31686004)(31696002)(26005)(2616005)(2906002)(53546011)(6506007)(66556008)(4326008)(66946007)(66476007)(36756003)(8676002)(508600001)(86362001)(6486002)(8936002)(38100700002)(316002)(5660300002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zERnc7DRgMpWoou2ymomef2d4lcsCWTjoZkqzdyxmsjmt/4TiTjWL0Ta0SUu?=
 =?us-ascii?Q?mC7aBp9bBq3LtX9+sw9l/wCFn4vuVqvhHbNGRgPMG2d82jt6vHmXYPdJH20+?=
 =?us-ascii?Q?EC2RRbDoaODZP67pLBYV2yAOPwaxHxe6cAA3paIk8sYIwYc6PiVPByCuTOc9?=
 =?us-ascii?Q?Xjeyw2vvwaWjzUu75hqCjJhxMO9CTFfcQ7miejuSqHpVF1oqnHpKK0YoWOIb?=
 =?us-ascii?Q?978ZaOdHkNYBQgzOHBs+0gt5XmyxYymM8MM8BvuD1ZJdkirz/uKjuj1KLp6g?=
 =?us-ascii?Q?8ogVzeP04+EyxpArScTFGziIaq0ndtgL1cpVxTmP6omIQn0XWVg5pOSV8sdr?=
 =?us-ascii?Q?aVrO/VUIZPAk8GuaS7lkI5oa1jirqdbo7QAc0GdbfCb2JcCosTBAYEd1PFfg?=
 =?us-ascii?Q?2zLHvEBkts6eCHDrLOILeqbJQIPMwpWfC1YfXSQ1nK0ZXWsR/yyCaS12ZdrJ?=
 =?us-ascii?Q?IwGCCcuJ6nWZLtjvaoZa7o7v8wCwfOXICnXSAv7Tm2J8K0n65xbJxLgeA8O6?=
 =?us-ascii?Q?XpykPoy5/X+wlSm1ALNAcnVh6q/3jtA+wgRZyuqJ+k/iG1du590LTNqBhhpb?=
 =?us-ascii?Q?EBX+LCJ7jp3PVi9HsJPppv2dihhEGTrYK0te1qroSkHpms7f69OCvdU8+hMm?=
 =?us-ascii?Q?kPcgP/qr0jaXyEIjUtb0njl08VMBQBBXXSbzYCuUJXXOcB05b0cPRtXzrLTt?=
 =?us-ascii?Q?d4A3yfKvyzz8Ccqfj4kY+PS0K8AKrSrC5U6OhloKlXLc7tF27YgXH3suVW6u?=
 =?us-ascii?Q?tg8cixo3N5hdiueJKEpx8wnzZJ4+AIcUuWRCWYUSR3H224oAPOKaqqi9uUeU?=
 =?us-ascii?Q?bbYccKyFOW7ktcDj2oZ2o6NkjsWFCTvBtfDeg3saAJJOtxQ0sSkaozU40j54?=
 =?us-ascii?Q?vPt0DhVfU1RmLzwJlLkTYoj11KVQ6FXx7yldW3asPhWbO2ukT4d7OF1PQUnM?=
 =?us-ascii?Q?1Xs+XHO/vuTEa2LUcnaQHfxfWwp15tdFK9bB/4U0lTv3BdiauUBCGvAcVgoX?=
 =?us-ascii?Q?/K+tUDZfw0RmToEVpRR0vLBmTOp2IVb2SukhnYyHc4pbRbNSV4Wj9ZQQnpeK?=
 =?us-ascii?Q?U/reS4fua+ssrIO3D7RuLzGgnYtIGScKXgS6/FNBiVZ/g0cPFIdN5JQW3bDK?=
 =?us-ascii?Q?u/qWIhqOCoXlps2oztm9PdFZ4zye4LI0Jxr9ZFA2mlyy3eLYbX0kN2MEk/Y2?=
 =?us-ascii?Q?THwQC7GbzRu2Od7CsSiIEUQ26wmgPLwmgnyfgjEuse6IoS0knUoex2Wo7OJQ?=
 =?us-ascii?Q?gJiAvM/8rGS+AZGur56ihIj6kVEofv/88qsDtnZC6YYLmAT8s4LWDnk2+bWy?=
 =?us-ascii?Q?c6Img1osByzYqhs8uUHZfMBaqn46Zm+zfhdUKvlWvAY9nE+x5WI22HA6qQo/?=
 =?us-ascii?Q?VLPfBdM+nHV5yxW3tcaLarNCS5g92sMU+pWkgcs+yKaTFUc9oCZEGNu1SQZY?=
 =?us-ascii?Q?BBBQX56rZ7RMEceVrTwRRhyJPjjnO0jg5JpnFaB+pCjyGcfwFWEaaHdQUEuC?=
 =?us-ascii?Q?INoAwKs48yAD9eSpN5azbfW9F1pyB1ROEhKazCqmNHlRQ71NgvyHsWMMfnDS?=
 =?us-ascii?Q?Tf/LtVfdxvJaPGKDUvDZEGKGV943qXbUDUydowzZAUlQo2Gz0eps+vzn0CwZ?=
 =?us-ascii?Q?KyEazWMOW8l3lIqKGXoBlnY5ZvrzkLBw6HRrkPWFIaxb6O5p+4RVZmltlzW3?=
 =?us-ascii?Q?HtAUghLw0Sp6zQYBuPSulfs+AL1cjA5w1zpZ12PknjAJDVSpJDyCey5Z/P+d?=
 =?us-ascii?Q?eAfmNmeV1A=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e76ee1c1-383f-48d3-ba9f-08da22c66830
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 12:07:57.5114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yxElzqIncDCZBBYXuXGwDsDfEDlLdpDW+a44pL9pFJjd/5ec8Mnzdc5YFUCPBj6+WBh1K3YuaRbGA4ngYxhVCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6247

On 14.04.2022 13:47, Andrew Cooper wrote:
> There are no .S intermediate files, so rework in terms of head-bin-objs.
>=20
> No functional change.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
>=20
> I'm slightly -1 on this, because
>=20
>   head-bin-objs :=3D $(addprefix $(obj)/,$(head-bin-objs))
>=20
> is substantial obfuscation which I'd prefer to bin.

Would ...

> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -1,16 +1,17 @@
>  obj-bin-y +=3D head.o
> -head-srcs :=3D cmdline.S reloc.S
> =20
> -nocov-y +=3D $(head-srcs:.S=3D.o)
> -noubsan-y +=3D $(head-srcs:.S=3D.o)
> -targets +=3D $(head-srcs:.S=3D.o)
> +head-bin-objs :=3D cmdline.o reloc.o

head-bin-objs :=3D $(obj)/cmdline.o $(obj)/reloc.o

> -head-srcs :=3D $(addprefix $(obj)/, $(head-srcs))
> +nocov-y +=3D $(head-bin-objs)
> +noubsan-y +=3D $(head-bin-objs)
> +targets +=3D $(head-bin-objs)

nocov-y +=3D $(notdir $(head-bin-objs))

etc perhaps be a little less obfuscation?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 12:11:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 12:11:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309203.525228 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh9BA-0005nJ-Fm; Wed, 20 Apr 2022 12:11:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309203.525228; Wed, 20 Apr 2022 12:11:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh9BA-0005nC-Bx; Wed, 20 Apr 2022 12:11:28 +0000
Received: by outflank-mailman (input) for mailman id 309203;
 Wed, 20 Apr 2022 12:11:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nh9B8-0005n6-OB
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 12:11:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 000c8730-c0a3-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 14:11:25 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-uwfWEGX1NVaOfO9FUaof_A-1; Wed, 20 Apr 2022 14:11:21 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB6451.eurprd04.prod.outlook.com (2603:10a6:208:16c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 12:11:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 12:11:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 000c8730-c0a3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650456685;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=A16MhQKcqURxxiTCYMO8bhIkjnzMaBlJC3Y088Jwy3c=;
	b=lw8JrDsXjc1AAJYR4OOjket6lnAoPh1VULe/xakCPhwzsByLe51YWwVemVs5SRXTHlBtfs
	zGNxCMg69LSuN207w9eH3AL+R7tm2+82m/fPz1489LHnsMttiw97Xfq7/SFEQf5QBEhVR8
	tCiwQRs0JZCFVi1I0hceWWsMdFqTrwU=
X-MC-Unique: uwfWEGX1NVaOfO9FUaof_A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VnruhpWk5xsIoYcAH6YJ4eoNzGPvlrNrpBvTrxZjuknnAJ9UBNJNNyaT/NMiMrsyaW98Mm4mXZee3+GAbohPUWiqpwHRWM3sdAF9KkkJYLXmzqK28FKQxZN8CHBHRDaFT0Qs/sct2Duac3rZnPdUa1OXFKJM8igKA+XLATjNpv9rlzCpVmt0HoVWc8TBNZT0Vg2WoOgQEx4WBte8skFxd0qkyBTVxs1pcHvkIgjkBCJ8GLoWa0UP9mViPteD/4LQLkJ8jRr2ymdPuUSDYv2xGG6tQZmgEAfa+a1mouLUoqGsl9JUX44zz5aiIZO0O/bqvcuuB3F7ADpKCDoOh49tkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A16MhQKcqURxxiTCYMO8bhIkjnzMaBlJC3Y088Jwy3c=;
 b=CvHHQA8Q07gLKNWBt//t+/xActUuiaTbTjfnJ86QnHop7unaUidJprzMNNHt51QV1iUJP2sL+k1/L2pSd2wPUgenYX4Q9qMttzqRsZuZvt4Zb7RgBXeZYF2qGXlbpkDkry7vwkWpU0zLtxG1GeUCzMh6y/VI5ryA2U5FREzOKDAjkE13qDi1sO16p04azIeA5gjRk7XHydpnfzC9F75nd6G0vjA0MJJfH4NbaOM/ci8k/kp0CM8fGtpH/Jw4ytdXIQGBeIdh2NqDa/SnPyv3ts7gPwcRFiXBL+Tfv7bxnKQ+ZaXQw60ZFQaqTdPMrvmWYIQOMhm0frPLJMrjYRjmTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8d2c6196-cf87-dccc-a84b-8ace1c4f1a42@suse.com>
Date: Wed, 20 Apr 2022 14:11:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1.1 2/3] x86/build: Don't convert boot/{cmdline,head}.bin
 back to .S
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220414114708.4788-3-andrew.cooper3@citrix.com>
 <20220414162739.7251-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220414162739.7251-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0058.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::19) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2cdf00e9-f766-4db3-446d-08da22c6e05f
X-MS-TrafficTypeDiagnostic: AM0PR04MB6451:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB64510D0C5F9CBEB916265ACEB3F59@AM0PR04MB6451.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mrq2j8qpSo6M+2e74MnYZUsoSFGwziuzCHk583GRD4FQBewZX635CEUODjRbvSHJtIOPS/CxhSJgCeSkSLy+hAE91ZM65V1VQZmurlptwaHemjdgfGTwZZaXtfTV49Ux064/eyoqdIKORx2HwNU+XX/T1zu5L9XkfkcFvKainRD+y0Nszq2GQeetuQHkt8+nSS3iZCd39n5eGvCc0byWs0LL73weD13ljhHZ8PXTFS54uHyZMTAc+BP86cDmlUSWFJSE/dwYT/nhWYYu+UBDICp83vf+3+b1/NRSSt9nPsR6mQaT5W/4KgfHQ7wU9lrC4nRLilM8b+4wREGQ0PXsKzkvI9ZPbaukF/Hj88RJHDnP8wsc9uda+5jjbjNz9ixqwvvwcyONojXUhREE4IiA2hN2rcgoU+TrEUXejwG0zQ+ILDC/W+ZRoSsnDPMHeI3gkHg5Tw1Z0Vk0kM6WrWr7zwbbweBaDV1se8hbThfBM7jchtrIYyQgs90M8ElYsC8fE7bGUmj6Y39w/EzckeQT6Yd4w8Wd+M4wa8u/rB1+r0PHvwvRuAICaIEc2KrkoI3IS5mmXtAW8m/Clpggvvjp5PMY3h+Ot6jj/IgfwhetWy6NbGMY8C5Y8EN/3ypGjiqT97/YiFe1y5yJIbE7K2ST3PfV02KktuHEWINK6e4XHYAn945ty/iBUkf+ddQkbFTY8fO4qXPXElCgvrFoLgddgAYWzGhbFeKQJCssEqR6Nio1UhCk/mzjiwP2l+rF5zKm7W5adYhrWZZbReCF2YinKA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(5660300002)(6506007)(4744005)(6512007)(6486002)(316002)(38100700002)(86362001)(2906002)(31696002)(53546011)(8936002)(66556008)(4326008)(26005)(186003)(2616005)(8676002)(66946007)(66476007)(36756003)(6916009)(54906003)(31686004)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SW1FQVg3U2xsZFJyOXVIRXVnVEpqdUZCS3BHTWZGajFWK25uTVJCRUYrS1Bs?=
 =?utf-8?B?MWh6cExaemk1d0pQQ3djSldBeFNJQTlDVWJ1SytEa3RCbEx6ZHhrQllDTWxR?=
 =?utf-8?B?Y1hXYWhndjZmL3RRZUI4QWhIcGVqU0dEdVNSWkJCenNxSFBDY3JyY2pEZUlj?=
 =?utf-8?B?S1BqNU9zbnBDTm0rV1hGdlZoQmZkK2s4d2ZzYWpUdm1MTG15RFlodVdwV0Zr?=
 =?utf-8?B?NDZ0ODVTczFqb085RVFwaGZyWDZvcGpBYzBybk81ZjFTMVIvdVJvZGxBa0lU?=
 =?utf-8?B?TUNrTlFtUm5mL2NPOEgwV1JraHlxQ3VZdEd1TnorNFNtSjFpSW8wUDFjTDVq?=
 =?utf-8?B?Z210aFc3Nmg1T1kzZUgvTERJK0g0LzUvU1BRaGlFVDRNb3B0ZnUza0paQ0xO?=
 =?utf-8?B?cVhjOHdMMTdBMThOY1NLbWwvQXJ0SW1XbmdHTVplSk1YN1lXazR4RVprVTNM?=
 =?utf-8?B?OGEyWWdDOUNtdWVOd2ZFUXZNQ21jeWp1eHRDcnFyeEpUeDR5K2tQcXpXbHBW?=
 =?utf-8?B?ZHkyaktKTjQ4ZWNYeG0rUXY4OHh1SUhXRjZlSW1ncUZ1aWtDOUJtaWZyb0xz?=
 =?utf-8?B?N2dNNU5RT3lGcVFyeTExbUZqTHFITDVzMW02M2t6RnN5WFBvdTRNMkc1R1Rt?=
 =?utf-8?B?M0M4UkpTZnNKcmI5djdhSFVtUmlubzIwaU0xN0NHNldVd3BDcnVIK090YUNF?=
 =?utf-8?B?RmxEOG9FUUdyTnNxUGdEcGZ5UkxKM0VyU2VNM0RpZ1RVZjBBQkR1NStSRHVq?=
 =?utf-8?B?K0Z1MU9PT2ZTWXlPVHVYbEx0cWZRYTRHb3FIS1U1ei8vTWU2akFrSU5sZ2ht?=
 =?utf-8?B?OHQwK1NrZ0NYc096Mzl1QzN5WDlZN3pybFd2Vk1RNk5IdGZsYzBLbXVnbmZQ?=
 =?utf-8?B?MnFqQ3VVbnZLNGNNVG53aVI1YVd4QmYyWDlqdUFxK1NnVnh2YTdBUjVyUUFr?=
 =?utf-8?B?L3BXRXJJaGlZdGFUY0l1b3lkRXlyWk1hMXpicXhhaUsrSUEyb1NzRmZxR0JK?=
 =?utf-8?B?NElsS1lWVFdwYUNSOURIRlpTNUFyL1Z6SGVtMVBKK0VDYkpNWVRPRzIzODlL?=
 =?utf-8?B?cFhzbnJUVXlhMGFzR2VaTThiTkF3bnBLaHdPeExrR3pWMnpSZE5xcE1TaDEx?=
 =?utf-8?B?eExNLzlhRU56ME1ncjE1cnhZOWs1MVVxbkdLcEIybnRnWXNyUW9ZSmptais1?=
 =?utf-8?B?NTNGb3I4TVJFWFozSm9oRE5yZzNSaFhRdmNrR0UrQ2dHZG1rZEpBalRKQjlh?=
 =?utf-8?B?OEszNklOdm81VGU4eXh5dVFQZ0c1WU40ampkNGhIS2RiQno3MVVwRS9TMGhk?=
 =?utf-8?B?R2M4KzNKaWRVdHo3b1VzTnNhaW1iTVZsaDA3TmpNeHV6VTFJcHB6YjRHVVV4?=
 =?utf-8?B?QUVPTWI1OEFleHpEc3c0cDZuNlFqMWlralgxUktzb1pCZTZDb0RQUStEdk1U?=
 =?utf-8?B?REtXazVITEtzVXdQWWNvWlZ1THlGMXJOd25VbXZXK2tadm4wUCtIdHI5M0lj?=
 =?utf-8?B?RkFWVHp3OWpxNGR6UG5JM0lqclJMclRsTUVNNlBuK2tKUHE2YkR5bGk2VnYv?=
 =?utf-8?B?QjNaZWM0TUgvU0NFZmpNRUw4NDd6clgzT1VtOUU2Zkk3WnJ0U3J2ZG85NHRI?=
 =?utf-8?B?dnBxRlk2OGdDbCtSaTIrcEVNSVdva3NLOEV5WU03QTE0bytjaTNzWGE4emlG?=
 =?utf-8?B?THlQcXl1eVNQOWdwaHR4UHpDTFBETEZ1SVBTYy9tN0N5cmcwdGpRTGRJakZt?=
 =?utf-8?B?dWRtV1pWUS9hdjlNRGliVHZ0Y09BS0ZPeDRuTm1BbjhOVDZzWHVZanZkcDhp?=
 =?utf-8?B?MTF6eGZQZGZEVStnU2RVM01tYjhTSzRLZVZoMmdTYlFmZEY2OUpaSEJQUk5U?=
 =?utf-8?B?dnE1TGxBcHRoZTlwZzhiaFJ1SUVZNVJOd2xyZk5HdnQydXJnSTlxai9yZkhL?=
 =?utf-8?B?MzRaSEdpMnU0Q3V4UFYvOHlxb0NqSGZkQ2xnWmtvUW92Q2dOeWhONFh3VUp3?=
 =?utf-8?B?dUVxZVkydGFMVG5IMzlqQnprcVUwbkxJSG16ZWhQUzd2NTFldVBSZnlGcGI0?=
 =?utf-8?B?aUx3anJ6eHAyWk43U0kzUjdQMnB3bThRbU9kWHRKTzRqRXhxNEpwNi9jeEtN?=
 =?utf-8?B?VFpySmtITTFUZ3puUGFoZlhhZHNQeXNubGtnZjRoVnZuRHgybGc0cmxpUFZ4?=
 =?utf-8?B?L1lpcnd3YnZUTnJ6NUg0SzF3ekJ1MUVRQXhJbzJUaDhpU29PNlIzTnhhVTRx?=
 =?utf-8?B?MUt6b3NQb3ZkblNTYVFueW5USGtSWHowM1EweldHWnR4TDQvUnpacys0YkFI?=
 =?utf-8?B?M2Z1aXoyNlI3dUl2ajgwUjlrdnJ5b1BkZkt3ZjF5ckFMMDRmekEwZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cdf00e9-f766-4db3-446d-08da22c6e05f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 12:11:19.0805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l2z4w9bvIwH0nuYlt3bMqNs8tYKLOUsdNk9Ws6odGZEBaprKr4Fc4s3X46Jsk/srbo6UjHHuV0fhok/wy9zjMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6451

On 14.04.2022 18:27, Andrew Cooper wrote:
> There's no point wasting time converting binaries back to asm source.  Just
> use .incbin directly.  Explain in head.S what these binaries are.

Hmm, yes. Why in the world did we do this all these years?

> Also, align the blobs.  While there's very little static data in the blobs,
> they should have at least 4 byte alignment.  There was previously no guarantee
> that cmdline_parse_early was aligned, and there is no longer an implicit
> 4-byte alignment between cmdline_parse_early and reloc caused by the use of
> .long.

There's no alignment associated with using .long, so I think you
want to re-word this.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 12:14:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 12:14:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309208.525239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh9EA-0006bN-W4; Wed, 20 Apr 2022 12:14:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309208.525239; Wed, 20 Apr 2022 12:14:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh9EA-0006bG-S0; Wed, 20 Apr 2022 12:14:34 +0000
Received: by outflank-mailman (input) for mailman id 309208;
 Wed, 20 Apr 2022 12:14:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh9E8-0006b6-WE; Wed, 20 Apr 2022 12:14:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh9E8-00073e-SA; Wed, 20 Apr 2022 12:14:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nh9E8-0007DA-F1; Wed, 20 Apr 2022 12:14:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nh9E8-00085A-EY; Wed, 20 Apr 2022 12:14:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=G7khnqOOxbdf9chSRMdw/1qdyVrEaRR5cdmpL+y4hxw=; b=h4DuwZZ3jsOk/eWpr53kY5nqSw
	Iz8Onrn+dmEeD1JbKE1zYw8vRiU9n76ANCzQ4W4TRFU6XZhUxirqf73TTbPtNE8zVamZSvII7Ca1O
	gJ0EK6mlFMbBEGWvp0yXSnJcQUp0fY9/m9ytPFiwF49z4XzxhUCVjDuUk6sVkpU23J58=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169566-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169566: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=78e072bc375043e81691a59454e09f0b38241ddd
X-Osstest-Versions-That:
    xen=e9935146cd695188e70c10a6dda9f24ef9b63e30
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 12:14:32 +0000

flight 169566 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169566/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  78e072bc375043e81691a59454e09f0b38241ddd
baseline version:
 xen                  e9935146cd695188e70c10a6dda9f24ef9b63e30

Last test of basis   169552  2022-04-20 01:01:44 Z    0 days
Testing same since   169566  2022-04-20 09:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e9935146cd..78e072bc37  78e072bc375043e81691a59454e09f0b38241ddd -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 12:47:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 12:47:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309218.525250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh9jz-0001yW-GT; Wed, 20 Apr 2022 12:47:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309218.525250; Wed, 20 Apr 2022 12:47:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh9jz-0001yP-D3; Wed, 20 Apr 2022 12:47:27 +0000
Received: by outflank-mailman (input) for mailman id 309218;
 Wed, 20 Apr 2022 12:47:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nh9jx-0001yJ-D4
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 12:47:25 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 055c0c01-c0a8-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 14:47:23 +0200 (CEST)
Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Apr 2022 08:47:20 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN8PR03MB4785.namprd03.prod.outlook.com (2603:10b6:408:9d::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 12:47:19 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 12:47:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 055c0c01-c0a8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650458843;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=NkeRCNNE6NO3vqwczH4AqDoKgpWiY9CwvYfF8dQKHvw=;
  b=HiXfRsYjLZlxhv9ajIPE1uiFeSvKsHmjx1CCHBu+eOtjkNqJakqlYJyl
   zQ5N+aM0tH1sUfpW0X2ZuYwkR/qM6Ubvj8h1Udirh8U/jFKTUF0Wk38YG
   c+SZc1ablQmL/HLIH3I7NEC8w0RGqZRUHsd1joUS6vfse1nDMf6lBmfd6
   Q=;
X-IronPort-RemoteIP: 104.47.58.105
X-IronPort-MID: 69507797
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:xMaRbKP8yJrhfO3vrR3WlsFynXyQoLVcMsEvi/4bfWQNrUom32dUn
 2scCGyFOKzeYWGhKdwnOd/kpEoFvpDcydVnGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NYw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 Olhnp33QyYSPobqtPoldQNeTSEnFPgTkFPHCSDXXc276WTjKiOp79AwSUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7EdaaG/iiCdxwhV/cguhnG/rEa
 tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2MJ9QrK+vtoi4TV5CpPjbHkEfWLQJutV+EPrhedg
 nnfoHusV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ
 lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/Y5lifD21dFjpZMoV+6YkxWCAg0
 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSsZZUvWd9enM/
 g23
IronPort-HdrOrdr: A9a23:LWy0FK7Lf2VcY3EOIAPXwZGCI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+843WBjB8bZYOCAghrmEGgC1/qu/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXerIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonis2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaQkEyzzYJriJaYfy+Azdk9vfr2rCV+
 O85SvICv4Drk85uFvF+CcFlTOQiArGoEWStGNwyUGT3fARAghKSvapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuKYlGclsRLYkjQpo+VY7bVDHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TpE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZeo6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z44HSKyGG4fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv
 fbAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.90,275,1643691600"; 
   d="scan'208";a="69507797"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oUVqb7/vjgJ/Bf4NdgWUoa35LQjncTWH3JNgfbPGJ1aaEj96jLQ7EaMQMDu+EOGChOxQM989rSGUKHzTC2yPAgXBqPlGxoZVpzsq96MWWDUkfi3Sck0URMGxte1sSivLYVRu9LrH1r8l0pJ8+1M2JsAMCKCN853/P1FfltGNyRhppaKwhivK/MebcfScuJxiynHmBXm9GUyiuCZL0b9xscWjb78Z1g6ZfBCE9w/XCavfuqi8HuC1JoBgGc8GfYvl8iTBhA6zocO513+gJg1lUUUzejeRAguUAwk00yVA1I0zYZe+tcizexcvuPjx/bOCgxX5XS6R6GxBJJAc5UYifQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NkeRCNNE6NO3vqwczH4AqDoKgpWiY9CwvYfF8dQKHvw=;
 b=G0uQ53vZ4EvsX9pgv/Ub5oun0rM2Je3nfRmF4AbMxXDs9wG5FqZDY083kILWK3YvYT+LftSNPfUPMRRXbmLbpN2DHOy3EQoekoM4ba19EqpY2mlhpR/djPT+JJLKxkAAju5/iFzhXPFeGDyj6ZDQLdCHXsssTnns2H4ifxHjs8m/MaYWNmD2zQIXfBEE5qGUx26zuUO420yY8JnUREVS6SrWF2CfyKuuWM7pasXf6KIJnGbs48cgxi1OxYr7bqNToDtMOU+NxBYNbsQTDH4aslev0vmM3fJG51oLWFEmppDV0BfkPddrMZd1Z5JtDYzOq5EXTFbHN6USl0e8sD+OcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NkeRCNNE6NO3vqwczH4AqDoKgpWiY9CwvYfF8dQKHvw=;
 b=KptddgDrLztx6yE0btN3c3hOqfLrJGiph8N8GqNbu6PEDTYKjnWAjawVd8DfNSgQcjA4FQEtWbXMKtyZgk2tn6VMwsdDmoUYcpo2u1vo49bvnDSk1BFyP2xfKPVnJOfG4NuYB17qOZLWNOUg4uLd1Lf8CfibwaDsUd4vV03zxQs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 Perard <anthony.perard@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1.1 2/3] x86/build: Don't convert boot/{cmdline,head}.bin
 back to .S
Thread-Topic: [PATCH v1.1 2/3] x86/build: Don't convert
 boot/{cmdline,head}.bin back to .S
Thread-Index: AQHYUBya0e9ha5i+akWuF9Hg8XHktKz4v0CAgAAKD4A=
Date: Wed, 20 Apr 2022 12:47:18 +0000
Message-ID: <c62175f9-7b8b-5bcd-9d48-7bcd6c45f7e3@citrix.com>
References: <20220414114708.4788-3-andrew.cooper3@citrix.com>
 <20220414162739.7251-1-andrew.cooper3@citrix.com>
 <8d2c6196-cf87-dccc-a84b-8ace1c4f1a42@suse.com>
In-Reply-To: <8d2c6196-cf87-dccc-a84b-8ace1c4f1a42@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d2f9146d-cb15-4564-cd0d-08da22cbe7a5
x-ms-traffictypediagnostic: BN8PR03MB4785:EE_
x-microsoft-antispam-prvs:
 <BN8PR03MB47853D52E5B845D62584916ABAF59@BN8PR03MB4785.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Zjm7VBhLmQzoSJGtDCwwuK604FTGe7hWnWyC/CrVXb0TAvElt4SBE5+EiW7kRkW0H/ogl1GpBUF4M5k/PzuzlTv61KGyV3gl21qlHjB5Vp+es5Cueemvl4CFCxkZZVuWMxqtt4YmVEJu8Re/gzPlY8akc5ovj+F5zAT6rGQLddCFlieZXdY7HRU3ZblsDY40jlhbJDmmEpJLEs5+56lv4+KpqoCmICN/NUj829JdhUDZ0Kgd0cDrI/gox+rcL5scRsXwfZoQvDKwi6ZVzXG14U8P47XJbLTpFEf8wyjsCT+j0GaxCKKGPuTJkSfzHnGCUDbeouOiIh38RIpF9E3wvAr+BPvAAgoTkjXrGWYUOYgK0+DiwEERK5k0dLZred/SOHyNXeSQbDTUuVaSP3vGNpUfpcw3HU6P89dEPlMsfTYPnkH54TCGggVHRJ3wzhb1NTXj843GdB/GoHa+wAT6gUcjlJlXigeUeNsgAmQ+oErYPTM2F0xLUKzSUulS+njQNtJPKVpDlFnPxlF0IUVNN9urLXJZyIHG83WrSwLDpQn51BYABfJkF7hI3XaOp688X5K8DHo27YOKmsKyaXDXxq+mrIFYSbAn2othOoE3F9YKnf2mRhGNAShc4G2ZMt1+jCTun4e55zaIa7gvKNSAZp8V7gagd6EhVwGnz6b81CMcbrKq4Hqt/22PEFeesREKuPFhR+vWwwQ5hKjuSb4PoDTw2iBJkLKM8hyWyA3hUpWoQ7nVZUv5Hp5aI3OcpqwemeF7/k/vgHhi4Vl11QnqL7XtVF3uEd/ON6/bDfYRDDs=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(36756003)(31686004)(91956017)(64756008)(66946007)(38070700005)(186003)(6916009)(66476007)(122000001)(4326008)(66556008)(66446008)(8676002)(76116006)(86362001)(8936002)(31696002)(6486002)(82960400001)(26005)(54906003)(5660300002)(71200400001)(6506007)(53546011)(6512007)(38100700002)(508600001)(2616005)(2906002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MkJpT2ZTTUJCbXdRTkFySTA2cWVJMjBJQWRKZVpUV0ltZ2Y0WGJCL2Zvd0F5?=
 =?utf-8?B?ZkUzVkdyMHlJV05SOWQ3SGRiWXJxd2lFOU1RZ1p4ZjNtak1mRHFqU1U5cFBq?=
 =?utf-8?B?TkdaWFJlRUE1NWQyY0FoLzRhS0FFZEFkay8rdVpuY3VvNUQ5VnF5dTBUNFpi?=
 =?utf-8?B?R1FoTHhIRDBuSmRFbWVPc3VKN29HdEhMSjJsbGlNTjZldEphazhMeWRsV1hh?=
 =?utf-8?B?UTladkRlakR3MG1kOE9EN2Z6Vlp6b2trLzh6WC9pV215dFpXOGJ6bEx6bW90?=
 =?utf-8?B?Vys2dVJWbi9NL1hSYUhDbTQxZ0lkYmFwVEJIMjBNWGNoQm4rQmpLYStZNmw1?=
 =?utf-8?B?L1p6eEt6V1JFdGNlM1hUUW9vSWF3dDVaTk5kWDdvZklSR3R3MjBWNEVDU09h?=
 =?utf-8?B?WWlJbWdUSDdCeUxJNFpxRjVSSGZTUGJ1WkFKRWlwVXgzWUtyTGtNZUlIdnIz?=
 =?utf-8?B?OEx0NVc0aEJ0a05DcnZRRlhBTWpOTk1UNGNQdUpudWUwcGVYZklFYVJsL2Rs?=
 =?utf-8?B?bXVrOTB5aW9mRzJPV1M3U3k2L0tIQlBndm5RdzVJcFE1bW5ZTFM0VndpZ3lV?=
 =?utf-8?B?UFBIbFlmWmRxNy95UVo2TWlKelFZakdnNFlObEYvM2xDMUNPdnlQZXJYdmdH?=
 =?utf-8?B?Zm05STFxeE5jWlV2YW9qRGErMG8xazd5V2NqN094RURCYVprT2FGWHI0T251?=
 =?utf-8?B?V3ZTcGpwTzlOZUhFb1M3Uzd1WUlIem02ckp2bExTY0ZKbXVWNlJNRE1nMGQy?=
 =?utf-8?B?K3hpNjYwR1EwODZEbVhuL1pZS29PYUVYaTRYRVJ2WjMwQWllbGU0YnMzWnc0?=
 =?utf-8?B?M0dDRU9ScTdqZ3laV0h5UXdlMjFQb3lpMzQ3Y0dIdW55VHFEd08zY3lwdVdu?=
 =?utf-8?B?VVoyQnZXYVlJYy9hM1I2R0h4Vy9LbzYwUnJUSlY4cW9kWHlQSlYvcEtmVTVQ?=
 =?utf-8?B?UWpqZldDZlJnSTNQd1VmWnhiYUlIU2l2amhiUitUWUo0WGhhS29wOGoxeDRs?=
 =?utf-8?B?Y1BCcjExTzN1cUJOdk9pazFVWFFRS3pzSEdDWE9tR1lJYmQyYk1ETmt6RUFh?=
 =?utf-8?B?UFljdVExc00xR1pWNUx3N3RUa2pyVVR5TVgvWW1zcW1kc09JNjk0b3dmRE5U?=
 =?utf-8?B?SVoxZUk1QU9JRzFoTjZvSTFHMjZueWh3NEtuaXF4M05JeTE4SDZNZjVQUDU2?=
 =?utf-8?B?UjBqbVg3YXphQkdlTTJwdVlBb3dwNTZZR0dEWnRTcFQxcjcxZFJUcEdURGs0?=
 =?utf-8?B?RmlhdWwzeUdUKzZqNHVTSlcwUVNJODRaSVJCemVMaEJiT05sWHBQc3ZjR1Y4?=
 =?utf-8?B?SG1YUnZOcmV2a1J0QlZpUUovWEpoRWZnSFZVN2FaR3F4T0ZxQnh5NEJSTkJE?=
 =?utf-8?B?bkpZSFVwc3lBZm5jZUVFanhBdDY2VVBWL3N6ak96UEN1VjE0aTR5WGhSYmNn?=
 =?utf-8?B?WDVYOExHNjF4amRNRHRDdjZ4U3ViMmRmTzZqWUxGYlhCYThwU0J5ZXYvaGFW?=
 =?utf-8?B?dThlR2M5SWRTUFVMaTErUzI0cWQ0RkpJS0lHVkVMR3VGb2FhcHA4SUlZVXJo?=
 =?utf-8?B?OVNwL1hTZTZ4TnUzYUNQTXJWL0krTFcrWlBxVTJDbVR0UTNjLzFCQnBzTHhl?=
 =?utf-8?B?L1pobXNYaEZmOEVRQjV2c05KT1V3VmQzSnVlaXh4RE84TERoUERER3VxUVl3?=
 =?utf-8?B?Z2dZMDF3WXhkNVJsSXRKemlEUnk2TXh0Z1IwcnRadFB1WmtyeEZ6eFNQcFlh?=
 =?utf-8?B?ZXNFWlJkb2g2Mlk0Skp5MUMzM2xQcExLSlVFaGltTFB1MmJXV3VnNU5IWXhU?=
 =?utf-8?B?a3ZPTGVaNTZHMi9zMjk0aWo1RHE1VkdsK2YzTzl2Q3MwNjRFb3ZzdnA2UFdn?=
 =?utf-8?B?aGJDKzk4d0R4MG50Mk42anV3VFBxUEZQOVhsUVM2a25sanNxL2dHR1B4amgv?=
 =?utf-8?B?T0ZWTFNCSHFrb0Vwb0VrbWRmUTRPOE9walAybGZkL3ZBUWo5b1FmZ2tITlFE?=
 =?utf-8?B?WGtsYVNqcnh0M1BnbUY2NmJQUjVrMG5oNU8wNHFoMkhWZE1IaWZ5WjhXYkRo?=
 =?utf-8?B?UFYreGQvNDNsN3RzRFZUNExIZ0QrS2tOeTdKZHF6d053N29uZUhtOG0zbEpM?=
 =?utf-8?B?K0s4Z1BLdW5CUzEzaCt1U1JnWEFvQzFaSS9uemROa29GdHV2anRqYWYxRUdo?=
 =?utf-8?B?Q3FvMTg0UUxVaUJPY2JkcVIwSFRaMlVJWEl4VU5tWFNMLzl2Q0h1a1pUbS9q?=
 =?utf-8?B?ODhETFg4N2NjTWdTS1piWW1tRVFLT0NwSkxUZmpvWkx6T1dSZHQ0YkhBaFhk?=
 =?utf-8?B?NEVHVmQ0K1libnlJVWNBejY3WGMrNE1Zd1hjWVBETmovWXNhNWhydz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <EB652EC187A5D8419B9C6D1025FE70BD@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2f9146d-cb15-4564-cd0d-08da22cbe7a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 12:47:18.5829
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xzgv/WGmejji4ohRfCAxQA/sBH0XDTR2ohA6C1DxZvak970zkaqTAKigwZKJ+MGki8FEZLskkcg2zlQgOdISVQygB7kzVhl8v2jGKjJtjK4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4785

T24gMjAvMDQvMjAyMiAxMzoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjA0LjIwMjIg
MTg6MjcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUaGVyZSdzIG5vIHBvaW50IHdhc3Rpbmcg
dGltZSBjb252ZXJ0aW5nIGJpbmFyaWVzIGJhY2sgdG8gYXNtIHNvdXJjZS4gIEp1c3QNCj4+IHVz
ZSAuaW5jYmluIGRpcmVjdGx5LiAgRXhwbGFpbiBpbiBoZWFkLlMgd2hhdCB0aGVzZSBiaW5hcmll
cyBhcmUuDQo+IEhtbSwgeWVzLiBXaHkgaW4gdGhlIHdvcmxkIGRpZCB3ZSBkbyB0aGlzIGFsbCB0
aGVzZSB5ZWFycz8NCg0KT25lIG9mIG1hbnkgZ29vZCBxdWVzdGlvbnMuwqAgT3RoZXJzIGluY2x1
ZGUgIndoeSB0aGUgZ3JhdHVpdG91cw0Kc3Vic2VsbD8iIGFuZCAid2hvJ3MgdGVhY2hpbmcgdGhh
dCAnb2QgfCB0ciB8IGF3ayB8IHNlZCB8IHNlZCB8IHNlZCcgaXMNCmEgY2xldmVyIGlkZWE/IsKg
IEFwcGFyZW50bHkgc29tZW9uZSB3YXMgdW5kZXIgdGhlIGltcHJlc3Npb24gdGhhdCBmb3Jrcw0K
YW5kIHVzZXJzcGFjZSBwaXBlcyB3ZXJlIGZyZWUuLi4NCg0KPj4gQWxzbywgYWxpZ24gdGhlIGJs
b2JzLiAgV2hpbGUgdGhlcmUncyB2ZXJ5IGxpdHRsZSBzdGF0aWMgZGF0YSBpbiB0aGUgYmxvYnMs
DQo+PiB0aGV5IHNob3VsZCBoYXZlIGF0IGxlYXN0IDQgYnl0ZSBhbGlnbm1lbnQuICBUaGVyZSB3
YXMgcHJldmlvdXNseSBubyBndWFyYW50ZWUNCj4+IHRoYXQgY21kbGluZV9wYXJzZV9lYXJseSB3
YXMgYWxpZ25lZCwgYW5kIHRoZXJlIGlzIG5vIGxvbmdlciBhbiBpbXBsaWNpdA0KPj4gNC1ieXRl
IGFsaWdubWVudCBiZXR3ZWVuIGNtZGxpbmVfcGFyc2VfZWFybHkgYW5kIHJlbG9jIGNhdXNlZCBi
eSB0aGUgdXNlIG9mDQo+PiAubG9uZy4NCj4gVGhlcmUncyBubyBhbGlnbm1lbnQgYXNzb2NpYXRl
ZCB3aXRoIHVzaW5nIC5sb25nLCBzbyBJIHRoaW5rIHlvdQ0KPiB3YW50IHRvIHJlLXdvcmQgdGhp
cy4NCg0KV2hhdCBJIG1lYW4gaXMgdGhhdCAubG9uZyB3aWxsIGd1YXJhbnRlZSB0byBoYXZlIGEg
NCBieXRlIHNpemUsIHNvIHJlbG9jDQp1c2VkIHRvIGVuZCB1cCB3aXRoIHRoZSBzYW1lIGFsaWdu
bWVudCB0aGF0IGNtZGxpbmVfcGFyc2VfZWFybHkgZGlkIChhcw0KZmFyIGFzIGludGVybmFsIHN0
YXRpYyBkYXRhIGlzIGNvbmNlcm5lZCksIHdoZXJlYXMgbm93IGl0IGRvZXNuJ3QuDQoNCn5BbmRy
ZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 12:48:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 12:48:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309223.525261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh9kv-0002Yn-VJ; Wed, 20 Apr 2022 12:48:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309223.525261; Wed, 20 Apr 2022 12:48:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nh9kv-0002Yg-RW; Wed, 20 Apr 2022 12:48:25 +0000
Received: by outflank-mailman (input) for mailman id 309223;
 Wed, 20 Apr 2022 12:48:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yir3=U6=marvell.com=nareshb@srs-se1.protection.inumbo.net>)
 id 1nh9ku-0002PJ-DU
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 12:48:24 +0000
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
 [67.231.156.173]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2981ee39-c0a8-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 14:48:23 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
 by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23KAYT2H009244;
 Wed, 20 Apr 2022 05:48:13 -0700
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49])
 by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3fhtapd81c-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 20 Apr 2022 05:48:13 -0700
Received: from DM6PR18MB3193.namprd18.prod.outlook.com (2603:10b6:5:1c4::10)
 by BY5PR18MB3202.namprd18.prod.outlook.com (2603:10b6:a03:1ac::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 12:48:09 +0000
Received: from DM6PR18MB3193.namprd18.prod.outlook.com
 ([fe80::987b:cd7e:d809:9a45]) by DM6PR18MB3193.namprd18.prod.outlook.com
 ([fe80::987b:cd7e:d809:9a45%5]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022
 12:48:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2981ee39-c0a8-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n8ZOIPNiWx5JW5GFsNa+m8hNtSz1o9ouA4C/xXk6mB+kccEQpZzmaZA2NXTwYg0KxjGEQ/04xFGdPD/3P2sJ7tzGQN1LTfPx+RA5DAf3fhxhbT9JSRksx676qMsEOn0C0NheX7DGrc100RqzKm4pMzzN9XE5uJsAYkfcgd9ELAhlwE9r5wYPcWP7vXHvYlVTwYcCTPThPe5i/YakVckmbDdIywueYF/06n7VvasBnFxaFZNX7MWHokyqaV1f3+x9RMrZI81B9OWJORjN4kaNcMCikLi1avIh4MNxlGiQTWoPZ4kkG7S8Ijxbu3bl6ubgObvxRzUcB+H11oFXMGzT/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tZ4XQfscFW4XNzWpat06473mKPO2/jW7rq0jSMlmmFA=;
 b=B9eTMSrnTo2tbA0vGQjmjBjy2mjMqJvhTaoeqSmJOvG/MHUP0GViF5pzmSaVPE2fKYQqfM2zpumw58bki6Gu8A1hNU+a72BWw3/oWCX1VDWGFcKLBDK772Z6WLAk6NOVvRnxdadVuEG8nq5aVv6QyRe66JgYECdkDALwU5KUj1bH3RmEuSMYjRR3q3pZ58430PekbhRYuGaemuCF0fVxohaLNFMfb+Ym7XsekPJ1QroCyhGsIYFzM212y1Z018JraotQwqpU+l7BiZpQJmYEhpcG3TjPqYC0WpWwmuvX01iHqwxmaXiovwop5sxLtRmrouhs87r0mZaSBe3a3Nl19g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
 dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tZ4XQfscFW4XNzWpat06473mKPO2/jW7rq0jSMlmmFA=;
 b=DyOBoic3ZIUYof65nZIFiR5Q47FkCAgeS1oisdBCQixhcDzWZ+QwPwVcDspbHrkHpFr0QLGW68KG2Sk3e/j7V6pyLrO8zT/1HNJf/7gPR8kBpDfO3JwX+RZkK8jH1ua92ABv02V9mtr9jOZvU8XmkpGzIvgr/cTQ2fc7FVere5w=
From: Naresh Bhat <nareshb@marvell.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>
Subject: DOMU: Virtual Function FLR in PCI passthrough is crashing
Thread-Topic: DOMU: Virtual Function FLR in PCI passthrough is crashing
Thread-Index: AQHYVLOBoc8zYi1khUW56WNBox6p/A==
Date: Wed, 20 Apr 2022 12:48:09 +0000
Message-ID: 
 <DM6PR18MB3193BA01B3A6FE2A4A9EAE5CB9F59@DM6PR18MB3193.namprd18.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
suggested_attachment_session_id: 3881f8c8-5b13-69d0-d21d-4a02acccd4cb
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dca3b9df-6a12-4e82-a124-08da22cc0637
x-ms-traffictypediagnostic: BY5PR18MB3202:EE_
x-microsoft-antispam-prvs: 
 <BY5PR18MB3202137F228FC623A3452F07B9F59@BY5PR18MB3202.namprd18.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 tl8iZAtZATbn04Wm0GC95yWbUsVFSJbpX5MNf92tW3xN/KCz3GA9fSuWrObD0bAjA0t5Gx4d1Hz75uQWk6XRUuQLr3R0iTTWBclbO0id9/WXngRLF6KvRea5SNEHp++zr+C3RKDB3viXwps8vC8vFvIheroTITLvcsOi7wxRKA4b2rL4uWK6Q7janj/aBsqzPZSCZsp7xzNAdAMKK4Zc3vQJ5Ni2LwpjNcpEaWOQ8tL+iKRqYNJKQC3glLempqKYhyGfUFXA3DdngO9xpIzAMkv6B4xX5mKN0C/BxbNJtAr0+kjvKHSIXUu9euBnkOsii5dYrq3mwGfn1otXlwMG8ApcXkE6Dq20VLrHZaeXfZJ8vzfeMYhkOibyRuM+Z7gVcSJGy9PhxinVwNHpIv+gkAYLGwixbvADMinBC3ugvWrFfmzmfMrULEG5iTCc7P3ve87dYOpbNZbVYETnCZyr2kV0DQTC0eKe/haeRwKv9v3roPvMwiusskahdfQcCI3he6/4KjRzzhONABHm9KSbFgfbLUcfe5uRwCw1V+5V3W8zU6LjANynAmtqqDFsFPJgn4GklGS0Pw4MfKp9g0Bl4RD1xr9Cb6CrpCUbqAqITM93NeuDs78odHbQF+cQ9jtJ/J3dNzNGqmgrvCmJGBUofDu7PeQ/oV5OtXLNqMkAUWh//P6nBpVJoPoQv/HAS5FnJkWGJ2FPIuFQxkDS+jyR/Q==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR18MB3193.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(33656002)(54906003)(508600001)(6916009)(66446008)(66556008)(91956017)(66946007)(52536014)(76116006)(71200400001)(45080400002)(4326008)(8676002)(8936002)(66476007)(5660300002)(64756008)(86362001)(9686003)(6506007)(7696005)(26005)(2906002)(83380400001)(38070700005)(38100700002)(55016003)(122000001)(186003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?NonSnZ2aIzPSH9AO5yYKXGcW+eOpSy1uEPdaDl4WVjmzXSF01b7zmzwVmG?=
 =?iso-8859-1?Q?Cn1G5ZJjjglJXB0+tKpej4DtQyI7f7gE3cmbfaL54pbWYNVvg7hLj355qw?=
 =?iso-8859-1?Q?EkIBg+bdYlJcAHMJIfK+fLy4v6s+ejtIpmx2KmTWHlQJMNwNaP/oGiOEZ1?=
 =?iso-8859-1?Q?IGRpOOra7e8aWd1ve6Gre9lLdJGmAiZYHiLLR/mBtfVKyHoHrgj/oIahwP?=
 =?iso-8859-1?Q?xX1AOsDlOLfaCGFALtNTGWN7ZXdcWHjP6FGQC2349nJ0KGaTYtAJVZLrdK?=
 =?iso-8859-1?Q?aaoiJVQdsfxnFgB+m47NmM1ThNKYmLfIgm+zrwfmrLeDRv38/iGBK+Lh0R?=
 =?iso-8859-1?Q?FI+0Ne6AeloDy9pk28CW6oPCNfOuD8DP0ZVaK85PYlllF9lX1x7EGQBQz8?=
 =?iso-8859-1?Q?QtCz3kJr1LqJMczJLt1/UpH8DBFt5TYMGzqjQF9dbNXk313112GycBbSEr?=
 =?iso-8859-1?Q?6s/kZ8UAARqE/VIAnmGgUR+W5vYqnYefOr7SFfc+KC8G3tIBoWtC/mXmHi?=
 =?iso-8859-1?Q?wlRE3eHvYxcaW+JIeyG0FgwLc4ssEjKYLlnq1a63HQUTXvalnc/xbCfEhA?=
 =?iso-8859-1?Q?WvZSjYaNf4civvTadldBWq2QjHYx//WxMki5dqLaJOUpUyiExsrPIX+M1P?=
 =?iso-8859-1?Q?/g7BfeQQl6sYP6jCVQF+3yiiSIeEN19yseVSmN2BdeWrkHQr1ft0vzMth1?=
 =?iso-8859-1?Q?PDFj4/Ps57JsDB4uhR6d/4mtV0a7k0pM4BbNNNFj2/5W/wWuXIMh47XIFJ?=
 =?iso-8859-1?Q?Ae/e5WVflpmfpo1hayIcbhyMcQHXHN+yurLp7q6XwaixrLExWTeGNMCfbo?=
 =?iso-8859-1?Q?9vmAZL2EyO8Gwe2Lx5PnWgPnhuKMGIw99nMBqgS98yJSadcN3XwBFSGDkU?=
 =?iso-8859-1?Q?8RsLKX/Y2WrBxqrRwkereqExlJkClUAQpyRATQizH3IAwB3UqJy5qGBfHt?=
 =?iso-8859-1?Q?eii2jf+ssNQ9pqUdVAVSgkm4dgKLGec/FD5lnyroOBWhCdpN/yyDn/gpr3?=
 =?iso-8859-1?Q?O1+QQnuH11NhddKl+4Y7Xa+Jf9k8TMkf+tDrIXFga4ML8LE5xE4QwvEZWz?=
 =?iso-8859-1?Q?Rot30kuHVX/Gowu4vko+IDibPRWmlQJuUCMjhKHfLrdKBMYPsZcdPcf+zF?=
 =?iso-8859-1?Q?LUSSsX3VRNov4VL/SQB0ZWLrtIVu07WJFzPYZX3+vJW94UG2ygoZzHylL4?=
 =?iso-8859-1?Q?+nzvTBMesEWpdbxosjAuj7k+7ERtzsPKIthY+gnsJvBtGm2TiRWyTdFAzv?=
 =?iso-8859-1?Q?NshG7uRuK85Aa+zRiIjY2ilfo7VrDpyJoSAzbazD8RkXvWv0yON59hpBGX?=
 =?iso-8859-1?Q?AGRx3is351rO+gcAas4sWMGQaPUD+KPX3/yisFD/CQRSz5990FFAIwzajs?=
 =?iso-8859-1?Q?BVQr30ZERK4Md+BbTWD7VJa1liK6ZeZ3nOhMKhxNC24xt0fK1mHKSW1djP?=
 =?iso-8859-1?Q?MikPQaNC9HNTUUiEUyW2YmcgbAt68SjJq36VvQxGYLda/M5XtIP67AEPOF?=
 =?iso-8859-1?Q?UsSHpX30Qgt1hSxMPZiNqrE4r3ATRieomr5ibTyqHP4SyPiuydWGkBgHdY?=
 =?iso-8859-1?Q?V3fBuMd+qEnw8ezQr+1BCHY2GmawS4YXQSUSU1UMYhNwcx9vwluMeGFxhB?=
 =?iso-8859-1?Q?y+x4V3c9QZEnphUcUgf6R98V3Cug55+fj/NMLw59KvJ4YGWgDctrPf323t?=
 =?iso-8859-1?Q?zrSBi++Gut6wNPnzBD7wcUAhc5Xt0VtSNWPosvcRLvKsF7samqx2YOOZHn?=
 =?iso-8859-1?Q?lKo0KYIdL5OLmmH0KOpltlzFxl2G9iTT2PcYV6e86hDHudg+rcwQBBiAAr?=
 =?iso-8859-1?Q?baoh2hSvog=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3193.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dca3b9df-6a12-4e82-a124-08da22cc0637
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 12:48:09.8859
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /mofZv0qsdBwwC7oTmcvbXNW9rdKbi1wz88A0901vS+KV0l19zmBbR6/HZUYJ0Y7jlqG9zkRTrTRlzcLCvcHRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3202
X-Proofpoint-GUID: IzSFc1nd7knrHx4kjMwmV7Sr5HweBjAR
X-Proofpoint-ORIG-GUID: IzSFc1nd7knrHx4kjMwmV7Sr5HweBjAR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-20_03,2022-04-20_01,2022-02-23_01

Hi,=0A=
=0A=
I have the following setup and try to test the Function Level Reset feature=
.  Any suggestions or pointers will be very much helpful.=0A=
=0A=
DOM0=0A=
Distribution: Ubuntu-20.04.3 (kernel 5.8.0-43)=0A=
Xen version : 4.11.4-pre=0A=
=0A=
DOMU=0A=
Distribution: Ubuntu-18.04.6 LTS (kernel 5.8.0)=0A=
PCIe device with SRIOV support, VF (Virtual Function) interface connected t=
o DOMU via PCI pass-through=0A=
=0A=
Issue on DOMU: =0A=
1. Enable MSIX on DOMU (We have used the following kernel APIs pci_enable_m=
six_range, pci_alloc_irq_vectors)=0A=
2. Execute FLR (Function Level Reset) via sysfs interface on the PCIe passt=
hrough device in DOMU=0A=
   # echo "1" > /sys/bus/pci/devices/<ID>/reset=0A=
=0A=
The following crash observed =0A=
=0A=
[ 4126.391455] BUG: unable to handle page fault for address: ffffc900400290=
00=0A=
[ 4126.391489] #PF: supervisor write access in kernel mode=0A=
[ 4126.391503] #PF: error_code(0x0003) - permissions violation=0A=
[ 4126.391516] PGD 94980067 P4D 94980067 PUD 16a155067 PMD 16a156067 PTE 80=
100000a000c075=0A=
[ 4126.391537] Oops: 0003 [#1] SMP NOPTI=0A=
[ 4126.391550] CPU: 0 PID: 971 Comm: bash Tainted: G           OE     5.8.0=
 #1=0A=
[ 4126.391570] RIP: e030:__pci_write_msi_msg+0x59/0x150=0A=
[ 4126.391580] Code: 8b 50 d8 85 d2 75 31 83 78 fc 03 74 2b f6 47 54 01 74 =
6e f6 47 55 02 75 1f 0f b7 47 56 c1 e0 04 48 98 48 03 47 60 74 10 8b 16 <89=
> 10 8b 56 04 89 50 04 8b 56 08 89 50 08 48 8b 03 49 89 44 24 20=0A=
[ 4126.391606] RSP: e02b:ffffc90040407cc0 EFLAGS: 00010286=0A=
[ 4126.391623] RAX: ffffc90040029000 RBX: ffff888164cfb120 RCX: 00000000000=
00000=0A=
[ 4126.391639] RDX: 0000000000000000 RSI: ffff888164cfb120 RDI: ffff888164c=
fb100=0A=
[ 4126.391653] RBP: ffffc90040407cf8 R08: 000053f2d6975617 R09: ffff888169c=
4e238=0A=
[ 4126.391672] R10: 0000000000000000 R11: ffffffff8266b248 R12: ffff888164c=
fb100=0A=
[ 4126.391688] R13: ffff88815e81c2e0 R14: ffff88815e81c130 R15: ffff8881648=
394a0=0A=
[ 4126.391723] FS:  00007f72b4b9b740(0000) GS:ffff88816ac00000(0000) knlGS:=
0000000000000000=0A=
[ 4126.391742] CS:  e030 DS: 0000 ES: 0000 CR0: 0000000080050033=0A=
[ 4126.391756] CR2: ffffc90040029000 CR3: 0000000167b10000 CR4: 00000000000=
40660=0A=
[ 4126.391781] Call Trace:=0A=
[ 4126.391799]  default_restore_msi_irq+0x38/0x70=0A=
[ 4126.391818]  default_restore_msi_irqs+0x2f/0x80=0A=
[ 4126.391836]  arch_restore_msi_irqs+0x15/0x20=0A=
[ 4126.391851]  pci_restore_msi_state+0xa1/0x230=0A=
[ 4126.391870]  pci_restore_state.part.0+0x319/0x440=0A=
[ 4126.391888]  pci_dev_restore+0x4a/0x60=0A=
[ 4126.391901]  pci_reset_function+0x4b/0x70=0A=
[ 4126.391915]  reset_store+0x5d/0xa0=0A=
[ 4126.391931]  dev_attr_store+0x17/0x30=0A=
[ 4126.391944]  sysfs_kf_write+0x3e/0x50=0A=
[ 4126.391958]  kernfs_fop_write+0xda/0x1b0=0A=
[ 4126.391973]  vfs_write+0xc9/0x200=0A=
[ 4126.391986]  ksys_write+0x67/0xe0=0A=
[ 4126.392002]  __x64_sys_write+0x1a/0x20=0A=
[ 4126.392018]  do_syscall_64+0x52/0xc0=0A=
[ 4126.392033]  entry_SYSCALL_64_after_hwframe+0x44/0xa9=0A=
[ 4126.392049] RIP: 0033:0x7f72b4277224=0A=
[ 4126.392064] Code: 89 02 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 =
00 00 66 90 48 8d 05 c1 07 2e 00 8b 00 85 c0 75 13 b8 01 00 00 00 0f 05 <48=
> 3d 00 f0 ff ff 77 54 f3 c3 66 90 41 54 55 49 89 d4 53 48 89 f5=0A=
[ 4126.392093] RSP: 002b:00007ffc5236f578 EFLAGS: 00000246 ORIG_RAX: 000000=
0000000001=0A=
[ 4126.392114] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f72b42=
77224=0A=
[ 4126.392128] RDX: 0000000000000002 RSI: 0000562bde52f440 RDI: 00000000000=
00001=0A=
[ 4126.392140] RBP: 0000562bde52f440 R08: 000000000000000a R09: 00000000000=
00001=0A=
[ 4126.392155] R10: 000000000000000a R11: 0000000000000246 R12: 00007f72b45=
53760=0A=
[ 4126.392171] R13: 0000000000000002 R14: 00007f72b454f2a0 R15: 00007f72b45=
4e760=0A=
[ 4126.392185] Modules linked in: <driver function> intel_rapl_msr intel_ra=
pl_common crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel cry=
pto_simd cryptd glue_helper rapl xen_pcifront sch_fq_codel parport_pc ppdev=
 lp parport ip_tables x_tables autofs4=0A=
[ 4126.392228] CR2: ffffc90040029000=0A=
[ 4126.392238] ---[ end trace 23e8ad345e1ef956 ]---=0A=
=0A=
=0A=
Thanks and Regards=0A=
-Naresh Bhat=


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 13:07:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 13:07:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309230.525272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhA3C-0005LO-Gy; Wed, 20 Apr 2022 13:07:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309230.525272; Wed, 20 Apr 2022 13:07:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhA3C-0005LH-E1; Wed, 20 Apr 2022 13:07:18 +0000
Received: by outflank-mailman (input) for mailman id 309230;
 Wed, 20 Apr 2022 13:07:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZ94=U6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhA3B-0005LB-9p
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 13:07:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cce31b9d-c0aa-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 15:07:15 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-nz7PdrciNt6wqHE0gCiDrw-1; Wed, 20 Apr 2022 15:07:12 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB4138.eurprd04.prod.outlook.com (2603:10a6:5:19::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 13:07:11 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 13:07:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cce31b9d-c0aa-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650460035;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=H/K3F3UrZRB/ZyGYDvjGe1Wk9XC2zVjl4+MXZ2dzlFk=;
	b=GgIOvaUUcXSSZAs5gNyFuYE2BsLKqnAVgkz48v0+PlPzR1aUm2Spr/nefg70zYb+Aznt3i
	PsThM1zdNM7DuCxCmLvLzvzwOtWmuwOoQTaT/Ozwd2INFvkBIw3bRu/6KqoQWDH/xAdUXC
	KUEFxf9WWezTlcejNLxiffESxPZ0Kco=
X-MC-Unique: nz7PdrciNt6wqHE0gCiDrw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eZXfjoqGF0Jyf6FThr1FyqDRE2BWMK2fV8lr3JsrJIvV4UmekENOw4RTTlGdvsTClih1OpXGDoUIkC4/2vBDalpf0rDa5jYTrrwLdZeoB/lztxFv+lljB+neMhIrLqce+4t5yE7yHFfE6hnxvF1lIL7LEF42ugPKNYQYO+qbHTo7rWj5Bdu2aIsacUNdBU0jJQJ/lVGAXeHQdShFe4lnFk58x3CH2IPGa9q6tH4ALNcKl/9W6Gakz8oiw6OwgvBDL4vtk6YwW7A3CcocYgwfUf2oW+QZjPer4QGuEQELIBD8n22eLv9tC3txCD7Y2bOdgJszIe0Z+nLhrBM8EloVjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=H/K3F3UrZRB/ZyGYDvjGe1Wk9XC2zVjl4+MXZ2dzlFk=;
 b=dfWCeS0UqMmXh4oETGmWAKK3I26ZuDmkxo6Iq1oP140uUv3mVh1RjBchSo8QW5zjebZQcvGDdHYfyX7+5HQeDOC6uYBadgK9tZdu7uuuViDHdKKBLyopUgK9wuuiFttHBO9pxso7rWdtfjtk9diEZwh5CMuzlvzeraucDEaHHuMoy76ARDjV4EHDiYcrqNf8DsnGy3gAWPcaUGJHtKwaCq+LHxu240jIR6gPJLX/f1oJjBNEKjpaAZdFCbY9MZRplk9+58lD/xFD2/Yl+WWVFoQUshKTrnejOY0yHUse5bopNJGbJoPFCdM/V89mM8Vu8zMbQbaWFTkQgMsOyG1kfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7d1d06ce-6bbb-b4c6-5b59-32ac37e41c4a@suse.com>
Date: Wed, 20 Apr 2022 15:07:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: DOMU: Virtual Function FLR in PCI passthrough is crashing
Content-Language: en-US
To: Naresh Bhat <nareshb@marvell.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <DM6PR18MB3193BA01B3A6FE2A4A9EAE5CB9F59@DM6PR18MB3193.namprd18.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DM6PR18MB3193BA01B3A6FE2A4A9EAE5CB9F59@DM6PR18MB3193.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0152.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::21) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3a12d30f-951e-4cf3-6519-08da22ceae2c
X-MS-TrafficTypeDiagnostic: DB7PR04MB4138:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4138128D001254DDE3558D50B3F59@DB7PR04MB4138.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7UjSOQc1MCX2qYU2jVUCUKnngjUpKBMoVN6h5lOLc0ikrjGDbnZZLPIYO0tCp6ZBTvcg0zELYyQEKGdjOYEA9MhIp2kdTgIlcqdFPqNg5fXAM8N/mA85FnBEcq5ycPZH7Uyo5zYbbZaM0z9hcr7MVq1vndm7tB9906iHJYMgr8cmZ05msCUhVgz4zTEE0amNjIsrix0GbbCF2Rm319eM83HXP7ImCXiBwC+iVKF6SXnxHUdwbCM+/liQ6do2CbLSzLvh7uQD54Mhd+H9QWnvWX/Iiur0Etb0ZHIUzuzFKyhfUQO7DqW/06DZdNzluMfrKIE6EzYJsBonB0EuAO/Qtbgd/RZNhzM/8lZfc3bEbFY8hRycsBdAaw6rHIR2dP98Ehxb7VL2wl3t6pKDgyUNbSd3dxm14Q/moWnURhvEqQ5lF7BbFHyQfmbwO1Xfaei/M2Ujk2Rw8i0nEgSgRLpMpYIUDrh7EPL+LjsEUW0HD+iacWKNLtTY/ew4fCjsnLXHPacmwvhqHrIbVQseLbGeNe4kls6foRwRORDqwXyNjfVFMZEkvR5o8BZ5/avBEm1IZJHnv+Vl79wtVgzykJedeydpIIQHfgOw9cFJM/nrouPw+ycS4QiuxBhKyGkHitb2X8wdWcBI47fAyz8r2DPQkAueLb2hrWfOtBjeBdQJTAcWhU17JPYt7+xHDOHQFK0WMcI7Y7uIJ4WfrL3qm5Qah1rPmCCHVOo0yG3CSZh3mSE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(66556008)(53546011)(54906003)(6512007)(8676002)(508600001)(8936002)(4326008)(6486002)(83380400001)(86362001)(66946007)(66476007)(38100700002)(31696002)(186003)(26005)(2616005)(31686004)(36756003)(6506007)(5660300002)(6916009)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L2VNaDRRMHVTU1k3c2ZUU2h1TjN6d2J3ekZHNmxTMEJWWWZ1T0xCVzY0SWVw?=
 =?utf-8?B?WUtZdk1ZdEZPTERyRTUwWmdKTEEyZHlOR1Bnd1FOeHUwajVwdGgzbWxFRWhX?=
 =?utf-8?B?WVMyWlZybktvMExJenpzSXdQWE5Sb1pIN3dPUXBUdjhLLzNpUVB6dHVZL0Ra?=
 =?utf-8?B?YUxCOVc0WEZiZUZ4Z2Y0RzR5cjR3YUR4RmFIeVF5clQvS3c1dTNib3kwdE0y?=
 =?utf-8?B?WnlFVUJvY2l2RTgvbnh3MGFJOVFPN3M5cTdTVkw3SkJNcGtTMDRQVXVWM2k5?=
 =?utf-8?B?WTZhamFVQTJaRXZ1VnFrYzBCNXZyZTJiRStLWTBTbVp5OHI1MUNVVlF4c2th?=
 =?utf-8?B?bHg4eTFBemhqUWVObHBWM3Zxei8zYWJrUExUSUxqRE51ZDNSV3cwTXloRzJI?=
 =?utf-8?B?TmZDUEI5VXh1OUQxdSs3b3NMUnIwdFdmeXJMYUJOaktlelBUVVpJVmlaQlZj?=
 =?utf-8?B?THZIdC9DMHFuZktOOGFmSzFJSlhOR0UrWTQ5aGlpalU3NE9lZnpEbW5MbnFF?=
 =?utf-8?B?bm9KRVVCemxQUlVEWTlqckg2RHFqOFMrZk42L1ZxZHNPMkRSRWxZNzZCejh0?=
 =?utf-8?B?d0VXbUxIMmg4cGppdEUvUy92bzVQQzE3OFZVQnYycDhmL3FVd3lOZHNJb1ZQ?=
 =?utf-8?B?dy9qU1djdUFoanB3cjlZTlQ3ajd2VUhNc04reEZ6NmJ4dGxTOS9tbnEzR3Y4?=
 =?utf-8?B?NERPdUZhSnpoN1BXbG5PRjZhRTc3Z0ZGRmc5UWhKak45VmppY3RQTGlTNUph?=
 =?utf-8?B?cUhrdnkzdkxSK1cxRkxsMHEzZ2wxS1NjMXhYR3g3bkJyY2ZBU2ZpSElYc0lD?=
 =?utf-8?B?KzM5V0xhRkZZZFZmVFJXZUVzMWx2bW9URTJ3OTVxWGliUGRaNWRhTnFjZno3?=
 =?utf-8?B?TXg4eTU0QlM3dTllVDRMdjhPaFovTUtDbEs4QTJvdGVjZW8vRzY2U3NXREN5?=
 =?utf-8?B?Sm80ZGY5ZUF4dk5pR1ZGaTJPNUtXNElLcnBHWkttTjJ4QkJBT1Ntbk05cWNB?=
 =?utf-8?B?N01Pei85OWF3M1RYNkhvQmg0R3QzT1FYVmtVMlBPUjc5UVB4Y0lhQmtWQVBi?=
 =?utf-8?B?U0Ewb0Jqd2l6SzhJQ2x6V1JNNVhrNTQwRldoVFBpc3ZGc25ZendwNHhQR1N2?=
 =?utf-8?B?RGs1bWN5d2xuQkJVV0I4ekJUZlFDR0IrV2VrUExVU2lGSnF2dm0vYWxveG9x?=
 =?utf-8?B?TGxlTkYwTzkyZG1jdDh4WnB5VlJ0RTVFR3NDQW9zbmtDK25DVzlmZGJwbFZp?=
 =?utf-8?B?WWZnWTFTV3JjdzVhU1FTRWR3NlZIY2ZrTjRlbW1PV1UrcVlBZ0JKNTA2UVpx?=
 =?utf-8?B?aXFBNmFnbWJ1TlNUK0NRSWUzanZHTlBxb1ExL2dwTzV5YWRPdllsbC9kdTM1?=
 =?utf-8?B?dTRtRnd6QWI0V1ZwMFRQTGF0SVJTaElWY0hVTCtoMEZMRG9aZnZlU3MvcWFs?=
 =?utf-8?B?c2E5VjBQNVNJMG96d1hOMzIvT3BZRFNWd1ZkNnFhMzVrZGJEdnlDcklmeWZQ?=
 =?utf-8?B?aG8xWi80dDhyb280c2lYRXlnems0amFtem85aFFYL2RpanZmTjJBSGFTNHBm?=
 =?utf-8?B?dkIxbXN5WGgvUlUyY3BWV3BEL0ovaXpOaCt6UU1scXFiM2gxZXZYWVpyRjFP?=
 =?utf-8?B?bDU5ck1Bc3orNXdCQU9oSk82Z3hwekFVNWFqaW1yMVhDbTR1Q2QyYXRxdFVr?=
 =?utf-8?B?SmRvM3lvMS8xZ09WYkdoZHh3VDVHamhqUThjUHcvbEk2T3RvKy9sQmVKb2lR?=
 =?utf-8?B?b05kaC83MmpqU0NrdkpJZjQvdEJKZXEvUkNZUUpnbCt3OTNYQmtpWTFhaGFl?=
 =?utf-8?B?cnFFYk1kZWZBV0d6RFdIaXpnM1c4MTRYZFo3UGkwOS9PTlRleUdpcmo2dTFX?=
 =?utf-8?B?eGl5L3BtMGdkNDJNOGhyRGx4UC95RURoM2NtQ0tXWFZIOVVqNHJMbjRaNW9R?=
 =?utf-8?B?TXpqdHhSckozSHFESTAyamI5TzBsL3RZSEZycWZyTWRJZGlOYXVTeUlyeWF6?=
 =?utf-8?B?UnNnTThVWjZWRkJvcHg5V1lYdG1jQUVGZmlDQ0pXaWRsUU5Cb3hVNkhGMVlm?=
 =?utf-8?B?MzIrNU5FOXllS29RRTY0YTRiU1Evdmhja2hucnk1Vkh6eXdXbjIvTSs2dWwz?=
 =?utf-8?B?RXg2YVJxQmU5ZFZZczc5U2FNYnNyemVrays1V241c0YyOUk1L3dTNXVkYUxC?=
 =?utf-8?B?Y2YvaGNhNlhaRGZCaDVVZStyUHJuT3lyQmlmSk5aa0NnUnZkM2JaKzJTRHIw?=
 =?utf-8?B?N1JOU3Y4RVFhcDROekhDdDVnQnhSdGRJam1sZVB0emxEZVhaRGpGWXQ1ODFz?=
 =?utf-8?B?cE5uVVR5RVloQ0p3WmVXbmpYbU5iV29QTEZ6cy9jdHRGclRXMmhrUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a12d30f-951e-4cf3-6519-08da22ceae2c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 13:07:10.8816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U7zDYDTC397FEHmIWipoiXGU1JFgV08xnob2M6F7eUQU5thrRZmopS2SQt6JHJbuchYTFgbs6iAtOhGoif9g1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4138

On 20.04.2022 14:48, Naresh Bhat wrote:
> I have the following setup and try to test the Function Level Reset feature.  Any suggestions or pointers will be very much helpful.
> 
> DOM0
> Distribution: Ubuntu-20.04.3 (kernel 5.8.0-43)
> Xen version : 4.11.4-pre
> 
> DOMU
> Distribution: Ubuntu-18.04.6 LTS (kernel 5.8.0)
> PCIe device with SRIOV support, VF (Virtual Function) interface connected to DOMU via PCI pass-through
> 
> Issue on DOMU: 
> 1. Enable MSIX on DOMU (We have used the following kernel APIs pci_enable_msix_range, pci_alloc_irq_vectors)
> 2. Execute FLR (Function Level Reset) via sysfs interface on the PCIe passthrough device in DOMU
>    # echo "1" > /sys/bus/pci/devices/<ID>/reset
> 
> The following crash observed 
> 
> [ 4126.391455] BUG: unable to handle page fault for address: ffffc90040029000
> [ 4126.391489] #PF: supervisor write access in kernel mode
> [ 4126.391503] #PF: error_code(0x0003) - permissions violation
> [ 4126.391516] PGD 94980067 P4D 94980067 PUD 16a155067 PMD 16a156067 PTE 80100000a000c075
> [ 4126.391537] Oops: 0003 [#1] SMP NOPTI
> [ 4126.391550] CPU: 0 PID: 971 Comm: bash Tainted: G           OE     5.8.0 #1
> [ 4126.391570] RIP: e030:__pci_write_msi_msg+0x59/0x150
> [ 4126.391580] Code: 8b 50 d8 85 d2 75 31 83 78 fc 03 74 2b f6 47 54 01 74 6e f6 47 55 02 75 1f 0f b7 47 56 c1 e0 04 48 98 48 03 47 60 74 10 8b 16 <89> 10 8b 56 04 89 50 04 8b 56 08 89 50 08 48 8b 03 49 89 44 24 20
> [ 4126.391606] RSP: e02b:ffffc90040407cc0 EFLAGS: 00010286

The RSP related selector value suggests you're talking about a PV DomU.
Such a DomU cannot write the MSI-X table directly, yet at a guess (from
the PTE displayed) that's what the insn does where the crash occurred. I
would guess you've hit yet another place in the kernel where proper PV
abstraction is missing. You may want to check with newer kernels.

As to FLR - I guess this operation as a whole needs passing through
pcifront to pciback, such that the operation can be carried out safely
(e.g. to save and restore active MSIs, which is what I infer is being
attempted here, as per the stack trace).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 13:24:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 13:24:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309235.525283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAJZ-0007zi-W3; Wed, 20 Apr 2022 13:24:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309235.525283; Wed, 20 Apr 2022 13:24:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAJZ-0007zb-Ry; Wed, 20 Apr 2022 13:24:13 +0000
Received: by outflank-mailman (input) for mailman id 309235;
 Wed, 20 Apr 2022 13:22:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) id 1nhAHf-0007y0-5x
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 13:22:15 +0000
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com
 [2a00:1450:4864:20::62f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dd34d7b4-c0ac-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 15:22:02 +0200 (CEST)
Received: by mail-ej1-x62f.google.com with SMTP id g13so3544040ejb.4
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 06:22:13 -0700 (PDT)
Received: from leap.localnet (host-79-50-86-254.retail.telecomitalia.it.
 [79.50.86.254]) by smtp.gmail.com with ESMTPSA id
 w7-20020a1709061f0700b006ec8197e8a4sm6255708ejj.97.2022.04.20.06.22.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 20 Apr 2022 06:22:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd34d7b4-c0ac-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=ng4rT6I4vcHmv4/7ezO3PQ9fpnN0wzaNSUcZ6IscV4k=;
        b=hisOYUiR4cenD1rp5qPKSBG+WAk64wKCLuwUm8RftXBLSnJNAj+b10FaYqJQ3H8Y9I
         Ll8ySPsAvRZBbFLxQqCxiKgJ0Raz+OKxSEH123P/ID9N4IMOW/8S2ZkWhDmPtn4DAB/m
         CJXmIRJgEXBZ86KiTOsgJKbzAQqulyO6SC+rF1OBjPNBAOlcac+iA0cVT2Zag6WtfN5n
         hByBi+9SfZHZRP99RvjAjR8Z+1Dv2JwgaaEJBwfKpHlGXP9Cqug0aiqIne7waUJcKbUf
         gdKJgXh+ank2b2a3ZSQAavn0rdJK8My3fLILeOefKuQTSWeoq0kT/7SmppbOo6yXDD9L
         H7QA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=ng4rT6I4vcHmv4/7ezO3PQ9fpnN0wzaNSUcZ6IscV4k=;
        b=PeTzsuCEmFpnjYy5lAlsGI/WIEmFpujTyb7oE3Mq4W4bG52OlA/nwWebawMUAp/btE
         1TPWFB3B8uDhX57OlLyKF3l7PhDJqKVYhEo9py17xulxi3f9E9mc4X+lh5LVfY7WvaPZ
         8mUj4RJ0zoatYtTlN8/DY+/5nBzn1CgckHnznJ1SizIxKev/7KW0kUhoL3q4/FZy/Gg3
         9c2n0E728hgcB7q5VnQzjprR/RJy9RW30ECQBYdVzMXx77Pt6L7xYKzgBea04PUqwoHW
         iwiSigjA8RxzT3d2JywzuLOTdVQlgj7gXNaBqiTZMheQXSn+hwWjGRMmUhn3CRtz19sv
         l8Rg==
X-Gm-Message-State: AOAM5320onoTHbXo/cErpyEhtxwlF4ENe5okAQOJ3I8KzJE7hQO7pG++
	LOb/QYXU8rPdj4wxFp8ViT4=
X-Google-Smtp-Source: ABdhPJwU9wCOFteWozSkt5bu3lmUNtDTL6NNULRKJcKJoaUjbAjkFKxtS6lDaecx+VwibuEjcyEeBQ==
X-Received: by 2002:a17:906:60c2:b0:6e7:681e:b4b7 with SMTP id f2-20020a17090660c200b006e7681eb4b7mr18667712ejk.130.1650460932892;
        Wed, 20 Apr 2022 06:22:12 -0700 (PDT)
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>, ira.weiny@intel.com
Cc: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>, outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
Date: Wed, 20 Apr 2022 15:22:10 +0200
Message-ID: <2940450.687JKscXgg@leap>
In-Reply-To: <alpine.DEB.2.22.394.2204200759080.2937@hadrien>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com> <alpine.DEB.2.22.394.2204200759080.2937@hadrien>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On mercoled=C3=AC 20 aprile 2022 08:03:05 CEST Julia Lawall wrote:
>=20
> On Wed, 20 Apr 2022, Alaa Mohamed wrote:
>=20
> > kmap() is being deprecated and these usages are all local to the thread
> > so there is no reason kmap_local_page() can't be used.
> >
> > Replace kmap() calls with kmap_local_page().
>=20
> OK, so from a Coccinelle point of view, could we do
>=20
> @@
> expression e1,e2,x,f;
> @@
>=20
> e1 =3D
> - kmap
> + kmap_local_page
>     (e2)
> ... when !=3D x =3D e1 // not stored in any location and not passed to=20
another function
>     when !=3D f(...,e1,...)
>     when !=3D x =3D e2
>     when !=3D f(...,e2,...)
> -kunmap(e2)
> +kunmap_local(e1)
>=20
> julia
>=20

I've never spent sufficient time to understand properly the syntax and=20
semantics of expressions of Coccinelle. However, thanks Julia, this code=20
looks good and can be very helpful.

Only a minor objection... it doesn't tell when 'e2' has been allocated=20
within the same function where the kmap() call is.

In the particular case that I cite above, I'd prefer to remove the=20
allocation of the page (say with alloc_page()) and convert kmap() /kunmap()=
=20
to use kmalloc() / kfree().=20

=46ox example, this is done in the following patch:

commit 633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from=20
sgx_ioc_enclave_init()") from Ira Weiny.

Can Coccinelle catch also those special cases where a page that is passed=20
to kmap() is allocated within that same function (vs. being passed as=20
argument to this function) and, if so, propose a replacement with=20
kmalloc()?

Thanks,

=46abio





From xen-devel-bounces@lists.xenproject.org Wed Apr 20 13:28:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 13:28:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309242.525294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhANL-0000FQ-K7; Wed, 20 Apr 2022 13:28:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309242.525294; Wed, 20 Apr 2022 13:28:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhANL-0000FJ-GE; Wed, 20 Apr 2022 13:28:07 +0000
Received: by outflank-mailman (input) for mailman id 309242;
 Wed, 20 Apr 2022 13:28:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nGXA=U6=inria.fr=julia.lawall@srs-se1.protection.inumbo.net>)
 id 1nhANK-0000FD-8W
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 13:28:06 +0000
Received: from mail2-relais-roc.national.inria.fr
 (mail2-relais-roc.national.inria.fr [192.134.164.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ae6dd775-c0ad-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 15:27:53 +0200 (CEST)
Received: from 203.107.68.85.rev.sfr.net (HELO hadrien) ([85.68.107.203])
 by mail2-relais-roc.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 15:28:03 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae6dd775-c0ad-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=inria.fr; s=dc;
  h=date:from:to:cc:subject:in-reply-to:message-id:
   references:mime-version;
  bh=+CoeG1wGEI8/gfMyxtQ5JH5NSEVqNFUDQuUEB1szdvM=;
  b=AEhXO2mE1hpaKTTPfhCAJm2kDZDm+IKMhPsQCDZfeqrnUOkvF3XHJSft
   0uWekxsBgStNaOhDaWn4f9+SepJ845Q0i8JhNvEvztlACkGEvBkg8DZoe
   C2rKv55OG3gHEVEv077nOIw/KnN63OT80cFE6q4+X6CqIIdcGj2M3SCl5
   U=;
Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr
X-IronPort-AV: E=Sophos;i="5.90,275,1643670000"; 
   d="scan'208";a="32524915"
Date: Wed, 20 Apr 2022 15:28:03 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
X-X-Sender: jll@hadrien
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
cc: Julia Lawall <julia.lawall@inria.fr>, ira.weiny@intel.com, 
    Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>, 
    outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, 
    sstabellini@kernel.org, xen-devel@lists.xenproject.org, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
In-Reply-To: <2940450.687JKscXgg@leap>
Message-ID: <alpine.DEB.2.22.394.2204201525080.2937@hadrien>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com> <alpine.DEB.2.22.394.2204200759080.2937@hadrien> <2940450.687JKscXgg@leap>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-65486685-1650461283=:2937"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-65486685-1650461283=:2937
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT



On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:

> On mercoledì 20 aprile 2022 08:03:05 CEST Julia Lawall wrote:
> >
> > On Wed, 20 Apr 2022, Alaa Mohamed wrote:
> >
> > > kmap() is being deprecated and these usages are all local to the thread
> > > so there is no reason kmap_local_page() can't be used.
> > >
> > > Replace kmap() calls with kmap_local_page().
> >
> > OK, so from a Coccinelle point of view, could we do
> >
> > @@
> > expression e1,e2,x,f;
> > @@
> >
> > e1 =
> > - kmap
> > + kmap_local_page
> >     (e2)
> > ... when != x = e1 // not stored in any location and not passed to
> another function
> >     when != f(...,e1,...)
> >     when != x = e2
> >     when != f(...,e2,...)
> > -kunmap(e2)
> > +kunmap_local(e1)
> >
> > julia
> >
>
> I've never spent sufficient time to understand properly the syntax and
> semantics of expressions of Coccinelle. However, thanks Julia, this code
> looks good and can be very helpful.
>
> Only a minor objection... it doesn't tell when 'e2' has been allocated
> within the same function where the kmap() call is.

OK, thanks for pointing that out.  That seems like a key point that should
be mentioned in log messages.  It's not even visible in the context lines
around the patch.

>
> In the particular case that I cite above, I'd prefer to remove the
> allocation of the page (say with alloc_page()) and convert kmap() /kunmap()
> to use kmalloc() / kfree().
>
> Fox example, this is done in the following patch:
>
> commit 633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from
> sgx_ioc_enclave_init()") from Ira Weiny.
>
> Can Coccinelle catch also those special cases where a page that is passed
> to kmap() is allocated within that same function (vs. being passed as
> argument to this function) and, if so, propose a replacement with
> kmalloc()?

Sure.  I'll take a look at the precise example Alaa started with and see
if I can come up with something.

thanks,
julia
--8323329-65486685-1650461283=:2937--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 13:40:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 13:40:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309248.525305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAZ3-0002ed-Oj; Wed, 20 Apr 2022 13:40:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309248.525305; Wed, 20 Apr 2022 13:40:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAZ3-0002eW-Jz; Wed, 20 Apr 2022 13:40:13 +0000
Received: by outflank-mailman (input) for mailman id 309248;
 Wed, 20 Apr 2022 13:40:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nGXA=U6=inria.fr=julia.lawall@srs-se1.protection.inumbo.net>)
 id 1nhAZ2-0002eQ-Qy
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 13:40:12 +0000
Received: from mail2-relais-roc.national.inria.fr
 (mail2-relais-roc.national.inria.fr [192.134.164.83])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 664fea9d-c0af-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 15:40:11 +0200 (CEST)
Received: from 203.107.68.85.rev.sfr.net (HELO hadrien) ([85.68.107.203])
 by mail2-relais-roc.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 15:40:10 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 664fea9d-c0af-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=inria.fr; s=dc;
  h=date:from:to:cc:subject:in-reply-to:message-id:
   references:mime-version;
  bh=9I3bT6dcN2vCZLdK2K7miTQFQ1CYOstV5pWjpPiUb+Y=;
  b=WNZyopOqnJxaQ0EhlQcHhCW6rNA0BpnSUqA0bIJDlbTQEM3Rt2Cdovry
   Tutni1e+2r9GTbhxHgPRi8GoQGNbn11m+/rdD/n/BRa1s4Wzw9FP785jj
   ys0FAO5f9ksBA0jBF9qSnnCdQEI6Fv4lliFLxxLcUZLBl5iqvKjU2Yv+0
   I=;
Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr
X-IronPort-AV: E=Sophos;i="5.90,275,1643670000"; 
   d="scan'208";a="32527674"
Date: Wed, 20 Apr 2022 15:40:10 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
X-X-Sender: jll@hadrien
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
cc: Julia Lawall <julia.lawall@inria.fr>, ira.weiny@intel.com, 
    Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>, 
    outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, 
    sstabellini@kernel.org, xen-devel@lists.xenproject.org, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
In-Reply-To: <2940450.687JKscXgg@leap>
Message-ID: <alpine.DEB.2.22.394.2204201538560.2937@hadrien>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com> <alpine.DEB.2.22.394.2204200759080.2937@hadrien> <2940450.687JKscXgg@leap>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1715972237-1650462010=:2937"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1715972237-1650462010=:2937
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT



On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:

> On mercoledì 20 aprile 2022 08:03:05 CEST Julia Lawall wrote:
> >
> > On Wed, 20 Apr 2022, Alaa Mohamed wrote:
> >
> > > kmap() is being deprecated and these usages are all local to the thread
> > > so there is no reason kmap_local_page() can't be used.
> > >
> > > Replace kmap() calls with kmap_local_page().
> >
> > OK, so from a Coccinelle point of view, could we do
> >
> > @@
> > expression e1,e2,x,f;
> > @@
> >
> > e1 =
> > - kmap
> > + kmap_local_page
> >     (e2)
> > ... when != x = e1 // not stored in any location and not passed to
> another function
> >     when != f(...,e1,...)
> >     when != x = e2
> >     when != f(...,e2,...)
> > -kunmap(e2)
> > +kunmap_local(e1)
> >
> > julia
> >
>
> I've never spent sufficient time to understand properly the syntax and
> semantics of expressions of Coccinelle. However, thanks Julia, this code
> looks good and can be very helpful.
>
> Only a minor objection... it doesn't tell when 'e2' has been allocated
> within the same function where the kmap() call is.
>
> In the particular case that I cite above, I'd prefer to remove the
> allocation of the page (say with alloc_page()) and convert kmap() /kunmap()
> to use kmalloc() / kfree().
>
> Fox example, this is done in the following patch:
>
> commit 633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from
> sgx_ioc_enclave_init()") from Ira Weiny.
>
> Can Coccinelle catch also those special cases where a page that is passed
> to kmap() is allocated within that same function (vs. being passed as
> argument to this function) and, if so, propose a replacement with
> kmalloc()?

It looks complex in this case, because the allocation is in another
function, and it is passed to another function.

julia


>
> Thanks,
>
> Fabio
>
>
>
>
--8323329-1715972237-1650462010=:2937--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 13:55:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 13:55:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309256.525319 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAo0-0004Z9-3C; Wed, 20 Apr 2022 13:55:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309256.525319; Wed, 20 Apr 2022 13:55:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAnz-0004Z2-VI; Wed, 20 Apr 2022 13:55:39 +0000
Received: by outflank-mailman (input) for mailman id 309256;
 Wed, 20 Apr 2022 13:55:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) id 1nhAny-0004Yw-Dq
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 13:55:38 +0000
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com
 [2a00:1450:4864:20::62f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e4f24eb-c0b1-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 15:55:37 +0200 (CEST)
Received: by mail-ej1-x62f.google.com with SMTP id k23so3749096ejd.3
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 06:55:37 -0700 (PDT)
Received: from leap.localnet (host-79-50-86-254.retail.telecomitalia.it.
 [79.50.86.254]) by smtp.gmail.com with ESMTPSA id
 x19-20020a05640226d300b004228faf83desm8275806edd.12.2022.04.20.06.55.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 20 Apr 2022 06:55:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e4f24eb-c0b1-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=lWkDf0wNceWcaf4i2M1FdHierloyPBoW31t9T2JLGrs=;
        b=MMLAf5NoGw56Pzvcxrd5pY9+RhqwItSeA0OHHxL1ivLiEGGdjUaxH+oPSJccQLbtkn
         jqSvrv0+NgCPeCx1Tq8ErwuVVY+ZEe431Iz58dHu7LSBisKz0idcCiHGFmTSZ0KXHI5S
         zsSQrw9kn5p8BtVCZe7iVkRyOUB+/9/e4nx9Cd2mH6A6kKMpXdkONZKiEhcx/kanQ/Zb
         7/WKktk6Mxp4M53vfXEfzUFgnxt5gi5ePPpqMQjIYdY3uOf5q9+5sWqb0a3adab0WOQu
         5iswm3+ZIIUtQqotZWENSzvIV1k4O52iky9KWA24KAdVQlCwa+33sDpfS990ze9syLqL
         cTqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=lWkDf0wNceWcaf4i2M1FdHierloyPBoW31t9T2JLGrs=;
        b=n7CBt/UTFOKE97hy4JM/c/LiaoO1IjiWURXm1DfTMQ3uVmSKbtKOccxdtxRsEG9b9C
         4mknXzghsI1cLBWFETNd+gh1K4ws165Ulfi9uVAl9ZhGUvvzzFUfVE9fMLia7VC4MwNI
         0dTRyFyyl9jOHysXxUH8B2zfotAuKUj0EqUN8V+uELO4uP//kD+6D5FUv25XQoVc3aIH
         UAjH+o3cfd4cYgH9DGgrVlOFuqm5gxfjCwDIii4ftpO+OpczBCnb1crpZWpHMUTAbLuD
         tqRLbP4OZaP+2/96u8GTD0OCYCjiMdfiKoYxf+rJ6qlkRwkgHRFJ6i6CAZIOkZSko9IR
         jcIA==
X-Gm-Message-State: AOAM531A2JukpJsxMsDhC3/3d8Sn34ItZf3JCoC5DqMdU1AcyFKrGLE7
	HDFC+UG6zQN4xROlbM/jrUg=
X-Google-Smtp-Source: ABdhPJz0c2WM3jXMhp3SbAHw3bgGqgx8hp0cdYVR6eNckJU3LJwiBiMvAH6WyMFGZfERJkze9g8T4Q==
X-Received: by 2002:a17:907:6d23:b0:6d9:ac9d:222 with SMTP id sa35-20020a1709076d2300b006d9ac9d0222mr18765799ejc.595.1650462936798;
        Wed, 20 Apr 2022 06:55:36 -0700 (PDT)
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>, ira.weiny@intel.com
Cc: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>, outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
Date: Wed, 20 Apr 2022 15:55:34 +0200
Message-ID: <3990312.6PsWsQAL7t@leap>
In-Reply-To: <alpine.DEB.2.22.394.2204201538560.2937@hadrien>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com> <2940450.687JKscXgg@leap> <alpine.DEB.2.22.394.2204201538560.2937@hadrien>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On mercoled=C3=AC 20 aprile 2022 15:40:10 CEST Julia Lawall wrote:
>=20
> On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:
>=20
> > On mercoled=C3=AC 20 aprile 2022 08:03:05 CEST Julia Lawall wrote:
> > >
> > > On Wed, 20 Apr 2022, Alaa Mohamed wrote:
> > >
> > > > kmap() is being deprecated and these usages are all local to the=20
thread
> > > > so there is no reason kmap_local_page() can't be used.
> > > >
> > > > Replace kmap() calls with kmap_local_page().
> > >
> > > OK, so from a Coccinelle point of view, could we do
> > >
> > > @@
> > > expression e1,e2,x,f;
> > > @@
> > >
> > > e1 =3D
> > > - kmap
> > > + kmap_local_page
> > >     (e2)
> > > ... when !=3D x =3D e1 // not stored in any location and not passed to
> > another function
> > >     when !=3D f(...,e1,...)
> > >     when !=3D x =3D e2
> > >     when !=3D f(...,e2,...)
> > > -kunmap(e2)
> > > +kunmap_local(e1)
> > >
> > > julia
> > >
> >
> > I've never spent sufficient time to understand properly the syntax and
> > semantics of expressions of Coccinelle. However, thanks Julia, this=20
code
> > looks good and can be very helpful.
> >
> > Only a minor objection... it doesn't tell when 'e2' has been allocated
> > within the same function where the kmap() call is.
> >
> > In the particular case that I cite above, I'd prefer to remove the
> > allocation of the page (say with alloc_page()) and convert kmap() /
kunmap()
> > to use kmalloc() / kfree().
> >
> > Fox example, this is done in the following patch:
> >
> > commit 633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from
> > sgx_ioc_enclave_init()") from Ira Weiny.
> >
> > Can Coccinelle catch also those special cases where a page that is=20
passed
> > to kmap() is allocated within that same function (vs. being passed as
> > argument to this function) and, if so, propose a replacement with
> > kmalloc()?
>=20
> It looks complex in this case, because the allocation is in another
> function, and it is passed to another function.

This is not the special case I was talking about. In this case your code=20
for Coccinelle tells the right proposal and it is exactly what Alaa did in=
=20
her patch (which is good!).

I'm talking about other special cases like the one I pointed to with the=20
link I provided. I'm sorry if my bad English made you think that Alaa's=20
patch was one of those cases where the page is allocated within the same=20
function where kmap() is.

I hope that now I've been clearer :)

Thanks,

=46abio




From xen-devel-bounces@lists.xenproject.org Wed Apr 20 13:57:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 13:57:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309260.525330 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhApa-00058v-F7; Wed, 20 Apr 2022 13:57:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309260.525330; Wed, 20 Apr 2022 13:57:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhApa-00058o-AZ; Wed, 20 Apr 2022 13:57:18 +0000
Received: by outflank-mailman (input) for mailman id 309260;
 Wed, 20 Apr 2022 13:57:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nGXA=U6=inria.fr=julia.lawall@srs-se1.protection.inumbo.net>)
 id 1nhApY-00058c-P4
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 13:57:16 +0000
Received: from mail2-relais-roc.national.inria.fr
 (mail2-relais-roc.national.inria.fr [192.134.164.83])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c8ae0c1b-c0b1-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 15:57:15 +0200 (CEST)
Received: from 203.107.68.85.rev.sfr.net (HELO hadrien) ([85.68.107.203])
 by mail2-relais-roc.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 15:57:15 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8ae0c1b-c0b1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=inria.fr; s=dc;
  h=date:from:to:cc:subject:in-reply-to:message-id:
   references:mime-version;
  bh=3SSJXbjOy1qLhNGe/bTpSNKpfz9W3niG2+rjeL4z3oQ=;
  b=F1RqfgRYhqbxqwAW8IPNwtEdU9s3utkiBmSyM33s/tK87vtA39lDLms7
   ZYZ1ezEJuAYnR7oCrzO9U2fn2sOe7CQHEfHoxmc1XaA3p7stMQNcIVlNU
   ZPlmIehfFMfeB/H7ieZwqZ4Igw0nJ/8AwzOggEnXp1UXOMI0mm3dC1ZAC
   0=;
Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr
X-IronPort-AV: E=Sophos;i="5.90,275,1643670000"; 
   d="scan'208";a="32531422"
Date: Wed, 20 Apr 2022 15:57:14 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
X-X-Sender: jll@hadrien
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
cc: Julia Lawall <julia.lawall@inria.fr>, ira.weiny@intel.com, 
    Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>, 
    outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, 
    sstabellini@kernel.org, xen-devel@lists.xenproject.org, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
In-Reply-To: <3990312.6PsWsQAL7t@leap>
Message-ID: <alpine.DEB.2.22.394.2204201556330.2937@hadrien>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com> <2940450.687JKscXgg@leap> <alpine.DEB.2.22.394.2204201538560.2937@hadrien> <3990312.6PsWsQAL7t@leap>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-915472296-1650463034=:2937"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-915472296-1650463034=:2937
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT



On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:

> On mercoledì 20 aprile 2022 15:40:10 CEST Julia Lawall wrote:
> >
> > On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:
> >
> > > On mercoledì 20 aprile 2022 08:03:05 CEST Julia Lawall wrote:
> > > >
> > > > On Wed, 20 Apr 2022, Alaa Mohamed wrote:
> > > >
> > > > > kmap() is being deprecated and these usages are all local to the
> thread
> > > > > so there is no reason kmap_local_page() can't be used.
> > > > >
> > > > > Replace kmap() calls with kmap_local_page().
> > > >
> > > > OK, so from a Coccinelle point of view, could we do
> > > >
> > > > @@
> > > > expression e1,e2,x,f;
> > > > @@
> > > >
> > > > e1 =
> > > > - kmap
> > > > + kmap_local_page
> > > >     (e2)
> > > > ... when != x = e1 // not stored in any location and not passed to
> > > another function
> > > >     when != f(...,e1,...)
> > > >     when != x = e2
> > > >     when != f(...,e2,...)
> > > > -kunmap(e2)
> > > > +kunmap_local(e1)
> > > >
> > > > julia
> > > >
> > >
> > > I've never spent sufficient time to understand properly the syntax and
> > > semantics of expressions of Coccinelle. However, thanks Julia, this
> code
> > > looks good and can be very helpful.
> > >
> > > Only a minor objection... it doesn't tell when 'e2' has been allocated
> > > within the same function where the kmap() call is.
> > >
> > > In the particular case that I cite above, I'd prefer to remove the
> > > allocation of the page (say with alloc_page()) and convert kmap() /
> kunmap()
> > > to use kmalloc() / kfree().
> > >
> > > Fox example, this is done in the following patch:
> > >
> > > commit 633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from
> > > sgx_ioc_enclave_init()") from Ira Weiny.
> > >
> > > Can Coccinelle catch also those special cases where a page that is
> passed
> > > to kmap() is allocated within that same function (vs. being passed as
> > > argument to this function) and, if so, propose a replacement with
> > > kmalloc()?
> >
> > It looks complex in this case, because the allocation is in another
> > function, and it is passed to another function.
>
> This is not the special case I was talking about. In this case your code
> for Coccinelle tells the right proposal and it is exactly what Alaa did in
> her patch (which is good!).
>
> I'm talking about other special cases like the one I pointed to with the
> link I provided. I'm sorry if my bad English made you think that Alaa's
> patch was one of those cases where the page is allocated within the same
> function where kmap() is.
>
> I hope that now I've been clearer :)

Ah, sorry for the misunderstanding.  If you have an example, I can take a
look and propose something for this special case.

julia
--8323329-915472296-1650463034=:2937--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:00:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:00:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309267.525343 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAsj-0006cw-UW; Wed, 20 Apr 2022 14:00:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309267.525343; Wed, 20 Apr 2022 14:00:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAsj-0006cp-Rh; Wed, 20 Apr 2022 14:00:33 +0000
Received: by outflank-mailman (input) for mailman id 309267;
 Wed, 20 Apr 2022 14:00:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=k8Fu=U6=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nhAsj-0006cj-6h
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:00:33 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0620.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::620])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3d79fa98-c0b2-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 16:00:31 +0200 (CEST)
Received: from AS8P250CA0010.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::15)
 by AM0PR08MB4353.eurprd08.prod.outlook.com (2603:10a6:208:144::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 14:00:28 +0000
Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:330:cafe::ba) by AS8P250CA0010.outlook.office365.com
 (2603:10a6:20b:330::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25 via Frontend
 Transport; Wed, 20 Apr 2022 14:00:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Wed, 20 Apr 2022 14:00:27 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Wed, 20 Apr 2022 14:00:26 +0000
Received: from 07f2d32a5601.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 37B311BA-52FC-415D-AA0A-994B9C7F54F3.1; 
 Wed, 20 Apr 2022 14:00:15 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 07f2d32a5601.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 14:00:15 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by GV1PR08MB8082.eurprd08.prod.outlook.com (2603:10a6:150:96::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.29; Wed, 20 Apr
 2022 14:00:12 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5186.013; Wed, 20 Apr 2022
 14:00:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d79fa98-c0b2-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4/v1WE61xkur4osDmCIiuy0rcZqs2HZfVCItorOm5zQ=;
 b=d3c77tb860jZwtX6GztA5BKyqTXSv7ZTBDyfcTWN/cMrSBYlY3+MaoMSKYvRyRG32QVjdwmHxeB1ZMkFbqsV0stdzThGGT4+MgzKZ+KytDj78ocefXoExBPs5sDNH52PGgMegY/FTCcPUkqektqEbaINxpklc1HUp32sb7eL1Cg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f4a1645a57bb5590
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GK57qlGm2vsUBFaCW58Y75RqpKG5YfENijiafO43wWg3vcoiuSB+68GE5JxQaM4Na0HC8boJpXmcURkM8xJDwFTNAtF3RjAy6Xw1OFXwbf/kR5Tq8565GAMtbPVQADSMYgkiApn8ma2pKyXyZrGvlEeqHtYm/vJWV1IkJM3oSb+DlWSxV0DW2m0aZe88J5qt4bzzuzcv9F4ciJsXUJ185SUd5IX5SMJTnlhnOg+P1KJfPN6GMSfCQLpwd7/B3mZGF/o1OmUFOcyAXzdGCbUEYNogBDFqDfLAnYrcpmSiEb1I21mKAZEkvf6ED4+atMYvLP8Jc6yJ+dAVMbeKeIJdEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4/v1WE61xkur4osDmCIiuy0rcZqs2HZfVCItorOm5zQ=;
 b=TgK+7s2yrx/Iw6J4IklehKaOP1ly8yxHh4ct6tPO0mNdcULaakmVwXpdwlHbV4t5C687qT26I3lk9NgI3ymtdpyfU7Mp3Da2YeNw0z+fXs/eAmQg8T0tCQ0B8OeaRBJigMYUxSfz30hWEJMJIQqCEfd73LKJZHF40oQkxyRRJrTERBmjbwmaluIAkOl2wL+6fp3aEhpzKzVxx1d7BKoyZFGL6yCb9NKuwWFhYuOM0ECjvXbUo9kFAPqZCW81Lbyu8PXfatJeNNVbHOBHvsd8hDT3CmgV1ZIAG0QH6yWQTDAG3kNiACPrF5o0gJN2fRgXMP0eIpwnVN1chdnQQd8EjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4/v1WE61xkur4osDmCIiuy0rcZqs2HZfVCItorOm5zQ=;
 b=d3c77tb860jZwtX6GztA5BKyqTXSv7ZTBDyfcTWN/cMrSBYlY3+MaoMSKYvRyRG32QVjdwmHxeB1ZMkFbqsV0stdzThGGT4+MgzKZ+KytDj78ocefXoExBPs5sDNH52PGgMegY/FTCcPUkqektqEbaINxpklc1HUp32sb7eL1Cg=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Dario Faggioli <dfaggioli@suse.com>, Juergen Gross <jgross@suse.com>
CC: Jan Beulich <jbeulich@suse.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Julien
 Grall <julien@xen.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Thread-Topic: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Thread-Index:
 AQHYTbfiNTg+IXy/G0GwaoqGDOL0yazq2Y4AgAEwcQCAAAivgIAA2MwAgACFroCAAAHtgIALb2GA
Date: Wed, 20 Apr 2022 14:00:11 +0000
Message-ID: <AB17024F-15BF-4F43-802B-9F54B76F6348@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-5-luca.fancellu@arm.com>
 <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
 <86F93995-5CFD-4A43-A928-E9053B027722@arm.com>
 <50dc64e6-1a89-59aa-e087-d80aad1c653d@suse.com>
 <alpine.DEB.2.22.394.2204121616030.3066615@ubuntu-linux-20-04-desktop>
 <39D59E80-A4B5-4587-9A2A-1D5F06C8C33E@arm.com>
 <13f077b9-6b61-5737-1c94-b17da0fd6ecc@suse.com>
In-Reply-To: <13f077b9-6b61-5737-1c94-b17da0fd6ecc@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 031a66f9-db3d-4fea-27c7-08da22d61fa1
x-ms-traffictypediagnostic:
	GV1PR08MB8082:EE_|VE1EUR03FT042:EE_|AM0PR08MB4353:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB435378A7445354152DF7857DE4F59@AM0PR08MB4353.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 4PmQQlvT2FCcyRaXwFNrEundhYhqy/xn5v1BrZYsr47XgckS+C7SCocRB9HHxnLpvWt0qZy+J/CK99Wujr7a5+9okoKF4Di9X9KIJ6oUgTd0H5tbc+0K1QDWdTgYyNy0Lssl7u1lypSSKo1y02K/QCp9DkzKeHZRws0j/c5/CPdGeioJkntcCCR7C4yXvZYYw8Atbx8ioCH6Cvcsb0PYo4EixDOzPlOJu6/eZrQUaIjO+UdOqzGfCBM+Kqju+SrH59sDgr6/tRI0bK71tpmT63stUuWB1kkETjZcYijCPEqA1QdMHJquZ+nwYn2zcFF7w1/Qd+HA1n1bcxAFzSic4NX8A2GWU0dYiWURR3CN5fDWohZuMb140lsZbti8sRo2ASlTaWMS766eU2XPk+HWDf2K4onE6WFEg8Ylw42FtCzdTyHnUbw9gIUD7mrCHrKEmt4TuDQB1/+Jw48imf/+BH/6wBFqvQehFtLNo0mserKeim+4Zjb2HHgXeUen4Y9kgAgKL81le5Od0/oz1MD1xm/66KF7zvx4jmI+n79DzByNJm79+gRZnkLPzj7Gldw4QnivKwMHFCpOUWGzsTDw90Julm4/xGaWD5mhfoZBRZxhFZCVwACDYpCzRe1fXJhcutqhPqE0HeWEv2JF/NgA22UlMtu7hCBwt67xqQa83uTbMDNHdUnMLhCA+9/vAZVxpBmLTFOyTByxO3qX5RmZkhOvFsgq6uYjEq3Y+e1AHA/DQpwR5H0k+dUkJVHopQBL
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(71200400001)(122000001)(8676002)(64756008)(6506007)(66556008)(2906002)(2616005)(86362001)(83380400001)(6512007)(8936002)(53546011)(186003)(26005)(54906003)(508600001)(7416002)(4326008)(33656002)(5660300002)(6486002)(36756003)(91956017)(38100700002)(110136005)(38070700005)(66446008)(316002)(66476007)(76116006)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <5716A86F7144654FA9CF75016E686B47@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8082
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c25deb4f-4878-4119-e3d4-08da22d6165e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	141Jn2K9HvU+PJSBQ/aKlq97/vPDzLCxnhDzMMPED2BESR5Li0FGUpd/+2a1wmYpPgG37a/msYXbMY4e9psLnKyJx9FB3wjG+ILu436S7HMPYkUJNSVR8YvU83aboBmw6thQaj7LudkiDX45YgJEDB+DErKXo2sKLgE8yPVKHh7nLq7RlWKisJOiHSE4yVxfLD5auvftaldvU7IcL9a/UmRtk/C91qLrs8ftB1s0fXFNuQWGj1GMsQJkxOu7NOr8v+ODSk2J8zVQHbeVSh0U2lw5db55n+NSdrnTpeW+vG4UaAYCkzZx9+4s5DtvPv/jLISvLjS984fEgGN0PaF/1hnUK7kZ5fQmDoHLh+sv1qVQViULXMKw42T7eg7LLO86kHnYXRglUqYKmme3AAFBCcGpsLNM/cHDZkOoIqy61QHfVjJnGqbn6fcO+kxZDplMOQ4zlRyOpHYtjFURvAOseF7QiDNHVyNPwPYdQoI86YXZjk4SnVrqMEcgWKZ083RISYhVGGxQux4/6bMq6u9OhdtxVuOdhnMA4YRTW/QiTHxPeDmBkeJKZa3X0VaZcbkBlgOs243FvO1PuKVvumA6kvvPZ7LH8NjXZd4OgDDukvhEtdgNUa2r5l+8pJwIJknzL/yaO12f9qwb11k9+OkPj+Yl3//4z3sXxSqGB3CiBx7IBcjNHYxg0jpuig34VQT/
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(53546011)(26005)(33656002)(70586007)(81166007)(47076005)(336012)(36756003)(83380400001)(2616005)(8676002)(82310400005)(70206006)(6512007)(2906002)(6506007)(5660300002)(186003)(107886003)(4326008)(508600001)(8936002)(36860700001)(6486002)(316002)(54906003)(110136005)(356005)(40460700003)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 14:00:27.4409
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 031a66f9-db3d-4fea-27c7-08da22d61fa1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4353

DQoNCj4gT24gMTMgQXByIDIwMjIsIGF0IDA4OjIyLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTMuMDQuMjAyMiAwOToxNSwgTHVjYSBGYW5jZWxsdSB3
cm90ZToNCj4+IA0KPj4+PiANCj4+Pj4gTm8sIEknbSBub3Qgc3VnZ2VzdGluZyBhIG5ldyBtZW51
LiBJIHdhcyBtZXJlbHkgd29uZGVyaW5nIHdoZXRoZXIgdGhlDQo+Pj4+IEtjb25maWcgY29udGVu
dHMgd291bGRuJ3QgbG9jYXRpb24td2lzZSBiZXR0ZXIgbWF0Y2ggd2hlcmUgdGhlDQo+Pj4+IHJl
c3BlY3RpdmUgc291cmNlIGZpbGUgbGl2ZXMuDQo+Pj4gDQo+Pj4gSXQgY291bGQgYmUgaW4geGVu
L2NvbW1vbi9zY2hlZC9LY29uZmlnIGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIGZpbGUNCj4+PiBi
ZWZvcmUgY3JlYXRpbmcgdGhlIG5ldyAiU2NoZWR1bGVycyIgbWVudSwgZS5nLjoNCj4+PiANCj4+
PiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9zY2hlZC9LY29uZmlnIGIveGVuL2NvbW1vbi9zY2hl
ZC9LY29uZmlnDQo+Pj4gaW5kZXggM2Q5ZjkyMTRiOC4uZjY1NDVmNGU5YiAxMDA2NDQNCj4+PiAt
LS0gYS94ZW4vY29tbW9uL3NjaGVkL0tjb25maWcNCj4+PiArKysgYi94ZW4vY29tbW9uL3NjaGVk
L0tjb25maWcNCj4+PiBAQCAtMSwzICsxLDEwIEBADQo+Pj4gK2NvbmZpZyBCT09UX1RJTUVfQ1BV
UE9PTFMNCj4+PiArIGJvb2wgIkNyZWF0ZSBjcHVwb29scyBhdCBib290IHRpbWUiDQo+Pj4gKyBk
ZXBlbmRzIG9uIEhBU19ERVZJQ0VfVFJFRQ0KPj4+ICsgaGVscA0KPj4+ICsgQ3JlYXRlcyBjcHVw
b29scyBkdXJpbmcgYm9vdCB0aW1lIGFuZCBhc3NpZ25zIGNwdXMgdG8gdGhlbS4gQ3B1cG9vbHMN
Cj4+PiArIG9wdGlvbnMgY2FuIGJlIHNwZWNpZmllZCBpbiB0aGUgZGV2aWNlIHRyZWUuDQo+Pj4g
Kw0KPj4+IG1lbnUgIlNjaGVkdWxlcnMiDQo+Pj4gCXZpc2libGUgaWYgRVhQRVJUDQo+Pj4gDQo+
Pj4gDQo+Pj4gSSB0aGluayBpdCBpcyBmaW5lIGVpdGhlciB3YXksIHNvOg0KPj4+IA0KPj4+IFJl
dmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+
PiANCj4+IFRoYW5rIHlvdSBTdGVmYW5vLA0KPj4gDQo+PiBKYW4gZm9yIHlvdSBpcyBpdCBvayBh
dCB0aGUgYmVnaW5uaW5nIGxpa2UgU3RlZmFubyBzYWlkPw0KPiANCj4gUGVyc29uYWxseSBJJ2Qg
cHJlZmVyIGl0IGF0IHRoZSBlbmQgKHN0aWxsIG91dHNpZGUgdGhlIG1lbnUpLCBidXQNCj4gcmVh
bGx5IHRoZSBzY2hlZHVsZXIgbWFpbnRhaW5lcnMgYXJlIGdvaW5nIHRvIGhhdmUgdGhlIGZpbmFs
IHNheS4NCg0KSGkgY3B1cG9vbHMgbWFpbnRhaW5lciwNCg0KSeKAmW0gZ29pbmcgdG8gYWRkcmVz
cyB0aGlzIGZpbmFsIGNvbW1lbnQgYW5kIHJlLXB1c2ggdGhlIHNlcmllLCBpbiBvcmRlcg0KdG8g
YXZvaWQgZnVydGhlciBub2lzZSwgd291bGQgeW91IG1pbmQgdG8gZ2l2ZSBtZSBhIGZlZWRiYWNr
IG9uIHRoYXQ/DQoNCldoYXQgaXMgeW91ciBwcmVmZXJlbmNlIGZvciB0aGUgS2NvbmZpZyBwYXJh
bWV0ZXIgcGxhY2VtZW50LCBiZWdpbm5pbmcNCm9mIHRoZSBmaWxlIG9yIGVuZD8NCg0KVGhhbmsg
eW91Lg0KDQpDaGVlcnMsDQpMdWNhDQoNCj4gDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:07:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:07:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309274.525355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAzd-0007YF-TC; Wed, 20 Apr 2022 14:07:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309274.525355; Wed, 20 Apr 2022 14:07:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhAzd-0007Y8-PW; Wed, 20 Apr 2022 14:07:41 +0000
Received: by outflank-mailman (input) for mailman id 309274;
 Wed, 20 Apr 2022 14:07:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) id 1nhAzc-0007Y1-Ei
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:07:40 +0000
Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com
 [2a00:1450:4864:20::62d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c9b2008-c0b3-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 16:07:39 +0200 (CEST)
Received: by mail-ej1-x62d.google.com with SMTP id s18so3894422ejr.0
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 07:07:39 -0700 (PDT)
Received: from leap.localnet (host-79-50-86-254.retail.telecomitalia.it.
 [79.50.86.254]) by smtp.gmail.com with ESMTPSA id
 au9-20020a170907092900b006e8985cc68asm6703151ejc.1.2022.04.20.07.07.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 20 Apr 2022 07:07:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c9b2008-c0b3-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=axtU0b8TtpVbp0s/mbZjWqvA94Dr9I508ZNrAg+bBn0=;
        b=h3ip9pqn1Te/4FB3H+4SHiAbA6baF/wjith2bzY2njubpPrbXH4SFJAnu8cJNj6/UK
         9HFHH3DpzxOPKbG+JhKptMmqnimupMF5acHMST/auHETQ7IXtI8oLiXzopiADk6Xvj+G
         C+uMkITomXf82mlJjY28A1Qwx4BudvCvgJ1RrHhCiHyBwvdNwBsktj2N82QxuHlJ2qY6
         A5ppVf0HcXwng/AJ50Z3JkMX+BIyeJSclRVNNIxSeuhV0kmicV+m33kBimktN/XAZHu0
         lnksAl27sz/nFPLLWRtLinxEZQwto3wwwhH8Z8jHyQEWM7nZtP1hdljsDO9Keod1r5az
         5AEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=axtU0b8TtpVbp0s/mbZjWqvA94Dr9I508ZNrAg+bBn0=;
        b=flK4A0i8dIn5DYQmdDMtdZ7uPfPz859doWDE2I5fpGsm9xoc9eRUG7LCnmLS6rnMrv
         xfWhvKZSiJrHbtpKevnAiMKaddkeHw3jGr3JQViYmgaOsu5cifGwjrVPDwyXNacWsnKY
         VWnqtpSlLVdzM7ORmBpCogES0Kn8JFXgoWydH9Iw2v3OztCwtMEvkB56oZlvSn5C0fKU
         N9CR6UFSezyTInc0ZIv3hOF1DMkIprWUqhCzrCBAxtrW8o923PrQwkGRpLLXCb4g/iUO
         Su1bUXgxjndu2OTihyP5NZAwNu0NNOK98WpcRbbnjgXX0fzFqfPflkmha6Rb2IvyeN1T
         mwxA==
X-Gm-Message-State: AOAM532oGCUbeMJ9dm86nouPHgwcKAxblqxYDxHySgfEA3um/neFQw+S
	EN7dWUn7lr55niBaKLHmDXQ=
X-Google-Smtp-Source: ABdhPJzx++INwh/binOtJF6UHoLInnaW20QfquRf+Me/PgiY/eme4g+R8VUQweTxq86X6SxppLyFcQ==
X-Received: by 2002:a17:906:2e8d:b0:6e4:b5fc:e8e6 with SMTP id o13-20020a1709062e8d00b006e4b5fce8e6mr6678249eji.215.1650463658445;
        Wed, 20 Apr 2022 07:07:38 -0700 (PDT)
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Julia Lawall <julia.lawall@inria.fr>, ira.weiny@intel.com, Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>, outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
Date: Wed, 20 Apr 2022 16:07:36 +0200
Message-ID: <2538961.9Mp67QZiUf@leap>
In-Reply-To: <alpine.DEB.2.22.394.2204201556330.2937@hadrien>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com> <3990312.6PsWsQAL7t@leap> <alpine.DEB.2.22.394.2204201556330.2937@hadrien>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On mercoled=C3=AC 20 aprile 2022 15:57:14 CEST Julia Lawall wrote:
>=20
> On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:
>=20
> > On mercoled=C3=AC 20 aprile 2022 15:40:10 CEST Julia Lawall wrote:
> > >
> > > On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:
> > >
> > > > On mercoled=C3=AC 20 aprile 2022 08:03:05 CEST Julia Lawall wrote:
> > > > >
> > > > > On Wed, 20 Apr 2022, Alaa Mohamed wrote:
> > > > >
> > > > > > kmap() is being deprecated and these usages are all local to=20
the
> > thread
> > > > > > so there is no reason kmap_local_page() can't be used.
> > > > > >
> > > > > > Replace kmap() calls with kmap_local_page().
> > > > >
> > > > > OK, so from a Coccinelle point of view, could we do
> > > > >
> > > > > @@
> > > > > expression e1,e2,x,f;
> > > > > @@
> > > > >
> > > > > e1 =3D
> > > > > - kmap
> > > > > + kmap_local_page
> > > > >     (e2)
> > > > > ... when !=3D x =3D e1 // not stored in any location and not pass=
ed=20
to
> > > > another function
> > > > >     when !=3D f(...,e1,...)
> > > > >     when !=3D x =3D e2
> > > > >     when !=3D f(...,e2,...)
> > > > > -kunmap(e2)
> > > > > +kunmap_local(e1)
> > > > >
> > > > > julia
> > > > >
> > > >
> > > > I've never spent sufficient time to understand properly the syntax=
=20
and
> > > > semantics of expressions of Coccinelle. However, thanks Julia, this
> > code
> > > > looks good and can be very helpful.
> > > >
> > > > Only a minor objection... it doesn't tell when 'e2' has been=20
allocated
> > > > within the same function where the kmap() call is.
> > > >
> > > > In the particular case that I cite above, I'd prefer to remove the
> > > > allocation of the page (say with alloc_page()) and convert kmap() /
> > kunmap()
> > > > to use kmalloc() / kfree().
> > > >
> > > > Fox example, this is done in the following patch:
> > > >
> > > > commit 633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from
> > > > sgx_ioc_enclave_init()") from Ira Weiny.
> > > >
> > > > Can Coccinelle catch also those special cases where a page that is
> > passed
> > > > to kmap() is allocated within that same function (vs. being passed=
=20
as
> > > > argument to this function) and, if so, propose a replacement with
> > > > kmalloc()?
> > >
> > > It looks complex in this case, because the allocation is in another
> > > function, and it is passed to another function.
> >
> > This is not the special case I was talking about. In this case your=20
code
> > for Coccinelle tells the right proposal and it is exactly what Alaa did=
=20
in
> > her patch (which is good!).
> >
> > I'm talking about other special cases like the one I pointed to with=20
the
> > link I provided. I'm sorry if my bad English made you think that Alaa's
> > patch was one of those cases where the page is allocated within the=20
same
> > function where kmap() is.
> >
> > I hope that now I've been clearer :)
>=20
> Ah, sorry for the misunderstanding.  If you have an example, I can take a
> look and propose something for this special case.
>=20
> julia

Yes, I have the example that you are asking for. It's that commit=20
633b0616cfe0 from Ira Weiny.

Let me copy and paste it here for your convenience...

diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/
ioctl.c
index 90a5caf76939..2e10367ea66c 100644
=2D-- a/arch/x86/kernel/cpu/sgx/ioctl.c
+++ b/arch/x86/kernel/cpu/sgx/ioctl.c
@@ -604,7 +604,6 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl,=
=20
void __user *arg)
 {
        struct sgx_sigstruct *sigstruct;
        struct sgx_enclave_init init_arg;
=2D       struct page *initp_page;
        void *token;
        int ret;
=20
@@ -615,11 +614,15 @@ static long sgx_ioc_enclave_init(struct sgx_encl=20
*encl, void __user *arg)
        if (copy_from_user(&init_arg, arg, sizeof(init_arg)))
                return -EFAULT;
=20
=2D       initp_page =3D alloc_page(GFP_KERNEL);
=2D       if (!initp_page)
+       /*
+        * 'sigstruct' must be on a page boundary and 'token' on a 512 byte
+        * boundary.  kmalloc() will give this alignment when allocating
+        * PAGE_SIZE bytes.
+        */
+       sigstruct =3D kmalloc(PAGE_SIZE, GFP_KERNEL);
+       if (!sigstruct)
                return -ENOMEM;
=20
=2D       sigstruct =3D kmap(initp_page);
        token =3D (void *)((unsigned long)sigstruct + PAGE_SIZE / 2);
        memset(token, 0, SGX_LAUNCH_TOKEN_SIZE);
=20
@@ -645,8 +648,7 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl,=
=20
void __user *arg)
        ret =3D sgx_encl_init(encl, sigstruct, token);
=20
 out:
=2D       kunmap(initp_page);
=2D       __free_page(initp_page);
+       kfree(sigstruct);
        return ret;
 }

I think that Coccinelle might understand that "initp_page" is allocated in=
=20
the same function where later it is kmap()'ed. But I'm not able to write a=
=20
Coccinelle check to find out these kinds of special cases. In these cases=20
the correct solution is not to use kmap_local_page(). Instead delete the=20
alloc_page() and use kmalloc().

Thanks,

=46abio





From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:08:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:08:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309277.525366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB0j-000862-6j; Wed, 20 Apr 2022 14:08:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309277.525366; Wed, 20 Apr 2022 14:08:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB0j-00085v-3g; Wed, 20 Apr 2022 14:08:49 +0000
Received: by outflank-mailman (input) for mailman id 309277;
 Wed, 20 Apr 2022 14:08:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhB0h-00085m-F1
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:08:47 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 647e6e77-c0b3-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 16:08:46 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B74B31F380;
 Wed, 20 Apr 2022 14:08:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5414A13A30;
 Wed, 20 Apr 2022 14:08:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kfO+Eu0TYGJ/EgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 14:08:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 647e6e77-c0b3-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650463725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XR9S3JAXaAm2nsvkdiVk/cyq5vfM5KURazSwqsS4JaM=;
	b=ZM4RQjYqM7BFEjqYbpiM+OJ6gzIjgUXVAPgcSSP1PAxy8rfa/SHegqTzE4lSIqGI7asp6+
	kEN41K7yOYU60QL/X8u3dp6fNK3GXcucffi60WYis5wCXy+kcAJsQ0K8sUql5/J7g19v5g
	EgftEUoET9E+HPf+XYPvG4ElMAkGql0=
Message-ID: <4d6f2048-e658-8cb0-97a1-34fc4cd43413@suse.com>
Date: Wed, 20 Apr 2022 16:08:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>, Dario Faggioli <dfaggioli@suse.com>
Cc: Jan Beulich <jbeulich@suse.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-5-luca.fancellu@arm.com>
 <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
 <86F93995-5CFD-4A43-A928-E9053B027722@arm.com>
 <50dc64e6-1a89-59aa-e087-d80aad1c653d@suse.com>
 <alpine.DEB.2.22.394.2204121616030.3066615@ubuntu-linux-20-04-desktop>
 <39D59E80-A4B5-4587-9A2A-1D5F06C8C33E@arm.com>
 <13f077b9-6b61-5737-1c94-b17da0fd6ecc@suse.com>
 <AB17024F-15BF-4F43-802B-9F54B76F6348@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <AB17024F-15BF-4F43-802B-9F54B76F6348@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------iWut7SOdnUTnzgb1ULH0FCwx"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------iWut7SOdnUTnzgb1ULH0FCwx
Content-Type: multipart/mixed; boundary="------------PhBnKmc00rN9J3wzgWTZt020";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>, Dario Faggioli <dfaggioli@suse.com>
Cc: Jan Beulich <jbeulich@suse.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <4d6f2048-e658-8cb0-97a1-34fc4cd43413@suse.com>
Subject: Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot
 time
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-5-luca.fancellu@arm.com>
 <8ddae5ff-120c-0097-bac0-2fca7a57d022@suse.com>
 <86F93995-5CFD-4A43-A928-E9053B027722@arm.com>
 <50dc64e6-1a89-59aa-e087-d80aad1c653d@suse.com>
 <alpine.DEB.2.22.394.2204121616030.3066615@ubuntu-linux-20-04-desktop>
 <39D59E80-A4B5-4587-9A2A-1D5F06C8C33E@arm.com>
 <13f077b9-6b61-5737-1c94-b17da0fd6ecc@suse.com>
 <AB17024F-15BF-4F43-802B-9F54B76F6348@arm.com>
In-Reply-To: <AB17024F-15BF-4F43-802B-9F54B76F6348@arm.com>

--------------PhBnKmc00rN9J3wzgWTZt020
Content-Type: multipart/mixed; boundary="------------Qj6Zedq0LBnDBg9pqSydHn0K"

--------------Qj6Zedq0LBnDBg9pqSydHn0K
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDQuMjIgMTY6MDAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IA0KPiANCj4+IE9u
IDEzIEFwciAyMDIyLCBhdCAwODoyMiwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
PiB3cm90ZToNCj4+DQo+PiBPbiAxMy4wNC4yMDIyIDA5OjE1LCBMdWNhIEZhbmNlbGx1IHdy
b3RlOg0KPj4+DQo+Pj4+Pg0KPj4+Pj4gTm8sIEknbSBub3Qgc3VnZ2VzdGluZyBhIG5ldyBt
ZW51LiBJIHdhcyBtZXJlbHkgd29uZGVyaW5nIHdoZXRoZXIgdGhlDQo+Pj4+PiBLY29uZmln
IGNvbnRlbnRzIHdvdWxkbid0IGxvY2F0aW9uLXdpc2UgYmV0dGVyIG1hdGNoIHdoZXJlIHRo
ZQ0KPj4+Pj4gcmVzcGVjdGl2ZSBzb3VyY2UgZmlsZSBsaXZlcy4NCj4+Pj4NCj4+Pj4gSXQg
Y291bGQgYmUgaW4geGVuL2NvbW1vbi9zY2hlZC9LY29uZmlnIGF0IHRoZSBiZWdpbm5pbmcg
b2YgdGhlIGZpbGUNCj4+Pj4gYmVmb3JlIGNyZWF0aW5nIHRoZSBuZXcgIlNjaGVkdWxlcnMi
IG1lbnUsIGUuZy46DQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3NjaGVk
L0tjb25maWcgYi94ZW4vY29tbW9uL3NjaGVkL0tjb25maWcNCj4+Pj4gaW5kZXggM2Q5Zjky
MTRiOC4uZjY1NDVmNGU5YiAxMDA2NDQNCj4+Pj4gLS0tIGEveGVuL2NvbW1vbi9zY2hlZC9L
Y29uZmlnDQo+Pj4+ICsrKyBiL3hlbi9jb21tb24vc2NoZWQvS2NvbmZpZw0KPj4+PiBAQCAt
MSwzICsxLDEwIEBADQo+Pj4+ICtjb25maWcgQk9PVF9USU1FX0NQVVBPT0xTDQo+Pj4+ICsg
Ym9vbCAiQ3JlYXRlIGNwdXBvb2xzIGF0IGJvb3QgdGltZSINCj4+Pj4gKyBkZXBlbmRzIG9u
IEhBU19ERVZJQ0VfVFJFRQ0KPj4+PiArIGhlbHANCj4+Pj4gKyBDcmVhdGVzIGNwdXBvb2xz
IGR1cmluZyBib290IHRpbWUgYW5kIGFzc2lnbnMgY3B1cyB0byB0aGVtLiBDcHVwb29scw0K
Pj4+PiArIG9wdGlvbnMgY2FuIGJlIHNwZWNpZmllZCBpbiB0aGUgZGV2aWNlIHRyZWUuDQo+
Pj4+ICsNCj4+Pj4gbWVudSAiU2NoZWR1bGVycyINCj4+Pj4gCXZpc2libGUgaWYgRVhQRVJU
DQo+Pj4+DQo+Pj4+DQo+Pj4+IEkgdGhpbmsgaXQgaXMgZmluZSBlaXRoZXIgd2F5LCBzbzoN
Cj4+Pj4NCj4+Pj4gUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxp
bmlAa2VybmVsLm9yZz4NCj4+Pg0KPj4+IFRoYW5rIHlvdSBTdGVmYW5vLA0KPj4+DQo+Pj4g
SmFuIGZvciB5b3UgaXMgaXQgb2sgYXQgdGhlIGJlZ2lubmluZyBsaWtlIFN0ZWZhbm8gc2Fp
ZD8NCj4+DQo+PiBQZXJzb25hbGx5IEknZCBwcmVmZXIgaXQgYXQgdGhlIGVuZCAoc3RpbGwg
b3V0c2lkZSB0aGUgbWVudSksIGJ1dA0KPj4gcmVhbGx5IHRoZSBzY2hlZHVsZXIgbWFpbnRh
aW5lcnMgYXJlIGdvaW5nIHRvIGhhdmUgdGhlIGZpbmFsIHNheS4NCj4gDQo+IEhpIGNwdXBv
b2xzIG1haW50YWluZXIsDQo+IA0KPiBJ4oCZbSBnb2luZyB0byBhZGRyZXNzIHRoaXMgZmlu
YWwgY29tbWVudCBhbmQgcmUtcHVzaCB0aGUgc2VyaWUsIGluIG9yZGVyDQo+IHRvIGF2b2lk
IGZ1cnRoZXIgbm9pc2UsIHdvdWxkIHlvdSBtaW5kIHRvIGdpdmUgbWUgYSBmZWVkYmFjayBv
biB0aGF0Pw0KPiANCj4gV2hhdCBpcyB5b3VyIHByZWZlcmVuY2UgZm9yIHRoZSBLY29uZmln
IHBhcmFtZXRlciBwbGFjZW1lbnQsIGJlZ2lubmluZw0KPiBvZiB0aGUgZmlsZSBvciBlbmQ/
DQoNCkknZCBwdXQgaXQgYXQgdGhlIGVuZCwgYXMgdGhlIHNjaGVkdWxlciBzZWxlY3Rpb24g
aXMgZ2VuZXJhbGx5IG9mIG1vcmUNCmludGVyZXN0IElNSE8uDQoNCg0KSnVlcmdlbg0K
--------------Qj6Zedq0LBnDBg9pqSydHn0K
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Qj6Zedq0LBnDBg9pqSydHn0K--

--------------PhBnKmc00rN9J3wzgWTZt020--

--------------iWut7SOdnUTnzgb1ULH0FCwx
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJgE+wFAwAAAAAACgkQsN6d1ii/Ey/u
vwf/S9sWqkevwVNA9MurdCRVKU3jzq3Q73AdBWnaOVrdb6Xjzn4G/FTfB+xY5hmIYPXHPykWQUD9
txv4TKwzE+gNdxUtb3MgoYL0dcaentocJVS0IquYCrj2ZZ2ri/CZEzZPOoGL9mThNf9vf9zN28Wc
WyhSbYVbDw4o0bNRD5wmb7x8OeWVhMzsASTVilPOwtGc/yR9Mnc0iOiA8Z5LRIYwOpWPykaipIZa
zT+jT1bf5gj9jcbdSWgTYpmWbwtKyTh/QBgE/lZ9jTW67T5rfqvWAz6ilqetxrfuGSj5wqjUK8qj
Hb0YY5G/bF1nxJvqEir2QAvkK5UvnVPqD0S8K/7xDw==
=/Rzz
-----END PGP SIGNATURE-----

--------------iWut7SOdnUTnzgb1ULH0FCwx--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:13:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:13:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309285.525393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5I-0001aX-Cr; Wed, 20 Apr 2022 14:13:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309285.525393; Wed, 20 Apr 2022 14:13:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5I-0001Zd-4w; Wed, 20 Apr 2022 14:13:32 +0000
Received: by outflank-mailman (input) for mailman id 309285;
 Wed, 20 Apr 2022 14:13:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhB5H-0001HT-EW
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:13:31 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c15dbb2-c0b4-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 16:13:29 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c15dbb2-c0b4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650464008;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=3bpTvdBqxpC9w/lc1aSyt+uk0x3/FV7Yyt5iB0rwB6Y=;
  b=Ye6j4eWlS1RvHlAmMTEQHanJDoYHJUjQh+fIR4IQsCo+3oYgj6UgXOo7
   jRYuNxjaQJ5Umnq8BmMtrk9e+R7grWae8TpWjtbibKGF8WkemLhzQflmp
   ML9bRRPQFyhwbkJWWYsVn2h1BQSy06MWNAlkf77xZcL22cJ7DWtTg5HBM
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69517259
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RL9cHaBDpYr7yxVW/1njw5YqxClBgxIJ4kV8jS/XYbTApGgl0mAGz
 2BJUDuFMq2PZTCjKtkjPI2xpkIF6sPRmtZnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj2tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhI8
 4lQp6eWcjtyN6LJh9wsUB5GMj5HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4fQK+BP
 ZdIAdZpRFPKJE1DA0oSNLQvteSmlHfkIxoGqHvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru3U70HxUbP9y30iee/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0YuEMDv8BzjqxkaPb5hmhN2sDUB9eUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPTt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp+ZgPf1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpib/JdoMv24kdBsB3iM4ldnBO
 R67VeR5vsE7AZdXRfUvP9LZ5zoCkcAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89AgORD7n1vmgvuqWXTkk3PPUy2PybFF9/o8TKmM4gE0U9ziFyMr
 Y0OZpfQlk03vS+XSnC/zLP/5GsidRATba0aYeQNHgJfCmKKwF0cNsI=
IronPort-HdrOrdr: A9a23:1vSlO6tXvfEeQotpB9Wl266T7skDTtV00zEX/kB9WHVpmszxra
 6TdZMgpGbJYVcqKRcdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79
 YFT0EXMqyJMbEQt6fHCWeDfOrIuOP3kpyVuQ==
X-IronPort-AV: E=Sophos;i="5.90,275,1643691600"; 
   d="scan'208";a="69517259"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v5 3/6] x86/gdbsx: Move domain_pause_for_debugger() into gdbsx
Date: Wed, 20 Apr 2022 15:13:04 +0100
Message-ID: <20220420141307.24153-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220420141307.24153-1-andrew.cooper3@citrix.com>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

domain_pause_for_debugger() is guest debugging (CONFIG_GDBSX) not host
debugging (CONFIG_CRASH_DEBUG).

Move it into the new gdbsx.c to drop the (incorrect) ifdefary, and provide a
static inline in the !CONFIG_GDBSX case so callers can optimise away
everything rather than having to emit a call to an empty function.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v5:
 * Basically new.  Reworked entirely after re-considering other cleanup.
---
 xen/arch/x86/domain.c               | 14 --------------
 xen/arch/x86/gdbsx.c                | 14 ++++++++++++++
 xen/arch/x86/hvm/svm/svm.c          |  2 +-
 xen/arch/x86/hvm/vmx/realmode.c     |  3 ++-
 xen/arch/x86/hvm/vmx/vmx.c          |  2 +-
 xen/arch/x86/include/asm/debugger.h |  2 --
 xen/arch/x86/include/asm/gdbsx.h    |  6 ++++++
 xen/arch/x86/nmi.c                  |  1 -
 xen/arch/x86/traps.c                |  1 +
 9 files changed, 25 insertions(+), 20 deletions(-)

diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index a5048ed6546a..a72cc9552ad6 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -2540,20 +2540,6 @@ static int __init cf_check init_vcpu_kick_softirq(void)
 }
 __initcall(init_vcpu_kick_softirq);
 
-void domain_pause_for_debugger(void)
-{
-#ifdef CONFIG_CRASH_DEBUG
-    struct vcpu *curr = current;
-    struct domain *d = curr->domain;
-
-    domain_pause_by_systemcontroller_nosync(d);
-
-    /* if gdbsx active, we just need to pause the domain */
-    if ( curr->arch.gdbsx_vcpu_event == 0 )
-        send_global_virq(VIRQ_DEBUGGER);
-#endif
-}
-
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/gdbsx.c b/xen/arch/x86/gdbsx.c
index 59eb31fc9a6a..6ef46e8ea77d 100644
--- a/xen/arch/x86/gdbsx.c
+++ b/xen/arch/x86/gdbsx.c
@@ -18,6 +18,8 @@
 #include <xen/mm.h>
 #include <xen/domain_page.h>
 #include <xen/guest_access.h>
+#include <xen/event.h>
+
 #include <asm/gdbsx.h>
 #include <asm/p2m.h>
 
@@ -164,6 +166,18 @@ int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop)
     return iop->remain ? -EFAULT : 0;
 }
 
+void domain_pause_for_debugger(void)
+{
+    struct vcpu *curr = current;
+    struct domain *d = curr->domain;
+
+    domain_pause_by_systemcontroller_nosync(d);
+
+    /* if gdbsx active, we just need to pause the domain */
+    if ( curr->arch.gdbsx_vcpu_event == 0 )
+        send_global_virq(VIRQ_DEBUGGER);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 2455835eda62..0849a9dc5f41 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -58,7 +58,7 @@
 #include <asm/hvm/trace.h>
 #include <asm/hap.h>
 #include <asm/apic.h>
-#include <asm/debugger.h>
+#include <asm/gdbsx.h>
 #include <asm/hvm/monitor.h>
 #include <asm/monitor.h>
 #include <asm/xstate.h>
diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c
index cc23afa788c2..4ac93e081015 100644
--- a/xen/arch/x86/hvm/vmx/realmode.c
+++ b/xen/arch/x86/hvm/vmx/realmode.c
@@ -14,7 +14,8 @@
 #include <xen/sched.h>
 #include <xen/paging.h>
 #include <xen/softirq.h>
-#include <asm/debugger.h>
+
+#include <asm/gdbsx.h>
 #include <asm/event.h>
 #include <asm/hvm/emulate.h>
 #include <asm/hvm/hvm.h>
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index af9ee7cebbe0..cc8c4e9f044a 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -51,7 +51,7 @@
 #include <asm/hvm/trace.h>
 #include <asm/hvm/monitor.h>
 #include <asm/xenoprof.h>
-#include <asm/debugger.h>
+#include <asm/gdbsx.h>
 #include <asm/apic.h>
 #include <asm/hvm/nestedhvm.h>
 #include <asm/altp2m.h>
diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/arch/x86/include/asm/debugger.h
index c5585752cae7..9a3132356fd6 100644
--- a/xen/arch/x86/include/asm/debugger.h
+++ b/xen/arch/x86/include/asm/debugger.h
@@ -26,8 +26,6 @@
 #include <asm/regs.h>
 #include <asm/processor.h>
 
-void domain_pause_for_debugger(void);
-
 #ifdef CONFIG_CRASH_DEBUG
 
 #include <xen/gdbstub.h>
diff --git a/xen/arch/x86/include/asm/gdbsx.h b/xen/arch/x86/include/asm/gdbsx.h
index eee746fc01d0..938eb74e2e25 100644
--- a/xen/arch/x86/include/asm/gdbsx.h
+++ b/xen/arch/x86/include/asm/gdbsx.h
@@ -9,5 +9,11 @@ struct xen_domctl_gdbsx_memio;
 
 int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop);
 
+void domain_pause_for_debugger(void);
+
+#else
+
+static inline void domain_pause_for_debugger(void) {}
+
 #endif /* CONFIG_GDBSX */
 #endif /* __X86_GDBX_H__ */
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index 302eaf2ff39a..765602374802 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -30,7 +30,6 @@
 #include <asm/msr.h>
 #include <asm/mpspec.h>
 #include <asm/nmi.h>
-#include <asm/debugger.h>
 #include <asm/div64.h>
 #include <asm/apic.h>
 
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 84cd038dc38b..d91532461189 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -58,6 +58,7 @@
 #include <xen/bitops.h>
 #include <asm/desc.h>
 #include <asm/debugreg.h>
+#include <asm/gdbsx.h>
 #include <asm/smp.h>
 #include <asm/flushtlb.h>
 #include <asm/uaccess.h>
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:13:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:13:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309283.525377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5G-0001Hf-P0; Wed, 20 Apr 2022 14:13:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309283.525377; Wed, 20 Apr 2022 14:13:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5G-0001HY-Li; Wed, 20 Apr 2022 14:13:30 +0000
Received: by outflank-mailman (input) for mailman id 309283;
 Wed, 20 Apr 2022 14:13:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhB5G-0001HR-2Z
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:13:30 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0ba8f292-c0b4-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 16:13:28 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ba8f292-c0b4-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650464008;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=5WBV3cEowC/5kYrEFg00ztx1PWHE5BHr/HFwGHA9nB0=;
  b=VpWcafuWS6mkANBtKxmRMUl50ZF5daqya4uQbvwgSEAyxDtk6KjdSZaQ
   WyVHahH1GJI5+u1D/l409+jstXShEczg5sSH+blwL9FUu29qQTduVXptu
   HxcyST7NMwnPkDk2gQ3InzdDia/vw1gmaMn6pxPaF7ln0WpX1SdlwitgN
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 71942788
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aetsRKw5CTiLFy18nwx6t+ffxirEfRIJ4+MujC+fZmUNrF6WrkVVm
 GYXDGnUbqyJZmTweoglao23pktQv8TQzNFkGldlqCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024DhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpluaKSaEApPabwgflBcl52NyZ7H4pm9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6BP
 ptFM2U/PHwsZTVRY3tOMMsZltzvuXKlSjZWog6Hg+04tj27IAtZj+G2bYu9lsaxbftSmkGUt
 2fX5VPTCxsRNMGc4Ted+3fqjejK9Qv5RYYTGbuQ5vNsxlqJyQQ7AhocX0r9rOK5jkO7UtR3J
 Ekd+y5opq83nGShQ8PhRRS+rDiBtwQFRttLO+Qg7UeGza+8yySzC3UATzVBQMc7r8JwTjsvv
 neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty8bniJE+iFTIVNkLOLWuktT/FDX0w
 jaLhCsznbMeiYgMzarTwLzcq2vy/N6TFFdzv1iJGDL+hu9kWGK7T4CWy3mc7fVLEJ+EEnjGk
 lwDnuq5zO9bWPlhixexaOkKGbio4dOMPzvdnUNjEvEdyti9x5KwVdsOuW8jfS+FJu5BIGa0O
 xGL5Wu98bcJZBOXgblLj5Vd4ijA5YzpDpzbW//ddbKiibAhJVbcrEmCiaN9tl0BcXTAc4liY
 f93ku72VB727JiLKxLsGY8gPUcDnHxW+I8qbcmTI+6b+bSffmWJbrwOLUGDaOs0hIvd/liNr
 44Fa5TVkUUDOAEbXsUx2ddCRbztBSJlba0aVuQNLrLTSuaYMD1J5wDtLUMJJNU+wvU9ehbg9
 XChQE5IoGcTdlWcQThmnktLMeu1Nb4m9CpTFXV1YT6Ahil4Ca7yvfh3SnfCVeR+nACV5aUsH
 6dtlgTpKqkndwkrDBxENMem/d0+Lknz7e9MVgL8CAUCk1dbb1Sh0rfZksHHqEHi0gLfWRMCn
 oCd
IronPort-HdrOrdr: A9a23:YkwWa6Grsyj7T1m2pLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy
 nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78
 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK
 Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A==
X-IronPort-AV: E=Sophos;i="5.90,275,1643691600"; 
   d="scan'208";a="71942788"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Bobby Eshleman <bobby.eshleman@gmail.com>
Subject: [PATCH v5 0/6] Clean up common/arch split for debugger.h
Date: Wed, 20 Apr 2022 15:13:01 +0100
Message-ID: <20220420141307.24153-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

This work is primarily to prevent new architectures from needing to implement
a stub debugger.h for something that is in practice only implemented on x86,
and probably bitrotten into oblivion.  It also resolves a lot of technical
debt on the x86 side.

Andrew Cooper (3):
  x86/gdbsx: Move domain_pause_for_debugger() into gdbsx
  x86/gdbstub: Clean up includes
  x86/debugger: Misc cleanup prior to splitting

Bobby Eshleman (3):
  x86/debugger: Remove debugger_trap_entry()
  x86/gdbsx: Rename debug.c to gdbsx.c
  xen: Split x86/debugger.h into common and arch specific parts

 xen/arch/arm/include/asm/debugger.h | 15 ------
 xen/arch/x86/Makefile               |  2 +-
 xen/arch/x86/domain.c               | 14 ------
 xen/arch/x86/domctl.c               | 14 +-----
 xen/arch/x86/gdbstub.c              |  5 +-
 xen/arch/x86/{debug.c => gdbsx.c}   | 37 +++++++++------
 xen/arch/x86/hvm/svm/svm.c          |  2 +-
 xen/arch/x86/hvm/vmx/realmode.c     |  3 +-
 xen/arch/x86/hvm/vmx/vmx.c          |  2 +-
 xen/arch/x86/include/asm/debugger.h | 93 +++++--------------------------------
 xen/arch/x86/include/asm/gdbsx.h    | 19 ++++++++
 xen/arch/x86/nmi.c                  |  1 -
 xen/arch/x86/setup.c                |  1 -
 xen/arch/x86/traps.c                | 37 +++++++--------
 xen/arch/x86/x86_64/gdbstub.c       |  2 +-
 xen/common/domain.c                 |  1 -
 xen/common/gdbstub.c                |  3 +-
 xen/common/keyhandler.c             |  2 +-
 xen/common/shutdown.c               |  2 +-
 xen/drivers/char/console.c          |  2 +-
 xen/include/xen/debugger.h          | 44 ++++++++++++++++++
 xen/include/xen/gdbstub.h           |  2 +
 22 files changed, 133 insertions(+), 170 deletions(-)
 delete mode 100644 xen/arch/arm/include/asm/debugger.h
 rename xen/arch/x86/{debug.c => gdbsx.c} (87%)
 create mode 100644 xen/arch/x86/include/asm/gdbsx.h
 create mode 100644 xen/include/xen/debugger.h

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:13:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:13:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309284.525388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5I-0001XJ-0C; Wed, 20 Apr 2022 14:13:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309284.525388; Wed, 20 Apr 2022 14:13:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5H-0001XC-Sq; Wed, 20 Apr 2022 14:13:31 +0000
Received: by outflank-mailman (input) for mailman id 309284;
 Wed, 20 Apr 2022 14:13:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhB5G-0001HT-Sl
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:13:31 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0be2b538-c0b4-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 16:13:28 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0be2b538-c0b4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650464008;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=6rpyxvnpX51Fwc4NnxSavHiI4jI1PWIWDeeEhjuyTPM=;
  b=J4X0MrkgbbeuhmOy9eFyME3MgFYMBH6RZUzAX5r5HuSkl5TuavXAKUUn
   thBmwuIRC0P3455pxSY5Q7dqt59ZQb2LlsM4TNiQA5vy+DvDYq1izDs+/
   lBWi9ovLyy7LPLA7RH/CuJbcgfumghGlItAUrCQEKgr0cKRa+kUHcoSwr
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69534205
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dHYvx6x9cewgMImUpfR6t+dHxirEfRIJ4+MujC+fZmUNrF6WrkUDy
 moYDzrTbquMajbwKIwlO9618BgDuJHVy4dqSQI4qyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024DhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplmZWUQlwDJbX1qO0zVgl0Kg5zG4BhweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AN
 pdCNWA3MXwsZTVJYUYlS8pit93zoVzlThICimm1tJUetj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO8EzzArW4LHM2jaQKG0UYgduZfoLk/ZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WvQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW
 1BexaCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I90IvGkkeBg2aJZYEdMMX
 KM1kVoAjHO0FCH0BZKbnqrrU5h6pUQePYiNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3FlrUuOFM+T8vhS+efHDJJjYexdYAXmgyFQxP7snTg5B
 P4GbpXRmkQDCrCmCsQVmKZKRW03wbEALcieg6RqmiSrfmKKxElJ5yft/I4c
IronPort-HdrOrdr: A9a23:jOnAC6DMw5WSRT/lHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo7v
 xG/c5rsyMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN
 9dmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.90,275,1643691600"; 
   d="scan'208";a="69534205"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v5 4/6] x86/gdbstub: Clean up includes
Date: Wed, 20 Apr 2022 15:13:05 +0100
Message-ID: <20220420141307.24153-5-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220420141307.24153-1-andrew.cooper3@citrix.com>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

common/gdbstub.c wants struct gdb_context but only gets it transitively
through asm/debugger.h.  None of */gdbstub.c should include asm/debugger.h so
include xen/gdbstub.h instead.

Forward declare struct cpu_user_regs in xen/gdbstub.h so it doesn't depend on
the include order to compile.

x86/setup.c doesn't need xen/gdbstub.h at all, so drop it.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v5:
 * New
---
 xen/arch/x86/gdbstub.c        | 5 ++++-
 xen/arch/x86/setup.c          | 1 -
 xen/arch/x86/x86_64/gdbstub.c | 2 +-
 xen/common/gdbstub.c          | 3 ++-
 xen/include/xen/gdbstub.h     | 2 ++
 5 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/gdbstub.c b/xen/arch/x86/gdbstub.c
index 8f4f49fd3b54..961cae0be74f 100644
--- a/xen/arch/x86/gdbstub.c
+++ b/xen/arch/x86/gdbstub.c
@@ -18,7 +18,10 @@
  * You should have received a copy of the GNU General Public License
  * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
-#include <asm/debugger.h>
+#include <asm/uaccess.h>
+#include <asm/x86-defns.h>
+
+#include <xen/gdbstub.h>
 
 u16
 gdb_arch_signal_num(struct cpu_user_regs *regs, unsigned long cookie)
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 6f20e178929f..53a73010e029 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -15,7 +15,6 @@
 #include <xen/multiboot.h>
 #include <xen/domain_page.h>
 #include <xen/version.h>
-#include <xen/gdbstub.h>
 #include <xen/hypercall.h>
 #include <xen/keyhandler.h>
 #include <xen/numa.h>
diff --git a/xen/arch/x86/x86_64/gdbstub.c b/xen/arch/x86/x86_64/gdbstub.c
index 2626519c89c7..8287124dfb1d 100644
--- a/xen/arch/x86/x86_64/gdbstub.c
+++ b/xen/arch/x86/x86_64/gdbstub.c
@@ -17,7 +17,7 @@
  * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <asm/debugger.h>
+#include <xen/gdbstub.h>
 
 #define GDB_REG64(r) gdb_write_to_packet_hex(r, sizeof(u64), ctx)
 #define GDB_REG32(r)  gdb_write_to_packet_hex(r, sizeof(u32), ctx)
diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c
index d6872721dc0d..df8d122bce8d 100644
--- a/xen/common/gdbstub.c
+++ b/xen/common/gdbstub.c
@@ -38,13 +38,14 @@
 #include <xen/serial.h>
 #include <xen/irq.h>
 #include <xen/watchdog.h>
-#include <asm/debugger.h>
 #include <xen/init.h>
 #include <xen/param.h>
 #include <xen/smp.h>
 #include <xen/console.h>
 #include <xen/errno.h>
 #include <xen/delay.h>
+#include <xen/gdbstub.h>
+
 #include <asm/byteorder.h>
 
 /* Printk isn't particularly safe just after we've trapped to the
diff --git a/xen/include/xen/gdbstub.h b/xen/include/xen/gdbstub.h
index 0b2041095d88..18c960969b76 100644
--- a/xen/include/xen/gdbstub.h
+++ b/xen/include/xen/gdbstub.h
@@ -25,6 +25,8 @@
 
 #ifdef CONFIG_CRASH_DEBUG
 
+struct cpu_user_regs;
+
 struct gdb_context {
     int                 serhnd;           /* handle on our serial line */
     int                 console_steal_id; /* handle on stolen console */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:13:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:13:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309286.525410 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5K-000268-Q1; Wed, 20 Apr 2022 14:13:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309286.525410; Wed, 20 Apr 2022 14:13:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5K-00025u-Lk; Wed, 20 Apr 2022 14:13:34 +0000
Received: by outflank-mailman (input) for mailman id 309286;
 Wed, 20 Apr 2022 14:13:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhB5I-0001HT-A0
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:13:32 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0df5faec-c0b4-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 16:13:30 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0df5faec-c0b4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650464010;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=qmoska+aIxotu+Z9bq9lWSYhYAKM0rZmYd2eehh+pdw=;
  b=ZtaAE8PvL6sqmWb5OxPYlVy72qOwxQoSED31YAhOuMOU4a5MsRRn/OFd
   5X5liRGvz3sG9qNIBfYkBfx7D15qRFx2RNtxtCgDLIpF4X3I8hAA/FT7w
   jezmkrCs6eAYrQU3An6N1QRSI64hBObjzyPu/1V7KOL3CRtMKydm+oDy8
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69517260
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0kYFbKJnwVqI8b+rFE+RoZUlxSXFcZb7ZxGr2PjKsXjdYENS0zJRn
 zBKXmrTbv2KZmD8fNlzbY618UsPscTUxtE1HQBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQw2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Ox26YGiciESAvbFl+ECayhbFD9fIpQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6eDP
 pVDN2IHgBLoOTBzYnQLV7YFn/qmmVnSajkAj12MjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zbKBwHMN2UyRKe72mhwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJpKLEn+jqr8ZaP6gmcGVA1TTlfScMf4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud1IWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtTABbvzt68owGOlor6p5
 iZspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD+JdwIum0hex05bq7onAMFh
 meK6Gu9A7cJYhOXgVJfOdrtW6zGM4C8fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ6nUgWmDKMLa0XOjz6iNJyklbOEedbWLZPB8hkhJ65TPL9q
 o8BbJrbl08CCIUToED/qOYuELzDFlBjbbieliCdXrXrztZOcI35N8Ls/A==
IronPort-HdrOrdr: A9a23:yVRE/65m3dlgKvVMtAPXwPLXdLJyesId70hD6qhwISY1TiX+rb
 HXoB17726MtN9/YgBCpTntAsa9qDbnhPpICOoqTNGftWvdyQmVxehZhOOIqVCNJ8S9zJ876U
 4JSdkENDSaNzhHZKjBjjVQa+xQpeW6zA==
X-IronPort-AV: E=Sophos;i="5.90,275,1643691600"; 
   d="scan'208";a="69517260"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v5 5/6] x86/debugger: Misc cleanup prior to splitting
Date: Wed, 20 Apr 2022 15:13:06 +0100
Message-ID: <20220420141307.24153-6-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220420141307.24153-1-andrew.cooper3@citrix.com>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

 * Remove inappropriate semicolon from debugger_trap_immediate()
 * Try to explain what debugger_trap_fatal() is doing, and write it in a more
   legible way.
 * Drop unecessary includes.  This includes common/domain.c which doesn't use
   any debugger functionality, even prior to this cleaup.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v5:
 * New
---
 xen/arch/x86/include/asm/debugger.h | 17 +++++++++++------
 xen/common/domain.c                 |  1 -
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/arch/x86/include/asm/debugger.h
index 9a3132356fd6..5bac2ee4c2a4 100644
--- a/xen/arch/x86/include/asm/debugger.h
+++ b/xen/arch/x86/include/asm/debugger.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * asm/debugger.h
  * 
@@ -22,23 +23,27 @@
 #ifndef __X86_DEBUGGER_H__
 #define __X86_DEBUGGER_H__
 
-#include <xen/sched.h>
-#include <asm/regs.h>
-#include <asm/processor.h>
-
 #ifdef CONFIG_CRASH_DEBUG
 
 #include <xen/gdbstub.h>
+#include <xen/stdbool.h>
+
+#include <asm/x86-defns.h>
 
+/* Returns true if GDB handled the trap, or it is surviveable. */
 static inline bool debugger_trap_fatal(
     unsigned int vector, struct cpu_user_regs *regs)
 {
     int rc = __trap_to_gdb(regs, vector);
-    return ((rc == 0) || (vector == TRAP_int3));
+
+    if ( rc == 0 )
+        return true;
+
+    return vector == X86_EXC_BP;
 }
 
 /* Int3 is a trivial way to gather cpu_user_regs context. */
-#define debugger_trap_immediate() __asm__ __volatile__ ( "int3" );
+#define debugger_trap_immediate() __asm__ __volatile__ ( "int3" )
 
 #else
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 351029f8b239..8d2c2a989708 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -33,7 +33,6 @@
 #include <xen/xenoprof.h>
 #include <xen/irq.h>
 #include <xen/argo.h>
-#include <asm/debugger.h>
 #include <asm/p2m.h>
 #include <asm/processor.h>
 #include <public/sched.h>
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:13:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:13:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309287.525417 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5L-0002Ab-Ce; Wed, 20 Apr 2022 14:13:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309287.525417; Wed, 20 Apr 2022 14:13:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5L-000295-0p; Wed, 20 Apr 2022 14:13:35 +0000
Received: by outflank-mailman (input) for mailman id 309287;
 Wed, 20 Apr 2022 14:13:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhB5J-0001HR-7J
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:13:33 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0e00f121-c0b4-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 16:13:31 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e00f121-c0b4-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650464011;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ppo83czs3ZgYyCOMzHGediGbdWtmuqhueJbG2O/yc+o=;
  b=MFSzwkfMhTTu6qlVZq8Q6u+GRglnVaCNO1eZnAk+6K+NiNC6754bx5rm
   OZj8G0x2rP0tmzM/HbWfhu6TlGXPwgefBbHsdz/3VGj1lx3705SjoN5WB
   GG5FCLRxHACx0RdeH/mdJ0u8RGVvM9VfwYsvMFRZi8iOz3cWiffCa6GUK
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69517263
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:njTUzKBu+KwjUBVW/yPjw5YqxClBgxIJ4kV8jS/XYbTApGtw0D0Ex
 msWXm6BM63bZDakLo8ibIuwp0kFsZXTzddjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj2tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhI8
 4lQp6eWcjtyN6LJh9wsUB5GMj5HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4fQK+BP
 ZRCAdZpRDjqWTJSAlgcM68FgsaV32D5aQ94hmvA8MLb5ECMlVcsgdABKuH9WPaHWMFUlUawv
 X/d8iLyBRRyHMOb4SqI9DSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3I
 Use8DtooLMy8EGuR9/VUBixoXrCtRkZM+e8CMVjtlvLkPCNpV/EWC5UFVatdeDKqucPfmA3x
 GSvpO+yDDNqr4WkSnWD16it+Gba1TcuEUcOYioNTA0g6tbloZ0ugh+ncuuPAJJZnfWuR2iun
 mniQDwWwuxK0JVVj/nTEUXv2WrEm3TfcuIiCuw7tEqB5xgxWoOqbpfABbPzvacZd9bxorVsU
 RE5dymiAAImUMnleM+lGrxl8FSVCxGtamO0vLKXN8N9nwlBAlb6FWyq3BlwJV1yLuEPciLzb
 UnYtGt5vcEOZCfyN/MoPNjhV6zGKJQM8/y8B5g4ifIUPPBMmPKvpnkyNSZ8IUix+KTTrU3PE
 cjCKpv9ZZrrIa9m0CC3V48gPUwDnUgDKZfobcmjlXyPiOPGDFbMEOttGAbfNYgRsfLbyDg5B
 v4CbqNmPT0ECL2gCsQWmKZORW03wY8TXMmo8J0GKrTeemKL2ggJUpfs/F/oQKQ994w9qwsC1
 irVtpNwoLYnuUD6FA==
IronPort-HdrOrdr: A9a23:4o56TKxqiMif+cPvhn2VKrPwFr1zdoMgy1knxilNoRw8SK2lfq
 eV7YwmPH7P+U8ssR4b6LO90cW7Lk80sKQFhbX5Xo3SOjUO2lHYTr2KhLGKq1aLdkHDH6xmpM
 BdmsBFeabN5DNB7foSjjPXLz9Z+qjjzJyV
X-IronPort-AV: E=Sophos;i="5.90,275,1643691600"; 
   d="scan'208";a="69517263"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Bobby Eshleman <bobby.eshleman@gmail.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v5 1/6] x86/debugger: Remove debugger_trap_entry()
Date: Wed, 20 Apr 2022 15:13:02 +0100
Message-ID: <20220420141307.24153-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220420141307.24153-1-andrew.cooper3@citrix.com>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

From: Bobby Eshleman <bobby.eshleman@gmail.com>

debugger_trap_entry() is unrelated to the other contents of debugger.h.  It is
a no-op for everything other than #DB/#BP, and for those it invokes guest
debugging (CONFIG_GDBSX) not host debugging (CONFIG_CRASH_DEBUG).

Furthermore, the description of how to use debugger_trap_entry() is at best,
stale.  It is not called from all exception paths, and because the developer
is forced to modify Xen to perform debugging, editing debugger_trap_entry() is
not the way one would efficiently go about diagnosing the problem.

Simplify everything by expanding debugger_trap_entry() into its two non-empty
locations, fixing bugs with their positioning (vs early exceptions and curr
not being safe to deference) and for #DB, deferring the pause until the
changes in %dr6 are saved to v->arch.dr6 so the debugger can actually see
which condition triggered.

Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v5:
 * Remove dead logic.  Move GDBSX changes into a later patch.
 * Rewrite commmit message.
---
 xen/arch/x86/include/asm/debugger.h | 42 ++-----------------------------------
 xen/arch/x86/traps.c                | 34 +++++++++++++-----------------
 2 files changed, 16 insertions(+), 60 deletions(-)

diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/arch/x86/include/asm/debugger.h
index 221bcde13796..e83b346a21d1 100644
--- a/xen/arch/x86/include/asm/debugger.h
+++ b/xen/arch/x86/include/asm/debugger.h
@@ -5,19 +5,12 @@
  * 
  * Each debugger should define two functions here:
  * 
- * 1. debugger_trap_entry(): 
- *  Called at start of any synchronous fault or trap, before any other work
- *  is done. The idea is that if your debugger deliberately caused the trap
- *  (e.g. to implement breakpoints or data watchpoints) then you can take
- *  appropriate action and return a non-zero value to cause early exit from
- *  the trap function.
- * 
- * 2. debugger_trap_fatal():
+ * debugger_trap_fatal():
  *  Called when Xen is about to give up and crash. Typically you will use this
  *  hook to drop into a debug session. It can also be used to hook off
  *  deliberately caused traps (which you then handle and return non-zero).
  *
- * 3. debugger_trap_immediate():
+ * debugger_trap_immediate():
  *  Called if we want to drop into a debugger now.  This is essentially the
  *  same as debugger_trap_fatal, except that we use the current register state
  *  rather than the state which was in effect when we took the trap.
@@ -49,31 +42,6 @@ static inline bool debugger_trap_fatal(
 /* Int3 is a trivial way to gather cpu_user_regs context. */
 #define debugger_trap_immediate() __asm__ __volatile__ ( "int3" );
 
-static inline bool debugger_trap_entry(
-    unsigned int vector, struct cpu_user_regs *regs)
-{
-    /*
-     * This function is called before any checks are made.  Amongst other
-     * things, be aware that during early boot, current is not a safe pointer
-     * to follow.
-     */
-    struct vcpu *v = current;
-
-    if ( vector != TRAP_int3 && vector != TRAP_debug )
-        return false;
-
-    if ( guest_mode(regs) && guest_kernel_mode(v, regs) &&
-         v->domain->debugger_attached  )
-    {
-        if ( vector != TRAP_debug ) /* domain pause is good enough */
-            current->arch.gdbsx_vcpu_event = vector;
-        domain_pause_for_debugger();
-        return true;
-    }
-
-    return false;
-}
-
 #else
 
 static inline bool debugger_trap_fatal(
@@ -84,12 +52,6 @@ static inline bool debugger_trap_fatal(
 
 #define debugger_trap_immediate() ((void)0)
 
-static inline bool debugger_trap_entry(
-    unsigned int vector, struct cpu_user_regs *regs)
-{
-    return false;
-}
-
 #endif
 
 #ifdef CONFIG_GDBSX
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 4c38f6c01539..84cd038dc38b 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -946,9 +946,6 @@ void do_trap(struct cpu_user_regs *regs)
     if ( regs->error_code & X86_XEC_EXT )
         goto hardware_trap;
 
-    if ( debugger_trap_entry(trapnr, regs) )
-        return;
-
     ASSERT(trapnr < 32);
 
     if ( guest_mode(regs) )
@@ -1177,9 +1174,6 @@ void do_invalid_op(struct cpu_user_regs *regs)
     int id = -1, lineno;
     const struct virtual_region *region;
 
-    if ( debugger_trap_entry(TRAP_invalid_op, regs) )
-        return;
-
     if ( likely(guest_mode(regs)) )
     {
         if ( pv_emulate_invalid_op(regs) )
@@ -1284,8 +1278,7 @@ void do_invalid_op(struct cpu_user_regs *regs)
 
 void do_int3(struct cpu_user_regs *regs)
 {
-    if ( debugger_trap_entry(TRAP_int3, regs) )
-        return;
+    struct vcpu *curr = current;
 
     if ( !guest_mode(regs) )
     {
@@ -1299,6 +1292,13 @@ void do_int3(struct cpu_user_regs *regs)
         return;
     }
 
+    if ( guest_kernel_mode(curr, regs) && curr->domain->debugger_attached )
+    {
+        curr->arch.gdbsx_vcpu_event = TRAP_int3;
+        domain_pause_for_debugger();
+        return;
+    }
+
     pv_inject_hw_exception(TRAP_int3, X86_EVENT_NO_EC);
 }
 
@@ -1575,9 +1575,6 @@ void do_page_fault(struct cpu_user_regs *regs)
     /* fixup_page_fault() might change regs->error_code, so cache it here. */
     error_code = regs->error_code;
 
-    if ( debugger_trap_entry(TRAP_page_fault, regs) )
-        return;
-
     perfc_incr(page_faults);
 
     /* Any shadow stack access fault is a bug in Xen. */
@@ -1676,9 +1673,6 @@ void do_general_protection(struct cpu_user_regs *regs)
     struct vcpu *v = current;
 #endif
 
-    if ( debugger_trap_entry(TRAP_gp_fault, regs) )
-        return;
-
     if ( regs->error_code & X86_XEC_EXT )
         goto hardware_gp;
 
@@ -1971,9 +1965,6 @@ void do_debug(struct cpu_user_regs *regs)
     /* Stash dr6 as early as possible. */
     dr6 = read_debugreg(6);
 
-    if ( debugger_trap_entry(TRAP_debug, regs) )
-        return;
-
     /*
      * At the time of writing (March 2018), on the subject of %dr6:
      *
@@ -2082,6 +2073,12 @@ void do_debug(struct cpu_user_regs *regs)
     v->arch.dr6 |= (dr6 & ~X86_DR6_DEFAULT);
     v->arch.dr6 &= (dr6 | ~X86_DR6_DEFAULT);
 
+    if ( guest_kernel_mode(v, regs) && v->domain->debugger_attached )
+    {
+        domain_pause_for_debugger();
+        return;
+    }
+
     pv_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC);
 }
 
@@ -2097,9 +2094,6 @@ void do_entry_CP(struct cpu_user_regs *regs)
     const char *err = "??";
     unsigned int ec = regs->error_code;
 
-    if ( debugger_trap_entry(X86_EXC_CP, regs) )
-        return;
-
     /* Decode ec if possible */
     if ( ec < ARRAY_SIZE(errors) && errors[ec][0] )
         err = errors[ec];
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:13:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:13:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309288.525423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5L-0002Jh-R0; Wed, 20 Apr 2022 14:13:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309288.525423; Wed, 20 Apr 2022 14:13:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5L-0002Gm-HI; Wed, 20 Apr 2022 14:13:35 +0000
Received: by outflank-mailman (input) for mailman id 309288;
 Wed, 20 Apr 2022 14:13:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhB5J-0001HT-AI
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:13:33 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0de30529-c0b4-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 16:13:30 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0de30529-c0b4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650464010;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=gXnxEoUiWo8s2nXZt3K2P0Lqj86T6+uf6sicbBh7yZU=;
  b=J3knBZaezJhIuzzcdTBpkP7meSkUhWyAX3Mdu2a07ASW/Shr9T+UAO70
   XScZz+mSFegg09ZEhyoJNPO+9UI44Uozgw68ohqRQXxL0mzBOlJoc7C6q
   2Y8ZPkA8J84NL9a5KM/YENkyM3JgBKYlktD4ksgdJdflWSW/VSamAZ9OL
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69534207
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZpbATarVUlS7DXBnP68teaupsJBeBmLwZRIvgKrLsJaIsI4StFCzt
 garIBmCP6uNZGv1LY10Ydni8kgBvJPSz9BqTwNrq39gFC4Q9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 4uq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBEqTok783SAFhIyhQOL1qwZDKB1WYiJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxPUmbP0cXZT/7Droz3+r02lXgIgRhj2O0+7sq8y+CzQF+he2F3N39JYXRGJQ9clyjj
 mDb+2X0BDkKOdrZziCKmlqzgsffkCW9X5gdfJWy++R2mlSVyioWAQcPSFqgifCjjwi1XNc3A
 3IT/i0ivK0j7nuBR9P2XwC7iHOctxtaUN1Ve8Uw7wuH2+zZ+AadC20NSBZObdUnsIk9QjlC/
 k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz
 FiijgIzmrEShs4jzLig8BbMhDfEm3TSZldrvEONBDvjt14nIt7+D2C11bTFxdpJCI3CZEKZh
 UgNtc2OwNkhALegsxXYFY3hA4qVz/qCNTTdh3tmEJ8g6ymh9hafQGxA3N1tDBw3a5hZIFcFd
 GeW4FoMv8ELYBNGeIctO+qM59IWIb8M/DgPftTddZJwb5d4b2drFwk+NBfLjwgBfKXB+JzT2
 Kt3k+7xVR726ow9lVJaotvxNpdxmEgDKZv7H8yT8vhe+eP2iISpYbkEKkCSSesy8bmJpg7Ym
 /4GaZbSl00FDLKhOHmLmWL2EbzsBSFqbXwRg5YJHtNv3yI8QD1xYxMv6e9Jl3NZc1R9yb6To
 yDVtr5ww1vjn3zXQThmmVg4AI4Dqa1X9CphVQR1ZA7A8yF6Pe6HsfZEH7NqLOZPyQCW5aMtJ
 xXzU57YUqonp/Wu02l1UKQRW6Q7LUrw1FPSZXf9CNX9FrY5LzH0FhbfVlOH3EEz4uCf6aPSf
 5XIOtvnfKc+
IronPort-HdrOrdr: A9a23:m3VoOamXvnPmrWDt/Obggpc5ltHpDfIU3DAbv31ZSRFFG/Fxl6
 iV8sjzsiWE8Qr5OUtQ/+xoV5PhfZqxz/JICMwqTNKftWrdyQyVxeNZnOjfKlTbckWUnINgPO
 VbAsxD4bXLfCBHZK3BgTVQfexO/DD+ytHLudvj
X-IronPort-AV: E=Sophos;i="5.90,275,1643691600"; 
   d="scan'208";a="69534207"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Bobby Eshleman <bobby.eshleman@gmail.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>
Subject: [PATCH v5 6/6] xen: Split x86/debugger.h into common and arch specific parts
Date: Wed, 20 Apr 2022 15:13:07 +0100
Message-ID: <20220420141307.24153-7-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220420141307.24153-1-andrew.cooper3@citrix.com>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

From: Bobby Eshleman <bobby.eshleman@gmail.com>

With all the non-CONFIG_CRASH_DEBUG functionality moved elsewhere, split
x86/debugger.h in two, with the stubs and explanation moved to xen/debugger.h.

In particular, this means that arches only need to provide an $arch/debugger.h
if they implement CONFIG_CRASH_DEBUG, and ARM's stub can be deleted.

Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

v5:
 * Clean up includes
 * Drop rendundant comments
---
 xen/arch/arm/include/asm/debugger.h                | 15 --------
 xen/arch/x86/include/asm/debugger.h                | 34 +----------------
 xen/arch/x86/traps.c                               |  2 +-
 xen/common/keyhandler.c                            |  2 +-
 xen/common/shutdown.c                              |  2 +-
 xen/drivers/char/console.c                         |  2 +-
 .../x86/include/asm => include/xen}/debugger.h     | 44 +++++++---------------
 7 files changed, 20 insertions(+), 81 deletions(-)
 delete mode 100644 xen/arch/arm/include/asm/debugger.h
 copy xen/{arch/x86/include/asm => include/xen}/debugger.h (54%)

diff --git a/xen/arch/arm/include/asm/debugger.h b/xen/arch/arm/include/asm/debugger.h
deleted file mode 100644
index ac776efa7899..000000000000
--- a/xen/arch/arm/include/asm/debugger.h
+++ /dev/null
@@ -1,15 +0,0 @@
-#ifndef __ARM_DEBUGGER_H__
-#define __ARM_DEBUGGER_H__
-
-#define debugger_trap_fatal(v, r) (0)
-#define debugger_trap_immediate() ((void) 0)
-
-#endif /* __ARM_DEBUGGER_H__ */
-/*
- * Local variables:
- * mode: C
- * c-file-style: "BSD"
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/arch/x86/include/asm/debugger.h
index 5bac2ee4c2a4..a5c299c6c34d 100644
--- a/xen/arch/x86/include/asm/debugger.h
+++ b/xen/arch/x86/include/asm/debugger.h
@@ -1,30 +1,12 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
- * asm/debugger.h
- * 
- * Generic hooks into arch-dependent Xen.
- * 
- * Each debugger should define two functions here:
- * 
- * debugger_trap_fatal():
- *  Called when Xen is about to give up and crash. Typically you will use this
- *  hook to drop into a debug session. It can also be used to hook off
- *  deliberately caused traps (which you then handle and return non-zero).
+ * xen/arch/x86/include/asm/debugger.h
  *
- * debugger_trap_immediate():
- *  Called if we want to drop into a debugger now.  This is essentially the
- *  same as debugger_trap_fatal, except that we use the current register state
- *  rather than the state which was in effect when we took the trap.
- *  For example: if we're dying because of an unhandled exception, we call
- *  debugger_trap_fatal; if we're dying because of a panic() we call
- *  debugger_trap_immediate().
+ * x86-specific debugger hooks.
  */
-
 #ifndef __X86_DEBUGGER_H__
 #define __X86_DEBUGGER_H__
 
-#ifdef CONFIG_CRASH_DEBUG
-
 #include <xen/gdbstub.h>
 #include <xen/stdbool.h>
 
@@ -45,16 +27,4 @@ static inline bool debugger_trap_fatal(
 /* Int3 is a trivial way to gather cpu_user_regs context. */
 #define debugger_trap_immediate() __asm__ __volatile__ ( "int3" )
 
-#else
-
-static inline bool debugger_trap_fatal(
-    unsigned int vector, struct cpu_user_regs *regs)
-{
-    return false;
-}
-
-#define debugger_trap_immediate() ((void)0)
-
-#endif
-
 #endif /* __X86_DEBUGGER_H__ */
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index d91532461189..25bffe47d7ae 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -36,6 +36,7 @@
 #include <xen/shutdown.h>
 #include <xen/guest_access.h>
 #include <asm/regs.h>
+#include <xen/debugger.h>
 #include <xen/delay.h>
 #include <xen/event.h>
 #include <xen/spinlock.h>
@@ -64,7 +65,6 @@
 #include <asm/uaccess.h>
 #include <asm/i387.h>
 #include <asm/xstate.h>
-#include <asm/debugger.h>
 #include <asm/msr.h>
 #include <asm/nmi.h>
 #include <asm/xenoprof.h>
diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
index ca9ee0790149..0a551033c443 100644
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -3,6 +3,7 @@
  */
 
 #include <asm/regs.h>
+#include <xen/debugger.h>
 #include <xen/delay.h>
 #include <xen/keyhandler.h>
 #include <xen/param.h>
@@ -20,7 +21,6 @@
 #include <xen/mm.h>
 #include <xen/watchdog.h>
 #include <xen/init.h>
-#include <asm/debugger.h>
 #include <asm/div64.h>
 
 static unsigned char keypress_key;
diff --git a/xen/common/shutdown.c b/xen/common/shutdown.c
index abde48aa4ca0..a933ee001ea4 100644
--- a/xen/common/shutdown.c
+++ b/xen/common/shutdown.c
@@ -2,13 +2,13 @@
 #include <xen/lib.h>
 #include <xen/param.h>
 #include <xen/sched.h>
+#include <xen/debugger.h>
 #include <xen/domain.h>
 #include <xen/delay.h>
 #include <xen/watchdog.h>
 #include <xen/shutdown.h>
 #include <xen/console.h>
 #include <xen/kexec.h>
-#include <asm/debugger.h>
 #include <public/sched.h>
 
 /* opt_noreboot: If true, machine will need manual reset on error. */
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index d9d6556c2293..f9937c5134c0 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -15,6 +15,7 @@
 #include <xen/init.h>
 #include <xen/event.h>
 #include <xen/console.h>
+#include <xen/debugger.h>
 #include <xen/param.h>
 #include <xen/serial.h>
 #include <xen/softirq.h>
@@ -26,7 +27,6 @@
 #include <xen/kexec.h>
 #include <xen/ctype.h>
 #include <xen/warning.h>
-#include <asm/debugger.h>
 #include <asm/div64.h>
 #include <xen/hypercall.h> /* for do_console_io */
 #include <xen/early_printk.h>
diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/include/xen/debugger.h
similarity index 54%
copy from xen/arch/x86/include/asm/debugger.h
copy to xen/include/xen/debugger.h
index 5bac2ee4c2a4..72684268aff7 100644
--- a/xen/arch/x86/include/asm/debugger.h
+++ b/xen/include/xen/debugger.h
@@ -1,11 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
- * asm/debugger.h
- * 
- * Generic hooks into arch-dependent Xen.
- * 
- * Each debugger should define two functions here:
- * 
+ * Arch specific debuggers should implement:
+ *
  * debugger_trap_fatal():
  *  Called when Xen is about to give up and crash. Typically you will use this
  *  hook to drop into a debug session. It can also be used to hook off
@@ -20,41 +16,29 @@
  *  debugger_trap_immediate().
  */
 
-#ifndef __X86_DEBUGGER_H__
-#define __X86_DEBUGGER_H__
+#ifndef __XEN_DEBUGGER_H__
+#define __XEN_DEBUGGER_H__
 
 #ifdef CONFIG_CRASH_DEBUG
 
-#include <xen/gdbstub.h>
-#include <xen/stdbool.h>
-
-#include <asm/x86-defns.h>
-
-/* Returns true if GDB handled the trap, or it is surviveable. */
-static inline bool debugger_trap_fatal(
-    unsigned int vector, struct cpu_user_regs *regs)
-{
-    int rc = __trap_to_gdb(regs, vector);
-
-    if ( rc == 0 )
-        return true;
+#include <asm/debugger.h>
 
-    return vector == X86_EXC_BP;
-}
+#else
 
-/* Int3 is a trivial way to gather cpu_user_regs context. */
-#define debugger_trap_immediate() __asm__ __volatile__ ( "int3" )
+#include <xen/stdbool.h>
 
-#else
+struct cpu_user_regs;
 
 static inline bool debugger_trap_fatal(
-    unsigned int vector, struct cpu_user_regs *regs)
+    unsigned int vector, const struct cpu_user_regs *regs)
 {
     return false;
 }
 
-#define debugger_trap_immediate() ((void)0)
+static inline void debugger_trap_immediate(void)
+{
+}
 
-#endif
+#endif /* CONFIG_CRASH_DEBUG */
 
-#endif /* __X86_DEBUGGER_H__ */
+#endif /* __XEN_DEBUGGER_H__ */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:13:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:13:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309289.525429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5M-0002Xj-FN; Wed, 20 Apr 2022 14:13:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309289.525429; Wed, 20 Apr 2022 14:13:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhB5M-0002UH-9J; Wed, 20 Apr 2022 14:13:36 +0000
Received: by outflank-mailman (input) for mailman id 309289;
 Wed, 20 Apr 2022 14:13:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhB5K-0001HT-AK
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:13:34 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e9d7115-c0b4-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 16:13:31 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e9d7115-c0b4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650464011;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ZZ4LFIyXhFA4quq56SEIYd7bIBzBk+g+i6q0EnuhZrs=;
  b=OUigjGYv7JPs0u8TPgMHaQIFwxBINxWk/03gyY7LNJLGpXNqsCbVVwbN
   cyb1QzdMyZfi73UGX9Hjq0l3F6SiTH0VSDnpFcW8g8LYBXYtSI2TlIMb5
   Wn59qCpb3PdwUPzvAPMVu4CkVm9/cX6syKU/ul88W2K3AJgu66y20nwMu
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69517262
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vjG0caOr2XIUO7/vrR2vl8FynXyQoLVcMsEvi/4bfWQNrUp2hGECz
 mQdDT2AP/eOZTGnKY9yaI3g8UNQvJ/UzoNgTwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NYw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z8
 e4RqI6LbzwVZaTDnfslYhpfDQBhBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTKuHO
 JBHM1KDajycPCIQFHQoJKkuhb3rvkPALT5Vgnas8P9fD2/7k1UqjemF3MDuUv6gSNhRn02Yj
 nnb5Gm/CRYfXPSAzRKV/3TqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A
 0YT8CA/66Up9EimS9D7dxK9qX+A+BUbXrJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEefAd2y
 02yuejVXjVgtaKteHGa6JaLlGbnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn
 W3TxMQqr/BK1JNQif3nlbzSq2j0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU
 ZVtpiR/0AzsJczV/MBuaL9UdF1M2xpiGGeC6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNYSP2NfUrPN3rW5hCIU3c+TLND6G8gj1mOMYZSeN61Hs2OR74M57FzCDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7WuPEE6MOc7cDg3EJTMLcmv9ZcGJ7LZf1IO9aNII6a5/I7NsrdNx8x9/tokN
 FnmMqOE4DITXUH6FDg=
IronPort-HdrOrdr: A9a23:SYfyb6HUtKQryQkdpLqE0seALOsnbusQ8zAXP0AYc31om6uj5r
 iTdZUgpGbJYVkqKRIdcLy7V5VoBEmskaKdgrNhW4tKPjOW2ldARbsKheCJrlHd8m/Fh4lgPM
 9bAtND4bbLbWSS4/yV3ODBKadE/OW6
X-IronPort-AV: E=Sophos;i="5.90,275,1643691600"; 
   d="scan'208";a="69517262"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Bobby Eshleman <bobby.eshleman@gmail.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c
Date: Wed, 20 Apr 2022 15:13:03 +0100
Message-ID: <20220420141307.24153-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220420141307.24153-1-andrew.cooper3@citrix.com>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

From: Bobby Eshleman <bobby.eshleman@gmail.com>

debug.c contains only dbg_rw_mem().  Rename it to gdbsx.c.

Move gdbsx_guest_mem_io(), and the prior setup of iop->remain, from domctl.c
to gdbsx.c, merging it with dbg_rw_mem().

Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v5:
 * Consolidate hunks from multiple v4 patches
 * Rewrite commit message

The semantics are rather broken.  XEN_DOMCTL_gdbsx_guestmemio only sets
copyback when there's nothing to copy back, and skips copying back in the
-EFAULT case when the iop->remain field is relevant.  Furthermore, it can be
asked to move up to 4GB in one go, with no continuability whatsoever.
---
 xen/arch/x86/Makefile               |  2 +-
 xen/arch/x86/domctl.c               | 14 ++------------
 xen/arch/x86/{debug.c => gdbsx.c}   | 23 ++++++++++-------------
 xen/arch/x86/include/asm/debugger.h |  6 ------
 xen/arch/x86/include/asm/gdbsx.h    | 13 +++++++++++++
 5 files changed, 26 insertions(+), 32 deletions(-)
 rename xen/arch/x86/{debug.c => gdbsx.c} (89%)
 create mode 100644 xen/arch/x86/include/asm/gdbsx.h

diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index 717bcbcac7a0..177a2ff74272 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -22,7 +22,6 @@ obj-y += cpuid.o
 obj-$(CONFIG_PV) += compat.o
 obj-$(CONFIG_PV32) += x86_64/compat.o
 obj-$(CONFIG_KEXEC) += crash.o
-obj-$(CONFIG_GDBSX) += debug.o
 obj-y += delay.o
 obj-y += desc.o
 obj-bin-y += dmi_scan.init.o
@@ -34,6 +33,7 @@ obj-y += emul-i8254.o
 obj-y += extable.o
 obj-y += flushtlb.o
 obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o
+obj-$(CONFIG_GDBSX) += gdbsx.o
 obj-y += hypercall.o
 obj-y += i387.o
 obj-y += i8259.o
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index a6aae500a30b..c20ab4352715 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -20,6 +20,8 @@
 #include <xen/console.h>
 #include <xen/iocap.h>
 #include <xen/paging.h>
+
+#include <asm/gdbsx.h>
 #include <asm/irq.h>
 #include <asm/hvm/emulate.h>
 #include <asm/hvm/hvm.h>
@@ -33,20 +35,9 @@
 #include <public/vm_event.h>
 #include <asm/mem_sharing.h>
 #include <asm/xstate.h>
-#include <asm/debugger.h>
 #include <asm/psr.h>
 #include <asm/cpuid.h>
 
-#ifdef CONFIG_GDBSX
-static int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop)
-{
-    iop->remain = dbg_rw_mem(iop->gva, guest_handle_from_ptr(iop->uva, void),
-                             iop->len, d, iop->gwr, iop->pgd3val);
-
-    return iop->remain ? -EFAULT : 0;
-}
-#endif
-
 static int update_domain_cpu_policy(struct domain *d,
                                     xen_domctl_cpu_policy_t *xdpc)
 {
@@ -827,7 +818,6 @@ long arch_do_domctl(
 
 #ifdef CONFIG_GDBSX
     case XEN_DOMCTL_gdbsx_guestmemio:
-        domctl->u.gdbsx_guest_memio.remain = domctl->u.gdbsx_guest_memio.len;
         ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
         if ( !ret )
            copyback = true;
diff --git a/xen/arch/x86/debug.c b/xen/arch/x86/gdbsx.c
similarity index 89%
rename from xen/arch/x86/debug.c
rename to xen/arch/x86/gdbsx.c
index 91034a852e5f..59eb31fc9a6a 100644
--- a/xen/arch/x86/debug.c
+++ b/xen/arch/x86/gdbsx.c
@@ -18,7 +18,7 @@
 #include <xen/mm.h>
 #include <xen/domain_page.h>
 #include <xen/guest_access.h>
-#include <asm/debugger.h>
+#include <asm/gdbsx.h>
 #include <asm/p2m.h>
 
 typedef unsigned long dbgva_t;
@@ -150,21 +150,18 @@ static unsigned int dbg_rw_guest_mem(struct domain *dp, unsigned long addr,
     return len;
 }
 
-/*
- * addr is guest addr
- * buf is debugger buffer.
- * if toaddr, then addr = buf (write to addr), else buf = addr (rd from guest)
- * pgd3: value of init_mm.pgd[3] in guest. see above.
- * Returns: number of bytes remaining to be copied.
- */
-unsigned int dbg_rw_mem(unsigned long gva, XEN_GUEST_HANDLE_PARAM(void) buf,
-                        unsigned int len, struct domain *d, bool toaddr,
-                        uint64_t pgd3)
+int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop)
 {
     if ( d && !d->is_dying )
-        len = dbg_rw_guest_mem(d, gva, buf, len, toaddr, pgd3);
+    {
+        iop->remain = dbg_rw_guest_mem(
+            d, iop->gva, guest_handle_from_ptr(iop->uva, void),
+            iop->len, iop->gwr, iop->pgd3val);
+    }
+    else
+        iop->remain = iop->len;
 
-    return len;
+    return iop->remain ? -EFAULT : 0;
 }
 
 /*
diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/arch/x86/include/asm/debugger.h
index e83b346a21d1..c5585752cae7 100644
--- a/xen/arch/x86/include/asm/debugger.h
+++ b/xen/arch/x86/include/asm/debugger.h
@@ -54,10 +54,4 @@ static inline bool debugger_trap_fatal(
 
 #endif
 
-#ifdef CONFIG_GDBSX
-unsigned int dbg_rw_mem(unsigned long gva, XEN_GUEST_HANDLE_PARAM(void) buf,
-                        unsigned int len, struct domain *d, bool toaddr,
-                        uint64_t pgd3);
-#endif
-
 #endif /* __X86_DEBUGGER_H__ */
diff --git a/xen/arch/x86/include/asm/gdbsx.h b/xen/arch/x86/include/asm/gdbsx.h
new file mode 100644
index 000000000000..eee746fc01d0
--- /dev/null
+++ b/xen/arch/x86/include/asm/gdbsx.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __X86_GDBX_H__
+#define __X86_GDBX_H__
+
+#ifdef CONFIG_GDBSX
+
+struct domain;
+struct xen_domctl_gdbsx_memio;
+
+int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop);
+
+#endif /* CONFIG_GDBSX */
+#endif /* __X86_GDBX_H__ */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:32:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:32:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309328.525454 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBNr-0007b7-4l; Wed, 20 Apr 2022 14:32:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309328.525454; Wed, 20 Apr 2022 14:32:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBNr-0007b0-1V; Wed, 20 Apr 2022 14:32:43 +0000
Received: by outflank-mailman (input) for mailman id 309328;
 Wed, 20 Apr 2022 14:32:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhBNp-0007aq-8i; Wed, 20 Apr 2022 14:32:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhBNp-0001A3-5h; Wed, 20 Apr 2022 14:32:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhBNo-0007IV-Ls; Wed, 20 Apr 2022 14:32:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhBNo-0007Hs-LN; Wed, 20 Apr 2022 14:32:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bgsrUePBa3OOsxjvxp43gSpgHMzLN7MaUoKfhesc4BU=; b=J4JBHmenITK27SXTkQkGSn8vJq
	B721FWihBcGGw9QztFslkUBtHNUfB6jXPWzeMoSNzPEmtg1yp5wJ0m11eZSlQcwb5WMTu3xSqBdXD
	WN7ghXk3SzZbAd/43a283edcDOW7feDnfh0qZEgaXBpxyR5uDZ2Sv2dfTqhnyo+MhL/U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169568-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169568: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=532bd4ec384b8e5764d97a62e5bd01fdbae6bd7a
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 14:32:40 +0000

flight 169568 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169568/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 532bd4ec384b8e5764d97a62e5bd01fdbae6bd7a
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  521 attempts
Testing same since   169568  2022-04-20 11:10:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5504 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 14:58:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 14:58:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309338.525471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBmQ-0001yC-AG; Wed, 20 Apr 2022 14:58:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309338.525471; Wed, 20 Apr 2022 14:58:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBmQ-0001y5-76; Wed, 20 Apr 2022 14:58:06 +0000
Received: by outflank-mailman (input) for mailman id 309338;
 Wed, 20 Apr 2022 14:58:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=k8Fu=U6=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nhBmP-0001xz-1h
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 14:58:05 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20630.outbound.protection.outlook.com
 [2a01:111:f400:7d00::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 471318b6-c0ba-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 16:58:03 +0200 (CEST)
Received: from DB7PR05CA0040.eurprd05.prod.outlook.com (2603:10a6:10:2e::17)
 by AM6PR08MB3269.eurprd08.prod.outlook.com (2603:10a6:209:49::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 14:58:01 +0000
Received: from DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2e:cafe::c) by DB7PR05CA0040.outlook.office365.com
 (2603:10a6:10:2e::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Wed, 20 Apr 2022 14:58:01 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT051.mail.protection.outlook.com (10.152.21.19) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Wed, 20 Apr 2022 14:58:01 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Wed, 20 Apr 2022 14:58:00 +0000
Received: from 157407c4dda6.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 02295FC8-35B6-4310-9C0C-24550698381E.1; 
 Wed, 20 Apr 2022 14:57:54 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 157407c4dda6.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Apr 2022 14:57:54 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12)
 by AM6PR08MB4263.eurprd08.prod.outlook.com (2603:10a6:20b:b7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 14:57:53 +0000
Received: from AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com
 ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5186.013; Wed, 20 Apr 2022
 14:57:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 471318b6-c0ba-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qcSxRGKWIyXVsTcm+6OyqMKTxR49DC5OvdmGcWW3kc4=;
 b=has0C6gOtTMyopAVBjrgOEniItyfG+sl8Tyekf08Sqkg5neZQEjcNWX9Mspgk9vEyXLds0sX8Px4Q6bZ2SNIMEbJKcP0RT2MG/45LV/XwjjPp0Ly8XaLKpaMJCuIUJ8woCqYtSdjW8q3UrAWvohSULixNLDELAfPl8pxQkEPyvc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f8c0a3221b450856
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bOa/VGOJWx0PPwZCJJXESkOSnpXn0ytqpCCO8SwyuipQofZKuNvLTikdLIQya/4MzedZAjfkHSIfrK7xxcDbd3vfBzpf6qU0bJnytD1HuVgWKg+4TrmHuO3LXFIrtwCFcD8NeEjjCnsFFpDJ9bL36TNDShJoQyhq0T2SL9QhgwNHelht4dTi5cck6xHQ9+HXTolDyFclXZ7P2GTsqvW/aWpcEx0Ulb4Oz6ImHG8ji2BSKx7pqr3tpTLCW0iif9Bq71MJ332cNVzHyEZ3zZX/PPUfhUSjhLlcQSgsL41eKKEzz2ewMpfiCaenD0ppCAwnpbWsKCoSZJPAfTHgkU+wIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qcSxRGKWIyXVsTcm+6OyqMKTxR49DC5OvdmGcWW3kc4=;
 b=dNKuSQYFEl/9kf2z4QMNZ7GgsR+jiAwQIZWhAj2hJApwCFSKAlXyCxDUS7gHbQBP9U5ULr8qIZx49n98ncyJCKgTkAOtQl7bbsNAa4zkCFVg08fnvTgVHFPaYNbOcxrrDSm0E5xRqXBk/gyklqCqDFXcaqT7Bm0IUDmW5yup/hPSlyfEoxnSPLGIsDengTnykEUuKsL2QchwRkDEtlBOt1n2Fq5FYGeJZ9KfX9y218CM/DTldWPFZol+h7iNgRM4Hf/AXcjtwrGQnazvKwjPZxxhHOkG5+4xWiPx1J2s69khzlwEJ5feSLclTSq+9n8PQZzCTTkWisZhmxRwlVDJmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qcSxRGKWIyXVsTcm+6OyqMKTxR49DC5OvdmGcWW3kc4=;
 b=has0C6gOtTMyopAVBjrgOEniItyfG+sl8Tyekf08Sqkg5neZQEjcNWX9Mspgk9vEyXLds0sX8Px4Q6bZ2SNIMEbJKcP0RT2MG/45LV/XwjjPp0Ly8XaLKpaMJCuIUJ8woCqYtSdjW8q3UrAWvohSULixNLDELAfPl8pxQkEPyvc=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Xen developer discussion <xen-devel@lists.xenproject.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Juergen Gross <jgross@suse.com>, Dario Faggioli <dfaggioli@suse.com>, George
 Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH v7 5/7] xen/cpupool: Don't allow removing cpu0 from
 cpupool0
Thread-Topic: [PATCH v7 5/7] xen/cpupool: Don't allow removing cpu0 from
 cpupool0
Thread-Index: AQHYTbfhTkT1+2FTCUa/iQjDpfI7J6z48pQA
Date: Wed, 20 Apr 2022 14:57:52 +0000
Message-ID: <214318DB-3359-4525-870F-0293EDDC32A6@arm.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-6-luca.fancellu@arm.com>
In-Reply-To: <20220411152101.17539-6-luca.fancellu@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 94c9fcc2-a573-43b6-953d-08da22de2a13
x-ms-traffictypediagnostic:
	AM6PR08MB4263:EE_|DB5EUR03FT051:EE_|AM6PR08MB3269:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB32691D0C4FA5D5C5F5D9CC90E4F59@AM6PR08MB3269.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 U3FS4kt8lna7YcISOHJ3WeJ30mbeuVPBbpQ3OFygfTK2tw5DWTr8AjchphBxTazlDg1Ay+54zra/x3/68abOJzOaVoGj/aRLM8a26QIPj6VDbA5uLwuuYyNp24u3ELFMgtYOQPcQJT15Fm7RKNglVh+65Z62iMp8PvIJcZronMy7mbZuinVK4p5YtwBavPicQy/TFl2/MsxV5ItCLuJveOUlkgydoIpj+4vVw1523rnoE0qo0ma9WessxC0/EnAXJHP+9HbjGi5sH/Pc2j5bqVrich946qZnnmeeuIhyVuVdyHxE2KTYDN23n+Gg2tKE/bG/741pG325W37V/x5jRBHIfgqU8b9jtiKYDc3pxId9l9VzsUSx02PFn6+l3OcTqho6OAvzIt0eg3YgO9D4fBsd5av/R4Y95ayMd+yKNITKMN3tH30lPkp5O6VlfkKuEMrcb5ClwIiqvSNNxk/GJa5gq7VMi6rASwY/PvS+joEHAf7z+RTicSO+zNMIJDaphw8kQvlYRcfpOH7rh/di3gAbRt1B1dMtL+AuA876O/gNcEyBci7MshYSzUjbd/RkIu+rglCQyq4AFVRXEu93cdqRakafFLkYKgRQAwEH1lRLjLbLzXKbUS6C20968w83SpQ5sFyWUoZKaMx/ssU5mvrTkCOB6JLWdondS/lUIUtJK6ThXWGHtSfId0/L+chpUwRjUnK7p+IHvmXXL0PKnPmtO3quRmqKgXG4PYIRXGZIVGo+wbk6zj3eVWJgC4cN
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(71200400001)(66556008)(36756003)(26005)(186003)(4326008)(6916009)(8936002)(86362001)(2616005)(5660300002)(66476007)(66946007)(91956017)(76116006)(122000001)(6512007)(6486002)(33656002)(54906003)(83380400001)(316002)(508600001)(6506007)(38100700002)(38070700005)(66446008)(2906002)(64756008)(53546011)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <E6F06DBBFDA8D54D858790974C670B7F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4263
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ff9bfc22-3846-48c4-89f2-08da22de2545
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hySsSHn3zaV669ITTMpWiVsFYK2H+yZ5xEwWntMS0l4INVinwDCtlWhIXSNJT//XlF1xPTZJqSVTJ2sa4vgpBNjNEGq5fjnraLQRnpFjCWTe+BPYQpSuOJBtYAjiEXz9WlWj3OoyCtbn5eTtgsg/vA/7V+cCIEUOhrCBUOxtnUU3m8y7ECU/6RlvJyyrNJo3SxY1VfvEovEXF/Zj572TNTW4pFIJPS7xmyNUuTLzGaugys5/SjmSF5ZnHuJ6wYqDf1Gl206ljoVrTxM5jA2vGs6T8kC4ONDNei4V/ZW5KkxiRI2GTWz8e1g/4cPeutjEwermNwY5A9u2gVZD0i7S6uSjV28O4WTc2g80zGNlPoag1O0wPcHu7oE8vXFxL4zHsaPaolfAa8CdsEF1gmbWf+d6bwV8eQl4Ksc3XaO3oO6EsVaKO4fiB1RY6iSrvtORBQM0+J5RpXxdmyzRXVdjgM7OO9Bcrx06U8Mev2O5us1UdY7OtKTXhy1wd+umDnwH90FttXnltzQheMqILGlNbZlno8F68sZ7WDDWFTsAByn9n2/XWn7b5hEx7FSBNmqCHp+KvzMqhVHxMI4oXHqhKe614J0BKpf2iKB571ZtIexWQY63ChbySbc6DxJ6ll/iNv5YwjWfCALiuhnRL54+mt5jtweJWhu8z7TWjQD4PFdsNqERAn5b3xMLjR+96Cl5
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(6512007)(86362001)(36756003)(186003)(81166007)(40460700003)(316002)(6486002)(107886003)(26005)(36860700001)(6506007)(2906002)(336012)(8676002)(6916009)(4326008)(508600001)(53546011)(8936002)(356005)(5660300002)(33656002)(82310400005)(83380400001)(47076005)(2616005)(54906003)(70206006)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 14:58:01.0357
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 94c9fcc2-a573-43b6-953d-08da22de2a13
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3269

DQoNCj4gT24gMTEgQXByIDIwMjIsIGF0IDE2OjIwLCBMdWNhIEZhbmNlbGx1IDxMdWNhLkZhbmNl
bGx1QGFybS5jb20+IHdyb3RlOg0KPiANCj4gQ3B1MCBtdXN0IHJlbWFpbiBpbiBjcHVwb29sMCwg
b3RoZXJ3aXNlIHNvbWUgb3BlcmF0aW9ucyBsaWtlIG1vdmluZyBjcHVzDQo+IGJldHdlZW4gY3B1
cG9vbHMsIGNwdSBob3RwbHVnLCBkZXN0cm95aW5nIGNwdXBvb2xzLCBzaHV0ZG93biBvZiB0aGUg
aG9zdCwNCj4gbWlnaHQgbm90IHdvcmsgaW4gYSBzYW5lIHdheS4NCj4gDQo+IFNpZ25lZC1vZmYt
Ynk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4gLS0tDQo+IENoYW5n
ZXMgaW4gdjc6DQo+IC0gbmV3IHBhdGNoDQo+IC0tLQ0KPiB4ZW4vY29tbW9uL3NjaGVkL2NwdXBv
b2wuYyB8IDggKysrKysrKy0NCj4gMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBk
ZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5j
IGIveGVuL2NvbW1vbi9zY2hlZC9jcHVwb29sLmMNCj4gaW5kZXggODZhMTc1Zjk5Y2Q1Li4wYTkz
YmNjNjMxYmYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5jDQo+ICsr
KyBiL3hlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5jDQo+IEBAIC01NzIsNiArNTcyLDcgQEAgc3Rh
dGljIGxvbmcgY2ZfY2hlY2sgY3B1cG9vbF91bmFzc2lnbl9jcHVfaGVscGVyKHZvaWQgKmluZm8p
DQo+ICAqIHBvc3NpYmxlIGZhaWx1cmVzOg0KPiAgKiAtIGxhc3QgY3B1IGFuZCBzdGlsbCBhY3Rp
dmUgZG9tYWlucyBpbiBjcHVwb29sDQo+ICAqIC0gY3B1IGp1c3QgYmVpbmcgdW5wbHVnZ2VkDQo+
ICsgKiAtIEF0dGVtcHQgdG8gcmVtb3ZlIGJvb3QgY3B1IGZyb20gY3B1cG9vbDANCj4gICovDQo+
IHN0YXRpYyBpbnQgY3B1cG9vbF91bmFzc2lnbl9jcHUoc3RydWN0IGNwdXBvb2wgKmMsIHVuc2ln
bmVkIGludCBjcHUpDQo+IHsNCj4gQEAgLTU4Miw3ICs1ODMsMTIgQEAgc3RhdGljIGludCBjcHVw
b29sX3VuYXNzaWduX2NwdShzdHJ1Y3QgY3B1cG9vbCAqYywgdW5zaWduZWQgaW50IGNwdSkNCj4g
ICAgIGRlYnVndHJhY2VfcHJpbnRrKCJjcHVwb29sX3VuYXNzaWduX2NwdShwb29sPSV1LGNwdT0l
ZClcbiIsDQo+ICAgICAgICAgICAgICAgICAgICAgICBjLT5jcHVwb29sX2lkLCBjcHUpOw0KPiAN
Cj4gLSAgICBpZiAoICFjcHVfb25saW5lKGNwdSkgKQ0KPiArICAgIC8qDQo+ICsgICAgICogQ3B1
MCBtdXN0IHJlbWFpbiBpbiBjcHVwb29sMCwgb3RoZXJ3aXNlIHNvbWUgb3BlcmF0aW9ucyBsaWtl
IG1vdmluZyBjcHVzDQo+ICsgICAgICogYmV0d2VlbiBjcHVwb29scywgY3B1IGhvdHBsdWcsIGRl
c3Ryb3lpbmcgY3B1cG9vbHMsIHNodXRkb3duIG9mIHRoZSBob3N0LA0KPiArICAgICAqIG1pZ2h0
IG5vdCB3b3JrIGluIGEgc2FuZSB3YXkuDQo+ICsgICAgICovDQo+ICsgICAgaWYgKCAoIWMtPmNw
dXBvb2xfaWQgJiYgIWNwdSkgfHwgIWNwdV9vbmxpbmUoY3B1KSApDQo+ICAgICAgICAgcmV0dXJu
IC1FSU5WQUw7DQo+IA0KPiAgICAgbWFzdGVyX2NwdSA9IHNjaGVkX2dldF9yZXNvdXJjZV9jcHUo
Y3B1KTsNCj4gLS0gDQo+IDIuMTcuMQ0KPiANCg0KSGksDQoNCknigJltIGdvaW5nIHRvIGFkZHJl
c3MgdGhlIGNvbW1lbnQgb24gdGhpcyBzZXJpZSBiZWZvcmUgcmUtcHVzaGluZyBpdCwgSSBzZWUg
dGhlcmUNCmFyZSBubyBjb21tZW50cyBvbiB0aGlzIHBhdGNoLCBzbyBJ4oCZbSB3b25kZXJpbmcs
IHdoZW4geW91IGhhdmUgdGltZSwgaWYgeW91DQpjYW4gZ2l2ZSBtZSBzb21lIGZlZWRiYWNrIG9u
IHRoaXMgb25lLg0KDQpDaGVlcnMsDQpMdWNh


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309352.525533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy0-0004rc-ND; Wed, 20 Apr 2022 15:10:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309352.525533; Wed, 20 Apr 2022 15:10:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy0-0004pv-Dn; Wed, 20 Apr 2022 15:10:04 +0000
Received: by outflank-mailman (input) for mailman id 309352;
 Wed, 20 Apr 2022 15:10:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxy-0003l9-6f
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:02 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f21b4112-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:09:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6714C2112B;
 Wed, 20 Apr 2022 15:09:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E37713AD5;
 Wed, 20 Apr 2022 15:09:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id SGcBDkciYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:09:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f21b4112-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=P9m9SWnGsWjRx9ANR0XSy+QMtPG0e3QupiRUzE89rSY=;
	b=FqRfpSvFwPYNTbSEb+BczfXaG/PTZ/jawRTYZIcGfRVWCFx/hIuhAVbgCyF6TW7nx10JYF
	FhE/gNjXdum/2VeRLcck0wNBZhBe41TwRXa/Uxr/OaE4aGv16cRpLtTDb3XaaCaQsxUm2+
	ubqyrMN6DY0Ttw/z5+7IZWwzUAbuaTo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 04/18] xen/usb: switch xen-hcd to use INVALID_GRANT_REF
Date: Wed, 20 Apr 2022 17:09:28 +0200
Message-Id: <20220420150942.31235-5-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/usb/host/xen-hcd.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c
index 3e487baf8422..9cbc7c2dab02 100644
--- a/drivers/usb/host/xen-hcd.c
+++ b/drivers/usb/host/xen-hcd.c
@@ -87,8 +87,6 @@ struct xenhcd_info {
 	bool error;
 };
 
-#define GRANT_INVALID_REF 0
-
 #define XENHCD_RING_JIFFIES (HZ/200)
 #define XENHCD_SCAN_JIFFIES 1
 
@@ -1100,17 +1098,17 @@ static void xenhcd_destroy_rings(struct xenhcd_info *info)
 		unbind_from_irqhandler(info->irq, info);
 	info->irq = 0;
 
-	if (info->urb_ring_ref != GRANT_INVALID_REF) {
+	if (info->urb_ring_ref != INVALID_GRANT_REF) {
 		gnttab_end_foreign_access(info->urb_ring_ref,
 					  (unsigned long)info->urb_ring.sring);
-		info->urb_ring_ref = GRANT_INVALID_REF;
+		info->urb_ring_ref = INVALID_GRANT_REF;
 	}
 	info->urb_ring.sring = NULL;
 
-	if (info->conn_ring_ref != GRANT_INVALID_REF) {
+	if (info->conn_ring_ref != INVALID_GRANT_REF) {
 		gnttab_end_foreign_access(info->conn_ring_ref,
 					  (unsigned long)info->conn_ring.sring);
-		info->conn_ring_ref = GRANT_INVALID_REF;
+		info->conn_ring_ref = INVALID_GRANT_REF;
 	}
 	info->conn_ring.sring = NULL;
 }
@@ -1123,8 +1121,8 @@ static int xenhcd_setup_rings(struct xenbus_device *dev,
 	grant_ref_t gref;
 	int err;
 
-	info->urb_ring_ref = GRANT_INVALID_REF;
-	info->conn_ring_ref = GRANT_INVALID_REF;
+	info->urb_ring_ref = INVALID_GRANT_REF;
+	info->conn_ring_ref = INVALID_GRANT_REF;
 
 	urb_sring = (struct xenusb_urb_sring *)get_zeroed_page(
 							GFP_NOIO | __GFP_HIGH);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309348.525498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxx-00043c-Rq; Wed, 20 Apr 2022 15:10:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309348.525498; Wed, 20 Apr 2022 15:10:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxx-000434-O6; Wed, 20 Apr 2022 15:10:01 +0000
Received: by outflank-mailman (input) for mailman id 309348;
 Wed, 20 Apr 2022 15:10:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxw-0003l9-EK
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:00 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1d218da-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:09:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E2C341F380;
 Wed, 20 Apr 2022 15:09:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A1E0513AD5;
 Wed, 20 Apr 2022 15:09:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uItUJkYiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:09:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1d218da-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1+sLUcbyL72u2uT21oB5tsWX/EFozEKqCEXKzXzCiFA=;
	b=RLridzMgQycyuagIizn5XaAT4I+nxk2qHqd10tZfXxzpJqLqtrA1gDkHD182fZNaso9mSe
	M9IT/uHa81ObORL8HehqC09E8nBntt7MTyqLHZ9M417SVAZWN+02SKS/YxV7x5VfpqEzCX
	9ftMZq85+XPw0YvTrEoKDbTzpI9EF3E=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH 02/18] xen/netfront: switch netfront to use INVALID_GRANT_REF
Date: Wed, 20 Apr 2022 17:09:26 +0200
Message-Id: <20220420150942.31235-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/net/xen-netfront.c | 36 +++++++++++++++++-------------------
 1 file changed, 17 insertions(+), 19 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index e2b4a1893a13..af3d3de7d9fa 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -78,8 +78,6 @@ struct netfront_cb {
 
 #define RX_COPY_THRESHOLD 256
 
-#define GRANT_INVALID_REF	0
-
 #define NET_TX_RING_SIZE __CONST_RING_SIZE(xen_netif_tx, XEN_PAGE_SIZE)
 #define NET_RX_RING_SIZE __CONST_RING_SIZE(xen_netif_rx, XEN_PAGE_SIZE)
 
@@ -224,7 +222,7 @@ static grant_ref_t xennet_get_rx_ref(struct netfront_queue *queue,
 {
 	int i = xennet_rxidx(ri);
 	grant_ref_t ref = queue->grant_rx_ref[i];
-	queue->grant_rx_ref[i] = GRANT_INVALID_REF;
+	queue->grant_rx_ref[i] = INVALID_GRANT_REF;
 	return ref;
 }
 
@@ -432,7 +430,7 @@ static bool xennet_tx_buf_gc(struct netfront_queue *queue)
 			}
 			gnttab_release_grant_reference(
 				&queue->gref_tx_head, queue->grant_tx_ref[id]);
-			queue->grant_tx_ref[id] = GRANT_INVALID_REF;
+			queue->grant_tx_ref[id] = INVALID_GRANT_REF;
 			queue->grant_tx_page[id] = NULL;
 			add_id_to_list(&queue->tx_skb_freelist, queue->tx_link, id);
 			dev_kfree_skb_irq(skb);
@@ -1021,7 +1019,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
 		 * the backend driver. In future this should flag the bad
 		 * situation to the system controller to reboot the backend.
 		 */
-		if (ref == GRANT_INVALID_REF) {
+		if (ref == INVALID_GRANT_REF) {
 			if (net_ratelimit())
 				dev_warn(dev, "Bad rx response id %d.\n",
 					 rx->id);
@@ -1390,7 +1388,7 @@ static void xennet_release_tx_bufs(struct netfront_queue *queue)
 		gnttab_end_foreign_access(queue->grant_tx_ref[i],
 					  (unsigned long)page_address(queue->grant_tx_page[i]));
 		queue->grant_tx_page[i] = NULL;
-		queue->grant_tx_ref[i] = GRANT_INVALID_REF;
+		queue->grant_tx_ref[i] = INVALID_GRANT_REF;
 		add_id_to_list(&queue->tx_skb_freelist, queue->tx_link, i);
 		dev_kfree_skb_irq(skb);
 	}
@@ -1411,7 +1409,7 @@ static void xennet_release_rx_bufs(struct netfront_queue *queue)
 			continue;
 
 		ref = queue->grant_rx_ref[id];
-		if (ref == GRANT_INVALID_REF)
+		if (ref == INVALID_GRANT_REF)
 			continue;
 
 		page = skb_frag_page(&skb_shinfo(skb)->frags[0]);
@@ -1422,7 +1420,7 @@ static void xennet_release_rx_bufs(struct netfront_queue *queue)
 		get_page(page);
 		gnttab_end_foreign_access(ref,
 					  (unsigned long)page_address(page));
-		queue->grant_rx_ref[id] = GRANT_INVALID_REF;
+		queue->grant_rx_ref[id] = INVALID_GRANT_REF;
 
 		kfree_skb(skb);
 	}
@@ -1761,7 +1759,7 @@ static int netfront_probe(struct xenbus_device *dev,
 static void xennet_end_access(int ref, void *page)
 {
 	/* This frees the page as a side-effect */
-	if (ref != GRANT_INVALID_REF)
+	if (ref != INVALID_GRANT_REF)
 		gnttab_end_foreign_access(ref, (unsigned long)page);
 }
 
@@ -1798,8 +1796,8 @@ static void xennet_disconnect_backend(struct netfront_info *info)
 		xennet_end_access(queue->tx_ring_ref, queue->tx.sring);
 		xennet_end_access(queue->rx_ring_ref, queue->rx.sring);
 
-		queue->tx_ring_ref = GRANT_INVALID_REF;
-		queue->rx_ring_ref = GRANT_INVALID_REF;
+		queue->tx_ring_ref = INVALID_GRANT_REF;
+		queue->rx_ring_ref = INVALID_GRANT_REF;
 		queue->tx.sring = NULL;
 		queue->rx.sring = NULL;
 
@@ -1927,8 +1925,8 @@ static int setup_netfront(struct xenbus_device *dev,
 	grant_ref_t gref;
 	int err;
 
-	queue->tx_ring_ref = GRANT_INVALID_REF;
-	queue->rx_ring_ref = GRANT_INVALID_REF;
+	queue->tx_ring_ref = INVALID_GRANT_REF;
+	queue->rx_ring_ref = INVALID_GRANT_REF;
 	queue->rx.sring = NULL;
 	queue->tx.sring = NULL;
 
@@ -1978,17 +1976,17 @@ static int setup_netfront(struct xenbus_device *dev,
 	 * granted pages because backend is not accessing it at this point.
 	 */
  fail:
-	if (queue->rx_ring_ref != GRANT_INVALID_REF) {
+	if (queue->rx_ring_ref != INVALID_GRANT_REF) {
 		gnttab_end_foreign_access(queue->rx_ring_ref,
 					  (unsigned long)rxs);
-		queue->rx_ring_ref = GRANT_INVALID_REF;
+		queue->rx_ring_ref = INVALID_GRANT_REF;
 	} else {
 		free_page((unsigned long)rxs);
 	}
-	if (queue->tx_ring_ref != GRANT_INVALID_REF) {
+	if (queue->tx_ring_ref != INVALID_GRANT_REF) {
 		gnttab_end_foreign_access(queue->tx_ring_ref,
 					  (unsigned long)txs);
-		queue->tx_ring_ref = GRANT_INVALID_REF;
+		queue->tx_ring_ref = INVALID_GRANT_REF;
 	} else {
 		free_page((unsigned long)txs);
 	}
@@ -2020,7 +2018,7 @@ static int xennet_init_queue(struct netfront_queue *queue)
 	queue->tx_pend_queue = TX_LINK_NONE;
 	for (i = 0; i < NET_TX_RING_SIZE; i++) {
 		queue->tx_link[i] = i + 1;
-		queue->grant_tx_ref[i] = GRANT_INVALID_REF;
+		queue->grant_tx_ref[i] = INVALID_GRANT_REF;
 		queue->grant_tx_page[i] = NULL;
 	}
 	queue->tx_link[NET_TX_RING_SIZE - 1] = TX_LINK_NONE;
@@ -2028,7 +2026,7 @@ static int xennet_init_queue(struct netfront_queue *queue)
 	/* Clear out rx_skbs */
 	for (i = 0; i < NET_RX_RING_SIZE; i++) {
 		queue->rx_skbs[i] = NULL;
-		queue->grant_rx_ref[i] = GRANT_INVALID_REF;
+		queue->grant_rx_ref[i] = INVALID_GRANT_REF;
 	}
 
 	/* A grant for every tx ring slot */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309347.525487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxw-0003lM-JS; Wed, 20 Apr 2022 15:10:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309347.525487; Wed, 20 Apr 2022 15:10:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxw-0003lF-GD; Wed, 20 Apr 2022 15:10:00 +0000
Received: by outflank-mailman (input) for mailman id 309347;
 Wed, 20 Apr 2022 15:09:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxv-0003l4-Tg
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:09:59 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f191d712-c0bb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:09:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5B4A1210E4;
 Wed, 20 Apr 2022 15:09:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 96AE513AD5;
 Wed, 20 Apr 2022 15:09:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id QAKAI0UiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:09:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f191d712-c0bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=E9Za1fy7SJZVuU3gsJHYcUnfUQspR3rknfU8bXQql9Y=;
	b=s7o4aJsXllglxjEicM+le/pE5Q4+nZsQh1+qkc+l1wMXB8I5KM8EXHpK9vVJQBopp4olwE
	/0eL2tvJFzr8/5F+QMy5ysfmCp4A5ramqeRsMJKSZCtFDWgeFHKh6l0oEFDWWCNJk0EhzP
	yXIHNy0QuiJkmeTPgRibcNpvjDS2yuo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-integrity@vger.kernel.org,
	linux-pci@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org,
	Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 00/18] xen: simplify frontend side ring setup
Date: Wed, 20 Apr 2022 17:09:24 +0200
Message-Id: <20220420150942.31235-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Many Xen PV frontends share similar code for setting up a ring page
(allocating and granting access for the backend) and for tearing it
down.

Create new service functions doing all needed steps in one go.

This requires all frontends to use a common value for an invalid
grant reference in order to make the functions idempotent.

Juergen Gross (18):
  xen/blkfront: switch blkfront to use INVALID_GRANT_REF
  xen/netfront: switch netfront to use INVALID_GRANT_REF
  xen/scsifront: remove unused GRANT_INVALID_REF definition
  xen/usb: switch xen-hcd to use INVALID_GRANT_REF
  xen/drm: switch xen_drm_front to use INVALID_GRANT_REF
  xen/sound: switch xen_snd_front to use INVALID_GRANT_REF
  xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF
  xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF
  xen/xenbus: add xenbus_setup_ring() service function
  xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/xenbus: eliminate xenbus_grant_ring()

 drivers/block/xen-blkfront.c                | 54 ++++----------
 drivers/char/tpm/xen-tpmfront.c             | 18 +----
 drivers/gpu/drm/xen/xen_drm_front.h         |  9 ---
 drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 40 +++-------
 drivers/net/xen-netfront.c                  | 77 ++++++--------------
 drivers/pci/xen-pcifront.c                  | 19 +----
 drivers/scsi/xen-scsifront.c                | 30 ++------
 drivers/usb/host/xen-hcd.c                  | 59 ++++-----------
 drivers/xen/gntdev-dmabuf.c                 | 13 +---
 drivers/xen/xen-front-pgdir-shbuf.c         | 17 +----
 drivers/xen/xenbus/xenbus_client.c          | 81 ++++++++++++++++-----
 include/xen/xenbus.h                        |  4 +-
 sound/xen/xen_snd_front_evtchnl.c           | 41 +++--------
 sound/xen/xen_snd_front_evtchnl.h           |  9 ---
 14 files changed, 156 insertions(+), 315 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309351.525525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxz-0004cF-T2; Wed, 20 Apr 2022 15:10:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309351.525525; Wed, 20 Apr 2022 15:10:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxz-0004bN-KN; Wed, 20 Apr 2022 15:10:03 +0000
Received: by outflank-mailman (input) for mailman id 309351;
 Wed, 20 Apr 2022 15:10:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxx-0003l4-MO
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:01 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f247eda1-c0bb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:09:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A9A2B2129B;
 Wed, 20 Apr 2022 15:09:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6D87713AD5;
 Wed, 20 Apr 2022 15:09:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id MJhzGUciYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:09:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f247eda1-c0bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tOhV6YQDouFKSF4kDrscgmAnoCYSHdFmpTsct9Kqzek=;
	b=M2CSLl0VqnHJJC0YsOCEQojyDKPkmBs5veLj38AgGdJxabAIf7h7XElPNlT4+0mo0+eBOj
	zKrOb0vmHAlVaH4Nbwvy1oILNfIjzCnCLFr0PRRGVQhPpjPeLu24cZScK/vIUcyE6IHG/O
	MNv+w8hsIg/uI1+QirFTAqLXtACWMas=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: [PATCH 05/18] xen/drm: switch xen_drm_front to use INVALID_GRANT_REF
Date: Wed, 20 Apr 2022 17:09:29 +0200
Message-Id: <20220420150942.31235-6-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/gpu/drm/xen/xen_drm_front.h         | 9 ---------
 drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 4 ++--
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
index cefafe859aba..a987c78abe41 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.h
+++ b/drivers/gpu/drm/xen/xen_drm_front.h
@@ -80,15 +80,6 @@ struct drm_pending_vblank_event;
 /* timeout in ms to wait for backend to respond */
 #define XEN_DRM_FRONT_WAIT_BACK_MS	3000
 
-#ifndef GRANT_INVALID_REF
-/*
- * Note on usage of grant reference 0 as invalid grant reference:
- * grant reference 0 is valid, but never exposed to a PV driver,
- * because of the fact it is already in use/reserved by the PV console.
- */
-#define GRANT_INVALID_REF	0
-#endif
-
 struct xen_drm_front_info {
 	struct xenbus_device *xb_dev;
 	struct xen_drm_front_drm_info *drm_info;
diff --git a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
index 08b526eeec16..4006568b9e32 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
@@ -147,7 +147,7 @@ static void evtchnl_free(struct xen_drm_front_info *front_info,
 		xenbus_free_evtchn(front_info->xb_dev, evtchnl->port);
 
 	/* end access and free the page */
-	if (evtchnl->gref != GRANT_INVALID_REF)
+	if (evtchnl->gref != INVALID_GRANT_REF)
 		gnttab_end_foreign_access(evtchnl->gref, page);
 
 	memset(evtchnl, 0, sizeof(*evtchnl));
@@ -168,7 +168,7 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index,
 	evtchnl->index = index;
 	evtchnl->front_info = front_info;
 	evtchnl->state = EVTCHNL_STATE_DISCONNECTED;
-	evtchnl->gref = GRANT_INVALID_REF;
+	evtchnl->gref = INVALID_GRANT_REF;
 
 	page = get_zeroed_page(GFP_NOIO | __GFP_HIGH);
 	if (!page) {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309350.525520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxz-0004Z9-FR; Wed, 20 Apr 2022 15:10:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309350.525520; Wed, 20 Apr 2022 15:10:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxz-0004YL-8W; Wed, 20 Apr 2022 15:10:03 +0000
Received: by outflank-mailman (input) for mailman id 309350;
 Wed, 20 Apr 2022 15:10:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxx-0003l9-6T
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1fea23b-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:09:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 379941F747;
 Wed, 20 Apr 2022 15:09:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E8D5313AE0;
 Wed, 20 Apr 2022 15:09:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kBmNN0YiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:09:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1fea23b-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8WOMLJJL+8fDd8BjyKVyzFwvZFKiwjT3Bwvxi9ywj7Y=;
	b=CE/mkh1GUmE0SEPgpv7h3QUa2wELR2bW/esRvHI7txzKQA9wQsVKrOu+eAzgp/hLcYnX7E
	r6J7pCdMHUpedleoOia07CHwEuQG5UDphvqpVAQRRMVaPddqdZziFxg9iRwriLzvdhz9uZ
	SvY5Pd4iersIGuwjkFHkZ97a9UYSgi4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 03/18] xen/scsifront: remove unused GRANT_INVALID_REF definition
Date: Wed, 20 Apr 2022 17:09:27 +0200
Message-Id: <20220420150942.31235-4-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

GRANT_INVALID_REF isn't used in scsifront, so remove it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/scsi/xen-scsifront.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 761c9c463ecd..9db2366fa2d4 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -58,9 +58,6 @@
 
 #include <asm/xen/hypervisor.h>
 
-
-#define GRANT_INVALID_REF	0
-
 #define VSCSIFRONT_OP_ADD_LUN	1
 #define VSCSIFRONT_OP_DEL_LUN	2
 #define VSCSIFRONT_OP_READD_LUN	3
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309349.525504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxy-00046g-5v; Wed, 20 Apr 2022 15:10:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309349.525504; Wed, 20 Apr 2022 15:10:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBxy-00046K-0W; Wed, 20 Apr 2022 15:10:02 +0000
Received: by outflank-mailman (input) for mailman id 309349;
 Wed, 20 Apr 2022 15:10:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxw-0003l4-Ly
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:00 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f1ad0c12-c0bb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:09:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9C16421115;
 Wed, 20 Apr 2022 15:09:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6227213AE0;
 Wed, 20 Apr 2022 15:09:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id aMK0FkYiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:09:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1ad0c12-c0bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8T6Z7jV+2E1LG0Lx6kFTGECOTx+ZZjBB+fMJq4VZyPo=;
	b=WF4b9n87A3M7HYOr+N4ZjOY+Cgid8wI0c6irsUK8+pQROZTqJnInO/MAVODMUxLWX9V4V0
	Z+LcPet04JF89QS0wEomkfON2JmmAd36vHuHA/rqkTO0zUey1+1KZplpI+cvYdc6r6WSe9
	cji3xX1G6SjGEefquTF4b8p4MGSO6uo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 01/18] xen/blkfront: switch blkfront to use INVALID_GRANT_REF
Date: Wed, 20 Apr 2022 17:09:25 +0200
Message-Id: <20220420150942.31235-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/block/xen-blkfront.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 003056d4f7f5..7f35e30e626a 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -229,8 +229,6 @@ static unsigned int nr_minors;
 static unsigned long *minors;
 static DEFINE_SPINLOCK(minor_lock);
 
-#define GRANT_INVALID_REF	0
-
 #define PARTS_PER_DISK		16
 #define PARTS_PER_EXT_DISK      256
 
@@ -321,7 +319,7 @@ static int fill_grant_buffer(struct blkfront_ring_info *rinfo, int num)
 			gnt_list_entry->page = granted_page;
 		}
 
-		gnt_list_entry->gref = GRANT_INVALID_REF;
+		gnt_list_entry->gref = INVALID_GRANT_REF;
 		list_add(&gnt_list_entry->node, &rinfo->grants);
 		i++;
 	}
@@ -350,7 +348,7 @@ static struct grant *get_free_grant(struct blkfront_ring_info *rinfo)
 					  node);
 	list_del(&gnt_list_entry->node);
 
-	if (gnt_list_entry->gref != GRANT_INVALID_REF)
+	if (gnt_list_entry->gref != INVALID_GRANT_REF)
 		rinfo->persistent_gnts_c--;
 
 	return gnt_list_entry;
@@ -372,7 +370,7 @@ static struct grant *get_grant(grant_ref_t *gref_head,
 	struct grant *gnt_list_entry = get_free_grant(rinfo);
 	struct blkfront_info *info = rinfo->dev_info;
 
-	if (gnt_list_entry->gref != GRANT_INVALID_REF)
+	if (gnt_list_entry->gref != INVALID_GRANT_REF)
 		return gnt_list_entry;
 
 	/* Assign a gref to this page */
@@ -396,7 +394,7 @@ static struct grant *get_indirect_grant(grant_ref_t *gref_head,
 	struct grant *gnt_list_entry = get_free_grant(rinfo);
 	struct blkfront_info *info = rinfo->dev_info;
 
-	if (gnt_list_entry->gref != GRANT_INVALID_REF)
+	if (gnt_list_entry->gref != INVALID_GRANT_REF)
 		return gnt_list_entry;
 
 	/* Assign a gref to this page */
@@ -1221,7 +1219,7 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
 		list_for_each_entry_safe(persistent_gnt, n,
 					 &rinfo->grants, node) {
 			list_del(&persistent_gnt->node);
-			if (persistent_gnt->gref != GRANT_INVALID_REF) {
+			if (persistent_gnt->gref != INVALID_GRANT_REF) {
 				gnttab_end_foreign_access(persistent_gnt->gref,
 							  0UL);
 				rinfo->persistent_gnts_c--;
@@ -1283,9 +1281,9 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
 
 	/* Free resources associated with old device channel. */
 	for (i = 0; i < info->nr_ring_pages; i++) {
-		if (rinfo->ring_ref[i] != GRANT_INVALID_REF) {
+		if (rinfo->ring_ref[i] != INVALID_GRANT_REF) {
 			gnttab_end_foreign_access(rinfo->ring_ref[i], 0);
-			rinfo->ring_ref[i] = GRANT_INVALID_REF;
+			rinfo->ring_ref[i] = INVALID_GRANT_REF;
 		}
 	}
 	free_pages_exact(rinfo->ring.sring,
@@ -1475,7 +1473,7 @@ static int blkif_completion(unsigned long *id,
 			 * to the tail of the list, so it will not be picked
 			 * again unless we run out of persistent grants.
 			 */
-			s->grants_used[i]->gref = GRANT_INVALID_REF;
+			s->grants_used[i]->gref = INVALID_GRANT_REF;
 			list_add_tail(&s->grants_used[i]->node, &rinfo->grants);
 		}
 	}
@@ -1500,7 +1498,7 @@ static int blkif_completion(unsigned long *id,
 					indirect_page = s->indirect_grants[i]->page;
 					list_add(&indirect_page->lru, &rinfo->indirect_pages);
 				}
-				s->indirect_grants[i]->gref = GRANT_INVALID_REF;
+				s->indirect_grants[i]->gref = INVALID_GRANT_REF;
 				list_add_tail(&s->indirect_grants[i]->node, &rinfo->grants);
 			}
 		}
@@ -1687,7 +1685,7 @@ static int setup_blkring(struct xenbus_device *dev,
 	grant_ref_t gref[XENBUS_MAX_RING_GRANTS];
 
 	for (i = 0; i < info->nr_ring_pages; i++)
-		rinfo->ring_ref[i] = GRANT_INVALID_REF;
+		rinfo->ring_ref[i] = INVALID_GRANT_REF;
 
 	sring = alloc_pages_exact(ring_size, GFP_NOIO);
 	if (!sring) {
@@ -2544,13 +2542,13 @@ static void purge_persistent_grants(struct blkfront_info *info)
 
 		list_for_each_entry_safe(gnt_list_entry, tmp, &rinfo->grants,
 					 node) {
-			if (gnt_list_entry->gref == GRANT_INVALID_REF ||
+			if (gnt_list_entry->gref == INVALID_GRANT_REF ||
 			    !gnttab_try_end_foreign_access(gnt_list_entry->gref))
 				continue;
 
 			list_del(&gnt_list_entry->node);
 			rinfo->persistent_gnts_c--;
-			gnt_list_entry->gref = GRANT_INVALID_REF;
+			gnt_list_entry->gref = INVALID_GRANT_REF;
 			list_add_tail(&gnt_list_entry->node, &grants);
 		}
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309353.525540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy1-00050A-AW; Wed, 20 Apr 2022 15:10:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309353.525540; Wed, 20 Apr 2022 15:10:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy0-0004ww-S0; Wed, 20 Apr 2022 15:10:04 +0000
Received: by outflank-mailman (input) for mailman id 309353;
 Wed, 20 Apr 2022 15:10:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxy-0003l4-Mv
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:02 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f2633f23-c0bb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:10:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D9190212CA;
 Wed, 20 Apr 2022 15:09:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A555313AE0;
 Wed, 20 Apr 2022 15:09:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iIX9JkciYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:09:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2633f23-c0bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nqfEAJYikez5yuRaJWQFVEnr7bTvqklH6kJ7XEyZeH4=;
	b=uZzO2cwIu/sM9Hdm1fFLMi4NNhXH9dzuMEXeAORI9mIENpJgMi0mH8YBRcV8SfzpXm4aCJ
	mgsKBrn4Aeo/6RKAQb2zKRH4zXldm3hlBxeNEOtRX2j1vJT8fz76y2iMt2w21WFF5SD4De
	UvfkRO//eO3i1T3ieg9KOtmlKggUaBw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH 06/18] xen/sound: switch xen_snd_front to use INVALID_GRANT_REF
Date: Wed, 20 Apr 2022 17:09:30 +0200
Message-Id: <20220420150942.31235-7-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 sound/xen/xen_snd_front_evtchnl.c | 4 ++--
 sound/xen/xen_snd_front_evtchnl.h | 9 ---------
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
index ecbc294fc59a..3e21369c8216 100644
--- a/sound/xen/xen_snd_front_evtchnl.c
+++ b/sound/xen/xen_snd_front_evtchnl.c
@@ -167,7 +167,7 @@ static void evtchnl_free(struct xen_snd_front_info *front_info,
 		xenbus_free_evtchn(front_info->xb_dev, channel->port);
 
 	/* End access and free the page. */
-	if (channel->gref != GRANT_INVALID_REF)
+	if (channel->gref != INVALID_GRANT_REF)
 		gnttab_end_foreign_access(channel->gref, page);
 	else
 		free_page(page);
@@ -207,7 +207,7 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 	channel->index = index;
 	channel->front_info = front_info;
 	channel->state = EVTCHNL_STATE_DISCONNECTED;
-	channel->gref = GRANT_INVALID_REF;
+	channel->gref = INVALID_GRANT_REF;
 	page = get_zeroed_page(GFP_KERNEL);
 	if (!page) {
 		ret = -ENOMEM;
diff --git a/sound/xen/xen_snd_front_evtchnl.h b/sound/xen/xen_snd_front_evtchnl.h
index cbe51fd1ec15..3675fba70564 100644
--- a/sound/xen/xen_snd_front_evtchnl.h
+++ b/sound/xen/xen_snd_front_evtchnl.h
@@ -15,15 +15,6 @@
 
 struct xen_snd_front_info;
 
-#ifndef GRANT_INVALID_REF
-/*
- * FIXME: usage of grant reference 0 as invalid grant reference:
- * grant reference 0 is valid, but never exposed to a PV driver,
- * because of the fact it is already in use/reserved by the PV console.
- */
-#define GRANT_INVALID_REF	0
-#endif
-
 /* Timeout in ms to wait for backend to respond. */
 #define VSND_WAIT_BACK_MS	3000
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309354.525543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy1-00058X-Rn; Wed, 20 Apr 2022 15:10:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309354.525543; Wed, 20 Apr 2022 15:10:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy1-000545-D2; Wed, 20 Apr 2022 15:10:05 +0000
Received: by outflank-mailman (input) for mailman id 309354;
 Wed, 20 Apr 2022 15:10:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxz-0003l9-70
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:03 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f280d0b4-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:10:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1094E215FC;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DDE5413AD5;
 Wed, 20 Apr 2022 15:09:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iEbyNEciYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:09:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f280d0b4-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SPIngja7rfH6/X0ahWtYB7L7nX8NRl4zj/+cjR7xZr0=;
	b=izW36Q/K4I+x9+ssoIZTIP6kcaOBnqGIAchacXhFrguclN9mlcwDy5Y3j6XIl58RxItKh2
	yFKJRHgSaBRlN10cFBSOt7Ea7MtSQEgQQW0NFvI/a+0rlT0kNILSRJWUf2qg0/waqA7ALN
	NEaH3ZeHIDVzSTHBGCrCGbqlRrM0AMs=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 07/18] xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF
Date: Wed, 20 Apr 2022 17:09:31 +0200
Message-Id: <20220420150942.31235-8-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/gntdev-dmabuf.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
index d5bfd7b867fc..91073b4e4a20 100644
--- a/drivers/xen/gntdev-dmabuf.c
+++ b/drivers/xen/gntdev-dmabuf.c
@@ -24,15 +24,6 @@
 
 MODULE_IMPORT_NS(DMA_BUF);
 
-#ifndef GRANT_INVALID_REF
-/*
- * Note on usage of grant reference 0 as invalid grant reference:
- * grant reference 0 is valid, but never exposed to a driver,
- * because of the fact it is already in use/reserved by the PV console.
- */
-#define GRANT_INVALID_REF	0
-#endif
-
 struct gntdev_dmabuf {
 	struct gntdev_dmabuf_priv *priv;
 	struct dma_buf *dmabuf;
@@ -532,7 +523,7 @@ static void dmabuf_imp_end_foreign_access(u32 *refs, int count)
 	int i;
 
 	for (i = 0; i < count; i++)
-		if (refs[i] != GRANT_INVALID_REF)
+		if (refs[i] != INVALID_GRANT_REF)
 			gnttab_end_foreign_access(refs[i], 0UL);
 }
 
@@ -567,7 +558,7 @@ static struct gntdev_dmabuf *dmabuf_imp_alloc_storage(int count)
 	gntdev_dmabuf->nr_pages = count;
 
 	for (i = 0; i < count; i++)
-		gntdev_dmabuf->u.imp.refs[i] = GRANT_INVALID_REF;
+		gntdev_dmabuf->u.imp.refs[i] = INVALID_GRANT_REF;
 
 	return gntdev_dmabuf;
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309355.525556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy2-0005L4-VS; Wed, 20 Apr 2022 15:10:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309355.525556; Wed, 20 Apr 2022 15:10:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy2-0005Hn-7b; Wed, 20 Apr 2022 15:10:06 +0000
Received: by outflank-mailman (input) for mailman id 309355;
 Wed, 20 Apr 2022 15:10:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBxz-0003l4-Me
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:03 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f2b5a086-c0bb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:10:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6E98B215FD;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 45D1113AD5;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kDnRD0giYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2b5a086-c0bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YDGIDWKPRWQB7unVe+D0Q46rvuLr6BdasgzAbPg2LQ4=;
	b=ldrF4kjq+B1ALbw+0FXFa11PZ6m6yv1eHafGyMjuw6sVEYhgTHTCPqG4eHHk3RNDnjFvFR
	uDngELLfvTSL23P1jfO6z9oZtu/Q96ANRFBwBt10W+2B3ZxB7zzO52ScagQgii6L1DZlt7
	yUr1q+kDuVo+nLFzfmzqcDwMKjr82z4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 09/18] xen/xenbus: add xenbus_setup_ring() service function
Date: Wed, 20 Apr 2022 17:09:33 +0200
Message-Id: <20220420150942.31235-10-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Most PV device frontends share very similar code for setting up shared
ring buffers:

- allocate page(s)
- init the ring admin data
- give the backend access to the ring via grants

Tearing down the ring requires similar actions in all frontends again:

- remove grants
- free the page(s)

Provide service functions xenbus_setup_ring() and xenbus_teardown_ring()
for that purpose.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/xenbus/xenbus_client.c | 69 ++++++++++++++++++++++++++++++
 include/xen/xenbus.h               |  4 ++
 2 files changed, 73 insertions(+)

diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
index df6890681231..1a2e0d94ccd1 100644
--- a/drivers/xen/xenbus/xenbus_client.c
+++ b/drivers/xen/xenbus/xenbus_client.c
@@ -407,6 +407,75 @@ int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
 }
 EXPORT_SYMBOL_GPL(xenbus_grant_ring);
 
+/*
+ * xenbus_setup_ring
+ * @dev: xenbus device
+ * @vaddr: pointer to starting virtual address of the ring
+ * @nr_pages: number of pages to be granted
+ * @grefs: grant reference array to be filled in
+ *
+ * Allocate physically contiguous pages for a shared ring buffer and grant it
+ * to the peer of the given device. The ring buffer is initially filled with
+ * zeroes. The virtual address of the ring is stored at @vaddr and the
+ * grant references are stored in the @grefs array. In case of error @vaddr
+ * will be set to NULL and @grefs will be filled with INVALID_GRANT_REF.
+ */
+int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
+		      unsigned int nr_pages, grant_ref_t *grefs)
+{
+	unsigned long ring_size = nr_pages * XEN_PAGE_SIZE;
+	unsigned int i;
+	int ret;
+
+	*vaddr = alloc_pages_exact(ring_size, gfp | __GFP_ZERO);
+	if (!*vaddr) {
+		ret = -ENOMEM;
+		goto err;
+	}
+
+	ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs);
+	if (ret)
+		goto err;
+
+	return 0;
+
+ err:
+	if (*vaddr)
+		free_pages_exact(*vaddr, ring_size);
+	for (i = 0; i < nr_pages; i++)
+		grefs[i] = INVALID_GRANT_REF;
+	*vaddr = NULL;
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(xenbus_setup_ring);
+
+/*
+ * xenbus_teardown_ring
+ * @vaddr: starting virtual address of the ring
+ * @nr_pages: number of pages
+ * @grefs: grant reference array
+ *
+ * Remove grants for the shared ring buffer and free the associated memory.
+ * On return the grant reference array is filled with INVALID_GRANT_REF.
+ */
+void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages,
+			  grant_ref_t *grefs)
+{
+	unsigned int i;
+
+	for (i = 0; i < nr_pages; i++) {
+		if (grefs[i] != INVALID_GRANT_REF) {
+			gnttab_end_foreign_access(grefs[i], 0);
+			grefs[i] = INVALID_GRANT_REF;
+		}
+	}
+
+	if (*vaddr)
+		free_pages_exact(*vaddr, nr_pages * XEN_PAGE_SIZE);
+	*vaddr = NULL;
+}
+EXPORT_SYMBOL_GPL(xenbus_teardown_ring);
 
 /**
  * Allocate an event channel for the given xenbus_device, assigning the newly
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
index b13eb86395e0..b533b4adc835 100644
--- a/include/xen/xenbus.h
+++ b/include/xen/xenbus.h
@@ -226,6 +226,10 @@ int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch,
 int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state);
 int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
 		      unsigned int nr_pages, grant_ref_t *grefs);
+int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
+		      unsigned int nr_pages, grant_ref_t *grefs);
+void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages,
+			  grant_ref_t *grefs);
 int xenbus_map_ring_valloc(struct xenbus_device *dev, grant_ref_t *gnt_refs,
 			   unsigned int nr_grefs, void **vaddr);
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309356.525561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy3-0005YH-MF; Wed, 20 Apr 2022 15:10:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309356.525561; Wed, 20 Apr 2022 15:10:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy3-0005UD-3O; Wed, 20 Apr 2022 15:10:07 +0000
Received: by outflank-mailman (input) for mailman id 309356;
 Wed, 20 Apr 2022 15:10:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy0-0003l9-78
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:04 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f29a7f35-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:10:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3F52C1F74E;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1721D13AD5;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qJqaBEgiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f29a7f35-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=27ryrQ9/V3A+L0L1cMkzg+znNHks8+NEi42Ak1eCxTQ=;
	b=tZ70zY2Z8ae+EH5HDjSsCrE0+Obr0+3PLdmMlwpcYTQS6O/gxKd5Wt0smGPntpM64zeZns
	oDNx8gIE1hM6kQMNo7Cc4s/LzaDVNqHIV/dBcgmK7lqMVFb+cnuA2Tt5XNHncoqPC6Byia
	RGfEx698LwhJYEYLJteROadnU2YJOEo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 08/18] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF
Date: Wed, 20 Apr 2022 17:09:32 +0200
Message-Id: <20220420150942.31235-9-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/xen-front-pgdir-shbuf.c | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/drivers/xen/xen-front-pgdir-shbuf.c b/drivers/xen/xen-front-pgdir-shbuf.c
index a959dee21134..fa2921d4fbfc 100644
--- a/drivers/xen/xen-front-pgdir-shbuf.c
+++ b/drivers/xen/xen-front-pgdir-shbuf.c
@@ -21,15 +21,6 @@
 
 #include <xen/xen-front-pgdir-shbuf.h>
 
-#ifndef GRANT_INVALID_REF
-/*
- * FIXME: usage of grant reference 0 as invalid grant reference:
- * grant reference 0 is valid, but never exposed to a PV driver,
- * because of the fact it is already in use/reserved by the PV console.
- */
-#define GRANT_INVALID_REF	0
-#endif
-
 /**
  * This structure represents the structure of a shared page
  * that contains grant references to the pages of the shared
@@ -83,7 +74,7 @@ grant_ref_t
 xen_front_pgdir_shbuf_get_dir_start(struct xen_front_pgdir_shbuf *buf)
 {
 	if (!buf->grefs)
-		return GRANT_INVALID_REF;
+		return INVALID_GRANT_REF;
 
 	return buf->grefs[0];
 }
@@ -142,7 +133,7 @@ void xen_front_pgdir_shbuf_free(struct xen_front_pgdir_shbuf *buf)
 		int i;
 
 		for (i = 0; i < buf->num_grefs; i++)
-			if (buf->grefs[i] != GRANT_INVALID_REF)
+			if (buf->grefs[i] != INVALID_GRANT_REF)
 				gnttab_end_foreign_access(buf->grefs[i], 0UL);
 	}
 	kfree(buf->grefs);
@@ -355,7 +346,7 @@ static void backend_fill_page_dir(struct xen_front_pgdir_shbuf *buf)
 	}
 	/* Last page must say there is no more pages. */
 	page_dir = (struct xen_page_directory *)ptr;
-	page_dir->gref_dir_next_page = GRANT_INVALID_REF;
+	page_dir->gref_dir_next_page = INVALID_GRANT_REF;
 }
 
 /**
@@ -384,7 +375,7 @@ static void guest_fill_page_dir(struct xen_front_pgdir_shbuf *buf)
 
 		if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) {
 			to_copy = grefs_left;
-			page_dir->gref_dir_next_page = GRANT_INVALID_REF;
+			page_dir->gref_dir_next_page = INVALID_GRANT_REF;
 		} else {
 			to_copy = XEN_NUM_GREFS_PER_PAGE;
 			page_dir->gref_dir_next_page = buf->grefs[i + 1];
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309357.525572 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy4-0005oT-NP; Wed, 20 Apr 2022 15:10:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309357.525572; Wed, 20 Apr 2022 15:10:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy4-0005lU-4P; Wed, 20 Apr 2022 15:10:08 +0000
Received: by outflank-mailman (input) for mailman id 309357;
 Wed, 20 Apr 2022 15:10:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy0-0003l4-Mu
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:04 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f2ddd54d-c0bb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:10:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id AEDA81F74F;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 75BB713AD5;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sHx2G0giYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2ddd54d-c0bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jX7srMhp6ubGUE560TW855B1p8XgeYqviaHs7bo1HEQ=;
	b=kK+HoGASU9zFbNjXEDo2LjceMqvAQGce4bPew3hcIKRD6+xa3dfSQNUY3SkQUPf+rnjJIq
	Y0nCIHUplnWY8chzVzP3MDTZFhGpeqmjYivp4zntVFFokHKSMNmI5bZgJjfrtepBO97rOd
	DI4vcrcbfvyYU+fGRcUV/5+gt5T/RHo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 10/18] xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Wed, 20 Apr 2022 17:09:34 +0200
Message-Id: <20220420150942.31235-11-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify blkfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/block/xen-blkfront.c | 34 +++++++---------------------------
 1 file changed, 7 insertions(+), 27 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 7f35e30e626a..367df4d9cd59 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1280,15 +1280,8 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
 	flush_work(&rinfo->work);
 
 	/* Free resources associated with old device channel. */
-	for (i = 0; i < info->nr_ring_pages; i++) {
-		if (rinfo->ring_ref[i] != INVALID_GRANT_REF) {
-			gnttab_end_foreign_access(rinfo->ring_ref[i], 0);
-			rinfo->ring_ref[i] = INVALID_GRANT_REF;
-		}
-	}
-	free_pages_exact(rinfo->ring.sring,
-			 info->nr_ring_pages * XEN_PAGE_SIZE);
-	rinfo->ring.sring = NULL;
+	xenbus_teardown_ring((void **)&rinfo->ring.sring, info->nr_ring_pages,
+			     rinfo->ring_ref);
 
 	if (rinfo->irq)
 		unbind_from_irqhandler(rinfo->irq, rinfo);
@@ -1679,31 +1672,18 @@ static int setup_blkring(struct xenbus_device *dev,
 			 struct blkfront_ring_info *rinfo)
 {
 	struct blkif_sring *sring;
-	int err, i;
+	int err;
 	struct blkfront_info *info = rinfo->dev_info;
 	unsigned long ring_size = info->nr_ring_pages * XEN_PAGE_SIZE;
-	grant_ref_t gref[XENBUS_MAX_RING_GRANTS];
 
-	for (i = 0; i < info->nr_ring_pages; i++)
-		rinfo->ring_ref[i] = INVALID_GRANT_REF;
+	err = xenbus_setup_ring(dev, GFP_NOIO, (void **)&sring,
+				info->nr_ring_pages, rinfo->ring_ref);
+	if (err)
+		goto fail;
 
-	sring = alloc_pages_exact(ring_size, GFP_NOIO);
-	if (!sring) {
-		xenbus_dev_fatal(dev, -ENOMEM, "allocating shared ring");
-		return -ENOMEM;
-	}
 	SHARED_RING_INIT(sring);
 	FRONT_RING_INIT(&rinfo->ring, sring, ring_size);
 
-	err = xenbus_grant_ring(dev, rinfo->ring.sring, info->nr_ring_pages, gref);
-	if (err < 0) {
-		free_pages_exact(sring, ring_size);
-		rinfo->ring.sring = NULL;
-		goto fail;
-	}
-	for (i = 0; i < info->nr_ring_pages; i++)
-		rinfo->ring_ref[i] = gref[i];
-
 	err = xenbus_alloc_evtchn(dev, &rinfo->evtchn);
 	if (err)
 		goto fail;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309358.525580 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy5-00063w-RF; Wed, 20 Apr 2022 15:10:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309358.525580; Wed, 20 Apr 2022 15:10:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy5-0005zb-3L; Wed, 20 Apr 2022 15:10:09 +0000
Received: by outflank-mailman (input) for mailman id 309358;
 Wed, 20 Apr 2022 15:10:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy1-0003l9-7M
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:05 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f3556ef4-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:10:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 74293215FF;
 Wed, 20 Apr 2022 15:10:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3DC6113AD5;
 Wed, 20 Apr 2022 15:10:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sI81DUkiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3556ef4-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tmwmbbtZJudUbAIbysps04tc1Vmd3FQIvvzlUXPcKxg=;
	b=pAfvqqiAD4OraYwqo6cZohlEfrN0mMKqAKpKdNaD5lUWEA3R1ABBgaA1jdc8J3HR2zf6Wv
	CbtxRrC6+LnfHL8iyNIz6lOK5roLsOdBsexS444hgxmjwnb4JHGj8GWdkog+m6mn/sWicy
	SxSln3cit6a9OYDk0m+vcJYUQ1e4DUo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: [PATCH 13/18] xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Wed, 20 Apr 2022 17:09:37 +0200
Message-Id: <20220420150942.31235-14-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify drmfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 40 ++++++---------------
 1 file changed, 10 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
index 4006568b9e32..9b16ea9f523b 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
@@ -123,12 +123,12 @@ static irqreturn_t evtchnl_interrupt_evt(int irq, void *dev_id)
 static void evtchnl_free(struct xen_drm_front_info *front_info,
 			 struct xen_drm_front_evtchnl *evtchnl)
 {
-	unsigned long page = 0;
+	void *page = NULL;
 
 	if (evtchnl->type == EVTCHNL_TYPE_REQ)
-		page = (unsigned long)evtchnl->u.req.ring.sring;
+		page = evtchnl->u.req.ring.sring;
 	else if (evtchnl->type == EVTCHNL_TYPE_EVT)
-		page = (unsigned long)evtchnl->u.evt.page;
+		page = evtchnl->u.evt.page;
 	if (!page)
 		return;
 
@@ -147,8 +147,7 @@ static void evtchnl_free(struct xen_drm_front_info *front_info,
 		xenbus_free_evtchn(front_info->xb_dev, evtchnl->port);
 
 	/* end access and free the page */
-	if (evtchnl->gref != INVALID_GRANT_REF)
-		gnttab_end_foreign_access(evtchnl->gref, page);
+	xenbus_teardown_ring(&page, 1, &evtchnl->gref);
 
 	memset(evtchnl, 0, sizeof(*evtchnl));
 }
@@ -158,8 +157,7 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index,
 			 enum xen_drm_front_evtchnl_type type)
 {
 	struct xenbus_device *xb_dev = front_info->xb_dev;
-	unsigned long page;
-	grant_ref_t gref;
+	void *page;
 	irq_handler_t handler;
 	int ret;
 
@@ -168,44 +166,26 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index,
 	evtchnl->index = index;
 	evtchnl->front_info = front_info;
 	evtchnl->state = EVTCHNL_STATE_DISCONNECTED;
-	evtchnl->gref = INVALID_GRANT_REF;
 
-	page = get_zeroed_page(GFP_NOIO | __GFP_HIGH);
-	if (!page) {
-		ret = -ENOMEM;
+	ret = xenbus_setup_ring(xb_dev, GFP_NOIO | __GFP_HIGH, &page,
+				1, &evtchnl->gref);
+	if (ret)
 		goto fail;
-	}
 
 	if (type == EVTCHNL_TYPE_REQ) {
 		struct xen_displif_sring *sring;
 
 		init_completion(&evtchnl->u.req.completion);
 		mutex_init(&evtchnl->u.req.req_io_lock);
-		sring = (struct xen_displif_sring *)page;
+		sring = page;
 		SHARED_RING_INIT(sring);
 		FRONT_RING_INIT(&evtchnl->u.req.ring, sring, XEN_PAGE_SIZE);
 
-		ret = xenbus_grant_ring(xb_dev, sring, 1, &gref);
-		if (ret < 0) {
-			evtchnl->u.req.ring.sring = NULL;
-			free_page(page);
-			goto fail;
-		}
-
 		handler = evtchnl_interrupt_ctrl;
 	} else {
-		ret = gnttab_grant_foreign_access(xb_dev->otherend_id,
-						  virt_to_gfn((void *)page), 0);
-		if (ret < 0) {
-			free_page(page);
-			goto fail;
-		}
-
-		evtchnl->u.evt.page = (struct xendispl_event_page *)page;
-		gref = ret;
+		evtchnl->u.evt.page = page;
 		handler = evtchnl_interrupt_evt;
 	}
-	evtchnl->gref = gref;
 
 	ret = xenbus_alloc_evtchn(xb_dev, &evtchnl->port);
 	if (ret < 0)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309359.525598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy8-0006by-DP; Wed, 20 Apr 2022 15:10:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309359.525598; Wed, 20 Apr 2022 15:10:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy7-0006U7-5P; Wed, 20 Apr 2022 15:10:11 +0000
Received: by outflank-mailman (input) for mailman id 309359;
 Wed, 20 Apr 2022 15:10:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy1-0003l4-Mw
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:05 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f307f1cf-c0bb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:10:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id F1572215FE;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B560113AD5;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kMInK0giYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f307f1cf-c0bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aZCkP4ZTIz8L3n5icXJW44l5GxuZEDRnsAjAP0WhQbc=;
	b=ltchNwiSpdyVnlwL94VdMGg3q9XkNrTd8PU8GecHmmKA2xueh8TSnLik9ju2nQgFdU7jAI
	fouQD9Ufzdt2SX7rghRnRK21cspyfWJSePo4SMHeff6MNuZopRUi8C1YLrbQaWkDstD8fp
	lKCwbxP0tpg7NCPGqZst22fehTkYZ20=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH 11/18] xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Wed, 20 Apr 2022 17:09:35 +0200
Message-Id: <20220420150942.31235-12-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify netfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/net/xen-netfront.c | 49 +++++++++-----------------------------
 1 file changed, 11 insertions(+), 38 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index af3d3de7d9fa..880b10d435d9 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1921,8 +1921,7 @@ static int setup_netfront(struct xenbus_device *dev,
 			struct netfront_queue *queue, unsigned int feature_split_evtchn)
 {
 	struct xen_netif_tx_sring *txs;
-	struct xen_netif_rx_sring *rxs = NULL;
-	grant_ref_t gref;
+	struct xen_netif_rx_sring *rxs;
 	int err;
 
 	queue->tx_ring_ref = INVALID_GRANT_REF;
@@ -1930,34 +1929,22 @@ static int setup_netfront(struct xenbus_device *dev,
 	queue->rx.sring = NULL;
 	queue->tx.sring = NULL;
 
-	txs = (struct xen_netif_tx_sring *)get_zeroed_page(GFP_NOIO | __GFP_HIGH);
-	if (!txs) {
-		err = -ENOMEM;
-		xenbus_dev_fatal(dev, err, "allocating tx ring page");
+	err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH, (void **)&txs,
+				1, &queue->tx_ring_ref);
+	if (err)
 		goto fail;
-	}
+
 	SHARED_RING_INIT(txs);
 	FRONT_RING_INIT(&queue->tx, txs, XEN_PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, txs, 1, &gref);
-	if (err < 0)
+	err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH, (void **)&rxs,
+				1, &queue->rx_ring_ref);
+	if (err)
 		goto fail;
-	queue->tx_ring_ref = gref;
 
-	rxs = (struct xen_netif_rx_sring *)get_zeroed_page(GFP_NOIO | __GFP_HIGH);
-	if (!rxs) {
-		err = -ENOMEM;
-		xenbus_dev_fatal(dev, err, "allocating rx ring page");
-		goto fail;
-	}
 	SHARED_RING_INIT(rxs);
 	FRONT_RING_INIT(&queue->rx, rxs, XEN_PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, rxs, 1, &gref);
-	if (err < 0)
-		goto fail;
-	queue->rx_ring_ref = gref;
-
 	if (feature_split_evtchn)
 		err = setup_netfront_split(queue);
 	/* setup single event channel if
@@ -1972,24 +1959,10 @@ static int setup_netfront(struct xenbus_device *dev,
 
 	return 0;
 
-	/* If we fail to setup netfront, it is safe to just revoke access to
-	 * granted pages because backend is not accessing it at this point.
-	 */
  fail:
-	if (queue->rx_ring_ref != INVALID_GRANT_REF) {
-		gnttab_end_foreign_access(queue->rx_ring_ref,
-					  (unsigned long)rxs);
-		queue->rx_ring_ref = INVALID_GRANT_REF;
-	} else {
-		free_page((unsigned long)rxs);
-	}
-	if (queue->tx_ring_ref != INVALID_GRANT_REF) {
-		gnttab_end_foreign_access(queue->tx_ring_ref,
-					  (unsigned long)txs);
-		queue->tx_ring_ref = INVALID_GRANT_REF;
-	} else {
-		free_page((unsigned long)txs);
-	}
+	xenbus_teardown_ring((void **)&queue->rx.sring, 1, &queue->rx_ring_ref);
+	xenbus_teardown_ring((void **)&queue->tx.sring, 1, &queue->tx_ring_ref);
+
 	return err;
 }
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309360.525608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy9-0006sv-Io; Wed, 20 Apr 2022 15:10:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309360.525608; Wed, 20 Apr 2022 15:10:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhBy8-0006mv-Iv; Wed, 20 Apr 2022 15:10:12 +0000
Received: by outflank-mailman (input) for mailman id 309360;
 Wed, 20 Apr 2022 15:10:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy2-0003l9-7O
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:06 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f37b7617-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:10:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B143321600;
 Wed, 20 Apr 2022 15:10:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7A52A13AD5;
 Wed, 20 Apr 2022 15:10:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mMS4HEkiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f37b7617-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4w7uCrVXVTwZfPuB483vIPp5pLFfFRyBD4Y2IYXR2Yk=;
	b=fz0rlO1XMdB4BddZo8c4Teth0+zAy8QaParWZU14wrqXGD6EySljVo6Vq6kBi9HXKi0Rga
	xuTZhtvj50WWZimNnLTKwBftHtnnForaUNyo7J+NGQQPcb/KSOCH4nn4iVfeQ4OCTkaQVZ
	j32mZDbE44Ahb1h++ngv8o4nT0tLPzw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 14/18] xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Wed, 20 Apr 2022 17:09:38 +0200
Message-Id: <20220420150942.31235-15-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify pcifront's shared page creation and removal via
xenbus_setup_ring() and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/pci/xen-pcifront.c | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index 3edc1565a27c..689271c4245c 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -709,9 +709,8 @@ static struct pcifront_device *alloc_pdev(struct xenbus_device *xdev)
 	if (pdev == NULL)
 		goto out;
 
-	pdev->sh_info =
-	    (struct xen_pci_sharedinfo *)__get_free_page(GFP_KERNEL);
-	if (pdev->sh_info == NULL) {
+	if (xenbus_setup_ring(xdev, GFP_KERNEL, (void **)&pdev->sh_info, 1,
+			      &pdev->gnt_ref)) {
 		kfree(pdev);
 		pdev = NULL;
 		goto out;
@@ -729,7 +728,6 @@ static struct pcifront_device *alloc_pdev(struct xenbus_device *xdev)
 	spin_lock_init(&pdev->sh_info_lock);
 
 	pdev->evtchn = INVALID_EVTCHN;
-	pdev->gnt_ref = INVALID_GRANT_REF;
 	pdev->irq = -1;
 
 	INIT_WORK(&pdev->op_work, pcifront_do_aer);
@@ -754,11 +752,7 @@ static void free_pdev(struct pcifront_device *pdev)
 	if (pdev->evtchn != INVALID_EVTCHN)
 		xenbus_free_evtchn(pdev->xdev, pdev->evtchn);
 
-	if (pdev->gnt_ref != INVALID_GRANT_REF)
-		gnttab_end_foreign_access(pdev->gnt_ref,
-					  (unsigned long)pdev->sh_info);
-	else
-		free_page((unsigned long)pdev->sh_info);
+	xenbus_teardown_ring((void **)&pdev->sh_info, 1, &pdev->gnt_ref);
 
 	dev_set_drvdata(&pdev->xdev->dev, NULL);
 
@@ -769,13 +763,6 @@ static int pcifront_publish_info(struct pcifront_device *pdev)
 {
 	int err = 0;
 	struct xenbus_transaction trans;
-	grant_ref_t gref;
-
-	err = xenbus_grant_ring(pdev->xdev, pdev->sh_info, 1, &gref);
-	if (err < 0)
-		goto out;
-
-	pdev->gnt_ref = gref;
 
 	err = xenbus_alloc_evtchn(pdev->xdev, &pdev->evtchn);
 	if (err)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309361.525619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhByB-0007H9-FG; Wed, 20 Apr 2022 15:10:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309361.525619; Wed, 20 Apr 2022 15:10:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhByA-00079l-3z; Wed, 20 Apr 2022 15:10:14 +0000
Received: by outflank-mailman (input) for mailman id 309361;
 Wed, 20 Apr 2022 15:10:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy2-0003l4-N6
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:06 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3288839-c0bb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:10:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 326F31F752;
 Wed, 20 Apr 2022 15:10:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0350D13AD5;
 Wed, 20 Apr 2022 15:10:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wJc1O0giYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3288839-c0bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CI5eCbbUh0HTvUxNvVm6rOMW68v7G6W10HjxAtg/ngA=;
	b=gjZEMURyKhH+ffoe/cJZIs+1qR6NiuC5LbjUsc6HQbUiY2YzhMqa9gcWbW4J8W52XRcuUB
	bxVKmzgppOt2rXgXD9zG+IZ7iT7xfDjw0J35R694tg4TxR9zrp0FyFGkwbXBgSna0vfc7P
	/KVWK5ggl/fmh28DGQ7IZcMIgPfHAnU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-integrity@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>
Subject: [PATCH 12/18] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Wed, 20 Apr 2022 17:09:36 +0200
Message-Id: <20220420150942.31235-13-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify tpmfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/char/tpm/xen-tpmfront.c | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 69df04ae2401..379291826261 100644
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -253,20 +253,12 @@ static int setup_ring(struct xenbus_device *dev, struct tpm_private *priv)
 	struct xenbus_transaction xbt;
 	const char *message = NULL;
 	int rv;
-	grant_ref_t gref;
 
-	priv->shr = (void *)__get_free_page(GFP_KERNEL|__GFP_ZERO);
-	if (!priv->shr) {
-		xenbus_dev_fatal(dev, -ENOMEM, "allocating shared ring");
-		return -ENOMEM;
-	}
-
-	rv = xenbus_grant_ring(dev, priv->shr, 1, &gref);
+	rv = xenbus_setup_ring(dev, GFP_KERNEL, (void **)&priv->shr, 1,
+			       &priv->ring_ref);
 	if (rv < 0)
 		return rv;
 
-	priv->ring_ref = gref;
-
 	rv = xenbus_alloc_evtchn(dev, &priv->evtchn);
 	if (rv)
 		return rv;
@@ -331,11 +323,7 @@ static void ring_free(struct tpm_private *priv)
 	if (!priv)
 		return;
 
-	if (priv->ring_ref)
-		gnttab_end_foreign_access(priv->ring_ref,
-				(unsigned long)priv->shr);
-	else
-		free_page((unsigned long)priv->shr);
+	xenbus_teardown_ring((void **)&priv->shr, 1, &priv->ring_ref);
 
 	if (priv->irq)
 		unbind_from_irqhandler(priv->irq, priv);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309362.525631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhByD-0007fM-9x; Wed, 20 Apr 2022 15:10:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309362.525631; Wed, 20 Apr 2022 15:10:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhByB-0007X3-TO; Wed, 20 Apr 2022 15:10:15 +0000
Received: by outflank-mailman (input) for mailman id 309362;
 Wed, 20 Apr 2022 15:10:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy3-0003l9-7V
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:07 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f3a0aa29-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:10:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EC45B2112B;
 Wed, 20 Apr 2022 15:10:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B940913AD5;
 Wed, 20 Apr 2022 15:10:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id GL8QLEkiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3a0aa29-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zIVRYJfuKT5Cc8Eh8lkT4S5YymR5yO4CxthS7o0vErk=;
	b=dqosmBbYFka6Cq4Fx3XDgQHYlD1l+kwlMIm2CKI8qmUk88Qls9O2u9OhjZfgqQVVyXEHAl
	F5AYRXlkgASQKbFoZaaEmJYPy7bQ0yV3XDjBRjOVGpr8R+cUhgWmk84/IMZM/K9yZKlQHC
	oSvKC/4crEhSlduV6M0b2pJQU17VPOU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 15/18] xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Wed, 20 Apr 2022 17:09:39 +0200
Message-Id: <20220420150942.31235-16-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify scsifront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/scsi/xen-scsifront.c | 27 +++++++--------------------
 1 file changed, 7 insertions(+), 20 deletions(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 9db2366fa2d4..f15a35750040 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -798,28 +798,17 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info)
 {
 	struct xenbus_device *dev = info->dev;
 	struct vscsiif_sring *sring;
-	grant_ref_t gref;
-	int err = -ENOMEM;
+	int err;
 
 	/***** Frontend to Backend ring start *****/
-	sring = (struct vscsiif_sring *)__get_free_page(GFP_KERNEL);
-	if (!sring) {
-		xenbus_dev_fatal(dev, err,
-			"fail to allocate shared ring (Front to Back)");
+	err = xenbus_setup_ring(dev, GFP_KERNEL, (void **)&sring, 1,
+				&info->ring_ref);
+	if (err)
 		return err;
-	}
+
 	SHARED_RING_INIT(sring);
 	FRONT_RING_INIT(&info->ring, sring, PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, sring, 1, &gref);
-	if (err < 0) {
-		free_page((unsigned long)sring);
-		xenbus_dev_fatal(dev, err,
-			"fail to grant shared ring (Front to Back)");
-		return err;
-	}
-	info->ring_ref = gref;
-
 	err = xenbus_alloc_evtchn(dev, &info->evtchn);
 	if (err) {
 		xenbus_dev_fatal(dev, err, "xenbus_alloc_evtchn");
@@ -847,8 +836,7 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info)
 free_irq:
 	unbind_from_irqhandler(info->irq, info);
 free_gnttab:
-	gnttab_end_foreign_access(info->ring_ref,
-				  (unsigned long)info->ring.sring);
+	xenbus_teardown_ring((void **)&sring, 1, &info->ring_ref);
 
 	return err;
 }
@@ -856,8 +844,7 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info)
 static void scsifront_free_ring(struct vscsifrnt_info *info)
 {
 	unbind_from_irqhandler(info->irq, info);
-	gnttab_end_foreign_access(info->ring_ref,
-				  (unsigned long)info->ring.sring);
+	xenbus_teardown_ring((void **)&info->ring.sring, 1, &info->ring_ref);
 }
 
 static int scsifront_init_ring(struct vscsifrnt_info *info)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309363.525639 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhByF-0007yl-3h; Wed, 20 Apr 2022 15:10:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309363.525639; Wed, 20 Apr 2022 15:10:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhByD-0007t3-IQ; Wed, 20 Apr 2022 15:10:17 +0000
Received: by outflank-mailman (input) for mailman id 309363;
 Wed, 20 Apr 2022 15:10:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy4-0003l9-7c
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:08 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f3bbec23-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:10:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 249321F755;
 Wed, 20 Apr 2022 15:10:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F294D13AD5;
 Wed, 20 Apr 2022 15:10:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wD8gOkkiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3bbec23-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4XO8mycpJSRe2vI+Vj0O3qJ4olWbFoCtMGHkp23ojsk=;
	b=Y/wHvCn79hpZ3MR5MUZgiZYUWb54QUxJMgP20Sni9+zhVg83Ad+Ow6g1GClmrtdxakPE9M
	cm1US8RDJtQ9jv+2INVLRiTBj/VTsmp/DbYnUzbcWFWq60WgTjevWgSCFhJG/LFhRTGMGS
	NcQBgF6wnnuAovRz8oLfTVPntt124Ag=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 16/18] xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Wed, 20 Apr 2022 17:09:40 +0200
Message-Id: <20220420150942.31235-17-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify xen-hcd's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/usb/host/xen-hcd.c | 55 +++++++++-----------------------------
 1 file changed, 13 insertions(+), 42 deletions(-)

diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c
index 9cbc7c2dab02..0acb68eb37ee 100644
--- a/drivers/usb/host/xen-hcd.c
+++ b/drivers/usb/host/xen-hcd.c
@@ -1098,19 +1098,10 @@ static void xenhcd_destroy_rings(struct xenhcd_info *info)
 		unbind_from_irqhandler(info->irq, info);
 	info->irq = 0;
 
-	if (info->urb_ring_ref != INVALID_GRANT_REF) {
-		gnttab_end_foreign_access(info->urb_ring_ref,
-					  (unsigned long)info->urb_ring.sring);
-		info->urb_ring_ref = INVALID_GRANT_REF;
-	}
-	info->urb_ring.sring = NULL;
-
-	if (info->conn_ring_ref != INVALID_GRANT_REF) {
-		gnttab_end_foreign_access(info->conn_ring_ref,
-					  (unsigned long)info->conn_ring.sring);
-		info->conn_ring_ref = INVALID_GRANT_REF;
-	}
-	info->conn_ring.sring = NULL;
+	xenbus_teardown_ring((void **)&info->urb_ring.sring, 1,
+			     &info->urb_ring_ref);
+	xenbus_teardown_ring((void **)&info->conn_ring.sring, 1,
+			     &info->conn_ring_ref);
 }
 
 static int xenhcd_setup_rings(struct xenbus_device *dev,
@@ -1118,47 +1109,27 @@ static int xenhcd_setup_rings(struct xenbus_device *dev,
 {
 	struct xenusb_urb_sring *urb_sring;
 	struct xenusb_conn_sring *conn_sring;
-	grant_ref_t gref;
 	int err;
 
-	info->urb_ring_ref = INVALID_GRANT_REF;
 	info->conn_ring_ref = INVALID_GRANT_REF;
-
-	urb_sring = (struct xenusb_urb_sring *)get_zeroed_page(
-							GFP_NOIO | __GFP_HIGH);
-	if (!urb_sring) {
-		xenbus_dev_fatal(dev, -ENOMEM, "allocating urb ring");
-		return -ENOMEM;
+	err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH,
+				(void **)&urb_sring, 1, &info->urb_ring_ref);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "allocating urb ring");
+		return err;
 	}
 	SHARED_RING_INIT(urb_sring);
 	FRONT_RING_INIT(&info->urb_ring, urb_sring, PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, urb_sring, 1, &gref);
-	if (err < 0) {
-		free_page((unsigned long)urb_sring);
-		info->urb_ring.sring = NULL;
-		goto fail;
-	}
-	info->urb_ring_ref = gref;
-
-	conn_sring = (struct xenusb_conn_sring *)get_zeroed_page(
-							GFP_NOIO | __GFP_HIGH);
-	if (!conn_sring) {
-		xenbus_dev_fatal(dev, -ENOMEM, "allocating conn ring");
-		err = -ENOMEM;
+	err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH,
+				(void **)&conn_sring, 1, &info->conn_ring_ref);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "allocating conn ring");
 		goto fail;
 	}
 	SHARED_RING_INIT(conn_sring);
 	FRONT_RING_INIT(&info->conn_ring, conn_sring, PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, conn_sring, 1, &gref);
-	if (err < 0) {
-		free_page((unsigned long)conn_sring);
-		info->conn_ring.sring = NULL;
-		goto fail;
-	}
-	info->conn_ring_ref = gref;
-
 	err = xenbus_alloc_evtchn(dev, &info->evtchn);
 	if (err) {
 		xenbus_dev_fatal(dev, err, "xenbus_alloc_evtchn");
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:10:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:10:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309364.525651 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhByH-0008LP-0X; Wed, 20 Apr 2022 15:10:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309364.525651; Wed, 20 Apr 2022 15:10:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhByF-0008Ea-9G; Wed, 20 Apr 2022 15:10:19 +0000
Received: by outflank-mailman (input) for mailman id 309364;
 Wed, 20 Apr 2022 15:10:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy5-0003l9-7l
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:09 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f3ddcb98-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:10:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5A2221F756;
 Wed, 20 Apr 2022 15:10:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B21313AD5;
 Wed, 20 Apr 2022 15:10:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8E1yCUoiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3ddcb98-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ij8UfjCLrmWlzw8p3dv1NeerjjrG+tJoiHZZthvTeTI=;
	b=JFTWSh6PJxJNJV7oRKcYWQSPPmYpfiNbr7bGGF1C4FLcMUoeH5mugdJwUSjRTpmafzW3Z6
	3/rnOYNY53Prw7TUqwIAO/wr+1hE9sHaZ8juMfZMr2ylg+TetOlsdH5uDLkAimH+CRHSO4
	/xH4WD232P0oiT57WD4l/KlJ4lYa0c0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH 17/18] xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Wed, 20 Apr 2022 17:09:41 +0200
Message-Id: <20220420150942.31235-18-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify sndfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 sound/xen/xen_snd_front_evtchnl.c | 41 +++++++------------------------
 1 file changed, 9 insertions(+), 32 deletions(-)

diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
index 3e21369c8216..32d42fd3f7ac 100644
--- a/sound/xen/xen_snd_front_evtchnl.c
+++ b/sound/xen/xen_snd_front_evtchnl.c
@@ -143,12 +143,12 @@ void xen_snd_front_evtchnl_flush(struct xen_snd_front_evtchnl *channel)
 static void evtchnl_free(struct xen_snd_front_info *front_info,
 			 struct xen_snd_front_evtchnl *channel)
 {
-	unsigned long page = 0;
+	void *page = NULL;
 
 	if (channel->type == EVTCHNL_TYPE_REQ)
-		page = (unsigned long)channel->u.req.ring.sring;
+		page = channel->u.req.ring.sring;
 	else if (channel->type == EVTCHNL_TYPE_EVT)
-		page = (unsigned long)channel->u.evt.page;
+		page = channel->u.evt.page;
 
 	if (!page)
 		return;
@@ -167,10 +167,7 @@ static void evtchnl_free(struct xen_snd_front_info *front_info,
 		xenbus_free_evtchn(front_info->xb_dev, channel->port);
 
 	/* End access and free the page. */
-	if (channel->gref != INVALID_GRANT_REF)
-		gnttab_end_foreign_access(channel->gref, page);
-	else
-		free_page(page);
+	xenbus_teardown_ring(&page, 1, &channel->gref);
 
 	memset(channel, 0, sizeof(*channel));
 }
@@ -196,8 +193,7 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 			 enum xen_snd_front_evtchnl_type type)
 {
 	struct xenbus_device *xb_dev = front_info->xb_dev;
-	unsigned long page;
-	grant_ref_t gref;
+	void *page;
 	irq_handler_t handler;
 	char *handler_name = NULL;
 	int ret;
@@ -207,12 +203,9 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 	channel->index = index;
 	channel->front_info = front_info;
 	channel->state = EVTCHNL_STATE_DISCONNECTED;
-	channel->gref = INVALID_GRANT_REF;
-	page = get_zeroed_page(GFP_KERNEL);
-	if (!page) {
-		ret = -ENOMEM;
+	ret = xenbus_setup_ring(xb_dev, GFP_KERNEL, &page, 1, &channel->gref);
+	if (ret)
 		goto fail;
-	}
 
 	handler_name = kasprintf(GFP_KERNEL, "%s-%s", XENSND_DRIVER_NAME,
 				 type == EVTCHNL_TYPE_REQ ?
@@ -226,33 +219,19 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 	mutex_init(&channel->ring_io_lock);
 
 	if (type == EVTCHNL_TYPE_REQ) {
-		struct xen_sndif_sring *sring = (struct xen_sndif_sring *)page;
+		struct xen_sndif_sring *sring = page;
 
 		init_completion(&channel->u.req.completion);
 		mutex_init(&channel->u.req.req_io_lock);
 		SHARED_RING_INIT(sring);
 		FRONT_RING_INIT(&channel->u.req.ring, sring, XEN_PAGE_SIZE);
 
-		ret = xenbus_grant_ring(xb_dev, sring, 1, &gref);
-		if (ret < 0) {
-			channel->u.req.ring.sring = NULL;
-			goto fail;
-		}
-
 		handler = evtchnl_interrupt_req;
 	} else {
-		ret = gnttab_grant_foreign_access(xb_dev->otherend_id,
-						  virt_to_gfn((void *)page), 0);
-		if (ret < 0)
-			goto fail;
-
-		channel->u.evt.page = (struct xensnd_event_page *)page;
-		gref = ret;
+		channel->u.evt.page = page;
 		handler = evtchnl_interrupt_evt;
 	}
 
-	channel->gref = gref;
-
 	ret = xenbus_alloc_evtchn(xb_dev, &channel->port);
 	if (ret < 0)
 		goto fail;
@@ -279,8 +258,6 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 	return 0;
 
 fail:
-	if (page)
-		free_page(page);
 	kfree(handler_name);
 	dev_err(&xb_dev->dev, "Failed to allocate ring: %d\n", ret);
 	return ret;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:13:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:13:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309416.525686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhC0z-0006tF-87; Wed, 20 Apr 2022 15:13:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309416.525686; Wed, 20 Apr 2022 15:13:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhC0z-0006t8-4p; Wed, 20 Apr 2022 15:13:09 +0000
Received: by outflank-mailman (input) for mailman id 309416;
 Wed, 20 Apr 2022 15:13:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhBy6-0003l9-7o
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:10:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f3fba793-c0bb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:10:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 870F51F75C;
 Wed, 20 Apr 2022 15:10:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 602B213AD5;
 Wed, 20 Apr 2022 15:10:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2PBIFkoiYGJILQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:10:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3fba793-c0bb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650467402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QLFILJSyTHZFwq9omiEC/cxiL5bUIoRxF/dV9SsWN+s=;
	b=fU0EP2NLCoJe8acGsjUQq+tmbjd9EV5kJ837Yvpjtv3R+E+3rdGLFrVs3chlN8uv83+s3P
	V2mWF1R7X54tVlLdCKJydZmarq3eFTC+1QOhIfPS3iXNwVxAbQaf+CszPw4cSbP+RQi0bK
	PRYJay9LyAUNVTxOluvKtHQACb11R0A=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 18/18] xen/xenbus: eliminate xenbus_grant_ring()
Date: Wed, 20 Apr 2022 17:09:42 +0200
Message-Id: <20220420150942.31235-19-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220420150942.31235-1-jgross@suse.com>
References: <20220420150942.31235-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There is no external user of xenbus_grant_ring() left, so merge it into
the only caller xenbus_setup_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/xenbus/xenbus_client.c | 64 +++++++++---------------------
 include/xen/xenbus.h               |  2 -
 2 files changed, 18 insertions(+), 48 deletions(-)

diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
index 1a2e0d94ccd1..7b1f7f86b6e5 100644
--- a/drivers/xen/xenbus/xenbus_client.c
+++ b/drivers/xen/xenbus/xenbus_client.c
@@ -363,50 +363,6 @@ static void xenbus_switch_fatal(struct xenbus_device *dev, int depth, int err,
 		__xenbus_switch_state(dev, XenbusStateClosing, 1);
 }
 
-/**
- * xenbus_grant_ring
- * @dev: xenbus device
- * @vaddr: starting virtual address of the ring
- * @nr_pages: number of pages to be granted
- * @grefs: grant reference array to be filled in
- *
- * Grant access to the given @vaddr to the peer of the given device.
- * Then fill in @grefs with grant references.  Return 0 on success, or
- * -errno on error.  On error, the device will switch to
- * XenbusStateClosing, and the error will be saved in the store.
- */
-int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
-		      unsigned int nr_pages, grant_ref_t *grefs)
-{
-	int err;
-	unsigned int i;
-	grant_ref_t gref_head;
-
-	err = gnttab_alloc_grant_references(nr_pages, &gref_head);
-	if (err) {
-		xenbus_dev_fatal(dev, err, "granting access to ring page");
-		return err;
-	}
-
-	for (i = 0; i < nr_pages; i++) {
-		unsigned long gfn;
-
-		if (is_vmalloc_addr(vaddr))
-			gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr));
-		else
-			gfn = virt_to_gfn(vaddr);
-
-		grefs[i] = gnttab_claim_grant_reference(&gref_head);
-		gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id,
-						gfn, 0);
-
-		vaddr = vaddr + XEN_PAGE_SIZE;
-	}
-
-	return 0;
-}
-EXPORT_SYMBOL_GPL(xenbus_grant_ring);
-
 /*
  * xenbus_setup_ring
  * @dev: xenbus device
@@ -424,6 +380,7 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
 		      unsigned int nr_pages, grant_ref_t *grefs)
 {
 	unsigned long ring_size = nr_pages * XEN_PAGE_SIZE;
+	grant_ref_t gref_head;
 	unsigned int i;
 	int ret;
 
@@ -433,9 +390,24 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
 		goto err;
 	}
 
-	ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs);
-	if (ret)
+	ret = gnttab_alloc_grant_references(nr_pages, &gref_head);
+	if (ret) {
+		xenbus_dev_fatal(dev, ret, "granting access to ring page");
 		goto err;
+	}
+
+	for (i = 0; i < nr_pages; i++) {
+		unsigned long gfn;
+
+		if (is_vmalloc_addr(*vaddr))
+			gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr[i]));
+		else
+			gfn = virt_to_gfn(vaddr[i]);
+
+		grefs[i] = gnttab_claim_grant_reference(&gref_head);
+		gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id,
+						gfn, 0);
+	}
 
 	return 0;
 
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
index b533b4adc835..eaa932b99d8a 100644
--- a/include/xen/xenbus.h
+++ b/include/xen/xenbus.h
@@ -224,8 +224,6 @@ int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch,
 			 const char *pathfmt, ...);
 
 int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state);
-int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
-		      unsigned int nr_pages, grant_ref_t *grefs);
 int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
 		      unsigned int nr_pages, grant_ref_t *grefs);
 void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages,
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:22:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:22:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309445.525697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCAE-000055-4u; Wed, 20 Apr 2022 15:22:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309445.525697; Wed, 20 Apr 2022 15:22:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCAE-00004w-1c; Wed, 20 Apr 2022 15:22:42 +0000
Received: by outflank-mailman (input) for mailman id 309445;
 Wed, 20 Apr 2022 15:22:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhCAC-0008WT-H6
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:22:40 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b4f92030-c0bd-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:22:37 +0200 (CEST)
Received: from mail-dm3nam07lp2048.outbound.protection.outlook.com (HELO
 NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.48])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Apr 2022 11:22:35 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BYAPR03MB4181.namprd03.prod.outlook.com (2603:10b6:a03:7d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 15:22:32 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 15:22:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4f92030-c0bd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650468158;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ajc7tNbbGPWIctUbbCGk2QBq3ugT/V+TsK8nwL4vgrc=;
  b=BZPWWzGFKk67kWG1gkkgO4snNq2nXmXf8LkzxUbHBmP3BbFmy+G46EGq
   1GgezlkgSeZbei4xFwq7J/NoQKQYZy2WT8Pho6bKPlvtm2kgXxjIB/lLK
   Nz7sVcCciHYDGMgkwTVb1XZcC5ZTQmXQpFTK1nO4UbVsi42BwQ6QC3f5x
   o=;
X-IronPort-RemoteIP: 104.47.56.48
X-IronPort-MID: 69400021
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:7bcSHq3hIXaFvO0AavbD5e9wkn2cJEfYwER7XKvMYLTBsI5bpzVSy
 jNOWT2CPfnYZWqhLt8ibYyypB4O6MXQn4VlGQFtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy2YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /11lsyNVxoTIZHDo/UiWTVTF3FZfup/reqvzXiX6aR/zmXgWl60mbBCKRpzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82dBfmajTNb9G5YasRmNPDSf
 ccGLxFoawzNeUZnMVYLEpMu2uyvgxETdhUG+Q7N/fJtugA/yiQh9ZvDaOTyJOa0Yu5phEzCv
 m7r9UnAV0Ry2Nu3jGDtHmiXru3AhyTgQ6oJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvH5XhulsDuHswQaVt54DeI38keOx7DS7gLfAXILJhZLb8Ynr4kxXiAw0
 UGSnMLBAiZmu7mYD3ma89+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXryos1LFae0ipj5HGr2y
 jXS8ywm3e1P3YgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl
 BA5dwK2toji0bnlePSxfdgw
IronPort-HdrOrdr: A9a23:ywEnaa+2CbB9/t0GwkFuk+GBdr1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79
 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6
 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1cjegIK5Y1n3X
 nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3bRY0eTFcZcso+5zXQISdKUmREXeR
 730lEd1vFImjbsl6eO0ELQMkfboW4TAjTZuCKlaDPY0LDErXQBeot8bMtiA2XkAwBLhqAC7I
 tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOJ1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+
 uzUagmdsPeEQ==
X-IronPort-AV: E=Sophos;i="5.90,276,1643691600"; 
   d="scan'208";a="69400021"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DXeE8/WtlgPbw+XeWo7px7IbI8n1w3T3Q63A5sSiK+fFq1tMMOkW7RDrFNePkGsmFMSQzNQ2C/PUn+0Pa89TLCisK7Hqw/Kgm+Fpwu30itiRrn4aECVnsVU2i1wDP1/Kzk+S8QNpff5DjR6lzsaAZUfcrJzrVOpq/z0qVH/IdEIwa0EU9hBjHtGaeVCd21jFuVQouyWKB29FizWkkAe9d5Yo2QV3qO4yDFjMNZU0mBIMBVXHbp818qmZMaohzHr0cuYpQ4iMVcHqUrnvc4ivEwp+AFwPLYsnI62q2MCTDGFacr1/7Kv/NcSU8sGhh4t4pS78BJT0pC9vZ4g5cYtPig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ajc7tNbbGPWIctUbbCGk2QBq3ugT/V+TsK8nwL4vgrc=;
 b=R0yOzXoFNJbbCfj1ekVvIj8b/4pZskk+Xpbs1R1OV1G3q+PQflOpAtQhzVMsZHU2aj7DGPBbRDChC82b0b7da+DPffXO0a9UPb7H8SJ4/EszEB8wV/Azfzly+fZzcqa5GnLFrdkRF7XZm/4shv6yLClKNPXBUQFENt7CX2EchjzGZhN5H1aFLgflbLUUdtqMYrRRJyjLe+qzaYQlStOMgqHPJQ6KLZOziTQ/FnqHmonnjY9PFDKg/wJILCfDu/3Wecm+OqPlFJoG0jXu+zYa6AFcn8e/eIpDfefjLJjFOuOGUwaMHiVGtOkTzE1Fy8NgR1AT6HALPG87NYCQHO+ymg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ajc7tNbbGPWIctUbbCGk2QBq3ugT/V+TsK8nwL4vgrc=;
 b=qaLCf5kiwf735s4Ap7tm0Dwk6dB5lUgN21xyvPH4ojlFdxfoge07YNlusDas1vVMmG/JgBwnz2vrb9U+JlvIhWReD6oHNI3EHkS/cj5trRwdGU5QgGY0jRCrvBdw+i7SUPH4gCbdvxtZSxNyuq8VqGTYLvl0J4+nyVzbpigQZL8=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: Re: [PATCH 18/18] xen/xenbus: eliminate xenbus_grant_ring()
Thread-Topic: [PATCH 18/18] xen/xenbus: eliminate xenbus_grant_ring()
Thread-Index: AQHYVMkyGaYzhccwwkWCnGeb0Tf8nKz461YA
Date: Wed, 20 Apr 2022 15:22:32 +0000
Message-ID: <fdc5675e-7766-2144-8f56-a49faab9631a@citrix.com>
References: <20220420150942.31235-1-jgross@suse.com>
 <20220420150942.31235-19-jgross@suse.com>
In-Reply-To: <20220420150942.31235-19-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bba60d3f-9a84-4d28-e368-08da22e1970f
x-ms-traffictypediagnostic: BYAPR03MB4181:EE_
x-microsoft-antispam-prvs:
 <BYAPR03MB4181306827CC220B964F2297BAF59@BYAPR03MB4181.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 O65np1h+M0gzluCzYQNORH1WbE3wu0LrlDNMYICvTuAH/R6C6KftH9hhWZ8XCz4OEEWKee5P/d3ZAMnWWdupEIkLnuBTwA9u6NhUgZt4yOCvuTiCtQ4Gh/IoqtWp+IcLP5ikJI11KXohHyW52k7ZaSo3+81Fjt8LMmYhV1NDWs8tYQgLasDmTTbxLmV65EQdZzQq5FufzKaoy89yAm1fPsdJig0pzMBSFHJEGasG2taxLoDxYMFOVZOH7+Z+F7DLAtCwXDMnrTFXR2eIANBpoAUvDIpXYrWCZAh5CxlB3+J/BdhvfzmpjYohvOQMWX1U1AmL6Xp18xUpWGJMRCBJr/unoei4AOsWsfal8dgQg0KRmg925+OtV3+RcGePEc7E2iYon110XadqpwAUCZlofvrnH4gRg5aAgP81l7fjbnO7Sgnw6T6j+QeBiOZ6QqP/zlre2kSX+TVNWveeQccBD2T6zjeIjjr2nGIfYvb/kdq9ll+kPkGAnWEics0q6guQI9tKGEinY64RQbAT83MHtqHnS9kv45XF0S1DpyWOF/BvsANliUAMClYcLL1K1KTqsfRrtN5UeiD/MBEANbLWdABL0pOE27p1mAq4OwFls8OW1SQ3iAWYMWIUzsoziWEqXdnO49RXR1xHV9lZwiib4pqhL+d2yKyIkC7PHhcZXJkeWWwLI4hToSlU0ZLvmw2SX+iS3vfTx9n867ytaw9F7JFCes8FJsMsMOgGew50NwZ37U9+gJ7PjWbN+cUi00omDFg+LpvH5mNbQ928KPzj7iK1h2dnG4+/CkS+ShBpkVbe+hRfJMqCBexKUSAKDtYg
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(508600001)(4326008)(83380400001)(66946007)(8676002)(66556008)(6486002)(66476007)(66446008)(64756008)(110136005)(2616005)(82960400001)(38100700002)(316002)(38070700005)(54906003)(5660300002)(36756003)(8936002)(31696002)(6506007)(6512007)(86362001)(26005)(31686004)(53546011)(4744005)(122000001)(186003)(91956017)(76116006)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?V1JaWndZNFpQbUs0Y01Uekdtem5tNE5selVIdHE4eFZjalpibDBON1JGVlpo?=
 =?utf-8?B?R0JLd3VVOWI2Uk0xT2J6aGlSVkhxN1EyY09tRVlkMzl4RmJsZzZ1VFRHaUVI?=
 =?utf-8?B?NDllSzN1d09ZcVZUY01QdFkzZCs4b0RJZzZaWmJYbmFpMnlXWTVRK3U5QUdQ?=
 =?utf-8?B?QU53aTE4VTZZTlVPWkhDSW4xZnR2NjZ2Nmdsc2ZvdEdlc2I1VTZ1eUZJMnNW?=
 =?utf-8?B?cFNIUlhWWEVCRlNXZ05RQ00vYjZNOEhjQmZDZHdmVmpNZnpkZkVnOTJmdURq?=
 =?utf-8?B?bE1WZEVYa2JtSStBaFpIVVphRTA1Wnp6NHBYdEhaRm56dmVmd3NTeU1mSEp2?=
 =?utf-8?B?TFFIdTRWSkRWWFI0Y0JyTXZTeVArQjV4eEhoR0kzcnJPL2toVmloZnBaTGRo?=
 =?utf-8?B?T2tBT09hYi9EU3c2NUZESWp6VExMRXh5SzRTbzV6TTlnYUJkbzFpbW02em9B?=
 =?utf-8?B?VGR4NkgwOHd2bUdXSDUrOGNlMWtHNzhDZkF1aEZDY21DR3pvTHNWN3BhWW90?=
 =?utf-8?B?UnlyU0VWNzZyQlBuT2Z3T2cwYWhkUDFMOGpQdFFGMWo4ZmJNWGRmeWJIenlr?=
 =?utf-8?B?UWM3QkdNcDFXV3ZsZ2QvNzVBQUJWM3FBUHhiazlKSDhEcTc5WjFaTFU3eU9U?=
 =?utf-8?B?bmNubmpQYmdFZ05hQWMxNGNDdjBjSnRIU2tMTkhDc01jc3FISEZOWW9oRHBo?=
 =?utf-8?B?MWtYNDFkNVFPMUp4VUlROFJIZHZ5Zmk1N3JlSTREQ2ZJempKS3Q1QzNuUWpO?=
 =?utf-8?B?UVpZbndIRXA1UmF4S2IvWkl4VVhKdnhhV1hqT01EcDVtYXlPaEtaSnFIVjZq?=
 =?utf-8?B?OXdLTUgzNTRmWm5kNW43ZU9vaXBhWHRmZU1kajBzZG9mYkdUblhPZ1ptdHlE?=
 =?utf-8?B?MjRvZ2h5QUVab0pkNkplVktvckxmL05rVVBYQjRJOVNOTWdqKy9iSmNyR2Q1?=
 =?utf-8?B?V2xJWGhDVTNMVUQxOEdSeE40eHlKYTJ0SU1FRCtMSFdzVFhYRFJIdzZxSll0?=
 =?utf-8?B?UStYbGRyM04vU1FEeUpZTExvVlRhKzhvWHRQRlFvTDRDdG1qejVYZmVzTVJL?=
 =?utf-8?B?ZDFxNXBLMG5ZMjNYRXhDc0RYdFUyR01OTW9mMC9qZGNxVGFSbWpqc1NNSXMy?=
 =?utf-8?B?Q3QybEt3OTRhV3VpSHhKYmNpOFlTTU1Qem5oNklSSWV1Wlpvc0MrY2VUTkk3?=
 =?utf-8?B?Y2h0cHJtQW9UVWg3Vnd3M1VKSU12U0NKNzFreDkrbU1JR25IOG1MVTFNVlVJ?=
 =?utf-8?B?aTVBN1I0MkNuWXpYVjZ6ZThzQXVqTHNzNzNZNGFmODZZVDUyV2NtUWdHR29w?=
 =?utf-8?B?VHF3QnVZd1luUG5LZVduWnRPWnNhdi92THNnTVpVcStvbWhBNitQTG01RC9G?=
 =?utf-8?B?a1lwSjJadGg3Vk1rRzU3bFZVSC9NV2RwMEM0ZXJYMzh6SndQamlkc3djUnh3?=
 =?utf-8?B?YklZZjZ1L3E4SS9RYk9YM0U1ODF3a3dwRUtrcy9iYjBzV3NrY0h4ZXczWkQz?=
 =?utf-8?B?SFBiZUF5MEM2ekRQUkNpd2VHUWd1N2lEYnE1NHJwZnpBQlkyMWp0MWxNRUs5?=
 =?utf-8?B?aGRCUVdDbWNOdGlBSEw1WDhjblg2YmxpTmVZNFdsYjQ2Tk9FZW0zYVpBL005?=
 =?utf-8?B?L0o2b2IxOEtoUzJTcENQQkJOUTBUWHdKOGxEVWlSY0dPMXpQWkh5ejhyTGRt?=
 =?utf-8?B?VWF3Q0RUWktaanFUVGljaTJFTHZNV2NJUWR0NnVLVmc5Vm5hU0R1Vng4RmVR?=
 =?utf-8?B?SW5JUC84enF4NFcyRFRSbXRuVC9WeURIL09HNGxndFptT2hXckdrS2ZhOTVH?=
 =?utf-8?B?ekdScFByUTUzYXF5TCszMVFaZ2NkKzdwNWJhNnhYRFg4RkVsK0tmQi9UZlJK?=
 =?utf-8?B?dmJXK004STM1T3drcGwwU01kaVl2K2lWTEQ3UXN0c3I1ZGFhL2xENnZ1ek1T?=
 =?utf-8?B?MkZSSWJDdEphaEVuMmxHVzFCWG5CRU0wUUFMdmNSM0E4dVhJVjUyNEE0dDBh?=
 =?utf-8?B?STZyZ2ZOYlF2OEpla29Yc29XVEFiR24wdWVMMVRMc3l4SHErN2V5YnVqU05v?=
 =?utf-8?B?VUkwb1FDZ1lKNXkxenp2VExBeHBmZDBXd241SEt0YS9la0tTMWpYUlVEVzYy?=
 =?utf-8?B?Z1hHWEt2a3FRMkJnQW05RkhoS3I1K0tjOEhHYXJ1SnM3WnN5d3lvVHZKNGJk?=
 =?utf-8?B?SW81OUhWVDF0bmhXajVndlJmTnN0NndySVEvaDBFZVpnNklYZ2tXQnJCT1Aw?=
 =?utf-8?B?aEc1L1loOFo1MnU2OWQ2dGZzV1dNa1g1ajlMZU5DRW5hOXY3dFlzS2RUQmVj?=
 =?utf-8?B?ZGh5ZGJ4bmVEcisyNEY4aTBuOEFGK29KeTBDRG55YjlkSnJCOVBidz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <22CCBF37A861C04FA021C24F492FD183@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bba60d3f-9a84-4d28-e368-08da22e1970f
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 15:22:32.3420
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x+kJ6Ki1wyEGof7r6nFPuy/9s7955Ho4xPbBHA6TXSoJBv/IO5FkqOCxKyUUr/OAs15eZjdYJjN6yEOVEHCsHRAQnbx6EF63kJ6xx5TI6aI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4181

T24gMjAvMDQvMjAyMiAxNjowOSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfY2xpZW50LmMgYi9kcml2ZXJzL3hlbi94ZW5idXMv
eGVuYnVzX2NsaWVudC5jDQo+IGluZGV4IDFhMmUwZDk0Y2NkMS4uN2IxZjdmODZiNmU1IDEwMDY0
NA0KPiAtLS0gYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NsaWVudC5jDQo+ICsrKyBiL2Ry
aXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfY2xpZW50LmMNCj4gQEAgLTQzMyw5ICszOTAsMjQgQEAg
aW50IHhlbmJ1c19zZXR1cF9yaW5nKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsIGdmcF90IGdm
cCwgdm9pZCAqKnZhZGRyLA0KPiAgCQlnb3RvIGVycjsNCj4gIAl9DQo+ICANCj4gLQlyZXQgPSB4
ZW5idXNfZ3JhbnRfcmluZyhkZXYsICp2YWRkciwgbnJfcGFnZXMsIGdyZWZzKTsNCj4gLQlpZiAo
cmV0KQ0KPiArCXJldCA9IGdudHRhYl9hbGxvY19ncmFudF9yZWZlcmVuY2VzKG5yX3BhZ2VzLCAm
Z3JlZl9oZWFkKTsNCj4gKwlpZiAocmV0KSB7DQo+ICsJCXhlbmJ1c19kZXZfZmF0YWwoZGV2LCBy
ZXQsICJncmFudGluZyBhY2Nlc3MgdG8gcmluZyBwYWdlIik7DQoNCkNhbiB3ZSB0YWtlIHRoZSBv
cHBvcnR1bml0eSB0byB1bmJyZWFrIHRoaXMgZXJyb3IgbWVzc2FnZT/CoCAiJXUgcmluZyBwYWdl
cyIuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:33:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:33:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309451.525707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCKi-0001sP-56; Wed, 20 Apr 2022 15:33:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309451.525707; Wed, 20 Apr 2022 15:33:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCKi-0001sI-2B; Wed, 20 Apr 2022 15:33:32 +0000
Received: by outflank-mailman (input) for mailman id 309451;
 Wed, 20 Apr 2022 15:33:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhCKg-0001rs-Fq
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:33:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 39dc97a8-c0bf-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:33:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1CC781F385;
 Wed, 20 Apr 2022 15:33:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DDAD513AD5;
 Wed, 20 Apr 2022 15:33:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mE/bNMcnYGJpNwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:33:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39dc97a8-c0bf-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650468808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=kUyien+X+aKrfWNmxu1J2DMHSzIs0wi8yTDzXFvfr6A=;
	b=PQwL7DUDNvQu+aJEVFd0jprGoTBj6Jgi4S+pvkM/n0Szgln9UNjx2j51uohrkhoBEKLHwe
	2Hv+zVe0kJqjJ3Fmg4ScxLCyQ38HBHsLmi/fWQw3QGOfe0ZLyQ9cZgoOvo5Hj0Hy1jD5t9
	RnWe5o6V2QNzSKBnAJLIGdHT0BRZMaw=
Message-ID: <67088937-576d-cafa-ad21-13eea497683a@suse.com>
Date: Wed, 20 Apr 2022 17:33:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 18/18] xen/xenbus: eliminate xenbus_grant_ring()
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20220420150942.31235-1-jgross@suse.com>
 <20220420150942.31235-19-jgross@suse.com>
 <fdc5675e-7766-2144-8f56-a49faab9631a@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <fdc5675e-7766-2144-8f56-a49faab9631a@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------pbiZjsksvj6Z21gBiaYfufUn"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------pbiZjsksvj6Z21gBiaYfufUn
Content-Type: multipart/mixed; boundary="------------Zynua7uXBy7MiNzM6Om5Hml7";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <67088937-576d-cafa-ad21-13eea497683a@suse.com>
Subject: Re: [PATCH 18/18] xen/xenbus: eliminate xenbus_grant_ring()
References: <20220420150942.31235-1-jgross@suse.com>
 <20220420150942.31235-19-jgross@suse.com>
 <fdc5675e-7766-2144-8f56-a49faab9631a@citrix.com>
In-Reply-To: <fdc5675e-7766-2144-8f56-a49faab9631a@citrix.com>

--------------Zynua7uXBy7MiNzM6Om5Hml7
Content-Type: multipart/mixed; boundary="------------OzQRlIwmin5E8UoUJHiWu0RY"

--------------OzQRlIwmin5E8UoUJHiWu0RY
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDQuMjIgMTc6MjIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDIwLzA0LzIw
MjIgMTY6MDksIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy94ZW4veGVuYnVzL3hlbmJ1c19jbGllbnQuYyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5i
dXNfY2xpZW50LmMNCj4+IGluZGV4IDFhMmUwZDk0Y2NkMS4uN2IxZjdmODZiNmU1IDEwMDY0
NA0KPj4gLS0tIGEvZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19jbGllbnQuYw0KPj4gKysr
IGIvZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19jbGllbnQuYw0KPj4gQEAgLTQzMyw5ICsz
OTAsMjQgQEAgaW50IHhlbmJ1c19zZXR1cF9yaW5nKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpk
ZXYsIGdmcF90IGdmcCwgdm9pZCAqKnZhZGRyLA0KPj4gICAJCWdvdG8gZXJyOw0KPj4gICAJ
fQ0KPj4gICANCj4+IC0JcmV0ID0geGVuYnVzX2dyYW50X3JpbmcoZGV2LCAqdmFkZHIsIG5y
X3BhZ2VzLCBncmVmcyk7DQo+PiAtCWlmIChyZXQpDQo+PiArCXJldCA9IGdudHRhYl9hbGxv
Y19ncmFudF9yZWZlcmVuY2VzKG5yX3BhZ2VzLCAmZ3JlZl9oZWFkKTsNCj4+ICsJaWYgKHJl
dCkgew0KPj4gKwkJeGVuYnVzX2Rldl9mYXRhbChkZXYsIHJldCwgImdyYW50aW5nIGFjY2Vz
cyB0byByaW5nIHBhZ2UiKTsNCj4gDQo+IENhbiB3ZSB0YWtlIHRoZSBvcHBvcnR1bml0eSB0
byB1bmJyZWFrIHRoaXMgZXJyb3IgbWVzc2FnZT/CoCAiJXUgcmluZyBwYWdlcyIuDQoNCkZp
bmUgd2l0aCBtZS4NCg0KDQpKdWVyZ2VuDQo=
--------------OzQRlIwmin5E8UoUJHiWu0RY
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------OzQRlIwmin5E8UoUJHiWu0RY--

--------------Zynua7uXBy7MiNzM6Om5Hml7--

--------------pbiZjsksvj6Z21gBiaYfufUn
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJgJ8cFAwAAAAAACgkQsN6d1ii/Ey8z
VwgAh1MZdNvdCxCgf5LxO0qIPGvZHJWiJwP/cImXnvin9CGB4VUSgWMQWzPs9Iw7zYJVPEN6VYx2
vlKCqu75kY11q3RfjYcsmFyiNU6BL/VDkbelbFiLDYPVqrkjXiJ0gnGdAsRtFy/09Dihyu21jlLP
fNuRyikPXexmuD5iKsVyAusaKwJG4Uzxd3wr9ChSsoUSZ9/K5VIM+JAbM/Qkm8VfBDldxtbXxXfY
iBSWGHHEFj0E2JdEto7OkMnbQoHeOADXC4wCyOoHd0ZTZV4jbGfRLSzc0LuDvmJFJ2y8l4jRT7R+
vnBNUe4/vdJDqE3LD04IfBoRwu3IbwCDlu9lpcRxAw==
=kcqN
-----END PGP SIGNATURE-----

--------------pbiZjsksvj6Z21gBiaYfufUn--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:35:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:35:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309456.525719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCMD-0002fZ-JN; Wed, 20 Apr 2022 15:35:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309456.525719; Wed, 20 Apr 2022 15:35:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCMD-0002fS-G3; Wed, 20 Apr 2022 15:35:05 +0000
Received: by outflank-mailman (input) for mailman id 309456;
 Wed, 20 Apr 2022 15:35:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Avzr=U6=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1nhCMC-0002es-J6
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:35:04 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7167e8f9-c0bf-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:35:03 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 06C54618E5;
 Wed, 20 Apr 2022 15:35:01 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99049C385A1;
 Wed, 20 Apr 2022 15:34:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7167e8f9-c0bf-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1650468900;
	bh=uDbXPsQLU9tElHGZJOcUaYQxeuzg8LGzzXxfnfZ3DUk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=2XUPnrrd1R/EP512qBRWnWZ0CQzmEE6Dw1iC59OeDJXdfO3GGWuRLKz6WcqoeDl5D
	 ktQyyZiQMLceQAGZedyyRmhJKRXY6OJaEc4CrysGnOOyPPwAqL1T0Nl7QeGyvTwzTw
	 /8GKcnxqRD8SZj/o8/zLVJkX/GPJSmuHrvdGtQuU=
Date: Wed, 20 Apr 2022 17:34:56 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/18] xen/usb: switch xen-hcd to use INVALID_GRANT_REF
Message-ID: <YmAoIPJYoq65uybr@kroah.com>
References: <20220420150942.31235-1-jgross@suse.com>
 <20220420150942.31235-5-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220420150942.31235-5-jgross@suse.com>

On Wed, Apr 20, 2022 at 05:09:28PM +0200, Juergen Gross wrote:
> Instead of using a private macro for an invalid grant reference use
> the common one.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  drivers/usb/host/xen-hcd.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:35:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:35:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309457.525730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCMK-000304-Ro; Wed, 20 Apr 2022 15:35:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309457.525730; Wed, 20 Apr 2022 15:35:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCMK-0002zx-Og; Wed, 20 Apr 2022 15:35:12 +0000
Received: by outflank-mailman (input) for mailman id 309457;
 Wed, 20 Apr 2022 15:35:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Avzr=U6=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1nhCMJ-0002es-An
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:35:11 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 76965a4c-c0bf-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 17:35:10 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A83F5B81EB2;
 Wed, 20 Apr 2022 15:35:09 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02272C385A0;
 Wed, 20 Apr 2022 15:35:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76965a4c-c0bf-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1650468908;
	bh=0TvdShlIkCt6RpyVO2I0TcefFwjvh8bV2p1H8fkiRCY=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=DfCCWMrlvQ7r8C8oCO+V3OEkoZT+yCc1nyQ/di1itJ78t/ql3ehtDekGvZnIC0f0s
	 mV/030tbzJqg8eEmHPd/KpRzen1MTbg1uyRkd+cL6e1wy8uH2SYMBFGn1nzEQ7xjOp
	 VdzA+wfCOZ2exyOVSfQKaFYjz8Ke5y9C1NoSVn+Y=
Date: Wed, 20 Apr 2022 17:35:05 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/18] xen/usbfront: use xenbus_setup_ring() and
 xenbus_teardown_ring()
Message-ID: <YmAoKaw2Xe39oWm+@kroah.com>
References: <20220420150942.31235-1-jgross@suse.com>
 <20220420150942.31235-17-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220420150942.31235-17-jgross@suse.com>

On Wed, Apr 20, 2022 at 05:09:40PM +0200, Juergen Gross wrote:
> Simplify xen-hcd's ring creation and removal via xenbus_setup_ring()
> and xenbus_teardown_ring().
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  drivers/usb/host/xen-hcd.c | 55 +++++++++-----------------------------
>  1 file changed, 13 insertions(+), 42 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:38:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:38:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309467.525741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCPV-0003wA-Ab; Wed, 20 Apr 2022 15:38:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309467.525741; Wed, 20 Apr 2022 15:38:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCPV-0003w3-7L; Wed, 20 Apr 2022 15:38:29 +0000
Received: by outflank-mailman (input) for mailman id 309467;
 Wed, 20 Apr 2022 15:38:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhCPT-0003vx-QM
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:38:27 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb3a8993-c0bf-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:38:26 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5BBC81F380;
 Wed, 20 Apr 2022 15:38:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 30C2B13AD5;
 Wed, 20 Apr 2022 15:38:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id y7tpCvIoYGJqOQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 15:38:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb3a8993-c0bf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650469106; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/pZusOKcqvv/exzu40WZnHGbpb5yQWBb4nm0puIF6fA=;
	b=NBhagqJG1dSGTv5OC5kHZuaFOreInnt3W56D7YlYvqLPjl4eQemG2AjMJyhcpXyUIEpYzF
	5NsRag2w5fAVWWihBMdmlb2m7m5MU0TQ9Icn3ZnFxCArwtGrm+ju1at9lbTa9qctKNbdON
	pxTwJJk2y54ma/legkMZsa+nMksMBcA=
Message-ID: <30e984cb-36e8-d28a-4a02-21e693eb647e@suse.com>
Date: Wed, 20 Apr 2022 17:38:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v7 5/7] xen/cpupool: Don't allow removing cpu0 from
 cpupool0
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>,
 Xen developer discussion <xen-devel@lists.xenproject.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Dario Faggioli <dfaggioli@suse.com>, George Dunlap <george.dunlap@citrix.com>
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-6-luca.fancellu@arm.com>
 <214318DB-3359-4525-870F-0293EDDC32A6@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <214318DB-3359-4525-870F-0293EDDC32A6@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------LqDLEK2eEDkYYC3Fj0eyNnED"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------LqDLEK2eEDkYYC3Fj0eyNnED
Content-Type: multipart/mixed; boundary="------------Bh9g1TH3tJUfd28A0Vnm00Cf";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>,
 Xen developer discussion <xen-devel@lists.xenproject.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Dario Faggioli <dfaggioli@suse.com>, George Dunlap <george.dunlap@citrix.com>
Message-ID: <30e984cb-36e8-d28a-4a02-21e693eb647e@suse.com>
Subject: Re: [PATCH v7 5/7] xen/cpupool: Don't allow removing cpu0 from
 cpupool0
References: <20220411152101.17539-1-luca.fancellu@arm.com>
 <20220411152101.17539-6-luca.fancellu@arm.com>
 <214318DB-3359-4525-870F-0293EDDC32A6@arm.com>
In-Reply-To: <214318DB-3359-4525-870F-0293EDDC32A6@arm.com>

--------------Bh9g1TH3tJUfd28A0Vnm00Cf
Content-Type: multipart/mixed; boundary="------------mW3mwg9lG70kn5irFcmeWO93"

--------------mW3mwg9lG70kn5irFcmeWO93
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDQuMjIgMTY6NTcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IA0KPiANCj4+IE9u
IDExIEFwciAyMDIyLCBhdCAxNjoyMCwgTHVjYSBGYW5jZWxsdSA8THVjYS5GYW5jZWxsdUBh
cm0uY29tPiB3cm90ZToNCj4+DQo+PiBDcHUwIG11c3QgcmVtYWluIGluIGNwdXBvb2wwLCBv
dGhlcndpc2Ugc29tZSBvcGVyYXRpb25zIGxpa2UgbW92aW5nIGNwdXMNCj4+IGJldHdlZW4g
Y3B1cG9vbHMsIGNwdSBob3RwbHVnLCBkZXN0cm95aW5nIGNwdXBvb2xzLCBzaHV0ZG93biBv
ZiB0aGUgaG9zdCwNCj4+IG1pZ2h0IG5vdCB3b3JrIGluIGEgc2FuZSB3YXkuDQo+Pg0KPj4g
U2lnbmVkLW9mZi1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0K
Pj4gLS0tDQo+PiBDaGFuZ2VzIGluIHY3Og0KPj4gLSBuZXcgcGF0Y2gNCj4+IC0tLQ0KPj4g
eGVuL2NvbW1vbi9zY2hlZC9jcHVwb29sLmMgfCA4ICsrKysrKystDQo+PiAxIGZpbGUgY2hh
bmdlZCwgNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+Pg0KPj4gZGlmZiAtLWdp
dCBhL3hlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5jIGIveGVuL2NvbW1vbi9zY2hlZC9jcHVw
b29sLmMNCj4+IGluZGV4IDg2YTE3NWY5OWNkNS4uMGE5M2JjYzYzMWJmIDEwMDY0NA0KPj4g
LS0tIGEveGVuL2NvbW1vbi9zY2hlZC9jcHVwb29sLmMNCj4+ICsrKyBiL3hlbi9jb21tb24v
c2NoZWQvY3B1cG9vbC5jDQo+PiBAQCAtNTcyLDYgKzU3Miw3IEBAIHN0YXRpYyBsb25nIGNm
X2NoZWNrIGNwdXBvb2xfdW5hc3NpZ25fY3B1X2hlbHBlcih2b2lkICppbmZvKQ0KPj4gICAq
IHBvc3NpYmxlIGZhaWx1cmVzOg0KPj4gICAqIC0gbGFzdCBjcHUgYW5kIHN0aWxsIGFjdGl2
ZSBkb21haW5zIGluIGNwdXBvb2wNCj4+ICAgKiAtIGNwdSBqdXN0IGJlaW5nIHVucGx1Z2dl
ZA0KPj4gKyAqIC0gQXR0ZW1wdCB0byByZW1vdmUgYm9vdCBjcHUgZnJvbSBjcHVwb29sMA0K
Pj4gICAqLw0KPj4gc3RhdGljIGludCBjcHVwb29sX3VuYXNzaWduX2NwdShzdHJ1Y3QgY3B1
cG9vbCAqYywgdW5zaWduZWQgaW50IGNwdSkNCj4+IHsNCj4+IEBAIC01ODIsNyArNTgzLDEy
IEBAIHN0YXRpYyBpbnQgY3B1cG9vbF91bmFzc2lnbl9jcHUoc3RydWN0IGNwdXBvb2wgKmMs
IHVuc2lnbmVkIGludCBjcHUpDQo+PiAgICAgIGRlYnVndHJhY2VfcHJpbnRrKCJjcHVwb29s
X3VuYXNzaWduX2NwdShwb29sPSV1LGNwdT0lZClcbiIsDQo+PiAgICAgICAgICAgICAgICAg
ICAgICAgIGMtPmNwdXBvb2xfaWQsIGNwdSk7DQo+Pg0KPj4gLSAgICBpZiAoICFjcHVfb25s
aW5lKGNwdSkgKQ0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBDcHUwIG11c3QgcmVtYWluIGlu
IGNwdXBvb2wwLCBvdGhlcndpc2Ugc29tZSBvcGVyYXRpb25zIGxpa2UgbW92aW5nIGNwdXMN
Cj4+ICsgICAgICogYmV0d2VlbiBjcHVwb29scywgY3B1IGhvdHBsdWcsIGRlc3Ryb3lpbmcg
Y3B1cG9vbHMsIHNodXRkb3duIG9mIHRoZSBob3N0LA0KPj4gKyAgICAgKiBtaWdodCBub3Qg
d29yayBpbiBhIHNhbmUgd2F5Lg0KPj4gKyAgICAgKi8NCj4+ICsgICAgaWYgKCAoIWMtPmNw
dXBvb2xfaWQgJiYgIWNwdSkgfHwgIWNwdV9vbmxpbmUoY3B1KSApDQo+PiAgICAgICAgICBy
ZXR1cm4gLUVJTlZBTDsNCj4+DQo+PiAgICAgIG1hc3Rlcl9jcHUgPSBzY2hlZF9nZXRfcmVz
b3VyY2VfY3B1KGNwdSk7DQo+PiAtLSANCj4+IDIuMTcuMQ0KPj4NCj4gDQo+IEhpLA0KPiAN
Cj4gSeKAmW0gZ29pbmcgdG8gYWRkcmVzcyB0aGUgY29tbWVudCBvbiB0aGlzIHNlcmllIGJl
Zm9yZSByZS1wdXNoaW5nIGl0LCBJIHNlZSB0aGVyZQ0KPiBhcmUgbm8gY29tbWVudHMgb24g
dGhpcyBwYXRjaCwgc28gSeKAmW0gd29uZGVyaW5nLCB3aGVuIHlvdSBoYXZlIHRpbWUsIGlm
IHlvdQ0KPiBjYW4gZ2l2ZSBtZSBzb21lIGZlZWRiYWNrIG9uIHRoaXMgb25lLg0KDQpTb3Jy
eSwgSSBzZWVtIHRvIGhhdmUgbWlzc2VkIHRoaXMgb25lLg0KDQpSZXZpZXdlZC1ieTogSnVl
cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg0K
--------------mW3mwg9lG70kn5irFcmeWO93
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------mW3mwg9lG70kn5irFcmeWO93--

--------------Bh9g1TH3tJUfd28A0Vnm00Cf--

--------------LqDLEK2eEDkYYC3Fj0eyNnED
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJgKPEFAwAAAAAACgkQsN6d1ii/Ey99
uAf9Gvwv2J5YK90YvDDRpA9Alvl4RhXGXHrSJVZToB4qL6Tl1P15tF4CsyMsRC1JdJ8SfIMsqfJJ
OBjRcXwgoCIiIRdBjqMLQ+8eEHXGl5WytZhNZ1yQiedmmxpp99Ak71AE+L8B5ku9O7xajtEjLA7o
mTpGCrHPMwTH4D3F2cX0s1uAk0y1Lc95jguHb1GHa5xANBPVnVFK4XJfCsptNgAghsVgiWu/6+Na
zO6/O+q89rV15LmuLlyXQioeSohTyuEvpXr0X/Km77//S9i++fyj7Y8oWXHoENTkS3Bt2vskFaO0
4BVL/DYZctY2SGc1HmnLKGi+/tkghK9ZzzLziVgUeA==
=BLZI
-----END PGP SIGNATURE-----

--------------LqDLEK2eEDkYYC3Fj0eyNnED--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 15:57:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 15:57:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309473.525752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhChq-0006jK-U8; Wed, 20 Apr 2022 15:57:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309473.525752; Wed, 20 Apr 2022 15:57:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhChq-0006jD-QY; Wed, 20 Apr 2022 15:57:26 +0000
Received: by outflank-mailman (input) for mailman id 309473;
 Wed, 20 Apr 2022 15:57:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhCho-0006j7-RB
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 15:57:24 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f8fb64a-c0c2-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 17:57:23 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f8fb64a-c0c2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650470243;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=1s+jDJLjZkp14miwMVaWlVz5f1j3mQtfwGaoBi6XF1c=;
  b=KfCy87xATwLUImt0jrfYZfdWCcFit/NE9tGPK+vrHaK7gAyoGPyFGOVT
   peYG9K5IUyc3dkDvWZ3zC3rmQyTVNrEH7Mt7ZqkJG3w+Y73ZvlUDHoS7v
   E0bpQoPaKb12y90KV8wYjgtRL5GtQHbAtqV3fqScOo38O4vkKthVLb8eu
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 68925659
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:q96m3qMk6iJcOwzvrR1El8FynXyQoLVcMsEvi/4bfWQNrUpz3z0Fy
 2ZLCjuOb/fZYmfyeYwibI3npkNQ75LRm4dgSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NYw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 txOtLyWdxcVAIrKmsEWcjBVTTBBBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQTaeEO
 pREOFKDajzpTDJOY3Q+VakxkcO0g0jvQgF3uEya8P9fD2/7k1UqjemF3MDuUt6FX8JOhW6Du
 3nLuW/+B3kyFvaS1D6E+XKEnfLUkGXwX4d6PLe17OJwiVufgGkaEgQLVECTqOO8zEW5Xrp3F
 UsQ/SY/qLkow2aiRNL9Qh6QrWaNu1gXXN84O/Yh9AiHx67Q4gCYLmsJVDhMbJohrsBebSwn0
 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakcsTxYB4tTliJE+iFTIVNkLOLGxps34H3f32
 T/ikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzl/eXWOFyD1pWLCCYY6N4nny4KhRE7/MGzFto
 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUxRsd8rlxB71bmJNkNu28meC+FJ+5eIVfUj
 FnvVRS9DXO5FF+jdudJbo24EKzGJoCwRI2+Bpg4gjejC6WdlTNrHgkzPSZ8PEi3ySDAdJ3T3
 r/BL66R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+pdbAPUMr9mtvPYyOkwz
 zq5H5Lbo/m4eLegChQ7DKZJdQxaRZTFLcyeRzNrmh6rfVM9RTBJ5w75yrI9YY1195m5Zc+Tl
 kxRrnRwkQKl7VWecF3iQik6NNvHAMckxVpmbHNEALpd8yV6CWpZxPxHJ8VfkHhO3LEL8MOYu
 NFcIpvbU6UTEGmfk9nfBLGkxLFfmN2QrVrmF0KYjPIXJfaMmyShFgfYQzbS
IronPort-HdrOrdr: A9a23:BPNj3633t4d7XBeY8SRo5AqjBL4kLtp133Aq2lEZdPRUGvb3qy
 nIpoV96faUskd0ZJhOo7C90cW7LU80lqQFhLX5X43SPzUO0VHAROoJgLcKqweQfREWndQ96U
 4PScdD4aXLfDpHsfo=
X-IronPort-AV: E=Sophos;i="5.90,276,1643691600"; 
   d="scan'208";a="68925659"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Juergen Gross <jgross@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: [PATCH RFC] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Date: Wed, 20 Apr 2022 16:56:57 +0100
Message-ID: <20220420155657.32506-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

When CONFIG_GDBSX is compiled out, iommu_do_domctl() falls over a NULL
pointer.  It isn't really correct for processing of XEN_DOMCTL_gdbsx_* to fall
into the default case when compiled out.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Liu <wl@xen.org>
CC: Julien Grall <julien@xen.org>
CC: Juergen Gross <jgross@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

RFC, because this has implications across the codebase.  The tl;dr is that
case FOO:'s shouldn't be compiled out; we still know what the subops are, even
when the functionality is compiled out.

There are several ways to express this.  Alternatives would be:

    case XEN_DOMCTL_gdbsx_guestmemio:
        if ( !IS_ENABLED(CONFIG_GDBSX) )
        {
            rc = -EOPNOTSUPP;
            break;
        }
        ...;

but given my debugger series creating gdbsx.c, I was also considering:

    case XEN_DOMCTL_gdbsx_guestmemio:
    case XEN_DOMCTL_gdbsx_pausevcpu:
    case XEN_DOMCTL_gdbsx_unpausevcpu:
    case XEN_DOMCTL_gdbsx_domstatus:
        rc = gdbsx_do_domctl(d, iop);
        break;

when I can rework the callers of domain_pause_for_debugger() slightly, at
which point we can conditionally compile the gdbsx variables out struct
domain/vcpu, which wouldn't be compatible with the first suggestion.

Thoughts?
---
 xen/arch/x86/domctl.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index a6aae500a30b..1faa5a49ff3c 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -890,7 +890,14 @@ long arch_do_domctl(
         copyback = true;
         break;
     }
-#endif
+#else /* CONFIG_GDBSX */
+    case XEN_DOMCTL_gdbsx_guestmemio:
+    case XEN_DOMCTL_gdbsx_pausevcpu:
+    case XEN_DOMCTL_gdbsx_unpausevcpu:
+    case XEN_DOMCTL_gdbsx_domstatus:
+        rc = -EOPNOTSUPP;
+        break;
+#endif /* CONFIG_GDBSX */
 
     case XEN_DOMCTL_setvcpuextstate:
     case XEN_DOMCTL_getvcpuextstate:
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 16:04:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 16:04:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309481.525763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCo9-0000S8-LC; Wed, 20 Apr 2022 16:03:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309481.525763; Wed, 20 Apr 2022 16:03:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCo9-0000S1-Ho; Wed, 20 Apr 2022 16:03:57 +0000
Received: by outflank-mailman (input) for mailman id 309481;
 Wed, 20 Apr 2022 16:03:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aTZJ=U6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhCo7-0000Rv-HU
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 16:03:55 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7a382252-c0c3-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 18:03:54 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 2B6C51F385;
 Wed, 20 Apr 2022 16:03:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D46FB13AD5;
 Wed, 20 Apr 2022 16:03:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id S9/gMekuYGIERAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Apr 2022 16:03:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a382252-c0c3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650470634; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tVjg2mRYK4qiokg63C3YtQVzNHSP9U5XoeF6De8JgMg=;
	b=n4N/Ik897z38UAfLP7jabyF16X5oGYzuZ6fR6b0URMapBN8JFRaM4ATG0Rhl+CB/Y1WPoU
	z2dVx1XT6Je9hNn07AGWgdVqvP0E2Y5LgETbPkOvhQ/qayqpGJXu1PGJWXOb0Q5MXBOG78
	3JHwRRDxRozslUsp9MdNzPOASAM2EFI=
Message-ID: <70490620-16d2-6045-f83c-df65540025a8@suse.com>
Date: Wed, 20 Apr 2022 18:03:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH RFC] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
 Jan Beulich <JBeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
 <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220420155657.32506-1-andrew.cooper3@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220420155657.32506-1-andrew.cooper3@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------rWutLE0nMFnDzCxKho9GRhUZ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------rWutLE0nMFnDzCxKho9GRhUZ
Content-Type: multipart/mixed; boundary="------------O1FIbOsQ3rcXguZCxjpy8c71";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
 Jan Beulich <JBeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
 <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Message-ID: <70490620-16d2-6045-f83c-df65540025a8@suse.com>
Subject: Re: [PATCH RFC] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
References: <20220420155657.32506-1-andrew.cooper3@citrix.com>
In-Reply-To: <20220420155657.32506-1-andrew.cooper3@citrix.com>

--------------O1FIbOsQ3rcXguZCxjpy8c71
Content-Type: multipart/mixed; boundary="------------KHFjSC3gpBygPpKhaHAiLoDS"

--------------KHFjSC3gpBygPpKhaHAiLoDS
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDQuMjIgMTc6NTYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IFdoZW4gQ09ORklH
X0dEQlNYIGlzIGNvbXBpbGVkIG91dCwgaW9tbXVfZG9fZG9tY3RsKCkgZmFsbHMgb3ZlciBh
IE5VTEwNCj4gcG9pbnRlci4gIEl0IGlzbid0IHJlYWxseSBjb3JyZWN0IGZvciBwcm9jZXNz
aW5nIG9mIFhFTl9ET01DVExfZ2Ric3hfKiB0byBmYWxsDQo+IGludG8gdGhlIGRlZmF1bHQg
Y2FzZSB3aGVuIGNvbXBpbGVkIG91dC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBD
b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBDQzogR2Vvcmdl
IER1bmxhcCA8R2VvcmdlLkR1bmxhcEBldS5jaXRyaXguY29tPg0KPiBDQzogSmFuIEJldWxp
Y2ggPEpCZXVsaWNoQHN1c2UuY29tPg0KPiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh
YmVsbGluaUBrZXJuZWwub3JnPg0KPiBDQzogV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4gQ0M6
IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IENDOiBKdWVyZ2VuIEdyb3NzIDxq
Z3Jvc3NAc3VzZS5jb20+DQo+IENDOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0
cml4LmNvbT4NCj4gQ0M6IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0Bl
cGFtLmNvbT4NCj4gQ0M6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJt
LmNvbT4NCj4gDQo+IFJGQywgYmVjYXVzZSB0aGlzIGhhcyBpbXBsaWNhdGlvbnMgYWNyb3Nz
IHRoZSBjb2RlYmFzZS4gIFRoZSB0bDtkciBpcyB0aGF0DQo+IGNhc2UgRk9POidzIHNob3Vs
ZG4ndCBiZSBjb21waWxlZCBvdXQ7IHdlIHN0aWxsIGtub3cgd2hhdCB0aGUgc3Vib3BzIGFy
ZSwgZXZlbg0KPiB3aGVuIHRoZSBmdW5jdGlvbmFsaXR5IGlzIGNvbXBpbGVkIG91dC4NCj4g
DQo+IFRoZXJlIGFyZSBzZXZlcmFsIHdheXMgdG8gZXhwcmVzcyB0aGlzLiAgQWx0ZXJuYXRp
dmVzIHdvdWxkIGJlOg0KPiANCj4gICAgICBjYXNlIFhFTl9ET01DVExfZ2Ric3hfZ3Vlc3Rt
ZW1pbzoNCj4gICAgICAgICAgaWYgKCAhSVNfRU5BQkxFRChDT05GSUdfR0RCU1gpICkNCj4g
ICAgICAgICAgew0KPiAgICAgICAgICAgICAgcmMgPSAtRU9QTk9UU1VQUDsNCj4gICAgICAg
ICAgICAgIGJyZWFrOw0KPiAgICAgICAgICB9DQo+ICAgICAgICAgIC4uLjsNCj4gDQo+IGJ1
dCBnaXZlbiBteSBkZWJ1Z2dlciBzZXJpZXMgY3JlYXRpbmcgZ2Ric3guYywgSSB3YXMgYWxz
byBjb25zaWRlcmluZzoNCj4gDQo+ICAgICAgY2FzZSBYRU5fRE9NQ1RMX2dkYnN4X2d1ZXN0
bWVtaW86DQo+ICAgICAgY2FzZSBYRU5fRE9NQ1RMX2dkYnN4X3BhdXNldmNwdToNCj4gICAg
ICBjYXNlIFhFTl9ET01DVExfZ2Ric3hfdW5wYXVzZXZjcHU6DQo+ICAgICAgY2FzZSBYRU5f
RE9NQ1RMX2dkYnN4X2RvbXN0YXR1czoNCj4gICAgICAgICAgcmMgPSBnZGJzeF9kb19kb21j
dGwoZCwgaW9wKTsNCj4gICAgICAgICAgYnJlYWs7DQoNCkknZCBnbyB0aGlzIHJvdXRlLg0K
DQoNCkp1ZXJnZW4NCg==
--------------KHFjSC3gpBygPpKhaHAiLoDS
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------KHFjSC3gpBygPpKhaHAiLoDS--

--------------O1FIbOsQ3rcXguZCxjpy8c71--

--------------rWutLE0nMFnDzCxKho9GRhUZ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJgLukFAwAAAAAACgkQsN6d1ii/Ey+K
JQf9EOeQnheS7CA4o6YD8xWOSH/dH2PY8eIKzOwVm0wzSxvnFYYLyeZI43BNgec4rDVOvrt7zKWT
3cIcgCWZ2zFL+PZewcO2Eh4sIiMIQyJ5VI1RiDQr1+/6gBC6TJJDbFQcjqYzOOX3KeazOJ2ZN12T
jBzq9v2CCrxPxyw7/Zk/2XRy7Wy9uv23218H/LLSaKvYLWscYBdmLEjYfvRJSAJdyGxItlqmbINz
6KR3alGwI099mGevuL9BmEb0dsIIzV9dsYeCmDxDkVrMrpUn9cwmXnw/ZXEEGFkzCR4pHJAvjy8l
u7//Wqdu4UGiRHEiyPJ4dgepHAe80yGHZxX2TGM2Bg==
=2oou
-----END PGP SIGNATURE-----

--------------rWutLE0nMFnDzCxKho9GRhUZ--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 16:13:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 16:13:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309487.525773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCxI-0002BE-O6; Wed, 20 Apr 2022 16:13:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309487.525773; Wed, 20 Apr 2022 16:13:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCxI-0002B7-L3; Wed, 20 Apr 2022 16:13:24 +0000
Received: by outflank-mailman (input) for mailman id 309487;
 Wed, 20 Apr 2022 16:13:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tIrT=U6=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nhCxG-0002B1-Rv
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 16:13:23 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cae49f7b-c0c4-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 18:13:20 +0200 (CEST)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23KEiXxS019340; 
 Wed, 20 Apr 2022 16:13:15 GMT
Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta01.appoci.oracle.com [138.1.114.2])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ffm7csdfw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 20 Apr 2022 16:13:15 +0000
Received: from pps.filterd
 (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23KGCAGD026812; Wed, 20 Apr 2022 16:13:14 GMT
Received: from nam02-dm3-obe.outbound.protection.outlook.com
 (mail-dm3nam07lp2045.outbound.protection.outlook.com [104.47.56.45])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3ffm874wfu-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 20 Apr 2022 16:13:14 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MWHPR1001MB2301.namprd10.prod.outlook.com (2603:10b6:301:2d::38)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr
 2022 16:12:38 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 16:12:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cae49f7b-c0c4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=iR7t+QrE0HeqxKbKGoC5cY0rBqqhBGg66dUiGeZ+tXY=;
 b=H2vSo7Rh5UYtJ2hY6qXqtSL9D6hvH/RZYUBlxGjxGT2JyzIEec2ANWi4ntywSWZh5G/W
 xNeD1QnzPz15z3/uOpDUYMMhVlC2e5Wjlr9zeETwOcx6Pf4y0O8q+FYzw8GIpW7JaUg5
 qukjJhthpH/ehREqtFbM4BrA+Mnho0g5ZVVNoiMJePmnM+ATCLsoFt0pKwKM0+VQ2hWG
 8t2ElRqSfRPQMCxERHSFLsCxE0U9/KBw/1sHG0/bisyETqRU0gJjOt67lcOKY56xkN6Z
 XGYesSgaZxnGbGj1edgu5X2+xiVxwOVhg/vnxSqaLk0C47Zd+eLvF271ZC05ByS94WOb mg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N/V1iIf/gYPK8TxXOnWkzrOcFR+AKsbx+neUll5y4pA8TAbspk+N9l0egW9Jc9Fe6opdLLWQF/8hwydU4SVlDzvDAAo6RAZg7nM6l00IuFZHqpLwt3sVWAFcnbHoa8yTOaljJ72YT7Jj6LACHwSPloFdTdlIFA4YnAXHfWWiIiQWXeSHzLy1Aw0aibye4xqQIDm/cxqhRFoM/B6/tXto6IzRPkWNb8ey2NibEIGrB/K6onhDXLcH8CRkqlupvsL/5lUbpWTeB52DRkZzWx0j5CnkOW11yHAEHwx0ex61gsKJeTke7spQpReROrrzpYuUhPexeBG++J2R8rpQSgRq2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iR7t+QrE0HeqxKbKGoC5cY0rBqqhBGg66dUiGeZ+tXY=;
 b=NL5SiBlw2G7sedeHV8cjsewEjUqYWGH1xiT8VcRzz6k6du5o5HKVsZVMJwG8q3VbUSL1TOXkBkBe6cZhUTZFIG8vjb/ZX8iN3+tg5UNH7GHQhAgDH4UtsWMrCptBJW3ub0ov0CTSDgxSUkCDJB6sigBFrkT4qj4gC49K7q7y2hqu6nmREISnqtBzCIWQkfauFjaXy+R1FumFwQ1r38WtLqMFPz9AQmPWoIcTIlUQHH4USt4iTdX2JxUGvp4VX4PfskZ80+wHzTVy2n2Ey7Wbd7UED9DGNVj4lt1EfuHIYuEL7BAtLwhRoEFVMPTqR3ZUw3gf1OyKFf3FTUchjRsdpw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iR7t+QrE0HeqxKbKGoC5cY0rBqqhBGg66dUiGeZ+tXY=;
 b=fvVIELZrsdZPmbXlWnWk/v24QUe6QzfOsbY6L9yLX/iH7FW8JwuM/BmHYVFZDonQK5gpLIriNn6GK0WZptvG9IyqSPq4qCoMBiMzzUtJjVD9bRdjXe+7ByTttlHxKGfg/7fohIb4IL/g9xF2qaOP7Fz19WNUUi+CBv4yVY2zIrA=
Message-ID: <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
Date: Wed, 20 Apr 2022 12:12:33 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-3-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220420092503.11123-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DM6PR08CA0007.namprd08.prod.outlook.com
 (2603:10b6:5:80::20) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 21cdc698-1749-491e-ccec-08da22e896ff
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2301:EE_
X-Microsoft-Antispam-PRVS: 
	<MWHPR1001MB23015E6767FD1156B8E7E84D8AF59@MWHPR1001MB2301.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	ZoOkwagp4IOJLtypk33NrZZc3th+GEJWMGt3KgO1jWpXf9FQhxyg8HSlLSUKlRAWa9vNi0BxSfxPLomqSaLP9obs2kTVEuglq73ISmSKbU/UMxsm1l25u9bpp3PuL/5e2rGgqH0kaQKdxpovLXFXA9NxaEPKHGhiWTEx70Wy3F/TSZjpjHU2Xx/HY7uKwH+JM3tEsev+KRGZDiDeA986QOk1J5groJy/GvRKMPdmWplK7IippLSDTm3pooYsZhKcjt7fVbA1uX7LDha0SQmZYIDQzzXas0KxXSJ4m4Z/oQ4Of3Cql1J8q1znk2iKx4R2ePFJCFiOuthhuP4HTCsojK0A6p4ibxv8kNYStlK+8voR9doesrd0Sd2u68AAc9eLNuFoNZaalb6zV8m6fekHzTg9YEGOKcmiY/JGE6dSWQFvircZ5dD1jq1aBqcKLEAuRLB4yP/auAxgWRJVSTAxslV08aO7LfM5rhV4F+1mthbf8i++LOau8X0bR/LBjCXS50DKQcFJEaKTiwwvgIYyTJNSWo5w9oe87iq6xKvWpw0UNeLre6xNZpxAE0wNPSjD/7JApSci1K4O4gr4ZjiC3ThVcvfHVHvXBGAGyB+xvepFMs0c00cUdyFeIlS3/A2CURkIctFqi22MJp/ioDbpqkVXQwB/eoYFzf8n2ayH/jhRUoZzoTIiSfedeaMO35zddXWQ41KhGsdmJFwJoi23quzqzbhNOzL6RlcovxPpQCai42jjo4SFOtlH4DuGeJRl
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(44832011)(31686004)(2906002)(66946007)(8676002)(4326008)(36756003)(4744005)(2616005)(86362001)(186003)(508600001)(5660300002)(66476007)(316002)(6486002)(26005)(38100700002)(31696002)(6512007)(8936002)(66556008)(53546011)(6506007)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?b2lVUVNObFRHYzdRZWxjZEhZNzRUaEJURHdnWUJtc1J1NG9oZFluZ1ZJdHht?=
 =?utf-8?B?SXo3WFdFaFlIOHVyQnd1b0pOanpneW9GN1pmS3FBZDJKSFIwZndYUlFrODQ4?=
 =?utf-8?B?VHhzeERPQ3IzTjc1aHdCZVRIU2Z0VmhCUFJsaGZCVzhYTmRQMTdJaE9YUkVp?=
 =?utf-8?B?Z01pdEhXUFVsVVdlRkcxSExYekl2aGhuN213Z0ozaXpQeVllaGo1R0RZWmo1?=
 =?utf-8?B?cElkK2g5VlNWbkwrOHNpMlJhZ3RUb0h0U1NwYlBZOVZoT3VwandOeUk2andG?=
 =?utf-8?B?K2NmV1QwYks4YVpzZkVmY3Exc0owVlFQeVNNYlh4aDhOMWtXL0NHV2N3WHJP?=
 =?utf-8?B?bDBRWDdxTUVnT2Y2N09VNWJIMG9GWERCWERBbnIvMEV4YmxLaGNCMTRDRVdv?=
 =?utf-8?B?MlhDZzROandES1hoT2d4YWw5aVFheE1TbzdlK3dtWVFZajBreUcySER1OGlw?=
 =?utf-8?B?cnRDYVErdkxDaHZ4QWJkNmxNRGhFRmI1d1NEYnpVdjBnTWhnYUhJbDVaL3pr?=
 =?utf-8?B?bXZtUVZEU1Z2ZW4ycVA0OU9ZNk5pQWl5NW95bUtaRGpaazArY0RrbG9CRmpV?=
 =?utf-8?B?bHJqdXd2anVsc2VIY2phbEhBbEZMVlZ5UkpFR3pLeURTVTRKSm05b0VzZStU?=
 =?utf-8?B?RW5rWVUrVnp2QU9VZlJHT2hrUUFSMm9nQWVtRHU5NTJEWjl0NHI1ZkV1eTdQ?=
 =?utf-8?B?Y01ZcnBXcHVZNU9QdmgyRCtuckZkcElxc3B3YVUweWJPYXJ1YXZwUGhhTUFF?=
 =?utf-8?B?QmJkR29YbjI0RjBFV1BCY2pJTE0xVUtZVGQ1K2FXS2xhN2YzMzlrbS9MZGRZ?=
 =?utf-8?B?eTBQRzVhaTk0L3djOVoxRjFnMTdPVk9TODVKME1nVEdRMm1mSzFrQUVjcVZU?=
 =?utf-8?B?RmEvOW5pZ2RCSHk1SUo1VDk3YzMwUCtGOUhoeVlWK3g2c1RJemZXZjBKSXlr?=
 =?utf-8?B?ZVdzSFVqcmxidGM3QmZXVTkxTmlTaDdJMG9nOXkvc0cvSGcreXhzVnE1QS9S?=
 =?utf-8?B?R2hoRG9GbitCeThnM3RyNW81MGkzSGtWSmJzZWVJRE02c2M2NWJMWDdqYmx6?=
 =?utf-8?B?ZjUwN0x0dWtRRStiN2Yrd3dQTEZKczJYQlk0M1o1YzhHQzNQZXpkSENwZDFn?=
 =?utf-8?B?V3c2VDRvd1NGRGNFVHV6ZHJYbFpHS2dXUGdBNHo4bDFPRUEvekh5VXRaSWJ0?=
 =?utf-8?B?ZXdhaE5BS0hKeG9oMWxtc1U1NHhtOVJpOFZ6OXFuQ1NQb0pWRUpTVEtpbzBR?=
 =?utf-8?B?V2Qyb2E0aWdIeHNMZzlCdXdUNENGeFFFK0VnSzRkaitKTjI5akFlbHFBakRE?=
 =?utf-8?B?eW1BR2ZENmxCRktuNkVrR2RoWCtsUzVTUmNTcXpqRGZ0NTNadTZpa2U5a2J3?=
 =?utf-8?B?SDRZNVRZTUFsd1NPMkF1MlJQYTdKMllSb1FPWlJsZ2VuWU45UUVBN3FveDZJ?=
 =?utf-8?B?ckhvZ2EwZUUxYkUyNTVrS3RPeHVHQzVibDgvOXV4VHFGMk9NK2hpdzRyNnVU?=
 =?utf-8?B?bHJFTmREZ0RCOGVrK1VPem92cjZyM1p0NFArM2pMWHhwbkhDUTZqQitWUGpM?=
 =?utf-8?B?NzBhMmVyTDBPUGlqVUxuUlFNOEVsUHFqMjNkQ1h6a2t3ZzQvVitwaXV1OTdn?=
 =?utf-8?B?djl0ZXZTaGl5N3RnQlFiZzUzVTFkVTZWa1lMbkNXVVhxN0R0djVOc2kxazJV?=
 =?utf-8?B?aCthMFN1eVR2bkxveU9rZ0s2dUZ1MElpd0dUTUY5YllPVWp0NDVDNEl2TGtZ?=
 =?utf-8?B?cFlVSzdiNzI3clZCQW5nV0lvb2tzSDk0VXVMZHdnYk5GV3RORVp3RjVyc3k0?=
 =?utf-8?B?OVA5RUJYWDJYSEdOdGkyaG5pc1gvYUZ3NkxJZm0vZlVwNE4vYk4yLzlBVTI1?=
 =?utf-8?B?OVZndFpQYitPSVg4eFFtN0hkdTBPMTlZOEx2bVlRcEIwUXptcTZsYVVkYmpI?=
 =?utf-8?B?bmJQbVYwaGxHYi9JR0ZQZHkrNmhMd0Z2SytRTWRQTVBPRWtqOFJ1UlIwTkE2?=
 =?utf-8?B?VWROcmM4WDdKbTI5YlNmN0ZzcUcwZ3NGNTE2bHBDWXR3R245eWVsS1hQbisz?=
 =?utf-8?B?S3hrdnRacGhTcHNoZHFmTFY1UU92OG8zN3NwR0hvbXZpUExMK0tQTnZBaVZU?=
 =?utf-8?B?MUwrV3FtYzcxTE5RZk16MGtwWU9IT2dTV2t0QnF4VXZ5MU1kWTNkUHg4SURP?=
 =?utf-8?B?Z3haKzhhRWg3bEZ2NkpNczZOenB4bm9ORXBHZjVOa21JWmN2TzJZNzRrWDVF?=
 =?utf-8?B?Q2tKYkJEajBJcWw1b1U4Zm9zVzAwc2VzOXB0a0Jra09CNmRZNXNIQ0FFeWxT?=
 =?utf-8?B?WFlmM3h2ZVdIVm54ZnE5YzJkTUZ1MG9lSnF0ZFdRbWY4SFdyNDhXendkNzFO?=
 =?utf-8?Q?HQO3Wr0c7aEZSvbQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21cdc698-1749-491e-ccec-08da22e896ff
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 16:12:38.8699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: evgORJpYMo0PWFoFJ5dJuArcYc6+AH7yY88q0hKzDeUmdSR9DTYqdb9cQdJTNR9ewK2wNz3BkU2NK6J5uOaY/IaWwmC/vPFyA/RyAY5TgAs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2301
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-20_04:2022-04-20,2022-04-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204200097
X-Proofpoint-GUID: DzTvsBdnHLfWy6Tgc-d-yrQb3DCjs0om
X-Proofpoint-ORIG-GUID: DzTvsBdnHLfWy6Tgc-d-yrQb3DCjs0om


On 4/20/22 5:25 AM, Juergen Gross wrote:
> @@ -569,7 +645,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
>   	wait_for_completion(&pending_req->tmr_done);
>   
>   	err = (se_cmd->se_tmr_req->response == TMR_FUNCTION_COMPLETE) ?
> -		SUCCESS : FAILED;
> +		XEN_VSCSIIF_RSLT_RESET_SUCCESS : XEN_VSCSIIF_RSLT_RESET_FAILED;
>   
>   	scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
>   	transport_generic_free_cmd(&pending_req->se_cmd, 0);


You also want to initialize err to XEN_VSCSIIF_RSLT_RESET_FAILED.


And also looking at invocations of scsiback_do_resp_with_sense() I think those may need to be adjusted as well.




-boris



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 16:14:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 16:14:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309491.525785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCxz-0002dl-2U; Wed, 20 Apr 2022 16:14:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309491.525785; Wed, 20 Apr 2022 16:14:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhCxy-0002de-VU; Wed, 20 Apr 2022 16:14:06 +0000
Received: by outflank-mailman (input) for mailman id 309491;
 Wed, 20 Apr 2022 16:14:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tIrT=U6=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nhCxx-0002B1-4w
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 16:14:05 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e5366c06-c0c4-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 18:14:04 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23KFV2Y5019231; 
 Wed, 20 Apr 2022 16:13:59 GMT
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ffmk2skds-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 20 Apr 2022 16:13:58 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23KGBnD6037506; Wed, 20 Apr 2022 16:13:57 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2107.outbound.protection.outlook.com [104.47.58.107])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3ffm86wyhq-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 20 Apr 2022 16:13:57 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by CY4PR1001MB2280.namprd10.prod.outlook.com (2603:10b6:910:3f::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 16:13:54 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 16:13:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5366c06-c0c4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=ooB2RxGWxeLyDbDD9GGB2TVmqG6+Hn1n/fSj2kAWyzo=;
 b=RdCy5JvJTjh+YeoBhNdi2Q7+JbqwrTO9dS8ggTN6OEgJA1BLu8BFaXJU5Rp9YzAYR8w5
 WmIEcIGYbM6j6cuL8nYCnQJxQ9jj32WCSo6MOeLgVZCfAyjP8iNt7xL0a9CvQBOfXxGO
 ppx5hZMMl56WQn/HySLPSnrRcK25110ZF2zlhF0S+nt4uHuul12v1bi4LQYqtdmiSC8j
 3j5m89ElRgETbcYmlzX7NqNlyQfRA4zdm2qgoVVkNmi96T0PGxBBirS7iVkdmYA2LZkQ
 QbAf6m4RQVIqGveJEROuZYDuX2E1SRAvxslUGRoWuMSO9prUUSDsfPUT0jTNfw4d3dnz wQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D3D0nmy1RSKDalm8Wddrwu2EABiHObKIMhJCFvH/vPvkrSswH2MbyhdDvAxc3YwXw31TCQKLnnwu72B6BH+4/VdOYwUnbax3Zht7AYACbL8e181w630G4GsUapfMW1P7AbCQ1TiZwexD2WsYWUuK2YSz3IjCF6WyngN1uogqiejMascLOk3h4Zy91Vm3n290exTQmbe43OWLPIksQnaGbk/RALKj6mJemDnDiDTEXjy+EzH/XlMbshpvWFUQMSizu6Y7wZNbUO/mSDirQsx7pie+nXl5IGXsM0EOMRVr0rQgCG484FM9mWOVi0kSCK0/lyypnCuA4AcLuV1WMolCZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ooB2RxGWxeLyDbDD9GGB2TVmqG6+Hn1n/fSj2kAWyzo=;
 b=Noq3Ic9PSdUJCtLKrNs3ALx2uCOxFP+cU9oNUgjrRKtHy48J32e0kHSgaq5BCG7hcoxah8MMt5IcktE3FhFgpVY1fe0EspTbfC5Nhwqn4720aV13NTkPg2GuYm2YkNu9IuSuu/J6+8a7x+0pUVv/C7PYlbHXz3lz61+oIdaqtqCO2DDdpRnQMpBkiY52eEQw4FmDNLZYrUWCphvrgK2FNu1WoF4eMQ1t7u3jBrUgsxAhzeyh5RQeH7jVUOUp9N45knW3uUg6DykkYHYOydwUt7YI0uSP0Rxo3DBtPy35RevsHEP4TZrtBtqjqljz9Or+YdIndIF+KlwiurXgTSqvFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ooB2RxGWxeLyDbDD9GGB2TVmqG6+Hn1n/fSj2kAWyzo=;
 b=N+3b33zh6ONqRzDbjvolbZ+Lrayq0/L0i3s0qJ8mL9X2xAWhOkydZkGPpa5lIXqNZ+D9v4V0cuy4+hsl8wDuF5JX1LJpnsLaF7mraES0wEuLHmZ3BUS+TPqRPRsrttwcL7EkZco8EIjrK3SE0kRY6bKmoIb8KYXZ1Em0U+ASUlc=
Message-ID: <00c1cd38-5164-edfa-6c47-606803629dcf@oracle.com>
Date: Wed, 20 Apr 2022 12:13:50 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH 4/4] xen/scsifront: harden driver against malicious
 backend
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-5-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220420092503.11123-5-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DM6PR08CA0016.namprd08.prod.outlook.com
 (2603:10b6:5:80::29) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 93297cad-a2bd-45ea-b52b-08da22e8c428
X-MS-TrafficTypeDiagnostic: CY4PR1001MB2280:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR1001MB22801B29BE9CCD03D3063BD58AF59@CY4PR1001MB2280.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	UnKnIN4sN9OHsN+J1rLH6eA1YJeqUBIph0BPAr5j5W9lstEPoQST3wks0ykq4cD/TPqkpp2hteUEs4Kn5MuUvtWwrZocpoYcttnAu0sH6beIwVDI3QzihVhFdMzZkEPGRWNY9qPWIQu6sK7KRk6I5WA/l+e2xIesFn9Zyq3ltWKXOfTeEARfh4+8ZsfDqgvlDBqumsVV+Wv4rpQtDkK46q7/Vnvbewx85INHGcv6ZBa7JCJccRFzxKMz7smrPFSE7nWiHcInlYuJiQEwUeqFE/1eM5pL8DhKzWoLzOWMnCUZAsrnU+bJQpHLvEo884ofqFiJtXm4J/envlADWy37CITlOg6vDyZTFJhbSTmsCXylVpmhNFhsev+E6N+ovI3nQkz4UFdA4YEmflvjP54pGtM8JFzL0tUOkSWfxN/3Z0R/2nIyHIjM3E1hrDnuP/CvbwYAOB20+vkjhbYw3LX1la57M4nUDUS94t9cU/wC8uRg1LvUDylyYW6NNz7IQ3igTeB88isjnVaL+UsEOtXJqnPYTT6HrE53rnEgTIOrbfTq4v9KhXGc4IDKue6luKFWhibjfZRIRTzo7Os9oyudHO3FBGcnHY/cE4XZ9tAk2Yz7/PNyf4S77Rt/bRQzgIFIEQEU/dla+hRowZItJaFhRRVB3dkGtQvdCY355906Lo0gkI2y1etyUeR+PfmVZIHKRgAblxeWMQsEi1tfmE1oPJ8qnjHakCdy/2A7r0V/n8kc2W2ytL4O9WUIJMt//NVT
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(4326008)(6666004)(83380400001)(6512007)(6506007)(53546011)(5660300002)(316002)(8936002)(8676002)(44832011)(38100700002)(31686004)(26005)(66556008)(508600001)(54906003)(107886003)(66946007)(31696002)(86362001)(2616005)(36756003)(6486002)(66476007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?YitVZUszQWxGdFBibUFsVzFqK21BQ1dJT0gyZjJwTjRHTVBYeWhmdFYxdlJ3?=
 =?utf-8?B?cnlCRXlXOUlPdlhGYm9NcGoveWtFVHM2N0lsRE5lMEV3M3JTdllvODYzV2wr?=
 =?utf-8?B?eUJ5ZVpjS3hHOERmTG5UY2dRQjlMN3c1UnhZWmhoOS9rQ3d2NXlVdG1ZNnNH?=
 =?utf-8?B?aEdNdnBjcThEUWRiVHE3bW5KclRkTks2VXVobVZKVHNNek9wYVB3SDZuaGg1?=
 =?utf-8?B?OFEzK09qL3c2bTlyejFtZk5YdDQrUm9XOGt3endsa1diakFZQVowemRRQ3JE?=
 =?utf-8?B?eFBmK0NXUU9zRTFTc3pvM2lDL1Rvakw0aitRellPOTJsaTZjQ1NFd1hFNHRj?=
 =?utf-8?B?d3dwQnh6eUwyK0lLRkJhaDF6Rm00bTJrcnFXWUpMSHJRRTJBalFJR0phUVFh?=
 =?utf-8?B?NlhnRXRQNlo4RzZsV3dHQ1lHTlR2dmVzZHVNV09CeXZKUkFrdFJzL1FycDJk?=
 =?utf-8?B?d0ZMOGN5SzB6bDVMUXR5VGEwQTdBT1pqVUQzWlYwd3JubzF0Q3d3WlY2MXJE?=
 =?utf-8?B?cTlTdEplZGlUUVY5SnQvSWhzTFBkWmRZNnMzSmFnVVhzbFRSenJNUG5WeGJF?=
 =?utf-8?B?WlI0TGl2dGlkWWQ2OGM3ekNycHZBWDY3bzBuenRaeGtqVUQ4UEVsWXpzYmcr?=
 =?utf-8?B?YmlVQ2l1RkFpQ0NvZHNLM1IvNnJXRHJDNHRPNllleVQyTUNqaTByQzBnd0VV?=
 =?utf-8?B?OG82dUxwTmVyejlrL0RKVDVIaWROMzZMZEhQekhjcVhsenZ2TldmZlk5U1hr?=
 =?utf-8?B?THFxbGVWTzNubU1JNVo4YWI4emo3bHZuemxPOEl0QUFOdWxYaS85RWkyWGNu?=
 =?utf-8?B?S3pTUXR0SEJTVTNQUEJLckVKWmJDcXZ0VVc1OEVaR1Q5enFrQmVtdGg4RmR3?=
 =?utf-8?B?YU0vZHQ4K2l5cU8vOWZNNGxTbFplRUFKUDBTVGR2ME94VzU1S0w0eWlVT1J0?=
 =?utf-8?B?cmZyWENxaUlIVzVFYU5aWUwwSWNTOEFxalBwbDU5cGVPRFlCcDNoVDQvbDBQ?=
 =?utf-8?B?VTlsVDFaRDE5OUd5VnRraGE4WnNYUEtXMXBXVUtzNDFsdVY4SzViSWRaM2U1?=
 =?utf-8?B?a3Z3NDlPMXg1eWJMd1liUW5kY0M0eFJPM1hRb01ubS9tSTVObVNVeXRJSDZq?=
 =?utf-8?B?UnIzMXlsUlc3VjJxOWlnbjRrV1JmaWFsOWVIdGxtWHljbHhaWjZvNnlCZ3Bn?=
 =?utf-8?B?SjZYTk94QnIyTkpjV0piTHNOdjhEMHZqQjdlakxCYWQveW1nMGRpWmI5RUdi?=
 =?utf-8?B?clhRMm9nVG1WRWhTWHFwVllyQWhaNittamJkWENxanEvL0xqWmhpR253Nndk?=
 =?utf-8?B?QmdwSTRwRmhCZjZ1K2tMM0VYVGZTNnc3SU5hbVJyRlljL3UyWWpwb01HRHlV?=
 =?utf-8?B?ZEpmWHQ0ZVY0S1FhZlRWVU1pYXR2aVNwU2JlRzJudVZwSGZzMktGVVFSRVND?=
 =?utf-8?B?enpseXY4YXJ0RllKelJnT0JpM0FUUkZadVdub3V2V3dhbzY5SWVRNS9OSExs?=
 =?utf-8?B?Q1dWVFJaNVlKQ1Y5akp5L0g0c3d6OVF6UlVIRXhINWVINEpyVG5WeTE1M3V1?=
 =?utf-8?B?RkRVVUU4L1FJeHNXekJ1TnYxanZRZElWQTludndXOFFQNHdUWlNycHFNTTY2?=
 =?utf-8?B?L0lOYmRaNGM4eFZpUVNSUGxETExpNTBMbHNhTnFQU29PRjEvS2FUNjhzMU5D?=
 =?utf-8?B?V1lDb3lvZzhjcFpxdnlQWGlJaUxRU0puTnhnTnhmNS85TlpTRmoyWVNOYTNN?=
 =?utf-8?B?aWhRd2g0Sm94dzM0aWhnWjVQcHFsL0gxYUxNam8xem9GVXVNU2tST3JFR1FD?=
 =?utf-8?B?K055RDB0OE1oZlY3eTFUa2oxazhVMzJnZUdTbWk5L0NSS0U3ck43YTVLKzBY?=
 =?utf-8?B?U2hqTlZ5YWtnMEF4SVU1T2syS0Z0eVBnNFR2QkN1RGUwdHdIeHFwZlZBbmdV?=
 =?utf-8?B?bkdnOFRRbWFGL082SGJUOU54b2QvMnNXaGNHbkVXY0lHaFpkMjR2OVpZYThT?=
 =?utf-8?B?VUJTdXMxSHJaU1BBOUk1QjZ1MXNrVS9SNGJSK1lmYkdiWTFKaGduUmZaQkl1?=
 =?utf-8?B?YVJRNlM2MEY4VXdUWDdaVGxTZmNVZm5qR0ozQ3RnNHp4MjVYMHhNZlZscFBt?=
 =?utf-8?B?L3BmeXM5cklCdHpBOXpIUi9BN3duZ3NZbFB6b05Gb3pmYVc3eDBMMWhTQTNu?=
 =?utf-8?B?S1RqWjBLNm9teU5jNUY1REduNlFJb0pvaDAza3N5eU1lYlBCK2JSbUl1ZG1Z?=
 =?utf-8?B?SWs3U3JnNlF1VE56VzNnZ1dnTFJxMmZiUEloTmZaQ3VYT1VVY3ZHU2Zmcml4?=
 =?utf-8?B?Z1g0L2xMTWtMZTNQelloTitCZ3pzdWtCcU5MeGRYOVEzYjMwZmYwSHFuQy9u?=
 =?utf-8?Q?UpQFlkVdTII62WuU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93297cad-a2bd-45ea-b52b-08da22e8c428
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 16:13:54.6199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ja2wW0udeLSZSj/0MDSGYw0Dn5coA43XcPww7sB+bvvEWIVAAx93MJMfE/TT8lgRQr0G4mWuLs4bd4Swd9UKjRmX+vCrT/15ckZ6RqWpjRQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2280
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-20_04:2022-04-20,2022-04-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204200097
X-Proofpoint-GUID: ci7Wv1xx3pzIbiV1hcxAvsA6Hu_Dne3e
X-Proofpoint-ORIG-GUID: ci7Wv1xx3pzIbiV1hcxAvsA6Hu_Dne3e

Just a couple of nits.


On 4/20/22 5:25 AM, Juergen Gross wrote:
>   
> -static int scsifront_ring_drain(struct vscsifrnt_info *info)
> +static int scsifront_ring_drain(struct vscsifrnt_info *info,
> +				unsigned int *eoiflag)
>   {
> -	struct vscsiif_response *ring_rsp;
> +	struct vscsiif_response ring_rsp;
>   	RING_IDX i, rp;
>   	int more_to_do = 0;
>   
> -	rp = info->ring.sring->rsp_prod;
> -	rmb();	/* ordering required respective to dom0 */
> +	rp = READ_ONCE(info->ring.sring->rsp_prod);
> +	virt_rmb();	/* ordering required respective to backend */
> +	if (RING_RESPONSE_PROD_OVERFLOW(&info->ring, rp)) {
> +		scsifront_set_error(info, "illegal number of responses");


In net and block drivers we report number of such responses. (But not in usb)


> +		return 0;
> +	}
>   	for (i = info->ring.rsp_cons; i != rp; i++) {
> -		ring_rsp = RING_GET_RESPONSE(&info->ring, i);
> -		scsifront_do_response(info, ring_rsp);
> +		RING_COPY_RESPONSE(&info->ring, i, &ring_rsp);
> +		scsifront_do_response(info, &ring_rsp);
> +		if (info->host_active == STATE_ERROR)
> +			return 0;
> +		*eoiflag = 0;


*eoiflags &= ~XEN_EOI_FLAG_SPURIOUS; ?


We also use eoi_flags name in other instances in this file.


-boris


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 16:58:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 16:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309498.525795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhDeM-0007hN-Fs; Wed, 20 Apr 2022 16:57:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309498.525795; Wed, 20 Apr 2022 16:57:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhDeM-0007hG-Ct; Wed, 20 Apr 2022 16:57:54 +0000
Received: by outflank-mailman (input) for mailman id 309498;
 Wed, 20 Apr 2022 16:57:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhDeL-0007h6-9R; Wed, 20 Apr 2022 16:57:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhDeL-0004WK-61; Wed, 20 Apr 2022 16:57:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhDeK-0007RB-Jc; Wed, 20 Apr 2022 16:57:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhDeK-00068t-J8; Wed, 20 Apr 2022 16:57:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iB8wavRZPSIc6iy/8mgUOxkjXJ+t0/8TgRYML9+WdC0=; b=vBLsRscSCjjIohpHtN+2fE+XCZ
	h4qDrbNBqRHpMPYW0JEtH1Ous+6EpTRQZho2DyObW2YPj5fgGM+vnPKSi+AD1iUcEcfAvkooojPne
	y/4+GIRb7pxIcSQT134xPsZnehRQxbotYdtItLcmjcI9NDUgNXKx4pyxr3koJ7calqPE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169560-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169560: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=559089e0a93d44280ec3ab478830af319c56dbe3
X-Osstest-Versions-That:
    linux=b7f73403a3e922c20bb278ba3cfcc3c61930d82a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 16:57:52 +0000

flight 169560 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169560/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169545
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169545
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169545
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169545
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169545
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169545
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169545
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169545
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                559089e0a93d44280ec3ab478830af319c56dbe3
baseline version:
 linux                b7f73403a3e922c20bb278ba3cfcc3c61930d82a

Last test of basis   169545  2022-04-19 17:41:16 Z    0 days
Testing same since   169560  2022-04-20 06:47:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>
  Song Liu <song@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b7f73403a3e9..559089e0a93d  559089e0a93d44280ec3ab478830af319c56dbe3 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 17:02:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 17:02:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309507.525807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhDj4-0000xj-9w; Wed, 20 Apr 2022 17:02:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309507.525807; Wed, 20 Apr 2022 17:02:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhDj4-0000xc-4x; Wed, 20 Apr 2022 17:02:46 +0000
Received: by outflank-mailman (input) for mailman id 309507;
 Wed, 20 Apr 2022 17:02:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CUyO=U6=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhDj2-0000xW-NW
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 17:02:44 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b09963ae-c0cb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 19:02:43 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650474155979567.7828546115068;
 Wed, 20 Apr 2022 10:02:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b09963ae-c0cb-11ec-8fbf-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650474158; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=S4dDeJGdViW9gJkSXaXTBfY5V3tnpROHw8CNZvpcy6hlzDaludOzV5tI/RgzFuyBBSbAsY3gQTt23PVnm6lSv4PFoXrdwdKqLZps4ds6yidcBQ8amVav9q4WWfNLNeTEP6iAGLQb828y1lGW4aBtQ1aMGRILEhxj/q78/2TR9Hc=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650474158; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=+AF6PHlDwTTK1l0rIrxR4mBCwLUshmplkl+DA05lAQ0=; 
	b=CXhvOhMbUk3+NWyi0qCIRThAWpUQfZCrBJBa7BjvPeCHDq+mm0HOPLJjPXcZdxfAk9d1wHTOK8a9LCgNxvx8r2n1Vy+JA6TMjLBKBV9HNNtjmUjApEt5MOD+iUv89Y1UsxWDxVHjf8QzYb1H8WiOSu/h3rtUZuUe4jqibAGSxSI=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650474158;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=+AF6PHlDwTTK1l0rIrxR4mBCwLUshmplkl+DA05lAQ0=;
	b=NTfXWpTa4sKnp3m07qh4M6HpRFhfGH1uO7HUGKbDnAQfEXYaBmpUDg1umOC0y7lc
	8sMTkOdEfoDsfT9m/fbnPeFWZfzZOUx4rVdT6ICe+8fnUmt03OZG4aW6HkFNq/Hl7jR
	Acx8U+0viRtirMfrGrjwaqs9F53FDWlv0RPgmDbo=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	scott.davis@starlab.io,
	jandryuk@gmail.com
Subject: [PATCH 0/2] Adds starting the idle domain privileged
Date: Wed, 20 Apr 2022 17:04:05 -0400
Message-Id: <20220420210407.18060-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This series makes it so that the idle domain is started privileged under the
default policy, which the SILO policy inherits, and under the flask policy. It
then introduces a new one-way XSM hook, xsm_transition_running, that is hooked
by an XSM policy to transition the idle domain to its running privilege level.

Daniel P. Smith (2):
  xsm: create idle domain privieged and demote after setup
  flask: implement xsm_transtion_running

 tools/flask/policy/modules/xen.if      |  6 ++++++
 tools/flask/policy/modules/xen.te      |  1 +
 tools/flask/policy/policy/initial_sids |  1 +
 xen/arch/arm/setup.c                   |  6 ++++++
 xen/arch/x86/setup.c                   |  6 ++++++
 xen/common/sched/core.c                |  7 ++++++-
 xen/include/xsm/dummy.h                | 12 ++++++++++++
 xen/include/xsm/xsm.h                  |  6 ++++++
 xen/xsm/dummy.c                        |  1 +
 xen/xsm/flask/hooks.c                  | 21 ++++++++++++++++++++-
 xen/xsm/flask/policy/initial_sids      |  1 +
 11 files changed, 66 insertions(+), 2 deletions(-)

-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 17:02:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 17:02:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309508.525818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhDj9-0001FW-Fy; Wed, 20 Apr 2022 17:02:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309508.525818; Wed, 20 Apr 2022 17:02:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhDj9-0001FP-Cb; Wed, 20 Apr 2022 17:02:51 +0000
Received: by outflank-mailman (input) for mailman id 309508;
 Wed, 20 Apr 2022 17:02:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CUyO=U6=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhDj8-0000xW-BO
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 17:02:50 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b46a4f18-c0cb-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 19:02:49 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650474158293185.54717793821146;
 Wed, 20 Apr 2022 10:02:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b46a4f18-c0cb-11ec-8fbf-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650474162; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=cp8o60aNK+qXKZNp6V3qPn+ET9lHf/J6rPUtLwd+WQXDlbX2lGYcKpD7GGCi4Vj4mRR6KgzgQN8p3oTpeaU5jGe0QHt2npXjNQ3noO3EMIP0zAdRR+dRk5i+Sm77cngzqvmrnNOS1JLvi6nFl2WQzEnPYMi9OeBhPtlttMu6jgM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650474162; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=Y5VK/nn1NuDaRru49lx3xM09xnkVW4XL3YTrgNudhT0=; 
	b=fgMERb0mNbEE4pPJewta3ZKnDsoOY+Omf7GrYwjjEX8J37XLorqczWJW8cmHOLsBFkMyC7IAi4P2f8bwZENhvsybp3h/Sn1z1sdHHDv4xoSZwtR7U2ZwppJAilgQBFtclzTD3bNeNwC1+pf63DlckKWpaTgi2XKQYz2hnRG8SkM=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650474162;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=Y5VK/nn1NuDaRru49lx3xM09xnkVW4XL3YTrgNudhT0=;
	b=ZXVpO3VTCyG3as2hfQhB324EdOezED4HtRzBuFlXa+zDdfZNlA8bSL+LBfT0EdLN
	6Js82YMGpYebDiS8KEA8SvhkctGDkN4l94taUGx55WCi73zgdJKvDA5wWyTMoO97QXK
	CWN7z0YLRHNxxaDFNtNMrvWDAVKWYQy9DPuagBOk=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io,
	jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: [PATCH 1/2] xsm: create idle domain privieged and demote after setup
Date: Wed, 20 Apr 2022 17:04:06 -0400
Message-Id: <20220420210407.18060-2-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20220420210407.18060-1-dpsmith@apertussolutions.com>
References: <20220420210407.18060-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

There are now instances where internal hypervisor logic needs to make resource
allocation calls that are protectd by XSM checks. The internal hypervisor logic
is represented a number of system domains which by designed are represented by
non-privileged struct domain instances. To enable these logic blocks to
function correctly but in a controlled manner, this commit changes the idle
domain to be created as a privileged domain under the default policy, which is
inherited by the SILO policy, and demoted before transitioning to running. A
new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
type to demote the idle domain appropriately for that policy type.

For flask a stub is added to ensure that flask policy system will function
correctly with this patch until flask is extended with support for starting the
idle domain privileged and properly demoting it on the call to
xsm_transtion_running.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/arch/arm/setup.c    |  6 ++++++
 xen/arch/x86/setup.c    |  6 ++++++
 xen/common/sched/core.c |  7 ++++++-
 xen/include/xsm/dummy.h | 12 ++++++++++++
 xen/include/xsm/xsm.h   |  6 ++++++
 xen/xsm/dummy.c         |  1 +
 xen/xsm/flask/hooks.c   | 15 +++++++++++++++
 7 files changed, 52 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..763835aeb5 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -1048,6 +1048,12 @@ void __init start_xen(unsigned long boot_phys_offset,
     /* Hide UART from DOM0 if we're using it */
     serial_endboot();
 
+    xsm_transition_running();
+
+    /* Ensure idle domain was not left privileged */
+    if ( current->domain->is_privileged )
+        panic("idle domain did not properly transition from setup privilege\n");
+
     system_state = SYS_STATE_active;
 
     for_each_domain( d )
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 6f20e17892..72695dcb07 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -621,6 +621,12 @@ static void noreturn init_done(void)
     void *va;
     unsigned long start, end;
 
+    xsm_transition_running();
+
+    /* Ensure idle domain was not left privileged */
+    if ( current->domain->is_privileged )
+        panic("idle domain did not properly transition from setup privilege\n");
+
     system_state = SYS_STATE_active;
 
     domain_unpause_by_systemcontroller(dom0);
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab678181..22a619e260 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
         sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
     }
 
-    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
+    /*
+     * idle dom is created privileged to ensure unrestricted access during
+     * setup and will be demoted by xsm_transition_running when setup is
+     * complete
+     */
+    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
     BUG_ON(IS_ERR(idle_domain));
     BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
     idle_domain->vcpu = idle_vcpu;
diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index 58afc1d589..b33f0ec672 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -101,6 +101,18 @@ static always_inline int xsm_default_action(
     }
 }
 
+static XSM_INLINE void cf_check xsm_transition_running(void)
+{
+    struct domain *d = current->domain;
+
+    if ( d->domain_id != DOMID_IDLE )
+        panic("xsm_transition_running should only be called by idle domain\n");
+
+    d->is_privileged = false;
+
+    return;
+}
+
 static XSM_INLINE void cf_check xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
index 3e2b7fe3db..a5c06804ab 100644
--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t;
  * !!! WARNING !!!
  */
 struct xsm_ops {
+    void (*transition_running)(void);
     void (*security_domaininfo)(struct domain *d,
                                 struct xen_domctl_getdomaininfo *info);
     int (*domain_create)(struct domain *d, uint32_t ssidref);
@@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops;
 
 #ifndef XSM_NO_WRAPPERS
 
+static inline void xsm_transition_running(void)
+{
+    alternative_vcall(xsm_ops.transition_running);
+}
+
 static inline void xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 8c044ef615..66f26c6909 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -14,6 +14,7 @@
 #include <xsm/dummy.h>
 
 static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
+    .transition_running            = xsm_transition_running,
     .security_domaininfo           = xsm_security_domaininfo,
     .domain_create                 = xsm_domain_create,
     .getdomaininfo                 = xsm_getdomaininfo,
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 0bf63ffa84..51c896d9f7 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -186,6 +186,20 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
     return 0;
 }
 
+static void cf_check flask_domain_runtime_security(void)
+{
+    struct domain *d = current->domain;
+
+    if ( d->domain_id != DOMID_IDLE )
+        panic("xsm_transition_running should only be called by idle domain\n");
+
+    /*
+     * While is_privileged has no significant meaning under flask,
+     * set to false for the consistency check(s) in the setup code.
+     */
+    d->is_privileged = false;
+}
+
 static void cf_check flask_domain_free_security(struct domain *d)
 {
     struct domain_security_struct *dsec = d->ssid;
@@ -1766,6 +1780,7 @@ static int cf_check flask_argo_send(
 #endif
 
 static const struct xsm_ops __initconst_cf_clobber flask_ops = {
+    .transition_running = flask_domain_runtime_security,
     .security_domaininfo = flask_security_domaininfo,
     .domain_create = flask_domain_create,
     .getdomaininfo = flask_getdomaininfo,
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 17:03:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 17:03:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309517.525828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhDjj-0001yS-Oy; Wed, 20 Apr 2022 17:03:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309517.525828; Wed, 20 Apr 2022 17:03:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhDjj-0001yL-Lv; Wed, 20 Apr 2022 17:03:27 +0000
Received: by outflank-mailman (input) for mailman id 309517;
 Wed, 20 Apr 2022 17:03:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CUyO=U6=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhDji-0001aR-PC
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 17:03:26 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ca307303-c0cb-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 19:03:25 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650474160905460.02002794635507;
 Wed, 20 Apr 2022 10:02:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca307303-c0cb-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1650474163; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=CTxWLgCeuWnLv2VOCcXmi09a880v9ZBTFREtRMNRReO5Ru90scD+dp9jKce9+YVRuetMrRG0+e9q7mr+ehzCqdg1+HDOZk4fRp4fimRwl6I7iJIOvlbR+rbglj/vZrmGpE5Tkqy3AeYMxLBRdE98XROonvOhGNvoBbEjZb4VEeo=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650474163; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=TymRc8V7wVKkFF8i7BKHRUOSpUbifIpbb54+vNPswqA=; 
	b=RzW18awQrx3YbGuvUIdfikJQfzRSHreOPJFzXcRy4HGLjio/TCmYPpIgdnbl3+zoVA9LBEswyI50xMqp0u/QYimSn+aNHt0oeF42+ILKp1QnL38sk71MhztuyciiD2/L5wA9G48/+yF39D+aaB6miSCMPSEEqVh4GuNKdjoe5lw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650474163;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=TymRc8V7wVKkFF8i7BKHRUOSpUbifIpbb54+vNPswqA=;
	b=h/P7V63m83DhKw/S5tRl3bFWX8Tps4+Zua/m7YoXu3ixN88k1Sa9NDZQ0rGRFsQR
	Gd4l5QuEDcY1ItX9au60TvwQPoCa1I52RPDDXDyFaxQApp29zelfevOFmPE4jrDq37I
	4FrZZo0x1s/sfO+fbl5Jy7dingqFRvzMFiLXDcjU=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io,
	jandryuk@gmail.com,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH 2/2] flask: implement xsm_transtion_running
Date: Wed, 20 Apr 2022 17:04:07 -0400
Message-Id: <20220420210407.18060-3-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20220420210407.18060-1-dpsmith@apertussolutions.com>
References: <20220420210407.18060-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit implements full support for starting the idle domain privileged by
introducing a new flask label xenboot_t which the idle domain is labeled with
at creation.  It then provides the implementation for the XSM hook
xsm_transition_running to relabel the idle domain to the existing xen_t flask
label.

In the reference flask policy a new macro, xen_build_domain(target), is
introduced for creating policies for dom0less/hyperlaunch allowing the
hypervisor to create and assign the necessary resources for domain
construction.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 tools/flask/policy/modules/xen.if      | 6 ++++++
 tools/flask/policy/modules/xen.te      | 1 +
 tools/flask/policy/policy/initial_sids | 1 +
 xen/xsm/flask/hooks.c                  | 6 +++++-
 xen/xsm/flask/policy/initial_sids      | 1 +
 5 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if
index 5e2aa472b6..4ec676fff1 100644
--- a/tools/flask/policy/modules/xen.if
+++ b/tools/flask/policy/modules/xen.if
@@ -62,6 +62,12 @@ define(`create_domain_common', `
 			setparam altp2mhvm altp2mhvm_op dm };
 ')
 
+# xen_build_domain(target)
+#   Allow a domain to be created at boot by the hypervisor
+define(`xen_build_domain', `
+	allow xenboot_t $1_channel:event create;
+')
+
 # create_domain(priv, target)
 #   Allow a domain to be created directly
 define(`create_domain', `
diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modules/xen.te
index 3dbf93d2b8..de98206fdd 100644
--- a/tools/flask/policy/modules/xen.te
+++ b/tools/flask/policy/modules/xen.te
@@ -24,6 +24,7 @@ attribute mls_priv;
 ################################################################################
 
 # The hypervisor itself
+type xenboot_t, xen_type, mls_priv;
 type xen_t, xen_type, mls_priv;
 
 # Domain 0
diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/policy/initial_sids
index 6b7b7eff21..ec729d3ba3 100644
--- a/tools/flask/policy/policy/initial_sids
+++ b/tools/flask/policy/policy/initial_sids
@@ -2,6 +2,7 @@
 # objects created before the policy is loaded or for objects that do not have a
 # label defined in some other manner.
 
+sid xenboot gen_context(system_u:system_r:xenboot_t,s0)
 sid xen gen_context(system_u:system_r:xen_t,s0)
 sid dom0 gen_context(system_u:system_r:dom0_t,s0)
 sid domxen gen_context(system_u:system_r:domxen_t,s0)
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 51c896d9f7..7e840af6fc 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
     switch ( d->domain_id )
     {
     case DOMID_IDLE:
-        dsec->sid = SECINITSID_XEN;
+        dsec->sid = SECINITSID_XENBOOT;
         break;
     case DOMID_XEN:
         dsec->sid = SECINITSID_DOMXEN;
@@ -188,6 +188,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
 
 static void cf_check flask_domain_runtime_security(void)
 {
+    struct domain_security_struct *dsec;
     struct domain *d = current->domain;
 
     if ( d->domain_id != DOMID_IDLE )
@@ -198,6 +199,9 @@ static void cf_check flask_domain_runtime_security(void)
      * set to false for the consistency check(s) in the setup code.
      */
     d->is_privileged = false;
+
+    dsec = d->ssid;
+    dsec->sid = SECINITSID_XEN;
 }
 
 static void cf_check flask_domain_free_security(struct domain *d)
diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/initial_sids
index 7eca70d339..e8b55b8368 100644
--- a/xen/xsm/flask/policy/initial_sids
+++ b/xen/xsm/flask/policy/initial_sids
@@ -3,6 +3,7 @@
 #
 # Define initial security identifiers 
 #
+sid xenboot
 sid xen
 sid dom0
 sid domio
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 17:36:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 17:36:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309532.525840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhEFr-000603-D2; Wed, 20 Apr 2022 17:36:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309532.525840; Wed, 20 Apr 2022 17:36:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhEFr-0005zw-9f; Wed, 20 Apr 2022 17:36:39 +0000
Received: by outflank-mailman (input) for mailman id 309532;
 Wed, 20 Apr 2022 17:36:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tmf/=U6=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1nhEFp-0005zp-Cj
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 17:36:37 +0000
Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com
 [209.85.128.181]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6cda4039-c0d0-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 19:36:36 +0200 (CEST)
Received: by mail-yw1-f181.google.com with SMTP id
 00721157ae682-2f16645872fso26229757b3.4
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 10:36:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cda4039-c0d0-11ec-a405-831a346695d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=aSRYCi9Gu592mc1yy2JGCfSHyy3Om8/ZMl9fXbJ4VAk=;
        b=yrGfKdQ+RQ4jqB3hwQm5DAU7oDDuDCsReBXtdrrYPndOaxB+VuJ7FHkxpUyulIaqDr
         YRFLFO75pViOPwc1xDRucPO/otLt8Sw1CTPxbkZkhoNZrUcSkZUNkJy8oLXNNCwkgssw
         0vWoevC5omGuXLFUmg6/wFEXlFD8KJ97RphCT0yW6Vib2qCnSLLek/dlKDEQ0vJ0ool4
         tSkeOEA/rzhvmjzKTlyxhftZIXRVT6t52lGvWjfeRGd7BdVhz4UMs6RjKLUrERdq6n8J
         ruWXJpv2hsCuutEIY08iQiFf0vN+VJWBS4PykAmAqAipA3PdKqZhe0Lt7km5chNfvUyj
         U9xQ==
X-Gm-Message-State: AOAM530QzbJSKcmk3TvknxMaNCZCJtrUpE0PgKVuF+Corp9QR/gpXa88
	uIiVypSP+ljDfK95gCzqd2dd7ctUrHZf8dfKuDk=
X-Google-Smtp-Source: ABdhPJzNeFf91aJ2AcO4HxwsyceUmkMGZe3BT/sKo5s3TT3nCPguaeHFtXhd48Duxnk7AG97fF2bO/GqS3ZkGsIQMYE=
X-Received: by 2002:a81:260a:0:b0:2f4:ca82:a42f with SMTP id
 m10-20020a81260a000000b002f4ca82a42fmr1985644ywm.149.1650476194968; Wed, 20
 Apr 2022 10:36:34 -0700 (PDT)
MIME-Version: 1.0
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <20220411233832.391817-4-dmitry.osipenko@collabora.com> <CAJZ5v0gf1J+yPW14TAdLGLGfO+-2s=r0DDP7d+Rgop3=dB0gaQ@mail.gmail.com>
 <af51d9d0-26ba-fc66-05f1-d92ef7172730@collabora.com> <CAJZ5v0jFQi1x1Fnfk04n+HTTirz19-_xW2NgJtpOYyPgVh3Afw@mail.gmail.com>
 <fa20ae2f-e265-c713-493d-5b2ebcdf7f0a@collabora.com>
In-Reply-To: <fa20ae2f-e265-c713-493d-5b2ebcdf7f0a@collabora.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 20 Apr 2022 19:36:23 +0200
Message-ID: <CAJZ5v0iA6St_J5C6+Efygu25g9g-_tLBPc0qQoHbFqfrdT6azQ@mail.gmail.com>
Subject: Re: [PATCH v7 03/20] reboot: Print error message if restart handler
 has duplicated priority
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, 
	Jonathan Hunter <jonathanh@nvidia.com>, Russell King <linux@armlinux.org.uk>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, 
	Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	=?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>, linux-parisc@vger.kernel.org, 
	linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>, 
	xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, Apr 18, 2022 at 3:29 AM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
>
> On 4/14/22 14:19, Rafael J. Wysocki wrote:
> > On Thu, Apr 14, 2022 at 12:24 AM Dmitry Osipenko
> > <dmitry.osipenko@collabora.com> wrote:
> >>
> >> On 4/13/22 21:48, Rafael J. Wysocki wrote:
> >>> On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
> >>> <dmitry.osipenko@collabora.com> wrote:
> >>>>
> >>>> Add sanity check which ensures that there are no two restart handlers
> >>>> registered using the same priority. This requirement will become mandatory
> >>>> once all drivers will be converted to the new API and such errors will be
> >>>> fixed.
> >>>>
> >>>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >>>
> >>> The first two patches in the series are fine with me and there's only
> >>> one minor nit regarding this one (below).
> >>>
> >>>> ---
> >>>>  kernel/reboot.c | 15 +++++++++++++++
> >>>>  1 file changed, 15 insertions(+)
> >>>>
> >>>> diff --git a/kernel/reboot.c b/kernel/reboot.c
> >>>> index ed4e6dfb7d44..acdae4e95061 100644
> >>>> --- a/kernel/reboot.c
> >>>> +++ b/kernel/reboot.c
> >>>> @@ -182,6 +182,21 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
> >>>>   */
> >>>>  int register_restart_handler(struct notifier_block *nb)
> >>>>  {
> >>>> +       int ret;
> >>>> +
> >>>> +       ret = atomic_notifier_chain_register_unique_prio(&restart_handler_list, nb);
> >>>> +       if (ret != -EBUSY)
> >>>> +               return ret;
> >>>> +
> >>>> +       /*
> >>>> +        * Handler must have unique priority. Otherwise call order is
> >>>> +        * determined by registration order, which is unreliable.
> >>>> +        *
> >>>> +        * This requirement will become mandatory once all drivers
> >>>> +        * will be converted to use new sys-off API.
> >>>> +        */
> >>>> +       pr_err("failed to register restart handler using unique priority\n");
> >>>
> >>> I would use pr_info() here, because this is not a substantial error AFAICS.
> >>
> >> It's indeed not a substantial error so far, but it will become
> >> substantial later on once only unique priorities will be allowed. The
> >> pr_warn() could be a good compromise here, pr_info() is too mild, IMO.
> >
> > Well, I'm still unconvinced about requiring all of the users of this
> > interface to use unique priorities.
> >
> > Arguably, there are some of them who don't really care about the
> > ordering, so could there be an option for them to specify the lack of
> > care by, say, passing 0 as the priority that would be regarded as a
> > special case?
> >
> > IOW, if you pass 0, you'll be run along the others who've also passed
> > 0, but if you pass anything different from 0, it must be unique.  What
> > do you think?
>
> There are indeed cases where ordering is unimportant. Like a case of
> PMIC and watchdog restart handlers for example, both handlers will
> produce equal effect from a user's perspective. Perhaps indeed it's more
> practical to have at least one shared level.
>
> In this patchset the level 0 is specified as an alias to the default
> level 128. If one user registers handler using unique level 128 and the
> other user uses non-unique level 0, then we have ambiguity.
>
> One potential option is to make the whole default level 128 non-unique.
> This will allow users to not care about the uniqueness by default like
> they always did it previously, but it will hide potential problems for
> users who actually need unique level and don't know about it yet due to
> a lucky registration ordering that they have today. Are you okay with
> this option?

Yes, I am.


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 17:49:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 17:49:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309538.525850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhESC-0007jd-Ly; Wed, 20 Apr 2022 17:49:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309538.525850; Wed, 20 Apr 2022 17:49:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhESC-0007jW-J7; Wed, 20 Apr 2022 17:49:24 +0000
Received: by outflank-mailman (input) for mailman id 309538;
 Wed, 20 Apr 2022 17:49:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhESC-0007jQ-2z
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 17:49:24 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3418363c-c0d2-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 19:49:21 +0200 (CEST)
Received: from mail-mw2nam10lp2107.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.107])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Apr 2022 13:49:18 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BYAPR03MB4776.namprd03.prod.outlook.com (2603:10b6:a03:13a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr
 2022 17:49:16 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 17:49:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3418363c-c0d2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650476961;
  h=from:to:cc:subject:date:message-id:content-id:
   content-transfer-encoding:mime-version;
  bh=ASC6GTUqC2es2YZ0agjLi/AN8O1YPG+gzXCIywLXTZI=;
  b=cg34f1EjuHtH8lHUwoPTpuPeXb7JxNSIK7UGtvnDDaFqpdIZhxIRxtQB
   9CBaNN3xizngcxsuYHZnhZIMZHWAXlPsiKQPhiuU1WWgpOZMvfDnS1qUr
   wE0R063ejmy/CjYNVKIK7T9gsmJZIfpX5aIKFGUNdTmqQykj3gFQwdNsr
   Y=;
X-IronPort-RemoteIP: 104.47.55.107
X-IronPort-MID: 68937094
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:rc9B7qy9yhXDZqnQNZF6t+dYxyrEfRIJ4+MujC+fZmUNrF6WrkUEz
 DYeWWGBP/bcY2qme4ogaIu/9hhTvpTUmNA3HgJopSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024DhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplt7e/ZCExF4/2hMtGfTJ5A2ZyBZdZ5+qSSZS/mZT7I0zuVVLJmq0rKX5seIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHuOTvYAwMDQY36iiGd73Y
 cYDZCUpRxPHexBVYX8cCY4knffujX76G9FdgAzF9PFouzmPpOB3+L7JGYvtd/+sfsELn3eqp
 0bH0EvVBzhPYbRzzhLAqBpAnNTnnyn2RYYTH72Q7eNxjRuYwWl7IA0bUx63rOe0jma6WslDM
 AoE9yw2t68w+Ue3CN7nUHWFTGWsuxcdX59VDLc84QTUkq7MuV/BWS4DUyJLb8EguIkuXzs22
 1SVntTvQztyrLmSTnHb/bCRxd+vBRUowaY5TXdsZWM4DxPL+unfUjqnog5fLZOI
IronPort-HdrOrdr: A9a23:ljGtEa8pLJ99NC3zKvVuk+GQdr1zdoMgy1knxilNoENuHPBwxv
 rAoB1E73PJYW4qKQwdcdDpAtjkfZquz+8I3WBxB8bpYOCCggGVxe5ZnPLfKlHbak7DH6tmpN
 1dmstFeZDN5DpB/L7HCWCDer5KrbjmzEnrv5ak854Hd3APV0gU1XYeNu/tKDwQeOApP+taKL
 Osou584xawc3Ueacq2QlMfWfLYmtHNnJX6JTYbGh8O8mC1/HyVwY+/NyLd8gYVUjtJz7tn23
 PCiRbF6qKqtOz+4gPA1lXU849dlLLau5V+7Y23+4kowwfX+0WVjbdaKv+/VfcO0aSSAWMR4Z
 nxStEbToBOAj3qDyaISFDWqnbdOX4VmgHfIBmj8DfeiP28fSk9DcVZg4Jfb1/212oM1esMiZ
 5j7iahrJxQAgrHnCPho/7ydz8vuHaVjBMZ4KguZ1o2a/pHVJZB6YMY509bC5EGAWbz750mCv
 BnCIXG6O9Rak7yVQGRgoBD+q3aYp0IJGbxfqHCgL3m7xFG2HRii0cIzs0WmXkNsJo7Vplf/u
 zBdqBljqtHQMMaZb90QL5pe7r9NkXdBRbXdG6CK1XuE68Kf3rLtp7s+b0woOWnYoYBwpc+kI
 nIFFlYqWkxcUTzDtDm5uwCzjndBGGmGTj9wMBX4JZ0/rX6WbrwKCWGDEsjlsOxys9vdvEzm8
 zDTa6+L8WTXVcGQ7w5rjEWc6MiWkUjbA==
X-IronPort-AV: E=Sophos;i="5.90,276,1643691600"; 
   d="scan'208";a="68937094"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dr2m2DeWpl29iTj2qoksRpuPAJi7VJbDm82zq38pUTa4Fq3/ff+0nmSvqfGeuCU9YiFnBBx7fdDsp1BhUQQhERvbTFvDg4HxKNPACRvyOPOCSUuwT9WvpmxDVOcnKKGs+uWZRM9U9E+XxMA7ePgBepOFFdZS6xIowMT0+sPWmk8duAgPqlfA3hk5IU/hkqXOFxtgCW4R1xr2Rt7Bv1W04T5wkCQpyWGG7KExncYpRQK6fTSTiUfGCTLqmTHy/cvFMlpE6Yq8TgEt8uCih/swM6JjynEuBXrOW0cYaMa+GZMnljN+sw1f+Lc8oxG9/MT1nZWRFQtzJWgSOlQxrc0bLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ASC6GTUqC2es2YZ0agjLi/AN8O1YPG+gzXCIywLXTZI=;
 b=DVdK5OL8tmehab2y2LVuzg3d/rYfxs3xHU3GmXxDpZRWTt2mRjnzNmXhLm6nkIdbCsocG+dpI//paTO1XhD8Tk1kEI4ST966fb6v7lAEHs5gx6oKi016475z/tlSPD4aJtPUnvaAbgpsP9qY7T7MYO+W93olmjLUKXG0/B1zPU/VzyQfC5+bGRyvX59mjO2NYJnrmQf4cpLwK/Z0Dh3ScMuLRwvPxBE1o5fYDaHEHTQ3pzl4x4nx3V+PnKaIPpuMFLWe/e4CDt1ow93b1ixfGk9Za66MfPqENZmDyn8yt+8ZZIvyl6JYBL9EaKSeohJejB2ZWZ05e63Y3CRuannuoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ASC6GTUqC2es2YZ0agjLi/AN8O1YPG+gzXCIywLXTZI=;
 b=QiliFDAUC5KM/RIic9Cp70H8XFx/xM2AiNBZ6vWW1B7nUt9O6nMtwjhsblUmA2Mt7pjkGg7X/RRlETyCqpjB9DpHKVMEQ5GIsq9hoEAiHILMM8pBr8rE+ijpwmN0Tb5za6BFqQ9Zz2dTV8nABNbbC4FRNw6cc0QQ9EEy0qr/Hcg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: xen-devel <xen-devel@lists.xenproject.org>
Subject: Ranconfig failure between VT-d and HVM
Thread-Topic: Ranconfig failure between VT-d and HVM
Thread-Index: AQHYVN7zVpKNKLs79U2pM+0BQOt1bg==
Date: Wed, 20 Apr 2022 17:49:15 +0000
Message-ID: <9537f2bf-981c-d4ac-d41d-ab59f7d7ab2c@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 66797de5-4a03-4fe1-1a60-08da22f61678
x-ms-traffictypediagnostic: BYAPR03MB4776:EE_
x-microsoft-antispam-prvs:
 <BYAPR03MB4776CF64AA9F3898D80919F8BAF59@BYAPR03MB4776.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 O6NMLeklm7agOJGfkz7Vm5DTE5LtG1Wz6kTZAEE7C9NYNThtDc1mUz2M/D4q1igvYWiHfCOY6GAcSWecqTruvVoyQuFWAKPz+248yZAzy0mY2FrqZ49EM4+EBDNfKC/gHkBhe/dKsyAtpRtHYZ5oCuHDLAx75a9K9VilORqfyf7nix0AT8mfm7PIKkWOhMyyDISyNkKIq2E3zReLesA5Fg4YGn3WRr/j5GJFu0MB9L/ZScAAbVJqFlCBYQNFBC6hqkQ7M98H/eI2yHRSOGFoIxy2DrGHviXlUKXtlvrV9IyWEc4DQSLMD/sUz1OIvMgKiXo5TlunlN1/dU8bsk8SDTJvesjLXRO4EUr4DQDGXwumjAGKwTxhqdm6Oo/m00OdmNTa0oZ2dONvIGJ30x+rR9STGSaqNJ82qEVkcKshtjYMIwNSX27JgWmwGkBlLG8i89v3ouhrrDWsDJPiXTf4uJd3gLYzTK7uqTw/5ooVh7kh6BSyY5D2QoGn1on6fZwcCkbNDAnt2vM2cTan/GOJwwvQh7giBhTcMwSRO9Wv83PoNAN5pTyQSEtY/p2Kd8Bh82/3llXIIKCSCLyRuyvKjpFcqxSByagD2djA6HP4um9V9e9nNqB8OyjrZHLpityu+fkykU4l5dxKhGOVKrw3Uqchgyne5e15pLc6cIaJSPeF37k2/CF0SijxfZKGsx8qBxVPqRkMUut7uWSTCYdxidCYD4uyuuIJ7CJkePCgwkwFonrLOVKxqnNuOlGhuthKa/rx7zv71UbPhobcUJcvwYmrRzMxW80xVVJi5PGPK/oQQy6cMESzXHaChGvdgvwKRyFq+G2e0hLAuN3tnWySP/BP9s3rXsRnPc70t0UlyMw=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(82960400001)(6916009)(122000001)(76116006)(508600001)(66946007)(186003)(64756008)(71200400001)(86362001)(2616005)(31696002)(66446008)(66476007)(36756003)(6486002)(66556008)(38070700005)(6506007)(966005)(6512007)(4326008)(2906002)(38100700002)(26005)(31686004)(5660300002)(316002)(8676002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?UEhqQ0RKVWVGSlQ3T1pBc0JWVFJ1RlRFMVJqc3lNOFozbm4wN3NJOFFjUnFN?=
 =?utf-8?B?SWlaRzJ0cm0ybDZaSEhLck1TcWdIWURLcG90TmdjNGUzUzYwbWQ2OElGdDhP?=
 =?utf-8?B?REtmWUJhMklCcWZ5Ymg1OFRYNU0yRlkreGZZMFdWbXU2aTdLVmdWYzQvRy9M?=
 =?utf-8?B?S2VqWG1rVHRiQXVTTW03ZnVPeisyZ0l3R0VDMWlyREk2T3d3L3k3TU5MbnE5?=
 =?utf-8?B?d2UwQkR4R2ZMMGlhRndKSzhSazlicUxnV0pJWDF2cDJsZkJjV0lKc2dKaGJa?=
 =?utf-8?B?RnJmcFZROXl2V2ViN0hKYUMxSWt3ayt4M0JTdVhBbk52cVpscUZkQ3NyaUdj?=
 =?utf-8?B?VUVxQ0d2enZtNzJ5aEt4SlV0SVVxRnllZnhKODdXTGNGRjk4UWFjVVMraDdH?=
 =?utf-8?B?RnBhWXNzYWJuMW8xWDBxQlNDRHkwcUJuNWZrU24zNE1xcjllT1U3QlFKbk01?=
 =?utf-8?B?MUJhVlRKOW1BVGxlZGdCZnorQTR5bFMvOTE3YUtaMklKT0FRRGR4bHpyQjVt?=
 =?utf-8?B?NjR6aVNVOFdVbGljdTZHa2xFTFRneHl5c0JRQzBCc2FMWmhGYjk3ZmZEUDJz?=
 =?utf-8?B?MnAxL1IvY1N4MjhWbGhyWXV6dmUrWElyVmVXNGo3akFLcVlhamd5TndON1p4?=
 =?utf-8?B?Q3h0M09NcFQ2WEdNZ04vQ0EvWi9uNGpnc1FsVjd0V2JxbXR0MVlCaG1xcnRL?=
 =?utf-8?B?djJjWXpRTXdmTm9FVXRJMUN5OW05NFBLSEhySzVPVDlucmJQaFh6Vmg4bFpr?=
 =?utf-8?B?cGloNzFyYUR3RDVlaC9rWGh4NkFyZmJzamFLbXRIYlVRZ1FFbGZqY0JNRXJs?=
 =?utf-8?B?NEJ5RTMwc1lmTDlrcUN3Y3M3SlA2ZDFyUURBcFppVFlGV09CNks3bTdCdUFs?=
 =?utf-8?B?UHBlcnBXMDF4dWc3VFMxcGZub1ZUdzhFOXJXaXZVdmx4NWg1cVdOZVBJeGFK?=
 =?utf-8?B?dW9ubnFQeWZ6VDZ2MkdvYjJpWVFrQTdXVzJQSWJrdGtzcE9zakpMcCtpNkRo?=
 =?utf-8?B?b0dBME9DQVN2eEFYUW92ME8vaEUxUkdrVWE5TVRTbzJ6ZitXaG5TMWsxQk1F?=
 =?utf-8?B?M3M4TkFzUEdYWVdsNHNYVFJkb1FDZGptOFVnUmdkNDlNOFlXMUxpdU1wUG1h?=
 =?utf-8?B?Qml6N3E2SDY0Q3BNWjY2WEtjbW9GTUN4VE5PN3k2V3lxcTNwRVZHSzNTY1JV?=
 =?utf-8?B?NDcvdGdGUVU3eGRJaDFvNTVGYUZ4SGduZy8za2NIYm9PdDJjaHIvMHRVTFFk?=
 =?utf-8?B?QlBlYjJrdzdKcDRMV2JqaDdRN280QnF0L2sraXBRdzhRVDdaZkFGVmRETCsv?=
 =?utf-8?B?YytET0NwdXNpbGVPSzgrRHYvejdEMVBjRlZ1SWNLRDRLYSt6bWZ0RzdheTYw?=
 =?utf-8?B?MDZBeWdkd3h1YU1pdmNpQk41TFRmZFV6NW5Ea3hWVzBsREFjV1N4c1lGN1Zo?=
 =?utf-8?B?Z2N0UnJkNG5LWS8yRmZZV1pmTy9ENk9pY1NXUlVLTmp4VVhWNmZ1T2tReVBR?=
 =?utf-8?B?Y2RXZmV6OHFhRzFMZk4xNGhVS0t5UDl3Zm4xME1xcTdoeVlSV2RuTCtoU1JL?=
 =?utf-8?B?L3h6eS9qNVFsaGRKUFd5bXBUM0Y3UVJUVS85NXFHUXVRUnd1bzdGYk04Uk85?=
 =?utf-8?B?bWVhYThlN1UwSER6dDFOTUl0NkNrR2c4Q2hjeWdEYXpRSU1HN1FDTlpZTHBl?=
 =?utf-8?B?SFZZVFJDZERHSnVDSzErWm10UjZWUFNtaXZxKzV5S1FsTXZQdHdpVDBHU01x?=
 =?utf-8?B?Vzg5bDNZcEpUZERiS0ZmMk1wSm1pUG1mdzU1L2lRTWFNWFZqSHJHdllaeWVK?=
 =?utf-8?B?Nnd2TGdQNUdaSFhHOFU4cEN1S2lhS1RpOTF2RVVLVkh0ZTF1clBNTFJ3WlUv?=
 =?utf-8?B?OUFhdGcxckUwWldMM2JhODlabTc0WFp0Q0F3VE5KSko3M0FaVEJuUGlqczMw?=
 =?utf-8?B?NW5rVDVTUXJUSzdiNTArb2QwWEdLWHd5Y3JwQ0kvaUJMRWRadXVnYm95czFY?=
 =?utf-8?B?MkxMUTJUNXNtYmJmbTJWWnh0MUlLbUFDbzBibElob0xIWjQrMTNvYUJIYWkv?=
 =?utf-8?B?NVREUDFUUHVDbjE5RFJEWk8vOFFEM0NjZFNKdkFGdlZQUS8rTXU3QWJwMjVC?=
 =?utf-8?B?Q3ZyZURvcFdFeFl6cDVkcGZib0VLUTViZWhxYjdkTUtmeElDbWF1TWZNV0tM?=
 =?utf-8?B?SklIUCtIREx6RGEyOVhMb0dYaTA0WWJBazd3TTJpNTlyMVZFTGp6cksxbFpT?=
 =?utf-8?B?VFBuQXEyc1M1SWxYTDZWRnlpN3VKa05hQm5PemxiblpzRkpoM2hZU3lNbWFY?=
 =?utf-8?B?ZnAwNUgydWF1UVJmS0Q2alBiRlE2ZDlJMHVJL3RwVGlwQXlVczI0dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <141EB287C096C044A7E8A8A03089B9FE@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66797de5-4a03-4fe1-1a60-08da22f61678
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 17:49:16.0459
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cvBIHPnMVKOtCMmz3c55BIwLMBUCMfptX/fYpbcrrCNfHS9rqJrO7SMh88iQNOljPtNEx8g8NwcJF4sEZY/T5S7ocVlq70EUuxM1kNtCcIw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4776

aHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS9hbmR5aGhwL3hlbi8tL2pvYnMv
MjM1NTU2MjExOQ0KDQpsZDogcHJlbGluay5vOiBpbiBmdW5jdGlvbiBgdnRkX3NldHVwJzoNCmRy
aXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmM6KC5pbml0LnRleHQrMHgyMTlmNik6IHVuZGVm
aW5lZA0KcmVmZXJlbmNlIHRvIGBvcHRfaGFwXzJtYicNCmRyaXZlcnMvcGFzc3Rocm91Z2gvdnRk
L2lvbW11LmM6KC5pbml0LnRleHQrMHgyMTlmNik6IHJlbG9jYXRpb24NCnRydW5jYXRlZCB0byBm
aXQ6IFJfWDg2XzY0X1BDMzIgYWdhaW5zdCB1bmRlZmluZWQgc3ltYm9sIGBvcHRfaGFwXzJtYicN
CmxkOiBkcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jOiguaW5pdC50ZXh0KzB4MjFhMjMp
OiB1bmRlZmluZWQNCnJlZmVyZW5jZSB0byBgb3B0X2hhcF8xZ2InDQpkcml2ZXJzL3Bhc3N0aHJv
dWdoL3Z0ZC9pb21tdS5jOiguaW5pdC50ZXh0KzB4MjFhMjMpOiByZWxvY2F0aW9uDQp0cnVuY2F0
ZWQgdG8gZml0OiBSX1g4Nl82NF9QQzMyIGFnYWluc3QgdW5kZWZpbmVkIHN5bWJvbCBgb3B0X2hh
cF8xZ2InDQpsZDogLi8ueGVuLXN5bXMuMDogaGlkZGVuIHN5bWJvbCBgb3B0X2hhcF8ybWInIGlz
bid0IGRlZmluZWQNCmxkOiBmaW5hbCBsaW5rIGZhaWxlZDogYmFkIHZhbHVlDQptYWtlWzNdOiAq
KiogW2FyY2gveDg2L01ha2VmaWxlOjEzNzogeGVuLXN5bXNdIEVycm9yIDENCg0KSXQncyByZWFs
bHkgbm90IGNsZWFyIHdoeSB0aGlzIGhhcyBmaXJzdCBzaG93IHVwIG5vdy7CoCBUaGVyZSBoYXMg
YmVlbiBhDQpodWdlIHF1YW50aXR5IG9mIG5vaXNlIGluIEdpdGxhYiBDSSBmb3IgdGhlIHBhc3Qg
MyB3ZWVrcyB3aXRoIEFSTSBiZWluZw0Kb2ZmbGluZSwgYnV0IEkgY2FuJ3Qgc2VlIGFueXRoaW5n
IHJlbGV2YW50IGluIHRoZSBsYXJnZSBudW1iZXIgb2YgSU9NTVUNCmNoYW5nZXMgaW4gdGhhdCBw
ZXJpb2QuDQoNCkFueXdheSwgdGhlIGlzc3VlIGlzIHNpbXBsZS7CoCBJdCdzIHZ0ZF9lcHRfcGFn
ZV9jb21wYXRpYmxlKCkgaW4gYQ0KIUNPTkZJR19IVk0gYnVpbGQuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 18:01:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 18:01:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309544.525862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhEdt-0001pl-RF; Wed, 20 Apr 2022 18:01:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309544.525862; Wed, 20 Apr 2022 18:01:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhEdt-0001pe-ND; Wed, 20 Apr 2022 18:01:29 +0000
Received: by outflank-mailman (input) for mailman id 309544;
 Wed, 20 Apr 2022 18:01:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E3+=U6=citrix.com=prvs=10247635a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhEds-0001pY-8I
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 18:01:28 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e3d79249-c0d3-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 20:01:25 +0200 (CEST)
Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Apr 2022 14:01:21 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CH0PR03MB5971.namprd03.prod.outlook.com (2603:10b6:610:e2::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 18:01:20 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 18:01:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3d79249-c0d3-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650477685;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=V4eKRoYraXiZ5Xl7eXfR+PhSvzcIiRTT8tSAkFum5JU=;
  b=P9ekPfco1gbNPDhSuEmX4F3ah3+9P5OJAtYamE1uiTaks8RbxY8p4nH4
   XPcmxu2wOtnbsdiJ6sGKxWDOj2OONuPaiLAJa/wqYRpMB0hu+EFKTJHGA
   aJwva5MTbznHqLW2VHAivKb+mMasl9b0wMMhsJu+So/G2io8JcQEsfgv2
   8=;
X-IronPort-RemoteIP: 104.47.59.176
X-IronPort-MID: 69940169
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:dcm9Fq91t2wvZktDQe7RDrUD73+TJUtcMsCJ2f8bNWPcYEJGY0x3z
 jYaDD2DOfeNNGujKoh2bYji9hxQ75XTytI1SARvrCg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YLhW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnce9bD91NbTHo9UmTUBfLw9uA5Qe0qCSdBBTseTLp6HHW13F5qw0SW0TY8gf8OsxBnxS/
 /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvSMvIAGtNszrpkm8fL2T
 swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrL9PtruzGNnWSd1pDSK/3FK+etevxIm0zJi
 lKW2mDgUhoFYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQnZKflhsVWt4VH+hk7giIk/DQ+1zAWTZCSSNdYts7ssNwXSYty
 lKCg9LuA3poraGRTnWesLyTqFteJBQoEIPLXgdcJSNt3jUpiNhbYs7nJjq7LJOIsw==
IronPort-HdrOrdr: A9a23:aAyrxq82DBYKUywpKkduk+DyI+orL9Y04lQ7vn2ZESYlFvBw5P
 re+8jztCWZtN9/YgBDpTntAsa9qBDnhOVICOsqTNKftWDd0QPCRuxfBOPZskfd8kbFl9K1oJ
 0QEJSWf+eRMbEVt6jHCNXRKadc/DDNytHPuQ6X9QYVcehFUdAZ0ztE
X-IronPort-AV: E=Sophos;i="5.90,276,1643691600"; 
   d="scan'208";a="69940169"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iEC/P2exux22RuAbTBTUHRrhLSViev8kS6rh+9Wv+J2YOKS21uQ2fjM7/Z90+eB32UeQufgplfMuLFPG5gPIB5DOq928MMS4Mi9km/AalraxhusTHtp/WmqhApRzU25YlkAoBPMxGfbgd4QF4EgqDvE9GCiyZWX0BbUUOjs3VxOLHMi8/k74sdAA+/xwvwt2jtSOiy/BgdXGvvKmIZfzWA4wV2gDoFbeZD49MiriwUHBbwaieC1WoCd/woEKPQeisZaadWlaaXV6LReY0eLavN67lRaN8qSAKuKN3kgLG+hs5UaGlPYbk0hQ+tSNhIAZhQmJ5KlyybT8+wEAANgFoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V4eKRoYraXiZ5Xl7eXfR+PhSvzcIiRTT8tSAkFum5JU=;
 b=d9u2DWkRH+Rf9GyEMHJi6OAqCGOlfknpGMZevhVd0OdB5VXvmtYs7BVQevmcV4vcf6yw/XfurTxuka2HJoOuHnuOX5NBrgXxabqmKqh6qfor4DGeScUOuRtkLoDZbq9LY0Ht7W2cDW8zzfeywgyxRFWOIB6chwaOa0X6TDkHnWMcs366nMDDsnCuHt/ua/WdDbFbnOqyn3clFD3NL8qu2VguWdwPPGgi0dGpUKf9Yple1lJ4nKDrm1m+EUmCN+6WCnl2Xs7fhxYJO11yL3x1nfoFjOSV2c4cQIonm2r3TyvwqLn2TsqRhdyLzzKOL/gCceMyS0mr3c+vXPoxgLr2hA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V4eKRoYraXiZ5Xl7eXfR+PhSvzcIiRTT8tSAkFum5JU=;
 b=AoMhb6u+cZB6fDrEKQEUH4YFVPF/TBCIQUNN2LqgdehzcHqtGSb92ueakjZadOkUaToB8KltW4R59ssxb96fumUQEXhGoE0mGCUp0zjdF8dEe7mb3cIHJfMJ5B42Pyz8CMtVQ0/4dX3pjR0+8BfCbZMCNhoIBCpuooq6UWhhYFQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Ranconfig failure between VT-d and HVM
Thread-Topic: Ranconfig failure between VT-d and HVM
Thread-Index: AQHYVN7zVpKNKLs79U2pM+0BQOt1bqz5F4eA
Date: Wed, 20 Apr 2022 18:01:20 +0000
Message-ID: <4095a567-86aa-8311-ed92-730348ab43d3@citrix.com>
References: <9537f2bf-981c-d4ac-d41d-ab59f7d7ab2c@citrix.com>
In-Reply-To: <9537f2bf-981c-d4ac-d41d-ab59f7d7ab2c@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3e64fdbc-1d1f-4ea3-6719-08da22f7c629
x-ms-traffictypediagnostic: CH0PR03MB5971:EE_
x-microsoft-antispam-prvs:
 <CH0PR03MB5971C1122B70B1BBF13E8D0BBAF59@CH0PR03MB5971.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 kH4ciVVINtOBuFexYXECvSDqE05/paeC2MykGOdegs2dvGWS6FHLQB0xzjlQfxzx23OfIllonVNMfGmB6C06EsN2tL/m9dYQMQ5UwwbzJ26kmzCR31HzACZqXs6HXE5hhomOkWXWx6UIinT9M8mUgTDvZwnhPahiA1YZCwR+I0uIbTtMTl7hd9Amg6ewLicBI6D4nrOyHOPB6+t7dILy7LfuPEXxRy2z3ENz7cZ+n9d0Ot41lyoh7+vra96BbbdCTXHSHMI/87I9nyrxxJBAVutGlZPo5KWhZjUKehT0OiCZ0GS+HXCfUhHqYiI8crpV7ucrLAGPbAXHFeKs/2MiABsFBqvRUMhl9sBsvA3pwMb+Xrh/IRSjEiO3wGtR+SNks3wk5kF4iLf18xifWrf+zkDrtnOHeNlMsNlGvvUkClBkmgWREV+xVBKXjdbpdoynBsbkrYc87JwZeFmjkpARtUhNFcnabvYZdy0biR4W0A0NZU3HM2SduzwmIMoCZ8NuVyEejmmLxxOe/F9o3/F7HISh8EOYkpqkMdQWkOxdH1iaXz6g4O9AmfrTltYcbJOgJtCJaMyN87x62EKvnRU5CppQx96iLiCcBgWR9/656235F3fUBpZGVGwQzBb0G3ytoZWGi+QUSbMFpG1p5YRNgx6oBFDce4CPqXkSlMDBax+GPojKrZxZSEgWGwEAvJVBVvSavOJxz33KLG2xvqS15alxtmZyIYRH2/JJoJvwvdSvU+fmMD6CWsNEjikAAyX7UhRnq04PgSmIQT7UbtlGpSE3k+/BgvIQJOb9MS9ZEyt7AsXEBKjt5gnXZVLO001m49Revmxekly4wJmRO77oIWTn5vGpvSIMUKCRWELOuzI=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(38070700005)(122000001)(38100700002)(316002)(66946007)(82960400001)(64756008)(4326008)(31686004)(8676002)(91956017)(66446008)(6916009)(76116006)(66556008)(71200400001)(66476007)(2616005)(6512007)(5660300002)(53546011)(2906002)(6506007)(86362001)(6486002)(966005)(508600001)(186003)(31696002)(26005)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?a3dkdUNRd20xYTNwdXIxRjJhcTQxY0haVzhNTVZnUGsvVnRiRE5kblRFaXlT?=
 =?utf-8?B?VmppZnR5aHUwOXNXWitXai9URjMxZFhKRTIyaUw0Ulo3VFVIZ1pDQzluSlpN?=
 =?utf-8?B?RTVXMnkyekRlWmxqWHZtVXRIUGxLNzBOMjBtbjNKbkEyQlhOMEM4SExOTG9R?=
 =?utf-8?B?UGZkOGl0OGYrck03TmN0NUl5TVh1WUlXSGhoYlB4Z0J2eHVuditzQkU2MFhU?=
 =?utf-8?B?TkFEeE9CZk5Wb3dXRWxKS3NwSm1mMG10V1ZyYUx5bVREcTRLWVpINnBpci9k?=
 =?utf-8?B?SUYyMmtmNlgvTzV2Unh3bk8xVWh2RUtzUzZXUTBLSkNQMlVRRDczVkNiSEZM?=
 =?utf-8?B?blZ0cGw0MHB5eWJBZ3dXd2ljMitnRE5LcVpNb294TzNvVjhUQTJOSmhmOE1O?=
 =?utf-8?B?enkwWURmRmwrMlVocW11Z2lOaUJENFcyME4xdDQxVkVwWmtBSkk4ZnE1ZUJV?=
 =?utf-8?B?ZFhtYUtzcW8xcUwyTkZ4eDlkTE1VZ1laZjBmRDlabkRZcWtPVUlNYVJLYUR4?=
 =?utf-8?B?RFhqZmRHbGFmbGJZT3o1S3Z4MDhYd1I3R1ZnbTEzVTFOOU9JbWRza1IrTTR3?=
 =?utf-8?B?VVk0TTBCNWRRdGg0N3RSMnZKNGF6V1JxL05WV05NQzIvVWh1eXE1dmtwcmJG?=
 =?utf-8?B?VEg3ZGpBWWFNMmZ4U2xsbDB3czcyZjZmTGFBR0U4K0dFSTJRMzRmaldSajQ4?=
 =?utf-8?B?Q1dia3hBUU1aOXpLdWEza01YTHQ0MENPcUVEbUxQUk9oZWk0Zk91RFlWNXhh?=
 =?utf-8?B?aERlbVh4UHN2WVhzcGxhNnIxTmZ0SFJEZzNIcStqUVBlUUVGWGJrZ1NEUzM0?=
 =?utf-8?B?NEFBWnRoWTVSdGRuakFYUVZEbk85OEt5ZlhuWU9jdE1Lc3dFNWtqVnMrQXlC?=
 =?utf-8?B?WXBxYk1WYmg5bXJYSGIwcjlsR0pzRVdLbWlJQm0rTW50QzdVdXc1cEhuaERx?=
 =?utf-8?B?dERITjBOOFM4ZmRBZlJIRnY5RUQzWlB5cXhvRWdPNVp1Sm9PajlpRDByU3I5?=
 =?utf-8?B?L25JNVBDVFV0ZmxWdnRyQXNBQkhzVm1jRlYvMFhZZlhCM1FaeG85c2pqbndR?=
 =?utf-8?B?TnYrblhiUlJ6SG8zeU9XOStiVmU4ZkVSOWp1cDd5WS9XNTl6UHlERWpYMEJE?=
 =?utf-8?B?TlY5djZENHl5Q3pKOE0zdEpGaDZ3QXdRWlRrQUdNa2RYN2xTYldEc1hSTmQ1?=
 =?utf-8?B?YjYyYUlRRlJKK2ZHaklleVRDY2xIcVJ6N3poVkRHZDIxcDJoYXlSeGVGVjFh?=
 =?utf-8?B?ZmJtRnVHOTY2VnMvczBVYXE2Szc4RWUyVStBcGVVTVZBa2FybURNMVdxdk1a?=
 =?utf-8?B?REFwQWxxV21peTQrNWhKbWpMSGJGVFFGdFJwV1BWbVVJREtTVlpkZDc5SjNJ?=
 =?utf-8?B?TldHRi8zK1JjaStsck0xVkZHWnM3MzU3MXNGVkdoYVEzT3NQWjluc00rdkJH?=
 =?utf-8?B?REJiTTEvbFIrR2E2U29oeCs2UFlBMWdOY0xhVis5bGJzS2x5bFAwa3hnM0wz?=
 =?utf-8?B?dmJSNWU4eVBTbmVxdjdBVDgrZXV4K2xib3pkcTRFSTJXR05ETnQ2Ym5qbkhD?=
 =?utf-8?B?cW5ueVVZeWRNbUR2SXR2VmdUKy8rdDZxYjgrQUYyMnkxZ0NZZWkxOU1mVUJk?=
 =?utf-8?B?Z25iWVJoWXlPd29NeXA4V2UyS1FwY0pzRUZXZDUyVE93dkoxcVRXeDczTG9m?=
 =?utf-8?B?ajJSY3Q1OVc0eEpRQW9ERWNWQ2ljcHlJSkRzVUdZUlFyVStVME1pcTRIcjRU?=
 =?utf-8?B?NndpRVhhZjdUUmwyUVF4RDBzM0dIa0p6SDVIVHNVbnlocWRZLy91RVVMZG5M?=
 =?utf-8?B?eTF6YTlOWmZYcS9HZjRPLzhMRHBENXhncE5WRzA5V2lQaUp0NGhBeVFGN294?=
 =?utf-8?B?N2hpejdxRGg1T0pHNlhuMVhGVmkwNmhuNjJQclV5YVlHRnZzMGNmaElCbllN?=
 =?utf-8?B?bmZOZXUwVVJLcHUvUldLN2lMNTJ4aFVDUUROVVNnUU41S3o3MHA2MjlpMGFp?=
 =?utf-8?B?ZWxqQ1VUT1pDdWloM2dFalFSN0c4ZEpmcGkyd3FING1Uc0x0bWw0R0xqeEFr?=
 =?utf-8?B?ZkZMdDNVQmtxUEF1VCt4Y2I3VUs1aGNibEUwMURMYUZXMjVQVzNkSExDTVBt?=
 =?utf-8?B?cXpTcld2NHRiaStRRURmc25qRG5wUlBYQjBxREZSQitHVlFLYSs0TTlRM0RT?=
 =?utf-8?B?T1JqYVpUQWRTRFFSM2FqOWkwRFNvUjJjZXdTUmk5S1h2Z25Pc2FqenBiVnUw?=
 =?utf-8?B?ZlQwUndHMWJ6eXE4ZGRvbkFRT0ZIcFoydUkwZGtjYk1jdmlQN1dZbFNsWjhH?=
 =?utf-8?B?NXR3OTJXZUo1bGRoV2V5QytTaDNVWWNlQTJpN2Y3U01KVkhxbkxoQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E9184EA33AB1B341B6816161B278EC4E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e64fdbc-1d1f-4ea3-6719-08da22f7c629
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 18:01:20.2590
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4Zg9lskYRAN65nJa7/SoZRS1/ypsqBIeqBcYoUacJsFPkzoiQS8Ob++oF14T2CDzX4XYDVoK4cG2dL9Kq3nuUQly4nW2Qxby5yzBGKzXhiE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5971

T24gMjAvMDQvMjAyMiAxODo0OSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gaHR0cHM6Ly9naXRs
YWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS9hbmR5aGhwL3hlbi8tL2pvYnMvMjM1NTU2MjExOQ0K
Pg0KPiBsZDogcHJlbGluay5vOiBpbiBmdW5jdGlvbiBgdnRkX3NldHVwJzoNCj4gZHJpdmVycy9w
YXNzdGhyb3VnaC92dGQvaW9tbXUuYzooLmluaXQudGV4dCsweDIxOWY2KTogdW5kZWZpbmVkDQo+
IHJlZmVyZW5jZSB0byBgb3B0X2hhcF8ybWInDQo+IGRyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmM6KC5pbml0LnRleHQrMHgyMTlmNik6IHJlbG9jYXRpb24NCj4gdHJ1bmNhdGVkIHRvIGZp
dDogUl9YODZfNjRfUEMzMiBhZ2FpbnN0IHVuZGVmaW5lZCBzeW1ib2wgYG9wdF9oYXBfMm1iJw0K
PiBsZDogZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYzooLmluaXQudGV4dCsweDIxYTIz
KTogdW5kZWZpbmVkDQo+IHJlZmVyZW5jZSB0byBgb3B0X2hhcF8xZ2InDQo+IGRyaXZlcnMvcGFz
c3Rocm91Z2gvdnRkL2lvbW11LmM6KC5pbml0LnRleHQrMHgyMWEyMyk6IHJlbG9jYXRpb24NCj4g
dHJ1bmNhdGVkIHRvIGZpdDogUl9YODZfNjRfUEMzMiBhZ2FpbnN0IHVuZGVmaW5lZCBzeW1ib2wg
YG9wdF9oYXBfMWdiJw0KPiBsZDogLi8ueGVuLXN5bXMuMDogaGlkZGVuIHN5bWJvbCBgb3B0X2hh
cF8ybWInIGlzbid0IGRlZmluZWQNCj4gbGQ6IGZpbmFsIGxpbmsgZmFpbGVkOiBiYWQgdmFsdWUN
Cj4gbWFrZVszXTogKioqIFthcmNoL3g4Ni9NYWtlZmlsZToxMzc6IHhlbi1zeW1zXSBFcnJvciAx
DQo+DQo+IEl0J3MgcmVhbGx5IG5vdCBjbGVhciB3aHkgdGhpcyBoYXMgZmlyc3Qgc2hvdyB1cCBu
b3cuwqAgVGhlcmUgaGFzIGJlZW4gYQ0KPiBodWdlIHF1YW50aXR5IG9mIG5vaXNlIGluIEdpdGxh
YiBDSSBmb3IgdGhlIHBhc3QgMyB3ZWVrcyB3aXRoIEFSTSBiZWluZw0KPiBvZmZsaW5lLCBidXQg
SSBjYW4ndCBzZWUgYW55dGhpbmcgcmVsZXZhbnQgaW4gdGhlIGxhcmdlIG51bWJlciBvZiBJT01N
VQ0KPiBjaGFuZ2VzIGluIHRoYXQgcGVyaW9kLg0KPg0KPiBBbnl3YXksIHRoZSBpc3N1ZSBpcyBz
aW1wbGUuwqAgSXQncyB2dGRfZXB0X3BhZ2VfY29tcGF0aWJsZSgpIGluIGENCj4gIUNPTkZJR19I
Vk0gYnVpbGQuDQoNCkFuZCBqdXN0IGFmdGVyIHNlbmRpbmcsIEkgcmVhbGlzZWQgaXQncyBub3Qg
YW4gSU9NTVUgY2hhbmdlLg0KDQpjb21taXQgYzQ3OTQxNTYxMGYwNDQ4YmIwN2QzOTE4NWU3MmVm
MzZlMDhlYmVjMA0KQXV0aG9yOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQpEYXRl
OsKgwqAgRnJpIEFwciA4IDEzOjUwOjI5IDIwMjINCg0KwqDCoMKgIHg4Ni9QMk06IHAybS5jIGlz
IEhWTS1vbmx5DQoNCg0KQ0kgZGlzcHV0ZXMgdGhlIGNsYWltLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 18:07:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 18:07:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309551.525873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhEk5-0002h2-GC; Wed, 20 Apr 2022 18:07:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309551.525873; Wed, 20 Apr 2022 18:07:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhEk5-0002gv-D1; Wed, 20 Apr 2022 18:07:53 +0000
Received: by outflank-mailman (input) for mailman id 309551;
 Wed, 20 Apr 2022 18:07:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oHj2=U6=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nhEk3-0002gm-SJ
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 18:07:51 +0000
Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com
 [2a00:1450:4864:20::22e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ca6305ce-c0d4-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 20:07:50 +0200 (CEST)
Received: by mail-lj1-x22e.google.com with SMTP id q14so2819718ljc.12
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 11:07:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca6305ce-c0d4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=ZefzNMP2xUCwCKtwQAeTzLb3uVrLkvJxMgprBH62UZ4=;
        b=jLlgx2f/ZRVcIZm4xsCqE2Kjbklu4dCw34zc+5hFOBbtXsx33lV/Liy5yZhk/qVwpE
         /jpdht04fxkdW6QOR7a9LAXNTA8DuIPmPqi8v7c0ASvRn6R6BtF0Rih8kbwUnnIYQC0g
         JfcAMkmWz3AAfCOl4JcFwoc2+N7kpMg0SodyW+WpckqmLV2t9nyQ+wFwcUPlHj4/rzfS
         FD5SKdRNTwMA3vcuHriNvqYoyuU5JLtmJnivY+1G/SmjyELFaaRrOEu+jxNTRpyCEdcV
         AwvLmwz6ltUBhb39rHzuCvJUGluIsaQ3F4CWH9SHc1ituCugO+2qjMWqlW2nqrP3X5SR
         g1ug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=ZefzNMP2xUCwCKtwQAeTzLb3uVrLkvJxMgprBH62UZ4=;
        b=qAf7TwSbYOtkmzXBc1dQLvjgfJ9sxKCjY8B1gBXZXXvgtOG5YPfdhuTGnYMEB3mCHB
         5tk5zOLaagnc1/LNNGZYYNwDY7X/myk/74yQGfSfrScI7obPPworwfDt0A4b4jc4XYxN
         FpEYs50jzbo2iRWeMybULtOLnorb/wJeD8NQmB/6eu6JSBsupauk93ocpW8GWXvbKGIS
         Wbx51BMhK7jw7TL9JH9l8DWEpCZj5BKgqm2xYrSuQ4S+0Lu1lJsXgmEz1judPu/zWWA9
         oG4J9eIrPyBN1q+MY0VkLQhKCfr/17SnV/dGl2guKCWRk7bzrWRB4slHU2uqFADgPo0A
         X67Q==
X-Gm-Message-State: AOAM533Qjh+yX0muICzjmh8ut+imoz+/MpiAXg9BkED+dByNXYL8fvFF
	7GVdSm3Ued8A6m9KnrpQ+BF6XiCjGx7JFDGteKc=
X-Google-Smtp-Source: ABdhPJy0T85tV9T7j+l9fg1Fnk2oUlxepKw/ZgiogRIXXxCjO3U7OZSZglYRrW6eyobfr+8O0huUZpAa3plF1Jd1EGY=
X-Received: by 2002:a05:651c:1204:b0:24e:e127:f509 with SMTP id
 i4-20020a05651c120400b0024ee127f509mr1482017lja.459.1650478069889; Wed, 20
 Apr 2022 11:07:49 -0700 (PDT)
MIME-Version: 1.0
References: <20220420210407.18060-1-dpsmith@apertussolutions.com> <20220420210407.18060-3-dpsmith@apertussolutions.com>
In-Reply-To: <20220420210407.18060-3-dpsmith@apertussolutions.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Wed, 20 Apr 2022 14:07:37 -0400
Message-ID: <CAKf6xptTqsL9wcP2n=-NBd9UtrCh=+XxzJgK3tGYpqUXQEDUAA@mail.gmail.com>
Subject: Re: [PATCH 2/2] flask: implement xsm_transtion_running
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Scott Davis <scott.davis@starlab.io>, 
	Daniel De Graaf <dgdegra@tycho.nsa.gov>, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 20, 2022 at 1:03 PM Daniel P. Smith
<dpsmith@apertussolutions.com> wrote:
>
> This commit implements full support for starting the idle domain privileged by
> introducing a new flask label xenboot_t which the idle domain is labeled with
> at creation.  It then provides the implementation for the XSM hook
> xsm_transition_running to relabel the idle domain to the existing xen_t flask
> label.
>
> In the reference flask policy a new macro, xen_build_domain(target), is
> introduced for creating policies for dom0less/hyperlaunch allowing the
> hypervisor to create and assign the necessary resources for domain
> construction.
>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> ---

> @@ -188,6 +188,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>
>  static void cf_check flask_domain_runtime_security(void)
>  {
> +    struct domain_security_struct *dsec;
>      struct domain *d = current->domain;
>
>      if ( d->domain_id != DOMID_IDLE )
> @@ -198,6 +199,9 @@ static void cf_check flask_domain_runtime_security(void)
>       * set to false for the consistency check(s) in the setup code.
>       */
>      d->is_privileged = false;
> +
> +    dsec = d->ssid;
> +    dsec->sid = SECINITSID_XEN;

I think you also want
   dsec->self_sid = dsec->sid;
so self also changes to xen_t.

Otherwise I think it looks good,

I was wondering if you were going to require xenboot_t -> xen_t
permissions, but manually setting the sid fields side-steps that.
That seems nicer than requiring policy rules for the transition.

Hmmm, cross referencing other flask code, often after assigning
self_sid there is this call to potentially re-calculate it:
    security_transition_sid(dsec->sid, dsec->sid, SECCLASS_DOMAIN,
&dsec->self_sid);

But it isn't used for system domains, so omitting it seems fine.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 18:32:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 18:32:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309559.525891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhF7f-0006bS-Lv; Wed, 20 Apr 2022 18:32:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309559.525891; Wed, 20 Apr 2022 18:32:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhF7f-0006bL-Iw; Wed, 20 Apr 2022 18:32:15 +0000
Received: by outflank-mailman (input) for mailman id 309559;
 Wed, 20 Apr 2022 18:32:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oHj2=U6=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nhF7W-0006aw-2N
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 18:32:13 +0000
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
 [2a00:1450:4864:20::22a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29762ed7-c0d8-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 20:31:58 +0200 (CEST)
Received: by mail-lj1-x22a.google.com with SMTP id o16so2927373ljp.3
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 11:31:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29762ed7-c0d8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=+Uex363Ymu2/aIWQGUWWDZmYR1B14kPEYvn07kB6+6A=;
        b=mMGet4nXFP8hqh7DiRVCLuRx/7WbKcCcie4WDB7JF/uhVM7ehVcoIe0fhkcJbUEDyE
         bJ/WX4FZ/WlIegchNuGcMdv1YrssPw8vTfRnzFOfFBJtiN9Jag+adlbx5MYQKpl1bMHa
         IiNTzcL6tfB0YJwDalzcLHD6pHynHm3WbJhBuViusWLDOGT5xoPcSRiTFxXC1aj7ZU9+
         MAGh5Z+hUEHZdcFhjh5BJNUxWK92HwxG4X/LwhHARZFp6duizRt0eao2ES7T7N0Cfn9V
         BW6hNgNzqwec43vUNc47pP7IUal1933Lf8UDIcjb1d2wCMgsZEc9VIqy+CJ4/IAkx0U+
         q6rw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=+Uex363Ymu2/aIWQGUWWDZmYR1B14kPEYvn07kB6+6A=;
        b=PHflpTadiLncvkWIvVMvcNFIG7gCtgUxCngt9NmHxuvn/MPs72FbF4i2lRWqXdSVbC
         vCQewWV1MCxcz9ItUfubqGvnnwqfsvg5Nn6RGLZWv7ZOJ/rcm9TNo7a3kZdLV4Vh1c6K
         O5miFTJXgW/G4rzje7+Rvn62WFkJ60xrUIudlnQr+WUhIhUp5CLBcQ+3I462rvfDDisQ
         /e3vCkSRn2xWar6J4kfyxYm/8gMMaaARYmWsPWTAgqpC4LMnYShSO8VtAuxBIJUGgGU2
         zcuUrNK4264+YyReE91zTfsHwsSAxJNnJJL1YjkxgXYXMBlcOrBgxJ8eqGCGArjOQukd
         FMsA==
X-Gm-Message-State: AOAM533VckYvseWXbwv66bRxknVg97T0vi534zmLYn2COMLcLxtBcTx+
	nGfdIbCEk6Zlvk9J5ioxSTHzBPUhjEKzy0IhJow=
X-Google-Smtp-Source: ABdhPJwy514BkdjW/oFG+ptq7vneO01CI5rBVbXtREs+KElvaanyesVY8fpaRZVfuiSMSvZchNmyWs480oiaqZ8QNQw=
X-Received: by 2002:a2e:9c02:0:b0:24d:bcbd:1c77 with SMTP id
 s2-20020a2e9c02000000b0024dbcbd1c77mr9570985lji.19.1650479517842; Wed, 20 Apr
 2022 11:31:57 -0700 (PDT)
MIME-Version: 1.0
References: <20220420210407.18060-1-dpsmith@apertussolutions.com> <20220420210407.18060-2-dpsmith@apertussolutions.com>
In-Reply-To: <20220420210407.18060-2-dpsmith@apertussolutions.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Wed, 20 Apr 2022 14:31:46 -0400
Message-ID: <CAKf6xpsr_0m=tWMjVQsufxSJ52kz3QFzMJvVa0MEKLrtrVM9TQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] xsm: create idle domain privieged and demote after setup
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>, 
	Scott Davis <scott.davis@starlab.io>, Stefano Stabellini <sstabellini@kernel.org>, 
	Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>, Dario Faggioli <dfaggioli@suse.com>, 
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 20, 2022 at 1:02 PM Daniel P. Smith
<dpsmith@apertussolutions.com> wrote:
>
> There are now instances where internal hypervisor logic needs to make resource
> allocation calls that are protectd by XSM checks. The internal hypervisor logic
> is represented a number of system domains which by designed are represented by
> non-privileged struct domain instances. To enable these logic blocks to
> function correctly but in a controlled manner, this commit changes the idle
> domain to be created as a privileged domain under the default policy, which is
> inherited by the SILO policy, and demoted before transitioning to running. A
> new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
> type to demote the idle domain appropriately for that policy type.
>
> For flask a stub is added to ensure that flask policy system will function
> correctly with this patch until flask is extended with support for starting the
> idle domain privileged and properly demoting it on the call to
> xsm_transtion_running.
>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> ---

> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
> index 6f20e17892..72695dcb07 100644
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -621,6 +621,12 @@ static void noreturn init_done(void)
>      void *va;
>      unsigned long start, end;
>
> +    xsm_transition_running();
> +
> +    /* Ensure idle domain was not left privileged */
> +    if ( current->domain->is_privileged )
> +        panic("idle domain did not properly transition from setup privilege\n");

Checking immediately after the XSM hook seems redundant, though I
guess having a sanity check isn't harmful.

>  static void cf_check flask_domain_free_security(struct domain *d)
>  {
>      struct domain_security_struct *dsec = d->ssid;
> @@ -1766,6 +1780,7 @@ static int cf_check flask_argo_send(
>  #endif
>
>  static const struct xsm_ops __initconst_cf_clobber flask_ops = {
> +    .transition_running = flask_domain_runtime_security,

I'd prefer flask_transition_running.  That way grep for the hook name
also finds the flask implementation.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 18:45:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 18:45:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309564.525902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhFJs-0008Gj-Oo; Wed, 20 Apr 2022 18:44:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309564.525902; Wed, 20 Apr 2022 18:44:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhFJs-0008Gc-Lz; Wed, 20 Apr 2022 18:44:52 +0000
Received: by outflank-mailman (input) for mailman id 309564;
 Wed, 20 Apr 2022 18:44:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tIrT=U6=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nhFJr-0008GV-Ea
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 18:44:51 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f43eba40-c0d9-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 20:44:49 +0200 (CEST)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23KGHllo020622; 
 Wed, 20 Apr 2022 18:44:39 GMT
Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta01.appoci.oracle.com [138.1.114.2])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ffmd1a33f-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 20 Apr 2022 18:44:38 +0000
Received: from pps.filterd
 (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23KIg9op038787; Wed, 20 Apr 2022 18:44:38 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3ffm87rwys-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 20 Apr 2022 18:44:37 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BN6PR10MB1298.namprd10.prod.outlook.com (2603:10b6:404:43::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr
 2022 18:44:35 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.014; Wed, 20 Apr 2022
 18:44:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f43eba40-c0d9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=mIgCx3qy+wGt5g+bKCz+mXdTduGa4CCdQN2W26eK25Q=;
 b=kyQspdQrYjw+ur7K2GQQEr4ntUlibCXrPnDG2UuXaHGL/ebDuuoNgAsdPtpY5jR4JkA4
 K5tb3AfEX8NrUYr0XkPkUUTq5xgyXDv/b/kGtRx2taW8m0Nqo0feTvuCePk1C4oZE3JJ
 IR5vW3PcS+D/Q1MkvD1neexV4yJU5/8A6Dti0IxKdCLEk2oF0uS4y4s1Qd6r3av8yU6P
 CewT2zzIrc4Fhgg9+vf3bVow6GqD1aR0xDrz6OqN/wZ/GwANhAecya4WbvsVbTRDfrb1
 7PkqlmgO5tCpK0+bkhlQr/l+b6k5BGmQvxjWdN5LED5spY0nSSlqmtbJOoVfWsTntRx4 XQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a+lasMn6Hf+orNcQ4FZjRThhQA8GP+2opoEvIAbh4gEX3E79iL7qEnGgEenNH4mc2VafaNn8KPbR8qZjyXYYYN28ypwXZRr4lfkaVurO7m/sSmIeQ6R7yaACn7LXAvo+2KIzKGGo6G4/4w7GwW4OX5tyB5vYFcin7jHkIm2LAkFqVu7OK3frUkoD8RoSf+3dcVx0epW7gfE9TYv6Enb7lFTY4W64Rjw4UaiCOrv6Yh0udO5H3sRQl8aalaCQ/HucnaGt78FWqUMBdrfH/pmPJctn0y4cElaowldoaAEWgs51NkN0mzPWkQ38FwRTEq9DdaN65Uz7NEGBQZOo+uYY2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mIgCx3qy+wGt5g+bKCz+mXdTduGa4CCdQN2W26eK25Q=;
 b=oXtOT8ju9HtXXNg+1j1HMHgm1d06Q//VtqwCT9wREK7HH3Qx58Tehj6KtVTtygk5GgqHpBM/ZNDck64vmRegjIAILXEtpmty3WohgsQ084RKaOIh0PN8CekFQ+5PVcbZGgG7LOliDJFoYZK5l5PHz/U51Dna6aZipYlUlMyXRF5veoNhZG5stqbKy7W6p7mLoe9154brMaFzlAgAYb9hgEBbspUkQY9iVeqhfcLKd0J+ZQOvhqIwcXySQS/rfwaOLbJ7/ZrM8YKTAwLMU8hzyfT4ySi1M7Pf+jR+58/0YcyumTfkTSr0buU8cM/0/mroPFvQBngOEZBlXFz8Ip7Cbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mIgCx3qy+wGt5g+bKCz+mXdTduGa4CCdQN2W26eK25Q=;
 b=xc1eAQudVCsIrjvG6Ff/mgXo8DCmgpI5bxoSXiMvkA5MckBvZGOKk9lcN7MMqwYiD4Trp7moR6xh74sEHPuWr/LWaZcHUTrsk5vys9x53yZoYJP0KL6+5FM1Q5V+UNGHm4nlVvcskWfcopOggJc97XB24zPZdWfOOVnNMOEjuBM=
Message-ID: <0d5ae87a-be43-ce7c-57b2-4567bb7e9f4d@oracle.com>
Date: Wed, 20 Apr 2022 14:44:31 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH 09/18] xen/xenbus: add xenbus_setup_ring() service
 function
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20220420150942.31235-1-jgross@suse.com>
 <20220420150942.31235-10-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220420150942.31235-10-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0PR05CA0165.namprd05.prod.outlook.com
 (2603:10b6:a03:339::20) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: be03f60c-e93b-47ea-e95b-08da22fdd0fb
X-MS-TrafficTypeDiagnostic: BN6PR10MB1298:EE_
X-Microsoft-Antispam-PRVS: 
	<BN6PR10MB12982BD7C83E4013F4DA04228AF59@BN6PR10MB1298.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	6y/Y2txxb/33JdxPGJfgPzkbP3SkgPc07T5PShS48yL0LLAShAQwpWOUkOVUaAOEGlpufhMx2PWUHbzPib5v43WPf/TxzBhvfCj5aw7OllV6JfivBmRTpiHbkpQaQzl6WWAn782ldoDEQyY/uJSCu8D7CBiQdoCC0vq3rSWNalZGOxYrzoVe2bFbP5iqxWFypZrcIQ35MwYnwxYNLK7lXTCegGtzkxhCpLqxPHgbRzM7Fl+jYGPQZmVGNgQjd00Uk3P1wETkgKrvrrFNF5UMG283q9NNp3BIVH8VL4tmtXPZnOZyyeUqtEEyOXtyh3khpJmMZNlAXFj7A/1CDap0gIM+WohtZtd25eT6dM/HXT3Vnlop5LzIFcIuP7TkA654lDBmAmJmwjik8s9/Qq1mNJMmN+J0nM/h5PVum/sXw4VGE6hegDpv920cKDhXk1fOluEmDoOH/ouotTmLAORe2SBR8JdK2rXpBtWqPfZ7MR0ylAT/s+nlV9iPB/LQcd9Bmigcy2PzBkxqdGsjs9tjOmRwZ9nV168GFwFe8r0vJD7bihaNRmQjDHYCOWQD9+Do4WKfsXCdBNaVJ69sBklbXuAeuectyvzoYs6nD7m/WHwFDIScFYbmVESDmhoswg3SKAhqvXIagKfVbBzvAzVDFCajkYVPocsdydQGHO5awMzzfIN2sCjil9sJwWsSf1meNRoFggLSZGAlxOORqJAwg+RVaG/EDYqREXU98UtoSrFD0z2HsYbF3CerIBA+n+r1
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(6512007)(2906002)(6506007)(31686004)(6486002)(36756003)(4326008)(86362001)(8936002)(8676002)(31696002)(508600001)(186003)(2616005)(53546011)(26005)(38100700002)(316002)(5660300002)(66946007)(44832011)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Ym12dVI2Y1hMMFhxK0lpYUp1Z3dLTGEwa3NNSUJ1ejAyeS9EVXRvcHVBTS9S?=
 =?utf-8?B?ZUJQRStZRHZiZmFPczc4Qml4dFZwbGRwdUlseUVkTlhmWlYzVmtvOFZlVkZx?=
 =?utf-8?B?enB6OVJ1Tng2Q05CU0VHa1VXS0FMQkhvQzJCUXFPQTZpcVRRTUd6cy9ZL0hr?=
 =?utf-8?B?UW5kT1JXZXp2WnU1a0MzcEd2R2JHcXkyTlBrTVd2NEFVY3QzNitXL3RSNUcz?=
 =?utf-8?B?b21Bbkpjd0phWWpLZFIwOTZFZGhJQy9aN2RPdStid3ZiNmdBWDcwKzZDUzgv?=
 =?utf-8?B?d2JCS2RHNUhsQlNoNG9nOEdnRGJnelZpYzdlNk83YnJiZ1FtaHpZVjNLWWZP?=
 =?utf-8?B?VGZ6TDlaVUQ4OGpvTmFRSGREUFQ2bU1KTktPUjluWDgwWnNSYVc3Uzc5aGlU?=
 =?utf-8?B?THpER29wY0pPbUtyNndxQzVYWUF4aWVMRDR5Q3F2TDVYMTlTOVorUVAvblNr?=
 =?utf-8?B?OWdpcjRFenpRMXZ1THJmcW1tVWF5VWh3SEgrR05PaTlPM3ZuU1pPd2RSaUxU?=
 =?utf-8?B?Rk9rclZsdzRtYU94QXpzZlhRcHJKUXJIRkVNejd3eWRBajVRenJKbEFtTmcx?=
 =?utf-8?B?enRmZ2VmN3c4cjJFMDg5TUp2YmZ2blZHa1NPa2ZoY3diWGUzcVEvM0dWYmxG?=
 =?utf-8?B?QSthR0habmliN1VtUTd6K0xRQmhabExEUmg4U3JHaGNCOE9URWlUb0lmNnhZ?=
 =?utf-8?B?M0FjTkJHakFDOFBUclNMcWw5ZFFJRUJaSzZxZUVaYml5bWNqVXg5NE56VExX?=
 =?utf-8?B?SFZXUWRMYWNwN3kza3dQRytiM1RTL3QyVDFKSUluWnJuaVFLNHBRTStWWklO?=
 =?utf-8?B?OXBsTjR1MDc2V0RYOVFsak5XQTZzWEJRd25zNlUxeExBaFFvaUVBdUx2OEcr?=
 =?utf-8?B?MWZYUTNpc3YwcUhlSlRFdE1QZXdyeHk4WXJQZWxpSWZEeERpc3NBNXlsMmxM?=
 =?utf-8?B?cUFWbnJYeTNGdWNGelBVUExRNlU1dzVDNlBTOG43cng1clQ0S0NDcXo5NFRn?=
 =?utf-8?B?NkVNd0Z6MkVhbnVNMVJWTElheFFSdVFBODQyTmVRRGNKWVk4ZkMyQW1UL0dM?=
 =?utf-8?B?TTZKa0pnaWIzOVZoRXZpUXhLWmxSZm9lbDYvOVVSaHNJWW9TbzdpTTYyaVNH?=
 =?utf-8?B?a2R4UFlJWFNDbDBvajl1VEV2NytEUEM5Z3o5ZWFFaDlhYVYvYnI2LzlnMG00?=
 =?utf-8?B?d2pndnJMbjYvSVlhQmZqTHFsc3FlMDV0QjBETE4wL3c0NXhwd3dQN2lqOEFD?=
 =?utf-8?B?Z3FoamVLa1ZuWEhNWHFDQWlySUY3QWU1NHoyS0FqUDZCWnJSbDVFdzIyWGtI?=
 =?utf-8?B?ZWxtWnlKZVF6cmtGZkE3YU9zd3I4MjZaRWNXZWl4TUxPQ0JZUDZoQzRxa3JH?=
 =?utf-8?B?U25RbSs0KzR3R2NqVS90QjhQV2xCc2xWNVh5aWh3V1RBNnZmR2lMNHphMWpT?=
 =?utf-8?B?R2VrRDF0S2lSdUNwdnZsNHBLTGdQUEdBcStDTVFMMHNxdGwvVEpVSU04TnMx?=
 =?utf-8?B?RkZTMzlhZjRoVUZMc0NrU0NxTHRFYXRwMFR6dlF0WW12NU9mcjdJMHhNa2dh?=
 =?utf-8?B?aDZqSGphQWd5NUFPeGxkVFgzSTVkRVJSdjk3b1ZxTWdrS1ZCMVgyRFIwcWJt?=
 =?utf-8?B?OHRLU1BYUjR3eTh4aUh1RWhkc2dGSkZOMmluenVZVWV3UUNxWUxMUEg1T2dY?=
 =?utf-8?B?R2hQMFZ6SUxyMlh4c1dUQldxS2htRWMzNk5jY3E1RnZ3YkNtSlM5YWxtZWJP?=
 =?utf-8?B?S2xENHNpMDVtRW1mOGxPakZVVGJ2Wlo2cExLcDZNWnVYSmk2N0RnaiszK0FE?=
 =?utf-8?B?aGlGU3VHRm10Y1p1WmMzd3VVZTZqSkJxaUVVWCswMkFpWEY5VmpoTnRuZGpO?=
 =?utf-8?B?ZjFudnZPMWw1ZFZHbWNGWVpoTkpYSDNOMnk4Vy8yRnNsbnR1OVBvbGt5V20y?=
 =?utf-8?B?ZlR4d0JMTXZTcHFWcUpNZWV3bUlKcjFPdUgwL01tbHhmVVVkdVdYWWc1dXFS?=
 =?utf-8?B?elNXTWc5VWd2MXBjczAvbi81dWd4ZEtjY3pWR1dqaWdZUjR5NDdvNFI2OGpO?=
 =?utf-8?B?L3d0QXkyZ2tqMHFXa1ptbFNmWFgzcTQ0UUZFS3FyY2JNUU1MdGxSME84dUc0?=
 =?utf-8?B?YXcxcnNnUERlWWNkSUpWYkhYWmdEc2NlMnlVRlJBay9UenNYcWFySU4wUVNB?=
 =?utf-8?B?dGo0TEdSYVpwUTRJY2F1UXdQNmZXY0RvR3V2N3NYSUcwQ1VjT2kvOXZvMTI3?=
 =?utf-8?B?Kytaa3lmK3lxS0RoT0Y2cTFicjNvSmdYeUkyZlVYZmpxeTNGUStxeURXZUpD?=
 =?utf-8?B?bHEyZjZJVUJuNGJURmkyTG9yZ3IyWlE2UC9LOC9HQWRFaEhwVVlzSjk4U0xz?=
 =?utf-8?Q?dBC1Y13ur6yx7u5w=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be03f60c-e93b-47ea-e95b-08da22fdd0fb
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 18:44:35.6305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8k4Tpv0aYB2mfDatVOe+KiHEkY3kqg4I/kOarKpMqjl66+ceUpiMHaDQuvfuHd/+me4Ygyh8mwLyaD1wBZiychxssPJvKff1902bleT8JBQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1298
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-20_05:2022-04-20,2022-04-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204200110
X-Proofpoint-ORIG-GUID: Xq-Lrdf6vHn9cHvuS_ocp4uWE9Xzpwg9
X-Proofpoint-GUID: Xq-Lrdf6vHn9cHvuS_ocp4uWE9Xzpwg9


On 4/20/22 11:09 AM, Juergen Gross wrote:
>   
> +/*
> + * xenbus_setup_ring
> + * @dev: xenbus device
> + * @vaddr: pointer to starting virtual address of the ring
> + * @nr_pages: number of pages to be granted
> + * @grefs: grant reference array to be filled in
> + *
> + * Allocate physically contiguous pages for a shared ring buffer and grant it
> + * to the peer of the given device. The ring buffer is initially filled with
> + * zeroes. The virtual address of the ring is stored at @vaddr and the
> + * grant references are stored in the @grefs array. In case of error @vaddr
> + * will be set to NULL and @grefs will be filled with INVALID_GRANT_REF.
> + */
> +int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
> +		      unsigned int nr_pages, grant_ref_t *grefs)
> +{
> +	unsigned long ring_size = nr_pages * XEN_PAGE_SIZE;
> +	unsigned int i;
> +	int ret;
> +
> +	*vaddr = alloc_pages_exact(ring_size, gfp | __GFP_ZERO);
> +	if (!*vaddr) {
> +		ret = -ENOMEM;
> +		goto err;
> +	}
> +
> +	ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs);
> +	if (ret)
> +		goto err;
> +
> +	return 0;
> +
> + err:
> +	if (*vaddr)
> +		free_pages_exact(*vaddr, ring_size);
> +	for (i = 0; i < nr_pages; i++)
> +		grefs[i] = INVALID_GRANT_REF;
> +	*vaddr = NULL;
> +
> +	return ret;
> +}


We can create a wrapper around this function that will also call SHARED_RING_INIT() and FRONT_RING_INIT(). A bunch of drivers do that.


-boris



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 18:47:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 18:47:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309569.525914 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhFMV-0000RO-71; Wed, 20 Apr 2022 18:47:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309569.525914; Wed, 20 Apr 2022 18:47:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhFMV-0000RH-3X; Wed, 20 Apr 2022 18:47:35 +0000
Received: by outflank-mailman (input) for mailman id 309569;
 Wed, 20 Apr 2022 18:47:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tmf/=U6=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1nhFMT-0000RB-KH
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 18:47:33 +0000
Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com
 [209.85.219.176]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54db6a4a-c0da-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 20:47:30 +0200 (CEST)
Received: by mail-yb1-f176.google.com with SMTP id x39so4500208ybd.8
 for <xen-devel@lists.xenproject.org>; Wed, 20 Apr 2022 11:47:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54db6a4a-c0da-11ec-8fbf-03012f2f19d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=dE5RadEMib60o9KVjQcUjy+eJ3gNL/iiBHhDxgP/GWk=;
        b=t9blxEOmHQhDrFOiKxFqdLphbs40G+g+5I2gN0fSqL/+/Q4WZprtbQXDFDiJibLn+V
         NMlyFDmii3bjieVLZwtfxfk3ite6B8wfa0qJGjt5FLrahqDQjFaqYBov02Vjvz3rbLAN
         Xb+cSjzx+C9WkxW0DVOP8y5JlLkCWxYjS1XWA5MBm3KMOzm1VYAyyDHfer+R7j112hWn
         346BhleePPgVwZo1XtwSOuuRxwqoXvIlgrwaKaDGvU0UvsIoosCtHZpE3iVBqF7wdYpB
         YNOu+M8Tvj0VaZapaZhMm/v0wjzQQhnmpaCESXeLjs/HD05TQMrKFGpGpPjuGT+//W52
         iQfQ==
X-Gm-Message-State: AOAM5313P+lrUJYWb1M/hQHI8U/wkZjfoEgTdcppLVONTP0lhWOcZLH3
	JtX1BcikUZ3gXBL1vIZOhCKU6dvMQUWWCpvUkzw=
X-Google-Smtp-Source: ABdhPJy0l46FqKK3F6TPwNoLPQjTN9iZHgvIu9g3S+a+hhpuyVO+CbVALwAXm8q/rJbzWksFWeDjWWSShgdOVqSqVVo=
X-Received: by 2002:a05:6902:187:b0:63d:9c95:edca with SMTP id
 t7-20020a056902018700b0063d9c95edcamr20821310ybh.81.1650480449135; Wed, 20
 Apr 2022 11:47:29 -0700 (PDT)
MIME-Version: 1.0
References: <20220411233832.391817-1-dmitry.osipenko@collabora.com>
 <20220411233832.391817-5-dmitry.osipenko@collabora.com> <CAJZ5v0gnTSoeNP+QXwrZ45FQY4howVkJMuCjM=j+_-2BngJdQg@mail.gmail.com>
 <990621e7-9f8a-8b4a-02ec-fd6c1e1f48ff@collabora.com>
In-Reply-To: <990621e7-9f8a-8b4a-02ec-fd6c1e1f48ff@collabora.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 20 Apr 2022 20:47:17 +0200
Message-ID: <CAJZ5v0jxXtwot0qpib4UG8Tz8Hd1dEbgo58tEdPFboU8xwKHNw@mail.gmail.com>
Subject: Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler
 call chain API
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, 
	Jonathan Hunter <jonathanh@nvidia.com>, Russell King <linux@armlinux.org.uk>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, 
	Lee Jones <lee.jones@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	=?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>, linux-parisc@vger.kernel.org, 
	linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>, 
	xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, Apr 18, 2022 at 3:44 AM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
>
> On 4/15/22 21:14, Rafael J. Wysocki wrote:
> > Honestly, I would prefer this to be split so as to make it easier to
> > review if nothing else.
>
> I'll try to split it in v8.
>
> > On Tue, Apr 12, 2022 at 1:39 AM Dmitry Osipenko
> > <dmitry.osipenko@collabora.com> wrote:
> >>
> >> SoC platforms often have multiple ways of how to perform system's
> >> power-off and restart operations. Meanwhile today's kernel is limited to
> >> a single option. Add combined power-off+restart handler call chain API,
> >> which is inspired by the restart API. The new API provides both power-off
> >> and restart functionality.
> >>
> >> The old pm_power_off method will be kept around till all users are
> >> converted to the new API.
> >>
> >> Current restart API will be replaced by the new unified API since
> >> new API is its superset. The restart functionality of the sys-off handler
> >> API is built upon the existing restart-notifier APIs.
> >
> > Which means that the existing notifier chains for system restart are
> > used as they are without modifications.
> >
> > At least that's what follows from the code and it would be good to
> > mention it here.
>
> Will improve the commit message.
>
> > Moreover, a new notifier chain is introduced for the power-off case
> > and it appears to be the counterpart of the restart_handler_list
> > chain, but then why is it blocking and not atomic like the latter?
>
> Good catch, it probably indeed should be atomic because shutting down
> could run with a disabled interrupts. I'll invistigate this more for v8,
> at least right now I don't recall any particular reason for using the
> blocking notifier.
>
> >> In order to ease conversion to the new API, convenient helpers are added
> >> for the common use-cases. They will reduce amount of boilerplate code and
> >> remove global variables. These helpers preserve old behaviour for cases
> >> where only one power-off handler is expected, this is what all existing
> >> drivers want, and thus, they could be easily converted to the new API.
> >> Users of the new API should explicitly enable power-off chaining by
> >> setting corresponding flag of the power_handler structure.
> >
> > "the corresponding"
>
> Thanks
>
> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> ---
> >>  include/linux/reboot.h   | 229 ++++++++++++++-
> >>  kernel/power/hibernate.c |   2 +-
> >>  kernel/reboot.c          | 604 ++++++++++++++++++++++++++++++++++++++-
> >>  3 files changed, 827 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/include/linux/reboot.h b/include/linux/reboot.h
> >> index a2429648d831..ba5e5dddcfcd 100644
> >> --- a/include/linux/reboot.h
> >> +++ b/include/linux/reboot.h
> >> @@ -8,10 +8,35 @@
> >>
> >>  struct device;
> >>
> >> -#define SYS_DOWN       0x0001  /* Notify of system down */
> >> -#define SYS_RESTART    SYS_DOWN
> >> -#define SYS_HALT       0x0002  /* Notify of system halt */
> >> -#define SYS_POWER_OFF  0x0003  /* Notify of system power off */
> >> +enum reboot_prepare_mode {
> >> +       SYS_DOWN = 1,           /* Notify of system down */
> >> +       SYS_RESTART = SYS_DOWN,
> >> +       SYS_HALT,               /* Notify of system halt */
> >> +       SYS_POWER_OFF,          /* Notify of system power off */
> >> +};
> >> +
> >> +/*
> >> + * Standard restart priority levels. Intended to be set in the
> >> + * sys_off_handler.restart_priority field.
> >> + *
> >> + * Use `RESTART_PRIO_ABC +- prio` style for additional levels.
> >> + *
> >> + * RESTART_PRIO_RESERVED:      Falls back to RESTART_PRIO_DEFAULT.
> >> + *                             Drivers may leave priority initialized
> >> + *                             to zero, to auto-set it to the default level.
> >
> > What is the "default level" here?
>
> "default level" = RESTART_PRIO_DEFAULT = 128
>
> I'll remove the second sentence about the "default level", for clarity.
>
> >> + *
> >> + * RESTART_PRIO_LOW:           Use this for handler of last resort.
> >> + *
> >> + * RESTART_PRIO_DEFAULT:       Use this for default/generic handler.
> >> + *
> >> + * RESTART_PRIO_HIGH:          Use this if you have multiple handlers and
> >> + *                             this handler has higher priority than the
> >> + *                             default handler.
> >> + */
> >> +#define RESTART_PRIO_RESERVED          0
> >> +#define RESTART_PRIO_LOW               8
> >> +#define RESTART_PRIO_DEFAULT           128
> >> +#define RESTART_PRIO_HIGH              192
> >>
> >>  enum reboot_mode {
> >>         REBOOT_UNDEFINED = -1,
> >> @@ -49,6 +74,201 @@ extern int register_restart_handler(struct notifier_block *);
> >>  extern int unregister_restart_handler(struct notifier_block *);
> >>  extern void do_kernel_restart(char *cmd);
> >>
> >> +/*
> >> + * System power-off and restart API.
> >> + */
> >> +
> >> +/*
> >> + * Standard power-off priority levels. Intended to be set in the
> >> + * sys_off_handler.power_off_priority field.
> >> + *
> >> + * Use `POWEROFF_PRIO_ABC +- prio` style for additional levels.
> >
> > What exactly does this mean?
>
> "POWEROFF_PRIO_DEFAULT+1 or POWEROFF_PRIO_DEFAULT-1" for example, I'll
> improve it in v8.

So the users of this interface are expected to set priorities relative
to the "standard" levels.  That wasn't clear.

> >> + *
> >> + * POWEROFF_PRIO_RESERVED:     Falls back to POWEROFF_PRIO_DEFAULT.
> >> + *                             Drivers may leave priority initialized
> >> + *                             to zero, to auto-set it to the default level.
> >> + *
> >> + * POWEROFF_PRIO_PLATFORM:     Intended to be used by platform-level handler.
> >> + *                             Has lowest priority since device drivers are
> >> + *                             expected to take over platform handler which
> >> + *                             doesn't allow further callback chaining.
> >> + *
> >> + * POWEROFF_PRIO_DEFAULT:      Use this for default/generic handler.
> >> + *
> >> + * POWEROFF_PRIO_FIRMWARE:     Use this if handler uses firmware call.
> >> + *                             Has highest priority since firmware is expected
> >> + *                             to know best how to power-off hardware properly.
> >> + */
> >> +#define POWEROFF_PRIO_RESERVED         0
> >> +#define POWEROFF_PRIO_PLATFORM         1
> >> +#define POWEROFF_PRIO_DEFAULT          128
> >> +#define POWEROFF_PRIO_HIGH             192
> >> +#define POWEROFF_PRIO_FIRMWARE         224
> >> +
> >> +enum poweroff_mode {
> >> +       POWEROFF_NORMAL = 0,
> >
> > Why not just POWEROFF?
>
> This is a bit too generic name to me.
>
> I can rename it as MODE_POWEROFF and MODE_POWEROFF_PREPARE.

In that case I would leave POWEROFF_PREPARE as is and rename the other
one to POWEROFF_FINAL.  And maybe put them in the reverse order in the
enum definition, because _PREPARE will be done before _FINAL.

> >> +       POWEROFF_PREPARE,
> >> +};
> >> +
> >> +/**
> >> + * struct power_off_data - Power-off callback argument
> >> + *
> >> + * @cb_data: Callback data.
> >> + */
> >> +struct power_off_data {
> >> +       void *cb_data;
> >> +};
> >> +
> >> +/**
> >> + * struct power_off_prep_data - Power-off preparation callback argument
> >> + *
> >> + * @cb_data: Callback data.
> >> + */
> >> +struct power_off_prep_data {
> >> +       void *cb_data;
> >> +};
> >
> > Why does this need to be a separate data type?
>
> To allow us extend the "struct power_off_prep_data" with more parameters
> later on without a need to update each driver with the new arguments.

I'm not really sure what you mean here.  Can you give an example?

> >> +
> >> +/**
> >> + * struct restart_data - Restart callback argument
> >> + *
> >> + * @cb_data: Callback data.
> >> + * @cmd: Restart command string.
> >> + * @stop_chain: Further lower priority callbacks won't be executed if set to
> >> + *             true. Can be changed within callback. Default is false.
> >> + * @mode: Reboot mode ID.
> >> + */
> >> +struct restart_data {
> >> +       void *cb_data;
> >> +       const char *cmd;
> >> +       bool stop_chain;
> >> +       enum reboot_mode mode;
> >> +};
> >> +
> >> +/**
> >> + * struct reboot_prep_data - Reboot and shutdown preparation callback argument
> >> + *
> >> + * @cb_data: Callback data.
> >> + * @cmd: Restart command string.
> >> + * @stop_chain: Further lower priority callbacks won't be executed if set to
> >> + *             true. Can be changed within callback. Default is false.
> >> + * @mode: Preparation mode ID.
> >> + */
> >> +struct reboot_prep_data {
> >> +       void *cb_data;
> >> +       const char *cmd;
> >> +       bool stop_chain;
> >> +       enum reboot_prepare_mode mode;
> >> +};
> >
> > There seem to be some duplicate data items between struct restart_data
> > and struct reboot_prep_data, so what's the reason why they are
> > separate?
>
> They indeed look similar, but have different purposes. We shouldn't use
> reboot handler for restarting, hence why should we mix them?

Well, I got confused by the naming.

The "reboot prep" thing really should be a "system is going down"
notification.  Since "sysoff" is already used in the names below, why
not rename it to "sysoff_prepare"?

> >> +struct sys_off_handler_private_data {
> >> +       struct notifier_block power_off_nb;
> >> +       struct notifier_block restart_nb;
> >> +       struct notifier_block reboot_nb;
> >
> > So restart_nb is going to be added to restart_handler_list, eboot_nb
> > will be added to reboot_notifier_list (which both exist already) and
> > power_off_nb will be added to the new power_off_handler_list, right?
> >
> > Of course, this means that reboot_nb will be used in
> > kernel_restart_prepare() and kernel_shutdown_prepare(), so the
> > corresponding callback will be invoked in both the restart and
> > power-off cases.
> >
> > It would be good to document that somehow.
>
> This is documented in the doc-comment to struct sys_off_handler later in
> this patch. You actually found it below.

IMO, it would be better to document it here, because that's where
people will look first, as a rule.

> >> +       void (*platform_power_off_cb)(void);
> >> +       void (*simple_power_off_cb)(void *data);
> >> +       void *simple_power_off_cb_data;
> >
> > Is there any particular reason to put these callbacks here and not
> > directly into struct sys_off_handler?
>
> They are used internally by reboot.c and shouldn't be touched by the
> kernel API users, so I wanted to factor out and protect all the private
> data.

But they come from these users anyway, don't they?

> >> +       bool registered;
> >> +};
> >> +
> >> +/**
> >> + * struct sys_off_handler - System power-off and restart handler
> >> + *
> >> + * @cb_data: Pointer to user's data.
> >> + *
> >> + * @power_off_cb: Callback that powers off this machine. Inactive if NULL.
> >> + *
> >> + * @power_off_prepare_cb: Power-off preparation callback. All power-off
> >> + * preparation callbacks are invoked after @reboot_prepare_cb and before
> >> + * @power_off_cb. Inactive if NULL.
> >> + *
> >> + * @power_off_priority: Power-off callback priority, must be unique.
> >> + * Zero value is reserved and auto-reassigned to POWEROFF_PRIO_DEFAULT.
> >> + * Inactive if @power_off_cb is NULL.
> >> + *
> >> + * @power_off_chaining_allowed: Set to false if callback's execution should
> >> + * stop when @power_off_cb fails to power off this machine. True if further
> >> + * lower priority power-off callback should be executed. False is default
> >> + * value.
> >> + *
> >> + * @restart_cb: Callback that reboots this machine. Inactive if NULL.
> >> + *
> >> + * @restart_priority: Restart callback priority, must be unique. Zero value
> >> + * is reserved and auto-reassigned to RESTART_PRIO_DEFAULT. Inactive if
> >> + * @restart_cb is NULL.
> >> + *
> >> + * @restart_chaining_disallowed: Set to true if callback's execution should
> >> + * stop when @restart_cb fails to restart this machine. False if further
> >> + * lower priority restart callback should be executed. False is default
> >> + * value.
> >> + *
> >> + * @reboot_prepare_cb: Reboot/shutdown preparation callback. All reboot
> >> + * preparation callbacks are invoked before @restart_cb or @power_off_cb,
> >> + * depending on the mode. It's registered with register_reboot_notifier().
> >> + * The point is to remove boilerplate code from drivers which use this
> >> + * callback in conjunction with the restart/power-off callbacks.
> >> + *
> >> + * @reboot_priority: Reboot/shutdown preparation callback priority, doesn't
> >> + * need to be unique. Zero is default value. Inactive if @reboot_prepare_cb
> >> + * is NULL.
> >
> > It is unclear that the ->reboot_prepare_cb() callback is going to be
> > used for both restart and power-off and reboot_priority is about the
> > preparation phase only.
> >
> > And in the preparation phase the priority may not matter that much,
> > because there are users who don't care about the ordering as long as
> > their stuff is called at all.
> >
> > Honestly, I would change the naming here, because what it is is quite
> > confusing at least to me.  Especially that "restart" and "reboot" seem
> > to be used interchangeably in the comments.
>
> These are the legacy names and they are indeed very confusing. Do you
> have suggestion for a better names?

Well, as I said above, I would rename the "reboot" thing to
"sysoff_prepare" covering all of the cases.  And then either "restart"
or "poweroff" would be called after that, depending on the specific
case.

On a slightly related note, I started to wonder about the actual value
provided by struct sys_off_handler.  Namely, the existing "reboot" and
"restart" notifier chains will be used anyway and there are ways to
use them directly.  Also, there will be ways to use the new "poweroff"
chain directly, so struct sys_off_handler appears to be an extra
complication and it is not particularly easier to use than a
combination of "raw" notifiers.

It looks to me that it might be sufficient to have a way to register a
callback for "sysoff_prepare" (aka "reboot") and "restart" and a pair
of callbacks for "poweroff", with a given priority with all of the
necessary internals taken care of by the framework.

> >> + *
> >> + * @priv: Internal data. Shouldn't be touched.
> >> + *
> >> + * Describes power-off and restart handlers which are invoked by kernel
> >> + * to power off or restart this machine. Supports prioritized chaining for
> >> + * both restart and power-off handlers.
> >> + *
> >> + * Struct sys_off_handler can be static. Members of this structure must not be
> >> + * altered while handler is registered.
> >> + *
> >> + * Fill the structure members and pass it to @register_sys_off_handler().
> >> + */
> >> +struct sys_off_handler {
> >> +       void *cb_data;
> >> +
> >> +       void (*power_off_cb)(struct power_off_data *data);
> >> +       void (*power_off_prepare_cb)(struct power_off_prep_data *data);
> >> +       int power_off_priority;
> >> +       bool power_off_chaining_allowed;
> >> +
> >> +       void (*restart_cb)(struct restart_data *data);
> >> +       int restart_priority;
> >> +       bool restart_chaining_disallowed;
> >> +
> >> +       void (*reboot_prepare_cb)(struct reboot_prep_data *data);
> >> +       int reboot_priority;
> >> +
> >> +       const struct sys_off_handler_private_data priv;
> >
> > Why is it const?  Because of the callbacks in there?
>
> It's const to prevent changing/abusing of the internal data by kernel
> API users. Those callbacks are private to kernel/reboot.c
>
> > Doesn't this mean that all struct sys_off_handler need to be static?
>
> The reboot.c is allowed to modify the private data, sys_off_handler can
> be static and dynamic. There is no limitaion, I made the 'priv' member
> constant only for the API users.

Well, to me it is confusing and it doesn't really make the intention clear.

Personally, I'd call it something like "internal_leave_alone" or similar.

> >> +};
> >> +
> >> +int register_sys_off_handler(struct sys_off_handler *handler);
> >> +int unregister_sys_off_handler(struct sys_off_handler *handler);
> >> +
> >> +int devm_register_sys_off_handler(struct device *dev,
> >> +                                 struct sys_off_handler *handler);
> >> +
> >> +int devm_register_prioritized_power_off_handler(struct device *dev,
> >> +                                               int priority,
> >> +                                               void (*callback)(void *data),
> >> +                                               void *cb_data);
> >> +
> >> +int devm_register_simple_power_off_handler(struct device *dev,
> >> +                                          void (*callback)(void *data),
> >> +                                          void *cb_data);
> >> +
> >> +int register_platform_power_off(void (*power_off)(void));
> >> +int unregister_platform_power_off(void (*power_off)(void));
> >> +
> >> +int devm_register_prioritized_restart_handler(struct device *dev,
> >> +                                             int priority,
> >> +                                             void (*callback)(struct restart_data *data),
> >> +                                             void *cb_data);
> >> +
> >> +int devm_register_simple_restart_handler(struct device *dev,
> >> +                                        void (*callback)(struct restart_data *data),
> >> +                                        void *cb_data);
> >> +
> >> +void do_kernel_power_off(void);
> >> +
> >>  /*
> >>   * Architecture-specific implementations of sys_reboot commands.
> >>   */
> >> @@ -70,6 +290,7 @@ extern void kernel_restart_prepare(char *cmd);
> >>  extern void kernel_restart(char *cmd);
> >>  extern void kernel_halt(void);
> >>  extern void kernel_power_off(void);
> >> +extern bool kernel_can_power_off(void);
> >>
> >>  void ctrl_alt_del(void);
> >>
> >> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> >> index 938d5c78b421..a9464b4a3209 100644
> >> --- a/kernel/power/hibernate.c
> >> +++ b/kernel/power/hibernate.c
> >> @@ -665,7 +665,7 @@ static void power_down(void)
> >>                 hibernation_platform_enter();
> >>                 fallthrough;
> >>         case HIBERNATION_SHUTDOWN:
> >> -               if (pm_power_off)
> >> +               if (kernel_can_power_off())
> >>                         kernel_power_off();
> >>                 break;
> >>         }
> >> diff --git a/kernel/reboot.c b/kernel/reboot.c
> >> index acdae4e95061..e76e2570dcf5 100644
> >> --- a/kernel/reboot.c
> >> +++ b/kernel/reboot.c
> >> @@ -296,6 +296,595 @@ void kernel_halt(void)
> >>  }
> >>  EXPORT_SYMBOL_GPL(kernel_halt);
> >>
> >> +/*
> >> + *     Notifier list for kernel code which wants to be called
> >> + *     to power off the system.
> >> + */
> >> +static BLOCKING_NOTIFIER_HEAD(power_off_handler_list);
> >> +
> >> +/*
> >> + * Temporary stub that prevents linkage failure while we're in process
> >> + * of removing all uses of legacy pm_power_off() around the kernel.
> >
> > Nit: inconsistent comment formatting.
> >
> >> + */
> >> +void __weak (*pm_power_off)(void);
> >> +
> >> +static void dummy_pm_power_off(void)
> >> +{
> >> +       /* temporary stub until pm_power_off() is gone, see more below */
> >> +}
> >> +
> >> +static struct notifier_block *pm_power_off_nb;
> >> +
> >> +/**
> >> + *     register_power_off_handler - Register function to be called to power off
> >> + *                                  the system
> >> + *     @nb: Info about handler function to be called
> >> + *     @nb->priority:  Handler priority. Handlers should follow the
> >> + *                     following guidelines for setting priorities.
> >> + *                     0:      Reserved
> >> + *                     1:      Power-off handler of last resort,
> >> + *                             with limited power-off capabilities
> >> + *                     128:    Default power-off handler; use if no other
> >> + *                             power-off handler is expected to be available,
> >> + *                             and/or if power-off functionality is
> >> + *                             sufficient to power-off the entire system
> >> + *                     255:    Highest priority power-off handler, will
> >> + *                             preempt all other power-off handlers
> >> + *
> >> + *     Registers a function with code to be called to power off the
> >> + *     system.
> >
> > Because this is only used internally in this file, I'd say what it
> > does directly, that is "Add a notifier to the power-off chain used for
> > powering off the system".
>
> I'll improve it, thanks.
>
> >> + *
> >> + *     Registered functions will be called as last step of the power-off
> >> + *     sequence.
> >> + *
> >> + *     Registered functions are expected to power off the system immediately.
> >> + *     If more than one function is registered, the power-off handler priority
> >> + *     selects which function will be called first.
> >> + *
> >> + *     Power-off handlers are expected to be registered from non-architecture
> >> + *     code, typically from drivers. A typical use case would be a system
> >> + *     where power-off functionality is provided through a PMIC. Multiple
> >> + *     power-off handlers may exist; for example, one power-off handler might
> >> + *     turn off the entire system, while another only turns off part of
> >> + *     system. In such cases, the power-off handler which only disables part
> >> + *     of the hardware is expected to register with low priority to ensure
> >> + *     that it only runs if no other means to power off the system is
> >> + *     available.
> >
> > I would move the above 3 paragraphs to the description comment for
> > power_off_handler_list.
>
> Noted
>
> >> + *
> >> + *     Currently always returns zero, as blocking_notifier_chain_register()
> >> + *     always returns zero.
> >> + */
> >> +static int register_power_off_handler(struct notifier_block *nb)
> >> +{
> >> +       int ret;
> >> +
> >> +       ret = blocking_notifier_chain_register_unique_prio(&power_off_handler_list, nb);
> >> +       if (ret && ret != -EBUSY)
> >> +               return ret;
> >> +
> >> +       if (!ret)
> >> +               goto set_pm_power_off;
> >> +
> >> +       /*
> >> +        * Handler must have unique priority. Otherwise call order is
> >> +        * determined by registration order, which is unreliable.
> >> +        *
> >> +        * This requirement will become mandatory once all drivers
> >> +        * will be converted to use new sys-off API.
> >> +        */
> >> +       pr_err("failed to register power-off handler using unique priority\n");
> >> +
> >> +       ret = blocking_notifier_chain_register(&power_off_handler_list, nb);
> >> +       if (ret)
> >> +               return ret;
> >> +
> >> +       /*
> >> +        * Some drivers check whether pm_power_off was already installed.
> >> +        * Install dummy callback using new API to preserve old behaviour
> >> +        * for those drivers during period of transition to the new API.
> >> +        */
> >> +set_pm_power_off:
> >> +       if (!pm_power_off) {
> >> +               pm_power_off = dummy_pm_power_off;
> >> +               pm_power_off_nb = nb;
> >> +       }
> >> +
> >> +       return 0;
> >> +}
> >> +
> >> +static int unregister_power_off_handler(struct notifier_block *nb)
> >> +{
> >> +       if (nb == pm_power_off_nb) {
> >> +               if (pm_power_off == dummy_pm_power_off)
> >> +                       pm_power_off = NULL;
> >> +
> >> +               pm_power_off_nb = NULL;
> >> +       }
> >> +
> >> +       return blocking_notifier_chain_unregister(&power_off_handler_list, nb);
> >> +}
> >> +
> >> +static void devm_unregister_power_off_handler(void *data)
> >> +{
> >> +       struct notifier_block *nb = data;
> >> +
> >> +       unregister_power_off_handler(nb);
> >> +}
> >> +
> >> +static int devm_register_power_off_handler(struct device *dev,
> >> +                                          struct notifier_block *nb)
> >> +{
> >> +       int err;
> >> +
> >> +       err = register_power_off_handler(nb);
> >> +       if (err)
> >> +               return err;
> >> +
> >> +       return devm_add_action_or_reset(dev, devm_unregister_power_off_handler,
> >> +                                       nb);
> >> +}
> >> +
> >> +static int sys_off_handler_power_off(struct notifier_block *nb,
> >> +                                    unsigned long mode, void *unused)
> >> +{
> >> +       struct power_off_prep_data prep_data = {};
> >> +       struct sys_off_handler_private_data *priv;
> >> +       struct power_off_data data = {};
> >> +       struct sys_off_handler *h;
> >> +       int ret = NOTIFY_DONE;
> >> +
> >> +       priv = container_of(nb, struct sys_off_handler_private_data, power_off_nb);
> >> +       h = container_of(priv, struct sys_off_handler, priv);
> >> +       prep_data.cb_data = h->cb_data;
> >> +       data.cb_data = h->cb_data;
> >> +
> >> +       switch (mode) {
> >> +       case POWEROFF_NORMAL:
> >> +               if (h->power_off_cb)
> >> +                       h->power_off_cb(&data);
> >> +
> >> +               if (priv->simple_power_off_cb)
> >> +                       priv->simple_power_off_cb(priv->simple_power_off_cb_data);
> >> +
> >> +               if (priv->platform_power_off_cb)
> >> +                       priv->platform_power_off_cb();
> >
> > The invocation of the priv callbacks here confuses me quite a bit.
> >
> > Can you please at least add a comment explaining this?
>
> Sure
>
> >> +
> >> +               if (!h->power_off_chaining_allowed)
> >> +                       ret = NOTIFY_STOP;
> >> +
> >> +               break;
> >> +
> >> +       case POWEROFF_PREPARE:
> >> +               if (h->power_off_prepare_cb)
> >> +                       h->power_off_prepare_cb(&prep_data);
> >> +
> >> +               break;
> >> +
> >> +       default:
> >> +               unreachable();
> >> +       }
> >> +
> >> +       return ret;
> >> +}
> >> +
> >> +static int sys_off_handler_restart(struct notifier_block *nb,
> >> +                                  unsigned long mode, void *cmd)
> >> +{
> >> +       struct sys_off_handler_private_data *priv;
> >> +       struct restart_data data = {};
> >> +       struct sys_off_handler *h;
> >> +
> >> +       priv = container_of(nb, struct sys_off_handler_private_data, restart_nb);
> >> +       h = container_of(priv, struct sys_off_handler, priv);
> >> +
> >> +       data.stop_chain = h->restart_chaining_disallowed;
> >> +       data.cb_data = h->cb_data;
> >> +       data.mode = mode;
> >> +       data.cmd = cmd;
> >> +
> >> +       h->restart_cb(&data);
> >
> > Wouldn't it be a bit more straightforward to allow ->restart_cb() to
> > return a value being either NOTIFY_STOP or NOTIFY_DONE?
>
> Vast majority of drivers don't use the 'stop_chain', hence it's
> unnecessary boilerplate code for drivers. The code looks nicer without
> the boilerplate "return NOTIFY_DONE", IMO.

I don't really think that making the callback non-void would be a problem.

> >> +       return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;
> >
> > And I would prefer
> >
> > if (data.stop_chain)
> >         return NOTIFY_STOP;
> >
> > return NOTIFY_DONE;
>
> Okay
>
> >> +}
> >> +
> >> +static int sys_off_handler_reboot(struct notifier_block *nb,
> >> +                                 unsigned long mode, void *cmd)
> >> +{
> >> +       struct sys_off_handler_private_data *priv;
> >> +       struct reboot_prep_data data = {};
> >> +       struct sys_off_handler *h;
> >> +
> >> +       priv = container_of(nb, struct sys_off_handler_private_data, reboot_nb);
> >> +       h = container_of(priv, struct sys_off_handler, priv);
> >> +
> >> +       data.cb_data = h->cb_data;
> >> +       data.stop_chain = false;
> >> +       data.mode = mode;
> >> +       data.cmd = cmd;
> >> +
> >> +       h->reboot_prepare_cb(&data);
> >> +
> >> +       return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;
> >
> > And analogously here.
> >
> >> +}
> >> +
> >> +static struct sys_off_handler_private_data *
> >> +sys_off_handler_private_data(struct sys_off_handler *handler)
> >> +{
> >> +       return (struct sys_off_handler_private_data *)&handler->priv;
> >
> > Is the cast needed to avoid a warning about "const"?
>
> The private data is constant to prevent the API users from using it. For
> internal use we need to cast out the "const". It's a compilation error
> to change the constant members.

Precisely.  And so it shouldn't be done in any way.

> >> +}
> >> +
> >> +/**
> >> + *     devm_register_sys_off_handler - Register system power-off/restart handler
> >
> > register_sys_off_handler
>
> Good catch!
>
> >> + *     @dev: Device that registers handler
> >> + *     @handler: System-off handler
> >> + *
> >> + *     Registers handler that will be called as last step of the power-off
> >> + *     and restart sequences.
> >
> > Not necessarily as the last step, because there may be other system
> > power-off/restart handlers called after it.
> >
> > I would just say "at the end of the power-off and restart sequences".
> >
> > Moreover, it registers the "reboot_cb" part that is not called "at the
> > end" even.
> >
> > Also, because this is the function that will be used by drivers etc to
> > register handlers, I would give some more information on how the
> > object registered by it is going to be used to the prospective users.
>
> I'll improve the description, thank you.
>
> >> + *
> >> + *     Returns zero on success, or error code on failure.
> >> + */
> >> +int register_sys_off_handler(struct sys_off_handler *handler)
> >> +{
> >> +       struct sys_off_handler_private_data *priv;
> >> +       int err, priority;
> >> +
> >> +       priv = sys_off_handler_private_data(handler);
> >> +
> >> +       /* sanity-check whether handler is registered twice */
> >> +       if (priv->registered)
> >> +               return -EBUSY;
> >> +
> >> +       if (handler->power_off_cb || handler->power_off_prepare_cb) {
> >> +               if (handler->power_off_priority == POWEROFF_PRIO_RESERVED)
> >> +                       priority = POWEROFF_PRIO_DEFAULT;
> >
> > I'm not sure that this helps.
> >
> > I mean, why can't the users of this new API pass POWEROFF_PRIO_DEFAULT
> > directly if they want "default"?
>
> Users could pass POWEROFF_PRIO_DEFAULT, but it's a boilerplate code
> which I wanted to avoid by reserving 0 for the alias to
> POWEROFF_PRIO_DEFAULT=128.
>
> This removes a need from drivers to explicitly specify the default
> priorities in the code, assuming that sys_off_handler is initialized to
> zero.

But the developers need to check whether or not they do the right
thing anyway and so they will need to look at the code here to see
whether or not it is OK to pass 0 and what happens then.  I'm not sure
if I prefer this to the explicit "default".

Or define POWEROFF_PRIO_DEFAULT as 0 and there will be nothing to worry about.

> >> +               else
> >> +                       priority = handler->power_off_priority;
> >> +
> >> +               priv->power_off_nb.notifier_call = sys_off_handler_power_off;
> >> +               priv->power_off_nb.priority = priority;
> >> +
> >> +               err = register_power_off_handler(&priv->power_off_nb);
> >> +               if (err)
> >> +                       goto reset_sys_off_handler;
> >> +       }
> >> +
> >> +       if (handler->restart_cb) {
> >> +               if (handler->restart_priority == RESTART_PRIO_RESERVED)
> >> +                       priority = RESTART_PRIO_DEFAULT;
> >> +               else
> >> +                       priority = handler->restart_priority;
> >> +
> >> +               priv->restart_nb.notifier_call = sys_off_handler_restart;
> >> +               priv->restart_nb.priority = priority;
> >> +
> >> +               err = register_restart_handler(&priv->restart_nb);
> >> +               if (err)
> >> +                       goto unreg_power_off_handler;
> >> +       }
> >> +
> >> +       if (handler->reboot_prepare_cb) {
> >> +               priv->reboot_nb.notifier_call = sys_off_handler_reboot;
> >> +               priv->reboot_nb.priority = handler->reboot_priority;
> >> +
> >> +               err = register_reboot_notifier(&priv->reboot_nb);
> >> +               if (err)
> >> +                       goto unreg_restart_handler;
> >> +       }
> >> +
> >> +       priv->registered = true;
> >> +
> >> +       return 0;
> >> +
> >> +unreg_restart_handler:
> >> +       if (handler->restart_cb)
> >> +               unregister_restart_handler(&priv->restart_nb);
> >> +
> >> +unreg_power_off_handler:
> >> +       if (handler->power_off_cb)
> >> +               unregister_power_off_handler(&priv->power_off_nb);
> >> +
> >> +reset_sys_off_handler:
> >> +       memset(priv, 0, sizeof(*priv));
> >> +
> >> +       return err;
> >> +}
> >> +EXPORT_SYMBOL(register_sys_off_handler);
> >> +
> >> +/**
> >> + *     unregister_sys_off_handler - Unregister system power-off/restart handler
> >> + *     @handler: System-off handler
> >> + *
> >> + *     Unregisters sys-off handler. Does nothing and returns zero if handler
> >> + *     is NULL.
> >> + *
> >> + *     Returns zero on success, or error code on failure.
> >> + */
> >> +int unregister_sys_off_handler(struct sys_off_handler *handler)
> >> +{
> >> +       struct sys_off_handler_private_data *priv;
> >> +
> >> +       if (!handler)
> >> +               return 0;
> >> +
> >> +       priv = sys_off_handler_private_data(handler);
> >> +
> >> +       /* sanity-check whether handler is unregistered twice */
> >> +       if (!priv->registered)
> >> +               return -EINVAL;
> >> +
> >> +       if (handler->reboot_prepare_cb)
> >> +               unregister_reboot_notifier(&priv->reboot_nb);
> >> +
> >> +       if (handler->restart_cb)
> >> +               unregister_restart_handler(&priv->restart_nb);
> >> +
> >> +       if (handler->power_off_cb)
> >> +               unregister_power_off_handler(&priv->power_off_nb);
> >> +
> >> +       memset(priv, 0, sizeof(*priv));
> >> +
> >> +       return 0;
> >> +}
> >> +EXPORT_SYMBOL(unregister_sys_off_handler);
> >> +
> >> +static void devm_unregister_sys_off_handler(void *data)
> >> +{
> >> +       struct sys_off_handler *handler = data;
> >> +
> >> +       unregister_sys_off_handler(handler);
> >> +}
> >> +
> >> +/**
> >> + *     devm_register_sys_off_handler - Register system power-off/restart handler
> >> + *     @dev: Device that registers handler
> >> + *     @handler: System-off handler
> >> + *
> >> + *     Resource-managed variant of register_sys_off_handler().
> >> + *
> >> + *     Returns zero on success, or error code on failure.
> >> + */
> >> +int devm_register_sys_off_handler(struct device *dev,
> >> +                                 struct sys_off_handler *handler)
> >> +{
> >> +       int err;
> >> +
> >> +       err = register_sys_off_handler(handler);
> >> +       if (err)
> >> +               return err;
> >> +
> >> +       return devm_add_action_or_reset(dev, devm_unregister_sys_off_handler,
> >> +                                       handler);
> >> +}
> >> +EXPORT_SYMBOL(devm_register_sys_off_handler);
> >> +
> >> +/**
> >> + *     devm_register_prioritized_power_off_handler - Register prioritized power-off callback
> >> + *     @dev: Device that registers callback
> >> + *     @priority: Callback's priority
> >> + *     @callback: Callback function
> >> + *     @cb_data: Callback's argument
> >> + *
> >> + *     Registers resource-managed power-off callback with a given priority.
> >> + *     It will be called as last step of the power-off sequence. Callbacks
> >> + *     chaining is disabled, i.e. further lower priority callbacks won't
> >> + *     be executed if this @callback will fail to execute.
> >> + *
> >> + *     Returns zero on success, or error code on failure.
> >
> > What's the case in which this should be used instead of registering a
> > full sys_off handler?
>
> There are a lot of drivers that just want to register power-off handler
> with a non-default priority and don't need to stop the chain or do
> anything else special. This is a convinient helper for them.
>
> Please note that the callback here takes only the cb_data for the
> argument, while sys_off uses "struct power_off_data".
>
> Similar for the reset of the convinient helpers.

So if there is a way to do this, why would anyone prefer to use the
full sys_off handler at all?

> ...
> >> +/**
> >> + *     register_platform_power_off - Register platform-level power-off callback
> >> + *     @power_off: Power-off callback
> >> + *
> >> + *     Registers power-off callback that will be called as last step
> >> + *     of the power-off sequence. This callback is expected to be invoked
> >> + *     for the last resort. Further lower priority callbacks won't be
> >> + *     executed if @power_off fails. Only one platform power-off callback
> >> + *     is allowed to be registered at a time.
> >> + *
> >> + *     Returns zero on success, or error code on failure.
> >
> > What's the use case for this?
>
> There are dozens of trivial platform/board-specific power-off handlers
> in the arch/ code. Those handlers don't take any arguments, hence it's a
> convinient helper that transits them to the new API neatly.
>
> >> + */
> >> +int register_platform_power_off(void (*power_off)(void))
> >> +{
> >> +       struct sys_off_handler_private_data *priv;
> >> +       int ret = 0;
> >> +
> >> +       priv = sys_off_handler_private_data(&platform_power_off_handler);
> >> +
> >> +       spin_lock(&platform_power_off_lock);
> >> +       if (priv->platform_power_off_cb)
> >> +               ret = -EBUSY;
> >> +       else
> >> +               priv->platform_power_off_cb = power_off;
> >
> > Wasn't priv supposed to be const?
>
> It's const only for the external API users to prevent them from abusing
> the internal data.

So if this is not clear yet, I'm not going to let this go.

> >> +       spin_unlock(&platform_power_off_lock);
> >> +
> >> +       if (ret)
> >> +               return ret;
> >> +
> >> +       ret = register_power_off_handler(&priv->power_off_nb);
> >> +       if (ret)
> >> +               priv->platform_power_off_cb = NULL;
> >> +
> >> +       return ret;
> >> +}
> >> +EXPORT_SYMBOL_GPL(register_platform_power_off);
> >> +
> >> +/**
> >> + *     unregister_platform_power_off - Unregister platform-level power-off callback
> >> + *     @power_off: Power-off callback
> >> + *
> >> + *     Unregisters previously registered platform power-off callback.
> >> + *
> >> + *     Returns zero on success, or error code on failure.
> >> + */
> >> +int unregister_platform_power_off(void (*power_off)(void))
> >> +{
> >> +       struct sys_off_handler_private_data *priv;
> >> +       int ret;
> >> +
> >> +       priv = sys_off_handler_private_data(&platform_power_off_handler);
> >> +
> >> +       if (priv->platform_power_off_cb != power_off)
> >> +               return -EINVAL;
> >> +
> >> +       ret = unregister_power_off_handler(&priv->power_off_nb);
> >> +       priv->platform_power_off_cb = NULL;
> >> +
> >> +       return ret;
> >> +}
> >> +EXPORT_SYMBOL_GPL(unregister_platform_power_off);
> >> +
> >> +/**
> >> + *     do_kernel_power_off - Execute kernel power-off handler call chain
> >> + *
> >> + *     Calls functions registered with register_power_off_handler.
> >> + *
> >> + *     Expected to be called as last step of the power-off sequence.
> >> + *
> >> + *     Powers off the system immediately if a power-off handler function has
> >> + *     been registered. Otherwise does nothing.
> >> + */
> >> +void do_kernel_power_off(void)
> >> +{
> >> +       /* legacy pm_power_off() is unchained and has highest priority */
> >> +       if (pm_power_off && pm_power_off != dummy_pm_power_off)
> >> +               return pm_power_off();
> >> +
> >> +       blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_NORMAL,
> >> +                                    NULL);
> >> +}
> >> +
> >> +static void do_kernel_power_off_prepare(void)
> >> +{
> >> +       /* legacy pm_power_off_prepare() is unchained and has highest priority */
> >> +       if (pm_power_off_prepare)
> >> +               return pm_power_off_prepare();
> >> +
> >> +       blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE,
> >> +                                    NULL);
> >> +}
> >> +
> >>  /**
> >>   *     kernel_power_off - power_off the system
> >>   *
> >> @@ -304,8 +893,7 @@ EXPORT_SYMBOL_GPL(kernel_halt);
> >>  void kernel_power_off(void)
> >>  {
> >>         kernel_shutdown_prepare(SYSTEM_POWER_OFF);
> >> -       if (pm_power_off_prepare)
> >> -               pm_power_off_prepare();
> >> +       do_kernel_power_off_prepare();
> >>         migrate_to_reboot_cpu();
> >>         syscore_shutdown();
> >>         pr_emerg("Power down\n");
> >> @@ -314,6 +902,16 @@ void kernel_power_off(void)
> >>  }
> >>  EXPORT_SYMBOL_GPL(kernel_power_off);
> >>
> >> +bool kernel_can_power_off(void)
> >> +{
> >> +       if (!pm_power_off &&
> >> +           blocking_notifier_call_chain_is_empty(&power_off_handler_list))
> >> +               return false;
> >> +
> >> +       return true;
> >
> > return pm_power_off ||
> > blocking_notifier_call_chain_is_empty(&power_off_handler_list);
>
> Thank you for the thorough review!

You're very welcome!


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 19:19:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 19:19:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309576.525925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhFrY-0004Xm-Jq; Wed, 20 Apr 2022 19:19:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309576.525925; Wed, 20 Apr 2022 19:19:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhFrY-0004Xf-FZ; Wed, 20 Apr 2022 19:19:40 +0000
Received: by outflank-mailman (input) for mailman id 309576;
 Wed, 20 Apr 2022 19:19:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhFrW-0004XV-V8; Wed, 20 Apr 2022 19:19:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhFrW-00071s-Qw; Wed, 20 Apr 2022 19:19:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhFrW-0006UQ-CB; Wed, 20 Apr 2022 19:19:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhFrW-0007i3-Bl; Wed, 20 Apr 2022 19:19:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Cz4C8IRikcs5nv0dr/f/ad3nxHvlaWxbtYImggl5Lck=; b=Zxo2L73DC5qPjmsmo6pnrCR9/5
	5KL6GF+t+PciKZht+cUW2p1+Pf9GvXrQNKkraTkq9heGX4pBnr0LN73rHhgNL+k86pNKWkQXcEtoo
	f3yLuOwu5OiNKF6xTyAYiaFuDx01rxn4adjzjU60ZBmk/dqpnXK5lQEEuxO+SZl7Rzz0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169569-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169569: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=532bd4ec384b8e5764d97a62e5bd01fdbae6bd7a
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 19:19:38 +0000

flight 169569 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169569/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 532bd4ec384b8e5764d97a62e5bd01fdbae6bd7a
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  522 attempts
Testing same since   169568  2022-04-20 11:10:26 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5504 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 19:25:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 19:25:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309584.525935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhFwj-00069C-7r; Wed, 20 Apr 2022 19:25:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309584.525935; Wed, 20 Apr 2022 19:25:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhFwj-000695-55; Wed, 20 Apr 2022 19:25:01 +0000
Received: by outflank-mailman (input) for mailman id 309584;
 Wed, 20 Apr 2022 19:25:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CUyO=U6=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhFwi-00068z-9C
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 19:25:00 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8fd88f6f-c0df-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 21:24:58 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650482690355130.23016543154029;
 Wed, 20 Apr 2022 12:24:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8fd88f6f-c0df-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1650482695; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=d5kjXM+mKe8SzoC8+M0Pbv6kd4pJLHxSA2vkvklr7zTL3N/ypEPQ5ga8S2B+uJgQU1jwPISwgNAjJnU2nC7nv82nIoaEydHyGkM094cnCjlHmxaSZJqtS2B/BEcRBDgM4G8D3BEPkV+IoT+Pyo0Vfp8pmRaLzc22P9r/Ud8xDTo=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650482695; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=qm5h+xagSlEf0EKTM4q1nqnzY1FHMzwJBGqOx/exje8=; 
	b=iyEUDWm3hLfMZ27whdaUqfnXZ5JL0ufBIEkYqCdxTNps1VwA402Z2GUJ2KNP+i+Lt2KVf3Um+Keg5w7s+6PD4r4iBC3oW5NXeGwcFnBYu/UXMKesAYW3KEIaMTzrsIUxYJ6efUFPeLM+3da5CNXR+LMhfVnoL7F83v8YGSzNB+c=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650482695;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=qm5h+xagSlEf0EKTM4q1nqnzY1FHMzwJBGqOx/exje8=;
	b=O0qEqlpTYHwQRR1w8vLflv6vK4Ld8IujZijT0z71azJGIaMHfum1sDsWpifFKz5s
	q4gNDOB22aUAriUVMuk5ob2s4GjVbiTCeHchWMAXSD82tB2uQldbow1aqBTOzjH5ofP
	DECQ7j0dI2OQ88ULmO2Ah0mEeIQua3JuOmXsjwWA=
Message-ID: <2531185f-591a-a9a0-9f0d-2f358ce3afe3@apertussolutions.com>
Date: Wed, 20 Apr 2022 15:24:07 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] xsm: create idle domain privieged and demote after
 setup
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 Scott Davis <scott.davis@starlab.io>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Jan Beulich
 <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220420210407.18060-1-dpsmith@apertussolutions.com>
 <20220420210407.18060-2-dpsmith@apertussolutions.com>
 <CAKf6xpsr_0m=tWMjVQsufxSJ52kz3QFzMJvVa0MEKLrtrVM9TQ@mail.gmail.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
In-Reply-To: <CAKf6xpsr_0m=tWMjVQsufxSJ52kz3QFzMJvVa0MEKLrtrVM9TQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/20/22 14:31, Jason Andryuk wrote:
> On Wed, Apr 20, 2022 at 1:02 PM Daniel P. Smith
> <dpsmith@apertussolutions.com> wrote:
>>
>> There are now instances where internal hypervisor logic needs to make resource
>> allocation calls that are protectd by XSM checks. The internal hypervisor logic
>> is represented a number of system domains which by designed are represented by
>> non-privileged struct domain instances. To enable these logic blocks to
>> function correctly but in a controlled manner, this commit changes the idle
>> domain to be created as a privileged domain under the default policy, which is
>> inherited by the SILO policy, and demoted before transitioning to running. A
>> new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
>> type to demote the idle domain appropriately for that policy type.
>>
>> For flask a stub is added to ensure that flask policy system will function
>> correctly with this patch until flask is extended with support for starting the
>> idle domain privileged and properly demoting it on the call to
>> xsm_transtion_running.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
> 
>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
>> index 6f20e17892..72695dcb07 100644
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -621,6 +621,12 @@ static void noreturn init_done(void)
>>      void *va;
>>      unsigned long start, end;
>>
>> +    xsm_transition_running();
>> +
>> +    /* Ensure idle domain was not left privileged */
>> +    if ( current->domain->is_privileged )
>> +        panic("idle domain did not properly transition from setup privilege\n");
> 
> Checking immediately after the XSM hook seems redundant, though I
> guess having a sanity check isn't harmful.

I was back and forth on this, so I threw it in and figured if there was
strong opinions against it I could easily remove and respin the series.

>>  static void cf_check flask_domain_free_security(struct domain *d)
>>  {
>>      struct domain_security_struct *dsec = d->ssid;
>> @@ -1766,6 +1780,7 @@ static int cf_check flask_argo_send(
>>  #endif
>>
>>  static const struct xsm_ops __initconst_cf_clobber flask_ops = {
>> +    .transition_running = flask_domain_runtime_security,
> 
> I'd prefer flask_transition_running.  That way grep for the hook name
> also finds the flask implementation.

Sure.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 19:52:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 19:52:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309590.525946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhGMu-0001Vq-D8; Wed, 20 Apr 2022 19:52:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309590.525946; Wed, 20 Apr 2022 19:52:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhGMu-0001Vj-AF; Wed, 20 Apr 2022 19:52:04 +0000
Received: by outflank-mailman (input) for mailman id 309590;
 Wed, 20 Apr 2022 19:52:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CUyO=U6=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhGMs-0001Vd-SU
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 19:52:02 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 52d90a90-c0e3-11ec-a405-831a346695d4;
 Wed, 20 Apr 2022 21:51:54 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650484306172272.49530555779097;
 Wed, 20 Apr 2022 12:51:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52d90a90-c0e3-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1650484309; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=iem/k3jWNpm7hSecSJuydASpv/zLQ1Wy8Ztn7L+oh+I5HcpRLDaWr+IMKlXFk4S3ZWVeegV094hDpcn/0YHHIxwEfrdpPonFdm1GosCGNlRVC/sH9P9HFmlZnTyl/NCsx1+cQ0UOV5QIl9fva8KqkhsEKCSCgAxhp4cuUy5bw4M=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650484309; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=nLGKb2nHoVHpxHpT6pxINKx03WgbTw/0e+pGu/rhNj4=; 
	b=l5nB+38Ijziq98xzw2IDx0zD24C72iZrDh0tF+q7syFilpo1QV9Vgz7wgFJgqQBXdTyOC556gzl6f843GMXrhtzNgQOCsZOtiHef80RM4I/DaBTBL4lJ9WT3WNtZ7KB4i0dDbdW6iKPxmaSMhTDDMVGcP7X/3/QfrIdPxts2akw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650484309;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=nLGKb2nHoVHpxHpT6pxINKx03WgbTw/0e+pGu/rhNj4=;
	b=Ok+cJnGaV4OFMetIA+o+BJ5pqYwdaQ3X8saYcm55FUdSAMSxLivU/EUBGXSyE3D2
	vpQtwvh0D7xAzw618KpVQoylSuyaDmkAJmXLgGPTBr7buIUh3/vo4bZRceHEgOshpNE
	4VGgK17Z5/Z0/MKUtSpxVNuq6hd4gFOaWcTMcPag=
Message-ID: <24dfdca7-a767-d115-133d-f79138bb41b6@apertussolutions.com>
Date: Wed, 20 Apr 2022 15:51:03 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Scott Davis <scott.davis@starlab.io>, Daniel De Graaf
 <dgdegra@tycho.nsa.gov>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20220420210407.18060-1-dpsmith@apertussolutions.com>
 <20220420210407.18060-3-dpsmith@apertussolutions.com>
 <CAKf6xptTqsL9wcP2n=-NBd9UtrCh=+XxzJgK3tGYpqUXQEDUAA@mail.gmail.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 2/2] flask: implement xsm_transtion_running
In-Reply-To: <CAKf6xptTqsL9wcP2n=-NBd9UtrCh=+XxzJgK3tGYpqUXQEDUAA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/20/22 14:07, Jason Andryuk wrote:
> On Wed, Apr 20, 2022 at 1:03 PM Daniel P. Smith
> <dpsmith@apertussolutions.com> wrote:
>>
>> This commit implements full support for starting the idle domain privileged by
>> introducing a new flask label xenboot_t which the idle domain is labeled with
>> at creation.  It then provides the implementation for the XSM hook
>> xsm_transition_running to relabel the idle domain to the existing xen_t flask
>> label.
>>
>> In the reference flask policy a new macro, xen_build_domain(target), is
>> introduced for creating policies for dom0less/hyperlaunch allowing the
>> hypervisor to create and assign the necessary resources for domain
>> construction.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
> 
>> @@ -188,6 +188,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>>
>>  static void cf_check flask_domain_runtime_security(void)
>>  {
>> +    struct domain_security_struct *dsec;
>>      struct domain *d = current->domain;
>>
>>      if ( d->domain_id != DOMID_IDLE )
>> @@ -198,6 +199,9 @@ static void cf_check flask_domain_runtime_security(void)
>>       * set to false for the consistency check(s) in the setup code.
>>       */
>>      d->is_privileged = false;
>> +
>> +    dsec = d->ssid;
>> +    dsec->sid = SECINITSID_XEN;
> 
> I think you also want
>    dsec->self_sid = dsec->sid;
> so self also changes to xen_t.

Erg, thanks for the catch.

> Otherwise I think it looks good,
> 
> I was wondering if you were going to require xenboot_t -> xen_t
> permissions, but manually setting the sid fields side-steps that.
> That seems nicer than requiring policy rules for the transition.

I was considering it but as I was reflecting on the discussions that
were had, this is a one-time, one-way transition. Combine that with the
fact that xenboot_t has to be an initial sid (fixed/permnant type) for
Xen's flask policy, there is no need to require a transition rule in the
policy that can never be changed. And yes, it helps makes things much
simpler.( ^_^)

> Hmmm, cross referencing other flask code, often after assigning
> self_sid there is this call to potentially re-calculate it:
>     security_transition_sid(dsec->sid, dsec->sid, SECCLASS_DOMAIN,
> &dsec->self_sid);
> 
> But it isn't used for system domains, so omitting it seems fine.

Hmm, now you have me concerned about decisions residing in the avc from
accesses made during domain creation. Let me double check that, but I
think it will be needed. I believe the reason it was not needed for the
system domains because prior to this no access decisions were made
before the domains were labeled.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 20:12:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 20:12:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309595.525957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhGgj-0004LQ-4d; Wed, 20 Apr 2022 20:12:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309595.525957; Wed, 20 Apr 2022 20:12:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhGgj-0004LJ-1R; Wed, 20 Apr 2022 20:12:33 +0000
Received: by outflank-mailman (input) for mailman id 309595;
 Wed, 20 Apr 2022 20:12:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhGgh-0004L9-OA; Wed, 20 Apr 2022 20:12:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhGgh-0007yG-ME; Wed, 20 Apr 2022 20:12:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhGgh-00083m-CJ; Wed, 20 Apr 2022 20:12:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhGgh-0000PC-Bg; Wed, 20 Apr 2022 20:12:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=18NpIIln9fhtbYCVabeac394wXzPaSJvD7m+3MqrZSQ=; b=MXlsXVd2lH5pwgrN+2jrjUlP02
	9OFdJsRPV6c7rpvaCgnoUsCt1J/QgHyJiIykGvcgAh9Okp+ucS4oRrAC+C8rBeR+Cl9tvqy3Ld4KE
	0gCa6JVwkrcaGNLg8NCVJv/TnIR0ErnKf2W543H7601VuNcdPefHUGLyHSTMQALP8h78=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169562-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169562: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=1be5a765c08cee3a9587c8a8d3fc2ea247b13f9c
X-Osstest-Versions-That:
    qemuu=823a3f11fb8f04c3c3cc0f95f968fef1bfc6534f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 20:12:31 +0000

flight 169562 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169562/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169547
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169547
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169547
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169547
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 169547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169547
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                1be5a765c08cee3a9587c8a8d3fc2ea247b13f9c
baseline version:
 qemuu                823a3f11fb8f04c3c3cc0f95f968fef1bfc6534f

Last test of basis   169547  2022-04-19 18:07:08 Z    1 days
Testing same since   169562  2022-04-20 07:22:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dov Murik <dovmurik@linux.ibm.com>
  Halil Pasic <pasic@linux.ibm.com>
  Ivan Shcherbakov <ivan@sysprogs.com>
  Jon Doron <arilou@gmail.com>
  Longpeng(Mike) <longpeng2@huawei.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   823a3f11fb..1be5a765c0  1be5a765c08cee3a9587c8a8d3fc2ea247b13f9c -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 20:48:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 20:48:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309605.525969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhHEx-0008Hn-2o; Wed, 20 Apr 2022 20:47:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309605.525969; Wed, 20 Apr 2022 20:47:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhHEw-0008Hg-W8; Wed, 20 Apr 2022 20:47:54 +0000
Received: by outflank-mailman (input) for mailman id 309605;
 Wed, 20 Apr 2022 20:47:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhHEw-0008HW-3A; Wed, 20 Apr 2022 20:47:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhHEw-00009X-0j; Wed, 20 Apr 2022 20:47:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhHEv-0000ab-Ii; Wed, 20 Apr 2022 20:47:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhHEv-0004ym-IF; Wed, 20 Apr 2022 20:47:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3c7iQ9eRooQOKaEI++8nKP4kq52URvao5naFERtYA80=; b=HtDuoZk4O7XryZW/L0huJyJnBy
	9GcNpxoO7u8U2+rQO6sxpZyLkej4pcD+Gb/RbwdPe7FQxRW8aYvyU0u/qQe6jWO0ce1dbRm+5Katu
	qgdcMysBNd75X5bpwAkMcRx80X5bjidalVdQF/As4E6cQOBpCdtYEiz/3SOpswkaDm2c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169571-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169571: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=6d2baf9dfbffe43019932c2771cd7d39697d4b11
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 20:47:53 +0000

flight 169571 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169571/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 6d2baf9dfbffe43019932c2771cd7d39697d4b11
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  523 attempts
Testing same since   169571  2022-04-20 19:40:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5520 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 21:08:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 21:08:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309613.525980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhHYY-0002dB-QI; Wed, 20 Apr 2022 21:08:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309613.525980; Wed, 20 Apr 2022 21:08:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhHYY-0002d4-N9; Wed, 20 Apr 2022 21:08:10 +0000
Received: by outflank-mailman (input) for mailman id 309613;
 Wed, 20 Apr 2022 21:08:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhHYX-0002cy-Ju
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 21:08:09 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f9ffd04e-c0ed-11ec-8fbf-03012f2f19d4;
 Wed, 20 Apr 2022 23:08:07 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 374B0B81F90;
 Wed, 20 Apr 2022 21:08:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81C08C385A1;
 Wed, 20 Apr 2022 21:08:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9ffd04e-c0ed-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650488885;
	bh=T8FKDQt3bZsBb8hU4ZLoS/4/8NT9b2cS2wm/0Bs1j+M=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Kp2YGvH+3VAOmrfNzD8QpIePG7wvghskoMvnRGSrtctcrwtg4+FJqY2GcFcTZpQ+f
	 F6Mu2nE2/ILMWaGzjBASz9GNEzynddJgoudO7moRSXd9U5gNAybUWgKZhA2+OstjB0
	 6HUmOkiECKdkTGzDA1NvIDcjFdacxEhF/EwsnsN9BHwemBZhYSIfShxtO/VNieOJIu
	 lfJV24B4w8QHYvkU5PJiNq0Qqba5d7q6IoDWBsRrDWLrNRTHuOLimferlcBxF0GHUM
	 oTLcfTsrbk3nTvQmQnhOXE8lwIOUbo2poZdB8pFoTZRRgRI17xTNhq1akablbs0DDQ
	 j3hZ2GsZLN9EA==
Date: Wed, 20 Apr 2022 14:08:04 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <Wei.Chen@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "julien@xen.org" <julien@xen.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Penny Zheng <Penny.Zheng@arm.com>
Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftB
In-Reply-To: <PAXPR08MB742058D3041BA2D97AA05F1D9EF59@PAXPR08MB7420.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2204201403180.915916@ubuntu-linux-20-04-desktop>
References: <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com> <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop> <PAXPR08MB7420786607A15FA5027BF4579EF29@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204191752390.915916@ubuntu-linux-20-04-desktop> <PAXPR08MB742058D3041BA2D97AA05F1D9EF59@PAXPR08MB7420.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 20 Apr 2022, Wei Chen wrote:
> > On Tue, 19 Apr 2022, Wei Chen wrote:
> > > > > ### 3.2. Xen Event Channel Support
> > > > >     In Current RFC patches we haven't enabled the event channel
> > support.
> > > > >     But I think it's good opportunity to do some discussion in
> > advanced.
> > > > >     On Armv8-R, all VMs are native direct-map, because there is no
> > > > stage2
> > > > >     MMU translation. Current event channel implementation depends on
> > > > some
> > > > >     shared pages between Xen and guest: `shared_info` and per-cpu
> > > > `vcpu_info`.
> > > > >
> > > > >     For `shared_info`, in current implementation, Xen will allocate
> > a
> > > > page
> > > > >     from heap for `shared_info` to store initial meta data. When
> > guest
> > > > is
> > > > >     trying to setup `shared_info`, it will allocate a free gfn and
> > use a
> > > > >     hypercall to setup P2M mapping between gfn and `shared_info`.
> > > > >
> > > > >     For direct-mapping VM, this will break the direct-mapping
> > concept.
> > > > >     And on an MPU based system, like Armv8-R system, this operation
> > will
> > > > >     be very unfriendly. Xen need to pop `shared_info` page from Xen
> > heap
> > > > >     and insert it to VM P2M pages. If this page is in the middle of
> > > > >     Xen heap, this means Xen need to split current heap and use
> > extra
> > > > >     MPU regions. Also for the P2M part, this page is unlikely to
> > form
> > > > >     a new continuous memory region with the existing p2m pages, and
> > Xen
> > > > >     is likely to need another additional MPU region to set it up,
> > which
> > > > >     is obviously a waste for limited MPU regions. And This kind of
> > > > dynamic
> > > > >     is quite hard to imagine on an MPU system.
> > > >
> > > > Yeah, it doesn't make any sense for MPU systems
> > > >
> > > >
> > > > >     For `vcpu_info`, in current implementation, Xen will store
> > > > `vcpu_info`
> > > > >     meta data for all vCPUs in `shared_info`. When guest is trying
> > to
> > > > setup
> > > > >     `vcpu_info`, it will allocate memory for `vcpu_info` from guest
> > side.
> > > > >     And then guest will use hypercall to copy meta data from
> > > > `shared_info`
> > > > >     to guest page. After that both Xen `vcpu_info` and guest
> > `vcpu_info`
> > > > >     are pointed to the same page that allocated by guest.
> > > > >
> > > > >     This implementation has serval benifits:
> > > > >     1. There is no waste memory. No extra memory will be allocated
> > from
> > > > Xen heap.
> > > > >     2. There is no P2M remap. This will not break the direct-mapping,
> > > > and
> > > > >        is MPU system friendly.
> > > > >     So, on Armv8-R system, we can still keep current implementation
> > for
> > > > >     per-cpu `vcpu_info`.
> > > > >
> > > > >     So, our proposal is that, can we reuse current implementation
> > idea
> > > > of
> > > > >     `vcpu_info` for `shared_info`? We still allocate one page for
> > > > >     `d->shared_info` at domain construction for holding some initial
> > > > meta-data,
> > > > >     using alloc_domheap_pages instead of alloc_xenheap_pages and
> > > > >     share_xen_page_with_guest. And when guest allocates a page for
> > > > >     `shared_info` and use hypercall to setup it,  We copy the
> > initial
> > > > data from
> > > > >     `d->shared_info` to it. And after copy we can update `d-
> > > > >shared_info` to point
> > > > >     to guest allocated 'shared_info' page. In this case, we don't
> > have
> > > > to think
> > > > >     about the fragmentation of Xen heap and p2m and the extra MPU
> > > > regions.
> > > >
> > > > Yes, I think that would work.
> > > >
> > > > Also I think it should be possible to get rid of the initial
> > > > d->shared_info allocation in Xen, given that d->shared_info is for the
> > > > benefit of the guest and the guest cannot access it until it makes the
> > > > XENMAPSPACE_shared_info hypercall.
> > > >
> > >
> > > While we're working on event channel PoC work on Xen Armv8-R, we found
> > > another issue after we dropped d->shared_info allocation in Xen. Both
> > > shared_info and vcpu_info are allocated from Guest in runtime. That
> > > means the addresses of shared_info and vcpu_info are random. For MMU
> > > system, this is OK, because Xen has a full view of system memory in
> > > runtime. But for MPU system, the situation becomes a little tricky.
> > > We have to setup extra MPU regions for remote domains' shared_info
> > > and vcpu_info in event channel hypercall runtime. That's because
> > > in current Xen hypercall concept, hypercall will not cause vCPU
> > > context switch. When hypercall trap to EL2, it will keep vCPU's
> > > P2M view. For MMU system, we have vttbr_el2 for vCPU P2M view and
> > > ttbr_el2 for Xen view. So in EL2 Xen has full permissions to access
> > > any memory it wants. But for MPU system, we only have one EL2 MPU.
> > > Before entering guest, Xen will setup vCPU P2M view in EL2 MPU.
> > > In this case, when system entry EL2 through hypercall, the EL2
> > > MPU still keeps current vCPU P2M view and with Xen essential
> > > memory (code, data, heap) access permissions. But current EL2 MPU
> > > doesn't have the access permissions for EL2 to access other
> > > domain's memory. For an event channel hypercall, if we want to
> > > update the pending bitmap in remote domain's vcpu_info, it will
> > > cause a dataabort in EL2. To solve this dataabort, we may have
> > > two methods:
> > > 1. Map remote domain's whole memory or pages for shared_info +
> > >    vcpu_info in EL2 MPU temporarily for hypercall to update
> > >    pending bits or other accesses.
> > >
> > >    This method doesn't need to do context switch for EL2 MPU,
> > >    But this method has some disadvantages:
> > >    1. We have to reserve MPU regions for hypercall.
> > >    2. Different hypercall may have different reservation of
> > >       MPU regions.
> > >    3. We have to handle hypercall one by one for existed and
> > >       new in future.
> > >
> > > 2. Switch to Xen's memory view in EL2 MPU when trap from EL1 to
> > >    EL2. In this case, Xen will have full memory access permissions
> > >    to update pending bits in EL2. This only changes the EL2 MPU
> > >    context, does not need to do vCPU context switch. Because the
> > >    trapped vCPU will be used in the full flow of hypercall. After
> > >    the hypercall, before returning to EL2, the EL2 MPU will switch
> > >    to scheduled vCPU' P2M view.
> > >    This method needs to do EL2 MPU context switch, but:
> > >    1. We don't need to reserve MPU regions for Xen's memory view.
> > >       (Xen's memory view has been setup while initialization)
> > >    2. We don't need to handle pages' mapping in hypercall level.
> > >    3. Apply to other EL1 to EL2 traps, like dataabort, IRQ, etc.
> > 
> > 
> > Both approach 1) and 2) are acceptable and in fact I think we'll
> > probably have to do a combination of both.
> > 
> > We don't need to do a full MPU context switch every time we enter Xen.
> > We can be flexible. Only when Xen needs to access another guest memory,
> > if the memory is not mappable using approach 1), Xen could do a full MPU
> > context switch. Basically, try 1) first, if it is not possible, do 2).
> > 
> > This also solves the problem of "other hypercalls". We can always do 2)
> > if we cannot do 1).
> > 
> > So do we need to do 1) at all? It really depends on performance data.
> > Not all hypercalls are made equal. Some are very rare and it is fine if
> > they are slow. Some hypercalls are actually on the hot path. The event
> > channels hypercalls are on the hot path so they need to be fast. It
> > makes sense to implement 1) just for event channels hypercalls if the
> > MPU context switch is slow.
> > 
> > Data would help a lot here to make a good decision. Specifically, how
> > much more expensive is an EL2 MPU context switch compared to add/remove
> > of an MPU region in nanosec or cpu cycles?
> > 
> 
> We will do it when we get a proper platform.
> 
> > 
> > The other aspect is how many extra MPU regions do we need for each guest
> > to implement 1). Do we need one extra MPU region for each domU? If so, I
> > don't think approach 1) if feasible unless we come up with a smart
> > memory allocation scheme for shared_info and vcpu_info. For instance, if
> > shared_info and vcpu_info of all guests were part of the Xen data or
> > heap region, or 1 other special MPU region, then they could become
> > immediately accessible without need for extra mappings when switching to
> > EL2.
> > 
> 
> Allocate shared_info and vcpu_info from Xen data or heap will cause memory
> fragmentation. We have to split the Xen data or heap and populate the pages
> for shared_info and vcpu_info, And insert them to Guest P2M. Because Armv8-R
> MPU doesn't allow memory overlap, this will cause at least 2 extra MPU
> regions usage. One page could not exist in Xen MPU region and Guest P2M
> MPU region at the same time. And we definitely don't want to make the entire
> Xen data and heap accessible to EL1. And this approach does not solve the
> 100% direct mapping problem. A special MPU region might have the same issues.
> Except we make this special MPU region can be accessed in EL1 and EL2 at
> runtime (it's unsafe), and update hypercall to use pages from this special
> region for shared_info and vcpu_info (every guest can see this region, so
> it's still 1:1 mapping).
> 
> For 1), the concern is caused by our current rough PoC, we used extra MPU
> regions to map the whole memory of remote domain, whose may have serval
> memory blocks in the worst case. We have thought it further, we can reduce
> the map granularity to page. For example, Xen wants to update shared_info
> or vcpu_info, Xen must know the address of it. So we can just map this
> one page temporarily. So I think only reserve 1 MPU region for runtime
> mapping is feasible on most platforms.

Actually I think that it would be great if we can do that. It looks like
the best way forward.


> But the additional problem with this is that if the hypercall are
> modifying multiple variables, Xen may need to do multiple mappings if
> they are not on the same page (or a proper MPU region range).

There are not that many hypercalls that require Xen to map multiple
pages, and those might be OK if they are slow.


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 21:19:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 21:19:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309618.525991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhHjN-0004Jw-RA; Wed, 20 Apr 2022 21:19:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309618.525991; Wed, 20 Apr 2022 21:19:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhHjN-0004Jp-OB; Wed, 20 Apr 2022 21:19:21 +0000
Received: by outflank-mailman (input) for mailman id 309618;
 Wed, 20 Apr 2022 21:19:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhHjM-0004Jf-6j; Wed, 20 Apr 2022 21:19:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhHjM-0000ik-3a; Wed, 20 Apr 2022 21:19:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhHjL-0003HV-Jr; Wed, 20 Apr 2022 21:19:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhHjL-00036J-JP; Wed, 20 Apr 2022 21:19:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bB5qFVxZjbs6zF+UUkK7ZgFvXs4SwQaTx9SWHoYr7BM=; b=PRGJzpobIqQ+xDeF0EoUPScQwJ
	UxjE4vIxahjlJgW15QeK3VyK0O33vcxbyL1fFlqv/yy2k6Xq5L224GiEsNLZ8IQ2mhQnav7LGTRnd
	EOomBBAm/2y9CrE94jKb8jvWKf0PApi2GR61GnxabkZAVt2dBIhGXCPBoiHxe7WnwwZc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169563-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 169563: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=dc213ac85601199834e7f2d222a5e63d7076d971
X-Osstest-Versions-That:
    linux=e7f5213d755bc34f366d36f08825c0b446117d96
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 21:19:19 +0000

flight 169563 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169563/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169426
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169426
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169426
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169426
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169426
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169426
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169426
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169426
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169426
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169426
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169426
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169426
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                dc213ac85601199834e7f2d222a5e63d7076d971
baseline version:
 linux                e7f5213d755bc34f366d36f08825c0b446117d96

Last test of basis   169426  2022-04-15 12:43:23 Z    5 days
Testing same since   169563  2022-04-20 07:42:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Deucher <alexander.deucher@amd.com>
  Alex Hung <alex.hung@amd.com>
  Alexey Galakhov <agalakhov@gmail.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Athira Rajeev <atrajeev@linux.vnet.ibm.com>
  Aurabindo Pillai <aurabindo.pillai@amd.com>
  Bagas Sanjaya <bagasdotme@gmail.com>
  Benedikt Spranger <b.spranger@linutronix.de>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  Chandrakanth patil <chandrakanth.patil@broadcom.com>
  Chao Gao <chao.gao@intel.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Christian Lamparter <chunkeey@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Hildenbrand <david@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Duoming Zhou <duoming@zju.edu.cn>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Guillaume Nault <gnault@redhat.com>
  Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
  Ido Schimmel <idosch@nvidia.com>
  Jakub Kicinski <kuba@kernel.org>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Joey Gouly <joey.gouly@arm.com>
  Johannes Berg <johannes.berg@intel.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Bakker <xc-racer2@live.ca>
  Juergen Gross <jgross@suse.com>
  Kalle Valo <kvalo@kernel.org>
  Karsten Graul <kgraul@linux.ibm.com>
  Kees Cook <keescook@chromium.org>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Leo (Hanghong) Ma <hanghong.ma@amd.com>
  Leo Ruan <tingquan.ruan@cn.bosch.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marcin Kozlowski <marcinguy@gmail.com>
  Mark Brown <broonie@kernel.org>
  Mark Jonas <mark.jonas@de.bosch.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Povišer <povik+lin@cutebit.org>
  Melissa Wen <mwen@igalia.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael Kelley <mikelley@microsoft.com>
  Michal Hocko <mhocko@suse.com>
  Mike Snitzer <snitzer@kernel.org>
  Mikulas Patocka <mpatocka@redhat.com>
  Nadav Amit <namit@vmware.com>
  Naohiro Aota <naohiro.aota@wdc.com>
  Nathan Chancellor <nathan@kernel.org>
  Nicolas Dichtel <nicolas.dichtel@6wind.com>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Paolo Abeni <pabeni@redhat.com>
  Patrick Wang <patrick.wang.shcn@gmail.com>
  Paul Gortmaker <paul.gortmaker@windriver.com>
  Peter Seiderer <ps.report@gmx.net>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Petr Malat <oss@malat.biz>
  Philipp Zabel <p.zabel@pengutronix.de>
  QintaoShen <unSimple1993@163.com>
  Rameshkumar Sundaram <quic_ramess@quicinc.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rei Yamamoto <yamamoto.rei@jp.fujitsu.com>
  Rob Clark <robdclark@chromium.org>
  Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
  Roman Li <Roman.Li@amd.com>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Ser <contact@emersion.fr>
  Stephen Boyd <swboyd@chromium.org>
  Steve Capper <steve.capper@arm.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Thomas Gleixner <tglx@linutronix.de>
  Tim Crawford <tcrawford@system76.com>
  Toke Høiland-Jørgensen <toke@redhat.com>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tushar Patel <tushar.patel@amd.com>
  Tyrel Datwyler <tyreld@linux.ibm.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Vinicius Costa Gomes <vinicius.gomes@intel.com>
  Vlad Buslov <vladbu@nvidia.com>
  Wei Liu <wei.liu@kernel.org>
  Will Deacon <will@kernel.org>
  Wolfram Sang <wsa@kernel.org>
  Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e7f5213d755b..dc213ac85601  dc213ac85601199834e7f2d222a5e63d7076d971 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 22:29:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 22:29:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309629.526013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhIoj-0004P6-Br; Wed, 20 Apr 2022 22:28:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309629.526013; Wed, 20 Apr 2022 22:28:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhIoj-0004Oz-8O; Wed, 20 Apr 2022 22:28:57 +0000
Received: by outflank-mailman (input) for mailman id 309629;
 Wed, 20 Apr 2022 22:28:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CUyO=U6=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhIoi-00048L-Du
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 22:28:56 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 42b9e4f9-c0f9-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 00:28:55 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650493727255817.7561172280812;
 Wed, 20 Apr 2022 15:28:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42b9e4f9-c0f9-11ec-8fbf-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650493728; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=EFEPSu5yJSYhRf8ENJBUS8f5prO7/JETT4r+LoFYW8WccbaIxd7DJvXhK1YlIczlyL0m5Yet9hnwvg/Vrdi8AMIa8FBfoC2n7DaVnukArja/C/vLL7v55NGx2Sxvrzt6XBQLxCG4bDqOEGGeKq4uM5MQ4OLP30gR2Vunuvjd9cY=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650493728; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=TRSJFXRMakYmWB2kJyW8tPNfqEyszLPKpOq9/CBWGkU=; 
	b=WhANJIJdQwNjMjbGCa+if9sMxUNqTg5KFUpqYrxMNZyqEAZMS0BbaOzavr481OVVAkGsXYl2GSFnh4WqGCDro07uSrnoUi0/JWWGOheIlt63qQlU8QR17v8KxuSDmfQVCszpAVi84T3edAP6u7rnRjFy/0Dn7J7WVIy+rMnA1kc=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650493728;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=TRSJFXRMakYmWB2kJyW8tPNfqEyszLPKpOq9/CBWGkU=;
	b=CUNip+k1w4bg7wufpzBWHcLNqDqUL+XptA2Oe56QXy2J2CFRZhOPSckTBE9XPM/6
	sQfI+mYbQllWmdf2j7vgct8oFITpbkXnO8XqIqPz4asUUcOgC2dFlaYiH1YjAPFpPCP
	vEc8OoYL/uqBKhOy+eaR8f4XSj0fpHrv6y92te1U=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io,
	jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: [PATCH v2 1/2] xsm: create idle domain privieged and demote after setup
Date: Wed, 20 Apr 2022 18:28:33 -0400
Message-Id: <20220420222834.5478-2-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20220420222834.5478-1-dpsmith@apertussolutions.com>
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

There are now instances where internal hypervisor logic needs to make resource
allocation calls that are protectd by XSM checks. The internal hypervisor logic
is represented a number of system domains which by designed are represented by
non-privileged struct domain instances. To enable these logic blocks to
function correctly but in a controlled manner, this commit changes the idle
domain to be created as a privileged domain under the default policy, which is
inherited by the SILO policy, and demoted before transitioning to running. A
new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
type to demote the idle domain appropriately for that policy type.

For flask a stub is added to ensure that flask policy system will function
correctly with this patch until flask is extended with support for starting the
idle domain privileged and properly demoting it on the call to
xsm_transtion_running.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/arch/arm/setup.c    |  6 ++++++
 xen/arch/x86/setup.c    |  6 ++++++
 xen/common/sched/core.c |  7 ++++++-
 xen/include/xsm/dummy.h | 12 ++++++++++++
 xen/include/xsm/xsm.h   |  6 ++++++
 xen/xsm/dummy.c         |  1 +
 xen/xsm/flask/hooks.c   | 15 +++++++++++++++
 7 files changed, 52 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..763835aeb5 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -1048,6 +1048,12 @@ void __init start_xen(unsigned long boot_phys_offset,
     /* Hide UART from DOM0 if we're using it */
     serial_endboot();
 
+    xsm_transition_running();
+
+    /* Ensure idle domain was not left privileged */
+    if ( current->domain->is_privileged )
+        panic("idle domain did not properly transition from setup privilege\n");
+
     system_state = SYS_STATE_active;
 
     for_each_domain( d )
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 6f20e17892..72695dcb07 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -621,6 +621,12 @@ static void noreturn init_done(void)
     void *va;
     unsigned long start, end;
 
+    xsm_transition_running();
+
+    /* Ensure idle domain was not left privileged */
+    if ( current->domain->is_privileged )
+        panic("idle domain did not properly transition from setup privilege\n");
+
     system_state = SYS_STATE_active;
 
     domain_unpause_by_systemcontroller(dom0);
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab678181..22a619e260 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
         sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
     }
 
-    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
+    /*
+     * idle dom is created privileged to ensure unrestricted access during
+     * setup and will be demoted by xsm_transition_running when setup is
+     * complete
+     */
+    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
     BUG_ON(IS_ERR(idle_domain));
     BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
     idle_domain->vcpu = idle_vcpu;
diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index 58afc1d589..b33f0ec672 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -101,6 +101,18 @@ static always_inline int xsm_default_action(
     }
 }
 
+static XSM_INLINE void cf_check xsm_transition_running(void)
+{
+    struct domain *d = current->domain;
+
+    if ( d->domain_id != DOMID_IDLE )
+        panic("xsm_transition_running should only be called by idle domain\n");
+
+    d->is_privileged = false;
+
+    return;
+}
+
 static XSM_INLINE void cf_check xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
index 3e2b7fe3db..a5c06804ab 100644
--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t;
  * !!! WARNING !!!
  */
 struct xsm_ops {
+    void (*transition_running)(void);
     void (*security_domaininfo)(struct domain *d,
                                 struct xen_domctl_getdomaininfo *info);
     int (*domain_create)(struct domain *d, uint32_t ssidref);
@@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops;
 
 #ifndef XSM_NO_WRAPPERS
 
+static inline void xsm_transition_running(void)
+{
+    alternative_vcall(xsm_ops.transition_running);
+}
+
 static inline void xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 8c044ef615..66f26c6909 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -14,6 +14,7 @@
 #include <xsm/dummy.h>
 
 static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
+    .transition_running            = xsm_transition_running,
     .security_domaininfo           = xsm_security_domaininfo,
     .domain_create                 = xsm_domain_create,
     .getdomaininfo                 = xsm_getdomaininfo,
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 0bf63ffa84..decebc8231 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -186,6 +186,20 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
     return 0;
 }
 
+static void cf_check flask_transition_running(void)
+{
+    struct domain *d = current->domain;
+
+    if ( d->domain_id != DOMID_IDLE )
+        panic("xsm_transition_running should only be called by idle domain\n");
+
+    /*
+     * While is_privileged has no significant meaning under flask,
+     * set to false for the consistency check(s) in the setup code.
+     */
+    d->is_privileged = false;
+}
+
 static void cf_check flask_domain_free_security(struct domain *d)
 {
     struct domain_security_struct *dsec = d->ssid;
@@ -1766,6 +1780,7 @@ static int cf_check flask_argo_send(
 #endif
 
 static const struct xsm_ops __initconst_cf_clobber flask_ops = {
+    .transition_running = flask_transition_running,
     .security_domaininfo = flask_security_domaininfo,
     .domain_create = flask_domain_create,
     .getdomaininfo = flask_getdomaininfo,
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 22:29:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 22:29:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309628.526001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhIoe-00048Y-3G; Wed, 20 Apr 2022 22:28:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309628.526001; Wed, 20 Apr 2022 22:28:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhIoe-00048R-0S; Wed, 20 Apr 2022 22:28:52 +0000
Received: by outflank-mailman (input) for mailman id 309628;
 Wed, 20 Apr 2022 22:28:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CUyO=U6=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhIod-00048L-Nj
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 22:28:51 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3edc8853-c0f9-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 00:28:49 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 165049372519117.4222669135022;
 Wed, 20 Apr 2022 15:28:45 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3edc8853-c0f9-11ec-8fbf-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650493726; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=YNwuHO4ARecXZnsWfG9OnoU9XCq9XdxvND5KCXveA1ZQwd8377UMRhz1c5Qd1S/mudPIKIt5RLvKqMlGzv4hUV6lQBh2XA/dX91DVkaotZVNaVe2zaKEddar+gbBfgHY6aOJvmDOY7p2XIV2ux6JaVxH05Ae1UGpy+BsrrkpcMs=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650493726; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=JVD+GfaoWvDjJRBq7+oTsxIw+uQowdOcLbdplkdNJe0=; 
	b=bLnNyDKudGXBYDHlJ7v+QznK3M1jxdVg6k8+HqOVa81qt5hRlleba4MYDieCF09cM9sPHvA5YjV7kFgQ9EzDJdXwiOqdROELsF6IzzO0Rf4vs2NsQNwAtQ6/+iteYkZyY5J+mdMXP6TDN88n5dp2CwTH/5neLTa1xllXglNSU3s=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650493726;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=JVD+GfaoWvDjJRBq7+oTsxIw+uQowdOcLbdplkdNJe0=;
	b=F85I6ekVUE+hSrmo7RZ2/KgZvpGfxczOogaIRavxUx3weBdOnruqbmGOpSE3KWNg
	3NfLWDpzgZh0n5pocGq65utxxFd46r8t1tamy+zeRpKftDb1JLWRJJBVE26UU0NDZuQ
	+W27tRvx8zaxKqf2vq6ijgI5psJ96ONOIPjZ7Jls=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	scott.davis@starlab.io,
	jandryuk@gmail.com
Subject: [PATCH v2 0/2] Adds starting the idle domain privileged
Date: Wed, 20 Apr 2022 18:28:32 -0400
Message-Id: <20220420222834.5478-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This series makes it so that the idle domain is started privileged under the
default policy, which the SILO policy inherits, and under the flask policy. It
then introduces a new one-way XSM hook, xsm_transition_running, that is hooked
by an XSM policy to transition the idle domain to its running privilege level.

Changes in v2:
- renamed flask_domain_runtime_security() to flask_transition_running()
- added the missed assignment of self_sid

Daniel P. Smith (2):
  xsm: create idle domain privieged and demote after setup
  flask: implement xsm_transtion_running

 tools/flask/policy/modules/xen.if      |  6 ++++++
 tools/flask/policy/modules/xen.te      |  1 +
 tools/flask/policy/policy/initial_sids |  1 +
 xen/arch/arm/setup.c                   |  6 ++++++
 xen/arch/x86/setup.c                   |  6 ++++++
 xen/common/sched/core.c                |  7 ++++++-
 xen/include/xsm/dummy.h                | 12 ++++++++++++
 xen/include/xsm/xsm.h                  |  6 ++++++
 xen/xsm/dummy.c                        |  1 +
 xen/xsm/flask/hooks.c                  | 22 +++++++++++++++++++++-
 xen/xsm/flask/policy/initial_sids      |  1 +
 11 files changed, 67 insertions(+), 2 deletions(-)

-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 22:29:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 22:29:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309634.526024 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhIp4-0004yj-Kx; Wed, 20 Apr 2022 22:29:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309634.526024; Wed, 20 Apr 2022 22:29:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhIp4-0004ya-I3; Wed, 20 Apr 2022 22:29:18 +0000
Received: by outflank-mailman (input) for mailman id 309634;
 Wed, 20 Apr 2022 22:29:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CUyO=U6=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhIp2-00048L-Ue
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 22:29:17 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4ef91ce3-c0f9-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 00:29:16 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650493728447691.6530014584494;
 Wed, 20 Apr 2022 15:28:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ef91ce3-c0f9-11ec-8fbf-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650493730; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=iuJcKq+ndj+QWhAzGfa0ETYdjBS9od22RVIYMRfUNU6z7UgC3FyBj/5xHaDoKyYsdZqD6MjRvkBUcAyvVVHDG1sFJ8l5WFcyEoPb7GzEvMjA9GCxcOHiiJSrOqyxuR+f543abUHowW+Gb+ckXZd4uY/MCJMHnfOCpM/owKnXbcs=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650493730; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=rHJBVfL0hECCWnf5o+DbpSbD0YLUZ/xJtca9sdXcG1M=; 
	b=ayMfG5enGgHrnHUImdpGE3OWHYaY+CIcxc5/9xTaROf4CxL0SW2n6eo50JTnBdvIvCqRrmduftJxkdcdj0Dg/GckZfXlPCTnpB9Z4Mib6xaobXpbmTqpvPMB7sNAX+3QNK3sYuokzs/83zZbjSa4BZSdyweGRDpeNo2oN0bWISs=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650493730;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=rHJBVfL0hECCWnf5o+DbpSbD0YLUZ/xJtca9sdXcG1M=;
	b=cyMGCfOI44D3Oq1w3qCwhizqk5EvQoYfs2gXXQPCaLNo0V0TNImBngfQiyEJT/nT
	stxektkc0Jd3odpcFFUlYARGhNKVY079sLO66pX+cL0Ak2zQk3C9tCC3MRIXhiHjpd8
	7D6MstwnCwUlZ3E/uYazpIDhQunJgECmVaHc3ycg=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io,
	jandryuk@gmail.com,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2 2/2] flask: implement xsm_transtion_running
Date: Wed, 20 Apr 2022 18:28:34 -0400
Message-Id: <20220420222834.5478-3-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20220420222834.5478-1-dpsmith@apertussolutions.com>
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit implements full support for starting the idle domain privileged by
introducing a new flask label xenboot_t which the idle domain is labeled with
at creation.  It then provides the implementation for the XSM hook
xsm_transition_running to relabel the idle domain to the existing xen_t flask
label.

In the reference flask policy a new macro, xen_build_domain(target), is
introduced for creating policies for dom0less/hyperlaunch allowing the
hypervisor to create and assign the necessary resources for domain
construction.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 tools/flask/policy/modules/xen.if      | 6 ++++++
 tools/flask/policy/modules/xen.te      | 1 +
 tools/flask/policy/policy/initial_sids | 1 +
 xen/xsm/flask/hooks.c                  | 7 ++++++-
 xen/xsm/flask/policy/initial_sids      | 1 +
 5 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if
index 5e2aa472b6..4ec676fff1 100644
--- a/tools/flask/policy/modules/xen.if
+++ b/tools/flask/policy/modules/xen.if
@@ -62,6 +62,12 @@ define(`create_domain_common', `
 			setparam altp2mhvm altp2mhvm_op dm };
 ')
 
+# xen_build_domain(target)
+#   Allow a domain to be created at boot by the hypervisor
+define(`xen_build_domain', `
+	allow xenboot_t $1_channel:event create;
+')
+
 # create_domain(priv, target)
 #   Allow a domain to be created directly
 define(`create_domain', `
diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modules/xen.te
index 3dbf93d2b8..de98206fdd 100644
--- a/tools/flask/policy/modules/xen.te
+++ b/tools/flask/policy/modules/xen.te
@@ -24,6 +24,7 @@ attribute mls_priv;
 ################################################################################
 
 # The hypervisor itself
+type xenboot_t, xen_type, mls_priv;
 type xen_t, xen_type, mls_priv;
 
 # Domain 0
diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/policy/initial_sids
index 6b7b7eff21..ec729d3ba3 100644
--- a/tools/flask/policy/policy/initial_sids
+++ b/tools/flask/policy/policy/initial_sids
@@ -2,6 +2,7 @@
 # objects created before the policy is loaded or for objects that do not have a
 # label defined in some other manner.
 
+sid xenboot gen_context(system_u:system_r:xenboot_t,s0)
 sid xen gen_context(system_u:system_r:xen_t,s0)
 sid dom0 gen_context(system_u:system_r:dom0_t,s0)
 sid domxen gen_context(system_u:system_r:domxen_t,s0)
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index decebc8231..0643654aba 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
     switch ( d->domain_id )
     {
     case DOMID_IDLE:
-        dsec->sid = SECINITSID_XEN;
+        dsec->sid = SECINITSID_XENBOOT;
         break;
     case DOMID_XEN:
         dsec->sid = SECINITSID_DOMXEN;
@@ -188,6 +188,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
 
 static void cf_check flask_transition_running(void)
 {
+    struct domain_security_struct *dsec;
     struct domain *d = current->domain;
 
     if ( d->domain_id != DOMID_IDLE )
@@ -198,6 +199,10 @@ static void cf_check flask_transition_running(void)
      * set to false for the consistency check(s) in the setup code.
      */
     d->is_privileged = false;
+
+    dsec = d->ssid;
+    dsec->sid = SECINITSID_XEN;
+    dsec->self_sid = dsec->sid;
 }
 
 static void cf_check flask_domain_free_security(struct domain *d)
diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/initial_sids
index 7eca70d339..e8b55b8368 100644
--- a/xen/xsm/flask/policy/initial_sids
+++ b/xen/xsm/flask/policy/initial_sids
@@ -3,6 +3,7 @@
 #
 # Define initial security identifiers 
 #
+sid xenboot
 sid xen
 sid dom0
 sid domio
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 20 22:37:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 22:37:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309643.526035 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhIx7-0006x8-E8; Wed, 20 Apr 2022 22:37:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309643.526035; Wed, 20 Apr 2022 22:37:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhIx7-0006x1-B9; Wed, 20 Apr 2022 22:37:37 +0000
Received: by outflank-mailman (input) for mailman id 309643;
 Wed, 20 Apr 2022 22:37:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhIx6-0006wr-2O; Wed, 20 Apr 2022 22:37:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhIx5-0002Eg-UK; Wed, 20 Apr 2022 22:37:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhIx5-0006Za-HI; Wed, 20 Apr 2022 22:37:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhIx5-0001ki-Gr; Wed, 20 Apr 2022 22:37:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=slVydBA80fIh2bmhGUOuMqjuXymTTJmQ+HITTyg+t/M=; b=D3WaXJp9Flu2kLkA76u6y0D+4K
	OBtPeSgXYjF0KauGdZw3xSagGdUtGVCrFJbQXPu8A13HJqDPwrGJFRdfLEtqma54ToQY6qR2hpBtD
	dqrWF5Cmr2UmqpSKyuhDLNflpeZ3QfiFPsIS6ZImlq2au0a/GOfk41fXygC/mIqz8AtM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169570-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169570: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fdef107edd4459375f9c0e6e377f30e82d498747
X-Osstest-Versions-That:
    xen=78e072bc375043e81691a59454e09f0b38241ddd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 22:37:35 +0000

flight 169570 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169570/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  fdef107edd4459375f9c0e6e377f30e82d498747
baseline version:
 xen                  78e072bc375043e81691a59454e09f0b38241ddd

Last test of basis   169566  2022-04-20 09:00:28 Z    0 days
Testing same since   169570  2022-04-20 19:03:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   78e072bc37..fdef107edd  fdef107edd4459375f9c0e6e377f30e82d498747 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 22:47:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 22:47:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309651.526045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhJ68-0000Bq-Bk; Wed, 20 Apr 2022 22:46:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309651.526045; Wed, 20 Apr 2022 22:46:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhJ68-0000Bj-8m; Wed, 20 Apr 2022 22:46:56 +0000
Received: by outflank-mailman (input) for mailman id 309651;
 Wed, 20 Apr 2022 22:46:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhJ67-0000Bd-3x
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 22:46:55 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c59d4b67-c0fb-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 00:46:53 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1737361A22;
 Wed, 20 Apr 2022 22:46:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04039C385A1;
 Wed, 20 Apr 2022 22:46:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c59d4b67-c0fb-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650494811;
	bh=coltKSVgO0B0RD+eLJLDzWjwSNKN3sbnfB318hMdCg0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=mglhkRj/iuV7TrEjXIEIgMTn+0BK22SazL130VLpD0hwaUTRTj7BibcviBBfidseB
	 aCMjayKdZKv+Dcxbo1q8jS/vLrZvR85tPSnmSnsNlVP3B918BpP1LsBE2MzVz/17pb
	 EUD95SI6Ns/2XLwW+gCmeVOSqszswv93ca5D5A3YC/IEvnFN6KYW68RCAmySj1213A
	 8Hf5QaXyz7Wl4M4eSEU5ubA6RVAoiZq2Brmehn5klyT8SXYTtUAratHzfR2Hm97JQm
	 cKoyVniv/tlaTu3/aY6hW/c0KSkdXD8kBjw7f6DZbP13gPYUx82jwArfx5jdO2Nb/c
	 gABWUaQB7aO6Q==
Date: Wed, 20 Apr 2022 15:46:50 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <Rahul.Singh@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Christoph Hellwig <hch@lst.de>, xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>, 
    "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
In-Reply-To: <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com> <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop> <8C511888-6183-421E-A4C7-B271DAF46696@arm.com> <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de> <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop> <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com> <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop> <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop> <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-225123715-1650494599=:915916"
Content-ID: <alpine.DEB.2.22.394.2204201543391.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-225123715-1650494599=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204201543392.915916@ubuntu-linux-20-04-desktop>

On Wed, 20 Apr 2022, Rahul Singh wrote:
> > On 20 Apr 2022, at 3:36 am, Stefano Stabellini <sstabellini@kernel.org> wrote:
> >>> Then there is xen_swiotlb_init() which allocates some memory for
> >>> swiotlb-xen at boot. It could lower the total amount of memory
> >>> available, but if you disabled swiotlb-xen like I suggested,
> >>> xen_swiotlb_init() still should get called and executed anyway at boot
> >>> (it is called from arch/arm/xen/mm.c:xen_mm_init). So xen_swiotlb_init()
> >>> shouldn't be the one causing problems.
> >>>
> >>> That's it -- there is nothing else in swiotlb-xen that I can think of.
> >>>
> >>> I don't have any good ideas, so I would only suggest to add more printks
> >>> and report the results, for instance:
> >>
> >> As suggested I added the more printks but only difference I see is the size apart
> >> from that everything looks same .
> >>
> >> Please find the attached logs for xen and native linux boot.
> >
> > One difference is that the order of the allocations is significantly
> > different after the first 3 allocations. It is very unlikely but
> > possible that this is an unrelated concurrency bug that only occurs on
> > Xen. I doubt it.
> 
> I am not sure but just to confirm with you, I see below logs in every scenario.
> SWIOTLB memory allocated by linux swiotlb and used by xen-swiotlb. Is that okay or it can cause some issue.
> 
> [    0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off
> [    0.000000] software IO TLB: mapped [mem 0x00000000f4000000-0x00000000f8000000] (64MB)
> 
> snip from int __ref xen_swiotlb_init(int verbose, bool early)
> /*                                                                         
>      * IO TLB memory already allocated. Just use it.                           
>      */                                                                        
>     if (io_tlb_start != 0) {                                                   
>         xen_io_tlb_start = phys_to_virt(io_tlb_start);                         
>         goto end;                                                              
>     }

Unfortunately there is nothing obvious in the logs. I think we need to
look at the in-details executions of Linux on Xen with swiotlb-xen and
Linux on Xen without swiotlb-xen. The comparison with Linux on native is
not very interesting because the memory layout is a bit different.

The comparison between the two executions should be simple because
swiotlb-xen should be transparent: in this simple case swiotlb-xen
should end up calling always the same functions that would end up being
called anyway without swiotlb-xen. Basically, it should only add a
couple of extra steps in between, nothing else.

As we have already discussed:

- [no swiotlb-xen] dma_alloc_attrs --> dma_direct_alloc
- [swiotlb-xen] dma_alloc_attrs --> xen_swiotlb_alloc_coherent --> dma_direct_alloc

The result should be identical. In xen_swiotlb_alloc_coherent the code
path taken should be:

- xen_alloc_coherent_pages
- if (((dev_addr + size - 1 <= dma_mask)) &&
      !range_straddles_page_boundary(phys, size)) {
      *dma_handle = dev_addr;
- return ret

So basically, it should make zero difference. That is expected because
swiotlb-xen really only comes into play for domU pages. For booting
dom0, it should only be a "useless" indirection.

In the case of xen_swiotlb_map_page, it should be similar. The path
taken should be:

	if (dma_capable(dev, dev_addr, size, true) &&
	    !range_straddles_page_boundary(phys, size) &&
		!xen_arch_need_swiotlb(dev, phys, dev_addr) &&
		swiotlb_force != SWIOTLB_FORCE)
		goto done;

which I think should correspond to this prints in your logs at line 400:

    DEBUG xen_swiotlb_map_page 400 phys=80003c4f000 dev_addr=80003c4f000

So that should be OK too. If different paths are taken, then we have a
problem. If the paths above are taken there should be zero difference
between the swiotlb-xen and the non-swiotlb-xen cases.

Which brings me to your question about xen_swiotlb_init and this
message:

    software IO TLB: mapped [mem 0x00000000f4000000-0x00000000f8000000] (64MB)

The swiotlb-xen buffer should *not* be used if the code paths taken are
the ones above. So it doesn't matter if it is allocated or not. You
could comment out the code in xen_swiotlb_init and everything should
still behave the same.

Finally, my suggestion. Considering all the above, I would look *very*
closely at the execution of Linux on Xen with and without swiotlb-xen.
The differences should be really minimal. Adds prints to all the
swiotlb-xen functions, but really only the following should matter:
- xen_swiotlb_alloc_coherent
- xen_swiotlb_map_page
- xen_swiotlb_unmap_page

What are the differences between the two executions? From the logs:

- the allocation of the swiotlb-xen buffer which leads to 64MB of less
  memory available, but actually if you compared to Linux on Xen
  with/without swiotlb-xen this different would go away because
  xen_swiotlb_init would be called in both cases anyway

- the size upgrade in xen_swiotlb_alloc_coherent: I can see several
  instances of the allocation size being increased. Is that causing the
  problem? It seems unlikely and you have already verified it is not the
  case by removing the size increase in xen_swiotlb_alloc_coherent

- What else is different? There *must* be something, but it is not
  showing in the logs so far.


The only other observation that I have, but it doesn't help, is that the
failure happens on the second 4MB allocation when there is another
concurrent memory allocation of 4K. Neither the 4MB nor the 4K are
size-upgrades by xen_swiotlb_alloc_coherent.

4MB is an larger-than-usual size, but it shouldn't make that much of a
difference. Is that problem that the 4MB have to be contiguous? I don't
see how swiotlb-xen could have an impact in that regard, if not for the
size increase in xen_swiotlb_alloc_coherent.

Please let me know what you find.
--8323329-225123715-1650494599=:915916--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 22:47:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 22:47:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309655.526056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhJ6Y-0000bu-OV; Wed, 20 Apr 2022 22:47:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309655.526056; Wed, 20 Apr 2022 22:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhJ6Y-0000bn-LY; Wed, 20 Apr 2022 22:47:22 +0000
Received: by outflank-mailman (input) for mailman id 309655;
 Wed, 20 Apr 2022 22:47:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhJ6X-0000ap-Nm; Wed, 20 Apr 2022 22:47:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhJ6X-0002Pq-M4; Wed, 20 Apr 2022 22:47:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhJ6X-0006zi-7D; Wed, 20 Apr 2022 22:47:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhJ6X-0002eN-6k; Wed, 20 Apr 2022 22:47:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Wh06sBCp/+khlHHQ/TaMKH2yJi43GaxK6G2D3FzuQ84=; b=HYIXUnMVKnOAOXRue0c/a7gyG1
	LPCW2NnFyeoE4j7qYRdiilrhkouMbiekILhAD+T0mmRs2Sqy+H8j/rwI9IgbgC93maLveVVM9DCUQ
	U2K/HfUN/BK2V7Bn5MV7j7Ezg+KN/jGEFm+34EkK9Bw/bQrbTswtEhPKqB64ib/N02m4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169574-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169574: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=6d2baf9dfbffe43019932c2771cd7d39697d4b11
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Apr 2022 22:47:21 +0000

flight 169574 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169574/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 6d2baf9dfbffe43019932c2771cd7d39697d4b11
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  524 attempts
Testing same since   169571  2022-04-20 19:40:26 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5520 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 22:49:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 22:49:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309665.526068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhJ8q-0001Q6-69; Wed, 20 Apr 2022 22:49:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309665.526068; Wed, 20 Apr 2022 22:49:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhJ8q-0001Pz-3A; Wed, 20 Apr 2022 22:49:44 +0000
Received: by outflank-mailman (input) for mailman id 309665;
 Wed, 20 Apr 2022 22:49:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhJ8p-0001Pr-84
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 22:49:43 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29c08f72-c0fc-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 00:49:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 5ACCF61A39;
 Wed, 20 Apr 2022 22:49:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 142AAC385A1;
 Wed, 20 Apr 2022 22:49:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29c08f72-c0fc-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650494979;
	bh=lIuJHhHOgNuH1ROpspFRdUfMt//99S18SoadoZcLQ2w=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=bQLXb4+jDgHanXvy1kPZqJpVUHaPlyhmwkJTT7UNgx6lSUQEvTFtZNElWpCfHZM2u
	 uSEm9wwnaR67kRfA5QV+fwx2TN5CWRNIFZlwplJoIosnwbj/P7jodXPk9UFZXnhV1G
	 39b3QDB3cT6cqhdr3poCNwmYKOpbF+iwDGmBlu0yK0u56QYoZqRjPcXHMIqZqmkZEM
	 HUNCmTOTdLEbpbw5q9JvIriss3MOvFAXZ4uJTBMG1kdVTFXqfnlspAFGNowJH7ICom
	 a1YivhPopzQ937np+UCWLRf8YleU+8D3WSmiRmhU4i/pvx3H8JdMYVNXZFKnUNR652
	 25koJk+3aRWmQ==
Date: Wed, 20 Apr 2022 15:49:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, Christoph Hellwig <hch@infradead.org>, 
    xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Julien Grall <julien@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio
 devices in Xen guests
In-Reply-To: <7047c7a7-47a0-d446-3b99-94bd552ec90f@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204201549270.915916@ubuntu-linux-20-04-desktop>
References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-7-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2204151305050.915916@ubuntu-linux-20-04-desktop> <YlpdBHKT1bYzZe2e@infradead.org> <f879622e-5656-deb1-1930-f0cd180a4ab1@gmail.com>
 <alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop> <6a04cc34-fbb3-44d8-c1a4-03bda5b3deb1@gmail.com> <b68163be-ad43-7773-22ff-e83191886626@suse.com> <5afb9e61-4164-9cc9-278a-911fc21f4f6c@gmail.com> <alpine.DEB.2.22.394.2204191717020.915916@ubuntu-linux-20-04-desktop>
 <7047c7a7-47a0-d446-3b99-94bd552ec90f@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1919739536-1650494979=:915916"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1919739536-1650494979=:915916
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 20 Apr 2022, Oleksandr wrote:
> On 20.04.22 03:23, Stefano Stabellini wrote:
> > On Tue, 19 Apr 2022, Oleksandr wrote:
> > > On 19.04.22 17:48, Juergen Gross wrote:
> > > > On 19.04.22 14:17, Oleksandr wrote:
> > > > > Hello Stefano, Juergen
> > > > > 
> > > > > 
> > > > > On 18.04.22 22:11, Stefano Stabellini wrote:
> > > > > > On Mon, 18 Apr 2022, Oleksandr wrote:
> > > > > > > On 16.04.22 09:07, Christoph Hellwig wrote:
> > > > > > > 
> > > > > > > Hello Christoph
> > > > > > > 
> > > > > > > > On Fri, Apr 15, 2022 at 03:02:45PM -0700, Stefano Stabellini
> > > > > > > > wrote:
> > > > > > > > > This makes sense overall. Considering that the swiotlb-xen
> > > > > > > > > case
> > > > > > > > > and the
> > > > > > > > > virtio case are mutually exclusive, I would write it like
> > > > > > > > > this:
> > > > > > > > Curious question:  Why can't the same grant scheme also be used
> > > > > > > > for
> > > > > > > > non-virtio devices?  I really hate having virtio hooks in the
> > > > > > > > arch
> > > > > > > > dma code.  Why can't Xen just say in DT/ACPI that grants can be
> > > > > > > > used
> > > > > > > > for a given device?
> > > > > > [...]
> > > > > > 
> > > > > > > This patch series tries to make things work with "virtio" devices
> > > > > > > in
> > > > > > > Xen
> > > > > > > system without introducing any modifications to code under
> > > > > > > drivers/virtio.
> > > > > > Actually, I think Christoph has a point.
> > > > > > 
> > > > > > There is nothing inherently virtio specific in this patch series or
> > > > > > in
> > > > > > the "xen,dev-domid" device tree binding.
> > > > > 
> > > > > Although the main intention of this series was to enable using virtio
> > > > > devices in Xen guests, I agree that nothing in new DMA ops layer
> > > > > (xen-virtio.c) is virtio specific (at least at the moment). Regarding
> > > > > the
> > > > > whole patch series I am not quite sure, as it uses
> > > > > arch_has_restricted_virtio_memory_access(). >
> > > > > >    Assuming a given device is
> > > > > > emulated by a Xen backend, it could be used with grants as well.
> > > > > > 
> > > > > > For instance, we could provide an emulated e1000 NIC with a
> > > > > > "xen,dev-domid" property in device tree. Linux could use grants with
> > > > > > it
> > > > > > and the backend could map the grants. It would work the same way as
> > > > > > virtio-net/block/etc. Passthrough devices wouldn't have the
> > > > > > "xen,dev-domid" property, so no problems.
> > > > > > 
> > > > > > So I think we could easily generalize this work and expand it to any
> > > > > > device. We just need to hook on the "xen,dev-domid" device tree
> > > > > > property.
> > > > > > 
> > > > > > I think it is just a matter of:
> > > > > > - remove the "virtio,mmio" check from xen_is_virtio_device
> > > > > > - rename xen_is_virtio_device to something more generic, like
> > > > > >     xen_is_grants_device
> > > > xen_is_grants_dma_device, please. Normal Xen PV devices are covered by
> > > > grants, too, and I'd like to avoid the confusion arising from this.
> > > 
> > > yes, this definitely makes sense as we need to distinguish
> > > 
> > > 
> > > > 
> > > > > > - rename xen_virtio_setup_dma_ops to something more generic, like
> > > > > >     xen_grants_setup_dma_ops
> > > > > > 
> > > > > > And that's pretty much it.
> > > > > + likely renaming everything in that patch series not to mention
> > > > > virtio
> > > > > (mostly related to xen-virtio.c internals).
> > > > > 
> > > > > 
> > > > > Stefano, thank you for clarifying Christoph's point.
> > > > > 
> > > > > Well, I am not against going this direction. Could we please make a
> > > > > decision on this? @Juergen, what is your opinion?
> > > > Yes, why not.
> > > 
> > > ok, thank you for confirming.
> > > 
> > > 
> > > > 
> > > > Maybe rename xen-virtio.c to grant-dma.c?
> > > 
> > > Personally I don't mind.
> > > 
> > > 
> > > > I'd keep the XEN_VIRTIO related config option, as this will be the
> > > > normal
> > > > use
> > > > case. grant-dma.c should be covered by a new hidden config option
> > > > XEN_GRANT_DMA
> > > > selected by XEN_VIRTIO.
> > > 
> > > I got it, ok
> > > 
> > > 
> > > > 
> > > > CONFIG_XEN_VIRTIO should still guard
> > > > xen_has_restricted_virtio_memory_access().
> > > 
> > > ok
> > > 
> > > 
> > > So a few questions to clarify:
> > > 
> > > 1. What is the best place to keep "xen,dev-domid" binding's description
> > > now? I
> > > think that proposed in current series place
> > > (Documentation/devicetree/bindings/virtio/) is not good fit now.
> > I would probably add it to the existing
> > Documentation/devicetree/bindings/arm/xen.txt.
> > 
> > 
> > > 2. I assume the logic in the current patch will remain the same, I mean we
> > > will still assign Xen grant DMA ops from xen_setup_dma_ops() here?
> > Yes I think so
> 
> 
> Stefano, thank you for clarifying!
> 
> 
> Regarding new naming scheme...
> 
> As there is an existing Kconfig option XEN_GRANT_DMA_ALLOC used for different
> purpose, we need to clarify naming scheme here a bit to avoid possible
> confusion.
> 
> For example, I am happy with proposed by Juergen ...
> 
> ... Kconfig option: XEN_GRANT_DMA_OPS
> 
> and
> 
> ... file: grant-dma-ops.c

I think that's fine by me
--8323329-1919739536-1650494979=:915916--


From xen-devel-bounces@lists.xenproject.org Wed Apr 20 23:31:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Apr 2022 23:31:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309671.526079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhJnF-0007Ed-Cr; Wed, 20 Apr 2022 23:31:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309671.526079; Wed, 20 Apr 2022 23:31:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhJnF-0007EW-9b; Wed, 20 Apr 2022 23:31:29 +0000
Received: by outflank-mailman (input) for mailman id 309671;
 Wed, 20 Apr 2022 23:31:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HBwa=U6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhJnD-0007EQ-It
 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 23:31:27 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fdf57b20-c101-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 01:31:24 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id B3D1061B14;
 Wed, 20 Apr 2022 23:31:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5FD4C385A0;
 Wed, 20 Apr 2022 23:31:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdf57b20-c101-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650497483;
	bh=4qwbtgRQoC2otELmI9XE6FDW8+VhxpRDQPma0JXMSEo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=a/7+aj1Zwm92G2Xz1K2PTRVfDTRy+aU6JnfXkBaq0obi8vHZnVTfTmfDOUvnFaDOY
	 aHs+NzzjSyazeRW+CnJWQFMrkQ7iTTg44sx/QNm1Sm4P9qVUTgw8HkE/UuJrtnxLpP
	 a2kdPGwL7/205/S5CdnWtFmlGcdPVe/jkx597I1xpMlFiCQ2LdMLp/cDZgwdWZEKup
	 MWWeO7sdCUleUR4lpR5/yBAUctNCWET7WTJkp0cPe4hJzZxBgKXfBK0yC5+0OZ5Cc4
	 wHGmF3mVIVCD7EA7uj1DErctx4EYS2HOn5SjwFjoiprIjMWtxVWCmfhs1/tAUUXdiQ
	 eKjjsxbyW2Oqw==
Date: Wed, 20 Apr 2022 16:31:22 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, cardoe@cardoe.com, wl@xen.org, 
    andrew.cooper3@citrix.com, anthony.perard@citrix.com, 
    bertrand.marquis@arm.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v5 2/2] gitlab-ci: add an ARM32 qemu-based smoke test
In-Reply-To: <6e01871e-9e47-2d92-617e-952dde2df3b2@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204201630330.915916@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop> <20220416001701.1301324-2-sstabellini@kernel.org> <6e01871e-9e47-2d92-617e-952dde2df3b2@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 19 Apr 2022, Michal Orzel wrote:
> On 16.04.2022 02:17, Stefano Stabellini wrote:
> > Add a minimal ARM32 smoke test based on qemu-system-arm, as provided by
> > the test-artifacts qemu container. The minimal test simply boots Xen
> > (built from previous build stages) and Dom0.
> > 
> > The test needs a working kernel and minimal initrd for dom0. Instead of
> > building our own kernel and initrd, which would mean maintaining one or
> > two more builting scripts under automation/, we borrow a kernel and
> > initrd from distros.
> > 
> > For the kernel we pick the Debian Bullseye kernel, which has everything
> > we need already built-in. However, we cannot use the Debian Bullseye
> > initrd because it is 22MB and the large size causes QEMU to core dump.
> > 
> > Instead, use the tiny busybox-based rootfs provided by Alpine Linux,
> > which is really minimal: just 2.5MB. Note that we cannot use the Alpine
> > Linux kernel because that doesn't boot on Xen.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > ---
> > Changes in v5:
> > - use "virt" machine in QEMU
> 
> > +# For Xen, we need a couple of more node. Dump the DT from QEMU and add them
> > +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded
> > +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom
> > +./qemu-system-arm \
> > +   -machine virt \
> You changed machine to virt here, but ...
> 
> > +rm -f smoke.serial
> > +set +e
> > +timeout -k 1 240 \
> > +./qemu-system-arm \
> > +   -machine virt-6.0 \
> forgot to change it here as well.

Oops, yes I did. Well spotted. Just sending this one update here.


---
gitlab-ci: add an ARM32 qemu-based smoke test

Add a minimal ARM32 smoke test based on qemu-system-arm, as provided by
the test-artifacts qemu container. The minimal test simply boots Xen
(built from previous build stages) and Dom0.

The test needs a working kernel and minimal initrd for dom0. Instead of
building our own kernel and initrd, which would mean maintaining one or
two more builting scripts under automation/, we borrow a kernel and
initrd from distros.

For the kernel we pick the Debian Bullseye kernel, which has everything
we need already built-in. However, we cannot use the Debian Bullseye
initrd because it is 22MB and the large size causes QEMU to core dump.

Instead, use the tiny busybox-based rootfs provided by Alpine Linux,
which is really minimal: just 2.5MB. Note that we cannot use the Alpine
Linux kernel because that doesn't boot on Xen.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
Changes:
- use virt machine instead of virt-6.0 at both call sites
---
 automation/gitlab-ci/test.yaml         | 23 ++++++++
 automation/scripts/qemu-smoke-arm32.sh | 81 ++++++++++++++++++++++++++
 2 files changed, 104 insertions(+)
 create mode 100755 automation/scripts/qemu-smoke-arm32.sh

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index ec2a2e1607..42cd725a12 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -95,6 +95,29 @@ qemu-smoke-arm64-gcc:
     - /^coverity-tested\/.*/
     - /^stable-.*/
 
+qemu-smoke-arm32-gcc:
+  stage: test
+  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  variables:
+    CONTAINER: debian:unstable-arm64v8
+  script:
+    - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
+  dependencies:
+    - debian-unstable-gcc-arm32
+    - qemu-system-aarch64-6.0.0-arm32-export
+  artifacts:
+    paths:
+      - smoke.serial
+      - '*.log'
+    when: always
+  tags:
+    - arm64
+  except:
+    - master
+    - smoke
+    - /^coverity-tested\/.*/
+    - /^stable-.*/
+
 qemu-smoke-x86-64-gcc:
   stage: test
   image: registry.gitlab.com/xen-project/xen/${CONTAINER}
diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh
new file mode 100755
index 0000000000..530f3892fd
--- /dev/null
+++ b/automation/scripts/qemu-smoke-arm32.sh
@@ -0,0 +1,81 @@
+#!/bin/bash
+
+set -ex
+
+export DEBIAN_FRONTENT=noninteractive
+apt-get -qy update
+apt-get -qy install --no-install-recommends device-tree-compiler \
+                                            curl \
+                                            cpio
+
+cd binaries
+# Use the kernel from Debian
+curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz
+# Use a tiny initrd based on busybox from Alpine Linux
+curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz
+
+mkdir rootfs
+cd rootfs
+tar xvzf ../initrd.tar.gz
+find . | cpio -H newc -o | gzip > ../initrd.gz
+cd ..
+
+kernel=`stat -L --printf="%s" vmlinuz`
+initrd=`stat -L --printf="%s" initrd.gz`
+
+# For Xen, we need a couple of more node. Dump the DT from QEMU and add them
+# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded
+curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom
+./qemu-system-arm \
+   -machine virt \
+   -machine virtualization=true \
+   -smp 4 \
+   -m 1024 \
+   -serial stdio \
+   -monitor none \
+   -display none \
+   -machine dumpdtb=virt.dtb
+
+dtc -I dtb -O dts virt.dtb > virt.dts
+
+cat >> virt.dts << EOF
+/ {
+	chosen {
+		#address-cells = <0x2>;
+		#size-cells = <0x2>;
+		stdout-path = "/pl011@9000000";
+        xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0";
+		xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh";
+		dom0 {
+			compatible = "xen,linux-zimage", "xen,multiboot-module";
+			reg = <0x0 0x1000000 0x0 $kernel>;
+		};
+        dom0-ramdisk {
+			compatible = "xen,linux-initrd", "xen,multiboot-module";
+			reg = <0x0 0x3200000 0x0 $initrd>;
+		};
+	};
+};
+EOF
+dtc -I dts -O dtb virt.dts > virt.dtb
+
+rm -f smoke.serial
+set +e
+timeout -k 1 240 \
+./qemu-system-arm \
+   -machine virt \
+   -machine virtualization=true \
+   -smp 4 \
+   -m 1024 \
+   -serial stdio \
+   -monitor none \
+   -display none \
+   -dtb virt.dtb \
+   -no-reboot \
+   -kernel ./xen \
+   -device loader,file=./vmlinuz,addr=0x1000000 \
+   -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial
+
+set -e
+(grep -q "^/ #" smoke.serial) || exit 1
+exit 0
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 00:08:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 00:08:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309677.526090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKNG-0003Y9-9n; Thu, 21 Apr 2022 00:08:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309677.526090; Thu, 21 Apr 2022 00:08:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKNG-0003Y2-6l; Thu, 21 Apr 2022 00:08:42 +0000
Received: by outflank-mailman (input) for mailman id 309677;
 Thu, 21 Apr 2022 00:08:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhKNE-0003Xo-2i
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 00:08:40 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 312ffa3c-c107-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 02:08:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2F81AB821D9;
 Thu, 21 Apr 2022 00:08:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57BD4C385A0;
 Thu, 21 Apr 2022 00:08:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 312ffa3c-c107-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650499716;
	bh=TvnMk/5d2+4Kfw5dtsHq6wHU83fKbKyv30oC++gxv+0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=PgmIT6nIyCcMzOQ7pNcYCmhjCw2gDliaLf1WPXnxgD6xAUD89tzDO+1z3UUiz61mR
	 /D/39WisHdnfOPBEFgIUe5zZdM4B25aD1+suOGZotQiWJ9ZvbRB0hbdFNE72yQNb4t
	 ZE3FbMfL0Y63p5SbhkOs99xwOm5+vievwuPhmWcEQg00Zw8I2Dnq8goGE8WQNa3X/c
	 JrHBeQoiBfPLHluKIQqQWs/7l+pX/Bt10d/BA6mwJ2GEDx50jIoYFcarcw6uwVvnMX
	 OvUVOgcbaeMOKnedFwZqCrooMa47kTSV1Q5kUk3D2EwYo9oPPDFv95KZfX8RvDF1pf
	 H6YUGXBfd3bYQ==
Date: Wed, 20 Apr 2022 17:08:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Penny Zheng <Penny.Zheng@arm.com>
cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 4/6] xen/arm: introduce CDF_staticmem
In-Reply-To: <20220418122251.3583049-5-Penny.Zheng@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204201708240.915916@ubuntu-linux-20-04-desktop>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com> <20220418122251.3583049-5-Penny.Zheng@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 18 Apr 2022, Penny Zheng wrote:
> In order to have an easy and quick way to find out whether this domain memory
> is statically configured, this commit introduces a new flag CDF_staticmem and a
> new helper is_domain_static to tell.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> v2 changes:
> - change name from "is_domain_on_static_allocation" to "is_domain_static()"
> ---
>  xen/arch/arm/domain_build.c       | 5 ++++-
>  xen/arch/arm/include/asm/domain.h | 2 ++
>  xen/include/xen/domain.h          | 2 ++
>  3 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 8be01678de..4e62fd0bf1 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3191,9 +3191,12 @@ void __init create_domUs(void)
>          if ( !dt_device_is_compatible(node, "xen,domain") )
>              continue;
>  
> +        if ( dt_find_property(node, "xen,static-mem", NULL) )
> +            flags |= CDF_staticmem;
> +
>          if ( dt_property_read_bool(node, "direct-map") )
>          {
> -            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) )
> +            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !(flags & CDF_staticmem) )
>                  panic("direct-map is not valid for domain %s without static allocation.\n",
>                        dt_node_name(node));
>  
> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index 36ec00e62d..b097433f9f 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -31,6 +31,8 @@ enum domain_type {
>  
>  #define is_domain_direct_mapped(d) ((d)->flags & CDF_directmap)
>  
> +#define is_domain_static(d) ((d)->flags & CDF_staticmem)
> +
>  /*
>   * Is the domain using the host memory layout?
>   *
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 1c3c88a14d..35dc7143a4 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -34,6 +34,8 @@ void arch_get_domain_info(const struct domain *d,
>  #ifdef CONFIG_ARM
>  /* Should domain memory be directly mapped? */
>  #define CDF_directmap            (1U << 1)
> +/* Is domain memory on static allocation? */
> +#define CDF_staticmem            (1U << 2)
>  #endif
>  
>  /*
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 00:17:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 00:17:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309684.526100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKW8-0005Kg-BH; Thu, 21 Apr 2022 00:17:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309684.526100; Thu, 21 Apr 2022 00:17:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKW8-0005KZ-7y; Thu, 21 Apr 2022 00:17:52 +0000
Received: by outflank-mailman (input) for mailman id 309684;
 Thu, 21 Apr 2022 00:17:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhKW7-0005KP-Bq
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 00:17:51 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7a649acd-c108-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 02:17:50 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 979BFB82144;
 Thu, 21 Apr 2022 00:17:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E589CC385A0;
 Thu, 21 Apr 2022 00:17:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a649acd-c108-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650500268;
	bh=NWF8OHvmAnZ/tFu+kHeaLBtgsCFjPSwiXspk4eGd9oI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=X0oPAqgK0ma7aXFfDBfXKVxyyA74oLxu6T/JcUf4zf//iHQpbJIx4Spo9+EWYO98V
	 HtBcVr+tAFkMI2YnB0iRCRqusWEkTlAPMEn08i2lB0xhT3efiHV1+4ufaaJduUvIxp
	 FC0C/3ntqpvgxrgHb4wJTZM7odPCfwcScL9TjrXxZKJFQQQCloY79lf5k8aqfaWUpx
	 E9MATHoEfM1nQOgBVNCB2e2rA6CbKTsQ7SlupXsLclbzUvY1w8witixL1iWy8tpgyp
	 dPhf+nF2Un+EgzbkBZBomogiCRnSs4SVV0carc2//7boJkwc/209Q38jDiRgOU5TSU
	 WdJtuqNYsa5Dg==
Date: Wed, 20 Apr 2022 17:17:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <wei.chen@arm.com>
cc: xen-devel@lists.xenproject.org, nd@arm.com, 
    Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from
 x86 to common
In-Reply-To: <20220418090735.3940393-3-wei.chen@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204201717320.915916@ubuntu-linux-20-04-desktop>
References: <20220418090735.3940393-1-wei.chen@arm.com> <20220418090735.3940393-3-wei.chen@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 18 Apr 2022, Wei Chen wrote:
> Most of the functions in x86 EFI stub.c can be reused for other
> architectures. So we move them to common and keep the x86 specific
> function in stub-x86.c.
> 
> Signed-off-by: Wei Chen <wei.chen@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> v1 -> v2:
> 1. Drop the copy of stub.c from Arm EFI.
> 2. Share common codes of x86 EFI stub for other architectures.
> ---
>  xen/arch/x86/efi/Makefile               |  4 +--
>  xen/arch/x86/efi/{stub.c => stub-x86.c} | 37 ------------------------
>  xen/common/efi/stub.c                   | 38 +++++++++++++++++++++++++
>  3 files changed, 40 insertions(+), 39 deletions(-)
>  rename xen/arch/x86/efi/{stub.c => stub-x86.c} (71%)
>  create mode 100644 xen/common/efi/stub.c
> 
> diff --git a/xen/arch/x86/efi/Makefile b/xen/arch/x86/efi/Makefile
> index 034ec87895..5ca3a0b4a4 100644
> --- a/xen/arch/x86/efi/Makefile
> +++ b/xen/arch/x86/efi/Makefile
> @@ -11,8 +11,8 @@ $(obj)/boot.init.o: $(obj)/buildid.o
>  $(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary=4)
>  $(addprefix $(obj)/,$(EFIOBJ-y)): CFLAGS_stack_boundary := $(cflags-stack-boundary)
>  
> -obj-y := stub.o
> +obj-y := stub.o stub-x86.o
>  obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y))
>  obj-bin-$(XEN_BUILD_EFI) := $(filter %.init.o,$(EFIOBJ-y))
>  extra-$(XEN_BUILD_EFI) += buildid.o relocs-dummy.o
> -nocov-$(XEN_BUILD_EFI) += stub.o
> +nocov-$(XEN_BUILD_EFI) += stub.o stub-x86.o
> diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub-x86.c
> similarity index 71%
> rename from xen/arch/x86/efi/stub.c
> rename to xen/arch/x86/efi/stub-x86.c
> index 9984932626..2cd5c8d4dc 100644
> --- a/xen/arch/x86/efi/stub.c
> +++ b/xen/arch/x86/efi/stub-x86.c
> @@ -1,7 +1,5 @@
>  #include <xen/efi.h>
> -#include <xen/errno.h>
>  #include <xen/init.h>
> -#include <xen/lib.h>
>  #include <asm/asm_defns.h>
>  #include <asm/efibind.h>
>  #include <asm/page.h>
> @@ -45,11 +43,6 @@ void __init noreturn efi_multiboot2(EFI_HANDLE ImageHandle,
>      unreachable();
>  }
>  
> -bool efi_enabled(unsigned int feature)
> -{
> -    return false;
> -}
> -
>  void __init efi_init_memory(void) { }
>  
>  bool efi_boot_mem_unused(unsigned long *start, unsigned long *end)
> @@ -61,33 +54,3 @@ bool efi_boot_mem_unused(unsigned long *start, unsigned long *end)
>  }
>  
>  void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t l4e) { }
> -
> -bool efi_rs_using_pgtables(void)
> -{
> -    return false;
> -}
> -
> -unsigned long efi_get_time(void)
> -{
> -    BUG();
> -    return 0;
> -}
> -
> -void efi_halt_system(void) { }
> -void efi_reset_system(bool warm) { }
> -
> -int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
> -{
> -    return -ENOSYS;
> -}
> -
> -int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *)
> -    __attribute__((__alias__("efi_get_info")));
> -
> -int efi_runtime_call(struct xenpf_efi_runtime_call *op)
> -{
> -    return -ENOSYS;
> -}
> -
> -int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *)
> -    __attribute__((__alias__("efi_runtime_call")));
> diff --git a/xen/common/efi/stub.c b/xen/common/efi/stub.c
> new file mode 100644
> index 0000000000..6e4f4de9af
> --- /dev/null
> +++ b/xen/common/efi/stub.c
> @@ -0,0 +1,38 @@
> +#include <xen/efi.h>
> +#include <xen/errno.h>
> +#include <xen/lib.h>
> +
> +bool efi_enabled(unsigned int feature)
> +{
> +    return false;
> +}
> +
> +bool efi_rs_using_pgtables(void)
> +{
> +    return false;
> +}
> +
> +unsigned long efi_get_time(void)
> +{
> +    BUG();
> +    return 0;
> +}
> +
> +void efi_halt_system(void) { }
> +void efi_reset_system(bool warm) { }
> +
> +int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
> +{
> +    return -ENOSYS;
> +}
> +
> +int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *)
> +    __attribute__((__alias__("efi_get_info")));
> +
> +int efi_runtime_call(struct xenpf_efi_runtime_call *op)
> +{
> +    return -ENOSYS;
> +}
> +
> +int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *)
> +    __attribute__((__alias__("efi_runtime_call")));
> -- 
> 2.25.1
> 
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 00:24:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 00:24:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309692.526124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKcF-00075n-5x; Thu, 21 Apr 2022 00:24:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309692.526124; Thu, 21 Apr 2022 00:24:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKcF-00075g-2o; Thu, 21 Apr 2022 00:24:11 +0000
Received: by outflank-mailman (input) for mailman id 309692;
 Thu, 21 Apr 2022 00:24:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhKcD-00075W-Ln; Thu, 21 Apr 2022 00:24:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhKcD-0004gP-JG; Thu, 21 Apr 2022 00:24:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhKcD-0004HW-2d; Thu, 21 Apr 2022 00:24:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhKcD-0003zl-1s; Thu, 21 Apr 2022 00:24:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=95CQB2H1OidqtCLprbiFAO2mCUmxUuFjC84wsIBwvSg=; b=ZBP5hClatNSpIacooyCTWYlCv/
	RgRjbZ7egb9tePml8wgb5K+BZG5YUy3TMx8rCEvlxrSrzWSmqetg1WL08F9bwGnZUPdmnVQpqx38z
	JJkygO+6/MYIv9OFDE8zLGueUDa+RpjzeQl8Qt7P2h7dCIR8y2z3xAeEJMrfTiz8Gzac=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169565-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169565: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e9935146cd695188e70c10a6dda9f24ef9b63e30
X-Osstest-Versions-That:
    xen=2ce9afd68e0bacc15b5570a983fa626cc4de9dbd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 00:24:09 +0000

flight 169565 xen-unstable real [real]
flight 169576 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169565/
http://logs.test-lab.xenproject.org/osstest/logs/169576/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 169576-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169550
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169550
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169550
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169550
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169550
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  e9935146cd695188e70c10a6dda9f24ef9b63e30
baseline version:
 xen                  2ce9afd68e0bacc15b5570a983fa626cc4de9dbd

Last test of basis   169550  2022-04-19 23:36:53 Z    1 days
Testing same since   169565  2022-04-20 08:57:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bertrand Marquis <bertrand.marquis@arm.com>
  Henry Wang <Henry.Wang@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Peng Fan <peng.fan@nxp.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2ce9afd68e..e9935146cd  e9935146cd695188e70c10a6dda9f24ef9b63e30 -> master


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 00:24:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 00:24:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309697.526134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKcc-0007Vr-FP; Thu, 21 Apr 2022 00:24:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309697.526134; Thu, 21 Apr 2022 00:24:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKcc-0007Vk-CS; Thu, 21 Apr 2022 00:24:34 +0000
Received: by outflank-mailman (input) for mailman id 309697;
 Thu, 21 Apr 2022 00:24:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhKca-0007VA-E0; Thu, 21 Apr 2022 00:24:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhKca-0004gV-DE; Thu, 21 Apr 2022 00:24:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhKca-0004J3-2s; Thu, 21 Apr 2022 00:24:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhKca-0004LC-2S; Thu, 21 Apr 2022 00:24:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PkcAcDP5fnco6aZV3SMKYYPHezA2vbkDkHEopXuPuA0=; b=ybAiguOTOtLONg2cJ7bOlKI+QB
	p0FglrCBHS6yDSfmYxOXwA0agEyTqG7qrtCfEcg0C9sQ7EHin78pOlGKO/JQcQQJtsIS3++jMw4ns
	3LAVs74aE5NGeBh0008eEnoW7O7kCCz/hJ7tQj1l++Flxy5c7nLcZAic8UZRlbNrT4Ww=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169575-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169575: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=6d2baf9dfbffe43019932c2771cd7d39697d4b11
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 00:24:32 +0000

flight 169575 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169575/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 6d2baf9dfbffe43019932c2771cd7d39697d4b11
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   50 days  525 attempts
Testing same since   169571  2022-04-20 19:40:26 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5520 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 00:25:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 00:25:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309707.526146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKdm-0008Hs-0c; Thu, 21 Apr 2022 00:25:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309707.526146; Thu, 21 Apr 2022 00:25:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKdl-0008Hl-Rx; Thu, 21 Apr 2022 00:25:45 +0000
Received: by outflank-mailman (input) for mailman id 309707;
 Thu, 21 Apr 2022 00:25:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhKdl-0008HX-DI
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 00:25:45 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94723bef-c109-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 02:25:44 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6CC0461B65;
 Thu, 21 Apr 2022 00:25:42 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D4D0C385A1;
 Thu, 21 Apr 2022 00:25:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94723bef-c109-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650500741;
	bh=F5z1Sq5i0vA2eHARyKF/bte/6EWjDK59RP6Y9XTCLHI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=NUZlATHTgvt9jsYfKIL/fUeBncEPYaIQq9mneEBIkbvPog5rwjRtwOGkgK3xaLf8p
	 4m+8EVjWBTFFQQ64rPKKei4w/rQpbtN3Lc9axdcq5W07aBHbcAFnDieWR3MX0pkZJl
	 J9+SR1VAf+zL9UYlVY6Zv+95L1zAlaM0WeH4Y8m8ahjYaJuPwhJJQD2TVbKw9Botgy
	 W13SYXll4SXdlzU0o7f+k01AAD5v2JGMzWxXHqQXr3JWEUnFYsuDAI4XTnUp13NdJU
	 SGJHm157TGcLYgEMz/UKbF2W/607a35elbQXThqnrzk1PIa+GKl2fA1tnTN3pkfRV/
	 iOM3rDtu1VpQQ==
Date: Wed, 20 Apr 2022 17:25:41 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <wei.chen@arm.com>
cc: xen-devel@lists.xenproject.org, nd@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 03/10] xen/arm: add CONFIG_ARM_EFI to stub EFI API
In-Reply-To: <20220418090735.3940393-4-wei.chen@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204201724430.915916@ubuntu-linux-20-04-desktop>
References: <20220418090735.3940393-1-wei.chen@arm.com> <20220418090735.3940393-4-wei.chen@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 18 Apr 2022, Wei Chen wrote:
> x86 is using compiler feature testing to decide EFI
> build enable or not. When EFI build is disabled, x86
> will use a efi/stub.c file to replace efi/runtime.c
> for build objects. Following this idea, we introduce
> a stub file for Arm, but use CONFIG_ARM_EFI to decide
> EFI build enable or not.
> 
> Signed-off-by: Wei Chen <wei.chen@arm.com>
> ---
> v1 -> v2:
> 1. Use CONFIG_ARM_EFI to replace CONFIG_EFI
> 2. Remove help text and make CONFIG_ARM_EFI invisible.
> 3. Merge one following patch:
>    xen/arm: introduce a stub file for non-EFI architectures
> 4. Use the common stub.c instead of creating new one.
> ---
>  xen/arch/arm/Kconfig      | 5 +++++
>  xen/arch/arm/Makefile     | 2 +-
>  xen/arch/arm/efi/Makefile | 5 +++++
>  3 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4..5f1b0121b0 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -6,6 +6,7 @@ config ARM_64
>  	def_bool y
>  	depends on !ARM_32
>  	select 64BIT
> +	select ARM_EFI
>  	select HAS_FAST_MULTIPLY
>  
>  config ARM
> @@ -33,6 +34,10 @@ config ACPI
>  	  Advanced Configuration and Power Interface (ACPI) support for Xen is
>  	  an alternative to device tree on ARM64.
>  
> +config ARM_EFI
> +	bool
> +	depends on ARM_64

As ARM_EFI is selected by ARM_64 and it cannot be enable via a menu (it
is hidden) there is no need for the "depends" line here


>  config GICV3
>  	bool "GICv3 driver"
>  	depends on ARM_64 && !NEW_VGIC
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 1d862351d1..bb7a6151c1 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -1,6 +1,5 @@
>  obj-$(CONFIG_ARM_32) += arm32/
>  obj-$(CONFIG_ARM_64) += arm64/
> -obj-$(CONFIG_ARM_64) += efi/
>  obj-$(CONFIG_ACPI) += acpi/
>  obj-$(CONFIG_HAS_PCI) += pci/
>  ifneq ($(CONFIG_NO_PLAT),y)
> @@ -20,6 +19,7 @@ obj-y += domain.o
>  obj-y += domain_build.init.o
>  obj-y += domctl.o
>  obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
> +obj-y += efi/
>  obj-y += gic.o
>  obj-y += gic-v2.o
>  obj-$(CONFIG_GICV3) += gic-v3.o
> diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile
> index 4313c39066..75ef180233 100644
> --- a/xen/arch/arm/efi/Makefile
> +++ b/xen/arch/arm/efi/Makefile
> @@ -1,4 +1,9 @@
>  include $(srctree)/common/efi/efi-common.mk
>  
> +ifeq ($(CONFIG_ARM_EFI),y)
>  obj-y += $(EFIOBJ-y)
>  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
> +else
> +EFIOBJ-y += stub.o
> +obj-y += stub.o

The change to EFIOBJ-y is not needed here as EFIOBJ-y is not used.
Only obj-y += stub.o should be enough

> +endif
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 00:30:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 00:30:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309714.526156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKiD-0001In-GI; Thu, 21 Apr 2022 00:30:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309714.526156; Thu, 21 Apr 2022 00:30:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKiD-0001Ig-DW; Thu, 21 Apr 2022 00:30:21 +0000
Received: by outflank-mailman (input) for mailman id 309714;
 Thu, 21 Apr 2022 00:30:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhKiC-0001Ia-Qw
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 00:30:20 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 39429bf7-c10a-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 02:30:19 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 55219B82239;
 Thu, 21 Apr 2022 00:30:19 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A137C385A0;
 Thu, 21 Apr 2022 00:30:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39429bf7-c10a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650501017;
	bh=Yvmw5PHMhlY0F2tFAujdl+1NQEj9T2rDNEyfu7S1j+4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=RX6eUHm+8GXgQ7pWkMXbtP1RJ37VGYqLmtfyDhuNfM3RPVuAhKpuyEoiCJwALxkK6
	 Bj+v+AoESa/4haDpoGB2G2z8gLfAIfpBecGPSXQuw96N4dmsMk3b4GUhtJLmgEbJ3M
	 USLHFvnZw1swpHjJohWoA03SIZ9OiQRT1CCeP31ulak2I847yrs5w3bQ+ZLO+BFMWH
	 Ml4Ks3SC7YeGpTsKjV1viMQO3sYBj7tZikq139/ej3o2T6KsN6pAp9+uOX4uhqYGkP
	 V0KvM6ulHevER+WUO9lPGeod0yKIiZSLGP4W5DWqDDfTRCGtX2Egm9pG9jBgMPrjcV
	 MXQ6TvIH3r82A==
Date: Wed, 20 Apr 2022 17:30:17 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <wei.chen@arm.com>
cc: xen-devel@lists.xenproject.org, nd@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 04/10] xen/arm: Keep memory nodes in device tree when
 Xen boots from EFI
In-Reply-To: <20220418090735.3940393-5-wei.chen@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204201728560.915916@ubuntu-linux-20-04-desktop>
References: <20220418090735.3940393-1-wei.chen@arm.com> <20220418090735.3940393-5-wei.chen@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 18 Apr 2022, Wei Chen wrote:
> In current code, when Xen is booting from EFI, it will delete
> all memory nodes in device tree. This would work well in current
> stage, because Xen can get memory map from EFI system table.
> However, EFI system table cannot completely replace memory nodes
> of device tree. EFI system table doesn't contain memory NUMA
> information. Xen depends on ACPI SRAT or device tree memory nodes
> to parse memory blocks' NUMA mapping. So in EFI + DTB boot, Xen
> doesn't have any method to get numa-node-id for memory blocks any
> more. This makes device tree based NUMA support become impossible
> for Xen in EFI + DTB boot.
> 
> So in this patch, we will keep memory nodes in device tree for
> NUMA code to parse memory numa-node-id later.
> 
> As a side effect, if we still parse boot memory information in
> early_scan_node, bootmem.info will calculate memory ranges in
> memory nodes twice. So we have to prevent early_scan_node to
> parse memory nodes in EFI boot.
> 
> Signed-off-by: Wei Chen <wei.chen@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> v1 -> v2:
> 1. Move this patch from later to early of this series.
> 2. Refine commit message.
> ---
>  xen/arch/arm/bootfdt.c      |  8 +++++++-
>  xen/arch/arm/efi/efi-boot.h | 25 -------------------------
>  2 files changed, 7 insertions(+), 26 deletions(-)
> 
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index e318ef9603..78e10c6ebc 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -11,6 +11,7 @@
>  #include <xen/lib.h>
>  #include <xen/kernel.h>
>  #include <xen/init.h>
> +#include <xen/efi.h>
>  #include <xen/device_tree.h>
>  #include <xen/libfdt/libfdt.h>
>  #include <xen/sort.h>
> @@ -370,7 +371,12 @@ static int __init early_scan_node(const void *fdt,
>  {
>      int rc = 0;
>  
> -    if ( device_tree_node_matches(fdt, node, "memory") )
> +    /*
> +     * If Xen has been booted via UEFI, the memory banks are
> +     * populated. So we should skip the parsing.
> +     */
> +    if ( !efi_enabled(EFI_BOOT) &&
> +         device_tree_node_matches(fdt, node, "memory") )
>          rc = process_memory_node(fdt, node, name, depth,
>                                   address_cells, size_cells, &bootinfo.mem);
>      else if ( depth == 1 && !dt_node_cmp(name, "reserved-memory") )
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index e452b687d8..59d93c24a1 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -231,33 +231,8 @@ EFI_STATUS __init fdt_add_uefi_nodes(EFI_SYSTEM_TABLE *sys_table,
>      int status;
>      u32 fdt_val32;
>      u64 fdt_val64;
> -    int prev;
>      int num_rsv;
>  
> -    /*
> -     * Delete any memory nodes present.  The EFI memory map is the only
> -     * memory description provided to Xen.
> -     */
> -    prev = 0;
> -    for (;;)
> -    {
> -        const char *type;
> -        int len;
> -
> -        node = fdt_next_node(fdt, prev, NULL);
> -        if ( node < 0 )
> -            break;
> -
> -        type = fdt_getprop(fdt, node, "device_type", &len);
> -        if ( type && strncmp(type, "memory", len) == 0 )
> -        {
> -            fdt_del_node(fdt, node);
> -            continue;
> -        }
> -
> -        prev = node;
> -    }
> -
>     /*
>      * Delete all memory reserve map entries. When booting via UEFI,
>      * kernel will use the UEFI memory map to find reserved regions.
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 00:37:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 00:37:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309719.526168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKov-0002FC-8t; Thu, 21 Apr 2022 00:37:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309719.526168; Thu, 21 Apr 2022 00:37:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhKov-0002F5-4o; Thu, 21 Apr 2022 00:37:17 +0000
Received: by outflank-mailman (input) for mailman id 309719;
 Thu, 21 Apr 2022 00:37:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhKou-0002Ez-7E
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 00:37:16 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2fba6094-c10b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 02:37:13 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 7EE4361B94;
 Thu, 21 Apr 2022 00:37:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49D9EC385A0;
 Thu, 21 Apr 2022 00:37:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fba6094-c10b-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650501431;
	bh=CoWODmOl9M5wMVTRWAcJI6GU0GPuMAlTEzkQj6mW1NI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EVMN0c6LyZo1wyHTjN0XvZDBPYNKlG9UuFGRwmS2Xo0+5mYQmtS6C0iIqfjQbQOwm
	 fAPX/3CaK8jVjxBSSvlc5Mp81ksorPNB/iiWJOOiZWqCpTIHZ/ePB+Ui4R26vWFEwb
	 6I0vreTf3Ojwh9XPzrmKiQYqrjGDM9ZjfgYftG+tG5NwAyLHqUBF4XXtaVh2FyEhDZ
	 bNnuunrksbjX4s8kbbtgBcVzXBV9sVmBZS4p2ZYI01ywoc6WLrzK5uDmoqU1WY6Qk9
	 nFE0sgc4fXO6cf4lZCqVTic1C1OJzkshli3JJy6lMXwply8Yg3NZr10XYYP2phzMF/
	 A/sZmdEjuI8Ow==
Date: Wed, 20 Apr 2022 17:37:11 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <wei.chen@arm.com>
cc: xen-devel@lists.xenproject.org, nd@arm.com, 
    Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON
 for phys_to_nid
In-Reply-To: <20220418090735.3940393-6-wei.chen@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204201736030.915916@ubuntu-linux-20-04-desktop>
References: <20220418090735.3940393-1-wei.chen@arm.com> <20220418090735.3940393-6-wei.chen@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 18 Apr 2022, Wei Chen wrote:
> VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This
> results in two lines of error-checking code in phys_to_nid
> that is not actually working and causing two compilation
> errors:
> 1. error: "MAX_NUMNODES" undeclared (first use in this function).
>    This is because in the common header file, "MAX_NUMNODES" is
>    defined after the common header file includes the ARCH header
>    file, where phys_to_nid has attempted to use "MAX_NUMNODES".
>    This error was resolved when we moved the definition of
>    "MAX_NUMNODES" to x86 ARCH header file. And we reserve the
>    "MAX_NUMNODES" definition in common header file through a
>    conditional compilation for some architectures that don't
>    need to define "MAX_NUMNODES" in their ARCH header files.
> 2. error: wrong type argument to unary exclamation mark.
>    This is because, the error-checking code contains !node_data[nid].
>    But node_data is a data structure variable, it's not a pointer.
> 
> So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
> enable the two lines of error-checking code. And fix the left
> compilation errors by replacing !node_data[nid] to
> !node_data[nid].node_spanned_pages.
> 
> Because when node_spanned_pages is 0, this node has no memory,
> numa_scan_node will print warning message for such kind of nodes:
> "Firmware Bug or mis-configured hardware?".
>
> Signed-off-by: Wei Chen <wei.chen@arm.com>

This patch looks OK to me but the x86 changes would benefit from a
review from one of the x86 maintainers


> ---
> v1 -> v2:
> 1. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid.
> 2. Adjust the conditional express for ASSERT.
> 3. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86.
> 4. Use conditional macro to gate MAX_NUMNODES for other architectures.
> ---
>  xen/arch/x86/include/asm/numa.h | 6 +++---
>  xen/include/xen/numa.h          | 2 ++
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
> index bada2c0bb9..1f268ce77d 100644
> --- a/xen/arch/x86/include/asm/numa.h
> +++ b/xen/arch/x86/include/asm/numa.h
> @@ -4,6 +4,7 @@
>  #include <xen/cpumask.h>
>  
>  #define NODES_SHIFT 6
> +#define MAX_NUMNODES    (1 << NODES_SHIFT)
>  
>  typedef u8 nodeid_t;
>  
> @@ -26,7 +27,6 @@ extern int compute_hash_shift(struct node *nodes, int numnodes,
>  extern nodeid_t pxm_to_node(unsigned int pxm);
>  
>  #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT))
> -#define VIRTUAL_BUG_ON(x) 
>  
>  extern void numa_add_cpu(int cpu);
>  extern void numa_init_array(void);
> @@ -62,9 +62,9 @@ extern struct node_data node_data[];
>  static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr)
>  { 
>  	nodeid_t nid;
> -	VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize);
> +	ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize);
>  	nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; 
> -	VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); 
> +	ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages);
>  	return nid; 
>  } 
>  
> diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
> index 7aef1a88dc..91b25c5617 100644
> --- a/xen/include/xen/numa.h
> +++ b/xen/include/xen/numa.h
> @@ -10,7 +10,9 @@
>  #define NUMA_NO_NODE     0xFF
>  #define NUMA_NO_DISTANCE 0xFF
>  
> +#ifndef MAX_NUMNODES
>  #define MAX_NUMNODES    (1 << NODES_SHIFT)
> +#endif
>  
>  #define vcpu_to_node(v) (cpu_to_node((v)->processor))
>  
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 02:31:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 02:31:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309726.526179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhMbb-0005sm-H3; Thu, 21 Apr 2022 02:31:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309726.526179; Thu, 21 Apr 2022 02:31:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhMbb-0005se-Bd; Thu, 21 Apr 2022 02:31:39 +0000
Received: by outflank-mailman (input) for mailman id 309726;
 Thu, 21 Apr 2022 02:31:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhMba-0005sT-CJ; Thu, 21 Apr 2022 02:31:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhMba-00056f-Ak; Thu, 21 Apr 2022 02:31:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhMbZ-0001Yf-Sc; Thu, 21 Apr 2022 02:31:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhMbZ-0004F8-QP; Thu, 21 Apr 2022 02:31:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bF2AWlpwbzTLOGicDXAV02XkMFIQ7GFG8b6x4K5QEA4=; b=S+5fNxoQ4AzS4Y/ErkY5SmhDOn
	vt64w9/7OkGOjBGt+/WMC9aknkwpS7xz8GMZJuIL61Vn2Qz8EqbH+VZaQSCjBb7awCAvmpcGcoetr
	GtJhGfJ2/gad/DLpmUWTgtx7iAKirhoskPBbuJft69hATPRai3gRBGh6rRUbu4ejYtfQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169578-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169578: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=6d2baf9dfbffe43019932c2771cd7d39697d4b11
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 02:31:37 +0000

flight 169578 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169578/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 6d2baf9dfbffe43019932c2771cd7d39697d4b11
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  526 attempts
Testing same since   169571  2022-04-20 19:40:26 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5520 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 02:57:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 02:57:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309735.526189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhN04-0000YA-73; Thu, 21 Apr 2022 02:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309735.526189; Thu, 21 Apr 2022 02:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhN04-0000Y3-4I; Thu, 21 Apr 2022 02:56:56 +0000
Received: by outflank-mailman (input) for mailman id 309735;
 Thu, 21 Apr 2022 02:56:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhN03-0000Xt-6u; Thu, 21 Apr 2022 02:56:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhN03-0005Vm-53; Thu, 21 Apr 2022 02:56:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhN02-0003If-O5; Thu, 21 Apr 2022 02:56:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhN02-0002AV-Nc; Thu, 21 Apr 2022 02:56:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=T96qr3CxWzwq2Ec/zF1Rvs6C4NGF86peeg3LOGJphE0=; b=kHre9xRwmeWlnMMHBKMfhJeLfc
	m2QVlXHjzPwFKeBo2w4TBAiFZ3oy30feLSIj27ToKLlp/oYjCSsu4AISuAKJzFPZiagRxZToMnqEA
	d3TIEkJ8ww1T+XF7JfVNj0dThBFtCyFH7UClqXbs/Dg6Wrn2a9k3w1Sj5DjImzgpGSz8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169572-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169572: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b253435746d9a4a701b5f09211b9c14d3370d0da
X-Osstest-Versions-That:
    linux=559089e0a93d44280ec3ab478830af319c56dbe3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 02:56:54 +0000

flight 169572 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169572/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169560
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169560
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169560
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169560
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169560
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169560
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169560
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169560
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                b253435746d9a4a701b5f09211b9c14d3370d0da
baseline version:
 linux                559089e0a93d44280ec3ab478830af319c56dbe3

Last test of basis   169560  2022-04-20 06:47:19 Z    0 days
Testing same since   169572  2022-04-20 20:13:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Duoming Zhou <duoming@zju.edu.cn>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Guo Ren <guoren@kernel.org>
  Guo Ren <guoren@linux.alibaba.com>
  Hans de Goede <hdegoede@redhat.com>
  Hongyu Jin <hongyu.jin@unisoc.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Max Filippov <jcmvbkbc@gmail.com>
  Mikulas Patocka <mpatocka@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   559089e0a93d..b253435746d9  b253435746d9a4a701b5f09211b9c14d3370d0da -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 03:33:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 03:33:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309745.526201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhNZF-0005ZZ-2p; Thu, 21 Apr 2022 03:33:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309745.526201; Thu, 21 Apr 2022 03:33:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhNZE-0005ZS-Uw; Thu, 21 Apr 2022 03:33:16 +0000
Received: by outflank-mailman (input) for mailman id 309745;
 Thu, 21 Apr 2022 03:33:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhNZD-0005ZI-Fs; Thu, 21 Apr 2022 03:33:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhNZD-00067a-EN; Thu, 21 Apr 2022 03:33:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhNZC-0004np-KH; Thu, 21 Apr 2022 03:33:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhNZC-0002dW-Jq; Thu, 21 Apr 2022 03:33:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+g9mIjWlCJt7PjpVn9sOSwvts7iFYbmUUCI7bpifGdI=; b=W0bl2P0kPgp9A4Z6wHfD/CrBXs
	egLXiqE1CZ2xQ/PyBhIh4ILJw80f2kfiDTBa6oLA+foTixVS5Sv8ylQtWc7PbjlRDBWNvS2/wNciB
	ajIhskWvC7N9nkHT6kRGGjrMTf6NDxxsoHmKwBmZ9ix/IkDWDvX9eYoZqMWiW+RCvUkc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169579-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169579: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=892787fed516a147f3edfd2bb4fa0cf67c599be6
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 03:33:14 +0000

flight 169579 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169579/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 892787fed516a147f3edfd2bb4fa0cf67c599be6
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  527 attempts
Testing same since   169579  2022-04-21 02:33:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5553 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 05:20:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 05:20:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309755.526212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhPF9-0001fJ-Ou; Thu, 21 Apr 2022 05:20:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309755.526212; Thu, 21 Apr 2022 05:20:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhPF9-0001fC-LU; Thu, 21 Apr 2022 05:20:39 +0000
Received: by outflank-mailman (input) for mailman id 309755;
 Thu, 21 Apr 2022 05:20:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhPF8-0001f2-9r; Thu, 21 Apr 2022 05:20:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhPF8-0008Ot-7P; Thu, 21 Apr 2022 05:20:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhPF7-0002qc-P5; Thu, 21 Apr 2022 05:20:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhPF7-0005Ye-Od; Thu, 21 Apr 2022 05:20:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tYi4fSyUMRS9ZrF8dZ7p+577KRu2hLfY5CAKU+EdFUs=; b=ynwDoVzcH9wUFwq1X+Kb/C8K5a
	IBuJkU7VbA2nx3RmbjgECm79jbHHBfwF4YKKx4csLi0u+r/wTMfTgjtsDt/cME1whIbasdxhCV6U2
	Qu8vzAf/CU3Bk/3uto6Ql3XSjcmjtCmJMXWf1FZlb73N7NwLovGo2fnlUPm9jhZtJ4Jc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169580-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169580: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=892787fed516a147f3edfd2bb4fa0cf67c599be6
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 05:20:37 +0000

flight 169580 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169580/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 892787fed516a147f3edfd2bb4fa0cf67c599be6
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  528 attempts
Testing same since   169579  2022-04-21 02:33:55 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5553 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 06:01:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 06:01:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309763.526223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhPsd-0006kZ-Uh; Thu, 21 Apr 2022 06:01:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309763.526223; Thu, 21 Apr 2022 06:01:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhPsd-0006kS-RS; Thu, 21 Apr 2022 06:01:27 +0000
Received: by outflank-mailman (input) for mailman id 309763;
 Thu, 21 Apr 2022 06:01:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhPsc-0006kI-BS; Thu, 21 Apr 2022 06:01:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhPsc-0000jd-9h; Thu, 21 Apr 2022 06:01:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhPsc-00042G-1C; Thu, 21 Apr 2022 06:01:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhPsc-0004IC-0l; Thu, 21 Apr 2022 06:01:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iSlWND/j6hr9UiKu0/7TOf8hzgFFxYcb+p8kTflBlBA=; b=ljBGi4j8Q5Ru16xch/cQHrBmlR
	7hUmOa/ZUGgf0W3lJLurQ9+puttD8Qtrj+P6yspMQSJV+vyI5X7kPUoWOJOy3UyAKBNDKhY3ZaZqz
	+LaCmakBeq2RIwhL284qSCLRqo2LDg22tG5OyFMIE1c5HfTpQaowC5FnTAAypC/gMX6A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169582-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169582: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 06:01:26 +0000

flight 169582 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169582/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  529 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 06:16:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 06:16:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309774.526234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQ7D-0000JF-Bw; Thu, 21 Apr 2022 06:16:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309774.526234; Thu, 21 Apr 2022 06:16:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQ7D-0000J8-90; Thu, 21 Apr 2022 06:16:31 +0000
Received: by outflank-mailman (input) for mailman id 309774;
 Thu, 21 Apr 2022 06:16:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhQ7B-0000Il-IF; Thu, 21 Apr 2022 06:16:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhQ7B-0000zp-CM; Thu, 21 Apr 2022 06:16:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhQ7A-0004m1-SY; Thu, 21 Apr 2022 06:16:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhQ7A-0000MD-S9; Thu, 21 Apr 2022 06:16:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8LH/bZVPAOMDzvJtRBbJ5JswdvPk/35m6IsEYMUYt8E=; b=GmgNq7EA/oaORhemK4HBDS4FKL
	kt13NldMvtqzMU+8aldYbZkSMBLU7ycmYYlZVc/aLzJ9LUTPr+e9KqVijHg8WLsOdLCIQbsRTsAUr
	tdao7Ozc0CynPvVo3FxNmYvASa+vn3WLgg25+0xsHNegPh29z8+KBFXVOrwxHlQ454+g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169573-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169573: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=2d20a57453f6a206938cbbf77bed0b378c806c1f
X-Osstest-Versions-That:
    qemuu=1be5a765c08cee3a9587c8a8d3fc2ea247b13f9c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 06:16:28 +0000

flight 169573 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169573/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169562
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169562
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169562
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169562
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169562
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169562
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169562
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169562
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                2d20a57453f6a206938cbbf77bed0b378c806c1f
baseline version:
 qemuu                1be5a765c08cee3a9587c8a8d3fc2ea247b13f9c

Last test of basis   169562  2022-04-20 07:22:44 Z    0 days
Testing same since   169573  2022-04-20 20:38:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ahmed Abouzied <email@aabouzied.com>
  Alex Bennée <alex.bennee@linaro.org>
  Cornelia Huck <cohuck@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Hanna Reitz <hreitz@redhat.com>
  Laurent Vivier <laurent@vivier.eu>
  Lucas Ramage <lucas.ramage@infinite-omicron.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   1be5a765c0..2d20a57453  2d20a57453f6a206938cbbf77bed0b378c806c1f -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 06:25:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 06:25:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309783.526245 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQFR-00021a-9D; Thu, 21 Apr 2022 06:25:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309783.526245; Thu, 21 Apr 2022 06:25:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQFR-00021T-6B; Thu, 21 Apr 2022 06:25:01 +0000
Received: by outflank-mailman (input) for mailman id 309783;
 Thu, 21 Apr 2022 06:24:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MX63=U7=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nhQFP-00021N-JL
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 06:24:59 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id c3657932-c13b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 08:24:57 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 55A011477;
 Wed, 20 Apr 2022 23:24:56 -0700 (PDT)
Received: from [10.57.11.77] (unknown [10.57.11.77])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 792613F73B;
 Wed, 20 Apr 2022 23:24:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3657932-c13b-11ec-8fbf-03012f2f19d4
Message-ID: <404e095e-6645-6f00-40e1-64574a6d2c3e@arm.com>
Date: Thu, 21 Apr 2022 08:24:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v5 2/2] gitlab-ci: add an ARM32 qemu-based smoke test
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, cardoe@cardoe.com, wl@xen.org,
 andrew.cooper3@citrix.com, anthony.perard@citrix.com,
 bertrand.marquis@arm.com, Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop>
 <20220416001701.1301324-2-sstabellini@kernel.org>
 <6e01871e-9e47-2d92-617e-952dde2df3b2@arm.com>
 <alpine.DEB.2.22.394.2204201630330.915916@ubuntu-linux-20-04-desktop>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <alpine.DEB.2.22.394.2204201630330.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 21.04.2022 01:31, Stefano Stabellini wrote:
> 
> Oops, yes I did. Well spotted. Just sending this one update here.
> 
> 
> ---
> gitlab-ci: add an ARM32 qemu-based smoke test
> 
> Add a minimal ARM32 smoke test based on qemu-system-arm, as provided by
> the test-artifacts qemu container. The minimal test simply boots Xen
> (built from previous build stages) and Dom0.
> 
> The test needs a working kernel and minimal initrd for dom0. Instead of
> building our own kernel and initrd, which would mean maintaining one or
> two more builting scripts under automation/, we borrow a kernel and
> initrd from distros.
> 
> For the kernel we pick the Debian Bullseye kernel, which has everything
> we need already built-in. However, we cannot use the Debian Bullseye
> initrd because it is 22MB and the large size causes QEMU to core dump.
> 
> Instead, use the tiny busybox-based rootfs provided by Alpine Linux,
> which is really minimal: just 2.5MB. Note that we cannot use the Alpine
> Linux kernel because that doesn't boot on Xen.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 06:30:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 06:30:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309792.526255 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQKF-0002ft-S3; Thu, 21 Apr 2022 06:29:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309792.526255; Thu, 21 Apr 2022 06:29:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQKF-0002fm-PD; Thu, 21 Apr 2022 06:29:59 +0000
Received: by outflank-mailman (input) for mailman id 309792;
 Thu, 21 Apr 2022 06:29:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhQKE-0002fc-Sr; Thu, 21 Apr 2022 06:29:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhQKE-0001Dw-Ru; Thu, 21 Apr 2022 06:29:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhQKE-0005Kz-Es; Thu, 21 Apr 2022 06:29:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhQKE-0006XF-ES; Thu, 21 Apr 2022 06:29:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DgIpaUXaD2M8eC9CkU4bz9Rw9sFhNkBHGZTpuj7noXE=; b=N4NWGYPbqlH/qNEKDTdCdBwTrN
	5GhorKw+1nDMk0usAVli1Cm2tzkFLtRhtrP2gVKj2tgGOSR3TmleoqJarQADU0m17S6nTLVum86z4
	m8MM4W87Mq8kl9XRdcEvbG7dFI/4ZMq5LT9aaP5htPH0Mopq26zJnBZYS/qQwwVyc+KE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169583-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169583: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 06:29:58 +0000

flight 169583 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169583/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  530 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 07:01:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 07:01:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309800.526267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQoH-0007NM-6I; Thu, 21 Apr 2022 07:01:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309800.526267; Thu, 21 Apr 2022 07:01:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQoH-0007NF-2C; Thu, 21 Apr 2022 07:01:01 +0000
Received: by outflank-mailman (input) for mailman id 309800;
 Thu, 21 Apr 2022 07:00:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dwl+=U7=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nhQoF-0007N9-7M
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 07:00:59 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20623.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::623])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id caf2ac45-c140-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 09:00:57 +0200 (CEST)
Received: from DB6PR0202CA0001.eurprd02.prod.outlook.com (2603:10a6:4:29::11)
 by VI1PR08MB4333.eurprd08.prod.outlook.com (2603:10a6:803:101::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 07:00:53 +0000
Received: from DB5EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:29:cafe::bc) by DB6PR0202CA0001.outlook.office365.com
 (2603:10a6:4:29::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Thu, 21 Apr 2022 07:00:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT030.mail.protection.outlook.com (10.152.20.144) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 07:00:53 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Thu, 21 Apr 2022 07:00:53 +0000
Received: from 91b6710f0ab5.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E85C9981-ECFE-4F70-89E5-059EED353AF1.1; 
 Thu, 21 Apr 2022 07:00:42 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 91b6710f0ab5.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Apr 2022 07:00:42 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by AM0PR08MB5075.eurprd08.prod.outlook.com (2603:10a6:208:15b::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 07:00:39 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%9]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 07:00:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: caf2ac45-c140-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Znk8eN52uG/uV4s7QJ837O3y9WTc5AsZ1ioifoeZcH0=;
 b=TgdCWYP05guoYyu0gOQpT/X4CJhexfmrNF/90XVHV+IW+Rr+ISEOJCJ2rfkFWjsKqsfbH1ZTK9SUPRDLpxKnYcMIAntAFmOH95wGUjY5ll6Eluwa90xvOTu6mh5cmBu6SHKgjK+2zO/jBz+B7AGmnDGGPa3ONKzMXQtQy6bQaas=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mDERpl5q7zIgWDDS3HAkm+RgQ0n0rs9leAb7vp14ja+SVSfkX394efwH2VA1Cd9osVtE5Qe84OmpnvlhcCiz1Mo/5GCPPAA2H5KStEug4KnI81N1se3sbhdq+wEhliEN428gQdkr3gVEHbvzRDI28pLvc3D3ACHM1Jw9ROzmUhKeKJ8WR73WeY5dHbjZZahDmt1cp+y5etqHeO1Ho/sJ61DD58QUcmSEJyG6VzwGHGPfTBE+md9vVNU2v5G055Wff1SlMfTBV9yUmVp1pmzYvmOPYz5U5xhk3o/JTGjNWsrakzgdJz8S5xo0HXa2tA0UlGMKGYt6C0T9zIUsFV9ShA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Znk8eN52uG/uV4s7QJ837O3y9WTc5AsZ1ioifoeZcH0=;
 b=XgC8hviRkBXYQySrBg9h36jmwW4/ic3ewkeNY8SJlz7ckvPZo4jw4eqWj6XNSF/i0zs5ygwTYrIKN4/fATWLZIW1O4Ld1uC8Z6+S4R4Bq+GGCxi/wIUJm/bwoZaW7sklfp4rOLIeIRx2+bpdkeh7769AMOlqcj3uttQ44xGN5u/E1H1W4pyzCGuB9pEqMkutTBt1BZzWLYJYCtsjZSnMyaoPSHb+Rba4xx1q2/4boDysqA3FCmjsItXnS4iFnPwepLSfKZiCdjHS0oTX2K25xdgMgACrS9gwPQlBQuRpzAsR8cliku/nFQu0PX9juthZ/4zFC6KsvRO18cOYJzfTlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Znk8eN52uG/uV4s7QJ837O3y9WTc5AsZ1ioifoeZcH0=;
 b=TgdCWYP05guoYyu0gOQpT/X4CJhexfmrNF/90XVHV+IW+Rr+ISEOJCJ2rfkFWjsKqsfbH1ZTK9SUPRDLpxKnYcMIAntAFmOH95wGUjY5ll6Eluwa90xvOTu6mh5cmBu6SHKgjK+2zO/jBz+B7AGmnDGGPa3ONKzMXQtQy6bQaas=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: nd <nd@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v1 08/13] xen/arm: destroy static shared memory when
 de-construct domain
Thread-Topic: [PATCH v1 08/13] xen/arm: destroy static shared memory when
 de-construct domain
Thread-Index: AQHYNQ8XP5NnJaO3/U2NKPTcSWC8l6znfYSAgBKyp0A=
Date: Thu, 21 Apr 2022 07:00:37 +0000
Message-ID:
 <DU2PR08MB7325D83D85E9D543A400D677F7F49@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220311061123.1883189-1-Penny.Zheng@arm.com>
 <20220311061123.1883189-9-Penny.Zheng@arm.com>
 <7c6a3af7-6052-aab8-829c-bc2c2a5db341@xen.org>
In-Reply-To: <7c6a3af7-6052-aab8-829c-bc2c2a5db341@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 0A5C5D048BF6BF4CA0E73135AD3E967A.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: dd4a4786-2206-4830-f48d-08da2364ad1a
x-ms-traffictypediagnostic:
	AM0PR08MB5075:EE_|DB5EUR03FT030:EE_|VI1PR08MB4333:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB43330F9174CDB2ACF54772BBF7F49@VI1PR08MB4333.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DAxr2N03WS6UpJoFb4CMe3Ie5N7JCIIamRhbC9BRXa8uHuDY0Y57stI2RGaZ7Zl7C4n6sLVzHR0JPY+IWppmdHlQS+TozVL+orBeTxZk0Ui2IYwWghz9InR+5o1cldOB2LR0fAEgbnZ5rQeP1aemRDExKlAS+rZ08bMt7EkzVhZdJI8uJk3TM4mYFlYpb028dkqDOChQ1U5DmK47BiwrrRvOoR03DOSndO5ifP/H4+rteg6xWY5+1FudrO0ySJKEq6MHcixs9RFzZouzeseQTgMlESmBO2e2K1/+7pygFtzRf4Id9DJWRTLrwse14hmluPCPmlUnMsDMXfM8LI/sfLB5ABlmafkmtgTO+WRMDL4NToUHT8RScu6ahlR/9O8YBzzWtor9XaDKgH0lpnKWlBPDDkygtv5fiPuu5t71Etv1o3LPWlyE6b8fRo9G/kB4Uf7UmwIr0ZKd+6TYHFoQl7c7S11ruR1LeVyHwpdz6kVtlKuiHqWY08c0sg6acJUPff0110q/GkKrn/3sFqZi5ZWMcLCFI2erC5oMFqgCQek1qQTPK7yHR3OWjySSvAajO2HTn/7zZec2DlmJwkeves8QWoE+O1yBQSFz+bBiTNGxb97k2i6MPkkDJ91KYosCtR481H+uNpxJTYJ855xqgxwaLq6Kw64iD0oUzRT60jS8Wzis7dqE1E28Zz9g1soLuGdQKw86Gr1KIxIIQFSUWw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(64756008)(76116006)(53546011)(66556008)(26005)(33656002)(4326008)(186003)(7696005)(66946007)(71200400001)(66476007)(8676002)(66446008)(9686003)(6506007)(2906002)(5660300002)(52536014)(508600001)(55016003)(38070700005)(38100700002)(8936002)(316002)(54906003)(110136005)(122000001)(86362001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5075
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f53e29ea-a09d-42d1-afb1-08da2364a3f6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bDHCP+YIIgCSU/jXAc1ZKwn2+6+ru1BkG0HeVamP6S8GjOq8SRrngOa8K7d1aBJDwYYreNJAnMBnJqwNOvGHWma17BNjhOKbeAuLPJoq1zMWJgs73Wzn7zlKDeOjj6DR7msa4Pz8WUW3EEQrmU8QByct5VVpQeDZuchN56n9+1E7aeRXMBCq4ICbICTs/Ys5OSSAxiY0vwpdtTzrzyENmm8OnRCOaoWMV6U3WODeJ9sLW2a4nJn4OJfNGgHUlE8EA3j4a/JPREvHVwmViXYiOwr6vFjl+oNkSed1ys820Gqk4fiR+RwPqmUcJ9GUKqDFeFmfkYMxOSImBVEAPppVTVbdeFXwjJcuKe0RCG1gWCfyEF/Xf13Rf9Zv11xBlxieJ7SPR+ncMkFB3JNOfZH5sQ+1a+U+AM9UsxOtxTp/JqxQYEcffUEgRFJ272SSWPJ1qYTFpFCXP/GaQYPIDtke5b7LN1JuFIcUHvNZsFSN45WhMgOf4a4i7eOcPkfntcReFoy+Tlr7QD4RTT8rxvvNRSmwNKFKJDdEeNAdERoauWhpos0A8nMBdupLcSXpFo+GMdnRXWTjkFoaSIxXkCuaHOFDB7ZeJonUuAkDgCXGiCmZ14eyYsOpFQK7pTiN2wElQxXYmdG+FZmrPqaX6ry1jrCLXH9eAx/GsBGwRFA4sJMdJjVj/d9AJPNKX3KM246h
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(33656002)(186003)(336012)(36860700001)(7696005)(47076005)(2906002)(9686003)(26005)(40460700003)(55016003)(83380400001)(82310400005)(107886003)(52536014)(5660300002)(356005)(86362001)(8936002)(70586007)(70206006)(8676002)(4326008)(81166007)(110136005)(508600001)(53546011)(316002)(54906003)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 07:00:53.4273
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dd4a4786-2206-4830-f48d-08da2364ad1a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4333

SGksIGp1bGllbg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IFNhdHVyZGF5LCBBcHJpbCA5LCAyMDIy
IDU6MjYgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRl
dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBuZCA8bmRAYXJtLmNvbT47IFN0ZWZhbm8g
U3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kDQo+IE1hcnF1aXMg
PEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlt
eXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MSAwOC8xM10geGVu
L2FybTogZGVzdHJveSBzdGF0aWMgc2hhcmVkIG1lbW9yeSB3aGVuDQo+IGRlLWNvbnN0cnVjdCBk
b21haW4NCj4gDQo+IEhpIFBlbm55LA0KPiANCj4gT24gMTEvMDMvMjAyMiAwNjoxMSwgUGVubnkg
Wmhlbmcgd3JvdGU6DQo+ID4gRnJvbTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+
DQo+ID4NCj4gPiBUaGlzIGNvbW1pdCBpbnRyb2R1Y2VzIGEgbmV3IGhlbHBlciBkZXN0cm95X2Rv
bWFpbl9zaG0gdG8gZGVzdHJveQ0KPiA+IHN0YXRpYyBzaGFyZWQgbWVtb3J5IGF0IGRvbWFpbiBk
ZS1jb25zdHJ1Y3Rpb24uDQo+ID4NCj4gPiBUaGlzIHBhdGNoIG9ubHkgY29uc2lkZXJzIHRoZSBz
Y2VuYXJpbyB3aGVyZSB0aGUgb3duZXIgZG9tYWluIGlzIHRoZQ0KPiA+IGRlZmF1bHQgZG9tX3No
YXJlZCwgZm9yIHVzZXItZGVmaW5lZCBvd25lciBkb21haW4sIGl0IHdpbGwgYmUgY292ZXJlZA0K
PiA+IGluIHRoZSBmb2xsb3dpbmcgcGF0Y2hlcy4NCj4gPg0KPiA+IFNpbmNlIGFsbCBkb21haW5z
IGFyZSBib3Jyb3dlciBkb21haW5zLCB3ZSBjb3VsZCBzaW1wbHkgcmVtb3ZlIGd1ZXN0DQo+ID4g
UDJNIGZvcmVpZ24gbWFwcGluZyBvZiBzdGF0aWNhbGx5IHNoYXJlZCBtZW1vcnkgcmVnaW9uIGFu
ZCBkcm9wIHRoZQ0KPiA+IHJlZmVyZW5jZSBhZGRlZCBhdCBndWVzdF9waHlzbWFwX2FkZF9zaG0u
DQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQZW5ueSBaaGVuZyA8cGVubnkuemhlbmdAYXJtLmNv
bT4NCj4gPiAtLS0NCj4gPiAgIHhlbi9hcmNoL2FybS9kb21haW4uYyB8IDQ4DQo+ICsrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgIDEgZmlsZSBjaGFuZ2Vk
LCA0OCBpbnNlcnRpb25zKCspDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2Rv
bWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGluZGV4DQo+ID4gMWZmMWRmNWQzZi4uZjBi
ZmQ2N2ZlNSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4gPiArKysg
Yi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4gPiBAQCAtMzQsNiArMzQsNyBAQA0KPiA+ICAgI2lu
Y2x1ZGUgPGFzbS9wbGF0Zm9ybS5oPg0KPiA+ICAgI2luY2x1ZGUgPGFzbS9wcm9jaW5mby5oPg0K
PiA+ICAgI2luY2x1ZGUgPGFzbS9yZWdzLmg+DQo+ID4gKyNpbmNsdWRlIDxhc20vc2V0dXAuaD4N
Cj4gPiAgICNpbmNsdWRlIDxhc20vdGVlL3RlZS5oPg0KPiA+ICAgI2luY2x1ZGUgPGFzbS92ZnAu
aD4NCj4gPiAgICNpbmNsdWRlIDxhc20vdmdpYy5oPg0KPiA+IEBAIC05OTMsNiArOTk0LDQ4IEBA
IHN0YXRpYyBpbnQgcmVsaW5xdWlzaF9tZW1vcnkoc3RydWN0IGRvbWFpbiAqZCwNCj4gc3RydWN0
IHBhZ2VfbGlzdF9oZWFkICpsaXN0KQ0KPiA+ICAgICAgIHJldHVybiByZXQ7DQo+ID4gICB9DQo+
ID4NCj4gPiArI2lmZGVmIENPTkZJR19TVEFUSUNfU0hNDQo+ID4gK3N0YXRpYyBpbnQgZG9tYWlu
X2Rlc3Ryb3lfc2htKHN0cnVjdCBkb21haW4gKmQpIHsNCj4gPiArICAgIGludCByZXQgPSAwOw0K
PiA+ICsgICAgdW5zaWduZWQgbG9uZyBpID0gMFVMLCBqOw0KPiA+ICsNCj4gPiArICAgIGlmICgg
ZC0+YXJjaC5zaG1fbWVtID09IE5VTEwgKQ0KPiA+ICsgICAgICAgIHJldHVybiByZXQ7DQo+IA0K
PiBZb3UgYWxyZWFkeSByZXR1cm4gdGhlIHZhbHVlIGhlcmUuIFNvLi4uDQo+IA0KPiA+ICsgICAg
ZWxzZQ0KPiANCj4gLi4uIHRoZSBlbHNlIGlzIHBvaW50bGVzcy4NCj4gDQo+ID4gKyAgICB7DQo+
ID4gKyAgICAgICAgZm9yICggOyBpIDwgZC0+YXJjaC5zaG1fbWVtLT5ucl9iYW5rczsgaSsrICkN
Cj4gPiArICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbnJfZ2ZucyA9
IFBGTl9ET1dOKGQtPmFyY2guc2htX21lbS0NCj4gPmJhbmtbaV0uc2l6ZSk7DQo+ID4gKyAgICAg
ICAgICAgIGdmbl90IGdmbiA9IGdhZGRyX3RvX2dmbihkLT5hcmNoLnNobV9tZW0tPmJhbmtbaV0u
c3RhcnQpOw0KPiA+ICsNCj4gPiArICAgICAgICAgICAgZm9yICggaiA9IDA7IGogPCBucl9nZm5z
OyBqKysgKQ0KPiA+ICsgICAgICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgICAgICBtZm5fdCBt
Zm47DQo+ID4gKw0KPiA+ICsgICAgICAgICAgICAgICAgbWZuID0gZ2ZuX3RvX21mbihkLCBnZm5f
YWRkKGdmbiwgaikpOw0KPiANCj4gQSBkb21haW4gaXMgYWxsb3dlZCB0byBtb2RpZnkgaXRzIFAy
TS4gU28gdGhlcmUgYXJlIG5vIGd1YXJhbnRlZSB0aGF0IHRoZQ0KPiBHRk4gd2lsbCBzdGlsbCBw
b2ludCB0byB0aGUgc2hhcmVkIG1lbW9yeS4gVGhpcyB3aWxsIGFsbG93IHRoZSBndWVzdC4uLg0K
PiANCj4gPiArICAgICAgICAgICAgICAgIGlmICggIW1mbl92YWxpZChtZm4pICkNCj4gPiArICAg
ICAgICAgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19F
UlIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiRG9tYWluICVwZCBwYWdlIG51
bWJlciAlbHggaW52YWxpZC5cbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBk
LCBnZm5feChnZm4pICsgaSk7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5W
QUw7DQo+IA0KPiAuLi4gdG8gYWN0aXZlbHkgcHJldmVudCBkZXN0cnVjdGlvbi4NCj4gDQo+ID4g
KyAgICAgICAgICAgICAgICB9DQo+IA0KPiANCj4gPiArDQo+ID4gKyAgICAgICAgICAgICAgICBy
ZXQgPSBndWVzdF9waHlzbWFwX3JlbW92ZV9wYWdlKGQsIGdmbl9hZGQoZ2ZuLCBqKSwgbWZuLCAw
KTsNCj4gPiArICAgICAgICAgICAgICAgIGlmICggcmV0ICkNCj4gPiArICAgICAgICAgICAgICAg
ICAgICByZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAgICAgICAgICAgICAgIC8qIERyb3AgdGhl
IHJlZmVyZW5jZS4gKi8NCj4gPiArICAgICAgICAgICAgICAgIHB1dF9wYWdlKG1mbl90b19wYWdl
KG1mbikpOw0KPiANCj4gZ3Vlc3RfcGh5c21hcF9yZW1vdmVfcGFnZSgpIHdpbGwgYWxyZWFkeSBk
cm9wIHRoZSByZWZlcmVuY2UgdGFrZW4gZm9yIHRoZQ0KPiBmb3JlaWduIG1hcHBpbmcuIEkgY291
bGRuJ3QgZmluZCBhbnkgb3RoZXIgcmVmZXJlbmNlIHRha2VuLCB3aGF0IGlzIHRoZQ0KPiBwdXRf
cGFnZSgpIGZvcj8NCj4gDQo+IEFsc28sIGFzIHBlciBhYm92ZSB3ZSBkb24ndCBrbm93IHdoZXRo
ZXIgdGhpcyBpcyBhIHBhZ2UgZnJvbSB0aGUgc2hhcmVkIHBhZ2UuDQo+IFNvIHdlIGNhbid0IGJs
aW5kbHkgY2FsbCBwdXRfcGFnZSgpLg0KPiANCj4gSG93ZXZlciwgSSBkb24ndCB0aGluayB3ZSBu
ZWVkIGFueSBzcGVjaWZpYyBjb2RlIGhlcmUuIFdlIGNhbiByZWx5IG9uDQo+IHJlbGlucXVpc2hf
cDJtX21hcHBpbmdzKCkgdG8gZHJvcCBhbnkgcmVmZXJlbmNlLiBJZiB0aGVyZSBpcyBhbiBleHRy
YSBvbmUgZm9yDQo+IHNoYXJlZCBtYXBwaW5ncywgdGhlbiB3ZSBzaG91bGQgdXBkYXRlIHAybV9w
dXRfbDNfcGFnZSgpLg0KPiANCg0KVHJ1ZSwgdHJ1ZS4gVGhhbmtzIGZvciBwb2ludGluZyB0aGlz
IG91dCENCkluIHAybV9wdXRfbDNfcGFnZSwgaXQgaGFzIGFscmVhZHkgY2FsbGVkIHB1dF9wYWdl
KCkgZm9yIGZvcmVpZ24gbWFwcGluZywNCmRlZmluaXRlbHkgbm8gZXh0cmEgb25lIGhlcmUhDQoN
Cj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo=


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 07:01:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 07:01:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309804.526278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQp4-00089P-FL; Thu, 21 Apr 2022 07:01:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309804.526278; Thu, 21 Apr 2022 07:01:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQp4-00089I-CC; Thu, 21 Apr 2022 07:01:50 +0000
Received: by outflank-mailman (input) for mailman id 309804;
 Thu, 21 Apr 2022 07:01:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/n2O=U7=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nhQp3-0007N9-2B
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 07:01:49 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20612.outbound.protection.outlook.com
 [2a01:111:f400:7d00::612])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e94f76c4-c140-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 09:01:48 +0200 (CEST)
Received: from AM6PR10CA0049.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::26)
 by PAXPR08MB7036.eurprd08.prod.outlook.com (2603:10a6:102:208::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 07:01:41 +0000
Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:80::4) by AM6PR10CA0049.outlook.office365.com
 (2603:10a6:209:80::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Thu, 21 Apr 2022 07:01:41 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 07:01:40 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Thu, 21 Apr 2022 07:01:40 +0000
Received: from f4556d51b140.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5573A7CB-E376-4BDB-A29C-5CD2DEDCFE2D.1; 
 Thu, 21 Apr 2022 07:01:33 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4556d51b140.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Apr 2022 07:01:33 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AS4PR08MB8071.eurprd08.prod.outlook.com (2603:10a6:20b:58a::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Thu, 21 Apr
 2022 07:01:31 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Thu, 21 Apr 2022
 07:01:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e94f76c4-c140-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4xIcU96ZbrD7FqvIuy4Xpm+ZwhPyAu1JGyRqhzRBv9s=;
 b=bDI21dRQ+kFaIKgaez0M77ZqEa3e+2Zc8xpKC3eZ72z/UrAVB2IAOpRUymL+biiXFER11FKLw8yQtaaWzP+6jhiz4YW3wjpc0ITp/aZQhISkdp55fMHB666wDA4WIDIi4/d2poCkq9gX/GTqjjqph/mB7LQXAK4Q2tWyC1iYyjw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 04da220d14e6d16f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Mu1D85Cl6qaURPK5Q8vq6R/0QfziuqrW5h9DuIHBlpuvQSHeIG6WYrWjzoEm4dP+GeG0/v5OgGJUZqEZEIQuqB5/q9WStJfS/i4atnBgsO0Ok1LBBplRJ+XMy1F9oJW7qDNMU+mk7/ABrs9RE2nO0nmaXqn0keKZpvWB2bbKPZxXwPCybseUaTlWU4pdQoQB7CKY2Sge7tw/BhaQb6fMyreu1qFO8ucG8g4c/gwxATcsE1n91vGofs/MJGe46CtC2TmvMwG5bo5KetP2CfNEJc9Oi2NtP3+lETgAwBAV8icBKrgJY0A4c/xTrYkJ1uDoLByhZdMcFfS9uunI6IzNVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4xIcU96ZbrD7FqvIuy4Xpm+ZwhPyAu1JGyRqhzRBv9s=;
 b=NbqChWjWnts/Y6DdWPkkQElroN6LfDW+hySGaQDFlk6xyqCwDSDOtoFUIeYE6suGQpLPSt6NNv8QuxeBaBlGQYOtiInbbSyl9JbEasdjN2U8yqEze7xN23jvItujM9OK0NueYn9x8AnMDln3CDnIyJrMjyfv8fIrChOnOeUO2nwSQLitKIHFq4grkAiuAXj3ZmeXO1JvuP6daxilpVdFPz38j+OaFNMRKkNY6BR7QurDHyW+k0UvKyBD98clVmJsbFrLRBEYeHM0hnkmhq8jXH4hoYTAxGU+kzHdjDQfz4clwA0x8a8bWg0EpFUV//GS7RoEn91ua96LHUtWOznFKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4xIcU96ZbrD7FqvIuy4Xpm+ZwhPyAu1JGyRqhzRBv9s=;
 b=bDI21dRQ+kFaIKgaez0M77ZqEa3e+2Zc8xpKC3eZ72z/UrAVB2IAOpRUymL+biiXFER11FKLw8yQtaaWzP+6jhiz4YW3wjpc0ITp/aZQhISkdp55fMHB666wDA4WIDIi4/d2poCkq9gX/GTqjjqph/mB7LQXAK4Q2tWyC1iYyjw=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <265745cb-40f4-22d8-8c85-ffc89b2baf04@arm.com>
Date: Thu, 21 Apr 2022 15:01:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 03/10] xen/arm: add CONFIG_ARM_EFI to stub EFI API
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, nd@arm.com, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-4-wei.chen@arm.com>
 <alpine.DEB.2.22.394.2204201724430.915916@ubuntu-linux-20-04-desktop>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <alpine.DEB.2.22.394.2204201724430.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SG2PR01CA0178.apcprd01.prod.exchangelabs.com
 (2603:1096:4:28::34) To PAXPR08MB7420.eurprd08.prod.outlook.com
 (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: abb1cd32-07ed-4ab6-e09b-08da2364c96d
X-MS-TrafficTypeDiagnostic:
	AS4PR08MB8071:EE_|VE1EUR03FT009:EE_|PAXPR08MB7036:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB70360D4F3E765F63784B1ACD9EF49@PAXPR08MB7036.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5pwH9q7xxuR5rewbwG2xiDUA6R/hOxmyCSDb1OYmr6ygzcRdqW9ttWSrlIwivEK/9wBtReihcJfeyZNiTehjtJvyo4UTJt95Xs3lk2aYARaZ4evLzefqea9pM7P00X9cP4Zd+mY/DDc9NcLpM/FkvsO9yl15LCsdEuEAdb530BK/lyYUSZXUEKYvYhCpo9tOq39hAG3mitlDFL4GmaZyUrkgLzRTo5NDzvtHwxpPoI/SUPvH53DuAZ0jBAA0N0MpeKryP2Y0nzLqbyTtnuvatzoKBXde5R9ALahLh0+JmjdKuxgOF0mbZUDTaV1gjHwutW+mojcc4VNe3dYFpEsLB4DkPjytgZ6TaN61vbju+NtL/FlyJUgKKhNY2S9lWILQ/kz2vMgT3mG0dV5syFDIrz3ST+YKujR8YMjZSmaayTjFwBucI/19gOHcSG2QTe0o0gj/sDxlzEggOiGG1HbtMZMwnKoi58IzHfL5iZ5MIf1+ufgY5ZXx/kobOWn9ABY6/t6cBb5lQAC8quFDdUL4OjAh+u5AsmXYP/cWD7BqifpujQigMTsmJ8dXmQpNjjDT3RCg6FAaGcYVIf3RMIeK/Tvkw2jEXBHOT40w4xbvrJD4rf2etfmTruS0nBX/1Wpj5T0dgxxQPgzw5n3atWE4i9/8JKH4ujbLuOz+SoiiVuzCO7eA5WCjb54/FuONTXoPhvsvgToGJkXEbXmPNgqZ/hi7pnaeBJBK8+5RlOY7bAQ=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(53546011)(8936002)(38100700002)(66946007)(31696002)(54906003)(316002)(508600001)(6486002)(66556008)(66476007)(6916009)(6666004)(2616005)(186003)(4326008)(8676002)(5660300002)(31686004)(6512007)(26005)(2906002)(6506007)(36756003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8071
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	96dce694-757c-4975-696e-08da2364c39e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3q2WdEy1EXLOvGI+VjzwEIbKZ6246/ABta5vFxrOeZ1TNWyK8eNoJ5T8Dr8CziLqd2jLXjRYFvySwtBbpOvw1Kc4KR6SPuJEGPtw/xcPUEBwEodJChR+Uaz7g8Gv1Ju8Gb/4JwsjkLsE5BcffUtlDhhM0LXJpZJwqcjn1nxRNetnR0Pb7zL1QMmo9XtwNBbbIwq6AXHS+Grj3PuwOVT7MXlHDfozDUvWIJo/s2roWV/Pc7V6gAEeVbuBXvwkrTUyB89/ARR9vvLUPit+5qGhCSNz1RgJX8WEpP5/kEHiKafeIqOYO9SuoMVSlrLXspnTGtgzieMYTk9Evojki1Uo6ri3E0XE95n5KADYCIigg2rh9iKJX77vDqKx1A06AumajcScbLR2Jnl3/9BInz61U8bCYxdf+MHb+vPiNpVkVvpgy6E+UXT2vpM6BO4kMbWvs2DHobVv9I5qYYCgPOdzijX39UjUcSuHRwvlf7JYoPgZOeXooIS0ZFxjwv3clSLSxMhglnPEX9zJ88Kn4mYex4yVoPcSncdeHg3ddNbSVG0cen9y5FwQD8x35cCeSauRMOevIAtefNjrifblHwfSnvBYP/5wTt/LDEi6Sc2LOJ7Xx0bYofz554N4WhKNV2OeyMfMqw8TNqTkrcNNhMi4D5FHcT4HpBcvfRqbFCHaz01MhN7nZ/qzJsA8RiGpAQa6j0cQbM251tUmQafCXGa7uw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(82310400005)(70206006)(70586007)(54906003)(81166007)(47076005)(336012)(36756003)(356005)(36860700001)(316002)(6862004)(8676002)(4326008)(31686004)(8936002)(2906002)(6512007)(86362001)(508600001)(26005)(2616005)(6486002)(107886003)(53546011)(40460700003)(186003)(31696002)(5660300002)(83380400001)(6506007)(6666004)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 07:01:40.8532
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: abb1cd32-07ed-4ab6-e09b-08da2364c96d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7036

Hi Stefano,

On 2022/4/21 8:25, Stefano Stabellini wrote:
> On Mon, 18 Apr 2022, Wei Chen wrote:
>> x86 is using compiler feature testing to decide EFI
>> build enable or not. When EFI build is disabled, x86
>> will use a efi/stub.c file to replace efi/runtime.c
>> for build objects. Following this idea, we introduce
>> a stub file for Arm, but use CONFIG_ARM_EFI to decide
>> EFI build enable or not.
>>
>> Signed-off-by: Wei Chen <wei.chen@arm.com>
>> ---
>> v1 -> v2:
>> 1. Use CONFIG_ARM_EFI to replace CONFIG_EFI
>> 2. Remove help text and make CONFIG_ARM_EFI invisible.
>> 3. Merge one following patch:
>>     xen/arm: introduce a stub file for non-EFI architectures
>> 4. Use the common stub.c instead of creating new one.
>> ---
>>   xen/arch/arm/Kconfig      | 5 +++++
>>   xen/arch/arm/Makefile     | 2 +-
>>   xen/arch/arm/efi/Makefile | 5 +++++
>>   3 files changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>> index ecfa6822e4..5f1b0121b0 100644
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -6,6 +6,7 @@ config ARM_64
>>   	def_bool y
>>   	depends on !ARM_32
>>   	select 64BIT
>> +	select ARM_EFI
>>   	select HAS_FAST_MULTIPLY
>>   
>>   config ARM
>> @@ -33,6 +34,10 @@ config ACPI
>>   	  Advanced Configuration and Power Interface (ACPI) support for Xen is
>>   	  an alternative to device tree on ARM64.
>>   
>> +config ARM_EFI
>> +	bool
>> +	depends on ARM_64
> 
> As ARM_EFI is selected by ARM_64 and it cannot be enable via a menu (it
> is hidden) there is no need for the "depends" line here
> 

Ok, I will remove it.

> 
>>   config GICV3
>>   	bool "GICv3 driver"
>>   	depends on ARM_64 && !NEW_VGIC
>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
>> index 1d862351d1..bb7a6151c1 100644
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -1,6 +1,5 @@
>>   obj-$(CONFIG_ARM_32) += arm32/
>>   obj-$(CONFIG_ARM_64) += arm64/
>> -obj-$(CONFIG_ARM_64) += efi/
>>   obj-$(CONFIG_ACPI) += acpi/
>>   obj-$(CONFIG_HAS_PCI) += pci/
>>   ifneq ($(CONFIG_NO_PLAT),y)
>> @@ -20,6 +19,7 @@ obj-y += domain.o
>>   obj-y += domain_build.init.o
>>   obj-y += domctl.o
>>   obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
>> +obj-y += efi/
>>   obj-y += gic.o
>>   obj-y += gic-v2.o
>>   obj-$(CONFIG_GICV3) += gic-v3.o
>> diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile
>> index 4313c39066..75ef180233 100644
>> --- a/xen/arch/arm/efi/Makefile
>> +++ b/xen/arch/arm/efi/Makefile
>> @@ -1,4 +1,9 @@
>>   include $(srctree)/common/efi/efi-common.mk
>>   
>> +ifeq ($(CONFIG_ARM_EFI),y)
>>   obj-y += $(EFIOBJ-y)
>>   obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
>> +else
>> +EFIOBJ-y += stub.o
>> +obj-y += stub.o
> 
> The change to EFIOBJ-y is not needed here as EFIOBJ-y is not used.
> Only obj-y += stub.o should be enough
> 

I add stub.o to EFIOBJ-y that's because I want to use the clean-files
in efi-common.mk. Otherwise the link of stub.c in arm/efi will not
be cleaned in "make clean".

>> +endif
>> -- 
>> 2.25.1
>>


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 07:03:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 07:03:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309811.526289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQqz-0000QS-Vw; Thu, 21 Apr 2022 07:03:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309811.526289; Thu, 21 Apr 2022 07:03:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQqz-0000QJ-Sl; Thu, 21 Apr 2022 07:03:49 +0000
Received: by outflank-mailman (input) for mailman id 309811;
 Thu, 21 Apr 2022 07:03:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/n2O=U7=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nhQqy-0000QB-Ls
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 07:03:48 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on061e.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::61e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 309a193a-c141-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 09:03:47 +0200 (CEST)
Received: from AM6PR05CA0031.eurprd05.prod.outlook.com (2603:10a6:20b:2e::44)
 by AM4PR08MB2690.eurprd08.prod.outlook.com (2603:10a6:205:5::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 07:03:45 +0000
Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2e:cafe::f4) by AM6PR05CA0031.outlook.office365.com
 (2603:10a6:20b:2e::44) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Thu, 21 Apr 2022 07:03:45 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 07:03:44 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Thu, 21 Apr 2022 07:03:44 +0000
Received: from e493116380c2.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E5D9CF31-07B1-448C-83DB-B94D7A32BDCC.1; 
 Thu, 21 Apr 2022 07:03:38 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e493116380c2.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Apr 2022 07:03:38 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM6PR08MB4936.eurprd08.prod.outlook.com (2603:10a6:20b:eb::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 07:03:35 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Thu, 21 Apr 2022
 07:03:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 309a193a-c141-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J9Esg3YoA6ses4DC0rYJeS9nw9MCvXOmCUoUxocmDVI=;
 b=8nPEELgMIpyJqKiSINbeIiRslqpSEK5WcByEL/LOfbvOyn8BKAh6iOXoR8E60LYa/CYmkLoUAJcTRmsf3FhYqXWCZFGBgNgqOaOKGvgWVp0qyb/kRfDZs2Qz1QWmZrWfWL0Nvo5NtYks54G9R8XUOWcrEn4OIkVuVHixAtHfcw8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2a57343a8b927f19
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H2flMK5ccI4SvnGgwUhued0y4gnuU57Nx1+Ubq0zdsvVy6o0w+OiUtxm/dcSXSW8sFfxFQbpKZ/T2Bt28vzH57MMkDaZrdPuGCmNpO0kiNqmpsHWFKw0mM4V0RL1YuXXkGz1ijSrhw5HAao65YYzzYboFrF2WT+6Hy7MIUbNL73lmA126+9WMrjauoC3guDHCOvx8melfO8nZoyQPSxZHDnSfiJr00k8y4E08oCyhcjtw/Q0DAuQRHxW1U7IRNEp5dkL7NsoFcqL3LhRs2ugIwSr0sKe3/ofgCN0uYggt98okrc52nvxk3FJyjpkwR8LuaBwP2UOojiAnDBPJIRQVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J9Esg3YoA6ses4DC0rYJeS9nw9MCvXOmCUoUxocmDVI=;
 b=QiRyCidcdm21p55gycx7rvEgmgH+B6eZADkLmgEkL2h/vENpnyqqAYF+LyTz5UQvfXpkm82u8mxxpcv3pulhNOw501ZxXjm7H6yztm6fqHf9OQ7+UVNLpJeL26QM7+9jTNL5F9yO8RHi2Cn5xElsrAt6S+Fc07kQFxeWUgJHmF/UmfTo4mQyW+bNCTi0uHZtHPq7TtaXUDLPJCepZwbt+Tc/Oh09VMLq8NK8s0FCdSnKdm13hSQckROVKlK6XLFK13D8ptvHH1q3e/H1Kv5ZQ3ZiR0ImVFRWVpFvwShfkGpT+mQ5BI1g9Dt/BKOjYr8rafabth6dCaiQFVNHryfbSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J9Esg3YoA6ses4DC0rYJeS9nw9MCvXOmCUoUxocmDVI=;
 b=8nPEELgMIpyJqKiSINbeIiRslqpSEK5WcByEL/LOfbvOyn8BKAh6iOXoR8E60LYa/CYmkLoUAJcTRmsf3FhYqXWCZFGBgNgqOaOKGvgWVp0qyb/kRfDZs2Qz1QWmZrWfWL0Nvo5NtYks54G9R8XUOWcrEn4OIkVuVHixAtHfcw8=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <de8082c4-47a4-305c-3110-5c5990a2229f@arm.com>
Date: Thu, 21 Apr 2022 15:03:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 06/10] xen: introduce an arch helper for default dma
 zone status
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: nd@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-7-wei.chen@arm.com>
 <9ab21bd5-7208-0000-5274-3c970ec6768e@suse.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <9ab21bd5-7208-0000-5274-3c970ec6768e@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SI2PR02CA0024.apcprd02.prod.outlook.com
 (2603:1096:4:195::18) To PAXPR08MB7420.eurprd08.prod.outlook.com
 (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: f9e74e81-cebd-4cd8-136c-08da2365133a
X-MS-TrafficTypeDiagnostic:
	AM6PR08MB4936:EE_|AM5EUR03FT040:EE_|AM4PR08MB2690:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR08MB2690868CA9341A5BF8BAC5B99EF49@AM4PR08MB2690.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 WsNDahYxfquEkuaBtE17aOPDckbfnd27glb2OpkuxchPxUXrH1FJ/Mp1egKNQ7Su22XfjiY8BlvQQ4M7yZq9oM9R54Dw/Wd2PmG/C1ZKPJV94qTfNst7mMRd/0jPTT6AUbNwx0UUrqFQlz+x6rHtlwueKquBfyxOwdmar0LGUsdqgOxJFC2v37xLduZkrsol4CPIgFxvsKRdcKLxNrGqS2NlVGPB7rvFot9zyqgJTrvwdlRFZdn2eMkwk8qXhIVPi+aYyJjb48e0hqii33cc65bUUUwWpuz6MXbkUWZRPl46Rry748kt1wMeQ5bCPsUkFjJVLKzeTcvJbHuBnT2iIvlDo6OHsGE2YTk83GSaDZpjdyS3S0EXsfJST95Yav37ZambFgHNYya+HCX6I5S/BdPdyhNHpWgv2+7LOppNcJWnpAz4PTx0X64BsnaqcPehApCpRez2vVw46AQ5XhCoy2DfS/EV5MTNccYGpvZxuDbvDHLyzQYzYNwAZRVqP9m9jzuJhZxVBtefwi3VzFNEQhEShzhAxduaA6Amglkr0lvQr2GrRkB373BPJ860LiUkO/nWx6vZ8+uRFtKiplnkKGbLHLRCkaMg+VdrV+WvaToEKJYZxOFesRIHlps1rKtfAhBg/buFqVvGqAClYSnHKvGr02+uv9Ub/y/n8G4SUU08GQW5PXnPJCrf69Hcrp1NQEqH2UCQIFDngX1MLzILOrk7p9wJYDmBp2mDoJijgjtBc3LuFvwZe0+/TtQoMjqJ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(4326008)(6486002)(8676002)(6916009)(54906003)(316002)(4744005)(53546011)(2906002)(6512007)(508600001)(31696002)(86362001)(66476007)(6666004)(83380400001)(2616005)(186003)(26005)(66946007)(66556008)(31686004)(8936002)(5660300002)(36756003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4936
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e1e5cef6-d72d-46ef-9b04-08da23650daa
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4veYHLiITE8ZfwALXGxe9b6CqqM0HlmYyOOt9N7jjEfm/FYznilFOsxibIZqLzriQWFYx2TljwPYtbvLTrq4Dw/ECMCviFc3keCALYxMj/Y5Z68FE8zukcD5QoiJPZLFu1OnFba/Nt+jfTR/6WDvVKGzHYBqM6Z5vCD52Mp/Sv3rpVDWx/TJGBR9pQmgUCKy+cSWsw0r/nMa0V4ze4TCFYpA7KYVwfjDhQp+CfzfdRgUfsxM4xcBbr5YMe/mqmvwDBSkCa9NQQ0EIbGZEDLHbjQ3x1+//HrSKDpRTUUis2tagzWqxUr2KWvSbt3NIuuJJxJxZuy/S9C+oWhHAwLahEAxEUjqtSv7UK8i7ginXctu8x/XrzBvEAlJUXM5M8lI7MJsvzq1dNCriJX5jsfii2AJh2DjB/ptQArRpmYgbDbxmqhE3EsMLPMxlFZtcLum1W+bDxztT55n4TFzJHVaE4aRU/LN8xytr6lScPaUbmY6e5gWiROL3/R0zyj8qyKfa79VYPwNUXsgbneGsbM+U7PeXeMOiyiRix83GriYEmmOxwiPAu1hbbhR9O6BiCO/cuqEkR5sg0IlXiF390qzovBVIsLPCLImwjmzABhrNiF2GhZff9Gf8vgwPhwhVyY7q3gHTUys4uQXvXRT9mK0vGL5UvYBygW1ecFyd811C9T6mvxZ3ifkJBExbvRcN6JcFFFU9wLJnL7hK+v53zXnRA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(2906002)(26005)(336012)(6512007)(8936002)(316002)(54906003)(186003)(70206006)(70586007)(82310400005)(81166007)(6506007)(83380400001)(8676002)(6862004)(4326008)(31686004)(53546011)(6666004)(508600001)(4744005)(36756003)(47076005)(86362001)(2616005)(31696002)(5660300002)(356005)(36860700001)(6486002)(40460700003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 07:03:44.7059
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f9e74e81-cebd-4cd8-136c-08da2365133a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2690

Hi Jan,

On 2022/4/19 17:18, Jan Beulich wrote:
> On 18.04.2022 11:07, Wei Chen wrote:
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -1889,7 +1889,7 @@ void __init end_boot_allocator(void)
>>       }
>>       nr_bootmem_regions = 0;
>>   
>> -    if ( !dma_bitsize && (num_online_nodes() > 1) )
>> +    if ( !dma_bitsize && arch_have_default_dmazone() )
>>           dma_bitsize = arch_get_dma_bitsize();
> 
> Considering its purpose, may I suggest "want" instead of "have" in the
> hook name?
> 

Ok, I will do it.

> Jan
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 07:05:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 07:05:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309816.526300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQsi-00011j-Aw; Thu, 21 Apr 2022 07:05:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309816.526300; Thu, 21 Apr 2022 07:05:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhQsi-00011c-82; Thu, 21 Apr 2022 07:05:36 +0000
Received: by outflank-mailman (input) for mailman id 309816;
 Thu, 21 Apr 2022 07:05:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/n2O=U7=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nhQsg-00011S-Pk
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 07:05:34 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20612.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::612])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f745f88-c141-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 09:05:33 +0200 (CEST)
Received: from DB6PR0501CA0038.eurprd05.prod.outlook.com (2603:10a6:4:67::24)
 by DU2PR08MB7341.eurprd08.prod.outlook.com (2603:10a6:10:2f0::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 07:05:31 +0000
Received: from DB5EUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:67:cafe::90) by DB6PR0501CA0038.outlook.office365.com
 (2603:10a6:4:67::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Thu, 21 Apr 2022 07:05:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT049.mail.protection.outlook.com (10.152.20.191) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 07:05:31 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Thu, 21 Apr 2022 07:05:30 +0000
Received: from a8f3234f7f5e.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DE6560BF-D1E4-4E95-8974-41FE49EE2AF6.1; 
 Thu, 21 Apr 2022 07:05:24 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8f3234f7f5e.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Apr 2022 07:05:24 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM6PR08MB4936.eurprd08.prod.outlook.com (2603:10a6:20b:eb::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 07:05:22 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Thu, 21 Apr 2022
 07:05:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f745f88-c141-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XJ+obiYyCB7rESgWXHYYrBcZ79Glzjlht246yinLcgg=;
 b=WdQ4LzE964lKgLO2UsWrglwljV3xSqBwn4P6zKJocHJBSERyutTtJw8myeax6JSdwTCC5T98MYAyCjmbRSKLsewo6ZsG5FtOmn8+kLkjKYLG7ZLIK9qlFS+f8QtuOI+3A6qhD8Zb5bXXn09XaZxrtHIRcsq4JRXTnMFD19c8oe0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1ed7141db5728a4f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=efUPtaAEdZ8jXNTb1L/2VYPc08qn6Twkr409i4nA3Vd9VVPoX3LPfpj9fhb4W+IovMUjqj8PH7bIAkV+IIDIFPa9OhzKXto5u48XNW75sv7eVioULALV1OxIPt/MJCk/tFVIveCnJ2ezCoT6zKiH8cChS6Ai7R55jcYkkKkgInuxlG8v7ojyK6oGQVnGiy5FoY3YXiiqE7IkiqdyLgZR96EriIBT62YIMFYX7pYV3PT29vdzQ1hbC0Hsuren024z1iuFUNiDk0L29qrGyoaeME6XjTI/wMB1GPgdmy/VdPVsXs2ZZ+9ZCESYk8FkvscbzI9LWlIDuac6DOvOLJzbhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XJ+obiYyCB7rESgWXHYYrBcZ79Glzjlht246yinLcgg=;
 b=G7j/0LfkuvF/IKbuQ6M3wbxepgb0g0jVcBFMF5eJesCEqlrLj2VkcaNHj/A9nbL0BS2JEqa/ctITYcHFOgXUiIY63wiuLkd7S/qygL79mzhfq3gSqxWsYvYIlFdizNYE6KIqAyDaB+cb0rqSADAJkTVvmB1r2HaVTv8OspS6aL4Ke/jKS3kVAXmrdpSfivZ/qW+lSOvBIEeArhtSRC9B80eeaE3rd+2rRKO873aA8B6W1Rx8fKRH/gJrlGm74yMmoAy33Y0Fp9A4eZFTRNbOQB+u9RuaK6/guntMtCzjvYFw4UrjbQPW9LzYzlIfGME/nryBGUX3VU2ljfDamu+W9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XJ+obiYyCB7rESgWXHYYrBcZ79Glzjlht246yinLcgg=;
 b=WdQ4LzE964lKgLO2UsWrglwljV3xSqBwn4P6zKJocHJBSERyutTtJw8myeax6JSdwTCC5T98MYAyCjmbRSKLsewo6ZsG5FtOmn8+kLkjKYLG7ZLIK9qlFS+f8QtuOI+3A6qhD8Zb5bXXn09XaZxrtHIRcsq4JRXTnMFD19c8oe0=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <6e5a59a9-c61a-92e4-d3f8-6bbcb49372fa@arm.com>
Date: Thu, 21 Apr 2022 15:05:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 01/10] xen/arm: Print a 64-bit number in hex from early
 uart
Content-Language: en-US
To: Jiamei Xie <Jiamei.Xie@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: nd <nd@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Julien Grall <jgrall@amazon.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-2-wei.chen@arm.com>
 <VI1PR08MB3056693E070014DD4F7A885F92F29@VI1PR08MB3056.eurprd08.prod.outlook.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <VI1PR08MB3056693E070014DD4F7A885F92F29@VI1PR08MB3056.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SI2PR02CA0007.apcprd02.prod.outlook.com
 (2603:1096:4:194::23) To PAXPR08MB7420.eurprd08.prod.outlook.com
 (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: b2490fd7-4399-453b-d7c1-08da23655293
X-MS-TrafficTypeDiagnostic:
	AM6PR08MB4936:EE_|DB5EUR03FT049:EE_|DU2PR08MB7341:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR08MB7341CCE5ECE6607D764ECAEE9EF49@DU2PR08MB7341.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 8EF8zcDM27DLU6zKD69eDfHtEfxt617XbDLMiBBJjs4C7icTRBSahU60VSEehLGhFZBwPRkX1X814vXT3CFgho1Vjs3ugq5HVJrsp3F46y6LspFMb+CtRm/R/vh8GiNrU6sDSMO8MsPD/aGDu1rt9ngkXBfBDyti02CHLtP2I5Jk8rtlN/Vx/8tLIZJycAq1lbXL0l5UNOaQBQxK45xeESRL0wuxzd8XtGmKcxkeE5erWiOKapQ931CNPrYZwkTn4u8WW7sBhA+aRJVegNy4oOooowJmUcChWz8ueu6yZWbiPrFNQ26727S+CXFvf8QAmBJehGGc60Z1TNwMm55iz07RWbHzlWvOFX7YHYPy8/20C0QLin2B8rrcXUFyroIeSOpCL4GUqBn1mbcoR4kNBjNINY7rIcq2ZgaUbECZVE7WdgMLC1ERZlQ8+nrYEDeYdGZowvRaYDwobJFuutitWrSRoZTWez3dJJc+k7s5kh5DfxAw3Rmoieaoa5wlIDXlaO4ZM5AZ3W/ymjB9rIyZWMLZnJ3aeaErA+mG3AsGUTgDVv89ufIXM85rjU+gHxn/EWCbh8X83NfsFPgKPiNkLJLc5T++KFjK9D549K+PJ6QlMirZf/fZtOXtXjSdq4WSAaXx8PxI9aYij/xe4htVhde0kLn2tfA2BnYa729nlcf3DiIct+KigNssl9ZlOWRojnyuuEqvFshHVDK4HbENxzAXOD+SWgha2jiFW/MF2bM=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(4326008)(6486002)(8676002)(54906003)(316002)(53546011)(2906002)(6512007)(508600001)(31696002)(110136005)(86362001)(66476007)(6666004)(83380400001)(2616005)(186003)(26005)(66946007)(66556008)(31686004)(8936002)(5660300002)(36756003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4936
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5f7ae7e2-5c49-4c84-0736-08da23654cfe
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mVL39RFkB0RMXaZwLfAZAFw02s3iq90B8E6OgB2fGm3uNQbbzjBNj9rizumekWJ2DMRiZXkR4/r9ALIGn9DlS4Dp0bEJec8dDKL1v8sDX4KmIMY5CanuwvKqzCKwju/d/xNGHB/24Af0W9IvQqGp0iLdruJuNQJ9XH0YBOOOv+r3OJaMEUrrinAinFj/OZFnpl7BwW6q/VxGPfKQoU1KGPLybZi7fJ3lXY81uJyznga1JP22CdwaQPkKieAK64tOueAim3X/AIpEHfWIqZ3PvZnE2Fza5DXTNhz+ptomNjahkZ5zf63cJcQvg7LVZIfFFRW3UqGevfA2H7JsAZ/hbxicG00bHcxvg0sGaOem6yosz6DJuWx78JfNSFxDhcuDFkt445pket74waEi8fWss280jeSdLVxAaZFnnAHLBcC+xnTFSMCavBXr2+TY0ntqbgAwkIVO157qgH/PvPwvlsK8KSPdD74WM3PWzilkw/NooiVHflnLoX8XF8LWn3B+xnFeGkk6IUZ4qS5n5mkRf+iZzdlKR7E2bK5nWBvVCxnTBTDgET5BNaudV16Xc0nrWHd6Wd9ZgbHWcoQ6npd5ZayE4GfBqnsHUCQWW9TXmXLeZ+yiQCt5iPMG+Uv+mBUHRkaFy0Z9l1OypskOl/wDATNAqqXkBg/XkycFpfoGjjHzFJawz/pP206q8/BZtIzqlVF8JaRCWx1ZF6z0Za9EqA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(508600001)(6512007)(6486002)(110136005)(54906003)(186003)(5660300002)(8936002)(31686004)(36756003)(8676002)(4326008)(2616005)(2906002)(107886003)(26005)(70586007)(70206006)(86362001)(82310400005)(83380400001)(40460700003)(356005)(336012)(36860700001)(81166007)(47076005)(316002)(53546011)(6506007)(6666004)(31696002)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 07:05:31.0280
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b2490fd7-4399-453b-d7c1-08da23655293
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7341

Hi Jiamei,

On 2022/4/19 17:13, Jiamei Xie wrote:
> Hi Wei,
> 
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
>> Wei Chen
>> Sent: 2022年4月18日 17:07
>> To: --to=xen-devel@lists.xenproject.org; xen-devel@lists.xenproject.org
>> Cc: nd <nd@arm.com>; Wei Chen <Wei.Chen@arm.com>; Stefano Stabellini
>> <sstabellini@kernel.org>; Julien Grall <julien@xen.org>; Bertrand Marquis
>> <Bertrand.Marquis@arm.com>; Volodymyr Babchuk
>> <Volodymyr_Babchuk@epam.com>; Julien Grall <jgrall@amazon.com>
>> Subject: [PATCH v2 01/10] xen/arm: Print a 64-bit number in hex from early
>> uart
>>
>> Current putn function that is using for early print
>> only can print low 32-bit of AArch64 register. This
>> will lose some important messages while debugging
>> with early console. For example:
>> (XEN) Bringing up CPU5
>> - CPU 0000000100000100 booting -
>> Will be truncated to
>> (XEN) Bringing up CPU5
>> - CPU 00000100 booting -
>>
>> In this patch, we increased the print loops and shift
>> bits to make putn print 64-bit number.
>>
>> Signed-off-by: Wei Chen <wei.chen@arm.com>
>> Acked-by: Julien Grall <jgrall@amazon.com>
>> ---
>>   xen/arch/arm/arm64/head.S | 12 +++++++-----
>>   1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
>> index e62c48ec1c..2bb7906f69 100644
>> --- a/xen/arch/arm/arm64/head.S
>> +++ b/xen/arch/arm/arm64/head.S
>> @@ -866,17 +866,19 @@ puts:
>>           ret
>>   ENDPROC(puts)
>>
>> -/* Print a 32-bit number in hex.  Specific to the PL011 UART.
>> +/*
>> + * Print a 64-bit number in hex.
>>    * x0: Number to print.
>>    * x23: Early UART base address
>> - * Clobbers x0-x3 */
>> + * Clobbers x0-x3
>> + */
>>   putn:
>>           adr   x1, hex
>> -        mov   x3, #8
>> +        mov   x3, #16
>>   1:
>>           early_uart_ready x23, 2
>> -        and   x2, x0, #0xf0000000    /* Mask off the top nybble */
>> -        lsr   x2, x2, #28
>> +        and   x2, x0, #(0xf<<60)     /* Mask off the top nybble */
>> +        lsr   x2, x2, #60
>>           ldrb  w2, [x1, x2]           /* Convert to a char */
>>           early_uart_transmit x23, w2
>>           lsl   x0, x0, #4             /* Roll it through one nybble at a time */
>> --
>> 2.25.1
>>
> 
> I have tested the whole patch series on Armv8A(config without NUMA) and X86(config with NUMA), both can enter Dom0 successfully and the X86 NUMA works normally.
> 
> Tested-by: Jiamei Xie <jiamei.xie@arm.com>
> 

Thanks for your testing!

> Regards,
> Jiamei Xie


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 07:37:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 07:37:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309821.526311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRNB-0004yc-No; Thu, 21 Apr 2022 07:37:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309821.526311; Thu, 21 Apr 2022 07:37:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRNB-0004yV-KJ; Thu, 21 Apr 2022 07:37:05 +0000
Received: by outflank-mailman (input) for mailman id 309821;
 Thu, 21 Apr 2022 07:37:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhRNA-0004yL-JA; Thu, 21 Apr 2022 07:37:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhRNA-0002LM-Gd; Thu, 21 Apr 2022 07:37:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhRNA-0007Vd-2U; Thu, 21 Apr 2022 07:37:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhRNA-0006d5-20; Thu, 21 Apr 2022 07:37:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GRa0as9oOOV0oAISlAmrKmgRvKHZ93z45LmyqWJV0ZY=; b=YzGk5y8yQOVH8+IAf+NWtT17X0
	dZig4QdkbhJ8T2ffamGNpPG+vEr0RZ+yzJPwkAbxnEyfYt8OaYl0kAQgmbu8pgILLt+zEyWsxgvDk
	gNICM7qv3slA86tcoFtLlZTXsm5GrtLh2JMWPD34smdCKRIvhB5WLtmGeY6D6K2pY0/M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169585-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169585: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 07:37:04 +0000

flight 169585 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169585/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  531 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 07:57:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 07:57:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309830.526322 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRh5-0007q4-JC; Thu, 21 Apr 2022 07:57:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309830.526322; Thu, 21 Apr 2022 07:57:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRh5-0007px-Fm; Thu, 21 Apr 2022 07:57:39 +0000
Received: by outflank-mailman (input) for mailman id 309830;
 Thu, 21 Apr 2022 07:57:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Sn/J=U7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhRh4-0007pp-6D
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 07:57:38 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b5089c64-c148-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 09:57:36 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D753321115;
 Thu, 21 Apr 2022 07:57:34 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB32913A84;
 Thu, 21 Apr 2022 07:57:34 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 5LZ4KG4OYWKBGwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 21 Apr 2022 07:57:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5089c64-c148-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650527854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZDsaqZmsX1WpM5fCrR8a4mXklVUCBN6p9dIP3+CxwgE=;
	b=sTCHxZVJFMhUSgNv/9WpNzbnD7dmmZQybsZs7SER/cVnJ2caWeKRwLK+9iIsyMFSJSrpap
	LX9eqI48H27rFdWNHohuFVxgMNwitBqsC1euICtBdZ/Ky6+m9l8S/bExdunchcMuy4lJvH
	sYpXOggBN4c3kgmRU/5vK6+FTorxVXk=
Message-ID: <c60ed330-a21b-24e1-e77d-c40f773c2298@suse.com>
Date: Thu, 21 Apr 2022 09:57:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20220420150942.31235-1-jgross@suse.com>
 <20220420150942.31235-10-jgross@suse.com>
 <0d5ae87a-be43-ce7c-57b2-4567bb7e9f4d@oracle.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 09/18] xen/xenbus: add xenbus_setup_ring() service
 function
In-Reply-To: <0d5ae87a-be43-ce7c-57b2-4567bb7e9f4d@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------vB2y5WggVz3Q8yeTQtMS7igE"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------vB2y5WggVz3Q8yeTQtMS7igE
Content-Type: multipart/mixed; boundary="------------6zMPaf8astR48LP1vGQmTDoa";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <c60ed330-a21b-24e1-e77d-c40f773c2298@suse.com>
Subject: Re: [PATCH 09/18] xen/xenbus: add xenbus_setup_ring() service
 function
References: <20220420150942.31235-1-jgross@suse.com>
 <20220420150942.31235-10-jgross@suse.com>
 <0d5ae87a-be43-ce7c-57b2-4567bb7e9f4d@oracle.com>
In-Reply-To: <0d5ae87a-be43-ce7c-57b2-4567bb7e9f4d@oracle.com>

--------------6zMPaf8astR48LP1vGQmTDoa
Content-Type: multipart/mixed; boundary="------------WQKVgk7KonRnY0qz39V6KC7l"

--------------WQKVgk7KonRnY0qz39V6KC7l
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDQuMjIgMjA6NDQsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDQv
MjAvMjIgMTE6MDkgQU0sIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiArLyoNCj4+ICsgKiB4
ZW5idXNfc2V0dXBfcmluZw0KPj4gKyAqIEBkZXY6IHhlbmJ1cyBkZXZpY2UNCj4+ICsgKiBA
dmFkZHI6IHBvaW50ZXIgdG8gc3RhcnRpbmcgdmlydHVhbCBhZGRyZXNzIG9mIHRoZSByaW5n
DQo+PiArICogQG5yX3BhZ2VzOiBudW1iZXIgb2YgcGFnZXMgdG8gYmUgZ3JhbnRlZA0KPj4g
KyAqIEBncmVmczogZ3JhbnQgcmVmZXJlbmNlIGFycmF5IHRvIGJlIGZpbGxlZCBpbg0KPj4g
KyAqDQo+PiArICogQWxsb2NhdGUgcGh5c2ljYWxseSBjb250aWd1b3VzIHBhZ2VzIGZvciBh
IHNoYXJlZCByaW5nIGJ1ZmZlciBhbmQgZ3JhbnQgaXQNCj4+ICsgKiB0byB0aGUgcGVlciBv
ZiB0aGUgZ2l2ZW4gZGV2aWNlLiBUaGUgcmluZyBidWZmZXIgaXMgaW5pdGlhbGx5IGZpbGxl
ZCB3aXRoDQo+PiArICogemVyb2VzLiBUaGUgdmlydHVhbCBhZGRyZXNzIG9mIHRoZSByaW5n
IGlzIHN0b3JlZCBhdCBAdmFkZHIgYW5kIHRoZQ0KPj4gKyAqIGdyYW50IHJlZmVyZW5jZXMg
YXJlIHN0b3JlZCBpbiB0aGUgQGdyZWZzIGFycmF5LiBJbiBjYXNlIG9mIGVycm9yIEB2YWRk
cg0KPj4gKyAqIHdpbGwgYmUgc2V0IHRvIE5VTEwgYW5kIEBncmVmcyB3aWxsIGJlIGZpbGxl
ZCB3aXRoIElOVkFMSURfR1JBTlRfUkVGLg0KPj4gKyAqLw0KPj4gK2ludCB4ZW5idXNfc2V0
dXBfcmluZyhzdHJ1Y3QgeGVuYnVzX2RldmljZSAqZGV2LCBnZnBfdCBnZnAsIHZvaWQgKip2
YWRkciwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgbnJf
cGFnZXMsIGdyYW50X3JlZl90ICpncmVmcykNCj4+ICt7DQo+PiArwqDCoMKgIHVuc2lnbmVk
IGxvbmcgcmluZ19zaXplID0gbnJfcGFnZXMgKiBYRU5fUEFHRV9TSVpFOw0KPj4gK8KgwqDC
oCB1bnNpZ25lZCBpbnQgaTsNCj4+ICvCoMKgwqAgaW50IHJldDsNCj4+ICsNCj4+ICvCoMKg
wqAgKnZhZGRyID0gYWxsb2NfcGFnZXNfZXhhY3QocmluZ19zaXplLCBnZnAgfCBfX0dGUF9a
RVJPKTsNCj4+ICvCoMKgwqAgaWYgKCEqdmFkZHIpIHsNCj4+ICvCoMKgwqDCoMKgwqDCoCBy
ZXQgPSAtRU5PTUVNOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGdvdG8gZXJyOw0KPj4gK8KgwqDC
oCB9DQo+PiArDQo+PiArwqDCoMKgIHJldCA9IHhlbmJ1c19ncmFudF9yaW5nKGRldiwgKnZh
ZGRyLCBucl9wYWdlcywgZ3JlZnMpOw0KPj4gK8KgwqDCoCBpZiAocmV0KQ0KPj4gK8KgwqDC
oMKgwqDCoMKgIGdvdG8gZXJyOw0KPj4gKw0KPj4gK8KgwqDCoCByZXR1cm4gMDsNCj4+ICsN
Cj4+ICsgZXJyOg0KPj4gK8KgwqDCoCBpZiAoKnZhZGRyKQ0KPj4gK8KgwqDCoMKgwqDCoMKg
IGZyZWVfcGFnZXNfZXhhY3QoKnZhZGRyLCByaW5nX3NpemUpOw0KPj4gK8KgwqDCoCBmb3Ig
KGkgPSAwOyBpIDwgbnJfcGFnZXM7IGkrKykNCj4+ICvCoMKgwqDCoMKgwqDCoCBncmVmc1tp
XSA9IElOVkFMSURfR1JBTlRfUkVGOw0KPj4gK8KgwqDCoCAqdmFkZHIgPSBOVUxMOw0KPj4g
Kw0KPj4gK8KgwqDCoCByZXR1cm4gcmV0Ow0KPj4gK30NCj4gDQo+IA0KPiBXZSBjYW4gY3Jl
YXRlIGEgd3JhcHBlciBhcm91bmQgdGhpcyBmdW5jdGlvbiB0aGF0IHdpbGwgYWxzbyBjYWxs
IA0KPiBTSEFSRURfUklOR19JTklUKCkgYW5kIEZST05UX1JJTkdfSU5JVCgpLiBBIGJ1bmNo
IG9mIGRyaXZlcnMgZG8gdGhhdC4NCg0KVGhpcyB3cmFwcGVyIHdvdWxkIG5lZWQgdG8gYmUg
YSBtYWNybywgc28gSSBkZWNpZGVkIG5vdCB0byBkbyB0aGF0Lg0KDQpJdCB3b3VsZCBtYWtl
IHNlbnNlIHRvIG1lcmdlIHRoZSBjYWxsIG9mIFNIQVJFRF9SSU5HX0lOSVQoKSBpbnRvDQpG
Uk9OVF9SSU5HX0lOSVQoKSAob3IgYmV0dGVyLCBoYXZlIGEgbmV3IG1hY3JvIGNvbWJpbmlu
ZyB0aGUgdHdvKSwNCnRob3VnaCwgYXMgdGhlcmUgaXMgbm8gdXNlIGNhc2Ugb2YgRlJPTlRf
UklOR19JTklUKCkgd2l0aG91dCBhDQpjYWxsIG9mIFNIQVJFRF9SSU5HX0lOSVQoKSBkaXJl
Y3RseSBiZWZvcmUgaXQuDQoNCg0KSnVlcmdlbg0K
--------------WQKVgk7KonRnY0qz39V6KC7l
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------WQKVgk7KonRnY0qz39V6KC7l--

--------------6zMPaf8astR48LP1vGQmTDoa--

--------------vB2y5WggVz3Q8yeTQtMS7igE
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJhDm4FAwAAAAAACgkQsN6d1ii/Ey/i
Swf6AoqYqbKuaciaFv0odbbSswm1dEbDVYrJGDhoPDBAqHexAFBHhPicVL7mA8O/IJ5V2x0gvdH7
F8F6EI4Tm1JcuCAgSPVy4bv81yY5hYc9mTWiz8lgjDuDORW2kiGIXMDEeAhyedFjzoypQ55vuPsz
upqDRKj/KX25o0mm6d75CkdJgQJ1dnzyOyi9FhlIWd/udnNihpq9NNVFgbQr02x3Zuzhvf2TJG8f
UzEAw9k+xxRgfsr+RazUPJJwOlJKM1wHe1j1IAcs1g1QWIdaN6ZW+HxgooKehJ1x/u/9GOf8jViq
6QPxvuVoVkq+jZOy55p0hTBpGROp0+LI3MY2cCraaQ==
=gBpF
-----END PGP SIGNATURE-----

--------------vB2y5WggVz3Q8yeTQtMS7igE--


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:17:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:17:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309844.526338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzp-0002qF-Va; Thu, 21 Apr 2022 08:17:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309844.526338; Thu, 21 Apr 2022 08:17:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzp-0002og-P8; Thu, 21 Apr 2022 08:17:01 +0000
Received: by outflank-mailman (input) for mailman id 309844;
 Thu, 21 Apr 2022 08:16:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=foL4=U7=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nhRzn-0002nQ-Od
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:16:59 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6860a5b3-c14b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 10:16:56 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B7B951515;
 Thu, 21 Apr 2022 01:16:56 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C19D3F73B;
 Thu, 21 Apr 2022 01:16:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6860a5b3-c14b-11ec-8fbf-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com
Subject: [PATCH v8 1/7] tools/cpupools: Give a name to unnamed cpupools
Date: Thu, 21 Apr 2022 09:16:39 +0100
Message-Id: <20220421081645.40235-2-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220421081645.40235-1-luca.fancellu@arm.com>
References: <20220421081645.40235-1-luca.fancellu@arm.com>

With the introduction of boot time cpupools, Xen can create many
different cpupools at boot time other than cpupool with id 0.

Since these newly created cpupools can't have an
entry in Xenstore, create the entry using xen-init-dom0
helper with the usual convention: Pool-<cpupool id>.

Given the change, remove the check for poolid == 0 from
libxl_cpupoolid_to_name(...).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
---
Changes in v8:
- no changes
Changes in v7:
- Add R-by from Anthony
Changes in v6:
- Reworked loop to have only one error path (Anthony)
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- no changes, add R-by
Changes in v2:
 - Remove unused variable, moved xc_cpupool_infofree
   ahead to simplify the code, use asprintf (Juergen)
---
 tools/helpers/xen-init-dom0.c  | 37 +++++++++++++++++++++++++++++++++-
 tools/libs/light/libxl_utils.c |  3 +--
 2 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
index c99224a4b607..37eff8868f25 100644
--- a/tools/helpers/xen-init-dom0.c
+++ b/tools/helpers/xen-init-dom0.c
@@ -43,7 +43,10 @@ int main(int argc, char **argv)
     int rc;
     struct xs_handle *xsh = NULL;
     xc_interface *xch = NULL;
-    char *domname_string = NULL, *domid_string = NULL;
+    char *domname_string = NULL, *domid_string = NULL,
+         *pool_path = NULL, *pool_name = NULL;
+    xc_cpupoolinfo_t *xcinfo;
+    unsigned int pool_id = 0;
     libxl_uuid uuid;
 
     /* Accept 0 or 1 argument */
@@ -114,9 +117,41 @@ int main(int argc, char **argv)
         goto out;
     }
 
+    /* Create an entry in xenstore for each cpupool on the system */
+    do {
+        xcinfo = xc_cpupool_getinfo(xch, pool_id);
+        if (xcinfo != NULL) {
+            if (xcinfo->cpupool_id != pool_id)
+                pool_id = xcinfo->cpupool_id;
+            xc_cpupool_infofree(xch, xcinfo);
+            if (asprintf(&pool_path, "/local/pool/%d/name", pool_id) <= 0) {
+                fprintf(stderr, "cannot allocate memory for pool path\n");
+                rc = 1;
+                goto out;
+            }
+            if (asprintf(&pool_name, "Pool-%d", pool_id) <= 0) {
+                fprintf(stderr, "cannot allocate memory for pool name\n");
+                rc = 1;
+                goto out;
+            }
+            pool_id++;
+            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
+                          strlen(pool_name))) {
+                fprintf(stderr, "cannot set pool name\n");
+                rc = 1;
+                goto out;
+            }
+            free(pool_name);
+            free(pool_path);
+            pool_path = pool_name = NULL;
+        }
+    } while(xcinfo != NULL);
+
     printf("Done setting up Dom0\n");
 
 out:
+    free(pool_path);
+    free(pool_name);
     free(domid_string);
     free(domname_string);
     xs_close(xsh);
diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c
index b91c2cafa223..81780da3ff40 100644
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -151,8 +151,7 @@ char *libxl_cpupoolid_to_name(libxl_ctx *ctx, uint32_t poolid)
 
     snprintf(path, sizeof(path), "/local/pool/%d/name", poolid);
     s = xs_read(ctx->xsh, XBT_NULL, path, &len);
-    if (!s && (poolid == 0))
-        return strdup("Pool-0");
+
     return s;
 }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:17:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:17:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309846.526366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzr-0003Ww-L4; Thu, 21 Apr 2022 08:17:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309846.526366; Thu, 21 Apr 2022 08:17:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzr-0003Vm-Dk; Thu, 21 Apr 2022 08:17:03 +0000
Received: by outflank-mailman (input) for mailman id 309846;
 Thu, 21 Apr 2022 08:17:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=foL4=U7=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nhRzp-0002nQ-E4
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:17:01 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 69447d5a-c14b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 10:16:57 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 538F61516;
 Thu, 21 Apr 2022 01:16:58 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB5DC3F73B;
 Thu, 21 Apr 2022 01:16:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69447d5a-c14b-11ec-8fbf-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com
Subject: [PATCH v8 3/7] xen/sched: retrieve scheduler id by name
Date: Thu, 21 Apr 2022 09:16:41 +0100
Message-Id: <20220421081645.40235-4-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220421081645.40235-1-luca.fancellu@arm.com>
References: <20220421081645.40235-1-luca.fancellu@arm.com>

Add a static function to retrieve the scheduler pointer using the
scheduler name.

Add a public function to retrieve the scheduler id by the scheduler
name that makes use of the new static function.

Take the occasion to replace open coded scheduler search with the
new static function in scheduler_init.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
---
Changes in v8:
- no changes
Changes in v7:
- Add R-by (Dario)
Changes in v6:
- no changes
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- add R-by
Changes in v2:
- replace open coded scheduler search in scheduler_init (Juergen)
---
 xen/common/sched/core.c | 40 ++++++++++++++++++++++++++--------------
 xen/include/xen/sched.h | 11 +++++++++++
 2 files changed, 37 insertions(+), 14 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab67818106..48ee01420fb8 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2947,10 +2947,30 @@ void scheduler_enable(void)
     scheduler_active = true;
 }
 
+static inline
+const struct scheduler *__init sched_get_by_name(const char *sched_name)
+{
+    unsigned int i;
+
+    for ( i = 0; i < NUM_SCHEDULERS; i++ )
+        if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) )
+            return schedulers[i];
+
+    return NULL;
+}
+
+int __init sched_get_id_by_name(const char *sched_name)
+{
+    const struct scheduler *scheduler = sched_get_by_name(sched_name);
+
+    return scheduler ? scheduler->sched_id : -1;
+}
+
 /* Initialise the data structures. */
 void __init scheduler_init(void)
 {
     struct domain *idle_domain;
+    const struct scheduler *scheduler;
     int i;
 
     scheduler_enable();
@@ -2981,25 +3001,17 @@ void __init scheduler_init(void)
                    schedulers[i]->opt_name);
             schedulers[i] = NULL;
         }
-
-        if ( schedulers[i] && !ops.name &&
-             !strcmp(schedulers[i]->opt_name, opt_sched) )
-            ops = *schedulers[i];
     }
 
-    if ( !ops.name )
+    scheduler = sched_get_by_name(opt_sched);
+    if ( !scheduler )
     {
         printk("Could not find scheduler: %s\n", opt_sched);
-        for ( i = 0; i < NUM_SCHEDULERS; i++ )
-            if ( schedulers[i] &&
-                 !strcmp(schedulers[i]->opt_name, CONFIG_SCHED_DEFAULT) )
-            {
-                ops = *schedulers[i];
-                break;
-            }
-        BUG_ON(!ops.name);
-        printk("Using '%s' (%s)\n", ops.name, ops.opt_name);
+        scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT);
+        BUG_ON(!scheduler);
+        printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name);
     }
+    ops = *scheduler;
 
     if ( cpu_schedule_up(0) )
         BUG();
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 0164db996b8b..4442a1940c25 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -764,6 +764,17 @@ void sched_destroy_domain(struct domain *d);
 long sched_adjust(struct domain *, struct xen_domctl_scheduler_op *);
 long sched_adjust_global(struct xen_sysctl_scheduler_op *);
 int  sched_id(void);
+
+/*
+ * sched_get_id_by_name - retrieves a scheduler id given a scheduler name
+ * @sched_name: scheduler name as a string
+ *
+ * returns:
+ *     positive value being the scheduler id, on success
+ *     negative value if the scheduler name is not found.
+ */
+int sched_get_id_by_name(const char *sched_name);
+
 void vcpu_wake(struct vcpu *v);
 long vcpu_yield(void);
 void vcpu_sleep_nosync(struct vcpu *v);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:17:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:17:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309848.526388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzt-00042B-Ko; Thu, 21 Apr 2022 08:17:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309848.526388; Thu, 21 Apr 2022 08:17:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzt-00041N-AX; Thu, 21 Apr 2022 08:17:05 +0000
Received: by outflank-mailman (input) for mailman id 309848;
 Thu, 21 Apr 2022 08:17:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=foL4=U7=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nhRzr-0002nQ-Gt
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:17:03 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 69ce2dfb-c14b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 10:16:58 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3EECD1477;
 Thu, 21 Apr 2022 01:16:59 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 88A8F3F73B;
 Thu, 21 Apr 2022 01:16:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69ce2dfb-c14b-11ec-8fbf-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com
Subject: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time
Date: Thu, 21 Apr 2022 09:16:42 +0100
Message-Id: <20220421081645.40235-5-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220421081645.40235-1-luca.fancellu@arm.com>
References: <20220421081645.40235-1-luca.fancellu@arm.com>

Introduce a way to create different cpupools at boot time, this is
particularly useful on ARM big.LITTLE system where there might be the
need to have different cpupools for each type of core, but also
systems using NUMA can have different cpu pools for each node.

The feature on arm relies on a specification of the cpupools from the
device tree to build pools and assign cpus to them.

ACPI is not supported for this feature.

With this patch, cpupool0 can now have less cpus than the number of
online ones, so update the default case for opt_dom0_max_vcpus.

Documentation is created to explain the feature.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes in v8:
- moved Kconfig parameter from xen/common/Kconfig to
  xen/common/sched/Kconfig (Jan)
- Add R-by (Stefano)
Changes in v7:
- rename xen/common/boot_cpupools.c to xen/common/sched/boot-cpupool.c (Jan)
- reverted xen/common/Makefile, add entry in xen/common/sched/Makefile
- changed line in MAINTAINERS under CPU POOLS section (Dario)
- Fix documentation, update opt_dom0_max_vcpus to the number of cpu in
  cpupool0 (Julien)
Changes in v6:
- Changed docs, return if booted with ACPI in btcpupools_dtb_parse,
  panic if /chosen does not exists. Changed commit message (Julien)
- Add Juergen R-by for the xen/common/sched part that didn't change
Changes in v5:
- Fixed wrong variable name, swapped schedulers, add scheduler info
  in the printk (Stefano)
- introduce assert in cpupool_init and btcpupools_get_cpupool_id to
  harden the code
Changes in v4:
- modify Makefile to put in *.init.o, fixed stubs and macro (Jan)
- fixed docs, fix brakets (Stefano)
- keep cpu0 in Pool-0 (Julien)
- moved printk from btcpupools_allocate_pools to
  btcpupools_get_cpupool_id
- Add to docs constraint about cpu0 and Pool-0
Changes in v3:
- Add newline to cpupools.txt and removed "default n" from Kconfig (Jan)
- Fixed comment, moved defines, used global cpu_online_map, use
  HAS_DEVICE_TREE instead of ARM and place arch specific code in header
  (Juergen)
- Fix brakets, x86 code only panic, get rid of scheduler dt node, don't
  save pool pointer and look for it from the pool list (Stefano)
- Changed data structures to allow modification to the code.
Changes in v2:
- Move feature to common code (Juergen)
- Try to decouple dtb parse and cpupool creation to allow
  more way to specify cpupools (for example command line)
- Created standalone dt node for the scheduler so it can
  be used in future work to set scheduler specific
  parameters
- Use only auto generated ids for cpupools
---
 MAINTAINERS                            |   2 +-
 docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
 xen/arch/arm/domain_build.c            |   5 +-
 xen/arch/arm/include/asm/smp.h         |   3 +
 xen/common/sched/Kconfig               |   7 +
 xen/common/sched/Makefile              |   1 +
 xen/common/sched/boot-cpupool.c        | 207 +++++++++++++++++++++++++
 xen/common/sched/cpupool.c             |  12 +-
 xen/include/xen/sched.h                |  14 ++
 9 files changed, 388 insertions(+), 3 deletions(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/common/sched/boot-cpupool.c

diff --git a/MAINTAINERS b/MAINTAINERS
index 2a47fafe8580..38fc3243d1a1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -273,7 +273,7 @@ CPU POOLS
 M:	Juergen Gross <jgross@suse.com>
 M:	Dario Faggioli <dfaggioli@suse.com>
 S:	Supported
-F:	xen/common/sched/cpupool.c
+F:	xen/common/sched/*cpupool.c
 
 DEVICE TREE
 M:	Stefano Stabellini <sstabellini@kernel.org>
diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
new file mode 100644
index 000000000000..1f640d680317
--- /dev/null
+++ b/docs/misc/arm/device-tree/cpupools.txt
@@ -0,0 +1,140 @@
+Boot time cpupools
+==================
+
+When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to
+create cpupools during boot phase by specifying them in the device tree.
+ACPI is not supported for this feature.
+
+Cpupools specification nodes shall be direct childs of /chosen node.
+Each cpupool node contains the following properties:
+
+- compatible (mandatory)
+
+    Must always include the compatiblity string: "xen,cpupool".
+
+- cpupool-cpus (mandatory)
+
+    Must be a list of device tree phandle to nodes describing cpus (e.g. having
+    device_type = "cpu"), it can't be empty.
+
+- cpupool-sched (optional)
+
+    Must be a string having the name of a Xen scheduler. Check the sched=<...>
+    boot argument for allowed values [1]. When this property is omitted, the Xen
+    default scheduler will be used.
+
+
+Constraints
+===========
+
+If no cpupools are specified, all cpus will be assigned to one cpupool
+implicitly created (Pool-0).
+
+If cpupools node are specified, but not every cpu brought up by Xen is assigned,
+all the not assigned cpu will be assigned to an additional cpupool.
+
+If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
+stop.
+
+The boot cpu must be assigned to Pool-0, so the cpupool containing that core
+will become Pool-0 automatically.
+
+
+Examples
+========
+
+A system having two types of core, the following device tree specification will
+instruct Xen to have two cpupools:
+
+- The cpupool described by node cpupool_a will have 4 cpus assigned.
+- The cpupool described by node cpupool_b will have 2 cpus assigned.
+
+The following example can work only if hmp-unsafe=1 is passed to Xen boot
+arguments, otherwise not all cores will be brought up by Xen and the cpupool
+creation process will stop Xen.
+
+
+a72_1: cpu@0 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x0>;
+        device_type = "cpu";
+        [...]
+};
+
+a72_2: cpu@1 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x1>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_1: cpu@100 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x100>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_2: cpu@101 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x101>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_3: cpu@102 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x102>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_4: cpu@103 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x103>;
+        device_type = "cpu";
+        [...]
+};
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a53_1 &a53_2 &a53_3 &a53_4>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "credit2";
+    };
+
+    [...]
+
+};
+
+
+A system having the cpupools specification below will instruct Xen to have three
+cpupools:
+
+- The cpupool described by node cpupool_a will have 2 cpus assigned.
+- The cpupool described by node cpupool_b will have 2 cpus assigned.
+- An additional cpupool will be created, having 2 cpus assigned (created by Xen
+  with all the unassigned cpus a53_3 and a53_4).
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a53_1 &a53_2>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "null";
+    };
+
+    [...]
+
+};
+
+[1] docs/misc/xen-command-line.pandoc
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 1472ca4972b0..5df5c8ffb8ba 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -73,7 +73,10 @@ custom_param("dom0_mem", parse_dom0_mem);
 unsigned int __init dom0_max_vcpus(void)
 {
     if ( opt_dom0_max_vcpus == 0 )
-        opt_dom0_max_vcpus = num_online_cpus();
+    {
+        ASSERT(cpupool0);
+        opt_dom0_max_vcpus = cpumask_weight(cpupool_valid_cpus(cpupool0));
+    }
     if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
         opt_dom0_max_vcpus = MAX_VIRT_CPUS;
 
diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h
index af5a2fe65266..83c0cd69767b 100644
--- a/xen/arch/arm/include/asm/smp.h
+++ b/xen/arch/arm/include/asm/smp.h
@@ -34,6 +34,9 @@ extern void init_secondary(void);
 extern void smp_init_cpus(void);
 extern void smp_clear_cpu_maps (void);
 extern int smp_get_max_cpus (void);
+
+#define cpu_physical_id(cpu) cpu_logical_map(cpu)
+
 #endif
 
 /*
diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
index 3d9f9214b8cc..b2ef0c99a3f8 100644
--- a/xen/common/sched/Kconfig
+++ b/xen/common/sched/Kconfig
@@ -64,3 +64,10 @@ config SCHED_DEFAULT
 	default "credit2"
 
 endmenu
+
+config BOOT_TIME_CPUPOOLS
+	bool "Create cpupools at boot time"
+	depends on HAS_DEVICE_TREE
+	help
+	  Creates cpupools during boot time and assigns cpus to them. Cpupools
+	  options can be specified in the device tree.
diff --git a/xen/common/sched/Makefile b/xen/common/sched/Makefile
index 3537f2a68d69..697bd54bfe93 100644
--- a/xen/common/sched/Makefile
+++ b/xen/common/sched/Makefile
@@ -1,3 +1,4 @@
+obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot-cpupool.init.o
 obj-y += cpupool.o
 obj-$(CONFIG_SCHED_ARINC653) += arinc653.o
 obj-$(CONFIG_SCHED_CREDIT) += credit.o
diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c
new file mode 100644
index 000000000000..9429a5025fc4
--- /dev/null
+++ b/xen/common/sched/boot-cpupool.c
@@ -0,0 +1,207 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * xen/common/boot_cpupools.c
+ *
+ * Code to create cpupools at boot time.
+ *
+ * Copyright (C) 2022 Arm Ltd.
+ */
+
+#include <xen/sched.h>
+#include <asm/acpi.h>
+
+/*
+ * pool_cpu_map:   Index is logical cpu number, content is cpupool id, (-1) for
+ *                 unassigned.
+ * pool_sched_map: Index is cpupool id, content is scheduler id, (-1) for
+ *                 unassigned.
+ */
+static int __initdata pool_cpu_map[NR_CPUS]   = { [0 ... NR_CPUS-1] = -1 };
+static int __initdata pool_sched_map[NR_CPUS] = { [0 ... NR_CPUS-1] = -1 };
+static unsigned int __initdata next_pool_id;
+
+#define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
+#define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
+
+static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
+{
+    unsigned int i;
+
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpu_physical_id(i) == hwid )
+            return i;
+    }
+
+    return -1;
+}
+
+static int __init
+get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
+{
+    int cpu_num;
+    const __be32 *prop;
+    unsigned int cpu_reg;
+
+    prop = dt_get_property(cpu_node, "reg", NULL);
+    if ( !prop )
+        return BTCPUPOOLS_DT_NODE_NO_REG;
+
+    cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node));
+
+    cpu_num = get_logical_cpu_from_hw_id(cpu_reg);
+    if ( cpu_num < 0 )
+        return BTCPUPOOLS_DT_NODE_NO_LOG_CPU;
+
+    return cpu_num;
+}
+
+static int __init check_and_get_sched_id(const char* scheduler_name)
+{
+    int sched_id = sched_get_id_by_name(scheduler_name);
+
+    if ( sched_id < 0 )
+        panic("Scheduler %s does not exists!\n", scheduler_name);
+
+    return sched_id;
+}
+
+void __init btcpupools_dtb_parse(void)
+{
+    const struct dt_device_node *chosen, *node;
+
+    if ( !acpi_disabled )
+        return;
+
+    chosen = dt_find_node_by_path("/chosen");
+    if ( !chosen )
+        panic("/chosen missing. Boot time cpupools can't be parsed from DT.\n");
+
+    dt_for_each_child_node(chosen, node)
+    {
+        const struct dt_device_node *phandle_node;
+        int sched_id = -1;
+        const char* scheduler_name;
+        unsigned int i = 0;
+
+        if ( !dt_device_is_compatible(node, "xen,cpupool") )
+            continue;
+
+        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) )
+            sched_id = check_and_get_sched_id(scheduler_name);
+
+        phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
+        if ( !phandle_node )
+            panic("Missing or empty cpupool-cpus property!\n");
+
+        while ( phandle_node )
+        {
+            int cpu_num;
+
+            cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
+
+            if ( cpu_num < 0 )
+                panic("Error retrieving logical cpu from node %s (%d)\n",
+                      dt_node_name(node), cpu_num);
+
+            if ( pool_cpu_map[cpu_num] != -1 )
+                panic("Logical cpu %d already added to a cpupool!\n", cpu_num);
+
+            pool_cpu_map[cpu_num] = next_pool_id;
+
+            phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++);
+        }
+
+        /* Save scheduler choice for this cpupool id */
+        pool_sched_map[next_pool_id] = sched_id;
+
+        /* Let Xen generate pool ids */
+        next_pool_id++;
+    }
+}
+
+void __init btcpupools_allocate_pools(void)
+{
+    unsigned int i;
+    bool add_extra_cpupool = false;
+    int swap_id = -1;
+
+    /*
+     * If there are no cpupools, the value of next_pool_id is zero, so the code
+     * below will assign every cpu to cpupool0 as the default behavior.
+     * When there are cpupools, the code below is assigning all the not
+     * assigned cpu to a new pool (next_pool_id value is the last id + 1).
+     * In the same loop we check if there is any assigned cpu that is not
+     * online.
+     */
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpumask_test_cpu(i, &cpu_online_map) )
+        {
+            /* Unassigned cpu gets next_pool_id pool id value */
+            if ( pool_cpu_map[i] < 0 )
+            {
+                pool_cpu_map[i] = next_pool_id;
+                add_extra_cpupool = true;
+            }
+
+            /*
+             * Cpu0 must be in cpupool0, otherwise some operations like moving
+             * cpus between cpupools, cpu hotplug, destroying cpupools, shutdown
+             * of the host, might not work in a sane way.
+             */
+            if ( !i && (pool_cpu_map[0] != 0) )
+                swap_id = pool_cpu_map[0];
+
+            if ( swap_id != -1 )
+            {
+                if ( pool_cpu_map[i] == swap_id )
+                    pool_cpu_map[i] = 0;
+                else if ( pool_cpu_map[i] == 0 )
+                    pool_cpu_map[i] = swap_id;
+            }
+        }
+        else
+        {
+            if ( pool_cpu_map[i] >= 0 )
+                panic("Pool-%d contains cpu%u that is not online!\n",
+                      pool_cpu_map[i], i);
+        }
+    }
+
+    /* A swap happened, swap schedulers between cpupool id 0 and the other */
+    if ( swap_id != -1 )
+    {
+        int swap_sched = pool_sched_map[swap_id];
+
+        pool_sched_map[swap_id] = pool_sched_map[0];
+        pool_sched_map[0] = swap_sched;
+    }
+
+    if ( add_extra_cpupool )
+        next_pool_id++;
+
+    /* Create cpupools with selected schedulers */
+    for ( i = 0; i < next_pool_id; i++ )
+        cpupool_create_pool(i, pool_sched_map[i]);
+}
+
+unsigned int __init btcpupools_get_cpupool_id(unsigned int cpu)
+{
+    ASSERT((cpu < NR_CPUS) && (pool_cpu_map[cpu] >= 0));
+
+    printk(XENLOG_INFO "Logical CPU %u in Pool-%d (Scheduler id: %d).\n",
+           cpu, pool_cpu_map[cpu], pool_sched_map[pool_cpu_map[cpu]]);
+
+    return pool_cpu_map[cpu];
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 89a891af7076..86a175f99cd5 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1247,12 +1247,22 @@ static int __init cf_check cpupool_init(void)
     cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
+    btcpupools_dtb_parse();
+
+    btcpupools_allocate_pools();
+
     spin_lock(&cpupool_lock);
 
     cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
 
     for_each_cpu ( cpu, &cpupool_free_cpus )
-        cpupool_assign_cpu_locked(cpupool0, cpu);
+    {
+        unsigned int pool_id = btcpupools_get_cpupool_id(cpu);
+        struct cpupool *pool = cpupool_find_by_id(pool_id);
+
+        ASSERT(pool);
+        cpupool_assign_cpu_locked(pool, cpu);
+    }
 
     spin_unlock(&cpupool_lock);
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 4442a1940c25..74b3aae10b94 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1184,6 +1184,20 @@ extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 
+#ifdef CONFIG_BOOT_TIME_CPUPOOLS
+void btcpupools_allocate_pools(void);
+unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
+void btcpupools_dtb_parse(void);
+
+#else /* !CONFIG_BOOT_TIME_CPUPOOLS */
+static inline void btcpupools_allocate_pools(void) {}
+static inline void btcpupools_dtb_parse(void) {}
+static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
+{
+    return 0;
+}
+#endif
+
 #endif /* __SCHED_H__ */
 
 /*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:17:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:17:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309843.526333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzp-0002nn-Lv; Thu, 21 Apr 2022 08:17:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309843.526333; Thu, 21 Apr 2022 08:17:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzp-0002ng-Gh; Thu, 21 Apr 2022 08:17:01 +0000
Received: by outflank-mailman (input) for mailman id 309843;
 Thu, 21 Apr 2022 08:16:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=foL4=U7=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nhRzn-0002nP-Np
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:16:59 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 68a05d1d-c14b-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 10:16:57 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDD921480;
 Thu, 21 Apr 2022 01:16:55 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 60D153F73B;
 Thu, 21 Apr 2022 01:16:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68a05d1d-c14b-11ec-a405-831a346695d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com
Subject: [PATCH v8 0/7] Boot time cpupools
Date: Thu, 21 Apr 2022 09:16:38 +0100
Message-Id: <20220421081645.40235-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

This serie introduces a feature for Xen to create cpu pools at boot time, the
feature is enabled using a configurable that is disabled by default.
The boot time cpupool feature relies on the device tree to describe the cpu
pools.
Another feature is introduced by the serie, the possibility to assign a
dom0less guest to a cpupool at boot time.

Here follows an example, Xen is built with CONFIG_BOOT_TIME_CPUPOOLS=y.

>From the DT:

  [...]

  a72_0: cpu@0 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x0>;
    device_type = "cpu";
    [...]
  };

  a72_1: cpu@1 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x1>;
    device_type = "cpu";
    [...]
  };

  a53_0: cpu@100 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x100>;
    device_type = "cpu";
    [...]
  };

  a53_1: cpu@101 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x101>;
    device_type = "cpu";
    [...]
  };

  a53_2: cpu@102 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x102>;
    device_type = "cpu";
    [...]
  };

  a53_3: cpu@103 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x103>;
    device_type = "cpu";
    [...]
  };

  chosen {
    #size-cells = <0x1>;
    #address-cells = <0x1>;
    xen,dom0-bootargs = "...";
    xen,xen-bootargs = "...";

    cpupool0 {
      compatible = "xen,cpupool";
      cpupool-cpus = <&a72_0 &a72_1>;
      cpupool-sched = "credit2";
    };

    cp1: cpupool1 {
      compatible = "xen,cpupool";
      cpupool-cpus = <&a53_0 &a53_1 &a53_2 &a53_3>;
      cpupool-sched = "null";
    };

    module@0 {
      reg = <0x80080000 0x1300000>;
      compatible = "multiboot,module";
    };

    domU1 {
      #size-cells = <0x1>;
      #address-cells = <0x1>;
      compatible = "xen,domain";
      cpus = <1>;
      memory = <0 0xC0000>;
      vpl011;
      domain-cpupool = <&cp1>;

      module@92000000 {
        compatible = "multiboot,kernel", "multiboot,module";
        reg = <0x92000000 0x1ffffff>;
        bootargs = "...";
      };
    };
  };

  [...]

The example DT is instructing Xen to have two cpu pools, one having two phisical
cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the
null scheduler and from the /chosen node we can see that a dom0less guest will
be started on that cpu pool.

In this particular case Xen must boot with different type of cpus, so the
boot argument hmp_unsafe must be enabled.

Luca Fancellu (7):
  tools/cpupools: Give a name to unnamed cpupools
  xen/sched: create public function for cpupools creation
  xen/sched: retrieve scheduler id by name
  xen/cpupool: Create different cpupools at boot time
  xen/cpupool: Don't allow removing cpu0 from cpupool0
  arm/dom0less: assign dom0less guests to cpupools
  xen/cpupool: Allow cpupool0 to use different scheduler

 MAINTAINERS                            |   2 +-
 docs/misc/arm/device-tree/booting.txt  |   5 +
 docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++
 tools/helpers/xen-init-dom0.c          |  37 +++-
 tools/libs/light/libxl_utils.c         |   3 +-
 xen/arch/arm/domain_build.c            |  19 +-
 xen/arch/arm/include/asm/smp.h         |   3 +
 xen/common/domain.c                    |   2 +-
 xen/common/sched/Kconfig               |   7 +
 xen/common/sched/Makefile              |   1 +
 xen/common/sched/boot-cpupool.c        | 234 +++++++++++++++++++++++++
 xen/common/sched/core.c                |  40 +++--
 xen/common/sched/cpupool.c             |  43 ++++-
 xen/include/public/domctl.h            |   5 +-
 xen/include/xen/sched.h                |  53 ++++++
 15 files changed, 563 insertions(+), 31 deletions(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/common/sched/boot-cpupool.c

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:17:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:17:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309845.526345 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzq-0002z4-B0; Thu, 21 Apr 2022 08:17:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309845.526345; Thu, 21 Apr 2022 08:17:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzq-0002v1-3h; Thu, 21 Apr 2022 08:17:02 +0000
Received: by outflank-mailman (input) for mailman id 309845;
 Thu, 21 Apr 2022 08:17:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=foL4=U7=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nhRzo-0002nQ-EA
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:17:00 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 68c397f7-c14b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 10:16:56 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 84B4E1477;
 Thu, 21 Apr 2022 01:16:57 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB5B13F73B;
 Thu, 21 Apr 2022 01:16:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68c397f7-c14b-11ec-8fbf-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com
Subject: [PATCH v8 2/7] xen/sched: create public function for cpupools creation
Date: Thu, 21 Apr 2022 09:16:40 +0100
Message-Id: <20220421081645.40235-3-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220421081645.40235-1-luca.fancellu@arm.com>
References: <20220421081645.40235-1-luca.fancellu@arm.com>

Create new public function to create cpupools, can take as parameter
the scheduler id or a negative value that means the default Xen
scheduler will be used.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v8:
- no changes
Changes in v7:
- no changes
Changes in v6:
- add R-by
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- Fixed comment (Andrew)
Changes in v2:
- cpupool_create_pool doesn't check anymore for pool id uniqueness
  before calling cpupool_create. Modified commit message accordingly
---
 xen/common/sched/cpupool.c | 15 +++++++++++++++
 xen/include/xen/sched.h    | 16 ++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index a6da4970506a..89a891af7076 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1219,6 +1219,21 @@ static void cpupool_hypfs_init(void)
 
 #endif /* CONFIG_HYPFS */
 
+struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id)
+{
+    struct cpupool *pool;
+
+    if ( sched_id < 0 )
+        sched_id = scheduler_get_default()->sched_id;
+
+    pool = cpupool_create(pool_id, sched_id);
+
+    BUG_ON(IS_ERR(pool));
+    cpupool_put(pool);
+
+    return pool;
+}
+
 static int __init cf_check cpupool_init(void)
 {
     unsigned int cpu;
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index ed8539f6d297..0164db996b8b 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1153,6 +1153,22 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c);
 int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op);
 unsigned int cpupool_get_id(const struct domain *d);
 const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool);
+
+/*
+ * cpupool_create_pool - Creates a cpupool
+ * @pool_id: id of the pool to be created
+ * @sched_id: id of the scheduler to be used for the pool
+ *
+ * Creates a cpupool with pool_id id.
+ * The sched_id parameter identifies the scheduler to be used, if it is
+ * negative, the default scheduler of Xen will be used.
+ *
+ * returns:
+ *     pointer to the struct cpupool just created, or Xen will panic in case of
+ *     error
+ */
+struct cpupool *cpupool_create_pool(unsigned int pool_id, int sched_id);
+
 extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:17:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:17:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309847.526370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzs-0003en-3U; Thu, 21 Apr 2022 08:17:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309847.526370; Thu, 21 Apr 2022 08:17:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzr-0003bt-US; Thu, 21 Apr 2022 08:17:03 +0000
Received: by outflank-mailman (input) for mailman id 309847;
 Thu, 21 Apr 2022 08:17:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=foL4=U7=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nhRzq-0002nQ-EG
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:17:02 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6a4101c6-c14b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 10:16:59 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 093C81515;
 Thu, 21 Apr 2022 01:17:00 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 72C3E3F73B;
 Thu, 21 Apr 2022 01:16:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a4101c6-c14b-11ec-8fbf-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com
Subject: [PATCH v8 5/7] xen/cpupool: Don't allow removing cpu0 from cpupool0
Date: Thu, 21 Apr 2022 09:16:43 +0100
Message-Id: <20220421081645.40235-6-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220421081645.40235-1-luca.fancellu@arm.com>
References: <20220421081645.40235-1-luca.fancellu@arm.com>

Cpu0 must remain in cpupool0, otherwise some operations like moving cpus
between cpupools, cpu hotplug, destroying cpupools, shutdown of the host,
might not work in a sane way.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v8:
- Add R-by (Juergen)
Changes in v7:
- new patch
---
 xen/common/sched/cpupool.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 86a175f99cd5..0a93bcc631bf 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -572,6 +572,7 @@ static long cf_check cpupool_unassign_cpu_helper(void *info)
  * possible failures:
  * - last cpu and still active domains in cpupool
  * - cpu just being unplugged
+ * - Attempt to remove boot cpu from cpupool0
  */
 static int cpupool_unassign_cpu(struct cpupool *c, unsigned int cpu)
 {
@@ -582,7 +583,12 @@ static int cpupool_unassign_cpu(struct cpupool *c, unsigned int cpu)
     debugtrace_printk("cpupool_unassign_cpu(pool=%u,cpu=%d)\n",
                       c->cpupool_id, cpu);
 
-    if ( !cpu_online(cpu) )
+    /*
+     * Cpu0 must remain in cpupool0, otherwise some operations like moving cpus
+     * between cpupools, cpu hotplug, destroying cpupools, shutdown of the host,
+     * might not work in a sane way.
+     */
+    if ( (!c->cpupool_id && !cpu) || !cpu_online(cpu) )
         return -EINVAL;
 
     master_cpu = sched_get_resource_cpu(cpu);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:17:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:17:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309849.526398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzu-0004OE-Vk; Thu, 21 Apr 2022 08:17:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309849.526398; Thu, 21 Apr 2022 08:17:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzu-0004NA-OA; Thu, 21 Apr 2022 08:17:06 +0000
Received: by outflank-mailman (input) for mailman id 309849;
 Thu, 21 Apr 2022 08:17:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=foL4=U7=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nhRzs-0002nQ-Dt
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:17:04 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6ab33383-c14b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 10:17:00 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAE671516;
 Thu, 21 Apr 2022 01:17:00 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CB213F73B;
 Thu, 21 Apr 2022 01:17:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ab33383-c14b-11ec-8fbf-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com
Subject: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools
Date: Thu, 21 Apr 2022 09:16:44 +0100
Message-Id: <20220421081645.40235-7-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220421081645.40235-1-luca.fancellu@arm.com>
References: <20220421081645.40235-1-luca.fancellu@arm.com>

Introduce domain-cpupool property of a xen,domain device tree node,
that specifies the cpupool device tree handle of a xen,cpupool node
that identifies a cpupool created at boot time where the guest will
be assigned on creation.

Add member to the xen_domctl_createdomain public interface so the
XEN_DOMCTL_INTERFACE_VERSION version is bumped.

Add public function to retrieve a pool id from the device tree
cpupool node.

Update documentation about the property.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes in v8:
- no changes
Changes in v7:
- Add comment for cpupool_id struct member. (Jan)
Changes in v6:
- no changes
Changes in v5:
- no changes
Changes in v4:
- no changes
- add R-by
Changes in v3:
- Use explicitely sized integer for struct xen_domctl_createdomain
  cpupool_id member. (Stefano)
- Changed code due to previous commit code changes
Changes in v2:
- Moved cpupool_id from arch specific to common part (Juergen)
- Implemented functions to retrieve the cpupool id from the
  cpupool dtb node.
---
 docs/misc/arm/device-tree/booting.txt |  5 +++++
 xen/arch/arm/domain_build.c           | 14 +++++++++++++-
 xen/common/domain.c                   |  2 +-
 xen/common/sched/boot-cpupool.c       | 24 ++++++++++++++++++++++++
 xen/include/public/domctl.h           |  5 ++++-
 xen/include/xen/sched.h               |  9 +++++++++
 6 files changed, 56 insertions(+), 3 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index a94125394e35..7b4a29a2c293 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -188,6 +188,11 @@ with the following properties:
     An empty property to request the memory of the domain to be
     direct-map (guest physical address == physical address).
 
+- domain-cpupool
+
+    Optional. Handle to a xen,cpupool device tree node that identifies the
+    cpupool where the guest will be started at boot.
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 5df5c8ffb8ba..aa777741bdd0 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3174,7 +3174,8 @@ static int __init construct_domU(struct domain *d,
 void __init create_domUs(void)
 {
     struct dt_device_node *node;
-    const struct dt_device_node *chosen = dt_find_node_by_path("/chosen");
+    const struct dt_device_node *cpupool_node,
+                                *chosen = dt_find_node_by_path("/chosen");
 
     BUG_ON(chosen == NULL);
     dt_for_each_child_node(chosen, node)
@@ -3243,6 +3244,17 @@ void __init create_domUs(void)
                                          vpl011_virq - 32 + 1);
         }
 
+        /* Get the optional property domain-cpupool */
+        cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0);
+        if ( cpupool_node )
+        {
+            int pool_id = btcpupools_get_domain_pool_id(cpupool_node);
+            if ( pool_id < 0 )
+                panic("Error getting cpupool id from domain-cpupool (%d)\n",
+                      pool_id);
+            d_cfg.cpupool_id = pool_id;
+        }
+
         /*
          * The variable max_init_domid is initialized with zero, so here it's
          * very important to use the pre-increment operator to call
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 351029f8b239..0827400f4f49 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -698,7 +698,7 @@ struct domain *domain_create(domid_t domid,
         if ( !d->pbuf )
             goto fail;
 
-        if ( (err = sched_init_domain(d, 0)) != 0 )
+        if ( (err = sched_init_domain(d, config->cpupool_id)) != 0 )
             goto fail;
 
         if ( (err = late_hwdom_init(d)) != 0 )
diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c
index 9429a5025fc4..240bae4cebb8 100644
--- a/xen/common/sched/boot-cpupool.c
+++ b/xen/common/sched/boot-cpupool.c
@@ -22,6 +22,8 @@ static unsigned int __initdata next_pool_id;
 
 #define BTCPUPOOLS_DT_NODE_NO_REG     (-1)
 #define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2)
+#define BTCPUPOOLS_DT_WRONG_NODE      (-3)
+#define BTCPUPOOLS_DT_CORRUPTED_NODE  (-4)
 
 static int __init get_logical_cpu_from_hw_id(unsigned int hwid)
 {
@@ -56,6 +58,28 @@ get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node)
     return cpu_num;
 }
 
+int __init btcpupools_get_domain_pool_id(const struct dt_device_node *node)
+{
+    const struct dt_device_node *phandle_node;
+    int cpu_num;
+
+    if ( !dt_device_is_compatible(node, "xen,cpupool") )
+        return BTCPUPOOLS_DT_WRONG_NODE;
+    /*
+     * Get first cpu listed in the cpupool, from its reg it's possible to
+     * retrieve the cpupool id.
+     */
+    phandle_node = dt_parse_phandle(node, "cpupool-cpus", 0);
+    if ( !phandle_node )
+        return BTCPUPOOLS_DT_CORRUPTED_NODE;
+
+    cpu_num = get_logical_cpu_from_cpu_node(phandle_node);
+    if ( cpu_num < 0 )
+        return cpu_num;
+
+    return pool_cpu_map[cpu_num];
+}
+
 static int __init check_and_get_sched_id(const char* scheduler_name)
 {
     int sched_id = sched_get_id_by_name(scheduler_name);
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0aa..84e75829b980 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
@@ -106,6 +106,9 @@ struct xen_domctl_createdomain {
     /* Per-vCPU buffer size in bytes.  0 to disable. */
     uint32_t vmtrace_size;
 
+    /* CPU pool to use; specify 0 or a specific existing pool */
+    uint32_t cpupool_id;
+
     struct xen_arch_domainconfig arch;
 };
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 74b3aae10b94..32d2a6294b6d 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1188,6 +1188,7 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 void btcpupools_allocate_pools(void);
 unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
 void btcpupools_dtb_parse(void);
+int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
 
 #else /* !CONFIG_BOOT_TIME_CPUPOOLS */
 static inline void btcpupools_allocate_pools(void) {}
@@ -1196,6 +1197,14 @@ static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
 {
     return 0;
 }
+#ifdef CONFIG_HAS_DEVICE_TREE
+static inline int
+btcpupools_get_domain_pool_id(const struct dt_device_node *node)
+{
+    return 0;
+}
+#endif
+
 #endif
 
 #endif /* __SCHED_H__ */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:17:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:17:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309850.526404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzv-0004Sx-FP; Thu, 21 Apr 2022 08:17:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309850.526404; Thu, 21 Apr 2022 08:17:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhRzv-0004Rg-5O; Thu, 21 Apr 2022 08:17:07 +0000
Received: by outflank-mailman (input) for mailman id 309850;
 Thu, 21 Apr 2022 08:17:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=foL4=U7=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nhRzt-0002nQ-EE
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:17:05 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6b23b9d2-c14b-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 10:17:00 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 917381477;
 Thu, 21 Apr 2022 01:17:01 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07CAF3F73B;
 Thu, 21 Apr 2022 01:17:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b23b9d2-c14b-11ec-8fbf-03012f2f19d4
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com
Subject: [PATCH v8 7/7] xen/cpupool: Allow cpupool0 to use different scheduler
Date: Thu, 21 Apr 2022 09:16:45 +0100
Message-Id: <20220421081645.40235-8-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220421081645.40235-1-luca.fancellu@arm.com>
References: <20220421081645.40235-1-luca.fancellu@arm.com>

Currently cpupool0 can use only the default scheduler, and
cpupool_create has an hardcoded behavior when creating the pool 0
that doesn't allocate new memory for the scheduler, but uses the
default scheduler structure in memory.

With this commit it is possible to allocate a different scheduler for
the cpupool0 when using the boot time cpupool.
To achieve this the hardcoded behavior in cpupool_create is removed
and the cpupool0 creation is moved.

When compiling without boot time cpupools enabled, the current
behavior is maintained (except that cpupool0 scheduler memory will be
allocated).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v8:
- no changes
Changes in v7:
- no changes
Changes in v6:
- Add R-by
Changes in v5:
- no changes
Changes in v4:
- no changes
Changes in v3:
- fix typo in commit message (Juergen)
- rebase changes
Changes in v2:
- new patch
---
 xen/common/sched/boot-cpupool.c | 5 ++++-
 xen/common/sched/cpupool.c      | 8 +-------
 xen/include/xen/sched.h         | 5 ++++-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c
index 240bae4cebb8..5955e6f9a98b 100644
--- a/xen/common/sched/boot-cpupool.c
+++ b/xen/common/sched/boot-cpupool.c
@@ -205,8 +205,11 @@ void __init btcpupools_allocate_pools(void)
     if ( add_extra_cpupool )
         next_pool_id++;
 
+    /* Keep track of cpupool id 0 with the global cpupool0 */
+    cpupool0 = cpupool_create_pool(0, pool_sched_map[0]);
+
     /* Create cpupools with selected schedulers */
-    for ( i = 0; i < next_pool_id; i++ )
+    for ( i = 1; i < next_pool_id; i++ )
         cpupool_create_pool(i, pool_sched_map[i]);
 }
 
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 0a93bcc631bf..f6e3d97e5288 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -312,10 +312,7 @@ static struct cpupool *cpupool_create(unsigned int poolid,
         c->cpupool_id = q->cpupool_id + 1;
     }
 
-    if ( poolid == 0 )
-        c->sched = scheduler_get_default();
-    else
-        c->sched = scheduler_alloc(sched_id);
+    c->sched = scheduler_alloc(sched_id);
     if ( IS_ERR(c->sched) )
     {
         ret = PTR_ERR(c->sched);
@@ -1248,9 +1245,6 @@ static int __init cf_check cpupool_init(void)
 
     cpupool_hypfs_init();
 
-    cpupool0 = cpupool_create(0, 0);
-    BUG_ON(IS_ERR(cpupool0));
-    cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
     btcpupools_dtb_parse();
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 32d2a6294b6d..6040fa3b3830 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1191,7 +1191,10 @@ void btcpupools_dtb_parse(void);
 int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
 
 #else /* !CONFIG_BOOT_TIME_CPUPOOLS */
-static inline void btcpupools_allocate_pools(void) {}
+static inline void btcpupools_allocate_pools(void)
+{
+    cpupool0 = cpupool_create_pool(0, -1);
+}
 static inline void btcpupools_dtb_parse(void) {}
 static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu)
 {
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:33:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:33:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309912.526420 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSFI-0001Mq-5h; Thu, 21 Apr 2022 08:33:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309912.526420; Thu, 21 Apr 2022 08:33:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSFI-0001Mj-2j; Thu, 21 Apr 2022 08:33:00 +0000
Received: by outflank-mailman (input) for mailman id 309912;
 Thu, 21 Apr 2022 08:32:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhSFG-0001Mb-2w
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:32:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 87c3bd10-c14d-11ec-8fbf-03012f2f19d4;
 Thu, 21 Apr 2022 10:32:07 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-_yLNHB5PM7C01kRg5gd3qw-1; Thu, 21 Apr 2022 10:32:55 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR04MB3275.eurprd04.prod.outlook.com (2603:10a6:7:1a::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 08:32:51 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 08:32:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87c3bd10-c14d-11ec-8fbf-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650529976;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qh8JA2ktFZmnt2DgV9E2856/BRxduDPAtM4hPu9teN8=;
	b=hgjkgRVhopyDzpy2S0ii1zNzanniXrg1Eo4nqlqiXuLsWLpNp9JHc79/gBiOXT6xdfxMwb
	It0IM6SZKAXpGoTYHeGnWbxKzEf0jYFQbNZ1dtwTDA0paYJjqUzSpAGfaA64iAKcuWr1+f
	/b2pGuc8V2197si9EMJpcaEtMstVHQ0=
X-MC-Unique: _yLNHB5PM7C01kRg5gd3qw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A6Yz4Ahj/xULAU3xYkvR5LjlrwHIsP6pbcdQZsShsGF8R5y9JtfJbFbdB48T80HdtD1MGl6BNflcSbEZBZxc03bOxzTdOtIttw4U52vcRNdOGKbW4ra88/nQvwYEqt5AGZLGSSQ5HQrynW3VJ73IRPyDnMi91Pkeiz0McSa1A9lJbBO5syI49r3oZZOg/TzVafG0WGdJ5k19ZQWZOmmenyFkmBf0bCahBwBcaG8vq0TGQl329KAoRniFub1Pi+TmedaBtAABNcHEoRHUW7zUxqjyEexdeTQ4QJAV/LQL0YBGCOu5IEu09t262/DFKstuPnlmoITs+bKuSJnoVKCybg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wJPNkTbujZUJw7XP1mTklYVLa7q+376OQFRedGA2RnM=;
 b=aKZH21+Q1Tx46g19++qJtc3YXOUWF6DIBexWMiA6dca23dijyXDdjVDQt3W6SusheNdu5gWDHI6ski3U9Sjd+38T2LkE3LBhWA10XYnb3KJKeWQteG9ubw6Zav0wU8FA+JgXlGcRwLx865dr/62I2XmnvMskVrXcZtmhVBw3+TPrxwZstQbH13j6XK9T182mj5G0RaTTbqbV+j04KLKBIktlGwyBP8D8r0ZR101XFr1E6ASgqtD64/Vq5f0eAFg1HosnFeTaAUotSEd0BFRTtPSJrUizcu+sfaq46/gEZHQ9FypcbzsRyw4i1y5F+4aU1zcSXT0oIblLkVCFv3DUrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7a3dcddf-9632-8d4a-7d1a-6cc6e5fe8844@suse.com>
Date: Thu, 21 Apr 2022 10:32:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: Ranconfig failure between VT-d and HVM
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: xen-devel <xen-devel@lists.xenproject.org>
References: <9537f2bf-981c-d4ac-d41d-ab59f7d7ab2c@citrix.com>
 <4095a567-86aa-8311-ed92-730348ab43d3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4095a567-86aa-8311-ed92-730348ab43d3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0111.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a31d5dcb-d3ca-4a35-bd05-08da237185f3
X-MS-TrafficTypeDiagnostic: HE1PR04MB3275:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR04MB32756F36B8528E199F7E8581B3F49@HE1PR04MB3275.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4vdr8ZJnHyA29/oKsA6zQXUb+RRSSI+Z8mcJMYka01phGNZwPw1AkFurR7k2kcy8lr5zQmY2mbOKEL2fGU8081mQ9M2R27PoOGQQeeF/nUHeX3RTs3JEYYUlGc8GwQVc3VLFp/lwuKzP/GUOcR7op6TPyNs2STqcU8Qi6FQx0OvdF/N4r7/4liD3PB+Fek1au/oHXQ/w+jJSKAMo/swzDJsxcaevyQZbvDf1hQlUZ+yGC/gDKZlbSqsNYONpD1oVmRnvybd+aEKVE29Kcl5L6kdwg3KCY/szsfE+IMxFqTOFG41VQhRYIL5Uc0aQwCZPvK6VIb/iVouQO3fKa255agE5ocRHhCRV3hNf+RaqreHdqLFhFwWEVyWTWHw85r9jhvNrxHX1PT88EvivhUK+MbR2h/a/Fmuu4h4QFTdizo+xQDcj6WMQh284qIsWJnPMhGUtvOU023JMw9IDdiUVimSJfbEDFjtSjZ/VLS7uRpYapguhofLezVxJRNETHa9aLCsy0Zh30I1MyoP97ajW0oRMT3zD48GTgCyUPSCegOGr0Z7g7kIJ1l4FBhnF/KH/oEq8pZ6VUMhG7GIwUlmjIzE60xbzfUF2gz2tNVTHeFihXUZ9b6S7+2hK982+7zHNL4fERpoetQyZ8TgOukhClICxYoUsWtdlejdt7bIEoLakzYB9Vg1DWSCbC0Ojsx6sOYBoixoigt48wQ0ygZF58z8IPDGB/cpSacvJ0fK2snJVdI4kuV3+bfr9x6HXzoFw11uhXu14tHOAKOjGP1yepLAq3bKzX6UIN3cFIsFl8L+neeEFDVRkc3CrKX6e6kw4AqeyMpyJZZWu4YX0ay4FUw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(66946007)(26005)(6512007)(66476007)(6506007)(86362001)(508600001)(38100700002)(186003)(2616005)(4326008)(8676002)(5660300002)(966005)(53546011)(31696002)(6916009)(8936002)(2906002)(31686004)(66556008)(36756003)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JhmY+AS4zwKKRHrttQflH40CBfhB6hldFiDU7OJeQumvE82l2pqBCE/9bD9W?=
 =?us-ascii?Q?4fiV0kLAebu8ngdCXsG22s7eF0wu3qsXKGRV5mNlP2z4TBRkoOQUpt1Bhte/?=
 =?us-ascii?Q?VPjFmlH8//Mz/sFPq+K7G9L0nmD+2bMwQ26M411QbACvmcMiMP3x+h7lmR5a?=
 =?us-ascii?Q?Bb2aoyFJWorBpxV9LekxvVIi0btbmekFJj1ABT0qrgipc1ZX//PMfIoYnGTh?=
 =?us-ascii?Q?7gwAYnN9ayZ8JjY/T1caRcjD8I8dgCZr46VG1i58m2hQI7tRgJfg7JfnzkVH?=
 =?us-ascii?Q?/+ChjlMJVwQKGpoUM5FchZAo4MWqGAGVyoSOA8trlQqN2OjxRbDaiOdQhOXx?=
 =?us-ascii?Q?4noQEUW2KUJ43nmddzALU+uBrvUXrrf7wKNMn7GOkmU/GVJSzNQuJl/dCuGc?=
 =?us-ascii?Q?7TGivcGPMBmJ2yqS3+vk264OUO161wo2fuF+ELxCo1rM7sKKGzQO4biKUoqy?=
 =?us-ascii?Q?oPXJZ3IVtxkNzcKYNttfHb/+djF6vWVVhSEAJNTllJUoK+rMmpsbFSIoCfsN?=
 =?us-ascii?Q?4c6P1brTZpd/lqunxWxS99j2QwMwU0a2uilR98SC8CcUS9RrielONqljcl7K?=
 =?us-ascii?Q?G4qGYJ4ThOQfSl/jorTDT+RfKpWftJXG+RV2wdxw54AE6ZMKmvmtd97/FVzZ?=
 =?us-ascii?Q?rtL8UOrQt83OpOq5/+ovRRdK4g+wGNQSwcbXRZNkYq3wFDQ00N8GVooaq3BM?=
 =?us-ascii?Q?N9aG8+u5FmcIjKT1dulmsHfhZ8KuW5jgXvPixDIhe5lwGddjx72XXDknJJd/?=
 =?us-ascii?Q?In8hwMEhCJ9H/IIjKsjPfqmFHXHxXXApkubVqZ4EjNVlkGP7JhFN0fuvjVqL?=
 =?us-ascii?Q?uzNh0layxfnYmJBhPtQDYLVesTlyLOwI7hsbvQpIW1FE4Q6bUPh0xCkBCoRr?=
 =?us-ascii?Q?8UoyAOD9SzajHNff4R+cygXsVnYrg2tW02hoKMtlRdjgUDRrQ7qolfhKOV+t?=
 =?us-ascii?Q?nqSqDC+QJAMZcBnUEkgWTms2TTCgBF3VJ+TqMRGzznm0bzxNSdjyw0Pw1Agc?=
 =?us-ascii?Q?ltWrJd+HDwLHu41Wtp8qbwjeKfGGSFcl8CRTo8q0DTY0iOiAbrTVhrHe1Jw/?=
 =?us-ascii?Q?sJVZ1SwhxHm8TaQF7V1k1UpQuUFKK5GoIBT6CcP1iXGgVNTM+i6l7xTogR7B?=
 =?us-ascii?Q?XvnFD968x2Nf8AHnOBy4V3pO9tTlthe+MrGKihHJW24OdcdfrTs0S8LinrCN?=
 =?us-ascii?Q?RND4mUoyEgnoNYvZVTwM87dioWRaD4k5FuEjDeEdlG3nBT+xlQYbSNWe75xx?=
 =?us-ascii?Q?p7l81QPERdfcTPPYntJBmnj2bccnGKKWrnVF2BWLaqiaYuGOVzWxfibr85NB?=
 =?us-ascii?Q?Bi/7R7c9ip9LBCBVRycI4xEKxY+LZXT7DyFIScR2W2yR8OTJyEPNDV7YE68G?=
 =?us-ascii?Q?+UveRteUe+QwbqzFx+8bR4xhjdhYRMF7Bc9BRh6PXh7EE6wJfAyFtaDgYiM8?=
 =?us-ascii?Q?1EYdVqPkzIVvHBZZAOavxDrvbxIWBRzxhxOAV3UfiGk5EV/MD0qmVsCp7PaE?=
 =?us-ascii?Q?kt5XAYuvLKmthshoOotQP5DuigfOTjL8hBy9lHYMUlutCcnUic+rtIohoV/d?=
 =?us-ascii?Q?DpCd9qzvorctFZDVgIUryUHUL1awiEcR9Deo+RE5I+fxqfGuHbJX17Bzssh/?=
 =?us-ascii?Q?IaOTngAVz37hkcXbJ902iHss6PMSECqkobysFY/FXdXhWxiWhueX2PNALb/j?=
 =?us-ascii?Q?6zQzUw69e1JA8YQQLCXwD+qM8nox5GJ251cWYSO0454o7y0mkoC0HHUZ9eng?=
 =?us-ascii?Q?fGlURtiKpA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a31d5dcb-d3ca-4a35-bd05-08da237185f3
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 08:32:51.3371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MSaUDOo+4tze/47pBkqtrdzZoq1qKUeuJ8UyJB/Tql4HUxb6qjqTU5VBOTanv1LjNPN/nZm+57zDQyl11F8y5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3275

On 20.04.2022 20:01, Andrew Cooper wrote:
> On 20/04/2022 18:49, Andrew Cooper wrote:
>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/2355562119
>>
>> ld: prelink.o: in function `vtd_setup':
>> drivers/passthrough/vtd/iommu.c:(.init.text+0x219f6): undefined
>> reference to `opt_hap_2mb'
>> drivers/passthrough/vtd/iommu.c:(.init.text+0x219f6): relocation
>> truncated to fit: R_X86_64_PC32 against undefined symbol `opt_hap_2mb'
>> ld: drivers/passthrough/vtd/iommu.c:(.init.text+0x21a23): undefined
>> reference to `opt_hap_1gb'
>> drivers/passthrough/vtd/iommu.c:(.init.text+0x21a23): relocation
>> truncated to fit: R_X86_64_PC32 against undefined symbol `opt_hap_1gb'
>> ld: ./.xen-syms.0: hidden symbol `opt_hap_2mb' isn't defined
>> ld: final link failed: bad value
>> make[3]: *** [arch/x86/Makefile:137: xen-syms] Error 1
>>
>> It's really not clear why this has first show up now.=C2=A0 There has be=
en a
>> huge quantity of noise in Gitlab CI for the past 3 weeks with ARM being
>> offline, but I can't see anything relevant in the large number of IOMMU
>> changes in that period.
>>
>> Anyway, the issue is simple.=C2=A0 It's vtd_ept_page_compatible() in a
>> !CONFIG_HVM build.
>=20
> And just after sending, I realised it's not an IOMMU change.
>=20
> commit c479415610f0448bb07d39185e72ef36e08ebec0
> Author: Jan Beulich <jbeulich@suse.com>
> Date:=C2=A0=C2=A0 Fri Apr 8 13:50:29 2022
>=20
> =C2=A0=C2=A0=C2=A0 x86/P2M: p2m.c is HVM-only
>=20
>=20
> CI disputes the claim.

I'm afraid it can't be this simple, as I've been routinely doing !HVM
build for quite some time. There must be some further interaction,
albeit potentially with not-yet-committed further changes of mine. I'll
investigate.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:35:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:35:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309917.526431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSHT-0001wv-JL; Thu, 21 Apr 2022 08:35:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309917.526431; Thu, 21 Apr 2022 08:35:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSHT-0001wo-G8; Thu, 21 Apr 2022 08:35:15 +0000
Received: by outflank-mailman (input) for mailman id 309917;
 Thu, 21 Apr 2022 08:35:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSHS-0001wc-Bs; Thu, 21 Apr 2022 08:35:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSHS-0003rX-9D; Thu, 21 Apr 2022 08:35:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSHR-0002qw-Ok; Thu, 21 Apr 2022 08:35:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSHR-0002aL-OI; Thu, 21 Apr 2022 08:35:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=O93ueFTgh3VXOrvY+Pib86rv6cY1a3M10O2XtCYRMRg=; b=FCyjAVRNckIdi6js6slrePD1T7
	PTSErjv0wDK+u+gUDfG2IqFSLLEOZK6yOPQSMMYWDVAQn9MEIoMXcFqUe2OnJc80v8CLmTokm+thk
	FwsJQzvWLFcGynbIvdSO72wpYnEMbUiNdnFM8txcRuNJKcqyX3I5cE4QoHpLgGW3W6MM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169586-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169586: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 08:35:13 +0000

flight 169586 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169586/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  532 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 08:40:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 08:40:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309925.526443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSMV-0003NU-9L; Thu, 21 Apr 2022 08:40:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309925.526443; Thu, 21 Apr 2022 08:40:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSMV-0003NN-4z; Thu, 21 Apr 2022 08:40:27 +0000
Received: by outflank-mailman (input) for mailman id 309925;
 Thu, 21 Apr 2022 08:40:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Sn/J=U7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhSMU-0003NH-5w
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 08:40:26 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 798034b4-c14e-11ec-8fc1-03012f2f19d4;
 Thu, 21 Apr 2022 10:38:53 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C50B421115;
 Thu, 21 Apr 2022 08:40:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8D3C913446;
 Thu, 21 Apr 2022 08:40:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id lHDMIHcYYWIsLwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 21 Apr 2022 08:40:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 798034b4-c14e-11ec-8fc1-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650530423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=qI8TPu71J+We/zCvxxP4jxhJX/Df5nYpF5m9OjwsUpE=;
	b=nC4t79M+Meslic6x1AnQgarI4lTLcBDsDh4aC3zJm0VPX49PIlLRjtZupBHBWN2qlzyJVu
	BZKR1SzWWHm/CZ9sElRDqfXMS3mz+TBudPI3jxi7rMEcM4VjZQrlF0UwEajq4yCCPaNJ2T
	9AP4ZNo/9HfqUItkFmm/M+4YlFxsNgM=
Message-ID: <bf19c5f8-badd-5afb-fcaa-a16483783a27@suse.com>
Date: Thu, 21 Apr 2022 10:40:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-3-jgross@suse.com>
 <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
In-Reply-To: <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------MXBgLgi61U0vYgbXaSFEBPbU"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------MXBgLgi61U0vYgbXaSFEBPbU
Content-Type: multipart/mixed; boundary="------------BAmmp0nFgIuRzrKlabLeMkus";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <bf19c5f8-badd-5afb-fcaa-a16483783a27@suse.com>
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-3-jgross@suse.com>
 <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
In-Reply-To: <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>

--------------BAmmp0nFgIuRzrKlabLeMkus
Content-Type: multipart/mixed; boundary="------------m02jPnaQ9qMxTiQzXNCK6VDd"

--------------m02jPnaQ9qMxTiQzXNCK6VDd
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDQuMjIgMTg6MTIsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDQv
MjAvMjIgNToyNSBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IEBAIC01NjksNyArNjQ1
LDcgQEAgc3RhdGljIHZvaWQgc2NzaWJhY2tfZGV2aWNlX2FjdGlvbihzdHJ1Y3QgdnNjc2li
a19wZW5kIA0KPj4gKnBlbmRpbmdfcmVxLA0KPj4gwqDCoMKgwqDCoCB3YWl0X2Zvcl9jb21w
bGV0aW9uKCZwZW5kaW5nX3JlcS0+dG1yX2RvbmUpOw0KPj4gwqDCoMKgwqDCoCBlcnIgPSAo
c2VfY21kLT5zZV90bXJfcmVxLT5yZXNwb25zZSA9PSBUTVJfRlVOQ1RJT05fQ09NUExFVEUp
ID8NCj4+IC3CoMKgwqDCoMKgwqDCoCBTVUNDRVNTIDogRkFJTEVEOw0KPj4gK8KgwqDCoMKg
wqDCoMKgIFhFTl9WU0NTSUlGX1JTTFRfUkVTRVRfU1VDQ0VTUyA6IFhFTl9WU0NTSUlGX1JT
TFRfUkVTRVRfRkFJTEVEOw0KPj4gwqDCoMKgwqDCoCBzY3NpYmFja19kb19yZXNwX3dpdGhf
c2Vuc2UoTlVMTCwgZXJyLCAwLCBwZW5kaW5nX3JlcSk7DQo+PiDCoMKgwqDCoMKgIHRyYW5z
cG9ydF9nZW5lcmljX2ZyZWVfY21kKCZwZW5kaW5nX3JlcS0+c2VfY21kLCAwKTsNCj4gDQo+
IA0KPiBZb3UgYWxzbyB3YW50IHRvIGluaXRpYWxpemUgZXJyIHRvIFhFTl9WU0NTSUlGX1JT
TFRfUkVTRVRfRkFJTEVELg0KDQpJIGRpZCB0aGF0Lg0KDQo+IEFuZCBhbHNvIGxvb2tpbmcg
YXQgaW52b2NhdGlvbnMgb2Ygc2NzaWJhY2tfZG9fcmVzcF93aXRoX3NlbnNlKCkgSSB0aGlu
ayB0aG9zZSANCj4gbWF5IG5lZWQgdG8gYmUgYWRqdXN0ZWQgYXMgd2VsbC4NCg0KTm8sIHRo
ZSBpbnZvY2F0aW9ucyBhcmUgZmluZSwgYnV0IHNjc2liYWNrX3Jlc3VsdCgpIG5lZWRzIHRv
IHBhc3MgdGhyb3VnaA0KdGhlIGxvd2VzdCAxNiBiaXRzIGluc3RlYWQgb2Ygb25seSB0aGUg
bG93ZXN0IDggYml0cyBvZiB0aGUgcmVzdWx0IHZhbHVlLg0KDQoNCkp1ZXJnZW4NCg0K
--------------m02jPnaQ9qMxTiQzXNCK6VDd
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------m02jPnaQ9qMxTiQzXNCK6VDd--

--------------BAmmp0nFgIuRzrKlabLeMkus--

--------------MXBgLgi61U0vYgbXaSFEBPbU
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJhGHcFAwAAAAAACgkQsN6d1ii/Ey8i
8wf9FaiocRtl87gx2tr6V8vjqwVSfCryLsAbcuwExxjIuksH/A5BXtik3XEUysPhCWCTcq+Qol8y
054HCFU/WYurTIbvOg7zHrXFtdDugZNGhoXCByznAtF1PfsXA9rOi3xzNZUrIw3eRm5h3W/bBaea
jRUPtJgopqOrYey/GznfbhOQw/1KBXtLyDjsgTXCNzEEILFQjEjrnEhNDdIlROVIIab4CYdV7ZIM
nF6AM85sQVleCs/nANxkj6CyHOLU6/knhQMJUfI9eAO2MOLDRmMJaFgSGZoKjSTQbpPNxnR6HWMF
SkAOi8uI0+vOSDAt/Y4HzEVrZaO8b4EGGhFaHZnFOw==
=AMDp
-----END PGP SIGNATURE-----

--------------MXBgLgi61U0vYgbXaSFEBPbU--


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:15:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:15:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309934.526454 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSug-0007lC-Rw; Thu, 21 Apr 2022 09:15:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309934.526454; Thu, 21 Apr 2022 09:15:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSug-0007l5-OQ; Thu, 21 Apr 2022 09:15:46 +0000
Received: by outflank-mailman (input) for mailman id 309934;
 Thu, 21 Apr 2022 09:15:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSuf-0007kt-6V; Thu, 21 Apr 2022 09:15:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSuf-0004aY-1Q; Thu, 21 Apr 2022 09:15:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSue-0005RB-Lu; Thu, 21 Apr 2022 09:15:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSue-0000fk-LS; Thu, 21 Apr 2022 09:15:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mia8oD0wmZyr+fWK/5IPk2JTaAMDP7CAeez4kCTGtOo=; b=LG6B9EFxRDHSmRLY4Ny7ecFrCN
	hjC8fRpPlXmZoJLx3E9Y2ZXwvIvb247F7VurCB1Sj3UECrPQXmknm3xiD2pYaIJrhSggjLyxHH/Z5
	wmJovw2tJZ0QDs/B8xMOzL9Lz1ljj3u5gj0Ji3BNINHhYawrl2frtGinAm8o+eKfFEE4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169581-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169581: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=abafffb931574e036024640b3732283f2b964e3e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 09:15:44 +0000

flight 169581 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169581/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              abafffb931574e036024640b3732283f2b964e3e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  650 days
Failing since        151818  2020-07-11 04:18:52 Z  649 days  631 attempts
Testing same since   169581  2022-04-21 04:18:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 105014 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:19:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:19:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309942.526465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSxs-0008OI-9m; Thu, 21 Apr 2022 09:19:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309942.526465; Thu, 21 Apr 2022 09:19:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSxs-0008OB-6o; Thu, 21 Apr 2022 09:19:04 +0000
Received: by outflank-mailman (input) for mailman id 309942;
 Thu, 21 Apr 2022 09:19:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSxr-0008Nz-4H; Thu, 21 Apr 2022 09:19:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSxr-0004eq-3O; Thu, 21 Apr 2022 09:19:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSxq-0005Zb-OQ; Thu, 21 Apr 2022 09:19:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhSxq-0001Wf-Ny; Thu, 21 Apr 2022 09:19:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BP04cnOB3VFT4EMvzZMrX5orTffezaHPnHOLIc6E5BQ=; b=52xQQzLVTIX3XOz+drTk5P4yof
	BvqzQSlw1RZw57H4+UpKmrkrMTe76koq3MALDeVx3reU2ZtqKHUXOYgndIyz94gMxMIsiRwDg9gqe
	sJsT4XkXXopxr/KpQ4D81wYXqOw82x52516WxzBiK8FbuxfyGrd5Ve+O8/A5ymTm3F9M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169587-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169587: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 09:19:02 +0000

flight 169587 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169587/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  533 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:20:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:20:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309950.526475 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSzX-0001JE-MK; Thu, 21 Apr 2022 09:20:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309950.526475; Thu, 21 Apr 2022 09:20:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhSzX-0001J7-J9; Thu, 21 Apr 2022 09:20:47 +0000
Received: by outflank-mailman (input) for mailman id 309950;
 Thu, 21 Apr 2022 09:20:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhSzW-0001Ix-DF
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 09:20:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 529e5a80-c154-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 11:20:45 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-TLNnFqlcN4W8KFJd_nAFmg-2; Thu, 21 Apr 2022 11:20:40 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4445.eurprd04.prod.outlook.com (2603:10a6:803:6e::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 09:20:35 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 09:20:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 529e5a80-c154-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650532844;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=x38M4jTtVVsfp07hlSV44EN3P+EHzSj2fmdtntSAjNg=;
	b=NQzZdKITOpUy7TcyK3tMNMxqKYJQvFEmAh6FAN7Jlmz6axHD0Dg5KBF8m1zjmYvGogWjq8
	9N3u1MRCMu2Z5/KM9avf4Lo/T3EqCmqQxla64XfKY43tB3l/UXSfJtaV3EpV8QWDakAdJG
	893ZAMWVrixQoHjKn2A1gBa6WJ0zs9E=
X-MC-Unique: TLNnFqlcN4W8KFJd_nAFmg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c+3lVtzf7IqLaaTm4kwnC9dtcgVU14reUl5FMuB2RBTy3p3Gqxyi43xCbkWZvh+TcpDJEC6BDq6nhdY4csTNC0OT+r/FK3cHt7PE+9uokVJEuc6KGHg2lG6LLu1VO+lCh0gItNb8JHhnEJT3p2DB4cZJkfhGx8XC2dN1UFqpmazptogE7NZ8UlqfiXK/EyZ53dDCZ7793ynskDSBI7c+OEWaFa9Zv8oOjOLzR6A0rvcS+5CnbZ9dAt6ptxatgf1NMd25YBp0XRapEu/UXxjtjS7wSMup7SXeMVScehCpphA5Bfeav8vKAu4Id4+zqEdKNBgTr/keZtT1C5eB/mkCIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x38M4jTtVVsfp07hlSV44EN3P+EHzSj2fmdtntSAjNg=;
 b=SVpbeZGOnBa+2jkXfllrtBr/AcOiUT+RZ3u/hBTM3FKiLR90WAyINwQpU1JCXSmKVym5F75qARki1lYxfZjvR7SSPtc2JXn8q+qDj8fyXBkolFhXYc/x8Kd3bjCEw/XvI7wKp8xOiIEz/iqPLmrYLK01i/QusDJxajTFXEUjosBICqPoqw21Y2ZXuZkaSOtYq2S5ynBKHc56zQT80szDCmysFVSjYdLge9L2CRGMVAcM2arqoOO8MzyufPr04aTs4uI8DiohTxrh/5subXZFvX6BIUjyZhb86dWKwORDux+2TDzTx1l08wSek1UWxar4oFcY0EwT8IaayMu4bWRGlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <256567d3-8d0b-83ea-c3d6-215f0a1483b6@suse.com>
Date: Thu, 21 Apr 2022 11:20:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 1/2] xsm: create idle domain privieged and demote after
 setup
Content-Language: en-US
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
 <20220420222834.5478-2-dpsmith@apertussolutions.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420222834.5478-2-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0038.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5693c3a5-6c5f-4c2d-1846-08da237830c9
X-MS-TrafficTypeDiagnostic: VI1PR04MB4445:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4445E6FCC7D7A2F0429492E5B3F49@VI1PR04MB4445.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WenhevGmKIFtVQH9YrXfoUjhPhFZ6HwrTV4OwlB/BWKAqBmwemG4swim4ui6/LlrkwoldOJeuTPw5lFtcKwYbRrIljkDCHRQ3V//llVS5MGYwruXb+0FvNxgMOe8An+W47RI5C5gTVd6oNOOX7gu2sPttA7bqUhzfYBCFIudk8fM/q5/HhLkrx0KTFxfR8GaGftu+q8SS0sIO83r6b3mTvDI8gqToHP0G0pKpubzgRpFcpSTFyNJpi6hUhJ2EDuBfA54wkqqx5RGBq4EKYiQCAzIsBgb0tj10yUA3rrKrA7vP3lmRJBWFTufrNR1SE/i4S7dLRPpZMpcQVlK3VFbwmdt/0HppKa7AqBOOOjTicImSq6l4WX8kprooiM+6UEEQ52JKtHwDZm1O77otArkmM0a4dEdJxLnfnZRW7jWocZiiaFkzEzoLNgji93gujyvF+ozfnIxl5Dr6JxOmMSiZUZPWCegjHWsp8FDSio06dPAAvg0lRFvn4vv4HBPthmYkcMUhimNwdTplh/y0b2qFoGImnTXl/p2WkGnGNQTUvFzK4RlTZik+r4WKj4F0yPpEoOmXMQoGZQD/uge9Xq5JAZO+5CUmcRQ/sgK43f3cuTIrnJDXPkwB/uDKEZmd1TXzOrdYPs4eEBwNz36y5XQdpfR1D+B09PWNkwM0iKepycEvV9s+ASTEIliI/uAT98uVNVY+vMFvYDgJnMD2/xiaIcq44TsEdxyI2o2zdI5Zj2rPMqekmqULJxcVEhIqZlB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(6512007)(508600001)(86362001)(6486002)(2616005)(8936002)(66476007)(2906002)(53546011)(83380400001)(6506007)(5660300002)(31696002)(186003)(7416002)(36756003)(66556008)(38100700002)(66946007)(54906003)(6916009)(8676002)(4326008)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MmJ4bWNSbHRhYW1yWGdraHFMUUNROHRtbmgranlpeEY3KzFhTHo3eFdLVkUw?=
 =?utf-8?B?dEpQZVRQRHNURzc5VU9PQ1lURDI1cSs1a1hGRys1NFVoMWlBNVptTm01Y2E1?=
 =?utf-8?B?NDNMY0ZLRmh2dno5MlgzbGxmUjlaR0prTnNPcWV0eWFuMDBKZlcyd2paOU9r?=
 =?utf-8?B?eUptNVI0Zy9XcFJPMVp5b29zbkZxYkJ0RkNZakFZczVNN3cyY0k4TEFvTU56?=
 =?utf-8?B?M0N5cE1DUTVHL25GM1BBT3hUaVdtSTFrL1FQU3ZwWjVEVGEvazMxOTV6QnBp?=
 =?utf-8?B?a3BjVXUxSW95RkpzRlFWczV3UXJYRGpEQVlYS2syVyt0UHg2MmJqZUpPOVVQ?=
 =?utf-8?B?aFE4SXlVcGlvc082M3o4MVNSZWtFK21xZUF4VVlzempDK3NaRFQvTGZUM1Zr?=
 =?utf-8?B?QTVZRlh4aDhpK1hxQXR3SVN1MkV6bXd2UUFXREwrWkFPT1c3NndQQlZ1R3lu?=
 =?utf-8?B?Y1B6bDRyTFdTYzF1UVRhcjVtMzBsMFRCS2RwVEFlQW9PQWlxeUhLWlJOSENj?=
 =?utf-8?B?VEZna1BQSXJ3dDNhWXJuT1BETVNFVFoyMzVaSGxUQ1NpRXpaZnZ3ZkdHSnVq?=
 =?utf-8?B?Y0Nxalh0bXBqTnJrblpzSDl0bEhqVjlQMjFFNkJZbkRJT2JpVWUrbGsyK25q?=
 =?utf-8?B?bjVhQzlKcXRPS0lXNlViMWJ4eUdzTlorYmZHNG9MZkNhMmRjSlJldGVmOXlL?=
 =?utf-8?B?THFNMGY4RTRwQzh0MkdsUVVBMm1ZcDFKT2FsQW9QeVZoQkJ3VkN6MFcwWkd6?=
 =?utf-8?B?SlIyTXp2YWpGYVUvVFZUQ3c2Q1dVN2o0LzlNWjJYVTRwRUF4S2VLeDcyejBy?=
 =?utf-8?B?V3Ric25wWEdkT21ucGhmVEFKaXVsc0tpUFkxOVdjUERIcHNjTjF1N3podkdL?=
 =?utf-8?B?VkNHQlh0NU5oUTNaRThqUUxPa3dvc2h0WFR1VWpkcytWWjFRZExVMkpmRzRJ?=
 =?utf-8?B?dkxub09QZExQaHludmN3QkdnQkpKdFl6TXdGRDNRWUZLTjVCQmlUUnJqV1B2?=
 =?utf-8?B?bTFVQ3VQMGdMd2U5Sk1WTzNLS3hRUFpuVndnNk5WZFdValdvajVEZC94V0tl?=
 =?utf-8?B?SUJRTzY0dG9kckJiR25mNW9ZWGlXRFdnOUNNejZMRnc3TXpOMlozN1JyR1Vv?=
 =?utf-8?B?R2RJbmtBVzUzYmQxVEdtRlVRaGxGcHhtWlk4NVhTOTl5Y0djNUVVRzlzYUd1?=
 =?utf-8?B?RURnaE80UWlFNko0WDErS3ExdUxmY3JmSGdpdEd6Ukkya1ptbm9tdWhWUjhx?=
 =?utf-8?B?OEJlaVh6U0I1M3hoaW5PaFlZNUZZMitKUHIydHV1QTExdDZmZkE3OWVLSTFO?=
 =?utf-8?B?YU9xY2M0ZWI2d0QvdXRIc0xJOXU3SXRJSk1TMWM0Z3ZNUGYyeFNIUjFlYXRQ?=
 =?utf-8?B?R2ZlblNuQitZR0l3ZldCVHl0aVoycFBldVAzemtEaVNsOTdQRkFuODUxSC90?=
 =?utf-8?B?QlhXSXRiMFJ6OUxNdUZnbTlLVlFBZWR0UTBBbjNrQ2FaYkRVNDZZckx1VlU3?=
 =?utf-8?B?Q1ZmOTlvSzlIRVB0bkRxTlFJVjY4LzZGRG00cXl0djN5SUNncWxkM21hU1JW?=
 =?utf-8?B?UGczdnY2SkpCdTN3dmpUQWV6NDdpWlA4SWtSbUVUbU5EaXR3U2F6blBMbFdL?=
 =?utf-8?B?OGJiWGorTlhabUFnNzNCTDYraWJLV0hHdWFkN2RQR2dhcVFiNVJiQVFQSVd6?=
 =?utf-8?B?Q3hXU0k3UHM0anNyajY2OEZRZ3VLQmxISkorcG1qZm5SZlc2bk0yNnZSVllI?=
 =?utf-8?B?OUhYK1pvMGdnMUZnc1prdTFhQVlTU0doVFJvSDV5d2xZaUpCUzlNb0xMejds?=
 =?utf-8?B?bnY5Y3kvQUR1dW1Bc2tiSUxyU0J1MnZadGVndnZBNFNOU3dRRENrRXFTSFZD?=
 =?utf-8?B?ajg4UHYyeFV1NnNwb1NXQXNOQkxDNjlJdXBqaC9VTTRJa2UzcnQ5QUxrMzZo?=
 =?utf-8?B?Z0ROL2dVM2gyVzlXME92QjNMQ09aQnhwSm9ZV1hKcWJNTGl3a1F0b0EyeGo5?=
 =?utf-8?B?SWZKbEMrSVUxc25oT01XeGhaOTRIQ1p2QzNmb0luM1ErV2VicEN6Vm1uTytk?=
 =?utf-8?B?Z2tNdVVxV2FwYWQxOFBDc0pWWDZaWnJ1bnhzVDhlLzNxZjM1YzBsYnJBRi80?=
 =?utf-8?B?VGliMTRvMndMeWpjdVVCQW03WlppSDdlNUI3bXNmaW80VXROcVVSYklZbUZ5?=
 =?utf-8?B?WTZ6KzRzcUZGUFA0SVFXQTVUTkkxWGpINDVkbktOcUlNbEhBM0VXb3QweVlX?=
 =?utf-8?B?Vm1ZTGhVU01UTzZwdGdTR0ZzaXlzaUl4WEMwdk01Y1lRMEt2cUlvczlqVGI2?=
 =?utf-8?B?eC9ycWNlSDBJN0gzcEdRdm12QmNvNGFYbDd0YVUxQXFVVU9wTlNiQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5693c3a5-6c5f-4c2d-1846-08da237830c9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 09:20:34.9441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JYJdVJ6/I80ne/b4EU2BpKNfCBH5rY8v5g09+8YHH1GSB6hF+i7ySpayUIERgr/u/tDGlWwlxnNXmBJicQSuLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4445

On 21.04.2022 00:28, Daniel P. Smith wrote:
> There are now instances where internal hypervisor logic needs to make resource
> allocation calls that are protectd by XSM checks. The internal hypervisor logic
> is represented a number of system domains which by designed are represented by
> non-privileged struct domain instances. To enable these logic blocks to
> function correctly but in a controlled manner, this commit changes the idle
> domain to be created as a privileged domain under the default policy, which is
> inherited by the SILO policy, and demoted before transitioning to running. A
> new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
> type to demote the idle domain appropriately for that policy type.
> 
> For flask a stub is added to ensure that flask policy system will function
> correctly with this patch until flask is extended with support for starting the
> idle domain privileged and properly demoting it on the call to
> xsm_transtion_running.
> 
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>

Looks okay to me, but I'm not sure in how far agreement was reached on
taking this route. Just one nit:

> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -101,6 +101,18 @@ static always_inline int xsm_default_action(
>      }
>  }
>  
> +static XSM_INLINE void cf_check xsm_transition_running(void)
> +{
> +    struct domain *d = current->domain;
> +
> +    if ( d->domain_id != DOMID_IDLE )
> +        panic("xsm_transition_running should only be called by idle domain\n");
> +
> +    d->is_privileged = false;
> +
> +    return;
> +}

Please omit such return statements.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:22:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:22:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309957.526487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhT1S-0002Fx-6s; Thu, 21 Apr 2022 09:22:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309957.526487; Thu, 21 Apr 2022 09:22:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhT1S-0002Fq-3d; Thu, 21 Apr 2022 09:22:46 +0000
Received: by outflank-mailman (input) for mailman id 309957;
 Thu, 21 Apr 2022 09:22:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhT1Q-0002Fk-1s
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 09:22:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50086984-c154-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 11:20:40 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2056.outbound.protection.outlook.com [104.47.8.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-jM4CN3CLN9a6DLCXNX-n8A-1; Thu, 21 Apr 2022 11:22:38 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB9PR04MB8204.eurprd04.prod.outlook.com (2603:10a6:10:240::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 09:22:37 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 09:22:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50086984-c154-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650532962;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=D/ZlOqVFCb6lqWPaD9Ie2gDedpd7uWNY7wAaDj5S0og=;
	b=EQEVFzUdLVSAh5w8jaWSC2MOSMyZaEOzwl7nu5NowOCeW54THxr3yJ6w1UofMcI6tlQoK6
	XUPI3ksTkiunKzdOG7vmmZWrL31+6ZunVF3pTGMND1a98i1qUR6y9Rc/tWVRVcA35Cm76P
	QU+w5uU+4sVeacdTO7D0Wl1eIk7MiwI=
X-MC-Unique: jM4CN3CLN9a6DLCXNX-n8A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZSiYtQW0BdkUCZQ8h+ZF58pFPmoikLrEui1bvFS22TBkpmuk/nu+OMnz8csn7Ki74/bOHhQoOdsMpn8cOC0PJBY9Oe4YqT06+FU7TBN+qijPf3Sm2eZR+E1m9EGQKquFGlTZBJ62OwfsmLTwslmkhQge2n7rw8KFRGQ73iafiPRD3k1+uaIM4/1mntpzFcXDNKtqJpI4N7Y7rEKR2U5E+tvS7gSKJRAad1oPq1YCfz5WNf305B23Xe9F3ES3Xqh4QCYZNKMXrNrny6fAlXwNPmsn17FQZHB6biNpx4+Yay+tXCMogQVndQbbyEP3pOFJ8gKNPSohIqTg93oEeUYnCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D/ZlOqVFCb6lqWPaD9Ie2gDedpd7uWNY7wAaDj5S0og=;
 b=dwnkGWsAd8kuUHWnTayrfKlpQxVbzFyHtUJ18k8xWarpBpAt08ARFmS14isglVpviTmiTL1811YE4lz1OzECxt2RNz+6g6waaA3NeKuioN1Cp3Dx9OjTYVNrFTarEpGBqNqV4yEiLBJKTtO9OT1t8liMbcuazcDqKDGPcVDB+TGUMiy5tCpho9YRJe8Gc2LDJQ6cKusdfEyRQWaoCzG//1AS0+RGUPr47xOb2sNZbKj1EE/DF8e1LQ87zCV3qogiZJ/+ErQycUR5k+gBxlN3AOJYgs8hQph/Ch6LgwU4cbV4R4hGjDi0jBNCgmSXxkj1AWAoidHNAOUHvdfUWqvmBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <201cc975-7566-7e96-d964-dd65e1a15c25@suse.com>
Date: Thu, 21 Apr 2022 11:22:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 2/2] flask: implement xsm_transtion_running
Content-Language: en-US
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
 <20220420222834.5478-3-dpsmith@apertussolutions.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420222834.5478-3-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0103.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::44) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d0f3a7ce-c162-4343-5078-08da23787830
X-MS-TrafficTypeDiagnostic: DB9PR04MB8204:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB820435B156DB13C0DABFA6A7B3F49@DB9PR04MB8204.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mDbVSwxWnrfs/TXUP8eUXNXHp9LVCWObj8Hj4a4bCyI0y/XqGACpb9GnBrLJVZ1H5iZ6Hc29HkFbdp3JogKt6zZ9yoQcWzeey+Lxw4hIo+qLy2zueXFrg2F5ZXAmqU6GRYAFMqhPawvG9ewTiIN6zuovCClEmkya3UpG9wHjwXNDWDvQPSNXk3MODtUrrMfH3SDayxhss3sQOyZcUHvmZt4rgk7fHEKJqh8LOfYCbth8yKJgznAHSLLo2O/G1Nai/sDu7zy9qcWjkwPsRGAK44OrUesxupPqrPnJPJ14bKZHA3U7CQFajpaV3/emmj65nCvPw3e9TsMdxUaFjlsip8LulJ7sm/T39YI7yQbMxlAxAGseM1Ze3FzDNdJm2DxYoBmHJnz4P4gL5eld/zglOm7FuhKLZQcbNZDGPdn0yqcpZxAHUIcY+YX0yuhx3zZMkRIuR9Gnrvc032mWHul22r18lkGkpGQLol96j4im26vAyFFUOQL/htw5mlUbiu5S2qECLc5yy/EZVsd1Kywub/1Yw/F1KasPiX+dahyBiCb5bMKhOSTrYpqZAee58YqF38WYRmuC5onIzlQ2WbJ6WUTeby7vLDBI44SZl/wXsF1JOWA7va2BUlPvEZqNNbK5i9Z/meoIQTgxvVA0il9203eBqvjazcDDU3niH5bdTqHg14XclO9bJziWW4czBzdgTMMUOU2uDkppDpBb/W2/IdZtmkthUSf5LpwzngrcPYQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6512007)(6506007)(26005)(5660300002)(316002)(6916009)(4326008)(86362001)(66476007)(66556008)(66946007)(8676002)(54906003)(508600001)(31696002)(38100700002)(6486002)(2616005)(36756003)(83380400001)(8936002)(31686004)(186003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RURrNDk4K1dITjRkc0l4eXBDRlZnblRUK01pL1lFUUNDVmlnVXpzZEs3eG1U?=
 =?utf-8?B?bDZmcDNRNnViSjh0YkF0a3ExckpkOHBVaXpRT3p6UUdUb2FJNHFJVkVNWU1w?=
 =?utf-8?B?SFhJaXROYjRWcWRqNFRlTkVqc3k0NG01YUwzWE9oeUM3d3NXcnE5S0lYK0Nz?=
 =?utf-8?B?Q0VVMC94ajBYTkptVG43OWJsWFl0ZVdKNEpBOFB6WG5IcGwvODZsakQ5aWd6?=
 =?utf-8?B?TFdJL3kzVHN4aXRwNEJRY3hCYXF4ZENETGZqNG5oYVF2dFV1TXI1S2Z3cjEz?=
 =?utf-8?B?RXF3Z0ErTWU5ZUJOWXdkcGJoQ2hNL1dFMlBUWTBGQjdYUS9tVUwwZnRjdmJB?=
 =?utf-8?B?NDFLTVVJV2Uvb1N6bHVMSHFDeFZvZmNFdGZzM0tEM0VRUGxGRGRWR3pUN2c5?=
 =?utf-8?B?dW9rd0FmbzJtNzFja3Mwck5PdFdqdjlIZUFGcXFnTUxDOHhBUVROaVVON1d5?=
 =?utf-8?B?Zy8zclQzRlpqZW52RFZ2Z3ZscXpRRXlqN1haTVVZaVRXRnR6c1RSRmlGMnA2?=
 =?utf-8?B?cENibFFOcUljd0FCNjBCNG1kVDI3STZCOEFQbVZ3TXZlS1k2ejYyOWZiM3U1?=
 =?utf-8?B?aUl6MlNiUjJYOG1wZGRXdEdxdmwyQ3lFK1E0MklVWEtzT1BpVmlIS3N5a1Bv?=
 =?utf-8?B?NFB1bS84MGNYZEJYZDIrMGgzWmlpMnM4cUZZUW5EaG9lYzVWeEtIdDdtd0Vh?=
 =?utf-8?B?ZzJNYURFZnZIbUFVK1RGUVBYK2NTMFU3OVBLdnJIL2ZjRFczU3FYL2M0Y3o4?=
 =?utf-8?B?UjcrcEJ3TXUrTHE5TFVDRzNCbjBDUTZxb2RScmx3Sm1UbUpzbGtSenhaVlJV?=
 =?utf-8?B?enM2VG5xWWMydmR6S0RIL3A1V3lrTG9sOSt2Yno2bFQ4SG5hYkR6TGdkc2ZQ?=
 =?utf-8?B?c013ajdVeEtDdTZ4MWpJWEVqdjAyR3pHVzJlSGJDVVZEWnJtcXBEM3pZZGJF?=
 =?utf-8?B?YWUySGg5T25BM2ZOaTNkMjlXOUFIcXVReUYxL0xSNG1ySk5qQTZoVk4vMjdi?=
 =?utf-8?B?WWFDcnNXMTZoM2c0U3NHR3RQancwUEQ3TTcvTjJZZHNDQXFiUzErN1dvVzZQ?=
 =?utf-8?B?bWRhb3RGVmxqK3BOZ29FN0xYTzc3V0ErQlpIcHRDRW9zZjV4K2QwclBBemFo?=
 =?utf-8?B?TXBHdmZTSWxTU2pCUG1IWEgvMzFUM0pKRmJ3akg4NmxIRE92RmJzaGJiekQ2?=
 =?utf-8?B?OGJnemhsVVpmTXMzS2N3TzBic2NmbytzT0lDRnZRaTI3aHN6THdNby9rS3k4?=
 =?utf-8?B?THB0RnFpSmV5eExQZ3c1ZlJ4M2dJbDVWNWpzV3hpYlMrbzVrMTBKT2M3SFdj?=
 =?utf-8?B?dldqWWh4cEY5MWZqbEhvRnErUUNkTWFZa0VCQVg5aGcvMTk5a3h4VnFXOUd0?=
 =?utf-8?B?TUZhenBsdFBCUysxbFdXT0RpcHpQZ1ZNYkMzOTdqK0l1T2xpMzlDTEZERHVK?=
 =?utf-8?B?dVl1QjhEb3BNZDhGUmk1QUN5QmV6Z3NwNy82Y2dBNjBLbDdpYUlnZ01tc3RI?=
 =?utf-8?B?TlJQVklINDNKK3NKUzRrYnVaVkFjYUFrR2JMSnovWTI0T1NrSEpZQ25KQUE2?=
 =?utf-8?B?N2JoSC9qUHFLNFhSYU5vb2h4ZXlSdlpmZ2RoYWZPbngwdTJnRS9JUzFoNXcr?=
 =?utf-8?B?Q1liVURzSkIxWnlGaUZyNEV0ZlRRRUwrSmQ4WS9veVVGVVQvYTlDS3grT0t5?=
 =?utf-8?B?UTF2dXhDYVQvSHc3eWM4UER1eXlXejZCTEYrYUhwZ1V5QmdtRXZPMTFTOUFn?=
 =?utf-8?B?UWpOSTE4akl3ZmMrbEs2Vjd4MjFkY1hIUDFIMUpNVFNKS0NvOW5TTkM0SDVv?=
 =?utf-8?B?WkhCN2RnZXNjUGZ6S2VNaUFRREdIbDB2Tit5VGc0dUR0N25CTHBsc05SZTIy?=
 =?utf-8?B?MTBsci9JTllrTFBGYXZkeFNkbFV6aDlXbnJHMUdUWE1RTjNrZnBGWlMrMmt4?=
 =?utf-8?B?YjcwNDduV211UU5PblpwVnEybEFmSE5QYU9GMlVCWXA3Zk1OaVBjSHplQnZm?=
 =?utf-8?B?emUxc0YxWCtoMTZxcFlRNEh0N2R6MUQ0L3ZhSGNQZE1RS1NvWEpKYzdjRGM4?=
 =?utf-8?B?TmwrYVFzbG1QUHRlaEFNK1k1cE9sWFgxYlplNWFNamNaRmtNZ0ZCSGluMHor?=
 =?utf-8?B?aHN4SHMyMnVoN1VsbEtHTy9uZHI1K2NZUk1MMHl5Uy8wenFJZnM3S3ZKei84?=
 =?utf-8?B?K1puOW9IN01vVVBCbitaUjhmNVNlRmxVN2pMYjhMM2VXV3ZhZEhjNlBBK2cx?=
 =?utf-8?B?RWpja1ZMdWw0anhFeWhLd1A1U0U5L3RuS3pRYUlzQmI2MUluekV4aHNDQm5L?=
 =?utf-8?B?MHp5Q0RzODB3WldHc2xtVjZ4ODc2RUpFbHVxSFd5MTNzYjdXTFBPdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0f3a7ce-c162-4343-5078-08da23787830
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 09:22:34.7232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wqSacwp6NFuSoxKIk3kD54GzLG37zHx/4ZyOMlU2pRMTlbpL4X0XBDh/r84cyuH9WOqKPMMsgq6DzR47a4EHTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8204

On 21.04.2022 00:28, Daniel P. Smith wrote:
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>      switch ( d->domain_id )
>      {
>      case DOMID_IDLE:
> -        dsec->sid = SECINITSID_XEN;
> +        dsec->sid = SECINITSID_XENBOOT;
>          break;
>      case DOMID_XEN:
>          dsec->sid = SECINITSID_DOMXEN;
> @@ -188,6 +188,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>  
>  static void cf_check flask_transition_running(void)
>  {
> +    struct domain_security_struct *dsec;
>      struct domain *d = current->domain;
>  
>      if ( d->domain_id != DOMID_IDLE )
> @@ -198,6 +199,10 @@ static void cf_check flask_transition_running(void)
>       * set to false for the consistency check(s) in the setup code.
>       */
>      d->is_privileged = false;
> +
> +    dsec = d->ssid;
> +    dsec->sid = SECINITSID_XEN;
> +    dsec->self_sid = dsec->sid;
>  }

If replacing SIDs is an okay thing to do, perhaps assert that the
values haven't changed from SECINITSID_XENBOOT prior to replacing
them?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:26:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:26:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309962.526498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhT59-0002tt-OF; Thu, 21 Apr 2022 09:26:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309962.526498; Thu, 21 Apr 2022 09:26:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhT59-0002tm-KL; Thu, 21 Apr 2022 09:26:35 +0000
Received: by outflank-mailman (input) for mailman id 309962;
 Thu, 21 Apr 2022 09:26:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhT58-0002tg-Lw
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 09:26:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 223ff33d-c155-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 11:26:33 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2057.outbound.protection.outlook.com [104.47.1.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-mbLu9oq2NyC5c7E9J-iCew-1; Thu, 21 Apr 2022 11:26:31 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8758.eurprd04.prod.outlook.com (2603:10a6:10:2e1::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 09:26:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 09:26:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 223ff33d-c155-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650533193;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RdrblUgnysg651SA8maVoA/DgVaB96EI87pKo8AllnE=;
	b=bOcp4pFSMo/x6UlAv1zjyjQAkhkSL5T6El705DAi9SfCAu1Y5A+7KcGqRvpORtQDSUrOB8
	P3F/JAuVEWWjClFsH7H2XXNoE5Ydnnaz7r/kzFhIOGKf4VgcxJV/myLdb9rRrBcQjWEiCm
	3bH5BtLLw9dmzVdwWta5FiSqWZqx4mI=
X-MC-Unique: mbLu9oq2NyC5c7E9J-iCew-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R0z45PE26hOgPY+bXEohMjuRL52+wMXs8CtiAC5CMcPFg3lyEldnx9rLPwTuHxK/Kc7PGyKrsxlVj4Q6z4rG7Cpu0OUNRUqJji8sJqghjFj45yLcItW8PsP6jqFkh5WU4xCc6jabEczaLxUxMIz4YM5HV8lx1AEeK2Y6JULwKllmExmuSk8WHDSoLO790iBnQXOll2+mnl298wJkS7IbU7H86i0M/64u2U8gC7M26Ml5gy7icaIJI1W09Ox8o6pBHKdWYQy5evoUslPCcHrR8juYdVZDGvYwKHngd0XXJhk9K7AsHHmJfPbL9GHxEmKbAB3I5JpgD5uyrOmzxCwQRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9h7dSRiI6+gKM2CCwrigo35ZuUTH90ivrPDwKdYJ4Mo=;
 b=c2UH2LRkSdyb+DkMKY36eRExBlsy9JDXWNERKeAbQkwBAXi88DY4FRsvW70wpi/d2tnEiI9PkkM4wcnYKELWxg5TtrlV+LyYqRyCtSsqqqTz3nGdfB6WpmIjXEvnTej6aDgtb9wwzSOdf3/GRuL8axn8YUwwHBnE/xjTNBej/hBOvVhiuLFHXYRuLE0O3Qaxs7K5mecnuds5H7nEBSc9pGc2VYZVL7kjLZBR4yic1led5A6AZnEGvwglQnGMWw2qEzPMYRgSP5M06p27BPYml6751Viqq5txwgNn+aUDl4PHFO9xHPADUB1R2H+/Qk9J853hBMdTZF/392kgJfVllg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <33a37e77-0e38-2c5f-6bf9-2313b5dc5dd9@suse.com>
Date: Thu, 21 Apr 2022 11:26:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH RFC] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <George.Dunlap@eu.citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Juergen Gross
 <jgross@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420155657.32506-1-andrew.cooper3@citrix.com>
 <70490620-16d2-6045-f83c-df65540025a8@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <70490620-16d2-6045-f83c-df65540025a8@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0295.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::12) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71f5b7f9-da67-47c1-c340-08da237903e8
X-MS-TrafficTypeDiagnostic: DU2PR04MB8758:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB875804F7A5D84D5DB542BA35B3F49@DU2PR04MB8758.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jugNASDTngTVGIf/b2BWHWWDFtyYIC+mKwS6xbDPfjyjLwFCIM4vQLt9PUpjvgBQYXmXPI34aJDGCI5a2XFL4bScE8RApDTvvPw0seSQK6zsjfOZ6cO/EMUOMAVCP7qlBhJYkTY8gZ8eOgVRe90UCy+Ti267CJdUmrN1HEjSs6ks48lImjxEzJt8Zh5CaTvMBGJNTheSAtoahVKiXbNh1jqjgZYYJ8leTTc9muK82u8V++3aEdUSCEkZ/7zkY8IA+2+vAZyyVuXQ1lTaUz1q4A7Lwzwkgja4/03VuU5Hsauz9z3lKuHdgJI7MlVu04K27s5zSb81wSl0GSlKEuxDx4K7JpFStd84vlorKlnurHyKw2+UOceoVGtT8khs4otEoz+sl2cDdkCFoUW2Zj1oOCGAv7Yl8nakyLtvgpze+OtWCEqIQni4QtWOb2Lg8AMEj3v57C4RN8itu4lLyLQ6ZjVjm6395JYwPZStayRZLG0HZcop0n3ulzu5GJJCdio9XSKPgeAcacdNH5vR/U7/mPCUeSdKq6710naSjSHg9lRVlvC4ZjcX74A9xfwM8bbFfw15d9L6m1/+7uKWDrxl389wePIDp9810sei9GAXPWWFV7+HP+LksliZu43PGN9VkPuJmTLl6y5pVi3TeczfbutxkGeirCqTVxC4dmxyvjEFdDkZussEwyvuUx5IZ9en0VoYNTBFwHEiG1r8iFqqf8mVDmLCDTBg+zHdvY6aCMeAEJHsMJ3BW32BalncFD6q
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(4326008)(8676002)(53546011)(8936002)(26005)(86362001)(31696002)(6486002)(36756003)(31686004)(5660300002)(66556008)(66476007)(66946007)(508600001)(6506007)(6512007)(2906002)(6916009)(2616005)(54906003)(38100700002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IJz/AVStCd3OIfL3UDJ8ScCHy1hqgTHh+xj43oAldAM6NRv9NstM8VF07O+r?=
 =?us-ascii?Q?PXjVlgWUlxzOVKgFhBDnHixrvt4IVw+dlAnGxjLB6fDpBu5fEYo01P3d5fHA?=
 =?us-ascii?Q?Rwz9D1m3/G577QszwxVtto7au6bY4YsvMVblyyhQ9ajNCNFdCrY5H17F8TGw?=
 =?us-ascii?Q?G9ZNy16BRNwUhjCZ3pnrE7JFJZErGXYxKeAvvuLiQtyAsweC9kGYNuBXhdIm?=
 =?us-ascii?Q?vIpNK8BgvN1r305cZLDjmEAL2st7YmR/A1LDlpsnJEFdF4ysBhF+NKDzZwc6?=
 =?us-ascii?Q?jIqNH3fIq8ulHD3Ocu49zWx860LIQf1n0vPFAmEc8YwFYCI6UVyxx90W5ZVM?=
 =?us-ascii?Q?6yFOPIZmG9s7Ujl9dq24T3jtRHtdKusa1mOKsoCxLVIqf/DFoaQglAk+UnBo?=
 =?us-ascii?Q?TJm1mnaICfwyI7feebAcJ3n1yNefPrgqr7IKy5OFdFNcWiFFqXnVV5t8D3ct?=
 =?us-ascii?Q?s9hiDj0YMnddHY0/puOghv4pg1b1WjkPFXm/nNuvrebMn75QBh8eat6GSRTr?=
 =?us-ascii?Q?+fvnCh/WJ9+7aEMZu35Q7p3veoC7ATQT2Xjx//1SPjg6PG7g0UMoiXPcCws1?=
 =?us-ascii?Q?Xto7Tmm++N2JDd+TUyZv2Z/RHbk1gIvP5Ezqnn1Hry2k49ryXcu35Ns6Kjcp?=
 =?us-ascii?Q?ISuJyQrBGck3x2MnDxvbMsaITc4JYSg6+w5VXtFFphRK/F62uKhv0BIstd0N?=
 =?us-ascii?Q?9co7Ebu41aQRFoK6O9OzmoBYrkEFOljOukVi9I8vgxKDrg968zRHMqapl0yl?=
 =?us-ascii?Q?hdh0hAgM6CUxKRF0jD8778b2QsQB8UvZwu6X/upNMH72Q8akI6GhCnjFXKK2?=
 =?us-ascii?Q?Tl6K5Klp8mwEJjx5bsuUGr3/3Pu19VR08KrvNa5SD/ZBJncbG+kaDbheFcyT?=
 =?us-ascii?Q?txy9Y2z4yu/dJOewNE6jaL+96TIxISNybUu/iqnTy+cNe0kSZFdUKIJigRDu?=
 =?us-ascii?Q?1GNu/bXt8RIvG8qThwIILLkX29ZpIk8ktDn8d7+tRMln8ChxYe112c6QlW1A?=
 =?us-ascii?Q?GzkvySJnzOYqzQmn0mYDB0hYGwbXKSd3YV9zTiB+WTafmwvj8rk1WiOoEL7v?=
 =?us-ascii?Q?ZjLXwUKDnYVG+TLdmpraTkhic0Dg1R6D70KOl39gzrSWJHEKXydyaupi2dps?=
 =?us-ascii?Q?RBgFG0NFnjRLRBp9qTEkeApYU2gKnzD5Lfq7TqOacSqTqlOVrj+Xn4igR3YC?=
 =?us-ascii?Q?XqbPQMdu7dK7u9O6OCocJWknYvFMglvPOk/Y4lwdMqQY0gmgGUSGulWuSDzY?=
 =?us-ascii?Q?VgfwaWDo43b5sOaMNeDuaw3t6+NoNpgGuM/IQSuwGWkGfH2ggmVogMVPPC5I?=
 =?us-ascii?Q?8C8eFhOMB9Dolt91Z87iwBWHCmH+xE/CvqGt8VGFUfG3KCXN/O95Fbc9FLNY?=
 =?us-ascii?Q?WRXwgBmmYHdq9L1m4I8lK64BYjF8j1Bk/pB1kMvCpEwFeKwi6/OdJmQPTOTS?=
 =?us-ascii?Q?G6Uddt5PJaN8XlRzZJskQIUdAZjD/qsr6sfxpDRLHCy48afPR4YRdDFa7o8e?=
 =?us-ascii?Q?8lyp4cCsBFvQlU7ZAyzZZXp3d1HsHoUni+dzoo3FMHVD0tdfLaSNd9v5LHCF?=
 =?us-ascii?Q?W5qXSEIxjk0vXKgF7+/79ZutkgqpDAwk5/5vMv9fKtDbswiLg84B+PvevHrx?=
 =?us-ascii?Q?jeqzcTreTznvNIpCXNn6oQhukrOEXbPDqABgnMdmMoaZeCOYHGtvAjH8pJ4Y?=
 =?us-ascii?Q?In1oBkVRBwbvVIb5vHk0naKRUp/WE0LfEmP3JE405Zow5ra0lfXIZkWy7C6e?=
 =?us-ascii?Q?xWBfVLAqDw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71f5b7f9-da67-47c1-c340-08da237903e8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 09:26:29.1509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C5OAykQBMBjXorldbdxQA0ZkuVeuW+Omsebiy2EArlPua9dLYMu9+Sr2u/9b6kx0dXYwkhfNoVY4OkedLzCOFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8758

On 20.04.2022 18:03, Juergen Gross wrote:
> On 20.04.22 17:56, Andrew Cooper wrote:
>> When CONFIG_GDBSX is compiled out, iommu_do_domctl() falls over a NULL
>> pointer.  It isn't really correct for processing of XEN_DOMCTL_gdbsx_* t=
o fall
>> into the default case when compiled out.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: George Dunlap <George.Dunlap@eu.citrix.com>
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Stefano Stabellini <sstabellini@kernel.org>
>> CC: Wei Liu <wl@xen.org>
>> CC: Julien Grall <julien@xen.org>
>> CC: Juergen Gross <jgross@suse.com>
>> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
>> CC: Bertrand Marquis <bertrand.marquis@arm.com>
>>
>> RFC, because this has implications across the codebase.  The tl;dr is th=
at
>> case FOO:'s shouldn't be compiled out; we still know what the subops are=
, even
>> when the functionality is compiled out.
>>
>> There are several ways to express this.  Alternatives would be:
>>
>>      case XEN_DOMCTL_gdbsx_guestmemio:
>>          if ( !IS_ENABLED(CONFIG_GDBSX) )
>>          {
>>              rc =3D -EOPNOTSUPP;
>>              break;
>>          }
>>          ...;
>>
>> but given my debugger series creating gdbsx.c, I was also considering:
>>
>>      case XEN_DOMCTL_gdbsx_guestmemio:
>>      case XEN_DOMCTL_gdbsx_pausevcpu:
>>      case XEN_DOMCTL_gdbsx_unpausevcpu:
>>      case XEN_DOMCTL_gdbsx_domstatus:
>>          rc =3D gdbsx_do_domctl(d, iop);
>>          break;
>=20
> I'd go this route.

+1 if we already start enumerating sub-system domctl-s (as proposed
for the IOMMU ones as well).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:35:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:35:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309967.526509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTDD-0004a5-K8; Thu, 21 Apr 2022 09:34:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309967.526509; Thu, 21 Apr 2022 09:34:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTDD-0004Zy-Fm; Thu, 21 Apr 2022 09:34:55 +0000
Received: by outflank-mailman (input) for mailman id 309967;
 Thu, 21 Apr 2022 09:34:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhTDC-0004Zq-Q6
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 09:34:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 037a809f-c156-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 11:32:51 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-t_bT9zHRN3SA4mjJYwbdhQ-1; Thu, 21 Apr 2022 11:34:51 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB3968.eurprd04.prod.outlook.com (2603:10a6:803:3d::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 09:34:49 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 09:34:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 037a809f-c156-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650533693;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=p4VU66fUJcTMBh60wtywcoqMZWupFABTOcQaLrKDbTc=;
	b=Z2oSGxhz2IqeAsd8LvFSy9edG5E+wI3Jv4bCuh8MboeCrhi6GHH5dsdLBQ39PM7jGDBM/D
	Lvp9ABUkyqPFRIWGtCrIg2H9ji6CWr6j/ZjfOWENhWHQStfqIwYlfufe8BAwX1SjRpOu2c
	fNe8ulwG0PtIDFTSzTlPhMG5xRxEhLY=
X-MC-Unique: t_bT9zHRN3SA4mjJYwbdhQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H7b18MJ2tjOtQAHmMntqJECoK2sIktHZHhqygiwt2+ISpq7HpK/An4QJBRqB1KXAKprIF7rvCZx1QrCrBo3UVc5DuETkxZJwOIZUlCxqJoam/enhssX3QKYA6Jo7ryC/B9wpkBKFTXhX4nT3KjFie2wkoop/whqJ5T3pn6+MMOvzqrz0CDs2UZXZcHY12fYlQwpv6FvsGhqgcwD6E6c4FAnKue27uhAoGUyUfdaeEfmQdsVI1Ah+j6Ju8mdDT5WM9PhUAwUEgadiGSYVThb2bno01cP2OMobPQULWgwO4wVuvk37yMW+1ED+zPFwvuJHN9qtRvSusTFblz4ty3Znvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k68fuNs+Aikxltf9kuzUs8ZmRf7XM5WMesTjk3NmLn0=;
 b=CRaq3Zy760RfntonF9pFFQOlBB7CgQItvLY/PhliQhkQz/CBCuRsWU7ljUiuFfY81zRCSOQYkgwDmwfnYLCMcrrm82mXDeLoPMZDPJxM8b0mt08hZ++TfZdukwSyfc2f2QWTi+6GWjNcdI2Xtw/yGNjwHGfPbWiSJPMwunRRHOoGnD5uCVWmOWtIiw4u6jfgC2AYEy3LJCsDgUNwbvd5mBxD0EjRQg/Efm22sokOTKxyIe5o+sG6hPGQ3HaqH+qcTW0INnK/5ZkuIL1cyOeQHiWKvkmsQmxQozAgw46jkYG5c8AUFKyyhBFMvUvE0x4/9v30nUxsa6IFhfA1H7cvOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ff0fbea4-ac41-66f9-5440-88ae5d7cc188@suse.com>
Date: Thu, 21 Apr 2022 11:34:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 on top of SPEC_CTRL
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220331092717.9023-1-roger.pau@citrix.com>
 <20220331092717.9023-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220331092717.9023-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0601CA0074.eurprd06.prod.outlook.com
 (2603:10a6:206::39) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 552c96d8-4929-4907-78f5-08da237a2e28
X-MS-TrafficTypeDiagnostic: VI1PR04MB3968:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB39680D17E18B6A31C6108072B3F49@VI1PR04MB3968.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JHOVFhNb+V6DNkTvP3z4389S0j5KJ3ytqvkgKyL2mgOlyylyZmM9Ko0dwy3IZtG7hVGJZJJRaJsHz2RJ5SO9j8FolClwJIdQCC490qztN26NUYecNWNjlnaYztf/44XiNA0SKFdu30EWPodMzfjDpQ35HbD/J2n78NprvPtYnHk1aIjMHoSNVRk0PdDO7zollPGWjFpkIC7Krq/BXOh1tU4s4oBLk0DpjqJeX77dkQt1QqaluUCcg3NNalLzMpl5naslJy1GzcNzj6q8gtWH8tiVd2tsRmwmWkHsIYJfrWRwOBAMOpdn819mtaRgkjgFTlNuHxc+VPM3leBz9nNaFjiEgIa8+5p/FpzbgCW9dxRAwTCODZJZ42vXIC1PCgqWXCfdJUSdE0UyyzFvXmCcAGd/D5sxZ6LnFs5bcM3wBwhTSmaOLa9xO75owHq0hlws0OCaYaehAP8X6ojf/LneU/Zq0ved6ouUSSCbOOMKUihuZtLxyYIyAjQTA4Z8+vvS5k4/SxqsjbDnuX776B4fk1ET6YngL3pM/Elv0Emtm5QBDFZMuMmOz3lmLRxzdcdd/hj5QvzuByIyzBPHNNnpNfTcWGICD93e0AWipIuY371jFix+USKXw35ErC+/siDSKpbz6Uuh2i5lEvItUkisqvlDEhyEJLJ7Cq0TxE022mxRTyKAfY+03svpauE6pY0cd73Djp+OKCUbbQ5hlkBTOUL6jwShqMEeiOwy6u0AD5EsdSUK1wovjd4W/Vi2L4Pc
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(8676002)(66556008)(4326008)(316002)(6506007)(6486002)(83380400001)(66476007)(66946007)(36756003)(86362001)(6916009)(508600001)(8936002)(53546011)(5660300002)(31696002)(38100700002)(2906002)(54906003)(26005)(31686004)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?yY7tjiYu0byrtui1oiY5ladOpcha4mdEzMd3hzLATzylJyv2nhcbRw1Pvz2J?=
 =?us-ascii?Q?AL8cwsHipHbCoIX0/J7fYdA/q4ihyJ4NtTCHkvQRU5FvhD+vv/4wbM0WhDda?=
 =?us-ascii?Q?jYZ7z9okkQJqGrF06WjazoBNFEmQ9ffpaIN/peeKwuTqKoyAPsa1gJXr9R2r?=
 =?us-ascii?Q?/gGIIjFkhZIkxbmeqM7Q7Ugh6E5DtoIB78YzBCR0nih6IDswsaMXWGQTykZz?=
 =?us-ascii?Q?ied3Ub57rxdi6BjD5Hr3BpusIViN+U5CyCGZMdxoCBXIqT3ZhozaX8T458GN?=
 =?us-ascii?Q?LuslA0lRE+BfcNt9qh9VswqF1bkx49aLC2+22BdeyYy7uF2lAQLLFcyelZ7L?=
 =?us-ascii?Q?8sTtlou1BK3a6spDTeq42+DI1b4UaCVWxITIYngM9Hq4LgfxFPiFJ9hsHWia?=
 =?us-ascii?Q?iBPABEW+LzzRtN8hWvTEKGc5jrVAjV9gb6ZgcEv9I4x5u0MpXp042h3a+2we?=
 =?us-ascii?Q?UTMoBxQjlgfI1mX8gN6evfsPc12SGpYwpTWd7Q6oNJgIpc8hNCgXRLuwZLDf?=
 =?us-ascii?Q?PZ1b8hX/t65UxvC+e8ejAa+fDwwKddqB3pqIsFmBMt1oAObd8UPiEjk2rRJA?=
 =?us-ascii?Q?puP1qc3AkJBU7wx3jPKvfRCmajhRLMX7xyDT3bezTjECrwXvV/VjpMHdZq55?=
 =?us-ascii?Q?lnk6k0ckFOyfDK6BAIJsdFtSOK/1moCDAe61JiiukKwquLp97w8XrWDL/n4w?=
 =?us-ascii?Q?io3wOeYVPcs41TB1sj2bxZ1MB2iaIHaQduR5Ogo7pnBwHqcKZRKC05+HIW6D?=
 =?us-ascii?Q?9GyehVWcinaxbxoYb47MyAxWI5QimSl8bN/XYYMrrkvKXnlqRdvB8pqiehJK?=
 =?us-ascii?Q?w71WMTwUNUzmEv4hZaZTQDS5Mr9Q738ea5uy60vqUx8S8pHNdqvJdA8bEKQB?=
 =?us-ascii?Q?V3+f9R00bhVmUoGj6LZu0lFzZK+z/I9WB1z+5hvXYOHcylB0BNAfw0AkYB+u?=
 =?us-ascii?Q?7rHIdeTDT5EyL6KX3Gm9Pm5CVzypJv/MkvCoEBKSGyb7fFkJjVWdrmOAhPiD?=
 =?us-ascii?Q?3sT06hOPZP/DVkxTu3UrtkhuuBOf6oZQhXtZGPU2wWqtc8bH/lVfPxEc1hkh?=
 =?us-ascii?Q?tdDg5ByJwOCfQnOwaK4rhkoZY8+vi8waTBhXwdO5dpVdKFJ39WY5cfe9qs49?=
 =?us-ascii?Q?zytvaUs/EgievR4lbF5MM3e9AiTY7JqgD0TDiRj/AEsIekQ4Fac/tmSNKHxx?=
 =?us-ascii?Q?eXwHW3CNjN5+HLupZXArD6bV5NeniwMGuXGP0+Gc4xfaPNSLbVAyw3wXUP+C?=
 =?us-ascii?Q?ASfCsBA7r3qpZTb9nFD+YgGfD3NtEpZyRJCmYIeeNpdNYlhsIcYMnwyoM3op?=
 =?us-ascii?Q?6YP6/sX5PMAoGOHLddcdPG0E9UUbO641P2B3vMpWp7VwOfH1hRtN2jcyCgNT?=
 =?us-ascii?Q?7vGIOrQ8gg6vBwGUHuigc9qmBFa6IEMOR6cO8s/efWmfdM5TBJODWL2a6WWa?=
 =?us-ascii?Q?iwlqKJzB7yTaYoCftOQJcNRFeGSm3iF/wvAl0KPfw3yeH3jMyOY7QILqRQjg?=
 =?us-ascii?Q?gE4Rd4KsmNmgLbWfg517jqYBFmEU+Av6BDwWnHsLljZkxQvRBTUuWCuwgoXY?=
 =?us-ascii?Q?21DL21wpVBJ6lqbbbZ+VQwCqkvD8/cjn+w8xkxpPhu1T0TqIzss5x3wBgDa1?=
 =?us-ascii?Q?vt9UZOF3ozOfpOZv1jwZVlhXp9o9T7gTP7KM+sc0UfyoZ3MYRBJpMOhmqjE+?=
 =?us-ascii?Q?WwkX1f+Pg+/wsUf/dUB+1Tu3XulF2d5l79o0jqe/E7Iq66HIhVoa9Xe5SMHc?=
 =?us-ascii?Q?NPBCaU/q+A=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 552c96d8-4929-4907-78f5-08da237a2e28
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 09:34:49.5295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sgXlN/jkGMvat+BMYfzE62YTiBYCUHrPcSpAdhuTMQ/lHlgz+1j2gc/8O5GzBpmLKXwPW0mlgYO6gm9NMPNk6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3968

On 31.03.2022 11:27, Roger Pau Monne wrote:
> Use the logic to set shadow SPEC_CTRL values in order to implement
> support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM
> guests. This includes using the spec_ctrl vCPU MSR variable to store
> the guest set value of VIRT_SPEC_CTRL.SSBD, which will be OR'ed with
> any SPEC_CTRL values being set by the guest.
>=20
> On hardware having SPEC_CTRL VIRT_SPEC_CTRL will not be offered by
> default to guests. VIRT_SPEC_CTRL will only be part of the max CPUID
> policy so it can be enabled for compatibility purposes.
>=20
> Some reasoning regarding why '!s' is used to annotate the feature:
>  * '!': the feature might be exposed to guests even when not present
>    on the host hardware.

As mentioned before I don't think ! is to be used for this particular
purpose. But this needs input from Andrew. Hence ...

>  * 's': the feature won't be exposed by default.
>=20
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

... only tentatively:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:39:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:39:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309973.526520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTHh-0005In-7q; Thu, 21 Apr 2022 09:39:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309973.526520; Thu, 21 Apr 2022 09:39:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTHh-0005Ig-4V; Thu, 21 Apr 2022 09:39:33 +0000
Received: by outflank-mailman (input) for mailman id 309973;
 Thu, 21 Apr 2022 09:39:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhTHf-0005Ia-KF
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 09:39:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f17f2af4-c156-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 11:39:30 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2052.outbound.protection.outlook.com [104.47.5.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-ysm3tfn-Opu5I8pZRFt2nw-1; Thu, 21 Apr 2022 11:39:29 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0401MB2573.eurprd04.prod.outlook.com (2603:10a6:800:4f::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 09:39:27 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 09:39:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f17f2af4-c156-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650533970;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=y4Qkx2U3uVXXFRRtspSsIMXdrA4QjjRbrU8X/5Qe4CM=;
	b=WJGLSdSS64KJCDoam/Lw809Wj8TAthqSZd7T/FF2LTt4NLnrUIku6HU/JyCbpM5DOdJnjh
	PZU2njInwojrOtxZ7tBYAqRa/LyFJ4QQAWSjd5AwfEcDgYPqwJDEKHGgiIm8MQkXCyOIRZ
	wyoOnO1NcphDdARktcrt3E4EbuaUWWg=
X-MC-Unique: ysm3tfn-Opu5I8pZRFt2nw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DoaLt7p+a2kkxjs/eTfcrJO2T+M+RqkR+ssLdx9ODK2YlzzKx+hAI8Nl+xtR6xr/V7QiSeIOYjvr6v/XD+TBSJDi9tbvjR7z45+uCPZofU1hA8y0IJNOixUK8nGSHDirASzPi4mZ8y1rWPiG6jjLKvWtM/3WiCAdhXhq6nWVTFjYBLQiHdSH/AzmLjfiVxo+3dtr+fjQckYfbEIchkc8i00CDOJdCVFAF0hu99NUL/W79+fJmSXYTo4BKjBv5txTmfFh6hJkPEWNClsa80RIsS0C72iN5ISd6mql6QucWmOy6+miZuYiynIlLyOcHXvEso9yWjcouM53TE3wu6buNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VFaAOGw15ZhpdmoNFHik/UtDGCLFuF8sa/fki2a9rP4=;
 b=EbfbgyAEeCyKZF7Taqeeaat/MPhA/rnsp8SdbgR4YX+4RTdqOKe1QIzEmbq5hLPSo7O2LF65St8voA6x8VWK1PghMlL+drUd+XW2/q2GUPrE5HuCLRyECMYZt6dHYejc7jSsH4/F+YFmOOn4w/vqyMc0VtUe1vWAQhns/gqsVgjb73ngG1x0p9YEwhjrKHzvqeqmRKJichgBzcjhSBvFYLSU162gDNb86WLQq4XstuVKug/b/nbXaiSUSmALASgQZMKKq815xHCNzsW5uGB8wb68M4mX+3hNFSkmMyNi5f7h6kVzyy4LmqbWXUIeGDQLJIEc7cVUraGwl4HE2XUf2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c5d18996-3ea6-8316-35cd-6490d4278183@suse.com>
Date: Thu, 21 Apr 2022 11:39:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for
 HVM guests
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220331092717.9023-1-roger.pau@citrix.com>
 <20220331092717.9023-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220331092717.9023-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9P194CA0010.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::10) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4b4c990f-8358-426e-5ec7-08da237ad364
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2573:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB25732448A3CA23CB1C0CD3DFB3F49@VI1PR0401MB2573.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5deNjyjcRkVUhzcdmre4CGoRndME5yEBg5IEBeyEu0jat568cImyVIyLxZVah+HMtme5PIG6KfBplhvL4uxAuCTL8nxEuLV0hcXt6PgIvXjK03egiR7u68vzfOHFPziUyxaZG0mW5g/w796OhuHUV+Hb50YhOKUSedq3Em8+/6glLIpujx8VG7+OeIe6YwfJCkYKB/UEFASDlXF3Q+yauMEcHy8hhrX/3c46e9L5cc3LvwC/QwUOxNbbKBJWOjiM1w+ungyQNqzcX3ebCGzN+pNrMZsJa7tZsBqNI1vwlpRNCn4hXTsbcGDMHDVvPSi4YUe0aO2yBJ1COmxM2OIi5el/zrWmd0OEa2hybCUEXeAO8krT1k8EnN3NLb1cMZHIy4qoRonwewfh3iVd4lMwKele9dVdhqqvd7U/lICxUXryHrqqZqp34nypA7KUTLlrUDqGhk/SnRx51cSCuwz06m+VVxW4qw0sTQxcdPNuLjN36AExXMokIGhCfi63S7Dr9PPVs2oGOpKbzaxca1UE8aXfxiX8iPqcDe6lbBVn8wglYEGLsMKdUAilf9JmuX1yJcUNTAv/DXjaaExY6HfQZ1rl7nFdxWOkSJZRGWQ8wMXc1p2kR3bubxcKjWSa4FlC/7aqr2/GhpjssywZwolHyLRQQUXSXki8Yb2ELvNbPgrNrdFMySf9IjDvYbcNJ5fhER/zV6M3tbAXPrFR9rGSaucegSPMEq99PPIlZV+xn7F6AZ3Vo0lfHJbyGTvfd0oR
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(2906002)(5660300002)(54906003)(86362001)(8936002)(83380400001)(316002)(6916009)(4744005)(31696002)(6506007)(66946007)(31686004)(36756003)(6512007)(2616005)(508600001)(53546011)(26005)(8676002)(6486002)(186003)(4326008)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KiqbUXKy7Aveneubetdb2taHJj+n3w19IvP6qk6MHwsqCxKTsi0GP9RNvceB?=
 =?us-ascii?Q?7I5Bk0fgxs4TZ13hc8MANov4b948SMwSiN9zI4v7uNYCG0aLyqfI87OuOX45?=
 =?us-ascii?Q?+cbeZNhwcrXbTMCEY+/HHo7z9/yS20AqE38d0lXlBMvoz+3hbxpPrO1goUIV?=
 =?us-ascii?Q?qMPNCAIAz/BLiYyNfXjmZChtbuYCs8qn8fWa4MAYEx8K4aQoMsPh8cVn7FKH?=
 =?us-ascii?Q?RU9Dv0pIMp9veSggFrrWG81BEw2TRuNabhztacoiYpMM/tRcgzKVWN+GNoEa?=
 =?us-ascii?Q?NX2oxnhtwesBYOTRoHoaUO1TejnZKBcqYWcC1dFiX4ehwythYl2cWq/9xCSB?=
 =?us-ascii?Q?gWoSHzvZ3syLjMD3vm2LyTStyc7YXfACK0+H4Yyu+pAU1q0U16vr6p6qdrgE?=
 =?us-ascii?Q?hGfa1CnIK/X0BkUwNOdF81WgWs5dcxEJzhzVPK7dxagIyT9inwQf+DArKTIB?=
 =?us-ascii?Q?XroEWaVcMCYyZ5X1H95VdiMvYyJKYLi2WZbajeU5drad7hrxpIQ+rIb9KOp8?=
 =?us-ascii?Q?sHIfl/v5lQKBsiCiCiMQFZDso2Sd26F8Wh+cZ2wWTRddWhNB1pwTTAGxdlus?=
 =?us-ascii?Q?yZB2aCWlBR2ytQtY48zyZZU0Lrj6r3HAFE+7K9YxoT7Xi1IRRs6DYTxGNfCX?=
 =?us-ascii?Q?+WJVjGv7RJHkIuZVF4rNx1llpIoRNkyuvA0g7iAZJ2DJGJcg3qiiMiq1BJm9?=
 =?us-ascii?Q?evbtJMuU7VuFER7CXv+ZfkegdkA0JooNpQEzD0LOgR27ct9JzC618L7rM4Ph?=
 =?us-ascii?Q?MTU8JuQr7Qi3uHz2OBqnx1obEIx1iTDQUJ0PBiGnuA9EXvkhh6ga0N2UNMrs?=
 =?us-ascii?Q?meev3yzbYrxXyDfj8AosEbdZJjGVJ4eIZSJTJpcGWtb3u38RNtXb/lC1e8fR?=
 =?us-ascii?Q?T1J5Zo8St2Ru+V1L2SR+8Kyl9gBzchQ83xmJGNV8IFQUP5lYJWy49UdwwDcd?=
 =?us-ascii?Q?Bqo+22AhSAftWjzMNsG3gyfIyTuN1UkyN8DNmScDNyU0sSitbXyEJ0OZLuKf?=
 =?us-ascii?Q?xQSdOBsSeG921o6TfHTFUwbuXSeuU0T7SEJaQH7Fbdwb6fqX0hhy0dvWLV1t?=
 =?us-ascii?Q?PgS14GcrgcUlpYC7yo0ibSuppsSgPk+MmVt0WNKwzhhHH721cOSMBHAZqJtF?=
 =?us-ascii?Q?5DbJEtNpXLJUrFQULaA43nEmv4Xc+l1S6LBKpMofbnXmWoqN4AJSrErhLvsP?=
 =?us-ascii?Q?xPxDGoQ+h2N5QqiLMRbqCoe5g2bqty21NqgE9b+IxS7/hjgANJ+7NUXlPSt9?=
 =?us-ascii?Q?foT1hXdRUcj72Mx79zmKzG5wRipkFo7j8fv870Qq1vnK9wuVWWTCShdIrOk3?=
 =?us-ascii?Q?ywJsVp5HYPfdbUlQuQUGcSqp1iHxUSY+NLyU7jk9pY5p/cSQrG39PMKp3lcE?=
 =?us-ascii?Q?P1ifpBXB5KLmx4kC9QhpWI7UrwmPYle6uiDXv6KOZuAY1jtV5FEUr58BWAt6?=
 =?us-ascii?Q?Tqp4l83qxt6oNJKnthA6vHWTxDPuIDOzXplbG9qWSGUW4dKPuwjIseOQGt3b?=
 =?us-ascii?Q?b7kaPOR+5Z72G3+YV34l/bqQRDJBgaT2YDQOsth1TTxwCO5uwTibuJpE5R//?=
 =?us-ascii?Q?SuvRcfB9Q9XVmXeQkofDGh0yf+2EUVuNBIdjxa1RULnxtVine+Mo7ds31zpY?=
 =?us-ascii?Q?yJyiFbk7vkIooWQcEdkLWyhqIFTylRGqKZiWgqhlznmmZADO1kXKHatuXTrg?=
 =?us-ascii?Q?ElnlnYAvYK+lpIGDr0z5pW8qbD8BSR9WFYYLZJSdSCkZhz7IIIH8Kl/Y5E3t?=
 =?us-ascii?Q?Tj1hXLzcAQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b4c990f-8358-426e-5ec7-08da237ad364
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 09:39:27.0430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KMke8k8cjF8txNcNCZEm85GzYnNiXLO0H5kH3vPCurTr79ys5VC1hJFyOxr14r+XUqm+VrL/o1m3UhRIi/2azQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2573

On 31.03.2022 11:27, Roger Pau Monne wrote:
> Allow HVM guests untrapped access to MSR_VIRT_SPEC_CTRL if the
> hardware has support for it. This requires adding logic in the
> vm{entry,exit} paths for SVM in order to context switch between the
> hypervisor value and the guest one. The added handlers for context
> switch will also be used for the legacy SSBD support.
>=20
> Introduce a new synthetic feature leaf (X86_FEATURE_VIRT_SC_MSR_HVM)
> to signal whether VIRT_SPEC_CTRL needs to be handled on guest
> vm{entry,exit}.
>=20
> This patch changes the annotation 's' to 'S' because it introduces
> support to expose VIRT_SSBD to guests by default when the host
> (virtual) hardware also supports it.
>=20
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:46:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:46:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309978.526530 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTO8-0006yz-UU; Thu, 21 Apr 2022 09:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309978.526530; Thu, 21 Apr 2022 09:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTO8-0006ys-RZ; Thu, 21 Apr 2022 09:46:12 +0000
Received: by outflank-mailman (input) for mailman id 309978;
 Thu, 21 Apr 2022 09:46:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhTO7-0006ym-EX
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 09:46:11 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9435b47e-c157-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 11:44:05 +0200 (CEST)
Received: from mail-bn8nam11lp2175.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 05:46:04 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM5PR03MB3179.namprd03.prod.outlook.com (2603:10b6:4:47::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Thu, 21 Apr
 2022 09:46:01 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 09:46:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9435b47e-c157-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650534367;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=5SUBrspTLvRt4QobPVFslbzu6SyJIfpnPnCedK6hGsw=;
  b=TIFzWmdsFzPZh90slCeUKxy+lsRnwe3ZZi/3qh9og9i8ia/3c4I95X+F
   C8v5D37KpwxOgr1aFQt/OCL4ChKBVNPOpsOeHUHCGrSz9VikJ/OePr3H2
   hYYv+m1dI+csQKPOdSexsdUpWu0HwGeF1Pl1PGEmk4RvI/ymsrUMOXf9M
   k=;
X-IronPort-RemoteIP: 104.47.58.175
X-IronPort-MID: 69993523
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:dD2696hR1425mcxc6VeTLb98X161gBEKZh0ujC45NGQN5FlHY01je
 htvWT3Sb6yKZzfwKdEnO9m18R5QsJaHm4NqQVA++yg1F3wb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nU4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YToIY7z2o8g3aTRZS34kLa9q+5zjPlHq5KR/z2WeG5ft69NHKRhveKc+qqNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuI8ehWht7ixNNa+2i
 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJpsjmCl1Eri9ABNvKEXs3JacZR3XyU+
 G7A9mfWUkoAF9KmnG/tHnWEw7WncTnAcIAYGaC89/VqqEaO3WFVAxoTPXOguuWwgEO6X9NZK
 mQX9zAooKx081akJvHiWzWorXjCuQQTM/JSDuk75Qel2qfSpQGDCQAscDlFb9A3sd4schYj3
 FSJgtDBCCRmtfueTnf13r2Zty+oMC4Za2oLfzYZTBAt6sPm5oo0i3rnTNl5F7WupsboAjy2y
 DePxAAuirNWgcMV2qGT+VHcnynqtpXPVhQy5AjcQiSi9AwRWWK+T4mh6Fye5/AQKo+cFwCFp
 CJdxJXY6/0SB5aQkiDLWP8KALyi+/eCNnvbnEJrGJ4isT+q/hZPYLxt3d23H28xWu5sRNMjS
 BW7Vd95jHOLAEaXUA==
IronPort-HdrOrdr: A9a23:1z4Mqq0Kspg6DihbOQ527AqjBetxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+
 UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf
 grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e
 iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ
 PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/
 6uJZM+OY6XEVfT
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="69993523"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DItxplop08xUHaO6FcDfv2apWRQZBP/kUNxI+kJUtwTLxz0cJuO5Cz5iNZ0YC4jP1b/AYL6us9RYYNyXgtUosHpDv1a7sCaAtL+GJTpxszjJxPSbUVMqO1YNMK4anZvffKhgtzP7BrkAwdOwIkCc3E3Bec+XFCfd141c05rNHKR61UR1VK+mhL6I/2a0j6yvdTcJw2VIT8ptyOEn/pcPGp6s2K/QsjUDNDu6mb5wEI+HEplNPKZIyR6tQUkMzLHgxQ5+o8BlxzN3RSzLD6jgQcdoSlOhRNYp71xk4wmM+70mvIkzXB/6cVpxzxxRFVHp5PxX9KB5lgLIvsbSvksEFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5SUBrspTLvRt4QobPVFslbzu6SyJIfpnPnCedK6hGsw=;
 b=DZ5ymCsuZ44HI9atoS6OKDIJzt8XIIiC0P5xUUJAJ/vkRP17BztljABn+ZpRxRllYgdnDRJ9TnYAd4vRBQJihNqYOsu8XSUOO5X8pmC4f66T67NMaFax0pKPbApdO1iKgdV7XBJCC95DGfkJUBb8URp0PWTpiJ5jueHq4Mb0epzDSNimSI2mNjMWfLelGPLYYHwrayDUrkoniLdAJjXJMz2jnc4PeK7uk34h5FVSyH9wR3jr25PAJgfuDRB2rQ1Vpw1Pv4FahsSU9qB0mqZFx9W7QCzF0U3DDHTpmQxYNg70ewPO92A3u7sHL9ly5nJitN84oHZ/WxZ7/sadNKKRyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5SUBrspTLvRt4QobPVFslbzu6SyJIfpnPnCedK6hGsw=;
 b=XVrxPItafdHzcEatLzaF2lW/3yuElm9dzmxcSXV3FmyJYS9k3b2Pp2413rC21CEFW+a3udw+lm33yviXHiE5/TMm813LTtVEF2R2r2Sbe8Szl+H33s8IL1sqRN8ymNdF80sccHCuCoJUIMl9kPTIALc+wBL0WD5NKbeb/txP0Jg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Juergen Gross <jgross@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Topic: [PATCH RFC] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Index: AQHYVM9arFIsZUO7iUKZeaUlLxEzCaz49teAgAEjSoCAAAV3AA==
Date: Thu, 21 Apr 2022 09:46:00 +0000
Message-ID: <84c7a32d-9ff6-0002-8e42-4583a776665b@citrix.com>
References: <20220420155657.32506-1-andrew.cooper3@citrix.com>
 <70490620-16d2-6045-f83c-df65540025a8@suse.com>
 <33a37e77-0e38-2c5f-6bf9-2313b5dc5dd9@suse.com>
In-Reply-To: <33a37e77-0e38-2c5f-6bf9-2313b5dc5dd9@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d270e99f-5e0d-4518-afeb-08da237bbe81
x-ms-traffictypediagnostic: DM5PR03MB3179:EE_
x-microsoft-antispam-prvs:
 <DM5PR03MB3179D23E1A77C93AF8C34E9CBAF49@DM5PR03MB3179.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 4uZkfyB5U1nB4q+SDnHiB3PO9JR7WQVhFOD9rkvYECxn2m+5p6whhRSAJx0i/X9hM8Og1Qn++25BpAHo/ytO5hAyBW3FWHmct3F93uZuXdwLdO3aq+KrhwzoIrPs4xj731GOuOOnEuQmOElpZuLNmfg5HUfQU+B33vZ6sA8OgHBE+mudTp+T/I3Tb07fiC5e0xA8JJiybYqDkt7l/jr9amilQwHgth7s6tfp0SSubPhzMQAJUJ/czg5unLVd0ZL41gOFhmfUA+l5/kT8A1r1VTDpePalZmYxH/22zaZonbpgT5Hz1xtK+JlTEsC1sIf4k5A6O//TPXVFWRVfUc9KU+Ic6dvdKhLmmHNgKYLIfzAhX7SBsqx0cJugk2ox0w48gvbn2W4ot+qIbohuXGkSKFJysmuYHPckaS2ALookco4NPw5mRPtJJxnQf85fiqPUVxbUb8u8/LFAg4XxMqnVmQjG6ZtdlQD2sHEkSISo2N6bS4Q/aSOdDGkawPorHu9cwVPQUD/2l2jqXj+r2WS9qp0GY9tK6RAu6vJXI5Iz1ZmJFfwx2EwM73GHksPcHDhT/xzU5QT0JryQjqKPGkRlXiUMgFRBdxcLGsSXqXLNO8ZUJ9uFxbQ4XtQg2LFrbB0XFsvr4UyGA/j/7DkoowezZli/HkxR3GLue8iWtOUvjAk9MvgyGkIZEGxlU1+UMhfHNWYjTTmNeh1Cdb8L+EZcqS+heDX8G6fKz4skg1K0gM4Ba/IwXBrmXW06CMcSgbyJ9E9BG2rrb25lyYoA5UNvTg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(86362001)(5660300002)(508600001)(4326008)(6486002)(64756008)(2616005)(8936002)(8676002)(71200400001)(66476007)(66556008)(91956017)(76116006)(38100700002)(66446008)(66946007)(54906003)(36756003)(186003)(2906002)(82960400001)(53546011)(6512007)(122000001)(6506007)(26005)(316002)(38070700005)(6916009)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bGhIRFd2QjdaZ09WR251NlVLUnA2SDhZWGRYbUV1RnR6SDVzSGJUTk9oQXhz?=
 =?utf-8?B?YTZZNzBVbFd0ZWtTTVhUcEN1Z2Z5UTNYaEJrVDRuR3Q0alpSaVZlcXg3eXFw?=
 =?utf-8?B?N0VYYmZadHdEdUd2ejUvOVJ6ck94Ri9iRWdDTi9Wejk5WVIvVlMyUUJ4TVp5?=
 =?utf-8?B?U0pmS2hqYi8zVnpBTEFrd000UlR2TFNkSkx0TnROb0lTTktIcmNJZTMvQUl4?=
 =?utf-8?B?SWJTYWZvQmo3RTc3a3NQbFBZK25jTnhkZXpuTG9SNE9wdFNCdCtCMUt5M2hJ?=
 =?utf-8?B?RmU5dU00V1dsZm1zNE95K013Wm5oak5Va1cxSjluNnNsNkNDdmVybjRqMXNt?=
 =?utf-8?B?ZTNhYVNhR09RTVgzMW44Y2pTM29MZHRYbGVvNE0vejBIVlJ4VEc0LzV0NDQy?=
 =?utf-8?B?L1JKRks3NWxKamI4Zy9EckE3TS9UZ2I0eFNsZ25MU3ZHOGdROVNuVFFnZ1dG?=
 =?utf-8?B?SHdoTitUR2hCVGlydmcvRFdhckRKSDZQSkZnM1ZXRFQyTmVWcEJ3VGpvOWhJ?=
 =?utf-8?B?RkEzSEl4OTAyUUxIUlZLeXRPb1dhTmZ5VUt6Q21lYThxNUplR1ZUN3I4VzBr?=
 =?utf-8?B?MC8wRGdoTFcyQU81b2g5enFKUC9zWjIrcDYzczBKRWRNcW1mbUY4MlByV3B2?=
 =?utf-8?B?K0pLcUMwaS9TVUpJb1hOOHlzNHhqSzBDd3RhTzRqNkF4dWF4T3RhYnZTb0VW?=
 =?utf-8?B?a2p6QXk2SnlWbXEwMzRQY1l6WWhuRlF5cG9YaThNLzNTWXVxeDYzcXU2OXVV?=
 =?utf-8?B?SE5yelVXeVdiUjN6UjdZeXBrREQvQkErdVoweWNyUnhiVHpUY1RYeGxwSUJo?=
 =?utf-8?B?MHdHV1A0SUF0TzdpeUhHQlV3cDhpWEtMZnpJWFN2aUNkRjc0WEViTVFZcUl2?=
 =?utf-8?B?REJpcFM4UjZkRHNIZ1FNb2JlU1d2Y0JqQ3JVcjBSWk5FbGY5TVhuK2tuMEsr?=
 =?utf-8?B?RkVCOGpQSkdpTklvNi9XSzJkdlM1TXdNVndBZ2R3c3dqMitEYytKSGVESXNi?=
 =?utf-8?B?V242K3ppKzRGVjZBVnBXSnJjNVNoT2hlVXRRWmd0OE1hZTdwamZvNUdkRmF2?=
 =?utf-8?B?bkJEdlNnK0lRY1B3Z2tiTEozV3NQZ1JSSGxCS09pUlh0Qjl4YW1UeGlvY1FO?=
 =?utf-8?B?TlI5WmZtN0dnaytDRlJINTlqNUVIUG9EbDZMZU1ZRVJZSktTSmdhamd1TGJu?=
 =?utf-8?B?YWJ6eFdEUk1YNXNXRUx0NzZ3dTR4U0E5b3ErVm0wTUJIYkVoaVpBdmUrMTli?=
 =?utf-8?B?WHZBZnd2ZWNER285SC8yM290ZTEzL05OaEdTc1NKdDkrQjBGWWhwaHl0aGdP?=
 =?utf-8?B?MnFuTGF6Z1k5dkpWUHV4YU5TTHNaZVo2dUV0clIvUjZkbDkvSU8vczRiRXpI?=
 =?utf-8?B?bDNWNjlyZ09LZGJKelRqb2JZaGVLNjhUemlsSXRaRnRsOG52WEJlRGtWWG10?=
 =?utf-8?B?bmpSMnMzTjhHN2NVRkx6MWtnVFFJVHF4c2NtY0ZoeE9vS2JjelBLc2Z2ZXN1?=
 =?utf-8?B?OUNYTjVZUndFbytzWnpHcUdZbTYrUnFNUXNlU3R3R3ppRFhvQ0F5WTdiQVRt?=
 =?utf-8?B?LzRrQXRLQkIyeUc4MUxYQ09sU3Rlcm9EK2wzdHhXUjJpNmw1Nkg3eTdLRFAr?=
 =?utf-8?B?a0dJbEUyNGIxNVNJOXpTbzJJZXdrN1ZobjRIb2RSMHBGNU5XK0MyQUwzd0lZ?=
 =?utf-8?B?TzZpQUgxQlVnRDdpZC9VNG1XM2hvRHFuNktEM2FsbmI1Q3U1STh0QlVqWHBq?=
 =?utf-8?B?c1Y5OW9TYlEvNVpzbEZSczRuOVZ4bzc0S3A5N1I2Ym9zRE1TNWdsTHFFT3lD?=
 =?utf-8?B?eDNBS2laYk84cmNPUXZDaFd2bDRCWEJ6NEdjRWZHeUEvNm9iVFBoNmREQkUr?=
 =?utf-8?B?NUVpSDZYSjNhVXdBZnJ3UW00VHk4K1o0MElUNjlHb2E0VGgyRWQ5amd4eG5U?=
 =?utf-8?B?a2wxWnM2bE5rZXFVaHREdjNRNVVJc3h3d1JqY09jWmk4cFhSNDVhbmppQyty?=
 =?utf-8?B?Uk5PYWtqKytSeXIvd1FEY2E5TCtYSEN6Z3dJVFpvbzc1aTFVS0w1b24zejJS?=
 =?utf-8?B?NlJRNStyNkRMUkR3OTBXNzBRVkJhTXBidkVlNU9xMG15cTlqYlFCOU5PN0Vt?=
 =?utf-8?B?RWFrTEkxR0hrekhrUXhJWGd0eEl1WHRYTW84VGtrNzBxS1lCUVdZK2lGVTdI?=
 =?utf-8?B?dFVDc1c1UzlDbUozbUljaWhTYjNtUCs2SVN0U3NhVHNoWThkUzZoNFJYdkwr?=
 =?utf-8?B?MmJWTk5keTlzc2pYSWtNR25TbytQcUdKeFZpNUJaemtHTCtiYnkzcTBOa3U2?=
 =?utf-8?B?dUdPNW92V1Z5MlFUQ0ZQcnVGYXA0N0lZUHRVekhtSy9ndVhINkRCZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0E1CE07ED2A31B4294A6AD7667F42FA1@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d270e99f-5e0d-4518-afeb-08da237bbe81
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 09:46:01.0153
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PjuHRcAotVM9We10anlHEWWpH+rpTVxTHQuO1MTo7DCi1mSP1cE+/+GOv3/fDY/DzdITXCDLQxCcOZeUUg3R6XBVYUpVEcoRZQ8kYvm8DVQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3179

T24gMjEvMDQvMjAyMiAxMDoyNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIwLjA0LjIwMjIg
MTg6MDMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBPbiAyMC4wNC4yMiAxNzo1NiwgQW5kcmV3
IENvb3BlciB3cm90ZToNCj4+PiBXaGVuIENPTkZJR19HREJTWCBpcyBjb21waWxlZCBvdXQsIGlv
bW11X2RvX2RvbWN0bCgpIGZhbGxzIG92ZXIgYSBOVUxMDQo+Pj4gcG9pbnRlci4gIEl0IGlzbid0
IHJlYWxseSBjb3JyZWN0IGZvciBwcm9jZXNzaW5nIG9mIFhFTl9ET01DVExfZ2Ric3hfKiB0byBm
YWxsDQo+Pj4gaW50byB0aGUgZGVmYXVsdCBjYXNlIHdoZW4gY29tcGlsZWQgb3V0Lg0KPj4+DQo+
Pj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv
bT4NCj4+PiAtLS0NCj4+PiBDQzogR2VvcmdlIER1bmxhcCA8R2VvcmdlLkR1bmxhcEBldS5jaXRy
aXguY29tPg0KPj4+IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+DQo+Pj4gQ0M6
IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+PiBDQzogV2Vp
IExpdSA8d2xAeGVuLm9yZz4NCj4+PiBDQzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4N
Cj4+PiBDQzogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+IENDOiBSb2dlciBQ
YXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4+PiBDQzogVm9sb2R5bXlyIEJhYmNo
dWsgPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPj4+IENDOiBCZXJ0cmFuZCBNYXJxdWlz
IDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQo+Pj4NCj4+PiBSRkMsIGJlY2F1c2UgdGhpcyBo
YXMgaW1wbGljYXRpb25zIGFjcm9zcyB0aGUgY29kZWJhc2UuICBUaGUgdGw7ZHIgaXMgdGhhdA0K
Pj4+IGNhc2UgRk9POidzIHNob3VsZG4ndCBiZSBjb21waWxlZCBvdXQ7IHdlIHN0aWxsIGtub3cg
d2hhdCB0aGUgc3Vib3BzIGFyZSwgZXZlbg0KPj4+IHdoZW4gdGhlIGZ1bmN0aW9uYWxpdHkgaXMg
Y29tcGlsZWQgb3V0Lg0KPj4+DQo+Pj4gVGhlcmUgYXJlIHNldmVyYWwgd2F5cyB0byBleHByZXNz
IHRoaXMuICBBbHRlcm5hdGl2ZXMgd291bGQgYmU6DQo+Pj4NCj4+PiAgICAgIGNhc2UgWEVOX0RP
TUNUTF9nZGJzeF9ndWVzdG1lbWlvOg0KPj4+ICAgICAgICAgIGlmICggIUlTX0VOQUJMRUQoQ09O
RklHX0dEQlNYKSApDQo+Pj4gICAgICAgICAgew0KPj4+ICAgICAgICAgICAgICByYyA9IC1FT1BO
T1RTVVBQOw0KPj4+ICAgICAgICAgICAgICBicmVhazsNCj4+PiAgICAgICAgICB9DQo+Pj4gICAg
ICAgICAgLi4uOw0KPj4+DQo+Pj4gYnV0IGdpdmVuIG15IGRlYnVnZ2VyIHNlcmllcyBjcmVhdGlu
ZyBnZGJzeC5jLCBJIHdhcyBhbHNvIGNvbnNpZGVyaW5nOg0KPj4+DQo+Pj4gICAgICBjYXNlIFhF
Tl9ET01DVExfZ2Ric3hfZ3Vlc3RtZW1pbzoNCj4+PiAgICAgIGNhc2UgWEVOX0RPTUNUTF9nZGJz
eF9wYXVzZXZjcHU6DQo+Pj4gICAgICBjYXNlIFhFTl9ET01DVExfZ2Ric3hfdW5wYXVzZXZjcHU6
DQo+Pj4gICAgICBjYXNlIFhFTl9ET01DVExfZ2Ric3hfZG9tc3RhdHVzOg0KPj4+ICAgICAgICAg
IHJjID0gZ2Ric3hfZG9fZG9tY3RsKGQsIGlvcCk7DQo+Pj4gICAgICAgICAgYnJlYWs7DQo+PiBJ
J2QgZ28gdGhpcyByb3V0ZS4NCj4gKzEgaWYgd2UgYWxyZWFkeSBzdGFydCBlbnVtZXJhdGluZyBz
dWItc3lzdGVtIGRvbWN0bC1zIChhcyBwcm9wb3NlZA0KPiBmb3IgdGhlIElPTU1VIG9uZXMgYXMg
d2VsbCkuDQoNCk9rLCBzbyB0aGF0IHNlZW1zIGxpa2UgZ2VuZXJhbCBhZ3JlZW1lbnQgZm9yICJ3
ZSBzaG91bGRuJ3QgY29tcGlsZSBvdXQNCmNhc2Ugc3RhdGVtZW50cyIgd2hpY2ggaXMgc29tZXRo
aW5nIHdlIHNob3VsZCBhcHBseSBhY3Jvc3MgdGhlIGNvZGViYXNlDQpnb2luZyBmb3J3YXJkLg0K
DQpGb3IgZ2Ric3hfZG9fZG9tY3RsKCkgc3BlY2lmaWNhbGx5LCB0aGF0J3MgZ29pbmcgdG8gd2Fu
dCB0byB3YWl0IHVudGlsDQoiW1BBVENIIHY1IDAvNl0gQ2xlYW4gdXAgY29tbW9uL2FyY2ggc3Bs
aXQgZm9yIGRlYnVnZ2VyLmgiIGhhcyBnb25lIGluLA0KYnV0IEkgZG9uJ3QgYW50aWNpcGF0ZSBh
bnkgaXNzdWVzIHRoZXJlLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:50:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:50:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309984.526542 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTSC-0008LS-FL; Thu, 21 Apr 2022 09:50:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309984.526542; Thu, 21 Apr 2022 09:50:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTSC-0008LL-C1; Thu, 21 Apr 2022 09:50:24 +0000
Received: by outflank-mailman (input) for mailman id 309984;
 Thu, 21 Apr 2022 09:50:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhTSB-0008Kw-2N
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 09:50:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 756cbbb2-c158-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 11:50:21 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-KM3JTh85NwSjjbCmQXVoBA-1; Thu, 21 Apr 2022 11:50:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4164.eurprd04.prod.outlook.com (2603:10a6:208:66::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 09:50:17 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 09:50:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 756cbbb2-c158-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650534621;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5ucCWd1m5mJy2RGEuB9NX07OlO0Yl5UzMnQ2LuAVDK0=;
	b=d6HrfzmnbBVySP4ZkfnVSN96AcuemM0jCf/daKXJ5W4WnLWKLPWb9GPw2VWyys9/eK9psT
	uFL7cqE0pHqmUxnh0mHLbCG8ifXzdVXzA1MFATMCaeQEO3e2jfCESeJcVZEwBJmfubczvf
	KBY3ajl5EfcpcbjHuwkZQNu8Z8nXeZ4=
X-MC-Unique: KM3JTh85NwSjjbCmQXVoBA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VgzJKduuTEBZUA1D3GI8L9Ucs9GwPbCCSrdrmt5d7NHzvvTTuh3jQBkuBnro8NDeM1+trzUgbDlKCJh58PK2xL0MiHZCSPwI8LZ2I/9glpbq9DPtEEn08+C9+Nc1r30I+kEI6hScKRGb10YOZnVYAwvda8qqZ5PgfemdjHcfOHk013WkaxKMb8Et327S1HsgXjgYg6s2ctMssfFNBSAxzBGvnFLJkDBuCsub3Xeqtfze8KwkRuBdIXSGNCtt9AeWr2Wb+6RKOMY2HE1qAtEeOCzY1aMXn8+FkGFMgyt1cxDUUwCsHiy1xsA/TDcQ1/Iz+vo9NpurrBdfs8mnhA2yvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5ucCWd1m5mJy2RGEuB9NX07OlO0Yl5UzMnQ2LuAVDK0=;
 b=HahP2DlJS8XZwbOS/51QqeLbx/6C28SC4pOykRhOXIvFrHC6On0phNhgI57dkDdqPyiTKBE00OsHu9uq9X5pnsTvBIeR1o4eoT8TPrJwu7mbUjf1cj8IwHTRmei+JrKX12UtGjDd9T2GAs0A38BTs7a03wG24egzsCjWOBTKWL+OMKST+FRX4zWI5efRzGGosjsqhIYIXXTurebxUTzVlh67p7HivJojdtwY+xz08flMHoi00sdVknudqwIJehYNjzWvOz5T4IsKnERrlUoum/6C2AgUEQa1c+WFTQTjkBo540KMMhl8gH8wW0Tw71NpeOYoPeLOwalBOQfYgnq0ag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0bb48681-a78f-d32e-f989-822dd5e54b70@suse.com>
Date: Thu, 21 Apr 2022 11:50:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220331092717.9023-1-roger.pau@citrix.com>
 <20220331092717.9023-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220331092717.9023-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR05CA0010.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 61f26bb8-0c4b-42f7-f513-08da237c576e
X-MS-TrafficTypeDiagnostic: AM0PR04MB4164:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4164F8A65E6F5AA3B8869B1DB3F49@AM0PR04MB4164.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hGemch1Tsz2txySXItxkMXJjVBVD48H54vR3i225Ag36yZhSJYx7cFJynNoPnMgQk0PYtOSSUYEz11VM7+gcP5SfwgH9eAND5qlnrzUJ/BcJ1DAMAKXMoT7VAHpnX9lNZxCakGcUyxPD3xhevFwnygbf6lhOTSZ2YOHJQ02yWt/TIqok4KiczXCdnb/jMD1ThggVqifYonxMaxp6lKJkmmppd726eTy38G9hjcv8cAHZqFpV/xtnBeKJMNUyNAtO3wggKRFPs0bsr5W0dknmHcAv65qhHFlcaqlZe6pgkDptJjk4MPSXvZ8U3PuWH2ypUAI/zXESOerlY87HeY4UM035kcc0tTr9nwLMdhCZ+eF757NN6tZp/OjoltEW8DgPqnv+ECOluiDu00+Y0HBnCXiNV1iplq9rjyl/hZxlN6NFK2vQkCywpgMo1EoPrZU5+X2hwQuQzIGw2EH8Mo+tYT9HZ6Bqoyi9sMJdpZArrdmfCuljJHykmVOnNG5k2hCbVV1AF9MqygxLrpoE+yzZFzWgIsSIjJ6Dp0cbcNWrQxKo5fqXfD+tni+ACr0Y+wLT7Z8vwXLezBCYV+9uLmZnZPbl8USA1T7f3PxwV75QgIMv/69525Y77SQNFBs5QPKl0/IvSxlKSmEZIQheBfqtr2BPCLn5vUquauWUYU0If0iPM+oCLlceHmQy3q34rVBfUTMmVot9N+48F6wUuFBqvftCMQkOTWdbcyKMBwrT6pgTK0F4RKSRDyNvqr4pJvSP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(186003)(31686004)(26005)(6512007)(2616005)(2906002)(36756003)(8936002)(508600001)(66476007)(31696002)(6486002)(38100700002)(86362001)(5660300002)(66946007)(66556008)(316002)(8676002)(6916009)(6506007)(53546011)(4326008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?enIxaHliaGdUQUJyaURSY09KMVZDZjVrYUZpMlBoZGlUakErT0dldlZiZVhI?=
 =?utf-8?B?dG0zbVRuWXlYSmg3bFgvWERvUGg5a2NtYmtUbGtSWUFNQWVVeWZWVjlKZkl2?=
 =?utf-8?B?Sm9zeUFIdFlqdXYzbXNxTXBSSld2bG9TL1dqYVhvMC9UTjFyNG5DZU51dGlu?=
 =?utf-8?B?ditSUFdBR013OTVRdGU4ZSsxVDhnRnQ2RnVXRkpOTk4xRmE0d2FyMzF4cTIr?=
 =?utf-8?B?TjdXeVNTa1NCb01ncllhUitJRWZ0NVlDLyswSUdzcXQ5S2M4T2NnQnQvcTEw?=
 =?utf-8?B?NU5JeVNyMXY4YWRpNWNtZm5tRDl3eUFxNmt6WmZPOVBGWGJhd0tqTWxRWkt3?=
 =?utf-8?B?TWV0ektzTzBrUVdjd2lka2lZRkhTR3VvQjF1c2NOTzFtTTJDbnF0TDNHYkNt?=
 =?utf-8?B?N1ZBdGdhYkd0UE9iMHNKME15WlNEVjRKZ2pWSjFwRVplNTdOeWcraG9UeHNh?=
 =?utf-8?B?Z21Jd2NoWncvNEIrbXZmdFduTGxSN0RZb3p6N3JIZDFKUDZNcExyZitWRzBE?=
 =?utf-8?B?V1ptMXN5OEpIQmozWlBzSkFTcVlwYVo3MVR5Q2NNVGNBQ09WcnB1NWI3WnhV?=
 =?utf-8?B?T2JZbmdNU2JYVDJ5VUhhcGxKazh4bDZPZzVOU21JVXpCbmN0ajZEbzBBQWJM?=
 =?utf-8?B?MVhMdlR0Z3dVQ05haGtqalhNS1lGSE1IVTg2TEwrUXhYelQ3d1Q1OGwreXUy?=
 =?utf-8?B?TEpxLzRBY0I1VzFwMUV2bWdjNVBNQzhkOHd5RFluN1orajhMZDBZWnFkQXIz?=
 =?utf-8?B?SnNVMmFmV01vS1RLRkVjZzFzclFIMHhJVTU1RXNqQzJkVHJmTysySXRFMVV0?=
 =?utf-8?B?Y1RteVhoNk1HamJ4WmZxVXdpdWZsTmtXQ1paS3NSdUpWUWFwcWI3Ui9LVUNO?=
 =?utf-8?B?S2VOVmdhQVp0aVF5MDRreTI1U2FIaFp2dStsOU9WZFRBbzBXUWtvbW9YWkFK?=
 =?utf-8?B?MittZTg0RFRhN3kyWktxd2JZeElsOERxWDlRMFYyK3RidjNKZ2k2VEdDOEd6?=
 =?utf-8?B?WEpvSWdDN2NYamlNSGRyaE1yb0ZkZ0NEZ3dsa2diNTBxbEY1ZFdpVGx5Qkxz?=
 =?utf-8?B?UllNbzRtNzV5VW1xZVhvWWhNOGxwWUFud3duSGpKdUxkR0ovdUpZS2MxMG1T?=
 =?utf-8?B?Sm5VZERkTlhtWWNsd3RaSHhwMSt0UnUyMmQzemlDaEtFSDd1TXV4RHp1NkZH?=
 =?utf-8?B?WUY5UFhSSFRtbVZzNXZ0NjFJb0VYeFhoeG9ndmlSQXRhbmpQU0MwKzZ5a1lD?=
 =?utf-8?B?TThrYVZNQ3RFSzJlb0xEaVNoRDhNRG1hQ1RNbGI3a2tHTG8yYWRPejM0Nnkv?=
 =?utf-8?B?T0l0NURsaVFJMnFYRU5mOW56U3E0d1hCSW95TDFSL0Q0Nm56MnBheldkcWQw?=
 =?utf-8?B?UnBpSlhWUStOR0x4NWd6WUpqUUY1VkQvWVVEbTRDQUxNOWFxQjg5U0dHMDJY?=
 =?utf-8?B?bzl2U01MTmRHQWdOR0lDd3FqS0kzNDdOU29IWkg2THhRaTNCWHRYNVNDbmgx?=
 =?utf-8?B?RjJCY0tPb1JxS0lFTVJLRWZqSFlXSkQrNWV4SkpCbjFLQmhMNDhlN2tnK3Fm?=
 =?utf-8?B?VjNvSmNpSEdCcEttajQxb1l1NEpWcit2VmhZTlNsMWlESzVHN2tCcWQ5dnZn?=
 =?utf-8?B?Z2NGbFRDSXdYQTlVRytYZ3hXTVA0QXhZR3B5TTYvaFRCYksweE16NEdPcTEw?=
 =?utf-8?B?UytqMUg3Q01aU1diQzV3dzNyVWtZVmlrVmVBeWM1aHlPUzVmWTFGTGNLTTQ0?=
 =?utf-8?B?b3Rvd3BxUlhFMEFnM1pWRWJMTDRVeGFEWXdxdDFPbkc0MElGZXp5T0tTd01p?=
 =?utf-8?B?TU9nK1IwY2llY0YwYXNBc3h3ZkxsWVBjb0V3ODliQ3JxZzRTckdtdVp5M09T?=
 =?utf-8?B?TEtKT1BOeExnNlZubGVKK28zNDBQMURWWEJuOTN2TzEwOGVpVmI5NW1PbDVX?=
 =?utf-8?B?N0pUak9PY3JDNnFqYWdQdTNWOU1GL3Q5SEk2TjdUREo5NS9kOHo0NFVnUTMw?=
 =?utf-8?B?OVYwd3FYRjdId09DOFQ4L05RSG0vcXNPV0t3RHNQVTZyK2Z2dUdzdnpzMzhx?=
 =?utf-8?B?NEtmVDRrT1JBUy9TWksvS3FQR2xFWGRuTzgzMUIxVzRwTUxrb2Vuc090Uko4?=
 =?utf-8?B?WHlBaUxZclhkN09HQ284eU5OVkVlWUQ2aTVWRmVpZ3ZNQ1hDNUZxNCsyOUlG?=
 =?utf-8?B?a0ZDRDRoT3hRTmNQRUFWeDVldWt0eTNWekhacmY5eUtEWDU4YkdjYk5rSTRm?=
 =?utf-8?B?VU10QWVpMlh3WmY4ZWlpTmEzVDNRYkZTZlA0RU5IK1R4cHo3Njl0bklQT3E2?=
 =?utf-8?B?VzUvNXZBMTFlTGhLb3lHY2lzdSt3R2dqVzh4RmkvWlFQTlVLaC9pZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61f26bb8-0c4b-42f7-f513-08da237c576e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 09:50:17.7558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aVzFUsQpxqyYIaBSDUWZoRTBtK8H/xXYnYZIG2bmBxCUUWNkYW0iDsoYc2brLDojEHjScLwrHkhWYaSCHbxB0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4164

On 31.03.2022 11:27, Roger Pau Monne wrote:
> Expose VIRT_SSBD to guests if the hardware supports setting SSBD in
> the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU
> families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD
> allows for an unified way of exposing SSBD support to guests on AMD
> hardware that's compatible migration wise, regardless of what
> underlying mechanism is used to set SSBD.
> 
> Note that on AMD Family 17h (Zen 1) the value of SSBD in LS_CFG is
> shared between threads on the same core, so there's extra logic in
> order to synchronize the value and have SSBD set as long as one of the
> threads in the core requires it to be set. Such logic also requires
> extra storage for each thread state, which is allocated at
> initialization time.

So where exactly is the boundary? If I'm not mistaken Zen2 is also
Fam17 (and only Zen3 is Fam19), yet here and elsewhere you look to
take Zen1 == Fam17.

Just one further nit on the code:

> +static struct ssbd_core {
> +    spinlock_t lock;
> +    unsigned int count;
> +} *ssbd_core;
> +static unsigned int __ro_after_init ssbd_max_cores;
> +#define AMD_ZEN1_MAX_SOCKETS 2

This #define looks to render ...

> +bool __init amd_setup_legacy_ssbd(void)
> +{
> +	unsigned int i;
> +
> +	if (boot_cpu_data.x86 != 0x17 || boot_cpu_data.x86_num_siblings <= 1)
> +		return true;
> +
> +	/*
> +	 * One could be forgiven for thinking that c->x86_max_cores is the
> +	 * correct value to use here.
> +	 *
> +	 * However, that value is derived from the current configuration, and
> +	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
> +	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
> +	 */
> +	if (boot_cpu_data.extended_cpuid_level >= 0x80000008) {
> +		ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
> +		ssbd_max_cores /= boot_cpu_data.x86_num_siblings;
> +	}
> +	if (!ssbd_max_cores)
> +		return false;
> +
> +	/* Max is two sockets for Fam17h hardware. */
> +	ssbd_core = xzalloc_array(struct ssbd_core,
> +	                          ssbd_max_cores * AMD_ZEN1_MAX_SOCKETS);

... largely redundant the comment here; if anywhere I think the comment
would want to go next to the #define.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 09:53:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 09:53:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309991.526553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTVU-0000sG-1f; Thu, 21 Apr 2022 09:53:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309991.526553; Thu, 21 Apr 2022 09:53:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTVT-0000s9-Ur; Thu, 21 Apr 2022 09:53:47 +0000
Received: by outflank-mailman (input) for mailman id 309991;
 Thu, 21 Apr 2022 09:53:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhTVS-0000s3-DB
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 09:53:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id edef64ec-c158-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 11:53:45 +0200 (CEST)
Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 05:53:41 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BL1PR03MB6102.namprd03.prod.outlook.com (2603:10b6:208:31c::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 09:53:40 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 09:53:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: edef64ec-c158-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650534824;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=YelKCCOI5rhVFrYcp8VpBbDStP1lpfebB6WivQMkquo=;
  b=EDdHgo8akumLUq7yDWrhN219FUSpRLsB5kphMbeklr7skQhF9nYesYQG
   VUnFxMVAPd5gEoDY5xbmP3H3hUqQHhjpq/z3Id3ACXh57AMjiqFpgQXQR
   YxqaMcR9NNam7w7PQNRBcnRXRYYCd76+woTTgwVK0UdCm6n9EHJBQg51m
   I=;
X-IronPort-RemoteIP: 104.47.70.105
X-IronPort-MID: 69612332
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:7tamc6g8DPQJHfjITSgohtI0X161IRAKZh0ujC45NGQN5FlHY01je
 htvWG2Bb/iLMWGgf4h0bom3/R8D6pDWnYMwSFA9/iw1Qygb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nU4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQwYBKnvl+I0aSkCTT1BYoRnypPoHkHq5KR/z2WeG5ft69NHKRhueKc+paNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuocehW9t7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9gPL/PBsuDK7IApZzqW0EOaSRt22bOZomUHJj
 Gvr3GCoK0RPXDCY4X/fmp62vcfDhTj+WZ4SPLSg++R2nUaIwWgOFBwRU0D9qv684mauVtQaJ
 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O9M97AaB26/F+TGzD2IPTiNCQNE+vcpwTjsvv
 neWm/v5CDopt6eaIVqG/bCIsXW+MDYUNkcZeSYeSQIPpdjkyKkxhxTDVMd+E4a6i9T0HXf7x
 DXihDMlm7wZgMoP1qO61VPKmTShot7OVAFdzgfKWmOo6CtpaYjjYJangXDR4OxcNo+fQh+Et
 WIdhsmFxOkUCNeGkynlaOcHEayt5v2FGCbBmlMpFJ4knxyh9XescoFX5DBWP1pyP4APfjqBS
 EPctQ5e/pZ7IGqhbagxZZm4Tcst08Dd+c/NU/nVap9EZMd3fQrepCV2PxfIgibqjVQmlrw5N
 dGDa8GwAH0GCKNhij2rW+Ma1rxtzSc7rY/Oea3GI92c+eL2TBaopX0taTNisshRAHu4nTjo
IronPort-HdrOrdr: A9a23:h1Y7A6tPM2pCa+IOYnAxriRA7skC6oMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH
 PQ3LswmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZXbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczKgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxenkPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesaMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO21GkeKp
 ghMCjg3ocWTbvDBEqp/lWHgebcFEjbJy32DXTr4aeuontrdHMQ9Tpr+CVQpAZDyHsHceg72w
 31CNUWqFhwdL5mUUtcPpZ0fSLlMB27ffrzWFjiUWjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q
 6xG29liQ==
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="69612332"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k1jC+cHEnVv/iKXWkRRrVsFghsExpZp0QEOM7kubGEounyNB6YD4TPiCD8+COuDzzn5gcnlhrFfRKuurklNoLARdqRltyv3hxcywGF0A5SIPB4qsWbhdzfAw1f88ykxIi/nikXFr1ye22BUxsXml1tShW0T8txLcv85lgMjs2Tk3T/Ss/iWYL5UJFGEKf1XbuMmIBEBZs4bop5rSd2XeLt2TrXU4SradN37wOXadHbbDXk5sBBWsHokdtpsG49BfmByxKQijjCq2tza4q/XvtIRJZHy9vAHJcAOTQIn2YBUAYCJKV90d9cjW2hPifVsCbcKhrEYIEMaWgkKy4C7svA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ifnSTuDJqOZURT7kjFvAZMERUIas8xwYlFOSRtNG4cQ=;
 b=WsUJu8qms5Q0mc7iMmVolk3FkSu8X/23X71/T79642MRcYLvwqka3VaaImt102twIesL4hMLmYdgVO41Xh8fV+5k8NriUSr0EgLpmVGoRxQtj2aXTHUI6EtnPaddBbszs9jGJGtMNfGAjn1QrGqRtICicEU1/A1dP04p1oWcDvQObhZzA2upa4WlY7Ku0j1cfmaLTPZFv99V4aQWWLi9R/sNE7lTNleAIH/qXH5ERhTV/RuUeAI6DDNFxSEhCJiYRCLg7qVbbO8ssBos2cwd5wvzcwZRM8LkJRr5y25HvN19SZ4uckV6VkjpckRX2BWPGAZlFZcwiczdF4KVrXbOWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ifnSTuDJqOZURT7kjFvAZMERUIas8xwYlFOSRtNG4cQ=;
 b=NUaDQ/i4rm1uyHxRkBsBUvyYrI0c3P0prDR4MjgDerjiEZQR3qwxp0l67D+WFrAx1EuJVgW/I8OfbCAj36qB23zsSEgWoUE+bAizHOAJ+rCEiTh6fHdAgO/poX2q4Hvy9Q5db4eM5gevOFhvOERViSRiqcCgszQE/GR4hvWD7wg=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 21 Apr 2022 11:53:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>, scott.davis@starlab.io, jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v2 1/2] xsm: create idle domain privieged and demote
 after setup
Message-ID: <YmEpoDHpGP3xkAQ/@Air-de-Roger>
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
 <20220420222834.5478-2-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220420222834.5478-2-dpsmith@apertussolutions.com>
X-ClientProxiedBy: FR3P281CA0068.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf9bfdbf-fb08-4c6d-890a-08da237ccff7
X-MS-TrafficTypeDiagnostic: BL1PR03MB6102:EE_
X-Microsoft-Antispam-PRVS:
	<BL1PR03MB6102C29D49B9E94C49A144328FF49@BL1PR03MB6102.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0ssmGI6n2QrZRNxBM8iSPQsDV83uQKomDJz+1Ru+ETdbMrBElfgn+HQrl+1mCmsYtgt630Y4INF16CZHdNdwmfkdmXIMX0GcEayBHLvFMVwxPBRX9n+ACsqYLAVdDcLUszjGhCC1/6FRZ5IUvHaz0kr2P5x5Uy+JlXGsZ3FjfNz7ghNjKrt+OtetHM1ZiibG2zoNHFeA9i5T0xW6SKiPFEdyKuLdf+uQ72qFMp1G/DrlTLLEtHso/Y/7gSxW+WpcPV6VF8mVkTdtGvEoIHTGOA0YvH19gYdYUciUWxn3uKRYnyWHARp6DpwgEZnhh+UhIOvodwn6kRLJD9vB918IG5x4Qs4dPfqEqxgL5ffLYjCxYMghysv2c2WnNsuLWBGXZvFcZ79KZY5voiL3afwBm4nFWhZveLogLj3vfX8F7zKUOHcnRSnBeGmbzIAZOhJZAbjW28SMxxkpDU3K4EaIya1DC9GlJzOCIJjWATZBJiKzTzZcMj7lKIN+D3TYISPjb9AtWRTL5o09ntj7I6Xu44QY1fzO9tnBKjK54A5AEyVD3G3QTWDGAaHsC96R6/15vC2m2qqa/v1/6SQDHrB4mNsIJ29KpaSDDehZkHBeXS+D/1tEiabu6e3mfZWZEvkSty7Q+WuWdLJM6vkYYLky8Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66556008)(66946007)(85182001)(66476007)(86362001)(8676002)(2906002)(4326008)(316002)(38100700002)(33716001)(83380400001)(26005)(7416002)(54906003)(6916009)(8936002)(508600001)(186003)(6512007)(9686003)(6666004)(82960400001)(6506007)(6486002)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VEZlR01MQTlSdEFGSGZrcGtKcDlOdHJ5MkN1eVBrZzFOVzJ6SjlCTm8zVGZO?=
 =?utf-8?B?NHNxb2k5ZFF3RWZsWTJsQ3dZQ0dwZnNGbHc1L2xsbUczNjg3Zk10cy82dFNv?=
 =?utf-8?B?VzBFckZNanJkNlgvZ3BiTTQ0dmF5aURyWGRRRkkzVFFTTXRQY1EzclNrQ0tu?=
 =?utf-8?B?cHhvd25TdnFKdjlsa3JCQjlPbDdabC9FYTFpZm1ucGR0RkdRWXR4UUNIS0hn?=
 =?utf-8?B?emxnRGJrcWVxMDdBMzdzcWdNNHUvOWYzenNqdG1jME9oMVBGTjZzRElxTjBn?=
 =?utf-8?B?Njc0S01MdkozTmFhNDEwT0VzZklwNDB4TnFPUzRCOXE2UXpoOHdhbmtEbmJD?=
 =?utf-8?B?b1FBYW9lVTF1d21TajBzTG1aUlRTYS9zOVlXeWJjQ0JXWFNqeXpNZFZ6dkp6?=
 =?utf-8?B?YVRHeERYV01vQ0lGTlZreWo2TXZnY1JVOEgvdTNoL09YeTUyVmRJUjJBR1Zs?=
 =?utf-8?B?RlNzQ2lqUEJrMkdUNE1INjhWU3hhMWgwcHZVZ01CdEFuOW9pVmZ4RjEzNEp1?=
 =?utf-8?B?TzVVTlBhekluUXk1dWk4NUFNN3VnYVQ2NnIzMmd2czBLZHB2VHB0My81cVda?=
 =?utf-8?B?ekpWNVVJdVp2SHlMdVgvSkNINy81ZFNCWDVEaEFPaVd6Z2toeHl0SlFhUkRv?=
 =?utf-8?B?SGQ3aEkwYXlVL2tEeEg5alFIWGpPbWNtc1Fub3gxa1U4LzhPaEpCZkhqRGU3?=
 =?utf-8?B?ZXNXS0kraG53WWhVY3VMcW1uRm02Z29Xc1BNT2paMWt4Q0t6bjVWeE54WGdG?=
 =?utf-8?B?akY4TGJXaVZGRHZpVDRUM0tuajdtL1FIRk9jZC9WRjB0S3FvcUU3dkFRdzJR?=
 =?utf-8?B?ZnRNayswSWlaMWtUQlBRdlZQRE1mQkZ6MHhHN05TQm9Pb2lSWS8wOE9CWFdz?=
 =?utf-8?B?Y2N3MmNWMWsraU5wbjJGQW5PQkxBajcvRDhlSnZXNEVrS1JRWnRZUVV5eTgy?=
 =?utf-8?B?RUJuL1Zra3R3VDJHVGJZa3JSQkR4ZEdVWElUZkNTd01CSlY4UWowTlA4WW9Y?=
 =?utf-8?B?ekgwWndGRFM3cFVyd0dHV0tkN1Z6Rkd0bXlrVUZRRnkzVFFXVlVTZUVIbEpE?=
 =?utf-8?B?cGNMMlFpTlVUNFk1WklLMkNyRjRGUm1ZODBjS0lndEpIenIyTXNQc1NUUFB5?=
 =?utf-8?B?dnVCbzExd3RtblBBd3RYcE9WVThMNnBzY1JMbFZHcit6MFlWajBoYmk4MFp5?=
 =?utf-8?B?YnVySDFTRTZXaVlDQVNuQzl3REdZcWNVQ2dLay96WnkxMVZ5bXBmYmltZzRK?=
 =?utf-8?B?aXhMdGVZWE5ubTVHWmpxMVE2azlkM3ZZYWN2eTQxSWlsSnA5bnJuSlBpejZT?=
 =?utf-8?B?MVhTYVMvcEJWUWV5Sk1vVGZsdlF1MU9DOHNwY3R3ZFI2VlV5ZU9mL2Q3c3NQ?=
 =?utf-8?B?ejYxV1ZZNUxlQkE1dW9CV3dEUWFCelBkM2k2ZHQvMEhIaXpPdlVHQ043SVpC?=
 =?utf-8?B?MmR4YWEwYjJlOW8xaW1TUC9QSUlKN2tsYThVVTAxV3V4SEVoM3F6NDBDYVQ0?=
 =?utf-8?B?N2V4VlZLcjFmZUU3QW9zQzMxSlhYdXJ0bXJCTlp4cnAxRDk2QkIyU3dIYWlz?=
 =?utf-8?B?ZS9qYldXY0VGWU1rNmFLcTEwRlVpai9UeG1aQ1hqKzBQQ2llaFM0QW54eXl3?=
 =?utf-8?B?czZOckp0WHpralRkR1FqMnE5WUw1MFlXTk5kdXRwTjk1Wm1yQWVRVk9yaWl2?=
 =?utf-8?B?TlAvekc5UnNvcnp0K0graW5WOGk0VzdrQjVjSWdKejRGQ2NiMG5QSHpsNkp2?=
 =?utf-8?B?M0pGMGdROVhOaVloZnorN25kWWdzSHcydllOR0dhQi9zTUJGWmZuc3Y1dUxB?=
 =?utf-8?B?alNxR0tBeGg2ZEJYcHoxYUFrNjk1UzFTT0ZtblNKZFR5UHFVRGV1dk5TeC9v?=
 =?utf-8?B?aTRUS3BoLzdhejZ0cXpDNHlQdkx2VjlHYm5pRXdGc3NUSlRWdjFQUTFoT0xF?=
 =?utf-8?B?L29rTGhYcisrM3VQNGg1UzFqOU9XWnRtSFBxNjdCV0tJbkhPc3dLWjRDV2hI?=
 =?utf-8?B?TVovcjQ2OFFMMnBtZVBkejdwakRXb3VZNU1jSk5mQmhrS3RIb0Ntc3lnYTI0?=
 =?utf-8?B?dEJ5V0trek4zQjNOQ2RwNHh4VS9kZjloVG9TSE5vZTJDZ0VzeWJyN2xmSG9E?=
 =?utf-8?B?WmViNE5Wd3JwYVNGR3ZzVUJGSTYzUUZmcFRncUIxRTBHdS9XRXdMYWI5UDBx?=
 =?utf-8?B?bjY5R0tiQVM1bUhmODVJWkpIYUJybHRVNFV4NE8rT2hRRVFtMGdGMGNLTXA5?=
 =?utf-8?B?ZlZMR29YaXNNYWgzMjk0SXdqVUIxL2hUcDEzK1pjbjNiOExpdEZER3RORjYy?=
 =?utf-8?B?RUpISFBqS21ISzFldG1KbmVIaEpVVGhmN2k4TWFYWXNQL2hmZTBxb2g1dXln?=
 =?utf-8?Q?5egGSzc5imRdbJzw=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf9bfdbf-fb08-4c6d-890a-08da237ccff7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 09:53:39.9775
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vw6l253GQPZ3GR6rsycqKDjIs+XQTzvORNRRVV3ZM2QuGBjxj+ntFbosCvg3tXmHQYsQovl1W+TgzGFR5ACJXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6102

On Wed, Apr 20, 2022 at 06:28:33PM -0400, Daniel P. Smith wrote:
> There are now instances where internal hypervisor logic needs to make resource
> allocation calls that are protectd by XSM checks. The internal hypervisor logic
> is represented a number of system domains which by designed are represented by
> non-privileged struct domain instances. To enable these logic blocks to
> function correctly but in a controlled manner, this commit changes the idle
> domain to be created as a privileged domain under the default policy, which is
> inherited by the SILO policy, and demoted before transitioning to running. A
> new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
> type to demote the idle domain appropriately for that policy type.
> 
> For flask a stub is added to ensure that flask policy system will function
> correctly with this patch until flask is extended with support for starting the
> idle domain privileged and properly demoting it on the call to
> xsm_transtion_running.
> 
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> ---
>  xen/arch/arm/setup.c    |  6 ++++++
>  xen/arch/x86/setup.c    |  6 ++++++
>  xen/common/sched/core.c |  7 ++++++-
>  xen/include/xsm/dummy.h | 12 ++++++++++++
>  xen/include/xsm/xsm.h   |  6 ++++++
>  xen/xsm/dummy.c         |  1 +
>  xen/xsm/flask/hooks.c   | 15 +++++++++++++++
>  7 files changed, 52 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index d5d0792ed4..763835aeb5 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -1048,6 +1048,12 @@ void __init start_xen(unsigned long boot_phys_offset,
>      /* Hide UART from DOM0 if we're using it */
>      serial_endboot();
>  
> +    xsm_transition_running();

Could we put depriv or dipriviledge somewhere here? 'transition' seem to
ambiguous IMO (but I'm not a native speaker).

xsm_{depriv,demote}_current();

> +
> +    /* Ensure idle domain was not left privileged */
> +    if ( current->domain->is_privileged )
> +        panic("idle domain did not properly transition from setup privilege\n");
> +
>      system_state = SYS_STATE_active;
>  
>      for_each_domain( d )
> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
> index 6f20e17892..72695dcb07 100644
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -621,6 +621,12 @@ static void noreturn init_done(void)
>      void *va;
>      unsigned long start, end;
>  
> +    xsm_transition_running();
> +
> +    /* Ensure idle domain was not left privileged */
> +    if ( current->domain->is_privileged )
> +        panic("idle domain did not properly transition from setup privilege\n");
> +
>      system_state = SYS_STATE_active;
>  
>      domain_unpause_by_systemcontroller(dom0);
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index 19ab678181..22a619e260 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
>          sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
>      }
>  
> -    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
> +    /*
> +     * idle dom is created privileged to ensure unrestricted access during
> +     * setup and will be demoted by xsm_transition_running when setup is
> +     * complete
> +     */
> +    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
>      BUG_ON(IS_ERR(idle_domain));
>      BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
>      idle_domain->vcpu = idle_vcpu;
> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
> index 58afc1d589..b33f0ec672 100644
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -101,6 +101,18 @@ static always_inline int xsm_default_action(
>      }
>  }
>  
> +static XSM_INLINE void cf_check xsm_transition_running(void)
> +{
> +    struct domain *d = current->domain;
> +
> +    if ( d->domain_id != DOMID_IDLE )
> +        panic("xsm_transition_running should only be called by idle domain\n");

Could you also add a check that d->is_privileged == true?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 10:01:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 10:01:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.309997.526563 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTcO-0002Oq-Py; Thu, 21 Apr 2022 10:00:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 309997.526563; Thu, 21 Apr 2022 10:00:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhTcO-0002OJ-N3; Thu, 21 Apr 2022 10:00:56 +0000
Received: by outflank-mailman (input) for mailman id 309997;
 Thu, 21 Apr 2022 10:00:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhTcN-0002O8-Uc; Thu, 21 Apr 2022 10:00:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhTcN-0005Ue-RH; Thu, 21 Apr 2022 10:00:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhTcN-0006h8-B7; Thu, 21 Apr 2022 10:00:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhTcN-0000Hs-Ah; Thu, 21 Apr 2022 10:00:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aBtEtcM4MvIeU4qEa2B3mEZQPC8Bnh1VT68/aZ55k28=; b=2itoHaPCO0lhZ8t3cTZNQxxCNp
	GU4/FDffEa23vcP72PujkQUA11cuAevA2oCbOVKjut/+7Z7+gdqfJwafKpnA4MEQQMolq47awcFqY
	RDinCqrcKimfYNT6EeKv+Ao2ib7D9NtuCROwPXXkJmCPWCTKxwJOTbiFEH/Rx9wwsMv0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169588-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169588: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 10:00:55 +0000

flight 169588 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169588/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   51 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  534 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 10:13:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 10:13:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310005.526574 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhToM-0004Op-W4; Thu, 21 Apr 2022 10:13:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310005.526574; Thu, 21 Apr 2022 10:13:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhToM-0004Oi-T2; Thu, 21 Apr 2022 10:13:18 +0000
Received: by outflank-mailman (input) for mailman id 310005;
 Thu, 21 Apr 2022 10:13:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Sn/J=U7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhToL-0004Oc-Bl
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 10:13:17 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5fb6b51f-c15b-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 12:11:13 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6D3EB21100;
 Thu, 21 Apr 2022 10:13:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27E5213A84;
 Thu, 21 Apr 2022 10:13:15 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id RQFzCDsuYWLIWAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 21 Apr 2022 10:13:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fb6b51f-c15b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650535995; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iTHgU/VhRSYINu0e4T89zlNvUmi6qAAkVLRmZM6LFy4=;
	b=fLK/bCzL6N4pKlVEnPBdiSOKnJDrosHyJRKfKSYy195AcKfYXo2NJDqpHvpPp1Aj+MSoWX
	IKrioCdTwXCuw890w9BKEX41jL5vl5VCkwfmT5dvDMOYZ8qFiuOyboS0ru5qthKOgDFmHh
	rA2lhyttvLU5TD+14XfN365K3zA1QJ0=
Message-ID: <9d8c453b-7147-d80c-3d4f-666a3b530929@suse.com>
Date: Thu, 21 Apr 2022 12:13:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 4/4] xen/scsifront: harden driver against malicious
 backend
Content-Language: en-US
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>,
 "Martin K. Petersen" <martin.petersen@oracle.com>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-5-jgross@suse.com>
 <00c1cd38-5164-edfa-6c47-606803629dcf@oracle.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <00c1cd38-5164-edfa-6c47-606803629dcf@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------bOVcQ0bMgi1fIjeAQlOPmOe5"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------bOVcQ0bMgi1fIjeAQlOPmOe5
Content-Type: multipart/mixed; boundary="------------H0kwBUjQOfwijdKXCQgtrTrx";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>,
 "Martin K. Petersen" <martin.petersen@oracle.com>
Message-ID: <9d8c453b-7147-d80c-3d4f-666a3b530929@suse.com>
Subject: Re: [PATCH 4/4] xen/scsifront: harden driver against malicious
 backend
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-5-jgross@suse.com>
 <00c1cd38-5164-edfa-6c47-606803629dcf@oracle.com>
In-Reply-To: <00c1cd38-5164-edfa-6c47-606803629dcf@oracle.com>

--------------H0kwBUjQOfwijdKXCQgtrTrx
Content-Type: multipart/mixed; boundary="------------Cd0FSXteRQcyaOcd2VGwU4Qp"

--------------Cd0FSXteRQcyaOcd2VGwU4Qp
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDQuMjIgMTg6MTMsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gSnVzdCBhIGNv
dXBsZSBvZiBuaXRzLg0KPiANCj4gDQo+IE9uIDQvMjAvMjIgNToyNSBBTSwgSnVlcmdlbiBH
cm9zcyB3cm90ZToNCj4+IC1zdGF0aWMgaW50IHNjc2lmcm9udF9yaW5nX2RyYWluKHN0cnVj
dCB2c2NzaWZybnRfaW5mbyAqaW5mbykNCj4+ICtzdGF0aWMgaW50IHNjc2lmcm9udF9yaW5n
X2RyYWluKHN0cnVjdCB2c2NzaWZybnRfaW5mbyAqaW5mbywNCj4+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50ICplb2lmbGFnKQ0KPj4gwqAgew0KPj4g
LcKgwqDCoCBzdHJ1Y3QgdnNjc2lpZl9yZXNwb25zZSAqcmluZ19yc3A7DQo+PiArwqDCoMKg
IHN0cnVjdCB2c2NzaWlmX3Jlc3BvbnNlIHJpbmdfcnNwOw0KPj4gwqDCoMKgwqDCoCBSSU5H
X0lEWCBpLCBycDsNCj4+IMKgwqDCoMKgwqAgaW50IG1vcmVfdG9fZG8gPSAwOw0KPj4gLcKg
wqDCoCBycCA9IGluZm8tPnJpbmcuc3JpbmctPnJzcF9wcm9kOw0KPj4gLcKgwqDCoCBybWIo
KTvCoMKgwqAgLyogb3JkZXJpbmcgcmVxdWlyZWQgcmVzcGVjdGl2ZSB0byBkb20wICovDQo+
PiArwqDCoMKgIHJwID0gUkVBRF9PTkNFKGluZm8tPnJpbmcuc3JpbmctPnJzcF9wcm9kKTsN
Cj4+ICvCoMKgwqAgdmlydF9ybWIoKTvCoMKgwqAgLyogb3JkZXJpbmcgcmVxdWlyZWQgcmVz
cGVjdGl2ZSB0byBiYWNrZW5kICovDQo+PiArwqDCoMKgIGlmIChSSU5HX1JFU1BPTlNFX1BS
T0RfT1ZFUkZMT1coJmluZm8tPnJpbmcsIHJwKSkgew0KPj4gK8KgwqDCoMKgwqDCoMKgIHNj
c2lmcm9udF9zZXRfZXJyb3IoaW5mbywgImlsbGVnYWwgbnVtYmVyIG9mIHJlc3BvbnNlcyIp
Ow0KPiANCj4gDQo+IEluIG5ldCBhbmQgYmxvY2sgZHJpdmVycyB3ZSByZXBvcnQgbnVtYmVy
IG9mIHN1Y2ggcmVzcG9uc2VzLiAoQnV0IG5vdCBpbiB1c2IpDQpJJ20gbm90IHN1cmUgdGhl
IHNwZWNpZmljIHZhbHVlIGlzIG9mIGFueSBpbnRlcmVzdC4NCg0KPj4gK8KgwqDCoMKgwqDC
oMKgIHJldHVybiAwOw0KPj4gK8KgwqDCoCB9DQo+PiDCoMKgwqDCoMKgIGZvciAoaSA9IGlu
Zm8tPnJpbmcucnNwX2NvbnM7IGkgIT0gcnA7IGkrKykgew0KPj4gLcKgwqDCoMKgwqDCoMKg
IHJpbmdfcnNwID0gUklOR19HRVRfUkVTUE9OU0UoJmluZm8tPnJpbmcsIGkpOw0KPj4gLcKg
wqDCoMKgwqDCoMKgIHNjc2lmcm9udF9kb19yZXNwb25zZShpbmZvLCByaW5nX3JzcCk7DQo+
PiArwqDCoMKgwqDCoMKgwqAgUklOR19DT1BZX1JFU1BPTlNFKCZpbmZvLT5yaW5nLCBpLCAm
cmluZ19yc3ApOw0KPj4gK8KgwqDCoMKgwqDCoMKgIHNjc2lmcm9udF9kb19yZXNwb25zZShp
bmZvLCAmcmluZ19yc3ApOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGlmIChpbmZvLT5ob3N0X2Fj
dGl2ZSA9PSBTVEFURV9FUlJPUikNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVy
biAwOw0KPj4gK8KgwqDCoMKgwqDCoMKgICplb2lmbGFnID0gMDsNCj4gDQo+IA0KPiAqZW9p
ZmxhZ3MgJj0gflhFTl9FT0lfRkxBR19TUFVSSU9VUzsgPw0KDQpZZXMsIHByb2JhYmx5IGJl
dHRlci4NCg0KPiBXZSBhbHNvIHVzZSBlb2lfZmxhZ3MgbmFtZSBpbiBvdGhlciBpbnN0YW5j
ZXMgaW4gdGhpcyBmaWxlLg0KDQpJJ2xsIHVuaWZ5IHRoZSBuYW1lLg0KDQoNCkp1ZXJnZW4N
Cg==
--------------Cd0FSXteRQcyaOcd2VGwU4Qp
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Cd0FSXteRQcyaOcd2VGwU4Qp--

--------------H0kwBUjQOfwijdKXCQgtrTrx--

--------------bOVcQ0bMgi1fIjeAQlOPmOe5
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJhLjoFAwAAAAAACgkQsN6d1ii/Ey+y
twf+JqOrjEDh+gBA4bWZhNG3Gy1PCHVM7nXXibEBKsiBNfvIQPUa18GPWuDYfrdKijjNSi2SB+f6
Sxhp3iIwWkptvZhVBH+95OMfoOz8fyHOsATnRfDMV8h/JYvxHF4Kr87RtRCb/okeg6Z4aTMJ71FC
WnU+CSsxtQciPtct18b+h0o1YVj95rjevV2KWMv3afQx6DhtNU4V1FCEMPK36GIZYQ/43t1qtk1/
0pXEIWjT+WZG4R3nVATsoUYwbc5wpi08F0n6H+vtYwdW6hFQy+08w3/XyEEZXVRBeiZV+Ggyoljk
6QiLZIhdCIbUMhXjnpsF6XFRCZYO17zMveBlKKjuog==
=8nvY
-----END PGP SIGNATURE-----

--------------bOVcQ0bMgi1fIjeAQlOPmOe5--


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 10:40:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 10:40:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310013.526586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUEN-00089w-Cz; Thu, 21 Apr 2022 10:40:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310013.526586; Thu, 21 Apr 2022 10:40:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUEN-00089p-8j; Thu, 21 Apr 2022 10:40:11 +0000
Received: by outflank-mailman (input) for mailman id 310013;
 Thu, 21 Apr 2022 10:40:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhUEM-00089j-9U
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 10:40:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a4c62e2-c15f-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 12:40:09 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-ESgn8edSMpiQh-sI6cFV9A-1; Thu, 21 Apr 2022 12:40:06 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8789.eurprd04.prod.outlook.com (2603:10a6:10:2e0::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 10:40:04 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 10:40:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a4c62e2-c15f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650537609;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=ZPRI9TBpt7NqvcTDTjDO9kvTzuTJer701WOTHuYIYd4=;
	b=CL2YUmew2hko9etCuBtuDNmBrjlUX+/WZ/+8w4OkTuKNbLnsoPOtifepxvG4KeQO0Ub5rc
	5YXUeMLjIINRXJA0NFxPNaXm3SzPxf1QW9Lb2Y5acvNyTB941By1nVXUUmXrpuVgW0dEes
	HphcZdAcLAtoy7gipPUI7RiIUAR7CFw=
X-MC-Unique: ESgn8edSMpiQh-sI6cFV9A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fxqgaOJVIqKd7gvt/mc2X9GbxGYWnp+4pv2nOeh/fgqJqFlENhdQ2QTr6UqQXE88cVmiqZBNFVNM25qVc2raA2nrYVEX976TTGyhP8ZIHWNx7AOcN1VxVPxxb1XqEHrI5uOZws5QY3NIhKl1qRrydPpo4LjzzPDhAunAIwM/kVJTDn2/EDm/D+rEB4EiWfT5U++iEi7eE9go/7WgvN633dnP0s3kJ/5icgM93N0f0Q2O2P7NsAL4mbHwk0Ioahe/Z+Ig4Bh4iPi58PgzfIY0umI1MZFvrEqaSLeGjaUXJFbkYQhFaUvabYmvqT1atUI+9nvUvzY0mWx0huIPUZaBWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZPRI9TBpt7NqvcTDTjDO9kvTzuTJer701WOTHuYIYd4=;
 b=TRSbRNAKEexT0U3RHsj4llRA0vpDM79rMERKmqQB2l7G2Gdw7Vpa9Zx+fzr+fw+cFtxYZwcTvF9/mJRKQ78CiU3jeV7iYkLqLDtkYJko2jQ1SSDaGmapApMyY68VUYt+04V3Ozo/A2vqBct/6E8iaP831xjMoIoKdrctl5a3pQVPg/7i1jBMZU6MQXcdKqqG9Xe7EZEX/fb3A9hpb7kI8Z2jrAwVBctEFh84wSWCFRIpr9qQdNO2VAhpHlLHTYSViFMeHuPcqN+8oM4V1j8Wuikjil2dBCz26xE/N4H5eBOtX3gfOp+1cU9n/a+GXR2l1N/4T2s2YHu2y4JcEoh6uA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <971a1a9a-ab4a-38cd-2c20-534846b440f6@suse.com>
Date: Thu, 21 Apr 2022 12:40:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/build: make linking work again with ld incapable of
 generating build ID
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0121.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ed2ee7c5-be7f-4eb1-7bf0-08da23834bd8
X-MS-TrafficTypeDiagnostic: DU2PR04MB8789:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB878905FD533844A216E255F9B3F49@DU2PR04MB8789.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FLES9CT8AK7JAOHnSrVdHebjlAMoqE34wyXVvCQgDd7dzgUNSatmUL8cbhr6at6okBOxLE2vBTkOCRBgcMLgbSU7zERBi16Zq3Or65vAvmsJLZVS+0BHuLknjcQvZfBb/Y3HIDR8mqi33vpfnVmklJNO/gqXzJZWxn17rsYgfasAT6yneIaXG90qjSC65w7N5PU9y/qAOyXF6Tln8M4VVwOFRcN1j+lbr+WZEEHlwGRtdSyMU3fMENf1jb7+vXMJM7M9eXmGcglOe4Uhyuu41Bm/M63BCL2UAzzKyI4REOlEhA7osiPoEINZHI1SSjN1AiOx/deA6GNyU7SMm6AYMrkP//DS4ME6GbFat9CrQC/PRFHpTnoQpZpwl8OREz36k66Fcl1xTmsWzOw59DJPKgiv2DlsFMl+DA9sjSYm0UkjZOuy9H9QaBthpri+PBefQLAclSkL8yK6aporAxWuMCB18urrXCrZeU3poIAQtFt0TLBgyV7dp37jerwQmof3ETSvE1aNDYAWUlc3N+iRbhoks/WQdJE2FQ9sc8hIPhWqQznwrQXNSPMvyXnzabqNTAJYXJFlqLD7/ZivZDRRwcJ5Rhbhmnt2z8I2d7CQOd7E/zQbZ7ag2AYqBVrTH27dthddHIJjPGFixTLYrcPthye6O4MGx/HA+MLZtwP8Wyp79AjDcjjLqBDHdO27Y/DQD3tFilcxgurSxWEMdRDLclsuU9OWTAmBr3ywlEjdUhhJbxxY/YTHXCln3h+2L3au
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(4326008)(508600001)(31686004)(38100700002)(8676002)(66946007)(5660300002)(186003)(26005)(2616005)(36756003)(316002)(8936002)(66476007)(6486002)(2906002)(31696002)(86362001)(66556008)(6916009)(6512007)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dEdCTEJxT0o2STRzQzFUU2lzY2d5cGFtVVp0ZVdidWhTcUZZUHpHN0hLKzFt?=
 =?utf-8?B?TmxBYk51K3FiQ3VzMUl4cHUwa2M3OG1xNVJmTmZSRFdEU1lmQmNtNXE2MXpS?=
 =?utf-8?B?ZnBMS3BmK1c4aTlPZlhyOW9FRmhtNlJmZzJTRDdWNy9xZWZkaW5KUFBQTnda?=
 =?utf-8?B?ejNqZm83N0Vya09MU0NVNkw0RXlablFKbDJwMXEvNkVkNDBnb0NMOWwrcWQ1?=
 =?utf-8?B?eFVvOUt5aGNHL0FBb2RuNDQrMGlJZCtwMnczZEVWSzVXZ2MwVHNTVjR5b3Zq?=
 =?utf-8?B?c0tialFYOC9jWjhjdkxjeExmTlR5a3JTSkc2RnFsckZ2WFdWdWJXNmVYYmty?=
 =?utf-8?B?eGJWWWd0czBwdU9TaWFBd1JNSFlCS3ZxekNNU1NiYVpGSUNuRmJiczlqWlAr?=
 =?utf-8?B?MG1Kb1d5bXh3NGFMQW85Wk9taklvenQvS1lDaFBrQlpHNmpUbnRwZWhXS3Br?=
 =?utf-8?B?dFdXZi9wSFNxWjN3bUpGRVQyc1M5WGdMUnMzelZmWUV4MzhVaTJDcGV4L3BY?=
 =?utf-8?B?SEp3angxYjJMZWtqdytxaWVQdlllNXhNTVE5OE9vVDBMRmd3R1IvR0xCTHI2?=
 =?utf-8?B?SHVWNHVmM0xhc2xGc1kwYVNjVy9KVU9KWk1hVDdRUEF0SG5seEtobkVXeHBV?=
 =?utf-8?B?dDVvd0s1aUs0NFJCRU1URUZwMERxMU5pK3Z0bVlZVHVJeU9JaGtQTGhFWlpl?=
 =?utf-8?B?Vkdpejd0RmN1NzNzZGFGU0JGR1BGbjVxV3hjU1RtMDlCYTBKNW5xeW9wdDV4?=
 =?utf-8?B?YWppMlJiRFZCdFl3VW13TFBkcUZtbFM2TENzU0thMkdGMjBjUi9Ld0F6NG01?=
 =?utf-8?B?ZnJIQWNnZE1vKzhaTEloODdOK0w2U1Y5aGtvSWU4d1NSTUtSTC9rQ2dVTlNp?=
 =?utf-8?B?OXhCRlhDK21lOERGZnFvZmhBVnVtUm5zOHZqYlVtaS9vaEc4bEZyY01qQm5S?=
 =?utf-8?B?S3NNcU9LLzRTVlpsUTBtZi9uVUczWWxUKzJ2bW1YaDJQRDBQRXYybW9FRXhU?=
 =?utf-8?B?eGxvajVQWk1KYmZ3VjdnQkhGMDVNVDdNZVhnc3BsRzZtYklxckdCUWEwdnhh?=
 =?utf-8?B?eGM0U2JtdDR6YXFkSzFPcWFqTU9laUxwcS9tN3JKT1lrSzR3NHV1UXc2eSts?=
 =?utf-8?B?YlNNc2puS000TisydXc3YkZLM2IzRUpZMjVVK1JGY0UwVldXTUE5UEFFNVJV?=
 =?utf-8?B?Rkg0a2djKzNGekFRWng3a0JSZXFzSlQ3RzRDN1NxUXEvclVIaEd2YzhTVW1D?=
 =?utf-8?B?dFF4d3loLzRIQndkcDdjME90UjRjTytDOWFLN2xZYkx2Wk1wb0Z4Zk95SmUx?=
 =?utf-8?B?U3h0dkpQRGxmQVhUZ1RpK3o5aHZHbUxTbHhIRU4vMTFJR05TTlJma2YyT05y?=
 =?utf-8?B?b1NPLzVFbkt3bFBUL0FwaGdNRHJrTDQ3R1VoSDVLb3QxRXdwbDQ0b0FSd1Iv?=
 =?utf-8?B?SEUrNDFDUUU4Ri83cXRnMHU2Q1hXd3hmSS9hZWhrQTF1eXlDQUdaWi9QUDM5?=
 =?utf-8?B?MVFwa05DaU1WdDVoOTdKZzUrMDFWeVFmVWFFOHR0UVVvNE05MGp0RGVmcmVO?=
 =?utf-8?B?ZEVVQ1Nab1g0c3h5d3I1NUY3K1gzbHpDM3FsSTYrVkplVVpGeXFFd1pDZDBi?=
 =?utf-8?B?M3BCNzVML1VnTDZKSklhTmVpb1NUclJDRklpc05ic0JoWDZvTXFhUmVEc29W?=
 =?utf-8?B?b2ZDZThyWElSVGlocENjalkzVmZUU0lEdEgyczdQOXRIaEt3a3NhaHgyOWNG?=
 =?utf-8?B?emVvaDBIRjJqWmJJc3JSbkFJWGd4eVFabHdZNm00SzJCVndOYk1pZ3hKZWxY?=
 =?utf-8?B?WDdXY3g2aG5wYjZmVVNNY3RWaDhGWmpaV1VGV3RFSjdXa0pFL0h1SndFV1Uy?=
 =?utf-8?B?MCtBdVdGblhWMmEvYm5RYW5IcmxGbjBGaVgvT2RLWnFyR21MOGFOd0paUFpt?=
 =?utf-8?B?cVVaWVA0d0RvSTlMSmNWOHhmZVdEZldaRTlpbW9tb1FLMG9nVE1IMDhRUndG?=
 =?utf-8?B?QzlWblpBZFZHMktTNFNjUGJxcmFVZmZrTDVIblBoM2NKRFVYZ280K3VBb2V3?=
 =?utf-8?B?MklqZDVYZm5HL3V1Vk9RZ08wSFRwb3RXYnl1bS9LWHNJVU5NZDVyc2tWdG44?=
 =?utf-8?B?MDJNWElQUzNWdTZWSWtXQ0JXYVBRMk1oUXZwL3BMRW0xVW1ubXFUeU1lZW91?=
 =?utf-8?B?OEw5TVdDaU5UNytDU1krRllFQ0FUSGZNK3dVVGI0Z3Q4Y0swSnk2VU1acTlC?=
 =?utf-8?B?WkMwS3pRV2pUUGIxbTB6QUdtM1BJODFRRHNSV1R5Ynp4WEhSU2FpSHdrWWJp?=
 =?utf-8?B?ZXZ3NnZUMCtFK2RBQ3RlaTlwUDRTK29Vd0xHQU5WRWxhWlZrc0pJUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed2ee7c5-be7f-4eb1-7bf0-08da23834bd8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 10:40:04.8544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x5HliHGpybZi9K/rViXoIqQSJ5L/Ud/XqFhN+pqMb4cXgprJCuBomJXbfhEWF8aOSF0tGhGMybT5nSSA+DFfMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8789

The retaining of .note.* in a PT_NOTE segment requires a matching
program header to be present in the first place. Drop the respective
conditional and adjust mkelf32 to deal with (ignore) the potentially
present but empty extra segment (but have the new code be generic by
dropping any excess trailing entirely empty segments).

Fixes: dedb0aa42c6d ("x86/build: use --orphan-handling linker option if available")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/boot/mkelf32.c
+++ b/xen/arch/x86/boot/mkelf32.c
@@ -320,6 +320,19 @@ int main(int argc, char **argv)
                 (int)in64_ehdr.e_phentsize, (int)sizeof(in64_phdr));
         return 1;
     }
+
+    /* Ignore entirely empty trailing program headers. */
+    while ( in64_ehdr.e_phnum > num_phdrs )
+    {
+        (void)lseek(infd,
+                    in64_ehdr.e_phoff + in64_ehdr.e_phnum * sizeof(in64_phdr),
+                    SEEK_SET);
+        do_read(infd, &in64_phdr, sizeof(in64_phdr));
+        endianadjust_phdr64(&in64_phdr);
+        if ( in64_phdr.p_memsz )
+            break;
+        --in64_ehdr.e_phnum;
+    }
     if ( in64_ehdr.e_phnum != num_phdrs )
     {
         fprintf(stderr, "Expect precisly %d program header; found %d.\n",
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -40,9 +40,7 @@ OUTPUT_ARCH(i386:x86-64)
 PHDRS
 {
   text PT_LOAD ;
-#if defined(BUILD_ID) || defined(CONFIG_PVH_GUEST)
   note PT_NOTE ;
-#endif
 }
 #define PHDR(x) :x
 #else



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 10:43:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 10:43:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310018.526597 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUHl-0000cz-SZ; Thu, 21 Apr 2022 10:43:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310018.526597; Thu, 21 Apr 2022 10:43:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUHl-0000cs-PP; Thu, 21 Apr 2022 10:43:41 +0000
Received: by outflank-mailman (input) for mailman id 310018;
 Thu, 21 Apr 2022 10:43:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5++L=U7=gmail.com=d.vrabel.98@srs-se1.protection.inumbo.net>)
 id 1nhUHk-0000cm-O8
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 10:43:40 +0000
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com
 [2a00:1450:4864:20::435])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7b82409-c15f-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 12:43:39 +0200 (CEST)
Received: by mail-wr1-x435.google.com with SMTP id b19so6045312wrh.11
 for <xen-devel@lists.xenproject.org>; Thu, 21 Apr 2022 03:43:39 -0700 (PDT)
Received: from banana.davidvrabel.org.uk (banana.davidvrabel.org.uk.
 [82.70.146.42]) by smtp.googlemail.com with ESMTPSA id
 r3-20020a1c2b03000000b00392a3e6280bsm1790450wmr.8.2022.04.21.03.43.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Apr 2022 03:43:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: e7b82409-c15f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=sender:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=wMoTPeB7BTLpWOQfhuwiocjrzUK1wUCWzqs0ZSxBB7E=;
        b=Y3bn8wqcPwYxKKdf4DG25sqqv7W6UVZIiFzt5hVnYhTBvsbvE0kbVmkYEQH2rmdVgJ
         uBdik4pOaEo+lYU/2ev+OOh640tLaOSu62BcHJsx7wRp1PYgiN9T1STRIiKmEktOx5qD
         u2v6+XbYuDruSCSPlyrqR28tUZy1Y70aJf4Gilll/5j/NKrUNjlok4FyYm2IItoAlJVY
         y2lzjtoRE0ZWO4KaTHIdGNMFlaiEWge8F7HvZg75pid7yo+68bakUl7O/JM5ou1AnD5M
         nbTBfvDPzPzIqEUmtm9RbmVaB4iYNADocy6gtlHEgrByCD77SgwSR2X3vkYoUrUhkBOs
         Lf+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
         :mime-version:content-transfer-encoding;
        bh=wMoTPeB7BTLpWOQfhuwiocjrzUK1wUCWzqs0ZSxBB7E=;
        b=iBDzb5zH2ZAsLTfs2wCpd+czbR1hCbJGAh8DYgpDVoNIjD+pSI+v0kxYyAet14Xpn9
         rfqLiVuwcAgkrW5q47aTdA3PnVZtKhUE62X760OX5SYgz2dRXYxkWQs3vVRtweJ2q5sH
         rB6jVDYB/eqMDllmEaroD1Uxk6HW2uZ79qudTxaFXxPybHVAGPR75r++hM2WFZY3lxDl
         eu3qIGCg0X5z64ljLBdxtYgP6gf/Xuz4N90asC0qizJFBfrtGryP6cxkNw8t4dweoN/8
         1QbiZGseRmX30qIdfaxpxoSZTA06FflkrWejWpJm40Q3Buv5amLhQaV1gRivoLVB8pDh
         B3cw==
X-Gm-Message-State: AOAM531dsK/u+riWAFW9HXWAww7Hq4LRWqmFnZhLihfbFlup27u4ebM6
	znoHK0r4jGkj/oeDNBZpGv7KgajwtPEYeA==
X-Google-Smtp-Source: ABdhPJzglbNJLubVHZR+/nGmnbV/4mNnNj9ygNPA++nq5bkeqHoeq24mWFgc21kiLFTFfrejjWVxYg==
X-Received: by 2002:a5d:48cc:0:b0:206:d17:10aa with SMTP id p12-20020a5d48cc000000b002060d1710aamr19188725wrs.460.1650537819156;
        Thu, 21 Apr 2022 03:43:39 -0700 (PDT)
Sender: David Vrabel <d.vrabel.98@gmail.com>
From: David Vrabel <dvrabel@cantab.net>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	David Vrabel <dvrabel@amazon.co.uk>
Subject: [PATCH v2] page_alloc: assert IRQs are enabled in heap alloc/free
Date: Thu, 21 Apr 2022 11:43:05 +0100
Message-Id: <20220421104305.878204-1-dvrabel@cantab.net>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: David Vrabel <dvrabel@amazon.co.uk>

Heap pages can only be safely allocated and freed with interuupts
enabled as they may require a TLB flush which will send IPIs.

Normally spinlock debugging would catch calls from the incorrect
context, but not from stop_machine_run() action functions as these are
called with spin lock debugging disabled.

Enhance the assertions in alloc_xenheap_pages() and
alloc_domheap_pages() to check interrupts are enabled. For consistency
the same asserts are used when freeing heap pages.

As an exception, during early boot when only 1 PCPU is online,
allocations are permitted with interrupts disabled. This required
setting the SYS_STATE_smp_boot system state on arm, to match x86.

Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
---
Changes in v2:
- Set SYS_STATE_smp_boot on arm.
---
 xen/arch/arm/setup.c    |  2 ++
 xen/common/page_alloc.c | 24 ++++++++++++++++--------
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..44d45f1449 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -984,6 +984,8 @@ void __init start_xen(unsigned long boot_phys_offset,
 
     console_init_postirq();
 
+    system_state = SYS_STATE_smp_boot
+
     do_presmp_initcalls();
 
     for_each_present_cpu ( i )
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..e1ce38df13 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -162,6 +162,14 @@
 static char __initdata opt_badpage[100] = "";
 string_param("badpage", opt_badpage);
 
+/*
+ * Heap allocations may need TLB flushes which require IRQs to be
+ * enabled (except during early boot when only 1 PCPU is online).
+ */
+#define ASSERT_ALLOC_CONTEXT()                                          \
+    ASSERT(!in_irq() && (local_irq_is_enabled()                         \
+                         || system_state < SYS_STATE_smp_boot))
+
 /*
  * no-bootscrub -> Free pages are not zeroed during boot.
  */
@@ -2160,7 +2168,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 {
     struct page_info *pg;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     pg = alloc_heap_pages(MEMZONE_XEN, MEMZONE_XEN,
                           order, memflags | MEMF_no_scrub, NULL);
@@ -2173,7 +2181,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 
 void free_xenheap_pages(void *v, unsigned int order)
 {
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( v == NULL )
         return;
@@ -2202,7 +2210,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
     struct page_info *pg;
     unsigned int i;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( xenheap_bits && (memflags >> _MEMF_bits) > xenheap_bits )
         memflags &= ~MEMF_bits(~0U);
@@ -2224,7 +2232,7 @@ void free_xenheap_pages(void *v, unsigned int order)
     struct page_info *pg;
     unsigned int i;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( v == NULL )
         return;
@@ -2249,7 +2257,7 @@ void init_domheap_pages(paddr_t ps, paddr_t pe)
 {
     mfn_t smfn, emfn;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     smfn = maddr_to_mfn(round_pgup(ps));
     emfn = maddr_to_mfn(round_pgdown(pe));
@@ -2369,7 +2377,7 @@ struct page_info *alloc_domheap_pages(
     unsigned int bits = memflags >> _MEMF_bits, zone_hi = NR_ZONES - 1;
     unsigned int dma_zone;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
                                       bits ? : (BITS_PER_LONG+PAGE_SHIFT));
@@ -2419,7 +2427,7 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
     unsigned int i;
     bool drop_dom_ref;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( unlikely(is_xen_heap_page(pg)) )
     {
@@ -2738,7 +2746,7 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
 {
     struct page_info *pg;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     pg = acquire_staticmem_pages(smfn, nr_mfns, memflags);
     if ( !pg )
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 10:47:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 10:47:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310023.526608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUKq-0001Fv-D5; Thu, 21 Apr 2022 10:46:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310023.526608; Thu, 21 Apr 2022 10:46:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUKq-0001Fo-8M; Thu, 21 Apr 2022 10:46:52 +0000
Received: by outflank-mailman (input) for mailman id 310023;
 Thu, 21 Apr 2022 10:46:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhUKo-0001Fi-HO
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 10:46:50 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0d8efebd-c160-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 12:44:44 +0200 (CEST)
Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 06:46:44 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM6PR03MB4970.namprd03.prod.outlook.com (2603:10b6:5:1e3::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 10:46:41 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 10:46:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d8efebd-c160-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650538007;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=5RDebL21nm9Zfvjb2bOzHe0uNQB1+hoUytJwNm1mpGo=;
  b=S+TYsmEzc/xE49viIGkPU8QW2VvH8QfgFozrHOrAGNm8voElyxrs8a3z
   eIvymdy9TDhB0prynU4O5I8C5aYF1F6ps7dfOQQio52xItVTcdjmKlA7+
   SVmaVhhbAb0wTy2zGdSa4DZMYI8kbp//mRcYNXV/r5Ui9TQ2+sZ2lryXe
   0=;
X-IronPort-RemoteIP: 104.47.55.101
X-IronPort-MID: 68994097
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:yXSLQq5COE/2wTXIQwdEOAxRtEvGchMFZxGqfqrLsTDasY5as4F+v
 mdNCjvXPfiKYGKkeY0ibYS1pkoC7ZPVyNJnT1A6/ClkHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjWlvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSweB8KNYLXvdg6VjxIEjxuBbJa3J3+dC3XXcy7lyUqclPK6tA3VAQTAtdd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YAhV/chegXdRraT
 +MfZSBic1LrZBpXN01MIJk/gP2plj/0dDgwRFe9+/pmsjSLnVMZPL7FLdCPa+aqSvdvsVvH4
 Ufbpm/1LCpFHYnKodaC2jf27gPVpgv5Uo8PELyz9tZxnUaegGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yFabujYMVtwWFPc1gDxh0YLR6gedQ20bFDhIbYV+sNdsHGRzk
 FiUg9nuGDpj9qWPTm6Q/auVqjX0PjUJKWgFZmkPSg5tD8TfnbzfRynnFr5LeJNZRPWscd0s6
 1hmdBQDuog=
IronPort-HdrOrdr: A9a23:bZcHxKxXm0iz2yfQk0sDKrPxdegkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD
 AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2RYUh27D3xnklWavo3RiKmrwPAa
 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66
 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4
 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+
 qvOfttcoreEVc=
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="68994097"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ANSiPG4+pAXYWq4mIX1UIKtZCABUt7O8ZuASFZFBixQZhfCC2yPS4ouC1Ql1f2uAqDOkj3+u5FSewf+2HspG/kNd/G/Tiy9nizKT/edZpgdLMFlclZsqWu0D1Edg0Kiqw2czeD86E4nhK/u/p0jvIlN2+27jiN2yzIGiMkX+qok7FTXqIn/KO9A4uvh7w5sy9aziIBVAVO4kGarxKwX7zQlirj8WX8Fxmde9nyZhOhj10E/Q+SVIqKJWdFx/hHDVHQGTznFJ/fgnm1YeBhWxa9Mt214Re99WmUzHd9gg3yGIrFRSqjIvGdhG9kuqGMzK88UYdRGJ5wHw+Qgtlx2aOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5RDebL21nm9Zfvjb2bOzHe0uNQB1+hoUytJwNm1mpGo=;
 b=B+ywazXD3oDbyu9TqLnBUhQJta4yXFoDW6xbiwV2dMAJ3hL970cww4Ogn4jwlIaWbRJsNBrk5SFcN5jYwjf5diLnmx/++esLKdH+M6J8K1HaYV6pZx7+csiCfbmYBvjOkH2DWTZASw2CDrYXoez4zkZKo9O07lxFEfzUOhzRo0yUHsQFXuRvwHk4XC6W8ummkOCmFmrKIvoH3qThsB0cfiKcfHjx39eewf+KUh7Hf5DfsNOOiQnAoejXbCtL0ypvlPoyDrsiO2KTv0w1gMSaVce3pQ5f+pu1M36U7JVGDxzaqJ1sUQaNpirXQZjUjZrdsGKfMp+SENg2VS2tQ19BQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5RDebL21nm9Zfvjb2bOzHe0uNQB1+hoUytJwNm1mpGo=;
 b=l7KMNrFE6wMGLauxd6c1gSDzEq4AdctzDsY/VJdp8fuf9VDT/+KEu4wpBns/rc546vXGJ8iYjB3XhUpPZLMk+n/sNqum75nf3nIVlXaq7f1IK9n5mkfe080tBc3UNs3tjbyYTWryXFySt7LWT4ffXq971i04XaTxTfH2+g5bDWw=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/build: make linking work again with ld incapable of
 generating build ID
Thread-Topic: [PATCH] x86/build: make linking work again with ld incapable of
 generating build ID
Thread-Index: AQHYVWwugs+1XSUuI0uKWiHUrdPYw6z6L1EA
Date: Thu, 21 Apr 2022 10:46:41 +0000
Message-ID: <2f59bb2e-178b-942a-2b1d-5245fa77dcba@citrix.com>
References: <971a1a9a-ab4a-38cd-2c20-534846b440f6@suse.com>
In-Reply-To: <971a1a9a-ab4a-38cd-2c20-534846b440f6@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 567ed62c-0cca-49e6-5d22-08da2384383d
x-ms-traffictypediagnostic: DM6PR03MB4970:EE_
x-microsoft-antispam-prvs:
 <DM6PR03MB4970C9216D08BC4FCEBEA4FBBAF49@DM6PR03MB4970.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 9T0/khkV4crG5J2d7BSitL8eJm1fvt0rQ16qLMEHdXrGi9IKYO4y9zFp10LBlRHuSYL9VcbVui+QVZJOKoxvIo8ks2h4RVlbZjbW8o1EndZ/Nm9LZ1GBVz7Boz7DYLhuEsgzrWbFFsgtA/7n8c/nNhcu5H7NGU6AQGSXfgO+1f63/QERMuenQbBZkjceXReDVa7eLMz+4fBYwwchGl9MG54rX5pEC+LpPhqZoizkab7/R0XDs43kmYw6AeKjB9+8Z94S1BmyGxrEU6PShuBt0zW8E/vZALNAxNkKHC+u9k2/JJ3M7Np6ehDOTf57n67HAg+mIztHsysYHF5FT+X/wqy4ODdxvr9MasKaz1uNVty7Lqu9rbsmUKWsP4tmYDPH8QzmAsHUpIBY1f6KVK+pgSHGQGS9BBtuV10lBG1/ORgeMf91bEeuNPP9QFbbZopbWc3wf4AxPZXtFPSBIMu0eF9pIaO+zSWE35d3bbO4XWdh7/uLMmQJ1lPrzkmUdGK5n6cML9dQZ47IxA9g67OhZp0tyBpfmtZLxDWsGB0T/zVWvf1H+KxMpf50hDBEL8rVbxUMkOlah3lOuzAzWFOhDuDMPhgspCYn2wIoE1iKyUw+zIyQ6G2iWog5Xgr88iMC4E9XdohrAaAaIiyvcSxXTsS8mf1IXlifqbBdSbi5iPJXC5UxhUYCj/WUJwoNgom3LjmAt22P7L0TYnuZznaO91lLqGggowEFUgo4pS8VapQr+if6hgBstJxiyIw16OpIFvQSh5Z9z0eCtSfrkTDOhg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(4326008)(8676002)(186003)(5660300002)(54906003)(53546011)(26005)(71200400001)(6486002)(110136005)(64756008)(66946007)(66556008)(66476007)(66446008)(36756003)(31686004)(107886003)(76116006)(91956017)(2616005)(8936002)(86362001)(4744005)(122000001)(38100700002)(38070700005)(2906002)(6506007)(6512007)(316002)(31696002)(82960400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MWorc2RnRnhZZEQ3RnZCeUh5aEZhb252cDZjSEV5bmFmeXI3ZzdYL0p5SGgv?=
 =?utf-8?B?WGU5bUNLbDZiZll5MnJDbmpVa1cweEJvMnc3cnU4N2tuWnNYeVZ5S014Q0JD?=
 =?utf-8?B?YzBTR3lxdEJObjQyMG5kL2Q0ai9nWmNXVHVmSSt2MTM2cTVGTW9xeE1hOTZG?=
 =?utf-8?B?VDcyeG5td2RVTlI5YTcwQlhhcnRZbzUxd2F1UFBiMlp0dGhzSUY3aEVsSWJ5?=
 =?utf-8?B?RXhVU21LRUl1cDhkRGpBRkhISUJPRzhQMzR2UWNVdzFJQVpyTitMaEhNWXdQ?=
 =?utf-8?B?VzJlMDNSWnFyNm9LdjI0VEQ2TXhiUU5yREpJQWh3UGtPbmJaUHdkWU1PZUFw?=
 =?utf-8?B?VjlyNm1LZmptNkVlYkV3Tm5kMXpEbWJ5WnBseEM0OEFVQWczNmI2L01ybFVZ?=
 =?utf-8?B?QWJsbmRHQUhvcnk0ZzZsd0RLaDN3cGJtekR1Z1Z6czlSYnQ3LzNOM21WdUhl?=
 =?utf-8?B?bHViSU04aXBpY05HQzB1SjZMNEdHRWlabG15ZzljV2dIeXV4RFp5S2ZvRUx4?=
 =?utf-8?B?MHViSHhLU2FzcXpGNXBNTXFKSDdFMS94T3hyMHJmTmxSK2g3anlFWUVEUVpY?=
 =?utf-8?B?WkVzZVJoOXk1bkhvZjQ3Rk5aSnp6MTIzUTFHTDBrN1M2bHFxbmJCNTZqYUVP?=
 =?utf-8?B?NUtYbWVqamFxQW1BbGptemRod2xyYTMvVXUxM2hhVFRiR2RhWkRpSkNWYTBp?=
 =?utf-8?B?amN5c3VPQkllMjVlVFducGdTSWxyRGxLR0t0ZzFMTUtTZng4Z3R4RzFxYnFT?=
 =?utf-8?B?UnBieEQ2MGFXeVdJWGlBV2RZVzA4Ui9qQ1BjbWtPbHBiZTNCM21nUVFIbk9l?=
 =?utf-8?B?Z0ZRbUllN2lUdStqSmJYQkwrNWhZMEtuc09IUjhWRXgrc3VCSWdCTmY0QnRY?=
 =?utf-8?B?R2c0RU5CTDF2VHZJZCt0Um5FdVF1ekdUaE5QS0Zia3dXZ2orSGZzMDF6dlpu?=
 =?utf-8?B?MFFWV3F6am4wRVVPbE9HNDJwTzZHRjkyYlBBQXpqbndNNXoxNGtERUJLUWgx?=
 =?utf-8?B?Q0hldTZYTWZ1MUI5YlpTR2k3OWIxaE1ZVDdRbEg1WWZubTVia2ljUnJncGF3?=
 =?utf-8?B?NWxxZ0wvZEMyelBsaDdZY21yVW1id0NyR3UyTzQ2bHlzSVpxMGh1RWpzbTNr?=
 =?utf-8?B?bVpTWkM0MGhvWFhETE5EWThpa1laRm5nOTNxbHBlR3lRV3dpS1YwYWIyZHRQ?=
 =?utf-8?B?b2x1UnA3VjNGNHlvYm9sV0RjbmVDRUNqV3Q5Q0FSdlFMWEJMY2NYL3RCSjVV?=
 =?utf-8?B?MjZwN3RJUnduUEt0ZnhSaUJQTjlXa1BtTUhzWGsvR3JBUkpudDJjQWx0MSth?=
 =?utf-8?B?T0FjdzIzeFR2TlgwUkFXTXNqOXZOL29tR3RzZXo0QjJiTmY3T0Z2ejRPNisw?=
 =?utf-8?B?NWhKR1NXSkNEaDQzQU54aGVnbXlud2JvUVg4bHhQV2RJMW1YMGNDNEk4M0xG?=
 =?utf-8?B?cTVEbDNqQ1VoRUZ5dlEzb2taaTVwM29MTUM2RDU1ZVp2VU9MNW5tbldxUTY5?=
 =?utf-8?B?V3RiVWxYU2w3TWhobEJzT242dVBweThBQWI3ZEJCQTZ5TFh3Y3hVM0FuaHp1?=
 =?utf-8?B?N1gzT2kzT3V0V3dMRW5VVWZFVmlFQTJLc0VTS0ZXMjlWQXFyd0pnaUxtUHRS?=
 =?utf-8?B?VUFpMVdTbnlaY0ZBdGVMeHF4VU9wVCswaGphdDlmYVZ5ankyMUxJZndEUm16?=
 =?utf-8?B?ejBtbmdkYUtkL1JicklqMTZocnArZUlNTHpGNHNZZUhkd3cveGkwdVEvTkR2?=
 =?utf-8?B?dzVaRGF1cmxiTWp1RGxQeFhCbmJoWDJ5N0x2bUUxQ2FsU1dxS0hBNVpBd3Fh?=
 =?utf-8?B?alUwTUpvZXpJdU5tMTVadU1oNUp5TkxxLzlZR3FyR2VMZ2JoZHN3M21jcGQ3?=
 =?utf-8?B?ZVFHVCtMSkxtWVdwZUc4dEszcjVTOTUxaWJoVmZQRnQ4OE5tRC96YXZOenIr?=
 =?utf-8?B?U0txT2Z5OWY2cG5sNGZnVmR0NFhpVEM4YzdQejhYeFNQdm95SEJOTWlsY1pX?=
 =?utf-8?B?ZHFnMDhqaWk2SVJJc0lNc3RBcVBWRTJpTjN5VmxIbFEycmxqbTNmSzRsOW5w?=
 =?utf-8?B?TGNSaWtLQ3pUNVVaTnhhMVlZMzNueXNxakpGVG9wL1NoMHRjSmFsYUc0Z1NB?=
 =?utf-8?B?VE5pbFBnZFR4QnUrdGVpalY2YWc2blVUaHNVQUM1SlRLWEp5NWg1TUxTcmF5?=
 =?utf-8?B?QWtXUFhsMUdOcTUrZ2NLWDEwWUZ0T2twNUxBTVJnc2NMK3M2SHlPMS8vRE9K?=
 =?utf-8?B?SDFkbnR2dmV4TTdXcW5TeEJTV3dtbWl0Rk54TUd5djNqQU1Mb1dzUW9IbDFt?=
 =?utf-8?B?ck5FL0VScnUwY3o1aDY5T1JyM3V3Vzg5eFVjYTlBYXFIa2FFS2VQdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <156C00019D4DC844A4A8AADC4CE29769@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 567ed62c-0cca-49e6-5d22-08da2384383d
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 10:46:41.2391
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b8xBILzHzWvYf/vAxjz75m0ckT33fwPUDKXZBUJHQEPs1DWysVPo31yhuHC8CLLYK8iL7RU5dGO+qM+g+N+6//ZQF5UAmgeggYZ1yral0Jo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4970

T24gMjEvMDQvMjAyMiAxMTo0MCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoZSByZXRhaW5pbmcg
b2YgLm5vdGUuKiBpbiBhIFBUX05PVEUgc2VnbWVudCByZXF1aXJlcyBhIG1hdGNoaW5nDQo+IHBy
b2dyYW0gaGVhZGVyIHRvIGJlIHByZXNlbnQgaW4gdGhlIGZpcnN0IHBsYWNlLiBEcm9wIHRoZSBy
ZXNwZWN0aXZlDQo+IGNvbmRpdGlvbmFsIGFuZCBhZGp1c3QgbWtlbGYzMiB0byBkZWFsIHdpdGgg
KGlnbm9yZSkgdGhlIHBvdGVudGlhbGx5DQo+IHByZXNlbnQgYnV0IGVtcHR5IGV4dHJhIHNlZ21l
bnQgKGJ1dCBoYXZlIHRoZSBuZXcgY29kZSBiZSBnZW5lcmljIGJ5DQo+IGRyb3BwaW5nIGFueSBl
eGNlc3MgdHJhaWxpbmcgZW50aXJlbHkgZW1wdHkgc2VnbWVudHMpLg0KPg0KPiBGaXhlczogZGVk
YjBhYTQyYzZkICgieDg2L2J1aWxkOiB1c2UgLS1vcnBoYW4taGFuZGxpbmcgbGlua2VyIG9wdGlv
biBpZiBhdmFpbGFibGUiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA
c3VzZS5jb20+DQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRy
aXguY29tPg0K


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 10:58:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 10:58:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310030.526619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUW2-000343-ID; Thu, 21 Apr 2022 10:58:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310030.526619; Thu, 21 Apr 2022 10:58:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUW2-00033w-F9; Thu, 21 Apr 2022 10:58:26 +0000
Received: by outflank-mailman (input) for mailman id 310030;
 Thu, 21 Apr 2022 10:58:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhUW1-00033m-7s; Thu, 21 Apr 2022 10:58:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhUW1-0006Tq-3b; Thu, 21 Apr 2022 10:58:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhUW0-0008GS-Jx; Thu, 21 Apr 2022 10:58:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhUW0-00080p-JT; Thu, 21 Apr 2022 10:58:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jtt2ZE+SjZ9xUz/fR6jSL8raqGoFIe+CJoINRiReQv4=; b=yeiiq2ojDcZub3ZDIDVV0eOQD5
	iFNMWTYa1EejmPS4tJheDC+bWjebqR36ZEGx1jnXXxyWwc/5so+sSSFgfmfPcZ2e4bGvXzgPD2l6S
	3ZZ7g1OogPxn3CWtm/QTNto+cLCg09aNSMY84c0sgCVNrF0cRLTj6JSwD1ZHsBe56k9Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169589-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169589: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 10:58:24 +0000

flight 169589 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169589/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  535 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 11:11:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 11:11:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310042.526646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUin-0005mJ-TE; Thu, 21 Apr 2022 11:11:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310042.526646; Thu, 21 Apr 2022 11:11:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUin-0005mC-QE; Thu, 21 Apr 2022 11:11:37 +0000
Received: by outflank-mailman (input) for mailman id 310042;
 Thu, 21 Apr 2022 11:11:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhUim-0005lq-NR; Thu, 21 Apr 2022 11:11:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhUim-0006ii-L2; Thu, 21 Apr 2022 11:11:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhUim-00009h-6z; Thu, 21 Apr 2022 11:11:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhUim-0002iQ-6X; Thu, 21 Apr 2022 11:11:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qI6OXFaGBRv8nUAEm3pWZ0MHroqzbaZSuATE8IuEuVo=; b=yXFQq6tu83L6WC/3q4BBZQny0T
	5xK0j62m0DAR2B6DkoHsAYxKaYrKXnwjyt5mHcvhkco1QheKoRXAYyPBgl9SX+2x8EMbTVR3Ot4Kl
	9sLIrE13IPapOyc2t/fjTR4Kw5UnSkUdeG0z4RW3Uyz5zCBRTcKAJMK/8unXvrH2j+BI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169577-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169577: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fdef107edd4459375f9c0e6e377f30e82d498747
X-Osstest-Versions-That:
    xen=e9935146cd695188e70c10a6dda9f24ef9b63e30
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 11:11:36 +0000

flight 169577 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169577/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169565
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169565
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169565
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169565
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169565
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169565
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169565
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169565
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169565
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169565
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169565
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169565
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  fdef107edd4459375f9c0e6e377f30e82d498747
baseline version:
 xen                  e9935146cd695188e70c10a6dda9f24ef9b63e30

Last test of basis   169565  2022-04-20 08:57:32 Z    1 days
Testing same since   169577  2022-04-21 00:39:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e9935146cd..fdef107edd  fdef107edd4459375f9c0e6e377f30e82d498747 -> master


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 11:12:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 11:12:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310054.526672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUjX-0006mu-EQ; Thu, 21 Apr 2022 11:12:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310054.526672; Thu, 21 Apr 2022 11:12:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhUjX-0006mn-BT; Thu, 21 Apr 2022 11:12:23 +0000
Received: by outflank-mailman (input) for mailman id 310054;
 Thu, 21 Apr 2022 11:12:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/CjG=U7=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nhUjV-0006Gl-So
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 11:12:22 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on20606.outbound.protection.outlook.com
 [2a01:111:f400:fe59::606])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8727001-c163-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 13:12:19 +0200 (CEST)
Received: from SA0PR11CA0012.namprd11.prod.outlook.com (2603:10b6:806:d3::17)
 by DM6PR02MB5244.namprd02.prod.outlook.com (2603:10b6:5:48::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 11:12:16 +0000
Received: from SN1NAM02FT0023.eop-nam02.prod.protection.outlook.com
 (2603:10b6:806:d3:cafe::71) by SA0PR11CA0012.outlook.office365.com
 (2603:10b6:806:d3::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Thu, 21 Apr 2022 11:12:16 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0023.mail.protection.outlook.com (10.97.4.236) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 11:12:16 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Thu, 21 Apr 2022 12:12:15 +0100
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Thu, 21 Apr 2022 12:12:14 +0100
Received: from [10.71.119.153] (port=55901)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nhUjO-0002gU-SQ; Thu, 21 Apr 2022 12:12:14 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8727001-c163-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BpdknWLIhQ+uQuDGKtIoEprSMA0lEil3zC3eLjonucVVO2/AWreKejSgbvQEz+QPh4sFCv3VAX0/EU7RTDENn4FHgPjBrNYrpYECNAaoQUKuU3HKrD40mtEtjdx5tr7WoEVH4Yv6r6twAJhivIUSc+/fHnsL21X/XP61QKX3AzJROQXHfnUbKZNdT7lVf1NRkO2rsHSgf2rO7vi4KT+7fxPksTibHhnQiEc101INzxeBZYHjFYsmoam+QehjoKloqVvseMJLkJLeIkqLDMNBmHp5P/PkcDS16kK03YHTWSM/3rtgr22A2G9dm7Or229WTVr2UXvZ5CZTQ2D+1ZqiDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ayjYtlWkn1QhSNk4ar55+UT61YtxMb725DAP9tz1D/M=;
 b=lGQ++RfIUcJrgWYnKrjYNjLEkWz7IatiKwlNVDRUOb700m9tnN7OMef+ur5GPil8QLBuJY94Je5jouBMK59U2JqhX/SyxrTxsCXQwV3gziY6f3kREYdb8DAulxm55XgHo7pi0oczl2+LLZAK281SQ4FjQ041SeDEpJemeCqr0P6Tww0IvoDkzlsg9rwewt518v55g4KR1MS8S+POjlIum8tnEkF9IFkZ/PtoFxvArsoqEqwiLx0ceZ4GGIOX/Cw4cuAD8HUlgyWlBcDSJqvT4AGit6UCeMecSRACU9j0SUIS7aTqyjS4P8DUNvpN+YmuO7/hjCB3wyTmmpVbdyHPIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=arm.com smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ayjYtlWkn1QhSNk4ar55+UT61YtxMb725DAP9tz1D/M=;
 b=LTarhVGy0IzdUUYXDjtQP6p66EOv2YDiFqkNdDWds/SzXrmvHqkUBC+NoA07YBhyaP/zVMEgqoN+pEvapFjX1c5OKFp39CFPERYnhbmi2ciObftYQUxMzvmVgs2E2rVgocLO7f7p7YDwl7NEMS628yCP2hYWRN/l6AF9AW5OS64=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
Message-ID: <022fb545-9295-1f10-6caa-01813cf0a646@xilinx.com>
Date: Thu, 21 Apr 2022 12:12:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: Rahul Singh <rahul.singh@arm.com>, ", Bertrand Marquis"
	<Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>, ", Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Subject: Need help to debug Arm SMMU issue seen on guests with passthrough
 devices
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c5d42424-42b1-490a-c3c6-08da2387cb67
X-MS-TrafficTypeDiagnostic: DM6PR02MB5244:EE_
X-Microsoft-Antispam-PRVS:
	<DM6PR02MB5244E9DAFD0C896A03A9CA50B2F49@DM6PR02MB5244.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dzpZGy228nYtOL9kIMVHgwwCkI8/Y87KGWIeRnar7IbfACEG2I6MwZA3B4yDHEYfvzWmjd6B1p4XaoHbWRR8K8lWowrZlr7RSNz/pZaDXmgLrAjAv/GqORvIiq9A54WYkIpUv/bfs520lgVG1y1JhOpm309n3HQj0nd89/GZ9Iid2iQiUAAc5Pn4xj6kKBvPzIsI7TOhHXiLpKYN5VXwCml39vCrp4v0QGEFkOULnhr1E62IEQmyuYcfrdoIJUOq+ovnfbH5IeYlBaGf3aKNneqe6kOv/u3v5GeEsWWffgS7OXJ+0Z8BHdxRj8lwWtxAM9BItWj6uSxtYkwiNwx3orn+Ix6mH7+KonWZP2Ie8ZlHcbx5u/5lCgmz+h7Lcgg2Um3ylHMYFIj8g9pQtB2TCJHp91pw+q923yjGiSj3KptoFZHOrVdoBlDerL6cQP08CRi5FCZJVvjr4e+a+VUfeTOIBU0TMVdEVnLpHwBKrB+9T6A3+WWlJGj2kONkzDECnFGauLTI3YRXmHoIcDOKXcfNpKFb5MRgvBc2Y9fs03hN4zU1mMcaO6WhlplOMR6FO9qKM6fvjPX27WeB3CjAjClWZhP7XuxMvvutBb1mQ34m7GnDthc8rW7WQYoNl/XELZ4Q7lH3nToF9FHIo/r03Py5nGab3liOc5Davu2YeqAHsRolpFLvgdzADFXnIWMoHsBWTY7fpq7s3eGQIy4NUDYdAhH7TnkV9urgXchuqGA=
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(8936002)(82310400005)(5660300002)(9786002)(2906002)(36860700001)(31696002)(26005)(31686004)(4744005)(70206006)(70586007)(7636003)(4326008)(8676002)(356005)(47076005)(336012)(186003)(2616005)(426003)(316002)(110136005)(508600001)(40460700003)(83380400001)(36756003)(50156003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 11:12:16.3666
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c5d42424-42b1-490a-c3c6-08da2387cb67
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0023.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5244

Hi Arm/SMMU experts,

Scenario :- I am trying to assign a device (eg mmc) to a guest which 
uses smmu. I start the guest using "xl create -c ...". It works fine for 
the first time. I am able to access the device.

Now, when I destroy the guest and create again, I see this issue

(XEN) smmu: /axi/smmu@fd800000:         GFSR 0x00000002, GFSYNR0 
0x00000000, GFSYNR1 0x00000871, GFSYNR2 0x00000000

0x871 is the stream id used by mmc.

We are using SMMU-500. So from the Arm SMMU v2 specs, it is 
"Unidentified stream fault" for stream id "0x871".

This issue is seen regardless we use 'mmu-masters' or 'iommus' property 
in xen device tree.

I can confirm that this issue was not seen in xen-4.14.3. It is seen in 
our (Xilinx's) latest release ie xen-4.16.1.

I am using our downstream fork of Xen. I can't readily use the upstream 
as we use lot of EEMI codebase.


Can someone try to see if this issue exists in the latest upstream Xen ?

Any pointers on how to debug this further ?

Kind regards,

Ayan







From xen-devel-bounces@lists.xenproject.org Thu Apr 21 11:35:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 11:35:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310061.526683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhV5y-0001Ou-C9; Thu, 21 Apr 2022 11:35:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310061.526683; Thu, 21 Apr 2022 11:35:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhV5y-0001On-9F; Thu, 21 Apr 2022 11:35:34 +0000
Received: by outflank-mailman (input) for mailman id 310061;
 Thu, 21 Apr 2022 11:35:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhV5x-0001Ob-6O; Thu, 21 Apr 2022 11:35:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhV5x-00078r-3R; Thu, 21 Apr 2022 11:35:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhV5w-0000ty-Je; Thu, 21 Apr 2022 11:35:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhV5w-0005Ht-JC; Thu, 21 Apr 2022 11:35:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sGTNXvGodTBZjPid+0U2httVg3cRtJi7D/JwpmYRyKE=; b=yVjvJ6fxRgACvfbOmZRNQPKEh7
	oLpxatQdJR2+57TdcNmUVJe2yjF4cz+oKeCQ/jxbuufnDbsMjl5cEo6VTc0jriC7IVD5BZRYC3vWT
	81k9W9JaZ2zqE7Xj/3rG3EeZGZaoEF5af4cUl6z2QzT9WZU5m2YlHus0t/F5dmgszQgk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169590-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169590: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 11:35:32 +0000

flight 169590 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169590/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  536 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 11:38:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 11:38:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310070.526695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhV8y-00023F-Re; Thu, 21 Apr 2022 11:38:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310070.526695; Thu, 21 Apr 2022 11:38:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhV8y-000238-Ob; Thu, 21 Apr 2022 11:38:40 +0000
Received: by outflank-mailman (input) for mailman id 310070;
 Thu, 21 Apr 2022 11:38:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhV8x-000232-BF
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 11:38:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95d09612-c167-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 13:38:38 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2052.outbound.protection.outlook.com [104.47.6.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-DlZo_wojMYaBVkoGLZc97A-1; Thu, 21 Apr 2022 13:38:34 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0402MB2924.eurprd04.prod.outlook.com (2603:10a6:3:d4::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 11:38:31 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 11:38:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95d09612-c167-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650541118;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jr6ZU9kFlnV3p/SkrDxixPwzoRQ4FltgIQce8A5gICY=;
	b=ipmnTc1Bl0dzOAra4XYPJwMoY9eerwlc5gK9dA0xZOn82sq8JjfQOOkEKQvWT3mywbxsjr
	dZRfN+UBFgVRxslIgSxxj7C6Jyu+6l6yE1ftKAgcsuylkh88LLIiTfqbCeZ3lvkYRM8KUU
	nEEN+qC5mjKHNRkkEqiE/K/IA5tnXOk=
X-MC-Unique: DlZo_wojMYaBVkoGLZc97A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VC/1Ddv9YcmgjUA9tB8nxQvm43GMiEPYIsODQxsMzV8UiiAYSiVnSJISWkixLrENaWPDk5Vd3hYgIw0CPrmEAKOuYl+Xi3CEMeHqEB6SBHIhOokC/mNeCj+j4lnG3pRzXKufkSxNy7AYP+qqmiNOSutuLMyHaPIm+7jm1YHGlZSl398PfLSlj+Q2Gkzvz07fGjJvfEdZ6txWaUzwLo9ArzjZUc5If+7Hh+0PvF+hjSu3uc5waOvYK51iLX8lN5RxIXU8k/i+W56XCBMcDNnfJTFQMyghirfrVP1gNXPRmUZnYaCtaWdPAvWpjanQYicPlmopl/aiiEZDf2QWhDzNCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jr6ZU9kFlnV3p/SkrDxixPwzoRQ4FltgIQce8A5gICY=;
 b=Hcseiq7l6wWpsuAN5GOhSFvhwaIo5MOa/+baHpJbDi93FRhF0fEluLlZchDfj1aCW4MaS24GaCN6i8QNJa4zCLqm7BDrwiKxgb7hAWtd43YpSXdbhG1Vc9gKH1Hn8PXhsifrjGVsL/9pSKeLcMTFnkCe/jhGapqzjIEMB9D50yP+g1AeZ6tyrRW2GnCH5TFMNZDqUdlrEIlHjMQCmCVgKzjy2VkSQBjGDNG6wrPD9ijjVu7NQxS5EETdvFcbdT0dFLt+fgvhaF4r//Vw/JzoMuxNCrX1LUfx7Af9Dn911KippHHvYYK972Bb8Dv/xaWtuu+yZSRVCRrPPxh+rg4zEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <34c410b1-969d-8b18-6b46-fbec72effc95@suse.com>
Date: Thu, 21 Apr 2022 13:38:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220421104305.878204-1-dvrabel@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220421104305.878204-1-dvrabel@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0163.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1ab87787-fe8a-4f31-97fe-08da238b7610
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2924:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB2924530073E0CF7CD2943C96B3F49@HE1PR0402MB2924.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2k2uQv082sKI3c/uDy949xk8+hHR5KVweDQy4ixM8ITwXedfCUGz31YZomoHVovj5a+uu8HB3ueDZ8kb5T+QWw5GyGVKWoBtpBVXwc0h8uc8E/y3/jZFZLarBfE9LEGOagQv2tLPIH2PcrlSUn/XXKPE6ZouHKNL6oFWU5Z6BJYyk95gOGJlXW1GLfghbODu1c/3zCz/xwd3FijC52TvVYOage2wBZrJvTIItvh/9tWt7izSC6xwgowfekH6d0zfrfkR8k9WxUk74+PnV5Q7JLYjKG52jiHjJkQIS8RJyoeLsAvIAIB99aLYuKLjaUYQzFzMUtWRnkULuOMy1wICv8OvtWi/hJ5Lj9RI01H+ksRazwZWeKkEJ1902u749dJC5muuf6eRGL9c41E0mLw0/cIyPNk/MMdrc4dQCSFOqQy8b+ydsGH2i0Ijj3Dq/IDf5weS6WMY7sGklZD9eUH0u5Wo70UCpyEQr3c2S659BngtDSwbHV3fDogAZ5VDeLnOEwaPHxtlDF5dNDuaqiAhJQkmLdBsHvzKAoabfZBP3gxPD4ELxSRxQ1zQnpKhmTl6KwmmTjsxOwI4RU5NUMMJ8vq81Y+d5VbSMgvTaCL2q0qJxOfVU3BXuOaa1MzkMYQcpklYjHhWhpqOSYHQpzEuEPubqB8n2B/zEDOLbBk8oIDVFJbG8N4/HHz1IO03jmtmbsmD3YrcDB7XZMz1QpfKqMrNhZ25Xlezq1te5FD23lJ6sDXCmMX/mwQztyCRmNIC
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(508600001)(2906002)(5660300002)(6486002)(6512007)(186003)(26005)(6506007)(53546011)(38100700002)(31696002)(86362001)(83380400001)(31686004)(8936002)(54906003)(316002)(6916009)(4326008)(66476007)(66556008)(8676002)(66946007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZVNVWGVVanVpNStzTVdONytkRFpzdFdTNmMzeWUrWmNPQ0R6VndCQmpaOFQ1?=
 =?utf-8?B?NEVER3ZnZ1N1c2dLQmYvdmgxQjVKUUZFRWpabjQxSlhJVE42MkRuS3Fmbnkz?=
 =?utf-8?B?Y0poaXNOWWhrSUkwMkFzNk5OV0NwbTI3Qm8xRE1ENWZYaThsL05VZEllaGNx?=
 =?utf-8?B?b0ZFZC8yQ2o5b0hhUFlUT25vZndta3Z5VS9VU3kzSzRJSVRVdUVweThtZ0lr?=
 =?utf-8?B?eXRhcHBDdm1rWWcySW5LWEt0TXdueC9jVVFmUkZRTi9EUXJUaC8wUzJLcjZK?=
 =?utf-8?B?dEZZVjF1TFBkTjZCdXEwWFRGTFF3dGRQeFRVNUpmM280ZlNlYmxYdUZxdWI4?=
 =?utf-8?B?Um9qN3ByQ3FEa1ExeEt5YStkSjNjSVFMcVkwMU4yRUpoMUVRNjhKOFA4THA1?=
 =?utf-8?B?bitqdG1JTFhMQUQzWGJUendYZ3E0U0V6R2gwNStHWTduelpTYnZiWXd6VUZ0?=
 =?utf-8?B?OWJvQm8vb1U5ZGpYbE0ydU5PdEhpN3YwTWlWbmVLeFk5Rm81Ty9sWjJ2M3Fz?=
 =?utf-8?B?UjRRMHpqbThWdWlVWE8vdFdyQkpwYS9STXlvN0JiYjVnTVM3elBBN1FtRWxy?=
 =?utf-8?B?QmJscWI0YlpycXlWT2k2N1ZGeDJRcjBHMmFxUHBFUUduTFBhVjQvSGExYlkw?=
 =?utf-8?B?akhHUGcyaHFxKzc2Ym1kK21QYlhhbS9QUi8xQnNXRHd5TXdxWUpmV3lUcmdJ?=
 =?utf-8?B?eHJoWm1Da2FXcWVuOGw0VzB5eWZiblVVOTkyV0E4WWhXVDE0UDVtaVMrdXpI?=
 =?utf-8?B?eURoVFlTNmNtazlMSTY4b1huSWZPTDJVRzNWR2JtcGR2Z0FaY292ODd2NG1P?=
 =?utf-8?B?YzhIM0NWK0JwL2RRY0ZGN0lkZEdScGk4QkVUb0VDQTlVVkxYY3F0WTdmOWZi?=
 =?utf-8?B?MmcreTNwdlZQSlRoTEx5V3R4Q0pCeXd6bzcwaEVHM044dVRTRE1UTm51ZnhV?=
 =?utf-8?B?MW1DME1nVVAvb1VLdW9TWi8vQXd3U2pROHpXcU9Eb3dFYjZzdWdVU2g1RG5F?=
 =?utf-8?B?dlVaV0ZWNm1Ic3VRWENtWDBIcTJzNVh3SEE1VE5abEk1YmRYZDhxZkxrd2pB?=
 =?utf-8?B?cHBMQWY3dUZXRXZ2ZUZnYjU3MExaVTVEU1J2THhhZWs2d2dwaWFlbDFUdkJW?=
 =?utf-8?B?RkE0bzNPdTZIN0FHYlc3ZWVVMUoyOWwyOHIvSkx3STdOZWR0NS81OGpPTFV5?=
 =?utf-8?B?NmlNVGRBWVIvb01xNi81QjE2WVNBenJsNW4yU1U2SkxKS0Q1TG9WaVdENnhF?=
 =?utf-8?B?VzBWUUwxc2taOEFPWjNwSUEveEtGQnQzMkNTd1A4RVRjUVhjeDR0QkNRblkr?=
 =?utf-8?B?NjhMeTRNc0tiQ25vVnhDK0d1VXdOZE95Z01rZDRkbGwreHVsT0doMFdMaWYr?=
 =?utf-8?B?dkgwb2NYMnBkV25ZVmpETHgzQUxCdzJteS9PdE1hZC95TWlmSjBGMDI4eHZ1?=
 =?utf-8?B?SGtYM2VqWFFKb1dxWThCclpyZE5hcnp6V2VMRmpBbUpTeTNtVUZCNG1wRWc0?=
 =?utf-8?B?ODlWRjhHSG0rN3dTS2YraDJnbS82NG5NR29qZjFOQjhLUlNDcVp2NmxNOGph?=
 =?utf-8?B?aVhLdUQ0ZUwyUm95Ty83eHZqK3Y3c2NHTzkrdi91NWdVY0REZWpqWkFOZjNr?=
 =?utf-8?B?TXdzVTV3SUgvM1NsYzBPRDlTQm5wQ1JibDNrcHBVZlZ0eGk1UVdZd1UrdTBh?=
 =?utf-8?B?RUNGQkF4dG9FMkJBTUJHMktibnU0VE9WcGduaFVNUUxXUzRaQ0ljTXdQenEz?=
 =?utf-8?B?T08vRmJNMVYyM1Zsb1c3bXFQU285NHdZMHlraElScTdJYUNzQzNYRUxTWW9G?=
 =?utf-8?B?c0JaN2V1b05ha3RBVHJJRkhHRndJT1RteksyQWZnR3kxcm9FQ0g1STIrNU82?=
 =?utf-8?B?MFZ0MkVKMVNScFV1elJSa1lYT0NkNWF4ai9xMEdUQ1pIUWtqdDZ4WU8xNXlB?=
 =?utf-8?B?OUdHaUVhdHNSMmhoa1Z2Z0xzWnMydGVuT014L1paQWtDcW1YOWtnUjVZTWcy?=
 =?utf-8?B?WFd5RVhYTmlZS3dkSzUwL3ZJQVJMYytPM1djVVB1WFZVeFFsT2kybWNKREVw?=
 =?utf-8?B?OTBqQVl3aWQ2dUs3UUtmMnREUUVUOVFCWkJSTEJCS2VDVDIyWW96N2c0N0s3?=
 =?utf-8?B?dlJiai8wN0xIQS95RVdFeUlFNG5tM1ZSUXB6Mk52SVBjUmFYRXZTaXVBMWJu?=
 =?utf-8?B?ZmVsOEFZQzVoY0dPUUJmZ29IcU5TQm5HTmZJV0h6K2c5ZkF0eTYwS2JIK2hS?=
 =?utf-8?B?dnV5aWdaSyszRGxJdFo1TWcvSEtNUi9LQTNremlIbE9aZEQ0VDU3a3FxTy81?=
 =?utf-8?B?WE91SkNVSGpmUFkxRDVpVDBCTHpneG9Gc2MxakFjSWFVMzYzK2RtUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ab87787-fe8a-4f31-97fe-08da238b7610
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 11:38:31.5977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X5I7P8x8CJKccWVpczu+ixg496h6H5NrEnJzdVtu5G5rBK6Txt/LQeYrARAs1+aFfvLmDcDXFBXU+TRe5pxlvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2924

On 21.04.2022 12:43, David Vrabel wrote:
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -984,6 +984,8 @@ void __init start_xen(unsigned long boot_phys_offset,
>  
>      console_init_postirq();
>  
> +    system_state = SYS_STATE_smp_boot
> +
>      do_presmp_initcalls();
>  
>      for_each_present_cpu ( i )

I'm afraid it's not this simple: There are two
"ASSERT(system_state != SYS_STATE_boot)" in Arm-specific code. While
both could in principle be left as is, I think both want modifying to
">= SYS_STATE_active", such that they would also trigger when in this
newly set state (in case registration of the notifiers was altered).

It also wants at least mentioning that setting this state is okay with
all uses of system_state in common code (where it's not impossible
that x86-isms still exist, having gone unnoticed so far), just to
indicate that all of these were actually inspected (there's just one
where it looks to be unobvious when simply looking at grep output, the
one in keyhandler.c). As a result this may want to be a separate,
prereq patch. At which point it will want considering whether to put
the setting of the state _in_ do_presmp_initcalls() instead of ahead
of its invocation.

> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -162,6 +162,14 @@
>  static char __initdata opt_badpage[100] = "";
>  string_param("badpage", opt_badpage);
>  
> +/*
> + * Heap allocations may need TLB flushes which require IRQs to be
> + * enabled (except during early boot when only 1 PCPU is online).
> + */
> +#define ASSERT_ALLOC_CONTEXT()                                          \
> +    ASSERT(!in_irq() && (local_irq_is_enabled()                         \
> +                         || system_state < SYS_STATE_smp_boot))

Upon further consideration: In principle IRQs would be okay to be off
whenever we're in UP mode (and hence flush IPIs don't need sending).
Provided of course spin debug is off as well and no other IRQs-on
checks get in the way (like that in flush_area_mask()). This might be
more robust overall than depending on system_state, but I'm not going
to exclude there may also be arguments against doing so.

In any event, looking back at my v1 comment, it would have been nice
if the spinlock related aspect was at least also mentioned here, even
if - as you did say in reply - the uses of the new macro aren't fully
redundant with check_lock().

Also, nit: The || belongs on the earlier line as per our coding style.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 11:48:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 11:48:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310075.526706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhVHq-0003mD-Lk; Thu, 21 Apr 2022 11:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310075.526706; Thu, 21 Apr 2022 11:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhVHq-0003m6-IJ; Thu, 21 Apr 2022 11:47:50 +0000
Received: by outflank-mailman (input) for mailman id 310075;
 Thu, 21 Apr 2022 11:47:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhVHp-0003m0-7R
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 11:47:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dce4c546-c168-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 13:47:47 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-rJzTY4BvPMubozgDOtq7jQ-1; Thu, 21 Apr 2022 13:47:43 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PA4PR04MB7952.eurprd04.prod.outlook.com (2603:10a6:102:b8::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 11:47:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 11:47:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dce4c546-c168-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650541666;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WMTJN4SIPofYUV6ct57m8nmSHWtqqPK5hlNLoMIg3L4=;
	b=TPNakM56wSDg7kXB29Ff1HMNiCcI487XoO0OujbyHFSXn5n59G9KE9u9VeLaVrsSxXMXeZ
	3vilY9fm5XhdlUw8hobmEnnspgT/Iu5V8XIXLUZCOTSU1hKOVS6lDk/LK1wFwsl67ev53U
	EDxyfY2h2yyno7DCqa31LoiB/rF2sbc=
X-MC-Unique: rJzTY4BvPMubozgDOtq7jQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HLHSacRFvSQ/BLHoTEUZH7C8ziY0kMZCJrVWu2sW/UQvbbNTOgUBI9SdL1JpAMaQBG9EWAyCJLQWLGYKjTiZ0pt9FsaXBDX+zwopp1XJXq+Wegrv+eT/N2vNGz6R8LfexlW37BriTG0+7AMiebXwlL+55rXY2mB8EY+Fafct/HOEvlOR9HcjaS4hsOOG477kegNdzHxJrYF4o1uDPTRPpAEwURWIV49YL12oK6lsrvztkoj5hWv+gPzBQmjNVA/9ehbwC/W8iRSFcXBS9hXmzuv0yqR0vwEL3knGIZtPfcbdE8jhbQflNA5qMZsOtigJfoPa6e8FG6Cn59tRzYqucg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ldsrMJ1vOYDMITcqJ1do5pRntxT9UX/xi9Q6RLrswm0=;
 b=Em5WyOVNAXYOJlhnaRHPiXW+ELBUn9x+uwKM1DLUz0oVqfLSrHpxU12Xl4dTqHLZEUMDyYFu/c+mdgr6SyJkwC6acefV2U48MaP48a9xuoF6bb3BOXyaCd0ztiir+/LYNoQi7QgeCIJn4WzH3oc/ogolMOFaq+4Gel/Bq8mK0lyqRmz2SC7A2wbCAWSG/avqXrXkp4/EDJaxzjviT/IOMxY7lkwCTVcpxFp31AN6kZDXVyRPubzevZWFmiM3iigupvlLZixysgcf7co16y4+5tuZuhcL4FS1W9KAaUWuDWr1qpD5UOrwL4XQ8G/Gia1uFYUu9EuaNk6Vh9AXgFnCwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f97c86b4-e918-0496-c0dc-d7e4a0ebadc4@suse.com>
Date: Thu, 21 Apr 2022 13:47:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: Need help to debug Arm SMMU issue seen on guests with passthrough
 devices
Content-Language: en-US
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Rahul Singh <rahul.singh@arm.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <022fb545-9295-1f10-6caa-01813cf0a646@xilinx.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <022fb545-9295-1f10-6caa-01813cf0a646@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0386.eurprd06.prod.outlook.com
 (2603:10a6:20b:460::33) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: efe8ab49-25ba-4182-aa36-08da238cbdd8
X-MS-TrafficTypeDiagnostic: PA4PR04MB7952:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB79524453690C3C0348F7CF2CB3F49@PA4PR04MB7952.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1RH1DK/ncElkti0kL6OTSDLf5cfzy/P+9nCky5MvlBg1LpBOkZ5DNbuEVpdsfZBFUQzTX1fhGmykFW/Sx5DNeM9GHMnD2KAqRixMbL3A1qR+39Nv0truqpdqMiDkQChy+FPLWAPKeSUklgEhqcP88CWkO8MeXCRE3ApdgSNU/6Cc4lXH2R6qACdnX2Nz9TyJ2vl5/G9eL7QPKNB/kNUns8MjRh5zz90Qz10tyfsvyMgntN3V0n4mYiHoNJ8LgaYuvWgKhgk3LCFHFc+r21LlZDtvJshW2wrc7We52JT4x/1SCtvijmsp/9FVabY+tq8D+WZ6dRFWA+pX/7D95gmuCtOvmgSkvJ6CpfNrvdBlrM0QAS/sb259TpcNMqS2YQhuZzbft6e4/zKm6GAV5mhgatIFziCPZDTH/HT+jQgbHizb+X3Fxf5szvrbERbV5qI0ZL0gO1BycPKFq2WPJtD45oqwbyz/BJFW3/qKh/2F3XAnWxOdT82Daa+7U9fWVFgMpjsPF6xkNCK76TKHI/SVrwBI+jrXHdJoE0NS3jH/LXm4mtG/XrlAJ+k5jItrIjwTRNkFnURupktnlRWhOk3R4Vth1feEncj5cHZLO/GBVlfCxVUW/ITmx2VdIRVXmxKyZn1MFq1sC0noLfSZhrIC5KssPF6wa63NfxFzH7Ss6afA7RobUCgwaG6MlYIalcEmbQ5JHvNIZToPlVBgL+03CujXMy+af7+aJ7FD515fHEA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(66476007)(4326008)(8936002)(66946007)(6506007)(66556008)(508600001)(2906002)(6486002)(83380400001)(5660300002)(86362001)(31686004)(31696002)(316002)(2616005)(38100700002)(186003)(6512007)(53546011)(54906003)(36756003)(6916009)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RVvNxirUvJuVHFOT1i5wJ5jEuHg19g5DltW6BCYHZldBdzrtWqMHnZe38qm4?=
 =?us-ascii?Q?VNM0CrJIs17tepQBh4F/FHvO103W87iE/bIoL1kBYonDx8HS1Mkdmf/Q7j8W?=
 =?us-ascii?Q?I1VFQ2V3X7np7yvTHNZ6vvcBbY7iikaq608wdSyGAPWaHn7skxbTQyOICklx?=
 =?us-ascii?Q?C+ebe5/K8cR4rIP39DW3Se0OzoLMmZPbrlJZP9rTtcRAjN0gYjtonEhozKWr?=
 =?us-ascii?Q?790cS0cMHwPsuKcJ1JsRnstUFL0VppSFWiLXPD6uzytGKgESpfa+FWR85oo9?=
 =?us-ascii?Q?RP7k739eoqRAp0ELFqtqXBYjLMYhauSEkaqt92xw0Jas5fPxuJ/TMaBz6VSe?=
 =?us-ascii?Q?RWFrrl5oZXCZoLjtk3g1SCiFYkh/jXSUkh5UsuRsUjg41J2nC3ss+HKzreQY?=
 =?us-ascii?Q?ABtU4ZCsH0ZWPscqaBPu1FDcI4dTEFXUR0GEvveNdAEbI3m2Sg8IZ7Nb7Vko?=
 =?us-ascii?Q?L7FRKqPDqO7ZLLSRrG1kG99blUXOWbyj9N/AHPv024SV5ipoO4+WevWf+FiY?=
 =?us-ascii?Q?sDF2OUJ86S9Cd3ZnX/og0ZzGJuK1982nhSANeK2TmFROzhho57MN3yozM5Z7?=
 =?us-ascii?Q?fMx3ryvT5FgwMesHNUFgs7yJGWqa/FcG1oisrzfOgnZn/tB2sDkBCelj6lqH?=
 =?us-ascii?Q?tXMbEYW++kenPmrk/egfMp1MEVfb8saOFufrqRp0wXIvlqRExvPm54L7ibgq?=
 =?us-ascii?Q?iDkQrNCtapMg3KMjXZdFGWBrtfKBhM2M0uW785HEjhD83ez0au8YTS6M0FyL?=
 =?us-ascii?Q?E7Iw4iZb2ousASaBiGbJDJNWRn4+5+p7NMQJ6xL4z3aEcpu09H3BLxVSaQr5?=
 =?us-ascii?Q?IYaxnSe5vL46big3x8XHGctlXMbRnvwiKUga+1dipezQ343bELQ3r2yoJVOM?=
 =?us-ascii?Q?zUkpj137PEOMIzyJABsU5lti9r7YlQDhaeNV1Qme+z3GlkDNYQ5L8D+NQA/3?=
 =?us-ascii?Q?cCF8ccJPWtYumjUWAyQWMxboBgreCjGsjYJBtZResWM4O5fsqX2n+k5G1p3c?=
 =?us-ascii?Q?C+hmwobf2b5hTPUGivI5y2pzrf7Zg5TkwFqzDIKm9sNagdoAThtfVE4XG49/?=
 =?us-ascii?Q?8s5CEpZXWiSRNH7acfYk/zIi1o20ThQhSo74Uno8jTCGS8aQ5m17PgkDZ1fZ?=
 =?us-ascii?Q?w2hC3PgAhc86T+K7zXjuoNVOMNIUZrWHpo/8DvU99MoGuUZHRRbbZ3EtjjcI?=
 =?us-ascii?Q?eiVl1W63K/8k8cG+WlI9ImXlggsphwB+VO1DFJC//JKo7d3m2HFDKwy/AJ78?=
 =?us-ascii?Q?LWw0yECVRPnRPhJnujZ+V7LdQ9VlcAyeRwchxxOwz/hfwhzIeB80NVeZDRMF?=
 =?us-ascii?Q?Gopk6gqlzBGYPoS+tWoZhLsBVdWYfayTErGpB+iSkcnS74J/QTg/E36YxqK+?=
 =?us-ascii?Q?/ljVSzojMaAwnWgbmRQ2Bkn2ZvsczPL3SAvv7rVwThhSlVcKtvH3jnnrUExq?=
 =?us-ascii?Q?Tgch6WelimLD0BWqRZubMOefWaey3yKqRNVFVbZG4rohrlA+l50ixNQOODjr?=
 =?us-ascii?Q?ue9ifT5ZTgZ4eFPmnCIXe248E5Gxh4RnvjzRZHDKHs44VpZZfzqs/PjHKCnd?=
 =?us-ascii?Q?ikTw6yU0mlC6yCHAW9oTVn62E1NJx1W3ZEGCxJGoXyoLKHrwheet/XBw7FdZ?=
 =?us-ascii?Q?vluGBWwlanyiarQIuL9BoAn7Gi8apCQP0FYcb38Xl6PoiDDODaWaq8vFfOlf?=
 =?us-ascii?Q?sLKGyaV+1YNrQMr1nJCqd04I1nc47xLSMfU+TbSSvc4AH2lQqmeYHtcfVWhV?=
 =?us-ascii?Q?15OmzuxB7A=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efe8ab49-25ba-4182-aa36-08da238cbdd8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 11:47:41.6489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sptzJCPS/lj0GZQVOOMo80HcTk3bj2czY5kuE4peL4hWVpvQ7vUAu9wkTcWKzCqgl+prL79QtJFzuZVVl8HDEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7952

On 21.04.2022 13:12, Ayan Kumar Halder wrote:
> Hi Arm/SMMU experts,
>=20
> Scenario :- I am trying to assign a device (eg mmc) to a guest which=20
> uses smmu. I start the guest using "xl create -c ...". It works fine for=
=20
> the first time. I am able to access the device.
>=20
> Now, when I destroy the guest and create again, I see this issue
>=20
> (XEN) smmu: /axi/smmu@fd800000:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 GFSR 0x00000002, GFSYNR0=20
> 0x00000000, GFSYNR1 0x00000871, GFSYNR2 0x00000000
>=20
> 0x871 is the stream id used by mmc.
>=20
> We are using SMMU-500. So from the Arm SMMU v2 specs, it is=20
> "Unidentified stream fault" for stream id "0x871".

I have no clue what any of this means. I wonder how I ended up on your
To: list. I'd like to ask everyone to drop me from the recipients list
in their replies.

Jan

> This issue is seen regardless we use 'mmu-masters' or 'iommus' property=20
> in xen device tree.
>=20
> I can confirm that this issue was not seen in xen-4.14.3. It is seen in=20
> our (Xilinx's) latest release ie xen-4.16.1.
>=20
> I am using our downstream fork of Xen. I can't readily use the upstream=20
> as we use lot of EEMI codebase.
>=20
>=20
> Can someone try to see if this issue exists in the latest upstream Xen ?
>=20
> Any pointers on how to debug this further ?
>=20
> Kind regards,
>=20
> Ayan
>=20
>=20
>=20
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 12:23:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 12:23:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310083.526717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhVqK-0000Xk-Gd; Thu, 21 Apr 2022 12:23:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310083.526717; Thu, 21 Apr 2022 12:23:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhVqK-0000Xd-DU; Thu, 21 Apr 2022 12:23:28 +0000
Received: by outflank-mailman (input) for mailman id 310083;
 Thu, 21 Apr 2022 12:23:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=abij=U7=cantab.net=dvrabel@srs-se1.protection.inumbo.net>)
 id 1nhVqJ-0000XX-Hu
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 12:23:27 +0000
Received: from smarthost01a.ixn.mail.zen.net.uk
 (smarthost01a.ixn.mail.zen.net.uk [212.23.1.20])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d7ced967-c16d-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 14:23:26 +0200 (CEST)
Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk)
 by smarthost01a.ixn.mail.zen.net.uk with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <dvrabel@cantab.net>)
 id 1nhVqE-00029I-7O; Thu, 21 Apr 2022 12:23:22 +0000
Received: from apple.davidvrabel.org.uk ([82.70.146.43])
 by pear.davidvrabel.org.uk with esmtp (Exim 4.94.2)
 (envelope-from <dvrabel@cantab.net>)
 id 1nhVq9-000VvN-Iv; Thu, 21 Apr 2022 13:23:21 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7ced967-c16d-11ec-8fc2-03012f2f19d4
Message-ID: <0b982410-9efb-dece-3bcf-3c6f2e1dce2a@cantab.net>
Date: Thu, 21 Apr 2022 13:23:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220421104305.878204-1-dvrabel@cantab.net>
 <34c410b1-969d-8b18-6b46-fbec72effc95@suse.com>
From: David Vrabel <dvrabel@cantab.net>
In-Reply-To: <34c410b1-969d-8b18-6b46-fbec72effc95@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 82.70.146.43
X-SA-Exim-Mail-From: dvrabel@cantab.net
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	pear.davidvrabel.org.uk
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,NICE_REPLY_A,
	SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no
	version=3.4.6
Subject: Re: [PATCH v2] page_alloc: assert IRQs are enabled in heap alloc/free
X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000)
X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk)
X-Originating-smarthost01a-IP: [82.70.146.41]
Feedback-ID: 82.70.146.41



On 21/04/2022 12:38, Jan Beulich wrote:
> On 21.04.2022 12:43, David Vrabel wrote:
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -984,6 +984,8 @@ void __init start_xen(unsigned long boot_phys_offset,
>>   
>>       console_init_postirq();
>>   
>> +    system_state = SYS_STATE_smp_boot
>> +
>>       do_presmp_initcalls();
>>   
>>       for_each_present_cpu ( i )
> 
> I'm afraid it's not this simple: There are two
> "ASSERT(system_state != SYS_STATE_boot)" in Arm-specific code. While
> both could in principle be left as is, I think both want modifying to
> ">= SYS_STATE_active", such that they would also trigger when in this
> newly set state (in case registration of the notifiers was altered).

These asserts are already too-relaxed given that there's an early_boot 
state.

> It also wants at least mentioning that setting this state is okay with
> all uses of system_state in common code (where it's not impossible
> that x86-isms still exist, having gone unnoticed so far), just to
> indicate that all of these were actually inspected (there's just one
> where it looks to be unobvious when simply looking at grep output, the
> one in keyhandler.c). As a result this may want to be a separate,
> prereq patch. At which point it will want considering whether to put
> the setting of the state _in_ do_presmp_initcalls() instead of ahead
> of its invocation.

Not sure I understand this comment. The transition to the smp_boot state 
on arm makes the state machine on x86 and arm look _more_ alike, thus 
common code should be happier.

>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -162,6 +162,14 @@
>>   static char __initdata opt_badpage[100] = "";
>>   string_param("badpage", opt_badpage);
>>   
>> +/*
>> + * Heap allocations may need TLB flushes which require IRQs to be
>> + * enabled (except during early boot when only 1 PCPU is online).
>> + */
>> +#define ASSERT_ALLOC_CONTEXT()                                          \
>> +    ASSERT(!in_irq() && (local_irq_is_enabled()                         \
>> +                         || system_state < SYS_STATE_smp_boot))
> 
> Upon further consideration: In principle IRQs would be okay to be off
> whenever we're in UP mode (and hence flush IPIs don't need sending).
> Provided of course spin debug is off as well and no other IRQs-on
> checks get in the way (like that in flush_area_mask()). This might be
> more robust overall than depending on system_state, but I'm not going
> to exclude there may also be arguments against doing so.

Not sure I understand what you're suggesting here. Do you mean something 
like this?

#define ASSERT_ALLOC_CONTEXT()                                         \
     ASSERT(!in_irq() && (local_irq_is_enabled()                        \
                          || nr_online_cpus == 1))

> In any event, looking back at my v1 comment, it would have been nice
> if the spinlock related aspect was at least also mentioned here, even
> if - as you did say in reply - the uses of the new macro aren't fully
> redundant with check_lock().
> 
> Also, nit: The || belongs on the earlier line as per our coding style.

CODING_STYLE says: "Long lines should be split at sensible places and 
the trailing portions indented."

If you're going to have rules (that have, IMO[1], worse readability) 
please document them.

David

[1] Compare

a = b
     + dksaldksa_daskldsa_dsakdlsad
     + hds
     + dsadjka_jdaksjdk_daskajd;

and

a = b +
     dksaldksa_daskldsa_dsakdlsad +
     hds +
     dsadjka_jdaksjdk_daskajd;

Which one is more clearly readable as a sum?


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 12:50:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 12:50:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310100.526732 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWGI-0004KW-LM; Thu, 21 Apr 2022 12:50:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310100.526732; Thu, 21 Apr 2022 12:50:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWGI-0004KP-IO; Thu, 21 Apr 2022 12:50:18 +0000
Received: by outflank-mailman (input) for mailman id 310100;
 Thu, 21 Apr 2022 12:50:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhWGH-0004KF-H2; Thu, 21 Apr 2022 12:50:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhWGH-00017y-ET; Thu, 21 Apr 2022 12:50:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhWGH-0003Qt-4q; Thu, 21 Apr 2022 12:50:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhWGH-0006DD-4N; Thu, 21 Apr 2022 12:50:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1e2or+4b7uVDV/SEvFZs66p6RZ2sraXJ8ODKWcyVEOA=; b=CL08xNJ/d5fsPlbOj5iy+UJvtA
	XKuZNQrE6Vd20i0ciaNs0X2FSe91DR1ZxLaYO3h3ST+5nd4ITuEp+CHZ1b+Xgz77IZqy4XV5CqZ68
	4lvc0quDaigtBW5SF6SEB+2OvierqY+j0QAzdUhRRN8UkO3KmERaidchDfalTBxwp7z0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169592-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169592: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 12:50:17 +0000

flight 169592 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169592/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  537 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 12:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 12:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310107.526742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWHk-0004u3-1v; Thu, 21 Apr 2022 12:51:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310107.526742; Thu, 21 Apr 2022 12:51:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWHj-0004tw-VG; Thu, 21 Apr 2022 12:51:47 +0000
Received: by outflank-mailman (input) for mailman id 310107;
 Thu, 21 Apr 2022 12:51:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhWHi-0004tm-2q
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 12:51:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cc4bb95d-c171-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 14:51:44 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-xAeJtrVBNUuV1hEsFJPtJw-1; Thu, 21 Apr 2022 14:51:43 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8400.eurprd04.prod.outlook.com (2603:10a6:20b:3e9::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 12:51:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 12:51:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc4bb95d-c171-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650545504;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rywNPPoj1p0qZQ6aCacAWvx2koG07iQjTQrkm0vQ37M=;
	b=g2fApB57DKwL/lfA9gYQZoXrmr9K188GqMeQnGmZNnp8C+0DRtOt5mPSkpiR7xwKgzLy3T
	ePVRq4cbGMotDYtV/YHZrHcCctGhtXSBt6J7lMCJosi6QcMid5rAr2j7QYta04WbXQRJuy
	xX5/8fV/LaJkD5a6qtT4K6M6Rfab4jM=
X-MC-Unique: xAeJtrVBNUuV1hEsFJPtJw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mi+CfLeNWLt8xs9Asn7JLlTeBaXGrBfoVSZRSsmvF1vKrIyk7iU/PqWqpChlqQLh6E/djDAaJRe5GOmF1RosObtRaTBv0qoup3hbyKuyTJRRVTzXu8iC+jMCgL7ci1Pt5NItR68kHT6rrxz2bdRmq2Ins4Us91CVUKoj0b/dd5txQ/6X8xsrCJ4fbq8joxiRkLBtxbnF5kHmv1x6IGBopvgcX5jMIpdKT+75OLQbzOkPpccmvJHVJf0lC2+VDgKJkiRXDOuAbZL2B1PlImHjvZBtGIembFwKMQZ4tuOlixQ/hZbTlIpq59Z1wbAG9KSlbrwGMrWBVZZrppOTzvSFyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rywNPPoj1p0qZQ6aCacAWvx2koG07iQjTQrkm0vQ37M=;
 b=cb82b3lFLnHfQkOYFTU4B/Tqts7qrUsueaPWQCX2bj8H7Itd/St/kY33gP9SGch0S4OOV0wko3TeKDM1qAU9v9sepUhPZCUclz3HUbCCbvayrgqBdUbalmmsu5gwDIXngoo8+XdNrQyvne6b/CzubS0JNhiZnctmmrC8/4W6zBn+R3YSz3HORbWEtlDw7yie2VB1j89jArSHzTj9ml+qNAWa1NCWn+Jn5s5eXHgJizu03d99QfgaHc4Respmaf6MZuSf0vN3pLPtffcI5ucEXClAZT2xWpnNyNbDy4OoC7pFBerANTLmNLgiQ1mztuDaMt3bK1jWJ0SVAiVUYl6dag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c55ba379-0960-0be8-b0d8-53c974f1a404@suse.com>
Date: Thu, 21 Apr 2022 14:51:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220421104305.878204-1-dvrabel@cantab.net>
 <34c410b1-969d-8b18-6b46-fbec72effc95@suse.com>
 <0b982410-9efb-dece-3bcf-3c6f2e1dce2a@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0b982410-9efb-dece-3bcf-3c6f2e1dce2a@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0022.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 00e866de-4992-4a61-acf4-08da2395ae89
X-MS-TrafficTypeDiagnostic: AM9PR04MB8400:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB84000A109637B3C2F81B50CFB3F49@AM9PR04MB8400.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	i7OjV7cjeis2iGDhGf+Pz+E2LE3iM5uRaqNPDivX+D8lP0Cm4u/WEbxHX8cH8j24U5MkDPro8do+jhG/OqgZma0hqQHslMHWOO5h6IIPAIx5JDypxBGzoli+XBpM3ChjXtgRTz4vT2TRgnSiHOjmro+oHpxF3fEXRH0YzxL0pSMSsit36Kvds7F/pKLLfkpwwBBzzy8ee3FCTKdS9H5hDNSdItnpAD87XZMHitSrzyoZdVbeHoZ+u7osBROavnbzNydMucikMRFwk5AoCi0LGvrFkNodjmUjDPH9ub5SjFba2dnZOtdZZtv4RFwQpLPpNEAJFLBPoopoHaHBTcYY/xehfvxgbjhuuxcaQ9RKQ9uB27T2++FaPeLJOHqtFQLZ+5trLLO8qAZQ+1Lx+iuCaeed1DIEQaayPHWT/0YjqoaXkmtXGeryVvwy5dHk7mnkEeTzE92SflB1iYiB70LEve3AB0XGCqRScndx5rRSrj4avGv6le39sSPpRXZgOn4WmoZdLzyD1Mi4opd7YsnFECybTgrrM6mSlEECLI5J0iXO4fR4GRJmDnH38L7O+RQ1NTjMTAdH26mk0r6ivYsQ385hpjT8GkQY9yjkfPOCJQwiLVYVxVOsTr4u7SY+L+btOGgCPvPO7/52jk+Z4Pt8XazX52lYdFwSplUABD7fBWbAbA8+eQ6hqA3LNVkrruiDZd705ylIvrgiamVLijFT4/zAzQVAmebNA1LPf0scGmq6amJdJKAa7g88zkJ2NwaI
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(66946007)(6916009)(54906003)(66556008)(36756003)(316002)(31686004)(8676002)(4326008)(66476007)(2906002)(8936002)(6512007)(508600001)(86362001)(26005)(6486002)(2616005)(53546011)(186003)(31696002)(6506007)(83380400001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NkF6bmZZWGt3TjFZd3ExeThJamdRZjRoa1gvZXlEZEtmRTZKRm5QcDc3clg2?=
 =?utf-8?B?Sk9ORUtDbDlMWTZhNzkrb3ZBL0xBTVVUME04ZUo1NlRkdzQ2UXhsZVJvZWFn?=
 =?utf-8?B?bjhrUGtHRTRQZ09VSVEwanJyZHVGQlRBbHRESWlYUzVGTlFjNVJ4UEJ0cUV2?=
 =?utf-8?B?aVlHTExNTnZQNGtSVEViODlTR2svYnF1OUh2K2FCVE8vUWtud1M1a3hEc3BM?=
 =?utf-8?B?V0NnSUZEMUJJVVpRaU05ZmFXRFB1aVVIM1c4SkY1UWkrV0dDRFlVaDM4TXlH?=
 =?utf-8?B?UUVmUFlRbHcwKzVhcmhRT09lZ1VOSFZNR1lTZThqQlZqRjJhNHVpRi9hNksr?=
 =?utf-8?B?TnY4YVdOK1pwSlplWDIzVWI0YkRHc0lxYVN5RHBFRXNwUm8wbWRoY1BGTzcv?=
 =?utf-8?B?Y3JOKzZJbFV5aXBDZno5dlBTTkhRMStSVW5GUERveW1JUFUwYnlSL0dqUFI5?=
 =?utf-8?B?SU5JM3RxUzZmQnc2VHA2V21xR1ROVXRvTGgrZVFrUDFGcENrNkdUalkxeElI?=
 =?utf-8?B?WlpCNkJ3V291eXF4QWEzYjFOUzVvSThRQXJhTURsOC9NbUppRHVwRWtYZ0lk?=
 =?utf-8?B?WGNtTmZ4Z3VkWjVwL04wMzdPR08yMTBUNVNYSmE2dTRKRFlxbzYyUjF4NWty?=
 =?utf-8?B?WTdXVk0vTm4rdXZUVjlwNGMwdTU4UFdBVURmWEtnVzdGRGJ5QnJHZWg5bDRi?=
 =?utf-8?B?U3Q3T2lVQmNMa21kdm40R2kxMXJaQUgyODV0cStCbGFNK0pJY2t6UmJTS3h3?=
 =?utf-8?B?T0JGZHdqdlY1eXkxUk15MTBZRFB2cEZBUE5KZU1FTFFRSFEyL2duTWI4TUxJ?=
 =?utf-8?B?WGFiekY2S1lSRFBsL2I5TTYzdTZ1RlExM08yNlNZczJvREhSVUM3eTMyMDNq?=
 =?utf-8?B?YklYV3N6NDlhZlNZaTgrM3hTdlphSXBDdkkxY0Vob2VBeDdXZFA3NXJkUyts?=
 =?utf-8?B?QWl5cEFKcFlCZFROdmhDNTNlZ3dydmdKSnVVU29NMzJxS2FqRStVTEJvbVpR?=
 =?utf-8?B?dGhKSlVhRGs3a1NxRUZNNEdLSnZhRzVJUm9GZmJITTA2RlRNb3A5QXRRQzcw?=
 =?utf-8?B?ZmlvbGxxVGtqU1psbGM4YmhZRDlBM0dtMWVzaCt1QmtkMEdENUpnY2tmSG5a?=
 =?utf-8?B?STBHY0ZRUitadWdkdmVtVkMrSVFMcXp2MXdDTUdiUU1JTnQvcFVrNFNWS2ZF?=
 =?utf-8?B?eGdqQVdQVHBmUDZPOEczTDdQbm5WSU4xdnFoblZZQWEvR0VCU2U1SHVTM01X?=
 =?utf-8?B?dTVITnhlR2lYeUsxdnM4eVd4S2NYUGhNeno5cDlwNEUzenFLL1hocFRuYTlR?=
 =?utf-8?B?SUZKVDRBTUk0WVFjVlZPTFJkZXFLVzc3aGNCWFl5VzlvRjVSVjNSNHFieG9o?=
 =?utf-8?B?bkt6T0NTUGllTWFBS1BIc282SVZBcVBvTXNUVGZPQmluVitaUlgxYXVaSVly?=
 =?utf-8?B?MzR5VWFHVFIrMk1FdFR3TVNuaWhEaEhTdU9NQ1kzUXRXMGZrY1QxRnZqcHpx?=
 =?utf-8?B?YmNRcUIvUER0VWlRS01IU2QvWHlKTVl4RnZPMzB0LzdFMERnTGxrYTI5MDd2?=
 =?utf-8?B?M1pDU05iUmY1MmFZTURBcWtQd1BxTWRDRW5Nd0RxZnpyUytxWnJIZEExcGp1?=
 =?utf-8?B?RDdXUDZ2dWEwQ3ZTUDRNemhwdEdIVmlTeXlRRnJCeHFGbWVMaXh1QStUQTlm?=
 =?utf-8?B?a3ZxWHdMUEdyQ2ZWMk9UWTdZRkxPL3FTWWFHMTFxWTNNdFF6VWFGZ2M1U09P?=
 =?utf-8?B?Sm5ZVmp6NEM0eXlrVEhraC9HYVVsdFhLZ2Z4eHQ5Nk1uN0tuV1hRMTJxRDVT?=
 =?utf-8?B?NVVwUm1FdTVoYWpOaTJRREZFbEo3MXU5cURKU2loLzBkYXAwNlNYbSt5dUY3?=
 =?utf-8?B?YUdZdEhqQUpWR2wzdUt3YUxSNGJ3RVNxWUFHRjZTaWZQbXlZZCtxc3l6dzkv?=
 =?utf-8?B?NXVGNWtSZ0xJYmZYeU81Z0VPM1VkbFozZzRQQ0Z2SndDQktnRDZNN0JuYkJQ?=
 =?utf-8?B?TU1zc2dYcWo0Tm5YMU9mMHNTQ0tRam5LSzNlamsvNjJScUR0VWIzTExSR0Va?=
 =?utf-8?B?TDh0N1NYeWhsU0p3WUhLcGlpcUd0RWM0R0prYUkwNHpQbkNOaUNjMWV1d2U4?=
 =?utf-8?B?a21QeE5yaEw2RXEwa2hzSEUwclQxNUhWeGE1V09OSVc5bWpaUDRVTzNnRTdB?=
 =?utf-8?B?RURwODVPQ1EvR0RFZEwrL3FHeW9NQjVqUVhHQ2tRWS94Qm13aVFKd2I5VjJ0?=
 =?utf-8?B?K1FwWmp3UmJzdGtyUWJlVGFydStmM0lUMVhBNTRXNmp2WkR1SEZIZnU0U0M5?=
 =?utf-8?B?djlnSnlGeHpsZlpyOTFpS0JvQ1FGRnVTTHhCVjFuMkFZR3BUYlFpdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00e866de-4992-4a61-acf4-08da2395ae89
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 12:51:41.3987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yosxLlb8Eu1wSPWk7Uwz19K4xe5Xe1Ox2dPmKXXi2J9b0PpRUS5IqyoRQs4VPzdQGRJWVEc+cSFA+K7/0PGvgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8400

On 21.04.2022 14:23, David Vrabel wrote:
> On 21/04/2022 12:38, Jan Beulich wrote:
>> On 21.04.2022 12:43, David Vrabel wrote:
>>> --- a/xen/arch/arm/setup.c
>>> +++ b/xen/arch/arm/setup.c
>>> @@ -984,6 +984,8 @@ void __init start_xen(unsigned long boot_phys_offset,
>>>   
>>>       console_init_postirq();
>>>   
>>> +    system_state = SYS_STATE_smp_boot
>>> +
>>>       do_presmp_initcalls();
>>>   
>>>       for_each_present_cpu ( i )
>>
>> I'm afraid it's not this simple: There are two
>> "ASSERT(system_state != SYS_STATE_boot)" in Arm-specific code. While
>> both could in principle be left as is, I think both want modifying to
>> ">= SYS_STATE_active", such that they would also trigger when in this
>> newly set state (in case registration of the notifiers was altered).
> 
> These asserts are already too-relaxed given that there's an early_boot 
> state.

Indeed they are. But that's not an excuse to make them ignore yet one
more state.

>> It also wants at least mentioning that setting this state is okay with
>> all uses of system_state in common code (where it's not impossible
>> that x86-isms still exist, having gone unnoticed so far), just to
>> indicate that all of these were actually inspected (there's just one
>> where it looks to be unobvious when simply looking at grep output, the
>> one in keyhandler.c). As a result this may want to be a separate,
>> prereq patch. At which point it will want considering whether to put
>> the setting of the state _in_ do_presmp_initcalls() instead of ahead
>> of its invocation.
> 
> Not sure I understand this comment. The transition to the smp_boot state 
> on arm makes the state machine on x86 and arm look _more_ alike, thus 
> common code should be happier.

I agree that it _should_, but experience tells me that such expectations
do not hold.

>>> --- a/xen/common/page_alloc.c
>>> +++ b/xen/common/page_alloc.c
>>> @@ -162,6 +162,14 @@
>>>   static char __initdata opt_badpage[100] = "";
>>>   string_param("badpage", opt_badpage);
>>>   
>>> +/*
>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>> + * enabled (except during early boot when only 1 PCPU is online).
>>> + */
>>> +#define ASSERT_ALLOC_CONTEXT()                                          \
>>> +    ASSERT(!in_irq() && (local_irq_is_enabled()                         \
>>> +                         || system_state < SYS_STATE_smp_boot))
>>
>> Upon further consideration: In principle IRQs would be okay to be off
>> whenever we're in UP mode (and hence flush IPIs don't need sending).
>> Provided of course spin debug is off as well and no other IRQs-on
>> checks get in the way (like that in flush_area_mask()). This might be
>> more robust overall than depending on system_state, but I'm not going
>> to exclude there may also be arguments against doing so.
> 
> Not sure I understand what you're suggesting here. Do you mean something 
> like this?
> 
> #define ASSERT_ALLOC_CONTEXT()                                         \
>      ASSERT(!in_irq() && (local_irq_is_enabled()                        \
>                           || nr_online_cpus == 1))

Yes, using num_online_cpus(). I'd like this to be at least considered.

>> In any event, looking back at my v1 comment, it would have been nice
>> if the spinlock related aspect was at least also mentioned here, even
>> if - as you did say in reply - the uses of the new macro aren't fully
>> redundant with check_lock().
>>
>> Also, nit: The || belongs on the earlier line as per our coding style.
> 
> CODING_STYLE says: "Long lines should be split at sensible places and 
> the trailing portions indented."
> 
> If you're going to have rules (that have, IMO[1], worse readability) 
> please document them.

Personally I, too, prefer operators at the start. But that's not how
Xen has been written, and this aspect didn't change in all the years,
no matter that ./CODING_STYLE doesn't explicitly say so (and it
doesn't state quite a few more rules that we try to abide to).

Jan

> [1] Compare
> 
> a = b
>      + dksaldksa_daskldsa_dsakdlsad
>      + hds
>      + dsadjka_jdaksjdk_daskajd;
> 
> and
> 
> a = b +
>      dksaldksa_daskldsa_dsakdlsad +
>      hds +
>      dsadjka_jdaksjdk_daskajd;
> 
> Which one is more clearly readable as a sum?
> 



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:02:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:02:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310114.526754 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWSA-00070d-2v; Thu, 21 Apr 2022 13:02:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310114.526754; Thu, 21 Apr 2022 13:02:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWS9-00070W-Vt; Thu, 21 Apr 2022 13:02:33 +0000
Received: by outflank-mailman (input) for mailman id 310114;
 Thu, 21 Apr 2022 13:02:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhWS7-00070Q-QM
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:02:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4d54fbcb-c173-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:02:30 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-FgJ1Jr3hNqyOO0yV5wbubQ-1; Thu, 21 Apr 2022 15:02:29 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBAPR04MB7271.eurprd04.prod.outlook.com (2603:10a6:10:1a6::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 13:02:28 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:02:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d54fbcb-c173-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650546150;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qa9f+bBLd9Ya+rQZ51gVN9YFWARxw6AJJLnAp9CF1mE=;
	b=gtYLn6ZurpE44ogQ/0fRcvJOtXkktRpWN14wyfZNvl0mq20T9ofDS/0t40jzThoUGaBJn7
	eO05dJzEQP0kSH1/uj8LYtq/A2T+dWeWR2O4i6lez6C695VzQRHByb29zxVkXHwCJQGx0n
	e8LDlBV2uBW/NplopL5ZyvrwyUj1g8I=
X-MC-Unique: FgJ1Jr3hNqyOO0yV5wbubQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YgvSWJPx1+7FVVTr18oWjqWN/O/EjwX9xUKfl+TQ9ac5FVops9cr5ImGWPx3tImwTrtZtvdE9JLpNxDUeCtCh2Az5VI9NAtrexvvGkwtF47AOpIMLku1odSA2J9B3aVMAZ8dUgZngf6mg+A30dIIZZpJ32jw7RQPGHBJNL+/hjVNoxIj+bMVA94/8c4rp4/pKsMMLJOQKw+vQIyn6xRJLj2JJsxx2JBSP1n0Hnzxjnwpp5Rd+HTZEKtiJANaQDdJKvduV6ohMRN0mGL73zgxsAWjLXr8Wv4LR/Ghnl5Th/pMWsLlBv6ZQx1AQv4OI3N4l9PnrjOmXRkLYMxn/0dc6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qa9f+bBLd9Ya+rQZ51gVN9YFWARxw6AJJLnAp9CF1mE=;
 b=lYi1i3GxT038jqeiKtuCUcRYWmhk5ccBn4Qp1oC4TXcK/cYHLPGYtOPW7NGqaxITFJqoMajd0bRckhWdqyik7kWgu+fwNyhMvULVEZX4uHdZy0xB1aRdhqF87JKanwcbqb1FsJnc9b6K22/JsDGmN+ZfwjvwD4fwlZ+Afeiu8aHjEXwpsUoGZUfqQ87FL9GPGewP1Y95uVC/pjMwy2oAPZNXbBOTc5l/slCaKdifFI59UGs99qFn8vL5YeDxqhvFMYM7aaLCa5SzooQbhhcRtVPHMrEPuaXbovGC18F1HDZu1duH9fFpn05pyKxTuPwuc2yBvRy9zn7ta1RO1FL3jA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <57858c7b-019a-2888-42ae-7ce9a7c88cc0@suse.com>
Date: Thu, 21 Apr 2022 15:02:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v5 1/6] x86/debugger: Remove debugger_trap_entry()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Bobby Eshleman <bobby.eshleman@gmail.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420141307.24153-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0084.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 64163717-57c3-4fb6-6cad-08da23972fd8
X-MS-TrafficTypeDiagnostic: DBAPR04MB7271:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB72712C92F079A633CF54D0D0B3F49@DBAPR04MB7271.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0jUUKGz/Y9paIaqHZbCBQA39TG5a+8otjhl64AFHbYy2H8F0kHJTUCnQvmsKjKbS2NpCaDOm5jur5pjey1zrK+Gt5LsbOMPSCV2XhWla0Ox9tkMZmhWvuxXMcgOfPnKq2IZoeQJc3+HHJsw88/Qj6mkCczVgm81pd4ad7BkEoG6L11mIjZOJmMUshYnkJ+0klZNjTi4QNMmVMaEiztF6thBXPiGpaq6Gsx/u+/y5DsmoEyzE4h7zt6FJBXuZ7RrNsdicgEQQayBxtw2CfbVXcP0ZxmROLCotQfgBSQEDE/m0piAA3YtQ4PfcKFo27xNMUmtmwZh5tV0yS/CZiD+6HDZhPR5dSi0Z+at+tEb7N3LCvDLI1+GFjxhMua0tsFmmDcC0OLlUNy1blPFRgytmIfY78RUvec1jO0SRIFMjJiFipqI4FwuJXg+ftoyU0sitcBA5veT5boJ6iYMh7gBFd3XDjzeuQkrfWVz1igMWTw0pWdtcIZVXaQvdrUwkS96zmIHJr2Nu/rucaDhrBTB4PNav10pTlIqRTWXEXgTTvPhtrFgi7wbTfXll1wOGbTUaZANAbJhVxqOYa7MU+xUIDn3OhQIZeH8W7m5ZXCax2lxxsvMLuI7OJ1MvDf8G3hqeHRwWPRMKhUf8tGOSYTs1CJvDKYefNvmcvxFJrpZQhlqZCsylBtdP2AITwTx53hS0MWZk4jJHSBlLTfBqbi7f1gR7MTOLD5sENKPAdA4YrrBJwACiyZtC1OZemcHE0Dx0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(2616005)(6486002)(186003)(508600001)(6916009)(53546011)(31686004)(36756003)(83380400001)(54906003)(86362001)(316002)(66476007)(6512007)(8676002)(4326008)(6506007)(5660300002)(4744005)(26005)(66556008)(31696002)(66946007)(8936002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UE92WFVhL3Q5WUNSMmh3SE4zczNxZWhOSFFEd0FVcHpmc1ZodjVrRnpieE02?=
 =?utf-8?B?Z3pSMVRVc3B4Q2V0TnBpc3I2M3hzSHp3d2xKaHJXamNnT21ScXBlNlVDSFNB?=
 =?utf-8?B?UEQyVWpTTkFTNjdFZzNnL1pLSDRuV3MrZEIrT0VHY2V1R1B4WFd0WXJEOWJY?=
 =?utf-8?B?RnFvaVdJWjEwaUgwV05QY1IycVhycTB3VXVxUkhJU3UyN2ROekN2MW9nVE43?=
 =?utf-8?B?YVo4QVlRMWFoMDhuTjBBZW9mZTJ2QVh4VTRxTEpmaXFNcFdobkxLL3IvOEor?=
 =?utf-8?B?UnVweVFhUWpuNlc4YkZyMGxYVysxeHFsM2NoandzYXRpUjBwRmV3WWRsOFdj?=
 =?utf-8?B?Q2t2QWc4aWd6WjRqN0VVZEplUzczalg5dk93VnFBaFhIMURSeXkyT2k0cWlw?=
 =?utf-8?B?S0JtY2JsR3BSNkl2dUZ0TVhxeDA3Z0NTMlh6R3R5MFNzMnE1VHloaHRyY05u?=
 =?utf-8?B?RnU0LzVxeERvaXBiSmlTQjNaa24wT1NVWitkK0tJZ1VLVjZBWDJwdDFQRnpM?=
 =?utf-8?B?ajRiZ2JiYWhlV0F5RWlLZ1pJQ0M1emRKVDFabXRnTFNITlFBQW1kc2dWRDVV?=
 =?utf-8?B?OGZRNG0xVWNEck5ieUNISC9KQWNHbUYxY084S1RuVG1FQ0kwVW9TL3VYTEkx?=
 =?utf-8?B?WEhiWks2WnlaTnE4OHNmMXZyVEpwdE95cWVBTG0zS0RuZGRjMEh2NVpMTTNO?=
 =?utf-8?B?RmZUcmw3OHRSaThuRDlFOGFmVUNzYyt5aFNERC84UGMwdnpMejQxS0xzaSs1?=
 =?utf-8?B?RFZvVElEcmkyZWJYcm45SGt3ZlVPY3VuUzM4Y2lob0ZnK0djdUQ3Uy9YekFl?=
 =?utf-8?B?bkt4RHNUVEhuYlVESVZSRDVtOVI0emYzMHBkWnNLM05ZRkVwZXBCOGRnQjY3?=
 =?utf-8?B?U1VZWlpCdGhITzRjZDBvVHFyUGxwQ21sN3JLZ2RaQnlXajR3Sms0WU1FQ0Fx?=
 =?utf-8?B?RG5BOXlLZlNTTW00RHVFd0E5VkxRa0pKeWtSVkF1MU1NNjFnWlpuelhQbnMz?=
 =?utf-8?B?eGRPN0o1cjVtaXlMZERlWUQ1MUFhUFE0Mm9UZlhyRGFVa0ovaWd1V1lKZ3pH?=
 =?utf-8?B?eVdMV3hmSmRyc2l4UlRTZFJPTHd0STB2RXBWaGpEV3VHVW5wNkFGd0k1aEth?=
 =?utf-8?B?QjZoaXc4VmQ2Nk40Q2NvcXZKWGoxZkVPWENMQ3BYMW90WjNsa0VOUVdKQWJt?=
 =?utf-8?B?SWFJT3hXSjFmV1VnengzbTliMHQ1MHcvSlU3YThVL3hkbHFtZXNiUHRDdXp3?=
 =?utf-8?B?U2kwRDlOU3cxMndZaFNSWG5sUlhsWjRMYjB4M203YnQ4TUI4VitzRlQ1aHQz?=
 =?utf-8?B?VUpkUEd2eVpmcjJLTU55WlJjKzJZTlphRUs3Q2VNWWgzaXdZbitkMVdNYm1i?=
 =?utf-8?B?eFdCSW1STGptTHYveFNsTDVRcUgxTXdFNnp0L0x0MUZhZGFXdVJEbzNCSkhZ?=
 =?utf-8?B?emg3c002WlB6RFQ0bFRCa3hVWXN4eGZEVlBvcjNaOWlpWkRQenY4RTdZNEFU?=
 =?utf-8?B?VTVocm5ualhjSDZ5QUdtdGx3UjJ3YjV5bDUrZW4vY0xwQ2FmVkw4TFZqTExE?=
 =?utf-8?B?aE9FS0VvM3NlRVJzREJZMlJGWC8zejZyUFFKd0ZmR0ZLUWdMd1gvTkdESnM0?=
 =?utf-8?B?VTdoRXN6SkNuMUZiei81ME82VmdwRm1GQWxPOWh0MzQ0ZHBHYVhKTlpBR0tQ?=
 =?utf-8?B?Ujc4Q1BWWFpvN2RhNC9TSFlxR1FJZC91Y0U0T0lHeFhOeWhjZE1IL1MwZWF2?=
 =?utf-8?B?QUQwT1pnRldzMGxmRm41Qi9OTnFVSzY0aHM1alVFbVhuanRHMUlEUHNjbWtD?=
 =?utf-8?B?TFcza2xWZFlJSTA2QUtWZFpzY0N1SjJQNXk4Y0NCbjRpalRkLzU4WjRJRU5q?=
 =?utf-8?B?d0JuemYrSVBlN1I2ZUtYS0Zia2l5dVlxc1NhMWFHMXFPTXdnR2prMTN5NmlD?=
 =?utf-8?B?QmpGaU0yMDlJV0dQSkhsZHFTUHdGYy9FRnhUOVVoZXM5SWkvK0Z5R0JnZWxE?=
 =?utf-8?B?MDZzbE11cXI5TStvbml1NzVNOWV4MUxVRGhyMEwzTG1IajNMTk41RVNJdG1P?=
 =?utf-8?B?U0g1Wjg5KzdqeUM3TXU3TFB1bFJwSTd4UHpLUSs4ZlVlcWU1UmZoV1Aya29a?=
 =?utf-8?B?ZW5uK01nK29lT1BwYmo1UnpNYkVEbFJld0VTbEVsM3JYaTJXNnMzejQ3Sk82?=
 =?utf-8?B?bnhZNU5YVWNpZmpJRThvR0lQQzNScno5UHlyTDB1c3JzNWh5OWN3MlRwUUxH?=
 =?utf-8?B?VElNdm5vd096VENOYmJEMmdLOXZEMnBBSTVnbmFiKzB0TXA0RzhlV1llT1lJ?=
 =?utf-8?B?ZlJqbzJFbTBiNTMzYWRsMjEvdDhBWmFPQW5xRDBiWUV1K0lmQythdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64163717-57c3-4fb6-6cad-08da23972fd8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:02:27.7967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pnkrslAJ2JUBSa4Yc0MOxk0l7zaHzDFV5GVfrINJGkva7yj2p00pSN3N0Lr3d2grO1DS69DsJE/XKeFLsOPrlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7271

On 20.04.2022 16:13, Andrew Cooper wrote:
> From: Bobby Eshleman <bobby.eshleman@gmail.com>
> 
> debugger_trap_entry() is unrelated to the other contents of debugger.h.  It is
> a no-op for everything other than #DB/#BP, and for those it invokes guest
> debugging (CONFIG_GDBSX) not host debugging (CONFIG_CRASH_DEBUG).
> 
> Furthermore, the description of how to use debugger_trap_entry() is at best,
> stale.  It is not called from all exception paths,

But on almost all (before this change) - the exception looks to be
#NM.

> and because the developer
> is forced to modify Xen to perform debugging, editing debugger_trap_entry() is
> not the way one would efficiently go about diagnosing the problem.

Shouldn't it be the remote end to request which exceptions it wants
to be notified of? If so, removing the hook invocation isn't very
helpful.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:06:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:06:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310120.526764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWVj-0007jZ-Mf; Thu, 21 Apr 2022 13:06:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310120.526764; Thu, 21 Apr 2022 13:06:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWVj-0007jS-Jg; Thu, 21 Apr 2022 13:06:15 +0000
Received: by outflank-mailman (input) for mailman id 310120;
 Thu, 21 Apr 2022 13:06:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=q+Sl=U7=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhWVi-0007jM-Bz
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:06:14 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd4b68f9-c173-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 15:06:07 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650546355808163.4948971852707;
 Thu, 21 Apr 2022 06:05:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd4b68f9-c173-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1650546360; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=iNR309RMOVWsH9WkQTG/IwOQEQdD978RWan+qjaSqprr2tqsdFdboxVDRp48J48uhZk03KcvOgBdpRV1epRRoew0Cl0EMVC41WppY0Ok5Te5RJmDZFDAnXAFuFfdl0kdWT4qsO50sownRahffl63R9u66Qs8NYEn/0B91npHC7s=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650546360; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=3LnXM9dW4GS8TCA+EPE0xJooNdtkTKgPxEbjJ/TcOyg=; 
	b=WnuigCRO15jxKDJF8sMVJdyivSAuMVcnLlic2hxEjtManonS9eJmPTuEiWYEj79X0HSLASwFDPh63mzh27zjpmUOYJC5ZZ2Sqwh45fL0YPGE9NDtfHeco73g8lxAKkTOYk7djWA40THqr8pROKcpRWaAAXF2Zaj/fC1u/EZxK0g=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650546360;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=3LnXM9dW4GS8TCA+EPE0xJooNdtkTKgPxEbjJ/TcOyg=;
	b=kQ8d4rpp1Ef6N+HKzNS0mV8sUMBG5mzz5vCzKGafPfEqBO5xxOmeyqzUXkUAprk2
	mcT4F93jgtsAzW6xla0Mvp8MDsROtyZ31WYtAPV4gT2IzKEP5GPc7Us2FqPhhlFG8uo
	oSNSP4nXYdlLsA8FHloB/6Rks43IE/+5e9itN/Ig=
Message-ID: <4c724c6e-c140-0b2e-6268-6db4c5958b9a@apertussolutions.com>
Date: Thu, 21 Apr 2022 09:05:12 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] xsm: create idle domain privieged and demote after
 setup
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
 <20220420222834.5478-2-dpsmith@apertussolutions.com>
 <256567d3-8d0b-83ea-c3d6-215f0a1483b6@suse.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
In-Reply-To: <256567d3-8d0b-83ea-c3d6-215f0a1483b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/21/22 05:20, Jan Beulich wrote:
> On 21.04.2022 00:28, Daniel P. Smith wrote:
>> There are now instances where internal hypervisor logic needs to make resource
>> allocation calls that are protectd by XSM checks. The internal hypervisor logic
>> is represented a number of system domains which by designed are represented by
>> non-privileged struct domain instances. To enable these logic blocks to
>> function correctly but in a controlled manner, this commit changes the idle
>> domain to be created as a privileged domain under the default policy, which is
>> inherited by the SILO policy, and demoted before transitioning to running. A
>> new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
>> type to demote the idle domain appropriately for that policy type.
>>
>> For flask a stub is added to ensure that flask policy system will function
>> correctly with this patch until flask is extended with support for starting the
>> idle domain privileged and properly demoting it on the call to
>> xsm_transtion_running.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> 
> Looks okay to me, but I'm not sure in how far agreement was reached on
> taking this route. Just one nit:

Thank you. As for the approach, Jason suggested it and Roger stated that
if this approach was adopted it would resolve his concerns over __init.
If you have a concern with this approach, please let me know so I can
ensure it is addressed to the best of my ability.

>> --- a/xen/include/xsm/dummy.h
>> +++ b/xen/include/xsm/dummy.h
>> @@ -101,6 +101,18 @@ static always_inline int xsm_default_action(
>>      }
>>  }
>>  
>> +static XSM_INLINE void cf_check xsm_transition_running(void)
>> +{
>> +    struct domain *d = current->domain;
>> +
>> +    if ( d->domain_id != DOMID_IDLE )
>> +        panic("xsm_transition_running should only be called by idle domain\n");
>> +
>> +    d->is_privileged = false;
>> +
>> +    return;
>> +}
> 
> Please omit such return statements.

Ack.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:06:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:06:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310122.526776 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWW2-00087g-V5; Thu, 21 Apr 2022 13:06:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310122.526776; Thu, 21 Apr 2022 13:06:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWW2-00087Z-Rx; Thu, 21 Apr 2022 13:06:34 +0000
Received: by outflank-mailman (input) for mailman id 310122;
 Thu, 21 Apr 2022 13:06:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhWW1-00085i-DJ
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:06:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dd6b8d35-c173-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:06:32 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-5bx8AzauO_eP1lO0rQkAFQ-2; Thu, 21 Apr 2022 15:06:30 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3389.eurprd04.prod.outlook.com (2603:10a6:803:b::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 13:06:28 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:06:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd6b8d35-c173-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650546392;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tepNA3z5icaKcddPsneOrUEpl8pzhfueXNqcqLddl+k=;
	b=X1O9w77Jd65k51Qcoy7hIwZMwfjy0HysqPg+S4T1qsj9Km9F4+wKMeeJhER5RW7q+a7sOD
	Z0eQmiNRyNcSMbBLXrH8/hr1PvmJq4NwLDHZlXHfQyDxrUGLdvOVb5ISAdhGrKQuKaVt8S
	epoCy+wBnFQnF94SSv3CE7/zR803SlA=
X-MC-Unique: 5bx8AzauO_eP1lO0rQkAFQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jFFkGIwjWLefrBmOqaF4fvC3XrWWJisSKepofYaqWCBXXnDk929EKg4Ks2IvWyG9Em4zrBVT/1q3csRc0sVJUG/cteRt82rLkKdNao2/p7iiBAmSmA+RJxXUOEoavubiT7PY/jALKy/xQzfrpbh1J3hnZKko2zLhih+vIjLgE5zV08VyGoFr995RGRmfryonrWz67yJqVDxoGJG1iiCn5jW/gqwF58z6dVe1WGC8cWK1e9vBOmdyL1vTeP0xWWBti4GLbIxlRFEOO3xDWOF7fCivGvt2YPXkxqkugrwMQDqpMyRElhTuRzFecaFlpxL9V8J+IsYXKRhvzCBfYtc6iA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tepNA3z5icaKcddPsneOrUEpl8pzhfueXNqcqLddl+k=;
 b=W1bzwVT6/V0iv0lnop5ko7MtH+JXsoWxMoJXdqkmnNSxiAUiiSUsaa+ceIJ1ugARnjtcdGdTYiWH2pHz/W3vlvNTP00ZpzAMGvZw2IBNfC6dmrIiqjb9Jt08kx9tFZO8lfsay2IqSmAVmDtkSRGzClZt2qwCwcUnlkrXuxZxRZxmNyc5XTnCykZNVeBpiexQ88vPeO5QXZUp0QKgJ6ylfE12o3hJNN4zneoAqE+S9L2JelpvfbqQt9LZlmJXT734PlMxvlQK6iAeDWme7lNOpc9TQx/eioyjb+XlB4iNtZ/COK+kSz/uongeMOiBZbvhVF5BIDmlhMBGyazc6NhWxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bb1961c1-af89-0220-6328-aa8cb98a1d84@suse.com>
Date: Thu, 21 Apr 2022 15:06:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Bobby Eshleman <bobby.eshleman@gmail.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420141307.24153-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0006.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::32) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 05f8d24f-f0bd-41dd-b090-08da2397bf5c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3389:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB338957F2F8D87851B059EEACB3F49@VI1PR0402MB3389.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	se7dHIYLkp/D3KM8w7+a7uo1UjAw+h/sCjY5Oi4HdKSGj/I7ScwuPWfVZ2WtH8sRgSq7WE3c2RbRT3+C/7KwRl8tjrJUupYJFoEB9IId7EX8OfWAs65tcxUe9zbTKPKk3Wl7JLjmZLNjM+vG3l7WF8unfI2y/rF5pSrlPma53XmqHbBxssQAiyS0Q1/acpSV/HAxr841QCelxplTSpNHq7+Xhs94O70f0d/L4/XCxfD3M7gDEZ7P+dku6DPVmM9ONaQZuAdewaiUNf/NszTS30RHdxNgfP3aqOr6Itn6vXUZGHQYJDKU3TaMlZ3btGaw4KF9Qh13r8G1Mg+d2xmVkim7C6//3VwenwRqBMSoNnBj1c/5vjZykihUJdEWMleq5j6utj5P58sGwBSpTMwdHwMK6XM16EViaC1M8P1HYU+GX1jsFVvnVKI8kfal+mmwRO8Ob8fpfgSfQ6udDY2bOXfQUyGWp0S5EqMfh0PO2i8JxTpWwe8MEuvbU/xXFyBklgtWM2q9FTeKRaCvevppT/G7mSR+Rsv9ztsovu3sBYiWG4H++KlIGkQ+5rGMShXNONYCkopmBZOGk1BatqAgvg+41osBh/9FsR968I8hTXFR2D+JFcNkAMVn68mx7Zap56rpaIkaJuX9mr58UaxZEsa/PC/v+hWmktcbhojXoH1zlWFBH8RMCKh3HTILS54LSpgA6tvtOaweb5Uo2qkU1I52zrXyF4DwnZRdpVB1Ea3eHJvk2UZj0Esos7TimvuT
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(31696002)(86362001)(6512007)(26005)(6916009)(53546011)(54906003)(316002)(6506007)(508600001)(6486002)(38100700002)(186003)(66946007)(66556008)(66476007)(36756003)(2906002)(4744005)(31686004)(5660300002)(4326008)(8676002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QnJRSU4rQndJakJiM0dxUWdMQWcvU3RNRWhXZndDdHlObThWazh6MVNkeDlN?=
 =?utf-8?B?RU1uWFpwQ3VWTVQrZmJoNTE2Q3M4aDJGWC9GNGsyVC9tc282UVR5MVNUQm5j?=
 =?utf-8?B?WmQ2Rmh4enpXNnNYWlRML2xaTFV1TGozVGVXQ3NPSFZsNFdUaWR5eE1rSm1U?=
 =?utf-8?B?SGcwdFZMRGV6RE5keDdOV0M3bkx5Z2hqc0hwUWFFeUd3ZjFaR3lid3RsM1Fr?=
 =?utf-8?B?emZOeWFuZXM0NTdOYUtMTHFzeU5VS3JlTkNPakczYUM5UlAwSElYWkU4VEkz?=
 =?utf-8?B?d2N1b0tuSjZjTnhXVjI2ZFlWK1BUUFNwaUZLNzhTbis3dmxnQ0hiKzRJTjJQ?=
 =?utf-8?B?V0hNR1RWUnVpR2p3UnBVMnRBd0JYaWpFVkF3Q0FaV3dBUlJKUmxUOXNXK3Mz?=
 =?utf-8?B?Z3JMK0JackpVUE1LTFhURzVQdUwwRmhONzlWMllERFdGNnNHSHp6T0QwOEhu?=
 =?utf-8?B?L3dWK0RIaUVIUzdidHdXL2w5U0M0aFVNYnl3b0I1YXFpUkM3L2RaUlFVVFdV?=
 =?utf-8?B?WTNXYnhINU5IMmhqWjNtZkdqMmlkQ0NlNks4MG9RYkc5RW8zUnhJSStDRDgy?=
 =?utf-8?B?MGo1aTEzOVFwbUgzMkQzbjAvWDdoUE4wd0FpVVptMGhleUhsdW52N084eDZ1?=
 =?utf-8?B?ZFZUZVQ4SG1JQTlRN2lVZWRrbG1HQ25FVVVQZmY4NDNOYWUrTkRTSTU1RUVD?=
 =?utf-8?B?cU51cFBDaGdPeW9oRWJlcGpRNC9CdXd6b2Z5U0s0Y01zSFJKVTk3aDZpZkxG?=
 =?utf-8?B?eGVtb1JLQS8vbW4weWc2Z0NQcDdNU2p3UEZLU1BJbHAzaVZpVVBDbTFoWDlo?=
 =?utf-8?B?UXZGUDNjQ28rZTVIbHU1SXUxUTVQNE04MURXcDBxZFZmTFJBaklyTllSVWw5?=
 =?utf-8?B?L0JINmhTNVNuVHJUWFI0Z3BjR1AzMlJZYVorcmZDaU9nRm0xUnlTNUlCcVgv?=
 =?utf-8?B?dFp6MGVxaklYUmdjTEpwbGsxREMvR1pGbVNjWER5Mnc2Zm9OS0NBWk40bEp4?=
 =?utf-8?B?YjZ6TWp5RXlHM2hWQWFIVnRYdyt2UnptNFZhWTV3azRKaU5sdk5yN3VBbExr?=
 =?utf-8?B?VWJoVVFsQ1liL2RqUkgxY1F4ckJUM3d6OWJjblI0b3RmN3ZWR0xlRkExbElL?=
 =?utf-8?B?WUUxS1JpV3hmMVNwQUYvVFVlVm11VTBneHdabGFnQ2dDODdMbEFoKzd6dHJu?=
 =?utf-8?B?a2NxeTRXc09sZmtFcUU2MHJWbmtMSkFIcm1oY3dGM0xlWk8xT0pDTW1jck1r?=
 =?utf-8?B?U2ZUQlR1Z256Sk9lOHBFYUh1ZWRySXhML0R2dnA2dTNvR3FvS0hIbWRSQlRj?=
 =?utf-8?B?cm1iKzJwc2xFcEFLRCtNTmw3MUtFVkUxaEhuV1RiUVNCWVZ3V0hWY3c4YkRi?=
 =?utf-8?B?UUJmRjR5UnVOWFJFOXR3MnplNFZhNGt6NzhxTVNtWkVhWkxwZktaZUZyUTlW?=
 =?utf-8?B?OTBWUklWQm1nYmtyR01jM2dyc2hiYmFnWEsvZ2NGVTE5Rk9Vdm82a25HWkxB?=
 =?utf-8?B?VnRGS3ZnNk0yZEhEQUV4VEFVcE8rWWFhUUFuSVpXc29pZjl4SGFWc3FDTTBi?=
 =?utf-8?B?VGt1NUNtN284WEFRb1RyVkxlYkwrRWNPTGtlSncxSjhqZGVQNzRqY1lDZ1Fp?=
 =?utf-8?B?KzhLbFpleEVlRFRRVlQ4eXp4SkdnSTF3V0ZMRXlTbDRGUkZhWUp0U1BUemgx?=
 =?utf-8?B?R1dLSmk2V3BMQWJUdDhJbTc5RVIzTDZpbnVhVWF2OGJKWExXczk2MGkxcSs1?=
 =?utf-8?B?UGZHdkJyY3htaktTbWY3ZzY4VjF0Vk4rck96QkovamRLUlc2RVhKYUNlY0dw?=
 =?utf-8?B?UlhJcHlEa0Naalk1am1tZFJNWmFaQXFwZWtoLzVvcU1JRSs2V2tsNzhHamhq?=
 =?utf-8?B?TlU3ZmFUejdzNmFFUHNWRWpPM2ROWi9KaUtVMTF6TUErKzA5M0NYWUVDSEw0?=
 =?utf-8?B?MDBQcktHQ09rZ1ZqK0lBbkxzS2I4MUlhRmhTRzkzS0hsSUlybW83VzJkZUh1?=
 =?utf-8?B?T2FUQlNqbWZ0V29hSUl1YVMycXJPMTZuSk1aQjkzcUlHODBTYnluUk5XZjNP?=
 =?utf-8?B?Z2M2VmJWdVVWdEk3WGdnQkRSaUk0WklUMHVuU1dxODFIY3FQM2RBRXhFQWth?=
 =?utf-8?B?Vm9KQ1NxQ2crOStUT1J3bVl2M0ZRNk9BdUVBQXRNdFpTV3gzQmNaWndPRmlR?=
 =?utf-8?B?NmhBN3h1KzNpek5oa2dqMjF4L0trMHVMZTJOWE4yTnlnTkUydkNQQlRPbFVZ?=
 =?utf-8?B?ZHVzMUJQeWZEemc4NFBSOGxDV0Job25BZTQ1RHNVeXczZkRGTGVlQlpZMmdD?=
 =?utf-8?B?ZHUwc29VZEVpRVY2cGptRllJNkxCMEJGZURONm9pVTdRQ1VYOGlaUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05f8d24f-f0bd-41dd-b090-08da2397bf5c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:06:28.5621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HyUf7EqfeevUyDXaGKBFVJdfXpWBI5QTIwqQh9ahWd23u0vipAGctgSpDSl9FjRZ9f6Fd9uxx/DYnZAsjoAr8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3389

On 20.04.2022 16:13, Andrew Cooper wrote:
> From: Bobby Eshleman <bobby.eshleman@gmail.com>
> 
> debug.c contains only dbg_rw_mem().  Rename it to gdbsx.c.
> 
> Move gdbsx_guest_mem_io(), and the prior setup of iop->remain, from domctl.c
> to gdbsx.c, merging it with dbg_rw_mem().
> 
> Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> The semantics are rather broken.  XEN_DOMCTL_gdbsx_guestmemio only sets
> copyback when there's nothing to copy back, and skips copying back in the
> -EFAULT case when the iop->remain field is relevant.  Furthermore, it can be
> asked to move up to 4GB in one go, with no continuability whatsoever.

The last point perhaps isn't overly much of a problem for this specific
operation.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:08:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:08:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310130.526787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWXc-0000RS-Ah; Thu, 21 Apr 2022 13:08:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310130.526787; Thu, 21 Apr 2022 13:08:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWXc-0000RL-6k; Thu, 21 Apr 2022 13:08:12 +0000
Received: by outflank-mailman (input) for mailman id 310130;
 Thu, 21 Apr 2022 13:08:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhWXa-0000RD-GE
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:08:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 17585d02-c174-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:08:09 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-IkyQrpd3MTmfzf9aqEGO8g-1; Thu, 21 Apr 2022 15:08:07 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB8893.eurprd04.prod.outlook.com (2603:10a6:102:20c::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 13:08:06 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:08:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17585d02-c174-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650546489;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m3Ll8XXoAgebmEaBxUAzSYZ46MdXqYrYM0ejhfGT9/4=;
	b=O9dskZ76lkpaH9yoQ+T5vTMWEwKnsK7n5Efn+Y2cmdnlwM39FnfKQUm1wnvDckxEad4+mJ
	OVQQNA6QYRn+0qpMace+syJgMCjqHXFSStXa66cuEuz/oVMI2kMVRIBrK/6U2ZZTG2j0H2
	Uy3yUXSMhb0goBIzrT18mqnPcew+AC4=
X-MC-Unique: IkyQrpd3MTmfzf9aqEGO8g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F8YyXXiDs1vFLJcMC4rI2Fub7Ly9HcwnxcUGd4jZLDoNpax3Mm4QQHLouv4OrBKf5DO+VzXLhs/pqUQe7CuuYw5NyTYMs8GdesT7ID0PEXNewT5FkyjaOXBo914bz7CySJX2ts53A/BxMPl2n9DjRl4/0+tjwPdQqwaT+Rv9N1XMEnTn2Hsb5KOMOX7rChKnvwXj9u9sYGjHLT7cmo9CoJbeEzm8GwsTXr4vfj8H1WZdTCvOamNhWLRFxPVgyYwbN4v8F6yn+E1V/3MOv16HRrFtvFSkkFINm/oA+4T+d9GX/SEvypHHKFRIMQug+tAYJYIpZ4SiSYeUgTHUM4Qw9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m3Ll8XXoAgebmEaBxUAzSYZ46MdXqYrYM0ejhfGT9/4=;
 b=ghaNz59EDWKuutuHuofg/VrGnPvk5o6XfAySzyI7D+dLFm5Tq34ltlASWGhnpg+YRUKn2W971m7uPR3NycX95ndILPbAOS9pIyLmaXTkprwSB+Zd/rAUv5SSkk0A6EPBhkou0YTRG+3PRU0kwGshQ3uIyQAgLzuHHrvdlzwWL5trEQhSk1Y0xnf8LuPzvwhBxLEfv1QAqmuXamzfOd8WtseCruor+uqNMBy0CspuS8xvrBnu7/KmKABbbmlOKxlrm1gjpnApRRWFHVrj3raxxCsEebsuich5dz1dO5iDemqQXpLPQK+qRO3/9FC8BOrj/H4CaYTn3NhzxQRRvAb6Pw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <acb6c1d3-7270-f651-4a8c-86b8c089075b@suse.com>
Date: Thu, 21 Apr 2022 15:08:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v5 3/6] x86/gdbsx: Move domain_pause_for_debugger() into
 gdbsx
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-4-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420141307.24153-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0022.eurprd03.prod.outlook.com
 (2603:10a6:206:14::35) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c1387474-a193-4ea4-b94d-08da2397f98b
X-MS-TrafficTypeDiagnostic: PAXPR04MB8893:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB889383CDCBF7BA45EB90770CB3F49@PAXPR04MB8893.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PYvh0NcyHBBu8Jbep42QIrpL2jFQTYgZWZ/u4zibtZwnE9cQLNsyEEZGn8UVypmTQQTjI2Gs+43l9l+SKQjVc7xb8r0wNLqejozG1K20I09d3N+5i7iVcs6RX4NyAJvcUKCBgcIz+t98P3c7z0b4uMUPsce0I0vLokHPZvpUxFSeB/VQ2loRiF2h6hi/EfnZWtW/vwvK1wLn40E+dIS8mRC2Co8++19IQB/VS4AO80rKXV54Wm0+MGj0ecdXfpRwLNijjNTHONOix1YI0+u0+djVF5Dkt6gYG5ioinkzoiQONJyKp1hLU8AIH0/wulHUf13DM7qZ/TnlArxQQcBZcxBkeHeyYHl6OhpY3lisiMey2NYHKisS0puR8yI6R3b5CX7gDvDgdr5kPO1r+RidEStoEbNxpXQE/pkDgsbiDzMGUJabtIsQn53NtfP5EmXgha0AeE0YnS+1Lod7RRSiucdZceJz8S0mt1jGDFPAUzEkycXNk8+8PMiIAqzy4I2BAK4QmVCVc11S7emzB/f5rZ/IPmrP24Z+gABRv+Hlu2pnT4mnZvNZdZfhY73r+ti8mpVpKfrSJObcAupruNlpy75ZljZG5h6155b/X7oj7tlywKBQjn2TMSmlXmRY2wK8ecIeeuYMZnhrklBQyBnSmi/6AWafNhhN0UBZCE0v6B3WiHoTNdhNz5X9eyGWSmn+2Vfma/tJuBgWFyRs9AP+lw0F6pS3QOpYdzkX3o+Ybxz/agOLCJzu2lA3JlW0ZRL9iOTBT8iWWcOdBtaJQDhvew==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(31686004)(2906002)(2616005)(26005)(4744005)(6512007)(36756003)(8936002)(5660300002)(86362001)(31696002)(38100700002)(8676002)(4326008)(6486002)(66556008)(66946007)(66476007)(53546011)(508600001)(316002)(6916009)(54906003)(6506007)(17423001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NHJvR1llc2hJYlBPRjB3ZGljSXVVWUhTT2FIK1MvUXpweStGa295ZkNDa0V2?=
 =?utf-8?B?KzZKRUliZER3U2dLYWVNN2QvaFljMHlVZjFrZWllOXE3alZEVVkyMmZKNGhS?=
 =?utf-8?B?UTMvVUFrQ0FEdWoxU09jUGluM2dzSjJrS28rRVRFSXZzaGlmRm5XVFNQUWpK?=
 =?utf-8?B?NUFrNWdJakZQL3FtSFdnNEwyVEtOVFZpcEEzZm9IZTlNRU5hUGZ4N25wODA1?=
 =?utf-8?B?WTRsaG1ucG1iZlZ2MGZDZFRNVk1KZnF2K1JYY3pyQi8yVkVNbnVHY3YrY2wz?=
 =?utf-8?B?NFZ1a2l2YlNQekVseGlzWVQwejRGZlVNOXNyOUFNSmJScU9VQ0hrenN1eG50?=
 =?utf-8?B?YkNDMDlzejQ5YXIyMDQzZ25odGhrQUdBZHlTZm9KSGVwVnJ0Rlk4U0pIRVN0?=
 =?utf-8?B?MGoxanJqUEIxeVBUR3ZkRjRuR0t6OS9oa0g2b212NWc5bFBETU5IbzM4eTZh?=
 =?utf-8?B?QUlUQWFkZm5TYmkwUW5CMzU1cEgxbkJrZitnOERveWk2ODJ2VkdRSllBS1NK?=
 =?utf-8?B?WkhPd1NFTlFnWnRmOU00NFY2RDcxOUZKUGFtbFNuaDQxczR2ZzlTR3FpWXVB?=
 =?utf-8?B?Vm1yelMybXpoOWk0QWg1ZnA0b2R1ZlRTOUlaNnIvWVAvRHpCMHZ6YWlIbDRt?=
 =?utf-8?B?Witxb0Z2NVN3ZzNFeVpwZ0U0dnY5Um54U25KZFdKWlRPR1hxYk9UZmx5S2Ni?=
 =?utf-8?B?NmxzZXhOY0p4RURnQzVqL2lLMzVpZ2NMY2ZpR01kOWZHdWtaWjM4SU1BR0tI?=
 =?utf-8?B?OVhNVDdaSGd6MmtJQkJYLzF5RmpNa0xidXlXSnZuR0Y1Q0hOWUxsTHhmSmlJ?=
 =?utf-8?B?NVRidFRieVlaWGpWOXFNZTduM2s0eWVmSXRUV0toZURjakE1YmdWNE5VanBi?=
 =?utf-8?B?VUpzLysreEFRWWkzUW5NNzcxNERpU2l3YnZxR0NIbStPcFhmUFhlVWJ2Vmxi?=
 =?utf-8?B?dDVrYWEvQkl2TTMzb2M3T3dWckpzRE1RN2J5Rnp2TGp4TysxaEtNcEhDdFRp?=
 =?utf-8?B?VE9ZNGpXY2tnWXkycFlvdDVGUmhaUGpCM0VWemNWWWcyZEJiWGF1RXJMR05E?=
 =?utf-8?B?WXczQ1A3QlA1ZFNxanZKaFQ1dkl2cDdybHFOemRCUWozUnplMnVIclVXUHJE?=
 =?utf-8?B?aisxUE11OWpCNzZOTDFzR2dBOFJUcytUaWRPcFZnWHJsbGxrcGxtQXV6V1hm?=
 =?utf-8?B?NWdoTXhhcy96STR3cHFSZFJmYXZaNHNsc1VQbWhVeVRVbXBQUHJ0UzhHdmtC?=
 =?utf-8?B?dkEzZHNPNG1UWWZ2NTVYSDZiOWVPM0tRa1hOZHcwOWVhRlNXTmtrRjJKUnRz?=
 =?utf-8?B?a2dRK1FIeWxnRWNDR1R5Z29UU2l5WkdLZnI3RTc1WkVCcFRyTndZdFdSaVVh?=
 =?utf-8?B?Zno4VWcxbkxRa0NtMVNPbHpGYVc2UWZ6emlWTXFpYW12emxkbm5ESmhaRHk0?=
 =?utf-8?B?dGJ4UXU2VUoyNG5CandIRHBPeXNCMzJlWW1FZTBFZ2VVWHFUNFluWVdCdlRK?=
 =?utf-8?B?dVV3NWlVcTdDNUp6dU1kOWxCcGtkWWdkQW1vLzdjQjZrZy9rYi9STlRVVDBs?=
 =?utf-8?B?bDhka2dLamhraXJWWnpNemlpaUNOL1dTekRNa3F3dXFuWVJ4a2ZpQUZjTmtt?=
 =?utf-8?B?NUcwSDRHMlp6UnpnQVA3QnVXVG1wd0YxY2lkOEp1LzNZemxzU1lkMmhlNEZa?=
 =?utf-8?B?b3NoTVB1Y1praHpMNXNnVDFLVXNvWm9lNnZlVWtKcXJVd0huU2lBaWVSWUN6?=
 =?utf-8?B?QkUvNFA4RnFsdnZ6Rm41REJLYjJCcWdnTjdJaUhZc0Z3ZHh0QW1RMHM4NTd4?=
 =?utf-8?B?VjkxcTJYaUlwdVdkdmtsMXMyaStpR3V0NWxoOXRxOEJFY0xjMmtuOGpyM0hz?=
 =?utf-8?B?ZXJlV2lPY1RIaFAyOFpiQitUSGZOeVdvdUJGRGhvalZzcUJmanRTT2VsQ1NB?=
 =?utf-8?B?aUEvNGR2N2NpVm5uZWtub1lBUEMxVEErTnl4cy9qVzJaditIQ0ZNZnNvSy9X?=
 =?utf-8?B?UWtVRHpwRmhJOVM2b3hweS8xQW41RHJzV2tWNmdDRG9QajE5R2xJMXRlb1Vz?=
 =?utf-8?B?Qk42a0tVWWd2SnVyR291allNN0dqWXFTS3o2QzVWSGFWY2MvTTIyNkdidnRn?=
 =?utf-8?B?dUxJU2EvRTdYQWpZNUF0eDVVdXMyS05hQXR2TGJwZnFRZmJxOVl6Mk5YNElT?=
 =?utf-8?B?ZVVGaU1uS3pvL2RqSVVEckl5ZTBtNUYwYnZpaXdiVjRIRHJpd2kxZmo1aDRa?=
 =?utf-8?B?QXVTc0duV2ROQUtjcHpZbk9ONlA1Q3loYlhrYldGSDZaUXo0d0gybjFETTJL?=
 =?utf-8?B?ZXd4SlV6WkFHNlBjc2dFUEFOVzJmL2pNVXdyaVpYTHE4cklJeEJPUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1387474-a193-4ea4-b94d-08da2397f98b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:08:06.1950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6fG4I/9aSkCcXO+BjymVrfZbFWP/FxpEx5JiMsoaVnpyZEhRCGHlROFfeZbnbztoKajVHrI4p7mr7/jblIH8Qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8893

On 20.04.2022 16:13, Andrew Cooper wrote:
> domain_pause_for_debugger() is guest debugging (CONFIG_GDBSX) not host
> debugging (CONFIG_CRASH_DEBUG).
> 
> Move it into the new gdbsx.c to drop the (incorrect) ifdefary, and provide a
> static inline in the !CONFIG_GDBSX case so callers can optimise away
> everything rather than having to emit a call to an empty function.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:09:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:09:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310134.526797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWYV-00010T-Ji; Thu, 21 Apr 2022 13:09:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310134.526797; Thu, 21 Apr 2022 13:09:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWYV-00010M-Gr; Thu, 21 Apr 2022 13:09:07 +0000
Received: by outflank-mailman (input) for mailman id 310134;
 Thu, 21 Apr 2022 13:09:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhWYU-00010C-9n
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:09:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 38a622b8-c174-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:09:05 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-lc5rgDzEPnStbxomq-J9Tg-1; Thu, 21 Apr 2022 15:09:04 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8693.eurprd04.prod.outlook.com (2603:10a6:10:2dc::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 13:09:02 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:09:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38a622b8-c174-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650546545;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i62EqEUg1FfwSh0GvIbYWih43SAiLcTQYBloPkznT2E=;
	b=EcNOUcFty281qBIMl+Pa0wKGg9MCt2e+7F0Dhc13eOUlbtwybyNmcmlf4tj3zqGbzw0scL
	++xw6cHjZvb/amecKNb5JHxwhhuUwwkU28Ls7ZOUhOYHHa2JuTMH5ZiK/u+4Lnu+5GxYf1
	awxiKA6p98y/X/7/7S1ISYOBvOSHUA4=
X-MC-Unique: lc5rgDzEPnStbxomq-J9Tg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XtN0H0v6TMO9MkMGsIhcjRM3Lh5vsCyUQzZnxk342k7IW+tzsFeAko6g/90FqmLLWjPMPXFauG09rDBF7ZPmvlb+kgFpHrC2yQWp/k5uHbISOmIVdClKvMFhx7EQ1RQq346B1UzKwVyrSnlPMZbhDAGGAbuIQZmVGO0rnwCa9wpUe2b01kOEIKmfPT/F2eEp++EByEZ6DH6VSkdLu9obkjfGZ3lj5Nd9P5p0IgIs82Nc8WoJO9gKddDeTjwrv82I2IQSbIPsmWnt931X/Ra0wCI5QZlNUOwnH11zJxvDu8vQaDa9yDOsaRJJcpyVvI43pKDeF/RswYkDVFGc0D5KAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i62EqEUg1FfwSh0GvIbYWih43SAiLcTQYBloPkznT2E=;
 b=BEf/MG/9RnUWso7dhUA9qI9SLuz65l/QqoCdZU/LhhZDR4PWLcFnQ7eIq80/Mdv4k3ZSPoaRAL8BCxyDyD6hOaAvZ2vWuyl6J2GBQBNzMqOHTTmAKo34YJkY6WYQOc7l1e20vhXgYjEdsi+g+oYC5ALSdi3rnYX5r9BTLzuo61CkBLJE4qpZEILwnbu/98d0naWc0nLpNcLyqNeWZA2nXokJd/PinxfrWuh/ObYk9r1LOwXGjbxMmxP5xLyGqa1LQL6owrI+WOqbFqm5TCLI/CUGSr323M+GDhuGFAiGsE694Dz7XLXWopc17ZSGwfaKOFBBWMSI4A3Ma4GSe3Udzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b07b4f2c-b97c-5a33-4d50-d98903b18b25@suse.com>
Date: Thu, 21 Apr 2022 15:09:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v5 4/6] x86/gdbstub: Clean up includes
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-5-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420141307.24153-5-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0028.eurprd03.prod.outlook.com
 (2603:10a6:206:14::41) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a76c5f4a-d713-4dbe-e8a1-08da23981af9
X-MS-TrafficTypeDiagnostic: DU2PR04MB8693:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8693B7B52F2AED1E002B1566B3F49@DU2PR04MB8693.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OgzpumNYeGzedzPThTbLQRC13EJoC4R9NsxAtVfNPeMhbMvf5A9Wf2/ow2t5llt8xKm4B05+AXqFNsZXzgymEgJ48qRZC19R3p0jgDetVT3zNIMPLG53sKmXKZUuqN94k8fX7cz4EY7dm7+6kEW7qLdUEKJcwF7tTtCvVzUZVM6/Gd8R1jMLzpBpv4ShfmjzOPCcSL7ZwVWvir+Cf3MZAIRHwWBFJ3/dtYelQsScy2d8XUSfWZH4AzDByaf6yTxSXdHsP+VOb9tuwqewp1gG/k8/cPg9ugRHhFAgZerfLYkgz9aHcUpCm1I/6J/q1VN92L0zwJcSLGlL9MsGW/Dqk2Uso0gJZ1IIraYOcHt1p6sbrCmdfuWoV+QjFYQDBB966VTAUxYNHkFJZfTlLzPeRVJV6UpTbQPBvNhQFVthXtI72C576uWdgJMVdHPqu1FclnzEqRDaPr+VUgBhUFV74YK9jVLZnYHD7aw+V50MrSRHgqYCFCBo467REgy88AjD0pL1PcHJ0hdL5ues2eRtAF1XpBuW+auSXWRCqHYDRbnBZhYidDFGrZbERz/VmLPX/YucaAkbGntA86T7zYlgnXJqvu3MtJ/W12rOVYl4x97g/UMey/Dx7poG3twAp1UyY0lt3xuCZwk6+mfbhFMJhC/o88Ie0qZzCVYi/DJlc3JCKIQBIxGYqu15+UaE8ZgrgkyOND08lrIndX5/Gsh3akPogEdTj1q3zO06lRb3ivxL6iejOfHA2rP9kDEjMZFa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(38100700002)(26005)(508600001)(31696002)(54906003)(8936002)(86362001)(6916009)(316002)(66556008)(83380400001)(36756003)(186003)(4744005)(53546011)(31686004)(6506007)(66946007)(6512007)(2906002)(5660300002)(4326008)(2616005)(66476007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WEVtdnpHRm1Nc3BQV0ZmZ1JMTWpKWCtIcjBKS0hCQm4raHJEQUt0cUVKWExN?=
 =?utf-8?B?TXZVY3dDZmVYWXEwMGppdm4xdXVQeG5GclpVejhPbE4xWnlNY1I1b0RreS9m?=
 =?utf-8?B?Y2UvcDIzQzNycnIzU0M5SkNOWUhVVitad3R2dmhsam9mRkZ6a0M0V2ZrL0E5?=
 =?utf-8?B?N3BBU1BBOFBEM29qb2tQQU9YNmdBa0RweWdHV2FoUWhMTjZXWS9VaXU0UXZB?=
 =?utf-8?B?K2taOXdhZ2piUnppN21kOXg2L0pjSVIwSnpCMHVpdU9kTEJvZXVsNzV4NldN?=
 =?utf-8?B?Q2kxcEkvWXZhV3UxOEQwYXo2L2VYWmdBK2dRd1VoekpPSURJVmlYdGpPWjho?=
 =?utf-8?B?bHEvdDVtODIrUlE1UFJZUkROcFpLS29tTk1lc0t1T3NubWhhbC9Ld0NUbEow?=
 =?utf-8?B?bzNXQUVYUkRhNmM3LzNpOEJXWnBsdTA1QkV2Rjh5MWhLZjRHSzYyRXJBUTRK?=
 =?utf-8?B?QUZjaFhWU3RnVWtaK2tUQU1iYlplVFJSc0l0UXJoemQxQ0IyamdzcS83YUpo?=
 =?utf-8?B?K2JHaFgxOUNuVERWOVh6ekwyRjM1RllWL1EyZlVRejEwY2xkUnpmTjJPeVk3?=
 =?utf-8?B?TVZLK3FRbmR1YzZOR2wzcStzRzFrNzdndnovaTZ2RytXaTI3akJMMnZWQkZZ?=
 =?utf-8?B?eGl4OHhQeEVKd1dhMTFTdm1QNjFXU0E4bUlRSUd1dTF0ZnVNb3QxMWhaTlcx?=
 =?utf-8?B?Q0kzeFUzZW00OGtsSFlRTnRhSGVpWGRTcTF5Z0Y5SFVtMlA3cHhaV3hHQ0gx?=
 =?utf-8?B?c3pRNmcwaG9HS2tzQUNNSXpudUxjeVFRZzRINFJtdmtod3E5MDJnc3pKenNU?=
 =?utf-8?B?Z0NkZXpzOWQ1QWRLNTREU3Q1VDJkY2N4MmNjVEVIWjdCY1VYZWtSeDEwaElu?=
 =?utf-8?B?cXVNSU5CRXJMNW1ET2hIKzU3S1RYSlArU0VzbzZyR21YeC9tWEJxdU56Z0F3?=
 =?utf-8?B?YTBJaGk1RUZDdG9tUUs5Z0E0Qzk5SDVNdjhoUUpxNXRUR1ZWMFdaS28yTDRy?=
 =?utf-8?B?ME9QbmllRlZQRXNQTHV1aUh0aFAvY1dIblphVnVIY2NvZ3ZCRktiQWhrekJI?=
 =?utf-8?B?THBaMVdmWnBBN0FUVU5xcUNKck1RSUY1OG5QMTU3NFdIWEIzaE9BMmFDaWhB?=
 =?utf-8?B?THkrR3NqMU9KWWovWDZHU1g3eWlla2QxOFJHdHlzVWhCT2RTV1dMNXIzb0Fr?=
 =?utf-8?B?dVluMS95MmgwL0NlTnNSQnQ1UnlaL0tQU1FyVWNQcHdzRE9iQnMrWTBtMUZ2?=
 =?utf-8?B?djU4S3VmWGs0ellxcW9rQ0pjUG1ZdTJNU2FtS1BMcWVWdG9nblRoVjlvbldu?=
 =?utf-8?B?UEJTOGUrT05JVStmRGxMYjV2Ym51c0t2cDhRRU0xU3JaRDFVM0lWVlhDY0Vz?=
 =?utf-8?B?aHFGeXc4c3h6UXFSVzFNbmlWUHVIR2RhaDZEZlZKZUsxVW1hajhLRmZJeWhS?=
 =?utf-8?B?OTVoRjl3QmhvelRUU0IyM2M1YVRrRGg1ZHZqamhzK2FtNGU3aGtjRUNhd0tR?=
 =?utf-8?B?MkZtUlZYL2JQQnhQcDBQeFpucTBRbzc4VmtMdWtiMjZ3SFg2MlBHZlUxbHdu?=
 =?utf-8?B?OWJOMkdJNyt4RXYwUHlRUlZaWWxRZEtVK2JYV0pwbHBGSEZhWHhOQlRhZHlw?=
 =?utf-8?B?YTgyWXJIdnpMeFhVSWFLaU9lU2N4ZUs1MlZYZ21JMGpZQkhKY1J1VzIrRS9D?=
 =?utf-8?B?WnRnanlqM092cGszc0FBZTh6RXZQSFBMRzRqNmNmZHI2dTlmcThmYS9iaUZZ?=
 =?utf-8?B?VG0ya2JjekFKSEpWZE1lbDBjRVA5Uk0zaDdWUS93djZpY0prY3h5MkhrMUFF?=
 =?utf-8?B?SitkRFVBRmwrSkhvdlNoTko0MnhISEVaNHdhbFR5ODB1RFlqN1NUQzZzMHVR?=
 =?utf-8?B?Tk1OT2VRWnFjVStoN3RrV2dJMG9QdlVLWVByNlp2ZjBVR0xOYks1RlpOSnNV?=
 =?utf-8?B?ZjR4OU5xUVdjOENHYVhIV0RYOTBydjNzQlBTMkxsc2lEc1lTWTBUTjhqTXF5?=
 =?utf-8?B?RG02anNxVDFGTFhUREphVlJyYm5OUWMxZXIxdEk3QW5tNWhsSVhqTjBGZUNi?=
 =?utf-8?B?WU11b05JZEgyd3dDSmVDTzMvR0Y3bGtXQndDdC9leU5SNXlrV0xnM2JuTXFP?=
 =?utf-8?B?aEVERzBhVGxLeU82cWJndkE5QUExVzF1UVIvZTVnbFZWaXZhdEpZeWJ6MzND?=
 =?utf-8?B?M0xHa2w3Vy9jdmdFOU1WT1g3azlHbmZIRWp5ZlMxVkI2U1RMSmlTOU8reFov?=
 =?utf-8?B?alBHM3lBVERrWjVScHQ4MkMybkZLUGh6Z2JWQlUyV1lDVG51ZnQ1WU9wVDZD?=
 =?utf-8?B?VTlCUFBMZ0JaYVRyTEN2ZVpHUmU3eGZubGk1eVNzVU5HbUxsNGhmdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a76c5f4a-d713-4dbe-e8a1-08da23981af9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:09:02.2943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wSNN38idKrouEFFhiDDhMzrkja8HxmdiUrWTnQhQpzKB/WMwXncXMeV4KESmRmKxO3L1vZ+C/RttUUWlYcVsVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8693

On 20.04.2022 16:13, Andrew Cooper wrote:
> common/gdbstub.c wants struct gdb_context but only gets it transitively
> through asm/debugger.h.  None of */gdbstub.c should include asm/debugger.h so
> include xen/gdbstub.h instead.
> 
> Forward declare struct cpu_user_regs in xen/gdbstub.h so it doesn't depend on
> the include order to compile.
> 
> x86/setup.c doesn't need xen/gdbstub.h at all, so drop it.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:10:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:10:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310147.526813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWa2-0002XB-5k; Thu, 21 Apr 2022 13:10:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310147.526813; Thu, 21 Apr 2022 13:10:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWa2-0002X4-2a; Thu, 21 Apr 2022 13:10:42 +0000
Received: by outflank-mailman (input) for mailman id 310147;
 Thu, 21 Apr 2022 13:10:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhWa1-0002Wy-Hg
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:10:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 715ec16a-c174-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 15:10:40 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-MNNobX0xMWWrssbHLp986w-1; Thu, 21 Apr 2022 15:10:39 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM5PR0401MB2676.eurprd04.prod.outlook.com (2603:10a6:203:2f::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 13:10:37 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:10:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 715ec16a-c174-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650546640;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XwltpXNGUfKmNG4DGrHU00pL2l7vesHzISdiHd+xR+4=;
	b=CVin/TLvtpZH5Z60kY3+rreU8Vi7MOMsqhGZ+/BmRGq19YfeVg7gR3zS4sLtSqbXbWkwgf
	gv76PHOm0Jit4xF2Zuk2xfYNqSyCdPSt+s+7WrrXkoJ9aoaNMtgY/0ztZKk7dYkWRlA2bV
	Gow6P3/NtOXOWuJSS8DXsziaxpCJGeo=
X-MC-Unique: MNNobX0xMWWrssbHLp986w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=le/J/KGTFSHr6dwWSWO9Mxa7hYCYqDr+uMhPeKQFXQBV9eHVj5sVnRjjzVPWFj8qZZqx32t5wgAvn3iWwrwnTXtfirFYXdfD8Qm8PD/7/AaKSfkrXrfv8WIsvAlD7FK3rPS2T90VSPH6C/AJkWTa+mB6v3+61H+G07OoRDbTBmo+MyqChuw5zRbI9sb/Kxh1N/Ft7cnblLRPgJEP2B8gfhmFeMAuS+XDh7zNAHUp4dGK6jLshbs4n1bUun8kCOpVd9TPlOjdXuAlxDap1wVieWLjd+BK0sDZ7Beqr9vs0ivCtTay9JKEswZNyZfrIDIYiYcbMOuLiHaICdPEfZqEPg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XwltpXNGUfKmNG4DGrHU00pL2l7vesHzISdiHd+xR+4=;
 b=XOOMBuczthkKG1RnExTIsGVyINmz7kFsKOv4X8VH5T35RSRXUUv3D3ct0CnoJ9IKvZUhMyoj+YIBs/Bp5HoLCzv/VAwMbj7X7jeG5b1qDPk4+mpDKHxFQqYXqO9oSrhc5RDYYaqtiV7ufubE7B5iqmVoQCme+Kqv9IztEtoTVoFoGuxVjMsOEUpd0YQanYaE4BMyPW8gQ1Z9rTyzBXa/hwAXJC3228XEmMJ5GjhdO0Yvmke1kfH5j9RMqVee+9GQtF4+69kzAEmqH6nJMOiKeM+rsYgYcBSBSZKIabasZElWK5Llt1yUu+/6JVbKLiIc+ANag/R5I2MQsKaA5Xy6Rw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e330e26a-052a-c75a-92f1-fe7f022b6c35@suse.com>
Date: Thu, 21 Apr 2022 15:10:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v5 5/6] x86/debugger: Misc cleanup prior to splitting
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-6-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420141307.24153-6-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0107.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::48) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 52ae3373-ee16-4464-f2f4-08da239853b0
X-MS-TrafficTypeDiagnostic: AM5PR0401MB2676:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0401MB267649F116E6E735E4EAD318B3F49@AM5PR0401MB2676.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2TxuDd9Tni0NmFFcs7rgEDHQ+cxQc8mCPUkHTV4hc+RiWK5HVqkwUjNO7hshW47kUrCROjaUPEMF4rJxyPYeDRZWOka7Ic+IQo1xwof3uhitUXbCix4vT+x3IC3eDSyJmgMgbSo2u3hwzC8k3QglLwSkeVbfL65iBb1t2Qu/8bmYjTzdQo+w0eyjIcnpjJealNc0R+I4D+gpeRQQRQZfsEe37pURluqtZ584Q3APqUX/8UMuE03maWrAmoIBbhswXMjW7+VxFSC+i2rvCnT3KaXiVZguOvE3Vipbwa5zIDtTP4n5wfd+EW0j2hr1E74Pw6WCXMdTOzPNKCIiN4iNizKXYZR7R8O1jxzjL1xhnL14IBAJAvYMXMZ0RI1DcfLvXqgxp5Z/fkUElKKIZTNPsbV2LXnCZkEcaUmhukrwGfAsAQOOHtfVKmmDjicWj1rHr23G6uYrwNQ+0+fEjtW3rUO7A2xSgSyoLaoDfNA108yi/TFxD1sbfrtUG3+De0HxmP9MZIMEj9JPkhvsPgUqJ1g3dswtGW8XqDKnVuSl+j8gCRaFWVmKTgyT4EH9anDy5SVJFKFYB0FVb/cW4/XyfXewXw1G5ydyqLOsoZBDawlV7pzxzRe45wSq+X6me91G1Nzz7tKVZmsw5Nl8coJCLdwdylcY2cuYKUXFq/BW/SKDIQ8NglcRuNjY78VvFDmtpDJjaEXh4kXFDMsldQmfp6ZiUt4T5YzI+9/suJ9Ya5MJlh0yUiymrLUKhc20jWjW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(5660300002)(4326008)(54906003)(186003)(8676002)(26005)(6916009)(6486002)(66556008)(66476007)(66946007)(31686004)(36756003)(86362001)(2616005)(8936002)(4744005)(53546011)(38100700002)(2906002)(316002)(6512007)(6506007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U2dQcjU5dzliMWNHZkVIejhGSTlzY3R4RzdvODZEdXZZdm5iaVpyV1lpeXNh?=
 =?utf-8?B?YU9OMWNVOUZwczZRNi9uSk1RZnNkTjFybGx2TjRXWHZCRnFjelNmaStlZEFQ?=
 =?utf-8?B?c25YdU9JVkRUZUpJak9idzB2NjBQZTNBTE9WUEhabVkwZFVwMjU5bWRURVlQ?=
 =?utf-8?B?dmpXOUxJQ0MwODU1c3ZJNDMxRmRnaUhXc3hSZW1DaDd0R2FkY0E0M3hUeXcv?=
 =?utf-8?B?RXIrelNmRkUxc1JiblJQSnprS3BUeU0xQzFON01HSnIyeWVkMElQWHVqVzVD?=
 =?utf-8?B?YlhVc1U4UVhSQWtwWVQwdzNaM1F3alF0WVBYYkZBMEcvL2dRdWJJWGllbnIv?=
 =?utf-8?B?UGE4dnRYcEZXZFVtSVpIWHR6dWRya2M4emdxajF1OVpLOWxoZ0JNMUpHaHV5?=
 =?utf-8?B?TTQvdHFiU1F1dDdJd0FzRy9OTXFOVXpZdy9NRnhEa1RRRTVPRnIvc05CN0M3?=
 =?utf-8?B?U3BsN1dSV1hUYXQ4NUZuczBMZTBDb0Z0YUdJdmFYLzNGRDdNRzJPRy83UW9Q?=
 =?utf-8?B?ZFQxUm5FOG12TmNXQmFIZzJqZVl6WVF5MkM5dUJHZ0h0ellFQ2ZORjV0OFFk?=
 =?utf-8?B?Ry9mZDJ5cVRxRFcydGV2bWRCYk1xOGhtZmF5QzBxY21qK3JXcTBjSWd3NWZD?=
 =?utf-8?B?UVVvQzJhYzdDUG81RUFCVjdLY24wM1BrVVdNOVErbm9obXpYNzRaNHVTTlow?=
 =?utf-8?B?aWFycTZYUHh3SitrNzc3WmJCZlV1a3FSRUNEWmQwVFh4SnBvM05PVkx4bkNX?=
 =?utf-8?B?ejFNR2toZUJCUnE2Vi9QM0JzZkNwYUhIZHplQ2NwWDFxeCtqbUoyRjg4UGdO?=
 =?utf-8?B?SGg0OUplY3RZUTMxNVplUVVHbG5YRGhjZE5IU1d4aTZSb3UweHJmY3BybjI3?=
 =?utf-8?B?QUJRU3NHcW05WHc0enA0MzBjOVpIcTlzS1BRcG5wanNlNEkyT0JLRGZ4VWta?=
 =?utf-8?B?ZjZSU1IxYWlVRmJqME1FL3pDcHhIbzN1WGlYSjhsYVBmb3Y4dG1YLzNMeGNJ?=
 =?utf-8?B?VytZOUFRYUtwRlFkOXNndjgxUjBEaFd1RVM4c2tJSUdKSzBSKzZiamdqZXIr?=
 =?utf-8?B?RTJaUThnblBheXNvMWZ6YUkrM0dnSjRsNVliM2hOV2I2UWxDNHJwMmNkaGlx?=
 =?utf-8?B?a0VCWmprK3l6UXVybnpPVlpvcDdud29RRVJSL3hIUHZwMFJmMHdmZ3pLblhn?=
 =?utf-8?B?b1p3YzNxa2V3LzFaV0RyWG5hWEh3NGkzdWI5NUNCRU5nZ0xwYmVjNi9hQm1P?=
 =?utf-8?B?eDBNQngyMis1ZFoxbVBlMUVNb3FjTUdwd0d3ekd4aEdRYnhlcGVCUjZOOHVw?=
 =?utf-8?B?R1JZQWlMZmlBeVJGM0poWEJxblJwa3lYb3pEdC94clNjMUhVRHFsOEllTUhW?=
 =?utf-8?B?MUVQaVd6Y0pOWGd0SFd6N0xFb21uTGZWbElHemd2WHpLTmNabTZZRmxXNHNU?=
 =?utf-8?B?R1pnUGZSOU50S08wcDdncHY3QjhPMk14amJWZWVIdXU1WTd2bHZMdlY1cGdp?=
 =?utf-8?B?MFRwMHVZcjFRNzA4bGh2MExQdjFNWTh1eW9DbUdPc1lzclh5Q3lZSU9JTklZ?=
 =?utf-8?B?MTdMc0QyK0VSMnc4elZzUnZVU1ZoZzIveXFaVTVucklVT0d6bzNSUUZXUExz?=
 =?utf-8?B?TVNUUmZIQ2lPdTZiWnRtdGdLRDdSVHhoU3RjSFVLZUZZWmppWFRHRDlXTG1m?=
 =?utf-8?B?N0IrZTlqRW1OMDUyWUQ1WWM2OUI1elNOWFY0dDdkK0JMQnd0YU1Rd09VcE9P?=
 =?utf-8?B?SmYvMjF6YTBxN2lLVWFUSWN3WW4yWXlDVW9scnl1b21pZndrem1ESmlXc0VG?=
 =?utf-8?B?QnQrU1dRUnpHanRuTU5KWW44M2VnOUJQdWtlUC9ZcHpnZE9kMEp1aitqTXJ5?=
 =?utf-8?B?K0hhdXorbjdBWnNEL0VkY0VrZmZJZEs0VGIyYnZuUmdlbDNpNFpDUDNtWEZF?=
 =?utf-8?B?TU9PTWNHbDhaRWdDWThRU1UvZE5hL0YvTllGMmpTcTZRaUxYeEpwNUM1a1Ir?=
 =?utf-8?B?WnF4MXNRYUNzcXV5by94T0hheXYrL25Mb3cyTjdFRDM2VldjTXBOV0JNOHBu?=
 =?utf-8?B?RG8yUnhhUUVzQ2tNdVJQVWVGNWs3ZjVKbVN2ZUtiNkVFRzlkN1RLbjR4ZHZi?=
 =?utf-8?B?Q1pCcXVxcjB4azd2RFMrZ29uSDZiRE9UUGFtYzB6djlSUllSNFJPamJoWTgv?=
 =?utf-8?B?Mi9wYUNud05NaHZKUzRvTFlOelFudkliZXlmVFlHQ0tuN1hrMnZMZVNrUFVT?=
 =?utf-8?B?dHM4NjQyVUt4S2JYNldsOEFsVitpaHpUc3VQclJCVGNRNS9NVXZmY1ZrM0xG?=
 =?utf-8?B?dTZDbFgxaTRabDFORTdMbVRyd3hPK2FRQ0wvc3hUNXVVN0FPdXRLQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52ae3373-ee16-4464-f2f4-08da239853b0
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:10:37.4014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K2roEmQHa7T5nHfx6/hm+twIOIO8c8knvoKqdr4lpBObNZsuUbDg+RuCUxAoRwqaKFg/oTRDkzoEGGR3Y7CB1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2676

On 20.04.2022 16:13, Andrew Cooper wrote:
>  * Remove inappropriate semicolon from debugger_trap_immediate()
>  * Try to explain what debugger_trap_fatal() is doing, and write it in a more
>    legible way.
>  * Drop unecessary includes.  This includes common/domain.c which doesn't use
>    any debugger functionality, even prior to this cleaup.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:12:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:12:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310154.526824 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWbm-0003Rz-Gd; Thu, 21 Apr 2022 13:12:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310154.526824; Thu, 21 Apr 2022 13:12:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWbm-0003Rs-Db; Thu, 21 Apr 2022 13:12:30 +0000
Received: by outflank-mailman (input) for mailman id 310154;
 Thu, 21 Apr 2022 13:12:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhWbk-0003Rm-Qq
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:12:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b15d9517-c174-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:12:27 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-sMe8rIa7P9OaK5EiQzQmKA-1; Thu, 21 Apr 2022 15:12:26 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR0401MB2551.eurprd04.prod.outlook.com (2603:10a6:4:3a::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 13:12:24 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:12:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b15d9517-c174-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650546747;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FEhOx39Vh3u+diaBYHdOaToLd7oDXDRK7iqTC04f/1s=;
	b=Ahcc/pKFtdLEU7bura8DB7lLXu9vs2VglVXN9dhoBRGIQXEZboMRVTa0ckS6kHisXxXQXG
	vz+aXDTABF4A6WAees8W+g3U7Iy0+thn2Yrnjh0RaOItWaPK6tgyxcg6nwISoKNUB4vh5M
	VxHaPN9NOIrCNattLHghHMvFdfBMlII=
X-MC-Unique: sMe8rIa7P9OaK5EiQzQmKA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g66ZoQ5twHK80kZO0Doko+jYerT96/K2u/8EMPOhvB4/ObVkjZj7gWABIP+QU2aBmQ5D9eHY1vTSCSnR/FkcOtZdGTbYeNt1nowZvF6PWqETXOGwpMXEh/NejfhuP8XfLOjKrP+IjLewlKyEMxCf6He8nzsC4DsSEeW+VLp1UTZ+F8oX6nBxkb8LSaY/oUuBaA199bjGZ3+H3lz9CPtVlQM5/5B1pOnLLWrqREB2vvA0X8QQ+YRHuhPXw4YAabclhKF4BOfga8QoU/C+jLrhcFtGCS9Z+o2CXcPDt08ymixdLu8q+3L+X1JjTWOnoH9Wx2QGqS5LXJ3Evvy318e3RQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FEhOx39Vh3u+diaBYHdOaToLd7oDXDRK7iqTC04f/1s=;
 b=QPyd2OVoZouCA7omhhEB9gUdya2kN7Z1gjWT5K2S4J1QqgScLL3nkankizQGE2IzGt+ZtlGHavhSAyKPUc+SnBFi2vVsfzIWGHv3lHEvprDJ6q0cJnIdmz/GvuP0dPTa09HS8HNT+RXzM3q1013xhL2cp54pthZno2ZgNbZ3iWDXBlrP7JwL2UGt+4ciziyFL2/Rt9LoVfDg+qTKO9XPXKFxR18pE7Ihe2fmsobk18yB2ruFX6pv7hYgTSEEouz08SbJGg0Y94Ga+75AGRW6+WTiAE6cgRoAgj/ld1yzxXWmx2l/LGRmeRRwv6MZd5Ud006fXpEC9ihkyVkJH19+sw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e74361a8-4006-4673-8a1a-d3ce6edf60ad@suse.com>
Date: Thu, 21 Apr 2022 15:12:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v5 6/6] xen: Split x86/debugger.h into common and arch
 specific parts
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Bobby Eshleman <bobby.eshleman@gmail.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-7-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420141307.24153-7-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR01CA0049.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89a90163-497c-4208-8823-08da2398932a
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2551:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB255198B981A14F5EFBB8C0C1B3F49@DB6PR0401MB2551.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9rW3ll+aiyx1zyMuB/Gmok80RWx4VbqHZ5n5Chg4fehJa29taajERQxdBw2NCNOHRzik8oXkEF7aK6oRe8Rg8NAbG6cjcKKfAsaz9PxHOyzjphBLxJsV0CZeIespll8CZc1jyPm4SmA2T664ZbJKR/5tJeS6tWEnJBpcRxtF+PHc1Mc1FHDNRBDW5EBqo1o3siqrl9040Yho3XCc5hHZirncBGBrpJ7mn3zQefNjsRJYStMKknT105H04KP9gU+xHRQ5q6C+8yLqvtrJsGn1W6m3FxVhkeFHbP4pb/4UifkJdqXGRkUJnM3kGmDtUAwhpZ7LYdaDeHQd9vbOZ7Rmji1eoDKM1mxALrA0JY4O3QanDpnSJezrQeruJLuygC/87FGgdu4HXogmETcsE/2oAA/2WGpXwx6m7UrMf2dOgFr1bv1mqGfk9MAPwk0CQKxi9OSxCbSpL+U0wgV3WogKN0O7ceEasmQL6PVi+R/i/d8aA9Sfb/NpmosBjxRXa9Zgm4KfZ995u8wKgCQZk2bB8HrjiQ+LaajZijdpOcBHbX/XBGSwzjQ+iwzvuObSfeOVrdb+CDFF4LS9I6WLtafuIyrb7fAY4oN1nrjoTchoFwPjuFUqnWAkyMEpfk5x701CFo/xrXnEI2M2DCjt03CjcuV6F6a2XszLoXUIyw5jXU88pZFb+wBglM/HQbzcPAdIIiZXkAhPxL4aHfC7/jgIBQRpEsAcVGiWjVgH8OG47hak34T+vjUD3XeayxDpUor1
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(6512007)(508600001)(86362001)(6486002)(2616005)(66476007)(2906002)(8936002)(53546011)(186003)(83380400001)(5660300002)(6506007)(31696002)(4744005)(66556008)(36756003)(38100700002)(66946007)(54906003)(6916009)(4326008)(8676002)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NktzWnpDdm8zaTgyWTlLdDJTOWFPQTZuRlY1bTR5SlNKOXJ6MERTOWZiYWtR?=
 =?utf-8?B?d1NFVlYyaHY0THlNUUFvNHZXWkFDS2xJTzBxZWJrZVg3UC84YkcvRThCK0Z4?=
 =?utf-8?B?bTF6SUFpMzloWkhXS3d1ckliNzNxTTlkdmVxK3Zja004alY0RjV0blVwK2dZ?=
 =?utf-8?B?OThldDZyKzFKdU9OVUplYk9sVGZKUkNoaWYvcEpFNFZzRVh1VkJwTndJc0w1?=
 =?utf-8?B?R0xubmtEc1FxSXpjNmFoWGhiNUVKWHNldlorSW9sbEMweDkzTFA0N244Zk5N?=
 =?utf-8?B?V25YZFpnTjdEa3Nac0oxZGdzQWNsek83cnlOOW9IYm5XckpPVCtZQXZWMEFB?=
 =?utf-8?B?elpONnp4aExEbUh0UzNCZ0pZbDBkVnZqS01aa3VkdFBnNS9pRS9IS0FCMyt5?=
 =?utf-8?B?TG9xSTFWdXNlalV2MEJTUVZ6MlFRd2g2ekJ6aUFPaEp2Q1BqeXJ2dXRkVWVy?=
 =?utf-8?B?QUZOK0FEQlV1RU1rVmE3TjNrTy9MK2hETDRTc1liMEZRVXljL1BiaUlOZmFJ?=
 =?utf-8?B?NnZJN1ByQUZMZ2dYL000NWFHVTJHeGNxdUJWb2l3bnVwZFRHS20xY2E2djRr?=
 =?utf-8?B?WG9mOWRWSDg0VmFtbitQRzVUMEdqMkNLYmkyMFlrSHErR1h5ZjhNWVptRFl4?=
 =?utf-8?B?cVZ1eEhFODZCNGFqcWhFSjVnNjE1VHd4d0VIK3QvQjN3RWZIaXdjbjNJOVp6?=
 =?utf-8?B?SDdpczZ4SElBbmwrNUhYVzFkVWZKK1FzdVNjRGt4SGtwb1VSTUZ2Qy9mdUZ3?=
 =?utf-8?B?Y2tGb0djNCtKRkZlUUxGRHBXTkVOUGRJbXhqUHhNa1V3cisvdi9JREowQVBv?=
 =?utf-8?B?alViUlZ5U28xV0NYMXNCQnRGckg0VTNHcUlXM1NyQmpuNFB1QVp4d0RWQi9t?=
 =?utf-8?B?ZGhKMXlyNGF2bnJmZTd0TXgrMHVQZ1VDdDFtVW9KZVBXRE96SXdEL0NXekNl?=
 =?utf-8?B?bmIrdStQanMvT3pkNWN6S0QrYkYySk1nM1hvQmtFcE5HclJ4VnVnYVcrTUsz?=
 =?utf-8?B?Mnhsak1CNWNKV0NiTTVIa21oQW5uMUdoeVZwK3VsR2VjZTJGNTcrSmZleGVH?=
 =?utf-8?B?MFRVazhQMzYzS1JtUlExbDhjUlRaTFJLd29zTzdKNzA3L1JWME9OTkE5a3l5?=
 =?utf-8?B?dWF4czBBR0F2dloyVDB4SURZRXV1M3V3STdvSGtQYmhYciswOVAxUjYyeUlh?=
 =?utf-8?B?SitPK3htL1cxcFVjK3c0dHI5T2Z2enJtNkdWOUpINEpCUytYQzdwQVEwRHMy?=
 =?utf-8?B?VVl3RkdWZ2cxOEhrbmE3NC9TaDUrN1RIbVJmalNRQi9odnd1YVBRMStOUVpv?=
 =?utf-8?B?Z0dtWFA5NmdmUmZ3YnlZT2RuOHVIWlhOTzc3Z2xadC9reHFmOEt5bTFzd0N3?=
 =?utf-8?B?YUJSMFdtSm5WR3o0b2MrQk44RkZFcVh1K09RQXFEbnJ3R1d2eVZjMkRSMnk4?=
 =?utf-8?B?LzhqTy94TG9tNTJwRnJLd3owSHJlWjBYWUl4b1lCZjg3TFVjREIyaVM3UjNp?=
 =?utf-8?B?VXJIOFVLbmIvMmZGOTlxbDBWOFd3cjJZSkRtUlhvaE5rcU5TNE9GMGE4LzRJ?=
 =?utf-8?B?RVh2YzFtOFdYWGU2REIzaG5XU3lSbE5tcGlCaittU3RoQmZzUm1JanVBSjU5?=
 =?utf-8?B?QWZXa1I0UGljL1J4cElzNkdudEJWNUcvekZrVjB2UWFrWHBwU05yano3UnM2?=
 =?utf-8?B?alk4YjlyVy9oRU9ZQk9yNCtqa1NhaG9GOW9nNHE3UWxRZnNOWW5IWTlNZkU1?=
 =?utf-8?B?azBoRmNCaXF3eW5wbXl0cEFYem0yUzZuZk9KTHZFbjZYWnJDeFdvUjV3bjdz?=
 =?utf-8?B?YWNKVnV1c0JWUlhJV1NwWTNzc0FQTEhyZS9LaEVvbVJGcDRXRnB4UzNhcXky?=
 =?utf-8?B?V2FPU1JCQUJKQWxnQlBVT2c4K0VocVRtTVRKUVlnYWtuSHplVlB0RnhZZE5w?=
 =?utf-8?B?KytnN0JUQkIyWFBWOUZnWDg2M3ZBeER4czArWHNlc3FrY3l2Rm9rWnRsSGtS?=
 =?utf-8?B?NVcwbkp6ODJUMVNWZ20zeGlEM2VkMHB6M3phdm9YdEVNMXAxcUtaVk9YSU1n?=
 =?utf-8?B?eVp0d1huR2JFQ0VsWjZBd3J2ZGU2YisxU0RlcmNKdmxSbkVVR0lnZklvRjV0?=
 =?utf-8?B?RU1Zb1NEdEsrYk1jOXpMZWE0UDhicDFDWlpKSmM3OEVSTnJHRlVYRVdtQ3Fa?=
 =?utf-8?B?Yloyd1MxdjIyOHVNRi82aHdGeGZ2K1E3elNuMExUcVhVL1BLbC9qTHhIblEr?=
 =?utf-8?B?dkl2MVBQY1BQcHpDUXRVN2xESCtkdDFEbVRJUGgrdm4zbHZLbGVlSkt4M3JP?=
 =?utf-8?B?Y2xBNHplbm03bks2cXVjN1l1MXNGcjljT2Y4eTg2bm1IenhtMWQwUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89a90163-497c-4208-8823-08da2398932a
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:12:23.9104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hIeNr36yFOfqjVf8nJSQ3zWOuONtNsihRDiPsDv9Y3Z8eCZktACY55DE3c42tS53Fh1kFlAQft6ZhDSWncoHkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2551

On 20.04.2022 16:13, Andrew Cooper wrote:
> From: Bobby Eshleman <bobby.eshleman@gmail.com>
> 
> With all the non-CONFIG_CRASH_DEBUG functionality moved elsewhere, split
> x86/debugger.h in two, with the stubs and explanation moved to xen/debugger.h.
> 
> In particular, this means that arches only need to provide an $arch/debugger.h
> if they implement CONFIG_CRASH_DEBUG, and ARM's stub can be deleted.
> 
> Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Julien Grall <jgrall@amazon.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:22:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:22:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310171.526861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWkz-0005nf-0Q; Thu, 21 Apr 2022 13:22:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310171.526861; Thu, 21 Apr 2022 13:22:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWky-0005nS-SR; Thu, 21 Apr 2022 13:22:00 +0000
Received: by outflank-mailman (input) for mailman id 310171;
 Thu, 21 Apr 2022 13:22:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhWky-0005Gk-73
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:22:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 047f6c89-c176-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:21:57 +0200 (CEST)
Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 09:21:57 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN7PR03MB3649.namprd03.prod.outlook.com (2603:10b6:406:c9::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 13:21:56 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:21:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 047f6c89-c176-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650547318;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=rBuBPJq4cctWRyDQOnxPt77RLOb1g9ofZ5nVo86zj30=;
  b=QdoELDoFyDiU6D76i0oVUyTu8gW5zas6oyiWAV1YuMkU53or3bhMGwmu
   L4m7TVhI98YEMavxZkzRyTR8Yia3Nje3MFxJQsbsdOfMdTSbd3hPxL6HI
   YC/7D0HR3fLbXYlpiRDpWVyd1k82dP/CwU5P8XzBXDS+/TxeIlMFKnRRI
   w=;
X-IronPort-RemoteIP: 104.47.55.174
X-IronPort-MID: 69628152
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:NEa5sajQCi2aL4yeUsQ07/xlX161FBEKZh0ujC45NGQN5FlHY01je
 htvCD+Fbv+CMTH3edAnPIXl80wD7JGBxtFhHgI5/3sxRX8b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nU4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YTwTAJzugNlBaAZdKB9VEvZF0aLte1Hq5KR/z2WeG5ft69NHKRhseKc+qqNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehWhs7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9gPL//puvjK7IApZ0L38EPbJdN2wQPpcjgGfm
 XLh8GL8DURPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BVJ
 lEQ+yEuhbMv70HtRd74NzWnpFaUsxhaXMBfe9DW8ymIw6vQpgyfVm4NS2cbbMR87ZBqAzs3y
 lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obs5jEpMVkcG
 wy3kRU=
IronPort-HdrOrdr: A9a23:epGMUaP281xqXcBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBDpTnmAtj7fZq8z+8P3WB1B9uftWbdyQ+Vxe1ZjbcKhgeQYhEWldQtqp
 uIDZIOb+EYZGIS5aia3OD7KadZ/DDuytHVuQ609QYJcegFUdAC0+8vYTzrb3GeCTM2TKYRJd
 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYo4LSIly95FMzQjlPybAt/S
 zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+cwjqAVcBEYfmvrTo1qOag5BIDl8
 TNmQ4pO4BJ53bYbgiO0G/Q8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMn5
 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvsH+9KK1wXR4S1bpXUN
 WHVKrnlbVrmBKhHj3kV1BUsZKRti9ZJGbFfqAA0vblpgS+0koJinfw//Zv70voxKhNNaWs2N
 60QpiA7Is+KPP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d
 78bG8=
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="69628152"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LqIbDiD/126uVBnMNLYUdgTHzjzQvvsXUWaM2bYsmfJ4Ov4bVdHwHGq31lvS3m+tFRFiBKtr+86nEgJAq9bvfhGBvyqULNdHcoIsjw0ZaPPdFcMLZVdln9DHIyyIT+BECeh/19issIBWrYYf1sWLz6RD1+ONwHKauZFY8jWSELdtOxnwpndd2o2wPeUS0Kg0lYUi7Z9x7ThQ2Ai4MqnVrdJzWWt0JUpQvN7zQPv12JfCD4f9bs3MElpXNAV06a7LPEJyf2Xti8MXzFwqJby6GFTxJfV6I9qzYGklq+JvyFHo4+IC+XFIFPEYlmjXeL8DF9Vuzy0+8VrfcX+fQ9x1RQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eiYpcvR4fTeX/RmTQ4OuGBZuZs0rA/Bk5WTNjAu5kLw=;
 b=RBRK5bkT/6FugdxcT9Qdcz5P6V9N2i43KFr2OWNvB1QEGipphggTUL630VanrnJLD0AqfUsTinuImIS3JVTigU0rbaPORr5NJbHWli5nKdKqIvFpmBZ58Yqidaf1E8dGB8iAjka4kzqSFRLQBWR9faBryE/wOSfgNdlnDcIvIxFln4cDT6lVmc3WJEo9e/egrKmH7LlEa8qVhhHVM74kPE5ikkWv3i4s1MOW0Ev8ahx+WL7OY2eZdsHPHFP14C83t70/VeJoYkFfijwuhf3rCoDLvM/Bz2dozzTXDO4GyosonEuXs3iLhnpBmT7KgWRFG1Ud/Rh4qDeO3rlQSZZH6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eiYpcvR4fTeX/RmTQ4OuGBZuZs0rA/Bk5WTNjAu5kLw=;
 b=BZnR8j+wTbUSDmrMjx1v6jV8rrPxLDi26B5aucr9rECPaioUgEJMZrrwgPajEE8onlJXgyPeKaSqD1JXjTneCjW+aJI4pYqBzW5HnTcgEIUkrnhdLOEWM3Xv2G+0aYTnYkhiFr21ykTI48l+GPDdrccq0wYpzFhM6b/N9n3G6e4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH RFC 2/6] x86/ioapic: add a raw field to RTE struct
Date: Thu, 21 Apr 2022 15:21:10 +0200
Message-Id: <20220421132114.35118-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220421132114.35118-1-roger.pau@citrix.com>
References: <20220421132114.35118-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0078.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1f8a5b20-5181-49f1-393e-08da2399e882
X-MS-TrafficTypeDiagnostic: BN7PR03MB3649:EE_
X-Microsoft-Antispam-PRVS:
	<BN7PR03MB3649A5410ED746917C5107A78FF49@BN7PR03MB3649.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BIxTxl1TZLD0KfAr435cOtkIF8VQSB6smlc03bb5GFbKrNZqJtu0jZB7XPXOFtQkBlv6UIUMCpinETwgzZCrhfyJhs3WTMfzmNs3MOlBFOKwIIN9JciwJQX/mkvN9ofVw16EtyB4Spud9U7oKgwYe7BDFNBY6w5+sUcxfao/Ev9rPBuYJbOew9vfkGMp0Mxaxi21DxfBu8eDd+sGM6hgSPWp06Q3XAHYds2T971X3mCoJMDLeIFXZs1Bo/HIKug5/9KRqsN4H3pWozqApwPET/KXgjCtuO3ZQBgnTcA+c1ik4qXKDEFYjvwmzYZrbyS/VpQ8a7WbD4L7qkSrw4hjXnLMfX0pjPksViadyf/JTGMTQGYJN4Yg7goMk+cbYbouFyEZjmYIn5QOs/+aEfrIXm7oFEZJxg7oMpifu6SKjmxUaa03ScwzkNHS0gHWm5Y/C1LHxZk0Sm+1zYsluB1xlZH97v5I7B11xegti3coCBhoRPZiZ26GX3LX5/DQ1MRRQgD9RwWYYyiTtrwR8qbcQNYD99h/Be9PPCQc13m3ID71Jra+dOyTN7I/U551r1NAuE/n/gPEwI3ULI5jtiJeiDqP7Bg2R8o2kuFPSKx5Cthndj0qhQxTKBrgjmqcP9Wc+gwMm3nz5JSTYkfbj9USUg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(6666004)(1076003)(6512007)(316002)(26005)(36756003)(54906003)(6916009)(2616005)(2906002)(6506007)(8676002)(4326008)(83380400001)(38100700002)(82960400001)(8936002)(66476007)(66556008)(66946007)(86362001)(6486002)(5660300002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Tjd2V25Xc252UEJnVHVSMUd4bkgyaG9yclJ0T0lzaTdDQmFvVTA2aEpwVjVI?=
 =?utf-8?B?LzlTZzJ2OSs1dVFqVmthbFd5VTNPK0ZINU5TT0Y3UEFpSHp3dzdFYmNiLytP?=
 =?utf-8?B?R0IvRUR4bmhPY3lLazBXRkVKLzEyTzVEYlVxZVZ4bUhqa2dmUmJ1aCtFT3pL?=
 =?utf-8?B?OVZLZS9wV3BpVjVMN3FMNFN3cHk0YS9ENkg1b3VHT0ZWV1p6bUFpNDE5TjBq?=
 =?utf-8?B?NlpiYzFtOUR6ZUZ5Z1hLYWVQZEpRQmQ0TEIwZEswL1hlREpVZjZnTnA4RTMw?=
 =?utf-8?B?cjBLN0pmdnRrbUhBdTJHUUlYZTJyWUN4MkRWdWl1L0hPNWhBOXI0SHFXKzBB?=
 =?utf-8?B?Qm8wSmdHOGx5cWFSaE5saDViNEU0d09SNlArVlhPSXc3bVNMK3hQUTFaZHgx?=
 =?utf-8?B?K3d2Ym1rRFljaUllWDdwZHhvbkZabUJQbGRYK2pWTStPVmVmQUR6R2hac1BU?=
 =?utf-8?B?Z3ZUdndIQXM3TDlhazBKK2tBOTFvVVMzRzUyMU5UUlVzZ1dsZjRiSXA1c2hv?=
 =?utf-8?B?UDllZGhIb0lGUVM1OXBUS0lzaXR5V0N1RmtMclBXZWdmVW9WcHpCU2I4NmRO?=
 =?utf-8?B?U1NudDRYb3JRUEJ0WEF4eFZuelJpdlV1UTRqM1ppUkYyaDlMSlR5dEN6MTZy?=
 =?utf-8?B?akFTeGVEQUR0TFFRRnFEanY5S3pkQW8yYzZFRVhYdlkySE1zR3BpcnRoSUVR?=
 =?utf-8?B?UmV2V2c2MWRvekVzbUc0dGkwVE85NnlUbXA1S3FwbmgyNDZRMUtWbk15cGNu?=
 =?utf-8?B?TDc1aEZqVDZKaFZ1K2NCYnlCV0VMLy92aytDUHVtQjRjdnUrSW1GaDZQN0E1?=
 =?utf-8?B?K3QrVXNNaHFIY21uVnFtRnB5ek50ZnJ5S0RyUlJYK3l4UU0raTkwUTFnV0V3?=
 =?utf-8?B?ZitqejhhWG8yOFBLSlAzMjI5dmcxNnc2em9aY2dJcXhPa0JXakZBcE9sbVJi?=
 =?utf-8?B?TzJDZ3NHajlndUpzbmpodm5sS3ZzZFVtVkVrLzdzaTJndDVEMjEwN3hzRXVw?=
 =?utf-8?B?VVM1RS9CYXNNMWxvdTFaRHZaYmRyNWpMa2hIL3BMY3lFREl1ZFhrN0RTMnYr?=
 =?utf-8?B?QmhyV1VxdFBsdjlHTzRqUlBjY0szR2RiV1g4U2dzT0VkTDh0TVRXYThlQlpM?=
 =?utf-8?B?bFF4K3pHYzhWL2ZMWmpvQ1UzZ1l2SStJeUdyWUpZMTVzOXJSSXkraTV0dlg1?=
 =?utf-8?B?UkR0dlJSdWhIZjJuZlZqWHRnVEw5eXNwZ2xPSHllNHlKbW5oQi9NelhPSnRh?=
 =?utf-8?B?SmgxVGtCTDBsUTZDbEkyUnZONHQ2ZFF1dTVWaGhXd091N1lOVTIxelk5MVhu?=
 =?utf-8?B?d0Ird3puUDlGNWNqVjJyWkdWeXk3Qzdjb3FyWDRHaEdERDd5YkZJNkpSTWVE?=
 =?utf-8?B?RHBuWHhlZlZIUXNRZm9sUlVRN25Vd1pTeERHMXhIUmU1L2RjTklIK0Vmck02?=
 =?utf-8?B?cnp3R2hWTXpLN282ZXdOTWwwamZrQWFGQUYzR0RDTGpuR3NpSjdiWk1GazZF?=
 =?utf-8?B?eUNlczhOZ2F2eGEvSXNMc0ZkV3NGQ1Q5a2hnU0VWYUd5c3grYnpSRnJzQ2JF?=
 =?utf-8?B?T09uNCtjVC9QSjZyNElIQ0gxL25zaThlcURGWTRyZEFNS3Q1YzlSaWI0NTBJ?=
 =?utf-8?B?TzBUdWF4TmhIMlJJUEtIVUhLLzJwR3ltQXh5eTl5SnRtdzdaVFc4ZHJ0dzFW?=
 =?utf-8?B?OHpvNHhmSVdkeEplaitRbGZqK3lTQ0VJSmdYZEk4Y2J2d0pudm9EME9wVXd2?=
 =?utf-8?B?Unh1RWg4S1NmdHN4WkF2eGthY2prNEVsR2l4VUZaaUFwVFA1alpvRGNhYXZa?=
 =?utf-8?B?Y0xQSUk5bEp1aXJRNFNMUEFoUUxGSzRXSk9CUjJGOHhJdmVPMi9SZzA4dmUx?=
 =?utf-8?B?WjBzbU1HVG5Tek12eUFHeHFEdWlzWVVibjJYL0Z1YzlWSm9ZOTFiZE5STkNk?=
 =?utf-8?B?NmtEbC9MdWR3UjlFU3pDQlpjNFRoN3BwbEhZb2czKyt4bXYyRkQ1TGZ4cHly?=
 =?utf-8?B?Z3gyemlPTG1TaXdMVFFsM2xRTnVicTkrdHhOenNyOC9SbVp3SVZyNmUvVyt5?=
 =?utf-8?B?UDFzdzh3QjYyRk1zRi9MTDBmeXRxUFRSTTNrT1hROEhrSXlSdHJtWUVtYXpi?=
 =?utf-8?B?dXdkMXBXNGdjanUvT2lxTUlmMjFWdWtkaFFVTnNsV05YNXh2Si9rQ3pSK3RQ?=
 =?utf-8?B?YkpqekpxaE5sOGNsNnhxMFpqa3gydUlvNE5pbHFoWTBBWjlITFBqZ0MxWE1C?=
 =?utf-8?B?Ym9walQxU0xidGhSSUhhbVRDTkNCMUpBaXRtaXpJSG5uMWxmVWhGTmczS2tB?=
 =?utf-8?B?ZUtEcnJndlFVNm5JaDVHY25jVkVDdmZLN25OTnhvSWdLbHFWd0h3dDZXU3I0?=
 =?utf-8?Q?4+IceP+3E0t3Sth4=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f8a5b20-5181-49f1-393e-08da2399e882
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:21:56.5256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YrJ4HswcJObdlM1qjxqQIKvi+hiCYD9/aBN4S4ECZO4pEwxmNsywssN5QibGjgvKA2s7rhs/rrL2Vk4qT5m4uQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3649

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/include/asm/io_apic.h | 57 ++++++++++++++++--------------
 1 file changed, 30 insertions(+), 27 deletions(-)

diff --git a/xen/arch/x86/include/asm/io_apic.h b/xen/arch/x86/include/asm/io_apic.h
index ef0878b09e..a558bb063c 100644
--- a/xen/arch/x86/include/asm/io_apic.h
+++ b/xen/arch/x86/include/asm/io_apic.h
@@ -89,35 +89,38 @@ enum ioapic_irq_destination_types {
 };
 
 struct IO_APIC_route_entry {
-    unsigned int vector:8;
-    unsigned int delivery_mode:3; /*
-                                   * 000: FIXED
-                                   * 001: lowest prio
-                                   * 111: ExtINT
-                                   */
-    unsigned int dest_mode:1;     /* 0: physical, 1: logical */
-    unsigned int delivery_status:1;
-    unsigned int polarity:1;      /* 0: low, 1: high */
-    unsigned int irr:1;
-    unsigned int trigger:1;       /* 0: edge, 1: level */
-    unsigned int mask:1;          /* 0: enabled, 1: disabled */
-    unsigned int __reserved_2:15;
-
     union {
         struct {
-            unsigned int __reserved_1:24;
-            unsigned int physical_dest:4;
-            unsigned int __reserved_2:4;
-        } physical;
-
-        struct {
-            unsigned int __reserved_1:24;
-            unsigned int logical_dest:8;
-        } logical;
-
-        /* used when Interrupt Remapping with EIM is enabled */
-        unsigned int dest32;
-    } dest;
+            unsigned int vector:8;
+            unsigned int delivery_mode:3; /*
+                                           * 000: FIXED
+                                           * 001: lowest prio
+                                           * 111: ExtINT
+                                           */
+            unsigned int dest_mode:1;     /* 0: physical, 1: logical */
+            unsigned int delivery_status:1;
+            unsigned int polarity:1;      /* 0: low, 1: high */
+            unsigned int irr:1;
+            unsigned int trigger:1;       /* 0: edge, 1: level */
+            unsigned int mask:1;          /* 0: enabled, 1: disabled */
+            unsigned int __reserved_2:15;
+
+            union {
+                struct {
+                    unsigned int __reserved_1:24;
+                    unsigned int physical_dest:4;
+                    unsigned int __reserved_2:4;
+                } physical;
+
+                struct {
+                    unsigned int __reserved_1:24;
+                    unsigned int logical_dest:8;
+                } logical;
+                unsigned int dest32;
+            } dest;
+        };
+        uint64_t raw;
+    };
 };
 
 /*
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:22:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:22:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310170.526850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWkw-0005Wh-Nc; Thu, 21 Apr 2022 13:21:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310170.526850; Thu, 21 Apr 2022 13:21:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWkw-0005Wa-Kb; Thu, 21 Apr 2022 13:21:58 +0000
Received: by outflank-mailman (input) for mailman id 310170;
 Thu, 21 Apr 2022 13:21:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhWku-0005Gk-Mb
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:21:56 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 029bfa40-c176-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:21:53 +0200 (CEST)
Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 09:21:54 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN7PR03MB3649.namprd03.prod.outlook.com (2603:10b6:406:c9::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 13:21:53 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:21:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 029bfa40-c176-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650547315;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=3IGNZ+VfL0mt0x6amMhXSerxu1UgLXEzTKuf9OnMG/4=;
  b=Pbr2AQzLjRK3mzr6SgeNiYJk7Ti2dk5qwIUCeG1zIcCUruRrMRsMbw77
   k6hDzqU7ZPtNIhUALuxjiCy3KxRGMj2JKCQrZKLfyw6xEx2SoEXmeQKXA
   Zfy/a+e41XPXeLNh3gxjBSxzSAvbMrh5LhPNU07spNH6j/+AxonhOFzB1
   8=;
X-IronPort-RemoteIP: 104.47.55.168
X-IronPort-MID: 69628147
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:wEJKo67y30ubgqHYVcnBbAxRtEzGchMFZxGqfqrLsTDasY5as4F+v
 mofXD2FbvuDamahft5/a460o0wPuMCDm9RkSgo5qiE1Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjWlvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSfRgFwA7z9id8aaDV6STw5BbRCo43+dC3XXcy7lyUqclPK6tA3VgQcG91d/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YGjF/chegXdRraT
 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2MJ9gjF/PZoi4TV5Fxo8IrnEOT0QebJTsBHkR+6l
 lv6zl2sV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL
 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJt//YS7QiMzu/e5VafD21dFDpZMoV45IkxWCAg0
 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLScZZUvWd9enM/
 g23
IronPort-HdrOrdr: A9a23:GmGl06vsuTN3uPJTRbBOB2uv7skC5IMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPMs1NaZLXLbUQ6TQL2KgrGSpwEIdxefygcZ79
 YYT0EcMqyOMbEFt7ec3ODQKb9Jrri6GeKT9J/jJh9WPH1XgspbnmJE42igYy5LrF4sP+tFKH
 PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w
 31CNUXqFhwdL5nUUsEPpZmfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a
 6xIm+w81RCMX7TNQ==
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="69628147"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YuSE/ALZgipOcoubIbKMxWWpUa/cMFsdouIFYVcITL/ios4ZD9CfHQLLCyfUnwL8g1CEbjatrvOwdCEfuFpWLrVIATX6uTz6t3YCB2+kqOLs1CFbotSNBK0HGO5jfMZUjNXVHwnte5KXiAPU6bvMBjFqdwfT18I85mfwOUXekX6ePCOCBI1wkQT0QrUb0taYp8r2qulx/kSeIV8CDInoeXuUiLhIJ6FcCYv9LKgwmcInzgf930bN9D359U9WAkWYd7RNJcyucucqcbuGo+/a3bdF+BLovOVCWAsvW1+2Pa8ZY0EZE99m+wZ4V6DDB9C5bfLI1Qxmim1aX98D6uTA5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MplFUaOgPEc44piH8DIO1e3W6kPo2BvT4PdjJ9GUhPE=;
 b=jVeVuPjKTczt3lAsHs4Bpkw04JWa/WkcMeHXl7i4erFkPyLo8OXzA8QYjYfrpIFC2OGR4Vw3KQf3BzWXH4i5Rk9EatoT73GM8BJOp+1cM3pJUjkahXpnHwO5SooRaiK1BEaAOFkK9Lr4J5kp5xEITgcis783B9xk/Py9KlQtasPuh6+vaB0nIKYXJ0j74FszmRs9uF9ZJ7jaEjoX/zwhkphA4nQSN8QwGEv+J/gmQX3KiSVLSY48riYqlkl0E0RFTIZ+FEQcmFp7R45crmnxGH1UhCkMH9vkI5Q1SIqzTsd6lweOP2hiRVEk+5NFpX2De8KELWnjLsJFbDp5jFyOPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MplFUaOgPEc44piH8DIO1e3W6kPo2BvT4PdjJ9GUhPE=;
 b=ib4J47h2/pybrx8wO+E5fzgg++JuNGHDUjT4lY1TlCEtx2lRmkPjFnp08D3QG5sWCCTVhnEIC661TCn3WosTTPQTDavmoDBaeD1ku2JT3QjxVT1vh662KDBm5ZrdEdY8PAQJeB5vWuZHZ1tXMRlhel663R/Z2EBqt7vOxf1J5ug=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH RFC 1/6] x86/ioapic: set disable hook for masking edge interrupts
Date: Thu, 21 Apr 2022 15:21:09 +0200
Message-Id: <20220421132114.35118-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220421132114.35118-1-roger.pau@citrix.com>
References: <20220421132114.35118-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0170.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::9)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 161fdfa6-5af9-4ded-dfd1-08da2399e645
X-MS-TrafficTypeDiagnostic: BN7PR03MB3649:EE_
X-Microsoft-Antispam-PRVS:
	<BN7PR03MB36495C921D6ACD0CFA89F1548FF49@BN7PR03MB3649.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bGhWpL3wjHR52MNL7jnHfNnqzjjuQg7qlczAlmzRalkN3+Ew5ngFNFks9yy3VSwTfbBsrpsOFDy6iQApMk/InP4FDXQkdtqUSeoXTQmGaXfzjVDU0Vfi4XtGLq35/cmZjpc5ulkZc9smBFr/MhPDKMwPptedHHyXS/PRoLS0mIG1WOoVjLmcK49KpqwkyhfA45n98TtQrxwTGH+pUJct6TRJJjTQcWxSg1tgH/2sUpo+pVJb9JYofmX1QQ6TOWNo6roQvaQ+XMSNJnXYhF5udHPaTBXRSxaaeEfnIBJPm5Nhp9vHlfii8TVU79l3EoYyUuueYuO8JVFOb1ct7BSYvmzL9/3uhy3hvmx/xJgJo63GACWgl5vIsLsZwXvq0UjIvWQJ0miP2MB7UIyFzR6y7su175Ewsa8oFaPo5gqzigTzTPPrbVbHqK4v6l6e1m6ALBVgQejoRu4EpD/1UB+yoAosWWRfSFgxqj5j3xQRebL+Ei8LNgClEbhWvSswxBSR8DnxT4OnllOFJaLpcLX7LswA7atwJSYj9L1ZC9IyHPOyUVLI2tahoUfh0wWNCr1KzOS/VD7E5Af9V3DmvQMQdp/kJSC99KgBG7qakFwL98tuuRBPKS16RlDQAHnJlsvO2B5BUpm4RCO9J5F+gL6Sfg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(6666004)(1076003)(6512007)(316002)(26005)(36756003)(54906003)(6916009)(2616005)(2906002)(6506007)(8676002)(4326008)(83380400001)(38100700002)(82960400001)(8936002)(66476007)(66556008)(66946007)(86362001)(6486002)(5660300002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Wi9vbk9lNnZub3hKZkd5b2pyaGNONGVoeUxVUFNwUDVCajNQdVIvWis4bFg0?=
 =?utf-8?B?Zm9SM3lQOGJBZWlYR3hzZnBqMEpNalJxRlBaZWRNUTBYSkl3bXRxb09MeWY4?=
 =?utf-8?B?OStFam9TOFcvRC96YlFpYzRDQnVIdEtQcDB4WktCWGFFYXJ5RUpwT1NHczVw?=
 =?utf-8?B?Q2Z3bVJJVHJEbkloVEZtVzJobm5aNkt1cjhmVjl6QnhqMCswS2h1NzJKYmVp?=
 =?utf-8?B?cGNVbm1oVlNGVXlLUDR4cDdKYXVrWWsrV2gwTkVaelR5dEZGbjZaS1VHcC9M?=
 =?utf-8?B?Ym9zVitHMzV3WEg2OEV5ZHV3SnR6a1AxOWF3bjlWUVFhbElPaW9WUjczS2Ux?=
 =?utf-8?B?aExUbHZ1NXI0ZW1MTjZWWjVaTVAzNXl1M01sUERjbmRGWTFIUHRUNjZrV2pR?=
 =?utf-8?B?eVVKRkFHa0wyWWZrN2l4YkJBTElZSU51RmVmWnlySkFmeXdiOXhweFE5TktB?=
 =?utf-8?B?TGF6TzhrSVRGRURFZEtwNjVGQ3lXSVlGN0dWaXVWYXZ6UEQyS0diV0pHck1I?=
 =?utf-8?B?bDlmUGQ0bmwyTVVWVXBraFdXbVNodVo1NWRYUWJQaTlzemRaeTl6SDVVV1kv?=
 =?utf-8?B?dHdjRWNzUEpvK3RIa0VLd2swY3diTkIzdUxwaTRIUUhqQTRvL2tTcE1TRHdt?=
 =?utf-8?B?TDd1VVB3SjkyMDk0MzkzZC9FMnFRUXlabE9VVWI3d0RMeXY0N0h3c1hTd01T?=
 =?utf-8?B?RFNSdm8xQW5hSkxPdy9BTGV2NkQ5cXpMdWdBT2dCQVBPM3RBSFYyUkpYclMx?=
 =?utf-8?B?NFVyT1NnZEcyKzIvQ2dwQUhlTEJ3WWE0ZjhiZXEyK1hHUWQrWlVvUitKdEFH?=
 =?utf-8?B?b2t6UURZNzFTakc0NmE4MEkvNERUVUc0SlI5UlRkdTBvSXVTaXYrK1lISWx1?=
 =?utf-8?B?ekFqNHIzOEs1dXdudWZOS281K0ptYXNCYmsveERSN3RNUDZwUWFDT3A2RnBK?=
 =?utf-8?B?dFMvOXhXR1hWdkszOFNJRjBQbUVmVUZMZFc1M2VQOG53Znh4dHdvTVI3NlFX?=
 =?utf-8?B?WDdBM1ZRRHBISjh4OXhnNU1XQTNpOHFOeFBraTQzV0FEb0dMQzdvUGdhNDNv?=
 =?utf-8?B?ZTZRZjArM1JHejkrVjNDR050d1A1Rnc2TWszTGJwMHE3UTZiK1hoR09OUHJG?=
 =?utf-8?B?UU0yZW9QK09tYmVvY0loeFhTbklmSlQwV2JNeU5NMWtjbEFlWGVPeDF4aEZZ?=
 =?utf-8?B?bFBjOFlhK2FsdkxEUUJrbk4xQlJQT3ViYXNBMTBDaFlFblIvZEZ6QWpTSXU2?=
 =?utf-8?B?dFQ3S0hqWlZRRXZabnRpMVpPaGtiQU9ZN0ltV04xOXpIK09KQWJFaTZpQjE2?=
 =?utf-8?B?alNTeno2QzdhbGtMa3lkMFZLRituRXl0bGVER1J0Ykt5ZDUzUFlkQnRJUlFO?=
 =?utf-8?B?bkE0MzQxbDB2ZHZhYkk1S1BCQ2FvbWVpNjB5QWdyb0huNm14N2dmSHFGWmdO?=
 =?utf-8?B?Q3B5UUxFdElMSk0wVjFvMTd3SUJIMytPTE51RW1pWlZzQVNWbUdEYnpuNXZS?=
 =?utf-8?B?M213WnJmaVlVYkFQYjlrZUNVU21rQTMvcytjcG9PSSt3Rk5Wdjh3dTVtc25t?=
 =?utf-8?B?SC94cCtreDJpTGhxUWhRUUpMb2k5Z09BYnRod29lNzBRejMzclAvR0xzSjhh?=
 =?utf-8?B?NEh5YnVFK2FqVVJ2d2NLRzc5M0JuY01jVEZkVEx4VEpjb2lWTU1EckN2TCsx?=
 =?utf-8?B?RlNHYWdJaDV5RU1aOER4UTcveFpSMVJjNk5TYU5ROUR5ZitLdzdWcjlQU0lm?=
 =?utf-8?B?eExyUjZtUHU5QXAvaC9Fb1hQT0NsZVdnZXh1NFFhc0hYR1p2eTdRR2ZkYmc2?=
 =?utf-8?B?N0pxbTM2MVBNYU0xMUdKVTJFRDFUQ1FNdFVKTDBWb3FDTzgwaXpLZUo2RnNK?=
 =?utf-8?B?TFFRa0d1YjBjMFY3bDlZVW5HTVRLTjVUcXRrZWl4eTVlZU8zckdzYTM5WkJZ?=
 =?utf-8?B?RWxDQWpKY2ZKdkJVSm41QUVPa3V3RTdMU2FCYkhQVWpnelBURGNHRW51WHVG?=
 =?utf-8?B?WGhpblZGMXU5dUNxOHZUZ0p3U2dkWlRLQTV1Q3BaV2lrYUlZQnIzM2UvLzBu?=
 =?utf-8?B?ZVlJV3p4WFovcnJsejVFcStnNEI0ZGdRVllOUWNPbHR1RzVTYWp4T0lEK3Nv?=
 =?utf-8?B?cTZoM1ZDVWZydldLUzdSOTFFVHV5SGthN2RkYmtnWmp3U3M5aDlnU3BKelUw?=
 =?utf-8?B?Y2dmZnE5dUllY1RhYnM5SXV2NWFTeDJEdzMvcDQycXlKQzdFK0dOMXZZSWxq?=
 =?utf-8?B?V2NKazB6N1h5ZjlCYm5Ca25vamxpSEdGZ0Mva2xhV0JBZnZOK2ZOOTRsdktp?=
 =?utf-8?B?RkdmVjRTZmtLSENZUEF3TXZZRkJLUWttclVtRnJUZVNEM0E3bEd6dEhVSHFq?=
 =?utf-8?Q?zWWbFLyg938mPSiY=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 161fdfa6-5af9-4ded-dfd1-08da2399e645
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:21:52.9454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cF16NhysOp9sAQaW14Y9M8OnJ0cZZzvZfHBSZhN90sdvHr8XAT1LHWF0re7NKCI9jGJ8M2UCfbWzJ1CdvPneyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3649

Allow disabling (masking) IO-APIC pins set to edge trigger mode.  This
is required in order to safely migrate such interrupts between CPUs,
as the write to update the IO-APIC RTE (or the IRTE) is not done
atomically, so there's a window where there's a mismatch between the
destination CPU and the vector:

(XEN) CPU1: No irq handler for vector b5 (IRQ -11, LAPIC)
(XEN) IRQ10 a=0002[0002,0008] v=bd[b5] t=IO-APIC-edge s=00000030

The main risk with masking edge triggered interrupts is losing them,
but getting them injected while in the process of updating the RTE is
equally harmful as the interrupts gets lost anyway.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/io_apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index c086f40f63..2e5964640b 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -1782,7 +1782,7 @@ static hw_irq_controller ioapic_edge_type = {
     .startup 	= startup_edge_ioapic_irq,
     .shutdown 	= irq_shutdown_none,
     .enable 	= unmask_IO_APIC_irq,
-    .disable 	= irq_disable_none,
+    .disable 	= mask_IO_APIC_irq,
     .ack 		= ack_edge_ioapic_irq,
     .set_affinity 	= set_ioapic_affinity_irq,
 };
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:22:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:22:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310169.526839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWkv-0005H2-Bj; Thu, 21 Apr 2022 13:21:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310169.526839; Thu, 21 Apr 2022 13:21:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWkv-0005Gv-8T; Thu, 21 Apr 2022 13:21:57 +0000
Received: by outflank-mailman (input) for mailman id 310169;
 Thu, 21 Apr 2022 13:21:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhWkt-0005Gk-SW
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:21:55 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 00f9627d-c176-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:21:52 +0200 (CEST)
Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 09:21:51 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN7PR03MB3649.namprd03.prod.outlook.com (2603:10b6:406:c9::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 13:21:48 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:21:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00f9627d-c176-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650547314;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=jZyrjLFF7c26fEoKVpZ5U3W1KX5PPxiSRBxQXY3VBOY=;
  b=XR1XMXW9Mty9Q527f+GEx+CLqddsAaHFjfxNtnzVdG/a+MBCyDqfQ9y8
   YBqtY8XRqD0+1HHlIWl1K/mzV0TTIfnR8W+ylp1M1RX6ToQUR6ZNO4OPh
   BwSvBJTELAEeG/yjFgkuisla4BD/xBbSxvN+0OHqZ4NCzCQwEDbVoKF+R
   o=;
X-IronPort-RemoteIP: 104.47.55.172
X-IronPort-MID: 69628143
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Wi78SKOr1hOd+qXvrR21lsFynXyQoLVcMsEvi/4bfWQNrUpz3zACz
 GtNUWrSbqmNMGekKYt3a9njpE0C6JaAyNdhHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2Ncw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z2
 O9dqpqqSFoTMoaQnuEmaEd5FSpMBPgTkFPHCSDXXc276WTjKiGp6dM+SUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaHP+iCdxwhV/cguhUGvnTf
 YwBYCdHZxXceRxffFwQDfrSmc/21yelI2QE8zp5o4IXuHH0kE8y0oLoMYX7IYy6Y5QLhnmx8
 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1a3FOvZsnwWVu/unHslh0RRdtWVfE74Qely6zI7gLfDW8BJhZZYcEinN87Q3otz
 FDhoj/yLTlmsbnQQ3TN8L6R9Gm2IXJMcjVEYjIYRwwY5dWluJs0kh/EUtdkFuiyk8HxHjbzh
 TuNqUDSmokusCLC7I3jlXivvt5mjsGhotIdjukPYl+Y0w==
IronPort-HdrOrdr: A9a23:qqV5lqOFaG8lVcBcT1z155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBDpTnmAtj5fZq8z+8N3WB1B9uftWbdyQ+Vxe1ZjbcKoAeQZhEWiNQtsp
 uIGpIWYLOQMbETt7eB3ODSKadE/DDoytHKuQ+IpE0dNj2CJpsQmTuQTW2gYzxLbTgDIaB8OI
 uX58JBqTblUXMLbv6jDn1Ae+TYvdXEmL/vfBZDXnccmUGzpALtzIS/PwmT3x8YXT8K6bA+8V
 Ldmwi8wqm4qfm0xjLVymeWxZVLn9nKzMdFGaW3+4EoAwSprjztSJVqWrWEsjxwiOaz6GwymN
 2JmBskN9Qb0QKlQkiF5T/WnyXw2jcn7HHvjXWCh2H4nMD/TDUmT+JcmINwaHLimgYdleA59J
 gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kNQUk2dUXeIlGfJsRLQkjQ1o+ao7bWPHANhNKp
 gvMCic3ocdTbqiVQGXgoE1q+bcHUjaHX+9Mzo/U4KuonprdUtCvjQlLfwk7ws9Ha0GOud5Dp
 z/Q8JVfZF1P7srhPFGdZA8qfXeMB28fTv8dESvHH/AKIYrf1rwlr+f2sRH2AjtQu1C8KcP
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="69628143"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EaH5qi5fFEkyBpCF6gUewO3xE1DhH0OoypZ9uf0xjk6nCvD34JgjS3jdXKfU3nNkI561Xv0FdOrsTBkTmvOQrKr/jXeQKss8WNvg1H4AcyEoVzmEWNF/9lvfj9m8nrU6MmysrCWa5gkxglWixuidufAJh+mMT6ebtHj2sVMtWS9AMp4MDyyGeeBsAd/C7WN8KYkSbY4y6EVlVzUbQ/Y256JPF3O1sY9a1S05+J57urOKNsdRFy1hhYh5FAL4RE921Wc4SE2i7Fvl3cDr2DLxJVCOeq/nLaHCVoSaHe8ugV3Mv/DjL+WSlcrk5oIxyXzuGQX9Swby2lMCk/4WZLz70w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p0eLGIcM3P4X+NUpoJY3mSiSpRD256XuFHD/XZ8SoOc=;
 b=HEPg8uSPqP49OiWpOlhol7Xz3T1HznCLw+kzPbVo8wh5+p9/A/Aequr4eu6QMj5ej6OR87prOpTa3lHRPyjdzJuRw/gK/JqFx9Z5FMkww+CexBy94NiKiqxm8fDAo4DJsGxIM8TFo46/fL4R8KCFgC553uXL7rLwsLBNqNXT5LEJcd5hGsetR/SbZRu3QQkRwnokZGN4RJddPGDuW/szxzzarRZ3K7cWijRQe1slkYDbuvZ/8C3CpiU2h8218wCDKnrfTSkU9+M9qvcBexZr/YishGA1qUyi0+xR6Hz490Lcbr649Q1SU8YcJjOp5wJyt8bwszpf16ixjtF4ujkBnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p0eLGIcM3P4X+NUpoJY3mSiSpRD256XuFHD/XZ8SoOc=;
 b=K4fCB+Povrrk/cFCL+DH0nkZ/cnVFVDBLDYP+em/CwNWW4jH/vX+d7QDuajEjS8JZLtFVlHFqF1xSMpIKYBTVNkR1bMLpOPXrvcEQ0PKYs1ioD6CA+6rkGCPg6ibKYieO2CZCdxQvkHHLDccgD+zAUXMaBqWpU/S2CTGOhSxH0s=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>,
	Kevin Tian <kevin.tian@intel.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH RFC 0/6] x86/ioapic: fix edge triggered interrupt migration
Date: Thu, 21 Apr 2022 15:21:08 +0200
Message-Id: <20220421132114.35118-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MRXP264CA0038.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::26) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7eaead84-28d0-4593-54e7-08da2399e399
X-MS-TrafficTypeDiagnostic: BN7PR03MB3649:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<BN7PR03MB3649FA6213E3C2F6117457C48FF49@BN7PR03MB3649.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	V8q2XbyRzlrNNg4Hk35yQ2OTZ8+H7rkawrS9o8soSsMfKwDoiCnLB0MP3sFOgtrz5eAVAwWnn8a988b0PZrQsOHP2utJrl+12Ju0YM0ypD9ZT6m3gVEHCbJY2DSVwUuQBIqsuJWMpog1GlXcO5LKCFpsYDuV4FL16K6L2rLYw8/TYXlNmkGuM4s39oHVEOhN5bM9qblzYX977Lkng0A9cxIg8LiElMxuOw7d6MGXu/BaKlSFmI56IHxWqBjTPvAmFoM2VkQTHV9zOc8jPkwXtTleeysJ4tAWGy2cPqfHJm7+0SBGai2XCn/H5+5WpfnNcOUG2SuL1oLc22Yfc76WUR8SWWj9ZEGSu5mAo/zhMDFYr2yPK8fa8JfOr51xT9F/isyPZYWf67l0YNkmkZ6pLD0L8R1ye62VZAiLJ7JUF1fFhGi1mLRuDiRbCJUgKBityT+DK860x2rl5xoeBDSea6X7A/SS9AiOhZ8yyXaS49F7AdVwLAvjmYiLo9xrVIyvT+T4o839vK76bSIjZ3dLSLyN23HUFzVL6Na8j3/8qnxcCej7FStBDgT6KUOxkYA4iEoknIjC0eeUPQPBjsnWVlEecJZW7UBaQsnhmwOAGq4ANtHbbFkhsmHH0yYcErgvPZ2I6XdmJKiu2qIYWaL3YQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(6666004)(1076003)(6512007)(316002)(26005)(36756003)(54906003)(6916009)(2616005)(2906002)(6506007)(8676002)(4326008)(83380400001)(38100700002)(82960400001)(8936002)(66476007)(66556008)(66946007)(86362001)(6486002)(5660300002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q0VDY2hqdS9FVDM0R0tlWmQwb3JnUjRhRHgrMzA1dmV0UDZqZ2RWbCs4OFZI?=
 =?utf-8?B?MFZCc0FuMjR0R0ZwN2ZGaldxZDE5cTgzZnpiRDJxTk5iUlpoS2JFaHc1STI3?=
 =?utf-8?B?M0oxZmJnUlNoUTJHNXN6NTJQWmlpWGhQT3dsc0lVTE1HaDhCWEVaRjFtYlhB?=
 =?utf-8?B?OTN3UzNCM2tNZmdMWDFQdHNRZzdTWGJPWEtjaHhiNTRWQVRqbGwwODgyZ0pD?=
 =?utf-8?B?dU9PUDhKNHlBTm5ob2RFZ0VNMDQvbGNHS3VKcjN6RDAwU1VXQVlDMTh0eXdU?=
 =?utf-8?B?N2E3Yk5abE5uemN3VUsraWRYYlA3Yi9kUnlnMVJPdk1uZ1JpU1lBQStmeSs1?=
 =?utf-8?B?VmEyZ2t0cjEvNExLVnl0cmg0cDBiRzZCOUFLWE1SNzZKQm5rbnJldHVQNTgv?=
 =?utf-8?B?NFIwNWd5Q1lHQ2xLUDY2YWduVFVyTER0enRpaURvYit6WnRsZnN0VlUrSklI?=
 =?utf-8?B?VzFCOXp1bWx5aVNMK3Bweld0cmlpVTZ6cE1YN0xJbTZzL09BMjI5ZFR1SC9l?=
 =?utf-8?B?R0FDdExva0dLSVhNTmhucE4wN01zUlhuaVdHZ1E0QkxIU04rYVU4WVFQREdR?=
 =?utf-8?B?SjZ0K0U3WGNzOVo3SzBWb0lCenV4TlkxSWZiRXVJbTB3cEdDS1RZMlR5cU12?=
 =?utf-8?B?NSsvWUtIWmttTkpUdGdNVVBKVURjbjhOYW54SDhjS1BhREtvejQ0VlFKMUtH?=
 =?utf-8?B?YTJ0R09tb2N4QzZUS1A3MVFwZVUyd3dJK0pRMEdLalBVRUxuZktVZ1kxNko2?=
 =?utf-8?B?RmMrdGR6R0VlOXU5QVhua1pOS0RwR2dmdWI3VTVFRnBTZlJwMmFTL2VNTkta?=
 =?utf-8?B?WFBwdHZJS2N2NG5ZTWE5V1h3dGNLZEVFS0dwb1pzZzVzRGpROEc4L0EyTjBY?=
 =?utf-8?B?em81UUo3eXVUNk94K1IzSFQ2dHN6MklLdmFMNlZ5Y1lHQzhnVjNBQzg2Zkp3?=
 =?utf-8?B?MW9qd245SCs0ZnJjUUJmQnNUcU8yNmVMNktzMnRwS3c5WDM2Q2lLQndSTE10?=
 =?utf-8?B?VkdzRWtzNFRQblJKaktIbittdjd4Q2tRb0dya3NWV1FzOTFNQyt2WWM4TzE1?=
 =?utf-8?B?Z1g2dy82K1dUUmp1bjNITlJZQlIwMGRMZ3U2SXZLWDhnMUxtamZlai95NDRn?=
 =?utf-8?B?ZXJLUGpPdEN5bDhsZnVmNUdEUjhRdjJpZEt4UDN0LzQ2dTVhVlc1Nk1VZTZB?=
 =?utf-8?B?dVR5bUhLcnExTG1KM0tMTnIxU0hyZUtYZ2U2S0JDVWNOWmI3UHdVZ05OdzdD?=
 =?utf-8?B?T0VSWmx1MFVvcEVCRnVUL0NTcXZNSENYNVU3TGJWY3J4RWJjNW1WNVNENW10?=
 =?utf-8?B?NDBnNytJRE9QWlJ6UTREazloeXRDUzJMQ2lqcW5qU2g2ejBlT09aZ1FmVGVy?=
 =?utf-8?B?YzgvdUM0R1VTRnF5NUxhRDFMdC9qMitTdUxLb2VXalFDV1I2cjduQmNUNFhk?=
 =?utf-8?B?aGxFandRU3FNc2ZjNjNrYnFISDlNaCt5Mm41V1JqZUJReHJjNFRPZGhWK0NX?=
 =?utf-8?B?b1ZGVnlEcXBiYWFFL0FkYkNqZmlaS0IrYTYzcUJEQ0w1a3dOVHlDZlVITlFZ?=
 =?utf-8?B?Yldab0Jkd25pZW5TMXIzSGJyalhVNFVKZUUxU1dGWHQxUStPeTJoKzQ5R2RL?=
 =?utf-8?B?S0ZzSXBUM1I3MS8ySDFOdkpmT3hYY3hML1lmQncreUVmNEltamdoeXNCWDdo?=
 =?utf-8?B?eGhMRXF3RG9UbWplTW1aYW4yT0pydEROZ1A5MG1qa2ppc1NaQW5HNm9UVGkz?=
 =?utf-8?B?aS90OW4rQlZJRnk2U05XamdvbVVGNHRYRWlmM0JtcEhkTll1NWQycVg0ZEJt?=
 =?utf-8?B?YytJUXZ3MjBZaHc3QlkxcUZIcE1hMWRJUzh0aHFKNndTcjV6K0JEQzlCYkZX?=
 =?utf-8?B?MEo5SjVZWWpmMWRqancvdXVLa1E5eTJqRzRaMG5hMm5IeDJ0RjlwQy96ZmFr?=
 =?utf-8?B?Q1hXSzZvc1NmMjVacGdQL3NvaXRNdXRUQ3AzR3R1MjY0dWRzZndWR25hTjNl?=
 =?utf-8?B?czFxS2pWOW52d0xKVmpudHd4TERWVGgrc29rb0ovaFYzZ3ZmSTNQd25FdEJK?=
 =?utf-8?B?TlpYZEFWMTd6T0REOUUzV1A1Qjg5T3FkY0M4clQ0WlBhMXluSDJXYnNQNTUv?=
 =?utf-8?B?YUc4ZGVsY1p6d0t3R0FubnJ0dTcwdHJHNFg5L0t0U09vUEUvSkdjV2NiTys3?=
 =?utf-8?B?NWJKaHVzK0VsR21UaWg3a2c3a2Z2eWZteFFXY3FqMXVRQ0xEdUJjS0p3MGd3?=
 =?utf-8?B?SGI1ekExUlJOejIzR1hHY050VllUVVZiYWhqbEY1Z2ZZSnJ5SEhlWUNxb0Ez?=
 =?utf-8?B?b2dpSHoyQ21lVHVzcG0vM01PZDhyOXljM3o2c3VzRDhpREJnOHJrQT09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7eaead84-28d0-4593-54e7-08da2399e399
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:21:48.4135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QjddaoNO2ao/nfF61A9tq0sNaps8IApB2LCsCZmmOLq2hLL5kcmPvLrfdBT/k8TiDKGykt8srJWC1RzXzeBedw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3649

Hello,

Following series attempts to solve the issue with IO-APIC edge triggered
interrupts seeing an inconsistent RTE or IRTE when injected while being
migrated.

It's currently RFC because some patches have post commit message notes,
and because I'm not sure if patch 1 is really needed.  I originally had
the idea of suggesting to only backport patch 1 in order to fix the
issue in older releases, while leaving the more complex (and thus
error prone) IOMMU changes in unstable.  Note however that patch 1 is
just a workaround to prevent interrupts seeing inconsistent entries
while being updated, masking the entry just makes the warning go away,
but the interrupt will be lost.

Thanks, Roger.

Roger Pau Monne (6):
  x86/ioapic: set disable hook for masking edge interrupts
  x86/ioapic: add a raw field to RTE struct
  x86/ioapic: RTE modifications must use ioapic_write_entry
  x86/iommu: pass full IO-APIC RTE for remapping table update
  amd/iommu: atomically update remapping entries when possible
  x86/ioapic: mask entry while updating

 xen/arch/x86/include/asm/io_apic.h       |  72 ++++++-------
 xen/arch/x86/include/asm/iommu.h         |   3 +-
 xen/arch/x86/io_apic.c                   |  81 ++++++++++-----
 xen/drivers/passthrough/amd/iommu.h      |   2 +-
 xen/drivers/passthrough/amd/iommu_intr.c | 115 +++++++--------------
 xen/drivers/passthrough/vtd/extern.h     |   2 +-
 xen/drivers/passthrough/vtd/intremap.c   | 125 +++++++++++------------
 xen/drivers/passthrough/x86/iommu.c      |   4 +-
 xen/include/xen/iommu.h                  |   3 +-
 9 files changed, 195 insertions(+), 212 deletions(-)

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:22:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:22:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310172.526872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWl7-0006Df-AM; Thu, 21 Apr 2022 13:22:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310172.526872; Thu, 21 Apr 2022 13:22:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWl7-0006DR-5p; Thu, 21 Apr 2022 13:22:09 +0000
Received: by outflank-mailman (input) for mailman id 310172;
 Thu, 21 Apr 2022 13:22:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhWl5-0005Gk-DJ
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:22:07 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0810eb34-c176-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:22:04 +0200 (CEST)
Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 09:22:02 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN7PR03MB3649.namprd03.prod.outlook.com (2603:10b6:406:c9::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 13:22:01 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:22:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0810eb34-c176-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650547325;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=CWJ3gYXTvrTAejdEzgkAoSP58R+z0deJo29UzhQr/fI=;
  b=DqMGwY7BH7Xu3wpefUB3/3Xd5/BwD5Y7nxYdgfusPwdk465TFyA2yCB2
   iP6c4Gxs7tX0YKvpi7TlMS3nxV3IeVNY0HpWWL+RhifHHBBvxUPQ7rJX9
   fXtgXG4QUrAIdo2BAJ+Z4Y0UDzTgN12q1v8PKRoQRrVV6GNEDIQZY3ipj
   E=;
X-IronPort-RemoteIP: 104.47.55.171
X-IronPort-MID: 69007247
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:GH0sHaIDsVV6C8DTFE+RpZQlxSXFcZb7ZxGr2PjKsXjdYENSgjwHz
 zdOCDqDPPeKN2r9ed93boS+8E0EuJ/XyYVgHlZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQx2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 O1AhLKOaCEPArHJscQNCzNjDTp3MrITrdcrIVDn2SCS52vvViK2ht9IXAQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM2FGvqTjTNb9G5YasRmB/HRa
 tBfcTNyRB/BfwdOKhEcD5dWcOKA2CinK2IC9A39SawfxnXKzDIv85/WIv3TR9m6ZJlOvHy0n
 zeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuzh1O6WtlfA
 1cJ4Sdopq83nGS0SvHtUhv+p2SL1iPwQPJVGuw+rQuLmqzd5l/DAnBeF2EYLts7qMUxWDomk
 EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqTJjq/OMZZVuHIJAw=
IronPort-HdrOrdr: A9a23:+adrA6D/jRhC9MTlHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ++xoX5PwO080lKQFmrX5WI3PYOCIghrNEGgP1+vfKnjbalTDH41mpN
 hdmtZFebrN5DFB5K6VgTVQUexQuOVvmJrY+ds2pE0dKD2CBZsQjDuQXW2gYzBLrUR9dNMEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfXHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+06VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qY5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 129lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ9o+a87bWPHAb0cYa
 lT5Jm23ocUTbraVQGVgoBX+q3jYpxpdS32AHTruaSuok1rdT5Cvg4lLfck7wY9HaIGOud5Dt
 v/Q9RVfcl1P6krhIJGdZA8qJiMexrwqSylChPgHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou
 WKbG9l
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="69007247"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TgqzFhEMb3REGoM5kPrbozRoN85IkOtykfZYj8C7oQAu+5a3oYhQmH9wUu1eeoTwnVfpGUhMil389n7hHAyReAJFyQvxb7Sj8A9XnHMee3G6aRZC4gcYhGXpeuyB3pz4GV6jFKseQCdWnsbE5IpS83kKre/RYoY4IsupwtebnMPWhfAW+nagQjS1NU/kPe5+5PvJ2ekvfCbZ6To2/+kAczW9rYbCLKsU8vJh3CJjwpzRCqghAYouZ9sV3Dn1F0K4qFcyUSBiODcX1q6aTyakAbeBbcCMwj78VLGyP3tUT3dUJEeZ7GukrRKQyHcTWZh4NcqtPX2c7tlrP2Xvvd8J/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fxFBazBOOa4h2EtJ6XIkMMGyor8r9knW0X4Tj/Qkz/w=;
 b=GXC7Hli8iMEYg4R+juHO5HSGW04cb2/O9XFja9NrOOTLnoBHLo3vhXufa7jWF1x0Rhe93RrgBWClcCOVrSO6UZCkLJKakFBTLQ9RfUB1PbFjpxuFhicHMrIP/H5xImTm28XgA5s6dl/fPCoeAZYMJ/VC62Fi4AYn//mvc4yiDT2J1RGeiaByiKOOaeDv9cKPwOpQx2r6aMdehJXa65rgI3I2X9t760evXnI73VFQa5ZQuJ6tU0Ztg0yU2Wtm6Wj7aYgy6EhCJ99+fKqnlHkNj+lHo4XD22R52rBKwlWCdbTslerdDRi3YND1wOrkAKoB87hiwG3afGoRcaSLu3C3gw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fxFBazBOOa4h2EtJ6XIkMMGyor8r9knW0X4Tj/Qkz/w=;
 b=pxPZZwsIJEHX4ag+xFGuRqtcRAC73Flpvb1vt5nRD9c4zJmNMuyt3ymaI56DkUtGR/ib8JKG2yEetq2hKQnaRIFf9MCvcnfDTty0Jh2CO+sKLwYya1PnCTYJ0e33zQQUWmG/G6dXr3Pgd8zfRKsuJ+BhIiiGsxyMq1+ANf8g05w=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH RFC 3/6] x86/ioapic: RTE modifications must use ioapic_write_entry
Date: Thu, 21 Apr 2022 15:21:11 +0200
Message-Id: <20220421132114.35118-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220421132114.35118-1-roger.pau@citrix.com>
References: <20220421132114.35118-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0094.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8fc159d7-4677-41c1-b0fa-08da2399eb40
X-MS-TrafficTypeDiagnostic: BN7PR03MB3649:EE_
X-Microsoft-Antispam-PRVS:
	<BN7PR03MB36492E595859797E3D28CD4C8FF49@BN7PR03MB3649.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	E5TsDMUE/03yaWqirUV8gPSNx13m1xR5/GWs/twknhLFj2g0HdqAlZkWkMIYCMnRlG8gQjAHAfMqGDHXz4tOYrPtOqnuapoyadmFjSuoS7kE0T8ItUJovz/qg6c/ySrawLeAtXthXdlri57GoivJxCyHQxdkuGFy/oEz+JKXU7HZyca3gmy4HIR0Ft82r0ZqfxYV+RYcuAsmcim4D6c1Sd5BD5LrpC/+qkmlg2Fb7up95npII67k6dKdRwAG6GAsoNxPDnjhPihjXCuK+eDlWxrftfaxb1EcNklcoN4PS+VGfYxKVYOtZb+5NaeHXkielLi6N/k+RFiMuQ0U64b4YxTYrQy1WV7cT7Xv9dpnSSHLDVlamI5twMK5j7fQx5yYAUNTUm2EXsbMfc4mTaC8xJle1/V/hJnynytPtIpof6Q/0B6s9iq14D0suVC4XSlryLRo39c7k4edvQzv+mIyAH4j5MObhhUlRWfDnvRD/Hojy3XLaqAOCMgPk7VjD0DXSOHt4fR/UA8TqoS0CSVfgY03qZExo3wmcG5HEVXwMlVGMc7CMp9Z+FM6Zl9WmRbxOuytbA459UUmw4Pv7rRABnmbiAt+inekpGGTagykGdR+yHGJLQGM6x1ujIDKwGOVpvN9kct1wHvY9n+Ui+hsYQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(6666004)(1076003)(6512007)(316002)(26005)(36756003)(54906003)(6916009)(2616005)(2906002)(6506007)(8676002)(4326008)(83380400001)(38100700002)(82960400001)(8936002)(66476007)(66556008)(66946007)(86362001)(6486002)(5660300002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SFU1WmQ3WStZWnlieDRuSmNYYjNyV2p5K21NVWdTemhGdXBPbjhjSHRzOEVR?=
 =?utf-8?B?YmFvdHFDQUd3K3J3SlptN3dqTUZKbFBJQW80RVZoRndCMDJ4QmRUVGVmNVhX?=
 =?utf-8?B?YVYwOHNjUEprajJJbzZVYVRXdmhtVE9iOTVlQkt3OWlLZStyaU1DTEZFU0pR?=
 =?utf-8?B?dStTWnloSkJkdFVGN2dBaHFMS20rdXpZWlFlcU1uaCtkQU9FZ2psaVRCMGh3?=
 =?utf-8?B?YmVZYkE5clNsVWMvbFBQSjJXUUVPVldhRmRWWXB4dFJtZHBCOXVwNVBvb1JN?=
 =?utf-8?B?cVVJeEl4NzN3M3M1dXVQMTF1MWRtWG94UHZzc01panZSUEhieno1bDNUZzJD?=
 =?utf-8?B?cGg2dXRJWXBVakhJWTVwQzQ1UmdKMzNLQ2VpVHBQM3BBQVhyUnRXV25BZ283?=
 =?utf-8?B?V0tZdUUvOGdvdTZna0RQd2VoY0tETzFyS25HSWFmNzlqNk5EaTgvTERhYXlM?=
 =?utf-8?B?bHJkbXJTbjhTWGM2TWVPejh1RW9PYzJQZHF1UlVMZUp5VjdRT2ZMb1IySGtB?=
 =?utf-8?B?L20wVU1pb3A1MFdnVFljZXY2ejduOXg2Y3MvOVQ5b3JkamE5KzdZQlVlNmFk?=
 =?utf-8?B?WmZsdEJNNWErZllZRDdLY3B2eXRDbkxhOE1mNk5aV29zY2VZWS80WUtIeFJl?=
 =?utf-8?B?anc2dStPb1NLZXpSYTZCT3ZXSzRCdlJnZmt4aWVTcEQ1V1BacUovT1BZS0E0?=
 =?utf-8?B?cENONDc0d1BHZnpGL2t3Vy9tcTQ2VlZuYmFzSk1VOE9hU0RMcFBnRXRuUWh4?=
 =?utf-8?B?SE9kVGM0NG9sbmgwd000RmZkYUpwaE9nMHg2WDh1cGc3RXMySEhBRlQ1bHhW?=
 =?utf-8?B?WDlzRGxqT0xBc1NrVHN1T1F2cjJOb09MaFY5TXZRcGdVK3pOOVRKTStYRU9y?=
 =?utf-8?B?V0RWd3hzcUt0R1dyekZOZ252SDFBdDYyVE41YjFjZkVYNVViekl6MU9lblRj?=
 =?utf-8?B?N29IOCswMldJTTA0MWx5OFJtdjRHdmFXS1pwM20yTEJabGRPSFVNY1dHL0ZI?=
 =?utf-8?B?bUdNTkVzbmVtNE5kTFc5ZHh4Zis3MGhrVk9kdTlaQWdhVC9tbnRmM001RjlY?=
 =?utf-8?B?YmpXL0I3UzRTcUdWeXVBUGI2QUpBeWpOaWlrY3ZwUFhOd0VmemlITFdUc2Fs?=
 =?utf-8?B?RjdJNjljeStOdm0zMWNZaWF1eGt5dzYzMXJrU1UwVVhwUU9TN2pJRFNvT0R0?=
 =?utf-8?B?b3ZtbXlDM3ZncWoxUzU0d2F0K3prTFRLaDBhTHVWREFXTHNWeldKczUwM2VF?=
 =?utf-8?B?Z3FPSGdFUGE0bmQ3aWl0WlZjNllTY1NBcEJZTFl4ZlFVUDNySUxMSGxiOW5L?=
 =?utf-8?B?V1hoUitseXNXclZrcFIzcGJIQi9qRHlQYW1wYWhlRW9NUkxMSkJzYzVnc05q?=
 =?utf-8?B?dFR5d2lYMmcvekc1TVV3WUd0MG9YTXAwb0JMVkloZXh0cGpXWGNVbHlXUGZE?=
 =?utf-8?B?eEw1VUQvMkVxRkdPbERqRlFTemRzNTdhTnNZbi92eVBtWXFKaGdHM2xWWTQ5?=
 =?utf-8?B?ZnhjZk5KVDZvUG9LeGhoMVg0WW10VldWYXhTY2tMZlNEVmsxNU9aditOK3E1?=
 =?utf-8?B?RFBGcWhYUTVqa3l0aHV4eXdQelY3YXQ3ZzN3OVdVbXYxOTk4TjREK0FIQ09u?=
 =?utf-8?B?QWYxMDZBdEhobHlnTDlRZWdOckhBTHB4dFhkdUlxQzh4YVd6MGJ4Q0k2SDhl?=
 =?utf-8?B?M3hlY0VSYWlXM2FtSVl0eFdJckNGM2QyRHJKQ0R5ekZhVkNrVmpsdjh4d1V3?=
 =?utf-8?B?ZEZxUlE1ZSszK0NuQjkrdCtYd1JYNzNsVDIwVGt0MW5hemJlOS9zRCt5aFhi?=
 =?utf-8?B?VHdGaXd4TDlYTWVrTkV3V0dIQ2ZhYVl5OWFXUmdjb2xOeVJJYWtjM3ZFUGJq?=
 =?utf-8?B?bWRQc21iM0t3cEF6MSszOElveFdrR3lZN0JOTGZSd3U4VHVSanliWERhYW5i?=
 =?utf-8?B?M3hlVXdhY05QQ0RkZkQvUlJWTndEV3hrVE1PWUJXZFlTQ292TFJuSmlKUmZp?=
 =?utf-8?B?VXBmMzVIVmdjM05QeWRaaTFjc2svc2pmeGpRcGdXays0emV6SkVSR2pPcWlZ?=
 =?utf-8?B?Znd0WUhpY2tLV3paQms3ZzNNWDN4ZGlDcDRDd3VjR3YyUDNXTmZaTjhYMlQ0?=
 =?utf-8?B?Mmx1K1dSZXVmYXJDRzBza0MzbHdWMmZ4Q0FLdFNmWElESFJHaDJkVUxpV0ky?=
 =?utf-8?B?ZjA2RFhFRlRFb3hyc0ZkbXJJM2p5RU5KeEtETG53Z0ZIV0ZSVC94d1hVeGgr?=
 =?utf-8?B?b0wyQjU1LzloZElVRjU5Z0NrVXdqNG5kRFp1TkphclVOTFhTaVZRU2dFRE9s?=
 =?utf-8?B?NWhTS0pSZVU2Mld4VXVUZitXVVpIUVBEVmMrR3dZd1hKTjFqMWxEeGJZdVVG?=
 =?utf-8?Q?OARvAP5s0nbB142s=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fc159d7-4677-41c1-b0fa-08da2399eb40
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:22:01.2387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zqh+wgA+9lhq4jDd+rqVijPthwzHDjzLTvxyfLlEP4eFq7aBzPCQzaxTm421EPDuAojSPuKeR+N0P3ZKdT95Bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3649

Do not allow to write to RTE registers using io_apic_write and instead
require changes to RTE to be performed using ioapic_write_entry.

This is in preparation for passing the full contents of the RTE to the
IOMMU interrupt remapping handlers, so remapping entries for IO-APIC
RTEs can be updated atomically when possible.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/include/asm/io_apic.h | 15 ++----------
 xen/arch/x86/io_apic.c             | 37 +++++++++++++++---------------
 2 files changed, 20 insertions(+), 32 deletions(-)

diff --git a/xen/arch/x86/include/asm/io_apic.h b/xen/arch/x86/include/asm/io_apic.h
index a558bb063c..c26261aecb 100644
--- a/xen/arch/x86/include/asm/io_apic.h
+++ b/xen/arch/x86/include/asm/io_apic.h
@@ -161,22 +161,11 @@ static inline void __io_apic_write(unsigned int apic, unsigned int reg, unsigned
 
 static inline void io_apic_write(unsigned int apic, unsigned int reg, unsigned int value)
 {
-    if ( ioapic_reg_remapped(reg) )
-        return iommu_update_ire_from_apic(apic, reg, value);
+    /* RTE writes must use ioapic_write_entry. */
+    BUG_ON(reg >= 0x10);
     __io_apic_write(apic, reg, value);
 }
 
-/*
- * Re-write a value: to be used for read-modify-write
- * cycles where the read already set up the index register.
- */
-static inline void io_apic_modify(unsigned int apic, unsigned int reg, unsigned int value)
-{
-    if ( ioapic_reg_remapped(reg) )
-        return iommu_update_ire_from_apic(apic, reg, value);
-    *(IO_APIC_BASE(apic) + 4) = value;
-}
-
 /* 1 if "noapic" boot option passed */
 extern bool skip_ioapic_setup;
 extern bool ioapic_ack_new;
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index 2e5964640b..3a5e3b7872 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -269,15 +269,15 @@ void __ioapic_write_entry(
 {
     union entry_union eu = { .entry = e };
 
-    if ( raw )
+    if ( raw || !iommu_intremap )
     {
         __io_apic_write(apic, 0x11 + 2 * pin, eu.w2);
         __io_apic_write(apic, 0x10 + 2 * pin, eu.w1);
     }
     else
     {
-        io_apic_write(apic, 0x11 + 2 * pin, eu.w2);
-        io_apic_write(apic, 0x10 + 2 * pin, eu.w1);
+        iommu_update_ire_from_apic(apic, 0x11 + 2 * pin, eu.w2);
+        iommu_update_ire_from_apic(apic, 0x10 + 2 * pin, eu.w1);
     }
 }
 
@@ -433,16 +433,17 @@ static void modify_IO_APIC_irq(unsigned int irq, unsigned int enable,
                                unsigned int disable)
 {
     struct irq_pin_list *entry = irq_2_pin + irq;
-    unsigned int pin, reg;
 
     for (;;) {
-        pin = entry->pin;
+        unsigned int pin = entry->pin;
+        struct IO_APIC_route_entry rte;
+
         if (pin == -1)
             break;
-        reg = io_apic_read(entry->apic, 0x10 + pin*2);
-        reg &= ~disable;
-        reg |= enable;
-        io_apic_modify(entry->apic, 0x10 + pin*2, reg);
+        rte = __ioapic_read_entry(entry->apic, pin, false);
+        rte.raw &= ~(uint64_t)disable;
+        rte.raw |= enable;
+        __ioapic_write_entry(entry->apic, pin, false, rte);
         if (!entry->next)
             break;
         entry = irq_2_pin + entry->next;
@@ -584,16 +585,16 @@ set_ioapic_affinity_irq(struct irq_desc *desc, const cpumask_t *mask)
             dest = SET_APIC_LOGICAL_ID(dest);
         entry = irq_2_pin + irq;
         for (;;) {
-            unsigned int data;
+            struct IO_APIC_route_entry rte;
+
             pin = entry->pin;
             if (pin == -1)
                 break;
 
-            io_apic_write(entry->apic, 0x10 + 1 + pin*2, dest);
-            data = io_apic_read(entry->apic, 0x10 + pin*2);
-            data &= ~IO_APIC_REDIR_VECTOR_MASK;
-            data |= MASK_INSR(desc->arch.vector, IO_APIC_REDIR_VECTOR_MASK);
-            io_apic_modify(entry->apic, 0x10 + pin*2, data);
+            rte = __ioapic_read_entry(entry->apic, pin, false);
+            rte.dest.dest32 = dest;
+            rte.vector = desc->arch.vector;
+            __ioapic_write_entry(entry->apic, pin, false, rte);
 
             if (!entry->next)
                 break;
@@ -2129,10 +2130,8 @@ void ioapic_resume(void)
             reg_00.bits.ID = mp_ioapics[apic].mpc_apicid;
             __io_apic_write(apic, 0, reg_00.raw);
         }
-        for (i = 0; i < nr_ioapic_entries[apic]; i++, entry++) {
-            __io_apic_write(apic, 0x11+2*i, *(((int *)entry)+1));
-            __io_apic_write(apic, 0x10+2*i, *(((int *)entry)+0));
-        }
+        for (i = 0; i < nr_ioapic_entries[apic]; i++, entry++)
+            __ioapic_write_entry(apic, i, true, *entry);
     }
     spin_unlock_irqrestore(&ioapic_lock, flags);
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:22:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:22:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310177.526883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWlE-0006ut-RX; Thu, 21 Apr 2022 13:22:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310177.526883; Thu, 21 Apr 2022 13:22:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWlE-0006ui-N6; Thu, 21 Apr 2022 13:22:16 +0000
Received: by outflank-mailman (input) for mailman id 310177;
 Thu, 21 Apr 2022 13:22:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhWlC-0006Vx-D9
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:22:14 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c927209-c176-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 15:22:12 +0200 (CEST)
Received: from mail-bn8nam11lp2171.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 09:22:08 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM6PR03MB3771.namprd03.prod.outlook.com (2603:10b6:5:4e::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 13:22:06 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:22:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c927209-c176-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650547332;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=7YRqHDhmiB+IydPusKoIgSDWAyO7QgBP+ELxznFDh5c=;
  b=JmIhSHxlm5qiBSlCKzebWCHqqMSLBEsut4GX5tUyCrnTnyWyd5w9ak4m
   mGbcRC/ZLKGlTMH0W/naa3FfLdw/c4wUlUVtYHRpo0vZ0GLK6vaeHJYxk
   k96n6cHoPSnXTKpDvc4iBiUlUPcwc/TuQ7/sH7gXrFLn6heOaHkppiSQJ
   c=;
X-IronPort-RemoteIP: 104.47.58.171
X-IronPort-MID: 70011025
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:8RXj2q4tLis4+CHsbRL/UAxRtCjGchMFZxGqfqrLsTDasY5as4F+v
 mMeX2GGbPeKMDbxct11bIm/9xsGuZKGm9FmGlQ5+H81Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjWlvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSXZTZyGIbPx90MCR9JSw1DJ6JD/+H+dC3XXcy7lyUqclPK6tA3VQQcG91d/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YHhV/chegXdRraT
 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA8AvM/fBqi4TV5F1IwprGG9bnRtehXZRxn0rE/
 334oU2sV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL
 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJ4EOAk6QfL1qvd5S6YAHQJSnhKb9lOnNc/WDgCx
 lKP2dTzClRSXKa9THuc8vKeq2O0MC1MdGsaP3ZbFE0C/sXpp5w1glTXVNF/HaWpj9rzXzbt3
 zSNqyt4jLIW5SIW65iGEZn8q2rEjvD0osQdv207gkrNAttFWbOY
IronPort-HdrOrdr: A9a23:+a/K06MGtWJsGcBcT1z155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBDpTnmAtj5fZq8z+8N3WB1B9uftWbdyQ+Vxe1ZjbcKoAeQZhEWiNQtsp
 uIGpIWYLOQMbETt7eB3ODSKadE/DDoytHKuQ+IpE0dNj2CJpsQmTuQTW2gYzxLbTgDIaB8OI
 uX58JBqTblUXMLbv6jDn1Ae+TYvdXEmL/vfBZDXnccmUGzpALtzIS/PwmT3x8YXT8K6bA+8V
 Ldmwi8wqm4qfm0xjLVymeWxZVLn9nKzMdFGaW3+4EoAwSprjztSJVqWrWEsjxwiOaz6GwymN
 2JmBskN9Qb0QKlQkiF5T/WnyXw2jcn7HHvjXWCh2H4nMD/TDUmT+JcmINwaHLimgYdleA59J
 gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kNQUk2dUXeIlGfJsRLQkjQ1o+ao7bWPHANhNKp
 gvMCic3ocdTbqiVQGXgoE1q+bcHUjaHX+9Mzo/U4KuonprdUtCvjQlLfwk7ws9Ha0GOud5Dp
 z/Q8JVfZF1P7srhPFGdZA8qfXeMB28fTv8dESvHH/AKIYrf1rwlr+f2sRH2AjtQu1C8KcP
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="70011025"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yz8tz8/wYqnSSm2dd+E14l3meHqH+KAgQeatEidikiTeuMqdD3ItGR43OSSV2J6wQRQk7LhI9zoacsGtz3lQjjyM/LBwwbq0LQM3T5mhWS+SDIJo3f9HCbHgA/6r0Wuc3YmES/MUxsJm+Ozdw26BHphYE5u8ktSgCIlocx5fj9zsilotpSfKIaTzzSTehpJb8s6rRml9mDwLXjoRmGrp+zD/f7swEVEyzAoIAAajovOrfKTFy0x5CIYGHF4tcQTRK+QcdoySndS7MAmCWA487UoEh1vYgJdO8lxJrMw9a6QHrUEaazY1PoMPd0OUYdoj2OAtwvu0MZFTlO45jiN5TQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FOHBZEpDF09Hk8lNie+2sWfpJc6zb8jWHm0gVWptEBg=;
 b=FnaorujnPZQnF7NWlwqXyTvDuVwOd/BVXzGjkUUp6JKqNkfwaj7MXSNB/mtrIZuAAwiUIsjqCLD7ywk80tA7E27ltEMcRdxD75u0/gD57wkSoBIjaaeXgIahGIghI8E5ANUh/98RxfRlGbUF3po/KoveHOeS3Gzcizcx1eQaCgJxXHw0Xpd4bH9uQHSkMmMbw+AMviWE6bfBXiYrRQONu2DJk+vJiUZcVJtZDp+In1ryrfnOgDlUqwZVnZNJU+F11uX0VUP4DZ4IPa1O3MksTdjLZSvsYMGHJrcMhntC51f6FeCEnTBBYzmTt+1uQ/v056NOn+ClqELz73xMquKEHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FOHBZEpDF09Hk8lNie+2sWfpJc6zb8jWHm0gVWptEBg=;
 b=xctScZo3c4pVpyBuWmLr8XkWnV2xokWr9gqyXejnuejkrRtG20NicwpTD7vG5vMcfYY5zL9ZurLs7gEP4i1lV85Y2xHIEZGP2o+KNPiBm1SE3kk9VLdodciFFjWo4HFGoY6JKUgNRAELLZx5sUnYLUWSaZBvj96DRGE7MvI61K0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>,
	Kevin Tian <kevin.tian@intel.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH RFC 4/6] x86/iommu: pass full IO-APIC RTE for remapping table update
Date: Thu, 21 Apr 2022 15:21:12 +0200
Message-Id: <20220421132114.35118-5-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220421132114.35118-1-roger.pau@citrix.com>
References: <20220421132114.35118-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0082.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4e04b4fd-75a6-4d76-19b7-08da2399ee05
X-MS-TrafficTypeDiagnostic: DM6PR03MB3771:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<DM6PR03MB377123953A733FA3A6F4068C8FF49@DM6PR03MB3771.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gdR8h9qMAnOoKhH5lTxbtJ1I1ck2zoVcA0v0GL9WbW9JAG1Wu6IGNHTBTeLcMMZzDlCIzTkW7SMOrEghwq8H1FCmTShASSM9zDC1mKrAx2PSK+xmtIDSnfXIp/b0cDTZFuHmsxgb7Td3iKkkzQQIDTM57LDGwzg3dfQoaRc7bp+jik/fUDIcQ6ICI98OBEe0pUX5mjdFEC8PtaiyTVyxFtIG2ecKptEyd02gPRENLKDk1nBTIcVWm6htkWV8JOesPOfiKOV/QHo5No+BapHMQNliDDhs7O/l1tXrUTmGAFMBheInux6a5WX1Daupo6NaL1TOEJiHLhmZSv7FM+76f4lE1whxqQhJt9JNWfUqeQUL/hkDZil46EA6TxMcGotwGGzxcNVj1y4UDsB6yeVrS++DQ/GeeITqcGOsamWrTEaPSyce6E67R+Eufpgd0b/p/faI+DlbdAiUc46ivHBCYlqk4XyXkQAwinKS1/f86Y6Kqf1P+zxBfu6BlvWaTUOrKxgMEcJIY5OGFYgq5c4U3Rj3ko0XbHKnRaHoM8poLGhW/bURBSY7FX3nW2hrdcIFEp/mEjAu3RTugYj6axo95lHZzlYwzQS4aU3hwJ9hZS5E9LNeim2X0VxStxYvxnD36vgNaa0mo5VgkHQJVVwmgg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(82960400001)(316002)(186003)(2616005)(26005)(5660300002)(30864003)(83380400001)(2906002)(6512007)(4326008)(8936002)(15650500001)(66556008)(6506007)(86362001)(66476007)(38100700002)(1076003)(8676002)(508600001)(54906003)(6486002)(66946007)(6916009)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NGducFVjd2pvbGIvUFJSYTV6Q1pnWHpXekN1Slc3UkdJWEFXRDh0OERncXBu?=
 =?utf-8?B?a1dXRW1TcXVYcGc1dVVxZW9NN2toOWNiYjBvelcwcFZiUmFjLzVKMmdwcHFS?=
 =?utf-8?B?VkZ0b2s4T00zY3huOGl1Y2RBalpHL3pFSWh1cFNVTUdXN2tHUjJ1KzU5aVdU?=
 =?utf-8?B?dG1nTVhHRUR4WnQyOG1wVHVvYVpjK2hUNDYzMWsxNHJEbThQRDZQaUZ5MW1H?=
 =?utf-8?B?dEJmbnpJelZWT2JmQ3A4dlBrcXMxaGFGYUxsWWE1dlZNYmcxRFF4T1E0a1RR?=
 =?utf-8?B?ekZ3eFpaNHZYdHFWR0JFWjJVV3lJWU85R1hUTFVDWEFWNnQ0SjZ0WHpGV0V5?=
 =?utf-8?B?MDMwL0QvOWxrcGFSNG16Z3BGSTNNcUhxbEdTNFoyZFgwbmdPYStSTUhnZjV1?=
 =?utf-8?B?MFREaUt3Mno3Y1BiSE9kdnp3L2RMR1hqSzRlcmF0SzZRbkowRXpwNUY1WmRK?=
 =?utf-8?B?SlcxazQwUDN4WTgzc01HZHkyUkd4QWhtUXAvTmx6akI3aFJIYkpyanJWRE4x?=
 =?utf-8?B?VVZnWDA2Y3BySDlEV3NzK2twVGZGVVZDcjFXcDk4Y1NpRTI1NmtpRUE0ZW91?=
 =?utf-8?B?cDFjcktZOWJnVDFCTjZRZXU3cWlyV0lONkxuR1IyQ29HMU02YkoxaUY0NDdl?=
 =?utf-8?B?dWMxbGtNMDFELzg1dkRHNU1zVDF3OE5FSWRmL0xSUS9sTEdBOURyYVVYK2JH?=
 =?utf-8?B?RFA1bzBtbWdCR010b3RuTVJnUkF5bi92cU5hdFhWUVZMTlAyM0src3I1RkJi?=
 =?utf-8?B?bjN0Vy9wRTJKZHI2UUhJcFpFUFVwT2ZjekZyemYvWjNROW55RjEwQTBLZGpH?=
 =?utf-8?B?RTVFclJVU3lGMEpmSDJlcTMxZVY4UXZHRDF4Qy9OaE05TzJIblk1Y3E5em1y?=
 =?utf-8?B?dWVqWVROZGpmb1FzdHpYSnNBMkpqYXhJT1hDY2FWNzJiM2Y5UU1xcjZsNjlh?=
 =?utf-8?B?ZVRVUllVbzR3U24yQVVuSGsxajNVS2xhMTFsVzVYUkl2VlZsaU1DNmMxMlJZ?=
 =?utf-8?B?SWE3T1ZXMFhrb2JxMmszMjRENzNmdXVSQ2kzNVMrY3ZUU2VObkpvRTYvK20v?=
 =?utf-8?B?R2FrcHhYYmN4SzllZmlVbVRoeG5ndTNBZGZnaGd0RE5SQWFBUEZNYlR6UkI4?=
 =?utf-8?B?aTY4UTBDOFVoSFRhVkJzZzJBMHEzdGF0MGl4RzlXOW11Qjh5N21VQXBrdzk1?=
 =?utf-8?B?Q1EzVUVIcm5XVmJPUk45VTA0dS9KQnZyRzFtaU54SWhqYWN5ZTdKVktmVHBn?=
 =?utf-8?B?MDJpbmExdk9PTGk0WEMwaGZrYU1GcG1yYnpidWJZd1ptenpOd0p1cE5EWm9I?=
 =?utf-8?B?amtNMmRCc2ZvOHFUZk42TUtWWTJnWXRLS3A2RjlhMlJMN3FRYllBU2F0dGE3?=
 =?utf-8?B?aTNIUWdSN3JBTUYxUlJuM1FFcDlEWEdaT0VEc3hrQXMxQnBic2hTOXo4Ui80?=
 =?utf-8?B?dVlFVWdDbmdjOWpDU0U0aXk5NUdDZ1FuakxqZFUxV1o3N3lZZ2RqSTRuOGxC?=
 =?utf-8?B?cDF3T3NBOEhiaGNZblhoYTBHS0JxZmppMy80WWE1bGpTQzQ3ZGY3bW1KNGky?=
 =?utf-8?B?MlhrczhDSnZHT093dHNjdWNhaThNYXRPWW5CM0puT0V3dzQ0SzB0SEdkNGxq?=
 =?utf-8?B?QWwrNERLQ1lkOGJZUkVWTGlxcDIreStYQlVXY2xaeWlERms2MGpIektBT0VL?=
 =?utf-8?B?VENhOWtSbkpRNTlMY0wvcTVQZU9XakJQS3hVTXVXdUlXZTdTSWVjZGVUZ09B?=
 =?utf-8?B?eVRCRGQwR2lsTkk0QXkxdHdoaG8vT3E3UmlmSHk5SmIySUloZERZTUdwZC9k?=
 =?utf-8?B?VkFGS21uZ0hzRklOaVhDcDllZkdwZzJuZ3NIOGU0R0FmdG1Wc2Y3TlJ2Vitl?=
 =?utf-8?B?MmFPU1JoemNzb1ZzcnpZWUg1VFdTMkd4SmpNUE9UQ0JQSWxLc3BJRHRScDNj?=
 =?utf-8?B?Z1RScGdORVBLU3h6QUZoekRBbmVuaFpjNVRKL1lzSGU5OVBSQjVDckUvWnNr?=
 =?utf-8?B?L3NIdG0zbWRtQTBYZDRsS0lUeW9USVdUSlFMQTJvN3BFQkNtYlEvbWpERmow?=
 =?utf-8?B?a0lJK3dDTjBWUlQzeDdaTmhlbmpTSnB6YWRyYmU5eU5OVmFhNHZraXVXZlR3?=
 =?utf-8?B?QTVFSWljOFc3bHllUU4wQ1Bhemw5ME40clIybUk0VmZrakxOazRDOExlVVFl?=
 =?utf-8?B?RzJ2YkF5QVU5WGdDV1k0eXU5QXlSZmU1UWMweGcraFZxZklpaGpoQnRmdDNG?=
 =?utf-8?B?S0JFeGxuNnlMVkZBQytGcVNVSU1JNE9SMlhKQVBmWXlCVitpZklZd3lnSEM1?=
 =?utf-8?B?MWtJMTk5WDBOMlFLNHBweFN2SDdOOHUrQ2Z3OXI0N0ZFUXdaVWRNTjZwLys2?=
 =?utf-8?Q?cVRTUMYM8/KvkQ7I=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e04b4fd-75a6-4d76-19b7-08da2399ee05
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:22:05.8188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W21p7AyHntu1s7JnHXiU7DvFDxMC9fPryBvgwLWJuPagKFGoNj0f+kmPR0aC3SpXlPjiSWxgBLoMi41sxefL6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3771

So that the remapping entry can be updated atomically when possible.

Doing such update atomically will avoid Xen having to mask the IO-APIC
pin prior to performing any interrupt movements (ie: changing the
destination and vector fields), as the interrupt remapping entry is
always consistent.

This also simplifies some of the logic on both VT-d and AMD-Vi
implementations, as having the full RTE available instead of half of
it avoids to possibly read and update the missing other half from
hardware.

While there remove the explicit zeroing of new_ire fields in
ioapic_rte_to_remap_entry and initialize the variable at definition so
all fields are zeroed.  Note fields could be also initialized with
final values at definition, but I found that likely too much to be
done at this time.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
There's some functional differences between VT-d and AMD-Vi that we
might also want to address: the logic on failure from setting up the
remap entry on VT-d unmasks the previous RTE, while on AMD-Vi the pin
is left masked.

Note that certain combination of changes to the RTE are impossible to
handle atomically. For example changing the vector and/or destination
fields together with the triggering mode is impossible to be performed
atomically (as the destination and vector is set in the IRTE, but the
triggering mode is set in the RTE).  Xen doesn't attempt to perform
such changes in a single update to the RTE anyway, so it's fine.

Since the IOMMU code now also uses __ioapic_write_entry to update the
RTE it might be helpful to introduce an explicit raw version of the
function, as IOMMU always wants to write the provided raw value to the
RTE.
---
 xen/arch/x86/include/asm/iommu.h         |   3 +-
 xen/arch/x86/io_apic.c                   |   5 +-
 xen/drivers/passthrough/amd/iommu.h      |   2 +-
 xen/drivers/passthrough/amd/iommu_intr.c |  84 ++-------------
 xen/drivers/passthrough/vtd/extern.h     |   2 +-
 xen/drivers/passthrough/vtd/intremap.c   | 125 +++++++++++------------
 xen/drivers/passthrough/x86/iommu.c      |   4 +-
 xen/include/xen/iommu.h                  |   3 +-
 8 files changed, 80 insertions(+), 148 deletions(-)

diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h
index 9ccf4f8bdd..1d62b42e17 100644
--- a/xen/arch/x86/include/asm/iommu.h
+++ b/xen/arch/x86/include/asm/iommu.h
@@ -97,7 +97,8 @@ struct iommu_init_ops {
 
 extern const struct iommu_init_ops *iommu_init_ops;
 
-void iommu_update_ire_from_apic(unsigned int apic, unsigned int reg, unsigned int value);
+void iommu_update_ire_from_apic(unsigned int apic, unsigned int reg,
+                                uint64_t rte);
 unsigned int iommu_read_apic_from_ire(unsigned int apic, unsigned int reg);
 int iommu_setup_hpet_msi(struct msi_desc *);
 
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index 3a5e3b7872..f61e56f3d1 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -275,10 +275,7 @@ void __ioapic_write_entry(
         __io_apic_write(apic, 0x10 + 2 * pin, eu.w1);
     }
     else
-    {
-        iommu_update_ire_from_apic(apic, 0x11 + 2 * pin, eu.w2);
-        iommu_update_ire_from_apic(apic, 0x10 + 2 * pin, eu.w1);
-    }
+        iommu_update_ire_from_apic(apic, pin, e.raw);
 }
 
 static void ioapic_write_entry(
diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h
index 64e4bbf33c..35df504406 100644
--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -298,7 +298,7 @@ int cf_check amd_iommu_free_intremap_table(
 unsigned int amd_iommu_intremap_table_order(
     const void *irt, const struct amd_iommu *iommu);
 void cf_check amd_iommu_ioapic_update_ire(
-    unsigned int apic, unsigned int reg, unsigned int value);
+    unsigned int apic, unsigned int pin, uint64_t raw);
 unsigned int cf_check amd_iommu_read_ioapic_from_ire(
     unsigned int apic, unsigned int reg);
 int cf_check amd_iommu_msi_msg_update_ire(
diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c
index cebf9ceca7..feed1d1447 100644
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -247,11 +247,6 @@ static void update_intremap_entry(const struct amd_iommu *iommu,
     }
 }
 
-static inline int get_rte_index(const struct IO_APIC_route_entry *rte)
-{
-    return rte->vector | (rte->delivery_mode << 8);
-}
-
 static inline void set_rte_index(struct IO_APIC_route_entry *rte, int offset)
 {
     rte->vector = (u8)offset;
@@ -267,7 +262,6 @@ static int update_intremap_entry_from_ioapic(
     int bdf,
     struct amd_iommu *iommu,
     struct IO_APIC_route_entry *rte,
-    bool_t lo_update,
     u16 *index)
 {
     unsigned long flags;
@@ -315,31 +309,6 @@ static int update_intremap_entry_from_ioapic(
         spin_lock(lock);
     }
 
-    if ( fresh )
-        /* nothing */;
-    else if ( !lo_update )
-    {
-        /*
-         * Low half of incoming RTE is already in remapped format,
-         * so need to recover vector and delivery mode from IRTE.
-         */
-        ASSERT(get_rte_index(rte) == offset);
-        if ( iommu->ctrl.ga_en )
-            vector = entry.ptr128->full.vector;
-        else
-            vector = entry.ptr32->flds.vector;
-        /* The IntType fields match for both formats. */
-        delivery_mode = entry.ptr32->flds.int_type;
-    }
-    else if ( x2apic_enabled )
-    {
-        /*
-         * High half of incoming RTE was read from the I/O APIC and hence may
-         * not hold the full destination, so need to recover full destination
-         * from IRTE.
-         */
-        dest = get_full_dest(entry.ptr128);
-    }
     update_intremap_entry(iommu, entry, vector, delivery_mode, dest_mode, dest);
 
     spin_unlock_irqrestore(lock, flags);
@@ -350,23 +319,15 @@ static int update_intremap_entry_from_ioapic(
 }
 
 void cf_check amd_iommu_ioapic_update_ire(
-    unsigned int apic, unsigned int reg, unsigned int value)
+    unsigned int apic, unsigned int pin, uint64_t raw)
 {
-    struct IO_APIC_route_entry old_rte = { 0 };
-    struct IO_APIC_route_entry new_rte = { 0 };
-    unsigned int rte_lo = (reg & 1) ? reg - 1 : reg;
-    unsigned int pin = (reg - 0x10) / 2;
+    struct IO_APIC_route_entry new_rte = { .raw = raw };
+    struct IO_APIC_route_entry old_rte = { };
     int seg, bdf, rc;
     bool saved_mask, fresh = false;
     struct amd_iommu *iommu;
     unsigned int idx;
 
-    if ( !iommu_intremap )
-    {
-        __io_apic_write(apic, reg, value);
-        return;
-    }
-
     idx = ioapic_id_to_index(IO_APIC_ID(apic));
     if ( idx == MAX_IO_APICS )
         return;
@@ -379,26 +340,14 @@ void cf_check amd_iommu_ioapic_update_ire(
     {
         AMD_IOMMU_WARN("failed to find IOMMU for IO-APIC @ %04x:%04x\n",
                        seg, bdf);
-        __io_apic_write(apic, reg, value);
+        __ioapic_write_entry(apic, pin, true, new_rte);
         return;
     }
 
     /* save io-apic rte lower 32 bits */
-    *((u32 *)&old_rte) =  __io_apic_read(apic, rte_lo);
+    old_rte = __ioapic_read_entry(apic, pin, true);
     saved_mask = old_rte.mask;
 
-    if ( reg == rte_lo )
-    {
-        *((u32 *)&new_rte) = value;
-        /* read upper 32 bits from io-apic rte */
-        *(((u32 *)&new_rte) + 1) = __io_apic_read(apic, reg + 1);
-    }
-    else
-    {
-        *((u32 *)&new_rte) = *((u32 *)&old_rte);
-        *(((u32 *)&new_rte) + 1) = value;
-    }
-
     if ( ioapic_sbdf[idx].pin_2_idx[pin] >= INTREMAP_MAX_ENTRIES )
     {
         ASSERT(saved_mask);
@@ -410,7 +359,7 @@ void cf_check amd_iommu_ioapic_update_ire(
          */
         if ( new_rte.mask && !x2apic_enabled )
         {
-            __io_apic_write(apic, reg, value);
+            __ioapic_write_entry(apic, pin, true, new_rte);
             return;
         }
 
@@ -421,16 +370,14 @@ void cf_check amd_iommu_ioapic_update_ire(
     if ( !saved_mask )
     {
         old_rte.mask = 1;
-        __io_apic_write(apic, rte_lo, *((u32 *)&old_rte));
+        __ioapic_write_entry(apic, pin, true, old_rte);
     }
 
     /* Update interrupt remapping entry */
     rc = update_intremap_entry_from_ioapic(
-             bdf, iommu, &new_rte, reg == rte_lo,
+             bdf, iommu, &new_rte,
              &ioapic_sbdf[idx].pin_2_idx[pin]);
 
-    __io_apic_write(apic, reg, ((u32 *)&new_rte)[reg != rte_lo]);
-
     if ( rc )
     {
         /* Keep the entry masked. */
@@ -439,20 +386,7 @@ void cf_check amd_iommu_ioapic_update_ire(
         return;
     }
 
-    /* For lower bits access, return directly to avoid double writes */
-    if ( reg == rte_lo )
-        return;
-
-    /*
-     * Unmask the interrupt after we have updated the intremap table. Also
-     * write the low half if a fresh entry was allocated for a high half
-     * update in x2APIC mode.
-     */
-    if ( !saved_mask || (x2apic_enabled && fresh) )
-    {
-        old_rte.mask = saved_mask;
-        __io_apic_write(apic, rte_lo, *((u32 *)&old_rte));
-    }
+    __ioapic_write_entry(apic, pin, true, new_rte);
 }
 
 unsigned int cf_check amd_iommu_read_ioapic_from_ire(
diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h
index 39602d1f88..032a7c3b42 100644
--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -92,7 +92,7 @@ int cf_check intel_iommu_get_reserved_device_memory(
 unsigned int cf_check io_apic_read_remap_rte(
     unsigned int apic, unsigned int reg);
 void cf_check io_apic_write_remap_rte(
-    unsigned int apic, unsigned int reg, unsigned int value);
+    unsigned int apic, unsigned int ioapic_pin, uint64_t raw);
 
 struct msi_desc;
 struct msi_msg;
diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c
index e6ba89591b..52058efe86 100644
--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -328,12 +328,11 @@ static int remap_entry_to_ioapic_rte(
 
 static int ioapic_rte_to_remap_entry(struct vtd_iommu *iommu,
     int apic, unsigned int ioapic_pin, struct IO_xAPIC_route_entry *old_rte,
-    unsigned int rte_upper, unsigned int value)
+    struct IO_xAPIC_route_entry new_rte)
 {
     struct iremap_entry *iremap_entry = NULL, *iremap_entries;
-    struct iremap_entry new_ire;
+    struct iremap_entry new_ire = { };
     struct IO_APIC_route_remap_entry *remap_rte;
-    struct IO_xAPIC_route_entry new_rte;
     int index;
     unsigned long flags;
     bool init = false;
@@ -364,48 +363,37 @@ static int ioapic_rte_to_remap_entry(struct vtd_iommu *iommu,
 
     new_ire = *iremap_entry;
 
-    if ( rte_upper )
-    {
-        if ( x2apic_enabled )
-            new_ire.remap.dst = value;
-        else
-            new_ire.remap.dst = (value >> 24) << 8;
-    }
+    if ( x2apic_enabled )
+        new_ire.remap.dst = new_rte.dest.dest32;
     else
-    {
-        *(((u32 *)&new_rte) + 0) = value;
-        new_ire.remap.fpd = 0;
-        new_ire.remap.dm = new_rte.dest_mode;
-        new_ire.remap.tm = new_rte.trigger;
-        new_ire.remap.dlm = new_rte.delivery_mode;
-        /* Hardware require RH = 1 for LPR delivery mode */
-        new_ire.remap.rh = (new_ire.remap.dlm == dest_LowestPrio);
-        new_ire.remap.avail = 0;
-        new_ire.remap.res_1 = 0;
-        new_ire.remap.vector = new_rte.vector;
-        new_ire.remap.res_2 = 0;
-
-        set_ioapic_source_id(IO_APIC_ID(apic), &new_ire);
-        new_ire.remap.res_3 = 0;
-        new_ire.remap.res_4 = 0;
-        new_ire.remap.p = 1;     /* finally, set present bit */
-
-        /* now construct new ioapic rte entry */
-        remap_rte->vector = new_rte.vector;
-        remap_rte->delivery_mode = 0;    /* has to be 0 for remap format */
-        remap_rte->index_15 = (index >> 15) & 0x1;
-        remap_rte->index_0_14 = index & 0x7fff;
-
-        remap_rte->delivery_status = new_rte.delivery_status;
-        remap_rte->polarity = new_rte.polarity;
-        remap_rte->irr = new_rte.irr;
-        remap_rte->trigger = new_rte.trigger;
-        remap_rte->mask = new_rte.mask;
-        remap_rte->reserved = 0;
-        remap_rte->format = 1;    /* indicate remap format */
-    }
-
-    update_irte(iommu, iremap_entry, &new_ire, !init);
+        new_ire.remap.dst = (new_rte.dest.dest32 >> 24) << 8;
+
+    new_ire.remap.dm = new_rte.dest_mode;
+    new_ire.remap.tm = new_rte.trigger;
+    new_ire.remap.dlm = new_rte.delivery_mode;
+    /* Hardware require RH = 1 for LPR delivery mode */
+    new_ire.remap.rh = (new_ire.remap.dlm == dest_LowestPrio);
+    new_ire.remap.vector = new_rte.vector;
+
+    set_ioapic_source_id(IO_APIC_ID(apic), &new_ire);
+    new_ire.remap.p = 1;     /* finally, set present bit */
+
+    /* now construct new ioapic rte entry */
+    remap_rte->vector = new_rte.vector;
+    remap_rte->delivery_mode = 0;    /* has to be 0 for remap format */
+    remap_rte->index_15 = (index >> 15) & 0x1;
+    remap_rte->index_0_14 = index & 0x7fff;
+
+    remap_rte->delivery_status = new_rte.delivery_status;
+    remap_rte->polarity = new_rte.polarity;
+    remap_rte->irr = new_rte.irr;
+    remap_rte->trigger = new_rte.trigger;
+    remap_rte->mask = new_rte.mask;
+    remap_rte->reserved = 0;
+    remap_rte->format = 1;    /* indicate remap format */
+
+    /* If cmpxchg16b is not available the caller must mask the IO-APIC pin. */
+    update_irte(iommu, iremap_entry, &new_ire, !init && cpu_has_cx16);
     iommu_sync_cache(iremap_entry, sizeof(*iremap_entry));
     iommu_flush_iec_index(iommu, 0, index);
 
@@ -439,33 +427,44 @@ unsigned int cf_check io_apic_read_remap_rte(
 }
 
 void cf_check io_apic_write_remap_rte(
-    unsigned int apic, unsigned int reg, unsigned int value)
+    unsigned int apic, unsigned int ioapic_pin, uint64_t raw)
 {
-    unsigned int ioapic_pin = (reg - 0x10) / 2;
-    struct IO_xAPIC_route_entry old_rte = { 0 };
+    struct IO_APIC_route_entry rte = { .raw = raw };
+    struct IO_xAPIC_route_entry old_rte = { };
     struct IO_APIC_route_remap_entry *remap_rte;
-    unsigned int rte_upper = (reg & 1) ? 1 : 0;
     struct vtd_iommu *iommu = ioapic_to_iommu(IO_APIC_ID(apic));
-    int saved_mask;
-
-    old_rte = __ioapic_read_entry(apic, ioapic_pin, true);
+    bool masked = true;
+    int rc;
 
     remap_rte = (struct IO_APIC_route_remap_entry *) &old_rte;
 
-    /* mask the interrupt while we change the intremap table */
-    saved_mask = remap_rte->mask;
-    remap_rte->mask = 1;
-    __io_apic_write(apic, reg & ~1, *(u32 *)&old_rte);
-    remap_rte->mask = saved_mask;
-
-    if ( ioapic_rte_to_remap_entry(iommu, apic, ioapic_pin,
-                                   &old_rte, rte_upper, value) )
+    if ( !cpu_has_cx16 )
     {
-        __io_apic_write(apic, reg, value);
+       /*
+        * Cannot atomically update the IRTE entry: mask the IO-APIC pin to
+        * avoid interrupts seeing an inconsistent IRTE entry.
+        */
+        old_rte = __ioapic_read_entry(apic, ioapic_pin, true);
+        if ( !old_rte.mask )
+        {
+            masked = false;
+            old_rte.mask = 1;
+            __ioapic_write_entry(apic, ioapic_pin, true, old_rte);
+        }
+    }
 
-        /* Recover the original value of 'mask' bit */
-        if ( rte_upper )
-            __io_apic_write(apic, reg & ~1, *(u32 *)&old_rte);
+    rc = ioapic_rte_to_remap_entry(iommu, apic, ioapic_pin, &old_rte, rte);
+    if ( rc )
+    {
+        dprintk(XENLOG_ERR,
+                "failed to update IRTE for IO-APIC#%u pin %u: %d\n",
+                apic, ioapic_pin, rc);
+        if ( !masked )
+        {
+            /* Recover the original value of 'mask' bit */
+            old_rte.mask = 0;
+            __ioapic_write_entry(apic, ioapic_pin, true, old_rte);
+        }
     }
     else
         __ioapic_write_entry(apic, ioapic_pin, true, old_rte);
diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c
index d5bf4d3241..e0ad38a09d 100644
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -133,9 +133,9 @@ int iommu_enable_x2apic(void)
 }
 
 void iommu_update_ire_from_apic(
-    unsigned int apic, unsigned int reg, unsigned int value)
+    unsigned int apic, unsigned int idx, uint64_t rte)
 {
-    iommu_vcall(&iommu_ops, update_ire_from_apic, apic, reg, value);
+    iommu_vcall(&iommu_ops, update_ire_from_apic, apic, idx, rte);
 }
 
 unsigned int iommu_read_apic_from_ire(unsigned int apic, unsigned int reg)
diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
index 3a83981464..b619cd872b 100644
--- a/xen/include/xen/iommu.h
+++ b/xen/include/xen/iommu.h
@@ -262,7 +262,8 @@ struct iommu_ops {
     int (*enable_x2apic)(void);
     void (*disable_x2apic)(void);
 
-    void (*update_ire_from_apic)(unsigned int apic, unsigned int reg, unsigned int value);
+    void (*update_ire_from_apic)(unsigned int apic, unsigned int idx,
+                                 uint64_t rte);
     unsigned int (*read_apic_from_ire)(unsigned int apic, unsigned int reg);
 
     int (*setup_hpet_msi)(struct msi_desc *);
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:22:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:22:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310178.526889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWlF-0006yA-DU; Thu, 21 Apr 2022 13:22:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310178.526889; Thu, 21 Apr 2022 13:22:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWlF-0006x7-0c; Thu, 21 Apr 2022 13:22:17 +0000
Received: by outflank-mailman (input) for mailman id 310178;
 Thu, 21 Apr 2022 13:22:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Mw+u=U7=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nhWlE-0006Vx-8I
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:22:16 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on061b.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::61b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0eb837ff-c176-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 15:22:14 +0200 (CEST)
Received: from DB7PR05CA0012.eurprd05.prod.outlook.com (2603:10a6:10:36::25)
 by AM9PR08MB6660.eurprd08.prod.outlook.com (2603:10a6:20b:305::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 13:22:12 +0000
Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:36:cafe::23) by DB7PR05CA0012.outlook.office365.com
 (2603:10a6:10:36::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Thu, 21 Apr 2022 13:22:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 13:22:11 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Thu, 21 Apr 2022 13:22:11 +0000
Received: from f13710f363c3.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2D0B353B-7510-4289-AC7F-1F70D4A7C287.1; 
 Thu, 21 Apr 2022 13:22:00 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f13710f363c3.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Apr 2022 13:22:00 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by HE1PR08MB2858.eurprd08.prod.outlook.com
 (2603:10a6:7:33::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 13:21:38 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 13:21:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0eb837ff-c176-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IAs366f38BlkOobXmdIdYladZKcRxVm8Lk0kmXz5/hc=;
 b=VnWVBK5YeZz4mJujjr1swFAixeI+jatZ05ong4sjYRUDnrYTyAuVR+GLDaIX3mmBZgrPqkgxR4P5KBbNUedEPkuwq9OzCtbYMzRNSVROY973I5eabgwAb6YY12BXmLuXCATSeD67SEBy6TZDGGXO4AZWykrOx/v8hlycHE8bTYQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a48196827fd3baf2
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ibtDdJOBOwX+RJDyniu3P9z6MMvvXpk/9KDEqtbgWf8tgOqxUnTyNrufxrq5R9nas4rxxx3zScMviNidVYpLPOv/lSzw9xWIOtVFoH6QOfsphWUO22pYpHpn6OW58kjX8UvSjVAKL0lbxoGtBgpTTK4QZKUJTZNUCjkE8ZshvCt9nnPW2emTCogL7vH33sbETkd+Uw4nq2NAX4QMp6SCjtJD7tAWcCEcJyXAaZCGlu8TkxyaJzKtMPt7X02KMiT7LKACvzmL9froLB3UdPL0AYFbb3Z42P9JgHFEeBv4vKeoWcR6xExd/ZdH1c//L3fFHHsDXNdzouelJXNRb5D5Ag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IAs366f38BlkOobXmdIdYladZKcRxVm8Lk0kmXz5/hc=;
 b=X0Ncpv5eQ1xma4EvYnnIWjWX4F6YVBz78/0ocXrhPWDKViIpH/CEAtazuGysv7z6ffMrt/uqc9KkiUhhP/K2BWScDo3q5VEX9+O9jC5mGFqk6aL0qWRiea0SjUcEZLzlmwE5utgXCh4n1PHywoiFzhY63V5s8WjCKCha78lLJ8noYZBPj98+Xhac9LT4qMvMcbZsW8yG3J1fcW2+ZoHGuo0WxSTYuSDSRK5UT3XsUwQrbhoGvMwO4UY6UsG1NwxmUYXsN2YicKDZ6Ov9pdi9p/+CAtd8N3Zwj5+tcGFrmPzP4LzpIU0WMvj4cvvBEoDkhJ/oT4WdHn5CMszoLXK0nQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IAs366f38BlkOobXmdIdYladZKcRxVm8Lk0kmXz5/hc=;
 b=VnWVBK5YeZz4mJujjr1swFAixeI+jatZ05ong4sjYRUDnrYTyAuVR+GLDaIX3mmBZgrPqkgxR4P5KBbNUedEPkuwq9OzCtbYMzRNSVROY973I5eabgwAb6YY12BXmLuXCATSeD67SEBy6TZDGGXO4AZWykrOx/v8hlycHE8bTYQ=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, ", Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Need help to debug Arm SMMU issue seen on guests with passthrough
 devices
Thread-Topic: Need help to debug Arm SMMU issue seen on guests with
 passthrough devices
Thread-Index: AQHYVXCysDCtUSKEqUams17wmJg+Jqz6WpOA
Date: Thu, 21 Apr 2022 13:21:38 +0000
Message-ID: <98FE5BFF-4201-49F1-9F17-42E26FBE3FAF@arm.com>
References: <022fb545-9295-1f10-6caa-01813cf0a646@xilinx.com>
In-Reply-To: <022fb545-9295-1f10-6caa-01813cf0a646@xilinx.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 92da8dda-5b07-477c-84ee-08da2399f1be
x-ms-traffictypediagnostic:
	HE1PR08MB2858:EE_|DB5EUR03FT061:EE_|AM9PR08MB6660:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB666037EA5E65326D1E6C4986FCF49@AM9PR08MB6660.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 sWgQKUjiGV4usW9kgS5gbc4qff3Q+xPtjPEJ+/UHGcKF2T6ydaJBa1p30ro4imWv9SopOO321PlMAMucTmA5XtqcQrlHA3ONfF/BmHeHUOsimM/7YL9Cl+bG2Fs37QIB4obvRm6I5RYZ23t9jP0AqOF/rDJcrssu5PNA1l4zZ5ih0xSigYwci3eDW10qzY+hU9AKsLRkVyuQP29c7HH1MAHGwlF7UjVQkY786i0dEWN75qCMDbQOG2WG+9fUPtcsn3I/VaVr0kvN9wp/+eGYZYZqmMV0ahiRs/Qf2Qdf+E+n1mHzIs4Rzmz/7WJFxNnheBASZd1KSe3MfN2JBlJcqHonxSoxgbxUipl1EQsbquts0+b1awfRpzh/oQD/zKoQDPtnfAeel2G/IFxf18R4JwST43447FYx0D4ofKL23VRvrJdUppaiRX7rdP+O0jMiPycK79FhwXq4rSZb4JoduvxRWR2aTBQNZvvxFHukB8XqmF5iNSxoRCMHiqx8tC2HRi3VqNaUz5f2+ZZDyafwV5aXvWX0rRdtqokTVDYAjfMGYLCBNOurvr8kFYJRXYAOguQY9elPWkx61EaAhKJ3YBT4ZYJ1m8uxMddfIBh6fC8Z7VhE4ioCojmifJB67PRQ39ewkFc6CWIrmSHbLkcsSTc3ZlYuijrJDmZ+3DxFfQv6mHvywO47k7uGDx5s67ZevUuLgP5J211V2fQYanuC8Vxoou0O0CurhZ4I2uiAU/8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(36756003)(38070700005)(4326008)(38100700002)(66476007)(508600001)(186003)(8676002)(64756008)(86362001)(66556008)(122000001)(316002)(5660300002)(99936003)(8936002)(76116006)(6486002)(91956017)(66946007)(66446008)(6916009)(71200400001)(53546011)(83380400001)(33656002)(6512007)(2906002)(26005)(54906003)(2616005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: multipart/mixed;
	boundary="_004_98FE5BFF420149F19F1742E26FBE3FAFarmcom_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2858
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	cd5601c8-e523-4fd9-f3cf-08da2399ddb7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jAuBlyx5y8Fz4hv8Ng5dVnr/tCA7U2rwT+fabXtZJ8suOq6DEdKr2u/tAHgCgL/FAieKPk9c5Z7o55QKOiG19sDuESc2Sp33I+xkngymujYAbNK+Gr/DvVTX+TxVgAXDhnFw62YDz+wp7PPKkF2LUaiMpf3TRabH3BV0sSIAwqlaS1fQr8nZ6qAacoEwpBfZ80s3V2rYNLo8W+vius4cVAx8eTtjsGNcEp487uu4Of8XqGg19ah8tZsaWvAKfi9inC4bZ4NAn8UBldMnb73iy/e2KPHr43n47SnuGM8Iv8dPas1+qW1aIzmqzalcEbtpMZqgf5iPYDa3ui60znz99P6d1BOuyOQ7TtB4SBCOboGaz3XZSwDLnKT1fOmffa/MLojeGrC2pHMwCCa9mPjNFLDGHSkhDnnOF3qFfwWl47SQyhR41x71jhE+jkQXxwCAna54UiontcdYisgPcD641/PLWB6VTDSFbQG4QYQ3H5lBAibUtc7Fiv6zJ6QFwx3+dOrqfIOf++V8qwOVaD7ULGHQP1u87jEzITEI7+FC3lSyGtXlrPXCF7WZtQOgjL6yoDa51MFoU7/7JeqnRsWW900gCCRjVZArBgRuBPpryI16FkBe52B8dNLQ97va71YYCQEBtIaKkCTCy+d16QlKLaLl0Bp8ZXEk+O7k+V5ZUbIFIFEajqXRPDjfKHP0fl8b
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(356005)(336012)(47076005)(53546011)(99936003)(2616005)(36860700001)(6512007)(26005)(86362001)(45080400002)(82310400005)(81166007)(2906002)(235185007)(40460700003)(5660300002)(8936002)(6486002)(36756003)(33656002)(508600001)(83380400001)(186003)(6862004)(8676002)(4326008)(54906003)(6506007)(70206006)(70586007)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:22:11.9109
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 92da8dda-5b07-477c-84ee-08da2399f1be
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6660

--_004_98FE5BFF420149F19F1742E26FBE3FAFarmcom_
Content-Type: multipart/alternative;
	boundary="_000_98FE5BFF420149F19F1742E26FBE3FAFarmcom_"

--_000_98FE5BFF420149F19F1742E26FBE3FAFarmcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Ayan,

> On 21 Apr 2022, at 12:12 pm, Ayan Kumar Halder <ayan.kumar.halder@xilinx.=
com> wrote:
>
> Hi Arm/SMMU experts,
>
> Scenario :- I am trying to assign a device (eg mmc) to a guest which uses=
 smmu. I start the guest using "xl create -c ...". It works fine for the fi=
rst time. I am able to access the device.
>
> Now, when I destroy the guest and create again, I see this issue

Did you observe any other Xen error while deassigning and assigning the dev=
ice ?
>
> (XEN) smmu: /axi/smmu@fd800000:         GFSR 0x00000002, GFSYNR0 0x000000=
00, GFSYNR1 0x00000871, GFSYNR2 0x00000000
>
> 0x871 is the stream id used by mmc.
>
> We are using SMMU-500. So from the Arm SMMU v2 specs, it is "Unidentified=
 stream fault" for stream id "0x871".

Yes, you are right above error means that Unidentified stream fault. That m=
eans SMMU hardware is not set up for streamId 0x0000087
I just try to go through the SMMU code and observe that this issue may be r=
elated to iommu group but I am not maybe I am wrong.
I just created the patch that is not tested. Please try to apply the patch =
and test it once.



Regards,
Rahul


--_000_98FE5BFF420149F19F1742E26FBE3FAFarmcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <3E8C096859DBE743B060FF943AAB2E35@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText">Hi Ayan,<br>
<br>
&gt; On 21 Apr 2022, at 12:12 pm, Ayan Kumar Halder &lt;ayan.kumar.halder@x=
ilinx.com&gt; wrote:<br>
&gt; <br>
&gt; Hi Arm/SMMU experts,<br>
&gt; <br>
&gt; Scenario :- I am trying to assign a device (eg mmc) to a guest which u=
ses smmu. I start the guest using &quot;xl create -c ...&quot;. It works fi=
ne for the first time. I am able to access the device.<br>
&gt; <br>
&gt; Now, when I destroy the guest and create again, I see this issue<br>
<br>
Did you observe any other Xen error while deassigning and assigning the dev=
ice ?<br>
&gt; <br>
&gt; (XEN) smmu: /axi/smmu@fd800000:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp; GFSR 0x00000002, GFSYNR0 0x00000000, GFSYNR1 0x00000871, GFSYNR2 =
0x00000000<br>
&gt; <br>
&gt; 0x871 is the stream id used by mmc.<br>
&gt; <br>
&gt; We are using SMMU-500. So from the Arm SMMU v2 specs, it is &quot;Unid=
entified stream fault&quot; for stream id &quot;0x871&quot;.<br>
<br>
Yes, you are right above error means that Unidentified stream fault. That m=
eans SMMU hardware is not set up for streamId 0x0000087<br>
I just try to go through the SMMU code and observe that this issue may be r=
elated to iommu group but I am not maybe I am wrong.<br>
I just created the patch that is not tested. Please try to apply the patch =
and test it once.<br>
<br>
</div>
</span></font></div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText"><br>
<br>
Regards,<br>
Rahul<br>
<br>
</div>
</span></font></div>
</body>
</html>

--_000_98FE5BFF420149F19F1742E26FBE3FAFarmcom_--

--_004_98FE5BFF420149F19F1742E26FBE3FAFarmcom_
Content-Type: application/octet-stream;
	name="0001-xen-arm-smmuv1-remove-iommu-group-when-deassign.patch"
Content-Description:
 0001-xen-arm-smmuv1-remove-iommu-group-when-deassign.patch
Content-Disposition: attachment;
	filename="0001-xen-arm-smmuv1-remove-iommu-group-when-deassign.patch";
	size=943; creation-date="Thu, 21 Apr 2022 13:21:37 GMT";
	modification-date="Thu, 21 Apr 2022 13:21:37 GMT"
Content-ID: <4A426946194A5C44BA5ADB74CF76019E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

RnJvbSBiMGYyYzM4ZDU4NTZhOGMxOWNkMDRmNzBkM2JkOGI4Y2QyMjU2YmJkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlkOiA8YjBmMmMzOGQ1ODU2YThjMTljZDA0ZjcwZDNiZDhi
OGNkMjI1NmJiZC4xNjUwNTQ2MjI4LmdpdC5yYWh1bC5zaW5naEBhcm0uY29tPgpGcm9tOiBSYWh1
bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4KRGF0ZTogVGh1LCAyMSBBcHIgMjAyMiAxMzo0
MjoyMCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIHhlbi9hcm06IHNtbXV2MTogcmVtb3ZlIGlvbW11
IGdyb3VwIHdoZW4gZGVhc3NpZ24KClNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdoIDxyYWh1bC5z
aW5naEBhcm0uY29tPgpDaGFuZ2UtSWQ6IEk5NDFjNTU0MWMyNGRmNDk2YmQzMTQzZjFjNzVmMTM2
NmFmNWQ4Y2E0Ci0tLQogeGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYXJtL3NtbXUuYyB8IDIgKysK
IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hcm0vc21tdS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYXJtL3Nt
bXUuYwppbmRleCBjOWRmYzRjYWEwLi4zODMxNDgwZWQ3IDEwMDY0NAotLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9hcm0vc21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Fy
bS9zbW11LmMKQEAgLTE2OTAsNiArMTY5MCw4IEBAIHN0YXRpYyB2b2lkIGFybV9zbW11X2RldGFj
aF9kZXYoc3RydWN0IGlvbW11X2RvbWFpbiAqZG9tYWluLCBzdHJ1Y3QgZGV2aWNlICpkZXYpCiAJ
aWYgKGNmZykKIAkJYXJtX3NtbXVfbWFzdGVyX2ZyZWVfc21lcyhjZmcpOwogCisJaW9tbXVfZ3Jv
dXBfcHV0KGRldl9pb21tdV9ncm91cChkZXYpKTsKKwlkZXZfaW9tbXVfZ3JvdXAoZGV2KSA9IE5V
TEw7CiB9CiAKICNpZiAwIC8qCi0tIAoyLjI1LjEKCg==

--_004_98FE5BFF420149F19F1742E26FBE3FAFarmcom_--


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:22:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:22:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310180.526903 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWlG-0007Rf-OG; Thu, 21 Apr 2022 13:22:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310180.526903; Thu, 21 Apr 2022 13:22:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWlG-0007Pg-Id; Thu, 21 Apr 2022 13:22:18 +0000
Received: by outflank-mailman (input) for mailman id 310180;
 Thu, 21 Apr 2022 13:22:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhWlF-0006Vx-2J
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:22:17 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e89e0a7-c176-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 15:22:15 +0200 (CEST)
Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 09:22:12 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SA2PR03MB5692.namprd03.prod.outlook.com (2603:10b6:806:11f::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 21 Apr
 2022 13:22:10 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:22:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e89e0a7-c176-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650547334;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=/bsTBjNEwz+nuNpaTcn/VhN1csiAX9NFexTx2XLkEJ8=;
  b=ebMfD7/QKD9+KFUyMEvQqog42ynyHsp+fyg3QVTPpA0x9lTqgKGX6I6P
   /dOhr+FFfdXoUR4GYHrn4jq6r3ttFMDvcmSUVWCydVpa0BQ5MBD9/HXd3
   UaAQn4CIZcOBWdN5zVBPXkD8Smj19TQY8HtKthuT/SmALRC+TuqrFKtbR
   c=;
X-IronPort-RemoteIP: 104.47.59.176
X-IronPort-MID: 69485236
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:HSJHLavrRg2Ypi4CTuzphcSXoefnVDZfMUV32f8akzHdYApBsoF/q
 tZmKTrVbq2KNmb9f49yPYvi9UkA6pbdnNJiSABt/CtmRSpD+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X4
 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8bB4bOws4bXCVnHhAjPe5c5eSXIHWG5Jn7I03uKxMAwt1IJWRvZ8g037gyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IJmm5v2KiiHt6HD
 yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgAzE+fpquTONpOB3+L6xM8PEXfivfORQu0DDm
 Xjc+VzDDjhPYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWFTGWsuxcdX59cFrM84QTUkK7MuV/GWC4DUyJLb8EguIkuXzs22
 1SVntTvQztyrLmSTnHb/bCRxd+vBRUowaY5TXdsZWM4DxPL/enfUjqnog5fLZOI
IronPort-HdrOrdr: A9a23:6kjBwKyWlRS3cN9fIZxqKrPxseskLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scu9qBTnhOZICOgqTM6ftWzd1FdAQ7sSibcKrweBJ8SczJ8h6U
 4fSdkYNDSYNzET46fHCWGDYqwdKbK8gcWVbInlvhRQpVYAUdAa0+41MHfsLqUwLzM2dKYRJd
 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoILSIly95FMzQjlPybAt/S
 zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+cwzqAVcBEYfmvrTo1qOag5BIDl8
 TNmQ4pO4BJ53bYbgiO0G7Q8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnJ
 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvsX+9KK1wUh4S1bpXUd
 WHVKrnlbZrmBKhHjrkV1BUsZORti9ZJGbEfqAA0vbloQS+0koJjXfw//Zv4UvoxKhNN6Ws2N
 60TJiA7Is+KPP+TZgNcNvpEvHHfVAkf3r3QRKvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d
 /8bG8=
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="69485236"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hunWtmTAxBGjZ4ixWsT4WgPn3qWzJnhRJEr96b7kBCnllSqhPFXXkcaUO1HxKgkF7EjOWhRm5wWzYZKx2VXQcRdV6TxzbEkLg+T4+ZVTvzcr1l8qmzvt7l8oF0UGTTE+gInCs5xSV4dCasFtSffurRNswart/cK9TPhRiXIHiSmwds6p9Ooe+n7+nsQflKNxmz8ObKYvZauCDn4aG1hxIz3djnuVufRGV2rLDUy46uLH70d+q9qGREMuEHt0X8T2bm6HGLBJ91JlD/rmOt+3hMi6stvhef4g9MRtvowENr1W1yk0Mxo4ODYDI7isjDF3XCaeO1kj/YDBwtpnPMsjcQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rEx7VOG8mAayx6SJwjyMn32in/pxHdqc+RPxorUEmOM=;
 b=ikZqYrI9uw/se/mt8vbOE8ArzmNi2QVH99G67fFJ4yEUYtcjK5CJSHoIDTjIZNI56YBc3eH+0hJeYq4Nuurq7mwPF7Fgv8qabPOd3NQA5FM3ODROF76xjhilRXVoV7LEK6Daoom97rQeH5e9czd7COrO7NG9c8C0jXAZTK1S4hveogLZzezEYdSVbhSeMvv3ivudS+egyke8hKAeY7JnxQLML8EIWFMkkNlPM8r9Ngcmhb0DJ/bGyzs4U6kYTV575R4UNt+EArSNPDtq8hO76cL/ZapRl+HbqOhudYEH8FsV/mY7iFR3yEASSVlXKaZo0tAJuM7KvcPhalhmF/ku0g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rEx7VOG8mAayx6SJwjyMn32in/pxHdqc+RPxorUEmOM=;
 b=t+98rKSaD+ls4CWZdV7YdtB7ZnyNGhqSVo/2yYEEEcbvXMm0eU8VBY1ODPDJKxdj+zrEWVOQm/aqftK7nGQW7o1Yv8gtz6/BJUZSKMm5tQHeJHD85Ba7MyjnpKcEgPHA5FPB5FB25w9jlJMsI0ZSN/YZxqwoy88G8fX/E+PBdJU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH RFC 5/6] amd/iommu: atomically update remapping entries when possible
Date: Thu, 21 Apr 2022 15:21:13 +0200
Message-Id: <20220421132114.35118-6-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220421132114.35118-1-roger.pau@citrix.com>
References: <20220421132114.35118-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0141.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:30::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e600cecd-38ad-49a0-159c-08da2399f0c7
X-MS-TrafficTypeDiagnostic: SA2PR03MB5692:EE_
X-Microsoft-Antispam-PRVS:
	<SA2PR03MB5692F1F95FB58296655D2D768FF49@SA2PR03MB5692.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	792vfE659+TBeT8rEsuB30HQ5i2El93f3wqpRKzowcGtFU3G/QOcBDoWZewGzJeXqVcKHKhuF92XWFeraKgfYXItoxID7gqMpOAGjsR5tdE2Jid2iEtdw61VKcBIXz8T3Qhz1/nNFU1peCq2ndkK5orbw7LaP5bizGzb0EoR7SAy1oWvT/dO7MWnHvhtqO/3/R3EBbGiySbAzkA5gzYppvm/TJovi/g+vVQ39WHs6nU9Sg5E0TFH97sp5dYXdf0wSaTd2Pg31eVcit8LHz4M3jtKM72dHr3x5klXBCS3kkZoGJ7tcKq9LPUgNs4VgkKV3UDK0XoJZ0Lo6IEEUPPlLccQkKUv6pAXdewjyRAPD2ypH4ak9fS4c9nLTxGUm0SgcAgM8sAJifs4h1olrhaFL0rNDenxrY9hY4QFKovD6Bs814j+E3B9znSwW/obEiOxJ84y9odbbbQdP6A+FIzfusf6RcMaMg2gEA2OXfcC6tJgqH5Y5ekHlc5ChA2nqNNdR6TApNVDCRdkNiIreZIAnfQmGnRhBZCCeD/qFIGhVUuLMmSgI52C2WBYRjg0TeuUpRo0Is/5/R23hkf9XOfAn/LoN3NYwTIoqDBuEESyKN8uET72IMSqy5w6Mm+Ol+/SIuUMfu7jIrvU+bhX6mlHkA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(54906003)(8936002)(5660300002)(83380400001)(107886003)(6916009)(36756003)(1076003)(316002)(86362001)(6486002)(6506007)(186003)(66476007)(66556008)(2906002)(2616005)(66946007)(8676002)(4326008)(6512007)(26005)(15650500001)(38100700002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bXNxQ1hJTXJ0Q0dIVXRWekJkaVY4TFdCUGcxbEdhU21jTVVOTEczSTdRWnhF?=
 =?utf-8?B?TTdSakVUc2JNbVplOVRGNit1aXFoWXNCeHNwQWtMcFBiSmxTMTN6MVdQMWZi?=
 =?utf-8?B?WkR0bkFwSDlrREZ2ZjU0NVBkenNWMGpOVjh5U1UremtwTVZ2NDdDK0ROUGo2?=
 =?utf-8?B?UG12MzltdVJWTkloNWJyZm5mTmdyNkVoWkQrOFIwclBIaWZmd29USFhiRFVH?=
 =?utf-8?B?V3JPRUxMbWg0RW1YK0Q4cWJvWlBjZS8wK3NQM1NZNmEwZmJqdDlGMmZMS2h4?=
 =?utf-8?B?NzFGcXNRL2JoR2krSE54ZUhUOXdWYmQvOUZHYW9GdWNUQm5MRlFYOEd3V3RK?=
 =?utf-8?B?aFdOTk9UUW9ld1NlL2FkRU5hUUNMMndTazNNVlBwN0xxQzlpa2Yzbjd5dEdt?=
 =?utf-8?B?VkZYL3hMbENlaG1RQlZLbWVtMnh3Q3FzK2Q4SndjTGt3bjJoSWo1bnJLdVFj?=
 =?utf-8?B?Wi8ySkpEak03blRyNkFaVm0rN2dMRDJuOC9EUTBQeGU3YXYvRzV3bHhSRHlO?=
 =?utf-8?B?Q0wxTGlkYUg0NGg2dkpSSW03N0NzQXJMbWtMU29lc3Y5eUZnbmNHNlNWVjJL?=
 =?utf-8?B?bWVGTEExbVdtWThTZkNwZTVva05ERE42dGdZTlVwdUVyMVMyTnRJNEQ3eUVx?=
 =?utf-8?B?Uk5GUVRCRnpMcG5YYXh4ekhua3IrenUwaUJhU3h1dEhBMUIxL1VpL2J2d1ov?=
 =?utf-8?B?bEdKWUxldUUwNEphVFN0Wk9vcllZTGVtRytvVjRpd3hlTzYvMkRVUXZvYW84?=
 =?utf-8?B?YjFXWE9tMUFpbjNxanByYnNtZE14MXUxVVNDN21OQXVTcllkU2JobFBZOUJk?=
 =?utf-8?B?VFlET1paeWp1V3BZMXdUSFB1U3YzVTFEMUtQMndzY2Y5M2VUNVJrMVg1c1dX?=
 =?utf-8?B?OXpJbkFRTFpaWk0yRkhyNzMrVEpVQWV0ZUdlSFNvallIeEVOTWZjY0N0TkRL?=
 =?utf-8?B?SDFDZEtIbHNvWjJ2M0dqN0VRdUlrZnlpWmorQWNoRmNmbkZPZ2MvbnIwaTNG?=
 =?utf-8?B?bU1ONnp4dCtVUjNRcGlFVXV1ai9GYTBjN3VwUTNkc0plclpSR2tPK3Y4SzBH?=
 =?utf-8?B?RlJSYUlhb3Z2L1VWTzVxZDlycm51NlNTcWFScjdJRXpTU0VjcmVnSmc4RTdl?=
 =?utf-8?B?R0tvcHgzRVA5MDdXS2hYNTIzWXZ0dmxGaW04dnljVDQ0TkpUSFNqUWNpc0sw?=
 =?utf-8?B?SFVBaTMxeTBPM1k0bXl6aWN4SGZDQ0xERUo2eHpEeEFnd3FaV1ptdCtXM0Zh?=
 =?utf-8?B?VFBnTHhZZHRWWHh3aXExRjZlQVdocTFoSlVuK21oMHNNTDlleHdmSk5tQU9m?=
 =?utf-8?B?V1BOUVdHblBmaWNlZjUvSE9sOEF2SFJkNHQ5TlQwZ0JWMkFueWRONGRnRlB5?=
 =?utf-8?B?NzNldGpIOE1vZVJ3d3dLQjBjQW1WZzM3ZjNkbDNabVN0eDBlY1pncHVGZHB5?=
 =?utf-8?B?Wjh5Yi9Nc3J1eUp3OGEvM1hMVTh5OXQ3YlJ2OVkrOUZ5dHNJSW1La3A5V3dU?=
 =?utf-8?B?ZU5acVA4QWFHRXJiV25FL2tCQVVnYVFlUXBqWHVBRHhDMWZVOWlQV1pWclBi?=
 =?utf-8?B?UHd3dVBySU9XSFNkMHV3N2ZxTDhLRmVEb0tOcGd1bG8zSnVwTkNEQ2UzSkNE?=
 =?utf-8?B?MmhUbGM4WUgzOUJaLzZQUXpFVUt4ZnBodWVIZ255YzRmOEswYUFseHJxZ2Fz?=
 =?utf-8?B?THdWeFY1TU4wc085c284bDNxY1B4cTVwTEY3UHd5U041YWY2cWg1eVlsejhE?=
 =?utf-8?B?T1RnWDFXVmMxT1JrZ3dtbGlmdDcxV0s2WUlOcFFkVU1ZcUVzK3Z1OEx6VVR0?=
 =?utf-8?B?RXp1Q1RWRUlxbWgvY1FGWlpuTko3TFc5c1lnMkZKN1JPN0tkNGphS1B1SmF2?=
 =?utf-8?B?d2dYeEpPZjVuSEZVdTRvMVdLOHJtYk9sbVNnTlR2L3ZDTHNuZkNqMVljOThX?=
 =?utf-8?B?QllzOW4rNXJpWk9BdGVoNXJpVUcxUFRTVDlaRksrZmxZVEFFL0U0ZS8vNUg4?=
 =?utf-8?B?d3RrSEN0Y2I5clVCUlE4YWtGZHA0Z2ltY3pVYmJRWkUzcXB2cjhrTVlndWxq?=
 =?utf-8?B?cFVTbzA2QmQ5cXRuTXZpdWEwTlpQUTFWMWpWS1ptRm03cDllQ2F5TEpDOTNV?=
 =?utf-8?B?YUl4RzR6SE9sOVNaN3hBWStGN09tcWR3UXVJKzd6TmpNdXZKRkFKWkJUNHJG?=
 =?utf-8?B?RUxUQm5rYzBoektLMnZzQnVFMnhyeStQSXBRLzRkWnVFL0xOVHdBMFZHbHNn?=
 =?utf-8?B?aWo0Q3ozZmg5b3hMb3dockkxcC96TVlJUFhST2V3emUzZ294YWp6K3ZQTkc5?=
 =?utf-8?B?WFVlM2dGdnBrVkdyZkF3akIzSDJzS3JhaGJJQ2M0N29wQ0VFdmgzUUlVNmZY?=
 =?utf-8?Q?hYedFj3mE3hWr4wc=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e600cecd-38ad-49a0-159c-08da2399f0c7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:22:10.4143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bicqIca0jy0XNgX+NeCxIuK0nQs8Fm6RPimje78Fz8vJqqIIn+hkQ+DzfunnpbEwcITxwAv7wJ46sznvGRsNFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5692

Doing so matches existing VT-d behavior, and does prevent having to
disable the remapping entry or mask the IO-APIC pin prior to being
updated, as the remap entry content is always consistent.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/drivers/passthrough/amd/iommu_intr.c | 31 +++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c
index feed1d1447..b24e703c75 100644
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -39,6 +39,7 @@ union irte32 {
 };
 
 union irte128 {
+    __uint128_t raw128;
     uint64_t raw[2];
     struct {
         bool remap_en:1;
@@ -222,6 +223,21 @@ static void update_intremap_entry(const struct amd_iommu *iommu,
             },
         };
 
+        if ( cpu_has_cx16 )
+        {
+            union irte128 old_irte = *entry.ptr128;
+            __uint128_t ret = cmpxchg16b(entry.ptr128, &old_irte, &irte);
+
+            /*
+             * In the above, we use cmpxchg16 to atomically update the 128-bit
+             * IRTE, and the hardware cannot update the IRTE behind us, so
+             * the return value of cmpxchg16 should be the same as old_ire.
+             * This ASSERT validate it.
+             */
+            ASSERT(ret == old_irte.raw128);
+            return;
+        }
+
         ASSERT(!entry.ptr128->full.remap_en);
         entry.ptr128->raw[1] = irte.raw[1];
         /*
@@ -299,7 +315,8 @@ static int update_intremap_entry_from_ioapic(
     entry = get_intremap_entry(iommu, req_id, offset);
 
     /* The RemapEn fields match for all formats. */
-    while ( iommu->enabled && entry.ptr32->flds.remap_en )
+    while ( iommu->enabled && entry.ptr32->flds.remap_en &&
+            !cpu_has_cx16 && iommu->ctrl.ga_en )
     {
         entry.ptr32->flds.remap_en = false;
         spin_unlock(lock);
@@ -366,8 +383,11 @@ void cf_check amd_iommu_ioapic_update_ire(
         fresh = true;
     }
 
-    /* mask the interrupt while we change the intremap table */
-    if ( !saved_mask )
+    /*
+     * Mask the interrupt while we change the intremap table if it can't be
+     * done atomically.
+     */
+    if ( !saved_mask && !cpu_has_cx16 && iommu->ctrl.ga_en )
     {
         old_rte.mask = 1;
         __ioapic_write_entry(apic, pin, true, old_rte);
@@ -383,6 +403,11 @@ void cf_check amd_iommu_ioapic_update_ire(
         /* Keep the entry masked. */
         printk(XENLOG_ERR "Remapping IO-APIC %#x pin %u failed (%d)\n",
                IO_APIC_ID(apic), pin, rc);
+        if ( !saved_mask && (cpu_has_cx16 || !iommu->ctrl.ga_en) )
+        {
+            old_rte.mask = 1;
+            __ioapic_write_entry(apic, pin, true, old_rte);
+        }
         return;
     }
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 13:22:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 13:22:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310183.526915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWlJ-0007vo-5C; Thu, 21 Apr 2022 13:22:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310183.526915; Thu, 21 Apr 2022 13:22:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhWlJ-0007vH-1H; Thu, 21 Apr 2022 13:22:21 +0000
Received: by outflank-mailman (input) for mailman id 310183;
 Thu, 21 Apr 2022 13:22:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhWlH-0005Gk-Dy
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:22:19 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f2121c8-c176-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 15:22:16 +0200 (CEST)
Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 09:22:15 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM6PR03MB3771.namprd03.prod.outlook.com (2603:10b6:5:4e::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 13:22:14 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 13:22:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f2121c8-c176-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650547337;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=t8julXlOoNYBqtFkpFb4nXUExQj90ge4lQC5Ly84gfg=;
  b=iXyEyQpdNrYDBFd5bP+PqsHVIvCoO3V2lWChOmOpZ8fAy3SdcBq7HUJk
   GmlVtWQE/LsVo1SUclYWnagLwXCtnzMCmDxeQ8+iU1ycGffgwuXl4WW9I
   e7FTiSGJrdYqNKLIePmKsLa7tA8Pl6vZYFeE7CcU5VqdZjQZ89x7+1Uvg
   E=;
X-IronPort-RemoteIP: 104.47.57.171
X-IronPort-MID: 69007273
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:QYDs6qsTWUENs+y4/n18U5bdb+fnVCJfMUV32f8akzHdYApBsoF/q
 tZmKT/Saf2LZmPzeY1yboS2/E0Av8Tcztc1TwVrr3wzEC4V+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X4
 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8lFPDlt99FECBeGh5gbaJ3pYb7C1ug5Jn7I03uKxMAwt1IJWRvZMg037gyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IHmm5v36iiHt6HD
 yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgAzE/fJouTeIpOB3+In/MNHKKsy0fMFQlFSpo
 X7Ap27lLjhPYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWQv3qsrhMaHd1KHIUHBBqlz6PV50OVAzYCRzsYMdg+7pZpHHoty
 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1LUZxRmYL
 +i2kRUD
IronPort-HdrOrdr: A9a23:acri96vzyyHP2ORWQFueMeMb7skC5IMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPMs1NaZLXLbUQ6TQL2KgrGSpwEIdxefygcZ79
 YYT0EcMqyOMbEFt7ec3ODQKb9Jrri6GeKT9J/jJh9WPH1XgspbnmJE42igYy5LrF4sP+tFKH
 PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w
 31CNUXqFhwdL5nUUsEPpZmfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a
 6xIm+w81RCMX7TNQ==
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="scan'208";a="69007273"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lX2SthwrUQ/YIADe5wZ0yXXTWPCtgLF1RH2dAeo+TITMiwhQPE7y0Obm/vp5otIPpfVvrEnr7Fq2A/S3tHYav6f6s9j7kWkq2S/wTvhP1PSXvD5o2o1vbQW3TCrRux+Mol4i0d6IUhp7Nn+/3UAgvHEdpUmoX94xzFm1/EPIOqHMZwzIQ87sFaymIslg7CFo8PF8PqvuYKOp+0/zvhDFos7yDaY9KctbKMeJ8yisJLQ94rB25S4P8joGCN6ZLjjMP+vtJwgkv/kNnToI1qfe553GBcri6ILZmIN/Xj0nwTO14FvAZLvU8QrsaeSkQo6Jz5ZLJsqmTcyGfHotbo1T5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=726ON294pXNt7c/3gsJ1Z+Ba/nN1vU6Da+G2qEPvwDg=;
 b=InHwxIemJPfVUmwg1QUudFLEgbO9AyoQoBY3PX21CtPT6J+KU9jvl+cYovnfIY4o8raD6Xwc0MRgma/+rJNPuzQrwwGBhDHPSilY8wbci+LN73/FUWGUimLaYdA5EDDjblBiHNbjA5N2SlRdRJI1r1jA1ayuqpN3ZCHfK8EuSvy0yIuORkZRbb6U+6P8mgJiN4gw1im2Q4gjMP0I0StEBQNCh3TXooi3r9q6vR+TMqliXaW51poqlmHuHL51tGBeTkfLX/pbbQJzJDP+KE6gBoEwBimAYFHcu/5Bozcz081wFMl8hGHF1dIAjrRtaNUInHdlK872LXGRfLm8ITxwSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=726ON294pXNt7c/3gsJ1Z+Ba/nN1vU6Da+G2qEPvwDg=;
 b=ep2ptWBSGhvmUNG5k//D2107BLtD80ac7BUM+4w97PyJfz3aW+QDL07vPJhqCvgGpZa4eyp1fURp4gd5VJkHi//jo7UTHP6kVUVDD0uMoY0NyUuW6aQPOxJKHHhRhO8val9F+zYpqcXhT/CKk+7ZSnngWlesaStgCIfmGRmoGao=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH RFC 6/6] x86/ioapic: mask entry while updating
Date: Thu, 21 Apr 2022 15:21:14 +0200
Message-Id: <20220421132114.35118-7-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220421132114.35118-1-roger.pau@citrix.com>
References: <20220421132114.35118-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0143.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:30::35) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f3b82e05-6ed6-4f41-b84f-08da2399f2fc
X-MS-TrafficTypeDiagnostic: DM6PR03MB3771:EE_
X-Microsoft-Antispam-PRVS:
	<DM6PR03MB37718EC3C9F5DE47049411908FF49@DM6PR03MB3771.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hReYVgCXeBfLRRYWkepBFYpuFUQA0kEkR8OeIulKXfFr8KAxEeZDe84BDIa2xFck/FjPS2JcF6oGhJTvSDIqoILtZaTOeyMu4uW8l9TDCbOR7Vk+d4lyPlKyBN1utjWsSkktIj/LNxnxBKwbj83rTZ22qIrg2yr8OKTL1PNOOWensgvM5CmWP/+jnYKRtDt/YlMFEvuYbvsN2Gpn1LqZOV4o+FEV0v3+9T8sLbMqyXsqDWnfJKcKxC86A97ubZv/sre85ma40PKZNrW9bIgEajnBS1KMZ9OgiWAyS6EQs7ylGW7Vi3XfE5ZuDFFwH27aqPOV+iuz2mm2ITm71ryVZx5jRW3mFHhSv/470pY17TAO3+/0qjPca1bjI4yK5XbgQFZRVje8/lTbPNcYX0WRvyWwUbyXNRRy8+HqceAJy4NxP+BBf/1YG2R+CZX9NRIm6855MZR/yGAgGi8k9FzPinbOjPmqR/PKhyxaZ2FDeoQNCvLhG2y24JKXDxGIzvFj45qPihRlTIXLSRHQTvQfpb59zu5gBgPVqnNzKQUvA3KpaHR+8WFXREVYX5t8Pod26kz1PJJ6YCqUFuDuNaPMwoTz1Bkvq1gUlnCTaWyHaG+WQx1VDeit4o8ODSDNuxsZl7+2V4iQuURWEFroULXKRw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(316002)(186003)(2616005)(26005)(5660300002)(83380400001)(2906002)(6512007)(4326008)(8936002)(66556008)(6506007)(86362001)(66476007)(38100700002)(1076003)(8676002)(508600001)(54906003)(6486002)(66946007)(6916009)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R3hBUUZLcHR3VkdJdVkrd1dtd1VqZERXU3RxVGpodWY2VndoWkFYSXp4WEJQ?=
 =?utf-8?B?MmJCQk1lY0JWdkJnWklBMXBrNXB3cTB1dHBUUlVnQWtRZ1NNYlkxcnNzblFM?=
 =?utf-8?B?VmVpM2I5Ukpyc1NOVkhkQTFWdzlQU2hWdGZYejNDNWJpdEJHTGVvWlE4RnEr?=
 =?utf-8?B?RGZHYUtnbE5GWU5WYWg0bXdzSStlaEFnT2tPMTFVSWdDb29QRkp0VFc0TjJ0?=
 =?utf-8?B?Q1ladVMwcG43ZU8zeXkzU0h2TFE1T0podWx5ajdwbGNuTHhlc1l6MEZXSzZy?=
 =?utf-8?B?TFFXdU9temN4TUlZWWlEQnhlSVVWTDFLTWtXbEF2b2JUK3ozSTZRUmRhSnI2?=
 =?utf-8?B?UXlDOGlKY1lMaEkxeHl2REZvazhHODNzU2lwTFk1SmFTK0FpdmhHQ0xIRnQ4?=
 =?utf-8?B?MVZvdGlrWlhrU0NWOXh5VGh5NVc0RTl2c1J3OHhZb2JnRDZkUjBCcDJTY3BY?=
 =?utf-8?B?bjBUZnpVRisxaXpyS2ZITTRLdFdpZUtEdEpZVzg4ZVBzM3dPQ3EvaG1JWDFG?=
 =?utf-8?B?RDlHVmN3cFlzWE1jMy9oRUU0RnZadW5RNmhTSkp3NTNDVTd2bjB4Z203VHFt?=
 =?utf-8?B?bCtqMHZpS2sxTmN5WHpKMVZDWExsQTA2aDhVYUpoNk44bFN3N0ppSDllMDYx?=
 =?utf-8?B?aGZvZWM2ODEvSGlscWNMbzNROFlVWnpYYWhmSmIrbWw2QnpDVUNTbFhScUFj?=
 =?utf-8?B?K05PVGtJaWh4NjEzNm9zeEgvcW1UUzYvWHZPa3RaMUJRN0NBN0JjQzRyYjlw?=
 =?utf-8?B?b0tpS0ltSXlSWTUwK25ESEZ1SkJjb1ZwZnB1VzBnRHFDZjhRMFZ3cHN5T21u?=
 =?utf-8?B?a1dBdVJNYmdXL3lreVpVaE9qNEg4bnNDNEIvVXdOaWJuMTk2d0Q5bG9neFA1?=
 =?utf-8?B?RzZ3ZEpDaU1xM01HclJOaE54K2oyTnVZemFpb0FrekJEVFo2Y1psbGZva0V2?=
 =?utf-8?B?OWR4Wm5zM1hhVG1SNWUwN0R0QXk3T1lxa0xlUnBURXMxeVAwUng5MHp0VGFK?=
 =?utf-8?B?blN6YWx6eEsyYVJJSEFsS1JoQzJSeURRcmo0MUp1Y0xSL0s0enZIQnAvTlpm?=
 =?utf-8?B?NTdGQ3JZMW1sUzFNOTFuc3hKZ3oxaGlJK1VmZ2dSbnEvdjBWMGF5V3ZlYzZ1?=
 =?utf-8?B?dnpxV1hiWno4ZHhueWh1VHBVVXNRTHpzUnRIQ2VYM2oweHljVmUvZ2d3NFI4?=
 =?utf-8?B?VEwwOUhCaWQwN2pGbDhpSlArYlhudDI1dlkwWnJ4MG9QNDE5MU96MlFqVUU1?=
 =?utf-8?B?N1c4TjQ1NC9YaGZnZjVFa0lZdzFWSEprTFRRWmJFTUJQbXZNNGt4TElCY3NJ?=
 =?utf-8?B?amRjWVN5eXkwTEQ4MnpMYm12NTVXN0w0TmxEQW9ub1J2Nk1PWmdjVGxUaHpG?=
 =?utf-8?B?SldvVHFibTl5Tzd4eTY4NVk3cmlCRWN1czVaRWVROXNxUUwxWWRJRnJNcjBo?=
 =?utf-8?B?RFVacXMySWRFN2psUTVySG9tQTREV0RFWGQ1K2JnaFRYcHJZeHpHWCtNWDdj?=
 =?utf-8?B?T3FOQ1JXa3U2K29sZGdLa0Jhc0FFL1B6bHpsNW44NVl6NnEvQ2dGYXhrRFdR?=
 =?utf-8?B?THJNc0Fya2FPODErZmNtS2J4dW13RHB4aXk1UWhESWtETEsydnloMG5laXBa?=
 =?utf-8?B?NnpWRjhLVDhyUXhhejI0UWxoMmhSZW1McWRpRWNranhidnF5clFkdHFWejli?=
 =?utf-8?B?TTVveUM4WmsxM2RUSmRzSTlLUW90dHVwQVNTUVZwSmNTQ05IZ0w3aWY3K0Rv?=
 =?utf-8?B?TTNadUhuVUoxbTJ5U01PakFRbGs0eUQrL25NdWlwR1VyNU1WZnNNaUNHMi9I?=
 =?utf-8?B?ODlYOWpYTzV4NXJVb1NBa3l6c1R3OFlPNG84ak50U0w4UElzcXhGUmtWZkpJ?=
 =?utf-8?B?ZGFjWDhTcUlUN2xKNTlrZHdPU09YTVl4QlVNUmZUKy93VFBBNXdvNWNlVVNq?=
 =?utf-8?B?UG9yT1NsdWdmUk1RUVZDeVhGVzBOVjFjUlY2Vk1OcS9BaldzTW0rU0F0dVRT?=
 =?utf-8?B?VUk3bThLamtRbm9KelJxUENNWVdSbzRPK2JMK3hnK3dFMGwraWRTY0RNQk9T?=
 =?utf-8?B?RTdreHlKNGJtVDRjQkVEc0pDU2JZai9EQkJkRXU2Vkgwc2ZPMkxwbFZrbjF1?=
 =?utf-8?B?U3BMYkhlTFk0T25nUSt1MFI2OEJsNGp0ZXBnaE5oMjVIZGoyTUdOZ3FBbEth?=
 =?utf-8?B?Z2pnMG9RdFlMRkx0L3NMSFJGUWtBaWp5eGVSck1JbXh4TzJGTGFaU2xTWjls?=
 =?utf-8?B?YVlxK2hsNGZEb2dVQkRKdFV6dFp2QjJYRWxGREt3WnkwQWYyWU9hNlJxaFF1?=
 =?utf-8?B?MGlKcmJYbSs5eVczdGhHWEhFOVd6MG1NTVJJa3VEeUc0K1IxdGJiOFN3Rlhx?=
 =?utf-8?Q?1qKGap5XWuJLf5l8=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3b82e05-6ed6-4f41-b84f-08da2399f2fc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:22:14.2150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zQ5bns9muO1JXf/NhXYQKgslld6veYOsM7kUW+GBE2FqKgDAsjBzyxt+hP523r7+JL8rqd9RCJxOVo87hOxvGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3771

When writing an IO-APIC RTE entry make sure incoming interrupts never
see a partially updated entry, by masking the pin while doing the
update when necessary.  Add some logic to attempt to limit the number
of writes.

With the masking now handled by __ioapic_write_entry itself when
necessary, we can drop the setting of the disable hook for IO-APIC
edge triggered interrupts.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Note this includes a revert of the first patch in the series.
---
 xen/arch/x86/io_apic.c | 45 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 40 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index f61e56f3d1..1860af7353 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -267,12 +267,47 @@ void __ioapic_write_entry(
     unsigned int apic, unsigned int pin, bool raw,
     struct IO_APIC_route_entry e)
 {
-    union entry_union eu = { .entry = e };
-
     if ( raw || !iommu_intremap )
     {
-        __io_apic_write(apic, 0x11 + 2 * pin, eu.w2);
-        __io_apic_write(apic, 0x10 + 2 * pin, eu.w1);
+        union entry_union eu = { .entry = e };
+        union entry_union curr = {
+            .entry = __ioapic_read_entry(apic, pin, true),
+        };
+        bool masked = true;
+
+        if ( curr.entry.mask )
+        {
+            /*
+             * If pin is currently masked we can update the high part first
+             * without worrying about the RTE being in an inconsistent state.
+             */
+            if ( curr.w2 != eu.w2 )
+                __io_apic_write(apic, 0x11 + 2 * pin, eu.w2);
+            if ( curr.w1 != eu.w1 )
+                __io_apic_write(apic, 0x10 + 2 * pin, eu.w1);
+            return;
+        }
+
+        if ( curr.w1 != eu.w1 && curr.w2 != eu.w2 && !eu.entry.mask )
+        {
+            /*
+             * If updating both halves mask the entry while updating so
+             * interrupts are not injected with an inconsistent RTE.
+             */
+            eu.entry.mask = 1;
+            masked = false;
+        }
+
+        if ( curr.w1 != eu.w1 )
+            __io_apic_write(apic, 0x10 + 2 * pin, eu.w1);
+        if ( curr.w2 != eu.w2 )
+            __io_apic_write(apic, 0x11 + 2 * pin, eu.w2);
+
+        if ( !masked )
+        {
+            eu.entry.mask = 0;
+            __io_apic_write(apic, 0x10 + 2 * pin, eu.w1);
+        }
     }
     else
         iommu_update_ire_from_apic(apic, pin, e.raw);
@@ -1780,7 +1815,7 @@ static hw_irq_controller ioapic_edge_type = {
     .startup 	= startup_edge_ioapic_irq,
     .shutdown 	= irq_shutdown_none,
     .enable 	= unmask_IO_APIC_irq,
-    .disable 	= mask_IO_APIC_irq,
+    .disable 	= irq_disable_none,
     .ack 		= ack_edge_ioapic_irq,
     .set_affinity 	= set_ioapic_affinity_irq,
 };
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:09:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:09:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310229.526930 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXUs-0006al-Ra; Thu, 21 Apr 2022 14:09:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310229.526930; Thu, 21 Apr 2022 14:09:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXUs-0006ae-Of; Thu, 21 Apr 2022 14:09:26 +0000
Received: by outflank-mailman (input) for mailman id 310229;
 Thu, 21 Apr 2022 14:09:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MTNk=U7=citrix.com=prvs=103b1a447=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nhXUr-0006aY-6G
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:09:25 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a0a95e50-c17c-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 16:09:18 +0200 (CEST)
Received: from mail-sn1anam02lp2047.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 10:05:59 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by CO1PR03MB5907.namprd03.prod.outlook.com (2603:10b6:303:6e::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 14:05:57 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::9981:cb1d:41c8:5530]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::9981:cb1d:41c8:5530%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 14:05:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0a95e50-c17c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650550163;
  h=from:to:subject:date:message-id:references:in-reply-to:
   mime-version;
  bh=x0ZAHfLPo+RLjLOtB3HPJVhPseLBSbaqlReY8TmEaFA=;
  b=KgFHkyij0S3P/ilBAoMso9C8O9PJOr1fWStcUYsSKTMbmYp0SNAv01Ps
   AM8d6XoV55nMVI4Dg1mRopRm2PrNjhIN96NtWHbWbQ5ktj56wHy7bDRG+
   /ORv1UaFWWQoyWanKsUgXk3bLwT7FYGwZDe6NQoZ+6tLqDjnWyYCQBJ+S
   I=;
X-IronPort-RemoteIP: 104.47.57.47
X-IronPort-MID: 69633762
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ROxQ/6/h/kv6wg1ZuIvpDrUDhnuTJUtcMsCJ2f8bNWPdYAuX7wSz/
 BJcAD7Ya7vPIDfrKpolWDmFhUxVuZaHnYVgHgdurypgF34X+MOZXY+QcB79My3KIpLIHE9ts
 s5HO9fKdco4EC+Aq0rwbrGw/CAh3q3SFrGtV7Cs1kydPeNBYH5JZUVLx75p6mIRveWEPu+th
 T/Ti5LRZ1X+imZ6bzIZ4fLSohpk5aqp6DlE7wE1aPwUtw6BxiUZVJ4RG/q8fiDyKmV28k9WZ
 AphIJWRpD6xE8IFU4v9+lrDWhRWBOaUZ2Bis1IOM0SYqkEqShcaj+BqbJLwVW8N02/Tx4wrk
 Y0U3XCNYVxB0pPkybx1vyZwS0mSDYUekFMQCSHi2SA75xSun0rEm52CPmlvVWEr0r8f7VV13
 e4ZMFgwgiWr3Ipa9l4Zpt5E3azPJOGzVG8WV+oJITvxVZ7KSribK0nGCEMxMJ7dSamiEN6HD
 /f1ZwaDYzzjYjlIIFkbM6sMgf75gmGvXQZ6qE+88P9fD2j7lGSd0ZDLGf+NIJmxY5wQmUyV4
 GXb427+HxcWcsSFziaI+W6tgemJmj7nXIUVF/uz8fsCbF+7nzRPTkFJEwbk56Xm4qK9c4s3x
 0g81Scpt6c/smC2SN30RzWzoWKevw5aUN1VewE/wF/clPGPvFjDboQCZmJ/TcQ7mv0VfDYn/
 23YztzDBhxhr4TAHBpx8Z/R91teIxM9PWIEICMJUwYBy93iu50oyALCSM55F6y4hcGzHiv/q
 xiWpS03nPMQy8oG0aqq8FTvjDelp5yPRQkwji3WWH6o6kZpaYiNZoq05Fyd5vFFRK6VR1+As
 XxCmMmG4fomCouEnyiABu4KGdmB7PafMSbAhkZvEoNn6HKm/3e5fqhf5Th/IAFiNcNsUSfke
 lTapBl565paPX/sZqhyC6qyBtory+74GN3/TffSRt1Ufp14cgSA+jpzYVKR2W+rm08p+Yk9N
 o2cat2EFmsBBOJsyz/eb/8RzKUxzyYi7WrWTIL8yVKs1r/2THySSbFDMlqmb+Yl4afCqwLQm
 /5SO8SD0VNeX+nzeSje6qYDLFQLK2h9Dpfzw+RNceSCJEx8EWctC/bOyJsoYYkjlKNQ/s/h5
 G2wX3h92VX2hHDZAQiSY3UlY7TqNb5apG4nexc0MFCj1mILaJyqqqwYcvMfRqUq6+V50bhUT
 v0Jds+aC/JDYjjA4TIQd4b6to95Mh+sgGqmIS2hZzQueo96cAbA8NTkYwjH+TEHC2y8ss5Wi
 5+t2A2dYocJTh9pDcX+ZPW1yV6ron8Hm/k0VEzNSvFIY1nl+oVuLy33j9c0LtsKJBGFwSGVv
 y6UHBMZqO/ls4Iztt7TisistYagFfJjH0xcN2be5LeycyLd+wKLzZdbVeeUfRjUTG7u5Li5f
 uJR0u39N/sc2l1NtuJUGL9xwaUzz9DmvbNdw0JvG3CjR1i0D6xIK3yPz85J8KZKgKJa0SO/X
 0OT0thcN6+ANM7sHBgWPgVNRvqKz/gYlTDP8f0wCEr/7S5zurGAVC16NQONgSobM7xyPJgN0
 eYlucgGrQe4j3ICKNGMyDxT6GKII20oXKAut5VcC4ju4iIhzVtIcNrRES/y7ZSGbf1DN0ArJ
 nmfg6+qr79Zx0zTemA/PX3T3PFBjNIFvxUi5FgGJkqIl8CDgvYy1hBL7RwpRxhY1VNJyYpbM
 3NrcU8zOqSK8zZui+BMWmmtH0dKAxjx0nb4y0YN0lbYSUaofmXXKSs2PuPl1FgY9H5GODtB+
 7Wwk2PpXDysd8b0tgM4Q0Njp/XlTocoriXNncmmG4KOGJxSSTvjmbK0am0gsRr8DN4pwkvKu
 YFC++J9arbyMyIKlKQ9B5OHzrQbSB2CJ2tqTOlo+eUCGmS0UDa21DuVIka9YPRRNufK+k+1D
 c9pDs9XXhH43yGLxhgXCKMUP7912vsB4MYeYfXgImtum6CUqSZ1r574+S33hWttSNJr+e43J
 4X5eiKFDmWWhGZR3W7KxOFBO2G4aN1CYxfu0eSd+f8MUZkEtYlRnVoa17K1uzCONlJu+RuR5
 FnHf/WOk7MkzplwlYzxFKkFHx+zNd74SOWP9ka0rshKatTMd8zJsmv5t2XaAuifBpNJM/wfq
 FhHmIKshispYJ5ev7jlpqS8
IronPort-HdrOrdr: A9a23:ovshHK8h5Yr5MUtnOFNuk+Ftdb1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYW4qKQkdcKO7SdK9qBLnhNRICOwqUYtKMzOW3FdAQLsC0WKm+UyYJ8SczJ8R6U
 4DSdkYNDSYNzET4qjHCUuDYrAdKbK8gcOVbJLlvhJQpHZRGsNdBmlCajqzIwlTfk1rFJA5HJ
 2T6o5svDy7Y0kaacy9Gz0sQ/XDj8ejruOoXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU
 DYjg3C4Lm5uf3T8G6T64aT1eUWpDLS8KoBOCW+sLlWFtwqsHfsWG1VYczDgNnympDq1L9lqq
 iKn/5qBbUI15qYRBDJnfKq4Xit7N9m0Q6c9XaIxXTkusD3XzQ8Fo5Igp9YaALQ7w46sMh7y7
 8j5RPRi3LGZSmw4BgVyuK4IC2CrHDE10bKUNRj/EB3QM8bcvtcvIYf9ERaHNMJGz/78pkuFK
 1rANvH7PhbfFuGZzSB11Mfi+CETzA2BFOLU0ICssua33xfm2141VIRwIgakm0b/JwwRpFY76
 DPM7hulrtJUsgKBJgNTNspUI+yECjAUBjMOGWdLRDuE7wGIWvEr9rt7LA89IiRCeg1JVsJ6e
 H8uX9jxB8PkhjVeLOzNbVwg2DwaXT4WyjxwcdD4JU8sqHgRdPQQF++dGw=
X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; 
   d="asc'?scan'208";a="69633762"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TWg34iEL9tv0FgjwTvYS/IdlOkLxDSxtbUYV+/hBTQUPBgVFDvVmJc+kafv2epIfLrFSBRhN2emLnuUhVGy2lPKH5t2rz6wr+5jy9yiOMbsjFdls4JV0o//TR5W5fd+s1td/AwKIDQ5i0UQmREBNnzVS+gz/DbcueAmIQYPuq1M7gyUoqaUNXwVUtRoswdoHewdPdAaqa0C4PtwQAwj4XF3by4VyNwzMDRgm/+rpekH7sStEJJVmWmO8qnPe4J9MDe6qtAz1uQqLZYyUQEcYnF73YyoVyOdzC/xgrpj9ZTyNR7aMtBn4Nf3dqVF5CmKrw0+ABoghVZsq9wzYzjS4zA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=afOtrwEoP3isJg4lNyUk+9tUuNr4rW2pgSxV3lpuKic=;
 b=K5ZPgVp7wwJk21WHOPX5HfuqJus8rMX1iAxE8EtYhj2Dko1B1xxWExWBxfqndZUEt+znyUgQBWLcy+QZyWzZp8viO+Cgd1KFtj/XlKX5RgsxncqrfVynhZ5k0c6gEE1nnF6XJWrjpuZvAURHm4kvN72e5PErs4umcKSXQZlpqeAhVH3Q7FviWY58r03bIeFPBg9AhNylNvbPH6R5mvMsYAFZv6n8lrgt4XWSFuWPrq45AXiiC9KPhCduHQp4IKCV9eZA+smyChvucdQqjfQ1ovxcQMZGi9tRSmQDh6e83fbW49E6fyGBdBpEoLk9EmJxhTfzlDOMgGaaB4/EQN6vhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=afOtrwEoP3isJg4lNyUk+9tUuNr4rW2pgSxV3lpuKic=;
 b=Nny0gTOfmn73TUzQb2/q3Ntu53FzyqopLFBYFnnoGlwoxnEv8pJKBdxIpF/JnyNBp/T0MOnZQv3s9IFZ3bGZXRPmdHI5vZPKCkdb/Tgg8C5iXlP/m7Ep0to181uzbZsdUtQrGhNqtKZNtTCB6IU4OD7LLTHAAochFYbS1uTmwK4=
From: George Dunlap <George.Dunlap@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>, Tamas K Lengyel
	<tamas.k.lengyel@gmail.com>, "intel-xen@intel.com" <intel-xen@intel.com>,
	"daniel.kiper@oracle.com" <daniel.kiper@oracle.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Sergey Dyasli <sergey.dyasli@citrix.com>, Christopher
 Clark <christopher.w.clark@gmail.com>, Rich Persaud <persaur@gmail.com>,
	Kevin Pearson <kevin.pearson@ortmanconsulting.com>, Juergen Gross
	<jgross@suse.com>, =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= <pdurrant@amazon.com>,
	"Ji, John" <john.ji@intel.com>, "edgar.iglesias@xilinx.com"
	<edgar.iglesias@xilinx.com>, "robin.randhawa@arm.com"
	<robin.randhawa@arm.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>, Matt
 Spencer <Matt.Spencer@arm.com>, Stewart Hildebrand
	<Stewart.Hildebrand@dornerworks.com>, Volodymyr Babchuk
	<volodymyr_babchuk@epam.com>, Jeff Kubascik <Jeff.Kubascik@dornerworks.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Rian Quinn <rianquinn@gmail.com>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?=
	<cardoe@cardoe.com>, George Dunlap <George.Dunlap@citrix.com>, David
 Woodhouse <dwmw@amazon.co.uk>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= <amit@infradead.org>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?=
	<varadgautam@gmail.com>, Brian Woods <brian.woods@xilinx.com>, Robert Townley
	<rob.townley@gmail.com>, Bobby Eshleman <bobby.eshleman@gmail.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?=
	<cminyard@mvista.com>, Olivier Lambert <olivier.lambert@vates.fr>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>, Ash Wilding <ash.j.wilding@gmail.com>,
	Rahul Singh <Rahul.Singh@arm.com>, =?utf-8?B?UGlvdHIgS3LDs2w=?=
	<piotr.krol@3mdeb.com>, Brendan Kerrigan <brendank310@gmail.com>, "Thierry
 Laurion (Insurgo)" <insurgo@riseup.net>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@epam.com>, Deepthi <deepthi.m@ltts.com>, Scott Davis
	<scottwd@gmail.com>, Ben Boyd <ben@exotanium.io>, Anthony Perard
	<anthony.perard@citrix.com>, Michal Orzel <michal.orzel@arm.com>
Subject: Re: Poll for new Community Call time
Thread-Topic: Poll for new Community Call time
Thread-Index: AQHYSmRtw5Y+hIDN70CUQUPEZT9yi6z6fQEA
Date: Thu, 21 Apr 2022 14:05:56 +0000
Message-ID: <3863CBF8-797A-418E-A4D0-5C8CC93EB052@citrix.com>
References: <A4C455B8-C7DF-4287-9DB3-BCFBDBCAFA12@citrix.com>
In-Reply-To: <A4C455B8-C7DF-4287-9DB3-BCFBDBCAFA12@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 867238b8-fc14-41be-ff52-08da23a00e73
x-ms-traffictypediagnostic: CO1PR03MB5907:EE_
x-microsoft-antispam-prvs:
 <CO1PR03MB5907B791B8280243A5E4C9A899F49@CO1PR03MB5907.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 SGnKTgJlN4cAgEqc3bAuWXhu8Qri59Ue7aPCjsJEXb7Wd/yS/7acp7Xhu0IzhOQhJPOJGzNggnKT3BhMKEYbwXsvn5uMhxiHc2Mt1yjvB7tBdH0lmzsMS38HM1Nmtp7quQflYBPtGvSEo5oz1vsl1kA/TlC53PsYnUj0CCz1NcTVh/X7zGvGzVAI98stsVb1Ro5jjXe9Y6wLUHku2D4D/s+8aqGCRcv5Vt+e0RnwwmJ6Y+JwFb328r2az3YAKqgd9gmdQ0azW2uncrI5ESHjhlyKKQ+OLjsC2jtIBeb3DRO51zsbwicw1soM3FrDaT3OiwIXLlZoOlIk/P/2vyIKxeLT05Zv09d+hYYYmfelxNGP5mw282P7F5sSKOKY+VoqR/h+onElesKDh6ykGD12p4tzRorXgBZq4P8jp+G8Oljx7r2E5RH5MtGnWya4nyjRb+ZdihD31HysLKvwuJ9t0nlqMcpu/A+DGtXFDYQ85rJ9xh6osVmEHX8vNlL0ukbTlrPRQ8wwtdSF7uI6j1viHBLprKH/Y+b9HL5THb/ABXy6SmkO8yYbc0C0lS0633E1Eww6X3zUSmEjgqeN4a+imdNZ9hko9Jid0dSGLRur6szWNES3zD/gbQCsX5aGqYCmi5LhP0CSw1WbwMOYOuKo+Zpezxbx6y34RsMjRQllGyZWpm/0pHwTqthAfGfVhiBoKWfM+PBBZfh9mcxr1fn4Mqztb4KDUYxQ+jTKL1qDCxn3MNsIaCgNOZmn4RwDxqtg+EyRX8KH5DU4RLkVsrqEbzRO5UsWi/C+ciGiOwUDeLFJQi33vEvjj78Mb3w9B+0OxueOxHqcXFMBy6+Bj0rmKlYTlQ3JaKHQvV8igd7owNM=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(66446008)(2906002)(91956017)(4744005)(8676002)(99936003)(66476007)(186003)(66556008)(66946007)(76116006)(110136005)(36756003)(33656002)(5660300002)(7416002)(7406005)(8936002)(316002)(26005)(86362001)(6486002)(71200400001)(966005)(2616005)(6506007)(6512007)(82960400001)(83380400001)(122000001)(38100700002)(921005)(38070700005)(508600001)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZGVOb0kyTzBUTnFQbFFBMHZqK1JoOFR1OVBFNjkyTWdJczVFc0pyT0o3YS9G?=
 =?utf-8?B?bDE1bXlVb3I2UnFWODhZQWNoVUNLRWlMdVJtQU5XcEtBMlpqMys1OUljS21G?=
 =?utf-8?B?Y2JVQlh5alFMQXNHZVdFQnYvTkk5elp1QU9VNWsyN3hxMHpITUhnS25haFQw?=
 =?utf-8?B?d2sreFJ0eHIzRmNLbnhXeGFHdHpQRENNTk45T3lXTHpOamJ3NnhWeDcxaDZH?=
 =?utf-8?B?Y2FDNHdVQU5HSFNkU1RPalV3encxbjBZVlBrQ2xpV0tNRWo3WWpMWHlFTk9l?=
 =?utf-8?B?QzYyNnM1Vzh3aGtSSDdwWDluYzhuNE5lbE9nTW15SnNaVnRzV1k2SU1tRTVm?=
 =?utf-8?B?YmpUNm9Sd1JEK3dKZVluOTROZDNzdzVqUDVLcjlBRkJHdS83NUNmOEJzSzJl?=
 =?utf-8?B?ZWhjbUszQVNIY3hRNnhMdElVcERQc3EzNFBrWUgxVVhoY01RQ2dxb01hRFc1?=
 =?utf-8?B?clkrWUlhVjYzZnFNVUtYUmgyWnVtTVd4S1pKb1c3RExhNVBjYWtqTXB3S2lU?=
 =?utf-8?B?a0pMR1Awb1R2T2tueTlWRVQwTFl2OHVVK3FDeUtQZjRuQy8wdzhOVjFDZzNh?=
 =?utf-8?B?NXVGdWpHdTZZN0pyNFZyemdqNnRIQ3N5NEhsYmxtdFhlQ2ZBWmJtMm1NVjVI?=
 =?utf-8?B?WHlUL3hhVlZvaVlQb3JnOTl4bzdScU92R0xkTy9ZZEdhemNIZHAvcTYvUUg5?=
 =?utf-8?B?WTU0QloyQXlnTnB0dEdCTWpMWnpmK25DYW1zdkxUV1dNeXZNS1pZWm5lN0hC?=
 =?utf-8?B?OUNvQ1U0L1FWQWh5aFJ2ZlZERTFLam5Ndk84U05hQWdpL1VJWW1lc1VnQnly?=
 =?utf-8?B?Qi8vbjNsKzNONnlXWE1VcUR0ZjhtUEU4L2UxVFNGNko5QnBVZktPcWNQQWRM?=
 =?utf-8?B?YzJrTWZkYnMvM2NqSUhTa253M1kxNEdUam5ra1VLZXlJRGJSSDdjNXRxM2F4?=
 =?utf-8?B?YWo3SlA5TXgyOFcrYWxxQWpGMzFiZ2RLL0Q2ZExWcHMrOFJud0EyZ3VrNU9q?=
 =?utf-8?B?azdoZFdjKzY3dm84MEJ3VUF1N2NMcFFUNmVVekExTDVyNGNPbFVtazUyRGJP?=
 =?utf-8?B?dUU4UCs5UnVqRHpIVzc3dHc4QVNVYmNIUlNaWk1ZUTJjTjZZU2RIOFRKdytu?=
 =?utf-8?B?N254OUVBangvcGh3dHMyNEJxelRKT0tQYjNIMnpHeFV6WTRpQk1KWTNJT3Ra?=
 =?utf-8?B?SFlaU0VtajgzU2tUWGhUVThHb1cwcG9FM1VMa25kdlAvdjlPYVdka25paDRp?=
 =?utf-8?B?YlJQbmlxbDhCQjA5c1VheGNqYm9EclNFdDIzUWs3b1ZzeVBhcDJQMk1Ea2Rt?=
 =?utf-8?B?SHlyR0N5ODJPT0NTaVNMUDV1N2lhdVMzRGovUG10Mkh6OXc5VWtCOVVpUjZR?=
 =?utf-8?B?OHhvc0daVUs2WDNuMGtNT2JXSkx2dkswUHFVL3l6dkJlVFZXNWFYaVdUaXY2?=
 =?utf-8?B?Vk9nV0dsSy9DMmNUMFVyOFk0OENVcHFEVWRvblV5MEo1VUU1cUFCUWFQYmJu?=
 =?utf-8?B?YkhYdkZLMUJ4MEEyVjJxeDRnSmFUVlNveC9Pc2hLZkcwcU04cmNnSjg3RXJU?=
 =?utf-8?B?NzA3RzFzQk93MXovU2JZVnhhVE5Hd0dQOFpFNGZCN0xIZ3ZnV0d5aVNIRm1h?=
 =?utf-8?B?cHZYNUFEOGZmVkUxYkgxaW5qbUFKSXI4U3VJR0pnVEZibjNyYzU2eGNxRkNk?=
 =?utf-8?B?US9vRi80engxc2o0bFRxRU9JR2wzV3g3cEpLY2hzYnZNQmNNZlprS2poODIz?=
 =?utf-8?B?WjJ1QjZMV1ZUSTQxSFA3VHRjaThLL2U2ZXU5eW1ZSjNLNzZSbEZGV2pmWlpt?=
 =?utf-8?B?djRFNFZjWDY5cDNGZ3lSVnhabTZkT2lsYXo0Y09ySTVpQ3prc2M0a1ZLMi9k?=
 =?utf-8?B?MnovR3hNRzE4WTlKdWxwdVRhSmExdENwczdSUkRWWExheThrZnNSUHlrVXFt?=
 =?utf-8?B?YkVDTHdmTlFOWE0xTDVRS0d2N1FHUTNvb2RNNEo0b3hubk1nQ1pXSHh5NXli?=
 =?utf-8?B?U1B2TjJ6RVV2NkRVUFlFcTdzUzFYY0FPU0VwQVpRY0pjam50YzdhV3pESXhB?=
 =?utf-8?B?b1VKVml0SnhadFNlK2hDaWplakxId2pqaFRKejU3N1Q0Y1JCbTVma0ErQlhO?=
 =?utf-8?B?b1c1NW1MQXFWa293NG4vclR2ampkamZyRW9McmpaemJPRGd4eWVEOGZqTFpI?=
 =?utf-8?B?Zlp3Y2xiLzllWlpDZWd3eE54S25wa2w0cytHSnEzV2NwMW5qc3ZreE92ajN6?=
 =?utf-8?B?NncrMDlHK3MrKzRZbmJYckxKenBkNmtpT0QvVXhaTHJFUzhEbDN5LzFxM1pU?=
 =?utf-8?B?SnFuNkpqMWcwbzhSTC84UGNXUzh6VmRmRlZlOXp6L2hYOHBSS29KbGhaam1V?=
 =?utf-8?Q?YSG0KKgqJ9Tel6EkyOb+2F7vt6zvD219XOrtt?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_6312E44F-4C5A-4B46-8F59-4DA274E0E10A";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 867238b8-fc14-41be-ff52-08da23a00e73
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 14:05:56.9944
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Nyae3gh5iJmoSg8xPeL5MuQBkgi1UePeQ71uhaovMT9y6LIIwvrSrNoWLvb13SmYVMmpiLes7PkDwW4NNM2aROyeONV+jGIncVrMzGfASq0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5907

--Apple-Mail=_6312E44F-4C5A-4B46-8F59-4DA274E0E10A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hello everyone,

The polling has now closed.  Thank you everyone who participated.  The =
best time turned out to be 4pm British Time on Thursday.  I know this is =
hard for some people, but it was always unlikely to find a time which =
suited everyone.

Peace,
 -George

> On Apr 7, 2022, at 10:46 AM, George Dunlap <george.dunlap@citrix.com> =
wrote:
>=20
> As discussed in the community call on Tuesday, here=E2=80=99s the poll =
for the new community call time.  If we don=E2=80=99t find a good time, =
we may just move back to 4pm BST Thursday, which is what it was before =
we moved it to Tuesday so that Ashley could run the meetings.
>=20
> I=E2=80=99ll close the poll and announce the new date after 2 weeks.
>=20
> https://doodle.com/meeting/participate/id/e1wwl5mb
>=20
> Thanks,
> -George


--Apple-Mail=_6312E44F-4C5A-4B46-8F59-4DA274E0E10A
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJhZLoACgkQshXHp8eE
G+0DQwgAlKfJWMD6O3x2yxgb2ZVq7zlDLm6HQNPLfo06Y40dkQdCfQXVTwa6iPVv
nUlRMXB7ACABz3B1PQWRdF9kj4wdPJMCWgTuC4Zsu7iUnjTBfyKwLr8+WHKBTyU3
PU2Dxl3QNurCmYD+XrVPT8eLQdU6ikgwpWQrev/NDfGLqrociR/PhjVy34AtStks
KrF4Cn0dYQVGXPhlVEkc0WzL1+KMeJrME7Zvt7mckv0cUXy2N7uNcThoFCP8r4E6
vIQwC46SSV66xewZrF5Je1AIetwBWNkQ5tC/EwlkBguOvNHeRBQ1lJ2TB16A15z4
bcUCATwuwrNN38y/zPt/P3wxFFr/8g==
=WKOn
-----END PGP SIGNATURE-----

--Apple-Mail=_6312E44F-4C5A-4B46-8F59-4DA274E0E10A--


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:12:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:12:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310236.526942 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXXV-0008Jb-Cy; Thu, 21 Apr 2022 14:12:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310236.526942; Thu, 21 Apr 2022 14:12:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXXV-0008JU-9v; Thu, 21 Apr 2022 14:12:09 +0000
Received: by outflank-mailman (input) for mailman id 310236;
 Thu, 21 Apr 2022 14:12:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhXXU-0008JM-Eh
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:12:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 06ca049c-c17d-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 16:12:07 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-AffPjT4fNx6u0geZCt_A5g-1; Thu, 21 Apr 2022 16:12:05 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4497.eurprd04.prod.outlook.com (2603:10a6:208:6a::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 14:12:04 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 14:12:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06ca049c-c17d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650550327;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=D3rLLPwGQb6X5D7LmfRjyLc5HrRUq6dttUpO0EEHTsE=;
	b=dY0gTlBO3RjeviiVIIY5VeA9Sha3TSTfHGcxUrZ9oNAJecapPhrJu3WeVhBnMpafsY/21+
	+PUTUmVrpvE8WPHdn0qaJ+XGTjyde5KgiUoOLd1uISshLYvfEpeRu7QXU0d3Z8QCnVGtjq
	ajhAF1Jq5TmYNPLWoxxAXgeUlY7TIvw=
X-MC-Unique: AffPjT4fNx6u0geZCt_A5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WAwRJTLOw2E1a9XMRYLx6uAX12CBX9kUd/YKdGGGhKwrLSUpp5ceOhOZNb9HtlgZViDcDp0TW617vB2ZhxgPrSnfLnp4UQuoxii0TYAGfHlPWajgGpwfojP+QGcs+HwB2A+vigNjK8QLFZF1Hs94Ox9/jcRdGlMms76BYRDsofA3d/Fq75jsGrbzDtusU/phePMWJAN78N7hBZsNmmjNJmCiPIskhNoZIF4M5Qw/pUOIn680V6rP6obgVeMt+gbS15wchYedPVs73k1F1QnAsx1PtUIWzU3M+9vGBKupctj5trpTKk1TDayeeuGzSDDK/HDcPC6zRt4PzztlJVwkow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vXo0w0CYODB9ALcu+zQYRCzxY1GbV6wdvC3xednxnSs=;
 b=SHnT6Y8ke/NT3jM90q3y0eTfyDIsJ5M+7HZRfXlJl0qCzeB5CcvE9FocEFFfD2nc0y9ekw9+RW2gFDP/D8q05tJ+vnpWLFwab7+5gbqzmnim4oX+SAa5lmd1hgUCoHB7NC1KDciny/H/r3milM7jUaPvpLrQ7iU8CjS4Fi1JLLnchGsgaw3Z8eiM4ap8gnsXubTsQ6LsZZEgD7EhQ5BNsmjgTQrbN2rLa5Ljv0Uv55kWoeRfpGleieEJhuTVybX0IEQPSACu6RGVOzeHXXRMHn3rFiDfuEBkRn7He3KGeh/1pue3q3a+D3y+89MItNJHTWN1fAaRW0T1aodiZWO4pg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a2792176-88e7-0da2-582c-157620fa62fe@suse.com>
Date: Thu, 21 Apr 2022 16:12:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: Ranconfig failure between VT-d and HVM
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: xen-devel <xen-devel@lists.xenproject.org>
References: <9537f2bf-981c-d4ac-d41d-ab59f7d7ab2c@citrix.com>
 <4095a567-86aa-8311-ed92-730348ab43d3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4095a567-86aa-8311-ed92-730348ab43d3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0064.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::41) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5752ca27-8c2f-400c-bb4e-08da23a0e8a3
X-MS-TrafficTypeDiagnostic: AM0PR04MB4497:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4497C31FD1DF2480551A80A8B3F49@AM0PR04MB4497.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7ujCGmVf9Y/d3G54WRlxHUjQtXSv6CV+FFD0FgjY3ZNb5sLV/CBQfLltprXLBnpSDdPjrOsE4G2cDxlkon4opfimWsRK26lGWJnunFoH+YaZcxCr0yGT+UmAg4gD4CuoiFP5I7M0SIMetcIZac412Xk1dWQPbqNPQ8XGtmCaj90r6LCfVA1JrRlkuHfFIkoHN0eN/zC8i1ybZfcSc9054QBjBd5hBqqCE565Zg9MkcQuPYCM1/iHax6whViLV1rlwN6VCslGYlbM60psDOR42YeUTKwqiMxXuEWOGmM4yTcGIrIH4Te1bExEc8pUuBfMUM6+OKvqBUYvaWTogAC1ikhB48JEFfljXs/aMbHEzjH4Qtb2zXnG1iM8F7GabR4P7rnKwz4IUP6HlrNszOhIBlPbonfD8YxI6zL+fpDPPsQ5lCC3fzf1+dXHASt9kI3v4C01VCdRtx9gfgbO10tXV6xkCR2tqt+W99H6bTm+q7IpF/+0tpI9F0BtArjlo+Nytvd2HxD+t7S9GxxeXHE7SrIZbBbdHn/cHDHIRuI5E/cDCPKHKvDZ3bkoUKa5Q9J9hoZPIbXzx38VMZ86ZT2zSbTfTBBj5hr6mOm2qQ1dvXPWSFChKczqdDDU3vGLY/RBosTAD6toZ8wpXYDPat/Y7IhiJVz98gOT3pVFmAPJRAVcBR4MmYeWBHxyXyrMK/oQcGSS+sqA7uepazn+L28jeOzrKJh47GYBPIeqvKtWMJydlW5VvtTCcKu4wRL6m4x3sX7ugWAGUMzjBeOvSdwtElX4H0zOl9JzxrqNK0baTuPQLylNJLRGtlUJXqG7eQep
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(6916009)(5660300002)(6506007)(66556008)(36756003)(31686004)(186003)(316002)(966005)(6486002)(508600001)(8936002)(8676002)(26005)(2616005)(66476007)(66946007)(4326008)(2906002)(53546011)(6512007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8VS2dPpRUFw7FlV7R4fWsRRZtczcKh+wU27xXYlfKoR1nz7HfM0MOnXXlBYL?=
 =?us-ascii?Q?Z17XTxqEqeHisZGAcK2o9hix/4Wz+u6zRvoQDReEz45gkUGODxe+PWt5Xi95?=
 =?us-ascii?Q?TLsfGuBqTAt4+DeFk+qlCfwzm4m5rnPUmhiVW7q4FYdjs/vXOXEhIHiEvqke?=
 =?us-ascii?Q?/g+WE+TELSghmko0ZoggE4qRrrE8dO5nijyez8Hv/wdkncqQOgZaVCOstQHt?=
 =?us-ascii?Q?PF8DYZZRJljDzNLA31/+zsG5gjIy8R7ghXuwNuWLGrHZ3x/HLh2XRndVX9Pu?=
 =?us-ascii?Q?ZUljJe42tmSHYMKeoOFKxJo5ArK6UNy8OpBbwUT6MbRF4+4VDQhNHbKco+U/?=
 =?us-ascii?Q?hB2WH/P1738xOe2+iCvb/EALsvfMdo9/D6ho35GckzJ25aP66bpAkMqKEuBk?=
 =?us-ascii?Q?HH0QrfFxfNrw4NTBGSJYmzvYIfUYxsDxTLjQq/U7R1C7S7diFvKxsM8Ir30k?=
 =?us-ascii?Q?HP6C21aGpRzLeQJys10/VNsr6GS1pTi8mLp8dPP96wbk+7sJ4Brc/4R6W1Oc?=
 =?us-ascii?Q?aK9HDQ5yX9SS9/bOxR2LH3vOp7m3E0VCBt2chYJ9hf4zZF8n5mJlYnXla81p?=
 =?us-ascii?Q?hhRXk6AVfMmWknmIszTQd7llKviaGO5sbwKNIH4Yv8QyubzOoh6DMEGalGaE?=
 =?us-ascii?Q?3YWhdQO2FAbUDqkDi98lbUnLQ1dQWx9/4UAkZu7b4FS6lCO+l0vs3VJO0omF?=
 =?us-ascii?Q?G+R43FNXy3cXkQ8IyMeVy4aIaamxVBUOg0JfEvnDa1Yw6mrpQI7eN6VvSAx9?=
 =?us-ascii?Q?aDeg/CU6PSpqnZiaaoQlN9Xtm5ga2pfsY7ooZqb0Ki+GxhZqkAxOoRBD4VNk?=
 =?us-ascii?Q?KLkOflVK200fqaQGxEvuKyNmOgWQCQBrvrRxSqFZK5PUzN8ouUYuMEQ+T4XO?=
 =?us-ascii?Q?p/8JU4S0Nu8AQXzqIBejTl2YOh9vKdi8EN4jaRm6SCsjKcCfXFyo0DA/5j18?=
 =?us-ascii?Q?H6jsDQxNk6jTTClTIvIWtaZt4HsZhVXInlSgXauUT9S2gA968SQYzCQpIqqC?=
 =?us-ascii?Q?DNZgeTcroEFP1vJKQFkGZlfKDFYqR+DxgyeUhW0YD8pujGBpJ1nBTJQ8at89?=
 =?us-ascii?Q?ED5z9i4VYxr929pjOsDad4kny3qWkRiSgWO+WTMqFM5pl6obNPKWvvSwxOnu?=
 =?us-ascii?Q?EZQDNyJRQZ4kJ7diQS91MO2uePZhdACrwlVKWqvWMhV+k4PNVPcQSZM8Fy4P?=
 =?us-ascii?Q?iOc3f0jPgfPiSvQawfXQ7rvY7vJ3sRcWwyxUfMXIwB1A/F8rfUqZudz8XFGJ?=
 =?us-ascii?Q?ykNb2OPnrcNCKboq2ULUVP0vR/nsgRiPmntoJUCFsLBS4acxTpGgOweC9Pyv?=
 =?us-ascii?Q?vqZ4FP+7UnOZRV0Pr85/iI/a5vz+/yBcUQ+abQ+21utV6pZOQ4qHiWN3iwjf?=
 =?us-ascii?Q?kKhvMINyhwAfn00FD1R3Vl+Bgr0Qs/fRJ5EDXMnFfZ62Y5WyWcZw2c8aA5/n?=
 =?us-ascii?Q?KdOCnyYlakhSm3sH5uTSEr9NHiWjKsDC0tjWCKkfC8Hjw2EUkSnlqNAat5mO?=
 =?us-ascii?Q?MioVuxKyZryh4kTn+hXHDnzX8pImi3ATrWgA2E9TmUNrse2/FN1j4woTHvUm?=
 =?us-ascii?Q?4nc3ovnLNPKnmBJhQmZPVjJ94K/U/YuW8SCI3u0ttfUwz/+UZ7WlgOSDYxN+?=
 =?us-ascii?Q?F9dbJworv3bDXT7PzmHXfNVm8Hk+NU8yN7b0IFOzQtqSy1jD0Vi5BJQIDwUi?=
 =?us-ascii?Q?nZrMno5VS7nY5i+L1SuNGc765zimeod+nJ1JeKoIxUZ5dCs3izvNf/M9H4Y0?=
 =?us-ascii?Q?MhTjLJ6oaQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5752ca27-8c2f-400c-bb4e-08da23a0e8a3
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 14:12:03.3786
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5vMjp6z60QgPvJmPNxE3u4VaECUKUZL6Dd5AziA/QRwd+W8jISDvjmvfHY1/rneRXCIJLcSCjZVrYN4f595Rew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4497

On 20.04.2022 20:01, Andrew Cooper wrote:
> On 20/04/2022 18:49, Andrew Cooper wrote:
>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/2355562119
>>
>> ld: prelink.o: in function `vtd_setup':
>> drivers/passthrough/vtd/iommu.c:(.init.text+0x219f6): undefined
>> reference to `opt_hap_2mb'
>> drivers/passthrough/vtd/iommu.c:(.init.text+0x219f6): relocation
>> truncated to fit: R_X86_64_PC32 against undefined symbol `opt_hap_2mb'
>> ld: drivers/passthrough/vtd/iommu.c:(.init.text+0x21a23): undefined
>> reference to `opt_hap_1gb'
>> drivers/passthrough/vtd/iommu.c:(.init.text+0x21a23): relocation
>> truncated to fit: R_X86_64_PC32 against undefined symbol `opt_hap_1gb'
>> ld: ./.xen-syms.0: hidden symbol `opt_hap_2mb' isn't defined
>> ld: final link failed: bad value
>> make[3]: *** [arch/x86/Makefile:137: xen-syms] Error 1
>>
>> It's really not clear why this has first show up now.=C2=A0 There has be=
en a
>> huge quantity of noise in Gitlab CI for the past 3 weeks with ARM being
>> offline, but I can't see anything relevant in the large number of IOMMU
>> changes in that period.
>>
>> Anyway, the issue is simple.=C2=A0 It's vtd_ept_page_compatible() in a
>> !CONFIG_HVM build.
>=20
> And just after sending, I realised it's not an IOMMU change.
>=20
> commit c479415610f0448bb07d39185e72ef36e08ebec0
> Author: Jan Beulich <jbeulich@suse.com>
> Date:=C2=A0=C2=A0 Fri Apr 8 13:50:29 2022
>=20
> =C2=A0=C2=A0=C2=A0 x86/P2M: p2m.c is HVM-only
>=20
>=20
> CI disputes the claim.

Just as an intermediate result: In my !HVM build (with gcc11) this

        if ( !vtd_ept_page_compatible(iommu) )
            clear_iommu_hap_pt_share();

simply compiles to nothing, which I assume is the result of
clear_iommu_hap_pt_share() doing nothing in that case. Hence no
reference to opt_hap_{2mb,1gb}.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:15:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:15:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310243.526953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXaV-0000V9-Rc; Thu, 21 Apr 2022 14:15:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310243.526953; Thu, 21 Apr 2022 14:15:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXaV-0000V2-Oa; Thu, 21 Apr 2022 14:15:15 +0000
Received: by outflank-mailman (input) for mailman id 310243;
 Thu, 21 Apr 2022 14:15:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=q+Sl=U7=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhXaT-0000Uw-TC
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:15:13 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 71c7dfaa-c17d-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 16:15:08 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 16505505017661008.6994746259218;
 Thu, 21 Apr 2022 07:15:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71c7dfaa-c17d-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650550506; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=RzgejQ1BH2k2eD9R2d68GJ8aJc6u7j9FXMsa4KkmSFhikrYcVNFGl8ScjmQU5KAyy4b6f6c7sGXozfF8+QjnXKRrPv1Xa44zg3bfyv/xJCRbm1KToPGeS01gD00PowQGeFduX6l/6xCLE+ILnox3kYtTKugDtA7SCMX3mdN9rEg=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650550506; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=Uv9Ldvfc0VWw+PaRsuAXwcxqKs5oqk/ra/UuHdM2/eg=; 
	b=X45iUa5vSbr6S44EV1bTM3UFctxBUvLh7bpgONu9+BJQVwo0r2LVewp5ws8ClniurecVTNcjdfA1HTsEssYS+A7R8lkglQ7ckblbWb+RwCCp5v/YJAIOiZ5A0wFVAgz4JrBxuyTfv2L04yzLECFM1b9w1jEc8Pu7gkbYxhfQlc4=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650550506;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=Uv9Ldvfc0VWw+PaRsuAXwcxqKs5oqk/ra/UuHdM2/eg=;
	b=r5Ev1+rpONNIBkE37yjc3ho7H4IgD8+4YdUbUrqnedweD5g+rSRzMYilZdZ11QNu
	4uVHUJYiqQMdBKx93xg747qk6ZlfODXg3nMQZeyjgHcf4cm87wzAl6prm4Kj+FXQtr0
	/DcTDtaMlah73CAFJiPeKXfL4TwIRhvsctvtFNyM=
Message-ID: <0b1b2f7b-dc81-af95-8591-4362ae0b85f9@apertussolutions.com>
Date: Thu, 21 Apr 2022 10:14:18 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Jan Beulich
 <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
 <20220420222834.5478-2-dpsmith@apertussolutions.com>
 <YmEpoDHpGP3xkAQ/@Air-de-Roger>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH v2 1/2] xsm: create idle domain privieged and demote after
 setup
In-Reply-To: <YmEpoDHpGP3xkAQ/@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 4/21/22 05:53, Roger Pau Monné wrote:
> On Wed, Apr 20, 2022 at 06:28:33PM -0400, Daniel P. Smith wrote:
>> There are now instances where internal hypervisor logic needs to make resource
>> allocation calls that are protectd by XSM checks. The internal hypervisor logic
>> is represented a number of system domains which by designed are represented by
>> non-privileged struct domain instances. To enable these logic blocks to
>> function correctly but in a controlled manner, this commit changes the idle
>> domain to be created as a privileged domain under the default policy, which is
>> inherited by the SILO policy, and demoted before transitioning to running. A
>> new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
>> type to demote the idle domain appropriately for that policy type.
>>
>> For flask a stub is added to ensure that flask policy system will function
>> correctly with this patch until flask is extended with support for starting the
>> idle domain privileged and properly demoting it on the call to
>> xsm_transtion_running.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
>>  xen/arch/arm/setup.c    |  6 ++++++
>>  xen/arch/x86/setup.c    |  6 ++++++
>>  xen/common/sched/core.c |  7 ++++++-
>>  xen/include/xsm/dummy.h | 12 ++++++++++++
>>  xen/include/xsm/xsm.h   |  6 ++++++
>>  xen/xsm/dummy.c         |  1 +
>>  xen/xsm/flask/hooks.c   | 15 +++++++++++++++
>>  7 files changed, 52 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>> index d5d0792ed4..763835aeb5 100644
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -1048,6 +1048,12 @@ void __init start_xen(unsigned long boot_phys_offset,
>>      /* Hide UART from DOM0 if we're using it */
>>      serial_endboot();
>>  
>> +    xsm_transition_running();
> 
> Could we put depriv or dipriviledge somewhere here? 'transition' seem to
> ambiguous IMO (but I'm not a native speaker).
> 
> xsm_{depriv,demote}_current();

Let me say this explanation is not to say no but to give context to the
concerns. Forms of deprive/demote were considered though when
considering the concept proposed was to change the security model where
the hypervisor/idle domain were now explicitly being give a new security
context, is_privileged and xenboot_t, under which setup is being run.
This new xsm hook is to provide a transition point for the XSM policies
to set what the running security context should be for the
hypervisor/idle domain. The name xsm_transition_running() clearly
denotes when/where this hook should be used, where as the name
xsm_depriv_current() is more generic and another developer may attempt
to use it in a manner it was not intended.

It is possible to consider creating an xsm_depriv_current() that
functions in a more generic manner but will likely be more complicated
to support general usage, especially for flask where a flask specific
"lower" security context must be provided.

If there is still a preference towards xsm_depriv_current() while
maintaining the current mechanics as it makes more sense for the
majority, I have no issue with that.

>> +
>> +    /* Ensure idle domain was not left privileged */
>> +    if ( current->domain->is_privileged )
>> +        panic("idle domain did not properly transition from setup privilege\n");
>> +
>>      system_state = SYS_STATE_active;
>>  
>>      for_each_domain( d )
>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
>> index 6f20e17892..72695dcb07 100644
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -621,6 +621,12 @@ static void noreturn init_done(void)
>>      void *va;
>>      unsigned long start, end;
>>  
>> +    xsm_transition_running();
>> +
>> +    /* Ensure idle domain was not left privileged */
>> +    if ( current->domain->is_privileged )
>> +        panic("idle domain did not properly transition from setup privilege\n");
>> +
>>      system_state = SYS_STATE_active;
>>  
>>      domain_unpause_by_systemcontroller(dom0);
>> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
>> index 19ab678181..22a619e260 100644
>> --- a/xen/common/sched/core.c
>> +++ b/xen/common/sched/core.c
>> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
>>          sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
>>      }
>>  
>> -    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
>> +    /*
>> +     * idle dom is created privileged to ensure unrestricted access during
>> +     * setup and will be demoted by xsm_transition_running when setup is
>> +     * complete
>> +     */
>> +    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
>>      BUG_ON(IS_ERR(idle_domain));
>>      BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
>>      idle_domain->vcpu = idle_vcpu;
>> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
>> index 58afc1d589..b33f0ec672 100644
>> --- a/xen/include/xsm/dummy.h
>> +++ b/xen/include/xsm/dummy.h
>> @@ -101,6 +101,18 @@ static always_inline int xsm_default_action(
>>      }
>>  }
>>  
>> +static XSM_INLINE void cf_check xsm_transition_running(void)
>> +{
>> +    struct domain *d = current->domain;
>> +
>> +    if ( d->domain_id != DOMID_IDLE )
>> +        panic("xsm_transition_running should only be called by idle domain\n");
> 
> Could you also add a check that d->is_privileged == true?

Are you thinking along the lines of,

    if ( (!d->is_privileged) || (d->domain_id != DOMID_IDLE)
        panic("some message\n");

or is your concern more of,

    if ( !d->is_privileged )
        return;

In my mind the former is legitimate because execution should only arrive
here with current->domain being the idle domain and is_privileged set to
true. The latter check I feel is extraneous because 1) this hook should
only ever be called under the idle domain, thus it should be checked
first and should absolutely panic if another domain context is in place.
Which leads to, 2) checking if it is not false before setting to false
is only protecting against resetting to false for which there could be
no side effects this guard would be protecting against.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:21:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:21:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310249.526964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXgb-0001vp-Ge; Thu, 21 Apr 2022 14:21:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310249.526964; Thu, 21 Apr 2022 14:21:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXgb-0001vi-DR; Thu, 21 Apr 2022 14:21:33 +0000
Received: by outflank-mailman (input) for mailman id 310249;
 Thu, 21 Apr 2022 14:21:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhXgZ-0001vY-VG; Thu, 21 Apr 2022 14:21:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhXgZ-0002r3-Qd; Thu, 21 Apr 2022 14:21:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhXgZ-0008N8-EX; Thu, 21 Apr 2022 14:21:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhXgZ-0000Gr-E0; Thu, 21 Apr 2022 14:21:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=91lZgbWltIrjTMGskbpHeQ8QFUS3AKiy9V7avclaQy4=; b=6RpGZ3iLvKIELI85Gp29ZrMCDG
	hdFs69m77Zz/xOGD+K3sF1d4HDLTXIbuY9QlLmvjXLr0m4oJBPX+VYw0jErmj9JsiAWaPxCSXBmG3
	1+X6H+Gr8ilBf2MFUnQmIl3BoU4gaooop5TuqVNushKulWI9AjTEyCTP7SKbhUHoXjUQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169593-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169593: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 14:21:31 +0000

flight 169593 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169593/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  538 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:25:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:25:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310259.526975 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXk5-0002s3-2f; Thu, 21 Apr 2022 14:25:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310259.526975; Thu, 21 Apr 2022 14:25:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXk4-0002rw-W2; Thu, 21 Apr 2022 14:25:08 +0000
Received: by outflank-mailman (input) for mailman id 310259;
 Thu, 21 Apr 2022 14:25:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhXk4-0002rp-Ge
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:25:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d7b9d775-c17e-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 16:25:07 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-rPQigAdZORemerd36MD06w-1; Thu, 21 Apr 2022 16:25:04 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:7::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 14:25:02 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 14:25:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7b9d775-c17e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650551107;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=zM1LKk9xeaEG5O4uovlDgLDOoSnwZ50HaYkeKJA9LUQ=;
	b=RJot3wGv8+WMHDS6ro1jxz9FmXOiPGSpYVH3aGDHIrUHmoURO1qftKU9zQJSfwt4Ezw4ia
	jf7I+bp+eodZ5ePczpc9VYMrq6qkMuUM1JRCFFoDu/Tu3Q1tAqh0M7kf+H7Kw7uF3pb7l7
	IkTnAy+BYcriSEuuU3QeFgJ5VPm/51A=
X-MC-Unique: rPQigAdZORemerd36MD06w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O2JSC+GbYNWW4HihKKHjAlakacOH2H9WMdh77+UqnVgkAnAkaUgIU8x9jIdtNWHgD9neYauSRf+/jaQ05EjIGG5zQyHsLRQiE07JynXt9xPjRjbnqt83VoO6R33H4Qpo/3AsB+6KcZW6100piBjdgjyJxhy8iik+P204fuPbp7NMoPJdcO7wf998MWFkRV/5/Dqq0Rqe+tborGWJmnXzcM/pXlsnfbG1rtdjyhC2cGUFq3Z+qRdHYSIeV5TjKGz6ZymVTd+j8aVxjyqwU7ptCD/AMw8wZ+rLW/GxZyXsE4pjEHz9EEvtqb3ol7X/6gz97cE3bFukbuDaXT9Y20fGSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zM1LKk9xeaEG5O4uovlDgLDOoSnwZ50HaYkeKJA9LUQ=;
 b=lv5dh8hkNjTtq9aWDZjA0neBqFSSeuQrWavOd7MqivT6528UCfcxFpHM8DcWpWG4LjoEBssKqC08g03uH7iASCsw7UDPyQp6SMx9QdiawT3fOdq2pjxcSMPz7UTwINdXMu72j7CFh0qNeumfJFTdlXVbtqBDW1YqL6yRDGfwUDm2O2MqhT12XyCI/r8ob3iZONVpZfaHvJdxmptX0rTKXASSbAYINn2o35v/q4peLwGbKdXjnMTj+nQ4m+2nmzetnnoU1gEBFPaAhDSAZbC+F27kAYAwfBdO+WcCA+UbnYs7q85oxSXNE+1rbbGEfiLU9pPckAOCMF54OXFRNLaBqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
Date: Thu, 21 Apr 2022 16:25:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 0/2] IOMMU/PCI: assorted follow-on to XSA-400
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0547.eurprd06.prod.outlook.com
 (2603:10a6:20b:485::21) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d8392b5e-a43a-43ed-7433-08da23a2b8cf
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3392:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3392FCE9B5DA8B4B015FD71FB3F49@VI1PR0402MB3392.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cZcxVvaB9u7TMuIH+SXlTS+gnXyyLmKM5eml9lT2EtXeKnbwWwEb6i7vfAeUiYUKwnEENn1e00YTfDVeiHgSSihJYk+lIl2T5CTHv9APy5tX2WgDyCuUu+zwFVWa1V4iDwTBHqqZOKA9vU50OmmmLV6+znWTmeBqG3BYoqJQQCsOIq0Cogiug9estcO3ftVttan2kDME9iaTNdEVPAEmljMnH1xdcwYNDSrW4fb6s+51Ryx9x2GM+whCWyJzcV2re4IwX7I57h5DypHDD43MjWia0e5ztezrWQ5NSWVLc7F/hXd+vxP2647zveUI45QBO9uWCae1TbqhcU5W5wLb7+jRgBtLpXH2yoSEnHRy9uF1KeCRphfyNd2BmZIKEptBXqiOTVhlSoqeba9tuaolgmTMs2KG7sqSadZuxebq4ZeY6SPKv6cy1buELvcJ3FEwAVVDfZKMzIIszCx3hTHhnyFJQFhQRw3l2YW5oOtersM3GPehI+SJlOZbDSurY7U3mucTtJ0VGS8mJi09gAPRHDFfenkNepHcXbCwbAscJP58ULe+ni7TrTnV0StPoGnQNuHva0ufgznaOSX1rhEekPiMvaoColwklpbESkOaDNKmKg2IZFVx76Sr8YkMLRV8wkENmKeXvMJY7mgW+tHMB4WFwNZBGqRGpLbR4QZd0+U3filtgrGS5VowCmLF8NKd3izd4BbFGr5qFvIfoeMxrDxqH3ytLSQot1q1koxvN3W+p4JvAq3mawL6rGVwAvx5
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(38100700002)(86362001)(6512007)(6506007)(6486002)(26005)(8936002)(558084003)(31696002)(2616005)(2906002)(186003)(5660300002)(6916009)(66946007)(66476007)(66556008)(8676002)(36756003)(4326008)(31686004)(54906003)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SXRvRFJUblRzNTdoNG9XazJBdVBMUkwrbVh5WTI1U1JDRmFhM29RUUNBVFJ6?=
 =?utf-8?B?Y0J6WVR2N3h1OHZ6SElBUlJZTE5IUVRBVDl5VlZzaDB5K3dZQzBiV2dPQ2wy?=
 =?utf-8?B?OFpGa2ozTHdhVG8vNVNlMU9LU2NtNEloT01qTkRmM1ZRMWcwYmlhOTVqMnF2?=
 =?utf-8?B?NGl4V0FsVU91bFdTdXZNZ2poY0FNUVpyWUxHWFJhVXo2Vm90T1JUV2dVaVJq?=
 =?utf-8?B?Qnc1QWNSMHhBdmdpRTdrejJZSUxIZVByY1lnRmhCRlhKbWNBWkowV2paeldn?=
 =?utf-8?B?ditiQ09Nb2szUUpGb2E4SS9PU0RMRjhldGJZWGhrMDFNcWV2alErSUp6TzNX?=
 =?utf-8?B?WStvWmMrNkxQWER6ek1pT2dKMmpucGV5NWJwemM0akx2TW91UXJZY1VraHg4?=
 =?utf-8?B?M3VVZm1pT0NXa2ZZd0Y3Yzl2UkZ2U2gzaXFSbWxib213dkFsbjRwYnYzMDN0?=
 =?utf-8?B?bXRYQVVIRFQyMkhOZnVUUVVhaWlVN1JKNjdNZ1NHbHpZVEw4RDhmZ3pYcjc2?=
 =?utf-8?B?aXdaSGZKZTNwWFpJWmNXRDlYUVRSL1VvMDBHTXJlZkNBUHNtYStjNUtUUzlS?=
 =?utf-8?B?OXZ4S2wrUUhGeWNxWnp1ZVVVVWpNNGFOdDFySFNJUnA5UGQ1c1VBVW04WnU4?=
 =?utf-8?B?M2JrRFdiQ1B2akJVT1Q5RGV5aWk4VHIyVUk2OGpvSFFLdVlNbnNEYWRqTlZK?=
 =?utf-8?B?eWVqNEJMOFVvOTYzV0xOWndEMjRWamRQMGdkam03SitBM2FyTElPVWFveGpn?=
 =?utf-8?B?YnF1a3dFTDd4SG45eU9JMFhLUTI4VXZmV0dUSnFrQW5Gd2VwYmVJdzdKOHZW?=
 =?utf-8?B?ekYvV1YybjREVkh0bmJlS3RzTVhQVDFEUzlWdkpIYVY2RXQ5ZXE2ZXJhVUVi?=
 =?utf-8?B?ODJUcDFJUkxpTVRJNzY4ajlDdVVzSDg2L1ZJZVRLZEhqeVl6b0gyMmNyTUVW?=
 =?utf-8?B?LzFVT0FpcXloL2diUHpWVWJiUUtYNjUwd0QwSzV5TFcwN1EvZVJjTHNjb1gv?=
 =?utf-8?B?cjI2ZWZVMEVXdmZOb3VkcnpHblJESDAwOEgyTnppMkp5OEUycEduZTY3dW4v?=
 =?utf-8?B?aWl2bnpLYThVWUpjRzFrZ0dsSjh3RjYwVkhVeTlEZ2s3c1dRZjlrcUJNRTJq?=
 =?utf-8?B?R09SUzNjTytnVXA3QVBsdEk0RDJpTk4vaDE4Wm9WU0JQSnJrQ0VOa3B1NmtS?=
 =?utf-8?B?MHVLT1I2MmFiKzJBUkZTb2d0Z3YvRXhCMkkxeUJLVHRvT0JGY0YxajZCT0NT?=
 =?utf-8?B?VEcyWi92Vk5LZFFGL2dqbVV4TmZsM1h5NDY1S1BMK3UwbkY1dXoyVXVZZEZr?=
 =?utf-8?B?TWN6WXBSK2sxa2VVc3Y2emRYbnBNbTFpQWk2dGVBTGZhVGk0YUhGM05VbzFo?=
 =?utf-8?B?dUUvd3EvQk9iZmptTjdYeHVyL21WcW9jNms4ZjEvVFBzWXNRZFNCVHIxVmE3?=
 =?utf-8?B?b056ZU9CTWZ5TDY4YzBhTER3QnpZWThrUFJPdXlXM21jYWlpRGFnNjcrS2Zz?=
 =?utf-8?B?S245dHFCL0h3NmY4WFZYNU5xUmFvOXBoZXE3VU15ZHNXdkJreVc1OTh6bHRo?=
 =?utf-8?B?R2Y1cFNxVTliRzQxekJwRXlsVU0xbXJMams4eTQreTVPZnY0SG9qTnZiM3RI?=
 =?utf-8?B?dzhscGl0WEJqTnp5UDBaenUzeXNVQnoyL1lNUFZkdWZPcTM5NGZLZDlKcjl2?=
 =?utf-8?B?VzZnWHdDZFBKcTc0dmlsdmUxRTVOVXhzY2xWbmd2VzFod3djcTFBVmdpNGgx?=
 =?utf-8?B?NnJGYThGTkZEeHFjY0FxOU00RmxoNjlWUzFZUElkazNyMHJUQUcwbVhPVGcy?=
 =?utf-8?B?QmJVanBQOVFlM1h3NC9DM1NIVFVzZUtna29BOENEMmY5YVk4M05ZajEveGt3?=
 =?utf-8?B?QitvTUtnM1YvbkRIdUV1cmZ3Ly9SK0pNVUhjVnFreld6enFxdmIwUEpIRUN5?=
 =?utf-8?B?elVIbnMrQjVNd0VPK3hVMzRLVlJhRytNTmFLZlNxaDFCSWdxd1IyNVlIeVBp?=
 =?utf-8?B?WG5NNHdpL0Q1NS9yd1lPQWgzN1IyR3RPOU1QU3ZZMXV0YVI1Nk1kVWR6WWJq?=
 =?utf-8?B?NHpnZmhRT1Q1NW5CbkgwdHZFVXpsQjloczd6bU0vWkZaa25xdVZHcVhwRmUv?=
 =?utf-8?B?ZHhhbm5HQWdPK01YV25xbko3RDZ4TVNkVEF6cisvNEQybHF0MUtUZ0FRWVF1?=
 =?utf-8?B?eE5hSExBbEJXVXlpVFBNNDcwbXNyVGxkRGV0eWZZNjJqUUlYZFFqVmdGTm5J?=
 =?utf-8?B?VjhvZXpiY0p0a0VXZjdWRE94emxzLzVMN0EzQ2NkaUo2NUxJN0VCN01UUnlN?=
 =?utf-8?B?emM0a1BkYlQ4N0Jxb0JsT3phc0Npc0IwaGhqWjJvOEc5bWovMVFlQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8392b5e-a43a-43ed-7433-08da23a2b8cf
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 14:25:02.0030
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T6Mga0lIkYCVIxiwDUvlgOKrNeKt08Ozkj+SV96hEB2GL0gJD806TO8TXTSl3WJOSkpheAktD7DirYfj6yY08Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3392

Just the two remaining patches, with the only change being a would-be-
build fix to Arm code which cannot be compiled in the first place.

1: PCI: replace stray uses of PCI_{DEVFN,BDF}2()
2: PCI: replace "secondary" flavors of PCI_{DEVFN,BDF,SBDF}()

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:26:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:26:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310265.526986 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXll-0003XU-HJ; Thu, 21 Apr 2022 14:26:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310265.526986; Thu, 21 Apr 2022 14:26:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXll-0003XN-EI; Thu, 21 Apr 2022 14:26:53 +0000
Received: by outflank-mailman (input) for mailman id 310265;
 Thu, 21 Apr 2022 14:26:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhXlj-0003XF-O3
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:26:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 15522564-c17f-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 16:26:50 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-l88B6IBfM-qEUgF6Xwld2g-1; Thu, 21 Apr 2022 16:26:45 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB9011.eurprd04.prod.outlook.com (2603:10a6:20b:42f::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 14:26:42 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 14:26:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15522564-c17f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650551210;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zKt+9U9TMdD6IMPEO87THHRe/EIUI24N1ey7tQCQd1Q=;
	b=NkEXzc9UhrYvr7rLls8srzwPIKzGq1yQQhPlYf5gTzydJfaKGftZFffQ/DlKPsVg8ZeqPP
	tNA9VG+hqBe1/W6/+y6TngChFETbgjygJXdlYitZHGjC4GEr5b9lxkelgNTREUnLIhiq+M
	k4I8aErP7TssSuXmqpRp7HSf1eQvLuw=
X-MC-Unique: l88B6IBfM-qEUgF6Xwld2g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bfgrtMu7vucfNoE5R0D+yUMGEzlYgou8CHF0REgvGV/T9BtFfTTjkFrVzokjbuC0ay+Xz641p9VgR6OZoxAHjn8U4zzW+PQgT9Vmg1ejIcucTwBI3rvRyh5v2LbZlvUmBPqAjnk0Jh7z3lNG0VJjQyy49UN3Uhcg2HhdxdUdnBoDY4LA7MhPZqWtSASKylFQKn5pE6xRc9j0KPd2WLQVPHaT54AcvFqg14UTFpoKozbC1fijhhtSDfBQ6dcMRGGepfSeGE7yj8jGRe5XOODW6QatagkRr/5oW17wt2nLVjULvIoS5q0YGnj2Oq63fU46W48pTzKiKCXACAY6j47kTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AN86zNdiwUuZ0FofNlHH9FuXW8RS4szdVKQ84rU2at8=;
 b=AAuTai2GNYtAqo/FT/xAHL20mooKpcXv1Di2Q8zS1Mpp8ftIfyxo2+L+Fj+rPwdRcWpc+0o+IqtlwI9PqweBl2bJSy0/k1VkbH/DP8ebLGFlKku/zBd3QFeMswxF6GXzcdm7XQpPGxAipfRQB+F7jTuSM7fQfrLeU/x2n2rsffy/XKNLL2qpB8cgz7kUvcJFIxDnlEvjpDsaLnF110KeqDOGwbiR5yFk1tBxFwY2wF1cXrNPW7JC84oNyLMC8dB0lKALDR8yeBfVb3aS+36kBOknVp9qi+/M4lhthquMTWxFY9NvzajrvA1JfIeOt4AKU6VRwGhppFk07xy31NYj+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6dd6719f-a05d-3f90-95b5-0ce9b5b0a2da@suse.com>
Date: Thu, 21 Apr 2022 16:26:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH v2 1/2] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
In-Reply-To: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0121.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9d2da52e-452c-4915-fc76-08da23a2f4e8
X-MS-TrafficTypeDiagnostic: AS8PR04MB9011:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB901130FFF88202EEFB7E5805B3F49@AS8PR04MB9011.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2NviS+iZfSATkD9lou9rZerurOteLilkR2K9qlnNUpBHIsK/4XMndz1HpFpCAgTM//MCLy3sAGoLCJYATBdQjCsyLo3nJXmlGkF0+ltb8CdQRPzh+K6Bot7XJIl0FGDZPD5iM617nNOFy+xVyeVaPIkejPmQ3Emqb9JPoMcZHlAVHtHXJIV+VMUZ6tHV3wRlJywVt01mNeehhWuiqajcsqpdSR8Up6FX0HKV9AmkV/LrXo+o2tSKERE/3yLPHINwZxO8nU3NYnMaLpzbC+Lt/3YOxxkWwSkhmSaU3i26++7owsIR8GvO/e9sJZxbxUUKY27tgYVsWp3/n/4Ah8BrguUTKyxuZRozhRZmd9UHj7Q9Roekiuhi3KAjfGC1oX7ALKCXKIEMKdgm0xFqwBfDdDE4lXWCTkQ1ZzbmBqY541rtgQ729io9yYDyUrQMYpSbHG589figG2hpRyJJ9FvNTLCByIddXIsIEvmEt/kR91+rHzma+rmdgaVZsPUNZPHDNbyipIBJdOy8I6rSnzIusFiMoiNdHWFMANxUCqmnmtaRJuyJ8JUAffuLuucsEUoHp/fIghmH4dC6a6lG2Z/ByhOyLwr8CStPEzQPIqioQci9x7Kch4B8BiGA9IgA05ulchmNyZGmQmBR44Egz63gw6ZPYlj4NSWjn8kaxkg9BA/JXt8yfGGti2Fdk+5P4e3RIoLYSaI2MQMoah7rJRwvLW0ryE+QaJNqWNuWWxLDAXI+t+M8eFLFubLNpb7jf+LY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(2906002)(6486002)(66556008)(66476007)(66946007)(31696002)(26005)(2616005)(6512007)(8936002)(86362001)(4326008)(8676002)(186003)(7416002)(5660300002)(6506007)(38100700002)(6916009)(54906003)(36756003)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ClTiCtRuo+jqCQBQTe9BnbSaY4Jg061xW6/KQiEwYZHYjvyCZ2lkZoETBYhK?=
 =?us-ascii?Q?sAxsigyg6m0W+fPoVsRXfYadwhM+bkc8IuT61csQ0QKPWJwslXWxEJecStgG?=
 =?us-ascii?Q?jXQGcjzN88ASGpCzpOImesQtMpekOZD2lxd5wvAtEiCxPGQhJoZFnfjF2yXX?=
 =?us-ascii?Q?38QkOnP0HpIk3P5mgsONHDMsGljRDWLAKEZXk6sHHfqZyg8M7v4w69Y2JaDW?=
 =?us-ascii?Q?EBKhdXjvEOkEv0swKAW6h59TJx6SGeTkQWjYTiTi5nMYXw4/SsKByaJrYVDO?=
 =?us-ascii?Q?ISP1MYKrc43R40qhYAXbAC8A4r+CVRdqin7rdVq2XrxcCBnjXPgJWVGMa+ly?=
 =?us-ascii?Q?pl+oajNyILelB6tQz3NTjTqHYAzG7QR8053koZ2FwrFFAHO9EknFpGBdEsw8?=
 =?us-ascii?Q?X9Yt3f7BcqLUy0FFVvDhryKlX1m724J+EKSzvlHWlnicoVWkPiBoBvvqQqsH?=
 =?us-ascii?Q?WQqwKo4+TI+YPJQ5D3yZl70rjUR51Kb+XUJyvRMlOYp3xVBzVgzhP5k3QsJW?=
 =?us-ascii?Q?qxUBlgP4H9uiDe5P2yOM4nUsy77ux1fxLTZpzXWVyHCVLouxhrTG8k5WBQ7a?=
 =?us-ascii?Q?mqM11UBTAYEtjpL1MEKhYDCCqEolUbN/qH/Fhp4ueIk5icmq90NjpkQ4Gaom?=
 =?us-ascii?Q?ZaYIaJZH3rgWvwJ2Fx7n83TlQSPzM5zRjii7QyC3mPDatZhoIGY/l87S4Dfd?=
 =?us-ascii?Q?XYk54y/co3nsFJMvPlvfyr4YQkSKHRelbEpKq1ksy/3X66PizNgpxHoMctia?=
 =?us-ascii?Q?74yMc326Q6t3tLJHPh5+q2H4wFgbpk8Xph8fKJq+1LOwnTkrX0+0rxGBsYsW?=
 =?us-ascii?Q?fd4BgB3+wiJa/pJ2wUEKvRxR2wVL/arnLjfdX7vMEBrzcZ3GUltMSfU6AnZk?=
 =?us-ascii?Q?lFGwtKG0Yk521ghYKsAbdvHXAdtk+JcLUBgLeLPhqwXj4yOgUv/zrZUp4GPL?=
 =?us-ascii?Q?IKIbtBPgpXVeNiV4Xd6V16PUrMc+CYtytkB1p0xJPDld4xaVRLHe1hF/dpEc?=
 =?us-ascii?Q?gGUT4PQV7uf+X+E3aOqjyPGF3aCm699yQAqdoSj0m5n63pOAzy1lh8gslCM1?=
 =?us-ascii?Q?noxj/2ogse61Se0+Dlc+9MfJlNs6Qidm/60k7iGXDqKNkTbaaAZ3InbhlfNK?=
 =?us-ascii?Q?VH85YGSsepl54OL6aCd+SovbVDMPkeloCa8MlBc4DX9mB5Ru9y37MJzCjZkN?=
 =?us-ascii?Q?LDfnRCbXbsamTP71ZEREHJnuGLOTfmNPNUZNCsO/sSohI/uuJfoTcWG5y87z?=
 =?us-ascii?Q?uKefKbt3XkprGP5+65pen3rg3Fd4g+i4vmNW/cbcjWo7+oNbKgSJqGTHB/kC?=
 =?us-ascii?Q?iX7/8YV1ahrGWvShbi6qKP1e/LIB0b8qCvuK9YT32BL5JKruwlcuehI6HfMw?=
 =?us-ascii?Q?uoJ5K86YYwP59LfI0k+SlzrVth9UpOa49BO7+5PJzu9Y4Ualky+570D9wqU5?=
 =?us-ascii?Q?0m/5jqJHNGu3H8zXxjl++M0p0owAqNKxr5uA3NGSg1pBh4Pa95lBwbXx5Gzl?=
 =?us-ascii?Q?PG2Qnj3SJ7gOe/Fn4snxtBSWalIpF86Zbo22ny9/dFLe5CdWuKnV/mqlbwn0?=
 =?us-ascii?Q?lh8AzHprEVLO1AtQIRF7CGmPtw8FKqlxDJTJr4BrpGA60Yf+/vtgEOw64Qgx?=
 =?us-ascii?Q?ckbQR9ilgVJ7t5HrBbk39BpahwzxhMJ/Mvoxlm/VmSNxgbF5Ico5OncxKQpD?=
 =?us-ascii?Q?zT34mvT2hZ0HykoqgdIr/IiH4ItB582FXG1QTbcOGzGlK4jo4XvIJfEix30o?=
 =?us-ascii?Q?7gt/0BAXUA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d2da52e-452c-4915-fc76-08da23a2f4e8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 14:26:42.7867
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xoO8Wlk8zli+pifa0+Q/rOJqSv5GICaPaed3S1mZDNSsmSYkkjVIJkMinGNDpEsVxHJgqi6T7dq44ZlBzYVa2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9011

There's no good reason to use these when we already have a pci_sbdf_t
type object available. This extends to the use of PCI_BUS() in
pci_ecam_map_bus() as well.

No change to generated code (with gcc11 at least, and I have to admit
that I didn't expect compilers to necessarily be able to spot the
optimization potential on the original code).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
---
Note that the Arm changes are "blind": I haven't been able to spot a way
to at least compile test the changes there; the code looks to be
entirely dead.
---
v2: Arm build fix (for those who actually have ways to build the Arm
    code being changed here).

--- a/xen/arch/arm/pci/ecam.c
+++ b/xen/arch/arm/pci/ecam.c
@@ -28,8 +28,7 @@ void __iomem *pci_ecam_map_bus(struct pc
         container_of(bridge->ops, const struct pci_ecam_ops, pci_ops);
     unsigned int devfn_shift =3D ops->bus_shift - 8;
     void __iomem *base;
-
-    unsigned int busn =3D PCI_BUS(sbdf.bdf);
+    unsigned int busn =3D sbdf.bus;
=20
     if ( busn < cfg->busn_start || busn > cfg->busn_end )
         return NULL;
@@ -37,7 +36,7 @@ void __iomem *pci_ecam_map_bus(struct pc
     busn -=3D cfg->busn_start;
     base =3D cfg->win + (busn << ops->bus_shift);
=20
-    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
+    return base + (sbdf.devfn << devfn_shift) + where;
 }
=20
 bool __init pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -839,7 +839,7 @@ static int msix_capability_init(struct p
             pbus =3D dev->info.physfn.bus;
             pslot =3D PCI_SLOT(dev->info.physfn.devfn);
             pfunc =3D PCI_FUNC(dev->info.physfn.devfn);
-            vf =3D PCI_BDF2(dev->bus, dev->devfn);
+            vf =3D dev->sbdf.bdf;
         }
=20
         table_paddr =3D read_pci_mem_bar(seg, pbus, pslot, pfunc, bir, vf)=
;
--- a/xen/drivers/passthrough/vtd/qinval.c
+++ b/xen/drivers/passthrough/vtd/qinval.c
@@ -267,7 +267,7 @@ int qinval_device_iotlb_sync(struct vtd_
     qinval_entry->q.dev_iotlb_inv_dsc.lo.res_1 =3D 0;
     qinval_entry->q.dev_iotlb_inv_dsc.lo.max_invs_pend =3D pdev->ats.queue=
_depth;
     qinval_entry->q.dev_iotlb_inv_dsc.lo.res_2 =3D 0;
-    qinval_entry->q.dev_iotlb_inv_dsc.lo.sid =3D PCI_BDF2(pdev->bus, pdev-=
>devfn);
+    qinval_entry->q.dev_iotlb_inv_dsc.lo.sid =3D pdev->sbdf.bdf;
     qinval_entry->q.dev_iotlb_inv_dsc.lo.res_3 =3D 0;
=20
     qinval_entry->q.dev_iotlb_inv_dsc.hi.size =3D size;



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:27:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:27:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310269.526997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXma-00045d-SL; Thu, 21 Apr 2022 14:27:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310269.526997; Thu, 21 Apr 2022 14:27:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXma-00045W-PG; Thu, 21 Apr 2022 14:27:44 +0000
Received: by outflank-mailman (input) for mailman id 310269;
 Thu, 21 Apr 2022 14:27:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhXmZ-00045H-2D
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:27:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 33388cb4-c17f-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 16:27:40 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-nJMVboWaMnGkN5yYamz2JQ-1; Thu, 21 Apr 2022 16:27:39 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4212.eurprd04.prod.outlook.com (2603:10a6:208:61::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr
 2022 14:27:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 14:27:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33388cb4-c17f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650551260;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lWdwfKUrs9ihaFZt4+efMhrvLkEmtIW52vKm8ENeA7A=;
	b=Lg09KJe6fh5mryPnA/Tatobq2t1pHzNkN1VWMjJMQcSMObkbAfaYf6fVxI8+RusYKEtlo1
	8QY6VqVJ9TPslcfwH4Ccnfto/A6vCPdJ3HW4sz2c8bRVuB4VAjYCF40x3jtjMYl7Kf8Uz9
	FqZTxxHK4xrTyNycVzlXURpqUWx83wY=
X-MC-Unique: nJMVboWaMnGkN5yYamz2JQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IG+KugfvkBmUE4PC1uhw4q2OLY6gK83Tvdxuw6AmTRtnW4Oq8Vhm4ZP7gT9BufKTAXYPPTBwcyoA9Iyy36ujv2XXtPTtemTngOzEdUI6H77dW0ZfAEdRpfAA1oaZKhqJGTvKQ6oU0F9O529972kkcGORcQKIfrzgUyiChTQBbi9bGLoKZf+BuFq+Aau03kDyPU/a9v5uMseEw2/3s/uq5CNW/ibHYXUqWNDOZzo9sN3HFlZFwBNmOd7ZJ6hZ+1N+Id9iDr527HFs3qSEwm0CHyqTmHPBGWBeWEAho5FY0rXlyah0Mgh7fSUEMvq5OqE8mUnP2bEjSUHqbed0tJ0alA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/s+/HBY9mvZq6p2p3A8ING0ScEKZEB0bVsd3PcRhr6o=;
 b=Q1CD3YKrCiXT/Tup0akj3/d6XdNHRmHQZJg3k3WMm6paoEIjSyhkLGab4XgCDVlrf6XX0WUQHhD5iL6Paj5lGGe8WUpbNahksGWi0ZAFW/tNFsAkoh3s3ZILbXmMK8HUhEwoPe2kJhP4qCxQmnxjIO0RpjnBZGVdLF9R1Nwf9tNy2YkK2tVAP34WZ3F1S6LQO3k2bqiYmy437Finky6+JGjTQn8c3dyHzOTfGbhl6CHa7o0/xCqoAK2JSk4LYmvCiyZUAZ69ZYND7WI2zWZZyeVsuOAMcMYYdj0kpRIxA60GOPbmtsQuPfMcDz85yivO/1JkvGrcwtAlpK7QWIcGqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <609d222f-16db-52c1-1875-0843515a54d7@suse.com>
Date: Thu, 21 Apr 2022 16:27:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: [PATCH v2 2/2] PCI: replace "secondary" flavors of
 PCI_{DEVFN,BDF,SBDF}()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
In-Reply-To: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0142.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::27) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0be1c450-5d12-4c69-6234-08da23a314f2
X-MS-TrafficTypeDiagnostic: AM0PR04MB4212:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4212B713F91E947E5FB7B089B3F49@AM0PR04MB4212.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KCDpx35zdcdGnp6ZkpZNFmd9j/u6dYw1kcBERfuof+lIP/Splha3Zff5Q3cVOK+Q/KMZMfJiSBXyokgl9IdfeaZ93n3o4fp1ZugIcwRp6r40d1kevbQTlkIPAFqUV8dIAdfwUB4wfrLS5QNlJqN7qUsBp/Gn7ZElAkMbafRvGNnrHY82ZSzBWVGkY0Qn/EnOGjRachxRdtmwEuvlZA6NnVtFD3JDQvnMK+d8ibH2/wdHyqvkd/2D9+2W6aJs3wnqIvNt10vkX9SM/459zlqBN21seybmCHZBmAuk0ke6+dcfbHZR1pCYZVZZJ5cGGdpDWNv2jJTRBp0WsXx7con2hEjrb9l81nIm5dEdsv2C2dQJbPKjJkWTHR23z6lWNmj4S2AH9zWeNsGtqjiyy1ghxwcfHJ9iYf7JowIbBG41wuLEoOzHj+BnthxewsXXdwKTb31ZHv4RTmpehFaPoD3UbJ3qklpuI5KaoxU7dSVVqQKeUxxZoQeIfUqj6dLpt9IZVxq1SUhmxL1W1gQPDQlJV2/dwK1dfD5ZE1mp5j5HJCNTaIGZanMRasFoSqvs+VwLdnFJSKR34FnlCvbJUFmlka3fpNOKUZiHLv5AfIWFUp6ZY4vN+cDiMpTsQ9RMjRH0+kKf/4cL6DFPZpbbkjpn0W+zeqsZFwvTNgdSP6CJURu90kOI4ndgAQhn5zlHJPlyeyw6ba5tpvLP6pwkrC7R+CpUi30YM6S2Rhvfb6Gb4bu3GJLE5AVphPw6mjuJjkQjuBE3dMyqiilgQde0nvBocw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(508600001)(6506007)(66946007)(6512007)(30864003)(8676002)(86362001)(8936002)(66556008)(38100700002)(66476007)(54906003)(6916009)(36756003)(4326008)(31686004)(83380400001)(5660300002)(2906002)(2616005)(186003)(316002)(26005)(31696002)(43740500002)(45980500001)(579004)(309714004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?I0La3gjmj9vu3sCaOLfJM84dvgncUOA5SBNeM1EIB9BXbH/hlYH0yYlqtm0v?=
 =?us-ascii?Q?VAJLgKLgnwd8k6KRXsK45vnRgkclZY2GY2ia8PYYVSw+oyhvpLzwVEXmy1Ci?=
 =?us-ascii?Q?I2oA/kAnEqFbVwhiq54QOA7phrVdmj+EG6tbQO/EOX9nGqDpmYYpFkOwMnOI?=
 =?us-ascii?Q?3gzxx45QrVFzGr3Kkomx/DXEjLRF5YgHPLzhhAGikKd4WEaL9Nd7AOpLruqW?=
 =?us-ascii?Q?W0u1uVmJK7sn2fVo3i+shJ8whMRooDrZbKq83g+ZF7x53z2a9yHN7reo5On9?=
 =?us-ascii?Q?GZq1xYorQG1G0orq4TEszOYKmXfmnZsmA9IIuikSuZwtq/2H2+04YJx5BrSU?=
 =?us-ascii?Q?aohy/L8WNP0dsK5KEgEH07mFRkF6oe/P/cs34q2B5U0T20KHmfo+eebYAh+6?=
 =?us-ascii?Q?QBcydnJ5GG5+kd4UWvB9ei15UTnjf5yZhCBUb7fSXC5ChUUgH1+DNrrI9fyW?=
 =?us-ascii?Q?ygnuqZuRNA1MGdPNXcxB2PUIjYMxfR1Ih0IQ8c5qS7Qa6ifKbahtDTBPJCcC?=
 =?us-ascii?Q?Va92baEIhsV8cdpeOmwJ3e52j5+KFYLrjMnlCh4w/qVnCvIKzoU/WzGVFL58?=
 =?us-ascii?Q?PXZq8ptIXBgp26VrZl7oSusjyGFISXDB4Ht70WVm5mPBSFjq1kORIlWnnKfK?=
 =?us-ascii?Q?VEVObuQZcvpLgiFGqEYwT/HHtdexoz8ulduo+PkFARWJoWRlh3MqaHdFwpt6?=
 =?us-ascii?Q?ls13zxgBzD8BpD4iLQWa4C7g1zubjinkMAmszcInPrc8cQ0DvL4xZ7rmcb6W?=
 =?us-ascii?Q?9hvCg4/VTh6xWemcN+fKGzqk/Ed2laLlBcPzxReHL+x8R7QC2M8I+I/zHUsW?=
 =?us-ascii?Q?ht59/f/imKmwl2STKkWLAnmfiRKO+vAk/M1xsUAYJgf5eEAZkditl8gtjLAD?=
 =?us-ascii?Q?RaZqCNUT/cLaUmCDQrkKiOgcNcNXlEWUXbCOh2w8UjL62I4FVWE5Tvh6w3Ux?=
 =?us-ascii?Q?yK9LkOzTwax69JRlzngnWUJXGYW7IH+M1CjUTlklnqtYjuDH9GemAi6D2D44?=
 =?us-ascii?Q?0XU4X/aYlWIKg1XomQ71ZGQ6k9CXjMvTywZDPqTqT0PoiSaZXrztIJ/VhD3+?=
 =?us-ascii?Q?jXZkcizULzKXj+8ZW22gfoErL/gECErCx89YyRJOLZg6zfrM3j2fxcEheWXe?=
 =?us-ascii?Q?g3EKQAIWyxCxHTo2T66DnYWXPC8RbutgSUrq6rnn5K5mta/bmKA7l/AtASWQ?=
 =?us-ascii?Q?hUvDrhbjCNQIV7ZjKowk82ZXPRdmBXe7DIizdDuZVRwlqZUYQ0rqpkeMCtPO?=
 =?us-ascii?Q?VmIoMIymlzTbKHoYetuzIqbPtaWEJlyZd43emFu64So/rGKRYTLptPIxyiLP?=
 =?us-ascii?Q?Qg40JzRumEFGRFrO3mdY++PjgTWnTt8b0xw1pc7cM1TxRWWiYXvDFbG1DzPP?=
 =?us-ascii?Q?m6PgVqQvoxoGtkxWC1Eq6DZzcrv48JdLNDLIOpbeoNouJzCvQi53/QRhYXdx?=
 =?us-ascii?Q?RQx2t+NQwShcRu38i6/kFrwPICxkgHVMhqeHMR+RdVSYOuKtyZuYvfAs4Cct?=
 =?us-ascii?Q?Odpt4HETgopQqrO98mkpw1bUPYG2skllnIyRL3cGlBIU39Oh2MnkyLXjud4c?=
 =?us-ascii?Q?3Mk7s4LOVZzAGKoRoEbWA2uxxe2GAV3u60tPGleZzXlreeG6bAM4bUVPbz7j?=
 =?us-ascii?Q?ab+gvvFQUzwUaaO9k6c1gttXtjoLohbtDPTG3NtBPctLwH/FcAMVrWzryqlR?=
 =?us-ascii?Q?8d0pC8bTH6Hh+4ShodeabxRZuhaKH2IyDMRBcEKZBqP7szBLM0bKsm2Iu0Sg?=
 =?us-ascii?Q?dRof+hLZKw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0be1c450-5d12-4c69-6234-08da23a314f2
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 14:27:36.5666
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KJJIzHrZouT23MafIL1SF/37nqNkyUTrgAR1fVKulKsZv39CtyrWdmrTl4Ti79ho0NJk+ubGJWjuv4KQnPmcsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4212

At their use sites the numeric suffixes are at least odd to read, first
and foremost for PCI_DEVFN2() where the suffix doesn't even match the
number of arguments. Make use of count_args() such that a single flavor
each suffices (leaving aside helper macros, which aren't supposed to be
used from the outside).

In parse_ppr_log_entry() take the opportunity and drop two local
variables and convert an assignment to an initializer.

In VT-d code fold a number of bus+devfn comparison pairs into a single
BDF comparison.

No change to generated code for the vast majority of the adjustments.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>

--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4902,7 +4902,7 @@ int cf_check mmcfg_intercept_write(
     if ( pci_conf_write_intercept(mmio_ctxt->seg, mmio_ctxt->bdf,
                                   offset, bytes, p_data) >=3D 0 )
         pci_mmcfg_write(mmio_ctxt->seg, PCI_BUS(mmio_ctxt->bdf),
-                        PCI_DEVFN2(mmio_ctxt->bdf), offset, bytes,
+                        PCI_DEVFN(mmio_ctxt->bdf), offset, bytes,
                         *(uint32_t *)p_data);
=20
     return X86EMUL_OKAY;
--- a/xen/arch/x86/pci.c
+++ b/xen/arch/x86/pci.c
@@ -90,7 +90,7 @@ int pci_conf_write_intercept(unsigned in
=20
     pcidevs_lock();
=20
-    pdev =3D pci_get_pdev(seg, PCI_BUS(bdf), PCI_DEVFN2(bdf));
+    pdev =3D pci_get_pdev(seg, PCI_BUS(bdf), PCI_DEVFN(bdf));
     if ( pdev )
         rc =3D pci_msi_conf_write_intercept(pdev, reg, size, data);
=20
--- a/xen/arch/x86/x86_64/mmconfig-shared.c
+++ b/xen/arch/x86/x86_64/mmconfig-shared.c
@@ -313,7 +313,7 @@ static int __init pci_mmcfg_check_hostbr
     for (i =3D 0; !name && i < ARRAY_SIZE(pci_mmcfg_probes); i++) {
         bus =3D  pci_mmcfg_probes[i].bus;
         devfn =3D pci_mmcfg_probes[i].devfn;
-        l =3D pci_conf_read32(PCI_SBDF3(0, bus, devfn), 0);
+        l =3D pci_conf_read32(PCI_SBDF(0, bus, devfn), 0);
         vendor =3D l & 0xffff;
         device =3D (l >> 16) & 0xffff;
=20
--- a/xen/common/compat/memory.c
+++ b/xen/common/compat/memory.c
@@ -27,8 +27,8 @@ static int cf_check get_reserved_device_
     xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt)
 {
     struct get_reserved_device_memory *grdm =3D ctxt;
-    uint32_t sbdf =3D PCI_SBDF3(grdm->map.dev.pci.seg, grdm->map.dev.pci.b=
us,
-                              grdm->map.dev.pci.devfn).sbdf;
+    uint32_t sbdf =3D PCI_SBDF(grdm->map.dev.pci.seg, grdm->map.dev.pci.bu=
s,
+                             grdm->map.dev.pci.devfn).sbdf;
=20
     if ( !(grdm->map.flags & XENMEM_RDM_ALL) && (sbdf !=3D id) )
         return 0;
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1055,8 +1055,8 @@ static int cf_check get_reserved_device_
     xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt)
 {
     struct get_reserved_device_memory *grdm =3D ctxt;
-    uint32_t sbdf =3D PCI_SBDF3(grdm->map.dev.pci.seg, grdm->map.dev.pci.b=
us,
-                              grdm->map.dev.pci.devfn).sbdf;
+    uint32_t sbdf =3D PCI_SBDF(grdm->map.dev.pci.seg, grdm->map.dev.pci.bu=
s,
+                             grdm->map.dev.pci.devfn).sbdf;
=20
     if ( !(grdm->map.flags & XENMEM_RDM_ALL) && (sbdf !=3D id) )
         return 0;
--- a/xen/drivers/passthrough/amd/iommu_acpi.c
+++ b/xen/drivers/passthrough/amd/iommu_acpi.c
@@ -96,7 +96,7 @@ static void __init add_ivrs_mapping_entr
=20
             if ( !ivrs_mappings[alias_id].intremap_table )
                 panic("No memory for %pp's IRT\n",
-                      &PCI_SBDF2(iommu->seg, alias_id));
+                      &PCI_SBDF(iommu->seg, alias_id));
         }
     }
=20
@@ -790,7 +790,7 @@ static u16 __init parse_ivhd_device_spec
     }
=20
     AMD_IOMMU_DEBUG("IVHD Special: %pp variety %#x handle %#x\n",
-                    &PCI_SBDF2(seg, bdf), special->variety, special->handl=
e);
+                    &PCI_SBDF(seg, bdf), special->variety, special->handle=
);
     add_ivrs_mapping_entry(bdf, bdf, special->header.data_setting, 0, true=
,
                            iommu);
=20
@@ -816,7 +816,7 @@ static u16 __init parse_ivhd_device_spec
             AMD_IOMMU_DEBUG("IVHD: Command line override present for IO-AP=
IC %#x"
                             "(IVRS: %#x devID %pp)\n",
                             ioapic_sbdf[idx].id, special->handle,
-                            &PCI_SBDF2(seg, bdf));
+                            &PCI_SBDF(seg, bdf));
             break;
         }
=20
@@ -888,7 +888,7 @@ static u16 __init parse_ivhd_device_spec
             AMD_IOMMU_DEBUG("IVHD: Command line override present for HPET =
%#x "
                             "(IVRS: %#x devID %pp)\n",
                             hpet_sbdf.id, special->handle,
-                            &PCI_SBDF2(seg, bdf));
+                            &PCI_SBDF(seg, bdf));
             break;
         case HPET_NONE:
             /* set device id of hpet */
--- a/xen/drivers/passthrough/amd/iommu_cmd.c
+++ b/xen/drivers/passthrough/amd/iommu_cmd.c
@@ -40,7 +40,7 @@ static void send_iommu_command(struct am
                      IOMMU_RING_BUFFER_PTR_MASK) )
     {
         printk_once(XENLOG_ERR "AMD IOMMU %pp: no cmd slot available\n",
-                    &PCI_SBDF2(iommu->seg, iommu->bdf));
+                    &PCI_SBDF(iommu->seg, iommu->bdf));
         cpu_relax();
     }
=20
@@ -84,7 +84,7 @@ static void flush_command_buffer(struct
             threshold |=3D threshold << 1;
             printk(XENLOG_WARNING
                    "AMD IOMMU %pp: %scompletion wait taking too long\n",
-                   &PCI_SBDF2(iommu->seg, iommu->bdf),
+                   &PCI_SBDF(iommu->seg, iommu->bdf),
                    timeout_base ? "iotlb " : "");
             timeout =3D 0;
         }
@@ -94,7 +94,7 @@ static void flush_command_buffer(struct
     if ( !timeout )
         printk(XENLOG_WARNING
                "AMD IOMMU %pp: %scompletion wait took %lums\n",
-               &PCI_SBDF2(iommu->seg, iommu->bdf),
+               &PCI_SBDF(iommu->seg, iommu->bdf),
                timeout_base ? "iotlb " : "",
                (NOW() - start) / 10000000);
 }
@@ -292,14 +292,14 @@ void amd_iommu_flush_iotlb(u8 devfn, con
     if ( !iommu )
     {
         AMD_IOMMU_WARN("can't find IOMMU for %pp\n",
-                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn));
+                       &PCI_SBDF(pdev->seg, pdev->bus, devfn));
         return;
     }
=20
     if ( !iommu_has_cap(iommu, PCI_CAP_IOTLB_SHIFT) )
         return;
=20
-    req_id =3D get_dma_requestor_id(iommu->seg, PCI_BDF2(pdev->bus, devfn)=
);
+    req_id =3D get_dma_requestor_id(iommu->seg, PCI_BDF(pdev->bus, devfn))=
;
     queueid =3D req_id;
     maxpend =3D pdev->ats.queue_depth & 0xff;
=20
--- a/xen/drivers/passthrough/amd/iommu_detect.c
+++ b/xen/drivers/passthrough/amd/iommu_detect.c
@@ -231,7 +231,7 @@ int __init amd_iommu_detect_one_acpi(
     rt =3D pci_ro_device(iommu->seg, bus, PCI_DEVFN(dev, func));
     if ( rt )
         printk(XENLOG_ERR "Could not mark config space of %pp read-only (%=
d)\n",
-               &PCI_SBDF2(iommu->seg, iommu->bdf), rt);
+               &PCI_SBDF(iommu->seg, iommu->bdf), rt);
=20
     list_add_tail(&iommu->list, &amd_iommu_head);
     rt =3D 0;
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -562,7 +562,7 @@ static void cf_check parse_event_log_ent
=20
         printk(XENLOG_ERR "AMD-Vi: %s: %pp d%u addr %016"PRIx64
                " flags %#x%s%s%s%s%s%s%s%s%s%s\n",
-               code_str, &PCI_SBDF2(iommu->seg, device_id),
+               code_str, &PCI_SBDF(iommu->seg, device_id),
                domain_id, addr, flags,
                (flags & 0xe00) ? " ??" : "",
                (flags & 0x100) ? " TR" : "",
@@ -578,7 +578,7 @@ static void cf_check parse_event_log_ent
         for ( bdf =3D 0; bdf < ivrs_bdf_entries; bdf++ )
             if ( get_dma_requestor_id(iommu->seg, bdf) =3D=3D device_id )
                 pci_check_disable_device(iommu->seg, PCI_BUS(bdf),
-                                         PCI_DEVFN2(bdf));
+                                         PCI_DEVFN(bdf));
     }
     else
         printk(XENLOG_ERR "%s %08x %08x %08x %08x\n",
@@ -631,18 +631,13 @@ static void iommu_check_event_log(struct
=20
 static void cf_check parse_ppr_log_entry(struct amd_iommu *iommu, u32 entr=
y[])
 {
-
-    u16 device_id;
-    u8 bus, devfn;
-    struct pci_dev *pdev;
-
     /* here device_id is physical value */
-    device_id =3D iommu_get_devid_from_cmd(entry[0]);
-    bus =3D PCI_BUS(device_id);
-    devfn =3D PCI_DEVFN2(device_id);
+    uint16_t device_id =3D iommu_get_devid_from_cmd(entry[0]);
+    struct pci_dev *pdev;
=20
     pcidevs_lock();
-    pdev =3D pci_get_real_pdev(iommu->seg, bus, devfn);
+    pdev =3D pci_get_real_pdev(iommu->seg, PCI_BUS(device_id),
+                             PCI_DEVFN(device_id));
     pcidevs_unlock();
=20
     if ( pdev )
@@ -751,12 +746,12 @@ static bool_t __init set_iommu_interrupt
=20
     pcidevs_lock();
     iommu->msi.dev =3D pci_get_pdev(iommu->seg, PCI_BUS(iommu->bdf),
-                                  PCI_DEVFN2(iommu->bdf));
+                                  PCI_DEVFN(iommu->bdf));
     pcidevs_unlock();
     if ( !iommu->msi.dev )
     {
         AMD_IOMMU_WARN("no pdev for %pp\n",
-                       &PCI_SBDF2(iommu->seg, iommu->bdf));
+                       &PCI_SBDF(iommu->seg, iommu->bdf));
         return 0;
     }
=20
@@ -778,7 +773,7 @@ static bool_t __init set_iommu_interrupt
         hw_irq_controller *handler;
         u16 control;
=20
-        control =3D pci_conf_read16(PCI_SBDF2(iommu->seg, iommu->bdf),
+        control =3D pci_conf_read16(PCI_SBDF(iommu->seg, iommu->bdf),
                                   iommu->msi.msi_attrib.pos + PCI_MSI_FLAG=
S);
=20
         iommu->msi.msi.nvec =3D 1;
@@ -842,22 +837,22 @@ static void amd_iommu_erratum_746_workar
          (boot_cpu_data.x86_model > 0x1f) )
         return;
=20
-    pci_conf_write32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf0, 0x90);
-    value =3D pci_conf_read32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf4);
+    pci_conf_write32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf0, 0x90);
+    value =3D pci_conf_read32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf4);
=20
     if ( value & (1 << 2) )
         return;
=20
     /* Select NB indirect register 0x90 and enable writing */
-    pci_conf_write32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf0, 0x90 | (1 <<=
 8));
+    pci_conf_write32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf0, 0x90 | (1 << =
8));
=20
-    pci_conf_write32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf4, value | (1 <=
< 2));
+    pci_conf_write32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf4, value | (1 <<=
 2));
     printk(XENLOG_INFO
            "AMD-Vi: Applying erratum 746 workaround for IOMMU at %pp\n",
-           &PCI_SBDF2(iommu->seg, iommu->bdf));
+           &PCI_SBDF(iommu->seg, iommu->bdf));
=20
     /* Clear the enable writing bit */
-    pci_conf_write32(PCI_SBDF2(iommu->seg, iommu->bdf), 0xf0, 0x90);
+    pci_conf_write32(PCI_SBDF(iommu->seg, iommu->bdf), 0xf0, 0x90);
 }
=20
 static void enable_iommu(struct amd_iommu *iommu)
@@ -1288,7 +1283,7 @@ static int __init cf_check amd_iommu_set
                 if ( !pci_init )
                     continue;
                 pcidevs_lock();
-                pdev =3D pci_get_pdev(seg, PCI_BUS(bdf), PCI_DEVFN2(bdf));
+                pdev =3D pci_get_pdev(seg, PCI_BUS(bdf), PCI_DEVFN(bdf));
                 pcidevs_unlock();
             }
=20
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -604,7 +604,7 @@ static struct amd_iommu *_find_iommu_for
     if ( iommu )
         return iommu;
=20
-    AMD_IOMMU_DEBUG("No IOMMU for MSI dev =3D %pp\n", &PCI_SBDF2(seg, bdf)=
);
+    AMD_IOMMU_DEBUG("No IOMMU for MSI dev =3D %pp\n", &PCI_SBDF(seg, bdf))=
;
     return ERR_PTR(-EINVAL);
 }
=20
@@ -814,7 +814,7 @@ static void dump_intremap_table(const st
         if ( ivrs_mapping )
         {
             printk("  %pp:\n",
-                   &PCI_SBDF2(iommu->seg, ivrs_mapping->dte_requestor_id))=
;
+                   &PCI_SBDF(iommu->seg, ivrs_mapping->dte_requestor_id));
             ivrs_mapping =3D NULL;
         }
=20
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -534,7 +534,7 @@ int cf_check amd_iommu_get_reserved_devi
=20
     for ( bdf =3D 0; bdf < ivrs_bdf_entries; ++bdf )
     {
-        pci_sbdf_t sbdf =3D PCI_SBDF2(seg, bdf);
+        pci_sbdf_t sbdf =3D PCI_SBDF(seg, bdf);
         const struct ivrs_unity_map *um =3D ivrs_mappings[bdf].unity_map;
         unsigned int req =3D ivrs_mappings[bdf].dte_requestor_id;
         const struct amd_iommu *iommu =3D ivrs_mappings[bdf].iommu;
@@ -563,7 +563,7 @@ int cf_check amd_iommu_get_reserved_devi
              * the same alias ID.
              */
             if ( bdf !=3D req && ivrs_mappings[req].iommu &&
-                 func(0, 0, PCI_SBDF2(seg, req).sbdf, ctxt) )
+                 func(0, 0, PCI_SBDF(seg, req).sbdf, ctxt) )
                 continue;
=20
             if ( global =3D=3D pending )
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -53,7 +53,7 @@ struct amd_iommu *find_iommu_for_device(
             ivrs_mappings[bdf] =3D tmp;
=20
             printk(XENLOG_WARNING "%pp not found in ACPI tables;"
-                   " using same IOMMU as function 0\n", &PCI_SBDF2(seg, bd=
f));
+                   " using same IOMMU as function 0\n", &PCI_SBDF(seg, bdf=
));
=20
             /* write iommu field last */
             ivrs_mappings[bdf].iommu =3D ivrs_mappings[bd0].iommu;
@@ -144,7 +144,7 @@ static int __must_check amd_iommu_setup_
                | (ivrs_dev->unity_map ? SET_ROOT_WITH_UNITY_MAP : 0);
=20
     /* get device-table entry */
-    req_id =3D get_dma_requestor_id(iommu->seg, PCI_BDF2(bus, devfn));
+    req_id =3D get_dma_requestor_id(iommu->seg, PCI_BDF(bus, devfn));
     table =3D iommu->dev_table.buffer;
     dte =3D &table[req_id];
     ivrs_dev =3D &get_ivrs_mappings(iommu->seg)[req_id];
@@ -202,7 +202,7 @@ static int __must_check amd_iommu_setup_
          * presence.  But let's deal with that case only if it is actually
          * found in the wild.
          */
-        if ( req_id !=3D PCI_BDF2(bus, devfn) &&
+        if ( req_id !=3D PCI_BDF(bus, devfn) &&
              (sr_flags & SET_ROOT_WITH_UNITY_MAP) )
             rc =3D -EOPNOTSUPP;
         else
@@ -231,7 +231,7 @@ static int __must_check amd_iommu_setup_
              (any_pdev_behind_iommu(pdev->domain, pdev, iommu) ||
               pdev->phantom_stride) )
             AMD_IOMMU_WARN(" %pp: reassignment may cause %pd data corrupti=
on\n",
-                           &PCI_SBDF3(pdev->seg, bus, devfn), pdev->domain=
);
+                           &PCI_SBDF(pdev->seg, bus, devfn), pdev->domain)=
;
=20
         /*
          * Check remaining settings are still in place from an earlier cal=
l
@@ -414,7 +414,7 @@ static void amd_iommu_disable_domain_dev
         disable_ats_device(pdev);
=20
     BUG_ON ( iommu->dev_table.buffer =3D=3D NULL );
-    req_id =3D get_dma_requestor_id(iommu->seg, PCI_BDF2(bus, devfn));
+    req_id =3D get_dma_requestor_id(iommu->seg, PCI_BDF(bus, devfn));
     table =3D iommu->dev_table.buffer;
     dte =3D &table[req_id];
=20
@@ -461,7 +461,7 @@ static int cf_check reassign_device(
     if ( !iommu )
     {
         AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be assigned to %p=
d\n",
-                       &PCI_SBDF3(pdev->seg, pdev->bus, devfn), target);
+                       &PCI_SBDF(pdev->seg, pdev->bus, devfn), target);
         return -ENODEV;
     }
=20
@@ -488,7 +488,7 @@ static int cf_check reassign_device(
     if ( !is_hardware_domain(source) )
     {
         const struct ivrs_mappings *ivrs_mappings =3D get_ivrs_mappings(pd=
ev->seg);
-        unsigned int bdf =3D PCI_BDF2(pdev->bus, devfn);
+        unsigned int bdf =3D PCI_BDF(pdev->bus, devfn);
=20
         rc =3D amd_iommu_reserve_domain_unity_unmap(
                  source,
@@ -498,7 +498,7 @@ static int cf_check reassign_device(
     }
=20
     AMD_IOMMU_DEBUG("Re-assign %pp from %pd to %pd\n",
-                    &PCI_SBDF3(pdev->seg, pdev->bus, devfn), source, targe=
t);
+                    &PCI_SBDF(pdev->seg, pdev->bus, devfn), source, target=
);
=20
     return 0;
 }
@@ -507,7 +507,7 @@ static int cf_check amd_iommu_assign_dev
     struct domain *d, u8 devfn, struct pci_dev *pdev, u32 flag)
 {
     struct ivrs_mappings *ivrs_mappings =3D get_ivrs_mappings(pdev->seg);
-    int bdf =3D PCI_BDF2(pdev->bus, devfn);
+    unsigned int bdf =3D PCI_BDF(pdev->bus, devfn);
     int req_id =3D get_dma_requestor_id(pdev->seg, bdf);
     int rc =3D amd_iommu_reserve_domain_unity_map(
                  d, ivrs_mappings[req_id].unity_map, flag);
@@ -575,12 +575,12 @@ static int cf_check amd_iommu_add_device
         }
=20
         AMD_IOMMU_WARN("no IOMMU for %pp; cannot be handed to %pd\n",
-                        &PCI_SBDF3(pdev->seg, pdev->bus, devfn), pdev->dom=
ain);
+                        &PCI_SBDF(pdev->seg, pdev->bus, devfn), pdev->doma=
in);
         return -ENODEV;
     }
=20
     ivrs_mappings =3D get_ivrs_mappings(pdev->seg);
-    bdf =3D PCI_BDF2(pdev->bus, devfn);
+    bdf =3D PCI_BDF(pdev->bus, devfn);
     if ( !ivrs_mappings ||
          !ivrs_mappings[ivrs_mappings[bdf].dte_requestor_id].valid )
         return -EPERM;
@@ -618,7 +618,7 @@ static int cf_check amd_iommu_add_device
              ivrs_mappings[ivrs_mappings[bdf].dte_requestor_id].unity_map,
              0) )
         AMD_IOMMU_WARN("%pd: unity mapping failed for %pp\n",
-                       pdev->domain, &PCI_SBDF2(pdev->seg, bdf));
+                       pdev->domain, &PCI_SBDF(pdev->seg, bdf));
=20
     if ( iommu_quarantine && pdev->arch.pseudo_domid =3D=3D DOMID_INVALID =
)
     {
@@ -651,20 +651,20 @@ static int cf_check amd_iommu_remove_dev
     if ( !iommu )
     {
         AMD_IOMMU_WARN("failed to find IOMMU: %pp cannot be removed from %=
pd\n",
-                        &PCI_SBDF3(pdev->seg, pdev->bus, devfn), pdev->dom=
ain);
+                        &PCI_SBDF(pdev->seg, pdev->bus, devfn), pdev->doma=
in);
         return -ENODEV;
     }
=20
     amd_iommu_disable_domain_device(pdev->domain, iommu, devfn, pdev);
=20
     ivrs_mappings =3D get_ivrs_mappings(pdev->seg);
-    bdf =3D PCI_BDF2(pdev->bus, devfn);
+    bdf =3D PCI_BDF(pdev->bus, devfn);
=20
     if ( amd_iommu_reserve_domain_unity_unmap(
              pdev->domain,
              ivrs_mappings[ivrs_mappings[bdf].dte_requestor_id].unity_map)=
 )
         AMD_IOMMU_WARN("%pd: unity unmapping failed for %pp\n",
-                       pdev->domain, &PCI_SBDF2(pdev->seg, bdf));
+                       pdev->domain, &PCI_SBDF(pdev->seg, bdf));
=20
     amd_iommu_quarantine_teardown(pdev);
=20
@@ -681,7 +681,7 @@ static int cf_check amd_iommu_remove_dev
=20
 static int cf_check amd_iommu_group_id(u16 seg, u8 bus, u8 devfn)
 {
-    int bdf =3D PCI_BDF2(bus, devfn);
+    unsigned int bdf =3D PCI_BDF(bus, devfn);
=20
     return (bdf < ivrs_bdf_entries) ? get_dma_requestor_id(seg, bdf) : bdf=
;
 }
--- a/xen/drivers/passthrough/ats.h
+++ b/xen/drivers/passthrough/ats.h
@@ -35,7 +35,7 @@ static inline int pci_ats_enabled(int se
     pos =3D pci_find_ext_capability(seg, bus, devfn, PCI_EXT_CAP_ID_ATS);
     BUG_ON(!pos);
=20
-    value =3D pci_conf_read16(PCI_SBDF3(seg, bus, devfn), pos + ATS_REG_CT=
L);
+    value =3D pci_conf_read16(PCI_SBDF(seg, bus, devfn), pos + ATS_REG_CTL=
);
=20
     return value & ATS_ENABLE;
 }
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -553,7 +553,7 @@ int __init pci_ro_device(int seg, int bu
         memset(pseg->ro_map, 0, sz);
     }
=20
-    __set_bit(PCI_BDF2(bus, devfn), pseg->ro_map);
+    __set_bit(PCI_BDF(bus, devfn), pseg->ro_map);
     _pci_hide_device(pdev);
=20
     return 0;
@@ -957,7 +957,7 @@ static int deassign_device(struct domain
  out:
     if ( ret )
         printk(XENLOG_G_ERR "%pd: deassign (%pp) failed (%d)\n",
-               d, &PCI_SBDF3(seg, bus, devfn), ret);
+               d, &PCI_SBDF(seg, bus, devfn), ret);
=20
     return ret;
 }
@@ -1406,7 +1406,7 @@ static int iommu_add_device(struct pci_d
         rc =3D iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(=
pdev));
         if ( rc )
             printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n",
-                   &PCI_SBDF3(pdev->seg, pdev->bus, devfn), rc);
+                   &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc);
     }
 }
=20
@@ -1452,7 +1452,7 @@ static int iommu_remove_device(struct pc
             continue;
=20
         printk(XENLOG_ERR "IOMMU: remove %pp failed (%d)\n",
-               &PCI_SBDF3(pdev->seg, pdev->bus, devfn), rc);
+               &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc);
         return rc;
     }
=20
@@ -1536,7 +1536,7 @@ static int assign_device(struct domain *
  done:
     if ( rc )
         printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n",
-               d, &PCI_SBDF3(seg, bus, devfn), rc);
+               d, &PCI_SBDF(seg, bus, devfn), rc);
     /* The device is assigned to dom_io so mark it as quarantined */
     else if ( d =3D=3D dom_io )
         pdev->quarantine =3D true;
@@ -1647,7 +1647,7 @@ int iommu_do_pci_domctl(
=20
         seg =3D domctl->u.get_device_group.machine_sbdf >> 16;
         bus =3D PCI_BUS(domctl->u.get_device_group.machine_sbdf);
-        devfn =3D PCI_DEVFN2(domctl->u.get_device_group.machine_sbdf);
+        devfn =3D PCI_DEVFN(domctl->u.get_device_group.machine_sbdf);
         max_sdevs =3D domctl->u.get_device_group.max_sdevs;
         sdevs =3D domctl->u.get_device_group.sdev_array;
=20
@@ -1697,7 +1697,7 @@ int iommu_do_pci_domctl(
=20
         seg =3D machine_sbdf >> 16;
         bus =3D PCI_BUS(machine_sbdf);
-        devfn =3D PCI_DEVFN2(machine_sbdf);
+        devfn =3D PCI_DEVFN(machine_sbdf);
=20
         pcidevs_lock();
         ret =3D device_assigned(seg, bus, devfn);
@@ -1706,7 +1706,7 @@ int iommu_do_pci_domctl(
             if ( ret )
             {
                 printk(XENLOG_G_INFO "%pp already assigned, or non-existen=
t\n",
-                       &PCI_SBDF3(seg, bus, devfn));
+                       &PCI_SBDF(seg, bus, devfn));
                 ret =3D -EINVAL;
             }
         }
@@ -1742,7 +1742,7 @@ int iommu_do_pci_domctl(
=20
         seg =3D machine_sbdf >> 16;
         bus =3D PCI_BUS(machine_sbdf);
-        devfn =3D PCI_DEVFN2(machine_sbdf);
+        devfn =3D PCI_DEVFN(machine_sbdf);
=20
         pcidevs_lock();
         ret =3D deassign_device(d, seg, bus, devfn);
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -222,7 +222,7 @@ struct acpi_drhd_unit *acpi_find_matched
             continue;
=20
         for (i =3D 0; i < drhd->scope.devices_cnt; i++)
-            if ( drhd->scope.devices[i] =3D=3D PCI_BDF2(bus, devfn) )
+            if ( drhd->scope.devices[i] =3D=3D PCI_BDF(bus, devfn) )
                 return drhd;
=20
         if ( test_bit(bus, drhd->scope.buses) )
@@ -1062,7 +1062,7 @@ int cf_check intel_iommu_get_reserved_de
=20
         rc =3D func(PFN_DOWN(rmrr->base_address),
                   PFN_UP(rmrr->end_address) - PFN_DOWN(rmrr->base_address)=
,
-                  PCI_SBDF2(rmrr->segment, bdf).sbdf, ctxt);
+                  PCI_SBDF(rmrr->segment, bdf).sbdf, ctxt);
=20
         if ( unlikely(rc < 0) )
             return rc;
--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -498,7 +498,7 @@ static void set_msi_source_id(struct pci
         case 4: sq =3D SQ_13_IGNORE_1; break;
         default: sq =3D SQ_ALL_16; break;
         }
-        set_ire_sid(ire, SVT_VERIFY_SID_SQ, sq, PCI_BDF2(bus, devfn));
+        set_ire_sid(ire, SVT_VERIFY_SID_SQ, sq, PCI_BDF(bus, devfn));
         break;
=20
     case DEV_TYPE_PCI:
@@ -508,7 +508,7 @@ static void set_msi_source_id(struct pci
         if ( ret =3D=3D 0 ) /* integrated PCI device */
         {
             set_ire_sid(ire, SVT_VERIFY_SID_SQ, SQ_ALL_16,
-                        PCI_BDF2(bus, devfn));
+                        PCI_BDF(bus, devfn));
         }
         else if ( ret =3D=3D 1 ) /* find upstream bridge */
         {
@@ -517,7 +517,7 @@ static void set_msi_source_id(struct pci
                             (bus << 8) | pdev->bus);
             else
                 set_ire_sid(ire, SVT_VERIFY_SID_SQ, SQ_ALL_16,
-                            PCI_BDF2(bus, devfn));
+                            PCI_BDF(bus, devfn));
         }
         else
             dprintk(XENLOG_WARNING VTDPREFIX,
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -938,21 +938,21 @@ static int iommu_page_fault_do_one(struc
                "DMAR:[%s] Request device [%pp] "
                "fault addr %"PRIx64"\n",
                (type ? "DMA Read" : "DMA Write"),
-               &PCI_SBDF2(seg, source_id), addr);
+               &PCI_SBDF(seg, source_id), addr);
         kind =3D "DMAR";
         break;
     case INTR_REMAP:
         printk(XENLOG_G_WARNING VTDPREFIX
                "INTR-REMAP: Request device [%pp] "
                "fault index %"PRIx64"\n",
-               &PCI_SBDF2(seg, source_id), addr >> 48);
+               &PCI_SBDF(seg, source_id), addr >> 48);
         kind =3D "INTR-REMAP";
         break;
     default:
         printk(XENLOG_G_WARNING VTDPREFIX
                "UNKNOWN: Request device [%pp] "
                "fault addr %"PRIx64"\n",
-               &PCI_SBDF2(seg, source_id), addr);
+               &PCI_SBDF(seg, source_id), addr);
         kind =3D "UNKNOWN";
         break;
     }
@@ -961,7 +961,7 @@ static int iommu_page_fault_do_one(struc
            kind, fault_reason, reason);
=20
     if ( iommu_verbose && fault_type =3D=3D DMA_REMAP )
-        print_vtd_entries(iommu, PCI_BUS(source_id), PCI_DEVFN2(source_id)=
,
+        print_vtd_entries(iommu, PCI_BUS(source_id), PCI_DEVFN(source_id),
                           addr >> PAGE_SHIFT);
=20
     return 0;
@@ -1039,7 +1039,7 @@ static void __do_iommu_page_fault(struct
                                 source_id, guest_addr);
=20
         pci_check_disable_device(iommu->drhd->segment,
-                                 PCI_BUS(source_id), PCI_DEVFN2(source_id)=
);
+                                 PCI_BUS(source_id), PCI_DEVFN(source_id))=
;
=20
         fault_index++;
         if ( fault_index > cap_num_fault_regs(iommu->cap) )
@@ -1541,7 +1541,7 @@ int domain_context_mapping_one(
                 check_cleanup_domid_map(domain, pdev, iommu);
             printk(XENLOG_ERR
                    "%pp: unexpected context entry %016lx_%016lx (expected =
%016lx_%016lx)\n",
-                   &PCI_SBDF3(seg, bus, devfn),
+                   &PCI_SBDF(seg, bus, devfn),
                    (uint64_t)(res >> 64), (uint64_t)res,
                    (uint64_t)(old >> 64), (uint64_t)old);
             rc =3D -EILSEQ;
@@ -1571,7 +1571,7 @@ int domain_context_mapping_one(
         if ( !(mode & (MAP_OWNER_DYING | MAP_SINGLE_DEVICE)) )
             printk(XENLOG_WARNING VTDPREFIX
                    " %pp: reassignment may cause %pd data corruption\n",
-                   &PCI_SBDF3(seg, bus, devfn), prev_dom);
+                   &PCI_SBDF(seg, bus, devfn), prev_dom);
=20
         write_atomic(&context->lo, lctxt.lo);
         /* No barrier should be needed between these two. */
@@ -1581,7 +1581,7 @@ int domain_context_mapping_one(
     iommu_sync_cache(context, sizeof(struct context_entry));
     spin_unlock(&iommu->lock);
=20
-    rc =3D iommu_flush_context_device(iommu, prev_did, PCI_BDF2(bus, devfn=
),
+    rc =3D iommu_flush_context_device(iommu, prev_did, PCI_BDF(bus, devfn)=
,
                                     DMA_CCMD_MASK_NOBIT, !prev_dom);
     flush_dev_iotlb =3D !!find_ats_dev_drhd(iommu);
     ret =3D iommu_flush_iotlb_dsi(iommu, prev_did, !prev_dom, flush_dev_io=
tlb);
@@ -1688,7 +1688,7 @@ static int domain_context_mapping(struct
     case DEV_TYPE_PCI_HOST_BRIDGE:
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:Hostbridge: skip %pp map\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         if ( !is_hardware_domain(domain) )
             return -EPERM;
         break;
@@ -1712,7 +1712,7 @@ static int domain_context_mapping(struct
=20
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCIe: map %pp\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         ret =3D domain_context_mapping_one(domain, drhd->iommu, bus, devfn=
, pdev,
                                          DEVICE_DOMID(domain, pdev), pgd_m=
addr,
                                          mode);
@@ -1737,7 +1737,7 @@ static int domain_context_mapping(struct
=20
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCI: map %pp\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
=20
         ret =3D domain_context_mapping_one(domain, drhd->iommu, bus, devfn=
,
                                          pdev, DEVICE_DOMID(domain, pdev),
@@ -1802,7 +1802,7 @@ static int domain_context_mapping(struct
=20
     default:
         dprintk(XENLOG_ERR VTDPREFIX, "%pd:unknown(%u): %pp\n",
-                domain, pdev->type, &PCI_SBDF3(seg, bus, devfn));
+                domain, pdev->type, &PCI_SBDF(seg, bus, devfn));
         ret =3D -EINVAL;
         break;
     }
@@ -1851,7 +1851,7 @@ int domain_context_unmap_one(
     iommu_sync_cache(context, sizeof(struct context_entry));
=20
     rc =3D iommu_flush_context_device(iommu, iommu_domid,
-                                    PCI_BDF2(bus, devfn),
+                                    PCI_BDF(bus, devfn),
                                     DMA_CCMD_MASK_NOBIT, 0);
=20
     flush_dev_iotlb =3D !!find_ats_dev_drhd(iommu);
@@ -1910,7 +1910,7 @@ static const struct acpi_drhd_unit *doma
     case DEV_TYPE_PCI_HOST_BRIDGE:
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:Hostbridge: skip %pp unmap\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         return ERR_PTR(is_hardware_domain(domain) ? 0 : -EPERM);
=20
     case DEV_TYPE_PCIe_BRIDGE:
@@ -1924,7 +1924,7 @@ static const struct acpi_drhd_unit *doma
=20
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCIe: unmap %pp\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         ret =3D domain_context_unmap_one(domain, iommu, bus, devfn);
         if ( !ret && devfn =3D=3D pdev->devfn && ats_device(pdev, drhd) > =
0 )
             disable_ats_device(pdev);
@@ -1937,7 +1937,7 @@ static const struct acpi_drhd_unit *doma
=20
         if ( iommu_debug )
             printk(VTDPREFIX "%pd:PCI: unmap %pp\n",
-                   domain, &PCI_SBDF3(seg, bus, devfn));
+                   domain, &PCI_SBDF(seg, bus, devfn));
         ret =3D domain_context_unmap_one(domain, iommu, bus, devfn);
         if ( ret )
             break;
@@ -1970,7 +1970,7 @@ static const struct acpi_drhd_unit *doma
=20
     default:
         dprintk(XENLOG_ERR VTDPREFIX, "%pd:unknown(%u): %pp\n",
-                domain, pdev->type, &PCI_SBDF3(seg, bus, devfn));
+                domain, pdev->type, &PCI_SBDF(seg, bus, devfn));
         return ERR_PTR(-EINVAL);
     }
=20
@@ -2181,9 +2181,7 @@ static int cf_check intel_iommu_add_devi
=20
     for_each_rmrr_device ( rmrr, bdf, i )
     {
-        if ( rmrr->segment =3D=3D pdev->seg &&
-             PCI_BUS(bdf) =3D=3D pdev->bus &&
-             PCI_DEVFN2(bdf) =3D=3D devfn )
+        if ( rmrr->segment =3D=3D pdev->seg && bdf =3D=3D PCI_BDF(pdev->bu=
s, devfn) )
         {
             /*
              * iommu_add_device() is only called for the hardware
@@ -2239,9 +2237,7 @@ static int cf_check intel_iommu_remove_d
=20
     for_each_rmrr_device ( rmrr, bdf, i )
     {
-        if ( rmrr->segment !=3D pdev->seg ||
-             PCI_BUS(bdf) !=3D pdev->bus ||
-             PCI_DEVFN2(bdf) !=3D devfn )
+        if ( rmrr->segment !=3D pdev->seg || bdf !=3D PCI_BDF(pdev->bus, d=
evfn) )
             continue;
=20
         /*
@@ -2668,8 +2664,7 @@ static int cf_check reassign_device_owne
=20
         for_each_rmrr_device( rmrr, bdf, i )
             if ( rmrr->segment =3D=3D pdev->seg &&
-                 PCI_BUS(bdf) =3D=3D pdev->bus &&
-                 PCI_DEVFN2(bdf) =3D=3D devfn )
+                 bdf =3D=3D PCI_BDF(pdev->bus, devfn) )
             {
                 /*
                  * Any RMRR flag is always ignored when remove a device,
@@ -2713,9 +2708,7 @@ static int cf_check intel_iommu_assign_d
      */
     for_each_rmrr_device( rmrr, bdf, i )
     {
-        if ( rmrr->segment =3D=3D seg &&
-             PCI_BUS(bdf) =3D=3D bus &&
-             PCI_DEVFN2(bdf) =3D=3D devfn &&
+        if ( rmrr->segment =3D=3D seg && bdf =3D=3D PCI_BDF(bus, devfn) &&
              rmrr->scope.devices_cnt > 1 )
         {
             bool_t relaxed =3D !!(flag & XEN_DOMCTL_DEV_RDM_RELAXED);
@@ -2725,7 +2718,7 @@ static int cf_check intel_iommu_assign_d
                    " with shared RMRR at %"PRIx64" for %pd.\n",
                    relaxed ? XENLOG_WARNING : XENLOG_ERR,
                    relaxed ? "risky" : "disallowed",
-                   &PCI_SBDF3(seg, bus, devfn), rmrr->base_address, d);
+                   &PCI_SBDF(seg, bus, devfn), rmrr->base_address, d);
             if ( !relaxed )
                 return -EPERM;
         }
@@ -2737,9 +2730,7 @@ static int cf_check intel_iommu_assign_d
     /* Setup rmrr identity mapping */
     for_each_rmrr_device( rmrr, bdf, i )
     {
-        if ( rmrr->segment =3D=3D seg &&
-             PCI_BUS(bdf) =3D=3D bus &&
-             PCI_DEVFN2(bdf) =3D=3D devfn )
+        if ( rmrr->segment =3D=3D seg && bdf =3D=3D PCI_BDF(bus, devfn) )
         {
             ret =3D iommu_identity_mapping(d, p2m_access_rw, rmrr->base_ad=
dress,
                                          rmrr->end_address, flag);
@@ -2762,9 +2753,7 @@ static int cf_check intel_iommu_assign_d
=20
     for_each_rmrr_device( rmrr, bdf, i )
     {
-        if ( rmrr->segment =3D=3D seg &&
-             PCI_BUS(bdf) =3D=3D bus &&
-             PCI_DEVFN2(bdf) =3D=3D devfn )
+        if ( rmrr->segment =3D=3D seg && bdf =3D=3D PCI_BDF(bus, devfn) )
         {
             int rc =3D iommu_identity_mapping(d, p2m_access_x,
                                             rmrr->base_address,
@@ -2791,7 +2780,7 @@ static int cf_check intel_iommu_group_id
     if ( find_upstream_bridge(seg, &bus, &devfn, &secbus) < 0 )
         return -ENODEV;
=20
-    return PCI_BDF2(bus, devfn);
+    return PCI_BDF(bus, devfn);
 }
=20
 static int __must_check cf_check vtd_suspend(void)
--- a/xen/drivers/passthrough/vtd/quirks.c
+++ b/xen/drivers/passthrough/vtd/quirks.c
@@ -115,7 +115,7 @@ bool is_azalia_tlb_enabled(const struct
         return true;
=20
     /* Check for the specific device. */
-    sbdf =3D PCI_SBDF2(drhd->segment, drhd->scope.devices[0]);
+    sbdf =3D PCI_SBDF(drhd->segment, drhd->scope.devices[0]);
     if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) !=3D PCI_VENDOR_ID_INTEL ||
          pci_conf_read16(sbdf, PCI_DEVICE_ID) !=3D 0x3a3e )
         return true;
@@ -446,7 +446,7 @@ int me_wifi_quirk(struct domain *domain,
             return 0;
=20
         /* if device is WLAN device, map ME phantom device 0:3.7 */
-        id =3D pci_conf_read32(PCI_SBDF3(0, bus, devfn), 0);
+        id =3D pci_conf_read32(PCI_SBDF(0, bus, devfn), 0);
         switch (id)
         {
             case 0x42328086:
@@ -470,7 +470,7 @@ int me_wifi_quirk(struct domain *domain,
             return 0;
=20
         /* if device is WLAN device, map ME phantom device 0:22.7 */
-        id =3D pci_conf_read32(PCI_SBDF3(0, bus, devfn), 0);
+        id =3D pci_conf_read32(PCI_SBDF(0, bus, devfn), 0);
         switch (id)
         {
             case 0x00878086:        /* Kilmer Peak */
--- a/xen/drivers/passthrough/vtd/utils.c
+++ b/xen/drivers/passthrough/vtd/utils.c
@@ -96,7 +96,7 @@ void print_vtd_entries(struct vtd_iommu
     u32 l_index, level;
=20
     printk("print_vtd_entries: iommu #%u dev %pp gmfn %"PRI_gfn"\n",
-           iommu->index, &PCI_SBDF3(iommu->drhd->segment, bus, devfn),
+           iommu->index, &PCI_SBDF(iommu->drhd->segment, bus, devfn),
            gmfn);
=20
     if ( iommu->root_maddr =3D=3D 0 )
--- a/xen/drivers/pci/pci.c
+++ b/xen/drivers/pci/pci.c
@@ -46,12 +46,12 @@ int pci_find_next_cap(u16 seg, u8 bus, u
=20
     while ( ttl-- )
     {
-        pos =3D pci_conf_read8(PCI_SBDF3(seg, bus, devfn), pos);
+        pos =3D pci_conf_read8(PCI_SBDF(seg, bus, devfn), pos);
         if ( pos < 0x40 )
             break;
=20
         pos &=3D ~3;
-        id =3D pci_conf_read8(PCI_SBDF3(seg, bus, devfn), pos + PCI_CAP_LI=
ST_ID);
+        id =3D pci_conf_read8(PCI_SBDF(seg, bus, devfn), pos + PCI_CAP_LIS=
T_ID);
=20
         if ( id =3D=3D 0xff )
             break;
@@ -93,7 +93,7 @@ int pci_find_next_ext_capability(int seg
     int ttl =3D 480; /* 3840 bytes, minimum 8 bytes per capability */
     int pos =3D max(start, 0x100);
=20
-    header =3D pci_conf_read32(PCI_SBDF3(seg, bus, devfn), pos);
+    header =3D pci_conf_read32(PCI_SBDF(seg, bus, devfn), pos);
=20
     /*
      * If we have no capabilities, this is indicated by cap ID,
@@ -109,7 +109,7 @@ int pci_find_next_ext_capability(int seg
         pos =3D PCI_EXT_CAP_NEXT(header);
         if ( pos < 0x100 )
             break;
-        header =3D pci_conf_read32(PCI_SBDF3(seg, bus, devfn), pos);
+        header =3D pci_conf_read32(PCI_SBDF(seg, bus, devfn), pos);
     }
     return 0;
 }
@@ -162,7 +162,7 @@ const char *__init parse_pci_seg(const c
     else
         func =3D 0;
     if ( seg !=3D (seg_p ? (u16)seg : 0) ||
-         bus !=3D PCI_BUS(PCI_BDF2(bus, 0)) ||
+         bus !=3D PCI_BUS(PCI_BDF(bus, 0)) ||
          dev !=3D PCI_SLOT(PCI_DEVFN(dev, 0)) ||
          func !=3D PCI_FUNC(PCI_DEVFN(0, func)) )
         return NULL;
--- a/xen/drivers/video/vga.c
+++ b/xen/drivers/video/vga.c
@@ -122,9 +122,9 @@ void __init video_endboot(void)
                 pcidevs_unlock();
=20
                 if ( !pdev ||
-                     pci_conf_read16(PCI_SBDF3(0, bus, devfn),
+                     pci_conf_read16(PCI_SBDF(0, bus, devfn),
                                      PCI_CLASS_DEVICE) !=3D 0x0300 ||
-                     !(pci_conf_read16(PCI_SBDF3(0, bus, devfn), PCI_COMMA=
ND) &
+                     !(pci_conf_read16(PCI_SBDF(0, bus, devfn), PCI_COMMAN=
D) &
                        (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) )
                     continue;
=20
@@ -136,12 +136,12 @@ void __init video_endboot(void)
                         b =3D 0;
                         break;
                     case 1:
-                        switch ( pci_conf_read8(PCI_SBDF3(0, b, df),
+                        switch ( pci_conf_read8(PCI_SBDF(0, b, df),
                                                 PCI_HEADER_TYPE) )
                         {
                         case PCI_HEADER_TYPE_BRIDGE:
                         case PCI_HEADER_TYPE_CARDBUS:
-                            if ( pci_conf_read16(PCI_SBDF3(0, b, df),
+                            if ( pci_conf_read16(PCI_SBDF(0, b, df),
                                                  PCI_BRIDGE_CONTROL) &
                                  PCI_BRIDGE_CTL_VGA )
                                 continue;
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -29,16 +29,21 @@
 #define PCI_BUS(bdf)    (((bdf) >> 8) & 0xff)
 #define PCI_SLOT(bdf)   (((bdf) >> 3) & 0x1f)
 #define PCI_FUNC(bdf)   ((bdf) & 0x07)
-#define PCI_DEVFN(d,f)  ((((d) & 0x1f) << 3) | ((f) & 0x07))
-#define PCI_DEVFN2(bdf) ((bdf) & 0xff)
-#define PCI_BDF(b,d,f)  ((((b) & 0xff) << 8) | PCI_DEVFN(d,f))
-#define PCI_BDF2(b,df)  ((((b) & 0xff) << 8) | ((df) & 0xff))
-#define PCI_SBDF(s,b,d,f) \
-    ((pci_sbdf_t){ .sbdf =3D (((s) & 0xffff) << 16) | PCI_BDF(b, d, f) })
-#define PCI_SBDF2(s,bdf) \
+
+#define PCI_DEVFN1_(df)   ((df) & 0xff)
+#define PCI_DEVFN2_(d, f) ((((d) & 0x1f) << 3) | ((f) & 7))
+#define PCI_SBDF4_(s, b, d, f...) \
+    ((pci_sbdf_t){ .sbdf =3D (((s) & 0xffff) << 16) | PCI_BDF(b, d, ##f) }=
)
+#define PCI_SBDF3_ PCI_SBDF4_
+#define PCI_SBDF2_(s, bdf) \
     ((pci_sbdf_t){ .sbdf =3D (((s) & 0xffff) << 16) | ((bdf) & 0xffff) })
-#define PCI_SBDF3(s,b,df) \
-    ((pci_sbdf_t){ .sbdf =3D (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
+
+#define PCI__(what, nr) PCI_##what##nr##_
+#define PCI_(what, nr)  PCI__(what, nr)
+
+#define PCI_DEVFN(d, f...)   PCI_(DEVFN, count_args(d, ##f))(d, ##f)
+#define PCI_BDF(b, d, f...)  ((((b) & 0xff) << 8) | PCI_DEVFN(d, ##f))
+#define PCI_SBDF(s, b, d...) PCI_(SBDF, count_args(s, b, ##d))(s, b, ##d)
=20
 #define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
=20



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:40:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:40:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310276.527008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXz0-0006kQ-5x; Thu, 21 Apr 2022 14:40:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310276.527008; Thu, 21 Apr 2022 14:40:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhXz0-0006kJ-2F; Thu, 21 Apr 2022 14:40:34 +0000
Received: by outflank-mailman (input) for mailman id 310276;
 Thu, 21 Apr 2022 14:40:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=q+Sl=U7=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhXyy-0006kD-Sr
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:40:32 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fb51597f-c180-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 16:40:27 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650552022039241.49162966002302;
 Thu, 21 Apr 2022 07:40:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb51597f-c180-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650552026; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=fj+mQqyhFd+gi98MLfSQqZZ31QCRNBG1/Fw/zW1oqrKc0Gg1jR1LLHTQvf/QYXsRJcKMtG8xHzpjvSVi2zaev0iJzqmHXJnRiQ4VFtfOASOLWyAh6GFr2EDQRIocxCFqVVAUgNH95s4t1/Uc3JO3tb3e6YLF0e3Augxxvv5myzA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650552026; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=INRJ/oYyZWUNGp0FaIjHRLa1bulSIckxyOMlagQ3NGc=; 
	b=l0tzb3V9O08FUO6S2NOObjAjxYqEyC6p0stPQSfQLDMZbZCpkixbZl5dZ4uuKuu73WGumbaugfcUEc/N5UwDwiJLM78EICYgBpFXtErtT2Rx4IaGyYBayZpZTexv0VRdioLMvvs+Apn4NkR9IhsQIXuxZdvEa5qusOCbrAMULs8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650552026;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=INRJ/oYyZWUNGp0FaIjHRLa1bulSIckxyOMlagQ3NGc=;
	b=Z1VeLQgYW0FN9sYx3u3Y++E3A78rLQtAiaLJ2dJY1vTmYFwfhEj3oLVVh/6TqMe7
	VPVfL6scQdevs+pMNqBEJY8ApmF9iANYAvKmQxRp/GpZ2xXRx891BisYjhHe3uCcsx4
	AeMNthcD//cRMRFctJoRa0AmMRgextH7fZJf15PM=
Message-ID: <77f0b3d0-dfba-f909-249e-fe51e068d635@apertussolutions.com>
Date: Thu, 21 Apr 2022 10:39:38 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
 <20220420222834.5478-3-dpsmith@apertussolutions.com>
 <201cc975-7566-7e96-d964-dd65e1a15c25@suse.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH v2 2/2] flask: implement xsm_transtion_running
In-Reply-To: <201cc975-7566-7e96-d964-dd65e1a15c25@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/21/22 05:22, Jan Beulich wrote:
> On 21.04.2022 00:28, Daniel P. Smith wrote:
>> --- a/xen/xsm/flask/hooks.c
>> +++ b/xen/xsm/flask/hooks.c
>> @@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>>      switch ( d->domain_id )
>>      {
>>      case DOMID_IDLE:
>> -        dsec->sid = SECINITSID_XEN;
>> +        dsec->sid = SECINITSID_XENBOOT;
>>          break;
>>      case DOMID_XEN:
>>          dsec->sid = SECINITSID_DOMXEN;
>> @@ -188,6 +188,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>>  
>>  static void cf_check flask_transition_running(void)
>>  {
>> +    struct domain_security_struct *dsec;
>>      struct domain *d = current->domain;
>>  
>>      if ( d->domain_id != DOMID_IDLE )
>> @@ -198,6 +199,10 @@ static void cf_check flask_transition_running(void)
>>       * set to false for the consistency check(s) in the setup code.
>>       */
>>      d->is_privileged = false;
>> +
>> +    dsec = d->ssid;
>> +    dsec->sid = SECINITSID_XEN;
>> +    dsec->self_sid = dsec->sid;
>>  }
> 
> If replacing SIDs is an okay thing to do, perhaps assert that the
> values haven't changed from SECINITSID_XENBOOT prior to replacing
> them?

Yes, changing a domain's SID is a legitimate action that could be done
today via the FLASK_RELABEL_DOMAIN subop of xsm_op hypercall that ends
up calling flask_relabel_domain(), when using flask policy. This is
where Jason was concerned if I was going to be using that call to change
the SID, which would require a policy rule to allow xenboot_t to relabel
itself as xen_t. As flask works today, the system domains use initial
SIDs which are effectively compile-time labels, which means the policy
rule is a static, fixed rule, i.e. it is not possible to use a different
set of labels, that must always be present. This also introduces the
risk for a custom policy writer to inadvertently leave the xenboot_t to
xen_t transitional rule out resulting in a failed access attempt which
would lead to a panic. This is unnecessary pain when we can just handle
the transition internal to the hypervisor as that where it is all really
occurring.

As for the ASSERT, that is a good point since there is a specific state
we are expecting to enter the hook. Pair that with some thinking I have
had to do in answering Jason, Roger, and yourself, I am going to rewire
the hook to return a success/error return value and move the panic
outside the check.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:50:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:50:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310281.527019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhY8s-0008Vl-3Z; Thu, 21 Apr 2022 14:50:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310281.527019; Thu, 21 Apr 2022 14:50:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhY8s-0008Ve-0a; Thu, 21 Apr 2022 14:50:46 +0000
Received: by outflank-mailman (input) for mailman id 310281;
 Thu, 21 Apr 2022 14:50:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BFhx=U7=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1nhY8r-0008VY-8B
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:50:45 +0000
Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com
 [2a00:1450:4864:20::330])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6bdd31dd-c182-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 16:50:44 +0200 (CEST)
Received: by mail-wm1-x330.google.com with SMTP id
 v64-20020a1cac43000000b0038cfd1b3a6dso6042468wme.5
 for <xen-devel@lists.xenproject.org>; Thu, 21 Apr 2022 07:50:44 -0700 (PDT)
Received: from [10.7.237.9] (54-240-197-225.amazon.com. [54.240.197.225])
 by smtp.gmail.com with ESMTPSA id
 m4-20020a7bcb84000000b00389efb7a5b4sm2238632wmi.17.2022.04.21.07.50.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 21 Apr 2022 07:50:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bdd31dd-c182-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=xBmdIR6wjqg4mGc+d6ERxxHFFhbZxiDh8aa+zoHO7oo=;
        b=BsPzQg9C7WZmWatbiQCyBE8gFNC5U8m3pbO0fG9Q+yEHtbyarMgqmFbVz7+swym/On
         yPKf03qIZLge3K2zB3+/AVen+/aW9DOemoVgtvP3J0Ib23uGye7VJE28nD2VCHr61CD7
         o92PehUgwpbJdE0smDKshlxSvdHRoSdF2UBbBNWkrHM3Cmd5oKUDkLWOnfXtHo4J+GAg
         t4ra+mfPQ5zpMYGkvEvxgZcwWrH8K5XAcZi0z+K3YR7gMYclyihu9CZOhJes97uueprW
         gWrg+cOl0/zWn28xTbFKFmrUzjmnPEV19v4QglZXTC9DVIRKMdOJLWADfAH1SauM7FAb
         B28w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=xBmdIR6wjqg4mGc+d6ERxxHFFhbZxiDh8aa+zoHO7oo=;
        b=ohDup7zMflYBwPmqhxhVIrctdTi0dZ9RStVQdGHdPi1G2CScY1byXM7GHxMJyB86dl
         /zOtyjJHTwfeI72QuxnzuIK4jGPjDgHxaxiFpOAoiLMuu7p1fZzzt96KHl7MFXq0gMCb
         chFAq8m6s0xkO7i/2K0l/SvDPlRQTAnQ6W4ZfH6Dw253xXXRsD6+WEZVGdc2V9OyTVXQ
         fM5HEWutVLqCHY3IEOWLPqypMqNgMCdXnFzbf1Az9VY9/yPE2AqepanOdErxUxNmVQfB
         ZYHIVHT8SgNdwjsE9Pgdup9RdwaKlnioa+dVlNBRkvTVVMKyxt1jL2cJyqHWa+LaVMTV
         6AMA==
X-Gm-Message-State: AOAM532VlDqgiIhnuk0tkf9u+dTgerPgSXka1Pp2A/UyLri1OBTw7WYs
	5fL++NRM9SMiyNkCsqQ7ucI=
X-Google-Smtp-Source: ABdhPJwwt3vzYd4VTyrQBWRQUNiOJfL7xvPZbEOIyCeEFGC11nnonkE2pnQofyL8spN7j3Vh3ms/FA==
X-Received: by 2002:a05:600c:1e1f:b0:38e:c3eb:2d9 with SMTP id ay31-20020a05600c1e1f00b0038ec3eb02d9mr9307563wmb.90.1650552643773;
        Thu, 21 Apr 2022 07:50:43 -0700 (PDT)
Message-ID: <a638ded8-3bb8-0fad-c97a-8b3d9752310a@gmail.com>
Date: Thu, 21 Apr 2022 15:50:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Reply-To: paul@xen.org
Subject: Re: [PATCH v2 1/2] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
 <6dd6719f-a05d-3f90-95b5-0ce9b5b0a2da@suse.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <6dd6719f-a05d-3f90-95b5-0ce9b5b0a2da@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 21/04/2022 15:26, Jan Beulich wrote:
> There's no good reason to use these when we already have a pci_sbdf_t
> type object available. This extends to the use of PCI_BUS() in
> pci_ecam_map_bus() as well.
> 
> No change to generated code (with gcc11 at least, and I have to admit
> that I didn't expect compilers to necessarily be able to spot the
> optimization potential on the original code).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:55:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:55:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310286.527030 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYCy-000122-Id; Thu, 21 Apr 2022 14:55:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310286.527030; Thu, 21 Apr 2022 14:55:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYCy-00011v-FX; Thu, 21 Apr 2022 14:55:00 +0000
Received: by outflank-mailman (input) for mailman id 310286;
 Thu, 21 Apr 2022 14:54:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BFhx=U7=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1nhYCx-00011p-8z
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:54:59 +0000
Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com
 [2a00:1450:4864:20::42e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0320aba0-c183-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 16:54:58 +0200 (CEST)
Received: by mail-wr1-x42e.google.com with SMTP id c10so7087671wrb.1
 for <xen-devel@lists.xenproject.org>; Thu, 21 Apr 2022 07:54:58 -0700 (PDT)
Received: from [10.7.237.9] (54-240-197-225.amazon.com. [54.240.197.225])
 by smtp.gmail.com with ESMTPSA id
 j16-20020adfff90000000b0020947cf914bsm2407655wrr.31.2022.04.21.07.54.55
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 21 Apr 2022 07:54:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0320aba0-c183-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=jEUURzZf5LICffNomhoozAYCrvZ7XkG9vvU6GCXZWAE=;
        b=BBMvsp+sXTRYkBBgwaw+MBO6pnkp3Ow64Tg7JADsrol6u7F5g9oT++f1O8Y2azfCsn
         aPCLoCwfCgBLjTEnO6HMkAA7dFvuLf2j5MljpkM56BEsKW4g1jxYsOPHY6+ZZmg+3hrU
         zzEfjeOf23Y40jzw3o6zTjwlVd2h+790KyPOtxM1xkI9QvQupoXopBkIta6HxNCacZVs
         CYWp62C73n0Bs/zBNXARXr4b//iE+e3iCzb8Y00ojaNmvvP5Hhuy40hZMQ47fG5li5eX
         I3gn2GwuUFgDVLNQ9yiX7yoZm4t+Rsk9ekKo+pu+rnkEhRXY+5JwgfVOoxiBkkrbuEbt
         uzVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=jEUURzZf5LICffNomhoozAYCrvZ7XkG9vvU6GCXZWAE=;
        b=oheiYujDuu39UVmZP0mPaXS1Uy/QRyyt1Usyn3ga2pfJMbdn1JSumLD+z5rXDLwj7i
         cgNMIW3bkZqK+XMc/BnQkzzg5ljr5OUN4/FddoA6GxA4KHiKKYQBk8T0RyBkUnfNUogQ
         IX/oAeP8NtjryVlGELzcjbxeoJPKtcRYnyjYFRSVKhaHtXsvHwa4VXJMwpnU1bfUteaJ
         0dzApG26SJ/jUVzdpCx36qWsbDSGHPXLt6nTmpHKalfVTdyt0nIndKlyAEyoBxZfQzG/
         Nd28pnajqjqV/zosGrdt3Fh3BOyrkEycLuj950Pusy5aUj5G3dEfIG0WXZk34cMDck7F
         T7dA==
X-Gm-Message-State: AOAM532LHccpz5QCnUGEpDXwDgQSL9qO5w72eOuJr53NbIddxc1uJCac
	vVyA0BysUh0KttPSQloKl4I=
X-Google-Smtp-Source: ABdhPJzgfKHzKvolxC1fVJLRMM038xEe2Gzx3igugklAyiRPGWF4h5gFjNLYEytmETbH4aBWUyqgHg==
X-Received: by 2002:a05:6000:184d:b0:20a:8a22:cbcf with SMTP id c13-20020a056000184d00b0020a8a22cbcfmr111431wri.350.1650552897611;
        Thu, 21 Apr 2022 07:54:57 -0700 (PDT)
Message-ID: <2e3b2575-edae-06df-c579-d6bade1eeddb@gmail.com>
Date: Thu, 21 Apr 2022 15:54:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Reply-To: paul@xen.org
Subject: Re: [PATCH v2 2/2] PCI: replace "secondary" flavors of
 PCI_{DEVFN,BDF,SBDF}()
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
 <609d222f-16db-52c1-1875-0843515a54d7@suse.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <609d222f-16db-52c1-1875-0843515a54d7@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 21/04/2022 15:27, Jan Beulich wrote:
> At their use sites the numeric suffixes are at least odd to read, first
> and foremost for PCI_DEVFN2() where the suffix doesn't even match the
> number of arguments. Make use of count_args() such that a single flavor
> each suffices (leaving aside helper macros, which aren't supposed to be
> used from the outside).
> 
> In parse_ppr_log_entry() take the opportunity and drop two local
> variables and convert an assignment to an initializer.
> 
> In VT-d code fold a number of bus+devfn comparison pairs into a single
> BDF comparison.
> 
> No change to generated code for the vast majority of the adjustments.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 14:57:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 14:57:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310291.527041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYEu-0001dk-UX; Thu, 21 Apr 2022 14:57:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310291.527041; Thu, 21 Apr 2022 14:57:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYEu-0001dd-RR; Thu, 21 Apr 2022 14:57:00 +0000
Received: by outflank-mailman (input) for mailman id 310291;
 Thu, 21 Apr 2022 14:56:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhYEt-0001dX-Du
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 14:56:59 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46bcc082-c183-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 16:56:53 +0200 (CEST)
Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 10:56:53 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN6PR03MB3377.namprd03.prod.outlook.com (2603:10b6:405:3d::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Thu, 21 Apr
 2022 14:56:52 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 14:56:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46bcc082-c183-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650553017;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=WbsfcHuLZf+jTz+4M6GujZ7G+iq+9aFPnAdUHPTJzgw=;
  b=UDkYdXwERoEABwM1pxANqpN1NyXjrOFJqepKgGie9pXaFjbPnWzUzPSj
   M5H81lxIqzZ1bRzyBVcaWwMPgLXinSq+cbstTkbfuhpuqesK2/5ZmvUe2
   iQ4S3Fi/Zz23+EkqGAT92i1dIIgngmtsrX36fntrdO/76J7Lz5OWAUDrC
   Y=;
X-IronPort-RemoteIP: 104.47.59.176
X-IronPort-MID: 69639772
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:zOXOR63pul7P0X5m7/bD5ZJxkn2cJEfYwER7XKvMYLTBsI5bpzMHy
 TAdWWqCOfzZMTf9c9ogPYS1pkMFvpCGzNM2QANupC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy2IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1iiqDgFER4Y5SRheM8XVp2AipGY5xvreqvzXiX6aR/zmXgWl61mbBCKR9zOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82SBfyVu7e03x9p7ixKNezZa
 McDLyJmcTzLYgFVO0dRA5U79AutrieuLWYJ9w3PzUYxy3ri6wZpyLH0C8XYWPiFV/tfxEuah
 W2TqgwVBTlfbrRz0wGt/mq3g+7TnQvyQI8ICKCj7flunUGSwWoIThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYiXN5XH/w/+Ru64KPe6AaEBUAJVjdELtchsaceWjgCx
 lKP2dTzClRHq7aSVW7b+r6KrCiaIjQcN2sLb2kFSmMt4dDlrJsikxHnQdNqEarzhdrwcRnr2
 CyDpiU6g7QVjOYI2r+98FSBhCijzrDLUwo06wP/Tm+jqARja+aNbYGy9ULS6/oGKY+DV0SAp
 1ANgc3Y5+cLZbmPniGQROQGHJmy+u2IdjbbhDZHE5co+Dus/HqiVZtN+zw4L0BsWu4IdjPkb
 1XakR9A759Uen2xZOl4ZJzZNigx5a3pFNCgWvWKaNNLO8J1bFXeo38oYlOM1WfwlkRqibs4J
 ZqQbcerCzAdFLhjyz21Aewa1NfH2xwD+I8afrijpzzP7FZUTCX9pWstWLdWUt0E0Q==
IronPort-HdrOrdr: A9a23:S72yt6poxKMCjo6CiKG9lBcaV5rbeYIsimQD101hICG9Evb0qy
 nOpoV96faQslwssR4b9uxoVJPvfZqYz+8X3WBzB8bHYOCFgguVxehZhOOP/9SjIVydygc078
 xdmsNFebjN5DZB7PoT4GODYqodKNvsytHWuQ8JpU0dMz2DaMtbnnZE4h7wKDwReOHfb6BJbq
 Z14KB81kOdUEVSVOuXLF8fUdPOotXa/aiWHCLvV3YcmXGzZSrD0s+ALySl
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="69639772"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fpYNDA8loocN6V9sXs9GFFoWleQq8ZLvF9nu3mHx+yxNPrK4VW/W9RJ2wveReIvwhxgl0oHUnnDf42LvfjxdOwbI1eawEDsQU6lbe+kxSrdqafQ/15t2kbFaBnsRNptDBgyUX2eRI4XxQ1ooSNTYl1cGlniOG+/T9tbwiwU3tKllARYyveupgVvmoMRJ3s7SHoTVb3VCFUOtOpnZNsN+ECjab5AV68iiNP1We9AeVpy0SETIP/AbVKyQmIOfuD/luU2ev4gecWZ6CNpMFW3h571+G6QWlQWAZGRd+lFovWH9AQNOdeNtn3eBzSllyNp7R+pRW7hFr5Pm4gkXy48jAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u1pxBJommfTjdXLPGqXVOjDmAqIo4pL05sOyBNfBBUA=;
 b=IjxFn5oTKgVIQTMAlwO7HQ3WPwpDHX7v74eFuAkWza3fwJAspiDEkdMegr1r0PAvTAL6Y8Ppp5WzwAiZ4joTWSaL3neQ66/TeapdoBdL7Brw0MploxLLc3tSYjVr/WOWMTRkFfqztETwaCqFujA+AolOmIF1lfYO2UFXxYx7f8Tn2dWiwW3z7nV+1EOxQOV83L72XJU8i+Fxi6e1Y07cju0aliNeoBuc9dLMm3KcZXNNhjMISfP9Lv7QLATisDEiLGRDWme22Q7v6CItxC+YCRlfvc8/JcqfLdUrIParBYhedog6Fwhno84VhPx+9L2MqubwaUVrlPO65sFdTYQlGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u1pxBJommfTjdXLPGqXVOjDmAqIo4pL05sOyBNfBBUA=;
 b=Gkzne/jdDoMflczI/9KePeFi1yKybYl/atwmuPPI7C+vjUkSmcqJCi1IjFafQmFj6qWhZ3eJDVQsDd1upy4622p3z0yVoJWQFJmCTByiKMx67KFbslinoSSDuaI+2mSRVK3ljQJ2/To+HwKzz48dZDvt0yMKYVWTqgbiKtGADE8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 21 Apr 2022 16:56:47 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>, scott.davis@starlab.io, jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v2 1/2] xsm: create idle domain privieged and demote
 after setup
Message-ID: <YmFwr6G1xbpk1sQG@Air-de-Roger>
References: <20220420222834.5478-1-dpsmith@apertussolutions.com>
 <20220420222834.5478-2-dpsmith@apertussolutions.com>
 <YmEpoDHpGP3xkAQ/@Air-de-Roger>
 <0b1b2f7b-dc81-af95-8591-4362ae0b85f9@apertussolutions.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0b1b2f7b-dc81-af95-8591-4362ae0b85f9@apertussolutions.com>
X-ClientProxiedBy: MRXP264CA0042.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 053001dc-2912-4054-916d-08da23a72b4b
X-MS-TrafficTypeDiagnostic: BN6PR03MB3377:EE_
X-Microsoft-Antispam-PRVS:
	<BN6PR03MB3377C86704BEB0AB6A5B3E058FF49@BN6PR03MB3377.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c6M9fQdOg8OOeLkOimTdxUre9qQ+c0g8Ww1rEwF8V7zttbUh7Ae8eZiENZya7bCwB5R1cPPIsckRRCk+pvtAAR7aeLPa+tp96ObhRrBEDxGVXa2F+19QqkyVXx198lErPAtPshxprg+Nj18iOQZl6XkiiLcZiLuaUVc8JiU9X93pgTaOypseonBEncXQxeLNIXZo+e891XXkOlt4xnaO3nVsHUdlXFwZlfp8DqMfJOgP3mZPgf445zMJkBBbKmHuK5RZduyvqehhVzAR1N5RXV8LeMdLGDo/F/Pnhz10TlDGf91FeQr0csaxzPEw9vs63II92///Z9gV4YV3BMq9rTyr1HmYNjr8kyEASFIj1YLLwQCk1qTOwS1XO5P3hMbrLVtTZWYOQBppRySKN3Y26pBH6XEfzTdi8lp0655hCR8EMf3CMun3pnFkB6KIXLbsJOfGFAW3e303kaDR76P+zgHshciFKLJlP92+UFmtBvXSHNOFbiMNGZubdNs9qGFryiB12SKaLrStNZ1R6ZuRiMn2NNKcpnxt9h8nZwskItMtiJSXQjHrlmd7iKUm4bIwgEhm0iQuHnJW1YNEOEWh76iLo4iL5rb7Of7zvZzS+7adGQ59OxPgEKxehqpiOUvMJGbR/ojhbOU3Zl2YWpyrjQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(508600001)(66556008)(6666004)(86362001)(186003)(66476007)(8936002)(316002)(7416002)(8676002)(66946007)(6916009)(54906003)(33716001)(5660300002)(38100700002)(85182001)(2906002)(53546011)(83380400001)(82960400001)(6486002)(4326008)(26005)(6512007)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cmFSd0FKbFhMU01XNm5FMFc3TVVEbTBLQjN5dlV1dU1CakptYUNWTVNaTlB0?=
 =?utf-8?B?T1NSTFRyOUNOS2pNd0tpZHhqMkhZUUZ0RXpaWWxjY05Bd3hkb0JVQWZwbnY5?=
 =?utf-8?B?Q09zbTI1cFg5anRQS3kvamtqblRDMnJ5M01jaUNIbkhVSFhtMXZVN1NlQ0Vs?=
 =?utf-8?B?NEo5ZzIwcmE4cFVsWnNjMVVZRlNKM1ZBamtQclpkMnNrajU2RG0rdCtTRDhq?=
 =?utf-8?B?Um1zaHlnMy9ZRndiLytxQ1FYTzBweWlMRUE1MFRUVmd6cWpJU1k2bEVtK01F?=
 =?utf-8?B?dG96VnhKTlpsU3FyNFdQdjkwdkRnNjBBZ1FrRDhnS1I0TW1sZHQwYVJzZVNX?=
 =?utf-8?B?OWdoL1VnTzdRRm5aUjZ2U3I1cXF1YytWa0RYY2xOMUFoQ1lacjZxdndkMGh6?=
 =?utf-8?B?bUlFSEdjUzhIZFQxN1k5UnNYbzl1M0FpWHFDdFlHMmFXY0FLYWwwT2tiSUtl?=
 =?utf-8?B?YVlyc3QvMThUSFZSQnJ5ZGRRMWRMQzdNV2N5ZW5TaVpCTS9LcGg2KzZwUTlH?=
 =?utf-8?B?WTFhRUEvdkVlQjh3VWpuUEhpbVNadFpyNngrVkxJbTRIQVVEMG50VnI0MVlH?=
 =?utf-8?B?UnRmaXVGMXc1ZitVS2d6dEhFTHdKZnhCZ21ZaWhuaG5lWmxJTnppSWJDRnVS?=
 =?utf-8?B?SXdrTGZhelI1anQwQjhtN2x6OTVyQUtkcVkzcm9pQ1lPc0ZFbFN3WWFrU2lJ?=
 =?utf-8?B?NHBtbC8wYVh5ekhrN0pkTEFMelI2b0ZEazBhaUFhKzdPSC9CQ3prS1R1MDZJ?=
 =?utf-8?B?b2tBMmpHMC9FV3Q5QUZSZ0hlRU44ZUNCWnBSL1ZEZEduSkV0b1QyU0JBZE9H?=
 =?utf-8?B?OHkvSjB6Y0xPSDRlSlJJWEFPL2ttemVqZVFHdmdLeEt3ZE9INmVPOEd5MkFR?=
 =?utf-8?B?OUdEWVRMQ2htTXpZYlpUcWMzN2ZzalJyaTNaaXlQZVhmNEF4Zi9VLzZVeEYv?=
 =?utf-8?B?eHpQVjhCZ2VKMkdHUmwwMTZMQ2FzclVVWi9rNGQ5UHlhbmdROVBIQlY4eGRE?=
 =?utf-8?B?QzYzQ2ZQR3JOa1Y2eVd2K0UwdjRjR3NUenNPYXBUMGZyam1aL291Vnpjbkw5?=
 =?utf-8?B?d1c1QkR1bXhZOUUzUkxtUEdqYjR6NmJNRzh1V1lOQU1ML0lyaTVoZjEyR0xC?=
 =?utf-8?B?dm42V3FYeFlZb010akM5a2UwZ3JmbUFlbVBDQVd0bUg2SnpQRU9XMGNGNDU0?=
 =?utf-8?B?OUFiZ2x4K1ZBc0ZmVXRwODlFWVpuZWJLSFlIRHhBZThrMkxadTI4eGVqNWZZ?=
 =?utf-8?B?VXZLQW8vbmJXbkd1K1ExK0xEODMxVW9aVU9kMVp1QTkyV2hiVDVFeExmZ25G?=
 =?utf-8?B?VUlIUFNZY1NmaDZzbU1TbVZqS0N0S1NnQ1pVcUI0UWFLbHYzNHBaRTZBalN3?=
 =?utf-8?B?ZCtnVWU2dm1xK3YxOEJmNDVpanVNTUx2RUgrdTdKZUlkdlNhR2pqRGZKQkgw?=
 =?utf-8?B?WlZLVnJ4Q0hNcmlOV0VvTVRROWdLV1pFVC9MQ2lOWUFlY0tSV0R3NFNYQWlI?=
 =?utf-8?B?QS9FYTZpcmRFNEozanVRZHNxUFRFYk1BUnpFdzMrYnZ2L01JcFV1QVZKVTlG?=
 =?utf-8?B?SDhYZ2Zyakt1ZDg2T3EvYUs0bnp6K2dnVFpYcWI0WVJLWFY3NUxTQlRWbnh6?=
 =?utf-8?B?bTAzL0lZdnRHOEFnUHQxS1V4akhkN1AzS2FaWktteHlLV0YybFByWVNsSWRq?=
 =?utf-8?B?M0ptYnJpMWgyTEJ0Y056WS9DamM4NE1BcHVUZWQ4UUxXdW5GYTVNOUVUM0x6?=
 =?utf-8?B?UzdlZTZhRjc3NVVDRktqM2FtcTN6bFJsNk9weFU3ay9FL1RCTXFiNW5KNmlv?=
 =?utf-8?B?WkVXSVFOemh5T3JWNGxod1FSQzZnUERmQUxUU1NaalpQYlluUU1zNkt3UWkr?=
 =?utf-8?B?Y3ZaU1EzS25adjR6dDZSc0I4aUhET1JGMUNBQnJ4YzBwRUZUUGUyZHg1cU4w?=
 =?utf-8?B?ZEN3UXpCZXJ1RjZNSlRtMVdYVEpoR2dMT1pTSnpjMjFBb3ZzNUFIMUtUcE92?=
 =?utf-8?B?aVRpUVNNM2J1M290b1pwVHhkczk0enFTOHIvc3d0enZnSG1lUFY5TmRNazZy?=
 =?utf-8?B?OGU1UWgySk4vRWNrNTA3KzFaUXZSWnA0aXVaQklJMHBYUVorTWRsSHZkYVpM?=
 =?utf-8?B?QlQva3FFSVRFUEtyaWEyWjFIMTJkWE9rWWxrR3daZGVQUzlMRWZvN0xWWFI4?=
 =?utf-8?B?b1ZZZWE2M2ZuUW1JUFZ5NCtaQ3pNaWVlU21YdEpjZHF4VTVMQkZUcHdnSDB2?=
 =?utf-8?B?K042YSt2bXZsSm9LaWNBK21kZmJoTG1yRHlhTjJOK1lrVEV6Q3hOdUs5aVNX?=
 =?utf-8?B?MnNHeWozTkkybk5aaGNWaS9PaThVbTlib21FemN3YTBtd1kyR3E4eFJPbHMx?=
 =?utf-8?Q?5mpIVxMDs3yf5rkw=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 053001dc-2912-4054-916d-08da23a72b4b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 14:56:52.0635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ts8vtrykXbMcxn2Ci/KvHxUbDXfTtN4kjnj4LiSpppCfHQbCSgRzJgRil4USuUb20JTEks839Mh2yXga557u2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3377

On Thu, Apr 21, 2022 at 10:14:18AM -0400, Daniel P. Smith wrote:
> On 4/21/22 05:53, Roger Pau Monné wrote:
> > On Wed, Apr 20, 2022 at 06:28:33PM -0400, Daniel P. Smith wrote:
> >> There are now instances where internal hypervisor logic needs to make resource
> >> allocation calls that are protectd by XSM checks. The internal hypervisor logic
> >> is represented a number of system domains which by designed are represented by
> >> non-privileged struct domain instances. To enable these logic blocks to
> >> function correctly but in a controlled manner, this commit changes the idle
> >> domain to be created as a privileged domain under the default policy, which is
> >> inherited by the SILO policy, and demoted before transitioning to running. A
> >> new XSM hook, xsm_transition_running, is introduced to allow each XSM policy
> >> type to demote the idle domain appropriately for that policy type.
> >>
> >> For flask a stub is added to ensure that flask policy system will function
> >> correctly with this patch until flask is extended with support for starting the
> >> idle domain privileged and properly demoting it on the call to
> >> xsm_transtion_running.
> >>
> >> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> >> ---
> >>  xen/arch/arm/setup.c    |  6 ++++++
> >>  xen/arch/x86/setup.c    |  6 ++++++
> >>  xen/common/sched/core.c |  7 ++++++-
> >>  xen/include/xsm/dummy.h | 12 ++++++++++++
> >>  xen/include/xsm/xsm.h   |  6 ++++++
> >>  xen/xsm/dummy.c         |  1 +
> >>  xen/xsm/flask/hooks.c   | 15 +++++++++++++++
> >>  7 files changed, 52 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> >> index d5d0792ed4..763835aeb5 100644
> >> --- a/xen/arch/arm/setup.c
> >> +++ b/xen/arch/arm/setup.c
> >> @@ -1048,6 +1048,12 @@ void __init start_xen(unsigned long boot_phys_offset,
> >>      /* Hide UART from DOM0 if we're using it */
> >>      serial_endboot();
> >>  
> >> +    xsm_transition_running();
> > 
> > Could we put depriv or dipriviledge somewhere here? 'transition' seem to
> > ambiguous IMO (but I'm not a native speaker).
> > 
> > xsm_{depriv,demote}_current();
> 
> Let me say this explanation is not to say no but to give context to the
> concerns. Forms of deprive/demote were considered though when
> considering the concept proposed was to change the security model where
> the hypervisor/idle domain were now explicitly being give a new security
> context, is_privileged and xenboot_t, under which setup is being run.
> This new xsm hook is to provide a transition point for the XSM policies
> to set what the running security context should be for the
> hypervisor/idle domain. The name xsm_transition_running() clearly
> denotes when/where this hook should be used, where as the name
> xsm_depriv_current() is more generic and another developer may attempt
> to use it in a manner it was not intended.

Hm, I see. I (wrongly) originally understood it was related to making
a transition in the running context, rather than the context being
changed to the running state.

Maybe xsm_{transition_,set_,}system_active() to better match the
system_state?

Albeit now that I understand it's purpose it doesn't feel so weird.

> >> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> >> index 19ab678181..22a619e260 100644
> >> --- a/xen/common/sched/core.c
> >> +++ b/xen/common/sched/core.c
> >> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
> >>          sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
> >>      }
> >>  
> >> -    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
> >> +    /*
> >> +     * idle dom is created privileged to ensure unrestricted access during
> >> +     * setup and will be demoted by xsm_transition_running when setup is
> >> +     * complete
> >> +     */
> >> +    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
> >>      BUG_ON(IS_ERR(idle_domain));
> >>      BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
> >>      idle_domain->vcpu = idle_vcpu;
> >> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
> >> index 58afc1d589..b33f0ec672 100644
> >> --- a/xen/include/xsm/dummy.h
> >> +++ b/xen/include/xsm/dummy.h
> >> @@ -101,6 +101,18 @@ static always_inline int xsm_default_action(
> >>      }
> >>  }
> >>  
> >> +static XSM_INLINE void cf_check xsm_transition_running(void)
> >> +{
> >> +    struct domain *d = current->domain;
> >> +
> >> +    if ( d->domain_id != DOMID_IDLE )
> >> +        panic("xsm_transition_running should only be called by idle domain\n");
> > 
> > Could you also add a check that d->is_privileged == true?
> 
> Are you thinking along the lines of,
> 
>     if ( (!d->is_privileged) || (d->domain_id != DOMID_IDLE)
>         panic("some message\n");
> 
> or is your concern more of,
> 
>     if ( !d->is_privileged )
>         return;
> 
> In my mind the former is legitimate because execution should only arrive
> here with current->domain being the idle domain and is_privileged set to
> true.

I was thinking about the former, maybe adding it as a separate
condition so you can print a specific panic message, or joined with
the other if the panic message can be adjusted to fit both conditions.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 15:07:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 15:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310298.527051 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYP7-0003gV-3J; Thu, 21 Apr 2022 15:07:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310298.527051; Thu, 21 Apr 2022 15:07:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYP7-0003gO-09; Thu, 21 Apr 2022 15:07:33 +0000
Received: by outflank-mailman (input) for mailman id 310298;
 Thu, 21 Apr 2022 15:07:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ckMZ=U7=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1nhYP5-0003gE-2b
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 15:07:31 +0000
Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com
 [2607:f8b0:4864:20::536])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c01eb33f-c184-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 17:07:25 +0200 (CEST)
Received: by mail-pg1-x536.google.com with SMTP id t13so4874253pgn.8
 for <xen-devel@lists.xenproject.org>; Thu, 21 Apr 2022 08:07:29 -0700 (PDT)
Received: from [192.168.0.18] ([118.33.58.98])
 by smtp.gmail.com with ESMTPSA id
 z5-20020a17090a398500b001cd4989ff42sm2863344pjb.9.2022.04.21.08.07.26
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 21 Apr 2022 08:07:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c01eb33f-c184-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:to:references:from
         :cc:in-reply-to:content-transfer-encoding;
        bh=GQYR9lJ8zjpdtOiTDeHXoBEngQpEucubUv0M42ZEpO8=;
        b=CvuXxD8pi6iDcudogEmmKvmSj2wPUQbTCKwoWlqLIbByZVlCLQCJRXS6unJk55bmhz
         VjPAHJlqMMkIIabry+rZFhePQhB0PCrYqZPSdYjpF0mDdJQVLHoI9S1HqYdEZ17YvneZ
         E2VW4OpiQ/f2tSP1Gt9cjKEHQmFwDb4DnMDjZBkJgsmoTNx9VpeTJu7U5kNdFt50tWjl
         5ubxLXE3Iz22/LBGsBMJ0zcHMJQL522cMF/ltYSHnUOXOqQC/YP1gCpa3X0pAbbX+P4b
         E7q7eH3DB5vyXjW7Rktp5/m7BewZoTzpDouJCXAsL33Itb6OjY7SqhKT++HWYXDBpFXj
         IZFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :to:references:from:cc:in-reply-to:content-transfer-encoding;
        bh=GQYR9lJ8zjpdtOiTDeHXoBEngQpEucubUv0M42ZEpO8=;
        b=nZOTKaNW7c1quf9or5bNb9w+/hpEiAkGSW0joVnWWJ/h7wvBAPYxvctX7ud1Hokuly
         8+atcez9TzomL1oiMn+NBM/gbUqID0M34CJ5v1HNokpamnMO7b6nC9kp62wJTWL/UdPX
         QCkk4WI9tBzVgEyTlsLFSYW+X7cf5KoZrMEth8E6Qy9YQLbn6UhJJft6dsJOVpdfjTjP
         8dRkFU95uPM6Rk6yNWZFbz0DCARwTZjecZ9alOk/kW7ioM2WDVlxCpHCqqnO3YF1TMwn
         vW7rzukFLV+XQxaaOPmHYaKp42QtzO6JWgIGIoAFwhBfSFIOJJMy33iGYEc9/PphaJOx
         Eb3g==
X-Gm-Message-State: AOAM531LFaicrNuMy+JFqor7k3c62R8n2nEgTAqrcMCEcsr2YS/wDEl/
	+y4CkovtL+2ef57MWXgX6SzL02Nye5loAfci
X-Google-Smtp-Source: ABdhPJwDykSzbtbD2/m7RMdY1NoTrNNdg3OrPer8QT3JFcSPxW6NlU8GFPivKk+NEay8R6W/8Rj70g==
X-Received: by 2002:a63:d347:0:b0:39c:d7d5:77fc with SMTP id u7-20020a63d347000000b0039cd7d577fcmr24236705pgi.201.1650553647832;
        Thu, 21 Apr 2022 08:07:27 -0700 (PDT)
Message-ID: <81517f48-346a-4756-310c-070d5ffd5834@gmail.com>
Date: Fri, 22 Apr 2022 00:07:26 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] xen/arm: silence ambiguous integer casting warning error
To: Julien Grall <julien.grall.oss@gmail.com>
References: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
 <CAJ=z9a37_y3B4aAfiK5C-bHJYyWqCo0+g+jB6cdDCmOzLuXLJw@mail.gmail.com>
 <925421bc-680b-df61-5a75-681d752c4820@gmail.com>
 <b8a0feed-1dde-3b36-646e-1e5413de8395@gmail.com>
 <CAJ=z9a2n0bWEk-7cpOj2q_4fUqetjkQdkgBGYKoQeGeDJ8MxTQ@mail.gmail.com>
From: Paran Lee <p4ranlee@gmail.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
In-Reply-To: <CAJ=z9a2n0bWEk-7cpOj2q_4fUqetjkQdkgBGYKoQeGeDJ8MxTQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi, Julien Grall.

Thank you! After thinking about it, I agree that the patch I suggested
is not a good way to go.

> I don't understand how this is related to adding extra cflags. Can you
> clarify it?

https://www.youtube.com/watch?v=RPgYinVQUgw

I took a short video of debugging through qemu and gdb.
I would like to try doing this with Xen in the same way.

I'm sorry I couldn't explain the debugging process well in writing. It's
not easy. :)

If I could explain the above my video in one sentence,
qemu booting arm64 kernel & gdb remote debugging with debug symbol
information.

BR,
Paran Lee


2022-04-20 오전 2:31에 Julien Grall 이(가) 쓴 글:
> Hi,
> 
> On Tue, 19 Apr 2022, 17:09 Paran Lee, <p4ranlee@gmail.com> wrote:
> 
>> Debugging with GDB from head.S with QEMU runtime was very convenient for
>> analysis(linux). so I have trying it in Xen. As I built it.
>>
> 
> I don't understand how this is related to adding extra cflags. Can you
> clarify it?
> 
> 
>> Wouldn't it be helpful if I fixed the code little by little?
> 
> 
> I am all to make Xen more robust. However, you are now implicitly casting a
> signed int to unsigned int. I am not convinced this is a good move.
> 
> I think it would be better to fix the other side of the equation or
> properly modify the function return.
> 
> Cheers,
> 
> 
>> 2022-04-20 오전 1:31에 Paran Lee 이(가) 쓴 글:
>>> Hi, Julien Grall.
>>>
>>> Thank you for checking it out. I'm sorry I forgot to attach the make log
>>> as well.
>>>
>>> My build configuration (include CFLGAS)
>>>
>>> export ARCH=arm64
>>> export XEN_TARGET_ARCH=arm64
>>> export $(dpkg-architecture -aarm64);
>>> export CROSS_COMPILE=aarch64-linux-gnu-
>>> export CFLAGS="-g -Wall -Wextra -Wno-unused-parameter"
>>>
>>> And i did     make dist-xen
>>>
>>> my arm64 compiler information are here.
>>> gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
>>>
>>> ~/xen$ aarch64-linux-gnu-gcc -v
>>> Using built-in specs.
>>> COLLECT_GCC=aarch64-linux-gnu-gcc
>>> COLLECT_LTO_WRAPPER=/usr/lib/gcc-cross/aarch64-linux-gnu/9/lto-wrapper
>>> Target: aarch64-linux-gnu
>>> Configured with: ../src/configure -v --with-pkgversion='Ubuntu
>>> 9.4.0-1ubuntu1~20.04.1'
>>> --with-bugurl=file:///usr/share/doc/gcc-9/README.Bugs
>>> --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,gm2 --prefix=/usr
>>> --with-gcc-major-version-only --program-suffix=-9 --enable-shared
>>> --enable-linker-build-id --libexecdir=/usr/lib
>>> --without-included-gettext --enable-threads=posix --libdir=/usr/lib
>>> --enable-nls --with-sysroot=/ --enable-clocale=gnu
>>> --enable-libstdcxx-debug --enable-libstdcxx-time=yes
>>> --with-default-libstdcxx-abi=new --enable-gnu-unique-object
>>> --disable-libquadmath --disable-libquadmath-support --enable-plugin
>>> --enable-default-pie --with-system-zlib --without-target-system-zlib
>>> --enable-libpth-m2 --enable-multiarch --enable-fix-cortex-a53-843419
>>> --disable-werror --enable-checking=release --build=x86_64-linux-gnu
>>> --host=x86_64-linux-gnu --target=aarch64-linux-gnu
>>> --program-prefix=aarch64-linux-gnu-
>>> --includedir=/usr/aarch64-linux-gnu/include
>>> Thread model: posix
>>> gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
>>>
>>> In arch/arm/gic-v3.c files.
>>>
>>> arch/arm/gic-v3.c: In function ‘gicv3_compute_target_list’:
>>> arch/arm/gic-v3.c:926:17: error: comparison of integer expressions of
>>> different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>>>   926 |     while ( cpu < nr_cpu_ids )
>>>       |                 ^
>>> arch/arm/gic-v3.c:936:18: error: comparison of integer expressions of
>>> different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>>>   936 |         if ( cpu == nr_cpu_ids )
>>>       |                  ^~                           ^
>>>
>>> In arch/arm/setup.c files.
>>>
>>> arch/arm/setup.c: In function ‘start_xen’:
>>> ./include/xen/cpumask.h:374:13: error: comparison of integer expressions
>>> of different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>>>   374 |       (cpu) < nr_cpu_ids;  \
>>>       |             ^
>>> ./include/xen/cpumask.h:459:36: note: in expansion of macro
>> ‘for_each_cpu’
>>>   459 | #define for_each_present_cpu(cpu)  for_each_cpu(cpu,
>>> &cpu_present_map)
>>>       |                                    ^~~~~~~~~~~~
>>> arch/arm/setup.c:989:5: note: in expansion of macro
>> ‘for_each_present_cpu’
>>>   989 |     for_each_present_cpu ( i )
>>>       |     ^~~~~~~~~~~~~~~~~~~~             ^
>>>
>>> Thank you!
>>>
>>> 2022-04-20 오전 12:50에 Julien Grall 이(가) 쓴 글:
>>>> Hi,
>>>>
>>>> On Tue, 19 Apr 2022, 15:41 Paran Lee, <p4ranlee@gmail.com> wrote:
>>>>
>>>>> GCC with "-g -Wall -Wextra" option throws warning message as below:
>>>>
>>>>
>>>> Which version of the compiler? Also you specify the exact cflags, did
>> you
>>>> tweak Xen?
>>>>
>>>>
>>>>> error: comparison of integer expressions of different signedness:
>>>>>  ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>>>>>
>>>>
>>>> GCC should give you a line/file. Can you provide it?
>>>>
>>>> Cheers,
>>>>
>>>>
>>>>> Silence the warning by correcting the integer type.
>>>>>
>>>>> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
>>>>> ---
>>>>>  xen/arch/arm/gic-v3.c | 5 +++--
>>>>>  xen/arch/arm/setup.c  | 2 +-
>>>>>  2 files changed, 4 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>>>>> index 3c472ed768..81ac25f528 100644
>>>>> --- a/xen/arch/arm/gic-v3.c
>>>>> +++ b/xen/arch/arm/gic-v3.c
>>>>> @@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)
>>>>>      isb();
>>>>>  }
>>>>>
>>>>> -static u16 gicv3_compute_target_list(int *base_cpu, const struct
>> cpumask
>>>>> *mask,
>>>>> +static u16 gicv3_compute_target_list(unsigned int *base_cpu,
>>>>> +                                     const struct cpumask *mask,
>>>>>                                       uint64_t cluster_id)
>>>>>  {
>>>>>      int cpu = *base_cpu;
>>>>> @@ -953,7 +954,7 @@ out:
>>>>>
>>>>>  static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t
>>>>> *cpumask)
>>>>>  {
>>>>> -    int cpu = 0;
>>>>> +    unsigned int cpu = 0;
>>>>>      uint64_t val;
>>>>>
>>>>>      for_each_cpu(cpu, cpumask)
>>>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>>>>> index d5d0792ed4..5ab2aaecaf 100644
>>>>> --- a/xen/arch/arm/setup.c
>>>>> +++ b/xen/arch/arm/setup.c
>>>>> @@ -862,7 +862,7 @@ void __init start_xen(unsigned long
>> boot_phys_offset,
>>>>>                        unsigned long fdt_paddr)
>>>>>  {
>>>>>      size_t fdt_size;
>>>>> -    int cpus, i;
>>>>> +    unsigned int cpus, i;
>>>>>      const char *cmdline;
>>>>>      struct bootmodule *xen_bootmodule;
>>>>>      struct domain *d;
>>>>> --
>>>>> 2.25.1
>>>>>
>>>>>
>>>>
>>
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 15:18:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 15:18:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310303.527063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYZE-0005dp-1W; Thu, 21 Apr 2022 15:18:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310303.527063; Thu, 21 Apr 2022 15:18:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYZD-0005di-UA; Thu, 21 Apr 2022 15:17:59 +0000
Received: by outflank-mailman (input) for mailman id 310303;
 Thu, 21 Apr 2022 15:17:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ckMZ=U7=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1nhYZD-0005dc-4h
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 15:17:59 +0000
Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com
 [2607:f8b0:4864:20::431])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 39469e3c-c186-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 17:17:58 +0200 (CEST)
Received: by mail-pf1-x431.google.com with SMTP id l127so5298590pfl.6
 for <xen-devel@lists.xenproject.org>; Thu, 21 Apr 2022 08:17:58 -0700 (PDT)
Received: from localhost ([118.33.58.98]) by smtp.gmail.com with ESMTPSA id
 p4-20020a637404000000b00375948e63d6sm22914548pgc.91.2022.04.21.08.17.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Apr 2022 08:17:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39469e3c-c186-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition;
        bh=HwkPi7EESKLMHvB+8DbibUoGGrCc2TxwDdNOywmo7kg=;
        b=hK4FvLb45aaO/zXcX3H8e0CpOAQEFa9TXmt9bhMJLAXLaCeN7+3hwazClNZxzxmJyb
         jS1kx7TGn0WAYKme1U/l9ZdibGl2D20g5XMU5aJsz0opMoZectMCnpwcDa5uZrRpRTBV
         Q46+dtrgsXwKbAunlvcDXq+4l+OTRn8bmUQ5p4p0EnswcZfzXtz0uiUHrRK8LkyYiJ9X
         f1TyYn4ojuLoEb+vw743s0ET6fopOzBodWVaNsTSrROhb1Yr+jGjHP3XERZNYj9jldBl
         hB8LWcwb3G9Q56GWseTY2JfLw5ENajJbYCs8E3GRwbb2Q9ZGXnzRxYeOk7jzMFX9pEir
         U9lA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition;
        bh=HwkPi7EESKLMHvB+8DbibUoGGrCc2TxwDdNOywmo7kg=;
        b=iVtEUNvlSS+PncIduoltsjbVZzi8CQpmnPU1k3Rey+QM5MihMTw5Uab+laQsK1d3ZQ
         JHP2ojgQ5ggzxV7t3t9Q8Z8ktD2S8rt7SRgo6dxVGZoUazC0D055QbZWsGCaIo52NfP+
         REM8tsNpLfdM/d6fbLERXj18ADZtk2plO3okut55tFZNwMWUoks0TsqsMhSRGWIdsJt4
         TsSZZGzPO8j5uFp0c97ho61KFciidp2aExp/ZKu7Zv3qCZLtrGwvWFF7cqhWYwVi0nXN
         eLJBSRZM78EFXlir31eE4uUhT/mFflEO/MpWclsfZVnmJsjBTfFvy3f9UWy942wbvHSo
         Q9KA==
X-Gm-Message-State: AOAM530afZNU8/PdWaJqF1EWhgSTq4EOTkUbTjz+e1ty48oaZ3YXCAuC
	l2W0NBYjYi1BcXbqThEDwEk=
X-Google-Smtp-Source: ABdhPJwsJBv7j6lm1zv+MhgWjiFUztQlpbffeBU4x6GSZ0YG80tXvyuhOJkOwl+F5dh+CIM9G3CG2A==
X-Received: by 2002:a65:638d:0:b0:39d:74ad:ce0b with SMTP id h13-20020a65638d000000b0039d74adce0bmr24761836pgv.103.1650554276683;
        Thu, 21 Apr 2022 08:17:56 -0700 (PDT)
Date: Fri, 22 Apr 2022 00:17:55 +0900
From: Paran Lee <p4ranlee@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: austindh.kim@gmail.com, xen-devel@lists.xenproject.org
Subject: [PATCH] xen/arm: p2m_set_entry duplicate calculation.
Message-ID: <20220421151755.GA4718@DESKTOP-NK4TH6S.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

It doesn't seem necessary to do that calculation of order shift again.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 xen/arch/arm/p2m.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 1d1059f7d2..533afc830a 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1092,7 +1092,7 @@ int p2m_set_entry(struct p2m_domain *p2m,
     while ( nr )
     {
         unsigned long mask;
-        unsigned long order;
+        unsigned long order, pages;
 
         /*
          * Don't take into account the MFN when removing mapping (i.e
@@ -1118,11 +1118,12 @@ int p2m_set_entry(struct p2m_domain *p2m,
         if ( rc )
             break;
 
-        sgfn = gfn_add(sgfn, (1 << order));
+        pages = 1 << order;
+        sgfn = gfn_add(sgfn, pages);
         if ( !mfn_eq(smfn, INVALID_MFN) )
-           smfn = mfn_add(smfn, (1 << order));
+           smfn = mfn_add(smfn, pages);
 
-        nr -= (1 << order);
+        nr -= pages;
     }
 
     return rc;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 15:21:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 15:21:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310308.527073 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYcY-00070z-GA; Thu, 21 Apr 2022 15:21:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310308.527073; Thu, 21 Apr 2022 15:21:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYcY-00070s-DC; Thu, 21 Apr 2022 15:21:26 +0000
Received: by outflank-mailman (input) for mailman id 310308;
 Thu, 21 Apr 2022 15:21:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/1dP=U7=citrix.com=prvs=1038dedf8=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhYcX-00070m-0j
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 15:21:25 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b20daeff-c186-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 17:21:22 +0200 (CEST)
Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 11:21:18 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN7PR03MB3619.namprd03.prod.outlook.com (2603:10b6:406:c5::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 15:21:17 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 15:21:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b20daeff-c186-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650554482;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=QZP8CMeFNR2okUu3n8U8k6wfrB/P6Lr1nHW2MRDT3pM=;
  b=VgQ7k2mMl4rkuoeKFlHttbDcdlB9WtcpQ+g4HLgTtJcXXigQsxqiXbsk
   sEc+Da2bBQcJNmyXveRKilp/ZbDhEawhl8HxULNrK7EfFXZ4VG9ZkiFVb
   Agn/E9CtO/ED2e80pPHURCO+2byWi+1fJAMA1EbJAuseLt0/0OFVULIks
   0=;
X-IronPort-RemoteIP: 104.47.59.177
X-IronPort-MID: 69500781
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:wQG2DKxD2eFd46H+IrV6t+dDxyrEfRIJ4+MujC+fZmUNrF6WrkVTm
 GUYXW7XaPjfM2XyLtB3bY/j/RkA78eHnIUxTQU+/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024HhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplsZCuYActD5f1mro0Th9dHSJFYZJo5+qSSZS/mZT7I0zuVVLJmq8rIGRoeIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeEuOTuoAwMDQY36iiGd7EY
 MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GhImAA8A3F/MLb5UDNlw1e876wN+bbWdehYO9+gRyJj
 WzJqjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWMwkQDBRtQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO+gz6QXIxq+K5Q+cXzIAVmQYN4Ngs9IqTzs30
 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZo8L/HKd5jEtJQzN/
 g==
IronPort-HdrOrdr: A9a23:pddejKxNorx11S2OH1l2KrPxsOskLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICOgqTM6ftWzd1FdAQ7sD0WKP+UyCJ8S6zJ8n6U
 4CSdkDNDSTNykcsS+S2mDRfbcdKZu8gcaVbI/lvgpQpGpRGsVdBmlCe2Sm+hocfng9OXN1Lu
 vr2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnR4j4uFxd0hZsy+2
 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUpZ5Sy+BQO5M2/4lcjl9
 fB5z8mIsRI8nvUOlq4pBP8sjOQpQoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L
 gj5RPUi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZMIMvD0vFoLA
 BSNrCc2B4PGmnqL0wx/1MfiuBEZ05DUStvGSM5y4+oOzs/pgEK86JX/r1cop46zuNCd3B13Z
 W6Dk1WrsA+ciY3V9MIOA5Te7rBNoTyKSi8QF66EBDAKJwtHU7rhtre3IgVjdvaC6DgiqFC06
 j8bA==
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="69500781"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XLjJHgE1YuY6acaD8A96pn8xpjO5/jEBgENhIOYbwUC/7krVKTmANOF4OAj69YaZQBn1QYB7dUt0jql0fKsiBQTxRoyg24vegmnBYcROHxMLJxuWc5aQ51SfFqx3oVDSacVs8yOqMmkOu9wuUZcamofymuF1JZmcKOjCmQTtRL3iOPa4s/FSIEMB3QmA2yLs6DS23BylG+wIiVp3vSRXooC1Mu++cSAEi9+pTkYr7ygvkJTfmf7mgzbSUKo0N/T0fPrN09Xz2/zRKw+OsNAH1ck5+pJqsB/wnWfdYv26JstBPz8lYdBM1XWPhP6dQPn0GHnEaMxdJYWj5Ywfx956rQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jMb8Ui/b+yY6q4PujdGxSBB6QMxryIVTYwXsh5AqGAo=;
 b=LL15BJjH3oeKRTxrJPAD0Zlf8/KS0Vt4IdRmzuDtrXx958Dlrcjyt9Wjn+yRqzTbSD0OKwbBu8/P7ZKFMrfkwqfhOmuwSfu3jbZJEcKQcqALhf61xEli+TomBGr0YNyJmC3u8al1d3fzsYHx3DLguBvJTjX2PW1agoe+fi5JiG2ijtHpr+zMZZmfSGDhOGOJOk2VNaGfw39bQu8pHY2XRGPzernlMDFGGBcBTTXTmb4g5ewLg8hXk/bG+88RtRXMbz16Q2aETl795L5jSav3Fxallbxm7tWPwviy0bW2WWSB11rhXrV6We7endWKU+fcTE+kehYRZflEgV0luGwEnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jMb8Ui/b+yY6q4PujdGxSBB6QMxryIVTYwXsh5AqGAo=;
 b=YnaK4YOP164i0pkgRWqu+btOh4h5v/iIS6YnROTMKBXowCwUWBuE1XVSIRvr6QgMGoxvx5nVAWaAL8fhA2+bRrTjTYUH9zT8XZes7Qu+/d33MXuHOENl/EF1MTd2umLNUUfm5ZtxcV7+wd46RluSKW6yP9pI8zGdillUdTUfEfw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 21 Apr 2022 17:21:11 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Message-ID: <YmF2Zw13O6oaAT0k@Air-de-Roger>
References: <20220331092717.9023-1-roger.pau@citrix.com>
 <20220331092717.9023-4-roger.pau@citrix.com>
 <0bb48681-a78f-d32e-f989-822dd5e54b70@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0bb48681-a78f-d32e-f989-822dd5e54b70@suse.com>
X-ClientProxiedBy: PR3P195CA0029.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:102:b6::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 01f2bae7-175b-4ad7-341f-08da23aa948d
X-MS-TrafficTypeDiagnostic: BN7PR03MB3619:EE_
X-Microsoft-Antispam-PRVS:
	<BN7PR03MB36194323EF060385B52FCAAD8FF49@BN7PR03MB3619.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DVpCNV6+iOqsUGrlWmeKsT2wyN99KRMZKuKKXIcRQoawSxlMGfQ/NQuN53hljCkV4x7Zy4peKZsPPTmWdjpvF3e3RaiJ874Iufgbs3ObGqcKQr5cgS5v9mmyPfsN2FVYKcwja5EWpOv/HJn6Vv8kN3BDppledHhpRvGnmMfqK38mozzP1rXFX/ovC/8ODP3PYmleyb+KtIwnnTd4MRCI4tCKyl6G2etkso5InCV5YpOGrkHcOPC0vXg1kVGmN7K80iv2a1VuzQHWtHmaXNEDw2ZaNDOIC2zFl4ttxwcHxcPOhUgSuuSIKjPxfXIbnTnx6sx4AZTDoIQXmecAKACTiAWLNIWLUGfKq3yWo7VJLng3SzG1HYaBBSplu9PCh2XVVsFZRqYhUkeMxEqnVaMcizyc4vM9dTbM5B0quz7p7B4YIqIYzKN9Kf5KKzbf6D8zzZmnOsODPlbUujEd82leastj2ae6iHk0/bRR5jrtXKEZxnmySBbLXlfz1SyJ9xLHKlfdeSOXIMJ4iRw/rDe46Kaq91hh41973GVhm9hdx280qj38H/VPNjQk9tHBv/0ajGI0bBt0DSko7cTMWAnatOGVpBcq6kASog5DCFHdGWYAdfF615MoWH3a9h5bdcnMrCDDsRE7LlDrY5FTB1l+Zw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(53546011)(186003)(2906002)(6506007)(26005)(83380400001)(9686003)(6512007)(33716001)(5660300002)(86362001)(316002)(8676002)(85182001)(38100700002)(6916009)(4326008)(66946007)(6486002)(66476007)(508600001)(6666004)(66556008)(8936002)(54906003)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eklvZ2QwbitWSFU4Wk4wajBmYzBzbW9tVVV6TVgrK0g5UzhKZXRlUVhLcVVo?=
 =?utf-8?B?ZVBsMUt0UDZEcVV0Zm5CMTlpRFdMakc2R3FCT2h5OTI5Rm1nY21MZ3hwTmw1?=
 =?utf-8?B?YUZNR1lRcFJsdngxamxlNmNWUTRvZ3hEVmk5OUZmVjVKZHRiMzB2YXk2enRU?=
 =?utf-8?B?QU05a2VCSWdUK2VLM2hyNC9idVdUdGgxUHE4cUtmLy9rM2JwWGI1RHhtSjdK?=
 =?utf-8?B?WEpQSk5SZnF3bWdTQVZnUmtpenZCNFB1ckhycUJ5SFkxLzF6V1lFcXpmenFz?=
 =?utf-8?B?MytoRzdWeW1vUkhqSmk0cm02emF4aFNIckZ3NUJPT2NuTE5YTkg2aFdRaHYw?=
 =?utf-8?B?ZFV1dlZmVXd4WmtJY3haQmU3L2MvMlIwZ2laWG45bHBkSUFkMzFDUDFWZGFV?=
 =?utf-8?B?SGdubktNbDJtbERseGFPak4zRk5OY29vTE96NklzWmJzelAweTVPd2xrQmlR?=
 =?utf-8?B?ZVlLQlZ1bmR2NlMvWFJlNVpzZnVlOUxpMVN5VGFjeHZrU2RsWFE2dnFDbTEr?=
 =?utf-8?B?RFVoNS9vWnExelA5QjRTTE1rU01QSDYwVTBOemhyNzg1ZmtJdW5mc0lZbUkr?=
 =?utf-8?B?NmxzSGJneEFibE1lYks4MTZxSXJCQmpqaE5KazlzelJFWW9ENFcwcFZQWmRF?=
 =?utf-8?B?N05rL1NEWTFZd3g2dUVSR2dOdVU5ZE5tVW9Lekp1SnhMYkNNZitaZXQ0YnR1?=
 =?utf-8?B?SHZOVWw4eE9Rb3M2WTdDV0dnZGRSdDRxc1dqY1pvaFNFbTdhZHNSM2hrdVRs?=
 =?utf-8?B?aDVndVQyQVgvTnBTTDlJbjRBd0RGclFjN1NLTjV0MkI4cHMvREdaWWZweTJ2?=
 =?utf-8?B?VGx5a25yL0R4aEJyM2hCT3NuTU5wWFlXQ3Jramdmdk5JNmNZU2dHK2UvTWFp?=
 =?utf-8?B?SWtOR1VlbWRaWm9NaHVrcldJNkh3enRNYmM3TURNU1FZZzhoZmprVG80NGFC?=
 =?utf-8?B?d3dMR21DM2NjK0xtKzNEa0o4ZDJYSitIRUd4SU9YeDd0MFRESk5OK0c4M2t6?=
 =?utf-8?B?dTdLbFhHMVlrb3BKRjVSVUk2Vldxb0JjOWVvT1RkQStzaTZKcjJwa1FOak1V?=
 =?utf-8?B?dkpQRTg1NUtvVTFwWmJ3dXMxMGUzZy93UktPeWYvMkRScjE5YmplL2tjMjRT?=
 =?utf-8?B?ei8wcnVoZVlvd0kyTnZ1M0M2VTZ4bWl1RE1uMVAyZHp5ZSs0Z2R2RlRRQlRz?=
 =?utf-8?B?QUl1M2VzRTgxeE5sY05iVXhQcmFSeHdPL08vcnRPQjZ2bU16ZGRubWZZSmRr?=
 =?utf-8?B?b1pVdGFqNnd4RE5iOUsvRlhvQlBISE9tb2tHWjZucno1ZHJZaHZrS1BQV1oy?=
 =?utf-8?B?SXQ1L2NpT1AwQjlnNTIva2gxc3dYSEU2Vk1tM01ycHE0dXlsK2dta0prSjNy?=
 =?utf-8?B?clppV0IrQlhPOVdVNDZCQnZTWFBiNEVOczV1RnBtdjh3N1c1ZFViU1F1aUpw?=
 =?utf-8?B?ejVza1pRVlkvbDdOTSsxYi8vRWM5WHo2TWNWeW5SVDlsblVSd0gwM0VzS1Zp?=
 =?utf-8?B?SlNYME1RaWhFb1NBNFJUU1I0NUx0VldUaUNYV1J5akc5bW8vUzBzOTNDUHd2?=
 =?utf-8?B?Q3FUY2lGdXNYRlhQYUEyUlBHM0ZRdkdhSTVWMkQvZFBzcDZXT214cHhoZVFP?=
 =?utf-8?B?U0VZSnl5b0pSc3VPMU5BNVliQUdoOWRNWFE4S2pQcCtiRG15TnJaVFBma040?=
 =?utf-8?B?Q0o1WUJCWGVZdU5vNlJWOEE1TFJrN0Z3QmVWN3k3S2lhZXlmTHRQV1JBdjQ5?=
 =?utf-8?B?dDFCcUJRUDFsUmVST3dYZzdjME5lTkZtN2oweFBZSk5Gd2Vqb3V3RDBKdUtk?=
 =?utf-8?B?d21keVZqUTJmWlQvZmFDZ2ZVVTJsczRNcVJpNUhQOUo4NnZDV2x6WjBkMG0x?=
 =?utf-8?B?L3dmM3VCY2VXdnc1ZE5YS1VsVDFCZ0h1N1hDak9wYU45elJMR1NPM1pZZ1FG?=
 =?utf-8?B?Q2VmTkR3N3ZISmtVS055QkpwaDh6eEQwSUgyMkE0Q1M4WDZvbnlTMEQ3ck5v?=
 =?utf-8?B?R1dtd2U0TFhvSlpXemtDQjVGTjZqN3luakpkbmtTK05wdzg4dVRBOVZ2QnRa?=
 =?utf-8?B?V0pCKzRTNU05cWNMcU1CaXVYZVVkRW5ZL3pzblBHalRVcDhpR2k5SzdoeTFE?=
 =?utf-8?B?b2k5ZHRFdmJQZklQQ0xwTnVjb2Q3RlNhZEMyN1p0WnM0K3I1QzgrSFJ5Snp2?=
 =?utf-8?B?UjB2eTFEMnV0MXRKQUwwd3JCZWlLMSt5Tm9ML3BONDhDKzJNTVZBamlzWDdL?=
 =?utf-8?B?Z3cwNDJrY09YWVlsa3VaaHhKSHZjQmpyZTZiOXR2U1RhSnNUaUw3QTkwZEV0?=
 =?utf-8?B?ZC80RjJaSWdpU2pNSnV4SHJoZUN1dndxRnU5TTFOSEhrbFhwZEk1Sm1jOHNX?=
 =?utf-8?Q?jE3it0bBoKGdQIHs=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01f2bae7-175b-4ad7-341f-08da23aa948d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 15:21:17.1759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5f6myKxipaUVQK244elfBwfkYjzu09HRktoMFYQvxTkfr3V+4xSlrJ3scEEtC+cof4tfSSGe+rkgVhh6uG30xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3619

On Thu, Apr 21, 2022 at 11:50:16AM +0200, Jan Beulich wrote:
> On 31.03.2022 11:27, Roger Pau Monne wrote:
> > Expose VIRT_SSBD to guests if the hardware supports setting SSBD in
> > the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU
> > families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD
> > allows for an unified way of exposing SSBD support to guests on AMD
> > hardware that's compatible migration wise, regardless of what
> > underlying mechanism is used to set SSBD.
> > 
> > Note that on AMD Family 17h (Zen 1) the value of SSBD in LS_CFG is
> > shared between threads on the same core, so there's extra logic in
> > order to synchronize the value and have SSBD set as long as one of the
> > threads in the core requires it to be set. Such logic also requires
> > extra storage for each thread state, which is allocated at
> > initialization time.
> 
> So where exactly is the boundary? If I'm not mistaken Zen2 is also
> Fam17 (and only Zen3 is Fam19), yet here and elsewhere you look to
> take Zen1 == Fam17.

Right, but Zen2 already has AMD_SSBD (ie: SPEC_CTRL), so it's not
using this logic.

The AMD whitepaper is more clear about this: any Fam17h processor that
is using the non-architectural MSRs to set SSBD and has more than 1
logical processor for each logical core must synchronize the setting
of SSBD.

I think just dropping the mention of Zen 1 in the commit message
should remove your concerns?

> Just one further nit on the code:
> 
> > +static struct ssbd_core {
> > +    spinlock_t lock;
> > +    unsigned int count;
> > +} *ssbd_core;
> > +static unsigned int __ro_after_init ssbd_max_cores;
> > +#define AMD_ZEN1_MAX_SOCKETS 2
> 
> This #define looks to render ...
> 
> > +bool __init amd_setup_legacy_ssbd(void)
> > +{
> > +	unsigned int i;
> > +
> > +	if (boot_cpu_data.x86 != 0x17 || boot_cpu_data.x86_num_siblings <= 1)
> > +		return true;
> > +
> > +	/*
> > +	 * One could be forgiven for thinking that c->x86_max_cores is the
> > +	 * correct value to use here.
> > +	 *
> > +	 * However, that value is derived from the current configuration, and
> > +	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
> > +	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
> > +	 */
> > +	if (boot_cpu_data.extended_cpuid_level >= 0x80000008) {
> > +		ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
> > +		ssbd_max_cores /= boot_cpu_data.x86_num_siblings;
> > +	}
> > +	if (!ssbd_max_cores)
> > +		return false;
> > +
> > +	/* Max is two sockets for Fam17h hardware. */
> > +	ssbd_core = xzalloc_array(struct ssbd_core,
> > +	                          ssbd_max_cores * AMD_ZEN1_MAX_SOCKETS);
> 
> ... largely redundant the comment here; if anywhere I think the comment
> would want to go next to the #define.

I guess I should also rename the define to FAM17H instead of ZEN1, as
all Fam17h is limited to two sockets, then the comment can be removed
as I think the define is self-explanatory.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 15:27:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 15:27:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310315.527085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYhy-00082k-8J; Thu, 21 Apr 2022 15:27:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310315.527085; Thu, 21 Apr 2022 15:27:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYhy-00082d-5M; Thu, 21 Apr 2022 15:27:02 +0000
Received: by outflank-mailman (input) for mailman id 310315;
 Thu, 21 Apr 2022 15:27:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhYhw-00082T-CE; Thu, 21 Apr 2022 15:27:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhYhw-00043i-9J; Thu, 21 Apr 2022 15:27:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhYhv-0003H8-Ry; Thu, 21 Apr 2022 15:26:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhYhv-0001yz-RX; Thu, 21 Apr 2022 15:26:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WaQ0K4fki5kobT25M0tRBu2EIYSW6USsJQHfWtmItqE=; b=PvgMZ4T6aI5DmBFfnEw3D9vexR
	r8neGAbMj7158aH6ez5VyMh0GwsDt7N4qtkeJkjHSmbIxPCkOZkjm8Ev9tp42NBCBxUMR25ZrNDUy
	bYH9p0Wf83FXBUOkMLyp/YWuG+IccwPvgDogqJASFp18sVxrK37d7aXX2WHDcwhU2rB4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169584-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169584: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=9c125d17e9402c232c46610802e5931b3639d77b
X-Osstest-Versions-That:
    qemuu=2d20a57453f6a206938cbbf77bed0b378c806c1f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 15:26:59 +0000

flight 169584 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169584/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169573
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169573
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169573
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169573
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169573
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169573
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169573
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169573
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                9c125d17e9402c232c46610802e5931b3639d77b
baseline version:
 qemuu                2d20a57453f6a206938cbbf77bed0b378c806c1f

Last test of basis   169573  2022-04-20 20:38:13 Z    0 days
Testing same since   169584  2022-04-21 06:18:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   2d20a57453..9c125d17e9  9c125d17e9402c232c46610802e5931b3639d77b -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 15:27:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 15:27:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310320.527096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYiN-0008W6-IW; Thu, 21 Apr 2022 15:27:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310320.527096; Thu, 21 Apr 2022 15:27:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYiN-0008Vx-F1; Thu, 21 Apr 2022 15:27:27 +0000
Received: by outflank-mailman (input) for mailman id 310320;
 Thu, 21 Apr 2022 15:27:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhYiL-0008NL-Nt
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 15:27:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b40db7f-c187-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 17:27:24 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-piUo11GlMqmKW5UDfZ4oRQ-2; Thu, 21 Apr 2022 17:27:22 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR0402MB3875.eurprd04.prod.outlook.com (2603:10a6:208:9::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 15:27:20 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 15:27:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b40db7f-c187-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650554844;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=copdA8uvOE43E5lPgCqr3yQRhyGX6TzQLV52e+UNrss=;
	b=hWCks8M9P2ZAXLs+mskFXT7uXRYUsi/TnNKOdwhok4b9sKv1N3UW1HZX5nDzv7UDfGcvLD
	1o1hPXy+hwWdM01D6LbDBQrCDxFuCZmEE8Cs4DoxMg8PovNaeoWZN5GqF5hZZPOROUXRgy
	bPRPJfOQV1kF0cbKFi6uZf1zT0C3T2g=
X-MC-Unique: piUo11GlMqmKW5UDfZ4oRQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DAI+kh2DcfFnWd1BkkDOdcjWwYy/N/RkZpsoZwIBm4gqcakUY3rsSy5PCpcpwBr3eYuDwgFK4pAqqZObEs1tWcPvspORZpoFgPARucT6grPkLf4H2EKPpzMyiMGnl1V7fRd/wju3l+iJ+mDQxg3q6eCViLE+3FTHeAjkgrIodBTllqXgVK6im4/bbMTdwvkdw34N6cN5VfQRAwmAHT1OwNONVt3wETv/rQT77q0Z6uMQGLSEbRh0To6PemeHq/T2CbVgIHz2C7Ri4OZDJoeNTBZfWbjNXEAFeudzpnc4cL+g1cDaH11nt5U3lOBsSytqBkj1ERiS5oakqvSzq7+CWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HgdXwCqaJbPWuWtnR11tCjs4kwvUL8Uz0zSvosnP2DM=;
 b=ga6itI8Ul+ZM9QqSTu2i6HwePZ1A2lqrcA741xU5sPnZwoUSOI9Qnr0OeRV6soXPgJktxGTJxmnOcmeWemHNAHcPHFx7iVnh3eXmARpGk+EIzFPlZhOgEfBdreSHYzBgxrSIe1+75cXmzGvN+Pypw/cH09ocKnexAahYLxhu2duHVdEJ3laqXhWIXW+SCcsCtW3+U+1nLAV6bssFm0Eqm5QiKTIBq8RI59/+bOptoFhrbCsr5ddr8Iie1W38ILPpapH8HoQ+sHYU6fWQrIKwvxCvhWJ7wVTVklHNBSUocnj52eDNbWTnnhrEUHVULWzorxKabKD+hN0TK4pbmUqiJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b7e3ecbe-6c2e-94f9-58c6-ae49652e6a29@suse.com>
Date: Thu, 21 Apr 2022 17:27:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220331092717.9023-1-roger.pau@citrix.com>
 <20220331092717.9023-4-roger.pau@citrix.com>
 <0bb48681-a78f-d32e-f989-822dd5e54b70@suse.com>
 <YmF2Zw13O6oaAT0k@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmF2Zw13O6oaAT0k@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0070.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6c52249a-4efe-4e2e-38a0-08da23ab6cd6
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3875:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3875F7E2336474A6DD53FF30B3F49@AM0PR0402MB3875.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JJl0lWQBKl4kNCNkBOMc1D8sW+CThEe76aSjKTBft1yMPjgGDo2rm9x4OGNnjBzRqu0uvlWrChCWbF7dW/F+MZgHp2liFsI4ogiCRcg3h+pn+LuZIZY2Akln67D2ncOqIupI7ReD4gpNWyAy1v4JcYfexGO8xHwo9eoeHkUIFEjEfjSoG3CaiHP93rkkhYQrv4JBmnER/pAose8sEUmLFPB4BZfGLpPeqqYbmwk9YaWSsIFjW6aKEXy4Yscm/c+R77ImQBH+IyGIrz6ULQxb2DoFAqOAP1MTKKema1jRzExcL1wVcN0k3QWpsf/o/0SB4jZV2XWMYdjZ7HgKrdf6W1giFhbYUlYYN18aKg3gw+xvnV8MuVyvOiQCHOARAdBpUdxoxUQlccOuBaSBzdFlo/dgOyqiJ7w0IPnYdG2M7prAWPopEdO7hSob3ATerhzEcyDWiva3S5InwXmvq4Nl/ESWsC9Kdza6HOuakaFn0qeQ72ALtTaFG3AloauTqSFU2BW1GEVckqSHD3UZfrzVysvrHqqRGHpsAUPL3578A8Lg9as/gJQqe5D5JcOrnzwBoXcpdz1GcpRsjbFOAMXJMbWDyxbJuuu17C1Yc/4hVXHelzTcLh0rhpvCCeurcR4tKRAi4GCRNQmlIFIkvfoJeswLiyYSSb092V77nRhvVnE4u3fSw3ISMGaBh1bMDRxsBr8voJuUNwQNKZpadYKnysCL8S7Qyupehq60jMQzPY4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(36756003)(6512007)(86362001)(6486002)(83380400001)(508600001)(31696002)(8676002)(4326008)(38100700002)(26005)(66476007)(31686004)(66556008)(186003)(6916009)(6506007)(2906002)(316002)(53546011)(8936002)(5660300002)(2616005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2VPqbFuiDjR+rOiVD1UjwAOVXgi1vZ5lhdpUlog3F6bZVWuw2HNMggQ2b3Mz?=
 =?us-ascii?Q?S3bgrAP5Jc2JAW3dNxLVVFfD8SOApSN0mlTUmyYyJUuRULzRjcM2qI82M/gN?=
 =?us-ascii?Q?2ZtLM7c1ViWa1auHZDdfyvPCNs9dUKDjujlYcW6iL+TGIyuJOF14INjNm1UP?=
 =?us-ascii?Q?2bsKGFo+rGSV5KeSLNrUIFdM//PoLUHahlu0ME9UFbXjICnyaAGBT+cN91vX?=
 =?us-ascii?Q?RIwIaFcJsfv7WTuARR0FXNzpdmzexR3gTwVvGvUAcTFx+zHRjE4ovAmZRDoL?=
 =?us-ascii?Q?ie6wIgmHa6yyB9p8UMdvSKWfMxc6Ow1nnZcSRMyFPsevBFyKauEfByHpv4n3?=
 =?us-ascii?Q?LSEBY/ksS05k8wwDqjKUGJG46tQJSryscssVfCuMw853LZNIol8NFjrAHnYt?=
 =?us-ascii?Q?vDiEmq8V7MEpgqTb3RKogh483p4kIsECkxrf12xhLrrgWEoE0eZVUyUgcChD?=
 =?us-ascii?Q?ovgwxg2J5aw3o+IvTSxkUpt1ZRKttsMQDLNc+/Cszlm1N15EX/HKUG6OHkMi?=
 =?us-ascii?Q?LHXnNoEMX9uFchv7dHHxjtoVJAXz/oQ5VB4SpwabpNY1q4PNx8inhFRlmgkw?=
 =?us-ascii?Q?FQ+4O2JJ+coWteH/obItJiIxnP3yQ3OL8bWAq1ih8ZoL6gOkONRJPWBivFnt?=
 =?us-ascii?Q?AJA8EiQHkqn8c7x2x8vJgcwsD63kxoj0WJwrJ4t5p6bauSj8p06vovgoV0mF?=
 =?us-ascii?Q?j7xEIyrnguAeJKxCwZqnPTe+20AfMol95+ErjaYp56G12yOHC7EF8l54Gtp/?=
 =?us-ascii?Q?/TPiC2lqU99hNcn2OI6WIbKdKnJdY5D8sB9vg0LERwCgmYZkdYjEFll6YXqz?=
 =?us-ascii?Q?kn2RJ0GcBGHG97sdJlbfpwfJ8y35c4JQaDRFGZ4CA+9i8+y3mvyySgZPRW6h?=
 =?us-ascii?Q?FZEiDXCykWFyQ/7p1TTwx88aUulZJaCSvYHOJ1/Ubz6upe1hhZnKgz4aDDTN?=
 =?us-ascii?Q?H49T1QoTExUTnGCsSlurrsskFaqL8133vIgHWpLJFUynurt8zBFroQUeEv/N?=
 =?us-ascii?Q?IohqNFvN3ZNMuTja9NXCTpLGc7qcTZG0h3fhEZ7XBe7hywWJn6uQkJlkJ3QS?=
 =?us-ascii?Q?2nxXd+GrA64orwJwZWE8DOK8Cp3YO+166huLFzvUhN82ZUdOYZsdK4dsjm4R?=
 =?us-ascii?Q?VUkgi85VDaFzlWk2dSN9ZT1pn7yEKoournBdH5TbCk74TeLrCVAAOptvanCH?=
 =?us-ascii?Q?m91mKStzv8V90q+4ZoCtJTGmc6+Fhfn1XUQSiIAiACcT0gZY1U9Hq007L+Y8?=
 =?us-ascii?Q?CnsW+MtkdX+3NjbcGIxxHfoGYZwa7KJleoNDi9PyLPMqCvuj5q0NuzK3MDJh?=
 =?us-ascii?Q?BG40ACDUxVg/NsuZW0RAeGe9aqsw5XI//DOg/DCAN/tgIoDAB5UwdpKEit7g?=
 =?us-ascii?Q?COpxLuOoNqnk995A/O8+/lmvWOYjUA4v9aJFWm6XQXj/qJCsGzxjJl7YGf31?=
 =?us-ascii?Q?hZePPfpjkqTRAzND2gDG452wMo5b+0guMTbqTJN8YJoBbNiIfI6I7Ng2dLR6?=
 =?us-ascii?Q?R9Psan4hUO/mEr3MAoTkfUXLYXQPRJokoTjw7hn1ofqYrMwu+5GD8bmnl2dr?=
 =?us-ascii?Q?7z7hq5hT1/XKiwA/CcKVvejq5csw2JhJ1PEJ2RHbtmsPEBKLg2HW2bo7CY4S?=
 =?us-ascii?Q?+pF+EQ9jwXT3HDocFvbzGWWCD8VHLFnkLf+oh56EGT2KeVSKPNxu5aNkpue/?=
 =?us-ascii?Q?Lj80gx7YqIc/dujwpxJQ13LEK4q8ISgG+1JRA4R6HPL47q9nEHJCY1ft5Twc?=
 =?us-ascii?Q?1Sb//HlufQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c52249a-4efe-4e2e-38a0-08da23ab6cd6
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 15:27:19.9954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HpgxMxF+jLzAbsDZ1k3BYqHN3k7XC/mRwWWRS4VnxUBok83nnpmL/IkeVP1K04GJbtKvakf3XPNcScJJcGJvzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3875

On 21.04.2022 17:21, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 21, 2022 at 11:50:16AM +0200, Jan Beulich wrote:
>> On 31.03.2022 11:27, Roger Pau Monne wrote:
>>> Expose VIRT_SSBD to guests if the hardware supports setting SSBD in
>>> the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU
>>> families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD
>>> allows for an unified way of exposing SSBD support to guests on AMD
>>> hardware that's compatible migration wise, regardless of what
>>> underlying mechanism is used to set SSBD.
>>>
>>> Note that on AMD Family 17h (Zen 1) the value of SSBD in LS_CFG is
>>> shared between threads on the same core, so there's extra logic in
>>> order to synchronize the value and have SSBD set as long as one of the
>>> threads in the core requires it to be set. Such logic also requires
>>> extra storage for each thread state, which is allocated at
>>> initialization time.
>>
>> So where exactly is the boundary? If I'm not mistaken Zen2 is also
>> Fam17 (and only Zen3 is Fam19), yet here and elsewhere you look to
>> take Zen1 =3D=3D Fam17.
>=20
> Right, but Zen2 already has AMD_SSBD (ie: SPEC_CTRL), so it's not
> using this logic.
>=20
> The AMD whitepaper is more clear about this: any Fam17h processor that
> is using the non-architectural MSRs to set SSBD and has more than 1
> logical processor for each logical core must synchronize the setting
> of SSBD.
>=20
> I think just dropping the mention of Zen 1 in the commit message
> should remove your concerns?

Or keep it, but qualify it by saying that Zen2 isn't expected to take
this path because of having SSBD. But iirc SSBD was introduced to
Zen2 only by a ucode update, so such a description should not be wrong
wrt such not-up-to-date systems.

>> Just one further nit on the code:
>>
>>> +static struct ssbd_core {
>>> +    spinlock_t lock;
>>> +    unsigned int count;
>>> +} *ssbd_core;
>>> +static unsigned int __ro_after_init ssbd_max_cores;
>>> +#define AMD_ZEN1_MAX_SOCKETS 2
>>
>> This #define looks to render ...
>>
>>> +bool __init amd_setup_legacy_ssbd(void)
>>> +{
>>> +	unsigned int i;
>>> +
>>> +	if (boot_cpu_data.x86 !=3D 0x17 || boot_cpu_data.x86_num_siblings <=
=3D 1)
>>> +		return true;
>>> +
>>> +	/*
>>> +	 * One could be forgiven for thinking that c->x86_max_cores is the
>>> +	 * correct value to use here.
>>> +	 *
>>> +	 * However, that value is derived from the current configuration, and
>>> +	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
>>> +	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
>>> +	 */
>>> +	if (boot_cpu_data.extended_cpuid_level >=3D 0x80000008) {
>>> +		ssbd_max_cores =3D 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
>>> +		ssbd_max_cores /=3D boot_cpu_data.x86_num_siblings;
>>> +	}
>>> +	if (!ssbd_max_cores)
>>> +		return false;
>>> +
>>> +	/* Max is two sockets for Fam17h hardware. */
>>> +	ssbd_core =3D xzalloc_array(struct ssbd_core,
>>> +	                          ssbd_max_cores * AMD_ZEN1_MAX_SOCKETS);
>>
>> ... largely redundant the comment here; if anywhere I think the comment
>> would want to go next to the #define.
>=20
> I guess I should also rename the define to FAM17H instead of ZEN1, as
> all Fam17h is limited to two sockets, then the comment can be removed
> as I think the define is self-explanatory.

Yes, this rename would help both eliminate my confusion as well as the
need for the comment.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 15:29:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 15:29:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310329.527107 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYkN-0000qc-2K; Thu, 21 Apr 2022 15:29:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310329.527107; Thu, 21 Apr 2022 15:29:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhYkM-0000qV-VP; Thu, 21 Apr 2022 15:29:30 +0000
Received: by outflank-mailman (input) for mailman id 310329;
 Thu, 21 Apr 2022 15:29:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Sn/J=U7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhYkL-0000qP-WC
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 15:29:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d573b020-c187-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 17:29:29 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 8B7D71F388;
 Thu, 21 Apr 2022 15:29:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5468A13446;
 Thu, 21 Apr 2022 15:29:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id LBK5Elh4YWJyZAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 21 Apr 2022 15:29:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d573b020-c187-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650554968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=h3T6oVdIEiAoOknXMJQlzGlmDQWgAHO2WwHFfzVsC2E=;
	b=AC/ZydHm/km1YL9h4guPQXh8abUCS2NHWmcApokIFGKvYAEuqWAK7J3zK9EzsEDxjv8YoB
	zLtmjfoV7igAOIMoR5MazGk7By6G65HQeZAI5Fq3gMEmCU5pDPht5+tyP/gVRy90qlkppD
	WFiExHABJWkpdZbeA7sKqqhICNanNvY=
Message-ID: <15c89971-aefb-e71c-3798-c2e3820601f8@suse.com>
Date: Thu, 21 Apr 2022 17:29:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 4/4] xen/scsifront: harden driver against malicious
 backend
Content-Language: en-US
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>,
 "Martin K. Petersen" <martin.petersen@oracle.com>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-5-jgross@suse.com>
 <00c1cd38-5164-edfa-6c47-606803629dcf@oracle.com>
 <9d8c453b-7147-d80c-3d4f-666a3b530929@suse.com>
In-Reply-To: <9d8c453b-7147-d80c-3d4f-666a3b530929@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------lrbiipHtViPigkxsk5QxRda5"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------lrbiipHtViPigkxsk5QxRda5
Content-Type: multipart/mixed; boundary="------------dNyHNIA0JsXSFk76jcObWza7";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>,
 "Martin K. Petersen" <martin.petersen@oracle.com>
Message-ID: <15c89971-aefb-e71c-3798-c2e3820601f8@suse.com>
Subject: Re: [PATCH 4/4] xen/scsifront: harden driver against malicious
 backend
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-5-jgross@suse.com>
 <00c1cd38-5164-edfa-6c47-606803629dcf@oracle.com>
 <9d8c453b-7147-d80c-3d4f-666a3b530929@suse.com>
In-Reply-To: <9d8c453b-7147-d80c-3d4f-666a3b530929@suse.com>

--------------dNyHNIA0JsXSFk76jcObWza7
Content-Type: multipart/mixed; boundary="------------JopTs9tb0nos5y7CFuy9ALV3"

--------------JopTs9tb0nos5y7CFuy9ALV3
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMDQuMjIgMTI6MTMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDIwLjA0LjIy
IDE4OjEzLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6DQo+PiBKdXN0IGEgY291cGxlIG9mIG5p
dHMuDQo+Pg0KPj4NCj4+IE9uIDQvMjAvMjIgNToyNSBBTSwgSnVlcmdlbiBHcm9zcyB3cm90
ZToNCj4+PiAtc3RhdGljIGludCBzY3NpZnJvbnRfcmluZ19kcmFpbihzdHJ1Y3QgdnNjc2lm
cm50X2luZm8gKmluZm8pDQo+Pj4gK3N0YXRpYyBpbnQgc2NzaWZyb250X3JpbmdfZHJhaW4o
c3RydWN0IHZzY3NpZnJudF9pbmZvICppbmZvLA0KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgdW5zaWduZWQgaW50ICplb2lmbGFnKQ0KPj4+IMKgIHsNCj4+PiAtwqDC
oMKgIHN0cnVjdCB2c2NzaWlmX3Jlc3BvbnNlICpyaW5nX3JzcDsNCj4+PiArwqDCoMKgIHN0
cnVjdCB2c2NzaWlmX3Jlc3BvbnNlIHJpbmdfcnNwOw0KPj4+IMKgwqDCoMKgwqAgUklOR19J
RFggaSwgcnA7DQo+Pj4gwqDCoMKgwqDCoCBpbnQgbW9yZV90b19kbyA9IDA7DQo+Pj4gLcKg
wqDCoCBycCA9IGluZm8tPnJpbmcuc3JpbmctPnJzcF9wcm9kOw0KPj4+IC3CoMKgwqAgcm1i
KCk7wqDCoMKgIC8qIG9yZGVyaW5nIHJlcXVpcmVkIHJlc3BlY3RpdmUgdG8gZG9tMCAqLw0K
Pj4+ICvCoMKgwqAgcnAgPSBSRUFEX09OQ0UoaW5mby0+cmluZy5zcmluZy0+cnNwX3Byb2Qp
Ow0KPj4+ICvCoMKgwqAgdmlydF9ybWIoKTvCoMKgwqAgLyogb3JkZXJpbmcgcmVxdWlyZWQg
cmVzcGVjdGl2ZSB0byBiYWNrZW5kICovDQo+Pj4gK8KgwqDCoCBpZiAoUklOR19SRVNQT05T
RV9QUk9EX09WRVJGTE9XKCZpbmZvLT5yaW5nLCBycCkpIHsNCj4+PiArwqDCoMKgwqDCoMKg
wqAgc2NzaWZyb250X3NldF9lcnJvcihpbmZvLCAiaWxsZWdhbCBudW1iZXIgb2YgcmVzcG9u
c2VzIik7DQo+Pg0KPj4NCj4+IEluIG5ldCBhbmQgYmxvY2sgZHJpdmVycyB3ZSByZXBvcnQg
bnVtYmVyIG9mIHN1Y2ggcmVzcG9uc2VzLiAoQnV0IG5vdCBpbiB1c2IpDQo+IEknbSBub3Qg
c3VyZSB0aGUgc3BlY2lmaWMgdmFsdWUgaXMgb2YgYW55IGludGVyZXN0Lg0KPiANCj4+PiAr
wqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7DQo+Pj4gK8KgwqDCoCB9DQo+Pj4gwqDCoMKgwqDC
oCBmb3IgKGkgPSBpbmZvLT5yaW5nLnJzcF9jb25zOyBpICE9IHJwOyBpKyspIHsNCj4+PiAt
wqDCoMKgwqDCoMKgwqAgcmluZ19yc3AgPSBSSU5HX0dFVF9SRVNQT05TRSgmaW5mby0+cmlu
ZywgaSk7DQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHNjc2lmcm9udF9kb19yZXNwb25zZShpbmZv
LCByaW5nX3JzcCk7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIFJJTkdfQ09QWV9SRVNQT05TRSgm
aW5mby0+cmluZywgaSwgJnJpbmdfcnNwKTsNCj4+PiArwqDCoMKgwqDCoMKgwqAgc2NzaWZy
b250X2RvX3Jlc3BvbnNlKGluZm8sICZyaW5nX3JzcCk7DQo+Pj4gK8KgwqDCoMKgwqDCoMKg
IGlmIChpbmZvLT5ob3N0X2FjdGl2ZSA9PSBTVEFURV9FUlJPUikNCj4+PiArwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCByZXR1cm4gMDsNCj4+PiArwqDCoMKgwqDCoMKgwqAgKmVvaWZsYWcg
PSAwOw0KPj4NCj4+DQo+PiAqZW9pZmxhZ3MgJj0gflhFTl9FT0lfRkxBR19TUFVSSU9VUzsg
Pw0KPiANCj4gWWVzLCBwcm9iYWJseSBiZXR0ZXIuDQo+IA0KPj4gV2UgYWxzbyB1c2UgZW9p
X2ZsYWdzIG5hbWUgaW4gb3RoZXIgaW5zdGFuY2VzIGluIHRoaXMgZmlsZS4NCj4gDQo+IEkn
bGwgdW5pZnkgdGhlIG5hbWUuDQoNCk9oLCBlb2lfZmxhZ3MgaXMgdXNlZCBpbiB0aGUgYmFj
a2VuZCBkcml2ZXIuIFNvIG5vdGhpbmcgdG8gdW5pZnkuDQoNCg0KSnVlcmdlbg0K
--------------JopTs9tb0nos5y7CFuy9ALV3
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------JopTs9tb0nos5y7CFuy9ALV3--

--------------dNyHNIA0JsXSFk76jcObWza7--

--------------lrbiipHtViPigkxsk5QxRda5
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJheFcFAwAAAAAACgkQsN6d1ii/Ey/T
jAf+PLx0YSgtXWb/kP9ZZG/6r1QHcj88BZwf8qFrjRFvlKsjF1KOxvZCn2AMroAqiv8RtgjeDjbv
z/7Ub9WUrQSezMH4Iznz+ppWGsnha88EAyNXlzE4mmn2GT/IfVgyHoM9NcrCb3cJK1+mXlSQ0VNj
Ti0/rkX6cNXcWwd1fRs9uTJq/rwlXVJn8l8gZ8EBY6LTVVEA5Scj9YczFGT6tkYFFsA1iZcmCcjC
yDTI4tecM2nSUMcoiYh5L2hQ5Uup0AQ1UORotJP/VKpmSLURcPIIFrN66hgOqDe0WZOXZcMFKuuw
So+lAQ/L7yK1vvBmSLNHfu/smOtXpyVOB3SFL9gVrQ==
=urCh
-----END PGP SIGNATURE-----

--------------lrbiipHtViPigkxsk5QxRda5--


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 16:01:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 16:01:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310335.527118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhZF1-0006M0-Fd; Thu, 21 Apr 2022 16:01:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310335.527118; Thu, 21 Apr 2022 16:01:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhZF1-0006Lt-Cf; Thu, 21 Apr 2022 16:01:11 +0000
Received: by outflank-mailman (input) for mailman id 310335;
 Thu, 21 Apr 2022 16:01:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhZF0-0006Ln-3i
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 16:01:10 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3d5ef55f-c18c-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 18:01:02 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d5ef55f-c18c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650556867;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=1OJz8RvTJ8Itq+VTruUHMHkolaIHndfDoMVGIZQTtrY=;
  b=S4TNRHtx6raypI2AeOLQGchgMoNya8T6VkGr9RNiMLj883T/Kd58oNiu
   cI6zylI3GIiSxlvbX+vHldOi55sHE4exH2zxi+jODiKpJNzjX4WVFpNTn
   K2JbKLIzpLmkn48kzh+z9AsIgeZMOkTAnqe+efgaPC9jCUTZgvzAt5twT
   g=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69648190
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZqZC/6knXQadjsawSDO8FLXo5gzpJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIcC27Tb6rfMGSheot0aY+wpBsE7MTXyd9iGwdoqX82RSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWVrV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYbA07HfOShrwmUBQHHCB+F7MX17rqGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHOGQzPE2RO3WjPH8PU8gwnsuRiULRaiNBqxWSoPUP+3XMmVkZPL/Fb4OOJ43iqd9utmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiFuOrD1CBcQIKO43tw6MyoDKsimcK1FRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqVFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tmuVh6b/PuREDGQ3Ct4acu6koqGp5
 iRspiRnxLlm4WuxvCKMWv4RO7qi+uyINjbR6XY2QcR5q2z3pyH8J9AMiN2bGKuPGp9VEdMOS
 BWN0T69GbcJZCf6BUOJS97Z5zsWIVjISo2+C6G8gitmaZltbg6XlByClmbLt10BZHMEyPllU
 b/CKJ7EJS9DVcxPkWrnL89AgORD7n1vmgvuqWXTkk3PPUy2PyXOF9/o8TKmM4gE0U9ziFiLo
 4sHa5vWmn2ykoTWO0HqzGLaFnhSRVBTOHw8g5A/mjKrSua+JFwcNg==
IronPort-HdrOrdr: A9a23:jWGYc69MPnmL2bhlSgduk+DQI+orL9Y04lQ7vn2YSXRuE/Bw9v
 re+sjzuiWE6wr5NEtOpTniAtjmfZq/z+8W3WB5B97LN2OK1FdARLsSibcKqAeBJ8SRzIBgPN
 9bAs1DNOE=
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="69648190"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH] xen/build: Fix MAP rule when called in isolation
Date: Thu, 21 Apr 2022 17:00:39 +0100
Message-ID: <20220421160039.24564-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

Now that `make MAP` might rebuild $(TARGET), it needs removing from
no-dot-config-targets.

Otherwise the build eventually fails with:

    CPP     arch/x86/asm-macros.i
  arch/x86/asm-macros.c:1:10: fatal error: asm/asm-defns.h: No such file or
  directory
      1 | #include <asm/asm-defns.h>
        |          ^~~~~~~~~~~~~~~~~

Fixes: e1e72198213b ("xen/build: Fix dependency for the MAP rule")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Anthony PERARD <anthony.perard@citrix.com>

Backporting notes.  The original, e1e72198213b, wants backporting as far as we
can go.  This patch is only relevant from 6c122d3984a5e onwards, so 4.14,
which is why my main developing/testing on 4.13 didn't spot it.

no-dot-config-targets seems like a very easy way to create breakage...
---
 xen/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/Makefile b/xen/Makefile
index 3a4e3bdd0f95..ec34524ed21d 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -215,7 +215,7 @@ export XEN_ROOT := $(abs_srctree)/..
 clean-targets := %clean
 no-dot-config-targets := $(clean-targets) \
                          uninstall debug cloc \
-                         cscope TAGS tags MAP gtags \
+                         cscope TAGS tags gtags \
                          xenversion
 
 config-build    := n
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 16:09:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 16:09:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310341.527129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhZNH-0007LG-BE; Thu, 21 Apr 2022 16:09:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310341.527129; Thu, 21 Apr 2022 16:09:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhZNH-0007L9-8N; Thu, 21 Apr 2022 16:09:43 +0000
Received: by outflank-mailman (input) for mailman id 310341;
 Thu, 21 Apr 2022 16:09:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lloE=U7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhZNF-0007L3-Ow
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 16:09:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 72e893da-c18d-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 18:09:40 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-pDCIU7AxObm1Xiv2t3_jCQ-1; Thu, 21 Apr 2022 18:09:39 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0401MB2462.eurprd04.prod.outlook.com (2603:10a6:800:5a::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 16:09:35 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 16:09:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72e893da-c18d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650557380;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DVq+6whEiLRJ7xHIrr30WCcB1pdiXOMTm0IylIrQNGA=;
	b=mNIRklGcilbJKyHtdizhyLhL8sXQaNMdebd21Y5LLrSjuC441n408qhNZZBo8qYJVZfSEC
	Y1iGiX+9FbjtxW5/VxSuzXgM65z6J+3cIG8xgplJn4xIMzpXkAKY6VB3qIBXRU/tad7/EX
	eaNfzeQ+55gOdokxB7OdC4RxS9KBQy0=
X-MC-Unique: pDCIU7AxObm1Xiv2t3_jCQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S+XuimSuMUcY14xZ9MpTohKs5KBkmKfSsIRbGma/i8/J2uKgAtzv2Ci18lLVdqPgg/sHbbmmx3xVBt58fj4l8rn1GvFAQgCjwzap/btE39GSXZ/pPApJxdfht9Q2ZpxLXb23cVs0CUvRDtbD+18qmfYM5MZOqP/KxiM/yqU7KxY9xxZx498tYEj4cpDmhLogttQuRaWQtfT+cT2vvTUJ+tsQWvuFhZxChQymQ15c12b+VIpA+bmk5RTiGUDBEM7R9jVhrPwChmqE5mggQ2t3ZmXllq5N5DYfVEuX+CuvjQ4xiYJFoNm/k387xuveSuVnAxSleTpUHc8aE4tH+WaJ6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DVq+6whEiLRJ7xHIrr30WCcB1pdiXOMTm0IylIrQNGA=;
 b=A8EZctFhMpt1c0b44Pqkvv/MACS4H/Yc/ZvYyJ98WgHSTE6xqIVf2IemjDDO4dp4bY66j9Jd5/z17SA0UG5ubQwCCcbRoWUH40HitEyyAGW0ty+NV2mNYmRn4Q3WwPLmKc9n0fbpHpTfiSxPYiIiLyjAeT3AxDjsJZ1qGVWZLRiFdFY7FPv2DfiH7+l6BymV6kYXQ7bJuifZiQD4FaxYA/7RWfEMGtumVjZNzEZcaFL+9N4MMKCEOKgI9XLTwF0PqN4kNgvs/xlqmG95fxwrJeupYCB0KBLDrTCsH9C3WX7fTuMBFz2XnQJJ4cBLqlhO5DSzMax4KqEj1NoBZECL2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b03098dd-7fd4-ed91-cc94-35fd24c46126@suse.com>
Date: Thu, 21 Apr 2022 18:09:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] xen/build: Fix MAP rule when called in isolation
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220421160039.24564-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220421160039.24564-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0384.eurprd06.prod.outlook.com
 (2603:10a6:20b:460::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2df8d500-228f-43be-8e33-08da23b153d5
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2462:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2462F404B9C2DF10DD4FE2F1B3F49@VI1PR0401MB2462.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F2bNmm4fykOGYG8g1V0va9z3uusNQEPihT1shQi5qWiWdAlxwJDkt5TJ5cHi5FMe9bB/mTckprRJF/Mnf5ImpVnehM+kj/5SmCCGFXYH6f7VCqXYkTKszG/HFcPTbHn5q/CqLizd+I9iZdJYJk23wnii8KcW5d8E6ylELadehDfxBV3+GtVbpELvjch+lffvt9/burO6EhO45mp3r3vGxuKy9AL/7P+BNaqvR/skUZbIR21ObyaxACEACTu/oHUgobgPyCI5N+5Ra4Bl4yLZ8vlQPnP/9WB4KlYQJRQAvOU+9qgeeUc2bd+f74ta5CMRO2vCnPlMSZS56pS9w0yKnMxTrKvDk4pvN9KaaEvMah5KhHGswkkLPeKlaYg9Zy+pvzZOcGjj0x/u+tOV5r1A/47fSyEV5eB6OJjTbItoUwIi1RHlauVlFwy8NCZn1WGch9EjZ9euKDKhG3WbTL8Rvfc9SY04K22HsX3QxT0pSqjZ/ZLhhfiod/p/dgkBaIgnygOycRnFLnFJpSVi8/tsfk9qebsxSLyAPX6XdVQ899E1/G5HVn+8whFE4DXea7ksf+bwTtT3Ko8VaxfwPeJuHaq3i4g4GmJkG7IZ1dtgvkpjipVLyLVi2cSw2+LdB2YO6AwdPFjF8dmUWAvX+B5zR3YxwqwvZQi8hLQOKV39szCpLFRjOLe2hKUmJ8I1s9Nfe7w1AkZhGTUJTVRmlqiMwbljMj8BkluhLpKy1H9FXKDR1oB5JlGAsaf1g23aECq+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(66556008)(36756003)(53546011)(31686004)(2906002)(8936002)(66476007)(186003)(6486002)(26005)(2616005)(38100700002)(54906003)(66946007)(4326008)(508600001)(6512007)(8676002)(86362001)(31696002)(6506007)(6916009)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WndBZ2tFTTV3VWtjd3hlcVBKdncyVmMxd3g4dTQ4eGx4RHZKNHlVWURObmZI?=
 =?utf-8?B?OVZ5S203MXkvazBYRUpZcVBsN01tSWRtUUhRVERWMFVVRnh0ZFdvZEdBc29R?=
 =?utf-8?B?QmNtNUFrL05jYUhmOXRNWS8zbXVXYkxUZXQweE9YMU5LRXV5NVdqN09PSXF3?=
 =?utf-8?B?QkwxSjJHWGJsZ2NFMzRZdDB2aWdHUGl4TlJJc0dhb3lHOWFqUnVDQ1pUR0U1?=
 =?utf-8?B?R0Nlbk1rZE5xeTdrTVBMcGpLTUt3MXhiSVdldmtCRHhCVkdzaWJiREFkQVly?=
 =?utf-8?B?SlJGYnZPZjVUQkdnaDB4Wm03bHZxSXp1a3h5dHFESUU4enRJNjBVTE4rek5v?=
 =?utf-8?B?bTROWGkySFBya2tiQmpVcjdWSGZpNTl4bVlheGNKcWRWbHUySkZ6andFZDRm?=
 =?utf-8?B?Q05iTFhFbmVXRkxJMnVkcGJCbHp1QmowRXpWSXZYV0JFbkszV0ErTGpIcXpV?=
 =?utf-8?B?SWNwZUxMMFN5d3BWTGFlSTdiM0dzdUdHYVBncmxTNm4wUXNGVExnZG1iajZ4?=
 =?utf-8?B?bU1WbDFLOUZCREVPd01mTlF6eGpBeGNUMEtvSHhHRjdGRUFiR2ZybFJteXRa?=
 =?utf-8?B?TU14Y1czc1hsZWExbWZvdllzT3Z4bWhFRGh2VWJoUWEzQkwrcEhKV3BSS0NX?=
 =?utf-8?B?dm9qV3Q1UmV4VVNSazhBNGJVWVVPU0tsVkJ2Y2hKU0srNngwYnFPdXBWc0tp?=
 =?utf-8?B?N0FQa25FQUNaeWZZdjRNcFFuMXpYanRQSllYcXpsQllTSUt2QVowelR6WVNF?=
 =?utf-8?B?Mzlhcm9IOVk0VFMxVUUxdFUvWm1aZW5EQjZvMUhjMi9RWWdwbTlyVlJ6K1NK?=
 =?utf-8?B?VlExSWZidWpmRXFEQnVabW9VTlkwajNhektnQ0hqcFQ3VW9EaTA2b1ZrVjFN?=
 =?utf-8?B?Q212OHYwVGVFdmFrTFBjNTIwRnNHUDVpSUNvRXBzRm5HU0pqdFZZeHFLbnZj?=
 =?utf-8?B?VktzTjRoamJuRlZBRWxxcHJhblVKbHkrQjdWWk0xb0dFcjFiVjlYcGpiTVNz?=
 =?utf-8?B?ajIyM0FWdUFJTUxoRmorOGtzN1V2UDlIbnNVeHA2NmpmKzRvZ2tDa0FCajI3?=
 =?utf-8?B?dG5RckR5R0s2cWZhVStkQUloMkNIZmd5U1pwNDBaL3hVWlBHajl1WkRnV1Rv?=
 =?utf-8?B?SlRDM2lHVmVBSDcxaEZIcEoyRG4xVWRpQllLQTBIb3lZUnJUbG5Nbkt1Z3lH?=
 =?utf-8?B?azVIaDliZ3pUcXNCMjl3bDV5d1B4S2wySUVWM1IvWHFPakRzZlZBdmRhY2Er?=
 =?utf-8?B?dnJ6dk4wQkFMZ3FiTGF0VHk2NVFrWXdFMy95TkhSNGNiRjhhSUM1VEZEMWNy?=
 =?utf-8?B?NUhDaGp0NStnMStlNExHVnpXSEoweHYyOTZCYnJaaE9RN1NiYTAyMHc1NVdp?=
 =?utf-8?B?K0lRdU1HM1p6WnhuRXVXSzVQYU5rUmZjMXVIeno5b1hmL1RkN2Jscm9RWXBn?=
 =?utf-8?B?RExBMlRtVzl1c2YxWGoxK2UyeVo3Y002cm81eFJjQUpwOXJFb0ZUK1h5dzhu?=
 =?utf-8?B?WXZiOUpUVDFkZFJyeHNBc1JKWFIwQnl2STl3K1hySWd5eUl0Mmw3VktjQmFU?=
 =?utf-8?B?a0dLRVNRWVVCcTBKQ25RV3lzVEgxaFU2SlpuY1RzbWJXOWJ3a21wV1lwY1pZ?=
 =?utf-8?B?a0ZwNmpEeEVIRVhBMVZqZks1enFVRk04ZG9oenRERTZZSjNYM3piamFuNDdU?=
 =?utf-8?B?S3dIQXVvb09KMm1rYkJCb1VOc0dJR3hnTU5sakIyVlZ2YlcvbGkyOGlLY1BJ?=
 =?utf-8?B?SklDQzhqNmJxSXVZRHJIbEluZ3U0VUdsL3V2NXkvZ1ZhbUFYK0NqVnd4TzVp?=
 =?utf-8?B?T3NFa01DV2Nac0dvVk5oQ2xwQ1ZOZmlLNVozQXVqd1pLSlo5SXNsN3BJNXhv?=
 =?utf-8?B?ME91TEJ6cG5aWlE1NFhXY0VYcEtZdjl5ZlJnM21VamhlRGxxOTRqeXV5QmJr?=
 =?utf-8?B?ZzlaSUZaRmN1RWdIcmxMd251SmRSNlZJMmNPelhGVFo2eHJUSGV0K2x5K3FN?=
 =?utf-8?B?YldyK0tlNnViQURjSStibjlNWjRYVnUyWFlDUzdEZHNnK2hMMXNCQzlndkx0?=
 =?utf-8?B?QytYWTZvdjcycExBelY2VGJ0ekRIeXU1T25rVVMrTjZLL2t2YTZNeEw2bUZ4?=
 =?utf-8?B?UjM3c0h4SDBqME5nYnR6SnQ1NHgxWFRxekU1NG4yYmJiSGk1WjEzS3h5TkZ6?=
 =?utf-8?B?b3ZDc1B4U3BjZ1hqekN1Y0VpY3hQUTlGbHNqMjFnTVRDVXNZK3Z0U3lWZVQ4?=
 =?utf-8?B?ZTRqTXdMMnR6SjNvczN4eWFqQ2pDLzF2SkZvVzF1NHUyaVk2MWFqa2Q1UEts?=
 =?utf-8?B?bTllYmwvVEhpTGptdG5zSjJDRjRwY2ZxWDdzSHhCQ2xyejQ4SXQ1UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2df8d500-228f-43be-8e33-08da23b153d5
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 16:09:35.1377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qI2NmmuzBSKQtcB7zAYO9DrHW3FzfGGkbDqRsddT1zsYC/6p6r8N97WGM6xd1lRwhDEjqUOZiNGQTNkZK93QmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2462

On 21.04.2022 18:00, Andrew Cooper wrote:
> Now that `make MAP` might rebuild $(TARGET), it needs removing from
> no-dot-config-targets.

Which raises the question whether the MAP target originally was
meant to be used only on an already built tree, which would
explain the missing dependency that you added in the earlier
commit.

> Otherwise the build eventually fails with:
> 
>     CPP     arch/x86/asm-macros.i
>   arch/x86/asm-macros.c:1:10: fatal error: asm/asm-defns.h: No such file or
>   directory
>       1 | #include <asm/asm-defns.h>
>         |          ^~~~~~~~~~~~~~~~~

Why would this be? asm/ isn't a symlink anymore, so should always
exist. I would have expected an error about .config or
autoconf.h not existing, ...

> Fixes: e1e72198213b ("xen/build: Fix dependency for the MAP rule")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> 
> Backporting notes.  The original, e1e72198213b, wants backporting as far as we
> can go.  This patch is only relevant from 6c122d3984a5e onwards, so 4.14,
> which is why my main developing/testing on 4.13 didn't spot it.

... and the commit you reference seems to support that expectation.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 16:43:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 16:43:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310346.527140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhZtK-0004Ch-Qe; Thu, 21 Apr 2022 16:42:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310346.527140; Thu, 21 Apr 2022 16:42:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhZtK-0004Ca-Mp; Thu, 21 Apr 2022 16:42:50 +0000
Received: by outflank-mailman (input) for mailman id 310346;
 Thu, 21 Apr 2022 16:42:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhZtJ-0004CU-4g
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 16:42:49 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 11d180be-c192-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 18:42:47 +0200 (CEST)
Received: from mail-mw2nam10lp2106.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.106])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 12:42:43 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SN6PR03MB4096.namprd03.prod.outlook.com (2603:10b6:805:ba::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 16:42:42 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 16:42:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11d180be-c192-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650559366;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=mBsW/ApJfYyBb1g98+1L1ledW7RTkyKYxJpQcL2Hxz0=;
  b=bsAHfJvzzN53r1NykMPuhaCN4ACbg+d183oZ2QCGwMbTXK5N2+Qdm2H5
   Els0AC/8+ikQmo7MvnDN6wu/zHQygPAiTf+R8Rv7anSBcnvV0wKA8kzwY
   hWJkk1i8An/OZqsAJGwmelyVP8d1BkDdq3oltFPI153AcveAod1odM8Og
   U=;
X-IronPort-RemoteIP: 104.47.55.106
X-IronPort-MID: 69652845
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:43ZKQKONA/zFn+7vrR3KlsFynXyQoLVcMsEvi/4bfWQNrUolhDAHz
 GZMDWDTbK6OYmr0L9AjboyxoBgA6JSDydRqHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2Ncw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 vpDh7+XSRYQZqjBiegbWAZjVCVfMvgTkFPHCSDXXc276WTjKiOp5so0SUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaG/uiCdxwhV/cguhnG/rEa
 tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2MJ9g/P9fZqi4TV5FFrzYHdc/WIQPzJH/9PpnbIo
 32dr12sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHAswaQpXeFulsZRIBWGuhjsAWVkPOMvUCeG3QOSSNHZJo+rsgqSDc21
 1iP2dT0GThot77TQnWYnluJkQ6P1eEuBTdqTUc5ocEtubEPfKlbYsrzc+te
IronPort-HdrOrdr: A9a23:6dThqq9fRvjcoGThHMNuk+GBdr1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79
 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6
 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1cjegIK5Y1n3X
 nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3bRY0eTFcZcso+5zXQISdKUmREXeR
 730lEd1vFImjbsl6eO0ELQMkfboW4TAjTZuCKlaDPY0LDErXQBeot8bMtiA2XkAwBLhqAC7I
 tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOJ1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+
 uzUagmdsPeEQ==
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="69652845"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BeKV3VigGAfCaNJ3KcVVlK2+jpL3cIfQ7g/AVU91oBursOtYetqT6nkUFbJL4iJ+CT0Zi/02TNz+c5jP9M006MdXebWS91vvmVtcHkUv1mOcOtEteMNhyiBXA8PWwXr2ouiGxtWLFzoDYstFO4KbWrHGOXb66u8xMbMuMAe9JmVUHHk36h8Pt4uHe0oSPyNRFtIgc5pyb3KbQ0aBnr+siKtJXE5wEGwYxXQHHfnRKNPRM+xDYT5dhsm0B4+Y7j3J9HavhoOVAhAozLt2L2F8FCVU8KdJtK6ceTSIAVdCMvpzZfvXd1xm3alN5zyzM1OBbW4c0VeL7vuE0Ob7de+YpQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mBsW/ApJfYyBb1g98+1L1ledW7RTkyKYxJpQcL2Hxz0=;
 b=mgLALSQs0GfZPpR+Eg2I5+dtfJZmwxcmJIHVCvIj86oCDblNy4d5/n7hSW24JXn5oXFduTguBfZUJPLkNwORVTbq59pJjp9useWXu9K1r7b4sUywJEVnH/7PEd8lt0lunm9wA+lW8YzSLmwlN/Nrbb+3ay6xawiB0vQ1GWKJ3ezfTeE6zmlxukIPYzFyXpR7NOWjJCNMlE/fKJAcl2UCfEc6V9juBnCRcH8l+G831QyW6stNf52dpG+h5jJRG/XBpOX8U0LvTbjrLleAP+8gjNmkAD7PI/B3lRqbY2OeuxAHL8lWJ47KslMYcqL9YOfv/q/G0bL14A11ne29AaaifQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mBsW/ApJfYyBb1g98+1L1ledW7RTkyKYxJpQcL2Hxz0=;
 b=Ew8yQBf+KGcWEAJMFIxoqDS+whodgmQEJZQIj70rek6m0HDZQ81IUztsPtUPj8/Ihr7R+YksM0yraN/X6vJ2DbicFOWRhcKUY1l5h/JjV81pH3ezqGMNlQ7tm22NNOYITz4wJtu255rwws+a5SfJ1YaFLeUj6iXeGI89WfNbC/Q=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Anthony Perard <anthony.perard@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/build: Fix MAP rule when called in isolation
Thread-Topic: [PATCH] xen/build: Fix MAP rule when called in isolation
Thread-Index: AQHYVZkIemPHAQupqUK7B7t6KIAc2Kz6iS6AgAAJQoA=
Date: Thu, 21 Apr 2022 16:42:42 +0000
Message-ID: <e563c62a-622c-15dd-34f7-57997132649d@citrix.com>
References: <20220421160039.24564-1-andrew.cooper3@citrix.com>
 <b03098dd-7fd4-ed91-cc94-35fd24c46126@suse.com>
In-Reply-To: <b03098dd-7fd4-ed91-cc94-35fd24c46126@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 82355762-3584-46cd-3902-08da23b5f44e
x-ms-traffictypediagnostic: SN6PR03MB4096:EE_
x-microsoft-antispam-prvs:
 <SN6PR03MB4096D3110A5798E854897549BAF49@SN6PR03MB4096.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 nENlTEo351euw5YexUAWO3BiJLVf7h/QUaXUHwNaL8cwqGN7AqMRwOjNKFxQL8AmiLszWeA2/qV1L8cM+DJVoBj9TzMnreTvFraLymEojKf/gXpddahoKcXhyUPwm9W9p8eYxS0CrAXAKCHN5laXyibNtLrEMqJwfVmILkmToP0/XCvuQYzb+QKTcXXPUl9TpCrHUggxpLZW3pnM2m00T1W1bNWbqtBkTeCQmstBHQDJVWPcQ3CihBU5b3uPFP1KCll09xPO3/dtZCmi4uBqwdmIJiov3MFhQYcegS0YAsUltzSaIeo4YmLR2m2TDkAIscgVs65CdKMWDIGOQhq4n5Y/X4ZFLV6xi34TcqAON1i0wOT4vLJzWp5uEtMUcCFCzcIMZ08EXkDz3a75mdpwRgAuiXVC/rjdbhG5+4b+8vRP6mAiKAj1QnawBGQmvAZEAC+WPLwZvMe7LL1ZV89zfUUDNFzCOXzYJ3rBdB14D3sEd1JnE/K2eHjKnkjUeSYCFr4IXxMqMf5BfjkaR1EzerXkdRB+zCzsuEG6Ya0lcfS9l8zOTsj7uCtgGJdE2TnKcOHa3kIZ3HhqfYwPQ0vjFMvuRkFN4+ERMX+cjqz3eh8GtNhHaSTNr5gu58sjc5a6HfJny9mldGrPyjEZi/BEsKoU3VOEPMDrjJu08LZ0uPyUh6Ti1x6RxhzsRfRcJqI8A+e5TTgo1MzGhLIzwaxF7OIq2UXvOwHcuOtBMrzGHgqrMJo+UKHz4gaS1e9BUHF0fUUQ8l+chRvi54zRvUuyLw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(36756003)(31696002)(66476007)(2906002)(8676002)(31686004)(6916009)(76116006)(4326008)(122000001)(66556008)(6486002)(26005)(54906003)(66946007)(82960400001)(316002)(64756008)(2616005)(6512007)(91956017)(53546011)(5660300002)(86362001)(83380400001)(508600001)(71200400001)(8936002)(38100700002)(38070700005)(6506007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dzdkcWU5NzdSSTFqS2dWTjViUU5LVlo2ei9uSlpGdG5RMm16ZU9BODltTlJk?=
 =?utf-8?B?QzhjWDhKY2pERDhuTDhzWnBIMmc1RDcvc0wrV3JvSFlHV05MTTZjR3VNTnRn?=
 =?utf-8?B?NFJYWStnRm1tcEtxRGdLVlZubEdXMzZvKzJSS3dkdDhhMW1TeEVNSU92eUNP?=
 =?utf-8?B?dVg1Q1laOER4MXZvTHFXS0ZDeVFPS3V1dVhlZTF6Y0d3VGI0Q0VCTWs3VEla?=
 =?utf-8?B?bVR0WUQwNnVUaHdZSzhmR25YWmk0Rk9nRkRLNTlMbVRURlFsc25NQm5Eb1lE?=
 =?utf-8?B?ZmxScUFuRWR0S2gyTEVpZnV4VENzRlZYRkpab01qZDM5dU1sQTlxM3JoM0gv?=
 =?utf-8?B?Q2hSS1JEcDJKY0ZsMXBhV0F0WFhzZzh4eEpiTjZ3NkNOMUpXMXZQU25tZ0dO?=
 =?utf-8?B?RFVYMmI0RjkzeFNaS3NmU2RlMlNUN1VUUVdIQ3pJaG83dWJWdWZaSkZwaXBj?=
 =?utf-8?B?UWMxM256Q1FtSGtBcjRMRlU4T3dKb1drOERIMjBMd2NweDdIUWFCZGZSV0tK?=
 =?utf-8?B?b2d4YmxySlRYMXA4d0NGenJkcmFOUWlocGw5RjMzRzFnc2Q3ZHFBeWRWekF0?=
 =?utf-8?B?YTExTythbmhKRnVkMXBNRE9MRVYwUytKeVBWOGZrQzRVUEpXbUtrSE52Y291?=
 =?utf-8?B?b09UTUlIRWZ3MWlOa1dXRUZDSWRxR0NUelFGL3VWSkFITGNKWWFVYlRTYzVJ?=
 =?utf-8?B?b1VWTXFXQUQ5bllIK0ZGeDBSb3FSSnVWM1F1QjNESmpZWHRQNFQ5Qk9ZK1By?=
 =?utf-8?B?b200YXdvcFJrK0QvckdIV09sNzFXRjRCMkZNcVJqdVBSMkozUXBhZVlxOWV1?=
 =?utf-8?B?a0h2OFMrQmNLSU01ZDF2TWltdGQrcnkrN0lMeW41RTVsdFBjelkrSkJuMXkw?=
 =?utf-8?B?OHdVeVo4YnNzNkNldHN2UUdiRlZQSmtDTi8zUndEbzQ2UmNoL2lFeXpnc3Iv?=
 =?utf-8?B?NVk3UFllQjZaWnZiUXBKdllwUFFDNHBEb25tdzdCL0RXM20xOUZuOEEyaXh0?=
 =?utf-8?B?M2NXU2I1aXY5blp5Ny92QSsxUXZLR3Z3M0QwOUJnZk9aMndQc1JSUlYrTnl4?=
 =?utf-8?B?RGw1cGV6ZTQ0UEFGbVl1NkU0K3ExZk5MRnNQVlRSc0FuSDNyQW92TjJETjdt?=
 =?utf-8?B?MzdPKzVINzE0WkZwNDhRLzIwbERrcXBDc1l1S3BUckxRQUVtUW5obnVQMzNo?=
 =?utf-8?B?L25lSHk3K2xnRjYrNjQ3RlljYjZ1emtEZTIvdTloVHc1eEMydldSVzZwNmUx?=
 =?utf-8?B?VUl6N29XV0tuQlJ5T1RzU2NCWnNnZjFkNEl3bTVOUytpZ2tneCtnYStUSlJu?=
 =?utf-8?B?dWMra21TSXlXTm1CNUR0UWtjM1NmdGp0MWxzYWxjNys3MUxQanYzNW5PSndC?=
 =?utf-8?B?NDErZTA2clFGL0dVUEdtYWxvR1JDdGE1SlVTKzljMEo4YnFUeWZyNklvamlL?=
 =?utf-8?B?b2ZGN1hoUm5VcDFoank3bnpwWjdVMmhGcVBMQUc3QXZEYlN6Q3I0K3dJL2Fn?=
 =?utf-8?B?dzU4MGRwUVhtWnhldmlsdUdQQmh2ZHk3OUxGUlhCN2ZNL2FTem52NlFTZ3pY?=
 =?utf-8?B?KytDNFBaVlNlanRyYmx4UkZTWGI5by9ySGxNaHc3czhBaVVWZjN5SVdFd2h4?=
 =?utf-8?B?NGc3T1VEdzV4dDFzYlp3NnRoSjF5ZmI3bTVtV2pJOVhtcGYyTkFwdk15NTR5?=
 =?utf-8?B?SndmR2Y4VHdOcnFxRXR2cUk2eEUxTG5FdVJ1VGRTc3VVU1EwaGkyTlNvellu?=
 =?utf-8?B?V0xCZGtlZmNoTkFIbEFFUGd5dDFDZWF0ajhaZXdxdFJGU0NSdjJqeXFTTzkz?=
 =?utf-8?B?SnA1ZFRLcXQwVW9LVU5Zc3ArRmZyUUNYaTBnMTF5YXlkRUUzUmNzYmQ0OEJQ?=
 =?utf-8?B?U3BKMjRPVjEwSHZpdmJ2aUg3NzZCY1lHUDZMN2ZnZUJQOTNuN3lTZUpSMisy?=
 =?utf-8?B?MTlkTi9GNlkyZCswVXBvUjZ5dTVEblJabjNiei9XZWJsNW56QlRPcXc5MHd6?=
 =?utf-8?B?cXFEaS8yODdpYkg5bkx0Y1BYcEpmakpjZFp0b0g5aFdFMkI5QjBoQ21keUNZ?=
 =?utf-8?B?d3R1aFlxdVJjdHNvV0Y4Q0doOFlaeHVUZTVJNnVxdWRoSVpTRUdvTWJuUzRa?=
 =?utf-8?B?Qnl0QmgzYThFZklrK3VRYmpPUTM4ekR5WUE4VFNmWUUrUWxlRVA3aTFxUXps?=
 =?utf-8?B?RE1PNVZ0MTdzOENBdjVrd3gwa0hvMVBrdHo1MnorbXlSQnJrVDJKVjB2bHU4?=
 =?utf-8?B?Z0xhKzB1ZGM2WjZNbm9jdVJFUHd4OFpYSjN3d0s2SUZCMXdSeUZYT3RzZzho?=
 =?utf-8?B?d21yallreXoxZytXSzhlZk9ldm5lNElYTllwUGZZOG1LUEg3OEkrQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <93C468FCF6517D4ABD8B1DD0F469C30F@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82355762-3584-46cd-3902-08da23b5f44e
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 16:42:42.0853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sdxTZCQrd8QbPrnEQ6iiP3kOpf4kKe1GQbgBYbJ4IU0oSxSNpOF69RUGvLcMbjMqlnPmV6nv/e05vUdjcUDWLIeU4H6ZauDa+29d3xz/pN4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4096

T24gMjEvMDQvMjAyMiAxNzowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIxLjA0LjIwMjIg
MTg6MDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBOb3cgdGhhdCBgbWFrZSBNQVBgIG1pZ2h0
IHJlYnVpbGQgJChUQVJHRVQpLCBpdCBuZWVkcyByZW1vdmluZyBmcm9tDQo+PiBuby1kb3QtY29u
ZmlnLXRhcmdldHMuDQo+IFdoaWNoIHJhaXNlcyB0aGUgcXVlc3Rpb24gd2hldGhlciB0aGUgTUFQ
IHRhcmdldCBvcmlnaW5hbGx5IHdhcw0KPiBtZWFudCB0byBiZSB1c2VkIG9ubHkgb24gYW4gYWxy
ZWFkeSBidWlsdCB0cmVlLCB3aGljaCB3b3VsZA0KPiBleHBsYWluIHRoZSBtaXNzaW5nIGRlcGVu
ZGVuY3kgdGhhdCB5b3UgYWRkZWQgaW4gdGhlIGVhcmxpZXINCj4gY29tbWl0Lg0KDQpJIGNhbid0
IGNvbW1lbnQgb24gdGhlIHByZXZpb3VzIGV4cGVjdGF0aW9uLCBidXQgdGhlIGZhY3QgeW91IGNv
dWxkbid0DQpwcmV2aW91c2x5IGRvIGBtYWtlIC1qNCBidWlsZCBNQVBgIHdhcyBzaW1wbHkgYnJv
a2VuLg0KDQpUaGVyZSBhcmUgYWxzbyBzZXZlcmFsIG90aGVyIGJyZWFrYWdlcyBpbiBYZW4ncyBi
dWlsZCBzeXN0ZW0gd2hpY2ggaXQNCnR1cm5zIG91dCBpcyBmb3JjaW5nIGFsbCBkb3duc3RyZWFt
cyB0byBib2RnZSBhcm91bmQgaW4gd2F5cyB0aGF0IHJhbmdlDQpmcm9tIGdyb3NzIHRvIGRhbmdl
cm91cywgYW5kIHdoaWNoIG5lZWQgZml4aW5nIGZvciBldmVyeW9uZSdzIGJlbmVmaXQuwqANCihF
bWFpbHMgd2lsbCBiZSBhcHBlYXJpbmcgZm9yIHRob3NlIHNob3J0bHkpDQoNClRoZSBjdXJyZW50
IGRlYnVnIHRhcmdldCAoanVzdCBydW5zIG9iamR1bXAgLWQpIGlzIHNpbWlsYXIgdG8gTUFQLA0K
ZXhjZXB0IEkgZG9uJ3QgZmluZCBpdCBhIGNyZWRpYmxlIHRhcmdldCB0byB1c2UgYW5kIHdhcyBw
bGFubmluZyB0bw0KZGVsZXRlIGl0Lg0KDQo+PiBPdGhlcndpc2UgdGhlIGJ1aWxkIGV2ZW50dWFs
bHkgZmFpbHMgd2l0aDoNCj4+DQo+PiAgICAgQ1BQICAgICBhcmNoL3g4Ni9hc20tbWFjcm9zLmkN
Cj4+ICAgYXJjaC94ODYvYXNtLW1hY3Jvcy5jOjE6MTA6IGZhdGFsIGVycm9yOiBhc20vYXNtLWRl
Zm5zLmg6IE5vIHN1Y2ggZmlsZSBvcg0KPj4gICBkaXJlY3RvcnkNCj4+ICAgICAgIDEgfCAjaW5j
bHVkZSA8YXNtL2FzbS1kZWZucy5oPg0KPj4gICAgICAgICB8ICAgICAgICAgIF5+fn5+fn5+fn5+
fn5+fn5+DQo+IFdoeSB3b3VsZCB0aGlzIGJlPyBhc20vIGlzbid0IGEgc3ltbGluayBhbnltb3Jl
LCBzbyBzaG91bGQgYWx3YXlzDQo+IGV4aXN0LiBJIHdvdWxkIGhhdmUgZXhwZWN0ZWQgYW4gZXJy
b3IgYWJvdXQgLmNvbmZpZyBvcg0KPiBhdXRvY29uZi5oIG5vdCBleGlzdGluZywgLi4uDQo+DQo+
PiBGaXhlczogZTFlNzIxOTgyMTNiICgieGVuL2J1aWxkOiBGaXggZGVwZW5kZW5jeSBmb3IgdGhl
IE1BUCBydWxlIikNCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w
ZXIzQGNpdHJpeC5jb20+DQo+PiAtLS0NCj4+IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3Vz
ZS5jb20+DQo+PiBDQzogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+
DQo+Pg0KPj4gQmFja3BvcnRpbmcgbm90ZXMuICBUaGUgb3JpZ2luYWwsIGUxZTcyMTk4MjEzYiwg
d2FudHMgYmFja3BvcnRpbmcgYXMgZmFyIGFzIHdlDQo+PiBjYW4gZ28uICBUaGlzIHBhdGNoIGlz
IG9ubHkgcmVsZXZhbnQgZnJvbSA2YzEyMmQzOTg0YTVlIG9ud2FyZHMsIHNvIDQuMTQsDQo+PiB3
aGljaCBpcyB3aHkgbXkgbWFpbiBkZXZlbG9waW5nL3Rlc3Rpbmcgb24gNC4xMyBkaWRuJ3Qgc3Bv
dCBpdC4NCj4gLi4uIGFuZCB0aGUgY29tbWl0IHlvdSByZWZlcmVuY2Ugc2VlbXMgdG8gc3VwcG9y
dCB0aGF0IGV4cGVjdGF0aW9uLg0KDQpJIGhhdmVuJ3Qgc3BlbnQgdmVyeSBsb25nIGludmVzdGln
YXRpbmcgZXhhY3RseSBob3cgaXQgYnJlYWtzLsKgIEkgZG9uJ3QNCnRoaW5rIGl0J3MgaW1wb3J0
YW50LCBiZWNhdXNlIHRoZSBwdXJwb3NlIG9mIG5vLWRvdC1jb25maWctdGFyZ2V0cyBpcyB0bw0K
c2tpcCBsYXJnZSBzd2F0aGVzIG9mIHRoZSBsb2dpYy4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 16:44:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 16:44:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310351.527151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhZvC-0004pX-AP; Thu, 21 Apr 2022 16:44:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310351.527151; Thu, 21 Apr 2022 16:44:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhZvC-0004pQ-6v; Thu, 21 Apr 2022 16:44:46 +0000
Received: by outflank-mailman (input) for mailman id 310351;
 Thu, 21 Apr 2022 16:44:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/CjG=U7=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nhZvA-0004pI-Ky
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 16:44:44 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2061c.outbound.protection.outlook.com
 [2a01:111:f400:fe59::61c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 573eba30-c192-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 18:44:42 +0200 (CEST)
Received: from BN9PR03CA0475.namprd03.prod.outlook.com (2603:10b6:408:139::30)
 by MN2PR02MB6864.namprd02.prod.outlook.com (2603:10b6:208:1d3::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 21 Apr
 2022 16:44:39 +0000
Received: from BN1NAM02FT007.eop-nam02.prod.protection.outlook.com
 (2603:10b6:408:139:cafe::b4) by BN9PR03CA0475.outlook.office365.com
 (2603:10b6:408:139::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend
 Transport; Thu, 21 Apr 2022 16:44:39 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT007.mail.protection.outlook.com (10.13.3.155) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 16:44:38 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Thu, 21 Apr 2022 17:44:37 +0100
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Thu, 21 Apr 2022 17:44:37 +0100
Received: from [10.71.116.47] (port=17504)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nhZv2-0003Qq-PW; Thu, 21 Apr 2022 17:44:37 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 573eba30-c192-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VhQGjpNHdBbNN5KSYzMhU9PvZ3pSzB6f7NT/ky+at45uzUmkHRrKowThQC0X9515FnxVcDLIRYW5DJbhGSkxm3WsjiSEWaGzsiGqsSAe2u+n66Ec/UcHBis7m8Tynde6P7vnPmwRpWyts2SGTFZ5wyVlGcF/Gono+0cOOt2IDmpYhCzcBPixyHuKZzRQ6N0GtUCWbtucpFM9DN3CeCZEaItvk0PFHrZLjdZDYBL6cbOeWptarJYLXN5I06OnvE5m0FHxiYQ5yC6WtmWgDoyEdCDQI1NgRYvRWFwImSEILBY1r8HbDGdAgIz4ZN4B2gFgaoRcHRPgF0GuguShH5+zoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3Rc/q4B2PL62CdSpzDBHeQ51IVQxGPHtDCltT2xqS1Y=;
 b=caOZE1C75sS7OoUkJBcHP+ZYAK+fq8JV/NcRpMzWZ9SLrdX0PoVsOII5w69scQXWPHEKD73tD8hOO6n6N3/pxD4vMd+seiwquO1Bn83qW/CiYdcbJdsyvLpQyOVU5xXIe4pysYUGmSf/safHfcgeQ6L/oebJxcJPL2YbeupTzzq+HN6bDMfbtpZOZfQ+xqTCKC+bn9dic1jwHkSSR9ckGqEz3GXfHyor18Yc4HoFhbNx5ENFnKLUPbNhTdhBvBqYFbSOik6PQLj0gAKkDiwvhxEYpL9KxtrC0MSWFgnZapLGnD+STc2g1VgEPzibVhkLeX5+rWo6v/s1MsgSwmAzYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=arm.com smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3Rc/q4B2PL62CdSpzDBHeQ51IVQxGPHtDCltT2xqS1Y=;
 b=kST1HjKFZ7JxEWdRDw/GYOkUCKKfTymSqcVX8Hhu0fjCTK0XY7hi6TmaysR72hI/sHCzXN4fuZhRTf/BDx0EuVQKohWCyzBRADhVFkCgN0QXnYlGF3MO7/Avz6F36Yb2EDnkNGbkBqm1K2A/xZ8KL5ZfxqN4cGUwLunBLze8rHw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
Message-ID: <f1a12f24-cc41-e731-b711-c1bd8e5cbfba@xilinx.com>
Date: Thu, 21 Apr 2022 17:44:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: Need help to debug Arm SMMU issue seen on guests with passthrough
 devices
To: Rahul Singh <Rahul.Singh@arm.com>, Ayan Kumar Halder
	<ayan.kumar.halder@xilinx.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
References: <022fb545-9295-1f10-6caa-01813cf0a646@xilinx.com>
 <98FE5BFF-4201-49F1-9F17-42E26FBE3FAF@arm.com>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <98FE5BFF-4201-49F1-9F17-42E26FBE3FAF@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 771c8053-03fa-4b9f-458a-08da23b63a03
X-MS-TrafficTypeDiagnostic: MN2PR02MB6864:EE_
X-Microsoft-Antispam-PRVS:
	<MN2PR02MB6864D6C76C689790866E9D76B2F49@MN2PR02MB6864.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c6puBU5Pw58p/1F14uIRdAMdacmExePaFWHT1pnen7q/tcmIlug05ZiDIxBE5/Nb/TiKlUHURlF5GqvS09TO/4WMcFNgtxinlYXQNjRp3fQ3soGySutJ4fg3jkAh6TekoreCOpyPJHv81RM43RyrZ2g1VAPHEARHKeDHG72iR30NW3G6Nfy7RhDf/TqyiUIC7YuDzVO7/uAuqtVpxqTZGlOsZVb0RUbhIEe2+QOIRfrd5YS3qLtHW8htyYq2W14TIIIHbJrVaWcDr5aBPVMOBEw4DA49htFUWXEYsz+nigqY9tt5mv2PHFBm26pMkKuGiFV8kpaeLCB6XiFW1ZOXNLNgBtqj2TF0nyCZhRWTu0e0CgFeXUyOYdx7KsipzvX4J9XM6PMMzmlzeQa2Z6HLiTStfiSd3Hd3mmIHA3eTO6MqonFUMtsdvgMOB81lXwtla5j4Hgaz44z8Bx+7OYkZTn8qDLbuPLu3VQ4W6DfjbsHzKPD4D358H3hSaTazuUIZaSUnd4ipYzlHk9Lo3QJ6ykw5kVyoQYa+DyIHHU2/YDOO1WkjJfi9LDOH1/MJkuTUyEBkcYFz9WcPR3P6zCSKDxV7kqqc3y7jgNdmldQECDf9ipPSYaDUCHyriXz35+QsEgLC+Y4Wse3rwM54p4aePTSHATBXnYlRvnODDLeB6S21lH4GqybeIiJjoSSexOXi8AyFjF6ETpkhGbjbf4BM7jwUO945LV77l0sToIyXCtI=
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(186003)(426003)(336012)(47076005)(54906003)(110136005)(4326008)(8676002)(70206006)(70586007)(2616005)(31686004)(26005)(36756003)(83380400001)(53546011)(356005)(7636003)(40460700003)(82310400005)(36860700001)(31696002)(2906002)(9786002)(8936002)(316002)(5660300002)(508600001)(50156003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 16:44:38.8940
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 771c8053-03fa-4b9f-458a-08da23b63a03
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT007.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6864

Hi Rahul,

On 21/04/2022 14:21, Rahul Singh wrote:
> Hi Ayan,
>
> > On 21 Apr 2022, at 12:12 pm, Ayan Kumar Halder 
> <ayan.kumar.halder@xilinx.com> wrote:
> >
> > Hi Arm/SMMU experts,
> >
> > Scenario :- I am trying to assign a device (eg mmc) to a guest which 
> uses smmu. I start the guest using "xl create -c ...". It works fine 
> for the first time. I am able to access the device.
> >
> > Now, when I destroy the guest and create again, I see this issue
>
> Did you observe any other Xen error while deassigning and assigning 
> the device ?
> >
> > (XEN) smmu: /axi/smmu@fd800000:         GFSR 0x00000002, GFSYNR0 
> 0x00000000, GFSYNR1 0x00000871, GFSYNR2 0x00000000
> >
> > 0x871 is the stream id used by mmc.
> >
> > We are using SMMU-500. So from the Arm SMMU v2 specs, it is 
> "Unidentified stream fault" for stream id "0x871".
>
> Yes, you are right above error means that Unidentified stream fault. 
> That means SMMU hardware is not set up for streamId 0x0000087
> I just try to go through the SMMU code and observe that this issue may 
> be related to iommu group but I am not maybe I am wrong.
> I just created the patch that is not tested. Please try to apply the 
> patch and test it once.

Many thanks for looking into this. With your patch, the issue is resolved.

Are you going to send out this patch for review ? You can add my 
"Tested-by" tag.

- Ayan

>
>
>
> Regards,
> Rahul
>


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 16:55:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 16:55:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310358.527162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nha5B-0006dJ-Ap; Thu, 21 Apr 2022 16:55:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310358.527162; Thu, 21 Apr 2022 16:55:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nha5B-0006dC-7l; Thu, 21 Apr 2022 16:55:05 +0000
Received: by outflank-mailman (input) for mailman id 310358;
 Thu, 21 Apr 2022 16:55:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Mw+u=U7=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nha5A-0006d6-6J
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 16:55:04 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on060d.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::60d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c8998330-c193-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 18:55:01 +0200 (CEST)
Received: from AS9PR06CA0494.eurprd06.prod.outlook.com (2603:10a6:20b:49b::18)
 by DBBPR08MB4300.eurprd08.prod.outlook.com (2603:10a6:10:c5::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 21 Apr
 2022 16:54:59 +0000
Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:49b:cafe::b4) by AS9PR06CA0494.outlook.office365.com
 (2603:10a6:20b:49b::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Thu, 21 Apr 2022 16:54:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 16:54:58 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Thu, 21 Apr 2022 16:54:58 +0000
Received: from 0a28f879592e.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CF45AE3B-BBBA-467E-9015-ED3B399125AC.1; 
 Thu, 21 Apr 2022 16:54:52 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0a28f879592e.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Apr 2022 16:54:51 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM6PR08MB4309.eurprd08.prod.outlook.com
 (2603:10a6:20b:bb::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 16:54:50 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 16:54:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8998330-c193-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eHRpoSgnui5pu95/h9IpUp2du+0058QGwq+wflPXLNY=;
 b=4oALB1s3QZT0WdoK1ZjFUhwCrzEBnLikbIWTtx04LGpwOhY+ioddyB6LTScYWCcXQZZK/Zbt3OyuvQXerjjvTeG0sWFvLwYudm3ttkmieCH20fcKX82U0nXIUM8k881TY4tKoXUf1HjEOg7CHFaJXRLLaB6/H/sPS4o7PJ5wLDw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ed55f77455c6a3e7
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PshMOx5J781HywB16HUrabqRZXgWAS3Uyh7A21b/kXEZa8Ou4PAsx361ziUpvjzHYlnUY8fcikNrkdTZDZSwO/X4IYmYRbU0pHcU4+6CAmnmVYO8q05r1DNa2dAvokwdHwVi1tubo0RULGRbyRqmv3O3clzEQ05CeyUi2ls17tzmAHRFYytj2c9KvuiUYpGaKbKQN4XbYhNVBQqD25aycEMms97X9R2SCN4N4dhoxNx2dONv2AhZXpeeOu7xNV/vpILUiK2jKqIXtOOcyOeJ6vjUR86CTjDqPGeZl30xanWpXgwKdjbOV7E2YId0NVom3siMEOb1A4X8dpFw8ffjFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eHRpoSgnui5pu95/h9IpUp2du+0058QGwq+wflPXLNY=;
 b=FYbm5VV6Zlu5w1l3g4WLf57e9IwbuHjmgSpxsp2FRuIDtGw03AS1G9SH6IuGPWOvjpo+WSwytZTNbb9kwYiv8ZQdSeZQoWPfxNhHgLAj5I028wPW8lUWUPzyzE4m9YlBqG9tlpZlkcdEcFbzE4dkQqu74HJYMH/QTE1NkkTtWiWoSkveB09B3xm0GAJ+vVmFjAMgGYJAF2WHzE0eFaQ9kfIWTJfTDJb8ZRgBgqzezUsFrSeSMEvXwpHXy8kmho3P2cR3QVRbUsIW9CGV9fvaU3nQBTx1WBMLok4u1ALoAUHICm5JZBHv/i8KcSNw1IK/ABEpW9HG/jOrnT8voJxtdQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eHRpoSgnui5pu95/h9IpUp2du+0058QGwq+wflPXLNY=;
 b=4oALB1s3QZT0WdoK1ZjFUhwCrzEBnLikbIWTtx04LGpwOhY+ioddyB6LTScYWCcXQZZK/Zbt3OyuvQXerjjvTeG0sWFvLwYudm3ttkmieCH20fcKX82U0nXIUM8k881TY4tKoXUf1HjEOg7CHFaJXRLLaB6/H/sPS4o7PJ5wLDw=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Need help to debug Arm SMMU issue seen on guests with passthrough
 devices
Thread-Topic: Need help to debug Arm SMMU issue seen on guests with
 passthrough devices
Thread-Index: AQHYVXCysDCtUSKEqUams17wmJg+Jqz6WpOAgAA4twCAAALZAA==
Date: Thu, 21 Apr 2022 16:54:49 +0000
Message-ID: <09DE25B5-BAB0-4A8C-88A1-4F97A5BC12A2@arm.com>
References: <022fb545-9295-1f10-6caa-01813cf0a646@xilinx.com>
 <98FE5BFF-4201-49F1-9F17-42E26FBE3FAF@arm.com>
 <f1a12f24-cc41-e731-b711-c1bd8e5cbfba@xilinx.com>
In-Reply-To: <f1a12f24-cc41-e731-b711-c1bd8e5cbfba@xilinx.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: c80d9385-e935-4f5f-a727-08da23b7ab53
x-ms-traffictypediagnostic:
	AM6PR08MB4309:EE_|AM5EUR03FT055:EE_|DBBPR08MB4300:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB4300B7F4A7F560508CEAC350FCF49@DBBPR08MB4300.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 VFG5g/r7Sc56ol9beophL5OWnhx4F3oZYEzMTEIJSztKE8uVhBFC50i3ZD9QQ2LVVdXkEXjBa+Ju1vrmWIKxx6yE5cUJbEG4rq7VWCFUff29Gi3MgmyNZE1qVpHh1NJPnC2NeBGYhxV8NbCyjupcBii8cX+TLKbWMPc/ObXwLZ7FMZ52nulveIVugQq/tE6eoU/ZscLOvfIpzP43HZ3fwFDy/PIrRysmqF7/j+r9m9QhbtmWwILKS5MlmSNZgBYPaZvTLWn0UuUv9ZtjbIxagauizyQu8glzmZsrxWN75ID6KFcD5rN+6jCGr4HEIZ1zj2pQc6egHZ0QdM2RlGRXf/EX+PPG3+Ssk1MO1uvMrpBrYKztGxjpIt/xbp8hso2Cpvh1sR3fhVjtWJc+73hPu/5kZAhKHwyEuIAtlv7iH3pc1GwsSphXrTHlcKTqLK/JPuFF0WbJoLL6e/uOKVndDPUxw0T7lvBhW5YN4w/qd2rbHUglkdhuwIQ0wamhWPsObt9x0zRP22GTT/xfutaLzWrlTocTkHR51eOp4bpvQ0IqP9acpNvZBqs+GwVqG4tR2pY1rvz33EBmNy7WuxxuK4OByWLWFAODNx3AkNJu2Yj7G2evhDKO6hekPEFNeXbI0KOzgaKI67wagQ79ztUuQyD53KqUNsUQHDWTMD0QeIl6/w05qRgFrYstW4Mx8StQ4DaQuKRWVcQ19tqkBCY/MIAgsWT6kNNnuIQDb4wLWYXQX3leuibQER+yAOgeEFU3
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(71200400001)(86362001)(8676002)(5660300002)(6512007)(6506007)(36756003)(186003)(38070700005)(26005)(316002)(6486002)(122000001)(53546011)(33656002)(2906002)(6916009)(508600001)(4326008)(8936002)(76116006)(66946007)(83380400001)(2616005)(66476007)(91956017)(66556008)(66446008)(64756008)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D37A292E94E49746BDD72F903A939CA7@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4309
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8a1876b4-f6cf-4288-534b-08da23b7a618
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZOh5AOOJC2lAiy8nQiELcQHY66oNyV1ZdgcFgJujY8eodHCCITRHgviUiGh81mEcNl65+1EWTv60f9wEt6uiSBNnZ28+SUsX9T8qG0he4qC6+gmvF7V7oRmdAjXxaE1OQhqHeD5SX3FsZz0urdgJAsQaG7vAxHQLJXQ/f2WVimzeVVOpSg7xkl0Dp8pb9b5574HW4ce58+hQcm0V8Q0sBYfjqh4g10p+ffvYXSopVBKpfypkU+V2ehLdq7/jPaFqdjYdh0P81Z6J2MBxDVEqan1k2NF9g1NBx6cQsHG6MMUSqgbx3YcZ+F4Dxk+j8DRtU4yECKsKwwglp2g41ZVpNXgsPGO541TGahdI3+Dhl6d3q6AOLVNbtuhZPsn+9CCUFEwzQlLzoKTzCRC4/7K6OzQe/YWuvY6U2E241I1Y3bCeObaXXljfOxu/Cnl/SeEQnteFDnFKj3UHoh94TB3E2qtxfwVeUdbNow7akQJvjPm+Cz0Ha1rcfGwBeNDJsFpkeGf/bR1oj8kL3x5Gq0D/6ZINED+VfQdjrbyDJjMqJMlfOoEwYHnyncsBjc8Ja64O15MkvPhCSDTPWRs0ODDt+gAFugYGwaAyj8GRGLaXfnyj9wxktkq9YoE9JNhWVejQDncm1lTHdoka+KkpIDdrHiBlM0kcaqG8pfCkYt/xfmYLTC3lTDvlfCpQyn4eGo/b
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(5660300002)(2906002)(356005)(86362001)(8936002)(81166007)(2616005)(26005)(47076005)(54906003)(186003)(336012)(40460700003)(6512007)(82310400005)(36756003)(6486002)(53546011)(6506007)(508600001)(70206006)(70586007)(83380400001)(8676002)(316002)(4326008)(6862004)(33656002)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 16:54:58.6095
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c80d9385-e935-4f5f-a727-08da23b7ab53
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4300

Hi Ayan,

> On 21 Apr 2022, at 5:44 pm, Ayan Kumar Halder <ayan.kumar.halder@xilinx.c=
om> wrote:
>=20
> Hi Rahul,
>=20
> On 21/04/2022 14:21, Rahul Singh wrote:
>> Hi Ayan,
>>=20
>> > On 21 Apr 2022, at 12:12 pm, Ayan Kumar Halder <ayan.kumar.halder@xili=
nx.com> wrote:
>> >
>> > Hi Arm/SMMU experts,
>> >
>> > Scenario :- I am trying to assign a device (eg mmc) to a guest which u=
ses smmu. I start the guest using "xl create -c ...". It works fine for the=
 first time. I am able to access the device.
>> >
>> > Now, when I destroy the guest and create again, I see this issue
>>=20
>> Did you observe any other Xen error while deassigning and assigning the =
device ?
>> >
>> > (XEN) smmu: /axi/smmu@fd800000:  GFSR 0x00000002, GFSYNR0 0x00000000, =
GFSYNR1 0x00000871, GFSYNR2 0x00000000
>> >
>> > 0x871 is the stream id used by mmc.
>> >
>> > We are using SMMU-500. So from the Arm SMMU v2 specs, it is "Unidentif=
ied stream fault" for stream id "0x871".
>>=20
>> Yes, you are right above error means that Unidentified stream fault. Tha=
t means SMMU hardware is not set up for streamId 0x0000087
>> I just try to go through the SMMU code and observe that this issue may b=
e related to iommu group but I am not maybe I am wrong.
>> I just created the patch that is not tested. Please try to apply the pat=
ch and test it once.
>=20
> Many thanks for looking into this. With your patch, the issue is resolved=
.
>=20
> Are you going to send out this patch for review ? You can add my "Tested-=
by" tag.
>=20

Good to know that the issue has been resolved. Yes, I will send the patch f=
or review.

Regards,
Rahul=


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 17:09:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 17:09:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310364.527172 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhaIZ-0008UG-Jq; Thu, 21 Apr 2022 17:08:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310364.527172; Thu, 21 Apr 2022 17:08:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhaIZ-0008U9-Gy; Thu, 21 Apr 2022 17:08:55 +0000
Received: by outflank-mailman (input) for mailman id 310364;
 Thu, 21 Apr 2022 17:08:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhaIY-0008Tz-Ms; Thu, 21 Apr 2022 17:08:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhaIY-0006PA-K6; Thu, 21 Apr 2022 17:08:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhaIY-0008Ku-AN; Thu, 21 Apr 2022 17:08:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhaIY-0004NJ-9s; Thu, 21 Apr 2022 17:08:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DQJ/Hit9hVik7mvO7yTY4CoehFDw0ws/096ux7jiyXM=; b=WcROarq0oGGYFK4xKuCLGNRy9+
	XGN8+tWyqIVX1lfKH0DF0iSHw797UL+OtzrhMBva/pVnD9dVfqW2W50sesAL80aWEymo1bvZ3nENi
	0W3JRKuIBWwrWBQpbuvYAkg3Im9cg0NRr+U7V01MaKofJbbcXwssUrNZ3eajzotfRnTA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169594-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169594: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 17:08:54 +0000

flight 169594 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169594/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  539 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 17:23:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 17:23:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310374.527185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhaWg-00033e-4I; Thu, 21 Apr 2022 17:23:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310374.527185; Thu, 21 Apr 2022 17:23:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhaWf-00033X-Vd; Thu, 21 Apr 2022 17:23:29 +0000
Received: by outflank-mailman (input) for mailman id 310374;
 Thu, 21 Apr 2022 17:23:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhaWe-00033B-5h
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 17:23:28 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bea3ca4b-c197-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 19:23:26 +0200 (CEST)
Received: from mail-bn1nam07lp2047.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 13:23:20 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BYAPR03MB4789.namprd03.prod.outlook.com (2603:10b6:a03:12d::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 17:23:16 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 17:23:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bea3ca4b-c197-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650561805;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Tl1ED7Ej7WCZr84wo1pq0ZwpBz7um8FadlQl+zoIHYo=;
  b=gvoFH98HZKpXTLNimxYbow/racxmsVmo/WZoyF7zV8WiWfif3mJdpmeg
   P7j0uxMcilLbaQdYR3qRszOzuoT2BchN0cZvLPhS7HNTl7PmBwJSyPCZz
   mHMfoRmPsdegQMhyIOMrHFQ2gIubz4jK2ptcY39N5/AXA9JLXKtLpJQGm
   k=;
X-IronPort-RemoteIP: 104.47.51.47
X-IronPort-MID: 72072777
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ImBUr66ZYjbJgTsivxn6igxRtDLGchMFZxGqfqrLsTDasY5as4F+v
 mMdUG+Fbv3cN2egKtF3bIqz9B4D65/VmNRkHQtrqylhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjWlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSvWxgZDqP3xt0QVgRXPAV0AOpl/7LudC3XXcy7lyUqclPK6tA2VgQcG9Rd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiTo4MHtNszrpkm8fL2T
 swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK//JouTeMk2Sd1pDxKtX4R8GIHv4OtUyit
 2nMz030WCgVYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUcUlGxsL+0kU66VtdWL
 WQb/yMvqe4580nDZsb5dw21pjiDpBF0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 Te0c8jBADVutPifTyub/7LM8jeqY3BJcikFeDMOShYD75/7uoYvgxnTT9FlVqmoktnyHjK2y
 DePxMQju4guYQcw//3T1Tj6b/iE/PAlkiZdCt3rY1+Y
IronPort-HdrOrdr: A9a23:1M69iaOvf0W1RcBcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM
 tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH
 Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u
 Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP
 hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/
 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ
 CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY
 fHBK5r
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="72072777"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O87t7QhzHJ0BFLX6i+Q53OubkXjRIpZjz6nSgSHzkTOm823kpySEpyOxsy7mIEyq6+aqkZiabxhQ5ap4I7kTzTAaeTQfCX6R783DfNILUMXeiBuydEEAguzKZ6Qckqv1zlSCfwoZHsS5F6poeVaTZohadxJzi6DGG29tZnz0VShPOWWpvgUOCbJV5Mny0mFfU/Jrh0wqs8eHqB5vNksW7WgHB0/KEp8chcmzH7cGrxwyr+zBQvQQDD/WsLy+DX/J+6xlH12USZQSUvJhPH++bvZin1qaXxfOvRHCU6z6ugsWfeaFuWaII5jt1PE/m5MYvEtc3QPAFn0AuIYEBcbfXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tl1ED7Ej7WCZr84wo1pq0ZwpBz7um8FadlQl+zoIHYo=;
 b=iCDkWV8JDOchhPPxNgCFXqqMeHdj03z7HsU5t5xoWD6Obeoe28WR2OQECZf216ae0B/optqbJpPG/uDAGxgoJ0LlfA79ZHD4fuDDOTm9L/tdlYZJlHnO5CzhzLqlLRCocj+y+E6ca5eaDRNKipuKYvZvGf3mahrWDkHyqytHWTbpPdvJEK1KGhLj7cNCDMyPHMH4g6NV71B+AtrnldPADt8eCtofAGGZ8DnOdIgi0YfTDuGQXbMbS6WbUZHg7DiWARHDVDO45RQ11jzhUUH1kd9mSOHQQl+/FQcve9yPOGZDi01DvU3OLBlu1qIbOGLLhlZXl0RX+451SVKJVg4dcg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Tl1ED7Ej7WCZr84wo1pq0ZwpBz7um8FadlQl+zoIHYo=;
 b=mXrJD9y22GHMQ2r8PqlJIKERfbih2xMATwSuUcd6VYVPNDaZrqQxJehJpb61+4hboRtswn3nmA2bXEgIfqtrVR/sd5W0orHwHavSGeN8vdBQex7uvwWWeH1fCtnt5MI9ADJnYEPqlj1BOII920+U2dN04IUM3TKI/Z1YbjZMBfs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bobby Eshleman <bobby.eshleman@gmail.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 1/6] x86/debugger: Remove debugger_trap_entry()
Thread-Topic: [PATCH v5 1/6] x86/debugger: Remove debugger_trap_entry()
Thread-Index: AQHYVMDX0pnJlQhLrUiicQUgBCrtjqz6VpcAgABI4AA=
Date: Thu, 21 Apr 2022 17:23:16 +0000
Message-ID: <b32d8ab5-dcca-971c-39ed-032aba0dcea2@citrix.com>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-2-andrew.cooper3@citrix.com>
 <57858c7b-019a-2888-42ae-7ce9a7c88cc0@suse.com>
In-Reply-To: <57858c7b-019a-2888-42ae-7ce9a7c88cc0@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 40ef017f-761a-4a9a-bf00-08da23bb9f78
x-ms-traffictypediagnostic: BYAPR03MB4789:EE_
x-microsoft-antispam-prvs:
 <BYAPR03MB478934A394153F305F2C11D9BAF49@BYAPR03MB4789.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 /btrih27nrwTr2wnLfPUZMFpKh5bSXtim65ilqO5pswOxMPD8nVGr9iag+qQy4kbFNuVuP+342wr9IaXqIH+25yQZguwypUCLWtFw4DzqCMmyOacE5C0/XuzpDRdEx4OD8j5OQoCDcpX7EReG6fqazcOwe4VsAXwOLAP6Xzso7TmPfknnxw7FxtDg4lrHn6n6DTqGacbcy3ADJU2rTAvKlW6EWN2wnJNC+NnB4A0x+PLBD7sPJBNDRs4X9WBv2CXaoHBwraFiBG/q+6vFnNg4TmisNQFMDjUoGo1niaFLBy2ijBRGRETYJqpY20x3399ZPPUQQU8O+f8nJ69f7ZMsDBL0LNAttYolfqAt4/0M2cqvXHdGHrCGhXzwrxlyUWnWOBHTeensOhPyysL1+I50ouS9IkQQbMjKuX/GsJTO/U5BGjCiec7Ajt6GiNA/6TXKXWAKhP8kLQ9eL+YSfYBmUZEj+mksO07tuHzW+ix5HrTgMEn0CTIsNkEImNjgaAF6kbVQPei+wlg4x14wGeOXCR8JhYVihMFSMN88jGt+fT1qH//QCUHN6CfWbVf/cMZ2aLqpsEq/OqXb1Klfq0Os7Jox3gG78I7TcsWbPA4ip+7qQKtZ2IP/Kf9vRSaI9jnyXUpN9MuNtxfQWUqS8vBpuBEYe1PhClammn0VN8u9oHRDAj54TiErfijZCwIHL5ChpmAXVeBL0Evch1DUaOFh5bL7AjXoITHggZrQvX3dTEfue+DVzdJk5EOh9fsCGsdEZ80w6UgZ4j6nSR5nKNEYg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(8936002)(5660300002)(4326008)(91956017)(508600001)(66446008)(2906002)(76116006)(8676002)(122000001)(36756003)(31696002)(64756008)(66946007)(66476007)(66556008)(31686004)(6512007)(53546011)(26005)(6486002)(186003)(6506007)(38100700002)(2616005)(83380400001)(54906003)(316002)(82960400001)(71200400001)(6916009)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZlRUSG5jaXN6UTFzVlV4dXd3UmtTYzBiZGRBYXR6Mk9hT0JjZWRSM21YZXdO?=
 =?utf-8?B?amdqN2pua3hrNy9NaE12UEFGRGh2TVhQOXJscmtoSElxd2UzRVFpK1VnU2Ru?=
 =?utf-8?B?UmlvelZjQzd3eFIrS1A1WTNGOUZaYmZLREhiNndNVE5iVkxrYUJLc3FTK3VM?=
 =?utf-8?B?UzFqK0I4dlpOWW8rRytNTHpqT0lwYTlDOWhpcVRpTGRHekgxeStTUHpEWkV5?=
 =?utf-8?B?eTE0ZVZzZGZLNnRDNXdYUFZva2xGY24vSDNrUGNPcXhnamc2MnhNYXlsQkhB?=
 =?utf-8?B?ZVJCaDhYbW1ZSVNaZHpnb0xzbEpuS0RrQU5NS3kwUFRBU25OdnFEM1dRQzJK?=
 =?utf-8?B?akk2T0QrVzRmb252TTNtcEZ6akV1OGJhZEhqNWFzMk96bC9pT0o5NTVOK3pt?=
 =?utf-8?B?MDkxS1VhK2orUnZycXcyZDBZcDlsTjRFc2VoSi9YejIrVWNiYWJOcTl1a2Ju?=
 =?utf-8?B?dmswVUltUlpLVDhxYW13c05YRm4wcng5QTJtRC9adnhDblJQem9wZDBLNE13?=
 =?utf-8?B?QlMzaEtRQ1Vlb2ZzVHc0NWdHODh0TTBGMnRrOUJJQXJtUzBna3o3UnZLUTdl?=
 =?utf-8?B?TVZLb3F1L2RMVVVwazJtYVFRYUplM0hZc3lUcFAybWR1NVpreUM4OVFtcWtV?=
 =?utf-8?B?SitvdHhvR1owT08rOEJ0QStEak5VVS9QM05xMkR3djRDRC9MYUxwaUtZK1Fk?=
 =?utf-8?B?TTlUVUFUUHduNksvdUpXc0hUSFhKendxT0FPS2FKc3lFWkowRjZqS2xETlNv?=
 =?utf-8?B?ZnhQRXY0dUR6M3gzTjNEWGVPNThlNHZZTEdneWpBOWcyQXcwaWlCa3JlTmM0?=
 =?utf-8?B?TUIrMHFTc1FFOEpZbnF2YzJmVHZPbFgzaCtZeDlWWG43SFFhbGxtZ2hTMDc0?=
 =?utf-8?B?OE1zWDFGRTZpYlMvOE44YVpMUmdERS96WHUxRnhnanFtUzBXZDFTdWI2Wko5?=
 =?utf-8?B?Mm5mNFhaSWZvcDAvTVFWcTV1MFRFazdTaUVDbVE3bElIWGd5U1pBRmRsTzRk?=
 =?utf-8?B?dzNVQ242ZHhsbCt6TGRBNTlWVTlTSi9OWXQ0dWtwOHJiRm5jTlBnQS9mb2NH?=
 =?utf-8?B?cUFJR3JPNWdQOThNS0JCWDZCZm1mS0wxOVdpSitCdy9NTGtNeGJHcjkxTEF3?=
 =?utf-8?B?LzBuRTBiMXNNMHFaTUo0VndGQ01YWDRKTWVwSm1nVmlmSExySEpSZzdFNkh4?=
 =?utf-8?B?QTVDb0loNWtpbXRxODVFRXZ6VDZZa0VNdXdUaEJqVHdaV2gyNEpIeloxVW54?=
 =?utf-8?B?YVhSWHRyanlLSlhwNEtBL2FzMU9Rbk0yUVhaSXc0R1cyeDVHRmZ6cjhjOThp?=
 =?utf-8?B?cWQra3lDZkhBeENIeS9pYUl5SFF2RFNiNkIrKzkyaDh3dVFLZDZsTmdmWk5Y?=
 =?utf-8?B?OHZUU3k3RTQ1WXg4T1V3Z1hacWgyWG5qRjJ2QTdCUlNpQ1lCcVpMQTV1d2Rm?=
 =?utf-8?B?MnVuOXhhVk9Pc0VRODJkYTVQWS8vN1VjdStYSko0VTBDbXpFc3MyTmcwdlIv?=
 =?utf-8?B?bFFXeEZWU0o5NWFXOUVFczhaVjRwdm4vSFFqQ0wvTEVxNjI3bEV2Nko4RFVT?=
 =?utf-8?B?b2VobHVabk5aaTlzNmFBOC9DQUxFUnpxeW93a3EwUlN5Sy90QlNHbW1NQWh3?=
 =?utf-8?B?Y20zYlVyN0xDTi90WGxuaEVXUjRRRmovK1NMTDVwcDBKVEZIeiswOVVJZ25N?=
 =?utf-8?B?MmlPT3VSckE5Z0pDUGRzY2IzbmtYaW1KQ1ZpbW9KZmdFWm1IdXR3dTUveWRK?=
 =?utf-8?B?TDRqRGM4dDFpZnc0WUJFMHF3WUUxZXJrVnp2YUJBUkc5a0daWVZUM080a0Fx?=
 =?utf-8?B?L1ErTmJMWVl2aUVkRjBmek9DQ3NtYW5WR1JVMWdQVjJ1cEs4TWZYZkMwNDEy?=
 =?utf-8?B?NkdHQnVwR3lTbVN6enJFdWUySFZMR055Ni9Pa0tYTEZTeVBtL2FZTzZ6MlVs?=
 =?utf-8?B?bFp5TkhXOWJha2V3UXRMcVU0TUJDSXU4YW9oQ0dVSDJHaEdKMmppNjdmRjhH?=
 =?utf-8?B?akhLOHV3VXlWTkp1d2wrNFBIMkl5cUc4ZFd2MEN6ZTNjWEZGenlvRzNMVVZt?=
 =?utf-8?B?bDUrOUFhRjZjRldKSysrcXE4cmErZ3huMHc4Z3NXWkVncFZrYkFPNkhJaldi?=
 =?utf-8?B?Y21kVVVBNGtHUDVxbGZqdm9nTjZMRjM5K3JKUC9jMnRFSUt5VVJGekNPbXor?=
 =?utf-8?B?MG9NR05TRlRmT2lZcE5EVWtaM3p1N25TVFdXazh4bXRWekUrMncrVlYzSEl1?=
 =?utf-8?B?RUwyWW9rS0UrNXp4NWhYTlFVYldFalovTDlxT2llZGlwb0s1YnhsajhGRzFB?=
 =?utf-8?B?Snh1aVpMZzRjT3hkYzZ6cGtIejBiR1o5WVdsdUFZVlNmY1MxRGs4QT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F5C26B2FE914E34FACAC12A86B993C5E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40ef017f-761a-4a9a-bf00-08da23bb9f78
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 17:23:16.7068
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ULqIUfABTgz+uqRNkIZtwIzzB/eakTvbnkb+8D90QEO8CrvDluXmAjCFp2IIeMR/qPuXZwAqY/Njq6o1d5Ij87fn9/Rfs6OyyoZhIY4lWv4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4789

T24gMjEvMDQvMjAyMiAxNDowMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIwLjA0LjIwMjIg
MTY6MTMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBGcm9tOiBCb2JieSBFc2hsZW1hbiA8Ym9i
YnkuZXNobGVtYW5AZ21haWwuY29tPg0KPj4NCj4+IGRlYnVnZ2VyX3RyYXBfZW50cnkoKSBpcyB1
bnJlbGF0ZWQgdG8gdGhlIG90aGVyIGNvbnRlbnRzIG9mIGRlYnVnZ2VyLmguICBJdCBpcw0KPj4g
YSBuby1vcCBmb3IgZXZlcnl0aGluZyBvdGhlciB0aGFuICNEQi8jQlAsIGFuZCBmb3IgdGhvc2Ug
aXQgaW52b2tlcyBndWVzdA0KPj4gZGVidWdnaW5nIChDT05GSUdfR0RCU1gpIG5vdCBob3N0IGRl
YnVnZ2luZyAoQ09ORklHX0NSQVNIX0RFQlVHKS4NCj4+DQo+PiBGdXJ0aGVybW9yZSwgdGhlIGRl
c2NyaXB0aW9uIG9mIGhvdyB0byB1c2UgZGVidWdnZXJfdHJhcF9lbnRyeSgpIGlzIGF0IGJlc3Qs
DQo+PiBzdGFsZS4gIEl0IGlzIG5vdCBjYWxsZWQgZnJvbSBhbGwgZXhjZXB0aW9uIHBhdGhzLA0K
PiBCdXQgb24gYWxtb3N0IGFsbCAoYmVmb3JlIHRoaXMgY2hhbmdlKSAtIHRoZSBleGNlcHRpb24g
bG9va3MgdG8gYmUNCj4gI05NLg0KPg0KPj4gYW5kIGJlY2F1c2UgdGhlIGRldmVsb3Blcg0KPj4g
aXMgZm9yY2VkIHRvIG1vZGlmeSBYZW4gdG8gcGVyZm9ybSBkZWJ1Z2dpbmcsIGVkaXRpbmcgZGVi
dWdnZXJfdHJhcF9lbnRyeSgpIGlzDQo+PiBub3QgdGhlIHdheSBvbmUgd291bGQgZWZmaWNpZW50
bHkgZ28gYWJvdXQgZGlhZ25vc2luZyB0aGUgcHJvYmxlbS4NCj4gU2hvdWxkbid0IGl0IGJlIHRo
ZSByZW1vdGUgZW5kIHRvIHJlcXVlc3Qgd2hpY2ggZXhjZXB0aW9ucyBpdCB3YW50cw0KPiB0byBi
ZSBub3RpZmllZCBvZj8gSWYgc28sIHJlbW92aW5nIHRoZSBob29rIGludm9jYXRpb24gaXNuJ3Qg
dmVyeQ0KPiBoZWxwZnVsLg0KDQpUaGF0J3Mgbm90IHBhcnQgb2YgdGhlIGdkYiByZW1vdGUgcHJv
dG9jb2wuDQoNCkluIG5vcm1hbCBjb25kaXRpb25zLCBnZGIgZ2V0cyB0byBzZWUgc2VlIGFueXRo
aW5nIHdoaWNoIG1hbmlmZXN0cyBhcyBhDQpzaWduYWwuwqAgSXQgZG9lcyBub3QgZ2V0IHRvIHNl
ZSBhbnl0aGluZyB3aGljaCBpcyByZXNvbHZlZCBieSB0aGUga2VybmVsDQpiZWhpbmQgdGhlIHNj
ZW5lcy7CoCAjTk0geW91J3ZlIGFscmVhZHkgaWRlbnRpZmllZCwgYW5kIG1vc3QgI1BGJ3Mgd291
bGQNCmNvdW50IHRvby7CoCBCYWNrIGluIHRoZSAzMmJpdCBkYXlzLCBYZW4taW5kdWNlZCAjR1Av
I1NTJ3MgZm9yIG5vbi00Rw0Kc2VnbWVudHMgd291bGQgY291bnQgdG9vLg0KDQpCdXQgaW4gYWRk
aXRpb24gdG8gZmlsdGVyaW5nIFhlbidzIGlkZWEgb2YgImZpeGluZyB1cCBiZWhpbmQgdGhlDQpz
Y2VuZXMiLCB5b3UgYWxzbyBuZWVkIHRvIFhlbiB0byB1bmRlcnN0YW5kIHdoZW4gdG8gc2tpcCBu
b3RpZmljYXRpb25zDQpiYXNlZCBvbiB3aGF0IGEgUFYgZ3Vlc3Qga2VybmVsIGNhbiBmaXggdXAs
IGFuZCB0aGlzIGlzIGdldHRpbmcgZXZlbg0KZnVydGhlciBvdXQgb2YgZ2RiJ3MgY29tZm9ydCB6
b25lLg0KDQpkZWJ1Z2dlcl90cmFwX2VudHJ5KCkgaXMgZW1wdHkgKFdSVCBnZGJzdHViKSBzcGVj
aWZpY2FsbHkgYmVjYXVzZSBpdCdzDQpkZXNjcmlwdGlvbiBpcyBub25zZW5zZSBpbiBhbnkgcHJh
Y3RpY2FsIGRlYnVnZ2luZyBzY2VuYXJpby7CoCBBbmQgbGV0cw0Kbm90IHN0YXJ0IG9uIHRoZSBm
YWN0IHRoYXQgdGhlIGxhY2sgb2YgYWJpbGl0eSB0byBpbnZva2UNCnB2X2V2ZW50X2luamVjdCgp
IG1lYW5zIHRoYXQgYW55IGZhdWx0IGZyb20gdXNlcnNwYWNlIHdpbGwgbGl2ZWxvY2sNCnVuZGVy
IGRlYnVnZ2luZy4NCg0KRGVsZXRpbmcgaXQgaXMgYWJzb2x1dGVseSB0aGUgcmlnaHQgd2F5IGZv
cndhcmQsIGJlY2F1c2UgYSB0aGVvcmV0aWNhbA0KZnV0dXJlIHdpdGggc29tZW9uZSB3aXJpbmcg
dGhpcyB1cCB3b3VsZCBoYXZlIHRvIHN0YXJ0IGFnYWluIGZyb20gc2NyYXRjaC4NCg0KTm90IHRo
YXQgcXVhbGlmaWVzIGFzIGEgZ29vZCByZWFzb24gaW4gaXNvbGF0aW9uLCBkb190cmFwKCkgY29u
dGFpbnMNCnVucmVhY2hhYmxlIGxvZ2ljIGJlY2F1c2UgdGhlIGNvbXBpbGVyIGNhbid0IGZpZ3Vy
ZSBvdXQgdGhhdCAjREIvI0JQIGFyZQ0KaGFuZGxlZCB2aWEgYWx0ZXJuYXRpdmUgcGF0aHMsIGFu
ZCB0aGUgZ2Ric3ggbG9naWMgaXMgZGVhZC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 17:29:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 17:29:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310380.527195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhach-0003ho-O0; Thu, 21 Apr 2022 17:29:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310380.527195; Thu, 21 Apr 2022 17:29:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhach-0003hh-LA; Thu, 21 Apr 2022 17:29:43 +0000
Received: by outflank-mailman (input) for mailman id 310380;
 Thu, 21 Apr 2022 17:29:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhacf-0003hb-T7
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 17:29:42 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9eea2f8a-c198-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 19:29:40 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 13:29:37 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM6PR03MB4988.namprd03.prod.outlook.com (2603:10b6:5:1e2::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 17:29:35 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 17:29:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9eea2f8a-c198-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650562180;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=1gQFfY2t396L6hNff6hEfdCdFQEnDCW6uEEb70wyU/s=;
  b=H1TjW6r9EtITo0LFCUY3xeBca9ee4SIo3UdyB4N2Ipuo06DmMKqPxSTe
   2LPKdJJsCTX6LUbCuihF596Yw65IEDAuIELpWrx4l4YOOleYTjD3yFhdS
   BOTx6+W8UjJ0xXq0Ulb53AwoTH7yK08aY70tJpoYZ11MgCwFU88HONuOZ
   c=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 69038089
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:whxG/KvoZdtlTDWLAGr+uNErYOfnVENfMUV32f8akzHdYApBsoF/q
 tZmKW+Db66JNmX8fd8nb4i/pBkDusKGx9RhQQU9/ipgESoa+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X4
 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8NPo30pLsxVCB4TT16IZF96bTWJ0Ow5Jn7I03uKxMAwt1IJWRvZMgy3LYyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5u1qiiHt6HD
 yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvTmLl1wpgOmF3Nz9YOShY+4Ewkahg
 kn072SiEEoEBt+f4G/Qmp6rrqqV9c/hY6oQHrCl8v9hgHWI23ceThYRUDOTq/6zgF/4VslfL
 0ER8ywGoq079UjtRd74NzWnpFaUsxhaXMBfe8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy
 hmOhdyBONB0mLicSHbY/LHEqzq3YHERNTVbO39CShYZ6d7+po11lgjIUttoDK+yiJvyBC30x
 DeJ6iM5gt3/kPI26klyxnif6xrEm3QDZlddCtn/No590j5EWQ==
IronPort-HdrOrdr: A9a23:uT3N76u5ucWHM8yZLan1MHqh7skCL4Aji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPuftXrdyRGVxeZZnMTfKlzbamDDH4tmuZ
 uIHJIOb+EYYWIasS++2njBLz9C+qjIzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf
 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIO/Z4StU
 z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfqWG0hYczBgNkGmpDq1L8Yqq
 iKn/7mBbU015rlRBDxnfIq4Xi47N9h0Q679bbSuwqfnSWwfkNHNyMGv/MZTvKR0TtfgDk3up
 g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIIO5gLZvin+9Kq1wVR4SKbpXYt
 VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFojvA3jzMF7tYwWpNE7+
 PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94KLf8fEw/qWnaZYIxJw9lN
 DIV05Zr3c7fwb0BciHzPRwg2fwqaWGLEDQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP
 v2MI5KApbYXB7TJbo=
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="69038089"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NJ2m3wH1UPdYKexo5r9+C9Gtxyr1hQysMbcWFtGFQLegbj1RsAwt2q81/AXfbM5B0WJ0bezhNESd6/h+g8LY8HnX1G1ZGTXUlwoPyAMXoKvLGVISB7kiUnldhI6HsKOes+msKjdDjITfNvvhWl4BACvIXH95S3OFimy73pgxoQx3TnUVAtB0s0MoOXCQecGWWl7iwKvihURsqubrDQZhQT+pQVaLupwu22wz+AAMfKKMSDDzsVGUwqqjbcg/DPpac9zOAvOOzJUV1bFs/ywQlwXQahHfDAQrUhDS1HRys1piZbPJycsbPhm8Jdt2T5yk/Cn+8Is9sJ8HBJCC5kK2Eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1gQFfY2t396L6hNff6hEfdCdFQEnDCW6uEEb70wyU/s=;
 b=TB2Eb6E4hgPBb6DRAqdOjOnuvj/ZqYySGIPbOHoOHg/YGwNMoHoYfGtsHGIiyDfFniKcGHAjN4YYUva5SLXczs5zFoRA3J0QBc9hlW6C3ztMKL5RvW10vMl779u08k66bHhHJuT+z1vSMrbwTiRRq4Gi90HlB2JUB1l+p6AXreHSemCAsEccUixZatYU5JlT46SHnLmk/SnijXfxvJlV0F5beuFYlVQZOAGJL4sM3gcTP/N4LTsdahHg5Qblyd9l0He4yOfZ57zOUClAAGdsdQPkfj3U4W+YOk6NR9GTx89U2yD1nx28o9IeOL76VdXxJt9So3MVPpt5GLq3uQVuXg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1gQFfY2t396L6hNff6hEfdCdFQEnDCW6uEEb70wyU/s=;
 b=UZTedu8yTf+3yGHqcfZO6JfcNMBaOZ2aWcQrMavcwUbwwo84yN32wNbR+ze4p4pJVeJZnvh+HzTPnYMa+VMkqQywmmhdlqSsdWToVktanPbqUPGb+XZ+5gpOAxSCZikG2U8+H6blaTtGi4gEHX0FvQ6xmpI6NkuGZD4xvR3db9E=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bobby Eshleman <bobby.eshleman@gmail.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c
Thread-Topic: [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c
Thread-Index: AQHYVMDYNMJuqSTXg0Gj9wXP4qElXaz6V7UAgABJhoA=
Date: Thu, 21 Apr 2022 17:29:35 +0000
Message-ID: <c7feeb73-78fb-136e-2dac-4a3f87e0ae93@citrix.com>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-3-andrew.cooper3@citrix.com>
 <bb1961c1-af89-0220-6328-aa8cb98a1d84@suse.com>
In-Reply-To: <bb1961c1-af89-0220-6328-aa8cb98a1d84@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1cd37b02-554e-4e6b-793a-08da23bc814f
x-ms-traffictypediagnostic: DM6PR03MB4988:EE_
x-microsoft-antispam-prvs:
 <DM6PR03MB4988E578571A51F52C4C660DBAF49@DM6PR03MB4988.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 zL37tbrHkpmN+eMV1cPElsYQ3NDvx0bkiwX0J3l7lDGGN+hflSBSMvp4ibc3fXNom1DCCsKw+XxeT70Z7AuXzGlFYhOj5Qillc2re65zXPChamyizaMS0GOzOZKbZlKyV8m+JnXblvbDBxElnntxC4YlJteP0Lb8nqLu+cjkrsyCKKlhJ6OE7EtHsnWpykKPpXxVq17ZnmxUXNAg7kcu65SiRi/9PF+rJNsS1eiFTVaZAvf6ymnKdlzFbLSqVdu90ph7VXYOENRgs807Cm62A5LXuljBHpKDLc/hwq/g0lR7MC8zw8dTGg/s7sy7QAx/c/SZAdWZ9n/QRxK14c5j1N/+wTqziSwJPdbgbDKuvhEfHLLbvx0rL7i9TtDfifwtD6wgrF1lQWG440acaOfi+hLVU7y1E7xiQqEP9BquekgWOdyAWIdaBq5oeSVtcSAYGXRFj+BtkGES5nFaAxMox118I2+IKHq6VseePTvPvWNfzRhCANXAbYzAc8EWvgCLVZznZdmtZhgM09ImGkc/biHo0Lf4tSXeLvhxIPQOAropFXD0Po4Iik/pgWEvqFnY7/9lB58y0njaYiLaq4lkagcSkA/RiI4IT/Tzv2QiBUX6egMtS8RLSmzbiuDSXSeZWfZtH1t/9POq37BdRlpC37OVBZfMVV1m8ZRwzv4A8lv3Zc7foR3U7fmZh2T8Nc/G5u5IsdiFYRodfJx7+riMobNz+BVNyyW+oUgajCuU9yfM+fmgSTKiTVncop/S7/9eLEe0bN1BzZm4zVyUaLfbevMUrt3kT76xEKPeBFYs8LbVFAjafUzyjDPRk7IM1YIabbpMO+A9W/hhqiGdBQfAUB+PJLZsROUJsPzE4IpATWU=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(508600001)(6486002)(6916009)(54906003)(6512007)(71200400001)(6506007)(2616005)(53546011)(66946007)(36756003)(316002)(966005)(91956017)(86362001)(186003)(76116006)(31686004)(64756008)(8936002)(8676002)(5660300002)(82960400001)(122000001)(2906002)(66476007)(38070700005)(4326008)(66446008)(66556008)(38100700002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MWJxNUVLZmZ6UTNzU2JUdC80UkNuVm9rUm9YekN6TEd6Ym9pNmVBVnZ3YzJK?=
 =?utf-8?B?Y0JmQXVFbWhpZ21GMyt0TUhlWVFIUlhYYWVpeXpTODY2TDd2UU9NUmFZZ2Yx?=
 =?utf-8?B?dncwSTA1SUhLK2dZdlRtTy9WdEQ4aUhRWUFLTDBvTVFjeGhUZ2FNUkJLSjA3?=
 =?utf-8?B?bzBPSWdUOVRlOWVnNVBpRkJ6aysvbWlqZDBOWktOTnFLZUQvRUlBUHB4YmxR?=
 =?utf-8?B?WkxsdW40QklNN2NNeDlpTEsycUZXOGFTQ0x4L0dncnVMUGE3czk0am5PK3NG?=
 =?utf-8?B?K1JmcFpNRXJMSTAweE9rSXJ4UWpYSk8vNGEyRVN2RGVnMWVPZVcwUHlnMHdu?=
 =?utf-8?B?WkNYRVRHdWxPYUF0SElnRDZDanN6YWpYRUk0WWFMdy9RNTF4bE8wSG42Ymd6?=
 =?utf-8?B?OVJZaFd2QUdtODJCRzlBTjFRVmM3MmlYaDRML2tPZHJxazhqT2JUVWtuQjlL?=
 =?utf-8?B?UnB2MldXZGFNaW0rVFlZdzlHTCsyclVRSzNTWm9sR0t4NCswVVI4SzNlRWlM?=
 =?utf-8?B?anFVWEtFaHRMTEJ4L2l2M2VsRFF4UXpvbGdodEpkZVYwNExIYnF1Ym4vL2pX?=
 =?utf-8?B?SGl1dVZVc1YzYkpKZ0pUZ0tJQ2dmdlNFRzd2Z25iYzhFTlBuRkpjNGtSTktM?=
 =?utf-8?B?OUJ4ZVBRRXg5ZmE4NVdjc0FJQ3FJRFdhSGJ5S05tV1AvVm45YkRjMnh1RkU2?=
 =?utf-8?B?Z09XVEt1blUzUnpnc1hHclV2NWtQLzh0bmFkbzlyVEEvcmhlaDRaS3A5OXpv?=
 =?utf-8?B?cWI1WUk4Mi9ONU9oS3IvZXIxZEN4MnFrWlJmQzNMRzk1Qzg2ZUVrRU1uRzBr?=
 =?utf-8?B?akRqYjlvQ1FScWVDRWdIRUpKVHljSEpmV2JGQ1R2Z2NZNnZkYi9VenlaYkdV?=
 =?utf-8?B?UkIvbmNibGhxaHZjd0xmRndJT2tYVDhmMW9sNWhndHpxN1BZZUFqV290dEtz?=
 =?utf-8?B?dU9wT2czUXJxZURVZkQxRlVVMTdmRjR0K0pOSUtjb3NtcHRLMVh5UjZYTWx0?=
 =?utf-8?B?YXc5aEJmN0pwZFE2MnNwRlJpWGZlRGg3OUU2RUtvTndKWkYyelVrcTFWRDF3?=
 =?utf-8?B?bHd4UTZMcDB0cmR6bmhPdDlWOCs2eDIrMTZhSnpyNDJmMWpNWUMrNDcxdkxK?=
 =?utf-8?B?K1NpZ2lMaGM0LzJubm5RQzhzeTBGUVlsZWhWTnR2UEZnUGtCWFNBMnFnV1ll?=
 =?utf-8?B?cFpwSTgrU0o3QkQwSFlsU0p5eUx5YnNVdHRKZTFodS9iRzJqcVRFS2RMZmln?=
 =?utf-8?B?TTlSUVJCNFZkSUlqSU5WMjFnY1JXc2FIYks1Y05iTmt5Ry9Ld3RiM0k0Rm94?=
 =?utf-8?B?MWNjbDBxd0t0YkxncWpGSFBPQXlXSXFjT1F0MHZyZlM1Yll4NTUvY1JQM1BV?=
 =?utf-8?B?QkhOV3N0bVpkTFRpSnJ4V0U3QStFODdjSkNFdmxESUZLWmpxd2xUa2NlbGlF?=
 =?utf-8?B?dHJ3Q0tyVEJudU13Um5BYksvcDd2bk5vQlRNaEhBNEdhRXZQVHZYSkg5L2h3?=
 =?utf-8?B?UHQvVVZqL01MbzRJckp6eitkdVhHMTlDbXdLOEQzSjFvWDl2cDJwWmNuL2pL?=
 =?utf-8?B?Tk9hcFFoc2d5UGxja25GazlQcm5hL3RxOTBMUUY4WGFreGdiR0ZlaGZ1SGhw?=
 =?utf-8?B?ZFhVcUxTTWxnZFFKWGRSRFA1THRiOEJKYWNraDB4YktMMzh0R1Fob0pKMGln?=
 =?utf-8?B?SVRiVGdMSlNPWC9lcW5HVzZjQm1TVTZ6aFFJQTZwTERydUpjOTNVRmFoeTRY?=
 =?utf-8?B?RXppTHUrMHVqbnBFdGdrMEFCTjZQR1RnL3N6SWI0VUw5ZTB3Zm5uY2dPZWg2?=
 =?utf-8?B?U1RSNkxHUkFuMjR4dmI5Uy9MeWlhM1NKR2VleDhWRUlDVzBUVkkxZWNINlMv?=
 =?utf-8?B?S1BrY1o1R1RBSjFrbTZZcnV3UHRGV21laWpUNTNUM2FrYVpIdjB2cU9mMExk?=
 =?utf-8?B?aG11UW1uTUUrT0gybDVMZzBTb29LL0pYWklKWGc3SC96QVV5ZE5NNkU1d1RJ?=
 =?utf-8?B?ZUNSbGtRM1RKTjA5WEx1ZTQxTlhXTDQ2eVZCaDlYdmxxcXEvZFFwWkRHYmRz?=
 =?utf-8?B?bkpuYVVOSGZZRy9Xc242a1ZwVlhGN0VOVmJnSjc0bGx6UWlIT3ZvVXAxNGxK?=
 =?utf-8?B?MlRjZk5KRDBGK0RqYXBmZFNyTE1LYU9yVUNMSU1kazV0V0dnQnRHdTB3SExC?=
 =?utf-8?B?UW14WUJlOGVnZGswbW9vTVRqcXZDOHhueDd2b20zYVhKU3lUV01wVStpZzJP?=
 =?utf-8?B?NE5KM2VSdlhRaDF0bXdBMmNFWHU1am1nSzF5eG12YzVuc29Ca1dtckFiT3hy?=
 =?utf-8?B?bnJYZXp6WFBFV1dCZFhmaDVqYWhDOFVEMm96a1F0N2hYYTNNV0QwUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <8AEE7DB5C0B3F54B98750BDBE31652F5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd37b02-554e-4e6b-793a-08da23bc814f
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 17:29:35.6170
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Dp8b+uOFWY9xTQKl+F1sClOabquVRRydWr2lzL7NvIJkNEcbHt3ArXrtNzmky/1vTL5v4jOZ4pE66xMv+ky+Kci0Iz1VUGbLVDmqVvw/UtE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4988

T24gMjEvMDQvMjAyMiAxNDowNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIwLjA0LjIwMjIg
MTY6MTMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBGcm9tOiBCb2JieSBFc2hsZW1hbiA8Ym9i
YnkuZXNobGVtYW5AZ21haWwuY29tPg0KPj4NCj4+IGRlYnVnLmMgY29udGFpbnMgb25seSBkYmdf
cndfbWVtKCkuICBSZW5hbWUgaXQgdG8gZ2Ric3guYy4NCj4+DQo+PiBNb3ZlIGdkYnN4X2d1ZXN0
X21lbV9pbygpLCBhbmQgdGhlIHByaW9yIHNldHVwIG9mIGlvcC0+cmVtYWluLCBmcm9tIGRvbWN0
bC5jDQo+PiB0byBnZGJzeC5jLCBtZXJnaW5nIGl0IHdpdGggZGJnX3J3X21lbSgpLg0KPj4NCj4+
IFNpZ25lZC1vZmYtYnk6IEJvYmJ5IEVzaGxlbWFuIDxib2JieS5lc2hsZW1hbkBnbWFpbC5jb20+
DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXgu
Y29tPg0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpU
aGFua3MuDQoNCj4NCj4+IFRoZSBzZW1hbnRpY3MgYXJlIHJhdGhlciBicm9rZW4uICBYRU5fRE9N
Q1RMX2dkYnN4X2d1ZXN0bWVtaW8gb25seSBzZXRzDQo+PiBjb3B5YmFjayB3aGVuIHRoZXJlJ3Mg
bm90aGluZyB0byBjb3B5IGJhY2ssIGFuZCBza2lwcyBjb3B5aW5nIGJhY2sgaW4gdGhlDQo+PiAt
RUZBVUxUIGNhc2Ugd2hlbiB0aGUgaW9wLT5yZW1haW4gZmllbGQgaXMgcmVsZXZhbnQuICBGdXJ0
aGVybW9yZSwgaXQgY2FuIGJlDQo+PiBhc2tlZCB0byBtb3ZlIHVwIHRvIDRHQiBpbiBvbmUgZ28s
IHdpdGggbm8gY29udGludWFiaWxpdHkgd2hhdHNvZXZlci4NCj4gVGhlIGxhc3QgcG9pbnQgcGVy
aGFwcyBpc24ndCBvdmVybHkgbXVjaCBvZiBhIHByb2JsZW0gZm9yIHRoaXMgc3BlY2lmaWMNCj4g
b3BlcmF0aW9uLg0KDQpJdCdzIGFsc28gbm90IHRlcnJpYmx5IGhhcmQgdG8gZml4LCBidXQgSSBy
ZWFsbHkgZG9uJ3QgaGF2ZSB0aW1lIHRvIGdldA0KYm9nZ2VkIGRvd24gaW4gIm1ha2UgdGhlIGdk
YnN4IGh5cGVyY2FsbHMgc2FuZSIuwqANClhFTl9ET01DVExfZ2Ric3hfZG9tc3RhdHVzIGlzIGEg
ZGlzYXN0ZXIsIGFuZCB0aGVyZSBhcmUgZmFyIGJldHRlciB3YXlzDQpvZiBkb2luZyB0aGlzLsKg
IGh0dHBzOi8vd3d3LnlvdXR1YmUuY29tL3dhdGNoP3Y9b3NaZWlvWUtzeEEgaXMgb25lIHdoaWNo
DQp3YXMgcHJlc2VudGVkIGF0IFhlblN1bW1pdCBpbiAyMDE5Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 17:46:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 17:46:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310387.527206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhasH-0006cz-5r; Thu, 21 Apr 2022 17:45:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310387.527206; Thu, 21 Apr 2022 17:45:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhasH-0006cs-28; Thu, 21 Apr 2022 17:45:49 +0000
Received: by outflank-mailman (input) for mailman id 310387;
 Thu, 21 Apr 2022 17:45:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Mw+u=U7=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nhasG-0006cm-E3
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 17:45:48 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20617.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::617])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df9a32ec-c19a-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 19:45:47 +0200 (CEST)
Received: from AS8P250CA0021.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::26)
 by AS8PR08MB7813.eurprd08.prod.outlook.com (2603:10a6:20b:52c::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 17:45:43 +0000
Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:330:cafe::e8) by AS8P250CA0021.outlook.office365.com
 (2603:10a6:20b:330::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Thu, 21 Apr 2022 17:45:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 17:45:42 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Thu, 21 Apr 2022 17:45:42 +0000
Received: from 9e203bf1a824.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2F5636AF-EBA8-43B7-9628-F73BA0884A94.1; 
 Thu, 21 Apr 2022 17:45:35 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9e203bf1a824.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Apr 2022 17:45:35 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by GV1PR08MB7705.eurprd08.prod.outlook.com
 (2603:10a6:150:50::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 17:45:33 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 17:45:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df9a32ec-c19a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=03t4vCHpSQTztr1WldDOWGW9sRhZpaD3oNd4i4lVIZg=;
 b=qzZf01zhwBRJrx8wx0Pr1yKMveXhaEJXGc95+4OTRaaCMFkO0TFlqTJTF5022ShnSC5CoqX/Pf0ucPr3Y9r6akl0t3B+ikaOxIv5OLXKSBh7RvNeA3o1lR6AM989zmW/H9KcLXYdYrJd2Ch7aqJyj40thpMUPQc+fDPWpupa3Yc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f1f2ba887ec4e7fd
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RspjWtg8/rwRQlQ2MJbiZu1Dt16uiI7rVCzsCoRxcyTitf+54jHvJNvv7RYVo/XQuBPMz9x6Rej/9z9/9smaQ5SmSxzGerSPQtb4N88gGQCmuQR6ZkW5w0LjWrQsIzhshmWAJBG9EeZN8SFeIe8I5RDrx1z+OpAYch+BlJ7HwWOTqRJOQCIdU6528UwtPUmUCRzCiNnfzmiftJWYu7cIf9+kaajxSeM8l/glHj15keSovHrn0xD3a+ZgpjYCJiLvY79f9Jt3a186L5VwfYGAow134J4Rg44bOgsNQlIvqMfpgFEbn2LS3E3ILHa9UU6FhCW6ur9farp/DqrcBP6z5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=03t4vCHpSQTztr1WldDOWGW9sRhZpaD3oNd4i4lVIZg=;
 b=ZjQrQo79+/C7kPeGKI1rz+P6Jfzabp9yXVmRxp1Gdb98j1Aa9imSf5SrBjya7oezVg0gXRkp0KRYcsFQT9j1eBTfZJYqEUUMYBpF0XBVDW/prIw1pPx7/0R+9l99Q2Op7ObYJAvv8LTwQdenjuQG/GJy2lQr9M4B3kyRLBqg0i0Y9fV68YMmI3Xz0fO5AK7SmZcGipLUjxVm1h7cJhlmSUJaypTPAy7HS6mS0ZC6CKipkeXdrdAoZCmkv26GiMNOclpeVLZZnLqqFOrdzRmhP/54xxb+/q0VGzefwjb5mRZeyQUsYBPI37mk/4jWbgB/4fDkELeMTzgtWirxCs+08A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=03t4vCHpSQTztr1WldDOWGW9sRhZpaD3oNd4i4lVIZg=;
 b=qzZf01zhwBRJrx8wx0Pr1yKMveXhaEJXGc95+4OTRaaCMFkO0TFlqTJTF5022ShnSC5CoqX/Pf0ucPr3Y9r6akl0t3B+ikaOxIv5OLXKSBh7RvNeA3o1lR6AM989zmW/H9KcLXYdYrJd2Ch7aqJyj40thpMUPQc+fDPWpupa3Yc=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Christoph Hellwig <hch@lst.de>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Jan Beulich
	<jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Topic: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Index:
 AQHYTzcUggEUWxM2006iot1qnYxlIKzuW0oAgAFU1ACAADDmgIAApv+AgAC5dQCAAp7ugIACQDIAgAEmAYCAANnhAIAAjguAgADEGACAAT4mAA==
Date: Thu, 21 Apr 2022 17:45:32 +0000
Message-ID: <12279FAE-2141-469E-A424-9984348E84BB@arm.com>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com>
 <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop>
 <8C511888-6183-421E-A4C7-B271DAF46696@arm.com>
 <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de>
 <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
 <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
 <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
 <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop>
 <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com>
 <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 56e15cb1-d130-46be-03cb-08da23bec1da
x-ms-traffictypediagnostic:
	GV1PR08MB7705:EE_|VE1EUR03FT010:EE_|AS8PR08MB7813:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB7813EF8A525EAFD53EB42F9AFCF49@AS8PR08MB7813.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DcejZwG+QZndpBsikkym6ESBo3Wf0SV8OoT7N91XsIoWpp5yOXv2w62YzP8/lQZZ3jylGUTtasiYmrVrOMxXJAJjUN2cagXUtR7wif2Yc5zeVo5DvKWLt1ve/aDFsVRZoBdEPICeMZN1vwgqYfHmO8Gp3DyIY6DAhKPSMQ+5HrWuY9o1eUs4MpifwQimIfwWLBcM2f05zKAKTlQDhu4l629kvhbbymoerwGIMbVtCXzYWsCeDhdSBV7Ij19EThE9UnMWosbHwry0AI8nViAB4wjwO4kunVgFQDtcc6DzVl2JqfyCbCklHOPkwLKWHtQngQexMifVwBuBOzIaedswP6T1aQfKhag9si4BJKfrX8lVLcgDny/W4NjRA77KOffEeicJ97dx2f2s713Z5Fq0WFJ7taZfLcc41aFHNwSofAa/cuiXgIbsnj63eSE3b+1NOnVR+aMLwhyEnT4VjI+Dl7Slka2fsoS2SbCQvW3p7EDE6l/ZTRouxlkOG1/fKI+VbAeYspWnq3QnA5dgTwC2isDURceC2RcDgoyIwjgSQPrJVBuRjSjgYfNxVK6dQJphZ13BAr/8hcegQxBlzneZE3ImV38dxOcEXwW5ZZUeEUMjyoN3zq0D4zNTDDPSwXU8vrUQ4hoURggU1cSgkaPhsxbH2znx4bJmb+8DW6SoAaM5rLm4h32GJFU4E8oMZKMZqN9X58Kr2cCnotvto5h5RryUx4OF2HM4OvutvX6+67KiDJ5VGu1rARQhRXX1IwRosg8HnHg848Iy//GFPbedonV5NX10hiH6W411/Fo2AlcxE6sPuMIgB/tUd195LYje2YkvfQiDfdw/E3RoB6zApg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8676002)(316002)(36756003)(5660300002)(8936002)(83380400001)(71200400001)(33656002)(6506007)(26005)(64756008)(6512007)(53546011)(86362001)(2906002)(91956017)(186003)(2616005)(66476007)(6916009)(66446008)(66556008)(54906003)(66946007)(76116006)(38100700002)(6486002)(966005)(122000001)(508600001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <DA3CBB9F383945479FD2881148A15101@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7705
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9c8ace39-a7e8-4860-0e46-08da23bebbd3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Z2OBpS0Fwrh26ib7GDEpC/ZApx+1XHUEjcIBbTKhJmQaerEbyA7pZ8x8Dg+Ikn02fYylVVj8KreMShfssgNTcWQJFwc0mIrOFo+QWtuTwPUL2jLTZ7/fRMGUUp0sg3BBNW9R+COhzzZJT5eo1Sh1IAiGyPanaJdynJHz3qgDwcHsGg/6V2t+2PUfh0BKV8atu+saYhVD7GoBumqe2mC3Xs6CwbZYeGkKqZ2ZVEDwIX4jH5IVBFzHZw5kNPe6pkrPYzcxFIL0m/dMt6lK4+4+uMnvKn01hsCGailGRIhipRnAfgmK1WVHawkWQiGwFs2NogXBRr7N8Q7pX95GFJTlt4ALojumx4OAU1RIQwbPBL9tRBUvZQADtXmAQMGkVVsyQTVcMm6VrWYcFaYrhg2tADBzwwzxNnjF+1BtviyfNdyCfxFpuu7KzC2VfFqEvkmrWfBuYp5/k5WgfRvTRwl/WnKtQBe7ZVKEUuCD8qsCd16XKZ8QXLJOf7lKk9WdM5zLXHLn9JhbdGjlmhShQ60kP9IW4E4aPtkTw7srTv/WPvIKRmW6SMg803PdEDBDZnb85SJADM6g8wZtXzrGboPvy0apOOdovFM+TiVjsPQgqPfEPZwWs+OUaDS0Hc7beWqbaXKaBzroOLUh+lAYIDnuzDDTd26KbuPJreoAD59Vd3oMrEt39s/d5cfgbtHrXDwQgYlX493GDhsPvJ3VE4NSHBFDDXCYSR/kPRPNY6CWk+oWDCmT4n2O6WiL96dVb7N2G08MSm0jKt3xfwPtK74EaQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(54906003)(8936002)(86362001)(4326008)(8676002)(316002)(6862004)(186003)(26005)(107886003)(40460700003)(70206006)(2616005)(47076005)(70586007)(33656002)(81166007)(5660300002)(356005)(36860700001)(6512007)(966005)(2906002)(6506007)(82310400005)(508600001)(36756003)(53546011)(336012)(6486002)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 17:45:42.7989
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 56e15cb1-d130-46be-03cb-08da23bec1da
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7813

SGkgU3RlZmFubywNCg0KPiBPbiAyMCBBcHIgMjAyMiwgYXQgMTE6NDYgcG0sIFN0ZWZhbm8gU3Rh
YmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIDIw
IEFwciAyMDIyLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+PiBPbiAyMCBBcHIgMjAyMiwgYXQgMzoz
NiBhbSwgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToN
Cj4+Pj4+IFRoZW4gdGhlcmUgaXMgeGVuX3N3aW90bGJfaW5pdCgpIHdoaWNoIGFsbG9jYXRlcyBz
b21lIG1lbW9yeSBmb3INCj4+Pj4+IHN3aW90bGIteGVuIGF0IGJvb3QuIEl0IGNvdWxkIGxvd2Vy
IHRoZSB0b3RhbCBhbW91bnQgb2YgbWVtb3J5DQo+Pj4+PiBhdmFpbGFibGUsIGJ1dCBpZiB5b3Ug
ZGlzYWJsZWQgc3dpb3RsYi14ZW4gbGlrZSBJIHN1Z2dlc3RlZCwNCj4+Pj4+IHhlbl9zd2lvdGxi
X2luaXQoKSBzdGlsbCBzaG91bGQgZ2V0IGNhbGxlZCBhbmQgZXhlY3V0ZWQgYW55d2F5IGF0IGJv
b3QNCj4+Pj4+IChpdCBpcyBjYWxsZWQgZnJvbSBhcmNoL2FybS94ZW4vbW0uYzp4ZW5fbW1faW5p
dCkuIFNvIHhlbl9zd2lvdGxiX2luaXQoKQ0KPj4+Pj4gc2hvdWxkbid0IGJlIHRoZSBvbmUgY2F1
c2luZyBwcm9ibGVtcy4NCj4+Pj4+IA0KPj4+Pj4gVGhhdCdzIGl0IC0tIHRoZXJlIGlzIG5vdGhp
bmcgZWxzZSBpbiBzd2lvdGxiLXhlbiB0aGF0IEkgY2FuIHRoaW5rIG9mLg0KPj4+Pj4gDQo+Pj4+
PiBJIGRvbid0IGhhdmUgYW55IGdvb2QgaWRlYXMsIHNvIEkgd291bGQgb25seSBzdWdnZXN0IHRv
IGFkZCBtb3JlIHByaW50a3MNCj4+Pj4+IGFuZCByZXBvcnQgdGhlIHJlc3VsdHMsIGZvciBpbnN0
YW5jZToNCj4+Pj4gDQo+Pj4+IEFzIHN1Z2dlc3RlZCBJIGFkZGVkIHRoZSBtb3JlIHByaW50a3Mg
YnV0IG9ubHkgZGlmZmVyZW5jZSBJIHNlZSBpcyB0aGUgc2l6ZSBhcGFydA0KPj4+PiBmcm9tIHRo
YXQgZXZlcnl0aGluZyBsb29rcyBzYW1lIC4NCj4+Pj4gDQo+Pj4+IFBsZWFzZSBmaW5kIHRoZSBh
dHRhY2hlZCBsb2dzIGZvciB4ZW4gYW5kIG5hdGl2ZSBsaW51eCBib290Lg0KPj4+IA0KPj4+IE9u
ZSBkaWZmZXJlbmNlIGlzIHRoYXQgdGhlIG9yZGVyIG9mIHRoZSBhbGxvY2F0aW9ucyBpcyBzaWdu
aWZpY2FudGx5DQo+Pj4gZGlmZmVyZW50IGFmdGVyIHRoZSBmaXJzdCAzIGFsbG9jYXRpb25zLiBJ
dCBpcyB2ZXJ5IHVubGlrZWx5IGJ1dA0KPj4+IHBvc3NpYmxlIHRoYXQgdGhpcyBpcyBhbiB1bnJl
bGF0ZWQgY29uY3VycmVuY3kgYnVnIHRoYXQgb25seSBvY2N1cnMgb24NCj4+PiBYZW4uIEkgZG91
YnQgaXQuDQo+PiANCj4+IEkgYW0gbm90IHN1cmUgYnV0IGp1c3QgdG8gY29uZmlybSB3aXRoIHlv
dSwgSSBzZWUgYmVsb3cgbG9ncyBpbiBldmVyeSBzY2VuYXJpby4NCj4+IFNXSU9UTEIgbWVtb3J5
IGFsbG9jYXRlZCBieSBsaW51eCBzd2lvdGxiIGFuZCB1c2VkIGJ5IHhlbi1zd2lvdGxiLiBJcyB0
aGF0IG9rYXkgb3IgaXQgY2FuIGNhdXNlIHNvbWUgaXNzdWUuDQo+PiANCj4+IFsgICAgMC4wMDAw
MDBdIG1lbSBhdXRvLWluaXQ6IHN0YWNrOm9mZiwgaGVhcCBhbGxvYzpvZmYsIGhlYXAgZnJlZTpv
ZmYNCj4+IFsgICAgMC4wMDAwMDBdIHNvZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgwMDAw
MDAwMGY0MDAwMDAwLTB4MDAwMDAwMDBmODAwMDAwMF0gKDY0TUIpDQo+PiANCj4+IHNuaXAgZnJv
bSBpbnQgX19yZWYgeGVuX3N3aW90bGJfaW5pdChpbnQgdmVyYm9zZSwgYm9vbCBlYXJseSkNCj4+
IC8qICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIA0KPj4gICAgICAqIElPIFRMQiBtZW1vcnkgYWxyZWFkeSBhbGxv
Y2F0ZWQuIEp1c3QgdXNlIGl0LiAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KPj4gICAgICAq
LyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIA0KPj4gICAgIGlmIChpb190bGJfc3RhcnQgIT0gMCkgeyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KPj4gICAgICAgICB4
ZW5faW9fdGxiX3N0YXJ0ID0gcGh5c190b192aXJ0KGlvX3RsYl9zdGFydCk7ICAgICAgICAgICAg
ICAgICAgICAgICAgIA0KPj4gICAgICAgICBnb3RvIGVuZDsgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KPj4gICAgIH0NCj4gDQo+
IFVuZm9ydHVuYXRlbHkgdGhlcmUgaXMgbm90aGluZyBvYnZpb3VzIGluIHRoZSBsb2dzLiBJIHRo
aW5rIHdlIG5lZWQgdG8NCj4gbG9vayBhdCB0aGUgaW4tZGV0YWlscyBleGVjdXRpb25zIG9mIExp
bnV4IG9uIFhlbiB3aXRoIHN3aW90bGIteGVuIGFuZA0KPiBMaW51eCBvbiBYZW4gd2l0aG91dCBz
d2lvdGxiLXhlbi4gVGhlIGNvbXBhcmlzb24gd2l0aCBMaW51eCBvbiBuYXRpdmUgaXMNCj4gbm90
IHZlcnkgaW50ZXJlc3RpbmcgYmVjYXVzZSB0aGUgbWVtb3J5IGxheW91dCBpcyBhIGJpdCBkaWZm
ZXJlbnQuDQo+IA0KPiBUaGUgY29tcGFyaXNvbiBiZXR3ZWVuIHRoZSB0d28gZXhlY3V0aW9ucyBz
aG91bGQgYmUgc2ltcGxlIGJlY2F1c2UNCj4gc3dpb3RsYi14ZW4gc2hvdWxkIGJlIHRyYW5zcGFy
ZW50OiBpbiB0aGlzIHNpbXBsZSBjYXNlIHN3aW90bGIteGVuDQo+IHNob3VsZCBlbmQgdXAgY2Fs
bGluZyBhbHdheXMgdGhlIHNhbWUgZnVuY3Rpb25zIHRoYXQgd291bGQgZW5kIHVwIGJlaW5nDQo+
IGNhbGxlZCBhbnl3YXkgd2l0aG91dCBzd2lvdGxiLXhlbi4gQmFzaWNhbGx5LCBpdCBzaG91bGQg
b25seSBhZGQgYQ0KPiBjb3VwbGUgb2YgZXh0cmEgc3RlcHMgaW4gYmV0d2Vlbiwgbm90aGluZyBl
bHNlLg0KPiANCj4gQXMgd2UgaGF2ZSBhbHJlYWR5IGRpc2N1c3NlZDoNCj4gDQo+IC0gW25vIHN3
aW90bGIteGVuXSBkbWFfYWxsb2NfYXR0cnMgLS0+IGRtYV9kaXJlY3RfYWxsb2MNCj4gLSBbc3dp
b3RsYi14ZW5dIGRtYV9hbGxvY19hdHRycyAtLT4geGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQg
LS0+IGRtYV9kaXJlY3RfYWxsb2MNCj4gDQo+IFRoZSByZXN1bHQgc2hvdWxkIGJlIGlkZW50aWNh
bC4gSW4geGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQgdGhlIGNvZGUNCj4gcGF0aCB0YWtlbiBz
aG91bGQgYmU6DQo+IA0KPiAtIHhlbl9hbGxvY19jb2hlcmVudF9wYWdlcw0KPiAtIGlmICgoKGRl
dl9hZGRyICsgc2l6ZSAtIDEgPD0gZG1hX21hc2spKSAmJg0KPiAgICAgICFyYW5nZV9zdHJhZGRs
ZXNfcGFnZV9ib3VuZGFyeShwaHlzLCBzaXplKSkgew0KPiAgICAgICpkbWFfaGFuZGxlID0gZGV2
X2FkZHI7DQo+IC0gcmV0dXJuIHJldA0KPiANCj4gU28gYmFzaWNhbGx5LCBpdCBzaG91bGQgbWFr
ZSB6ZXJvIGRpZmZlcmVuY2UuIFRoYXQgaXMgZXhwZWN0ZWQgYmVjYXVzZQ0KPiBzd2lvdGxiLXhl
biByZWFsbHkgb25seSBjb21lcyBpbnRvIHBsYXkgZm9yIGRvbVUgcGFnZXMuIEZvciBib290aW5n
DQo+IGRvbTAsIGl0IHNob3VsZCBvbmx5IGJlIGEgInVzZWxlc3MiIGluZGlyZWN0aW9uLg0KPiAN
Cj4gSW4gdGhlIGNhc2Ugb2YgeGVuX3N3aW90bGJfbWFwX3BhZ2UsIGl0IHNob3VsZCBiZSBzaW1p
bGFyLiBUaGUgcGF0aA0KPiB0YWtlbiBzaG91bGQgYmU6DQo+IA0KPiAJaWYgKGRtYV9jYXBhYmxl
KGRldiwgZGV2X2FkZHIsIHNpemUsIHRydWUpICYmDQo+IAkgICAgIXJhbmdlX3N0cmFkZGxlc19w
YWdlX2JvdW5kYXJ5KHBoeXMsIHNpemUpICYmDQo+IAkJIXhlbl9hcmNoX25lZWRfc3dpb3RsYihk
ZXYsIHBoeXMsIGRldl9hZGRyKSAmJg0KPiAJCXN3aW90bGJfZm9yY2UgIT0gU1dJT1RMQl9GT1JD
RSkNCj4gCQlnb3RvIGRvbmU7DQo+IA0KPiB3aGljaCBJIHRoaW5rIHNob3VsZCBjb3JyZXNwb25k
IHRvIHRoaXMgcHJpbnRzIGluIHlvdXIgbG9ncyBhdCBsaW5lIDQwMDoNCj4gDQo+ICAgIERFQlVH
IHhlbl9zd2lvdGxiX21hcF9wYWdlIDQwMCBwaHlzPTgwMDAzYzRmMDAwIGRldl9hZGRyPTgwMDAz
YzRmMDAwDQo+IA0KPiBTbyB0aGF0IHNob3VsZCBiZSBPSyB0b28uIElmIGRpZmZlcmVudCBwYXRo
cyBhcmUgdGFrZW4sIHRoZW4gd2UgaGF2ZSBhDQo+IHByb2JsZW0uIElmIHRoZSBwYXRocyBhYm92
ZSBhcmUgdGFrZW4gdGhlcmUgc2hvdWxkIGJlIHplcm8gZGlmZmVyZW5jZQ0KPiBiZXR3ZWVuIHRo
ZSBzd2lvdGxiLXhlbiBhbmQgdGhlIG5vbi1zd2lvdGxiLXhlbiBjYXNlcy4NCj4gDQo+IFdoaWNo
IGJyaW5ncyBtZSB0byB5b3VyIHF1ZXN0aW9uIGFib3V0IHhlbl9zd2lvdGxiX2luaXQgYW5kIHRo
aXMNCj4gbWVzc2FnZToNCj4gDQo+ICAgIHNvZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgw
MDAwMDAwMGY0MDAwMDAwLTB4MDAwMDAwMDBmODAwMDAwMF0gKDY0TUIpDQo+IA0KPiBUaGUgc3dp
b3RsYi14ZW4gYnVmZmVyIHNob3VsZCAqbm90KiBiZSB1c2VkIGlmIHRoZSBjb2RlIHBhdGhzIHRh
a2VuIGFyZQ0KPiB0aGUgb25lcyBhYm92ZS4gU28gaXQgZG9lc24ndCBtYXR0ZXIgaWYgaXQgaXMg
YWxsb2NhdGVkIG9yIG5vdC4gWW91DQo+IGNvdWxkIGNvbW1lbnQgb3V0IHRoZSBjb2RlIGluIHhl
bl9zd2lvdGxiX2luaXQgYW5kIGV2ZXJ5dGhpbmcgc2hvdWxkDQo+IHN0aWxsIGJlaGF2ZSB0aGUg
c2FtZS4NCj4gDQo+IEZpbmFsbHksIG15IHN1Z2dlc3Rpb24uIENvbnNpZGVyaW5nIGFsbCB0aGUg
YWJvdmUsIEkgd291bGQgbG9vayAqdmVyeSoNCj4gY2xvc2VseSBhdCB0aGUgZXhlY3V0aW9uIG9m
IExpbnV4IG9uIFhlbiB3aXRoIGFuZCB3aXRob3V0IHN3aW90bGIteGVuLg0KPiBUaGUgZGlmZmVy
ZW5jZXMgc2hvdWxkIGJlIHJlYWxseSBtaW5pbWFsLiBBZGRzIHByaW50cyB0byBhbGwgdGhlDQo+
IHN3aW90bGIteGVuIGZ1bmN0aW9ucywgYnV0IHJlYWxseSBvbmx5IHRoZSBmb2xsb3dpbmcgc2hv
dWxkIG1hdHRlcjoNCj4gLSB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudA0KPiAtIHhlbl9zd2lv
dGxiX21hcF9wYWdlDQo+IC0geGVuX3N3aW90bGJfdW5tYXBfcGFnZQ0KPiANCj4gV2hhdCBhcmUg
dGhlIGRpZmZlcmVuY2VzIGJldHdlZW4gdGhlIHR3byBleGVjdXRpb25zPyBGcm9tIHRoZSBsb2dz
Og0KPiANCj4gLSB0aGUgYWxsb2NhdGlvbiBvZiB0aGUgc3dpb3RsYi14ZW4gYnVmZmVyIHdoaWNo
IGxlYWRzIHRvIDY0TUIgb2YgbGVzcw0KPiAgbWVtb3J5IGF2YWlsYWJsZSwgYnV0IGFjdHVhbGx5
IGlmIHlvdSBjb21wYXJlZCB0byBMaW51eCBvbiBYZW4NCj4gIHdpdGgvd2l0aG91dCBzd2lvdGxi
LXhlbiB0aGlzIGRpZmZlcmVudCB3b3VsZCBnbyBhd2F5IGJlY2F1c2UNCj4gIHhlbl9zd2lvdGxi
X2luaXQgd291bGQgYmUgY2FsbGVkIGluIGJvdGggY2FzZXMgYW55d2F5DQo+IA0KPiAtIHRoZSBz
aXplIHVwZ3JhZGUgaW4geGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQ6IEkgY2FuIHNlZSBzZXZl
cmFsDQo+ICBpbnN0YW5jZXMgb2YgdGhlIGFsbG9jYXRpb24gc2l6ZSBiZWluZyBpbmNyZWFzZWQu
IElzIHRoYXQgY2F1c2luZyB0aGUNCj4gIHByb2JsZW0/IEl0IHNlZW1zIHVubGlrZWx5IGFuZCB5
b3UgaGF2ZSBhbHJlYWR5IHZlcmlmaWVkIGl0IGlzIG5vdCB0aGUNCj4gIGNhc2UgYnkgcmVtb3Zp
bmcgdGhlIHNpemUgaW5jcmVhc2UgaW4geGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQNCj4gDQo+
IC0gV2hhdCBlbHNlIGlzIGRpZmZlcmVudD8gVGhlcmUgKm11c3QqIGJlIHNvbWV0aGluZywgYnV0
IGl0IGlzIG5vdA0KPiAgc2hvd2luZyBpbiB0aGUgbG9ncyBzbyBmYXIuDQo+IA0KPiANCj4gVGhl
IG9ubHkgb3RoZXIgb2JzZXJ2YXRpb24gdGhhdCBJIGhhdmUsIGJ1dCBpdCBkb2Vzbid0IGhlbHAs
IGlzIHRoYXQgdGhlDQo+IGZhaWx1cmUgaGFwcGVucyBvbiB0aGUgc2Vjb25kIDRNQiBhbGxvY2F0
aW9uIHdoZW4gdGhlcmUgaXMgYW5vdGhlcg0KPiBjb25jdXJyZW50IG1lbW9yeSBhbGxvY2F0aW9u
IG9mIDRLLiBOZWl0aGVyIHRoZSA0TUIgbm9yIHRoZSA0SyBhcmUNCj4gc2l6ZS11cGdyYWRlcyBi
eSB4ZW5fc3dpb3RsYl9hbGxvY19jb2hlcmVudC4NCj4gDQo+IDRNQiBpcyBhbiBsYXJnZXItdGhh
bi11c3VhbCBzaXplLCBidXQgaXQgc2hvdWxkbid0IG1ha2UgdGhhdCBtdWNoIG9mIGENCj4gZGlm
ZmVyZW5jZS4gSXMgdGhhdCBwcm9ibGVtIHRoYXQgdGhlIDRNQiBoYXZlIHRvIGJlIGNvbnRpZ3Vv
dXM/IEkgZG9uJ3QNCj4gc2VlIGhvdyBzd2lvdGxiLXhlbiBjb3VsZCBoYXZlIGFuIGltcGFjdCBp
biB0aGF0IHJlZ2FyZCwgaWYgbm90IGZvciB0aGUNCj4gc2l6ZSBpbmNyZWFzZSBpbiB4ZW5fc3dp
b3RsYl9hbGxvY19jb2hlcmVudC4NCj4gDQo+IFBsZWFzZSBsZXQgbWUga25vdyB3aGF0IHlvdSBm
aW5kLg0KDQpJIGRlYnVnIHRoZSBpc3N1ZSBtb3JlIHRvZGF5IGFuZCBmb3VuZCBvdXQgdGhhdCB0
aGUgb25seSBkaWZmZXJlbmNlIHdoZW4NCmNhbGxpbmcgZG1hX2FsbG9jX2F0dHJzKCkgZnJvbSB0
aGUgTlZNZSBkcml2ZXIgWzFdIGFuZCB0aGUgb3RoZXIgZHJpdmVyIGlzIHRoZQ0KYXR0cmlidXRl
IOKAnERNQV9BVFRSX05PX0tFUk5FTF9NQVBQSU5HIi4gDQoNCkkgcmVtb3ZlIHRoZSBhdHRyaWJ1
dGUgIkRNQV9BVFRSX05PX0tFUk5FTF9NQVBQSU5H4oCdIGJlZm9yZQ0KY2FsbGluZyB0aGUgeGVu
X2FsbG9jX2NvaGVyZW50X3BhZ2VzKCkgLCBOVk1lIERNQSBhbGxvY2F0aW9uIGlzIHN1Y2Nlc3Nm
dWwNCmFuZCB0aGUgaXNzdWUgaXMgbm90IG9ic2VydmVkLg0KDQpEbyB5b3UgaGF2ZSBhbnkgaWRl
YSB3aHkgYXR0cmlidXRlIERNQV9BVFRSX05PX0tFUk5FTF9NQVBQSU5HIGlzDQpjYXVzaW5nIHRo
ZSB0aGUgaXNzdWUgd2l0aCB4ZW4tc3dpb3RsYi4NCg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVu
L3N3aW90bGIteGVuLmMgYi9kcml2ZXJzL3hlbi9zd2lvdGxiLXhlbi5jDQppbmRleCAyYjM4NWMx
YjRhOTkuLjNjMTgzOTVkZDU2NyAxMDA2NDQNCi0tLSBhL2RyaXZlcnMveGVuL3N3aW90bGIteGVu
LmMNCisrKyBiL2RyaXZlcnMveGVuL3N3aW90bGIteGVuLmMNCkBAIC0yOTIsNiArMjkyLDggQEAg
eGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQoc3RydWN0IGRldmljZSAqaHdkZXYsIHNpemVfdCBz
aXplLA0KICAgICAgICAqLw0KICAgICAgICBmbGFncyAmPSB+KF9fR0ZQX0RNQSB8IF9fR0ZQX0hJ
R0hNRU0pOw0KIA0KKyAgICAgICBhdHRycyAmPSB+KERNQV9BVFRSX05PX0tFUk5FTF9NQVBQSU5H
KTsNCisNCiAgICAgICAgLyogQ29udmVydCB0aGUgc2l6ZSB0byBhY3R1YWxseSBhbGxvY2F0ZWQu
ICovDQogICAgICAgIHNpemUgPSAxVUwgPDwgKG9yZGVyICsgWEVOX1BBR0VfU0hJRlQpOw0KIA0K
QEAgLTM1OSw2ICszNjEsOCBAQCB4ZW5fc3dpb3RsYl9mcmVlX2NvaGVyZW50KHN0cnVjdCBkZXZp
Y2UgKmh3ZGV2LCBzaXplX3Qgc2l6ZSwgdm9pZCAqdmFkZHIsDQogICAgICAgICAgICBUZXN0Q2xl
YXJQYWdlWGVuUmVtYXBwZWQocGFnZSkpDQogICAgICAgICAgICAgICAgeGVuX2Rlc3Ryb3lfY29u
dGlndW91c19yZWdpb24ocGh5cywgb3JkZXIpOw0KIA0KKyAgICAgICBhdHRycyAmPSB+KERNQV9B
VFRSX05PX0tFUk5FTF9NQVBQSU5HKTsNCisNCiAgICAgICAgeGVuX2ZyZWVfY29oZXJlbnRfcGFn
ZXMoaHdkZXYsIHNpemUsIHZhZGRyLCBwaHlzX3RvX2RtYShod2RldiwgcGh5cyksDQogICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGF0dHJzKTsNCiB9DQoNClsxXSBodHRwczovL2dpdC5r
ZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJl
ZS9kcml2ZXJzL252bWUvaG9zdC9wY2kuYyNuMjA1Mw0KDQpSZWdhcmRzLA0KUmFodWwNCg0K


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 17:47:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 17:47:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310393.527217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhauC-0007Hl-MD; Thu, 21 Apr 2022 17:47:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310393.527217; Thu, 21 Apr 2022 17:47:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhauC-0007He-Iq; Thu, 21 Apr 2022 17:47:48 +0000
Received: by outflank-mailman (input) for mailman id 310393;
 Thu, 21 Apr 2022 17:47:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhauA-0007HW-N0
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 17:47:46 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 251bf6fa-c19b-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 19:47:44 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 13:47:40 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB4880.namprd03.prod.outlook.com (2603:10b6:208:107::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 17:47:37 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 17:47:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 251bf6fa-c19b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650563264;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=H2Qy3iqHX58/KgxoTbYDY4twNI1kkfoN3krCB9RNYNc=;
  b=WmItmNcUnCrUSNusPRMhYRbCm6rb693qxfiX4NlZvcFp8gU6uM4yGw6A
   DncPb/3pi1afXblvniVkdkOHFzu1OyMGx4UppSY4PMpPpWpbHx2Br5LbP
   +cBk1Tt4bevek2Zvr5eJjnsc9CTxEtjFCmXmM9gru2rBfl4+2dAbh/XFI
   Y=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 69639601
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:KiMbSa5qKgfKS7tcU5gbQQxRtM/GchMFZxGqfqrLsTDasY5as4F+v
 mAYXW/Xb/uPYzbyfYh3atmzoxkAvcPUzYdlTgtqryo2Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjWlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurTpQw0LPO7tmd42eBIDNyFAE7Nlyo7IdC3XXcy7lyUqclPK6tA3VgQTAtdd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfuUo4MEtNszrpkm8fL2T
 swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrL9PRssjaLlWSd1pDWc4Pyc+yUW/lpuUGW+
 3zL1WHUWxoFYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUUWkG8uuKRkVOlVpRUL
 El80jE1saE4+UivT9/8dx61uniJulgbQdU4O+8n7ACAzILE7gDfAXILJhZLZcY6rsYwSXov3
 0WQgtLyLTV1tfueTnf13omTqTS+KC0EN1gobCUPTRYGy9T7qYR1hRXKJv58FIalg9uzHiv/q
 xiSpTU6r6Uei4gMzarT1UDKhXegq4bESiYx5x7LRSS14wVhfomnaoe0r1/B4p59wJ2xS1CAu
 D0BhJKY5eVXV5WVznTRHKMKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj
 IbokVs5zPdu0LGCNMebv6rZ5xwW8JXd
IronPort-HdrOrdr: A9a23:NGv+GqlNjM+EVfv5VfNinaokfaHpDfN1iWdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee
 r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp
 gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e
 XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5
 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe
 q1NdZfH+LjRFGebLp04w==
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="69639601"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M2iOjDXtmHJoVDOLMraNLgDBrwr3L7a0BjFetHk9ea2j57biSyiZaoX673Zb2Nlm1REdckGMFDK/okhWymUl9V9IEwkbCxlDIPpHoxD7FNz39Ud/NiuxnVgBqn6Zj0DTHjW0P37rrL/RHc07j3lHpGlggsd7DQrmxKTR7skrS4jZ95lQqMWAOa5L+1qA7kvSt26pRpZbII0BMTzk0cqyhWsIuIZ2V/HTckk2nlk3oBPeXQcOblv7RnmBGTf58SH3tXjoslfp+0Qrtamk3KPTwhrk4oJ7Y4gph/gpBlUz00cQFDKySbXGciNsEjniZPDNofZgp0IQUgbJyiQ6e9C8ng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=H2Qy3iqHX58/KgxoTbYDY4twNI1kkfoN3krCB9RNYNc=;
 b=L2IlsobNDiJfbwWM4kDgEg2jGoD4R87vO4vHj07W/Fd3nUcmwudimY5LfXw6hJH2wLIwCc4Y8nNq88BSqtvuDcQiPIYJ2hV7haxdrUcEcsD5Jd5UhSW/0+CXFtBkagq5pRJahEQzeNtamSoF0cCb+eZnIPGFvJOgKk0uzmOLmJxhykYwTTwVoze8xefxyq4o+tJhJpV2O0gWOPyhRzrEd9uWaWZNcSPs0h2hTWiZKxBk+2dPpsjQfwzOZ4R29sWwIvoecSp+O8r5H+cPXfB5LxlFheb2QvFzF6YufOL9AaFDG+v20i0wfVSkY3GOuW/G7kcummAeaSbwgl+Ov4Hbew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=H2Qy3iqHX58/KgxoTbYDY4twNI1kkfoN3krCB9RNYNc=;
 b=n19x1AB3VsqMki6c+tOnR6zwk09P2m1fMl5mD8r0rV87G7VSEnWfPlxGDOA+aa3aezgkSBIvcxbMzPdg3+w3F80ev0anLiUZfa2WWNXNfp8r3eVYLq4SsEGAv7/zHLDHePCJdTYSxu3YJ+8oW2wufGGXqyMvcX7zgZm6QAxzTCY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, George Dunlap
	<George.Dunlap@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Paul Durrant <paul@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Thread-Topic: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Thread-Index: AQHYVHuOvzYJLKPprEuLadRqUVZq9az4UhqAgAAC1gCAAAFpgIACUHUA
Date: Thu, 21 Apr 2022 17:47:37 +0000
Message-ID: <7f55e68c-17ed-c682-9ba7-4835d8e1a79b@citrix.com>
References: <20220420055736.27901-1-jgross@suse.com>
 <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
 <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
 <74f6105d-d3a3-6508-3c6f-3aac53285c5f@suse.com>
In-Reply-To: <74f6105d-d3a3-6508-3c6f-3aac53285c5f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b40f6f8a-d34f-450a-7042-08da23bf0634
x-ms-traffictypediagnostic: MN2PR03MB4880:EE_
x-microsoft-antispam-prvs:
 <MN2PR03MB4880CB82740F916D305343F2BAF49@MN2PR03MB4880.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 7YgJ3FmqRV+gf1Nhq61Pu8YcHxWZYgbKTLIIX/ThR5Yvt/4EJL0nnZT7ySy6pAGoBnMk1MMx0qKs0ebeHGC7p8O1SMIwKy4+I5PTHkApTg8655u7jvP7oZW0Lss2elJp2xBvoN0ZvE6GZmV87g6JLisz1IPKt+JLwQbzroqCrApGFidErEsfXqnEac5GTDuI0jy5x7qp+LCKtG6kfcf6IrEw1lGly3XuesGOB4OrMDevdO37xIl+GpIT1rl4zsxGPovYCzQfxHbFRSHLXqV4UwfwpDXWMWbh93a5DEpIoIsqvQmM/3tAo40fAX6Xr2IjEE5Pzdq6FNERBmc8r+JiutvdoxMC40rfJ8uqDZec9/3l/COEU/x49KRkVJKpppRNzK49K/H0oTfdFdS9zABg7lMfXrTMUebGqb/y8BdrHUqQ6R+zpwCnkv3aYADTdkZIqc12nsLxMens7a639kQV4Fg6YoFevJIk9d3f4xXeynwYQxJe9vPaK1kukZhwBgWgSMXS+YMqSSZXzS1ZwOR68TERUTeWK4Ges3r9OPNBp+qO8fKPzgl22jtFjcU+dHHr+0LTRqky63TKjikrcKOmcjZrIGISvyRlvJR1XDOQibUyNdbJO65JBA+v65WFdursYc6JCM6eA8Iyp1oKREObs7ymY+OjTL1DZi4yPh7JU3dAmC1/gGa9uSIjmi0Biw5pcHux5TLoUQZc5OkHVErcUJDzbFqlwE41SuC41yo8ljwDOkz31csjcw2+7ZIE/i82uS4pcEM8NcKzMiaGRXksRQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(66476007)(38070700005)(6506007)(316002)(53546011)(508600001)(8676002)(66446008)(66556008)(2906002)(66946007)(76116006)(91956017)(4326008)(6486002)(6512007)(71200400001)(31696002)(86362001)(5660300002)(8936002)(36756003)(2616005)(110136005)(31686004)(54906003)(186003)(26005)(82960400001)(38100700002)(122000001)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Q3RvRzd6ZGJ2eUljbTdsZ05HSmhOVDRDWDkybFk1ZjFjNXZwNnZ3Tk02OG5n?=
 =?utf-8?B?TEVGelI5eVFsdng5ZEdBOHc0RktkYkFpbFZNZEthcSs5bmdhL2lkck85NkRk?=
 =?utf-8?B?My9CUFhmL2JNNkFZL3Nsdk9uMS8zU09VZUdFcDdQRkEyUTB6TU9kYksrRHo5?=
 =?utf-8?B?NHltbmk0K3YwRXAxVW9uNFk3eXZVNUlTZFlKUkZaQW5mRlA2QmM2S1haYmM3?=
 =?utf-8?B?RHNvWEpHNTlVN3hvKytlRkJ5VFR0a3BqRE16MGh2aE1KaDZUWjI0LzVPUFZY?=
 =?utf-8?B?NDBHVTVyR29hdnlnNVpCNmZoblpHT0ZXNGR0OU44NjZKazNqWUtmOGFtRWVX?=
 =?utf-8?B?b3VBdGdRREw0ZVM4ZnJ2SGNzeG43M0owRGNTcDk4RXA0MDZHdnYySmtDYkVE?=
 =?utf-8?B?M0Q2aGVlUVh2elJGMnEyVkFOOU0xcEFCb0hUSHVPaU1zakdmcWtWR3VtNUd6?=
 =?utf-8?B?QzhqSGh0N283QnVqVHN5cnFwZGZkNmJaVU91MExuc2o3SDBmcnBNbEZPQ0gw?=
 =?utf-8?B?b2c4R3ZPZkVuOTRXdEkxZytySFJZaE1Qb3Q3R1N2SHkvMDl4dk92NEczSmhp?=
 =?utf-8?B?dTJQMGEvU1FWczNzL1hRMEJodmRqKzRIRGx0SG5yN2tIWTdRSkczN2xZRGVK?=
 =?utf-8?B?MFF3Q2pITHp4eks3ak5yeFphSk9qTFJUUzd6TU5WQjllZ0Q1WS9xa0dMTEdH?=
 =?utf-8?B?QlNDTFYrMXN3V2ZudjI3VlZnQS9ZQjFWdGFnajBoeGFCOGFWVGxRS2lGNERm?=
 =?utf-8?B?M20wWEdLbEV5d1VkaHZHTFZVMHl6cVdaYXVxcjFaeEtkN0tpa3o2d0FqWm53?=
 =?utf-8?B?SG9qaVoyZ20yR3VnTGJGb3BUTnlSa0FtTTJiYWQ1SjFZSmw2VnR1RWRHMVkx?=
 =?utf-8?B?YURhQ0M1eFdGZnRiQTBtSE1xaGxxdk4rS2NxckpYOERFNUdFWVp2UkZybnFB?=
 =?utf-8?B?RHJ0bkhyWHVmenVWZ05HTTA1QTRDWVFnQ1E0U3NKamFITlRhTE84Y0lLVS8w?=
 =?utf-8?B?cjEvK2Y4U1BXSm05UmM5dEhDbGd6NDkwT0Z1QU5FMXpmNHl0SjhZS28wanpG?=
 =?utf-8?B?U0ZPUEd1RzY5Mm0rclNzTnJuMXpPaGw1Q3IydThzT3dyVTJtQUhYSXBaQWR1?=
 =?utf-8?B?Mld1N1VIdEd2ZFAzWHRleXVsM0g0cDdzL0l2MEFwUVREOUd4cGpMaXpMckx3?=
 =?utf-8?B?SHF5NUU1TEdXVW9TRENCKzBLS0xwOVViVFBlTUtEMUIxRFhMN1gzbjBEM1dr?=
 =?utf-8?B?NmY0NS9VTU1LWXNyR3JNOW1GL0E3Wld3allaUExXOTdSMjNPemQvNWhyMHZW?=
 =?utf-8?B?ckM2bjFsdUJ2Mm5FZk5hUkRXMDhxODl1QVVsa2p2K0pXdFNNTW5nWXdCZTI4?=
 =?utf-8?B?dmpsMVNvNmovem02OUtESmV4dVlXNVVUMWpZTUt5d1BnRExlV3pkd2o1SEVG?=
 =?utf-8?B?NDlacGpMV3VJR0ZGa3Irc3F1bVRGWWdrV3R4ZGNzTy9vU0tvWXVOcEp3N3dI?=
 =?utf-8?B?c1N4ZEFoZ1lnZkFtRlZWczhPems0MFE0a1VBTnpYRWNZOGRQcFZEMm9HV255?=
 =?utf-8?B?YWdEdlJYYXN2YVFNM2YwVlpXYzhPR1FkWnhHM2xmYTRZMXBNcUdNYm9Tai90?=
 =?utf-8?B?Q3lubi9GZUw2SFJseDhkdkFKMUcvUjYxMUs1WFdCZUNFTXRmMFdvV0FBTEJ6?=
 =?utf-8?B?SlRYMlprekl2MmplWm5RbTltRzdPckMxd1UrOW15R1F4UHZNYWgrVUd2MG0z?=
 =?utf-8?B?SmwzajhQR0d2dVFiREx3enZyOWtVVDcrVmJ0dnAveXVsa2Ntd1pjMC9KQzhI?=
 =?utf-8?B?UlU5SXZQNTl5aWdINWVhSnFKc0dPajUzek1iMVBqM2FiWW5WVkdHM1NrTmZr?=
 =?utf-8?B?dHFhdkdycTBWZ0JRek4wWlA1MDBSOGtBYWRNMCttVmZoWUlYbUtmOGRXc3NS?=
 =?utf-8?B?RExkWEt5eHRJSmNGMzZxZGFmSUwrWUVWMWdxVS9NOE1rcjhnQWZlNW1aRTM0?=
 =?utf-8?B?eVhZOUpLYlJRY1p1RE92eXNIWWh2MktSeU9wZ043RjVROUF6NHdzNThGcWhh?=
 =?utf-8?B?dU10dzc5QjZ5QThVZWdpaWNaYjc2M1J4NkNIbkoxQVdWdDBRNGRJTDlSY0x5?=
 =?utf-8?B?RjkwcnlCYXhtK0c2M2txbm9SY0JqTGFpdmxqUjFLbkdISVYydVVRa0J5Qllx?=
 =?utf-8?B?YmhjSThzZTlWMGJpWWhJYUhtbEl3RzExaDdrM3IzYzFQUEJFeXNoczNNbkI4?=
 =?utf-8?B?Y1g2dEpWWmhCVEgrMWd1YVRVSExpMS9VaFRRM1dLSU1TN3pwUUNsaC9CQjQ4?=
 =?utf-8?B?ckpQNDRJNEVuOG1aNkhUbmZWZDdaNVZOZWcvRXBWZmxSaml1N01Bdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <47BF34459900234DA33E57D39444DD23@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b40f6f8a-d34f-450a-7042-08da23bf0634
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 17:47:37.5859
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VbvDlPfgnveJSyNAqgj6L9Pdlp7AL8btLjV8HXvsDZ3SIu/Mk+mEVPTe7DSOHTRoABOooJy/Fy/rIQrKTROe0TDd1zfbDfy1hijudlT5ikE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4880

T24gMjAvMDQvMjAyMiAwNzoyNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIwLjA0LjIwMjIg
MDg6MjIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBPbiAyMC4wNC4yMiAwODoxMSwgSmFuIEJl
dWxpY2ggd3JvdGU6DQo+Pj4gT24gMjAuMDQuMjAyMiAwNzo1NywgSnVlcmdlbiBHcm9zcyB3cm90
ZToNCj4+Pj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL2lvbW11LmgNCj4+Pj4gKysrIGIveGVuL2lu
Y2x1ZGUveGVuL2lvbW11LmgNCj4+Pj4gQEAgLTM0MSw4ICszNDEsMTcgQEAgc3RydWN0IGRvbWFp
bl9pb21tdSB7DQo+Pj4+ICAgLyogRG9lcyB0aGUgSU9NTVUgcGFnZXRhYmxlIG5lZWQgdG8gYmUg
a2VwdCBzeW5jaHJvbml6ZWQgd2l0aCB0aGUgUDJNICovDQo+Pj4+ICAgI2lmZGVmIENPTkZJR19I
QVNfUEFTU1RIUk9VR0gNCj4+Pj4gICAjZGVmaW5lIG5lZWRfaW9tbXVfcHRfc3luYyhkKSAgICAg
KGRvbV9pb21tdShkKS0+bmVlZF9zeW5jKQ0KPj4+PiArDQo+Pj4+ICtpbnQgaW9tbXVfZG9fZG9t
Y3RsKHN0cnVjdCB4ZW5fZG9tY3RsICpkb21jdGwsIHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+ICsg
ICAgICAgICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0oeGVuX2RvbWN0bF90KSB1
X2RvbWN0bCk7DQo+Pj4+ICAgI2Vsc2UNCj4+Pj4gICAjZGVmaW5lIG5lZWRfaW9tbXVfcHRfc3lu
YyhkKSAgICAgKHsgKHZvaWQpKGQpOyBmYWxzZTsgfSkNCj4+Pj4gKw0KPj4+PiArc3RhdGljIGlu
bGluZSBpbnQgaW9tbXVfZG9fZG9tY3RsKHN0cnVjdCB4ZW5fZG9tY3RsICpkb21jdGwsIHN0cnVj
dCBkb21haW4gKmQsDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWEVO
X0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3RsKQ0KPj4+PiArew0KPj4+
PiArICAgIHJldHVybiAtRU5PU1lTOw0KPj4+PiArfQ0KPj4+IEFzIHNhaWQgaW4gcmVwbHkgdG8g
QW5kcmV3IGFzIHdlbGwgYXMgaW4gYSBudW1iZXIgb3IgZWFybGllciBvY2Nhc2lvbnMsDQo+Pj4g
SSBmaXJtbHkgdGhpbmsgdGhhdCB0aGlzIHdhbnRzIHRvIGJlIC1FT1BOT1RTVVBQLCBub3QgLUVO
T1NZUy4gVmlld3MNCj4+IEluIGxpYnhsIHRoZXJlIGlzIGFuIGV4cGxpY2l0IGNoZWNrIGZvciBF
Tk9TWVMgYmVpbmcgcmV0dXJuZWQgZm9yDQo+PiBhc3NpZ25pbmcvZGVhc3NpZ25pbmcgYSBkZXZp
Y2UsIHNhbWUgaW4gdGhlIHhjIHB5dGhvbiBiaW5kaW5ncy4NCj4gVXJnaC4NCg0KSG9uZXN0bHks
IEkgd2Fzbid0IHBhcnRpY3VsYXJseSBoYXBweSB3aXRoIHlvdXIgcHVzaCB0byBzd2FwIEVOT1NZ
UyBvdXQNCmZvciBFT1BOT1RTVVBQLsKgIFRoaXMgc2hvd3MgcGxhaW5seSB3aHkgaXQncyBhIGJh
ZCBtb3ZlLg0KDQpBbiBlbmQgdXNlciBkb2Vzbid0IGdpdmUgdHdvIGhvb3RzIGFib3V0IHRoZSBk
aXN0aW5jdGlvbiBiZXR3ZWVuDQpoeXBlcmNhbGwgbm90IHN1cHBvcnRlZCBhbmQgc3Vib3BzIG5v
dCBzdXBwb3J0ZWQ7IHRoZXkgY2FyZSBhYm91dA0Kd2hldGhlciBYZW4gY2FuIHBlcmZvcm0gdGhl
IHJlcXVlc3RlZCBhY3Rpb24gb3Igbm90LsKgIEVOT1NZUyBpcyB0aGUgbW9yZQ0KY29tbW9uIHdh
eSBvZiBzaWduYWxsaW5nIHRoaXMsIGFuZCBoYXZpbmcgb25seSBvbmUgZXJybm8gdmFsdWUgdG8g
Y2hlY2sNCmlzIGJldHRlciBmb3IgZXZlcnlvbmUgaW52b2x2ZWQuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 17:51:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 17:51:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310399.527227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhaxd-0000Fe-5U; Thu, 21 Apr 2022 17:51:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310399.527227; Thu, 21 Apr 2022 17:51:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhaxd-0000FX-2V; Thu, 21 Apr 2022 17:51:21 +0000
Received: by outflank-mailman (input) for mailman id 310399;
 Thu, 21 Apr 2022 17:51:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhaxb-0000FQ-OJ
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 17:51:19 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4d9bd77-c19b-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 19:51:18 +0200 (CEST)
Received: from mail-dm6nam08lp2045.outbound.protection.outlook.com (HELO
 NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.45])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 13:51:15 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN8PR03MB4593.namprd03.prod.outlook.com (2603:10b6:408:95::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 17:51:14 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 17:51:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4d9bd77-c19b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650563478;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=1vn/PgBwFiDyetdTn8eGwhnUC3ObMABA8btvfgynp7k=;
  b=OQ+hCnOYzD4qh+VfZgePWU9Pk5fonMF7o43kIFNUP0Tj40igcMCInkM/
   CDq8k2LeTxh0rn0JN3rFMPyqhs2rXSg9b6VivSpBOJC6wWA4/O0cCTpoM
   pv1vbzDYCtKvMoYI43EHTSNgNvdEFkZuhsfhYVgf3/GI0bPua7+bNQBGu
   o=;
X-IronPort-RemoteIP: 104.47.73.45
X-IronPort-MID: 69039406
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:F7gVSap57BXUvnuiB0AeqM/69rNeBmLvZBIvgKrLsJaIsI4StFCzt
 garIBmEPazbMWv8et1waI209RwEu5Hcz4JjHQc+ry9jRXlH8JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 4qq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBB7zAxeYSbx5kEQZjBKMd4YfiIUmHiJnGp6HGWyOEL/RGKmgTZdFd1sMpRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkHh3Fs26iiHt6HD
 yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvTmLl10tiOaF3Nz9fIbSWPhJrGChg
 l3/0TnlBikwPeay1m/Qmp6rrqqV9c/hY6oQG6e/7eVCm0CIyyoYDxh+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxaspQUAUtBdF+k77gClyafO5QudQG8eQVZpasEitcIwbSwn0
 BmOhdyBLTZiqqGPQHSRsLKdtyqvODM9JHUHIyQDSGMt3d7np40iiwPVefxqGqW1k97dFCn5x
 naBqy1Wr7cZgNMP1q671UvamD/qrZ/MJiYq4i3HU2Tj6Rl2DKa9bpGswUjW67BHNonxc7Wal
 H0Nmszb4OVQC5iIzHyJWL9VQOzv4OuZOjrBh1IpB4Mm6zmm53+ke8ZX/S16I0BqdM0DfFcFf
 XPuhO+Y37cLVFPCUEO9S9vZ5xgCpUQ4KenYaw==
IronPort-HdrOrdr: A9a23:AIHvKKkDFfpNu02CphWEIOkZDRnpDfN1iWdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee
 r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp
 gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e
 XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5
 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe
 q1NdZfH+LjRFGebLp04w==
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="69039406"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QenYwEKeYmXpmfrTkDYXCXd0hrRSk2xKSqfJ6Njujf46Un3o7C3AdLP/NbbMNrp1oALynLksoep4hqKRzWMBs/5e40nh20a3Ts3L2yNXfiBJy3PgHnaIsJ9ll9prgDPrMF31QNdk1RK1HMRwbRfNVcytd8ttqAIGpXryEPtlI+7EYeOryiVXlRzLSr/0SA9uyxDU36CTG4/T8iCvolmYfLGd3K7kNx/wCtVSBxPikCTuutEJ0TaokLlzjcB07PjOK0P/Ec085EMNjK8a+fpy796UMu1E7YrUCrohdpb2FZJIbZUUONFqVd+0Lo9rCezFhpvP4hFklzj2PjxypSjyxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1vn/PgBwFiDyetdTn8eGwhnUC3ObMABA8btvfgynp7k=;
 b=McY5aTJc5od6p87FbsOd/GVf30cKJRkAp4dXHUX8KXzH2+IKRLqHT7Y1y5DkeNHVIqeIwaeDyjlSJDUqa6LzdGQKjoZEFbwNf56yT97mrUJyl/D6ACMq61OdQolI9AenFELsSqgcKLwqz8mt4NKHx9lZIDT+6T/1Hmq3BsXvNwKeB54xYe2/R03Af3+11VftQK6Gfk2CwsgU7djjPLXPLmI8L4KbHQMYwDLzVZqtbaUMsaTuHms1MoeI65XhMmmz9KfUvduFHnXty/BTgq1O6vEU8StACD6DoQx3DszC+Z5mhIfGwoQj4gzW8e2nEOUTJ2S2aQ0c97f/n1isisCLFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1vn/PgBwFiDyetdTn8eGwhnUC3ObMABA8btvfgynp7k=;
 b=CP1oLh1Jpdod/vSYYAHRfKyTTRmx0Q/XNFIPbNvE4240t3Pci3g3WzaJv0ArE22Gu9z2ykLktffYkyD9aZjAuajq0ithDWxXZntZIDBMopQq5eMbdRjAo3KNFuswAgeSAbzy1B8Glh+PZPOgLMB0dfUheUXFXgdyu/7CPnxv2Y0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Thread-Topic: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Thread-Index: AQHYVHuOvzYJLKPprEuLadRqUVZq9az6p9GA
Date: Thu, 21 Apr 2022 17:51:13 +0000
Message-ID: <0c8f5600-0a2c-5ebb-e83b-d902d0b74514@citrix.com>
References: <20220420055736.27901-1-jgross@suse.com>
In-Reply-To: <20220420055736.27901-1-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f07d1256-4c77-43e6-cdac-08da23bf8733
x-ms-traffictypediagnostic: BN8PR03MB4593:EE_
x-microsoft-antispam-prvs:
 <BN8PR03MB4593C359CDE71D891B007DD6BAF49@BN8PR03MB4593.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 BUaZ9N0iuHAo7dPcFJ4W7ST7GNTQq+Pqokp3E8yBcgZM9OiiBEehSL+lbuXN2fCZIlLPqdZy8clZ5qF6ryvrZiTSQ5l4GYT3qA0RXxZ5TsDqt9shraCUdMXqCF0PjY+/AYHv0IMvOpHj7spkRaHgnvmFkh5fUVcIcv/SsdxU3OSAq18VcnZXHrQRvGD1/xzbIc+VSviYuVCk0ODhBaRrJCbNOLf8jNhQ50upgfO6lsHG77yau9muyqpHhShFIlXOn9Q05txgxlaC6S3ACspLwq9Qb60zxMkD4wDbLjdulP8hZ23UYoPHtsueqCk23AhDy8YvfnGnpO0IT6ThZ5LEjBcI/aipEvzdIGByldQEBdgiac9jH55Hq8mNMhTu3xwJgE306UzkIKQK3ajHeezhpD6kxq/azrcKknIlFK8y4ttDqMVZqr0dbuGtB0QJMQCCaATpedrxZ99VXU1sRvE1afWVbnDEMdZ8gIXVV7WICoQq6k2bllzytIiFGich/6MD3BZTpLjVUdxYK1iA37N93Saf/wyjZbKy/pdbMn+lL1m92q+SWdHdstMCNY1ZqNzq66sNtJe1OoRizV460ggeYMV5Yw1XDDVrMpuEyY9+P6E+wIEelSHFzLFXKf0TBfc0zhJPyGDMS1kmgFnSfAkpW3n6RE5eNp/tkuPDE7ndj+xanWqNql/6wMLko8AAp5Qjxq6y6J2691QFrr+3/itHFt2gT8j1YSOr2QWoYNVSyUJmj8ywPsB/Hpp2cqZ36gk66ZvDa/BJKDXeKi1euqRLEg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(2906002)(38070700005)(5660300002)(76116006)(508600001)(71200400001)(64756008)(26005)(4326008)(66476007)(38100700002)(6486002)(8676002)(66446008)(6512007)(4744005)(82960400001)(31696002)(66946007)(66556008)(53546011)(316002)(186003)(36756003)(122000001)(91956017)(31686004)(6506007)(110136005)(83380400001)(8936002)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZU1iU3ZBY3dIODh1WnhVN0dHN1kvdFdsTE5MR0pEOWx1V3ZMdFlHckMybXlJ?=
 =?utf-8?B?SlMyUEFCK3dGYjdYVGtjeGd5enBxNFllbFJvcUNpUUhDcmFTOXh1WTFoQ2Zq?=
 =?utf-8?B?d3Z4UVhjcXQ5U1diaHBLdXlmRWl6cDNnZTR6SlZzRjBHUE9vRks2T2dBQUlL?=
 =?utf-8?B?ellWdmNpcDlid00zVVo2c3BMcmRyUjQrMitDRW5DT1J5L2xMejJESUFrZkpX?=
 =?utf-8?B?NytRYTdWYXp3NnV6M0dGT05jemdCUnd1cjE4aFQzbndUMVZxaUtaT1J1eWpK?=
 =?utf-8?B?TnNaWXBtNWp6dEQrY3NWcUNZWDVDZHNLd043ckE1aW5JSllwWnRkS2FyellL?=
 =?utf-8?B?SUxVWUlFOEJFZU45bDVvcmhxeDJ3dXQ2T3pyUXNCbDlwVDJ0bnFzYjc0Wis2?=
 =?utf-8?B?dE9Ya3JYaktpWTRUamkzNE80d1hYNkxJVlFBNUVzKzJHaHZEZHJzYXdaS0FC?=
 =?utf-8?B?WS9IV1Q0WWYxTTZGTmcvK3NDOWg0ZjRNYWIrbUdZMkhBZDBGTnQxalNZTlVa?=
 =?utf-8?B?aE5Eb1ZZNTZoYjZnaFVETWpyNnNJbFkveDFxeDhEdC9BdFlkTG4zWStJdnBB?=
 =?utf-8?B?YU95NFZ6NXRzdXllT1JZZFB2WjVzK1JOUDYrV005YU5tcW1nWVRTZUxoMjB1?=
 =?utf-8?B?d1JnS240VGlmTGJlRjBOY1kwZFh5azAxV3AvQVI3MWgwTUFUOGwrYXpxemd3?=
 =?utf-8?B?T3VnaVhSMUVkOXlNa0VMS0hIeGhWYTZkRDQ5RHZLTVRNZ2g3TE1yYXFjN2V2?=
 =?utf-8?B?V1AvZnVuNGlRQ1Z1V0dwbGxCdUZhU2tscWhnT3Z6bU05a3hYYVVHM2lIMjB4?=
 =?utf-8?B?MmpreUV1VFpxZXpnZThhZ2p0a0VsdnlOWE5hRkdyWWNWUkhUK3RkWVVFa25S?=
 =?utf-8?B?UHNDQmdxUzRzVXRNRTZ6L3ZwOTJYcklSUUJqcTk5YWlzQ2NPY1pCQldGUHpR?=
 =?utf-8?B?TDA5eWd4MG11dUxkRnFYTFlJckk0cUdXT3pxQUJJS0E0Y3l1MXkzT2tMdll2?=
 =?utf-8?B?MGZrbjNZeXFydERVNEZ2N3RFa2d1S016ZlJEV3ZtZEppTXVuNHdlWFpHckZ5?=
 =?utf-8?B?WXM1bVk1MkgyVHYxRVZ3czRxRUtzM3F0ZUlITzNvNU5IZmFaZUlRbnEydWVR?=
 =?utf-8?B?aEtPalM3aTlHVGY3ZXZNUHFJblJrME9aZzBHVG5oUXVhcUlUQWJWV3BxeHVW?=
 =?utf-8?B?TU9MVkVHTzZkOGxoWlFNNk8xdEZDTVBScld0S2xSUlQrMWxnV2l4WWp3b1pr?=
 =?utf-8?B?YXA4ZDVFT3crbW1XN05Ec3JmcXJSV3I3TU90WUpabS9UZ3FxUVNMb1JKK2or?=
 =?utf-8?B?WW5STkViMzJRN25ScjVycUZQQnFrdU1WbWFrZHc2ZEpOKzlrK2E3cy9JQ3Vu?=
 =?utf-8?B?eWc3bm1rbUwyQW13Qm16VXkvV0F4d2dSZXovcEFPWjUvOXNTM2RLRi9PM3hY?=
 =?utf-8?B?ckhUZy9mK2YwT0NyalJYbDQxSGJOT3ZpNStSdFZJdGxLT0l3alF5RnluTUpL?=
 =?utf-8?B?YnpackVlS0NwMUEwaHZwUVM5OHhOY2pWNndKSXhZb3E2Um81Sm5qeTRReTJX?=
 =?utf-8?B?cFlHSmVGVXowUmtQVktKdXlONnZIM2JKMjByQVB2RWN2d082bjhFL29rR1JX?=
 =?utf-8?B?a3hmWkdHQVhFek9CY3JYWDZ6WFRSRDNQM2gvUUpKL2hqcVhsbk1xUFlpZGdE?=
 =?utf-8?B?VHVEOHhJZXlFZE14eWd1c2lBNmhRdEVibDRnVzQ1enZzRTRsUjZ2UHBVY1Ft?=
 =?utf-8?B?aG9ZSUVIMnVVOW9rN2dZMjFvQU5lUWRibUF6TlA2eWRJKy9IWHlPNDJaWGk0?=
 =?utf-8?B?TFNoZEVpd3Bhdko5L1UwUU13OW42MDdYSGxkQXB6ZnF3cnNTRWxrR1l1ekt5?=
 =?utf-8?B?TVNJVFBvdXNHQmplc0FSWnp1cEZkRWYrQ1hrZldHeTZIdTlXbzgya2c1bGlB?=
 =?utf-8?B?VDRnZkVhVkUvQUtJT25MZ1hPbGdkcmxueVYra25vV3NOSkJHSmVubCt2WVFV?=
 =?utf-8?B?NStGUzlBYXUrUFZpeTBLRTBrdmpybzlTYTZicGg0dTVaTHY1MVBKbzFwSHdP?=
 =?utf-8?B?RXlBSytyRjNoWWI1dUMzcTdwaVJMWG9nSmJnVk0yK2RyRDJYMjdnSVkwNlhG?=
 =?utf-8?B?MWF0cHltWHRxMFdERVhIR28zNi9RNHh3dmsybi9XYUk4L1F6elovY3lYaHdT?=
 =?utf-8?B?K21sQWFZclhjNXNrVkp1aTcwWmhFbFlXa2NZRU1YM2VqOVZGcUh3ejduZGFY?=
 =?utf-8?B?R0ErSW9KamM4UmRqREpCOVV3TGIwOUppNW04eHRGbVpjcEVUVDdxVEYxejVZ?=
 =?utf-8?B?MHVTVWZaN0p6ZkozL0xJb2k3Z1RDSzRSRUdrVjh5djZHOUxhaEtndz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <90D5B38EF6CC3C49A4B86CA3F5D7C195@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f07d1256-4c77-43e6-cdac-08da23bf8733
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 17:51:13.9766
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qMtnQYIoWP+cyCBttJo6ytlLVCHexxkvElvx74L4XEAtIdp5qm8h5IZ8Es42jyjayCGGD0T52jSCdwMEu8FXm0Ses6+ow2wqpt1u4pR6x3Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4593

T24gMjAvMDQvMjAyMiAwNjo1NywgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gVG9kYXkgaW9tbXVf
ZG9fZG9tY3RsKCkgaXMgYmVpbmcgY2FsbGVkIGZyb20gYXJjaF9kb19kb21jdGwoKSBpbiB0aGUN
Cj4gImRlZmF1bHQ6IiBjYXNlIG9mIGEgc3dpdGNoIHN0YXRlbWVudC4gVGhpcyBoYXMgbGVkIGFs
cmVhZHkgdG8gY3Jhc2hlcw0KPiBkdWUgdG8gdW52YWxpZGF0ZWQgcGFyYW1ldGVycy4NCj4NCj4g
Rml4IHRoYXQgYnkgbW92aW5nIHRoZSBjYWxsIG9mIGlvbW11X2RvX2RvbWN0bCgpIHRvIHRoZSBt
YWluIHN3aXRjaA0KPiBzdGF0ZW1lbnQgb2YgZG9fZG9tY3RsKCkuDQo+DQo+IFNpZ25lZC1vZmYt
Ynk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEFuZHJl
dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo=


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 18:06:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 18:06:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310405.527239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhbC8-0002Wp-GR; Thu, 21 Apr 2022 18:06:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310405.527239; Thu, 21 Apr 2022 18:06:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhbC8-0002Wi-Cu; Thu, 21 Apr 2022 18:06:20 +0000
Received: by outflank-mailman (input) for mailman id 310405;
 Thu, 21 Apr 2022 18:06:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhbC6-0002WY-Iv; Thu, 21 Apr 2022 18:06:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhbC6-0007Ui-HE; Thu, 21 Apr 2022 18:06:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhbC6-0002RO-5y; Thu, 21 Apr 2022 18:06:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhbC6-0001ss-5W; Thu, 21 Apr 2022 18:06:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HPJtIkjyYoZ0r2xbnlKo/RD1tvha+c+V0uSQTr5rvLM=; b=gUGQj+5uJjkdrIXbJWVLcQ5Lcg
	m69nBRY0tpRVu/eA4yaxZQzFP6keivPbn62EtC7upmr/SigI/T/FJ/xBS6tBAPLkKPxGMTcLikAmW
	7qtHDVAPO50nGPjv/XwciBhlGehCdAPY8CEFO04vW1jKu3YFA/mdGN7hi4JjYiKidAOw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169596-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169596: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 18:06:18 +0000

flight 169596 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169596/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  540 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 19:06:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 19:06:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310418.527251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhc7j-0001yB-3Y; Thu, 21 Apr 2022 19:05:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310418.527251; Thu, 21 Apr 2022 19:05:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhc7i-0001y4-Uy; Thu, 21 Apr 2022 19:05:50 +0000
Received: by outflank-mailman (input) for mailman id 310418;
 Thu, 21 Apr 2022 19:05:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhc7h-0001xu-J1; Thu, 21 Apr 2022 19:05:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhc7h-0008Ui-Fr; Thu, 21 Apr 2022 19:05:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhc7h-0005R5-7U; Thu, 21 Apr 2022 19:05:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhc7h-0003za-74; Thu, 21 Apr 2022 19:05:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PjMD0049cL3THksrMIBJpDRyPVFpFw3grvYfuzQhtjs=; b=4XUMhF7ja/GyqOorDCl0dwt7CW
	bt9n+HftHZTuyR0IPbYFRlJ2sWxTAMblji+Z4OVPMN1sT6TTocU7rkTDOBL9DbJ96+WO54bnVjUO4
	1ufxeRiDQmbjhX9AUzgrbyqkzsXOzArYAhnaVpJwP/1RRltVONC7g9hBBbT9OR6g7gns=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169597-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169597: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 19:05:49 +0000

flight 169597 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169597/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  541 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 19:15:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 19:15:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310427.527261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhcGd-0003lk-Vg; Thu, 21 Apr 2022 19:15:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310427.527261; Thu, 21 Apr 2022 19:15:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhcGd-0003ld-SN; Thu, 21 Apr 2022 19:15:03 +0000
Received: by outflank-mailman (input) for mailman id 310427;
 Thu, 21 Apr 2022 19:15:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O5Hx=U7=citrix.com=prvs=10361b9f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhcGc-0003lX-JO
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 19:15:02 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 55dbcd3e-c1a7-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 21:15:00 +0200 (CEST)
Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Apr 2022 15:14:56 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN3PR03MB2305.namprd03.prod.outlook.com (2a01:111:e400:7bbf::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr
 2022 19:14:53 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022
 19:14:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55dbcd3e-c1a7-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650568499;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Y9pWpwzid0b/vkalw4ptt9lOsRkxF6ApYEjPg2lVN/g=;
  b=gP/ThJ4f5FaJ/j0iDNzVJNSDcj30ksf8VtwWm+MIMT86y0C1rhx37MJb
   aoN8XrK8D3djU+ftH3AtwNTX0iUPYH6PUz+qw5mTEaHmNpP7JaUrL1Kwq
   ns5p3cQuytheR5ymgVXZ+wpRfOKvyPnwWTXKk+6RECBjyr0321vf7ZdCk
   c=;
X-IronPort-RemoteIP: 104.47.56.170
X-IronPort-MID: 69646445
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:fDWUpqhzA2sfhC9a6qJWrMEZX161bBEKZh0ujC45NGQN5FlHY01je
 htvUTiPbviIN2Lxe4tza9m+9U1VvJLSzYA3HFE+qS4xQXsb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nU4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YT4yZ/zPifsEbwZJDw5cBvRI1eb9IVHq5KR/z2WeG5ft69NHKRhveKY/o6NwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIEehWho7ixNNa+2i
 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJpsjaPklAtjdABNvLPQtupWd5yxH2Hg
 T7i3EmjLB0RLdKAnG/tHnWEw7WncTnAcIAYGaC89/VqqEaO3WFVAxoTPXOjqOS9ol6zXZRYM
 UN80ight68p72SwU8LwGRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LQHGz
 XeMltLtQDdo6bucTCvE8q/O9Gzqfy8IMWUFeCkICxMf5MXuq50yiRSJSct/FKmyjZv+HjSYL
 y22kRXSTo471aYjv5hXN3id695wjvAlljII2zg=
IronPort-HdrOrdr: A9a23:l7sujK3Bj8RfxUDIC0nFMwqjBetxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+
 UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf
 grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e
 iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ
 PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/
 6uJZM+OY6XEVfT
X-IronPort-AV: E=Sophos;i="5.90,279,1643691600"; 
   d="scan'208";a="69646445"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j+PE9aU3u8o0zkrZ/o8hCXp26F4IpuUstdgM+DEuMUR7KC7R7epSU31oTHXwo4nOjlokT3kiptSdaoANDEy8bTU2ykt5RGLHOWCgjpIR/Hhj0iaVQb3rcZzIaTChhdGuE8wtn7X4DD6MMp24sZawkZoeka8zuAeSRn1iIMqC8LB1h7Bbht3c+R9Mok2bTZYxPZHBC4zjoILMx6NZj1gHbXLqnZy3W0+KFiGEq3kH3jxqe+KjYXFpm2PuNU3PzA3nEFtxwJh5Z973nmGdEuCnNrh8/A7brc8zDc7rcVCr/IpALgbeHW+8hbGVugioCMuE1N9K6e1avsAY1TiTfIdBIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y9pWpwzid0b/vkalw4ptt9lOsRkxF6ApYEjPg2lVN/g=;
 b=csQOvYtYyKiYaHh7MF1kw2ZnW/cQi61em8S7xQsXOzZbW9yYvl2/szlOVR4aWvHPBQFxORNxxHWDHOVV14lHH6rLnXzI9acf4g9wis3z6yxmAnWDSmznNKH0x3aL0DFzSe8Et57BnJQg0c7LyOGQRi841OhLii2HuWk97ndoOAiKtQNN2KqT+3Gw6oOoqCwkrRqis+Q+tBCIHTrFM/+VJxCV3kCy+lc1iPygDItQ1TRcRZATW9X1qq365z4HHL9XADsoEVZF0x02UKd+154tdsuGf+0xPsKxtbSr0dQAnefXKfurxoah67AQzix+CuaYhDKPxsnbpiTlOHhGbHOA9A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y9pWpwzid0b/vkalw4ptt9lOsRkxF6ApYEjPg2lVN/g=;
 b=iQVku+UB/CZmcCe7SiCPViZ7N0GLuTsluGH8sPlslADdbe8S2B1lw1dx7I1NlkXV2oLVKED7SIreNwCRXRwpIuDXubfovCqj7Vq3IiyhsqYh6PvxmG/vOSzPn7MTgrFzf/IJeIXovCXjHcsBk3i+6biyjRCYJnitNuLxfeb48Q8=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Paul Durrant <paul@xen.org>, Juergen Gross <jgross@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Topic: [PATCH] IOMMU: make domctl handler tolerate NULL domain
Thread-Index: AQHYU9FUwjuogeCS0EWgGeBVFIanqKz3Yk2AgAAA74CAAAPwgIAA5uIAgAJydgA=
Date: Thu, 21 Apr 2022 19:14:52 +0000
Message-ID: <f69185ac-9d7a-6293-f2aa-d2e8fa9a8e52@citrix.com>
References: <bc61d9cd-5da4-e35c-fb21-eeba5ab6e529@suse.com>
 <8a8aa0c1-e6f3-2dc0-77d4-282af89f4ed6@citrix.com>
 <bd446b5b-49ea-3d6f-6792-7d785586ea69@suse.com>
 <226afabd-ea07-dd60-474f-c594d7468de3@citrix.com>
 <7d3e5ed8-dd92-bfd7-6540-fa75965eeed8@suse.com>
In-Reply-To: <7d3e5ed8-dd92-bfd7-6540-fa75965eeed8@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9ff6e9f5-8d1f-4005-c19f-08da23cb369b
x-ms-traffictypediagnostic: BN3PR03MB2305:EE_
x-microsoft-antispam-prvs:
 <BN3PR03MB2305007F2259FB0B95967842BAF49@BN3PR03MB2305.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 tYY8x1w+XhwkCXe5qmmLF6eeQN6uz3CShso6YizTROCb0O8GJrfvdzwyimGROXySHgL6dvbhC5VWYw0whqXCkrwobidaSIjrfCHnJOnHNGWXOMYwkUaYg6EvRBW2mt38gpKhQgePSerEXlPUwG3Lsg90zut8UYoa4SL6n2oaUKDIFJ1w0i5vQS4RVREdE66oPJ6ovdX1Se1TeMQI62S7Wvkkg0ggAq61gwoH7xRUCExgqzETyrgQWOl2waoHUo3B192/VPtuatzYV+t60Bhx7zbuR4ccImvaI5gpZrbDK3izj5wqvNB7FKjBCPN20xQvLtvmIvcaKHwlslE0dQ9FMz2h9AppD5HngGUbVb9lw1KfZFc7wMlOqK14CWlW+xXbGhCzxqmqOwRbHttLQ0PPUFLF5LvuI943bk6B+mCr8zshI3HnCSwOSpMhuST7Mwtx14uAWEScW8RZhCTnupAjOCdLsB3toMCoFblEWi59pzDJBPNTCpFnWR9Mt7EOilioY8hkyvzIZC73Zs5SBVGNuojFr0AK6wpciYeUxvYpfHGbqDbLZ46/EX3vqdY6WNXwxGsm/pDK2rNiLm2u1Cw2c1O+8Keb5qzSthncmzmMEDrmHsUMSRszcPckVCswpLCoObEd7C1RnK5ry6ruvaMhIvnzFmqS23zU7FnPhOnjLuOqLyD5H5v+bqD9G0A71oWSKKJ/Qf72M8siNChjRnkqG++0E7nZnVXAPMiOJx83HSAyTsoJPBVkkYExDexRwjonODUewP2rGBcYZRzGFL4Y5Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(91956017)(6916009)(122000001)(76116006)(82960400001)(66556008)(508600001)(64756008)(71200400001)(54906003)(186003)(31696002)(86362001)(2616005)(36756003)(66446008)(6486002)(66476007)(6512007)(38070700005)(2906002)(6506007)(4326008)(83380400001)(38100700002)(31686004)(26005)(316002)(53546011)(8676002)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dU94MGdxdEE3WEdsQjErdEp0c0RHc25DWnF2SEJhRmFEUkxQc281QXNvckVv?=
 =?utf-8?B?MEhCT203cTZnM1YvcmFWeTBMZ0pqUlNHWUtEVk1SKzdTWXl0ZlJMQ3diQXpi?=
 =?utf-8?B?SmlzMmp4T3NlaEpsOEFmSEFTZ2VrV0dmeG0weTZuZkJUSXNKV2lqRHpMN00y?=
 =?utf-8?B?aUl2eXZaQWtHd1paQTJickFrclF0WkpSeXVPS2FPMk4yK3lQSWpWMjFxS1VK?=
 =?utf-8?B?dnpnQWVMVWRCSEwxQm93NlRVQ3FSY3BCQmZmdzB4MXVRMTRyMW9RK2xLZHFy?=
 =?utf-8?B?VGdjVmJwVTl1bU1valhEbVI1S0w2L0JPc0hHbDN3WlM2WGJCZEk2dDVza2Iw?=
 =?utf-8?B?UnZ5RU9iSnpZYVpnaFlwWmw5ckNTaVpHQjFtVnJ5UWs4RXJ0MDdNYzhmdkY0?=
 =?utf-8?B?MHp4QXoraE5iVVRqTDdHRVExN1U0WFVPaGJaWkFvTDBSeXA5SzRmaytlVjdk?=
 =?utf-8?B?UTNmTXdFMDkybk96RGMyWlNLb28rWHJ1aVBYMHJCZUJjNmtqcDY3YnpkNEVk?=
 =?utf-8?B?NlRTOXgvdGo3cGRLZ201K1pSQnREMWtDVm9VNjM4dzdwTjBTV2s1cDNVNFVr?=
 =?utf-8?B?R0M3VFFkMTU5bVNHdmJtL0taaXpCZDZ1MWdoNmxDc2EwVWRjQW1KdzFjUytB?=
 =?utf-8?B?aFJJWHVIUnFieVVxTFhIVFNzOWU3UkUxNWVBS1U4WWJLTTVEbGtQRU5DeVVq?=
 =?utf-8?B?TE00K2tnMUQ4UGJSbHRGRVNjL0V4T0ZQUzhNdUc4WWJZcHk2LzNtQ2VUR3hy?=
 =?utf-8?B?TndPRFU2ZHdPUnhPZGZBRkdCeWRUZWJ5WU1hZER0RHA4MnFmQVU4WlBicWlG?=
 =?utf-8?B?S1ljS0ljeHh3U1lQeWdEcnB4eXBsOExsWHl2VlNCeHkrUUlnNDZ5elMvWUFj?=
 =?utf-8?B?Tjk4d3paOStjNnZLdzRqZ2txTTNvRTRqeFl1ZTNhWUNrTlVxYnp2cUNDRGxF?=
 =?utf-8?B?TytRREhESmFNNDBlL2hnL3V6K0dZT3p3UzB0THozMnlTSVR1Ujk0S0RXTVZ5?=
 =?utf-8?B?dG96ME1lYTdHaklzSzNNd3JCdFptekVwZU0vRzB1M2N6amxyWER3Zk9obytR?=
 =?utf-8?B?NCtyYWNKWS9UalZEb0N4MStsK3FTODVQKzZneXE3UHYzeS95czZEYUJVOG1o?=
 =?utf-8?B?MC9NKzJPd1lFRjM3WkRQdzZuWUNUSEFyK2lCWHBaZS9lN3NudVdFbS8rdEdz?=
 =?utf-8?B?RTJiUU5DUlRXZG1uL3VSdjZ4cEpSYnM2Unh5TDhwWERXdmU1S1RyRHE3RWg5?=
 =?utf-8?B?VWVHYWZwenVMYTZHbUQwRHNkVTlCd3FHNXBHMDVpOXBCZWQybGVLL0VKdkZF?=
 =?utf-8?B?dnpXWlpIUmxzeGNTaUFGY3lyRHFVSDZNb2ZSb0tZNVhmM1JSYlRIVmR3WHFO?=
 =?utf-8?B?ME9UM29Wc2JDbngveitDeEdrY1Z6Y0d6T2svYXJmUlc2OTNCYVd3YnNCRERx?=
 =?utf-8?B?S0dtMnl5emFqTWovL08zSlVDbFJvVEZkY1g3bk12VmN4bHlEcU4yRy8zN1Nv?=
 =?utf-8?B?cWZzL21YMy9RTlNuNTR5Y2ZIWXBvUTd5S0JVeWJJNVY1a2R6a3ZDTHRBdVhT?=
 =?utf-8?B?MVNKZjBKR1RmdVFKM21VM2VVckVGKzhuenNmTi94WlpmQ0FadHR2YTFQckU5?=
 =?utf-8?B?N2RRNndUY1oxTjRrVjJLUUZ2NFZSMkJuRzNjaVFldHlPdnJ2VXVaY1hkOVk4?=
 =?utf-8?B?T0p3N2JWZFIyY2V2ejhkc2NwRDFtalNXdDBUTVRyaDRYL0w3bHFDbi9Reklu?=
 =?utf-8?B?UzNPN2VsMGhzME1iNGl6VjNTN0FTdEdlV1hvUzh0bHNkb1AranFWL0taSTVM?=
 =?utf-8?B?OGxQeGYzNWJmQVREQVFXNVcwdW81bmFtVWNud0hkVm9KZzlnT21JL3dWaFV0?=
 =?utf-8?B?ZjlJRHprZFZ3cHQxTnAvSGF6TmJMOVNHbHo2QXVDTTYzUTBhTitZQkRDU3pG?=
 =?utf-8?B?dS82OURlb0pUbUhEQ3hlU0puMzgrQk9paXBHeVVwNWpSM3QrYjc1bjNpdFVj?=
 =?utf-8?B?c3o3UlpVdnk3TXZFSDZFQzRYN01iREdMNUVzM3ozaDlnZ1RLVGs4WXFTeWRE?=
 =?utf-8?B?TVhYT3BWS0VtcWRHOWU1VnZOdW5pZHllR0lrSS9reEVtODFBdnBHWFpjZmhD?=
 =?utf-8?B?ZkZyckZEait4V3IyNWMxRk5OWENkK0I2eWZ5dElwVk1BM1lzbTJGbkpES3ZC?=
 =?utf-8?B?anQ0bDgrOWt2bWgwV1phaEUxYzRIRUc4ampKNTlRd01IeDd0SjJkR2hEL2hk?=
 =?utf-8?B?R3U2c1k3QVhsTUxFM3h1dnhxOFJ4N1dyazdrMExzYnBOVUhNZzVsU1V4ejla?=
 =?utf-8?B?THdsTzJNcGczeXdnekUwbDhlV3BGYmR1SXMrc2k0VzkxY01zL2pKZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E227B0879C332643A1FB392CD64CD28F@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ff6e9f5-8d1f-4005-c19f-08da23cb369b
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 19:14:52.7544
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WKNoa9KK1S+3keWZEbSWkPbcumOqZpTrEDuhYcGBAkh1RKRbBd4L9H9w/N5T8uptwwBmU3qizk1vK0385BoqTmcGct8aFoBIIaze1LfIYu4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2305

T24gMjAvMDQvMjAyMiAwNjo1MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE5LjA0LjIwMjIg
MTg6MDYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxOS8wNC8yMDIyIDE2OjUyLCBKdWVy
Z2VuIEdyb3NzIHdyb3RlOg0KPj4+IE9uIDE5LjA0LjIyIDE3OjQ4LCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBPbiAxOS8wNC8yMDIyIDEwOjM5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+
IEJlc2lkZXMgdGhlIHJlcG9ydGVyJ3MgaXNzdWUgb2YgaGl0dGluZyBhIE5VTEwgZGVyZWYgd2hl
bg0KPj4+Pj4gIUNPTkZJR19HREJTWCwNCj4+Pj4+IFhFTl9ET01DVExfdGVzdF9hc3NpZ25fZGV2
aWNlIGNhbiBsZWdpdGltYXRlbHkgZW5kIHVwIGhhdmluZyBOVUxMDQo+Pj4+PiBwYXNzZWQNCj4+
Pj4+IGhlcmUsIHdoZW4gdGhlIGRvbWN0bCB3YXMgcGFzc2VkIERPTUlEX0lOVkFMSUQuDQo+Pj4+
Pg0KPj4+Pj4gRml4ZXM6IDcxZTYxN2E2YjhmNiAoInVzZSBpc19pb21tdV9lbmFibGVkKCkgd2hl
cmUgYXBwcm9wcmlhdGUuLi4iKQ0KPj4+Pj4gUmVwb3J0ZWQtYnk6IENoZXllbm5lIFdpbGxzIDxj
aGV5ZW5uZS53aWxsc0BnbWFpbC5jb20+DQo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGlj
aCA8amJldWxpY2hAc3VzZS5jb20+DQo+Pj4+Pg0KPj4+Pj4gLS0tIGEveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvaW9tbXUuYw0KPj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvaW9t
bXUuYw0KPj4+Pj4gQEAgLTU1OCw3ICs1NTgsNyBAQCBpbnQgaW9tbXVfZG9fZG9tY3RsKA0KPj4+
Pj4gwqAgew0KPj4+Pj4gwqDCoMKgwqDCoCBpbnQgcmV0ID0gLUVOT0RFVjsNCj4+Pj4+IMKgIC3C
oMKgwqAgaWYgKCAhaXNfaW9tbXVfZW5hYmxlZChkKSApDQo+Pj4+PiArwqDCoMKgIGlmICggIShk
ID8gaXNfaW9tbXVfZW5hYmxlZChkKSA6IGlvbW11X2VuYWJsZWQpICkNCj4+Pj4+IMKgwqDCoMKg
wqDCoMKgwqDCoCByZXR1cm4gLUVPUE5PVFNVUFA7DQo+Pj4+IEhhdmluZyBzcGVudCB0aGUgYmV0
dGVyIHBhcnQgb2YgYSBkYXkgZGVidWdnaW5nIHRoaXMgbWVzcywgdGhpcyBwYXRjaCBpcw0KPj4+
PiBwbGFpbiBicm9rZW4uDQo+Pj4+DQo+Pj4+IEl0IGRlcGVuZHMgb24gSnVlcmdlbidzICJ4ZW4v
aW9tbXU6IGNsZWFudXAgaW9tbXUgcmVsYXRlZCBkb21jdGwNCj4+Pj4gaGFuZGxpbmciIHBhdGNo
LCBiZWNhdXNlIG90aGVyd2lzZSBpdCBlcnJvbmVvdXNseSBmYWlscyBub24tSU9NTVUNCj4+Pj4g
c3Vib3BzLg0KPj4+IFdoaWNoIGlzIG5vdCBhIHJlYWwgcHJvYmxlbSwgYXMgaXQgaXMgYmVpbmcg
Y2FsbGVkIGFmdGVyIGFsbCBvdGhlcg0KPj4+IHN1Ym9wcyBkaWRuJ3QgbWF0Y2guDQo+PiBJdCBp
cyBhIHJlYWwgcHJvYmxlbSBldmVuIG5vdywgYmVjYXVzZSBpdCBpcyBib2d1cyBmb3IgdGhlIGhv
c3Qgb3INCj4+IGRvbWFpbidzIElPTU1VIHN0YXR1cyB0byBoYXZlIGFueSBhbHRlcmF0aW9uIHRv
IHRoZQ0KPj4gWEVOX0RPTUNUTF9nZGJzeF9ndWVzdG1lbWlvIHBhdGguwqAgVGhlIHJvb3QgY2F1
c2Ugb2YgdGhpcyBidWcgaXMgdGhlDQo+PiBleGlzdGluZyBYRU5fRE9NQ1RMX2dkYnN4X2d1ZXN0
bWVtaW8gY2FzZSBiZWluZyBjb21waWxlZCBvdXQgaW4gdGhlDQo+PiAhR0RCU1ggY2FzZS4NCj4g
SSBmaW5kIHlvdXIgd29yZGluZyAoInBsYWluIGJyb2tlbiIgaW4gcGFydGljdWxhcikgaXJyaXRh
dGluZywgdG8gcHV0DQo+IGl0IG1pbGRseS4gVGhlIGNoYW5nZSBpbiBiZWhhdmlvciBpcyB0aGF0
IC1FT1BOT1RTVVBQIG1heSBub3cgYmUNCj4gcmV0dXJuZWQgZm9yIHRoZSBnZGJzeCBvcGVyYXRp
b24gaW5zdGVhZCBvZiAtRU5PU1lTLg0KDQpJdCdzIG5vdCBqdXN0IGdkYnN4IG9wZXJhdGlvbnMg
LSBpdCdzIGV2ZXJ5IGRvbWN0bCBzdWJvcCB3aG9zZSBjYXNlDQpzdGF0ZW1lbnQgaGFwcGVucyB0
byBnZXQgY29uZGl0aW9uYWxseSBjb21waWxlZCBvdXQ6DQoNClhFTl9ET01DVExfc2V0X2FjY2Vz
c19yZXF1aXJlZA0KWEVOX0RPTUNUTF9kZWJ1Z19vcA0KWEVOX0RPTUNUTF9tZW1fc2hhcmluZ19v
cA0KWEVOX0RPTUNUTF9hdWRpdF9wMm0NCg0KYW5kIGV2ZXJ5IGZ1dHVyZSBkb21jdGwuwqAgSSBk
aWRuJ3QgdHJ5aW5nIHJlYXNvbmluZyBhYm91dCB0aGUgZGlmZmVyaW5nDQpwb3B1bGF0aW9ucyBv
ZiBlYWNoIGFyY2hlcyBhcmNoX2RvX2RvbWN0bCgpLg0KDQo+ICBBbmQgdGhhdCdzIHdoZW4NCj4g
aXQgd291bGQgYmV0dGVyIGhhdmUgYmVlbiAtRU9QTk9UU1VQUCBpbiB0aGUgZmlyc3QgcGxhY2Uu
DQoNClRoaXMgaXJyZWxldmFudCB1bmxlc3MgeW91IGhhdmUgYSB0aW1lIG1hY2hpbmUsIG9yIHlv
dSBjYW4gcHJvdmUgdGhhdA0KdGhlIGNoYW5nZSBkb2Vzbid0IGJyZWFrIHRoaW5ncy4NCg0KRm9y
IHRoZSByZWNvcmQsIEkgZGlkbid0IGtub3cgYWJvdXQgSnVlcmdlbidzIGRpc2NvdmVyeSBvZiAy
IEVOT1NZUyB2cw0KRU9QTk9UU1VQUCBicmVha2FnZXMgaW4geGVuLmdpdCBhbG9uZSB3aGVuIHdy
aXRpbmcgdGhlIGVtYWlsLsKgIFRoZSBtYXNzLA0KYW5kIHNwdXJpb3VzLCBjaGFuZ2UgdG8gYWxt
b3N0IDJeMzIgc3Vib3BzIHdhcyBlbm91Z2ggdG8gZ2l2ZSBwYXVzZSBmb3INCnRob3VnaHQuDQoN
Cj4+IEl0IHdvdWxkIGJlIGEgbW9yZSBvYnZpb3VzIHByb2JsZW0gaWYgdGhlcmUgd2VyZSBjYWxs
cyBjaGFpbmVkIGFmdGVyDQo+PiBpb21tdV9kb19kb21jdGwoKSBpbiB0aGUgYXJjaF9kb21jdGwo
KSBkZWZhdWx0OiBibG9ja3MsIGJlY2F1c2UgdGhlbiBpdA0KPj4gd291bGRuJ3Qgb25seSBiZSBj
b21waWxlZC1vdXQgZnVuY3Rpb25hbGl0eSB3aGljaCBoaXQgdGhpcyBjaGVjay4NCj4gQnV0IHRo
YXQncyBub3QgdGhlIGNhc2UuDQoNClRoZXJlIGlzIHRpbWVib21iIHdoaWNoIGp1c3QgZXhwbG9k
ZWQgb24gYSB1c2VyLCBhbmQgeW91J3ZlIHByb3ZpZGVkIGENCnBhdGNoIGNsYWltaW5nIHRvIGRl
ZnVzZSBpdCwgd2hlbiBhbGwgeW91IGhhdmUgZG9uZSBpcyBzd2FwIG91dCBvbmUNCnRyaWdnZXIg
Zm9yIGFub3RoZXIuDQoNClNwZWNpZmljYWxseSwgeW91J3ZlIHJlcGxhY2VkIGEgbGF0ZW50IGJ1
ZyAobm90aGluZyBhY3R1YWxseSBjYWxscw0KdGVzdF9hc3NpZ25fZGV2aWNlIHdpdGggRE9NSURf
SU5WQUxJRCkgd2l0aCBhIHJlYWwgZXJyb3IgbWV0YXN0YWJpbGl0eQ0KZm9yIGxvZ2ljIHRoYXQg
cmVhbGx5IGRvZXMgY2FyZSBhYm91dCBFTk9TWVMgdnMgRU9QTk9UU1VQUC4NCg0KWWVzIC0gd2Ug
c2hvdWxkIGRlY2lkZSB3aGV0aGVyIGl0IG91Z2h0IGJlIGxlZ2FsIHRvIGNhbGwNCnRlc3RfYXNz
aWduX2RldmljZSB3aXRoIERPTUlEX0lOVkFMSUQgb3Igbm90LCBhbmQgdGhlbiB3cml0ZSB0aGUN
CnJlYXNvbmluZyBkb3duIGluIHRoZSBzYW1lIHBhdGNoIHdoaWNoIGFkanVzdHMgZG9fZG9tY3Rs
KCkgYW5kL29yDQppb21tdV9kb19kb21jdGwoKSB0byBoYXZlIGNvbnNpc3RlbnQgYmVoYXZpb3Vy
Lg0KDQpCdXQgdW50aWwgaW9tbXVfZG9fZG9tY3RsKCkgaXMgZmlsdGVyZWQgdG8gbm90IG9wZXJh
dGUgb24gdW5yZWxhdGVkDQpzdWJvcHMsIG1ha2luZyB0aGlzIGNoYW5nZSBicmVha3MgbW9yZSB0
aGluZ3MgdGhhbiBpdCBmaXhlcy4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 19:24:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 19:24:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310434.527272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhcPX-0005Y5-SX; Thu, 21 Apr 2022 19:24:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310434.527272; Thu, 21 Apr 2022 19:24:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhcPX-0005Xy-PD; Thu, 21 Apr 2022 19:24:15 +0000
Received: by outflank-mailman (input) for mailman id 310434;
 Thu, 21 Apr 2022 19:24:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhcPW-0005Xo-Ma; Thu, 21 Apr 2022 19:24:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhcPW-0000OC-EH; Thu, 21 Apr 2022 19:24:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhcPW-0005wo-0U; Thu, 21 Apr 2022 19:24:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhcPW-0000vT-00; Thu, 21 Apr 2022 19:24:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=H4FBxCY8R3H5wpaolt5E7Thc6B8EqWLzuSJaU0T6114=; b=L/R8Jmkte1cCJs9vQikBLk9Z8u
	s2Zk52Txq10whkCYbfaRD4SL2Pq8g2K0ioDyUtW5HAxeRK2nzZLXS/QvH068MdF79o++2FTTpiItI
	yqa3f1jVU8OPCbQDxJ5zK7Pg5MSJ2dw8QK88MCA+T6yE2evPWF4LRlWFWlgU3vwRkjf0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169591-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169591: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fdef107edd4459375f9c0e6e377f30e82d498747
X-Osstest-Versions-That:
    xen=fdef107edd4459375f9c0e6e377f30e82d498747
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 19:24:14 +0000

flight 169591 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169591/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 169577
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169577

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169577
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169577
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169577
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169577
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169577
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169577
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169577
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169577
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169577
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169577
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169577
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169577
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  fdef107edd4459375f9c0e6e377f30e82d498747
baseline version:
 xen                  fdef107edd4459375f9c0e6e377f30e82d498747

Last test of basis   169591  2022-04-21 11:13:37 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 20:02:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 20:02:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310444.527283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhd0i-0002fr-OJ; Thu, 21 Apr 2022 20:02:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310444.527283; Thu, 21 Apr 2022 20:02:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhd0i-0002fk-LM; Thu, 21 Apr 2022 20:02:40 +0000
Received: by outflank-mailman (input) for mailman id 310444;
 Thu, 21 Apr 2022 20:02:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhd0g-0002fX-Nl; Thu, 21 Apr 2022 20:02:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhd0g-00015c-LY; Thu, 21 Apr 2022 20:02:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhd0g-0007Bw-7n; Thu, 21 Apr 2022 20:02:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhd0g-0005rC-7P; Thu, 21 Apr 2022 20:02:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Y5O/eh3ekJrf4VfYxI7RohDtY8xlrpMq8mZ41bOLF0c=; b=UivVCZnEyOy+PU1rknbrxXmnOH
	RoeUJne39h4/H6ke30oxWgedQ+bLz9d/nEuZwzZInrd4USpC5e/wQX9PL39blDCBDrgZyu2EjXUCg
	k4QlpTIuIlKEmyZMB5PVMrMHiIH+QEvwYGShTMV1K+t8i3rtA/cGfS3qYFR3/MRNyDu4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169598-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169598: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 20:02:38 +0000

flight 169598 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169598/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  542 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 20:47:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 20:47:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310452.527293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhdhP-0008Ac-53; Thu, 21 Apr 2022 20:46:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310452.527293; Thu, 21 Apr 2022 20:46:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhdhP-0008AV-2E; Thu, 21 Apr 2022 20:46:47 +0000
Received: by outflank-mailman (input) for mailman id 310452;
 Thu, 21 Apr 2022 20:46:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhdhN-0008AL-Q6; Thu, 21 Apr 2022 20:46:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhdhN-0001pH-OZ; Thu, 21 Apr 2022 20:46:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhdhN-0000R7-Gq; Thu, 21 Apr 2022 20:46:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhdhN-0000fA-GO; Thu, 21 Apr 2022 20:46:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=m7yM4JKn8ukCRoRf3+64IfmI2FL+fZG/GSFkg3NVRAs=; b=1112RbrllkxR0w6IHrKUevbthe
	P8FY11UcDKSEDONnmGumCSB4f6fXPdZtFqO+yM5VmuI8Opu8q6oCG1qS/vpZ+whXZpUb18CDNlixN
	UaMrkCi/xl5/nKa8EyypQ0uvhJrsdl/1RXvEz786yHaljs3huCnH+Oovfprib3YYDdIM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169599-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169599: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 20:46:45 +0000

flight 169599 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169599/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  543 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 20:57:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 20:57:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310461.527305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhdrD-0001XN-5A; Thu, 21 Apr 2022 20:56:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310461.527305; Thu, 21 Apr 2022 20:56:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhdrD-0001XG-22; Thu, 21 Apr 2022 20:56:55 +0000
Received: by outflank-mailman (input) for mailman id 310461;
 Thu, 21 Apr 2022 20:56:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+mQ=U7=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nhdrB-0001X7-Up
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 20:56:54 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90da77d0-c1b5-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 22:56:51 +0200 (CEST)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23LHU10W024600; 
 Thu, 21 Apr 2022 20:56:47 GMT
Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta01.appoci.oracle.com [138.1.114.2])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ffnp9mtu8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 21 Apr 2022 20:56:47 +0000
Received: from pps.filterd
 (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23LKkSwT026569; Thu, 21 Apr 2022 20:56:46 GMT
Received: from nam11-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175])
 by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3ffm8ctfy2-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 21 Apr 2022 20:56:46 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by DM8PR10MB5430.namprd10.prod.outlook.com (2603:10b6:8:24::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 20:56:44 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 20:56:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90da77d0-c1b5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=DCAlBd4gJJ4mg164jNQlULsCgbg7QT4wMjEDmqu3oQU=;
 b=szHJiSXXNd0mZojzxqen7E5GqZIL3vU+8CzD4LzI66yTNREXXUhA547TNbx1xX6fqU6u
 50vDYp7apLkJ1tqinj/CerEYYcrK4NtbvKB4F+xIhfNItHB0UfKxgTP6V6o/zHAk2Lxh
 T5Gbx76H1JT19YMYWQL/Sfk7GFLt/QaQZbMdrk0kw24XZYkbUYRxO7NFzO4oKEuXBZwt
 +mHaH2RLthc/7wEBHTUdFJUJEAKKGWNl7p/2Dfs2rZF01eMhI7nVLttC8ZDetBkQKorw
 licVHDqAAHTfbjgSSAvo1PTdwjOyTne7b7Xb31MUGDM87pA8O0CB30FEl7bT3d96TCsV VQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QjPNhiTaEDzYuoK27u1DcoOWbVOEpRZGXtmqdM9h9TUtI+D624AuMTWx2Ro5jExZWlQ7asodiGSPdyLe2ZVKMTnnXf5sHMfTcLIZbR0Mk3C9ommUPjhT//V6fYJOYi2vKn1EAVmfXK2w35ypuRO4mS1yKdXdB85LXfyJ4DQlnKq0QuoIgfyQc/pafvrYPmTvPt8hIyCjDh6PYkhbobpv/1e7xuZ+V3IlO6Y4NHoktrjjEnPIWEMXLmn1a5QkxlV2ir7HKKrP6q6fVx0p62IIGUhloT296RpKULE6/aLlnN+zwnlZvao7a8kH58sB/ujFxdBXn4pqJFI5xcOOmfQ16g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DCAlBd4gJJ4mg164jNQlULsCgbg7QT4wMjEDmqu3oQU=;
 b=RWX8UlBVyAbIc9nC7XoxKL6FCvM5dUB0V/dsXkRD1AkbOpQUUusfabj48lGrqdZwPF+lqRdtrR1NDbyEK91Dt3h0cwIggar5hxikA+GzePPQ93oFPjC4kk8dbqiLM9Ub7Tj+Nwk7MQuj1Uim5qmrV06oYEdPcjYlvq2sC0SMELPM8nFmtvzzznkfZbaz3apdB6GBOkpWl9Ux/v7JigIh/UBgybmyVc/So2IUCasR15fQ4nrD7jTJIUQWKhnGzsxCSSqMmw6YR7BANLvnH0g4JRxGBsDdj05pQ0S4KemkKUU8cTyptCb/jUbNz8PMU/qBcIdz8NTc6hz14crAu1zNnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DCAlBd4gJJ4mg164jNQlULsCgbg7QT4wMjEDmqu3oQU=;
 b=rnW2HWYKWYtVY85tUkJcnYsJk2UKIScTAuLZVIsC0z0QmOSB4ODKdL89pPBYqpd3rNjRK6D4aho1aOazbD5kpoGkt4quCGRq1YlMa0B/cCcIQvBsjJUTNxvWj/bwxvblPC5CBvIrR8AwgZ/EhbnilVsiB7Fe/zi1i0SZADfjFtE=
Message-ID: <d4d36fb2-a26a-9fbd-acc6-fe97ab93fa66@oracle.com>
Date: Thu, 21 Apr 2022 16:56:40 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-3-jgross@suse.com>
 <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
 <bf19c5f8-badd-5afb-fcaa-a16483783a27@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <bf19c5f8-badd-5afb-fcaa-a16483783a27@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SJ0PR05CA0121.namprd05.prod.outlook.com
 (2603:10b6:a03:33d::6) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3b75503d-3210-483e-6b13-08da23d9715f
X-MS-TrafficTypeDiagnostic: DM8PR10MB5430:EE_
X-Microsoft-Antispam-PRVS: 
	<DM8PR10MB5430745D61CA34FADD002BC58AF49@DM8PR10MB5430.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	AG9Fc7IQuhWnUSTcrUGHpCebUQwvbJFy/NbdvplBmdWqqPOdk5/xkvVoTbtf/IRDHkalV8SG0cv0twa8z9fKfdXCnnIdQ027bvtYRf1lexG5/o1whfgtKdD5UkuPmEBkLkikeLJjCYsxCWbO7buSfxWJPyIPU+HuMqIpwzIoCgTlJ6AOKPqfGl0zG316ITD2iUo5S4soVcrrkMyL/wqhUo+w+Obxg/ffsXxnUHOQSTAZNOvSMLTiv/TULHUT8xUhbKRPuVq2w1BmQhwvLXLzKfY1fcALpM8O7TgEkvNo89lez5oUWWx5upS7Oyw2YkBxGFCGaWh+JKf9n8QnMuHaMjfAsGd/SMHPGHfJUeio4eyGCg3ytdHs7MXXTXqVO4zxEVxl8Yw74/CLQHRUVffR+TvWEYTRKkw4pGOkwsnVaNqq/fwQ9zY2EXP+W2W0qFmen97V7tqanzpi4qZrV2VOq9dlGXP0atI4hkBtBLAAxsh4c6ei+z1D/mt/gFJ7dN3Y8Qg0wZhvgP2+wB+vz4qbUuqAPo35L8IdfDUT3x9oCCBvoCmVeqDbzIQ6YyW8uI3uu3lyy/GBgnGFOr14YQZ46PMOG2uausoAidfS92aR/f2B7HYxA2XIFiVe0jddMJi6TeNSY6i1lgQQDcIJHpaCWP5B3ILLvaAEFojWmPhQ+C05sbq6FRCmQUcE1sFcQiLdZFZdXvjAJMiIMxA78rakrP5uNhnbat0WvLFDyePhGaPN/gJ53+JbiSNnEs3H5h3P
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(66556008)(44832011)(53546011)(26005)(4326008)(8936002)(186003)(66476007)(2616005)(8676002)(6666004)(6512007)(66946007)(6506007)(2906002)(5660300002)(508600001)(31686004)(6486002)(38100700002)(316002)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?UDkxRmIySDZEaXZGcXB2dkNrSC9JeUJXSXRHNG9Ub0p5WENUc3V1dlUzRTlU?=
 =?utf-8?B?TnRsV2ZwTWNZblhRUVFiTERoUmNoZDV0ZHpiMmVyY3VnUTVrSDhPdDN1T1lo?=
 =?utf-8?B?ckVlRGliV05WQ3RoQXNtTjkrYTdvbGNYTUFJSnJIZjkzeld5UFJkcmhYc3pj?=
 =?utf-8?B?SjY1L1EzeXFLVUg1cnZKWGdjWVA4VEVtdk5YZmlxMThsR3NaZVJxT1NsWFpt?=
 =?utf-8?B?YjRWbndLRmsyY1FwOThuSkxEZVlCTmo1R0hBSmd3clk5STBEbFpRYzZCTFJC?=
 =?utf-8?B?cDhqRU1SUjhvdklJNlpPcUlURTErVHQ0dTd6UzhXSEt5akVJOUlvWFlvQUZS?=
 =?utf-8?B?SmpWbjJndjNFdXlCRG1DRnV6V2FUUi90OVhNOU50YWhkM3RUVFIyRExnSy9P?=
 =?utf-8?B?RXhMSExlU28yRnJkZzVVSVcvYTA3Y1VxOVdOWEF3RDJCdkI1U1NxR0tHeXJQ?=
 =?utf-8?B?cEdveWpEN3JMSVM5ZWsxQUk4akdjQW1rTkdSdVhVL3RDZ1BFNU8rVzRRN3hH?=
 =?utf-8?B?UU0zdk11eW14WVJVY05nV0FCaGk0ckVkb1RlcEVvTklHZ0c0VjFXb0g4WXVT?=
 =?utf-8?B?aVFsMjFWMW1zSndNV0NEcldCVUNhSW8wTjFIaXYyeUlGekFrbzEvdy96Z2dJ?=
 =?utf-8?B?UVlRZDhTZmlBaXJtRmE4RkRQQmJYa1lVZ25mK2hIYkNqYWV0TTlLZ0JiaVN2?=
 =?utf-8?B?ODNXcHV4bTV0Y05oNW8yc0RNc2NRcStuVFRvUlBRS2NIWlZCZTdEWEc1MDRR?=
 =?utf-8?B?cnV3dHJ6OTRpRkhhOHB3OXRNUXRTMm0rUWRERmpvWVNHaTdPOHZSeldrazM4?=
 =?utf-8?B?YXYzMmFZQmgxR3BtRGlvc215NE9vS0lxNDJna0JuNXVLZFQvNll4M09OZVR3?=
 =?utf-8?B?eFBBak1QbG96cDZOcTh0M2h1bnZEWUNSeDFEd2RqMHBOZ1dPd0JMc0UwMktm?=
 =?utf-8?B?Z3U1MnNWS25wZ3BGQTZOQ1lvMkNjRjFUalZsRXRkUDhnbW8yS1pURUI4Y2RO?=
 =?utf-8?B?WGlDUUMxTjlwdUJKWWVxRkQ3Y3dFbzB5RlZZUFphZ05HYnQvdTZ6em0ycVZs?=
 =?utf-8?B?NDZId1BLYWFVdThkWXZzQU5DSS90VzRPemd5azhQbkVQR3lEVExUN0VDQ1Fy?=
 =?utf-8?B?bVFVT0U4NHJtNmMveG5nUndkQnJEenczTVZsVVJTR1RyaXc5SGlySnJRc1dR?=
 =?utf-8?B?b09sRUhWRXdXTWZ1TTR2MmQxZ2RDRmNJVXFpWVViUU11RXRKVmxHMVA3UnB2?=
 =?utf-8?B?RGNFamNHMjNBSkdvZEFETmVaUEQ5NkRPdkJDbFhRS3NwLzAxUmNXM3M0aUQz?=
 =?utf-8?B?dVlMQlJ0Y2JmUU1IbDREYzdhMWNITFJUWmJmSXF5SUFHTjFiNUFZNUxvUWQ3?=
 =?utf-8?B?QzFsRHRSUkNXWFFKeWx3ZVk2QWFoM2dUaWhSWTM2N0NRTEYzWHZGeG1kenRV?=
 =?utf-8?B?bDJqSG5uSGI3RUI1ZVc5YTRUWngzVjZoZWlkL1hGMEdLR3EvbytGdEJlZ2FG?=
 =?utf-8?B?RnFNUldPb2pKUFBjQjMzaDRSb0pPM056QW9UZkM2ZXo0NE5RV2swd25CWHI1?=
 =?utf-8?B?cWxLYkVPd081Y1ZPMk9nOTJnMnJhKzVpUVpZK0oxQ054VUw2UitHdWlNV0R1?=
 =?utf-8?B?bVR6YnhGeCtwRFQ4ZHQzcE1OQzlROHdsbVQrSnRBd0NDRWFTU3B1QjBWY0N3?=
 =?utf-8?B?OVoweEFJK082WmpUYlpNYTBld0ZoT1czMitxRTB3Um9oK2VNRitiT2lRcVEx?=
 =?utf-8?B?YnV3T0FVN2F5RmI5QWxENmlUeFZmalVQRzdnTUczUDRoanJRNVgwYnRYajEv?=
 =?utf-8?B?eVdiaERQNk1VMEppYU9CS2tJcSs3RTFRRTQvNThiTUtBZkNxK2t5bkVKb29O?=
 =?utf-8?B?MEVoRUkrRi8zRCtkQ0R3UE80RHlVV293c2NyTEcycERSWmN2cHJFWm9KVjdQ?=
 =?utf-8?B?aXFwMm93a1phSXBneVE0WEUyVHQxa0VjRStCL0ZrUW50aHRsTmVXM21MbXoy?=
 =?utf-8?B?dWh6Y0VPeFZTOGdPSWh5ZExSbktyRi9nTXBDOG5jYjR5R2oyYThXekJnL1JY?=
 =?utf-8?B?dnBXdllqL0lmb3VhQjkxamMwV0tBRDFFa0lPZHBJWmJYV1Y5NU9TWFBEQkZL?=
 =?utf-8?B?Ni85eFVaWGpGazBYdmhsSmlPUkJEbS93ZDZIY1B6cS81OGplcGZ1NlFZa012?=
 =?utf-8?B?bTJ1aTIyVTIzN2xsZUhvRUlDbUxTMWlsTG9ybW9MN25FQktNdXljUTg3cXJ5?=
 =?utf-8?B?NzF3WE1aVXJraEV0UkUzU0RVU1gyUjhQMG5TTjVjOVNDbVc1MktxTHVOWnBX?=
 =?utf-8?B?eGZJTFhMdURIQko2U0xuQy9PK3N6c2tnbHNiNERnMk9kdFZpV0krbTFCZ0NK?=
 =?utf-8?Q?VAyFmj88He1/AOAI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b75503d-3210-483e-6b13-08da23d9715f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 20:56:44.5031
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pNwQnuV4hQN60kvtue+wRiC9tvSsQSl781AidBA+UVasFC4701KXic90fsaCKpMOPwNZL2OCQi1g1b+Fm98hb5m81djvft4w74hBrAT5NpA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5430
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-21_05:2022-04-21,2022-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204210109
X-Proofpoint-ORIG-GUID: LB7Mjm4hd-h4z4eMnMlT55yWtsHWyWh-
X-Proofpoint-GUID: LB7Mjm4hd-h4z4eMnMlT55yWtsHWyWh-


On 4/21/22 4:40 AM, Juergen Gross wrote:
> On 20.04.22 18:12, Boris Ostrovsky wrote:
>>
>> On 4/20/22 5:25 AM, Juergen Gross wrote:
>>> @@ -569,7 +645,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
>>>       wait_for_completion(&pending_req->tmr_done);
>>>       err = (se_cmd->se_tmr_req->response == TMR_FUNCTION_COMPLETE) ?
>>> -        SUCCESS : FAILED;
>>> +        XEN_VSCSIIF_RSLT_RESET_SUCCESS : XEN_VSCSIIF_RSLT_RESET_FAILED;
>>>       scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
>>>       transport_generic_free_cmd(&pending_req->se_cmd, 0);
>>
>>
>> You also want to initialize err to XEN_VSCSIIF_RSLT_RESET_FAILED.
>
> I did that.


Yes you did. I don't know what I was was looking at.


>
>> And also looking at invocations of scsiback_do_resp_with_sense() I think those may need to be adjusted as well.
>
> No, the invocations are fine, but scsiback_result() needs to pass through
> the lowest 16 bits instead of only the lowest 8 bits of the result value.
>

What I was thinking was that this could use the reverse of XEN_VSCSIIF_RSLT_HOST(), i.e. something like

#define RSLT_HOST_TO_XEN_VSCSIIF(x)   ((x)<<16)

to be explicit about namespaces.


BTW, should scsiback_result() use XEN_VSCSIIF_RSLT_HOST() at the top?


-boris



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 21:15:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 21:15:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310467.527315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhe9Q-0004YA-Jc; Thu, 21 Apr 2022 21:15:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310467.527315; Thu, 21 Apr 2022 21:15:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhe9Q-0004Y3-GW; Thu, 21 Apr 2022 21:15:44 +0000
Received: by outflank-mailman (input) for mailman id 310467;
 Thu, 21 Apr 2022 21:15:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+mQ=U7=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nhe9O-0004Xx-Vv
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 21:15:42 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 31f0959b-c1b8-11ec-a405-831a346695d4;
 Thu, 21 Apr 2022 23:15:40 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23LJEAHB012431; 
 Thu, 21 Apr 2022 21:15:33 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ffpbvdgqx-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 21 Apr 2022 21:15:32 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23LL0mCX027434; Thu, 21 Apr 2022 21:15:31 GMT
Received: from nam02-bn1-obe.outbound.protection.outlook.com
 (mail-bn1nam07lp2041.outbound.protection.outlook.com [104.47.51.41])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3ffm89ju68-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 21 Apr 2022 21:15:31 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by DM5PR10MB1898.namprd10.prod.outlook.com (2603:10b6:3:10e::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr
 2022 21:15:29 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.015; Thu, 21 Apr 2022
 21:15:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31f0959b-c1b8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=EAOpr8ZdY081Ha81IqAq9/zTKyOSUanKdgBrWUCBYD8=;
 b=MRsrhd/ac7rVJP0OJoPwPBthbmUbqoR6PFI8F7tCFhgqfGE5TT5Hk0t2aCV3Gf8mys2v
 ufVbr2IMEfeaJcwqIf/h9HHzbejpsxjZeW3wocfXE7QWhmzAzX89wFjCQK8PNWILbt9k
 lbB2mayLyjMyNHns9ZmHX8nNLjnhk2DjUqyMcyL10JmY7GqDH6VgjHu73yJcknTdamed
 rwQN5sp2QLUnLnjCABbOxuWflDS16eJRpBbjRxAHd+rlk8z4LmpzxndRIbkPPVqDcgtw
 psN1R11zArnfI6gzyj/ultPQeDg5UBJ8ApDpeKS0ZxQVdNunMC0mDk4VSTVpJfKZ4CFm DA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZDGatQ6w5WYA6Yvc73X841hl14wzihpgVU55fJaSkqRIPaB4Ue3CHf7kVCsJECRlqenkZOu63z377yVHHjlHhqrr8zIMlylkOGmk3m76g+7qSTni4og8M961V+RAlUypqXoCe0gV5llYZRYKNH81w5vW3O1c5Lv7g62YSjcSJkzgbCwC0dKUQ8HAIpXB65AXDp6SSOHRkyJE4FjkZ4TbQ5aN0Mjwabro20kJ7S/acd3J/9R9x9SlctQovJqL8ZZsa+H1NuVpHROuGvoxXs4FyoWCp43DS784PX/YoWsgi4fGirByqUd8WaZQ0WjmnncthAAqPvIw/26bnC3AMbzVvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EAOpr8ZdY081Ha81IqAq9/zTKyOSUanKdgBrWUCBYD8=;
 b=nki7khf+iA3/SVVQt2LRzscfROq9JrvOHiTrDz7q+UbGcfedZhppSK1S3xfyYaRzCVX5bIeCkloPg5Nnj//fRvANxzeQT4Zo3adYB/fxQkIu1weZ4DS2kw1ocPe7CFu1AJyvC3DviIgaQFnAhsJqpneil5DzHgYGjGJhop2S9V7+n+Hs2bXnT/Z+xpLQ70LzpZ94B1eD7OUq6ePmmHFl74So8CMYDm3N9MOdIeDw6HmDZV2AxwBPhd/VYDuBvuux+WDtwSas+2s8IrLRbVAowLHN1nWqGUb14ZOBh1A1bI331lpvEI71Plh7TkEBJ93D4NDHQsx9sdM9POJgwZK2cQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EAOpr8ZdY081Ha81IqAq9/zTKyOSUanKdgBrWUCBYD8=;
 b=BIelbU3UgoWYx3NLhNoJBbrWV9yZGhH+eJN8rfdnEW1W6e8glxNxSm3hJLARNrGHt6l/OiBQcti59X+osyEroeoi+BjH26PmLEXUtpnGFasku622VQudScDhB7e1gU9Rgbj1GGT0dEMeqf2h5tMAIYankkAAw/HvRVhFCSKSkZg=
Message-ID: <7ff97157-4792-c48c-a06c-ad98884f9e9b@oracle.com>
Date: Thu, 21 Apr 2022 17:15:24 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v2] xen: Convert kmap() to kmap_local_page()
Content-Language: en-US
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
        outreachy@lists.linux.dev
Cc: jgross@suse.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, ira.weiny@intel.com
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0P220CA0030.NAMP220.PROD.OUTLOOK.COM
 (2603:10b6:a03:41b::6) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9be7f60b-7015-4cec-2ac8-08da23dc0f9a
X-MS-TrafficTypeDiagnostic: DM5PR10MB1898:EE_
X-Microsoft-Antispam-PRVS: 
	<DM5PR10MB18989CC3EA7A1354363D14EC8AF49@DM5PR10MB1898.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	8sE5nRMwj2KxdLsvDsGifDlUVB7e/CsxW+232oK1RAagY+ApuFMyFYeyQ6h+Ehhn2Rma0sbpbQ8aHoqGIw5X4sBQ4mgXUd/DSsT3Nqv+Rxipjqbc6Rg67ozsEZwY4vHahQUDFT9+PgjbMd09CHxtj2eL++HJwXxBF5K6u/Bq2FsMgGjnCig+M7nd1CMqZOmm/KnnQmtnONuUA6/adUd0jKtaaqL0ZGz8qv3k4cskoPzkLiA8v0XEMfF1/N1zNkIr/V15zQG6Lu4mIgxcLL61fC32AnVQY0yVT4YAOWswnb0Io38vHieTcq175TfbBtuqx5xGoTVmCJRWEQ9tgUnSjwedsR9p65NV6fgtqe4K8Wxg6IhUXNYhYuVqiP3px0u5DAKQvJ/3iwduCGh1oUgFJZ5GjHc83Lpfves7+sp+BQmmcInyCBTgcqHf7nHphRsuBsLaRrXR4sPEAcUv1IzCxVu2EysjUku4DdiwyghvnAZV4juSSC6DkyAe+M+alQOECOIIaF/3a94JMX06Jx1WNGAbKneZOy4mAc8T12ICDrF5SBvboxY5xajT5Vw4HHrTK8Gu8vKyfw7724u+InRNLMrbHgBvjGkOWtL2gUa3U05X2tjNvP4dBu1qRHq88yVruYQnA6HLeoF2vFXUNfEsXHZwB1p0rn8HmxlY3iTEzmEZchOCO/WeoXbkd1Nvv3TrCyNlrOIh+xywO2SX7qqlwxRrJJ8F7EExw/cAfzBrjjMmWpsdrOYShoH0JYz7NYRs
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(66556008)(6512007)(36756003)(316002)(31686004)(2906002)(508600001)(6486002)(186003)(26005)(6666004)(5660300002)(6506007)(44832011)(66476007)(8676002)(53546011)(86362001)(4326008)(4744005)(66946007)(31696002)(8936002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SjRBK05sdkc0YU5HRE9mZTdUQk95RWkxc1NXa09ZWDIva2dmQjBlaFVkS0Fu?=
 =?utf-8?B?WXo1TitRc212TFlMUE81QnpTUjdTYm1sWnJ6RXVXQk9sbkZvZXlUNGk1VWc3?=
 =?utf-8?B?dzhEVFRZdGN6QXZEeVJnNlpYSXJ4U0x4c1dCUzdaZi9XN3ExMDZ3NFRDSUYz?=
 =?utf-8?B?Mi92NzJya3RxM0RSTnpTTFBveG5HeGVEcEtUYnJKR2hnL1QwZldZZUMveDBs?=
 =?utf-8?B?VmhxaHVoamtaVHZ5RTlQMzJWS21wZHdkZlVlN2J5UHh5SktpQlU5UnVidndk?=
 =?utf-8?B?TElzTDlGQlJiQk5DRTZBVmtXQks5RjVhNkV2bzZxdTFtM3BCTjZhYkpzUGlx?=
 =?utf-8?B?RmpGL2E1UGpvUlZJc3cxV2g1cXVEQWVnUXFnQlRzbitmc3BCMzBVMmw3N2FM?=
 =?utf-8?B?RE9zc04vRnhKVHlkVnVsa3BuR1ZFV2FZeWZhbkZCTktscy9iM08vWERHblhJ?=
 =?utf-8?B?WnpLdHlzbFJBc3JQbSt3SFQ3NllJOXJFZ2JZeWNsZ3dnSzhIRU80NjJqSDdT?=
 =?utf-8?B?TlJiRkhERUM5ZDNrbldRbWhMZnNWajExanAxRExjMUlXcnJWUllBUlQwS2tH?=
 =?utf-8?B?L0oxUW5WS3NaNlNtMCttVXlQNWx1em9FeXFYdDhTcll5V1BJWm8zTUJ6Y21P?=
 =?utf-8?B?T09MR0F3aVM3aHVwSjZRc3hoU2FKaTNhNTZoSUY2dUlQUkMxc1lWVnRCUGRr?=
 =?utf-8?B?WWtRYnJCVDd4NHBmcGlORHpxOGFSNFVFMTJWOTZiM1N0MG8ydjNMN1k0TE5C?=
 =?utf-8?B?ZVZYWUhPdnhKVHNicDZRajFnaERJYkZvRi8weTlZR2xtcEp6dlhHcXNFSXNs?=
 =?utf-8?B?c1ZRdS9nNXE4UlozVE0wM2FPZE5oSDNvSnkrL3Y0Uno4eDcvQkY2YlVrQTQ5?=
 =?utf-8?B?S0NlVUlkWkJpa0hObGRIWHBnNk5RV3ZrSE9YNFBnQy9XZ3hGTlAydVppRERP?=
 =?utf-8?B?MnYxREV2dUdtUXpPVGVJSEU3YThOQVpONWYreXgwRFJuVUFwRWtLc0pZOUtY?=
 =?utf-8?B?dlV4N3lpaG9DOFhFakYwREcwNmlmem8ySnJFdFcrL05tMGFaR0F5YzJxVm1S?=
 =?utf-8?B?b0o0S3dhSnl5Z0lkWFU5eHZoUXAza2xNSG5NU2lsVU9jMFA1a0tCVFBEa0k5?=
 =?utf-8?B?d0U3djFneHRTNGZFKzFIYnZ1anZaS0ZUdm9MOWJNRXk1VkRZRlZlN2xDUUp2?=
 =?utf-8?B?ZU9LTVA3ZUtxVW1HQ1hNTEZtUG0zZStQRGd2WEJBb0ZoR3ZyMkRYeFJsQWR2?=
 =?utf-8?B?Q2JxQ2RuMmN5R0x2eDlDU3lYU1RKTkxaMnJuS3UxZlRKTVJaRlZUWlRBYVI1?=
 =?utf-8?B?SkJneDN6TTNsYlMyaGVyZk1RTzRVaW5MaXZiMVFRaWNjK2ZDc05odThvV1di?=
 =?utf-8?B?bCtqZ3RzYVl1RXVMQXY3TFVUMHJYUEgwUVdnS3VqVGg5VzMyYTFDcStydXNn?=
 =?utf-8?B?andVbFZoTld4YkZLeFowbmw3UnVVQXRZSlVZQW1YRFJ5N2tNT0hBeldPQmJ2?=
 =?utf-8?B?Y2EzRmZUaCtvOFpUZWhnL0ZyQzJLRERXa1Jqa29DY3pRUWw0T2JudWNFVVRk?=
 =?utf-8?B?RUtKZkx6UFBsaWpNZWM3RkNMMmdpdllyQXMvSFBxN1BBaUw0RjFnU2VRdDRu?=
 =?utf-8?B?LzNMUE5oUjJqMVZzUngxNDE4NUMzUXBXM3JzaTBOdWRWOTQ5SzM1bVZEVThC?=
 =?utf-8?B?ZG44VkI4VHlyQjFVeDdsZ09Ua0xwdDZENkcwcThhaTdNYXpUT2YrY2hLUE1X?=
 =?utf-8?B?VVR4aHk1MkJJVEF4UkJOTkM5QzZKYlMzbGtxeC9VZlFMbW9EUWowWm5TUFpB?=
 =?utf-8?B?a2NIdEFiTmtKZjdyMkh5RDgyZW5xQmJzVXk1RFNMVjMwTVlUYXlveVdUR3hS?=
 =?utf-8?B?a0tQa0J1SnhuMHVic3NkN3hnRnFIQTQ1cXZDdkFRUldQV2dvcGZBODVpbWIx?=
 =?utf-8?B?TXNIdHoxT0VnVU1TZHZWY084WHpBV05XSkxZWFJPNUNMY1RIZEJ2QVJYbThY?=
 =?utf-8?B?bWp2T3J4NXJVRXA0aXVEQWIwMFJMV25qSUVTRFRsbWFoN3JFaVRCYmcvcllH?=
 =?utf-8?B?dCtOUDdBdy9naUp6MUdSQThHRDRGRlpoV3k0cTdmQXAvanVnTHRCaTJVWjBX?=
 =?utf-8?B?U3VGbU5oOW4xNVREL2laMThUK29Rd0V5d0FDS0FURFM3MnZQek1IWXV6eSs0?=
 =?utf-8?B?R2pJZlZwbVJQdXBVQ05ZTWdPdDYwN0lLUjNOam5BcmtxNXIrTHdDZmhwS1ZG?=
 =?utf-8?B?SkcyOGlTUWlOMDEyOFM3NkxOaHpxaHVYYXpEYzkyRmRvVGdOa3dROWlGK2dG?=
 =?utf-8?B?TzdkdmR3Qk5aQzJlUmJGMzNIeVJScWQvZ0RlK3prNEhRVTRqMU5QcENZWGJJ?=
 =?utf-8?Q?NRT+Iv5RPxDUF1Bk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9be7f60b-7015-4cec-2ac8-08da23dc0f9a
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 21:15:29.1791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GdGp+b2CD1/+TUUe+ITGwyza4nd450Eyb0Xk+BajYP01YLtLZL+RN2aIjLVQ5SoorybFLMobUuTMTLY9N9AFikNrb9bbb1bOHZxzoQMBNuw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1898
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-21_05:2022-04-21,2022-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204210110
X-Proofpoint-GUID: o1CQ6H-WCdqYeRwAsE-c-mW-L3QnWulw
X-Proofpoint-ORIG-GUID: o1CQ6H-WCdqYeRwAsE-c-mW-L3QnWulw


On 4/19/22 7:43 PM, Alaa Mohamed wrote:
> kmap() is being deprecated and these usages are all local to the thread
> so there is no reason kmap_local_page() can't be used.
>
> Replace kmap() calls with kmap_local_page().
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>


Applied to for-linus-5.18. (Juergen, I kept your R-b from v1)


-boris



From xen-devel-bounces@lists.xenproject.org Thu Apr 21 21:36:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 21:36:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310474.527338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nheTA-0007v3-HK; Thu, 21 Apr 2022 21:36:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310474.527338; Thu, 21 Apr 2022 21:36:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nheTA-0007uu-E9; Thu, 21 Apr 2022 21:36:08 +0000
Received: by outflank-mailman (input) for mailman id 310474;
 Thu, 21 Apr 2022 21:36:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nheT9-0007uW-Dc; Thu, 21 Apr 2022 21:36:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nheT9-0002ie-Ce; Thu, 21 Apr 2022 21:36:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nheT8-0002Ls-W4; Thu, 21 Apr 2022 21:36:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nheT8-0007VO-VZ; Thu, 21 Apr 2022 21:36:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t4vWgjUDHpefXYDFvKAsUeo/6oUM+fRL9YjZ0QTHlNM=; b=uUK0BCIO3BBWOIifo7eVXIS18h
	jhbVPhDtAPV9MXM1G6rbJ6cULFkSDvnRpdS4VkMTg0bSLWBlmiu5a8YED11zm3JhtHKpp95oqKLwj
	2JTOtci7hwqeDpcv/tsVrR3wGZmVmTKFWqTclzqU4wLfA9HW6tfsWMJWtDOmmECr03oo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169600-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169600: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 21:36:06 +0000

flight 169600 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169600/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  544 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 21:36:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 21:36:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310473.527327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nheT4-0007dz-AD; Thu, 21 Apr 2022 21:36:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310473.527327; Thu, 21 Apr 2022 21:36:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nheT4-0007ds-73; Thu, 21 Apr 2022 21:36:02 +0000
Received: by outflank-mailman (input) for mailman id 310473;
 Thu, 21 Apr 2022 21:36:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nheT2-0007dm-DV
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 21:36:00 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 080406e3-c1bb-11ec-8fc2-03012f2f19d4;
 Thu, 21 Apr 2022 23:35:58 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 58800B82970;
 Thu, 21 Apr 2022 21:35:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA0C2C385A7;
 Thu, 21 Apr 2022 21:35:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 080406e3-c1bb-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650576956;
	bh=yXB4mQK4iaZ2rCsosmZLTLjlMBo2v1CK80qV0ZcfujI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=o3DJitXgswCZQbbk3JfpP8rXuwPW7tYpiUNH8IXKg398s2xQPolGhkQ0w4dOblcQA
	 2qxsHbix79le9SC35/WErytfU9+z4ug/vTxOfWtRdcn0tpuAfbDN67mG5fS+cUdKB5
	 BHO7/3J47AhKDpb+7Y3ft+zZRkTf/7bi1ESkP9ljgmwYHn1KXqwpz0MA2A1gm3V2tT
	 4DuJK+tNzpgsHVyJTtmO9XugL2ARkoyGLva9/f85tzv2Y2KKR2a8a1xSVwZLLXN5f/
	 VUozOXByubZhWGchT2q3xNe3bxHAuRyzK6wZ7j4n5x3TTbWEolnACtSWblEE3O+ZlF
	 vOxhd7SPe7B2A==
Date: Thu, 21 Apr 2022 14:35:55 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <Wei.Chen@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, nd@arm.com, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 03/10] xen/arm: add CONFIG_ARM_EFI to stub EFI API
In-Reply-To: <265745cb-40f4-22d8-8c85-ffc89b2baf04@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204211435460.915916@ubuntu-linux-20-04-desktop>
References: <20220418090735.3940393-1-wei.chen@arm.com> <20220418090735.3940393-4-wei.chen@arm.com> <alpine.DEB.2.22.394.2204201724430.915916@ubuntu-linux-20-04-desktop> <265745cb-40f4-22d8-8c85-ffc89b2baf04@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 21 Apr 2022, Wei Chen wrote:
> Hi Stefano,
> 
> On 2022/4/21 8:25, Stefano Stabellini wrote:
> > On Mon, 18 Apr 2022, Wei Chen wrote:
> > > x86 is using compiler feature testing to decide EFI
> > > build enable or not. When EFI build is disabled, x86
> > > will use a efi/stub.c file to replace efi/runtime.c
> > > for build objects. Following this idea, we introduce
> > > a stub file for Arm, but use CONFIG_ARM_EFI to decide
> > > EFI build enable or not.
> > > 
> > > Signed-off-by: Wei Chen <wei.chen@arm.com>
> > > ---
> > > v1 -> v2:
> > > 1. Use CONFIG_ARM_EFI to replace CONFIG_EFI
> > > 2. Remove help text and make CONFIG_ARM_EFI invisible.
> > > 3. Merge one following patch:
> > >     xen/arm: introduce a stub file for non-EFI architectures
> > > 4. Use the common stub.c instead of creating new one.
> > > ---
> > >   xen/arch/arm/Kconfig      | 5 +++++
> > >   xen/arch/arm/Makefile     | 2 +-
> > >   xen/arch/arm/efi/Makefile | 5 +++++
> > >   3 files changed, 11 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > index ecfa6822e4..5f1b0121b0 100644
> > > --- a/xen/arch/arm/Kconfig
> > > +++ b/xen/arch/arm/Kconfig
> > > @@ -6,6 +6,7 @@ config ARM_64
> > >   	def_bool y
> > >   	depends on !ARM_32
> > >   	select 64BIT
> > > +	select ARM_EFI
> > >   	select HAS_FAST_MULTIPLY
> > >     config ARM
> > > @@ -33,6 +34,10 @@ config ACPI
> > >   	  Advanced Configuration and Power Interface (ACPI) support for Xen is
> > >   	  an alternative to device tree on ARM64.
> > >   +config ARM_EFI
> > > +	bool
> > > +	depends on ARM_64
> > 
> > As ARM_EFI is selected by ARM_64 and it cannot be enable via a menu (it
> > is hidden) there is no need for the "depends" line here
> > 
> 
> Ok, I will remove it.
> 
> > 
> > >   config GICV3
> > >   	bool "GICv3 driver"
> > >   	depends on ARM_64 && !NEW_VGIC
> > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> > > index 1d862351d1..bb7a6151c1 100644
> > > --- a/xen/arch/arm/Makefile
> > > +++ b/xen/arch/arm/Makefile
> > > @@ -1,6 +1,5 @@
> > >   obj-$(CONFIG_ARM_32) += arm32/
> > >   obj-$(CONFIG_ARM_64) += arm64/
> > > -obj-$(CONFIG_ARM_64) += efi/
> > >   obj-$(CONFIG_ACPI) += acpi/
> > >   obj-$(CONFIG_HAS_PCI) += pci/
> > >   ifneq ($(CONFIG_NO_PLAT),y)
> > > @@ -20,6 +19,7 @@ obj-y += domain.o
> > >   obj-y += domain_build.init.o
> > >   obj-y += domctl.o
> > >   obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
> > > +obj-y += efi/
> > >   obj-y += gic.o
> > >   obj-y += gic-v2.o
> > >   obj-$(CONFIG_GICV3) += gic-v3.o
> > > diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile
> > > index 4313c39066..75ef180233 100644
> > > --- a/xen/arch/arm/efi/Makefile
> > > +++ b/xen/arch/arm/efi/Makefile
> > > @@ -1,4 +1,9 @@
> > >   include $(srctree)/common/efi/efi-common.mk
> > >   +ifeq ($(CONFIG_ARM_EFI),y)
> > >   obj-y += $(EFIOBJ-y)
> > >   obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
> > > +else
> > > +EFIOBJ-y += stub.o
> > > +obj-y += stub.o
> > 
> > The change to EFIOBJ-y is not needed here as EFIOBJ-y is not used.
> > Only obj-y += stub.o should be enough
> > 
> 
> I add stub.o to EFIOBJ-y that's because I want to use the clean-files
> in efi-common.mk. Otherwise the link of stub.c in arm/efi will not
> be cleaned in "make clean".

I see. Makes sense.


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 22:01:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 22:01:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310487.527349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nherr-0003gz-Ll; Thu, 21 Apr 2022 22:01:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310487.527349; Thu, 21 Apr 2022 22:01:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nherr-0003gs-Hr; Thu, 21 Apr 2022 22:01:39 +0000
Received: by outflank-mailman (input) for mailman id 310487;
 Thu, 21 Apr 2022 22:01:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nherq-0003gl-3E
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 22:01:38 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9cc71d17-c1be-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 00:01:36 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 62834B826CB;
 Thu, 21 Apr 2022 22:01:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B9BEC385A5;
 Thu, 21 Apr 2022 22:01:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cc71d17-c1be-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650578494;
	bh=1tesikSwyZurh75SXK/LLwrfwkYRq134cw9ak39qSa8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=VafdCrHrOxUod/JDNWujyqsqKTuRkPUdR5CiZ0O9WW+NZY5+wBQGxSc/BKEaxLJUq
	 70gCZPPdVVnHkNRX8Zmmnbaj3ab4E8B7wChvFhERnPZrLZRi9I3/luaEmg19mh++Rx
	 QzfdSh5MnD21oexo7OEdzBjuBnysIYhbc/OrvFHmP7NEznecxCQeDGHF0JAespyb+W
	 VrhV6mlRiB+9KXVwc6MTRuiLXetOSwuegr+ZP3fP7ZmrkywWPD3QaMpl0s0X2jRt0t
	 3pZBDUUogeaA1kgJey0Sn3csqEmriB2CemCtvYK1LcXwOfR4FI5mB72Ji4B4at2e4z
	 Mmz3LJZO/IndA==
Date: Thu, 21 Apr 2022 15:01:32 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <Rahul.Singh@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Christoph Hellwig <hch@lst.de>, xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>, 
    "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
In-Reply-To: <12279FAE-2141-469E-A424-9984348E84BB@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204211444190.915916@ubuntu-linux-20-04-desktop>
References: <C82612B1-FED5-4139-9B87-FB33DD81F01A@arm.com> <alpine.DEB.2.22.394.2204131354190.3066615@ubuntu-linux-20-04-desktop> <8C511888-6183-421E-A4C7-B271DAF46696@arm.com> <alpine.DEB.2.22.394.2204141329290.894007@ubuntu-linux-20-04-desktop>
 <20220415063705.GA24262@lst.de> <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop> <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com> <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop> <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop> <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com> <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop> <12279FAE-2141-469E-A424-9984348E84BB@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1560539718-1650577465=:915916"
Content-ID: <alpine.DEB.2.22.394.2204211444270.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1560539718-1650577465=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204211444271.915916@ubuntu-linux-20-04-desktop>

On Thu, 21 Apr 2022, Rahul Singh wrote:
> > On 20 Apr 2022, at 11:46 pm, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > On Wed, 20 Apr 2022, Rahul Singh wrote:
> >>> On 20 Apr 2022, at 3:36 am, Stefano Stabellini <sstabellini@kernel.org> wrote:
> >>>>> Then there is xen_swiotlb_init() which allocates some memory for
> >>>>> swiotlb-xen at boot. It could lower the total amount of memory
> >>>>> available, but if you disabled swiotlb-xen like I suggested,
> >>>>> xen_swiotlb_init() still should get called and executed anyway at boot
> >>>>> (it is called from arch/arm/xen/mm.c:xen_mm_init). So xen_swiotlb_init()
> >>>>> shouldn't be the one causing problems.
> >>>>> 
> >>>>> That's it -- there is nothing else in swiotlb-xen that I can think of.
> >>>>> 
> >>>>> I don't have any good ideas, so I would only suggest to add more printks
> >>>>> and report the results, for instance:
> >>>> 
> >>>> As suggested I added the more printks but only difference I see is the size apart
> >>>> from that everything looks same .
> >>>> 
> >>>> Please find the attached logs for xen and native linux boot.
> >>> 
> >>> One difference is that the order of the allocations is significantly
> >>> different after the first 3 allocations. It is very unlikely but
> >>> possible that this is an unrelated concurrency bug that only occurs on
> >>> Xen. I doubt it.
> >> 
> >> I am not sure but just to confirm with you, I see below logs in every scenario.
> >> SWIOTLB memory allocated by linux swiotlb and used by xen-swiotlb. Is that okay or it can cause some issue.
> >> 
> >> [    0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off
> >> [    0.000000] software IO TLB: mapped [mem 0x00000000f4000000-0x00000000f8000000] (64MB)
> >> 
> >> snip from int __ref xen_swiotlb_init(int verbose, bool early)
> >> /*                                                                         
> >>      * IO TLB memory already allocated. Just use it.                           
> >>      */                                                                        
> >>     if (io_tlb_start != 0) {                                                   
> >>         xen_io_tlb_start = phys_to_virt(io_tlb_start);                         
> >>         goto end;                                                              
> >>     }
> > 
> > Unfortunately there is nothing obvious in the logs. I think we need to
> > look at the in-details executions of Linux on Xen with swiotlb-xen and
> > Linux on Xen without swiotlb-xen. The comparison with Linux on native is
> > not very interesting because the memory layout is a bit different.
> > 
> > The comparison between the two executions should be simple because
> > swiotlb-xen should be transparent: in this simple case swiotlb-xen
> > should end up calling always the same functions that would end up being
> > called anyway without swiotlb-xen. Basically, it should only add a
> > couple of extra steps in between, nothing else.
> > 
> > As we have already discussed:
> > 
> > - [no swiotlb-xen] dma_alloc_attrs --> dma_direct_alloc
> > - [swiotlb-xen] dma_alloc_attrs --> xen_swiotlb_alloc_coherent --> dma_direct_alloc
> > 
> > The result should be identical. In xen_swiotlb_alloc_coherent the code
> > path taken should be:
> > 
> > - xen_alloc_coherent_pages
> > - if (((dev_addr + size - 1 <= dma_mask)) &&
> >      !range_straddles_page_boundary(phys, size)) {
> >      *dma_handle = dev_addr;
> > - return ret
> > 
> > So basically, it should make zero difference. That is expected because
> > swiotlb-xen really only comes into play for domU pages. For booting
> > dom0, it should only be a "useless" indirection.
> > 
> > In the case of xen_swiotlb_map_page, it should be similar. The path
> > taken should be:
> > 
> > 	if (dma_capable(dev, dev_addr, size, true) &&
> > 	    !range_straddles_page_boundary(phys, size) &&
> > 		!xen_arch_need_swiotlb(dev, phys, dev_addr) &&
> > 		swiotlb_force != SWIOTLB_FORCE)
> > 		goto done;
> > 
> > which I think should correspond to this prints in your logs at line 400:
> > 
> >    DEBUG xen_swiotlb_map_page 400 phys=80003c4f000 dev_addr=80003c4f000
> > 
> > So that should be OK too. If different paths are taken, then we have a
> > problem. If the paths above are taken there should be zero difference
> > between the swiotlb-xen and the non-swiotlb-xen cases.
> > 
> > Which brings me to your question about xen_swiotlb_init and this
> > message:
> > 
> >    software IO TLB: mapped [mem 0x00000000f4000000-0x00000000f8000000] (64MB)
> > 
> > The swiotlb-xen buffer should *not* be used if the code paths taken are
> > the ones above. So it doesn't matter if it is allocated or not. You
> > could comment out the code in xen_swiotlb_init and everything should
> > still behave the same.
> > 
> > Finally, my suggestion. Considering all the above, I would look *very*
> > closely at the execution of Linux on Xen with and without swiotlb-xen.
> > The differences should be really minimal. Adds prints to all the
> > swiotlb-xen functions, but really only the following should matter:
> > - xen_swiotlb_alloc_coherent
> > - xen_swiotlb_map_page
> > - xen_swiotlb_unmap_page
> > 
> > What are the differences between the two executions? From the logs:
> > 
> > - the allocation of the swiotlb-xen buffer which leads to 64MB of less
> >  memory available, but actually if you compared to Linux on Xen
> >  with/without swiotlb-xen this different would go away because
> >  xen_swiotlb_init would be called in both cases anyway
> > 
> > - the size upgrade in xen_swiotlb_alloc_coherent: I can see several
> >  instances of the allocation size being increased. Is that causing the
> >  problem? It seems unlikely and you have already verified it is not the
> >  case by removing the size increase in xen_swiotlb_alloc_coherent
> > 
> > - What else is different? There *must* be something, but it is not
> >  showing in the logs so far.
> > 
> > 
> > The only other observation that I have, but it doesn't help, is that the
> > failure happens on the second 4MB allocation when there is another
> > concurrent memory allocation of 4K. Neither the 4MB nor the 4K are
> > size-upgrades by xen_swiotlb_alloc_coherent.
> > 
> > 4MB is an larger-than-usual size, but it shouldn't make that much of a
> > difference. Is that problem that the 4MB have to be contiguous? I don't
> > see how swiotlb-xen could have an impact in that regard, if not for the
> > size increase in xen_swiotlb_alloc_coherent.
> > 
> > Please let me know what you find.
> 
> I debug the issue more today and found out that the only difference when
> calling dma_alloc_attrs() from the NVMe driver [1] and the other driver is the
> attribute “DMA_ATTR_NO_KERNEL_MAPPING". 

This is progress!


> I remove the attribute "DMA_ATTR_NO_KERNEL_MAPPING” before
> calling the xen_alloc_coherent_pages() , NVMe DMA allocation is successful
> and the issue is not observed.
> 
> Do you have any idea why attribute DMA_ATTR_NO_KERNEL_MAPPING is
> causing the the issue with xen-swiotlb.

Yes, if you look at xen_swiotlb_free_coherent, it is clear that things
won't work for the DMA_ATTR_NO_KERNEL_MAPPING case. Can you have a try
at the patch below?

---
swiotlb-xen: handle DMA_ATTR_NO_KERNEL_MAPPING

If DMA_ATTR_NO_KERNEL_MAPPING is set then the returned vaddr is a struct
*page instead of the virtual mapping of the buffer.

In xen_swiotlb_alloc_coherent, do not call virt_to_page, instead use the
returned pointer directly. Also do not memset the buffer or struct page
to zero.

In xen_swiotlb_free_coherent, check DMA_ATTR_NO_KERNEL_MAPPING and set
the page pointer appropriately.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 2b385c1b4a99..22d8779d3ac0 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -318,15 +318,21 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	    !range_straddles_page_boundary(phys, size))
 		*dma_handle = dev_addr;
 	else {
+		struct page *page;
+
 		if (xen_create_contiguous_region(phys, order,
 						 fls64(dma_mask), dma_handle) != 0) {
 			xen_free_coherent_pages(hwdev, size, ret, (dma_addr_t)phys, attrs);
 			return NULL;
 		}
 		*dma_handle = phys_to_dma(hwdev, *dma_handle);
-		SetPageXenRemapped(virt_to_page(ret));
+
+		if (attrs & DMA_ATTR_NO_KERNEL_MAPPING)
+			page = ret;
+		else
+			virt_to_page(ret);
+		SetPageXenRemapped(page);
 	}
-	memset(ret, 0, size);
 	return ret;
 }
 
@@ -349,7 +355,9 @@ xen_swiotlb_free_coherent(struct device *hwdev, size_t size, void *vaddr,
 	/* Convert the size to actually allocated. */
 	size = 1UL << (order + XEN_PAGE_SHIFT);
 
-	if (is_vmalloc_addr(vaddr))
+	if (attrs & DMA_ATTR_NO_KERNEL_MAPPING)
+		page = vaddr;
+	else if (is_vmalloc_addr(vaddr))
 		page = vmalloc_to_page(vaddr);
 	else
 		page = virt_to_page(vaddr);
--8323329-1560539718-1650577465=:915916--


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 22:31:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 22:31:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310492.527360 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhfKL-0007uI-VE; Thu, 21 Apr 2022 22:31:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310492.527360; Thu, 21 Apr 2022 22:31:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhfKL-0007uB-Rw; Thu, 21 Apr 2022 22:31:05 +0000
Received: by outflank-mailman (input) for mailman id 310492;
 Thu, 21 Apr 2022 22:31:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhfKK-0007u1-JD; Thu, 21 Apr 2022 22:31:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhfKK-0003lA-Fr; Thu, 21 Apr 2022 22:31:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhfKK-0003ew-49; Thu, 21 Apr 2022 22:31:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhfKK-0003d1-3h; Thu, 21 Apr 2022 22:31:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5AOtfX5MNLwUs5wqO0ki8GVwNpdMeLFK6KHsB9SZDoA=; b=ZEqDevkZt3T8RXohXTk+vYZ+3K
	wJtmlAVrQKTtf1OOW9kae18xYpbDJEAlvqVsr5qyrzOKypw9+Bm9ko7fxf0OzVbYa/8ZXmc5jTfdO
	j9B7UPkKIB67ihGGVkmJaXYn+6B923SUG0oNh8hraapNUZAauTH2ujKiWdadkrHP8bCA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169595-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169595: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=b1efff6bf031a93b5b8bf3912ddc720cc1653a61
X-Osstest-Versions-That:
    qemuu=9c125d17e9402c232c46610802e5931b3639d77b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 22:31:04 +0000

flight 169595 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169595/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169584
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169584
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169584
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169584
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169584
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169584
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169584
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169584
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                b1efff6bf031a93b5b8bf3912ddc720cc1653a61
baseline version:
 qemuu                9c125d17e9402c232c46610802e5931b3639d77b

Last test of basis   169584  2022-04-21 06:18:36 Z    0 days
Testing same since   169595  2022-04-21 15:39:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Kardashevskiy <aik@ozlabs.ru>
  Bernhard Beschow <shentey@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Fabiano Rosas <farosas@linux.ibm.com>
  Frederic Barrat <fbarrat@linux.ibm.com>
  Guo Zhi <qtxuning1999@sjtu.edu.cn>
  Joel Stanley <joel@jms.id.au>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   9c125d17e9..b1efff6bf0  b1efff6bf031a93b5b8bf3912ddc720cc1653a61 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 22:57:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 22:57:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310501.527371 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhfk8-0002zP-80; Thu, 21 Apr 2022 22:57:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310501.527371; Thu, 21 Apr 2022 22:57:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhfk8-0002zI-4s; Thu, 21 Apr 2022 22:57:44 +0000
Received: by outflank-mailman (input) for mailman id 310501;
 Thu, 21 Apr 2022 22:57:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhfk6-0002z8-T6; Thu, 21 Apr 2022 22:57:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhfk6-0004BG-RN; Thu, 21 Apr 2022 22:57:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhfk6-0004Fc-BK; Thu, 21 Apr 2022 22:57:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhfk6-0006YM-Ar; Thu, 21 Apr 2022 22:57:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6ri88QXByL+p8YLqOZoemqO+bhQYX/X8u14EJCHR3/I=; b=XKF5Iofklhyzby+LDz7Sp48U7+
	vilwWCskCQBYORCL7rV6w5YvdnKUU+4HPHNtkry3NsZk1gXabPDf9vbbGkhPR5+kjjxgUl7XjvJCC
	6ltqmvTSwFDZuQXalglCx9MuOAeNbQdc/rr5x1UWGhs5aRQ38YI6eFofsX+llxB9FVGE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169602-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169602: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 22:57:42 +0000

flight 169602 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169602/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  545 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 23:18:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 23:18:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310511.527381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhg46-00062o-1p; Thu, 21 Apr 2022 23:18:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310511.527381; Thu, 21 Apr 2022 23:18:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhg45-00062h-UT; Thu, 21 Apr 2022 23:18:21 +0000
Received: by outflank-mailman (input) for mailman id 310511;
 Thu, 21 Apr 2022 23:18:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhg44-00062Z-JS
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 23:18:20 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 52dfda99-c1c9-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 01:18:17 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1491261EA5;
 Thu, 21 Apr 2022 23:18:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FA51C385A7;
 Thu, 21 Apr 2022 23:18:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52dfda99-c1c9-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650583095;
	bh=wAlm6QlmE5vrtKgm8mKwkm92dsQdTmg8jgylRHRpKdM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=b897pQ7WHELW+y5IW3gX5iFYkZIYjG0pt0fYwKpwF0fJ2UPrcuw2/AAK79KjVqOHq
	 GWD38s9mo5gJ+8cmot8ULakTF5q7mJsUotB16K5O/J6EjdzdufWebUEzfIKF/MjZbZ
	 Ddoc+en+ZHhGH+9iK+GFpNNS9n42vhrDjqPbAwtzQb2H+PuBGElnHjemsTZXI/xFKG
	 7FiI87aERh7BQNpiRNZQW0yusoPkcLtt81oKluFSzBlha69OClxG9HcZr6YHm0Emc+
	 QW8H30gahXOIui3mZnX3AXE6Yf367eX951iFD2IKI3nQ4026nd3/JRWM06Gy5aopMo
	 UlhMOvpdiGvaw==
Date: Thu, 21 Apr 2022 16:18:14 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, cardoe@cardoe.com, wl@xen.org, 
    andrew.cooper3@citrix.com, anthony.perard@citrix.com, 
    bertrand.marquis@arm.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v5 2/2] gitlab-ci: add an ARM32 qemu-based smoke test
In-Reply-To: <404e095e-6645-6f00-40e1-64574a6d2c3e@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204211618080.915916@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204151715100.915916@ubuntu-linux-20-04-desktop> <20220416001701.1301324-2-sstabellini@kernel.org> <6e01871e-9e47-2d92-617e-952dde2df3b2@arm.com> <alpine.DEB.2.22.394.2204201630330.915916@ubuntu-linux-20-04-desktop>
 <404e095e-6645-6f00-40e1-64574a6d2c3e@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 21 Apr 2022, Michal Orzel wrote:
> On 21.04.2022 01:31, Stefano Stabellini wrote:
> > 
> > Oops, yes I did. Well spotted. Just sending this one update here.
> > 
> > 
> > ---
> > gitlab-ci: add an ARM32 qemu-based smoke test
> > 
> > Add a minimal ARM32 smoke test based on qemu-system-arm, as provided by
> > the test-artifacts qemu container. The minimal test simply boots Xen
> > (built from previous build stages) and Dom0.
> > 
> > The test needs a working kernel and minimal initrd for dom0. Instead of
> > building our own kernel and initrd, which would mean maintaining one or
> > two more builting scripts under automation/, we borrow a kernel and
> > initrd from distros.
> > 
> > For the kernel we pick the Debian Bullseye kernel, which has everything
> > we need already built-in. However, we cannot use the Debian Bullseye
> > initrd because it is 22MB and the large size causes QEMU to core dump.
> > 
> > Instead, use the tiny busybox-based rootfs provided by Alpine Linux,
> > which is really minimal: just 2.5MB. Note that we cannot use the Alpine
> > Linux kernel because that doesn't boot on Xen.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Thanks!


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 23:26:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 23:26:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310518.527401 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhgCL-0007vI-S4; Thu, 21 Apr 2022 23:26:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310518.527401; Thu, 21 Apr 2022 23:26:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhgCL-0007vB-P3; Thu, 21 Apr 2022 23:26:53 +0000
Received: by outflank-mailman (input) for mailman id 310518;
 Thu, 21 Apr 2022 23:26:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhgCJ-0007v5-Pc
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 23:26:51 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 84f621d5-c1ca-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 01:26:50 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 7C710B82978;
 Thu, 21 Apr 2022 23:26:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD181C385A5;
 Thu, 21 Apr 2022 23:26:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84f621d5-c1ca-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650583608;
	bh=JszuH5Z2k/2vz2+ErU6pnEK+7BLb3wyHYrzClhfUa7o=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=NE045yV2p921GdSZktWkB76oY1IOXecvnwKO+O61wzqJd4jzd8LGfMr+4U5D1kOLb
	 J1UzlOkR2kEGRWycHdNCenBEuVvFeltmfRdlL1t7QEg3usOj7jpVPpBxF0HA3e6Bxn
	 m1fLoXTWBoSbRHmpqMP0mVLD+yB1+7mLc8ygaAJjpK/AFnJMsSJocIhvaQ4uilvXgf
	 laNqgYiBDHkqzfXXLTIMPhEUCx2j5KG0J5Ei7uW9/iCLN09s/aRgCfpq52994tlcDq
	 uTiWWbcCQoC1QiuCmlXTUDIADFKHEJz8rJdVS15zB2wTxG2g6GwRGJxkVpBQ0eyzKK
	 oIJuoVlirCtaA==
Date: Thu, 21 Apr 2022 16:26:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Paran Lee <p4ranlee@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, austindh.kim@gmail.com, 
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/arm: p2m_set_entry duplicate calculation.
In-Reply-To: <20220421151755.GA4718@DESKTOP-NK4TH6S.localdomain>
Message-ID: <alpine.DEB.2.22.394.2204211626400.915916@ubuntu-linux-20-04-desktop>
References: <20220421151755.GA4718@DESKTOP-NK4TH6S.localdomain>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Apr 2022, Paran Lee wrote:
> It doesn't seem necessary to do that calculation of order shift again.
> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  xen/arch/arm/p2m.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 1d1059f7d2..533afc830a 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1092,7 +1092,7 @@ int p2m_set_entry(struct p2m_domain *p2m,
>      while ( nr )
>      {
>          unsigned long mask;
> -        unsigned long order;
> +        unsigned long order, pages;
>  
>          /*
>           * Don't take into account the MFN when removing mapping (i.e
> @@ -1118,11 +1118,12 @@ int p2m_set_entry(struct p2m_domain *p2m,
>          if ( rc )
>              break;
>  
> -        sgfn = gfn_add(sgfn, (1 << order));
> +        pages = 1 << order;
> +        sgfn = gfn_add(sgfn, pages);
>          if ( !mfn_eq(smfn, INVALID_MFN) )
> -           smfn = mfn_add(smfn, (1 << order));
> +           smfn = mfn_add(smfn, pages);
>  
> -        nr -= (1 << order);
> +        nr -= pages;
>      }
>  
>      return rc;
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 23:53:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 23:53:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310523.527411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhgbc-0003hK-Ux; Thu, 21 Apr 2022 23:53:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310523.527411; Thu, 21 Apr 2022 23:53:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhgbc-0003hD-Rm; Thu, 21 Apr 2022 23:53:00 +0000
Received: by outflank-mailman (input) for mailman id 310523;
 Thu, 21 Apr 2022 23:52:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=45zg=U7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhgbb-0003h7-Mx
 for xen-devel@lists.xenproject.org; Thu, 21 Apr 2022 23:52:59 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ba8723c-c1ce-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 01:52:58 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 7A2EDB829CB;
 Thu, 21 Apr 2022 23:52:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D055AC385A5;
 Thu, 21 Apr 2022 23:52:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ba8723c-c1ce-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650585176;
	bh=eykvC1d/EQJg4BjjlNBNB1jP5F6IGL/ShzWX84n1eO0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Qh3U8RjECIFd4RfxAtj2sY4YEg0iZ3RZLQ3deuMYuxASbsBoGibkVtPjk+sGD5W4k
	 dN56YjsI+Voy26CqnE/f0p8IDkW8vCMPoRn9RJ1L8zsnwZRnlaYhg5bZN5sLhRevkl
	 znQ60oo4UuH19Il8BEq+YzcMpWtVVfHErAznHSRoWT0mYk6lmSK0okttfTSb3R/l/+
	 LuCfQcEut0gIWzQCrrCGa/DvHmtiVDcrXDfXn2DzI+7ZdRj1gyQJ49I6k1tWwraLyj
	 DSz7PEV9S9nZgFI6GPH+cTr5xc3SMtqx3WlHD4oGkf5HAoFxC9hrcficDWx4WQoet4
	 tUzuA784dhHgg==
Date: Thu, 21 Apr 2022 16:52:55 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Paran Lee <p4ranlee@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    austindh.kim@gmail.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/device_tree: silence ambiguous integer casting
 warning error
In-Reply-To: <20220419154619.GA3136@DESKTOP-NK4TH6S.localdomain>
Message-ID: <alpine.DEB.2.22.394.2204211638390.915916@ubuntu-linux-20-04-desktop>
References: <20220419154619.GA3136@DESKTOP-NK4TH6S.localdomain>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1793672686-1650584546=:915916"
Content-ID: <alpine.DEB.2.22.394.2204211642310.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1793672686-1650584546=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204211642311.915916@ubuntu-linux-20-04-desktop>

On Wed, 20 Apr 2022, Paran Lee wrote:
> GCC with "-g -Wall -Wextra" option throws warning message as below:
> 
> error: comparison of integer expressions of different signedness:
>  ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
> 
> Silence the warning by correcting the integer type.
> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>

Thanks for the patch, this is a good improvement.



> ---
>  xen/common/device_tree.c | 31 +++++++++++++++----------------
>  1 file changed, 15 insertions(+), 16 deletions(-)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 4aae281e89..402e465c7a 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -79,7 +79,7 @@ struct dt_bus
>      const char *addresses;
>      bool_t (*match)(const struct dt_device_node *node);
>      void (*count_cells)(const struct dt_device_node *child,
> -                        int *addrc, int *sizec);
> +                        unsigned int *addrc, unsigned int *sizec);
>      u64 (*map)(__be32 *addr, const __be32 *range, int na, int ns, int pna);
>      int (*translate)(__be32 *addr, u64 offset, int na);
>      unsigned int (*get_flags)(const __be32 *addr);
> @@ -569,7 +569,7 @@ static bool_t dt_bus_default_match(const struct dt_device_node *node)
>  }
>  
>  static void dt_bus_default_count_cells(const struct dt_device_node *dev,
> -                                int *addrc, int *sizec)
> +                                       unsigned int *addrc, unsigned int *sizec)
>  {
>      if ( addrc )
>          *addrc = dt_n_addr_cells(dev);
> @@ -649,7 +649,7 @@ static bool_t dt_bus_pci_match(const struct dt_device_node *np)
>  }
>  
>  static void dt_bus_pci_count_cells(const struct dt_device_node *np,
> -				   int *addrc, int *sizec)
> +				   unsigned int *addrc, unsigned int *sizec)
>  {
>      if (addrc)
>          *addrc = 3;

Although I don't necessarily mind these two changes to
dt_bus_default_count_cells and dt_bus_pci_count_cells as they are
improvements, I don't see how they are related to the "comparison of
integer expressions of different signedness" problem.

I definitely see the comparison between "i" and "imaplen" below for
instance but where is the problematic integers comparison in the case of
"na" and "ns"?

It would help to post the GCC output that you are getting with all the
warnings for this file.


> @@ -737,7 +737,7 @@ static const struct dt_bus dt_busses[] =
>  
>  static const struct dt_bus *dt_match_bus(const struct dt_device_node *np)
>  {
> -    int i;
> +    long unsigned int i;

Just write is as "unsigned long" for uniformity with the rest of the
code


>      for ( i = 0; i < ARRAY_SIZE(dt_busses); i++ )
>          if ( !dt_busses[i].match || dt_busses[i].match(np) )
> @@ -754,7 +754,8 @@ static const __be32 *dt_get_address(const struct dt_device_node *dev,
>      u32 psize;
>      const struct dt_device_node *parent;
>      const struct dt_bus *bus;
> -    int onesize, i, na, ns;
> +    unsigned int i;
> +    unsigned int onesize, na, ns;
>  
>      /* Get parent & match bus type */
>      parent = dt_get_parent(dev);
> @@ -797,8 +798,7 @@ static int dt_translate_one(const struct dt_device_node *parent,
>                              int pna, const char *rprop)
>  {
>      const __be32 *ranges;
> -    unsigned int rlen;
> -    int rone;
> +    unsigned int rlen, rone;
>      u64 offset = DT_BAD_ADDR;
>  
>      ranges = dt_get_property(parent, rprop, &rlen);
> @@ -857,7 +857,7 @@ static u64 __dt_translate_address(const struct dt_device_node *dev,
>      const struct dt_device_node *parent = NULL;
>      const struct dt_bus *bus, *pbus;
>      __be32 addr[DT_MAX_ADDR_CELLS];
> -    int na, ns, pna, pns;
> +    unsigned int na, ns, pna, pns;
>      u64 result = DT_BAD_ADDR;
>  
>      dt_dprintk("DT: ** translation for device %s **\n", dev->full_name);


In this function na and ns get printed a few times. We should convert
%d to %u.


Also, if we are going to change na and ns to unsigned int, then I think
we should also do it in dt_read_number and dt_translate_one. Not
necessarily in this patch though.


> @@ -966,8 +966,7 @@ int dt_for_each_range(const struct dt_device_node *dev,
>      const struct dt_bus *bus, *pbus;
>      const __be32 *ranges;
>      __be32 addr[DT_MAX_ADDR_CELLS];
> -    unsigned int rlen;
> -    int na, ns, pna, pns, rone;
> +    unsigned int rlen, na, ns, pna, pns, rone;
>  
>      bus = dt_match_bus(dev);
>      if ( !bus )
> @@ -1134,7 +1133,7 @@ unsigned int dt_number_of_address(const struct dt_device_node *dev)
>      u32 psize;
>      const struct dt_device_node *parent;
>      const struct dt_bus *bus;
> -    int onesize, na, ns;
> +    unsigned int onesize, na, ns;
>  
>      /* Get parent & match bus type */
>      parent = dt_get_parent(dev);
> @@ -1169,8 +1168,8 @@ int dt_for_each_irq_map(const struct dt_device_node *dev,
>      const struct dt_device_node *ipar, *tnode, *old = NULL;
>      const __be32 *tmp, *imap;
>      u32 intsize = 1, addrsize, pintsize = 0, paddrsize = 0;
> -    u32 imaplen;
> -    int i, ret;
> +    u32 i, imaplen;
> +    int ret;
>  
>      struct dt_raw_irq dt_raw_irq;
>      struct dt_irq dt_irq;
> @@ -1354,8 +1353,8 @@ static int dt_irq_map_raw(const struct dt_device_node *parent,
>      const struct dt_device_node *ipar, *tnode, *old = NULL, *newpar = NULL;
>      const __be32 *tmp, *imap, *imask;
>      u32 intsize = 1, addrsize, newintsize = 0, newaddrsize = 0;
> -    u32 imaplen;
> -    int match, i;
> +    u32 i, imaplen;
> +    int match;
>  
>      dt_dprintk("dt_irq_map_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n",
>                 parent->full_name, be32_to_cpup(intspec),
> @@ -1737,7 +1736,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np,
>  
>              if ( out_args )
>              {
> -                int i;
> +                u32 i;
>  
>                  WARN_ON(count > MAX_PHANDLE_ARGS);
>                  if (count > MAX_PHANDLE_ARGS)

These changes are great, thanks! I wouldn't mind a patch that only
changes "i" in __dt_parse_phandle_with_args, dt_irq_map_raw,
dt_for_each_irq_map, dt_match_bus. Those changes are straightforward.
--8323329-1793672686-1650584546=:915916--


From xen-devel-bounces@lists.xenproject.org Thu Apr 21 23:59:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Apr 2022 23:59:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310528.527423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhgha-0004NW-K1; Thu, 21 Apr 2022 23:59:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310528.527423; Thu, 21 Apr 2022 23:59:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhgha-0004NP-H4; Thu, 21 Apr 2022 23:59:10 +0000
Received: by outflank-mailman (input) for mailman id 310528;
 Thu, 21 Apr 2022 23:59:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhghZ-0004N9-GD; Thu, 21 Apr 2022 23:59:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhghZ-0005E5-1l; Thu, 21 Apr 2022 23:59:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhghY-0007qL-M1; Thu, 21 Apr 2022 23:59:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhghY-0002Uh-La; Thu, 21 Apr 2022 23:59:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+o1d+2jdX5UiQY2S3t58pcXeJTGd/+BGGXcG1JMZT+Y=; b=wAs0Iy+7CD87WxPCO3eRw++p9w
	+G2yWN2T95aKLNhRm4Qc6PHmks2lOmvVZo64q4rapA5UJrIuRdlXyL8cB9Gj5kMrt8A0z9s1ZSST9
	EuuGXXUU96L1qlmbtDY9lZW4l69W9c1npNds4OCwPvch/9kcpasxbDnBsjy7w2xUqPWA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169604-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169604: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Apr 2022 23:59:08 +0000

flight 169604 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169604/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  546 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 00:03:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 00:03:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310539.527433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhglz-0006oc-Dd; Fri, 22 Apr 2022 00:03:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310539.527433; Fri, 22 Apr 2022 00:03:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhglz-0006oV-Am; Fri, 22 Apr 2022 00:03:43 +0000
Received: by outflank-mailman (input) for mailman id 310539;
 Fri, 22 Apr 2022 00:03:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhgly-0006oP-1V
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 00:03:42 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa3b633a-c1cf-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 02:03:40 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 94B6261EE7;
 Fri, 22 Apr 2022 00:03:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9943BC385A7;
 Fri, 22 Apr 2022 00:03:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa3b633a-c1cf-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650585819;
	bh=ROR6Gdgt9my5XqbGGDRFeSrSNlmuUJyzMdLwP1EFD2Q=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=muY203xxbEkaAcASdbLhi5+ByB1SLuSvVb7EUi4Q/wOu09DBwQBs/gMzF68QJCBcV
	 KElUnADL7TuQQaoPom8PjmAwNglYPfHdjwRZ5KZ5oHjVXinYLkgMlmkfgeonpXPOxb
	 58CxzlU3nt9v6fQXyEtA6cpR21bnr4l4+dV6yEmQ1DUJfsT4hWmxpJqbfHKPbwNNNh
	 iFXWqIhH93tj0tun0rf9HgCkwMt7WsO3D/9TWMOGqo1nwkMm6pKv7J4Z9JfsdvFsO5
	 OZnlfFcB15OwgbuYaj+kXWqQUgrS/A1RybpkCUVj8jqe0th6MweJ2YRgYl1tqnLkTz
	 VwTwJIyAatd6A==
Date: Thu, 21 Apr 2022 17:03:37 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Paran Lee <p4ranlee@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Austin Kim <austindh.kim@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/arm: silence ambiguous integer casting warning
 error
In-Reply-To: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
Message-ID: <alpine.DEB.2.22.394.2204211654380.915916@ubuntu-linux-20-04-desktop>
References: <20220419154126.GA1518@DESKTOP-NK4TH6S.localdomain>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-547296852-1650585819=:915916"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-547296852-1650585819=:915916
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 20 Apr 2022, Paran Lee wrote:

> GCC with "-g -Wall -Wextra" option throws warning message as below:
> 
> error: comparison of integer expressions of different signedness:
>  ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
> 
> Silence the warning by correcting the integer type.
> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>

Thanks for the cleanup!


> ---
>  xen/arch/arm/gic-v3.c | 5 +++--
>  xen/arch/arm/setup.c  | 2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 3c472ed768..81ac25f528 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -916,7 +916,8 @@ static void gicv3_hyp_disable(void)
>      isb();
>  }
>  
> -static u16 gicv3_compute_target_list(int *base_cpu, const struct cpumask *mask,
> +static u16 gicv3_compute_target_list(unsigned int *base_cpu,
> +                                     const struct cpumask *mask,
>                                       uint64_t cluster_id)
>  {
>      int cpu = *base_cpu;

I think we need to change cpu to unsigned int too to make it consistent


> @@ -953,7 +954,7 @@ out:
>  
>  static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t *cpumask)
>  {
> -    int cpu = 0;
> +    unsigned int cpu = 0;
>      uint64_t val;
>  
>      for_each_cpu(cpu, cpumask)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index d5d0792ed4..5ab2aaecaf 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -862,7 +862,7 @@ void __init start_xen(unsigned long boot_phys_offset,
>                        unsigned long fdt_paddr)
>  {
>      size_t fdt_size;
> -    int cpus, i;
> +    unsigned int cpus, i;
>      const char *cmdline;
>      struct bootmodule *xen_bootmodule;
>      struct domain *d;

I can see that we should change i to unsigned int.

cpus could cause a comparison between signed and unsigned int here:

  if ( (num_online_cpus() < cpus) && !cpu_online(i) )

num_online_cpus returns an int
--8323329-547296852-1650585819=:915916--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 00:25:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 00:25:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310544.527444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhh6c-0001Qw-6E; Fri, 22 Apr 2022 00:25:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310544.527444; Fri, 22 Apr 2022 00:25:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhh6c-0001Qp-3K; Fri, 22 Apr 2022 00:25:02 +0000
Received: by outflank-mailman (input) for mailman id 310544;
 Fri, 22 Apr 2022 00:25:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pzHF=VA=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nhh6b-0001Qj-8G
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 00:25:01 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a2f2f251-c1d2-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 02:24:58 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23M0OjT1006761
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Thu, 21 Apr 2022 20:24:51 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23M0Og3P006760;
 Thu, 21 Apr 2022 17:24:42 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2f2f251-c1d2-11ec-8fc2-03012f2f19d4
Message-Id: <dc05a59dc0e186f9dcec8d0e877ee80af168b6a8.1650551981.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wl@xen.org>
Date: Thu, 21 Apr 2022 07:35:14 -0700
Subject: [PATCH] scripts/add_maintainers.pl: add -o as an alternative to
 --patchdir
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=1.5 required=10.0 tests=DATE_IN_PAST_06_12,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

This matches the output directory option used by `git format-patch`.  I
suspect I'm not the only one who finds matching `git format-patch` more
intuitive, than -d for directory.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 scripts/add_maintainers.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/add_maintainers.pl b/scripts/add_maintainers.pl
index 5a6d0f631b..380e8da22a 100755
--- a/scripts/add_maintainers.pl
+++ b/scripts/add_maintainers.pl
@@ -32,7 +32,7 @@ $get_maintainer =~ s/add_maintainers/get_maintainer/;
 my $usage = <<EOT;
 OPTIONS:
 --------
-USAGE: $tool [options] (--patchdir | -d) <patchdir>
+USAGE: $tool [options] (--patchdir | -d | -o) <patchdir>
 
   --reroll-count <n> | -v <n>
     Choose patch files for specific version. This results into the
@@ -223,7 +223,7 @@ my $patch_ext           = ".patch";
 my $maintainers         = "MAINTAINERS";
 
 if (!GetOptions(
-                'd|patchdir=s'     => \$patch_dir,
+                'd|o|patchdir=s'   => \$patch_dir,
                 'v|reroll-count=i' => \$rerollcount,
                 'p|patchcc=s'      => \$plocation,
                 'c|covercc=s'      => \$clocation,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 00:26:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 00:26:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310552.527456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhh7t-000200-Gu; Fri, 22 Apr 2022 00:26:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310552.527456; Fri, 22 Apr 2022 00:26:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhh7t-0001zt-DC; Fri, 22 Apr 2022 00:26:21 +0000
Received: by outflank-mailman (input) for mailman id 310552;
 Fri, 22 Apr 2022 00:26:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pzHF=VA=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nhh7s-0001zi-Et
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 00:26:20 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3f30e4f-c1d2-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 02:26:19 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23M0Q68r006777
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Thu, 21 Apr 2022 20:26:11 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23M0Q5WC006776;
 Thu, 21 Apr 2022 17:26:05 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3f30e4f-c1d2-11ec-a405-831a346695d4
Message-Id: <cover.1650551486.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Date: Thu, 21 Apr 2022 07:31:26 -0700
Subject: [PATCH 0/1] Adjust odd Python bindings
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=1.5 required=10.0 tests=DATE_IN_PAST_06_12,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

First off, this isn't properly tested.  I know it compiles, but that may
not mean much when this encounters the Real World.

I'm doing initial exploration for a project involving Xen.  Python seems
a good language for the project, so I'm trying out the Python bindings
for Xen.

What I've noticed is the bindings seem wrong.  Importing xen.lowlevel.xc,
then creating a xen.lowlevel.xc.xc() object has too many layers.  The
extra ".xc" is a distinct mismatch for comparable tools.  As such I'm
trying to get rid of the duplicated layer for both xc and xs.

The Python documentation indicates the name given to Extension() should
be the full name, not just the package name.  As such that is being
adjusted too.

I haven't yet done testing beyond confirming this builds, since further
checking will take some time to do...

I'm unsure how widely the Python bindings are used.  Certainly they were
used for PyGRUB.  Have any other projects used them so far?  What I'm
doing is likely to be contributed to the Xen Project, and I suspect the
existence of other projects would be known...

Elliott Mitchell (1):
  tools/python: move lowlevel packages one level up

 tools/pygrub/src/pygrub                 |  4 ++--
 tools/python/setup.py                   | 12 ++++++------
 tools/python/xen/lowlevel/{xc => }/xc.c |  0
 tools/python/xen/lowlevel/{xs => }/xs.c |  0
 4 files changed, 8 insertions(+), 8 deletions(-)
 rename tools/python/xen/lowlevel/{xc => }/xc.c (100%)
 rename tools/python/xen/lowlevel/{xs => }/xs.c (100%)

-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 00:27:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 00:27:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310562.527467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhh9A-0002b7-R8; Fri, 22 Apr 2022 00:27:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310562.527467; Fri, 22 Apr 2022 00:27:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhh9A-0002b0-OA; Fri, 22 Apr 2022 00:27:40 +0000
Received: by outflank-mailman (input) for mailman id 310562;
 Fri, 22 Apr 2022 00:27:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pzHF=VA=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nhh98-0002ap-WA
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 00:27:38 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02ba711d-c1d3-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 02:27:37 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23M0RO6s006798
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Thu, 21 Apr 2022 20:27:30 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23M0ROmH006797;
 Thu, 21 Apr 2022 17:27:24 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02ba711d-c1d3-11ec-8fc2-03012f2f19d4
Message-Id: <92e5016290be569916c82c255e911d469b1de2db.1650551486.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1650551486.git.ehem+xen@m5p.com>
References: <cover.1650551486.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Date: Wed, 20 Apr 2022 19:23:50 -0700
Subject: [PATCH 1/1] tools/python: move lowlevel packages one level up
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=1.2 required=10.0 tests=DATE_IN_PAST_12_24,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Prior to this a Python script first needed to import 3 levels of
packages, then invoke xen.lowlevel.$tool.$tool() to get a handle.  Now
only 2 levels of packages, then xen.lowlevel.$tool() gets a handle.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/pygrub/src/pygrub                 |  4 ++--
 tools/python/setup.py                   | 12 ++++++------
 tools/python/xen/lowlevel/{xc => }/xc.c |  0
 tools/python/xen/lowlevel/{xs => }/xs.c |  0
 4 files changed, 8 insertions(+), 8 deletions(-)
 rename tools/python/xen/lowlevel/{xc => }/xc.c (100%)
 rename tools/python/xen/lowlevel/{xs => }/xs.c (100%)

diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub
index ce7ab0eb8c..6b1989c7d8 100755
--- a/tools/pygrub/src/pygrub
+++ b/tools/pygrub/src/pygrub
@@ -18,7 +18,7 @@ import os, sys, string, struct, tempfile, re, traceback, stat, errno
 import copy
 import logging
 import platform
-import xen.lowlevel.xc
+import xen.lowlevel
 
 import curses, _curses, curses.textpad, curses.ascii
 import getopt
@@ -669,7 +669,7 @@ def run_grub(file, entry, fs, cfg_args):
     return grubcfg
 
 def supports64bitPVguest():
-    xc = xen.lowlevel.xc.xc()
+    xc = xen.lowlevel.xc()
     caps = xc.xeninfo()['xen_caps'].split(" ")
     for cap in caps:
         if cap == "xen-3.0-x86_64":
diff --git a/tools/python/setup.py b/tools/python/setup.py
index 8c95db7769..77546335b8 100644
--- a/tools/python/setup.py
+++ b/tools/python/setup.py
@@ -17,28 +17,28 @@ PATH_LIBXENCTRL = XEN_ROOT + "/tools/libs/ctrl"
 PATH_LIBXENGUEST = XEN_ROOT + "/tools/libs/guest"
 PATH_XENSTORE = XEN_ROOT + "/tools/libs/store"
 
-xc = Extension("xc",
+xc = Extension("xen.lowlevel.xc",
                extra_compile_args = extra_compile_args,
                include_dirs       = [ PATH_XEN,
                                       PATH_LIBXENTOOLLOG + "/include",
                                       PATH_LIBXENEVTCHN + "/include",
                                       PATH_LIBXENCTRL + "/include",
                                       PATH_LIBXENGUEST + "/include",
-                                      "xen/lowlevel/xc" ],
+                                      "xen/lowlevel" ],
                library_dirs       = [ PATH_LIBXENCTRL, PATH_LIBXENGUEST ],
                libraries          = [ "xenctrl", "xenguest" ],
                depends            = [ PATH_LIBXENCTRL + "/libxenctrl.so", PATH_LIBXENGUEST + "/libxenguest.so" ],
                extra_link_args    = SHLIB_libxenctrl + SHLIB_libxenguest,
-               sources            = [ "xen/lowlevel/xc/xc.c" ])
+               sources            = [ "xen/lowlevel/xc.c" ])
 
-xs = Extension("xs",
+xs = Extension("xen.lowlevel.xs",
                extra_compile_args = extra_compile_args,
-               include_dirs       = [ PATH_XEN, PATH_XENSTORE + "/include", "xen/lowlevel/xs" ],
+               include_dirs       = [ PATH_XEN, PATH_XENSTORE + "/include", "xen/lowlevel" ],
                library_dirs       = [ PATH_XENSTORE ],
                libraries          = [ "xenstore" ],
                depends            = [ PATH_XENSTORE + "/libxenstore.so" ],
                extra_link_args    = SHLIB_libxenstore,
-               sources            = [ "xen/lowlevel/xs/xs.c" ])
+               sources            = [ "xen/lowlevel/xs.c" ])
 
 plat = os.uname()[0]
 modules = [ xc, xs ]
diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc.c
similarity index 100%
rename from tools/python/xen/lowlevel/xc/xc.c
rename to tools/python/xen/lowlevel/xc.c
diff --git a/tools/python/xen/lowlevel/xs/xs.c b/tools/python/xen/lowlevel/xs.c
similarity index 100%
rename from tools/python/xen/lowlevel/xs/xs.c
rename to tools/python/xen/lowlevel/xs.c
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 00:37:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 00:37:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310583.527478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhhI8-0004UL-Mq; Fri, 22 Apr 2022 00:36:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310583.527478; Fri, 22 Apr 2022 00:36:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhhI8-0004UE-J0; Fri, 22 Apr 2022 00:36:56 +0000
Received: by outflank-mailman (input) for mailman id 310583;
 Fri, 22 Apr 2022 00:36:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhhI7-0004U8-5m
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 00:36:55 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4e8b1515-c1d4-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 02:36:53 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2FFF5B829CF;
 Fri, 22 Apr 2022 00:36:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 623EDC385A5;
 Fri, 22 Apr 2022 00:36:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e8b1515-c1d4-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650587812;
	bh=q77UrqyhbHNMDbtjl23QSlBQJqBW2qP/oerjc/apOe0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=O8K3b3ix/Aoq1gJHNVNPUCqoWFQCq5larOk4rtjfKjmMzsI3R228DrK0i5oZVxhnB
	 xMu4yAbbvCnQMv+SNmGHPNiWBehcWGZ/7PwvzIHEWMmbyhRYfJGCfUQ7XMXhNptv3Y
	 Ik1QPXzlX3MVQZhtndW7G0GzqkRrfZlnO6XIotP3waUhFWTeEYl8qJYnSZHK6RmPPJ
	 63zDZGVx+kWkl9j3jmADIPqrSZPP04Yi0rHW2X8RyGjDPlsaD62ZmLE0Ep4nwKBQ1l
	 N0qjuXKWN9v+PpLfp1PDZWXyOSYbQD1cpPaKDlB8HA14Fgmk0BLSPI2qbtB2xGsa73
	 zy0oqZI4WmJSQ==
Date: Thu, 21 Apr 2022 17:36:50 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Miaoqian Lin <linmq006@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Russell King <linux@armlinux.org.uk>, 
    Shannon Zhao <shannon.zhao@linaro.org>, 
    Catalin Marinas <catalin.marinas@arm.com>, 
    Julien Grall <julien.grall@arm.com>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org, 
    linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm/xen: Fix some refcount leaks
In-Reply-To: <20220420014913.2586-1-linmq006@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204211727060.915916@ubuntu-linux-20-04-desktop>
References: <20220406021905.GA30436@8345e2a12d0c> <20220420014913.2586-1-linmq006@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 20 Apr 2022, Miaoqian Lin wrote:
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, We should use of_node_put() on it when done
> Add the missing of_node_put() to release the refcount.
> 
> Fixes: 9b08aaa3199a ("ARM: XEN: Move xen_early_init() before efi_init()")
> Fixes: b2371587fe0c ("arm/xen: Read extended regions from DT and init Xen resource")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Juergen,  Boris,
I applied the patch to for-linus-5.18


> ---
> changes in v2:
> - call of_node_put in non-error path in xen_dt_guest_init
> - fix same refcount leak error in arch_xen_unpopulated_init
> ---
>  arch/arm/xen/enlighten.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index ec5b082f3de6..07eb69f9e7df 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -337,12 +337,15 @@ int __init arch_xen_unpopulated_init(struct resource **res)
>  
>  	if (!nr_reg) {
>  		pr_err("No extended regions are found\n");
> +		of_node_put(np);
>  		return -EINVAL;
>  	}
>  
>  	regs = kcalloc(nr_reg, sizeof(*regs), GFP_KERNEL);
> -	if (!regs)
> +	if (!regs) {
> +		of_node_put(np);
>  		return -ENOMEM;
> +	}
>  
>  	/*
>  	 * Create resource from extended regions provided by the hypervisor to be
> @@ -403,8 +406,8 @@ int __init arch_xen_unpopulated_init(struct resource **res)
>  	*res = &xen_resource;
>  
>  err:
> +	of_node_put(np);
>  	kfree(regs);
> -
>  	return rc;
>  }
>  #endif
> @@ -424,8 +427,10 @@ static void __init xen_dt_guest_init(void)
>  
>  	if (of_address_to_resource(xen_node, GRANT_TABLE_INDEX, &res)) {
>  		pr_err("Xen grant table region is not found\n");
> +		of_node_put(xen_node);
>  		return;
>  	}
> +	of_node_put(xen_node);
>  	xen_grant_frames = res.start;
>  }
>  
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 01:15:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 01:15:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310590.527489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhhsr-0008FW-HK; Fri, 22 Apr 2022 01:14:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310590.527489; Fri, 22 Apr 2022 01:14:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhhsr-0008FP-EI; Fri, 22 Apr 2022 01:14:53 +0000
Received: by outflank-mailman (input) for mailman id 310590;
 Fri, 22 Apr 2022 01:14:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FogU=VA=canb.auug.org.au=sfr@srs-se1.protection.inumbo.net>)
 id 1nhhso-0008FI-Vm
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 01:14:52 +0000
Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 975d26ca-c1d9-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 03:14:47 +0200 (CEST)
Received: from authenticated.ozlabs.org (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.ozlabs.org (Postfix) with ESMTPSA id 4KkxJv1RSRz4xPw;
 Fri, 22 Apr 2022 11:14:39 +1000 (AEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 975d26ca-c1d9-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au;
	s=201702; t=1650590080;
	bh=PDwdWAr3d36JH4WWt/FccU1tk8rwMVXRWseC7stMlsM=;
	h=Date:From:To:Cc:Subject:From;
	b=Gb0CDA7eukAe0P/i42k0HOKCRwRH1jA0+DZp3nt5xb6JkQ0rWrOxTtzbS5rtS9cAv
	 m/ID0RHAA+E/piY2anrEQd5QWOOlJoOnGbpUDDsWmwZarEAHd96x5Xfdyb/0xRtKli
	 jaB8pUmxihzbcKKPSdjUj9g6VFjN8HaVt8QJOLW7yQ/umCokGXl3jqn1BmpQdi69RZ
	 QS/r6LCAsohc24zzjcrIkr8+qfXhqY4bvWJlSlsj/IKYqkDFIvzUDcoqZIOTtmZt0J
	 nvG7qNLx+AksBZXA1fJwifkgEQFuxI8SeaVpgjQvl9ky6J1/sRhwQkhU3g9ddUBYaY
	 8Bhl8Thc6Z31Q==
Date: Fri, 22 Apr 2022 11:14:38 +1000
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Juergen Gross <jgross@suse.com>, Konrad Rzeszutek Wilk
 <konrad.wilk@oracle.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Xen Devel
 <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <stefano.stabellini@xilinx.com>, Linux Kernel Mailing
 List <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: linux-next: Signed-off-by missing for commit in the xen-tip tree
Message-ID: <20220422111438.3946dbae@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Acwu5MAWinYu7DVgoSV1rm.";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/Acwu5MAWinYu7DVgoSV1rm.
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

Commit

  b12d41716e32 ("arm/xen: Fix some refcount leaks")

is missing a Signed-off-by from its committer.

--=20
Cheers,
Stephen Rothwell

--Sig_/Acwu5MAWinYu7DVgoSV1rm.
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmJiAX4ACgkQAVBC80lX
0GzLbQf/cAY5DZMoJcCtPP8hz0H5FOYfij/KKWzsQQ2SwET5tZnJunLuHEgGyaMQ
nAZK8EBg4cGBoabLnmdSzYL1gT68MlQJu3YPkBDPXmiJwZ0byd1LYMdex5z3isG/
ttkeb6VzAflpwtMGT3rS/C9ClH/WdISXofDOHK8jrQVKgZyg9fuC1pi0yfwlw80O
WgKGPAjawSdG6rh4urP0M9RoFH0bDoV1T66NYPflGMUqXC3pEQpEFiq27mXkwu38
5yk0zlGMy8YsW9J0pmgDU3foENCua+CqYppn61WgA+FDrfzPCVu6Q2BWdRfuHBh0
QvlCAOMLaHN4AL9g6aiI/X1YtqWZQQ==
=kNGi
-----END PGP SIGNATURE-----

--Sig_/Acwu5MAWinYu7DVgoSV1rm.--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 01:15:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 01:15:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310593.527500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhhtI-0000C4-QS; Fri, 22 Apr 2022 01:15:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310593.527500; Fri, 22 Apr 2022 01:15:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhhtI-0000Bv-MV; Fri, 22 Apr 2022 01:15:20 +0000
Received: by outflank-mailman (input) for mailman id 310593;
 Fri, 22 Apr 2022 01:15:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhhtH-0000BZ-KK; Fri, 22 Apr 2022 01:15:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhhtH-0004yU-Hn; Fri, 22 Apr 2022 01:15:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhhtH-0003EK-3k; Fri, 22 Apr 2022 01:15:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhhtH-00062D-3I; Fri, 22 Apr 2022 01:15:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=n6i89Tko/Van+A77wFWc3P+6dkFdHClLC0jFhlrLGsM=; b=wsMrCZeim9Ln1kPKoDtA8x3JmH
	tcHPtwqdUXp9b8ec8Lwo69sCrOvCoNnjHF6iNC/iLugsDVviUDdmBzP0+XjBgYscp21BiWVvRCIZG
	nbPEYor5F4wtSzLWOjzU99UtiLfvQgWmEb014naZp9CAXnMqOx2ku4xBi89CRAlS4nN0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169606-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169606: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 01:15:19 +0000

flight 169606 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169606/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   51 days  547 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 01:17:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 01:17:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310603.527510 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhhvS-00012C-Ae; Fri, 22 Apr 2022 01:17:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310603.527510; Fri, 22 Apr 2022 01:17:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhhvS-000125-7n; Fri, 22 Apr 2022 01:17:34 +0000
Received: by outflank-mailman (input) for mailman id 310603;
 Fri, 22 Apr 2022 01:17:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2Gha=VA=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nhhvQ-00011x-SL
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 01:17:33 +0000
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fa567f6f-c1d9-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 03:17:31 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 00B773204C42;
 Thu, 21 Apr 2022 21:17:27 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Thu, 21 Apr 2022 21:17:28 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 21 Apr 2022 21:17:26 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa567f6f-c1d9-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650590247; x=
	1650676647; bh=QWT3dbAmUvyabDJUMuZpvTjLmuuGeRRGSg6uQOlr4Nk=; b=b
	nZBbUJ9qksaSSNy91F2QrNz2iCVGdrtUfjfYJBXRYFqF7elJOIa/V8Gng08lJh0H
	Y1CDpnxviT9H56iffyjEJdSt4mBmQaSJHa6ZQ+b+7qiDZTEi75dGrxfvBjtXjvQh
	rRAKawrcUZrJNTPhLpPT3RwzwpJ1k3+Ng4ejWMMWPSmsW4A27jLOEXl6waB74IfU
	C/i3ZAURjg5qlbx0ht8HgWDX3L6lMVDQey+0ynwlCaXf28ZlwvG9NXq44l/JbS82
	j7Ai90VRyDUIp7THWVzpAZKVddOorOuH6yw7qZxjGe89URzyr3y99hKkborYdlMq
	uzRgnWaHowzKy8PrGVRAQ==
X-ME-Sender: <xms:JwJiYsHaysRo9p-Ot2o9doSJSBuEmCeothrGehqPscProo9qa7D7pw>
    <xme:JwJiYlWmylq-nUvz8KAk1xeYkIotLBWPLTZTTg7389HhTBePcwkpDysoE2EYOlgpg
    LmeK0fUqWzkqA>
X-ME-Received: <xmr:JwJiYmKIdb1yDZLIdlDOBm9bDqT_4rsQZ3sRkdyU6xo4rzejHnSLpiNQnkrfeNebd2XJlEoIMfdZ-W0R54b2PfrANzse_9-Qkg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrtdefgdeggecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeekgfel
    ueffhfekkeefffelvdefffettefhtdetkeejudeihefgveevvdefjefhueenucffohhmrg
    hinhepghhithdrihhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi
    lhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg
    homh
X-ME-Proxy: <xmx:JwJiYuGJzj5ov-nb0-hl62QAOuOcbD6rDdY69yaDjjFAeDytCQtVIg>
    <xmx:JwJiYiWfgMMF_sRisc9vkPcpOodmjq18CTO_6cdg4aIEEGmbzXoQ_Q>
    <xmx:JwJiYhOdwRmnFYHJ1MclSp4ollCvMiDycIe-p6bJCmOK7PIFI7G4Ew>
    <xmx:JwJiYleQHig7dLTpAZQMc-vhpCRXnuRkQyPXb5FdaxpbgLJlYt10Ww>
Date: Fri, 22 Apr 2022 03:17:23 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH 0/1] Adjust odd Python bindings
Message-ID: <YmICI1BPTBIqdgBq@mail-itl>
References: <cover.1650551486.git.ehem+xen@m5p.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="AxwdiV6ExxuBrUzG"
Content-Disposition: inline
In-Reply-To: <cover.1650551486.git.ehem+xen@m5p.com>


--AxwdiV6ExxuBrUzG
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 22 Apr 2022 03:17:23 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH 0/1] Adjust odd Python bindings

On Thu, Apr 21, 2022 at 07:31:26AM -0700, Elliott Mitchell wrote:
> I'm unsure how widely the Python bindings are used.  Certainly they were
> used for PyGRUB.  Have any other projects used them so far?  What I'm
> doing is likely to be contributed to the Xen Project, and I suspect the
> existence of other projects would be known...

Yes, Python bindings are used outside of xen.git. I'm aware of few
places in Qubes OS, but I expect there are other users too. So, I'm
afraid breaking the current import method isn't really an option. What
you could try, is to make both versions work at the same time, but TBH
I'm not sure how to do that with C extension.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--AxwdiV6ExxuBrUzG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmJiAiMACgkQ24/THMrX
1yz6wQf/cIPnIRxyOglAypJxmkOB99sDBRozgGKP0UjlAVZ7gHhE9mdcounJNNgN
XajK56k8+NQGfcJXjGBEEpnyJqsDXX5sl382c4NFVewgZf4jso2CiTl3YDzisKz8
KFTsRldcZeqZs7X0+Ly7ypHjgCDe3AJ/9XsDw9FNYhntdS/3gDURhA4yNfq8uwKC
5ShvPdM10dR5tPNC6ZC/k39JF3fosqkzQN/TGxLcWXATlqhKWvXCJZSfSigoPQg4
sarX9heJ1DcmvzXHxH94aT/6WX1ZlAkZkWDx/HgzV4gs2ymAaPh8ov8a2NktTUrX
+NLH/QK0zmbbp97ZRcdbnH6u12Xefg==
=4Q1I
-----END PGP SIGNATURE-----

--AxwdiV6ExxuBrUzG--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 01:52:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 01:52:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310617.527522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhiSo-0006dj-1V; Fri, 22 Apr 2022 01:52:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310617.527522; Fri, 22 Apr 2022 01:52:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhiSn-0006dc-U3; Fri, 22 Apr 2022 01:52:01 +0000
Received: by outflank-mailman (input) for mailman id 310617;
 Fri, 22 Apr 2022 01:52:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pzHF=VA=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nhiSm-0006dU-JP
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 01:52:00 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb0eebeb-c1de-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 03:51:58 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23M1phrv007102
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Thu, 21 Apr 2022 21:51:49 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23M1ph7Q007101;
 Thu, 21 Apr 2022 18:51:43 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb0eebeb-c1de-11ec-a405-831a346695d4
Date: Thu, 21 Apr 2022 18:51:43 -0700
From: Elliott Mitchell <ehem+undef@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Xen Domain Configuration file issue
Message-ID: <YmIKLzhVWENKnDEI@mattapan.m5p.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

I've been considering weaknesses with the `xendomains` script and how one
might address them.  In the process I've run head-on into some rather odd
design choices with Xen domain configuration handling.

The obvious place to dump domain start/stop configuration information is
into the domain.cfg files themselves.  One favored way to do this is to
stick the configuration information into comment sections.  This has
advantages and disadvantages.  Another way is if the file format syntax
allows it, simply stick the information into the main portion of the
files.

This lead to two observations.  First, domain.cfg files can have
arbitrary extra sections added and `xl create` doesn't complain about
unknown sections.  Second, unrecognized settings in domain.cfg files are
*completely* ignored.  Having these two characteristics combined is
extremely odd.

Complaining about unknown settings is the most common UI choice.  This
alerts users they've misconfigured things.  Sticking "colonel=XEN_EFI.fd"
is likely a configuration error.

On the flip side, since `xenstored` can hold more or less arbitrary
values, depositing unrecognized options there also seems reasonable.

Might the best behavior be for `xl create` to default to producing an
error if unrecognized options are found?  Then add a "-U" option to
`xl create` which places unrecognized options into the XenStore?

A replacement for `xendomains` script could then use `xl create -U` to
load domain.cfg files.  Configuration options it recognized could then be
consumed and if unrecognized options were left it would then complain.

Either approach is going to need some work on libxlutil.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Fri Apr 22 02:43:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 02:43:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310628.527533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhjGS-0005Q9-1k; Fri, 22 Apr 2022 02:43:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310628.527533; Fri, 22 Apr 2022 02:43:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhjGR-0005Q2-TK; Fri, 22 Apr 2022 02:43:19 +0000
Received: by outflank-mailman (input) for mailman id 310628;
 Fri, 22 Apr 2022 02:43:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xF4o=VA=arm.com=Jiamei.Xie@srs-se1.protection.inumbo.net>)
 id 1nhjGQ-0005Pv-6T
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 02:43:18 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on060e.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::60e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f551581b-c1e5-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 04:43:15 +0200 (CEST)
Received: from AS8PR04CA0055.eurprd04.prod.outlook.com (2603:10a6:20b:312::30)
 by VE1PR08MB5664.eurprd08.prod.outlook.com (2603:10a6:800:1ae::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 02:43:04 +0000
Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:312:cafe::6) by AS8PR04CA0055.outlook.office365.com
 (2603:10a6:20b:312::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Fri, 22 Apr 2022 02:43:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Fri, 22 Apr 2022 02:43:03 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Fri, 22 Apr 2022 02:43:02 +0000
Received: from a8588fb37557.3
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C549FC2D-2352-47F0-8B11-0FF0EAFA89FD.1; 
 Fri, 22 Apr 2022 02:42:52 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8588fb37557.3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 22 Apr 2022 02:42:52 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com (2603:10a6:803:3d::28)
 by AM8PR08MB6323.eurprd08.prod.outlook.com (2603:10a6:20b:354::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr
 2022 02:42:51 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::f42e:ad87:44e:2f67]) by VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::f42e:ad87:44e:2f67%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 02:42:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f551581b-c1e5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Mz1NLdAZXSfax8/knyL32k1Qnf63te+i4KRqrReehe4=;
 b=Ly5eP6/PSmiPpKvzw6vES9lGzdMivY9TIzc6rPV1RB5HAkuVZ36aBVB4X3Ge9SxoKIU9/hm/AAb95sQFaQNiaVYqJihxNs4o0A+bZCZnwVuWw/ZZhPA1TXEQQsb2mV90sPaLljOKQJFZnPhF/EDKDBVW7xgx7zSFI+jzNjBu3Q0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HV4dqa5bv+uHBKR4BunvbHCej+ZA5r2vTqID/djg6FhmCG78kyLcGt+kzbj12gJ4RVL71FOOB8btThxUc9WX8KqZhrI7bHqVvhQmLawzurieTPFe+79a3/yjXLE1m5dOqrcb8w09WvAIEYhTIEDz7Twd3GVbM9HZgc69S8pvYCowaOJ4/6lJ0BXPQueewlxSpIxR+jKXfl15OL1vJqjll9n/raWROT6u7VmFOVm5fJFgg9o+kL9Jt2vSjgeIWTMnrQsY0OuHNI1uhI2OfP94+m81ZISyeg+s32F6B7hWCEaPSljt2zLWJlhizwbjX8Bwl9BXkktds/TJTACCs9xJ5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Mz1NLdAZXSfax8/knyL32k1Qnf63te+i4KRqrReehe4=;
 b=AG0LCm82dz7JakHDFtUwBbAl399xG7vKpga9+TQheOE08wfAbajGPsPnzVJJgf13Ugmn06k/Bz689PA4pKaODLX7HPLcFUWNKxXpgOJLC53QLhwLOoZaP9oMYK/13MBGInkL2pRiMXibdAMHlBCQwhxYkDdFOGRjGYsapqgP9kn6YHSOUnz2nOpPWp/26jIMiGp+JQzoe7AKc9woyp1vDfwr/AXIBynsWEdG4luauURtJiot1yb89vdKztjTbg5+95REZsXyPwDUq2B9MpKeQh3BrtLwBopW5e0FdbuWqkjBUjx5DoIo2la4+6gxd/B+tzfOK5M87dUbUK9sbSkf5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Mz1NLdAZXSfax8/knyL32k1Qnf63te+i4KRqrReehe4=;
 b=Ly5eP6/PSmiPpKvzw6vES9lGzdMivY9TIzc6rPV1RB5HAkuVZ36aBVB4X3Ge9SxoKIU9/hm/AAb95sQFaQNiaVYqJihxNs4o0A+bZCZnwVuWw/ZZhPA1TXEQQsb2mV90sPaLljOKQJFZnPhF/EDKDBVW7xgx7zSFI+jzNjBu3Q0=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Julien Grall <Julien.Grall@arm.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Henry Wang <Henry.Wang@arm.com>, Oleksandr
 Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: RE: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
Thread-Topic: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
Thread-Index: AQHYS3WIibLynFptSU2M6YI1pBSl4Kz7TTLQ
Date: Fri, 22 Apr 2022 02:42:50 +0000
Message-ID:
 <VI1PR08MB3056B18C179244F174F0952F92F79@VI1PR08MB3056.eurprd08.prod.outlook.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1649442065-8332-3-git-send-email-olekstysh@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: EDD9F7E3A1DC6E4090808E6F52D99010.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 1a5744a2-6bc9-482d-92ac-08da2409d2cc
x-ms-traffictypediagnostic:
	AM8PR08MB6323:EE_|VE1EUR03FT021:EE_|VE1PR08MB5664:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB566412A048E4319AB59A209792F79@VE1PR08MB5664.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 8cbGBnL4HA8Psa1Owp1pNY6ryDXKd6XRHW3oOQ/83H9OOe5MmAA+Ip/oCH8L8qLFi6n+WDDwJNwCYeQ6xC64aVKR1LP8yQl97yH/1CqlNpKJJocMdDP5imGXuprY+QVqT12QdwzGG0C9QEzkcrwFPJGbZU3Q27c/RHP8eCHwUGe2Vgz355XFwodfXKmdaF44KYFvbT/2cLkZ6Dn66T1/2/0X6mj1qK367v038KKRwn4yjyHS1FoEyzumWJj3nhGHU1KAi/9VCydu9KjQZjo+0CkPyrgGHGhfmA3zjUhfhkQknxCnY4iH4d9IstwJElOzEfvEbTYhpjMRoTcKBEu3TmDGSvi5aTKuRrPg1pe+pFwQWg6UCoDevqq7Xy/iBbaqq4ZUJYUui1vDK+WmWhf/jcZ20dwA5aPZQ+rN4gyLaHe5DilYBMn26rW63ptfpW3RsfZdKuc/BTHugtUH0BSxCNNvgdxAfo4mfcRoFOWuc4i4k5SiNShgVhsJ1lsPBejyfOGfouCf9c2ZaWiUVcfojYjZ/chepyHFMs4bNPJ2Y/MCNTKcekeXdzKedcJyJksCbz3jbfQZUWM9keGaQKk6Yb6s0zDdD9oONq/LlUY981QPwGlaRT7O0zoc1a9LQc1ShEHQkje37xdpRR0VM93F2Jh7avWAOvEzBRw0ZPMJ5zmH59e+6siy343EVwJrXUn76vV6a22hO2IPdTioAOiNuw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3056.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(9686003)(26005)(38070700005)(38100700002)(71200400001)(7696005)(2906002)(6506007)(52536014)(122000001)(53546011)(508600001)(4326008)(8676002)(5660300002)(8936002)(55016003)(33656002)(186003)(76116006)(316002)(64756008)(110136005)(66446008)(54906003)(66476007)(66556008)(66946007)(83380400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6323
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8f4f67bf-3452-4ef7-adbb-08da2409cb45
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u95rcwCQWyi21Ubd1xXmzW3rtj0FUNzn4WgzYiUNICWOxXCayb6q2ev5fRNuhgH/bRP4tcRMz0OLy6VTKzTR/vOasuCLFaJmoY1DzVqXKXMpW0A7JXt/CeOxjnmivFJz0hX3esDPOr8XZR6z3dF9Sf5aVFc/D7Y+/zA/JAlQv7o5t7ISA77fJBQCdIDzkBzdUAhNMafZsWo6RAXHUF5o2ro1GYCJXbZXuP5++8FfCO1CGZEv5q/WSjLBkLLRtNQsH8k/vUSTM/LUCXb1zE69iQV/RhdhN1Pkqan/0bBnHOcMA3a7KABlaX4HWUATfLe22RxAXytbhlPHtW+iZQWVZnNS3SeDvhJKmZHEdDm/H6gBgIdhEqt2x7PC6rvys7yHW2cd8rS1DfBpOAFPpJbZd6Ye8KAteHYO5hITGfxBdwspqKyXrhjoTwbcCCARw7lwxud5NKJSrNNdg6rh3e5gn2mO8iQE8liQulWzJueze7KSPUJYVUjvhshzEyeTBiWjhAubQ+Y0P1VfP4GSO39ZbHs+8EG+1hNBnYDYMn7ChP4zSJgqOa7dQTheGkP7asxNVNfQBxdwL5sBBk9XfnHcD/tuPajEAYuCzaV29z1ExDgN6JFO/lFkL/KUJZlwPYd2kJfGQICOjbIvfWW5tlq7m1lzDkAb/iSEvuRpoRiIoo+JlqysTlhcLsD6OcGRhHXM
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(316002)(86362001)(40460700003)(9686003)(8936002)(36860700001)(7696005)(4326008)(336012)(8676002)(356005)(53546011)(52536014)(47076005)(5660300002)(83380400001)(110136005)(2906002)(54906003)(6506007)(55016003)(508600001)(107886003)(70586007)(70206006)(81166007)(33656002)(82310400005)(186003)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 02:43:03.4868
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5744a2-6bc9-482d-92ac-08da2409d2cc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5664

SGkgT2xla3NhbmRyLA0KDQogSSBhbSBoYXBweSB0byBrZWVwIG15IFQtYiB0YWcuICBJIGhhdmUg
dGVzdGVkIHRoaXMgbGF0ZXN0IHBhdGNoIHNlcmllcyBhbmQgaXQgd29ya3MuIA0KDQpSZWdhcmRz
LA0KSmlhbWVpIFhpZQ0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFhl
bi1kZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFs
ZiBPZg0KPiBPbGVrc2FuZHIgVHlzaGNoZW5rbw0KPiBTZW50OiAyMDIy5bm0NOaciDnml6UgMjoy
MQ0KPiBUbzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBKdWxpZW4gR3Jh
bGwgPEp1bGllbi5HcmFsbEBhcm0uY29tPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IEFudGhvbnkN
Cj4gUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPjsgSnVlcmdlbiBHcm9zcyA8amdy
b3NzQHN1c2UuY29tPjsNCj4gU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu
b3JnPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47DQo+IEJlcnRyYW5kIE1hcnF1aXMg
PEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlt
eXJfQmFiY2h1a0BlcGFtLmNvbT47IEppYW1laSBYaWUgPEppYW1laS5YaWVAYXJtLmNvbT47DQo+
IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT47IE9sZWtzYW5kciBUeXNoY2hlbmtvDQo+
IDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4gU3ViamVjdDogW1BBVENIIFY3IDIv
Ml0gbGlieGw6IEludHJvZHVjZSBiYXNpYyB2aXJ0aW8tbW1pbyBzdXBwb3J0IG9uIEFybQ0KPiAN
Cj4gRnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4NCj4gDQo+IFRoaXMg
cGF0Y2ggaW50cm9kdWNlcyBoZWxwZXJzIHRvIGFsbG9jYXRlIFZpcnRpbyBNTUlPIHBhcmFtcw0K
PiAoSVJRIGFuZCBtZW1vcnkgcmVnaW9uKSBhbmQgY3JlYXRlIHNwZWNpZmljIGRldmljZSBub2Rl
IGluDQo+IHRoZSBHdWVzdCBkZXZpY2UtdHJlZSB3aXRoIGFsbG9jYXRlZCBwYXJhbXMuIEluIG9y
ZGVyIHRvIGRlYWwNCj4gd2l0aCBtdWx0aXBsZSBWaXJ0aW8gZGV2aWNlcywgcmVzZXJ2ZSBjb3Jy
ZXNwb25kaW5nIHJhbmdlcy4NCj4gRm9yIG5vdywgd2UgcmVzZXJ2ZSAxTUIgZm9yIG1lbW9yeSBy
ZWdpb25zIGFuZCAxMCBTUElzLg0KPiANCj4gQXMgdGhlc2UgaGVscGVycyBzaG91bGQgYmUgdXNl
ZCBmb3IgZXZlcnkgVmlydGlvIGRldmljZSBhdHRhY2hlZA0KPiB0byB0aGUgR3Vlc3QsIGNhbGwg
dGhlbSBmb3IgVmlydGlvIGRpc2socykuDQo+IA0KPiBQbGVhc2Ugbm90ZSwgd2l0aCBzdGF0aWNh
bGx5IGFsbG9jYXRlZCBWaXJ0aW8gSVJRcyB0aGVyZSBpcw0KPiBhIHJpc2sgb2YgYSBjbGFzaCB3
aXRoIGEgcGh5c2ljYWwgSVJRcyBvZiBwYXNzdGhyb3VnaCBkZXZpY2VzLg0KPiBGb3IgdGhlIGZp
cnN0IHZlcnNpb24sIGl0J3MgZmluZSwgYnV0IHdlIHNob3VsZCBjb25zaWRlciBhbGxvY2F0aW5n
DQo+IHRoZSBWaXJ0aW8gSVJRcyBhdXRvbWF0aWNhbGx5LiBUaGFua2Z1bGx5LCB3ZSBrbm93IGlu
IGFkdmFuY2Ugd2hpY2gNCj4gSVJRcyB3aWxsIGJlIHVzZWQgZm9yIHBhc3N0aHJvdWdoIHRvIGJl
IGFibGUgdG8gY2hvb3NlIG5vbi1jbGFzaGVkDQo+IG9uZXMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5
OiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBP
bGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+IFRl
c3RlZC1ieTogSmlhbWVpIFhpZSA8SmlhbWVpLnhpZUBhcm0uY29tPg0KPiBSZXZpZXdlZC1ieTog
SGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KPiAtLS0NCj4gQEppYW1laSwgQEhlbnJ5
IEkgZGVjaWRlZCB0byBsZWF2ZSB5b3VyIFQtYiBhbmQgUi1iIHRhZ3Mgd2l0aCB0aGUgbWlub3IN
Cj4gY2hhbmdlIEkgbWFkZSwgYXJlIHlvdSBzdGlsbCBoYXBweSB3aXRoIHRoYXQ/DQo+IA0KPiBz
L2lmIChkaXNrLT52aXJ0aW8pL2lmIChkaXNrLT5wcm90b2NvbCA9PSBMSUJYTF9ESVNLX1BST1RP
Q09MX1ZJUlRJT19NTUlPKQ0KPiANCj4gUGxlYXNlIG5vdGUsIHRoaXMgaXMgYSBzcGxpdC9jbGVh
bnVwL2hhcmRlbmluZyBvZiBKdWxpZW4ncyBQb0M6DQo+ICJBZGQgc3VwcG9ydCBmb3IgR3Vlc3Qg
SU8gZm9yd2FyZGluZyB0byBhIGRldmljZSBlbXVsYXRvciINCj4gDQo+IENoYW5nZXMgUkZDIC0+
IFYxOg0KPiAgICAtIHdhcyBzcXVhc2hlZCB3aXRoOg0KPiAgICAgICJbUkZDIFBBVENIIFYxIDA5
LzEyXSBsaWJ4bDogSGFuZGxlIHZpcnRpby1tbWlvIGlycSBpbiBtb3JlIGNvcnJlY3Qgd2F5Ig0K
PiAgICAgICJbUkZDIFBBVENIIFYxIDExLzEyXSBsaWJ4bDogSW5zZXJ0ICJkbWEtY29oZXJlbnQi
IHByb3BlcnR5IGludG8gdmlydGlvLQ0KPiBtbWlvIGRldmljZSBub2RlIg0KPiAgICAgICJbUkZD
IFBBVENIIFYxIDEyLzEyXSBsaWJ4bDogRml4IGR1cGxpY2F0ZSBtZW1vcnkgbm9kZSBpbiBEVCIN
Cj4gICAgLSBtb3ZlIFZpcnRJTyBNTUlPICNkZWZpbmUtcyB0byB4ZW4vaW5jbHVkZS9wdWJsaWMv
YXJjaC1hcm0uaA0KPiANCj4gQ2hhbmdlcyBWMSAtPiBWMjoNCj4gICAgLSB1cGRhdGUgdGhlIGF1
dGhvciBvZiBhIHBhdGNoDQo+IA0KPiBDaGFuZ2VzIFYyIC0+IFYzOg0KPiAgICAtIG5vIGNoYW5n
ZXMNCj4gDQo+IENoYW5nZXMgVjMgLT4gVjQ6DQo+ICAgIC0gbm8gY2hhbmdlcw0KPiANCj4gQ2hh
bmdlcyBWNCAtPiBWNToNCj4gICAgLSBzcGxpdCB0aGUgY2hhbmdlcywgY2hhbmdlIHRoZSBvcmRl
ciBvZiB0aGUgcGF0Y2hlcw0KPiAgICAtIGRyb3AgYW4gZXh0cmEgInZpcnRpbyIgY29uZmlndXJh
dGlvbiBvcHRpb24NCj4gICAgLSB1cGRhdGUgcGF0Y2ggZGVzY3JpcHRpb24NCj4gICAgLSB1c2Ug
Q09OVEFJTkVSX09GIGluc3RlYWQgb2Ygb3duIGltcGxlbWVudGF0aW9uDQo+ICAgIC0gcmVzZXJ2
ZSByYW5nZXMgZm9yIFZpcnRpbyBNTUlPIHBhcmFtcyBhbmQgcHV0IHRoZW0NCj4gICAgICBpbiBj
b3JyZWN0IGxvY2F0aW9uDQo+ICAgIC0gY3JlYXRlIGhlbHBlcnMgdG8gYWxsb2NhdGUgVmlydGlv
IE1NSU8gcGFyYW1zLCBhZGQNCj4gICAgICBjb3JyZXNwb25kaW5nIHNhbml0eS3RgWhlY2tzDQo+
ICAgIC0gYWRkIGNvbW1lbnQgd2h5IE1NSU8gc2l6ZSAweDIwMCBpcyBjaG9zZW4NCj4gICAgLSB1
cGRhdGUgZGVidWcgcHJpbnQNCj4gICAgLSBkcm9wIFdlaSdzIFQtYg0KPiANCj4gQ2hhbmdlcyBW
NSAtPiBWNjoNCj4gICAgLSByZWJhc2Ugb24gY3VycmVudCBzdGFnaW5nDQo+IA0KPiBDaGFuZ2Vz
IFY2IC0+IFY3Og0KPiAgICAtIHJlYmFzZSBvbiBjdXJyZW50IHN0YWdpbmcNCj4gICAgLSBhZGQg
VC1iIGFuZCBSLWIgdGFncw0KPiAgICAtIHVwZGF0ZSBhY2NvcmRpbmcgdG8gdGhlIHJlY2VudCBj
aGFuZ2VzIHRvDQo+ICAgICAgImxpYnhsOiBBZGQgc3VwcG9ydCBmb3IgVmlydGlvIGRpc2sgY29u
ZmlndXJhdGlvbiINCj4gLS0tDQo+ICB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jICB8IDEz
MQ0KPiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0NCj4gIHhlbi9p
bmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oIHwgICA3ICsrKw0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAx
MzYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90b29s
cy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYw0K
PiBpbmRleCBlZWYxZGUwLi44MTMyYTQ3IDEwMDY0NA0KPiAtLS0gYS90b29scy9saWJzL2xpZ2h0
L2xpYnhsX2FybS5jDQo+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4gQEAg
LTgsNiArOCw1NiBAQA0KPiAgI2luY2x1ZGUgPGFzc2VydC5oPg0KPiAgI2luY2x1ZGUgPHhlbi9k
ZXZpY2VfdHJlZV9kZWZzLmg+DQo+IA0KPiArLyoNCj4gKyAqIFRoZXJlIGlzIG5vIGNsZWFyIHJl
cXVpcmVtZW50cyBmb3IgdGhlIHRvdGFsIHNpemUgb2YgVmlydGlvIE1NSU8gcmVnaW9uLg0KPiAr
ICogVGhlIHNpemUgb2YgY29udHJvbCByZWdpc3RlcnMgaXMgMHgxMDAgYW5kIGRldmljZS1zcGVj
aWZpYyBjb25maWd1cmF0aW9uDQo+ICsgKiByZWdpc3RlcnMgc3RhcnRzIGF0IHRoZSBvZmZzZXQg
MHgxMDAsIGhvd2V2ZXIgaXQncyBzaXplIGRlcGVuZHMgb24gdGhlDQo+IGRldmljZQ0KPiArICog
YW5kIHRoZSBkcml2ZXIuIFBpY2sgdGhlIGJpZ2dlc3Qga25vd24gc2l6ZSBhdCB0aGUgbW9tZW50
IHRvIGNvdmVyIG1vc3QNCj4gKyAqIG9mIHRoZSBkZXZpY2VzIChhbHNvIGNvbnNpZGVyIGFsbG93
aW5nIHRoZSB1c2VyIHRvIGNvbmZpZ3VyZSB0aGUgc2l6ZSB2aWENCj4gKyAqIGNvbmZpZyBmaWxl
IGZvciB0aGUgb25lIG5vdCBjb25mb3JtaW5nIHdpdGggdGhlIHByb3Bvc2VkIHZhbHVlKS4NCj4g
KyAqLw0KPiArI2RlZmluZSBWSVJUSU9fTU1JT19ERVZfU0laRSAgIHhlbl9ta191bGxvbmcoMHgy
MDApDQo+ICsNCj4gK3N0YXRpYyB1aW50NjRfdCB2aXJ0aW9fbW1pb19iYXNlOw0KPiArc3RhdGlj
IHVpbnQzMl90IHZpcnRpb19tbWlvX2lycTsNCj4gKw0KPiArc3RhdGljIHZvaWQgaW5pdF92aXJ0
aW9fbW1pb19wYXJhbXModm9pZCkNCj4gK3sNCj4gKyAgICB2aXJ0aW9fbW1pb19iYXNlID0gR1VF
U1RfVklSVElPX01NSU9fQkFTRTsNCj4gKyAgICB2aXJ0aW9fbW1pb19pcnEgPSBHVUVTVF9WSVJU
SU9fTU1JT19TUElfRklSU1Q7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyB1aW50NjRfdCBhbGxvY192
aXJ0aW9fbW1pb19iYXNlKGxpYnhsX19nYyAqZ2MpDQo+ICt7DQo+ICsgICAgdWludDY0X3QgYmFz
ZSA9IHZpcnRpb19tbWlvX2Jhc2U7DQo+ICsNCj4gKyAgICAvKiBNYWtlIHN1cmUgd2UgaGF2ZSBl
bm91Z2ggcmVzZXJ2ZWQgcmVzb3VyY2VzICovDQo+ICsgICAgaWYgKCh2aXJ0aW9fbW1pb19iYXNl
ICsgVklSVElPX01NSU9fREVWX1NJWkUgPg0KPiArICAgICAgICBHVUVTVF9WSVJUSU9fTU1JT19C
QVNFICsgR1VFU1RfVklSVElPX01NSU9fU0laRSkpIHsNCj4gKyAgICAgICAgTE9HKEVSUk9SLCAi
UmFuIG91dCBvZiByZXNlcnZlZCByYW5nZSBmb3IgVmlydGlvIE1NSU8gQkFTRQ0KPiAweCUiUFJJ
eDY0IlxuIiwNCj4gKyAgICAgICAgICAgIHZpcnRpb19tbWlvX2Jhc2UpOw0KPiArICAgICAgICBy
ZXR1cm4gMDsNCj4gKyAgICB9DQo+ICsgICAgdmlydGlvX21taW9fYmFzZSArPSBWSVJUSU9fTU1J
T19ERVZfU0laRTsNCj4gKw0KPiArICAgIHJldHVybiBiYXNlOw0KPiArfQ0KPiArDQo+ICtzdGF0
aWMgdWludDMyX3QgYWxsb2NfdmlydGlvX21taW9faXJxKGxpYnhsX19nYyAqZ2MpDQo+ICt7DQo+
ICsgICAgdWludDMyX3QgaXJxID0gdmlydGlvX21taW9faXJxOw0KPiArDQo+ICsgICAgLyogTWFr
ZSBzdXJlIHdlIGhhdmUgZW5vdWdoIHJlc2VydmVkIHJlc291cmNlcyAqLw0KPiArICAgIGlmICh2
aXJ0aW9fbW1pb19pcnEgPiBHVUVTVF9WSVJUSU9fTU1JT19TUElfTEFTVCkgew0KPiArICAgICAg
ICBMT0coRVJST1IsICJSYW4gb3V0IG9mIHJlc2VydmVkIHJhbmdlIGZvciBWaXJ0aW8gTU1JTyBJ
UlEgJXVcbiIsDQo+ICsgICAgICAgICAgICB2aXJ0aW9fbW1pb19pcnEpOw0KPiArICAgICAgICBy
ZXR1cm4gMDsNCj4gKyAgICB9DQo+ICsgICAgdmlydGlvX21taW9faXJxKys7DQo+ICsNCj4gKyAg
ICByZXR1cm4gaXJxOw0KPiArfQ0KPiArDQo+ICBzdGF0aWMgY29uc3QgY2hhciAqZ2ljdl90b19z
dHJpbmcobGlieGxfZ2ljX3ZlcnNpb24gZ2ljX3ZlcnNpb24pDQo+ICB7DQo+ICAgICAgc3dpdGNo
IChnaWNfdmVyc2lvbikgew0KPiBAQCAtMjYsOCArNzYsOCBAQCBpbnQgbGlieGxfX2FyY2hfZG9t
YWluX3ByZXBhcmVfY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+ICB7DQo+ICAgICAgdWludDMyX3Qg
bnJfc3BpcyA9IDA7DQo+ICAgICAgdW5zaWduZWQgaW50IGk7DQo+IC0gICAgdWludDMyX3QgdnVh
cnRfaXJxOw0KPiAtICAgIGJvb2wgdnVhcnRfZW5hYmxlZCA9IGZhbHNlOw0KPiArICAgIHVpbnQz
Ml90IHZ1YXJ0X2lycSwgdmlydGlvX2lycSA9IDA7DQo+ICsgICAgYm9vbCB2dWFydF9lbmFibGVk
ID0gZmFsc2UsIHZpcnRpb19lbmFibGVkID0gZmFsc2U7DQo+IA0KPiAgICAgIC8qDQo+ICAgICAg
ICogSWYgcGwwMTEgdnVhcnQgaXMgZW5hYmxlZCB0aGVuIGluY3JlbWVudCB0aGUgbnJfc3BpcyB0
byBhbGxvdyBhbGxvY2F0aW9uDQo+IEBAIC0zOSw2ICs4OSwzNSBAQCBpbnQgbGlieGxfX2FyY2hf
ZG9tYWluX3ByZXBhcmVfY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+ICAgICAgICAgIHZ1YXJ0X2Vu
YWJsZWQgPSB0cnVlOw0KPiAgICAgIH0NCj4gDQo+ICsgICAgLyoNCj4gKyAgICAgKiBWaXJ0aW8g
TU1JTyBwYXJhbXMgYXJlIG5vbi11bmlxdWUgYWNyb3NzIHRoZSB3aG9sZSBzeXN0ZW0gYW5kDQo+
IG11c3QgYmUNCj4gKyAgICAgKiBpbml0aWFsaXplZCBmb3IgZXZlcnkgbmV3IGd1ZXN0Lg0KPiAr
ICAgICAqLw0KPiArICAgIGluaXRfdmlydGlvX21taW9fcGFyYW1zKCk7DQo+ICsgICAgZm9yIChp
ID0gMDsgaSA8IGRfY29uZmlnLT5udW1fZGlza3M7IGkrKykgew0KPiArICAgICAgICBsaWJ4bF9k
ZXZpY2VfZGlzayAqZGlzayA9ICZkX2NvbmZpZy0+ZGlza3NbaV07DQo+ICsNCj4gKyAgICAgICAg
aWYgKGRpc2stPnByb3RvY29sID09IExJQlhMX0RJU0tfUFJPVE9DT0xfVklSVElPX01NSU8pIHsN
Cj4gKyAgICAgICAgICAgIGRpc2stPmJhc2UgPSBhbGxvY192aXJ0aW9fbW1pb19iYXNlKGdjKTsN
Cj4gKyAgICAgICAgICAgIGlmICghZGlzay0+YmFzZSkNCj4gKyAgICAgICAgICAgICAgICByZXR1
cm4gRVJST1JfRkFJTDsNCj4gKw0KPiArICAgICAgICAgICAgZGlzay0+aXJxID0gYWxsb2Nfdmly
dGlvX21taW9faXJxKGdjKTsNCj4gKyAgICAgICAgICAgIGlmICghZGlzay0+aXJxKQ0KPiArICAg
ICAgICAgICAgICAgIHJldHVybiBFUlJPUl9GQUlMOw0KPiArDQo+ICsgICAgICAgICAgICBpZiAo
dmlydGlvX2lycSA8IGRpc2stPmlycSkNCj4gKyAgICAgICAgICAgICAgICB2aXJ0aW9faXJxID0g
ZGlzay0+aXJxOw0KPiArICAgICAgICAgICAgdmlydGlvX2VuYWJsZWQgPSB0cnVlOw0KPiArDQo+
ICsgICAgICAgICAgICBMT0coREVCVUcsICJBbGxvY2F0ZSBWaXJ0aW8gTU1JTyBwYXJhbXMgZm9y
IFZkZXYgJXM6IElSUSAldQ0KPiBCQVNFIDB4JSJQUkl4NjQsDQo+ICsgICAgICAgICAgICAgICAg
ZGlzay0+dmRldiwgZGlzay0+aXJxLCBkaXNrLT5iYXNlKTsNCj4gKyAgICAgICAgfQ0KPiArICAg
IH0NCj4gKw0KPiArICAgIGlmICh2aXJ0aW9fZW5hYmxlZCkNCj4gKyAgICAgICAgbnJfc3BpcyAr
PSAodmlydGlvX2lycSAtIDMyKSArIDE7DQo+ICsNCj4gICAgICBmb3IgKGkgPSAwOyBpIDwgZF9j
b25maWctPmJfaW5mby5udW1faXJxczsgaSsrKSB7DQo+ICAgICAgICAgIHVpbnQzMl90IGlycSA9
IGRfY29uZmlnLT5iX2luZm8uaXJxc1tpXTsNCj4gICAgICAgICAgdWludDMyX3Qgc3BpOw0KPiBA
QCAtNTgsNiArMTM3LDEzIEBAIGludCBsaWJ4bF9fYXJjaF9kb21haW5fcHJlcGFyZV9jb25maWco
bGlieGxfX2djICpnYywNCj4gICAgICAgICAgICAgIHJldHVybiBFUlJPUl9GQUlMOw0KPiAgICAg
ICAgICB9DQo+IA0KPiArICAgICAgICAvKiBUaGUgc2FtZSBjaGVjayBhcyBmb3IgdnBsMDExICov
DQo+ICsgICAgICAgIGlmICh2aXJ0aW9fZW5hYmxlZCAmJg0KPiArICAgICAgICAgICAoaXJxID49
IEdVRVNUX1ZJUlRJT19NTUlPX1NQSV9GSVJTVCAmJiBpcnEgPD0gdmlydGlvX2lycSkpIHsNCj4g
KyAgICAgICAgICAgIExPRyhFUlJPUiwgIlBoeXNpY2FsIElSUSAldSBjb25mbGljdGluZyB3aXRo
IFZpcnRpbyBNTUlPIElSUQ0KPiByYW5nZVxuIiwgaXJxKTsNCj4gKyAgICAgICAgICAgIHJldHVy
biBFUlJPUl9GQUlMOw0KPiArICAgICAgICB9DQo+ICsNCj4gICAgICAgICAgaWYgKGlycSA8IDMy
KQ0KPiAgICAgICAgICAgICAgY29udGludWU7DQo+IA0KPiBAQCAtNzg3LDYgKzg3MywzOSBAQCBz
dGF0aWMgaW50IG1ha2VfdnBjaV9ub2RlKGxpYnhsX19nYyAqZ2MsIHZvaWQgKmZkdCwNCj4gICAg
ICByZXR1cm4gMDsNCj4gIH0NCj4gDQo+ICsNCj4gK3N0YXRpYyBpbnQgbWFrZV92aXJ0aW9fbW1p
b19ub2RlKGxpYnhsX19nYyAqZ2MsIHZvaWQgKmZkdCwNCj4gKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHVpbnQ2NF90IGJhc2UsIHVpbnQzMl90IGlycSkNCj4gK3sNCj4gKyAgICBp
bnQgcmVzOw0KPiArICAgIGdpY19pbnRlcnJ1cHQgaW50cjsNCj4gKyAgICAvKiBQbGFjZWhvbGRl
ciBmb3IgdmlydGlvQCArIGEgNjQtYml0IG51bWJlciArIFwwICovDQo+ICsgICAgY2hhciBidWZb
MjRdOw0KPiArDQo+ICsgICAgc25wcmludGYoYnVmLCBzaXplb2YoYnVmKSwgInZpcnRpb0AlIlBS
SXg2NCwgYmFzZSk7DQo+ICsgICAgcmVzID0gZmR0X2JlZ2luX25vZGUoZmR0LCBidWYpOw0KPiAr
ICAgIGlmIChyZXMpIHJldHVybiByZXM7DQo+ICsNCj4gKyAgICByZXMgPSBmZHRfcHJvcGVydHlf
Y29tcGF0KGdjLCBmZHQsIDEsICJ2aXJ0aW8sbW1pbyIpOw0KPiArICAgIGlmIChyZXMpIHJldHVy
biByZXM7DQo+ICsNCj4gKyAgICByZXMgPSBmZHRfcHJvcGVydHlfcmVncyhnYywgZmR0LCBHVUVT
VF9ST09UX0FERFJFU1NfQ0VMTFMsDQo+IEdVRVNUX1JPT1RfU0laRV9DRUxMUywNCj4gKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAxLCBiYXNlLCBWSVJUSU9fTU1JT19ERVZfU0laRSk7DQo+
ICsgICAgaWYgKHJlcykgcmV0dXJuIHJlczsNCj4gKw0KPiArICAgIHNldF9pbnRlcnJ1cHQoaW50
ciwgaXJxLCAweGYsIERUX0lSUV9UWVBFX0VER0VfUklTSU5HKTsNCj4gKyAgICByZXMgPSBmZHRf
cHJvcGVydHlfaW50ZXJydXB0cyhnYywgZmR0LCAmaW50ciwgMSk7DQo+ICsgICAgaWYgKHJlcykg
cmV0dXJuIHJlczsNCj4gKw0KPiArICAgIHJlcyA9IGZkdF9wcm9wZXJ0eShmZHQsICJkbWEtY29o
ZXJlbnQiLCBOVUxMLCAwKTsNCj4gKyAgICBpZiAocmVzKSByZXR1cm4gcmVzOw0KPiArDQo+ICsg
ICAgcmVzID0gZmR0X2VuZF9ub2RlKGZkdCk7DQo+ICsgICAgaWYgKHJlcykgcmV0dXJuIHJlczsN
Cj4gKw0KPiArICAgIHJldHVybiAwOw0KPiArfQ0KPiArDQo+ICBzdGF0aWMgY29uc3Qgc3RydWN0
IGFyY2hfaW5mbyAqZ2V0X2FyY2hfaW5mbyhsaWJ4bF9fZ2MgKmdjLA0KPiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHhjX2RvbV9pbWFn
ZSAqZG9tKQ0KPiAgew0KPiBAQCAtOTg4LDYgKzExMDcsNyBAQCBzdGF0aWMgaW50IGxpYnhsX19w
cmVwYXJlX2R0YihsaWJ4bF9fZ2MgKmdjLA0KPiBsaWJ4bF9kb21haW5fY29uZmlnICpkX2NvbmZp
ZywNCj4gICAgICBzaXplX3QgZmR0X3NpemUgPSAwOw0KPiAgICAgIGludCBwZmR0X3NpemUgPSAw
Ow0KPiAgICAgIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvICpjb25zdCBpbmZvID0gJmRfY29uZmln
LT5iX2luZm87DQo+ICsgICAgdW5zaWduZWQgaW50IGk7DQo+IA0KPiAgICAgIGNvbnN0IGxpYnhs
X3ZlcnNpb25faW5mbyAqdmVyczsNCj4gICAgICBjb25zdCBzdHJ1Y3QgYXJjaF9pbmZvICphaW5m
bzsNCj4gQEAgLTEwOTQsNiArMTIxNCwxMyBAQCBuZXh0X3Jlc2l6ZToNCj4gICAgICAgICAgaWYg
KGRfY29uZmlnLT5udW1fcGNpZGV2cykNCj4gICAgICAgICAgICAgIEZEVCggbWFrZV92cGNpX25v
ZGUoZ2MsIGZkdCwgYWluZm8sIGRvbSkgKTsNCj4gDQo+ICsgICAgICAgIGZvciAoaSA9IDA7IGkg
PCBkX2NvbmZpZy0+bnVtX2Rpc2tzOyBpKyspIHsNCj4gKyAgICAgICAgICAgIGxpYnhsX2Rldmlj
ZV9kaXNrICpkaXNrID0gJmRfY29uZmlnLT5kaXNrc1tpXTsNCj4gKw0KPiArICAgICAgICAgICAg
aWYgKGRpc2stPnByb3RvY29sID09IExJQlhMX0RJU0tfUFJPVE9DT0xfVklSVElPX01NSU8pDQo+
ICsgICAgICAgICAgICAgICAgRkRUKCBtYWtlX3ZpcnRpb19tbWlvX25vZGUoZ2MsIGZkdCwgZGlz
ay0+YmFzZSwgZGlzay0+aXJxKSApOw0KPiArICAgICAgICB9DQo+ICsNCj4gICAgICAgICAgaWYg
KHBmZHQpDQo+ICAgICAgICAgICAgICBGRFQoIGNvcHlfcGFydGlhbF9mZHQoZ2MsIGZkdCwgcGZk
dCkgKTsNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaCBi
L3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+IGluZGV4IGFiMDVmZTEuLmM4YjYwNTgg
MTAwNjQ0DQo+IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+ICsrKyBiL3hl
bi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+IEBAIC00MDcsNiArNDA3LDEwIEBAIHR5cGVk
ZWYgdWludDY0X3QgeGVuX2NhbGxiYWNrX3Q7DQo+IA0KPiAgLyogUGh5c2ljYWwgQWRkcmVzcyBT
cGFjZSAqLw0KPiANCj4gKy8qIFZpcnRpbyBNTUlPIG1hcHBpbmdzICovDQo+ICsjZGVmaW5lIEdV
RVNUX1ZJUlRJT19NTUlPX0JBU0UgICB4ZW5fbWtfdWxsb25nKDB4MDIwMDAwMDApDQo+ICsjZGVm
aW5lIEdVRVNUX1ZJUlRJT19NTUlPX1NJWkUgICB4ZW5fbWtfdWxsb25nKDB4MDAxMDAwMDApDQo+
ICsNCj4gIC8qDQo+ICAgKiB2R0lDIG1hcHBpbmdzOiBPbmx5IG9uZSBzZXQgb2YgbWFwcGluZyBp
cyB1c2VkIGJ5IHRoZSBndWVzdC4NCj4gICAqIFRoZXJlZm9yZSB0aGV5IGNhbiBvdmVybGFwLg0K
PiBAQCAtNDkzLDYgKzQ5Nyw5IEBAIHR5cGVkZWYgdWludDY0X3QgeGVuX2NhbGxiYWNrX3Q7DQo+
IA0KPiAgI2RlZmluZSBHVUVTVF9WUEwwMTFfU1BJICAgICAgICAzMg0KPiANCj4gKyNkZWZpbmUg
R1VFU1RfVklSVElPX01NSU9fU1BJX0ZJUlNUICAgMzMNCj4gKyNkZWZpbmUgR1VFU1RfVklSVElP
X01NSU9fU1BJX0xBU1QgICAgNDMNCj4gKw0KPiAgLyogUFNDSSBmdW5jdGlvbnMgKi8NCj4gICNk
ZWZpbmUgUFNDSV9jcHVfc3VzcGVuZCAwDQo+ICAjZGVmaW5lIFBTQ0lfY3B1X29mZiAgICAgMQ0K
PiAtLQ0KPiAyLjcuNA0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 03:10:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 03:10:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310634.527544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhjg1-0000CG-4F; Fri, 22 Apr 2022 03:09:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310634.527544; Fri, 22 Apr 2022 03:09:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhjg1-0000C9-10; Fri, 22 Apr 2022 03:09:45 +0000
Received: by outflank-mailman (input) for mailman id 310634;
 Fri, 22 Apr 2022 03:09:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhjfz-0000Bz-Uf; Fri, 22 Apr 2022 03:09:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhjfz-0007JQ-Qk; Fri, 22 Apr 2022 03:09:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhjfz-0000qz-8m; Fri, 22 Apr 2022 03:09:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhjfz-0001nE-8J; Fri, 22 Apr 2022 03:09:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VHmb18U0n7l/AGulaRbehMFHf+KXFHdlgqnpD2kMGg0=; b=rIt0z4bYx7uE6g/qXY8MsptkcH
	4SeaoyR7TEu08i9u2mL9+ZWuB9IU6qS6NLdaeDKjXMFEvtwgXXfAZV9xyLRjRq3wJk9qNhxgKCfIG
	b6UShTHrErrX1YG40AM/qgwLknmmvusq7c019DhOuG5oZ8Os+Td9dpjVPb8ugIWw9KeE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169601-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169601: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=59f0c2447e2553b0918b4a9fd38763a5c0587d02
X-Osstest-Versions-That:
    linux=b253435746d9a4a701b5f09211b9c14d3370d0da
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 03:09:43 +0000

flight 169601 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169601/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169572
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169572
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169572
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169572
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169572
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169572
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169572
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169572
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                59f0c2447e2553b0918b4a9fd38763a5c0587d02
baseline version:
 linux                b253435746d9a4a701b5f09211b9c14d3370d0da

Last test of basis   169572  2022-04-20 20:13:55 Z    1 days
Testing same since   169601  2022-04-21 21:40:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Arun Ramadoss <arun.ramadoss@microchip.com>
  Cong Wang <cong.wang@bytedance.com>
  Corinna Vinschen <vinschen@redhat.com>
  David Ahern <dsahern@kernel.org>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  Duoming Zhou <duoming@zju.edu.cn>
  Eelco Chaudron <echaudro@redhat.com>
  Eric Dumazet <edumazet@google.com>
  Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
  Hangbin Liu <liuhangbin@gmail.com>
  Horatiu Vultur <horatiu.vultur@microchip.com>
  Ido Schimmel <idosch@idosch.org>
  Ido Schimmel <idosch@nvidia.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamal Hadi Salim <jhs@mojatatu.com>
  James Hutchinson <jahutchinson99@googlemail.com>
  Jianglei Nie <niejianglei2021@163.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kevin Hao <haokexin@gmail.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kurt Kanzenbach <kurt@linutronix.de>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Magnus Karlsson <magnus.karlsson@intel.com>
  Manuel Ullmann <labre@posteo.de>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Michal Swiatkowski <michal.swiatkowski@intel.com>
  Naama Meir <naamax.meir@linux.intel.com>
  Nicolas Dichtel <nicolas.dichtel@6wind.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Paolo Abeni <pabeni@redhat.com>
  Paolo Valerio <pvalerio@redhat.com>
  Paul Menzel <pmenzel@molgen.mpg.de>
  Peilin Ye <peilin.ye@bytedance.com>
  Sabrina Dubroca <sd@queasysnail.net>
  Sandeep Penigalapati <sandeep.penigalapati@intel.com>
  Sasha Neftin <sasha.neftin@intel.com>
  Shwetha Nagaraju <Shwetha.nagaraju@intel.com>
  Steffen Klassert <steffen.klassert@secunet.com>
  Stephen Hemminger <stephen@networkplumber.org>
  Sukadev Bhattiprolu <sukadev@linux.ibm.com>
  suresh kumar <suresh2514@gmail.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vinicius Costa Gomes <vinicius.gomes@intel.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wojciech Drewek <wojciech.drewek@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b253435746d9..59f0c2447e25  59f0c2447e2553b0918b4a9fd38763a5c0587d02 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 03:31:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 03:31:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310643.527555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhk11-00042u-Qm; Fri, 22 Apr 2022 03:31:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310643.527555; Fri, 22 Apr 2022 03:31:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhk11-00042n-Np; Fri, 22 Apr 2022 03:31:27 +0000
Received: by outflank-mailman (input) for mailman id 310643;
 Fri, 22 Apr 2022 03:31:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhk10-00042d-VL; Fri, 22 Apr 2022 03:31:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhk10-0007eo-Sq; Fri, 22 Apr 2022 03:31:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhk10-0001yR-B3; Fri, 22 Apr 2022 03:31:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhk10-0000KO-AZ; Fri, 22 Apr 2022 03:31:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yZs8TNiAPZN392y2h7aPtv9D8YPKbWELuD4DYnFZpFg=; b=BbIyHkGgxXmhfA6yqfnFmQ1wNE
	BMH7+bolYVrIrZx4lWCowVE25IwLubGXYIEHO4dxeM76804q3026fBxAt8rgyYbblkXRDdv6C5IcY
	cNxwrbBprVncT1xaIRVNkl1cVajI68juAQSaeSrccSgZCBLtXIdJMuYBon0u6VGYhcTk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169605-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169605: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=43f3d51139178a03823b061482c674e15ce3d49c
X-Osstest-Versions-That:
    xen=fdef107edd4459375f9c0e6e377f30e82d498747
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 03:31:26 +0000

flight 169605 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169605/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  43f3d51139178a03823b061482c674e15ce3d49c
baseline version:
 xen                  fdef107edd4459375f9c0e6e377f30e82d498747

Last test of basis   169570  2022-04-20 19:03:00 Z    1 days
Testing same since   169605  2022-04-22 00:00:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   fdef107edd..43f3d51139  43f3d51139178a03823b061482c674e15ce3d49c -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 04:00:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 04:00:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310651.527565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhkTE-0008Ot-14; Fri, 22 Apr 2022 04:00:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310651.527565; Fri, 22 Apr 2022 04:00:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhkTD-0008Om-UM; Fri, 22 Apr 2022 04:00:35 +0000
Received: by outflank-mailman (input) for mailman id 310651;
 Fri, 22 Apr 2022 04:00:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhkTD-0008Oc-A5; Fri, 22 Apr 2022 04:00:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhkTD-0008EW-6u; Fri, 22 Apr 2022 04:00:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhkTC-00030v-SU; Fri, 22 Apr 2022 04:00:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhkTC-00037L-S1; Fri, 22 Apr 2022 04:00:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZYcDXJBtRkKi4gkaSHHlskM6qIU02br4KkrAH0ERgic=; b=mqKwPw0+zJP7aziliC9ZMreDuK
	xMoxXl6rnQQgY/Tbdf7HubPlN3UpiRnF6PqgeF/7P6VbI6/NtmNjYClb7Y6v8iUwaqSQMwHg2W/DD
	YphMlSH/5aqZ747FdSJijjnDwP/+O0BgmwJNj0UkRcUn2cglRQhbD11PzVYWIZwQa5t8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169607-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169607: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=b06a007b6471b6eba6d1c38ff1bcfff183b57488
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 04:00:34 +0000

flight 169607 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169607/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 b06a007b6471b6eba6d1c38ff1bcfff183b57488
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  548 attempts
Testing same since   169582  2022-04-21 05:41:38 Z    0 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5572 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 04:39:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 04:39:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310660.527577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhl4n-0004oF-8P; Fri, 22 Apr 2022 04:39:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310660.527577; Fri, 22 Apr 2022 04:39:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhl4n-0004o8-5U; Fri, 22 Apr 2022 04:39:25 +0000
Received: by outflank-mailman (input) for mailman id 310660;
 Fri, 22 Apr 2022 04:39:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhl4m-0004ny-1L; Fri, 22 Apr 2022 04:39:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhl4l-0000YD-UH; Fri, 22 Apr 2022 04:39:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhl4l-0005wv-Ea; Fri, 22 Apr 2022 04:39:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhl4l-0004gC-E5; Fri, 22 Apr 2022 04:39:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6PAx2+sMgiVGJbo98kxDb8g8SIKJzUrTZ3Fa4GsC7sE=; b=pnr+enYiUKSZSjJ9r55i+2WAv+
	+iaNlh43QwNpDYIK5d/sLlU74q439x+HySp24Kax3NKQJSztsL4wBIViTF1XWdxSSm1BvjT8bbI16
	q58KMlyhVffhKjMtDgkEwnYEJtkYIor8LqejgrTlguSH1E2xLJw9qZ+kgun6PqMgYxmI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169610-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169610: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=2306555bf9081ae9979405f96428738807e580d4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 04:39:23 +0000

flight 169610 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169610/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 2306555bf9081ae9979405f96428738807e580d4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  549 attempts
Testing same since   169610  2022-04-22 04:01:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5625 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 05:04:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 05:04:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310679.527588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhlSm-00018M-8y; Fri, 22 Apr 2022 05:04:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310679.527588; Fri, 22 Apr 2022 05:04:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhlSm-00018B-5B; Fri, 22 Apr 2022 05:04:12 +0000
Received: by outflank-mailman (input) for mailman id 310679;
 Fri, 22 Apr 2022 05:04:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=uSuW=VA=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1nhlSk-000185-4i
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 05:04:10 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a3e31141-c1f9-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 07:04:08 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id ECC2D68B05; Fri, 22 Apr 2022 07:04:05 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3e31141-c1f9-11ec-8fc2-03012f2f19d4
Date: Fri, 22 Apr 2022 07:04:05 +0200
From: Christoph Hellwig <hch@lst.de>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Rahul Singh <Rahul.Singh@arm.com>, Christoph Hellwig <hch@lst.de>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>,
	"jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Message-ID: <20220422050405.GA10195@lst.de>
References: <20220415063705.GA24262@lst.de> <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop> <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com> <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop> <49E3535A-5672-4047-AF86-05D5597C7019@arm.com> <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop> <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com> <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop> <12279FAE-2141-469E-A424-9984348E84BB@arm.com> <alpine.DEB.2.22.394.2204211444190.915916@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2204211444190.915916@ubuntu-linux-20-04-desktop>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Apr 21, 2022 at 03:01:32PM -0700, Stefano Stabellini wrote:
> swiotlb-xen: handle DMA_ATTR_NO_KERNEL_MAPPING
> 
> If DMA_ATTR_NO_KERNEL_MAPPING is set then the returned vaddr is a struct
> *page instead of the virtual mapping of the buffer.
> 
> In xen_swiotlb_alloc_coherent, do not call virt_to_page, instead use the
> returned pointer directly. Also do not memset the buffer or struct page
> to zero.
> 
> In xen_swiotlb_free_coherent, check DMA_ATTR_NO_KERNEL_MAPPING and set
> the page pointer appropriately.

Something like that should work, but it makes swiotlb-xen poke even
more into the opaque dma-direct internals.  I'd rather do something
like the patch below that uses the dma_direct allocator directly for
arm, and simplifies the xen-swiotlb allocator now that it just needs
to cater to the x86 case:

diff --git a/arch/arm/include/asm/xen/page-coherent.h b/arch/arm/include/asm/xen/page-coherent.h
deleted file mode 100644
index 27e984977402b..0000000000000
--- a/arch/arm/include/asm/xen/page-coherent.h
+++ /dev/null
@@ -1,2 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#include <xen/arm/page-coherent.h>
diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
index a7e54a087b802..6e603e5fdebb1 100644
--- a/arch/arm/xen/mm.c
+++ b/arch/arm/xen/mm.c
@@ -118,23 +118,6 @@ bool xen_arch_need_swiotlb(struct device *dev,
 		!dev_is_dma_coherent(dev));
 }
 
-int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
-				 unsigned int address_bits,
-				 dma_addr_t *dma_handle)
-{
-	if (!xen_initial_domain())
-		return -EINVAL;
-
-	/* we assume that dom0 is mapped 1:1 for now */
-	*dma_handle = pstart;
-	return 0;
-}
-
-void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order)
-{
-	return;
-}
-
 static int __init xen_mm_init(void)
 {
 	struct gnttab_cache_flush cflush;
diff --git a/arch/arm64/include/asm/xen/page-coherent.h b/arch/arm64/include/asm/xen/page-coherent.h
deleted file mode 100644
index 27e984977402b..0000000000000
--- a/arch/arm64/include/asm/xen/page-coherent.h
+++ /dev/null
@@ -1,2 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#include <xen/arm/page-coherent.h>
diff --git a/arch/x86/include/asm/xen/page-coherent.h b/arch/x86/include/asm/xen/page-coherent.h
deleted file mode 100644
index 63cd41b2e17ac..0000000000000
--- a/arch/x86/include/asm/xen/page-coherent.h
+++ /dev/null
@@ -1,24 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_X86_XEN_PAGE_COHERENT_H
-#define _ASM_X86_XEN_PAGE_COHERENT_H
-
-#include <asm/page.h>
-#include <linux/dma-mapping.h>
-
-static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t size,
-		dma_addr_t *dma_handle, gfp_t flags,
-		unsigned long attrs)
-{
-	void *vstart = (void*)__get_free_pages(flags, get_order(size));
-	*dma_handle = virt_to_phys(vstart);
-	return vstart;
-}
-
-static inline void xen_free_coherent_pages(struct device *hwdev, size_t size,
-		void *cpu_addr, dma_addr_t dma_handle,
-		unsigned long attrs)
-{
-	free_pages((unsigned long) cpu_addr, get_order(size));
-}
-
-#endif /* _ASM_X86_XEN_PAGE_COHERENT_H */
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 47aebd98f52f5..557edb9c54879 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -36,7 +36,6 @@
 #include <xen/hvc-console.h>
 
 #include <asm/dma-mapping.h>
-#include <asm/xen/page-coherent.h>
 
 #include <trace/events/swiotlb.h>
 #define MAX_DMA_BITS 32
@@ -104,6 +103,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr)
 	return 0;
 }
 
+#ifdef CONFIG_X86
 static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 {
 	int rc;
@@ -129,6 +129,12 @@ static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 	} while (i < nslabs);
 	return 0;
 }
+#else
+static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
+{
+	return 0;
+}
+#endif
 
 enum xen_swiotlb_err {
 	XEN_SWIOTLB_UNKNOWN = 0,
@@ -256,97 +262,60 @@ void __init xen_swiotlb_init_early(void)
 		panic("Cannot allocate SWIOTLB buffer");
 	swiotlb_set_max_segment(PAGE_SIZE);
 }
-#endif /* CONFIG_X86 */
 
 static void *
-xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
-			   dma_addr_t *dma_handle, gfp_t flags,
-			   unsigned long attrs)
+xen_swiotlb_alloc_coherent(struct device *dev, size_t size,
+		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
 {
-	void *ret;
+	u64 dma_mask = dev->coherent_dma_mask;
 	int order = get_order(size);
-	u64 dma_mask = DMA_BIT_MASK(32);
 	phys_addr_t phys;
-	dma_addr_t dev_addr;
-
-	/*
-	* Ignore region specifiers - the kernel's ideas of
-	* pseudo-phys memory layout has nothing to do with the
-	* machine physical layout.  We can't allocate highmem
-	* because we can't return a pointer to it.
-	*/
-	flags &= ~(__GFP_DMA | __GFP_HIGHMEM);
+	void *ret;
 
-	/* Convert the size to actually allocated. */
+	/* Align the allocation to the Xen page size */
 	size = 1UL << (order + XEN_PAGE_SHIFT);
 
-	/* On ARM this function returns an ioremap'ped virtual address for
-	 * which virt_to_phys doesn't return the corresponding physical
-	 * address. In fact on ARM virt_to_phys only works for kernel direct
-	 * mapped RAM memory. Also see comment below.
-	 */
-	ret = xen_alloc_coherent_pages(hwdev, size, dma_handle, flags, attrs);
-
+	ret = (void *)__get_free_pages(flags, get_order(size));
 	if (!ret)
 		return ret;
-
-	if (hwdev && hwdev->coherent_dma_mask)
-		dma_mask = hwdev->coherent_dma_mask;
-
-	/* At this point dma_handle is the dma address, next we are
-	 * going to set it to the machine address.
-	 * Do not use virt_to_phys(ret) because on ARM it doesn't correspond
-	 * to *dma_handle. */
-	phys = dma_to_phys(hwdev, *dma_handle);
-	dev_addr = xen_phys_to_dma(hwdev, phys);
-	if (((dev_addr + size - 1 <= dma_mask)) &&
-	    !range_straddles_page_boundary(phys, size))
-		*dma_handle = dev_addr;
-	else {
-		if (xen_create_contiguous_region(phys, order,
-						 fls64(dma_mask), dma_handle) != 0) {
-			xen_free_coherent_pages(hwdev, size, ret, (dma_addr_t)phys, attrs);
-			return NULL;
-		}
-		*dma_handle = phys_to_dma(hwdev, *dma_handle);
+	phys = virt_to_phys(ret);
+
+	*dma_handle = xen_phys_to_dma(dev, phys);
+	if (*dma_handle + size - 1 > dma_mask ||
+	    range_straddles_page_boundary(phys, size)) {
+		if (xen_create_contiguous_region(phys, order, fls64(dma_mask),
+				dma_handle) != 0)
+			goto out_free_pages;
 		SetPageXenRemapped(virt_to_page(ret));
 	}
+
 	memset(ret, 0, size);
 	return ret;
+
+out_free_pages:
+	free_pages((unsigned long)ret, get_order(size));
+	return NULL;
 }
 
 static void
-xen_swiotlb_free_coherent(struct device *hwdev, size_t size, void *vaddr,
-			  dma_addr_t dev_addr, unsigned long attrs)
+xen_swiotlb_free_coherent(struct device *dev, size_t size, void *vaddr,
+		dma_addr_t dma_handle, unsigned long attrs)
 {
+	phys_addr_t phys = virt_to_phys(vaddr);
 	int order = get_order(size);
-	phys_addr_t phys;
-	u64 dma_mask = DMA_BIT_MASK(32);
-	struct page *page;
-
-	if (hwdev && hwdev->coherent_dma_mask)
-		dma_mask = hwdev->coherent_dma_mask;
-
-	/* do not use virt_to_phys because on ARM it doesn't return you the
-	 * physical address */
-	phys = xen_dma_to_phys(hwdev, dev_addr);
 
 	/* Convert the size to actually allocated. */
 	size = 1UL << (order + XEN_PAGE_SHIFT);
 
-	if (is_vmalloc_addr(vaddr))
-		page = vmalloc_to_page(vaddr);
-	else
-		page = virt_to_page(vaddr);
+	if (WARN_ON_ONCE(dma_handle + size - 1 > dev->coherent_dma_mask) ||
+	    WARN_ON_ONCE(range_straddles_page_boundary(phys, size)))
+	    	return;
 
-	if (!WARN_ON((dev_addr + size - 1 > dma_mask) ||
-		     range_straddles_page_boundary(phys, size)) &&
-	    TestClearPageXenRemapped(page))
+	if (TestClearPageXenRemapped(virt_to_page(vaddr)))
 		xen_destroy_contiguous_region(phys, order);
-
-	xen_free_coherent_pages(hwdev, size, vaddr, phys_to_dma(hwdev, phys),
-				attrs);
+	free_pages((unsigned long)vaddr, get_order(size));
 }
+#endif /* CONFIG_X86 */
 
 /*
  * Map a single buffer of the indicated size for DMA in streaming mode.  The
@@ -549,8 +518,13 @@ xen_swiotlb_dma_supported(struct device *hwdev, u64 mask)
 }
 
 const struct dma_map_ops xen_swiotlb_dma_ops = {
+#ifdef CONFIG_X86
 	.alloc = xen_swiotlb_alloc_coherent,
 	.free = xen_swiotlb_free_coherent,
+#else
+	.alloc = dma_direct_alloc,
+	.free = dma_direct_free,
+#endif
 	.sync_single_for_cpu = xen_swiotlb_sync_single_for_cpu,
 	.sync_single_for_device = xen_swiotlb_sync_single_for_device,
 	.sync_sg_for_cpu = xen_swiotlb_sync_sg_for_cpu,
diff --git a/include/xen/arm/page-coherent.h b/include/xen/arm/page-coherent.h
deleted file mode 100644
index b9cc11e887ed5..0000000000000
--- a/include/xen/arm/page-coherent.h
+++ /dev/null
@@ -1,20 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _XEN_ARM_PAGE_COHERENT_H
-#define _XEN_ARM_PAGE_COHERENT_H
-
-#include <linux/dma-mapping.h>
-#include <asm/page.h>
-
-static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t size,
-		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
-{
-	return dma_direct_alloc(hwdev, size, dma_handle, flags, attrs);
-}
-
-static inline void xen_free_coherent_pages(struct device *hwdev, size_t size,
-		void *cpu_addr, dma_addr_t dma_handle, unsigned long attrs)
-{
-	dma_direct_free(hwdev, size, cpu_addr, dma_handle, attrs);
-}
-
-#endif /* _XEN_ARM_PAGE_COHERENT_H */


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 05:18:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 05:18:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310690.527599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhlgq-00030c-Ge; Fri, 22 Apr 2022 05:18:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310690.527599; Fri, 22 Apr 2022 05:18:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhlgq-00030V-Dl; Fri, 22 Apr 2022 05:18:44 +0000
Received: by outflank-mailman (input) for mailman id 310690;
 Fri, 22 Apr 2022 05:18:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aXhv=VA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhlgp-00030P-8n
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 05:18:43 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac61a42f-c1fb-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 07:18:41 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 11ABF1F37B;
 Fri, 22 Apr 2022 05:18:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C68A0132C4;
 Fri, 22 Apr 2022 05:18:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 9xyyLrA6YmIXOwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Apr 2022 05:18:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac61a42f-c1fb-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650604721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZSrkzKBvc5Gvurv3rbFxvcWCn6SuSOy5xDh9v4amNSM=;
	b=tOeDTTF45rjrpZWk8N68RH8Le+AJJGYgxepPzAZT8PCFqFJ0oYI404GsVsqT53o+1WfRjj
	9RU6utMsxt+7uM8CUP7hHdcwcLQxqH1uTpD7/cofmisIb8E+PA5nCHhJm/bZyw3PVzBOCk
	eJuxHZXJQ7RhD02vC4f0X0zzuRBl3qg=
Message-ID: <73b169f0-3bca-15b3-c5aa-074023941997@suse.com>
Date: Fri, 22 Apr 2022 07:18:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] scripts/add_maintainers.pl: add -o as an alternative to
 --patchdir
Content-Language: en-US
To: Elliott Mitchell <ehem+xen@m5p.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <dc05a59dc0e186f9dcec8d0e877ee80af168b6a8.1650551981.git.ehem+xen@m5p.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <dc05a59dc0e186f9dcec8d0e877ee80af168b6a8.1650551981.git.ehem+xen@m5p.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------kirzQ8Z99LpVjNbboeBpDNja"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------kirzQ8Z99LpVjNbboeBpDNja
Content-Type: multipart/mixed; boundary="------------iIL46v3C0y8YutUGhspzl0uW";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Elliott Mitchell <ehem+xen@m5p.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Message-ID: <73b169f0-3bca-15b3-c5aa-074023941997@suse.com>
Subject: Re: [PATCH] scripts/add_maintainers.pl: add -o as an alternative to
 --patchdir
References: <dc05a59dc0e186f9dcec8d0e877ee80af168b6a8.1650551981.git.ehem+xen@m5p.com>
In-Reply-To: <dc05a59dc0e186f9dcec8d0e877ee80af168b6a8.1650551981.git.ehem+xen@m5p.com>

--------------iIL46v3C0y8YutUGhspzl0uW
Content-Type: multipart/mixed; boundary="------------VHzSQYduNbE0phEA6ZowwcI0"

--------------VHzSQYduNbE0phEA6ZowwcI0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMDQuMjIgMTY6MzUsIEVsbGlvdHQgTWl0Y2hlbGwgd3JvdGU6DQo+IFRoaXMgbWF0
Y2hlcyB0aGUgb3V0cHV0IGRpcmVjdG9yeSBvcHRpb24gdXNlZCBieSBgZ2l0IGZvcm1hdC1w
YXRjaGAuICBJDQo+IHN1c3BlY3QgSSdtIG5vdCB0aGUgb25seSBvbmUgd2hvIGZpbmRzIG1h
dGNoaW5nIGBnaXQgZm9ybWF0LXBhdGNoYCBtb3JlDQo+IGludHVpdGl2ZSwgdGhhbiAtZCBm
b3IgZGlyZWN0b3J5Lg0KDQpUaGFuayB5b3UgZm9yIGRvaW5nIHRoYXQhDQoNCj4gU2lnbmVk
LW9mZi1ieTogRWxsaW90dCBNaXRjaGVsbCA8ZWhlbSt4ZW5AbTVwLmNvbT4NCg0KUmV2aWV3
ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo=

--------------VHzSQYduNbE0phEA6ZowwcI0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------VHzSQYduNbE0phEA6ZowwcI0--

--------------iIL46v3C0y8YutUGhspzl0uW--

--------------kirzQ8Z99LpVjNbboeBpDNja
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJiOrAFAwAAAAAACgkQsN6d1ii/Ey+b
pgf/SCW9O6fmL5D/QIuE+7qwdL8nF81K3nLCQSRxdnseHCrQnmMh62RebLzSo9akXJmb1KN0FS5L
hcF+sLikj8OFQyAJEVYp09KUkoAAD2+7qoFcE2nWsTA+Jo0h3BAR8C9APpVmPbyxfmS8jnp7CJYd
F0xs3u1u/51UdPWdiV0zQl+ibEanqBjuUKyvxottE1FkpLt5QHslOCn+xY1IVIgpBLIR1H2LeSou
LzPmfJiAiOiM3UWrq9SzvFuwZ9uDqnCzkWbfxct9sW/vp+YZq5X1aXC0Cp349h86aPI/tr7WqNod
y4CjO5skQIbvHiMdt8/mU9Gr+8CnCjpJKU/Gz3JUWQ==
=TG4v
-----END PGP SIGNATURE-----

--------------kirzQ8Z99LpVjNbboeBpDNja--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 06:09:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 06:09:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310695.527609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhmU0-0001Uy-6J; Fri, 22 Apr 2022 06:09:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310695.527609; Fri, 22 Apr 2022 06:09:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhmU0-0001Ur-3F; Fri, 22 Apr 2022 06:09:32 +0000
Received: by outflank-mailman (input) for mailman id 310695;
 Fri, 22 Apr 2022 06:09:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ZwqJ=VA=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nhmTy-0001Ul-N9
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 06:09:31 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20621.outbound.protection.outlook.com
 [2a01:111:f400:7d00::621])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c35e3782-c202-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 08:09:26 +0200 (CEST)
Received: from DB8PR06CA0052.eurprd06.prod.outlook.com (2603:10a6:10:120::26)
 by DU0PR08MB7787.eurprd08.prod.outlook.com (2603:10a6:10:3b8::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Fri, 22 Apr
 2022 06:09:23 +0000
Received: from DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:120:cafe::d7) by DB8PR06CA0052.outlook.office365.com
 (2603:10a6:10:120::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Fri, 22 Apr 2022 06:09:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT025.mail.protection.outlook.com (10.152.20.104) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Fri, 22 Apr 2022 06:09:23 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Fri, 22 Apr 2022 06:09:23 +0000
Received: from cd95b13914ef.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7B2F4CB4-8EA6-4887-ABC5-7EA95DBB1F78.1; 
 Fri, 22 Apr 2022 06:09:16 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd95b13914ef.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 22 Apr 2022 06:09:16 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by DB6PR0802MB2551.eurprd08.prod.outlook.com (2603:10a6:4:9f::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr
 2022 06:09:15 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Fri, 22 Apr 2022
 06:09:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c35e3782-c202-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gu8TCVTwwBYGYf7B9H9RVveLQMMJB0IZehu9UilohK0=;
 b=1GWo32YHQ4J+ZaYZ/OzS31qZnhtMrq4npSGgZ6ilhvVgsE+EhxAZ29tQ38mKIZa16nzVoaWk9BmIL6ahGhM9/FeSw9eFZtMjt3KMqnwvycwcDxCZoqnUEN5nWpSta5SAcOFBtsQIAwnYx0HGoZ8arJKyyi4LwcE0JC2IFt6UrnA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 668e0e87570d323a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cSZBl703RrcrfmuzgOSk1VYuWINjjWxEp0bk59yzB7npsmO4JPenpBE7do5GsIR/vrQtephJ4aE3t2jHKG0GPZ5YdCEdc/PPq0PwWcsO3Heo/O+eXk5zMJdKzJCcQe6SQ9qyzudmcDtl9OxLJobH3J9ue4s5Sc6ieWK8a9N4vEDs8JkA6NeUY4K6OoZgoBH+Fy2PYZK3R0aeKe3eq94qCPZepdiJd2ulfPIRmmEbdOnyfel3lPnk+pNhKq80ndEkoQJDpUvyT1TGYZGvE9aqxQlSHgqWPvmWoCkEgsYnW0oihbnSP78KGvlm+YUnlkq7bwIQxNJSwI9N5sfVby6b8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gu8TCVTwwBYGYf7B9H9RVveLQMMJB0IZehu9UilohK0=;
 b=Nmx9Ka8UJIFbDa0AKg5FYQRZbUlwA/L7649KeC/kQIEA0IR1VgLAu7yFzzqfLiaVAJ+Iy1nN7JBHfGOb/DdCS2ProbGKACz4zh6cLNsQm2jFO/iHGlbNkNJ4oBhuTo63Mo0eGCKfuUGi1MQ79KLvvcpL4fdYS3hItdl4aNR3hbrjRbbpR6KnhtVNtSXacASRmdQsHZu10FEgVWM/RVsY53W3FD8L6434ENlvXudfzvYQh2HRdCcOlPYDW6C4hk8tX/EESw0rgJJH8i4EnHe4e2aHq2YUNpHD04No6LnHlWs+BjTD1vvx5Acl0w3OL3l/I5MpLBXRmQ9dSRvVwSTmdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gu8TCVTwwBYGYf7B9H9RVveLQMMJB0IZehu9UilohK0=;
 b=1GWo32YHQ4J+ZaYZ/OzS31qZnhtMrq4npSGgZ6ilhvVgsE+EhxAZ29tQ38mKIZa16nzVoaWk9BmIL6ahGhM9/FeSw9eFZtMjt3KMqnwvycwcDxCZoqnUEN5nWpSta5SAcOFBtsQIAwnYx0HGoZ8arJKyyi4LwcE0JC2IFt6UrnA=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <6cd916fc-4a10-0a1e-afa6-9e4e6f0ea999@arm.com>
Date: Fri, 22 Apr 2022 14:09:05 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftB
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Penny Zheng <Penny.Zheng@arm.com>
References: <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop>
 <PAXPR08MB7420786607A15FA5027BF4579EF29@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204191752390.915916@ubuntu-linux-20-04-desktop>
 <PAXPR08MB742058D3041BA2D97AA05F1D9EF59@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204201403180.915916@ubuntu-linux-20-04-desktop>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <alpine.DEB.2.22.394.2204201403180.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SI2PR01CA0048.apcprd01.prod.exchangelabs.com
 (2603:1096:4:193::17) To PAXPR08MB7420.eurprd08.prod.outlook.com
 (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 8567e62e-0714-40eb-dde6-08da2426a5a8
X-MS-TrafficTypeDiagnostic:
	DB6PR0802MB2551:EE_|DB5EUR03FT025:EE_|DU0PR08MB7787:EE_
X-Microsoft-Antispam-PRVS:
	<DU0PR08MB7787AE136378169C8FE26BBA9EF79@DU0PR08MB7787.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6rQHwwJIWC3WMHyUDkVyp4x23kYDwYmLe5Uu1M7zhSFDjmJPMxtHFpKq19vTLN2WaAMm2JEDzA2NtAvL1ZlJ/NOUbr70jMptewIgRZVm9em+SUk+PYRBYnUP7RwlwdEj1BD6Uf94XOYEBeQ24NGmXXRkFhLJMhMj+2QBs3ZHaHCqbhRVy4KNga0AaufrHphhjEVCQ3hIdEYIpMRliYweQhB5s2eRToBOLctzv1KN6nlYWrTLAcpxprOi7zo47foydcKqnkbDsLAaoM+JzzzZS9XOhBjw+M7xorGuNhDyLSMN+3XC+PbEFevcoNoMhUkKoNg7aFIeaKRvebzVzLEdHg9k3F0RJ6+Egnclzzd6mJ4G5T4xAdyVk0Kv5PKG7W0C2Pe0DYOxqQ5F+O+bDzcD4EEx6ipkbzl+lzlZOau+DWsLBAPBTFVzaCxUjKND9dXw82Oux9G6VQkMhrqREN4k9a0fQchD9pFCnJ0i++cCVicljNOA21fdboVAA6Ldvbx6NVrn4Kr7Nlr0Dv0z2PE09VW3n9+MvXUX/OFUph8auGB+luHp7RuniNKGylIaW3vAkuNZN2Ydme0vrQNCi1LPj8inW5g+sDP3BYtL2oqZku8G2UPrLv2i2Zh3s1CimRksSiCKBErHUPeGSha74JTEYJEsbS6ixsc+HlSmJt7VVt3VPqIb1Foedy85GWqsX19LQ+w/EoLKEJ1aMlG8y+ijHolz0z0MhLcwKX1r8Ak+4CI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(2906002)(6486002)(31696002)(66556008)(30864003)(86362001)(6506007)(8676002)(38100700002)(6916009)(83380400001)(316002)(6512007)(54906003)(66476007)(31686004)(6666004)(66946007)(4326008)(53546011)(5660300002)(186003)(26005)(508600001)(2616005)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2551
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8b5ed803-963c-47bf-c946-08da2426a091
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kSedImfGllEytYakeusATPWqwecKz0JERNcVdCdwsgCOBvgBM2k1jyW1JcQ7OCoszKhzoWpHCjAT+RIyn6t+WYHMgZwMXsdk87nH0f2ti/aXw34F1uOfG18hqioT4KNT4+r17xNso+8EXGkOLC8THARLYTW41SlusDGhOL4F8AlginqdNuuy7vFDngA6y1Hc7DQuUlU01rW0+3zd7m6Ieo/uFGIttHpsZOpXFP9vZJV8ePhlAPlk18hfJz402EMMB4ofW77EdhDwntBxqo0KGUY0MLDK9dKlgICN+uj4wxaAb7TaXh30al9gztIb+DAJD2p7LVPAkCFNPintyaNUmN7sTIHpZ6f3o5tcUZr863pc0u2sbHXNtrqnaOfdTTyGRQ86bqs19xK+gKTXAKq25cHmgdBt8CqS7J/N6GhouO5LQtHu2/4G8yAyt5Jk7/c8yU9IYegsCwCBAXoCdxr6o3cOV2lTcEA44P+tlEPvI0SYDK+7+bu0YwdYSsMldntPzCShcZzINYWfP5xtWet9IK6LMSDZp77RChPpj3l0vMWw8Wb4bY3kF9U6DsVdgf1Lr7RjVdvtFt3D8REMTPPUqXsWuTC66XvEHlJm6E6JFOGG+i6vwGxI9/KTmgYEu+0kMBqcer5pwLInoeVAkpw9VJygttVq31JZ0y3sLNhvmvDaC4xrGj0LthAmp8AF7k+iDPOxdLVAOBTj0lDBeccL1w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(40460700003)(2616005)(36860700001)(336012)(70586007)(6506007)(2906002)(36756003)(6666004)(6862004)(6486002)(356005)(6512007)(53546011)(31686004)(186003)(26005)(47076005)(70206006)(508600001)(86362001)(31696002)(54906003)(30864003)(8676002)(82310400005)(5660300002)(4326008)(8936002)(316002)(81166007)(83380400001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 06:09:23.2926
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8567e62e-0714-40eb-dde6-08da2426a5a8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7787

Hi Stefano,

On 2022/4/21 5:08, Stefano Stabellini wrote:
> On Wed, 20 Apr 2022, Wei Chen wrote:
>>> On Tue, 19 Apr 2022, Wei Chen wrote:
>>>>>> ### 3.2. Xen Event Channel Support
>>>>>>      In Current RFC patches we haven't enabled the event channel
>>> support.
>>>>>>      But I think it's good opportunity to do some discussion in
>>> advanced.
>>>>>>      On Armv8-R, all VMs are native direct-map, because there is no
>>>>> stage2
>>>>>>      MMU translation. Current event channel implementation depends on
>>>>> some
>>>>>>      shared pages between Xen and guest: `shared_info` and per-cpu
>>>>> `vcpu_info`.
>>>>>>
>>>>>>      For `shared_info`, in current implementation, Xen will allocate
>>> a
>>>>> page
>>>>>>      from heap for `shared_info` to store initial meta data. When
>>> guest
>>>>> is
>>>>>>      trying to setup `shared_info`, it will allocate a free gfn and
>>> use a
>>>>>>      hypercall to setup P2M mapping between gfn and `shared_info`.
>>>>>>
>>>>>>      For direct-mapping VM, this will break the direct-mapping
>>> concept.
>>>>>>      And on an MPU based system, like Armv8-R system, this operation
>>> will
>>>>>>      be very unfriendly. Xen need to pop `shared_info` page from Xen
>>> heap
>>>>>>      and insert it to VM P2M pages. If this page is in the middle of
>>>>>>      Xen heap, this means Xen need to split current heap and use
>>> extra
>>>>>>      MPU regions. Also for the P2M part, this page is unlikely to
>>> form
>>>>>>      a new continuous memory region with the existing p2m pages, and
>>> Xen
>>>>>>      is likely to need another additional MPU region to set it up,
>>> which
>>>>>>      is obviously a waste for limited MPU regions. And This kind of
>>>>> dynamic
>>>>>>      is quite hard to imagine on an MPU system.
>>>>>
>>>>> Yeah, it doesn't make any sense for MPU systems
>>>>>
>>>>>
>>>>>>      For `vcpu_info`, in current implementation, Xen will store
>>>>> `vcpu_info`
>>>>>>      meta data for all vCPUs in `shared_info`. When guest is trying
>>> to
>>>>> setup
>>>>>>      `vcpu_info`, it will allocate memory for `vcpu_info` from guest
>>> side.
>>>>>>      And then guest will use hypercall to copy meta data from
>>>>> `shared_info`
>>>>>>      to guest page. After that both Xen `vcpu_info` and guest
>>> `vcpu_info`
>>>>>>      are pointed to the same page that allocated by guest.
>>>>>>
>>>>>>      This implementation has serval benifits:
>>>>>>      1. There is no waste memory. No extra memory will be allocated
>>> from
>>>>> Xen heap.
>>>>>>      2. There is no P2M remap. This will not break the direct-mapping,
>>>>> and
>>>>>>         is MPU system friendly.
>>>>>>      So, on Armv8-R system, we can still keep current implementation
>>> for
>>>>>>      per-cpu `vcpu_info`.
>>>>>>
>>>>>>      So, our proposal is that, can we reuse current implementation
>>> idea
>>>>> of
>>>>>>      `vcpu_info` for `shared_info`? We still allocate one page for
>>>>>>      `d->shared_info` at domain construction for holding some initial
>>>>> meta-data,
>>>>>>      using alloc_domheap_pages instead of alloc_xenheap_pages and
>>>>>>      share_xen_page_with_guest. And when guest allocates a page for
>>>>>>      `shared_info` and use hypercall to setup it,  We copy the
>>> initial
>>>>> data from
>>>>>>      `d->shared_info` to it. And after copy we can update `d-
>>>>>> shared_info` to point
>>>>>>      to guest allocated 'shared_info' page. In this case, we don't
>>> have
>>>>> to think
>>>>>>      about the fragmentation of Xen heap and p2m and the extra MPU
>>>>> regions.
>>>>>
>>>>> Yes, I think that would work.
>>>>>
>>>>> Also I think it should be possible to get rid of the initial
>>>>> d->shared_info allocation in Xen, given that d->shared_info is for the
>>>>> benefit of the guest and the guest cannot access it until it makes the
>>>>> XENMAPSPACE_shared_info hypercall.
>>>>>
>>>>
>>>> While we're working on event channel PoC work on Xen Armv8-R, we found
>>>> another issue after we dropped d->shared_info allocation in Xen. Both
>>>> shared_info and vcpu_info are allocated from Guest in runtime. That
>>>> means the addresses of shared_info and vcpu_info are random. For MMU
>>>> system, this is OK, because Xen has a full view of system memory in
>>>> runtime. But for MPU system, the situation becomes a little tricky.
>>>> We have to setup extra MPU regions for remote domains' shared_info
>>>> and vcpu_info in event channel hypercall runtime. That's because
>>>> in current Xen hypercall concept, hypercall will not cause vCPU
>>>> context switch. When hypercall trap to EL2, it will keep vCPU's
>>>> P2M view. For MMU system, we have vttbr_el2 for vCPU P2M view and
>>>> ttbr_el2 for Xen view. So in EL2 Xen has full permissions to access
>>>> any memory it wants. But for MPU system, we only have one EL2 MPU.
>>>> Before entering guest, Xen will setup vCPU P2M view in EL2 MPU.
>>>> In this case, when system entry EL2 through hypercall, the EL2
>>>> MPU still keeps current vCPU P2M view and with Xen essential
>>>> memory (code, data, heap) access permissions. But current EL2 MPU
>>>> doesn't have the access permissions for EL2 to access other
>>>> domain's memory. For an event channel hypercall, if we want to
>>>> update the pending bitmap in remote domain's vcpu_info, it will
>>>> cause a dataabort in EL2. To solve this dataabort, we may have
>>>> two methods:
>>>> 1. Map remote domain's whole memory or pages for shared_info +
>>>>     vcpu_info in EL2 MPU temporarily for hypercall to update
>>>>     pending bits or other accesses.
>>>>
>>>>     This method doesn't need to do context switch for EL2 MPU,
>>>>     But this method has some disadvantages:
>>>>     1. We have to reserve MPU regions for hypercall.
>>>>     2. Different hypercall may have different reservation of
>>>>        MPU regions.
>>>>     3. We have to handle hypercall one by one for existed and
>>>>        new in future.
>>>>
>>>> 2. Switch to Xen's memory view in EL2 MPU when trap from EL1 to
>>>>     EL2. In this case, Xen will have full memory access permissions
>>>>     to update pending bits in EL2. This only changes the EL2 MPU
>>>>     context, does not need to do vCPU context switch. Because the
>>>>     trapped vCPU will be used in the full flow of hypercall. After
>>>>     the hypercall, before returning to EL2, the EL2 MPU will switch
>>>>     to scheduled vCPU' P2M view.
>>>>     This method needs to do EL2 MPU context switch, but:
>>>>     1. We don't need to reserve MPU regions for Xen's memory view.
>>>>        (Xen's memory view has been setup while initialization)
>>>>     2. We don't need to handle pages' mapping in hypercall level.
>>>>     3. Apply to other EL1 to EL2 traps, like dataabort, IRQ, etc.
>>>
>>>
>>> Both approach 1) and 2) are acceptable and in fact I think we'll
>>> probably have to do a combination of both.
>>>
>>> We don't need to do a full MPU context switch every time we enter Xen.
>>> We can be flexible. Only when Xen needs to access another guest memory,
>>> if the memory is not mappable using approach 1), Xen could do a full MPU
>>> context switch. Basically, try 1) first, if it is not possible, do 2).
>>>
>>> This also solves the problem of "other hypercalls". We can always do 2)
>>> if we cannot do 1).
>>>
>>> So do we need to do 1) at all? It really depends on performance data.
>>> Not all hypercalls are made equal. Some are very rare and it is fine if
>>> they are slow. Some hypercalls are actually on the hot path. The event
>>> channels hypercalls are on the hot path so they need to be fast. It
>>> makes sense to implement 1) just for event channels hypercalls if the
>>> MPU context switch is slow.
>>>
>>> Data would help a lot here to make a good decision. Specifically, how
>>> much more expensive is an EL2 MPU context switch compared to add/remove
>>> of an MPU region in nanosec or cpu cycles?
>>>
>>
>> We will do it when we get a proper platform.
>>
>>>
>>> The other aspect is how many extra MPU regions do we need for each guest
>>> to implement 1). Do we need one extra MPU region for each domU? If so, I
>>> don't think approach 1) if feasible unless we come up with a smart
>>> memory allocation scheme for shared_info and vcpu_info. For instance, if
>>> shared_info and vcpu_info of all guests were part of the Xen data or
>>> heap region, or 1 other special MPU region, then they could become
>>> immediately accessible without need for extra mappings when switching to
>>> EL2.
>>>
>>
>> Allocate shared_info and vcpu_info from Xen data or heap will cause memory
>> fragmentation. We have to split the Xen data or heap and populate the pages
>> for shared_info and vcpu_info, And insert them to Guest P2M. Because Armv8-R
>> MPU doesn't allow memory overlap, this will cause at least 2 extra MPU
>> regions usage. One page could not exist in Xen MPU region and Guest P2M
>> MPU region at the same time. And we definitely don't want to make the entire
>> Xen data and heap accessible to EL1. And this approach does not solve the
>> 100% direct mapping problem. A special MPU region might have the same issues.
>> Except we make this special MPU region can be accessed in EL1 and EL2 at
>> runtime (it's unsafe), and update hypercall to use pages from this special
>> region for shared_info and vcpu_info (every guest can see this region, so
>> it's still 1:1 mapping).
>>
>> For 1), the concern is caused by our current rough PoC, we used extra MPU
>> regions to map the whole memory of remote domain, whose may have serval
>> memory blocks in the worst case. We have thought it further, we can reduce
>> the map granularity to page. For example, Xen wants to update shared_info
>> or vcpu_info, Xen must know the address of it. So we can just map this
>> one page temporarily. So I think only reserve 1 MPU region for runtime
>> mapping is feasible on most platforms.
> 
> Actually I think that it would be great if we can do that. It looks like
> the best way forward.
> 
> 
>> But the additional problem with this is that if the hypercall are
>> modifying multiple variables, Xen may need to do multiple mappings if
>> they are not on the same page (or a proper MPU region range).
> 
> There are not that many hypercalls that require Xen to map multiple
> pages, and those might be OK if they are slow.

Ok, I will update it in Draft-C.


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 07:05:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 07:05:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310701.527620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhnLe-0001EK-G7; Fri, 22 Apr 2022 07:04:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310701.527620; Fri, 22 Apr 2022 07:04:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhnLe-0001ED-DG; Fri, 22 Apr 2022 07:04:58 +0000
Received: by outflank-mailman (input) for mailman id 310701;
 Fri, 22 Apr 2022 07:04:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vZpq=VA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhnLd-0001E7-0r
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 07:04:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 83892692-c20a-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 09:04:55 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-BlNjzlMIOiqa5TkW_rwQhw-1; Fri, 22 Apr 2022 09:04:54 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4323.eurprd04.prod.outlook.com (2603:10a6:208:58::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 07:04:52 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 07:04:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83892692-c20a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650611095;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yax3tILkwXc8VPvBbFmXqqs5HeYzHB4zMFLmBxlChQQ=;
	b=UXq4WLkDjkvEDQf+Vdto/MqkBZTvKMMJlL7GH+1njxj04C+TwA2/413TW+xAnkHTeYgbrT
	0ZUjvFsNVC2fL1B6waim4N2Dy7L0kkFEFk1jwuSBYRBUFDOHnUNi49o6kqwagcuRyPM6ZG
	B07b9S1l4JnM1SLNy8nPdELtQCklwW8=
X-MC-Unique: BlNjzlMIOiqa5TkW_rwQhw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KUE3rls7LnoAAWDLC5pa/zhnUYNl8qKQcvIa9NCEj8mtKZ4h7E+g4WQ0+1uBmdbSs3PAJ7UrL94uieR/T0KvZ3MgVuvIOhGJJinebuLUV4R1wABpJPCOUORmVvUAV62cvGa2+7I+w+LEl0m2xyLMvgXszZiezDUVg48h5+zVVKaS6MGULHsqHcPFTFKOPdjxJrwNolWH4B2QEIefMU423VhgkUyx1Q/lpnFHKosoSco1OCFKA/asioyOUbw4eyByxstF1fKIwfL5oaYwjMgXbn7pFu4IonLckRx5fxDeBN73eFnct4mtcWMJO6jug+PFbeSlIchsDnVeWIIWlaQRiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2hmD/s1ez1XCcUlh9effmB5B4jmOpv8hHy1p5xn2eW8=;
 b=j9EfyFQ0mY2d5gb1gN5HTo92RxW+jVLcTRw/LrIYYbgCMxipiuwbKho/70vAMdaOhkqmluIcI6V1mY79858h54avOr9S09iF/cgGpSXkZTWlw53JMlZGSmwQvd6GrDE3EebWvVtILPJAs28fxMcOjjiTjSWvK89fZbvKTZdjEpfxhfPilLP9521B2fgCCmDdKfK+4lFFRSNGo33wCbQBiwXvdQRPvtJKe3Tu4kfjFBzvZINIVytc11eJqbbQLqw8DbUwamom8jVOdupBnPT6jAP00uVmCIWPFAdS9QzX57L51OfPIsyPU0Xn+TgWW8i+89MkOQ6Lq5L0ZEbmZDzdEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <335fcc84-ea0e-b250-11d7-a07e4bdeefeb@suse.com>
Date: Fri, 22 Apr 2022 09:04:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/build: Fix MAP rule when called in isolation
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Anthony Perard <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220421160039.24564-1-andrew.cooper3@citrix.com>
 <b03098dd-7fd4-ed91-cc94-35fd24c46126@suse.com>
 <e563c62a-622c-15dd-34f7-57997132649d@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e563c62a-622c-15dd-34f7-57997132649d@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0045.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d80991f1-e574-4ab9-1570-08da242e65dc
X-MS-TrafficTypeDiagnostic: AM0PR04MB4323:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB43235DF36B22C7D23E9AD237B3F79@AM0PR04MB4323.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	p9znMFzoa0sLFHvLM0Stos7jhBFbj/mBP/0D5NybC9OUqbv15JwzLBNxe9dNt35E5LhA7uOFN97c7knWHoUzyeTClLe3Jl/NfFRlokhijISK+C1FYpbzIDxC1yDRSHuM5TB7SoUJFyCPe0phfO1Pzq9T447m3CfZfp14oQLtOQRoRuBUodLy1P6su8tATiiIGKN2KGlCvK4ITNf2+JnY6Q9Q5dmLoCMq+Bn/wHZPf2vqotkD/u0dwEKRVKDvwBREuQOWBf5S59Y/D+96i3DN9t3En7EYQojacrd17NFsXcde184zIr1EgDjyuwACANlFh47fyNW0452bfCNk0GWlYLVP4eAM9GSTfiwGFYSTUdpMp8gCMHJhuTMaNbHB7ZpDHUcRntMIGST1KPoPXAZQsNKuyl+JntnSUvmPGrY1RdRwTjJrMbGI9/rXvWPs/L0L62927hw7qtYBpJZHv6MeV4XKib6UEJvbfLlhdZNpNTTbio3uIUsMiF1Zp3t2r64Eai05EaYfZBNxwWrcXi2z38zEwUUpzXbQTyXZK0uD9WzkdtaY9RiVbKIVAAScAqXxFQfjmDlG7P9ReME+Rpzn3wGVAa7tyFOHrdCf49Ch8pCEMMvErIezivJHtgkEJLksEMagMmgokyqUxy5tW6V/dF+4nZ2A6B5CfzhZirpXz4Q+M/7yArKNRATX0zypH5/MEEj4suVst2ItRoqknq+hWeq3BiwBkH1uX/VfRba7CfBJljuXcERiwv56oM7l7Jf+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6486002)(53546011)(6512007)(26005)(38100700002)(6506007)(5660300002)(2906002)(83380400001)(508600001)(86362001)(2616005)(31696002)(186003)(31686004)(316002)(66476007)(54906003)(36756003)(66946007)(6916009)(66556008)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0gLiBl2EHLm5H+9LgoytnfcnG6JYCvLXL/dYtRk6oQzk8+73Ntp85vgEjSuE?=
 =?us-ascii?Q?TVFdWMuzBUIxoL7GDBA70cyLbyn4GC8nG4xDIDFd6Bv1ErqVsYgndPXX8lIV?=
 =?us-ascii?Q?J7J7hYNe1s03dg3LQHPUIEBgosB4yPhKNSUgvmZow9Oq+4FxFMrQP4aycmxF?=
 =?us-ascii?Q?VW9RGaCuoZ0YHqKtkYOLaTE+XdQ0PUMPF/hyXug0ll1Nu1ojl8ZvsxqA50G0?=
 =?us-ascii?Q?g9bT97nnRygOBO+n59fezHzCa6PdHDp+u9hafmu4u/W+or30K3To3ECcSOWV?=
 =?us-ascii?Q?29iAwC6AHzoVGKNkNHW2l65AtHNAK5LTPi2a5r7AEZ0W0Z3xc5v6KcDO9Z/O?=
 =?us-ascii?Q?OOsDKf+qKZG4MD7dQ+1te3ot48MVlruKjVwyUXQm6dHQTsdWAY6UVgMS30AB?=
 =?us-ascii?Q?uzLC+csy9raBD4iipYTisrlOWsJqTb1PN+UBKyoSP+d8RbfPiztrgpwBzo6O?=
 =?us-ascii?Q?uTwG0MSCL4j9LwexA8BsiP9QqZcrEVTffAU31nsIMna78yLEzT4wJmGlx0KV?=
 =?us-ascii?Q?8A+Wam2yn3Rx6FjHNgNRfWvxVulhfZ/x2C6IvhpkPvUDdnlWntyRUSkHKZK5?=
 =?us-ascii?Q?QDOIeusJJ44X/z7R+7PqoAfmn77Ih17l1DdoQRPF06uTM0VdMhuuVjgnjylo?=
 =?us-ascii?Q?R5CN1JPBzArWx+uiz950N+Jgej2+pvEwAbzv5nYMVDEWvBL1o1A8G/XkxoSu?=
 =?us-ascii?Q?E0e1QYJDYHnYXWouksSOXt4XMovvMoeEs9OE7Ff/NxfEyKsTb25Cjr1zOVF4?=
 =?us-ascii?Q?KYBOSR4XQQVdyL4LiUaw99+65sAf3HACosEQPVWdUIWzx8djuzQsmlq57nk3?=
 =?us-ascii?Q?v0k1scvSr8jImM9/B9LDooCrtCsE8/v0FoGB68C/wtl1SLznhA0bk+4E8gOw?=
 =?us-ascii?Q?of3yF3Nd4QREvV44zu6FMopB4zX8EFWWY3ZWlb3Uf8CFqTnf86rqAQLUrijh?=
 =?us-ascii?Q?7le5VKIqod7Zhj++oU3qHOSXdY46aj315URxZfd2zZu0pVmIlQsPpHM9jNI/?=
 =?us-ascii?Q?7B2hTkoQ3BY/wdMipuTvQlSqApKoZXxAtktR/E7RCXogSc5hzPml3TkQYeZz?=
 =?us-ascii?Q?12ENTohvBpRPZNm0/dfLw/qKm5lEnZPWp4rVs1eWcATxoRHKVOAX9DKCeiBf?=
 =?us-ascii?Q?w6THywt9AoyNkyssU542sdSP/WPza4VIe7PDi9fgq5PcrcTGRwqNZGoT+ZnO?=
 =?us-ascii?Q?K3ymQCaCdTd3emKvoUb9WPw11/xbmCuTkaG/HoacNaDoKn2PZZPUO7/13kQz?=
 =?us-ascii?Q?v3lddTpmGrBphAk2TIN1XEmViLrR+zD9ONsWBMY/ly0vK6acsFSkG90eayww?=
 =?us-ascii?Q?r4Ey3n3OVzQ52jbgOYpLNzy5yAW6QSbi6OAcDax7kQdCaopMMFOZ9cB4B3E5?=
 =?us-ascii?Q?mULazxJ0SELuAf/6Qd0EpCAzQk62giIC1EVpotMg4aelbByft1Skw3qDkn1M?=
 =?us-ascii?Q?yVrC1n+kIN2dGqwkCYVzHKBl1bbTQUY3t5n1T/CgCB1H/bCPM5ZCMshR9E7X?=
 =?us-ascii?Q?d2EvJS1YJUPq6eNovo0/t8kfkd+z5cfaBVIBy2FUAqh5LUqweVdN1uvMgte/?=
 =?us-ascii?Q?OzN6mRwI8SHB3El1OpiNegPwq1mC0itKEIt/KR4U3cxjW6SZyV3r9v39sJoA?=
 =?us-ascii?Q?E0UwIhEmKyyB+7Gfh7fZj9p2bq4RqxipcuokwboOMF5r5/7bDB1JK8scUP3e?=
 =?us-ascii?Q?H+T7W4C9hm/4ewr5c64wojTfRt/u9jC5UyLRDrhQMAPXtB/GLmAbC/ED8gO0?=
 =?us-ascii?Q?F3W622zjwg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d80991f1-e574-4ab9-1570-08da242e65dc
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 07:04:52.3926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wVq1OxrF0xqYI/M3qzSYwInAoAlkJy42rYYCJpdoDo9n3cMAP3XVoauBGHPTeeYPsF2QpArcTO6kzHu/1RCpeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4323

On 21.04.2022 18:42, Andrew Cooper wrote:
> On 21/04/2022 17:09, Jan Beulich wrote:
>> On 21.04.2022 18:00, Andrew Cooper wrote:
>>> Now that `make MAP` might rebuild $(TARGET), it needs removing from
>>> no-dot-config-targets.
>> Which raises the question whether the MAP target originally was
>> meant to be used only on an already built tree, which would
>> explain the missing dependency that you added in the earlier
>> commit.
>=20
> I can't comment on the previous expectation, but the fact you couldn't
> previously do `make -j4 build MAP` was simply broken.
>=20
> There are also several other breakages in Xen's build system which it
> turns out is forcing all downstreams to bodge around in ways that range
> from gross to dangerous, and which need fixing for everyone's benefit.=C2=
=A0
> (Emails will be appearing for those shortly)

Right - at least tests and cloc look to have a similar issue.

> The current debug target (just runs objdump -d) is similar to MAP,
> except I don't find it a credible target to use and was planning to
> delete it.

Well, yes. I wasn't even aware of this mis-named goal.

>>> Otherwise the build eventually fails with:
>>>
>>>     CPP     arch/x86/asm-macros.i
>>>   arch/x86/asm-macros.c:1:10: fatal error: asm/asm-defns.h: No such fil=
e or
>>>   directory
>>>       1 | #include <asm/asm-defns.h>
>>>         |          ^~~~~~~~~~~~~~~~~
>> Why would this be? asm/ isn't a symlink anymore, so should always
>> exist. I would have expected an error about .config or
>> autoconf.h not existing, ...
>>
>>> Fixes: e1e72198213b ("xen/build: Fix dependency for the MAP rule")
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> ---
>>> CC: Jan Beulich <JBeulich@suse.com>
>>> CC: Anthony PERARD <anthony.perard@citrix.com>
>>>
>>> Backporting notes.  The original, e1e72198213b, wants backporting as fa=
r as we
>>> can go.  This patch is only relevant from 6c122d3984a5e onwards, so 4.1=
4,
>>> which is why my main developing/testing on 4.13 didn't spot it.
>> ... and the commit you reference seems to support that expectation.
>=20
> I haven't spent very long investigating exactly how it breaks.=C2=A0 I do=
n't
> think it's important, because the purpose of no-dot-config-targets is to
> skip large swathes of the logic.

I find it generally helpful to understand breakage when it looks odd how
exactly things break, but anyway
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 07:09:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 07:09:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310706.527632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhnQ4-0001rV-2F; Fri, 22 Apr 2022 07:09:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310706.527632; Fri, 22 Apr 2022 07:09:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhnQ3-0001rO-Uh; Fri, 22 Apr 2022 07:09:31 +0000
Received: by outflank-mailman (input) for mailman id 310706;
 Fri, 22 Apr 2022 07:09:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vZpq=VA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhnQ2-0001rI-PB
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 07:09:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 26f376e1-c20b-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 09:09:29 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-_t1u2K31NOiGxYg3IN56oA-1; Fri, 22 Apr 2022 09:09:28 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8661.eurprd04.prod.outlook.com (2603:10a6:10:2dc::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 07:09:26 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 07:09:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 26f376e1-c20b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650611369;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BolHv1M2s9SqPW1A5As/cq32oxmIFoz5uny0gNNpCao=;
	b=B8Ryqw5TCbpR3LZXnAi70/7xvcUSsvp+I3JCsUBsYXHrHX4T3RE1A8vsiDfCgzaSQpLaOx
	maX1m9JBAaLuBcOH523WCvZcz7elFyup+nUXEFEZLrPBwmVxglmEYb3+guySuQamJWdLKB
	+cB2Q1bMujrGJvXWb54t6gJ+c5pSXKM=
X-MC-Unique: _t1u2K31NOiGxYg3IN56oA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YExrMOCCUCoYEZsXZbvrMckY1m/BdyzoDlyA1y1HsG3E7lOI2WjebvCussIcSxJIYiHWSFJ6EeoK3Qurpg6GRzHZsqX4pIlRHVJSMx73mTVeZVvzEctOxxp+BPrplxdKFtS5UV3vZGFFfB/E1wIcxAp9Yr0E3o5HPGuULdhuNOFkf5267waltj26kEshnAM4+ILOIGLb402bbYvAi7SyYuSdebmNlDZ3jEHA+mkJIh1/O0wMRFBZfI/XrMF2IHTRWGIhKNMfiZJu4R6I6O6oxk8L99RQ/rYeqdfZCia6dJ2I7QuiyZDWZgvqycGUoQypSe7yNqNiz+fw2R9tyeDptw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jMX/ZkCefo+xl6c48nIAY5xxfgtI5L33BHnHz7NMMTk=;
 b=JH6Y3jon3HhaJhO+lQ4KfClorI7M/vndzXpSVZp5CXGRPC9AENZKH9k+nJ+euD7ZkfK0DlbrJXb8E/tBQOfIwtOLX18LhfzcX/AqDg5ulYWEdx7LnH8MHcoJ3gS+YcO0LsmRl35PldiD/YNzX89QfLFcYZ6Ox8M5KZ1bTbp3ChGw7pkwse5Yvj/nYJR6MGZbI7y1FkzESTJnkN7JO68d3f8ecjSzMHVBMl7EHPH7UbpYTKidLzjYwhfFoag4NobYl3oiZD5livUPnKdb5gAqDAdT28dVmEa2+QMcMB++Q/I8vM2V0dB0gLE2dlolthC8+otO+ar2hWIrrvbVR1PF8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a83fc8db-f8c0-5a17-a668-1a00cb1fdc2a@suse.com>
Date: Fri, 22 Apr 2022 09:09:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <George.Dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Juergen Gross <jgross@suse.com>
References: <20220420055736.27901-1-jgross@suse.com>
 <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
 <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
 <74f6105d-d3a3-6508-3c6f-3aac53285c5f@suse.com>
 <7f55e68c-17ed-c682-9ba7-4835d8e1a79b@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7f55e68c-17ed-c682-9ba7-4835d8e1a79b@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P189CA0024.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::29) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 83c793a3-ab7f-4fd0-2ed5-08da242f095c
X-MS-TrafficTypeDiagnostic: DU2PR04MB8661:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8661328A9172050A4A23414FB3F79@DU2PR04MB8661.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xUVZcCkQigrX6Ctd7vklMQCd77BFK2q+J+UQcCZBZKlP24OLSD055X4/J8RHRoaHPsIskHSkqyk/DeZ7jjvChd81w3pTGRCxjJufeirk8tvdyDPC5lqWXCXrOKKKI2YvsCp7+2Jq4US3sPDErRHJKV1kG5lNiTlOVF2zmGxp+Mnc9TkU4IzPdY0A/rUffRul6vqK3gQopjS5PnCB0O2df2JQdzsRiheIJ8U61LqZphvDUU2nV3oBuTspHJ27X9PAcSZgS+Ey8xVVw6LCXAnewOkTut7VZQz1MOKGPnpcW0FcWKzleO3sY+ed2bvGFErE+IICHc5Aa35dpHDOugIbx4uZSQZGFlPM8BLfnNffMP2i1q5lRCpZzsiWwyYynO6cwEEf7X7L0kgiSET5S5v0ZFi97BkJeTCHGMV23q39aCBAPjieozJFeEru3kJ+SENsuLysBrvYQu9Kt7erf8S1a839arybr0ZKWIIHlUkyzQyYFt7pJBXvaj3yJZRkMXCME9gkFl4ThLh0ICDg3y+YQEHBZ9DRWTcGRcWtKP9S2CE5xEL8/KHHhrzYWkjOJEhxdYBG9/FU/Mta3zJJrpCyE2cxiX/v+O2PzIpHPolStoUw+Ov1Ao4nGNX4T6RQFwXMcKVuXvD5IQIBUQifX+kL2cmieGq61sa5kNyFZGe8nOf1FGffidmNVIVsknvnGNq1kyZGaSgeR9mPD65q61dej/glqXQ0+ROzXlLO3z2jx4xBr658F9KVSEDOyEIE8fQf
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(54906003)(6486002)(31696002)(83380400001)(66556008)(66946007)(4326008)(8676002)(2906002)(6916009)(508600001)(8936002)(7416002)(5660300002)(2616005)(107886003)(26005)(186003)(86362001)(31686004)(6512007)(316002)(53546011)(6506007)(36756003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GlaEjjmw5bGcOFNGOs2vv3MuTJv6rXo8HIiGKIMCBu94EfOqrbVX8HZh40OY?=
 =?us-ascii?Q?jEzYIIhMuTWraeJvdQNt/9BWarjwq1Mz66gQyFmE61aa7O6JVbR4MkY1KWVc?=
 =?us-ascii?Q?x8PkhVdU3ilxHarnMSxRKtOqHN7tCKBBto0lGXDjqa6V3/jcXGr7Snm3gu6d?=
 =?us-ascii?Q?DIMDa62XhTCjMt2IyeTTly2PcyJv5otiznQYAb551uUFnExk41TKoRW+gmlT?=
 =?us-ascii?Q?+UOBeQqs4rT8SGOlVjZPr2treFGH/nxyaSO3W9YBnq7cG/4M4WGlT6AWOYJp?=
 =?us-ascii?Q?BwdumpTn9hZuR5bvhFKyS0y1AQPB3Yu+csRSHbyTA31kU66EleCDpYEQrUaO?=
 =?us-ascii?Q?aiNWntQQjrFBJEmBda3+lHE6rVcLj3gYxPZJBLXIlM+84uIlJPS2Q5kx5Z5V?=
 =?us-ascii?Q?cirgK1qhw8I9DRokv0Z9jhBMFQIEwSI7zxECQbbfBJMeb3unfiabtyb8X1sw?=
 =?us-ascii?Q?46c/uVM4VdfAA1rq6pw44A7YkfiCewiq/KZfWSgfXfiQ2WWAXLoiaO5XfDDw?=
 =?us-ascii?Q?RFFgTkoeTEtUgSRrL0Zms6ZJ5wId9sH+Bo5h23ecic+0fh5SxngAEKiwQNPI?=
 =?us-ascii?Q?dyoFp8LWSlGUs2Bo17xojbSgtGCLJzVjUwNboIblS64Zo1Vn0TL2PgOCYlnb?=
 =?us-ascii?Q?+7tCggRmpW4YP8tLQT8GOGrtDN/BOIXiwIyiUh+2Th103UNm4zM8mrW4s2Xm?=
 =?us-ascii?Q?KOKDiD+E+tZRRXqDIFsLeAaQvnjg8lGdSzC2AToGQspnEWTPgLrhKrDoNzGF?=
 =?us-ascii?Q?9yZFPKjrCa6U1s+7X2pYb0XfvH7vQtwBJvVlHwO0g2InAF//tTkHo7n9jSEQ?=
 =?us-ascii?Q?wvOlwHZV8/i5pNUJhQDUhcuilcLi3vD65KzUSxpDEufY5edL8ii2jNtwcLuT?=
 =?us-ascii?Q?ZolF5JtVtlQ6tqBowtkE0ttaedypQgstPuBPhL0+ohtXUzEtUqnKoOMmNQOG?=
 =?us-ascii?Q?rvmWJZf+YD3+ILnxYGxf0t6qbnjOcwU91dLwCH07XRy1+HwZifRNI2HCuJwc?=
 =?us-ascii?Q?6BhC8gSnJTjHTpV2Uu7CRiV4Zh+GRUsHIetawISNlUUXDvqa4Osle5BzUGE6?=
 =?us-ascii?Q?HBttiNq/iQz0ArFragxTfOKtUF6flIsHtcWDyrX3rQGxbEtpjhy1/7pQBW8r?=
 =?us-ascii?Q?4qDeAriTj/zTu2uEpzpSPcjifQM3dJKuN38KsIWHUsNXSxZZuCFrREqrODG1?=
 =?us-ascii?Q?DK96mUHvvKsPlEjCTXJ1WoNLiAV2NeuBE6oldCg2Fjah7DhG17prN3CBUlFA?=
 =?us-ascii?Q?7HOZ3JX1ThYkgn9F1mL3cnaKA1FRI5CHxgYZ02Y+t8lVRUoFbkEIBypwH206?=
 =?us-ascii?Q?QVRJav3kqwFAfq8bsP43LOBYpOdmeT5AbgOieJXxdKnx8tQ01FI+C8jGfrtf?=
 =?us-ascii?Q?aPia6SKyWAMTtzTL1qMiz+fu3VZeHFkZesNRfhrxLpo03i6OvT6+o1y4JtHK?=
 =?us-ascii?Q?maqCbnxZZyauhzmGehP3DK1lKk97hYXoLPLeKxV0pXhi3v1D/+zp/p7TQPDn?=
 =?us-ascii?Q?cTuxFtluimGORv4tdjdh6IzfoVhBHVy4RmF+5LqnFJbp++G0lPAJJno4aM0Y?=
 =?us-ascii?Q?D0Iyxh4KPn5VcGMT7+T8Hhp9OLNmC9/ioLg/+gU24MoYQDDyURi0auYtwCuv?=
 =?us-ascii?Q?zH5O9X/8srsY6B1SYDdyqpoigWtqV6wsiQEF1Uq4IaYs2R9SR8ham3bY49WF?=
 =?us-ascii?Q?TygmvE1qtaS8UD6iXE6Xsu5Xp3KrpscyV9FjR5q6HzyBkh9sPjtu+jM5WFwY?=
 =?us-ascii?Q?UMQNvW33Aw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83c793a3-ab7f-4fd0-2ed5-08da242f095c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 07:09:26.6851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W4ZvCE20Ya+obN+pPfNje3LPZppxXEfarm7YnUQTNyQBJ7D2v5YJHZOTebchGwStg2FGpv6BYA3oyAY2OsjVXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8661

On 21.04.2022 19:47, Andrew Cooper wrote:
> On 20/04/2022 07:27, Jan Beulich wrote:
>> On 20.04.2022 08:22, Juergen Gross wrote:
>>> On 20.04.22 08:11, Jan Beulich wrote:
>>>> On 20.04.2022 07:57, Juergen Gross wrote:
>>>>> --- a/xen/include/xen/iommu.h
>>>>> +++ b/xen/include/xen/iommu.h
>>>>> @@ -341,8 +341,17 @@ struct domain_iommu {
>>>>>   /* Does the IOMMU pagetable need to be kept synchronized with the P=
2M */
>>>>>   #ifdef CONFIG_HAS_PASSTHROUGH
>>>>>   #define need_iommu_pt_sync(d)     (dom_iommu(d)->need_sync)
>>>>> +
>>>>> +int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
>>>>> +                    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
>>>>>   #else
>>>>>   #define need_iommu_pt_sync(d)     ({ (void)(d); false; })
>>>>> +
>>>>> +static inline int iommu_do_domctl(struct xen_domctl *domctl, struct =
domain *d,
>>>>> +                                  XEN_GUEST_HANDLE_PARAM(xen_domctl_=
t) u_domctl)
>>>>> +{
>>>>> +    return -ENOSYS;
>>>>> +}
>>>> As said in reply to Andrew as well as in a number or earlier occasions=
,
>>>> I firmly think that this wants to be -EOPNOTSUPP, not -ENOSYS. Views
>>> In libxl there is an explicit check for ENOSYS being returned for
>>> assigning/deassigning a device, same in the xc python bindings.
>> Urgh.
>=20
> Honestly, I wasn't particularly happy with your push to swap ENOSYS out
> for EOPNOTSUPP.=C2=A0 This shows plainly why it's a bad move.
>=20
> An end user doesn't give two hoots about the distinction between
> hypercall not supported and subops not supported; they care about
> whether Xen can perform the requested action or not.=C2=A0 ENOSYS is the =
more
> common way of signalling this, and having only one errno value to check
> is better for everyone involved.

End users are of little interest here. Code looking for ENOSYS is what
is of interest, when the meaning of ENOSYS is quite well defined as
"system call not implemented" (which we merely extend to "hypercall").
Anything smaller scope than a major hypercall cannot possibly be
"hypercall not implemented". Code caring about knowing one vs the
other should not be misguided, and code looking for one when the other
is meant is simply flawed.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 07:27:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 07:27:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310713.527642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhnhE-0004uQ-FH; Fri, 22 Apr 2022 07:27:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310713.527642; Fri, 22 Apr 2022 07:27:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhnhE-0004uJ-CH; Fri, 22 Apr 2022 07:27:16 +0000
Received: by outflank-mailman (input) for mailman id 310713;
 Fri, 22 Apr 2022 07:27:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vZpq=VA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhnhC-0004uD-Nt
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 07:27:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a0a9fa63-c20d-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 09:27:13 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-2Is5hBucOPCENRDt3XpBvQ-1; Fri, 22 Apr 2022 09:27:10 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by GV1PR04MB9213.eurprd04.prod.outlook.com (2603:10a6:150:28::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 07:27:07 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 07:27:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0a9fa63-c20d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650612432;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=el4Ufmdp+XmvwbZ9wycrdfprh0xDhjlQOVswJzgLjHk=;
	b=iFtkSBwS727HwlPgVGqxiVBADatxT7XyV9pC8ux8QhzKxplhRjgspC5G4i+GFq+K2YyT1q
	1lrGMV9UG7JGQhbP0lP3N9+XNRWIgXJqBNmrmGvcsmynf+pfTM0XRQa3GVdgUrO2is8QMv
	R0D/iPFpQlSz5XVsJTcPafvxtUU9D1M=
X-MC-Unique: 2Is5hBucOPCENRDt3XpBvQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m0UKiZGL8qM69gus9pNiLeMIiY0JhpFw16Hdy98A/mgV+1IQodwYZuBrla8SjgwyuTy98MezwOJcqsMhcl4D+Ex6wMPdPIMFK8djhI2AOcZxh9PRuwcJ2/QPvOzwA8uJkwV971IfAYfDvQGpXgwHto35m5EcH3zY8t4L5BT8VHi0p8tYEMLYeb/gti5ha34jkCbpIxG/q43Ce1BlogS+zrr/CKQYI7idRmX69ip+VUY3q2nZRKFgA+HoH0N/nli/kJsJbpGslKEXB1Vjj92H3F1nSVSpVVo0doyCerToZuS8Vo0JfSrrgiohp594vK/OXYUUED0oXJipLpI4y7laVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FrmLkCznumhuP0eFOrcZnX3e9fgH0jxpTDlPyTGPLhI=;
 b=U5NGyqLWdQkj3+mEoHD/n6Xbx3i37xps66u9N5HoItNC0vAzigCz/sQMAoJeE8Wn/v6ls4xfkx/3F+nqu6XolkoQjbzwRjPyxSSqM9PEdeWu6XisAGnXKJG/SxZdKDncsJLbJwsp8uirxo+AqIQ0aRljDRn/ji30W/HWS/jSIfe8gbs0HGKg+OPaWLrlzS4JEH6s+u53hVYiimvL1JN0S+egtJnqN8lpXP8sahRb0bghoJDxmZTGusN5uA311OmYItB0tbZSsyia7F6jyn/CPIXCaKFxOLgC/87s02L4u2ttTrkC0kjH1UdKK7ZLeB17rn+XI7dZipvRAXSDYDIiMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <434a93ea-d311-a980-1efd-507937bc0010@suse.com>
Date: Fri, 22 Apr 2022 09:27:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v5 1/6] x86/debugger: Remove debugger_trap_entry()
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Bobby Eshleman <bobby.eshleman@gmail.com>,
 Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-2-andrew.cooper3@citrix.com>
 <57858c7b-019a-2888-42ae-7ce9a7c88cc0@suse.com>
 <b32d8ab5-dcca-971c-39ed-032aba0dcea2@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b32d8ab5-dcca-971c-39ed-032aba0dcea2@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0125.eurprd04.prod.outlook.com
 (2603:10a6:20b:531::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4bdf61a1-448c-43bc-135d-08da243181d1
X-MS-TrafficTypeDiagnostic: GV1PR04MB9213:EE_
X-Microsoft-Antispam-PRVS:
	<GV1PR04MB9213C36CC448E36D6B2A99A0B3F79@GV1PR04MB9213.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	X/xMLZfWcWhHtLQbg7UE59RcX/82k/nY28iyQYK+dzenQXRAZrR6GsbObpzvlt6nFDkXrQgtvZByroil72NMOiOyPFSmMZUwuRvfrF94fQnALNq6EjvByA/3cQSMUnuU75hrrClgpSlHjQDoxmXr/KMp+j1fIpExRcFUhMLahZsJwFPB9Y8CSiWzK+kPyBSFITiipx5K664VA5E92BGZYYhnLzhKwdxupwC1ybH/jseCLRjqohlyHtFAgZuXS7BsxXxVG4wSVrEbRVEJTNh9+E4yJadfmuHdO1NEK8VfreTXrr9tXmWAoAgcn2FmHelfNknsOEgx5+AmOpd5yDq/T/kcYEjP4rvgXYf7Zdg2M2eAUExs2R+Oq6O8JLrXegc72B99YXBkg5MVegg6kgXlA07bbcsb9twrxlQWee7KaHQwzpYsIlhGFc6EiuACKYW6k2Zzt56ipjvA0cc9R37CAjdayDHuxj7U8kbgHNkR9vB7pJ9PHGW4r5W9bUnRZx69WBw9f6DlH2XwslKs66L/VMyWemx9Hks21lnGWfDyAae3jTn0GqaigXggRRpjPrTquvvFFgXiLif2yYLblpZBBRCoF8Va5WzV9aWdAfp5mqTXUBBjLn6U/guEJIqp02rRxVyZ1FgFxkGKPNJe1ePj/ng6KDqL+2x6woPaoX37dO4VbELiZuzLCCyEq3C2s2zDP/rV+Hpd/IJKGqnPO91OdqtBtF1Z5IA5d8rxvebC4pkj7+yp4fVPP2TU4vHB3MCm
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(8936002)(6506007)(86362001)(31696002)(66556008)(66946007)(4326008)(2906002)(53546011)(6512007)(8676002)(6486002)(31686004)(316002)(6916009)(54906003)(26005)(36756003)(186003)(2616005)(5660300002)(38100700002)(508600001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Huv1dvtVYgbVGs3bY5mSwBARZAIoqdf3h4Kjm2Oom5px3YOQ5/GIQoGYwc4c?=
 =?us-ascii?Q?iM9IAhcGPN5RbUz4KfY+vNgnthDFuGpYxpOe3i3l2XRBmQS2KgAJqtB+7sK+?=
 =?us-ascii?Q?eELgQw2oBWZvDHPMdTJ7WvsJOSkSQIbnHLfbccdUxKbTCdWuP/dWKdqa1Qw+?=
 =?us-ascii?Q?SHazwXUa318R3bUglRzLEkaW2h2aTKh0WshqDFGwXa4k+YS8lz5Mi39pf5xT?=
 =?us-ascii?Q?6plWg5vJsIR6x7dABCDSoJX/Y8VujoHLuzk0SVuoeAXP2rrjgBmkAUI7MRl9?=
 =?us-ascii?Q?8isbxYzZHIc/huAXvLsQNXrw9EpgIu9ZaJPdzK7bydXAZGTQqaqMg+goApNv?=
 =?us-ascii?Q?IcswhLjZLuR9ckCBi3VJy/NqMJzIqkeDryDxfX9uwqppojfkIh6c3/Ns6UE7?=
 =?us-ascii?Q?dZxR4sVRRmUH8JiUoqyTxkjA27JsPn3cQGBjDajW5tpbHrY7biH5QTq3BUCh?=
 =?us-ascii?Q?u+UmHK2ow/AIGkWKDaNgGcelN0qLH3ERaWJ2tNPU4bzZeFpUgXLUlxWoGRT1?=
 =?us-ascii?Q?yWugGBvxjd9HNOSdVOxC4iI3tV/vC9XyiIeb4jZxnQ0JarRwPuxaXL/1d1Sl?=
 =?us-ascii?Q?rQyzPJSwsYToj1ldhUW1lSH3/FAkGwafeF8QNVSET56ZX2wCpCvKmVCnW+lp?=
 =?us-ascii?Q?GPXo81VN26mMEexkZZHU9g6OPKcqVATL08n9d7tN1TV9fC3DvlhH7Avsl+pY?=
 =?us-ascii?Q?QNGGEn9jmkugT5NcJl7trzV39CAiTdBWcwCMqdnjZVCcBL/1Fnv4PEqX2TWT?=
 =?us-ascii?Q?fvDh9MdPc8OaXS/5Eub9tE86aHhjd4etPxSwNHINIXpn/uzG2Pz4UyioIlxT?=
 =?us-ascii?Q?DkDYVQtY3LSKl16D7piufoVqYWex+Q8vfZO9BUSQbI2GFaDWjKsEC0eJJV1L?=
 =?us-ascii?Q?6lKYsz6t019IwDnBrOTXgiSSa9uWB3+uMGBkkjC2VV3HndNU4YjBOIcpB+Um?=
 =?us-ascii?Q?eTpVP48jBoMjFkTh6cvcpO+N2kGHsLwF989ApQnfYRRO26o895igGJzG6z+f?=
 =?us-ascii?Q?Cv2szLBW4g4ozoiszKA/zOMZrBLEfJT84KOloIf8VlYVG5DXsO82xjkvfgxq?=
 =?us-ascii?Q?S7cJTPLjBYkkmAVQu8s27r7di08plktUFePF6e3ccVN/8f083S59YtLjUNYC?=
 =?us-ascii?Q?1XMMevZ3MdD/eQb8z4ZO8CJGST9S2hmiEgH+1DL5kOHsNUiM8ZKH7GeS0QHc?=
 =?us-ascii?Q?2XT36cL9y5SxLyf4JXtVtuKPVmlA7tXZdQwucexfVF/XXEceht3a8qzePyme?=
 =?us-ascii?Q?+uIHi9gQtmtYFwxLgrjcJ+UuOuPBLnyIrRo+setMg1rEpepo9QHN1mEyrpX2?=
 =?us-ascii?Q?ZKQ/KZjY7iqTogrEwv5V0LKAE5ZjOyx593OYy6k8wxN8NXf1avcPZn7AF9ML?=
 =?us-ascii?Q?YAEpSoyPW08sSg3dI5ODklrDnetmiKQUzHV69Pf6buxU+VI/Cqst7YcZltDH?=
 =?us-ascii?Q?feAjBwOC/J9fXO2TEsmwDeVQJ9Z4NBFtf/iH0Mpey9+uhwSvlrIdFz+4TjS+?=
 =?us-ascii?Q?YF50HAh/ovTUoLgVI4hQbMyVj5J5Y8tO8lWds3DfYhXJ30vaHEJolfgME6VA?=
 =?us-ascii?Q?krZH4k1TKh1057I4BQdvzP+ejF8JB9r/sY5cr2vyznSAwfe7vLM1BvHdUe49?=
 =?us-ascii?Q?Hf6XqJoRRXJQ1iUBi4FqpDbSbw4nHZGAf6b/2icQvd+D2Y3K/j8VoND2u0wX?=
 =?us-ascii?Q?mtEsnZuuzhUSs1mKsDp9L7eK3kmVrvdE7Sg5FnJjJ0EjmlbwO4KfxAI080dn?=
 =?us-ascii?Q?9qVwApW13A=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bdf61a1-448c-43bc-135d-08da243181d1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 07:27:07.8025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yUiNbzc5FlU+NsJ4XB8GbtxwhrH+MB5QCO97PpVUYMKgiG4t/xdAeyvUXxJHy5P6ZiUl+3MJG1tN3nNFkIAzVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9213

On 21.04.2022 19:23, Andrew Cooper wrote:
> On 21/04/2022 14:02, Jan Beulich wrote:
>> On 20.04.2022 16:13, Andrew Cooper wrote:
>>> From: Bobby Eshleman <bobby.eshleman@gmail.com>
>>>
>>> debugger_trap_entry() is unrelated to the other contents of debugger.h.=
  It is
>>> a no-op for everything other than #DB/#BP, and for those it invokes gue=
st
>>> debugging (CONFIG_GDBSX) not host debugging (CONFIG_CRASH_DEBUG).
>>>
>>> Furthermore, the description of how to use debugger_trap_entry() is at =
best,
>>> stale.  It is not called from all exception paths,
>> But on almost all (before this change) - the exception looks to be
>> #NM.
>>
>>> and because the developer
>>> is forced to modify Xen to perform debugging, editing debugger_trap_ent=
ry() is
>>> not the way one would efficiently go about diagnosing the problem.
>> Shouldn't it be the remote end to request which exceptions it wants
>> to be notified of? If so, removing the hook invocation isn't very
>> helpful.
>=20
> That's not part of the gdb remote protocol.
>=20
> In normal conditions, gdb gets to see see anything which manifests as a
> signal.=C2=A0 It does not get to see anything which is resolved by the ke=
rnel
> behind the scenes.=C2=A0 #NM you've already identified, and most #PF's wo=
uld
> count too.=C2=A0 Back in the 32bit days, Xen-induced #GP/#SS's for non-4G
> segments would count too.
>=20
> But in addition to filtering Xen's idea of "fixing up behind the
> scenes", you also need to Xen to understand when to skip notifications
> based on what a PV guest kernel can fix up, and this is getting even
> further out of gdb's comfort zone.
>=20
> debugger_trap_entry() is empty (WRT gdbstub) specifically because it's
> description is nonsense in any practical debugging scenario.=C2=A0 And le=
ts
> not start on the fact that the lack of ability to invoke
> pv_event_inject() means that any fault from userspace will livelock
> under debugging.
>=20
> Deleting it is absolutely the right way forward, because a theoretical
> future with someone wiring this up would have to start again from scratch=
.
>=20
> Not that qualifies as a good reason in isolation, do_trap() contains
> unreachable logic because the compiler can't figure out that #DB/#BP are
> handled via alternative paths, and the gdbsx logic is dead.

The patch description could certainly do with expanding some along these
lines.

Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 07:58:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 07:58:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310720.527654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhoBm-0000s9-1J; Fri, 22 Apr 2022 07:58:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310720.527654; Fri, 22 Apr 2022 07:58:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhoBl-0000s2-T0; Fri, 22 Apr 2022 07:58:49 +0000
Received: by outflank-mailman (input) for mailman id 310720;
 Fri, 22 Apr 2022 07:58:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ZwqJ=VA=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nhoBk-0000rw-W5
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 07:58:49 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0602.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::602])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 08ee227a-c212-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 09:58:46 +0200 (CEST)
Received: from AS9PR06CA0095.eurprd06.prod.outlook.com (2603:10a6:20b:465::28)
 by PR3PR08MB5804.eurprd08.prod.outlook.com (2603:10a6:102:83::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 07:58:43 +0000
Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:465:cafe::69) by AS9PR06CA0095.outlook.office365.com
 (2603:10a6:20b:465::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Fri, 22 Apr 2022 07:58:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Fri, 22 Apr 2022 07:58:42 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Fri, 22 Apr 2022 07:58:42 +0000
Received: from e9d375c9ce83.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1EB8A40D-86C3-45C7-A610-FA46F9FCBB68.1; 
 Fri, 22 Apr 2022 07:58:32 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9d375c9ce83.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 22 Apr 2022 07:58:32 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM0PR08MB4354.eurprd08.prod.outlook.com (2603:10a6:208:13e::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 07:58:28 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5164.025; Fri, 22 Apr 2022
 07:58:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08ee227a-c212-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RGoEw0Tawy9jbujIWjLmcgIRBy1QmtTT0unoL+l9Xt8=;
 b=uKAcE1N7pY+l75NQfAiKfPGF0yBr0eQ+9GgaOXJCSqJbANiFdTvu6KYaAZplynqf0czvogOyn0wHaxRj8diQTCy+jSiUObuUgY8gO2Ppxt0qQMRwu+gYPSOBUZPNkoqE2Xg+tYteBGsNM0Cem18wlwWj1i6DuHCBz+saNteRzK0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5c5b3694673e0c7f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i/HUWp3+65/U1W7+cBH9vFDiavwW6yEFm3PZReKSpbqCaEBQPqbpBw5ssNOI6OAxw76HGoCRUlapnga41RHirDXjiudTETIEDmE1V2C0B2E9mCXYTKRwKVyFTb6Q/tj49bTp+BP+ltBXenxGtpc7U+s/WSpKStyWNGrazk76SNXxltKe0P67db/sWLA2rrjFI1ErRrz4XE/Kmc+fcwgKnpuqvXaIUo6xZPiBKA3/n9Ppth0np3O7cyOTXvQvN5RuDolV03oj+KXRWLut0qvX23Hi/H9G7OD4qsX8KJkwGZfx1deZYuGTNgVShBIfWRzUexhGrTbuo+KGUGJp1KpHxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RGoEw0Tawy9jbujIWjLmcgIRBy1QmtTT0unoL+l9Xt8=;
 b=Pz+YQWM1qulGLZOjb7ucSTOj5xOGe1Z5Ev2B8VPreuf4Htt2RW3dDPmZcs+cGcr4ieRkQ2Ww+1NslKjlB9K85tPJv7mwzhCJe+8vYMhEkzo8ViARideMn3iV5s1OzFMS56UP/XLeqL8bTvmxjxRXvavpFFm96tamQ2QwaAsrcu5QmKCm32EBPhDbTXwuvmuivHaMxfayionqk7vkdOJbw/WTvjF227VMJPHw0WPItrhbJcWyJOHWKwaeJCKbqvKgrF1yGVtNX3wE6U0GtV/E290lakZ23Z3/Ri1KqtYRgNamn329Z6t3c23MZtbNhO7F/iVB+xqpxSDHqsp0in6EJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RGoEw0Tawy9jbujIWjLmcgIRBy1QmtTT0unoL+l9Xt8=;
 b=uKAcE1N7pY+l75NQfAiKfPGF0yBr0eQ+9GgaOXJCSqJbANiFdTvu6KYaAZplynqf0czvogOyn0wHaxRj8diQTCy+jSiUObuUgY8gO2Ppxt0qQMRwu+gYPSOBUZPNkoqE2Xg+tYteBGsNM0Cem18wlwWj1i6DuHCBz+saNteRzK0=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <cdfe5b2c-3973-03d4-8fb2-dc8eab73b8b0@arm.com>
Date: Fri, 22 Apr 2022 15:58:21 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftB
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Penny Zheng <Penny.Zheng@arm.com>
References: <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SI2P153CA0014.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::6)
 To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 735576b7-bfa1-42e4-580f-08da2435eb63
X-MS-TrafficTypeDiagnostic:
	AM0PR08MB4354:EE_|VE1EUR03FT036:EE_|PR3PR08MB5804:EE_
X-Microsoft-Antispam-PRVS:
	<PR3PR08MB5804349FC23102A6A2209A779EF79@PR3PR08MB5804.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 BtiQazVA1tGhX7xgG2StrO4MjGyS7cjnPJqCGJ9ARd+CLo4NhRFqehdB+Jmjhy5hpjEeS++VmWd0Me26czLlO8sibIDmStRm1MsT6ViVYeFV9LBbJBDZiVbG6AdQdN4Z5GJTLFqAeh2vVz/Yq6n4AgH7VzY77vLZUZp+ClJjzcD1QFp8AqJjbwzr0504rrwI5ZZNSH3r5ExvXOp8yzW1jkx5QGuj3YlqUzD6ve7hWjNjbkEnjgIPNGqO9Ns63UCbPSbB9RDYzM5+/PA9dAhjJ8vzJpnGI+Tsp6OFDPweGT2OL3vbVY5uL21eV1+sAWRsSbtN0WCdGfhowYWIkIbwdBqisCraFYrF5dgxRgjHmj+QfDeNfrEVS/om3w9R/Ro4m3yGQ2Fh6+aUWWKX0G/oM3kyVyK/5YcVuBErObJF4j9QYnCShEVXrJhjYKATPWTgdPmng/zjkupUgvy6zHVy7l5/0kxZT99Z3/4f6sQixvNkzdglMI+LyDiAF0H0+1Q5+nyZz4HbUB8zEb9jr56X+4KBIxelpFz8H4UbVmuIq3LqOn/j4rWJE66No6/wCGmaSWHl/fOp4hfkkDcTk86h5aVflLq3dqH+CPD59/eBPPl+vjmDyCfH7GKcMrHWwviatPIFQfkYymngu502K26JueyqcxPy2ZYxU1ScXtEmLG7t5VES0e295yWw/ZfILDO1Adhl9R3pJaq/W+R6NMiMkb1bB187NMRfzdCNHZ6iq4vYi0jLF5w0CE4Bw+GGkbg3yYJ4LmdfLKnML74vlzsgwVjyIvV08vZ5V0wgi++BbduyzUE9mw7hZd0jCahwKXIXSuUhSS+EBIDwIEBBtpW0eB3sFBDj9n6XPq5bppqiwWk=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(53546011)(508600001)(5660300002)(31686004)(66946007)(66476007)(66556008)(4326008)(8936002)(36756003)(6666004)(6506007)(6512007)(30864003)(8676002)(86362001)(31696002)(6916009)(316002)(6486002)(966005)(83380400001)(186003)(2616005)(38100700002)(54906003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4354
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1c496621-7430-4ace-925c-08da2435e291
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/KSGs8lQGERa8Ls9HIlz1pehu5ufoFo1YMOorW6hgUW3YL0Rn4+ivQqTGLIywtQpW9OkPMZFFwiTaTu6+grb3BCCQJSoGUBZBDRYq3FsWtkO8xGcM8HGTU9qT+MrpYKNM5A3V65sdVTmb/l+Kz9M0ZsbeQnxkYNRvyOT5gRgS+dq8mWssDXWQODl1LrwYiKx0z93amaF/YL9iMElpMvA7mNOHenc9kJvTui/aenJGxOaCQyV5LrgEFoR5wqlnvZR35ysoWj735GJJn7S21Y/4EXSPOoJQbaXiCL8OnRzAqIBAtAxyF3f5/ajSg1M5e1C6SWWBQr4FY/cxqJaO5Y+n6W8NyF10rTDI2FMrHaowDe8W1Ct0/0Lij/gNgkWXBgCmNt1k71RRegPc3U4ra06vIRRpzdNZnKPW639DtwCaYXJMgengnp6Yzek9tUFpEUVLVZXPjW5PrNcmaHb/1TlC5a9xuCvXae+SPf4OmjmtK6eQkxLIi0Z1oFm/mHWhMzsEZAYu9Gbt4nFc6SY9ZGtC/Fg5/I0jczeFZkxjdKPMJyg2tcxJ6W6Bnfv4i469R0uzMV40osmYnXavl2hfIGXAa6Sqckgxi+YureZpi1iUeT2ysk8q98UrTqeiK5xD3ZakFDSudPyg3A4cP9S2/qWonYwbuKMnH/HIq2th6Kbcqvy+CP1xfKV5FFT/4znNAiuIQMXxrN7GPc/XKPnfGujOyYFjcyqdvJZFDxX1KoQbSx3Z3ykMOfshyPrq7zpj4OK1zEnvBEtWF4bylWSxDr1UIOyEsXw5eL/cjGi+B2tI+REOVJoazdsJl8aZAWRZYD+hOjnM2P/deNA8M7TOCMg3A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(86362001)(31686004)(2616005)(36860700001)(30864003)(83380400001)(5660300002)(6486002)(31696002)(4326008)(8676002)(6862004)(70586007)(70206006)(36756003)(8936002)(316002)(54906003)(6512007)(966005)(26005)(336012)(2906002)(82310400005)(47076005)(508600001)(186003)(40460700003)(81166007)(356005)(6666004)(6506007)(53546011)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 07:58:42.5807
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 735576b7-bfa1-42e4-580f-08da2435eb63
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5804

Hi Stefano,

Reply for non-Eventchannel comments:

On 2022/4/15 8:41, Stefano Stabellini wrote:
> On Fri, 25 Mar 2022, Wei Chen wrote:
>> # Proposal for Porting Xen to Armv8-R64
>>
...
>> ## 2. Proposed changes of Xen
>> ### **2.1. Changes of build system:**
>>
>> - ***Introduce new Kconfig options for Armv8-R64***:
>>    Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not
>>    expect one Xen binary to run on all machines. Xen images are not common
>>    across Armv8-R64 platforms. Xen must be re-built for different Armv8-R64
>>    platforms. Because these platforms may have different memory layout and
>>    link address.
>>      - `ARM64_V8R`:
>>        This option enables Armv8-R profile for Arm64. Enabling this option
>>        results in selecting MPU. This Kconfig option is used to gate some
>>        Armv8-R64 specific code except MPU code, like some code for Armv8-R64
>>        only system ID registers access.
>>
>>      - `ARM_MPU`
>>        This option enables MPU on Armv8-R architecture. Enabling this option
>>        results in disabling MMU. This Kconfig option is used to gate some
>>        ARM_MPU specific code. Once when this Kconfig option has been enabled,
>>        the MMU relate code will not be built for Armv8-R64. The reason why
>>        not depends on runtime detection to select MMU or MPU is that, we don't
>>        think we can use one image for both Armv8-R64 and Armv8-A64. Another
>>        reason that we separate MPU and V8R in provision to allow to support MPU
>>        on 32bit Arm one day.
>>
>>    ***Try to use `if ( IS_ENABLED(CONFIG_ARMXXXX) )` instead of spreading***
>>    ***`#ifdef CONFIG_ARMXXXX` everywhere, if it is possible.***
>>
>> - ***About Xen start address for Armv8-R64***:
>>    On Armv8-A, Xen has a fixed virtual start address (link address too) on all
>>    Armv8-A platforms. In an MMU based system, Xen can map its loaded address
>>    to this virtual start address. On Armv8-A platforms, the Xen start address
>>    does not need to be configurable. But on Armv8-R platforms, they don't have
>>    MMU to map loaded address to a fixed virtual address. And different platforms
>>    will have very different address space layout, so it's impossible for Xen to
>>    specify a fixed physical address for all Armv8-R platforms' start address.
>>
>>    - `XEN_START_ADDRESS`
>>      This option allows to set the custom address at which Xen will be
>>      linked. This address must be aligned to a page size. Xen's run-time
>>      addresses are the same as the link time addresses.
>>      ***Notes: Fixed link address means the Xen binary could not be***
>>      ***relocated by EFI loader. So in current stage, Xen could not***
>>      ***be launched as an EFI application on Armv8-R64.(TODO#3.3)***
>>
>>      - Provided by platform files.
>>        We can reuse the existed arm/platforms store platform specific files.
>>        And `XEN_START_ADDRESS` is one kind of platform specific information.
>>        So we can use platform file to define default `XEN_START_ADDRESS` for
>>        each platform.
>>
>>      - Provided by Kconfig.
>>        This option can be an independent or a supplymental option. Users can
>>        define a customized `XEN_START_ADDRESS` to override the default value
>>        in platform's file.
>>
>>      - Generated from device tree by build scripts (optional)
>>        Vendors who want to enable Xen on their Armv8-R platforms, they can
>>        use some tools/scripts to parse their boards device tree to generate
>>        the basic platform information. These tools/scripts do not necessarily
>>        need to be integrated in Xen, but Xen can give some recommended
>>        configuration. For example, Xen can recommend Armv8-R platforms to use
>>        lowest ram start address + 2MB as the default Xen start address.
>>        The generated platform files can be placed to arm/platforms for
>>        maintenance.
>>
>>      - Enable Xen PIC/PIE (optional)
>>        We have mentioned about PIC/PIE in section 1.2. With PIC/PIE support,
>>        Xen can run from everywhere it has been loaded. But it's rare to use
>>        PIC/PIE on a real-time system (code size, more memory access). So a
>>        partial PIC/PIE image maybe better (see 3. TODO section). But partial
>>        PIC/PIE image may not solve this Xen start address issue.
> 
> I like the description of the XEN_START_ADDRESS problem and solutions.
> 
> For the initial implementation, a platform file is fine. We need to
> start easy.
> 
> Afterwards, I think it would be far better to switch to a script that
> automatically generates XEN_START_ADDRESS from the host device tree.
> Also, if we provide a way to customize the start address via Kconfig,
> then the script that reads the device tree could simply output the right
> CONFIG_* option for Xen to build. It wouldn't even have to generate an
> header file.
> 

Ok,I will update the proposal to create two steps for XEN_START_ADDRESS:
stage 1: Use the platform files for XEN_START_ADDRESS. If no platform
          has been selected, provide Kconfig option for users to do
          customization.
stage 2: Try to switch to use scripts that can automatically generate
          XEN_START_ADDRESS from the host device tree. But still keep
          Kconfig customization option.

And for the PIC/PIE option,I will move it to TODO list so that we
have records for future discussions.Becuase this feature for an
MPU system, its priority is not very high.

> 
>> - ***About MPU initialization before parsing device tree***:
>>        Before Xen can start parsing information from device tree and use
>>        this information to setup MPU, Xen need an initial MPU state. This
>>        is because:
>>        1. More deterministic: Arm MPU supports background regions, if we
>>           don't configure the MPU regions and don't enable MPU. The default
>>           MPU background attributes will take effect. The default background
>>           attributes are `IMPLEMENTATION DEFINED`. That means all RAM regions
>>           may be configured to device memory and RWX. Random values in RAM or
>>           maliciously embedded data can be exploited.
>>        2. More compatible: On some Armv8-R64 platforms, if MPU is disabled,
>>           the `dc zva` instruction will make the system halt (This is one
>>           side effect of MPU background attributes, the RAM has been configured
>>           as device memory). And this instruction will be embedded in some
>>           built-in functions, like `memory set`. If we use `-ddont_use_dc` to
>>           rebuild GCC, the built-in functions will not contain `dc zva`.
>>           However, it is obviously unlikely that we will be able to recompile
>>           all GCC for ARMv8-R64.
>>
>>      - Reuse `XEN_START_ADDRESS`
>>        In the very beginning of Xen boot, Xen just need to cover a limited
>>        memory range and very few devices (actually only UART device). So we
>>        can use two MPU regions to map:
>>        1. `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or.
>>           `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_size`as
>>           normal memory.
>>        2. `UART` MMIO region base to `UART` MMIO region end to device memory.
>>        These two are enough to support Xen run in boot time. And we don't need
>>        to provide additional platform information for initial normal memory
>>        and device memory regions. In current PoC we have used this option
>>        for implementation, and it's the same as Armv8-A.
>>
>>      - Additional platform information for initial MPU state
>>        Introduce some macros to allow users to set initial normal
>>        memory regions:
>>        `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END`
>>        and device memory:
>>        `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END`
>>        These macros are the same platform specific information as
>>        `XEN_START_ADDRESS`, so the options#1/#2/#3 of generating
>>        `XEN_START_ADDRESS` also can be applied to these macros.
>>        ***From our current PoC work, we think these macros may***
>>        ***not be necessary. But we still place them here to see***
>>        ***whether the community will have some different scenarios***
>>        ***that we haven't considered.***
> 
> I think it is fine for now. And their values could be automatically
> generated by the same script that will automatically generate
> XEN_START_ADDRESS from the host device tree.
> 

Ok, we will keep current PoC "Reuse `XEN_START_ADDRESS`" for
day1 patch. We will update the proposal to address it. And place
script generatation in stage2.

> 
>> - ***Define new system registers for compiliers***:
>>    Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
>>    specific system registers. As Armv8-R64 only have secure state, so
>>    at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
>>    first GCC version that supports Armv8.4 is GCC 8.1. In addition to
>>    these, PMSA of Armv8-R64 introduced lots of MPU related system registers:
>>    `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
>>    `MPUIR_ELx`. But the first GCC version to support these system registers
>>    is GCC 11. So we have two ways to make compilers to work properly with
>>    these system registers.
>>    1. Bump GCC version to GCC 11.
>>       The pros of this method is that, we don't need to encode these
>>       system registers in macros by ourselves. But the cons are that,
>>       we have to update Makefiles to support GCC 11 for Armv8-R64.
>>       1.1. Check the GCC version 11 for Armv8-R64.
>>       1.2. Add march=armv8r to CFLAGS for Armv8-R64.
>>       1.3. Solve the confliction of march=armv8r and mcpu=generic
>>      These changes will affect common Makefiles, not only Arm Makefiles.
>>      And GCC 11 is new, lots of toolchains and Distro haven't supported it.
>>
>>    2. Encode new system registers in macros ***(preferred)***
>>          ```
>>          /* Virtualization Secure Translation Control Register */
>>          #define VSTCR_EL2  S3_4_C2_C6_2
>>          /* Virtualization System Control Register */
>>          #define VSCTLR_EL2 S3_4_C2_C0_0
>>          /* EL1 MPU Protection Region Base Address Register encode */
>>          #define PRBAR_EL1  S3_0_C6_C8_0
>>          ...
>>          /* EL2 MPU Protection Region Base Address Register encode */
>>          #define PRBAR_EL2  S3_4_C6_C8_0
>>          ...
>>          ```
>>       If we encode all above system registers, we don't need to bump GCC
>>       version. And the common CFLAGS Xen is using still can be applied to
>>       Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS.
>>       ***Notes:***
>>       ***Armv8-R AArch64 supports the A64 ISA instruction set with***
>>       ***some modifications:***
>>       ***Redefines DMB, DSB, and adds an DFB. But actually, the***
>>       ***encodings of DMB and DSB are still the same with A64.***
>>       ***And DFB is an alias of DSB #12. In this case, we think***
>>       ***we don't need a new architecture specific flag to***
>>       ***generate new instructions for Armv8-R.***
> 
> I think that for the initial implementation either way is fine. I agree
> that macros would be better than requiring GCC 11.
> 

Ok. We will use macros in day1. We can have a standalone patch set
to bump GCC version in the future. Based on some of the attempts we've
made, it will affect some makefile scripts of common and other
architectures.


> 
>> ### **2.2. Changes of the initialization process**
>>
>> **A sample device tree of memory layout restriction**:
>> ```
>> chosen {
>>      ...
>>      /*
>>       * Define a section to place boot modules,
>>       * all boot modules must be placed in this section.
>>       */
>>      mpu,boot-module-section = <0x10000000 0x10000000>;
>>      /*
>>       * Define a section to cover all guest RAM. All guest RAM must be located
>>       * within this section. The pros is that, in best case, we can only have
>>       * one MPU protection region to map all guest RAM for Xen.
>>       */
>>      mpu,guest-memory-section = <0x20000000 0x30000000>;
>>      /*
>>       * Define a memory section that can cover all device memory that
>>       * will be used in Xen.
>>       */
>>      mpu,device-memory-section = <0x80000000 0x7ffff000>;
>>      /* Define a section for Xen heap */
>>      xen,static-mem = <0x50000000 0x20000000>;
>>
>>      domU1 {
>>          ...
>>          #xen,static-mem-address-cells = <0x01>;
>>          #xen,static-mem-size-cells = <0x01>;
>>          /* Statically allocated guest memory, within mpu,guest-memory-section */
>>          xen,static-mem = <0x30000000 0x1f000000>;
>>
>>          module@11000000 {
>>              compatible = "multiboot,kernel\0multiboot,module";
>>              /* Boot module address, within mpu,boot-module-section */
>>              reg = <0x11000000 0x3000000>;
>>              ...
>>          };
>>
>>          module@10FF0000 {
>>                  compatible = "multiboot,device-tree\0multiboot,module";
>>                  /* Boot module address, within mpu,boot-module-section */
>>                  reg = <0x10ff0000 0x10000>;
>>                  ...
>>          };
>>      };
>> };
>> ```
>> It's little hard for users to compose such a device tree by hand. Based
>> on the discussion of Draft-A, Xen community suggested users to use some
>> tools like [imagebuilder](https://gitlab.com/ViryaOS/imagebuilder/-/blob/master/scripts/uboot-script-gen#L390) to generate the above device tree properties.
>> Please goto TODO#3.3 section to get more details of this suggestion.
> 
> Yes, I think we'll need an ImageBuilder script to populate these entries
> automatically. With George's help, I moved ImageBuilder to Xen Project.
> This is the new repository: https://gitlab.com/xen-project/imagebuilder
> 
> The script to generate mpu,boot-module-section and the other mpu
> addresses could be the same ImageBuilder script that generates also
> XEN_START_ADDRESS.
> 

That's great, I will update the link in proposal.

> 
>> ### **2.4. Changes of memory management**
>> Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to
>> decouple Xen from VMSA. And give Xen the ablity to manage memory in PMSA.
...          ```
>>
>> ### **2.5. Changes of guest management**
...
>>
>> ### **2.6. Changes of exception trap**
...
>>
>> ### **2.5. Changes of device driver**
...
>>
>> ## 3. TODO
...
>>
>> ### 3.1. Alternative framework support
...
>>
>> ### 3.2. Xen Event Channel Support
...
>> ### 3.3. Xen Partial PIC/PIE
...
>>
>> ### 3.4. A tool to generate Armv8-R Xen device tree
>> 1. Use a tool to generate above device tree property.
>>     This tool will have some similar inputs as below:
>>     ---
>>     DEVICE_TREE="fvp_baremetal.dtb"
>>     XEN="4.16-2022.1/xen"
>>
>>     NUM_DOMUS=1
>>     DOMU_KERNEL[0]="4.16-2022.1/Image-domU"
>>     DOMU_RAMDISK[0]="4.16-2022.1/initrd.cpio"
>>     DOMU_PASSTHROUGH_DTB[0]="4.16-2022.1/passthrough-example-dev.dtb"
>>     DOMU_RAM_BASE[0]=0x30000000
>>     DOMU_RAM_SIZE[0]=0x1f000000
>>     ---
>>     Using above inputs, the tool can generate a device tree similar as
>>     we have described in sample.
>>
>>     - `mpu,guest-memory-section`:
>>     This section will cover all guests' RAM (`xen,static-mem` defined regions
>>     in all DomU nodes). All guest RAM must be located within this section.
>>     In the best case, we can only have one MPU protection region to map all
>>     guests' RAM for Xen.
>>
>>     If users set `DOMU_RAM_BASE` and `DOMU_RAM_SIZE`, these will be converted
>>     to the base and size of `xen,static-mem`. This tool will scan all
>>     `xen, static-mem` in DomU nodes to determin the base and size of
>>     `mpu,guest-memory-section`. If there is any other kind of memory usage
>>     has been detected in this section, this tool can report an error.
>>     Except build time check, Xen also need to do runtime check to prevent a
>>     bad device tree that generated by malicious tools.
>>
>>     If users set `DOMU_RAM_SIZE` only, this will be converted to the size of
>>     `xen,static-mem` only. Xen will allocate the guest memory in runtime, but
>>     not from Xen heap. `mpu,guest-memory-section` will be caculated in runtime
>>     too. The property in device tree doesn't need or will be ignored by Xen.
> 
> I am fine with this. You should also know that there was a recent
> discussion about adding something like:
> 
> # address size address size ...
> DOMU_STATIC_MEM_RANGES[0]="0xe000000 0x1000000 0xa0000000 0x30000000"
> 
> to the ImageBuilder config file.
> 

Thanks for this update : )

> 
>>     - `mpu,boot-module-section`:
>>     This section will be used to store the boot modules like DOMU_KERNEL,
>>     DOMU_RAMDISK, and DOMU_PASSTHROUGH_DTB. Xen keeps all boot modules in
>>     this section to meet the requirement of DomU restart on Armv8-R. In
>>     current stage, we don't have a privilege domain like Dom0 that can
>>     access filesystem to reload DomU images.
>>
>>     And in current Xen code, the base and size are mandatory for boot modules
>>     If users don't specify the base of each boot module, the tool will
>>     allocte a base for each module. And the tool will generate the
>>     `mpu,boot-module-section` region, when it finishs boot module memory
>>     allocation.
>>
>>     Users also can specify the base and size of each boot module, these will
>>     be converted to the base and size of module's `reg` directly. The tool
>>     will scan all modules `reg` in DomU nodes to generate the base and size of
>>     `mpu,boot-module-section`. If there is any kind of other memory usage
>>     has been detected in this section, this tool can report an error.
>>     Except build time check, Xen also need to do runtime check to prevent a
>>     bad device tree that generated by malicious tools.
> 
> Xen should always check for the validity of its input. However I should
> point out that there is no "malicious tool" in this picture because a
> malicious entity with access to the tool would also have access to Xen
> directly, so they might as well replace the Xen binary.
> 

Ok, I will drop the "malicious tools". But I think the "bug tools" still
can be possible : )

> 
>>     - `mpu,device-memory-section`:
>>     This section will cover all device memory that will be used in Xen. Like
>>     `UART`, `GIC`, `SMMU` and other devices. We haven't considered multiple
>>     `mpu,device-memory-section` scenarios. The devices' memory and RAM are
>>     interleaving in physical address space, it would be required to use
>>     multiple `mpu,device-memory-section` to cover all devices. This layout
>>     is common on Armv8-A system, especially in server. But it's rare in
>>     Armv8-R. So in current stage, we don't want to allow multiple
>>     `mpu,device-memory-section`. The tool can scan baremetal device tree
>>     to sort all devices' memory ranges. And calculate a proper region for
>>     `mpu,device-memory-section`. If it find Xen need multiple
>>     `mpu,device-memory-section`, it can report an unsupported error.
>>
>> 2. Use a tool to generate device tree property and platform files
>>     This opinion still uses the same inputs as opinion#1. But this tool only
>>     generates `xen,static-mem` and `module` nodes in DomU nodes, it will not
>>     generate `mpu,guest-memory-section`, `mpu,boot-module-section` and
>>     `mpu,device-memory-section` properties in device tree. This will
>>     generate following macros:
>>     `MPU_GUEST_MEMORY_SECTION_BASE`, `MPU_GUEST_MEMORY_SECTION_SIZE`
>>     `MPU_BOOT_MODULE_SECTION_BASE`, `MPU_BOOT_MODULE_SECTION_SIZE`
>>     `MPU_DEVICE_MEMORY_SECTION_BASE`, `MPU_DEVICE_MEMORY_SECTION_SIZE`
>>     in platform files in build time. In runtime, Xen will skip the device
>>     tree parsing for `mpu,guest-memory-section`, `mpu,boot-module-section`
>>     and `mpu,device-memory-section`. And instead Xen will use these macros
>>     to do runtime check.
>>     But, this also means these macros only exist in local build system,
>>     these macros will not be maintained in Xen repo.
> 
> Yes this makes sense to me.
> 
> I think we should add both scripts to the imagebuilder repository. This
> way, they could share code easily, and we can keep the documentation in
> a single place.

Can I understand your comments like, we can support above two options.
Users can select to use either way. If the select the option#2 script,
MPU_GUEST_MEMORY_SECTION_BASE will be detected by Xen code, and Xen
can bypass the device tree parser. If Xen can't detected 
MPU_GUEST_MEMORY_SECTION_BASE, Xen can treat that users selected to
use option#1 scripts, Xen will do DT parser.

Cheers,
Wei Chen


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 09:09:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 09:09:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310753.527665 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhpHh-0002RW-KH; Fri, 22 Apr 2022 09:09:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310753.527665; Fri, 22 Apr 2022 09:09:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhpHh-0002RP-Go; Fri, 22 Apr 2022 09:09:01 +0000
Received: by outflank-mailman (input) for mailman id 310753;
 Fri, 22 Apr 2022 09:09:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhpHg-0002RF-8i; Fri, 22 Apr 2022 09:09:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhpHg-00062o-69; Fri, 22 Apr 2022 09:09:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhpHf-0004YU-JP; Fri, 22 Apr 2022 09:08:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhpHf-0006pi-Iz; Fri, 22 Apr 2022 09:08:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RkZgPoHjzHlwGj1DwsGL+oI5NF6Q7xwgp7o7gyUTYG4=; b=jiMWMPl3om0+fRwKUC9noro9K/
	xXjX7SomkdVXX6nsLCO0Xuude/aTYVn9kTKA7BM3vqzCsnmI/GlmggGKUgLmwCi0xoqjFMZ/kwR+K
	Mnl8H5q0MGMOrqOAWbPgIgWdWK7e82IamBIos7srhWVydgF6R1+YlcRuJ9ygukFr8LDw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169603-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169603: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=378f973a6ce89de16496bc6007f4dffa2f881dbc
X-Osstest-Versions-That:
    qemuu=b1efff6bf031a93b5b8bf3912ddc720cc1653a61
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 09:08:59 +0000

flight 169603 qemu-mainline real [real]
flight 169613 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169603/
http://logs.test-lab.xenproject.org/osstest/logs/169613/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw  8 xen-boot            fail pass in 169613-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 169613 like 169595
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 169613 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169595
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169595
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169595
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169595
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169595
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169595
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169595
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                378f973a6ce89de16496bc6007f4dffa2f881dbc
baseline version:
 qemuu                b1efff6bf031a93b5b8bf3912ddc720cc1653a61

Last test of basis   169595  2022-04-21 15:39:36 Z    0 days
Testing same since   169603  2022-04-21 22:39:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrea Bolognani <abologna@redhat.com>
  Dov Murik <dovmurik@linux.ibm.com>
  Edgar E. Iglesias <edgar.iglesias@amd.com>
  Hao Wu <wuhaotsh@google.com>
  Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>
  Zongyuan Li <zongyuan.li@smartx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   b1efff6bf0..378f973a6c  378f973a6ce89de16496bc6007f4dffa2f881dbc -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 09:21:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 09:21:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310769.527677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhpTj-00054Y-QT; Fri, 22 Apr 2022 09:21:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310769.527677; Fri, 22 Apr 2022 09:21:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhpTj-00054R-Lj; Fri, 22 Apr 2022 09:21:27 +0000
Received: by outflank-mailman (input) for mailman id 310769;
 Fri, 22 Apr 2022 09:21:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhpTj-00054H-1i; Fri, 22 Apr 2022 09:21:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhpTi-0006FO-Uj; Fri, 22 Apr 2022 09:21:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhpTi-0004uw-Jc; Fri, 22 Apr 2022 09:21:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhpTi-0004Yn-JA; Fri, 22 Apr 2022 09:21:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bhIa9XjsjAEQ9zS7I8auMrD/B+fROdbO9p4AhtSStG4=; b=xWDLLZxsaCVTvFWdoDuD0EGvC7
	KcLY3TpCwEEyWtYCwZIqlVTLEIX4yw6Kk4f1J46ieOpuzDWb2zFEy0/pknmJTTBLcZBDDvKLbc11/
	LxoQnE9JPTNT0p3Dl0bR5FKVRPTx2edz46MW8EMK8s+WIq9Zqz/IzhW1OUcpwl2fEOw4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169612-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169612: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=2306555bf9081ae9979405f96428738807e580d4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 09:21:26 +0000

flight 169612 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169612/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 2306555bf9081ae9979405f96428738807e580d4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  550 attempts
Testing same since   169610  2022-04-22 04:01:05 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5625 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 09:41:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 09:41:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310778.527687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhpnO-00089E-H0; Fri, 22 Apr 2022 09:41:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310778.527687; Fri, 22 Apr 2022 09:41:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhpnO-000897-DH; Fri, 22 Apr 2022 09:41:46 +0000
Received: by outflank-mailman (input) for mailman id 310778;
 Fri, 22 Apr 2022 09:41:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QJ8Z=VA=citrix.com=prvs=1040bc4e0=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhpnN-000891-Hp
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 09:41:45 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a1be77a-c220-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 11:41:43 +0200 (CEST)
Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 05:41:14 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SA2PR03MB5740.namprd03.prod.outlook.com (2603:10b6:806:11b::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 09:41:13 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 09:41:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a1be77a-c220-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650620503;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=PyavtDa7diMCEF0nVQcKlqv7x/eCnn35yRDzKXxBgdY=;
  b=a0Wfl29VzrjOpigrd9OKf0iifPLBjaaozG4/xxuQp/d4/kJHvinTZElq
   hyKgu77EipE60XDVgVn/jiNj9P9O/kh0ycPGKGU6BmP0Kn9b/kw2JwVis
   X1nfFs1XOUn+QJTIbgiXdlZGhcpyGasFCUk0qUQAxCJbaDyNMEF1eC+7M
   Y=;
X-IronPort-RemoteIP: 104.47.55.173
X-IronPort-MID: 69565157
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:QuYROKh7QKYoT9AMowSqo24LX1618xEKZh0ujC45NGQN5FlHY01je
 htvXDiCa/fcNmShKd1yaty+oUJUvZ7cxoQxGQtsqCgwFSkb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nX4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YV9xZZSQxeo+aj9dCwJ5OoZM9aPof1Hq5KR/z2WeG5ft69NHKRhseKc+qqNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehWhr7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9gPI+/duvje7IApZ94jub4rZROW2SPpww2+E/
 mj6rn3wDURPXDCY4X/fmp62vcfImS74Q54DD72Q+ftjgVnVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHmAsx0HUtxcCdom+RqNwarZ5QWeLmUcRzsHY9sj3OcpQRQ62
 1nPmMnmbRR1t6afU3Wa9bG8oja7OCxTJmgHDQcGQhEC+MLLu5wog1TESdMLOLWuktT/FDX0w
 jaLhCsznbMeiYgMzarT1VLahzOhoLDZQwhz4R/YNkqb6Qd+aJ+gdpafw1HR5vZdL66UVlCE+
 nMDnqC25u0UEYuEkiDLRewXBayo/N6MKjiaillqd6TN7Byo8n+nOIpWsDd3IR4zNt5eIGCyJ
 kjOpQlW+ZlfemOwarN6aJ6wDMJsyrX8EdPiVbbfad8mjoVNSTJrNRpGPSa4t10BWmBw+U3jE
 f93qfqRMEs=
IronPort-HdrOrdr: A9a23:ZPg/Yqs7ZET/iAgpFLr+F17Z7skC6oMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH
 PQ3LswmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZXbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczKgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxenkPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesaMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO21GkeKp
 ghMCjg3ocWTbvDBEqp/lWHgebcFEjbJy32DXTr4aeuontrdHMQ9Tpr+CVQpAZDyHsHceg72w
 31CNUWqFhwdL5mUUtcPpZ0fSLlMB27ffrzWFjiUWjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q
 6xG29liQ==
X-IronPort-AV: E=Sophos;i="5.90,281,1643691600"; 
   d="scan'208";a="69565157"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DWlSF8cBTVRIpg0W6/wWZYT+VhUrI5YN8DjlNB8kJSE73ErkRwxbrSvJCyqeOhlZUe1UtlcQc8tl7x3X6jXCD7151wJ59/ArvEBCpqqeHZ2WAejhhzKlxTsZIN8pixbZf4utzZvAryoShiWuaWerIt9SVGB6t7vqYhAwuH8Forh9E6qM4L1bNsOsW8lGtYgN3Izts6v/ezMy5jQlroIhQYycxkJq+AhJypVMHZ/GTH2cM73R2GfEa7t5oVQtMLCIlFAD9PH23VNVPMEYB0rybGsPhuKJkNVk69d9A09BDaGaK1tXZDbZ40F6Shcmu9cM+1aEsr1TfTgctiaLYyqL3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+nhS6/yUoO05duGe91k/b2AFm/E14+Gs/VbvDYRzq9g=;
 b=XGFGnE0oOlC4OOTGTE3eQxgpFJ4gdU/hy2L4ZNNNlQbqSErYORsEXg0pa6rqY/vjan80U3+g8SqHhgnP7kMNHhoL8E6ixLLqW1gBG6+mYftG7i7c39B4+hEd0gJsZB/aRlkP0eXi4V/aJdVnZ24iG3ajfUr5dQvtl/qsxT+18UeKCz9glhNg/dh0pzg/FDVuKyaNOke4pQo66W9Gn9HKMLbeFlaD2kxIBfoZIvB2APIMiqHYi36fwUb/WzE3Whkg94PplwZ2d6OUwKRha71uQDSvsBPOl3xTpoXnMepGzrmAYpOJRjhhleGvJr/3k5tT5hmHb7XF589Up3paZ3+zKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+nhS6/yUoO05duGe91k/b2AFm/E14+Gs/VbvDYRzq9g=;
 b=Fv0M2Cik0jQ3LGrL45KVAIePD53QNFydefMYBcS5vMOiuwv6v/EocG3woYar0HGKbhvdcB0RrDY+icg+DOS4Ea0gQqUI8tM/SB9JUdopolYsJ+BRt6nr76u6K2y2ywKEupWJKNXi5rSGr3PopMqROO0WMX7JB8BADz2Dt4yAzQo=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 22 Apr 2022 11:41:08 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@gmail.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
Message-ID: <YmJ4NLuvA63Irow+@Air-de-Roger>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
X-ClientProxiedBy: LO4P123CA0281.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:195::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0becddc0-cb27-4d49-9c3b-08da24443d06
X-MS-TrafficTypeDiagnostic: SA2PR03MB5740:EE_
X-Microsoft-Antispam-PRVS:
	<SA2PR03MB57405BB891DBC64F7BF9AA2B8FF79@SA2PR03MB5740.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/HkkQvksdJgwPonQl7GnKXTlOscU+LZAZcOszZuY242OmBO45sJsJLq0VKGI1hP+JCv0VxkSQ1EUpAs85y2AGYSXIgBdnRyD8ayGXYMQjD0fjYPd2rXhcUw8/sFf76egg5fiPwJzTszRjIDXdYtHLy9xVttsUi2guV4qCN8EJqA0mOuP86mFXquHcFt4sxfRw79XFK5gfePWRG9t3NmFX8bFCW7nt+IAJ5CXG8Yh7o/N9rf/V5L2NpzI1DzTSv99KfF79qKSIcb/aJrLsGSGUiwP7LiqhGpPKC7fzusEJU4Ab5EVRXO8DZ8wl0UYp6xNa77YrL1klFJXvFhiATfBRZIKhechpxq3JOFjLW/bonf58FHGKiipcL+rB4JHM/hXXs5Ut4HVWC/5Q4TYHTBZJdsUEqMDFw6GgKyV2LMAz4P91LyRU6bGJtIpsmFXditOW5MGRceZcoaDxjdacQzxH/I1WvFge33mfQgrpEgWltve/klei1rd+z1PwBAYUZwXP958cJXfcqBeg7RZ46qSJUWl4tv8rZfTz856Gfn0Sj30pguEaqdFSpNWxyN0nYoiMELqsa2GwLIbaOPJZ5gW3I4sQ4rpHozZp460YOt7eiCJFe6LfsLPtefQr7AU3onsj9cD+CnSXAnpQ90fWgSirQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66946007)(4326008)(8676002)(83380400001)(5660300002)(66476007)(66556008)(38100700002)(82960400001)(26005)(6512007)(6666004)(9686003)(85182001)(2906002)(7416002)(6916009)(508600001)(54906003)(8936002)(86362001)(6486002)(186003)(6506007)(316002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGhvZ0J4MEJpc1k1Q3lnSXFmdklLdE44VXl6UnptTVBTb0VacVlidThyOU5G?=
 =?utf-8?B?U0NsbnZHaWVGRU92UjVsS2ZFZllEaWYyRTUwYlRoZEFWbzdiTFZ2am52cnNF?=
 =?utf-8?B?Vys2Y1YwK2lWdU1oZWhMMUxHSjJkRXNuVWk3VG9TWmc2YlNCWUcrUFF3RFYv?=
 =?utf-8?B?dU9sT3pqbStrR1JyRzhCc1ZWeEtuOUR4VncySDJycUw2TUhJRDRDek9FNm9w?=
 =?utf-8?B?RW1Vc0JWNkxDdDhXeGpvRFdsZDNuZFZqYWdwK3hNZXJFVE02V3p2a1FlaEYv?=
 =?utf-8?B?ZHFHUUM5REJNS1pDNWVKUUlOdFBHSHVoOFpocUVjSVJwd0NTbm5ORnVRd09u?=
 =?utf-8?B?aFIrS2QvdFR6Y0loZG9wWWYrem9BR1JTR2J2Tlk5cXR6MUdyZUhoNnhEREt2?=
 =?utf-8?B?VDRibDZFQktXV2M1THcxQ0tDd2RFWWQvY2V6Y0RTYU0raHpscGRYNmRlUytq?=
 =?utf-8?B?dHFmOXFmaFZaNi9Fci82NDU0dWRNWHRta3NRK0hndzdaSGZ0MElHMm92QTZP?=
 =?utf-8?B?YmY2N0t2aGh2NTBIT2JMTXlsRm5JTzJoNk5RYk8rczZMeEI0S3lEZ0hXQURZ?=
 =?utf-8?B?bEUyb3VVMzZLV2x2Slk1cTEwM1BxUXpubWNnQko2dWo3SFFTaVpZZU5ad1R3?=
 =?utf-8?B?YlptdlV0ZWh2OS92b0lRWndXUVR4ZW01MnBKRFZ2MDlDTjJnOGw4U2ZqZ1p4?=
 =?utf-8?B?Ny8vUXQ3a0owODBlaCtlMmdvd0R3NGhNK2NiS3pIUVJZaE5GZytyMTJ5VjBS?=
 =?utf-8?B?VTc0VjcwSzZNYm8yc1IxNnNMak9mUU5Lcm9OWFNQUlFpb3dZaDluQ0Z6TW9C?=
 =?utf-8?B?UWhHQ3p1YkNBNEFybkQ2eC9CY3VDUUp0OVZQOFRMeGRPNSt2MDU0K3YvVFM3?=
 =?utf-8?B?eTRCaHAvK1NSbld0SVlzTnZZWnRrc1gveDZQMFFGd2dPNURlT3dSNjB1R0Fo?=
 =?utf-8?B?OVZvb0NZclJpSVN4T09TcExJekVpN3UydzBUOTJRd2x2bEhDSU9ORHEwK1Bq?=
 =?utf-8?B?VmFveGVvdHNLdGlKaU10UnE1T2V3bjZsL1dNV1E4cVhQMnlZQ0J2aVRMb1di?=
 =?utf-8?B?YlF3ZTZ1ZEJ0UnFVd0hyWEZIT01OOUkvZjhwNDdLRHNnM09NNGNNb083L25Z?=
 =?utf-8?B?VDRNemJSL0w1bENQMW5JNGpuRXJQbmtlMTE3WlVBbWVmTFMwVHo1SnJ4S21D?=
 =?utf-8?B?eUc0SkZFd01HRlhidGFVVURVWEZJd1dpaDhadExUOVdwRERaUEduMzB5R0lP?=
 =?utf-8?B?Mjg2SG1sakpYWmV2ZU4yWTdxL204TlZUVm53UnJpU0c3K0gvMlFITVVDdXh3?=
 =?utf-8?B?UlFGUkM1eFBMV3A2UVRxK1JoUDJHZlZnT1Z4YUlVU3dPcVBNWFFibm1jY2ZW?=
 =?utf-8?B?SFVibnNlVlVPMmUzaytsdUZWbUk0Z25sT1NxSm0wSFhSWG1WcDRncytibTNQ?=
 =?utf-8?B?elUvZysxN3RWM3FYdmZ5dHNRdllmeUovUWZocHFlRFVqSWx5Y1BjZTJqc2s1?=
 =?utf-8?B?MW5IcmN1bGluTjhzcFYwWnpMOFRPamZZaTkxam5EaFg1Nkw5Z3FpRHpCbU5v?=
 =?utf-8?B?OWlId3FHSlczMTE0enRtNTZXd2srRUM1ZHppWTRLQXNkd3VTRTU0VjZOOWlQ?=
 =?utf-8?B?aS91cFFFTm40aEIzU2hlWUQ0dmpmZXBmalphU0k3WUdhVWJUWjVDL1dhU1Zz?=
 =?utf-8?B?S1RxL1VOSHpjZDhodWdjY25hWmI5VzJUTjFZbEc4K0wrZXhuNjFlejdubTVW?=
 =?utf-8?B?bnhiTmtwNGVveTFyUFp5WVhhRnNRS2FuMEZrWTJnbjFwZHpxcjNRcitPc3pX?=
 =?utf-8?B?dDJPajdyZTRyckpjSHRXOEdBTHpFMnF6cm40MDgrVXYzVlpTbTdxblcwdlUz?=
 =?utf-8?B?ZzY4Sm1tZ0tNTzNXSi9pTVYzaW5UMjBXY1FqOWxtZGxIRzJCRUtpeEVmbHpx?=
 =?utf-8?B?MWtrUmZETmRUVHpEZXNsVFBEcWFxMXVpNVkyY1hKOVRXNDBtZG1Kd2g0eHd6?=
 =?utf-8?B?MDNERURUN1RlamhuNGdtU0N2N29ESUtvTFBId1lNUTFIK05lTG14L3llaW9T?=
 =?utf-8?B?RHRLTDQrMjFIMkV2Y3JRRmNTaEY0VFpvck5NK2JwNjEyeDd1YUdYTkZnNzBN?=
 =?utf-8?B?SnFWSjJrNVlGdzVBZlFZTW15NU53a1hmNDBvMy9Wd3c2c2RHdlpuYjZneGZK?=
 =?utf-8?B?OW9MdFRFek02RkpRcGxkeXNwbmNpUUFBdEdJZjBITk5jSzlTdjFmL1pjLzNn?=
 =?utf-8?B?eCtFcDQ3NUwzZkxxOXZiMjhSRStPSGFqY05zR0I0TEFoenNPUHYzbU9wSXdG?=
 =?utf-8?B?UXpGVlJMVU90MTRHVmhIZmI1enNNcUI0elFtVUg4c1ZkYVBDWkI1dz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0becddc0-cb27-4d49-9c3b-08da24443d06
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 09:41:12.9231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F2153OSP5ueBTFATZowyJjL0p4KqyLMK7zPK7uih1nertf/hE/t1bEiduWo8D6lLkz8e68Ry4wR4QiEOQC8rdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5740

On Fri, Apr 08, 2022 at 09:21:04PM +0300, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This patch adds basic support for configuring and assisting virtio-mmio
> based virtio-disk backend (emualator) which is intended to run out of
> Qemu and could be run in any domain.
> Although the Virtio block device is quite different from traditional
> Xen PV block device (vbd) from the toolstack's point of view:
>  - as the frontend is virtio-blk which is not a Xenbus driver, nothing
>    written to Xenstore are fetched by the frontend (the vdev is not
>    passed to the frontend)
>  - the ring-ref/event-channel are not used for the backend<->frontend
>    communication, the proposed IPC for Virtio is IOREQ/DM
> it is still a "block device" and ought to be integrated in existing
> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
> logic to deal with Virtio devices as well.
> 
> For the immediate purpose and an ability to extend that support for
> other use-cases in future (Qemu, virtio-pci, etc) perform the following
> actions:
> - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect
>   that in the configuration
> - Introduce new disk protocol field to libxl_device_disk struct
>   (with LIBXL_DISK_PROTOCOL_XEN and LIBXL_DISK_PROTOCOL_VIRTIO_MMIO
>   types) and reflect that in the configuration (new "protocol" option
>   with "xen" protocol being default value)
> - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
>   one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model
> 
> An example of domain configuration for Virtio disk:
> disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, protocol=virtio-mmio']
> 
> Nothing has changed for default Xen disk configuration.
> 
> Please note, this patch is not enough for virtio-disk to work
> on Xen (Arm), as for every Virtio device (including disk) we need
> to allocate Virtio MMIO params (IRQ and memory region) and pass
> them to the backend, also update Guest device-tree. The subsequent
> patch will add these missing bits. For the current patch,
> the default "irq" and "base" are just written to the Xenstore.
> This is not an ideal splitting, but this way we avoid breaking
> the bisectability.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Changes RFC -> V1:
>    - no changes
> 
> Changes V1 -> V2:
>    - rebase according to the new location of libxl_virtio_disk.c
> 
> Changes V2 -> V3:
>    - no changes
> 
> Changes V3 -> V4:
>    - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT
> 
> Changes V4 -> V5:
>    - split the changes, change the order of the patches
>    - update patch description
>    - don't introduce new "vdisk" configuration option with own parsing logic,
>      re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk
>    - introduce "virtio" flag and document it's usage
>    - add LIBXL_HAVE_DEVICE_DISK_VIRTIO
>    - update libxlu_disk_l.[ch]
>    - drop num_disks variable/MAX_VIRTIO_DISKS
>    - drop Wei's T-b
> 
> Changes V5 -> V6:
>    - rebase on current staging
>    - use "%"PRIu64 instead of %lu for disk->base in device_disk_add()
>    - update *.gen.go files
> 
> Changes V6 -> V7:
>    - rebase on current staging
>    - update *.gen.go files and libxlu_disk_l.[ch] files
>    - update patch description
>    - rework significantly to support more flexible configuration
>      and have more generic basic implementation for being able to extend
>      that for other use-cases (virtio-pci, qemu, etc).
> ---
>  docs/man/xl-disk-configuration.5.pod.in   |  37 +-
>  tools/golang/xenlight/helpers.gen.go      |   6 +
>  tools/golang/xenlight/types.gen.go        |  11 +
>  tools/include/libxl.h                     |   6 +
>  tools/libs/light/libxl_device.c           |  57 +-
>  tools/libs/light/libxl_disk.c             | 111 +++-
>  tools/libs/light/libxl_internal.h         |   1 +
>  tools/libs/light/libxl_types.idl          |  10 +
>  tools/libs/light/libxl_types_internal.idl |   1 +
>  tools/libs/light/libxl_utils.c            |   2 +
>  tools/libs/util/libxlu_disk_l.c           | 952 +++++++++++++++---------------
>  tools/libs/util/libxlu_disk_l.h           |   2 +-
>  tools/libs/util/libxlu_disk_l.l           |   9 +
>  tools/xl/xl_block.c                       |  11 +
>  14 files changed, 736 insertions(+), 480 deletions(-)
> 
> diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in
> index 71d0e86..36c851f 100644
> --- a/docs/man/xl-disk-configuration.5.pod.in
> +++ b/docs/man/xl-disk-configuration.5.pod.in
> @@ -232,7 +232,7 @@ Specifies the backend implementation to use
>  
>  =item Supported values
>  
> -phy, qdisk
> +phy, qdisk, other
>  
>  =item Mandatory
>  
> @@ -244,11 +244,13 @@ Automatically determine which backend to use.
>  
>  =back
>  
> -This does not affect the guest's view of the device.  It controls
> -which software implementation of the Xen backend driver is used.
> +It controls which software implementation of the backend driver is used.
> +Depending on the "protocol" option this may affect the guest's view
> +of the device.
>  
>  Not all backend drivers support all combinations of other options.
> -For example, "phy" does not support formats other than "raw".
> +For example, "phy" and "other" do not support formats other than "raw" and
> +"other" does not support protocols other than "virtio-mmio".
>  Normally this option should not be specified, in which case libxl will
>  automatically determine the most suitable backend.
>  
> @@ -344,8 +346,35 @@ can be used to disable "hole punching" for file based backends which
>  were intentionally created non-sparse to avoid fragmentation of the
>  file.
>  
> +=item B<protocol>=I<PROTOCOL>
> +
> +=over 4
> +
> +=item Description
> +
> +Specifies the communication protocol to use for the chosen "backendtype" option
> +
> +=item Supported values
> +
> +xen, virtio-mmio

>From a user PoV, I think it would be better to just select xen or
virtio here, but not the underlying configuration mechanism used to
expose the devices to the guest.

We would likely need to add a different option to select mmio or pci
then, but that should be set by default based on architecture/guest
type.  For example on x86 it should default to pci, while on Arm I
guess it will depend on whether the guest has PCI or not?

In any case, I think we should offer an option that's selecting
between xen or virtio protocol, and the way to expose the
configuration of the device shouldn't need to be explicitly selected
by the user.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 09:56:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 09:56:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310785.527698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhq1H-00022K-To; Fri, 22 Apr 2022 09:56:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310785.527698; Fri, 22 Apr 2022 09:56:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhq1H-00022D-Om; Fri, 22 Apr 2022 09:56:07 +0000
Received: by outflank-mailman (input) for mailman id 310785;
 Fri, 22 Apr 2022 09:56:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QJ8Z=VA=citrix.com=prvs=1040bc4e0=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhq1G-000227-TI
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 09:56:06 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b6d5764-c222-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 11:56:05 +0200 (CEST)
Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 05:56:01 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by CY4PR03MB3351.namprd03.prod.outlook.com (2603:10b6:910:57::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 09:55:58 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 09:55:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b6d5764-c222-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650621365;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=g9a957wLIr9qdQJBMWI6OwIVOkd+Y3rhznLifd7+Tyw=;
  b=I3tvZQC1e6VtICDiHVDBqCjiR2PhsXHdJZBAmVG3RiHo2ZYZoPXV9QzX
   NvPBUZHjDPMj+/udulHdSWMlNAzhA1fWlMbmwudt07sA0sUUe/IXCAvmw
   YBUfPjRYfML1IKvT5YIx1M/SE05Mu3nrpmvFZIAgdLplvptVwX/h8jJ6q
   E=;
X-IronPort-RemoteIP: 104.47.55.170
X-IronPort-MID: 70091864
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:4y48L6yt8t7osKnWOUJ6t+dDxyrEfRIJ4+MujC+fZmUNrF6WrkUDm
 DRMDTyFOq6NZTakfNkiPd6xoRhQu5OGydUyTVBsrSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024LhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplurebYkBuMZHwlekcdEdoLHtyE6Qa0eqSSZS/mZT7I0zuVVLJmq8rJmdmeIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHuOTuocwMDQY36iiGd7EY
 MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgK2UJ8QLL+cLb5UD80iot3IWzGub1e4e2fvlMwwW3t
 3LZqjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWMwkQDBRtQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO+gz6QXIwKyE5Q+cXzIAVmQYN4Rgs9IqTzs30
 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZowL/HKd5jEtJQzN/
 g==
IronPort-HdrOrdr: A9a23:VLDouKsq3tUTkBpJKrI/z+/s7skCJ4Aji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKdkrNhQotKPTOW9ldASbsC0WKM+UyZJ8STzJ8+6U
 4kSdkCNDSSNyk6sS+Z2njCLz9I+rDum8rE5Za8854ud3ARV0gK1XYfNu/vKDwOeOAwP+teKH
 Pz3LsjmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G
 DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z
 /xSiIbToFOArXqDziISFXWqlHdOX0VmgHfIBej8AreSIrCNWkH4oN69PFkWwHE5UQtpsxx3Z
 RCwn+QvZtSARTcqj7w/cLJURZdlkfcmwtTrccDy3NYSocQc7lXsMgW+15UCo4JGGbg5JkgC/
 QGNrCQ2B/4SyLsU5n1hBgl/DWXZAV4Iv5GeDl1huWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+
 DJKL5hmr1CRtIfKfsVPpZPfeKnTmjWBR7cOmObJlrqUKkBJnLWspbypLE4/vujdpAExIY73J
 7BTFRbv2gvfF+GM7zD4LRbthTWBGmtVzXkzc9To5B/p73nXbLudTaOTVg/+vHQ68n3wverEs
 pbFKgmdsMLd1Gea7qh9zeOL6VvFQ==
X-IronPort-AV: E=Sophos;i="5.90,281,1643691600"; 
   d="scan'208";a="70091864"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cmwjwAyTivmZWVxdjV12zNpEyuCbUBE6RqvWijMTOrveP6D3EoPGlvgCa/44EtDy3VPjSmySFUh2xQqw92mo8EgPtxY+m3W3yyHawk1QKcXqBmToNfgY5bbycntaFqogXuI0vzACL72Yq4eS7GcHkebRH8zsAX99CnoQh3g73B8mp9/U7Xfgz7iqKm08O9rNioGc2MKqKxwTsZBzyyJuC6cAXutXcWCm32hOu/DVMsi+ko6lROYWvGIR7LI7IhRqSYKCNE8xP/ckzcq2pk5un/IgEcn2luC54YEyxAbnZCqC+CcqG3WADInx6R3fjWWQaNDsbfvgwr1wmfkeKSuj6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a04gQxjp43IJV6/yDVIkrX8c05kdMCFzPAj6huzj8to=;
 b=dCUZvGi5maHmHd6wTRdX4PcJ2xFLIsLkEmreG+C6qW7C6ckLY7nkYGslAd231s/s0g5PaNGUKPbIuRiTsgJ/CaJCh3BTACHo3ZG2LrMD+yIG9LqdjBzGxFd7hhietuY8C/HOYlqYE3e9SubjzPhVw7m8b7oEEz0VhlAZtTdssSY2PgBE9MRXQRwtsbcAcbDSPMHeKgaDA9cWhvbas111JrePRKTE6KT2lO7Rs6n2ymxZIAVbGSsUdZxBFSuf0jcrPo6pFamosiaHidk9Pm1tOM+15NptUeX08eLQH3tY9qTtPvreXhFrYshYc7GfqkIssz2Y/g61qz9xDUJkjkB+yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a04gQxjp43IJV6/yDVIkrX8c05kdMCFzPAj6huzj8to=;
 b=ebDRpmZEJo4FrWG7ZtpmzqSErRjmZxQ/FW5KH1Vmoyjxsl3A5WLFEZr42ep5OCami2mP6xG6v9qc+qgd+oQrAqLqK9W5PoVYNj8dEcW5iU7RSPp5DUdFfflvh/cJUfA6HlhRJWPTONrkQWCAtkM2wA7rk+M2pmK/0VN/j3GPGcg=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 22 Apr 2022 11:55:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Message-ID: <YmJ7qr6W7cFkwV6W@Air-de-Roger>
References: <20220331092717.9023-1-roger.pau@citrix.com>
 <20220331092717.9023-4-roger.pau@citrix.com>
 <0bb48681-a78f-d32e-f989-822dd5e54b70@suse.com>
 <YmF2Zw13O6oaAT0k@Air-de-Roger>
 <b7e3ecbe-6c2e-94f9-58c6-ae49652e6a29@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b7e3ecbe-6c2e-94f9-58c6-ae49652e6a29@suse.com>
X-ClientProxiedBy: LO4P123CA0118.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89aad3ce-c02a-4bca-c984-08da24464cdb
X-MS-TrafficTypeDiagnostic: CY4PR03MB3351:EE_
X-Microsoft-Antispam-PRVS:
	<CY4PR03MB33512515DB36B924395D3CE98FF79@CY4PR03MB3351.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1UWwypnkDKvZgFNPu5WS9YtMS8ZKplSkYsoBp0XRG4GoD3ZDpUHKBmbJVPfEYynduvaJETI2lL84MVP857qFHydWFzB1goZwBMNkWcyo1A89fz67nTbyVvXqp8/lLxkiBrmDggRJG83ChYMqfXAbrks1zy1qX1uwYTLXe3fJATXMiAfzWGftWEtiSs4GnwK+zdg+cJm3l/IIzB9HOYKOAQEEj+GPJGUNVhbdqIjLlpTiKJL3QgUEt//IuP97bRo5XRqnQbRAQ8XHV+7HCpYfZt6vIK8gO8uRtNn99HmjfXiLEcuaBNhkX1HBynehdgbrLCH+tZxWvRxDgWB0BrzQXrN5cyXdOmTrR8hzIq9/G2e5fq7n565Ajc/SO3Y0nNYq/fSGkhE2jc7V+Dx5cy6ssl4bbHTFwMLoLnWZJ+1qkdQFHeuuePrlf0oxWn7F2f2hgMhJFGk9XGR44ILvBClYEwVxuXUOjwkEbe4NPDNkqvPJHphHd8gB3wDpyR+aWORFRkhrtsDNBvWm8qN31V4IsdWABOHIFyYt9eXlrWi/FHLLZwVuT+cdBAFE41i9GPxJugDH/vQqv79gs/nbmYOTpHdHHVSWxmSTa3R1mwTxCpYbSrajRAqkLvjLVUK+fwrJgGP915ouKrEtMOldbujNmQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(83380400001)(4326008)(8936002)(66476007)(186003)(82960400001)(66946007)(9686003)(53546011)(6512007)(5660300002)(6666004)(86362001)(26005)(8676002)(6486002)(66556008)(6916009)(54906003)(316002)(508600001)(33716001)(85182001)(2906002)(6506007)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bHJCNGs5ZGprMmhMbTdkOFBqVlpuRFJWeXdzUzFFVVhFM0UzL0xFcG9nQnU0?=
 =?utf-8?B?UkoraTA0dnJLZU5XSU1EYWs1QUNyTFFCM0NaSEtQUWdZUHZRZGovY05POXN2?=
 =?utf-8?B?cEVZRlpJK1pMMGJHK3Boa2RraVZFcDZiK2gxbDltRnA5MUJQVU9ZRXhPN1pl?=
 =?utf-8?B?VDBIdnRxcVl0Z25hUk9DS1lGOXJGdVlBNDF4Y0ZGczRBU2hYNlJTOHhkeU81?=
 =?utf-8?B?OEdrZHRqRmE0SVcrWmNuMzExb0tiYWRhUGROa3RmRmpTMm1FcWpPUEZxY1pL?=
 =?utf-8?B?akJMTWNCUjVJb3g3UWVIUjhBd0QxSXhDNXpUUHZBbElxcE9EQXpZUnlVNlhi?=
 =?utf-8?B?SlQyS3BaU3JmWG1jQVN0bzVObDk5bHpIamJSbTFZM0JxUEhtZFVITTZVVHM0?=
 =?utf-8?B?aGNNWWVWTXdBNkpYNEVHNlhkdk1YRVlrSWFManAxTHVBNDBkNzZrZWdSNHo3?=
 =?utf-8?B?SWtOWWlMQ09EcWFDUTR5ZjFBN0JkV05NSlpkVXN5Si80NFlzdDdOU21qd0F0?=
 =?utf-8?B?NUwzWCtpbVI3dzR2S3o4L2xRNEJFTFJyU3N0SFRTYTJZTldRcmwrOVdXOVBG?=
 =?utf-8?B?RWh5TnZkdTJUWnduQWRNdXAyRFdJOVdtYmlsbzVBSkkvcVFrNUhCZWVqL0FT?=
 =?utf-8?B?Y3hQYy9CcjdBTFIrUzlyUlVFdEJmckFYdGgwSXJLVFhDZGh2MTdYSDJvUjFv?=
 =?utf-8?B?MnM3aDgwR0lpb2wvQXI3TGpaWitrOW1qVXBqajB5SnJ6SmNBa3F5Q1VMNWF5?=
 =?utf-8?B?MWd2aFVzNERaUitiR2tiRStkRldMM20rcElmVXRtM1ovMUEwSXhJWUhPWXds?=
 =?utf-8?B?a0JFZnJzZGxBeDdwSDBvZVl3SnJCOFRMeEdZTldoVWFSNm9rdHlSZzg3bHd1?=
 =?utf-8?B?MFBUdEdzcWxpTFMyZDVwYkxsZnlOR0g3RjZ6Y012V1FOQmVEeE9mTlE3dXRi?=
 =?utf-8?B?MHFXQkczREdoL3N0VFBHcEU4U0k3ZkwxcmRiaytmUzhYVnFHZVp5Q1huMlU4?=
 =?utf-8?B?U0ZvT3JtbytaUmNndG83UG0vU3dkS1BEd1NBU0tRRThVYWJaZUtmdFZidjhZ?=
 =?utf-8?B?YkszZ0tMazZoNUo3UFJxcGNCdVlSUzdQVk1BSlkrbDlnZVYzUTkzcnBDWmxz?=
 =?utf-8?B?c0xsUEphOU1wOEt6Q0lwMVd1MC85YVRZK2lPOEUwdk9OMXU4bFpWYjA3dElI?=
 =?utf-8?B?cmhLdDZvV3RKYUpKbnhtZ3Nwa2ViSkYzbWNwdzRVSlVlN2ZZYkFzWmtjZVNF?=
 =?utf-8?B?elpqWDQ5ZUFIY2ZJTzJQRzBNYndCRGpNOS9JVitWZlhQeWI4aExLdFJwaWVa?=
 =?utf-8?B?VU1DeVpVZWc4OGJ0UzJKd09uU0RZZ0JQekZmSVJLYTlkcEJRaFNOekRYT1NO?=
 =?utf-8?B?a3h4VmJxMEhkSDJsU2R0YW9odFpXRmtLbW0yZHlrczltdUl3aHFhZ1BsRkhB?=
 =?utf-8?B?a1lhK3dxRXQrRGFmRDJabkZUNjhIZUpLV3Z1SmNYdFF0RmNVNVA5aFN0dU10?=
 =?utf-8?B?Y1gwRGtuSmw2eUN1S0NSN2pJVnhjYVlsRmlVOURZL0xnN2htekhyVkpMWFMv?=
 =?utf-8?B?bFF2TlpvN29FK3hQY1J4L1NQeHFOd1hNOW1xbldhdnVRWk9BNWVEZ3k0TmRN?=
 =?utf-8?B?TnViOFRsMzVrbncyNThyN0VPVFFYOW5GZ0lHUTQxZURveGlGa3A1TVowczJR?=
 =?utf-8?B?aUZtbTE4M2p6UnZZczUyV2Q0Q0xsSm9md0FVdmZQNW0yWFVNZW5tVEswMXFQ?=
 =?utf-8?B?bVE5a3JnS2VVYmRvMEt1NlQ3bzZTMG01NXp2Yk80TVlBaXN0NVZFbDRkL1FR?=
 =?utf-8?B?UTRBOTZzWlRNMm5uemNaZlhGSk54U0VoeHkwVE44NHhncEJ1QVZNblVaYmtY?=
 =?utf-8?B?QWJ5MHE3MllFN3UxMlFYSnBRUUhhcnhDdTdYZnRQQmd4SVFXbWR3NVpXTFht?=
 =?utf-8?B?cHkybk1waUp3YjZpNk9JZzF3U1BXQXZpbFlkM2xTQzhMYVFHTjlMcG5WUk11?=
 =?utf-8?B?bmVmaFM3eHhZb29oSmtsL0pubHV3RCtOTG1ZNmRhaFdLTXNxd2hPNjk0c05I?=
 =?utf-8?B?YlVIUVZRRXdUZjhuNGZWWUJDajBhZEdwV08yZm1jdWZ6dkxFdEJNQkZFVGhU?=
 =?utf-8?B?bG5icm42a3BBekpNdDE0NExzQUp2MnpvWHU3bVc3Nzg5WlU1aDdINXF2RGFE?=
 =?utf-8?B?VTZSOThJcE9sUGNXZ01UNGZXWUtDNTVMdW1IMVdQbkRSSEJzaXFvNlQ3Y1Bz?=
 =?utf-8?B?eU9UK2ZaQ2dOOFlMOHlwUlhPcWt2MFFTQ3FTd2pEL0pWNHJ5SFNvR284VlRF?=
 =?utf-8?B?SWJpOVVxOTdqd3VvbGwvM0RKZk1YaWwycXVzM2NFd1JtVS9HcFBqcVRWQitk?=
 =?utf-8?Q?6jDn+gmAS15CVsYk=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89aad3ce-c02a-4bca-c984-08da24464cdb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 09:55:58.4462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 61CuB/SgDpEz/0tx7CLzETattXD+gYnHBVKd3Wd+91n39u6akTCu8u8HsFxCyFGZZtl/Kn/3f21ewGnD8qqS8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3351

On Thu, Apr 21, 2022 at 05:27:18PM +0200, Jan Beulich wrote:
> On 21.04.2022 17:21, Roger Pau Monné wrote:
> > On Thu, Apr 21, 2022 at 11:50:16AM +0200, Jan Beulich wrote:
> >> On 31.03.2022 11:27, Roger Pau Monne wrote:
> >>> Expose VIRT_SSBD to guests if the hardware supports setting SSBD in
> >>> the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU
> >>> families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD
> >>> allows for an unified way of exposing SSBD support to guests on AMD
> >>> hardware that's compatible migration wise, regardless of what
> >>> underlying mechanism is used to set SSBD.
> >>>
> >>> Note that on AMD Family 17h (Zen 1) the value of SSBD in LS_CFG is
> >>> shared between threads on the same core, so there's extra logic in
> >>> order to synchronize the value and have SSBD set as long as one of the
> >>> threads in the core requires it to be set. Such logic also requires
> >>> extra storage for each thread state, which is allocated at
> >>> initialization time.
> >>
> >> So where exactly is the boundary? If I'm not mistaken Zen2 is also
> >> Fam17 (and only Zen3 is Fam19), yet here and elsewhere you look to
> >> take Zen1 == Fam17.
> > 
> > Right, but Zen2 already has AMD_SSBD (ie: SPEC_CTRL), so it's not
> > using this logic.
> > 
> > The AMD whitepaper is more clear about this: any Fam17h processor that
> > is using the non-architectural MSRs to set SSBD and has more than 1
> > logical processor for each logical core must synchronize the setting
> > of SSBD.
> > 
> > I think just dropping the mention of Zen 1 in the commit message
> > should remove your concerns?
> 
> Or keep it, but qualify it by saying that Zen2 isn't expected to take
> this path because of having SSBD. But iirc SSBD was introduced to
> Zen2 only by a ucode update, so such a description should not be wrong
> wrt such not-up-to-date systems.

FTAOD I've worded this as:

"Note that on AMD Family 17h and Hygon Family 18h processors the value
of SSBD in LS_CFG is shared between threads on the same core, so
there's extra logic in order to synchronize the value and have SSBD
set as long as one of the threads in the core requires it to be set.
Such logic also requires extra storage for each thread state, which is
allocated at initialization time."

Which I think is correct in all cases.  Iff Zen2 was to resort to
using the non-architectural way of setting SSBD (if that's even
possible) it should synchronize it between threads according to my
read of the AMD whitepaper.

I've also added handling for Hygon Fam18h, seeing as those also make
use of the non-architectural way of setting SSBD.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 09:59:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 09:59:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310790.527709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhq4A-0002dG-A8; Fri, 22 Apr 2022 09:59:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310790.527709; Fri, 22 Apr 2022 09:59:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhq4A-0002d9-75; Fri, 22 Apr 2022 09:59:06 +0000
Received: by outflank-mailman (input) for mailman id 310790;
 Fri, 22 Apr 2022 09:59:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vZpq=VA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhq49-0002d3-1n
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 09:59:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d71023c4-c222-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 11:59:03 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-N0Rj8CfzO1WhK7WeZIcLRA-1; Fri, 22 Apr 2022 11:59:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by GV1PR04MB9103.eurprd04.prod.outlook.com (2603:10a6:150:22::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr
 2022 09:58:59 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 09:58:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d71023c4-c222-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650621543;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=gfLEJWB8dYg/5ByFirWLKx4TpYb2Ys2tqREAkfOhScg=;
	b=XEGTzxG0yZaCSYfViYmTaeRzhE12JfQ/6URGl7oe8zwDTM55hTFEz/dDZ7GUdo0tmHPUSP
	qs84j8Inv7B2IRdQ4OmabYNyOKJnemELZ41B3zhH8hVhI/i2aLFIL7KJuPPxfEWpnzOcNe
	RHgm7WchiIMZ7kCWGNj8NGL8usTECeQ=
X-MC-Unique: N0Rj8CfzO1WhK7WeZIcLRA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OVUu5E7UQ+vfn6de5xu7ZJ2A/f5xDXBY31el1rzdzJ2oq1iuSkt1JX/9bqEkdlhVWMJz9QX8s02d9WWNLeYzrK0Nv70PZHGt9MO+uLHmugPJsHbobyT8/Q0KhUGNrr2y92cA/CMLKjtvUaWaOmXg/555I+tsw3uSK0XeqSK6HYH6RNuZHVddAGJ8Mh/ekKmlBvlFfo5yyPrKg6GKGTgsvbTLm962U3vPcBReSj4TfNF8R8+2wOeyqIGKcxfvWJv4VPrLq+bY4DGEzlvXNFmbpe6lRC/6bnYSfJP0J6V1+76xoFe15bilrU/u+7sHA3F+b5PS9q9JMRwqtNwffHpSkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gfLEJWB8dYg/5ByFirWLKx4TpYb2Ys2tqREAkfOhScg=;
 b=ev3zs7mr4fLd6PG4QVP2/dTS3yW182p09URhVzEbiF2cJRrhwXKrqfXe7zkebxQ8JT8C3dsi8xb5t5IoIaEnoQoExEn/edIcHnl228E15GlP6FfkWjV+3nROqbHp9eokP1GufoC8GgFPJg6QudpbefE7iyguozYeUBqloVDfI8kt4y7Y9cwEy7U22L0z8PfWL2jE8/9yOPoSJTAXvBkdx3zRd+CQXgVoRAUnlPj/FnNXNBCQMYkuIu01sqXYbttxrsNCLjR7GWBW3rhPVnbxUb53lwXpU6ocVfJBw+voecwWA9BqCOWFt0mDSQxxiQSOo73mLH+w6hhMTMDTFIKy8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <431d4212-07b8-63d5-1a4d-7e8c7a9108ea@suse.com>
Date: Fri, 22 Apr 2022 11:58:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] VT-d: fix !HVM build
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0353.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::30) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b4bce51a-70b4-42a1-6c0a-08da2446b8c9
X-MS-TrafficTypeDiagnostic: GV1PR04MB9103:EE_
X-Microsoft-Antispam-PRVS:
	<GV1PR04MB910316E4BB022F3B5EFC938AB3F79@GV1PR04MB9103.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MGr8SJ3NfntPCNW2x0bbttrBvzBh2PRBSbEhDmxMtPE9dR68sN0Pz9yzLlchc6GO6tfiIUdwzpRtNelnHN2rfbAADRpUgtPH1HzqvMPuPk5iUi1RILeSW5UmRRtLsxC/6Az/8gj7Z79E0ezfzxEPdGsC4FghX75QJC5nKqLqNiADOtcaeWHnMTiFC/gqc6rFEoMQwQbj76Wom48F3E2O5Hxy5KCTDDN4cckMAa9al1N5IRuwBo5JoxYeOV1mAlMMLN/RbZOES2Ywxsar7gDGgcVj5OHf3zg2l3r6qXwSPYKMQoGQSi4OEFqliUvWlldeAvJoX52+1J/ThX5V/w+fVHRXsdYcuJ3oNXeMiDBb6hDk1fac5tAX/rr8hZ9H5vk7lkhwOEjSpsTEtS0tFi7kz1+EA3LUeG0wQf1shUXY0NyNUf/b8IhGfArAP8xGcZMtMEqFJUbjX1r7oKoA7VaJWKkyRggSntbfj3jOv8rnKT5F3ikeWBBFZ3HrVuIbRVfe1YpsvByzNqjD/Xc2rHw7chSP0EVqHhlwmTmvwMIXmVnPQ/8j6O9+b54R2uk+I185dL3vEQh/rxnd/sDLBl6T0BPAwchNctIkVrCRWue0r5WFO9etuvvP6a0iX/YfegkbxMaoZt1mIs/Ht08oiNHLRgfCSqB5rVF+IghvsxH9yUZ30CuIHii5WRxSxxlB243eu5imjF7o4jK7MCsjwUIE8594+u3g0HPESX92R7ZdhHk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(5660300002)(38100700002)(316002)(8936002)(66556008)(66946007)(8676002)(6916009)(4326008)(54906003)(6512007)(66476007)(6506007)(6486002)(186003)(508600001)(2616005)(26005)(83380400001)(31686004)(2906002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SG5mOExuY093azUvbjFVL0JYRE1XY0VXVGRuSGlJb2UxTldFMFlBU1R1WExz?=
 =?utf-8?B?OGpBWUNTWTd3VjVtRlB1Q3Z4TjB5aTlNcXFWenlSRlpUVkc1NTB3SDlFNFdQ?=
 =?utf-8?B?MFREamxyZ2pVUHhMY09BV244aHNQYzRRN1dIdTNJY2dvS28vQkdkUmZ5MW4v?=
 =?utf-8?B?YVg2NC8rd3NEMloweFZLV3FBajRIbXFQVlpXL1FCS3pMcFk0MkM4eHpDSE1r?=
 =?utf-8?B?OVQ3YWR5WXVlMlViMXo0b0hmNXF3WFVCZEMzcnI3dmJRV1dYTWg2c21uNk1E?=
 =?utf-8?B?bWpveFVLOU5GQjBxeHJoOXVzVFh5YkF0T2RrWHo1WmlEVzFnVS9XaEF5Nlhk?=
 =?utf-8?B?U0V1bFVIUzZLLzhVY2pidTdFNjY3UDBwbXlMdk0wMXRwWHBjbmluZGFGSUlu?=
 =?utf-8?B?SGdNdmJ2ZE9FbG5RdXFhUG5FWjI1eXRqRVpDbUhqYmZIeCsyM25MUlJXN0hY?=
 =?utf-8?B?QnVXOGFSbTFFUE5MSWgyY2tDWE92ZlVOQTRockIyUlZQc3JoTGxzSnBNMVdE?=
 =?utf-8?B?cnUyYm14SlNodDRWcjBxSlNPL0RyUWVUb09tTUw1WGRPTmF1MCsva2FCc3lp?=
 =?utf-8?B?QjlheWR0SHRvK0lKMkd0MFR0b20ydWkyekJic3Z4TTZHMThaZ0xiM1pxdzdP?=
 =?utf-8?B?WFlLTklqUG1HTk5NYjBFNkRIV2s0MHdzYVMxWEZhMzMrU2dCYmtoMWRiTEk4?=
 =?utf-8?B?MFkrcEVNbGZoZ2h0Tm1FbTgwZ2dOblRLcnBxQ3hicXQzYTZsNjN2V2hBdUhQ?=
 =?utf-8?B?TURPL2Z4OVQvUjhIaVc2V0k0cjNqaVR3cUhGd1c0eDdvT3dPVE5pcU5xeDBW?=
 =?utf-8?B?NUVod3RjSEtjWW5DK2NQZFlUWU5SMEl2cTJSQ05oWCtXSWhKUWhZemh2dENk?=
 =?utf-8?B?dHpLd3pybkhJTEl5VGVNblJXTU40eDQyTkh0V1lsMHBOODliTXdhaHl1c25Y?=
 =?utf-8?B?akJSaEZHR1FzMUNYR0x0NGR4Sy9FZ3VPVEE1WjZ5S3dHcEdaL1p2WWpGZGVY?=
 =?utf-8?B?UllnaHBYTTVjVFQwbkw5T3dTbUVqcXI0cnBOT0Y3NllBRDBTaWlFVTZGR2Jn?=
 =?utf-8?B?d1dGa3g0M1psOUo0aWhOWmFOVkpkSXd4QU5HRkk0ZjU4dzBBbkpncDd2OTJ3?=
 =?utf-8?B?M096eGsxcjFkRStoUi9vRnNlYTJZR21wNzkwdUlQMFNyNGFWWWZQejIzRUY1?=
 =?utf-8?B?Mzc4SjIrVlVCbXdQTXJJVzErdzd1ZzhEaGNZYlBVWlAvWDNvWGZmaC9BLy9C?=
 =?utf-8?B?dTZ4WWVpRklvTHhaQ3hGZDhqM1NzTmpXUUZrWmVuRHZhb0UxV0hQODYzQU9N?=
 =?utf-8?B?ck0ydDJXVi8xS3dXSzlQYUdHTEFCVzZRM053TllpdnlDVk5CRXB3R2N2MVRM?=
 =?utf-8?B?SmVWVElYVExBUG1qelhEQ2dORXVmOXFIdVZUS0F3UmpUeStFU21tVlhrZ1h6?=
 =?utf-8?B?c3pDbEY3OGo0T3AvSDZMU0RHWnZibGNtR0pCWnd0ZnNMSjIwYTNwR1QwUG9a?=
 =?utf-8?B?b0F1K3BucVQxYURXNEI4TTBIRWZWUmdyMzNmNUF3dUZVOFNPWkxHaGlPbTBu?=
 =?utf-8?B?VHBZZ25qaFZXOTBSUURNaytZWHRzRGsvUjJZajVLdmNIeU0yUWd6bnY1b3Bt?=
 =?utf-8?B?Ny90N3IzMGcxK2gvUEFrRGszMzMzdndlNVdkcHlpcm5qbWIxQUVNditLcEFV?=
 =?utf-8?B?ZWduV3lJUnlOT0dNdUM5YWtadUxuYWZtYWpMY2xmQjRTL1pzU2dBWWNLaUFl?=
 =?utf-8?B?aStXMkpwQnFKM3gwYk5kSko5endrejEwT1lrQUJzcndXRnNnaWw2dW5maFhy?=
 =?utf-8?B?R2o0N3dBOTh4UjJSQ1RCQTNBL3gyUU4wLzFnMjBoWUJUQTVnQTcwUVdtaVR1?=
 =?utf-8?B?R0Q3RzZ3U082MmhMK1drT29UZ3l0TDhEUUlXQTBhWDBKQXZKc2lDSzQ1WGVT?=
 =?utf-8?B?YlUwQkllRHZuNjluY1FrVWNnYk1SdWcyMWVTeWhxOERuQW1DVEZTQ0xkZnFZ?=
 =?utf-8?B?WXdMUTRsSjh5U3lZektUL0NMalNOaEY0aTVSY3ZmN21mSXQrUFdRVjltenR1?=
 =?utf-8?B?TzhUVndzamNINUJzQUNZNCtZNWkrd2p1aEw2V2JqTzFhdWw2ZFZOWGgrekdE?=
 =?utf-8?B?SFZrYTF0aDJScERYenY0WFc1dkE0WkxMWEZYaE1KNkJpSktJTTFZVG9KNDBi?=
 =?utf-8?B?MjVYWmZvTXE0MzFHUHhIVkJOd05MVnZvWUVZbmNDRE5DbmxWNzFxTFVyTE1n?=
 =?utf-8?B?UWsxYXVydHVSeWVJN0ZwVzVTaDcwWExjVXF2by9mODZTVUJlT3FyWUhWc0dy?=
 =?utf-8?B?eGRZeXZoU2lYeFRoUDY3ZE41TnRxM0JVemJkSURVREErUjAwMzJDdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4bce51a-70b4-42a1-6c0a-08da2446b8c9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 09:58:59.4427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dniJGgykPiU3XtJYj0H/GGIJK9AMVUKrSF/WweAGEI+5inWQIgqJw5S4C6CEsjNtJiPahlgZvjAX2A3jQf4jXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9103

EPT is of no interest when !HVM. While I'm observing gcc11 to fully
eliminate the function, older gcc's DCE looks to not be as good. Aid the
compiler in eliminating the accesses of opt_hap_{2mb,1gb}, which
otherwise cause undefined symbol errors when linking.

While there adjust types.

Fixes: c479415610f0 ("x86/P2M: p2m.c is HVM-only")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -2155,14 +2155,17 @@ static int cf_check intel_iommu_lookup_p
     return 0;
 }
 
-static int __init vtd_ept_page_compatible(struct vtd_iommu *iommu)
+static bool __init vtd_ept_page_compatible(const struct vtd_iommu *iommu)
 {
-    u64 ept_cap, vtd_cap = iommu->cap;
+    uint64_t ept_cap, vtd_cap = iommu->cap;
+
+    if ( !IS_ENABLED(CONFIG_HVM) )
+        return false;
 
     /* EPT is not initialised yet, so we must check the capability in
      * the MSR explicitly rather than use cpu_has_vmx_ept_*() */
     if ( rdmsr_safe(MSR_IA32_VMX_EPT_VPID_CAP, ept_cap) != 0 ) 
-        return 0;
+        return false;
 
     return (ept_has_2mb(ept_cap) && opt_hap_2mb) <= cap_sps_2mb(vtd_cap) &&
            (ept_has_1gb(ept_cap) && opt_hap_1gb) <= cap_sps_1gb(vtd_cap);



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 10:01:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 10:01:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310796.527720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhq6Y-00044t-Nh; Fri, 22 Apr 2022 10:01:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310796.527720; Fri, 22 Apr 2022 10:01:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhq6Y-00044m-KR; Fri, 22 Apr 2022 10:01:34 +0000
Received: by outflank-mailman (input) for mailman id 310796;
 Fri, 22 Apr 2022 10:01:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vZpq=VA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhq6X-00044g-Jt
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 10:01:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2fc634f6-c223-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 12:01:32 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-NV6oev0wMcKeiy0gO3zdcw-1; Fri, 22 Apr 2022 12:01:23 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB7437.eurprd04.prod.outlook.com (2603:10a6:800:1b3::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 10:01:22 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 10:01:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fc634f6-c223-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650621692;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Dwkz+mBkDfhEysjc1Ie8B940Oys83KiklybeJs9lA7M=;
	b=czsIUizmRpw95xSysBRwdLvKUyytve2qGtrLgRHC/0Ib3hV73v2+cQdne0KLBCyXe+RvAq
	nSao0iUqLjjYKcSn5Drsi14L+kbMGXT31Eo1fmOnhre/pyeaegMEooFeURiQzqd/aMIg+f
	uBjEd1Dm9BWUG1EyVx/j+j39A3H0oDI=
X-MC-Unique: NV6oev0wMcKeiy0gO3zdcw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S36AIGGe3yEM05OW1lGbXVy24kAVPGB1kvn3FqyWtUkUVuwT0uIqwbytodu7os1unk2s4fVHvWqaQNZm5Yj69GkIFbFWPCLx/Q6Cbp4RDhhh3JIC6JQ2SVUUhzytqNjEu0VRgyE4qstL4/3t4ug8J8k4n3ZgGw9nRoQKz/Qsb1o7VEhllIy+nE8oPWUTWl0Ae2TqbYwKZ0MLy7WrN+lWkKSV4Ukqq9uzVjTYkk0gbsEMWrEqOWUTQzwnO7VtB6+6Vf9ARc5SKkzFXr4heyKqULgNhbcrLYA6EeU4dpGvPCOdsfAeVFeX0Gy7DY0EKE1SOkzCGjMqlOPLUKqwPxsE9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aBVXcZ82YigjIcWpUdrI8BN27ZedpdUW5T6z9N8NJO4=;
 b=NjJDQufXLu20WCqBvDpisRsA6XMrSqb9P4gwWOoFhyh7CcZnCz2ZsxBWMlMQWeK7HzeK1K4qZOvq3OCbXY9F6VLzysConUfauXgV5bNfQuIKKeuSENhU0VZZYRwuMBya+CItWT0wp3IY5kulFkoDXFmMRh83B1g/KLqbQKBxkP822mhRRpVSBvQ9FROiYxzKt+be/v93PXlKJXDKiM91Fn0RWCZ3YjWefrxSePywZJ2q01A3G0sy0rkdddqJz8OG2/yg7oX/EoaTCVnIhbfi3z7ZwHU+8RvpYegMFOKzGK+wcRUGU6FBphhx5Gj2AR3ltB8B3IfEARzXo83Hu0jmvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8089c126-430f-1c30-68b7-562be0cf6fd6@suse.com>
Date: Fri, 22 Apr 2022 12:01:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220331092717.9023-1-roger.pau@citrix.com>
 <20220331092717.9023-4-roger.pau@citrix.com>
 <0bb48681-a78f-d32e-f989-822dd5e54b70@suse.com>
 <YmF2Zw13O6oaAT0k@Air-de-Roger>
 <b7e3ecbe-6c2e-94f9-58c6-ae49652e6a29@suse.com>
 <YmJ7qr6W7cFkwV6W@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmJ7qr6W7cFkwV6W@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0327.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2ac5616a-72ea-4a61-465a-08da24470e05
X-MS-TrafficTypeDiagnostic: VE1PR04MB7437:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB74372DB24F3A880C72164717B3F79@VE1PR04MB7437.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1lLtlQ0Su/05QCPyf3hAwXt1ISzSGBkHFjg3f4K4LZc6uuyBcDlrlkYvMrSlWAS+tQULVqL2mTj1roL+jw735V9z0rYUI63jPDr5kgC+Lu9UIZRVVkjqD+gyXKpXTKemRKQm77JJyo6GVD2/ZyWU/FsXQKm9FSsD2QI2DkTMOlMBEH71w/UWHl0XyTfKC0q578B3hJ3L9w3Wle1dmFHXVqO+I5/SQDWQ4BcrXSx4CQRb568qEVZr+ai3bp6o3FW8qqBmQVXPCjtzJdM/FUBjN0HRvSZI1jZ3cPR+LwIB6eVeO15ykCwYt8RoAVQDrOiK/K4Ktj1Efjx6IaUHpB6HricR7tbYKNGCqQbadHNQyl6vnwzwdR4ENPsAHajCiz+BaR9AjHyELTRTfRIqiYxRnA0M/ux9TCy4tCYpXDhcXXg9orxewmfpWd3zREZeDB5b6APkoJQ+1XQCFvmw5eM+4qbWD7B8WGh5amRrqNBIuUAUGMK8Qm0v4WWgUy9t31hVNKaqmgH29xdzIhVhiEWWQFU8Ecmjdb4MYFW1EoZ1ARPk8YTgc6m+vraF+iMTH34iGTM0MmJn+7LkWPaz3zxfSJRVT5HgKvlW4eBL1PQN/k1yOcdwkIg9aPVsgtg//1VA6sQXxGC6R/4Bodoq5WsD6ay0MuYfkgJ6q6Ujrx4Eo9/X+JuJiRR3GdSIQXqzez/ovYf7bn0/Mp/VWmaYIXZw/6pYn4oq2YswBbW84wPiPZ8Sm2YpDScdF9dtxLUbTOl7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(83380400001)(2616005)(8936002)(66476007)(4326008)(54906003)(8676002)(86362001)(6916009)(2906002)(316002)(31696002)(53546011)(6506007)(38100700002)(5660300002)(6486002)(508600001)(6512007)(186003)(36756003)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Oi4WHz2Iza09xDL8ekbAbwi/0sSfSB3RjtLPWAgg7cZjL/Hmqbgu6qovFuXU?=
 =?us-ascii?Q?rMXY5iKMEmbHty0WrG6aEDDamzu4+CkHSEwMv1ATcGtTvTPczj3b4PfTDrwK?=
 =?us-ascii?Q?jIbAXfVUZt/1UkpcHJj8vSwFUy7wRotryB5dLAgs+3yi21EUEgOyJNSHv10F?=
 =?us-ascii?Q?EtaqAV0gk0XzhqGptt8eSFExl/lYcEM9d4KiMrO7COZ9HqADF6jNvP8YhPdl?=
 =?us-ascii?Q?Bdixvs5/5XrtlpmmqRC04ftTJA32Il7MdtjTjsKpQqCKjrtZp8C8SEx4N9NW?=
 =?us-ascii?Q?aChoUuTyXrp/YKg0A7ayrJW7REsdNUJcyB3TTDTbBT+no9OWaqWrM/Cpxn43?=
 =?us-ascii?Q?knG2uOvMcChna+M/ddFvTalRy4z5rBUjXQvKqL8jbyLB9AJYr4S9q5OKcGZs?=
 =?us-ascii?Q?092N7k5s+tkgzXuTnMfQ40KuypNKU6Z+QiIyYq6n6VAmIgfe5rN84T5CokPh?=
 =?us-ascii?Q?qN4fSFYYaYkOMpOhVDRFJecK0fE7hcmnuCcIrqIl3NdB2CW+Rj1GjoVWZBy+?=
 =?us-ascii?Q?Zpor2n1WoR3HLuHMhlLmJNRwbKTLkU4la+RP22ZwLtVZP1yZ9sBD0LwEvTqi?=
 =?us-ascii?Q?TpgDpp/Mztf7t318gyM2MNORW/rrbMZqdgA/1Jfi8LDYP8msUQDLiC+F9Ie0?=
 =?us-ascii?Q?//WM8+vXGxQF/iZKQow2JFSs2Kvog2qlB35zCZQZFTGHyj/iTeVbo+p1s7T5?=
 =?us-ascii?Q?G8gSKlLRfqXCSS/S4gVGGmlt5rxgDCc4hxtYSR9rs0hkwyUzgFA4SwBJFzAU?=
 =?us-ascii?Q?snquXn+at9rFXH/fde95jB1Hn0W28ZzfZZ7fwRyVfpsM55q31+7Xd1B/j2zG?=
 =?us-ascii?Q?X/mP/4lU3+rneS8uFisGKcyIAsJvrqt7ARQDvj2wjpZXuMiVn0N/PUYJr3ke?=
 =?us-ascii?Q?dDPz0CQY+TXLYb2P8sR/0AfiTngbMhMrishhDge11CZZgnEKC3BKNW1v1YAj?=
 =?us-ascii?Q?1zb1RWndr63p3pzuSIv4H1cgr1+3oODuY/da9IT8z8SgkhrMjMI+sKvTgRHo?=
 =?us-ascii?Q?r1pPDbj/yRbwLdsLeCgtYMs+lDkONT6oZ3WhZ81E+HvlIfPCAN/ewutnNxN9?=
 =?us-ascii?Q?fM1jMInSSY5TJqDQ9QWbehLBQe+nt4orAm5Vf+eHyWuY8DtqFhExTjKuN0US?=
 =?us-ascii?Q?ekxsefKKJX1q+FP67jxbPVhhzh5quQ8oQ6zOJmOELRhYiuy1Psgq5bsxUxzq?=
 =?us-ascii?Q?cScZP8KsADnWCJIpfM3VwyS5H0F8atqWJ+egROc/l4/U2jOG/owCTPnJw5kt?=
 =?us-ascii?Q?gxgQtCGhgjQQFYrrKc98z5n1FxePPjoikSlTIaLFlYpSYDTsishiceVcrvZX?=
 =?us-ascii?Q?i99sAchZXbAyl8GKIdukqaVQtcWKC973KxAsM9LmcVtUMeAP/oN0eoSuC+yW?=
 =?us-ascii?Q?GobwF2qsQa28BPM+97U5oOtvK6inqYOnYk2jaMjUtxJ78wCWl8FvZpimkASM?=
 =?us-ascii?Q?RBT3ulzV7pg6UTyPbtr6F36DZfD3xryjHDoMRWyJ7qQxqNoLeHaO+E3stbfq?=
 =?us-ascii?Q?uGIj3HPsH3yA/MkCcd8LcaRVmeHrTxwiRo0Vcdyw8Wths4Zdh/HWeUgDd/gc?=
 =?us-ascii?Q?eLTZ+Ko5VNgY7AE27J5eHnXSOHwD60+fxa3si3/YELNGMBFHM2ObyHMIdddN?=
 =?us-ascii?Q?GBQmaNq4OeV0pFp76iv0niMSK6e/J95b6ZxVW7OO4qBJUt1e8GBhTYZGEn/x?=
 =?us-ascii?Q?Y/r+raKisETUtYWK66A6h98Al7JFnKeRzITDiHu0XFH8Ud2bNn1R7stlRzVs?=
 =?us-ascii?Q?/gcSrhWMuQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ac5616a-72ea-4a61-465a-08da24470e05
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 10:01:22.5506
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KNSNKoCjovvQUJ8qUrm83rbpfsqE1jw60Ii9RxTsqDFCa+OZGQVsMYkw+UbAswbtn83vs0Eum+nsUqP1s2K8vQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7437

On 22.04.2022 11:55, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 21, 2022 at 05:27:18PM +0200, Jan Beulich wrote:
>> On 21.04.2022 17:21, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Apr 21, 2022 at 11:50:16AM +0200, Jan Beulich wrote:
>>>> On 31.03.2022 11:27, Roger Pau Monne wrote:
>>>>> Expose VIRT_SSBD to guests if the hardware supports setting SSBD in
>>>>> the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU
>>>>> families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSB=
D
>>>>> allows for an unified way of exposing SSBD support to guests on AMD
>>>>> hardware that's compatible migration wise, regardless of what
>>>>> underlying mechanism is used to set SSBD.
>>>>>
>>>>> Note that on AMD Family 17h (Zen 1) the value of SSBD in LS_CFG is
>>>>> shared between threads on the same core, so there's extra logic in
>>>>> order to synchronize the value and have SSBD set as long as one of th=
e
>>>>> threads in the core requires it to be set. Such logic also requires
>>>>> extra storage for each thread state, which is allocated at
>>>>> initialization time.
>>>>
>>>> So where exactly is the boundary? If I'm not mistaken Zen2 is also
>>>> Fam17 (and only Zen3 is Fam19), yet here and elsewhere you look to
>>>> take Zen1 =3D=3D Fam17.
>>>
>>> Right, but Zen2 already has AMD_SSBD (ie: SPEC_CTRL), so it's not
>>> using this logic.
>>>
>>> The AMD whitepaper is more clear about this: any Fam17h processor that
>>> is using the non-architectural MSRs to set SSBD and has more than 1
>>> logical processor for each logical core must synchronize the setting
>>> of SSBD.
>>>
>>> I think just dropping the mention of Zen 1 in the commit message
>>> should remove your concerns?
>>
>> Or keep it, but qualify it by saying that Zen2 isn't expected to take
>> this path because of having SSBD. But iirc SSBD was introduced to
>> Zen2 only by a ucode update, so such a description should not be wrong
>> wrt such not-up-to-date systems.
>=20
> FTAOD I've worded this as:
>=20
> "Note that on AMD Family 17h and Hygon Family 18h processors the value
> of SSBD in LS_CFG is shared between threads on the same core, so
> there's extra logic in order to synchronize the value and have SSBD
> set as long as one of the threads in the core requires it to be set.
> Such logic also requires extra storage for each thread state, which is
> allocated at initialization time."

Thanks.

> Which I think is correct in all cases.  Iff Zen2 was to resort to
> using the non-architectural way of setting SSBD (if that's even
> possible) it should synchronize it between threads according to my
> read of the AMD whitepaper.
>=20
> I've also added handling for Hygon Fam18h, seeing as those also make
> use of the non-architectural way of setting SSBD.

Right, better be on the safe side.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 10:35:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 10:35:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310805.527731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhqdb-0000UJ-EV; Fri, 22 Apr 2022 10:35:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310805.527731; Fri, 22 Apr 2022 10:35:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhqdb-0000UC-BA; Fri, 22 Apr 2022 10:35:43 +0000
Received: by outflank-mailman (input) for mailman id 310805;
 Fri, 22 Apr 2022 10:35:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hyV/=VA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nhqdZ-0000U6-MW
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 10:35:42 +0000
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com
 [2a00:1450:4864:20::52a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3d62de4-c227-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 12:35:39 +0200 (CEST)
Received: by mail-ed1-x52a.google.com with SMTP id y21so3008520edo.2
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 03:35:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3d62de4-c227-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=EzG1s9kf1XU0FJ5iNx5OiHIWUYKz1mxwT2mDLJVLVCQ=;
        b=mJq648sy/0rhD5M4vih/thTChIH6ujM5Zxu2D0xdYhogNN3iJdb2kTk27G0Gc8m7fo
         f6/+zImrGQDprhn06yLjNwZ+KSoVCeNoYre+82LdWUheVBoFMyQSvso9pxzSP+eFhZky
         Ssc6VNeGaGU1GfuXYtlPiJgsg24Th21j+pXjtoomro4XW8K+hUa+fIV6vPYBMeTHMYbz
         a6MYN8T2VTmHr4776E+8BZgrm1MPHsWLGzTNrlbFF3IOkCq4pEQVIoMeGTYOo043EfUx
         UkHMuKQ6/AqKODk5+OenaWII6ckaknD3+NEH2rxZm/XFitErEqsrWpa3vdVYXKgx9yUT
         uL9A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=EzG1s9kf1XU0FJ5iNx5OiHIWUYKz1mxwT2mDLJVLVCQ=;
        b=BCfhKKTLbe25Q0a5FsO850d8TZdOCtmWlJyP8MeYbqdkizPjf5D8IoUWnOyFS9AmkL
         D0EIGMB6/d/MLRHFrOygcQAAjDayaauGA7VFJHcAr4MaJoaJ6dUOXRUvUo72c+5VK5Kt
         yt+fxWl/4sX1yFDULrPGSBzmlz1kXviTaZ4Rr5JSEr1LPqiIDSIVkBgMkqzgxKyN9BM7
         aPwfLY7N1JHSJa3wVeS6vKzmegWvYKLpqsZjkuM0gUk2z5BBKcc/mY3m2d7t/F0Xgi3Q
         6WZ1z9tARlHwBOixeUkP6skzPmh0X50mBGlZrVypdXsZWz9W58r5v4/pmw6PsHhh02Xm
         Gsow==
X-Gm-Message-State: AOAM532SS7Rk1zxP3/bvUgZTQsGC1+1DqJm9hlMblsu6Jd58Sdf/hNZV
	kqvYcIRDoI9xEdinYxCMRC9uvMfGMmgVbcnKFTk=
X-Google-Smtp-Source: ABdhPJygX1GqdCXNBfb90nG3KhUB9nMr8FATI73NaXLStLfYfMahx0rbepp3B+Nvi2vHy+y3N/VPF/OAvTPD6Ed/7tI=
X-Received: by 2002:a05:6402:1707:b0:41d:9794:6421 with SMTP id
 y7-20020a056402170700b0041d97946421mr4049610edu.212.1650623738832; Fri, 22
 Apr 2022 03:35:38 -0700 (PDT)
MIME-Version: 1.0
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-3-git-send-email-olekstysh@gmail.com> <VI1PR08MB3056B18C179244F174F0952F92F79@VI1PR08MB3056.eurprd08.prod.outlook.com>
In-Reply-To: <VI1PR08MB3056B18C179244F174F0952F92F79@VI1PR08MB3056.eurprd08.prod.outlook.com>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Fri, 22 Apr 2022 13:34:48 +0300
Message-ID: <CAPD2p-mU-NN2xrC4DT7Nu3o17gq+SrcJO8JqehKA8e+d8Ad+RA@mail.gmail.com>
Subject: Re: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
To: Jiamei Xie <Jiamei.Xie@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Julien Grall <Julien.Grall@arm.com>, 
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Bertrand Marquis <Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Henry Wang <Henry.Wang@arm.com>, Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Content-Type: multipart/alternative; boundary="0000000000009c6c3c05dd3bc9a7"

--0000000000009c6c3c05dd3bc9a7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 22, 2022 at 5:43 AM Jiamei Xie <Jiamei.Xie@arm.com> wrote:

> Hi Oleksandr,
>

Hi Jiamei

[Sorry for the possible format issues]



>
>  I am happy to keep my T-b tag.  I have tested this latest patch series
> and it works.


Thank you for the testing and confirmation!



>
>
> Regards,
> Jiamei Xie
>
> > -----Original Message-----
> > From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> > Oleksandr Tyshchenko
> > Sent: 2022=E5=B9=B44=E6=9C=889=E6=97=A5 2:21
> > To: xen-devel@lists.xenproject.org
> > Cc: Julien Grall <Julien.Grall@arm.com>; Wei Liu <wl@xen.org>; Anthony
> > PERARD <anthony.perard@citrix.com>; Juergen Gross <jgross@suse.com>;
> > Stefano Stabellini <sstabellini@kernel.org>; Julien Grall <
> julien@xen.org>;
> > Bertrand Marquis <Bertrand.Marquis@arm.com>; Volodymyr Babchuk
> > <Volodymyr_Babchuk@epam.com>; Jiamei Xie <Jiamei.Xie@arm.com>;
> > Henry Wang <Henry.Wang@arm.com>; Oleksandr Tyshchenko
> > <oleksandr_tyshchenko@epam.com>
> > Subject: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on A=
rm
> >
> > From: Julien Grall <julien.grall@arm.com>
> >
> > This patch introduces helpers to allocate Virtio MMIO params
> > (IRQ and memory region) and create specific device node in
> > the Guest device-tree with allocated params. In order to deal
> > with multiple Virtio devices, reserve corresponding ranges.
> > For now, we reserve 1MB for memory regions and 10 SPIs.
> >
> > As these helpers should be used for every Virtio device attached
> > to the Guest, call them for Virtio disk(s).
> >
> > Please note, with statically allocated Virtio IRQs there is
> > a risk of a clash with a physical IRQs of passthrough devices.
> > For the first version, it's fine, but we should consider allocating
> > the Virtio IRQs automatically. Thankfully, we know in advance which
> > IRQs will be used for passthrough to be able to choose non-clashed
> > ones.
> >
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > Tested-by: Jiamei Xie <Jiamei.xie@arm.com>
> > Reviewed-by: Henry Wang <Henry.Wang@arm.com>
> > ---
> > @Jiamei, @Henry I decided to leave your T-b and R-b tags with the minor
> > change I made, are you still happy with that?
> >
> > s/if (disk->virtio)/if (disk->protocol =3D=3D
> LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
> >
> > Please note, this is a split/cleanup/hardening of Julien's PoC:
> > "Add support for Guest IO forwarding to a device emulator"
> >
> > Changes RFC -> V1:
> >    - was squashed with:
> >      "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correc=
t
> way"
> >      "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into
> virtio-
> > mmio device node"
> >      "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT"
> >    - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h
> >
> > Changes V1 -> V2:
> >    - update the author of a patch
> >
> > Changes V2 -> V3:
> >    - no changes
> >
> > Changes V3 -> V4:
> >    - no changes
> >
> > Changes V4 -> V5:
> >    - split the changes, change the order of the patches
> >    - drop an extra "virtio" configuration option
> >    - update patch description
> >    - use CONTAINER_OF instead of own implementation
> >    - reserve ranges for Virtio MMIO params and put them
> >      in correct location
> >    - create helpers to allocate Virtio MMIO params, add
> >      corresponding sanity-=D1=81hecks
> >    - add comment why MMIO size 0x200 is chosen
> >    - update debug print
> >    - drop Wei's T-b
> >
> > Changes V5 -> V6:
> >    - rebase on current staging
> >
> > Changes V6 -> V7:
> >    - rebase on current staging
> >    - add T-b and R-b tags
> >    - update according to the recent changes to
> >      "libxl: Add support for Virtio disk configuration"
> > ---
> >  tools/libs/light/libxl_arm.c  | 131
> > +++++++++++++++++++++++++++++++++++++++++-
> >  xen/include/public/arch-arm.h |   7 +++
> >  2 files changed, 136 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.=
c
> > index eef1de0..8132a47 100644
> > --- a/tools/libs/light/libxl_arm.c
> > +++ b/tools/libs/light/libxl_arm.c
> > @@ -8,6 +8,56 @@
> >  #include <assert.h>
> >  #include <xen/device_tree_defs.h>
> >
> > +/*
> > + * There is no clear requirements for the total size of Virtio MMIO
> region.
> > + * The size of control registers is 0x100 and device-specific
> configuration
> > + * registers starts at the offset 0x100, however it's size depends on
> the
> > device
> > + * and the driver. Pick the biggest known size at the moment to cover
> most
> > + * of the devices (also consider allowing the user to configure the
> size via
> > + * config file for the one not conforming with the proposed value).
> > + */
> > +#define VIRTIO_MMIO_DEV_SIZE   xen_mk_ullong(0x200)
> > +
> > +static uint64_t virtio_mmio_base;
> > +static uint32_t virtio_mmio_irq;
> > +
> > +static void init_virtio_mmio_params(void)
> > +{
> > +    virtio_mmio_base =3D GUEST_VIRTIO_MMIO_BASE;
> > +    virtio_mmio_irq =3D GUEST_VIRTIO_MMIO_SPI_FIRST;
> > +}
> > +
> > +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc)
> > +{
> > +    uint64_t base =3D virtio_mmio_base;
> > +
> > +    /* Make sure we have enough reserved resources */
> > +    if ((virtio_mmio_base + VIRTIO_MMIO_DEV_SIZE >
> > +        GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) {
> > +        LOG(ERROR, "Ran out of reserved range for Virtio MMIO BASE
> > 0x%"PRIx64"\n",
> > +            virtio_mmio_base);
> > +        return 0;
> > +    }
> > +    virtio_mmio_base +=3D VIRTIO_MMIO_DEV_SIZE;
> > +
> > +    return base;
> > +}
> > +
> > +static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc)
> > +{
> > +    uint32_t irq =3D virtio_mmio_irq;
> > +
> > +    /* Make sure we have enough reserved resources */
> > +    if (virtio_mmio_irq > GUEST_VIRTIO_MMIO_SPI_LAST) {
> > +        LOG(ERROR, "Ran out of reserved range for Virtio MMIO IRQ %u\n=
",
> > +            virtio_mmio_irq);
> > +        return 0;
> > +    }
> > +    virtio_mmio_irq++;
> > +
> > +    return irq;
> > +}
> > +
> >  static const char *gicv_to_string(libxl_gic_version gic_version)
> >  {
> >      switch (gic_version) {
> > @@ -26,8 +76,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
> >  {
> >      uint32_t nr_spis =3D 0;
> >      unsigned int i;
> > -    uint32_t vuart_irq;
> > -    bool vuart_enabled =3D false;
> > +    uint32_t vuart_irq, virtio_irq =3D 0;
> > +    bool vuart_enabled =3D false, virtio_enabled =3D false;
> >
> >      /*
> >       * If pl011 vuart is enabled then increment the nr_spis to allow
> allocation
> > @@ -39,6 +89,35 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
> >          vuart_enabled =3D true;
> >      }
> >
> > +    /*
> > +     * Virtio MMIO params are non-unique across the whole system and
> > must be
> > +     * initialized for every new guest.
> > +     */
> > +    init_virtio_mmio_params();
> > +    for (i =3D 0; i < d_config->num_disks; i++) {
> > +        libxl_device_disk *disk =3D &d_config->disks[i];
> > +
> > +        if (disk->protocol =3D=3D LIBXL_DISK_PROTOCOL_VIRTIO_MMIO) {
> > +            disk->base =3D alloc_virtio_mmio_base(gc);
> > +            if (!disk->base)
> > +                return ERROR_FAIL;
> > +
> > +            disk->irq =3D alloc_virtio_mmio_irq(gc);
> > +            if (!disk->irq)
> > +                return ERROR_FAIL;
> > +
> > +            if (virtio_irq < disk->irq)
> > +                virtio_irq =3D disk->irq;
> > +            virtio_enabled =3D true;
> > +
> > +            LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %=
u
> > BASE 0x%"PRIx64,
> > +                disk->vdev, disk->irq, disk->base);
> > +        }
> > +    }
> > +
> > +    if (virtio_enabled)
> > +        nr_spis +=3D (virtio_irq - 32) + 1;
> > +
> >      for (i =3D 0; i < d_config->b_info.num_irqs; i++) {
> >          uint32_t irq =3D d_config->b_info.irqs[i];
> >          uint32_t spi;
> > @@ -58,6 +137,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc=
,
> >              return ERROR_FAIL;
> >          }
> >
> > +        /* The same check as for vpl011 */
> > +        if (virtio_enabled &&
> > +           (irq >=3D GUEST_VIRTIO_MMIO_SPI_FIRST && irq <=3D virtio_ir=
q)) {
> > +            LOG(ERROR, "Physical IRQ %u conflicting with Virtio MMIO I=
RQ
> > range\n", irq);
> > +            return ERROR_FAIL;
> > +        }
> > +
> >          if (irq < 32)
> >              continue;
> >
> > @@ -787,6 +873,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt=
,
> >      return 0;
> >  }
> >
> > +
> > +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
> > +                                 uint64_t base, uint32_t irq)
> > +{
> > +    int res;
> > +    gic_interrupt intr;
> > +    /* Placeholder for virtio@ + a 64-bit number + \0 */
> > +    char buf[24];
> > +
> > +    snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base);
> > +    res =3D fdt_begin_node(fdt, buf);
> > +    if (res) return res;
> > +
> > +    res =3D fdt_property_compat(gc, fdt, 1, "virtio,mmio");
> > +    if (res) return res;
> > +
> > +    res =3D fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> > GUEST_ROOT_SIZE_CELLS,
> > +                            1, base, VIRTIO_MMIO_DEV_SIZE);
> > +    if (res) return res;
> > +
> > +    set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING);
> > +    res =3D fdt_property_interrupts(gc, fdt, &intr, 1);
> > +    if (res) return res;
> > +
> > +    res =3D fdt_property(fdt, "dma-coherent", NULL, 0);
> > +    if (res) return res;
> > +
> > +    res =3D fdt_end_node(fdt);
> > +    if (res) return res;
> > +
> > +    return 0;
> > +}
> > +
> >  static const struct arch_info *get_arch_info(libxl__gc *gc,
> >                                               const struct xc_dom_image
> *dom)
> >  {
> > @@ -988,6 +1107,7 @@ static int libxl__prepare_dtb(libxl__gc *gc,
> > libxl_domain_config *d_config,
> >      size_t fdt_size =3D 0;
> >      int pfdt_size =3D 0;
> >      libxl_domain_build_info *const info =3D &d_config->b_info;
> > +    unsigned int i;
> >
> >      const libxl_version_info *vers;
> >      const struct arch_info *ainfo;
> > @@ -1094,6 +1214,13 @@ next_resize:
> >          if (d_config->num_pcidevs)
> >              FDT( make_vpci_node(gc, fdt, ainfo, dom) );
> >
> > +        for (i =3D 0; i < d_config->num_disks; i++) {
> > +            libxl_device_disk *disk =3D &d_config->disks[i];
> > +
> > +            if (disk->protocol =3D=3D LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)
> > +                FDT( make_virtio_mmio_node(gc, fdt, disk->base,
> disk->irq) );
> > +        }
> > +
> >          if (pfdt)
> >              FDT( copy_partial_fdt(gc, fdt, pfdt) );
> >
> > diff --git a/xen/include/public/arch-arm.h
> b/xen/include/public/arch-arm.h
> > index ab05fe1..c8b6058 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -407,6 +407,10 @@ typedef uint64_t xen_callback_t;
> >
> >  /* Physical Address Space */
> >
> > +/* Virtio MMIO mappings */
> > +#define GUEST_VIRTIO_MMIO_BASE   xen_mk_ullong(0x02000000)
> > +#define GUEST_VIRTIO_MMIO_SIZE   xen_mk_ullong(0x00100000)
> > +
> >  /*
> >   * vGIC mappings: Only one set of mapping is used by the guest.
> >   * Therefore they can overlap.
> > @@ -493,6 +497,9 @@ typedef uint64_t xen_callback_t;
> >
> >  #define GUEST_VPL011_SPI        32
> >
> > +#define GUEST_VIRTIO_MMIO_SPI_FIRST   33
> > +#define GUEST_VIRTIO_MMIO_SPI_LAST    43
> > +
> >  /* PSCI functions */
> >  #define PSCI_cpu_suspend 0
> >  #define PSCI_cpu_off     1
> > --
> > 2.7.4
> >
>
>

--=20
Regards,

Oleksandr Tyshchenko

--0000000000009c6c3c05dd3bc9a7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Fri, Apr 22, 2022 at 5:43 AM Jiame=
i Xie &lt;<a href=3D"mailto:Jiamei.Xie@arm.com">Jiamei.Xie@arm.com</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Oleksa=
ndr,<br></blockquote><div><br></div><div>Hi=C2=A0Jiamei</div><div><br></div=
><div>[Sorry for the possible format issues]</div><div><br></div><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
=C2=A0I am happy to keep my T-b tag.=C2=A0 I have tested this latest patch =
series and it works.</blockquote><div><br></div><div>Thank you for the test=
ing and confirmation!</div><div><br></div><div>=C2=A0</div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex"> <br>
<br>
Regards,<br>
Jiamei Xie<br>
<br>
&gt; -----Original Message-----<br>
&gt; From: Xen-devel &lt;<a href=3D"mailto:xen-devel-bounces@lists.xenproje=
ct.org" target=3D"_blank">xen-devel-bounces@lists.xenproject.org</a>&gt; On=
 Behalf Of<br>
&gt; Oleksandr Tyshchenko<br>
&gt; Sent: 2022=E5=B9=B44=E6=9C=889=E6=97=A5 2:21<br>
&gt; To: <a href=3D"mailto:xen-devel@lists.xenproject.org" target=3D"_blank=
">xen-devel@lists.xenproject.org</a><br>
&gt; Cc: Julien Grall &lt;<a href=3D"mailto:Julien.Grall@arm.com" target=3D=
"_blank">Julien.Grall@arm.com</a>&gt;; Wei Liu &lt;<a href=3D"mailto:wl@xen=
.org" target=3D"_blank">wl@xen.org</a>&gt;; Anthony<br>
&gt; PERARD &lt;<a href=3D"mailto:anthony.perard@citrix.com" target=3D"_bla=
nk">anthony.perard@citrix.com</a>&gt;; Juergen Gross &lt;<a href=3D"mailto:=
jgross@suse.com" target=3D"_blank">jgross@suse.com</a>&gt;;<br>
&gt; Stefano Stabellini &lt;<a href=3D"mailto:sstabellini@kernel.org" targe=
t=3D"_blank">sstabellini@kernel.org</a>&gt;; Julien Grall &lt;<a href=3D"ma=
ilto:julien@xen.org" target=3D"_blank">julien@xen.org</a>&gt;;<br>
&gt; Bertrand Marquis &lt;<a href=3D"mailto:Bertrand.Marquis@arm.com" targe=
t=3D"_blank">Bertrand.Marquis@arm.com</a>&gt;; Volodymyr Babchuk<br>
&gt; &lt;<a href=3D"mailto:Volodymyr_Babchuk@epam.com" target=3D"_blank">Vo=
lodymyr_Babchuk@epam.com</a>&gt;; Jiamei Xie &lt;<a href=3D"mailto:Jiamei.X=
ie@arm.com" target=3D"_blank">Jiamei.Xie@arm.com</a>&gt;;<br>
&gt; Henry Wang &lt;<a href=3D"mailto:Henry.Wang@arm.com" target=3D"_blank"=
>Henry.Wang@arm.com</a>&gt;; Oleksandr Tyshchenko<br>
&gt; &lt;<a href=3D"mailto:oleksandr_tyshchenko@epam.com" target=3D"_blank"=
>oleksandr_tyshchenko@epam.com</a>&gt;<br>
&gt; Subject: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on =
Arm<br>
&gt; <br>
&gt; From: Julien Grall &lt;<a href=3D"mailto:julien.grall@arm.com" target=
=3D"_blank">julien.grall@arm.com</a>&gt;<br>
&gt; <br>
&gt; This patch introduces helpers to allocate Virtio MMIO params<br>
&gt; (IRQ and memory region) and create specific device node in<br>
&gt; the Guest device-tree with allocated params. In order to deal<br>
&gt; with multiple Virtio devices, reserve corresponding ranges.<br>
&gt; For now, we reserve 1MB for memory regions and 10 SPIs.<br>
&gt; <br>
&gt; As these helpers should be used for every Virtio device attached<br>
&gt; to the Guest, call them for Virtio disk(s).<br>
&gt; <br>
&gt; Please note, with statically allocated Virtio IRQs there is<br>
&gt; a risk of a clash with a physical IRQs of passthrough devices.<br>
&gt; For the first version, it&#39;s fine, but we should consider allocatin=
g<br>
&gt; the Virtio IRQs automatically. Thankfully, we know in advance which<br=
>
&gt; IRQs will be used for passthrough to be able to choose non-clashed<br>
&gt; ones.<br>
&gt; <br>
&gt; Signed-off-by: Julien Grall &lt;<a href=3D"mailto:julien.grall@arm.com=
" target=3D"_blank">julien.grall@arm.com</a>&gt;<br>
&gt; Signed-off-by: Oleksandr Tyshchenko &lt;<a href=3D"mailto:oleksandr_ty=
shchenko@epam.com" target=3D"_blank">oleksandr_tyshchenko@epam.com</a>&gt;<=
br>
&gt; Tested-by: Jiamei Xie &lt;<a href=3D"mailto:Jiamei.xie@arm.com" target=
=3D"_blank">Jiamei.xie@arm.com</a>&gt;<br>
&gt; Reviewed-by: Henry Wang &lt;<a href=3D"mailto:Henry.Wang@arm.com" targ=
et=3D"_blank">Henry.Wang@arm.com</a>&gt;<br>
&gt; ---<br>
&gt; @Jiamei, @Henry I decided to leave your T-b and R-b tags with the mino=
r<br>
&gt; change I made, are you still happy with that?<br>
&gt; <br>
&gt; s/if (disk-&gt;virtio)/if (disk-&gt;protocol =3D=3D LIBXL_DISK_PROTOCO=
L_VIRTIO_MMIO)<br>
&gt; <br>
&gt; Please note, this is a split/cleanup/hardening of Julien&#39;s PoC:<br=
>
&gt; &quot;Add support for Guest IO forwarding to a device emulator&quot;<b=
r>
&gt; <br>
&gt; Changes RFC -&gt; V1:<br>
&gt;=C2=A0 =C2=A0 - was squashed with:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &quot;[RFC PATCH V1 09/12] libxl: Handle virtio-mm=
io irq in more correct way&quot;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &quot;[RFC PATCH V1 11/12] libxl: Insert &quot;dma=
-coherent&quot; property into virtio-<br>
&gt; mmio device node&quot;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &quot;[RFC PATCH V1 12/12] libxl: Fix duplicate me=
mory node in DT&quot;<br>
&gt;=C2=A0 =C2=A0 - move VirtIO MMIO #define-s to xen/include/public/arch-a=
rm.h<br>
&gt; <br>
&gt; Changes V1 -&gt; V2:<br>
&gt;=C2=A0 =C2=A0 - update the author of a patch<br>
&gt; <br>
&gt; Changes V2 -&gt; V3:<br>
&gt;=C2=A0 =C2=A0 - no changes<br>
&gt; <br>
&gt; Changes V3 -&gt; V4:<br>
&gt;=C2=A0 =C2=A0 - no changes<br>
&gt; <br>
&gt; Changes V4 -&gt; V5:<br>
&gt;=C2=A0 =C2=A0 - split the changes, change the order of the patches<br>
&gt;=C2=A0 =C2=A0 - drop an extra &quot;virtio&quot; configuration option<b=
r>
&gt;=C2=A0 =C2=A0 - update patch description<br>
&gt;=C2=A0 =C2=A0 - use CONTAINER_OF instead of own implementation<br>
&gt;=C2=A0 =C2=A0 - reserve ranges for Virtio MMIO params and put them<br>
&gt;=C2=A0 =C2=A0 =C2=A0 in correct location<br>
&gt;=C2=A0 =C2=A0 - create helpers to allocate Virtio MMIO params, add<br>
&gt;=C2=A0 =C2=A0 =C2=A0 corresponding sanity-=D1=81hecks<br>
&gt;=C2=A0 =C2=A0 - add comment why MMIO size 0x200 is chosen<br>
&gt;=C2=A0 =C2=A0 - update debug print<br>
&gt;=C2=A0 =C2=A0 - drop Wei&#39;s T-b<br>
&gt; <br>
&gt; Changes V5 -&gt; V6:<br>
&gt;=C2=A0 =C2=A0 - rebase on current staging<br>
&gt; <br>
&gt; Changes V6 -&gt; V7:<br>
&gt;=C2=A0 =C2=A0 - rebase on current staging<br>
&gt;=C2=A0 =C2=A0 - add T-b and R-b tags<br>
&gt;=C2=A0 =C2=A0 - update according to the recent changes to<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &quot;libxl: Add support for Virtio disk configura=
tion&quot;<br>
&gt; ---<br>
&gt;=C2=A0 tools/libs/light/libxl_arm.c=C2=A0 | 131<br>
&gt; +++++++++++++++++++++++++++++++++++++++++-<br>
&gt;=C2=A0 xen/include/public/arch-arm.h |=C2=A0 =C2=A07 +++<br>
&gt;=C2=A0 2 files changed, 136 insertions(+), 2 deletions(-)<br>
&gt; <br>
&gt; diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm=
.c<br>
&gt; index eef1de0..8132a47 100644<br>
&gt; --- a/tools/libs/light/libxl_arm.c<br>
&gt; +++ b/tools/libs/light/libxl_arm.c<br>
&gt; @@ -8,6 +8,56 @@<br>
&gt;=C2=A0 #include &lt;assert.h&gt;<br>
&gt;=C2=A0 #include &lt;xen/device_tree_defs.h&gt;<br>
&gt; <br>
&gt; +/*<br>
&gt; + * There is no clear requirements for the total size of Virtio MMIO r=
egion.<br>
&gt; + * The size of control registers is 0x100 and device-specific configu=
ration<br>
&gt; + * registers starts at the offset 0x100, however it&#39;s size depend=
s on the<br>
&gt; device<br>
&gt; + * and the driver. Pick the biggest known size at the moment to cover=
 most<br>
&gt; + * of the devices (also consider allowing the user to configure the s=
ize via<br>
&gt; + * config file for the one not conforming with the proposed value).<b=
r>
&gt; + */<br>
&gt; +#define VIRTIO_MMIO_DEV_SIZE=C2=A0 =C2=A0xen_mk_ullong(0x200)<br>
&gt; +<br>
&gt; +static uint64_t virtio_mmio_base;<br>
&gt; +static uint32_t virtio_mmio_irq;<br>
&gt; +<br>
&gt; +static void init_virtio_mmio_params(void)<br>
&gt; +{<br>
&gt; +=C2=A0 =C2=A0 virtio_mmio_base =3D GUEST_VIRTIO_MMIO_BASE;<br>
&gt; +=C2=A0 =C2=A0 virtio_mmio_irq =3D GUEST_VIRTIO_MMIO_SPI_FIRST;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc)<br>
&gt; +{<br>
&gt; +=C2=A0 =C2=A0 uint64_t base =3D virtio_mmio_base;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 /* Make sure we have enough reserved resources */<br>
&gt; +=C2=A0 =C2=A0 if ((virtio_mmio_base + VIRTIO_MMIO_DEV_SIZE &gt;<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMI=
O_SIZE)) {<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 LOG(ERROR, &quot;Ran out of reserved rang=
e for Virtio MMIO BASE<br>
&gt; 0x%&quot;PRIx64&quot;\n&quot;,<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 virtio_mmio_base);<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return 0;<br>
&gt; +=C2=A0 =C2=A0 }<br>
&gt; +=C2=A0 =C2=A0 virtio_mmio_base +=3D VIRTIO_MMIO_DEV_SIZE;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 return base;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc)<br>
&gt; +{<br>
&gt; +=C2=A0 =C2=A0 uint32_t irq =3D virtio_mmio_irq;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 /* Make sure we have enough reserved resources */<br>
&gt; +=C2=A0 =C2=A0 if (virtio_mmio_irq &gt; GUEST_VIRTIO_MMIO_SPI_LAST) {<=
br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 LOG(ERROR, &quot;Ran out of reserved rang=
e for Virtio MMIO IRQ %u\n&quot;,<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 virtio_mmio_irq);<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return 0;<br>
&gt; +=C2=A0 =C2=A0 }<br>
&gt; +=C2=A0 =C2=A0 virtio_mmio_irq++;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 return irq;<br>
&gt; +}<br>
&gt; +<br>
&gt;=C2=A0 static const char *gicv_to_string(libxl_gic_version gic_version)=
<br>
&gt;=C2=A0 {<br>
&gt;=C2=A0 =C2=A0 =C2=A0 switch (gic_version) {<br>
&gt; @@ -26,8 +76,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,=
<br>
&gt;=C2=A0 {<br>
&gt;=C2=A0 =C2=A0 =C2=A0 uint32_t nr_spis =3D 0;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 unsigned int i;<br>
&gt; -=C2=A0 =C2=A0 uint32_t vuart_irq;<br>
&gt; -=C2=A0 =C2=A0 bool vuart_enabled =3D false;<br>
&gt; +=C2=A0 =C2=A0 uint32_t vuart_irq, virtio_irq =3D 0;<br>
&gt; +=C2=A0 =C2=A0 bool vuart_enabled =3D false, virtio_enabled =3D false;=
<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 /*<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0* If pl011 vuart is enabled then increment t=
he nr_spis to allow allocation<br>
&gt; @@ -39,6 +89,35 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc=
,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vuart_enabled =3D true;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 }<br>
&gt; <br>
&gt; +=C2=A0 =C2=A0 /*<br>
&gt; +=C2=A0 =C2=A0 =C2=A0* Virtio MMIO params are non-unique across the wh=
ole system and<br>
&gt; must be<br>
&gt; +=C2=A0 =C2=A0 =C2=A0* initialized for every new guest.<br>
&gt; +=C2=A0 =C2=A0 =C2=A0*/<br>
&gt; +=C2=A0 =C2=A0 init_virtio_mmio_params();<br>
&gt; +=C2=A0 =C2=A0 for (i =3D 0; i &lt; d_config-&gt;num_disks; i++) {<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 libxl_device_disk *disk =3D &amp;d_config=
-&gt;disks[i];<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (disk-&gt;protocol =3D=3D LIBXL_DISK_P=
ROTOCOL_VIRTIO_MMIO) {<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 disk-&gt;base =3D alloc_vir=
tio_mmio_base(gc);<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!disk-&gt;base)<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return ERROR_=
FAIL;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 disk-&gt;irq =3D alloc_virt=
io_mmio_irq(gc);<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!disk-&gt;irq)<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return ERROR_=
FAIL;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (virtio_irq &lt; disk-&g=
t;irq)<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 virtio_irq =
=3D disk-&gt;irq;<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 virtio_enabled =3D true;<br=
>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 LOG(DEBUG, &quot;Allocate V=
irtio MMIO params for Vdev %s: IRQ %u<br>
&gt; BASE 0x%&quot;PRIx64,<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 disk-&gt;vdev=
, disk-&gt;irq, disk-&gt;base);<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
&gt; +=C2=A0 =C2=A0 }<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 if (virtio_enabled)<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 nr_spis +=3D (virtio_irq - 32) + 1;<br>
&gt; +<br>
&gt;=C2=A0 =C2=A0 =C2=A0 for (i =3D 0; i &lt; d_config-&gt;b_info.num_irqs;=
 i++) {<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 uint32_t irq =3D d_config-&gt;b_info=
.irqs[i];<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 uint32_t spi;<br>
&gt; @@ -58,6 +137,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *g=
c,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return ERROR_FAIL;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
&gt; <br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* The same check as for vpl011 */<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (virtio_enabled &amp;&amp;<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(irq &gt;=3D GUEST_VIRTIO_MM=
IO_SPI_FIRST &amp;&amp; irq &lt;=3D virtio_irq)) {<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 LOG(ERROR, &quot;Physical I=
RQ %u conflicting with Virtio MMIO IRQ<br>
&gt; range\n&quot;, irq);<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return ERROR_FAIL;<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
&gt; +<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (irq &lt; 32)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;<br>
&gt; <br>
&gt; @@ -787,6 +873,39 @@ static int make_vpci_node(libxl__gc *gc, void *fd=
t,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 return 0;<br>
&gt;=C2=A0 }<br>
&gt; <br>
&gt; +<br>
&gt; +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0uint64_t base, uint32_t ir=
q)<br>
&gt; +{<br>
&gt; +=C2=A0 =C2=A0 int res;<br>
&gt; +=C2=A0 =C2=A0 gic_interrupt intr;<br>
&gt; +=C2=A0 =C2=A0 /* Placeholder for virtio@ + a 64-bit number + \0 */<br=
>
&gt; +=C2=A0 =C2=A0 char buf[24];<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 snprintf(buf, sizeof(buf), &quot;virtio@%&quot;PRIx64, =
base);<br>
&gt; +=C2=A0 =C2=A0 res =3D fdt_begin_node(fdt, buf);<br>
&gt; +=C2=A0 =C2=A0 if (res) return res;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 res =3D fdt_property_compat(gc, fdt, 1, &quot;virtio,mm=
io&quot;);<br>
&gt; +=C2=A0 =C2=A0 if (res) return res;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 res =3D fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_C=
ELLS,<br>
&gt; GUEST_ROOT_SIZE_CELLS,<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1, base, VIRTIO_MMIO_DEV_SIZE);<br>
&gt; +=C2=A0 =C2=A0 if (res) return res;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING);=
<br>
&gt; +=C2=A0 =C2=A0 res =3D fdt_property_interrupts(gc, fdt, &amp;intr, 1);=
<br>
&gt; +=C2=A0 =C2=A0 if (res) return res;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 res =3D fdt_property(fdt, &quot;dma-coherent&quot;, NUL=
L, 0);<br>
&gt; +=C2=A0 =C2=A0 if (res) return res;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 res =3D fdt_end_node(fdt);<br>
&gt; +=C2=A0 =C2=A0 if (res) return res;<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 return 0;<br>
&gt; +}<br>
&gt; +<br>
&gt;=C2=A0 static const struct arch_info *get_arch_info(libxl__gc *gc,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0const struct xc_dom_image *dom)<br>
&gt;=C2=A0 {<br>
&gt; @@ -988,6 +1107,7 @@ static int libxl__prepare_dtb(libxl__gc *gc,<br>
&gt; libxl_domain_config *d_config,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 size_t fdt_size =3D 0;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 int pfdt_size =3D 0;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 libxl_domain_build_info *const info =3D &amp;d_con=
fig-&gt;b_info;<br>
&gt; +=C2=A0 =C2=A0 unsigned int i;<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 const libxl_version_info *vers;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 const struct arch_info *ainfo;<br>
&gt; @@ -1094,6 +1214,13 @@ next_resize:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (d_config-&gt;num_pcidevs)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 FDT( make_vpci_node(gc=
, fdt, ainfo, dom) );<br>
&gt; <br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 for (i =3D 0; i &lt; d_config-&gt;num_dis=
ks; i++) {<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libxl_device_disk *disk =3D=
 &amp;d_config-&gt;disks[i];<br>
&gt; +<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (disk-&gt;protocol =3D=
=3D LIBXL_DISK_PROTOCOL_VIRTIO_MMIO)<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 FDT( make_vir=
tio_mmio_node(gc, fdt, disk-&gt;base, disk-&gt;irq) );<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
&gt; +<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (pfdt)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 FDT( copy_partial_fdt(=
gc, fdt, pfdt) );<br>
&gt; <br>
&gt; diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-a=
rm.h<br>
&gt; index ab05fe1..c8b6058 100644<br>
&gt; --- a/xen/include/public/arch-arm.h<br>
&gt; +++ b/xen/include/public/arch-arm.h<br>
&gt; @@ -407,6 +407,10 @@ typedef uint64_t xen_callback_t;<br>
&gt; <br>
&gt;=C2=A0 /* Physical Address Space */<br>
&gt; <br>
&gt; +/* Virtio MMIO mappings */<br>
&gt; +#define GUEST_VIRTIO_MMIO_BASE=C2=A0 =C2=A0xen_mk_ullong(0x02000000)<=
br>
&gt; +#define GUEST_VIRTIO_MMIO_SIZE=C2=A0 =C2=A0xen_mk_ullong(0x00100000)<=
br>
&gt; +<br>
&gt;=C2=A0 /*<br>
&gt;=C2=A0 =C2=A0* vGIC mappings: Only one set of mapping is used by the gu=
est.<br>
&gt;=C2=A0 =C2=A0* Therefore they can overlap.<br>
&gt; @@ -493,6 +497,9 @@ typedef uint64_t xen_callback_t;<br>
&gt; <br>
&gt;=C2=A0 #define GUEST_VPL011_SPI=C2=A0 =C2=A0 =C2=A0 =C2=A0 32<br>
&gt; <br>
&gt; +#define GUEST_VIRTIO_MMIO_SPI_FIRST=C2=A0 =C2=A033<br>
&gt; +#define GUEST_VIRTIO_MMIO_SPI_LAST=C2=A0 =C2=A0 43<br>
&gt; +<br>
&gt;=C2=A0 /* PSCI functions */<br>
&gt;=C2=A0 #define PSCI_cpu_suspend 0<br>
&gt;=C2=A0 #define PSCI_cpu_off=C2=A0 =C2=A0 =C2=A01<br>
&gt; --<br>
&gt; 2.7.4<br>
&gt; <br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><span style=3D"background-color:rgb(255,255,255)"><font size=
=3D"2"><span style=3D"color:rgb(51,51,51);font-family:Arial,sans-serif">Reg=
ards,</span></font></span></div><div dir=3D"ltr"><br></div><div dir=3D"ltr"=
><div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2">Ol=
eksandr Tyshchenko</font></span></div></div></div></div></div></div></div><=
/div>

--0000000000009c6c3c05dd3bc9a7--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 10:36:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 10:36:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310806.527742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhqds-0000rM-Pi; Fri, 22 Apr 2022 10:36:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310806.527742; Fri, 22 Apr 2022 10:36:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhqds-0000rF-Mc; Fri, 22 Apr 2022 10:36:00 +0000
Received: by outflank-mailman (input) for mailman id 310806;
 Fri, 22 Apr 2022 10:35:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhqdr-0000qR-S2; Fri, 22 Apr 2022 10:35:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhqdr-0007YL-QP; Fri, 22 Apr 2022 10:35:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhqdr-00086N-98; Fri, 22 Apr 2022 10:35:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhqdr-0008DT-8f; Fri, 22 Apr 2022 10:35:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=f0H4BkaQ0+I/ni98bdC9UqF/FpsN8gs3EqtLtydFTZM=; b=BMqANcBiRNd46AhpqNCr5MD8Br
	WOIE36J8HGFFAasXG4B9Mbpuzip0voGBjwdrIyV/XMBegtlyKhLyxOcbSLM/RuchQ2nrLS8Y2LPkd
	n2fcvVMD5qNYJCpr2sGeJrqtH1UUhqNMym7xk2q0f7zNQBC3pwEdr7f4VjpQKIFYPB5E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169615-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169615: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=2306555bf9081ae9979405f96428738807e580d4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 10:35:59 +0000

flight 169615 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169615/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 2306555bf9081ae9979405f96428738807e580d4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   52 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  551 attempts
Testing same since   169610  2022-04-22 04:01:05 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5625 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 10:57:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 10:57:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310818.527753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhqyN-0004E8-Kt; Fri, 22 Apr 2022 10:57:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310818.527753; Fri, 22 Apr 2022 10:57:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhqyN-0004E1-Gi; Fri, 22 Apr 2022 10:57:11 +0000
Received: by outflank-mailman (input) for mailman id 310818;
 Fri, 22 Apr 2022 10:57:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vZpq=VA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhqyL-0004Dv-NP
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 10:57:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3f9961e-c22a-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 12:57:08 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-ibRGHiTZNdG6ENlJzCN1MA-1; Fri, 22 Apr 2022 12:57:05 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4800.eurprd04.prod.outlook.com (2603:10a6:803:5a::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 10:57:04 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 10:57:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3f9961e-c22a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650625027;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=50ko0r9Z9sZripDqhzhdZ+ifhKviRjtt7QFwGCPfRnI=;
	b=QZn3ofJVaNFdLDJxeI6gggPpk50ZJGikdbz9QFVg40DB+GR9VGeAWfAOb9qFvz2zguzVRY
	BMhjw5qVFyNx6VMDnElm5VLGc9uxYc+Qql2jzU0c8MlHzh4Vajasp9QLk5TkWlTEQ7ZP6o
	eX8Tvc/iRYoeh2EjjLEXAMUQ2dkwQUg=
X-MC-Unique: ibRGHiTZNdG6ENlJzCN1MA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VlyRxy/TE+glo6GB9jhSSWjqSj3PCooym3mTQ5X+q/vFGw0esE/v8TYm/t/OOsx8W4kRwY9tyqbb0U6gL47Ne46kk7kpe4SVArJmZQ82u+cWxMEAqycC/eBWgW5E0ogXhyMZVK2voulwdJ5754FYEJCa6ufNrrQjvE/WAdjU4r0714sCDGBx97kQzV1yh1xl6FQSReT3UN8UCSVBXz2IdRDyGP6yGdSrnLPQlyS+tC3be5HM+gA9EbP4OMb94mBhGof7TYsbdUeLhOu+SlQUNBbbc1/TSqUPv9CJn2cQTom29SqJsfPbFAbPu0UmpaoW1LdgdhD6kHC5akBAzgKr+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=50ko0r9Z9sZripDqhzhdZ+ifhKviRjtt7QFwGCPfRnI=;
 b=laYd7pEuTRbNQqr7j09s7Xw5ZIyBuaUYgiE4N79k8XOSiaokVfD3h3uQxAPiWWlgDtZmv/OUW7h3ICfpfYBWHRYYqTy3wFZOGa8D2tNJAtE8mKix6ip0/xCLxX+nl8/sjzISY2lwdy4GuLJQGeCdnf3jhyOuE4PE8XN0GogmALV8Xtoyi/NqWWhje+zRVPWWZZcaST7nflJbOykWBeUDMLE1+JxaFtA/3BLpo/dPPhfo4CgWd38j2PGRptNCoVD33DXmgTA9qcngrMcxPKzGADpoV3iGcfF4lF9rK/M1ZVvBtsP2Tdyq30Nr09U+7SCGkusqS0sQqFU+zu96YmzTKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>
Date: Fri, 22 Apr 2022 12:57:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH RFC] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0080.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: db4f3a5c-2c72-42aa-b3fd-08da244ed5de
X-MS-TrafficTypeDiagnostic: VI1PR04MB4800:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB480051D73F546BBDDAA5E2AEB3F79@VI1PR04MB4800.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wmoOvlnssPZUtov3RyaSG2z1C2HB4sBXyhM8anG9WtXrBzDSNekjwlFF+X7NKaW0gVDhwYt1A8fGr0z9ubFnrqc1rMT9dYTz2YEY+b2ycZa5yRN79DNtVxCVZIBSiaDbNU1wr4sX6VEsL4gHrI+8Aisf4WQ/vbCvKh0zmNuOWVI5XMVFECfLBzuimIZham8f499CQQA+iwgqX46baSp8upoGkZFP8ZiGQdMtLgx/M2YTb704sIBHqNuquGkjI6yYefUwTypP6N+W5IU2u05MiRsrMyZp6RFf8ri5CbvtiRyMsoP3mYsfJ8MnQvzKnUbhSGcWfISPZL9eDkzQjOQGB2iwvlBiTkVIiMjdy+kIR1rMXTddMOTILREPK498bwS14MSQwY68EniLRkf5bUkJp7xe2na74JggzNQFdPdb6Tb6XHX4j8cQis4VedRvwvIYBwATWCfWtzXhM0ivc5aFn1uQ0Q6YKGgl3/X/WfOSR53Y2wWiQ20z6pyWPVAzKHgY63xzA2jdc/+RanI/5GWd2ci61LknfA5puWbdp4sT92abMHVB5nokoHWENZqBjA16HMxKiFvG0+rWSYtud9tx+AYcbG2+DGvOxYe7MUFhKOmOwQdfB+hT3BCg1EwZT6k4/VoEaQJiwggTUSCTyUOUUVYHXmwSTgndqzw4QOAlOOzP0kWyAvFkrnOXXqNO8La+Xz/6R0bHLij59NUElJdF/7wUTDdexdTN2+6J9lQ1BVs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(66946007)(6916009)(66476007)(4326008)(8676002)(54906003)(66556008)(316002)(107886003)(508600001)(6486002)(186003)(2616005)(6512007)(26005)(6506007)(8936002)(2906002)(31696002)(36756003)(5660300002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MDRzK0lQOSs1WGZqWFZsVmZ3ak4ycFcyV2IyRSt3ZjF5WUVWZlZsMGJTWEZN?=
 =?utf-8?B?WVV1UFZYRERwdFpVNmttTmx4QmFNRFRmTDFxWkZlbmVyMkcyWjQ5MUJiMGpM?=
 =?utf-8?B?TWU5eGJnbkk4SVE5cjdyTE5RVG5qR2F5OVlyQnZjRENBbkNzL0lBd3dnRlBB?=
 =?utf-8?B?eUVYcjRZUFNMTkMwMGhDSXFtdUt4SUFBWlF6bHVhYjVjYURVVmZFcjNDTkJl?=
 =?utf-8?B?N2VXYlFJaHRvTXhlUmhac3Uvdi9vRjMxVmc4TmtOc1ZQWjh1N1BxRkZOUGVK?=
 =?utf-8?B?MWpBMklyekhZK1dxWXV5R0MzL1IxVGZpbUJQZ3RiMWhWd0pvWkRUOUI4d3l3?=
 =?utf-8?B?UlpRV2lDWW9wTFM2Vk9rWHgwSVNBRlF5NXBoVzI3U2pxb1FOelo3U0Z1dGhs?=
 =?utf-8?B?UjNJamJubDhKL2JoZk5sTHZoVmVvaFRmUFlNa2xQdW8ycS9kaDJBTnpLMjdM?=
 =?utf-8?B?NWhZYWJ0a3BLVU5BekRMc3hHdE9NMWtVWjBkUHhtZGVYdDNyOU9CT2R5Vzkv?=
 =?utf-8?B?V0kvaTNsN2dLSkFqNVdNeEpVb3dZczZGdkEzU3E2QmNyQVMxQTlKM2ZZdzh2?=
 =?utf-8?B?dzZNYnNOY3pCMUtPcDF5S2pUOFoybzYzK0twOHFPcXFpMzRCMkMxMFFqQnIz?=
 =?utf-8?B?Z296eWN4SmcrQmRxaVIxOHdCQjYvUVV0WmZRWWwvd2RVTU9DU3pyQnlLSS9S?=
 =?utf-8?B?WkNTRVZaUXY5VURhL1hCU3RBYys4Y255SjZERkhmK3FZWS9Zc0xZZUNmdkpC?=
 =?utf-8?B?NndGTjM3TEtkbkI3aTJWc08vYnBjOHQ0UkNpRHJJZVJMeTRCRHVYRE1DZnk4?=
 =?utf-8?B?RmZjWkxoNnBET0RGNEZnaUg1SGRtSnlYRERWVmVYellDQ2NJYXlCRmkwWE1U?=
 =?utf-8?B?QnlvZ1d5dTN0U04rQVBPd0RHRk9BeWV6aHpPTHZ0WUI5NHpvZHM5SElZTjlZ?=
 =?utf-8?B?N0tqRmt2M0hiOTIxUXg0d3FBVTUrT3oyTjE0d0pFejVYMmxkV094S2hFdzhC?=
 =?utf-8?B?YWNKaHFsQ0NDZ3NjVDZ3M2lLWE1Gak9ydTBqbXllT1NyR3QvcG5xNlhtMUZR?=
 =?utf-8?B?Zk9GNEZZR1R5VEJ0ZEU3cjRrblVaMDFQT0JNRVNoTnZCbzhOL1NVRXJwZjBB?=
 =?utf-8?B?bjhLWHVIaE8wbURCMDFUcjhkR2lxLzNEV2pYS0EyeFJaL0VDZzVRbGpRTmhD?=
 =?utf-8?B?OXpEL3VUT1BETmlBOEp0WlZYMlJKYk1Fb2dxRHBNb3ErOWwrR3AvSUJkYndh?=
 =?utf-8?B?Y0JaYlN6ZU5lUjQzaDVxU1g4UzZicHdUWmVoQlJ3SXplUGg3Mk1vSGVqbTBT?=
 =?utf-8?B?cE13VXBCMGlIMmhEcEEvVXlRd0diYitzY1BSU1ZLbkNTTDFsUC83QXlWbTNa?=
 =?utf-8?B?WXFSUytWcGZMejFYMy9RVGsyNHNuUS9RcEZuM3NmOVcwRGhJeHcvcVVLVjNy?=
 =?utf-8?B?SXZRdUhkVUhLblFMNXFLdG1xb2VCWnA4ZTFJYWJ5MzAvR252eVpETjFZelNo?=
 =?utf-8?B?amgwSGs2S1ZWTXhLTDZ6Ym1KdERMR09hNnNvSUFLcjM5eXB3dXJvUUxQaW51?=
 =?utf-8?B?TEYrYmpqamRyYktyWTYrbmZLSit6cnZaWlZzS3ZUN2F5TmRhRm5OODJQWUZk?=
 =?utf-8?B?eC9WNTJqV0ZWRHlKTHlsNk13NkxGV0p5d0dpalFQaWRscC9EQ290ZmFndGtG?=
 =?utf-8?B?TmlrSjRYeFJ5WnhISjMydDNXbmdQSmx1WkFkaUZQeThGWmJybWlrRXdvNi85?=
 =?utf-8?B?MXR6QXNnZDVBZXEzdUFyTVhKNTRlYStsN0htbmhjeEc3UXRwRXR5VEM4TDNK?=
 =?utf-8?B?TGZjNDJ0M3cwV3M0OEJFUCtpbEx5SXBPaEw2cSthUmxvWlhKcFdPcjdOVVdk?=
 =?utf-8?B?ZFJhc0dIT0Uyd3JtRjcxVmE1dHhhZEYyTGNDY1kxK2lkTW85Z2svRGhwMExU?=
 =?utf-8?B?bTUybVh6R1Q0T0dUdTNEdXJMRjNXbFFrMWlYejU0Tk83TUpnSUhOd1lLV2k1?=
 =?utf-8?B?MEVwMTVMNGpMbVFTUnUrdGV4SGxLNlBTYWkrdGJvWmVxQXQxaStRQUxWK0Vq?=
 =?utf-8?B?bjZ2cTdZVFdkWkFwT2gvWTdvcHFvUjFWRkgwb3paRmdkUWxiOGZORUc3RHpp?=
 =?utf-8?B?QVR2SEcrMmJIaFVDR1NMUXlhOVE4QXE1aENGaTlEUHplZ3BXbFpiN2hReUZm?=
 =?utf-8?B?NndkTXlrZXpaaG9sQVBCMjluUDl5VGk4WXlUaEZ4Q2kzMmFIT3N5OHhtNE4v?=
 =?utf-8?B?UnVvVmd3Q2lWbytNUVEwR2pGSlp2QjY1L3QxdzlxVW10aENhK2RPVkZ4L085?=
 =?utf-8?B?OXBGckhuckpmcHJka1VNRUhUZGdxNkIvWGNzWEplOW5NV25NUG9WUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db4f3a5c-2c72-42aa-b3fd-08da244ed5de
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 10:57:04.1631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: grPqT5vbvhrVzBYCdRTODahmIUphew7ycZ4DoU1tWP1nkSgiVKPkUsxO9VoAQ44WChYXgH8Gci9y8Bp57H0Udg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4800

The reference "to shadow the resident processes" is applicable to
domains (potentially) running in shadow mode only. Adjust the
calculations accordingly.

In dom0_paging_pages() also take the opportunity and stop open-coding
DIV_ROUND_UP().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: I'm pretty sure I can't change a public libxl function (deprecated
     or not) like this, but I also don't know how I should go about
     doing so (short of introducing a brand new function and leaving the
     existing one broken).

--- a/tools/include/libxl_utils.h
+++ b/tools/include/libxl_utils.h
@@ -23,7 +23,10 @@ const
 #endif
 char *libxl_basename(const char *name); /* returns string from strdup */
 
-unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb, unsigned int smp_cpus);
+unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb,
+                                               unsigned int smp_cpus,
+                                               libxl_domain_type type,
+                                               bool hap);
   /* deprecated; see LIBXL_HAVE_DOMAIN_NEED_MEMORY_CONFIG in libxl.h */
 int libxl_name_to_domid(libxl_ctx *ctx, const char *name, uint32_t *domid);
 int libxl_domain_qualifier_to_domid(libxl_ctx *ctx, const char *name, uint32_t *domid);
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1194,10 +1194,17 @@ int libxl__domain_config_setdefault(libx
     }
 
     if (d_config->b_info.shadow_memkb == LIBXL_MEMKB_DEFAULT
-        && ok_to_default_memkb_in_create(gc))
+        && ok_to_default_memkb_in_create(gc)) {
+        bool hap = d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV
+                   ? libxl_defbool_val(d_config->c_info.hap)
+                   : false;
+
         d_config->b_info.shadow_memkb =
             libxl_get_required_shadow_memory(d_config->b_info.max_memkb,
-                                             d_config->b_info.max_vcpus);
+                                             d_config->b_info.max_vcpus,
+                                             d_config->c_info.type,
+                                             hap);
+    }
 
     /* No IOMMU reservation is needed if passthrough mode is not 'sync_pt' */
     if (d_config->b_info.iommu_memkb == LIBXL_MEMKB_DEFAULT
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -36,15 +36,21 @@ char *libxl_basename(const char *name)
     return strdup(name);
 }
 
-unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb, unsigned int smp_cpus)
+unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb,
+                                               unsigned int smp_cpus,
+                                               libxl_domain_type type,
+                                               bool hap)
 {
     /* 256 pages (1MB) per vcpu,
-       plus 1 page per MiB of RAM for the P2M map,
-       plus 1 page per MiB of RAM to shadow the resident processes.
+       plus 1 page per MiB of RAM for the P2M map (for non-PV guests),
+       plus 1 page per MiB of RAM to shadow the resident processes (for shadow
+       mode guests).
        This is higher than the minimum that Xen would allocate if no value
        were given (but the Xen minimum is for safety, not performance).
      */
-    return 4 * (256 * smp_cpus + 2 * (maxmem_kb / 1024));
+    return 4 * (256 * smp_cpus +
+                ((type != LIBXL_DOMAIN_TYPE_PV) + !hap) *
+                (maxmem_kb / 1024));
 }
 
 char *libxl_domid_to_name(libxl_ctx *ctx, uint32_t domid)
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -317,9 +317,12 @@ unsigned long __init dom0_paging_pages(c
     /* Copied from: libxl_get_required_shadow_memory() */
     unsigned long memkb = nr_pages * (PAGE_SIZE / 1024);
 
-    memkb = 4 * (256 * d->max_vcpus + 2 * (memkb / 1024));
+    memkb = 4 * (256 * d->max_vcpus +
+                 (paging_mode_enabled(d) +
+                  (opt_dom0_shadow || opt_pv_l1tf_hwdom)) *
+                 (memkb / 1024));
 
-    return ((memkb + 1023) / 1024) << (20 - PAGE_SHIFT);
+    return DIV_ROUND_UP(memkb, 1024) << (20 - PAGE_SHIFT);
 }
 
 



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 11:10:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 11:10:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310825.527764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrBR-0006sC-Qe; Fri, 22 Apr 2022 11:10:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310825.527764; Fri, 22 Apr 2022 11:10:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrBR-0006s5-Nh; Fri, 22 Apr 2022 11:10:41 +0000
Received: by outflank-mailman (input) for mailman id 310825;
 Fri, 22 Apr 2022 11:10:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aXhv=VA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhrBP-0006rg-PM
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 11:10:39 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d311adc4-c22c-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 13:10:32 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4511F212B7;
 Fri, 22 Apr 2022 11:10:38 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0CF60131BD;
 Fri, 22 Apr 2022 11:10:38 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sFvYAS6NYmJPOAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Apr 2022 11:10:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d311adc4-c22c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650625838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=dInreaPcH1Xy6SsC7cZkL2SMUJncDiJeMExLCEUxUHw=;
	b=uCkWOnnXH35EWtmUWxE7SQxpROxKuXK6XiYBuTClVNZNJhymtM4Ow+Wiy7BznQWN/2bPJw
	YdfsCs/haqgk5UQY3C5WfCrUewlKchq8mY2dC914AJZ77k+hu9GBOo/an5j+A7+MqHULQF
	xfpezM1Ufv1VYsWoHItHftD3IK0cpZo=
Message-ID: <a6c3a1d2-4fd3-71fc-7cc3-72948eec70a5@suse.com>
Date: Fri, 22 Apr 2022 13:10:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH RFC] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
References: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------Ym8qimm0qPzDZ129FZu0TYyi"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------Ym8qimm0qPzDZ129FZu0TYyi
Content-Type: multipart/mixed; boundary="------------mybByZ81b5gok4k2ZB1SYfiX";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
Message-ID: <a6c3a1d2-4fd3-71fc-7cc3-72948eec70a5@suse.com>
Subject: Re: [PATCH RFC] x86+libxl: correct p2m (shadow) memory pool size
 calculation
References: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>
In-Reply-To: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>

--------------mybByZ81b5gok4k2ZB1SYfiX
Content-Type: multipart/mixed; boundary="------------luMZrN0g5KlWdLz4newwbEwa"

--------------luMZrN0g5KlWdLz4newwbEwa
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjIuMDQuMjIgMTI6NTcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBUaGUgcmVmZXJlbmNl
ICJ0byBzaGFkb3cgdGhlIHJlc2lkZW50IHByb2Nlc3NlcyIgaXMgYXBwbGljYWJsZSB0bw0K
PiBkb21haW5zIChwb3RlbnRpYWxseSkgcnVubmluZyBpbiBzaGFkb3cgbW9kZSBvbmx5LiBB
ZGp1c3QgdGhlDQo+IGNhbGN1bGF0aW9ucyBhY2NvcmRpbmdseS4NCj4gDQo+IEluIGRvbTBf
cGFnaW5nX3BhZ2VzKCkgYWxzbyB0YWtlIHRoZSBvcHBvcnR1bml0eSBhbmQgc3RvcCBvcGVu
LWNvZGluZw0KPiBESVZfUk9VTkRfVVAoKS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gLS0tDQo+IFJGQzogSSdtIHByZXR0eSBz
dXJlIEkgY2FuJ3QgY2hhbmdlIGEgcHVibGljIGxpYnhsIGZ1bmN0aW9uIChkZXByZWNhdGVk
DQo+ICAgICAgIG9yIG5vdCkgbGlrZSB0aGlzLCBidXQgSSBhbHNvIGRvbid0IGtub3cgaG93
IEkgc2hvdWxkIGdvIGFib3V0DQo+ICAgICAgIGRvaW5nIHNvIChzaG9ydCBvZiBpbnRyb2R1
Y2luZyBhIGJyYW5kIG5ldyBmdW5jdGlvbiBhbmQgbGVhdmluZyB0aGUNCj4gICAgICAgZXhp
c3Rpbmcgb25lIGJyb2tlbikuDQoNCkknZCBtb2RpZnkgdGhlIGRlcHJlY2F0ZWQgZnVuY3Rp
b24gdG8gdXNlIHRoZSB3b3JzdCBjYXNlIHNjZW5hcmlvIGFuZA0KdXNlIGEgbmV3IGZ1bmN0
aW9uIGludGVybmFsbHkuDQoNCg0KSnVlcmdlbg0K
--------------luMZrN0g5KlWdLz4newwbEwa
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------luMZrN0g5KlWdLz4newwbEwa--

--------------mybByZ81b5gok4k2ZB1SYfiX--

--------------Ym8qimm0qPzDZ129FZu0TYyi
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJijS0FAwAAAAAACgkQsN6d1ii/Ey8A
SwgAhy1JozOAuvrvOqqlGgt36nCo+MveQxxaJlmyvQq+VhR16Fg7UqZFLb9Xnf6vr+oJmuyXwLIY
WDnlRTSNhm4l4ZTrhVvF58ArF5AAWFWyX9quMIoj2wGTVi4/fDXyBE9++cw45pMZIeFvn2BjjVFK
2m9DHVfeC9MwNhc9Z+jXjIsC7GIks/vkvsR0qtVsmS3xch1EORutHxOWOq/j3ZyQqeaMAxZPvvWc
OQOtoVHGxuhlGJfxA5D1Dv+8enb3xM19ZR+yoo6RBf1ijM5MDulLTPzAyYiIY0JjxYgwKYK1ZdZS
UX9+kyskyxJ82/SBlf9eZCbn0/FRuCk3ek+dUnufzA==
=0u/X
-----END PGP SIGNATURE-----

--------------Ym8qimm0qPzDZ129FZu0TYyi--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 11:15:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 11:15:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310831.527775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrFn-0007w8-Gm; Fri, 22 Apr 2022 11:15:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310831.527775; Fri, 22 Apr 2022 11:15:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrFn-0007w1-DV; Fri, 22 Apr 2022 11:15:11 +0000
Received: by outflank-mailman (input) for mailman id 310831;
 Fri, 22 Apr 2022 11:15:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QJ8Z=VA=citrix.com=prvs=1040bc4e0=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhrFm-0007vv-69
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 11:15:10 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 76dce5cf-c22d-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 13:15:08 +0200 (CEST)
Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 07:15:05 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SJ0PR03MB5869.namprd03.prod.outlook.com (2603:10b6:a03:2d4::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 11:15:01 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 11:15:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76dce5cf-c22d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650626107;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=sdM0juol54++k7mEDcS/69RVsc58WDJPxPBHiAz/YR8=;
  b=V3XgkmLZGEdgNSUrKbPLdeiyEQz22xScQmXGSE6EPBxCoJF8OLW48/Sw
   bFT8+VfXNhShZFdvzE3VjqhPUQp7NexhCAde1wgG2+tuRFM9r4qK03nlw
   iH8qgBSgUGkpszY1q0XiglXnUOr7Ibci/6qXrcIx2XSCjs3nhjhxXd6od
   0=;
X-IronPort-RemoteIP: 104.47.56.170
X-IronPort-MID: 69093561
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:5HFKNq82OAJeMERzW9FnDrUDh3+TJUtcMsCJ2f8bNWPcYEJGY0x3y
 jcZUWzTPPbcYGDzeop1YYng8kMBvpfSnNBnTFFv/Hw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YLjW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnb6RTzYsJ/biobs+YgRpGQMkFpZ86LCSdBBTseTLp6HHW13F5qw3SWoRZMgf8OsxBnxS/
 /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvuMvIAAtNszrpkm8fL2f
 c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLWwA+QnI+/NfD2773lAhl7LEL9fuUfuoXudMgXvfg
 0/f8DGsav0dHJnFodafyVqujOLSmSLwWKoJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvHiWzWorXjCuQQTM/JSHPc98xql0bfP7kCSAW1sc9JaQNkvtctzTjtz0
 FaMxortHWY27+XTTm+B/LCJqz/0ITISMWIJeS4DS00C/sXnp4YwyBnIS76PDZKIszE8Ihmoq
 xjikcT0r+x7YRIjv0ljwW36vg==
IronPort-HdrOrdr: A9a23:9ajYq6/J4Y3/PRHVW4Ruk+FEdb1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM
 RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe
 yhz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlCl9yZbdwkK7aYp8G
 DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFc1ccozHmApwjPCk6V4snt
 WJixA8P/5r43eURW2xqQuF4XiU7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys
 twri6knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdo99RrBmc4a+d
 RVfYDhDK48SyLbU5mZhBgk/DWUZAV9Iv/cKXJy+fB80FBt7QJEJgUjtY4id0w7hewAoql/lp
 v525tT5cBzp+8tHNZA7bQ6MLyK4lKke2O9DEuiZXLaKYogB1Xh77bK3ZRd3pDYRHVP9up4pK
 j8
X-IronPort-AV: E=Sophos;i="5.90,281,1643691600"; 
   d="scan'208";a="69093561"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nEsoZUdkCGwK/BlNc0MJBdHxI5XwannbkH61LgcoD3JqYaskfuuxHdwp/PicwSYujbIb9i7KBuEcuTClQiSGdRhE2ZC8f5AudYJCSEXaZXToHrWJKCEtWpym4WYpmOksDe1I5PBJs7RErWYr6L0FY+kWn2Rw+r7YT4ZoDFzyFzcDsFGh2Ggwzn+tjdnr85NvECeQAydJYbg9VBdBREe/1shJR3c2HTpvAjV9Y13E7S+jSnxt2m1FkQ+Xt9BKZsrtBn5IvajIgWIgNgBbBbdlq+ffBfehhG9P/3i2wgfsGVeDYP4GU7IyxlNaQuFW3gej2/OQiJVlMYwTsccRW6tvMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mI5SyJacBSCo/wsyoSwR7GL/vzZDlGFK/IuOZiuFVso=;
 b=k6/KEEsm2ajTq5Yx5nu79l2XFkbnonwDR1zMtipQZ1dRKI0A3kehpl04j0FSaLUniXM1C7qR4bvy/9H7FaXFovnHrM9R5CIX0rHeWM6+YOQDo4TECg7Rk1P4GWQIE7O88v9GOCgFFJwbk4B4vPvIjR0rEeyEjL1VGat9fWMq/eEK8n0+MPVm5DQjWSKwLbkxcWTyUeRHaw9fMuV09GdQcxGa9MMzH+Sqf031mvhLDyyKN1cbWBvedUIre4BsDJDfbz7nH9myEnn8PY7xs3XnNqO82eELq6Ev5Rl7urKJTpMDC7j5BL+H/nqHI8ZR9TdTg+j2OO5vdT3Cu56fNjVtoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mI5SyJacBSCo/wsyoSwR7GL/vzZDlGFK/IuOZiuFVso=;
 b=eHWZXbWO2lIoD0qF5erIL+sXMZi5TP2SjAq0Oc2JKKw3v/w2fg17yED5Diip87FuPJVGP/Ff4e9aNXAklpNa0bM+sbQh0WXFnT0scsvNxbRg0TAb0NMNJSyvPVOlTlVgoWtVVB2a+mhczltZVc95t3yIrp7QQrPwW8DxLIvTvzI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 22 Apr 2022 13:14:56 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH RFC] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Message-ID: <YmKOMC1TcQQUB6Lx@Air-de-Roger>
References: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>
X-ClientProxiedBy: LO4P123CA0495.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a16d040e-5a58-4110-9ec0-08da245157e9
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5869:EE_
X-Microsoft-Antispam-PRVS:
	<SJ0PR03MB5869923AF1B0CE344D693AE38FF79@SJ0PR03MB5869.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oJ/WYLDMB8d9a9GaO2QuEUM7FxTHjocm1tE8uL15r6JWgP+SmkRq6JIgaPnBRY9kj1lfKpyVjcL858ycLJZI6ONGDnR1Fo93QpGoPIxRRwPkLPSr4eweML/yeAQcvGl/dyadkmgsZYAy05Gnna85d0rcbiF4XLomthJpOxZJCfzZkeRAYxGJLp3A+Bdk+aGSEeYvdADpm+CDjcS37igV1JV3KeeRLO0VIZ7pDLjPQkcxgLjNf8gSt5ZKR65l0kH+ePlQhwi/FWKyATMuzQNzyNplcaNvUhafA/z0Ri0TEZZap3lSI9OF+3wD9nDmscmKTSxXJ63WJ4QSlTCWMZNJBGyHhvL85nls7OIr+3HZolW9vNgRmmDDy3mkT8mUAFyHHfw2iK/7/HqqWuNvtiamEU+Zl3+iahVHThZERsX9MWudq+Wis11CF5XYlmOb19tE2c+cIFGvSWeMFbLYzS49U1p81mAKhht622GkxN4p0lA3qzRmR31cfG/BgvenH6g4nNGR23M+3xTNMCnttuz51IhMrmBIwbw3Obh2CgiaE9Z1H1rYqbqkw8uy/TvEvE/KKVS+oLbP7M9Qg0BdtowIMmxuSd9cequ4GUwDaQ+1Tx7SjXYYQi+FzqdXegsyq/1H0wZMV0wgSOQy6Ayd07RrjQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(6666004)(6506007)(6512007)(186003)(9686003)(26005)(5660300002)(6486002)(508600001)(66476007)(8936002)(83380400001)(66556008)(33716001)(82960400001)(66946007)(2906002)(86362001)(6916009)(316002)(85182001)(4326008)(8676002)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dTFmMDZQSVFMZGJIQmkvQmVIUUJSWnBaUlE0QXRzQkhXSy9RZWVrTnhlNDB5?=
 =?utf-8?B?S3dHa1NtdDNmSzcxUXRMYjhrRXpxeTRpbE1PR25VM0krRCtWRGhCTkU2RzBN?=
 =?utf-8?B?ak5SdW4zOENaUldaRFV1eFU1QWFEbTE0QzdWc1Q5NGpPdDVTT0owSjBMVnhS?=
 =?utf-8?B?QVZ6VXcvVTdjS05wRVpEU2dWSDlXNDY1T0c4NTE5Z0NqMjZPN0t4enAwVExC?=
 =?utf-8?B?RjB2azZJbTVvRU1Rd0FSekxpTk82V3BlM25iVmpaeDVXZGtKZHNDSXBrWW1w?=
 =?utf-8?B?QUd1enIreE1SejlEM0wvZWpMUDhSK1NVbkVaWW4yWEhlRzJCdnZ6OU8vSktJ?=
 =?utf-8?B?K2J4aVJ3MVJLZE1maGNFN256QUhXZWFlR0RtbGlaY2IxMHMxblRIMDg5RENv?=
 =?utf-8?B?cmxWUXBEZVhzK0hBQ2xvdkZCa3lpUHlWRGtRUDgyQ1R4bUhhM09NVHlKU3Ro?=
 =?utf-8?B?d3pmSDZXWWF1aTduT2doZE1JeFp3cVNyVFpzeWlPaTUvMnhWU1FXNGRoam41?=
 =?utf-8?B?emRVL3h0bEZ6OWVkcVRQWll2UGhYZ0I1QXAwbjJFRE9jVE9KM0ZGVUFPcG1m?=
 =?utf-8?B?Wmw3eXlmT1lSSEZ5V0dhZ0s0V3VWSzhRSDFvRVRhOU1jTzZBY0pCemkrNi9p?=
 =?utf-8?B?enBhSWM4YUFENm1VVDduK2V4SmU0V041c0txbmx6TnQwdEJUcExqR0w3WUVF?=
 =?utf-8?B?U2xFV3cweGtGeGpjOVZoa1ZQcUpUQytmLzBWSS90QWRESlZqUW8yTmpEeWti?=
 =?utf-8?B?ZC9wZEJBSkR3U1RtUk1tQUhOaWNBbXBtaW1aY0U4Z29uMU95S01YblpKQUln?=
 =?utf-8?B?NndaTFMybmVoeUMwM2dZdXByK3IxWVQwcFFQUEd2bzFsSDFtTEJMWERPVnBu?=
 =?utf-8?B?cWF2QTI3RnAycEs5RVJoOWZnZU1NdDNqNENEWUNkNFE3cmt4SEFvMnk2K2tX?=
 =?utf-8?B?SmRTbkExbklTeXV2L2JCSFZpMWNnTDZDRENQay92SStOaWJYWEJrVGkwSWlk?=
 =?utf-8?B?RHdnRFUzV3ozYnkweVFvVFpwVytZMjdldmhMUmJkVjZSRU9mT2xmQUY0K29X?=
 =?utf-8?B?aDhTWU9Jc28rYTBSaXBvZ243Sis4N3lRbGE3SHV1TFA0aURXQXFGTDFPNElD?=
 =?utf-8?B?VTBDdURhb3lhNFQwbHdxaENiMmc3Y2IzbEo2ajR2MnZMV1ZpdDRyak1TT0U1?=
 =?utf-8?B?MFIvTEtoMUdVL2RhTmViLzFDUWprZVExczZaL3RZWjF5SnBsV0RvZWNTeUcr?=
 =?utf-8?B?WnN4MmV5VktQNWVRWm5oVXFZaHE1ZHZqUklLUTlPOUdOSFYveGEwNmo3SFdT?=
 =?utf-8?B?bDFuZ2xxZS9pcmxRbXBTOTZrOERRcmFMV0diVU5JZWdzeG5WUjgreUhXNTRF?=
 =?utf-8?B?K29mSk1UNFZBMDkwaXY5bGtybWdpWjN6ODlJWlBQdlVnN0xQTVl6MlJ2VmdT?=
 =?utf-8?B?M3ovbTNhUEJlRmpqWDVaYXlUSWJObFhHM2RIWGZuUUc1ZXhaaC9IU1RldnVp?=
 =?utf-8?B?c1RFTXVOMTRoQ0QrY0llWXo2cGdsWXEwaVB4a1lsY2RCaDVHVTNzNERURVNz?=
 =?utf-8?B?SGpPN1pvNDIzYTVIcGpidjlHYzMwYkwvQ241Ym1QZUxJeVl3VnNlZUZSL3kw?=
 =?utf-8?B?YU5XdTdlRjlleHdxRTBjUmFkd2NvYlNqcklvaTlJMXlXL1UwaTd6bDNiSHlt?=
 =?utf-8?B?S1FIeEtuTXBjVHZVdHZ0LzdJakpHTjZqbGJZZ1JQYjdqRFBrRlFVOVA0Mllu?=
 =?utf-8?B?Sml1eFpnZzBNN0FWaWRiTlRjTnpEN2hsemhLQ1NIME5DT2cwNHZRNVc2SlBH?=
 =?utf-8?B?blZscks4RC8xM3M0S3RqVmVENzRQVmZyU0tEVVZVaU1MdUZsVUc2V2tzWkpr?=
 =?utf-8?B?UTZURXd3bjNldkVDaUMrcStDdlZRQUVZVW5EMUsrUHRaYnpZZGdHK1VEWVFr?=
 =?utf-8?B?MjRnYmtvNUE4a3VWNmVrb1VacExyYUZxOFFpWUxqQkJBY0twcmFLZGc4K2FU?=
 =?utf-8?B?MXloQ2k0TWM2QzdwSFJmbWUyM1JaT1BtU3IvSStiTnNDVis1Sk9EdVVjaUNZ?=
 =?utf-8?B?elpJbGJDYU9YaXV5ekhsaWdneGswaExidmZsTSswRm8rRDNyOW10YXdjbHRP?=
 =?utf-8?B?WW5HcmdyZFZVRWJVQjd4VWEraDdMTWo4SWN5V3NDZEYya2ZpSC9UN3RTbEFh?=
 =?utf-8?B?SXdqRHppaTVIWWVMa0UrUUMyaVF6VUlpS1NQT1ZWNm5vK091c08xMDhlcGVt?=
 =?utf-8?B?KzR5VlJMVGFHTjlybzBqU3l1TE5HeElhYmFGM1V0cHpiWWdPaW0rZVRkZEpT?=
 =?utf-8?B?eHNXWDVPaHhaRVNJYk5YOHl5MmxsUG1hWm14RkVuN3cwcFBOTk9XUT09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a16d040e-5a58-4110-9ec0-08da245157e9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 11:15:01.4256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2abOXCmwQwYg9qW5PRCKQd41rNTChbsV9EX5uFPNz/taZLeB4qs2Cj0EQnvRFi4z78pWG7G1pWKqINb+gXO6jA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5869

On Fri, Apr 22, 2022 at 12:57:03PM +0200, Jan Beulich wrote:
> The reference "to shadow the resident processes" is applicable to
> domains (potentially) running in shadow mode only. Adjust the
> calculations accordingly.
> 
> In dom0_paging_pages() also take the opportunity and stop open-coding
> DIV_ROUND_UP().
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> RFC: I'm pretty sure I can't change a public libxl function (deprecated
>      or not) like this, but I also don't know how I should go about
>      doing so (short of introducing a brand new function and leaving the
>      existing one broken).

You have to play with LIBXL_API_VERSION, see for example:

1e3304005e libxl: Make libxl_retrieve_domain_configuration async

> 
> --- a/tools/include/libxl_utils.h
> +++ b/tools/include/libxl_utils.h
> @@ -23,7 +23,10 @@ const
>  #endif
>  char *libxl_basename(const char *name); /* returns string from strdup */
>  
> -unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb, unsigned int smp_cpus);
> +unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb,
> +                                               unsigned int smp_cpus,
> +                                               libxl_domain_type type,
> +                                               bool hap);

Iff we are to change this anyway, we might as well rename the
function and introduce a proper
libxl_get_required_{paging,p2m}_memory?

It seems wrong to have a function explicitly named 'shadow' that takes
a 'hap' parameter.

If you introduce a new function there's no need to play with the
LIBXL_API_VERSION and you can just add a new LIBXL_HAVE_FOO define.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 11:35:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 11:35:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310837.527786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrZK-0002UA-1O; Fri, 22 Apr 2022 11:35:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310837.527786; Fri, 22 Apr 2022 11:35:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrZJ-0002U3-Tl; Fri, 22 Apr 2022 11:35:21 +0000
Received: by outflank-mailman (input) for mailman id 310837;
 Fri, 22 Apr 2022 11:35:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYvr=VA=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nhrZI-0002Tx-5m
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 11:35:20 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0600.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::600])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4448505e-c230-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 13:35:10 +0200 (CEST)
Received: from AS9PR06CA0018.eurprd06.prod.outlook.com (2603:10a6:20b:462::11)
 by GV1PR08MB8036.eurprd08.prod.outlook.com (2603:10a6:150:97::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 11:35:08 +0000
Received: from VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:462:cafe::fa) by AS9PR06CA0018.outlook.office365.com
 (2603:10a6:20b:462::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Fri, 22 Apr 2022 11:35:08 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT053.mail.protection.outlook.com (10.152.19.198) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Fri, 22 Apr 2022 11:35:07 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Fri, 22 Apr 2022 11:35:07 +0000
Received: from 5a8c6b6d45cf.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E9F9B9B6-80EE-47E1-A7F2-D80A0E526387.1; 
 Fri, 22 Apr 2022 11:34:57 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5a8c6b6d45cf.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 22 Apr 2022 11:34:57 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by VI1PR0802MB2461.eurprd08.prod.outlook.com
 (2603:10a6:800:af::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Fri, 22 Apr
 2022 11:34:52 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 11:34:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4448505e-c230-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QY6klaSK2acOR58KRnVozDXSvrGRGDsosP9I1h8sdQg=;
 b=GWNcohEZTZ7asBZirDJucP27e1Ln7YshLPwBY+1Ul314rpSKoamBuA1bErv1BsyPoPiCqrSSlZ3oq+JTQ/kQUlZeZIugAkWMq/1fFhhrE0H0jzQGNuR1+0GaR+6f9feHCct+pPI8qZMJ+DvTlh4qMKlkPPewo/x6t0ARcaz8Plc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c4eb68193c1ec48e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k+RK5uw6C0MP+LCim52M7ECz7+Y5i493hKi4A1sUnSXE0am31B1RTQHabwOq2ayfrJlJGbiw8wDD+e983IQwTOPrM/nOuJh7rbc6sFS9SuRcls1dwagwg68zk8KjF+wa+HykUXSZVoi99YOsMVUjNQ5qNrLofb+1qevSzm6RjznPjneJjgpxUj8X+r7WU99BiZtYaD5ho/LLhRKYU3lMmV/1osUyURnoH6NzmQqOfmHtAOdAoLNEuS/jemFY47KLngUEpgJ2GVmDDBzS91mz9nTsTQYzdP2Exf5PNbM3n+GNpjTj6j1U9PVJdE9qFEPEqzcVbtAoTRMN9P9nO7VRmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QY6klaSK2acOR58KRnVozDXSvrGRGDsosP9I1h8sdQg=;
 b=AA8oBEy4PAMcaxHhCxC1WPVYVrs1ZiqmncQU00B9qmvJrgXRdLsYgIaMxWNcf4Rut1XxgfRwob9/EWm2RXtUGUzXG6KztaaR0Ce+shOd1sKslqUvz6SrgSQYX0X4OOskNp3KquCGVInpnBwO9ohMvgRItIVeiz4vL7+VfPDsWaIbc5VNQ31ckKt2hWA8YiQPP2d4fPJ5ujCS0moJ+zjIEDjuTjeIWLIGXhbIf92pslWAL2YYop7uZfOugDlILn8n0WI2RxA76BN59hWgMFCbSW2e8Jo7h/oHjezgqEm34ZMvjQYWCDSewNYJ1Iw2haeXPSUGg+4+CZ0G7Ll7R0aYAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QY6klaSK2acOR58KRnVozDXSvrGRGDsosP9I1h8sdQg=;
 b=GWNcohEZTZ7asBZirDJucP27e1Ln7YshLPwBY+1Ul314rpSKoamBuA1bErv1BsyPoPiCqrSSlZ3oq+JTQ/kQUlZeZIugAkWMq/1fFhhrE0H0jzQGNuR1+0GaR+6f9feHCct+pPI8qZMJ+DvTlh4qMKlkPPewo/x6t0ARcaz8Plc=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Christoph Hellwig <hch@lst.de>
CC: Stefano Stabellini <sstabellini@kernel.org>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Jan Beulich
	<jbeulich@suse.com>, "jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Topic: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Thread-Index:
 AQHYTzcUggEUWxM2006iot1qnYxlIKzuW0oAgAFU1ACAADDmgIAApv+AgAC5dQCAAp7ugIACQDIAgAEmAYCAANnhAIAAjguAgADEGACAAT4mAIAAR4cAgAB2D4CAAG0vAA==
Date: Fri, 22 Apr 2022 11:34:52 +0000
Message-ID: <105DB518-DB5B-47F8-852F-C997678BBCE6@arm.com>
References: <20220415063705.GA24262@lst.de>
 <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
 <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
 <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
 <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop>
 <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com>
 <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop>
 <12279FAE-2141-469E-A424-9984348E84BB@arm.com>
 <alpine.DEB.2.22.394.2204211444190.915916@ubuntu-linux-20-04-desktop>
 <20220422050405.GA10195@lst.de>
In-Reply-To: <20220422050405.GA10195@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: c2c6bdfd-be6e-4690-43a8-08da24542705
x-ms-traffictypediagnostic:
	VI1PR0802MB2461:EE_|VE1EUR03FT053:EE_|GV1PR08MB8036:EE_
X-Microsoft-Antispam-PRVS:
	<GV1PR08MB80362FD6EEEC275F4ED03E44FCF79@GV1PR08MB8036.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 dSPupamvBFJc/wsgEMfxjEE4KFwgA1j+yHmqqv71XrP1EJlm+pBo0hjd/CUPXdnc+rR4I71l7/7cYBhJCF2UIHgkg1kLOezI6z/QOCZZwcQSo+mnngOw+S/lYlsPpUEQ/kY78p1CihkaabQOlc/veK7igtwUEvabjHtW8aUkw46ugvaVfOaBAnY0VNMgSyzXcirtYxm3t47l6Oj+gboxp02+qmF7EcpwlhjIHProy1DRFt/v3XIZ8DT10QE1/GCasQEqRdgWJmB/qMQepWqMsdpJ0ygr9L0f9lkuebrGNqxiM7MT07MqLSOYuWywb9o3nODC97jgxJSOUFMFZ345aY6ysXzjDId2uKrr6devZwu/5BkISsOOC8vQBtaM9u/l0WWO+Z0v2lP3hrrxS63wpv/Pl4ZwnzZjwd01ht5g2PdHWCaRVDZ00Utc75aGg2zgBWCSGhziFDcC6jQDOnyU5QWa912jOMCgAZVfTJNUudtz3ih3y/pDRE4N+rjw1kIuVP8BquoqQykL4rMAUbpcxxmek+SB7vCbZ1B2dI6z7bKHjJPiBf5jwjCx/n5R86K9tijs9E0Q+z1puwQLjxCCrrNnyWnMXUzDs4jyHAWKBbX4I4jdNyDLkBuny41bnHmRPUih+SfAtQfvXoHPjlSVqXsaBqMLkE8zZdlUXCtqVyuLA0PJTXgiR5svQiNjWilmXeCc3wGzrb5F3qHuTkhNl5WSOd9rvuiMkuid+iN09pK7lsR3dentPAqKzH5oLXCX
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(54906003)(2616005)(66446008)(5660300002)(6506007)(33656002)(508600001)(8676002)(6486002)(8936002)(36756003)(2906002)(38100700002)(38070700005)(6916009)(86362001)(4326008)(26005)(71200400001)(53546011)(64756008)(6512007)(186003)(122000001)(83380400001)(66476007)(66556008)(76116006)(91956017)(66946007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C5C80E50A512A343AAB5312C84ABB9F0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2461
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	209d5f7c-ad11-4c5c-eba8-08da24541e25
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bhJzDOka/nEz9x5RjgdNNTGl6Q2ngP08VXmm5aoZqkQD6tQGo4+L1ANW51etbc8bkmoigB99aiTr1kvrzrfhtsxRW0nBmqmJc84qNVVAJoT5BJzFDG1jAujvW9CS1a9jkykHk7iEP4QP9Rrr2Zg7gx7ELt3dLDQtBadOo6kvdmopuDfuKvtiSddL5yQNSqNAh7W9+D1NH8poLjZ/8iEyMBM6i2WBylrn4X5twzCT8mWK/NFbe3jrRG15wJT9dJISWA9ylkkf2FhRA+F6A47pReOYWggWGl6PdHtG/0J88ZK1TuPjsQSPaksKeklBa4zQfZtDvXLF6qpXdotDmTqiyIqcshVe6N3RTUPe4rPpeFT/SR7lGX2g7qTDQC01haL9NB0LgE6UW1thdAUitHjwYW1H+hCPB8Mj02ePeZ3XHvYkSCK6GNXhqywK3iLYgF79btlTBSIad+YFAWrD6AUo7Lp+HUwG4/DjAuNjXLdmcPEd4OIqANb66sGNghkLWhB/bNk6j31VX1ejaI+FXwT9PEi82ZJBhP1PniT40s020/HPW73jL7AWKk08G39jLZIxvVl9auCyvSgcheuYg15ZuZ+aZwL1MxfzeefxC9EmyIJOnuwPAWLqY8IgCIlH7kAVPIdesYnvlmwnesWwQFr7nOXT3YFitz1AjMWU4FSrNCN4Nl+D0G4JURQnOX7aYt63
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(81166007)(186003)(26005)(6486002)(8936002)(36860700001)(47076005)(2906002)(82310400005)(54906003)(70586007)(70206006)(36756003)(6506007)(316002)(86362001)(8676002)(4326008)(2616005)(83380400001)(107886003)(6862004)(6512007)(336012)(53546011)(356005)(508600001)(5660300002)(33656002)(40460700003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 11:35:07.5449
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c2c6bdfd-be6e-4690-43a8-08da24542705
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8036

Hello Stefano, Christoph,

> On 22 Apr 2022, at 6:04 am, Christoph Hellwig <hch@lst.de> wrote:
>=20
> On Thu, Apr 21, 2022 at 03:01:32PM -0700, Stefano Stabellini wrote:
>> swiotlb-xen: handle DMA_ATTR_NO_KERNEL_MAPPING
>>=20
>> If DMA_ATTR_NO_KERNEL_MAPPING is set then the returned vaddr is a struct
>> *page instead of the virtual mapping of the buffer.
>>=20
>> In xen_swiotlb_alloc_coherent, do not call virt_to_page, instead use the
>> returned pointer directly. Also do not memset the buffer or struct page
>> to zero.
>>=20
>> In xen_swiotlb_free_coherent, check DMA_ATTR_NO_KERNEL_MAPPING and set
>> the page pointer appropriately.
>=20
> Something like that should work, but it makes swiotlb-xen poke even
> more into the opaque dma-direct internals.  I'd rather do something
> like the patch below that uses the dma_direct allocator directly for
> arm, and simplifies the xen-swiotlb allocator now that it just needs
> to cater to the x86 case:
>=20
> diff --git a/arch/arm/include/asm/xen/page-coherent.h b/arch/arm/include/=
asm/xen/page-coherent.h
> deleted file mode 100644
> index 27e984977402b..0000000000000
> --- a/arch/arm/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#include <xen/arm/page-coherent.h>
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index a7e54a087b802..6e603e5fdebb1 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -118,23 +118,6 @@ bool xen_arch_need_swiotlb(struct device *dev,
> 		!dev_is_dma_coherent(dev));
> }
>=20
> -int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> -				 unsigned int address_bits,
> -				 dma_addr_t *dma_handle)
> -{
> -	if (!xen_initial_domain())
> -		return -EINVAL;
> -
> -	/* we assume that dom0 is mapped 1:1 for now */
> -	*dma_handle =3D pstart;
> -	return 0;
> -}
> -
> -void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int orde=
r)
> -{
> -	return;
> -}
> -
> static int __init xen_mm_init(void)
> {
> 	struct gnttab_cache_flush cflush;
> diff --git a/arch/arm64/include/asm/xen/page-coherent.h b/arch/arm64/incl=
ude/asm/xen/page-coherent.h
> deleted file mode 100644
> index 27e984977402b..0000000000000
> --- a/arch/arm64/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#include <xen/arm/page-coherent.h>
> diff --git a/arch/x86/include/asm/xen/page-coherent.h b/arch/x86/include/=
asm/xen/page-coherent.h
> deleted file mode 100644
> index 63cd41b2e17ac..0000000000000
> --- a/arch/x86/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _ASM_X86_XEN_PAGE_COHERENT_H
> -#define _ASM_X86_XEN_PAGE_COHERENT_H
> -
> -#include <asm/page.h>
> -#include <linux/dma-mapping.h>
> -
> -static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_=
t size,
> -		dma_addr_t *dma_handle, gfp_t flags,
> -		unsigned long attrs)
> -{
> -	void *vstart =3D (void*)__get_free_pages(flags, get_order(size));
> -	*dma_handle =3D virt_to_phys(vstart);
> -	return vstart;
> -}
> -
> -static inline void xen_free_coherent_pages(struct device *hwdev, size_t =
size,
> -		void *cpu_addr, dma_addr_t dma_handle,
> -		unsigned long attrs)
> -{
> -	free_pages((unsigned long) cpu_addr, get_order(size));
> -}
> -
> -#endif /* _ASM_X86_XEN_PAGE_COHERENT_H */
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 47aebd98f52f5..557edb9c54879 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -36,7 +36,6 @@
> #include <xen/hvc-console.h>
>=20
> #include <asm/dma-mapping.h>
> -#include <asm/xen/page-coherent.h>
>=20
> #include <trace/events/swiotlb.h>
> #define MAX_DMA_BITS 32
> @@ -104,6 +103,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, =
dma_addr_t dma_addr)
> 	return 0;
> }
>=20
> +#ifdef CONFIG_X86
> static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
> {
> 	int rc;
> @@ -129,6 +129,12 @@ static int xen_swiotlb_fixup(void *buf, unsigned lon=
g nslabs)
> 	} while (i < nslabs);
> 	return 0;
> }
> +#else
> +static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
> +{
> +	return 0;
> +}
> +#endif
>=20
> enum xen_swiotlb_err {
> 	XEN_SWIOTLB_UNKNOWN =3D 0,
> @@ -256,97 +262,60 @@ void __init xen_swiotlb_init_early(void)
> 		panic("Cannot allocate SWIOTLB buffer");
> 	swiotlb_set_max_segment(PAGE_SIZE);
> }
> -#endif /* CONFIG_X86 */
>=20
> static void *
> -xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
> -			   dma_addr_t *dma_handle, gfp_t flags,
> -			   unsigned long attrs)
> +xen_swiotlb_alloc_coherent(struct device *dev, size_t size,
> +		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
> {
> -	void *ret;
> +	u64 dma_mask =3D dev->coherent_dma_mask;
> 	int order =3D get_order(size);
> -	u64 dma_mask =3D DMA_BIT_MASK(32);
> 	phys_addr_t phys;
> -	dma_addr_t dev_addr;
> -
> -	/*
> -	* Ignore region specifiers - the kernel's ideas of
> -	* pseudo-phys memory layout has nothing to do with the
> -	* machine physical layout.  We can't allocate highmem
> -	* because we can't return a pointer to it.
> -	*/
> -	flags &=3D ~(__GFP_DMA | __GFP_HIGHMEM);
> +	void *ret;
>=20
> -	/* Convert the size to actually allocated. */
> +	/* Align the allocation to the Xen page size */
> 	size =3D 1UL << (order + XEN_PAGE_SHIFT);
>=20
> -	/* On ARM this function returns an ioremap'ped virtual address for
> -	 * which virt_to_phys doesn't return the corresponding physical
> -	 * address. In fact on ARM virt_to_phys only works for kernel direct
> -	 * mapped RAM memory. Also see comment below.
> -	 */
> -	ret =3D xen_alloc_coherent_pages(hwdev, size, dma_handle, flags, attrs)=
;
> -
> +	ret =3D (void *)__get_free_pages(flags, get_order(size));
> 	if (!ret)
> 		return ret;
> -
> -	if (hwdev && hwdev->coherent_dma_mask)
> -		dma_mask =3D hwdev->coherent_dma_mask;
> -
> -	/* At this point dma_handle is the dma address, next we are
> -	 * going to set it to the machine address.
> -	 * Do not use virt_to_phys(ret) because on ARM it doesn't correspond
> -	 * to *dma_handle. */
> -	phys =3D dma_to_phys(hwdev, *dma_handle);
> -	dev_addr =3D xen_phys_to_dma(hwdev, phys);
> -	if (((dev_addr + size - 1 <=3D dma_mask)) &&
> -	    !range_straddles_page_boundary(phys, size))
> -		*dma_handle =3D dev_addr;
> -	else {
> -		if (xen_create_contiguous_region(phys, order,
> -						 fls64(dma_mask), dma_handle) !=3D 0) {
> -			xen_free_coherent_pages(hwdev, size, ret, (dma_addr_t)phys, attrs);
> -			return NULL;
> -		}
> -		*dma_handle =3D phys_to_dma(hwdev, *dma_handle);
> +	phys =3D virt_to_phys(ret);
> +
> +	*dma_handle =3D xen_phys_to_dma(dev, phys);
> +	if (*dma_handle + size - 1 > dma_mask ||
> +	    range_straddles_page_boundary(phys, size)) {
> +		if (xen_create_contiguous_region(phys, order, fls64(dma_mask),
> +				dma_handle) !=3D 0)
> +			goto out_free_pages;
> 		SetPageXenRemapped(virt_to_page(ret));
> 	}
> +
> 	memset(ret, 0, size);
> 	return ret;
> +
> +out_free_pages:
> +	free_pages((unsigned long)ret, get_order(size));
> +	return NULL;
> }
>=20
> static void
> -xen_swiotlb_free_coherent(struct device *hwdev, size_t size, void *vaddr=
,
> -			  dma_addr_t dev_addr, unsigned long attrs)
> +xen_swiotlb_free_coherent(struct device *dev, size_t size, void *vaddr,
> +		dma_addr_t dma_handle, unsigned long attrs)
> {
> +	phys_addr_t phys =3D virt_to_phys(vaddr);
> 	int order =3D get_order(size);
> -	phys_addr_t phys;
> -	u64 dma_mask =3D DMA_BIT_MASK(32);
> -	struct page *page;
> -
> -	if (hwdev && hwdev->coherent_dma_mask)
> -		dma_mask =3D hwdev->coherent_dma_mask;
> -
> -	/* do not use virt_to_phys because on ARM it doesn't return you the
> -	 * physical address */
> -	phys =3D xen_dma_to_phys(hwdev, dev_addr);
>=20
> 	/* Convert the size to actually allocated. */
> 	size =3D 1UL << (order + XEN_PAGE_SHIFT);
>=20
> -	if (is_vmalloc_addr(vaddr))
> -		page =3D vmalloc_to_page(vaddr);
> -	else
> -		page =3D virt_to_page(vaddr);
> +	if (WARN_ON_ONCE(dma_handle + size - 1 > dev->coherent_dma_mask) ||
> +	    WARN_ON_ONCE(range_straddles_page_boundary(phys, size)))
> +	    	return;
>=20
> -	if (!WARN_ON((dev_addr + size - 1 > dma_mask) ||
> -		     range_straddles_page_boundary(phys, size)) &&
> -	    TestClearPageXenRemapped(page))
> +	if (TestClearPageXenRemapped(virt_to_page(vaddr)))
> 		xen_destroy_contiguous_region(phys, order);
> -
> -	xen_free_coherent_pages(hwdev, size, vaddr, phys_to_dma(hwdev, phys),
> -				attrs);
> +	free_pages((unsigned long)vaddr, get_order(size));
> }
> +#endif /* CONFIG_X86 */
>=20
> /*
>  * Map a single buffer of the indicated size for DMA in streaming mode.  =
The
> @@ -549,8 +518,13 @@ xen_swiotlb_dma_supported(struct device *hwdev, u64 =
mask)
> }
>=20
> const struct dma_map_ops xen_swiotlb_dma_ops =3D {
> +#ifdef CONFIG_X86
> 	.alloc =3D xen_swiotlb_alloc_coherent,
> 	.free =3D xen_swiotlb_free_coherent,
> +#else
> +	.alloc =3D dma_direct_alloc,
> +	.free =3D dma_direct_free,
> +#endif
> 	.sync_single_for_cpu =3D xen_swiotlb_sync_single_for_cpu,
> 	.sync_single_for_device =3D xen_swiotlb_sync_single_for_device,
> 	.sync_sg_for_cpu =3D xen_swiotlb_sync_sg_for_cpu,
> diff --git a/include/xen/arm/page-coherent.h b/include/xen/arm/page-coher=
ent.h
> deleted file mode 100644
> index b9cc11e887ed5..0000000000000
> --- a/include/xen/arm/page-coherent.h
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _XEN_ARM_PAGE_COHERENT_H
> -#define _XEN_ARM_PAGE_COHERENT_H
> -
> -#include <linux/dma-mapping.h>
> -#include <asm/page.h>
> -
> -static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_=
t size,
> -		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
> -{
> -	return dma_direct_alloc(hwdev, size, dma_handle, flags, attrs);
> -}
> -
> -static inline void xen_free_coherent_pages(struct device *hwdev, size_t =
size,
> -		void *cpu_addr, dma_addr_t dma_handle, unsigned long attrs)
> -{
> -	dma_direct_free(hwdev, size, cpu_addr, dma_handle, attrs);
> -}
> -
> -#endif /* _XEN_ARM_PAGE_COHERENT_H */

Thanks for sharing the patch to fix the issue.
I tested both the patches and both the patches work fine.


Regards,
Rahul



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 11:42:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 11:42:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310843.527797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrgT-0004EY-VY; Fri, 22 Apr 2022 11:42:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310843.527797; Fri, 22 Apr 2022 11:42:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrgT-0004ER-Rr; Fri, 22 Apr 2022 11:42:45 +0000
Received: by outflank-mailman (input) for mailman id 310843;
 Fri, 22 Apr 2022 11:42:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhrgS-0004EL-FJ
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 11:42:44 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5099c97b-c231-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 13:42:42 +0200 (CEST)
Received: from mail-bn8nam11lp2172.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.172])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 07:42:38 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM6PR03MB3818.namprd03.prod.outlook.com (2603:10b6:5:42::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr
 2022 11:42:36 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 11:42:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5099c97b-c231-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650627762;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Y0PMjGop8+FVS5FTxtKmASPWLTlZSPYPyMYXZwy2wBw=;
  b=P/yFY+KRbqiZXRUfZTwzhjLgq2glh0ef6vmJ5TQRjGcrVYlqy7D3Z61m
   H9Q6XqgnGqnJyODChIs/nXwcaY7aKLqQmUho/zEiWMPpmO2WSua3eKLan
   YwkDwUbteYdreclXiOOKBzrCFnpYgktRqasSjJC9VNk6cokXhT4XFZf26
   A=;
X-IronPort-RemoteIP: 104.47.58.172
X-IronPort-MID: 69713643
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:MWF6Rqg2WiKr6+eVkyl5OrpoX161ZREKZh0ujC45NGQN5FlHY01je
 htvX2mHPv2PYDGhfNt+Yd/n/UsO65+GzN81SwRurypnQywb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nX4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YV8kD4flhtonbzJ3SjFBbbZ43JqAcEHq5KR/z2WeG5ft69NHKRhveKc+qqNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuI8ehWhq7ixNNa+2i
 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJpsjeKl1Iti9ABNvLrfM3SQsVbl32h/
 CXX4X+hBQwwG8CAnG/tHnWEw7WncTnAcIAYGaC89/VqqEaO3WFVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslh0RRdtWVfE74Qely6zI7gLfDW8BJgOtc/Qjvc4yADYsh
 lmAmoqwASQ16eLPD3WA6r2TsDW+fzAPKnMPbjMFSg1D5MT/pIY0jVTESdML/LOJs+AZ0ArYm
 1iixBXSTZ1K5SLX/81XJWz6vg8=
IronPort-HdrOrdr: A9a23:ycmwzqqTz3JmJYNHBRF0J6EaV5t0LNV00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcotKLzOWwldAS7sSo7cKogeQVxEWk9Qw6U
 4OSdkYNDSdNzlHZIPBkXGF+rUbsZi6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK
 Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInBy6IZn1V
 KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0SVjcVaKvi/VQIO0aaSAWUR4Z
 /xStAbTp1OAkbqDyWISN3WqlHdOXgVmiTfIBSj8AbeSITCNU4H4ox69MJkm1LimjQdVJsX6t
 M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pUVFb/l/1swKp5KuZIIMvB0vFuLA
 CuNrCo2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZMyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR+2Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NKwgFCvsukKSRloeMNIYDaxfzOWzGu/HQ0Mk3E4ncR+
 u5Po5QDrvqMXbucLw5qzHDZw==
X-IronPort-AV: E=Sophos;i="5.90,281,1643691600"; 
   d="scan'208";a="69713643"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XgL2qmYSMqsV5sSuM8WucIII8RvZOMzqlJwH5PdKxQcStG1nJTyOjY+bWmdF+lae4D1/cXjpha6nl3cooiYYM0aWPN63Ul6rXTeL6YBW0qO24dyw0Z5BjVJYAW4yvvgJSUhulp75UEXEnEBM3bj4W4Fhehy0fo8vydZ+jeKlxK5UVdAE8wp3oGWouBAjGrHfSgDUmkQGvoLzGa1khxJQQNrvEv55bISMZ3FOcRGljZJYuG59tQTa1jEukwFJwB+HgVx4GGeLcbVRZR7tK7fJUERwWwSaH2Mdi8Sl9AmuO/pJLMMe7ELVo22r+L+no99wLJmmVJ21FM1EXHbbi1s0vQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y0PMjGop8+FVS5FTxtKmASPWLTlZSPYPyMYXZwy2wBw=;
 b=SGEfwEVRb9tmgGT6HCgAwWfmnaP7ukPGwkqnJPjwHXrsXTlyqEs6teJaJ0uGwF9MoIXHGhXdQTlkjDdCCk9bZYZxtP0a1WR6UbcxyP8rrKW5eBc5u/0UOJ0x/qatT2j6GqusP19fHAIfg9MvXeojC5kCRqCUo0biQHyq27sOQw7TXftYdG1phj+0FvMr5lWj35bw5+eiOza5abMPgYoXMkFVEE/9yf3NPbrpNKvCUM7ZN0XxWn00FlXFa/L0eosX+zFnaD8RYL3xzwTE92nUnPeyxHTPbCrK1k9i4+qEbTyqwUQbVUsQwApJtdKaiPK22rnvD+ZPy2o7EfJxizs4+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y0PMjGop8+FVS5FTxtKmASPWLTlZSPYPyMYXZwy2wBw=;
 b=jMuzvgSZqOq6seg8ebt2mymB/g/YJZd/VvkurR40AOAB80fO7b2v/F+OrYjHs7vrSqznyiA78/og7Kts1xiU6nxZtbUWnlnRxTCImgWaZOfKIM2HdGtFQ7O8pGLA6lxZgqMwiWGDGmQmDpTxYH7A11pQEVUrNdWjJ8FIPf9YStg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH] VT-d: fix !HVM build
Thread-Topic: [PATCH] VT-d: fix !HVM build
Thread-Index: AQHYVi+clO+iJmB//EeiyYBjieMG6Kz7z7+A
Date: Fri, 22 Apr 2022 11:42:36 +0000
Message-ID: <191336d6-b7e4-551c-61b9-4d36bffee135@citrix.com>
References: <431d4212-07b8-63d5-1a4d-7e8c7a9108ea@suse.com>
In-Reply-To: <431d4212-07b8-63d5-1a4d-7e8c7a9108ea@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 531877b6-47a6-4e3d-1dc8-08da24553271
x-ms-traffictypediagnostic: DM6PR03MB3818:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs:
 <DM6PR03MB3818332F9A748F30A177EF3EBAF79@DM6PR03MB3818.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 FUC4jj6Mn8Xi0U/1a4ViVNpb1z0N6MQwa7pVL1sBNvr1ztNSMkLAAo/R2n/1JupwUZfQWuXXVPHXYBFV3BxOcU/CyhS3MChj4f2wA77p6psaUrtDiYFIz/ES2x227JceLK7DwILUcslxbCUQxysHeozBj4kVmc38wTMAiV+ZKe+VU/dtbZBr1nKphhiRlEAjUj3kZUTTY2aYeeyZ+vED8DKP1E7Jkp9U9O601InAxb/RYtwuZchUrfHkB22tNcGK/HtOfc1vgOPbWZFnf2DONl2hT/Fneb4xGsdAw3afArZTbR5ldlAXAtpUUTZGnrsJxIwx9Ppz3IBNje2izd254VCEKUOqA17ZsYI+OSuqYOs/IXlbLEEuKEbLNwBIGsi+VoQESDzgYwIUNr9qgMXu1OgCYD+swliNM5JedeNc549HRslw8WiyIl1eyZr7DyJdcae0CEfUGmbtg/ynpXD5UGaSRyr1qq4E5qYZFuvIUkOQCOdBCemw/s2AZaIzi9l5l8T0H6JdbYLoeTXO2A6teCFgHz6f8lCG6G1owBKBxaGDX5pol3FvwHgjk90omstCaLKGaF/FOxUmDW9fou8oICcLfdQHMkyMmYj+9cgGejpbSM/AgU1f7em7fvSuS0yTu/IEsnp0pDq3vLWK+c7ANRmX561gzpZAGHw2pYFv4LwBqHoqJz8ZJJJPZMlWqNPlbZlof1vybRDHENWa0o+mxSDviVQrn3IrldzKgRR66eCzkTfxVQLu/cMX/V1sfOibcTJHsjYbQ2tfstqAd0baJA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2906002)(71200400001)(91956017)(8676002)(2616005)(64756008)(5660300002)(82960400001)(83380400001)(316002)(26005)(508600001)(31696002)(6512007)(6506007)(76116006)(53546011)(186003)(110136005)(86362001)(66476007)(66946007)(38070700005)(66556008)(66446008)(4326008)(122000001)(38100700002)(6486002)(31686004)(4744005)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?YmZ6Qko5QVI5ZU82RmQ1Y2cwR2xFUXk3QnR6MHN4OUU5VDUrSFd1OW9KV3ht?=
 =?utf-8?B?UUpDKzduRDhZeW9jcWk2b2xncEx4Y0haaU5LemRTdkhCZ095elRXU2JzWUJJ?=
 =?utf-8?B?ZkRmVDlNTFBNcTc2dWNvaERhb0YrNjQ5cXJ2V05hSGZKQkEwYnF1K3hsVURy?=
 =?utf-8?B?SlNOSnpEMm5oeFk2Nzl2TmNTODJ1ay9MQXpKQXI3UFdJUmtxUStRQkU2Mk1a?=
 =?utf-8?B?ZVpwSFRsQmFWRTM4cDJsa3dDV3YzTVZOS09qcWxVc09xcEtLM2NxV3JTMTVr?=
 =?utf-8?B?SExoTUthSHVTRjVlTkozVmVSaTBicEVQckRpM1ZteFZjdEpNS01pOEpJbkxR?=
 =?utf-8?B?eXVJUW5xSk56ckJpRG4rUk9hMmNjY1llQ2U5SlVJSW9pbjV5RFNxbjk3NDBN?=
 =?utf-8?B?ZFBZYjNXTSs2OW85cFdvTDdSa0FFRUh3bXhHNm1FTWJ4ZTY4WG94aGNsbjBZ?=
 =?utf-8?B?cUZTWW94YitiaWlqbEFCYU8wT1BLa2wzcVBBMFo4aHBsQ3RtZjJzUlBBaEhr?=
 =?utf-8?B?MEkydTFIRHkwY2ZjVlpQNWp1V053VHMvZVBMRGJDYXZLRzFsMElMS09LYk5m?=
 =?utf-8?B?b05jOUVWaVBRa3ZiQUd1SDFSb0FZSmVOM2F1U0Fmc096M1E5QVNNaUtDMnlP?=
 =?utf-8?B?cUxjcm9Jd09wTlcxZytnU1NyYnR2UVVzVGYvZDg1YzZ1QXVhSG1xdDhJZU5D?=
 =?utf-8?B?dXdmVXAzd3BITXlWNFZBL0pvOHczYlVXL0MrYTU3QkZzcFV1OVZZMVdaS0Fw?=
 =?utf-8?B?VUYyU2NTeHBkRU5jMFgwUVhsT2Y5cU91MzFyQ3VpbkZNdnd3QSt0WUxQeWlN?=
 =?utf-8?B?RkJHeFRQU01RT3VXY3pDUDk1QjNyR1NpU2ZGZ1NmTnk4aVFMRVRvdVlPTmtD?=
 =?utf-8?B?MklnRzUxTG8ycFdIb0tGQjRCaDFLc1o4d2VUbDJCSUN1akw3MXFmOGlGbGVj?=
 =?utf-8?B?M3gyVUtVaXAzYkl6VXo3Q2ZjL3NrUzR3eGtxUE1JUTMrTDBjb093SW1wY0M3?=
 =?utf-8?B?QTJRRFdPUnZVNDFuMlNwNkxCclQzdVY4bW4vcXhmYW1EbkZBMkg0VmxyNVBO?=
 =?utf-8?B?aUFUbmhYa21IWkpyc0czMU0xcTY4cnROdjJBa01MS2lsKzRDdkMyMk8xQy9I?=
 =?utf-8?B?YXZYZm5nYzJmaDlKM2RFK1pNTGUrOCtyQTBxY0RVOGVNc085b2ZsTVFOeEJR?=
 =?utf-8?B?SWFHejZKZTB6SnJxRDBmN3pzZ0dVemJodkhIcEx6ODVxZEVtaGVRcXNxNFdx?=
 =?utf-8?B?WkxHTEEyV3pWVWZ0ejdZdlVmWHVrRVRobkwxN2xwY04yb0Q4Z0doRUR0YmFK?=
 =?utf-8?B?NmFuN1pvaUltbTZTMk1NNG9ab2kvWXpmai9ublBwdjl6UVhLMkxWUkN1TnhD?=
 =?utf-8?B?bjdWQ2Yxc0loL3RHV0lSMUhUTzRHM2tseXBDNWVqR3AvS0FGMDczaGlQWCsw?=
 =?utf-8?B?eXFEWkJVbFFTelRZY1ZVSVpOcXp2bmJ5NE9qaDE1ZXlQdnRFOFErays1QVhU?=
 =?utf-8?B?YlpQME4rUUtiM0pZckVlVGNuNk8rOXYwM2ZyTzk5OGMxTzZXTFlPSThWb2RN?=
 =?utf-8?B?SzBHbmZvR1pzRWlEeGl1VFhzU3dDQVMwR0NoR2d2c1FEMjJXSnNOYVhKeEFQ?=
 =?utf-8?B?bngyQXVJeGs5MEdFNXB2QlJnQXJRNjc1SEM2Smg4aU5qUVF3TGg2SGlXZnNW?=
 =?utf-8?B?RU9tdDJPUUNnM1lXY29UZFNXN3FaVEtSeEY3YTF3d0J2dTNEbUFSTW1lMHdi?=
 =?utf-8?B?cnpYNzAveU0yUnQreDk2TkN0Q1NWMnlGMk82SWFONGlXbS9XOUJDeFdMOHhR?=
 =?utf-8?B?OXBvN05qSzcxUnNRK0lFRkJOZHBvL1NHWEFwdmxGd2x3UkVocUc5UW5xeUdE?=
 =?utf-8?B?ZG1nOWxpSTI3RHpndzVjeXY5azR1aERrTThvbmFXcXlOanZUWmE3b0h2dzZZ?=
 =?utf-8?B?cW85UWZ1eFk1OVk2allyaHJ0OUFPaFFSQ09TR1hPUXViM2F5UEdDejU3UHVE?=
 =?utf-8?B?Q1o5VlNtdllqZW9tWGhMblJlWldTcmJtaVpZYjRsZWdDZDE1a0hzLzhWdU9h?=
 =?utf-8?B?blRjaDZoL09mMWVyc1JNVDhkdjN4Mkk3VjNZVzJhY0l0QUd3SVpQQU5VT216?=
 =?utf-8?B?cVBKNU4zZ2RJWngyS3drdTNMcGFOeWhJd1FranNMQzlmZTliUlRFVE9aYzBC?=
 =?utf-8?B?ZzZHRm9QbFVlUkhKN0ZoaHJMUmNHREloZjl6WktLeE9FVTdYQnR4dXhNcjBt?=
 =?utf-8?B?cmxrbEg2M2xuR0pHR3o0R0wrQTFFWmhEQmVYN1RRRHZEczVTM3hCRjYzVjZF?=
 =?utf-8?B?Ym1hdTNzUGxxV1VtbDlpeHlBa3FYOFNkYUFpWjBYbVlqUEV0b3A3dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5D451C0B9BF88B45B527D54C76F47E30@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 531877b6-47a6-4e3d-1dc8-08da24553271
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 11:42:36.3128
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HikqW1ap/mN5uwoCFpB6mDfVs8g2IkgjmPvapV8qHg3OvDCFi8DppQfaVSnB7QkZ0ARiU7CikE1qS6qVwWJQ89Fm3KH2lWjeWIfMCW+FnpQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3818

T24gMjIvMDQvMjAyMiAxMDo1OCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEVQVCBpcyBvZiBubyBp
bnRlcmVzdCB3aGVuICFIVk0uIFdoaWxlIEknbSBvYnNlcnZpbmcgZ2NjMTEgdG8gZnVsbHkNCj4g
ZWxpbWluYXRlIHRoZSBmdW5jdGlvbiwgb2xkZXIgZ2NjJ3MgRENFIGxvb2tzIHRvIG5vdCBiZSBh
cyBnb29kLiBBaWQgdGhlDQo+IGNvbXBpbGVyIGluIGVsaW1pbmF0aW5nIHRoZSBhY2Nlc3NlcyBv
ZiBvcHRfaGFwX3sybWIsMWdifSwgd2hpY2gNCj4gb3RoZXJ3aXNlIGNhdXNlIHVuZGVmaW5lZCBz
eW1ib2wgZXJyb3JzIHdoZW4gbGlua2luZy4NCg0KSSd2ZSBqdXN0IHJlcHJvZHVjZWQgaXQgb24g
R0NDIDExLCB1c2luZyBDT05GSUdfVUJTQU4gYXMgd2VsbC4NCg0KPg0KPiBXaGlsZSB0aGVyZSBh
ZGp1c3QgdHlwZXMuDQo+DQo+IEZpeGVzOiBjNDc5NDE1NjEwZjAgKCJ4ODYvUDJNOiBwMm0uYyBp
cyBIVk0tb25seSIpDQo+IFJlcG9ydGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy
M0BjaXRyaXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+DQoNClJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRy
aXguY29tPiwgcHJlZmVyYWJseSB3aXRoDQp0aGUgY29tbWl0IG1lc3NhZ2UgdHdlYWtlZC4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 11:56:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 11:56:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310850.527808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrth-000625-6B; Fri, 22 Apr 2022 11:56:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310850.527808; Fri, 22 Apr 2022 11:56:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrth-00061y-33; Fri, 22 Apr 2022 11:56:25 +0000
Received: by outflank-mailman (input) for mailman id 310850;
 Fri, 22 Apr 2022 11:56:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vZpq=VA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nhrtf-00061s-0v
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 11:56:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3a16878e-c233-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 13:56:21 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-1FQcOTp-MMiSMZ9psKjy2Q-1; Fri, 22 Apr 2022 13:56:20 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5919.eurprd04.prod.outlook.com (2603:10a6:803:eb::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 11:56:18 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 11:56:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a16878e-c233-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650628581;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=I4LwGOpsUZw5E+FSj4xztBrtq4Yu5US9sbJqhXKUb2U=;
	b=CvAMkBJ1/dpvc0TYbh627bFr12FoRO63cVNfwR+Vhasw7svzx8Xcr7vBBp0exFx2qhNDCT
	mRxl6dykW8RfxzN43vSJMvAYm+xUd4kfYGl5JZNb51dsNstwbOCjahgGEK2QWTS5DmQznQ
	Oi8C38egm+qaRdwgifgmQkf3t2vBEkM=
X-MC-Unique: 1FQcOTp-MMiSMZ9psKjy2Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cIN4LH0ARMZtldEf7zwpDZXToNYdR+4ROlThNC7tBz3ggqTbk9sCImR8aMWhsWc/zdC/rXLHIfSlAbNHuPpvI5emBO/kuR8Pdm2JUeV3QW4IxzBJEju9Hb9dr+Yhj3WOX7w4Zz1V9Se+KkylcXPUzgLxOYa95Ro0IUVWiXFoAzR5fVZ6U47QVL9g4+SX9vX/oWhlek/6SlkYW0uyctJTgqDJDUjGslzZy/ox8Kgo6k3/GVznU2K7pet+QacDfPHHxYQVhFQ6MFx9dxgIEAZid6DlAZ/dBU5084GwqXKlQkHyEiEREMEa5EM/JUNBNr4soJNruysfDn8UeKp6GUs+/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OYHP4Hj8cxj8+b8AVmKuZOBskLoXp/nmnzhsHZ5kjsY=;
 b=QSryXgmoBkqL57HckJYsXXyXFvI3vbLDrUvEIvRVTM0V793apV5uh3Vo4fmVHsdbxe84X7iaf1+GPPpNeNwUOFWU0gL9hNziRxqsdunu01mfgBGpS1vUi/wAympSwSH7ZGD52X1K/ZKmDQVBxx5LQKVjOsMnz8NTmAUUj8fDUdBEjfVZHJSFTYfEeMVGIsb0WXsFjeX6mKBp0Z0SpS5IUt4TH9MTy7ud84TZjdhMk8nBkP8xOk6O6qA5jVWzXiNOpiuNg+P9GuPSyBNlTxF5vx0tdHdqEav1kGprsxRnW56w7QvVNGC3uEa8DONJwnz1er7VXJPeLaW5D1P+DcmTgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <65e4428d-f89b-88c6-885c-7c0347e52861@suse.com>
Date: Fri, 22 Apr 2022 13:56:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH RFC] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
References: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>
 <YmKOMC1TcQQUB6Lx@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmKOMC1TcQQUB6Lx@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR03CA0008.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 154f6063-0505-4654-ad4f-08da24571c70
X-MS-TrafficTypeDiagnostic: VI1PR04MB5919:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5919E6FB991E935659F36D2AB3F79@VI1PR04MB5919.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nUcYFblhAJvCSELdNpH+QPMqfHnoKD3f0pwv5g78mA8rD/JFaNhH/4NVUP1MffVW1TdP9rrOzc+GyR85yjt0zReLfuDK20qv7Q1r3LLri/G6ETqSAhScgRK6ifD4PlTGmyx0ayKkKrNA7De31YPSaOgz8y0XE4Lh48PVsdqP2pa0takxyCdfxHQNZKZCF8zcEAs4uCT8ozA2FLvVowpvQNH44nG0lSzMAGlsQDtzJvonjsq9hxLCdNJFuVQCChR4y0y6aX3i4EqpNANbNHaOqJLlYBHxSrORa4pPfMt1MEd/x4C1WTg/BnPtjWo6xR8LecTB6tIvfp9KTGDmXD9zSbgdR3ggpxcp8HRUxd4g2j//l6lX51JH9n6qum2aQ2ktk7MFjcTrxW/oguN2TNYMIJlL9yeYbO1DtXiVJL0DfOFxmCAKqXIEJ+NH2MjtleUDh//BHCwUleEm7ezWtWX0cQyv9QlYmviwrhwooDtzCEA7okc6BfbYfvFYPN+m78Nfp1YSHicFsCF10/7sB28pjavqBzdbL3lj2rLvvLCFhQGxuQg7B1oYOe7lCAMD/X0Mmj8h9peaEA8CsEIuRnk9cbylGKSn3mLmtedphv9Opl0Up358jKkQaaP2U1RXJh1fcRGTDsu2CsISAUij8bcTeIDvjCS6CWWnJHBMyYsOMUNSQyxxlFoSK2tN0YGC3eq19Ir3IYK2bFZEVQPrRTw3uplQb7eKXKBdrLFDIxACswU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(8936002)(38100700002)(86362001)(508600001)(2906002)(26005)(6512007)(53546011)(8676002)(5660300002)(6506007)(4326008)(66556008)(66476007)(54906003)(6916009)(186003)(83380400001)(316002)(6486002)(36756003)(2616005)(31686004)(107886003)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?nahM/jX6RiSiqc1VsfCM3ZttaPTC2qRh4/F6SJJc6snX8Gx3jodTCq8YEsKE?=
 =?us-ascii?Q?635S7TGMb1TD5Rsqur35aO+BvC9FEgbdPQMPjHgPDlvYt4/eoD5SCDWDgSy3?=
 =?us-ascii?Q?QW4JH++N46q9KTwf2T+Ninhryv6Ne2p89XhYpAec9fL/l+ihZDN57wMy9dFm?=
 =?us-ascii?Q?+tadcCbFVkA3Gr/mt/RqUItQUsH9oCua8bhGGwNBo0/lMLAbMPM7mW4QI3KQ?=
 =?us-ascii?Q?F+o69PT6MWV1CYAJbVd8JE25cc6Ob0ltmy+puDbtdx1elTVRm1whH5fqn5EC?=
 =?us-ascii?Q?RQCp8GTFwuRH1j0uXHLB19YFeI0R8mCmFPNk03MjdYVtpRUJd3GqDsNCF3c+?=
 =?us-ascii?Q?0aheIRT9VHuD+xrc5ccNxHrl+WRFt30BoZaZTS963dD2eiHFCKvSu7EHJHwn?=
 =?us-ascii?Q?GQdiAnj4ybM/b6aQoU7H8xZDm/cyxXbG47ZWM8ri+rAmHaOSVlTbLIKwfQt5?=
 =?us-ascii?Q?p6TJRCUdMZgvCtFF5IIII2mXHGBPxdFyMs0G+I5Hymv+nT09Mz7xASH2cfzz?=
 =?us-ascii?Q?OxIh/aiIwyXFpwi5YzFQEWIefAfB1wVinEglRWnTHLScxVHVLjOL/DGMs7bL?=
 =?us-ascii?Q?l0kYwy9h6PDqn0HqnTeMAgvOAmG0Ni7Bt5Av/ppfx6eZ1rAIF8DhL4HPz6sW?=
 =?us-ascii?Q?51+EEQHrNu1ZYBKCXxZL+eJpXg7l/3XUcQdoHCAOx5xrOSwvXePlPaANwlD+?=
 =?us-ascii?Q?CvAn8sVK4jSRBUXVDB467l8wb9NUUHGZ7zdPLu/hK66pd1TyK96o+lTWl1jf?=
 =?us-ascii?Q?VD3UJ0x+wpUgivYHGUPoNZHLMNUC3qUEXNTxNNrsYU4RB9HMp0Nt/VH01vXn?=
 =?us-ascii?Q?q0O9mRjv6C/FI6mWvVieyTPhLEspQbdtQcKDmj2SwMPLzE6j8lUrFBp5aQfC?=
 =?us-ascii?Q?0dC53mhKN4K8OKYiXfWkV3/S8xPbBlRgze3XmmA36F3rnbfCUNaiwzV5rupn?=
 =?us-ascii?Q?1Mw2/wME3QZOeU8235WmHYcsU36ReJR3j7Mgt2LPEDTG2MNdVEkUx8wnZzys?=
 =?us-ascii?Q?MkZshJp9bL4mLW9499rQPWmcoK32AbrAuqjF5nSwiq6RNi2glP3zOqQMQfw1?=
 =?us-ascii?Q?56BxemWX/dER4HtJQuu4kUWeRRMelGunqMdujNMMf5VQk+KL7BHBu+U5pp6u?=
 =?us-ascii?Q?kGPCioGvsBiUNV0uzUTo5ALS1HQapLDusZL3M5ElHzIpurfKTRkmJjl7qLqB?=
 =?us-ascii?Q?t9lIiYMrtk0Snf4XHVRcED+qQtMl4Z2QhRYhuAnTTTBwqABYh6XpjNQ9wF5p?=
 =?us-ascii?Q?oQfvGJl7KZHk/7R5AuQ4Og8mhrBXp3qe5Vcychbpz+WhOzXtSHn0Y9bj1fka?=
 =?us-ascii?Q?B5v/G3xJtUTtnkDfAyxqc2T238VZWoIZpbp75Op9IbQCPhJdYbZFVPAeew+u?=
 =?us-ascii?Q?pSaXFBcGFgKSAKIOWPm19Y0RmDvDFMjqB0ljXC1z843qX2z+tmjKvhpFrWLN?=
 =?us-ascii?Q?MCNCOdv/xGBXvHni6W60HGg9X3A0VLvzIAjXxS0bgN0gZSGHKk66BSLrbSmZ?=
 =?us-ascii?Q?biKLnEV2ks2BUAQIzgkp/1XbowrgL2vIrqLg7QEPYdRzHDwHqe/WqhxXUvUW?=
 =?us-ascii?Q?cE00DySQ/Ga8hlXPep2EtNkFsNnnWPekaDeLVnHAg80qP+eX88utqJNFM7OG?=
 =?us-ascii?Q?8/90Rt3OVbMn49bYLj3BFWN+13vg4sFHXgPJQNNoD2e4D5USL14f5FL235Ls?=
 =?us-ascii?Q?Jz3V708OFTnBj6C2Wk5qsNL3G45mrk/4cHerrAGaz1loTB/AwKTUXFJQ81kL?=
 =?us-ascii?Q?ZptKJ6JFfw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 154f6063-0505-4654-ad4f-08da24571c70
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 11:56:18.5798
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AmVq8bQLrZDHZm/NwZAXbAYWNxpC+xxA+CqZuP0ci4nyvcix28BfWoA/HhwtEPje4RhZO5TbA5v75Kq2OwX/YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5919

On 22.04.2022 13:14, Roger Pau Monn=C3=A9 wrote:
> On Fri, Apr 22, 2022 at 12:57:03PM +0200, Jan Beulich wrote:
>> The reference "to shadow the resident processes" is applicable to
>> domains (potentially) running in shadow mode only. Adjust the
>> calculations accordingly.
>>
>> In dom0_paging_pages() also take the opportunity and stop open-coding
>> DIV_ROUND_UP().
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> RFC: I'm pretty sure I can't change a public libxl function (deprecated
>>      or not) like this, but I also don't know how I should go about
>>      doing so (short of introducing a brand new function and leaving the
>>      existing one broken).
>=20
> You have to play with LIBXL_API_VERSION, see for example:
>=20
> 1e3304005e libxl: Make libxl_retrieve_domain_configuration async
>=20
>>
>> --- a/tools/include/libxl_utils.h
>> +++ b/tools/include/libxl_utils.h
>> @@ -23,7 +23,10 @@ const
>>  #endif
>>  char *libxl_basename(const char *name); /* returns string from strdup *=
/
>> =20
>> -unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb,=
 unsigned int smp_cpus);
>> +unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb,
>> +                                               unsigned int smp_cpus,
>> +                                               libxl_domain_type type,
>> +                                               bool hap);
>=20
> Iff we are to change this anyway, we might as well rename the
> function and introduce a proper
> libxl_get_required_{paging,p2m}_memory?
>=20
> It seems wrong to have a function explicitly named 'shadow' that takes
> a 'hap' parameter.
>=20
> If you introduce a new function there's no need to play with the
> LIBXL_API_VERSION and you can just add a new LIBXL_HAVE_FOO define.

With the original function deprecated, I don't see why I'd need to
make a new public function - my fallback plan was (as also suggested
by J=C3=BCrgen) to make a new internal function.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 11:59:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 11:59:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310855.527819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrwv-0006dZ-LU; Fri, 22 Apr 2022 11:59:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310855.527819; Fri, 22 Apr 2022 11:59:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhrwv-0006dS-IY; Fri, 22 Apr 2022 11:59:45 +0000
Received: by outflank-mailman (input) for mailman id 310855;
 Fri, 22 Apr 2022 11:59:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhrwv-0006dI-2x; Fri, 22 Apr 2022 11:59:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhrwv-0000X9-1H; Fri, 22 Apr 2022 11:59:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhrwu-0004IC-Gf; Fri, 22 Apr 2022 11:59:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhrwu-0001Gh-GD; Fri, 22 Apr 2022 11:59:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4EySfWLAawE9lkpQ0HoBR7r/AEFztpgMa6EE38mAn9s=; b=D8U9SIcY+ZgamQ0DAjbMNu7jjd
	LWHqy0sCy3L1+SUszJfVMHcD7NVXDaf5NCUfbmd4Nvryk/+DDKVcujkLeUcUPCP1CXFUZYWEMQINX
	d1MVX9hR6bTKdzebKQcMgecMFqar028IJVWrk24/CvtRwG6cO7fXIHce8Zxncy3VTl+g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169618-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169618: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=2306555bf9081ae9979405f96428738807e580d4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 11:59:44 +0000

flight 169618 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169618/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 2306555bf9081ae9979405f96428738807e580d4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  552 attempts
Testing same since   169610  2022-04-22 04:01:05 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5625 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 12:07:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 12:07:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310865.527830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhs4j-0008R3-M2; Fri, 22 Apr 2022 12:07:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310865.527830; Fri, 22 Apr 2022 12:07:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhs4j-0008Qw-Iw; Fri, 22 Apr 2022 12:07:49 +0000
Received: by outflank-mailman (input) for mailman id 310865;
 Fri, 22 Apr 2022 12:07:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aXhv=VA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhs4i-0008Qq-CL
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 12:07:48 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d2596e81-c234-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 14:07:46 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 397BC215FD;
 Fri, 22 Apr 2022 12:07:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E850713AE1;
 Fri, 22 Apr 2022 12:07:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id rnJkN5GaYmIMTgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Apr 2022 12:07:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2596e81-c234-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650629266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=cozC/OlY257qG9c7Byxz1SGhm8ljn75GCvjIzYZFZx8=;
	b=eZUyu/u6nE3sS+xdGmb7R/LgUVSktC9gOTWF3+gZwf/ZXPE7JM+QaUQPtjSwAYfSoWPkk6
	IpAQz0NyVi9uCrkin4uK3HWZuMaiuMSdUjwqS/yZPylPk2/P4O7LIGHx5IcMu1GTPr8wPI
	wtjClYimIv49qoIJExzbjB/ve3ij8uw=
Message-ID: <86bc7ae3-d7af-5f6e-d246-b53a4fa8bc79@suse.com>
Date: Fri, 22 Apr 2022 14:07:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Content-Language: en-US
To: Rahul Singh <Rahul.Singh@arm.com>, Christoph Hellwig <hch@lst.de>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>,
 Jan Beulich <jbeulich@suse.com>,
 "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
References: <20220415063705.GA24262@lst.de>
 <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
 <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
 <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
 <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop>
 <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com>
 <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop>
 <12279FAE-2141-469E-A424-9984348E84BB@arm.com>
 <alpine.DEB.2.22.394.2204211444190.915916@ubuntu-linux-20-04-desktop>
 <20220422050405.GA10195@lst.de>
 <105DB518-DB5B-47F8-852F-C997678BBCE6@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <105DB518-DB5B-47F8-852F-C997678BBCE6@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------A5cKStjg7q0kKlp0COTm95Xs"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------A5cKStjg7q0kKlp0COTm95Xs
Content-Type: multipart/mixed; boundary="------------NkXXPDbtcnXod9351OiXTw0T";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Rahul Singh <Rahul.Singh@arm.com>, Christoph Hellwig <hch@lst.de>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>,
 Jan Beulich <jbeulich@suse.com>,
 "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Message-ID: <86bc7ae3-d7af-5f6e-d246-b53a4fa8bc79@suse.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
References: <20220415063705.GA24262@lst.de>
 <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop>
 <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com>
 <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop>
 <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop>
 <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com>
 <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop>
 <12279FAE-2141-469E-A424-9984348E84BB@arm.com>
 <alpine.DEB.2.22.394.2204211444190.915916@ubuntu-linux-20-04-desktop>
 <20220422050405.GA10195@lst.de>
 <105DB518-DB5B-47F8-852F-C997678BBCE6@arm.com>
In-Reply-To: <105DB518-DB5B-47F8-852F-C997678BBCE6@arm.com>

--------------NkXXPDbtcnXod9351OiXTw0T
Content-Type: multipart/mixed; boundary="------------cKiYT7vpGgRmMi0Z4ql00Vsl"

--------------cKiYT7vpGgRmMi0Z4ql00Vsl
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjIuMDQuMjIgMTM6MzQsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPiBIZWxsbyBTdGVmYW5v
LCBDaHJpc3RvcGgsDQo+IA0KPj4gT24gMjIgQXByIDIwMjIsIGF0IDY6MDQgYW0sIENocmlz
dG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPiB3cm90ZToNCj4+DQo+PiBPbiBUaHUsIEFwciAy
MSwgMjAyMiBhdCAwMzowMTozMlBNIC0wNzAwLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6
DQo+Pj4gc3dpb3RsYi14ZW46IGhhbmRsZSBETUFfQVRUUl9OT19LRVJORUxfTUFQUElORw0K
Pj4+DQo+Pj4gSWYgRE1BX0FUVFJfTk9fS0VSTkVMX01BUFBJTkcgaXMgc2V0IHRoZW4gdGhl
IHJldHVybmVkIHZhZGRyIGlzIGEgc3RydWN0DQo+Pj4gKnBhZ2UgaW5zdGVhZCBvZiB0aGUg
dmlydHVhbCBtYXBwaW5nIG9mIHRoZSBidWZmZXIuDQo+Pj4NCj4+PiBJbiB4ZW5fc3dpb3Rs
Yl9hbGxvY19jb2hlcmVudCwgZG8gbm90IGNhbGwgdmlydF90b19wYWdlLCBpbnN0ZWFkIHVz
ZSB0aGUNCj4+PiByZXR1cm5lZCBwb2ludGVyIGRpcmVjdGx5LiBBbHNvIGRvIG5vdCBtZW1z
ZXQgdGhlIGJ1ZmZlciBvciBzdHJ1Y3QgcGFnZQ0KPj4+IHRvIHplcm8uDQo+Pj4NCj4+PiBJ
biB4ZW5fc3dpb3RsYl9mcmVlX2NvaGVyZW50LCBjaGVjayBETUFfQVRUUl9OT19LRVJORUxf
TUFQUElORyBhbmQgc2V0DQo+Pj4gdGhlIHBhZ2UgcG9pbnRlciBhcHByb3ByaWF0ZWx5Lg0K
Pj4NCj4+IFNvbWV0aGluZyBsaWtlIHRoYXQgc2hvdWxkIHdvcmssIGJ1dCBpdCBtYWtlcyBz
d2lvdGxiLXhlbiBwb2tlIGV2ZW4NCj4+IG1vcmUgaW50byB0aGUgb3BhcXVlIGRtYS1kaXJl
Y3QgaW50ZXJuYWxzLiAgSSdkIHJhdGhlciBkbyBzb21ldGhpbmcNCj4+IGxpa2UgdGhlIHBh
dGNoIGJlbG93IHRoYXQgdXNlcyB0aGUgZG1hX2RpcmVjdCBhbGxvY2F0b3IgZGlyZWN0bHkg
Zm9yDQo+PiBhcm0sIGFuZCBzaW1wbGlmaWVzIHRoZSB4ZW4tc3dpb3RsYiBhbGxvY2F0b3Ig
bm93IHRoYXQgaXQganVzdCBuZWVkcw0KPj4gdG8gY2F0ZXIgdG8gdGhlIHg4NiBjYXNlOg0K
Pj4NCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9pbmNsdWRlL2FzbS94ZW4vcGFnZS1jb2hl
cmVudC5oIGIvYXJjaC9hcm0vaW5jbHVkZS9hc20veGVuL3BhZ2UtY29oZXJlbnQuaA0KPj4g
ZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAyN2U5ODQ5Nzc0MDJiLi4wMDAw
MDAwMDAwMDAwDQo+PiAtLS0gYS9hcmNoL2FybS9pbmNsdWRlL2FzbS94ZW4vcGFnZS1jb2hl
cmVudC5oDQo+PiArKysgL2Rldi9udWxsDQo+PiBAQCAtMSwyICswLDAgQEANCj4+IC0vKiBT
UERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMCAqLw0KPj4gLSNpbmNsdWRlIDx4ZW4v
YXJtL3BhZ2UtY29oZXJlbnQuaD4NCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS94ZW4vbW0u
YyBiL2FyY2gvYXJtL3hlbi9tbS5jDQo+PiBpbmRleCBhN2U1NGEwODdiODAyLi42ZTYwM2U1
ZmRlYmIxIDEwMDY0NA0KPj4gLS0tIGEvYXJjaC9hcm0veGVuL21tLmMNCj4+ICsrKyBiL2Fy
Y2gvYXJtL3hlbi9tbS5jDQo+PiBAQCAtMTE4LDIzICsxMTgsNiBAQCBib29sIHhlbl9hcmNo
X25lZWRfc3dpb3RsYihzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiAJCSFkZXZfaXNfZG1hX2Nv
aGVyZW50KGRldikpOw0KPj4gfQ0KPj4NCj4+IC1pbnQgeGVuX2NyZWF0ZV9jb250aWd1b3Vz
X3JlZ2lvbihwaHlzX2FkZHJfdCBwc3RhcnQsIHVuc2lnbmVkIGludCBvcmRlciwNCj4+IC0J
CQkJIHVuc2lnbmVkIGludCBhZGRyZXNzX2JpdHMsDQo+PiAtCQkJCSBkbWFfYWRkcl90ICpk
bWFfaGFuZGxlKQ0KPj4gLXsNCj4+IC0JaWYgKCF4ZW5faW5pdGlhbF9kb21haW4oKSkNCj4+
IC0JCXJldHVybiAtRUlOVkFMOw0KPj4gLQ0KPj4gLQkvKiB3ZSBhc3N1bWUgdGhhdCBkb20w
IGlzIG1hcHBlZCAxOjEgZm9yIG5vdyAqLw0KPj4gLQkqZG1hX2hhbmRsZSA9IHBzdGFydDsN
Cj4+IC0JcmV0dXJuIDA7DQo+PiAtfQ0KPj4gLQ0KPj4gLXZvaWQgeGVuX2Rlc3Ryb3lfY29u
dGlndW91c19yZWdpb24ocGh5c19hZGRyX3QgcHN0YXJ0LCB1bnNpZ25lZCBpbnQgb3JkZXIp
DQo+PiAtew0KPj4gLQlyZXR1cm47DQo+PiAtfQ0KPj4gLQ0KPj4gc3RhdGljIGludCBfX2lu
aXQgeGVuX21tX2luaXQodm9pZCkNCj4+IHsNCj4+IAlzdHJ1Y3QgZ250dGFiX2NhY2hlX2Zs
dXNoIGNmbHVzaDsNCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL3hl
bi9wYWdlLWNvaGVyZW50LmggYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL3hlbi9wYWdlLWNv
aGVyZW50LmgNCj4+IGRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NA0KPj4gaW5kZXggMjdlOTg0
OTc3NDAyYi4uMDAwMDAwMDAwMDAwMA0KPj4gLS0tIGEvYXJjaC9hcm02NC9pbmNsdWRlL2Fz
bS94ZW4vcGFnZS1jb2hlcmVudC5oDQo+PiArKysgL2Rldi9udWxsDQo+PiBAQCAtMSwyICsw
LDAgQEANCj4+IC0vKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMCAqLw0KPj4g
LSNpbmNsdWRlIDx4ZW4vYXJtL3BhZ2UtY29oZXJlbnQuaD4NCj4+IGRpZmYgLS1naXQgYS9h
cmNoL3g4Ni9pbmNsdWRlL2FzbS94ZW4vcGFnZS1jb2hlcmVudC5oIGIvYXJjaC94ODYvaW5j
bHVkZS9hc20veGVuL3BhZ2UtY29oZXJlbnQuaA0KPj4gZGVsZXRlZCBmaWxlIG1vZGUgMTAw
NjQ0DQo+PiBpbmRleCA2M2NkNDFiMmUxN2FjLi4wMDAwMDAwMDAwMDAwDQo+PiAtLS0gYS9h
cmNoL3g4Ni9pbmNsdWRlL2FzbS94ZW4vcGFnZS1jb2hlcmVudC5oDQo+PiArKysgL2Rldi9u
dWxsDQo+PiBAQCAtMSwyNCArMCwwIEBADQo+PiAtLyogU1BEWC1MaWNlbnNlLUlkZW50aWZp
ZXI6IEdQTC0yLjAgKi8NCj4+IC0jaWZuZGVmIF9BU01fWDg2X1hFTl9QQUdFX0NPSEVSRU5U
X0gNCj4+IC0jZGVmaW5lIF9BU01fWDg2X1hFTl9QQUdFX0NPSEVSRU5UX0gNCj4+IC0NCj4+
IC0jaW5jbHVkZSA8YXNtL3BhZ2UuaD4NCj4+IC0jaW5jbHVkZSA8bGludXgvZG1hLW1hcHBp
bmcuaD4NCj4+IC0NCj4+IC1zdGF0aWMgaW5saW5lIHZvaWQgKnhlbl9hbGxvY19jb2hlcmVu
dF9wYWdlcyhzdHJ1Y3QgZGV2aWNlICpod2Rldiwgc2l6ZV90IHNpemUsDQo+PiAtCQlkbWFf
YWRkcl90ICpkbWFfaGFuZGxlLCBnZnBfdCBmbGFncywNCj4+IC0JCXVuc2lnbmVkIGxvbmcg
YXR0cnMpDQo+PiAtew0KPj4gLQl2b2lkICp2c3RhcnQgPSAodm9pZCopX19nZXRfZnJlZV9w
YWdlcyhmbGFncywgZ2V0X29yZGVyKHNpemUpKTsNCj4+IC0JKmRtYV9oYW5kbGUgPSB2aXJ0
X3RvX3BoeXModnN0YXJ0KTsNCj4+IC0JcmV0dXJuIHZzdGFydDsNCj4+IC19DQo+PiAtDQo+
PiAtc3RhdGljIGlubGluZSB2b2lkIHhlbl9mcmVlX2NvaGVyZW50X3BhZ2VzKHN0cnVjdCBk
ZXZpY2UgKmh3ZGV2LCBzaXplX3Qgc2l6ZSwNCj4+IC0JCXZvaWQgKmNwdV9hZGRyLCBkbWFf
YWRkcl90IGRtYV9oYW5kbGUsDQo+PiAtCQl1bnNpZ25lZCBsb25nIGF0dHJzKQ0KPj4gLXsN
Cj4+IC0JZnJlZV9wYWdlcygodW5zaWduZWQgbG9uZykgY3B1X2FkZHIsIGdldF9vcmRlcihz
aXplKSk7DQo+PiAtfQ0KPj4gLQ0KPj4gLSNlbmRpZiAvKiBfQVNNX1g4Nl9YRU5fUEFHRV9D
T0hFUkVOVF9IICovDQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vc3dpb3RsYi14ZW4u
YyBiL2RyaXZlcnMveGVuL3N3aW90bGIteGVuLmMNCj4+IGluZGV4IDQ3YWViZDk4ZjUyZjUu
LjU1N2VkYjljNTQ4NzkgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL3hlbi9zd2lvdGxiLXhl
bi5jDQo+PiArKysgYi9kcml2ZXJzL3hlbi9zd2lvdGxiLXhlbi5jDQo+PiBAQCAtMzYsNyAr
MzYsNiBAQA0KPj4gI2luY2x1ZGUgPHhlbi9odmMtY29uc29sZS5oPg0KPj4NCj4+ICNpbmNs
dWRlIDxhc20vZG1hLW1hcHBpbmcuaD4NCj4+IC0jaW5jbHVkZSA8YXNtL3hlbi9wYWdlLWNv
aGVyZW50Lmg+DQo+Pg0KPj4gI2luY2x1ZGUgPHRyYWNlL2V2ZW50cy9zd2lvdGxiLmg+DQo+
PiAjZGVmaW5lIE1BWF9ETUFfQklUUyAzMg0KPj4gQEAgLTEwNCw2ICsxMDMsNyBAQCBzdGF0
aWMgaW50IGlzX3hlbl9zd2lvdGxiX2J1ZmZlcihzdHJ1Y3QgZGV2aWNlICpkZXYsIGRtYV9h
ZGRyX3QgZG1hX2FkZHIpDQo+PiAJcmV0dXJuIDA7DQo+PiB9DQo+Pg0KPj4gKyNpZmRlZiBD
T05GSUdfWDg2DQo+PiBzdGF0aWMgaW50IHhlbl9zd2lvdGxiX2ZpeHVwKHZvaWQgKmJ1Ziwg
dW5zaWduZWQgbG9uZyBuc2xhYnMpDQo+PiB7DQo+PiAJaW50IHJjOw0KPj4gQEAgLTEyOSw2
ICsxMjksMTIgQEAgc3RhdGljIGludCB4ZW5fc3dpb3RsYl9maXh1cCh2b2lkICpidWYsIHVu
c2lnbmVkIGxvbmcgbnNsYWJzKQ0KPj4gCX0gd2hpbGUgKGkgPCBuc2xhYnMpOw0KPj4gCXJl
dHVybiAwOw0KPj4gfQ0KPj4gKyNlbHNlDQo+PiArc3RhdGljIGludCB4ZW5fc3dpb3RsYl9m
aXh1cCh2b2lkICpidWYsIHVuc2lnbmVkIGxvbmcgbnNsYWJzKQ0KPj4gK3sNCj4+ICsJcmV0
dXJuIDA7DQo+PiArfQ0KPj4gKyNlbmRpZg0KPj4NCj4+IGVudW0geGVuX3N3aW90bGJfZXJy
IHsNCj4+IAlYRU5fU1dJT1RMQl9VTktOT1dOID0gMCwNCj4+IEBAIC0yNTYsOTcgKzI2Miw2
MCBAQCB2b2lkIF9faW5pdCB4ZW5fc3dpb3RsYl9pbml0X2Vhcmx5KHZvaWQpDQo+PiAJCXBh
bmljKCJDYW5ub3QgYWxsb2NhdGUgU1dJT1RMQiBidWZmZXIiKTsNCj4+IAlzd2lvdGxiX3Nl
dF9tYXhfc2VnbWVudChQQUdFX1NJWkUpOw0KPj4gfQ0KPj4gLSNlbmRpZiAvKiBDT05GSUdf
WDg2ICovDQo+Pg0KPj4gc3RhdGljIHZvaWQgKg0KPj4gLXhlbl9zd2lvdGxiX2FsbG9jX2Nv
aGVyZW50KHN0cnVjdCBkZXZpY2UgKmh3ZGV2LCBzaXplX3Qgc2l6ZSwNCj4+IC0JCQkgICBk
bWFfYWRkcl90ICpkbWFfaGFuZGxlLCBnZnBfdCBmbGFncywNCj4+IC0JCQkgICB1bnNpZ25l
ZCBsb25nIGF0dHJzKQ0KPj4gK3hlbl9zd2lvdGxiX2FsbG9jX2NvaGVyZW50KHN0cnVjdCBk
ZXZpY2UgKmRldiwgc2l6ZV90IHNpemUsDQo+PiArCQlkbWFfYWRkcl90ICpkbWFfaGFuZGxl
LCBnZnBfdCBmbGFncywgdW5zaWduZWQgbG9uZyBhdHRycykNCj4+IHsNCj4+IC0Jdm9pZCAq
cmV0Ow0KPj4gKwl1NjQgZG1hX21hc2sgPSBkZXYtPmNvaGVyZW50X2RtYV9tYXNrOw0KPj4g
CWludCBvcmRlciA9IGdldF9vcmRlcihzaXplKTsNCj4+IC0JdTY0IGRtYV9tYXNrID0gRE1B
X0JJVF9NQVNLKDMyKTsNCj4+IAlwaHlzX2FkZHJfdCBwaHlzOw0KPj4gLQlkbWFfYWRkcl90
IGRldl9hZGRyOw0KPj4gLQ0KPj4gLQkvKg0KPj4gLQkqIElnbm9yZSByZWdpb24gc3BlY2lm
aWVycyAtIHRoZSBrZXJuZWwncyBpZGVhcyBvZg0KPj4gLQkqIHBzZXVkby1waHlzIG1lbW9y
eSBsYXlvdXQgaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCB0aGUNCj4+IC0JKiBtYWNoaW5lIHBo
eXNpY2FsIGxheW91dC4gIFdlIGNhbid0IGFsbG9jYXRlIGhpZ2htZW0NCj4+IC0JKiBiZWNh
dXNlIHdlIGNhbid0IHJldHVybiBhIHBvaW50ZXIgdG8gaXQuDQo+PiAtCSovDQo+PiAtCWZs
YWdzICY9IH4oX19HRlBfRE1BIHwgX19HRlBfSElHSE1FTSk7DQo+PiArCXZvaWQgKnJldDsN
Cj4+DQo+PiAtCS8qIENvbnZlcnQgdGhlIHNpemUgdG8gYWN0dWFsbHkgYWxsb2NhdGVkLiAq
Lw0KPj4gKwkvKiBBbGlnbiB0aGUgYWxsb2NhdGlvbiB0byB0aGUgWGVuIHBhZ2Ugc2l6ZSAq
Lw0KPj4gCXNpemUgPSAxVUwgPDwgKG9yZGVyICsgWEVOX1BBR0VfU0hJRlQpOw0KPj4NCj4+
IC0JLyogT24gQVJNIHRoaXMgZnVuY3Rpb24gcmV0dXJucyBhbiBpb3JlbWFwJ3BlZCB2aXJ0
dWFsIGFkZHJlc3MgZm9yDQo+PiAtCSAqIHdoaWNoIHZpcnRfdG9fcGh5cyBkb2Vzbid0IHJl
dHVybiB0aGUgY29ycmVzcG9uZGluZyBwaHlzaWNhbA0KPj4gLQkgKiBhZGRyZXNzLiBJbiBm
YWN0IG9uIEFSTSB2aXJ0X3RvX3BoeXMgb25seSB3b3JrcyBmb3Iga2VybmVsIGRpcmVjdA0K
Pj4gLQkgKiBtYXBwZWQgUkFNIG1lbW9yeS4gQWxzbyBzZWUgY29tbWVudCBiZWxvdy4NCj4+
IC0JICovDQo+PiAtCXJldCA9IHhlbl9hbGxvY19jb2hlcmVudF9wYWdlcyhod2Rldiwgc2l6
ZSwgZG1hX2hhbmRsZSwgZmxhZ3MsIGF0dHJzKTsNCj4+IC0NCj4+ICsJcmV0ID0gKHZvaWQg
KilfX2dldF9mcmVlX3BhZ2VzKGZsYWdzLCBnZXRfb3JkZXIoc2l6ZSkpOw0KPj4gCWlmICgh
cmV0KQ0KPj4gCQlyZXR1cm4gcmV0Ow0KPj4gLQ0KPj4gLQlpZiAoaHdkZXYgJiYgaHdkZXYt
PmNvaGVyZW50X2RtYV9tYXNrKQ0KPj4gLQkJZG1hX21hc2sgPSBod2Rldi0+Y29oZXJlbnRf
ZG1hX21hc2s7DQo+PiAtDQo+PiAtCS8qIEF0IHRoaXMgcG9pbnQgZG1hX2hhbmRsZSBpcyB0
aGUgZG1hIGFkZHJlc3MsIG5leHQgd2UgYXJlDQo+PiAtCSAqIGdvaW5nIHRvIHNldCBpdCB0
byB0aGUgbWFjaGluZSBhZGRyZXNzLg0KPj4gLQkgKiBEbyBub3QgdXNlIHZpcnRfdG9fcGh5
cyhyZXQpIGJlY2F1c2Ugb24gQVJNIGl0IGRvZXNuJ3QgY29ycmVzcG9uZA0KPj4gLQkgKiB0
byAqZG1hX2hhbmRsZS4gKi8NCj4+IC0JcGh5cyA9IGRtYV90b19waHlzKGh3ZGV2LCAqZG1h
X2hhbmRsZSk7DQo+PiAtCWRldl9hZGRyID0geGVuX3BoeXNfdG9fZG1hKGh3ZGV2LCBwaHlz
KTsNCj4+IC0JaWYgKCgoZGV2X2FkZHIgKyBzaXplIC0gMSA8PSBkbWFfbWFzaykpICYmDQo+
PiAtCSAgICAhcmFuZ2Vfc3RyYWRkbGVzX3BhZ2VfYm91bmRhcnkocGh5cywgc2l6ZSkpDQo+
PiAtCQkqZG1hX2hhbmRsZSA9IGRldl9hZGRyOw0KPj4gLQllbHNlIHsNCj4+IC0JCWlmICh4
ZW5fY3JlYXRlX2NvbnRpZ3VvdXNfcmVnaW9uKHBoeXMsIG9yZGVyLA0KPj4gLQkJCQkJCSBm
bHM2NChkbWFfbWFzayksIGRtYV9oYW5kbGUpICE9IDApIHsNCj4+IC0JCQl4ZW5fZnJlZV9j
b2hlcmVudF9wYWdlcyhod2Rldiwgc2l6ZSwgcmV0LCAoZG1hX2FkZHJfdClwaHlzLCBhdHRy
cyk7DQo+PiAtCQkJcmV0dXJuIE5VTEw7DQo+PiAtCQl9DQo+PiAtCQkqZG1hX2hhbmRsZSA9
IHBoeXNfdG9fZG1hKGh3ZGV2LCAqZG1hX2hhbmRsZSk7DQo+PiArCXBoeXMgPSB2aXJ0X3Rv
X3BoeXMocmV0KTsNCj4+ICsNCj4+ICsJKmRtYV9oYW5kbGUgPSB4ZW5fcGh5c190b19kbWEo
ZGV2LCBwaHlzKTsNCj4+ICsJaWYgKCpkbWFfaGFuZGxlICsgc2l6ZSAtIDEgPiBkbWFfbWFz
ayB8fA0KPj4gKwkgICAgcmFuZ2Vfc3RyYWRkbGVzX3BhZ2VfYm91bmRhcnkocGh5cywgc2l6
ZSkpIHsNCj4+ICsJCWlmICh4ZW5fY3JlYXRlX2NvbnRpZ3VvdXNfcmVnaW9uKHBoeXMsIG9y
ZGVyLCBmbHM2NChkbWFfbWFzayksDQo+PiArCQkJCWRtYV9oYW5kbGUpICE9IDApDQo+PiAr
CQkJZ290byBvdXRfZnJlZV9wYWdlczsNCj4+IAkJU2V0UGFnZVhlblJlbWFwcGVkKHZpcnRf
dG9fcGFnZShyZXQpKTsNCj4+IAl9DQo+PiArDQo+PiAJbWVtc2V0KHJldCwgMCwgc2l6ZSk7
DQo+PiAJcmV0dXJuIHJldDsNCj4+ICsNCj4+ICtvdXRfZnJlZV9wYWdlczoNCj4+ICsJZnJl
ZV9wYWdlcygodW5zaWduZWQgbG9uZylyZXQsIGdldF9vcmRlcihzaXplKSk7DQo+PiArCXJl
dHVybiBOVUxMOw0KPj4gfQ0KPj4NCj4+IHN0YXRpYyB2b2lkDQo+PiAteGVuX3N3aW90bGJf
ZnJlZV9jb2hlcmVudChzdHJ1Y3QgZGV2aWNlICpod2Rldiwgc2l6ZV90IHNpemUsIHZvaWQg
KnZhZGRyLA0KPj4gLQkJCSAgZG1hX2FkZHJfdCBkZXZfYWRkciwgdW5zaWduZWQgbG9uZyBh
dHRycykNCj4+ICt4ZW5fc3dpb3RsYl9mcmVlX2NvaGVyZW50KHN0cnVjdCBkZXZpY2UgKmRl
diwgc2l6ZV90IHNpemUsIHZvaWQgKnZhZGRyLA0KPj4gKwkJZG1hX2FkZHJfdCBkbWFfaGFu
ZGxlLCB1bnNpZ25lZCBsb25nIGF0dHJzKQ0KPj4gew0KPj4gKwlwaHlzX2FkZHJfdCBwaHlz
ID0gdmlydF90b19waHlzKHZhZGRyKTsNCj4+IAlpbnQgb3JkZXIgPSBnZXRfb3JkZXIoc2l6
ZSk7DQo+PiAtCXBoeXNfYWRkcl90IHBoeXM7DQo+PiAtCXU2NCBkbWFfbWFzayA9IERNQV9C
SVRfTUFTSygzMik7DQo+PiAtCXN0cnVjdCBwYWdlICpwYWdlOw0KPj4gLQ0KPj4gLQlpZiAo
aHdkZXYgJiYgaHdkZXYtPmNvaGVyZW50X2RtYV9tYXNrKQ0KPj4gLQkJZG1hX21hc2sgPSBo
d2Rldi0+Y29oZXJlbnRfZG1hX21hc2s7DQo+PiAtDQo+PiAtCS8qIGRvIG5vdCB1c2Ugdmly
dF90b19waHlzIGJlY2F1c2Ugb24gQVJNIGl0IGRvZXNuJ3QgcmV0dXJuIHlvdSB0aGUNCj4+
IC0JICogcGh5c2ljYWwgYWRkcmVzcyAqLw0KPj4gLQlwaHlzID0geGVuX2RtYV90b19waHlz
KGh3ZGV2LCBkZXZfYWRkcik7DQo+Pg0KPj4gCS8qIENvbnZlcnQgdGhlIHNpemUgdG8gYWN0
dWFsbHkgYWxsb2NhdGVkLiAqLw0KPj4gCXNpemUgPSAxVUwgPDwgKG9yZGVyICsgWEVOX1BB
R0VfU0hJRlQpOw0KPj4NCj4+IC0JaWYgKGlzX3ZtYWxsb2NfYWRkcih2YWRkcikpDQo+PiAt
CQlwYWdlID0gdm1hbGxvY190b19wYWdlKHZhZGRyKTsNCj4+IC0JZWxzZQ0KPj4gLQkJcGFn
ZSA9IHZpcnRfdG9fcGFnZSh2YWRkcik7DQo+PiArCWlmIChXQVJOX09OX09OQ0UoZG1hX2hh
bmRsZSArIHNpemUgLSAxID4gZGV2LT5jb2hlcmVudF9kbWFfbWFzaykgfHwNCj4+ICsJICAg
IFdBUk5fT05fT05DRShyYW5nZV9zdHJhZGRsZXNfcGFnZV9ib3VuZGFyeShwaHlzLCBzaXpl
KSkpDQo+PiArCSAgICAJcmV0dXJuOw0KPj4NCj4+IC0JaWYgKCFXQVJOX09OKChkZXZfYWRk
ciArIHNpemUgLSAxID4gZG1hX21hc2spIHx8DQo+PiAtCQkgICAgIHJhbmdlX3N0cmFkZGxl
c19wYWdlX2JvdW5kYXJ5KHBoeXMsIHNpemUpKSAmJg0KPj4gLQkgICAgVGVzdENsZWFyUGFn
ZVhlblJlbWFwcGVkKHBhZ2UpKQ0KPj4gKwlpZiAoVGVzdENsZWFyUGFnZVhlblJlbWFwcGVk
KHZpcnRfdG9fcGFnZSh2YWRkcikpKQ0KPj4gCQl4ZW5fZGVzdHJveV9jb250aWd1b3VzX3Jl
Z2lvbihwaHlzLCBvcmRlcik7DQo+PiAtDQo+PiAtCXhlbl9mcmVlX2NvaGVyZW50X3BhZ2Vz
KGh3ZGV2LCBzaXplLCB2YWRkciwgcGh5c190b19kbWEoaHdkZXYsIHBoeXMpLA0KPj4gLQkJ
CQlhdHRycyk7DQo+PiArCWZyZWVfcGFnZXMoKHVuc2lnbmVkIGxvbmcpdmFkZHIsIGdldF9v
cmRlcihzaXplKSk7DQo+PiB9DQo+PiArI2VuZGlmIC8qIENPTkZJR19YODYgKi8NCj4+DQo+
PiAvKg0KPj4gICAqIE1hcCBhIHNpbmdsZSBidWZmZXIgb2YgdGhlIGluZGljYXRlZCBzaXpl
IGZvciBETUEgaW4gc3RyZWFtaW5nIG1vZGUuICBUaGUNCj4+IEBAIC01NDksOCArNTE4LDEz
IEBAIHhlbl9zd2lvdGxiX2RtYV9zdXBwb3J0ZWQoc3RydWN0IGRldmljZSAqaHdkZXYsIHU2
NCBtYXNrKQ0KPj4gfQ0KPj4NCj4+IGNvbnN0IHN0cnVjdCBkbWFfbWFwX29wcyB4ZW5fc3dp
b3RsYl9kbWFfb3BzID0gew0KPj4gKyNpZmRlZiBDT05GSUdfWDg2DQo+PiAJLmFsbG9jID0g
eGVuX3N3aW90bGJfYWxsb2NfY29oZXJlbnQsDQo+PiAJLmZyZWUgPSB4ZW5fc3dpb3RsYl9m
cmVlX2NvaGVyZW50LA0KPj4gKyNlbHNlDQo+PiArCS5hbGxvYyA9IGRtYV9kaXJlY3RfYWxs
b2MsDQo+PiArCS5mcmVlID0gZG1hX2RpcmVjdF9mcmVlLA0KPj4gKyNlbmRpZg0KPj4gCS5z
eW5jX3NpbmdsZV9mb3JfY3B1ID0geGVuX3N3aW90bGJfc3luY19zaW5nbGVfZm9yX2NwdSwN
Cj4+IAkuc3luY19zaW5nbGVfZm9yX2RldmljZSA9IHhlbl9zd2lvdGxiX3N5bmNfc2luZ2xl
X2Zvcl9kZXZpY2UsDQo+PiAJLnN5bmNfc2dfZm9yX2NwdSA9IHhlbl9zd2lvdGxiX3N5bmNf
c2dfZm9yX2NwdSwNCj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3hlbi9hcm0vcGFnZS1jb2hl
cmVudC5oIGIvaW5jbHVkZS94ZW4vYXJtL3BhZ2UtY29oZXJlbnQuaA0KPj4gZGVsZXRlZCBm
aWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCBiOWNjMTFlODg3ZWQ1Li4wMDAwMDAwMDAwMDAw
DQo+PiAtLS0gYS9pbmNsdWRlL3hlbi9hcm0vcGFnZS1jb2hlcmVudC5oDQo+PiArKysgL2Rl
di9udWxsDQo+PiBAQCAtMSwyMCArMCwwIEBADQo+PiAtLyogU1BEWC1MaWNlbnNlLUlkZW50
aWZpZXI6IEdQTC0yLjAgKi8NCj4+IC0jaWZuZGVmIF9YRU5fQVJNX1BBR0VfQ09IRVJFTlRf
SA0KPj4gLSNkZWZpbmUgX1hFTl9BUk1fUEFHRV9DT0hFUkVOVF9IDQo+PiAtDQo+PiAtI2lu
Y2x1ZGUgPGxpbnV4L2RtYS1tYXBwaW5nLmg+DQo+PiAtI2luY2x1ZGUgPGFzbS9wYWdlLmg+
DQo+PiAtDQo+PiAtc3RhdGljIGlubGluZSB2b2lkICp4ZW5fYWxsb2NfY29oZXJlbnRfcGFn
ZXMoc3RydWN0IGRldmljZSAqaHdkZXYsIHNpemVfdCBzaXplLA0KPj4gLQkJZG1hX2FkZHJf
dCAqZG1hX2hhbmRsZSwgZ2ZwX3QgZmxhZ3MsIHVuc2lnbmVkIGxvbmcgYXR0cnMpDQo+PiAt
ew0KPj4gLQlyZXR1cm4gZG1hX2RpcmVjdF9hbGxvYyhod2Rldiwgc2l6ZSwgZG1hX2hhbmRs
ZSwgZmxhZ3MsIGF0dHJzKTsNCj4+IC19DQo+PiAtDQo+PiAtc3RhdGljIGlubGluZSB2b2lk
IHhlbl9mcmVlX2NvaGVyZW50X3BhZ2VzKHN0cnVjdCBkZXZpY2UgKmh3ZGV2LCBzaXplX3Qg
c2l6ZSwNCj4+IC0JCXZvaWQgKmNwdV9hZGRyLCBkbWFfYWRkcl90IGRtYV9oYW5kbGUsIHVu
c2lnbmVkIGxvbmcgYXR0cnMpDQo+PiAtew0KPj4gLQlkbWFfZGlyZWN0X2ZyZWUoaHdkZXYs
IHNpemUsIGNwdV9hZGRyLCBkbWFfaGFuZGxlLCBhdHRycyk7DQo+PiAtfQ0KPj4gLQ0KPj4g
LSNlbmRpZiAvKiBfWEVOX0FSTV9QQUdFX0NPSEVSRU5UX0ggKi8NCj4gDQo+IFRoYW5rcyBm
b3Igc2hhcmluZyB0aGUgcGF0Y2ggdG8gZml4IHRoZSBpc3N1ZS4NCj4gSSB0ZXN0ZWQgYm90
aCB0aGUgcGF0Y2hlcyBhbmQgYm90aCB0aGUgcGF0Y2hlcyB3b3JrIGZpbmUuDQoNCkkgZ3Vl
c3MgeW91IGZpeGVkIFN0ZWZhbm8ncyBwYXRjaCAodGhlIGxpbmUgInZpcnRfdG9fcGFnZShy
ZXQpOyIgd2FzIG1pc3NpbmcNCmEgInBhZ2UgPSAiKS4NCg0KSSdkIGJlIGluIGZhdm9yIG9m
IENocmlzdG9waCdzIHBhdGNoLCBhc3N1bWluZyBpdCB3aWxsIHdvcmsgb24geDg2LCB0b28u
DQoNCg0KSnVlcmdlbg0K
--------------cKiYT7vpGgRmMi0Z4ql00Vsl
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------cKiYT7vpGgRmMi0Z4ql00Vsl--

--------------NkXXPDbtcnXod9351OiXTw0T--

--------------A5cKStjg7q0kKlp0COTm95Xs
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJimpEFAwAAAAAACgkQsN6d1ii/Ey/2
Twf/Y6pBKvo7x4xMgjc7Xzm4Ea7cwvli97pIlYKSeHnVNHZImn8v6ok8fNebEb1I2ncC45tyjnjX
2mO9QiwTOjyubWfqGlOa7C3Bn5uJeTe98M+ExJHPlOZpw8hi3XZLFhRJ9+zw+i7Vxc2xM1Ed9+aL
RPn/ARlbTRNHxj/CelyXeHCGaHM6L/DhLHSl6sjktuzGUxghoekn7LEWCvUFeVMtqCqhwTPdWoL3
IHKeAMj45yDp/JXjqu1InK11SVyQShvLOK665xXSFIZztG3ThxKGakUQTxZuSHpDtheCh4sOKkj0
AzunQPlezdceNCpc5ZlD3lg/N/8lheQcrhbmeBP+Zw==
=Q6/w
-----END PGP SIGNATURE-----

--------------A5cKStjg7q0kKlp0COTm95Xs--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 12:38:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 12:38:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310905.527853 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhsYL-0004Vh-5M; Fri, 22 Apr 2022 12:38:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310905.527853; Fri, 22 Apr 2022 12:38:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhsYL-0004Va-2K; Fri, 22 Apr 2022 12:38:25 +0000
Received: by outflank-mailman (input) for mailman id 310905;
 Fri, 22 Apr 2022 12:38:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhsYJ-0004VO-OA; Fri, 22 Apr 2022 12:38:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhsYJ-0001DF-MP; Fri, 22 Apr 2022 12:38:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhsYJ-0005sq-31; Fri, 22 Apr 2022 12:38:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhsYJ-0000jy-2W; Fri, 22 Apr 2022 12:38:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xc6mz5jnrlzSpxB7ej2lhkZVB7KXL2dP6hteNdGOiD8=; b=O4e39uhA2f1665O+g4WvSHFtgi
	xO6TvxWGmuvnIkk6uGfh/5lXlPF1AjcR9tlnrxSSroDVAJHzZvfOdAgCHqDOfPjQSlK4BXVdxYVC8
	5MrmnT9rBnqbBOous3AIbRDLuzhnfr7IwuFup9Jn99jqVGvwClp32drhMUIRydTrdQe0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169620-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169620: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=2306555bf9081ae9979405f96428738807e580d4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 12:38:23 +0000

flight 169620 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169620/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 2306555bf9081ae9979405f96428738807e580d4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  553 attempts
Testing same since   169610  2022-04-22 04:01:05 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5625 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 13:06:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 13:06:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310920.527887 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhszj-0000Qt-Oe; Fri, 22 Apr 2022 13:06:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310920.527887; Fri, 22 Apr 2022 13:06:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhszj-0000Qm-Lh; Fri, 22 Apr 2022 13:06:43 +0000
Received: by outflank-mailman (input) for mailman id 310920;
 Fri, 22 Apr 2022 13:06:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhszi-0000Qc-CW; Fri, 22 Apr 2022 13:06:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhszi-0001jM-AM; Fri, 22 Apr 2022 13:06:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhszh-0007Bs-Qr; Fri, 22 Apr 2022 13:06:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhszh-0002Tk-QK; Fri, 22 Apr 2022 13:06:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4Qe8LUswMs9REfoEEtbCR0bLBPVXd7VIclJt7vo7FXs=; b=6YnCdtE/IT9FEKL/vqUFPoN1Tl
	oOe05zMqAlkWqZ0viJbq38mmXD/6dSGgGG9YmIbKdn76YiyE6doV6MQVCCNlILOE89OdcPPWTK2bT
	FSmWgOTWzZFbzC9nHAbMW0/uValu46WChgZlEvEshZCWnix7p8jjCOekzV80JQFUELKM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169621-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169621: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=2306555bf9081ae9979405f96428738807e580d4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 13:06:41 +0000

flight 169621 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169621/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 2306555bf9081ae9979405f96428738807e580d4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  554 attempts
Testing same since   169610  2022-04-22 04:01:05 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5625 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 13:46:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 13:46:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310940.527903 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhtbl-0005iF-Tr; Fri, 22 Apr 2022 13:46:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310940.527903; Fri, 22 Apr 2022 13:46:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhtbl-0005i8-QV; Fri, 22 Apr 2022 13:46:01 +0000
Received: by outflank-mailman (input) for mailman id 310940;
 Fri, 22 Apr 2022 13:46:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhtbk-0005hy-Nm; Fri, 22 Apr 2022 13:46:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhtbk-0002OT-KP; Fri, 22 Apr 2022 13:46:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhtbj-0008Ov-U9; Fri, 22 Apr 2022 13:46:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhtbj-0007t1-Tk; Fri, 22 Apr 2022 13:45:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=K4UoT7rdyNi8UUGyD8K8IPEXgNAnISsiH6EtYLCFuK0=; b=g95V4ouxkL3FlhMvDphKQGF6hs
	g6bpIfq3d2kmo6z005lJJoLAETwx20AQ/DUaMywkshq6XDA23moTX4CJr+blpEuFpcE5q2YDbYzv7
	Cw5G/txKFUXu1iDUf723hVeUgIY/jN+XGNIY8fmElmQzVHaJVS9MkU5pUPwEfpySsZCY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169608-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169608: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fdef107edd4459375f9c0e6e377f30e82d498747
X-Osstest-Versions-That:
    xen=fdef107edd4459375f9c0e6e377f30e82d498747
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 13:45:59 +0000

flight 169608 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169608/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 169591 pass in 169608
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 169591 pass in 169608
 test-armhf-armhf-libvirt-qcow2  8 xen-boot                 fail pass in 169591

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 169591 like 169577
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 169591 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169591
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169591
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169591
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169591
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169591
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169591
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169591
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169591
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169591
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169591
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169591
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  fdef107edd4459375f9c0e6e377f30e82d498747
baseline version:
 xen                  fdef107edd4459375f9c0e6e377f30e82d498747

Last test of basis   169608  2022-04-22 01:52:06 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 13:52:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 13:52:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310947.527915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhthc-0007NF-JS; Fri, 22 Apr 2022 13:52:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310947.527915; Fri, 22 Apr 2022 13:52:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhthc-0007N8-G2; Fri, 22 Apr 2022 13:52:04 +0000
Received: by outflank-mailman (input) for mailman id 310947;
 Fri, 22 Apr 2022 13:52:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhthb-0007My-9Q; Fri, 22 Apr 2022 13:52:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhthb-0002Uf-6c; Fri, 22 Apr 2022 13:52:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhtha-000080-SN; Fri, 22 Apr 2022 13:52:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhtha-0001KL-Rs; Fri, 22 Apr 2022 13:52:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=90pPT4V7zlBnendgu6iooxpHZzAYrz9YTJ9gXQ7zei0=; b=Owuuzrc9E59DhimHKV6cc/2Knq
	5Skce3vNvWx0+ffkkGDPemlVu5hGvpDnCT1PnnTA1lDQ1MC5Ys0l+/mKsWj680LeSXsA5WH/gwLqX
	vMr5QA87fn7qEY6z9aw2KdS0eYYh0mSZHr7NMyimo/qLNhDbRXC5BwfMJAmcIIBgiWpA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169623-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169623: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=2306555bf9081ae9979405f96428738807e580d4
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 13:52:02 +0000

flight 169623 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169623/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 2306555bf9081ae9979405f96428738807e580d4
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  555 attempts
Testing same since   169610  2022-04-22 04:01:05 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5625 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 14:07:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 14:07:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310956.527926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhtwN-0000rr-3i; Fri, 22 Apr 2022 14:07:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310956.527926; Fri, 22 Apr 2022 14:07:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhtwN-0000rk-0p; Fri, 22 Apr 2022 14:07:19 +0000
Received: by outflank-mailman (input) for mailman id 310956;
 Fri, 22 Apr 2022 14:07:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=utlT=VA=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nhtwM-0000re-DL
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:07:18 +0000
Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com
 [2607:f8b0:4864:20::72c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 83553c6b-c245-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 16:07:16 +0200 (CEST)
Received: by mail-qk1-x72c.google.com with SMTP id d19so5860620qko.3
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 07:07:16 -0700 (PDT)
Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:db3c:923d:3601:7358])
 by smtp.gmail.com with ESMTPSA id
 j12-20020a05622a038c00b002f340aeffb3sm1293345qtx.85.2022.04.22.07.07.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Apr 2022 07:07:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83553c6b-c245-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=7ukyyy4K3zXbgBey+POVSCJzrrGx3irsNB33+kkDTdA=;
        b=D/dYZOEBKA8stz7w5ooNER6KE8Uy3BDwU7ov81twcLiHdmQAuzPnEJubwKDaeUcoOD
         wxhS23UefG/7cq81ZH2BP/aDvGq8dNH7QyOsIq2XCEyCm8ntKpwlJkKIZKq23RQ1Muop
         W5uXT5yVXVbfm1/n+eN+BGCiaNvHlrxN3xXmHDuPAJEyLuFzH1c973eP/uMfTSF5x23x
         jRetuaN5MEf4AYSGM6NmNu1geoFUmPVM0SkaACwJiQ1sln1l/JeqQkVNW2Dlu+SWCo+f
         sXKlgqEhkHhTHtn99U+My3JS3Ta7Fv/pNz0hQ9oIWwt5AXDnrGlxlRU1CpnHfPkwNlOf
         vRhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=7ukyyy4K3zXbgBey+POVSCJzrrGx3irsNB33+kkDTdA=;
        b=G+ittizks+PJ4eoqPB92Ypbp+oDBMfeTDz0J4j6GTz7H6cooN5AYQNwgcPjmG/ogBe
         i0k+DjZnVQQI4iyYQ5lk141YtEmbV23RICULlQSLNh2k8tmAhbAcdpT6kma47X26QHIX
         DeY0GyBfU7LMrHDAjPrggvw40Mzp8zT7yyS6UHX/BydRFAnVUfz+T7rPEdLzZi5/1MS2
         xAjFQpmuqKgYsCXwG5kj1hEjoyDpI0dCx7S3fDq/wyBkm9ag4zDmNfrUMP1QVcuThzox
         1oY19aaGKpiTI69Yz9n+o6WObxtIBXX8zxQp+zG3UDR/mz4GI2VC/hgs9Zw96AzBPVB2
         PHLQ==
X-Gm-Message-State: AOAM531d0JkRW7IuTYA5H0SgcgR9N4YgK9C+k+Ax2tUtGt8tgY3qVVMP
	t/3fQ8QzPIFPeM/bLNE9mcjc8L26xBY=
X-Google-Smtp-Source: ABdhPJyAYGJEW3WRcKwO0aiCwfg7lr3Gej4S/+o6tOvzGIZNdYMwFXOAgLCIJZs7mvwLaXVJY3eB7w==
X-Received: by 2002:a05:620a:4486:b0:69f:1e21:5393 with SMTP id x6-20020a05620a448600b0069f1e215393mr1232835qkp.504.1650636434090;
        Fri, 22 Apr 2022 07:07:14 -0700 (PDT)
From: Jason Andryuk <jandryuk@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Jason Andryuk <jandryuk@gmail.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2] libxl: Retry QMP PCI device_add
Date: Fri, 22 Apr 2022 10:07:03 -0400
Message-Id: <20220422140703.13614-1-jandryuk@gmail.com>
X-Mailer: git-send-email 2.35.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

PCI device assignment to an HVM with stubdom is potentially racy.  First
the PCI device is assigned to the stubdom via the PV PCI protocol.  Then
QEMU is sent a QMP command to attach the PCI device to QEMU running
within the stubdom.  However, the sysfs entries within the stubdom may
not have appeared by the time QEMU receives the device_add command
resulting in errors like:

libxl_qmp.c:1838:qmp_ev_parse_error_messages:Domain 10:Could not open '/sys/bus/pci/devices/0000:00:1f.3/config': No such file or directory

This patch retries the device assignment up to 10 times with a 1 second
delay between.  That roughly matches the overall hotplug timeout for
pci_add_timeout.  pci_add_timeout's initialization is moved to
do_pci_add since retries call into pci_add_qmp_device_add again.

The qmp_ev_parse_error_messages error is still printed since it happens
at a lower level than the pci code controlling the retries.  With that,
the "Retrying PCI add %d" message is also printed at ERROR level to
clarify what is happening.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
v2:
Only retry when a stubdom is present.
Move pci_add_timeout initialization.
Use pas->aodev->ao directly.
---
 tools/libs/light/libxl_pci.c | 44 +++++++++++++++++++++++++++++++-----
 1 file changed, 38 insertions(+), 6 deletions(-)

diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
index 4bbbfe9f16..96f88795b6 100644
--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -1109,8 +1109,10 @@ typedef struct pci_add_state {
     libxl__xswait_state xswait;
     libxl__ev_qmp qmp;
     libxl__ev_time timeout;
+    libxl__ev_time timeout_retries;
     libxl_device_pci pci;
     libxl_domid pci_domid;
+    int retries;
 } pci_add_state;
 
 static void pci_add_qemu_trad_watch_state_cb(libxl__egc *egc,
@@ -1118,6 +1120,8 @@ static void pci_add_qemu_trad_watch_state_cb(libxl__egc *egc,
 static void pci_add_qmp_device_add(libxl__egc *, pci_add_state *);
 static void pci_add_qmp_device_add_cb(libxl__egc *,
     libxl__ev_qmp *, const libxl__json_object *, int rc);
+static void pci_add_qmp_device_add_retry(libxl__egc *egc, libxl__ev_time *ev,
+    const struct timeval *requested_abs, int rc);
 static void pci_add_qmp_query_pci_cb(libxl__egc *,
     libxl__ev_qmp *, const libxl__json_object *, int rc);
 static void pci_add_timeout(libxl__egc *egc, libxl__ev_time *ev,
@@ -1137,7 +1141,9 @@ static void do_pci_add(libxl__egc *egc,
     libxl__xswait_init(&pas->xswait);
     libxl__ev_qmp_init(&pas->qmp);
     pas->pci_domid = domid;
+    pas->retries = 0;
     libxl__ev_time_init(&pas->timeout);
+    libxl__ev_time_init(&pas->timeout_retries);
 
     if (type == LIBXL_DOMAIN_TYPE_INVALID) {
         rc = ERROR_FAIL;
@@ -1157,6 +1163,11 @@ static void do_pci_add(libxl__egc *egc,
                 if (rc) goto out;
                 return;
             case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
+                rc = libxl__ev_time_register_rel(ao, &pas->timeout,
+                                                 pci_add_timeout,
+                                                 LIBXL_QMP_CMD_TIMEOUT * 1000);
+                if (rc) goto out;
+
                 pci_add_qmp_device_add(egc, pas); /* must be last */
                 return;
             default:
@@ -1205,11 +1216,6 @@ static void pci_add_qmp_device_add(libxl__egc *egc, pci_add_state *pas)
     libxl_device_pci *pci = &pas->pci;
     libxl__ev_qmp *const qmp = &pas->qmp;
 
-    rc = libxl__ev_time_register_rel(ao, &pas->timeout,
-                                     pci_add_timeout,
-                                     LIBXL_QMP_CMD_TIMEOUT * 1000);
-    if (rc) goto out;
-
     libxl__qmp_param_add_string(gc, &args, "driver",
                                 "xen-pci-passthrough");
     QMP_PARAMETERS_SPRINTF(&args, "id", PCI_PT_QDEV_ID,
@@ -1255,7 +1261,23 @@ static void pci_add_qmp_device_add_cb(libxl__egc *egc,
     EGC_GC;
     pci_add_state *pas = CONTAINER_OF(qmp, *pas, qmp);
 
-    if (rc) goto out;
+    if (rc) {
+        /* Retry only applicable for HVM with stubdom. */
+        if (libxl_get_stubdom_id(CTX, qmp->domid) == 0)
+            goto out;
+
+        if (pas->retries++ < 10) {
+            LOGD(ERROR, qmp->domid, "Retrying PCI add %d", pas->retries);
+            rc = libxl__ev_time_register_rel(pas->aodev->ao,
+                                             &pas->timeout_retries,
+                                             pci_add_qmp_device_add_retry,
+                                             1000);
+            if (rc) goto out;
+            return; /* Wait for the timeout to then retry. */
+        } else {
+            goto out;
+        }
+    }
 
     qmp->callback = pci_add_qmp_query_pci_cb;
     rc = libxl__ev_qmp_send(egc, qmp, "query-pci", NULL);
@@ -1266,6 +1288,15 @@ out:
     pci_add_dm_done(egc, pas, rc); /* must be last */
 }
 
+static void pci_add_qmp_device_add_retry(libxl__egc *egc, libxl__ev_time *ev,
+                                         const struct timeval *requested_abs,
+                                         int rc)
+{
+    pci_add_state *pas = CONTAINER_OF(ev, *pas, timeout_retries);
+
+    pci_add_qmp_device_add(egc, pas);
+}
+
 static void pci_add_qmp_query_pci_cb(libxl__egc *egc,
                                      libxl__ev_qmp *qmp,
                                      const libxl__json_object *response,
@@ -1507,6 +1538,7 @@ out_no_irq:
         rc = 0;
 out:
     libxl__ev_time_deregister(gc, &pas->timeout);
+    libxl__ev_time_deregister(gc, &pas->timeout_retries);
     pas->callback(egc, pas, rc);
 }
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 14:08:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 14:08:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310960.527936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhtxg-0001Oy-Dv; Fri, 22 Apr 2022 14:08:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310960.527936; Fri, 22 Apr 2022 14:08:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhtxg-0001Or-B8; Fri, 22 Apr 2022 14:08:40 +0000
Received: by outflank-mailman (input) for mailman id 310960;
 Fri, 22 Apr 2022 14:08:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOna=VA=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nhtxf-0001Of-3n
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:08:39 +0000
Received: from MTA-11-3.privateemail.com (mta-11-3.privateemail.com
 [198.54.122.105]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3959133-c245-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 16:08:37 +0200 (CEST)
Received: from mta-11.privateemail.com (localhost [127.0.0.1])
 by mta-11.privateemail.com (Postfix) with ESMTP id B448C18000A8
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 10:08:35 -0400 (EDT)
Received: from mail-oa1-f42.google.com (unknown [10.20.151.172])
 by mta-11.privateemail.com (Postfix) with ESMTPA id 8ECD818000A4
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 10:08:35 -0400 (EDT)
Received: by mail-oa1-f42.google.com with SMTP id
 586e51a60fabf-e9027efe6aso1415334fac.10
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 07:08:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3959133-c245-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650636515;
	bh=OMA+z+3k2e//Y/lXEpdmlZ0wVc06E/JWCiNcnB0aSR8=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=SFC5Vsi22zjX89hNoIXR0SwKcjZ40x8bsJ0sl0XS3sNyXBLQ31fC+N39CPx5LUtDZ
	 NJgaAH+BaymH/AcwkXClefYvAeIZpjuRJwU/DUNrbY7ScaQP6KCKMIxOI4nfJd21ZR
	 O9WwrR5LHegIpCMIKcIptl94i8JBWTEU2IK80+t8BRyb1QvYyBT3tNhGx/RYYs08Wd
	 No9dbl8gLGlomqAgsUyvMTY0PwwSog6NzAgOJGfduMZfg3YXUjBfbv3ImdodKrEBnC
	 pUJAlE/m+BqAOFHZNl8sxUD7uA/447+nx243B1KTUBu80HR0n5jqt62Pq80v7awhnc
	 NgcVCjwJfuYUA==
X-Gm-Message-State: AOAM5314Z4SFTzDoryb1n6vcdwEvSUKFgQ83wK4XEeFJHn+c8k6WJLp9
	+dgmV67ASXHXcpUZlohI71EjbUfsbuXRLpCQMhA=
X-Google-Smtp-Source: ABdhPJwllCKWXdw6Nf+F2hLnA7TAU87HBeVHYEZ4AD5VtaaIfT5MA3s6SMQmj0NMNLAJx1dRBhLDo9xgNRnNBBDCUeg=
X-Received: by 2002:a05:6870:ea8d:b0:e6:135c:1a2e with SMTP id
 s13-20020a056870ea8d00b000e6135c1a2emr6054557oap.9.1650636514944; Fri, 22 Apr
 2022 07:08:34 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
In-Reply-To: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Fri, 22 Apr 2022 10:07:58 -0400
X-Gmail-Original-Message-ID: <CABfawhki8YVxycv_zdDqDuOYvBdobdskXnjjdjiF7UND3784cg@mail.gmail.com>
Message-ID: <CABfawhki8YVxycv_zdDqDuOYvBdobdskXnjjdjiF7UND3784cg@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Alexandru Isaila <aisaila@bitdefender.com>, Petre Pircalabu <ppircalabu@bitdefender.com>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel <tamas.lengyel@intel.com> wrote:
>
> Allow specify distinct parts of the fork VM to be reset. This is useful when a
> fuzzing operation involves mapping in only a handful of pages that are known
> ahead of time. Throwing these pages away just to be re-copied immediately is
> expensive, thus allowing to specify partial resets can speed things up.
>
> Also allow resetting to be initiated from vm_event responses as an
> optimization.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>

Patch ping. Could I get a Reviewed-by if there are no objections?

Thanks,
Tamas


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 14:09:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 14:09:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.310965.527948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhtyQ-0001yR-NI; Fri, 22 Apr 2022 14:09:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 310965.527948; Fri, 22 Apr 2022 14:09:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhtyQ-0001yK-KS; Fri, 22 Apr 2022 14:09:26 +0000
Received: by outflank-mailman (input) for mailman id 310965;
 Fri, 22 Apr 2022 14:09:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOna=VA=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nhtyP-0001y5-SU
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:09:25 +0000
Received: from MTA-07-4.privateemail.com (mta-07-4.privateemail.com
 [68.65.122.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cf8aac34-c245-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 16:09:24 +0200 (CEST)
Received: from mta-07.privateemail.com (localhost [127.0.0.1])
 by mta-07.privateemail.com (Postfix) with ESMTP id DAF8C18000AF
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 10:09:22 -0400 (EDT)
Received: from mail-ot1-f43.google.com (unknown [10.20.151.169])
 by mta-07.privateemail.com (Postfix) with ESMTPA id C041A18000B0
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 10:09:22 -0400 (EDT)
Received: by mail-ot1-f43.google.com with SMTP id
 w27-20020a056830061b00b00604cde931a0so5557586oti.2
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 07:09:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf8aac34-c245-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650636562;
	bh=2eXVCjwgHglJAz5KN98RN6CFN4kBTy/rUtR5rB7L1Vw=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=Lpn++jEkxaZ4SyiZFVIJH825XZWNEdCBRrxnWLj2JY9oXqWqR352vTySEGeylHVHI
	 iHQ13L/HbMwkLdUZPVdZnxJlBdsTQNBDZpHboBuoYbRCGBoJxSpn6KcK0CEeIGDqI7
	 npli0fm1lP96myX8GtJx4VZvdNjB+JQuzwAEacDvlcQ/Ji2r7oE1W94BofEeG5RPwA
	 /a+6ZSfSYKRFpQRdmNtfUnMLqZwrfyKSKB9pQaq2JARy0bM8f5245yQ173wgBU7xQS
	 46VgaaMlfPqITBBAjVPKflzwjBXCd1g3N629Sh5jPavvnQGL1YmmFjoTKy/Aqxkkxj
	 +OQ5No6lUZH8g==
X-Gm-Message-State: AOAM531+dBaNDiBZwnqJ1WTn8Gd+b7tLHbyjre8oyquELOG1TFo23RIO
	CAP0oXrrM+oftliQHDqA0U5glUGi13BzIRnJyAU=
X-Google-Smtp-Source: ABdhPJzqIc/S0MYgJUnayLLT9ALrEp7pr3wFMABs5TcYLfcZuukrsBq6mXmVL8EzauubZoin78BlJfYOWp7DHJU5VhQ=
X-Received: by 2002:a05:6830:2b29:b0:605:7cdb:f10b with SMTP id
 l41-20020a0568302b2900b006057cdbf10bmr1763872otv.157.1650636562086; Fri, 22
 Apr 2022 07:09:22 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
In-Reply-To: <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Fri, 22 Apr 2022 10:08:45 -0400
X-Gmail-Original-Message-ID: <CABfawhmYsXFofoe9QSrM_FrBcQ7d5VY9XYQQ5mwEvYW1w8Fg3A@mail.gmail.com>
Message-ID: <CABfawhmYsXFofoe9QSrM_FrBcQ7d5VY9XYQQ5mwEvYW1w8Fg3A@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] x86/monitor: Add new monitor event to catch all vmexits
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Alexandru Isaila <aisaila@bitdefender.com>, 
	Petre Pircalabu <ppircalabu@bitdefender.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel <tamas.lengyel@intel.com> wrote:
>
> Add monitor event that hooks the vmexit handler allowing for both sync and
> async monitoring of events. With async monitoring an event is placed on the
> monitor ring for each exit and the rest of the vmexit handler resumes normally.
> If there are additional monitor events configured those will also place their
> respective events on the monitor ring.
>
> With the sync version an event is placed on the monitor ring but the handler
> does not get resumed, thus the sync version is only useful when the VM is not
> expected to resume normally after the vmexit. Our use-case is primarily with
> the sync version with VM forks where the fork gets reset after sync vmexit
> event, thus the rest of the vmexit handler can be safely skipped. This is
> very useful when we want to avoid Xen crashing the VM under any circumstance,
> for example during fuzzing. Collecting all vmexit information regardless of
> the root cause makes it easier to reason about the state of the VM on the
> monitor side, hence we opt to receive all events, even for external interrupt
> and NMI exits and let the monitor agent decide how to proceed.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> ---
> v4: Minor tweaks and more verbose patch description.
>
> Note: making the sync version resume-friendly is specifically out-of-scope as
> it would require significant rearrangement of the vmexit handler. As this
> feature is not required for our use-case we opt for the version that minimizes
> impact on the existing code.

Patch ping.


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 14:44:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 14:44:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311015.527979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhuWQ-0007Ts-Ow; Fri, 22 Apr 2022 14:44:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311015.527979; Fri, 22 Apr 2022 14:44:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhuWQ-0007Tl-Lp; Fri, 22 Apr 2022 14:44:34 +0000
Received: by outflank-mailman (input) for mailman id 311015;
 Fri, 22 Apr 2022 14:44:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhuWP-0007Tf-GY
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:44:33 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b719eb53-c24a-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 16:44:31 +0200 (CEST)
Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 10:44:28 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN8PR03MB5075.namprd03.prod.outlook.com (2603:10b6:408:df::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr
 2022 14:44:27 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 14:44:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b719eb53-c24a-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650638671;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Hn3/Va1zcskwbc3cwCcV3YNR4+I3wl/S8U3iOrqEKyM=;
  b=XcosSuEd1jcA4fCJR0VE9tKQq3jp+0riI3d3d+nw65NjZrK7TuI5gvx1
   yHgajSTsKifoyh5Ink2OridoiVCuIkSPWvg28uVSaleEQdWl76R5+qQO4
   262Wud89r54jMS5hyNW27swq+HHxmxJPFn69m4CB3UK0IpPwXiSLRp6AY
   U=;
X-IronPort-RemoteIP: 104.47.59.171
X-IronPort-MID: 69728125
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:AB4brqCLB7E0+xVW/1jiw5YqxClBgxIJ4kV8jS/XYbTApDl31GMGm
 2AbW2yEbKmDYzD0Ld0nbNzl80wD65TTnYBhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj2NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgh0
 vJD7KyIYD45YK7NqPUPVjxpDn9XaPguFL/veRBTsOS15mifKT7A5qsrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t3B8mcGs0m5vcBtNs0rulIEezTe
 Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLWwH8gLM//dfD2771y5y8LzmYNTve82la8N3wF6pq
 zjX8DGsav0dHJnFodafyVquifXIhjjTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySDUd3VTxC+5nmesXYht8F4FuQ77ESBz/TS6gPAXGwcFGceMZohqdM8QiEs2
 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnF76PzIbdYgXJJAzN
IronPort-HdrOrdr: A9a23:Mshsyq3izjU9xCGPPZ7uTQqjBetxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+
 UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf
 grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e
 iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ
 PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/
 6uJZM+OY6XEVfT
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="69728125"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f5wP6U4xMvNH5vbaPBSXbhwIFDDYmM7dGAH9TSd3PpLwvEaUmEf8dcAzAPB+UTTX4f16Q6Pk81mvhNcxNZhLjtai0RRCABYJh5UtivmuXKtGS1/W2Bbwqr8ENjBv4mY3Go4pgkyTDyqY1vVJE2GT/oZVMkzMHLR0B1dxrZHsAnU7KMWAkxxZ07pLWdSM6W+ghxF0ohxW2QNvbnTMYBuSGl2ThEKveKuysvB3+4lVf1DJiT71wMn4iwDsdTdTS6BM9X5cv9zl1H58eD7Q57lITXa+z/1u+0uvpdSPxjZ5sHMTt3FsbpEJbb8jM4hcav3S9RFpOLS8F/JfCOMHx0IxXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Hn3/Va1zcskwbc3cwCcV3YNR4+I3wl/S8U3iOrqEKyM=;
 b=hnJehBbnXiRcTWh3BCvSkKDB106FqRRvqLCjX7xpvAv3YaaQhJL9ovpApZEFDW+x3S0kzmfKxzcMneksoBVOi6wxnNzmGknUVgUP5KT/jzY5GT/XVDk4wvgYut65ZDzUU+EfA3hFbng2+5+Hpzvw4W0HNJH/W5xAObokGHldS65zqyu+Jgge4/x1nmf11c5mU15JThy8majEaHWW3CX/xVGvFDErRPwgXsrtt1TK/9UwL/KYYY0KQCuorXs0SL8bXS8yP/traj9ftTiDyrHyKGjAJ15Bqx/oLwAv6/8VGZmIy81BbulMqr8uAfWAYCScNp9Jr8jf0t+7eKFsra8IrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Hn3/Va1zcskwbc3cwCcV3YNR4+I3wl/S8U3iOrqEKyM=;
 b=cXyGzzZY4zQxR8JpQWPjPnpKR63m6xvGaBxaD6C39Jm/n9FArXiYdcMuzbHiBJtcha4qiMeZ2D93J53p9dhIKimwe1RBBxEMNppG9BKN4aMkD2lQGvASCj22C508VSzInIn7xR0f9o7MH0ABArlCcGAxpaLkTu+GMQ997dIPa6Y=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH 1/4] tools/libs/evtchn: don't set errno to negative values
Thread-Topic: [PATCH 1/4] tools/libs/evtchn: don't set errno to negative
 values
Thread-Index: AQHYVIinhoRyh3e5qEasPCJgKMVAJKz8BdsA
Date: Fri, 22 Apr 2022 14:44:26 +0000
Message-ID: <f9c85569-e068-339c-1ca2-db72cba139ce@citrix.com>
References: <20220420073119.16974-1-jgross@suse.com>
 <20220420073119.16974-2-jgross@suse.com>
In-Reply-To: <20220420073119.16974-2-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a116c7d1-c7a0-4fcc-fb31-08da246e99a9
x-ms-traffictypediagnostic: BN8PR03MB5075:EE_
x-microsoft-antispam-prvs:
 <BN8PR03MB50751A0D8A67089CD66ECABDBAF79@BN8PR03MB5075.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 CCBpX+NKXIwMTPDcqTmmKzDfC3VY5PAIVTvC4SM3t0vmXvSs6dclr0CeaFMWNSjUHycvOHyf1aQ/+qc8KLFkqgPapuc9qHJ9LLt5Dz1c1YRH2fCmY3nGOK9poeRsYVnc7FPcTHeNJbDLtaNV1JWQ9GhFQXiqO540bHEK1dJIsb+LfNSzmUrLR92J9QaMAllqvC6r+hf4cIXc8Dc9xrSaHLn0RZbHTw8WX+A1A6y/bL1f8gSDRUK3Uo121D/COVpblkI1KAjBhv2lkXWyWB35kGdayC5t3swptjeZiPmgf3PpvtUqd9uddOYGsJGJTQp2jZxyIk9xBpWmCafSVrZ16hX1NxZkoi5o3/Nuhm9p5m2slEouUsiRw0g5A3pgUtNpnhs6IM9LH6cFSaV5Y2/G8JzK1v0ceOn1cii98HVsmNYBBWVkIe6L8n7Jizr57a2CvAGRlvDHRlLbLee28827j5R1uQl6/B+yN8RcnRu+Giz7AeHRPGk3Jk0LwHgkUbWVtM/C36e07dFfl6PQ2Dz6ej2V4G4NDCsdgkhwnaz4pyo0dZtq76ymzA3RwI8Kna5GKGPgQBOtoWABaVDlB+r9b8EyWTyOfDmPQXAG9OjHpJDwea6yZUGIzwxvOH5NEUWiePTYvD+JTsZ23Jw4b4fiAVS5Kbu6WJnlo/n0LDxKJjJtS4GFPOu84B2NYNXQSalb1ueoKSAhXeAtDO3MqqIJ5EqrznLcWYvRVncHKWNuSVKgxRQPlAIP2OnVJAJUUXcEJAgVIVPb4RMRtWtje9aYRQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(26005)(66476007)(8676002)(6512007)(6506007)(54906003)(508600001)(38070700005)(91956017)(36756003)(38100700002)(86362001)(82960400001)(66946007)(53546011)(316002)(2906002)(76116006)(4326008)(6486002)(31686004)(66446008)(5660300002)(31696002)(64756008)(122000001)(8936002)(107886003)(66556008)(71200400001)(558084003)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Q3k4ZUJIWk1LdXI5eENneFRTOG1xeEk1clJ4enpibDdVVi9Ydm51ZFRXT2c4?=
 =?utf-8?B?eFlnU2NiMmRkL0h5Umswbm5WS1NMRFFISDdHQUFFSGFUVkthcHA4UGZMSUUy?=
 =?utf-8?B?aWZSWlpRaHhzZitYNlR4ZGJ6b0hoNTM4S2V2Z2RubmpZaDBzaW5HanQzdjF4?=
 =?utf-8?B?WjdHNnlxcEtxZTJ1bWJSYXdXNUl0OW5vRHlrRmxsMHIwWm9LWm04UTNSTFht?=
 =?utf-8?B?WWhMazNXTTlGSTRMdi9pc1gwdmpjWEtOMGJ4anBPd1ZvZnJNMGVSeTdoUk9N?=
 =?utf-8?B?WnY0Nk4zZTg5WTVYdUlxaW1OeUNrUzV1RlhvZ3FBQ2g4VjFwU2tLa3hYVUxQ?=
 =?utf-8?B?MlFORHZka0hkTHp4bWc2YnJVWi9Vc2dKQ0FTNWdobUMrdE05Qlc5ZHlSQ3Bm?=
 =?utf-8?B?dWpUd1F1K2gwMFlSVnlnWkNDZXhCY2NONFRCWGVkSjZvT1lQVTkyNmFNdmNj?=
 =?utf-8?B?UVlZRW5uUHJQUk5MTDVHd25sVWtLSnVtM3NqQXcyVGprbVI5S0hTaHE4WTAx?=
 =?utf-8?B?dXNyamFpeHRXbVAzenhVU01RblpNQ1JqQ2NGOXArOFpucmQ1NFZkV3VFVGZW?=
 =?utf-8?B?dk1QQVNLN3lUSkNNckFSMkMxMEJNR0daZXd4RitrSTY5WllnRzlmMEZhbGNt?=
 =?utf-8?B?aWV1MVZQTVhMY2h5a1FtL2FJTzZjK3ZjbnNiQ09vdDFvVWJkOFhsRVhFU2FQ?=
 =?utf-8?B?WHBJbU9OWFh2MlZ0NWJ0OE5KT0Q0WEhCOTRaNTMwWTRGMDdyRFFUaW8rblZk?=
 =?utf-8?B?MlAyOFV1TVJxNjd5ang3d1pGb08yRy8rY3JBZjZhNzJhTEhQaWVjeWthZURX?=
 =?utf-8?B?czNCSzIrd25zM0h2WFpvK2lwSk1QYm9Lc08yVmIraTdabDhnOGJQQkxzenc2?=
 =?utf-8?B?ZXFqaUl4TlYyNjdjczluUlRkVkdlT0d4ZytuS1pvY00xelExeEs1L0FTakNS?=
 =?utf-8?B?TEJRemRuQ1FDS0E5MGtiWW1qTWZoaXJpVnphelF1ZWpZTXZ4SjRPdSsvV3NY?=
 =?utf-8?B?eHY1TFRsYkl1NkVuWHpvajRJNEYvYWl5dEl2dXlLYm9tNGEzNmlESUEwbHZR?=
 =?utf-8?B?RFdPQ0xXL3Q1cTZMZUNJYmhQakZkMTlwVTZFc0ZLcVRydHJVS1VRd2JNalIx?=
 =?utf-8?B?ejVETDY5clEzczFSQmgvb0gvY20wcmVlN2JnUEk2K1hXSzlYZ054Z2pROU9h?=
 =?utf-8?B?VmF2elFlK3V6a3lmaFcreitnWXRLVmVYM0lVUWdHQTVQaGUyQm4ySlZxQ2JL?=
 =?utf-8?B?L3RRTFFIcE1sK1BRTmVRL3dSZkhCaXN4NVFYNnhoOFJjK1hFVXM1NEFEckR3?=
 =?utf-8?B?aVdEOEQ1WHlzOWNYRW9aWDNIMDF3a2VrSVZkM1lZZ3piMW1sT3ZNTWl4aHZH?=
 =?utf-8?B?QzVYVWhwZEkxWVNzbi8wRjR1b3pkcUR3RlJiVGZHQS81TlN0ZDVnN1JnQkNH?=
 =?utf-8?B?TUpWMkx0UmNzU3ROUjJRVzNBSEYvMWtLMjBKaHJkYWVNRUE0NE5nT0Q4RFR6?=
 =?utf-8?B?MnFIMjBIbTBrK0RuRFF1cVZZWW9pMFBxL1dUNkVBSDJ1dlJZZElwZ0hoWDJw?=
 =?utf-8?B?QURPWFU4eFJtNkxMTUJ2UE9jaDMxTm9yQ09tcFVzVXpZY250WHNHNTBaQXRr?=
 =?utf-8?B?cHRDekN1N0NPQllhVGxIYm9uYzFsMjVkZDZnMGlsdG51dWN3c3ozdC81ZGxO?=
 =?utf-8?B?SGhzYUs3RGFCdGs2enpoYlF2ekJ2d1RSQmZyUlVjVTAzbVh3YzJLWGpnQ0NC?=
 =?utf-8?B?S2NtcCtya0MydGNmTnlYMUxYeWJaaVhCYitWMmJLclJzWmVNdWJQQU43U0hp?=
 =?utf-8?B?dnpzNUxjZmQyd2o4STNlRm16YU5hcFoydHFYL04zSG1hUHQ4TlVrdmw0dmFv?=
 =?utf-8?B?MkUxOGh3a2NpWmVtQnlFR3lPdnhjd0lEN3VMdWxxMXh1UmFwaElFZzFuTEJS?=
 =?utf-8?B?UHdXY1dncitLZXUxeVNDUmFHbGZyNkVOTEtKR0d5NHdycWkrV1BXaTV3Qy82?=
 =?utf-8?B?SGs3MlFDV0NBRzJuNVlFLytLdmEweEUwU3BzK2V5M0poaER2eUtiK0xQZ1c5?=
 =?utf-8?B?WUpjdmYvVUUwK1pSR3FzaXdOVkJlTlVrdTEyclhuT3Q3R1g2TkxQUU5PSlZV?=
 =?utf-8?B?OVgvazMrR1JzamlnakpIcVY1YkVjSGNXbENmeHJKYzVMRkxSVnh4eTYyWDZX?=
 =?utf-8?B?N0gxN2NQRzdlVU5UdXc4OXRhb0xRUG1DM1owdzBMM0FoN1AwTkxTNDNpYmdI?=
 =?utf-8?B?d2t0NjAwc1h0akNkVUVRRlVHd0JaZjlSL2ZZL0FrUTNhekNqSlo1VVVFY3BQ?=
 =?utf-8?B?RFVGbDJ1WDBVVmg3ckxuWHV0OXYwVCtTVDJaRTQ5ejFpZ09sWUpxQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <86D8F6071ECA9A4892F599EDECF4410A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a116c7d1-c7a0-4fcc-fb31-08da246e99a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 14:44:26.9246
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3LmuiuNHvAI33eepH+2FO+qxt+E1YimkHFN/3zw6Zi5HTPr2bsl8by9uR7S8rbtli8ptRiTCDPBjEx5nAsD4awbE4OWnsPn5JrSibSbVfU8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5075

T24gMjAvMDQvMjAyMiAwODozMSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gU2V0dGluZyBlcnJu
byB0byBhIG5lZ2F0aXZlIHZhbHVlIG1ha2VzIG5vIHNlbnNlLg0KDQpGaXhlczogNmI2NTAwYjNj
YmFhDQoNCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0K
DQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 14:47:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 14:47:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311021.527990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhuZ7-00089h-9A; Fri, 22 Apr 2022 14:47:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311021.527990; Fri, 22 Apr 2022 14:47:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhuZ7-00089a-60; Fri, 22 Apr 2022 14:47:21 +0000
Received: by outflank-mailman (input) for mailman id 311021;
 Fri, 22 Apr 2022 14:47:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhuZ6-00089S-5V
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:47:20 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b1c0e3e-c24b-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 16:47:18 +0200 (CEST)
Received: from mail-mw2nam10lp2106.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.106])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 10:47:16 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM5PR03MB2826.namprd03.prod.outlook.com (2603:10b6:3:121::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 14:47:15 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 14:47:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b1c0e3e-c24b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650638839;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=CjqDlz04ZHJ1O1uKdizqU1iQf7raZFrx37RV2ckVO50=;
  b=d7jgg4kazFyAzQ8jw6IqAmqRi3+bVyfJDyKJNTD7MWIzhmpyk2PocLBp
   iOuXn2q3hO0HkYtIIJJKrdNzdxRUHE2IY7DJXbGQfQVxWMIAUTHs8tI1M
   dCN1g09oZ7lMjbst479Oa+/Y616b6Cv2WQy4t58vWQKKbH0vYLgv1+DZj
   0=;
X-IronPort-RemoteIP: 104.47.55.106
X-IronPort-MID: 69109873
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:T3rmfaPjT7/7Nc/vrR3UlsFynXyQoLVcMsEvi/4bfWQNrUom3jBSz
 jcZXDyDP/aDNDP9KdlzPYW29R8H65fWn9cyGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NQw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 84TkoaIZAwTB7DMleAsUThcUH4gIvgTkFPHCSDXXc276WTjKiOp5so0SUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaG/uiCdxwhV/cguhnG/rEa
 tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2MJ8QrE9fVsi4TV5B147pf1CN/NRsKHfOx83U3Ep
 TKFxXusV3n2M/Tak1Jp6EmEhODVmjjgcJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDZsb5dw21pjiDpBF0ZjZLO+gz6QXIz7WO5Q+cXzAAVmQYMIJgs9IqTzs30
 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZo8L/HKd5jEtJQzN/
 g==
IronPort-HdrOrdr: A9a23:V2hNXKtR8blN67OlWOb+cFNU7skCL4Aji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPuftXrdyRGVxeZZnMTfKlzbamDDH4tmuZ
 uIHJIOb+EYYWIasS++2njBLz9C+qjIzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf
 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIO/Z4StU
 z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfqWG0hYczBgNkGmpDq1L8Yqq
 iKn/7mBbU015rlRBDxnfIq4Xi47N9h0Q679bbSuwqfnSWwfkNHNyMGv/MZTvKR0TtfgDk3up
 g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIIO5gLZvin+9Kq1wVR4SKbpXYt
 VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFojvA3jzMF7tYwWpNE7+
 PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94KLf8fEw/qWnaZYIxJw9lN
 DIV05Zr3c7fwb0BciHzPRwg2fwqaWGLEDQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP
 v2MI5KApbYXB7TJbo=
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="69109873"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EPhwDNqCbNOQCe3PmOX5Bq8JMPTow15i4XNX9B8geTuhznKhIOos3t3ClKZ8DSY3P2WTVnE0EZ07OqDtZCR3CCdJflw/M0yhMxEDVf+c5J7cV1OgtvqZQlH3w23UmAMn7LAwrYVeXWBwO0HjOk4l/hL1mBAP/F5rKDlFC3rM3gnW84vxN52eWz+AfHQxqFKrg94YEV9a3YGQNWRNBKO0805rXY+zqIYtlFgk5THgvyqwxbPMj5gmE4fECoe4yTHPB3KQIaPUJzRYb+voELleG/QZVJa+MEXdO6ECPbgauz3GIjSn8JAQb2lk3LRnpPyYTRip1sXM5APIt3LszGLynw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CjqDlz04ZHJ1O1uKdizqU1iQf7raZFrx37RV2ckVO50=;
 b=mrZDR+9yWow/GPDLoRJs4P7gTHxsVLMSraPmJTJ8GApSTCVg/o8ixc/zkgb15kDqJgrxlG24t6PQTFUsUn0h7rQhA3JIYc7NKuyEkEgyR3vP5CY7rRZwDlkOVI8QaDLrSrXe+lFZ0ZXvv86S+YioGN5L4KleMMp/vjyChUVxNAFBvYtZHXMVEbA/AYWcjjwlFUB0Pdw6L/xSftQ9enZoQjGJpZE8BXYq3YfkW8BiKIYnPIoziE+yYt9rZka/FnPDWu8KeF+oR2X25GwdVQ3+n6DvkE0cMxc3eRxMucxgWic3m3sPsQJQgqBDfV/HchCbcKw4EMInYhypYEJsR3eZBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CjqDlz04ZHJ1O1uKdizqU1iQf7raZFrx37RV2ckVO50=;
 b=SY5YEfe5Ciu242PFPLxh6dT1nnx665snVuvHopvLLJ0bGWPqTjZvs+Hd+77IJF6CuFbN/20x8b21UQBvISsFSIgDwlGM+ZvHTxHAhtTFW3vD9exEuEp/aFVgtlreG1dPDbpkVfiiaTHo9h8GL2xP88+2Fs7i4SPzgd+KV8pDi3A=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH 2/4] tools/libs/ctrl: don't set errno to a negative value
Thread-Topic: [PATCH 2/4] tools/libs/ctrl: don't set errno to a negative value
Thread-Index: AQHYVIiq0AHvGYuWHEC71M7mTuQ1Nqz8BqQA
Date: Fri, 22 Apr 2022 14:47:14 +0000
Message-ID: <9708f9e4-9b75-3572-b5e0-7c0eb2573cf8@citrix.com>
References: <20220420073119.16974-1-jgross@suse.com>
 <20220420073119.16974-3-jgross@suse.com>
In-Reply-To: <20220420073119.16974-3-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bb4eb2b4-29e1-4dda-ade1-08da246efd91
x-ms-traffictypediagnostic: DM5PR03MB2826:EE_
x-microsoft-antispam-prvs:
 <DM5PR03MB28263D8F5B0BD5534D6A1737BAF79@DM5PR03MB2826.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 CiKC9KGNjiVW4S3GrpB4MP6UcGKn9f8YhBLL6JWlJVeG1FcaoicBAvNYhMPBQ7CgLTqqXtUOcjKCh1BHIR7CwZglTA5doJ11SOCQ0JoEgrTKLKMRKJjksEtQy+seXa1uIIGQXV6sS3omglBEslXwMMaSaJSCTsYkqd+RSii2z0n9WedW+shKLZKYhOwUofjoH3FQpGiBMR9vyEzqvTuAI6IvD0hYCuK600rZGZQO6WlIRzeVPUtcS/2iyEXY6sdl2QGzthk09DUmF0Z89xZ2yXjFp6okRR6CaFhPewnDGH4niTHCVgpxRuWti5YKHLWuUqRLx/sAfjPAzUP7fv5vb0/m64WRNjrmZ5ZheKL1gQW+hkRYYpbQNWDsW5nlgTMCXz79op1gqaLIeYstfKoPnwHHBsRjbT2VQpKACNs+GJCD7jmpLZKflRWmbn7RZ7tTXmpHQnixuNzlhpf86VFBbfAtVDYN3U5n8Ss4EB6mnHxegzvupTCb0CjORIHNAdceW4UImsbK5dZmgnSCNdnT4J/weVi6RkogLC8cPt0u6yAA9JupTXlPHGZlkFAU2JXeKAoBszkcp53fW14LD2oon/5Fyl0GSFZ5nl1Mo0zs4Rt5Q2/n96qb7Faju1xvqPEqmedFyqNbi4HA7qWAfa2WR9KTkC4KkwYWRwu5EQA2L6SIkPB6nEA1EvnM25SbmZvdAqT4/FBt3pDur3r6AB2xQ+CSNJN8LHZANSc/ByLHZrh3wk3P3DwXJBVtyufxq/lJ2pjidE8jvgP0HHeK2MmCUQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(6506007)(26005)(4326008)(8676002)(36756003)(71200400001)(53546011)(31686004)(31696002)(122000001)(82960400001)(508600001)(86362001)(64756008)(66476007)(38070700005)(38100700002)(6486002)(66446008)(76116006)(2616005)(5660300002)(66946007)(186003)(91956017)(2906002)(558084003)(107886003)(8936002)(110136005)(66556008)(316002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MXhYeUp3dEhSUERpTEp2M3J2VHo1REJ2Q1Jmdk1UQzhqV0dKZ2VyeDc0ZWtI?=
 =?utf-8?B?TXB0SDAyODRUTmdiMjdmaHZ5eFBSN0ZQck04aG92eHBTM2dOL1VlUXBuVWc1?=
 =?utf-8?B?cU1uWFY5aUFJaTkxMEFEcDZMUC9QVWFabHRPUDdGaHR6ZThIbWVKQmlLTG50?=
 =?utf-8?B?WDFMaG9qMUNOU3RKNlJYbjI2T1VLcXdMQ0dkWlhLUjNCR2s1eHRURG5UazBl?=
 =?utf-8?B?QlNPMjN3bU9Zaitzbjkzc09QNjFVaXdmWStUR3lyTmVvdlNmQnYwRXpQVUpC?=
 =?utf-8?B?L3dWVStLMnhHc2MvTzJNSzBwT0JPUFpreUZHQU9odWU3NXVnMTBkQVVBSUho?=
 =?utf-8?B?S2tRRjExWTV3UnNWNnVjYllsL0QyNUxqczdac0hNcUFrMkNVYzJEZ1lpM0kv?=
 =?utf-8?B?S3NoYVFHYzE3dWo0RGxEYWk1ZU1pU2NvbjhsWkJ3WmtkNjN4Sk1MRnNBRXNJ?=
 =?utf-8?B?dE9tZU1zTXc3MmU1endDeER5VFBRbHdlcWpsMXJwaUhIcjVncFQydFVEQUZV?=
 =?utf-8?B?UCsySFFOdnl3emc4NFdFcFZkZ2dKMlJndFhNMmRnS3g5K2NqL0lYMzQvWDRF?=
 =?utf-8?B?b0YwL0s2b2MyQUUvcUhmbUlMYzFGMmEyWlh4VnRJaURZUkM1ejZKTGpTeGR4?=
 =?utf-8?B?UFJaWTZ3cGVXaXVJTkxyNzBybWdMQzNMbEpXRng3bVdQZ0N0SFNHL1BobTZr?=
 =?utf-8?B?dzZtdUNqaURWTXFZRUUvdXVhVjQ4bzVrak4yQUs1VkI2a3YrTER5VEZSZlRa?=
 =?utf-8?B?eWJyNHMxVlorZExYa0ZNL2VCeVV6cUJ6eWlDTnpLT2w5aTk4WjIzU213YjVG?=
 =?utf-8?B?bVpEK0JpNHg0bUdBVEM2K3E0WlNEL05mSmZNcExiZDBPb1NqNTFuTGp4MDhk?=
 =?utf-8?B?WStXU01pRm5sZlNDYm9HNlRaQU9CeXV4K3VrZmhJTUJaUDY1akkzSDJlajl0?=
 =?utf-8?B?OGxUTnRORmJrdWRsdGdzNXZIUytvWTdZQ0JiQmRycU9hS3VYR05CVDh6SkVL?=
 =?utf-8?B?cXFYV0VDWFFMenhTMnVsbTdqVlZxVzVTWmgzVS9kM3FXTTEyc1dUKzY3U0p0?=
 =?utf-8?B?SDVxTUpib3RkWXBDNlpEOHlPT1dQcVplKzRjUVR6dVJXRGhUMXlvbWh6NUto?=
 =?utf-8?B?U1YxM0V3dmJKWlUzR01nRUtwOHNhTitSUTYyUTRsUVJnTSswbTNiL1V3V3R4?=
 =?utf-8?B?am1QUEVYbHYzMEdBRjVDLzZoeDZlWTJ4NUh1ck8xcEdQZS9ZOWVBSHdLYjBK?=
 =?utf-8?B?bk1sb0hYNHdMMklnUW53MU83ZTF3cUszYkx0bzVNeU94OGYxekdKdTEwSmhh?=
 =?utf-8?B?WUp1ZW84a0Q4ZHRnTWtQNmtGL3c0NGl0TzhyT2ltei9QTnNBNXpab2ZhY1hH?=
 =?utf-8?B?NUpEaitJTkEvOUFiZ0NSdnYveW51V0RKYUQzNlloSnIwanVFQUZaVDhkb0xm?=
 =?utf-8?B?VnRwbC83MjNaZHZJVkE0b1RpbFkyVmtobnA0RUhUVmZMTmt4Rktoak8vemNn?=
 =?utf-8?B?QlhJUWFVZCtTa1d3L0xqcndBWnlOY2daKzlVUkU0TXVMYXVmT0krdWVVekFz?=
 =?utf-8?B?eFFSZDZORHZxY3VxVDFoa2JteTVrbmNaVGdYcUxuS3pyQnh1dHVZYnJQbnpr?=
 =?utf-8?B?VXdRSndRUXBlZHQwMktJRUcremdRYU1qWUR4NVczUkZ3OFFCNUlMeXM0OE01?=
 =?utf-8?B?SWZYSmRkRi9BOVZjcEEwdUVOTzcyeDlOMmU2SzR5VWdWMVJBdTVPY2MwdDJ2?=
 =?utf-8?B?WjQrT2ZVUHBHQngyY0xWcjBOMFIzaUVNcW5SZ2dhSnZ5YUkyV1R1YjJadTY1?=
 =?utf-8?B?eXRPRFhwc1hmc1MrZ1ZqNkJubk9vN3pqZDhoVWtnRWkrcTBRNGdNdlRvVW96?=
 =?utf-8?B?YnEwVDdHeC82cGR1T0p0a2Y2LzF5Tk1ZRTU2VnNhY2xDNnA4T0xuR011ZHBS?=
 =?utf-8?B?WGxNcndmV1I1SUJyTGtLcFFueU92N2E0QjVmSXV6cGNtQkhrR3RKTU5aTHlQ?=
 =?utf-8?B?TURVallqcjZoTys3aEN2aVZkd1UyWVRHVVRsVm9ZMEY4ZzFPZm9oTVljK01V?=
 =?utf-8?B?bVFIWHBBY0NIenNzdUJuNU9GSXNFMDR5OFpvbGNFSDRwb2FSKzdsbjNDbDhp?=
 =?utf-8?B?bnhoaHdiOFNzOU00ODNtaW90RHJ0OXd2U0lLSm5HekE2YXU0VHQ3akxqbGVN?=
 =?utf-8?B?RnJaSkJMQWdwaDJhd3BveVpuYTBobFZPbCtCU29zUVE2S1hSOFVHTEY1eWdu?=
 =?utf-8?B?MGJBUE5BS2prUFd2UlppWldZam1Bb1N5THp2NnEwQ1UzSGJ1eTd0U1dZb2RP?=
 =?utf-8?B?NlB0TnNTcm9XaFBqUlArRDB2WERvUTFPTEhBQStyRjdUYWtPNGxPZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B7E60276AFDFA447875D935C1DACA16D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb4eb2b4-29e1-4dda-ade1-08da246efd91
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 14:47:14.5219
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nBxiZiMegqrqbgbpMVgRxRzgGMXLMO7UxllvPrE42jzRsmz2ZceTtfB53j6s2mk60hJmjORowhPvkZOGr4asHBq7hMrebVLGHqZ1H8hd3mw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2826

T24gMjAvMDQvMjAyMiAwODozMSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gVGhlIGNsYWltZWQg
cmVhc29uIGZvciBzZXR0aW5nIGVycm5vIHRvIC0xIGlzIHdyb25nLiBPbiB4ODYNCj4geGNfZG9t
YWluX3BvZF90YXJnZXQoKSB3aWxsIHNldCBlcnJubyB0byBhIHNhbmUgdmFsdWUgaW4gdGhlIGVy
cm9yDQo+IGNhc2UuDQoNCkZpeGVzOiBmZjE3NDVkNTg4MmINCg0KPiBTaWduZWQtb2ZmLWJ5OiBK
dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVy
IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 14:49:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 14:49:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311027.528001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhubV-0000M6-Mw; Fri, 22 Apr 2022 14:49:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311027.528001; Fri, 22 Apr 2022 14:49:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhubV-0000Lz-Jq; Fri, 22 Apr 2022 14:49:49 +0000
Received: by outflank-mailman (input) for mailman id 311027;
 Fri, 22 Apr 2022 14:49:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhubU-0000Lt-R8
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:49:48 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 73b73ff3-c24b-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 16:49:47 +0200 (CEST)
Received: from mail-mw2nam10lp2107.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.107])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 10:49:45 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM5PR03MB2826.namprd03.prod.outlook.com (2603:10b6:3:121::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 14:49:43 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 14:49:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73b73ff3-c24b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650638987;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=DIkvGl3E4Jcx+d5JejHHOmVng9dnbbg/kukzDT/s5d0=;
  b=Qam4HKB74hRcPVB6FtUoOrEEnEVGTkwmlwYWCjknV6UT7eliQAuXVb+p
   O+8kBJhIyhcK3scvdj4SoyKL3wUIcuQWCdlnlGPjT8H70JUZkZoZDaOt0
   zOTPCOpR8sFUE1vxUFkN5MfyRJmb5f9yWJ9OI1Nrv6PWv0BjXsHW/2TSU
   g=;
X-IronPort-RemoteIP: 104.47.55.107
X-IronPort-MID: 69709779
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:zvS0v61wOqredtFFuPbD5aJwkn2cJEfYwER7XKvMYLTBsI5bpzUFn
 DcfX2yBb6mNYjH9eo90PY6wpEoDuZHRnNRhSApopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy24Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0Qi4CMaz54H5bzmdYYVxt4CwN5Jq5/reqvzXiX6aR/zmXgWl61m7BLMxtzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfySure03x9p7ixKNd/Ya
 9AUdnxEaxPYbgcUElwWFIg/jKGjgXyXnzhw9gPK/ftovDm7IApZk4bmPNCIZYywasxypAWE/
 zvLz2byO0RPXDCY4X/fmp62vcfNkjn8Q5k6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVQBmQsHOC+BkGVLJt//YS7QiMzu/R/FyfD21dFjpZMoV+64kxWCAg0
 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLScZZUvWd9enM/
 g23
IronPort-HdrOrdr: A9a23:x6sY6axIqFmCSfUP9ZPuKrPxdegkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD
 AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2RYUh27D3xnklWavo3RiKmrwPAa
 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66
 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4
 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+
 qvOfttcoreEVc=
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="69709779"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jAoQm9DKer3GRiE3emu+ubz2YWQbxXgSvP0ny77Q+4yauLIhrBQxraNXdtT/EGOH7mM7ZhRSIHY9RklkOq18N1jbOjSyKi/Wy4+S2UvdGUmrWOMe2RaNp6AXT6o3AK6btewtC3vmrKFdnssUccfyNAfqEdlrBm5a4thkgjO/S/2V1ehzDiD+df48lDgkTY3AbbvsUxlxLBuXF0J2BITJWD6iKN9Wbxe0n0eIjzLn0I1wzwETHQTUtZdMUVKvNVAGEiZRuXCEYG24lVkTE3u7hjsSYJJ0WvN4JRqxnEQxc7sODEPm5rF4jsjcwI0S0WFigFqnqeQeLz3C56qL91l8Wg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DIkvGl3E4Jcx+d5JejHHOmVng9dnbbg/kukzDT/s5d0=;
 b=am7hezjIIc8Cubyx66BydmOa/TquTAqEZfB61osiUd6HjiQZfOifjBk92t6jMP6+6try0e8wgBG0H6ujgF6Ikls7+yWbilT/gKiiom6O6ZNc4kXhYnPse0fExJ4S7jqdZmvWU9JA9nGeIXP4PUyeDsO77KuIu0miIQHlb5Qf1fK293lsr0Ce4tnbie6SwiZhMn8b36UpR1QQm3v4RHzH3kSso/hSOnVV8mgePpSQjZNFFRo1bFe8sKUruOlQcZARa4HtyK20nklipCMpXkcR5PTyGu430G6LGPH6hAm3dxJ8DerDsr/8QLSfLa7PBRBQ06UufxRrEEw8/QUOIE3mFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DIkvGl3E4Jcx+d5JejHHOmVng9dnbbg/kukzDT/s5d0=;
 b=XL62x7mu6v2FNMAre/gBu962cfWdPmX7n8rQqnEfQUtYoP+M2OGV8gYYZhLUZyOVz2SOieaIN/IwXxgcTmFzu8j6Zt44Ys5C9NXUVSV9TUi3a32QQyLhQZmjEnen3oqgYBWSGxlecqmben96pFcup+M0Iag0V6+5BIdk2qRMKYk=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH 3/4] tools/libs/guest: don't set errno to a negative value
Thread-Topic: [PATCH 3/4] tools/libs/guest: don't set errno to a negative
 value
Thread-Index: AQHYVIinr/Ua+fX7+EepMs2SjezAeKz8B1QA
Date: Fri, 22 Apr 2022 14:49:43 +0000
Message-ID: <ab1b7536-d082-eb88-6005-fd710bc6a1fa@citrix.com>
References: <20220420073119.16974-1-jgross@suse.com>
 <20220420073119.16974-4-jgross@suse.com>
In-Reply-To: <20220420073119.16974-4-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bba830de-7f10-490e-013c-08da246f5648
x-ms-traffictypediagnostic: DM5PR03MB2826:EE_
x-microsoft-antispam-prvs:
 <DM5PR03MB282695D80DC28A7F9AA9D584BAF79@DM5PR03MB2826.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 6fTk7VG5F/FI+G2hAycxfjgfSCIq6yrA8VRpIaut8oVofwIqAk1fnF2lQ7Y8UzfWIGUwpOdCy9TJFqVHaaWXxyfMbUYBbvXhw+tDeyhvhE0bgTMqic3U0KXUcxim7UX3mag7Rr1ColEgztwewcwdoFBw9w5YMbeyS4EyxsAbXcY4maIeqsSUpT2gX2l0oIUFSmljmrKgklAxVTmZHe/uEBltPwaYtJO9Nv/BJ+1xXnI0GQYe3e0xWjM6x6NlYHPFh7GKxhKOSDLPCr9SEtf/hoqHtk803i7WQ+0l7/14WrW7CcwS+f8ALT93EzsIHtv6b7Hyst+9Sl/Y50G25ELfLe5Csnqi8CnrsNbdcvGolrCOuYx7BLVdriXA3HZNh3VRrGvJ+wE402fWiGTn9iVPR6kF/V54XII93qkNonwjmZtrRsulxGM0bJOeMQ66NL76YGwZi1n5ypBP2fQu7V7igkjDrVrAFYzC/wi+6pH0SmNl3+Zva+rUCxAZhnrYn5284XEMzryxN1HfWXn1fOvBHlLXUBtrtXgOjz+CVuT3HErdnkyC1eQSHGvL9smjyenYNRXGQmXY3bfEe5nl9G9bOLPzpei+SP0CK2VEhD869r4RlXO7mRx8NExRSK0xFCCJETnDGhPHywqGUxaRRqTGN2WFVt36O0FDQC486QuquJ1tHVHquwAr7SBygI5Glt5P7qipWiRUJ19zGQTiSmDBhHDo2WCh9dMT2Gwu1rVhglTmrpcGDoLIKzRpUMkynYh1YMtGcFLKO7JMYpfiETZ97A==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(6506007)(26005)(4326008)(8676002)(36756003)(71200400001)(53546011)(31686004)(31696002)(122000001)(82960400001)(508600001)(86362001)(64756008)(66476007)(38070700005)(38100700002)(6486002)(66446008)(76116006)(2616005)(5660300002)(66946007)(186003)(91956017)(2906002)(558084003)(107886003)(8936002)(110136005)(66556008)(316002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dk5TWlV2ODB6cU9KcEZqeEFHZnB6TW9OSDJ1eEJLOVB5SXVlcFZYbzNUeEVq?=
 =?utf-8?B?V3FuRWRPNVdNQW50RndySGxqLzVBSndIR2hKTjZRaFFXVitQdGxOVWVQWjcw?=
 =?utf-8?B?UTlESFhFMTU3Tmd3UmJvRzJDMXhCNGRzaUpadndwTVVTSVdray9URndpMDlS?=
 =?utf-8?B?ZEMwWGxwaXE5TnNnczgycElSUkpsUG1TcU1NVGQ1WXVhWXhqZ0Q3TWJMNVp6?=
 =?utf-8?B?NGlZcXg5dlFFR3V6aDIzUWtiMUJVeTI5N05zTE43NTU5aGlDUW82a2VpZXRI?=
 =?utf-8?B?VGthbFpNTU1XWW9nMStKS255dzIxK3h6eHVtcWk1ZmVqbGVFZVEycFFPeml4?=
 =?utf-8?B?ZmR2SXNjTXBML0dVNFlxQW4xTnNBcGJUK0ZlR1BKU2NNbHk1aytBL01lQ1BV?=
 =?utf-8?B?TEM5THcrZzhSSXkvQjVab25TMUFDcVh6cU1qQUQ1ZE1wUnIzOS9mMHJEcFVn?=
 =?utf-8?B?ei9DcE9KV0VvbGRIbE5IZ2pWT1dWOGNxRVNOREZnMUpmVHJYTW1NVEFDT3pV?=
 =?utf-8?B?dVlVTFR1ZGg4Q2lqTjRHdmVORTZkNEtsZkwrdVFIM3YxbDZ4d3g5UDNTMUEr?=
 =?utf-8?B?WThoVVV0RGpUcjFRTUNWbHE0NEJlRHZiRW5BbHZUVWhGQVZScDZiTU54dmVB?=
 =?utf-8?B?bTlsTGdjZ0Nja256Qi9VNlRiOFovbEVXMjJwV0FtZ256V0dSZFpIZnBVSThG?=
 =?utf-8?B?T3RuNUg4SjhMQUIvTitESy9aakJJVU43Mi9TMk5RUzlpeG9GZGcwY0JOWDZW?=
 =?utf-8?B?ZVZ1eXhFWlEwTk5uQlRLZzAxS2JCNUY0dCs4T0FkaWd3SzdVOUo5OWZwU0lY?=
 =?utf-8?B?Skk3SFBEblRpcS9vUTQxSmdHVzFGYWE1aDBUajViQ3ZjTFdXcEZYKzdjVG0y?=
 =?utf-8?B?ZFBpL3JkQlh3eTJuU0J4UHdkbS9ndEI5V0FZTjZRK0IxcWczcy9GeGhSREZp?=
 =?utf-8?B?UkF5QS9ab0tPOU9GWkxGUHRETktBY1RnWGU4Sm8vOXQ4SC93N2NreEsva2Yr?=
 =?utf-8?B?S0lDdzNITDhuY0hqZmVsSWtjVEpVVmsrUUZDc29ZcnRxT09xL2ZEUVQyNXhu?=
 =?utf-8?B?dnhKTm5jc0U0dDhCZ2lVM21sUEFtVWNPMWNweEVCeHQ0NVNyM29DMmRPaE9s?=
 =?utf-8?B?S3pFZ2d3R0QwUHdBVTN2c0hGM1pWRGFCL1JpTUEydWVKY3hab1V0UUNWa3Vs?=
 =?utf-8?B?dHY2Y2VncjFBMHlwcEhkaHk1NDlGTTM2ZHFiTGxnemJpSWlZNG5FOTB2akY5?=
 =?utf-8?B?UTVNSzVwVklEM3E0MUQvc1BiOFRwOHhzdlF2YnJEeW1wbWtCSFZuRnBqODJO?=
 =?utf-8?B?ZU0vbXdzZmI5NTNTRVphSC9JOFRtYU1CWWpjTVp3azNsc0RhYjRON1VZQmhF?=
 =?utf-8?B?WU1wUm55ZDE2ZkNvSjFoZG9jeWNPNlRneE54UUdJMERWMGdlejlZS0Zrblhv?=
 =?utf-8?B?cnY4SCtibkRneDlJT0h3d2NsSEJBaUlGOTlMSzhDb29mbmtyS2VKeUltSUF5?=
 =?utf-8?B?bHhQOEpGNmpDb2h2ZjRncUFBWmVFQVpQOE5QT0ZUTTUvV0ZPTFRKMmViSVJz?=
 =?utf-8?B?eFpQQ0tKMlVvbS9PUHg0UXJjckJGaGcvK2VtZHVPNkh5OHd0ZlNqVHkzdDJV?=
 =?utf-8?B?OGlSR29VSXNLL1FXV0JaNUhlay9rT3E2UUlzKzg5MWZQTllPckxzYUJyWlh0?=
 =?utf-8?B?b1h2NDZUZU4vUW95VytocGdxN2l1NWpJbkJROUxldDA3YXFOTEhDeXVtWWxu?=
 =?utf-8?B?RHlSV2pveXNHc05zKzhzRTFaL1BYeEtVTXBGVHZ0bVFxanF0WkxDQmhmbldB?=
 =?utf-8?B?QkFtazRuUkFjQlNGODVNb3c3N1BLZlRDWXRCc0xVTS9YTGZac2dYQm8rbExy?=
 =?utf-8?B?cDRTUFVPcHBENTJub1J5QmdOdHIwWWtvRjhlNDAvb1pRZ0R0MUx6STR5QWNX?=
 =?utf-8?B?NUZxTDRnMjZxV1V6SUVQblZxNDNYVmVnWWoyb3E5N1JaV05rTU9QOXJ1dmFp?=
 =?utf-8?B?VFFMdjBpd1o5UXlYK2E0c0hUTU1ZZUQ3RGtqUnpOdXRWUXppdi9rVGpSSXkw?=
 =?utf-8?B?VHBBRmtoUGJ0dzBSaFZ0Ykl4QVpWamFSN285d3RmWXhFeVhYS3BPd1N6UUVT?=
 =?utf-8?B?UnpmUGlZWEZnQ3BmYTFhK2tWTWovU3lWeTE4Y2E1Nk44SXpyVkdiSVBqWW9D?=
 =?utf-8?B?bEtxTHB0N0E1OXBCeXNvVmkyMjRtYktHN3l4cDJSSVJtUmx0WE9ST0ZBRTVp?=
 =?utf-8?B?UGVYWS9Hd0VnU0lseHFRV3d2Q1g4bUxMVk5SL2pJUVNOdG1EWnRRWVRYZk5w?=
 =?utf-8?B?aTVWYThVL2pMZWJUbll2N1FST3NBaW9PMXZCVElUTmR5bGx2VEFCQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D51F3D454FE04C428C4148C706039106@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bba830de-7f10-490e-013c-08da246f5648
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 14:49:43.3250
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w/UwmhUeBjDLe7//5msiYcQRMcRmww+VX3UCpjMw0znArEZG6XDECyAKKugS6FBdyqzvmXitMbAwrWcfPwOP0DftpLOUtY0uJt1BpE09E4E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2826

T24gMjAvMDQvMjAyMiAwODozMSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gU2V0dGluZyBlcnJu
byB0byBhIG5lZ2F0aXZlIGVycm9yIHZhbHVlIG1ha2VzIG5vIHNlbnNlLg0KDQpGaXhlczogY2I5
OWE2NDAyOWM5ZA0KDQo+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNl
LmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5j
b20+DQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 14:52:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 14:52:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311035.528012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhueP-00020G-5V; Fri, 22 Apr 2022 14:52:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311035.528012; Fri, 22 Apr 2022 14:52:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhueP-000209-1f; Fri, 22 Apr 2022 14:52:49 +0000
Received: by outflank-mailman (input) for mailman id 311035;
 Fri, 22 Apr 2022 14:52:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhueN-000203-MR
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:52:47 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de477ece-c24b-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 16:52:46 +0200 (CEST)
Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 10:52:39 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BL1PR03MB6151.namprd03.prod.outlook.com (2603:10b6:208:315::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr
 2022 14:52:37 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 14:52:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de477ece-c24b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650639166;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=bUjaUQsZ4QqG07Za/uRxFd4B76IfSDF4tXRoDPFEuYE=;
  b=ZSZmIOx9Z7+zrSBJAbgnbDVyht+5UW6de3bwGu1UIITOK+2OJLdC3O9L
   T1+GD8eqSs/FMgCfRwTuw4Vug7vZAkyLHa4F4RlC2WIciVIXJVOw5nU6W
   8rCcNK/JhlLut1nRk8O0oTjnu9KhoUnwERNNxtIWOdOdBKC024RnVQkSM
   o=;
X-IronPort-RemoteIP: 104.47.57.176
X-IronPort-MID: 70114302
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:kGRe/K0hcC82YFxrqvbD5aNwkn2cJEfYwER7XKvMYLTBsI5bpzIFy
 TcaW27Qa62MMzfyL4x0bY+w9UIF6p6BmoVqGwc6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy24Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1EtI26EhksEpbiwucvWihFSTpSIPNvreqvzXiX6aR/zmXgWl61mrBCKR9zOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82cBfyVu7e03x9p7ixKNd/Ya
 9AUdnxEaxPYbgcUElwWFIg/jKGjgXyXnzhw9wrM/PZsuzK7IApZgeDEbOuJR5+2T8BOhB+Aj
 Ebk+m3rO0RPXDCY4X/fmp62vcfNkjn8Q5k6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVQBmQsHOC+BkGVLJt//YS7QiMzu/Y5lifD21dFzpZMoV56okxWCAg0
 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSvbdYgHdcd0o/
 w23kQ==
IronPort-HdrOrdr: A9a23:qhxUs6wIHMCwDzNJ8Ji1KrPxdegkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD
 AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2RYUh27D3xnklWavo3RiKmrwPAa
 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66
 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4
 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+
 qvOfttcoreEVc=
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="70114302"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VAhmuYcPYZSn+mXEindtgIYP7MrH4tcABcZkS6tyEZyyU/u/KPXUHsJ21ZXY8OtTbTSUIiJ7CIi9n4IqXZCYmdMkvZobFu/DH8AazfpSgf9yqhOYivjYtikvrAtrUqcUWFtnS7VEt+1M4HhhjY9A3J1bk+lYWQ1aJytUXm51pwfxIGs5QFDn5hY4diLhOptUfO/p2JZTb75Oazwxf+thn2mt4vuYpsGYCUdJCLIjxIKwPM8a2hN1RYZShaBF1dMQZ1Sq9DAKl6t3KlarJSN73bxOd1QCaZM8RepnLFbWBvkf3WXS7PHNO/JRxc1auIlEmdnJBSwBL8DbpX0UiRh03A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bUjaUQsZ4QqG07Za/uRxFd4B76IfSDF4tXRoDPFEuYE=;
 b=OJsRXJz5ABuuMQf+FsdyavC2EQ5I0EPOx94I7lTo5HYHIgg2T3mU+fN2nv6ntBZLIwLvzvep3sQ+nudV6lAyfg1ChGyAtuYN64ytpc6edV0PtvK90zRVSRBt8PdDLQkjD3V1nKxkQB/STy1uEORvm/kdD7Lxz8Z1egzY5GO2Co4dSnoKdL9PFRzjUFztA2lHa2ReRbPpolznF4+atPVNZcJJgJ3oXdvwUzkAZDOSEzLJyUPvIGTPChLmHgfOAErcYAV+QxGSCtVEgcZ3Cmk+3cFoxtOV4/ae61zJzKgDbLUW4VHCQJRrAyRiPahyQoBpBLF13kEOz45F6y+rgO5xZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bUjaUQsZ4QqG07Za/uRxFd4B76IfSDF4tXRoDPFEuYE=;
 b=pqFt7BBCoOzXhTGcgFCKAGB32/BOBXlBqMZx4r9Jv0c0nOYK+RLQjRPZTqrg1/aE0CEsxL8SIlMK9FSWjlIh298ct9B5OvrarhmWT5APm+0rrhZCajXKk3pHofQ0GY//e4LTULy5ijVVJCzpWi//wDSwfg3Dsy6hXCCCHNKYIHY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH 4/4] tools/libs/light: don't set errno to a negative value
Thread-Topic: [PATCH 4/4] tools/libs/light: don't set errno to a negative
 value
Thread-Index: AQHYVIin9iN+mLKty0OtvWT3B8JHOKz8CCWA
Date: Fri, 22 Apr 2022 14:52:37 +0000
Message-ID: <f2d73d68-b313-0f5b-7a42-ad6bef7f5620@citrix.com>
References: <20220420073119.16974-1-jgross@suse.com>
 <20220420073119.16974-5-jgross@suse.com>
In-Reply-To: <20220420073119.16974-5-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3def8e7a-f819-4f00-0b99-08da246fbe06
x-ms-traffictypediagnostic: BL1PR03MB6151:EE_
x-microsoft-antispam-prvs:
 <BL1PR03MB6151FE3D73704743AE384A5BBAF79@BL1PR03MB6151.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 J1DIAC9NOZ8ohS533XgBLkWRyOdvX35E5iiz/rz487d/Tvb5lGpMmZhx/9AQRhqQ4iRMogumd5GS8isqZNL6stS6zFHP7QEp7t0Yh1UIApNxaZMS919ycLkyTlmRwYv7358PjnxHAVLT4hONCQkWj1zCOl2HWmvFmHcmEJeO9kq2jgxJ+rhZ9sjADnqT1H+lsSI02IP/LRDLOIGQ7iPw7fDK5ksI+pKMPVl+K9qhOK6QisES/1A26tNTtigjUD+95ZcE8aDpAvs12dJ+asdWfr9WzF2JDIO0MlG1P72kzi5SVv/10yt+nNOfKxYWZGNuYzbI60e4/WAPkQ0plh9c1VQjQ9TyFbT9WtyBI16yKMfSHAnsXzz9SxwXSJubayfmJQ3KwMgSRMePcPc9pThWeZa+T/4x7ammU/t+TLFDHOHxLn3tdf52dxZGmUMF0nd3s1fR4jm+7NFsNgJ4VEL93uYb5pQ4bLsjEQ53JcxERxIrtMwENekFEkBl3lgYLMhuanNKmO/BmjMsWXnyYk1eiuMDPcNjuwikFdkADpmqUiS0kZmm16VGX4bSJ2hOajsyuYf7j7m3e8QZCFNzx+DJiedA/Ir8HnTJTTl1hkWvVfMsYq2b10LNuXlRVUO6mZqepzfuBpbWTejbrXeOjMMSJaOx6HquznEyN34tkTmGt3jA/9eGVUJcRMcI2IM7sFv9GYooDRM6EIra06fLm9JZ2QunMraAI2vxW2+p8etxStFhq/aoc5ffDhtHtL93DLg+TASuwkmABWSgP/sXl/mCog==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(5660300002)(38100700002)(2906002)(31696002)(316002)(91956017)(107886003)(53546011)(8936002)(76116006)(8676002)(66476007)(38070700005)(66556008)(66446008)(64756008)(4326008)(122000001)(82960400001)(66946007)(2616005)(6512007)(26005)(186003)(6506007)(71200400001)(54906003)(110136005)(508600001)(6486002)(558084003)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZXpwTG1OUndvbitVeHg3YW9LdklnRmZSeFZGejVodXFPQnd3SFZPaWhFMGJv?=
 =?utf-8?B?bGZ6Szd1d2VIQlViSWJCY29NZWR4QlFLcDdIVEdheHh1eFVaakc3aFJ5ejlq?=
 =?utf-8?B?TnNWYUtWMXNZdlArOFRtN0QvZE9JYUVGTkNSVzdrREtTWlo0U1RySk9GU2th?=
 =?utf-8?B?T29vMUxlVGJaakNFMTlYOHFodXNnQ0IrTkpUbVF4VVRndTFEbjFSVnkwa0ZX?=
 =?utf-8?B?ZXNDLzFCdzF2ZmVKTmZNdlRlaWxId294TUtsMDJ1T2RSYnRxcUVCSCsweHZW?=
 =?utf-8?B?M0JkQ2Uvc1Fad2IxSFM0clVLSytXRlkrUWVQaE9RbWNjOFhYZzYwc3owZGxX?=
 =?utf-8?B?L0ZsdHRwRXk4S0pBWXY1T3Y2NmlZNVVYTXRPMyt1MHVHYU96YmFQdDJUVTdL?=
 =?utf-8?B?MkdIZWpQNithMDJ6TXF5Ynprei9Qb1R3UVdNVzFHYUVhWThNK0FoaUgzSEtO?=
 =?utf-8?B?RlJxcWhBVW05Uk95bVg5S2U2anRwdDk5UlUvdHgwUnVnT1hqY1VSampDbjlY?=
 =?utf-8?B?ZnFTd2hzWkNJVTBmakd3bFY0dXBROWJWbG90aDBiQ0x4eGo3Q1NyQUtHWFVQ?=
 =?utf-8?B?c1Fwbno0SXZIcm9ld1BJZXViNHNBWnduU1hRQ2RtemNSTUU3c3prcjdhTnNI?=
 =?utf-8?B?Mkw0WW4zZGpjSUN1N29Rd1RpZHZhUEl3VjRlWXBMQzFCdWd5MEM1QlI4cjJj?=
 =?utf-8?B?c3JDWTNTRWdUUlcyT21xNmFRMjM0N01TZW5RUUF4SS8zZ21NZjBJU29XaHp4?=
 =?utf-8?B?a21rY0YxQWVvZG9NWDRCZWtsdlBuYmFWaksvQzlwV1FGVm93OFZVQkJEYkdG?=
 =?utf-8?B?UitmdDU3VnEwYnB5MkI0WDcweWJFOXdxUzl1dm8zbFJHSjl2b3pMZ01wSUxx?=
 =?utf-8?B?RkdSOUwrTmlwZnA1dlowUGw1M0ZZZVkwb2lSUGxBWFpmSFN5ZitjdnpYNUdr?=
 =?utf-8?B?Z2hUWHU3QlMrTjZTaDRHaDFwbStnZnBQNldmdmIyOTV2dmJSYjFRM0t4TkVi?=
 =?utf-8?B?dTJMa21wV2FtVStiZ0tsZnFITys2ZXdNeWR5QW5IdC9TcmErRDNMT0ZQZ1pD?=
 =?utf-8?B?ajMxMkhUZzBMQ2ZEWUtSU0tTQ0tUV1hMSGtpTmNDaTM2RWFaZ2t2NmxoNEhD?=
 =?utf-8?B?a2szTjdqaTlkSjB1TFg1VnhGVWJzUlZNNnZpSjJuVy9JYVlhRVhTQnFXc0hj?=
 =?utf-8?B?eStWeDBaSzVHa1c1ejYrMG53aGczSzhXS0U5Q0FQdVUxcE1QUWkyaG52YVhC?=
 =?utf-8?B?cHMxcmU5SlVDdkRleTlKOFJRQlQ4WCtQRmYvQ2JJRW8rb1EwUUVtc1IzZDVP?=
 =?utf-8?B?UHBSVDZFQWk1SFlld0lYbTdQbzBQVTc0WCtnSGl5c09PcTladEVnaTdvSmYw?=
 =?utf-8?B?ZTNNL2hmMFhTQlRiY05oRXdqQU85emhZSW1sV0xKTFpScmFuSHhXRWhzUk41?=
 =?utf-8?B?SjVGbXBqMURWdXJVVDhEbStLK3Fpb2ZGRWZGYW1acU9lTWNKby9yWE51U1gr?=
 =?utf-8?B?N1RoY3lUMWwwY3k4TXZpejRvWE1YVm83dld1Ulhvd254YnNhdUhoQzIwcVFh?=
 =?utf-8?B?Q2ZRRkxQTkg5OEY3ZVNPVGhXMlNXQmlYRVBVakhnUWkrMkNIUktLL2FOZFph?=
 =?utf-8?B?aVluR1VZQTY3V1JKaCswTUh5bjRpMkpCaTVlUVI2RXA0Z2JUSENsQUJIb01P?=
 =?utf-8?B?WFBjTWJXM1ZaN3B2eUQ0SVZzNVFYejZHMXdvYUszZEVNbjNVaUlScGQvbGQr?=
 =?utf-8?B?NkJOQkNUVmlIT1JSYkwxZFZXYTB3MTFIZmRUbGViUkxzSnVobXJRV3lCM2tX?=
 =?utf-8?B?b1NMOHphazJIVlFVVW82YWl1d0xjSUsrb0NiREhQdmh4QmpMcDJ4YTY2c1Rl?=
 =?utf-8?B?em9rSWVpRGc0SFg5WitUeHk5Skc2S3V1bkNITUNXbE9uTFEyaDNJZlhaYkhh?=
 =?utf-8?B?RkRpVGVmYnlDcmF5eFJNakZMSU51RWlqRlN0cEhadTE2NHJkOFdIWVNFejlC?=
 =?utf-8?B?WVBFcmNCNEZWNWFPMjVleVdOc1hMNmpmaXhTcWdXODNlcngrSk50L0pYb2dN?=
 =?utf-8?B?bVR2aFh0Mk9YSmt1TXc3L2NVdk1sWXg3blh6cXBLYXdLYmE0RE1xTzg5cGR6?=
 =?utf-8?B?UTlyQ3FXZzZ2QVhHWWREbXBUTlBDcU9xTmJ4WDdqcUNQcEpLeHV0RHNxdDhE?=
 =?utf-8?B?eEt0b3o3dkJDLzZzcmQrdFdiZEFMWTZJcVhIOXllT2VUVDEwTzlUZWxuNUNn?=
 =?utf-8?B?SEJYNUlWSXdkM0xnVTJuZkVpeWxuWjZYK0JpS0phZzNEME13aW5EU04xTGY3?=
 =?utf-8?B?a2RXT2ZwTzl5NWhkSnZralk3VHZGenNzNFp4UDlrRDFDOHZkM1Iyd0hXVm9J?=
 =?utf-8?Q?2BrRzoFdbLzXdwOU=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B3B3A19E27CC414F853A5EF20E081062@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3def8e7a-f819-4f00-0b99-08da246fbe06
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 14:52:37.4071
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Qhi31dXjy+dvTdLfA4i3NEIH4/Yu5F/b1Koo1P4G1/bl0xeHxJ9MvBKjw7gNqD8DyS7fxODfkahqEqp47fwsg3RgR3hD2KVNCp6WSHXpOOo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6151

T24gMjAvMDQvMjAyMiAwODozMSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gU2V0dGluZyBlcnJu
byB0byBhIG5lZ2F0aXZlIHZhbHVlIG1ha2VzIG5vIHNlbnNlLg0KDQpGaXhlczogZTc4ZThiOWJi
NjQ5Yg0KDQo+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4N
Cg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 14:55:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 14:55:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311042.528023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhuhD-0002fM-ML; Fri, 22 Apr 2022 14:55:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311042.528023; Fri, 22 Apr 2022 14:55:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhuhD-0002fF-JO; Fri, 22 Apr 2022 14:55:43 +0000
Received: by outflank-mailman (input) for mailman id 311042;
 Fri, 22 Apr 2022 14:55:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aXhv=VA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nhuhC-0002et-EB
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:55:42 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4762da50-c24c-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 16:55:41 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 079FA1F388;
 Fri, 22 Apr 2022 14:55:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA75D13AE1;
 Fri, 22 Apr 2022 14:55:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id rlskNOzBYmLQEQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Apr 2022 14:55:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4762da50-c24c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650639341; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZxaMZ0DFNUnG/GvA3+xXEC79r2XUD+QrpwgwSqDbDnM=;
	b=bL0V9mlszGb0kf6zY3oAsaVLBl0T9pEjzELKCg1ppZoU+AO/mV0DIFEIVXBELm1xKo5Zap
	GPt+LDJLoeqLDD/cuAWRypt4AYtp2v9GRCRfM/ZycHHj6QjAt7BmwUngtG3NFPZ//9VOOe
	u8tcoLe9WPbXYfDmH41qACOqV10A4xs=
Message-ID: <f70f7746-2e9d-3418-d198-aa42cb58c9ad@suse.com>
Date: Fri, 22 Apr 2022 16:55:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 4/4] tools/libs/light: don't set errno to a negative value
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
References: <20220420073119.16974-1-jgross@suse.com>
 <20220420073119.16974-5-jgross@suse.com>
 <f2d73d68-b313-0f5b-7a42-ad6bef7f5620@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <f2d73d68-b313-0f5b-7a42-ad6bef7f5620@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------bKH9gZZsE5VtHK3Y23Vmauqh"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------bKH9gZZsE5VtHK3Y23Vmauqh
Content-Type: multipart/mixed; boundary="------------XgMDZMCPHAzuIT0J0akbSoNi";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Message-ID: <f70f7746-2e9d-3418-d198-aa42cb58c9ad@suse.com>
Subject: Re: [PATCH 4/4] tools/libs/light: don't set errno to a negative value
References: <20220420073119.16974-1-jgross@suse.com>
 <20220420073119.16974-5-jgross@suse.com>
 <f2d73d68-b313-0f5b-7a42-ad6bef7f5620@citrix.com>
In-Reply-To: <f2d73d68-b313-0f5b-7a42-ad6bef7f5620@citrix.com>

--------------XgMDZMCPHAzuIT0J0akbSoNi
Content-Type: multipart/mixed; boundary="------------vkYKFRQNVKPK0o3YlbnbvhSy"

--------------vkYKFRQNVKPK0o3YlbnbvhSy
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjIuMDQuMjIgMTY6NTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDIwLzA0LzIw
MjIgMDg6MzEsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBTZXR0aW5nIGVycm5vIHRvIGEg
bmVnYXRpdmUgdmFsdWUgbWFrZXMgbm8gc2Vuc2UuDQo+IA0KPiBGaXhlczogZTc4ZThiOWJi
NjQ5Yg0KPiANCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNl
LmNvbT4NCj4gDQo+IEFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj
aXRyaXguY29tPg0KDQpEbyB5b3Ugd2FudCBtZSB0byBzZW5kIHRoZSBwYXRjaGVzIHdpdGgg
dGhlIEZpeGVzIHRhZ3MgYWRkZWQ/DQoNClRCSCBJIGRpZG4ndCBib3RoZXIgdG8gZG8gdGhl
IHJlc2VhcmNoIGZvciB0aG9zZSwgYXMgdGhlIHdyb25nIHZhbHVlcw0KZG9uJ3Qgc2VlbSB0
byBjYXVzZSBhbnkgaGFybSB0b2RheS4gSSBqdXN0IHN0dW1ibGVkIG92ZXIgdGhlIGlzc3Vl
cw0KYW5kIHRob3VnaHQgaXQgd291bGQgYmUgYSBnb29kIGlkZWEgdG8gZml4IHRob3NlLg0K
DQoNCkp1ZXJnZW4NCg==
--------------vkYKFRQNVKPK0o3YlbnbvhSy
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------vkYKFRQNVKPK0o3YlbnbvhSy--

--------------XgMDZMCPHAzuIT0J0akbSoNi--

--------------bKH9gZZsE5VtHK3Y23Vmauqh
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJiwewFAwAAAAAACgkQsN6d1ii/Ey9F
ZAf/QmvI+5M8Hy1ORM5DCEN8xJ1WU4nRKf1kirJLBHTBujrxk+iQJ7rt/PXlyR1GA5HsTMcVJc5d
ZC/fWDeXEqWMy7QDp4Y2GvsiGHS0IU8JzqW1lN/234VcAuNS9nHBC6ffqOwMICGh8Q3e/pEWkLkB
TaqCn2VqH8BIn2XS0BnDvS8Pzn3BXvW0eQsKw5uNftpXj1sgCulVre2qt454sXpArUUDBj+fLVet
Zr5dvcpfPvrMrktwVtM8/jm5Ox19zkU+Gs/NE7BgLbN7JICrBLVwmJXYXkTMNFE7mqrQ/M9+kC41
Ul5RfU61ackTlhy9TwwkO+9ICWAycPPgEd6RuWdnKg==
=C3mi
-----END PGP SIGNATURE-----

--------------bKH9gZZsE5VtHK3Y23Vmauqh--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 15:00:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 15:00:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311047.528034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhulR-0003wO-7l; Fri, 22 Apr 2022 15:00:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311047.528034; Fri, 22 Apr 2022 15:00:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhulR-0003wH-4H; Fri, 22 Apr 2022 15:00:05 +0000
Received: by outflank-mailman (input) for mailman id 311047;
 Fri, 22 Apr 2022 15:00:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhulQ-0003j4-0w
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 15:00:04 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e24cc44c-c24c-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 17:00:02 +0200 (CEST)
Received: from mail-dm6nam08lp2040.outbound.protection.outlook.com (HELO
 NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.40])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 11:00:00 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SN2PR03MB2400.namprd03.prod.outlook.com (2603:10b6:804:d::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 14:59:57 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 14:59:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e24cc44c-c24c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650639602;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=gMv2Mf3HbKb0S1kBCFIVNZS23nc51ueQKQ+r1qjJMw8=;
  b=MlQd5RCakW4rbgJWMv6OzlP8JzOeO0/UAQDzmB4bGVZdGSO51RKNUfqT
   YNLFTg7JXo0zIM0bgGfaYipbjDTXFsqGjw/yRyX5rhhT0aeo9aYclEGW3
   6FAaN9tZnga55lTHr0hiL2oAm6L369DY9Bp/u9wiVtmnNi7lyLbKzPakp
   o=;
X-IronPort-RemoteIP: 104.47.73.40
X-IronPort-MID: 69710555
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:WHXPuq0FL5EarR4dz/bD5dBwkn2cJEfYwER7XKvMYLTBsI5bpzNSz
 GEaCDrQa/3fNmr0Kdoiboi0oBsCuMXXzYRnTVZppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy24Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1q7riRFQIwOZbJkd4jQysBQj9iMYZvreqvzXiX6aR/zmXgWl60n7BCKR9zOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+YBfmSjTNb9G5YasRmNPDSf
 ccGLxFoawzNeUZnMVYLEpMu2uyvgxETdhUG+Q3M/fdqvgA/yiR+6+bcAvuLVefVSJV6hhy/j
 U/E70rmV0Ry2Nu3jGDtHmiXru3AhyTgQ6oJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvHiWzWorXjCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1Z8hMcOscY3QXkm0
 wGPltaxVTh36uXJETSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6
 2jihEADa3871KbnC43TEYj7vg+R
IronPort-HdrOrdr: A9a23:nCTXiqGfrM4vX1hBpLqFsZLXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq
 iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq
 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P
 nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo
 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp
 +ISedrP8M=
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="69710555"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h7CifjANm3gQTEBerVtj5BRhS3h6+YMHzK/uSiBx1gdggFnEmyF3dcdVqLc8P/xqtqxKVjzWOR2iERtyOFTZi5TUCyPjBxoN+Fe2WmnS6AwNkUZ3BNCgHrQP55hSqfFNpxthviXS5VLW6eY1kvGCPKV4S6UkFAfd/HMZ6CpC9m7IGcdk5grd5sn//rCjVEzsTjzlCyuwfJQVtAcC+439Hevwn9VMYJGmbPOdyz8XsBroLseg6P/CV0sTON5/QS1NwcQRGWBqmbE9KmueU+4EfH684+adIgyfH5JuCpJXOEDi/pjTmjzqJdmFrHkbzHn01Z3R8m5NJ10m2XKRKnFo+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gMv2Mf3HbKb0S1kBCFIVNZS23nc51ueQKQ+r1qjJMw8=;
 b=HmjgcXfhh52aIf+lD0RLiLn8456uCMGvJAQ3kVVKYjMbXMVwRp+hhrcV2DtRpPMGWDsgLwIkTmx6JjsUz3OAjBlzQm9CMhkCamoY8WW8wIJkyNDVAb+XahxKD3r39KCF9yc/Br7ZsLos7e1qzzR8zk0VyvEHOwdmwQVZNjorTWX9yO1hgITkwCV+17bVzqYgMCBphJsCkPCiGIIlOWV4teL4eXCnlfUkcas+v20g4HIWSa4RXnXe1t2Zbk65k7RcrqkBHLj1bCB+/xHKcRxc0yv2mRoEq84YqXSyMcmXViU5RJqAOtptpztE3JGALuxE9a6hUbpVT1C3wCD5FNaXew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gMv2Mf3HbKb0S1kBCFIVNZS23nc51ueQKQ+r1qjJMw8=;
 b=X7FVe76pXW/bWtH0i2UgVm6bmMgWYaQT2KIbDthopfSIU/uSHUNMRo1Zpah9aTiqLSM4aDhAlsVo55LIUb5UJmwOD+hdCNIu/bpU6JdEmVHd7iVdOfcdSs7ndLKhru5RXnPAUXwd7E+Cdw88b3qM6vRAKgVYSAGloxejt91n9iE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Jan
 Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 4/4] tools/libs/light: don't set errno to a negative value
Thread-Topic: [PATCH 4/4] tools/libs/light: don't set errno to a negative
 value
Thread-Index: AQHYVIin9iN+mLKty0OtvWT3B8JHOKz8CCWAgAAA2gCAAAEygA==
Date: Fri, 22 Apr 2022 14:59:57 +0000
Message-ID: <e7a1c235-1746-e3df-f3d5-77edb899b8a2@citrix.com>
References: <20220420073119.16974-1-jgross@suse.com>
 <20220420073119.16974-5-jgross@suse.com>
 <f2d73d68-b313-0f5b-7a42-ad6bef7f5620@citrix.com>
 <f70f7746-2e9d-3418-d198-aa42cb58c9ad@suse.com>
In-Reply-To: <f70f7746-2e9d-3418-d198-aa42cb58c9ad@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5b706ecb-a3ba-4dca-e195-08da2470c44f
x-ms-traffictypediagnostic: SN2PR03MB2400:EE_
x-microsoft-antispam-prvs:
 <SN2PR03MB2400E620EE56D258DA3FC971BAF79@SN2PR03MB2400.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 oiASaU57zK9sqr7aqNiUC7xWVlNqslNyZhx56X+TKUieREieBVhqlDFnaoq5L3XXyjZethig2Mp2D/29fhYxyQ0PPGSaOC/bhcnTNob+5LSjPm63B74okJQSaj6Lpawr8fkJEddBgLwWLFPl73PIU64YQ3SBCit24xnqgI0V1A1hZ3DtDd8apIiMcvgZ41IZQKiHRMxrHB/3wELCMcg5lHhwV2KJ7QqatWxOlGk2AbT4qraE4SXOc9rum8LCWJ2T+Fxlr7S6N+3k3ING3RRfI8VZY86U3LT+c/i8iDkwfl5Ho0y5RC4O/DVIs6v9mPzQCwgKThc7CR3iz8M6zeJpDOu31O8M2sYpfL1yxbuUYLbBvXA5T+XqqhUDuKFbG0Pm92w5w84YwaIOmrFgPE+V0a05Cz+2osL9A4RMpEyrIB1MLM6S9PEGg3D1uwprUHbKUbuJg8JYuRBKr/8TTgKl397KfhedOfuwkh53mZbe3MMNieXwGvatP60JmCSqN3owp6HFLAvA6B1Uk85aqkPwoYZ1KJIsGMxRYsqJRwawgM+1XC7P9rUdvB5vz6zKeHtX4DAeN6jK9OgyZyTazprnyUvGQQXp1/1BLqQ2yMMrIrm6DrrozF3YeR57ROX7qNONz1KwaHP80+k6THPmqmNGjkHA5EHJ+XRD5n59fv9rStfh8YtXXPbH4ddN83Jcwg/R5iX+PTQwV6AO5WQHQOfkXsdSwBE29ErCY7i+3nTqOAnFGyFDEC0spuX8NF/DoIKH0dD3u4U9MMDobZaDQqdlBA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(2616005)(86362001)(508600001)(6486002)(4744005)(38100700002)(6512007)(91956017)(66946007)(66556008)(4326008)(38070700005)(26005)(8676002)(66476007)(76116006)(66446008)(64756008)(71200400001)(82960400001)(8936002)(36756003)(31696002)(122000001)(316002)(6506007)(31686004)(186003)(54906003)(110136005)(2906002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dnlYZjZnWjlHdUZCVTVqd2RjTWJXZWpYQVRndW03RWdmN1dZaHNyTEFXM0R2?=
 =?utf-8?B?S1dxbTRlTWNjQVlQcWc2bG5QSWNVMlNjcndLZlJQSGxUcncwb3BZb0xNSTM4?=
 =?utf-8?B?TVJaelBOY3hUaXdjWWROSXVWdyt6VnNzenUzN2I2REZIM0dDQncwcmRseU94?=
 =?utf-8?B?VWNSQmdnZ0VLb0RmWnVIUFhmcjVXSDdDamV2NHg1bHhqTlJWOHZISkxwSkhS?=
 =?utf-8?B?OVlOMVNVWFJOSjJPYkdpMk9zTXVpRC81eGpGM0RXeXVmVVJjeFpnUU1qVTh0?=
 =?utf-8?B?angzKzg0ZW0rbmhZSXdrd2h3Q1c0dWNrb05DajZ6aDN0ZGU2QVZqVkJOVm1v?=
 =?utf-8?B?RThWZ0ltb0RUOEFHczZnWTNwRTZZYmxROHcyT2dWajhMU2FqRnhhWnMybk4z?=
 =?utf-8?B?YUt6ZkVtVlBoa3c3SlQ5QUJpLyt2ZHhweWE0ak5WYkt3M0RDUk9jd2ZydUVi?=
 =?utf-8?B?NC83bVBSU2k0WkdMQXg4ZW5neHVuV2MvUjFWdDVuOXgrK1VtMWxRVis3c3Iz?=
 =?utf-8?B?bVRjc0xoZ2l6a1AyVEhUbFdYMmt2RjBGUm13S2trVUlBdDFoWU9VNlY5dHZ4?=
 =?utf-8?B?R0ZHTGdqK2VBeXc4blZuNXlmdXdBZ1pQemU4U2R0cUY2SzFzV0d1L3NCclE0?=
 =?utf-8?B?N29JVHRIZGtWbitKVmxTTllBcXk1Y0NzdmthNUFVTlBlNTdCRHNCZ2UrMTFm?=
 =?utf-8?B?eFlkRCs0RllnRzFKZmhqMEpCYlJMa08ya2FwdGRkOHhTdDdWdnFFaXU4b1Fy?=
 =?utf-8?B?QXJiRkpOeHNiRFdTSktYdGQ1Ukk3Y1A0U2pjUVlXS1crQngwcnVpMk9kN1c1?=
 =?utf-8?B?NkJBazZ3QUNCUDJQZHhXVFc0ak9CNUJQM0FXcDQ1cnBaV1M2bWVhZTh4WW96?=
 =?utf-8?B?ekhXU1ZHK0w3YjRQNXdxMWw5UTRNNTg0UVp1ajVvU3RPRXdZUGc1eEw2bm1T?=
 =?utf-8?B?MG5HcmVOMmUvZklMWFNhQVFCaytLZmpaNFZHcFVSdTRySXJaN0RFNzRvYUJv?=
 =?utf-8?B?R0xxaldoclFkS05TOTh1NmlQd1NVdXFzZXBsRDJlZFFrd093OGg4U1RDaU9z?=
 =?utf-8?B?VWhGT1I4UGpSQ0xIVGtPNVNlNHU1dTljRFhjSWE1SCtBVFhON2xVd3czTS9O?=
 =?utf-8?B?VmFoa0NLS1B6dVFjWEtMSFlxWjFKNGdHa01YRmxBb1ZaQ1Y2bUxhUjR6VTdm?=
 =?utf-8?B?bXc5MWRjVVFMN3BNaEtxRHlXa1J0TVhsUjVTOVJROGJtS0NZSmdGOUlBdUpt?=
 =?utf-8?B?aHU4ZitSNHR1V0c5b1hjOW11b1BmeGI1dFEvUHdhYVNVTE1hdTBKcFczS1NV?=
 =?utf-8?B?Wi9UbmVwUFlFYnhKR0xLQlh3d0Qvc1Q1K1U1SkhwQjhnRmpaQ2U0ODh3VnQy?=
 =?utf-8?B?NlpkK3IvdVVwYW1xS1lKU25YN2YzQTgxZkQvbWs3SFlpWmdYOVIxTGluQlRz?=
 =?utf-8?B?WWN1MzJKWG92M2NodXlkdnZtNjNIU0V0WVBFSUQrd2hJcVMreFp2K0FQaUp5?=
 =?utf-8?B?eUdxbEk1QkNmT1FEQXNCRmdnVWdGU0xaVEdUQWpCU05sc0ZSajlKY1krS2VC?=
 =?utf-8?B?NEk3WGN5SkRzaXpQcUlVeG84YUNRRkpYc2lnQVBFenlJZG9UUldMQlBFWDVx?=
 =?utf-8?B?R0JNNTFBNkMwWTlUaVlzaGp2NlBCelRpSERiM0xWY1FjejFWampJQWJDZC9l?=
 =?utf-8?B?OGV0TTF0NHBKVzJRcWsxN21sUldJMndnN0V3QkYzNUc5Y0tTMGRCYkVNZzlE?=
 =?utf-8?B?d1JrNEtPRUZ5TFJnMW9tbjF1SmF5Q1dHWkFlcWxmVnpsUkFKVkNTNG04dkph?=
 =?utf-8?B?UXpkcnVkQnhXZlBXcnhZT01OcytlOEV6ZGpJSG9WeEd2ZUlJMUFFN3hLZmx3?=
 =?utf-8?B?VmxIb0dHMGdSUzFtS0pmVzlEVTFKYlN4MEFsNis2TnBlZVlJMGtHS3hTY1Uv?=
 =?utf-8?B?bzc2Y0tPcnp0TlhmQzFaL1lnTTRpUUVFVWNpcHpxNVJ4QVQvNmNYMGtHdE9p?=
 =?utf-8?B?azg0dHJNdFZOeHk2dzAvQlROdW9KZThPdE9SSCtLZ0R3R3A5TDN0Z2k5UUNN?=
 =?utf-8?B?NEh1MGV0ZDQ2dGdkSEszd2RmSGQ5bDk4M013L3VVR0dLeStFelo3VE9hcEtV?=
 =?utf-8?B?SHVScGo5TVdWTVFTY2ZwWklxc09aZjVhckxYUlRjTjJYNEErTkZJUTBSSkRV?=
 =?utf-8?B?cXArYy9jYlhKUFJzWVFna2JVYTlNTFlPK3pYclM1R0RzVDRBTkN4cEVqOHBI?=
 =?utf-8?B?Z0VjSFZ0dXJlaDdzdVdXbG1JM1UwWWNzZFhXMnZaZHBOdlVPRzQxcDk5Mmtk?=
 =?utf-8?B?bVRiZFNJZ2NzRzB0NkFwNHpGVG9wMWxUQWVXKzZFTTBFMUI0MVhMNkJsSTB2?=
 =?utf-8?Q?Xz2wQ8KAFscMntaY=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A56305DE46B4FA41B93712FEEBF87A9F@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b706ecb-a3ba-4dca-e195-08da2470c44f
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 14:59:57.4384
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dsllur06aGFnC6r77B1ux4DfSWepgjblpSNDv3dPu+sihqRuQJ+8LgnyNgFfF8rlTSyWpwNfSDKDUpChTk248C9+iVbXW6yN8kk/fXBlqhw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2400

T24gMjIvMDQvMjAyMiAxNTo1NSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gT24gMjIuMDQuMjIg
MTY6NTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyMC8wNC8yMDIyIDA4OjMxLCBKdWVy
Z2VuIEdyb3NzIHdyb3RlOg0KPj4+IFNldHRpbmcgZXJybm8gdG8gYSBuZWdhdGl2ZSB2YWx1ZSBt
YWtlcyBubyBzZW5zZS4NCj4+DQo+PiBGaXhlczogZTc4ZThiOWJiNjQ5Yg0KPj4NCj4+PiBTaWdu
ZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+Pg0KPj4gQWNrZWQt
Ynk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+DQo+IERvIHlv
dSB3YW50IG1lIHRvIHNlbmQgdGhlIHBhdGNoZXMgd2l0aCB0aGUgRml4ZXMgdGFncyBhZGRlZD8N
Cj4NCj4gVEJIIEkgZGlkbid0IGJvdGhlciB0byBkbyB0aGUgcmVzZWFyY2ggZm9yIHRob3NlLCBh
cyB0aGUgd3JvbmcgdmFsdWVzDQo+IGRvbid0IHNlZW0gdG8gY2F1c2UgYW55IGhhcm0gdG9kYXku
IEkganVzdCBzdHVtYmxlZCBvdmVyIHRoZSBpc3N1ZXMNCj4gYW5kIHRob3VnaHQgaXQgd291bGQg
YmUgYSBnb29kIGlkZWEgdG8gZml4IHRob3NlLg0KDQpHaXZlbiB0aGF0IHRoZXJlJ3Mgbm90aGlu
ZyBlbHNlIHRvIGFkanVzdCwgSSB3YXMgdGhpbmtpbmcgb2YganVzdCBmaXhpbmcNCnRoZW0gb24g
Y29tbWl0Lg0KDQpCdXQgd2Ugc2hvdWxkIGJhY2twb3J0IHRoZXNlIHRvIGFsbCBhcHByb3ByaWF0
ZSByZWxlYXNlcyAoY2MgSmFuKS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 15:36:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 15:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311053.528045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvKR-0008Pd-3x; Fri, 22 Apr 2022 15:36:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311053.528045; Fri, 22 Apr 2022 15:36:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvKR-0008PW-0L; Fri, 22 Apr 2022 15:36:15 +0000
Received: by outflank-mailman (input) for mailman id 311053;
 Fri, 22 Apr 2022 15:36:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9oV9=VA=gmail.com=d.vrabel.98@srs-se1.protection.inumbo.net>)
 id 1nhvKP-0008PQ-PS
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 15:36:13 +0000
Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com
 [2a00:1450:4864:20::42f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id efcbd4da-c251-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 17:36:11 +0200 (CEST)
Received: by mail-wr1-x42f.google.com with SMTP id h25so5569121wrc.13
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 08:36:11 -0700 (PDT)
Received: from banana.davidvrabel.org.uk (banana.davidvrabel.org.uk.
 [82.70.146.42]) by smtp.googlemail.com with ESMTPSA id
 m21-20020a05600c3b1500b003928f20b7besm1829096wms.42.2022.04.22.08.36.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Apr 2022 08:36:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: efcbd4da-c251-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=sender:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=FHYrzSvh6xDWNNAItKaBBuh/jI95qz9hOrlWNTaNwg0=;
        b=MRqaI3YjIVqk4qTKuNsJwDtZ34tiQNTkbdDDZJXccGvWclxDCJmzV0/eKWGtXDUVku
         slpCBYJr6NaD2UIFecon65GJT95LHTBx95VgqntwHWkttOWxbz5rSqDPzVNc51EJUo3L
         07UTbRCyJYc5hoBrz9N5IV7PjbSlu4tU2W5G+mMsEFWMITYTIngrFK60ueolqHGwYtYO
         ZbT6gfzf++Y6higrXp3GpVn7LiBZqzhgxT5+riYdb4loRd07ZDlW637siZdG/PFfHwwB
         C1/zOIgMnL7sl0wptHUePVEuImz11Ac5mVIFoxFgPuYB5X1zd40jL0lV0NXohLCmSIWv
         PF2A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
         :mime-version:content-transfer-encoding;
        bh=FHYrzSvh6xDWNNAItKaBBuh/jI95qz9hOrlWNTaNwg0=;
        b=2vBnuX5Tm2A7v06Q823NPQ+FKr5uNV2r5PJ0puQBjHKxhIwhKeUNzIWfeoraRxZCo6
         ydZrFVWWfIYvgCv4iAvY1Pi5ydvOi7ZMncRri/vv7g1EwjsBfdlUPNV6OnZ7n6A6CO29
         Hl64nvyH9EtaNIbe9bVisvZtoWa7IwmZ2+sIGJ4hhBzYqv2SUyw2RPaM/Haxux1e6JaT
         0+75WOxxRvzc8F/b/4Ps/xpjWD8wZgWFsahW/7CkcQdiujFUGjxpyiV9wgB78fzr1l53
         D/RKH2hDiegwH7Xt6PFwgbMBYIaa5efhii8PRJEvvZ9CXjL/3raQRJa8JKl4KPCeUblA
         mbqw==
X-Gm-Message-State: AOAM530zxfKZtPRbkk2FRhRuL4UY5oZjMHtXhSa8us2H7lM5ocqUeBEl
	e03TdqqBmm/RJ/OUcKSN9UyDtWN7xmuFFNqq
X-Google-Smtp-Source: ABdhPJyR6RwA1Ot8vLJYrOt6/ft0LIUL9nRnFY2FQfgrwndD84Woc/irIbYYI44b4ZOq2SjkGG2UkQ==
X-Received: by 2002:adf:e60a:0:b0:20a:c402:6810 with SMTP id p10-20020adfe60a000000b0020ac4026810mr4380911wrm.45.1650641770811;
        Fri, 22 Apr 2022 08:36:10 -0700 (PDT)
Sender: David Vrabel <d.vrabel.98@gmail.com>
From: David Vrabel <dvrabel@cantab.net>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	David Vrabel <dvrabel@amazon.co.uk>
Subject: [PATCH v3] page_alloc: assert IRQs are enabled in heap alloc/free
Date: Fri, 22 Apr 2022 16:36:01 +0100
Message-Id: <20220422153601.967318-1-dvrabel@cantab.net>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: David Vrabel <dvrabel@amazon.co.uk>

Heap pages can only be safely allocated and freed with interuupts
enabled as they may require a TLB flush which will send IPIs.

Normally spinlock debugging would catch calls from the incorrect
context, but not from stop_machine_run() action functions as these are
called with spin lock debugging disabled.

Enhance the assertions in alloc_xenheap_pages() and
alloc_domheap_pages() to check interrupts are enabled. For consistency
the same asserts are used when freeing heap pages.

As an exception, when only 1 PCPU is online, allocations are permitted
with interrupts disabled as any TLB flushes would be local only. This
is necessary during early boot.

Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
---
Changes in v3:
- Use num_online_cpus() in assert.

Changes in v2:
- Set SYS_STATE_smp_boot on arm.
---
 xen/common/page_alloc.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..516ffa2a97 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -162,6 +162,13 @@
 static char __initdata opt_badpage[100] = "";
 string_param("badpage", opt_badpage);
 
+/*
+ * Heap allocations may need TLB flushes which require IRQs to be
+ * enabled (except during early boot when only 1 PCPU is online).
+ */
+#define ASSERT_ALLOC_CONTEXT() \
+    ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() == 1))
+
 /*
  * no-bootscrub -> Free pages are not zeroed during boot.
  */
@@ -2160,7 +2167,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 {
     struct page_info *pg;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     pg = alloc_heap_pages(MEMZONE_XEN, MEMZONE_XEN,
                           order, memflags | MEMF_no_scrub, NULL);
@@ -2173,7 +2180,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 
 void free_xenheap_pages(void *v, unsigned int order)
 {
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( v == NULL )
         return;
@@ -2202,7 +2209,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
     struct page_info *pg;
     unsigned int i;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( xenheap_bits && (memflags >> _MEMF_bits) > xenheap_bits )
         memflags &= ~MEMF_bits(~0U);
@@ -2224,7 +2231,7 @@ void free_xenheap_pages(void *v, unsigned int order)
     struct page_info *pg;
     unsigned int i;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( v == NULL )
         return;
@@ -2249,7 +2256,7 @@ void init_domheap_pages(paddr_t ps, paddr_t pe)
 {
     mfn_t smfn, emfn;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     smfn = maddr_to_mfn(round_pgup(ps));
     emfn = maddr_to_mfn(round_pgdown(pe));
@@ -2369,7 +2376,7 @@ struct page_info *alloc_domheap_pages(
     unsigned int bits = memflags >> _MEMF_bits, zone_hi = NR_ZONES - 1;
     unsigned int dma_zone;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
                                       bits ? : (BITS_PER_LONG+PAGE_SHIFT));
@@ -2419,7 +2426,7 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
     unsigned int i;
     bool drop_dom_ref;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( unlikely(is_xen_heap_page(pg)) )
     {
@@ -2738,7 +2745,7 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
 {
     struct page_info *pg;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     pg = acquire_staticmem_pages(smfn, nr_mfns, memflags);
     if ( !pg )
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 15:37:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 15:37:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311058.528055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvLl-0000aS-IH; Fri, 22 Apr 2022 15:37:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311058.528055; Fri, 22 Apr 2022 15:37:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvLl-0000aL-FW; Fri, 22 Apr 2022 15:37:37 +0000
Received: by outflank-mailman (input) for mailman id 311058;
 Fri, 22 Apr 2022 15:37:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvLj-0000a4-O4; Fri, 22 Apr 2022 15:37:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvLj-0004Ny-ME; Fri, 22 Apr 2022 15:37:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvLj-0003ED-Ey; Fri, 22 Apr 2022 15:37:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvLj-0001Td-EZ; Fri, 22 Apr 2022 15:37:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NOaB++AzjJWeO7fD/1laopMdD6cz4ite9mWnjepycXU=; b=ET669CHR/gviJAaLsGxmEQflma
	Q8lzOTli5EbE+Ihe8OCnbnZCs8IcvVKwzv1YpkxIxI2dDZdGnybgKx52XT0XEzcPhB5OPkyo4JJ2r
	lc8eE9ZUnkLXFiKPCccs/C3dLp4km2zbN4K0drhgaWud07i493O5KfMsdawudqGgjC78=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169625-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169625: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=f4dfec6ca1ef4354307b8ca8005affe17fc64360
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 15:37:35 +0000

flight 169625 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169625/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 f4dfec6ca1ef4354307b8ca8005affe17fc64360
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  556 attempts
Testing same since   169625  2022-04-22 14:11:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5655 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 15:46:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 15:46:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311066.528066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvUg-0002LV-GU; Fri, 22 Apr 2022 15:46:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311066.528066; Fri, 22 Apr 2022 15:46:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvUg-0002LO-DT; Fri, 22 Apr 2022 15:46:50 +0000
Received: by outflank-mailman (input) for mailman id 311066;
 Fri, 22 Apr 2022 15:46:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvUe-0002LE-I9; Fri, 22 Apr 2022 15:46:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvUe-0004YY-Fe; Fri, 22 Apr 2022 15:46:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvUe-0003r5-2l; Fri, 22 Apr 2022 15:46:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvUe-00044S-2L; Fri, 22 Apr 2022 15:46:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0XAnDCUP5YyW54s7ERx6PHKnIimbSmME5e5LL9Dcy1k=; b=MeHjyZMQL4mmAnS28F927Tdodw
	gtkTpqkV4d82mOMKnSgxM6LUM3GT1bXT7TtUv5VeW0dZuyRYTh+eW7ly03wWWeNYdoWXbTZoqnjVQ
	58RO4G8ffryb4nq9grp6OtVU2pyN1129JvOROtCE5+YNwk+4qghqYxFkDFX/8lbcH6PA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169609-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169609: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b05a5683eba6e2d40eadd5eeef53c4864149a4fe
X-Osstest-Versions-That:
    linux=59f0c2447e2553b0918b4a9fd38763a5c0587d02
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 15:46:48 +0000

flight 169609 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169609/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169601

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169601
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169601
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169601
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169601
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169601
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169601
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169601
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169601
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                b05a5683eba6e2d40eadd5eeef53c4864149a4fe
baseline version:
 linux                59f0c2447e2553b0918b4a9fd38763a5c0587d02

Last test of basis   169601  2022-04-21 21:40:01 Z    0 days
Testing same since   169609  2022-04-22 03:12:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bernice Zhang <bernice.zhang@intel.com>
  Dave Jiang <dave.jiang@intel.com>
  Herve Codina <herve.codina@bootlin.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Kevin Groeneveld <kgroeneveld@lenbrook.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Miaoqian Lin <linmq006@gmail.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Tony Zhu <tony.zhu@intel.com>
  Vinod Koul <vkoul@kernel.org>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>
  Zhang Qilong <zhangqilong3@huawei.com>
  zhangqilong <zhangqilong3@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   59f0c2447e25..b05a5683eba6  b05a5683eba6e2d40eadd5eeef53c4864149a4fe -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 15:48:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 15:48:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311073.528078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvWV-0002vG-Sd; Fri, 22 Apr 2022 15:48:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311073.528078; Fri, 22 Apr 2022 15:48:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvWV-0002v9-Pb; Fri, 22 Apr 2022 15:48:43 +0000
Received: by outflank-mailman (input) for mailman id 311073;
 Fri, 22 Apr 2022 15:48:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QJ8Z=VA=citrix.com=prvs=1040bc4e0=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nhvWT-0002v1-V5
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 15:48:42 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac80203a-c253-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 17:48:39 +0200 (CEST)
Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 11:48:35 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by PH0PR03MB6512.namprd03.prod.outlook.com (2603:10b6:510:be::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr
 2022 15:48:32 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022
 15:48:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac80203a-c253-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650642519;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fMwHEW/+JGqk/dqMyB+HGMMvFjIOrVKhp13aUjBXZyw=;
  b=JQDG/M3NJ0Hgilq2Uerllm1ultDbTt7FEnpHan/riviRnoTL+CiG5jpv
   wkwV8CCj4+COjfQMT2vurZJ8YEBdjd9LmZ7xWKfAl+sxmEGGk9bXW66Pq
   amcn8UTgp4aQTaYEnMi+VCSI5+FiFVdN4vnvrlyL3drjVT/4jSvL8wsr5
   c=;
X-IronPort-RemoteIP: 104.47.55.103
X-IronPort-MID: 69592658
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:KOleaarmHQG6Hj26JYRqFdBrf2ZeBmIfZBIvgKrLsJaIsI4StFCzt
 garIBmAPvzfZmLxL95yaIWw9UlS6sKEyddnTlZp/y5kE39A85uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 4mq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBYofxmv0jAzdhCQ5UZPUcpueaPmmnmJnGp6HGWyOEL/RGKmgTZNVd39ktRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFgXFp3psm8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrL9PdmuTaOnGSd1pDqPcTXfICWH/lS3U+Uj
 DvKzmHFIzMVYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiGGAlg4RXZxXCeJSwAOC0K3P+C6CG3MJCDVGbbQbWNQeQDUr0
 hqMgInvDDk26LmNEyvFrfGTsC+4PjUTISkafygYQAAZ4t7l5oYukhbISdUlG6mw5jHoJQzNL
 /mxhHBWr90uYQQjjc1XIXivb+qQm6X0
IronPort-HdrOrdr: A9a23:FcVUD66o5KFaBo5x9wPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN
 MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt
 gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd
 L6IRlliVI=
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="69592658"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xnjq0KEDHHPmMmvI3AwUY9vLB/9qWqKfz6b1avEweEeeXbBbFTqc8JQnY8lMyr3eqlsYq9d8lIpoc3IFWc8oyp47HPSV+jR4Oky77TSB7DKNigmk2gavPyZfQOYWT+Yb7ONyqVeHqVL2WMoF2b4LxDnYHyNfQW6Ggrl1nLMPeO/rTXVrIC8//cbyXvSPC0UuF0UFxAem9i3PbXoG0SIGkBhRITG37ZPOb2x8tguh22ZXK3/0dTNDGtVkl4uhnmKyxbb5mUqV0Tbf10Ydj3wG6IC7LgzE3mkfE5CrjoNgfzvZmQchIi8u8T/T4TjpnOptUzEHrPLfPwrux/TqadFT6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sd/I353whyT6eDqonLgykwRUjWz+3qq0b6Tk9+xDv7g=;
 b=HzLUTbuzaVivMW/3rDlHo4aRhdNyQ3b605VpxsHpHRI3WbkZJi0k/rfPnCKWw/bYsHiiPgz6M0t5xMqWB/H4CfNecGoiIeoHnqHRWhaDAJsyhtC3i0QnbPgKGEUlgNeaWJwJJfM88jlsBQI/bxElHvdiuZ8WtKa3bzv8IXQ6pJKIieSFueEFsw5aNJPeAJ1zpchd2/V5qcU8Y7w91mToneaf5I36+0YIEnheT+beZFTJ5BuoUZ9NAevncK9xqKejtUwVUdDwJ6QaYGdcsyDQMtej2W397Wqodpl3EO72Kz+qqMnvkrUxBhntLjLbdp6BoPHoh4IUivlgS7jjjGaxiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sd/I353whyT6eDqonLgykwRUjWz+3qq0b6Tk9+xDv7g=;
 b=J3BOKNJWU42uuz5+97zZ5HZuXCoPA9nQdF4T5ulwjPXkfaS+ko2qvtBThW9sHgP5FRmmIvCIh5fSud83UPfyBoNOY5D5EiBR9PDoPfdT3nyDQhDqEawLtneXHoG9otgulW47BYMa21eLXy8m95c75lglyHCwwNMnx2viZm9BpLU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 22 Apr 2022 17:48:27 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH RFC] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Message-ID: <YmLOS+fKRxQ9BXc2@Air-de-Roger>
References: <c5844665-8ed7-d91f-a41c-9e4eb3e2bcc2@suse.com>
 <YmKOMC1TcQQUB6Lx@Air-de-Roger>
 <65e4428d-f89b-88c6-885c-7c0347e52861@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <65e4428d-f89b-88c6-885c-7c0347e52861@suse.com>
X-ClientProxiedBy: MR1P264CA0091.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::28) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 74626e11-5e4e-4ac5-170a-08da24778db5
X-MS-TrafficTypeDiagnostic: PH0PR03MB6512:EE_
X-Microsoft-Antispam-PRVS:
	<PH0PR03MB651234268095CC34A0C4E3CD8FF79@PH0PR03MB6512.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xqA31e1Vk3kOFZL7KLB0c/iXxmyem1+H/eFy7lnCbyVmgz0Al6xKTs4MMqHJ6UmjUSm7cAGlv4B0TPFpL5+BhRLPr9TsnAyGMS+DxkJZHXRce49p9o/JjB+0f/P3z+hQnnDXtj4D6KgEh2wbIUMyzOYISQdHVtY07hIFPAc2+U9KQ/aMwkxJ9vsiMIIpPfGhSvj9AvxeTVZzedJ8NDcbqg1MFE0E3KumBnj7bBGON+qCD6lvy15Z1y5y8vYM7YVR9gc8JFCwwhFW8IdWkSew63SSaOx79w05j+vJ385nZqnrvTgEBaOB06+1DGDig57lpi4qiZIqRHfB+xjzl5334dRnV4hj1NhuQ65dmMKlk063YMbjOulonHDiC641CXhIYU92jOG1II8cqX9gON5ZTjtpLvndcrxB+JyChyAVKtUeOF3Y+Xlr4ZrM23reCjpVlK0M67LaQ9vEVAo7dxne1rmD7lTgo4hJDeGDIgrX+8VZvo8Di8wI1b8ZCMi98fz6o5oG5EWWBt3PoACXlDi5uoSn0/vcVIPrk+HUmZkyQIT/ZJbLpwdWzmIDpR7JF75XPo4c8qMdM8+jOll0ykFwkgT+6PEw1s4/neWoAPS6/LyKccJes2rI0RrBwy1bF1Di/AjILQOdaxB7/kCjE/hzzwoqRcgpX1HCfqjbdJhHPzNJe7ARmbU5C+siqGnrhxlpcThxpoBq9e0PICOiHHvhJw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(316002)(2906002)(186003)(53546011)(54906003)(85182001)(83380400001)(6486002)(508600001)(6916009)(38100700002)(6666004)(6506007)(4326008)(8676002)(33716001)(9686003)(6512007)(26005)(8936002)(86362001)(5660300002)(66556008)(66476007)(82960400001)(66946007)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Nnk2SXpmT2FFT0VjQ3BvbHVWTzVxVHhycjR5eWZkdGVJUGVYZjZCV1A5aUJQ?=
 =?utf-8?B?QVlMeVR6T0gybG8xZnoxcHo4Y052Ly9JWmdyNlhFMGxsdmliQW12TDVqSGky?=
 =?utf-8?B?RVhERWhiQVBBVzhNZklDM2Fha3JOTWQ5eVRNSXlOQ1MwQVJlZ1hycmU4eExm?=
 =?utf-8?B?anNlQnpqMzJwVjFMZkQ3M2RTSEFxM09OVVFUT1Z1Mkk2RVR5b2JkR1NlNk1p?=
 =?utf-8?B?QU1LMnI4U2dvUzA1azVBa1ZERW5IUklBVm5MK3NJUVFhOWxOY0t6VnpwSlNo?=
 =?utf-8?B?a01VRFEySk51MG5SaUxZYXJXY08xUjZIN3lwcjdVeUFuVnhrMXVZZDh2VEZ1?=
 =?utf-8?B?Tkp5cTRJdm04UHZVdkMrUlR1SDdXZWM0dHdFaHZEWnEzRkxQVS9HMnpSVVFF?=
 =?utf-8?B?R3FUVStRVDdBSUY0M1N5UXROVWZsNC95U2FsQmpEeFB4bHBiVERIcUs3MnJW?=
 =?utf-8?B?Zmd5d25SQWNST01STDBSSXpZTFViMjNQQmNveTh2ZUlnUEcxWVBVaTRuYksz?=
 =?utf-8?B?T21razRmYWJ0Tk1tYUp6V1lVYnpHaHpuemwwMnA2Vmo2Vk1PUFdXM1lHM0tH?=
 =?utf-8?B?WW1KTmZxd1hDUlBQZlkwVm1kd21xY29URnd4eVVhVFNnVmtxVElZalcrU1da?=
 =?utf-8?B?cGJSLy9oV1J2MEhtVW40Ni9UcmUzMWp4Q1E4VEwrQXV1Y0tTTzRXT0VwSzUr?=
 =?utf-8?B?REQ5cEFML1pObk5qdlhHVG5mTkZJaTRvcXpFdFAxTnNWMmtQN1ZWN3M0bWRh?=
 =?utf-8?B?NkVHeDRzTlJhRjFJRlRFL1o2WE1remh5OFB5UG0wWHdWQVZkUGNjZEt6cy9m?=
 =?utf-8?B?NmhVNUR3UnBLaFFLOUt0UlZzb2QydXhtRkR3NTEybDFVQ2RJNnpYRGovcnRK?=
 =?utf-8?B?dVI4RUZMOURwcGJCVUpYSGFOOEQzNGt3NllKcG5yQk9vSE5NNjVqRUYxNWtn?=
 =?utf-8?B?N0gyNExqUml4Q0h0c0YySUEvOFppdTQ3QjBBUWdtNjZkQXVZdEh6WmlJejhP?=
 =?utf-8?B?WEQzSk9pbTdmZlZvaWwycUhudDlCZWV0ZDkvQWFjSVhmT3RHRmUyTGFEUUlK?=
 =?utf-8?B?WUNhM1JTZkR6YnQ0MG51aWRSZFhYMnJwVDZ6MklUdUhJTjd1UWcwajJHL09Z?=
 =?utf-8?B?VlFRa0xFYmJMZDJYL0I2NURKTEZSUnZvYmJWNmFxdCt5bFkwOEowSTVzTkZi?=
 =?utf-8?B?V2lUelFrckRtQ0FPUGFrVzMveElnQ09tbTFGQ1A2QWhvWmc1VFhoZGs5V3Nq?=
 =?utf-8?B?YVh6LzBrTHNJcWJhS3QyMVFkTWx4Lys3K3lKcXREa2htTXgyYVpXU1c5VjAv?=
 =?utf-8?B?aXhWcFhSZHg0bjVKbW1mYW53OEUzZGQybHhqbG83eHR3ZDc4YUVyRVA3bW5r?=
 =?utf-8?B?Vm5PcDduTGRDclplc3Rodi94d0ZycHp0ditBbG9uTi9hTVl6TGc2N29vRGJP?=
 =?utf-8?B?WFRQZ1pHUnhuU2k0VU51UldGbEp2NElEOG9POXZWc2kwQ2I4RnkzNnZuT1VZ?=
 =?utf-8?B?RlRLcUpZQ3BQajI5UDlzN3ZzbnNva3pQK2k4Mm1Gemd2dHJ3aG43SFRMSlho?=
 =?utf-8?B?OEYyT0lVU1Qzd3NaalU3cEZ6bW5ZZU0xWnJseURSbi9qdTVhbWhQZ0dVYUlG?=
 =?utf-8?B?ZExRZE9zVHZqK2xuNXhZT1lJRlIwZHYzdEhqcXd3UWJzSXdGNWlKQTZSdXA3?=
 =?utf-8?B?NytyVU55WElsQnVYNDRHNTdwSk9VczF4elFJanp5Z3dOUXNjRmYrdFd6Mitq?=
 =?utf-8?B?UjlqMjlnT21UTExnT05ramFrcVB4VzltNnNPT0FpZ0RWV0JCbjdkUXByQm0z?=
 =?utf-8?B?TnFzWm1meUFpNEFlZjRKVTNTa3BrMWtTSnVkb0RLMHAzL2RnMHBMR1NheXhn?=
 =?utf-8?B?c28xZjlqU3Z2NU82bW9CTVhqZXBWcFNKNTZGbklhQ1h1dVhjRzh2NmhZb2dw?=
 =?utf-8?B?NHJaclJFMmRBc1ZmdHBGc1F6Z1JIMWRveC9zWDZ2Rm9vSlNBQ3ExY1BGM242?=
 =?utf-8?B?anBrNmM0YXF4S3N4dUIxWjJvWVdLU25UbnVISEVFT3FEcS9pTWwyUXRsbU5Y?=
 =?utf-8?B?UzVQN0puWEI5SkRCMGtrSVZoY045aXZDRmRKWSsxYlRBVk16VFFadjhaQmZF?=
 =?utf-8?B?U0VubUJmN1RvWlF1UEM4WWR2b2dZUFU4OWw4emE3b2NrWWtKT2RORmx3bnZO?=
 =?utf-8?B?RVhRUmgvRlBTNG1ZSkd0ZG4yREM0ejRkVDMyaXJnY0tON3FzRXRtKy9XaFRW?=
 =?utf-8?B?Q0RIbkFHOVpjT2pLSWZQbW5mVFE3N2NHSlZhZDFuY0d3OWlXMXpUTGUrNEJv?=
 =?utf-8?B?SmhlTm1vQUpTZHoxSjJObzdWYzYxeTZpYnd4K2gwNzJoRjhhd2Fadz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74626e11-5e4e-4ac5-170a-08da24778db5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 15:48:32.6478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OtljbZ9xLc383py6aBSBL+qMH44/CN/DcHrxaBJJLY8++zKItgLojnJBivMDYMsWiRvkKThoHp/v/3ZTzLM6UA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6512

On Fri, Apr 22, 2022 at 01:56:17PM +0200, Jan Beulich wrote:
> On 22.04.2022 13:14, Roger Pau Monné wrote:
> > On Fri, Apr 22, 2022 at 12:57:03PM +0200, Jan Beulich wrote:
> >> The reference "to shadow the resident processes" is applicable to
> >> domains (potentially) running in shadow mode only. Adjust the
> >> calculations accordingly.
> >>
> >> In dom0_paging_pages() also take the opportunity and stop open-coding
> >> DIV_ROUND_UP().
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> RFC: I'm pretty sure I can't change a public libxl function (deprecated
> >>      or not) like this, but I also don't know how I should go about
> >>      doing so (short of introducing a brand new function and leaving the
> >>      existing one broken).
> > 
> > You have to play with LIBXL_API_VERSION, see for example:
> > 
> > 1e3304005e libxl: Make libxl_retrieve_domain_configuration async
> > 
> >>
> >> --- a/tools/include/libxl_utils.h
> >> +++ b/tools/include/libxl_utils.h
> >> @@ -23,7 +23,10 @@ const
> >>  #endif
> >>  char *libxl_basename(const char *name); /* returns string from strdup */
> >>  
> >> -unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb, unsigned int smp_cpus);
> >> +unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb,
> >> +                                               unsigned int smp_cpus,
> >> +                                               libxl_domain_type type,
> >> +                                               bool hap);
> > 
> > Iff we are to change this anyway, we might as well rename the
> > function and introduce a proper
> > libxl_get_required_{paging,p2m}_memory?
> > 
> > It seems wrong to have a function explicitly named 'shadow' that takes
> > a 'hap' parameter.
> > 
> > If you introduce a new function there's no need to play with the
> > LIBXL_API_VERSION and you can just add a new LIBXL_HAVE_FOO define.
> 
> With the original function deprecated, I don't see why I'd need to
> make a new public function - my fallback plan was (as also suggested
> by Jürgen) to make a new internal function.

Yes, that would be fine if there's no need to expose the new function
for external callers.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 15:59:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 15:59:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311080.528088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvhI-0004j0-1P; Fri, 22 Apr 2022 15:59:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311080.528088; Fri, 22 Apr 2022 15:59:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhvhH-0004it-Ug; Fri, 22 Apr 2022 15:59:51 +0000
Received: by outflank-mailman (input) for mailman id 311080;
 Fri, 22 Apr 2022 15:59:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvhG-0004ij-ES; Fri, 22 Apr 2022 15:59:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvhG-0004lw-Bm; Fri, 22 Apr 2022 15:59:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvhF-0004PN-SV; Fri, 22 Apr 2022 15:59:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhvhF-0006NL-S5; Fri, 22 Apr 2022 15:59:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/4FxBBojOvizVL8GWK82DLzsZ9GMVrKykejFa+2Xdas=; b=i/j+zOYTex4l8Unoq4CNygVpVi
	y7H+Cc3yXGnPDEMhUwOnEArPS0pn4Nhnc4525nGonI3z4JX4xye8vkMP9dDvGgTXoUcsYK2l/Ii3E
	3n4bbGmydCwzOjDJvIaQDbNbjYRKIX7Ad8W4W+zqm1uTFoz7ZlMO4sbqrHxKER/3GWnM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169611-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169611: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=ea42cc69ccac69627dae65dc24ca8d8435af5706
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 15:59:49 +0000

flight 169611 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169611/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              ea42cc69ccac69627dae65dc24ca8d8435af5706
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  651 days
Failing since        151818  2020-07-11 04:18:52 Z  650 days  632 attempts
Testing same since   169611  2022-04-22 04:20:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 105061 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:35:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:35:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311089.528099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwFX-0001uh-P5; Fri, 22 Apr 2022 16:35:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311089.528099; Fri, 22 Apr 2022 16:35:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwFX-0001ua-ME; Fri, 22 Apr 2022 16:35:15 +0000
Received: by outflank-mailman (input) for mailman id 311089;
 Fri, 22 Apr 2022 16:35:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JQBp=VA=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhwFV-0001uU-VV
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:35:14 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2d330861-c25a-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 18:35:12 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 165064530579532.33830211828172;
 Fri, 22 Apr 2022 09:35:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d330861-c25a-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1650645307; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=bK8uyusoRSJV5H320EKGuHoz8gIx0Fd7V/1YuPBcZAhiPz3GDzQqpvFeFNwMmG5bCvAX5vGlOeL5I7Emiuxjn/uDQSl94pxwAL7LKPgO9biWgyHjEnK8UUyJz3+eI6I5+uSzobrgsSvnQAAqlM1hKjpz/7lxVbxPDd/Kcp1H2NA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650645307; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=JmUJd8m1+kH1LBV6rKljJnSt9maxgAY7fiPqIijmhQs=; 
	b=mvjiPdtyYITCcPzEvApk65R1T9Wg3FiapdmwzGsK/HDKiQkYzBfJH0mwUO4i/4xySZuWCxFGo42IiOVzf6m27Wt5OwvNz7quPOrqiDtwjjmZtmDc4JrYGXtGvnmH4QC+Rk29e14l6JiuJ6p5uLZT54bmsiiG/MBMd/n7T+UGbdY=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650645307;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=JmUJd8m1+kH1LBV6rKljJnSt9maxgAY7fiPqIijmhQs=;
	b=FK+/UeqpK2uc4EZAT5CnPWGmI5kivBzaq+RW+ZAFdXOU9PQxQGVNneWELIZXNGOk
	UnCiG2b8T8efp1fU5JmHvzt8t/CfIVe265U1/OvgnjRAxOJ6Qz7jj4RUWdISHFNlp9B
	nC2i/F9SdHpqyAl1LsOGQNSPoB+s8ka/pvAaArf8=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	scott.davis@starlab.io,
	jandryuk@gmail.com
Subject: [PATCH v3 0/2] Adds starting the idle domain privileged
Date: Fri, 22 Apr 2022 12:34:56 -0400
Message-Id: <20220422163458.30170-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This series makes it so that the idle domain is started privileged under the
default policy, which the SILO policy inherits, and under the flask policy. It
then introduces a new one-way XSM hook, xsm_transition_running, that is hooked
by an XSM policy to transition the idle domain to its running privilege level.

Changes in v3:
- renamed *_transition_running() to *_set_system_active()
- changed the XSM hook set_system_active() from void to int return
- added ASSERT check for the expected privilege level each XSM policy expected
- replaced a check against is_privileged in each arch with checking the return
  value from the call to xsm_set_system_active()

Changes in v2:
- renamed flask_domain_runtime_security() to flask_transition_running()
- added the missed assignment of self_sid

Daniel P. Smith (2):
  xsm: create idle domain privileged and demote after setup
  flask: implement xsm_set_system_active

 tools/flask/policy/modules/xen.if      |  6 ++++++
 tools/flask/policy/modules/xen.te      |  1 +
 tools/flask/policy/policy/initial_sids |  1 +
 xen/arch/arm/setup.c                   |  3 +++
 xen/arch/x86/setup.c                   |  3 +++
 xen/common/sched/core.c                |  7 ++++++-
 xen/include/xsm/dummy.h                | 17 +++++++++++++++
 xen/include/xsm/xsm.h                  |  6 ++++++
 xen/xsm/dummy.c                        |  1 +
 xen/xsm/flask/hooks.c                  | 29 +++++++++++++++++++++++++-
 xen/xsm/flask/policy/initial_sids      |  1 +
 11 files changed, 73 insertions(+), 2 deletions(-)

-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:35:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:35:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311090.528110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwFc-0002B4-0h; Fri, 22 Apr 2022 16:35:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311090.528110; Fri, 22 Apr 2022 16:35:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwFb-0002At-U7; Fri, 22 Apr 2022 16:35:19 +0000
Received: by outflank-mailman (input) for mailman id 311090;
 Fri, 22 Apr 2022 16:35:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JQBp=VA=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhwFa-0001uU-L6
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:35:18 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 30c786e5-c25a-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 18:35:17 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650645308059975.7777187133837;
 Fri, 22 Apr 2022 09:35:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30c786e5-c25a-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1650645309; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=Wi9eAHTruENQ2BlsCjVccyQsDV0ZKS4S1aL4JqYqM6Scc88jyrdCbz2FxjHiwHwkZtPAgJcNgn0tIiSqDhmunFS7o31gZAhlogtjuyWqn1h0G3qcRKewYTD0Z8VNyO9OSm13mXan6dSVa39d0tMrIHHQ+YuDufDt0Y3jpsFMd+0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650645309; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=2wRiekjzxthLjBV/DEn0NzrOAnSgS0vwehjI3eBZqCQ=; 
	b=GTE1Ktq4K9ZNItIEBcV695E3auAl3AxovU0Xd2W5k8Spk63yNzPKG4qF1fdnTl1+F9VHOS7FNmUgrvR3U0rG+WhmIUHUwySg5BexbYym25uaMQ5jsjp34BV4AYX6I440VI5f4DoTk+DP0fP5fPlsk9y5wVKxwdJsVce+PJ8w16U=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650645309;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=2wRiekjzxthLjBV/DEn0NzrOAnSgS0vwehjI3eBZqCQ=;
	b=Ry198MmZN4nkqDEvUe5YPzKm3fU/7J+igfaqBpS+rpDZGrr2f0ParuMRvHmG6eus
	GuqtQ9Pu2Ebo4vJGqGvCMZnirrgWs5C/Y8m5iKwRNH+q2zQWQ8gqz+IlBmjsayVMm81
	l9e067rQ40Qs0E/WjbrY7ZTs0qYaR2mnvMvtoMmw=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io,
	jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: [PATCH v3 1/2] xsm: create idle domain privileged and demote after setup
Date: Fri, 22 Apr 2022 12:34:57 -0400
Message-Id: <20220422163458.30170-2-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20220422163458.30170-1-dpsmith@apertussolutions.com>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

There are now instances where internal hypervisor logic needs to make resource
allocation calls that are protected by XSM checks. The internal hypervisor logic
is represented a number of system domains which by designed are represented by
non-privileged struct domain instances. To enable these logic blocks to
function correctly but in a controlled manner, this commit changes the idle
domain to be created as a privileged domain under the default policy, which is
inherited by the SILO policy, and demoted before transitioning to running. A
new XSM hook, xsm_set_system_active, is introduced to allow each XSM policy
type to demote the idle domain appropriately for that policy type.

For flask a stub is added to ensure that flask policy system will function
correctly with this patch until flask is extended with support for starting the
idle domain privileged and properly demoting it on the call to
xsm_set_system_active.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/arch/arm/setup.c    |  3 +++
 xen/arch/x86/setup.c    |  3 +++
 xen/common/sched/core.c |  7 ++++++-
 xen/include/xsm/dummy.h | 17 +++++++++++++++++
 xen/include/xsm/xsm.h   |  6 ++++++
 xen/xsm/dummy.c         |  1 +
 xen/xsm/flask/hooks.c   | 21 +++++++++++++++++++++
 7 files changed, 57 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..e71fa3f860 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset,
     /* Hide UART from DOM0 if we're using it */
     serial_endboot();
 
+    if ( xsm_set_system_active() != 0)
+        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
+
     system_state = SYS_STATE_active;
 
     for_each_domain( d )
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 6f20e17892..a3ce288ef9 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -621,6 +621,9 @@ static void noreturn init_done(void)
     void *va;
     unsigned long start, end;
 
+    if ( xsm_set_system_active() != 0)
+        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
+
     system_state = SYS_STATE_active;
 
     domain_unpause_by_systemcontroller(dom0);
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab678181..22a619e260 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
         sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
     }
 
-    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
+    /*
+     * idle dom is created privileged to ensure unrestricted access during
+     * setup and will be demoted by xsm_transition_running when setup is
+     * complete
+     */
+    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
     BUG_ON(IS_ERR(idle_domain));
     BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
     idle_domain->vcpu = idle_vcpu;
diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index 58afc1d589..3291fb5396 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -101,6 +101,23 @@ static always_inline int xsm_default_action(
     }
 }
 
+static XSM_INLINE int cf_check xsm_set_system_active(void)
+{
+    struct domain *d = current->domain;
+
+    ASSERT(d->is_privileged);
+
+    if ( d->domain_id != DOMID_IDLE )
+    {
+        printk("xsm_set_system_active: should only be called by idle domain\n");
+        return -EPERM;
+    }
+
+    d->is_privileged = false;
+
+    return 0;
+}
+
 static XSM_INLINE void cf_check xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
index 3e2b7fe3db..8dad03fd3d 100644
--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t;
  * !!! WARNING !!!
  */
 struct xsm_ops {
+    int (*set_system_active)(void);
     void (*security_domaininfo)(struct domain *d,
                                 struct xen_domctl_getdomaininfo *info);
     int (*domain_create)(struct domain *d, uint32_t ssidref);
@@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops;
 
 #ifndef XSM_NO_WRAPPERS
 
+static inline int xsm_set_system_active(void)
+{
+    return alternative_call(xsm_ops.set_system_active);
+}
+
 static inline void xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 8c044ef615..e6ffa948f7 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -14,6 +14,7 @@
 #include <xsm/dummy.h>
 
 static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
+    .set_system_active             = xsm_set_system_active,
     .security_domaininfo           = xsm_security_domaininfo,
     .domain_create                 = xsm_domain_create,
     .getdomaininfo                 = xsm_getdomaininfo,
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 0bf63ffa84..8a62de2fd6 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
     return 0;
 }
 
+static int cf_check flask_set_system_active(void)
+{
+    struct domain *d = current->domain;
+
+    if ( d->domain_id != DOMID_IDLE )
+    {
+        printk("xsm_set_system_active should only be called by idle domain\n");
+        return -EPERM;
+    }
+
+    /*
+     * While is_privileged has no significant meaning under flask, set to false
+     * as there are times in hypervisor code privilege checks check this
+     * directly instead of going through XSM.
+     */
+    d->is_privileged = false;
+
+    return 0;
+}
+
 static void cf_check flask_domain_free_security(struct domain *d)
 {
     struct domain_security_struct *dsec = d->ssid;
@@ -1766,6 +1786,7 @@ static int cf_check flask_argo_send(
 #endif
 
 static const struct xsm_ops __initconst_cf_clobber flask_ops = {
+    .set_system_active = flask_set_system_active,
     .security_domaininfo = flask_security_domaininfo,
     .domain_create = flask_domain_create,
     .getdomaininfo = flask_getdomaininfo,
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:35:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:35:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311092.528121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwFy-0002nc-EB; Fri, 22 Apr 2022 16:35:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311092.528121; Fri, 22 Apr 2022 16:35:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwFy-0002nV-Ar; Fri, 22 Apr 2022 16:35:42 +0000
Received: by outflank-mailman (input) for mailman id 311092;
 Fri, 22 Apr 2022 16:35:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JQBp=VA=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhwFx-0001uU-Kf
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:35:41 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e8b4b10-c25a-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 18:35:40 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 165064530941963.43325690543736;
 Fri, 22 Apr 2022 09:35:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e8b4b10-c25a-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1650645311; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=oLqbNKpiqPiNQ5j07LT6UG3ZTC//M5oxdfEs5UvLbxSlQjl/QmPGVn7x17J7YcZ4uYwXcgnKQ3QKCTcINEtX8br2nxFETxZmwPabqaRD2FoLpANavOsFjw2tBs5Zee/sawySkdIau4Rb6NUNedlCNksXDAiLszEgcoTlgoTr21Y=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650645311; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=dIZZxXRju0ki+6zOp/C2v1mFoGOokA/bwLqQioVO/ao=; 
	b=LNdTzGeBakQRjAxgPyWXmKoJV8W9NR7oFbczw3nyNXg8MNIR4HrC+wFVWzW62Pf4CWb2VnVM5L6mlglj9Dz9QqWc/Rdq8W6xWT/+F4X4z3DfCzVEyaM6E8eDhP02YSgBFqsFWBXhV2GU83uvOKtyk5z74CNMPmcqP87fT1CpwV8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650645311;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=dIZZxXRju0ki+6zOp/C2v1mFoGOokA/bwLqQioVO/ao=;
	b=DoZFpJylZ1DiowysRvd+6VMTpUxbM48G+WXVH6fPXb2hmGCRLqs3xfeT4qGFkY/5
	IIZ0H/zHXC76tko7sIK3c8UQev7+FoXp81Is5FqQV/8b+5SQ0hY1BDsnip8TD2mUBHf
	/VTmilRwLCwSLQKS94VgtcFckHUHeatJdnGJjliU=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io,
	jandryuk@gmail.com,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v3 2/2] flask: implement xsm_set_system_active
Date: Fri, 22 Apr 2022 12:34:58 -0400
Message-Id: <20220422163458.30170-3-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20220422163458.30170-1-dpsmith@apertussolutions.com>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit implements full support for starting the idle domain privileged by
introducing a new flask label xenboot_t which the idle domain is labeled with
at creation.  It then provides the implementation for the XSM hook
xsm_set_system_active to relabel the idle domain to the existing xen_t flask
label.

In the reference flask policy a new macro, xen_build_domain(target), is
introduced for creating policies for dom0less/hyperlaunch allowing the
hypervisor to create and assign the necessary resources for domain
construction.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 tools/flask/policy/modules/xen.if      | 6 ++++++
 tools/flask/policy/modules/xen.te      | 1 +
 tools/flask/policy/policy/initial_sids | 1 +
 xen/xsm/flask/hooks.c                  | 8 +++++++-
 xen/xsm/flask/policy/initial_sids      | 1 +
 5 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if
index 5e2aa472b6..4ec676fff1 100644
--- a/tools/flask/policy/modules/xen.if
+++ b/tools/flask/policy/modules/xen.if
@@ -62,6 +62,12 @@ define(`create_domain_common', `
 			setparam altp2mhvm altp2mhvm_op dm };
 ')
 
+# xen_build_domain(target)
+#   Allow a domain to be created at boot by the hypervisor
+define(`xen_build_domain', `
+	allow xenboot_t $1_channel:event create;
+')
+
 # create_domain(priv, target)
 #   Allow a domain to be created directly
 define(`create_domain', `
diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modules/xen.te
index 3dbf93d2b8..de98206fdd 100644
--- a/tools/flask/policy/modules/xen.te
+++ b/tools/flask/policy/modules/xen.te
@@ -24,6 +24,7 @@ attribute mls_priv;
 ################################################################################
 
 # The hypervisor itself
+type xenboot_t, xen_type, mls_priv;
 type xen_t, xen_type, mls_priv;
 
 # Domain 0
diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/policy/initial_sids
index 6b7b7eff21..ec729d3ba3 100644
--- a/tools/flask/policy/policy/initial_sids
+++ b/tools/flask/policy/policy/initial_sids
@@ -2,6 +2,7 @@
 # objects created before the policy is loaded or for objects that do not have a
 # label defined in some other manner.
 
+sid xenboot gen_context(system_u:system_r:xenboot_t,s0)
 sid xen gen_context(system_u:system_r:xen_t,s0)
 sid dom0 gen_context(system_u:system_r:dom0_t,s0)
 sid domxen gen_context(system_u:system_r:domxen_t,s0)
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 8a62de2fd6..4732ca4019 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
     switch ( d->domain_id )
     {
     case DOMID_IDLE:
-        dsec->sid = SECINITSID_XEN;
+        dsec->sid = SECINITSID_XENBOOT;
         break;
     case DOMID_XEN:
         dsec->sid = SECINITSID_DOMXEN;
@@ -188,8 +188,12 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
 
 static int cf_check flask_set_system_active(void)
 {
+    struct domain_security_struct *dsec;
     struct domain *d = current->domain;
 
+    dsec = d->ssid;
+    ASSERT( dsec->sid == SECINITSID_XENBOOT);
+
     if ( d->domain_id != DOMID_IDLE )
     {
         printk("xsm_set_system_active should only be called by idle domain\n");
@@ -203,6 +207,8 @@ static int cf_check flask_set_system_active(void)
      */
     d->is_privileged = false;
 
+    dsec->self_sid = dsec->sid = SECINITSID_XEN;
+
     return 0;
 }
 
diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/initial_sids
index 7eca70d339..e8b55b8368 100644
--- a/xen/xsm/flask/policy/initial_sids
+++ b/xen/xsm/flask/policy/initial_sids
@@ -3,6 +3,7 @@
 #
 # Define initial security identifiers 
 #
+sid xenboot
 sid xen
 sid dom0
 sid domio
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:51:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:51:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311107.528133 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwUg-0005kC-Vw; Fri, 22 Apr 2022 16:50:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311107.528133; Fri, 22 Apr 2022 16:50:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwUg-0005k5-Qt; Fri, 22 Apr 2022 16:50:54 +0000
Received: by outflank-mailman (input) for mailman id 311107;
 Fri, 22 Apr 2022 16:50:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhwUf-0005jv-RA; Fri, 22 Apr 2022 16:50:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhwUf-0006Bi-Mz; Fri, 22 Apr 2022 16:50:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhwUf-0006ff-8F; Fri, 22 Apr 2022 16:50:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhwUf-0004c2-7n; Fri, 22 Apr 2022 16:50:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XsdiJpGdMxVXwb7KtvqHDSOX4bZjV7knuM6R/Tg8/AQ=; b=Qp7HhUIE/TQqOAkaqS8rW7NYPo
	mOGIUw5Mngo6RXXuNfaJtvFdlSMG8XLNw7a28MGgVqNVj3JbYQeHRNqYaGYlWyNj69x4VDxPkO90H
	bTi3JzYvCtMLf2KVfP6fHZq7xV97DXShAHx7URF3ZW2lL5wmq2jw2vrMC6HduC4u0080=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169622-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169622: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=54279f87ecbcb3eab45fbdd52f44c1be998a9ab3
X-Osstest-Versions-That:
    xen=43f3d51139178a03823b061482c674e15ce3d49c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 16:50:53 +0000

flight 169622 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169622/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  54279f87ecbcb3eab45fbdd52f44c1be998a9ab3
baseline version:
 xen                  43f3d51139178a03823b061482c674e15ce3d49c

Last test of basis   169605  2022-04-22 00:00:29 Z    0 days
Testing same since   169622  2022-04-22 13:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   43f3d51139..54279f87ec  54279f87ecbcb3eab45fbdd52f44c1be998a9ab3 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:51:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:51:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311111.528144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwV8-0006D0-8E; Fri, 22 Apr 2022 16:51:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311111.528144; Fri, 22 Apr 2022 16:51:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwV8-0006Ct-4b; Fri, 22 Apr 2022 16:51:22 +0000
Received: by outflank-mailman (input) for mailman id 311111;
 Fri, 22 Apr 2022 16:51:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hyV/=VA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nhwV6-00064C-Ch
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:51:20 +0000
Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com
 [2a00:1450:4864:20::22e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ee2a5c5-c25c-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 18:51:19 +0200 (CEST)
Received: by mail-lj1-x22e.google.com with SMTP id q185so1165337ljb.5
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:51:19 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 n2-20020a056512310200b0046e2f507a3asm279742lfb.167.2022.04.22.09.51.17
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 22 Apr 2022 09:51:17 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ee2a5c5-c25c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=LliXt8vJbXvk0gdFymCWz7TFV5bME1jg6XdQF6Tyw7k=;
        b=E9bX8ntWQGbQG1g3CC0CY2p2Kmtu3Nq9zrBtYvnyvEBLe7UDaSXAfZp84Hz0Tmy7ZA
         AATF/cIenThS+4zqHWER1H04j8AbhDQSZaiKleKvsWFfPEERKOkds0mIPjp1CnINcTYs
         RLpfQnNiRd8n8brSU0+bqdlt5sMm5kgdxDCiGtBaZHF3pAZRJU4F2T867V9vCEExFw7G
         OI9aX+a85bD1I3FoyNGdVkXG/48sjsOQuXPybwv6PTvN6tn1yJhSp1wtym1oBJjESUKS
         NjVtGr70HWW9TBwhjue+jdSTc64xnZqHDbqFQjwFr0fddlJhOkp/FOuMjxHmyoihZYWs
         hrIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=LliXt8vJbXvk0gdFymCWz7TFV5bME1jg6XdQF6Tyw7k=;
        b=HNVkh1jpLKCM+4DCzkvHAhYOENrZPuufNtC/+eev0wvQ2HRrMOi4gKy54hfCD90K0T
         /zsj8q1p/eWy98xx0XoXPezi/a6LZdqgDVDJTNIcowvSukL26ML4rXTRwwyqrvF2Vga/
         X9w4/5qyXSfqm4HXnm9m+NIJNvN/P3OlxlxUA3wB8VUzWtwiqPwC8Kn8+apneJokO5bm
         +tWHknXnCU+CSHYu/s4ds6XiUb92CmDXfr7e7wlG1ezKsfHQ96sf/KB86w7lyKXhn1NX
         TaWvTfUVOUPoQ9J428UmwrzQVm+KSxedcsGrkrzojewoCxDWp5jhXmQ0vvK86Oxfcs5e
         W1Cw==
X-Gm-Message-State: AOAM530d0cm3ynSymAZVJ0xVdFddqHfseDO1Va0YkYS16gmt0010Q5R6
	tIdMTYnFMxmp5q05k/0A76v6rC2FO88=
X-Google-Smtp-Source: ABdhPJy6agfKahSo69KTOtM8idnRXj26r9imzfrM1EBFWoxzebKvrJ8xa3gfhyv7KZGn11RXBkTAWA==
X-Received: by 2002:a2e:9984:0:b0:24e:f843:3e8c with SMTP id w4-20020a2e9984000000b0024ef8433e8cmr1173572lji.299.1650646278427;
        Fri, 22 Apr 2022 09:51:18 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	x86@kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>,
	Henry Wang <Henry.Wang@arm.com>,
	Kaly Xin <Kaly.Xin@arm.com>,
	Jiamei Xie <Jiamei.Xie@arm.com>,
	=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
Subject: [PATCH V1 0/6] virtio: Solution to restrict memory access under Xen using xen-grant DMA-mapping layer
Date: Fri, 22 Apr 2022 19:50:57 +0300
Message-Id: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

The purpose of this patch series is to add support for restricting memory access under Xen using specific
grant table [1] based DMA-mapping layer. Patch series is based on Juergen Gross’ initial work [2] which implies
using grant references instead of raw guest physical addresses (GPA) for the virtio communications (some
kind of the software IOMMU).

You can find RFC patch series (and previous discussions) at [3].

The high level idea is to create new Xen’s grant table based DMA-mapping layer for the guest Linux whose main
purpose is to provide a special 64-bit DMA address which is formed by using the grant reference (for a page
to be shared with the backend) with offset and setting the highest address bit (this is for the backend to
be able to distinguish grant ref based DMA address from normal GPA). For this to work we need the ability
to allocate contiguous (consecutive) grant references for multi-page allocations. And the backend then needs
to offer VIRTIO_F_ACCESS_PLATFORM and VIRTIO_F_VERSION_1 feature bits (it must support virtio-mmio modern
transport for 64-bit addresses in the virtqueue).

Xen's grant mapping mechanism is the secure and safe solution to share pages between domains which proven
to work and works for years (in the context of traditional Xen PV drivers for example). So far, the foreign
mapping is used for the virtio backend to map and access guest memory. With the foreign mapping, the backend
is able to map arbitrary pages from the guest memory (or even from Dom0 memory). And as the result, the malicious
backend which runs in a non-trusted domain can take advantage of this. Instead, with the grant mapping
the backend is only allowed to map pages which were explicitly granted by the guest before and nothing else.
According to the discussions in various mainline threads this solution would likely be welcome because it
perfectly fits in the security model Xen provides.

What is more, the grant table based solution requires zero changes to the Xen hypervisor itself at least
with virtio-mmio and DT (in comparison, for example, with "foreign mapping + virtio-iommu" solution which would
require the whole new complex emulator in hypervisor in addition to new functionality/hypercall to pass IOVA
from the virtio backend running elsewhere to the hypervisor and translate it to the GPA before mapping into
P2M or denying the foreign mapping request if no corresponding IOVA-GPA mapping present in the IOMMU page table
for that particular device). We only need to update toolstack to insert a new "xen,dev-domid" property to
the virtio-mmio device node when creating a guest device-tree (this is an indicator for the guest to use grants
and the ID of Xen domain where the corresponding backend resides, it is used as an argument to the grant mapping
APIs). It worth mentioning that toolstack patch is based on non  upstreamed yet “Virtio support for toolstack
on Arm” series which is on review now [4].

Please note the following:
- Patch series only covers Arm and virtio-mmio (device-tree) for now. To enable the restricted memory access
  feature on Arm the following option should be set:
  CONFIG_XEN_VIRTIO = y
- Some callbacks in xen-grant DMA-mapping layer (alloc_pages/free_pages, etc) are not implemented yet as they
  are not needed/used in the first prototype
- Xen should be built with the following options:
  CONFIG_IOREQ_SERVER=y
  CONFIG_EXPERT=y
  
Patch series is rebased on Linux 5.18-rc2 tag and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64)
with standalone userspace (non-Qemu) virtio-mmio based virtio-disk backend running in Driver domain and Linux
guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy'
use-cases work properly. I have also tested other use-cases such as assigning several virtio block devices
or a mix of virtio and Xen PV block devices to the guest. Patch series was build-tested on Arm32 and x86.

1. Xen changes located at (last patch):
https://github.com/otyshchenko1/xen/commits/libxl_virtio_next
2. Linux changes located at:
https://github.com/otyshchenko1/linux/commits/virtio_grant6
3. virtio-disk changes located at:
https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant

Any feedback/help would be highly appreciated.

[1] https://xenbits.xenproject.org/docs/4.16-testing/misc/grant-tables.txt
[2] https://www.youtube.com/watch?v=IrlEdaIUDPk
[3] https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-olekstysh@gmail.com/
[4] https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/

Juergen Gross (2):
  xen/grants: support allocating consecutive grants
  xen/virtio: Add option to restrict memory access under Xen

Oleksandr Tyshchenko (4):
  arm/xen: Introduce xen_setup_dma_ops()
  dt-bindings: Add xen,dev-domid property description for xen-grant DMA
    ops
  xen/grant-dma-ops: Retrieve the ID of backend's domain for DT devices
  arm/xen: Assign xen-grant DMA ops for xen-grant DMA devices

 .../devicetree/bindings/arm/xen,dev-domid.yaml     |  37 +++
 arch/arm/include/asm/xen/xen-ops.h                 |   1 +
 arch/arm/mm/dma-mapping.c                          |   7 +-
 arch/arm/xen/enlighten.c                           |   8 +
 arch/arm64/include/asm/xen/xen-ops.h               |   1 +
 arch/arm64/mm/dma-mapping.c                        |   7 +-
 arch/x86/mm/init.c                                 |  11 +
 arch/x86/mm/mem_encrypt.c                          |   5 -
 drivers/xen/Kconfig                                |  15 +
 drivers/xen/Makefile                               |   1 +
 drivers/xen/grant-dma-ops.c                        | 328 +++++++++++++++++++++
 drivers/xen/grant-table.c                          | 238 +++++++++++++--
 include/xen/arm/xen-ops.h                          |  20 ++
 include/xen/grant_table.h                          |   4 +
 include/xen/xen-ops.h                              |  13 +
 include/xen/xen.h                                  |   5 +
 16 files changed, 654 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
 create mode 100644 arch/arm/include/asm/xen/xen-ops.h
 create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
 create mode 100644 drivers/xen/grant-dma-ops.c
 create mode 100644 include/xen/arm/xen-ops.h

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:51:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:51:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311113.528155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVA-0006Tz-GA; Fri, 22 Apr 2022 16:51:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311113.528155; Fri, 22 Apr 2022 16:51:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVA-0006Ts-CZ; Fri, 22 Apr 2022 16:51:24 +0000
Received: by outflank-mailman (input) for mailman id 311113;
 Fri, 22 Apr 2022 16:51:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hyV/=VA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nhwV8-0006Cr-Ha
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:51:22 +0000
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
 [2a00:1450:4864:20::22a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 700a0360-c25c-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 18:51:21 +0200 (CEST)
Received: by mail-lj1-x22a.google.com with SMTP id n17so10333832ljc.11
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:51:21 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 n2-20020a056512310200b0046e2f507a3asm279742lfb.167.2022.04.22.09.51.18
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 22 Apr 2022 09:51:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 700a0360-c25c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=GMgjzuq0mtE7dfPwrz9iyN7XiqhJI/kKUBmloz8CHVM=;
        b=TvogOFhSkVoEFDDp2UyFM5JT+iRsMeAsMM/Ir0HL2o1J+3AsH38OlCvt5oXs8CCV0S
         xnxUElm53fIFEcmFNvNSvMmmh4juZ3+WxRoQAU7gWAgnSyXTv4uRTElLcGlojn+w9rdF
         qDNCuB/K5KxRpOUO1ACvBknXeQucuqYZcVPZzxDWH6TcyWGUucHe6OwZ+exVVrxtH5Wa
         xzdueEOQxmDYRx+fspEs14YJcnhc7fM4o0YNvW4kICFGZc/ebzCbRgyaUk87mgH3Hb+/
         GgKojJu/EjHmouEBcVqfsA7l9jnJtbGlyY8Cf/h0HXmwLUzvJ+uSw/3SbFoXbhRUvmTW
         BPAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=GMgjzuq0mtE7dfPwrz9iyN7XiqhJI/kKUBmloz8CHVM=;
        b=3HUQIvYXwD4/zBrGQua/kQ6Tdkkbn4MSEHzwR1M48DqDW9RINTYcMpV2ZkdYGsyTVz
         TMU1/syq8qoZa24PuGM4udgBuGYdmbcJKO7kkdBVkcH2OmoN8SmcwlktfEcCsIeq+ImB
         GdpDXvPPau1c7CIZXgJ6xI3gLdQQGH2dJIIHvsf3x8Hiy60nwEYqUsuG9kW3kOu7UepT
         f4ncjzYdPzaNELtDtqS0BStk2KKFkkim1dl9nDD6Z37sXQs6N/nlJ45Hm2L+27GfbWc8
         9Zug1ClKRhzIAxdvIG9SZca/GH4pGYylOc9KEkuT5plLYH6f+L2pAaxO4bIziPc1tgfD
         Q3qw==
X-Gm-Message-State: AOAM533kKhaooNWphymSFd4GeVGezsnZsClujHMR615Qa/3YQEr4ycK6
	yA6zoX2HWw0KdPOrsa7f8DCmRLYDnmY=
X-Google-Smtp-Source: ABdhPJxBofHQqIEEOVD/ysfSrlTaHT4d23vVGsnsT2WqL8jP7PaAU3+Os5xoi30E2pyYaSKWwDmonw==
X-Received: by 2002:a2e:8659:0:b0:24d:b379:4cc0 with SMTP id i25-20020a2e8659000000b0024db3794cc0mr3390687ljj.289.1650646279861;
        Fri, 22 Apr 2022 09:51:19 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	David Hildenbrand <david@redhat.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Kees Cook <keescook@chromium.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Julien Grall <julien@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: [PATCH V1 1/6] arm/xen: Introduce xen_setup_dma_ops()
Date: Fri, 22 Apr 2022 19:50:58 +0300
Message-Id: <1650646263-22047-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This patch introduces new helper and places it in new header.
The helper's purpose is to assign any Xen specific DMA ops in
a single place. For now, we deal with xen-swiotlb DMA ops only.
The one of the subsequent commits in current series will add
xen-grant DMA ops case.

Also re-use the xen_swiotlb_detect() check on Arm32.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V1:
   - update commit description
   - move commit to the beginning of the series
   - move #ifdef CONFIG_XEN from dma-mapping.c to xen-ops.h
---
 arch/arm/include/asm/xen/xen-ops.h   |  1 +
 arch/arm/mm/dma-mapping.c            |  7 ++-----
 arch/arm64/include/asm/xen/xen-ops.h |  1 +
 arch/arm64/mm/dma-mapping.c          |  7 ++-----
 include/xen/arm/xen-ops.h            | 15 +++++++++++++++
 5 files changed, 21 insertions(+), 10 deletions(-)
 create mode 100644 arch/arm/include/asm/xen/xen-ops.h
 create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
 create mode 100644 include/xen/arm/xen-ops.h

diff --git a/arch/arm/include/asm/xen/xen-ops.h b/arch/arm/include/asm/xen/xen-ops.h
new file mode 100644
index 00000000..8d2fa24
--- /dev/null
+++ b/arch/arm/include/asm/xen/xen-ops.h
@@ -0,0 +1 @@
+#include <xen/arm/xen-ops.h>
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 82ffac6..059cce0 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -33,7 +33,7 @@
 #include <asm/dma-iommu.h>
 #include <asm/mach/map.h>
 #include <asm/system_info.h>
-#include <xen/swiotlb-xen.h>
+#include <asm/xen/xen-ops.h>
 
 #include "dma.h"
 #include "mm.h"
@@ -2287,10 +2287,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
 
 	set_dma_ops(dev, dma_ops);
 
-#ifdef CONFIG_XEN
-	if (xen_initial_domain())
-		dev->dma_ops = &xen_swiotlb_dma_ops;
-#endif
+	xen_setup_dma_ops(dev);
 	dev->archdata.dma_ops_setup = true;
 }
 
diff --git a/arch/arm64/include/asm/xen/xen-ops.h b/arch/arm64/include/asm/xen/xen-ops.h
new file mode 100644
index 00000000..8d2fa24
--- /dev/null
+++ b/arch/arm64/include/asm/xen/xen-ops.h
@@ -0,0 +1 @@
+#include <xen/arm/xen-ops.h>
diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
index 6719f9e..6099c81 100644
--- a/arch/arm64/mm/dma-mapping.c
+++ b/arch/arm64/mm/dma-mapping.c
@@ -9,9 +9,9 @@
 #include <linux/dma-map-ops.h>
 #include <linux/dma-iommu.h>
 #include <xen/xen.h>
-#include <xen/swiotlb-xen.h>
 
 #include <asm/cacheflush.h>
+#include <asm/xen/xen-ops.h>
 
 void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
 		enum dma_data_direction dir)
@@ -52,8 +52,5 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
 	if (iommu)
 		iommu_setup_dma_ops(dev, dma_base, dma_base + size - 1);
 
-#ifdef CONFIG_XEN
-	if (xen_swiotlb_detect())
-		dev->dma_ops = &xen_swiotlb_dma_ops;
-#endif
+	xen_setup_dma_ops(dev);
 }
diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
new file mode 100644
index 00000000..288deb1
--- /dev/null
+++ b/include/xen/arm/xen-ops.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_ARM_XEN_OPS_H
+#define _ASM_ARM_XEN_OPS_H
+
+#include <xen/swiotlb-xen.h>
+
+static inline void xen_setup_dma_ops(struct device *dev)
+{
+#ifdef CONFIG_XEN
+	if (xen_swiotlb_detect())
+		dev->dma_ops = &xen_swiotlb_dma_ops;
+#endif
+}
+
+#endif /* _ASM_ARM_XEN_OPS_H */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:51:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:51:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311114.528162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVB-0006cx-28; Fri, 22 Apr 2022 16:51:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311114.528162; Fri, 22 Apr 2022 16:51:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVA-0006Zq-Su; Fri, 22 Apr 2022 16:51:24 +0000
Received: by outflank-mailman (input) for mailman id 311114;
 Fri, 22 Apr 2022 16:51:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hyV/=VA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nhwV9-00064C-8b
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:51:23 +0000
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com
 [2a00:1450:4864:20::22b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 70888400-c25c-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 18:51:22 +0200 (CEST)
Received: by mail-lj1-x22b.google.com with SMTP id bf11so10345801ljb.7
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:51:22 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 n2-20020a056512310200b0046e2f507a3asm279742lfb.167.2022.04.22.09.51.19
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 22 Apr 2022 09:51:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70888400-c25c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=pbGH0EJ6MfeeEzJEuzrpQca/NgV2qpOSu33pTptCq9E=;
        b=l5FeG5KZgUw75VEghyNLWNSsq1XbGFuddkrMY/kSwoz/2B4wHM7gyCFzKfP0cNxyan
         z8SPKUCXEVxkxcNsEP7gbZQiduwcfoLcBs5mjAIuC8gZBXbBnkxYjVVyDR8e2G7toS8R
         69MktkPQK6iKJGYL2XZ1KzEiEOFe2wxAMQ16bBK3KsxpL7dlsloHnQalFGtfN0iIznvZ
         hCeI/uWsOIc9VtBfZ7iFb0wv2jnA4qZqABUCEQC5EiWEg0ZznfO049sxLpj82IYG8GbF
         dmcms/+GjyGaQlZtu02c65QMO8SMZcOn1ZRMAtPLfkyTPLTwgxLPNrIWnqPwU1TMwJCM
         p6pw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=pbGH0EJ6MfeeEzJEuzrpQca/NgV2qpOSu33pTptCq9E=;
        b=I9jv6nKMqeSppAMJMG5p4mDjo6JRIkxK2F08tRRumQlUgp4RRNNgCrX3H00D8DM/dn
         rcj2F7BDBXQAe+BragZcGPCuj+gLLbbeTqi8kWOJp+aSVLuiJfqL2AYfY+jGmEwxEJ2m
         RxHtNtZBfX8z6p4kyiO2EVLHZ2h5J12Gern69+cux0Kvtl2SHgb6AXY+ykyRWT9uiUX/
         BAGNZHEzdrPZGaXNhzsVIe3P3TgJJZ2XOt3zs/BCJfqjcZGKKVR18Gmlkwf1kEIJOrQ0
         74oYXlcqUDHzAsJ+wg+kBy2SuRDMindb01e4q3SIUlfZLoE9tTf0/h+ewud4A3AMmKzq
         CdCQ==
X-Gm-Message-State: AOAM531L49vv/IVkOo0IV0VrZP9qygLhuOPW4AtuucsCIfByC0aUoD0H
	GsfZXNV/TQXr/gTJ+tn//aVCDnoawO4=
X-Google-Smtp-Source: ABdhPJzXR1tqIb0yStMleNK7DtbOn2CfKFh2xfxXbFehkBHPpsyEBLUWQr+LG3hsAxYll2f+Op0pKA==
X-Received: by 2002:a2e:a7d5:0:b0:24d:ba78:1d30 with SMTP id x21-20020a2ea7d5000000b0024dba781d30mr3375134ljp.285.1650646281488;
        Fri, 22 Apr 2022 09:51:21 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: [PATCH V1 2/6] xen/grants: support allocating consecutive grants
Date: Fri, 22 Apr 2022 19:50:59 +0300
Message-Id: <1650646263-22047-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>

From: Juergen Gross <jgross@suse.com>

For support of virtio via grant mappings in rare cases larger mappings
using consecutive grants are needed. Support those by adding a bitmap
of free grants.

As consecutive grants will be needed only in very rare cases (e.g. when
configuring a virtio device with a multi-page ring), optimize for the
normal case of non-consecutive allocations.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
Changes RFC -> V1:
   - no changes
---
 drivers/xen/grant-table.c | 238 +++++++++++++++++++++++++++++++++++++++-------
 include/xen/grant_table.h |   4 +
 2 files changed, 210 insertions(+), 32 deletions(-)

diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 8ccccac..1b458c0 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -33,6 +33,7 @@
 
 #define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt
 
+#include <linux/bitmap.h>
 #include <linux/memblock.h>
 #include <linux/sched.h>
 #include <linux/mm.h>
@@ -72,9 +73,32 @@
 
 static grant_ref_t **gnttab_list;
 static unsigned int nr_grant_frames;
+
+/*
+ * Handling of free grants:
+ *
+ * Free grants are in a simple list anchored in gnttab_free_head. They are
+ * linked by grant ref, the last element contains GNTTAB_LIST_END. The number
+ * of free entries is stored in gnttab_free_count.
+ * Additionally there is a bitmap of free entries anchored in
+ * gnttab_free_bitmap. This is being used for simplifying allocation of
+ * multiple consecutive grants, which is needed e.g. for support of virtio.
+ * gnttab_last_free is used to add free entries of new frames at the end of
+ * the free list.
+ * gnttab_free_tail_ptr specifies the variable which references the start
+ * of consecutive free grants ending with gnttab_last_free. This pointer is
+ * updated in a rather defensive way, in order to avoid performance hits in
+ * hot paths.
+ * All those variables are protected by gnttab_list_lock.
+ */
 static int gnttab_free_count;
-static grant_ref_t gnttab_free_head;
+static unsigned int gnttab_size;
+static grant_ref_t gnttab_free_head = GNTTAB_LIST_END;
+static grant_ref_t gnttab_last_free = GNTTAB_LIST_END;
+static grant_ref_t *gnttab_free_tail_ptr;
+static unsigned long *gnttab_free_bitmap;
 static DEFINE_SPINLOCK(gnttab_list_lock);
+
 struct grant_frames xen_auto_xlat_grant_frames;
 static unsigned int xen_gnttab_version;
 module_param_named(version, xen_gnttab_version, uint, 0);
@@ -170,16 +194,111 @@ static int get_free_entries(unsigned count)
 
 	ref = head = gnttab_free_head;
 	gnttab_free_count -= count;
-	while (count-- > 1)
-		head = gnttab_entry(head);
+	while (count--) {
+		bitmap_clear(gnttab_free_bitmap, head, 1);
+		if (gnttab_free_tail_ptr == __gnttab_entry(head))
+			gnttab_free_tail_ptr = &gnttab_free_head;
+		if (count)
+			head = gnttab_entry(head);
+	}
 	gnttab_free_head = gnttab_entry(head);
 	gnttab_entry(head) = GNTTAB_LIST_END;
 
+	if (!gnttab_free_count) {
+		gnttab_last_free = GNTTAB_LIST_END;
+		gnttab_free_tail_ptr = NULL;
+	}
+
 	spin_unlock_irqrestore(&gnttab_list_lock, flags);
 
 	return ref;
 }
 
+static int get_seq_entry_count(void)
+{
+	if (gnttab_last_free == GNTTAB_LIST_END || !gnttab_free_tail_ptr ||
+	    *gnttab_free_tail_ptr == GNTTAB_LIST_END)
+		return 0;
+
+	return gnttab_last_free - *gnttab_free_tail_ptr + 1;
+}
+
+/* Rebuilds the free grant list and tries to find count consecutive entries. */
+static int get_free_seq(unsigned int count)
+{
+	int ret = -ENOSPC;
+	unsigned int from, to;
+	grant_ref_t *last;
+
+	gnttab_free_tail_ptr = &gnttab_free_head;
+	last = &gnttab_free_head;
+
+	for (from = find_first_bit(gnttab_free_bitmap, gnttab_size);
+	     from < gnttab_size;
+	     from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + 1)) {
+		to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size,
+					from + 1);
+		if (ret < 0 && to - from >= count) {
+			ret = from;
+			bitmap_clear(gnttab_free_bitmap, ret, count);
+			from += count;
+			gnttab_free_count -= count;
+			if (from == to)
+				continue;
+		}
+
+		while (from < to) {
+			*last = from;
+			last = __gnttab_entry(from);
+			gnttab_last_free = from;
+			from++;
+		}
+		if (to < gnttab_size)
+			gnttab_free_tail_ptr = __gnttab_entry(to - 1);
+	}
+
+	*last = GNTTAB_LIST_END;
+	if (gnttab_last_free != gnttab_size - 1)
+		gnttab_free_tail_ptr = NULL;
+
+	return ret;
+}
+
+static int get_free_entries_seq(unsigned int count)
+{
+	unsigned long flags;
+	int ret = 0;
+
+	spin_lock_irqsave(&gnttab_list_lock, flags);
+
+	if (gnttab_free_count < count) {
+		ret = gnttab_expand(count - gnttab_free_count);
+		if (ret < 0)
+			goto out;
+	}
+
+	if (get_seq_entry_count() < count) {
+		ret = get_free_seq(count);
+		if (ret >= 0)
+			goto out;
+		ret = gnttab_expand(count - get_seq_entry_count());
+		if (ret < 0)
+			goto out;
+	}
+
+	ret = *gnttab_free_tail_ptr;
+	*gnttab_free_tail_ptr = gnttab_entry(ret + count - 1);
+	gnttab_free_count -= count;
+	if (!gnttab_free_count)
+		gnttab_free_tail_ptr = NULL;
+	bitmap_clear(gnttab_free_bitmap, ret, count);
+
+ out:
+	spin_unlock_irqrestore(&gnttab_list_lock, flags);
+
+	return ret;
+}
+
 static void do_free_callbacks(void)
 {
 	struct gnttab_free_callback *callback, *next;
@@ -206,17 +325,48 @@ static inline void check_free_callbacks(void)
 		do_free_callbacks();
 }
 
-static void put_free_entry(grant_ref_t ref)
+static void put_free_entry_locked(grant_ref_t ref)
 {
-	unsigned long flags;
-	spin_lock_irqsave(&gnttab_list_lock, flags);
 	gnttab_entry(ref) = gnttab_free_head;
 	gnttab_free_head = ref;
+	if (!gnttab_free_count)
+		gnttab_last_free = ref;
+	if (gnttab_free_tail_ptr == &gnttab_free_head)
+		gnttab_free_tail_ptr = __gnttab_entry(ref);
 	gnttab_free_count++;
+	bitmap_set(gnttab_free_bitmap, ref, 1);
+}
+
+static void put_free_entry(grant_ref_t ref)
+{
+	unsigned long flags;
+
+	spin_lock_irqsave(&gnttab_list_lock, flags);
+	put_free_entry_locked(ref);
 	check_free_callbacks();
 	spin_unlock_irqrestore(&gnttab_list_lock, flags);
 }
 
+static void gnttab_set_free(unsigned int start, unsigned int n)
+{
+	unsigned int i;
+
+	for (i = start; i < start + n - 1; i++)
+		gnttab_entry(i) = i + 1;
+
+	gnttab_entry(i) = GNTTAB_LIST_END;
+	if (!gnttab_free_count) {
+		gnttab_free_head = start;
+		gnttab_free_tail_ptr = &gnttab_free_head;
+	} else {
+		gnttab_entry(gnttab_last_free) = start;
+	}
+	gnttab_free_count += n;
+	gnttab_last_free = i;
+
+	bitmap_set(gnttab_free_bitmap, start, n);
+}
+
 /*
  * Following applies to gnttab_update_entry_v1 and gnttab_update_entry_v2.
  * Introducing a valid entry into the grant table:
@@ -448,23 +598,31 @@ void gnttab_free_grant_references(grant_ref_t head)
 {
 	grant_ref_t ref;
 	unsigned long flags;
-	int count = 1;
-	if (head == GNTTAB_LIST_END)
-		return;
+
 	spin_lock_irqsave(&gnttab_list_lock, flags);
-	ref = head;
-	while (gnttab_entry(ref) != GNTTAB_LIST_END) {
-		ref = gnttab_entry(ref);
-		count++;
+	while (head != GNTTAB_LIST_END) {
+		ref = gnttab_entry(head);
+		put_free_entry_locked(head);
+		head = ref;
 	}
-	gnttab_entry(ref) = gnttab_free_head;
-	gnttab_free_head = head;
-	gnttab_free_count += count;
 	check_free_callbacks();
 	spin_unlock_irqrestore(&gnttab_list_lock, flags);
 }
 EXPORT_SYMBOL_GPL(gnttab_free_grant_references);
 
+void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count)
+{
+	unsigned long flags;
+	unsigned int i;
+
+	spin_lock_irqsave(&gnttab_list_lock, flags);
+	for (i = count; i > 0; i--)
+		put_free_entry_locked(head + i - 1);
+	check_free_callbacks();
+	spin_unlock_irqrestore(&gnttab_list_lock, flags);
+}
+EXPORT_SYMBOL_GPL(gnttab_free_grant_reference_seq);
+
 int gnttab_alloc_grant_references(u16 count, grant_ref_t *head)
 {
 	int h = get_free_entries(count);
@@ -478,6 +636,24 @@ int gnttab_alloc_grant_references(u16 count, grant_ref_t *head)
 }
 EXPORT_SYMBOL_GPL(gnttab_alloc_grant_references);
 
+int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first)
+{
+	int h;
+
+	if (count == 1)
+		h = get_free_entries(1);
+	else
+		h = get_free_entries_seq(count);
+
+	if (h < 0)
+		return -ENOSPC;
+
+	*first = h;
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(gnttab_alloc_grant_reference_seq);
+
 int gnttab_empty_grant_references(const grant_ref_t *private_head)
 {
 	return (*private_head == GNTTAB_LIST_END);
@@ -570,16 +746,13 @@ static int grow_gnttab_list(unsigned int more_frames)
 			goto grow_nomem;
 	}
 
+	gnttab_set_free(gnttab_size, extra_entries);
 
-	for (i = grefs_per_frame * nr_grant_frames;
-	     i < grefs_per_frame * new_nr_grant_frames - 1; i++)
-		gnttab_entry(i) = i + 1;
-
-	gnttab_entry(i) = gnttab_free_head;
-	gnttab_free_head = grefs_per_frame * nr_grant_frames;
-	gnttab_free_count += extra_entries;
+	if (!gnttab_free_tail_ptr)
+		gnttab_free_tail_ptr = __gnttab_entry(gnttab_size);
 
 	nr_grant_frames = new_nr_grant_frames;
+	gnttab_size += extra_entries;
 
 	check_free_callbacks();
 
@@ -1424,7 +1597,6 @@ int gnttab_init(void)
 	int i;
 	unsigned long max_nr_grant_frames;
 	unsigned int max_nr_glist_frames, nr_glist_frames;
-	unsigned int nr_init_grefs;
 	int ret;
 
 	gnttab_request_version();
@@ -1452,6 +1624,13 @@ int gnttab_init(void)
 		}
 	}
 
+	i = gnttab_interface->grefs_per_grant_frame * max_nr_grant_frames;
+	gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL);
+	if (!gnttab_free_bitmap) {
+		ret = -ENOMEM;
+		goto ini_nomem;
+	}
+
 	ret = arch_gnttab_init(max_nr_grant_frames,
 			       nr_status_frames(max_nr_grant_frames));
 	if (ret < 0)
@@ -1462,15 +1641,9 @@ int gnttab_init(void)
 		goto ini_nomem;
 	}
 
-	nr_init_grefs = nr_grant_frames *
-			gnttab_interface->grefs_per_grant_frame;
-
-	for (i = NR_RESERVED_ENTRIES; i < nr_init_grefs - 1; i++)
-		gnttab_entry(i) = i + 1;
+	gnttab_size = nr_grant_frames * gnttab_interface->grefs_per_grant_frame;
 
-	gnttab_entry(nr_init_grefs - 1) = GNTTAB_LIST_END;
-	gnttab_free_count = nr_init_grefs - NR_RESERVED_ENTRIES;
-	gnttab_free_head  = NR_RESERVED_ENTRIES;
+	gnttab_set_free(NR_RESERVED_ENTRIES, gnttab_size - NR_RESERVED_ENTRIES);
 
 	printk("Grant table initialized\n");
 	return 0;
@@ -1479,6 +1652,7 @@ int gnttab_init(void)
 	for (i--; i >= 0; i--)
 		free_page((unsigned long)gnttab_list[i]);
 	kfree(gnttab_list);
+	bitmap_free(gnttab_free_bitmap);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(gnttab_init);
diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h
index dfd5bf3..d815e1d 100644
--- a/include/xen/grant_table.h
+++ b/include/xen/grant_table.h
@@ -129,10 +129,14 @@ int gnttab_try_end_foreign_access(grant_ref_t ref);
  */
 int gnttab_alloc_grant_references(u16 count, grant_ref_t *pprivate_head);
 
+int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first);
+
 void gnttab_free_grant_reference(grant_ref_t ref);
 
 void gnttab_free_grant_references(grant_ref_t head);
 
+void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count);
+
 int gnttab_empty_grant_references(const grant_ref_t *pprivate_head);
 
 int gnttab_claim_grant_reference(grant_ref_t *pprivate_head);
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:51:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:51:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311115.528177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVC-000702-DE; Fri, 22 Apr 2022 16:51:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311115.528177; Fri, 22 Apr 2022 16:51:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVC-0006z1-7d; Fri, 22 Apr 2022 16:51:26 +0000
Received: by outflank-mailman (input) for mailman id 311115;
 Fri, 22 Apr 2022 16:51:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hyV/=VA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nhwVB-0006Cr-7F
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:51:25 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 718865e4-c25c-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 18:51:24 +0200 (CEST)
Received: by mail-lf1-x130.google.com with SMTP id bq30so15303521lfb.3
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:51:24 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 n2-20020a056512310200b0046e2f507a3asm279742lfb.167.2022.04.22.09.51.21
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 22 Apr 2022 09:51:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 718865e4-c25c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=o6f6b9Ed2EOTSIl43sWJ1e4CyXkESkrVfEWzvoot9Wk=;
        b=mAUA9xma+eay/TnfhAP6yaN1yv/vOdxInTPx3XbLjEy67v+x1BSm6nrFpg3Cj2/Dun
         JDvJobIjZFNimuCmWOJGHF2Le3njiIeAjD0jp8RVAlb/iCh309R96+lQzF2+nuZKgkRo
         1FI1ChP7jLX3bOf7kgAEAud9NHv6fDGSG+IC/DNbDJzeHAH1za4wBtv5HDezvWv4L78w
         Q0fxrK8rqC6zcO7os3J4orGrGe2ijTtjKZWKjd19vxXdpKlIlXZV9VX1aTikdRNH5PqF
         NA1+MdqActyKZ9hxk5RzK2Hv61ZFl+PWOsltfbV4YX7aMBHEo3Ftue6aABERdx8ACvKS
         HL9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=o6f6b9Ed2EOTSIl43sWJ1e4CyXkESkrVfEWzvoot9Wk=;
        b=hjmx8iXLGr6ylHzCchDGrCJRekYIWIBeg4Mv6ACSNTdkAjm8vtlDwiB2CKJ65ScuOW
         /taYnuxh6GOLg7J4ilGSF+m/CPUSG0VEGHlY3DB2wyHNpL8tCz7ZLfAwMnso1LRNG7DU
         W/E3P2/yoYsH8uR70X+9ySfOfKw0c8lgJXP9TjGNLlzN6sU0aJDWmNeN2xJiZlrGbVU8
         HI2ItV7WY7rcjzdxrKKWZrTcR9k1YTyEyR1XjEHOmiGObOezDTt6PT2ZPKx0bbf4vAIb
         XszDL6JYEPzFN6zLN+JUE8rHiCGXrhXPNrQCQzrpgKEu5YmaNbu19Jzx9Z7Dk64sjxGv
         Ay3w==
X-Gm-Message-State: AOAM532+qtU1w6mP59wIZLLmQG2kLviJTJdcfsvAvlt/EQReAk5CYae8
	uYoqSMFz/aCe+VKwBdnpiKuAQQYe5hI=
X-Google-Smtp-Source: ABdhPJxUulQza4XzwHS+vn+t0JcKH1tSxdalQ0Xh720bOQBE/5H0dXKzgQ/JULuYgnjvPsZUQgNOsg==
X-Received: by 2002:a05:6512:2385:b0:470:6e19:7ec8 with SMTP id c5-20020a056512238500b004706e197ec8mr3580179lfv.303.1650646282914;
        Fri, 22 Apr 2022 09:51:22 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Juergen Gross <jgross@suse.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access under Xen
Date: Fri, 22 Apr 2022 19:51:00 +0300
Message-Id: <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Juergen Gross <jgross@suse.com>

Introduce Xen grant DMA-mapping layer which contains special DMA-mapping
routines for providing grant references as DMA addresses to be used by
frontends (e.g. virtio) in Xen guests.

In order to support virtio in Xen guests add a config option XEN_VIRTIO
enabling the user to specify whether in all Xen guests virtio should
be able to access memory via Xen grant mappings only on the host side.

As this also requires providing arch_has_restricted_virtio_memory_access
implementation, switch from a pure stub to a real function on Arm
and combine with existing implementation for the SEV guests on x86.

Add the needed functionality by providing a special set of DMA ops
handling the needed grant operations for the I/O pages.

Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V1:
   - squash with almost all changes from commit (except handling "xen,dev-domid"
     property):
     "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer"
   - update commit subject/description and comments in code
   - leave only single Kconfig option XEN_VIRTIO and remove architectural
     dependencies
   - introduce common xen_has_restricted_virtio_memory_access() in xen.h
     and update arch_has_restricted_virtio_memory_access() for both
     Arm and x86 to call new helper
   - use (1ULL << 63) instead of 0x8000000000000000ULL for XEN_GRANT_ADDR_OFF
   - implement xen_virtio_dma_map(unmap)_sg() using example in swiotlb-xen.c
   - optimize padding by moving "broken" field in struct xen_virtio_data
   - remove unneeded per-device spinlock
   - remove the inclusion of virtio_config.h
   - remane everything according to the new naming scheme:
     s/virtio/grant_dma
   - add new hidden config option XEN_GRANT_DMA_OPS
---
 arch/arm/xen/enlighten.c    |   8 ++
 arch/x86/mm/init.c          |  11 ++
 arch/x86/mm/mem_encrypt.c   |   5 -
 drivers/xen/Kconfig         |  15 +++
 drivers/xen/Makefile        |   1 +
 drivers/xen/grant-dma-ops.c | 317 ++++++++++++++++++++++++++++++++++++++++++++
 include/xen/xen-ops.h       |   8 ++
 include/xen/xen.h           |   5 +
 8 files changed, 365 insertions(+), 5 deletions(-)
 create mode 100644 drivers/xen/grant-dma-ops.c

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index ec5b082..49af493 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -409,6 +409,14 @@ int __init arch_xen_unpopulated_init(struct resource **res)
 }
 #endif
 
+#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+int arch_has_restricted_virtio_memory_access(void)
+{
+	return xen_has_restricted_virtio_memory_access();
+}
+EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
+#endif
+
 static void __init xen_dt_guest_init(void)
 {
 	struct device_node *xen_node;
diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index d8cfce2..fe84a3e 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -8,6 +8,8 @@
 #include <linux/kmemleak.h>
 #include <linux/sched/task.h>
 
+#include <xen/xen.h>
+
 #include <asm/set_memory.h>
 #include <asm/e820/api.h>
 #include <asm/init.h>
@@ -1065,3 +1067,12 @@ unsigned long max_swapfile_size(void)
 	return pages;
 }
 #endif
+
+#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+int arch_has_restricted_virtio_memory_access(void)
+{
+	return (xen_has_restricted_virtio_memory_access() ||
+			cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
+}
+EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
+#endif
diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
index 50d2099..dda020f 100644
--- a/arch/x86/mm/mem_encrypt.c
+++ b/arch/x86/mm/mem_encrypt.c
@@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
 	print_mem_encrypt_feature_info();
 }
 
-int arch_has_restricted_virtio_memory_access(void)
-{
-	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
-}
-EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 120d32f..b95581f 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -335,4 +335,19 @@ config XEN_UNPOPULATED_ALLOC
 	  having to balloon out RAM regions in order to obtain physical memory
 	  space to create such mappings.
 
+config XEN_GRANT_DMA_OPS
+	bool
+	select DMA_OPS
+
+config XEN_VIRTIO
+	bool "Xen virtio support"
+	default n
+	depends on VIRTIO
+	select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+	select XEN_GRANT_DMA_OPS
+	help
+	  Enable virtio support for running as Xen guest. Depending on the
+	  guest type this will require special support on the backend side
+	  (qemu or kernel, depending on the virtio device types used).
+
 endmenu
diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
index 5aae66e..1a23cb0 100644
--- a/drivers/xen/Makefile
+++ b/drivers/xen/Makefile
@@ -39,3 +39,4 @@ xen-gntalloc-y				:= gntalloc.o
 xen-privcmd-y				:= privcmd.o privcmd-buf.o
 obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)	+= xen-front-pgdir-shbuf.o
 obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)	+= unpopulated-alloc.o
+obj-$(CONFIG_XEN_GRANT_DMA_OPS)		+= grant-dma-ops.o
diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
new file mode 100644
index 00000000..0e69aa8
--- /dev/null
+++ b/drivers/xen/grant-dma-ops.c
@@ -0,0 +1,317 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/******************************************************************************
+ * Xen grant DMA-mapping layer - contains special DMA-mapping routines
+ * for providing grant references as DMA addresses to be used by frontends
+ * (e.g. virtio) in Xen guests
+ *
+ * Copyright (c) 2021, Juergen Gross <jgross@suse.com>
+ */
+
+#include <linux/module.h>
+#include <linux/dma-map-ops.h>
+#include <linux/of.h>
+#include <linux/pci.h>
+#include <linux/pfn.h>
+#include <xen/xen.h>
+#include <xen/grant_table.h>
+
+struct xen_grant_dma_data {
+	/* The ID of backend domain */
+	domid_t dev_domid;
+	/* Is device behaving sane? */
+	bool broken;
+	struct device *dev;
+	struct list_head list;
+};
+
+static LIST_HEAD(xen_grant_dma_devices);
+static DEFINE_SPINLOCK(xen_grant_dma_lock);
+
+#define XEN_GRANT_DMA_ADDR_OFF	(1ULL << 63)
+
+static inline dma_addr_t grant_to_dma(grant_ref_t grant)
+{
+	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
+}
+
+static inline grant_ref_t dma_to_grant(dma_addr_t dma)
+{
+	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT);
+}
+
+static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
+{
+	struct xen_grant_dma_data *data = NULL;
+	bool found = false;
+
+	spin_lock(&xen_grant_dma_lock);
+
+	list_for_each_entry(data, &xen_grant_dma_devices, list) {
+		if (data->dev == dev) {
+			found = true;
+			break;
+		}
+	}
+
+	spin_unlock(&xen_grant_dma_lock);
+
+	return found ? data : NULL;
+}
+
+/*
+ * DMA ops for Xen frontends (e.g. virtio).
+ *
+ * Used to act as a kind of software IOMMU for Xen guests by using grants as
+ * DMA addresses.
+ * Such a DMA address is formed by using the grant reference as a frame
+ * number and setting the highest address bit (this bit is for the backend
+ * to be able to distinguish it from e.g. a mmio address).
+ *
+ * Note that for now we hard wire dom0 to be the backend domain. In order
+ * to support any domain as backend we'd need to add a way to communicate
+ * the domid of this backend, e.g. via Xenstore, via the PCI-device's
+ * config space or DT/ACPI.
+ */
+static void *xen_grant_dma_alloc(struct device *dev, size_t size,
+				 dma_addr_t *dma_handle, gfp_t gfp,
+				 unsigned long attrs)
+{
+	struct xen_grant_dma_data *data;
+	unsigned int i, n_pages = PFN_UP(size);
+	unsigned long pfn;
+	grant_ref_t grant;
+	void *ret;
+
+	data = find_xen_grant_dma_data(dev);
+	if (!data)
+		return NULL;
+
+	if (unlikely(data->broken))
+		return NULL;
+
+	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
+	if (!ret)
+		return NULL;
+
+	pfn = virt_to_pfn(ret);
+
+	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
+		free_pages_exact(ret, n_pages * PAGE_SIZE);
+		return NULL;
+	}
+
+	for (i = 0; i < n_pages; i++) {
+		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
+				pfn_to_gfn(pfn + i), 0);
+	}
+
+	*dma_handle = grant_to_dma(grant);
+
+	return ret;
+}
+
+static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
+			       dma_addr_t dma_handle, unsigned long attrs)
+{
+	struct xen_grant_dma_data *data;
+	unsigned int i, n_pages = PFN_UP(size);
+	grant_ref_t grant;
+
+	data = find_xen_grant_dma_data(dev);
+	if (!data)
+		return;
+
+	if (unlikely(data->broken))
+		return;
+
+	grant = dma_to_grant(dma_handle);
+
+	for (i = 0; i < n_pages; i++) {
+		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
+			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
+			data->broken = true;
+			return;
+		}
+	}
+
+	gnttab_free_grant_reference_seq(grant, n_pages);
+
+	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
+}
+
+static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
+					      dma_addr_t *dma_handle,
+					      enum dma_data_direction dir,
+					      gfp_t gfp)
+{
+	WARN_ONCE(1, "xen_grant_dma_alloc_pages size %zu\n", size);
+	return NULL;
+}
+
+static void xen_grant_dma_free_pages(struct device *dev, size_t size,
+				     struct page *vaddr, dma_addr_t dma_handle,
+				     enum dma_data_direction dir)
+{
+	WARN_ONCE(1, "xen_grant_dma_free_pages size %zu\n", size);
+}
+
+static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
+					 unsigned long offset, size_t size,
+					 enum dma_data_direction dir,
+					 unsigned long attrs)
+{
+	struct xen_grant_dma_data *data;
+	unsigned int i, n_pages = PFN_UP(size);
+	grant_ref_t grant;
+	dma_addr_t dma_handle;
+
+	BUG_ON(dir == DMA_NONE);
+
+	data = find_xen_grant_dma_data(dev);
+	if (!data)
+		return DMA_MAPPING_ERROR;
+
+	if (unlikely(data->broken))
+		return DMA_MAPPING_ERROR;
+
+	if (gnttab_alloc_grant_reference_seq(n_pages, &grant))
+		return DMA_MAPPING_ERROR;
+
+	for (i = 0; i < n_pages; i++) {
+		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
+				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
+	}
+
+	dma_handle = grant_to_dma(grant) + offset;
+
+	return dma_handle;
+}
+
+static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
+				     size_t size, enum dma_data_direction dir,
+				     unsigned long attrs)
+{
+	struct xen_grant_dma_data *data;
+	unsigned int i, n_pages = PFN_UP(size);
+	grant_ref_t grant;
+
+	BUG_ON(dir == DMA_NONE);
+
+	data = find_xen_grant_dma_data(dev);
+	if (!data)
+		return;
+
+	if (unlikely(data->broken))
+		return;
+
+	grant = dma_to_grant(dma_handle);
+
+	for (i = 0; i < n_pages; i++) {
+		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
+			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
+			data->broken = true;
+			return;
+		}
+	}
+
+	gnttab_free_grant_reference_seq(grant, n_pages);
+}
+
+static void xen_grant_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
+				   int nents, enum dma_data_direction dir,
+				   unsigned long attrs)
+{
+	struct scatterlist *s;
+	unsigned int i;
+
+	BUG_ON(dir == DMA_NONE);
+
+	for_each_sg(sg, s, nents, i)
+		xen_grant_dma_unmap_page(dev, s->dma_address, sg_dma_len(s), dir,
+				attrs);
+}
+
+static int xen_grant_dma_map_sg(struct device *dev, struct scatterlist *sg,
+				int nents, enum dma_data_direction dir,
+				unsigned long attrs)
+{
+	struct scatterlist *s;
+	unsigned int i;
+
+	BUG_ON(dir == DMA_NONE);
+
+	for_each_sg(sg, s, nents, i) {
+		s->dma_address = xen_grant_dma_map_page(dev, sg_page(s), s->offset,
+				s->length, dir, attrs);
+		if (s->dma_address == DMA_MAPPING_ERROR)
+			goto out;
+
+		sg_dma_len(s) = s->length;
+	}
+
+	return nents;
+
+out:
+	xen_grant_dma_unmap_sg(dev, sg, i, dir, attrs | DMA_ATTR_SKIP_CPU_SYNC);
+	sg_dma_len(sg) = 0;
+
+	return -EIO;
+}
+
+static int xen_grant_dma_supported(struct device *dev, u64 mask)
+{
+	return mask == DMA_BIT_MASK(64);
+}
+
+static const struct dma_map_ops xen_grant_dma_ops = {
+	.alloc = xen_grant_dma_alloc,
+	.free = xen_grant_dma_free,
+	.alloc_pages = xen_grant_dma_alloc_pages,
+	.free_pages = xen_grant_dma_free_pages,
+	.mmap = dma_common_mmap,
+	.get_sgtable = dma_common_get_sgtable,
+	.map_page = xen_grant_dma_map_page,
+	.unmap_page = xen_grant_dma_unmap_page,
+	.map_sg = xen_grant_dma_map_sg,
+	.unmap_sg = xen_grant_dma_unmap_sg,
+	.dma_supported = xen_grant_dma_supported,
+};
+
+void xen_grant_setup_dma_ops(struct device *dev)
+{
+	struct xen_grant_dma_data *data;
+	uint32_t dev_domid;
+
+	data = find_xen_grant_dma_data(dev);
+	if (data) {
+		dev_err(dev, "Xen grant DMA data is already created\n");
+		return;
+	}
+
+	/* XXX The dom0 is hardcoded as the backend domain for now */
+	dev_domid = 0;
+
+	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
+	if (!data) {
+		dev_err(dev, "Сannot allocate Xen grant DMA data\n");
+		goto err;
+	}
+	data->dev_domid = dev_domid;
+	data->dev = dev;
+
+	spin_lock(&xen_grant_dma_lock);
+	list_add(&data->list, &xen_grant_dma_devices);
+	spin_unlock(&xen_grant_dma_lock);
+
+	dev->dma_ops = &xen_grant_dma_ops;
+
+	return;
+
+err:
+	dev_err(dev, "Сannot set up Xen grant DMA ops, retain platform DMA ops\n");
+}
+EXPORT_SYMBOL_GPL(xen_grant_setup_dma_ops);
+
+MODULE_DESCRIPTION("Xen grant DMA-mapping layer");
+MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
+MODULE_LICENSE("GPL");
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index a3584a3..4f9fad5 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { }
 
 #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
 
+#ifdef CONFIG_XEN_GRANT_DMA_OPS
+void xen_grant_setup_dma_ops(struct device *dev);
+#else
+static inline void xen_grant_setup_dma_ops(struct device *dev)
+{
+}
+#endif /* CONFIG_XEN_GRANT_DMA_OPS */
+
 #endif /* INCLUDE_XEN_OPS_H */
diff --git a/include/xen/xen.h b/include/xen/xen.h
index a99bab8..fe6e6bb 100644
--- a/include/xen/xen.h
+++ b/include/xen/xen.h
@@ -52,6 +52,11 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
 extern u64 xen_saved_max_mem_size;
 #endif
 
+static inline int xen_has_restricted_virtio_memory_access(void)
+{
+	return IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain();
+}
+
 #ifdef CONFIG_XEN_UNPOPULATED_ALLOC
 int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
 void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:51:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:51:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311116.528188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVD-0007KA-V3; Fri, 22 Apr 2022 16:51:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311116.528188; Fri, 22 Apr 2022 16:51:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVD-0007It-Oh; Fri, 22 Apr 2022 16:51:27 +0000
Received: by outflank-mailman (input) for mailman id 311116;
 Fri, 22 Apr 2022 16:51:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hyV/=VA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nhwVB-0006Cr-RY
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:51:25 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 721d1434-c25c-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 18:51:25 +0200 (CEST)
Received: by mail-lf1-x134.google.com with SMTP id h27so15021693lfj.13
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:51:25 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 n2-20020a056512310200b0046e2f507a3asm279742lfb.167.2022.04.22.09.51.23
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 22 Apr 2022 09:51:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 721d1434-c25c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=99hspxuLODhQpov2wjpLVe38h5x1eJYakvWm7x8e6iI=;
        b=F23kF0eGH2ZVB+UGEjmW9/zKmFnzoAMLghAwzApvwMCcMhtBG9yJPpY4U1QzTxgJqh
         dlRXZHbEg3zZ7nY0RRV+8fUOu1XkZkXeqKyrW16n02fiZBATqOd2CzVkTaqbBEsKlX+6
         r6aK5PoP5QLM42PK/aLq8s/VUKQChEmq/ezbmXtxZxY1a/RDaoMGUVuns/+Ft+exgVHV
         qbfu1h52HdfRiNt9rNvFnhuiPOsYt6N8H7gak3I0DBjmtU3G2m7PdaKAunzdkWOdWVMV
         ovHh6R/nKxeNIZ67iu83BqdSWGokrQ3h7RK4/vcpMr2+xi4nqmoXe2TQmCa8LS8q13oq
         2CTg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=99hspxuLODhQpov2wjpLVe38h5x1eJYakvWm7x8e6iI=;
        b=G1zdLWHuUIT2Jjxw6iBc7++vLZ6JOLTf+DSJHtcohudJTHPqHK371eQVRSoMTXxmQa
         ffkp+YUCx/XJ3AP7s1gpvz9JBeDDFtXSJFZn3pjHtQ+Ewbmdk8bGRkMaLh4xLvrJ2Wc5
         7vVdVJGlK3f2bNbsdt8N30T+STZKxjn0i+SAJ8gApRmoggd7gGjitjeeOxc164y7Eder
         6z7uKxrdrOub8TaVbwHEoxwPxHkMF99TBSJLWXJrhqt6Qx/94IsktSL7kjTRDYXGUmRN
         +9mYYOxdZ7iVToMODuLkI0QfEo5Wc5ZIF8BB0/l3F/hwWlI4NULM7+RYfVOPRuCE3J7/
         pRSw==
X-Gm-Message-State: AOAM5333jqtpdcyfEucnJQWov1badj/zMQMpT/5gXcxPlpYHyCwV27sU
	LDUAaKLcFs1dP9RoNt/A0/XSQMaU1oQ=
X-Google-Smtp-Source: ABdhPJxHzbye4XRLnSvBlQObswNpXjTS3XrDqE1jJLqg0maTMcfec1EnyxM49kxDQRnXmTUAz/llKg==
X-Received: by 2002:a05:6512:499:b0:46f:d419:a19b with SMTP id v25-20020a056512049900b0046fd419a19bmr3576799lfq.654.1650646284247;
        Fri, 22 Apr 2022 09:51:24 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Jason Wang <jasowang@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Julien Grall <julien@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops
Date: Fri, 22 Apr 2022 19:51:01 +0300
Message-Id: <1650646263-22047-5-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Introduce Xen specific binding for the virtualized device (e.g. virtio)
to be used by Xen grant DMA-mapping layer in the subsequent commit.

This binding indicates that Xen grant mappings scheme needs to be
enabled for the device which DT node contains that property and specifies
the ID of Xen domain where the corresponding backend resides. The ID
(domid) is used as an argument to the grant mapping APIs.

This is needed for the option to restrict memory access using Xen grant
mappings to work which primary goal is to enable using virtio devices
in Xen guests.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V1:
   - update commit subject/description and text in description
   - move to devicetree/bindings/arm/
---
 .../devicetree/bindings/arm/xen,dev-domid.yaml     | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml

diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
new file mode 100644
index 00000000..ef0f747
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xen specific binding for the virtualized device (e.g. virtio)
+
+maintainers:
+  - Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
+
+select: true
+
+description:
+  This binding indicates that Xen grant mappings scheme needs to be enabled
+  for that device and specifies the ID of Xen domain where the corresponding
+  device (backend) resides. This is needed for the option to restrict memory
+  access using Xen grant mappings to work.
+
+properties:
+  xen,dev-domid:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      The domid (domain ID) of the domain where the device (backend) is running.
+
+additionalProperties: true
+
+examples:
+  - |
+    virtio_block@3000 {
+            compatible = "virtio,mmio";
+            reg = <0x3000 0x100>;
+            interrupts = <41>;
+
+            /* The device is located in Xen domain with ID 1 */
+            xen,dev-domid = <1>;
+    };
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:51:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:51:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311117.528193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVE-0007MY-Aq; Fri, 22 Apr 2022 16:51:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311117.528193; Fri, 22 Apr 2022 16:51:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVE-0007Lx-1Y; Fri, 22 Apr 2022 16:51:28 +0000
Received: by outflank-mailman (input) for mailman id 311117;
 Fri, 22 Apr 2022 16:51:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hyV/=VA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nhwVC-0006Cr-Q8
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:51:26 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 72be5f01-c25c-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 18:51:26 +0200 (CEST)
Received: by mail-lf1-x12b.google.com with SMTP id p12so9739958lfs.5
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:51:26 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 n2-20020a056512310200b0046e2f507a3asm279742lfb.167.2022.04.22.09.51.24
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 22 Apr 2022 09:51:24 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72be5f01-c25c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=KhuPWU8Ck/Zqwd8QYGNbplUi9vy17AnQZagSCJ37QGk=;
        b=NOb0zaTNkpTy3DsQIPg0dlh0OMrNEZEmtlKznw8XqFpcusEUdvVM6zMbTVNhxDwSXb
         9s37u6+satXYoHdp9aa7oR59besAWm0FyfFiy6XEjvSmmpgqVORyHmPjGB9ycHQDJJWY
         NhBHK5PmSgHWKDXsrY1o7I3msHW/lE2r8fRLPkm+huQTPVs0JPTel+isPlp+aKY9PECA
         TgXI2IbEGgOzT7qwLsqu/TyulQid0mXcPa7j9ZtTDusbzC4o3xYvxYVruqLq6WimAnlD
         NuIvwpd8kt/kRI2bBQnCc3VInK9vHaSdv0v4tgUnpJpgPie2NhI61zNXsHV+nBAVrH8s
         y7vQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=KhuPWU8Ck/Zqwd8QYGNbplUi9vy17AnQZagSCJ37QGk=;
        b=boxFOPn6jT4Z0iPbjzj4SyZ5wa9eEGiboe3nTVjHT7KhAGNeocc8CPHEw+1HVHrCgq
         sgq84vgiY3QUAQysbF3o1Hs59TJwoFsqRjtAwlPDX0AmwGYxfqSeBc3bXMPYyZiNOV5t
         5jFo+Nqsamr/RpXNNVJu9Z8Eo+s2MkYOBp3caxEOgnU1gpH4j8nGmhrrVUPnQPucVgci
         r9XDbXGxLXkhuw+x71Cmkz58HGz6bGQ0IAylHMlvIjK0tdtyomnsLj9y8eJeXAaWIxZ0
         X8UPdHmw3XWtfz+udbpKmjG89AODCck1Mo2UwyRu6i2FLIglYy/bXi8C4CBb7azl47aQ
         9NFg==
X-Gm-Message-State: AOAM5332ctY2ed7ZQm03Cv7k9AkWEGP8S2aw7/IKOyCnoLKSDahB77q/
	jtLyqmlY+LJ03WNzvBHywIatVLf54PQ=
X-Google-Smtp-Source: ABdhPJwYOQYW+DLtmEipeBoU8JAOfR2j+jhgl2CJGFYZXuwNwDTvK1p0Ec2CwRYofuAFV0Wcslpcwg==
X-Received: by 2002:ac2:4e95:0:b0:471:ee3b:6534 with SMTP id o21-20020ac24e95000000b00471ee3b6534mr808665lfr.291.1650646285373;
        Fri, 22 Apr 2022 09:51:25 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: [PATCH V1 5/6] xen/grant-dma-ops: Retrieve the ID of backend's domain for DT devices
Date: Fri, 22 Apr 2022 19:51:02 +0300
Message-Id: <1650646263-22047-6-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Use the presence of recently introduced "xen,dev-domid" property
in the device node as a clear indicator of enabling Xen grant
mappings scheme for that device and read the ID of Xen domain where
the corresponding backend resides. The ID (domid) is used as
an argument to the Xen grant mapping APIs.

Also introduce xen_is_grant_dma_device() to check whether xen-grant
DMA ops need to be set for a passed device.

Remove the hardcoded domid 0 in xen_grant_setup_dma_ops().

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V1:
   - new patch, split required changes from commit:
    "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer"
   - update checks in xen_virtio_setup_dma_ops() to only support
     DT devices for now
   - remove the "virtio,mmio" check from xen_is_virtio_device()
   - remane everything according to the new naming scheme:
     s/virtio/grant_dma
---
 drivers/xen/grant-dma-ops.c | 25 ++++++++++++++++++-------
 include/xen/xen-ops.h       |  5 +++++
 2 files changed, 23 insertions(+), 7 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 0e69aa8..70d5d77 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -66,11 +66,6 @@ static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
  * Such a DMA address is formed by using the grant reference as a frame
  * number and setting the highest address bit (this bit is for the backend
  * to be able to distinguish it from e.g. a mmio address).
- *
- * Note that for now we hard wire dom0 to be the backend domain. In order
- * to support any domain as backend we'd need to add a way to communicate
- * the domid of this backend, e.g. via Xenstore, via the PCI-device's
- * config space or DT/ACPI.
  */
 static void *xen_grant_dma_alloc(struct device *dev, size_t size,
 				 dma_addr_t *dma_handle, gfp_t gfp,
@@ -277,6 +272,16 @@ static const struct dma_map_ops xen_grant_dma_ops = {
 	.dma_supported = xen_grant_dma_supported,
 };
 
+bool xen_is_grant_dma_device(struct device *dev)
+{
+	/* XXX Handle only DT devices for now */
+	if (!dev->of_node)
+		return false;
+
+	return of_property_read_bool(dev->of_node, "xen,dev-domid");
+}
+EXPORT_SYMBOL_GPL(xen_is_grant_dma_device);
+
 void xen_grant_setup_dma_ops(struct device *dev)
 {
 	struct xen_grant_dma_data *data;
@@ -288,8 +293,14 @@ void xen_grant_setup_dma_ops(struct device *dev)
 		return;
 	}
 
-	/* XXX The dom0 is hardcoded as the backend domain for now */
-	dev_domid = 0;
+	/* XXX ACPI and PCI devices unsupported for now */
+	if (dev_is_pci(dev) || !dev->of_node)
+		goto err;
+
+	if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) {
+		dev_err(dev, "xen,dev-domid property is not present\n");
+		goto err;
+	}
 
 	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
 	if (!data) {
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 4f9fad5..62be9dc 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { }
 
 #ifdef CONFIG_XEN_GRANT_DMA_OPS
 void xen_grant_setup_dma_ops(struct device *dev);
+bool xen_is_grant_dma_device(struct device *dev);
 #else
 static inline void xen_grant_setup_dma_ops(struct device *dev)
 {
 }
+static inline bool xen_is_grant_dma_device(struct device *dev)
+{
+	return false;
+}
 #endif /* CONFIG_XEN_GRANT_DMA_OPS */
 
 #endif /* INCLUDE_XEN_OPS_H */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:51:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:51:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311118.528206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVF-0007nW-LH; Fri, 22 Apr 2022 16:51:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311118.528206; Fri, 22 Apr 2022 16:51:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwVF-0007nE-Gf; Fri, 22 Apr 2022 16:51:29 +0000
Received: by outflank-mailman (input) for mailman id 311118;
 Fri, 22 Apr 2022 16:51:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hyV/=VA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nhwVD-00064C-NI
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:51:27 +0000
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [2a00:1450:4864:20::135])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7367ed71-c25c-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 18:51:27 +0200 (CEST)
Received: by mail-lf1-x135.google.com with SMTP id br15so894077lfb.9
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:51:27 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 n2-20020a056512310200b0046e2f507a3asm279742lfb.167.2022.04.22.09.51.25
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 22 Apr 2022 09:51:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7367ed71-c25c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=FWaKUpxpKzKjbtSZ6ZKtWz+3C1vj9orKjhUr2xwY4lM=;
        b=hZs3izeCtmtt43a0UNm5IqmPSa6o2CTFdv4hT95HlTt8sq4U8H2GVbe8LO7gpfIx9P
         nUCA0BIFr8bWe4R+3Vx5F5V5bZlcVUxVU6cfKnoKPtW9fYpu4rM0I3NA6A9jDYVP/9eT
         5v6R6JbVvZdOMWrOceZlrUlagLbrTSPHZ85X9eWLHsTTCGbqBvoaWLAPWUgbs6Idby5s
         4LtwH2Lnu3gjEMNKSbuabCyQMifLdMh/r+T6OpIX4rBGG1FX/6XuNg2Nq2vJTPVMJqWK
         NdOH6K0tTIKQxd1NLk5+6LC7bTT/3ZCxi4f0143G79Y5OyjlhU1DkqwMqAELZuYMQgwV
         5rHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=FWaKUpxpKzKjbtSZ6ZKtWz+3C1vj9orKjhUr2xwY4lM=;
        b=QHrDY9ByWpy7nSgRO9MCsHDZRgcnE+2Qk4z4dcZmyuMg57TYzcwm9hzq106MN9jg7U
         Mik5h1dYKluLVepMlcQa/F+W/D9kDcKrAjBGdfKK1oMqsa+s4nblnc2h2cYhnkXieHss
         hoJGIMVRa+llpcp7nY7enJ9vZbDBGJ9OdXeVq3sGfZfl4SPY7K1fI8aCYcWY6QWFkLqj
         g0WDPqylg3LIarYL+7EjScVrXDiejmmF/jMFEOqN06ZzOz3bGwN4TR47q16s7ezLg00u
         Nj78ESvHmcCvHNUckhv1KJjHF/PbtM2k7yN9moWhpqnQAtYxW5z8zo+Szhj4zFVt1oKk
         IsiA==
X-Gm-Message-State: AOAM532KWLwI9s2m3qzoqwacgBsJsizY6Q7DJskvMCUtQ8qhQya9vqd8
	JkB5wu+2JjpW8xjaSBdHEH6KapkHoVw=
X-Google-Smtp-Source: ABdhPJw7+T0P6Ouxeu7dgpNbQZDF5EXBC/YTqVl/e4VxLwsPs+mJYBXNMvJhS0HMKIGJGQ32Omz2oQ==
X-Received: by 2002:a05:6512:3d14:b0:46b:81d9:b9ee with SMTP id d20-20020a0565123d1400b0046b81d9b9eemr3709015lfv.109.1650646286428;
        Fri, 22 Apr 2022 09:51:26 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: [PATCH V1 6/6] arm/xen: Assign xen-grant DMA ops for xen-grant DMA devices
Date: Fri, 22 Apr 2022 19:51:03 +0300
Message-Id: <1650646263-22047-7-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

As the main (and single at the moment) purpose of xen-grant
DMA devices is to enable using virtio devices in Xen guests
in a safe manner, assign xen-grant DMA ops only if restricted
access to the guest memory is enabled.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V1:
   - update commit subject/description
   - remove #ifdef CONFIG_XEN_VIRTIO
   - re-organize the check taking into the account that
     swiotlb and virtio cases are mutually exclusive
   - update according to the new naming scheme:
     s/virtio/grant_dma
---
 include/xen/arm/xen-ops.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
index 288deb1..26954e5 100644
--- a/include/xen/arm/xen-ops.h
+++ b/include/xen/arm/xen-ops.h
@@ -2,12 +2,17 @@
 #ifndef _ASM_ARM_XEN_OPS_H
 #define _ASM_ARM_XEN_OPS_H
 
+#include <linux/virtio_config.h>
 #include <xen/swiotlb-xen.h>
+#include <xen/xen-ops.h>
 
 static inline void xen_setup_dma_ops(struct device *dev)
 {
 #ifdef CONFIG_XEN
-	if (xen_swiotlb_detect())
+	if (arch_has_restricted_virtio_memory_access() &&
+			xen_is_grant_dma_device(dev))
+		xen_grant_setup_dma_ops(dev);
+	else if (xen_swiotlb_detect())
 		dev->dma_ops = &xen_swiotlb_dma_ops;
 #endif
 }
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:54:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:54:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311143.528221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwXw-0002Mu-A1; Fri, 22 Apr 2022 16:54:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311143.528221; Fri, 22 Apr 2022 16:54:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwXw-0002Mm-6Q; Fri, 22 Apr 2022 16:54:16 +0000
Received: by outflank-mailman (input) for mailman id 311143;
 Fri, 22 Apr 2022 16:54:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhwXu-0002MU-Uu; Fri, 22 Apr 2022 16:54:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhwXu-0006Gy-UA; Fri, 22 Apr 2022 16:54:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhwXu-0006zx-J1; Fri, 22 Apr 2022 16:54:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhwXu-0008QG-Ia; Fri, 22 Apr 2022 16:54:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iJhP9DscZO+z1X8t6JXsIVUCokhUqWKnAWgEwCbnhgI=; b=I1QDmB1u7ZVKSj5MLYBTLLkKpE
	CdZgx19UdbI/OhE+aea0dzLtB3uzbwUr8O1f1TuA0eSiS0xBAE6bPjgsy2St7e9I1HHvzmWfDtyfF
	ZAqR6FH0n7hruOnR/TWryvIPsXYWjaCxe+dfD/hfTf3ZVFRiVxtN2z0Alb9gzwQKLMrk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169626-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169626: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=ee582858c4f43c63a1566f0c1c0aa8ace0e4a79c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 16:54:14 +0000

flight 169626 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169626/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 ee582858c4f43c63a1566f0c1c0aa8ace0e4a79c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  557 attempts
Testing same since   169626  2022-04-22 15:42:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5675 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:57:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:57:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311150.528232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwbI-00030H-RT; Fri, 22 Apr 2022 16:57:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311150.528232; Fri, 22 Apr 2022 16:57:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwbI-00030A-N5; Fri, 22 Apr 2022 16:57:44 +0000
Received: by outflank-mailman (input) for mailman id 311150;
 Fri, 22 Apr 2022 16:57:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=utlT=VA=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nhwbH-000304-SY
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:57:43 +0000
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com
 [2a00:1450:4864:20::12e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5355c0ee-c25d-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 18:57:42 +0200 (CEST)
Received: by mail-lf1-x12e.google.com with SMTP id x33so15334909lfu.1
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:57:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5355c0ee-c25d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=rfdHOxkpzIyt1O/sX3V/T6aR7Ux9FcCSbdpHX3js2OU=;
        b=WAYfJQLjb3sTDCqrFB0VW4kqmwqn97Yeu5kzjRnCm+2Gv2qKu6syDVAr2V72gwrewj
         hPCu4oTnx0PU2kXbeIiDfaJsv90wFU/H2OH8cQM7IZQvKnPugkS4yvB5Q/VYBkCsUVQo
         CQ8Uzp6aIh219QlQXFqXZRArwFn/s7O421TQ2suIAKnFlhA2E1yz9MZEOQ4kmk0wuktT
         CkWdYsnRjJxCTieIFKIdj97cok4hKG2B+8xT+GRPoEW+/+jMfjL1NSDZOLqCvAWWPaDf
         JKRAX/b8W5eeTOec/XEU2IPph8EGuq5Foazy+EP6uUnZjH84TL0ZMqwFT+UMyF/psnYI
         Nn/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=rfdHOxkpzIyt1O/sX3V/T6aR7Ux9FcCSbdpHX3js2OU=;
        b=UDp/AXR4OXNpfeQWgiVi69IoSKnnuzO5gz5pF/GPM4fubAv/JGTGjWce+Q8W9tTiDu
         Gb3SfxhIDo90f1dmJ6jmPx/SiG2QIhbnytFsXwNP+0UbmqYppeNh0BztF5047+AOEigV
         CH0w12Sv3yv8RhaKbS6Q48xWe3HSs+ZuJPHn/KGYcpqyNPjCE3r6U091x+gz/hbCZrsX
         5l0gRDOF6YGGH8CnSR56PDqhSd0gVIa/Ac2/Rp01b95ugjyrL2Cm5jET4msujkYLm59t
         yoYsDjaxBAvUzHrQH01/8rjcHI+D3exkadweJTUtjxnwaa/m+WYakkp2Pcm6A7r1e6oO
         JGOA==
X-Gm-Message-State: AOAM530U9cpq28Nds3HFDtszg+5RdePeu7w3/Vs8/sn4HRPjvAHJPFc2
	ZZ0RgexO+ELW0kp7N4whkg7pU/9i9Kv8b8it0Y4=
X-Google-Smtp-Source: ABdhPJyKUI8VrLLD4c5ypJBtzNyGAJneEOLHkcLQgVc49JQ5pnYxCLmoRHNxMLl8AbjiPXQPT+r4k6PaxWsvAVOWe5Q=
X-Received: by 2002:a05:6512:e83:b0:46f:cc1c:a7b1 with SMTP id
 bi3-20020a0565120e8300b0046fcc1ca7b1mr3751450lfb.388.1650646662315; Fri, 22
 Apr 2022 09:57:42 -0700 (PDT)
MIME-Version: 1.0
References: <20220422163458.30170-1-dpsmith@apertussolutions.com> <20220422163458.30170-2-dpsmith@apertussolutions.com>
In-Reply-To: <20220422163458.30170-2-dpsmith@apertussolutions.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Fri, 22 Apr 2022 12:57:30 -0400
Message-ID: <CAKf6xptd7BD4R818q9SpQryn2X_E0PH8LONrjifOw6VK3AikPg@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote
 after setup
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>, 
	Scott Davis <scott.davis@starlab.io>, Stefano Stabellini <sstabellini@kernel.org>, 
	Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>, Dario Faggioli <dfaggioli@suse.com>, 
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 22, 2022 at 12:35 PM Daniel P. Smith
<dpsmith@apertussolutions.com> wrote:
>
> There are now instances where internal hypervisor logic needs to make resource
> allocation calls that are protected by XSM checks. The internal hypervisor logic
> is represented a number of system domains which by designed are represented by
> non-privileged struct domain instances. To enable these logic blocks to
> function correctly but in a controlled manner, this commit changes the idle
> domain to be created as a privileged domain under the default policy, which is
> inherited by the SILO policy, and demoted before transitioning to running. A
> new XSM hook, xsm_set_system_active, is introduced to allow each XSM policy
> type to demote the idle domain appropriately for that policy type.
>
> For flask a stub is added to ensure that flask policy system will function
> correctly with this patch until flask is extended with support for starting the
> idle domain privileged and properly demoting it on the call to
> xsm_set_system_active.
>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>

Reviewed-by: Jason Andryuk <jandryuk@gmail.com>


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 16:58:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 16:58:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311155.528242 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwbn-0003ZZ-7A; Fri, 22 Apr 2022 16:58:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311155.528242; Fri, 22 Apr 2022 16:58:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhwbn-0003ZS-4E; Fri, 22 Apr 2022 16:58:15 +0000
Received: by outflank-mailman (input) for mailman id 311155;
 Fri, 22 Apr 2022 16:58:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=utlT=VA=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nhwbl-000304-MQ
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 16:58:13 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 654cfaa2-c25d-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 18:58:13 +0200 (CEST)
Received: by mail-lf1-x134.google.com with SMTP id y32so15325770lfa.6
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 09:58:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 654cfaa2-c25d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=hu+6brSl+lbKFssBircurUAEc3KTJPIkkXnWXDJ1yJA=;
        b=gkfnjgEEQAQFsZ/bHsti7D5TBXQKzWSOEPry/iP7SuxVOWkPCbnfCj9UWmzOJ8hxeY
         vmRRXhFegzU3n20TZDnt/F11tHveODoxkg1wCm1bjLdgoP82BXuaoue0umoueZWTR7cK
         /8eDgEpT5IIgGDWrqCM9Y8AvmhAmS4Lsu4cw/5J5+V3/mbsf+WlPSYl5QJtBNZDAvjo/
         qQmHeupjJrDQBSK82g4bqyh2vYrE6FXLPU2GgA6QP63hNj7hm3GLECBeNECFIUTz23i1
         cGOse6BLHlQ+3qNSJKC4YDarLQWOT/ayvkaond49dhfbN9P9ZhIoj6SlGWNMkl2ykDTb
         Aa5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=hu+6brSl+lbKFssBircurUAEc3KTJPIkkXnWXDJ1yJA=;
        b=E/atkLbbkmsqUrM0iDWWnhbpzEsmHB42ysMJCIhx6Q20ojNUbkWm/5ofT0QyHzM711
         fM6j0JWHGSwPClYKYVMpJtMOd08CTMlyaaKQkeeZIeVih9LYBMQyZl+1sOFYZyx+Yyj5
         O+Pz3yiUzb14ET/i5eN/1k+FLxny7NFLTfheIMTfqBSS9yM0ZlNTe1JtfpAxO7zp7PKu
         Utry7If96BYB0SuWSrx4lWqHxfx8re39JW1zS0U8o1FQLUXerqTwjHCCTBG2cW5Wda30
         FKvGU5hRB1PBj92wJPFGUi7vDdY6xGq5h36uzxcs0lENVj+E4WCbz65qKv8X7BrK3QkL
         gVIg==
X-Gm-Message-State: AOAM531peF4Tglk/ijmAh+f8ExtPgBdYwju/MK8z7dP1nhrExA9WhPNJ
	MuFUJePQ9eHuMJX94pITnBxAEjNU9hdlDJX8cQI=
X-Google-Smtp-Source: ABdhPJxPL65bRGUvJUBQvYuIRVz4ox6BMZYXRsWKIi9dVX5ifRXRsO9J73RKC7H4xCXCtZN6f7ZzqtMdTuO/8tb4eFQ=
X-Received: by 2002:a05:6512:11cc:b0:44a:5770:7425 with SMTP id
 h12-20020a05651211cc00b0044a57707425mr3560614lfr.406.1650646692701; Fri, 22
 Apr 2022 09:58:12 -0700 (PDT)
MIME-Version: 1.0
References: <20220422163458.30170-1-dpsmith@apertussolutions.com> <20220422163458.30170-3-dpsmith@apertussolutions.com>
In-Reply-To: <20220422163458.30170-3-dpsmith@apertussolutions.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Fri, 22 Apr 2022 12:58:01 -0400
Message-ID: <CAKf6xptRBMwjrE_m+rQEoS+ZoC=7qFO+NGg3eUQYuC6x66Uauw@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] flask: implement xsm_set_system_active
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Scott Davis <scott.davis@starlab.io>, 
	Daniel De Graaf <dgdegra@tycho.nsa.gov>, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 22, 2022 at 12:35 PM Daniel P. Smith
<dpsmith@apertussolutions.com> wrote:
>
> This commit implements full support for starting the idle domain privileged by
> introducing a new flask label xenboot_t which the idle domain is labeled with
> at creation.  It then provides the implementation for the XSM hook
> xsm_set_system_active to relabel the idle domain to the existing xen_t flask
> label.
>
> In the reference flask policy a new macro, xen_build_domain(target), is
> introduced for creating policies for dom0less/hyperlaunch allowing the
> hypervisor to create and assign the necessary resources for domain
> construction.
>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> ---

> @@ -188,8 +188,12 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>
>  static int cf_check flask_set_system_active(void)
>  {
> +    struct domain_security_struct *dsec;
>      struct domain *d = current->domain;
>
> +    dsec = d->ssid;
> +    ASSERT( dsec->sid == SECINITSID_XENBOOT);

Extra space before dsec.

With that fixed,
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 18:13:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 18:13:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311172.528253 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhxmS-000524-N8; Fri, 22 Apr 2022 18:13:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311172.528253; Fri, 22 Apr 2022 18:13:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhxmS-00051x-KG; Fri, 22 Apr 2022 18:13:20 +0000
Received: by outflank-mailman (input) for mailman id 311172;
 Fri, 22 Apr 2022 18:13:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhxmR-00051n-FE; Fri, 22 Apr 2022 18:13:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhxmR-0007g4-70; Fri, 22 Apr 2022 18:13:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nhxmQ-0003Bv-R1; Fri, 22 Apr 2022 18:13:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nhxmQ-0001j0-QY; Fri, 22 Apr 2022 18:13:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=if4oQhT96JXWvztgvz0K005t87IHuJiFrUi4DiWYfNo=; b=bwwF95un7vTpKlKteb59X8Md7P
	NWjSvafZ8WA1P1tW7sk6SKWKJKWjSEV9QadK0n6unHookp8sBYrY6SDvNrI6qZjyWDiHtouhbflov
	oi9t4QJHzAgxNj3fdrNZa49jvT0aNGX75BTCbyNkVILf2srjAtoOgSTDpfUdm7aefjaQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169614-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169614: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=a74782936dc6e979ce371dabda4b1c05624ea87f
X-Osstest-Versions-That:
    qemuu=378f973a6ce89de16496bc6007f4dffa2f881dbc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 18:13:18 +0000

flight 169614 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169614/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 169603
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169603
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169603
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169603
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169603
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169603
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169603
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169603
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                a74782936dc6e979ce371dabda4b1c05624ea87f
baseline version:
 qemuu                378f973a6ce89de16496bc6007f4dffa2f881dbc

Last test of basis   169603  2022-04-21 22:39:32 Z    0 days
Testing same since   169614  2022-04-22 09:11:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cleber Rosa <crosa@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eduardo Habkost <eduardo@habkost.net>
  Fam Zheng <fam@euphon.net>
  Hanna Reitz <hreitz@redhat.com>
  John Snow <jsnow@redhat.com>
  Luiz Capitulino <lcapitulino@redhat.com>
  Peter Xu <peterx@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Tomoaki Kawada <i@yvt.jp>
  Yoshinori Sato <ysato@users.sourceforge.jp>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   378f973a6c..a74782936d  a74782936dc6e979ce371dabda4b1c05624ea87f -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 18:50:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 18:50:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311180.528265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhyM4-0001QN-Jo; Fri, 22 Apr 2022 18:50:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311180.528265; Fri, 22 Apr 2022 18:50:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhyM4-0001QG-Ew; Fri, 22 Apr 2022 18:50:08 +0000
Received: by outflank-mailman (input) for mailman id 311180;
 Fri, 22 Apr 2022 18:50:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhyM2-0001Iq-8K
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 18:50:06 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 046af9ff-c26d-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 20:50:04 +0200 (CEST)
Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 14:50:01 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BL0PR03MB4244.namprd03.prod.outlook.com (2603:10b6:208:6b::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 18:49:59 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 18:49:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 046af9ff-c26d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650653404;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ku9iOS7qDiztKx5YVvBRja3pzeOHCfJTACA0ZiezsS8=;
  b=GUvzgPdzO/ex2kdF7QervxZAAv83wBaKhA65OHg3newrlWWJdHSf1mU/
   gPL5GfquBXNtLs79JCWuzDKuKvjf/bAA/JQOdfQ7hU/BvMCbUoCS2Aa1F
   UMh4zF8ZDv3RwnAVUEFtMt41NO8gk099aeAqSPdQynMn/fBugYnOJ6DTO
   o=;
X-IronPort-RemoteIP: 104.47.70.102
X-IronPort-MID: 69129382
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:oVT8BqNMZ9ttEhfvrR3WlsFynXyQoLVcMsEvi/4bfWQNrUol1GdUn
 2AZXTiCMvyDamSjfY1zbIq1oUoGvMPUmN5rHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NQw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 vpz5aydVwQVD4rNorkAdxRRNTB/IvgTkFPHCSDXXc276WTjKiOp6dMxSUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB5GdaaG/+iCdxwhV/cguhnG/rEa
 tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2MJ8QjE/vpti4TV5CFc9eTUaMrlQcODQeVQokqW/
 Uf/xE2sV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL
 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJt//YS7QiMzu/e5VmfD21dFjpZMoV+7okxWCAg0
 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSsZZUvWd9enM/
 g23
IronPort-HdrOrdr: A9a23:Ul9vcKPFLk9OSMBcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM
 tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH
 Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u
 Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP
 hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/
 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ
 CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY
 fHBK5r
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="69129382"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mSPzWISr1/bPwzdLT41sDLuGv5OU2sX0+uM7sEBPxzHT+PHZkt04u55BG17ie/4eOatlj632lKvzUfE6juiYdGLogXPmX0BTY+OIChTCwUu6F1+nj3nq7KOfDMBEo2mt2M6KKjW8OOBhKool6nNROuhcVF5F3Yi3C9Z7pUgieTEGaTORqN1D0m3WcP+RJiR2il5PG8bMCcmoYkPSnOfMv8lHmvnb0gcTmKY/48/WiJ4Q/kO+STOY9fkWFc7GfB7yeh9HXQl3ej4G8klE2UPifI07upgXh+Z0uXk2Z92fE/pD8945uQRcX8TWtW1k+/8jWURhZbgi2ubLIxno7JdjbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ku9iOS7qDiztKx5YVvBRja3pzeOHCfJTACA0ZiezsS8=;
 b=Wei6+WGhHoJgYX3E8YaE4pct5UUYpa7ZAjGZHpZciFH+PPt/QZosYFUw0H9iQ63nBNPWi3WkcLLR1pMo7f0/bxcbMv9iqT4JSju7sFM6cKFc2egu2FdUGeGrhg633BPfsaIemyVoyM+Q7npI/ZyPGYtY23+bPD3d3nXy8ucaJuX+1gQ1Lxq6TPxM8Pdm0zlfWa6PwSn/Qh6R6nUKHXkPlocT0lDgOiwc40oKHuRVK6YAGAc+XAOn7gECv8kW0KZLAGS7iqshEdb+S6yrfya1gW24rXAvCsuf87ByivXa/441O90bYy7yGy+1mQrnhMrE1suuloeJsLsM+4MBENsUyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ku9iOS7qDiztKx5YVvBRja3pzeOHCfJTACA0ZiezsS8=;
 b=HJFEGObeVpdD9GLa7lfjxDYTw6q+fSLJ4Bkys8h55shvvJ5v/qhnkLMXQJS0cLx2Br4VuUztFavTuV+KZSoSg8byn7d8Iia4yDk/eUZ+2yNcQ41jUUl1ZfZV4E26i8z4fATauXc0RMO6hLfCh8/7xl35v1Rs8oJNmTnSz1OTAc0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM
 guests
Thread-Topic: [PATCH v3 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM
 guests
Thread-Index: AQHYROG7H4IUo8Py9UONHlhaTBRq8az8acKA
Date: Fri, 22 Apr 2022 18:49:57 +0000
Message-ID: <9f510109-df45-af7d-1c0a-49ef435e371f@citrix.com>
References: <20220331092717.9023-1-roger.pau@citrix.com>
In-Reply-To: <20220331092717.9023-1-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fead6591-6893-4d63-100a-08da2490e5fd
x-ms-traffictypediagnostic: BL0PR03MB4244:EE_
x-microsoft-antispam-prvs:
 <BL0PR03MB4244F935A342CB548B3CE491BAF79@BL0PR03MB4244.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 ggMnIGpiwzVgFKnYlHD3tsBDpOlJofMC0pgK6vSN6VIL77NWps+WsdvBXeY1o3XSeW67ZjKMVEE1edeSc7VVM1XZbBKofM5KhhN3WPa9pB2FAefJYVY2TGywr/VRZ5oa4r3rubY+eeM/tN2A+xbp3D2innduDjqm1FSe0XWGSNtjaX/2FXtobxG+UbgaFhAYTSuqR3BpaY0fZAmEUQ2eg64Q2K6YDFKwpMqSa1kish0vpiHC/bgl2p8SxLl8iB7YWXn16vjlwCZ+3v0oZbj1udtOrACVjiulmM1LTZRx2U4L+PkRX9bbWnN3kGu+GLSTWvkk90EhSLq+VEPml60UU8CovDUdX5PiC1Z+aouJLRZMb9jHjRjps5eBSchzT66t/P6lSr+F9CrHiuVeU7RhLipHwqGlk2bVC2/uu8pbokD47gMUkSwdCBp+6UICA94HKiBg06oqm9eAjRKYdyW8NEXE2a5llYOdIm3zDDM6yYvB5dqiyE+fDUvRhAEACP4M9yhMnTjFwcjzH1YbilO15vF56mAVCLMPxjwFrKihCnqTq+zUm00tgOphBO547xfQuFvD6sKnxPUykk4qyaHIaP6zEhPPsy/aaiXPvb3srzSYXzaNU+GAQeicgvCFabPAL4K86mGw1FdP8Paa4fbLuxxxyDjxNotV8TajAlMdHSVP4gCT1kxd+jR2s7lUz3FbaesxA5jhct+yR4b8gROh+LKN/62z/2v34SrC3qkC1LUnB0yAo5tXvtZfWu6AfuQWKXqVWqVkrTh4lNBVmgSmcw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8676002)(26005)(71200400001)(64756008)(66446008)(66476007)(66556008)(76116006)(8936002)(66946007)(91956017)(508600001)(5660300002)(31696002)(86362001)(6486002)(38100700002)(38070700005)(82960400001)(122000001)(6512007)(186003)(83380400001)(53546011)(2906002)(2616005)(6506007)(110136005)(31686004)(36756003)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bzByendPU01CRzU1UGU3V3FPbERNaTJkaWVpRXd1Y3I3T2hBM25USnUxbVdr?=
 =?utf-8?B?eks0N1lJZGlTaUZJZy9SZ1ZESFhmN2FFMU5vSVVvWC9PNFh6cEphZ2N6VjZT?=
 =?utf-8?B?ZW44blc1UkxyRmt0UWNTQm5nTzRwTjl5QWk3NHBxVWtOTDQ1UmFjMmc2b2xD?=
 =?utf-8?B?Ull6VmV2Rlo2OWI4WW53TEs3U2pyV1ZRaG5hWDhZUHlUdTRmYk1HZENwVUwy?=
 =?utf-8?B?eCsxSEliMHVidzkrWjh3cTZwT2NDMFNkRmFxOVp3UC9yZVl3WHAyaGs1RkNZ?=
 =?utf-8?B?TlRFN2FSbzJWc2dnNDBMSm1nTDg5VWNXYzZLaTN3a3Vtd2h2UGpOVXU1cndX?=
 =?utf-8?B?MnVvUy9XODlMZzZKTEpHc2RaSm5ZMVVmdVhPdGs0UXdaUGkxQWwxdnBkZlVK?=
 =?utf-8?B?QmVGcDlrc0J4ejY5dmh4a0UwbWNJVG5GVHJrNUZYcVU3YUpVOCtvQzBjM0Jz?=
 =?utf-8?B?VFlnOUF0ZGZTcXNGY296a0Q0d0VFdjlxZmFxdWR6cENSSEJuSjBhTlpLV1Jq?=
 =?utf-8?B?QXU2U01vQ3A4cGN4clZYR3NGT05kUEhYM05zL294Z0RENVlMUzZJYzJ0cDJD?=
 =?utf-8?B?aUxNeURhc3gvV29jV3JpQ04zaG1mMzFHMHUzZDU3Nkp4REhObU1VNHFpaGRK?=
 =?utf-8?B?d010WkMxQytUS0NOczgwWnlGZVlyYkxCeHB3TDVMSFBQRHJwV3hPcTBzR0Y4?=
 =?utf-8?B?ZlZvT2FBUTFSaUErOTNPWVRBNFZiSFJRR09HbUUvN3daVUNFdWFSMjNSc2k1?=
 =?utf-8?B?QTdSRnY5LzhaYi9TZ2U0SHprVXZ3UGROZ0twK2JoMlBteXE2MlU0SnBDMGZV?=
 =?utf-8?B?REUxb1NQQVlSSjMyZ3ZaV3pqaW9iZWljRU50dkt0a3VRWFg0d08wZEZMZ2Q1?=
 =?utf-8?B?UmRkbFNsVjlveDVsTFlmRlhDSXRUU0M0YnVjQmlRci8zdnE2enlMQ0JVNURN?=
 =?utf-8?B?SDd4dXBpcTRhYjlqazAvRnRmUVlnSm1DME5pVXFWaXpmNVFmQXMyNXBVTkZs?=
 =?utf-8?B?ZVg1dGY3UnpxaFAxTEFHT2NlYm9VYUo3NkM5aEZyU2RjU0oxazJ2bmkxSnEx?=
 =?utf-8?B?SUI2ZndLTm1ucTVLcnc3S2RBM1RueHExaVRiSExvUHpqZHp1MElMa2xsKzh6?=
 =?utf-8?B?bzVjdHNWNEs0cGcxSUZxeTNreDlKZUtzL0JCQlBlbFI1S0VmcEVVRHZVM3lJ?=
 =?utf-8?B?Z0wweTlGaHY4aWM0T3JTeVgxQVgxTldBWHkvUzNWeDFjYTR1OFdYQ0swTC9X?=
 =?utf-8?B?aG5zdVRDbGhrNWx5SE1PNGNNY0QzM2Nxa2p2Z242L3RJUWIzV25tWUQ1YzZV?=
 =?utf-8?B?NHF1RTdPdjkxUnZBNi8zTURreXNzQk9lSy9BSGVxcWdjM0FOTTV4QjYzUU95?=
 =?utf-8?B?WEJQd3IrWFhOVHhjeFhIWWhvY1paOWZmNStpK0xyUWZIcm9lc1RmU1R3QkJF?=
 =?utf-8?B?R3A2VW56bFFyWWRnNCttbWhMRFJ6c0JGU2FhZENGVEU4ZGMyaHo4emErbkZw?=
 =?utf-8?B?b3RPemY0NmxLY3o4R3FDKzBkdnNuQlpaS09qRGhUeGVIOXBrdkZjQ1FTTFVN?=
 =?utf-8?B?UU1BWjVDZmhPWUhJcVB3MWRNWVRZOFhQZ0NmSTJ1Q2FlZmdUQ2dmRFhzM0dv?=
 =?utf-8?B?ZFRHU043NWFPWDdOSUk2UTFZRFBPdjBNVXFqR3AwcnpvbVZoVllXMXJtaE1T?=
 =?utf-8?B?Ym9lNkVvUzVWdkhNS20vZlRqVG55UFdOMmN1TlJIZDlvSHFiYnRacXhwNzlm?=
 =?utf-8?B?VmcvNWhBUlU1cnlzVzFpVlY2K2lLbHNLTW1na0M0aVpCNUo5T3RlVEl0UHF6?=
 =?utf-8?B?LzN2YktEdnBrRkRMRk5scldMbFZ3MzBpb0JGMFpSQmx5NVp4b1FSbmNxRzRZ?=
 =?utf-8?B?WW5rdGhNSHRybDE2N2RGeEJ1cWhwTE5ucUlTVWtCTXV1UGp5bkpVckdoNy9V?=
 =?utf-8?B?VXpmL2t3OCswZHRzUXo5b2V4c0o0SGlBNk5JeklTZGFFWFhYRlF6MS9qNkpI?=
 =?utf-8?B?aUc1N3FWNmp0Q08zYVUvOGFUeSszRTdwd0hhWkVSamZhM3JoNzZCZ0MyNzZP?=
 =?utf-8?B?c0VLOFVkUk5HREVkT3BnZHZ5S0JpQjlBNUFZV01BQ1dxUWFvQXlIcVNqODYy?=
 =?utf-8?B?bHV4NCtrYzI0WG9NOG4yeTBuV3F3RHAzbXg1M3ZTTjlydEVTTlVqOFdTbHFs?=
 =?utf-8?B?SVVsT05tazZxVDVSVGRJY3ZSWHRmSEx2L2xYaWIvUmg5QmduMndXbk5ETVo4?=
 =?utf-8?B?L0VLT3BXYmwwUWdVVTVyTUlBMFRTVXJ0Y3l4ZTFac0tTdEJGTGlQUlNDc3hG?=
 =?utf-8?B?d2wzYjhZdW1HL1dCNmJtbTBlNjhmUC8yVGREakZxay9PQ3FLWVBCZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0281D12324C2E148A484F96D7A035571@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fead6591-6893-4d63-100a-08da2490e5fd
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 18:49:57.8179
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oyuHtCMYwkh91f665JfRrEJFBpcvzmiyYz/B7pwqkZfzQNvJALPHvzfabJfpab2j1pGjj3XDQiCToAOnTNnvti7Ac/3sNUeVu6v8dyMMrfk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4244

T24gMzEvMDMvMjAyMiAxMDoyNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBIZWxsbywNCj4N
Cj4gVGhlIGZvbGxvd2luZyBzZXJpZXMgaW1wbGVtZW50cyBzdXBwb3J0IGZvciBNU1JfVklSVF9T
UEVDX0NUUkwNCj4gKFZJUlRfU1NCRCkgb24gZGlmZmVyZW50IEFNRCBDUFUgZmFtaWxpZXMuDQo+
DQo+IE5vdGUgdGhhdCB0aGUgc3VwcG9ydCBpcyBhZGRlZCBiYWNrd2FyZHMsIHN0YXJ0aW5nIHdp
dGggdGhlIG5ld2VyIENQVXMNCj4gdGhhdCBzdXBwb3J0IE1TUl9TUEVDX0NUUkwgYW5kIG1vdmlu
ZyB0byB0aGUgb2xkZXIgb25lcyBlaXRoZXIgdXNpbmcNCj4gTVNSX1ZJUlRfU1BFQ19DVFJMIG9y
IHRoZSBTU0JEIGJpdCBpbiBMU19DRkcuDQo+DQo+IFhlbiBpcyBzdGlsbCBmcmVlIHRvIHVzZSBp
dCdzIG93biBTU0JEIHNldHRpbmcsIGFzIHRoZSBzZWxlY3Rpb24gaXMNCj4gY29udGV4dCBzd2l0
Y2hlZCBvbiB2bXtlbnRyeSxleGl0fS4NCj4NCj4gT24gWmVuMiBhbmQgbGF0ZXIsIFNQRUNfQ1RS
TC5TU0JEIGV4aXN0cyBhbmQgc2hvdWxkIGJlIHVzZWQgaW4NCj4gcHJlZmVyZW5jZSB0byBWSVJU
X1NQRUNfQ1RSTC5TU0JELsKgIEhvd2V2ZXIsIGZvciBtaWdyYXRpb24NCj4gY29tcGF0aWJpbGl0
eSwgWGVuIG9mZmVycyBWSVJUX1NTQkQgdG8gZ3Vlc3RzIChpbiB0aGUgbWF4IENQVUlEIHBvbGlj
eSwNCj4gbm90IGRlZmF1bHQpIGltcGxlbWVudGVkIGluIHRlcm1zIG9mIFNQRUNfQ1RSTC5TU0JE
Lg0KPg0KPiBPbiBGYW0xNWggdGhydSBaZW4xLCBYZW4gZXhwb3NlcyBWSVJUX1NTQkQgdG8gZ3Vl
c3RzIGJ5IGRlZmF1bHQgdG8NCj4gYWJzdHJhY3QgYXdheSB0aGUgbW9kZWwgYW5kL29yIGh5cGVy
dmlzb3Igc3BlY2lmaWMgZGlmZmVyZW5jZXMgaW4NCj4gTVNSX0xTX0NGRy9NU1JfVklSVF9TUEVD
X0NUUkwuDQo+DQo+IE5vdGUgdGhhdCBpZiB0aGUgaGFyZHdhcmUgaXRzZWxmIGRvZXMgb2ZmZXIg
VklSVF9TU0JEIChpZTogdmVyeSBsaWtlbHkNCj4gd2hlbiBydW5uaW5nIHZpcnR1YWxpemVkIG9u
IDwgWmVuMiBoYXJkd2FyZSkgYW5kIG5vdCBBTURfU1NCRCBYZW4gd2lsbA0KPiBhbGxvdyB1bnRy
YXBwZWQgYWNjZXNzIHRvIE1TUl9WSVJUX1NQRUNfQ1RSTCBmb3IgSFZNIGd1ZXN0cy4NCj4NCj4g
U28gdGhlIGltcGxlbWVudGF0aW9uIG9mIFZJUlRfU1NCRCBleHBvc2VkIHRvIEhWTSBndWVzdHMg
d2lsbCB1c2Ugb25lIG9mDQo+IHRoZSBmb2xsb3dpbmcgdW5kZXJseWluZyBtZWNoYW5pc21zLCBp
biB0aGUgcHJlZmVyZW5jZSBvcmRlciBsaXN0ZWQNCj4gYmVsb3c6DQo+DQo+ICAqIFNQRUNfQ1RS
TC5TU0JELiAocGF0Y2ggMSkNCj4gICogVklSVF9TUEVDX0NUUkwuU1NCRCAodW50cmFwcGVkKS4g
KHBhdGNoIDIpLg0KPiAgKiBOb24tYXJjaGl0ZWN0dXJhbCB3YXkgdXNpbmcgTFNfQ0ZHLiAocGF0
Y2ggMykNCj4NCj4gVGhpcyBoYXMgc3Vydml2ZWQgYSBYZW5SVCBiYXNpYyBzZXQgb2YgdGVzdHMg
b24gQU1EIG1hY2hpbmVzLg0KDQpTb3JyeSBmb3IgdGhlIG1peGVkIGZlZWRiYWNrLCBidXQgc29t
ZSBpcyBhcHBsaWNhYmxlIGFjcm9zcyBtdWx0aXBsZQ0KcGF0Y2hlcy4NCg0KRmlyc3QsIGl0IGlz
IGltcG9ydGFudCB0byBrbm93IHdoeSBNU1JfVklSVF9TUEVDX0NUUkwgZXhpc3RzLCBiZWNhdXNl
DQp0aGF0IGluZm9ybXMgd2hhdCBpcywgYW5kIGlzIG5vdCwgc2Vuc2libGUgdG8gZG8gd2l0aCBp
dC4NCg0KSXQgZXhpc3RzIHRvIGJlIGEgRk1TLWludmFyaWFudCBhYnN0cmFjdGlvbiBvZiB0aGUg
REVfQ0ZHIGludGVyZmFjZSwNCmVtdWxhdGVkIGJ5IHRoZSBoeXBlcnZpc29yLsKgIEF0IHRoZSB0
aW1lLCB3ZSBleHBlcmltZW50ZWQgd2l0aCBlbXVsYXRpbmcNCk1TUl9TUEVDX0NUUkwgZGlyZWN0
bHksIGJ1dCB0aGUgcmVzdWx0cyB3ZXJlIHVudXNhYmxlIHNsb3cgKGxlZ2FjeSBJQlJTDQpjYXVz
aW5nIGEgdm1leGl0IG9uIGV2ZXJ5IHN5c2NhbGwvaW50ZXJydXB0IGVudHJ5JmV4aXQpIHNvDQpN
U1JfVklSVF9TUEVDX0NUUkwgaXMgYWxzbyBhbiBleHBsaWNpdCBzdGF0ZW1lbnQgdGhhdCBpdCBp
cyBhbiBleHBlbnNpdmUNCm9wZXJhdGlvbiBhbmQgc2hvdWxkbid0IGJlIHVzZWQgZnJlcXVlbnRs
eS4NCg0KSW4gcHJhY3RpY2UsIHRoaXMgbWVhbnMgIm9ubHkgZm9yIHZlcnkgdmVyeSBpbXBvcnRh
bnQgcHJvY2Vzc2VzLCBhbmQgbm90DQp0byBiZSB1c2VkIG1vcmUgZnJlcXVlbnRseSB0aGFuIHBy
b2Nlc3MgY29udGV4dCBzd2l0Y2giLsKgIEFsc28sIHRoZXJlIGlzDQpubyBoYXJkd2FyZSB3aGlj
aCBpbXBsZW1lbnRzIE1TUl9WSVJUX1NQRUNfQ1RSTCwgbm9yIHdpbGwgdGhlcmUgYmUuDQoNClBh
dGNoIDIgaGFzIGFkZGVkIGFuIGV4dHJhIHR3byB2bWV4aXRzIGFyb3VuZCBlYWNoIHZtZXhpdCwg
aW4gYW4gZWZmb3J0DQp0byBsZXQgTDIgdm1leGl0IHRvIEwwIHJhdGhlciB0aGFuIEwxIGZvciB3
aGF0IGlzIGxpa2VseSB0byBiZSAwIHRpbWVzDQppbiBhbiBMMSB0aW1lc2xpY2UuwqAgSXQncyBu
b3QgYSBjcmVkaWJsZSBvcHRpbWlzYXRpb24sIGZvciBzb21ldGhpbmcNCndoaWNoIGlzbid0IGEg
cHJvZHVjdGlvbiB1c2VjYXNlLsKgIFllcyAtIG5lc3RlZCB2aXJ0IGRvZXMgZXhpc3QsIGFuZCBp
cw0KdXNlZnVsIGZvciBkZXYsIGJ1dCBub29uZSBydW5zIGEgZnVsbHkgZmF0IHNlcnZlciB2aXJ0
IGh5cGVydmlzb3IgYXQgTDENCmluIHByb2R1Y3Rpb24gaWYgdGhleSBjYXJlIGluIHRoZSBzbGln
aHRlc3QgYWJvdXQgcGVyZm9ybWFuY2UuwqAgRWl0aGVyDQp3YXksIHBhdGNoIDIgaXMgcHJlbWF0
dXJlIG9wdGltaXNhdGlvbiB3aXRoIGEgbWFzc2l2ZSBjb21wbGV4aXR5IGNvc3QuDQoNCkZ1cnRo
ZXJtb3JlLCB3cml0ZXMgdG8gTFNfQ0ZHIGFyZSBhbHNvIGluY3JlZGlibHkgZXhwZW5zaXZlLCBl
dmVuIGlmDQp5b3UncmUgbm90IGNoYW5naW5nIGFueSBiaXRzLsKgIFRoZSBBTUQgcmVjb21tZW5k
ZWQgYWxnb3JpdGhtDQpzcGVjaWZpY2FsbHkgYXZvaWRzIHJld3JpdGluZyBpdCB3aXRoIHRoZSBz
YW1lIHZhbHVlIGFzIGJlZm9yZS4NCg0KQW5vdGhlciB0aGluZyBpcyB0aGF0IFhlbiBzaG91bGRu
J3QgdG91Y2ggTFNfQ0ZHIGxpa2UgdGhpcyBpZiB0aGVyZSBpcw0KYW55IGhpbnQgb2YgYSBoeXBl
cnZpc29yIG9uIHRoZSBzeXN0ZW0uwqAgSWYgdGhlcmUgaXMgYSBoeXBlcnZpc29yIGFuZCBpdA0K
ZG9lc24ndCBvZmZlciBWSVJUX1NQRUNfQ1RSTCwgdHJ5aW5nIHRvIHBsYXkgd2l0aCBMU19DRkcg
aXNuJ3QgZ29pbmcgdG8NCm1ha2UgdGhlIHNpdHVhdGlvbiBhbnkgYmV0dGVyLg0KDQpBcyB0byB0
aGUgQ1BVSUQgYml0IGhhbmRsaW5nLCBvbiBjb25zaWRlcmF0aW9uIG9mIHRoZSB3aG9sZSBzZXJp
ZXMsIGl0DQp3YW50cyB0byBiZSAiISIgb25seS7CoCAhIGlzIHRoZXJlIHRvIGluZGljYXRlICJz
b21ldGhpbmcgY29tcGxpY2F0ZWQgaXMNCmdvaW5nIG9uIHdpdGggdGhpcyBiaXQiLCBhbmQgbGlm
ZSBpcyB0b28gc2hvcnQgdG8gdHJ5IGFuZCBnZXQgdGhlDQpkZXJpdmF0aW9uIGxvZ2ljIHJpZ2h0
IHdpdGggYm90aCBpbXBsaWNpdCBhbmQgZXhwbGljaXQgY29uZGl0aW9ucy7CoA0KTGVhdmUgaXQg
d2l0aG91dCBhbiBzL1MgKHNvIG5vIGF1dG8gcHJvcGFnYXRpb24gZnJvbSB0aGUgaG9zdCBwb2xp
Y3kpLA0KYW5kIHNldCBpdCBpbiB0aGUgbWF4IHBvbGljeSBmb3IgTFNfQ0ZHIHx8IFZJUlRfU1BF
Q19DVFJMIHx8IFNQRUNfQ1RSTCwNCmFuZCBzZXQgaXQgaW4gdGhlIGRlZmF1bHQgcG9saWN5IGZv
ciBMU19DRkcgfHwgVklSVF9TUEVDX0NUUkwsIHdoaWNoDQp3aWxsIGJlIGZhciBjbGVhcmVyIHRv
IGZvbGxvdy4NCg0KRm9yIGBzdHJ1Y3Qgc3NiZF9jb3JlYCwgdGhlIG5hbWUgaXNuJ3QgZ3JlYXQu
wqAgSXQncyBtb3JlDQpzc2JkX2xzX2NmZy9zdGF0ZS7CoCBBbHNvLCBlYWNoIGFycmF5IGVsZW1l
bnQgd2FudHMgNjQgYnl0ZSBhbGlnbm1lbnQsDQpiZWNhdXNlIHRoYXQncyB0aGUgb25seSB3YXkg
dG8gYXZvaWQgYXRvbWljIGNhY2hlbGluZSBwaW5ncG9uZyBmcm9tIHRoZQ0Kc3BpbmxvY2tzLsKg
IEFsc28sIHRoZSBhY2Nlc3NvcnMgbmVlZCB0byBiZSByYXcsIGJlY2F1c2UgR0lGPTAgY29udGV4
dCBpcw0Kd2VpcmQgYW5kIHdvcmtpbmcgYXJvdW5kIGNoZWNrbG9jayB3aXRoIGlycXNhdmUgdmFy
aWFudHMgaXMgbm90IGEgY2xldmVyDQptb3ZlLsKgIEl0IGlzIG5vdCBzYWZlIHRvIHByaW50aygp
L2J1Zy9ldGMgZnJvbSBHSUY9MCBjb250ZXh0LCBzbyBsb2dpYw0KbmVlZHMgdG8gYmUga2VwdCB0
byBhbiBhYnNvbHV0ZSBiYXJlIG1pbmltdW0uDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 18:52:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 18:52:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311187.528276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhyOn-0002NC-3K; Fri, 22 Apr 2022 18:52:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311187.528276; Fri, 22 Apr 2022 18:52:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhyOn-0002N5-0I; Fri, 22 Apr 2022 18:52:57 +0000
Received: by outflank-mailman (input) for mailman id 311187;
 Fri, 22 Apr 2022 18:52:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ojHi=VA=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1nhyOl-0002Mx-Vz
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 18:52:56 +0000
Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com
 [2607:f8b0:4864:20::62c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6ace17eb-c26d-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 20:52:55 +0200 (CEST)
Received: by mail-pl1-x62c.google.com with SMTP id d15so12753266pll.10
 for <xen-devel@lists.xenproject.org>; Fri, 22 Apr 2022 11:52:54 -0700 (PDT)
Received: from localhost ([118.33.58.98]) by smtp.gmail.com with ESMTPSA id
 t9-20020a17090ad50900b001cd4989feecsm6645161pju.56.2022.04.22.11.52.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Apr 2022 11:52:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ace17eb-c26d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition;
        bh=MzQpyWVGd6/oj99QHSaMNGw4bNEHQuphO4N+La1lNXc=;
        b=pFKtqZ49r5qs8C1gaNPeURj/UJk2+IJc6qFTyVxesaqzLOIfAu8bAhiuqTptbqr4IO
         Zkp/Oy4P0zdMrAp7MlF9tYcxrVDwZayGy5MeRjnYxo8ER2BJceqW+IPxqZ+IvWvmFoz6
         eILK2+hqB569neFwydPKIrRoWsPwDx3u6+JKz2/imLxIa+j1sifsG+71LCOk0cwxx7U4
         e5MURCz0NNHcg7wKWnYLH5mRcUS/vc9IIAbN5BkBrVtxj51UVFPAGnkgEk8SOiQmC8ZW
         PivSvkLvrQxLXzOy4ARofjxN5LLJK8LKxh0tycsZyjOAWnYUKlLC+U8HpMMlqjea01Dv
         2w/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition;
        bh=MzQpyWVGd6/oj99QHSaMNGw4bNEHQuphO4N+La1lNXc=;
        b=yN+w6459F716/9OHXVopw5M28ZnNA2IZsIJCtUrA0myhwHeIoIPKsNQUB1Hk+im1s+
         VjaG0UfrpcZem5cQpKC7K6CxH+hLWuGQN8Jk10Z60uIGQfdOhfwSnywvTkiZSnF2fyKA
         c26pAd/7xCnF5WQ7fs2M2wiLhBMyBtP8Hhfaf+Thf4Wm/LLZuoUFrLCb/uunRG3O3Qn3
         XY/bMsSgAal9J/3Miq3xjiFy4SlmDgURSmOFq8dBE6OT05aKsY8v4vIf1M3wr1Lcp125
         lSQXLrys54ej1hLmkO7C9I8XIVchow1vi3loIEESYkbkSZCGKiZGSagL40cqHxzjWYP4
         VZiw==
X-Gm-Message-State: AOAM5335eKp+Kv3PW8f/+q7rssR6nh9vM3GPvdmoE7oemjSkcAVpAzKu
	FYRKqBnv3JT99iCUClWgHXo=
X-Google-Smtp-Source: ABdhPJzmQq+ytJJZZiySqbM4zWDZvMnW+Qy8paUr8NflAfoC+EJg8LPTKGbSwFuRFL7xwxeU8LemQw==
X-Received: by 2002:a17:902:9001:b0:156:a567:2683 with SMTP id a1-20020a170902900100b00156a5672683mr5953430plp.164.1650653573442;
        Fri, 22 Apr 2022 11:52:53 -0700 (PDT)
Date: Sat, 23 Apr 2022 03:52:51 +0900
From: Paran Lee <p4ranlee@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
Subject: [PATCH] xen/arm: fdt fix duplicated ternary operator, shift
 operations
Message-ID: <20220422185251.GA7124@DESKTOP-NK4TH6S.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

It doesn't seem necessary to do duplicate ternary operation and calculation
of order shift using fdt32_to_cpu macro.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 xen/arch/arm/bootfdt.c  | 12 ++++++++++--
 xen/common/libfdt/fdt.c | 10 +++++-----
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index e318ef9603..e5b885a7f2 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -159,8 +159,16 @@ int __init device_tree_for_each_node(const void *fdt, int node,
             continue;
         }
 
-        as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
-        ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
+        if ( depth > 0 )
+        {
+            as = address_cells[depth-1];
+            ss = size_cells[depth-1];
+        }
+        else
+        {
+            as = DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
+            ss = DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
+        }
 
         address_cells[depth] = device_tree_get_u32(fdt, node,
                                                    "#address-cells", as);
diff --git a/xen/common/libfdt/fdt.c b/xen/common/libfdt/fdt.c
index 9fe7cf4b74..a507169d29 100644
--- a/xen/common/libfdt/fdt.c
+++ b/xen/common/libfdt/fdt.c
@@ -165,7 +165,7 @@ const void *fdt_offset_ptr(const void *fdt, int offset, unsigned int len)
 uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
 {
 	const fdt32_t *tagp, *lenp;
-	uint32_t tag;
+	uint32_t tag, len;
 	int offset = startoffset;
 	const char *p;
 
@@ -192,11 +192,11 @@ uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
 		if (!can_assume(VALID_DTB) && !lenp)
 			return FDT_END; /* premature end */
 		/* skip-name offset, length and value */
-		offset += sizeof(struct fdt_property) - FDT_TAGSIZE
-			+ fdt32_to_cpu(*lenp);
+		len = fdt32_to_cpu(*lenp);
+		offset += sizeof(struct fdt_property) - FDT_TAGSIZE + len;
 		if (!can_assume(LATEST) &&
-		    fdt_version(fdt) < 0x10 && fdt32_to_cpu(*lenp) >= 8 &&
-		    ((offset - fdt32_to_cpu(*lenp)) % 8) != 0)
+		    fdt_version(fdt) < 0x10 && len >= 8 &&
+		    ((offset - len) % 8) != 0)
 			offset += 4;
 		break;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 19:01:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 19:01:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311193.528287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhyXG-0003r3-UN; Fri, 22 Apr 2022 19:01:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311193.528287; Fri, 22 Apr 2022 19:01:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhyXG-0003qw-RH; Fri, 22 Apr 2022 19:01:42 +0000
Received: by outflank-mailman (input) for mailman id 311193;
 Fri, 22 Apr 2022 19:01:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nhyXF-0003qq-A9
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 19:01:41 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a2fe9fd9-c26e-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 21:01:39 +0200 (CEST)
Received: from mail-dm6nam08lp2045.outbound.protection.outlook.com (HELO
 NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.45])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 15:01:36 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BL0PR03MB4148.namprd03.prod.outlook.com (2603:10b6:208:65::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr
 2022 19:01:34 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 19:01:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2fe9fd9-c26e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650654099;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=IlQGvV+muFMVKgvw9h8yPUKC3o/hjcUSdtxGSXtmxnU=;
  b=Zc+NlsdDRTnbNmyMxqQldWka7PLBUGAglElLzIgMnQ1a2IMdWTS5fbSh
   Qu7FJoYqXGt6U8wdkbG3wM6viaelbbHzwkl8UqRqz5Qm7hraby204T0sO
   8Tcj9BoIYyTOw7L/cErzbaLnv7CpWBbuOnmcYxD6pVsrmDVJt2aD5Pj2c
   o=;
X-IronPort-RemoteIP: 104.47.73.45
X-IronPort-MID: 70134481
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:0RVv3qi/uy/q1nWu3k5DnG4NX161lxEKZh0ujC45NGQN5FlHY01je
 htvD2iDO/eLNmSnedB1O4Sz8h8D6J7RmNYyQFA4/is2ESMb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nX4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YS0qAar3vqMQaThJCi1kZpVh3OTlMHfq5KR/z2WeG5ft69NHKRlqeKE9pKNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuoQegGpYasNmRJ4yY
 +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVvujOPkFwouFTrGMXHR9yDRsZ6onazh
 k399WunWQoLGMPKnFJp9Vrp3IcjhxjTWogfCbm5/f5Cm0CIyyoYDxh+fUCgvfCzh0q6WtReA
 08Z4Cwjqe417kPDZtvgWxy1plaUsxhaXMBfe8Uw5RuR0KPS70CcD3IdUz9aQNU8sYk9QjlC/
 mGOm9TlFDl+qoq/QHiW9qqXhT6qMC1TJmgHDQcbSSMV7t+lp5s85jrXR8tnOL64iJvyAz6Y6
 yCHqm0yiqseieYP1r6n5hbXjjS0vJ/LQwUpoALNUQqN7AxjY5W+T5e18lWd5vFFRLt1VXGEt
 XkA3sSbsuYHCMndkDTXGLlQWra0+/yCLTvQx0Z1GIUs/Cis/Hjlep1M5DZ5JwFiNcNslSLVX
 XI/cDh5vPd7VEZGp4ctC25tI6zGFZTdKOk=
IronPort-HdrOrdr: A9a23:oDfttq1Brw1mLOuHzy6ddQqjBetxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+
 UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf
 grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e
 iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ
 PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/
 6uJZM+OY6XEVfT
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="70134481"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KuSESmM8Lgu2cpqeF+iQZ/5S8ptM65FcHmHsc9EC9Wf84FUjiTgUpgi53n0lo0QVUeKulQ7TyF73udJa41ythmI9M7g3bQPewacyvehGlC8YTaL20Vgsu9nQWxGhgmRiJHQekjPX8GliTARe314D00sFfgo522DGRpD5kNcTwiKMgB0Vke49OkVQ+TInW2c/8CJbtPe228SkZY7zmr2sntX1VUecLLbCOhWEvANWxhlOpY82mBjFNP6UqxWSLB2OpWU+wlZXtmv8CtFh0Qemb80YLZ3hqjD0n0H/+LlptvakQjaepeLroG66ex9NJvcspdIt74YaS7AMcy7e3iLvsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IlQGvV+muFMVKgvw9h8yPUKC3o/hjcUSdtxGSXtmxnU=;
 b=WfIvIdBySTE3rr9uE0lyE2HfzKuwT0YDhZau2rxSGz9dy/B4p50I7hjeLnP1pRYq7owqImmiYQM+jo1tTbqQbEYcj/HzRZXs9j39Y3gkiGIDvvmf7tiOh2oVNIDeS82um46jl1m6WG5Hpl1HkpCPZXU3U8d147vn4djVu/PVDfOt+HG/4T2eQodxMG/EfQm7TPMVq8Aiht0aHbmeXKdv+MmQG1IdjMYTYFnBU3garHjkA3hxff+ozv+hrV1bOl+yZnGMfzUSGh1MfxiTPB2tP9H2/TCr+lPLGUWCuvos5RHZncJRhx6aGkk9QSuYyeDoaz4+VYitCI79JpRZ8GccfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IlQGvV+muFMVKgvw9h8yPUKC3o/hjcUSdtxGSXtmxnU=;
 b=bXJIClcRrQwHHND6JH3a+uzbC9TnGoSbKU8aPdmTOvHSqYJz1N55T1RcQu6c6Zw5LBIhVWJNl8wk98c/YMD5XwfosCm1R/7RYJWmmcNZak8FFMOiHOlt+mvNRd6bIXQHScDErFbVWQGnlo9sCih/f2qbG8RGNxGBVvKGsujtn/o=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, George Dunlap
	<George.Dunlap@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Paul Durrant <paul@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Juergen
 Gross <jgross@suse.com>
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Thread-Topic: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
Thread-Index:
 AQHYVHuOvzYJLKPprEuLadRqUVZq9az4UhqAgAAC1gCAAAFpgIACUHUAgADgBQCAAMb5gA==
Date: Fri, 22 Apr 2022 19:01:33 +0000
Message-ID: <a39c8975-b331-8d3b-a09d-688a91fa8fb1@citrix.com>
References: <20220420055736.27901-1-jgross@suse.com>
 <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
 <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
 <74f6105d-d3a3-6508-3c6f-3aac53285c5f@suse.com>
 <7f55e68c-17ed-c682-9ba7-4835d8e1a79b@citrix.com>
 <a83fc8db-f8c0-5a17-a668-1a00cb1fdc2a@suse.com>
In-Reply-To: <a83fc8db-f8c0-5a17-a668-1a00cb1fdc2a@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 713d76f1-d8a1-4a5c-d39c-08da249284dc
x-ms-traffictypediagnostic: BL0PR03MB4148:EE_
x-microsoft-antispam-prvs:
 <BL0PR03MB414845C9BC7DD8A1D5753206BAF79@BL0PR03MB4148.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 FNrd9XI0TSAFMJCPWNC9lgKeIiJWLcdXynhvi7t/3oZ9DLkycJssiJdugIVslEx+/x6ktqbvKLH+QMoYS24D3YceaHr6ViulUWBlhNvdL4+uBPky9Tx5HDmjBuacfQNLWr1bCPpkE2m0arwIMVOUBniR0kbBp8jAaP9UWTtre9dHgSyagPo9RCTLXdiHsXILquEH/0eeHdg/8YMPUY1KYHSyRcusdi8BzU/6hLMfHzQE+/hY3sM1TwVEQmkywPpQxJ6LX3Uvm3W5lGzPAKYKDykhq2uxv3L9rpgO7BTNSWt+F8DuayhVO3giIbJGMmLQcnVTUHrBYgyMIyaGlBra2aUMqAM/mICBNxuWDOk1NrK13twOji7KGqHhIVWN5OP4kj6w+dQkE2UTenH2H9yZ69xpBpWDnhFT38liQ/SHMrOsrHRG/J/0HMZFZniO9eZ7vFCW+aHnA1Oe0S9ZLABJ++Vmh/PQH1Lh27WfxtBjpApRaL+wU5sLXVC1JRhYYUQsM1I+36cuD3VhlXl9PrAoPy2tdxObSll0V1TH0yDEHvVBfEeagN3SoPmJT4wX81QQfAu2u0i1ZDsAFDaF26XhP8vuahQ6yCQAdi1CZ/TKFbiGnnnDLdkIrlSSgJn59YSL3Ql6Y0H18V9KLq6nWtJQMeBlZie8SdOX6oTQx/ig8OcMTYbIpCSJy7dAQlJMfKT3MvaNB1YOp6L60tSIYiVUgH5kenluv9F58819xgwh5ndMhdt4XKQvbgfCRkgUYCTIDqOwo+sSlCoCtUR6RdurLQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(66946007)(82960400001)(64756008)(8676002)(66476007)(8936002)(91956017)(5660300002)(66446008)(4326008)(38070700005)(38100700002)(122000001)(6486002)(71200400001)(508600001)(6506007)(31686004)(53546011)(6512007)(26005)(36756003)(76116006)(186003)(83380400001)(86362001)(31696002)(316002)(54906003)(2906002)(2616005)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?emd0ckFpSVE1MGtPcEdxYU1UVUJPQmdtS1EvUnQvSVpoQk5iQlNZQVBVWUFq?=
 =?utf-8?B?QzliM3ZTZWpYVm9ZQTVpeDFPMjFUTmRNZCtKUzVrOEtWeHNOVm1ncXozcExo?=
 =?utf-8?B?UnFYTjNvakJsNWY4WjNDbEdyWXFOcGpYa0ZQeExqeVZvYWZ0YS9ybkdaK21n?=
 =?utf-8?B?eU5nQmxYMHZKRzhWczUxSUJ6dndFc3JwUHdxRm1QTURDSkJ0a1VuMG90aUhh?=
 =?utf-8?B?dUZjY3hKS3VTN3dtQS90cWVpbkxvWklxM0xld2dYaHJzWjdEL2x1akJnZkJm?=
 =?utf-8?B?TkRINUJ1aEc0azlQcVlJdDJKc1NtczhEY3FPem9BYjVJWWFITDlxVWs4dlpq?=
 =?utf-8?B?NUxGZXhJemVtQmt4aDRXWHZCeDRycnNmSGd3T1VyUTFhdFlTRkhwME1LWnRP?=
 =?utf-8?B?akRQY2lzYzVwSVAxR2NaTDFyZEpRYjF4WDQrbHdsMGtuWGNHelBmUzR3a09N?=
 =?utf-8?B?Q0FHRVJ5QVljMDUxeEdsMThXQm9TUXdFYllhV1hHWkFlWUJtYmQrVTNzeVEv?=
 =?utf-8?B?b05yaTBnK2IvN3JEV1FZeDVVRXZKLzR6bXBKT3RhczY0UGtUbXh1Z3VQUkhu?=
 =?utf-8?B?VThZeVB6eHFoRFJmN0d1cS9mQ29ralo4UlJCQks3aFljeWw2WHhwbGdTNnBs?=
 =?utf-8?B?L3dIZEZlOFRZNWFscW5pSUppc2pBMFJ1NVFud0NQS0EybkVzeDVEdU9QbHVs?=
 =?utf-8?B?QXBZSktOdVZlYVpWNENJeXVJYVkwVkN4eXhZVXFuakNDVFRadlgxMnNScUVy?=
 =?utf-8?B?cjR4UHdSU2lIQUV1V0o1czdvd2g1NmE4RU9UcGNqYnM0c1k2QURaU2xLQUFC?=
 =?utf-8?B?WE1heWwzNi80cUVmdDFueW1JbTNEeXVBTmQxbGcwSVh0WFlPa3hJVElIUVVm?=
 =?utf-8?B?VEY5YkhrNFJGR0ZHeThvT3NsdTFGTVlkZzRnRytzMU1tZHRBaTQ4a1RnaEYz?=
 =?utf-8?B?V1FiK1QvcUIyKzFYWlBPS2FUTkJjZWZpLzNCKzdteTdJZFNjTTRGaWluanBE?=
 =?utf-8?B?VzljWHN4QjBsUTY3clhGMk5yRlRIay9PYm5zRjh6ZGY0VmV4Q0JxRVBlOHdS?=
 =?utf-8?B?aXM4cXJSUnZPVjQ4Rjh0WnVOZitaQVAxUXhSWmdlRDVERnhSaGdNOVdaT2hv?=
 =?utf-8?B?NE1oSkV3NE5UZ05vMVVYcUFkZ1FlR3Y4NDBkN2VvK1orWkw0eG0ybFZjZDR2?=
 =?utf-8?B?SW8wRTExdnYzNjlkYlYvN0lYRHlzRGU0MFBTblZvaVROYnlVRFFCQ2w5czJJ?=
 =?utf-8?B?bmtuc2t2VHowa05HbUp1TDU4ckJCNHQrNE1rUklNQjVHZ2tXQ0t1akQ1Y2hU?=
 =?utf-8?B?czZRa1BMODQ0cmpDZmIrWmZZOERzR0xnOG41SHExWWRrUkZScDgrdE9TUUJm?=
 =?utf-8?B?eEFsaTU4aFFXV0lIbjVKTWhOZFhKVVNVVzl2OTA0OEM4ZU9raHd0bUxIOFJo?=
 =?utf-8?B?NFQ5QU9wLzA5SHBBVlA0bTlhZWd4ek9zSkJ2aFVXTzJ5NjlpK0tmZ2ljd0xI?=
 =?utf-8?B?Q0pENk54bCtLaW82VlRrVytjU2hZNUdDK2M3NDQzSHJvUzhoUWVnT3U0WkxT?=
 =?utf-8?B?MXlmQnR3V0ZTeGRiRDdQekc3R0JuQ3h4dVRETlFncEVPUk9ESEdLVXM1ZHZa?=
 =?utf-8?B?bVBiMXZmbW9GdE1Wbk4yTVdITzVFM1pEdnhRODllQlpieXlKaSsvdk05bjRI?=
 =?utf-8?B?cyttQzd6RmV0dnJEOStOR3h5WGhNTnJvVjJnV0s4TEM4NUpiYWxhaXN5ZWxp?=
 =?utf-8?B?bVhYb213STJrOXlDVi9YQUp1TkVXTTNveWlFTUNGUXQ5QS9MUGpTTE5ZTWla?=
 =?utf-8?B?cTZQZUxnbGtjVkRZZXl0c2Q4YVBwNjBOZmVmbkFXNUszdUp5Z2ZTYVQ0R2ZB?=
 =?utf-8?B?VjVsTWJvWVM3T1JEQlN5aTZzM1JFYXVWbEFSdlhqYkZXM1lWODVSdFNNb2xI?=
 =?utf-8?B?elBTMkMrcnJUOGdBSS9rVXNmZDRQemROSHJlRVc1THFHR2k3ZjIwMTV3Z3JJ?=
 =?utf-8?B?cHJWazBMaFZGVWpTSE9aS0VFempBVnMvRVphUTErMVFkc01VOHZ0aU50RWRZ?=
 =?utf-8?B?TTAzRXlOWllIRmVSOWNEajAya2Y2UGl1eGRYTjRzQmpXK1ZibVBYbXpzbTVR?=
 =?utf-8?B?VEx0ZWhvNFljUXFHTFdRNXVvc1VNYzJENnVDNFpSekxadDFQeUFNOGFYQ3lJ?=
 =?utf-8?B?WlhwZFFITXNZRk9kNlZNdWl6eGZrbFpOM3cza3lkQjc3Y0pURlM0akxORVBo?=
 =?utf-8?B?YnZXdjA0aG40NXNaU3lhZng4MzZwUlZpQjdwcTA0b1QwaFkxWDJsc21jQTFI?=
 =?utf-8?B?L3ZkOVJBcUZXYTNnaDMxRkMzRUJUcmllT0FTRm1qckZ1TWZraHdpdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <21D9DDD78E1B3E4FAB1DA16FDA6B868A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 713d76f1-d8a1-4a5c-d39c-08da249284dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 19:01:33.8611
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5hIlA88aiG5KWBwsjI5yu+PVOQNhz89rJUp/4ozhQZxdi3JRvqHuCiylgrIJoSUDfIBIqzB99f9n3vktuAHTEZmQYPiJN4FPxKNwitecS2c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4148

T24gMjIvMDQvMjAyMiAwODowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIxLjA0LjIwMjIg
MTk6NDcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyMC8wNC8yMDIyIDA3OjI3LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAyMC4wNC4yMDIyIDA4OjIyLCBKdWVyZ2VuIEdyb3NzIHdy
b3RlOg0KPj4+PiBPbiAyMC4wNC4yMiAwODoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBP
biAyMC4wNC4yMDIyIDA3OjU3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+Pj4+IC0tLSBhL3hl
bi9pbmNsdWRlL3hlbi9pb21tdS5oDQo+Pj4+Pj4gKysrIGIveGVuL2luY2x1ZGUveGVuL2lvbW11
LmgNCj4+Pj4+PiBAQCAtMzQxLDggKzM0MSwxNyBAQCBzdHJ1Y3QgZG9tYWluX2lvbW11IHsNCj4+
Pj4+PiAgIC8qIERvZXMgdGhlIElPTU1VIHBhZ2V0YWJsZSBuZWVkIHRvIGJlIGtlcHQgc3luY2hy
b25pemVkIHdpdGggdGhlIFAyTSAqLw0KPj4+Pj4+ICAgI2lmZGVmIENPTkZJR19IQVNfUEFTU1RI
Uk9VR0gNCj4+Pj4+PiAgICNkZWZpbmUgbmVlZF9pb21tdV9wdF9zeW5jKGQpICAgICAoZG9tX2lv
bW11KGQpLT5uZWVkX3N5bmMpDQo+Pj4+Pj4gKw0KPj4+Pj4+ICtpbnQgaW9tbXVfZG9fZG9tY3Rs
KHN0cnVjdCB4ZW5fZG9tY3RsICpkb21jdGwsIHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+Pj4gKyAg
ICAgICAgICAgICAgICAgICAgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVf
ZG9tY3RsKTsNCj4+Pj4+PiAgICNlbHNlDQo+Pj4+Pj4gICAjZGVmaW5lIG5lZWRfaW9tbXVfcHRf
c3luYyhkKSAgICAgKHsgKHZvaWQpKGQpOyBmYWxzZTsgfSkNCj4+Pj4+PiArDQo+Pj4+Pj4gK3N0
YXRpYyBpbmxpbmUgaW50IGlvbW11X2RvX2RvbWN0bChzdHJ1Y3QgeGVuX2RvbWN0bCAqZG9tY3Rs
LCBzdHJ1Y3QgZG9tYWluICpkLA0KPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3RsKQ0KPj4+
Pj4+ICt7DQo+Pj4+Pj4gKyAgICByZXR1cm4gLUVOT1NZUzsNCj4+Pj4+PiArfQ0KPj4+Pj4gQXMg
c2FpZCBpbiByZXBseSB0byBBbmRyZXcgYXMgd2VsbCBhcyBpbiBhIG51bWJlciBvciBlYXJsaWVy
IG9jY2FzaW9ucywNCj4+Pj4+IEkgZmlybWx5IHRoaW5rIHRoYXQgdGhpcyB3YW50cyB0byBiZSAt
RU9QTk9UU1VQUCwgbm90IC1FTk9TWVMuIFZpZXdzDQo+Pj4+IEluIGxpYnhsIHRoZXJlIGlzIGFu
IGV4cGxpY2l0IGNoZWNrIGZvciBFTk9TWVMgYmVpbmcgcmV0dXJuZWQgZm9yDQo+Pj4+IGFzc2ln
bmluZy9kZWFzc2lnbmluZyBhIGRldmljZSwgc2FtZSBpbiB0aGUgeGMgcHl0aG9uIGJpbmRpbmdz
Lg0KPj4+IFVyZ2guDQo+PiBIb25lc3RseSwgSSB3YXNuJ3QgcGFydGljdWxhcmx5IGhhcHB5IHdp
dGggeW91ciBwdXNoIHRvIHN3YXAgRU5PU1lTIG91dA0KPj4gZm9yIEVPUE5PVFNVUFAuwqAgVGhp
cyBzaG93cyBwbGFpbmx5IHdoeSBpdCdzIGEgYmFkIG1vdmUuDQo+Pg0KPj4gQW4gZW5kIHVzZXIg
ZG9lc24ndCBnaXZlIHR3byBob290cyBhYm91dCB0aGUgZGlzdGluY3Rpb24gYmV0d2Vlbg0KPj4g
aHlwZXJjYWxsIG5vdCBzdXBwb3J0ZWQgYW5kIHN1Ym9wcyBub3Qgc3VwcG9ydGVkOyB0aGV5IGNh
cmUgYWJvdXQNCj4+IHdoZXRoZXIgWGVuIGNhbiBwZXJmb3JtIHRoZSByZXF1ZXN0ZWQgYWN0aW9u
IG9yIG5vdC7CoCBFTk9TWVMgaXMgdGhlIG1vcmUNCj4+IGNvbW1vbiB3YXkgb2Ygc2lnbmFsbGlu
ZyB0aGlzLCBhbmQgaGF2aW5nIG9ubHkgb25lIGVycm5vIHZhbHVlIHRvIGNoZWNrDQo+PiBpcyBi
ZXR0ZXIgZm9yIGV2ZXJ5b25lIGludm9sdmVkLg0KPiBFbmQgdXNlcnMgYXJlIG9mIGxpdHRsZSBp
bnRlcmVzdCBoZXJlLiBDb2RlIGxvb2tpbmcgZm9yIEVOT1NZUyBpcyB3aGF0DQo+IGlzIG9mIGlu
dGVyZXN0LCB3aGVuIHRoZSBtZWFuaW5nIG9mIEVOT1NZUyBpcyBxdWl0ZSB3ZWxsIGRlZmluZWQg
YXMNCj4gInN5c3RlbSBjYWxsIG5vdCBpbXBsZW1lbnRlZCINCg0KUE9TSVggc3BlY2lmaWVzIGl0
IGFzICJGdW5jdGlvbmFsaXR5IG5vdCBzdXBwb3J0ZWQiIHdoaWNoIGlzIHdoeSBvdGhlcg0KY29t
cGxpbWVudCBzeXN0ZW1zIHVzZSBpdCBmb3Igc21hbGxlciBncmFudWxhcml0eSB0aGFuIGEgc3lz
dGVtIGNhbGwuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 19:44:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 19:44:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311203.528298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhzCE-0000rD-SL; Fri, 22 Apr 2022 19:44:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311203.528298; Fri, 22 Apr 2022 19:44:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhzCE-0000qy-OD; Fri, 22 Apr 2022 19:44:02 +0000
Received: by outflank-mailman (input) for mailman id 311203;
 Fri, 22 Apr 2022 19:44:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JQBp=VA=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nhzCD-0000qs-3W
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 19:44:01 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c375f41-c274-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 21:43:58 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650656632818594.2966413037028;
 Fri, 22 Apr 2022 12:43:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c375f41-c274-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650656634; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=JRl+DMZtthZJ96hEuSHBTBYsIm2kTrfjWn95dAVKIGStX95lDe+c363VKK0nLfQAcfxpMYDuH5zUYEusikt1BFmt+T/A6ok067ZAjet+49TGAdp5M9vklf+SmWSeNbiYFimuThFbTrtmKzA8S5B7SvVrMwgrwvrU+3q3/vde+aw=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650656634; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=gZoPE3ey9o58yT/dUqy4QzWLLVgIJXl38ETuW0qXh5U=; 
	b=klLYoxZzdf1lTQAkq0ND+T4fkva5hjfmfwfKJJMWsC+DET0Aa+hHdqkaGKHuYc94sg7Ir8BtVOaCqYBZmcxaZl5IApNL61bg8AAyconHSyV4Sh+503QEu6C6poJ4G36ulmxLbZ1O1aYq/fBwBJ5jUmTgS5wAVyUuWHG0kW+lZyE=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650656634;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=gZoPE3ey9o58yT/dUqy4QzWLLVgIJXl38ETuW0qXh5U=;
	b=JmIqFSMKeCF0Obd2gt0O6Uw7de0Xc9xCtQdqeVuFJZ/8GOX5381Y6OytiO0xRdZE
	7HI58fat5WyZWerYtg85/aYtJsOD29l3705VOLZcIpxuJGYbuQzuQDPwePM4b7AgJaY
	qFpibTxxl7BEQf1lhY1dAJLV1sQjHQsiFk3J8QtM=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: jandryuk@gmail.com,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: [PATCH] xsm/flask: code style formatting
Date: Fri, 22 Apr 2022 15:43:44 -0400
Message-Id: <20220422194344.9318-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This is a quick code style cleanup patch for xsm/flask. The files flask_op.c
and hooks.c are Xen specific, thus full code style rules were applied. The
remaining files are from Linux and therefore only trailing whitespace was
remove from those files.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/xsm/flask/avc.c            |  14 +--
 xen/xsm/flask/flask_op.c       |  27 ++---
 xen/xsm/flask/hooks.c          | 186 +++++++++++++++++----------------
 xen/xsm/flask/include/avc.h    |   2 +-
 xen/xsm/flask/ss/avtab.c       |  10 +-
 xen/xsm/flask/ss/avtab.h       |   4 +-
 xen/xsm/flask/ss/conditional.c |   4 +-
 xen/xsm/flask/ss/context.h     |   4 +-
 xen/xsm/flask/ss/mls.c         |   2 +-
 xen/xsm/flask/ss/policydb.c    |   2 +-
 xen/xsm/flask/ss/services.c    |   6 +-
 xen/xsm/flask/ss/sidtab.c      |   6 +-
 12 files changed, 136 insertions(+), 131 deletions(-)

diff --git a/xen/xsm/flask/avc.c b/xen/xsm/flask/avc.c
index e20c165042..4a75ec97e2 100644
--- a/xen/xsm/flask/avc.c
+++ b/xen/xsm/flask/avc.c
@@ -13,9 +13,9 @@
  *    it under the terms of the GNU General Public License version 2,
  *      as published by the Free Software Foundation.
  */
- 
+
 /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
- 
+
 #include <xen/lib.h>
 #include <xen/xmalloc.h>
 #include <xen/types.h>
@@ -267,7 +267,7 @@ int avc_get_hash_stats(struct xen_flask_hash_stats *arg)
     }
 
     rcu_read_unlock(&avc_rcu_lock);
-    
+
     arg->entries = atomic_read(&avc_cache.active_nodes);
     arg->buckets_used = slots_used;
     arg->buckets_total = AVC_CACHE_SLOTS;
@@ -336,7 +336,7 @@ static inline int avc_reclaim_node(void)
         }
         rcu_read_unlock(&avc_rcu_lock);
         spin_unlock_irqrestore(lock, flags);
-    }    
+    }
  out:
     return ecx;
 }
@@ -622,7 +622,7 @@ static int avc_update_node(u32 perms, u32 ssid, u32 tsid, u16 tclass,
     struct hlist_head *head;
     struct hlist_node *next;
     spinlock_t *lock;
-    
+
     node = avc_alloc_node();
     if ( !node )
     {
@@ -630,7 +630,7 @@ static int avc_update_node(u32 perms, u32 ssid, u32 tsid, u16 tclass,
         goto out;
     }
 
-    hvalue = avc_hash(ssid, tsid, tclass);    
+    hvalue = avc_hash(ssid, tsid, tclass);
 
     head = &avc_cache.slots[hvalue];
     lock = &avc_cache.slots_lock[hvalue];
@@ -695,7 +695,7 @@ int avc_ss_reset(u32 seqno)
         rcu_read_unlock(&avc_rcu_lock);
         spin_unlock_irqrestore(lock, flag);
     }
-    
+
     avc_latest_notif_update(seqno, 0);
     return rc;
 }
diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
index 707be72a3b..eb16e289c3 100644
--- a/xen/xsm/flask/flask_op.c
+++ b/xen/xsm/flask/flask_op.c
@@ -75,15 +75,15 @@ static int __init cf_check parse_flask_param(const char *s)
 }
 custom_param("flask", parse_flask_param);
 
-static int domain_has_security(struct domain *d, u32 perms)
+static int domain_has_security(struct domain *d, uint32_t perms)
 {
     struct domain_security_struct *dsec;
-    
+
     dsec = d->ssid;
     if ( !dsec )
         return -EACCES;
-        
-    return avc_has_perm(dsec->sid, SECINITSID_SECURITY, SECCLASS_SECURITY, 
+
+    return avc_has_perm(dsec->sid, SECINITSID_SECURITY, SECCLASS_SECURITY,
                         perms, NULL);
 }
 
@@ -130,7 +130,7 @@ static int flask_security_access(struct xen_flask_access *arg)
     arg->audit_allow = avd.auditallow;
     arg->audit_deny = avd.auditdeny;
     arg->seqno = avd.seqno;
-                
+
     return rv;
 }
 
@@ -196,7 +196,7 @@ static int flask_security_sid(struct xen_flask_sid_context *arg)
 {
     int rv;
     char *context;
-    u32 len;
+    uint32_t len;
 
     rv = domain_has_security(current->domain, SECURITY__CHECK_CONTEXT);
     if ( rv )
@@ -223,7 +223,8 @@ static int flask_security_sid(struct xen_flask_sid_context *arg)
 
 #ifndef COMPAT
 
-static int flask_security_setavc_threshold(struct xen_flask_setavc_threshold *arg)
+static int flask_security_setavc_threshold(
+    struct xen_flask_setavc_threshold *arg)
 {
     int rv = 0;
 
@@ -350,7 +351,7 @@ static int flask_security_get_bool(struct xen_flask_boolean *arg)
         if ( nameout_len > arg->size )
             rv = -ERANGE;
         arg->size = nameout_len;
- 
+
         if ( !rv && _copy_to_guest(arg->name, nameout, nameout_len) )
             rv = -EFAULT;
         xfree(nameout);
@@ -386,9 +387,9 @@ static int flask_security_make_bools(void)
     int ret = 0;
     int num;
     int *values = NULL;
-    
+
     xfree(bool_pending_values);
-    
+
     ret = security_get_bools(&num, NULL, &values, NULL);
     if ( ret != 0 )
         goto out;
@@ -474,8 +475,8 @@ static int flask_devicetree_label(struct xen_flask_devicetree_label *arg)
 {
     int rv;
     char *buf;
-    u32 sid = arg->sid;
-    u32 perm = sid ? SECURITY__ADD_OCONTEXT : SECURITY__DEL_OCONTEXT;
+    uint32_t sid = arg->sid;
+    uint32_t perm = sid ? SECURITY__ADD_OCONTEXT : SECURITY__DEL_OCONTEXT;
 
     rv = domain_has_security(current->domain, perm);
     if ( rv )
@@ -670,7 +671,7 @@ ret_t cf_check do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op)
 
     case FLASK_MLS:
         rv = flask_mls_enabled;
-        break;    
+        break;
 
     case FLASK_GETAVC_THRESHOLD:
         rv = avc_cache_threshold;
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 0bf63ffa84..e2ebbc7716 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -38,34 +38,34 @@
 #include <conditional.h>
 #include "private.h"
 
-static u32 domain_sid(const struct domain *dom)
+static uint32_t domain_sid(const struct domain *dom)
 {
     struct domain_security_struct *dsec = dom->ssid;
     return dsec->sid;
 }
 
-static u32 domain_target_sid(const struct domain *src,
-                             const struct domain *dst)
+static uint32_t domain_target_sid(
+    const struct domain *src, const struct domain *dst)
 {
     struct domain_security_struct *ssec = src->ssid;
     struct domain_security_struct *dsec = dst->ssid;
-    if (src == dst)
+    if ( src == dst )
         return ssec->self_sid;
-    if (src->target == dst)
+    if ( src->target == dst )
         return ssec->target_sid;
     return dsec->sid;
 }
 
-static u32 evtchn_sid(const struct evtchn *chn)
+static uint32_t evtchn_sid(const struct evtchn *chn)
 {
     return chn->ssid.flask_sid;
 }
 
-static int domain_has_perm(const struct domain *dom1,
-                           const struct domain *dom2,
-                           u16 class, u32 perms)
+static int domain_has_perm(
+    const struct domain *dom1, const struct domain *dom2, uint16_t class,
+    uint32_t perms)
 {
-    u32 ssid, tsid;
+    uint32_t ssid, tsid;
     struct avc_audit_data ad;
     AVC_AUDIT_DATA_INIT(&ad, NONE);
     ad.sdom = dom1;
@@ -77,34 +77,35 @@ static int domain_has_perm(const struct domain *dom1,
     return avc_has_perm(ssid, tsid, class, perms, &ad);
 }
 
-static int avc_current_has_perm(u32 tsid, u16 class, u32 perm,
-                                struct avc_audit_data *ad)
+static int avc_current_has_perm(
+    uint32_t tsid, uint16_t class, uint32_t perm, struct avc_audit_data *ad)
 {
-    u32 csid = domain_sid(current->domain);
+    uint32_t csid = domain_sid(current->domain);
     return avc_has_perm(csid, tsid, class, perm, ad);
 }
 
-static int current_has_perm(struct domain *d, u16 class, u32 perms)
+static int current_has_perm(struct domain *d, uint16_t class, uint32_t perms)
 {
     return domain_has_perm(current->domain, d, class, perms);
 }
 
-static int domain_has_evtchn(struct domain *d, struct evtchn *chn, u32 perms)
+static int domain_has_evtchn(
+    struct domain *d, struct evtchn *chn, uint32_t perms)
 {
-    u32 dsid = domain_sid(d);
-    u32 esid = evtchn_sid(chn);
+    uint32_t dsid = domain_sid(d);
+    uint32_t esid = evtchn_sid(chn);
 
     return avc_has_perm(dsid, esid, SECCLASS_EVENT, perms, NULL);
 }
 
-static int domain_has_xen(struct domain *d, u32 perms)
+static int domain_has_xen(struct domain *d, uint32_t perms)
 {
-    u32 dsid = domain_sid(d);
+    uint32_t dsid = domain_sid(d);
 
     return avc_has_perm(dsid, SECINITSID_XEN, SECCLASS_XEN, perms, NULL);
 }
 
-static int get_irq_sid(int irq, u32 *sid, struct avc_audit_data *ad)
+static int get_irq_sid(int irq, uint32_t *sid, struct avc_audit_data *ad)
 {
     if ( irq >= nr_irqs || irq < 0 )
         return -EINVAL;
@@ -120,8 +121,8 @@ static int get_irq_sid(int irq, u32 *sid, struct avc_audit_data *ad)
         struct irq_desc *desc = irq_to_desc(irq);
         if ( desc->msi_desc && desc->msi_desc->dev ) {
             struct pci_dev *dev = desc->msi_desc->dev;
-            u32 sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
-            if (ad) {
+            uint32_t sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
+            if ( ad ) {
                 AVC_AUDIT_DATA_INIT(ad, DEV);
                 ad->device = sbdf;
             }
@@ -130,7 +131,7 @@ static int get_irq_sid(int irq, u32 *sid, struct avc_audit_data *ad)
     }
 #endif
 
-    if (ad) {
+    if ( ad ) {
         AVC_AUDIT_DATA_INIT(ad, IRQ);
         ad->irq = irq;
     }
@@ -200,7 +201,7 @@ static void cf_check flask_domain_free_security(struct domain *d)
 static int cf_check flask_evtchn_unbound(
     struct domain *d1, struct evtchn *chn, domid_t id2)
 {
-    u32 sid1, sid2, newsid;
+    uint32_t sid1, sid2, newsid;
     int rc;
     struct domain *d2;
 
@@ -234,7 +235,7 @@ static int cf_check flask_evtchn_interdomain(
     struct domain *d1, struct evtchn *chn1,
     struct domain *d2, struct evtchn *chn2)
 {
-    u32 sid1, sid2, newsid, reverse_sid;
+    uint32_t sid1, sid2, newsid, reverse_sid;
     int rc;
     struct avc_audit_data ad;
     AVC_AUDIT_DATA_INIT(&ad, NONE);
@@ -336,9 +337,9 @@ static char *cf_check flask_show_security_evtchn(
     struct domain *d, const struct evtchn *chn)
 {
     int irq;
-    u32 sid = 0;
+    uint32_t sid = 0;
     char *ctx;
-    u32 ctx_len;
+    uint32_t ctx_len;
 
     switch ( chn->state )
     {
@@ -354,7 +355,7 @@ static char *cf_check flask_show_security_evtchn(
     }
     if ( !sid )
         return NULL;
-    if (security_sid_to_context(sid, &ctx, &ctx_len))
+    if ( security_sid_to_context(sid, &ctx, &ctx_len) )
         return NULL;
     return ctx;
 }
@@ -367,7 +368,7 @@ static int cf_check flask_init_hardware_domain(struct domain *d)
 static int cf_check flask_grant_mapref(
     struct domain *d1, struct domain *d2, uint32_t flags)
 {
-    u32 perms = GRANT__MAP_READ;
+    uint32_t perms = GRANT__MAP_READ;
 
     if ( !(flags & GNTMAP_readonly) )
         perms |= GRANT__MAP_WRITE;
@@ -445,7 +446,7 @@ static int cf_check flask_get_vnumainfo(struct domain *d)
 
 static int cf_check flask_console_io(struct domain *d, int cmd)
 {
-    u32 perm;
+    uint32_t perm;
 
     switch ( cmd )
     {
@@ -464,7 +465,7 @@ static int cf_check flask_console_io(struct domain *d, int cmd)
 
 static int cf_check flask_profile(struct domain *d, int op)
 {
-    u32 perm;
+    uint32_t perm;
 
     switch ( op )
     {
@@ -510,7 +511,7 @@ static void cf_check flask_security_domaininfo(
     info->ssidref = domain_sid(d);
 }
 
-static int cf_check flask_domain_create(struct domain *d, u32 ssidref)
+static int cf_check flask_domain_create(struct domain *d, uint32_t ssidref)
 {
     int rc;
     struct domain_security_struct *dsec = d->ssid;
@@ -843,7 +844,7 @@ static int cf_check flask_sysctl(int cmd)
 
 static int cf_check flask_readconsole(uint32_t clear)
 {
-    u32 perms = XEN__READCONSOLE;
+    uint32_t perms = XEN__READCONSOLE;
 
     if ( clear )
         perms |= XEN__CLEARCONSOLE;
@@ -851,7 +852,7 @@ static int cf_check flask_readconsole(uint32_t clear)
     return domain_has_xen(current->domain, perms);
 }
 
-static inline u32 resource_to_perm(uint8_t access)
+static inline uint32_t resource_to_perm(uint8_t access)
 {
     if ( access )
         return RESOURCE__ADD;
@@ -861,13 +862,13 @@ static inline u32 resource_to_perm(uint8_t access)
 
 static char *cf_check flask_show_irq_sid(int irq)
 {
-    u32 sid, ctx_len;
+    uint32_t sid, ctx_len;
     char *ctx;
     int rc = get_irq_sid(irq, &sid, NULL);
     if ( rc )
         return NULL;
 
-    if (security_sid_to_context(sid, &ctx, &ctx_len))
+    if ( security_sid_to_context(sid, &ctx, &ctx_len) )
         return NULL;
 
     return ctx;
@@ -878,12 +879,13 @@ static int cf_check flask_map_domain_pirq(struct domain *d)
     return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD);
 }
 
-static int flask_map_domain_msi (struct domain *d, int irq, const void *data,
-                                 u32 *sid, struct avc_audit_data *ad)
+static int flask_map_domain_msi (
+    struct domain *d, int irq, const void *data, uint32_t *sid,
+    struct avc_audit_data *ad)
 {
 #ifdef CONFIG_HAS_PCI_MSI
     const struct msi_info *msi = data;
-    u32 machine_bdf = (msi->seg << 16) | (msi->bus << 8) | msi->devfn;
+    uint32_t machine_bdf = (msi->seg << 16) | (msi->bus << 8) | msi->devfn;
 
     AVC_AUDIT_DATA_INIT(ad, DEV);
     ad->device = machine_bdf;
@@ -894,7 +896,7 @@ static int flask_map_domain_msi (struct domain *d, int irq, const void *data,
 #endif
 }
 
-static u32 flask_iommu_resource_use_perm(const struct domain *d)
+static uint32_t flask_iommu_resource_use_perm(const struct domain *d)
 {
     /* Obtain the permission level required for allowing a domain
      * to use an assigned device.
@@ -905,7 +907,7 @@ static u32 flask_iommu_resource_use_perm(const struct domain *d)
      * less capable hardware (no IOMMU or IOMMU missing intremap capability)
      * via other separate permissions.
      */
-    u32 perm = RESOURCE__USE_NOIOMMU;
+    uint32_t perm = RESOURCE__USE_NOIOMMU;
 
     if ( is_iommu_enabled(d) )
         perm = ( iommu_intremap ? RESOURCE__USE_IOMMU :
@@ -913,18 +915,18 @@ static u32 flask_iommu_resource_use_perm(const struct domain *d)
     return perm;
 }
 
-static int cf_check flask_map_domain_irq(struct domain *d, int irq, const void *data)
+static int cf_check flask_map_domain_irq(
+    struct domain *d, int irq, const void *data)
 {
-    u32 sid, dsid;
+    uint32_t sid, dsid;
     int rc = -EPERM;
     struct avc_audit_data ad;
-    u32 dperm = flask_iommu_resource_use_perm(d);
+    uint32_t dperm = flask_iommu_resource_use_perm(d);
 
-    if ( irq >= nr_static_irqs && data ) {
+    if ( irq >= nr_static_irqs && data )
         rc = flask_map_domain_msi(d, irq, data, &sid, &ad);
-    } else {
+    else
         rc = get_irq_sid(irq, &sid, &ad);
-    }
 
     if ( rc )
         return rc;
@@ -944,12 +946,13 @@ static int cf_check flask_unmap_domain_pirq(struct domain *d)
     return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE);
 }
 
-static int flask_unmap_domain_msi (struct domain *d, int irq, const void *data,
-                                   u32 *sid, struct avc_audit_data *ad)
+static int flask_unmap_domain_msi (
+    struct domain *d, int irq, const void *data, uint32_t *sid,
+    struct avc_audit_data *ad)
 {
 #ifdef CONFIG_HAS_PCI_MSI
     const struct pci_dev *pdev = data;
-    u32 machine_bdf = (pdev->seg << 16) | (pdev->bus << 8) | pdev->devfn;
+    uint32_t machine_bdf = (pdev->seg << 16) | (pdev->bus << 8) | pdev->devfn;
 
     AVC_AUDIT_DATA_INIT(ad, DEV);
     ad->device = machine_bdf;
@@ -963,15 +966,15 @@ static int flask_unmap_domain_msi (struct domain *d, int irq, const void *data,
 static int cf_check flask_unmap_domain_irq(
     struct domain *d, int irq, const void *data)
 {
-    u32 sid;
+    uint32_t sid;
     int rc = -EPERM;
     struct avc_audit_data ad;
 
-    if ( irq >= nr_static_irqs && data ) {
+    if ( irq >= nr_static_irqs && data )
         rc = flask_unmap_domain_msi(d, irq, data, &sid, &ad);
-    } else {
+    else
         rc = get_irq_sid(irq, &sid, &ad);
-    }
+
     if ( rc )
         return rc;
 
@@ -982,11 +985,11 @@ static int cf_check flask_unmap_domain_irq(
 static int cf_check flask_bind_pt_irq(
     struct domain *d, struct xen_domctl_bind_pt_irq *bind)
 {
-    u32 dsid, rsid;
+    uint32_t dsid, rsid;
     int rc = -EPERM;
     int irq;
     struct avc_audit_data ad;
-    u32 dperm = flask_iommu_resource_use_perm(d);
+    uint32_t dperm = flask_iommu_resource_use_perm(d);
 
     rc = current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD);
     if ( rc )
@@ -1020,14 +1023,14 @@ static int cf_check flask_irq_permission(
 }
 
 struct iomem_has_perm_data {
-    u32 ssid;
-    u32 dsid;
-    u32 perm;
-    u32 use_perm;
+    uint32_t ssid;
+    uint32_t dsid;
+    uint32_t perm;
+    uint32_t use_perm;
 };
 
 static int cf_check _iomem_has_perm(
-    void *v, u32 sid, unsigned long start, unsigned long end)
+    void *v, uint32_t sid, unsigned long start, unsigned long end)
 {
     struct iomem_has_perm_data *data = v;
     struct avc_audit_data ad;
@@ -1077,10 +1080,10 @@ static int cf_check flask_pci_config_permission(
     struct domain *d, uint32_t machine_bdf, uint16_t start, uint16_t end,
     uint8_t access)
 {
-    u32 dsid, rsid;
+    uint32_t dsid, rsid;
     int rc = -EPERM;
     struct avc_audit_data ad;
-    u32 perm;
+    uint32_t perm;
 
     rc = security_device_sid(machine_bdf, &rsid);
     if ( rc )
@@ -1116,7 +1119,7 @@ static int flask_resource_use_core(void)
 
 static int cf_check flask_resource_plug_pci(uint32_t machine_bdf)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
     struct avc_audit_data ad;
 
@@ -1131,7 +1134,7 @@ static int cf_check flask_resource_plug_pci(uint32_t machine_bdf)
 
 static int cf_check flask_resource_unplug_pci(uint32_t machine_bdf)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
     struct avc_audit_data ad;
 
@@ -1146,7 +1149,7 @@ static int cf_check flask_resource_unplug_pci(uint32_t machine_bdf)
 
 static int cf_check flask_resource_setup_pci(uint32_t machine_bdf)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
     struct avc_audit_data ad;
 
@@ -1161,7 +1164,7 @@ static int cf_check flask_resource_setup_pci(uint32_t machine_bdf)
 
 static int cf_check flask_resource_setup_gsi(int gsi)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
     struct avc_audit_data ad;
 
@@ -1179,7 +1182,8 @@ static int cf_check flask_resource_setup_misc(void)
 
 static inline int cf_check flask_page_offline(uint32_t cmd)
 {
-    switch (cmd) {
+    switch ( cmd )
+    {
     case sysctl_page_offline:
         return flask_resource_unplug_core();
     case sysctl_page_online:
@@ -1214,7 +1218,7 @@ static int cf_check flask_map_gmfn_foreign(struct domain *d, struct domain *t)
 
 static int cf_check flask_hvm_param(struct domain *d, unsigned long op)
 {
-    u32 perm;
+    uint32_t perm;
 
     switch ( op )
     {
@@ -1289,7 +1293,7 @@ static int cf_check flask_mem_sharing(struct domain *d)
 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI)
 static int cf_check flask_get_device_group(uint32_t machine_bdf)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
 
     rc = security_device_sid(machine_bdf, &rsid);
@@ -1301,7 +1305,7 @@ static int cf_check flask_get_device_group(uint32_t machine_bdf)
 
 static int flask_test_assign_device(uint32_t machine_bdf)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
 
     rc = security_device_sid(machine_bdf, &rsid);
@@ -1313,10 +1317,10 @@ static int flask_test_assign_device(uint32_t machine_bdf)
 
 static int cf_check flask_assign_device(struct domain *d, uint32_t machine_bdf)
 {
-    u32 dsid, rsid;
+    uint32_t dsid, rsid;
     int rc = -EPERM;
     struct avc_audit_data ad;
-    u32 dperm;
+    uint32_t dperm;
 
     if ( !d )
         return flask_test_assign_device(machine_bdf);
@@ -1344,7 +1348,7 @@ static int cf_check flask_assign_device(struct domain *d, uint32_t machine_bdf)
 static int cf_check flask_deassign_device(
     struct domain *d, uint32_t machine_bdf)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
 
     rc = current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE);
@@ -1362,7 +1366,7 @@ static int cf_check flask_deassign_device(
 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE)
 static int flask_test_assign_dtdevice(const char *dtpath)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
 
     rc = security_devicetree_sid(dtpath, &rsid);
@@ -1375,10 +1379,10 @@ static int flask_test_assign_dtdevice(const char *dtpath)
 
 static int cf_check flask_assign_dtdevice(struct domain *d, const char *dtpath)
 {
-    u32 dsid, rsid;
+    uint32_t dsid, rsid;
     int rc = -EPERM;
     struct avc_audit_data ad;
-    u32 dperm;
+    uint32_t dperm;
 
     if ( !d )
         return flask_test_assign_dtdevice(dtpath);
@@ -1406,7 +1410,7 @@ static int cf_check flask_assign_dtdevice(struct domain *d, const char *dtpath)
 static int cf_check flask_deassign_dtdevice(
     struct domain *d, const char *dtpath)
 {
-    u32 rsid;
+    uint32_t rsid;
     int rc = -EPERM;
 
     rc = current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE);
@@ -1498,7 +1502,7 @@ static int cf_check flask_do_mca(void)
 
 static int cf_check flask_shadow_control(struct domain *d, uint32_t op)
 {
-    u32 perm;
+    uint32_t perm;
 
     switch ( op )
     {
@@ -1524,14 +1528,14 @@ static int cf_check flask_shadow_control(struct domain *d, uint32_t op)
 }
 
 struct ioport_has_perm_data {
-    u32 ssid;
-    u32 dsid;
-    u32 perm;
-    u32 use_perm;
+    uint32_t ssid;
+    uint32_t dsid;
+    uint32_t perm;
+    uint32_t use_perm;
 };
 
 static int cf_check _ioport_has_perm(
-    void *v, u32 sid, unsigned long start, unsigned long end)
+    void *v, uint32_t sid, unsigned long start, unsigned long end)
 {
     struct ioport_has_perm_data *data = v;
     struct avc_audit_data ad;
@@ -1590,7 +1594,7 @@ static int cf_check flask_mem_sharing_op(
 
 static int cf_check flask_apic(struct domain *d, int cmd)
 {
-    u32 perm;
+    uint32_t perm;
 
     switch ( cmd )
     {
@@ -1622,7 +1626,7 @@ static int cf_check flask_mmu_update(
     struct domain *d, struct domain *t, struct domain *f, uint32_t flags)
 {
     int rc = 0;
-    u32 map_perms = 0;
+    uint32_t map_perms = 0;
 
     if ( t && d != t )
         rc = domain_has_perm(d, t, SECCLASS_MMU, MMU__REMOTE_REMAP);
@@ -1649,7 +1653,7 @@ static int cf_check flask_mmuext_op(struct domain *d, struct domain *f)
 static int cf_check flask_update_va_mapping(
     struct domain *d, struct domain *f, l1_pgentry_t pte)
 {
-    u32 map_perms = MMU__MAP_READ;
+    uint32_t map_perms = MMU__MAP_READ;
     if ( !(l1e_get_flags(pte) & _PAGE_PRESENT) )
         return 0;
     if ( l1e_get_flags(pte) & _PAGE_RW )
@@ -1665,7 +1669,7 @@ static int cf_check flask_priv_mapping(struct domain *d, struct domain *t)
 
 static int cf_check flask_pmu_op(struct domain *d, unsigned int op)
 {
-    u32 dsid = domain_sid(d);
+    uint32_t dsid = domain_sid(d);
 
     switch ( op )
     {
@@ -1694,7 +1698,7 @@ static int cf_check flask_dm_op(struct domain *d)
 
 static int cf_check flask_xen_version(uint32_t op)
 {
-    u32 dsid = domain_sid(current->domain);
+    uint32_t dsid = domain_sid(current->domain);
 
     switch ( op )
     {
@@ -1902,8 +1906,8 @@ static const struct xsm_ops __initconst_cf_clobber flask_ops = {
 #endif
 };
 
-const struct xsm_ops *__init flask_init(const void *policy_buffer,
-                                        size_t policy_size)
+const struct xsm_ops *__init flask_init(
+    const void *policy_buffer, size_t policy_size)
 {
     int ret = -ENOENT;
 
diff --git a/xen/xsm/flask/include/avc.h b/xen/xsm/flask/include/avc.h
index c14bd07a2b..e29949f5a8 100644
--- a/xen/xsm/flask/include/avc.h
+++ b/xen/xsm/flask/include/avc.h
@@ -3,7 +3,7 @@
  *
  * Author : Stephen Smalley, <sds@epoch.ncsc.mil>
  */
- 
+
 /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
 
 #ifndef _FLASK_AVC_H_
diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c
index 55c2b4d8a4..017f5183de 100644
--- a/xen/xsm/flask/ss/avtab.c
+++ b/xen/xsm/flask/ss/avtab.c
@@ -35,7 +35,7 @@ static inline int avtab_hash(struct avtab_key *keyp, u16 mask)
 }
 
 static struct avtab_node* avtab_insert_node(struct avtab *h, int hvalue,
-    struct avtab_node * prev, struct avtab_node * cur, struct avtab_key *key, 
+    struct avtab_node * prev, struct avtab_node * cur, struct avtab_key *key,
                                                     struct avtab_datum *datum)
 {
     struct avtab_node *newnode = xzalloc(struct avtab_node);
@@ -59,7 +59,7 @@ static struct avtab_node* avtab_insert_node(struct avtab *h, int hvalue,
     return newnode;
 }
 
-static int avtab_insert(struct avtab *h, struct avtab_key *key, 
+static int avtab_insert(struct avtab *h, struct avtab_key *key,
                                                     struct avtab_datum *datum)
 {
     int hvalue;
@@ -100,7 +100,7 @@ static int avtab_insert(struct avtab *h, struct avtab_key *key,
  * key/specified mask into the table, as needed by the conditional avtab.
  * It also returns a pointer to the node inserted.
  */
-struct avtab_node * avtab_insert_nonunique(struct avtab * h, 
+struct avtab_node * avtab_insert_nonunique(struct avtab * h,
                             struct avtab_key * key, struct avtab_datum * datum)
 {
     int hvalue;
@@ -110,7 +110,7 @@ struct avtab_node * avtab_insert_nonunique(struct avtab * h,
     if ( !h || !h->htable )
         return NULL;
     hvalue = avtab_hash(key, h->mask);
-    for ( prev = NULL, cur = h->htable[hvalue]; cur; 
+    for ( prev = NULL, cur = h->htable[hvalue]; cur;
                                                 prev = cur, cur = cur->next )
     {
         if ( key->source_type == cur->key.source_type &&
@@ -199,7 +199,7 @@ struct avtab_node* avtab_search_node(struct avtab *h, struct avtab_key *key)
     return NULL;
 }
 
-struct avtab_node* avtab_search_node_next(struct avtab_node *node, 
+struct avtab_node* avtab_search_node_next(struct avtab_node *node,
                                                                 int specified)
 {
     struct avtab_node *cur;
diff --git a/xen/xsm/flask/ss/avtab.h b/xen/xsm/flask/ss/avtab.h
index a2b50c222a..591604f927 100644
--- a/xen/xsm/flask/ss/avtab.h
+++ b/xen/xsm/flask/ss/avtab.h
@@ -74,12 +74,12 @@ int avtab_read_item(struct avtab *a, void *fp, struct policydb *pol,
 
 int avtab_read(struct avtab *a, void *fp, struct policydb *pol);
 
-struct avtab_node *avtab_insert_nonunique(struct avtab *h, 
+struct avtab_node *avtab_insert_nonunique(struct avtab *h,
                             struct avtab_key *key, struct avtab_datum *datum);
 
 struct avtab_node *avtab_search_node(struct avtab *h, struct avtab_key *key);
 
-struct avtab_node *avtab_search_node_next(struct avtab_node *node, 
+struct avtab_node *avtab_search_node_next(struct avtab_node *node,
                                                                 int specified);
 
 #define MAX_AVTAB_HASH_BITS 13
diff --git a/xen/xsm/flask/ss/conditional.c b/xen/xsm/flask/ss/conditional.c
index b4b116666c..e74fc01746 100644
--- a/xen/xsm/flask/ss/conditional.c
+++ b/xen/xsm/flask/ss/conditional.c
@@ -452,7 +452,7 @@ static int cond_read_node(struct policydb *p, struct cond_node *node, void *fp)
             goto err;
         }
 
-        if ( i == 0 ) 
+        if ( i == 0 )
             node->expr = expr;
         else
             last->next = expr;
@@ -513,7 +513,7 @@ err:
 /* Determine whether additional permissions are granted by the conditional
  * av table, and if so, add them to the result
  */
-void cond_compute_av(struct avtab *ctab, struct avtab_key *key, 
+void cond_compute_av(struct avtab *ctab, struct avtab_key *key,
                                                         struct av_decision *avd)
 {
     struct avtab_node *node;
diff --git a/xen/xsm/flask/ss/context.h b/xen/xsm/flask/ss/context.h
index 302b3698a7..311edf8794 100644
--- a/xen/xsm/flask/ss/context.h
+++ b/xen/xsm/flask/ss/context.h
@@ -12,9 +12,9 @@
  *
  * Author : Stephen Smalley, <sds@epoch.ncsc.mil>
  */
- 
+
 /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
- 
+
 #ifndef _SS_CONTEXT_H_
 #define _SS_CONTEXT_H_
 
diff --git a/xen/xsm/flask/ss/mls.c b/xen/xsm/flask/ss/mls.c
index f2fa560810..a3255ae01a 100644
--- a/xen/xsm/flask/ss/mls.c
+++ b/xen/xsm/flask/ss/mls.c
@@ -70,7 +70,7 @@ int mls_compute_context_len(struct context * context)
         }
         if ( l == 0 )
         {
-            if ( mls_level_eq(&context->range.level[0], 
+            if ( mls_level_eq(&context->range.level[0],
                               &context->range.level[1]) )
                 break;
             else
diff --git a/xen/xsm/flask/ss/policydb.c b/xen/xsm/flask/ss/policydb.c
index ff2103c63e..162470bbbd 100644
--- a/xen/xsm/flask/ss/policydb.c
+++ b/xen/xsm/flask/ss/policydb.c
@@ -339,7 +339,7 @@ static int cf_check sens_index(void *key, void *datum, void *datap)
 
     if ( !levdatum->isalias )
     {
-        if ( !levdatum->level->sens || levdatum->level->sens > 
+        if ( !levdatum->level->sens || levdatum->level->sens >
                                                         p->p_levels.nprim )
             return -EINVAL;
         p->p_sens_val_to_name[levdatum->level->sens - 1] = key;
diff --git a/xen/xsm/flask/ss/services.c b/xen/xsm/flask/ss/services.c
index 2f6d3d350d..dab07b5f60 100644
--- a/xen/xsm/flask/ss/services.c
+++ b/xen/xsm/flask/ss/services.c
@@ -99,7 +99,7 @@ static int context_struct_compute_av(struct context *scontext,
  * constraint_expr_eval should pass in NULL for xcontext.
  */
 static int constraint_expr_eval(struct context *scontext,
-                            struct context *tcontext, struct context *xcontext, 
+                            struct context *tcontext, struct context *xcontext,
                                                 struct constraint_expr *cexpr)
 {
     u32 val1, val2;
@@ -1073,7 +1073,7 @@ static int security_compute_sid(u32 ssid,
                 /* Look for a role transition rule. */
                 for ( roletr = policydb.role_tr; roletr; roletr = roletr->next )
                 {
-                    if ( roletr->role == scontext->role && 
+                    if ( roletr->role == scontext->role &&
                                             roletr->type == tcontext->type )
                     {
                         /* Use the role transition rule. */
@@ -1485,7 +1485,7 @@ int security_irq_sid(int pirq, u32 *out_sid)
     POLICY_RDLOCK;
 
     c = policydb.ocontexts[OCON_PIRQ];
-    
+
     while ( c )
     {
         if ( c->u.pirq == pirq )
diff --git a/xen/xsm/flask/ss/sidtab.c b/xen/xsm/flask/ss/sidtab.c
index cd1360cb4a..74babfac9c 100644
--- a/xen/xsm/flask/ss/sidtab.c
+++ b/xen/xsm/flask/ss/sidtab.c
@@ -3,9 +3,9 @@
  *
  * Author : Stephen Smalley, <sds@epoch.ncsc.mil>
  */
- 
+
 /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
- 
+
 #include <xen/lib.h>
 #include <xen/xmalloc.h>
 #include <xen/errno.h>
@@ -192,7 +192,7 @@ void sidtab_map_remove_on_error(struct sidtab *s,
     return;
 }
 
-static inline u32 sidtab_search_context(struct sidtab *s, 
+static inline u32 sidtab_search_context(struct sidtab *s,
                                                         struct context *context)
 {
     int i;
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 20:00:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 20:00:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311221.528353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhzRm-00040w-UK; Fri, 22 Apr 2022 20:00:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311221.528353; Fri, 22 Apr 2022 20:00:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhzRm-00040p-Pa; Fri, 22 Apr 2022 20:00:06 +0000
Received: by outflank-mailman (input) for mailman id 311221;
 Fri, 22 Apr 2022 20:00:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pzHF=VA=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nhzRl-0003wZ-MI
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 20:00:05 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cc04de81-c276-11ec-8fc2-03012f2f19d4;
 Fri, 22 Apr 2022 22:00:03 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23MJxnvV012240
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 22 Apr 2022 15:59:55 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23MJxnPr012239;
 Fri, 22 Apr 2022 12:59:49 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc04de81-c276-11ec-8fc2-03012f2f19d4
Date: Fri, 22 Apr 2022 12:59:49 -0700
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Marek Marczykowski-G??recki <marmarek@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
        Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH 0/1] Adjust odd Python bindings
Message-ID: <YmMJNV0T6K1ih79x@mattapan.m5p.com>
References: <cover.1650551486.git.ehem+xen@m5p.com>
 <YmICI1BPTBIqdgBq@mail-itl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YmICI1BPTBIqdgBq@mail-itl>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

On Fri, Apr 22, 2022 at 03:17:23AM +0200, Marek Marczykowski-G??recki wrote:
> On Thu, Apr 21, 2022 at 07:31:26AM -0700, Elliott Mitchell wrote:
> > I'm unsure how widely the Python bindings are used.  Certainly they were
> > used for PyGRUB.  Have any other projects used them so far?  What I'm
> > doing is likely to be contributed to the Xen Project, and I suspect the
> > existence of other projects would be known...
> 
> Yes, Python bindings are used outside of xen.git. I'm aware of few
> places in Qubes OS, but I expect there are other users too. So, I'm
> afraid breaking the current import method isn't really an option. What
> you could try, is to make both versions work at the same time, but TBH
> I'm not sure how to do that with C extension.

Simplest would have been to address this in 2004, when the Python
bindings had insignificant usage.  Another handy time when things could
have been broken was the Python 2->3 transition.  Yet now both of those
points have passed.

I suspect this could be done by adding some Python code to an __init__.py
file.  Simply redirect attempts to load the old path to the new path.

Other thing I noted is the Python documentation indicates the first
argument to Extension() was wrong.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Fri Apr 22 20:30:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 20:30:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311232.528364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhzuk-0007UZ-AW; Fri, 22 Apr 2022 20:30:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311232.528364; Fri, 22 Apr 2022 20:30:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nhzuk-0007Tm-6P; Fri, 22 Apr 2022 20:30:02 +0000
Received: by outflank-mailman (input) for mailman id 311232;
 Fri, 22 Apr 2022 20:30:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nhzui-0007KR-Qe
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 20:30:00 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f9b0dc89-c27a-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 22:29:58 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id B8F8361772;
 Fri, 22 Apr 2022 20:29:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B21FFC385A4;
 Fri, 22 Apr 2022 20:29:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9b0dc89-c27a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650659396;
	bh=P7rt1gadbKOBoGiZRhZ6zWKaJDOi0iWtl4Li0IVE+ho=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=JD/2AiRdv59h80FLcy4j0yOh6qD1OiyfGW+SCzJggo6ZQZE+RI3C3DQv+x0Ud8sdz
	 eYz1q3MkRuXb7GmdcdCRYhXlg7x90eeBdwc+5kqjg3vT664rqwO+Qd4cgqQeBu1AK5
	 CGWQDB5MJgHeWXfM7CeM2jEQjRX8zhz7HfYJXlVKeLIPU9XYZUVxlSdhoBaG4XFbY5
	 BxaOHtwhXRuNsv/B56GWoYVwh4AocC3/8uvJAS5/c5o8AMKnyVa/6h+cWCKkc61kGd
	 kxUmWMO57aiDeCoOMzyu/2HHRYCHHfe7qHSEqlNlV/RhF+fLUDwXa8eKVdXrgA200M
	 487Y3CfyFlHdw==
Date: Fri, 22 Apr 2022 13:29:54 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: Rahul Singh <Rahul.Singh@arm.com>, Christoph Hellwig <hch@lst.de>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, 
    "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
In-Reply-To: <86bc7ae3-d7af-5f6e-d246-b53a4fa8bc79@suse.com>
Message-ID: <alpine.DEB.2.22.394.2204221319490.915916@ubuntu-linux-20-04-desktop>
References: <20220415063705.GA24262@lst.de> <alpine.DEB.2.22.394.2204150917390.915916@ubuntu-linux-20-04-desktop> <4BC65913-EB0A-441C-A09C-4175697BDE9D@arm.com> <alpine.DEB.2.22.394.2204181225340.915916@ubuntu-linux-20-04-desktop> <49E3535A-5672-4047-AF86-05D5597C7019@arm.com>
 <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop> <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com> <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop> <12279FAE-2141-469E-A424-9984348E84BB@arm.com>
 <alpine.DEB.2.22.394.2204211444190.915916@ubuntu-linux-20-04-desktop> <20220422050405.GA10195@lst.de> <105DB518-DB5B-47F8-852F-C997678BBCE6@arm.com> <86bc7ae3-d7af-5f6e-d246-b53a4fa8bc79@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Apr 2022, Juergen Gross wrote:
> On 22.04.22 13:34, Rahul Singh wrote:
> > Hello Stefano, Christoph,
> > 
> > > On 22 Apr 2022, at 6:04 am, Christoph Hellwig <hch@lst.de> wrote:
> > > 
> > > On Thu, Apr 21, 2022 at 03:01:32PM -0700, Stefano Stabellini wrote:
> > > > swiotlb-xen: handle DMA_ATTR_NO_KERNEL_MAPPING
> > > > 
> > > > If DMA_ATTR_NO_KERNEL_MAPPING is set then the returned vaddr is a struct
> > > > *page instead of the virtual mapping of the buffer.
> > > > 
> > > > In xen_swiotlb_alloc_coherent, do not call virt_to_page, instead use the
> > > > returned pointer directly. Also do not memset the buffer or struct page
> > > > to zero.
> > > > 
> > > > In xen_swiotlb_free_coherent, check DMA_ATTR_NO_KERNEL_MAPPING and set
> > > > the page pointer appropriately.
> > > 
> > > Something like that should work, but it makes swiotlb-xen poke even
> > > more into the opaque dma-direct internals.  I'd rather do something
> > > like the patch below that uses the dma_direct allocator directly for
> > > arm, and simplifies the xen-swiotlb allocator now that it just needs
> > > to cater to the x86 case:
> > > 
> > > diff --git a/arch/arm/include/asm/xen/page-coherent.h
> > > b/arch/arm/include/asm/xen/page-coherent.h
> > > deleted file mode 100644
> > > index 27e984977402b..0000000000000
> > > --- a/arch/arm/include/asm/xen/page-coherent.h
> > > +++ /dev/null
> > > @@ -1,2 +0,0 @@
> > > -/* SPDX-License-Identifier: GPL-2.0 */
> > > -#include <xen/arm/page-coherent.h>
> > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> > > index a7e54a087b802..6e603e5fdebb1 100644
> > > --- a/arch/arm/xen/mm.c
> > > +++ b/arch/arm/xen/mm.c
> > > @@ -118,23 +118,6 @@ bool xen_arch_need_swiotlb(struct device *dev,
> > > 		!dev_is_dma_coherent(dev));
> > > }
> > > 
> > > -int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> > > -				 unsigned int address_bits,
> > > -				 dma_addr_t *dma_handle)
> > > -{
> > > -	if (!xen_initial_domain())
> > > -		return -EINVAL;
> > > -
> > > -	/* we assume that dom0 is mapped 1:1 for now */
> > > -	*dma_handle = pstart;
> > > -	return 0;
> > > -}
> > > -
> > > -void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int
> > > order)
> > > -{
> > > -	return;
> > > -}
> > > -
> > > static int __init xen_mm_init(void)
> > > {
> > > 	struct gnttab_cache_flush cflush;
> > > diff --git a/arch/arm64/include/asm/xen/page-coherent.h
> > > b/arch/arm64/include/asm/xen/page-coherent.h
> > > deleted file mode 100644
> > > index 27e984977402b..0000000000000
> > > --- a/arch/arm64/include/asm/xen/page-coherent.h
> > > +++ /dev/null
> > > @@ -1,2 +0,0 @@
> > > -/* SPDX-License-Identifier: GPL-2.0 */
> > > -#include <xen/arm/page-coherent.h>
> > > diff --git a/arch/x86/include/asm/xen/page-coherent.h
> > > b/arch/x86/include/asm/xen/page-coherent.h
> > > deleted file mode 100644
> > > index 63cd41b2e17ac..0000000000000
> > > --- a/arch/x86/include/asm/xen/page-coherent.h
> > > +++ /dev/null
> > > @@ -1,24 +0,0 @@
> > > -/* SPDX-License-Identifier: GPL-2.0 */
> > > -#ifndef _ASM_X86_XEN_PAGE_COHERENT_H
> > > -#define _ASM_X86_XEN_PAGE_COHERENT_H
> > > -
> > > -#include <asm/page.h>
> > > -#include <linux/dma-mapping.h>
> > > -
> > > -static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t
> > > size,
> > > -		dma_addr_t *dma_handle, gfp_t flags,
> > > -		unsigned long attrs)
> > > -{
> > > -	void *vstart = (void*)__get_free_pages(flags, get_order(size));
> > > -	*dma_handle = virt_to_phys(vstart);
> > > -	return vstart;
> > > -}
> > > -
> > > -static inline void xen_free_coherent_pages(struct device *hwdev, size_t
> > > size,
> > > -		void *cpu_addr, dma_addr_t dma_handle,
> > > -		unsigned long attrs)
> > > -{
> > > -	free_pages((unsigned long) cpu_addr, get_order(size));
> > > -}
> > > -
> > > -#endif /* _ASM_X86_XEN_PAGE_COHERENT_H */
> > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> > > index 47aebd98f52f5..557edb9c54879 100644
> > > --- a/drivers/xen/swiotlb-xen.c
> > > +++ b/drivers/xen/swiotlb-xen.c
> > > @@ -36,7 +36,6 @@
> > > #include <xen/hvc-console.h>
> > > 
> > > #include <asm/dma-mapping.h>
> > > -#include <asm/xen/page-coherent.h>
> > > 
> > > #include <trace/events/swiotlb.h>
> > > #define MAX_DMA_BITS 32
> > > @@ -104,6 +103,7 @@ static int is_xen_swiotlb_buffer(struct device *dev,
> > > dma_addr_t dma_addr)
> > > 	return 0;
> > > }
> > > 
> > > +#ifdef CONFIG_X86
> > > static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
> > > {
> > > 	int rc;
> > > @@ -129,6 +129,12 @@ static int xen_swiotlb_fixup(void *buf, unsigned long
> > > nslabs)
> > > 	} while (i < nslabs);
> > > 	return 0;
> > > }
> > > +#else
> > > +static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
> > > +{
> > > +	return 0;
> > > +}
> > > +#endif
> > > 
> > > enum xen_swiotlb_err {
> > > 	XEN_SWIOTLB_UNKNOWN = 0,
> > > @@ -256,97 +262,60 @@ void __init xen_swiotlb_init_early(void)
> > > 		panic("Cannot allocate SWIOTLB buffer");
> > > 	swiotlb_set_max_segment(PAGE_SIZE);
> > > }
> > > -#endif /* CONFIG_X86 */
> > > 
> > > static void *
> > > -xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
> > > -			   dma_addr_t *dma_handle, gfp_t flags,
> > > -			   unsigned long attrs)
> > > +xen_swiotlb_alloc_coherent(struct device *dev, size_t size,
> > > +		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
> > > {
> > > -	void *ret;
> > > +	u64 dma_mask = dev->coherent_dma_mask;
> > > 	int order = get_order(size);
> > > -	u64 dma_mask = DMA_BIT_MASK(32);
> > > 	phys_addr_t phys;
> > > -	dma_addr_t dev_addr;
> > > -
> > > -	/*
> > > -	* Ignore region specifiers - the kernel's ideas of
> > > -	* pseudo-phys memory layout has nothing to do with the
> > > -	* machine physical layout.  We can't allocate highmem
> > > -	* because we can't return a pointer to it.
> > > -	*/
> > > -	flags &= ~(__GFP_DMA | __GFP_HIGHMEM);
> > > +	void *ret;
> > > 
> > > -	/* Convert the size to actually allocated. */
> > > +	/* Align the allocation to the Xen page size */
> > > 	size = 1UL << (order + XEN_PAGE_SHIFT);
> > > 
> > > -	/* On ARM this function returns an ioremap'ped virtual address for
> > > -	 * which virt_to_phys doesn't return the corresponding physical
> > > -	 * address. In fact on ARM virt_to_phys only works for kernel direct
> > > -	 * mapped RAM memory. Also see comment below.
> > > -	 */
> > > -	ret = xen_alloc_coherent_pages(hwdev, size, dma_handle, flags, attrs);
> > > -
> > > +	ret = (void *)__get_free_pages(flags, get_order(size));
> > > 	if (!ret)
> > > 		return ret;
> > > -
> > > -	if (hwdev && hwdev->coherent_dma_mask)
> > > -		dma_mask = hwdev->coherent_dma_mask;
> > > -
> > > -	/* At this point dma_handle is the dma address, next we are
> > > -	 * going to set it to the machine address.
> > > -	 * Do not use virt_to_phys(ret) because on ARM it doesn't correspond
> > > -	 * to *dma_handle. */
> > > -	phys = dma_to_phys(hwdev, *dma_handle);
> > > -	dev_addr = xen_phys_to_dma(hwdev, phys);
> > > -	if (((dev_addr + size - 1 <= dma_mask)) &&
> > > -	    !range_straddles_page_boundary(phys, size))
> > > -		*dma_handle = dev_addr;
> > > -	else {
> > > -		if (xen_create_contiguous_region(phys, order,
> > > -						 fls64(dma_mask), dma_handle)
> > > != 0) {
> > > -			xen_free_coherent_pages(hwdev, size, ret,
> > > (dma_addr_t)phys, attrs);
> > > -			return NULL;
> > > -		}
> > > -		*dma_handle = phys_to_dma(hwdev, *dma_handle);
> > > +	phys = virt_to_phys(ret);
> > > +
> > > +	*dma_handle = xen_phys_to_dma(dev, phys);
> > > +	if (*dma_handle + size - 1 > dma_mask ||
> > > +	    range_straddles_page_boundary(phys, size)) {
> > > +		if (xen_create_contiguous_region(phys, order, fls64(dma_mask),
> > > +				dma_handle) != 0)
> > > +			goto out_free_pages;
> > > 		SetPageXenRemapped(virt_to_page(ret));
> > > 	}
> > > +
> > > 	memset(ret, 0, size);
> > > 	return ret;
> > > +
> > > +out_free_pages:
> > > +	free_pages((unsigned long)ret, get_order(size));
> > > +	return NULL;
> > > }
> > > 
> > > static void
> > > -xen_swiotlb_free_coherent(struct device *hwdev, size_t size, void *vaddr,
> > > -			  dma_addr_t dev_addr, unsigned long attrs)
> > > +xen_swiotlb_free_coherent(struct device *dev, size_t size, void *vaddr,
> > > +		dma_addr_t dma_handle, unsigned long attrs)
> > > {
> > > +	phys_addr_t phys = virt_to_phys(vaddr);
> > > 	int order = get_order(size);
> > > -	phys_addr_t phys;
> > > -	u64 dma_mask = DMA_BIT_MASK(32);
> > > -	struct page *page;
> > > -
> > > -	if (hwdev && hwdev->coherent_dma_mask)
> > > -		dma_mask = hwdev->coherent_dma_mask;
> > > -
> > > -	/* do not use virt_to_phys because on ARM it doesn't return you the
> > > -	 * physical address */
> > > -	phys = xen_dma_to_phys(hwdev, dev_addr);
> > > 
> > > 	/* Convert the size to actually allocated. */
> > > 	size = 1UL << (order + XEN_PAGE_SHIFT);
> > > 
> > > -	if (is_vmalloc_addr(vaddr))
> > > -		page = vmalloc_to_page(vaddr);
> > > -	else
> > > -		page = virt_to_page(vaddr);
> > > +	if (WARN_ON_ONCE(dma_handle + size - 1 > dev->coherent_dma_mask) ||
> > > +	    WARN_ON_ONCE(range_straddles_page_boundary(phys, size)))
> > > +	    	return;
> > > 
> > > -	if (!WARN_ON((dev_addr + size - 1 > dma_mask) ||
> > > -		     range_straddles_page_boundary(phys, size)) &&
> > > -	    TestClearPageXenRemapped(page))
> > > +	if (TestClearPageXenRemapped(virt_to_page(vaddr)))
> > > 		xen_destroy_contiguous_region(phys, order);
> > > -
> > > -	xen_free_coherent_pages(hwdev, size, vaddr, phys_to_dma(hwdev, phys),
> > > -				attrs);
> > > +	free_pages((unsigned long)vaddr, get_order(size));
> > > }
> > > +#endif /* CONFIG_X86 */
> > > 
> > > /*
> > >   * Map a single buffer of the indicated size for DMA in streaming mode.
> > > The
> > > @@ -549,8 +518,13 @@ xen_swiotlb_dma_supported(struct device *hwdev, u64
> > > mask)
> > > }
> > > 
> > > const struct dma_map_ops xen_swiotlb_dma_ops = {
> > > +#ifdef CONFIG_X86
> > > 	.alloc = xen_swiotlb_alloc_coherent,
> > > 	.free = xen_swiotlb_free_coherent,
> > > +#else
> > > +	.alloc = dma_direct_alloc,
> > > +	.free = dma_direct_free,
> > > +#endif
> > > 	.sync_single_for_cpu = xen_swiotlb_sync_single_for_cpu,
> > > 	.sync_single_for_device = xen_swiotlb_sync_single_for_device,
> > > 	.sync_sg_for_cpu = xen_swiotlb_sync_sg_for_cpu,
> > > diff --git a/include/xen/arm/page-coherent.h
> > > b/include/xen/arm/page-coherent.h
> > > deleted file mode 100644
> > > index b9cc11e887ed5..0000000000000
> > > --- a/include/xen/arm/page-coherent.h
> > > +++ /dev/null
> > > @@ -1,20 +0,0 @@
> > > -/* SPDX-License-Identifier: GPL-2.0 */
> > > -#ifndef _XEN_ARM_PAGE_COHERENT_H
> > > -#define _XEN_ARM_PAGE_COHERENT_H
> > > -
> > > -#include <linux/dma-mapping.h>
> > > -#include <asm/page.h>
> > > -
> > > -static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t
> > > size,
> > > -		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
> > > -{
> > > -	return dma_direct_alloc(hwdev, size, dma_handle, flags, attrs);
> > > -}
> > > -
> > > -static inline void xen_free_coherent_pages(struct device *hwdev, size_t
> > > size,
> > > -		void *cpu_addr, dma_addr_t dma_handle, unsigned long attrs)
> > > -{
> > > -	dma_direct_free(hwdev, size, cpu_addr, dma_handle, attrs);
> > > -}
> > > -
> > > -#endif /* _XEN_ARM_PAGE_COHERENT_H */
> > 
> > Thanks for sharing the patch to fix the issue.
> > I tested both the patches and both the patches work fine.
> 
> I guess you fixed Stefano's patch (the line "virt_to_page(ret);" was missing
> a "page = ").
> 
> I'd be in favor of Christoph's patch, assuming it will work on x86, too.

I also prefer Christoph's patch :-)

It is great to remove xen_alloc_coherent_pages/xen_free_coherent_pages
for ARM. We can safely remove them because on ARM we can only use
swiotlb-xen when the domain is 1:1 mapped. So it is impossible to get
into a situation where memory allocated expected to be contiguous is not
actually contiguous.

So, from an ARM point of view, it is great. However,
DMA_ATTR_NO_KERNEL_MAPPING wouldn't work on x86 still? I don't know if
matters.

Then a small NIT: the declaration of xen_create_contiguous_region and
xen_destroy_contiguous_region should be moved away from
include/xen/xen-ops.h to an arch/x86 specific header. For instance to
arch/x86/include/asm/xen/swiotlb-xen.h. Or at least the #ifdef in
include/xen/xen-ops.h should change, currently it is:

#if defined(CONFIG_XEN_PV) || defined(CONFIG_ARM) || defined(CONFIG_ARM64)
int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
				unsigned int address_bits,
				dma_addr_t *dma_handle);
void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order);
#endif


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 20:36:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 20:36:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311237.528374 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni01N-0000av-0r; Fri, 22 Apr 2022 20:36:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311237.528374; Fri, 22 Apr 2022 20:36:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni01M-0000ao-UD; Fri, 22 Apr 2022 20:36:52 +0000
Received: by outflank-mailman (input) for mailman id 311237;
 Fri, 22 Apr 2022 20:36:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni01L-0000ai-DK
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 20:36:51 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ef701d92-c27b-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 22:36:50 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 209F161D93;
 Fri, 22 Apr 2022 20:36:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26FDAC385AA;
 Fri, 22 Apr 2022 20:36:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef701d92-c27b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650659808;
	bh=a+XR4UoEGJUvtEOaoDDXPDz++it2F/wJ7l1aRxdt+0A=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=U1C6BKzOQuYL/nfuZoLkjlUF20h2YUwLxJY1jSCzxIVnBUp4EdJZVs73O1Pn6Utof
	 mjCRxX9TNkmFvZRFKUp56ZToSf4XCNw3aT2W7Bb3Wj1WnU12GEiA8K4+pF9M/zJgab
	 Izb9tqF2ccr987MY+dxr3hXiq9qVIVBJ5f2n2B6Jbyvz1tasMZIf9LgX+MYnKR/xjG
	 E7WDSqaSUS+UtgaJCSFEciax2GbqTfgDORciTT4qkV5m2axVo/H+60yclotNZx8AJ0
	 da1zxk6XQKfI87Sn8gDX/QDKt5eLqEfHH35itwJbVBrcOOqKMbhg2APRBh3695gRXT
	 MN2pwmL/0NspQ==
Date: Fri, 22 Apr 2022 13:36:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Stephen Rothwell <sfr@canb.auug.org.au>
cc: Juergen Gross <jgross@suse.com>, 
    Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Xen Devel <xen-devel@lists.xenproject.org>, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>, 
    Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, 
    Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the xen-tip
 tree
In-Reply-To: <20220422111438.3946dbae@canb.auug.org.au>
Message-ID: <alpine.DEB.2.22.394.2204221336170.915916@ubuntu-linux-20-04-desktop>
References: <20220422111438.3946dbae@canb.auug.org.au>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Juergen, Boris,

I forced-pushed the linux-next and for-linus-5.18 branches to solve the
issue


On Fri, 22 Apr 2022, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   b12d41716e32 ("arm/xen: Fix some refcount leaks")
> 
> is missing a Signed-off-by from its committer.
> 
> -- 
> Cheers,
> Stephen Rothwell
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 20:51:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 20:51:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311242.528385 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni0Ey-000378-3e; Fri, 22 Apr 2022 20:50:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311242.528385; Fri, 22 Apr 2022 20:50:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni0Ey-000371-0n; Fri, 22 Apr 2022 20:50:56 +0000
Received: by outflank-mailman (input) for mailman id 311242;
 Fri, 22 Apr 2022 20:50:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni0Ex-00036s-Bj
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 20:50:55 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e591712b-c27d-11ec-a405-831a346695d4;
 Fri, 22 Apr 2022 22:50:52 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 811C961E2E;
 Fri, 22 Apr 2022 20:50:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AA93C385A4;
 Fri, 22 Apr 2022 20:50:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e591712b-c27d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650660650;
	bh=gFSZw1Eb+mNPjde0203NmcMSAeWbwTZAL8XaqiiefaA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=MP55Ki1tdZUrSBQnPWt2qCAKbsLQkw/nf8VuC32V1kwaQ8iWPDsg9QJM3fu3wr67x
	 lb9NlZmuM39Dpw6X/WZeOSOZIdz9SDMSu+0CFJIZkrwfjzunHD9GnOHJp5fUZKsNK+
	 +/wj3WMf/ddGwo4mclvD+/U4c/2Hxeblx/xfRk1yUuhyj3rCBJydJj1HQkh+epQfGI
	 ib1yXRrbYRutHCnrCu6zAtuO2WfcwuBP3Vunfv5gtRwYp0OjSIGho57dTs2YYfUmao
	 U0hKFYZCXqoVrdMmsfxvjG9kVQcR5SQQXog5/9brk4Qt90fdskLvFSfbRMEur1j0os
	 lP2fosh+xFqDQ==
Date: Fri, 22 Apr 2022 13:50:49 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <Wei.Chen@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "julien@xen.org" <julien@xen.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Penny Zheng <Penny.Zheng@arm.com>
Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftB
In-Reply-To: <cdfe5b2c-3973-03d4-8fb2-dc8eab73b8b0@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204221338430.915916@ubuntu-linux-20-04-desktop>
References: <PAXPR08MB742064F5F00A18E09DEF66B69E1A9@PAXPR08MB7420.eurprd08.prod.outlook.com> <alpine.DEB.2.22.394.2204141613340.915916@ubuntu-linux-20-04-desktop> <cdfe5b2c-3973-03d4-8fb2-dc8eab73b8b0@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Apr 2022, Wei Chen wrote:
> On 2022/4/15 8:41, Stefano Stabellini wrote:
> > On Fri, 25 Mar 2022, Wei Chen wrote:
> > > # Proposal for Porting Xen to Armv8-R64
> > > 
> ...
> > > ## 2. Proposed changes of Xen
> > > ### **2.1. Changes of build system:**
> > > 
> > > - ***Introduce new Kconfig options for Armv8-R64***:
> > >    Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not
> > >    expect one Xen binary to run on all machines. Xen images are not common
> > >    across Armv8-R64 platforms. Xen must be re-built for different
> > > Armv8-R64
> > >    platforms. Because these platforms may have different memory layout and
> > >    link address.
> > >      - `ARM64_V8R`:
> > >        This option enables Armv8-R profile for Arm64. Enabling this option
> > >        results in selecting MPU. This Kconfig option is used to gate some
> > >        Armv8-R64 specific code except MPU code, like some code for
> > > Armv8-R64
> > >        only system ID registers access.
> > > 
> > >      - `ARM_MPU`
> > >        This option enables MPU on Armv8-R architecture. Enabling this
> > > option
> > >        results in disabling MMU. This Kconfig option is used to gate some
> > >        ARM_MPU specific code. Once when this Kconfig option has been
> > > enabled,
> > >        the MMU relate code will not be built for Armv8-R64. The reason why
> > >        not depends on runtime detection to select MMU or MPU is that, we
> > > don't
> > >        think we can use one image for both Armv8-R64 and Armv8-A64.
> > > Another
> > >        reason that we separate MPU and V8R in provision to allow to
> > > support MPU
> > >        on 32bit Arm one day.
> > > 
> > >    ***Try to use `if ( IS_ENABLED(CONFIG_ARMXXXX) )` instead of
> > > spreading***
> > >    ***`#ifdef CONFIG_ARMXXXX` everywhere, if it is possible.***
> > > 
> > > - ***About Xen start address for Armv8-R64***:
> > >    On Armv8-A, Xen has a fixed virtual start address (link address too) on
> > > all
> > >    Armv8-A platforms. In an MMU based system, Xen can map its loaded
> > > address
> > >    to this virtual start address. On Armv8-A platforms, the Xen start
> > > address
> > >    does not need to be configurable. But on Armv8-R platforms, they don't
> > > have
> > >    MMU to map loaded address to a fixed virtual address. And different
> > > platforms
> > >    will have very different address space layout, so it's impossible for
> > > Xen to
> > >    specify a fixed physical address for all Armv8-R platforms' start
> > > address.
> > > 
> > >    - `XEN_START_ADDRESS`
> > >      This option allows to set the custom address at which Xen will be
> > >      linked. This address must be aligned to a page size. Xen's run-time
> > >      addresses are the same as the link time addresses.
> > >      ***Notes: Fixed link address means the Xen binary could not be***
> > >      ***relocated by EFI loader. So in current stage, Xen could not***
> > >      ***be launched as an EFI application on Armv8-R64.(TODO#3.3)***
> > > 
> > >      - Provided by platform files.
> > >        We can reuse the existed arm/platforms store platform specific
> > > files.
> > >        And `XEN_START_ADDRESS` is one kind of platform specific
> > > information.
> > >        So we can use platform file to define default `XEN_START_ADDRESS`
> > > for
> > >        each platform.
> > > 
> > >      - Provided by Kconfig.
> > >        This option can be an independent or a supplymental option. Users
> > > can
> > >        define a customized `XEN_START_ADDRESS` to override the default
> > > value
> > >        in platform's file.
> > > 
> > >      - Generated from device tree by build scripts (optional)
> > >        Vendors who want to enable Xen on their Armv8-R platforms, they can
> > >        use some tools/scripts to parse their boards device tree to
> > > generate
> > >        the basic platform information. These tools/scripts do not
> > > necessarily
> > >        need to be integrated in Xen, but Xen can give some recommended
> > >        configuration. For example, Xen can recommend Armv8-R platforms to
> > > use
> > >        lowest ram start address + 2MB as the default Xen start address.
> > >        The generated platform files can be placed to arm/platforms for
> > >        maintenance.
> > > 
> > >      - Enable Xen PIC/PIE (optional)
> > >        We have mentioned about PIC/PIE in section 1.2. With PIC/PIE
> > > support,
> > >        Xen can run from everywhere it has been loaded. But it's rare to
> > > use
> > >        PIC/PIE on a real-time system (code size, more memory access). So a
> > >        partial PIC/PIE image maybe better (see 3. TODO section). But
> > > partial
> > >        PIC/PIE image may not solve this Xen start address issue.
> > 
> > I like the description of the XEN_START_ADDRESS problem and solutions.
> > 
> > For the initial implementation, a platform file is fine. We need to
> > start easy.
> > 
> > Afterwards, I think it would be far better to switch to a script that
> > automatically generates XEN_START_ADDRESS from the host device tree.
> > Also, if we provide a way to customize the start address via Kconfig,
> > then the script that reads the device tree could simply output the right
> > CONFIG_* option for Xen to build. It wouldn't even have to generate an
> > header file.
> 
> Ok,I will update the proposal to create two steps for XEN_START_ADDRESS:
> stage 1: Use the platform files for XEN_START_ADDRESS. If no platform
>          has been selected, provide Kconfig option for users to do
>          customization.
> stage 2: Try to switch to use scripts that can automatically generate
>          XEN_START_ADDRESS from the host device tree. But still keep
>          Kconfig customization option.
> 
> And for the PIC/PIE option,I will move it to TODO list so that we
> have records for future discussions.Becuase this feature for an
> MPU system, its priority is not very high.

That sounds good to me

 
> > > - ***About MPU initialization before parsing device tree***:
> > >        Before Xen can start parsing information from device tree and use
> > >        this information to setup MPU, Xen need an initial MPU state. This
> > >        is because:
> > >        1. More deterministic: Arm MPU supports background regions, if we
> > >           don't configure the MPU regions and don't enable MPU. The
> > > default
> > >           MPU background attributes will take effect. The default
> > > background
> > >           attributes are `IMPLEMENTATION DEFINED`. That means all RAM
> > > regions
> > >           may be configured to device memory and RWX. Random values in RAM
> > > or
> > >           maliciously embedded data can be exploited.
> > >        2. More compatible: On some Armv8-R64 platforms, if MPU is
> > > disabled,
> > >           the `dc zva` instruction will make the system halt (This is one
> > >           side effect of MPU background attributes, the RAM has been
> > > configured
> > >           as device memory). And this instruction will be embedded in some
> > >           built-in functions, like `memory set`. If we use `-ddont_use_dc`
> > > to
> > >           rebuild GCC, the built-in functions will not contain `dc zva`.
> > >           However, it is obviously unlikely that we will be able to
> > > recompile
> > >           all GCC for ARMv8-R64.
> > > 
> > >      - Reuse `XEN_START_ADDRESS`
> > >        In the very beginning of Xen boot, Xen just need to cover a limited
> > >        memory range and very few devices (actually only UART device). So
> > > we
> > >        can use two MPU regions to map:
> > >        1. `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or.
> > >           `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_size`as
> > >           normal memory.
> > >        2. `UART` MMIO region base to `UART` MMIO region end to device
> > > memory.
> > >        These two are enough to support Xen run in boot time. And we don't
> > > need
> > >        to provide additional platform information for initial normal
> > > memory
> > >        and device memory regions. In current PoC we have used this option
> > >        for implementation, and it's the same as Armv8-A.
> > > 
> > >      - Additional platform information for initial MPU state
> > >        Introduce some macros to allow users to set initial normal
> > >        memory regions:
> > >        `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END`
> > >        and device memory:
> > >        `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END`
> > >        These macros are the same platform specific information as
> > >        `XEN_START_ADDRESS`, so the options#1/#2/#3 of generating
> > >        `XEN_START_ADDRESS` also can be applied to these macros.
> > >        ***From our current PoC work, we think these macros may***
> > >        ***not be necessary. But we still place them here to see***
> > >        ***whether the community will have some different scenarios***
> > >        ***that we haven't considered.***
> > 
> > I think it is fine for now. And their values could be automatically
> > generated by the same script that will automatically generate
> > XEN_START_ADDRESS from the host device tree.
> > 
> 
> Ok, we will keep current PoC "Reuse `XEN_START_ADDRESS`" for
> day1 patch. We will update the proposal to address it. And place
> script generatation in stage2.
> 
> > 
> > > - ***Define new system registers for compiliers***:
> > >    Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
> > >    specific system registers. As Armv8-R64 only have secure state, so
> > >    at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
> > >    first GCC version that supports Armv8.4 is GCC 8.1. In addition to
> > >    these, PMSA of Armv8-R64 introduced lots of MPU related system
> > > registers:
> > >    `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
> > >    `MPUIR_ELx`. But the first GCC version to support these system
> > > registers
> > >    is GCC 11. So we have two ways to make compilers to work properly with
> > >    these system registers.
> > >    1. Bump GCC version to GCC 11.
> > >       The pros of this method is that, we don't need to encode these
> > >       system registers in macros by ourselves. But the cons are that,
> > >       we have to update Makefiles to support GCC 11 for Armv8-R64.
> > >       1.1. Check the GCC version 11 for Armv8-R64.
> > >       1.2. Add march=armv8r to CFLAGS for Armv8-R64.
> > >       1.3. Solve the confliction of march=armv8r and mcpu=generic
> > >      These changes will affect common Makefiles, not only Arm Makefiles.
> > >      And GCC 11 is new, lots of toolchains and Distro haven't supported
> > > it.
> > > 
> > >    2. Encode new system registers in macros ***(preferred)***
> > >          ```
> > >          /* Virtualization Secure Translation Control Register */
> > >          #define VSTCR_EL2  S3_4_C2_C6_2
> > >          /* Virtualization System Control Register */
> > >          #define VSCTLR_EL2 S3_4_C2_C0_0
> > >          /* EL1 MPU Protection Region Base Address Register encode */
> > >          #define PRBAR_EL1  S3_0_C6_C8_0
> > >          ...
> > >          /* EL2 MPU Protection Region Base Address Register encode */
> > >          #define PRBAR_EL2  S3_4_C6_C8_0
> > >          ...
> > >          ```
> > >       If we encode all above system registers, we don't need to bump GCC
> > >       version. And the common CFLAGS Xen is using still can be applied to
> > >       Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS.
> > >       ***Notes:***
> > >       ***Armv8-R AArch64 supports the A64 ISA instruction set with***
> > >       ***some modifications:***
> > >       ***Redefines DMB, DSB, and adds an DFB. But actually, the***
> > >       ***encodings of DMB and DSB are still the same with A64.***
> > >       ***And DFB is an alias of DSB #12. In this case, we think***
> > >       ***we don't need a new architecture specific flag to***
> > >       ***generate new instructions for Armv8-R.***
> > 
> > I think that for the initial implementation either way is fine. I agree
> > that macros would be better than requiring GCC 11.
> > 
> 
> Ok. We will use macros in day1. We can have a standalone patch set
> to bump GCC version in the future. Based on some of the attempts we've
> made, it will affect some makefile scripts of common and other
> architectures.
> 
> 
> > 
> > > ### **2.2. Changes of the initialization process**
> > > 
> > > **A sample device tree of memory layout restriction**:
> > > ```
> > > chosen {
> > >      ...
> > >      /*
> > >       * Define a section to place boot modules,
> > >       * all boot modules must be placed in this section.
> > >       */
> > >      mpu,boot-module-section = <0x10000000 0x10000000>;
> > >      /*
> > >       * Define a section to cover all guest RAM. All guest RAM must be
> > > located
> > >       * within this section. The pros is that, in best case, we can only
> > > have
> > >       * one MPU protection region to map all guest RAM for Xen.
> > >       */
> > >      mpu,guest-memory-section = <0x20000000 0x30000000>;
> > >      /*
> > >       * Define a memory section that can cover all device memory that
> > >       * will be used in Xen.
> > >       */
> > >      mpu,device-memory-section = <0x80000000 0x7ffff000>;
> > >      /* Define a section for Xen heap */
> > >      xen,static-mem = <0x50000000 0x20000000>;
> > > 
> > >      domU1 {
> > >          ...
> > >          #xen,static-mem-address-cells = <0x01>;
> > >          #xen,static-mem-size-cells = <0x01>;
> > >          /* Statically allocated guest memory, within
> > > mpu,guest-memory-section */
> > >          xen,static-mem = <0x30000000 0x1f000000>;
> > > 
> > >          module@11000000 {
> > >              compatible = "multiboot,kernel\0multiboot,module";
> > >              /* Boot module address, within mpu,boot-module-section */
> > >              reg = <0x11000000 0x3000000>;
> > >              ...
> > >          };
> > > 
> > >          module@10FF0000 {
> > >                  compatible = "multiboot,device-tree\0multiboot,module";
> > >                  /* Boot module address, within mpu,boot-module-section */
> > >                  reg = <0x10ff0000 0x10000>;
> > >                  ...
> > >          };
> > >      };
> > > };
> > > ```
> > > It's little hard for users to compose such a device tree by hand. Based
> > > on the discussion of Draft-A, Xen community suggested users to use some
> > > tools like
> > > [imagebuilder](https://gitlab.com/ViryaOS/imagebuilder/-/blob/master/scripts/uboot-script-gen#L390)
> > > to generate the above device tree properties.
> > > Please goto TODO#3.3 section to get more details of this suggestion.
> > 
> > Yes, I think we'll need an ImageBuilder script to populate these entries
> > automatically. With George's help, I moved ImageBuilder to Xen Project.
> > This is the new repository: https://gitlab.com/xen-project/imagebuilder
> > 
> > The script to generate mpu,boot-module-section and the other mpu
> > addresses could be the same ImageBuilder script that generates also
> > XEN_START_ADDRESS.
> > 
> 
> That's great, I will update the link in proposal.
> 
> > 
> > > ### **2.4. Changes of memory management**
> > > Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to
> > > decouple Xen from VMSA. And give Xen the ablity to manage memory in PMSA.
> ...          ```
> > > 
> > > ### **2.5. Changes of guest management**
> ...
> > > 
> > > ### **2.6. Changes of exception trap**
> ...
> > > 
> > > ### **2.5. Changes of device driver**
> ...
> > > 
> > > ## 3. TODO
> ...
> > > 
> > > ### 3.1. Alternative framework support
> ...
> > > 
> > > ### 3.2. Xen Event Channel Support
> ...
> > > ### 3.3. Xen Partial PIC/PIE
> ...
> > > 
> > > ### 3.4. A tool to generate Armv8-R Xen device tree
> > > 1. Use a tool to generate above device tree property.
> > >     This tool will have some similar inputs as below:
> > >     ---
> > >     DEVICE_TREE="fvp_baremetal.dtb"
> > >     XEN="4.16-2022.1/xen"
> > > 
> > >     NUM_DOMUS=1
> > >     DOMU_KERNEL[0]="4.16-2022.1/Image-domU"
> > >     DOMU_RAMDISK[0]="4.16-2022.1/initrd.cpio"
> > >     DOMU_PASSTHROUGH_DTB[0]="4.16-2022.1/passthrough-example-dev.dtb"
> > >     DOMU_RAM_BASE[0]=0x30000000
> > >     DOMU_RAM_SIZE[0]=0x1f000000
> > >     ---
> > >     Using above inputs, the tool can generate a device tree similar as
> > >     we have described in sample.
> > > 
> > >     - `mpu,guest-memory-section`:
> > >     This section will cover all guests' RAM (`xen,static-mem` defined
> > > regions
> > >     in all DomU nodes). All guest RAM must be located within this section.
> > >     In the best case, we can only have one MPU protection region to map
> > > all
> > >     guests' RAM for Xen.
> > > 
> > >     If users set `DOMU_RAM_BASE` and `DOMU_RAM_SIZE`, these will be
> > > converted
> > >     to the base and size of `xen,static-mem`. This tool will scan all
> > >     `xen, static-mem` in DomU nodes to determin the base and size of
> > >     `mpu,guest-memory-section`. If there is any other kind of memory usage
> > >     has been detected in this section, this tool can report an error.
> > >     Except build time check, Xen also need to do runtime check to prevent
> > > a
> > >     bad device tree that generated by malicious tools.
> > > 
> > >     If users set `DOMU_RAM_SIZE` only, this will be converted to the size
> > > of
> > >     `xen,static-mem` only. Xen will allocate the guest memory in runtime,
> > > but
> > >     not from Xen heap. `mpu,guest-memory-section` will be caculated in
> > > runtime
> > >     too. The property in device tree doesn't need or will be ignored by
> > > Xen.
> > 
> > I am fine with this. You should also know that there was a recent
> > discussion about adding something like:
> > 
> > # address size address size ...
> > DOMU_STATIC_MEM_RANGES[0]="0xe000000 0x1000000 0xa0000000 0x30000000"
> > 
> > to the ImageBuilder config file.
> > 
> 
> Thanks for this update : )
> 
> > 
> > >     - `mpu,boot-module-section`:
> > >     This section will be used to store the boot modules like DOMU_KERNEL,
> > >     DOMU_RAMDISK, and DOMU_PASSTHROUGH_DTB. Xen keeps all boot modules in
> > >     this section to meet the requirement of DomU restart on Armv8-R. In
> > >     current stage, we don't have a privilege domain like Dom0 that can
> > >     access filesystem to reload DomU images.
> > > 
> > >     And in current Xen code, the base and size are mandatory for boot
> > > modules
> > >     If users don't specify the base of each boot module, the tool will
> > >     allocte a base for each module. And the tool will generate the
> > >     `mpu,boot-module-section` region, when it finishs boot module memory
> > >     allocation.
> > > 
> > >     Users also can specify the base and size of each boot module, these
> > > will
> > >     be converted to the base and size of module's `reg` directly. The tool
> > >     will scan all modules `reg` in DomU nodes to generate the base and
> > > size of
> > >     `mpu,boot-module-section`. If there is any kind of other memory usage
> > >     has been detected in this section, this tool can report an error.
> > >     Except build time check, Xen also need to do runtime check to prevent
> > > a
> > >     bad device tree that generated by malicious tools.
> > 
> > Xen should always check for the validity of its input. However I should
> > point out that there is no "malicious tool" in this picture because a
> > malicious entity with access to the tool would also have access to Xen
> > directly, so they might as well replace the Xen binary.
> > 
> 
> Ok, I will drop the "malicious tools". But I think the "bug tools" still
> can be possible : )
> 
> > 
> > >     - `mpu,device-memory-section`:
> > >     This section will cover all device memory that will be used in Xen.
> > > Like
> > >     `UART`, `GIC`, `SMMU` and other devices. We haven't considered
> > > multiple
> > >     `mpu,device-memory-section` scenarios. The devices' memory and RAM are
> > >     interleaving in physical address space, it would be required to use
> > >     multiple `mpu,device-memory-section` to cover all devices. This layout
> > >     is common on Armv8-A system, especially in server. But it's rare in
> > >     Armv8-R. So in current stage, we don't want to allow multiple
> > >     `mpu,device-memory-section`. The tool can scan baremetal device tree
> > >     to sort all devices' memory ranges. And calculate a proper region for
> > >     `mpu,device-memory-section`. If it find Xen need multiple
> > >     `mpu,device-memory-section`, it can report an unsupported error.
> > > 
> > > 2. Use a tool to generate device tree property and platform files
> > >     This opinion still uses the same inputs as opinion#1. But this tool
> > > only
> > >     generates `xen,static-mem` and `module` nodes in DomU nodes, it will
> > > not
> > >     generate `mpu,guest-memory-section`, `mpu,boot-module-section` and
> > >     `mpu,device-memory-section` properties in device tree. This will
> > >     generate following macros:
> > >     `MPU_GUEST_MEMORY_SECTION_BASE`, `MPU_GUEST_MEMORY_SECTION_SIZE`
> > >     `MPU_BOOT_MODULE_SECTION_BASE`, `MPU_BOOT_MODULE_SECTION_SIZE`
> > >     `MPU_DEVICE_MEMORY_SECTION_BASE`, `MPU_DEVICE_MEMORY_SECTION_SIZE`
> > >     in platform files in build time. In runtime, Xen will skip the device
> > >     tree parsing for `mpu,guest-memory-section`, `mpu,boot-module-section`
> > >     and `mpu,device-memory-section`. And instead Xen will use these macros
> > >     to do runtime check.
> > >     But, this also means these macros only exist in local build system,
> > >     these macros will not be maintained in Xen repo.
> > 
> > Yes this makes sense to me.
> > 
> > I think we should add both scripts to the imagebuilder repository. This
> > way, they could share code easily, and we can keep the documentation in
> > a single place.
> 
> Can I understand your comments like, we can support above two options.
> Users can select to use either way. If the select the option#2 script,
> MPU_GUEST_MEMORY_SECTION_BASE will be detected by Xen code, and Xen
> can bypass the device tree parser. If Xen can't detected
> MPU_GUEST_MEMORY_SECTION_BASE, Xen can treat that users selected to
> use option#1 scripts, Xen will do DT parser.

Yes, that is what I meant. Both options are acceptable and we could
support both. The main difference for the user is that option #2
requires a Xen build after running ImageBuilder, while option #1 might
not.

Of course you don't have to implement both options right away. If you
have to pick one for the initial implementation I think it might be
easier to use option 1 as it is more similar to the current way of doing
things.


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 21:13:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 21:13:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311250.528396 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni0af-0006MX-3d; Fri, 22 Apr 2022 21:13:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311250.528396; Fri, 22 Apr 2022 21:13:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni0af-0006MQ-0s; Fri, 22 Apr 2022 21:13:21 +0000
Received: by outflank-mailman (input) for mailman id 311250;
 Fri, 22 Apr 2022 21:13:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni0ad-0006MG-R5; Fri, 22 Apr 2022 21:13:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni0ad-0002M7-Nh; Fri, 22 Apr 2022 21:13:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni0ad-00074K-BK; Fri, 22 Apr 2022 21:13:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni0ad-0000vb-Au; Fri, 22 Apr 2022 21:13:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XX2MGYiCkffjakdgfPPAnjj+vv0opGKb/kbnYHYLOeg=; b=Ah5mtc18EDFeVVLecwuyvluaGM
	pdbEom+kGio0LiP/JuA0yXEekAt4EnEYKIrpNYGuvv+p10ecmn8x/Z1zg2UJ295nnoQPZlToNXMdA
	hyOlxkzFEgvk5WyXkQTW/EbzaoDyMxzpxvGYPjZNKkUiGJF/UPlyHCS/hkyY0t/vWJMM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169628-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169628: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=ee582858c4f43c63a1566f0c1c0aa8ace0e4a79c
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 21:13:19 +0000

flight 169628 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169628/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 ee582858c4f43c63a1566f0c1c0aa8ace0e4a79c
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  558 attempts
Testing same since   169626  2022-04-22 15:42:24 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5675 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 22:58:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 22:58:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311268.528407 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2EN-0001WZ-Ko; Fri, 22 Apr 2022 22:58:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311268.528407; Fri, 22 Apr 2022 22:58:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2EN-0001WS-Hg; Fri, 22 Apr 2022 22:58:27 +0000
Received: by outflank-mailman (input) for mailman id 311268;
 Fri, 22 Apr 2022 22:58:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pzHF=VA=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1ni2EM-0001WM-5z
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 22:58:26 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b634173e-c28f-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 00:58:24 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23MMw1bM013129
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 22 Apr 2022 18:58:06 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23MMw0jv013127;
 Fri, 22 Apr 2022 15:58:00 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b634173e-c28f-11ec-8fc2-03012f2f19d4
Date: Fri, 22 Apr 2022 15:58:00 -0700
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 5/5] tools/xl: Fix potential deallocation bug
Message-ID: <YmMy+LaG1RqXMrlb@mattapan.m5p.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
 <2d1335a4056558d172d9aa3e59982eb761647418.1640590794.git.ehem+xen@m5p.com>
 <YdWzswCszMN1IE20@perard>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YdWzswCszMN1IE20@perard>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Huh, never got around to replying to this.  Too many things going on, too
many distractions...

On Wed, Jan 05, 2022 at 03:05:23PM +0000, Anthony PERARD wrote:
> On Thu, Dec 10, 2020 at 03:09:06PM -0800, Elliott Mitchell wrote:
> > There is potential for the info and info_free variable's purposes to
> > diverge.  If info was overwritten with a distinct value, yet info_free
> > still needed deallocation a bug would occur on this line.  Preemptively
> > address this issue (making use of divergent info/info_free values is
> > under consideration).
> > 
> > Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> > ---
> >  tools/xl/xl_info.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> > index 3647468420..938f06f1a8 100644
> > --- a/tools/xl/xl_info.c
> > +++ b/tools/xl/xl_info.c
> > @@ -579,7 +579,7 @@ int main_list(int argc, char **argv)
> >                       info, nb_domain);
> >  
> >      if (info_free)
> > -        libxl_dominfo_list_free(info, nb_domain);
> > +        libxl_dominfo_list_free(info_free, nb_domain);
> >  
> >      libxl_dominfo_dispose(&info_buf);
> >  
> 
> I don't think this is the right thing to do with this patch.

I disagree with this statement.

> libxl_dominfo_list_free() should use the same variable that is used by
> libxl_list_domain(). What we want to free is the allocation made by
> libxl_list_domain().

I agree with this statement.

> "info_free" in the function seems to be used as a boolean which tell
> if "info" have been allocated or not. Actually, it probably say if
> "info" is a list of "libxl_dominfo" or not.

That may be what the author was thinking when they wrote lines 579 & 580.
Problem is info_free is a pointer to libxl_dominfo, *not* a boolean.

> So instead of just replacing "info" by "info_free" here, we should
> instead store the result from libxl_list_domain() into a different
> variable and free that, like it is done with "info_buf".
> 
> I hope that makes sense?

What you're describing seems to be precisely what the patch does.
Perhaps you got the roles of "info" and "info_free" reversed?

This actually points to an issue on lines 548 & 553.  Instead of storing
the return from libxl_list_domain() into "info" then copying to
"info_free" both should be set at the same time.

I had noticed this (and cringed), but didn't feel it was currently
worthwhile to go after lines 548 & 553.  If you want this additional
change to accept the patch, I'm up for that.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Fri Apr 22 22:59:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 22:59:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311275.528418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2Fq-00024I-W0; Fri, 22 Apr 2022 22:59:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311275.528418; Fri, 22 Apr 2022 22:59:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2Fq-00024B-TC; Fri, 22 Apr 2022 22:59:58 +0000
Received: by outflank-mailman (input) for mailman id 311275;
 Fri, 22 Apr 2022 22:59:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni2Fp-000241-GQ
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 22:59:57 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ed52526b-c28f-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 00:59:56 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 9FF62B832FF;
 Fri, 22 Apr 2022 22:59:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81619C385A4;
 Fri, 22 Apr 2022 22:59:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed52526b-c28f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650668394;
	bh=M7V1x3+dW0OrON/J4gjnWwch4NqKEpkTbtbZGq9n8Ds=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=QohgQHLzztT0SIwKMxTyP1z4XMJ5yxThvDyiQXdXw5R9vEhb1vIQoOPFBA4vMDmp7
	 OMXSxeoQZPdSRsYBxP6lNveMG6mN71h9ljeHiyhlpi/JE8n/ahpBv5rA297OdfD3m8
	 HHK67H6zwN4EyeCZgH1FN5Uk5vizPpcotPFjYvEbbBSvYm6gGnkuABqm9TF1YeELcW
	 dZxik/y3nacGdEG+7JlHx0QMJgfEE4t/k3UBooyvCEvN3vWl00th8B2WdhSt0OXQy3
	 GaxYCztJOy1KwmrjIyLwOtFbI06hD3+pGKZrqMWLJyXHiH0diFy04HgYZUZFVIcB/p
	 fhGy9MUJZMx3Q==
Date: Fri, 22 Apr 2022 15:59:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Russell King <linux@armlinux.org.uk>, 
    Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Logan Gunthorpe <logang@deltatee.com>, 
    David Hildenbrand <david@redhat.com>, 
    Martin Oliveira <martin.oliveira@eideticom.com>, 
    Kees Cook <keescook@chromium.org>, 
    Jean-Philippe Brucker <jean-philippe@linaro.org>, 
    Julien Grall <julien@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>, 
    Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V1 1/6] arm/xen: Introduce xen_setup_dma_ops()
In-Reply-To: <1650646263-22047-2-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204221509220.915916@ubuntu-linux-20-04-desktop>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-2-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This patch introduces new helper and places it in new header.
> The helper's purpose is to assign any Xen specific DMA ops in
> a single place. For now, we deal with xen-swiotlb DMA ops only.
> The one of the subsequent commits in current series will add
> xen-grant DMA ops case.
> 
> Also re-use the xen_swiotlb_detect() check on Arm32.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes RFC -> V1:
>    - update commit description
>    - move commit to the beginning of the series
>    - move #ifdef CONFIG_XEN from dma-mapping.c to xen-ops.h
> ---
>  arch/arm/include/asm/xen/xen-ops.h   |  1 +
>  arch/arm/mm/dma-mapping.c            |  7 ++-----
>  arch/arm64/include/asm/xen/xen-ops.h |  1 +
>  arch/arm64/mm/dma-mapping.c          |  7 ++-----
>  include/xen/arm/xen-ops.h            | 15 +++++++++++++++
>  5 files changed, 21 insertions(+), 10 deletions(-)
>  create mode 100644 arch/arm/include/asm/xen/xen-ops.h
>  create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
>  create mode 100644 include/xen/arm/xen-ops.h
> 
> diff --git a/arch/arm/include/asm/xen/xen-ops.h b/arch/arm/include/asm/xen/xen-ops.h
> new file mode 100644
> index 00000000..8d2fa24
> --- /dev/null
> +++ b/arch/arm/include/asm/xen/xen-ops.h
> @@ -0,0 +1 @@
> +#include <xen/arm/xen-ops.h>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 82ffac6..059cce0 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -33,7 +33,7 @@
>  #include <asm/dma-iommu.h>
>  #include <asm/mach/map.h>
>  #include <asm/system_info.h>
> -#include <xen/swiotlb-xen.h>
> +#include <asm/xen/xen-ops.h>
>  
>  #include "dma.h"
>  #include "mm.h"
> @@ -2287,10 +2287,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>  
>  	set_dma_ops(dev, dma_ops);
>  
> -#ifdef CONFIG_XEN
> -	if (xen_initial_domain())
> -		dev->dma_ops = &xen_swiotlb_dma_ops;
> -#endif
> +	xen_setup_dma_ops(dev);
>  	dev->archdata.dma_ops_setup = true;
>  }
>  
> diff --git a/arch/arm64/include/asm/xen/xen-ops.h b/arch/arm64/include/asm/xen/xen-ops.h
> new file mode 100644
> index 00000000..8d2fa24
> --- /dev/null
> +++ b/arch/arm64/include/asm/xen/xen-ops.h
> @@ -0,0 +1 @@
> +#include <xen/arm/xen-ops.h>
> diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
> index 6719f9e..6099c81 100644
> --- a/arch/arm64/mm/dma-mapping.c
> +++ b/arch/arm64/mm/dma-mapping.c
> @@ -9,9 +9,9 @@
>  #include <linux/dma-map-ops.h>
>  #include <linux/dma-iommu.h>
>  #include <xen/xen.h>
> -#include <xen/swiotlb-xen.h>
>  
>  #include <asm/cacheflush.h>
> +#include <asm/xen/xen-ops.h>
>  
>  void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
>  		enum dma_data_direction dir)
> @@ -52,8 +52,5 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>  	if (iommu)
>  		iommu_setup_dma_ops(dev, dma_base, dma_base + size - 1);
>  
> -#ifdef CONFIG_XEN
> -	if (xen_swiotlb_detect())
> -		dev->dma_ops = &xen_swiotlb_dma_ops;
> -#endif
> +	xen_setup_dma_ops(dev);
>  }
> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
> new file mode 100644
> index 00000000..288deb1
> --- /dev/null
> +++ b/include/xen/arm/xen-ops.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _ASM_ARM_XEN_OPS_H
> +#define _ASM_ARM_XEN_OPS_H
> +
> +#include <xen/swiotlb-xen.h>
> +
> +static inline void xen_setup_dma_ops(struct device *dev)
> +{
> +#ifdef CONFIG_XEN
> +	if (xen_swiotlb_detect())
> +		dev->dma_ops = &xen_swiotlb_dma_ops;
> +#endif
> +}
> +
> +#endif /* _ASM_ARM_XEN_OPS_H */
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 23:00:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 23:00:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311278.528430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2G8-0003Fb-88; Fri, 22 Apr 2022 23:00:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311278.528430; Fri, 22 Apr 2022 23:00:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2G8-0003FS-58; Fri, 22 Apr 2022 23:00:16 +0000
Received: by outflank-mailman (input) for mailman id 311278;
 Fri, 22 Apr 2022 23:00:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni2G6-0002xN-A9
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 23:00:14 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6b8d5e9-c28f-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 01:00:12 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 23D3C6122B;
 Fri, 22 Apr 2022 23:00:11 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D664C385A0;
 Fri, 22 Apr 2022 23:00:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6b8d5e9-c28f-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650668410;
	bh=1hOEPpI8cgRF5lLEd0hRrdz++am9bOEonoN37TkAAbI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=qvtO0QBvf2gPsezSOqygGD6dJE+dthIsm1w7wXkaMBrZs0gs9oD+AxlnXkhLjiqs7
	 gKDkyswYaircah8jWoZUPGNpmL/K7x9N2dNrScFMF1+kMcwdA/R2NfbeZIwUkm0imp
	 8jwV76BGmyO2pEAltatSqWd+fNAGqEGEmmOCqtAYHfmFQURnyUbgnH0TWRK4ZhlBY9
	 bOowUtxJMbPC++4+K1YIWDHFzlk7lybdNmcYJtl4T25gVuaFE1/l5+MuYhzUDe5Kz3
	 7SMXk7iZteBj86eHZhPDALgK+h5aF+9fdP5OFe0Erz5YZw9zSswHiXPk709P/j/0bd
	 iPMjkwdQj7Z2g==
Date: Fri, 22 Apr 2022 16:00:09 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, x86@kernel.org, 
    linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
    Juergen Gross <jgross@suse.com>, Dave Hansen <dave.hansen@linux.intel.com>, 
    Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, 
    Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, 
    Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    "Michael S. Tsirkin" <mst@redhat.com>, 
    Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
In-Reply-To: <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204221526221.915916@ubuntu-linux-20-04-desktop>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1577086982-1650666424=:915916"
Content-ID: <alpine.DEB.2.22.394.2204221527222.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1577086982-1650666424=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204221527223.915916@ubuntu-linux-20-04-desktop>

On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Juergen Gross <jgross@suse.com>
> 
> Introduce Xen grant DMA-mapping layer which contains special DMA-mapping
> routines for providing grant references as DMA addresses to be used by
> frontends (e.g. virtio) in Xen guests.
> 
> In order to support virtio in Xen guests add a config option XEN_VIRTIO
> enabling the user to specify whether in all Xen guests virtio should
> be able to access memory via Xen grant mappings only on the host side.
> 
> As this also requires providing arch_has_restricted_virtio_memory_access
> implementation, switch from a pure stub to a real function on Arm
> and combine with existing implementation for the SEV guests on x86.
> 
> Add the needed functionality by providing a special set of DMA ops
> handling the needed grant operations for the I/O pages.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

There are a couple of minor things that checkpatch.pl reports, but aside
from those the patch looks fine to me.


> ---
> Changes RFC -> V1:
>    - squash with almost all changes from commit (except handling "xen,dev-domid"
>      property):
>      "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer"
>    - update commit subject/description and comments in code
>    - leave only single Kconfig option XEN_VIRTIO and remove architectural
>      dependencies
>    - introduce common xen_has_restricted_virtio_memory_access() in xen.h
>      and update arch_has_restricted_virtio_memory_access() for both
>      Arm and x86 to call new helper
>    - use (1ULL << 63) instead of 0x8000000000000000ULL for XEN_GRANT_ADDR_OFF
>    - implement xen_virtio_dma_map(unmap)_sg() using example in swiotlb-xen.c
>    - optimize padding by moving "broken" field in struct xen_virtio_data
>    - remove unneeded per-device spinlock
>    - remove the inclusion of virtio_config.h
>    - remane everything according to the new naming scheme:
>      s/virtio/grant_dma
>    - add new hidden config option XEN_GRANT_DMA_OPS
> ---
>  arch/arm/xen/enlighten.c    |   8 ++
>  arch/x86/mm/init.c          |  11 ++
>  arch/x86/mm/mem_encrypt.c   |   5 -
>  drivers/xen/Kconfig         |  15 +++
>  drivers/xen/Makefile        |   1 +
>  drivers/xen/grant-dma-ops.c | 317 ++++++++++++++++++++++++++++++++++++++++++++
>  include/xen/xen-ops.h       |   8 ++
>  include/xen/xen.h           |   5 +
>  8 files changed, 365 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/xen/grant-dma-ops.c
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index ec5b082..49af493 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -409,6 +409,14 @@ int __init arch_xen_unpopulated_init(struct resource **res)
>  }
>  #endif
>  
> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> +int arch_has_restricted_virtio_memory_access(void)
> +{
> +	return xen_has_restricted_virtio_memory_access();
> +}
> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> +#endif
> +
>  static void __init xen_dt_guest_init(void)
>  {
>  	struct device_node *xen_node;
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index d8cfce2..fe84a3e 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -8,6 +8,8 @@
>  #include <linux/kmemleak.h>
>  #include <linux/sched/task.h>
>  
> +#include <xen/xen.h>
> +
>  #include <asm/set_memory.h>
>  #include <asm/e820/api.h>
>  #include <asm/init.h>
> @@ -1065,3 +1067,12 @@ unsigned long max_swapfile_size(void)
>  	return pages;
>  }
>  #endif
> +
> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> +int arch_has_restricted_virtio_memory_access(void)
> +{
> +	return (xen_has_restricted_virtio_memory_access() ||
> +			cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
> +}
> +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> +#endif
> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
> index 50d2099..dda020f 100644
> --- a/arch/x86/mm/mem_encrypt.c
> +++ b/arch/x86/mm/mem_encrypt.c
> @@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
>  	print_mem_encrypt_feature_info();
>  }
>  
> -int arch_has_restricted_virtio_memory_access(void)
> -{
> -	return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
> -}
> -EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index 120d32f..b95581f 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -335,4 +335,19 @@ config XEN_UNPOPULATED_ALLOC
>  	  having to balloon out RAM regions in order to obtain physical memory
>  	  space to create such mappings.
>  
> +config XEN_GRANT_DMA_OPS
> +	bool
> +	select DMA_OPS
> +
> +config XEN_VIRTIO
> +	bool "Xen virtio support"
> +	default n
> +	depends on VIRTIO
> +	select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> +	select XEN_GRANT_DMA_OPS
> +	help
> +	  Enable virtio support for running as Xen guest. Depending on the
> +	  guest type this will require special support on the backend side
> +	  (qemu or kernel, depending on the virtio device types used).
> +
>  endmenu
> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> index 5aae66e..1a23cb0 100644
> --- a/drivers/xen/Makefile
> +++ b/drivers/xen/Makefile
> @@ -39,3 +39,4 @@ xen-gntalloc-y				:= gntalloc.o
>  xen-privcmd-y				:= privcmd.o privcmd-buf.o
>  obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)	+= xen-front-pgdir-shbuf.o
>  obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)	+= unpopulated-alloc.o
> +obj-$(CONFIG_XEN_GRANT_DMA_OPS)		+= grant-dma-ops.o
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> new file mode 100644
> index 00000000..0e69aa8
> --- /dev/null
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -0,0 +1,317 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/******************************************************************************
> + * Xen grant DMA-mapping layer - contains special DMA-mapping routines
> + * for providing grant references as DMA addresses to be used by frontends
> + * (e.g. virtio) in Xen guests
> + *
> + * Copyright (c) 2021, Juergen Gross <jgross@suse.com>
> + */
> +
> +#include <linux/module.h>
> +#include <linux/dma-map-ops.h>
> +#include <linux/of.h>
> +#include <linux/pci.h>
> +#include <linux/pfn.h>
> +#include <xen/xen.h>
> +#include <xen/grant_table.h>
> +
> +struct xen_grant_dma_data {
> +	/* The ID of backend domain */
> +	domid_t dev_domid;
> +	/* Is device behaving sane? */
> +	bool broken;
> +	struct device *dev;
> +	struct list_head list;
> +};
> +
> +static LIST_HEAD(xen_grant_dma_devices);
> +static DEFINE_SPINLOCK(xen_grant_dma_lock);
> +
> +#define XEN_GRANT_DMA_ADDR_OFF	(1ULL << 63)
> +
> +static inline dma_addr_t grant_to_dma(grant_ref_t grant)
> +{
> +	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
> +}
> +
> +static inline grant_ref_t dma_to_grant(dma_addr_t dma)
> +{
> +	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT);
> +}
> +
> +static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
> +{
> +	struct xen_grant_dma_data *data = NULL;
> +	bool found = false;
> +
> +	spin_lock(&xen_grant_dma_lock);
> +
> +	list_for_each_entry(data, &xen_grant_dma_devices, list) {
> +		if (data->dev == dev) {
> +			found = true;
> +			break;
> +		}
> +	}
> +
> +	spin_unlock(&xen_grant_dma_lock);
> +
> +	return found ? data : NULL;
> +}
> +
> +/*
> + * DMA ops for Xen frontends (e.g. virtio).
> + *
> + * Used to act as a kind of software IOMMU for Xen guests by using grants as
> + * DMA addresses.
> + * Such a DMA address is formed by using the grant reference as a frame
> + * number and setting the highest address bit (this bit is for the backend
> + * to be able to distinguish it from e.g. a mmio address).
> + *
> + * Note that for now we hard wire dom0 to be the backend domain. In order
> + * to support any domain as backend we'd need to add a way to communicate
> + * the domid of this backend, e.g. via Xenstore, via the PCI-device's
> + * config space or DT/ACPI.
> + */
> +static void *xen_grant_dma_alloc(struct device *dev, size_t size,
> +				 dma_addr_t *dma_handle, gfp_t gfp,
> +				 unsigned long attrs)
> +{
> +	struct xen_grant_dma_data *data;
> +	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned long pfn;
> +	grant_ref_t grant;
> +	void *ret;
> +
> +	data = find_xen_grant_dma_data(dev);
> +	if (!data)
> +		return NULL;
> +
> +	if (unlikely(data->broken))
> +		return NULL;
> +
> +	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
> +	if (!ret)
> +		return NULL;
> +
> +	pfn = virt_to_pfn(ret);
> +
> +	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
> +		free_pages_exact(ret, n_pages * PAGE_SIZE);
> +		return NULL;
> +	}
> +
> +	for (i = 0; i < n_pages; i++) {
> +		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
> +				pfn_to_gfn(pfn + i), 0);
> +	}
> +
> +	*dma_handle = grant_to_dma(grant);
> +
> +	return ret;
> +}
> +
> +static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
> +			       dma_addr_t dma_handle, unsigned long attrs)
> +{
> +	struct xen_grant_dma_data *data;
> +	unsigned int i, n_pages = PFN_UP(size);
> +	grant_ref_t grant;
> +
> +	data = find_xen_grant_dma_data(dev);
> +	if (!data)
> +		return;
> +
> +	if (unlikely(data->broken))
> +		return;
> +
> +	grant = dma_to_grant(dma_handle);
> +
> +	for (i = 0; i < n_pages; i++) {
> +		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
> +			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
> +			data->broken = true;
> +			return;
> +		}
> +	}
> +
> +	gnttab_free_grant_reference_seq(grant, n_pages);
> +
> +	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
> +}
> +
> +static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
> +					      dma_addr_t *dma_handle,
> +					      enum dma_data_direction dir,
> +					      gfp_t gfp)
> +{
> +	WARN_ONCE(1, "xen_grant_dma_alloc_pages size %zu\n", size);
> +	return NULL;
> +}
> +
> +static void xen_grant_dma_free_pages(struct device *dev, size_t size,
> +				     struct page *vaddr, dma_addr_t dma_handle,
> +				     enum dma_data_direction dir)
> +{
> +	WARN_ONCE(1, "xen_grant_dma_free_pages size %zu\n", size);
> +}
> +
> +static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
> +					 unsigned long offset, size_t size,
> +					 enum dma_data_direction dir,
> +					 unsigned long attrs)
> +{
> +	struct xen_grant_dma_data *data;
> +	unsigned int i, n_pages = PFN_UP(size);
> +	grant_ref_t grant;
> +	dma_addr_t dma_handle;
> +
> +	BUG_ON(dir == DMA_NONE);
> +
> +	data = find_xen_grant_dma_data(dev);
> +	if (!data)
> +		return DMA_MAPPING_ERROR;
> +
> +	if (unlikely(data->broken))
> +		return DMA_MAPPING_ERROR;
> +
> +	if (gnttab_alloc_grant_reference_seq(n_pages, &grant))
> +		return DMA_MAPPING_ERROR;
> +
> +	for (i = 0; i < n_pages; i++) {
> +		gnttab_grant_foreign_access_ref(grant + i, data->dev_domid,
> +				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
> +	}
> +
> +	dma_handle = grant_to_dma(grant) + offset;
> +
> +	return dma_handle;
> +}
> +
> +static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
> +				     size_t size, enum dma_data_direction dir,
> +				     unsigned long attrs)
> +{
> +	struct xen_grant_dma_data *data;
> +	unsigned int i, n_pages = PFN_UP(size);
> +	grant_ref_t grant;
> +
> +	BUG_ON(dir == DMA_NONE);
> +
> +	data = find_xen_grant_dma_data(dev);
> +	if (!data)
> +		return;
> +
> +	if (unlikely(data->broken))
> +		return;
> +
> +	grant = dma_to_grant(dma_handle);
> +
> +	for (i = 0; i < n_pages; i++) {
> +		if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) {
> +			dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n");
> +			data->broken = true;
> +			return;
> +		}
> +	}
> +
> +	gnttab_free_grant_reference_seq(grant, n_pages);
> +}
> +
> +static void xen_grant_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> +				   int nents, enum dma_data_direction dir,
> +				   unsigned long attrs)
> +{
> +	struct scatterlist *s;
> +	unsigned int i;
> +
> +	BUG_ON(dir == DMA_NONE);
> +
> +	for_each_sg(sg, s, nents, i)
> +		xen_grant_dma_unmap_page(dev, s->dma_address, sg_dma_len(s), dir,
> +				attrs);
> +}
> +
> +static int xen_grant_dma_map_sg(struct device *dev, struct scatterlist *sg,
> +				int nents, enum dma_data_direction dir,
> +				unsigned long attrs)
> +{
> +	struct scatterlist *s;
> +	unsigned int i;
> +
> +	BUG_ON(dir == DMA_NONE);
> +
> +	for_each_sg(sg, s, nents, i) {
> +		s->dma_address = xen_grant_dma_map_page(dev, sg_page(s), s->offset,
> +				s->length, dir, attrs);
> +		if (s->dma_address == DMA_MAPPING_ERROR)
> +			goto out;
> +
> +		sg_dma_len(s) = s->length;
> +	}
> +
> +	return nents;
> +
> +out:
> +	xen_grant_dma_unmap_sg(dev, sg, i, dir, attrs | DMA_ATTR_SKIP_CPU_SYNC);
> +	sg_dma_len(sg) = 0;
> +
> +	return -EIO;
> +}
> +
> +static int xen_grant_dma_supported(struct device *dev, u64 mask)
> +{
> +	return mask == DMA_BIT_MASK(64);
> +}
> +
> +static const struct dma_map_ops xen_grant_dma_ops = {
> +	.alloc = xen_grant_dma_alloc,
> +	.free = xen_grant_dma_free,
> +	.alloc_pages = xen_grant_dma_alloc_pages,
> +	.free_pages = xen_grant_dma_free_pages,
> +	.mmap = dma_common_mmap,
> +	.get_sgtable = dma_common_get_sgtable,
> +	.map_page = xen_grant_dma_map_page,
> +	.unmap_page = xen_grant_dma_unmap_page,
> +	.map_sg = xen_grant_dma_map_sg,
> +	.unmap_sg = xen_grant_dma_unmap_sg,
> +	.dma_supported = xen_grant_dma_supported,
> +};
> +
> +void xen_grant_setup_dma_ops(struct device *dev)
> +{
> +	struct xen_grant_dma_data *data;
> +	uint32_t dev_domid;
> +
> +	data = find_xen_grant_dma_data(dev);
> +	if (data) {
> +		dev_err(dev, "Xen grant DMA data is already created\n");
> +		return;
> +	}
> +
> +	/* XXX The dom0 is hardcoded as the backend domain for now */
> +	dev_domid = 0;
> +
> +	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> +	if (!data) {
> +		dev_err(dev, "Сannot allocate Xen grant DMA data\n");
> +		goto err;
> +	}
> +	data->dev_domid = dev_domid;
> +	data->dev = dev;
> +
> +	spin_lock(&xen_grant_dma_lock);
> +	list_add(&data->list, &xen_grant_dma_devices);
> +	spin_unlock(&xen_grant_dma_lock);
> +
> +	dev->dma_ops = &xen_grant_dma_ops;
> +
> +	return;
> +
> +err:
> +	dev_err(dev, "Сannot set up Xen grant DMA ops, retain platform DMA ops\n");
> +}
> +EXPORT_SYMBOL_GPL(xen_grant_setup_dma_ops);
> +
> +MODULE_DESCRIPTION("Xen grant DMA-mapping layer");
> +MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
> +MODULE_LICENSE("GPL");
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index a3584a3..4f9fad5 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { }
>  
>  #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
>  
> +#ifdef CONFIG_XEN_GRANT_DMA_OPS
> +void xen_grant_setup_dma_ops(struct device *dev);
> +#else
> +static inline void xen_grant_setup_dma_ops(struct device *dev)
> +{
> +}
> +#endif /* CONFIG_XEN_GRANT_DMA_OPS */
> +
>  #endif /* INCLUDE_XEN_OPS_H */
> diff --git a/include/xen/xen.h b/include/xen/xen.h
> index a99bab8..fe6e6bb 100644
> --- a/include/xen/xen.h
> +++ b/include/xen/xen.h
> @@ -52,6 +52,11 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
>  extern u64 xen_saved_max_mem_size;
>  #endif
>  
> +static inline int xen_has_restricted_virtio_memory_access(void)
> +{
> +	return IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain();
> +}
> +
>  #ifdef CONFIG_XEN_UNPOPULATED_ALLOC
>  int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
>  void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
--8323329-1577086982-1650666424=:915916--


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 23:00:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 23:00:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311284.528441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2GW-0003vJ-LF; Fri, 22 Apr 2022 23:00:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311284.528441; Fri, 22 Apr 2022 23:00:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2GW-0003vC-I0; Fri, 22 Apr 2022 23:00:40 +0000
Received: by outflank-mailman (input) for mailman id 311284;
 Fri, 22 Apr 2022 23:00:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni2GV-0003le-Hn
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 23:00:39 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 061d8e3f-c290-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 01:00:38 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 39F7B61372;
 Fri, 22 Apr 2022 23:00:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DABEEC385A4;
 Fri, 22 Apr 2022 23:00:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 061d8e3f-c290-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650668436;
	bh=i3k4Z+wq+0X0ubvvjcLYArt+TLHMdxZUdHM1xhLD/BY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Xj7t9bXwLftOK6Wn2xSX5vGqV5VDq4zyr6DxzaGMlOikdAPrXgpep/Xhxocbey161
	 /Yd5kPFmohPRLw2OhkmpBq1AaEq1ZHlyyn+XijNZq4BtcPDq+LqaikTsS8fuhthm/U
	 Lz4xi+GzuHsx5VQ9qQCPSgspu3pWky/VJaqwx4E3VHQYIrwN7slyzw/DKoDci+pVhN
	 OZOBiUwvHSsmSnxeU1NQ5jK4o4sdt2uwZ7HRO2c6jLRvCBqdD/cVTicSPYrzu6XIZg
	 Ag9FRVb5V1cw/AGlUJAnjKOsrr6oanSlaQrtTNCYsfq0ogVQQiH7AumNcbcx/cvA5a
	 I4grC0fhpEQfA==
Date: Fri, 22 Apr 2022 16:00:35 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, 
    devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Jason Wang <jasowang@redhat.com>, Rob Herring <robh+dt@kernel.org>, 
    Krzysztof Kozlowski <krzk+dt@kernel.org>, Julien Grall <julien@xen.org>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    "Michael S. Tsirkin" <mst@redhat.com>, 
    Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V1 4/6] dt-bindings: Add xen, dev-domid property description
 for xen-grant DMA ops
In-Reply-To: <1650646263-22047-5-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204221527500.915916@ubuntu-linux-20-04-desktop>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-5-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Introduce Xen specific binding for the virtualized device (e.g. virtio)
> to be used by Xen grant DMA-mapping layer in the subsequent commit.
> 
> This binding indicates that Xen grant mappings scheme needs to be
> enabled for the device which DT node contains that property and specifies
> the ID of Xen domain where the corresponding backend resides. The ID
> (domid) is used as an argument to the grant mapping APIs.
> 
> This is needed for the option to restrict memory access using Xen grant
> mappings to work which primary goal is to enable using virtio devices
> in Xen guests.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Looks OK to me. Just a couple of grammar improvements below. Aside from
those, I have no further comments.


> ---
> Changes RFC -> V1:
>    - update commit subject/description and text in description
>    - move to devicetree/bindings/arm/
> ---
>  .../devicetree/bindings/arm/xen,dev-domid.yaml     | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
> new file mode 100644
> index 00000000..ef0f747
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xen specific binding for the virtualized device (e.g. virtio)

NIT: Xen specific binding for virtualized devices (e.g. virtio)


> +maintainers:
> +  - Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> +
> +select: true
> +
> +description:
> +  This binding indicates that Xen grant mappings scheme needs to be enabled
> +  for that device and specifies the ID of Xen domain where the corresponding
> +  device (backend) resides. This is needed for the option to restrict memory
> +  access using Xen grant mappings to work.

NIT:

This binding indicates that Xen grant mappings need to be enabled for
the device, and it specifies the ID of the domain where the
corresponding device (backend) resides. The property is required to
restrict memory access using Xen grant mappings.


> +properties:
> +  xen,dev-domid:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      The domid (domain ID) of the domain where the device (backend) is running.
> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    virtio_block@3000 {
> +            compatible = "virtio,mmio";
> +            reg = <0x3000 0x100>;
> +            interrupts = <41>;
> +
> +            /* The device is located in Xen domain with ID 1 */
> +            xen,dev-domid = <1>;
> +    };



From xen-devel-bounces@lists.xenproject.org Fri Apr 22 23:00:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 23:00:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311285.528452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2Gg-0004Kf-UK; Fri, 22 Apr 2022 23:00:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311285.528452; Fri, 22 Apr 2022 23:00:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2Gg-0004KU-QM; Fri, 22 Apr 2022 23:00:50 +0000
Received: by outflank-mailman (input) for mailman id 311285;
 Fri, 22 Apr 2022 23:00:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni2Gf-0003le-0q
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 23:00:49 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c5bfaf6-c290-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 01:00:48 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id B760CB832E2;
 Fri, 22 Apr 2022 23:00:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE5F5C385A0;
 Fri, 22 Apr 2022 23:00:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c5bfaf6-c290-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650668446;
	bh=EG9Sat3nnlct87XJ7aI6xJ/IJzxF9nLDysqX+nVR4hI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=chdUsvXdzye2ukDSePy0mN4FkH+KKMIU3Nycg5slUUctlXi2Hk1aYXRlJIlnhy3y5
	 /E7IR/cJtDDSGBTMVb0qqR21/7RpTMti9lQFp175AjdHQotbT0LUgHKUgkMzRjcTW9
	 HQdUEU909dGByOZd+NPKzTpKgzU2A3UI1DjHphnRS9zrbO+SWdg+zbgirJzXDXhaXX
	 9S+g84qZB7TdhBayLnzZWRYTxPiEhexK2KxcsIBkayp49QkOLjxZa8RBL5C5So3aBB
	 9uEUn8V7vres4ULlqLLJGN2d7pmknP3OQaXPYV/nGhRSDL/a6wZyrRu8cuszTbjEJU
	 pcfhqO/x6ocNw==
Date: Fri, 22 Apr 2022 16:00:45 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, 
    "Michael S. Tsirkin" <mst@redhat.com>, 
    Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V1 5/6] xen/grant-dma-ops: Retrieve the ID of backend's
 domain for DT devices
In-Reply-To: <1650646263-22047-6-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204221534080.915916@ubuntu-linux-20-04-desktop>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-6-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Use the presence of recently introduced "xen,dev-domid" property
> in the device node as a clear indicator of enabling Xen grant
> mappings scheme for that device and read the ID of Xen domain where
> the corresponding backend resides. The ID (domid) is used as
> an argument to the Xen grant mapping APIs.
> 
> Also introduce xen_is_grant_dma_device() to check whether xen-grant
> DMA ops need to be set for a passed device.
> 
> Remove the hardcoded domid 0 in xen_grant_setup_dma_ops().
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Changes RFC -> V1:
>    - new patch, split required changes from commit:
>     "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer"
>    - update checks in xen_virtio_setup_dma_ops() to only support
>      DT devices for now
>    - remove the "virtio,mmio" check from xen_is_virtio_device()
>    - remane everything according to the new naming scheme:
>      s/virtio/grant_dma
> ---
>  drivers/xen/grant-dma-ops.c | 25 ++++++++++++++++++-------
>  include/xen/xen-ops.h       |  5 +++++
>  2 files changed, 23 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 0e69aa8..70d5d77 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -66,11 +66,6 @@ static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
>   * Such a DMA address is formed by using the grant reference as a frame
>   * number and setting the highest address bit (this bit is for the backend
>   * to be able to distinguish it from e.g. a mmio address).
> - *
> - * Note that for now we hard wire dom0 to be the backend domain. In order
> - * to support any domain as backend we'd need to add a way to communicate
> - * the domid of this backend, e.g. via Xenstore, via the PCI-device's
> - * config space or DT/ACPI.
>   */
>  static void *xen_grant_dma_alloc(struct device *dev, size_t size,
>  				 dma_addr_t *dma_handle, gfp_t gfp,
> @@ -277,6 +272,16 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>  	.dma_supported = xen_grant_dma_supported,
>  };
>  
> +bool xen_is_grant_dma_device(struct device *dev)
> +{
> +	/* XXX Handle only DT devices for now */
> +	if (!dev->of_node)
> +		return false;
> +
> +	return of_property_read_bool(dev->of_node, "xen,dev-domid");
> +}
> +EXPORT_SYMBOL_GPL(xen_is_grant_dma_device);
> +
>  void xen_grant_setup_dma_ops(struct device *dev)
>  {
>  	struct xen_grant_dma_data *data;
> @@ -288,8 +293,14 @@ void xen_grant_setup_dma_ops(struct device *dev)
>  		return;
>  	}
>  
> -	/* XXX The dom0 is hardcoded as the backend domain for now */
> -	dev_domid = 0;
> +	/* XXX ACPI and PCI devices unsupported for now */
> +	if (dev_is_pci(dev) || !dev->of_node)
> +		goto err;

I think we can remove the "dev_is_pci" check, right?


> +	if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) {
> +		dev_err(dev, "xen,dev-domid property is not present\n");
> +		goto err;
> +	}
>  
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
>  	if (!data) {
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index 4f9fad5..62be9dc 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { }
>  
>  #ifdef CONFIG_XEN_GRANT_DMA_OPS
>  void xen_grant_setup_dma_ops(struct device *dev);
> +bool xen_is_grant_dma_device(struct device *dev);
>  #else
>  static inline void xen_grant_setup_dma_ops(struct device *dev)
>  {
>  }
> +static inline bool xen_is_grant_dma_device(struct device *dev)
> +{
> +	return false;
> +}
>  #endif /* CONFIG_XEN_GRANT_DMA_OPS */
>  
>  #endif /* INCLUDE_XEN_OPS_H */
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 23:00:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 23:00:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311287.528463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2Go-0004nV-6v; Fri, 22 Apr 2022 23:00:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311287.528463; Fri, 22 Apr 2022 23:00:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2Go-0004nM-3e; Fri, 22 Apr 2022 23:00:58 +0000
Received: by outflank-mailman (input) for mailman id 311287;
 Fri, 22 Apr 2022 23:00:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni2Gm-0002xN-H9
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 23:00:56 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 10a65f16-c290-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 01:00:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 07606B83302;
 Fri, 22 Apr 2022 23:00:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B6B6C385A0;
 Fri, 22 Apr 2022 23:00:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10a65f16-c290-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650668453;
	bh=Tt3wwME8ZrAnjoqNSv/eny+SL/xKTMCNW0YOwL5HtmU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=pbkp72Syh6ze1/sVyi2ZMLT+cvAgwDIUvVnmDhf93VYSNywj5WeHzORptbyE6qnCp
	 Kj0veLD6zjTWSl2azkAW3joi+nFnQJPt4r/40N62vmTbpV8HQk0UAypHp4iJt9mvhb
	 VbCPtoxYVel6jnB7YSXPTl1xFeMsUV7fkRz+W0JFs6lfFbQiORL+7ALl8VgRQFMwzz
	 WgbYAr7QXc/+YIBuhsGqgGJ/aWpcXxJ3bmWsmxsHklj4NSJDY+EbVYRYxltALvFvFn
	 bOoCfKQq8f7CkYyjMLMJ9/2i1c3g7V8uz0QOmYsPhnz29cg0NlwTAulTy+D9D5kY0I
	 zZC4ySq0Nur6w==
Date: Fri, 22 Apr 2022 16:00:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    "Michael S. Tsirkin" <mst@redhat.com>, 
    Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V1 6/6] arm/xen: Assign xen-grant DMA ops for xen-grant
 DMA devices
In-Reply-To: <1650646263-22047-7-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204221537160.915916@ubuntu-linux-20-04-desktop>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-7-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> As the main (and single at the moment) purpose of xen-grant
> DMA devices is to enable using virtio devices in Xen guests
> in a safe manner, assign xen-grant DMA ops only if restricted
> access to the guest memory is enabled.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes RFC -> V1:
>    - update commit subject/description
>    - remove #ifdef CONFIG_XEN_VIRTIO
>    - re-organize the check taking into the account that
>      swiotlb and virtio cases are mutually exclusive
>    - update according to the new naming scheme:
>      s/virtio/grant_dma
> ---
>  include/xen/arm/xen-ops.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
> index 288deb1..26954e5 100644
> --- a/include/xen/arm/xen-ops.h
> +++ b/include/xen/arm/xen-ops.h
> @@ -2,12 +2,17 @@
>  #ifndef _ASM_ARM_XEN_OPS_H
>  #define _ASM_ARM_XEN_OPS_H
>  
> +#include <linux/virtio_config.h>
>  #include <xen/swiotlb-xen.h>
> +#include <xen/xen-ops.h>
>  
>  static inline void xen_setup_dma_ops(struct device *dev)
>  {
>  #ifdef CONFIG_XEN
> -	if (xen_swiotlb_detect())
> +	if (arch_has_restricted_virtio_memory_access() &&
> +			xen_is_grant_dma_device(dev))
> +		xen_grant_setup_dma_ops(dev);
> +	else if (xen_swiotlb_detect())
>  		dev->dma_ops = &xen_swiotlb_dma_ops;
>  #endif
>  }
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 23:07:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 23:07:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311304.528474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2NQ-0006Et-Qx; Fri, 22 Apr 2022 23:07:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311304.528474; Fri, 22 Apr 2022 23:07:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2NQ-0006Em-Nv; Fri, 22 Apr 2022 23:07:48 +0000
Received: by outflank-mailman (input) for mailman id 311304;
 Fri, 22 Apr 2022 23:07:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+xj=VA=citrix.com=prvs=1042e1a12=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ni2NP-0006Eg-AC
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 23:07:47 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fe6a635c-c290-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 01:07:44 +0200 (CEST)
Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 22 Apr 2022 19:07:30 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BLAPR03MB5428.namprd03.prod.outlook.com (2603:10b6:208:285::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr
 2022 23:07:28 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.014; Fri, 22 Apr 2022
 23:07:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe6a635c-c290-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650668862;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=sbxOhCfN9nkn/L+LnqC1edIGhfUPvHS5KTv1L7nfA7E=;
  b=BS/Qs+KwDEYJ7UdWIQA7NvaPpdHgr1nz3xIL5pASMpKGxgnyotIMxi28
   cJ+UOX02OQS1Nib7QXemKjGcPnJHxIG/V5BhBNvPb526HndA2uRCJzoWu
   aZmt/VUnORaYtoZv+m+A+NlFJyQQDYg8FtI2Y8Ad8vA47dwQNlyLWi4Bz
   Q=;
X-IronPort-RemoteIP: 104.47.57.171
X-IronPort-MID: 69624674
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:t+kDIaC3zDg+oxVW/wziw5YqxClBgxIJ4kV8jS/XYbTApD123jEAy
 DdODWqOPP/eZGOme4wgO46/80lT7ZHXxoc2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj2NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh+8
 4tTuY3gdD52M7/SpL80EAl7SgxXaPguFL/veRBTsOS15mifKj7A5qsrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t5B8mcGs0m5vcBtNs0rulIEezTe
 Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLWwG8g7L+vZfD277lQMpz4e3APrsQ/eVZchpgFzHn
 VPkxjGsav0dHJnFodafyVqgnvTKnD/7cIsKGaek6+Vxh1mO2m0UDgZQXly+ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9hZFeEg+RyO4qXR6gedQGMDS1ZpZNMqucAsTBQ2x
 1SJmJXvHjUpv7qLIU9x7Z+RpDK2fCQQc2kLYHZdSRNfuoa65oYukhjIU9BvVravicH4Ei3xx
 DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr7hu+lTOZJv7CV1GU=
IronPort-HdrOrdr: A9a23:RzvOGq2U1DYacpnHZ0kwOAqjBetxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+
 UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf
 grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e
 iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ
 PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/
 6uJZM+OY6XEVfT
X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; 
   d="scan'208";a="69624674"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fKM0VQ7W9oBIzdQsPQRbLxA6/PPQ8JbM+5c+dvXIBw8n1eVQzNg6Wr/kVzVxeE3aP1grHt2xfiFWmWMO5DZffBiyOY09ZNtI9BC1A1a82Pdv1fbRjZVsvglQr1mE65drXmcaWzoCE4pUzQq5Ho6Agqp4C/CJDCF7sPlZMgRaB04HQpmMtmznY4L9V0OuZ5a5lY6F/hyc7hYgL65aW/yTgbSDvV8znZdJXW3nLR0Al0Mrq/9ynlKWz7tUOHbN2piZzAYev6i5ygfID3ghBT3yxNFYfK5Yr3BDF01RYKPxfsxFf/rT2dDIVgqJFvq7W3/BFl7XR7CKSGh9hijOdNURAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sbxOhCfN9nkn/L+LnqC1edIGhfUPvHS5KTv1L7nfA7E=;
 b=DpYrBdJkOzrwgq0rtZajwUnQew6yPXfshQboHFeZgfyjox2i4jc1whNUSXxbI0ZKInn2vka+1RVzPHItbWrNemg3EGmX2AKGutPdtZBn6BuOig5yPBADzk7Qv7k8aUq3TPH915ZmQinXYnT83/Y82zm+Rt9gPsoGj+Uuph3odYT91m0klsq7PM8URLdqNnUygY2q4bqxTkuxkMBLJPGXpl+lQpASP7vVO45nA7j9BQRFEIWNGgD+PP7BP2yUv2el2aA/LbTwRupE8a6J2Zn3QOl/thgaWCn25FAvpbpEH758QU63p8xPO/UTJLq+tq8SW87LvF8hX4P8Xy4r18pxFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sbxOhCfN9nkn/L+LnqC1edIGhfUPvHS5KTv1L7nfA7E=;
 b=NuUmg4dUXXwJYe5Ff3jy2esJP7B6OwWjbi3l3oX9OGjzhzZufq5Zrz3Dhgol+tcRJW3WqcmdvLHuOhI2Re7HRoGQOq2MjChGxZA8wwIoLLomaJHoi/rKlWNb0kfhmMG1PE/qXZYCm5n85VmeQOfuhnKETcOchct05m7+EF1CZAE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "jandryuk@gmail.com" <jandryuk@gmail.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH] xsm/flask: code style formatting
Thread-Topic: [PATCH] xsm/flask: code style formatting
Thread-Index: AQHYVoFX0AAXIBUsy0WDoXcUztv2Zqz8jnWA
Date: Fri, 22 Apr 2022 23:07:27 +0000
Message-ID: <5b199cfb-98c8-c382-82b3-a60819a0e977@citrix.com>
References: <20220422194344.9318-1-dpsmith@apertussolutions.com>
In-Reply-To: <20220422194344.9318-1-dpsmith@apertussolutions.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f8ceeebe-51fa-4b6f-7745-08da24b4dedd
x-ms-traffictypediagnostic: BLAPR03MB5428:EE_
x-microsoft-antispam-prvs:
 <BLAPR03MB5428DC40C30C8CB6BFD66820BAF79@BLAPR03MB5428.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 eZ9Fqnz7I8fgYkI7eDgZDH+IpDLo/Pi1iBqV2SaKeywYVhXrMpih/oWkuRz8rCaWXXujjtZA8S1VWqsuyblCdcT6i44norylCxa7idOTrk+mRCTudG2rui49MmIUHb+/CDQa3gLHbB9WltlCx/6kw477Vs8g/GgaBBPBFaSdxxTbjUYMKcbJacYee1MRjdiHk4C0pNEUomhX1NwK3WXLhQhplgrvgl1w+x1sJACZz7n+dZsbccSJ8uO77Bmo9jxI7OOCJsWfbskzoOWjsV5glaDSc33FGvdQJ88A9IgjoiA4Ly4NGOyQMhxC7IQLfAS9lP3F46xteu38H6D9NkBjibcR+yxg+vO6wItpv61bEEIydrcqWOBZP8cqXyQSEtbbrn6vNL5oESc8XaI204gdCaqxFqbFApl0Qww4UfQCOQnwL0lt8oyjtNXk2bkv7aXS8+9+Wyymp6hysRW35RmJ7U8As4hbaGKx4Jpq5IemBZ/83WHjuTBcxvyhaInGeoDhjiwPRsEEbFlDt/LfpKR6N0t5fFjup5IiYgb5yE+rq67JbwicnKDuTrcA7lsxSwl9BemTzlObPVlgPRaMj0LnnPWfUa4mh6/uu2HZflCDWscQwckTu9mQKETfYJ/9nOX22KxBk/GI8XVwvJt0NF4i8ZrYw9LgF9m2kERjy4I6Cp3/sS3d+aikFLFkXkZvcbGyUaRzi/r6AIafG0DjlHWiFVIHJ/x/T7eWpszVSA5JBKBKId4/PSY9FYtrz3i0LtkcdelIaeqWNMc5n3OgQ4oHCw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31686004)(186003)(508600001)(36756003)(31696002)(5660300002)(8936002)(38100700002)(91956017)(66476007)(66556008)(76116006)(64756008)(66946007)(38070700005)(66446008)(110136005)(54906003)(316002)(6512007)(86362001)(4744005)(8676002)(4326008)(2616005)(71200400001)(122000001)(6486002)(82960400001)(6506007)(26005)(2906002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?cUVDVnBtTVZsT2orUThWWFg2UE9STElaNGtMbzZPaHZlY1gyWDIvaEljRHNC?=
 =?utf-8?B?Q1VOSThodE1lTFNaMDhCUy80Q1RtV0R4eXczTFN3aWZKdEZmUzBJOXN1bDlE?=
 =?utf-8?B?UmhQZi9hVXFnVkVJaldRcWRQeEFxRThWQnpZUXhFZUNjd3lZMmdZb011M2Ro?=
 =?utf-8?B?dGtqWGZHdGlRTlFjY2t1cHZUOHZCcmFOVnRWdlBMUllDRkVhZmxFc1ZmWXJv?=
 =?utf-8?B?R3VnS0IyQzNFRHY5MlRjblBDUkVDT0UzUmJvQ2RyRnRYV0NHSjY5U1NzYXcw?=
 =?utf-8?B?RWNpb2c1Qkg0UFlkSjdPU0tGSFZQcS9zcTZVRWZDKzJXWWlKRXdRUVRNOVVI?=
 =?utf-8?B?dERaRFJYbHNCeWxVVEZRL3lNby9tcElub2JtMitISmVPd3c1Zno5aEhNR0cw?=
 =?utf-8?B?TENmUW0xT2kxUDdrNzA1Ryt0TUJPVkNJcm1qN0J5Qm9KemRSaVVlRy9FYlp3?=
 =?utf-8?B?NE1INVNhZDRidU5qWVBqajJCTHBkQ3pnc1hFbGUrb1F2eHE5d21vTk9wTHBx?=
 =?utf-8?B?b0VwWGJ2NHN2VEZOdGwrcVN2Tm41aDZ6d1lKRlpEMFRBRmxmTUdhNGdWMnEy?=
 =?utf-8?B?UlZOSG4ralYzVFpDekk4cVZtSWx5aDY4THllVzRaTUFZUDhPTlpRdzI4USsw?=
 =?utf-8?B?L3ZHbTNwQURPR2dCMEJlYU9LQ1N5MzRaTE8wbG0xUWtJNnBwVE1BNnhNNGNF?=
 =?utf-8?B?aXlxRkk2VHFxeUFnallrUEg5bnJ2R1dZVXp2UnI2b05zRVc2RTk0RDhmeDZP?=
 =?utf-8?B?emtpZjZSOHV6OW1IOUdmNGphNEd4V1hudVUrck4wNjlrZk9Md0dXZWZSQlIy?=
 =?utf-8?B?ZDc0bnBTMmlPZnJocGhKY3JHTngySVdxc3RZRCtFRHBXOG1IQmZvQlRhYm0x?=
 =?utf-8?B?UmV2MHdmSUZSOXJaRHdpRXU1aSs2bEp3Yi9VWDh1VkNYREw4VmR0SjVIZW95?=
 =?utf-8?B?U0FueXo2K25zWGtrem85b3pRRXFIbFQ4WUtYNmgvcGFLYUx0ZXFlSG9WRUpQ?=
 =?utf-8?B?ZHBTditoQW9kVkdSR3lDWVZJN3JPbEM1d0hWbVczb2lsKzlWUXRKelZXOUV5?=
 =?utf-8?B?NTIrTnZYRDdRMjFLNUZsem1wT3RwNVJnc0FKVTBaSllqRE0wU3d1MmZ3MGJl?=
 =?utf-8?B?NitUVXMvRGVrOXRQMU9td3NvZUs4OXpzTUZSTXZibkROaFlHYUV4QzZoVGFC?=
 =?utf-8?B?cjJhcEg4T3E5RHFZM2lEVXN0OEZzV0d3NnBweFdNYTFRQjA5N1l6ODJjNEtZ?=
 =?utf-8?B?MjcyT0ExYzdrb3VIYXFocDNraGNCNzZSU0cwTXJIZjFjd21NazN6U1hzd29j?=
 =?utf-8?B?NjBIbTB0a0NpblVsOTVFbGxBeHNxOUNEdlEvQ0k5Y3ViVllCeTRwSTlzdnJC?=
 =?utf-8?B?QlljbDdVL3R4RFM0VEhJU0g1eUt3L2QzL0c1VWhvckFXZlB1Z2hqRUxjSkdC?=
 =?utf-8?B?NHpFclRrdFF1ckJkWkZiT2p6NFVXRFlBdU1xcWg0Zi9mVFJkQjFyWndXb3ZP?=
 =?utf-8?B?MlgvMWdGWGtwc3c5QXdldHhqRm9USjQyR3hZVHNlQ0xOM0xnUldJNXVveG95?=
 =?utf-8?B?K2x3SjlHVm9hL2JXM2tFRXpUUjNFOHJhTVhaTHY3RTY3RXR3bkJRaHNoTDZ5?=
 =?utf-8?B?dVlGdGwzVzVvZDZzL2t1Zm52SmNFWjZzZHRSdzcvbHoyNlUxOSs0WGRyVFRM?=
 =?utf-8?B?UlorUE1TMllqUmI3VGJvcDljY1o2T1dpNzBuYmdXMWJXTTFEaU1MbWlKWmJI?=
 =?utf-8?B?MTdCTHk5d3lYZGVlUXlweGNvZXVTeFZJcGtkRjRaNGNVVUJwL0NhWlJKdnB5?=
 =?utf-8?B?WmxxRldEZnplM3E1bks4NVBMVFJrMnZ6S21aQkFFMXphejh6NzlaT3FxTjE0?=
 =?utf-8?B?NkhqalpxSGFwcWUyYXhHTzg1SEVXbzVnQmk4WnhGbVROMnRjeVRhdTdyazM3?=
 =?utf-8?B?aHl2bG9jdzhzcmJTQW1WMWw3WHJsSnUrN3NTaGZURHp6a0EzNzBKWVhDeHZy?=
 =?utf-8?B?eVY5RGMrV0txWUpSUnFiazFBMzBjdUNKRGhWWXdrTWZVVVNQQTMyeEYxaEJC?=
 =?utf-8?B?MUxLWU9JaUIyWDlTSTBEVHBoLytMUXA1cEFRZEtLZzVHU3hGU0FDTnhqVlBM?=
 =?utf-8?B?NG5IV2Q1YUgrU2NvSHZmYWswcFRDVWFrOEFma1hhbXAzcHVMbnBTNnlZNjl0?=
 =?utf-8?B?MXY2T0lBenRvTUF3SzdweEEwWlZmdWw2c3J1a3ZXVWZYK0hOWldkYUQwYXBu?=
 =?utf-8?B?YUwwT21nK3E4UUV2aGl4Y0ZOdGhVYXlFbElEZFRKRWsxbXByWFNmcVllTmhE?=
 =?utf-8?B?azFuVUY0NENHaGZIS3dRUVVGbEN1SElaOXVwME1KT1JxelZVR0tqdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <631FC9191B9702419D52C52DD0942BDA@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8ceeebe-51fa-4b6f-7745-08da24b4dedd
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 23:07:27.7646
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sAHu98U3PIM6dGTLpbqEcj5UWwdgObhT0yqO1zWMB48y43mUy1Iti8iuRfydZFBEobjInd4gkIXXz4va4bELkCxEex2QBm5pSoEWd8APA5M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5428

T24gMjIvMDQvMjAyMiAyMDo0MywgRGFuaWVsIFAuIFNtaXRoIHdyb3RlOg0KPiBkaWZmIC0tZ2l0
IGEveGVuL3hzbS9mbGFzay9ob29rcy5jIGIveGVuL3hzbS9mbGFzay9ob29rcy5jDQo+IGluZGV4
IDBiZjYzZmZhODQuLmUyZWJiYzc3MTYgMTAwNjQ0DQo+IC0tLSBhL3hlbi94c20vZmxhc2svaG9v
a3MuYw0KPiArKysgYi94ZW4veHNtL2ZsYXNrL2hvb2tzLmMNCj4gQEAgLTEyMCw4ICsxMjEsOCBA
QCBzdGF0aWMgaW50IGdldF9pcnFfc2lkKGludCBpcnEsIHUzMiAqc2lkLCBzdHJ1Y3QgYXZjX2F1
ZGl0X2RhdGEgKmFkKQ0KPiAgICAgICAgICBzdHJ1Y3QgaXJxX2Rlc2MgKmRlc2MgPSBpcnFfdG9f
ZGVzYyhpcnEpOw0KPiAgICAgICAgICBpZiAoIGRlc2MtPm1zaV9kZXNjICYmIGRlc2MtPm1zaV9k
ZXNjLT5kZXYgKSB7DQo+ICAgICAgICAgICAgICBzdHJ1Y3QgcGNpX2RldiAqZGV2ID0gZGVzYy0+
bXNpX2Rlc2MtPmRldjsNCj4gLSAgICAgICAgICAgIHUzMiBzYmRmID0gKGRldi0+c2VnIDw8IDE2
KSB8IChkZXYtPmJ1cyA8PCA4KSB8IGRldi0+ZGV2Zm47DQo+IC0gICAgICAgICAgICBpZiAoYWQp
IHsNCj4gKyAgICAgICAgICAgIHVpbnQzMl90IHNiZGYgPSAoZGV2LT5zZWcgPDwgMTYpIHwgKGRl
di0+YnVzIDw8IDgpIHwgZGV2LT5kZXZmbjsNCj4gKyAgICAgICAgICAgIGlmICggYWQgKSB7DQoN
CkJyYWNlIG9uIG5ld2xpbmUsIGFuZCBpbiB0aGUgc3Vic2VxdWVudCBodW5rLsKgIENhbiBiZSBm
aXhlZCBvbiBjb21taXQuDQoNCk90aGVyd2lzZSwgTEdUTS7CoCBBY2tlZC1ieTogQW5kcmV3IENv
b3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 23:27:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 23:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311312.528485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2gH-0000kB-Jo; Fri, 22 Apr 2022 23:27:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311312.528485; Fri, 22 Apr 2022 23:27:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2gH-0000k4-GW; Fri, 22 Apr 2022 23:27:17 +0000
Received: by outflank-mailman (input) for mailman id 311312;
 Fri, 22 Apr 2022 23:27:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni2gG-0000jy-9c
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 23:27:16 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bdac0e91-c293-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 01:27:14 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8784E6178B;
 Fri, 22 Apr 2022 23:27:13 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9774CC385A4;
 Fri, 22 Apr 2022 23:27:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bdac0e91-c293-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650670033;
	bh=3WouP7I5Z0D1Pgp3vsl29XDpy01zQPzK8XtCcoY38xk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=QkKD36LggfOTQfEkjsbRrQcUV5TB519DZ8Kt9xuHSscFX+Hun4B7EtdXHyqI+v1tS
	 okHgjCo/QwNUoQoqYz+BgBr9j6QZpJ0JCOwqXTduMVL2fvw7+inEekjx+krR3w+mHS
	 Lp+6MDOhzlqL5NUxpug3eC+IGn+XTmfe7dyFVwUjKU3D2w6BK0gIaRp9sQYbr4HkmA
	 17Ihqy8UjxsGxo07RsRsmFEqj419vI78NnV3SgM2CnrwancdEWW4lycXOphPilWDGy
	 nyHw4cfARysZ+ch5GpD8uVR503JTAWWdGNrCaTngnOGHDIjw1xsPOJap9Krh6Wq5ZD
	 3FNRYdyPxI+bA==
Date: Fri, 22 Apr 2022 16:27:12 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Paran Lee <p4ranlee@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/arm: fdt fix duplicated ternary operator, shift
 operations
In-Reply-To: <20220422185251.GA7124@DESKTOP-NK4TH6S.localdomain>
Message-ID: <alpine.DEB.2.22.394.2204221627060.915916@ubuntu-linux-20-04-desktop>
References: <20220422185251.GA7124@DESKTOP-NK4TH6S.localdomain>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 23 Apr 2022, Paran Lee wrote:
> It doesn't seem necessary to do duplicate ternary operation and calculation
> of order shift using fdt32_to_cpu macro.
> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  xen/arch/arm/bootfdt.c  | 12 ++++++++++--
>  xen/common/libfdt/fdt.c | 10 +++++-----
>  2 files changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index e318ef9603..e5b885a7f2 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -159,8 +159,16 @@ int __init device_tree_for_each_node(const void *fdt, int node,
>              continue;
>          }
>  
> -        as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
> -        ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
> +        if ( depth > 0 )
> +        {
> +            as = address_cells[depth-1];
> +            ss = size_cells[depth-1];
> +        }
> +        else
> +        {
> +            as = DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
> +            ss = DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
> +        }
>  
>          address_cells[depth] = device_tree_get_u32(fdt, node,
>                                                     "#address-cells", as);
> diff --git a/xen/common/libfdt/fdt.c b/xen/common/libfdt/fdt.c
> index 9fe7cf4b74..a507169d29 100644
> --- a/xen/common/libfdt/fdt.c
> +++ b/xen/common/libfdt/fdt.c
> @@ -165,7 +165,7 @@ const void *fdt_offset_ptr(const void *fdt, int offset, unsigned int len)
>  uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
>  {
>  	const fdt32_t *tagp, *lenp;
> -	uint32_t tag;
> +	uint32_t tag, len;
>  	int offset = startoffset;
>  	const char *p;
>  
> @@ -192,11 +192,11 @@ uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
>  		if (!can_assume(VALID_DTB) && !lenp)
>  			return FDT_END; /* premature end */
>  		/* skip-name offset, length and value */
> -		offset += sizeof(struct fdt_property) - FDT_TAGSIZE
> -			+ fdt32_to_cpu(*lenp);
> +		len = fdt32_to_cpu(*lenp);
> +		offset += sizeof(struct fdt_property) - FDT_TAGSIZE + len;
>  		if (!can_assume(LATEST) &&
> -		    fdt_version(fdt) < 0x10 && fdt32_to_cpu(*lenp) >= 8 &&
> -		    ((offset - fdt32_to_cpu(*lenp)) % 8) != 0)
> +		    fdt_version(fdt) < 0x10 && len >= 8 &&
> +		    ((offset - len) % 8) != 0)
>  			offset += 4;
>  		break;
>  
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 23:31:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 23:31:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311317.528496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2kB-000283-44; Fri, 22 Apr 2022 23:31:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311317.528496; Fri, 22 Apr 2022 23:31:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2kB-00027w-13; Fri, 22 Apr 2022 23:31:19 +0000
Received: by outflank-mailman (input) for mailman id 311317;
 Fri, 22 Apr 2022 23:31:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni2k9-00027m-RV; Fri, 22 Apr 2022 23:31:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni2k9-0004iS-Pd; Fri, 22 Apr 2022 23:31:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni2k9-0006D6-A1; Fri, 22 Apr 2022 23:31:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni2k9-0006zg-9K; Fri, 22 Apr 2022 23:31:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=r50LIzLp6KR5TjLzDQxsfVmEWPhpt8Vgb09epoN3BkQ=; b=39J0n+N4NJDMLaFxbYlzO5lzLN
	Iy1z71tGl3WuYNe1SDyXlhWh9UZ0cbC9bzb8WMFjLc6f+4s6k7wq0Od7hZ6b3pukK7YMwOR1p86Cu
	uYe624Twp6NX+gc7XNtA6KLyV/28IIZE+fPSQK9UBSpxpiGzByIXeATq7GYJGD7uarO8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169630-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169630: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
X-Osstest-Versions-That:
    xen=54279f87ecbcb3eab45fbdd52f44c1be998a9ab3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Apr 2022 23:31:17 +0000

flight 169630 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169630/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08
baseline version:
 xen                  54279f87ecbcb3eab45fbdd52f44c1be998a9ab3

Last test of basis   169622  2022-04-22 13:00:28 Z    0 days
Testing same since   169630  2022-04-22 20:01:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bobby Eshleman <bobby.eshleman@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   54279f87ec..2419a159fb  2419a159fb943c24a6f2439604b9fdb1478fcd08 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 22 23:41:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Apr 2022 23:41:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311325.528506 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2uG-0003r8-4c; Fri, 22 Apr 2022 23:41:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311325.528506; Fri, 22 Apr 2022 23:41:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni2uG-0003r1-1U; Fri, 22 Apr 2022 23:41:44 +0000
Received: by outflank-mailman (input) for mailman id 311325;
 Fri, 22 Apr 2022 23:41:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N0EE=VA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ni2uE-0003qv-OX
 for xen-devel@lists.xenproject.org; Fri, 22 Apr 2022 23:41:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2ae89cd-c295-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 01:41:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id ACA5CB83331;
 Fri, 22 Apr 2022 23:41:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2F7CC385A0;
 Fri, 22 Apr 2022 23:41:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2ae89cd-c295-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650670898;
	bh=5QuYhRgFPxWY9VGWC+SG9+xWFlM8oS8TIbaKaKxgZB0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=D+xh1F195TEvbAJuowysu5xIR7e1kUcloQNyTbl1JcbIhWY91exZ5OyiR1wK/ktrp
	 FN+o1+SBz967teSr1wxswh2iCgqnHUPGI6ltbBDclj0sP6cRsA49MOZ8jnvQx2yg0p
	 E14oeoyKKH6sAeYpDrgViKYoV09yyLRtyqliG4p/Z5ChXKDJPN/S47MwhUwo0rnUpG
	 REAs6JnJYT3KcTnJD4jYKbi8rSOCTXCAI9sQpOvAsv3jfkolKm94YP2CQJKPfJHN9n
	 qzGQokzq9F/ck+T8evmkVlI1a64zyWj4xYvKGb8nXSkKs4vCYg5EZqxiTdDgiDJioi
	 aexHDGRF1BPtg==
Date: Fri, 22 Apr 2022 16:41:37 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
In-Reply-To: <20220420055736.27901-1-jgross@suse.com>
Message-ID: <alpine.DEB.2.22.394.2204221640290.915916@ubuntu-linux-20-04-desktop>
References: <20220420055736.27901-1-jgross@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 20 Apr 2022, Juergen Gross wrote:
> Today iommu_do_domctl() is being called from arch_do_domctl() in the
> "default:" case of a switch statement. This has led already to crashes
> due to unvalidated parameters.
> 
> Fix that by moving the call of iommu_do_domctl() to the main switch
> statement of do_domctl().
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

For the ARM side:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


I have no opinion on the ENOSYS vs EOPNOTSUPP discussion.



> ---
> V3:
> - new patch
> V4:
> - add iommu_do_domctl() stub for !CONFIG_HAS_PASSTHROUGH (Andrew Cooper,
>   Jan Beulich)
> ---
>  xen/arch/arm/domctl.c   | 11 +----------
>  xen/arch/x86/domctl.c   |  2 +-
>  xen/common/domctl.c     |  7 +++++++
>  xen/include/xen/iommu.h | 12 +++++++++---
>  4 files changed, 18 insertions(+), 14 deletions(-)
> 
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index 6245af6d0b..1baf25c3d9 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -176,16 +176,7 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
>          return rc;
>      }
>      default:
> -    {
> -        int rc;
> -
> -        rc = subarch_do_domctl(domctl, d, u_domctl);
> -
> -        if ( rc == -ENOSYS )
> -            rc = iommu_do_domctl(domctl, d, u_domctl);
> -
> -        return rc;
> -    }
> +        return subarch_do_domctl(domctl, d, u_domctl);
>      }
>  }
>  
> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> index a6aae500a3..c9699bb868 100644
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -1380,7 +1380,7 @@ long arch_do_domctl(
>          break;
>  
>      default:
> -        ret = iommu_do_domctl(domctl, d, u_domctl);
> +        ret = -ENOSYS;
>          break;
>      }
>  
> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index 5879117580..0a866e3132 100644
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -871,6 +871,13 @@ long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>              copyback = 1;
>          break;
>  
> +    case XEN_DOMCTL_assign_device:
> +    case XEN_DOMCTL_test_assign_device:
> +    case XEN_DOMCTL_deassign_device:
> +    case XEN_DOMCTL_get_device_group:
> +        ret = iommu_do_domctl(op, d, u_domctl);
> +        break;
> +
>      default:
>          ret = arch_do_domctl(op, d, u_domctl);
>          break;
> diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
> index 3a83981464..c6bbb65bbf 100644
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -341,8 +341,17 @@ struct domain_iommu {
>  /* Does the IOMMU pagetable need to be kept synchronized with the P2M */
>  #ifdef CONFIG_HAS_PASSTHROUGH
>  #define need_iommu_pt_sync(d)     (dom_iommu(d)->need_sync)
> +
> +int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
> +                    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
>  #else
>  #define need_iommu_pt_sync(d)     ({ (void)(d); false; })
> +
> +static inline int iommu_do_domctl(struct xen_domctl *domctl, struct domain *d,
> +                                  XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
> +{
> +    return -ENOSYS;
> +}
>  #endif
>  
>  int __must_check iommu_suspend(void);
> @@ -356,9 +365,6 @@ int iommu_do_pci_domctl(struct xen_domctl *, struct domain *d,
>                          XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
>  #endif
>  
> -int iommu_do_domctl(struct xen_domctl *, struct domain *d,
> -                    XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
> -
>  void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev);
>  
>  /*
> -- 
> 2.34.1
> 


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 00:12:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 00:12:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311330.528517 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni3Nn-0000It-MI; Sat, 23 Apr 2022 00:12:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311330.528517; Sat, 23 Apr 2022 00:12:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni3Nn-0000Im-JM; Sat, 23 Apr 2022 00:12:15 +0000
Received: by outflank-mailman (input) for mailman id 311330;
 Sat, 23 Apr 2022 00:12:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni3Nm-0000Ic-7b; Sat, 23 Apr 2022 00:12:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni3Nm-00062B-3L; Sat, 23 Apr 2022 00:12:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni3Nl-0007lV-O7; Sat, 23 Apr 2022 00:12:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni3Nl-0003A2-Nb; Sat, 23 Apr 2022 00:12:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hFpHysVsHvzOEsaHMjxy6UCsDHHWig7T0+tjz9rEwwI=; b=vrQX8MZLEzyKNw7BrvXLoptHFV
	QJLbe97dIacaxAKzq5D5B36oN55rF8pnF91b4l9v0sqzaRrNxbvKqnT2g5VXT1rK03sflFJBU/q3Q
	uaOPOqyUzJP1GGK2DeAUFjuRbJXypTn3Sm82QIx+j4WBQHjVm8z7cBoR/Mo1T3uyUAuo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169631-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169631: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 00:12:13 +0000

flight 169631 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169631/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  559 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 01:01:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 01:01:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311338.528529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni49J-0003d7-21; Sat, 23 Apr 2022 01:01:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311338.528529; Sat, 23 Apr 2022 01:01:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni49I-0003cm-VO; Sat, 23 Apr 2022 01:01:20 +0000
Received: by outflank-mailman (input) for mailman id 311338;
 Sat, 23 Apr 2022 01:01:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni49H-00037F-KR; Sat, 23 Apr 2022 01:01:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni49H-0004kH-HE; Sat, 23 Apr 2022 01:01:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni49H-0000bS-4x; Sat, 23 Apr 2022 01:01:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni49H-0001oC-4W; Sat, 23 Apr 2022 01:01:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bW0p1y18d5SSRlxR+DkqKnGBT2qUhsnZga5+2QmH82s=; b=cxIKIMSdYBcCfU1OrLc3CiqzoQ
	Tk6kUcTkD6tvQnnP3laoYplIFQ3iYjNIM88hQdDyvSZ5xpzH6FMXdkqtWHf+rjhTBiHyUJhckvkRj
	LgzU4oAgzbNojj1cej+TW6PKp17UPaoh9Bv/NDsZlOpohTQdiTipvG2+ug74H4KNhEg8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169632-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169632: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 01:01:19 +0000

flight 169632 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169632/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  560 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 01:31:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 01:31:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311348.528540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni4cL-0000Cv-Mh; Sat, 23 Apr 2022 01:31:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311348.528540; Sat, 23 Apr 2022 01:31:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni4cL-0000Cn-HI; Sat, 23 Apr 2022 01:31:21 +0000
Received: by outflank-mailman (input) for mailman id 311348;
 Sat, 23 Apr 2022 01:31:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni4cK-0000Ca-Hv; Sat, 23 Apr 2022 01:31:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni4cK-0005By-Gk; Sat, 23 Apr 2022 01:31:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni4cJ-0001is-Vr; Sat, 23 Apr 2022 01:31:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni4cJ-0002uA-UZ; Sat, 23 Apr 2022 01:31:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cEsWLLkKK4J9wcEQYLdHBynXibs723X6XkI5XfUGCgM=; b=eoqQrM2kKh+A2+uL2jUrLjbw+o
	c+k65mUHtyva8p6T2tWeW3aGPAIxMeXM+IylNIO7bzeUVnGxsVwX3/cDD4HXTL7cjqWzmPHqXWlS8
	OI3FJ8VKqZlLT9S8tYfVZBXV7b1jb/bYR6FTFK8TpgCQSUYHUfgLgycjQVeczamwApCs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169633-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169633: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 01:31:19 +0000

flight 169633 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169633/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   52 days  561 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 02:01:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 02:01:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311357.528559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni55c-0004f3-15; Sat, 23 Apr 2022 02:01:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311357.528559; Sat, 23 Apr 2022 02:01:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni55b-0004ew-SJ; Sat, 23 Apr 2022 02:01:35 +0000
Received: by outflank-mailman (input) for mailman id 311357;
 Sat, 23 Apr 2022 02:01:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni55a-0004em-Pd; Sat, 23 Apr 2022 02:01:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni55a-00069a-N7; Sat, 23 Apr 2022 02:01:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni55a-0002hW-DR; Sat, 23 Apr 2022 02:01:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni55a-0001an-BS; Sat, 23 Apr 2022 02:01:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YsqPpxRD144Z1YDGhWYhQJ/unN6NNg2fMB3B6DCK3Cc=; b=wtJ4TsXqELm3DXDAhDiKVrQyro
	D2FXuH0HpqZubgK25r4MZKUtGZ2fhJZ0nGLfkl4d5GuPGkO1JyQ7WXLBwq3CdrxlbQ7RDMuFTIFjU
	uCc+ke3j5gg1YQDT1hEuGU4fbE/8JmtH28CcJWVgRsJ556CDKwHArWYb3WobZdaDePLc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169624-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169624: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=43f3d51139178a03823b061482c674e15ce3d49c
X-Osstest-Versions-That:
    xen=fdef107edd4459375f9c0e6e377f30e82d498747
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 02:01:34 +0000

flight 169624 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169624/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169591
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169608
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169608
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169608
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169608
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169608
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169608
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169608
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169608
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169608
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169608
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169608
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  43f3d51139178a03823b061482c674e15ce3d49c
baseline version:
 xen                  fdef107edd4459375f9c0e6e377f30e82d498747

Last test of basis   169608  2022-04-22 01:52:06 Z    1 days
Testing same since   169624  2022-04-22 14:09:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   fdef107edd..43f3d51139  43f3d51139178a03823b061482c674e15ce3d49c -> master


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 02:02:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 02:02:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311363.528570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni56W-0005Ss-Ay; Sat, 23 Apr 2022 02:02:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311363.528570; Sat, 23 Apr 2022 02:02:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni56W-0005Sk-6e; Sat, 23 Apr 2022 02:02:32 +0000
Received: by outflank-mailman (input) for mailman id 311363;
 Sat, 23 Apr 2022 02:02:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni56U-0005SX-Tw; Sat, 23 Apr 2022 02:02:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni56U-0006AH-T8; Sat, 23 Apr 2022 02:02:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni56U-0002jv-90; Sat, 23 Apr 2022 02:02:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni56U-0002Eu-8Y; Sat, 23 Apr 2022 02:02:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=D2IiqC9+rPq1tDZuhuHOy7tRCztYUnwSlBULgwjgUAo=; b=Ys40Zh80eht5qC4pBTw+BqbMsB
	rtXwrdTtt+XTpBvHMqura9Bkit6zbrn1Z4q0dHvBCWGUrn+s33MzrqKgAesSAzaRuzM/REYQhVGmw
	B3qM6yTgtCHsCSALBOEjmErRRZdM4KJ36ICbeH8qvrT+rvkN/WgxSL74OcwvXHYaUxkw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169634-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169634: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 02:02:30 +0000

flight 169634 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169634/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  562 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 02:55:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 02:55:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311373.528580 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni5vD-0003S0-BS; Sat, 23 Apr 2022 02:54:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311373.528580; Sat, 23 Apr 2022 02:54:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni5vD-0003Rt-8I; Sat, 23 Apr 2022 02:54:55 +0000
Received: by outflank-mailman (input) for mailman id 311373;
 Sat, 23 Apr 2022 02:54:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni5vB-0003Ri-OW; Sat, 23 Apr 2022 02:54:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni5vB-00071W-MT; Sat, 23 Apr 2022 02:54:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni5vB-00048D-4s; Sat, 23 Apr 2022 02:54:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni5vB-0004Zf-4T; Sat, 23 Apr 2022 02:54:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tHgAC1v9grfH7c2dWbJE4plJe1v4/ACo34iORqE5pPw=; b=L0KPxA9/2YuPFwvgCaP4s86y9Q
	CjARrlZ20CNth+c8w+HeSSgJ5wAp5/IXrICigmXWiGUOudHS9Bq8/XF03hgP6MI8mUQhvYoDJsYwH
	O9sNMsxXESRF77S+fNPdyVXj/A8E4+DjOMbGnOuX6HQaiIwKg/Cgm2q/eeXQ3PrJN6cY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169636-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169636: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 02:54:53 +0000

flight 169636 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169636/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  563 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 03:10:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 03:10:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311381.528592 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni6AJ-000611-L8; Sat, 23 Apr 2022 03:10:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311381.528592; Sat, 23 Apr 2022 03:10:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni6AJ-00060u-HY; Sat, 23 Apr 2022 03:10:31 +0000
Received: by outflank-mailman (input) for mailman id 311381;
 Sat, 23 Apr 2022 03:10:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni6AI-00060k-TC; Sat, 23 Apr 2022 03:10:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni6AI-0007Ia-Pf; Sat, 23 Apr 2022 03:10:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni6AI-0004bR-By; Sat, 23 Apr 2022 03:10:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni6AI-0005tC-BW; Sat, 23 Apr 2022 03:10:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+cMWxuhaDbbKE8TThhVbV4wWMlq39Kl8ME5LwJvvbxM=; b=EtyTNWVaA/Dq0JqoXhVR+bWDEM
	DgfCqqzhfLdB3wTliWrICvvwWUwJF7N8Ztvx2mXyD4/MmrmX8yw2xYiZ/lUjqztBVV9hptcdsaK6s
	EkY8etZXtAAFluw3HhcE79HRIWJJfMPOx8gKoEzZnh+qfNZ3MlV8aW81ymPgTKstreeE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169627-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169627: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=d569e86915b7f2f9795588591c8d5ea0b66481cb
X-Osstest-Versions-That:
    linux=b05a5683eba6e2d40eadd5eeef53c4864149a4fe
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 03:10:30 +0000

flight 169627 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169627/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169609
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169609
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169609
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169609
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169609
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169609
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169609
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169609
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                d569e86915b7f2f9795588591c8d5ea0b66481cb
baseline version:
 linux                b05a5683eba6e2d40eadd5eeef53c4864149a4fe

Last test of basis   169609  2022-04-22 03:12:48 Z    0 days
Testing same since   169627  2022-04-22 16:11:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dave Airlie <airlied@redhat.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
  José Roberto de Souza <jose.souza@intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Manasi Navare <manasi.d.navare@intel.com>
  Rob Clark <robdclark@chromium.org>
  Rob Clark <robdclark@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b05a5683eba6..d569e86915b7  d569e86915b7f2f9795588591c8d5ea0b66481cb -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 04:06:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 04:06:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311391.528603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni72V-0004Jf-TM; Sat, 23 Apr 2022 04:06:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311391.528603; Sat, 23 Apr 2022 04:06:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni72V-0004JY-QT; Sat, 23 Apr 2022 04:06:31 +0000
Received: by outflank-mailman (input) for mailman id 311391;
 Sat, 23 Apr 2022 04:06:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni72U-0004JN-6R; Sat, 23 Apr 2022 04:06:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni72U-0008Ih-4b; Sat, 23 Apr 2022 04:06:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni72T-0000KJ-HM; Sat, 23 Apr 2022 04:06:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni72T-00040S-Gt; Sat, 23 Apr 2022 04:06:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6L7jXMNxm4Vv5c26XDRqz2LCmiEwEAAzzNrw9IfZ3vk=; b=H6/zEZFdOyUOh7jkwub4+dCifr
	9tavMNzQ7zny+LbzIMPR1HfhD4LrQjgLV9Z6HI1kBsUEx0dzTfysncYjbNMpeuKWR9fF6pqq2IqDz
	95r+57KERvev1bGBJ4wc0oy3HdZm/AzmOWtyEZs7DDhKsUAi00WJyCnS/nR5siOP8rQs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169637-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169637: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 04:06:29 +0000

flight 169637 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169637/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  564 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 04:42:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 04:42:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311400.528613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni7bS-0001Bo-Ol; Sat, 23 Apr 2022 04:42:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311400.528613; Sat, 23 Apr 2022 04:42:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni7bS-0001Bh-LT; Sat, 23 Apr 2022 04:42:38 +0000
Received: by outflank-mailman (input) for mailman id 311400;
 Sat, 23 Apr 2022 04:42:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni7bR-0001BX-N1; Sat, 23 Apr 2022 04:42:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni7bR-0000ge-LQ; Sat, 23 Apr 2022 04:42:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni7bR-0002Cx-B5; Sat, 23 Apr 2022 04:42:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni7bR-0008DB-Ac; Sat, 23 Apr 2022 04:42:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kS1fW4fvWDMcrDsgTezKFP8MpzaobA4eT0il1E9TNDU=; b=FfUWw3378zt1bvsuGs0Q6pE6p/
	Zv4IgiVLAOc5W/PvwIx5xhd/tTkG1I05MnNcig6WI9SH8tV/k1nJq9Rl15qVjtKVr8wwVxk+dhqBL
	NQc17cBp3pO+5l7KEwtLYbHF4jht0FX+/+wqD3q9he9XlTIbqMX0OrG6BYuYn/ceHAJk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169639-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169639: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 04:42:37 +0000

flight 169639 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169639/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  565 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 05:19:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 05:19:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311409.528625 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni8Ax-0005ZD-IE; Sat, 23 Apr 2022 05:19:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311409.528625; Sat, 23 Apr 2022 05:19:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni8Ax-0005Z6-Ej; Sat, 23 Apr 2022 05:19:19 +0000
Received: by outflank-mailman (input) for mailman id 311409;
 Sat, 23 Apr 2022 05:19:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fLqp=VB=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1ni8Aw-0005Z0-6a
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 05:19:18 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eafcb626-c2c4-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 07:19:17 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id CEC0C68AFE; Sat, 23 Apr 2022 07:19:12 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eafcb626-c2c4-11ec-a405-831a346695d4
Date: Sat, 23 Apr 2022 07:19:12 +0200
From: Christoph Hellwig <hch@lst.de>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Juergen Gross <jgross@suse.com>, Rahul Singh <Rahul.Singh@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: xen-swiotlb issue when NVMe driver is enabled in Dom0 on ARM
Message-ID: <20220423051912.GB17488@lst.de>
References: <49E3535A-5672-4047-AF86-05D5597C7019@arm.com> <alpine.DEB.2.22.394.2204191933450.915916@ubuntu-linux-20-04-desktop> <5C7EC3F4-9126-46E8-9321-60878357F939@arm.com> <alpine.DEB.2.22.394.2204201523390.915916@ubuntu-linux-20-04-desktop> <12279FAE-2141-469E-A424-9984348E84BB@arm.com> <alpine.DEB.2.22.394.2204211444190.915916@ubuntu-linux-20-04-desktop> <20220422050405.GA10195@lst.de> <105DB518-DB5B-47F8-852F-C997678BBCE6@arm.com> <86bc7ae3-d7af-5f6e-d246-b53a4fa8bc79@suse.com> <alpine.DEB.2.22.394.2204221319490.915916@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2204221319490.915916@ubuntu-linux-20-04-desktop>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Fri, Apr 22, 2022 at 01:29:54PM -0700, Stefano Stabellini wrote:
> It is great to remove xen_alloc_coherent_pages/xen_free_coherent_pages
> for ARM. We can safely remove them because on ARM we can only use
> swiotlb-xen when the domain is 1:1 mapped. So it is impossible to get
> into a situation where memory allocated expected to be contiguous is not
> actually contiguous.
> 
> So, from an ARM point of view, it is great. However,
> DMA_ATTR_NO_KERNEL_MAPPING wouldn't work on x86 still? I don't know if
> matters.

It works by ignoring it, just like it works for most of the other
DMA OPS instance.  The problem with the existing xen swiotlb case
is it tries to interpret what is returned by dma_direct_alloc.
Driver must not do that per the API contract and just use the DMA
handle while using the return value as a cookie only. It is a odd
API and I plan to remove it eventually.

> Then a small NIT: the declaration of xen_create_contiguous_region and
> xen_destroy_contiguous_region should be moved away from
> include/xen/xen-ops.h to an arch/x86 specific header. For instance to
> arch/x86/include/asm/xen/swiotlb-xen.h. Or at least the #ifdef in
> include/xen/xen-ops.h should change, currently it is:
> 
> #if defined(CONFIG_XEN_PV) || defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> 				unsigned int address_bits,
> 				dma_addr_t *dma_handle);
> void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order);
> #endif

I'll resend a cleaned up version in a bit.


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 05:30:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 05:30:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311420.528635 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni8LG-0007JL-H7; Sat, 23 Apr 2022 05:29:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311420.528635; Sat, 23 Apr 2022 05:29:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni8LG-0007JE-Dz; Sat, 23 Apr 2022 05:29:58 +0000
Received: by outflank-mailman (input) for mailman id 311420;
 Sat, 23 Apr 2022 05:29:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni8LF-0007J3-55; Sat, 23 Apr 2022 05:29:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni8LF-0001n7-10; Sat, 23 Apr 2022 05:29:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ni8LE-0004cK-Om; Sat, 23 Apr 2022 05:29:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ni8LE-0000PN-Nu; Sat, 23 Apr 2022 05:29:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8kwqKBRupXZdBT9OkmqUTijt6E89K7RznNfSqC3nx/w=; b=EX2XmTobck9DWCw3RZwWgkHwjq
	6kIsK5g9pUA/mKPAiTWUOnNyZK3gWjwJTf6Y9b1JkRvZrACYBZP6RjCsO2mtx4b47u+I+0bHRlse9
	Z3Pfi3iq2cqEPLe8cm2srme1vc46siFqo5XlXBUj0upJe2yAxr5fH3u7i2O8Nt9JtmG0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169629-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169629: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=754f756cc4c6d9d14b7230c62b5bb20f9d655888
X-Osstest-Versions-That:
    qemuu=a74782936dc6e979ce371dabda4b1c05624ea87f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 05:29:56 +0000

flight 169629 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169629/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169614
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169614
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169614
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169614
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169614
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169614
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169614
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169614
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                754f756cc4c6d9d14b7230c62b5bb20f9d655888
baseline version:
 qemuu                a74782936dc6e979ce371dabda4b1c05624ea87f

Last test of basis   169614  2022-04-22 09:11:23 Z    0 days
Testing same since   169629  2022-04-22 18:42:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Atish Patra <atishp@rivosinc.com>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng.cn@gmail.com>
  Dylan Jhong <dylan@andestech.com>
  Frank Chang <frank.chang@sifive.com>
  Janosch Frank <frankja@linux.ibm.com>
  Jim Shu <jim.shu@sifive.com>
  Junqiang Wang <wangjunqiang@iscas.ac.cn>
  Nicolas Pitre <nico@fluxnic.net>
  Niklas Cassel <niklas.cassel@wdc.com>
  Peter Maydell <peter.maydell@linaro.org>
  Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>
  Richard Henderson <richard.henderson@linaro.org>
  Tsukasa OI <research_trasio@irq.a4lg.com>
  Viktor Prutyanov <viktor.prutyanov@redhat.com>
  Weiwei Li <liweiwei@iscas.ac.cn>
  Wilfred Mallawa <wilfred.mallawa@wdc.com>
  Xiang Chen <chenxiang66@hisilicon.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   a74782936d..754f756cc4  754f756cc4c6d9d14b7230c62b5bb20f9d655888 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 05:55:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 05:55:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311428.528646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni8ju-0002rf-Pc; Sat, 23 Apr 2022 05:55:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311428.528646; Sat, 23 Apr 2022 05:55:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni8ju-0002rY-Mj; Sat, 23 Apr 2022 05:55:26 +0000
Received: by outflank-mailman (input) for mailman id 311428;
 Sat, 23 Apr 2022 05:55:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JeyS=VB=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ni8jt-0002rS-W0
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 05:55:26 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7b0da6d-c2c9-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 07:55:24 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B979D1F388;
 Sat, 23 Apr 2022 05:55:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 698E613AD8;
 Sat, 23 Apr 2022 05:55:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id cghtGMuUY2LTDgAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 23 Apr 2022 05:55:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7b0da6d-c2c9-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650693323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=7zn4Dd4I99qMEB3R07m+sR/CWx3UUvE0Rb/eZDjb15o=;
	b=bA0B6XE67+88fzl+7E820ikzw2i5a/j4YUkKPj0NercpkvOXEic1REgtPT28H3wxInkTd4
	68yVbevqm5dk/Ku8UdjUj94iSoQjBJSl3RLAQVzBdn9x7NLRTZSYaIBuQt6jnRBNJcAREK
	awxUvKW88j4vfwE75b5eso6C25Z5qDA=
Message-ID: <dcce470b-56ad-c82a-bfe0-3eae2f460e24@suse.com>
Date: Sat, 23 Apr 2022 07:55:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <George.Dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220420055736.27901-1-jgross@suse.com>
 <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
 <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
 <74f6105d-d3a3-6508-3c6f-3aac53285c5f@suse.com>
 <7f55e68c-17ed-c682-9ba7-4835d8e1a79b@citrix.com>
 <a83fc8db-f8c0-5a17-a668-1a00cb1fdc2a@suse.com>
 <a39c8975-b331-8d3b-a09d-688a91fa8fb1@citrix.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
In-Reply-To: <a39c8975-b331-8d3b-a09d-688a91fa8fb1@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------5GTn4F5ytGxLroBDrRFN0nbM"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------5GTn4F5ytGxLroBDrRFN0nbM
Content-Type: multipart/mixed; boundary="------------4ExohZE7IxYE9OEipBWd98mr";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <George.Dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <dcce470b-56ad-c82a-bfe0-3eae2f460e24@suse.com>
Subject: Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
References: <20220420055736.27901-1-jgross@suse.com>
 <927d3bbd-64db-15dc-9bec-270711b9c1a8@suse.com>
 <a2489d58-883e-01e7-1b7d-0413b4006fbe@suse.com>
 <74f6105d-d3a3-6508-3c6f-3aac53285c5f@suse.com>
 <7f55e68c-17ed-c682-9ba7-4835d8e1a79b@citrix.com>
 <a83fc8db-f8c0-5a17-a668-1a00cb1fdc2a@suse.com>
 <a39c8975-b331-8d3b-a09d-688a91fa8fb1@citrix.com>
In-Reply-To: <a39c8975-b331-8d3b-a09d-688a91fa8fb1@citrix.com>

--------------4ExohZE7IxYE9OEipBWd98mr
Content-Type: multipart/mixed; boundary="------------i8J04AFYXRuU0UN4lSTMfTuP"

--------------i8J04AFYXRuU0UN4lSTMfTuP
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjIuMDQuMjIgMjE6MDEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDIyLzA0LzIw
MjIgMDg6MDksIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMjEuMDQuMjAyMiAxOTo0Nywg
QW5kcmV3IENvb3BlciB3cm90ZToNCj4+PiBPbiAyMC8wNC8yMDIyIDA3OjI3LCBKYW4gQmV1
bGljaCB3cm90ZToNCj4+Pj4gT24gMjAuMDQuMjAyMiAwODoyMiwgSnVlcmdlbiBHcm9zcyB3
cm90ZToNCj4+Pj4+IE9uIDIwLjA0LjIyIDA4OjExLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+
Pj4+PiBPbiAyMC4wNC4yMDIyIDA3OjU3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+Pj4+
PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vaW9tbXUuaA0KPj4+Pj4+PiArKysgYi94ZW4vaW5j
bHVkZS94ZW4vaW9tbXUuaA0KPj4+Pj4+PiBAQCAtMzQxLDggKzM0MSwxNyBAQCBzdHJ1Y3Qg
ZG9tYWluX2lvbW11IHsNCj4+Pj4+Pj4gICAgLyogRG9lcyB0aGUgSU9NTVUgcGFnZXRhYmxl
IG5lZWQgdG8gYmUga2VwdCBzeW5jaHJvbml6ZWQgd2l0aCB0aGUgUDJNICovDQo+Pj4+Pj4+
ICAgICNpZmRlZiBDT05GSUdfSEFTX1BBU1NUSFJPVUdIDQo+Pj4+Pj4+ICAgICNkZWZpbmUg
bmVlZF9pb21tdV9wdF9zeW5jKGQpICAgICAoZG9tX2lvbW11KGQpLT5uZWVkX3N5bmMpDQo+
Pj4+Pj4+ICsNCj4+Pj4+Pj4gK2ludCBpb21tdV9kb19kb21jdGwoc3RydWN0IHhlbl9kb21j
dGwgKmRvbWN0bCwgc3RydWN0IGRvbWFpbiAqZCwNCj4+Pj4+Pj4gKyAgICAgICAgICAgICAg
ICAgICAgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3RsKTsN
Cj4+Pj4+Pj4gICAgI2Vsc2UNCj4+Pj4+Pj4gICAgI2RlZmluZSBuZWVkX2lvbW11X3B0X3N5
bmMoZCkgICAgICh7ICh2b2lkKShkKTsgZmFsc2U7IH0pDQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4g
K3N0YXRpYyBpbmxpbmUgaW50IGlvbW11X2RvX2RvbWN0bChzdHJ1Y3QgeGVuX2RvbWN0bCAq
ZG9tY3RsLCBzdHJ1Y3QgZG9tYWluICpkLA0KPj4+Pj4+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0oeGVuX2RvbWN0bF90KSB1
X2RvbWN0bCkNCj4+Pj4+Pj4gK3sNCj4+Pj4+Pj4gKyAgICByZXR1cm4gLUVOT1NZUzsNCj4+
Pj4+Pj4gK30NCj4+Pj4+PiBBcyBzYWlkIGluIHJlcGx5IHRvIEFuZHJldyBhcyB3ZWxsIGFz
IGluIGEgbnVtYmVyIG9yIGVhcmxpZXIgb2NjYXNpb25zLA0KPj4+Pj4+IEkgZmlybWx5IHRo
aW5rIHRoYXQgdGhpcyB3YW50cyB0byBiZSAtRU9QTk9UU1VQUCwgbm90IC1FTk9TWVMuIFZp
ZXdzDQo+Pj4+PiBJbiBsaWJ4bCB0aGVyZSBpcyBhbiBleHBsaWNpdCBjaGVjayBmb3IgRU5P
U1lTIGJlaW5nIHJldHVybmVkIGZvcg0KPj4+Pj4gYXNzaWduaW5nL2RlYXNzaWduaW5nIGEg
ZGV2aWNlLCBzYW1lIGluIHRoZSB4YyBweXRob24gYmluZGluZ3MuDQo+Pj4+IFVyZ2guDQo+
Pj4gSG9uZXN0bHksIEkgd2Fzbid0IHBhcnRpY3VsYXJseSBoYXBweSB3aXRoIHlvdXIgcHVz
aCB0byBzd2FwIEVOT1NZUyBvdXQNCj4+PiBmb3IgRU9QTk9UU1VQUC7CoCBUaGlzIHNob3dz
IHBsYWlubHkgd2h5IGl0J3MgYSBiYWQgbW92ZS4NCj4+Pg0KPj4+IEFuIGVuZCB1c2VyIGRv
ZXNuJ3QgZ2l2ZSB0d28gaG9vdHMgYWJvdXQgdGhlIGRpc3RpbmN0aW9uIGJldHdlZW4NCj4+
PiBoeXBlcmNhbGwgbm90IHN1cHBvcnRlZCBhbmQgc3Vib3BzIG5vdCBzdXBwb3J0ZWQ7IHRo
ZXkgY2FyZSBhYm91dA0KPj4+IHdoZXRoZXIgWGVuIGNhbiBwZXJmb3JtIHRoZSByZXF1ZXN0
ZWQgYWN0aW9uIG9yIG5vdC7CoCBFTk9TWVMgaXMgdGhlIG1vcmUNCj4+PiBjb21tb24gd2F5
IG9mIHNpZ25hbGxpbmcgdGhpcywgYW5kIGhhdmluZyBvbmx5IG9uZSBlcnJubyB2YWx1ZSB0
byBjaGVjaw0KPj4+IGlzIGJldHRlciBmb3IgZXZlcnlvbmUgaW52b2x2ZWQuDQo+PiBFbmQg
dXNlcnMgYXJlIG9mIGxpdHRsZSBpbnRlcmVzdCBoZXJlLiBDb2RlIGxvb2tpbmcgZm9yIEVO
T1NZUyBpcyB3aGF0DQo+PiBpcyBvZiBpbnRlcmVzdCwgd2hlbiB0aGUgbWVhbmluZyBvZiBF
Tk9TWVMgaXMgcXVpdGUgd2VsbCBkZWZpbmVkIGFzDQo+PiAic3lzdGVtIGNhbGwgbm90IGlt
cGxlbWVudGVkIg0KPiANCj4gUE9TSVggc3BlY2lmaWVzIGl0IGFzICJGdW5jdGlvbmFsaXR5
IG5vdCBzdXBwb3J0ZWQiIHdoaWNoIGlzIHdoeSBvdGhlcg0KPiBjb21wbGltZW50IHN5c3Rl
bXMgdXNlIGl0IGZvciBzbWFsbGVyIGdyYW51bGFyaXR5IHRoYW4gYSBzeXN0ZW0gY2FsbC4N
Cg0KVGhpbmtpbmcgYSBsaXR0bGUgYml0IG1vcmUgYWJvdXQgdGhpcyB0b3BpYywgSSdkIGxp
a2UgdG8gcmV0dXJuIEVOT1NZUy4NCg0KRU9QTk9UU1VQUCBzaG91bGQgYmUgcmV0dXJuZWQg
aW4gY2FzZSBhbiBvcGVyYXRpb24gaXMgbm90IHN1aXRhYmxlDQpmb3IgdGhlIGdpdmVuIHBh
cmFtZXRlciBjb21iaW5hdGlvbiAoZS5nLiBhbiBJT01NVSByZWxhdGVkIG9wZXJhdGlvbg0K
Zm9yIGEgZ3Vlc3Qgbm90IGJlaW5nIHN1YmplY3QgdG8gSU9NTVUgaGFuZGxpbmcpLiBUaGUg
c2FtZSBvcGVyYXRpb24NCmNhbiBiZSBzdWNjZXNzZnVsIG9uIHRoZSBnaXZlbiBzeXN0ZW0g
d2l0aCBvdGhlciBwYXJhbWV0ZXIgY29tYmluYXRpb25zLg0KDQpFTk9TWVMgc2hvdWxkIGJl
IHJldHVybmVkIGlmIHRoZSBjdXJyZW50IGh5cGVydmlzb3IgZG9lc24ndCBzdXBwb3J0IHRo
ZQ0KcmVxdWVzdGVkIG9wZXJhdGlvbiAoaHlwZXJjYWxsIG9yIGh5cGVyY2FsbCArIHN1Yi1v
cCkgb24gdGhlIGdpdmVuIHN5c3RlbQ0KYXQgYWxsLiBUaGUgaGlnaCBsZXZlbCBjYWxsZXIg
KGUuZy4gYSB1c2VyIG9mIGxpYnhjKSBkb2Vzbid0IGNhcmUsIHdoZXRoZXINCmEgcmVxdWVz
dGVkIG9wZXJhdGlvbiBpcyBhIGRlZGljYXRlZCBoeXBlcmNhbGwgb3IgYSBzdWItb3Agb2Yg
YSBoeXBlcmNhbGwuDQpUaGUgb25seSBpbnRlcmVzdGluZyBhc3BlY3QgaXMgd2hldGhlciB0
aGUgb3BlcmF0aW9uIGlzIHVuYXZhaWxhYmxlLCBvcg0KanVzdCBmYWlsaW5nIGR1ZSB0byB0
aGUgY3VycmVudCBzaXR1YXRpb24uDQoNCg0KSnVlcmdlbg0K
--------------i8J04AFYXRuU0UN4lSTMfTuP
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------i8J04AFYXRuU0UN4lSTMfTuP--

--------------4ExohZE7IxYE9OEipBWd98mr--

--------------5GTn4F5ytGxLroBDrRFN0nbM
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJjlMsFAwAAAAAACgkQsN6d1ii/Ey/U
iAf/eaRdEImoZ8hctljtdLhfU94TuK7i24bzFkP0daFaEMXbtIqSU12j4gVE76JeghOhFQq0j34o
XnaR6kOGPDh33ichWXg8re5p9+XUyb4J+R2OCPGnNjAQYNNW1l2ShFX5UopVQ5jshCjYZpQpsafB
lm8Eu5W96R5/Ug4D3S/rxWrLW9TuXlBe+bcHowLQ8JEQvKXrt4/wPNFWg6MarJuuo5FjsZWASLOc
kQ/Ait6kLN6uIYCU1BIQJ5foVOVorF/4P1hrOfXUQH2VC4iTEzGawn7Nft9uT/twacoWFH+JT5vO
LPOjDkTJfZSNInvuKeRQtUIz2h2TPjvnt/C0VdfdSA==
=9ruF
-----END PGP SIGNATURE-----

--------------5GTn4F5ytGxLroBDrRFN0nbM--


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 07:05:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 07:05:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311440.528657 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni9ph-00039W-1F; Sat, 23 Apr 2022 07:05:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311440.528657; Sat, 23 Apr 2022 07:05:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ni9pg-00039P-UF; Sat, 23 Apr 2022 07:05:28 +0000
Received: by outflank-mailman (input) for mailman id 311440;
 Sat, 23 Apr 2022 07:05:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hJIN=VB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ni9pf-00039I-T5
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 07:05:28 +0000
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
 [2a00:1450:4864:20::22a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bfad2ae3-c2d3-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 09:05:25 +0200 (CEST)
Received: by mail-lj1-x22a.google.com with SMTP id bn33so12044893ljb.6
 for <xen-devel@lists.xenproject.org>; Sat, 23 Apr 2022 00:05:25 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 d6-20020a056512320600b0047196449b7fsm507662lfe.92.2022.04.23.00.05.22
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 23 Apr 2022 00:05:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bfad2ae3-c2d3-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language;
        bh=/OlakjqnRmEAn/ytZGVcF22kYWzHUx0JWp7WuYws5xc=;
        b=dG3Cqw8W+risw5HhgeGUsOV40IIJN9LsfZ/mAt53EHPXci8Nh+AS0Ukg7ugAniPlvf
         2kMqWG/94faucQwjCFPGSlPgAniNw53bC+/Z2jpnNhuAfFOMslvUk8ffO+xJWC6elags
         DzBBmQPsl2ZWmlUpiBBlF/kAFNvs75hTOMhy9PUF8hRWso+0p7sI8aZARWWvGdyHQMw0
         cypec0klqiA/oNpDbS1oDR0knRoiDjcnaD2T5jJwo8w/NfJqc7VmUFOYOb4PF9TfGnUo
         fX5HlQ1of/u1PYZ2DZwtWGBh26oESoG/Q5kRpeZnQCI1cefaGnb0XbPe80ZES01fcHCu
         V0bQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language;
        bh=/OlakjqnRmEAn/ytZGVcF22kYWzHUx0JWp7WuYws5xc=;
        b=gooRYXM07AYueoO2op4pKQDJXa4DBWOSZz+WrCnCZg5KD6zWYhh5n7VfUCbMsFxt6i
         6vOVXZWyibgZgHwsIomlj/by1Sm040iqO2/4QNlnRVPHOnK7kXtxU5x0LdOuK+n0xXMF
         719C4VrEIlJQpeProMMj7AkeGJTcjl5qzH9KruVca4T6zGxCi1JOrPk2UlX2zCxPkr3b
         5cqeI0RLj5d3yj/eCqiHkqjSHpC+7Z/OecSGZhfKIBOhMJAnznReqnxIsCDCb9Uew7/F
         918Zj56lZDkXECA8CGrvA6cbRlcQ45dkJvYpz1B+II3ml31WCWJcOmy22ew+985KZH+r
         G49A==
X-Gm-Message-State: AOAM530Ss9qJ06fLLWnzDb0EQSfG2deKNdUiEDVhdABW4nBTVu6ZRGeW
	l0Bc79lYPC29a2AoT+qdUgE=
X-Google-Smtp-Source: ABdhPJzYqUou0JMTdEbgFu+n32xCOhNS5ykDoZom+OkX0kkYiAJxNaDtFp7tRuvODxqjyVzBcqPIcg==
X-Received: by 2002:a2e:9345:0:b0:24b:451:7ce1 with SMTP id m5-20020a2e9345000000b0024b04517ce1mr4877723ljh.258.1650697524590;
        Sat, 23 Apr 2022 00:05:24 -0700 (PDT)
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Juergen Gross <jgross@suse.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204221526221.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <3de2852b-0a94-fd1d-2eb6-fd818f33fc88@gmail.com>
Date: Sat, 23 Apr 2022 10:05:22 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204221526221.915916@ubuntu-linux-20-04-desktop>
Content-Type: multipart/mixed;
 boundary="------------1C2D46C789FB115F1F5DE02D"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------1C2D46C789FB115F1F5DE02D
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit


On 23.04.22 02:00, Stefano Stabellini wrote:

Hello Stefano


> On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Juergen Gross <jgross@suse.com>
>>
>> Introduce Xen grant DMA-mapping layer which contains special DMA-mapping
>> routines for providing grant references as DMA addresses to be used by
>> frontends (e.g. virtio) in Xen guests.
>>
>> In order to support virtio in Xen guests add a config option XEN_VIRTIO
>> enabling the user to specify whether in all Xen guests virtio should
>> be able to access memory via Xen grant mappings only on the host side.
>>
>> As this also requires providing arch_has_restricted_virtio_memory_access
>> implementation, switch from a pure stub to a real function on Arm
>> and combine with existing implementation for the SEV guests on x86.
>>
>> Add the needed functionality by providing a special set of DMA ops
>> handling the needed grant operations for the I/O pages.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> There are a couple of minor things that checkpatch.pl reports,

Thank you for pointing this out, my fault.


>   but aside
> from those the patch looks fine to me.

good


The attached diff to be squashed for the new version. One thing remains:

checkpatch.pl says regarding drivers/xen/grant-dma-ops.c:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#151:
new file mode 100644


Which, I assume, this is not an issue as new file falls under XEN 
HYPERVISOR INTERFACE maintainership?

scripts/get_maintainer.pl -f drivers/xen/grant-dma-ops.c
Boris Ostrovsky <boris.ostrovsky@oracle.com> (supporter:XEN HYPERVISOR 
INTERFACE)
Juergen Gross <jgross@suse.com> (supporter:XEN HYPERVISOR INTERFACE)
Stefano Stabellini <sstabellini@kernel.org> (reviewer:XEN HYPERVISOR 
INTERFACE)
xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE)
linux-kernel@vger.kernel.org (open list)

[snip]

-- 
Regards,

Oleksandr Tyshchenko


--------------1C2D46C789FB115F1F5DE02D
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-fixup.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
 filename="0001-fixup.patch"

>From 8d36fc5a3604a69848c300a42f1a78f8ace41829 Mon Sep 17 00:00:00 2001
From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Date: Sat, 23 Apr 2022 09:23:04 +0300
Subject: [PATCH] fixup

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
 drivers/xen/Kconfig         |  2 ++
 drivers/xen/grant-dma-ops.c | 21 ++++++++++++---------
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index b95581f..1727337 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -350,4 +350,6 @@ config XEN_VIRTIO
 	  guest type this will require special support on the backend side
 	  (qemu or kernel, depending on the virtio device types used).
 
+	  If in doubt, say n.
+
 endmenu
diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 70d5d77..b9d93d7 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -139,7 +139,7 @@ static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
 					      enum dma_data_direction dir,
 					      gfp_t gfp)
 {
-	WARN_ONCE(1, "xen_grant_dma_alloc_pages size %zu\n", size);
+	WARN_ONCE(1, "%s: size %zu\n", __func__, size);
 	return NULL;
 }
 
@@ -147,7 +147,7 @@ static void xen_grant_dma_free_pages(struct device *dev, size_t size,
 				     struct page *vaddr, dma_addr_t dma_handle,
 				     enum dma_data_direction dir)
 {
-	WARN_ONCE(1, "xen_grant_dma_free_pages size %zu\n", size);
+	WARN_ONCE(1, "%s: size %zu\n", __func__, size);
 }
 
 static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
@@ -160,7 +160,8 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
 	grant_ref_t grant;
 	dma_addr_t dma_handle;
 
-	BUG_ON(dir == DMA_NONE);
+	if (WARN_ON(dir == DMA_NONE))
+		return DMA_MAPPING_ERROR;
 
 	data = find_xen_grant_dma_data(dev);
 	if (!data)
@@ -190,7 +191,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
 	unsigned int i, n_pages = PFN_UP(size);
 	grant_ref_t grant;
 
-	BUG_ON(dir == DMA_NONE);
+	if (WARN_ON(dir == DMA_NONE))
+		return;
 
 	data = find_xen_grant_dma_data(dev);
 	if (!data)
@@ -219,7 +221,8 @@ static void xen_grant_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
 	struct scatterlist *s;
 	unsigned int i;
 
-	BUG_ON(dir == DMA_NONE);
+	if (WARN_ON(dir == DMA_NONE))
+		return;
 
 	for_each_sg(sg, s, nents, i)
 		xen_grant_dma_unmap_page(dev, s->dma_address, sg_dma_len(s), dir,
@@ -233,7 +236,8 @@ static int xen_grant_dma_map_sg(struct device *dev, struct scatterlist *sg,
 	struct scatterlist *s;
 	unsigned int i;
 
-	BUG_ON(dir == DMA_NONE);
+	if (WARN_ON(dir == DMA_NONE))
+		return -EINVAL;
 
 	for_each_sg(sg, s, nents, i) {
 		s->dma_address = xen_grant_dma_map_page(dev, sg_page(s), s->offset,
@@ -303,10 +307,9 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	}
 
 	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
-	if (!data) {
-		dev_err(dev, "Сannot allocate Xen grant DMA data\n");
+	if (!data)
 		goto err;
-	}
+
 	data->dev_domid = dev_domid;
 	data->dev = dev;
 
-- 
2.7.4


--------------1C2D46C789FB115F1F5DE02D--


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 07:39:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 07:39:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311446.528669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niAMR-0007CZ-FC; Sat, 23 Apr 2022 07:39:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311446.528669; Sat, 23 Apr 2022 07:39:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niAMR-0007CS-CG; Sat, 23 Apr 2022 07:39:19 +0000
Received: by outflank-mailman (input) for mailman id 311446;
 Sat, 23 Apr 2022 07:39:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hJIN=VB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1niAMQ-0007CM-4c
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 07:39:18 +0000
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
 [2a00:1450:4864:20::22a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7a740ae7-c2d8-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 09:39:16 +0200 (CEST)
Received: by mail-lj1-x22a.google.com with SMTP id bn33so12094795ljb.6
 for <xen-devel@lists.xenproject.org>; Sat, 23 Apr 2022 00:39:16 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 h28-20020a056512055c00b0046bb80943a9sm516890lfl.277.2022.04.23.00.39.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 23 Apr 2022 00:39:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a740ae7-c2d8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=9d2jHkf0EN2HagYieovcIbqUttEIC/mj0jQXYLAZ6UQ=;
        b=B9A4YkHx8mQq27yYAvgepgUFPzWrdmPRAlWM1MLWFYw2v1qDMfOTfrzmdFBCMK6Nys
         g/lTUnD2YLMGUmgAV3LNfR3OtzO3FcDdJH8X9vFHYqYuu2IUkr423T6P3UOol3shcl7K
         jP/Rrv+Tvdd9S36ltzDpEdRQqcEoFoR461BlBczUtyqVIirICVXk6OxQKOkxSvq+6UxW
         QhkYxNYJtCj7/jyaK5aAgeh1cY6c7EgWapTRc9S42jby7NlK+Qfd2krfmc3RyPXl+DG7
         Llu5fK5YLSNiX8BRua5LjBIxroHoguOKoGn4qgNF0ApGvkgCNG+edWipHbKyLbGYAS1C
         SyiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=9d2jHkf0EN2HagYieovcIbqUttEIC/mj0jQXYLAZ6UQ=;
        b=UxRhYk5Jdncj5/zsPhMnM73IMzD7Sr0H7woEhldmuobBAudUtrTIU86uxRc5bUs8m2
         fqWAdYu8a/w++cNPodlV3JSv7MmLZrTbFrF8pNRSzfpQUrKMmqgA8ZavzlAHetGz9Rdt
         4llhDk2s/tqea4mhgDzBW42BXH3fvqz68vvAGoFGXaPgqejUh2wgs4CFktD0vrnq1KQs
         FyUaUqFknEAIrAxQhNmmUYW47e8v4yjin9XwY+ytU2IN+hlHcZ9jqcO2ZMFDZBFSsxOT
         HEL5kx4A2iIfbhu+CRFp0sNpBJEvPyWUshQNQawPTjYuZpobI69wXNl34uNPXZqBmVk9
         srmA==
X-Gm-Message-State: AOAM5339Z6mHQOrh8AW3cZZcEOrAskhkofVRZNF5VOxlcSluPmUibmw7
	d08rHDexzyOcmLV+1L/cuAc=
X-Google-Smtp-Source: ABdhPJygB9RLBSU8PFYUwCCetVqQyNvgZEF57+ZvQHfv6vx0bX0AX2/bSZlplak8TbZYH8qi0zESog==
X-Received: by 2002:a05:651c:1548:b0:24d:d7ac:d8dd with SMTP id y8-20020a05651c154800b0024dd7acd8ddmr4982193ljp.521.1650699555901;
        Sat, 23 Apr 2022 00:39:15 -0700 (PDT)
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <YmJ4NLuvA63Irow+@Air-de-Roger>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <24112cfc-0446-d81e-85f1-ebf9da0afe14@gmail.com>
Date: Sat, 23 Apr 2022 10:39:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YmJ4NLuvA63Irow+@Air-de-Roger>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 22.04.22 12:41, Roger Pau Monné wrote:


Hello Roger

> On Fri, Apr 08, 2022 at 09:21:04PM +0300, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> This patch adds basic support for configuring and assisting virtio-mmio
>> based virtio-disk backend (emualator) which is intended to run out of
>> Qemu and could be run in any domain.
>> Although the Virtio block device is quite different from traditional
>> Xen PV block device (vbd) from the toolstack's point of view:
>>   - as the frontend is virtio-blk which is not a Xenbus driver, nothing
>>     written to Xenstore are fetched by the frontend (the vdev is not
>>     passed to the frontend)
>>   - the ring-ref/event-channel are not used for the backend<->frontend
>>     communication, the proposed IPC for Virtio is IOREQ/DM
>> it is still a "block device" and ought to be integrated in existing
>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
>> logic to deal with Virtio devices as well.
>>
>> For the immediate purpose and an ability to extend that support for
>> other use-cases in future (Qemu, virtio-pci, etc) perform the following
>> actions:
>> - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect
>>    that in the configuration
>> - Introduce new disk protocol field to libxl_device_disk struct
>>    (with LIBXL_DISK_PROTOCOL_XEN and LIBXL_DISK_PROTOCOL_VIRTIO_MMIO
>>    types) and reflect that in the configuration (new "protocol" option
>>    with "xen" protocol being default value)
>> - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
>>    one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model
>>
>> An example of domain configuration for Virtio disk:
>> disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, protocol=virtio-mmio']
>>
>> Nothing has changed for default Xen disk configuration.
>>
>> Please note, this patch is not enough for virtio-disk to work
>> on Xen (Arm), as for every Virtio device (including disk) we need
>> to allocate Virtio MMIO params (IRQ and memory region) and pass
>> them to the backend, also update Guest device-tree. The subsequent
>> patch will add these missing bits. For the current patch,
>> the default "irq" and "base" are just written to the Xenstore.
>> This is not an ideal splitting, but this way we avoid breaking
>> the bisectability.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>> Changes RFC -> V1:
>>     - no changes
>>
>> Changes V1 -> V2:
>>     - rebase according to the new location of libxl_virtio_disk.c
>>
>> Changes V2 -> V3:
>>     - no changes
>>
>> Changes V3 -> V4:
>>     - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT
>>
>> Changes V4 -> V5:
>>     - split the changes, change the order of the patches
>>     - update patch description
>>     - don't introduce new "vdisk" configuration option with own parsing logic,
>>       re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk
>>     - introduce "virtio" flag and document it's usage
>>     - add LIBXL_HAVE_DEVICE_DISK_VIRTIO
>>     - update libxlu_disk_l.[ch]
>>     - drop num_disks variable/MAX_VIRTIO_DISKS
>>     - drop Wei's T-b
>>
>> Changes V5 -> V6:
>>     - rebase on current staging
>>     - use "%"PRIu64 instead of %lu for disk->base in device_disk_add()
>>     - update *.gen.go files
>>
>> Changes V6 -> V7:
>>     - rebase on current staging
>>     - update *.gen.go files and libxlu_disk_l.[ch] files
>>     - update patch description
>>     - rework significantly to support more flexible configuration
>>       and have more generic basic implementation for being able to extend
>>       that for other use-cases (virtio-pci, qemu, etc).
>> ---
>>   docs/man/xl-disk-configuration.5.pod.in   |  37 +-
>>   tools/golang/xenlight/helpers.gen.go      |   6 +
>>   tools/golang/xenlight/types.gen.go        |  11 +
>>   tools/include/libxl.h                     |   6 +
>>   tools/libs/light/libxl_device.c           |  57 +-
>>   tools/libs/light/libxl_disk.c             | 111 +++-
>>   tools/libs/light/libxl_internal.h         |   1 +
>>   tools/libs/light/libxl_types.idl          |  10 +
>>   tools/libs/light/libxl_types_internal.idl |   1 +
>>   tools/libs/light/libxl_utils.c            |   2 +
>>   tools/libs/util/libxlu_disk_l.c           | 952 +++++++++++++++---------------
>>   tools/libs/util/libxlu_disk_l.h           |   2 +-
>>   tools/libs/util/libxlu_disk_l.l           |   9 +
>>   tools/xl/xl_block.c                       |  11 +
>>   14 files changed, 736 insertions(+), 480 deletions(-)
>>
>> diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in
>> index 71d0e86..36c851f 100644
>> --- a/docs/man/xl-disk-configuration.5.pod.in
>> +++ b/docs/man/xl-disk-configuration.5.pod.in
>> @@ -232,7 +232,7 @@ Specifies the backend implementation to use
>>   
>>   =item Supported values
>>   
>> -phy, qdisk
>> +phy, qdisk, other
>>   
>>   =item Mandatory
>>   
>> @@ -244,11 +244,13 @@ Automatically determine which backend to use.
>>   
>>   =back
>>   
>> -This does not affect the guest's view of the device.  It controls
>> -which software implementation of the Xen backend driver is used.
>> +It controls which software implementation of the backend driver is used.
>> +Depending on the "protocol" option this may affect the guest's view
>> +of the device.
>>   
>>   Not all backend drivers support all combinations of other options.
>> -For example, "phy" does not support formats other than "raw".
>> +For example, "phy" and "other" do not support formats other than "raw" and
>> +"other" does not support protocols other than "virtio-mmio".
>>   Normally this option should not be specified, in which case libxl will
>>   automatically determine the most suitable backend.
>>   
>> @@ -344,8 +346,35 @@ can be used to disable "hole punching" for file based backends which
>>   were intentionally created non-sparse to avoid fragmentation of the
>>   file.
>>   
>> +=item B<protocol>=I<PROTOCOL>
>> +
>> +=over 4
>> +
>> +=item Description
>> +
>> +Specifies the communication protocol to use for the chosen "backendtype" option
>> +
>> +=item Supported values
>> +
>> +xen, virtio-mmio
>  From a user PoV, I think it would be better to just select xen or
> virtio here, but not the underlying configuration mechanism used to
> expose the devices to the guest.

I got your point.



>
> We would likely need to add a different option to select mmio or pci
> then, but that should be set by default based on architecture/guest
> type.  For example on x86 it should default to pci, while on Arm I
> guess it will depend on whether the guest has PCI or not?
>
> In any case, I think we should offer an option that's selecting
> between xen or virtio protocol, and the way to expose the
> configuration of the device shouldn't need to be explicitly selected
> by the user.


ok, for now I will use "xen and virtio" values for the "protocol" 
option, then internally toolstack will assume that "virtio" really means 
"virtio-mmio".

When there is a need to expand that support to "virtio-pci", we will see 
how to deal with it from the configuration PoV, probably like you 
suggested above by adding another option (e.g. "transport") with default 
values based on the architecture/guest type.


>
> Thanks, Roger.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sat Apr 23 08:07:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 08:07:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311461.528680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niAnA-0003Nb-85; Sat, 23 Apr 2022 08:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311461.528680; Sat, 23 Apr 2022 08:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niAnA-0003NU-50; Sat, 23 Apr 2022 08:06:56 +0000
Received: by outflank-mailman (input) for mailman id 311461;
 Sat, 23 Apr 2022 08:06:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niAn8-0003N1-P5; Sat, 23 Apr 2022 08:06:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niAn8-0005DQ-Mu; Sat, 23 Apr 2022 08:06:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niAn8-000560-BC; Sat, 23 Apr 2022 08:06:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niAn8-0003PM-Aj; Sat, 23 Apr 2022 08:06:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lY/2zBhJzCwOAGPzMnD8gKzCJft6RRqUR0itf2CWpEE=; b=wNmQuYCAAtkbATMUi5lv4lk8sR
	tQeXMuRSRBj7fgOVvn+dQjUgCH6GMQ0UgL5fjpw7MbZn/N1U3KrbqGy7t2xBo6dZpP04KNPY9f7jt
	eO+QFC2IyDrKfrPcOUI04qrVoo7yMBWa0/LIhhgtTJlyHTJMsWlhvbq9E1SBsLLggtBs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169641-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169641: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 08:06:54 +0000

flight 169641 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169641/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  566 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 09:10:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 09:10:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311477.528690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niBmO-00038e-1Y; Sat, 23 Apr 2022 09:10:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311477.528690; Sat, 23 Apr 2022 09:10:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niBmN-00038X-Uo; Sat, 23 Apr 2022 09:10:11 +0000
Received: by outflank-mailman (input) for mailman id 311477;
 Sat, 23 Apr 2022 09:10:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JeyS=VB=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1niBmN-000381-IM
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 09:10:11 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2c788090-c2e5-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 11:10:09 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9677D21107;
 Sat, 23 Apr 2022 09:10:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CAFE13A1B;
 Sat, 23 Apr 2022 09:10:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id TlqKBXDCY2JqPQAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 23 Apr 2022 09:10:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c788090-c2e5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650705008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=LZcBEsRf4H4TUD/LeIhDCJzVbvZV1c9YPF146laEEeM=;
	b=EEpJluR3Y0YyLokU3njES4XnOYjNIqnoThKrkYg7sXIUUJNopUdSaqmOAirKNKsFmvV4+Q
	uzN+EI5avd9cRQv3jAaLYlAInBKvtSDY2C3BSoGC5ZhSk7QgTsvR1OB8Gke6oGp69PhFQe
	EYeaQct9YW9eufYb76CXu7ccyzP6zLM=
Message-ID: <8acfaa93-50ce-8dd9-49c6-cc328bb37569@suse.com>
Date: Sat, 23 Apr 2022 11:10:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204221526221.915916@ubuntu-linux-20-04-desktop>
 <3de2852b-0a94-fd1d-2eb6-fd818f33fc88@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <3de2852b-0a94-fd1d-2eb6-fd818f33fc88@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------o0kwwZd5WhI0vqwOQJ85oWOv"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------o0kwwZd5WhI0vqwOQJ85oWOv
Content-Type: multipart/mixed; boundary="------------DtRNb3Oo0VGbLsVI53cPNLg0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr <olekstysh@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
Message-ID: <8acfaa93-50ce-8dd9-49c6-cc328bb37569@suse.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204221526221.915916@ubuntu-linux-20-04-desktop>
 <3de2852b-0a94-fd1d-2eb6-fd818f33fc88@gmail.com>
In-Reply-To: <3de2852b-0a94-fd1d-2eb6-fd818f33fc88@gmail.com>

--------------DtRNb3Oo0VGbLsVI53cPNLg0
Content-Type: multipart/mixed; boundary="------------GUEFUP6KMNbzPrgiWpDseGco"

--------------GUEFUP6KMNbzPrgiWpDseGco
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjMuMDQuMjIgMDk6MDUsIE9sZWtzYW5kciB3cm90ZToNCj4gDQo+IE9uIDIzLjA0LjIy
IDAyOjAwLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IA0KPiBIZWxsbyBTdGVmYW5v
DQo+IA0KPiANCj4+IE9uIEZyaSwgMjIgQXByIDIwMjIsIE9sZWtzYW5kciBUeXNoY2hlbmtv
IHdyb3RlOg0KPj4+IEZyb206IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+
Pg0KPj4+IEludHJvZHVjZSBYZW4gZ3JhbnQgRE1BLW1hcHBpbmcgbGF5ZXIgd2hpY2ggY29u
dGFpbnMgc3BlY2lhbCBETUEtbWFwcGluZw0KPj4+IHJvdXRpbmVzIGZvciBwcm92aWRpbmcg
Z3JhbnQgcmVmZXJlbmNlcyBhcyBETUEgYWRkcmVzc2VzIHRvIGJlIHVzZWQgYnkNCj4+PiBm
cm9udGVuZHMgKGUuZy4gdmlydGlvKSBpbiBYZW4gZ3Vlc3RzLg0KPj4+DQo+Pj4gSW4gb3Jk
ZXIgdG8gc3VwcG9ydCB2aXJ0aW8gaW4gWGVuIGd1ZXN0cyBhZGQgYSBjb25maWcgb3B0aW9u
IFhFTl9WSVJUSU8NCj4+PiBlbmFibGluZyB0aGUgdXNlciB0byBzcGVjaWZ5IHdoZXRoZXIg
aW4gYWxsIFhlbiBndWVzdHMgdmlydGlvIHNob3VsZA0KPj4+IGJlIGFibGUgdG8gYWNjZXNz
IG1lbW9yeSB2aWEgWGVuIGdyYW50IG1hcHBpbmdzIG9ubHkgb24gdGhlIGhvc3Qgc2lkZS4N
Cj4+Pg0KPj4+IEFzIHRoaXMgYWxzbyByZXF1aXJlcyBwcm92aWRpbmcgYXJjaF9oYXNfcmVz
dHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vzcw0KPj4+IGltcGxlbWVudGF0aW9uLCBzd2l0
Y2ggZnJvbSBhIHB1cmUgc3R1YiB0byBhIHJlYWwgZnVuY3Rpb24gb24gQXJtDQo+Pj4gYW5k
IGNvbWJpbmUgd2l0aCBleGlzdGluZyBpbXBsZW1lbnRhdGlvbiBmb3IgdGhlIFNFViBndWVz
dHMgb24geDg2Lg0KPj4+DQo+Pj4gQWRkIHRoZSBuZWVkZWQgZnVuY3Rpb25hbGl0eSBieSBw
cm92aWRpbmcgYSBzcGVjaWFsIHNldCBvZiBETUEgb3BzDQo+Pj4gaGFuZGxpbmcgdGhlIG5l
ZWRlZCBncmFudCBvcGVyYXRpb25zIGZvciB0aGUgSS9PIHBhZ2VzLg0KPj4+DQo+Pj4gU2ln
bmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+IFNpZ25l
ZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0Bl
cGFtLmNvbT4NCj4+IFRoZXJlIGFyZSBhIGNvdXBsZSBvZiBtaW5vciB0aGluZ3MgdGhhdCBj
aGVja3BhdGNoLnBsIHJlcG9ydHMsDQo+IA0KPiBUaGFuayB5b3UgZm9yIHBvaW50aW5nIHRo
aXMgb3V0LCBteSBmYXVsdC4NCj4gDQo+IA0KPj4gwqAgYnV0IGFzaWRlDQo+PiBmcm9tIHRo
b3NlIHRoZSBwYXRjaCBsb29rcyBmaW5lIHRvIG1lLg0KPiANCj4gZ29vZA0KPiANCj4gDQo+
IFRoZSBhdHRhY2hlZCBkaWZmIHRvIGJlIHNxdWFzaGVkIGZvciB0aGUgbmV3IHZlcnNpb24u
IE9uZSB0aGluZyByZW1haW5zOg0KPiANCj4gY2hlY2twYXRjaC5wbCBzYXlzIHJlZ2FyZGlu
ZyBkcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmM6DQo+IA0KPiBXQVJOSU5HOiBhZGRlZCwg
bW92ZWQgb3IgZGVsZXRlZCBmaWxlKHMpLCBkb2VzIE1BSU5UQUlORVJTIG5lZWQgdXBkYXRp
bmc/DQo+ICMxNTE6DQo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+IA0KPiANCj4gV2hpY2gs
IEkgYXNzdW1lLCB0aGlzIGlzIG5vdCBhbiBpc3N1ZSBhcyBuZXcgZmlsZSBmYWxscyB1bmRl
ciBYRU4gSFlQRVJWSVNPUiANCj4gSU5URVJGQUNFIG1haW50YWluZXJzaGlwPw0KDQpZZXMu
DQoNCg0KSnVlcmdlbg0K
--------------GUEFUP6KMNbzPrgiWpDseGco
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------GUEFUP6KMNbzPrgiWpDseGco--

--------------DtRNb3Oo0VGbLsVI53cPNLg0--

--------------o0kwwZd5WhI0vqwOQJ85oWOv
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJjwm8FAwAAAAAACgkQsN6d1ii/Ey+H
1wf/RIPBtwhsuLI224stYcbzkJ08tRoayokmGlxy4V+7w0pS3B8Hn8UfcC1c91lB9xMQc3SSA8CB
G3FFo9EekVBD/eHx0OkGyBzDYr6zR0xCjiUWXgyzse0uFO0kNKlUT0tC9uCO8PqR83Nejpo9mN09
UbZS4fUctvMyUgdrDXzqqitob/tRVjd6qjWXUthBgHhmGyuX5ET3kXMeAwx+UsvjQAlAS3ZVu8q0
PmEI3ZbtnWcdkiKI5r4tn7Io8wuQs1xz7gG3RD9STIgu+AiL7nK4WLWRgFcKzGsj9AWaOC/PCeiN
ZsBan4mYBQczyADAMHkjnQByzi22RN/27cKp1uROUw==
=RYNS
-----END PGP SIGNATURE-----

--------------o0kwwZd5WhI0vqwOQJ85oWOv--


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 09:14:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 09:14:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311484.528702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niBq3-00041T-JF; Sat, 23 Apr 2022 09:13:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311484.528702; Sat, 23 Apr 2022 09:13:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niBq3-00041M-Fl; Sat, 23 Apr 2022 09:13:59 +0000
Received: by outflank-mailman (input) for mailman id 311484;
 Sat, 23 Apr 2022 09:13:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niBq3-00041C-0Q; Sat, 23 Apr 2022 09:13:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niBq2-0006MZ-Th; Sat, 23 Apr 2022 09:13:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niBq2-0007NL-7I; Sat, 23 Apr 2022 09:13:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niBq2-0000Iv-6p; Sat, 23 Apr 2022 09:13:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GpH8fTRCN+E47qepmyORTzrm9hLsBAXabXrPzEgJw8k=; b=w4nX6qYdqDLHkf5/l+6RydDhPE
	8lrDj98+jSr5Y8OFH2PGDcQvPxQkGaS8KBDn3wNhvH4FGMBWtI3Y7IyBnBdv+eUq4wf0ZCQIRSocM
	9tC4S68IzC7kjBTG2KyxzRhrPuMBsLxry98jAVtiirl5caYWloeW9yvZI6kNYctSgFAE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169642-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169642: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 09:13:58 +0000

flight 169642 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169642/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  567 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 10:09:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 10:09:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311503.528713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niChq-0001yK-SS; Sat, 23 Apr 2022 10:09:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311503.528713; Sat, 23 Apr 2022 10:09:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niChq-0001yD-Nn; Sat, 23 Apr 2022 10:09:34 +0000
Received: by outflank-mailman (input) for mailman id 311503;
 Sat, 23 Apr 2022 10:09:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niChp-0001y3-5z; Sat, 23 Apr 2022 10:09:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niChp-0007Kd-1J; Sat, 23 Apr 2022 10:09:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niCho-0000Xm-J9; Sat, 23 Apr 2022 10:09:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niCho-0005sm-Ie; Sat, 23 Apr 2022 10:09:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0nnmcI/bFfw6SzUh51BlSRrwHRCVfnX9BIf/vv5Lae0=; b=G0SPrZx1KWELSE+kuUgmSv+ifV
	o03OKFJIh/A7yUCKs/KxqtWB1PAjiCktemyv+G63vH90dKAOdhBLi1CRjP2aogbellllp4DpMxGOd
	8IhB1hqzLJva4d9ej97CIWfm/lu5M+r1g50AJPE8r/prO7JOYr2B2YjTuNMukGmuhAIY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169643-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169643: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 10:09:32 +0000

flight 169643 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169643/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   53 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  568 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 11:00:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 11:00:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311521.528723 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niDUe-0008Gw-Pm; Sat, 23 Apr 2022 11:00:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311521.528723; Sat, 23 Apr 2022 11:00:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niDUe-0008Gp-Lr; Sat, 23 Apr 2022 11:00:00 +0000
Received: by outflank-mailman (input) for mailman id 311521;
 Sat, 23 Apr 2022 10:59:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niDUd-0008Gf-Nt; Sat, 23 Apr 2022 10:59:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niDUd-00088q-LN; Sat, 23 Apr 2022 10:59:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niDUd-0001xy-AS; Sat, 23 Apr 2022 10:59:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niDUd-0006xH-9z; Sat, 23 Apr 2022 10:59:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=E0wmlgDjPuYWNMgnNq4YdVaI089/aSNnlak9f9JwVJ4=; b=WlTiUb9y5LO9jZWPLSAhSuZRst
	KnlaGJ8Qvkg4gpbpED+PpiDbON+ZXoQGMW3uTAErBIHKdcG23rTow7lexSecEfyLaIACBg/sy3+Au
	I04c6RCC1REaNthoiHCTojwzKxOAVOeAmfwzJ4iSRPCp+Eb3LhykS+K08pItDqs6xPLI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169644-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169644: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 10:59:59 +0000

flight 169644 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169644/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  569 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 11:39:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 11:39:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311531.528735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niE70-0004v1-Mq; Sat, 23 Apr 2022 11:39:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311531.528735; Sat, 23 Apr 2022 11:39:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niE70-0004uu-Jq; Sat, 23 Apr 2022 11:39:38 +0000
Received: by outflank-mailman (input) for mailman id 311531;
 Sat, 23 Apr 2022 11:39:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niE6z-0004uk-HL; Sat, 23 Apr 2022 11:39:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niE6z-0000Nq-AF; Sat, 23 Apr 2022 11:39:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niE6y-00030c-VV; Sat, 23 Apr 2022 11:39:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niE6y-0007QU-V1; Sat, 23 Apr 2022 11:39:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=crPP9VFy7ED7UMtECWTNCLukhHq26Saoj1WL9phQwfA=; b=DVsh4rLXMza4zQiRQn3E+HNTnD
	3JZRi4J1JNVnn2+rLxipDvksgNLuhzZyLdD8uUEcB/GbyqCMUsBb4DNVd51eiYmpl2/xF5xTkuLHi
	zgAIJEFOj3Y0esGEqU+siETn+vhK4Ra4/zX2Xp48FJ5YAamIoZSjPhWhiHcK/oo1g7Yw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169646-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169646: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 11:39:36 +0000

flight 169646 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169646/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  570 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 12:07:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 12:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311544.528746 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niEXf-0000e6-0r; Sat, 23 Apr 2022 12:07:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311544.528746; Sat, 23 Apr 2022 12:07:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niEXe-0000dz-Te; Sat, 23 Apr 2022 12:07:10 +0000
Received: by outflank-mailman (input) for mailman id 311544;
 Sat, 23 Apr 2022 12:07:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niEXd-0000dp-CS; Sat, 23 Apr 2022 12:07:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niEXd-0000qx-6m; Sat, 23 Apr 2022 12:07:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niEXc-0003mG-Qf; Sat, 23 Apr 2022 12:07:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niEXc-0003xa-QA; Sat, 23 Apr 2022 12:07:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TCsOSsadt1zLdzUQNr4SdYxGvmUodCKT5qXxHPe5e/8=; b=UbwyDcbV6q6VaGZfc0dsHJCuxo
	U6lNnFkEqoCMYgq/6UcDa1goCjaD6TmqJKepdgb3orKHbWj0QOkk7ain4+0KnobGyLwfM8KqqazqN
	/zQ9brFoqPARkQe4bqXZBRN6aLZp9Maae6mlaIzNG9w3JCJHqZ34/n5VQQSvwzX86oE0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169635-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169635: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
X-Osstest-Versions-That:
    xen=43f3d51139178a03823b061482c674e15ce3d49c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 12:07:08 +0000

flight 169635 xen-unstable real [real]
flight 169645 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169635/
http://logs.test-lab.xenproject.org/osstest/logs/169645/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-arndale   8 xen-boot            fail pass in 169645-retest
 test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail pass in 169645-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 169645 never pass
 test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 169645 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169624
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169624
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169624
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169624
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169624
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169624
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169624
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169624
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169624
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169624
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169624
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169624
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08
baseline version:
 xen                  43f3d51139178a03823b061482c674e15ce3d49c

Last test of basis   169624  2022-04-22 14:09:48 Z    0 days
Testing same since   169635  2022-04-23 02:05:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bobby Eshleman <bobby.eshleman@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   43f3d51139..2419a159fb  2419a159fb943c24a6f2439604b9fdb1478fcd08 -> master


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 12:09:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 12:09:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311552.528757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niEZl-0001EP-DL; Sat, 23 Apr 2022 12:09:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311552.528757; Sat, 23 Apr 2022 12:09:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niEZl-0001EI-AO; Sat, 23 Apr 2022 12:09:21 +0000
Received: by outflank-mailman (input) for mailman id 311552;
 Sat, 23 Apr 2022 12:09:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niEZk-0001E8-IP; Sat, 23 Apr 2022 12:09:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niEZk-0000uI-He; Sat, 23 Apr 2022 12:09:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niEZk-0003oN-3j; Sat, 23 Apr 2022 12:09:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niEZk-0007MT-3D; Sat, 23 Apr 2022 12:09:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=p4LngTPyaSxLM9Qo/iswjRbPPZunD/miH3yJpiE2TOs=; b=0DgqzWMQzKpYtPxEsWituNhw0y
	08ZOb0RpscssuYYT4bCJzZe0BYeiCJLwMKkQmEwGRE04B7Ttb7iyp4X9aBlUHQfXHKkYjDNuWQHof
	gDEsqvENKQu3YnKTyymk2apadhSdx+N/3sVFnSZEKwvEb7kM77qwG30jkz2iJWuVFPx4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169647-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169647: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 12:09:20 +0000

flight 169647 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169647/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  571 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 13:00:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 13:00:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311585.528836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFNK-0000dw-9Y; Sat, 23 Apr 2022 13:00:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311585.528836; Sat, 23 Apr 2022 13:00:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFNK-0000dp-5t; Sat, 23 Apr 2022 13:00:34 +0000
Received: by outflank-mailman (input) for mailman id 311585;
 Sat, 23 Apr 2022 13:00:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFNI-0000df-UR; Sat, 23 Apr 2022 13:00:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFNI-0001px-Rz; Sat, 23 Apr 2022 13:00:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFNI-0004xq-Fm; Sat, 23 Apr 2022 13:00:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niFNI-0005ac-FL; Sat, 23 Apr 2022 13:00:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QHu2+NDxsyrOJZ4Brv8rsrGA4WED1C/BQNs48LQB68I=; b=ixVSOn4r4o39QeaqaHpe2/EOe9
	ak63T6DutbOwvPN2rpdiw3W6itbPRmrvMYdxLq/5zjmhqUrXYOBceyMlDIXL8Bq0ToUOaLibfK2l3
	L7/LJRnav2w6AsJi6onL84TCBYiX2nT3vI0IWTaQttDoj4znoTwJMFtHiPcjUYsirbDc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169648-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169648: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 13:00:32 +0000

flight 169648 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169648/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  572 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 13:08:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 13:08:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311596.528846 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFUf-0001Zs-2V; Sat, 23 Apr 2022 13:08:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311596.528846; Sat, 23 Apr 2022 13:08:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFUe-0001Zl-Vj; Sat, 23 Apr 2022 13:08:08 +0000
Received: by outflank-mailman (input) for mailman id 311596;
 Sat, 23 Apr 2022 13:08:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JeyS=VB=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1niFUe-0001Zf-DG
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 13:08:08 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6adc7278-c306-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 15:08:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EBE1F1F388;
 Sat, 23 Apr 2022 13:08:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B5EE813AD8;
 Sat, 23 Apr 2022 13:08:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id n3tYKzb6Y2LfdQAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 23 Apr 2022 13:08:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6adc7278-c306-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650719286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=xWfm7BakUoeVsVVbr6mNUxRV4SUG2JRam42wgGqtYIc=;
	b=lLi+d9yy5DdQq1TLM/gtOzFoULe+auo+MlB7Eb/Vz/ccN+lu+y3HD2Z51wKWEk1aYNuVUf
	BumjDvrMkoyaSoeefg9FcpWDUueGpX5j4RX1D5iHPWNYKIjD05Af3tQo8xPyLRKERrjtmb
	o+y0XW1Qk1LHhO8GyB6nelsfitmTUgI=
From: Juergen Gross <jgross@suse.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com
Subject: [GIT PULL] xen: branch for v5.18-rc4
Date: Sat, 23 Apr 2022 15:08:06 +0200
Message-Id: <20220423130806.15699-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Linus,

Please git pull the following tag:

 git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.18-rc4-tag

xen: branch for v5.18-rc4

It contains a simple cleanup patch and a refcount fix for Xen on Arm.

Thanks.

Juergen

 arch/arm/xen/enlighten.c | 9 +++++++--
 drivers/xen/gntalloc.c   | 4 ++--
 2 files changed, 9 insertions(+), 4 deletions(-)

Alaa Mohamed (1):
      xen: Convert kmap() to kmap_local_page()

Miaoqian Lin (1):
      arm/xen: Fix some refcount leaks


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 13:13:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 13:13:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311602.528858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFZw-0002z0-R5; Sat, 23 Apr 2022 13:13:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311602.528858; Sat, 23 Apr 2022 13:13:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFZw-0002yt-Nu; Sat, 23 Apr 2022 13:13:36 +0000
Received: by outflank-mailman (input) for mailman id 311602;
 Sat, 23 Apr 2022 13:13:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFZv-0002yj-Tg; Sat, 23 Apr 2022 13:13:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFZv-00024P-My; Sat, 23 Apr 2022 13:13:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFZv-0005Jz-89; Sat, 23 Apr 2022 13:13:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niFZv-0000Qx-7i; Sat, 23 Apr 2022 13:13:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GgRvbJ1CFqv1l92LtkwydQiIwmLo+Y8wsGvaNgeJq0s=; b=NbBdSanzMnd5JhTcKUKgJspSsJ
	z1oWFOeHqnfSG4RNK7H9Cm+EAD7A9hqQ+GVp8Zl99JlJoUy9jtPfo9uu6qANX1AoLhpwS84BOIVlM
	F4M7HMTOZ9EPB8essq9Cruj3C7RLH6qCfwsjDybQyEbxU/1JIFOPhUbstkrX/JovWiSc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169640-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169640: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=de0a50833f91ad934d5492125b2d636c86a87140
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 13:13:35 +0000

flight 169640 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169640/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              de0a50833f91ad934d5492125b2d636c86a87140
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  652 days
Failing since        151818  2020-07-11 04:18:52 Z  651 days  633 attempts
Testing same since   169640  2022-04-23 04:18:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 105272 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 13:34:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 13:34:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311613.528869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFuU-00068o-Ku; Sat, 23 Apr 2022 13:34:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311613.528869; Sat, 23 Apr 2022 13:34:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFuU-00068h-HV; Sat, 23 Apr 2022 13:34:50 +0000
Received: by outflank-mailman (input) for mailman id 311613;
 Sat, 23 Apr 2022 13:34:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFuS-00068W-UN; Sat, 23 Apr 2022 13:34:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFuS-0002Oe-Q8; Sat, 23 Apr 2022 13:34:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFuS-0005qP-7j; Sat, 23 Apr 2022 13:34:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niFuS-0006W9-7I; Sat, 23 Apr 2022 13:34:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=y9WDD+6TvhQ2OFEsHhNYqVTeOdrxR288QarUL+i01iw=; b=wqcjj2KvLKb+Ns2kfYnaGOVm0k
	6arR8n3i0Yn4ItYu/UTeURP7uXlwc1a5MQkhxugW9xd8vNtnFhi5YyQ8HChN0w9NYa66nLOFZYJaW
	V3faBtAkgF90L1n7F2K2Dcl9aKptSiiaeeSom2P9cp4oqpgvUPbOM0zPY1/xdbxVzD6U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169638-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169638: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=c00c5e1d157bec0ef0b0b59aa5482eb8dc7e8e49
X-Osstest-Versions-That:
    linux=d569e86915b7f2f9795588591c8d5ea0b66481cb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 13:34:48 +0000

flight 169638 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169638/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169627
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169627
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169627
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169627
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169627
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169627
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169627
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169627
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                c00c5e1d157bec0ef0b0b59aa5482eb8dc7e8e49
baseline version:
 linux                d569e86915b7f2f9795588591c8d5ea0b66481cb

Last test of basis   169627  2022-04-22 16:11:32 Z    0 days
Testing same since   169638  2022-04-23 03:15:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ahmad Fatoum <a.fatoum@pengutronix.de>
  Ajye Huang <ajye.huang@gmail.com>
  Ajye Huang <ajye_huang@compal.corp-partner.google.com>
  Aleksandr Nogikh <nogikh@google.com>
  Alistair Popple <apopple@nvidia.com>
  Amit Pundir <amit.pundir@linaro.org>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Chi <andy.chi@canonical.com>
  Anup Patel <anup@brainfault.org>
  Anup Patel <apatel@ventanamicro.com>
  Atish Patra <atishp@rivosinc.com>
  Chao Song <chao.song@linux.intel.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christian Brauner <brauner@kernel.org>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Darrick J. Wong <djwong@kernel.org>
  Fabiano Rosas <farosas@linux.ibm.com>
  Gongjun Song <gongjun.song@intel.com>
  Hans de Goede <hdegoede@redhat.com>
  Haowen Bai <baihaowen@meizu.com>
  Heiner Kallweit <hkallweit1@gmail.com>
  Hui Wang <hui.wang@canonical.com>
  Ivan Babrou <ivan@cloudflare.com>
  Jason Gunthorpe <jgg@nvidia.com>
  Joel Savitz <jsavitz@redhat.com>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Ken Kurematsu <k.kurematsu@nskint.co.jp>
  Like Xu <likexu@tencent.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Lucas De Marchi <lucas.demarchi@intel.com>
  lukeluk498@gmail.com Link:
  Marco Elver <elver@google.com>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Maurizio Avogadro <mavoga@gmail.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Miaoqian Lin <linmq006@gmail.com>
  Michal Hocko <mhocko@suse.com>
  Miles Chen <miles.chen@mediatek.com>
  Mingwei Zhang <mizhang@google.com>
  Muchun Song <songmuchun@bytedance.com>
  Nadav Amit <namit@vmware.com>
  Naoya Horiguchi <naoya.horiguchi@nec.com>
  Nathan Chancellor <nathan@kernel.org>
  Nicholas Piggin <npiggin@gmail.com>
  Nico Pache <npache@redhat.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Paulo Alcantara <pc@cjr.nz>
  Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
  Peter Xu <peterx@redhat.com>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Richard Fitzgerald <rf@opensource.cirrus.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Samuel Čavoj <samuel@cavoj.net>
  Sean Christopherson <seanjc@google.com>
  Shakeel Butt <shakeelb@google.com>
  Shengjiu Wang <shengjiu.wang@gmail.com>
  Sidhartha Kumar <sidhartha.kumar@oracle.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Steve French <stfrench@microsoft.com>
  syzbot+cf4cf13056f85dec2c40@syzkaller.appspotmail.com
  Tadeusz Struk <tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Theodore Ts'o <tytso@mit.edu>
  Thomas Gleixner <tglx@linutronix.de>
  Thomas Huth <thuth@redhat.com>
  Tim Crawford <tcrawford@system76.com>
  Tom Rix <trix@redhat.com>
  Vincenzo Frascino <vincenzo.frascino@arm.com>
  Wang Jianjian <wangjianjian3@huawei.com>
  wangjianjian (C) <wangjianjian3@huawei.com>
  Wanpeng Li <wanpengli@tencent.com>
  Will Deacon <will@kernel.org>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>
  Xu Yu <xuyu@linux.alibaba.com>
  Yanan Wang <wangyanan55@huawei.com>
  Ye Bin <yebin10@huawei.com>
  Yu Liao <liaoyu15@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   d569e86915b7..c00c5e1d157b  c00c5e1d157bec0ef0b0b59aa5482eb8dc7e8e49 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 13:39:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 13:39:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311622.528879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFzB-0006pt-DM; Sat, 23 Apr 2022 13:39:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311622.528879; Sat, 23 Apr 2022 13:39:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niFzB-0006pm-AX; Sat, 23 Apr 2022 13:39:41 +0000
Received: by outflank-mailman (input) for mailman id 311622;
 Sat, 23 Apr 2022 13:39:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFz9-0006pc-N3; Sat, 23 Apr 2022 13:39:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFz9-0002To-M1; Sat, 23 Apr 2022 13:39:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niFz9-0005x5-A3; Sat, 23 Apr 2022 13:39:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niFz9-0005ch-9b; Sat, 23 Apr 2022 13:39:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Lo4n0eerhpl37ewQbsLDVTpZPrUFjeKNZ8obheSOXf4=; b=lwBJ9TcAGco5UauyVX7eUai+Mi
	CWnILtwOkbiTn39XfKEyz9gfQYj0tA6KkOjTzR+ofRey2OTJkcqpPgDTrdvjZ/vNy0AD1LIAoHZyn
	C5geyNTgyo5dAiaVl0IOn0+XUcsbkJDnAcqmoSqFZixcwC4wGJPH1OT76TU33X68ha6U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169649-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169649: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 13:39:39 +0000

flight 169649 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169649/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  573 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 14:11:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 14:11:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311634.528891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niGTZ-0003Gy-RW; Sat, 23 Apr 2022 14:11:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311634.528891; Sat, 23 Apr 2022 14:11:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niGTZ-0003Gr-OK; Sat, 23 Apr 2022 14:11:05 +0000
Received: by outflank-mailman (input) for mailman id 311634;
 Sat, 23 Apr 2022 14:11:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niGTZ-0003Gh-2E; Sat, 23 Apr 2022 14:11:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niGTY-00035V-VF; Sat, 23 Apr 2022 14:11:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niGTY-0006d7-Jg; Sat, 23 Apr 2022 14:11:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niGTY-0005zO-JG; Sat, 23 Apr 2022 14:11:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ExFmXWd33jw3x3ihiXJ/3hzIpOx/zae+9KnfpD1HSHs=; b=Qwevg2sj+G9o1/9RSMTkLsfQC7
	pA1MNg7OPTxSwC+xBLnckERVbtFecnYGe2U7Z7BpqaVnvDckr41TycftwsEW9zgZ4rgehrgkvrDey
	E4CZkRxNmZwDWo6x0zJXAvAQunpmm35YPPyKywLtaaj51DziACmACPiHwVgM3UJK65xg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169650-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169650: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 14:11:04 +0000

flight 169650 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169650/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  574 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 14:35:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 14:35:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311643.528902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niGrO-0006Af-RW; Sat, 23 Apr 2022 14:35:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311643.528902; Sat, 23 Apr 2022 14:35:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niGrO-0006AY-O0; Sat, 23 Apr 2022 14:35:42 +0000
Received: by outflank-mailman (input) for mailman id 311643;
 Sat, 23 Apr 2022 14:35:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hJIN=VB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1niGrN-0006AS-AR
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 14:35:41 +0000
Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com
 [2a00:1450:4864:20::131])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a5c32397-c312-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 16:35:40 +0200 (CEST)
Received: by mail-lf1-x131.google.com with SMTP id w19so18949089lfu.11
 for <xen-devel@lists.xenproject.org>; Sat, 23 Apr 2022 07:35:40 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 k10-20020a19560a000000b0046d1707fcbdsm640495lfb.215.2022.04.23.07.35.37
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 23 Apr 2022 07:35:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5c32397-c312-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=5Ob5FZ3XWHH7ndiX9e02UPLlc8ptKYdQZQQb2q10kFk=;
        b=edcQjFzK13CxlrO3DRi39U1HLX1VBiZdMToLxtPriW5w54rke5iEMAjcSbz0qLKiU1
         6Dg/+t7jlWN4zLOE4R7gc+Oiehyx44/fBegjF9CUPZTdazhsEq5kmlyBBIDrFcpJ2UXh
         39lAPieblL9SemJymxB3+VitLdVV4ID+j2PN+nuGr61uKUGz8IVRPkA+fobqsdBAqXKq
         ApWZOKdhVIcgtmhqGwlNCdGSukJgvhZDorgcmTlkv0mfPzZ/PfSWiA/hCgs5Wv2oL+vK
         XJZN28Yak1op0o0AkGamHUIANzbptaiH+ktbXi6pl22teiG63KGXxIYyM50hdzwzZcwU
         6EXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=5Ob5FZ3XWHH7ndiX9e02UPLlc8ptKYdQZQQb2q10kFk=;
        b=nfsLed2CNQT4bW/7ImaZ9jJlMRtCiVF8IhpokrScogc+XWQ7wmyuoWJd8tqIJqG8vs
         x9qXscoP0+Vv4Et4KNHl5BU95J1WLyRbzkAPzaEnf1cmDOnLAx0WR4EgiZ42qaXbyTAl
         ozv36q7UADdAb4i/dbOcBpFDY3fOH0OjTcEZr6Y/7LDoVRe7RVWoXllHVGHVy5Nm/0bd
         gnzoG7UBM9XomyOMW6cnjaqITTeGa5pbzSlHeHg1eBRklgoqR9P//VftvBrKuk5v80dX
         +ag+BuQ9+DCLIVn/sVmPcTcUOJE00a8aobmHuc2PohCe/DQjlXK0cK/ED/GedI8Ib8I5
         gywg==
X-Gm-Message-State: AOAM531u4ZeJzFsp8ox7yYCBSg0Hjet+aKqntpC9dyI6ofnf7mp9QTP6
	tBjp2bZaa5Df6UneYGabsek=
X-Google-Smtp-Source: ABdhPJzuBm8Fq2ksLNZubEsggwEds0YNor4simf+758e/Wch36unqYhiwGrQiA/w92oNFg+B4tk+9w==
X-Received: by 2002:a05:6512:2348:b0:471:92ac:3bfd with SMTP id p8-20020a056512234800b0047192ac3bfdmr6525788lfu.199.1650724539295;
        Sat, 23 Apr 2022 07:35:39 -0700 (PDT)
Subject: Re: [PATCH V1 1/6] arm/xen: Introduce xen_setup_dma_ops()
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Russell King <linux@armlinux.org.uk>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Logan Gunthorpe <logang@deltatee.com>,
 David Hildenbrand <david@redhat.com>,
 Martin Oliveira <martin.oliveira@eideticom.com>,
 Kees Cook <keescook@chromium.org>,
 Jean-Philippe Brucker <jean-philippe@linaro.org>,
 Julien Grall <julien@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>,
 Christoph Hellwig <hch@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-2-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204221509220.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <a1112ea4-6eb9-f4ec-745d-e28c41fd1930@gmail.com>
Date: Sat, 23 Apr 2022 17:35:37 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204221509220.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 23.04.22 01:59, Stefano Stabellini wrote:


Hello Stefano


> On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> This patch introduces new helper and places it in new header.
>> The helper's purpose is to assign any Xen specific DMA ops in
>> a single place. For now, we deal with xen-swiotlb DMA ops only.
>> The one of the subsequent commits in current series will add
>> xen-grant DMA ops case.
>>
>> Also re-use the xen_swiotlb_detect() check on Arm32.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


Thanks!


checkpatch.pl suggests adding missing SPDX-License-Identifier to 
Arm/Arm64's xen-ops.h

I will retain your R-b tag after making this change. Please let me know 
if you think otherwise.



>> ---
>> Changes RFC -> V1:
>>     - update commit description
>>     - move commit to the beginning of the series
>>     - move #ifdef CONFIG_XEN from dma-mapping.c to xen-ops.h
>> ---
>>   arch/arm/include/asm/xen/xen-ops.h   |  1 +
>>   arch/arm/mm/dma-mapping.c            |  7 ++-----
>>   arch/arm64/include/asm/xen/xen-ops.h |  1 +
>>   arch/arm64/mm/dma-mapping.c          |  7 ++-----
>>   include/xen/arm/xen-ops.h            | 15 +++++++++++++++
>>   5 files changed, 21 insertions(+), 10 deletions(-)
>>   create mode 100644 arch/arm/include/asm/xen/xen-ops.h
>>   create mode 100644 arch/arm64/include/asm/xen/xen-ops.h
>>   create mode 100644 include/xen/arm/xen-ops.h
>>
>> diff --git a/arch/arm/include/asm/xen/xen-ops.h b/arch/arm/include/asm/xen/xen-ops.h
>> new file mode 100644
>> index 00000000..8d2fa24
>> --- /dev/null
>> +++ b/arch/arm/include/asm/xen/xen-ops.h
>> @@ -0,0 +1 @@
>> +#include <xen/arm/xen-ops.h>
>> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
>> index 82ffac6..059cce0 100644
>> --- a/arch/arm/mm/dma-mapping.c
>> +++ b/arch/arm/mm/dma-mapping.c
>> @@ -33,7 +33,7 @@
>>   #include <asm/dma-iommu.h>
>>   #include <asm/mach/map.h>
>>   #include <asm/system_info.h>
>> -#include <xen/swiotlb-xen.h>
>> +#include <asm/xen/xen-ops.h>
>>   
>>   #include "dma.h"
>>   #include "mm.h"
>> @@ -2287,10 +2287,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>>   
>>   	set_dma_ops(dev, dma_ops);
>>   
>> -#ifdef CONFIG_XEN
>> -	if (xen_initial_domain())
>> -		dev->dma_ops = &xen_swiotlb_dma_ops;
>> -#endif
>> +	xen_setup_dma_ops(dev);
>>   	dev->archdata.dma_ops_setup = true;
>>   }
>>   
>> diff --git a/arch/arm64/include/asm/xen/xen-ops.h b/arch/arm64/include/asm/xen/xen-ops.h
>> new file mode 100644
>> index 00000000..8d2fa24
>> --- /dev/null
>> +++ b/arch/arm64/include/asm/xen/xen-ops.h
>> @@ -0,0 +1 @@
>> +#include <xen/arm/xen-ops.h>
>> diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
>> index 6719f9e..6099c81 100644
>> --- a/arch/arm64/mm/dma-mapping.c
>> +++ b/arch/arm64/mm/dma-mapping.c
>> @@ -9,9 +9,9 @@
>>   #include <linux/dma-map-ops.h>
>>   #include <linux/dma-iommu.h>
>>   #include <xen/xen.h>
>> -#include <xen/swiotlb-xen.h>
>>   
>>   #include <asm/cacheflush.h>
>> +#include <asm/xen/xen-ops.h>
>>   
>>   void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
>>   		enum dma_data_direction dir)
>> @@ -52,8 +52,5 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>>   	if (iommu)
>>   		iommu_setup_dma_ops(dev, dma_base, dma_base + size - 1);
>>   
>> -#ifdef CONFIG_XEN
>> -	if (xen_swiotlb_detect())
>> -		dev->dma_ops = &xen_swiotlb_dma_ops;
>> -#endif
>> +	xen_setup_dma_ops(dev);
>>   }
>> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
>> new file mode 100644
>> index 00000000..288deb1
>> --- /dev/null
>> +++ b/include/xen/arm/xen-ops.h
>> @@ -0,0 +1,15 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +#ifndef _ASM_ARM_XEN_OPS_H
>> +#define _ASM_ARM_XEN_OPS_H
>> +
>> +#include <xen/swiotlb-xen.h>
>> +
>> +static inline void xen_setup_dma_ops(struct device *dev)
>> +{
>> +#ifdef CONFIG_XEN
>> +	if (xen_swiotlb_detect())
>> +		dev->dma_ops = &xen_swiotlb_dma_ops;
>> +#endif
>> +}
>> +
>> +#endif /* _ASM_ARM_XEN_OPS_H */
>> -- 
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sat Apr 23 14:38:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 14:38:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311654.528912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niGtc-0006yR-6z; Sat, 23 Apr 2022 14:38:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311654.528912; Sat, 23 Apr 2022 14:38:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niGtc-0006yK-45; Sat, 23 Apr 2022 14:38:00 +0000
Received: by outflank-mailman (input) for mailman id 311654;
 Sat, 23 Apr 2022 14:37:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hJIN=VB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1niGtb-0006xy-8P
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 14:37:59 +0000
Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com
 [2a00:1450:4864:20::131])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f827e9a6-c312-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 16:37:58 +0200 (CEST)
Received: by mail-lf1-x131.google.com with SMTP id y32so18971325lfa.6
 for <xen-devel@lists.xenproject.org>; Sat, 23 Apr 2022 07:37:58 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 k11-20020a196f0b000000b00471c56b7a3dsm641075lfc.74.2022.04.23.07.37.56
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 23 Apr 2022 07:37:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f827e9a6-c312-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=9Q3pZjqL2YRbxMi3ZEZPC+BgttCsWqeK314Feyp4SQ4=;
        b=O6lRTdmyP9SYSA3U8hfLl6p8PcytluSsbHwEFXxwQ+ubIxxSVZKbp9ABI4a104ybmE
         4B0KpBf9zDgnV1i4oYkJNepeB9/rfyra7k5PI9DZqHke1VwN6482HV8XrLngsjtfpsFr
         6bM8w36eLRa4VwfIxnHVhQfOZg/AaPvpoW8tB1wDHi0T7pELIli9N4UTO8TGcKuvFaKm
         eOZaalv2Z8+00j28i8eI7dMT0V4YIeOFmc8x7xswIRAT1Q9HRGUBVnLTfkM6C5KtYtu2
         I9VW/XbIJHjaJqcC0s3p2b54l8r+mGP1Bv8UyPsSSwS8lK/HSTCCWDhUQlDqrMwBzC0h
         BFLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=9Q3pZjqL2YRbxMi3ZEZPC+BgttCsWqeK314Feyp4SQ4=;
        b=BV5YHpq9TpzgMgYvklOwlqJyhoBfpzV89lzM+SCzaLlHSOOFaJ3HSMSV2osMXl+gAG
         svYvsjUScQjFKWb3PYuxT+mwJisgKOTnWh1m9Lz1zlTPC4aIpmY47hlNed63wGA8R5F7
         9Nr2fkiUFtadj6u67c6Sr1mw+6m/P09mDkKGEj8A8Bsf3ueW1czLlGy+rlWKbBpCIV36
         T71G4evZOqFekquL7RBhRFhJwjneWkUK5v3njnkO8Ideak2NykWL8xuwNVpxdwKBzE2v
         kp2CdgABHnWrwB9JTj4pRN70TeEYzSteweC8ltqy1Z8tKrIECgH9zychkXMEthcCm547
         N/CQ==
X-Gm-Message-State: AOAM533tZY7cspuSUH+OXs8xYfaEM0UNZMxrbz4xJhp2ooGo0po28uf9
	8KJuS+ozPwmUrCXOEj224mU=
X-Google-Smtp-Source: ABdhPJx8PYPHNf3hIYDk6xxcUZ5Cz4AjHRjZCng72eHk60GDl8rPACcXENIApaJQbCkMeAProiKKeA==
X-Received: by 2002:a05:6512:150f:b0:45d:ccac:c43c with SMTP id bq15-20020a056512150f00b0045dccacc43cmr7231892lfb.604.1650724677772;
        Sat, 23 Apr 2022 07:37:57 -0700 (PDT)
Subject: Re: [PATCH V1 4/6] dt-bindings: Add xen, dev-domid property
 description for xen-grant DMA ops
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Jason Wang <jasowang@redhat.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Christoph Hellwig <hch@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-5-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204221527500.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <638a5b09-ce9e-ab7e-0a5e-d81afe851cc1@gmail.com>
Date: Sat, 23 Apr 2022 17:37:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204221527500.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 23.04.22 02:00, Stefano Stabellini wrote:

Hello Stefano

> On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Introduce Xen specific binding for the virtualized device (e.g. virtio)
>> to be used by Xen grant DMA-mapping layer in the subsequent commit.
>>
>> This binding indicates that Xen grant mappings scheme needs to be
>> enabled for the device which DT node contains that property and specifies
>> the ID of Xen domain where the corresponding backend resides. The ID
>> (domid) is used as an argument to the grant mapping APIs.
>>
>> This is needed for the option to restrict memory access using Xen grant
>> mappings to work which primary goal is to enable using virtio devices
>> in Xen guests.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Looks OK to me. Just a couple of grammar improvements below. Aside from
> those, I have no further comments.

thank you, I agree with proposed comments, will update



>
>
>> ---
>> Changes RFC -> V1:
>>     - update commit subject/description and text in description
>>     - move to devicetree/bindings/arm/
>> ---
>>   .../devicetree/bindings/arm/xen,dev-domid.yaml     | 37 ++++++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
>> new file mode 100644
>> index 00000000..ef0f747
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml
>> @@ -0,0 +1,37 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Xen specific binding for the virtualized device (e.g. virtio)
> NIT: Xen specific binding for virtualized devices (e.g. virtio)
>
>
>> +maintainers:
>> +  - Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> +
>> +select: true
>> +
>> +description:
>> +  This binding indicates that Xen grant mappings scheme needs to be enabled
>> +  for that device and specifies the ID of Xen domain where the corresponding
>> +  device (backend) resides. This is needed for the option to restrict memory
>> +  access using Xen grant mappings to work.
> NIT:
>
> This binding indicates that Xen grant mappings need to be enabled for
> the device, and it specifies the ID of the domain where the
> corresponding device (backend) resides. The property is required to
> restrict memory access using Xen grant mappings.
>
>
>> +properties:
>> +  xen,dev-domid:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description:
>> +      The domid (domain ID) of the domain where the device (backend) is running.
>> +
>> +additionalProperties: true
>> +
>> +examples:
>> +  - |
>> +    virtio_block@3000 {
>> +            compatible = "virtio,mmio";
>> +            reg = <0x3000 0x100>;
>> +            interrupts = <41>;
>> +
>> +            /* The device is located in Xen domain with ID 1 */
>> +            xen,dev-domid = <1>;
>> +    };

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sat Apr 23 15:12:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 15:12:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311670.528924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niHQk-0003bz-1x; Sat, 23 Apr 2022 15:12:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311670.528924; Sat, 23 Apr 2022 15:12:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niHQj-0003bs-VF; Sat, 23 Apr 2022 15:12:13 +0000
Received: by outflank-mailman (input) for mailman id 311670;
 Sat, 23 Apr 2022 15:12:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niHQi-0003bi-VM; Sat, 23 Apr 2022 15:12:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niHQi-0004Aa-Tr; Sat, 23 Apr 2022 15:12:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niHQi-0007xw-Kb; Sat, 23 Apr 2022 15:12:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niHQi-0003TZ-K8; Sat, 23 Apr 2022 15:12:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OFnri8+I2WI0TE3MvUXw/XqzmtRPOfGPPSE0Ot7J6BQ=; b=5xga3cek3J6CYy0fwdQdzENxak
	XW3iopkcf9g7qqL0Bnu8ygDK5t2mzdmmYSxYbyCJU6oSfUEXTsOAVBqra+9bTP5GokWDdtZTqA2/X
	F3n/DxNJ7+XksiGxlCkFg5mGCyKaCf//jesEgDWwuwd1xIG7Z3CLvDehR8Y9Z24BPmDM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169651-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169651: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 15:12:12 +0000

flight 169651 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169651/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  575 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 15:23:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 15:23:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311678.528935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niHbZ-0005Iq-4d; Sat, 23 Apr 2022 15:23:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311678.528935; Sat, 23 Apr 2022 15:23:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niHbZ-0005Ij-1G; Sat, 23 Apr 2022 15:23:25 +0000
Received: by outflank-mailman (input) for mailman id 311678;
 Sat, 23 Apr 2022 15:23:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hJIN=VB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1niHbX-0005Id-3y
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 15:23:23 +0000
Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com
 [2a00:1450:4864:20::22f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4f9de374-c319-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 17:23:22 +0200 (CEST)
Received: by mail-lj1-x22f.google.com with SMTP id bj36so12872341ljb.13
 for <xen-devel@lists.xenproject.org>; Sat, 23 Apr 2022 08:23:22 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 x22-20020a19e016000000b00471f7e4f09asm252577lfg.112.2022.04.23.08.23.20
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 23 Apr 2022 08:23:21 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f9de374-c319-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=IrpG+O4O8YGPLjnEW6ym2q9Ak0YBISr2l1Uzmevi7UU=;
        b=IQIfElwQ6vipgSII8m7fw6jPT7ARLMUo+GYVfI8Knl2qwcFVEEhcFvD8Om4SSjKAx2
         rhHWD/FD4idPYpw6gGmafqjLSO6s5PnKgRub3B+6obIRWzQnvSBJtyJQi3yrabfM/3YH
         nyMF8uDK1IRSsUIm9AaGjRtkUTA84vsuNJIwUvyB4GNP5y1x7sQZT+c8y4qqZ/6mHAet
         nubs7NGVFobqf7TGI1y4TrUGgxgSag+RI8iLIe9SEJTQyV0518eyYpKVLK3gEmGFlfzs
         i97+MmHFuoXsYprc+xZO4DAi1h+VcMtO3Ecc7KkUECH8yT0sSemR7hzD5vvLn3BlyJFZ
         JNuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=IrpG+O4O8YGPLjnEW6ym2q9Ak0YBISr2l1Uzmevi7UU=;
        b=uJvrf0N6PFjm7NIpGA6ndGOV42akXGRGx9oF4cQi7ZDKR7qqvN0AxxXUisZTUsTuJM
         as/q3nHDoDpquoix6CQSgBJy5BuUoGVeNm8sp1sx/Ir98b3EOZVzprUkRf6zB2ykLn9z
         OuFgc0M6nNDYB8fQPFGxyL4A+3xdgrEyYTE3otc3di/x3GPNki9nwvY/CDjsswM3PfQI
         4F4jLkGaSqRvHaCnTmtT35d+PRUdFpWBcDL9RgG/pXq08RLuEvJnhUFFWRhsQXB8z0om
         xeS/A7HNereBb+X9Ybt4uVxP61buytj/APvN7Z5Ip4mO+jQD5adYqdcLmYW3b/2aGTIN
         2BsA==
X-Gm-Message-State: AOAM5328IYiMPqYfrZ6nKSN3MuGSbuRRCF9YIEvlLpmf7gbGyZ4IhSwD
	9IPzBdzsELpQYIRJrMt/i7Q=
X-Google-Smtp-Source: ABdhPJzDEm0kTMzLCkWHC07bFgwWAdrQLhfM8wiRtUiko+APIl1auVipAlGP2engdswsIY79u6w4jg==
X-Received: by 2002:a2e:b537:0:b0:24f:9dc:28a6 with SMTP id z23-20020a2eb537000000b0024f09dc28a6mr637763ljm.509.1650727401488;
        Sat, 23 Apr 2022 08:23:21 -0700 (PDT)
Subject: Re: [PATCH V1 5/6] xen/grant-dma-ops: Retrieve the ID of backend's
 domain for DT devices
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-6-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204221534080.915916@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6ac03d9f-a678-60e9-ca6e-fcbe1aee51d3@gmail.com>
Date: Sat, 23 Apr 2022 18:23:19 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2204221534080.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 23.04.22 02:00, Stefano Stabellini wrote:

Hello Stefano

> On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Use the presence of recently introduced "xen,dev-domid" property
>> in the device node as a clear indicator of enabling Xen grant
>> mappings scheme for that device and read the ID of Xen domain where
>> the corresponding backend resides. The ID (domid) is used as
>> an argument to the Xen grant mapping APIs.
>>
>> Also introduce xen_is_grant_dma_device() to check whether xen-grant
>> DMA ops need to be set for a passed device.
>>
>> Remove the hardcoded domid 0 in xen_grant_setup_dma_ops().
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>> Changes RFC -> V1:
>>     - new patch, split required changes from commit:
>>      "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer"
>>     - update checks in xen_virtio_setup_dma_ops() to only support
>>       DT devices for now
>>     - remove the "virtio,mmio" check from xen_is_virtio_device()
>>     - remane everything according to the new naming scheme:
>>       s/virtio/grant_dma
>> ---
>>   drivers/xen/grant-dma-ops.c | 25 ++++++++++++++++++-------
>>   include/xen/xen-ops.h       |  5 +++++
>>   2 files changed, 23 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
>> index 0e69aa8..70d5d77 100644
>> --- a/drivers/xen/grant-dma-ops.c
>> +++ b/drivers/xen/grant-dma-ops.c
>> @@ -66,11 +66,6 @@ static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
>>    * Such a DMA address is formed by using the grant reference as a frame
>>    * number and setting the highest address bit (this bit is for the backend
>>    * to be able to distinguish it from e.g. a mmio address).
>> - *
>> - * Note that for now we hard wire dom0 to be the backend domain. In order
>> - * to support any domain as backend we'd need to add a way to communicate
>> - * the domid of this backend, e.g. via Xenstore, via the PCI-device's
>> - * config space or DT/ACPI.
>>    */
>>   static void *xen_grant_dma_alloc(struct device *dev, size_t size,
>>   				 dma_addr_t *dma_handle, gfp_t gfp,
>> @@ -277,6 +272,16 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>>   	.dma_supported = xen_grant_dma_supported,
>>   };
>>   
>> +bool xen_is_grant_dma_device(struct device *dev)
>> +{
>> +	/* XXX Handle only DT devices for now */
>> +	if (!dev->of_node)
>> +		return false;
>> +
>> +	return of_property_read_bool(dev->of_node, "xen,dev-domid");
>> +}
>> +EXPORT_SYMBOL_GPL(xen_is_grant_dma_device);
>> +
>>   void xen_grant_setup_dma_ops(struct device *dev)
>>   {
>>   	struct xen_grant_dma_data *data;
>> @@ -288,8 +293,14 @@ void xen_grant_setup_dma_ops(struct device *dev)
>>   		return;
>>   	}
>>   
>> -	/* XXX The dom0 is hardcoded as the backend domain for now */
>> -	dev_domid = 0;
>> +	/* XXX ACPI and PCI devices unsupported for now */
>> +	if (dev_is_pci(dev) || !dev->of_node)
>> +		goto err;
> I think we can remove the "dev_is_pci" check, right?

I think, yes (at least for now). I will remove the inclusion of #include 
<linux/pci.h> as well.


>
>
>> +	if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) {
>> +		dev_err(dev, "xen,dev-domid property is not present\n");
>> +		goto err;
>> +	}
>>   
>>   	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
>>   	if (!data) {
>> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>> index 4f9fad5..62be9dc 100644
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { }
>>   
>>   #ifdef CONFIG_XEN_GRANT_DMA_OPS
>>   void xen_grant_setup_dma_ops(struct device *dev);
>> +bool xen_is_grant_dma_device(struct device *dev);
>>   #else
>>   static inline void xen_grant_setup_dma_ops(struct device *dev)
>>   {
>>   }
>> +static inline bool xen_is_grant_dma_device(struct device *dev)
>> +{
>> +	return false;
>> +}
>>   #endif /* CONFIG_XEN_GRANT_DMA_OPS */
>>   
>>   #endif /* INCLUDE_XEN_OPS_H */
>> -- 
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sat Apr 23 15:25:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 15:25:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311684.528945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niHdh-0005sC-G5; Sat, 23 Apr 2022 15:25:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311684.528945; Sat, 23 Apr 2022 15:25:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niHdh-0005s5-DH; Sat, 23 Apr 2022 15:25:37 +0000
Received: by outflank-mailman (input) for mailman id 311684;
 Sat, 23 Apr 2022 15:25:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hJIN=VB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1niHdg-0005rz-8V
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 15:25:36 +0000
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [2a00:1450:4864:20::135])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e9705de-c319-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 17:25:35 +0200 (CEST)
Received: by mail-lf1-x135.google.com with SMTP id t25so19097311lfg.7
 for <xen-devel@lists.xenproject.org>; Sat, 23 Apr 2022 08:25:34 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 w23-20020a197b17000000b0046d1729e7d9sm651824lfc.294.2022.04.23.08.25.32
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 23 Apr 2022 08:25:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e9705de-c319-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=uPFaFyXz+EDuxvlVGUNcApp1IgYD33kJxyk7ho7JgsI=;
        b=qAX7YMz/JVxRQSD3fqnQXDX9zVCZWMtAGJZf1JQG6BC5yFq+jBJs0Bmw87DF2eoCmq
         eB2jJ/jLcplC0r+dgKvQHASQCXlpPx9qQUvjOIRwmext+2BEI0HSQFsH+wCaKaT+dSrx
         pM78v3UdfvFh6ZqEaYYirFC4NVvxB3UYNKeyJAuxTPBGueHYmNO1YXcqFHfXfqC5kFeK
         XCKNDjDTj1YGjwgrnHyOM3osVRjWrQAzoW4HO1CVCAsEzUy/NId/1IIJ6vn2OTwihsxL
         HbGqWv2cHnxee5QlZ8keGC34Wlv1JJF3pXORff0x5PdSPBVpKxUSGjq/0Pa0qxEffFfF
         oZZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=uPFaFyXz+EDuxvlVGUNcApp1IgYD33kJxyk7ho7JgsI=;
        b=QZoY+9fTtVki2BSwCt7hIztxUEHaegFQcZCjeppvK88tdEi2RQb1dugbj+we6MsIO8
         ypG7PDE5GHFAIK4wBJr/jIbVddBYHDQ/JelcjxjPPjhZ/eUs/32xsGW20OW1Dt+UmEgI
         am6wb2zIKHmSpqwBUDz8al44UAH/+FPxESC6DhzsfK18j/7CSShDB2JjH/W3DHDdO1OS
         7hIrkNS7PU9SG23f5lqLv+rXyjEaCkvHoDMS5B9tMk2dgZcfgIrhyQgaNZfC/PIe8xqJ
         /LJX8k+sGnveZlL1SQrqYgWlxnkb7XzvB3YTsSxtfeid1BMr4zwX1dlcL/MUEJtSxfds
         NqKA==
X-Gm-Message-State: AOAM531snxMAcFMxVP/L/wWsaXjqkJc76P+TbTshZuBAJB/Bl88am0JU
	g11wyUdeLTkaAGj5V/MnwMs=
X-Google-Smtp-Source: ABdhPJwZNl8ZX/SsU1gM9f+mVYW4LB3X8j+kRC6d+voW45tPtkkQcLAFY9FBtTyQGpxCpCgIZRyrOQ==
X-Received: by 2002:a19:dc0f:0:b0:439:702c:d83b with SMTP id t15-20020a19dc0f000000b00439702cd83bmr6906996lfg.192.1650727534046;
        Sat, 23 Apr 2022 08:25:34 -0700 (PDT)
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Christoph Hellwig <hch@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2204221526221.915916@ubuntu-linux-20-04-desktop>
 <3de2852b-0a94-fd1d-2eb6-fd818f33fc88@gmail.com>
 <8acfaa93-50ce-8dd9-49c6-cc328bb37569@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <cfeec3e9-8a04-b2ae-56bf-153e4ff2d9c7@gmail.com>
Date: Sat, 23 Apr 2022 18:25:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <8acfaa93-50ce-8dd9-49c6-cc328bb37569@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 23.04.22 12:10, Juergen Gross wrote:

Hello Juergen

> On 23.04.22 09:05, Oleksandr wrote:
>>
>> On 23.04.22 02:00, Stefano Stabellini wrote:
>>
>> Hello Stefano
>>
>>
>>> On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote:
>>>> From: Juergen Gross <jgross@suse.com>
>>>>
>>>> Introduce Xen grant DMA-mapping layer which contains special 
>>>> DMA-mapping
>>>> routines for providing grant references as DMA addresses to be used by
>>>> frontends (e.g. virtio) in Xen guests.
>>>>
>>>> In order to support virtio in Xen guests add a config option 
>>>> XEN_VIRTIO
>>>> enabling the user to specify whether in all Xen guests virtio should
>>>> be able to access memory via Xen grant mappings only on the host side.
>>>>
>>>> As this also requires providing 
>>>> arch_has_restricted_virtio_memory_access
>>>> implementation, switch from a pure stub to a real function on Arm
>>>> and combine with existing implementation for the SEV guests on x86.
>>>>
>>>> Add the needed functionality by providing a special set of DMA ops
>>>> handling the needed grant operations for the I/O pages.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> There are a couple of minor things that checkpatch.pl reports,
>>
>> Thank you for pointing this out, my fault.
>>
>>
>>>   but aside
>>> from those the patch looks fine to me.
>>
>> good
>>
>>
>> The attached diff to be squashed for the new version. One thing remains:
>>
>> checkpatch.pl says regarding drivers/xen/grant-dma-ops.c:
>>
>> WARNING: added, moved or deleted file(s), does MAINTAINERS need 
>> updating?
>> #151:
>> new file mode 100644
>>
>>
>> Which, I assume, this is not an issue as new file falls under XEN 
>> HYPERVISOR INTERFACE maintainership?
>
> Yes.


ok, thank you for the confirmation.


>
>
> Juergen

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sat Apr 23 16:32:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 16:32:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311712.528957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niIgW-0006Mp-J8; Sat, 23 Apr 2022 16:32:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311712.528957; Sat, 23 Apr 2022 16:32:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niIgW-0006Mi-F4; Sat, 23 Apr 2022 16:32:36 +0000
Received: by outflank-mailman (input) for mailman id 311712;
 Sat, 23 Apr 2022 16:32:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nM19=VB=bombadil.srs.infradead.org=BATV+786c894e6a19374922de+6817+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1niIgS-0006Mc-W7
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 16:32:34 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6dc1c21-c322-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 18:32:30 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1niIgK-004dlm-8q; Sat, 23 Apr 2022 16:32:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6dc1c21-c322-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=tm0gSqV7/P9ncZVPB8LqYHR3Gz1xeU6baJ61OHE1BW8=; b=udvQngrutqjVgHNdHAkQtTYj4Z
	uj9eaEdm3fjU1uTVZOIo8pU0/Xxa1IKlKSUeYPCiWaC9FpsXAJEnJgqJz/yitw2wTHWU0tEc7LSB0
	X0fJM5ntfIPoWNdpv6L+CjuafNJPUUUUSwV8L4ktUqnMQ1hQBI8wsyqfk1dQwn/uh4gWv85fnhRh5
	/2X1dbCuYTh75gIu7ru2dCAx8PLj/duLjwK9+USlnlkZAl5R53zH9b1eckSJdfd8QiJmEOQ/WBdN7
	56vfH6cgCE6eS5U3OAlXcaMK1noDeWW7GbezDKIaRw7AZsWDTsNetOJKT90zCvQ8NQKBlrdbciioY
	HZy5IN0A==;
Date: Sat, 23 Apr 2022 09:32:24 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	David Hildenbrand <david@redhat.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Kees Cook <keescook@chromium.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Julien Grall <julien@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V1 1/6] arm/xen: Introduce xen_setup_dma_ops()
Message-ID: <YmQqGOoNDwkKSbZr@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-2-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650646263-22047-2-git-send-email-olekstysh@gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Fri, Apr 22, 2022 at 07:50:58PM +0300, Oleksandr Tyshchenko wrote:
> +#ifndef _ASM_ARM_XEN_OPS_H
> +#define _ASM_ARM_XEN_OPS_H
> +
> +#include <xen/swiotlb-xen.h>
> +
> +static inline void xen_setup_dma_ops(struct device *dev)
> +{
> +#ifdef CONFIG_XEN
> +	if (xen_swiotlb_detect())
> +		dev->dma_ops = &xen_swiotlb_dma_ops;
> +#endif

Maybe create a proper !CONFIG_XEN stub for xen_swiotlb_detect instead
of the ifdef here, but otherwise this looks good to me.


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 16:41:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 16:41:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311722.528968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niIof-0007p2-DA; Sat, 23 Apr 2022 16:41:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311722.528968; Sat, 23 Apr 2022 16:41:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niIof-0007ov-9o; Sat, 23 Apr 2022 16:41:01 +0000
Received: by outflank-mailman (input) for mailman id 311722;
 Sat, 23 Apr 2022 16:40:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nM19=VB=bombadil.srs.infradead.org=BATV+786c894e6a19374922de+6817+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1niIod-0007oW-N9
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 16:40:59 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 26133643-c324-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 18:40:57 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1niIoX-004edG-Bn; Sat, 23 Apr 2022 16:40:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 26133643-c324-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=2MvqW49dlfPXlTFO4cVz6jW0fsGriUccE1VFxe7rooQ=; b=4CpgKtZWpr1YvrwrgR0PVODSfR
	eFHq3GErIpjs8WXAaxmLwUJKW2Z//2hg9eashRdzhcM19R6oVxxqIxAe6YlPuPVuItoTu4azCvfr2
	pGg65CQ/FdUzZKmE6ubYHxzYTixg9YZgL+KZeg+2Hf6FBRSvPF83kFxQ+JjE8EUs6qRpgGpXw+r1e
	ukp3Ji2ELJKv1OizDiizyYel4rZFkUXo+rKGnGWuuAZi6cPGZi7Gj7OSWaq4fKE93lQDwpAxnqKSd
	7sMpv5r84yTKbhECYHDRHM16S9tNaakXyhMW2GipLr8jLem2OCOeIy90YqNtk/EF11ryDiHiAuK4s
	nqKdocew==;
Date: Sat, 23 Apr 2022 09:40:53 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Juergen Gross <jgross@suse.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Message-ID: <YmQsFb36UEH9BUnN@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Please split this into one patch that creates grant-dma-ops, and another
that sets up the virtio restricted access helpers.

> +
> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> +int arch_has_restricted_virtio_memory_access(void)
> +{
> +	return (xen_has_restricted_virtio_memory_access() ||
> +			cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
> +}

So instead of hardcoding Xen here, this seems like a candidate for
another cc_platform_has flag.

> +config XEN_VIRTIO
> +	bool "Xen virtio support"
> +	default n

n is the default default, so no need to specify it.

> +// SPDX-License-Identifier: GPL-2.0-only
> +/******************************************************************************

The all * line is not the usual kernel style, I'd suggest to drop it.

> +static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
> +					      dma_addr_t *dma_handle,
> +					      enum dma_data_direction dir,
> +					      gfp_t gfp)
> +{
> +	WARN_ONCE(1, "xen_grant_dma_alloc_pages size %zu\n", size);
> +	return NULL;
> +}
> +
> +static void xen_grant_dma_free_pages(struct device *dev, size_t size,
> +				     struct page *vaddr, dma_addr_t dma_handle,
> +				     enum dma_data_direction dir)
> +{
> +	WARN_ONCE(1, "xen_grant_dma_free_pages size %zu\n", size);
> +}

Please just wire this up to the same implementation as .alloc and .free.

> +	spin_lock(&xen_grant_dma_lock);
> +	list_add(&data->list, &xen_grant_dma_devices);
> +	spin_unlock(&xen_grant_dma_lock);

Hmm, having to do this device lookup for every DMA operation is going
to suck. It might make sense to add a private field (e.g. as a union
with the iommu field) in struct device instead.

But if not you probably want to switch to a more efficient data
structure like the xarray at least.

> +EXPORT_SYMBOL_GPL(xen_grant_setup_dma_ops);

I don't think this has any modular users, or did I miss something?


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 16:42:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 16:42:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311732.528979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niIpz-0008VM-Tk; Sat, 23 Apr 2022 16:42:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311732.528979; Sat, 23 Apr 2022 16:42:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niIpz-0008VF-QB; Sat, 23 Apr 2022 16:42:23 +0000
Received: by outflank-mailman (input) for mailman id 311732;
 Sat, 23 Apr 2022 16:42:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nM19=VB=bombadil.srs.infradead.org=BATV+786c894e6a19374922de+6817+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1niIpx-0008V4-KE
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 16:42:21 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 57924a14-c324-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 18:42:20 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1niIpu-004etX-T8; Sat, 23 Apr 2022 16:42:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57924a14-c324-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=BbU4qU1u+ib3z06jcjxtpWxewOhWeGRACT3SUClYfQU=; b=AhrDqdLN83fA5xLD4BM2GP2cPe
	ZPFamzRoBUWgZ6TueAJd/LnTpCkqpIraOwxxnFdhh10vSqfwomorASN5nrlTp8V9Dry0dnGRxjjEw
	v7JuhY6ox9FidKp5Hlp3HLTXDr3Vz4TBvr3dE48LvKPTfesNhxqNIb3L+LJJZDQI1E1E05OFk7nZJ
	fdgfnxdUNoQrEcTt1wwc5Cy5Dh82uK7C4oGDIf7aO2Wy+2OHkl7W87Jqi1aFlc6+I3039Se/GEDo3
	evKCQOC1ENaEsIIIjNzCQtGidYDx7645wDthEjcAzr29ZEXmNny8nn/OVrakWVtN9qIAf8TKvLahV
	rbi2qx6g==;
Date: Sat, 23 Apr 2022 09:42:18 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V1 6/6] arm/xen: Assign xen-grant DMA ops for xen-grant
 DMA devices
Message-ID: <YmQsagqMn56jidFZ@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-7-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650646263-22047-7-git-send-email-olekstysh@gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Fri, Apr 22, 2022 at 07:51:03PM +0300, Oleksandr Tyshchenko wrote:
>  static inline void xen_setup_dma_ops(struct device *dev)
>  {
>  #ifdef CONFIG_XEN
> -	if (xen_swiotlb_detect())
> +	if (arch_has_restricted_virtio_memory_access() &&
> +			xen_is_grant_dma_device(dev))
> +		xen_grant_setup_dma_ops(dev);
> +	else if (xen_swiotlb_detect())

I don't think that arch_has_restricted_virtio_memory_access
check should be there as it still is a bit of a layering violation.



From xen-devel-bounces@lists.xenproject.org Sat Apr 23 16:52:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 16:52:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311744.528989 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niIzO-0001y9-QQ; Sat, 23 Apr 2022 16:52:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311744.528989; Sat, 23 Apr 2022 16:52:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niIzO-0001y2-N0; Sat, 23 Apr 2022 16:52:06 +0000
Received: by outflank-mailman (input) for mailman id 311744;
 Sat, 23 Apr 2022 16:52:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niIzN-0001xs-Ti; Sat, 23 Apr 2022 16:52:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niIzN-0006PI-QP; Sat, 23 Apr 2022 16:52:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niIzN-0001hM-C4; Sat, 23 Apr 2022 16:52:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niIzN-0002Kf-BZ; Sat, 23 Apr 2022 16:52:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=K9h8SxdE3lLTDXdnTn9rs7CG0JtKqtyhTn3fr7+lsi8=; b=QQMGS2IUixZIKIfPGK3iuSqpfM
	feqgDAi6LoOLsi5TaE9sa35xpxbALw8TJGUzU0Xz/ClgYPj+5mX+CbuDqeODJKXatWD1aVFe5J7ne
	Kl+Z7eHMYwX6uz+bQPJjgKLrBgveHVSpzSLcufeSEIKyt92qIVVBUWfi9e1HK545lMWE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169653-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169653: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 16:52:05 +0000

flight 169653 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169653/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  576 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 17:14:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 17:14:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311754.529001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niJLA-0004pK-MJ; Sat, 23 Apr 2022 17:14:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311754.529001; Sat, 23 Apr 2022 17:14:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niJLA-0004pD-Iu; Sat, 23 Apr 2022 17:14:36 +0000
Received: by outflank-mailman (input) for mailman id 311754;
 Sat, 23 Apr 2022 17:14:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nM19=VB=bombadil.srs.infradead.org=BATV+786c894e6a19374922de+6817+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1niJL9-0004p7-Ev
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 17:14:35 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d736f947-c328-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 19:14:32 +0200 (CEST)
Received: from [2001:4bb8:18d:be1d:2a19:700d:8998:ac2a] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1niJL0-004iuc-6j; Sat, 23 Apr 2022 17:14:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d736f947-c328-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=Nni+9zbbB8BgtGggAXNYH6yiRNel4M1xirsDWdfnzGw=; b=PgkMT/2nOy9iL9JNqXJpbcS7PZ
	AsyDGYun0Nd3X13GtAjqiaBbkqK+P7hBdCsR9gigqLv6SIDfFasuLeu4Asu6O1ceUqjsp549FszHs
	A9vyHug4wp5UsbwoltMDcOh26SGSjvlBnDFzBmBl8lfo+9LVIQqDQjOq6HpwGuxg7DjPwC0Eu/bSB
	lGfMJ2+KEzDryDUrCRfzJnhyjwsKIbupCTpM/Jdoee7lXBTr+s+cADDX0sLgBqQOnw3zbYU3sTvEt
	q7HBN1E/Nxt5ZaL1VF/BQalPlh6oM/9jjwrhuelDMPZCCJ50e1Et/Y0aNpHw65s93rjN4vJydcLCY
	JxNsmbWg==;
From: Christoph Hellwig <hch@lst.de>
To: sstabellini@kernel.org,
	jgross@suse.com
Cc: xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	iommu@lists.linux-foundation.org,
	Rahul Singh <Rahul.Singh@arm.com>
Subject: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
Date: Sat, 23 Apr 2022 19:14:22 +0200
Message-Id: <20220423171422.1831676-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

swiotlb-xen uses very different ways to allocate coherent memory on x86
vs arm.  On the former it allocates memory from the page allocator, while
on the later it reuses the dma-direct allocator the handles the
complexities of non-coherent DMA on arm platforms.

Unfortunately the complexities of trying to deal with the two cases in
the swiotlb-xen.c code lead to a bug in the handling of
DMA_ATTR_NO_KERNEL_MAPPING on arm.  With the DMA_ATTR_NO_KERNEL_MAPPING
flag the coherent memory allocator does not actually allocate coherent
memory, but just a DMA handle for some memory that is DMA addressable
by the device, but which does not have to have a kernel mapping.  Thus
dereferencing the return value will lead to kernel crashed and memory
corruption.

Fix this by using the dma-direct allocator directly for arm, which works
perfectly fine because on arm swiotlb-xen is only used when the domain is
1:1 mapped, and then simplifying the remaining code to only cater for the
x86 case with DMA coherent device.

Reported-by: Rahul Singh <Rahul.Singh@arm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm/include/asm/xen/page-coherent.h   |   2 -
 arch/arm/xen/mm.c                          |  17 ----
 arch/arm64/include/asm/xen/page-coherent.h |   2 -
 arch/x86/include/asm/xen/page-coherent.h   |  24 -----
 arch/x86/include/asm/xen/swiotlb-xen.h     |   5 +
 drivers/xen/swiotlb-xen.c                  | 106 ++++++++-------------
 include/xen/arm/page-coherent.h            |  20 ----
 include/xen/xen-ops.h                      |   7 --
 8 files changed, 45 insertions(+), 138 deletions(-)
 delete mode 100644 arch/arm/include/asm/xen/page-coherent.h
 delete mode 100644 arch/arm64/include/asm/xen/page-coherent.h
 delete mode 100644 arch/x86/include/asm/xen/page-coherent.h
 delete mode 100644 include/xen/arm/page-coherent.h

diff --git a/arch/arm/include/asm/xen/page-coherent.h b/arch/arm/include/asm/xen/page-coherent.h
deleted file mode 100644
index 27e984977402b..0000000000000
--- a/arch/arm/include/asm/xen/page-coherent.h
+++ /dev/null
@@ -1,2 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#include <xen/arm/page-coherent.h>
diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
index a7e54a087b802..6e603e5fdebb1 100644
--- a/arch/arm/xen/mm.c
+++ b/arch/arm/xen/mm.c
@@ -118,23 +118,6 @@ bool xen_arch_need_swiotlb(struct device *dev,
 		!dev_is_dma_coherent(dev));
 }
 
-int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
-				 unsigned int address_bits,
-				 dma_addr_t *dma_handle)
-{
-	if (!xen_initial_domain())
-		return -EINVAL;
-
-	/* we assume that dom0 is mapped 1:1 for now */
-	*dma_handle = pstart;
-	return 0;
-}
-
-void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order)
-{
-	return;
-}
-
 static int __init xen_mm_init(void)
 {
 	struct gnttab_cache_flush cflush;
diff --git a/arch/arm64/include/asm/xen/page-coherent.h b/arch/arm64/include/asm/xen/page-coherent.h
deleted file mode 100644
index 27e984977402b..0000000000000
--- a/arch/arm64/include/asm/xen/page-coherent.h
+++ /dev/null
@@ -1,2 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#include <xen/arm/page-coherent.h>
diff --git a/arch/x86/include/asm/xen/page-coherent.h b/arch/x86/include/asm/xen/page-coherent.h
deleted file mode 100644
index 63cd41b2e17ac..0000000000000
--- a/arch/x86/include/asm/xen/page-coherent.h
+++ /dev/null
@@ -1,24 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_X86_XEN_PAGE_COHERENT_H
-#define _ASM_X86_XEN_PAGE_COHERENT_H
-
-#include <asm/page.h>
-#include <linux/dma-mapping.h>
-
-static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t size,
-		dma_addr_t *dma_handle, gfp_t flags,
-		unsigned long attrs)
-{
-	void *vstart = (void*)__get_free_pages(flags, get_order(size));
-	*dma_handle = virt_to_phys(vstart);
-	return vstart;
-}
-
-static inline void xen_free_coherent_pages(struct device *hwdev, size_t size,
-		void *cpu_addr, dma_addr_t dma_handle,
-		unsigned long attrs)
-{
-	free_pages((unsigned long) cpu_addr, get_order(size));
-}
-
-#endif /* _ASM_X86_XEN_PAGE_COHERENT_H */
diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h
index 66b4ddde77430..558821387808e 100644
--- a/arch/x86/include/asm/xen/swiotlb-xen.h
+++ b/arch/x86/include/asm/xen/swiotlb-xen.h
@@ -10,4 +10,9 @@ extern int pci_xen_swiotlb_init_late(void);
 static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }
 #endif
 
+int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
+				unsigned int address_bits,
+				dma_addr_t *dma_handle);
+void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order);
+
 #endif /* _ASM_X86_SWIOTLB_XEN_H */
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 47aebd98f52f5..557edb9c54879 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -36,7 +36,6 @@
 #include <xen/hvc-console.h>
 
 #include <asm/dma-mapping.h>
-#include <asm/xen/page-coherent.h>
 
 #include <trace/events/swiotlb.h>
 #define MAX_DMA_BITS 32
@@ -104,6 +103,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr)
 	return 0;
 }
 
+#ifdef CONFIG_X86
 static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 {
 	int rc;
@@ -129,6 +129,12 @@ static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 	} while (i < nslabs);
 	return 0;
 }
+#else
+static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
+{
+	return 0;
+}
+#endif
 
 enum xen_swiotlb_err {
 	XEN_SWIOTLB_UNKNOWN = 0,
@@ -256,97 +262,60 @@ void __init xen_swiotlb_init_early(void)
 		panic("Cannot allocate SWIOTLB buffer");
 	swiotlb_set_max_segment(PAGE_SIZE);
 }
-#endif /* CONFIG_X86 */
 
 static void *
-xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
-			   dma_addr_t *dma_handle, gfp_t flags,
-			   unsigned long attrs)
+xen_swiotlb_alloc_coherent(struct device *dev, size_t size,
+		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
 {
-	void *ret;
+	u64 dma_mask = dev->coherent_dma_mask;
 	int order = get_order(size);
-	u64 dma_mask = DMA_BIT_MASK(32);
 	phys_addr_t phys;
-	dma_addr_t dev_addr;
-
-	/*
-	* Ignore region specifiers - the kernel's ideas of
-	* pseudo-phys memory layout has nothing to do with the
-	* machine physical layout.  We can't allocate highmem
-	* because we can't return a pointer to it.
-	*/
-	flags &= ~(__GFP_DMA | __GFP_HIGHMEM);
+	void *ret;
 
-	/* Convert the size to actually allocated. */
+	/* Align the allocation to the Xen page size */
 	size = 1UL << (order + XEN_PAGE_SHIFT);
 
-	/* On ARM this function returns an ioremap'ped virtual address for
-	 * which virt_to_phys doesn't return the corresponding physical
-	 * address. In fact on ARM virt_to_phys only works for kernel direct
-	 * mapped RAM memory. Also see comment below.
-	 */
-	ret = xen_alloc_coherent_pages(hwdev, size, dma_handle, flags, attrs);
-
+	ret = (void *)__get_free_pages(flags, get_order(size));
 	if (!ret)
 		return ret;
-
-	if (hwdev && hwdev->coherent_dma_mask)
-		dma_mask = hwdev->coherent_dma_mask;
-
-	/* At this point dma_handle is the dma address, next we are
-	 * going to set it to the machine address.
-	 * Do not use virt_to_phys(ret) because on ARM it doesn't correspond
-	 * to *dma_handle. */
-	phys = dma_to_phys(hwdev, *dma_handle);
-	dev_addr = xen_phys_to_dma(hwdev, phys);
-	if (((dev_addr + size - 1 <= dma_mask)) &&
-	    !range_straddles_page_boundary(phys, size))
-		*dma_handle = dev_addr;
-	else {
-		if (xen_create_contiguous_region(phys, order,
-						 fls64(dma_mask), dma_handle) != 0) {
-			xen_free_coherent_pages(hwdev, size, ret, (dma_addr_t)phys, attrs);
-			return NULL;
-		}
-		*dma_handle = phys_to_dma(hwdev, *dma_handle);
+	phys = virt_to_phys(ret);
+
+	*dma_handle = xen_phys_to_dma(dev, phys);
+	if (*dma_handle + size - 1 > dma_mask ||
+	    range_straddles_page_boundary(phys, size)) {
+		if (xen_create_contiguous_region(phys, order, fls64(dma_mask),
+				dma_handle) != 0)
+			goto out_free_pages;
 		SetPageXenRemapped(virt_to_page(ret));
 	}
+
 	memset(ret, 0, size);
 	return ret;
+
+out_free_pages:
+	free_pages((unsigned long)ret, get_order(size));
+	return NULL;
 }
 
 static void
-xen_swiotlb_free_coherent(struct device *hwdev, size_t size, void *vaddr,
-			  dma_addr_t dev_addr, unsigned long attrs)
+xen_swiotlb_free_coherent(struct device *dev, size_t size, void *vaddr,
+		dma_addr_t dma_handle, unsigned long attrs)
 {
+	phys_addr_t phys = virt_to_phys(vaddr);
 	int order = get_order(size);
-	phys_addr_t phys;
-	u64 dma_mask = DMA_BIT_MASK(32);
-	struct page *page;
-
-	if (hwdev && hwdev->coherent_dma_mask)
-		dma_mask = hwdev->coherent_dma_mask;
-
-	/* do not use virt_to_phys because on ARM it doesn't return you the
-	 * physical address */
-	phys = xen_dma_to_phys(hwdev, dev_addr);
 
 	/* Convert the size to actually allocated. */
 	size = 1UL << (order + XEN_PAGE_SHIFT);
 
-	if (is_vmalloc_addr(vaddr))
-		page = vmalloc_to_page(vaddr);
-	else
-		page = virt_to_page(vaddr);
+	if (WARN_ON_ONCE(dma_handle + size - 1 > dev->coherent_dma_mask) ||
+	    WARN_ON_ONCE(range_straddles_page_boundary(phys, size)))
+	    	return;
 
-	if (!WARN_ON((dev_addr + size - 1 > dma_mask) ||
-		     range_straddles_page_boundary(phys, size)) &&
-	    TestClearPageXenRemapped(page))
+	if (TestClearPageXenRemapped(virt_to_page(vaddr)))
 		xen_destroy_contiguous_region(phys, order);
-
-	xen_free_coherent_pages(hwdev, size, vaddr, phys_to_dma(hwdev, phys),
-				attrs);
+	free_pages((unsigned long)vaddr, get_order(size));
 }
+#endif /* CONFIG_X86 */
 
 /*
  * Map a single buffer of the indicated size for DMA in streaming mode.  The
@@ -549,8 +518,13 @@ xen_swiotlb_dma_supported(struct device *hwdev, u64 mask)
 }
 
 const struct dma_map_ops xen_swiotlb_dma_ops = {
+#ifdef CONFIG_X86
 	.alloc = xen_swiotlb_alloc_coherent,
 	.free = xen_swiotlb_free_coherent,
+#else
+	.alloc = dma_direct_alloc,
+	.free = dma_direct_free,
+#endif
 	.sync_single_for_cpu = xen_swiotlb_sync_single_for_cpu,
 	.sync_single_for_device = xen_swiotlb_sync_single_for_device,
 	.sync_sg_for_cpu = xen_swiotlb_sync_sg_for_cpu,
diff --git a/include/xen/arm/page-coherent.h b/include/xen/arm/page-coherent.h
deleted file mode 100644
index b9cc11e887ed5..0000000000000
--- a/include/xen/arm/page-coherent.h
+++ /dev/null
@@ -1,20 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _XEN_ARM_PAGE_COHERENT_H
-#define _XEN_ARM_PAGE_COHERENT_H
-
-#include <linux/dma-mapping.h>
-#include <asm/page.h>
-
-static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t size,
-		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
-{
-	return dma_direct_alloc(hwdev, size, dma_handle, flags, attrs);
-}
-
-static inline void xen_free_coherent_pages(struct device *hwdev, size_t size,
-		void *cpu_addr, dma_addr_t dma_handle, unsigned long attrs)
-{
-	dma_direct_free(hwdev, size, cpu_addr, dma_handle, attrs);
-}
-
-#endif /* _XEN_ARM_PAGE_COHERENT_H */
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index a3584a357f353..c7c1b46ff4cd4 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -42,13 +42,6 @@ int xen_setup_shutdown_event(void);
 
 extern unsigned long *xen_contiguous_bitmap;
 
-#if defined(CONFIG_XEN_PV) || defined(CONFIG_ARM) || defined(CONFIG_ARM64)
-int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
-				unsigned int address_bits,
-				dma_addr_t *dma_handle);
-void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order);
-#endif
-
 #if defined(CONFIG_XEN_PV)
 int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr,
 		  xen_pfn_t *pfn, int nr, int *err_ptr, pgprot_t prot,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 23 18:26:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 18:26:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311769.529013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niKST-0004tB-0p; Sat, 23 Apr 2022 18:26:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311769.529013; Sat, 23 Apr 2022 18:26:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niKSS-0004t4-S2; Sat, 23 Apr 2022 18:26:12 +0000
Received: by outflank-mailman (input) for mailman id 311769;
 Sat, 23 Apr 2022 18:26:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niKSR-0004su-BZ; Sat, 23 Apr 2022 18:26:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niKSR-00083H-5y; Sat, 23 Apr 2022 18:26:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niKSQ-0004jH-RP; Sat, 23 Apr 2022 18:26:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niKSQ-0008Gy-Qw; Sat, 23 Apr 2022 18:26:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pkvsZC0/OadTqIUc2C6OfYo+YgH5CC5pE1islOfE/a8=; b=nQljZloAvOq8I0cBKmYZsfzysk
	B9oaSqD1KVXuqSbt0cK76znfzwJCMClqCwuYutjYaXcgAx5/SUfISyr0ea7fmN9nLlLgf1e/ZNx21
	MrPICUV/WJr3m2J//yN3s10ndj2vGAd12T0hOVns1PeQG64moXzmjlhXNFRyqWjJjKJw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169655-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169655: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 18:26:10 +0000

flight 169655 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169655/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  577 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 19:35:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 19:35:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311778.529023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niLXD-0004v7-Bq; Sat, 23 Apr 2022 19:35:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311778.529023; Sat, 23 Apr 2022 19:35:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niLXD-0004v0-7Z; Sat, 23 Apr 2022 19:35:11 +0000
Received: by outflank-mailman (input) for mailman id 311778;
 Sat, 23 Apr 2022 19:35:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HFCZ=VB=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1niLXB-0004uu-Ek
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 19:35:09 +0000
Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com
 [2607:f8b0:4864:20::429])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7a98b2bd-c33c-11ec-a405-831a346695d4;
 Sat, 23 Apr 2022 21:35:07 +0200 (CEST)
Received: by mail-pf1-x429.google.com with SMTP id y14so10352870pfe.10
 for <xen-devel@lists.xenproject.org>; Sat, 23 Apr 2022 12:35:07 -0700 (PDT)
Received: from localhost ([118.33.58.98]) by smtp.gmail.com with ESMTPSA id
 j9-20020aa78009000000b004fde2dd78b0sm6182154pfi.109.2022.04.23.12.35.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 23 Apr 2022 12:35:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a98b2bd-c33c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition;
        bh=4tavhL6msLPCorzynuJXgSiaV6UCD46MhySnJI+bSiQ=;
        b=JelAi7F7QJ49IeyAJRnO2kSRA9utw+F4WEa0i3BeAghEIrPa6SjKV2Swjj3YmZJJ5Q
         g4v2FTsnCrjMb4o/rCpmsdSWPqXom+rYbt92b454r8fi10TfEAgLEoim0FPc3vq3enJA
         NHpttCcnI0cAZqTbsV/5QJ7u2mtD+7TeFKuJTnLoX9iOAzbDpu6rIDzdAyFadWBqD6jG
         8UGECs/dLgQ/h2OSDdQveYEbPWsTk0VpxwBXpPFWjGKx3ZHr1RJ1UMDz7iktCdhEf6W5
         1ShUAwkux3FY2Aqcrjwv9XZkJ0dasLEXkklB8giEN/N5XOSamYyrlKPU5F24OA+T4tlH
         CgPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition;
        bh=4tavhL6msLPCorzynuJXgSiaV6UCD46MhySnJI+bSiQ=;
        b=7q1Wgdwq+2WHnjsHD3KSSXrRKYik6PPtbtJn/HndCIIq+eXXMDT7fDU9GSE7/Lx9Dx
         GjcICGBMzz5w6AS6S6C7m9I8Uq6JwvV9d4lg17+3e/MyTRA96Tgj0MPAzWlXQjhychK0
         EuVQgbUE3gbfFZyS5PtVeQGTbPMNkeRz+NdkKa2A1piet88fUa+eV+BzQCYix2AyQzRL
         +dq7AUvcASLT9wBoCGlVyf/mfmorHeeZinIBU0bPDXhIzHGOzLFldvhpk3gDsu+BtqW/
         xFho9Xr2gjWFEKlZEfhaWtbQpYO3GqF2DN69DwWNFyymEr9Yvqg/JQ99bWprP+H1OATm
         Qhsw==
X-Gm-Message-State: AOAM5337MUbyZsaL4Lg0VtT7m8tJ155qvgQfsxJ5VRS+ZMgWCBD2JWwk
	vCCVamtltvB5keVnmnR7gAs=
X-Google-Smtp-Source: ABdhPJybvX+zPdayg19N6R8s+Di+UkzQJTh8X3RzJZetxAmyu65neNTb3E+e5UArpdKwgzbcT3I2iQ==
X-Received: by 2002:a63:8941:0:b0:3aa:b55c:729b with SMTP id v62-20020a638941000000b003aab55c729bmr8618019pgd.285.1650742505694;
        Sat, 23 Apr 2022 12:35:05 -0700 (PDT)
Date: Sun, 24 Apr 2022 04:35:01 +0900
From: Paran Lee <p4ranlee@gmail.com>
To: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
Subject: [PATCH] xen/mm: page_alloc fix duplicated order shift operation in
 the loop
Message-ID: <20220423193501.GA10077@DESKTOP-NK4TH6S.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

It doesn't seem necessary to do that
duplicate calculation of order shift 2^@order in the loop.

In addition, I fixed type of total_avail_pages from long
to unsigned long. because when total_avail_pages static variable
substitute in functions of page alloc local variable,
type of local variables is unsigned long.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 xen/common/page_alloc.c | 51 ++++++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 24 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..9a955ce84e 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -456,7 +456,7 @@ static heap_by_zone_and_order_t *_heap[MAX_NUMNODES];
 static unsigned long node_need_scrub[MAX_NUMNODES];
 
 static unsigned long *avail[MAX_NUMNODES];
-static long total_avail_pages;
+static unsigned long total_avail_pages;
 
 static DEFINE_SPINLOCK(heap_lock);
 static long outstanding_claims; /* total outstanding claims by all domains */
@@ -922,8 +922,9 @@ static struct page_info *alloc_heap_pages(
     struct domain *d)
 {
     nodeid_t node;
-    unsigned int i, buddy_order, zone, first_dirty;
-    unsigned long request = 1UL << order;
+    unsigned int buddy_order, zone, first_dirty;
+    unsigned int buddy_request;
+    unsigned long i, request = 1UL << order;
     struct page_info *pg;
     bool need_tlbflush = false;
     uint32_t tlbflush_timestamp = 0;
@@ -975,16 +976,17 @@ static struct page_info *alloc_heap_pages(
     while ( buddy_order != order )
     {
         buddy_order--;
+        buddy_request = 1U << buddy_order;
         page_list_add_scrub(pg, node, zone, buddy_order,
-                            (1U << buddy_order) > first_dirty ?
+                            buddy_request > first_dirty ?
                             first_dirty : INVALID_DIRTY_IDX);
-        pg += 1U << buddy_order;
+        pg += buddy_request;
 
         if ( first_dirty != INVALID_DIRTY_IDX )
         {
             /* Adjust first_dirty */
-            if ( first_dirty >= 1U << buddy_order )
-                first_dirty -= 1U << buddy_order;
+            if ( first_dirty >= buddy_request )
+                first_dirty -= buddy_request;
             else
                 first_dirty = 0; /* We've moved past original first_dirty */
         }
@@ -1000,13 +1002,13 @@ static struct page_info *alloc_heap_pages(
     if ( d != NULL )
         d->last_alloc_node = node;
 
-    for ( i = 0; i < (1 << order); i++ )
+    for ( i = 0; i < request; i++ )
     {
         /* Reference count must continuously be zero for free pages. */
         if ( (pg[i].count_info & ~PGC_need_scrub) != PGC_state_free )
         {
             printk(XENLOG_ERR
-                   "pg[%u] MFN %"PRI_mfn" c=%#lx o=%u v=%#lx t=%#x\n",
+                   "pg[%lu] MFN %"PRI_mfn" c=%#lx o=%u v=%#lx t=%#x\n",
                    i, mfn_x(page_to_mfn(pg + i)),
                    pg[i].count_info, pg[i].v.free.order,
                    pg[i].u.free.val, pg[i].tlbflush_timestamp);
@@ -1034,7 +1036,7 @@ static struct page_info *alloc_heap_pages(
     if ( first_dirty != INVALID_DIRTY_IDX ||
          (scrub_debug && !(memflags & MEMF_no_scrub)) )
     {
-        for ( i = 0; i < (1U << order); i++ )
+        for ( i = 0; i < request; i++ )
         {
             if ( test_and_clear_bit(_PGC_need_scrub, &pg[i].count_info) )
             {
@@ -1063,7 +1065,7 @@ static struct page_info *alloc_heap_pages(
      * can control its own visibility of/through the cache.
      */
     mfn = page_to_mfn(pg);
-    for ( i = 0; i < (1U << order); i++ )
+    for ( i = 0; i < request; i++ )
         flush_page_to_ram(mfn_x(mfn) + i, !(memflags & MEMF_no_icache_flush));
 
     return pg;
@@ -1437,15 +1439,16 @@ static void free_heap_pages(
 {
     unsigned long mask;
     mfn_t mfn = page_to_mfn(pg);
-    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn));
+    unsigned int node = phys_to_nid(mfn_to_maddr(mfn));
     unsigned int zone = page_to_zone(pg);
+    unsigned long i, request = 1UL << order;
     bool pg_offlined = false;
 
     ASSERT(order <= MAX_ORDER);
 
     spin_lock(&heap_lock);
 
-    for ( i = 0; i < (1 << order); i++ )
+    for ( i = 0; i < request; i++ )
     {
         if ( mark_page_free(&pg[i], mfn_add(mfn, i)) )
             pg_offlined = true;
@@ -1457,11 +1460,11 @@ static void free_heap_pages(
         }
     }
 
-    avail[node][zone] += 1 << order;
-    total_avail_pages += 1 << order;
+    avail[node][zone] += request;
+    total_avail_pages += request;
     if ( need_scrub )
     {
-        node_need_scrub[node] += 1 << order;
+        node_need_scrub[node] += request;
         pg->u.free.first_dirty = 0;
     }
     else
@@ -1490,7 +1493,7 @@ static void free_heap_pages(
             /* Update predecessor's first_dirty if necessary. */
             if ( predecessor->u.free.first_dirty == INVALID_DIRTY_IDX &&
                  pg->u.free.first_dirty != INVALID_DIRTY_IDX )
-                predecessor->u.free.first_dirty = (1U << order) +
+                predecessor->u.free.first_dirty = mask +
                                                   pg->u.free.first_dirty;
 
             pg = predecessor;
@@ -1511,7 +1514,7 @@ static void free_heap_pages(
             /* Update pg's first_dirty if necessary. */
             if ( pg->u.free.first_dirty == INVALID_DIRTY_IDX &&
                  successor->u.free.first_dirty != INVALID_DIRTY_IDX )
-                pg->u.free.first_dirty = (1U << order) +
+                pg->u.free.first_dirty = mask +
                                          successor->u.free.first_dirty;
 
             page_list_del(successor, &heap(node, zone, order));
@@ -2416,7 +2419,7 @@ struct page_info *alloc_domheap_pages(
 void free_domheap_pages(struct page_info *pg, unsigned int order)
 {
     struct domain *d = page_get_owner(pg);
-    unsigned int i;
+    unsigned long i, request = 1UL << order;
     bool drop_dom_ref;
 
     ASSERT(!in_irq());
@@ -2426,10 +2429,10 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
         /* NB. May recursively lock from relinquish_memory(). */
         spin_lock_recursive(&d->page_alloc_lock);
 
-        for ( i = 0; i < (1 << order); i++ )
+        for ( i = 0; i < request; i++ )
             arch_free_heap_page(d, &pg[i]);
 
-        d->xenheap_pages -= 1 << order;
+        d->xenheap_pages -= request;
         drop_dom_ref = (d->xenheap_pages == 0);
 
         spin_unlock_recursive(&d->page_alloc_lock);
@@ -2443,12 +2446,12 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
             /* NB. May recursively lock from relinquish_memory(). */
             spin_lock_recursive(&d->page_alloc_lock);
 
-            for ( i = 0; i < (1 << order); i++ )
+            for ( i = 0; i < request; i++ )
             {
                 if ( pg[i].u.inuse.type_info & PGT_count_mask )
                 {
                     printk(XENLOG_ERR
-                           "pg[%u] MFN %"PRI_mfn" c=%#lx o=%u v=%#lx t=%#x\n",
+                           "pg[%lu] MFN %"PRI_mfn" c=%#lx o=%u v=%#lx t=%#x\n",
                            i, mfn_x(page_to_mfn(pg + i)),
                            pg[i].count_info, pg[i].v.free.order,
                            pg[i].u.free.val, pg[i].tlbflush_timestamp);
@@ -2462,7 +2465,7 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
                 }
             }
 
-            drop_dom_ref = !domain_adjust_tot_pages(d, -(1 << order));
+            drop_dom_ref = !domain_adjust_tot_pages(d, -request);
 
             spin_unlock_recursive(&d->page_alloc_lock);
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Apr 23 19:36:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 19:36:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311781.529034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niLY7-0005Qx-Lh; Sat, 23 Apr 2022 19:36:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311781.529034; Sat, 23 Apr 2022 19:36:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niLY7-0005Qo-HE; Sat, 23 Apr 2022 19:36:07 +0000
Received: by outflank-mailman (input) for mailman id 311781;
 Sat, 23 Apr 2022 19:36:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niLY7-0005Qe-35; Sat, 23 Apr 2022 19:36:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niLY7-0000mF-0O; Sat, 23 Apr 2022 19:36:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niLY6-0007pS-LW; Sat, 23 Apr 2022 19:36:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niLY6-0003Kw-L1; Sat, 23 Apr 2022 19:36:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=G4dWi/hTDX68HPwgMR47cKzl/BtEqiiuutHkggW6ddE=; b=1DnslT4m7n3Dk8yvKNGhgiuSw5
	jK/vd3jm03HE2AcQG7vbDdD+xzU8P8wF5gziEwv0erAqMobcpFzbNcMbt9erLtPbQPmOaMXAJndjA
	4S39o1aIA7V3QRAreDPgZAfGRxvlcim5MTefsQx9DO/KKKxPA6ZV8V1ZwqpEDH/3/Aiw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169656-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169656: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 19:36:06 +0000

flight 169656 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169656/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  578 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 20:33:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 20:33:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311793.529045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niMRj-0004Jk-T2; Sat, 23 Apr 2022 20:33:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311793.529045; Sat, 23 Apr 2022 20:33:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niMRj-0004Jd-PO; Sat, 23 Apr 2022 20:33:35 +0000
Received: by outflank-mailman (input) for mailman id 311793;
 Sat, 23 Apr 2022 20:33:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niMRi-0004JT-Oh; Sat, 23 Apr 2022 20:33:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niMRi-0001qj-KW; Sat, 23 Apr 2022 20:33:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niMRh-0001Ni-W0; Sat, 23 Apr 2022 20:33:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niMRh-0007u8-VX; Sat, 23 Apr 2022 20:33:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XTb42UCSi7c59R7cYG2SHwRjWLJO8qXWpfIvweQuXR4=; b=srMll29d/4vQr/QRtKjglKo7Tq
	XUzSJori9ETgQG2zvXqd0a9CxSSCy0LxGsjPUPFmFSqxZPR9cMxumWzThmCifNclFVtTRTi6vEjoN
	qsvWBKu/8Wq0CyOGDuQ2bmsh/npODhDAI8+C1yTpmHzCefuKJvR+F+7dzgJve/SsxrsQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169657-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169657: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 20:33:33 +0000

flight 169657 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169657/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  579 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   21 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 21:01:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 21:01:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311803.529057 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niMrw-0007yW-1u; Sat, 23 Apr 2022 21:00:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311803.529057; Sat, 23 Apr 2022 21:00:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niMrv-0007yP-TA; Sat, 23 Apr 2022 21:00:39 +0000
Received: by outflank-mailman (input) for mailman id 311803;
 Sat, 23 Apr 2022 21:00:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ukTE=VB=kernel.org=pr-tracker-bot@srs-se1.protection.inumbo.net>)
 id 1niMru-0007yJ-5l
 for xen-devel@lists.xenproject.org; Sat, 23 Apr 2022 21:00:38 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6bc9d863-c348-11ec-8fc2-03012f2f19d4;
 Sat, 23 Apr 2022 23:00:36 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1B13460FF8;
 Sat, 23 Apr 2022 21:00:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPS id 7DDE8C385A0;
 Sat, 23 Apr 2022 21:00:34 +0000 (UTC)
Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org
 (localhost.localdomain [127.0.0.1])
 by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id
 6ABE9E8DBD4; Sat, 23 Apr 2022 21:00:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bc9d863-c348-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650747634;
	bh=RzYZ8CVv9KyE6w4BSTCQ7iFCqpRihYLBT92FFn5f1+Q=;
	h=Subject:From:In-Reply-To:References:Date:To:Cc:From;
	b=bww765jZMMB8Rgrvn+scGPWxo8/sLdHM76w7xAJMiiM8UJ5UUUj3x5aQa9w1rqmO1
	 EppOZCNKyxvnIrteeEEEw/nuOPd5N2w0WiIDNJSJm8fWORljrehe1AzE/bktCsrjo0
	 3lkZjwQXNDr07zVAlMV/ZolAFadDT65OFroefsXoz+IMoGWygT/AXPK95gyjCd1Wj3
	 Eg6sxs5fn30nX+UMDAwzluRcgm+LuvXlMKibVSuwnJJJqHRtVytxkPWA4m31yZkDIH
	 IP6DWT9AzGvkN9Mk595jWKXCSQGue0+6r75kxAcjXqREV9pegjVi92doi5UhrRa0Z9
	 NJiQfKHDkaF/A==
Subject: Re: [GIT PULL] xen: branch for v5.18-rc4
From: pr-tracker-bot@kernel.org
In-Reply-To: <20220423130806.15699-1-jgross@suse.com>
References: <20220423130806.15699-1-jgross@suse.com>
X-PR-Tracked-List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
X-PR-Tracked-Message-Id: <20220423130806.15699-1-jgross@suse.com>
X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.18-rc4-tag
X-PR-Tracked-Commit-Id: 533bec143a4c32f7b2014a159d0f5376226e5b4d
X-PR-Merge-Tree: torvalds/linux.git
X-PR-Merge-Refname: refs/heads/master
X-PR-Merge-Commit-Id: b51bd23c614bc5a8a905d258133246e78d611df1
Message-Id: <165074763443.21099.15482523060926556291.pr-tracker-bot@kernel.org>
Date: Sat, 23 Apr 2022 21:00:34 +0000
To: Juergen Gross <jgross@suse.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com

The pull request you sent on Sat, 23 Apr 2022 15:08:06 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.18-rc4-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b51bd23c614bc5a8a905d258133246e78d611df1

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 21:06:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 21:06:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311810.529067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niMx8-0000V0-Na; Sat, 23 Apr 2022 21:06:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311810.529067; Sat, 23 Apr 2022 21:06:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niMx8-0000Ut-KF; Sat, 23 Apr 2022 21:06:02 +0000
Received: by outflank-mailman (input) for mailman id 311810;
 Sat, 23 Apr 2022 21:06:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niMx7-0000Uj-1s; Sat, 23 Apr 2022 21:06:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niMx6-0002PI-U9; Sat, 23 Apr 2022 21:06:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niMx6-0002Lc-Eb; Sat, 23 Apr 2022 21:06:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niMx6-00058a-E6; Sat, 23 Apr 2022 21:06:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=51JHuEoIeNp0XSLEEdet1ZfkIRcCIpSI/MyFwRc6bNY=; b=hYY+raWHdWd84CrNhmoYaZHeTE
	Zm0alse2CfoFcY1LKYsU+Ca+991oGo3EyfMdpmqnI6Q1/UR8Kaaa5QZhxHpij2wF083aGwSfsK0Gv
	tC8q7UyxoKMkYelD6ThjWEmZ7A6fmvU4Uwqc7o8x/l0F7X0l0HDQSs541QfTrT2aVrfk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169658-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169658: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 21:06:00 +0000

flight 169658 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169658/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  580 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    0 days   22 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 21:45:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 21:45:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311818.529078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niNYh-0005QN-Om; Sat, 23 Apr 2022 21:44:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311818.529078; Sat, 23 Apr 2022 21:44:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niNYh-0005QG-Lo; Sat, 23 Apr 2022 21:44:51 +0000
Received: by outflank-mailman (input) for mailman id 311818;
 Sat, 23 Apr 2022 21:44:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niNYh-0005Q6-2k; Sat, 23 Apr 2022 21:44:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niNYg-00033h-W0; Sat, 23 Apr 2022 21:44:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niNYg-0003VG-Oy; Sat, 23 Apr 2022 21:44:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niNYg-0006PY-OX; Sat, 23 Apr 2022 21:44:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/ng13q5+UEn9dtNgDge9E0umrus5Y4fl94KHffoFY28=; b=cyKssMobwyV+OoUmrRrqgV0CCT
	eI5ToEgr/FCIzTflhs73JyEZk8l789vbSY2m1mIouD90MZ8omazVYGf44/MZFqtKt0LCzcf4TzSj9
	7c+xUbxjELSVTwIXnqJxhFwgDiQcKbSnp3QFgD1lnj19OU+QSI61SC5NdQjzN7I0YAW0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169659-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169659: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 21:44:50 +0000

flight 169659 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169659/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  581 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   23 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 23:08:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 23:08:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311826.529088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niOrD-0006W4-Uz; Sat, 23 Apr 2022 23:08:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311826.529088; Sat, 23 Apr 2022 23:08:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niOrD-0006Vx-S3; Sat, 23 Apr 2022 23:08:03 +0000
Received: by outflank-mailman (input) for mailman id 311826;
 Sat, 23 Apr 2022 23:08:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niOrC-0006Vn-CH; Sat, 23 Apr 2022 23:08:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niOrC-0004QN-62; Sat, 23 Apr 2022 23:08:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niOrB-0005RY-Ms; Sat, 23 Apr 2022 23:08:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niOrB-0006OF-MR; Sat, 23 Apr 2022 23:08:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AopUNQ8Gzj/TUarpfc/y9G0u/tYbO1OOCc80WFt7hVs=; b=E36gymH+dpMDmoUL+d43oBoDl+
	ll/E4FDCEqsvftk5sClLktBOE+im7QPK6IG31WRxkNDIxFTjGEQA4rtxyWmErb1r9o1bcR6VGvROH
	O59aaQ7mv+fCDc+uh8RZ20A5Iu85RC28+OtS7Hu3ESqlKJYOYEps3L4qiMmS54OoltJ8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169660-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169660: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 23:08:01 +0000

flight 169660 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169660/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  582 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   24 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 23 23:44:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Apr 2022 23:44:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311835.529100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niPQD-00031N-S1; Sat, 23 Apr 2022 23:44:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311835.529100; Sat, 23 Apr 2022 23:44:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niPQD-00031G-P1; Sat, 23 Apr 2022 23:44:13 +0000
Received: by outflank-mailman (input) for mailman id 311835;
 Sat, 23 Apr 2022 23:44:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niPQC-000316-89; Sat, 23 Apr 2022 23:44:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niPQC-00053M-5O; Sat, 23 Apr 2022 23:44:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niPQB-0006HD-M1; Sat, 23 Apr 2022 23:44:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niPQB-0001eF-LY; Sat, 23 Apr 2022 23:44:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TDZP0g7dlpsEI/e1btCFW0tEfVbBocNG5juuWHZhJPE=; b=ptoQBLo0jYDKiuby/h2fRSk9ys
	H4tIuzCAnaACYnue8BaVPo5VGbak+DG892xdtuBcO0H83IwaQN7QVATxR3l02CmwqIrlAsfFGyu+i
	nV+0bR9d8y5Osahz1WZpK77i3pX8rBhKKlqw72OZLWHhdEn5pwORGKgzDwSsVXI2A7Ys=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169661-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169661: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Apr 2022 23:44:11 +0000

flight 169661 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169661/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  583 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   25 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 00:52:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 00:52:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311851.529111 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niQU2-0003WS-UX; Sun, 24 Apr 2022 00:52:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311851.529111; Sun, 24 Apr 2022 00:52:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niQU2-0003WL-RP; Sun, 24 Apr 2022 00:52:14 +0000
Received: by outflank-mailman (input) for mailman id 311851;
 Sun, 24 Apr 2022 00:52:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niQU0-0003WB-Ls; Sun, 24 Apr 2022 00:52:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niQU0-0006nJ-If; Sun, 24 Apr 2022 00:52:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niQU0-0007oF-4j; Sun, 24 Apr 2022 00:52:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niQU0-0000Hj-4D; Sun, 24 Apr 2022 00:52:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+9lSwN4gFLJo/QFNM+xLQr6eappb8c80yzKeSkfh0bA=; b=ZC0tECFk7hX02kEwgNtwPhFfN3
	8oc1knRpOqYJ/7ZOpnzOcMNhMQa6K3Rt5gCup4HCFG+tUf4ZSiN3eqJhoDzjZo5ecPFUFqprCyQsA
	JZf8fv5whj2KZ4lP/VeHDClQrO5CRG+apzHkVUzjtCtWRlnWCLvTT6mAYoBhdmGWTS/0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169654-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169654: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-vhd:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=45ab9400e73f34103e73c18a73280c9aa1650e98
X-Osstest-Versions-That:
    linux=c00c5e1d157bec0ef0b0b59aa5482eb8dc7e8e49
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 00:52:12 +0000

flight 169654 linux-linus real [real]
flight 169662 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169654/
http://logs.test-lab.xenproject.org/osstest/logs/169662/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw  8 xen-boot            fail pass in 169662-retest
 test-amd64-amd64-xl-vhd   19 guest-localmigrate/x10 fail pass in 169662-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 169662 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 169662 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169638
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169638
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169638
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169638
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169638
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169638
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169638
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169638
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                45ab9400e73f34103e73c18a73280c9aa1650e98
baseline version:
 linux                c00c5e1d157bec0ef0b0b59aa5482eb8dc7e8e49

Last test of basis   169638  2022-04-23 03:15:15 Z    0 days
Testing same since   169654  2022-04-23 17:09:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Arnaldo Carvalho de Melo <acme@redhat.com>
  German Gomez <german.gomez@arm.com>
  Guilherme Amadio <amadio@gentoo.org>
  Herbert Xu <herbert@gondor.apana.org.au>
  Leo Yan <leo.yan@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Randy Dunlap <rdunlap@infradead.org>
  Sam Ravnborg <sam@ravnborg.org>
  Sumanth Korikkar <sumanthk@linux.ibm.com>
  Thomas Richter <tmricht@linux.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   c00c5e1d157b..45ab9400e73f  45ab9400e73f34103e73c18a73280c9aa1650e98 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 00:58:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 00:58:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311859.529121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niQaP-0004As-Kq; Sun, 24 Apr 2022 00:58:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311859.529121; Sun, 24 Apr 2022 00:58:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niQaP-0004Al-I1; Sun, 24 Apr 2022 00:58:49 +0000
Received: by outflank-mailman (input) for mailman id 311859;
 Sun, 24 Apr 2022 00:58:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niQaO-0004Ab-W7; Sun, 24 Apr 2022 00:58:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niQaO-0006un-U3; Sun, 24 Apr 2022 00:58:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niQaO-0007wQ-I8; Sun, 24 Apr 2022 00:58:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niQaO-0003U0-Hf; Sun, 24 Apr 2022 00:58:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oyDRL0lM6Qt4wQ4qGEFBakbQOxuCW9qRIH6Vu0J79/E=; b=4i6usxwzrGCKiDN2GrKedeLaqP
	FMAK6BsBB0uIZAfyIgxL4B9Huxn/eaRLlLsEYbNFj3oOvscmO8CxLC7/ilWFYxJNeH6MCtx+dJqvQ
	eNkgKYnJYT5MDJ5MmPEvJGxgovk2Wp1gA4b7Wnn3hgb03QVdxuXlP0roqPLnfaHZWLdY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169663-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169663: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 00:58:48 +0000

flight 169663 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169663/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   53 days  584 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   26 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 02:05:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 02:05:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311870.529133 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niRck-0002cQ-Lp; Sun, 24 Apr 2022 02:05:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311870.529133; Sun, 24 Apr 2022 02:05:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niRck-0002cG-Fv; Sun, 24 Apr 2022 02:05:18 +0000
Received: by outflank-mailman (input) for mailman id 311870;
 Sun, 24 Apr 2022 02:05:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niRci-0002c6-VF; Sun, 24 Apr 2022 02:05:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niRci-0006Me-TU; Sun, 24 Apr 2022 02:05:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niRci-0002NS-D9; Sun, 24 Apr 2022 02:05:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niRci-0001ea-Ch; Sun, 24 Apr 2022 02:05:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZsDaZNqkQFvN0CGhxIDiGO1mIIhh1hVZwGiQZ9t4L2c=; b=ucuXaG6xSGTRBtb6yAYlhVWNBK
	HX5I76Qz36Pj0vG1WTCwcYmkcweVRPfJqivDQQGJLaWgo/wQ79rEGMa2retIn3H0XDNjnU19anLwi
	aXujbFnwHReDSgdbZ38/06Ok7oN+bAUcF63XqGOlHtMhr0yn3Zw5W2DjK1EqBgBC3cks=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169665-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169665: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 02:05:16 +0000

flight 169665 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169665/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  585 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   27 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 04:01:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 04:01:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311897.529143 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niTR1-0007n3-Ua; Sun, 24 Apr 2022 04:01:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311897.529143; Sun, 24 Apr 2022 04:01:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niTR1-0007mw-Rj; Sun, 24 Apr 2022 04:01:19 +0000
Received: by outflank-mailman (input) for mailman id 311897;
 Sun, 24 Apr 2022 04:01:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niTR0-0007mm-NZ; Sun, 24 Apr 2022 04:01:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niTR0-0008No-L3; Sun, 24 Apr 2022 04:01:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niTR0-0006t4-7m; Sun, 24 Apr 2022 04:01:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niTR0-0004EW-7M; Sun, 24 Apr 2022 04:01:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=SBl4uItaVKCHIjCIO4T0wKdy7ALYSdz6BioPzVBK0Z4=; b=5i/989eB6eTNXz0gZYNS2Rx16q
	/Ob6LjddJHu7EpHuDAJbU9n+1YP+nSprca+lEEm7fP7R1IMu+bGlKCG9IYyGhC9yktFVUfZDB2MUI
	vrZrU7rEzbPZm+fIP4QkR/pgRPxk+AigyV5GySfFZIdhA+pPkAn3mNt/EwHxyI4zWVCs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169667-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169667: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 04:01:18 +0000

flight 169667 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169667/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  586 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   28 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 05:41:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 05:41:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311908.529155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niUzr-00031v-7A; Sun, 24 Apr 2022 05:41:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311908.529155; Sun, 24 Apr 2022 05:41:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niUzr-00031o-4D; Sun, 24 Apr 2022 05:41:23 +0000
Received: by outflank-mailman (input) for mailman id 311908;
 Sun, 24 Apr 2022 05:41:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niUzp-00031e-FL; Sun, 24 Apr 2022 05:41:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niUzp-000270-CH; Sun, 24 Apr 2022 05:41:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niUzo-0004kh-SB; Sun, 24 Apr 2022 05:41:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niUzo-0003Gr-Rm; Sun, 24 Apr 2022 05:41:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RZ5YUNbE9FTrNd9GCqv+Ghcy7rKLboLmkvQ4bKqyYsM=; b=nyouvTWjHLgjuSWTsDDHpLGbWM
	irVKbBx3U9P6kV7eGRbx8DCv/HeYsyM6Wu5ra67C+yxq5ywisRC+MENEUmpfrg+kiDeWgnGYy8cy9
	bSa++TXlPiJJhc401I2jERFLy9s7eyxKlVgtAppodxgKhfhtHYd4ouqp1UFvWUkR46lg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169668-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169668: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 05:41:20 +0000

flight 169668 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169668/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  587 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   29 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 07:56:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 07:56:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311945.529165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niX5u-0001Cl-F7; Sun, 24 Apr 2022 07:55:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311945.529165; Sun, 24 Apr 2022 07:55:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niX5u-0001Ce-BZ; Sun, 24 Apr 2022 07:55:46 +0000
Received: by outflank-mailman (input) for mailman id 311945;
 Sun, 24 Apr 2022 07:55:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niX5t-0001CU-HT; Sun, 24 Apr 2022 07:55:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niX5t-0004SW-Ej; Sun, 24 Apr 2022 07:55:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niX5t-0002uQ-0p; Sun, 24 Apr 2022 07:55:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niX5t-0007t5-0M; Sun, 24 Apr 2022 07:55:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fQ6jgCObapymPzi8e0KJXFdNvO67r1Rg3tXpmL6hHUM=; b=Atd9b+amsRyeqJunSkmnAEdWpZ
	yilyRpfnpYqYRvY/j5YEP2jZI3wYB/HjY2OZIzn3Yf2YRu3qaiW9xkJDra0RSrV4Xwb/BOgX7xkqb
	N3e7qUYcrGBWGXBI1y5F1HjioDDBwRlWRP7XsAfHWHtGNoCUexaenk/k2EwNW9b44vfg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169664-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169664: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=22da5264abf497a10a4ed629f07f4ba28a7ed5eb
X-Osstest-Versions-That:
    linux=45ab9400e73f34103e73c18a73280c9aa1650e98
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 07:55:45 +0000

flight 169664 linux-linus real [real]
flight 169671 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169664/
http://logs.test-lab.xenproject.org/osstest/logs/169671/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 169671-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169654
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169654
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169654
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169654
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169654
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169654
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169654
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169654
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                22da5264abf497a10a4ed629f07f4ba28a7ed5eb
baseline version:
 linux                45ab9400e73f34103e73c18a73280c9aa1650e98

Last test of basis   169654  2022-04-23 17:09:53 Z    0 days
Testing same since   169664  2022-04-24 01:09:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Bang Li <libang.linuxer@gmail.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Boris Ostrovsky <boris.ostrovsky@oracle.com>
  Christian König <christian.koenig@amd.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Coly Li <colyli@suse.de>
  Dave Airlie <airlied@redhat.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Jens Axboe <axboe@kernel.dk>
  Julia Lawall <Julia.Lawall@inria.fr>
  Karol Herbst <kherbst@redhat.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Maxime Ripard <maxime@cerno.tech>
  Miaoqian Lin <linmq006@gmail.com>
  Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com> (v1)
  Namjae Jeon <linkinjeon@kernel.org>
  Paul Kocialkowski <paul.kocialkowski@bootlin.com>
  Pavel Begunkov <asml.silence@gmail.com>
  Rolf Eike Beer <eb@emlix.com>
  Sergey Matyukevich <sergey.matyukevich@synopsys.com>
  Shelby Heffron <Shelby.Heffron@garmin.com>
  Stefan Wahren <stefan.wahren@i2se.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Steve French <stfrench@microsoft.com>
  Tom Rix <trix@redhat.com>
  Vineet Gupta <vgupta@kernel.org>
  Zack Rusin <zackr@vmware.com>
  Zheng Bin <zhengbin13@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   45ab9400e73f..22da5264abf4  22da5264abf497a10a4ed629f07f4ba28a7ed5eb -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 07:56:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 07:56:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311950.529177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niX6J-0001gv-Si; Sun, 24 Apr 2022 07:56:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311950.529177; Sun, 24 Apr 2022 07:56:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niX6J-0001fu-Ox; Sun, 24 Apr 2022 07:56:11 +0000
Received: by outflank-mailman (input) for mailman id 311950;
 Sun, 24 Apr 2022 07:56:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niX6I-0001eF-SE; Sun, 24 Apr 2022 07:56:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niX6I-0004Sx-RI; Sun, 24 Apr 2022 07:56:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niX6I-0002uy-Fi; Sun, 24 Apr 2022 07:56:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niX6I-0008MV-FH; Sun, 24 Apr 2022 07:56:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6qqLavX7Bzzgc6g8OLsQXai42UkiK8KIPZ2mIdOcW5s=; b=ZzdfwFbZ3PxvD3XJXYuyEF4++1
	m0Vj//NbM2vWlHT3pSz6LiB/Hv0o61fLaslRLx9auGuisxmWWrwNd58rLWDPYdLu6fKWYZjy54NfR
	xRixhefpN7KCB88K3DJ+wdLBkJsEPRpy25KcnYkl3p4AJXd5E+9jEwKWAVG7Qw5AxlSQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169670-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169670: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 07:56:10 +0000

flight 169670 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169670/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  588 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   30 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 08:31:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 08:31:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311971.529188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niXe5-0007Pl-Tv; Sun, 24 Apr 2022 08:31:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311971.529188; Sun, 24 Apr 2022 08:31:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niXe5-0007Pe-Q5; Sun, 24 Apr 2022 08:31:05 +0000
Received: by outflank-mailman (input) for mailman id 311971;
 Sun, 24 Apr 2022 08:31:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niXe4-0007PU-G1; Sun, 24 Apr 2022 08:31:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niXe4-0005cu-Cm; Sun, 24 Apr 2022 08:31:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niXe4-0004PQ-1l; Sun, 24 Apr 2022 08:31:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niXe4-00030U-1O; Sun, 24 Apr 2022 08:31:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YwzJ3JHf7LkwP1fKP4CXPdVzlEcrXWnXaA4AdOGG3Qc=; b=uudAHARsCcl7iBraOapqfCSMrJ
	oJtgF5tyEeHVW20WdjpyB2scoj5xMuAukc3z7lxsEXFLLTfrFRUm4f5Dq+jtmiscGhU97WH8GftMV
	2IDnTt2SXWDMpEcQos0vVlwN1fmRW7C6UjLPnxoZLtTgWEyfitTsm5qjmbKCTZSqFA30=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169672-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169672: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 08:31:04 +0000

flight 169672 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169672/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  589 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   31 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 09:31:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 09:31:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311985.529199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niYaW-00062n-Fo; Sun, 24 Apr 2022 09:31:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311985.529199; Sun, 24 Apr 2022 09:31:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niYaW-00062g-CY; Sun, 24 Apr 2022 09:31:28 +0000
Received: by outflank-mailman (input) for mailman id 311985;
 Sun, 24 Apr 2022 09:31:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYaV-00062W-0m; Sun, 24 Apr 2022 09:31:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYaU-0006dR-SO; Sun, 24 Apr 2022 09:31:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYaU-00060Q-HB; Sun, 24 Apr 2022 09:31:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niYaU-0002CU-Gl; Sun, 24 Apr 2022 09:31:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bILqxSFELssNsuNMEZzJNN+PYuzeyG8W//COlBawd0o=; b=Zv/pQk04fPAPgAn2Rur/Q9vIJi
	14I1vNbpKSJNR6vPrk73oc4SjrnNx42H+QJLD314lHpywe5SH2QQwZkubyOpj1xqt7G4P7AnjcM8A
	wvd5DxlUqPXfrSpPiD9X97JIfg9g9Ma39JrpDaBcTKf3Oqs1k2l3Kuxe8zvYLIR6ON70=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169673-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169673: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 09:31:26 +0000

flight 169673 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169673/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  590 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   32 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 09:40:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 09:40:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.311999.529210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niYjg-0007tP-Ec; Sun, 24 Apr 2022 09:40:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 311999.529210; Sun, 24 Apr 2022 09:40:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niYjg-0007tI-Au; Sun, 24 Apr 2022 09:40:56 +0000
Received: by outflank-mailman (input) for mailman id 311999;
 Sun, 24 Apr 2022 09:40:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYjf-0007t8-H9; Sun, 24 Apr 2022 09:40:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYjf-0006mx-Ae; Sun, 24 Apr 2022 09:40:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYje-0006D5-S8; Sun, 24 Apr 2022 09:40:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niYje-0003yk-Rg; Sun, 24 Apr 2022 09:40:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/BSGK+odyu3dbCzcL71RLoyLoCRIV7hBkk5bibYO46g=; b=tzgZ1xUX/tJRS/YSu+qxowG49u
	frMqVtbjb2ja1nX7WDtohDNDLjQkRPPGhy5682ihaF+ldp9JOsElfflMe2BX7hYDXLliu++0vlfyC
	NlrXJPBeFMcZ9gecuC3miaT0OTvyS4va78UQLKH4e5RzqCkRo7o328Z5aJZqD2I6pJ3A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169666-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169666: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
X-Osstest-Versions-That:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 09:40:54 +0000

flight 169666 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169666/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-arndale   8 xen-boot         fail in 169635 pass in 169666
 test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail in 169635 pass in 169666
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail pass in 169635

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169635
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169635
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169635
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169635
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169635
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169635
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169635
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169635
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169635
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169635
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169635
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169635
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08
baseline version:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08

Last test of basis   169666  2022-04-24 01:52:28 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Apr 24 09:42:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 09:42:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312006.529220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niYkj-0000GZ-Sh; Sun, 24 Apr 2022 09:42:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312006.529220; Sun, 24 Apr 2022 09:42:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niYkj-0000GS-Pj; Sun, 24 Apr 2022 09:42:01 +0000
Received: by outflank-mailman (input) for mailman id 312006;
 Sun, 24 Apr 2022 09:42:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYki-0000GG-Bh; Sun, 24 Apr 2022 09:42:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYki-0006nq-9x; Sun, 24 Apr 2022 09:42:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niYkh-0006G6-Nj; Sun, 24 Apr 2022 09:41:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niYkh-0004Z1-NF; Sun, 24 Apr 2022 09:41:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YHb1WFfsWsw9Dlte/AN78Xa8TKisp3ddF7ZtHCiNmV0=; b=PCAT6VAWPktUdGnsmn+w3WsOBP
	qZD0ftX0/WoSeGCorayRk7OejAl8sQtFbOy46nKFF+yIHiksvTJJvRdMZVPkYdsS0V6ELAs4AOv3n
	LfQnFZVHKCrTHN3guxR0M9cB2o80ugJOwfRajEjnsFWENLsyuhwGk4tPE0Ti55bgPnKg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169669-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169669: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=de0a50833f91ad934d5492125b2d636c86a87140
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 09:41:59 +0000

flight 169669 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169669/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              de0a50833f91ad934d5492125b2d636c86a87140
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  653 days
Failing since        151818  2020-07-11 04:18:52 Z  652 days  634 attempts
Testing same since   169640  2022-04-23 04:18:54 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 105272 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 10:03:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 10:03:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312016.529232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niZ4y-00039S-Mm; Sun, 24 Apr 2022 10:02:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312016.529232; Sun, 24 Apr 2022 10:02:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niZ4y-00039L-JG; Sun, 24 Apr 2022 10:02:56 +0000
Received: by outflank-mailman (input) for mailman id 312016;
 Sun, 24 Apr 2022 10:02:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niZ4x-00039B-LC; Sun, 24 Apr 2022 10:02:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niZ4x-0007Fj-I2; Sun, 24 Apr 2022 10:02:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niZ4x-0006hh-Al; Sun, 24 Apr 2022 10:02:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niZ4x-0001V8-AI; Sun, 24 Apr 2022 10:02:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5zPmkfZCtN1x7vZ+tWiLy1QRS/cF3e/odSgYerWB0p4=; b=YaZrlAYAv3j222bu1W4iBT3ksN
	lcv7SNf5Ge2p264BQa8SjVavYDq5KxkpLwNdWXhkLNqITJu6wwhZ8JYyZbh9VsLgmXiCCovMRe2Uu
	bpzf6GTKXF2FdbrSRIR3kW3U3vL07zArmddhIA4tsYpwNIWsZIj5pOwA/vbiOyyutIhg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169674-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169674: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 10:02:55 +0000

flight 169674 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169674/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  591 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   33 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 10:29:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 10:29:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312026.529243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niZUb-00062g-S8; Sun, 24 Apr 2022 10:29:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312026.529243; Sun, 24 Apr 2022 10:29:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niZUb-00062Z-P3; Sun, 24 Apr 2022 10:29:25 +0000
Received: by outflank-mailman (input) for mailman id 312026;
 Sun, 24 Apr 2022 10:29:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niZUa-00062P-5Q; Sun, 24 Apr 2022 10:29:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niZUa-0007jn-4M; Sun, 24 Apr 2022 10:29:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niZUZ-0007Gr-Og; Sun, 24 Apr 2022 10:29:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niZUZ-0000KG-OD; Sun, 24 Apr 2022 10:29:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kXzHLh5wuRmH+n8IqW7wrrLjRk/W4cZ64m3hHYob5q0=; b=C5vub1fX39Se+VggbvDwTCrD4R
	Ts5a+WcwJ9C+WgF2WQNPLbp2zh3DPSV7/rP5hxHl6Tqt02iDrZzVSQKEGzZNdw16REBZhhOm9pvsI
	01zZgCZ2fffhfHYfsGSI6Uebihi7m34GoVU9QaPnud2/teXS1ZeTsMMCvfQeCzYIAhY0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169675-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169675: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 10:29:23 +0000

flight 169675 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169675/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   54 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  592 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   34 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 11:19:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 11:19:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312042.529253 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niaGd-0003ce-MB; Sun, 24 Apr 2022 11:19:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312042.529253; Sun, 24 Apr 2022 11:19:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niaGd-0003cX-JE; Sun, 24 Apr 2022 11:19:03 +0000
Received: by outflank-mailman (input) for mailman id 312042;
 Sun, 24 Apr 2022 11:19:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niaGb-0003cN-HR; Sun, 24 Apr 2022 11:19:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niaGb-00009R-Fp; Sun, 24 Apr 2022 11:19:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niaGb-0008LB-4C; Sun, 24 Apr 2022 11:19:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niaGb-0001p9-3j; Sun, 24 Apr 2022 11:19:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dX3PuENtCmWZ117u8sWkCymJqKfsXgxwSwyxJp15+ho=; b=HfnYO6fPizYkXj7ik7MpT9yb8t
	MGU5FFrj9ENCwtCpm2claBU3cKixc6EW9IqWuQVdMn+0SFaxzJTR/8eifYBlNlLPy0D5B1Baf9lVC
	cgZ4vd++6+OIBHlgCL0F0BjdFPDrZc7pFOR+rCz1aJ0GTcKuEu34HOCNYGTLlMlTpvU0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169676-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169676: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 11:19:01 +0000

flight 169676 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169676/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  593 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   35 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 12:16:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 12:16:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312059.529265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nib9o-0002HI-9f; Sun, 24 Apr 2022 12:16:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312059.529265; Sun, 24 Apr 2022 12:16:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nib9o-0002HB-4w; Sun, 24 Apr 2022 12:16:04 +0000
Received: by outflank-mailman (input) for mailman id 312059;
 Sun, 24 Apr 2022 12:16:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nib9n-0002Gx-2c; Sun, 24 Apr 2022 12:16:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nib9m-0001Ci-Iu; Sun, 24 Apr 2022 12:16:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nib9m-00018S-BN; Sun, 24 Apr 2022 12:16:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nib9m-00076X-Ax; Sun, 24 Apr 2022 12:16:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=c1v7w/gcSdHce4s61AA9eTX6zgDtl+BVClJP+ROW8mw=; b=eLGv9GdUIhCeegVFakxLG4E3WX
	xpRolcBoxq2ffhF+aI/tKi8YvhSU8nbc+BHOs11jMEOb4ZVLB0kikCRe529Kakuuo45QDwUwq9ju+
	pmUXIrz+UOHV1XDfsv7eWmRC5Qjd8oUYvQFfGz3PL293/z9//ytwwcNr1of/1i9YEHq0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169677-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169677: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 12:16:02 +0000

flight 169677 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169677/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  594 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   36 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 13:01:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 13:01:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312070.529275 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nibrG-0007wG-Mo; Sun, 24 Apr 2022 13:00:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312070.529275; Sun, 24 Apr 2022 13:00:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nibrG-0007w9-Jw; Sun, 24 Apr 2022 13:00:58 +0000
Received: by outflank-mailman (input) for mailman id 312070;
 Sun, 24 Apr 2022 13:00:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nibrF-0007vz-5j; Sun, 24 Apr 2022 13:00:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nibrF-00023j-3v; Sun, 24 Apr 2022 13:00:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nibrE-00026h-Mq; Sun, 24 Apr 2022 13:00:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nibrE-0001bi-MQ; Sun, 24 Apr 2022 13:00:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hgkKchMqbYgixhoJdJ1JZ/0SLu6WaIaxq80bkILaKZQ=; b=FsDYddw75rm/aXg2HeXNex3qtJ
	kVc66lZU/Gc3KhbEQ4Y6eDqhy96va8Pq6hUcJAy/T4J9ofbgGhDf5VL32XGNZ9IRN5QSrixmBiClo
	W/1cUkW0F/pLoudn9r6m2tx/LzSvrIviRTTe73272wOEBFSaWBlBdwAG17/ZE3+OHeKQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169678-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169678: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 13:00:56 +0000

flight 169678 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169678/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  595 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   37 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 13:31:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 13:31:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312079.529287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nicKT-0003GE-2k; Sun, 24 Apr 2022 13:31:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312079.529287; Sun, 24 Apr 2022 13:31:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nicKS-0003G7-W3; Sun, 24 Apr 2022 13:31:08 +0000
Received: by outflank-mailman (input) for mailman id 312079;
 Sun, 24 Apr 2022 13:31:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nicKR-0003Fx-JL; Sun, 24 Apr 2022 13:31:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nicKR-0002YU-Du; Sun, 24 Apr 2022 13:31:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nicKR-0002kw-03; Sun, 24 Apr 2022 13:31:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nicKQ-0000TN-Vs; Sun, 24 Apr 2022 13:31:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uTqc1j5PSfvbvFxB4Um2AJ1tFgUudrtuB4YS9Yn365w=; b=t1+8YEdPIVNg8rXvOwpuTFjjYL
	v6vrJxm67pZhO/Fy0+JSXmFPEKVlWTq63ORDfAMs4oFjLwzt4p55X8JUIgjPYvFUXyqK5tq7xF7IT
	5xNqlg0XyRV257zRV8slKrcEw7qyfTJZB1iYmcTzYb828nlgrt/AjhDCldVIdSAaKot8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169679-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169679: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 13:31:06 +0000

flight 169679 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169679/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  596 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   38 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 14:35:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 14:35:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312102.529298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nidKX-000242-QT; Sun, 24 Apr 2022 14:35:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312102.529298; Sun, 24 Apr 2022 14:35:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nidKX-00023v-NE; Sun, 24 Apr 2022 14:35:17 +0000
Received: by outflank-mailman (input) for mailman id 312102;
 Sun, 24 Apr 2022 14:35:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nidKW-00023l-9y; Sun, 24 Apr 2022 14:35:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nidKW-0003gi-5j; Sun, 24 Apr 2022 14:35:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nidKV-000499-Pz; Sun, 24 Apr 2022 14:35:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nidKV-0007Sb-PX; Sun, 24 Apr 2022 14:35:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=F8zMeO+KGsuBFClMefCFhoFrgg7fPWkpTjAsdt1mJ5E=; b=SQVnWxcgWeXPaZNcX0LcTjcfBh
	9uotSvBC2OFzkGXd1029O18DIArnhtiUZYX2p2aRafbY43ePJsWTVtKkskm0itSc0i3L8ZL9osWJ/
	4JqsvvZDkpUpBGW4Pf8kZcnDSJWQCfSnZcuPQN9FTsYrfQlxFASnNYb4mj4NVxHgTD2Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169680-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169680: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 14:35:15 +0000

flight 169680 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169680/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  597 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   39 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 14:44:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 14:44:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312112.529309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nidTJ-0003l3-Sy; Sun, 24 Apr 2022 14:44:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312112.529309; Sun, 24 Apr 2022 14:44:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nidTJ-0003kw-Or; Sun, 24 Apr 2022 14:44:21 +0000
Received: by outflank-mailman (input) for mailman id 312112;
 Sun, 24 Apr 2022 14:44:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZwHJ=VC=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1nidTI-0003kq-QO
 for xen-devel@lists.xenproject.org; Sun, 24 Apr 2022 14:44:20 +0000
Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com
 [2607:f8b0:4864:20::62f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 05083a5f-c3dd-11ec-8fc2-03012f2f19d4;
 Sun, 24 Apr 2022 16:44:19 +0200 (CEST)
Received: by mail-pl1-x62f.google.com with SMTP id b12so6715211plg.4
 for <xen-devel@lists.xenproject.org>; Sun, 24 Apr 2022 07:44:19 -0700 (PDT)
Received: from localhost ([118.33.58.98]) by smtp.gmail.com with ESMTPSA id
 o189-20020a62cdc6000000b0050d3d606538sm1027651pfg.25.2022.04.24.07.44.16
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 24 Apr 2022 07:44:17 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05083a5f-c3dd-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition;
        bh=95y6zSa4Tw7B58PQxi0n0y875m0i99N3ZRZMzlGKgCU=;
        b=a2JyL0mibelfR7CaCfHyARbdi6Tkmd/5RBwRzBaO7CA6//5/Ik13wFiJO0aCEZ6Ln4
         WOQP2xB8NRPYrxN8RTDJq4WktDypzyNlei+Cb8j9ONpXG/A7v+qP++GhREr/r5wVbKKg
         s3rk6PgdHwADCzXAhiqK6goAqNlwY2kjVpEPC162k6EG2qxtHW4zNbanWirn43+xWcqq
         y3QeUE/9hTTPvIpBnsGbbhvNpN7z9/U4atZYKjqabGRpQPRCOj52qLrF0hslnO6SJUbD
         ljiUPTGAOHr3lA1f5vtnjVmBqLXJzIVJocS4FRwgQj9NaXDk4eGEPAuSf9jV3JxddEMi
         rbMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition;
        bh=95y6zSa4Tw7B58PQxi0n0y875m0i99N3ZRZMzlGKgCU=;
        b=w2CFUYNpXjwNmDoWy7yKvZOOfEcY8FBxEJQDa5mpnROe5NI7dvheBdov534D8Dsoz2
         3lBAZJA+KXaQfQrLW6scxSghcK0b3tBD65tUfeuDBy+UjpRpqax7pnATKcdBXhoFbpt7
         aTejIJLeexgxJ89rAR3pQU6OmDd+TVO8R+xacK6J1532liNli7WGf/eu5OsbUBNNM0U2
         PHb3Ex/AKFt4aPzgvRsKbVNeeukz74BoZDtHFAk8rDbqR9ZdhItO52Mt1KeAUX1oIKOF
         W6ZlPje/EoOxvkz9zFeZJACHBku95i2vYSFUcsxo6KQgVlfvQIUPlzXpAIpcM4IclkfW
         dK2g==
X-Gm-Message-State: AOAM531dIWmwbEzbIpIrnhEz3wJsaGE8YaQDYZbMQIq+SWaUPF+8NX79
	C/e5BLb6dVEETgGTE/PEe0c=
X-Google-Smtp-Source: ABdhPJzwZAQcoucPBWROp0IJC9Bs9FMsSpoWPjnqHrWvbhIZ4nr1j1S8iQeYGldkqwcKFrcNy5j3+w==
X-Received: by 2002:a17:90a:fd85:b0:1d9:6281:d158 with SMTP id cx5-20020a17090afd8500b001d96281d158mr2421912pjb.187.1650811457440;
        Sun, 24 Apr 2022 07:44:17 -0700 (PDT)
Date: Sun, 24 Apr 2022 23:44:14 +0900
From: Paran Lee <p4ranlee@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
Subject: [PATCH] xen/efi: boot fix duplicated index, offset calculate
 operation in the copy_mapping loop
Message-ID: <20220424144414.GA17868@DESKTOP-NK4TH6S.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

It doesn't seem necessary to do that
duplicated calculation of mfn to addr and l4 table index
in the copy_mapping loop.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 xen/common/efi/boot.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index ac1b235372..7da4269c32 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1470,7 +1470,9 @@ static __init void copy_mapping(unsigned long mfn, unsigned long end,
 
     for ( ; mfn < end; mfn = next )
     {
-        l4_pgentry_t l4e = efi_l4t[l4_table_offset(mfn << PAGE_SHIFT)];
+        unsigned long addr = mfn << PAGE_SHIFT;
+        unsigned long l4_table_idx = l4_table_offset(addr);
+        l4_pgentry_t l4e = efi_l4t[l4_table_idx];
         unsigned long va = (unsigned long)mfn_to_virt(mfn);
 
         if ( !(mfn & ((1UL << (L4_PAGETABLE_SHIFT - PAGE_SHIFT)) - 1)) )
@@ -1489,7 +1491,7 @@ static __init void copy_mapping(unsigned long mfn, unsigned long end,
 
             l3dst = alloc_mapped_pagetable(&l3mfn);
             BUG_ON(!l3dst);
-            efi_l4t[l4_table_offset(mfn << PAGE_SHIFT)] =
+            efi_l4t[l4_table_idx] =
                 l4e_from_mfn(l3mfn, __PAGE_HYPERVISOR);
         }
         else
@@ -1497,7 +1499,7 @@ static __init void copy_mapping(unsigned long mfn, unsigned long end,
 
         if ( !l3src )
             l3src = map_l3t_from_l4e(idle_pg_table[l4_table_offset(va)]);
-        l3dst[l3_table_offset(mfn << PAGE_SHIFT)] = l3src[l3_table_offset(va)];
+        l3dst[l3_table_offset(addr)] = l3src[l3_table_offset(va)];
     }
 
     unmap_domain_page(l3src);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sun Apr 24 15:12:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 15:12:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312137.529320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nidu7-0007Y2-2I; Sun, 24 Apr 2022 15:12:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312137.529320; Sun, 24 Apr 2022 15:12:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nidu6-0007Xv-VV; Sun, 24 Apr 2022 15:12:02 +0000
Received: by outflank-mailman (input) for mailman id 312137;
 Sun, 24 Apr 2022 15:12:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nidu5-0007Xl-HR; Sun, 24 Apr 2022 15:12:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nidu5-0004KE-9J; Sun, 24 Apr 2022 15:12:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nidu4-0004x2-Su; Sun, 24 Apr 2022 15:12:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nidu4-0006lb-SQ; Sun, 24 Apr 2022 15:12:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZZ7W0RiuX1kHkwOuj2HDJ0sj2cqfx95UG7hCpykk6G8=; b=4/rQsXtSLiUBAfT/yPfKzfmw0e
	bMzRjPMKWtTpaiAuPDKPE8aDbZEDTIdSqNA5jmuzz50wNqG36KWP7F2C3CDZC+6d3jOPvZ1WnVEM+
	4V198zA8uFrGP2UY++fYqbdF3b4fHGKVPE8t3RUMT+WZdVClbp1lIB5r0Nquan3Iw1gk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169681-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169681: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 15:12:00 +0000

flight 169681 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169681/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  598 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   40 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 15:46:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 15:46:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312151.529331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nieRF-0002tB-M6; Sun, 24 Apr 2022 15:46:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312151.529331; Sun, 24 Apr 2022 15:46:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nieRF-0002t4-JA; Sun, 24 Apr 2022 15:46:17 +0000
Received: by outflank-mailman (input) for mailman id 312151;
 Sun, 24 Apr 2022 15:46:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nieRF-0002sy-3z
 for xen-devel@lists.xenproject.org; Sun, 24 Apr 2022 15:46:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nieRC-0004vr-5Z; Sun, 24 Apr 2022 15:46:14 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nieRB-0002SI-Vz; Sun, 24 Apr 2022 15:46:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=YdywgbeFh9usAAic3yJ/a3BdO5PaskS+FhaLbPIad5I=; b=6IEkDn7QSR/3Len5p0Lqe2Le9d
	rXM6tYI/pnQw8KY8WyeWKgS84aEGoT0w88Da/20citgVY6AHFSZKDmk9pE2VOx9ZMI4TAwoDgZ379
	ZeiFwwOURiE0t6koFpbbqyhdgewzDmi2mMZRHiOhD9dynsvB2TaGPeeNqEpc/oSJZMFQ=;
Message-ID: <ea06f2ac-4ac1-4a6f-bda6-e775a7e68699@xen.org>
Date: Sun, 24 Apr 2022 16:46:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: Paran Lee <p4ranlee@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
References: <20220422185251.GA7124@DESKTOP-NK4TH6S.localdomain>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH] xen/arm: fdt fix duplicated ternary operator, shift
 operations
In-Reply-To: <20220422185251.GA7124@DESKTOP-NK4TH6S.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 22/04/2022 19:52, Paran Lee wrote:
> It doesn't seem necessary to do duplicate ternary operation and calculation
> of order shift using fdt32_to_cpu macro.
> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> ---
>   xen/arch/arm/bootfdt.c  | 12 ++++++++++--
>   xen/common/libfdt/fdt.c | 10 +++++-----
>   2 files changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index e318ef9603..e5b885a7f2 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -159,8 +159,16 @@ int __init device_tree_for_each_node(const void *fdt, int node,
>               continue;
>           }
>   
> -        as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
> -        ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
> +        if ( depth > 0 )
> +        {
> +            as = address_cells[depth-1];
> +            ss = size_cells[depth-1];
> +        }
> +        else
> +        {
> +            as = DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
> +            ss = DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
> +        }
IHMO the original code is easier to read. That said, in the two cases, I 
think this is a bit pointless to check if the depth is > 0 at every 
iteration because it will mostly be only always true but for one node.

So I would go with the following code (not tested):

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index e318ef960386..a382e10065f9 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -144,10 +144,13 @@ int __init device_tree_for_each_node(const void 
*fdt, int node,
       */
      int depth = 0;
      const int first_node = node;
-    u32 address_cells[DEVICE_TREE_MAX_DEPTH];
-    u32 size_cells[DEVICE_TREE_MAX_DEPTH];
+    u32 address_cells[DEVICE_TREE_MAX_DEPTH + 1];
+    u32 size_cells[DEVICE_TREE_MAX_DEPTH + 1];
      int ret;

+    address_cells[0] = DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
+    size_cells[0] = DT_ROOT_NOT_SIZE_CELLS_DEFAULT;
+
      do {
          const char *name = fdt_get_name(fdt, node, NULL);
          u32 as, ss;
@@ -159,13 +162,13 @@ int __init device_tree_for_each_node(const void 
*fdt, int node,
              continue;
          }

-        as = depth > 0 ? address_cells[depth-1] : 
DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
-        ss = depth > 0 ? size_cells[depth-1] : 
DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
+        as = address_cells[depth];
+        ss = size_cells[depth];

-        address_cells[depth] = device_tree_get_u32(fdt, node,
+        address_cells[depth + 1] = device_tree_get_u32(fdt, node,
                                                     "#address-cells", as);
-        size_cells[depth] = device_tree_get_u32(fdt, node,
-                                                "#size-cells", ss);
+        size_cells[depth + 1] = device_tree_get_u32(fdt, node,
+                                                    "#size-cells", ss);

          /* skip the first node */
          if ( node != first_node )

Any thoughts?

>   
>           address_cells[depth] = device_tree_get_u32(fdt, node,
>                                                      "#address-cells", as);
> diff --git a/xen/common/libfdt/fdt.c b/xen/common/libfdt/fdt.c
> index 9fe7cf4b74..a507169d29 100644
> --- a/xen/common/libfdt/fdt.c
> +++ b/xen/common/libfdt/fdt.c

fdt.c is an (old) verbatim copy from DTC (see [1]). I would rather 
prefer to keep this directory as a verbatim copy because it makes easier 
to sync with the upstream version.

In fact, there are a patch on xen-devel ([1]) to re-sync. So any of your 
changes would be lost. Therefore, please send this change to the DTC 
mailing list. We will pick it up on the next re-sync.

Cheers,

[1] https://github.com/dgibson/dtc
[2] 
https://lore.kernel.org/xen-devel/1636702040-116895-1-git-send-email-fnu.vikram@xilinx.com/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 15:53:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 15:53:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312157.529342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nieXo-0004SV-EE; Sun, 24 Apr 2022 15:53:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312157.529342; Sun, 24 Apr 2022 15:53:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nieXo-0004SO-AE; Sun, 24 Apr 2022 15:53:04 +0000
Received: by outflank-mailman (input) for mailman id 312157;
 Sun, 24 Apr 2022 15:53:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nieXm-0004SI-Qf
 for xen-devel@lists.xenproject.org; Sun, 24 Apr 2022 15:53:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nieXl-000524-OO; Sun, 24 Apr 2022 15:53:01 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nieXl-0002j8-IA; Sun, 24 Apr 2022 15:53:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=fCdHlP4JUGdOgK2VuJATBo5jPRLuWs+P2JtGnZ35zJw=; b=r7Qo3aakDorTGjzYql4DP8DX8I
	8T11xZUdjMo5Dm2RDUiVKss3FrlAF9gBDLS4gBxr9rAYtAZsx1K95whzBoB3EgNR0sQfpa6FHtXlu
	lxbDomtmbdfzo7e/fo0Tt7jM7OPhi6pDpufLfQ99Cskb7O0TvcS3m7bnJGtYvJhMAwYI=;
Message-ID: <c15c5faa-ba5d-4407-e9e8-341f41200d77@xen.org>
Date: Sun, 24 Apr 2022 16:52:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: David Vrabel <dvrabel@cantab.net>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>
References: <20220422153601.967318-1-dvrabel@cantab.net>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3] page_alloc: assert IRQs are enabled in heap alloc/free
In-Reply-To: <20220422153601.967318-1-dvrabel@cantab.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi David,

On 22/04/2022 16:36, David Vrabel wrote:
> From: David Vrabel <dvrabel@amazon.co.uk>
> 
> Heap pages can only be safely allocated and freed with interuupts

typo: s/interuupts/interrupts/

> enabled as they may require a TLB flush which will send IPIs.

We don't have such requirements on Arm. Given this is common code, I 
think we should write "which may send IPIs on some architectures (such 
as x86).

That said, I think the change is still a good move on Arm because I 
don't think it is sane to do allocation with interrupts disabled.

> 
> Normally spinlock debugging would catch calls from the incorrect
> context, but not from stop_machine_run() action functions as these are
> called with spin lock debugging disabled.
> 
> Enhance the assertions in alloc_xenheap_pages() and
> alloc_domheap_pages() to check interrupts are enabled. For consistency
> the same asserts are used when freeing heap pages.
> 
> As an exception, when only 1 PCPU is online, allocations are permitted
> with interrupts disabled as any TLB flushes would be local only. This
> is necessary during early boot.
> 
> Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
> ---
> Changes in v3:
> - Use num_online_cpus() in assert.
> 
> Changes in v2:
> - Set SYS_STATE_smp_boot on arm.
> ---
>   xen/common/page_alloc.c | 23 +++++++++++++++--------
>   1 file changed, 15 insertions(+), 8 deletions(-)
> 
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index 319029140f..516ffa2a97 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -162,6 +162,13 @@
>   static char __initdata opt_badpage[100] = "";
>   string_param("badpage", opt_badpage);
>   
> +/*
> + * Heap allocations may need TLB flushes which require IRQs to be
> + * enabled (except during early boot when only 1 PCPU is online).

Same remark as above. Also, I think there are other cases where 
num_online_cpus() == 1:
   - Xen is only using one core (it will not be a useful system but 
technically supported)
   - During suspend/resume

So I think we should either relax the comment or restrict the assert 
below. I don't have any preference.

> + */ > +#define ASSERT_ALLOC_CONTEXT() \
> +    ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() == 1))
> +
>   /*
>    * no-bootscrub -> Free pages are not zeroed during boot.
>    */
> @@ -2160,7 +2167,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>   {
>       struct page_info *pg;
>   
> -    ASSERT(!in_irq());
> +    ASSERT_ALLOC_CONTEXT();
>   
>       pg = alloc_heap_pages(MEMZONE_XEN, MEMZONE_XEN,
>                             order, memflags | MEMF_no_scrub, NULL);
> @@ -2173,7 +2180,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>   
>   void free_xenheap_pages(void *v, unsigned int order)
>   {
> -    ASSERT(!in_irq());
> +    ASSERT_ALLOC_CONTEXT();
>   
>       if ( v == NULL )
>           return;
> @@ -2202,7 +2209,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>       struct page_info *pg;
>       unsigned int i;
>   
> -    ASSERT(!in_irq());
> +    ASSERT_ALLOC_CONTEXT();
>   
>       if ( xenheap_bits && (memflags >> _MEMF_bits) > xenheap_bits )
>           memflags &= ~MEMF_bits(~0U);
> @@ -2224,7 +2231,7 @@ void free_xenheap_pages(void *v, unsigned int order)
>       struct page_info *pg;
>       unsigned int i;
>   
> -    ASSERT(!in_irq());
> +    ASSERT_ALLOC_CONTEXT();
>   
>       if ( v == NULL )
>           return;
> @@ -2249,7 +2256,7 @@ void init_domheap_pages(paddr_t ps, paddr_t pe)
>   {
>       mfn_t smfn, emfn;
>   
> -    ASSERT(!in_irq());
> +    ASSERT_ALLOC_CONTEXT();
>   
>       smfn = maddr_to_mfn(round_pgup(ps));
>       emfn = maddr_to_mfn(round_pgdown(pe));
> @@ -2369,7 +2376,7 @@ struct page_info *alloc_domheap_pages(
>       unsigned int bits = memflags >> _MEMF_bits, zone_hi = NR_ZONES - 1;
>       unsigned int dma_zone;
>   
> -    ASSERT(!in_irq());
> +    ASSERT_ALLOC_CONTEXT();
>   
>       bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
>                                         bits ? : (BITS_PER_LONG+PAGE_SHIFT));
> @@ -2419,7 +2426,7 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
>       unsigned int i;
>       bool drop_dom_ref;
>   
> -    ASSERT(!in_irq());
> +    ASSERT_ALLOC_CONTEXT();
>   
>       if ( unlikely(is_xen_heap_page(pg)) )
>       {
> @@ -2738,7 +2745,7 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
>   {
>       struct page_info *pg;
>   
> -    ASSERT(!in_irq());
> +    ASSERT_ALLOC_CONTEXT();
>   
>       pg = acquire_staticmem_pages(smfn, nr_mfns, memflags);
>       if ( !pg )

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 16:07:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 16:07:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312165.529353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nielk-0006gq-LL; Sun, 24 Apr 2022 16:07:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312165.529353; Sun, 24 Apr 2022 16:07:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nielk-0006gj-HX; Sun, 24 Apr 2022 16:07:28 +0000
Received: by outflank-mailman (input) for mailman id 312165;
 Sun, 24 Apr 2022 16:07:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ret3=VC=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nielj-0006gd-DU
 for xen-devel@lists.xenproject.org; Sun, 24 Apr 2022 16:07:27 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a231fb56-c3e8-11ec-8fc2-03012f2f19d4;
 Sun, 24 Apr 2022 18:07:26 +0200 (CEST)
Received: by mail-lf1-x136.google.com with SMTP id x33so22324714lfu.1
 for <xen-devel@lists.xenproject.org>; Sun, 24 Apr 2022 09:07:26 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 x5-20020a2e9dc5000000b0024dbe5356bcsm925671ljj.91.2022.04.24.09.07.24
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 24 Apr 2022 09:07:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a231fb56-c3e8-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=P0QTcW9KC8jtIUCRBrIIRQHtbmv2CJL2pbvGJ+qNveo=;
        b=RiDL8hh90QWpKHeZOtsPDicsUv8uA01P9JI5zDhJzv9S+hSKAbApcqzHs0T8Ldp9TH
         fAKRmSgdTSQEE98j8anHPESWwfAC2Wr6fwaU0UzzpCRUSoyOzbyPMzyk4xG8MnEvB3iV
         vXzmNcMzP3+/OStgwtLtURtgOrLqR3sG0n+QrmZd6F+knSa4ckhblkdvzPf132oMlyW7
         8t9564ctxOVGtPTZPcgIhaetMmVgXzuHspqXhW5Z1CHzDb7rM2I+v0s8lEPpdwVc60cp
         RKkWFcAQAI+3ep3nitOiLgSd5r38470CHVIt8zrx9Sfl0OWd+5F9Bp8RCTq2DFJy08Ox
         nIrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=P0QTcW9KC8jtIUCRBrIIRQHtbmv2CJL2pbvGJ+qNveo=;
        b=dPH9GzbLNiH8mrd3qsCKDPIuTIEipLSZNiqNJFIvRP1YkhOxz449EbJ6HDKX9Opbnx
         eIbBFoDWMP5x15YfGJyS1W/zOkHNxEa7OEd0jujBwCs7YM/o/kLL3siXsKlXmYLpGUyK
         xjKsbWq7fmbIRSus55yrwTwjZ0KP1hIOM0TKCAMT//nXH7bVeYKEZh/ZCDGp4E4D5z/T
         SCQbcO5kAwjIww39jBNyHg/zYP19l2gMZmyrHCxsOJa0+1upMYuojmlYgm9tLEAhrjZU
         +xE6dwICY3Hys0KCqCmXOqvLtW1eeiXh+66JJYThjR+jBzuDBAh0wPqyQZLWI9NlWVN6
         MgRw==
X-Gm-Message-State: AOAM532J8v3PTBjmlsXMAqm/+eJGxgQYKRfbJAaGN4DW6fLCw2e+Z3EV
	TC+mg/1455RFNJw50Ah3kTU=
X-Google-Smtp-Source: ABdhPJwXDQKL0ddwC14m+1rm/W4CunYi8dET47R83s7iLr9ZMexO+AO6MY6p46hpbAM/pGFodjYHLQ==
X-Received: by 2002:a05:6512:685:b0:471:d466:9750 with SMTP id t5-20020a056512068500b00471d4669750mr9842846lfe.623.1650816445822;
        Sun, 24 Apr 2022 09:07:25 -0700 (PDT)
Subject: Re: [PATCH V1 6/6] arm/xen: Assign xen-grant DMA ops for xen-grant
 DMA devices
To: Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-7-git-send-email-olekstysh@gmail.com>
 <YmQsagqMn56jidFZ@infradead.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <d102516a-af42-7637-2b5c-f7da33d5036e@gmail.com>
Date: Sun, 24 Apr 2022 19:07:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YmQsagqMn56jidFZ@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 23.04.22 19:42, Christoph Hellwig wrote:

Hello Christoph

> On Fri, Apr 22, 2022 at 07:51:03PM +0300, Oleksandr Tyshchenko wrote:
>>   static inline void xen_setup_dma_ops(struct device *dev)
>>   {
>>   #ifdef CONFIG_XEN
>> -	if (xen_swiotlb_detect())
>> +	if (arch_has_restricted_virtio_memory_access() &&
>> +			xen_is_grant_dma_device(dev))
>> +		xen_grant_setup_dma_ops(dev);
>> +	else if (xen_swiotlb_detect())
> I don't think that arch_has_restricted_virtio_memory_access
> check should be there as it still is a bit of a layering violation.

Well, I will remove it then (and update commit description).

For virtualized but non-virtio devices, it is not needed at all. For the 
virtio devices, this check is already present at 
virtio.c:virtio_features_ok()



>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 24 16:12:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 16:12:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312172.529363 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nieq8-0008JS-B0; Sun, 24 Apr 2022 16:12:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312172.529363; Sun, 24 Apr 2022 16:12:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nieq8-0008JL-85; Sun, 24 Apr 2022 16:12:00 +0000
Received: by outflank-mailman (input) for mailman id 312172;
 Sun, 24 Apr 2022 16:11:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nieq6-0008JB-9m; Sun, 24 Apr 2022 16:11:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nieq6-0005uk-6P; Sun, 24 Apr 2022 16:11:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nieq5-0006FI-Qm; Sun, 24 Apr 2022 16:11:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nieq5-0003Yi-QK; Sun, 24 Apr 2022 16:11:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=B/t+LXNQ391coKL+ei/M8hS+aLEDP1Jl+59R4jDyyAs=; b=Evn4ChCKEZiLSHRyM1BvRMQ1aL
	0QyS1ahMa2Uetn9aOmc7FlwtOBhHHfLflpfPdux3AtR56DCc9VuPxtHlp/S/7MaIbGiVJZiLrZGQR
	84b4hKrRm8bSW4jubqS+ndfydhYwSSqoxT/nC/xM9zPsUWc8hXcHqK8TN7UkTIo2ls5w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169682-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169682: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 16:11:57 +0000

flight 169682 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169682/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  599 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   41 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 16:17:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 16:17:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312180.529375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niev9-0000Wc-Vc; Sun, 24 Apr 2022 16:17:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312180.529375; Sun, 24 Apr 2022 16:17:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niev9-0000WV-SV; Sun, 24 Apr 2022 16:17:11 +0000
Received: by outflank-mailman (input) for mailman id 312180;
 Sun, 24 Apr 2022 16:17:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1niev8-0000WP-U2
 for xen-devel@lists.xenproject.org; Sun, 24 Apr 2022 16:17:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niev6-00061a-8t; Sun, 24 Apr 2022 16:17:08 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niev6-0004Kj-2o; Sun, 24 Apr 2022 16:17:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=+rzU2IaBKnlaamdubPg4kZon4zbw8RHOvuTtxWLYQwY=; b=HFShPMGOY63baVdPKwVne4UsyP
	XXtRBR9vT8ycu9uU4MomAMW3V+NJWfoRq+gw0V5hON1p41i33mpUcrzUDis5IABl6nstJuGBezNK/
	QQu78PrDwF/KYfuEuw5lPOMKRu4TOMltwJtfomh048t/dqF62f8luJgbLsJESZvrPjT4=;
Message-ID: <a160a77a-1cb2-c7cb-7d93-7334772620fe@xen.org>
Date: Sun, 24 Apr 2022 17:17:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: Paran Lee <p4ranlee@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: austindh.kim@gmail.com, xen-devel@lists.xenproject.org
References: <20220421151755.GA4718@DESKTOP-NK4TH6S.localdomain>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH] xen/arm: p2m_set_entry duplicate calculation.
In-Reply-To: <20220421151755.GA4718@DESKTOP-NK4TH6S.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 21/04/2022 16:17, Paran Lee wrote:
> It doesn't seem necessary to do that calculation of order shift again.

I think we need to weight that against increasing the number of local 
variables that do pretty much the same.

This is pretty much done to a matter of taste here. IMHO, the original 
version is better but I see Stefano reviewed it so I will not argue 
against it.

That said, given you already sent a few patches, can you explain why you 
are doing this? Is this optimization purpose? Is it clean-up?

> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> ---
>   xen/arch/arm/p2m.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 1d1059f7d2..533afc830a 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1092,7 +1092,7 @@ int p2m_set_entry(struct p2m_domain *p2m,
>       while ( nr )
>       {
>           unsigned long mask;
> -        unsigned long order;
> +        unsigned long order, pages;
>   
>           /*
>            * Don't take into account the MFN when removing mapping (i.e
> @@ -1118,11 +1118,12 @@ int p2m_set_entry(struct p2m_domain *p2m,
>           if ( rc )
>               break;
>   
> -        sgfn = gfn_add(sgfn, (1 << order));
> +        pages = 1 << order;

Please take the opportunity to switch to 1UL.

> +        sgfn = gfn_add(sgfn, pages);
>           if ( !mfn_eq(smfn, INVALID_MFN) )
> -           smfn = mfn_add(smfn, (1 << order));
> +           smfn = mfn_add(smfn, pages);
>   
> -        nr -= (1 << order);
> +        nr -= pages;
>       }
>   
>       return rc;

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 16:34:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 16:34:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312188.529386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nifC6-0003A4-EG; Sun, 24 Apr 2022 16:34:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312188.529386; Sun, 24 Apr 2022 16:34:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nifC6-00039x-B0; Sun, 24 Apr 2022 16:34:42 +0000
Received: by outflank-mailman (input) for mailman id 312188;
 Sun, 24 Apr 2022 16:34:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nifC5-00039r-MR
 for xen-devel@lists.xenproject.org; Sun, 24 Apr 2022 16:34:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nifC5-0006Iu-7D; Sun, 24 Apr 2022 16:34:41 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nifC5-0005KG-1l; Sun, 24 Apr 2022 16:34:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=vNm9+PyVSLS5gX8C8VhKLW5scel3z5mGkUEUfPXaQ/8=; b=jpc/fTU5AlfueZPxiZ+EyDrqHT
	oaLyJpFc0T+RrzqHLHPaEr142CQUQwSeMyiWMQbzdxAVDqVVLga9Mol/N2ILdIoy7ua1uJBYXxYHc
	9cb7kL5Ewd2rfOos+PCFwZ5JpR/jCWx1f8tX6egsoF3PbnI+TO4so3VLNE9GroouVIsE=;
Message-ID: <95926460-c332-8ad7-9430-c628705b21d5@xen.org>
Date: Sun, 24 Apr 2022 17:34:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: Paran Lee <p4ranlee@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: austindh.kim@gmail.com, xen-devel@lists.xenproject.org
References: <20220419154619.GA3136@DESKTOP-NK4TH6S.localdomain>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH] xen/device_tree: silence ambiguous integer casting
 warning error
In-Reply-To: <20220419154619.GA3136@DESKTOP-NK4TH6S.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 19/04/2022 16:46, Paran Lee wrote:
> GCC with "-g -Wall -Wextra" option throws warning message as below:

s/warning/error/

> 
> error: comparison of integer expressions of different signedness:
>   ‘int’ and ‘unsigned int’ [-Werror=sign-compare]

Can you post the full log?

> 
> Silence the warning by correcting the integer type.

IIRC most of the code you touch below is from Linux and had very limited 
changes afterwards. So while I agree the changes are good, AFAIK they 
are not (latent?) bugs and we don't build by default with -Wextra.

Therefore, I would prefer if they are upstreamed to Linux first and then 
backported to Xen.

> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> ---
>   xen/common/device_tree.c | 31 +++++++++++++++----------------
>   1 file changed, 15 insertions(+), 16 deletions(-)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 4aae281e89..402e465c7a 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -79,7 +79,7 @@ struct dt_bus
>       const char *addresses;
>       bool_t (*match)(const struct dt_device_node *node);
>       void (*count_cells)(const struct dt_device_node *child,
> -                        int *addrc, int *sizec);
> +                        unsigned int *addrc, unsigned int *sizec);
>       u64 (*map)(__be32 *addr, const __be32 *range, int na, int ns, int pna);
>       int (*translate)(__be32 *addr, u64 offset, int na);
>       unsigned int (*get_flags)(const __be32 *addr);
> @@ -569,7 +569,7 @@ static bool_t dt_bus_default_match(const struct dt_device_node *node)
>   }
>   
>   static void dt_bus_default_count_cells(const struct dt_device_node *dev,
> -                                int *addrc, int *sizec)
> +                                       unsigned int *addrc, unsigned int *sizec)
>   {
>       if ( addrc )
>           *addrc = dt_n_addr_cells(dev);

Technically, the prototype of dt_n_addr_cells() is "int ... (". So now 
you are casting an "int" to an "unsigned int". AFAICT, dt_n_addr_cells() 
will never return a negative value. So we should propage the "unsigned int".

> @@ -649,7 +649,7 @@ static bool_t dt_bus_pci_match(const struct dt_device_node *np)
>   }
>   
>   static void dt_bus_pci_count_cells(const struct dt_device_node *np,
> -				   int *addrc, int *sizec)
> +				   unsigned int *addrc, unsigned int *sizec)
>   {
>       if (addrc)
>           *addrc = 3;
> @@ -737,7 +737,7 @@ static const struct dt_bus dt_busses[] =
>   
>   static const struct dt_bus *dt_match_bus(const struct dt_device_node *np)
>   {
> -    int i;
> +    long unsigned int i;

This should be size_t.

>   
>       for ( i = 0; i < ARRAY_SIZE(dt_busses); i++ )
>           if ( !dt_busses[i].match || dt_busses[i].match(np) )
> @@ -754,7 +754,8 @@ static const __be32 *dt_get_address(const struct dt_device_node *dev,
>       u32 psize;
>       const struct dt_device_node *parent;
>       const struct dt_bus *bus;
> -    int onesize, i, na, ns;
> +    unsigned int i;
> +    unsigned int onesize, na, ns; >
>       /* Get parent & match bus type */
>       parent = dt_get_parent(dev);
> @@ -797,8 +798,7 @@ static int dt_translate_one(const struct dt_device_node *parent,
>                               int pna, const char *rprop)
>   {
>       const __be32 *ranges;
> -    unsigned int rlen;
> -    int rone;
> +    unsigned int rlen, rone;
>       u64 offset = DT_BAD_ADDR;
>   
>       ranges = dt_get_property(parent, rprop, &rlen);
> @@ -857,7 +857,7 @@ static u64 __dt_translate_address(const struct dt_device_node *dev,
>       const struct dt_device_node *parent = NULL;
>       const struct dt_bus *bus, *pbus;
>       __be32 addr[DT_MAX_ADDR_CELLS];
> -    int na, ns, pna, pns;
> +    unsigned int na, ns, pna, pns;
>       u64 result = DT_BAD_ADDR;
>   
>       dt_dprintk("DT: ** translation for device %s **\n", dev->full_name);
> @@ -966,8 +966,7 @@ int dt_for_each_range(const struct dt_device_node *dev,
>       const struct dt_bus *bus, *pbus;
>       const __be32 *ranges;
>       __be32 addr[DT_MAX_ADDR_CELLS];
> -    unsigned int rlen;
> -    int na, ns, pna, pns, rone;
> +    unsigned int rlen, na, ns, pna, pns, rone;
>   
>       bus = dt_match_bus(dev);
>       if ( !bus )
> @@ -1134,7 +1133,7 @@ unsigned int dt_number_of_address(const struct dt_device_node *dev)
>       u32 psize;
>       const struct dt_device_node *parent;
>       const struct dt_bus *bus;
> -    int onesize, na, ns;
> +    unsigned int onesize, na, ns;
>   
>       /* Get parent & match bus type */
>       parent = dt_get_parent(dev);
> @@ -1169,8 +1168,8 @@ int dt_for_each_irq_map(const struct dt_device_node *dev,
>       const struct dt_device_node *ipar, *tnode, *old = NULL;
>       const __be32 *tmp, *imap;
>       u32 intsize = 1, addrsize, pintsize = 0, paddrsize = 0;
> -    u32 imaplen;
> -    int i, ret;
> +    u32 i, imaplen;
> +    int ret;
>   
>       struct dt_raw_irq dt_raw_irq;
>       struct dt_irq dt_irq;
> @@ -1354,8 +1353,8 @@ static int dt_irq_map_raw(const struct dt_device_node *parent,
>       const struct dt_device_node *ipar, *tnode, *old = NULL, *newpar = NULL;
>       const __be32 *tmp, *imap, *imask;
>       u32 intsize = 1, addrsize, newintsize = 0, newaddrsize = 0;
> -    u32 imaplen;
> -    int match, i;
> +    u32 i, imaplen;
> +    int match;
>   
>       dt_dprintk("dt_irq_map_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n",
>                  parent->full_name, be32_to_cpup(intspec),
> @@ -1737,7 +1736,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np,
>   
>               if ( out_args )
>               {
> -                int i;
> +                u32 i;
>   
>                   WARN_ON(count > MAX_PHANDLE_ARGS);
>                   if (count > MAX_PHANDLE_ARGS)

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 16:53:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 16:53:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312194.529397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nifUO-0005pj-SR; Sun, 24 Apr 2022 16:53:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312194.529397; Sun, 24 Apr 2022 16:53:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nifUO-0005pc-PW; Sun, 24 Apr 2022 16:53:36 +0000
Received: by outflank-mailman (input) for mailman id 312194;
 Sun, 24 Apr 2022 16:53:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ret3=VC=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nifUN-0005pW-9D
 for xen-devel@lists.xenproject.org; Sun, 24 Apr 2022 16:53:35 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 134f8f6d-c3ef-11ec-8fc2-03012f2f19d4;
 Sun, 24 Apr 2022 18:53:33 +0200 (CEST)
Received: by mail-lf1-x12c.google.com with SMTP id z18so5291503lfu.9
 for <xen-devel@lists.xenproject.org>; Sun, 24 Apr 2022 09:53:33 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 f18-20020a193812000000b00471f8573c96sm649350lfa.241.2022.04.24.09.53.31
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 24 Apr 2022 09:53:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 134f8f6d-c3ef-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=jglWAKRkI0cPF7sxIMVbMR7zt7h0C3kJ96kO8VwqGDI=;
        b=GYowuHqr7FB76QyplNtwwt3lky81k7Ou35ecYplCgAko4aBaXhy/MXAyl2x4Cu/MW6
         A4pRF0w0ewJckI7S8ELGwOHTFDh7jbReEQ26VnrDMV4qu3juRSwbpBdXChSHPNYzJmNd
         EHpOi7Mjq2QTjAF+XObk/nyy30OuCFJhSKdBQ+Y8I1flgab/G8K3uMsZzQcobPMA9HKV
         1kEJq9DMHRJL81nG7xqc1Ivq+c1M0Okte8Uf5RWCZA2JcJ3d4RyX0YkMLopKdkYqryTY
         TAmhz+4UYcJcT+l9p8zKrD1SrCQXsuNIOFI0RDhK9P6wTsNSdnQFTWRDH+NAyQ9FHB/3
         E/1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=jglWAKRkI0cPF7sxIMVbMR7zt7h0C3kJ96kO8VwqGDI=;
        b=KkxlWLdZCNPPPrq44RnaMaThWaqkD54LBlEGB9MyvomrfBV0elml7DI57BFZSHZHH0
         khVItp6Ajfppumhpbqg1lSsOkBGVLxzL9yPxn5oLSA6+WttVt6t5PcYBuvyZSop0OfzM
         qockPqA6O9ISpD3vSbg6S5iBWOkCHmzuXTl+JFV09SpQrnw5GC4JPWFnq367uVpNtqrU
         EYzKi9q0ltdopIFS/FOVJjcFmlAYMFwwvWWVQdnJ6CCGY9WSeW45UBMvuMlq2Og7VIoA
         ApyfRyF+lWXNLVEFKIDWJ1Q4PcTZrNNXlzMEnX7C1755LoTaxxyle4+BYnTpZ7GvOQZI
         7gPA==
X-Gm-Message-State: AOAM530M1nktUXNB9GThehuvjdZnmhYTTcAc91t2eEVn8iHeBD+/xxBH
	KCzbtXszI8/XxszS4JfuZME=
X-Google-Smtp-Source: ABdhPJwFreSpU5cEMVZzTUFm4eZzNyKMvOqf9D+S7BUgoISlXctBt6KVfUUcLTPNUQsOQOiq0aeg4w==
X-Received: by 2002:a05:6512:ac9:b0:470:e6d0:1bd8 with SMTP id n9-20020a0565120ac900b00470e6d01bd8mr10000761lfu.614.1650819212650;
        Sun, 24 Apr 2022 09:53:32 -0700 (PDT)
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
To: Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Juergen Gross <jgross@suse.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
Date: Sun, 24 Apr 2022 19:53:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YmQsFb36UEH9BUnN@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 23.04.22 19:40, Christoph Hellwig wrote:


Hello Christoph

> Please split this into one patch that creates grant-dma-ops, and another
> that sets up the virtio restricted access helpers.


Sounds reasonable, will do:

1. grant-dma-ops.c with config XEN_GRANT_DMA_OPS

2. arch_has_restricted_virtio_memory_access() with config XEN_VIRTIO


>
>> +
>> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>> +int arch_has_restricted_virtio_memory_access(void)
>> +{
>> +	return (xen_has_restricted_virtio_memory_access() ||
>> +			cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
>> +}
> So instead of hardcoding Xen here, this seems like a candidate for
> another cc_platform_has flag.


I have a limited knowledge of x86 and Xen on x86.

Would the Xen specific bits fit into Confidential Computing Platform 
checks? I will let Juergen/Boris comment on this.


>
>> +config XEN_VIRTIO
>> +	bool "Xen virtio support"
>> +	default n
> n is the default default, so no need to specify it.

ok, will drop


>
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/******************************************************************************
> The all * line is not the usual kernel style, I'd suggest to drop it.

ok, will drop


>
>> +static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
>> +					      dma_addr_t *dma_handle,
>> +					      enum dma_data_direction dir,
>> +					      gfp_t gfp)
>> +{
>> +	WARN_ONCE(1, "xen_grant_dma_alloc_pages size %zu\n", size);
>> +	return NULL;
>> +}
>> +
>> +static void xen_grant_dma_free_pages(struct device *dev, size_t size,
>> +				     struct page *vaddr, dma_addr_t dma_handle,
>> +				     enum dma_data_direction dir)
>> +{
>> +	WARN_ONCE(1, "xen_grant_dma_free_pages size %zu\n", size);
>> +}
> Please just wire this up to the same implementation as .alloc and .free.

I got it, will implement


>
>> +	spin_lock(&xen_grant_dma_lock);
>> +	list_add(&data->list, &xen_grant_dma_devices);
>> +	spin_unlock(&xen_grant_dma_lock);
> Hmm, having to do this device lookup for every DMA operation is going
> to suck. It might make sense to add a private field (e.g. as a union
> with the iommu field) in struct device instead.


I was thinking about it, but decided to not alter common struct device 
for adding Xen specific field, but haven't managed to think of a better 
idea than just using that brute lookup ...


>
> But if not you probably want to switch to a more efficient data
> structure like the xarray at least.

... I think, this is good point, thank you. I have no idea how faster it 
is going to be, but the resulting code looks simple (if of course I 
correctly understood the usage of xarray)


diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index a512c0a..7ecc0b0 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -11,6 +11,7 @@
  #include <linux/dma-map-ops.h>
  #include <linux/of.h>
  #include <linux/pfn.h>
+#include <linux/xarray.h>
  #include <xen/xen.h>
  #include <xen/grant_table.h>

@@ -19,12 +20,9 @@ struct xen_grant_dma_data {
         domid_t dev_domid;
         /* Is device behaving sane? */
         bool broken;
-       struct device *dev;
-       struct list_head list;
  };

-static LIST_HEAD(xen_grant_dma_devices);
-static DEFINE_SPINLOCK(xen_grant_dma_lock);
+static DEFINE_XARRAY(xen_grant_dma_devices);

  #define XEN_GRANT_DMA_ADDR_OFF (1ULL << 63)

@@ -40,21 +38,13 @@ static inline grant_ref_t dma_to_grant(dma_addr_t dma)

  static struct xen_grant_dma_data *find_xen_grant_dma_data(struct 
device *dev)
  {
-       struct xen_grant_dma_data *data = NULL;
-       bool found = false;
-
-       spin_lock(&xen_grant_dma_lock);
-
-       list_for_each_entry(data, &xen_grant_dma_devices, list) {
-               if (data->dev == dev) {
-                       found = true;
-                       break;
-               }
-       }
+       struct xen_grant_dma_data *data;

-       spin_unlock(&xen_grant_dma_lock);
+       xa_lock(&xen_grant_dma_devices);
+       data = xa_load(&xen_grant_dma_devices, (unsigned long)dev);
+       xa_unlock(&xen_grant_dma_devices);

-       return found ? data : NULL;
+       return data;
  }

  /*
@@ -310,11 +300,12 @@ void xen_grant_setup_dma_ops(struct device *dev)
                 goto err;

         data->dev_domid = dev_domid;
-       data->dev = dev;

-       spin_lock(&xen_grant_dma_lock);
-       list_add(&data->list, &xen_grant_dma_devices);
-       spin_unlock(&xen_grant_dma_lock);
+       if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, 
data,
+                       GFP_KERNEL))) {
+               dev_err(dev, "Cannot store Xen grant DMA data\n");
+               goto err;
+       }

         dev->dma_ops = &xen_grant_dma_ops;


>
>> +EXPORT_SYMBOL_GPL(xen_grant_setup_dma_ops);
> I don't think this has any modular users, or did I miss something?

No, you didn't. Will drop here and in the next patch for 
xen_is_grant_dma_device() as well.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sun Apr 24 17:27:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 17:27:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312205.529408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nig0k-0001Gk-LS; Sun, 24 Apr 2022 17:27:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312205.529408; Sun, 24 Apr 2022 17:27:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nig0k-0001Gd-Gq; Sun, 24 Apr 2022 17:27:02 +0000
Received: by outflank-mailman (input) for mailman id 312205;
 Sun, 24 Apr 2022 17:27:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nig0i-0001GT-SO; Sun, 24 Apr 2022 17:27:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nig0i-0007BG-Na; Sun, 24 Apr 2022 17:27:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nig0i-0007rh-7o; Sun, 24 Apr 2022 17:27:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nig0i-0004JY-7L; Sun, 24 Apr 2022 17:27:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zkG30kTHH2yn7bZx3he5ksJXDD8ac8hzX6AZXeDSv7k=; b=DLHNCkkxqLHJ00IoapfK5Ny3kJ
	3AHIMMJlHWTIoIXXJmIboTGZxFYaEkZrAgu1eIO35iLtEq85tXdZDNHkj+SAHn9aDAbFOX1S+ECge
	fVtVTzf8U9Rbp/uZ0jSezMt1o2EI4TFBLFOKL7+AamyDuKYmf9YemhspOsKgZMLyyxNY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169683-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169683: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 17:27:00 +0000

flight 169683 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169683/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  600 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   42 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 18:11:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 18:11:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312217.529419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nighA-0006t7-0b; Sun, 24 Apr 2022 18:10:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312217.529419; Sun, 24 Apr 2022 18:10:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nigh9-0006t0-TQ; Sun, 24 Apr 2022 18:10:51 +0000
Received: by outflank-mailman (input) for mailman id 312217;
 Sun, 24 Apr 2022 18:10:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lx8X=VC=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nigh7-0006su-QY
 for xen-devel@lists.xenproject.org; Sun, 24 Apr 2022 18:10:50 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d7106596-c3f9-11ec-a405-831a346695d4;
 Sun, 24 Apr 2022 20:10:39 +0200 (CEST)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23OGa83V022232;
 Sun, 24 Apr 2022 18:08:42 GMT
Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta02.appoci.oracle.com [147.154.114.232])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmaw49re3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sun, 24 Apr 2022 18:08:42 +0000
Received: from pps.filterd
 (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23OI0s1l004093; Sun, 24 Apr 2022 18:08:41 GMT
Received: from nam04-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam08lp2041.outbound.protection.outlook.com [104.47.73.41])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id
 3fm7w1f0h4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sun, 24 Apr 2022 18:08:40 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by CY4PR10MB1768.namprd10.prod.outlook.com (2603:10b6:910:c::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sun, 24 Apr
 2022 18:08:38 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.020; Sun, 24 Apr 2022
 18:08:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7106596-c3f9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=nzMJntI2rKxWeSgLPQUl3FmXqyfq27Cgh/lYk/ng5Y8=;
 b=deUECF8Z/3EI4lb5akHHDoDu5hqfhwMdVDtF5B6YBg3ziDk/K2DgVZlZMlES00xSs9J5
 +WkDEAzu7xC74HWhGaYpam5w5i89lPHSZ++jmzL0dmr3yRgqeugG59H8LIz7q6cMxnaf
 KQsyO4gA0diFd/JdTtwC1qfEvcXcw/mwUY8ij5LfZQK2QJd91VhTCqf1Htpa8O0dI7x5
 rP3tai4XzS2dd3tky3dHyyVrJfbrm+h5sRm+CCBpBmv0FKu3e8heamzHyTdTZkt4tVbT
 bFtR4LGITwzBL8Ao+687TSQeB5rmlRyg+mhlaj7d0Nz1WeCfe1iSlAc+QpGkFXm3vePv GA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ip+SE4F1s59zOyY2jyPVw0Rx78IxPnsaKF80baCnVmDjD4v75FYc7euk04vWHaGtr6Oz4cK4jwkX20IaeNXUmEtLkU0BjLqcq0ey5u5xag7VjrH/OyzOuJ1U62IRJRyp7uFwy9h37V0mMngf8tSIpfuNsbBexswM1dIDpGRz98I/puNjXskoyzJ6iqTfxTFRfWQmJDQFWirb1q00pgG8DoAeflfKNIdiShEUmV8QXPTew9SBxzi5c1daHpZbV1NxUJHiLMcEYSq3pWjD0BXeD5DEerYbVeh9JcW8VNE24OY4k/jZDin7NAShzRZPl9UtYpUP7yiVtRRotz1tLaNSIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nzMJntI2rKxWeSgLPQUl3FmXqyfq27Cgh/lYk/ng5Y8=;
 b=YuWE2kJ158yKTscZXnsMUgXhu4+4Q7mBUU5d+xDqLoKhk16mleeN2zpv1BCN2efKlC1e/jCiwI5VsObRhKLNCAGecoThkqfz/a+vythFNy0ztpP5fe0rBgNJNbewxY1pcOOZPKEEehbUHxA1bzGA50TDfzCY9P32TwAgOdBpV30lhCvyheaTZGwITdkkOVp+wBHY82GFW5A1c9i2BRk7GJyh6x2yNT/zvtL7LtmqqZkuUdjU3whkcCrvcDo2KRLrXbHVXVGDr+H5BeWunY/jpBsa+Gdkwa76aBn8khQY0gnbTn7W+qc+SIjQgFB/7swg+7JVCZ/3inau94OzlNBUUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nzMJntI2rKxWeSgLPQUl3FmXqyfq27Cgh/lYk/ng5Y8=;
 b=a3BH/j9npWLCHamQ2HuUmX1qurgfTeeRntsxcyC3OFPY+iRYPW3xbBNhEcjGOiKqeFACMlKqm9/wyAWkSOwcPTMlNn8E+lT5BIUmLnFN0ee4IqIrTbp8xeeX9PwtxQrjK63Eis+sZvk/zPJ2kQW0MCWsVq/ujB/f4vaSK3LMjzY=
Message-ID: <e63bfa2c-6edb-f224-1d2a-0c69330492ad@oracle.com>
Date: Sun, 24 Apr 2022 14:08:36 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Juergen Gross <jgross@suse.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        "Michael S. Tsirkin" <mst@redhat.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: BL0PR02CA0128.namprd02.prod.outlook.com
 (2603:10b6:208:35::33) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eab6a1c3-1b05-45c8-c0c3-08da261d74fa
X-MS-TrafficTypeDiagnostic: CY4PR10MB1768:EE_
X-Microsoft-Antispam-PRVS: 
	<CY4PR10MB17684AAE2C0ABC903BC74E818AF99@CY4PR10MB1768.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	aEE4haSESYbkA/ryPAJq5upUt3b3vzxNitMk2egsH9OOwk/K/1PVJ6LoaDspltr5BV+ChRAkWmihfjQQqKRyOkkg5vFJG3H84dKxj5KbJd/JcHVkBrpamIgXknXgIAfCNyIFizHoG9yBkoG20NLIvN7FC4Vfkv1caM2kKvCb8FL1CkhfD1zCAVRhTTN/pNoy8ImHCh5KIZWpuH4oXKh5+k9mfjurMZo+FqUGQwe6MzECKP4yb8W9xme53B3UXS7VmR/9/Sv3dy2GKCEYz4sMEwxo/q2j0vZ2cmqioR0pOHu2Nw6qx9kinLrFOGVmzLtUfQxI1BZdmEhzIjSet6loDH15eqOI3hqiUIO8pF09m9sIHWkZOtoQ6PgU9Zy0xUQJEtg7UOxTjM++3mYzNfImvSIey2KzWdKvSG0jQgEzz0lo4Uq+4Of9eLYK1um4/et8822C8TdF0yhI6VsUDfIbyYSSPWOsfQfcS7x2QUBesQseuv5bwh3CN88/AnIe6wQhxBsTO/2UoYY4p4YrmpabuFxSeYJgJqWf4PqfmbfueZgCxA/g05r5Z6UsRU1wt4iOFTTGMitLLZomX4Mfs29D3o2JWfMQFoZuxJqakEITR5gsX5rtxkOBP2xXJaOfnDFtYHH5GexEx+SWDAQGVF4cVsVi7gY1yUZuCEz6iBOPAl1tb5FmE/q/QX65A3ASVBCz127yYIsHTm8h5Vn5NsBmf6Tpva0pVFHHdvGCdUZVYKw=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(508600001)(6486002)(8936002)(316002)(38100700002)(26005)(8676002)(4326008)(86362001)(66946007)(54906003)(66556008)(66476007)(36756003)(110136005)(5660300002)(4744005)(6506007)(83380400001)(6512007)(7416002)(31686004)(53546011)(44832011)(2906002)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?WDJINEZNY3h4azViemtZTndhWkJEK3czUldGVXR1MzdMMmhIUnltWGtKdlRW?=
 =?utf-8?B?cmovWDBVSXRFbXZUOHNweFFZeFRtemsxMzlaRnFIQ3BsS09lSGJreDRDM0F2?=
 =?utf-8?B?aFEwYjYvZG8yQkRCL1kreEllcVdRR3VuME5GWDZXQjM2VzZ3UUQvY2t4eFh2?=
 =?utf-8?B?ZWUwaEpxQUJzT2E0QStnTTRLb1FlOFFYTHArMkJROG9RbWkxQmdVSTdVRGZU?=
 =?utf-8?B?VnBkL1NlN3p0SFpWNENXSEQyTXFRek40NnJhR1A2OTFPQVlzYTJCTlM5RDZH?=
 =?utf-8?B?Q2YweXMzbmRWZXFIdjNRUnhvck1yeVMyVHVvNUp3L1NlUHl2SzNqTzV3NDJD?=
 =?utf-8?B?MStHeElhT2g3bUx0dXNjeHpVRGRGY0YxQUpadFVxTlNEdEpOSU1pdzZVdG5M?=
 =?utf-8?B?Tzl6aWxiWW9ja1QrVnlOK2xuei9kQmZ1MHFabmZqY29SOUtKRlA0bTJYODI5?=
 =?utf-8?B?ckNDd1hMOCtkaG82eUVsSWJjaHFvQjFsWE55OWZVVFp4V1cvR1JzaEovWm85?=
 =?utf-8?B?S1pJYjFKM0hITE9rVUlhTVVLakpBUnFYdzdrN1VYaEdXNWV0V0N1M3RWUEx2?=
 =?utf-8?B?cXJJb2F3MXltY1hWZnl2dGhWT1VRaTBFT2diZGlqNTNZUWdBKytaeXl2Y0Yw?=
 =?utf-8?B?cHdiRzNia09tMlFSMGNucnZ3Z3VMUUNHaWUwWWNOTVQ5K0F0UzhEcjFKYzBq?=
 =?utf-8?B?RUEyMGhIbDBveFVoOXZFUUZKWXAzNlpsQzZ6WFRjZFNVaFRqdUxSbCtrWGEy?=
 =?utf-8?B?aGJMWTRwZzNsVjQxTTVmYTROdHZFMDF3bkVEbXNsQWxUb21DT2lxaUdLT2pZ?=
 =?utf-8?B?cUhQQk5vVFJ4R3Nwc2RhVzE1eHNrYlpuRmptdXQ5dkV1VXRQczRlbmp4QTNV?=
 =?utf-8?B?R09jTXpUekFiLzFxWjBHaVRSdVlxTlZHYjVHekNqcm5GSXh1T0pBK000Q0la?=
 =?utf-8?B?WU9UV2VQOFQwTUxuZXcza1M5ODcvVmhycUNxT3NYUks4M3FiaFV4M25qaEdo?=
 =?utf-8?B?TDlacEMrdTdIVmFpanIwNWlBZ1liY2tTcjRXbWtTdEl4Q1krdXZGMWtNVmEr?=
 =?utf-8?B?d1B3TUl0cDJSM0xWRU01VWVmOExPOUlTdWlpNEFXTGg0Vm9yRzBJaXhna2x4?=
 =?utf-8?B?OXhQZVorZE9BTTJNa0FPMm9MR1ZCWnQzVkg0NnhaL3p5M1ZHUGg2RmtkaWJn?=
 =?utf-8?B?SEx3SmxtTGxEM2Z2YjFyQkFzbk93Z01YQjJhNiszNjRhTTBWRTg3cnQxeUpk?=
 =?utf-8?B?WVBWUUhhQXRINUloRzNuMHFzc2R2SVNZaHpMaGJzc2J6VTlQTHVPTCt3ZHo2?=
 =?utf-8?B?L3QyUThZK01qUUhHdllqdU1Rcy9nS2RtREZ6RmtrYitHU0JvcTJJK2RUYWd6?=
 =?utf-8?B?UVZ2YkVhd3VlL1F4VVcyNytkanZhUC90eFdYNGhlOUxDWjNqbEdOaHk5ZTkr?=
 =?utf-8?B?eVlXSHBGTUg4amlZeGl2U0ZDQzFtRmZySW1KdGxVQU51Z0lySUkwcTBHMlVw?=
 =?utf-8?B?cDF2eWRCYzUwL2xOV2hMbGp3SW9ZSmhVTHkyRS9zUWRHSHlaTmRqNEh6L0tV?=
 =?utf-8?B?dGVhUnl1dVRmOHVDVjh6RlpqWkhzQnVxVDd5K2lkc3dpYkpHMDNmblJRd3Fn?=
 =?utf-8?B?RFpqMkFJYkd4RmhnVVMrZy9YVjRQV2ZNWEdObXFleHpFdU1NK1BHL2ovU0Qz?=
 =?utf-8?B?MzZ6c1h5RW15N0hwdDQyS0Y2Zm11TE9JOWJ0NzlLaksvL0p3clBscW94L2R2?=
 =?utf-8?B?TVV2d0hnajBHM1Q3NXg0Q0Z6OW9WamV6WnJhcDkvbEI4ckpIRUJuRU9ZVUtz?=
 =?utf-8?B?UjdEMDM4cVBKWCtNU0M5MjYwRGt0YXFCTWJNaTFTVFZJN3BNS1F2emJQcnZ0?=
 =?utf-8?B?RkhBd0Y3bEpQeElaK3hjU2swTXdhbVJNRzVPMlMzQUwvbWdWemZYQXJwS1gr?=
 =?utf-8?B?WVZDT3AyQ3VXeUxSUGo0WVpabGp4T1M0OWhOdUl5QmFiT29RZFI0Q3BEdDNo?=
 =?utf-8?B?THh1QWVoQVNjZCtqLzBlNCtER3Y0SzJtWHJqYmxLQXJqd0VkVVNEdUdzTEEw?=
 =?utf-8?B?UmgvUGxiZGpORmJjdUtudEtpaHl5bnRHazBkSEg4SFM3QWw2NURVb2ZnU0NY?=
 =?utf-8?B?RFVnQVJPRXVmKzhSYnd5ZzhXclRBS0NpczNFcHFXZStIeDhNTUhGYzNEMzJC?=
 =?utf-8?B?dzlJTS81OWMrL3ZjRGRlWC80VXVwVzZNbUlIUVFLL3NBMUQ3MG5PaGg3QnR4?=
 =?utf-8?B?TEIvTHhlYTBhWFMyeElxL1U0Qi96MFYySUlsdW8wOVZCS1BidnIvQ1pkM2VH?=
 =?utf-8?B?NXpsVHB5REszWFNLL0JpL0VzMHZMWFRXd0lFWmZrRXhNQ01kWXB0UXExbFNx?=
 =?utf-8?Q?uYfV9/g2wVuBECJo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eab6a1c3-1b05-45c8-c0c3-08da261d74fa
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2022 18:08:38.6093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dQM0d4rfbeLvo+8nGoHahiT/aNqz792h7o+60Nzer0gY1Zy1hLHf3ubys8axZ++Yr27f0sPWHnOsrVPeMz6+ORZ7aw15bFaaZtXdvXpfjcg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1768
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-23_01:2022-04-22,2022-04-23 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204240091
X-Proofpoint-GUID: Jnd0UO71IogSBYldUQVPbxjV4hl736C5
X-Proofpoint-ORIG-GUID: Jnd0UO71IogSBYldUQVPbxjV4hl736C5


On 4/24/22 12:53 PM, Oleksandr wrote:
>
> On 23.04.22 19:40, Christoph Hellwig wrote:
>
>
>
>
>>
>>> +
>>> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>>> +int arch_has_restricted_virtio_memory_access(void)
>>> +{
>>> +    return (xen_has_restricted_virtio_memory_access() ||
>>> +            cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
>>> +}
>> So instead of hardcoding Xen here, this seems like a candidate for
>> another cc_platform_has flag.
>
>
> I have a limited knowledge of x86 and Xen on x86.
>
> Would the Xen specific bits fit into Confidential Computing Platform checks? I will let Juergen/Boris comment on this.
>

This is unrelated to confidential so I don't think we can add another CC_ flag.


Would arch/x86/kernel/cpu/hypervisor.c be a better home for this?


-boris



From xen-devel-bounces@lists.xenproject.org Sun Apr 24 18:33:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 18:33:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312224.529429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nih3H-0001HQ-Pv; Sun, 24 Apr 2022 18:33:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312224.529429; Sun, 24 Apr 2022 18:33:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nih3H-0001HJ-N4; Sun, 24 Apr 2022 18:33:43 +0000
Received: by outflank-mailman (input) for mailman id 312224;
 Sun, 24 Apr 2022 18:33:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nih3G-0001H9-5j; Sun, 24 Apr 2022 18:33:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nih3G-0008NM-3s; Sun, 24 Apr 2022 18:33:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nih3F-0000rr-Oc; Sun, 24 Apr 2022 18:33:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nih3F-0001io-O9; Sun, 24 Apr 2022 18:33:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dcV/K4QC9h9Xj5l5+Z9at6As7qiSk1DKzqROv59gUEY=; b=d1pmbL/2g2wSmNWP0nYLn/wnYU
	qSHcHjQ/FmrAh5lKOhUrusNCnEtoFBejkgGGbhy3AFepKX02nW6fU9DMyYU8bNnRU0idAHc2Av9Hu
	jSNnwJIKxvul5ZU7r3W6HT9HQykggxg8jQl5iUZgMPdBgXGbYqS1V54pW7pk267LmjzI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169684-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169684: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 18:33:41 +0000

flight 169684 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169684/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  601 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   43 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 19:12:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 19:12:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312236.529441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nihe5-0005vh-QC; Sun, 24 Apr 2022 19:11:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312236.529441; Sun, 24 Apr 2022 19:11:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nihe5-0005va-Lb; Sun, 24 Apr 2022 19:11:45 +0000
Received: by outflank-mailman (input) for mailman id 312236;
 Sun, 24 Apr 2022 19:11:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nihe5-0005vQ-3Z; Sun, 24 Apr 2022 19:11:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nihe4-0000Ze-Vb; Sun, 24 Apr 2022 19:11:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nihe4-0001hh-Ki; Sun, 24 Apr 2022 19:11:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nihe4-0002Su-KB; Sun, 24 Apr 2022 19:11:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=T0EnOWLfqC1ZEBEkuWvgVhGkKpYifGkn991dczc17jY=; b=yEjrgzIU4YgQktQS07i1dbQ8Um
	kYRzswrx7mnZJGKkjKciNYp35G9Mh7//bhoMvuJOM45Ra72VmENqixHTJmXZHDe96o3pJ3t0xktHB
	Ix2Q2bwW8mUvmf+K8Ej5CmI442Kaui+qnkgGZsBfS2yVaBa+sO783a/h5aS3EuUAlf3I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169685-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169685: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 19:11:44 +0000

flight 169685 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169685/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  602 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   44 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 21:20:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 21:20:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312251.529451 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nijeR-0003F9-6O; Sun, 24 Apr 2022 21:20:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312251.529451; Sun, 24 Apr 2022 21:20:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nijeR-0003F2-3W; Sun, 24 Apr 2022 21:20:15 +0000
Received: by outflank-mailman (input) for mailman id 312251;
 Sun, 24 Apr 2022 21:20:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nijeQ-0003Es-Bm; Sun, 24 Apr 2022 21:20:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nijeQ-0002pJ-8Z; Sun, 24 Apr 2022 21:20:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nijeP-0005o5-LI; Sun, 24 Apr 2022 21:20:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nijeP-0005n7-Ks; Sun, 24 Apr 2022 21:20:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/eySib4tcI2JV93IcSJwvKf/yGGFn9hhlbWXIDDpRTE=; b=a5w+xN0WzDdVHVoLm4Z4JJ+kSG
	ja1HXBZc37sCZbUOEXY+P5WBGq2pdtG07bx+6eVeWyb1gmG0DqOK9/TsvkQ/u4vO6cvpcz6yt1+RV
	yCuGJubcGHvIqvz9AUOHkpVfyxrXCBYv34e49xNPEd+JNpoVbaeFTwWUrt8J1jGIGsDY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169687-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169687: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 21:20:13 +0000

flight 169687 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169687/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  603 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    1 days   45 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 22:19:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 22:19:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312260.529463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nikZr-0000th-Kp; Sun, 24 Apr 2022 22:19:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312260.529463; Sun, 24 Apr 2022 22:19:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nikZr-0000ta-GW; Sun, 24 Apr 2022 22:19:35 +0000
Received: by outflank-mailman (input) for mailman id 312260;
 Sun, 24 Apr 2022 22:19:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nikZq-0000tQ-EW; Sun, 24 Apr 2022 22:19:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nikZq-0003p4-C3; Sun, 24 Apr 2022 22:19:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nikZp-0007xF-S7; Sun, 24 Apr 2022 22:19:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nikZp-0007Oc-Rf; Sun, 24 Apr 2022 22:19:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PqULwUx0RWs/qo1qWkpsT4nizw1jiuMTkNnLjCfGDI0=; b=VZyislqCmyhHhE7MLMA+w8OFLj
	MeoTmjsJElqD28NQP4wQou+Gpx4zUegC5Jl/mcqnm6OE93lrnu/vQ+FD3V3PngraTk5X0tPU9eFc0
	Du0rG46kcjB8Cn56+R7Hpsvtgexyh0tKwR9iAdQdIKIYYSJIVItvqRyk6f9lfi3zUjhE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169688-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169688: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 22:19:33 +0000

flight 169688 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169688/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  604 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   46 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 23:29:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 23:29:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312277.529474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nilet-0000IL-PG; Sun, 24 Apr 2022 23:28:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312277.529474; Sun, 24 Apr 2022 23:28:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nilet-0000IE-K1; Sun, 24 Apr 2022 23:28:51 +0000
Received: by outflank-mailman (input) for mailman id 312277;
 Sun, 24 Apr 2022 23:28:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niles-0000I4-FN; Sun, 24 Apr 2022 23:28:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niles-0004yY-9I; Sun, 24 Apr 2022 23:28:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niler-0002Rz-Ul; Sun, 24 Apr 2022 23:28:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niler-000340-UJ; Sun, 24 Apr 2022 23:28:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JzybVd8MqYW0tDFh/R0dQMyaZY7aIQamrzK/7dg2UBY=; b=ozlog7rvywq5/2yoFlSHnb1erM
	5wHCGoZUcaC/897cmmDZA5ZPn5OfpC9qJKLiHJVKkcjPp31t621RdZUTWR3MpyiuvygXjhTrCQDUG
	46Pj+n9AAr6VPhrMlg+Vbh6por1vmDLecpwn2rK40G97gmFLjnCNGqQ0OSC7YQXzqV3o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169689-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169689: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 23:28:49 +0000

flight 169689 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169689/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  605 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   47 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Apr 24 23:59:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Apr 2022 23:59:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312286.529485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nim8c-0003z0-81; Sun, 24 Apr 2022 23:59:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312286.529485; Sun, 24 Apr 2022 23:59:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nim8c-0003yt-4h; Sun, 24 Apr 2022 23:59:34 +0000
Received: by outflank-mailman (input) for mailman id 312286;
 Sun, 24 Apr 2022 23:59:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nim8a-0003yj-Lu; Sun, 24 Apr 2022 23:59:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nim8a-0005XY-Ib; Sun, 24 Apr 2022 23:59:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nim8a-0003Nq-5X; Sun, 24 Apr 2022 23:59:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nim8a-0004Dg-55; Sun, 24 Apr 2022 23:59:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=k7LfcURxS7dFY8e6shwW8s8oFG4wuQY8UU8xih58IRQ=; b=iW1EHOvWdiJf+KGpJQK9ffqtR4
	RDHtqIZm8zLuoHV+sw8JfBrO1DWWw+0IgDFw8H3ftLSsnhL+VD/EpG+qqDoimn78CJQ4tBG5sm+kf
	mS8BQBHjc0iKd6enJQgUhwaPy3XCHc5D0l7tAFyVQJJUWj7rx9C1Mdvhx1fq7ovdjvEc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169690-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169690: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Apr 2022 23:59:32 +0000

flight 169690 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169690/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  606 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   48 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 00:30:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 00:30:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312297.529496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nimbw-0008NC-Qe; Mon, 25 Apr 2022 00:29:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312297.529496; Mon, 25 Apr 2022 00:29:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nimbw-0008N5-NF; Mon, 25 Apr 2022 00:29:52 +0000
Received: by outflank-mailman (input) for mailman id 312297;
 Mon, 25 Apr 2022 00:29:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nimbv-0008Mu-Lo; Mon, 25 Apr 2022 00:29:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nimbv-0006lM-IP; Mon, 25 Apr 2022 00:29:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nimbv-0004DF-5j; Mon, 25 Apr 2022 00:29:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nimbv-0004iQ-5H; Mon, 25 Apr 2022 00:29:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jcw+U9lbj6PHRlyj7gTOToS0583ohCzDkz5qNtmJv78=; b=CaDGza+ayqIbDx0VX9q+Ts4aJg
	uz26VXCaoWJ5RTtX9bE22AVwuPtI3OcUIJx7F4Pn3i74aHnNBQxp4V2Th5K7dgreAXhHrKwgX2Cyc
	B9Fz0w1bE03R01ycJIfvssphDc3TL8IDdSTvBR0D8H26fYDYume/s1WgS803okWEhpQ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169691-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169691: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 00:29:51 +0000

flight 169691 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169691/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  607 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   49 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 00:59:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 00:59:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312310.529507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nin4q-0003cZ-2E; Mon, 25 Apr 2022 00:59:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312310.529507; Mon, 25 Apr 2022 00:59:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nin4p-0003cS-VA; Mon, 25 Apr 2022 00:59:43 +0000
Received: by outflank-mailman (input) for mailman id 312310;
 Mon, 25 Apr 2022 00:59:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nin4p-0003cI-2r; Mon, 25 Apr 2022 00:59:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nin4o-0007Os-Ux; Mon, 25 Apr 2022 00:59:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nin4o-0004rh-Eb; Mon, 25 Apr 2022 00:59:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nin4o-0003Ts-EA; Mon, 25 Apr 2022 00:59:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bFWfL9YY9qy92pRMg8RcnuzH3YbBcPhFsWYajJyiOXg=; b=29h2T1DKU/+E2cnsqYp44573TJ
	z74MQZRKcTbPG+GmLAazFyLYdIzEvY76uKTmhfQxLwWQ1Gf+eio8VDqlOUqB8Hl3XoZbTwMy4eHw8
	PreE5WLAuvhSjKWYqYsZfKMqHfmf4zCNiCNxw03RezDzQDz11yckLOQdKz8rIYaoP9S8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169692-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169692: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 00:59:42 +0000

flight 169692 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169692/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  608 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   50 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 01:48:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 01:48:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312318.529517 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ninpK-0007bx-MU; Mon, 25 Apr 2022 01:47:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312318.529517; Mon, 25 Apr 2022 01:47:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ninpK-0007bq-JF; Mon, 25 Apr 2022 01:47:46 +0000
Received: by outflank-mailman (input) for mailman id 312318;
 Mon, 25 Apr 2022 01:47:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ninpJ-0007bg-Tx; Mon, 25 Apr 2022 01:47:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ninpJ-00069s-S1; Mon, 25 Apr 2022 01:47:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ninpJ-00061I-A6; Mon, 25 Apr 2022 01:47:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ninpJ-0005ID-9h; Mon, 25 Apr 2022 01:47:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tkaXnLLFzzNZ5EYmqcbRLBviQuGANjhHbVi1lMbfP5M=; b=N/lgK70EYmjkNBeLKfJGK4O2qG
	nLMbyQHyLtYKfm8JKiMYRwKRbiWCLp5GiTq9ugwT2v2HDnY6dOvTjh0C3G1vubYjH/Qe9uPJizZ7E
	6P4VhFXQ95AXzGOrtS1fP5dbuE7MPC1mOujtB+Elj0ITdo0bDSWHAx6JssnhhHBq2tPI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169693-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169693: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 01:47:45 +0000

flight 169693 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169693/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   54 days  609 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   51 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 01:55:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 01:55:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312326.529529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ninws-0000kd-HU; Mon, 25 Apr 2022 01:55:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312326.529529; Mon, 25 Apr 2022 01:55:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ninws-0000kW-DO; Mon, 25 Apr 2022 01:55:34 +0000
Received: by outflank-mailman (input) for mailman id 312326;
 Mon, 25 Apr 2022 01:55:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ninwr-0000kM-4a; Mon, 25 Apr 2022 01:55:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ninwr-0006II-2c; Mon, 25 Apr 2022 01:55:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ninwq-0006Ba-Lt; Mon, 25 Apr 2022 01:55:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ninwq-0007cL-LV; Mon, 25 Apr 2022 01:55:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rdFxyYpeCXNIIUdRcjjDsaWOEnd0p9ySNYicLRRcjYU=; b=bn2xeviPQX2Pz6Zj/nH5ch+7T0
	jsCPItJDzrYxpGQybEdxaUv59BeF/mcxFa/VEloexPm/Tn64tSUsk8KdTFNEmgHRGdarriullFFTP
	mhsej75lO+pCsb4TNSoQitPxO6raEnA3hd7keTyZq7UmoZaJygLR2d0k9zKGwGTvDXPQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169686-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169686: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=5206548f6e6741fccbce8d95cff8faeba0738c99
X-Osstest-Versions-That:
    linux=22da5264abf497a10a4ed629f07f4ba28a7ed5eb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 01:55:32 +0000

flight 169686 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169686/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10    fail like 169664
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169664
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169664
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169664
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169664
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169664
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169664
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169664
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169664
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                5206548f6e6741fccbce8d95cff8faeba0738c99
baseline version:
 linux                22da5264abf497a10a4ed629f07f4ba28a7ed5eb

Last test of basis   169664  2022-04-24 01:09:28 Z    1 days
Testing same since   169686  2022-04-24 19:39:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Kardashevskiy <aik@ozlabs.ru>
  Athira Rajeev <atrajeev@linux.vnet.ibm.com>
  Borislav Petkov <bp@suse.de>
  David Gibson <david@gibson.dropbear.id.au>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michael Ellerman <mpe@ellerman.id.au>
  Michal Simek <michal.simek@xilinx.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Song Liu <song@kernel.org>
  Zhang Rui <rui.zhang@intel.com>
  Zhipeng Xie <xiezhipeng1@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   22da5264abf4..5206548f6e67  5206548f6e6741fccbce8d95cff8faeba0738c99 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 03:06:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 03:06:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312337.529540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nip2g-00017x-MP; Mon, 25 Apr 2022 03:05:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312337.529540; Mon, 25 Apr 2022 03:05:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nip2g-00017q-Hv; Mon, 25 Apr 2022 03:05:38 +0000
Received: by outflank-mailman (input) for mailman id 312337;
 Mon, 25 Apr 2022 03:05:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nip2f-00017g-2F; Mon, 25 Apr 2022 03:05:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nip2e-0000CK-RN; Mon, 25 Apr 2022 03:05:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nip2e-0008R9-Fx; Mon, 25 Apr 2022 03:05:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nip2e-0006oW-FV; Mon, 25 Apr 2022 03:05:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HnS3heJp7rId5bJPR1U2JH9fjbeIJGmyFS4ysQLd6Uc=; b=DNUpdSzR7F4P20wCqY3mAI0oue
	s2C8nAsvLCm+xm7quNhkiep7dFE88xXlCIgYHAIt5PCj2O4A1MDMzGCsRCpYMznawAk0nQjVud7AD
	PhOYLkdr7GOBChbB9E3ds+uyaGG94zbaRHQz5utT+hhZ9MBFbotefA1MG/w8ecZi+ADg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169695-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169695: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 03:05:36 +0000

flight 169695 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169695/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  610 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   52 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 04:00:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 04:00:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312346.529550 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niptA-00076Z-OL; Mon, 25 Apr 2022 03:59:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312346.529550; Mon, 25 Apr 2022 03:59:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niptA-00076S-LI; Mon, 25 Apr 2022 03:59:52 +0000
Received: by outflank-mailman (input) for mailman id 312346;
 Mon, 25 Apr 2022 03:59:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nipt8-00076H-LK; Mon, 25 Apr 2022 03:59:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nipt8-00015H-Fc; Mon, 25 Apr 2022 03:59:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nipt7-0002tr-VM; Mon, 25 Apr 2022 03:59:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nipt7-00073F-Un; Mon, 25 Apr 2022 03:59:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=T5M7LLarZTld3e40E/rzY288t2/TibKcE4gndbhRd3g=; b=HmaENrLQWjVeG8kYIOMCImGp6P
	XnUvZ2rPaoXnPRNc7krhY+vHLbzjaZRGEDD7IprPFC/xxOirGUswVbEBK5+GTOGYA5+PHihLBwhOM
	5pViGWjSjEv2yOHAdNlcOqjA9/63CKKQfgOTLiryLtreCJmq41Yn/AspCQSEAaM2Fvwk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169697-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169697: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 03:59:49 +0000

flight 169697 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169697/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  611 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   53 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 05:06:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 05:06:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312354.529561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niquq-0006yR-B2; Mon, 25 Apr 2022 05:05:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312354.529561; Mon, 25 Apr 2022 05:05:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niquq-0006yJ-84; Mon, 25 Apr 2022 05:05:40 +0000
Received: by outflank-mailman (input) for mailman id 312354;
 Mon, 25 Apr 2022 05:05:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niqup-0006yA-T1; Mon, 25 Apr 2022 05:05:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niqup-0002jv-Q3; Mon, 25 Apr 2022 05:05:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niqup-0007ia-E8; Mon, 25 Apr 2022 05:05:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niqup-0005O7-Db; Mon, 25 Apr 2022 05:05:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OZI+Nc3Rgsqq6rwIJ85PQ11G7TWivhXeTBwVq9jwcew=; b=HVB8FrnrZwqBPHDsGSS//cYNpN
	7wGacYURS0uz/ZzNZrCUpmvD75p+HcnQdFqAhhenPJr439RIjWK47KZAuy3OeIljRaXX1YkIrx3CV
	g1GwinW6lvq68aEBGDmdfAiktnR4cktlTHDSQx4IVBpXvAufa41kSs/7hFDLLQ/dcVtc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169698-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169698: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 05:05:39 +0000

flight 169698 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169698/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  612 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   54 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 06:02:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 06:02:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312366.529573 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nirnu-0005MS-Iq; Mon, 25 Apr 2022 06:02:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312366.529573; Mon, 25 Apr 2022 06:02:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nirnu-0005ML-Ey; Mon, 25 Apr 2022 06:02:34 +0000
Received: by outflank-mailman (input) for mailman id 312366;
 Mon, 25 Apr 2022 06:02:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nirnt-0005LG-7S
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 06:02:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4ae2523b-c45d-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 08:02:31 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2055.outbound.protection.outlook.com [104.47.5.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-9P4aHIH3P4uSSssyD2f1xw-1; Mon, 25 Apr 2022 08:02:28 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5383.eurprd04.prod.outlook.com (2603:10a6:20b:97::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 06:02:27 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 06:02:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ae2523b-c45d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650866550;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DI0mNHaVTQhsn0fbckggEE65l3p6hVlWm31IMwMt9NU=;
	b=WF11njSWtADStRc/2E00g8QuWHCpP51PKxWFunzGVDPl/dKrwnRmJ1I9itAe0ObpqnD9gs
	7KTJzqxWGm6Es50IJHaQShp7Ep4jjAOXm8WSLT6QYCs41G+/FCn71uuhD3DAdU7uZqhfab
	59O0581u0MAWDgWxVenv1R/VNpKvRsk=
X-MC-Unique: 9P4aHIH3P4uSSssyD2f1xw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wf3/ZJBpMh1g7w8qsl3LiA/1X0VMH1FOstLu7j1bg2QY0n4JjeiF4KQ/Nc65KDl8RMQlwhG1BO8/bUA3D2mWxCzXE6CZHUJKl1gOhBIzZl0fi45JNUsPfe2rUbuUZelNhcfcuCQnaQ+gbQRHwJSNH1T64jp6RHr1QrN9AtIYomxBQ3AQuQrBq2/gskRIFGLPiEDovk5nMsDHb4DNf6bJqIpKEwAct7dEtDRIlHtkisMk1VcULFHWoJjhBLXVq5s+ByWFvGhGmW73l7svmFIpKETb17+jRdsD8SaFqnYkzHO1gAiGrPbiAvP4RfAkE9lp9gLydpWuY13XwoT3KECNTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DI0mNHaVTQhsn0fbckggEE65l3p6hVlWm31IMwMt9NU=;
 b=PyzANgPiFpVkOMVhdCiOWxS671zvrnotFOkzwZAOE6gudHLuK8ULrXAX6rUra3vzk0mDn4bjGHsJIc8YCUmKX2Gs7SgbEbKjR1hR2V6eZhi41uzfdx4OhlcC1YE6iQcUtllLBvUkfz8fk4qF1Lvhiwzmc6PHcttAuSfqpsCfrmQejE8/gHquUagxNYJSJ7Nvf23t2zNjQiauuH3LCPvx8glKBT+n4rrjc6b0X41vLWEOAHv4u6rbpxGbU89eVgXQKTfPgDs4DamQPsHvbkk6O5po7HcvemolIjN6N7FMNxILhrJHQc1gpybA+4Z7vrqrFiT6MqIJHkb7TXCCB9hejg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <30b1dc39-4572-2980-df09-0fd06c5120ab@suse.com>
Date: Mon, 25 Apr 2022 08:02:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/efi: boot fix duplicated index, offset calculate
 operation in the copy_mapping loop
Content-Language: en-US
To: Paran Lee <p4ranlee@gmail.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
References: <20220424144414.GA17868@DESKTOP-NK4TH6S.localdomain>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220424144414.GA17868@DESKTOP-NK4TH6S.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0175.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7052b413-d28c-4dd2-8528-08da26812c9c
X-MS-TrafficTypeDiagnostic: AM6PR04MB5383:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5383E1A2322FCCFB87887EF2B3F89@AM6PR04MB5383.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xFFqZQskFWB++g8ji0lLvfU4YvkyNwx7ZNqTQLiQVccd7c/V7enBiv4b0+YFu+Jg+D2h3j7Q8kCS4pCngdpY42fIwZdNHORsLNh5oTw3mrjuWe+o9n5Dbp2Q0mSMLTttcP+WgaVKB7ufN5YpNvHoqd2AInGchRcfMJUuZPCiSvZETZ8mdaK45Kjq+Gq2igUmV52eBotvgIPZH9qOfz+4ZsnnUJIs1qTSlfYVIQWY917nlo6kh/9eNY5qfb4O7bHSdkGzXU6WAnuxqsUQUhubndpiJ0UrYdAxxAV0kasEyiCa4hChgaWGZ0wfsD+2IcgdvP3VZU8omDbemvMv6+BIdQV+MQ6ZEoOdhH0rC7cUX9hTvh5JDPWDdCFg/IjAW9x9uXtPzHI8CRaEOsufiLczpq0s+D6kcTC693/zm687MTOhosVvO7LQq1DHXOoUTtST0cjlsVqSgRJn4Cr9tAOBwILRdJbnJbhKyM3vlEU0ruCvzka0/gp2QoWA6OM1B/QHT2IqoU/VbKqJTMTKChYLp9mcgRhZzdT/OQlWfRtSniAU/AAeJMv2Dmo2PAdqJKFp63UublhtiMbZtb7Mna1dGPbD9tVEANcb+uZDypmd/WAXpaRClVrjwAg3wBiQ1bUZlstQLa2zMt4w/jaw9K26uAmYmIgxXRy1jx0tbhAcAp8GXf9rxewsW8d3D2vtQUvLGWRf4R8ozXbhhj7hSiwY5LSR88wXjIg09mbKguIe6KM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(31696002)(86362001)(186003)(38100700002)(8676002)(2906002)(66556008)(66476007)(4326008)(508600001)(36756003)(31686004)(66946007)(6916009)(6512007)(5660300002)(26005)(316002)(6506007)(8936002)(6486002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZWNYcU9wTnhFbkthMUlHVHpCM0tVYXlTclFSVGFrUW9QT1lPOGw1ekpDdGxv?=
 =?utf-8?B?cit0aVdyUkU2Y25lR014Zk54Vkl2Z0ZQLzE3RXd2SlJyOGlzcU1MK1NIRGhY?=
 =?utf-8?B?NEo2ZytVTzZMODN4M3RMMDl3Y0dLbWdzdXJocU95dkpjRFZvMCt4WFNDRURu?=
 =?utf-8?B?bWFmck1UVnZvTERiY0dCYU1qK1drVnJPZTJMbDNDNWg3cEFXb2h2enEvRGFX?=
 =?utf-8?B?b0VOMS9XSDNLNk9pMFlWeWlhVFNRRS9jU3JKcmE4SVF3T01La1VmbVBpUTFY?=
 =?utf-8?B?TmF6YkRtd1hIeUY0YThoNnpTTDNHSDZlUjF6dXBjQVBZVEJKdklTcms2cVZp?=
 =?utf-8?B?Rm5panh3eUgxMUFRcG92QzJmbXRVUHdSbnpFdDE5bjREUXEwd0Z0US9kU1Br?=
 =?utf-8?B?dWR5eHp5SFBYL1F2bHJMemZpMDJaU1pZUFZ4WGhCVlRsWDhTWTdPbDlHVkd2?=
 =?utf-8?B?R3lOdmtrZHFMakRZRGlTZnRza3BjcisvTjkvenpNczBaUnJSNy81RHlwOWI5?=
 =?utf-8?B?MURnbjU0eldpMkdnMFBQMlgycUh0ckFnbWVveFhDb3ZrUGxlaUtjZFdVTkdz?=
 =?utf-8?B?R1BqYlN3SmhrWFlENXc4Q014akJSMTIyWEpQMGEva3Q5SUhEYkVmT2x0Rml2?=
 =?utf-8?B?TDdMeGZ6QkQyNnF5c3dmeitmUytjeXo5NEFvT0o1c1lsL09IcFV4ekRYWVZR?=
 =?utf-8?B?VmtMbHF0UTg2d1IyWlpZZ0V2YURlVDVoekRKYTh6bUZ1WGRua0Z0alg1Nkth?=
 =?utf-8?B?WlRVZDhHemVWODlCM3Y1aTlyQm9uUW9Pb1BrYkpKSXlicmRDcDNabHJPaVRm?=
 =?utf-8?B?SlNQdUJzTmlwTlBJTkJXMytsbEhqSklPY3AxMWNjUkVQdXVFcGZudmxjTVpz?=
 =?utf-8?B?OExPNkZ0Q0c3Z01OMXZmK1dMZlYyZzU4SWlBNVVPckw0N1BIdmF0QUUvbVZ1?=
 =?utf-8?B?MGZTZFNlY0w4VUJlN0Z5bGJPeHdiSFEvZDl4b0tPY3EySmZpWkZuZnBQb21E?=
 =?utf-8?B?TFZLT3JkdGlaVkRBVXlhRC9qcTBkSDlmZG5JTFJtQXhZRHR1V3l1ZEtob0JN?=
 =?utf-8?B?MTdvWVdFaWlrODNpS1ptSk5rRTJwaWdYR2hFOXhzR01Wb1E5RURpc0U5MlpI?=
 =?utf-8?B?MFhvaWUzNGlpTGtwZzg1Z2FiaUpPU2lUVkdpS240WGhTVXBRREt3MlczbVRy?=
 =?utf-8?B?aWtxSFZLMXBmUHBhZDNhazg3WXlhRTNHWU1DRWFnb21BWUVzSmwrR0ZINXF5?=
 =?utf-8?B?UTVVT1pTYWN0aVgxK0s0a1VvVWJlZDd1cWRxUmJhZW9oQmN6bFl0MFJJbktz?=
 =?utf-8?B?dWl2dXhaZC9VdTRjcmdIZzdEVkY3Nk0yMnJQZk90MndVU2w2aVJHYkZxK29F?=
 =?utf-8?B?VThLVHhKRVN3Q1RXdHEwdkQxcDVwWGhEZGcrUUx2ejZPUjZDNGNReVZuYXhY?=
 =?utf-8?B?OWd4bEdxZ1NsZ1JhNHZTUmdsb1BJT2VNb0RCaFkrM0FyZU9Sd0NQNWVvUEVt?=
 =?utf-8?B?blJ6UXhPeXFUU1drWkF1YXpsOFNkSUhkK3RsVlJPZC9sbEdwZEY5WFJWMFVU?=
 =?utf-8?B?N1BxdTNZRkFaZUNjQmNTZkJzYXZFVjgyQlY1RGJHZHZiQWt3R0pKbnFxZjhC?=
 =?utf-8?B?clB4ZUhsT0hNbDhMZW9hUDBabVVWaUxpSThxSU54a1dFM1g3N1BneXRaZStK?=
 =?utf-8?B?S3UyWlRIOWErVGZVWndTQ3lRRTI4QnVBajZuVVpMWEFmbHNzeXVwaDJnRUFZ?=
 =?utf-8?B?YkczM0tnb0k1MDV3N2l5WWZyZ3A4a3JVRVd4WVpwdnBISmtuSkNlQ0hTM0RW?=
 =?utf-8?B?aXczWXBla0M4aWZEUHZXenFnZVFqSnpUYXZVSE5DVjlKV3JGZE1jdmhvWkhm?=
 =?utf-8?B?a29Xckg2TFBmNFp0ZHhYdW5WOGQxTFdmT0pBU1czQkd2TGV4eUdWd0Q3MmRu?=
 =?utf-8?B?dmRwcWRVY1hHT0FzRUZHVDJYa3J1Skc2bGhMcmFSbXNLQWYvc3prUVdlUk5S?=
 =?utf-8?B?enMvdWR5STdwR0dkRmZFczhJZERZOStGdW5Wek9IaGd5aVB0VHZ0UnI4UENP?=
 =?utf-8?B?c2FEMU5TcmtzUy82QTVLRmllSVBDdUJ6QVlreVVmOGViZDVrSm5jRVVTTHlm?=
 =?utf-8?B?SDgzUTd3S2FMMmtZcjdtdEVrM3BJcXU4SzY3Wm10eklyRkFuMG12NTBkdTg0?=
 =?utf-8?B?Tm81d1hFM1FZcGhPNERkb0xEeklNVkovMUxUWkhxOW9mWTJ5bUw3ZXZkWDM2?=
 =?utf-8?B?ZGN0eWY5MHVkM2ZLOVhGNStIckUyZkF0akNOaFA4RlFSWEZaZk5KWFF6dnNi?=
 =?utf-8?B?MkdOZnVFc3hMeEZlMGt3TGVrVkVpck9PV1dOcVBBQ3ZsNUJwRmRKQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7052b413-d28c-4dd2-8528-08da26812c9c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 06:02:26.9469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tTXaCq2KWHxsFTmMVnDb5PuLhNVoBUNjSKABckjU/IjMhX8A4DUAd2ffzfM6tuCuA80FIW68JfAN+Md6cPsHXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5383

On 24.04.2022 16:44, Paran Lee wrote:
> It doesn't seem necessary to do that
> duplicated calculation of mfn to addr and l4 table index
> in the copy_mapping loop.

I'm not convinced this is an improvement. If the compiler sees fit, it
can CSE things like this, but it may see reasons not to (register
pressure, for example). Furthermore ...

> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -1470,7 +1470,9 @@ static __init void copy_mapping(unsigned long mfn, unsigned long end,
>  
>      for ( ; mfn < end; mfn = next )
>      {
> -        l4_pgentry_t l4e = efi_l4t[l4_table_offset(mfn << PAGE_SHIFT)];
> +        unsigned long addr = mfn << PAGE_SHIFT;

... this isn't 32-bit clean (we build EFI for 64-bit architectures
only right now, but this should not result in there being issues if
anyone wanted to enable the code for 32-bit as well).

> +        unsigned long l4_table_idx = l4_table_offset(addr);

There's no reason I can see for this to be wider than unsigned int.

> +        l4_pgentry_t l4e = efi_l4t[l4_table_idx];
>          unsigned long va = (unsigned long)mfn_to_virt(mfn);
>  
>          if ( !(mfn & ((1UL << (L4_PAGETABLE_SHIFT - PAGE_SHIFT)) - 1)) )
> @@ -1489,7 +1491,7 @@ static __init void copy_mapping(unsigned long mfn, unsigned long end,
>  
>              l3dst = alloc_mapped_pagetable(&l3mfn);
>              BUG_ON(!l3dst);
> -            efi_l4t[l4_table_offset(mfn << PAGE_SHIFT)] =
> +            efi_l4t[l4_table_idx] =
>                  l4e_from_mfn(l3mfn, __PAGE_HYPERVISOR);

_If_ your change was to be taken, you'd want to unwrap this statement
now that it first on a single line.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 06:03:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 06:03:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312372.529584 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niros-0005vu-WF; Mon, 25 Apr 2022 06:03:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312372.529584; Mon, 25 Apr 2022 06:03:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niros-0005vn-T1; Mon, 25 Apr 2022 06:03:34 +0000
Received: by outflank-mailman (input) for mailman id 312372;
 Mon, 25 Apr 2022 06:03:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niros-0005LG-5o
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 06:03:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f97d4b5-c45d-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 08:03:32 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-D8nj5UUTOMOXKN3OC6yyNQ-1; Mon, 25 Apr 2022 08:03:31 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3551.eurprd04.prod.outlook.com (2603:10a6:803:a::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 06:03:30 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 06:03:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f97d4b5-c45d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650866612;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Qla4iPLvTB9bgTz1l2+vBOmKGjCe/BAEs8SusRxRU9k=;
	b=ILudyZuC8mAea4nZJQkx4eQRyznY3YeBsV0CcOgdd7HlMOXoYD+BIYg6j9DT/IMa0e9Q7V
	autPung6KfcPdIgqqSE4kTVDfDnudZCY4H7FXDuVXGRzq3trGZ4w+pmp1RCce76yohbxPG
	XWXKUeb82awwha0Ac/zOd+p+MiZHFp8=
X-MC-Unique: D8nj5UUTOMOXKN3OC6yyNQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y2irF/+W7A1ZM1qMAqDBwZ/ciExcz6c8PzuCx+zXyltDzI6clkwUEtQ6did/58bQOWfJMHoGtyvFqcKgkxIzqvcYjKUtcw6/VHsaQxZxO5Dh2XBPiWBi8b/+/pn3iOZXSuivKodvwt3VNAaJngdBZXBl+2kiW9vTpnjEZI+00ZsTcZkOVNXNl7jLsioLhBHlV5d3E6J2L3d5spkb1mBiVGzKZDI75lY29x7G6U/GAThtrwhYGMVJ8SbGGSrogam9h+CrCWfzZ4sOQWehXDsAah0ZBzsj2OfNtACP3yrIXmLqdOJkwwsi8uUvslhjDz9oy2x4OXaCT3wN6sl7iddhYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Qla4iPLvTB9bgTz1l2+vBOmKGjCe/BAEs8SusRxRU9k=;
 b=jzTi7Dt7hhWJlkquIz2aCTIAK4Z8u3/gr/jrTERkT3v3H3xgXb1VEgV4vtdq1Hp6YhAvhEs26z5ee9LNisHrVnGIW68XOk96oNRXrBs6KjlUe93FSWezmzQRm4aKGt0euJ/JtaaNfPpUAlIQ6XN+QUYDGjfpFgUScZQ4lMh7R6bR3T3aXcccBosJX3amtYvmpdthbi99bXA+i3dIhN+S+cwXaxvqgDvnOJ6CrtnKl8r5BBGkJ7itmojdoPHmbkDZNOH/pQY2hJxDbrNjfRa1f0x3kxmV6qrmSfVkrwPbRwAMoTKFvZw0dUbHwYwmjbdDpDESNA2G3EOnhf+xe6Xniw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <de23d880-0494-1712-da7d-052fdaa28287@suse.com>
Date: Mon, 25 Apr 2022 08:03:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/efi: boot fix duplicated index, offset calculate
 operation in the copy_mapping loop
Content-Language: en-US
To: Paran Lee <p4ranlee@gmail.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
References: <20220424144414.GA17868@DESKTOP-NK4TH6S.localdomain>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220424144414.GA17868@DESKTOP-NK4TH6S.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0013.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::26) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ff3e953f-c796-472e-de49-08da26815231
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3551:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3551AB2A42D59E4959A8D8B8B3F89@VI1PR0402MB3551.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hyxg2SN3MvMTo20E1nd5w+3YEV+t4BQQgahygZ63yOhkaeq6VBdOGtvLU6/3xVIlOApxyMkC0nRrNBfksEwdTAch0Q2nJ92st8n56tVzN/HJCViAM132x0Sox1z0Olhtjf2CYWufhkxo4cYvsvSG2hyODdtwY/f1DWA5i9qmfJcU8urh1PMUt6s9AKkc4qICiL56+m4iODcumCZDQXr6awFwuMNIYmGR+t+fhuBu5tJpmB+/xMR5UqwlL5llF74APzXc3aoGnZRFNcLbj3cHi9OGYtC3tjbJaiDg4vGbpNjTmvh/Sdwmvi3Qx2Xx7WSAHySnp1OgDjKDNQFUwQOhpeoUEAmnNc4pyDovSe0MQnI7CY1u1cngGk7M1+bjyD85bCWSo4Ks4w4KB2OXL8caeUqS6ry3Rel+O0C83em9vIhzJItlbcREoDSMEcHrQTKNK84ZfryKxqRb72PM6w0C4bJAjVjb59Ib9QKFjkuId/r7OpHfnoiQP293cdPKJHqqIvwaDYxH/H8Hq8hjIPXRheZOOHJbRdjJhTrE0FhtbYS6YSDVjozGRkcQtGgQFJwpINUmk36JoZiS+9oV/FSu2p7Pk0IA3Nyhmd3t/rMTBYuqwtxG9uHD8t0+1IFfNooTPIFuWkZpsbKl49K8OdaOu7wVuXpQyAKewweUG40frzTmS1XZ/deYVn5qWrAl4HtMf7/vEjceDYCicSSOS/dfKTbkEmQwjOEWlKOxujdtXrA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(31696002)(508600001)(53546011)(86362001)(2616005)(316002)(8676002)(2906002)(36756003)(6506007)(8936002)(26005)(38100700002)(31686004)(186003)(6916009)(4744005)(6512007)(5660300002)(66476007)(66556008)(66946007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VS9lK3FpYjZuVnNiRmhVcFhjeElWbkJRM2RHeUxSVkV5emdWTGJLVlZFYVlo?=
 =?utf-8?B?ZHRjZ2VkMUVDQzNjT3ZZcDdTZVZIMlV4OVJycTh0US9va1hIL0IvQURJbmth?=
 =?utf-8?B?SlJ6dWk3WWkzYWVsT2tQL240MnZHT3Q1TmVDTFhjb1F1WUd0QzFOZXN1TDZX?=
 =?utf-8?B?NjcyRTFuQTl4TmNMOU9IZG1URFk5MTM1dmxMVlp2RGV3U0lsQ2s0NHhlTXNM?=
 =?utf-8?B?aW9ROFBMRlo0U2ttMmRqSGhsaWJKclF2TTdscDZuN3Nra0EzSHYwUE43U051?=
 =?utf-8?B?bkFVU1pDbFVxSUo4SFgwTWk2LzQ0NW4zZ2JyNUI5amdsWmhUb3NEaExEbk02?=
 =?utf-8?B?NStTRzNSdUxlQjBuR3NyZURJUm40cVlLdE5rNGtnWk1KOVFRdW40ZWZhSk50?=
 =?utf-8?B?eDlteHlkTzF4MmJ1akUyQkFXRnJWenZ4aW42eDllU3VSVzVrUEdxZFZBcUJV?=
 =?utf-8?B?bUdiT2UvckVJVVR5aEFwR0NlQVdTRDcxcmc4U1BkNU5wWElKMzVwNmNKMnI1?=
 =?utf-8?B?VllOTzUzdk8wRG9ITmhXK0duMm1Bek42eGJDNG1iL2RRYW9SM05Bd0lDdjBa?=
 =?utf-8?B?OHNDTmNQZnRZcXd2REluSWJzVmxwTHp0b2FmTEcrb2ZMNmg4SlVXM0M0RE8v?=
 =?utf-8?B?NGw5akJtZVZldzVXNnFlUE0wcVFGMVdDUVB6SlVhZ29rZTVHNG5SR2QwRXE0?=
 =?utf-8?B?VGlDNlRPRVRuOEhoanFRTXN3bjlDaU84OTJRK1FqcGVpVkMrZ1pxZG9yQTQv?=
 =?utf-8?B?Tm5JRVFvN3Y0V2h3QTlNVHA5U2tQUlpUNEhTN2pYVjNaclY1Wm1rS1h4ekt4?=
 =?utf-8?B?SUpJd1FmS295dFRSTGdxNzRpS2lBNm5rcEt0L1N3KzBlRkx0bTRzSjJONTQv?=
 =?utf-8?B?dUpiRTYxTHZFa3ZvNmE5V1dienZDcC9LVEkxVFFJSXRvSEZ3T2p3TmlETXZY?=
 =?utf-8?B?VzVqMU0yUXZZNHdQc1UvVityUzlyazRna3Q2cit4elF5UTI5OE9waDZhWUJn?=
 =?utf-8?B?aml2cEdXdnV6dTZqd21XcERwUnh6K1JPQlUrME90YnNOMnc0aUR3VHJVdDgy?=
 =?utf-8?B?eVhnSmx4Rk1QWm1vNnV4VUliS3gweks1SWtKZ0tLcUNPSXR3OHN5eEJkbk9a?=
 =?utf-8?B?dWFvTnk0b1BhRU5PdzZwRHhkdjlZNGpqMEJJaGd3VEgyQXd4S1lWU2tmUUxF?=
 =?utf-8?B?b3Z3UXFYOTZQckcrbFo5dHpFVlp4d1BWVU55eXVBeXhNZkgwYXIrWWpZZy8y?=
 =?utf-8?B?eW5wdzNaZU82OVBrMFV6dENET0dJTFhRNnJ5ZTYvSnAvVDhURmhkeHBXZXhR?=
 =?utf-8?B?UlBSb3JIVlpNZUVRUkhVR1Jyc0x5TUx6MzFmRGNYNTNzNU9PWUpyNWdoUWsz?=
 =?utf-8?B?YUxxOWFPRTViR3RRTGdwZks1ekxodU8zaTNtaWc5SEF5R2lIVGdGNkNsMjR1?=
 =?utf-8?B?M0V6SFZqVXFIWXpETy8ySUJrclZQRnoxZlc1VkNnaFdBWEhPWUVQTC9lb0xu?=
 =?utf-8?B?VmxyMldoZzhXT0tPSWowN2ZMOHkxOHhNTnlaTE1iZmFjOUxSREZzeU9kbk9v?=
 =?utf-8?B?Qm5yU2dSUnpBSE94Mzdkdncxb1U0UjI3NGw4MDA5WURtZHpvNkhBbHJqVFBW?=
 =?utf-8?B?aVhhUnVTdHA3Uk94elkyMGl1dGhwa2V1SnhDS3NpRi9SczBSOS9RVHpYOEh6?=
 =?utf-8?B?SUlHalJNY0RJZUgxVkNwR1k3VThSK2k3WFp2aGhzc0FNRzRsMVJsOUVsdktL?=
 =?utf-8?B?RGhvUnlxcnF5MDRhVm1ack1hWnM1dEtHQktvdXFYVmViVjNHK1UxN1JPcW9u?=
 =?utf-8?B?OS92WDgzcHRDaWt0L01xbFFCdHVSM3krMVVRaEJsRUJkejlRc1BnbGIzWWhF?=
 =?utf-8?B?cVQyKzFzZG1sSzVLL1Y5VEgxZVdNRVhBVlFsTWJoSjNoYzlna1o5bGNocnZh?=
 =?utf-8?B?ZzJxcFExUkE0OVhpT3kzWjRHL2tKYU1UWHY0RGdnak52T0R3MXFBOGozYTUv?=
 =?utf-8?B?OVJYZUptMGQ5YUI3bnJJVVJTMG13RkJ1Si9VTi8wTmVTMWZCWnFQdFI5Z3c5?=
 =?utf-8?B?ZHpERXFRVTkvbDlxN1JFbTNWRWk3UW5WOVhTbW1CRHFXRjVvSm1zREg4U2F6?=
 =?utf-8?B?akh4UGFTeVZEcUZRU0U4bnN1ZitVSzJuU2ptRElZeWtRQzBWK1NJaGdRRTJ5?=
 =?utf-8?B?RTBxMFl5bzZhTmJCbm5lVlllL0FPd28raTZVbGRpczBINDl5V3FBWFVwb1F5?=
 =?utf-8?B?NWhicVcvenV3WVRCZFhreHVUS1Q5ZWIxUEpja2N3VFMvVkhTaG5TODNETUkx?=
 =?utf-8?B?RG54dHR4Y1RWODBGY2lBWDB2akxUL1IxL291a0Rjc2ZEWDBuOEFRUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff3e953f-c796-472e-de49-08da26815231
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 06:03:29.9701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fvex53t9k6DQszzXxM2ScTSmSFNhkcx4cIUIkqJWEZSa2T16yKq7PsDyDL1RWiarQvPnaENGRXjBYqj6zbUc6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3551

On 24.04.2022 16:44, Paran Lee wrote:
> It doesn't seem necessary to do that
> duplicated calculation of mfn to addr and l4 table index
> in the copy_mapping loop.
> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>

Oh, one more thing: Please submit patches _To_ the list, with maintainers
on _Cc_ (not the other way around).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 06:34:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 06:34:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312382.529595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nisIq-0001L3-Dm; Mon, 25 Apr 2022 06:34:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312382.529595; Mon, 25 Apr 2022 06:34:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nisIq-0001Kw-Am; Mon, 25 Apr 2022 06:34:32 +0000
Received: by outflank-mailman (input) for mailman id 312382;
 Mon, 25 Apr 2022 06:34:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WklX=VD=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nisIp-0001Kq-2V
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 06:34:31 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2061c.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::61c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c1ceb760-c461-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 08:34:28 +0200 (CEST)
Received: from AM6PR10CA0007.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::20)
 by AS8PR08MB6040.eurprd08.prod.outlook.com (2603:10a6:20b:296::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr
 2022 06:34:15 +0000
Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:89:cafe::67) by AM6PR10CA0007.outlook.office365.com
 (2603:10a6:209:89::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17 via Frontend
 Transport; Mon, 25 Apr 2022 06:34:14 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Mon, 25 Apr 2022 06:34:14 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Mon, 25 Apr 2022 06:34:14 +0000
Received: from f0ccd9030bb6.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6A455389-9614-4B62-95B6-30FD964E1B5E.1; 
 Mon, 25 Apr 2022 06:34:08 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f0ccd9030bb6.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 25 Apr 2022 06:34:08 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by VI1PR08MB4285.eurprd08.prod.outlook.com (2603:10a6:803:f8::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr
 2022 06:34:05 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 06:34:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c1ceb760-c461-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jkal6/YU0n5LBmLH7Yzxro58HxLEMfm0NgF34Y+Tx5k=;
 b=4Y4Hj4QtJbe7KGkCDaM/pNRZzN/1jvu9FJJleG0r76kmk2SY/NyX3RpxswKA3Wb7iSGHcZGggurl0d6ftna4KryPqiJeR6v5X0lyHol5btBafo7y7CxWa5ZaAMaFWj9VSeN57S2xn6jvL+OZ3TGrosViIb9p/k0EGC6xyo8D1RM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TlBqES71IlnAFTFuVooyWu2iMMcRUu/a3zhqafQ7rnQHH/kN/Zw/TslBVKj5OBdzxcI8gjC1+vX5ThuEe/eXbG7Exy/TyoBbzKJELKZAAcmk9s9Lny44aHPqGMSZz53L91r7ooV9H7L2Xm0lDtvTnj+xGj2nUg6D0KBQr/P/wXMAX3T8q01M8NQ2TZXOO5fiqhbgg2pMyaWHFEByY/h4VBP/Z3SODSP+QVxLyMukfnOrITkrYiDNQz89pK3D9aW0T3C4YIoGPFm+PlNwGgULVMNAXdg+Toj+9JDug23nRiOa3Rd57VWAnHHR4W0gyyjdwe2EqX6Pgu9woLc8+r1sjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jkal6/YU0n5LBmLH7Yzxro58HxLEMfm0NgF34Y+Tx5k=;
 b=mtbyQTFCNomnbqgSQfv1dNbTdVxTGFFJBDlcEgmYOrAE/YxmPwduvUFlJ8M5YLFl8icaf1QDwzqaE3de/v2F91+U5YfDjqgr6xB4uTPG3eO/HzdPrrbcVbG5PmuMGQfPLadkHQekqtIHRChyqpDdd17PtSIiRy11Ut0Ekwu1spTzUO5xigL/MyQZkzWRoJM4Xx35P+nSrgYNCCwrCrh3fttvoXWE+sFwkkQFnp+DX7gAN7703mc8E9pFoCLmLKIn0vI5DjFWtAmXlnpzqeBXDu8kv4kudnf5wpnzrvv+xmobDQSM7do+0/iZaP+UJ0/dZw459Mr/ubHE6fNlMNl45Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jkal6/YU0n5LBmLH7Yzxro58HxLEMfm0NgF34Y+Tx5k=;
 b=4Y4Hj4QtJbe7KGkCDaM/pNRZzN/1jvu9FJJleG0r76kmk2SY/NyX3RpxswKA3Wb7iSGHcZGggurl0d6ftna4KryPqiJeR6v5X0lyHol5btBafo7y7CxWa5ZaAMaFWj9VSeN57S2xn6jvL+OZ3TGrosViIb9p/k0EGC6xyo8D1RM=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Wei
 Liu <wl@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2 5/6] xen/arm: unpopulate memory when domain is static
Thread-Topic: [PATCH v2 5/6] xen/arm: unpopulate memory when domain is static
Thread-Index: AQHYUx8sjuusUaZZhUW8Wxz6RmBB9Kz29IIAgAk/PSA=
Date: Mon, 25 Apr 2022 06:34:04 +0000
Message-ID:
 <DU2PR08MB73253426B332CFF5358AB346F7F89@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <20220418122251.3583049-6-Penny.Zheng@arm.com>
 <b76b3207-4eb7-5236-6812-d64cd4dad17f@suse.com>
In-Reply-To: <b76b3207-4eb7-5236-6812-d64cd4dad17f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: A58FCC2E272575478CF8F592BF4A41F4.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: d6f7b370-185c-487e-8bdc-08da26859dc7
x-ms-traffictypediagnostic:
	VI1PR08MB4285:EE_|VE1EUR03FT055:EE_|AS8PR08MB6040:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB604070DF2DA0D5CA5A9B86FEF7F89@AS8PR08MB6040.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 osPzJoGmmZkjz497HdFhYZtg/vEU1TSZNXXVl9K9C/i/uH3cQMbr7kHkdvyvYelmlnl1TZ9HWtC1yB6PzgtRGa7CanKLQ0UnRLGvfK/pJDBVJ1vah2Kar9ov+Tq5jj86nJpdOoO+ukpqFvxlrcH+GELbEIhDvPSh0xNfIXC4Qt5XooS46BkbC/LTpDuANFJ0BUy2rhNiwtcQ9G9nq+dUM2o/JfntL9d+g7YW6982NapXp4x/oM//Cm5BAGjwYpfxPG1MSXp8r6fCeboAchxDJDmCQWsZCDYk+qtrpya3yPoPIrdhS9ElIVTTfEV7tY3B08JBqC47n//XtEdQzkzOeCHedNL8dlTFu92zScCZIcPAOWcBze75zO4QKfjNLMlC40Mb4lzfDSWbLkEB8w3iNGteP5XnjXGBY8NnoHAf0QRNzaZqm596+FqKSaTBToM8XGbzzBQCAe41cDf6k8vG6ByGEidy3wzI367X9ws260+Av712a7MWXOLuTR1xx/lz0Qa82SjBN5pOVERbAr80L3G60OMydSRrD9DgFQG6PR2ohdipD9+fYdKHlllsJLWV0AAEkFBwjfVYTDr95R0g1SDJpJghDWL4RGAvmhkcR/04R6wMDP4lLBV28AKjhtRu4+5m4NKJq0s9L6F93nSpyJioQwI8D5gqKWHdh6K/5/4QGlc4HJ6tgcrpvWeLRKUxq/9orIQdwDoXQGrCVweisg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(66946007)(66446008)(64756008)(66556008)(66476007)(8676002)(76116006)(186003)(38100700002)(38070700005)(26005)(6506007)(7696005)(9686003)(53546011)(316002)(6916009)(5660300002)(54906003)(122000001)(86362001)(33656002)(55016003)(2906002)(83380400001)(508600001)(71200400001)(8936002)(52536014);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4285
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	88bb452c-a22a-4a79-791b-08da26859802
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pEyCArpowSl8gKw/xw9j8MbOyh/O5fm13CnFxphGjGNO04b1HAh11AsrrjaKuVH6Dcxpk9j0HaOEGjO3nnXHxNUWknsA5+qVDXcOkMwmv0XNLIDTYP8LTvmznRu+iO0qvjdGBxPE26WQqHWTODBBrc8JISHQs1C5dYB7gpywUiM3OvyK3CtrIaqcgwL8dOsk7dhBo0ZE46I9vK6ryTu8PeIKKcucwlGWR6fj/QSYdka778egvqwp2Ik4IFfk5CjIDjp9uxnW9BbiMakWuHfLuPZXZAPAK5hqXM6c5gEggDDk25icSWSNPSEyH/EVVJnq/136pXliS5V8DBpyU+5laYtsrLXQilOspMv/zZzmNwpGYTV14alGW5WmL0TQPLmx5Tpg+VaFOP/7f9RigpgrsTuTqG29ILrneMDxJwk8DRHD4h7oo+qkr63LD8BAvyxmaZdzDMyjV/fRL7EzlbBLi7ZlyZn1QPNsZBlis+M0EinwiBtt+L3Efiu2TjXHUuIAxkqXa9GaU45bRymeNV3MEmxYN6k8/ArpsA9h54qF830++H0MasEMrPnYPRy7sI9QgNhmWokenSVqMMxxKp12Jjs26/rCfNQeu8c5da5ajhwD6TfdyxraMXuz4IbXw7huSnmq9MH+PmBvEpA480tEA+l21jlWrCyI2/pD4J6zC2lETY29QczjkoAT8JM3pcj1
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(8936002)(52536014)(9686003)(83380400001)(26005)(54906003)(316002)(5660300002)(36860700001)(47076005)(336012)(33656002)(186003)(6506007)(53546011)(7696005)(82310400005)(2906002)(86362001)(508600001)(356005)(40460700003)(55016003)(70586007)(4326008)(6862004)(8676002)(70206006)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 06:34:14.4779
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d6f7b370-185c-487e-8bdc-08da26859dc7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6040

SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUdWVzZGF5LCBBcHJpbCAxOSwgMjAyMiA1
OjExIFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IFdl
aSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVs
bGluaUBrZXJuZWwub3JnPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IEJlcnRyYW5k
IE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVr
DQo+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEFuZHJldyBDb29wZXINCj4gPGFuZHJl
dy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJp
eC5jb20+Ow0KPiBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2pl
Y3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgNS82XSB4ZW4vYXJtOiB1bnBvcHVsYXRl
IG1lbW9yeSB3aGVuIGRvbWFpbiBpcw0KPiBzdGF0aWMNCj4gDQo+IE9uIDE4LjA0LjIwMjIgMTQ6
MjIsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2Fz
bS9tbS5oDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL21tLmgNCj4gPiBAQCAt
MzU4LDYgKzM1OCwyMyBAQCB2b2lkIGNsZWFyX2FuZF9jbGVhbl9wYWdlKHN0cnVjdCBwYWdlX2lu
Zm8NCj4gPiAqcGFnZSk7DQo+ID4NCj4gPiAgdW5zaWduZWQgaW50IGFyY2hfZ2V0X2RtYV9iaXRz
aXplKHZvaWQpOw0KPiA+DQo+ID4gKy8qDQo+ID4gKyAqIFB1dCBmcmVlIHBhZ2VzIG9uIHRoZSBy
ZXN2IHBhZ2UgbGlzdCBhZnRlciBoYXZpbmcgdGFrZW4gdGhlbQ0KPiA+ICsgKiBvZmYgdGhlICJu
b3JtYWwiIHBhZ2UgbGlzdCwgd2hlbiBwYWdlcyBmcm9tIHN0YXRpYyBtZW1vcnkgICovDQo+ID4g
KyNpZmRlZiBDT05GSUdfU1RBVElDX01FTU9SWQ0KPiA+ICsjZGVmaW5lIGFyY2hfZnJlZV9oZWFw
X3BhZ2UoZCwgcGcpIHsgICAgICAgICAgICAgICAgICAgIFwNCj4gPiArICAgIGlmICggKHBnKS0+
Y291bnRfaW5mbyAmIFBHQ19yZXNlcnZlZCApICAgICAgICAgICAgICBcDQo+ID4gKyAgICB7ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXA0KPiA+ICsg
ICAgICAgIHBhZ2VfbGlzdF9kZWwocGcsIHBhZ2VfdG9fbGlzdChkLCBwZykpOyAgICAgICAgIFwN
Cj4gPiArICAgICAgICBwYWdlX2xpc3RfYWRkX3RhaWwocGcsICYoZCktPnJlc3ZfcGFnZV9saXN0
KTsgICBcDQo+ID4gKyAgICAgICAgKGQpLT5yZXN2X3BhZ2VzKys7ICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgXA0KPiANCj4gVGhlcmUncyBubyBjb25zdW1lciBvZiB0aGlzIGNvdW50ZXIs
IHNvIEknZCBsaWtlIHRvIGFzayB0aGF0IGl0IGJlIGludHJvZHVjZWQNCj4gb25jZSBhIGNvbnN1
bWVyIGFwcGVhcnMuDQo+IA0KPiA+ICsgICAgfSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIFwNCj4gPiArICAgIGVsc2UgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+ID4gKyAgICAgICAgcGFnZV9saXN0X2Rl
bChwZywgcGFnZV90b19saXN0KGQsIHBnKSk7ICAgICAgICAgXA0KPiANCj4gSXMgdGhlcmUgYSBw
YXJ0aWN1bGFyIHJlYXNvbiB0byBoYXZlIHRoaXMgcGFnZV9saXN0X2RlbCgpIHR3aWNlLCBpbnN0
ZWFkIG9mIGp1c3QNCj4gb25jZSBhaGVhZCBvZiB0aGUgaWYoKT8NCj4gDQo+ID4gK30NCj4gDQo+
IEFsc28gdGhpcyBlbnRpcmUgY29uc3RydWN0IHdhbnQgdG8gYmUgYW4gZXhwcmVzc2lvbiwgbm90
IGENCj4gKGNvbXBvdW5kKSBzdGF0ZW1lbnQuIEFuZCBpdCBwcm9iYWJseSB3b3VsZCBiZXR0ZXIg
ZXZhbHVhdGUgaXRzIHBhcmFtZXRlcnMNCj4ganVzdCBvbmNlLg0KPiANCg0KI2RlZmluZSBhcmNo
X2ZyZWVfaGVhcF9wYWdlKGQsIHBnKSB7ICAgICAgICAgICAgICAgICAgICBcDQogICAgICAgIHBh
Z2VfbGlzdF9kZWwocGcsIHBhZ2VfdG9fbGlzdChkLCBwZykpOyAgICAgICAgICAgICBcDQogICAg
ICAgIGlmICggKHBnKS0+Y291bnRfaW5mbyAmIFBHQ19yZXNlcnZlZCApICAgICAgICAgICAgICBc
DQogICAgICAgICAgICAgcGFnZV9saXN0X2FkZF90YWlsKHBnLCAmKGQpLT5yZXN2X3BhZ2VfbGlz
dCk7ICAgXA0KfQ0KDQpJJ20gdHJ5aW5nIHRvIHJlZmluZSB0aGUgYXJjaF9mcmVlX2hlYXBfcGFn
ZSgpIGhlcmUsIGJ1dCBJJ20gYSBiaXQgY29uZnVzZWQNCmFib3V0IHRvIGxldCBpdCBiZSBhbiBl
eHByZXNzaW9uLCBub3QgYSBjb21wb3VuZCBzdGF0ZW1lbnQuICBEbyB5b3UgbWVhbiB0aGF0DQp5
b3UgcHJlZmVyIHRvIGxldCB0aGUgaWYtY2xhdXNlIG91dCBvZiB0aGUgYXJjaF9mcmVlX2hlYXBf
cGFnZSgpPw0KDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 07:43:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 07:43:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312393.529606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitNU-0000j4-8X; Mon, 25 Apr 2022 07:43:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312393.529606; Mon, 25 Apr 2022 07:43:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitNU-0000ix-4e; Mon, 25 Apr 2022 07:43:24 +0000
Received: by outflank-mailman (input) for mailman id 312393;
 Mon, 25 Apr 2022 07:43:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Y4oX=VD=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nitNS-0000ir-K3
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 07:43:22 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 60290383-c46b-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 09:43:19 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 47482210EE;
 Mon, 25 Apr 2022 07:43:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E1C4613AE1;
 Mon, 25 Apr 2022 07:43:18 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 7LO/NRZRZmLQZwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 25 Apr 2022 07:43:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60290383-c46b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650872599; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZemnL4BqPVn0sRoQ92YEUPsRWL1/aLlQAV5NeHgO9XM=;
	b=HNBD2gmxQiinaiXLTAVtbJmBjIuCoIaIPpsMRjRkRjEnuTns06PKg/H193fzMvrIgzeM9N
	YXoK1S3EyJLEClLew+o8XXwCkQFPsdl4tKdMYRVaoeUkL2+kiZuj//0pbLYFeeANX8jLAu
	PVZ1BXwac1NlmER/hxNbtoVLDH5igC4=
Message-ID: <6864c64b-246d-7ca4-371a-61d4953a781d@suse.com>
Date: Mon, 25 Apr 2022 09:43:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu
 <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
In-Reply-To: <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------0y3uPQdTz0ZSHZtGEQPoNPYz"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------0y3uPQdTz0ZSHZtGEQPoNPYz
Content-Type: multipart/mixed; boundary="------------rXqCqEUO8Lt6tagxLtf6Vqn8";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu
 <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Message-ID: <6864c64b-246d-7ca4-371a-61d4953a781d@suse.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1649442065-8332-2-git-send-email-olekstysh@gmail.com>

--------------rXqCqEUO8Lt6tagxLtf6Vqn8
Content-Type: multipart/mixed; boundary="------------gQZC9zbwTZhcj0YQy1fTYREg"

--------------gQZC9zbwTZhcj0YQy1fTYREg
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDQuMjIgMjA6MjEsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t
OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+IA0KPiBUaGlzIHBhdGNoIGFkZHMgYmFzaWMgc3VwcG9ydCBmb3IgY29uZmlndXJpbmcg
YW5kIGFzc2lzdGluZyB2aXJ0aW8tbW1pbw0KPiBiYXNlZCB2aXJ0aW8tZGlzayBiYWNrZW5k
IChlbXVhbGF0b3IpIHdoaWNoIGlzIGludGVuZGVkIHRvIHJ1biBvdXQgb2YNCj4gUWVtdSBh
bmQgY291bGQgYmUgcnVuIGluIGFueSBkb21haW4uDQo+IEFsdGhvdWdoIHRoZSBWaXJ0aW8g
YmxvY2sgZGV2aWNlIGlzIHF1aXRlIGRpZmZlcmVudCBmcm9tIHRyYWRpdGlvbmFsDQo+IFhl
biBQViBibG9jayBkZXZpY2UgKHZiZCkgZnJvbSB0aGUgdG9vbHN0YWNrJ3MgcG9pbnQgb2Yg
dmlldzoNCj4gICAtIGFzIHRoZSBmcm9udGVuZCBpcyB2aXJ0aW8tYmxrIHdoaWNoIGlzIG5v
dCBhIFhlbmJ1cyBkcml2ZXIsIG5vdGhpbmcNCj4gICAgIHdyaXR0ZW4gdG8gWGVuc3RvcmUg
YXJlIGZldGNoZWQgYnkgdGhlIGZyb250ZW5kICh0aGUgdmRldiBpcyBub3QNCj4gICAgIHBh
c3NlZCB0byB0aGUgZnJvbnRlbmQpDQoNCkkgdGhvdWdodCBhYm91dCB0aGUgZnV0dXJlIHN1
cHBvcnQgb24geDg2Lg0KDQpUaGVyZSB3ZSBkb24ndCBoYXZlIGEgZGV2aWNlIHRyZWUgKGFu
ZCBJIGRvbid0IHdhbnQgdG8gaW50cm9kdWNlIGl0KSwNCnNvIHRoZSBvbmx5IHdheXMgdG8g
c3BlY2lmeSB0aGUgYmFja2VuZCBkb21haW4gaWQgd291bGQgYmUgdG86DQoNCi0gYWRkIHNv
bWUgaW5mb3JtYXRpb24gdG8gQUNQSSB0YWJsZXMNCi0gdXNlIGJvb3QgcGFyYW1ldGVycw0K
LSB1c2UgWGVuc3RvcmUNCg0KVGhpbmtpbmcgZnVydGhlciBvZiBob3RwbHVnZ2luZyB2aXJ0
aW8gZGV2aWNlcywgWGVuc3RvcmUgc2VlbXMgdG8gYmUgdGhlDQpvbmx5IHJlYWwgc3VpdGFi
bGUgYWx0ZXJuYXRpdmUuIFVzaW5nIHZpcnRpbyBtZWNoYW5pc21zIGRvZXNuJ3Qgc2VlbQ0K
YXBwcm9wcmlhdGUsIGFzIHN1Y2ggaW5mb3JtYXRpb24gc2hvdWxkIGJlIHJldHJpZXZlZCBp
biAicGxhdGZvcm0NCnNwZWNpZmljIiB3YXlzIChzZWUgZS5nLiBzcGVjaWZ5aW5nIGFuICJl
bmRwb2ludCIgaW4gdGhlIHZpcnRpbyBJT01NVQ0KZGV2aWNlIFsxXSwgWzJdKS4gSSB0aGlu
ayB0aGUgWGVuc3RvcmUgaW5mb3JtYXRpb24gZm9yIHRoYXQgcHVycG9zZQ0KY291bGQgYmUg
cmF0aGVyIG1pbmltYWwgYW5kIGl0IHNob3VsZCBiZSBkZXZpY2UtdHlwZSBhZ25vc3RpYy4g
SGF2aW5nDQpqdXN0IGEgZGlyZWN0b3J5IHdpdGggZW5kcG9pbnRzIGFuZCBhc3NvY2lhdGVk
IGJhY2tlbmQgZG9taWRzIHdvdWxkDQpwcm9iYWJseSBiZSBlbm91Z2ggKG5vdCBuZWVkZWQg
aW4gdGhpcyBzZXJpZXMsIG9mIGNvdXJzZSkuDQoNClRoaXMgZG9lc24ndCBwcmVjbHVkZSB0
aGUgZGV2aWNlIHRyZWUgdmFyaWFudCB5b3UgYXJlIHVzaW5nLCBhcyB0aGlzDQp3b3VsZCBi
ZSByZXF1aXJlZCBmb3IgZG9tMGxlc3Mgc3lzdGVtcyBhbnl3YXkuDQoNCk9UT0ggSSdkIGxp
a2UgeW91IHRvIG1vZGlmeSB0aGUgY29tbWl0IG1lc3NhZ2UgdG8gbWFrZSBpdCBtb3JlIGNs
ZWFyDQp0aGF0IGluIGZ1dHVyZSBmcm9udGVuZCBkYXRhIG1pZ2h0IGJlIHdyaXR0ZW4gdG8g
WGVuc3RvcmUgaW4gb3JkZXIgdG8NCnN1cHBvcnQgb3RoZXIgdXNlIGNhc2VzLg0KDQo+ICAg
LSB0aGUgcmluZy1yZWYvZXZlbnQtY2hhbm5lbCBhcmUgbm90IHVzZWQgZm9yIHRoZSBiYWNr
ZW5kPC0+ZnJvbnRlbmQNCj4gICAgIGNvbW11bmljYXRpb24sIHRoZSBwcm9wb3NlZCBJUEMg
Zm9yIFZpcnRpbyBpcyBJT1JFUS9ETQ0KPiBpdCBpcyBzdGlsbCBhICJibG9jayBkZXZpY2Ui
IGFuZCBvdWdodCB0byBiZSBpbnRlZ3JhdGVkIGluIGV4aXN0aW5nDQo+ICJkaXNrIiBoYW5k
bGluZy4gU28sIHJlLXVzZSAoYW5kIGFkYXB0KSAiZGlzayIgcGFyc2luZy9jb25maWd1cmF0
aW9uDQo+IGxvZ2ljIHRvIGRlYWwgd2l0aCBWaXJ0aW8gZGV2aWNlcyBhcyB3ZWxsLg0KPiAN
Cj4gRm9yIHRoZSBpbW1lZGlhdGUgcHVycG9zZSBhbmQgYW4gYWJpbGl0eSB0byBleHRlbmQg
dGhhdCBzdXBwb3J0IGZvcg0KPiBvdGhlciB1c2UtY2FzZXMgaW4gZnV0dXJlIChRZW11LCB2
aXJ0aW8tcGNpLCBldGMpIHBlcmZvcm0gdGhlIGZvbGxvd2luZw0KPiBhY3Rpb25zOg0KPiAt
IEFkZCBuZXcgZGlzayBiYWNrZW5kIHR5cGUgKExJQlhMX0RJU0tfQkFDS0VORF9PVEhFUikg
YW5kIHJlZmxlY3QNCj4gICAgdGhhdCBpbiB0aGUgY29uZmlndXJhdGlvbg0KPiAtIEludHJv
ZHVjZSBuZXcgZGlzayBwcm90b2NvbCBmaWVsZCB0byBsaWJ4bF9kZXZpY2VfZGlzayBzdHJ1
Y3QNCj4gICAgKHdpdGggTElCWExfRElTS19QUk9UT0NPTF9YRU4gYW5kIExJQlhMX0RJU0tf
UFJPVE9DT0xfVklSVElPX01NSU8NCj4gICAgdHlwZXMpIGFuZCByZWZsZWN0IHRoYXQgaW4g
dGhlIGNvbmZpZ3VyYXRpb24gKG5ldyAicHJvdG9jb2wiIG9wdGlvbg0KPiAgICB3aXRoICJ4
ZW4iIHByb3RvY29sIGJlaW5nIGRlZmF1bHQgdmFsdWUpDQoNCkFuZCB3aXRoIHRoZSBob3Rw
bHVnIG9wdGlvbiBpbiBtaW5kIEkgc3RhcnQgdG8gZmVlbCB1bnVlYXN5IHdpdGggbmFtaW5n
DQp0aGUgbmV3IFhlbnN0b3JlIG5vZGUgInByb3RvY29sIiwgYXMgdGhlIGZyb250ZW5kIGRp
c2sgbm9kZXMgZm9yICJub3JtYWwiDQpkaXNrcyBhbHJlYWR5IGhhdmUgYSAicHJvdG9jb2wi
IGVudHJ5IHNwZWNpZnlpbmcgNjQtIG9yIDMyLWJpdCBwcm90b2NvbC4NCg0KTWF5YmUgd2Ug
c2hvdWxkIHJlYWxseSBuYW1lIGl0ICJ0cmFuc3BvcnQiIGluc3RlYWQ/DQoNCj4gLSBBZGQg
bmV3IGRldmljZSBraW5kIChMSUJYTF9fREVWSUNFX0tJTkRfVklSVElPX0RJU0spIGFzIGN1
cnJlbnQNCj4gICAgb25lIChMSUJYTF9fREVWSUNFX0tJTkRfVkJEKSBkb2Vzbid0IGZpdCBp
bnRvIFZpcnRpbyBkaXNrIG1vZGVsDQo+IA0KPiBBbiBleGFtcGxlIG9mIGRvbWFpbiBjb25m
aWd1cmF0aW9uIGZvciBWaXJ0aW8gZGlzazoNCj4gZGlzayA9IFsgJ3BoeTovZGV2L21tY2Js
azBwMywgeHZkYTEsIGJhY2tlbmR0eXBlPW90aGVyLCBwcm90b2NvbD12aXJ0aW8tbW1pbydd
DQoNCldpdGggUm9nZXIncyBmZWVkYmFjayB0aGlzIHdvdWxkIHRoZW4gYmUgInRyYW5zcG9y
dD12aXJ0aW8iLCB0aGUgIm1taW8iDQpwYXJ0IHNob3VsZCB0aGVuIGJlIHNvbWV0aGluZyBs
aWtlICJhZGFwdGVyPW1taW8iIChpbiBjb250cmFzdCB0bw0KImFkYXB0ZXI9cGNpIiksIGFu
ZCAiYWRhcHRlciIgb25seSBuZWVkZWQgaW4gY2FzZSBvZiBhIGRldmljZSB0cmVlIGFuZA0K
UENJIGJlaW5nIGF2YWlsYWJsZS4NCg0KPiANCj4gTm90aGluZyBoYXMgY2hhbmdlZCBmb3Ig
ZGVmYXVsdCBYZW4gZGlzayBjb25maWd1cmF0aW9uLg0KPiANCj4gUGxlYXNlIG5vdGUsIHRo
aXMgcGF0Y2ggaXMgbm90IGVub3VnaCBmb3IgdmlydGlvLWRpc2sgdG8gd29yaw0KPiBvbiBY
ZW4gKEFybSksIGFzIGZvciBldmVyeSBWaXJ0aW8gZGV2aWNlIChpbmNsdWRpbmcgZGlzaykg
d2UgbmVlZA0KPiB0byBhbGxvY2F0ZSBWaXJ0aW8gTU1JTyBwYXJhbXMgKElSUSBhbmQgbWVt
b3J5IHJlZ2lvbikgYW5kIHBhc3MNCj4gdGhlbSB0byB0aGUgYmFja2VuZCwgYWxzbyB1cGRh
dGUgR3Vlc3QgZGV2aWNlLXRyZWUuIFRoZSBzdWJzZXF1ZW50DQo+IHBhdGNoIHdpbGwgYWRk
IHRoZXNlIG1pc3NpbmcgYml0cy4gRm9yIHRoZSBjdXJyZW50IHBhdGNoLA0KPiB0aGUgZGVm
YXVsdCAiaXJxIiBhbmQgImJhc2UiIGFyZSBqdXN0IHdyaXR0ZW4gdG8gdGhlIFhlbnN0b3Jl
Lg0KPiBUaGlzIGlzIG5vdCBhbiBpZGVhbCBzcGxpdHRpbmcsIGJ1dCB0aGlzIHdheSB3ZSBh
dm9pZCBicmVha2luZw0KPiB0aGUgYmlzZWN0YWJpbGl0eS4NCj4gDQo+IFNpZ25lZC1vZmYt
Ynk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNv
bT4NCg0KSSdtIGZpbmUgd2l0aCB0aGUgb3ZlcmFsbCBhcHByb2FjaCBhbmQgY291bGRuJ3Qg
c3BvdCBhbnkgcmVhbCBpc3N1ZXMNCmluIHRoZSBjb2RlLg0KDQoNCkp1ZXJnZW4NCg0KWzFd
OiBodHRwczovL2dpdGh1Yi5jb20vb2FzaXMtdGNzL3ZpcnRpby1zcGVjL2Jsb2IvbWFzdGVy
L3ZpcnRpby1pb21tdS50ZXgNClsyXTogaHR0cHM6Ly9tZWRpdW0uY29tL0BtaWNoYWVsMjAx
MnpoYW9fNjcwODUvdmlydGlvLWlvbW11LTc4OTM2OTA0OTQ0Mw0K
--------------gQZC9zbwTZhcj0YQy1fTYREg
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------gQZC9zbwTZhcj0YQy1fTYREg--

--------------rXqCqEUO8Lt6tagxLtf6Vqn8--

--------------0y3uPQdTz0ZSHZtGEQPoNPYz
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJmURYFAwAAAAAACgkQsN6d1ii/Ey+5
1gf/fMbnID1TWVRdnvJZdLCnVYqsNDXbaSn/S3gtuEgSLe2gnCsS+MIIKhJzTNAQgPEN2efne+oX
vPKsQIFRxs1JaDvC91IEE9B1Mj3fNE9SqP036GxazeRKwkOaTqSsSFR3/XzkTgQjRvMPq3frEp7A
TU8pOzlga+PrRJ3NmsxyFbfNeU2bK1JDhAzgkJDspUPWK+23/7r0t7MvQWy4nCgEgf2iliEwMath
MAh23eGQyT2tX5EHxv3TeWu4Dze1Q4EnAGmJ9MHjmtivH0APxJvXcG0P7sxVRjrOfS3xrnCMrWaL
zVnTFM33btGKcmWJ8brln5cWs96Vc9wY8mOkx8aFyw==
=csVy
-----END PGP SIGNATURE-----

--------------0y3uPQdTz0ZSHZtGEQPoNPYz--


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 07:47:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 07:47:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312400.529617 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitRo-0001QH-Ub; Mon, 25 Apr 2022 07:47:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312400.529617; Mon, 25 Apr 2022 07:47:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitRo-0001QA-QR; Mon, 25 Apr 2022 07:47:52 +0000
Received: by outflank-mailman (input) for mailman id 312400;
 Mon, 25 Apr 2022 07:47:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Y4oX=VD=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nitRo-0001Q4-6z
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 07:47:52 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 020752e7-c46c-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 09:47:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D1053210E3;
 Mon, 25 Apr 2022 07:47:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E2A213AED;
 Mon, 25 Apr 2022 07:47:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id anV8ESZSZmLGaQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 25 Apr 2022 07:47:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 020752e7-c46c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650872870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XOZ4B64PQp3QRZDkrypCGMf/bZ0hCmFjlGKE4h24+mM=;
	b=PK0exDEEY6G0RKSVAYgvQ3K/zqysbdYeTj5P2OWOYQeGD4yDVU0gcaTHnBLurBsf5QgfoT
	fAH14WNJ9QRhLfjDUm8YmHYbC1hcVVvzXyUCWIBIkc3plaYi3dYcjyxRuQBNzQFZpqmJ1T
	TXZUceooP1N5NHCaZflRC187gXd97IY=
Message-ID: <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
Date: Mon, 25 Apr 2022 09:47:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------RTRugpKcpQELUP0Gus1cI1VK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------RTRugpKcpQELUP0Gus1cI1VK
Content-Type: multipart/mixed; boundary="------------XSdyHfDZ8NSbH9riXD1TXs2C";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
In-Reply-To: <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>

--------------XSdyHfDZ8NSbH9riXD1TXs2C
Content-Type: multipart/mixed; boundary="------------AUotc6vkbgM0g5J5WIJwHZMe"

--------------AUotc6vkbgM0g5J5WIJwHZMe
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMDQuMjIgMTg6NTMsIE9sZWtzYW5kciB3cm90ZToNCj4gDQo+IE9uIDIzLjA0LjIy
IDE5OjQwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90ZToNCj4gDQo+IA0KPiBIZWxsbyBDaHJp
c3RvcGgNCj4gDQo+PiBQbGVhc2Ugc3BsaXQgdGhpcyBpbnRvIG9uZSBwYXRjaCB0aGF0IGNy
ZWF0ZXMgZ3JhbnQtZG1hLW9wcywgYW5kIGFub3RoZXINCj4+IHRoYXQgc2V0cyB1cCB0aGUg
dmlydGlvIHJlc3RyaWN0ZWQgYWNjZXNzIGhlbHBlcnMuDQo+IA0KPiANCj4gU291bmRzIHJl
YXNvbmFibGUsIHdpbGwgZG86DQo+IA0KPiAxLiBncmFudC1kbWEtb3BzLmMgd2l0aCBjb25m
aWcgWEVOX0dSQU5UX0RNQV9PUFMNCj4gDQo+IDIuIGFyY2hfaGFzX3Jlc3RyaWN0ZWRfdmly
dGlvX21lbW9yeV9hY2Nlc3MoKSB3aXRoIGNvbmZpZyBYRU5fVklSVElPDQo+IA0KPiANCj4+
DQo+Pj4gKw0KPj4+ICsjaWZkZWYgQ09ORklHX0FSQ0hfSEFTX1JFU1RSSUNURURfVklSVElP
X01FTU9SWV9BQ0NFU1MNCj4+PiAraW50IGFyY2hfaGFzX3Jlc3RyaWN0ZWRfdmlydGlvX21l
bW9yeV9hY2Nlc3Modm9pZCkNCj4+PiArew0KPj4+ICvCoMKgwqAgcmV0dXJuICh4ZW5faGFz
X3Jlc3RyaWN0ZWRfdmlydGlvX21lbW9yeV9hY2Nlc3MoKSB8fA0KPj4+ICvCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIGNjX3BsYXRmb3JtX2hhcyhDQ19BVFRSX0dVRVNUX01FTV9FTkNSWVBU
KSk7DQo+Pj4gK30NCj4+IFNvIGluc3RlYWQgb2YgaGFyZGNvZGluZyBYZW4gaGVyZSwgdGhp
cyBzZWVtcyBsaWtlIGEgY2FuZGlkYXRlIGZvcg0KPj4gYW5vdGhlciBjY19wbGF0Zm9ybV9o
YXMgZmxhZy4NCj4gDQo+IA0KPiBJIGhhdmUgYSBsaW1pdGVkIGtub3dsZWRnZSBvZiB4ODYg
YW5kIFhlbiBvbiB4ODYuDQo+IA0KPiBXb3VsZCB0aGUgWGVuIHNwZWNpZmljIGJpdHMgZml0
IGludG8gQ29uZmlkZW50aWFsIENvbXB1dGluZyBQbGF0Zm9ybSBjaGVja3M/IEkgDQo+IHdp
bGwgbGV0IEp1ZXJnZW4vQm9yaXMgY29tbWVudCBvbiB0aGlzLg0KDQpJIGRvbid0IHRoaW5r
IGNjX3BsYXRmb3JtX2hhcyB3b3VsZCBiZSBjb3JyZWN0IGhlcmUuIFhlbiBjZXJ0YWlubHkN
CnByb3ZpZGVzIG1vcmUgaXNvbGF0aW9uIGJldHdlZW4gZ3Vlc3RzIGFuZCBkb20wLCBidXQg
IkNvbmZpZGVudGlhbA0KQ29tcHV0aW5nIiBpcyBiYXNpY2FsbHkgb3J0aG9nb25hbCB0byB0
aGF0IGZlYXR1cmUuDQoNCg0KSnVlcmdlbg0K
--------------AUotc6vkbgM0g5J5WIJwHZMe
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------AUotc6vkbgM0g5J5WIJwHZMe--

--------------XSdyHfDZ8NSbH9riXD1TXs2C--

--------------RTRugpKcpQELUP0Gus1cI1VK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJmUiUFAwAAAAAACgkQsN6d1ii/Ey83
vQgAllvB7gAmPzj4MJJf1J3ydVrvO/9eWJrgz/vrZAJPBT28frjIAcyOkmnvU61akrHDYp0TdaFR
xsXXrTja9p8p1wkcizFfvwEO43WaFmTnxVO5LQyw0xZyPQVwsRmZ6cdcnStlwDUc6HqFghpiDSVQ
NFosdwG/eB81MFHq2sSyhuc+ZpAd1+/GKk9Gri46PgO7m1NCBqiN6eBNoWkik6DUkR32fPutFw3e
4m6UqtOYu6htLUYWx+gF3Iq9KSafJLSypAJ09YS8dOvNzCrXmwFSRp6Ri43VJ2LJQc1Eo0++cFlC
9Ho5QTt1fs81HBVVA6FWCCeLJ4LIeMQG5Q9sKPUb2w==
=8gGu
-----END PGP SIGNATURE-----

--------------RTRugpKcpQELUP0Gus1cI1VK--


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 07:49:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 07:49:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312405.529628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitTF-0001zs-8v; Mon, 25 Apr 2022 07:49:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312405.529628; Mon, 25 Apr 2022 07:49:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitTF-0001zl-4n; Mon, 25 Apr 2022 07:49:21 +0000
Received: by outflank-mailman (input) for mailman id 312405;
 Mon, 25 Apr 2022 07:49:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nitTD-0001zd-Uw
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 07:49:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3619e6c7-c46c-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 09:49:18 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-qIlIct9hMmqeIvgBJT7Obg-1; Mon, 25 Apr 2022 09:49:17 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB3976.eurprd04.prod.outlook.com (2603:10a6:209:3f::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 07:49:14 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 07:49:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3619e6c7-c46c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650872958;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+0eZOK6t0NMZu8QXih3b2xtzSHrOqoaouXI0M5kS5dg=;
	b=afV/qTsuKsDg0+InsebZ5EEvKNfG4kTa6/kszWBLwafee7aBCar/XF+U3KHiCfmi5sWwzr
	T7osEDhdQbTTWkfbwTxtuwassiMscxQB0m1DiKczZPEqEPvwxq8ht6hRUjXO7e7X6pGnjK
	XAVGt4GROhIVhVcx8lS9yUDIAVkJLwE=
X-MC-Unique: qIlIct9hMmqeIvgBJT7Obg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ljca6kbRjgeljQtJvqMq3szsEGuUbD3QBqkekhqGmAIVXXkzX2szg3srjQCl2m+owXNryTRJ4Aqgz9eGd+fy5CZJxfHeuhHU1l4zzajRpEwVktdy5r4Nhy2HHYE3mFeqUzaGNaPE9AoH2wMG0mWMC+5N5unu1+LGPl8qryOwbaB6DgPWv4FkLM0q83mmLGT7kRX27PowP0J8VQXQF50LCB+gpKH4ohe2ld+3c/xULl44kyQVdiGfStEgLclA2gp5YKw30Wi8hIvR2v+AwnhBqb3Kob+7M++FrRVihGYMJeWFnse8aeCHajrDxPxGogup1vanB7+zzW7EpK7Gh9TGyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+0eZOK6t0NMZu8QXih3b2xtzSHrOqoaouXI0M5kS5dg=;
 b=RlS+WfEyZpHWeAeviTgSApVLHrDlVBlJwjXrACDrzDDUpUkZK5SK2uKTNgzA+NcxucA/LlQUE07GlBDoADXHvSbHxMwRSvHfUGMPFTh50h3qwKbDj6yGSB+GyTjBEi2gSiSBswu/iX0lWA3TClJrV03+sFmPD5OiLEL22LNAqKkPXfVFem3ebHLNoF+gIx2kn6T+Xscs83Q2Bl1ERAS51CIFpeNv2r67Ppj6dN4mQSxQRJmw/OzPsJgQQ+9VfEX7fuLpliUKvMh1eMW65lAwUWofJ2xl4Oem1Qjig7R7zzR3AnLoGg1r0F4PCh64Gc15+bMdSLD9LwKX3h6msK3vEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <310ab91a-60bd-f4fa-aeee-28aab43aabbe@suse.com>
Date: Mon, 25 Apr 2022 09:49:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
Content-Language: en-US
To: Tamas K Lengyel <tamas@tklengyel.com>,
 Tamas K Lengyel <tamas.lengyel@intel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <CABfawhki8YVxycv_zdDqDuOYvBdobdskXnjjdjiF7UND3784cg@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CABfawhki8YVxycv_zdDqDuOYvBdobdskXnjjdjiF7UND3784cg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0297.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::35) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5beba772-f4eb-40ec-7877-08da269017bb
X-MS-TrafficTypeDiagnostic: AM6PR04MB3976:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB39761DC5BFC49F0F89E97E05B3F89@AM6PR04MB3976.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Gw1X7cIozQUlq3mRKbk9T7Bw898AHw3XPwOgTyeaXvm+Edt6tRa/IkcqPu2Z+ngsXmjFpzlhjQqmU4vSO8QZr38Bz8Ztqd9njjep1w9NgxkbncgGAHXvQqYAbyoFQMvGwgxrg+ziVEUdkdTCE/wb2ImAE8qxx35qjkgYPbX8zBikVwosclZQtEa5atJqib/M6WY3rZkxpyydbsSL/6V6pcCjznNwqtt05LLcOiwgY92jI4pfcEKKKnVa8DkHDn213rceFKoAqDSesBeQbDyQi27ApSt1V16ky2h0WxwJN1yIqojW1BIWvrG322DDIxL519F0XJrtmGujc2E3os9AgnEOZKmegrYgfPKfHL92mY3v6NJ3Ztg+zkV2jvv1CNzbsXJmzJY0I60M3IroYID9WC/47mvwFgSnQvg5Xe0As/cMO8/sueAhldJ0h1C+PpVT9+7h3E3oer29+uESE6tFlRHqx2k1vSxzdjHxeRTE5bkcICXb3zwcwPsq3gFw1A+NebVDIa0QUinlxkFcy495ti1CHiEsnAOKvVu5bL43k0gE8BNgaXxF0LrA0WhAA5Oll/SMQwT6xkLVrRZ0sdnhDVtbjEgrK/cx54UQzUUqsxsXpHvthsiiLCDi3ewa9HFf27R+/6wKz7yTTvExZwX+uy9uvpR8T8ML3KX79Dj869kCqY/V+0aAAz2gM5YDoGJW1pxAbq3zVYc0SdSmZJJTRBxvNer6rFtNtF4UrpCC/Zk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(508600001)(8936002)(5660300002)(26005)(86362001)(31696002)(6512007)(186003)(2616005)(83380400001)(7416002)(38100700002)(53546011)(2906002)(6506007)(66476007)(66946007)(54906003)(316002)(66556008)(110136005)(31686004)(36756003)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eE5zUEVqenRZZFpvOGtNSHhVekVmUTJCSFczWUFlUTBwbUdsVzVOTldCNVZ6?=
 =?utf-8?B?cVB4dEFLSEFiRHlGeDF6YjMrVkNWckJKeWhKMTRSL1RhcXJNdm0zaHRHMXpN?=
 =?utf-8?B?clFLYVFHQ3JlcGQxWXJ5VmpKbjhNQnZSdnZXd1lSNXpmRFQrN1N2bU56Vm9T?=
 =?utf-8?B?QVBXRWhsOG0zbnZ6SEtqU2x4OGtCd0JjdHFMbnR3OCt5WkhydDMxMmNDdzVq?=
 =?utf-8?B?YUtPYjZiY0hTRUJrN0Q5ZG8rZnpNZTdPVE1kWlZKamJHTFA3VGZxVEJUMUZF?=
 =?utf-8?B?eXp5QllHYUkyQkUvZHY5TDQxSEk2RG43Z3FBNG5tS1pRUWtIMDdNdTZyenI5?=
 =?utf-8?B?WGRhUi8vYlpZUkJQNXAwSXBPZjBTSTdpM3lWSmdVUXBZZmlEbnorYjFyeENw?=
 =?utf-8?B?OFE5R0JKUXdYV0J4ckZCdFdGSzdrRnZEY1k1amNNOHR5alRYNE9MQzNnMDlL?=
 =?utf-8?B?V0RRUjN5K0pVdUVzQzA0aTE1dHpTa0lJOURXY1p3U2hzQ1hVcFpVeE56UHZr?=
 =?utf-8?B?YlJSaXo2QW5HVlE2NCtBcWIvbnZUcytmdEZyV0xnWVh2TUlRUWM0eU1iM1Jh?=
 =?utf-8?B?WXd1SlNTNUU4UURGVXRNaEUvRzhuSXN5WjRtdzd0YWFyMCtOU29nZDZkVjBT?=
 =?utf-8?B?WHlMSHpYUWs1emVodjR3Y296Z1BwRkwrOFgrbHpjOGRDaUM4YzZPVTQxdHNi?=
 =?utf-8?B?Y0hicUZkTTBhVEZtQWk3b2tvUW5LV2JvN1JzUHpTYmJHMzZLUEVDaE40UkZS?=
 =?utf-8?B?WnNPMzJFd2htdzBMcnFxUUtjSjd0bS9SeDUwV2Y0NTVIMk80K1hyYjJ1a0Mw?=
 =?utf-8?B?NmFqV0dXaExQWlRFWkhPWGhOTkUwUElnUWJ4Wm5yOThFdXp2amRaQlllWlpG?=
 =?utf-8?B?ckNQbTdUN2J5aTJpa2d2SG43Yk1BYjV6M2pMem96TE5PRUZoTlZUclREdy9j?=
 =?utf-8?B?eDBlcnBkSkMwTEsySW5jemRENHVWYnczdTdqbGhkdjAvMUlRRG1HblNxRHVa?=
 =?utf-8?B?NDd4VHlwRy9PN3RzSjZ2ZUlaaW9qaEJRalUwbmNkckMyZVdYWG5PanhxWXFz?=
 =?utf-8?B?U2s4L2NqS3ppTmpmR1BQSHdaZWxUSHdKeVd0cjJVTjRFQlNlSitKMHFpZVYx?=
 =?utf-8?B?Rm41QStiY0VudHdIS212dklDUlRtNGxjenhqek9aamJYb3puRHRRamMxMzRQ?=
 =?utf-8?B?amxCUDF2bFA1azd5aG5SMFNzSkVCM05xSVozSmNKOXFuRVp1b1JPcjlWTkpX?=
 =?utf-8?B?Y05jZzVrazFVa2IraGJwRFhacEJyZFhLdE9BcHN3V2ZSMnNMNUpkRTJDNEFy?=
 =?utf-8?B?YjNheXp1WkhFOGZiakVMVVBGQ3lsUnZKcUlQbG5qbS9sL0hKMVV0bWdlYjM5?=
 =?utf-8?B?aU9sRmhRNTZRRkxhdTd0OVBLUG1xSHcrL3F3RThjTm9BNCtjNUZHK1pzZ3hK?=
 =?utf-8?B?MytvS2J5Z0lBU2IyTmRVYzIwMTdwTGFhSXU1eGl1QmdaOGN5cDNObjdudlRy?=
 =?utf-8?B?TlBoR3F2c3FQdUkvY2VMRHlOZGxic1ljN09iREdLb1dBRXFCcjh3Y1RXbzB4?=
 =?utf-8?B?ZDBRQ0FRVGh2SHgzQXdYd1NiOEl1QkpZSElnTWYyalNvZG14bkFvblUrUWcy?=
 =?utf-8?B?ZGpiM3VMRklSeUFEOGJrZ0xlUlExM0orWEQwZzltYms0aEh1K3pYTnRtbExh?=
 =?utf-8?B?Q1pEZ1M4WHpOT1djRjJuVEZzZnIzdXFCeWl4MFRhOUltSWFzOGsvU3ZFUE9p?=
 =?utf-8?B?VHdPOS82V2swSkVsMTNLMUFvN1haSmpkdG9naGVpbWtSK2xxSjRRZkU0MkFJ?=
 =?utf-8?B?WCs3TU1MSjhaQUtCUG56TmhvVlFoY0NQUEZVNmdXd1JWRk1EMWU4VjRieWQz?=
 =?utf-8?B?Um5sc1NIY2dYWEdyaWxHY0RvN2FsY3BTYWo4a1BBcXlHZVMyZmNFYnV6eWZj?=
 =?utf-8?B?bktVWldLMTJVMjlobThmZWlYRzlicUVka1d6cEZ4bUpSTm5ITmxDOEFzOVB0?=
 =?utf-8?B?ZGFjMzNOZEFDRTNhKzhaSWNRMForQ3VnM0tRbklYRmFFdkQ5bjhCTGpzVXlN?=
 =?utf-8?B?ejdENFJ3bW0rVFdBUnFyLzFLQzNLbjk5RkVGSVYvMUxFUWREQzJpeGJ0NDdY?=
 =?utf-8?B?bGNNY1ZCa240Tk1pUjdTQkhlcUluL2F6SkZac1JhelNwRFdUcm8vb3hlZUwx?=
 =?utf-8?B?Q081Q0Y3YzNsRzZVeC9ReTc1MEFSYmxkckc0cW91YjA5K2ZVQnhWR3NRY2d0?=
 =?utf-8?B?RG15V2dQYmJGZWhLakpBb1V5R1VMUEJoaStKOUhuUkxqUTJOWmZjem5XRTVk?=
 =?utf-8?B?amFEZFpBWmgxSUlnK0RqVnlQOGtOMS9qL2NieXdncm1nZ3FpVXVvdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5beba772-f4eb-40ec-7877-08da269017bb
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 07:49:14.3060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9m+uwFPDTMLsPSRqf/hreEYEUKqjNKPt+yw3fU2RJoDOADwfe2sdlu1+3wYJNXEwU0jLoovHFMRuI26ephn3Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB3976

On 22.04.2022 16:07, Tamas K Lengyel wrote:
> On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel <tamas.lengyel@intel.com> wrote:
>>
>> Allow specify distinct parts of the fork VM to be reset. This is useful when a
>> fuzzing operation involves mapping in only a handful of pages that are known
>> ahead of time. Throwing these pages away just to be re-copied immediately is
>> expensive, thus allowing to specify partial resets can speed things up.
>>
>> Also allow resetting to be initiated from vm_event responses as an
>> optimization.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> 
> Patch ping. Could I get a Reviewed-by if there are no objections?

Hmm, this is a little difficult. I'd be willing to give an ack, but that's
meaningless for most of the code here. Besides a stylistic issue I did
point out which I'm not happy with, I'm afraid I'm not good enough at
mem-sharing and forking. Therefore I wouldn't want to offer an R-b.
Considering the VM event interaction, maybe the BitDefender guys could
take a stab?

Of course you'd then still need a tool stack side ack.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 07:51:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 07:51:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312410.529638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitUo-0003Mg-JO; Mon, 25 Apr 2022 07:50:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312410.529638; Mon, 25 Apr 2022 07:50:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitUo-0003MZ-GV; Mon, 25 Apr 2022 07:50:58 +0000
Received: by outflank-mailman (input) for mailman id 312410;
 Mon, 25 Apr 2022 07:50:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nitUm-0003MI-PA
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 07:50:56 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6e13e3c4-c46c-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 09:50:54 +0200 (CEST)
Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 03:50:51 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BL0PR03MB4289.namprd03.prod.outlook.com (2603:10b6:208:6c::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Mon, 25 Apr
 2022 07:50:50 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 07:50:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e13e3c4-c46c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650873054;
  h=date:from:to:subject:message-id:mime-version;
  bh=iULifExNRLw2P/oVIh+trd/fPLbWVeUmhCbaLqog3+w=;
  b=DV2XgjKSdgRroq+Eg4dEe5zmtoWhJ9aig1Krh0+BgDZRYbV66y1yfLCc
   hqm2eAj+7I/Z7z8oyU4xcQAOOn1wtUuWFnToas499H2LbPYKr33p0sk+F
   fZvneMKxpxyAeRi58ml2KQev2nqb0TuXIjGfGmPgxhm6lxqe/FM9JvIIe
   w=;
X-IronPort-RemoteIP: 104.47.57.175
X-IronPort-MID: 69712376
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:sgYGvKzgA9DtadrGSx96t+dgxyrEfRIJ4+MujC+fZmUNrF6WrkVVm
 jdNXWuCMqqPajT0LYslbo20o09S7JSEzYM3SQVqqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024ThWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplqaOCFQFxGb31x9syYT0ITQhTP6wZ0eqSSZS/mZT7I0zuVVLJmqwrIGRoeIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHOOTuoIwMDQY36iiGd7EY
 MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GhImIB8gnK+8Lb5UDp7SpD6InkYeaLZ8aMa+t6r3fG+
 CHJqjGR7hYycYb3JSC+2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGEZlWWXtteL
 wkY/3QopK1rrUizFICiAlu/vWKOuQMaV5xICeom5QqRy63SpQGEGmwDST0HY9sj3CMreQEXO
 payt4uBLVRSXHe9EBpxKp/8QeuOBBUo
IronPort-HdrOrdr: A9a23:pkEzYK30QkrkGdTX1q5JrgqjBEgkLtp133Aq2lEZdPU0SKGlfg
 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5
 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq
 a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
X-IronPort-AV: E=Sophos;i="5.90,287,1643691600"; 
   d="scan'208";a="69712376"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Mxpb9stK+fiOtinFMGPti+tQRUU+hZKHl8/ohO7pymPymYeRv8sWrLb031rVd/nYtnYyVNk0ppg4ANh9pvEaSDgC+19lQUe1/NLlaCOqWzfrcRCdl5oiowPKnmHsM2i3Bdez8rBQ2/YX1I6TnjdOGoJOFrh9i+SE/UNgUEl+FaRgyiwgZLFM8O2ajpwlyYzYxI+/Utj6WNkOG/WGNyISyh53VAUyJ0+qyYwSXMo6WhLhpgJTCXqnt9roaN8L6DyTBkOWClqVvajc6pCfyDF2crf3LRoNuXZ6Cp+KJwGgX7h1aG3NE1EZ32SDgI1EmQO+0HwVlmTxlreaJGEkyH28Ow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iULifExNRLw2P/oVIh+trd/fPLbWVeUmhCbaLqog3+w=;
 b=Yb/bzHgBplUzVcFKytzsCFAC8mmADqW6PQUkYP2Rd3k6fRfe/J2mdVaPo+JVihhWymym4toKgSMR91nbNJIXEU5ycTK6P6tgWgVSQQ70yWpJbELj9yh/WyI0DiMQ5uT+FbcBXvIuV0VZLcIQ4P+S8nusLPJqPWvC0iuFDmMi2PTh/3+W3kO1eNC6wBAlC5DaJgugUre6VCvpzXNw64s1BgFbn2jEJTKez1YhQ3keNmstvA+kqemrxPCauIB+bXMxE17vA6STzuJ3IxaoCnksnKLBx6cKsvk6pDG0/fR8EOjZwqPuzmcD1HYTMUBOs7XVrMBfs/2SZuKX4QZswWvjTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iULifExNRLw2P/oVIh+trd/fPLbWVeUmhCbaLqog3+w=;
 b=U6RzX1ey407I6fc1YIhF7K2uzCqI6/tfdC0bGoQBYMpbuKREhrjLQvv/ogG+5XIKiO9Wvq9ql371NcLXfR9g+u+P666kS0F+nnpyR48HKiq3uaOTG+c7oK0je5kBR3DcFUFBepPHDY4NBFWgOHRZT+2qRN28uOUjnNB+tUx1Ovc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 09:50:44 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Subject: osstest: noceras back into production
Message-ID: <YmZS1EduV4tOsxrT@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
X-ClientProxiedBy: MR1P264CA0017.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2e::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 205c0465-e259-4de3-cc9d-08da269050c8
X-MS-TrafficTypeDiagnostic: BL0PR03MB4289:EE_
X-Microsoft-Antispam-PRVS:
	<BL0PR03MB428989028F4AB9F9DD57BC788FF89@BL0PR03MB4289.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hH8RfrLWCSeiAXUMLd2wuKZ087KWVcmVeIpoKygbJNI745UxA0XiZeaQpSIaMfkl5PalHyUvmeAc2FYTlk7ckpzYB4iRUUatxGQ1+bDf0HuVIaH+rVl+7EJJ7wly0j3UaP1pv4ccG3unsCwEnXgA1jr2QYdpJUFxZpXWDKWtz/H+VvQbeNJhRBxwLVk4j2syQl2LIDTYJHKgCkjKPKryQ2R2eJ8drs/5FNFgEZX6TLPBZAb02jy4M4zem7fp+dY4KnoDdIH5Em1x5bYidAJ3ElQeMDonjEb610r7hfezVKZJIIzggdz4tGH9QC3/PtVb7pDOO8pPPfUL8PZfmDpfuiPtiR8CHVe7yENyyo18tE0APO1O3ZWov0ToM3rrmqj0sJ21ildRds+CS9WXCOjg3gVFgbtzddCL2gQz45YyVZznRnxuxYR3RlnzMICXklS7/z1l/ADdjbSDUMK9jL00EeubANW0uYqRFUK60cCdzDLU4N7zFwEPzSddBQrBzVoWT6lKepDi4ZNZQHDd5QqZR6FgNldsxi1J6eZpU0zc7lVaKVRmz0STdzlzYTSFCKE9f7jIfIFn8/RXggfdEln/M9tsjuJ/buOD1RkzzkeKqy4nbjqlAGwH+AVIR6Ktpp60jxg9OgSIhrX/pMfd78Drc0cECUR34ShDu2uzdyuG+Yb3INOeKvritORGz0ZiemEougHQwdtOOPxejXduvJyaVum2QhJ6Fe5MnetdvdR+Mu2fY5avv+YodoQec7esRzMzCB4xy16gW/T6H7kNa3b69jXcxMsA0gXczYXERTCUVz0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6512007)(9686003)(26005)(186003)(6916009)(6506007)(85182001)(33716001)(558084003)(508600001)(6486002)(966005)(38100700002)(86362001)(5660300002)(2906002)(316002)(6666004)(82960400001)(8676002)(8936002)(66946007)(66476007)(66556008)(15302535012);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RUtxV0x2UWNrdTBaaG5IUEltVEJNVWxQYkJ4bU5VM2hlWXhwWHJvZnRneU4w?=
 =?utf-8?B?V2IxWmNOallPZjZYdHBJVi9uQUdFYnY5bVBMWGt0OTRZYjlIejk5V21OWCsr?=
 =?utf-8?B?a1YvdHNYMlZkTVpQT0pQYXNjejJIMVdaSTFpMzhObDRoZlpxK2N6d1pzak1v?=
 =?utf-8?B?Yk5rajN6QlRzcGszQ2s3dlhqYkRlVEhLd0FCaHlEN2lrVjR4OUU4dHFRYng2?=
 =?utf-8?B?bDYrU2IvcXA3SDNKTFRxWHZOOHdDOXlveUMyaTMwYm5VTjVuRGx5UFFVTmxJ?=
 =?utf-8?B?OGk3UkZEaXloQlg0d0dUVWRmTjdvaHY1aUo5dHpTOE5XSkRXTnZ5VGhKdDZq?=
 =?utf-8?B?ZExRS2JIdXRFU2pmWTN0YTBmMS93Tm0rdmxrdks2TkRsbDNSOVJacjVrdW9m?=
 =?utf-8?B?alZTcmtEdkcvZjZGc0ZxdEh0dE5kK1N6dVB2NWRiZ05adWtYUzZHcGdrUTNU?=
 =?utf-8?B?UTZ6V3NUdFhBZEJlM2wzS1hkR1BWU1JsY3QzUTBpVE9sZU12Mlg4NDVXK2hF?=
 =?utf-8?B?VE1nU05heDBWbHpuOEdES1JmbWl4OUhiK2NwMHRMdDFLemNabmsrKy9VMFFN?=
 =?utf-8?B?UUhMU2dTUGJBaDBRZFVkV2pPOW5kTjh5R29vS3A3aTQxQm42ZXdUVUEyTjBD?=
 =?utf-8?B?RFlpWTBEQWZ0VndPYVZVMUlsWk1Sdys4NkwzKzlPWHF2eUJDTkp3em9mZ2lp?=
 =?utf-8?B?b1JzaVhNWWdCY0Q5d3NMbyt4R2QwcFJHenJmVVp4TUZra1RxcG5vSFNWTytK?=
 =?utf-8?B?bVV4NjgxZ3JnM0RRT0UwQVRqM1dzSUQzWU9DOGV3dU1MVW5BY2c1Tk9ZMHJi?=
 =?utf-8?B?cWdpeHM4NnBkRU00ZXBqdmhpbEhvMjBOY1o2TmdnMzUxRkpvOVIvSHdMMGxI?=
 =?utf-8?B?Y0NCWTBnQjdZOStVd2RNMGpOUG5EK240R052SFF3MlFpV0lqTEFESFNIbktz?=
 =?utf-8?B?dW5tTG45aDlTL0JlYXFJekNLZTZCb2ZBSHBGd0Y4WWlVdU5BNjBZZzdUc2xC?=
 =?utf-8?B?SzlTYVpYQ211bVpua3l0RFByZyt5M0N6aVNScGxrUVhZNWdsRTUwaGNvOFAw?=
 =?utf-8?B?Zlc2ZjM2OWhrdkd3MDZWK1E5c2lEUXphbitWOXFMc0ZMM3hLWEVoLzNGZ0ZY?=
 =?utf-8?B?N09MZHFqS0drMFJJbWN2d21QQkxsMVpyUnU1OWVqaXlBYzBoSVRrMlRGNk9y?=
 =?utf-8?B?V0M5VUwzQi9NcDRBNVh4blIyd3JWOW55K2wyZ3IyS1hKUnVlTVA4cUQxNXF0?=
 =?utf-8?B?T05YS21OdUhNd0YwTHUvL2hvaW53UEtiVGowVmF6d0xOUXFXSitrZ2cvVU8y?=
 =?utf-8?B?VDhWU0ZjZ2RnTnV4RVowTG1YY2lhZ2FzR2ZsSWJTcm84NS9LZEdoL1dmMk43?=
 =?utf-8?B?RU5uRzB6VDBjclV2RFdGVHE4cFNvK0xIK1Z0NEU4OVdMbUJaMVZObU9xcS93?=
 =?utf-8?B?SVFKVXc1TDRvQ3N5RmxZMUR6YVdjSEJZQlAzVFJJbG5BS0xqWGdZeHNmVEI5?=
 =?utf-8?B?RVBhSTc2SU5WS1hpMWZNc0tBZC9YZWlVcUZwN2lrUDFtRDRLZmdSbTlyaTlx?=
 =?utf-8?B?cTJaMC9YR0xWa3hITnBWNUNhaHcwWTJYR2dsZWRsb25tUTJUSnZIdDdNWis1?=
 =?utf-8?B?amx2VXJGd3VPTjFBMjhwVmZ0QUJobEVIbkhkSkwrL004blIrTmJmeE9URWlw?=
 =?utf-8?B?VkR4Q2QvV21NVEE1ME5UZGdQYlc5Q3lPRklYTnJjMytjbjhxNFFoYnlML2tD?=
 =?utf-8?B?S2NCRmxZYTJBNUZMN1VpU1dtd1RBd3RIb1o4YUZWTEd0MnR3WUxVbjgxUHB5?=
 =?utf-8?B?ZDRKd2NYUnY5SzE5N2NPb1U0Q1JvM3FqMGthdms0VzMxbTJtYXkyeHhUNC95?=
 =?utf-8?B?Q0JGR0RtbVFqTXh3OExzTWREN1FzaVIwV2tlaDhEMmR5cG9jalByWk9SdzhO?=
 =?utf-8?B?SStUTVhLL09lTDZyU2lXWVVNZE9td1dpSy8wenJxZ2JxR2ptU0tFS0luK3l5?=
 =?utf-8?B?YUJxa3J1UDBOSHErUlZZUzZIbytNOW1mSUVuRmVnUjdrNVQxK0xmcU82SEp3?=
 =?utf-8?B?MW1tbjgzMWxscFduT1U4MGVEbThrZFVFZ1Bza21FSFpjckJpMFF2dFNPU21q?=
 =?utf-8?B?UWIvSEN1NDZ2SmVsV01MeVZ5b1ZBTThKMkFTcmVDTWF4aWlQOEJkS3o2SUVE?=
 =?utf-8?B?TDlvZ3JmaWtzN2psZUE1MnVwYmtUSWtDSkdkdDhUMVgxam9NZTZWTjdqR0V1?=
 =?utf-8?B?NGJmY2p5MXRwUDZFVXkvVHVZd0d5TU8xcGFoU1RtNncxb0VReWloeFk2cjdr?=
 =?utf-8?B?bTBpcEp4UDVNc2ZDZ1dhV2Q5dWkwZUxnaWJGSGVkdGp3TjNRZllBQT09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 205c0465-e259-4de3-cc9d-08da269050c8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 07:50:49.9454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +CzoHVHOiS6cYezPYOmH07ryirpTQQaigXAkacoN1bvT37lxpkSMkFYhp3SWiDwwq4jkDFdt389Cbz6XAf1ehQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4289

Hello,

The noceras seem to be in working condition again after plugging the
hard disks directly into the built in motherboard controller instead
of using the external LSI RAID card:

http://logs.test-lab.xenproject.org/osstest/logs/169619/

I will bless those now for real test usage.

Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 07:53:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 07:53:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312419.529649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitXE-0004CB-3l; Mon, 25 Apr 2022 07:53:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312419.529649; Mon, 25 Apr 2022 07:53:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitXE-0004C4-0t; Mon, 25 Apr 2022 07:53:28 +0000
Received: by outflank-mailman (input) for mailman id 312419;
 Mon, 25 Apr 2022 07:53:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Y4oX=VD=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nitXC-0004Bf-3O
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 07:53:26 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c9089d39-c46c-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 09:53:25 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B2084210E3;
 Mon, 25 Apr 2022 07:53:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 37F6513AED;
 Mon, 25 Apr 2022 07:53:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id lC4uDHRTZmJKbAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 25 Apr 2022 07:53:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9089d39-c46c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650873204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6J/iNUKJLZU6UZVIYmW6fFp8/3H1kEij2Zec5To3N0Y=;
	b=VK+MEYCddHzu2chMnuBog0HhHzDWTsWO0kmAh0n6rBNTGvYIU99i5py8YfvtmdmIpZ5PbH
	5KfvHmprQjqkkoLetj6MvrWlmPP8TcW26ax/HStcwGdPPLBmtXufZm2f/LXkfuABmpJg8Q
	MOvPo6hKLF5Ipdy1doBtgq7a38GHnEo=
Message-ID: <22a6eb7e-f98c-ff15-f4dd-b2834ad345c8@suse.com>
Date: Mon, 25 Apr 2022 09:53:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Content-Language: en-US
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <e63bfa2c-6edb-f224-1d2a-0c69330492ad@oracle.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <e63bfa2c-6edb-f224-1d2a-0c69330492ad@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------UMN1MmzbWRc84Fi7yZ5FDfaK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------UMN1MmzbWRc84Fi7yZ5FDfaK
Content-Type: multipart/mixed; boundary="------------vBUQSUV9DXk8H0gwrYNEVMMz";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <22a6eb7e-f98c-ff15-f4dd-b2834ad345c8@suse.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <e63bfa2c-6edb-f224-1d2a-0c69330492ad@oracle.com>
In-Reply-To: <e63bfa2c-6edb-f224-1d2a-0c69330492ad@oracle.com>

--------------vBUQSUV9DXk8H0gwrYNEVMMz
Content-Type: multipart/mixed; boundary="------------CscnO1cb8JXTmYt8xaramFbd"

--------------CscnO1cb8JXTmYt8xaramFbd
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMDQuMjIgMjA6MDgsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDQv
MjQvMjIgMTI6NTMgUE0sIE9sZWtzYW5kciB3cm90ZToNCj4+DQo+PiBPbiAyMy4wNC4yMiAx
OTo0MCwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+Pg0KPj4NCj4+DQo+Pg0KPj4+DQo+
Pj4+ICsNCj4+Pj4gKyNpZmRlZiBDT05GSUdfQVJDSF9IQVNfUkVTVFJJQ1RFRF9WSVJUSU9f
TUVNT1JZX0FDQ0VTUw0KPj4+PiAraW50IGFyY2hfaGFzX3Jlc3RyaWN0ZWRfdmlydGlvX21l
bW9yeV9hY2Nlc3Modm9pZCkNCj4+Pj4gK3sNCj4+Pj4gK8KgwqDCoCByZXR1cm4gKHhlbl9o
YXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2VzcygpIHx8DQo+Pj4+ICvCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIGNjX3BsYXRmb3JtX2hhcyhDQ19BVFRSX0dVRVNUX01FTV9FTkNS
WVBUKSk7DQo+Pj4+ICt9DQo+Pj4gU28gaW5zdGVhZCBvZiBoYXJkY29kaW5nIFhlbiBoZXJl
LCB0aGlzIHNlZW1zIGxpa2UgYSBjYW5kaWRhdGUgZm9yDQo+Pj4gYW5vdGhlciBjY19wbGF0
Zm9ybV9oYXMgZmxhZy4NCj4+DQo+Pg0KPj4gSSBoYXZlIGEgbGltaXRlZCBrbm93bGVkZ2Ug
b2YgeDg2IGFuZCBYZW4gb24geDg2Lg0KPj4NCj4+IFdvdWxkIHRoZSBYZW4gc3BlY2lmaWMg
Yml0cyBmaXQgaW50byBDb25maWRlbnRpYWwgQ29tcHV0aW5nIFBsYXRmb3JtIGNoZWNrcz8g
SSANCj4+IHdpbGwgbGV0IEp1ZXJnZW4vQm9yaXMgY29tbWVudCBvbiB0aGlzLg0KPj4NCj4g
DQo+IFRoaXMgaXMgdW5yZWxhdGVkIHRvIGNvbmZpZGVudGlhbCBzbyBJIGRvbid0IHRoaW5r
IHdlIGNhbiBhZGQgYW5vdGhlciBDQ18gZmxhZy4NCj4gDQo+IA0KPiBXb3VsZCBhcmNoL3g4
Ni9rZXJuZWwvY3B1L2h5cGVydmlzb3IuYyBiZSBhIGJldHRlciBob21lIGZvciB0aGlzPw0K
DQpPciBhIGNhbGxiYWNrIGluIHN0cnVjdCBzdHJ1Y3QgeDg2X2h5cGVyX3J1bnRpbWUgbWF5
YmU/DQoNCg0KSnVlcmdlbg0K
--------------CscnO1cb8JXTmYt8xaramFbd
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------CscnO1cb8JXTmYt8xaramFbd--

--------------vBUQSUV9DXk8H0gwrYNEVMMz--

--------------UMN1MmzbWRc84Fi7yZ5FDfaK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJmU3MFAwAAAAAACgkQsN6d1ii/Ey/e
6wf/UlTnGioaYcmvwVrbHCMgdeIF87ezgg0eMIIROuAmVceVaVjdBTSC4AN4Aa3Z4flFUi80wC/q
SZI7MKBolM6UwNTFybbyltBjRxGeVCDT00kzWiAZxIWCjWBVq16P1XkOJe/B1cLKkyFLRwCOkqEs
f50IWV3DadHahPJSoygFSucX9PNybmD7N8sP/yKwIOVxIgnZ4NrghbPnhtF7WCCJkgYXzEW1yzd+
wWIvBNMiZoAawYn7IUhj63lqjbFQYLnYxOY2VAcPwhXxMgSSuJVkzLlu/KIGuZbrwVqNi8qzSeTK
Z4eWZo6AUCpQKIYWUxSy7ZtdljjRC/M7UE8M6AE/HA==
=PvOM
-----END PGP SIGNATURE-----

--------------UMN1MmzbWRc84Fi7yZ5FDfaK--


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 07:56:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 07:56:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312426.529660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nita9-0004pX-J0; Mon, 25 Apr 2022 07:56:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312426.529660; Mon, 25 Apr 2022 07:56:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nita9-0004pQ-G1; Mon, 25 Apr 2022 07:56:29 +0000
Received: by outflank-mailman (input) for mailman id 312426;
 Mon, 25 Apr 2022 07:56:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nita8-0004pK-5P
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 07:56:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 358a12c2-c46d-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 09:56:27 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-e4RWyqFqODW1oZFw3oMWsQ-1; Mon, 25 Apr 2022 09:56:23 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB6906.eurprd04.prod.outlook.com (2603:10a6:10:118::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 07:56:21 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 07:56:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 358a12c2-c46d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650873386;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iK6dgsjGKDgplw9d1zD27UYyxD/H5pBjgMUJG558ock=;
	b=XaZ+gqiLkeeIVnNwiFRlzR+/NehkUJuj2o45qCK1Gqpzvhyj/Dzc+zw/KY98v9ENPor1Qa
	VN03xQz8FkveF046iY8Cl2l2IYi/0uNLIlWFWT5+TwBTFqwIonADe7oJjaVsY3fcpfNZLW
	0mvpgunxUjrdzZi4UkyafO3++Kc83M4=
X-MC-Unique: e4RWyqFqODW1oZFw3oMWsQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JlPrF/bMRMzE0OkyxKnVWe7kLjtV5U9AisVUEzD6bq5MGrcmlkws0OQsNHNGOolIU0FZ9vK51GCwjEfjs0XQDeR+5kkJTZCmRoP6NjgBveDbbiLzs/pyc6quuphLy/MUMgYleZZWpmKQif4FCDUXi+HSBhviW3AIzc4rbgOIrwy/GwP0mCilLWwJHNKR0YWNzCm0NClEGkke605dRdbFbsd+ZX20xiZDOT+hYUYCBeZKxxSTUKjKTrCwj+Uz0Bq2cKrfFenlWmiTvRK24YMugVZSS23p+X1RPcBQ++PEll8CXkjsj3+WHbFlHMoYDO0jBN+cWqEkgJlz6R9TQR+C5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iK6dgsjGKDgplw9d1zD27UYyxD/H5pBjgMUJG558ock=;
 b=TbBpT9W6bsqqo8EGecGwJyaTwwzj7GqYgD5mmzx5QvBiv9ltUI20XW0P6vSyn7Kw4J8SR6DfjwKs2mC/y1dZOY0pd3WqRLt9WRDLGXbPzfvynn6dNNraoOjwp+V/dauicvHRlhp/NPvYylzpGSYwzYh41GMVXc2DktHB6fyzBO2jjHiv4wZW4T59J8VKqcTtmFHVMLTJMW5OchpDa4J9xHR/FoHxKTwOaA+65qnUwtDQEXwzML2ghtrY24TUOiLhOIGlCHabf0xahCwRogJyxX/Bbg/y5qN6/YvvAY1zeP13GT0/jGtemhbMWDW4mbORsydOZGb4NYwKOk7KbkCFOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <325103a8-8c5d-06cf-0fab-a977398c642b@suse.com>
Date: Mon, 25 Apr 2022 09:56:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: Julien Grall <julien@xen.org>, David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220422153601.967318-1-dvrabel@cantab.net>
 <c15c5faa-ba5d-4407-e9e8-341f41200d77@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c15c5faa-ba5d-4407-e9e8-341f41200d77@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0766.eurprd06.prod.outlook.com
 (2603:10a6:20b:484::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b3d0808d-a24e-49e0-a609-08da26911632
X-MS-TrafficTypeDiagnostic: DB8PR04MB6906:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6906E954E49ACD2FD09A602CB3F89@DB8PR04MB6906.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mohM7Sxzb7BeKXX8EcZiDkHp6Mps2acM9nZXErluBPuTx1b3R586Y3zHkwGW/nthTsEBe6wuiGhW0vnCSFsB0xWLETK054skOVK+ioU9mod+52mJW2PcOss+mWEPxXvoqCT3TMA+e37P0qNkUZrmaEFc3IOtgGCDNfTbeUBdsQQliR7YANLsMSUQYFHDED6hL48rI3Y/cEaMqNwnMrvG5Gcmxta2LTYRWNq9uFUQL7qShtz8O1H+etLeU6AGOBGr+XuxjHzSk8eemdREDvOnvvZvYQlrVxkfD/wdNtzqND6phvhvnInWlObv87VQK4N6wLJGXP/q4hmFUoQMT8tJ2IJrl5DhPbD0BIEeC3d6S8ItyWtZUQKsOZzdeC3+xA7zL2Dj4vQxbTndfeDrE2rBE540ihsRZ/bmv2+prWeSZg1EyvUnHRWB+ELQ++FJbf0UAktKvi+syER92d11eDWfhfuGhpU/LhHruvyPA3TdqQD3aW5R98k003orQSefmknZIdES4nNZ/Au6HZJWmZjZlvMf5Dd1tF/9brSQOiryCgt9CgEW1zqzWqdkuMXvSqukp0eWiIoFKSTqQNLIRXEfk2id1NtJ7XxRrYOPD3uHtQgPtqwhc+wLoeEaUTSp1fJx0H11rkZ0Sj0fs3/9yjddbN3oRrZWze09irF+3hSfdavAaQpA3/fGwiiUM6eoBCYUdZcWoTIaiN3DI/mREd4BmFPj1Wj4hDbXcaukQoUyZnSmSJMvB/eMMMhlodopnN4g
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(31696002)(6486002)(86362001)(2906002)(508600001)(66556008)(66946007)(8676002)(4326008)(66476007)(316002)(5660300002)(54906003)(110136005)(8936002)(83380400001)(26005)(6512007)(31686004)(2616005)(36756003)(53546011)(6506007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WnVBbmg0bnF1c3ZPNHFsWFY4dXBWZmhEUVNRNG5JNzVpRDRTQVZtMnZTNU9O?=
 =?utf-8?B?T1pBUHFjTnpDVm9nTXJmZThWSk4vL25BTTRrQURCd1A4VkU2SXcwOWZuNThh?=
 =?utf-8?B?TTRyK1NCN1B0TXVuZWFsblRYZzg0a01xS3NYZHZRdnZKcEMxaG5wQmdvWjcw?=
 =?utf-8?B?cmpGWDFHNnNWNERGQmNXa1lNeENOSjBoaXZYL3V3a1dCSEtGb0szT0lQNlFn?=
 =?utf-8?B?VnlBV01tY2ZWNWZKNUtDeTdmWElqRGJhMWp1OHl2T3FHNGdtSXBkNjNwU3dI?=
 =?utf-8?B?RmQwNzNzcWl1ZjRJajBqeEYxVlJyOE1RQ2pwVDlHcDgyaGswVHdDYU8rMkVy?=
 =?utf-8?B?NGhSb1IyKzRCZ1ZQOGNWOTVXS0VSZUZSeFY4NkUzaUhjTm53bGlIRGZ2WHVX?=
 =?utf-8?B?MnNpZ0ZtME96b3ltZ3g3SlZkNE1hVS84SWthSkp2c3QrdHI0NUI4UnhRWWc3?=
 =?utf-8?B?c1hWMjEvVnRVL2JoSXBLakJPY1NJZVlTMWc3WERzbWd0cDlmeWxaTGM3SG0z?=
 =?utf-8?B?cldXWVhYcys4R0tjTEppKytuVGVkZnRQRWZteC9sRjRQN2Zta1FhRjRrZGNM?=
 =?utf-8?B?NnNlL2xuOGJmNWFDWmxER1BJd0pBeGhPN05IZjZNMW55UVdaK1pHKy8wdjBN?=
 =?utf-8?B?MkovRGd1MTNiMmNsT1VOMHBLYy9nZk1pbWFvSUdkcC92V2Jxc0E2UVBwcnNy?=
 =?utf-8?B?U2wvNndkb2xnT1k2bncxcDBFRlJOS1NEb1ZOblBjbGQzcG9ueS84NU5xSG1W?=
 =?utf-8?B?Ri93MGtDK2wwREp3SjdZcmd5ektKcjF0WSsxRlBpeS9WZVFmWlpMWnZkaXNy?=
 =?utf-8?B?MEhreWlpRXVuRmdnZ2RPVjY4aTQ0eHp3M1VuVWJOVkloeTNhZ1lneHNtZVVW?=
 =?utf-8?B?ajA0aGZScUgyZmNINUNjVFpCOE0xbFNuTkc5dlc2Z3U5TXp0dHhtbzlXeC95?=
 =?utf-8?B?cnMzbDM2Y2FKcmFURktCeHpoZmh2dUtwNzdOT01BWUg1aytmMzEzeUs0ZFhJ?=
 =?utf-8?B?UUIvQXE3aHV5SXAxTGtiY2VYTytiMkpFeFlNMFdSVGo5WXhOMEJpcitzZndn?=
 =?utf-8?B?MGViNVI3TmJIYVljYmFBL1V2d3o1cXN1TVUzRGptZ2FWODFtRE5SQ2Jub0Zm?=
 =?utf-8?B?dDdOSitNbkU4Wmh6cjRUVzh0QzNGNkZ0S0EySFhlZlNFa28vbXBZcTIwbXlv?=
 =?utf-8?B?b1VzQWxuVHdLMVVUdllBcWJUZ1VZRktTRnJ2amo1VDBsNXJrdHUrMlNLZWdO?=
 =?utf-8?B?SnFrV3NXQWVnTTZCU0pNOEs5WkdsdW9XV3ZZNHBId0I5UytQTmpjWVM3bnJH?=
 =?utf-8?B?NHYzNTVVbXYwMkI4MVVuMWx6eFdMRDdGZzgyanFlSU95SVlGRHNEaGV5cFg2?=
 =?utf-8?B?V2p6T3paMWcvbHlLeVliSDl3OXkrRTBKdEhSM2xwWkg1Qkc3eHdxa3pQMlVt?=
 =?utf-8?B?WFZESnhiZ2lFMjBwVlhWTkhzNVQzWmRWMHZYOWNqWjJpL3IxR2VpU0pVemVY?=
 =?utf-8?B?TnE2NytjRkVLZ1hhN0RKbDdZdlE2OVRFbFJhbW1Uajd2bkF4dzdGeDF4WFVQ?=
 =?utf-8?B?aTlwWkpDWUVTeFdqQ2xPT2hPdjhIVFpuTjlHcE9Ic015b2pVdHdyUjBnYWFx?=
 =?utf-8?B?TDBGb1YvaTI5UUFpcXlJWWI4QkVHU09GdFJYbzh1aTg2aEphZzl2ak5hSHds?=
 =?utf-8?B?NjF1YmdxTGxHRlJZYnN1R1NGQTh0WWNZVzFlcFhKQ3ZhS3VPdmR0SU4xOStU?=
 =?utf-8?B?YmtFYmhPdEdhZWhVTHdpeVhsbUFmWjU4UG9sYk9IWGxJRmNhMWhqUHNrUmpJ?=
 =?utf-8?B?amFEY1R4emJud3dkcmlhSDNrck9ZMk1mQThJTGlCaENUZVJEbytoV3NMb3E1?=
 =?utf-8?B?ZjlzMEpRVFovMm8zaGtCK25WcWFvVTQrdmJWc0VZb3ZnZUFpMEZ4L3lObll5?=
 =?utf-8?B?dE10RG41OEorT1pjT2kvQnFYbTliU3VQZk9lS2ZaRlRSWXZaNXVwcjdmOVgy?=
 =?utf-8?B?anhQd2tnTytPQmZtOUNmREpiS0VYK1VDV3NmTVZ5bTRNUlJ2ZUpIcTkwRXJM?=
 =?utf-8?B?MEMya3c5NUE0TFg5VUVvNThyN3gxNjFUbmlva2RTQk5yQjlyaG9wQVlOZE1L?=
 =?utf-8?B?Z1UwTlJteHBGNk42YmxHOURTRXB2b0UrRStCVHlrVENDbS9UR3RqTFRDR3ZP?=
 =?utf-8?B?WXk2Q3pXaTQ2S3dBR2hFNTIveE1BNHRCT0FUK3M1R0drRHMyOGVwT3NtQ2Fn?=
 =?utf-8?B?SFpzdTZ4dzVEclhBcWluYmdMbEZXQXM3K3FCWVp5SWlBZWRoMS9IM3V1N0pV?=
 =?utf-8?B?RDZGODl6a0RmKzA1S05ERlVIZ0l0d3c4bzJObk53TUtSaWF0ODFHUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3d0808d-a24e-49e0-a609-08da26911632
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 07:56:21.2127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iqkuo7lM9XFm9xoF9JUsfrWtRukisZ+06/tvOif8orrJ/6gFcA0xuT/mee0d6Etm9Q0crSArrPogc2Bxde6A+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6906

On 24.04.2022 17:52, Julien Grall wrote:
>> Changes in v3:
>> - Use num_online_cpus() in assert.

With this ...

>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -162,6 +162,13 @@
>>   static char __initdata opt_badpage[100] = "";
>>   string_param("badpage", opt_badpage);
>>   
>> +/*
>> + * Heap allocations may need TLB flushes which require IRQs to be
>> + * enabled (except during early boot when only 1 PCPU is online).
> 
> Same remark as above. Also, I think there are other cases where 
> num_online_cpus() == 1:
>    - Xen is only using one core (it will not be a useful system but 
> technically supported)
>    - During suspend/resume
> 
> So I think we should either relax the comment or restrict the assert 
> below. I don't have any preference.

... I think it is the comment which wants bringing back in sync.

> + */ > +#define ASSERT_ALLOC_CONTEXT() \
> +    ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() == 1))

While by the time calls here can legitimately occur the online map
should be initialized, I wonder whether it wouldn't be better to use
"<= 1" here nevertheless.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 07:58:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 07:58:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312432.529672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitcI-0005Ql-V1; Mon, 25 Apr 2022 07:58:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312432.529672; Mon, 25 Apr 2022 07:58:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitcI-0005Qe-SC; Mon, 25 Apr 2022 07:58:42 +0000
Received: by outflank-mailman (input) for mailman id 312432;
 Mon, 25 Apr 2022 07:58:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Knhg=VD=bombadil.srs.infradead.org=BATV+0e76985a1041d5454cb7+6819+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nitcG-0005QU-Bn
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 07:58:41 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 81e9e2c8-c46d-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 09:58:37 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1nitc6-008hbI-PT; Mon, 25 Apr 2022 07:58:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81e9e2c8-c46d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=bk7N8VtSWAvLQd3yMexQM6sFuFonXwjn/dFWlACLuw4=; b=KrNUg6E9jRh6S9p23phIwDD+A9
	2yjbvoiMW3hXguiVED3XGeLI5RAp9z3c3rmBxo0F++ml3YQ8tcOKSZOhMELY6kv+Bo4zE7qjAcWtU
	4e1Lurbi4qCxDhsiGkas5y6uhLAsCknOpNVtA8OPhC29Rp4ibbQQWk7Dx2gUkzdJLCazkHqGz7Izp
	3JA0+CRtthmVp/yKRShz0BN0MuqCJ6vXAbzrTgeGDRw/XkPuzBc6ZO2k7jO4uF8Mglc5aF6PsTyYT
	WrTKukboCsRrzIBFPXxbH/jQ1NFzu8tuncjK13ASp0sXfOTrrMx8nRWkxEyq52l9iDKiiOEFi2QRD
	o9WfNkjA==;
Date: Mon, 25 Apr 2022 00:58:30 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Juergen Gross <jgross@suse.com>
Cc: Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Message-ID: <YmZUpua3hkCPdbfx@infradead.org>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Mon, Apr 25, 2022 at 09:47:49AM +0200, Juergen Gross wrote:
> > Would the Xen specific bits fit into Confidential Computing Platform
> > checks? I will let Juergen/Boris comment on this.
> 
> I don't think cc_platform_has would be correct here. Xen certainly
> provides more isolation between guests and dom0, but "Confidential
> Computing" is basically orthogonal to that feature.

The point of cc_platform_has is to remove all these open code checks.
If a Xen hypervisor / dom0 can't access arbitrary guest memory for
virtual I/O and we need special APIs for that it certainly false
into the scope of cc_platform_has, even if the confientiality is
rather limited.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:00:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:00:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312445.529683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niteL-0007LV-QI; Mon, 25 Apr 2022 08:00:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312445.529683; Mon, 25 Apr 2022 08:00:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niteL-0007LO-Ma; Mon, 25 Apr 2022 08:00:49 +0000
Received: by outflank-mailman (input) for mailman id 312445;
 Mon, 25 Apr 2022 08:00:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niteJ-0007LG-PU
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:00:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d037d38a-c46d-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:00:46 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-6U_zLnw1OtaDTW2qjc4nCg-1; Mon, 25 Apr 2022 10:00:42 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB6342.eurprd04.prod.outlook.com (2603:10a6:20b:f2::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:00:40 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:00:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d037d38a-c46d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650873646;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dwjUfjasWoK5VqTh6RqK/vuveUXh689QuV2Uvjsgduo=;
	b=TI5a1kG1/miob3DRQyUDqGhH5D/GTnQg+Z0YbAZnGx8AL7qk5hDDmSBkjxbJyNgtHTjHI7
	pW1WZIdrC940NRyepe5CdyKjhiJ6mtEanaNhtp4pcl1IthrFuI2+kpZxlElVENZEGUpi4m
	x6jbCcrVPKMrRQtkmS4qCcmNKiJOOxk=
X-MC-Unique: 6U_zLnw1OtaDTW2qjc4nCg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UlGyv8YMtbIbmiELefydqgc4PRHRmpqaidjjcY1lyShKhMSumJHK1RInXbGJJ03Y+YVkS6UTpkfzraaAbTwPAzWxVi0lj1u4rnmYJWJq2EOn+ZmuMgjqDerQ9X5HtRK8Nj8OYAXeHuYEZg95bqltn2N9MQh+ROh8RZYeCX1ksv7cCHSWTugI3VyTAnSJDYh/CxY2iAF67mRTW2QI24Q/NNeCXUe/bLxaXBkb1y0cWW6LwN2aZRKO6fCFSZi5nKOmW9HMdZfisoSmesOMY1fUlNrs3uBUSWX7+k0ic4GN1DDmZucT2nQoZpxr6OjGw8kdxaB1nD08rUh3XQxYhZNP+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dwjUfjasWoK5VqTh6RqK/vuveUXh689QuV2Uvjsgduo=;
 b=PssR486ikTrUaRUNk4TcKoOK3Mqd4JnSsp4yzC+3lZ2hGN63R7+uoxA+Y1V3vRPz+IPuZX1G1RgjQ10rCfhAZDCVlyoWCbIXQQS8MW/4B6vK+ezWGjdak/4CaTxzDxj+if2RTJSzzi1PRQU+9uFg2Es4Gvxw70h6dAh2OfkJZjXBewI7gA5ZKbfxL4K0TxYR2dQJ93MfUCgH11TJ3Qp0nQXfRG8B3VfnxDe5dktqS8pC35jcgOEiVlUBMHjP1WBx8FUExSDK5lEe/+QYP110RL/qepwwjsIUQadVd2Hm2WhZVZH8LeCr6YGMVDhxIXgcMvbxBU1edlVf9JJYD57HQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ee51e12b-806f-99a9-b60d-84d6a9a939d6@suse.com>
Date: Mon, 25 Apr 2022 10:00:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 5/6] xen/arm: unpopulate memory when domain is static
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <20220418122251.3583049-6-Penny.Zheng@arm.com>
 <b76b3207-4eb7-5236-6812-d64cd4dad17f@suse.com>
 <DU2PR08MB73253426B332CFF5358AB346F7F89@DU2PR08MB7325.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DU2PR08MB73253426B332CFF5358AB346F7F89@DU2PR08MB7325.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0125.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::10) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a8f46a94-16ac-457a-9c7a-08da2691b04e
X-MS-TrafficTypeDiagnostic: AM6PR04MB6342:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6342A266B07576575A6105CCB3F89@AM6PR04MB6342.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zX5pJQYVQlC3iz80Y20m5O67JOEOpcIlydJfx1O8qNwDZg3e7bOu3rp401dJebe11yRxsQflAD7Gb8UToDuBRRyVsUd2X0UFQW5Ym0syxhkIB/nlcR6Ql82SPuk86vr3HjfsRS+kQsCkwXkfu7D+zBuZROP0PvvPd5la3lulKOp6L+ST21j1NFEnO2V5Z1KuS7YM73ti621j2IIZeQq/Iptjj5azAYCojhT3+EcAoq5szRGXzhENev6m3m3f3wt8Y0lIpupUKnmMpIX4X5OzfnKcYTyB2XJcK6Wz8qZr84GTNey5kGIRkdI0vWY0nlM1XJBbHuAvTOwFyQ6pAA10nAnS+H1zxv1sNsmKuX059cNcYDYRNhIdKAfsQqlGdQLv3qfHRmln90yieIlH3/kYlntqF7pBYqYU3BufDEtIZTzT+VpnVpNGMG33wa8N1MbIcTzpu+P+GmuZ7PAaq4I3eAY+HgWU/u99kDsoe6p+TvWcWYIQ4N/44tgow6nNOJv4b1+luEKpUvqneqF6RXZeSltjI1xfcNDEZMZ0GXQD8gxldvaO3Oh9hDGtw+poj6soLwPuai5upUjqb2RQIi1tQ24IRTwIr7JNRv00tLdsHPKDAmsfSD3OymQo1JAc9FF1SoNeaG4vWQPFIVptt9yYMCup0GMl3fXq5xJQSUIJIGXk4QywhsbbKbcVx+Z+019s8+37D2uWudUsSNYDVokdtmom8QwXf8PlQ7LxAGI386pYVC1DOKkY8VLcLxVRRUNF
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(38100700002)(4326008)(8676002)(66476007)(66946007)(2616005)(31696002)(316002)(54906003)(6916009)(86362001)(186003)(508600001)(6486002)(66556008)(6506007)(6666004)(6512007)(26005)(53546011)(8936002)(31686004)(7416002)(5660300002)(36756003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDRUcEsyVlJFdk1aa3MzUWlYekU2S2ppQ2owMkxOT3AvTHpnTUZOeUcrWmwy?=
 =?utf-8?B?ckk5WTY4MnIzT05oT1h6UVhXSTIydnAvNVlvenhRS0V2b0Y3T1lKTmppTE1i?=
 =?utf-8?B?YWd2UEwzZTl6MUtrODQ4MGpxSnNieVZQYyt2S2NrVFJXa2t3TG9nM1JPbURY?=
 =?utf-8?B?d2VybG5DWGJIUFZPTy9vQnNrdFNvZ2NzcmErNGRhTVNHQXI4MXZjaTNzT2VD?=
 =?utf-8?B?dXdPNk4xMTA4ekgrR2kzT3piUjF1aEh4eGg1M0UvRUFMUnVLRmwwcUdvcmpQ?=
 =?utf-8?B?YXZSQUlzM28wQWMyYWZJQ3Z0aDdodDVvQ2pmdDY0Sjk1UVlQRmJQcVk3c1VU?=
 =?utf-8?B?QUdQVVBoMWdIY0JrM1E5dzg4TEdHNk9CQjhMSWRiOXp5MU1VZndtOC9ReWdp?=
 =?utf-8?B?Z0RpZ3B1dFQyZVFVT0tpcWZaWEcyOW9PUHNYQzNLb0ZUbUpLdUJENzdacS9r?=
 =?utf-8?B?ZnFpVlppYkp6Yk5YM3pyR2pqVkFnUUVGMzRkWlJ6bVI4anlvQnFVV0pBWkFz?=
 =?utf-8?B?aTlFV1RVNWR2RThnV09uQXBwakhtK3F0VTJPQXY5bjZMZ0xRclFEWWRoR2pl?=
 =?utf-8?B?cm8rdVcxZ2Q4WWJ4OWxrM2V3RHNvWjhCbm04aExVb0hRQytwNXNNc3VkM0h1?=
 =?utf-8?B?QmpqNHE5dEdSMDFFcExpb1pMRW45Q2txeG5lS29oV3grVHpqREMvU0lpMFFa?=
 =?utf-8?B?WkIxVGY4eStMWVNSTnA1R2I1dVRIdENpRStrdzJtWStTbUZLMU9rYkhtalJt?=
 =?utf-8?B?d3VxYU05c2IyT0c1U3pwQU10MXBmZjF4VE00WGdEcVN5YnVsNlVISHFhaUoz?=
 =?utf-8?B?a1p4Z0FXaGlqZFFtcGhlQXA2S0lvamlmZE93dXlIdDlxV2F6RDdVbmpVcXN4?=
 =?utf-8?B?QjFDU3Y2eFhlb1gvZytwYmJsR29Ia2VQRFhPZXV0R3FEWGZIUnBJRm1mcG15?=
 =?utf-8?B?TlYraG53TlNtYTVrOXNFOWsxeFhEVUZOOGFkbjVrVW1pWjd6UE5jdG5IOGd3?=
 =?utf-8?B?elFEZWxaSjIzWXBzRml5OFkwRWJUY09xWlQ1Y2lxdFpjOUl6eS8wWnVneG81?=
 =?utf-8?B?Z0hDcHg4QjB6ek1ZbitYc3o1TzFNY203ZmRoNjgyQURkUFVCTHV6R2JaMnI4?=
 =?utf-8?B?VllxRUdNTkhrQkRRZXlpaUxaQU1MS1ZhQ1hDTlpJVytpZzYyQW5LY3Y5ZU1t?=
 =?utf-8?B?ZCtEZmk1Rm9PdzExQUJYYmp3M09qNmlvR29Tb2h0bi9qeFZ6UDFENUhva2hm?=
 =?utf-8?B?SU1udlBPWUdhQkVtWkdaTEVzQkRoK0ZIOVFhSjZPMnZKcG9oWEN6cVlJM09T?=
 =?utf-8?B?RWNUSnZZaVA1cTRWSE0vSy9PNkdiaDJNWm54TFpOZWJncTV3b2cvb0U1bGVw?=
 =?utf-8?B?bVk0aE9HcHFYbWpveHFpME1GWFBoTHVQQWdFOXRFLzErcUZqNjVjZEg0V0ZI?=
 =?utf-8?B?ZXdZT3VkQjV6MTF0Vng1UkF6cndDNEZpYjlDbkErM210a0FiNXhHVlBPWVEx?=
 =?utf-8?B?WXNQcWNIUkV4ZW56ZzdQZW12NkhEcWJIN0szZ2VQVXI5bnYrWXJzOWd5VVlj?=
 =?utf-8?B?elRqOSs0a01Kc0FvZ1ZrVEZUalUzTzE5ZUdhRlhhOWMxdXNvbUc2MVp5WHZD?=
 =?utf-8?B?ait4MnY4b3kzSG9RUmc3TEJoOGltem0xbjJ0YkRkbFJoVDYrNktZMTJtd1Bp?=
 =?utf-8?B?VnczanhuQ21GUENxTUJDUWlSdW9nL1hHRTFvTEg3bllvUWp0S0J3TTY2RHBq?=
 =?utf-8?B?SUw3RmppeGN2ZHJDTVBYRmw3K0FZeTZwM0RKUFp4OTQrcVhwMVVWeEFWVUtY?=
 =?utf-8?B?ZERJM2Ryc0s2b0FMV2lBQkh1WUx4K1NXNGFES1dPZVFoSGw4cDBsOENZTkV3?=
 =?utf-8?B?T0VpOFJ6RXB1SEJScEhTaHZxSlhXZjdEclNMS3B6a0UyL3ArNHd1Wmsvdk1j?=
 =?utf-8?B?Ykt3VkdwRkRSZklPcnRqOWtnNTBkZ0lpTnJwOWp1RWtBTXZ2L3Z0MWd2Zy9N?=
 =?utf-8?B?YUdVYXNHY3ZpZmYxbWpqVUpnaU5EbndiSkcvOHNucUJUeWEvYlp0eVdsYXlJ?=
 =?utf-8?B?MWpWd2xFdVpEWkJqUk5zUEJBVWF1L2ZndHhRU3ZubUxVWUg0Ky96ekJvRDNn?=
 =?utf-8?B?K3ZNanBaRjU3bDhUNWlqRDhNMS95YzBxdHFVS0N4RjZ1VytiU0V0MVNBeVo0?=
 =?utf-8?B?Q0IzSUo0RTdscWcyZnFCakFjMlRpVVNqRzNORGltRVlsUjRsdnhkRnhYby8w?=
 =?utf-8?B?ZTB0d0tuNjVnUjhIM0dHbHEvR3libytwSzRhZ2J2eFAxUkpKVkV2UXNJczB5?=
 =?utf-8?B?aENhWnNpYWRVN2FkWndwY3FyVDIzY3dWdkJZanJzVFl2RkVkdjF3QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8f46a94-16ac-457a-9c7a-08da2691b04e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:00:39.7339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PH62O3xeaL3AqcwQBxAORTo2oXH8K0kRuwG/8b2UkgsAQXjktTnxludmnt93j5fIsVaIJ4ypu7OI8QWYwgpX0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6342

On 25.04.2022 08:34, Penny Zheng wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Tuesday, April 19, 2022 5:11 PM
>>
>> On 18.04.2022 14:22, Penny Zheng wrote:
>>> --- a/xen/arch/arm/include/asm/mm.h
>>> +++ b/xen/arch/arm/include/asm/mm.h
>>> @@ -358,6 +358,23 @@ void clear_and_clean_page(struct page_info
>>> *page);
>>>
>>>  unsigned int arch_get_dma_bitsize(void);
>>>
>>> +/*
>>> + * Put free pages on the resv page list after having taken them
>>> + * off the "normal" page list, when pages from static memory  */
>>> +#ifdef CONFIG_STATIC_MEMORY
>>> +#define arch_free_heap_page(d, pg) {                    \
>>> +    if ( (pg)->count_info & PGC_reserved )              \
>>> +    {                                                   \
>>> +        page_list_del(pg, page_to_list(d, pg));         \
>>> +        page_list_add_tail(pg, &(d)->resv_page_list);   \
>>> +        (d)->resv_pages++;                              \
>>
>> There's no consumer of this counter, so I'd like to ask that it be introduced
>> once a consumer appears.
>>
>>> +    }                                                   \
>>> +    else                                                \
>>> +        page_list_del(pg, page_to_list(d, pg));         \
>>
>> Is there a particular reason to have this page_list_del() twice, instead of just
>> once ahead of the if()?
>>
>>> +}
>>
>> Also this entire construct want to be an expression, not a
>> (compound) statement. And it probably would better evaluate its parameters
>> just once.
>>
> 
> #define arch_free_heap_page(d, pg) {                    \
>         page_list_del(pg, page_to_list(d, pg));             \
>         if ( (pg)->count_info & PGC_reserved )              \
>              page_list_add_tail(pg, &(d)->resv_page_list);   \
> }
> 
> I'm trying to refine the arch_free_heap_page() here, but I'm a bit confused
> about to let it be an expression, not a compound statement.  Do you mean that
> you prefer to let the if-clause out of the arch_free_heap_page()?

No. You want to put parentheses around the braces, using a gcc extension
we make extensive use of throughout the code base.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:19:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:19:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312453.529694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitvr-0000sg-Es; Mon, 25 Apr 2022 08:18:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312453.529694; Mon, 25 Apr 2022 08:18:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nitvr-0000sZ-AJ; Mon, 25 Apr 2022 08:18:55 +0000
Received: by outflank-mailman (input) for mailman id 312453;
 Mon, 25 Apr 2022 08:18:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nitvp-0000sT-PD
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:18:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2373fa0b-c470-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:17:33 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-5y1FxReCN4mhQPngoN3a0A-1; Mon, 25 Apr 2022 10:15:15 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB5187.eurprd04.prod.outlook.com (2603:10a6:208:ca::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:15:12 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:15:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2373fa0b-c470-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650874641;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kgFXD2ZM0QepaS14l6MPX+1+SMvT6zHSjQoxlyY18es=;
	b=kFhlCX4eQUmMMZyyqBkTbKW2UkeMbVPxJ9SNl7+H68z2mHFPX2OZrwm5xHgkkBZusBb2P3
	lHfFNB7mPCHFF1t4uRujkB/rtPpefDHN3GipqcDg9AB2519JQxThByGPvycg1JlTFkwOH4
	V0TOjAkC73jqjFq9rIcH01dUn4Ywr/w=
X-MC-Unique: 5y1FxReCN4mhQPngoN3a0A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lqauwyr+ADJto2FW1c2MeOEY3XGpanqMjKKzKsL9poy2m8kCSogU7En2cEL19q3k6AY/z3sfirsVrC3zkDdN9gFIY04LQ29DaVqKxsbH0HQ5Kjjtg/SqL1PYBaGwUQm+5sKzmh+5XREAKSAU5Rll9/9KWu1it3TVdpLQhJ59nXwf6wCdrHy6xUz8ecjQekd4BF5XL1e8zKnK3fqM2YcBFBFK/yGac5exDUSdgivkCGflwPGoS3aFwtTgBJc1E9/sPCzsXndC2kFts7fafwBRUWT5gXVPxyoied6PQeo/4rMMWh33VoKYWn0JPjLUFHLT7c/xbYzhHVemOZQQMDMs4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kgFXD2ZM0QepaS14l6MPX+1+SMvT6zHSjQoxlyY18es=;
 b=gcIShmr2ky5pKCCuoRdcoTwUavPkTWJN6b4eUPeViXYDKvQJsapGKEsEU+P4vHOeB9MAUzITttJ/nkDWSDJ+uxVtqCuWgIr4cxU9JmPWwbGQlKr16q2LjlMabSoLguFHjLs4MImzvNlN44MYcC6SEVUeoInwWWkJMdqIdYOeQEweyNFLaS+SdvjUfkXhULlRoqS+0moWwgPUbSCBzsZNunBCZQCRpO25iwzwS2pkmCf+CPoNvN+ObD1cOmYpxulTS+aHKw90qIdNx9ZXMYR2RGU0z9vt28hY1huYpfmMUrQeImPVBHnPYxj0Jk06juNNVFnwYSbyIYxSkNutSomaZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8babf7f7-988d-641f-fc4d-6d5ea1227e84@suse.com>
Date: Mon, 25 Apr 2022 10:15:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/mm: page_alloc fix duplicated order shift operation
 in the loop
Content-Language: en-US
To: Paran Lee <p4ranlee@gmail.com>
Cc: Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
References: <20220423193501.GA10077@DESKTOP-NK4TH6S.localdomain>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220423193501.GA10077@DESKTOP-NK4TH6S.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0091.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::32) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4bd57526-9607-4404-a3a7-08da2693b875
X-MS-TrafficTypeDiagnostic: AM0PR04MB5187:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB51874118FA1D9F3E55EF07CBB3F89@AM0PR04MB5187.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VY9J6xPScB80vO/AB1PbVgQe+268DAk2RRCgR2tSi1joNTeJ2h2Eb3iG+Ojq9TmwUdb5LQQky3XNPM+sEkGimnOvCYBNRW9YWcAvr0DwNjdfPOjNSraq9YBbkCSlE2NaG60HJw5LGFCVK7NSEPvAPWxI8wxmmAR6I3/QGSVRTYHoGP0x9vDaYb7A4ThYrhinoCMeCivop2l36J1W3aRhuYGHXwmcuL1XLuotQAzdUGw2h0pCd3oGUMKW2kwAB3T9arUaoR+TrtjOgTU3Q3P9XwiGMuY2lC1YmcdbsPm9ggrXrZblXUPuUZ8fHtEYaiTKeOEyz7mO+hSQ1Nw0+JRLmpt/JWS81fDPulc+PEyImy1qlGdGJS5aq70xOJE4i2CFK28Km8BGy6cYOGG+TVjt8StsrmSJpf4UiQdXPCiCgYkT8Dk6iAE9nJRXtlkeBXTBucuV3rUXXJfx0UyUw4wjn1QlVDZ1QQx7d1Gv4W6BycIK3LL53kfl3U2p7B5YCdTZ3KV12Xv6Iehw1qUmQC9tRfG861/WimQOzF2wx1wFhViFy0b0O8twrXc4ydoKE1Y/XgRAhS0BvOHuM4i291TuDz05cJIflqJHh81AKZZWThhsSjOK8OBKqsmGHZJOqvkUiG08+G1Fe9dsgPItCf+6SoJNmjbZgQUGJe6Wg6VRmFFs6hY5t7Atf3OqxfB4TzYu1FrKpwV+wZKO6h9Au6M+KTCH7oVWvHlRuLgsmhKyu7MRlSHEG5XEjy0VA/vIfWdH
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(36756003)(83380400001)(5660300002)(8936002)(86362001)(53546011)(6506007)(66946007)(186003)(2906002)(2616005)(54906003)(8676002)(4326008)(66476007)(66556008)(6916009)(508600001)(316002)(6512007)(31696002)(6486002)(38100700002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cUJTaG1ibkVqNHRHMWcvb0xDbW1DYVdReDNpTk83aE5zNm5HQTBraStLVTdz?=
 =?utf-8?B?bHBxK05qbXpTK1JSK2VQaXlxMTN2b3hhMDRzODZTcGdITW0wN0pOWnJ2S3hB?=
 =?utf-8?B?UnQwWXhpQ2lBVGFEVGVXNHAyeVc5cnlENTVjWGl2U2NLdHVMUEl4Y3NBLzBT?=
 =?utf-8?B?R1RWdmxMWU5vcVcrRUZTZ0tyRCtKT3NwTUs3TVBXeDN1NTNhdXl2THduYXJy?=
 =?utf-8?B?NmZ5SitWMndPZzJvTXdOdkg1dFZpaG0rUUowUFhOT2hnRHR3K1VRazFLVmo0?=
 =?utf-8?B?aHFKK3o3K3RoeXg0cGxuUEk3cGdLNE9FbjFWK3pMQlJCRDZBVlhPOWorOTl5?=
 =?utf-8?B?REc5bkMrZTcwUVloUU55Rll2cHpGcURRYnBwOXMya0NEZUg0cGRIcHJWM2I5?=
 =?utf-8?B?VFpGMWw3VC9mOUVZOGt4SWdla3FZeEtlQ3o1Y0MyWklPT05sNzJaTHo0TURa?=
 =?utf-8?B?Q0JzK0djbFNVWXBWRnNNSnJSaFczMEJhZTNWc0dCcVVkaHhWSldIR3dRRHE4?=
 =?utf-8?B?TzR5Z0ZEejZZVCtnYXV1ZFlyQ0RuQkM2QVZ1OXpMa3ZOTVI2aWlUZVRmNHNQ?=
 =?utf-8?B?VkhlTGkwYzRiNzJTaFpqNmtYbGE0SHQxYXRuaEdiZzhYTlgyRDFZd2dSZndu?=
 =?utf-8?B?ZjA0VnVEbzB1bjF2dnZaUndqYXNGQ25FOThVQ0w1L1hmam16WVR0VzBERXlo?=
 =?utf-8?B?YVU0RWNqTWdVYUx5enZvMlM1VFVpVHRTa0hoSThSVXc2YzlIMDVOdzJiK0Fq?=
 =?utf-8?B?cmZxOVN4cXFrd2Z4OE5KdG9GbklRaDJsTzkzSFB6bkQ1YU1ZTXc5emNqZ1Ns?=
 =?utf-8?B?bTJYSm5jRzVzdDF0NjBRR1AvUEhOakEzNTRTdGFSQjVQMlk3bVpDbDE5Q3RB?=
 =?utf-8?B?UHZjOERMelFZb3ZrVURHaVlhbDlkSmU5aGUvTVpCeHdEbmpZOXdpL3JScG9B?=
 =?utf-8?B?V1JWNGw2cHIrQ01vYXVQYWRXODAwRVUzWFR1VkxGcER6VVRaakcwazdPdm1W?=
 =?utf-8?B?SzFzaTNmVkpQUkJ0WFYxM1J4Y29pV0lOSEl6NkZGdmpYR2xJZ1cvRm1jL3k1?=
 =?utf-8?B?YjJJOFFMdnJaZU5BbUVMMTRXT0FkblpIMUN2cFhORHRsQlBhc2JaRGxZdTZo?=
 =?utf-8?B?K2VpeHJRaUpKZmJDaFdSWjk3RmtlTE9maE5lbUYwa2E0ODRTTlkvSHRLRHJS?=
 =?utf-8?B?R2krZTBSNUo3MWpJN0dIL3hvd3V2UmR6clBkelg2b25hVEtrNVZ6MXNWa3hr?=
 =?utf-8?B?djBrRXlzSCtPZCtnSTFESWZsRC9iNGs1UFl2M1lXTVNEQ2FRYysyUHh5aHEv?=
 =?utf-8?B?TjlpaTY2Q2FUVjFKeDNFbWJZZXVTblo5VlhLN2dDSFdTQjd3aVorUmNGQ05r?=
 =?utf-8?B?WmozdmlqbFpWYjJ2YTVCeFdZeUEwcVNqa2JDWXlxbE1aamtvOC9kV3pQZDJO?=
 =?utf-8?B?OG5KNjE5UmY3V1p0N0duR01QY3ZiUVNaSWRTQjJmbktGN3lIa2w3TGE4ZUN3?=
 =?utf-8?B?RGJ5MzcxY3FleThDNFVicEs2VXFtMFJsUyt2TU81SDZGNUhiVWo0S1pVUFh5?=
 =?utf-8?B?RGtxM0FxMUJSRU9IdmV6WkxhOFMyRE1obnlEQ1NSSVlQMDRZWXdqWlhuMllW?=
 =?utf-8?B?czBsSEc1RUdjQ2VEdU9PRWN2bkxJSVZqLzQ1eG5jWUNsaVhRdUhhUGRmbERt?=
 =?utf-8?B?dHY1OHIwaGwxaDJWYzB6Yy9OVS8xRUovMGkxaVo5MXd4ZFljdm82ak16TUJE?=
 =?utf-8?B?b0JhTGxJblFMU084VFBuelh3ZUdNUVpERGhDZUZXRkxsR056K2EwYXFnc3pH?=
 =?utf-8?B?dnozOHNoQ1NBQ0tEL2RUVmtVWlNoblZHcGlXQWRaOTRoYmdtOERrT21nZzlF?=
 =?utf-8?B?bkY1OWhBOVU2di9lSHRYbzBRS0dUNEtmTFBzemltWG9XdVNxWGIyWXVJb3h2?=
 =?utf-8?B?VzNLWlFHdDRJTm5hWWxsMVFTbjdZcDF6TStyTkFpNVhKSEFwTGFEMjI0dFpF?=
 =?utf-8?B?TTZIOUk3MFFjSGI5WkQyb0VJZGFaM0Q0aktXaW05eWRZM1lHRnNIZDA0K3RY?=
 =?utf-8?B?QjRMU2NjNkNYVU5sblBsYkVkNWgrNEZSMEZkVEFKZ1hmM1lUYnIybjE3SmpI?=
 =?utf-8?B?V2IwbGYzNEk0T09HUG5aeDNrb3UvUS84cW9MN2dCYzZhaDBDMnZHcFZOVHVQ?=
 =?utf-8?B?cVVmK0grcE5hUndSbDB5ZzEwUyt4c01UenBEc1JGaFYrcUIxb0s2ZzJwcmRj?=
 =?utf-8?B?OTlXdXpOZEtoRGpQeENBRGU3azUwRlY0SEJXTml0TDdURWJLMGNzRDlXejZs?=
 =?utf-8?B?TW9qcmRQaU1zVlpBbTFkTUlpMFJaVkQ2MHZoSnk2ODFuVTBBYUJyQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bd57526-9607-4404-a3a7-08da2693b875
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:15:12.4049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j4VKP+9avErqQrbv41oI85zOJqoXDsD8ohmQGPYi2HLbuXNUNjVao6+7u7CTJFqKIJ5HMCqEHOrMLTBIq+UTrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5187

On 23.04.2022 21:35, Paran Lee wrote:
> It doesn't seem necessary to do that
> duplicate calculation of order shift 2^@order in the loop.

Once again I'm not convinced. As in the other patch the compiler could
do this transformation via its CSE pass if it sees fit.

Also (applicable as well to the other patch) I think "fix" in the
subject is misleading: There's nothing wrong with the original code.

> In addition, I fixed type of total_avail_pages from long
> to unsigned long. because when total_avail_pages static variable
> substitute in functions of page alloc local variable,
> type of local variables is unsigned long.

You've done more changes, some of which are questionable.

> @@ -922,8 +922,9 @@ static struct page_info *alloc_heap_pages(
>      struct domain *d)
>  {
>      nodeid_t node;
> -    unsigned int i, buddy_order, zone, first_dirty;
> -    unsigned long request = 1UL << order;
> +    unsigned int buddy_order, zone, first_dirty;
> +    unsigned int buddy_request;
> +    unsigned long i, request = 1UL << order;

E.g. it's not clear why these both need to be unsigned long when the
largest chunk which can be allocated in one go is 1GiB (MAX_ORDER).
At least on x86 operations on 32-bit quantities are generally
slightly more efficient than such on 64-bit values. If we wanted to
cater for architectures setting MAX_ORDER to 32 or higher, I think
the type used should become a typedef picking "unsigned int" at least
on x86.

> @@ -975,16 +976,17 @@ static struct page_info *alloc_heap_pages(
>      while ( buddy_order != order )
>      {
>          buddy_order--;
> +        buddy_request = 1U << buddy_order;

Such a local variable would better have narrowest possible scope.

> @@ -1490,7 +1493,7 @@ static void free_heap_pages(
>              /* Update predecessor's first_dirty if necessary. */
>              if ( predecessor->u.free.first_dirty == INVALID_DIRTY_IDX &&
>                   pg->u.free.first_dirty != INVALID_DIRTY_IDX )
> -                predecessor->u.free.first_dirty = (1U << order) +
> +                predecessor->u.free.first_dirty = mask +
>                                                    pg->u.free.first_dirty;
>  
>              pg = predecessor;
> @@ -1511,7 +1514,7 @@ static void free_heap_pages(
>              /* Update pg's first_dirty if necessary. */
>              if ( pg->u.free.first_dirty == INVALID_DIRTY_IDX &&
>                   successor->u.free.first_dirty != INVALID_DIRTY_IDX )
> -                pg->u.free.first_dirty = (1U << order) +
> +                pg->u.free.first_dirty = mask +
>                                           successor->u.free.first_dirty;

This re-use of an existing local variable looks reasonable to me.
It would be nice though if the variable's scope was shrunk and its
type was also adjusted to unsigned int.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:21:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:21:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312459.529705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nityR-0002FT-Ry; Mon, 25 Apr 2022 08:21:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312459.529705; Mon, 25 Apr 2022 08:21:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nityR-0002FM-Og; Mon, 25 Apr 2022 08:21:35 +0000
Received: by outflank-mailman (input) for mailman id 312459;
 Mon, 25 Apr 2022 08:21:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WklX=VD=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nityQ-0002FE-Fo
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:21:34 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0606.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::606])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b5f9bca1-c470-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:21:32 +0200 (CEST)
Received: from AS9PR06CA0255.eurprd06.prod.outlook.com (2603:10a6:20b:45f::26)
 by AM4PR08MB2819.eurprd08.prod.outlook.com (2603:10a6:205:a::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.18; Mon, 25 Apr
 2022 08:21:27 +0000
Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45f:cafe::55) by AS9PR06CA0255.outlook.office365.com
 (2603:10a6:20b:45f::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Mon, 25 Apr 2022 08:21:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Mon, 25 Apr 2022 08:21:27 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Mon, 25 Apr 2022 08:21:27 +0000
Received: from 74b00610958b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E25E073C-67C6-4A82-83DC-FA339FAB6299.1; 
 Mon, 25 Apr 2022 08:21:21 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 74b00610958b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 25 Apr 2022 08:21:21 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by DB9PR08MB7422.eurprd08.prod.outlook.com (2603:10a6:10:371::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Mon, 25 Apr
 2022 08:21:08 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:21:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5f9bca1-c470-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LeMk/pZtcVi2z/1bgpqfXlqAMEpb1KOGkd+nuALoPew=;
 b=fQ5Y7mr2EI8CPKa9+AKcskdzB+ZCaJ7+FnoIBL6ogHDtp60AdtqG8dU6+LS8ot65W0v5XEMFT4TRgpcGNqF4mMVtgMbvryuYs96nYsQ7dj2LVXkF1xGUOG5tHMN1daF92s7c9HFtyZX1LCminzg5XBmUvNTDv6tuWGlG4B98CBE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gCqbeOJ1c41m05djo1/Neh/b7TPbri1S1QiCFRJsTX7tpDfG3cIeLPHuYXzODM7l2+xLRcdjdgjS6PBDEoVu6XqHPvFAI9Ws+rmn++9F0ZB9V5q3EpYGNYhGwjBUDUEnkAuY+kaKHZQzttnjNAkd7CgGJryKX2VN70HwtxZ66chis2u7ZAgdLFV8oovo0H49OZArqwyLp0IJR0GpoD9iBpKidNY0FFpLYU7W2605jchgGG9SBpS2CZ4WMrxyVjoPjLo7Um4wKofU9LTrHpuRQ6pvu0V31ZFzNniHNqdCaH41/dLj+qa+aRlHsENwOK9Jfr26lh3BRGbqabFsSDVJjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LeMk/pZtcVi2z/1bgpqfXlqAMEpb1KOGkd+nuALoPew=;
 b=LWqJWX+X6MZO+2FAC4IDLC+SDOm8o7VrElvYDF2jECxeAiod0zlKon/hlhFBpV42hMPIH4Ka9rBX988FWFT7MjJ27Xf5p+y2/VB+k0cqFi1yh/LzEBUJ7ok30SJgzoN1+oAFGrwnuomA/yiwcNd1IEZD1ESAu4UH6ZhBcP6rxVoSg5yAkGU9Ly/sSn7nGToWT6w1oJlbDhw7GkfOmi7RF1m99g3gmAHb5/2++VdodVE+xjPNND/QaJa2UneNKTMK+CvlE+7sH0LVc3tSSoQxMtJZJJUoYy1yhX38w+VRxDwp0nPObBiM3wQopIY/tr5Fn/kHNEXr4/OZYw4C8p9gSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LeMk/pZtcVi2z/1bgpqfXlqAMEpb1KOGkd+nuALoPew=;
 b=fQ5Y7mr2EI8CPKa9+AKcskdzB+ZCaJ7+FnoIBL6ogHDtp60AdtqG8dU6+LS8ot65W0v5XEMFT4TRgpcGNqF4mMVtgMbvryuYs96nYsQ7dj2LVXkF1xGUOG5tHMN1daF92s7c9HFtyZX1LCminzg5XBmUvNTDv6tuWGlG4B98CBE=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Wei
 Liu <wl@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2 5/6] xen/arm: unpopulate memory when domain is static
Thread-Topic: [PATCH v2 5/6] xen/arm: unpopulate memory when domain is static
Thread-Index: AQHYUx8sjuusUaZZhUW8Wxz6RmBB9Kz29IIAgAk/PSCAABseAIAABFLw
Date: Mon, 25 Apr 2022 08:21:08 +0000
Message-ID:
 <DU2PR08MB732526FEFECA658C21ADE984F7F89@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220418122251.3583049-1-Penny.Zheng@arm.com>
 <20220418122251.3583049-6-Penny.Zheng@arm.com>
 <b76b3207-4eb7-5236-6812-d64cd4dad17f@suse.com>
 <DU2PR08MB73253426B332CFF5358AB346F7F89@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <ee51e12b-806f-99a9-b60d-84d6a9a939d6@suse.com>
In-Reply-To: <ee51e12b-806f-99a9-b60d-84d6a9a939d6@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 15262FA90F8CB440A6158530C3E24272.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: c76a1097-829a-4625-8cc5-08da2694981f
x-ms-traffictypediagnostic:
	DB9PR08MB7422:EE_|AM5EUR03FT018:EE_|AM4PR08MB2819:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR08MB281954B8CF24CFE8812E0B4CF7F89@AM4PR08MB2819.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Yz6k380roGPZgKtIZuf1JYhWGHGrc6kbiW/4CfJi742GEaSg7VpFLrfkbIjxo2rKdojjn9BtMK+toEZ+LR/4XEnweMSK/SogtFvtyJn0Go+U3+SSXIKo/Id7jrvnDXyTavlTL5evbPD6EL+Gh6cZAIqU8aBF7x5LTjgGNPgJg1QcRvISiY7cIWXrJ7pPyYM2yBkAinoxZprGNG+/TMzWnoJdEbOODqeHQqw810pcVYxkB1JX8kkN2S/OtMseV89JxKiU3IelAWq7wTDWZ5rvgQuhUs6MuI/A32ccoKVGPzvO8+3FPI4nE5iRIp9adTSHBDJr9dP5yp5InKtudBLl3LLnzsYRSQSoyWuIJ6knZXjFdHNUNG0MJNj8GxxMjUSo6t3+/06TdQOarqeAXfS8EVRJBGAGY7UhHfIDYTDfsIY/ttYbcOXtg14kgiiHFmtwSWQwBV1Ob6i1C/ZXOv8XqcGklrvAaECWmLvMJlLBf/aWsM2beXXJjZifd9Z4sNcdfrP37rY/VpeHj9Ar6Jm1sYug5BbEwl3I9tgj5Y2cMhQGJFvEoJCn+i8YAf4joTAt0W+vCX0TQHS6Amx0h7PmubGdwchtRx//rt2j6NsK/Ol8D1qXJHC7knMjNUFFW5mem3eL0Rt0yXjK++94V9Q4B/UxlbsRPJST+pAqtk/VKq4kTb1fHPdUI8hpvV1N6xHrpSW0vuaz1NXz5c0ZsOoF8w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(52536014)(83380400001)(5660300002)(8936002)(53546011)(76116006)(33656002)(6506007)(66946007)(186003)(66476007)(2906002)(55016003)(66446008)(4326008)(66556008)(64756008)(54906003)(8676002)(6916009)(508600001)(7696005)(71200400001)(316002)(122000001)(38100700002)(38070700005)(9686003)(26005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7422
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	87e52c10-c915-42a6-50ea-08da26948cba
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vxR/p1RF99YQYOB4Blq/qplc6G//YDIPMAzrvA/HwVy3b16jbqLcvHN/7nJeKCGeg+NfYYpejXYluHqriVhbaJNpSARISrKH6DgLwweFVY9/3kY3TO62MyYBBLdoYPqCCPkRTorDXOShfY77IUqlkrgfTNZobfRFTuC+BcIRMEvK0HiX1+O/0LnNuC21n7G47I5sDNjFSUpx9cItSE13cQSJaqKz9NhbcMCgoxlJAff+JRjfXni4nkuUzzLHptRW6WFhArA2B1pkmE+90QeuMENl0XTdPD/XBKP4Zu+skHQbhazPc9DegfbiHaNTTOjaCWgGM4Qkm+/crCnMa+Rj4Ot2t/dt8v9/WLO0RQ3UOubuVnzREn28wZwKJ2BEUJx7rZFAhgnEHggkFyaSaseumGJ0wcB/KzBWr6G1aYlWGHm7MU/+Ux2ZnSG0lbSwVM5q4V+NjQ9+ajnmEPmM1ffRX4YtMQxB+3rcBIP2ohsKN17T9WNb8qSLqKUtzUKJMusDTkUgm61oVuiSySVEXm2gE2Xb/Ps3YPK9tzAXY7yjGj1VnalhfwKyRrDF3q0QfnszTbiCIhrAbaFuAAz3/StU3tYx1Mpa8yJ1AfJsbJijaarRZdyp/6wmUR1a+PFkCDK5upMOAyiRh5ljySRpXcLTxQ90FOrMgeMXPJF2DpXk+r1bAS9Aq7IhmR3tfWq1S89E
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(356005)(81166007)(316002)(9686003)(5660300002)(52536014)(33656002)(186003)(8936002)(54906003)(40460700003)(2906002)(336012)(47076005)(86362001)(26005)(7696005)(36860700001)(55016003)(53546011)(83380400001)(70586007)(70206006)(8676002)(6862004)(82310400005)(4326008)(6506007)(508600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:21:27.4941
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c76a1097-829a-4625-8cc5-08da2694981f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2819

SGksIGphbg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogTW9uZGF5LCBBcHJpbCAyNSwgMjAyMiA0
OjAxIFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IFdl
aSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVs
bGluaUBrZXJuZWwub3JnPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IEJlcnRyYW5k
IE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVr
DQo+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEFuZHJldyBDb29wZXINCj4gPGFuZHJl
dy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJp
eC5jb20+Ow0KPiBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2pl
Y3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgNS82XSB4ZW4vYXJtOiB1bnBvcHVsYXRl
IG1lbW9yeSB3aGVuIGRvbWFpbiBpcw0KPiBzdGF0aWMNCj4gDQo+IE9uIDI1LjA0LjIwMjIgMDg6
MzQsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K
PiA+PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+ID4+IFNlbnQ6IFR1
ZXNkYXksIEFwcmlsIDE5LCAyMDIyIDU6MTEgUE0NCj4gPj4NCj4gPj4gT24gMTguMDQuMjAyMiAx
NDoyMiwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVk
ZS9hc20vbW0uaA0KPiA+Pj4gKysrIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL21tLmgNCj4g
Pj4+IEBAIC0zNTgsNiArMzU4LDIzIEBAIHZvaWQgY2xlYXJfYW5kX2NsZWFuX3BhZ2Uoc3RydWN0
IHBhZ2VfaW5mbw0KPiA+Pj4gKnBhZ2UpOw0KPiA+Pj4NCj4gPj4+ICB1bnNpZ25lZCBpbnQgYXJj
aF9nZXRfZG1hX2JpdHNpemUodm9pZCk7DQo+ID4+Pg0KPiA+Pj4gKy8qDQo+ID4+PiArICogUHV0
IGZyZWUgcGFnZXMgb24gdGhlIHJlc3YgcGFnZSBsaXN0IGFmdGVyIGhhdmluZyB0YWtlbiB0aGVt
DQo+ID4+PiArICogb2ZmIHRoZSAibm9ybWFsIiBwYWdlIGxpc3QsIHdoZW4gcGFnZXMgZnJvbSBz
dGF0aWMgbWVtb3J5ICAqLw0KPiA+Pj4gKyNpZmRlZiBDT05GSUdfU1RBVElDX01FTU9SWQ0KPiA+
Pj4gKyNkZWZpbmUgYXJjaF9mcmVlX2hlYXBfcGFnZShkLCBwZykgeyAgICAgICAgICAgICAgICAg
ICAgXA0KPiA+Pj4gKyAgICBpZiAoIChwZyktPmNvdW50X2luZm8gJiBQR0NfcmVzZXJ2ZWQgKSAg
ICAgICAgICAgICAgXA0KPiA+Pj4gKyAgICB7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgXA0KPiA+Pj4gKyAgICAgICAgcGFnZV9saXN0X2RlbChwZywg
cGFnZV90b19saXN0KGQsIHBnKSk7ICAgICAgICAgXA0KPiA+Pj4gKyAgICAgICAgcGFnZV9saXN0
X2FkZF90YWlsKHBnLCAmKGQpLT5yZXN2X3BhZ2VfbGlzdCk7ICAgXA0KPiA+Pj4gKyAgICAgICAg
KGQpLT5yZXN2X3BhZ2VzKys7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXA0KPiA+Pg0K
PiA+PiBUaGVyZSdzIG5vIGNvbnN1bWVyIG9mIHRoaXMgY291bnRlciwgc28gSSdkIGxpa2UgdG8g
YXNrIHRoYXQgaXQgYmUNCj4gPj4gaW50cm9kdWNlZCBvbmNlIGEgY29uc3VtZXIgYXBwZWFycy4N
Cj4gPj4NCj4gPj4+ICsgICAgfSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIFwNCj4gPj4+ICsgICAgZWxzZSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIFwNCj4gPj4+ICsgICAgICAgIHBhZ2VfbGlzdF9kZWwocGcs
IHBhZ2VfdG9fbGlzdChkLCBwZykpOyAgICAgICAgIFwNCj4gPj4NCj4gPj4gSXMgdGhlcmUgYSBw
YXJ0aWN1bGFyIHJlYXNvbiB0byBoYXZlIHRoaXMgcGFnZV9saXN0X2RlbCgpIHR3aWNlLA0KPiA+
PiBpbnN0ZWFkIG9mIGp1c3Qgb25jZSBhaGVhZCBvZiB0aGUgaWYoKT8NCj4gPj4NCj4gPj4+ICt9
DQo+ID4+DQo+ID4+IEFsc28gdGhpcyBlbnRpcmUgY29uc3RydWN0IHdhbnQgdG8gYmUgYW4gZXhw
cmVzc2lvbiwgbm90IGENCj4gPj4gKGNvbXBvdW5kKSBzdGF0ZW1lbnQuIEFuZCBpdCBwcm9iYWJs
eSB3b3VsZCBiZXR0ZXIgZXZhbHVhdGUgaXRzDQo+ID4+IHBhcmFtZXRlcnMganVzdCBvbmNlLg0K
PiA+Pg0KPiA+DQo+ID4gI2RlZmluZSBhcmNoX2ZyZWVfaGVhcF9wYWdlKGQsIHBnKSB7ICAgICAg
ICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICBwYWdlX2xpc3RfZGVsKHBnLCBwYWdlX3RvX2xp
c3QoZCwgcGcpKTsgICAgICAgICAgICAgXA0KPiA+ICAgICAgICAgaWYgKCAocGcpLT5jb3VudF9p
bmZvICYgUEdDX3Jlc2VydmVkICkgICAgICAgICAgICAgIFwNCj4gPiAgICAgICAgICAgICAgcGFn
ZV9saXN0X2FkZF90YWlsKHBnLCAmKGQpLT5yZXN2X3BhZ2VfbGlzdCk7ICAgXA0KPiA+IH0NCj4g
Pg0KPiA+IEknbSB0cnlpbmcgdG8gcmVmaW5lIHRoZSBhcmNoX2ZyZWVfaGVhcF9wYWdlKCkgaGVy
ZSwgYnV0IEknbSBhIGJpdA0KPiA+IGNvbmZ1c2VkIGFib3V0IHRvIGxldCBpdCBiZSBhbiBleHBy
ZXNzaW9uLCBub3QgYSBjb21wb3VuZCBzdGF0ZW1lbnQuDQo+ID4gRG8geW91IG1lYW4gdGhhdCB5
b3UgcHJlZmVyIHRvIGxldCB0aGUgaWYtY2xhdXNlIG91dCBvZiB0aGUNCj4gYXJjaF9mcmVlX2hl
YXBfcGFnZSgpPw0KPiANCj4gTm8uIFlvdSB3YW50IHRvIHB1dCBwYXJlbnRoZXNlcyBhcm91bmQg
dGhlIGJyYWNlcywgdXNpbmcgYSBnY2MgZXh0ZW5zaW9uIHdlDQo+IG1ha2UgZXh0ZW5zaXZlIHVz
ZSBvZiB0aHJvdWdob3V0IHRoZSBjb2RlIGJhc2UuDQo+IA0KDQpPaCwgb2gsIHRoYW5rcyENCnB1
dCBwYXJlbnRoZXNlcyBhcm91bmQgdGhlIGJyYWNlcywgdGhlbiB0aGF0J3Mgd2hhdCB5b3Ugc2Fp
ZCBhYm91dCBtYWtlIGl0IA0KYmUgYW4gZXhwcmVzc2lvbg0KDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:29:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:29:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312473.529715 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niu5m-00035v-LM; Mon, 25 Apr 2022 08:29:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312473.529715; Mon, 25 Apr 2022 08:29:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niu5m-00035o-IW; Mon, 25 Apr 2022 08:29:10 +0000
Received: by outflank-mailman (input) for mailman id 312473;
 Mon, 25 Apr 2022 08:29:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niu5k-00035c-U5
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:29:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c601b801-c471-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:29:07 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-bP04QAlhOe2EQBEyjg18Sw-1; Mon, 25 Apr 2022 10:29:06 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8021.eurprd04.prod.outlook.com (2603:10a6:20b:2a7::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:29:05 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:29:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c601b801-c471-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875347;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=z2vjN2m0sI6wewrZIc2Vi6egwfUpSl6a+CXzDwfH8Gw=;
	b=GxkvIsUceHG27uIN9xHSJ1nvLyPgA6xPsCRC5oG9YS460uVytg5n5C/ebYOGW9NWjAkNOu
	DFOxAunrvmdmEeIyu4rk9fbS5j/Zi2XlX8DfWxP9U0mFWHESH7oCgKJH6i6/BCSOOI3Ohm
	JKHdxEDF/FBMKzuetbRrrNYRmjj4k2E=
X-MC-Unique: bP04QAlhOe2EQBEyjg18Sw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dP26ePVuI4cf7E0NzvLGRferT3clbTpXCcv50tYVj8WQ0Nox39i1BDsCwydx78VmHAiJ2XRAUlX4R48Bo4NuGiLbR1Tpc5e7FAd8XdYlnIwTVMWdB/sNDr5DJGyJnBIys6I2cx2+F3BwCzreeEa1yMzV/adgyXEk2buakLJ4KzyHTMVhinbYVJgWSgblEznPQEoHJ+aZyAgtoL/e7ZoatN2Oxx27N+xLhUL7aPalnzq6snTLLPueh7Wj1H8mtKrKPjLIPRP+55zDR51nqfdQcDLfD9WZteIVgZcq+YpjQEqX6TX9V1g2ha5OKuU5lYdlaDvTZZFYvl8hxthkTXa8eQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z2vjN2m0sI6wewrZIc2Vi6egwfUpSl6a+CXzDwfH8Gw=;
 b=PzQ/mVeIuPdqkzNgGvn4lGIaYgooSFZPL8KWTRY50q8PSbfIP6A+xT3roz7CMt0tgq9tT4eyOWaSbSJJLAnmYpb/E3Ft5jLTpP1VMHHbLnCEf/ZBZKv2YC9+Q2dPxg9Xs9SAQm8BhU6977G6RWJtLqv0BNlGrmywJs8GSTLzhyGGmdAm2nzEqJ2CyddwC6ATuUYnykxxhbynzsuFfZS3ST5wGzhqVdSeAldhvO4bWuHzgEYQQjkb0xqvkMucdNdT9k0dex7WcwCnAajlHjd+gLoPYjUluq3iswJzJARzB/T+ZtRadh2cPU0D3/V8cHPzsP8NLBG2uVOeAwn+2fc9SA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Date: Mon, 25 Apr 2022 10:29:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v4 00/21] IOMMU: superpage support when not sharing pagetables
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM9P250CA0004.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:21c::9) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a0478d19-7f98-47b3-3847-08da2695a8b6
X-MS-TrafficTypeDiagnostic: AS8PR04MB8021:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8021F8E74F509D5661D7534EB3F89@AS8PR04MB8021.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ftvH1B7vyWQtJ1pOXUwhpmWsQdV94gbLm7U+3VkWOsdtaqE9DCZEaCxWiljgLvOrT8czBGALjum7rR2Bw1oLsOIF5DzF9PJXufAMjssYigs3zjbNOVEMb+JJ97OqASifur/xCt4KLddVRb41qsPC0mLcvLYhLpS3apbAqWpClV5ELS4n/rFhTTPHQmgdkaGGGExu0ho0a0lynYCNY59CgrPLiI8egg7REG1UKSggUjGHpA0B5kwEsupXs5TrpHSYMkODphtYFpfYy2FEsywgRrs0HhX8dWgDcb8ApUU7ZIVjdH80qeARbeSD1Jk2qQlfHb9f1aPFWjLp8lndiN6fSRqjwGJ82gbNBoMJ2LMFIRR54zhxJUN7AkcWPr91kLM3MfZIeJiP8axwnZu9aMnGiJIvOjY/Ex+OiOIBzmeYcNzbG72HdJHj8g06AjTpOmNKwaQU++5p2EJoWToIWRixOWw6Zkz70lyAkhjkBU89+SyseNkvHAMQt0X4WyrE56q3vquHBz7xd4ha4JhAlsaKno2w/D4Q3d6WKwu+mXDNbxnkcP7ztq3MrLAnSUm1jzi8TtV9lFipcld2hW7ck5cJ4p/QWfUHC5W57AsqDjestPtYUCKTgzenfB9yJyUQHStIdUYPli8E6/anT3K80OSHMUsfxKE9y7FtvHbQZyRby2wFn/9kJIXRHV6AI0upyKFSy/U1u6Sb3e7Xo6Mtz4jV1OLreHAPIpfDSbgm15sr9lVkNjQ2d/aIdK4MPBNqtyY6D9qpL602FcvkzOa2qXCqVPHS1r7llrXkcwJmFOa8745w+4WniyygZoENvFAcIOe0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(966005)(6486002)(66476007)(4326008)(2906002)(31686004)(8676002)(5660300002)(508600001)(2616005)(186003)(83380400001)(38100700002)(26005)(86362001)(8936002)(6506007)(66946007)(6916009)(316002)(66556008)(31696002)(54906003)(36756003)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a1ZjSzhHM2hncjhrTkJMVCtSSGlISXhITmhZRmM1b2s4ZjEvMDQ5QjU3bHps?=
 =?utf-8?B?M0l0ZmlZcnExMldxYjdodFZ3NHUwZkpXeGszaDJ0RmRKU1d6MzJvcmdqdTE5?=
 =?utf-8?B?dStwMnBjS0JPdTd5QXFVVUxoaFErbXFqZ29BaTd6T1dBenZ0QTM1TlpHZi9I?=
 =?utf-8?B?U2lYWnR6YVlucytpWWdjNDlwT1dIT2xxVnpWWEJKOVNId3Q2N1N3bWpFSTFG?=
 =?utf-8?B?aFEyOG1LZHltc2o5UnFuWU5GZjNrYmRUZkw5b1JiVVhIMlFyVWhHcHd4aVZi?=
 =?utf-8?B?UGMzQU95MlBFenhLa0JQVnZqb2p2ejMyamtweU1YdmgzU0JWUnYxdkpERDRK?=
 =?utf-8?B?d0lWK0N6RExNQytwdDVpZXpJRjlEODFpQmNBYWlXckRlNVVpcCtvaHBPamhr?=
 =?utf-8?B?R2hub1g2aWQ5UzRhQzYwZVJac3lEc2lUaUlwNTk1OUF0UzVjVVJ1dkhKem5i?=
 =?utf-8?B?Nk9jSlpxWkllZXZNQW9uNkd6ZTdRb3JrTDZORXBNcVBMNTBHSE00Zyt3WE9O?=
 =?utf-8?B?RWF1MWxFZmlFRFA3MWlFeEFrNHphZWFkUzVDTC9aL2s1Rnc5OUFIdkh2RGNM?=
 =?utf-8?B?THNZdEI1VmhtKzYzLzB0OUlkM01ybUc1bnJyZ2lJWnJjQzkxeTJueGNyc3BZ?=
 =?utf-8?B?a1lrd09xallSUlpCUHhVdjdsRC9pWEJnSkJDbmc4cll3Y01aQjNhajlkallu?=
 =?utf-8?B?cWZveHVzeXFqOFcxQVdic3JBQUVpRG5TSHp2KzdsL3VRUkJXV2hYU2ZoT1lZ?=
 =?utf-8?B?a2FBODViVDZVbHU2alZMeE5aL0JuSXRyejVzc0ZFaFk3NklwZml4djg3aVlZ?=
 =?utf-8?B?YjZwclNoaDM0Qk1qdEpFdlptTW9qUkp1enMrL2JZeDMvRUR0K09FbTdsVVR5?=
 =?utf-8?B?allSMGdNVkFXSEFxWEp4T3NsUC9oNlpwdVlVMmcxZHJ5U0ZRTDhzTnNSSFln?=
 =?utf-8?B?YjV5Rzh5QUJ0Y0JSSGtxQlN5ajlTNzlCQnZCV29kWkNyNi9OZlhxRE43dFpK?=
 =?utf-8?B?ZU9uMmlYOFd0TnBZbi9FTTF6a2x2d0c4S3BZdlFhemN0QWhXV3g1Q0k0cmtH?=
 =?utf-8?B?SjRLejg3TCtnREwzMXVROVJLeG56aDNIck9GcHMzZk9yYmZ4bGJlWmlJUnM3?=
 =?utf-8?B?T0cySnFSV3RBTnlUN2dqSHIyMThpdjRHOXlvdS9sVFJlZ3hoRFRXU25MZ0ZB?=
 =?utf-8?B?VG5DK1hkaC9zVUkxU2ZESkJCejJMM3VIZDYvV0YxQm12cExDZEw5dGcwanpo?=
 =?utf-8?B?N0NsNlU3VUxSMHFLZjZ4REtOZ0IvMDZiTXFrVXFOZHN2bnQ4aUZNVlUyd0sy?=
 =?utf-8?B?cTI0QStkTzB3QkU0VFIxak5qZmYrck1MeXZjNVJpaVkzQ2s3VzFQbTZ6VFZr?=
 =?utf-8?B?eFdURzY1L3NnWU1oSnFpcU12L0JGY0pNMFU4eGNPc1MvUjFlbURqWEdTYTBB?=
 =?utf-8?B?UldZK1FKOWd0SSsyRm1DaXJwQjI2WFprVnJUL3F1S2d3b3hZZTJzSjRob1VB?=
 =?utf-8?B?a1ZyTUt0ZDdLaU41MFBOREFFY2JUVlowbTdhbjNqQUsybWxKNUMzajZ0UmxL?=
 =?utf-8?B?ZGRKdngxMEZLTG9xc0lCNVlzN1BXcUZKanFBZ0s0dnpjT3U4ZHVIRnN4OFZh?=
 =?utf-8?B?TzFyTFdXODN5TE1VOGJKUjI5Nkg3MHhvUkFnVThzOE9YRXArMFM0Y1VaNnpG?=
 =?utf-8?B?dlMvY01jeE95NlBRVEpsa1dSTk1TaCtKekJKMFVQMHFZQ3Z3Z3hGYmEyYWpI?=
 =?utf-8?B?TlRBMUUwWnV2VlNReGV1SzZPVGw5TUdMUC9BVkJ1SjZUTkVzZzNXUDBPcXhw?=
 =?utf-8?B?TlNPS1psUmFqaDRwb1ZoUEt4b2NDQ3gwdVlscjQwQlFuTEp4bXpMaStRL1JP?=
 =?utf-8?B?c0pQOEZ2anErUVVmSVpqME1pdEhtbXM0dG1CaGlHSmVWT0txRjFQMEdPMVZ1?=
 =?utf-8?B?Z3QwN2tsbHQ1RHdqc01ZMEFWYkdBUkgzVjJDcmpUKzNtMnZVazEvQVNlMEE1?=
 =?utf-8?B?SzNxcU9lTW13UFppQjFvN290a2Q2emd1RFZ6ZU05QklIVWZ6OWx5WlJwNzJP?=
 =?utf-8?B?S2JNUFpKYTd6dGs4OHdYaW5taUJON3h4T25ZQy9UakFMeEJBc2taKzVDVXVK?=
 =?utf-8?B?SGJTNDFVU1FvSVVtMHQrekdkS3RNZHI3cElwN2hPMmhlTGlmd0JCQXNYcGgw?=
 =?utf-8?B?VElYZGJZNUFKV3ovTTFzeHVYa2RoODJSNmRqbnRXNXlqZmhTNEgzbmNpUHIy?=
 =?utf-8?B?Z3QvWTE1RXdKZXBTMmRGT3FqeEJ0MjJ6VE1ETkRrM2w4a0xzdDVJTDFOaHQ0?=
 =?utf-8?B?aUlTeUNLS3RCMEtNQWZVUlZiWjdMMDhMVGxIdlRERVJJQW5YaWY2UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0478d19-7f98-47b3-3847-08da2695a8b6
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:29:05.0249
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wiClTMN3XfXlIAmcWo5dB/Cr6/ET1LEY0CgJ+o3owA0O5RiaZUsJqmGVALtWTW2WShlCOOw2YVVEu1l8nLUbEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8021

For a long time we've been rather inefficient with IOMMU page table
management when not sharing page tables, i.e. in particular for PV (and
further specifically also for PV Dom0) and AMD (where nowadays we never
share page tables). While up to about 2.5 years ago AMD code had logic
to un-shatter page mappings, that logic was ripped out for being buggy
(XSA-275 plus follow-on).

This series enables use of large pages in AMD and Intel (VT-d) code;
Arm is presently not in need of any enabling as pagetables are always
shared there. It also augments PV Dom0 creation with suitable explicit
IOMMU mapping calls to facilitate use of large pages there. Depending
on the amount of memory handed to Dom0 this improves booting time
(latency until Dom0 actually starts) quite a bit; subsequent shattering
of some of the large pages may of course consume some of the saved time.

Known fallout has been spelled out here:
https://lists.xen.org/archives/html/xen-devel/2021-08/msg00781.html

There's a dependency on 'PCI: replace "secondary" flavors of
PCI_{DEVFN,BDF,SBDF}()', in particular by patch 8. Its prereq patch
still lacks an Arm ack, so it couldn't go in yet.

I'm inclined to say "of course" there are also a few seemingly unrelated
changes included here, which I just came to consider necessary or at
least desirable (in part for having been in need of adjustment for a
long time) along the way. Some of these changes are likely independent
of the bulk of the work here, and hence may be fine to go in ahead of
earlier patches.

See individual patches for details on the v4 changes.

01: AMD/IOMMU: correct potentially-UB shifts
02: IOMMU: simplify unmap-on-error in iommu_map()
03: IOMMU: add order parameter to ->{,un}map_page() hooks
04: IOMMU: have iommu_{,un}map() split requests into largest possible chunks
05: IOMMU/x86: restrict IO-APIC mappings for PV Dom0
06: IOMMU/x86: perform PV Dom0 mappings in batches
07: IOMMU/x86: support freeing of pagetables
08: AMD/IOMMU: walk trees upon page fault
09: AMD/IOMMU: return old PTE from {set,clear}_iommu_pte_present()
10: AMD/IOMMU: allow use of superpage mappings
11: VT-d: allow use of superpage mappings
12: IOMMU: fold flush-all hook into "flush one"
13: IOMMU/x86: prefill newly allocate page tables
14: x86: introduce helper for recording degree of contiguity in page tables
15: AMD/IOMMU: free all-empty page tables
16: VT-d: free all-empty page tables
17: AMD/IOMMU: replace all-contiguous page tables by superpage mappings
18: VT-d: replace all-contiguous page tables by superpage mappings
19: IOMMU/x86: add perf counters for page table splitting / coalescing
20: VT-d: fold iommu_flush_iotlb{,_pages}()
21: VT-d: fold dma_pte_clear_one() into its only caller

While not directly related (except that making this mode work properly
here was a fair part of the overall work), at this occasion I'd also
like to renew my proposal to make "iommu=dom0-strict" the default going
forward. It already is not only the default, but the only possible mode
for PVH Dom0.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:30:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:30:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312479.529727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niu7E-0004TX-4v; Mon, 25 Apr 2022 08:30:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312479.529727; Mon, 25 Apr 2022 08:30:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niu7E-0004TQ-1Z; Mon, 25 Apr 2022 08:30:40 +0000
Received: by outflank-mailman (input) for mailman id 312479;
 Mon, 25 Apr 2022 08:30:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niu7C-0004TG-3k
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:30:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb625731-c471-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:30:37 +0200 (CEST)
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03lp2172.outbound.protection.outlook.com [104.47.51.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-N9J2nGXnOXyZKBl-HY7EaA-1; Mon, 25 Apr 2022 10:30:34 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0402MB3355.eurprd04.prod.outlook.com (2603:10a6:7:81::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:30:32 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:30:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb625731-c471-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875436;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=auT+iHb+14B5DSUBAnnO1f63YotPDBxUCIQdd1daVCQ=;
	b=BvnAvvdXorHlNXPqO0Gcc33yToHVkXVD9ADZ1+dAoErPIiy0kgh4qaF6Pvv4cKe1AkPxD5
	s0LteGnF6Rz9XMXdJEo8Wn35D0Z0Kt9jOLgzBHvAD046FMrq9Px6Cd5Qiyi2pkFc1qEs+A
	fX3QpQfg75zJaFjnZ/J1sjPtou8GSUQ=
X-MC-Unique: N9J2nGXnOXyZKBl-HY7EaA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W8ISYQKoqRhrdnvlD6ztHf03SR2TYQaYd+zN3O+7vR9MdyJem5BOf1Rs1E/TGlgk1lZP2GRjarvkPA6jkanIY0taYYaJ1/+Cscd74mHyFfmGagSa1RW0Ert//Sajd+RidRoshl326qo2gpBl4Fz+5+OjTfastat8aEniOCC/XcVbC7otQEl7KsFlKqyKuV45GpfT4d+BBeZgtpA//2pBAZu9RZXA3ZbslzamTdIrH0KSutMBjkbsyn0eqy4shhBW4Y0FLq24M/v26WGRcomsHzOCxenGvoH0MZQtYOL23MLYjhZL9RhsWB/mAJ5ueMCF9mkt8qP2XzYvJBsND1Me9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=auT+iHb+14B5DSUBAnnO1f63YotPDBxUCIQdd1daVCQ=;
 b=KwUE1AYIyP3gjap9B32YKMnqeHp4fny8SovKioxF06tJnxP+yJpcwcM9BTJgDVOhPEqWkKz8wp/93BwT7a04GiJF5oyME0JZWwnyEVUa/uNnW2A5tFLWK86Ls52E5bRInJRLtYgHJoxGxMRzv1ed9u5721knwVbbkAEZISYti1LQ3PqS7zmU9v9bEwu1+Vn0Ek5o9hsRfB/ZS27t3L9KSeYnJHmJ6Lsf3h8nSVCR8NBtCAOi/ad9mOQHPUpy01MtWjmtNbxKO/vrDdUI58D5azA7/Y33zOfOYtVO3AS+f2OLXw9FNM4sH98YyWuOCSki6j3jyIP54XSXw7fXfeaoIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0dec8285-a348-53d4-f9fa-552c7c1c405f@suse.com>
Date: Mon, 25 Apr 2022 10:30:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 01/21] AMD/IOMMU: correct potentially-UB shifts
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0252.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::27) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dd287a59-cfb3-406b-7fdf-08da2695dd0f
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3355:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB3355983C97EC3A127EF9A787B3F89@HE1PR0402MB3355.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aOZWqanjAFeSC14fiTf50/yViFalVpIbBgHXbPsvM7nQzrhMUX/ZMAOuU6ZHQ6IeCYO7sULvQrind2+zUZbbGVuUuEYp8VsxI2vI2qdfMA9x8RsRoljtchGhA2wPct5DfnALbruhBctpkmRBXkSVgrkN8lfc+8MRSwwz8fm5Mi5VxyBfrScSL3LvhBFSBAaPfYPvM7Seuc1JS6L6P0gu3UEF5wV3h9UIz2bNX6v9HO3P2WI0mc3knJylHDNePRKubuA4IRN65UW0HlDb8a+gv9WJboplD0BfF8Q7Su8LRcbAy9L0I0Fh6O9kpYNC5bTHu1FKylsaV5TmelCE0L5umW4HUQUfzfeG89Km9ZtiDGx2zUmsgAOFLDZHRJchpn7PeY1OKSJt5W5K3nV3xkXiPK1JXM1wSTUCtMh79lF2O9Eb2GemuK1HEJ2ftmpUCnnuAg35MVUec6mw04P/Xgary5D9PFts9aYadU6t5wa1cFNQCERTFL70/hXApU3P7RpT9xJVe5QyaPBceY1nShmi93w2h2var0j2bOYbNuZ/u8RcL9g9eKhpgR6iEzmSaLsYiJhrGDD/Stmx09Pxz634W16i+c4nKCXiLL3f7TfFtCMBbzc7FgOlO6YlxPVUQ9kUKC3HQOPxw/iFDacZalGs+3Ets9zJZoxB8QbmxFKwcQGzd3PQd4g2GdYtxyL0NzkzrkBJXr1hPXbrEh61uAbiXBYvW7Xepzwh0obJ+EOG0UXIc1PpI3GZbuo3u2sjjlx9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(86362001)(6512007)(6506007)(31686004)(26005)(2616005)(186003)(31696002)(8936002)(4326008)(66476007)(66556008)(8676002)(38100700002)(5660300002)(2906002)(66946007)(36756003)(6486002)(508600001)(316002)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d2dZaXpsQkRwOUhhVVVIUkwzTXh5bVd6RSsrVWZ5L2hDNUU5Yml6bm9SQzVF?=
 =?utf-8?B?VjZhWmdMUXRITE5HblRaVXRGcTNZVlpHN2dlNFZWVlBYZGVwRm5SUUxzNktl?=
 =?utf-8?B?Sng0bk9RV0J5dVhRM2I5OHJXTVhsU0YvVUp2aXNjanl3VVJYMm1tUEw2b0E1?=
 =?utf-8?B?VG45UkZ6ejV1ODloaERPb3J1Ukdsdlo4V3dWMnpTUUF4SkY2SFJqSmdaRC9l?=
 =?utf-8?B?bEtpMi9McHJTSkdkcldUT0pDeVYrRlh3Y09LNWlLeGRwVng1M1FiVXBZYUMy?=
 =?utf-8?B?bDZGR3Z1aVNlVnUxekJyamNwSzRGTnhYa3g1bFY1b25md3VwZmRBMXg2U211?=
 =?utf-8?B?alRrRDg3dFYrTlJFYXRER0lNcE9PL2hHY25JY1BUMnJ0dU9LNS95eFJKMjhK?=
 =?utf-8?B?WHZyYWpEZDBxWHdVeFdsNldwbUR2OExPNXArMnBCWC9CVWFzL0VFRFNxTXJE?=
 =?utf-8?B?VkVhN0dXbThQYkU3emhtaTNrSjhqMmk2d3JiYkp6RExZNEpISFZlUG56NWJV?=
 =?utf-8?B?NHRJUDU0Rkg2Rmdhb28xRUQ2WldMQzdwejJ1cVIwTSs1d3VzTGhxWkRycnpz?=
 =?utf-8?B?UVNxenFvRVVTZHdRb05ocTRkWUVhM2d0eWRGR0hBVzJqckp5UUhJQXZYSkZi?=
 =?utf-8?B?NjVNbnowcmtSTnFlU2FWMVVYV0FMWEptRlZOU25pQzQveTJTNGJxd0RzZTM4?=
 =?utf-8?B?d1VKRVRsR3pXcjYvK3ZjWFBIMzErTXJYLzhNem9ob2ZGR2N2V090SVFOU2lM?=
 =?utf-8?B?R1BJaFlGZXpHSVVZakRFYjNTdDNyOFpBZkZCRk1kS3M4TGY4ekNZbVhLZkdR?=
 =?utf-8?B?VzY3OFZlcUdZdG0reDRKemg4UDRTbk0zaSsxYmxGUkJpRVlvbXdYTUV5L24w?=
 =?utf-8?B?WU9scGYyd3ZGWTB3aUJ3RTZUQTNNL0hlQVE0MG5ZZmxkVkxxQzA5S3pEOWdr?=
 =?utf-8?B?cVkxenU5MXBnQ2FTcW9nSmEwK2tMa0txVEFMMkFUb0hMa3dnZkNlYnl3b1Ju?=
 =?utf-8?B?bUFZZlZpdGNWNFJ4VUx3SGRtUjVIQWt4bDAvczJyR3BuTytuc2tYeVkrT1My?=
 =?utf-8?B?Vk45b2t2eXU3ZmtZWTlmZUt0ME55R3phYmxnTlI2WmFNOExLdFJqSWJ0clNS?=
 =?utf-8?B?TDhSRFlVNmdqdWY0SXFQMVpCWTFLOWpLSlRhekRhVnVrOG1GU0ZHRjdxQlVH?=
 =?utf-8?B?ejErTG5yZnpyOXhRL3JNakpNSFluK0JyOTh1U21BY0E4SUN3MXI5VUhmUW9n?=
 =?utf-8?B?eVFHOGJ4R2c2aFdnbForN2p6eE9Nc3B1dWtlMWE0eUVXRlhvRS9kZ2dTSFVS?=
 =?utf-8?B?YysrWEFkRVFTdW51bEVHdHlLS21iOHpPaC9Yb0xGQUduQ1puZ0pSRm5ycFVu?=
 =?utf-8?B?MXZqbzJSdWxmNTVEbjBCcnVwamdHVHBZU2lkWkEzelUwdnFmMUhsMHdYR09j?=
 =?utf-8?B?VnRwR09FVFdwMk1OMW43YnZYUDJnRHVWTElWck42bGdsVXhkOHJEY3Z3S21t?=
 =?utf-8?B?QnNpeGFhWmQvYUxNcXpOeGlsNEN0VnIyVjNFTG9TOXdZZkJkajdIVkVHWUJE?=
 =?utf-8?B?VzFDRVE1ZEt4YjZQNEpkZlZ5UkF1Y05UK0tQRmdadG5MU0lwMkhJVWtYRkVD?=
 =?utf-8?B?NldUMXliRG80WXRJek5rZE82dENyMm9CdGhRRjdITG9aSlUwM3pyR1lFWFpj?=
 =?utf-8?B?eW0ydXMrTzRNR29rWnlmaDBDcFdkZ0dxSUJOcXVobGxpQitFWW40eE9sUUt0?=
 =?utf-8?B?aHJzOUdHSlV3WFQvc1JqSDRSaDlpUTBYR25rNzlDcTgrYlZzTFo5NzFKSUdI?=
 =?utf-8?B?VFZUL1k4enZkS1RoT3N6ZHRvKytURjFoQVd0QlFvdVErOWNYL1dTWXo4dVFS?=
 =?utf-8?B?OWpyWW4vdXpCWC9WdSs1aDhmZ09aM1h5Q1Q0L1FWLzBkWjl4TFRvYWpud0hy?=
 =?utf-8?B?eUZhK2lIWUU3Y2U3RVNmMVplYjhoK0wxSkxmTElBSGZ0VzhBT1hrTERybExy?=
 =?utf-8?B?bys1OWpYeXY4bktKeXc4R3lDTGlZNDMxNlBRMXYxMFdwRzJSTEozWlJhQ0tK?=
 =?utf-8?B?QmNDQ0hnU2pGQkxia281a3dyZ1JHc0hia3VsV2kwdWZBWHB1OFBTaFBzNmg0?=
 =?utf-8?B?ZUQzeS94TWV6QVA5cHNRaTZFZ1FNazYrSVhudXVMdk1MdEFvVCt3L2NBbS85?=
 =?utf-8?B?aEdJRkZRSzgvM1BpUU04NlNEWnFEaENiaXRheWE0bHJ4NWZmWlgxYThDdEIw?=
 =?utf-8?B?ejh6aDVWS2t2Q0Faa1ljVkZDSXJnSmpTS21FMTIrV0xjV1hzT1NHbnMwU3JU?=
 =?utf-8?B?ckdpeGxLZU1aOGNFbXNRWnhRNDBxckFFeE80dExrUnl1NDN6elcwUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd287a59-cfb3-406b-7fdf-08da2695dd0f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:30:32.8515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VIn1ipyJvC2Y/8mYpU9Fr/M1q1bw54pS1X6NgB2IkGWSeJRjW1BJpDvWCjFo95jkY2dLtPF2LH2sBzmHYKT4Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3355

Recent changes (likely 5fafa6cf529a ["AMD/IOMMU: have callers specify
the target level for page table walks"]) have made Coverity notice a
shift count in iommu_pde_from_dfn() which might in theory grow too
large. While this isn't a problem in practice, address the concern
nevertheless to not leave dangling breakage in case very large
superpages would be enabled at some point.

Coverity ID: 1504264

While there also address a similar issue in set_iommu_ptes_present().
It's not clear to me why Coverity hasn't spotted that one.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v4: New.

--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -89,11 +89,11 @@ static unsigned int set_iommu_ptes_prese
                                            bool iw, bool ir)
 {
     union amd_iommu_pte *table, *pde;
-    unsigned int page_sz, flush_flags = 0;
+    unsigned long page_sz = 1UL << (PTE_PER_TABLE_SHIFT * (pde_level - 1));
+    unsigned int flush_flags = 0;
 
     table = map_domain_page(_mfn(pt_mfn));
     pde = &table[pfn_to_pde_idx(dfn, pde_level)];
-    page_sz = 1U << (PTE_PER_TABLE_SHIFT * (pde_level - 1));
 
     if ( (void *)(pde + nr_ptes) > (void *)table + PAGE_SIZE )
     {
@@ -281,7 +281,7 @@ static int iommu_pde_from_dfn(struct dom
         {
             unsigned long mfn, pfn;
 
-            pfn =  dfn & ~((1 << (PTE_PER_TABLE_SHIFT * next_level)) - 1);
+            pfn = dfn & ~((1UL << (PTE_PER_TABLE_SHIFT * next_level)) - 1);
             mfn = next_table_mfn;
 
             /* allocate lower level page table */



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:32:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:32:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312491.529742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niu8l-0005Kd-If; Mon, 25 Apr 2022 08:32:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312491.529742; Mon, 25 Apr 2022 08:32:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niu8l-0005KW-Eb; Mon, 25 Apr 2022 08:32:15 +0000
Received: by outflank-mailman (input) for mailman id 312491;
 Mon, 25 Apr 2022 08:32:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niu8j-0005KM-OR
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:32:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 34642581-c472-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:32:12 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-oUMUKYlAMVa2Yg-nFT7akw-1; Mon, 25 Apr 2022 10:32:11 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0402MB2923.eurprd04.prod.outlook.com (2603:10a6:3:da::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:32:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:32:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34642581-c472-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875532;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/iXrr5wbNhiSfeRN5CafS9CPFmFmiZ1NrYkK3k2eoBc=;
	b=OrXI8RrCgJYu0U36MH1G3nbd00GCoYsXRFNdWVCyKqlDLAWjZ2v/rYKAtPzu2GVqyJ3QYv
	ISeEhvBFztkrr/AhUWx16Ejg2Hyfoeadr+tjP3V8ajKtXsbgce/Q261GeqpYP0aiLx/MnK
	b7Nv+wq+BjkpArljAeWXp2ycfRRR6Rg=
X-MC-Unique: oUMUKYlAMVa2Yg-nFT7akw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JHI0KfcCU2uigwWDWFkCx6UQb18qfCQvO4Xtbxp02SKFpdwTu8bwWyGGuWZqshO0KX31eFKZ2n4ZifoUlYNNTTlY65ffS4ZS2QSK49+3R/IRuX1I12hgNnlr4O5jcC5gtglVAqdb/ZhxNJO5n+TDxsc3FWu9lAFhIvQae2tsWgkGgrU5jx40LMxAnK4wifPHdU/GICO6wX6NB7hTYDeZPHguap0WLuKxDl1a56GFcwZGIlPkN4cnmED3QllQuQVlor1tfsaRfvgu4XcRhGGEMO8/osZr8Y4PgSa9t4RRC+uM3IOfsnMkVhg6my/A+wAjVMnsAd9WqHG9OJi3wNyjHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rjdSQtedmMFCh8llXOYSf/g3U8VFnBdTE7dsIXoukzk=;
 b=WsFxqEPx2zlx2PsD33HJ1WnxZ2pguQ9u43ppwthKVBozbTx/1oioyitOrsQ1m76GmqlZvBpXSA9uAMtxVtEUTXLeaEIqr+xiFiMeJFeRbZvmeoFF39+hu4GH3vx52/h/QXwZ1CLcDWmWhen1+sTcCuS2DEdW5kHG4ifLnQP75WQ5nuC2dAf2OXKUZ4/4scDVnexkRFkl+UYNsnxhKmG5P+cKhvSzgwH9BcA0SygWVTqRkS3/7p+Xg7LCudqG/HkbCd2YrRiHKo5XfRutP/SP4sIEKxy9mXcUeOmgsLmTPpRCWYhwMJmRBenX88w32HKh4/65BKytgtP4qwkrPSEP6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cc4323b2-e074-f86f-eea0-9cd6a802bed8@suse.com>
Date: Mon, 25 Apr 2022 10:32:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0330.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::9) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bab5479d-ae76-4ef6-773d-08da269616bd
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2923:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB2923FAF86F9E84389C8CBE7CB3F89@HE1PR0402MB2923.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4plGuojbvHRApdQtJBz5lbEa4KFSgYrAfWdhtKGjJzcLRz0T2jqpuT6+2YD+LiLN+70FjKx85i4q7NOy1P3/BjRQyw5zjA2E1GJXZtDLvSAgIYuXWIOr7GdVK3nUMe6grWwRaO/cpI4LkYVFFHiLNrGp9r49iTQEWnj6RaiE8KQ8dPZAopM+1fddAxazCC9IlNmdM6jvb+bdS2n7vCbJYT6z2gmPXBCcaBVfGS6/OF6kOwOEpRxicVOZrjfJ/r8j2rPRhxykfyVSujkHUnFpYG6GUAFVtccMyv6BeIpK6Fs6Cpnvt+daCzXb3h6Zaa54ZehWF15nml1RMUuAW5V0BJhEmBKmtjVdOniM8IGGVxqiyoyF3TUqUxBK5/LcftisJ69nDT7eMZ0QCqwmjo4zvcxOWeivt1CUGx3f3tvobed80iTGyJbEyabKYWlab0n1rT6Faf/myCHsw7YRyYsZmUrVIfxrnJI09zDtlWEgFAxi6Sw4Tu5b6YIFlp9Z06DRBosHA+OUcYmg7Ur5ZiUQRV/rYzFNq315+00+bLxlCvZ3/r2sTSoO6CMEdrE76GAQX5eUPnRVrwHhfC1f/kEsorxx5b6hOgY0fgfg+gLJv4FEzoF6+9w1w7P//ekXOdymEqLXdqa0d2DDMiqmImSSiAZCVaET5OTeYo19XgIzlMBJ9wMp1t5PYaxTeQwg79HR4/4BtMlDVH2ASgDM88Z5XQRpHgy8i0H/6d4tDk+F1srOAcqmiBYU8KtxxSEF37j2
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(8676002)(316002)(86362001)(66946007)(5660300002)(4744005)(31696002)(66556008)(38100700002)(6666004)(2906002)(6506007)(2616005)(4326008)(8936002)(186003)(26005)(6512007)(54906003)(6916009)(508600001)(6486002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?SRBWLxRBnBIwe8OiebPawFRHRf1xo+30UsiNPDLrhKJoYjwOHAm3mwCUFXmm?=
 =?us-ascii?Q?F0JqRACpAXgzVquzlsoRkbQpeF/jiXmGhJgAEYjMVC0dQEUnRfun7LtrwPTR?=
 =?us-ascii?Q?dtoImZtfHsHcif9hmYM8ay3nrMF4pJOyl9Gqjq+29+rSTISuaDPBf0Hj7I0n?=
 =?us-ascii?Q?AmQjpRyLrSbT9yt3ZEiq169ci1CKwFe7wMYCSzb4wb22G14Q1iKxLH3AKmDv?=
 =?us-ascii?Q?P03/r0niaPQMrzocaFaipMF3HKLVlmLjkr+JYFGctrHoAUaRJw3lAIIgEG/o?=
 =?us-ascii?Q?AT0CClSh+Gd2Ow656lVsUeZqzThD/Amw2Le5T2Un2bZ/Dnx1mzzkIKN9i38L?=
 =?us-ascii?Q?HBb1WZ5mItLhW1p3pefTSOfk1tKrbQHGfs/04+DXXpo4c+P6TEyZ5Z4iaxEM?=
 =?us-ascii?Q?rlC/T4qiTpxTmlXNDu3IPOVPVPLYAy5KYN8Dby91/roKeBvxV89EI9mUn5db?=
 =?us-ascii?Q?lwVqixnFvEmLLCygQG8cOVsRSNUVy5JyRqXr43DqvQJoM3WfyIvC65vGkFT2?=
 =?us-ascii?Q?JWDfaqv4u45hvdYDriOHmULf4WlzHixQW88I30FQj3FP4wHowMNxMZaRovJX?=
 =?us-ascii?Q?n3bC2x0sSoGUo1RIr3QywjGF5heal1EvFvZmKsquli7rcSqi+beWtNwCTnw+?=
 =?us-ascii?Q?QH+uh/b0Fzy9LC62Lh96+LwFgfl+bB11IahLYPzUViphqfEIlwIs+vU8vhPC?=
 =?us-ascii?Q?DRNcMIRs3gnjbGe5n24G9uYX+rU4IqAkl2A1lLQAGgJUESPYuQU5r4LBeThw?=
 =?us-ascii?Q?UBQpB6mnbVwxRP6oVhLlJWKF+UtgytWo2Wx9ouiUPW6mPltuR88oEStn9KxE?=
 =?us-ascii?Q?mRcRaIUQMoRqRWki8F1CvxSXXPgy4lDyk5bF9gsyTDcZByTz1zoWm8wK19Eo?=
 =?us-ascii?Q?0FXCxiS8whw+vrxAmvGpgkZMZFCwsLOOBM+BtOSFWHc62SJYb+t4uNuYN4EB?=
 =?us-ascii?Q?Mcmef2kB1ozf3Vx3kB9B0fqBLtonmAa0Ri/OJNjqan1+vzKewg5hJsJ7RKqp?=
 =?us-ascii?Q?SMgYRQdhEOM/YjaHZIqrp/uGaFCbs97zOcOKOrKAszeiZCX45ndGjiPPOCH2?=
 =?us-ascii?Q?IElHwnKxVTrPrjjjV6vss7j4nhPhlKseCd6JDOcuRbiTAQiDNLbXBA6LSLU9?=
 =?us-ascii?Q?QDQLVdazo8N6dm57BnzwX8ICK9R97fMVJa5aGU++C81C2k6J82yJ5Kv363x7?=
 =?us-ascii?Q?U5sjkrsesC9qlwP/I5Tl4SburM6Xgs4x5KhzUOpvA/4VBXAiQ4U9KjpmRM0K?=
 =?us-ascii?Q?KdAEboU+hZ2p12BIrVJzKxJ5dXFKzTaTqztBgXCRxCF1F/2aa8vyX6PwUoAr?=
 =?us-ascii?Q?oDFlWWHF/8hVEmhDeVdfZdZPPXlDtPekMzLbjECgog7pmuNvvoJdv7QDjkp3?=
 =?us-ascii?Q?QF9kuMNQH51NmAqJ+wNuwuLzdtnO3YsdiDsP7LEbaQoP3C/sQa4cGz9759Tq?=
 =?us-ascii?Q?T6WuDNdUfuhfLZJmvHcGaeQIUSSp7deGvSBboKJFoYis2FYyh5QJOco2Ntdh?=
 =?us-ascii?Q?2TRiLXlK0itheC4IUS8NqoQPMoNYX8mZZWlRsGx7bYt9p/TWGADg8GeAKBZC?=
 =?us-ascii?Q?WpPMmlwHtcXAclFrRKtwOfY2c0a6WFxfW5NrHd9pJJ06Ln/7JFJQGdz/q0CB?=
 =?us-ascii?Q?2y5/LplOylO8emOIm6hifYHIUN9LXt2KvR1yTk53OIXDLaBrMZYo9UKkmO/Y?=
 =?us-ascii?Q?S0bD50NrzIUGx++HAWNGFo3ELd9dnw9mNCKEBgij3363b37EUkrTt5YeWqwf?=
 =?us-ascii?Q?JYLHxBQrKg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bab5479d-ae76-4ef6-773d-08da269616bd
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:32:09.5905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: td2wkBK9YkcAHiFj5mmvYuijr+lhcC4Pjzl44ZVZqzBUX58CA8SXvlhRVCvp1HNuwG7nnafQr988hMtZ6HouEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2923

As of 68a8aa5d7264 ("iommu: make map and unmap take a page count,
similar to flush") there's no need anymore to have a loop here.

Suggested-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v3: New.

--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -308,11 +308,9 @@ int iommu_map(struct domain *d, dfn_t df
                    d->domain_id, dfn_x(dfn_add(dfn, i)),
                    mfn_x(mfn_add(mfn, i)), rc);
=20
-        while ( i-- )
-            /* if statement to satisfy __must_check */
-            if ( iommu_call(hd->platform_ops, unmap_page, d, dfn_add(dfn, =
i),
-                            flush_flags) )
-                continue;
+        /* while statement to satisfy __must_check */
+        while ( iommu_unmap(d, dfn, i, flush_flags) )
+            break;
=20
         if ( !is_hardware_domain(d) )
             domain_crash(d);



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:32:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:32:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312497.529753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niu9G-0005qH-T3; Mon, 25 Apr 2022 08:32:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312497.529753; Mon, 25 Apr 2022 08:32:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niu9G-0005qA-O8; Mon, 25 Apr 2022 08:32:46 +0000
Received: by outflank-mailman (input) for mailman id 312497;
 Mon, 25 Apr 2022 08:32:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niu9F-0005mk-4G
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:32:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 471218fe-c472-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:32:44 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-1YS7kSfkOHKz2PAbquvqIg-1; Mon, 25 Apr 2022 10:32:42 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB9078.eurprd04.prod.outlook.com (2603:10a6:20b:445::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Mon, 25 Apr
 2022 08:32:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:32:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 471218fe-c472-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875563;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Rx5RuDNsd53Ne+GEPe7btLL0NeSg+006AajLP6dHqSA=;
	b=UxFxlCMDfNGrnkimfoqRWi+DNLoTPwwWidfu2BaMhH718xxSfaShG+mRfjsMVsMxefdFe/
	NNjbexzSb3EC5qfDsMPjpG8Mgb3i9yPF6RKSM7jhWH5mHIpxVn3yv7GWsxNve5YgNJWx1k
	O7POTFxPeAiRu5ZRs3uCkwQ2mMJA64w=
X-MC-Unique: 1YS7kSfkOHKz2PAbquvqIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KBhbBW5x/s0aHTvFEKUtdvBdu0GqPt4dowlvnPJoFi/DiBpsYdme8jepY1Vtr0DCNuJvFR9MCgv3Wzq9F4N0bu/GTUMYx5uqAzWRIKsEwgD2yCPI6sC3dOrrwnAkCQ4+KarQfYMoI8upW8GRn3mPGkaQXvRVU1ks2wC3S/LDWRcKhJeNt5+mSBhoftlPmohH+rfQfOuLbH25JQVoUxCd5g+1AW3iBJduhmadZwu6K/NwQWBu05HTbTljnJ6OsKiCAY5l6UpPaWDl5vCiS2sDAaqteZ7+7L1CEvc4/XiyyFxgD1LNISYAY1uauLTVMYfuoPZvvUFRxw/hKI4Solhefg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9K+UqwmOPdb/UDNInYNhrwscOOzna6UxgCO3tesJ9P4=;
 b=S7xuwr7Xw9siPT1TtBYMAVWfX0l8Ggkz8QXwujgss4CjYsXOHIGyzmvvGfHKsZl5hHD9VUPa2nJ2zJj0jjc/EdcjRtFj0k1//Yy9wZtiSqBSs1I2SGXRl6e9WciinGq3NVFGYZxIzXd+1ejyL7Cn1GFlwCwaFcuBElI8PdjNV8gPv30CcQdPgFQeZY+TFPGQbIDggCxWLh5oAmVanp2YUNrO+Kxmj+U8GCCxIp90ybzSFZnhbf3+izewSX65czU9qzOuO4ixIfjOjDke5f0y3nmlhsKw5AJ4/2vTQFl772yFhNK9F3RHaTJKM064xT4iHTn8lA4voQAmoAA27JpBBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fc7b0483-5cf3-13a8-0181-fc61f9a16b87@suse.com>
Date: Mon, 25 Apr 2022 10:32:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 03/21] IOMMU: add order parameter to ->{,un}map_page()
 hooks
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0308.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cab66417-afa1-4b28-7244-08da269629a5
X-MS-TrafficTypeDiagnostic: AS8PR04MB9078:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB9078E8534B2975E4CD659590B3F89@AS8PR04MB9078.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zR1KTmlmqVL1SSAro1SskXtFZHHmGz39JjcBdywElWsGccJhpQFdS7ASLXyVzd9bO3oyEuVCQ44/gVtQpDJgNs6jZkfQbD83C39HVjFKSdgZU8xx6Z/J2rOkOmv8Xfi1T/mQIsOqh8Xb63jNqaS3DQuY/TSsLtn6Yk5XacUUY7cRv8eE0QVwOkEbcfIEyPE5RzwwufCJKVtCRsODuQNaBxgQsbB8XQLzuWxr4PF/cMzI8I58uKtyIf7pudr0V0wR9LbooQzIbfPr67MjVaXwRZeyUJgashVHJ/BfyU8AOwlR6rPucs/dP8yrVCuq6R4x3X7D9y4OcwyF8uVh9CE1B9SF/tY1Zcu2qTF2d4UTkqjDgIYfI4i0O9GhyAL069NlbFwH2JOns90Pist1+Ra/NdoHR4PpzwvZpotT/30GHhSJhI8oU/Ge/VEohSuXz1603iVw1A8ULKsMRNsphsoDsgsdxcvhZaB+5ExQN2uNHYFA4EGVmtzevECytjwHloPLxKokxL+ndvtz6vzILp0QltRmzPEsO9eXsMW/Ug1emBWP6gtEpUICANoOt504hNEZ8yvgZP6/lfpxyA6glmGojz7OjmAIfrzLdnD4antEsJvc82XzVG+36P5YGXFU11x85+4DcggWtmmxHrQUALn6+/Np0wp69fdaO1uHMBo+rwEIeKWTdQ3eS7tEk4iuXYfElmA99SJjrhVLOpzsMFkWT2fSvfoe0U+xulkovb9rle0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(66946007)(26005)(36756003)(66476007)(8676002)(66556008)(6512007)(5660300002)(6506007)(31696002)(86362001)(508600001)(38100700002)(2906002)(8936002)(4326008)(83380400001)(54906003)(6916009)(316002)(31686004)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?QmTStnSxsT9vnjHfZiiZVvjc5lJopa7Rhh/CRwQFwKhyInRfSOhwydQvSF8G?=
 =?us-ascii?Q?iaFjfL542gUYJr4wCB/Kz92IYPunRLu311Lu1loKdHOZy8WzIvzIRqCgkkCc?=
 =?us-ascii?Q?2nZcgi6h7s6YXA6W8FXXU6vygunfuCmBZmuVhmJpIXjyMNgU63TKHNIhhbrI?=
 =?us-ascii?Q?Aik6Tx74hbHYUwgPuRlAa2b3mZ5GewaQ+Qi+xNJc4WvRanS83JsGesafItSp?=
 =?us-ascii?Q?5cD/8OiG5ixMcGBq0z6lOhDGOmMsgsm7vlKq2qF+LKH3gCyEbqx3M6gGCOx3?=
 =?us-ascii?Q?/6u9XwLBeZ6koauMpVhM4cTJTgdmcShdTk+tusMCMKlngjKfM/WPM/4G9m9V?=
 =?us-ascii?Q?j2NrYNB0xrcWAzWFBiqxJeR4wJ0YIIaDBYaRLDamXOxh0OxmSb1EcWpupZhE?=
 =?us-ascii?Q?nlAGLmbz+kCTe7E1MRmjozyE/ii6DIKtAPXKD5cgLroFnMmEHSB+BrlHcqWg?=
 =?us-ascii?Q?IHi4fAEgdNc82sksbNGl+qRrcliKUlP8xEAjJIsaKhsGRekbegp/mSTqEsk0?=
 =?us-ascii?Q?kmxXEW7cp7j/Vae3+xUiQ/PAj6mtd4fUDDomMk7pUVV5imX8NW8I1iK7RUh8?=
 =?us-ascii?Q?U08W+VxST9uvzCiFg66DS9s2MPGIocqbscqKLFdxqMfIyGzT8Z1/6lwaGDie?=
 =?us-ascii?Q?SJ6vJRKiW2FBabmOG/G3zOMs5Lj8m0at16Ph3bV4yRcwzbGB2nOOUWMgLoVf?=
 =?us-ascii?Q?HZaDfF202MewBaNcNjg72JmX6p5EXDVim8RjA1Iv0EA3/KK/PXeuecZ17PLw?=
 =?us-ascii?Q?YCIfEQUfFYK7kmvQ1E+MK20MdRi41BSUMlNNOH97MmJldBIQcbLVNLEz6mTy?=
 =?us-ascii?Q?kxRRjHm/VcePh8Fgjxv0yLq90OAuZhE+w+6JjOTAzKnJXNLKWieL41pxW7DI?=
 =?us-ascii?Q?nSWZm7W2s34ONW035h55xYRBll4aKgEogse1f1jDXLogLw2xNR5uOqES76pt?=
 =?us-ascii?Q?u8hBZiCFOnRZQ7w5agfaeeHKG67rQZH2/M5tYFdmnetJzoZirpxKedfzT5Zu?=
 =?us-ascii?Q?pfsHNZS3dHamXqnS6p1IsDi4BwPvIppFVu1cYzMMJWFkKZEFPlQ+Rsf6WL1y?=
 =?us-ascii?Q?9+urcBDG+0+PMRSVSnOinH4awkXPEfbbADh5eRgS7t0ey6Ept9is7DkR+Gkw?=
 =?us-ascii?Q?DEjJbEPmBHJhSsMSF71CLqJycIOAexoBy745WBQ84EZ37ctx24+R9eo1MIbH?=
 =?us-ascii?Q?k11QjHEyIxe3/fSplNA99MzLQ5Vsb68ks/qURJ8QKgo/vC7SN3qHqbibQFcI?=
 =?us-ascii?Q?Y9jC+T7GdItss4IIYaX13C2Pf45PgmZEc19hv600gpMaLpo0uET0NaLFTQ1A?=
 =?us-ascii?Q?PxSUBCL97u7GyxOVzYKE8Wbk9eSVC46lcIiQeK7B11exKB3UsQEzlI5y9Twx?=
 =?us-ascii?Q?3DPIgfIhjPAxSI29UbFaZ63aCaLZ+7UO3fwJ5imITTv6tV0WSOI2dw64hgRl?=
 =?us-ascii?Q?J1YUyEEEfrs4/Af/wXTzvL95GrOgaywjhciSfmwmttvsEgMGGFi/gnMwEKOl?=
 =?us-ascii?Q?v8xt+w+tIQtJaoJjE9cilhMS4k0rs9cDICMIN317s/AmNYLrIPN6h/yXSEBP?=
 =?us-ascii?Q?3iLVo0OsX29N3TcwOfkI2u62es46F2XGZmGFmoUlBoEVZpseLXl9cQ6kiAuf?=
 =?us-ascii?Q?MucQRSE2cmLiAZO4YWD/iIIF+fK6yTk19Sj/WsbrRisz8Cp94nofPCG1nC+p?=
 =?us-ascii?Q?9i9rTSSDGEmnkIgJgVzu6IBU1t+wiuiVy0E3N+oRLCWjnje5kBoliZq+ehJs?=
 =?us-ascii?Q?KPrIJYxIcQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cab66417-afa1-4b28-7244-08da269629a5
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:32:41.3723
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 96WLL1VODuTBFo2bhFmwlGSlemoV4xSClqts33a34LYDVwCnNpMRxXZFg8lD05t7WwIaJyAZDZHoHaej1MesnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9078

Or really, in the case of ->map_page(), accommodate it in the existing
"flags" parameter. All call sites will pass 0 for now.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
Acked-by: Julien Grall <jgrall@amazon.com> # Arm
---
v4: Re-base.
v3: Re-base over new earlier patch.
v2: Re-base over change earlier in the series.

--- a/xen/arch/arm/include/asm/iommu.h
+++ b/xen/arch/arm/include/asm/iommu.h
@@ -31,6 +31,7 @@ int __must_check arm_iommu_map_page(stru
                                     unsigned int flags,
                                     unsigned int *flush_flags);
 int __must_check arm_iommu_unmap_page(struct domain *d, dfn_t dfn,
+                                      unsigned int order,
                                       unsigned int *flush_flags);
=20
 #endif /* __ARCH_ARM_IOMMU_H__ */
--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -245,7 +245,8 @@ int __must_check cf_check amd_iommu_map_
     struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags,
     unsigned int *flush_flags);
 int __must_check cf_check amd_iommu_unmap_page(
-    struct domain *d, dfn_t dfn, unsigned int *flush_flags);
+    struct domain *d, dfn_t dfn, unsigned int order,
+    unsigned int *flush_flags);
 int __must_check amd_iommu_alloc_root(struct domain *d);
 int amd_iommu_reserve_domain_unity_map(struct domain *domain,
                                        const struct ivrs_unity_map *map,
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -395,7 +395,7 @@ int cf_check amd_iommu_map_page(
 }
=20
 int cf_check amd_iommu_unmap_page(
-    struct domain *d, dfn_t dfn, unsigned int *flush_flags)
+    struct domain *d, dfn_t dfn, unsigned int order, unsigned int *flush_f=
lags)
 {
     unsigned long pt_mfn =3D 0;
     struct domain_iommu *hd =3D dom_iommu(d);
--- a/xen/drivers/passthrough/arm/iommu_helpers.c
+++ b/xen/drivers/passthrough/arm/iommu_helpers.c
@@ -57,11 +57,13 @@ int __must_check arm_iommu_map_page(stru
      * The function guest_physmap_add_entry replaces the current mapping
      * if there is already one...
      */
-    return guest_physmap_add_entry(d, _gfn(dfn_x(dfn)), _mfn(dfn_x(dfn)), =
0, t);
+    return guest_physmap_add_entry(d, _gfn(dfn_x(dfn)), _mfn(dfn_x(dfn)),
+                                   IOMMUF_order(flags), t);
 }
=20
 /* Should only be used if P2M Table is shared between the CPU and the IOMM=
U. */
 int __must_check arm_iommu_unmap_page(struct domain *d, dfn_t dfn,
+                                      unsigned int order,
                                       unsigned int *flush_flags)
 {
     /*
@@ -71,7 +73,8 @@ int __must_check arm_iommu_unmap_page(st
     if ( !is_domain_direct_mapped(d) )
         return -EINVAL;
=20
-    return guest_physmap_remove_page(d, _gfn(dfn_x(dfn)), _mfn(dfn_x(dfn))=
, 0);
+    return guest_physmap_remove_page(d, _gfn(dfn_x(dfn)), _mfn(dfn_x(dfn))=
,
+                                     order);
 }
=20
 /*
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -294,6 +294,8 @@ int iommu_map(struct domain *d, dfn_t df
     if ( !is_iommu_enabled(d) )
         return 0;
=20
+    ASSERT(!IOMMUF_order(flags));
+
     for ( i =3D 0; i < page_count; i++ )
     {
         rc =3D iommu_call(hd->platform_ops, map_page, d, dfn_add(dfn, i),
@@ -354,7 +356,7 @@ int iommu_unmap(struct domain *d, dfn_t
     for ( i =3D 0; i < page_count; i++ )
     {
         int err =3D iommu_call(hd->platform_ops, unmap_page, d, dfn_add(df=
n, i),
-                             flush_flags);
+                             0, flush_flags);
=20
         if ( likely(!err) )
             continue;
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -2163,7 +2163,7 @@ static int __must_check cf_check intel_i
 }
=20
 static int __must_check cf_check intel_iommu_unmap_page(
-    struct domain *d, dfn_t dfn, unsigned int *flush_flags)
+    struct domain *d, dfn_t dfn, unsigned int order, unsigned int *flush_f=
lags)
 {
     /* Do nothing if VT-d shares EPT page table */
     if ( iommu_use_hap_pt(d) )
@@ -2173,7 +2173,7 @@ static int __must_check cf_check intel_i
     if ( iommu_hwdom_passthrough && is_hardware_domain(d) )
         return 0;
=20
-    return dma_pte_clear_one(d, dfn_to_daddr(dfn), 0, flush_flags);
+    return dma_pte_clear_one(d, dfn_to_daddr(dfn), order, flush_flags);
 }
=20
 static int cf_check intel_iommu_lookup_page(
--- a/xen/include/xen/iommu.h
+++ b/xen/include/xen/iommu.h
@@ -127,9 +127,10 @@ void arch_iommu_hwdom_init(struct domain
  * The following flags are passed to map operations and passed by lookup
  * operations.
  */
-#define _IOMMUF_readable 0
+#define IOMMUF_order(n)  ((n) & 0x3f)
+#define _IOMMUF_readable 6
 #define IOMMUF_readable  (1u<<_IOMMUF_readable)
-#define _IOMMUF_writable 1
+#define _IOMMUF_writable 7
 #define IOMMUF_writable  (1u<<_IOMMUF_writable)
=20
 /*
@@ -255,6 +256,7 @@ struct iommu_ops {
                                  unsigned int flags,
                                  unsigned int *flush_flags);
     int __must_check (*unmap_page)(struct domain *d, dfn_t dfn,
+                                   unsigned int order,
                                    unsigned int *flush_flags);
     int __must_check (*lookup_page)(struct domain *d, dfn_t dfn, mfn_t *mf=
n,
                                     unsigned int *flags);



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:33:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:33:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312504.529764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuA5-0006VR-8g; Mon, 25 Apr 2022 08:33:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312504.529764; Mon, 25 Apr 2022 08:33:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuA5-0006VK-4v; Mon, 25 Apr 2022 08:33:37 +0000
Received: by outflank-mailman (input) for mailman id 312504;
 Mon, 25 Apr 2022 08:33:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuA3-0005KM-J8
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:33:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6538076c-c472-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:33:34 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-uwry9y5OPUeZAKnkaGefdQ-1; Mon, 25 Apr 2022 10:33:33 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PA4PR04MB9567.eurprd04.prod.outlook.com (2603:10a6:102:26d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 25 Apr
 2022 08:33:32 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:33:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6538076c-c472-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875614;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Z53/35ZdniZbOvRjYGCROZXOzui9qbcXDOdkOD0m+zk=;
	b=MBPp0o1HKTKEDby7Ewe7v6glUqF85R10qpPM+6kgugU5bg2sAEGjonAkJQ23HNOUFFrZST
	daTr53/TpwPMogHoMo+9qOR3nsYwyc/XZ+bn2YPMKA+W6QNkdgnVYDxG1PzyoVZbJtFgEG
	X3BjBL70DypzJjBU/h2Bc8qSp4RKJEk=
X-MC-Unique: uwry9y5OPUeZAKnkaGefdQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PDQXtv204C/f9VPwvQC511Wup4uJLJK6ZrI5DSLO0lFc1xR4Lwl4g3V91MMtzhj59jgYbUROtqtgy2oCD24m79oPW+f3v6AMarRLxw/pMkbgG2pWAbcSc1PE1ids8PDSYY+mMQe4kPOmw8xQcvtujP4I5OCcQB78o7h1Nnf6E8pP2IFxpgcDuq3U/YEHoB0wkzWZAXgeqT3oEjEV0zpkgj8yVum4psd1hfozJRqNHYyakPT+KUa/TTzqxIQA63dNnPMDqgrkdoySGsR89BI5aqtWf+dy/tU0up/uPlRjUjZY0Jt6Iwc6753dGbbYIDw+1k/0gNIoJivCUKISqeLx8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z53/35ZdniZbOvRjYGCROZXOzui9qbcXDOdkOD0m+zk=;
 b=MiAN1DnqOTNQw7Im0x6j2PAROhgQWsQdBY1QpE4pLFhWGwW0JzeFXnsFirBtFSLxEXNDTD55AUCtZ7lOyl26FqbScv/95kZWfXrZEbMBnicbW+VQ+vE7C8/187Y2ldBOPEIL87nMBwBnRGNGxiifH0i7yTkfqhjzGE6d6GnCq3KW5XmveB54NmmyRAI9kOddIuerUeECQN2qBTvBfWAKIDmC5gfCJeyKrDzodo8+1bzz9+p9rGi6g3Khcc7KPjCLludoSw1mMpy4npoaD6J/Eb9OJFXQVhoYLdQn9JWu3oXS8rzgi+VH5OzV/9sIvIuXUmyQj9/GPuG+3cvupNzAig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <227d0bd1-c448-6024-7b98-220271d9bf63@suse.com>
Date: Mon, 25 Apr 2022 10:33:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 04/21] IOMMU: have iommu_{,un}map() split requests into
 largest possible chunks
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0040.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::17) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cb8186a4-4d2b-4713-8fd9-08da269647c7
X-MS-TrafficTypeDiagnostic: PA4PR04MB9567:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB9567713203EFFD3D0B8922E3B3F89@PA4PR04MB9567.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YGQMhTH3ufYG3qJKRgFZ0mnwQxBkZ7EZQB9Y3QhlDYJ89pwbtb4dzpbMU9sgzuOI4vtDVizXbn//Y8rXi48infzq8wk9X5Zpv2OAcyEj2bsyVM/h9r01u4qBikE4Cs5dCacB8IsoN3urOLi8VJHV32PqLIjD5Kj6kVKvHR+rVCZ7kofDLPITxghibsirXafGNWWwWiCxtpycIZ4FEG/GGJ60el6s8myYoOvckW99sq4pL6tYbZh4Hsu0lwMjwG/nU5cDJLYDWEIQZCy37wrYyz57oCNB1UjOAsiOAOd+kPLghA+2mMe6qstYnzcY3Hl5ZLoHhA7PS1H0SC1gE+MQkMH8ys5ffFsqQsiaG21fSFxQNuxp7fPrVMl3KhDaym8SZ5nDZlv6biY+YiC9raImcaUaRy6Ux/83JwlFUhUWhIbuL8s5ISfXUW5l0lpZwiiXwB1ZWEq35hvlEKj480WuUHnYXVNFLQbAmgwBFTVnsxAG9QNyXMMwBVlwcCU/9JsEI0lpM6kKQw91YAPDuTuZLD7saRLX+ljm3uE8JU4FTM1+SE3P2mFlEsRls1HbqdJR1/zbVBWnzRmDN83GoeGyelX+TlpqWSiNwIZMl8hSSI/YTK/7SEyVfmzU0/SI/lRjvjLuJTWo8+ml8ebOEcI0AbTEiSHsHlSvFy8YKtGmh/TwKiXt4dLOqbvRkWIIwKFZfldZz3Pdxg99fp0UK1ZN/NthhcuRNpdp+WEtZfnLQZY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31696002)(5660300002)(508600001)(31686004)(54906003)(6512007)(2616005)(66476007)(6916009)(316002)(186003)(2906002)(83380400001)(4326008)(8676002)(86362001)(38100700002)(6486002)(66556008)(26005)(66946007)(6506007)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WjRaTDR3ZWFPN2dROUhzcTJnbjJqUDFkYkJtRjJRb25JeDRYYm5VKzc0d0Er?=
 =?utf-8?B?YW9sUFpadU9sOE1kUk9DOW4zR1ZVZUkxYnNjTVJLU1hQenlBZnd1ekxCcnkr?=
 =?utf-8?B?bXpqaEZXSFliZDh0ZXdpRVEyRkpJNm80MXlFQ0dMNWFpOUFVaFZhWVMvVEJj?=
 =?utf-8?B?c2ZUbTZsSGpHL0tRKzFqQVc5c1lNK2FGNzVWTE5qNWZhUE9DekJnbVg5c2Jw?=
 =?utf-8?B?WTNlNHg5MlRLV0hNaks2emdZYVU5RWI5TUFBYzdxZUcvY2F3RlJkL2NhUGcy?=
 =?utf-8?B?STRwaksybXVPb0hyZXIxak9jVC93dFN5bGlRcHd6NE90cmpsOWo2b1E3bjg4?=
 =?utf-8?B?cjRaRUJwbGRnMS9rQmFOZlAxY0xPekM2eGZaMDlGOUtNeElBNVBtd3Fra2tM?=
 =?utf-8?B?U0ZsS00yeEdIeDVCMHk4a0tSOVdsVGV3b3FmeUZMUVNCRXZqRHFQSXN6M0tN?=
 =?utf-8?B?dDQ2RlMrNVp4LzN1K3pwditFalgvK2oreDdvYlpnRkpvdFZWSS9RUHdVd09T?=
 =?utf-8?B?UWpiTW85Q28rRDkwa2wxTVNxSjFFWUpTNDR0YnNpV0poUGZUM3UzY01HTFBn?=
 =?utf-8?B?R1BIOGVWZlNIZW5ZUFoxQm1uWDgzRFlOV2tWaUVYMkNuRXZFbVZreDg1NllE?=
 =?utf-8?B?WkxWWWlNUDI0UVF4NGF2a1BCUHpTQjV1enltUCtZdlg3SVJxVm5yb05yWTRa?=
 =?utf-8?B?QkdRR2hDUHlwVkVHSmZlRHg3anA5clEwWWdqYnpaRzFaTFZydWpXQVpOdlhw?=
 =?utf-8?B?L0tzQ2JuTGtydGVIRlo4bkZBemR4NXNpbTdDLzdSSUpaWGZFMmp5a2tBdEFu?=
 =?utf-8?B?VzR6WEVNdkpSV2FxNjBSVTF2dUFQbTBWemd6anAycjZzY2MxdnVmckFZeFhQ?=
 =?utf-8?B?eEw1cExVVVdRUUJxMWk4ZXhuVS9tKzhsdllCTHRkb2Z0Q2IzU0c0emdxVlpi?=
 =?utf-8?B?VWhaOVBFM0dNcW5TVnlUc2x5QnZpZStnOXV4ZHJLNXZvSUtBbWhoanFGakF0?=
 =?utf-8?B?ZEdsOFBnczhsWVVPNXE3bndOSFZvYmdUU2F2bGFYbTVqbHExSCtoYjJIbFV4?=
 =?utf-8?B?dFkrNXNzK0dKU3pkaEtoc0ZPSUM2amlqM3BPVlNjQnJqRFAxdTBNeUlqd0R2?=
 =?utf-8?B?STZoT2cvUkt6OTUwcFlYSDdKUms3Q1hnTkp0bXYxMkRROE4xVE16NGVvczZV?=
 =?utf-8?B?cHFPT2FtYkxNODQzeTJJVFFQSGxNZ3BtWjdhNHVPQkpLaDgxRFRLVXg3WDZv?=
 =?utf-8?B?MFU0c2NZaHRrKzNhQzJTN2tlM1N5MjNyMkt3dzR6V1dSZlVCNnVibzlWdEF5?=
 =?utf-8?B?d1VIU29mYUdtTlBBRjB3V3BhNDkycDFScjNiWUVtbjJnSmduS3lQNFY3QnBp?=
 =?utf-8?B?Umd4clQrVHZldXlPdTNEU1J4RHp0SUZBRjdkaUdLamEvU0FzMDM5c0FzUGUx?=
 =?utf-8?B?OENQaVA5SzlQenRIRE5yMXExZExWZkRRSkJHaUpmdjBFV1duUkZQc2VNaDZx?=
 =?utf-8?B?K0o2eXgzRGFqWXdkR0hQY2tYQ0svMnUwNUs0eENsS010WmZSOUcvVWkyU1Iv?=
 =?utf-8?B?amIrRUMrVnlHUG9XNGZJVUNUeUJBdWt2M1Zjdkt1d08vQ2pGQjJaVU5MUVRG?=
 =?utf-8?B?SVIxMFVzcHVPMmcyakpEOC9lTXlob1BFa2dseTB4NnpSdVZ0Lzd6b3JBOFJW?=
 =?utf-8?B?T3V3WWo2VDhZYnM3WjZWazNZeTVBc2xKVk9DUDl6TTZ5L0QxbzFYTXROcEtm?=
 =?utf-8?B?Y2JjUXFCVWk5OGI2SjJHSmlRVFc5MFhDUzVnN3JzWlJUZkpxMjhQZ3lmdGdB?=
 =?utf-8?B?REJDSHU4M0lNdkxUblJpMFNmaERhd2Z1TU50TkpCeGlkMkRjSDU2Z2I0a25n?=
 =?utf-8?B?ZWhlZzlzM1NYZ0dzY0pjQVdXUG83eFJMUzdhYTZ0ck9ndHB0VGxibmIwQllo?=
 =?utf-8?B?Q09ySjdoQW1EbkxaTEhsOVdLcmxoV0ducExkTVBCQ1o3REFuSHVFZlBacGRQ?=
 =?utf-8?B?UlhLWGZoOS9VWm5LZWVtdWdlLzVOU1E5Nk1CUDlDYWFrSEJQU0tiQlQ3SDJD?=
 =?utf-8?B?Y1RPczNwNjRuRHRDZW82SzkxYWlMT3dZUlpLTHQ2dUhHRWlaUTRLVk9PVDIx?=
 =?utf-8?B?ck9YZEFIaitzQWl2bklMQk1tUHZ6elBTbXhmZ2ZST2RSV1ZkWGE3aEhhS1Jx?=
 =?utf-8?B?MzZSaktjS1N6cHZVdFFMUTVCUTlQWFNoV3VUUlR3U291S1IvOFUva1BvVW5V?=
 =?utf-8?B?aXJCQWN2R21CQWlaL09WT2VCVTZWR2VYaWZzeTFWSmYzeUJlVVovaG1KaGdG?=
 =?utf-8?B?dHQvMGZOVmhjZ2RIUWF0STlQeWdDZnVmbkNkVFRyeDVmc3kvUnJzQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb8186a4-4d2b-4713-8fd9-08da269647c7
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:33:31.8650
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kMzdGho5gKzkzrISqdWMGx1hw/CHOUWgHGKUCs20jhSdc6melKevyZ+aRQbbcwXyJDdpfNBWScqO1tAquH+oPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9567

Introduce a helper function to determine the largest possible mapping
that allows covering a request (or the next part of it that is left to
be processed).

In order to not add yet more recurring dfn_add() / mfn_add() to the two
callers of the new helper, also introduce local variables holding the
values presently operated on.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v3: Re-base over new earlier patch.

--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -283,12 +283,38 @@ void iommu_domain_destroy(struct domain
     arch_iommu_domain_destroy(d);
 }
 
-int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn,
+static unsigned int mapping_order(const struct domain_iommu *hd,
+                                  dfn_t dfn, mfn_t mfn, unsigned long nr)
+{
+    unsigned long res = dfn_x(dfn) | mfn_x(mfn);
+    unsigned long sizes = hd->platform_ops->page_sizes;
+    unsigned int bit = find_first_set_bit(sizes), order = 0;
+
+    ASSERT(bit == PAGE_SHIFT);
+
+    while ( (sizes = (sizes >> bit) & ~1) )
+    {
+        unsigned long mask;
+
+        bit = find_first_set_bit(sizes);
+        mask = (1UL << bit) - 1;
+        if ( nr <= mask || (res & mask) )
+            break;
+        order += bit;
+        nr >>= bit;
+        res >>= bit;
+    }
+
+    return order;
+}
+
+int iommu_map(struct domain *d, dfn_t dfn0, mfn_t mfn0,
               unsigned long page_count, unsigned int flags,
               unsigned int *flush_flags)
 {
     const struct domain_iommu *hd = dom_iommu(d);
     unsigned long i;
+    unsigned int order;
     int rc = 0;
 
     if ( !is_iommu_enabled(d) )
@@ -296,10 +322,15 @@ int iommu_map(struct domain *d, dfn_t df
 
     ASSERT(!IOMMUF_order(flags));
 
-    for ( i = 0; i < page_count; i++ )
+    for ( i = 0; i < page_count; i += 1UL << order )
     {
-        rc = iommu_call(hd->platform_ops, map_page, d, dfn_add(dfn, i),
-                        mfn_add(mfn, i), flags, flush_flags);
+        dfn_t dfn = dfn_add(dfn0, i);
+        mfn_t mfn = mfn_add(mfn0, i);
+
+        order = mapping_order(hd, dfn, mfn, page_count - i);
+
+        rc = iommu_call(hd->platform_ops, map_page, d, dfn, mfn,
+                        flags | IOMMUF_order(order), flush_flags);
 
         if ( likely(!rc) )
             continue;
@@ -307,11 +338,10 @@ int iommu_map(struct domain *d, dfn_t df
         if ( !d->is_shutting_down && printk_ratelimit() )
             printk(XENLOG_ERR
                    "d%d: IOMMU mapping dfn %"PRI_dfn" to mfn %"PRI_mfn" failed: %d\n",
-                   d->domain_id, dfn_x(dfn_add(dfn, i)),
-                   mfn_x(mfn_add(mfn, i)), rc);
+                   d->domain_id, dfn_x(dfn), mfn_x(mfn), rc);
 
         /* while statement to satisfy __must_check */
-        while ( iommu_unmap(d, dfn, i, flush_flags) )
+        while ( iommu_unmap(d, dfn0, i, flush_flags) )
             break;
 
         if ( !is_hardware_domain(d) )
@@ -343,20 +373,25 @@ int iommu_legacy_map(struct domain *d, d
     return rc;
 }
 
-int iommu_unmap(struct domain *d, dfn_t dfn, unsigned long page_count,
+int iommu_unmap(struct domain *d, dfn_t dfn0, unsigned long page_count,
                 unsigned int *flush_flags)
 {
     const struct domain_iommu *hd = dom_iommu(d);
     unsigned long i;
+    unsigned int order;
     int rc = 0;
 
     if ( !is_iommu_enabled(d) )
         return 0;
 
-    for ( i = 0; i < page_count; i++ )
+    for ( i = 0; i < page_count; i += 1UL << order )
     {
-        int err = iommu_call(hd->platform_ops, unmap_page, d, dfn_add(dfn, i),
-                             0, flush_flags);
+        dfn_t dfn = dfn_add(dfn0, i);
+        int err;
+
+        order = mapping_order(hd, dfn, _mfn(0), page_count - i);
+        err = iommu_call(hd->platform_ops, unmap_page, d, dfn,
+                         order, flush_flags);
 
         if ( likely(!err) )
             continue;
@@ -364,7 +399,7 @@ int iommu_unmap(struct domain *d, dfn_t
         if ( !d->is_shutting_down && printk_ratelimit() )
             printk(XENLOG_ERR
                    "d%d: IOMMU unmapping dfn %"PRI_dfn" failed: %d\n",
-                   d->domain_id, dfn_x(dfn_add(dfn, i)), err);
+                   d->domain_id, dfn_x(dfn), err);
 
         if ( !rc )
             rc = err;



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:34:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:34:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312512.529775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuAu-00076y-Hn; Mon, 25 Apr 2022 08:34:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312512.529775; Mon, 25 Apr 2022 08:34:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuAu-00076r-Ef; Mon, 25 Apr 2022 08:34:28 +0000
Received: by outflank-mailman (input) for mailman id 312512;
 Mon, 25 Apr 2022 08:34:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuAs-0005mk-D8
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:34:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8385b456-c472-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:34:25 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-ToR_TdrHMMC6fmfo9YEqkA-1; Mon, 25 Apr 2022 10:34:23 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PA4PR04MB9567.eurprd04.prod.outlook.com (2603:10a6:102:26d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 25 Apr
 2022 08:34:22 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:34:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8385b456-c472-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875665;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vWBl6T/hSAOh0rV2Tz0Vc2i51OiQePKLr7zssMhmHEk=;
	b=iJiO3at5AyhaD0pkDvAEjgaCB5m8onj+KmNiCfFcLDWcZoMRrct/X6zKtMoJLivPRPtRu6
	ap5MJEkS7H3C5i3SISR2GIBH6LsKtsEkHdlsk8B9UzLZVQijgI7kOqMVn4kwDFLsZ23oZK
	+1+I+Igtk3OAmSXyNwwYyJrYJndFtuc=
X-MC-Unique: ToR_TdrHMMC6fmfo9YEqkA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V0iGxl19zlvHtS3x5PhrvJpKskoHfSjw4QFkmEUlnoe4XsXV1kd15gmM3wGd/HxYM5Q8Vy3yk0ubzTMBmdEdvRu1m4NypasjLdznmNxepBO4sGSLuPVq0v/LzibQPEls9j95zZEs0wWbBkVYP6Yt88ji60T16PnAkHWiNLSsPFzgZ8+uTLySvhCAz+RBQuTNzJJDD7Vycxn6J+9GTvSb7NvvrIO7oarSs1FaLiYoQR+EnjYBV6Dq+svZ7PChMQF/raZQmjjbiqu4LFyxzDQW4cuqVPOMPDAlEpnSjqGzLvdkPDPqegSXsbiiW+vnN/oMsPB8u64SV93QoVob2WpMxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vWBl6T/hSAOh0rV2Tz0Vc2i51OiQePKLr7zssMhmHEk=;
 b=k+Fk7Qn+W8Fsa4Er9wdyHjq93t096ejQv6HNToG/ihkdjbPAxKbJ3N8Wu6pKb19MyyNivpQ32CATspIUGN7MV7n56bBWTyGXdncVgTi1ekkPCAMmD61ynEsIe/1CDpliXNLg2WPYjhEmUrCp5z79BB5ll0dBYgSh8ecDu3cc3IvC73Dv1VZeg0ohCpBkZkuZajCqQ1liZ+gP604Nj6GqAjdjtnalNvC6cbnL4BSWfTo7g1Qx7MpClZK2lj2Dt38uuAKwBJAvYbZ9968XwjKTc7Ltx+G6AqZDVnK03WhiuD47pnX8dEeXtdFVeFNVUYiF6xNMz12Dm4NrVoB736yZXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com>
Date: Mon, 25 Apr 2022 10:34:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR0301CA0011.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::32) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6f64066d-4dbd-41a9-cb13-08da269665f7
X-MS-TrafficTypeDiagnostic: PA4PR04MB9567:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB95677EC948CC2FFDCF524254B3F89@PA4PR04MB9567.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oFkPV4GsiJRxgpE1BeGJBz8SYMYoymPfzbD69Z2LcS11JqaXwU1lENuhXfwNEIQU53YZu8RdqqL17vesN8IibrTjGHbBNEUn+0yHin/hhO8Ynp+pWC7zOyKOp9/bFzCONNiALZ8+f1xB/8q9XDtcIAzIS/yh76TUClHpBGsj6u0iZylbfvrxh3eeFswBabaU/hartMgJpA1b1bCDw4UxME1L1/XQC/JTD3PZJRCPSufqQ7spV11Q95XMkTaIkq5v3MMkdBNj77o0fInzY2SSRzRupaMK8WzcCgn3FyvogJTqssDGKpOG5Wc4ZmSyIZqK3fymW1hnawI19+0e6z52hNumEQqu+eTwtWTkjrme4MpoJGa5mhCHwvi6EG+oXwufdppHfg5VzEsrx9EsnxZ6gdm8QEx12Vu8QimQVnF6llOiEA/arDgwiQzE2U2YYPEJ+ZL0dzhCM1O5XPR+wyt2m3O8YkLGcthYbP1vrEniRfk951rr1g3vheg4rvKIrgKVWGmej3vPpqLi87VM58H8NoXTifg2P5cuo1WoD9ftxTvFvQBE07j1Hm9Lr2VHf4ZEhtQr9JkzCsXOMSWm9PC2KMweSA9pHz/68MjrGNgC0XfBHIJDDAttnqN7hfsBLdn4E/zcwJ1B8/9jhv6SISOPtmHUrkffQyhL60MF/AqHYCQEAE2tDGnYzPbcTErBJlyjNajsg/+ZdW/47gDrNEAWQu9aFT/sewfAm6LkvxC+PTA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31696002)(5660300002)(508600001)(31686004)(54906003)(6512007)(2616005)(66476007)(6916009)(316002)(186003)(2906002)(83380400001)(4326008)(8676002)(86362001)(38100700002)(6486002)(66556008)(26005)(66946007)(6506007)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q0svMWVKTk9sU3FDcmR4b3ZRcHBQU2RoZGhmOVV6d0RvMm5RSmU1MVlTWnVK?=
 =?utf-8?B?WUgrdkFYaEdOY2tlOHNQaHJ5RVJzMXZGeUxaODFxdlVxQW5xUHlkSkFjRHVW?=
 =?utf-8?B?QzNMK1pNRmtjcTFlb3FJbUhmdzJrWVRic2FFM2g0TUtPQmxTVWNhc0dZQVBM?=
 =?utf-8?B?M09YejdPVXF3THlQamhnOHYxWE5qQzNlK3hPcndQZ0V0WTQyOHczZmFLZ3N3?=
 =?utf-8?B?c2h5NVFOL1FmWXRXc3ZTWkM2UVpkYjZCeWdiV0t3QnU4b25UT20vU1o5MThn?=
 =?utf-8?B?Sk1Wcjl2SVk5SDlVL1cvbk16Z1djTFR0SkZtNFRKSTNQNFBzS0xoK08xbThV?=
 =?utf-8?B?VEwycEdxakdZZ0QxSTM0eFFGem51UUV5a0N3Ujl3S01LRTBrTDhoU0dia3pO?=
 =?utf-8?B?bW9GL0pHMzkxQTVwY0I3K1ltTTNmRzZ2WDlXWmlDWXZNMVJFUWZDYzlpRlZq?=
 =?utf-8?B?dVVBaHp5K2ZvQkd1STBYZldmMnhQNGhrckFac2NhbnlEcXAvTEp5ZUFFUFN5?=
 =?utf-8?B?Q2t0Rm5IZ1dzQ0poKzRqd0FKMmdEbWlTV2tBcmlmV1ZrRGlWcG5MSE1pT0pt?=
 =?utf-8?B?NlNhS3NzNEx3WThQc2hjY3pRZU5hOVJrR2dZN3dPN0x0SlNGaFdaektrcEs1?=
 =?utf-8?B?a1FTMTZWL203MjloSW9NY1k5OG5lbll3d2dUcVdHYVgwSGFFK0lVWWpNOXho?=
 =?utf-8?B?Vm1uVEJIREtxM1VXd1ROWkx0TEx3ZitwV2JDTVAxZHp1a05rajdxNGlVL3NW?=
 =?utf-8?B?R0syMVFNcTBraTdGcStpU1E4V3BmdFIrOWhMcVE4NWM3TDlVTVN4L3piWCtH?=
 =?utf-8?B?OStlOFV0VGFmL2pKUEh0T3NtWDBKTGVvSS91V0RYbmhnRi9FMEZub3Q4SkQ4?=
 =?utf-8?B?bE13QTk2STdDbGtINHpZTmticnF4bEFxNmxjWGpNL1A2dkdsVVVvNHlHS1hp?=
 =?utf-8?B?cDhtU0paRG9TbkNLMHkxK0ZIbWRyOEZNVWdmWDBRclNUR0xvNFc2eWhwV0p0?=
 =?utf-8?B?b09xTGp1RVllaHlTd3NIL1VRUExUb0w4cjFpT0EyZGIva0tpT2F5Yy9MdmFG?=
 =?utf-8?B?djFCR1ZCNGQyNko2Z2hjMFVVemNZNWgzNFVKUmoveHRsWDR6RDVYSDZneDl2?=
 =?utf-8?B?RG9LTEVQcmplV0d6REsvMFQxTEV2dDBaWGlBK2lLeVB6Y3B0S3Z1Qkc4Q0oz?=
 =?utf-8?B?QWVBaGZ3VWtKYXFtcHBGTERjNnA3dzlWUzViS2xRcFlQUGdsN0hOeE5aYnlH?=
 =?utf-8?B?VzJ5YVg3dzRlSEtPVzl0NVNwbjRmbHc3Z3FneGdUcDIySG5jN25NSmlGZlQ4?=
 =?utf-8?B?dkZLYzFkOHVRSDNGZ1J6WXE1YkIrdHhaVXpkWXNhalVFbUxTL2hUaGRxMDc3?=
 =?utf-8?B?czcyMG1QV1ZLcUZNcUhXRjJzajdSRGhnMDJ6WUxNbE05RU9IVlgvVlorUmdn?=
 =?utf-8?B?SmRKSG85VGRDTC9NQXBmc2xWQjBTL0lOWUhLZ2NraDZGR1JXS25OcnVXVGtl?=
 =?utf-8?B?a3V5NzU3NjBVM3dkMzFuaTZwQkZpbWZhM3V2ODlnaEkwRmNIOHdqbTB0Y1FT?=
 =?utf-8?B?dHJJMWcvd3R0S1RlTmh4OFlIVmMrdGxYTlNSWEhnOWJhN3AwakdONDdLcU5Y?=
 =?utf-8?B?by9Zd2w1eDhkVDNGSnJnSitkdE9YdFJoQkFIQWNBSkpydkNJMjg3emd6b0xF?=
 =?utf-8?B?Vk82Mm5jYTgyN0FpNDdQWWg1NVZjV3Q3WjFWMG1KUzcyQ214Z3JiUFpBdG8z?=
 =?utf-8?B?R1FwKy82Q05JWEU5SXYwY3dNeWxBQWVXa1NZM3FCV0ROak5tTnhvVkx2RURp?=
 =?utf-8?B?dHpJQzFzNnNBdmZiSmVuYzdiTVBXRjFPcjNwdFJEYjI3V3BwN0R2cVVUZjJT?=
 =?utf-8?B?RXdlWStpV3l0Z3VPeVZZMy9UUWxaTnRhT0VHV28vVlVNNUVzMlR5S0pWOExl?=
 =?utf-8?B?U0RRM1BLZHZOak9WKzBZcko5SFRRS3dyOG12THJOaGJ5K1hoREhBRENkcHNi?=
 =?utf-8?B?MWFnMmFlYzlLZElpME9RSlVtQ3NDMHJhMXNoZ2hvTlBQTk02UGlyVC91TlZx?=
 =?utf-8?B?ZTViT2J2ZXNsYnhoOU8vbzJYWHVWbi96a1ZObWxYd1JtWlhGSDlKSlZ1QlJ6?=
 =?utf-8?B?d3htZ3RIT3NVbkl0ZDR0Yzdock02TW54eEdTakxoWGQ5ejh0SUdvWHJoWFZE?=
 =?utf-8?B?V3FGbUk5R3lxVVQ1N2tyOE1nNnIrdlRNU3FTWHJqSWMxYzVoQjFoc0VLQk4y?=
 =?utf-8?B?NFk3ajljd3RET3hPTS9NUlVIMEdTUURYS0hzUm44QzRreVBKZnh4ZnR3M1Js?=
 =?utf-8?B?OUZiNUExaER4cXlPbFlUZ3NqMDFkbU9yNjhrTnp5bGxsK0JYV2t6dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f64066d-4dbd-41a9-cb13-08da269665f7
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:34:22.5596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TciKBrwbBpsQ3N6GgoXP7HCYONyH21uWr1sC4JSnk0xhUhrH4Nw5vpj9X3loRaj71v4NcTbIYvPS/Ll4llKr8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9567

While already the case for PVH, there's no reason to treat PV
differently here, though of course the addresses get taken from another
source in this case. Except that, to match CPU side mappings, by default
we permit r/o ones. This then also means we now deal consistently with
IO-APICs whose MMIO is or is not covered by E820 reserved regions.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
[integrated] v1: Integrate into series.
[standalone] v2: Keep IOMMU mappings in sync with CPU ones.

--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -275,12 +275,12 @@ void iommu_identity_map_teardown(struct
     }
 }
 
-static bool __hwdom_init hwdom_iommu_map(const struct domain *d,
-                                         unsigned long pfn,
-                                         unsigned long max_pfn)
+static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *d,
+                                                 unsigned long pfn,
+                                                 unsigned long max_pfn)
 {
     mfn_t mfn = _mfn(pfn);
-    unsigned int i, type;
+    unsigned int i, type, perms = IOMMUF_readable | IOMMUF_writable;
 
     /*
      * Set up 1:1 mapping for dom0. Default to include only conventional RAM
@@ -289,44 +289,60 @@ static bool __hwdom_init hwdom_iommu_map
      * that fall in unusable ranges for PV Dom0.
      */
     if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) )
-        return false;
+        return 0;
 
     switch ( type = page_get_ram_type(mfn) )
     {
     case RAM_TYPE_UNUSABLE:
-        return false;
+        return 0;
 
     case RAM_TYPE_CONVENTIONAL:
         if ( iommu_hwdom_strict )
-            return false;
+            return 0;
         break;
 
     default:
         if ( type & RAM_TYPE_RESERVED )
         {
             if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved )
-                return false;
+                perms = 0;
         }
-        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn )
-            return false;
+        else if ( is_hvm_domain(d) )
+            return 0;
+        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
+            perms = 0;
     }
 
     /* Check that it doesn't overlap with the Interrupt Address Range. */
     if ( pfn >= 0xfee00 && pfn <= 0xfeeff )
-        return false;
+        return 0;
     /* ... or the IO-APIC */
-    for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ )
-        if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
-            return false;
+    if ( has_vioapic(d) )
+    {
+        for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ )
+            if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
+                return 0;
+    }
+    else if ( is_pv_domain(d) )
+    {
+        /*
+         * Be consistent with CPU mappings: Dom0 is permitted to establish r/o
+         * ones there, so it should also have such established for IOMMUs.
+         */
+        for ( i = 0; i < nr_ioapics; i++ )
+            if ( pfn == PFN_DOWN(mp_ioapics[i].mpc_apicaddr) )
+                return rangeset_contains_singleton(mmio_ro_ranges, pfn)
+                       ? IOMMUF_readable : 0;
+    }
     /*
      * ... or the PCIe MCFG regions.
      * TODO: runtime added MMCFG regions are not checked to make sure they
      * don't overlap with already mapped regions, thus preventing trapping.
      */
     if ( has_vpci(d) && vpci_is_mmcfg_address(d, pfn_to_paddr(pfn)) )
-        return false;
+        return 0;
 
-    return true;
+    return perms;
 }
 
 void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
@@ -368,15 +384,19 @@ void __hwdom_init arch_iommu_hwdom_init(
     for ( ; i < top; i++ )
     {
         unsigned long pfn = pdx_to_pfn(i);
+        unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn);
         int rc;
 
-        if ( !hwdom_iommu_map(d, pfn, max_pfn) )
+        if ( !perms )
             rc = 0;
         else if ( paging_mode_translate(d) )
-            rc = p2m_add_identity_entry(d, pfn, p2m_access_rw, 0);
+            rc = p2m_add_identity_entry(d, pfn,
+                                        perms & IOMMUF_writable ? p2m_access_rw
+                                                                : p2m_access_r,
+                                        0);
         else
             rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
-                           IOMMUF_readable | IOMMUF_writable, &flush_flags);
+                           perms, &flush_flags);
 
         if ( rc )
             printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n",



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312515.529786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuBU-0007dp-SZ; Mon, 25 Apr 2022 08:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312515.529786; Mon, 25 Apr 2022 08:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuBU-0007dh-Ox; Mon, 25 Apr 2022 08:35:04 +0000
Received: by outflank-mailman (input) for mailman id 312515;
 Mon, 25 Apr 2022 08:35:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuBT-0007dM-6k
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:35:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 98f17de4-c472-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:35:01 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-TGjtCKQ_OQKiRzHTUvBcNw-1; Mon, 25 Apr 2022 10:35:00 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8472.eurprd04.prod.outlook.com (2603:10a6:20b:417::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:34:58 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:34:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98f17de4-c472-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875701;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=E1iCV10YdTuovGxw8Kec93Mw/xo3l/7mx9DOj2uTyh8=;
	b=J7zjSz9JwdWhrxjiuTlsMbfBpTRXnf19Nm7ir1jB3cpewXdL63uUo3LiTB+vGFY8xugr+U
	cjp9xF1xSKCvTrUSIob2FvWn93bnhb68qVdp9WxEcRtAkfxwAWl2rP0qyeVuL1fz9VQ4Ug
	DmWx1uXTpgz6ugHrR600ldp9M0bcaQs=
X-MC-Unique: TGjtCKQ_OQKiRzHTUvBcNw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f3Sa5bfKpgTCEOpPcMYwB0jq3E04t72ZZsem0OFXfZei7itp8aMTXq5rXuMwQc+jEKq9WSLOLzjUR6roY1GI0w3ZxMwZaduDy9l/6jl3zyWzSGaGyYW4bU8JggF6zo7s0vKonKNQQDJiMdbg/mUXEdM9+kUIt5YRq3t4nb8978d1cTrSQ1eGlxK6U2vquSQMfVHkxUCekn0egr2daUbdR1mtUx3Gp5ze+y6Bz53jIS213pgRNPy3GPRc2l1ySoe+aMmbbKXWSb4lzGFRAqQhVl1dKDHQIbFFwDJkfAu5iCb5e4GjACjiVsT/B8awzgGXbA3ILGiunhMsk6hyBe5V0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E1iCV10YdTuovGxw8Kec93Mw/xo3l/7mx9DOj2uTyh8=;
 b=UDxChBSa4v1D2I3/anjHuuemSccXKvAS00E+p73TmjN6Yj7DWIkDsT6zTE/SyvZM5YO0gyUT5u5LqC3RLk5zdzvm9tTf+/k96Aimwci5d0QJQqMddK9Jt9Ta8Np/51Qid/jgkOW0AifSeN9Mv0HWTb1H1pJcX81WIrb3Pj8SrRBWbXElrZh0fbtJ6R1itGrzjC52LIUK5w3X69uctAYFD8p9D73FHQi86sb5HQSUIGDxCYm1nRvanmTKCqbbEbjaAYDAfUM8R6A+SAFiw041S4OgnjjX4v7Py8tC2AkFp2xVJZjQq9LihGhzCgO8rIbfHbQ4O/g4HrFIGL8ps/YFTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f85a5557-3483-8135-ff47-a15474aaebb4@suse.com>
Date: Mon, 25 Apr 2022 10:34:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 06/21] IOMMU/x86: perform PV Dom0 mappings in batches
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0028.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9bedd4c9-2a8f-46dd-9946-08da26967b77
X-MS-TrafficTypeDiagnostic: AM9PR04MB8472:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8472EA63662CE9297E85B1B5B3F89@AM9PR04MB8472.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	74HVRLekGw92SypuC8yRZY8jqZ4WwKoKix1F8N/GccxYasZ6XN0oyMfbaW4dLYH8GNzqA9//ldCIVixNYeEZIiswQzyH4GtrFwYznUuphI+MQB0aEFly7RBdcDI+TV8K2xPe3Ao5ICmYKr7keq77xBxvqU4cyzW2EPsKGeJRc4VTCmk4V+nGTG0pifxsKSmxA8G4R7bJFrQeygD56OOoZkfRQoOwPv5OAZk39oDbogEKpirGcL8Zd/xcnOaYYbwjq7tUZEbk+WnOPpXZD3tBQmQPmszCL+tlx4HG5fjLDi/xFbhN1qZtUno2r0cVxMsQGOUiJeqnRWL/WIN5inArNDvxKX75DbQGw9gegOCztIJiYUuMrxncdpE8yRN7TH2yId6SjO8ULtsT49XCliGsVZgAmV7KIPF9nYR6nFAYF8KHr4OZNPyXOOUuvGGaxNjBqcCyo1gfo0YOApkvPQNKdu6lKDAjUcVlawQDhOBz0jDluAxjFE05/GdnAjTRgl2ktAINS03Ykw5eAHo9gOZPKXy3wS/Wm9WXnar1NQuqOWlyi/79OC8RYgS3B+Xd/LFNBbIMtDULwAmJxDZu2RA4ZQbxKJgFT2OZEIbE9R+qfuc3VRh8n9uH9Vb5qgGL+vXo31giNoGEa8ECAOYGLKeI9mtKE5Zo7eo0Yb+AKT72nxzH9W6fHwyscq3IssvJ5HtTRB8bO/2p8weZkcGYgfWrJ8QCre4kbX7j6meiiyZCfz4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(38100700002)(508600001)(31696002)(66476007)(6486002)(66556008)(26005)(36756003)(83380400001)(6506007)(31686004)(2616005)(6512007)(186003)(66946007)(2906002)(5660300002)(8936002)(8676002)(6916009)(30864003)(316002)(4326008)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SG1hL1Z5cXczeTZIRXM4amZBU29TK3RiSld4bFNIVEpZQS9iSTBmZFNxcVBl?=
 =?utf-8?B?aFI1blNZQ3YrUmc2TnUyRnpkcmlmMzhRbXdGRTVpcFNXTHFBb1dxaWMyWGtj?=
 =?utf-8?B?TXFGTmZlWWtoUUlZcjlCVmgzcnhKSy8zVDNWUHA2TnA3dHNwTWFKT1ZjcTRP?=
 =?utf-8?B?NldwcFdLdXBzZ1N3ZFJyMlZyVDdUcC9TaEx2eWFhOXBxNVZZRlJSYUw3K2VH?=
 =?utf-8?B?ZFg0WnZIOWJyR2hXdWp1ZHFRZ1Foa0RtYnVnYTZ2bWtvT3hCbUYzSHVKT3B2?=
 =?utf-8?B?U1RwSlppVkRGQmtJdHdsMnZibEkyZkU1ZUFCVi9wNXNyK245aGRybVpTUSsx?=
 =?utf-8?B?Mm1DTnMvVFdCQTc5V0REQXRQMXk2dXBudUpyT0w0YlE5bjlZbjBRMERPenpN?=
 =?utf-8?B?dDJkMlRsNm9SVmlKdXYzMnZDeTM3NUhTRjZQWnFGK1RaeDZDaCt1dGdBTC9N?=
 =?utf-8?B?T2dNQUxtclNXQzZmY0lGNnRKSS9yTzNQbHY4Zk1JcmhMZ3hXa1FFeS9ib0Ju?=
 =?utf-8?B?dzIydVVvUjB6ZzMwU05zeTFKSnZBdzZNV2Nrb3M1WEtBY3R1aS9ZeFN1Z3ow?=
 =?utf-8?B?d1FLM3N3a1hEU1FLQzd1MHAxMGNMWlEyam00dm5XSGJ4cDBjbWRsc1lyTG9X?=
 =?utf-8?B?SkhGQmlRUlpnSWNsc1pLcWRuRTYxN2hqd3JVZjhGYktTbzlPZ1BlYVJKeFJu?=
 =?utf-8?B?ODk2WnhlRCtHZ1NYQnVZSWlReCsxZnZ4Zm1oaFlEWFd1UXNaeFRrVHVxNWR6?=
 =?utf-8?B?dS94bmF2TC9mSHdBd2lST1J3d3d4Sy85ajFPWUZSbE1NUVhyQitoMVRvVXRF?=
 =?utf-8?B?eXFDeU1FbG42aXV5dUhXYXdiUDE2aVppdThVajBzZHJrTzdlYmtLcFNxbGx3?=
 =?utf-8?B?bWZQSEpiUTM3YTZscFJvVVJRaDNLTjlnbTYvWXF0NG9RMmJCTEh0TVl0T1Zl?=
 =?utf-8?B?Rm5SUW41aTg5ay8xR2w5Q01oUTBHV2pZVEg1Qm9wczcrdHdiUGFOZ0VpWGpl?=
 =?utf-8?B?SE1GUzVYWU1uMUtmWGJFNDRiaVVUZXdEYWdZL2k1ZVU2SnkwaW5oR1c4L093?=
 =?utf-8?B?QklXSnpwYzV0b0pvVVhtRGJjR1k4dFg4QnVOVGxZbkd1MWg1aERiWDZzOVJi?=
 =?utf-8?B?TFY0MDQ2SGloYXFYNDl4VFQyYjlPdmk4R1pOSmJwa3djR2pQOWVoMkJXVTdk?=
 =?utf-8?B?NXp0RzNNY0tkNStRVzBrT1BtRGJ5S2RrYittQis1RFdlY2xQclVwTE5HZndS?=
 =?utf-8?B?WGNSN1hoeTZtSzhiQlRQdURwcWptOGsvKzJYVXFDNEQ2K3pJZmkrMXVkblJJ?=
 =?utf-8?B?Q3VZR0RyeHpnT3FyRDYxOVRUK0tCSVN3YXhHZXhINXU1MytuN3Jyclgwb2d3?=
 =?utf-8?B?RkY3ekxZU1ozYThwTUlTS0h3UDh6em1sWFJUREo5VEpVblFtZnBDajFKaEE1?=
 =?utf-8?B?YTFRaUNHd09sOHFrdTVtRGk2K0dUdUtWSlBWTXB3ODd2MjFKNVZtdUVxbEo5?=
 =?utf-8?B?dFFzaklXWjZJZXJ2aWhpVUVSZS9UTG0zdnR1SEJFVG5GY0d4VjJxb3FLSUhO?=
 =?utf-8?B?VitEYXpsZFhkWGl3YWphNkdWTDNxOEs2Vm9LTDFqSmNVR0MvQzNXZmI3Ujgy?=
 =?utf-8?B?YVB1azBDQk5BSS80b2kzZytMdnpzZG42MDJ2S1ZiTzVhNUt6aEtRKzR2T05V?=
 =?utf-8?B?V0NUbWQ5OFlPT0VTSkF0UFczcnJqazBRa2tDcFRHUkdNSHZRK2R4a1NiT1Yz?=
 =?utf-8?B?VVczcCtnWFU1MFpVT1E4NDlNYlhJUUljWEpEVEdGQyt4MmZwbnNOZlR2dlZp?=
 =?utf-8?B?QXNNSzdyOWRwa1BTMTNSK3RpN2wrUmF1U1ZkUVhPUjFNV3F0S3FKMk1saHJj?=
 =?utf-8?B?MmxwY0tXZnlHMlBJN2FPOVhXUElUdWpMakdoRkhxYWZyM3pjZGhLQTk4Z1RJ?=
 =?utf-8?B?WStTdVFtZzY2dEt1S3cxdFJqZ1h1dG1CdWJ1anpUQWJGRVdYOGVxdnJWQzBo?=
 =?utf-8?B?cnVtQnM5R1g4MktSVzMyUjl0WE1OeUprRUFWRkFQcFF6N09aTG5NRVJLckNr?=
 =?utf-8?B?UFBBNTU2MFVBci9EdkFJNHYraDcyaHM2a3FNOEtaNHlQcXFTSkh3THV2aFJY?=
 =?utf-8?B?SE5DZ3M2TnNuNm1scDAxZG5GOWRTMkpWMjdpanRRSmZuTitaTzJ0Tzg5OEFx?=
 =?utf-8?B?RHBaeFFBVXoyNGhjcysrRVZVVmdySHkreDhHZDhmbDNlb0J3cWVmaUROc0dj?=
 =?utf-8?B?UWFSWElKdnl3ZnhxTGpBdEZ4RE4xTnpzSllzWUxLNy9JMHJiaXJDTW9mTDlU?=
 =?utf-8?B?UGYrS2JWRkhRMk1xRktDRUlBVEJJSHp1SXpxdTNmVkpMNHRManRhQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bedd4c9-2a8f-46dd-9946-08da26967b77
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:34:58.5668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ZQLsqdP5cYEGBq8qweGyDUC+SBI2TSXgW1IzH5GDRx1Q9cf3Rryfhkyu+zONrqe/1tEG2+mbXV4UKPliCAoQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8472

For large page mappings to be easily usable (i.e. in particular without
un-shattering of smaller page mappings) and for mapping operations to
then also be more efficient, pass batches of Dom0 memory to iommu_map().
In dom0_construct_pv() and its helpers (covering strict mode) this
additionally requires establishing the type of those pages (albeit with
zero type references).

The earlier establishing of PGT_writable_page | PGT_validated requires
the existing places where this gets done (through get_page_and_type())
to be updated: For pages which actually have a mapping, the type
refcount needs to be 1.

There is actually a related bug that gets fixed here as a side effect:
Typically the last L1 table would get marked as such only after
get_page_and_type(..., PGT_writable_page). While this is fine as far as
refcounting goes, the page did remain mapped in the IOMMU in this case
(when "iommu=dom0-strict").

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Subsequently p2m_add_identity_entry() may want to also gain an order
parameter, for arch_iommu_hwdom_init() to use. While this only affects
non-RAM regions, systems typically have 2-16Mb of reserved space
immediately below 4Gb, which hence could be mapped more efficiently.

The installing of zero-ref writable types has in fact shown (observed
while putting together the change) that despite the intention by the
XSA-288 changes (affecting DomU-s only) for Dom0 a number of
sufficiently ordinary pages (at the very least initrd and P2M ones as
well as pages that are part of the initial allocation but not part of
the initial mapping) still have been starting out as PGT_none, meaning
that they would have gained IOMMU mappings only the first time these
pages would get mapped writably. Consequently an open question is
whether iommu_memory_setup() should set the pages to PGT_writable_page
independent of need_iommu_pt_sync().

I didn't think I need to address the bug mentioned in the description in
a separate (prereq) patch, but if others disagree I could certainly
break out that part (needing to first use iommu_legacy_unmap() then).

Note that 4k P2M pages don't get (pre-)mapped in setup_pv_physmap():
They'll end up mapped via the later get_page_and_type().

As to the way these refs get installed: I've chosen to avoid the more
expensive {get,put}_page_and_type(), favoring to put in place the
intended type directly. I guess I could be convinced to avoid this
bypassing of the actual logic; I merely think it's unnecessarily
expensive.

Note also that strictly speaking the iommu_iotlb_flush_all() here (as
well as the pre-existing one in arch_iommu_hwdom_init()) shouldn't be
needed: Actual hooking up (AMD) or enabling of translation (VT-d)
occurs only afterwards anyway, so nothing can have made it into TLBs
just yet.
---
v3: Fold iommu_map() into (the now renamed) iommu_memory_setup(). Move
    iommu_unmap() into mark_pv_pt_pages_rdonly(). Adjust (split) log
    message in arch_iommu_hwdom_init().

--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c
@@ -46,7 +46,8 @@ void __init dom0_update_physmap(bool com
 static __init void mark_pv_pt_pages_rdonly(struct domain *d,
                                            l4_pgentry_t *l4start,
                                            unsigned long vpt_start,
-                                           unsigned long nr_pt_pages)
+                                           unsigned long nr_pt_pages,
+                                           unsigned int *flush_flags)
 {
     unsigned long count;
     struct page_info *page;
@@ -71,6 +72,14 @@ static __init void mark_pv_pt_pages_rdon
         ASSERT((page->u.inuse.type_info & PGT_type_mask) <= PGT_root_page_table);
         ASSERT(!(page->u.inuse.type_info & ~(PGT_type_mask | PGT_pae_xen_l2)));
 
+        /*
+         * Page table pages need to be removed from the IOMMU again in case
+         * iommu_memory_setup() ended up mapping them.
+         */
+        if ( need_iommu_pt_sync(d) &&
+             iommu_unmap(d, _dfn(mfn_x(page_to_mfn(page))), 1, flush_flags) )
+            BUG();
+
         /* Read-only mapping + PGC_allocated + page-table page. */
         page->count_info         = PGC_allocated | 3;
         page->u.inuse.type_info |= PGT_validated | 1;
@@ -107,11 +116,43 @@ static __init void mark_pv_pt_pages_rdon
     unmap_domain_page(pl3e);
 }
 
+static void __init iommu_memory_setup(struct domain *d, const char *what,
+                                      struct page_info *page, unsigned long nr,
+                                      unsigned int *flush_flags)
+{
+    int rc;
+    mfn_t mfn = page_to_mfn(page);
+
+    if ( !need_iommu_pt_sync(d) )
+        return;
+
+    rc = iommu_map(d, _dfn(mfn_x(mfn)), mfn, nr,
+                   IOMMUF_readable | IOMMUF_writable, flush_flags);
+    if ( rc )
+    {
+        printk(XENLOG_ERR "pre-mapping %s MFN [%lx,%lx) into IOMMU failed: %d\n",
+               what, mfn_x(mfn), mfn_x(mfn) + nr, rc);
+        return;
+    }
+
+    /*
+     * For successfully established IOMMU mappings the type of the page(s)
+     * needs to match (for _get_page_type() to unmap upon type change). Set
+     * the page(s) to writable with no type ref.
+     */
+    for ( ; nr--; ++page )
+    {
+        ASSERT(!page->u.inuse.type_info);
+        page->u.inuse.type_info = PGT_writable_page | PGT_validated;
+    }
+}
+
 static __init void setup_pv_physmap(struct domain *d, unsigned long pgtbl_pfn,
                                     unsigned long v_start, unsigned long v_end,
                                     unsigned long vphysmap_start,
                                     unsigned long vphysmap_end,
-                                    unsigned long nr_pages)
+                                    unsigned long nr_pages,
+                                    unsigned int *flush_flags)
 {
     struct page_info *page = NULL;
     l4_pgentry_t *pl4e, *l4start = map_domain_page(_mfn(pgtbl_pfn));
@@ -177,6 +218,10 @@ static __init void setup_pv_physmap(stru
                                              L3_PAGETABLE_SHIFT - PAGE_SHIFT,
                                              MEMF_no_scrub)) != NULL )
             {
+                iommu_memory_setup(d, "P2M 1G", page,
+                                   SUPERPAGE_PAGES * SUPERPAGE_PAGES,
+                                   flush_flags);
+
                 *pl3e = l3e_from_page(page, L1_PROT|_PAGE_DIRTY|_PAGE_PSE);
                 vphysmap_start += 1UL << L3_PAGETABLE_SHIFT;
                 continue;
@@ -203,6 +248,9 @@ static __init void setup_pv_physmap(stru
                                              L2_PAGETABLE_SHIFT - PAGE_SHIFT,
                                              MEMF_no_scrub)) != NULL )
             {
+                iommu_memory_setup(d, "P2M 2M", page, SUPERPAGE_PAGES,
+                                   flush_flags);
+
                 *pl2e = l2e_from_page(page, L1_PROT|_PAGE_DIRTY|_PAGE_PSE);
                 vphysmap_start += 1UL << L2_PAGETABLE_SHIFT;
                 continue;
@@ -311,6 +359,7 @@ int __init dom0_construct_pv(struct doma
     unsigned long initrd_pfn = -1, initrd_mfn = 0;
     unsigned long count;
     struct page_info *page = NULL;
+    unsigned int flush_flags = 0;
     start_info_t *si;
     struct vcpu *v = d->vcpu[0];
     void *image_base = bootstrap_map(image);
@@ -573,6 +622,9 @@ int __init dom0_construct_pv(struct doma
                     BUG();
         }
         initrd->mod_end = 0;
+
+        iommu_memory_setup(d, "initrd", mfn_to_page(_mfn(initrd_mfn)),
+                           PFN_UP(initrd_len), &flush_flags);
     }
 
     printk("PHYSICAL MEMORY ARRANGEMENT:\n"
@@ -606,6 +658,13 @@ int __init dom0_construct_pv(struct doma
 
     process_pending_softirqs();
 
+    /*
+     * Map the full range here and then punch holes for page tables
+     * alongside marking them as such in mark_pv_pt_pages_rdonly().
+     */
+    iommu_memory_setup(d, "init-alloc", mfn_to_page(_mfn(alloc_spfn)),
+                       alloc_epfn - alloc_spfn, &flush_flags);
+
     mpt_alloc = (vpt_start - v_start) + pfn_to_paddr(alloc_spfn);
     if ( vinitrd_start )
         mpt_alloc -= PAGE_ALIGN(initrd_len);
@@ -690,7 +749,8 @@ int __init dom0_construct_pv(struct doma
         l1tab++;
 
         page = mfn_to_page(_mfn(mfn));
-        if ( !page->u.inuse.type_info &&
+        if ( (!page->u.inuse.type_info ||
+              page->u.inuse.type_info == (PGT_writable_page | PGT_validated)) &&
              !get_page_and_type(page, d, PGT_writable_page) )
             BUG();
     }
@@ -719,7 +779,7 @@ int __init dom0_construct_pv(struct doma
     }
 
     /* Pages that are part of page tables must be read only. */
-    mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages);
+    mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages, &flush_flags);
 
     /* Mask all upcalls... */
     for ( i = 0; i < XEN_LEGACY_MAX_VCPUS; i++ )
@@ -794,7 +854,7 @@ int __init dom0_construct_pv(struct doma
     {
         pfn = pagetable_get_pfn(v->arch.guest_table);
         setup_pv_physmap(d, pfn, v_start, v_end, vphysmap_start, vphysmap_end,
-                         nr_pages);
+                         nr_pages, &flush_flags);
     }
 
     /* Write the phys->machine and machine->phys table entries. */
@@ -825,7 +885,9 @@ int __init dom0_construct_pv(struct doma
         if ( get_gpfn_from_mfn(mfn) >= count )
         {
             BUG_ON(compat);
-            if ( !page->u.inuse.type_info &&
+            if ( (!page->u.inuse.type_info ||
+                  page->u.inuse.type_info == (PGT_writable_page |
+                                              PGT_validated)) &&
                  !get_page_and_type(page, d, PGT_writable_page) )
                 BUG();
 
@@ -841,8 +903,12 @@ int __init dom0_construct_pv(struct doma
 #endif
     while ( pfn < nr_pages )
     {
-        if ( (page = alloc_chunk(d, nr_pages - domain_tot_pages(d))) == NULL )
+        count = domain_tot_pages(d);
+        if ( (page = alloc_chunk(d, nr_pages - count)) == NULL )
             panic("Not enough RAM for DOM0 reservation\n");
+
+        iommu_memory_setup(d, "chunk", page, domain_tot_pages(d) - count,
+                           &flush_flags);
         while ( pfn < domain_tot_pages(d) )
         {
             mfn = mfn_x(page_to_mfn(page));
@@ -857,6 +923,10 @@ int __init dom0_construct_pv(struct doma
         }
     }
 
+    /* Use while() to avoid compiler warning. */
+    while ( iommu_iotlb_flush_all(d, flush_flags) )
+        break;
+
     if ( initrd_len != 0 )
     {
         si->mod_start = vinitrd_start ?: initrd_pfn;
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -347,8 +347,8 @@ static unsigned int __hwdom_init hwdom_i
 
 void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
 {
-    unsigned long i, top, max_pfn;
-    unsigned int flush_flags = 0;
+    unsigned long i, top, max_pfn, start, count;
+    unsigned int flush_flags = 0, start_perms = 0;
 
     BUG_ON(!is_hardware_domain(d));
 
@@ -379,9 +379,9 @@ void __hwdom_init arch_iommu_hwdom_init(
      * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid
      * setting up potentially conflicting mappings here.
      */
-    i = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0;
+    start = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0;
 
-    for ( ; i < top; i++ )
+    for ( i = start, count = 0; i < top; )
     {
         unsigned long pfn = pdx_to_pfn(i);
         unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn);
@@ -390,20 +390,41 @@ void __hwdom_init arch_iommu_hwdom_init(
         if ( !perms )
             rc = 0;
         else if ( paging_mode_translate(d) )
+        {
             rc = p2m_add_identity_entry(d, pfn,
                                         perms & IOMMUF_writable ? p2m_access_rw
                                                                 : p2m_access_r,
                                         0);
+            if ( rc )
+                printk(XENLOG_WARNING
+                       "%pd: identity mapping of %lx failed: %d\n",
+                       d, pfn, rc);
+        }
+        else if ( pfn != start + count || perms != start_perms )
+        {
+        commit:
+            rc = iommu_map(d, _dfn(start), _mfn(start), count, start_perms,
+                           &flush_flags);
+            if ( rc )
+                printk(XENLOG_WARNING
+                       "%pd: IOMMU identity mapping of [%lx,%lx) failed: %d\n",
+                       d, pfn, pfn + count, rc);
+            SWAP(start, pfn);
+            start_perms = perms;
+            count = 1;
+        }
         else
-            rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
-                           perms, &flush_flags);
+        {
+            ++count;
+            rc = 0;
+        }
 
-        if ( rc )
-            printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n",
-                   d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc);
 
-        if (!(i & 0xfffff))
+        if ( !(++i & 0xfffff) )
             process_pending_softirqs();
+
+        if ( i == top && count )
+            goto commit;
     }
 
     /* Use if to avoid compiler warning */



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:36:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:36:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312522.529797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuDA-0008PB-E4; Mon, 25 Apr 2022 08:36:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312522.529797; Mon, 25 Apr 2022 08:36:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuDA-0008P4-A8; Mon, 25 Apr 2022 08:36:48 +0000
Received: by outflank-mailman (input) for mailman id 312522;
 Mon, 25 Apr 2022 08:36:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuD8-0008Oy-SG
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:36:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6e6387d-c472-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:36:45 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-gSnVVsnVNa-CbtIEbv3wKA-1; Mon, 25 Apr 2022 10:36:43 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR0402MB3831.eurprd04.prod.outlook.com (2603:10a6:209:19::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:36:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:36:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6e6387d-c472-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875805;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BtcZhyZ3f1vF1sJNNT1uwgtm+sm1Ld+qz9aFACUX3vg=;
	b=gYkQ4TjBGzw6RvBgD/EigooTehKz7XibdXx5mTnm0q5SrGFdjN9apTNlVmOhXH76zlMn5b
	GVnyRrpZY5JzQrqbnY0+uOVM5R96k6yMRDXvPJh6N7Qo7AYQJQxRqvAPygTiueXUxFRulx
	785+8mJkxElXusUaX1G2ZtHDe3CGeZA=
X-MC-Unique: gSnVVsnVNa-CbtIEbv3wKA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XdNXV77H1NXVLu3v1tX98yi5giqrhi1AVSWRKpIeJDImc59aqNeb1coPEGfr9PadNvQBThoYp3+JTZpR3S5Q+UL4s6CRgGdWz5qPmBvaFP8MWAK1IvqS/6ZUCFQuwSwY301oZ//Jd2XMM0gPR3K3k4q2XCrFI9Ko2TiGaSsvBYoObjAFIDyEv2fGDqfMVSRU7NxBBR11ts8OtPXie1qlOtK4WvqtAnrqWuY13Bii81DBPoyTB6aIAyq7tcRGXAJwVq+ELq+ocjNMVi+4zocQ9vHZhKNj79oZu7jDkt2bUT8ybXcmVg/QYMfTPKq+NXrvovjtrucdaJdNahZUf91Xhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BtcZhyZ3f1vF1sJNNT1uwgtm+sm1Ld+qz9aFACUX3vg=;
 b=GvKxR8c/dwRcqKyi34eO0hf+wIesvubCyO5d1FCLYVZV24GlKBrUaRhSjYFSmYtNjByxYrt57Gwhc2nFdQaStJxT0IKWl1Cs8uJ9lMsM+49APqZKVxUPXymZWR3QL7mfvy4KnRDVIh4NG7N1Arb3s0cYaSfl1/BNm6J/Qev1aUpB3yXsWWYZsbcldjupgGD8Z0JuqHNvCSV55/RSsTbqxfz7joIEx+0Ac70FHbbH/x9/PXAIPf4ZOxVQ8miQ9IdDykdFQBzUpY5jGZP2IrHQUB0ql9k1fZkKQjTUWRkIV0U7xTVai3JLdPH81BTSb4KzcJzB9o8HZo664s/qaLZZWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bc32c611-53cb-8c4c-1f97-355d58efad4d@suse.com>
Date: Mon, 25 Apr 2022 10:36:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 08/21] AMD/IOMMU: walk trees upon page fault
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0101CA0011.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 92e83e9d-ff7c-4cdf-3ddc-08da2696b908
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3831:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB38316B0FE0523F20657DA3FCB3F89@AM6PR0402MB3831.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xm7dGnj4lg4cYqZJgka0kXEATUj/KgewnOFgpQ1hn4GyZ9KuepI5SA64E0xUAq5nNwYL4OePaBatCPsNN8dAL8abJH4i4io9Fxw26kZSSkQl9X3d+FUwm29PvsJf32CWCcCyI6M+6vEtbBPD8wDzuHEu9LAMgXQzCO6ybIrrtcwn6OAzF9FvtjxQCPVi0xdPZYD11F5VCFiJuBBc6XI076oKYX8uvUVaAwWCMHGTxmSm1mNW/CQ30q+CnxjfW3O08t4X0rZrANGUzuFT2i603cROf1yMy4wvNf59epwjXXNrZ4uDwLGlArnZwzmTe4qxOkBpCIZBJxRVk6s5apRE3MehNAaUKmG9/MFJzvI636QHvE5ZtTZk3gYnNre4X6ux0qU/NSaBaq2hrU5an/BticdVztwy7u+uqFxdzr0UvTvbB0+ESQKNot3sEPEeDJbnjfqnBeqC7rTKriGFpBLAjPNoPYPdFgygzvT1zMTJQXal+73JVXD6Sp1H1sNdZVA530fMpAGjsD4rQphOcMoG0IsNeJzggkVS8fuaWMiHr4LzEiEG1pDVJuNiBZO0JI9XUQk4tyQpc9zXO1sx1zFfpOHjXWeb7/lS/lUWdy7g4wdR6kmN189zZxf2Osbk5j2wfup1jfBRpxfdFTIAcHrlLIFEU9NlyG4DetNEKo6Hn+sYyGg4YqixzuHA7rHa2LUR4kroaKGjybyws/Mtr0oO1HN4wQKrUfzgbdziEW8Z9N4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(2906002)(66556008)(4326008)(8676002)(38100700002)(5660300002)(508600001)(6486002)(6916009)(8936002)(54906003)(2616005)(31686004)(66476007)(36756003)(316002)(186003)(31696002)(86362001)(6506007)(26005)(83380400001)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NURQQ3ZrNlhGSldiL2pQemd5dmdXWEV3b3VhOE1Yb2NZamQ2Q0o0MHlVQ3hW?=
 =?utf-8?B?dnk3VEEwcS90NmIrenZsWWJaSHBRYllIQU1wS0VjQ0pFaitYenpORDJhNDhh?=
 =?utf-8?B?TTZXRXpDaW1SdHlUWG5aREVUZ21kMm5iTWFGSkVSWVhYdXdpR1RDYVRHeTJH?=
 =?utf-8?B?aVhZRHh5RnU2NFl5Z0FyZHNmYzZ5ZmJaTW8vTEpqY3NxckRlUE9TRUg4Q1J1?=
 =?utf-8?B?VUszNi9YN3hMbGRnSE0wRTBBazdvdlpKZlAvbWdlUTc2d2dwZCtPZGh4cDkx?=
 =?utf-8?B?VlhGQzQ3bU14NVVmcnZnSWpTaGZ3SmNPQytWUDYrR3k2Qk91NEZpVnVZcGlK?=
 =?utf-8?B?OXh3c2tjSzg4NDhrd0lzNW9hMWp3SWJ1b3pYSk5UaEwxcmxnR2dmTytBRkxK?=
 =?utf-8?B?SzRYaVgzTVg3bzQ4VStBWm1iS0FqS1NBVlg3S0dOMXVZZkJXK0FGRDhqQlZC?=
 =?utf-8?B?K0RBT2lHY3BDZ2FEV0cySFZEYWxiMDJSOEh2SmF5bWY4RzNvK0ZYVHdOZks0?=
 =?utf-8?B?TnVxZmxwVEVUcjZTOGZ2Sm9BR1kvclJJSnRsTzRRMzhTbEcwdE4zVU1yam5n?=
 =?utf-8?B?UzUzM28wM3R6eWJoLzVUbU9PbmtXWWRTS0JNQzFTQ254bExJZXByQllWekxN?=
 =?utf-8?B?V1RjTS9RTUxiQkhTVUNFcWh2cXp6RlZqSXo2NERQY0FiOHlwK250dTNqRXJz?=
 =?utf-8?B?ZjlIYWhNd0RaVTFHcTJHU3lvUVRUODNtSVVDc2FtU2k3OFJ4eWZoOVdRL1p0?=
 =?utf-8?B?c09qVXRrOXhjczN6VHZ1WXI5OWF4VGpiR04ySHRibUhJMFNHUTVCN2VHV3pW?=
 =?utf-8?B?YloyQW5yNW5nWGd1aXl6UExkbmlNYVIrbFoxeDZucEc0bEQ3bERQL3k2a01h?=
 =?utf-8?B?S1hFN0psWGNadmJwQnhyd2Nhd2d2ajVwTVVNMjhCdTM1MEY2M0NBMm85TkR1?=
 =?utf-8?B?UFRPTlRrQStWQ3V1RWl1bUNXS3NKQVlDU2M4N251b3cwcTVkZlVjL3JrS1Nz?=
 =?utf-8?B?TytNbHUwRXNQaC8xMHJCVzFETDVQWFhybnAxeXdNeEF6NVN2VU5UZm04Q3Vj?=
 =?utf-8?B?aGxWVDYxdy9ZUGhWR2Vwa3Vkb1NTeWo0SEpNdHpZUWZnQUUxbkNVa09jbFBX?=
 =?utf-8?B?MURLcWlRU3I1K29xa0lWeURUYnZINUxwaXFQcjR5UjQ3K2lzVVhyQmhRYzJK?=
 =?utf-8?B?Y2QvVFNtODF0K3drR0l1ZmNkRkQ5U1pSK2c4QjJjNEU1OXBVYjlUTGxLckpm?=
 =?utf-8?B?YmRFY2NKWWRqcW9nVFA3ejgxUk9WUjdieXhkWnA0WU1pbEdMOVAvZGtqaEhF?=
 =?utf-8?B?dXhmaUpPU1piekFnWU9vR2U0L2orSXB5M1JjR0hEd1V3by9TbWEvUzFvM2JN?=
 =?utf-8?B?QUF2ciszNjY0OHlsVWQ0U21EcGNqeUlQQTBsY0M2MnVwOFEwQ1R6QXlaSUI0?=
 =?utf-8?B?Y0VDZ2FWc3c3dy9zUEJhWlgza2ZjbUx1Q0V6R3d1dnRLcjEzd1ZZVU1CNzBt?=
 =?utf-8?B?MnpZR3dEWnQyTEZwOWhWZzRxdFR6cHdTekVmeHRZWmJUWWFTTUVCU2puNG1P?=
 =?utf-8?B?a2NSbmZMbnRmeTY1Sk8rYlU1Q3N6K0Z5Yy9lUC9iNTRwK1ZLeEcrdXMxM0lH?=
 =?utf-8?B?dm5zajlrUjI1N0Y0V0k5TDh6Qk1VSFpUWlArbnRkVXVyQ05XeHlrS0xoRytN?=
 =?utf-8?B?bGZ2SUVWUjRkYWYydmc0SmowZnppWlFSb3ZFbVBXNmVNeFh0OEUrdTlPU3A0?=
 =?utf-8?B?YUt6c2YyMk5IOVh3ZUttTmtNRWMxRmQveUdYaWVQR3YydnZ2S0F3VllaUyt3?=
 =?utf-8?B?OGdtVHdqMndiZXNyb1dkKythektPaVNhN3ZNcmxtRE9vYVJvalZ6S2dEenNV?=
 =?utf-8?B?YVhhNzVGSGhQMytLR0VqNGE1SkEydmUwSFA1UnQ3MkdBSG11KzNjdDNNelBo?=
 =?utf-8?B?cHlKWFJVakVhY0xKdTB4Qm01T3lHeExNckExL0xqSXlLUlNGUFBqVWpxVm9E?=
 =?utf-8?B?dFJmTjJRc1FzejhMNmJmTGxNS0Fkb2tWb0dhVDcrOU15bjRneFBJaW1lQUR5?=
 =?utf-8?B?T0dOOVdkYTlRazlBc2xOUmpjVkhlRjhEcWYxL1lPRHlhaVlaNmxRSUM5cHdR?=
 =?utf-8?B?aHVKK00yb1czUkM4WVJCNkswT04xUENLQUFtNUNXcnppRThGeGtRYkNrQm56?=
 =?utf-8?B?endNbkRndW1ZL1JraWtUS25lbVNod0ZoVEZQck5tbHhRRHN3YXQxeGpBMCtr?=
 =?utf-8?B?SUpvSVlCZGVPYm9iWDBIRTBQeDdqbGtjdHNDK0czSktOVkt0M3k5NFlqQlJS?=
 =?utf-8?B?Z2kwbk91VEdXSGtjdTFpN1BYOTMrU25KZnRQeUlkUDE4bUdVNk90Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92e83e9d-ff7c-4cdf-3ddc-08da2696b908
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:36:41.8402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l5c2buF642afHOntxQfEsIvR329//ygv1CjYXrIANgUDdYiUPcb8pamR7nb+4pTEpy9uuyUZswXAHuXCAjJ5ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3831

This is to aid diagnosing issues and largely matches VT-d's behavior.
Since I'm adding permissions output here as well, take the opportunity
and also add their displaying to amd_dump_page_table_level().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Note: "largely matches VT-d's behavior" includes the lack of any locking
      here. Adding suitable locking may not be that easy, as we'd need
      to determine which domain's mapping lock to acquire in addition to
      the necessary IOMMU lock (for the device table access), and
      whether that domain actually still exists. The latter is because
      if we really want to play safe here, imo we also need to account
      for the device table to be potentially corrupted / stale.
---
v4: Re-base.

--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -259,6 +259,8 @@ int __must_check cf_check amd_iommu_flus
     struct domain *d, dfn_t dfn, unsigned long page_count,
     unsigned int flush_flags);
 int __must_check cf_check amd_iommu_flush_iotlb_all(struct domain *d);
+void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int dev_id,
+                             dfn_t dfn);
 
 /* device table functions */
 int get_dma_requestor_id(uint16_t seg, uint16_t bdf);
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -575,6 +575,9 @@ static void cf_check parse_event_log_ent
                (flags & 0x002) ? " NX" : "",
                (flags & 0x001) ? " GN" : "");
 
+        if ( iommu_verbose )
+            amd_iommu_print_entries(iommu, device_id, daddr_to_dfn(addr));
+
         for ( bdf = 0; bdf < ivrs_bdf_entries; bdf++ )
             if ( get_dma_requestor_id(iommu->seg, bdf) == device_id )
                 pci_check_disable_device(iommu->seg, PCI_BUS(bdf),
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -428,6 +428,50 @@ int cf_check amd_iommu_unmap_page(
     return 0;
 }
 
+void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int dev_id,
+                             dfn_t dfn)
+{
+    mfn_t pt_mfn;
+    unsigned int level;
+    const struct amd_iommu_dte *dt = iommu->dev_table.buffer;
+
+    if ( !dt[dev_id].tv )
+    {
+        printk("%pp: no root\n", &PCI_SBDF(iommu->seg, dev_id));
+        return;
+    }
+
+    pt_mfn = _mfn(dt[dev_id].pt_root);
+    level = dt[dev_id].paging_mode;
+    printk("%pp root @ %"PRI_mfn" (%u levels) dfn=%"PRI_dfn"\n",
+           &PCI_SBDF(iommu->seg, dev_id), mfn_x(pt_mfn), level, dfn_x(dfn));
+
+    while ( level )
+    {
+        const union amd_iommu_pte *pt = map_domain_page(pt_mfn);
+        unsigned int idx = pfn_to_pde_idx(dfn_x(dfn), level);
+        union amd_iommu_pte pte = pt[idx];
+
+        unmap_domain_page(pt);
+
+        printk("  L%u[%03x] = %"PRIx64" %c%c\n", level, idx, pte.raw,
+               pte.pr ? pte.ir ? 'r' : '-' : 'n',
+               pte.pr ? pte.iw ? 'w' : '-' : 'p');
+
+        if ( !pte.pr )
+            break;
+
+        if ( pte.next_level >= level )
+        {
+            printk("  L%u[%03x]: next: %u\n", level, idx, pte.next_level);
+            break;
+        }
+
+        pt_mfn = _mfn(pte.mfn);
+        level = pte.next_level;
+    }
+}
+
 static unsigned long flush_count(unsigned long dfn, unsigned long page_count,
                                  unsigned int order)
 {
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -724,10 +724,11 @@ static void amd_dump_page_table_level(st
                 mfn_to_page(_mfn(pde->mfn)), pde->next_level,
                 address, indent + 1);
         else
-            printk("%*sdfn: %08lx  mfn: %08lx\n",
+            printk("%*sdfn: %08lx  mfn: %08lx  %c%c\n",
                    indent, "",
                    (unsigned long)PFN_DOWN(address),
-                   (unsigned long)PFN_DOWN(pfn_to_paddr(pde->mfn)));
+                   (unsigned long)PFN_DOWN(pfn_to_paddr(pde->mfn)),
+                   pde->ir ? 'r' : '-', pde->iw ? 'w' : '-');
     }
 
     unmap_domain_page(table_vaddr);



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:37:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:37:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312525.529807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuDX-0000Ru-Na; Mon, 25 Apr 2022 08:37:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312525.529807; Mon, 25 Apr 2022 08:37:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuDX-0000Rn-KF; Mon, 25 Apr 2022 08:37:11 +0000
Received: by outflank-mailman (input) for mailman id 312525;
 Mon, 25 Apr 2022 08:37:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuDW-0008Oy-HA
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:37:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e51cd92e-c472-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:37:09 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-lhSQmLnTMdCSD3zsMAdqNw-1; Mon, 25 Apr 2022 10:37:07 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR0402MB3831.eurprd04.prod.outlook.com (2603:10a6:209:19::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:37:06 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:37:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e51cd92e-c472-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875829;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3svnu4oijNxO7SygTj1nIXI23Kv+KFJWpuZLxXqiiHk=;
	b=I3hoD7Yv80OcqzwbG1oXA6nUgQ+8Lpyt27WC50E/gad9mke2KnP3k+o5fiGiDuz/HnTuix
	r8BZPBU6ZYidpq5NuuRuM1P1UfxC1Vsu2TOm8LasJGNAmAH+dXY+EbuDQtgaXuuASupGY9
	SKs2NMpvZgX9tA7tIwyyRKw5sYCGsSM=
X-MC-Unique: lhSQmLnTMdCSD3zsMAdqNw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yvn6mRihD2sGvl+cQB3Q+DdgpxcOpwwUhlSBU/VWrlEGXHaKwZUPLG/wX7+CtLGFnv8YUj5LQ4LVHbQB7ZmZWR20mq+BCthfC7v2r4DTBp0DgAMfNruIkxHWR2R1vBg5AbJWEr/AHcalqARlSo/KLUCd04w5Z/04RHZjosiIL8AvyhWGJgS2ogmsGFoEs1UfiyIpDOiiguAD6RDBecGq/DCUO2udZNpaB7bi81cJvAbOwNDqma/QcfYYu0cAXDsLwxgp2UOIK+3IK72wXwcax9Q7tfjTJL7PmSoML5Z5Z7S2mw5eXbvHSFWm5+LeOTPSK30jKxfsYIDa/ZGqXdsmEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pJ/rcnHk48J2486MfEcTZdg7UhutmuOyywKelNyvVqw=;
 b=ZDHOkMHf20ORZOnUx7Q7vZHa8U2C2MtjwHwpd10T//5EiSFNauZMHLVqKeWNgjedTDWqjSw4EFlAGzv+SWlgqF0vWLAItJWYwJLDQzpmbRGZjQAYWQDlGqBc5wR8+AHUCwPg6OwZoz+ur6uMWpQGgUQd1ZqxJk3Ak/hMetYn0psdvYD6MLEsrE7sTHxCpJ45fAZbZDTyfQ83Z4h3WWbvxFHiAPFF+BFocsR6+bgNTZ0hmbjGosxJRZafv+SorTNcZVT6ZliUlFMJcopMuMq6IX2tXO3V5V4WevRXkJ/KuW5ZOyvBGlKVxOPhAOJ/PtO4xwJQPOW+i0/ZbmGfxB/AUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f5a0dffd-ec55-3b99-0eba-418d96dc4151@suse.com>
Date: Mon, 25 Apr 2022 10:37:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 09/21] AMD/IOMMU: return old PTE from
 {set,clear}_iommu_pte_present()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0066.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::11) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c68f9848-db3b-4065-c36a-08da2696c75e
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3831:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3831F2A8E5599EB1953F1F5FB3F89@AM6PR0402MB3831.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rrXWuFSVB2Ikn/Fsk7GLk4OKZXbfgWj1niR1mP5y1gIUMISAVCEYcv/lk3pypisCCKnogU4NK9uWRU3+oQptvYiHzVaGrlFCb8ByOHUDXsbnsSRkvUpk9+3KG2v7rstvqG2ZBtJR1z38h6zpZYgpsseogWjYhKQEJGm4g4YdUeISJ2yialnS/dNi4vC+weSYwDE66adtFiubACGeB/WBLZaJkONAJo9HB6j2jnZ/Q+n4RVGTFbRGeG88vhxYSNV6f31na/pf6L79wSsj8adX747IKf2Uf6MgTLBopD3lPPlFKeeq2ZqBsnka5eaXH6SgtSTttP5UpwodC9D2Sl2jdGxHtg/jUOXtgnzQ93YXC49rGW62c4Fn8FVCPNhEGhf2FGb6fXq6FAV19z812evuebkr9sbTsLDHRYP5q5s2cyTO5tGEnbNcHcbcgWNj9z++xG0Xh50i27hm6bhUQ6cOsyzkEx9t2UhrbqDgKdY2qsckTzU1qquW7KnZW0OjbHzRj/MRRoOx9l/zTCVl6fBT9c8QOSVSg8U5uDpi9teZKOjZ0cfsStH64l7n3Wjj3WIs/qxFFP9YNjNvJHUCKsjtedWOSjn4NiO+DygoI7EkdkJ4Cs/OIVPC2IA0G3dhh2iCFJmG/SSZodbr1KXiOkCqJ9BEtKSbPGvj5tcI6CVB8tGDLvdM5xlOdB+T2HiRevxHsx3oyswl/zyiB8XyMIrBOjvTSnmrtN1hhsZzA1TPf7g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(2906002)(66556008)(4326008)(8676002)(38100700002)(5660300002)(508600001)(6486002)(6916009)(8936002)(54906003)(2616005)(31686004)(66476007)(36756003)(316002)(186003)(31696002)(86362001)(6506007)(26005)(83380400001)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?QpvxNlTRvthqlsTNAmRgcSHHtY4mT9GM2edATTJifFfNonCovqNEbXKSoCyZ?=
 =?us-ascii?Q?my8WlED5BReGQJZ9G7+gyviF3P+kl/UWdbzB6KUf5WWtR8K3TbWQyZODU9u5?=
 =?us-ascii?Q?rTGV7N7S+nA+ft/lNUo1QnVQ8/K2nAbWLBvV/CAOBeLFrJuVrtc0qUvLCfKj?=
 =?us-ascii?Q?KTg09YSMrG8O4CrA/IxCSvPwBDQu9yojAUGAw11g0n0EQzBj4kv0XOp04H+2?=
 =?us-ascii?Q?XZpHdWD3tUKu7s40UvKJ2/2GkuLQMJc7QEWuFpAnj/gvB5kzPifHDcXdLzPk?=
 =?us-ascii?Q?ZtrY6oiY6oIdEDwGOrJ+RXS69sZvvm36hNJDZWnobQHKsn70fOLULtIH3cR6?=
 =?us-ascii?Q?02jalycUIQDWBA9yoYqzbkrVPwLTwdLWiu1g8s3m0B6gvNqTxX3WQt+zSaVX?=
 =?us-ascii?Q?uCIS9swqEte0aLiivmzlmObBiEPiBcYBNarDvkVxvfOhzfY66h9My4pBY9D7?=
 =?us-ascii?Q?SGtW1NAUEFbDaWfKskt3Fou5FYdYIySB2PWOpAVEKLmACUoC8sHb69QbQ7Cf?=
 =?us-ascii?Q?+gQ4fZnT8bRxYkhtWeW2altabXEhrCyZcq96r0thEMc1xNJUtirvmkptO03B?=
 =?us-ascii?Q?QiOzW7dBcqpJ0Y2JBJsD7orfhWs+qrwNupd1VwbH6BsDJ571LB17vUNKQswC?=
 =?us-ascii?Q?eYSejZLlvLoi95LNM8poCcz5wWEHw+9e7xtaSZOAYbdiKBn/PDqQUIBKN6ZI?=
 =?us-ascii?Q?XYfqA55e/yjeukTG8B242ZNiqMr+CX+18v6IDqypQ5DYqMmfAWfoebU3SZuG?=
 =?us-ascii?Q?fT15NGBDe/JB6dM6yZfnVY3nRczQhGWIMsaSTcfLIDVaaU9e1t4iwfiasS6X?=
 =?us-ascii?Q?oGVmtakpHr9SH4GQsEPaFHCafh3lUS69aAVKwBhVQmjuxSSYDqh/ZwRpXY/Y?=
 =?us-ascii?Q?aDm2OmGmzUQWTm0MZ87a/updLbDssW8daip+ifzwJ8qWqoe/JHNK7SurQFVh?=
 =?us-ascii?Q?GKwLDYNQZiNHwIbAj8tlilfZItoYB1TKqxP1FUMQ6p7RiOcabGNGUEH/DjXj?=
 =?us-ascii?Q?JPsvdLu0l7pgWRTRscRM85BrWst1nsZdOkLs2mF60HHyFWcpJaXXGgTBc/e6?=
 =?us-ascii?Q?UEoU9160ef0p36xLsKw0FBi5D4PQuGCOQr7OFNBVCN/y79p16SCmskB5HYqG?=
 =?us-ascii?Q?unqWQ/203B5uU93yxqxp5TPta+uKwlyKhWEtHGbcJC3a9MkE3/zVpAnwdOC+?=
 =?us-ascii?Q?OY1KHFWmY65qxv+3scL68DuF+EiqHGf03HGNjhVHaMITMDiXnfwu7nKvZ1u4?=
 =?us-ascii?Q?fU1dWhoekDfD2rXEJkamHdFpx+OyPwGj0znp5fPZY4k2y04n4boj5hIxlxcr?=
 =?us-ascii?Q?dNbzHcMOt1YhpyU0antAXc1LHEj/3h7Ho+08q0w908TwlkJPaeiXqW9YD9wF?=
 =?us-ascii?Q?nUbUc0+ikJAOpI0575iHcY/NtbQPfyIa+0IG47bwSaZKj3L6W8ZlZdIV/Osf?=
 =?us-ascii?Q?xIYVM7L//KEvHPHuXD1rX8trWLxv38YdrzmSfVXwpHhUwNNPZ5jkCiHyOCS/?=
 =?us-ascii?Q?mG4s+WrugfTQzqtKgeFQyC5QlGvBX3wyPe9hyVlVes7vv/+w7iOuhvLP8DuL?=
 =?us-ascii?Q?2OPQM/XVL+Z79bDqy5mPpE+jaennyE+Hbl73v98NIS6g7QvNcgpwoqqD0DGF?=
 =?us-ascii?Q?xHyyMnLHxJmEmaThw/DXOmZS+EvLivUwReyjeMMKUyJRh0VCnhFbsGnBFYd6?=
 =?us-ascii?Q?k/ZaabDqyQ/gXXOgjZSmdAyQmjtwZ0GPkHJ8k34TD70BALR08S4QvVbwE9ad?=
 =?us-ascii?Q?mOLPXXvfEQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c68f9848-db3b-4065-c36a-08da2696c75e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:37:05.9422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5CzsvGC8W8vgJ6L7eXJO0CYSkYGJba6X/LQkt0x7tisP8jA6ws0qXwLvwWs+aF0HZbysfW7juSezZdanjJxR3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3831

In order to free intermediate page tables when replacing smaller
mappings by a single larger one callers will need to know the full PTE.
Flush indicators can be derived from this in the callers (and outside
the locked regions). First split set_iommu_pte_present() from
set_iommu_ptes_present(): Only the former needs to return the old PTE,
while the latter (like also set_iommu_pde_present()) doesn't even need
to return flush indicators. Then change return types/values and callers
accordingly.

Note that for subsequent changes returning merely a boolean (old.pr) is
not going to be sufficient; the next_level field will also be required.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
---
v4: Re-base over changes earlier in the series.

--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -31,30 +31,28 @@ static unsigned int pfn_to_pde_idx(unsig
     return idx;
 }
=20
-static unsigned int clear_iommu_pte_present(unsigned long l1_mfn,
-                                            unsigned long dfn)
+static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn,
+                                                   unsigned long dfn)
 {
-    union amd_iommu_pte *table, *pte;
-    unsigned int flush_flags;
+    union amd_iommu_pte *table, *pte, old;
=20
     table =3D map_domain_page(_mfn(l1_mfn));
     pte =3D &table[pfn_to_pde_idx(dfn, 1)];
+    old =3D *pte;
=20
-    flush_flags =3D pte->pr ? IOMMU_FLUSHF_modified : 0;
     write_atomic(&pte->raw, 0);
=20
     unmap_domain_page(table);
=20
-    return flush_flags;
+    return old;
 }
=20
-static unsigned int set_iommu_pde_present(union amd_iommu_pte *pte,
-                                          unsigned long next_mfn,
-                                          unsigned int next_level, bool iw=
,
-                                          bool ir)
+static void set_iommu_pde_present(union amd_iommu_pte *pte,
+                                  unsigned long next_mfn,
+                                  unsigned int next_level,
+                                  bool iw, bool ir)
 {
-    union amd_iommu_pte new =3D {}, old;
-    unsigned int flush_flags =3D IOMMU_FLUSHF_added;
+    union amd_iommu_pte new =3D {};
=20
     /*
      * FC bit should be enabled in PTE, this helps to solve potential
@@ -68,29 +66,42 @@ static unsigned int set_iommu_pde_presen
     new.next_level =3D next_level;
     new.pr =3D true;
=20
-    old.raw =3D read_atomic(&pte->raw);
-    old.ign0 =3D 0;
-    old.ign1 =3D 0;
-    old.ign2 =3D 0;
+    write_atomic(&pte->raw, new.raw);
+}
=20
-    if ( old.pr && old.raw !=3D new.raw )
-        flush_flags |=3D IOMMU_FLUSHF_modified;
+static union amd_iommu_pte set_iommu_pte_present(unsigned long pt_mfn,
+                                                 unsigned long dfn,
+                                                 unsigned long next_mfn,
+                                                 unsigned int level,
+                                                 bool iw, bool ir)
+{
+    union amd_iommu_pte *table, *pde, old;
=20
-    write_atomic(&pte->raw, new.raw);
+    table =3D map_domain_page(_mfn(pt_mfn));
+    pde =3D &table[pfn_to_pde_idx(dfn, level)];
+
+    old =3D *pde;
+    if ( !old.pr || old.next_level ||
+         old.mfn !=3D next_mfn ||
+         old.iw !=3D iw || old.ir !=3D ir )
+        set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
+    else
+        old.pr =3D false; /* signal "no change" to the caller */
=20
-    return flush_flags;
+    unmap_domain_page(table);
+
+    return old;
 }
=20
-static unsigned int set_iommu_ptes_present(unsigned long pt_mfn,
-                                           unsigned long dfn,
-                                           unsigned long next_mfn,
-                                           unsigned int nr_ptes,
-                                           unsigned int pde_level,
-                                           bool iw, bool ir)
+static void set_iommu_ptes_present(unsigned long pt_mfn,
+                                   unsigned long dfn,
+                                   unsigned long next_mfn,
+                                   unsigned int nr_ptes,
+                                   unsigned int pde_level,
+                                   bool iw, bool ir)
 {
     union amd_iommu_pte *table, *pde;
     unsigned long page_sz =3D 1UL << (PTE_PER_TABLE_SHIFT * (pde_level - 1=
));
-    unsigned int flush_flags =3D 0;
=20
     table =3D map_domain_page(_mfn(pt_mfn));
     pde =3D &table[pfn_to_pde_idx(dfn, pde_level)];
@@ -98,20 +109,18 @@ static unsigned int set_iommu_ptes_prese
     if ( (void *)(pde + nr_ptes) > (void *)table + PAGE_SIZE )
     {
         ASSERT_UNREACHABLE();
-        return 0;
+        return;
     }
=20
     while ( nr_ptes-- )
     {
-        flush_flags |=3D set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
+        set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
=20
         ++pde;
         next_mfn +=3D page_sz;
     }
=20
     unmap_domain_page(table);
-
-    return flush_flags;
 }
=20
 /*
@@ -349,6 +358,7 @@ int cf_check amd_iommu_map_page(
     struct domain_iommu *hd =3D dom_iommu(d);
     int rc;
     unsigned long pt_mfn =3D 0;
+    union amd_iommu_pte old;
=20
     spin_lock(&hd->arch.mapping_lock);
=20
@@ -385,12 +395,16 @@ int cf_check amd_iommu_map_page(
     }
=20
     /* Install 4k mapping */
-    *flush_flags |=3D set_iommu_ptes_present(pt_mfn, dfn_x(dfn), mfn_x(mfn=
),
-                                           1, 1, (flags & IOMMUF_writable)=
,
-                                           (flags & IOMMUF_readable));
+    old =3D set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), 1,
+                                (flags & IOMMUF_writable),
+                                (flags & IOMMUF_readable));
=20
     spin_unlock(&hd->arch.mapping_lock);
=20
+    *flush_flags |=3D IOMMU_FLUSHF_added;
+    if ( old.pr )
+        *flush_flags |=3D IOMMU_FLUSHF_modified;
+
     return 0;
 }
=20
@@ -399,6 +413,7 @@ int cf_check amd_iommu_unmap_page(
 {
     unsigned long pt_mfn =3D 0;
     struct domain_iommu *hd =3D dom_iommu(d);
+    union amd_iommu_pte old =3D {};
=20
     spin_lock(&hd->arch.mapping_lock);
=20
@@ -420,11 +435,14 @@ int cf_check amd_iommu_unmap_page(
     if ( pt_mfn )
     {
         /* Mark PTE as 'page not present'. */
-        *flush_flags |=3D clear_iommu_pte_present(pt_mfn, dfn_x(dfn));
+        old =3D clear_iommu_pte_present(pt_mfn, dfn_x(dfn));
     }
=20
     spin_unlock(&hd->arch.mapping_lock);
=20
+    if ( old.pr )
+        *flush_flags |=3D IOMMU_FLUSHF_modified;
+
     return 0;
 }
=20



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:38:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:38:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312533.529819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuEV-0001As-5X; Mon, 25 Apr 2022 08:38:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312533.529819; Mon, 25 Apr 2022 08:38:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuEV-0001Al-2I; Mon, 25 Apr 2022 08:38:11 +0000
Received: by outflank-mailman (input) for mailman id 312533;
 Mon, 25 Apr 2022 08:38:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuET-0001AU-P5
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:38:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0877dcb2-c473-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:38:08 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-9euADwJEMM6-oNQMvwzxDA-1; Mon, 25 Apr 2022 10:38:07 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB7424.eurprd04.prod.outlook.com (2603:10a6:800:1a7::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:38:05 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:38:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0877dcb2-c473-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875888;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HbAbSHg5ZYzDcoXEhcNJap9YC68omZXSPDO+MrCQoo4=;
	b=a0B/FBbG54bSiF2MRSXM3YVxNwvPbqQGkN3pnGcbCJBq1nhn7r+BIz+F5iQzn65SE1Q0/e
	H1/hYbutfq4ZtLvhqhiGCLLGBffD7R+Xwbdc+lWMRU1PK/xOgnSC5Rwhxd9ETwzGDG9pbP
	KSlXvchJxU6jUaFp9BKoPZ3ve9JBf7k=
X-MC-Unique: 9euADwJEMM6-oNQMvwzxDA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cbewgt8CsIo6ZPR2bkZk0GWOw4kfOiWCRFBP4svCdR4igDdcQVjgYG+wjq+diuMhe7MwFGLIBrUcsmWpU9tBRpZAptQFKot4Bb9hm67wY9J3hF2KoK9a61t5I8Qxkhr1HmPIyIGAxHvIKQ6PLk90c54pajs5FjN/Uk2uDMOXgFFn3T9UUu6v+DqM8g9k1tKe+KVo1glkWihZN4B9UAwHjQzFcWj6n8r6ADNBG0G5pYVFRBURHrcRH504ArFQNzKs1njPZFsOnZe61pcG0H9Ftbk9T70yi31sVZn/xF9KafAaqiMWt1GZJwS2HcYuo2D/+Rp+XCnwmVMuJ04qCos3EQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HbAbSHg5ZYzDcoXEhcNJap9YC68omZXSPDO+MrCQoo4=;
 b=AN4i23UufRgtexkGF58cmoZB5BQCTd9TvdJZGMZ++1x9LlMGs4+Y5WQJeXEeaDwVH/MhlCadrVN2Do1O92yprebqNhzq+Z4k+tSbkgjOR/h/0tP3d6FHxodxKlsaEyNaKrztmHa95GkJN3EjGVzy8F8U8Pd1kSvd5lD+GMhzaW2PFHiK4l7wISDnFkviQHGR07LObjoILRBks7/lr/0R0VJQPIQY6lOYwhi3Jb+t3Q+D6MCn0PJbdm/G/8CYlppXamvTM0u+Yfkh1kil+Ftyjm7GHMwDlq797nIiWg7j38poklIaYIvG85p+j0ZjF8D/6SD84h/qjSpijN67xMbTNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5866e22e-9f31-84ab-1df9-db84aa802944@suse.com>
Date: Mon, 25 Apr 2022 10:38:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 10/21] AMD/IOMMU: allow use of superpage mappings
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR04CA0014.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d56cf4ea-ca11-43f8-2c34-08da2696eab8
X-MS-TrafficTypeDiagnostic: VE1PR04MB7424:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7424F897A880C91B8AAF9ADBB3F89@VE1PR04MB7424.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Fiut1mesAS/t0AksbdJlXJ0SSZtzAwn9hT8AUwtxdev03uSMZxhxzu544oz/pHolxu61r4ScHKBO58niWtBcUOyfcYlZoIdrmH4gp/K1AnGWzD/trDZ6R0pzyJAEplhsEmhP/AeCX9xXZx3zbVwtbeWp272bb++7PluO1r/PCN0dzd+AcA7t4AALCHMn51Gv/nzFHwENKzZckfcyCKEQCRs9aOtrheoPrhNwt1BNmyb1CzwVUxu1ZV+tpjM3IerRSiqxcwnNg8+MJwIz8o80hT8/+M/42k2nYPC6w9lhR/7zhuB8zLHtaCEwMj917GRSMvJ7ngENqDexO2m23rTiw2F5KAf9QsBux0iHdu8t3qBj2iYmWkp170uZ+xxuAJAJ0blH0Todp7arLN+id+/rX9RS1TnmAM6V250ppHyIkdOWcuN5wEgFMaZMMdDQaGFS3MsgU/EjcH4PSoYQUpRTqYLJG2oIjIhfk7M8v2H9A0Cjw3kAiSXATAIIBP27tD//B4F231tL0GCmqmNEIRUfsJaueQLqYbfp/O7G2rH87dXlUoRqQtRqabohRdqs+sHJiGkmF5L8arT6Az7yrhvyscdL3vPNFClId3LId96AaDREy4QIElkl8tIlY4e66wMyufL0juLFzAQl5T8yyXhXh7fldTEK1xACnQ8u0Jd01s+e/fOgLJIlfBPEUHhzbIUiAgI43kolJQWVgascJDehitvQRlAcku0zxqqS5ZcH2Rk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(31696002)(86362001)(66946007)(83380400001)(66556008)(8676002)(66476007)(38100700002)(2906002)(6916009)(186003)(316002)(2616005)(4326008)(8936002)(31686004)(36756003)(6506007)(508600001)(6486002)(6512007)(26005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MS9PWnlPR244U0RtTHBhVmFjS2o1M28xZ1FsMW5DMXRGYm9mVjljbW4yeVdF?=
 =?utf-8?B?anVySUZnZDkxdXNObTJGbXg3NkdEeTdsUEJZSW5pTTFqb0JOQXp6MjFlRWkv?=
 =?utf-8?B?WUpROEUvU3ExcVdTU3A5Sm1KNzBCS0Y1c3BKMXdxOXFyWmRad254OGdwcEx3?=
 =?utf-8?B?RTRLR0xqQlhPdisrVnZ1eHllamhIMy85b1RBU1h0OGFIWDFIZ0FTMDFlZkRB?=
 =?utf-8?B?anBPNmk3ZzE3cGtERFBBTGZaVVcveTZTU0I3QTZtckRReEJWYmN1ZUtnUkVM?=
 =?utf-8?B?SEhDY2xWREZTNkdmcGNMaGg1UW1xZW1OaXpEMW1ONkZ6Q05IMTdDZGU0WlZt?=
 =?utf-8?B?Znk0aEkvQmxqMDkxY0Z3UGErUHREYTQwMldDOGJkQjdoSjlYdTJlS0JZZGpJ?=
 =?utf-8?B?N3h4QkV1WTk5UTBwcDJEdXFZbjBPVjFVbW5RRWliUTVuVTFwcG5HNHNOSjBk?=
 =?utf-8?B?T3RCMXU5Rjc3QjZLQkVHTVo0QUZRMTBldThrNkRqNytySnVPc0tmbjlONUp1?=
 =?utf-8?B?OXhaMy9rbVFwRUhSWGNHcHE1emdiWVpBNmJzRkcyejByeHFlVHVhU1RxQTNk?=
 =?utf-8?B?eWZ3VFpUNExvb2FxWDF3OE9iYkUzOVFnZU8zRlJoNnVYK2N6MHo3dGVMQlR3?=
 =?utf-8?B?OTFpV2puOTdacXdFSlZtZGJNVTJMaVU5YXRlV2YrSjhxeW5CYzV3dnlrMWFS?=
 =?utf-8?B?L3N2YnRvZjYzUGpUa3phTWJpb3ZQRmE0cGtQR0tVWDliTXZhdm1PRDhtNGdh?=
 =?utf-8?B?d2JjcUdWNm9qbnJ4QkQ4Z0doN2JhaXJzd3A2RnFLdXI0bmxadXBHdTd6Yzdk?=
 =?utf-8?B?YXBMcW9qeWlQSVZMTnUrc2ZMZlhIM1J4eldnSmVqSFd1enlzdk9YUWprR1d4?=
 =?utf-8?B?SGlDVTNZK2QwM0dKZnJoQ29OdWtPd3gzUXdBNnZNanM2MWN1SmdOZ2MwaWRt?=
 =?utf-8?B?WmFkN1dDTmJxdWdxaXZ3aGd1R2d1U3RlRDUvS2NXMWU2T3RrL0VTZEdaQzk4?=
 =?utf-8?B?RXp5WTYxTlpMNkpGbFdRYlN5dDg0UVdTQ04wdFRhemVBSjg1WlhHU0M1a2l5?=
 =?utf-8?B?MnRrMTBKZitQYmZwWDhUNTRHZmIyTTNLVVNmYm4zRFZ6Sm9ibXloK2hpOVZ0?=
 =?utf-8?B?UXZQY0tyODk5dC80SEVjSmVjNjg1MzZNUUZiY05DSzlvdDFaYVRrRE5aTmlm?=
 =?utf-8?B?VEJDdDA1RFZxcW1FM3ZLcUVjLzJYQlNxT3d4dHltOHhiV2kvNUtOL0hvbzI1?=
 =?utf-8?B?UEp1WStSTFFhN011L2k2V3l1ZmJUWEhuNmNCcVNrbUYvUDNDNllsbGhLM1Bw?=
 =?utf-8?B?UFkxSGtiaW93OWYvdHNWV1pZZ0pob29WNDRlM0ZicVA2NmpmL3lCRnB1Rngr?=
 =?utf-8?B?TmdOWWNmcUJET1JRd0UyeEg3U1F4MjFlOUNma0p4STNWZk9EODI5T1lCSlVC?=
 =?utf-8?B?V1N1R1JaUzBzNi9TVXlzVzRPSmpYcU4vQ0kvaVp6eU0zd0JHTUJ4Nlk5Z0dR?=
 =?utf-8?B?YWR4cEp2dTl4SWh2Wi9HekJwRndyUXhQWWlOZDdnTjVZbkNjQTc0ZmxvNkxI?=
 =?utf-8?B?c0lqeTJWR3NkYVdOR2ViK004SkwvY2VJSmV6WVZXdnZab00yaXRra1Z4amg5?=
 =?utf-8?B?WUJLYmg1eVV5NFpNNkoxczFoNHRhMjlTUWRSZ282ZU50MUIwbTRIMmpCM0ZD?=
 =?utf-8?B?MXJOdHlVTy96cU5hSGxHTFA1ZDJBM2JhR1JDSi9wYUcxOUExSDBlWlJ4Y1Fw?=
 =?utf-8?B?TXFoSUJCNU9ySGpCbENQb1VVTjhHODl5UUlKOVVxbFNPUkQrcXAyRU84eUVv?=
 =?utf-8?B?eHZRTEdWS3lPT1dGMG13dG5yQzRrWlhSa09ZSWd0ejlPY3BMRUJjOGRLUkFw?=
 =?utf-8?B?MHJleFM3RGxsd0tVK2d5cHo5cFUvTHJzMU8vTzVpRU5JWlQzbEJtV1FBVXFE?=
 =?utf-8?B?bG5vK0g4aTJXclEyd1JJZXBpd0hYMkJvYXFteHhWODJvdjlrbW5mY2ZFd01C?=
 =?utf-8?B?b1hQQ2pWR0xpM3BUOTNvTnc0SjNncjZKR2VUWWdXUk1VQnlKMzFlaUxwakpN?=
 =?utf-8?B?SUFpazdzMGJZaGZ2cDdXc2xpdTAzY29SL1ZGSWdVdXJJdTJVQjNwRTZlRmxW?=
 =?utf-8?B?TFJicHBOc09CZmlyM29kZ0kzM24wdUhlUlpJcDZYZW1nSHVKYTRPajFGWjd0?=
 =?utf-8?B?THdwWFFhSTZvcWgrRjFaalVxdHJvOG50Mm9jZlkzRVljSlVObEJZV2hTQ3p4?=
 =?utf-8?B?UTlEbldSaWhPYi9JaGhUU1dYRzZpVXRSVVdqenJ5RnhLK3o5azhLcnpqSTFJ?=
 =?utf-8?B?L2xsYXZFV05MNVZtTXdxZ2Q3Sy8reWFDN0RVWW9NNjNUOVFXNHJNQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d56cf4ea-ca11-43f8-2c34-08da2696eab8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:38:05.2328
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KSo6xq+YQlGLdbM93qG9dyJ3VhSsbd5Vboxi0sDqpRnf0RaaO16IK9bKlB8dD6nUEeR6imRzjEUM5GRcJaA+rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7424

No separate feature flags exist which would control availability of
these; the only restriction is HATS (establishing the maximum number of
page table levels in general), and even that has a lower bound of 4.
Thus we can unconditionally announce 2M, 1G, and 512G mappings. (Via
non-default page sizes the implementation in principle permits arbitrary
size mappings, but these require multiple identical leaf PTEs to be
written, which isn't all that different from having to write multiple
consecutive PTEs with increasing frame numbers. IMO that's therefore
beneficial only on hardware where suitable TLBs exist; I'm unaware of
such hardware.)

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I'm not fully sure about allowing 512G mappings: The scheduling-for-
freeing of intermediate page tables would take quite a while when
replacing a tree of 4k mappings by a single 512G one. Yet then again
there's no present code path via which 512G chunks of memory could be
allocated (and hence mapped) anyway, so this would only benefit huge
systems where 512 1G mappings could be re-coalesced (once suitable code
is in place) into a single L4 entry. And re-coalescing wouldn't result
in scheduling-for-freeing of full trees of lower level pagetables.
---
v4: Change type of queue_free_pt()'s 1st parameter. Re-base.
v3: Rename queue_free_pt()'s last parameter. Replace "level > 1" checks
    where possible.

--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -32,12 +32,13 @@ static unsigned int pfn_to_pde_idx(unsig
 }
 
 static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn,
-                                                   unsigned long dfn)
+                                                   unsigned long dfn,
+                                                   unsigned int level)
 {
     union amd_iommu_pte *table, *pte, old;
 
     table = map_domain_page(_mfn(l1_mfn));
-    pte = &table[pfn_to_pde_idx(dfn, 1)];
+    pte = &table[pfn_to_pde_idx(dfn, level)];
     old = *pte;
 
     write_atomic(&pte->raw, 0);
@@ -351,11 +352,32 @@ static int iommu_pde_from_dfn(struct dom
     return 0;
 }
 
+static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int level)
+{
+    if ( level > 1 )
+    {
+        union amd_iommu_pte *pt = map_domain_page(mfn);
+        unsigned int i;
+
+        for ( i = 0; i < PTE_PER_TABLE_SIZE; ++i )
+            if ( pt[i].pr && pt[i].next_level )
+            {
+                ASSERT(pt[i].next_level < level);
+                queue_free_pt(hd, _mfn(pt[i].mfn), pt[i].next_level);
+            }
+
+        unmap_domain_page(pt);
+    }
+
+    iommu_queue_free_pgtable(hd, mfn_to_page(mfn));
+}
+
 int cf_check amd_iommu_map_page(
     struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags,
     unsigned int *flush_flags)
 {
     struct domain_iommu *hd = dom_iommu(d);
+    unsigned int level = (IOMMUF_order(flags) / PTE_PER_TABLE_SHIFT) + 1;
     int rc;
     unsigned long pt_mfn = 0;
     union amd_iommu_pte old;
@@ -384,7 +406,7 @@ int cf_check amd_iommu_map_page(
         return rc;
     }
 
-    if ( iommu_pde_from_dfn(d, dfn_x(dfn), 1, &pt_mfn, flush_flags, true) ||
+    if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, true) ||
          !pt_mfn )
     {
         spin_unlock(&hd->arch.mapping_lock);
@@ -394,8 +416,8 @@ int cf_check amd_iommu_map_page(
         return -EFAULT;
     }
 
-    /* Install 4k mapping */
-    old = set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), 1,
+    /* Install mapping */
+    old = set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), level,
                                 (flags & IOMMUF_writable),
                                 (flags & IOMMUF_readable));
 
@@ -403,8 +425,13 @@ int cf_check amd_iommu_map_page(
 
     *flush_flags |= IOMMU_FLUSHF_added;
     if ( old.pr )
+    {
         *flush_flags |= IOMMU_FLUSHF_modified;
 
+        if ( IOMMUF_order(flags) && old.next_level )
+            queue_free_pt(hd, _mfn(old.mfn), old.next_level);
+    }
+
     return 0;
 }
 
@@ -413,6 +440,7 @@ int cf_check amd_iommu_unmap_page(
 {
     unsigned long pt_mfn = 0;
     struct domain_iommu *hd = dom_iommu(d);
+    unsigned int level = (order / PTE_PER_TABLE_SHIFT) + 1;
     union amd_iommu_pte old = {};
 
     spin_lock(&hd->arch.mapping_lock);
@@ -423,7 +451,7 @@ int cf_check amd_iommu_unmap_page(
         return 0;
     }
 
-    if ( iommu_pde_from_dfn(d, dfn_x(dfn), 1, &pt_mfn, flush_flags, false) )
+    if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, false) )
     {
         spin_unlock(&hd->arch.mapping_lock);
         AMD_IOMMU_ERROR("invalid IO pagetable entry dfn = %"PRI_dfn"\n",
@@ -435,14 +463,19 @@ int cf_check amd_iommu_unmap_page(
     if ( pt_mfn )
     {
         /* Mark PTE as 'page not present'. */
-        old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn));
+        old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level);
     }
 
     spin_unlock(&hd->arch.mapping_lock);
 
     if ( old.pr )
+    {
         *flush_flags |= IOMMU_FLUSHF_modified;
 
+        if ( order && old.next_level )
+            queue_free_pt(hd, _mfn(old.mfn), old.next_level);
+    }
+
     return 0;
 }
 
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -747,7 +747,7 @@ static void cf_check amd_dump_page_table
 }
 
 static const struct iommu_ops __initconst_cf_clobber _iommu_ops = {
-    .page_sizes = PAGE_SIZE_4K,
+    .page_sizes = PAGE_SIZE_4K | PAGE_SIZE_2M | PAGE_SIZE_1G | PAGE_SIZE_512G,
     .init = amd_iommu_domain_init,
     .hwdom_init = amd_iommu_hwdom_init,
     .quarantine_init = amd_iommu_quarantine_init,
--- a/xen/include/xen/page-defs.h
+++ b/xen/include/xen/page-defs.h
@@ -21,4 +21,19 @@
 #define PAGE_MASK_64K               PAGE_MASK_GRAN(64K)
 #define PAGE_ALIGN_64K(addr)        PAGE_ALIGN_GRAN(64K, addr)
 
+#define PAGE_SHIFT_2M               21
+#define PAGE_SIZE_2M                PAGE_SIZE_GRAN(2M)
+#define PAGE_MASK_2M                PAGE_MASK_GRAN(2M)
+#define PAGE_ALIGN_2M(addr)         PAGE_ALIGN_GRAN(2M, addr)
+
+#define PAGE_SHIFT_1G               30
+#define PAGE_SIZE_1G                PAGE_SIZE_GRAN(1G)
+#define PAGE_MASK_1G                PAGE_MASK_GRAN(1G)
+#define PAGE_ALIGN_1G(addr)         PAGE_ALIGN_GRAN(1G, addr)
+
+#define PAGE_SHIFT_512G             39
+#define PAGE_SIZE_512G              PAGE_SIZE_GRAN(512G)
+#define PAGE_MASK_512G              PAGE_MASK_GRAN(512G)
+#define PAGE_ALIGN_512G(addr)       PAGE_ALIGN_GRAN(512G, addr)
+
 #endif /* __XEN_PAGE_DEFS_H__ */



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:38:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:38:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312538.529830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuEz-0001ic-EL; Mon, 25 Apr 2022 08:38:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312538.529830; Mon, 25 Apr 2022 08:38:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuEz-0001iV-BH; Mon, 25 Apr 2022 08:38:41 +0000
Received: by outflank-mailman (input) for mailman id 312538;
 Mon, 25 Apr 2022 08:38:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuEy-0001TY-BJ
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:38:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1aad4c05-c473-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:38:39 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-FnbnxG2eO5yWg5I1ukSaqQ-1; Mon, 25 Apr 2022 10:38:38 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PAXPR04MB8638.eurprd04.prod.outlook.com (2603:10a6:102:21d::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:38:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:38:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1aad4c05-c473-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875919;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m9iSfvMKYPfUIQdOapiU+/T/G/OgrgAKwMM8hwIFvpo=;
	b=EqkNxuy16guVo0OgYTCCIeK52s7phBnnaN7NsI4LyOfjM93nse67dl/aCTFYo/fm1Tw+vv
	iZOstjjYDkkOZ9kA+6yTRFWxH6xFiRti0gnjVUQzcdDZbbN76uAVJ+xDr+SoVRQvk6cKE3
	b+JvCvfSQnwbsBVOijREzsSMIzTOiM0=
X-MC-Unique: FnbnxG2eO5yWg5I1ukSaqQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AC9GrLuVvBD1b/TnZsGZSiVY1DbV36D8eXE/50Dd1+WHYeX8l/796QMQhbLWfQOU3iaPh1wZbM+vpTz1xeydMr30JN0qiHq71I5hkke5N9qy9Bejnok3hLUDp6btRlUxwwyZpAraJ/IIyimx1/vGYhZESEFNc/V1dovAiXTMLsKbanr5zzHiCjnwEu6vKhFUekMt3tkkCw2PaZukhotgzNpUA8LBIlWMHwynycKNudL82c33WqHb02pBH1X5OC0lQElG/MqEwODY12tAb9f9LhF6AQRncGfs+sgbyktCae7SmYujLOe9OM0np/KLo2VEyHEW2htiD+E88xmRVcV/+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m9iSfvMKYPfUIQdOapiU+/T/G/OgrgAKwMM8hwIFvpo=;
 b=hRQozTN2AbYVHczUPgxM6DHCgnFgGdUqMzyWE7U+ae1FAj0rrHIdgD5yvJyf9mI0qPCCYw+DvBvwRytr857wYO5cJfTvsRQ9eMfyAk5xZ4EzgdjJIIdDmJbOwUOVx8O19gv2SkSt4WbFETSjq76zel40l5F0S5r5qjhQO/ltvQUYHHDOkT+Es39fs4y/1J+K02howFk8dOK7gRmsVztFZVps4qWp0moQTiHdZzgJIkGWOyvRIYputYeAqqxIXQ5v5MdaPfqQzuhsEDDWdu7CBxQG2WxuNyVkf4FxAA8PBqAucTfrCfoGQwFt/54pyMh3q+QgkpF3FfnxZmnAVlbnvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c73ae968-44a2-08f5-df26-7cf9b4a5b1aa@suse.com>
Date: Mon, 25 Apr 2022 10:38:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 11/21] VT-d: allow use of superpage mappings
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0016.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::29) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 024289db-c4be-4ab4-6b62-08da2696fd57
X-MS-TrafficTypeDiagnostic: PAXPR04MB8638:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB86388D68A565651EA665865EB3F89@PAXPR04MB8638.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0txE0dPW/Knkt9kdhOFyIlR3d3u/lL8h3ml3s4PWP+iJ8P7ndgoQHkFE7Fx+sTdO80P6EcYKL58edE7HTg0SNAvBXJdr1lt6dBpOG8PVCrQQDNCc/9aC526DBFzaJMJmWvRWpNdUi7TsChWWyxfUi6/KQ5sIxHJ1knteJDPyKHZwQIIwwz953V0FnH1DGVsBie+gXQGU9l4T4cJSbxqVXziHo0ZzH8qwjgBeNsxAwbzOLsHKecq7+d2DOeHr//PGWw52D1kTP0SLKyZ4opPyZmFTHw/jFLBdD0+rjRVEt0mBGJeD4phtcyeoeJ+FnZXAgCh/V5897KRQUVl4PRUmJYyhbfDJr5rkkIyUKau1fpxGvjusro/X1B6MhfZDpOxmHP7Bg8uoPsX+n2pIX5fiCrNLTydRjm7+kGl5mn86fjLlhZwHsud2+HYZc36zPZB7Ca/zyOLk/k7GoqxyWc0OgB1p0JUOj1/gh9K3dp8jD84uS533KbwnPr68gPMmCcXtFbQowFGWNuuMXX2nHv/eqIGUcOhg5GiKGirlVnR7UX5/yNznT6akHzyoPgMDzDdlinoe+rvl7wsFvz3w9aLkvTwtPUa1YLRjoLPQaVh7SAkQHUoLaFLCKDfjxZp5JBFcmJtmgsk9VSpAr9U9pL56P5+/ctQeAp0tIiYsY9wPr51VVxEEJTmVhxeYd4L8nDcQipq6uI/86IO99m+UbQtYwUzEYn3CmSk5+dttvGX1WrE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(31696002)(83380400001)(86362001)(316002)(8936002)(6916009)(66946007)(66476007)(66556008)(8676002)(26005)(186003)(2616005)(54906003)(4326008)(38100700002)(2906002)(6512007)(6506007)(31686004)(508600001)(6486002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZTlIOEVkMmNvZGt6dGp4ZGp3WWZSNjBmc080b0JqZEJONG1hL2R5aGFNWkha?=
 =?utf-8?B?Rkl4NVRNVWdFdXpERFNDVHFETmNvMldNdW1iTnNrbVQ5Z3k4LzJQU1lCMlFm?=
 =?utf-8?B?dTJTczZGcXg3MHFsYmtRTytabTBnVGh4djRWd1lYM05oYmpKTkJsNmUrV1Yv?=
 =?utf-8?B?RFNUNjdDd2l4TmxtTTFCUzA4Y3dQMVdybTBjVVhaLzE5RG1TTFEzU3ZwazA0?=
 =?utf-8?B?ZXhudUgwOUVNYXpma1dpclViVzZOWE1qdU5sNUVMZllBeVp3dDNJV0U1dFow?=
 =?utf-8?B?TDNZR0JDaUF0M0toSG1Oemw1TjIyRnZQdUM5VUVheWtqdnZkSVQ0NEpHUXoz?=
 =?utf-8?B?dnBBRExDVjlocG9OQ0gzY0xlTW5GZm5EZ0lRaU9EcDB3U1czcHAzZ3AyNU9V?=
 =?utf-8?B?MGxjcUg0Q0g4ZTV3blViemtaaXBQUzdQV1FvenZNZHNoNkRQU3FSMG95YVlm?=
 =?utf-8?B?SERuQjdFVjhQRmp3ZnlVK3NkdnRXSmpwbTZWc3VPUW5HZ09LaGxrMWFIQ2xh?=
 =?utf-8?B?NzY4UWRwK2p2em1EYzZVSjdtMU9ndnY4TWFMTittM28vdVdscm1QODZxT0cw?=
 =?utf-8?B?Z3E0ME1DY3pzZU11a24yOFZPeVZUYitPM2NBM3NBU2FmOGtJemJKVWpUYyt1?=
 =?utf-8?B?MytRV0VkSE85MHRIbDJkdDFlN2lIakpZY2tYM0ZCamhYVlIzWFhReTJuYW5o?=
 =?utf-8?B?RUlQcitjRjFqM2Y0OTVVeGhWcUNjelF1cW9QemhRQVNwTFhxSmR4blY1b1B3?=
 =?utf-8?B?UzVwbGVrRXlzS3J4SmNVeWcxQkx3bTN5R002UVFYZzlBb1pPZlYvWnppbkM4?=
 =?utf-8?B?eTBTTVFqYjdJQkpsQXlmdG1nSHJvQWhTanBsYkxGaGwwNGNmMi81YzZzQll2?=
 =?utf-8?B?VWhxOFFvNmVNd2NSeUpHMVRTQnVJNTV5ZU41TGZvYzJraFIvQ21xV1RxUEw0?=
 =?utf-8?B?K0tPOVkyL1pjdVR6Mm1VcnFOYVhkeXZiOW1QQzlsUFR5UkFhRUVFb3VrL0NB?=
 =?utf-8?B?Zm9DYW9BVGE2aDJnZjVPT2FwNW4vaUdyd2lFTkk0STFDQjRvT2k0cXFFQ2VT?=
 =?utf-8?B?d2MyZ3VpK0twNncxbnBuSzNEK0xBTXhLUTdTQUVkbzVoemIyd0JjVDB4SWdL?=
 =?utf-8?B?enF0dk1YV0JoRVFHdGNqa1ZCUXc1R3RvblJUTXlENUI3cnVORzdoY0VDRDJn?=
 =?utf-8?B?WGV5ZHc4TDY1RFFFWWd4anlPREJIbmpsbXIxSHFOcmdLeFFpZjUzRE5GU3pn?=
 =?utf-8?B?N0ZoVUZSdmJGZm5zdmw2SVNNQXpvbGwxUUNvRWV4ckNYa005UDU1MGNGTGQz?=
 =?utf-8?B?SEVkcVVvTnFWR0o5ejFlSXVCdnpPeUIyOWJLdHdCUE1NMk5CRm5JNVdpN3Nw?=
 =?utf-8?B?QnF5Z2dZZE03bktZTFgrbkxUY09FS1h6aEpyY1M2SHdCUGNXYTFuc1h2Uy92?=
 =?utf-8?B?KzJxWjVET2ZZZGlNTnF5UmFjN1VKdzh4SXJHRERGZ3I4RmQvQ0kzdVhxUDVQ?=
 =?utf-8?B?S0ZKekhDRlVHUTlSZzQ3ZXNpSmFkS0lBNTJsb3pRaWI3YmVUMWdVZlFVemJh?=
 =?utf-8?B?RjJ0anRUc2l4bTBDQ0E2czcvUTFRamVXa0k1RW9pbkt5SUM0WUNaWFhObGZY?=
 =?utf-8?B?bjZDZEhkaGNuZVEwdVNjbnc1VEZ2M3NRY2M2bnFjZkYrQ1hHNFltOHNWQU1V?=
 =?utf-8?B?REduNU10b1BTRTF0NTl2SFk1c0pXL1I3c3AzQkdsUWN6MUY3WUg5U09vUDNw?=
 =?utf-8?B?M1piYVVFUlo1Qk5IWFhnZ2lkbW15ajcxN2dMclI5V0lyOEVnTmVldnF0OGhX?=
 =?utf-8?B?bE1JdUJKdkp0eEJ6OUtENFhtdjNKSGdCY1IzdVRLemtlV0FneTVGVEttZWxa?=
 =?utf-8?B?WGtiWi9KV0F1ZVZNREZwNWxLS2MwUlVWOVZlT2phc3cvOE1RR2NMZkQ2WlRI?=
 =?utf-8?B?OFJobmV2ZkY1eXVBYnZES01ETWxNOGJuR2d1ZTAzV1NCcmFYL0RxOGtWQStH?=
 =?utf-8?B?c1UrSUFkMUZSZG9FczBrY3pSR1VyL3FoZ1hTLzZnV0l5a2VUSEQwME1uV1VI?=
 =?utf-8?B?d3QrYjhxcENtYTRIaE1FU1ZkYklKemJVczJvdi8vRnRpTXpKSzRSdWF5QlpO?=
 =?utf-8?B?MzE1V3pWejU0clJ5cFJLQk42WjNDZUFNSFJtS05EK0I5dkJIMlpDc05lRW4r?=
 =?utf-8?B?V3lTbVJ2c2xQNmdZMkRrdzNGNitBTUoyS1pVSVBlaThTS0VXNG1JQ0hsREU2?=
 =?utf-8?B?UEpsY1lzb1d0WXdEeE42bGJjdXZUOUVZY0tkYlJDVUZJTzlUUmgvaHNKZ1gw?=
 =?utf-8?B?OCtTUUkrTVlTUHRFbERPdGo5WWlGUnp4TzU0ZkpxNGNoUjhLRjZMdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 024289db-c4be-4ab4-6b62-08da2696fd57
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:38:36.4442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +VzYyKTRyt6dCKW8dDbGLYv6niNWOFdSKAQ+GCN5TveojwzsCU3CvZpaHSudkuuoj5h15ylA8yUlizQ82Kkspg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8638

... depending on feature availability (and absence of quirks).

Also make the page table dumping function aware of superpages.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
---
v4: Change type of queue_free_pt()'s 1st parameter. Re-base.
v3: Rename queue_free_pt()'s last parameter. Replace "level > 1" checks
    where possible. Tighten assertion.

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -784,18 +784,37 @@ static int __must_check cf_check iommu_f
     return iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
 }
 
+static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int level)
+{
+    if ( level > 1 )
+    {
+        struct dma_pte *pt = map_domain_page(mfn);
+        unsigned int i;
+
+        for ( i = 0; i < PTE_NUM; ++i )
+            if ( dma_pte_present(pt[i]) && !dma_pte_superpage(pt[i]) )
+                queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(pt[i])),
+                              level - 1);
+
+        unmap_domain_page(pt);
+    }
+
+    iommu_queue_free_pgtable(hd, mfn_to_page(mfn));
+}
+
 /* clear one page's page table */
 static int dma_pte_clear_one(struct domain *domain, daddr_t addr,
                              unsigned int order,
                              unsigned int *flush_flags)
 {
     struct domain_iommu *hd = dom_iommu(domain);
-    struct dma_pte *page = NULL, *pte = NULL;
+    struct dma_pte *page = NULL, *pte = NULL, old;
     u64 pg_maddr;
+    unsigned int level = (order / LEVEL_STRIDE) + 1;
 
     spin_lock(&hd->arch.mapping_lock);
-    /* get last level pte */
-    pg_maddr = addr_to_dma_page_maddr(domain, addr, 1, flush_flags, false);
+    /* get target level pte */
+    pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, false);
     if ( pg_maddr < PAGE_SIZE )
     {
         spin_unlock(&hd->arch.mapping_lock);
@@ -803,7 +822,7 @@ static int dma_pte_clear_one(struct doma
     }
 
     page = (struct dma_pte *)map_vtd_domain_page(pg_maddr);
-    pte = page + address_level_offset(addr, 1);
+    pte = &page[address_level_offset(addr, level)];
 
     if ( !dma_pte_present(*pte) )
     {
@@ -812,14 +831,20 @@ static int dma_pte_clear_one(struct doma
         return 0;
     }
 
+    old = *pte;
     dma_clear_pte(*pte);
-    *flush_flags |= IOMMU_FLUSHF_modified;
 
     spin_unlock(&hd->arch.mapping_lock);
     iommu_sync_cache(pte, sizeof(struct dma_pte));
 
     unmap_vtd_domain_page(page);
 
+    *flush_flags |= IOMMU_FLUSHF_modified;
+
+    if ( order && !dma_pte_superpage(old) )
+        queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)),
+                      order / LEVEL_STRIDE);
+
     return 0;
 }
 
@@ -2097,6 +2122,7 @@ static int __must_check cf_check intel_i
     struct domain_iommu *hd = dom_iommu(d);
     struct dma_pte *page, *pte, old, new = {};
     u64 pg_maddr;
+    unsigned int level = (IOMMUF_order(flags) / LEVEL_STRIDE) + 1;
     int rc = 0;
 
     /* Do nothing if VT-d shares EPT page table */
@@ -2121,7 +2147,7 @@ static int __must_check cf_check intel_i
         return 0;
     }
 
-    pg_maddr = addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), 1, flush_flags,
+    pg_maddr = addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), level, flush_flags,
                                       true);
     if ( pg_maddr < PAGE_SIZE )
     {
@@ -2130,13 +2156,15 @@ static int __must_check cf_check intel_i
     }
 
     page = (struct dma_pte *)map_vtd_domain_page(pg_maddr);
-    pte = &page[dfn_x(dfn) & LEVEL_MASK];
+    pte = &page[address_level_offset(dfn_to_daddr(dfn), level)];
     old = *pte;
 
     dma_set_pte_addr(new, mfn_to_maddr(mfn));
     dma_set_pte_prot(new,
                      ((flags & IOMMUF_readable) ? DMA_PTE_READ  : 0) |
                      ((flags & IOMMUF_writable) ? DMA_PTE_WRITE : 0));
+    if ( IOMMUF_order(flags) )
+        dma_set_pte_superpage(new);
 
     /* Set the SNP on leaf page table if Snoop Control available */
     if ( iommu_snoop )
@@ -2157,8 +2185,14 @@ static int __must_check cf_check intel_i
 
     *flush_flags |= IOMMU_FLUSHF_added;
     if ( dma_pte_present(old) )
+    {
         *flush_flags |= IOMMU_FLUSHF_modified;
 
+        if ( IOMMUF_order(flags) && !dma_pte_superpage(old) )
+            queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)),
+                          IOMMUF_order(flags) / LEVEL_STRIDE);
+    }
+
     return rc;
 }
 
@@ -2516,6 +2550,7 @@ static int __init cf_check vtd_setup(voi
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
+    unsigned int large_sizes = PAGE_SIZE_2M | PAGE_SIZE_1G;
     int ret;
     bool reg_inval_supported = true;
 
@@ -2558,6 +2593,11 @@ static int __init cf_check vtd_setup(voi
                cap_sps_2mb(iommu->cap) ? ", 2MB" : "",
                cap_sps_1gb(iommu->cap) ? ", 1GB" : "");
 
+        if ( !cap_sps_2mb(iommu->cap) )
+            large_sizes &= ~PAGE_SIZE_2M;
+        if ( !cap_sps_1gb(iommu->cap) )
+            large_sizes &= ~PAGE_SIZE_1G;
+
 #ifndef iommu_snoop
         if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
             iommu_snoop = false;
@@ -2629,6 +2669,9 @@ static int __init cf_check vtd_setup(voi
     if ( ret )
         goto error;
 
+    ASSERT(iommu_ops.page_sizes == PAGE_SIZE_4K);
+    iommu_ops.page_sizes |= large_sizes;
+
     register_keyhandler('V', vtd_dump_iommu_info, "dump iommu info", 1);
 
     return 0;
@@ -2961,7 +3004,7 @@ static void vtd_dump_page_table_level(pa
             continue;
 
         address = gpa + offset_level_address(i, level);
-        if ( next_level >= 1 ) 
+        if ( next_level && !dma_pte_superpage(*pte) )
             vtd_dump_page_table_level(dma_pte_addr(*pte), next_level,
                                       address, indent + 1);
         else



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:40:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:40:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312547.529841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuGT-0003Br-U2; Mon, 25 Apr 2022 08:40:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312547.529841; Mon, 25 Apr 2022 08:40:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuGT-0003Bk-QR; Mon, 25 Apr 2022 08:40:13 +0000
Received: by outflank-mailman (input) for mailman id 312547;
 Mon, 25 Apr 2022 08:40:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuGT-0003Bc-1g
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:40:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 51ae4a43-c473-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:40:11 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-3F6FFF6yNJy5jC8k8S1EAA-1; Mon, 25 Apr 2022 10:40:09 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB3024.eurprd04.prod.outlook.com (2603:10a6:802:d::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Mon, 25 Apr
 2022 08:40:06 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:40:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51ae4a43-c473-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876011;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Rl/rdFZhS9nc5eyV5hC8ECsbWBsvtfY3/7jS7Dgl1JE=;
	b=EoABwmeuWlggepzpWtkjaJD32vsbewyVuKdu4X8SPf9+itK/SyDBtqJnvQ+/27em3YgeUQ
	bqiiVpm5eQFP4KWrBe4hmdmZY9vB5bBR6yCjVP2jNZOMwHZGgYuIEADqgCwZEL8UQkN7ht
	wd4mvMTxw24yTrTB7l3XIyxgM5biQRY=
X-MC-Unique: 3F6FFF6yNJy5jC8k8S1EAA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LXMyRwtIGfrvAAIAB1EYQmowUJqPgI4gjMD/0XF9WPzaYETlnEGaTN/Rq4UcAC+cDzdlUIrGEDklMl35dGPn1iRNCvWOA2j9EBpO2nnCbrokmAdEexQ93k2eQe+Hj+s8i2hXXKEtwhEg8b6THaH75vje/NKBWui/TVvC+UPPvzpJ3K6r3Nw0mjpi0sgN8MBd0b1vDOvHR2n47evm3786xzxbXNPo3mPIsaSRHnOPtWkLm36AA7TocdGGZD3R+OTpAsbA43uZKNFkOSe3DRZ7vOKic0qSK8dxX9q+sfTeDxtX/Hl5F6+YDS/FoHP70DDXxPPjr1uHVqlnVuWa5MlbBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cKU8QBhqAL8on7QC3DOwvdl/zHdOAjDj5Tns2U4wJto=;
 b=ZQDFbAIlAKOsg8tpHOqv3qSiWq5BKfaGsyREXhcvIL6ArFy5OWtQDo7UR9bgKw1znN+IunRBiZHWVb18mqIbXJtOSKNksYpmfR9a2doRNJOrDmjmaNqWSjIRG8ia+kX/SdPemvGAYNLHltjxIe6Bf9+wn2g3qVsZ9F0T5vzf7fPe95NmhJ1KTpBj1H307oaYJanfrgR7AWHwOlqkAPUZqcXR5udhBhhy4+J3yBHF8TgLLFjhL7CFm3H9x4HXvnJXVlZO7XiW2Ds+CcQGDCAKo9uXzk8WEFZB31OoBwALtLt1r9Cmof7lTZUomVA1UT+BFSkeH8+zjrkamgLWYyclSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <024c89df-9cf9-4d74-116d-ca8481dca90b@suse.com>
Date: Mon, 25 Apr 2022 10:40:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 12/21] IOMMU: fold flush-all hook into "flush one"
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR2P281CA0010.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 82bd58dc-66e2-41ee-fbc4-08da269732bd
X-MS-TrafficTypeDiagnostic: VI1PR04MB3024:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3024AE15395232B9B9F36AFEB3F89@VI1PR04MB3024.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FPaoW+yJEZmfxGVw+R5ApLtETmbykN4S76uLHfqFCkHdkJGRbPxKqJg8ESda51jdqkUreXGpUeuKCbNCMPPqtd0yM9SmyC+aSPExNRgpgHCI5/asGdGTHTUamNzR2I2rLNroVU2JSE9TIQDMQAalmCOOxtzjn0A1cplR1X/6Jhdwa++DLdLxJaSxYIUNZy6ifP984huGp0P8L9scmm+lXYn4VHL0igzbyGMGvBNtoiuGuYT+yXCSJu/CkK6M0phe2hBbcTmDn9y39qKoX2JUpMlikJwjuS5OmbLdn24mSqPOEhnmRgUmPUyt4+G8PZrTWNyo50hy6nD2lpVHpZvPFOWqqmzncFOdKTRwyEvrV2e/nwwGaaZYnALMY4o37cOiORh9XxGYN9jP0+OC6JiNDxF9NsQVxwjBW3twkFndoqjqJ/UQjO3yBkUmLQqewcOH5t8N+mfKg4zboA9S65mljxTmdQ+EQg+fPnyuDJjp1Ouzwmz6lgt1toOi2v1cJAsB5RvUWL5FGJwZZVNLeuRvSmgDdP/FfhMLSo5lIcRQj0/NchA0heQsb07kM/HYgv/H87Oym3wQV+mUmXxcxDJ2iQDJI6Vp7Scw92TjtIIOqWkAmpmp4+AfACGr0Fe5wh8MRSIY9b7t9CsrTheYXXIUAaj1BhUaUyj7wEuxV2VIhPJ2NMw1h25euuXwkwG3K0pAdsd377Ifw6ex6MyRiV6SlnwNB+haB70Z6tlxqqbr0lM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(86362001)(38100700002)(31696002)(508600001)(186003)(2616005)(83380400001)(8936002)(6486002)(26005)(6506007)(66946007)(6512007)(66556008)(36756003)(2906002)(6916009)(66476007)(31686004)(54906003)(4326008)(8676002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6wHeL+SCGwc0O6Z++agJmn05CcUEssKj/mai+ElDXgdOt6jQUGGhrnEa9Q8m?=
 =?us-ascii?Q?pI7l62yKdNCgS0oi/OfG05fszUNAc4/YdwU8lmnEHDoafZy8B/CYh4WfKjy4?=
 =?us-ascii?Q?jvfa/6FZIcm1O/Eh5+lrDitGPSTa+3ZTwnq8fQ44VemR3ZEcwg4C6GGxYcxN?=
 =?us-ascii?Q?dPiyoH+Unx+d+xEdVyThwSz9ltgsxBbVMCMfbUEQ1ia1Fh1oFyVfTa0H5iqZ?=
 =?us-ascii?Q?3e73uRx6KsaqChbNZeebEX4oGXlBsKFr8bB+21exyK08iGHsurUWihAz6UAq?=
 =?us-ascii?Q?UTW4QH94sn/F6QAfy1p/sT+2losEMwFfJ0cCk8ZK4iZkehEK08i92U1zjK2U?=
 =?us-ascii?Q?EsPHM5Bk3tbuGGyS0NP3EIGvtYK2Kyv2yVvdFXLt0z1gLFe/FVd+Lhao8fXz?=
 =?us-ascii?Q?VjtUREzfEJVy219XvUn2GtI3wonbBW4Fr3MdlnGb7sNBdL7Gv9ihnw26i0Kw?=
 =?us-ascii?Q?SxhbGSy7X2A4vQqPs+m2j7VZP6YXGi03uRZALrmIWf1s/o3FXwT3zbYCd0+j?=
 =?us-ascii?Q?pCiovVkFYaFTMzgcOi7cviWgSmnEiKukcGVADVjv47kRyaB1VpCug1kViZSd?=
 =?us-ascii?Q?JkQu9gbfJSjSmT+CBd32JIqBo1XMaKMWLE06wMjJoAbO7Tg9vtQJCuSSPqcz?=
 =?us-ascii?Q?4UOuIQ+cSw4WNx+0GNrya3K8J7R0kdNcz/wqy1LVLXmRibQfkKzmYD4vjWKe?=
 =?us-ascii?Q?Nb0i1eWzyw4B4rALrrRH/DGci4l33unurIzPE/Om/5lwcxBVmmEzj3GCD8zP?=
 =?us-ascii?Q?RWHndz7IZlCzRLvbj6eBeBEgekqYDQWEdVtU47R47vdK0KfHAgohcrJTeA39?=
 =?us-ascii?Q?sNto59bGlHT3C6WLONK9fpXAtXn8DUoQBLq3gWjwUDursmUrMPapu0aLPRfz?=
 =?us-ascii?Q?8okzHAkXEUdoftInLNRWFKqueJEQPctQK+hULsuf/N6Oqn36teVSsTPUeGsz?=
 =?us-ascii?Q?+X6hAPGXatkq2nDrBTNgPGn/QiZy3+hwq6wMCM9MaMmndROYDTWDqFLXo37r?=
 =?us-ascii?Q?vZqy7cXXDkiZTcp/dTCfrqZRFfczs/WAQzA6VAO1t8/g46z3TdoJXsmItWMj?=
 =?us-ascii?Q?o82qFnk6o/hoQF/ynHeTiCFmhcDowjr5lMkMyQIfidoXuCwGSJ+z/RnpoHhY?=
 =?us-ascii?Q?LGe43wkTu405mxVdtIjxmj99WvW0Tj0BOpoQGsmgW1qfqnnaHOTtfR8T66Gx?=
 =?us-ascii?Q?esh3/oz3AMBNEzYn3qz7f2vc2a4GkEBqrjeuO2WJTBRe7QYVv5s+aFXPDXbt?=
 =?us-ascii?Q?GZkUjKiA7faN2ktybopOOzKnmp2dBjvf4kxNl47YBkZ5KPJDMTGJGa81jibj?=
 =?us-ascii?Q?KItB8ZNqck5i/Kn+OPTmXac2nMTJkw+mL4ifJnLQUxIigydKkqwGJ5rSP+CD?=
 =?us-ascii?Q?Ie5M0QjaTPFUBxk2O2vQx6HE7XMxJ8k5/fUrg/CshONpnW7FUhQtiV97ANOl?=
 =?us-ascii?Q?g4Q/GdSzyCoq/xruGDPUFjXta5QudSszVo9846aNXxlsK2J1uY/Z/D60zgaw?=
 =?us-ascii?Q?uPJ9UIvN4pif/LHd4bZsv4sYqvi9/ar1INrt7tO7FZ2Z/PQIl0B047KJtB93?=
 =?us-ascii?Q?DYDyDetZAN1Nr1lYqORpITxcTVazHbHXk+uhPvTG+omtmSDZ0C7ndFnRxJeZ?=
 =?us-ascii?Q?1C4CyHDvhkOZnug6KwolIPCo1sbdhKGb/dEYHj2zNNdMzT54f+VaH6mvlH7T?=
 =?us-ascii?Q?qWGfedbf1wO0zSpSpeuOJi6tBy9A3uZ7+IwhX63aSYS4GJiMkZ6PBEUbhtN2?=
 =?us-ascii?Q?rKJHk7TSMQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82bd58dc-66e2-41ee-fbc4-08da269732bd
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:40:06.0657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uVB+Hh6GpwtGZPGomUBi9S2PMHQ5b0XT0eTEr9YF7a3Q4JuqIbi9RTjhzfMCHKrF5cf9FY2WgFTQIR+QdVIFPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3024

Having a separate flush-all hook has always been puzzling me some. We
will want to be able to force a full flush via accumulated flush flags
from the map/unmap functions. Introduce a respective new flag and fold
all flush handling to use the single remaining hook.

Note that because of the respective comments in SMMU and IPMMU-VMSA
code, I've folded the two prior hook functions into one. For SMMU-v3,
which lacks a comment towards incapable hardware, I've left both
functions in place on the assumption that selective and full flushes
will eventually want separating.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> # IPMMU-V=
MSA, SMMU-V2
Reviewed-by: Rahul Singh <rahul.singh@arm.com> # SMMUv3
Acked-by: Julien Grall <jgrall@amazon.com> # Arm
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
---
TBD: What we really are going to need is for the map/unmap functions to
     specify that a wider region needs flushing than just the one
     covered by the present set of (un)maps. This may still be less than
     a full flush, but at least as a first step it seemed better to me
     to keep things simple and go the flush-all route.
---
v4: Re-base.
v3: Re-base over changes earlier in the series.
v2: New.

--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -258,7 +258,6 @@ int cf_check amd_iommu_get_reserved_devi
 int __must_check cf_check amd_iommu_flush_iotlb_pages(
     struct domain *d, dfn_t dfn, unsigned long page_count,
     unsigned int flush_flags);
-int __must_check cf_check amd_iommu_flush_iotlb_all(struct domain *d);
 void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int d=
ev_id,
                              dfn_t dfn);
=20
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -539,15 +539,18 @@ int cf_check amd_iommu_flush_iotlb_pages
 {
     unsigned long dfn_l =3D dfn_x(dfn);
=20
-    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
-    ASSERT(flush_flags);
+    if ( !(flush_flags & IOMMU_FLUSHF_all) )
+    {
+        ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
+        ASSERT(flush_flags);
+    }
=20
     /* Unless a PTE was modified, no flush is required */
     if ( !(flush_flags & IOMMU_FLUSHF_modified) )
         return 0;
=20
-    /* If the range wraps then just flush everything */
-    if ( dfn_l + page_count < dfn_l )
+    /* If so requested or if the range wraps then just flush everything. *=
/
+    if ( (flush_flags & IOMMU_FLUSHF_all) || dfn_l + page_count < dfn_l )
     {
         amd_iommu_flush_all_pages(d);
         return 0;
@@ -572,13 +575,6 @@ int cf_check amd_iommu_flush_iotlb_pages
=20
     return 0;
 }
-
-int cf_check amd_iommu_flush_iotlb_all(struct domain *d)
-{
-    amd_iommu_flush_all_pages(d);
-
-    return 0;
-}
=20
 int amd_iommu_reserve_domain_unity_map(struct domain *d,
                                        const struct ivrs_unity_map *map,
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -759,7 +759,6 @@ static const struct iommu_ops __initcons
     .map_page =3D amd_iommu_map_page,
     .unmap_page =3D amd_iommu_unmap_page,
     .iotlb_flush =3D amd_iommu_flush_iotlb_pages,
-    .iotlb_flush_all =3D amd_iommu_flush_iotlb_all,
     .reassign_device =3D reassign_device,
     .get_device_group_id =3D amd_iommu_group_id,
     .enable_x2apic =3D iov_enable_xt,
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -1000,13 +1000,19 @@ out:
 }
=20
 /* Xen IOMMU ops */
-static int __must_check ipmmu_iotlb_flush_all(struct domain *d)
+static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn,
+                                          unsigned long page_count,
+                                          unsigned int flush_flags)
 {
     struct ipmmu_vmsa_xen_domain *xen_domain =3D dom_iommu(d)->arch.priv;
=20
+    ASSERT(flush_flags);
+
     if ( !xen_domain || !xen_domain->root_domain )
         return 0;
=20
+    /* The hardware doesn't support selective TLB flush. */
+
     spin_lock(&xen_domain->lock);
     ipmmu_tlb_invalidate(xen_domain->root_domain);
     spin_unlock(&xen_domain->lock);
@@ -1014,16 +1020,6 @@ static int __must_check ipmmu_iotlb_flus
     return 0;
 }
=20
-static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn,
-                                          unsigned long page_count,
-                                          unsigned int flush_flags)
-{
-    ASSERT(flush_flags);
-
-    /* The hardware doesn't support selective TLB flush. */
-    return ipmmu_iotlb_flush_all(d);
-}
-
 static struct ipmmu_vmsa_domain *ipmmu_get_cache_domain(struct domain *d,
                                                         struct device *dev=
)
 {
@@ -1360,7 +1356,6 @@ static const struct iommu_ops ipmmu_iomm
     .hwdom_init      =3D arch_iommu_hwdom_init,
     .teardown        =3D ipmmu_iommu_domain_teardown,
     .iotlb_flush     =3D ipmmu_iotlb_flush,
-    .iotlb_flush_all =3D ipmmu_iotlb_flush_all,
     .assign_device   =3D ipmmu_assign_device,
     .reassign_device =3D ipmmu_reassign_device,
     .map_page        =3D arm_iommu_map_page,
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -2649,11 +2649,17 @@ static int force_stage =3D 2;
  */
 static u32 platform_features =3D ARM_SMMU_FEAT_COHERENT_WALK;
=20
-static int __must_check arm_smmu_iotlb_flush_all(struct domain *d)
+static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn,
+					     unsigned long page_count,
+					     unsigned int flush_flags)
 {
 	struct arm_smmu_xen_domain *smmu_domain =3D dom_iommu(d)->arch.priv;
 	struct iommu_domain *cfg;
=20
+	ASSERT(flush_flags);
+
+	/* ARM SMMU v1 doesn't have flush by VMA and VMID */
+
 	spin_lock(&smmu_domain->lock);
 	list_for_each_entry(cfg, &smmu_domain->contexts, list) {
 		/*
@@ -2670,16 +2676,6 @@ static int __must_check arm_smmu_iotlb_f
 	return 0;
 }
=20
-static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn,
-					     unsigned long page_count,
-					     unsigned int flush_flags)
-{
-	ASSERT(flush_flags);
-
-	/* ARM SMMU v1 doesn't have flush by VMA and VMID */
-	return arm_smmu_iotlb_flush_all(d);
-}
-
 static struct iommu_domain *arm_smmu_get_domain(struct domain *d,
 						struct device *dev)
 {
@@ -2864,7 +2860,6 @@ static const struct iommu_ops arm_smmu_i
     .add_device =3D arm_smmu_dt_add_device_generic,
     .teardown =3D arm_smmu_iommu_domain_teardown,
     .iotlb_flush =3D arm_smmu_iotlb_flush,
-    .iotlb_flush_all =3D arm_smmu_iotlb_flush_all,
     .assign_device =3D arm_smmu_assign_dev,
     .reassign_device =3D arm_smmu_reassign_dev,
     .map_page =3D arm_iommu_map_page,
--- a/xen/drivers/passthrough/arm/smmu-v3.c
+++ b/xen/drivers/passthrough/arm/smmu-v3.c
@@ -3416,7 +3416,6 @@ static const struct iommu_ops arm_smmu_i
 	.hwdom_init		=3D arch_iommu_hwdom_init,
 	.teardown		=3D arm_smmu_iommu_xen_domain_teardown,
 	.iotlb_flush		=3D arm_smmu_iotlb_flush,
-	.iotlb_flush_all	=3D arm_smmu_iotlb_flush_all,
 	.assign_device		=3D arm_smmu_assign_dev,
 	.reassign_device	=3D arm_smmu_reassign_dev,
 	.map_page		=3D arm_iommu_map_page,
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -478,15 +478,12 @@ int iommu_iotlb_flush_all(struct domain
     const struct domain_iommu *hd =3D dom_iommu(d);
     int rc;
=20
-    if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush_all ||
+    if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush ||
          !flush_flags )
         return 0;
=20
-    /*
-     * The operation does a full flush so we don't need to pass the
-     * flush_flags in.
-     */
-    rc =3D iommu_call(hd->platform_ops, iotlb_flush_all, d);
+    rc =3D iommu_call(hd->platform_ops, iotlb_flush, d, INVALID_DFN, 0,
+                    flush_flags | IOMMU_FLUSHF_all);
     if ( unlikely(rc) )
     {
         if ( !d->is_shutting_down && printk_ratelimit() )
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -772,18 +772,21 @@ static int __must_check cf_check iommu_f
     struct domain *d, dfn_t dfn, unsigned long page_count,
     unsigned int flush_flags)
 {
-    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
-    ASSERT(flush_flags);
+    if ( flush_flags & IOMMU_FLUSHF_all )
+    {
+        dfn =3D INVALID_DFN;
+        page_count =3D 0;
+    }
+    else
+    {
+        ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
+        ASSERT(flush_flags);
+    }
=20
     return iommu_flush_iotlb(d, dfn, flush_flags & IOMMU_FLUSHF_modified,
                              page_count);
 }
=20
-static int __must_check cf_check iommu_flush_iotlb_all(struct domain *d)
-{
-    return iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
-}
-
 static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int=
 level)
 {
     if ( level > 1 )
@@ -3185,7 +3188,6 @@ static const struct iommu_ops __initcons
     .resume =3D vtd_resume,
     .crash_shutdown =3D vtd_crash_shutdown,
     .iotlb_flush =3D iommu_flush_iotlb_pages,
-    .iotlb_flush_all =3D iommu_flush_iotlb_all,
     .get_reserved_device_memory =3D intel_iommu_get_reserved_device_memory=
,
     .dump_page_tables =3D vtd_dump_page_tables,
 };
--- a/xen/include/xen/iommu.h
+++ b/xen/include/xen/iommu.h
@@ -147,9 +147,11 @@ enum
 {
     _IOMMU_FLUSHF_added,
     _IOMMU_FLUSHF_modified,
+    _IOMMU_FLUSHF_all,
 };
 #define IOMMU_FLUSHF_added (1u << _IOMMU_FLUSHF_added)
 #define IOMMU_FLUSHF_modified (1u << _IOMMU_FLUSHF_modified)
+#define IOMMU_FLUSHF_all (1u << _IOMMU_FLUSHF_all)
=20
 int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn,
                            unsigned long page_count, unsigned int flags,
@@ -281,7 +283,6 @@ struct iommu_ops {
     int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn,
                                     unsigned long page_count,
                                     unsigned int flush_flags);
-    int __must_check (*iotlb_flush_all)(struct domain *d);
     int (*get_reserved_device_memory)(iommu_grdm_t *, void *);
     void (*dump_page_tables)(struct domain *d);
=20



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:41:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:41:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312552.529851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuHG-0003kh-7T; Mon, 25 Apr 2022 08:41:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312552.529851; Mon, 25 Apr 2022 08:41:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuHG-0003ka-3l; Mon, 25 Apr 2022 08:41:02 +0000
Received: by outflank-mailman (input) for mailman id 312552;
 Mon, 25 Apr 2022 08:41:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuHE-0003e7-3Z
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:41:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6dee6dec-c473-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:40:59 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-qKVd713AP8u-SNmZDmSHuw-1; Mon, 25 Apr 2022 10:40:56 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB3024.eurprd04.prod.outlook.com (2603:10a6:802:d::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Mon, 25 Apr
 2022 08:40:54 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:40:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6dee6dec-c473-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876058;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=E9yc1zY4O0b+hMzg6Cm9cySZnRsS6KKgNE5TEN/QJ18=;
	b=CikhCdS8ajxONqf5C6XjXIWuO+bWXh8QViRTJh9R/n/MCwINRvaH949NCWwLHAfpt9QK8y
	6m74sz4zgrbINCWPREuSKQC1WMnmE4zOXwzGZ2EmoSKDQAnYxVuuJPRSm1dbHMMxROcdQn
	uz3uLaviBln6h305CGUjSZtRHEySzxk=
X-MC-Unique: qKVd713AP8u-SNmZDmSHuw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QZ3B+4Gko45DPdGlbaO0jJGgyVkv98b2YSclDN5loclZQ9blMzSMKSWk+pym9uK8qp/qf9VJf1Jd0M+VBbhL1ey62j89w8Ncr3x+ZcPlkqCduVz7lLw+3l9ubMeRgV1qOTaBeHCs7JUp/U3EqWp5Nhaur47qBE0JLDD/BlZuyZAcujlikoQU5CVtUSf5xMEC2/hqs4DUBy+NenOtVw5RGgaAHELwVzXedxp/cxxf2JycTZgMN930vfhjJg2+rknsAYFCmR/L+iIEX4Mw2ICO6GgvcP/aw1nBuvs8feFXkG8bS0EqMmbg5vqvYpvMrboSvH9wCm++a2USIpd0mA1HNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E9yc1zY4O0b+hMzg6Cm9cySZnRsS6KKgNE5TEN/QJ18=;
 b=Og3m297lwLlYjVavG2aYsKXYvsoX1W1AAH2lUQ9aqS9qz7I4pQKXqsKe3u/V6lGcoAJM7aamhP0GzibROlqHK7uO9SHkejQzIf/OKNOotGYX969gHGPcwQDu/g/iZuDpR4I2Uupu9x3El0ig4BSZyLG9S5RRPIvNX4a25aSOXcGiZ+ii6acBhOKdCA7lR0kWnSz03xuv5cY0c0kVz78LKR0IIIPZ+TCruWTkxvyK5QTCnyRiOfMniqKf2sBFtnobGlLfUhXR2moEyT/v/g/PtbRxf4icqgudNbYjI5YwEUsEUoKwL+D7UCy3qcVEMyKZREtzbSz2SkW7CxIQPH0ZCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com>
Date: Mon, 25 Apr 2022 10:40:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0009.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a::19) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 555bda5b-d73c-403f-75b0-08da26974fb0
X-MS-TrafficTypeDiagnostic: VI1PR04MB3024:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3024B9415DD75825B8461FEDB3F89@VI1PR04MB3024.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tfcakujOkl5oXtmD+8ssxSE6hPhUjc+RpA2hOuPX6ogxJJTPSHZwCoTb3SZE4gv75gsmVA3ElV9E6nimjzLI4NI8mwCMAG4ucEPKxbKo6iLN28QeqAQyGFRdHTDPXFJMpqUiphV1HRwZ+S3nBZG3bR5lRdw2qJ/oj2VVKU1rBhL90RQo9ndzo7VtW1BJ29J9p47xkcDhwTlSLcaS5syZSVj7rH5vSDmqpbDIOp8BPCwh3DuylogMc+BAK1UdsN+nIa4p38qZyiFh0VAP2YQbntsOdkbB13/ipgiL2ULea72R+gNM0yIzX/KBp0OqL7d6kZSn5+UH65YDOSXcaFhCwgSGyaIWrFCxKfBYKyAX2xnatV5nAOGQ9wsL7+2Q3eMoDgUIlKGmpU+pjzeSjSOKa7rcOfPVwvIU56Zg1A0tOTNPfF6wLHCcVVEcDMsJw2PX4sCOl+KuAqW0dAjpDwu6N5UWKYxScJI+LbFX2PKWYlnAhkECyqbl26adq7hDw8272VwfPF4uyLu3A3m2n+6lpGy3pj6v1v+MDiMaPAPt3Rn3lCe/HrAHzoyxcREBq8bTIfCzSegkb5N/pFSuUlTfwN+6USWx9Ipv5oyywDJmUWVeCMn8KbEnXkpGCUX1iP8K0FOxz9HXJLbvCdgaDsNomwbQkJBDz5a7GVyjgRlfYnKhJeZSsCD5hvdTTZ0v2RLoyY7/y5DPrzJZc82HWijGz2Ax+DHTv/52Z83AgiKQoXM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(86362001)(38100700002)(31696002)(508600001)(186003)(2616005)(83380400001)(8936002)(6486002)(26005)(6506007)(66946007)(6512007)(66556008)(36756003)(2906002)(6916009)(66476007)(31686004)(54906003)(4326008)(8676002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjJjL0xHUWhGZUgwUy8vOWRSNXV2dnhlWnBrWnd6S2FLMmdrdGZJSzRYL3Rj?=
 =?utf-8?B?TFZrNUdwMlU2NVM0SWk0TFBzMk10ZkVla3VUZUZNVHlKVjVwY3hYWmQycWJn?=
 =?utf-8?B?dDNKdVVJTVhRM0RHNHVjR1BvOC82Y1VyZmVRZkRzMlp6UHpRU3VDM2g3dVU1?=
 =?utf-8?B?RzNoWE11RHpxRUU0MVNxS0R5OGNtd05xV0hneU5NNkdpTFFialRqOXA0Y2RW?=
 =?utf-8?B?RVQ2RWZaSERxcjFlWWdVc1kzYXk3a2VUK3djWU82akx5Qm1KckpSUGg5bkFX?=
 =?utf-8?B?ckpRMGt4WXdBdEU4eHZQQlF3cWN2YjRwUDNMOThDam55Zmp2RlY5OFhoUk5z?=
 =?utf-8?B?TjdWVUQ5Q25vNGNKZWlWZDByMm1OTi9yYzI5eE8zaGZCQkxpRmRJVDh3N2xq?=
 =?utf-8?B?VytQaGRFUWhYYUd0MkduR1lnRFZEbUtvMXFsVlc5N04zZFlOdGtqTDhDTHFl?=
 =?utf-8?B?cVNjNkVSZWlEUFUzbWp6WngxZHFEaEYwM1BXRTRkeXB1UFRrcTJrSTRpYVd2?=
 =?utf-8?B?eW0xWkhvUmczVncxWnZWUWEyRGtnYmx5UlFtYzIwaFZvRmVUR3R6TVF5dGVx?=
 =?utf-8?B?QkRYbTA2QmFnWWhRK25LcjhScnltTlBxOVNWSTVja05XbnNIUWYrZDVrNzdq?=
 =?utf-8?B?Q0dPR2lvS2xNZXFkMGJ0bW1oaFRNYVhMVGVUQWxtYmlRTzRRNXVtRy9VZzZs?=
 =?utf-8?B?UFNieG5WQ3FUTUZqQi9vY3d1cUhsZzhGT3ViZXBRbDk3UFJOb3ZHMWVBZXdz?=
 =?utf-8?B?aFZFdzllenNlL2Zrd0dNdmRBL3lFUFR3YU9SNjdadGh6SnRZOS9Va00wU21i?=
 =?utf-8?B?M1M4Q3dxK0I0bjFtQ2lCUmdjOUUrMmtnVGhMRUZNcldPcE8vanB6WHlhV1JY?=
 =?utf-8?B?OUpsM0FPRzlHSS9yZWJmcVdoWm5KNkJrN0xjTUJjenBBcEJBaGZ2cGY2Q0Ri?=
 =?utf-8?B?RitYeTlRNVUyUDVVZVMxYWhHM2EyRWhGbE9WVGtHUUV4WnlhU3JlSWVUc3cv?=
 =?utf-8?B?YW5UcVFnMHFvSTRoelZHZzlUZnkxK2RzTlV3RkJIY2E0Q1lYaG9FdWZDQjkw?=
 =?utf-8?B?amt3TDJ4M1dGM1FYVWEzdDYyeEthVE8wbUlIMSs1cmozUnhyKzMwemVpQWEv?=
 =?utf-8?B?V2xMc2ZNV2VhTFRoU0ZlR2x6YWZsaS95UytFUjFXajN2U1lHZUNEK0hzcW9M?=
 =?utf-8?B?YzJaSHBCNkpGYnltQWYxVGVzcFVVaDJDUHNIa3BoUlpEUVlWWUE2L2JDakVY?=
 =?utf-8?B?QndpdXJOenZJbEU5UEZabDlTWE45cUFPd1M2enhtbDI3c3BZbSt3N2o1RkJ0?=
 =?utf-8?B?WEt1TzVCN1c5M1BuU0VDcE9KQW5Pa2ZpMG5GSlMzSXo3aHpMak1MMDk3blpr?=
 =?utf-8?B?YUNhYWdmeWEwdUtwd0RuclVTRzRzQ1o4djZMVHhzSy8xNzZQeWVzUVl5ekIw?=
 =?utf-8?B?cWhGenJoZjdjcmRhVzdEYW4yaC83RkFRSCtPc05NOWc1bHhJYytZUkkweHFW?=
 =?utf-8?B?d0wrR2JGK055ZUd0OWhWZTBhUWNiQ2lhSFdHanJWM3BXR0I3SG1JSU5XOUc3?=
 =?utf-8?B?MVZyUm1NVmRqT0Q4TWNBNWIyRWlMTkRtcGVnZkFMV2xCMlpIYVNxZ0NhckdW?=
 =?utf-8?B?SWMvRHZ3VTNaZld6R0plL1FvdmJiS2RHK0hQTlhzMFd1eWNuNTlLaWY3NmU5?=
 =?utf-8?B?eWlBQ1VaeURLY2h0N0VKeWs1dld5T0UvSU9RT3VQSnRJWXdRVVJXTURvMWlI?=
 =?utf-8?B?dG1pcktXZG5tM3ZySDV0TVRoYmR6MWNNVllOL0V2UE82SFhnVzFRK2w4bzJV?=
 =?utf-8?B?SGxhdUovd3ROVGRwSlJobjEzb3JpczgzTHVtMFVMcWQ4eFJUKyszT3ZHeUxD?=
 =?utf-8?B?dENTRkFjUWxEdXczS2p3cm1qdkxxeXc1RGhwcURWR0NwVHlsVTV3aFhobE5U?=
 =?utf-8?B?R2RrVEVudlVrVEVudE10cE5FaWhLWUdVbWxqT1ZIb3pJalpPTEprL3BBeUk0?=
 =?utf-8?B?ZDZOT25WVDlsQkRNc1FzK1JsMCs0OUdTV3JBZlgvdkhIQXZlb3JwZWJPVW9y?=
 =?utf-8?B?VjZVamdVTEZ2RDhLc2ZmazdUWllMaUY4Uys5dHZnSitCOHVjdld5SDQvVFhs?=
 =?utf-8?B?VE9Jemt2TlBWbnVScFUzaUhFanFaakR2T0RZT3hTbjNobWFZTFhsSitzYmx5?=
 =?utf-8?B?aTFZNC82WWlQNEpjdVJkcnZiRjYzaGdnZ2pwQkg4K1ZKd1RKZThYbVNKQXZq?=
 =?utf-8?B?cE4yRXMyWklPM0lXaFZOa0JOYUpsM3Z6M0dOVWhwaG1BVmlnbmdvY0tERlNp?=
 =?utf-8?B?bXJ1RHlEYlhLdmxoQXR5cW14alUxUDVFdjVoSDBPZGxUcTkzU29Pdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 555bda5b-d73c-403f-75b0-08da26974fb0
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:40:54.7102
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5cWnBrVPL2oHVweV5swGEksjW6qJ/A9bBdlKBQ0B0qI2xYw/JFmwTOqtWLwSQK8rBDD5Ld9eotQe0+udFh0dXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3024

Page tables are used for two purposes after allocation: They either
start out all empty, or they get filled to replace a superpage.
Subsequently, to replace all empty or fully contiguous page tables,
contiguous sub-regions will be recorded within individual page tables.
Install the initial set of markers immediately after allocation. Make
sure to retain these markers when further populating a page table in
preparation for it to replace a superpage.

The markers are simply 4-bit fields holding the order value of
contiguous entries. To demonstrate this, if a page table had just 16
entries, this would be the initial (fully contiguous) set of markers:

index  0 1 2 3 4 5 6 7 8 9 A B C D E F
marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0

"Contiguous" here means not only present entries with successively
increasing MFNs, each one suitably aligned for its slot, but also a
respective number of all non-present entries.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
---
An alternative to the ASSERT()s added to set_iommu_ptes_present() would
be to make the function less general-purpose; it's used in a single
place only after all (i.e. it might as well be folded into its only
caller).

While in VT-d's comment ahead of struct dma_pte I'm adjusting the
description of the high bits, I'd like to note that the description of
some of the lower bits isn't correct either. Yet I don't think adjusting
that belongs here.
---
v4: Add another comment referring to pt-contig-markers.h. Re-base.
v3: Add comments. Re-base.
v2: New.

--- a/xen/arch/x86/include/asm/iommu.h
+++ b/xen/arch/x86/include/asm/iommu.h
@@ -146,7 +146,8 @@ void iommu_free_domid(domid_t domid, uns
 
 int __must_check iommu_free_pgtables(struct domain *d);
 struct domain_iommu;
-struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd);
+struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd,
+                                                   uint64_t contig_mask);
 void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg);
 
 #endif /* !__ARCH_X86_IOMMU_H__ */
--- a/xen/drivers/passthrough/amd/iommu-defs.h
+++ b/xen/drivers/passthrough/amd/iommu-defs.h
@@ -446,11 +446,13 @@ union amd_iommu_x2apic_control {
 #define IOMMU_PAGE_TABLE_U32_PER_ENTRY	(IOMMU_PAGE_TABLE_ENTRY_SIZE / 4)
 #define IOMMU_PAGE_TABLE_ALIGNMENT	4096
 
+#define IOMMU_PTE_CONTIG_MASK           0x1e /* The ign0 field below. */
+
 union amd_iommu_pte {
     uint64_t raw;
     struct {
         bool pr:1;
-        unsigned int ign0:4;
+        unsigned int ign0:4; /* Covered by IOMMU_PTE_CONTIG_MASK. */
         bool a:1;
         bool d:1;
         unsigned int ign1:2;
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig
 
     while ( nr_ptes-- )
     {
-        set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
+        ASSERT(!pde->next_level);
+        ASSERT(!pde->u);
+
+        if ( pde > table )
+            ASSERT(pde->ign0 == find_first_set_bit(pde - table));
+        else
+            ASSERT(pde->ign0 == PAGE_SHIFT - 3);
+
+        pde->iw = iw;
+        pde->ir = ir;
+        pde->fc = true; /* See set_iommu_pde_present(). */
+        pde->mfn = next_mfn;
+        pde->pr = true;
 
         ++pde;
         next_mfn += page_sz;
@@ -295,7 +307,7 @@ static int iommu_pde_from_dfn(struct dom
             mfn = next_table_mfn;
 
             /* allocate lower level page table */
-            table = iommu_alloc_pgtable(hd);
+            table = iommu_alloc_pgtable(hd, IOMMU_PTE_CONTIG_MASK);
             if ( table == NULL )
             {
                 AMD_IOMMU_ERROR("cannot allocate I/O page table\n");
@@ -325,7 +337,7 @@ static int iommu_pde_from_dfn(struct dom
 
             if ( next_table_mfn == 0 )
             {
-                table = iommu_alloc_pgtable(hd);
+                table = iommu_alloc_pgtable(hd, IOMMU_PTE_CONTIG_MASK);
                 if ( table == NULL )
                 {
                     AMD_IOMMU_ERROR("cannot allocate I/O page table\n");
@@ -717,7 +729,7 @@ static int fill_qpt(union amd_iommu_pte
                  * page table pages, and the resulting allocations are always
                  * zeroed.
                  */
-                pgs[level] = iommu_alloc_pgtable(hd);
+                pgs[level] = iommu_alloc_pgtable(hd, 0);
                 if ( !pgs[level] )
                 {
                     rc = -ENOMEM;
@@ -775,7 +787,7 @@ int cf_check amd_iommu_quarantine_init(s
         return 0;
     }
 
-    pdev->arch.amd.root_table = iommu_alloc_pgtable(hd);
+    pdev->arch.amd.root_table = iommu_alloc_pgtable(hd, 0);
     if ( !pdev->arch.amd.root_table )
         return -ENOMEM;
 
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -342,7 +342,7 @@ int amd_iommu_alloc_root(struct domain *
 
     if ( unlikely(!hd->arch.amd.root_table) && d != dom_io )
     {
-        hd->arch.amd.root_table = iommu_alloc_pgtable(hd);
+        hd->arch.amd.root_table = iommu_alloc_pgtable(hd, 0);
         if ( !hd->arch.amd.root_table )
             return -ENOMEM;
     }
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -334,7 +334,7 @@ static uint64_t addr_to_dma_page_maddr(s
             goto out;
 
         pte_maddr = level;
-        if ( !(pg = iommu_alloc_pgtable(hd)) )
+        if ( !(pg = iommu_alloc_pgtable(hd, 0)) )
             goto out;
 
         hd->arch.vtd.pgd_maddr = page_to_maddr(pg);
@@ -376,7 +376,7 @@ static uint64_t addr_to_dma_page_maddr(s
             }
 
             pte_maddr = level - 1;
-            pg = iommu_alloc_pgtable(hd);
+            pg = iommu_alloc_pgtable(hd, DMA_PTE_CONTIG_MASK);
             if ( !pg )
                 break;
 
@@ -388,12 +388,13 @@ static uint64_t addr_to_dma_page_maddr(s
                 struct dma_pte *split = map_vtd_domain_page(pte_maddr);
                 unsigned long inc = 1UL << level_to_offset_bits(level - 1);
 
-                split[0].val = pte->val;
+                split[0].val |= pte->val & ~DMA_PTE_CONTIG_MASK;
                 if ( inc == PAGE_SIZE )
                     split[0].val &= ~DMA_PTE_SP;
 
                 for ( offset = 1; offset < PTE_NUM; ++offset )
-                    split[offset].val = split[offset - 1].val + inc;
+                    split[offset].val |=
+                        (split[offset - 1].val & ~DMA_PTE_CONTIG_MASK) + inc;
 
                 iommu_sync_cache(split, PAGE_SIZE);
                 unmap_vtd_domain_page(split);
@@ -2173,7 +2174,7 @@ static int __must_check cf_check intel_i
     if ( iommu_snoop )
         dma_set_pte_snp(new);
 
-    if ( old.val == new.val )
+    if ( !((old.val ^ new.val) & ~DMA_PTE_CONTIG_MASK) )
     {
         spin_unlock(&hd->arch.mapping_lock);
         unmap_vtd_domain_page(page);
@@ -3052,7 +3053,7 @@ static int fill_qpt(struct dma_pte *this
                  * page table pages, and the resulting allocations are always
                  * zeroed.
                  */
-                pgs[level] = iommu_alloc_pgtable(hd);
+                pgs[level] = iommu_alloc_pgtable(hd, 0);
                 if ( !pgs[level] )
                 {
                     rc = -ENOMEM;
@@ -3109,7 +3110,7 @@ static int cf_check intel_iommu_quaranti
     if ( !drhd )
         return -ENODEV;
 
-    pg = iommu_alloc_pgtable(hd);
+    pg = iommu_alloc_pgtable(hd, 0);
     if ( !pg )
         return -ENOMEM;
 
--- a/xen/drivers/passthrough/vtd/iommu.h
+++ b/xen/drivers/passthrough/vtd/iommu.h
@@ -253,7 +253,10 @@ struct context_entry {
  * 2-6: reserved
  * 7: super page
  * 8-11: available
- * 12-63: Host physcial address
+ * 12-51: Host physcial address
+ * 52-61: available (52-55 used for DMA_PTE_CONTIG_MASK)
+ * 62: reserved
+ * 63: available
  */
 struct dma_pte {
     u64 val;
@@ -263,6 +266,7 @@ struct dma_pte {
 #define DMA_PTE_PROT (DMA_PTE_READ | DMA_PTE_WRITE)
 #define DMA_PTE_SP   (1 << 7)
 #define DMA_PTE_SNP  (1 << 11)
+#define DMA_PTE_CONTIG_MASK  (0xfull << PADDR_BITS)
 #define dma_clear_pte(p)    do {(p).val = 0;} while(0)
 #define dma_set_pte_readable(p) do {(p).val |= DMA_PTE_READ;} while(0)
 #define dma_set_pte_writable(p) do {(p).val |= DMA_PTE_WRITE;} while(0)
@@ -276,7 +280,7 @@ struct dma_pte {
 #define dma_pte_write(p) (dma_pte_prot(p) & DMA_PTE_WRITE)
 #define dma_pte_addr(p) ((p).val & PADDR_MASK & PAGE_MASK_4K)
 #define dma_set_pte_addr(p, addr) do {\
-            (p).val |= ((addr) & PAGE_MASK_4K); } while (0)
+            (p).val |= ((addr) & PADDR_MASK & PAGE_MASK_4K); } while (0)
 #define dma_pte_present(p) (((p).val & DMA_PTE_PROT) != 0)
 #define dma_pte_superpage(p) (((p).val & DMA_PTE_SP) != 0)
 
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -522,11 +522,12 @@ int iommu_free_pgtables(struct domain *d
     return 0;
 }
 
-struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd)
+struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd,
+                                      uint64_t contig_mask)
 {
     unsigned int memflags = 0;
     struct page_info *pg;
-    void *p;
+    uint64_t *p;
 
 #ifdef CONFIG_NUMA
     if ( hd->node != NUMA_NO_NODE )
@@ -538,7 +539,29 @@ struct page_info *iommu_alloc_pgtable(st
         return NULL;
 
     p = __map_domain_page(pg);
-    clear_page(p);
+
+    if ( contig_mask )
+    {
+        /* See pt-contig-markers.h for a description of the marker scheme. */
+        unsigned int i, shift = find_first_set_bit(contig_mask);
+
+        ASSERT(((PAGE_SHIFT - 3) & (contig_mask >> shift)) == PAGE_SHIFT - 3);
+
+        p[0] = (PAGE_SHIFT - 3ull) << shift;
+        p[1] = 0;
+        p[2] = 1ull << shift;
+        p[3] = 0;
+
+        for ( i = 4; i < PAGE_SIZE / 8; i += 4 )
+        {
+            p[i + 0] = (find_first_set_bit(i) + 0ull) << shift;
+            p[i + 1] = 0;
+            p[i + 2] = 1ull << shift;
+            p[i + 3] = 0;
+        }
+    }
+    else
+        clear_page(p);
 
     iommu_sync_cache(p, PAGE_SIZE);
 



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:41:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:41:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312558.529863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuHg-0004Kn-Ig; Mon, 25 Apr 2022 08:41:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312558.529863; Mon, 25 Apr 2022 08:41:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuHg-0004Kc-Fb; Mon, 25 Apr 2022 08:41:28 +0000
Received: by outflank-mailman (input) for mailman id 312558;
 Mon, 25 Apr 2022 08:41:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuHf-0003e7-01
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:41:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7e336170-c473-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:41:26 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-ZktRNjkqPfWbQ1YRYp5RlQ-2; Mon, 25 Apr 2022 10:41:23 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB6891.eurprd04.prod.outlook.com (2603:10a6:10:112::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:41:22 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:41:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e336170-c473-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876085;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=R8DiCPGmZfdIitLCnmZ7S3mCQH5fBWGDgn8DzVJxrZM=;
	b=cG5HNqJ85x5KfaghM7F4h1epa3hfnbhsd4u+khx3ZB5JZ6+D84+6O0jx9bm54GQ/P/qxsf
	xmgl3PpI0YXapJV5ei/DTTg1r4zNWazfHFzbIBCHjMrLX0gUPKSHcFhGjDx445mYMNlA0f
	/UuAgjHrNja+egtScCbMNOHYobjaz7o=
X-MC-Unique: ZktRNjkqPfWbQ1YRYp5RlQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=coDZ6RpsG602xyEM7tLBo7nhvZW3Ko6pEtf1UXXXmMOcujikRDFcu7Aoh0BjUypvHQi/nVS7pLvgb2b1Pm8OtxoEWItdP42EXLRrJIGnos2xgNrZqGLR3GnEtGlOTIwSIqPi3yH7JO6l9DErytmtoOfuzsgFuu+raBzNrawSWOtDrgyDggb1QgMAufpqM6jrWfkR9WbSFZnkpZEZldkwkDzIswXnNTQ212PkNuIdxS3pOTt/P3dSTdXZCxIp+dwwc8leld9s2v2YTIIETVllWga08w398fri79N9RKFLQTsVbIPqc+JkR4n1a8p4ShqJ2SKZp/Dp4IqhYTC3Kc9//w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R8DiCPGmZfdIitLCnmZ7S3mCQH5fBWGDgn8DzVJxrZM=;
 b=M3o93GbzCeH6THWaLvpzP3/l2TovQH+tocAd70n3h5+tkyqjDbH2zQ2VytALlubRohBExvTfP2o0tyIOfFGkzTk5XCWBYOzHs6gspcDoMvgpEKz9qAVvEeoMZYq9eYePDgStbhGeCEB+aSsj7OOWo6r2eI4VwX+nvMg4w5feLEQdM8Y/Yh/nDvmCvBpqPG6/ibaUOlXuPd+yKNCRbIOuaPJIpP+gBhz/RbeMSZx/fS7dbQtqUd2Z7mgG0t8UNJ2nVGLSDY3f1ZwEd4yyddatpMNXbbwdawoU9ngHJWuhwKFeifRKKd7bs2x6xZeS7GilOm0p8TbSPXWZV4tSq2fdlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fedf7224-8023-275a-843c-1a5753c20ded@suse.com>
Date: Mon, 25 Apr 2022 10:41:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 14/21] x86: introduce helper for recording degree of
 contiguity in page tables
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0043.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 16e2feb1-0837-4112-01c3-08da2697606e
X-MS-TrafficTypeDiagnostic: DB8PR04MB6891:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB68919AA9B1B9CDE17DB04C38B3F89@DB8PR04MB6891.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zXiGfoVkqc9pAj1Wobos8VX3wDvPd7bajFrbhXS3nJqZbhuq9LGg0a2vBL7nVq/vbjtA9B8Dl1Sp8tXqNSHNe0gFl7BOt3cbop5pV5b3WbYvg+q//Fb2sabk3ZMLTIMbAOQTuwNqxIjwxHUxuF6uzF/KbOdn9jLj3I2Nwy3xycN9dC3WjQWmI9bJ6S1QgVEXjEEzTqmmbHJzceWMy73CwuoNftvM303NAn1l7dGPaKIeLfXLMiG6qqhVv/4vlq6GhX7l2AHCdQFc9Jlk/MamVjoORqqYPWPFPCSwxX0jfKA74gYbmv0gb5uSldYWL2Tlw1AzZeK1RkqvwW+Fg+tYL+1ONzoHPIjKOd/jYKDLYjxXAmz3gdv0kvzKoJYG+Rl4STnUzrpaWEqHH9+OVz73OU+Za4NjuAyTkQ1R/tkIKF0BBnuCIhM8zkKecc4o6QFO0BL7Pn5FSabySHh+h9+MMaTz9JvAUbvffb+xNDIMtPGCzc/vbJd9N5cNXN+PTkh2gnb14v4FzpkkzYVDHphSMMbdHGETC3OIs/g366s6WZKBjhvKQ5QYsAL6ZxJzLPTkb8xOByeFtNORmF8IYLY2PnxY9qGxF2EJGvo/HQGmfyUZympB1UM4f24EeOS8LcOCnuMnvet88tSs9FP6NbJju4AiMywXJPR75LkHcJmojkdDmtZ0ma3NXBgAwcw86EHt/OsuhltnbDkUHNM1Zkuz6q3aodmk7tJdUMJHqiRNf2A=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(26005)(66946007)(6512007)(38100700002)(508600001)(66476007)(316002)(6506007)(83380400001)(54906003)(6486002)(186003)(6916009)(86362001)(31696002)(2616005)(2906002)(5660300002)(31686004)(8936002)(36756003)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q05JaDJPaHZwazNySlNrS2JreVFrY05iekJYcTVkS241VmJPVlVLYWJFalV6?=
 =?utf-8?B?M0xUdWhzeStCaHJFTklSQmdHcVdGejNrN2YzWlgxV0pkaU1zSUlncFNzZVZX?=
 =?utf-8?B?OUVoU0UrQWJ0NG5CQkw0VW1vUmVLdm5XZkdWdGcrRU1UVzkrYVZsVjVVbGR4?=
 =?utf-8?B?UUVWdXI2MUFwT09Rbm84T2pudU1TT0FZSDMxMEtwUTh1aXNURWxQUkZ1ckdW?=
 =?utf-8?B?RS9zUWpVbFhTOVJoUDJuMVUzb21PR0FhcXVLUUIxNUs4eWUyYm5OeE01VnpZ?=
 =?utf-8?B?Q29hUzJGdW0wZFFtRG53cjFiSUlMb0k3YlJjaDJYOStCbWNCOGNscXAzRGx0?=
 =?utf-8?B?c09hYVU1a1A4RzRUVnZ1TjllMXhvU0RwbEhhOUpsTmo3bG9OSEsrdTNCZjBU?=
 =?utf-8?B?NXN0cmNWblcxRmFyMmtQQ2tMOWJRRmJvMzBibjVvSXVmaFkvQlM1bm83bExC?=
 =?utf-8?B?RTFzM1UwYnZ6Skp0RVAxTFVJRDNBdy8zUWIydHZyY2tDQTNMQkR0Um5JQU94?=
 =?utf-8?B?Ykp6am45QzdWRithNTljNURCUHQ2V0Vua01UQ3Y0eDcxQUZJQnoxU2kvcjlm?=
 =?utf-8?B?czlySkEreFJVNU5PcUNmREVGV0x4ekJidE1yVlNTeTRSeEI0T1Q1Z2FHb0dp?=
 =?utf-8?B?MzFyRUdVTHdDd2JXRmlGZlFmL1JjS1VPZDR0b3c4VHNBRkxNMENQdmxRcHNQ?=
 =?utf-8?B?dmhSdVh3WXVqSnZyNXFacGxvUWI1STRnMWFlYUZ4UWRQNFNENURrT3Jrc2dW?=
 =?utf-8?B?bUZIbm5LMU54WE91TWZXTXo0VWF3Rnc2U3d3Vkc5SjArOVFDK0ZsU3dDU20y?=
 =?utf-8?B?YTZpbEJ6alA4bzlmaTMxSEE5MHo1UGsxL0JTemhaOWtGQzI1ZFdtZkQ3S3Rr?=
 =?utf-8?B?MU1YZTRRMjF1dzZhQ1hWOHk0MjY2NUg1aFRDakJzcDVQOTlDdDRMNlUzNFgx?=
 =?utf-8?B?YXl2dUdmdW01bHNMRU9yOEZLSVBHbXArZHJUaXdZVDFIVm9UTkNNZTZJckph?=
 =?utf-8?B?ZUZYaUovMnEybnJ5b0xRejhNTTJqVjA2ZUdpcGFqdVdGenhpa2Z4dzlIWVlS?=
 =?utf-8?B?eFkvWERESVV0Vk5mY0pyWEV3S0F4YlZ1VW5FNlNVTnBoSUdGd2MvVkVGTk9K?=
 =?utf-8?B?UjNMM1Ayd1FrSmNxaitZaHM2dFZWTFFxbmtEUTNLS1hhUElzWlZERGl0VTVq?=
 =?utf-8?B?dDV2R0huWTAwait5cEp2cUthczlPZEZMb3dibXdRYlB4RVlxMVNYNERsN0J1?=
 =?utf-8?B?WUVQODJqVVZDSUZUemFiOW5MbTMwVDA4OUNLbm0yNHVwM01IQlp5dy90MTBj?=
 =?utf-8?B?V2V3ZEd0SzY2cFdjanlmYTZMTTdQMW1CVFRjYjd5ekI2MVNxRFFoNFQ4Wm44?=
 =?utf-8?B?QXVsbXlhM0lYTVZub1dQM2k5RGxBYzFsK0JvTnhQc0VGd3Q4ZGowTElpa3p4?=
 =?utf-8?B?cEVuSVNCQWxSb3YzWW5idVJHWDhoSzgrYldBVHp1Q3RDZEl5bXUrVlJSTTFk?=
 =?utf-8?B?dG8rd0xWN0NMajA1ZlhoTzJTMDZncGRyL1h1Z3ltMEI3TmxNNDBYSXVPbGVy?=
 =?utf-8?B?MXZyV3F2NjNVL1YxRk8vYVNMcnB0VGRpYSsyVVcxT1F0L2Y4d1l0dlVFY3Zw?=
 =?utf-8?B?RDFldmErN0hrTXFLSWlHR0RBODZEb2RyS3JOb3Y2S1ZpdEJKU216QTZiMzJF?=
 =?utf-8?B?SW56WGhnOFY3ek4ycUNpWURySm1QQ0s2dCt2YXlEanNLWDNxOVBkZXdqY01I?=
 =?utf-8?B?bll3QW5qNXJXOXdmMEZCblRwUDRRNXpvZXdOc25uSmVYOGlHUUF0SnVaZTc2?=
 =?utf-8?B?QVFmRlVWWVRZU2NLeThlK1AvaCtGblVTem14ZWhxTjZmM1BydERvb0pVK09B?=
 =?utf-8?B?SGc2U1ZnSVJUSlBsUUVKbjZTUEpLZFM2YTU3MGNRNmlwUEkyS01pNG5LN3d1?=
 =?utf-8?B?Q1RXaWliVTJNUVpSMFJ5emtGT0tTeVRlQng2dzBabEZpaEx0dWtWeEM5aGMx?=
 =?utf-8?B?ck5tZENYR3dyMVV6VWd6TWZQaGk2VmtabkpYQ25XdGFRR0tFWnpkYlZRNEov?=
 =?utf-8?B?RkdrMGdlUUwzUGFaZjJIcGxGeVFweUR0VmkyR1E4Z04wR214am5PWUpOVitM?=
 =?utf-8?B?UHlDTnhGSGxCb1dYb2FOWFAxREVoWkNXWEFNUG8yaXZ6UGY0S1N2S1gvYWNz?=
 =?utf-8?B?NVFXaFNubG82UENOaDRQNXIxaDJQWkwxWGFqZGxLKy9YQ2p0MS9LdTRoKzFQ?=
 =?utf-8?B?L1p5ZC8zNCtHNjVvZlF5TEUwVkc0aW50VWhkdHA0TUhzSlpCaHlCMGRpU1dz?=
 =?utf-8?B?MDB6V254ZXk3RC9HeW40djdoOUNpS2ViVENrSHdvVDk3aTVpNnU1dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16e2feb1-0837-4112-01c3-08da2697606e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:41:22.7491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e2I5vDMK/fGIZa0bT3yfQpKU/+SM2HnQVxQsKx/3m4fpNuRjVuhNv3vxrem1NWc5BF9rceepUr7X0ihfTYDvpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6891

This is a re-usable helper (kind of a template) which gets introduced
without users so that the individual subsequent patches introducing such
users can get committed independently of one another.

See the comment at the top of the new file. To demonstrate the effect,
if a page table had just 16 entries, this would be the set of markers
for a page table with fully contiguous mappings:

index  0 1 2 3 4 5 6 7 8 9 A B C D E F
marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0

"Contiguous" here means not only present entries with successively
increasing MFNs, each one suitably aligned for its slot, but also a
respective number of all non-present entries.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v3: Rename function and header. Introduce IS_CONTIG().
v2: New.

--- /dev/null
+++ b/xen/arch/x86/include/asm/pt-contig-markers.h
@@ -0,0 +1,105 @@
+#ifndef __ASM_X86_PT_CONTIG_MARKERS_H
+#define __ASM_X86_PT_CONTIG_MARKERS_H
+
+/*
+ * Short of having function templates in C, the function defined below is
+ * intended to be used by multiple parties interested in recording the
+ * degree of contiguity in mappings by a single page table.
+ *
+ * Scheme: Every entry records the order of contiguous successive entries,
+ * up to the maximum order covered by that entry (which is the number of
+ * clear low bits in its index, with entry 0 being the exception using
+ * the base-2 logarithm of the number of entries in a single page table).
+ * While a few entries need touching upon update, knowing whether the
+ * table is fully contiguous (and can hence be replaced by a higher level
+ * leaf entry) is then possible by simply looking at entry 0's marker.
+ *
+ * Prereqs:
+ * - CONTIG_MASK needs to be #define-d, to a value having at least 4
+ *   contiguous bits (ignored by hardware), before including this file,
+ * - page tables to be passed here need to be initialized with correct
+ *   markers.
+ */
+
+#include <xen/bitops.h>
+#include <xen/lib.h>
+#include <xen/page-size.h>
+
+/* This is the same for all anticipated users, so doesn't need passing in. */
+#define CONTIG_LEVEL_SHIFT 9
+#define CONTIG_NR          (1 << CONTIG_LEVEL_SHIFT)
+
+#define GET_MARKER(e) MASK_EXTR(e, CONTIG_MASK)
+#define SET_MARKER(e, m) \
+    ((void)((e) = ((e) & ~CONTIG_MASK) | MASK_INSR(m, CONTIG_MASK)))
+
+#define IS_CONTIG(kind, pt, i, idx, shift, b) \
+    ((kind) == PTE_kind_leaf \
+     ? (((pt)[i] ^ (pt)[idx]) & ~CONTIG_MASK) == (1ULL << ((b) + (shift))) \
+     : !((pt)[i] & ~CONTIG_MASK))
+
+enum PTE_kind {
+    PTE_kind_null,
+    PTE_kind_leaf,
+    PTE_kind_table,
+};
+
+static bool pt_update_contig_markers(uint64_t *pt, unsigned int idx,
+                                     unsigned int level, enum PTE_kind kind)
+{
+    unsigned int b, i = idx;
+    unsigned int shift = (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIFT;
+
+    ASSERT(idx < CONTIG_NR);
+    ASSERT(!(pt[idx] & CONTIG_MASK));
+
+    /* Step 1: Reduce markers in lower numbered entries. */
+    while ( i )
+    {
+        b = find_first_set_bit(i);
+        i &= ~(1U << b);
+        if ( GET_MARKER(pt[i]) > b )
+            SET_MARKER(pt[i], b);
+    }
+
+    /* An intermediate table is never contiguous with anything. */
+    if ( kind == PTE_kind_table )
+        return false;
+
+    /*
+     * Present entries need in-sync index and address to be a candidate
+     * for being contiguous: What we're after is whether ultimately the
+     * intermediate table can be replaced by a superpage.
+     */
+    if ( kind != PTE_kind_null &&
+         idx != ((pt[idx] >> shift) & (CONTIG_NR - 1)) )
+        return false;
+
+    /* Step 2: Check higher numbered entries for contiguity. */
+    for ( b = 0; b < CONTIG_LEVEL_SHIFT && !(idx & (1U << b)); ++b )
+    {
+        i = idx | (1U << b);
+        if ( !IS_CONTIG(kind, pt, i, idx, shift, b) || GET_MARKER(pt[i]) != b )
+            break;
+    }
+
+    /* Step 3: Update markers in this and lower numbered entries. */
+    for ( ; SET_MARKER(pt[idx], b), b < CONTIG_LEVEL_SHIFT; ++b )
+    {
+        i = idx ^ (1U << b);
+        if ( !IS_CONTIG(kind, pt, i, idx, shift, b) || GET_MARKER(pt[i]) != b )
+            break;
+        idx &= ~(1U << b);
+    }
+
+    return b == CONTIG_LEVEL_SHIFT;
+}
+
+#undef IS_CONTIG
+#undef SET_MARKER
+#undef GET_MARKER
+#undef CONTIG_NR
+#undef CONTIG_LEVEL_SHIFT
+#undef CONTIG_MASK
+
+#endif /* __ASM_X86_PT_CONTIG_MARKERS_H */



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:41:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:41:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312562.529874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuI2-0004xn-T1; Mon, 25 Apr 2022 08:41:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312562.529874; Mon, 25 Apr 2022 08:41:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuI2-0004xg-Nz; Mon, 25 Apr 2022 08:41:50 +0000
Received: by outflank-mailman (input) for mailman id 312562;
 Mon, 25 Apr 2022 08:41:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuCB-0005mk-Vq
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:35:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b427c536-c472-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:35:47 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-GyOr7XTDMV6Y45BrJtxeOw-1; Mon, 25 Apr 2022 10:35:45 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB7641.eurprd04.prod.outlook.com (2603:10a6:10:1f7::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:35:44 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:35:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b427c536-c472-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650875746;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xpBRkm9Z5IBvu/NQMA+LCq2v737PicnDjxA+STnwy5s=;
	b=LHQLpS2dJwvVnjaLr852QknCwsaIN6y/ZBujl3QH7KjU6bU0MjKxlQ+rCsYhTWG2XWJr5N
	A/jxvGWDB59unjvm4HY4Ed9lbKih9CLBdjlvhP+bgK+XJNpQpWzxfkPdYrkzneKsmlLD3f
	e4VICLe5JwriFBA7RC6lY1ckdfjtGhU=
X-MC-Unique: GyOr7XTDMV6Y45BrJtxeOw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=clhCJyuyPVJOkk/RFMeOsimStHG7DCGYFXLt4YDz5r7m30pbzjTHaYPtIZ/z/rWV9aQm/a5m6a/TG1Hta8pypf05RuyxseGsaCRM5W1IZppl9ZglDaXJ+Ap6WL73TNDKjLkNENETX0Z3t8zIC3RJu96fW0hTarqpdGzmpCUI6iAIAcJVmtIbM7sq+weppRmThFxXkEh5OM6IlkDNUsLH8fuLcesNpDU61YZbuWXSisj0KowtDM0WlBDwoRmHNnsNNdci4j0UNTdteE3jaFHJtqFFzEdXaBNqf8zXXoxLvctq/qyn6nNxnndmsTp+YmVnkIe/YsQa5rL24OoNxw8NTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xpBRkm9Z5IBvu/NQMA+LCq2v737PicnDjxA+STnwy5s=;
 b=gslz2pLKZdGxIaWIJvr2T70alvPIBleVYreJxfZlcNzdaogpZkPPHKfZw8dApDN1lD7Vphr5IWxHAnsKN5bCGb8XUePSvv7MjB/6zY7cYlc/Q3qAISIhJf4+frVsVP4uxNyFCyjEsVYS+dMPLYVozEKhrVR5Gw+ROmdwpP7rCIguvOX9nmUITUwXEnGhLRV4puml+ENnSRnLAyjmIrwClZ6fTdFYZSIqLr4m8xydtoETXZ/y8tHdjmEtlrtUDQJiXSQzpIUpZ8r5d619u4CyIculyN7jjerDAgBYKaeSHjeClah8bs7dTq3gKHNX3RLoBpcUWJCHmDpcLYznsAi4dA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1389c785-ffe3-5d8c-36f1-a923ce5250cd@suse.com>
Date: Mon, 25 Apr 2022 10:35:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 07/21] IOMMU/x86: support freeing of pagetables
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0194.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::29) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4786ce58-5143-4d8b-b37b-08da269696cc
X-MS-TrafficTypeDiagnostic: DBBPR04MB7641:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB76413E83A5449C54140D84B0B3F89@DBBPR04MB7641.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jqOyCAWCKznMvypUKtfiWpUP2kDn3ZGwvltvR/p04I4Y0KYqdjiwQFNuJ81ToF5ofpWd91XXDnBv0eTz5Mxxx3H8JgQZtMbdntPdPMiwq8jtxrZ96+bDsUHasJXhCXVbYxdWp8YDhm1ITD6h+wEFX7BQkuhFp4wqPqvIlfn2ofCggFiJnO1K2St0+xgPm5BZ2+sCYvT8b3kj8Z3tJ+s0Q40H1mDu4vLHH0OZrd/JB+iy9RhtoAiMx62G8Ha8d97/qtPlY/wXZcXoTfgOXVcHdKEHZxfAfhB5aBkRXU6FTyRWS0gcsV3ev90zCox471CX91nhcV7miSNaqBDY3a9G9QLnjFYQrhy9q8BvTaYb3kfui0/pQfGKL2hPiFN/aiWYNoO8SMBeRveTB93PdJs4eQGIjsyWV5527679joyshpTcIh6okipFU4i5pepm58u1zY939EF+9w7CdHx3fycw608BZREFJg7KTyM3Bpo+iuZCwebCJVfwBL+QHrE2LD74Q6IIlOeQDI+ErLCc86EO/oFFGzXfK7VM0oDen7fsuS91M7zEPdE1OcEvTPMS6KCe2U/42RB/rgGJOA0Ya467H3D++eQpUiszXVk8AwDB5bKhHN6I3N4ZCBqky+Y99p9OUPt9xuo4hXCcJkIjgrCFgWd7BvIIgUmBp59A4/i2lz0atUcgCZVRH83GmN4atsTdkbvW0iqZe4ItBuY4r06TO/hAVXEOqM1StW93MseFNLzZhjm34yV7URDwKophxPQwkMC4JsFsipiX58/NBt00f6JAjArhp4hx056gi2IYikeoLB/fttGn1/LRWV1iZ52I
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(186003)(6916009)(31696002)(86362001)(31686004)(8936002)(4326008)(8676002)(36756003)(2906002)(5660300002)(508600001)(66476007)(38100700002)(316002)(26005)(66556008)(66946007)(6506007)(6512007)(83380400001)(54906003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MENSczdJWDEvL1JlcFpJb1Y5NmF2NXUrSWJUTXM3ZkFBNU1XQ0xuNTFhTjVs?=
 =?utf-8?B?ZVd0dFBHOU54dDAwRjBEYzl4aHJqK1BzazFlb0JnUWd6dzc3djhvQWN0OVo3?=
 =?utf-8?B?NXBYaGhIK05VZmNoUDlVeUczMVVaWFF0VFBONkEzVnhyU2V4SDJpZThHVGpV?=
 =?utf-8?B?c0R5cE8rK0ZtMFVVNDdKMCs3SW0rQXFxU1pvUldZSkxxanUySDQrdWpjUGs5?=
 =?utf-8?B?U3hFd1BNMzFEMlVHbmdCdUlEZmd2OWt4K21pY2JORFFCSHhaLzJNNUlEc054?=
 =?utf-8?B?Wkl6dVM5aFVVMFluWHZZc29BUEhsZkpwcUE1c2FEaHRLOWUvV2JZVlZRMVA4?=
 =?utf-8?B?R2NsaUZuWTN6VEFBRXdMcTlrT2RzbFFVTWV0MnVKSFVDc1ExbjNNNWIvK0lG?=
 =?utf-8?B?Mk5VWVhFaUFzUXdlN2RxOVFUQ0RDRXFCYkI3V09aaE96V1RuMFY4b0l5aGs2?=
 =?utf-8?B?TUVVbHBVa0tmNjY5Z1dwd3ZaR2VvVG1NSW5QTzdJeEJHUmNZNndCMWwvQTBo?=
 =?utf-8?B?T2o2Z2U2eE15QTZYcDA4eFNCcE1tRmdYdzNBSC9SeWhxemNLVG5HeXBTcnpP?=
 =?utf-8?B?dHJ6TjNzRlhsaW1xMUxCQUlFK2FKMUZXbjdsM0czQkRtbkkza2xobFlmd0lQ?=
 =?utf-8?B?Rkk2ZjN6WEM2cDlsS2ZZOVQ3eEoySmQxeG1sTkRKTG5PQ3BZclZtdzhockd0?=
 =?utf-8?B?bWNuMFc3WDUvcXRFeHUzYUw0QWVTQUtOMC9WOTZmeGFIbGRYeFdmcHNxcDJ1?=
 =?utf-8?B?TVpSVzArODBtRWYzeWxpcXZQZi9ILzRvVStSaTFnU1prdG5FajE1SWpZOVlV?=
 =?utf-8?B?SmhsaG5zNk5GUXZsekV6ZXhHTVA5RWRvN2JoeGo0b0hmdGFzaWdyVDEzdFA2?=
 =?utf-8?B?ZUh5OUUycEcwOURlOTNBRWFELzYvZmFWSXhjU3Zoc2w3MGp6QjVpMGw3THZw?=
 =?utf-8?B?OE9hQlZ6MnU1TkhnUDZyNEsyL3ZFVUJEdG94UDg4YkhvRGdBL1gxRzhpUzRx?=
 =?utf-8?B?TXFJbHBJb3pOTHFnejhDTVlnWGtmTWphZzJ5OHV3dWpaNzdRazREckx3cnBP?=
 =?utf-8?B?ZVFVSmtNWUM4M050MFd0Rmg5Rno5LysxZ1Z3OHp4eDZnRnFQMnhWUVRLZWJN?=
 =?utf-8?B?eEhmNFFpR1hROWYwelQ5OWFCQkdLQmVPdWF6N2VKdGh4NjVvcXlyRG5kc0pY?=
 =?utf-8?B?V3c2ZVFDOWQzelo1SXNCN081dDlrZjdLNzlKY2VaaElUTFVsMlVKOHVnejZW?=
 =?utf-8?B?WThwdDlOZFdqWXFhMCtNSkJaT016eUttUVhUalYvcjQrbmFKNmRRS1VxNmlO?=
 =?utf-8?B?Q0tNeTFVaThuU2M3SjhhYXBFRFdqUUlOSTN2UnlrZVI4VnVBSW92dXJZa0s3?=
 =?utf-8?B?WVJoTmJ2WFp1V0JWL0R0aDk1a2hUbkpHYXdmTDJCT2ZPQUhja2dOdDF3VmFY?=
 =?utf-8?B?Q2ttcSsrTW93T0ZzWXdiNmUvMmdxbkluNTFMN3JSd0wxNm1GVEN3bHhsUk90?=
 =?utf-8?B?d2JjQUhyL0xYU3VWQWgzaW5wOVhUOWFxUG1OSkQwYzAvK1h6elBBb2cycTY2?=
 =?utf-8?B?OHJJQWVVOXY5dTRiVXdzenhoSmRXek0xWGMybnkram03R0JLRmwwUWRxNVZV?=
 =?utf-8?B?R1NCSEcwRDZOQjFiYWZmMTh2ak1oWVRaZFdPc3crYWZWQVlaN0lsWjlHMTR4?=
 =?utf-8?B?MGwvSFkxUXAzUUFWUDhpT2FiOEwrbkg4R1JFcStpYm5yb01sZnhRRkJJOTI3?=
 =?utf-8?B?MjBOYldjRFQ1dDB0TC9iOW1pYXpManZEcXZOcDdFYUc1REJYZzg3K2xMWHMr?=
 =?utf-8?B?amIvZlhwLzVPamtnNkZOd3RSUjRmNytuNVhzZVlnWXJIMWo5bUJ0TVp6bEFX?=
 =?utf-8?B?elhSenl6Y1FoOGxyOWxNcGlhRndQeFYwaTNnSWlMUFpVWlpTWklMMlphR0FH?=
 =?utf-8?B?ZExVOVl0SmdZQ1BHWTRnUExQN2dWUmNCZld1U2djZ0FNWU8zQTdUYXVpeDht?=
 =?utf-8?B?alFNUG1oRGpGK1gzSGNRVDNzbHhsL0hvMG1CK2tid3R4K3lXM1I3eDlOd1Qr?=
 =?utf-8?B?T3RSaTZQRXVweDRTZVFpRVA3cU9ibG84MG9pYUcvekhoaHpjYzZxcFZIM1RU?=
 =?utf-8?B?aERXaXN0ZVNOdVBtcXZhcXhyb0RxdmFyNy9qcTBORDRxQmhhbjhVemlram1m?=
 =?utf-8?B?UE5COC90SG9KZTlTb3ZOcmVwLzFaZmJlR0IwM09MeS9sUmJvOFVDczBheEFm?=
 =?utf-8?B?a2NQWVZ4RmlONnl4bGt0aGJNZmRyWHg0TjlnUFNGOVMwZWpaTDVLbllvWTU1?=
 =?utf-8?B?eHlIV3dRYnRlTzZoanYxVzMyYWdYeDMvZE9yT0VmWEFyRGNlMG82dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4786ce58-5143-4d8b-b37b-08da269696cc
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:35:44.4231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6ehietAuHGSpWwSk1Qjh5wrMwLnBLbCvBD9PZjVgRIwxWA6zLSizU2Hkt2RrQIjf5gI11iykMfDt2lyI3sStcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7641

For vendor specific code to support superpages we need to be able to
deal with a superpage mapping replacing an intermediate page table (or
hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is
needed to free individual page tables while a domain is still alive.
Since the freeing needs to be deferred until after a suitable IOTLB
flush was performed, released page tables get queued for processing by a
tasklet.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I was considering whether to use a softirq-tasklet instead. This would
have the benefit of avoiding extra scheduling operations, but come with
the risk of the freeing happening prematurely because of a
process_pending_softirqs() somewhere.
---
v4: Change type of iommu_queue_free_pgtable()'s 1st parameter. Re-base.
v3: Call process_pending_softirqs() from free_queued_pgtables().

--- a/xen/arch/x86/include/asm/iommu.h
+++ b/xen/arch/x86/include/asm/iommu.h
@@ -147,6 +147,7 @@ void iommu_free_domid(domid_t domid, uns
 int __must_check iommu_free_pgtables(struct domain *d);
 struct domain_iommu;
 struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd);
+void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg);
 
 #endif /* !__ARCH_X86_IOMMU_H__ */
 /*
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -12,6 +12,7 @@
  * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <xen/cpu.h>
 #include <xen/sched.h>
 #include <xen/iommu.h>
 #include <xen/paging.h>
@@ -550,6 +551,91 @@ struct page_info *iommu_alloc_pgtable(st
     return pg;
 }
 
+/*
+ * Intermediate page tables which get replaced by large pages may only be
+ * freed after a suitable IOTLB flush. Hence such pages get queued on a
+ * per-CPU list, with a per-CPU tasklet processing the list on the assumption
+ * that the necessary IOTLB flush will have occurred by the time tasklets get
+ * to run. (List and tasklet being per-CPU has the benefit of accesses not
+ * requiring any locking.)
+ */
+static DEFINE_PER_CPU(struct page_list_head, free_pgt_list);
+static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet);
+
+static void free_queued_pgtables(void *arg)
+{
+    struct page_list_head *list = arg;
+    struct page_info *pg;
+    unsigned int done = 0;
+
+    while ( (pg = page_list_remove_head(list)) )
+    {
+        free_domheap_page(pg);
+
+        /* Granularity of checking somewhat arbitrary. */
+        if ( !(++done & 0x1ff) )
+             process_pending_softirqs();
+    }
+}
+
+void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg)
+{
+    unsigned int cpu = smp_processor_id();
+
+    spin_lock(&hd->arch.pgtables.lock);
+    page_list_del(pg, &hd->arch.pgtables.list);
+    spin_unlock(&hd->arch.pgtables.lock);
+
+    page_list_add_tail(pg, &per_cpu(free_pgt_list, cpu));
+
+    tasklet_schedule(&per_cpu(free_pgt_tasklet, cpu));
+}
+
+static int cf_check cpu_callback(
+    struct notifier_block *nfb, unsigned long action, void *hcpu)
+{
+    unsigned int cpu = (unsigned long)hcpu;
+    struct page_list_head *list = &per_cpu(free_pgt_list, cpu);
+    struct tasklet *tasklet = &per_cpu(free_pgt_tasklet, cpu);
+
+    switch ( action )
+    {
+    case CPU_DOWN_PREPARE:
+        tasklet_kill(tasklet);
+        break;
+
+    case CPU_DEAD:
+        page_list_splice(list, &this_cpu(free_pgt_list));
+        INIT_PAGE_LIST_HEAD(list);
+        tasklet_schedule(&this_cpu(free_pgt_tasklet));
+        break;
+
+    case CPU_UP_PREPARE:
+    case CPU_DOWN_FAILED:
+        tasklet_init(tasklet, free_queued_pgtables, list);
+        break;
+    }
+
+    return NOTIFY_DONE;
+}
+
+static struct notifier_block cpu_nfb = {
+    .notifier_call = cpu_callback,
+};
+
+static int __init cf_check bsp_init(void)
+{
+    if ( iommu_enabled )
+    {
+        cpu_callback(&cpu_nfb, CPU_UP_PREPARE,
+                     (void *)(unsigned long)smp_processor_id());
+        register_cpu_notifier(&cpu_nfb);
+    }
+
+    return 0;
+}
+presmp_initcall(bsp_init);
+
 bool arch_iommu_use_permitted(const struct domain *d)
 {
     /*



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:42:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:42:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312577.529885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuJ6-0005m4-76; Mon, 25 Apr 2022 08:42:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312577.529885; Mon, 25 Apr 2022 08:42:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuJ6-0005lx-3j; Mon, 25 Apr 2022 08:42:56 +0000
Received: by outflank-mailman (input) for mailman id 312577;
 Mon, 25 Apr 2022 08:42:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuJ5-0005as-70
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:42:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b29b928a-c473-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:42:54 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-GNVznJqEMCyrHfr4cwFnUw-1; Mon, 25 Apr 2022 10:42:51 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB6647.eurprd04.prod.outlook.com (2603:10a6:20b:f2::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:42:49 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:42:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b29b928a-c473-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876174;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=F76uggdKpcuSYHZPwCK0FV2JMpLEoy075SIPYzCN2oY=;
	b=aHt0+UEKQ5szrRaM/h7CXa47hjLmRn1XOA9ssQzOkcVIYIrXHiEz0uRpdNfjmTdcEXnFIw
	DI1dMvwvY/FkFGZqH6Sb1bv7Z7zW/w6QwDJeKG18o+PXr+wSEml6gyRqZblSHrO3EdDucw
	h2PMLOLjfEU7rNDkQVre18RRe9uavs0=
X-MC-Unique: GNVznJqEMCyrHfr4cwFnUw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IwIt75MDAsiF5vuXMEKM7Qs+6xXxJvstqdESHtOtEwDLFLjwSSEFbGjSRN97SO7fthl7A00hE/kQdhmu4/fnuQ8CULnCFlXWgDkL/odcVYm+sviWr5/OBkc56EvarFy+JyiNXunjq/wK4+0B6MkcQfXNFvaIGkXRj3FUPeEM8d3AaP/k7Ktk5+xfSUSURSnWMAIJLDktKyNb96SgacdOPoJVovH0P6Cau75VKGOAY8cLchySdky7j2AYWFok0aTjLmdeyEFvVEKW3aGiaCOlYSQU7g7QtLhz7NpzDiusy+7bVE6LcEoC1LGVybKdqJIGO6ELqasXif/BYww+Dx/9uQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F76uggdKpcuSYHZPwCK0FV2JMpLEoy075SIPYzCN2oY=;
 b=CMkyhM7LTzpt/ZYD1AKt5b6zsuaGrv43WnK6Zjz7u6vRl9zfWCFmTmkaFMDjIPHHRcM+Ak2136f9pEDzP2r0cehOsB1BH5HCuWCWUIjMSnYKcgb8cwD+K/y/QY8ut2IKHmmRxBjyT5YjjZn2acCnU69Jg+eTVL6mzPRaYgpHzTvRknrQqSYZAvkFpVVRZZiZaq7nvo/ESTe6RIR4m84sEnClCO3F/G98gFoyu5sBSX55UIoMgj2+gO8WFbIGqruxF0PRmsRBlCA6XCMXwTLCfYLlyx8K5JrU6qrdppfRuU+AyvnqfJbRg+TdsOBOcOtUoVinldcYz922sv8xETHUGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b9a2be8d-3bb9-3718-6e3b-f07f6dcdde20@suse.com>
Date: Mon, 25 Apr 2022 10:42:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 16/21] VT-d: free all-empty page tables
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0033.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::8) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1f36f1ab-8f0d-44cf-4b65-08da269793cc
X-MS-TrafficTypeDiagnostic: AM6PR04MB6647:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB66472FA36886A4E5EB0E4277B3F89@AM6PR04MB6647.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+sZCJwKu+kKqohWo2wnpRtkG+226O4gDKlAtsuJIqnk6FjMeovxdmo9YulYupX9OPLn6n5NO0Hut7derq1vXpL6swurkfUaU/VJ3MICXKVkbaXw1gR0hWKgVsfdnzFoynS7dKGn+r5acRHdsoVEauALfhsqfnzK00kOIfk/tM2c6c4bevJ0noXrpJRdXpzUgTdATF30uSaLV6qhH0B74J+ZKs9ueRvFeBZqwKzZdzqC27CK+XPzxBsuYt8EuF6nvIUOLo1hXVHeq+pwZ1GwmkdbvsWzdgjmiWPz/k4dtZ6OhrOZoLDoiKSsY/ZxLcChd4h2MJBy8d/6jZWp1TCnVogvDP0ibWdD26nZmD/r+kZHzAc7V/8t5aTb7rMZz+ST44TAF1VrXT0yFawWMn0VsYcEeUokz5NYe5emXbp6K/jqUPtTmuwJo/l620EsFUw/WMdlhq6Y5WSyIq/uP84T4y+jaqX+yRcTE4pmKjeCO9RLKDUJhq4HWnCma+HasPxv3X/AwCJDcSxhjaffLF2pAO0cPQsgk77pIKXQPDnh158H3gLku2rXUq6pYpR7sHEnEhVpMF0jTIC1RbXRLDkjY43E51cAVdzw/Mr3V8Fdpy7XqbbDymywUB4+amsZLvRAOJ2Pd3xKPuQv2Jps+ZoxTnfMQad7Xo6RFTTQKsuQpgYtC4vhfhP1wwDISLIL7l8EHKWAlQ1WkEL49c5X/JdziyYliCRB+KW1iTPMDn3D4WdQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(66556008)(66476007)(4326008)(2616005)(31696002)(8676002)(38100700002)(86362001)(26005)(6666004)(6506007)(6486002)(2906002)(83380400001)(5660300002)(508600001)(66946007)(36756003)(316002)(8936002)(186003)(31686004)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aC82d1NidEowdi9UUTlmVXAvL0w4S1JmbWN1NVJKY3JPVTlYZ0FVR1g4QnJZ?=
 =?utf-8?B?Z0VVWmN6bUIvZm85UnhlRFlqWG1DN293NjFKWEtVZnNUMjFSQlJsZ08vakVm?=
 =?utf-8?B?a2xycjgvczl1dlE2ZG1ERHZ2bU5INFU2ZG5nTS9uYi9QZHBBWUo5OHJ2U00v?=
 =?utf-8?B?dWE0dk5nQTREVlpBWWRlZWkrRHVON1JIa1BnYUIyenFHUk1rd2VrcVlFWmov?=
 =?utf-8?B?TDA3V2N4aFIzek5GSWwxd1RkZVFzL0prOGFDZUhIUUJSRVNTZGlIN2pic2Vi?=
 =?utf-8?B?bXVzQ3VvTnM3aDRTb1ZVcVZkbTJRZUNBMnEvNCtwZmh1T1VzaWdTVnZHZ24z?=
 =?utf-8?B?VnJ5SXBqRk0xeE94dTRoSDFvaXlHQjVnaWdyLzg1VXk1UHdhRFFwZFFIUzVh?=
 =?utf-8?B?a1pkQmk1eENUMlV0OGNKN1ZMbFhIaXlmUHQ1RjIvT0RMc2t5ZFhXMzFlMHRN?=
 =?utf-8?B?cDVqaFdPN0NoQTlIU2pya2Fvc0VIYVRBZ1JEbDR4ZDk4NEZqOEYyNXpOSFFP?=
 =?utf-8?B?ZFF0MmF5aXJtMkU2VU4xdzltdThkQXU5d3NtOGZ3QXNXd1hBMHg4MktWVTdY?=
 =?utf-8?B?aUZZNTZRMW45a0xHNE52c3BHMGNQVFZHYjBvZXVBcTVIYlUwdDJUQThsc3VU?=
 =?utf-8?B?bzhKQnZtbUUvM3VRRVRKOFUxVGJveHM2a25EWTJheGVxckk4RTlPNk9Ucm5J?=
 =?utf-8?B?Q0VESmJmajVpM29UUXk0N1dyS0lIOWFoQW9kNmdMTjN2aHFQdGRuRXhkQ3U3?=
 =?utf-8?B?SEtIMUZyNU11MnA3eW9nQjZvODNMbnkxckt0MWxYbHdzMmZmVDlOZjJsd2hB?=
 =?utf-8?B?Vm05Z2lOeGVFK2o3eHhEVGRWMmhvV0NCK3piU2ZudkFMbnZreWhzam5xMWl5?=
 =?utf-8?B?SW5tMTZYdXN2WmRheE5qS1NHTU45ZVRZSmIzZmo2cDlKdzRNMDU3cVlsNTJv?=
 =?utf-8?B?OENPL253WlphbjFzdytLTUF6VmhielN2d1JyTWVHT1M4YUViUllNS25BUnpl?=
 =?utf-8?B?ckFyRzBFbnVoNFZkNGVUWnhHc2dEUStFRkxJMmxvcG93MHpuMUt0dVkrRXBx?=
 =?utf-8?B?RDNtUjFHV3hhd0FDWG5kNytRdjY0ZERGbnZ3ZVRGK2VLdVhMTVNmbWR6RVla?=
 =?utf-8?B?MllQY21jOFNySnZhUk9XUnhRZVFtVnpMZ2UzYU5Rd2dta3VleUNvd3BMNW44?=
 =?utf-8?B?NXVnaHNhbEFjUlcwd3dPQVpkY3ZvN0IwZ0VDNGRzd0NoSUozQXdLY3EwME55?=
 =?utf-8?B?VmJKOXpBWlhxMTFLRUFoSEFiclFlYkJEamM4MWhqUnBNNlkrUHU5aHNMMXlB?=
 =?utf-8?B?ZytET09YdHZJc0poazJBcHprNTFKNjNMcEUvdEpFT2pzaURFUUh5amZmYmJZ?=
 =?utf-8?B?eWdJaW53UXkvN3ZYNlQ1bFVndHdEL3cya3lWdjAySHVoMC9pNCt6c1dTVU1u?=
 =?utf-8?B?VElvTUhrWEdVdlRpNzNvV3kvUzBjUGxGRXl6UTRvSzQ4M21Da3ZiTlh3cUZu?=
 =?utf-8?B?Z3E2blFvWUZsOVhoQmZuZG9STkZ2UW5PTmRaUTQxb2ZaV0tFeSswVHZRR3Vt?=
 =?utf-8?B?MytXN1psQnlFYlE5cnllUU92Wk5hRVBVWjExOGVpU1lwcFZ4cGwrK21aWXdG?=
 =?utf-8?B?Q3hoUlhobDY0aGo0c3I1dWpPbnhRUHRsVkRGdis0cFBnRXFKell0ZWYwQndu?=
 =?utf-8?B?RlFVWkJPRWgyUnZUUzlWR3V3L1JvZmJDOXZaeVo4TS9QekJkdmt2M0xpWDBS?=
 =?utf-8?B?bXJjaTFEMWhqVDZVT2R1anpkZzBBdE51emJWQUIwYy9rcCszbnp1dGxuSXFY?=
 =?utf-8?B?T3hTLy9adFZScHZOSGE3eExKdWZBMUVPaFZJRDMvbVFvZFdVQkhxbkJaTXpL?=
 =?utf-8?B?SEMyaDhVakp1ckY2WnArdmZQVVYzNzR0MHJ2YklEMU43eXh2TEtoOGdoNVJ0?=
 =?utf-8?B?T25rOVF6YkFVd2kzNnA2cm5XelJUZUFhcFRUd0hmM2krc21TdEx2cWs2Umc2?=
 =?utf-8?B?eXhZTDRRVFlKbXV0Qm5DaWlTVmZ6aU9ET2NESUs1Q0hxOURmaEJCUjR5Y1hC?=
 =?utf-8?B?aURWeXFQQjZtUk9aSFhIRTAvdGphSWl5QVI1MGM5MGtudXZPY1h5d1dJMTVu?=
 =?utf-8?B?M0lSMGhTSjF4MWtCQkxZZ2swRmZoSnNXQmpFY0cxOEFGY003QUF0T2l0Zjhm?=
 =?utf-8?B?bktGaFV3Q3JTRFpkQWN5TndBUUx0WTRlSmxiWkRnZk1aQWs5T2hIODBmRkdp?=
 =?utf-8?B?VFNIQnpEaGpGTnpZRldhaTVtNjBPajVRQ29TSlR3RkpjRENOZ0dsUjZ3dWFU?=
 =?utf-8?B?VlhRUlg1b0ozYUZOMU1ldWk2ODFrQ2xDa2tTT2R3N3EwZnB1RjJIdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f36f1ab-8f0d-44cf-4b65-08da269793cc
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:42:48.9933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jsmPMr0Ur35rlFPrzoOZ5DbnsRGaLvtm54hMftZ30/8sLRqFmrAOKhr7z/nR7CubGlwix4WOz85X9hPsdgTFgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6647

When a page table ends up with no present entries left, it can be
replaced by a non-present entry at the next higher level. The page table
itself can then be scheduled for freeing.

Note that while its output isn't used there yet,
pt_update_contig_markers() right away needs to be called in all places
where entries get updated, not just the one where entries get cleared.

Note further that while pt_update_contig_markers() updates perhaps
several PTEs within the table, since these are changes to "avail" bits
only I do not think that cache flushing would be needed afterwards. Such
cache flushing (of entire pages, unless adding yet more logic to me more
selective) would be quite noticable performance-wise (very prominent
during Dom0 boot).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v4: Re-base over changes earlier in the series.
v3: Properly bound loop. Re-base over changes earlier in the series.
v2: New.
---
The hang during boot on my Latitude E6410 (see the respective code
comment) was pretty close after iommu_enable_translation(). No errors,
no watchdog would kick in, just sometimes the first few pixel lines of
the next log message's (XEN) prefix would have made it out to the screen
(and there's no serial there). It's been a lot of experimenting until I
figured the workaround (which I consider ugly, but halfway acceptable).
I've been trying hard to make sure the workaround wouldn't be masking a
real issue, yet I'm still wary of it possibly doing so ... My best guess
at this point is that on these old IOMMUs the ignored bits 52...61
aren't really ignored for present entries, but also aren't "reserved"
enough to trigger faults. This guess is from having tried to set other
bits in this range (unconditionally, and with the workaround here in
place), which yielded the same behavior.

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -43,6 +43,9 @@
 #include "vtd.h"
 #include "../ats.h"
 
+#define CONTIG_MASK DMA_PTE_CONTIG_MASK
+#include <asm/pt-contig-markers.h>
+
 /* dom_io is used as a sentinel for quarantined devices */
 #define QUARANTINE_SKIP(d, pgd_maddr) ((d) == dom_io && !(pgd_maddr))
 #define DEVICE_DOMID(d, pdev) ((d) != dom_io ? (d)->domain_id \
@@ -405,6 +408,9 @@ static uint64_t addr_to_dma_page_maddr(s
 
             write_atomic(&pte->val, new_pte.val);
             iommu_sync_cache(pte, sizeof(struct dma_pte));
+            pt_update_contig_markers(&parent->val,
+                                     address_level_offset(addr, level),
+                                     level, PTE_kind_table);
         }
 
         if ( --level == target )
@@ -837,9 +843,31 @@ static int dma_pte_clear_one(struct doma
 
     old = *pte;
     dma_clear_pte(*pte);
+    iommu_sync_cache(pte, sizeof(*pte));
+
+    while ( pt_update_contig_markers(&page->val,
+                                     address_level_offset(addr, level),
+                                     level, PTE_kind_null) &&
+            ++level < min_pt_levels )
+    {
+        struct page_info *pg = maddr_to_page(pg_maddr);
+
+        unmap_vtd_domain_page(page);
+
+        pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags,
+                                          false);
+        BUG_ON(pg_maddr < PAGE_SIZE);
+
+        page = map_vtd_domain_page(pg_maddr);
+        pte = &page[address_level_offset(addr, level)];
+        dma_clear_pte(*pte);
+        iommu_sync_cache(pte, sizeof(*pte));
+
+        *flush_flags |= IOMMU_FLUSHF_all;
+        iommu_queue_free_pgtable(hd, pg);
+    }
 
     spin_unlock(&hd->arch.mapping_lock);
-    iommu_sync_cache(pte, sizeof(struct dma_pte));
 
     unmap_vtd_domain_page(page);
 
@@ -2182,8 +2210,21 @@ static int __must_check cf_check intel_i
     }
 
     *pte = new;
-
     iommu_sync_cache(pte, sizeof(struct dma_pte));
+
+    /*
+     * While the (ab)use of PTE_kind_table here allows to save some work in
+     * the function, the main motivation for it is that it avoids a so far
+     * unexplained hang during boot (while preparing Dom0) on a Westmere
+     * based laptop.
+     */
+    pt_update_contig_markers(&page->val,
+                             address_level_offset(dfn_to_daddr(dfn), level),
+                             level,
+                             (hd->platform_ops->page_sizes &
+                              (1UL << level_to_offset_bits(level + 1))
+                              ? PTE_kind_leaf : PTE_kind_table));
+
     spin_unlock(&hd->arch.mapping_lock);
     unmap_vtd_domain_page(page);
 



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:43:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:43:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312583.529896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuJV-0006Kr-K0; Mon, 25 Apr 2022 08:43:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312583.529896; Mon, 25 Apr 2022 08:43:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuJV-0006Kk-Gt; Mon, 25 Apr 2022 08:43:21 +0000
Received: by outflank-mailman (input) for mailman id 312583;
 Mon, 25 Apr 2022 08:43:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuJU-0005as-5B
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:43:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c179822f-c473-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:43:19 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-b_RJjmPEOLKgT5WnXpataQ-1; Mon, 25 Apr 2022 10:43:18 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB6098.eurprd04.prod.outlook.com (2603:10a6:208:141::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:43:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:43:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c179822f-c473-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876199;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=o5dMhpfznMlqVzr+kJ/53g9HZAHAFuJCF88KGG0p/Pw=;
	b=gskIEYe9IOm7q3QfsHWYC2um8rRth94hdRAjXOeqLzzgOlwkvnjnTtnJ3qyM3ZYwNpcL7i
	XXfZ0yFtaVjMo+1Cw6RWnPhv0CqOBmpH9/wALLZ1Pj+sqc844dOQAtCp799P6Pj9JlMs6b
	dNoRD+ioyrDskObMH6tsdZfh7vw++zc=
X-MC-Unique: b_RJjmPEOLKgT5WnXpataQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZftQTbEYgdFI+6kFvVAR1LxW+gdwYPevxgRcxbAjkJH2xeMrt1lhDdShjj4WxGNyXpSN8/wAYkXtG3mNdNvLiSiLehSEP1GOWXE7OjIFRwb8kL+waytULHoEbRruTU5us+n3Zp5XGJfkLAhGj3Mkf/aD/7K+HGjvICVAmXDXazDxdLVvnBxFr0HBJW5gQ5IiX54qaWTzMNagqB0pNz/bSqyOmiLXIFmBMvSajgYZSa9Ofn/DrLFImniq8DO46z2FsH5wV9XUAHA+tlVcNDWtNkdTFBzvF7veo47iWWYTsqrh3htOuju3MwoMm682VsCRL/yLNM+0ZiAie4PQIaPDXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o5dMhpfznMlqVzr+kJ/53g9HZAHAFuJCF88KGG0p/Pw=;
 b=hPrybism78QkDSlKfu4XCcxGX0U2vKBDRgDyZNGShWVF9DJlzW21kuN/2eom/yaoHbd6QkU2k1e/B+s+yoPc0B2lk5x9RgUItu2UTUcGjf8JsgYoO70kT/W8Yz5j8sB1TuWApNa/GJDFERrf07Eje1SkYjYHr/OHIqIayTomzPrI4sRTSnPw5GF6JhmHb1pu56K5gVcNFEpWvc8VwvaeDgwMs1I03wx3UrFjHo4tqOSYppSSkezTBcUZWagYru0351ZSQ7+YUn5o0HiXmu4d1r/5j5MjR4BvBfA/EdJ/scN3tm0BXRvLb7TKkkgoOdIoc/hdmC1nHPxbUl4rtm3Yyg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e0e2d865-5ac9-d7ac-c763-f4b99b699224@suse.com>
Date: Mon, 25 Apr 2022 10:43:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 17/21] AMD/IOMMU: replace all-contiguous page tables by
 superpage mappings
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0100.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::41) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0f182e83-4d2b-4a78-34b6-08da2697a387
X-MS-TrafficTypeDiagnostic: AM0PR04MB6098:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6098D2B8DD4C9692A9D8800DB3F89@AM0PR04MB6098.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ytsBkCaiyoBdFjY91ut+WHsBc5lfa6NiEnTAJYQGLPRDVwVIshYUIGksbHMJmMwvoBhJKIDKjXXXXtW06f6og/+du/wk0zu2/8OqHw4opGJMo8fqCpit2HjL6DrzVkr5XO909B2v/jl+yb29yqWC/kE+2amqVj5BpRKJoc533Mt/MZyvDNP8AZAxYRNmaWNu2+jIi7g+AVw1mIoy5qqKmCmkCcrrp1ppHuV65kPVtarNyBpAuChiI0YkbK/BkzeaXM4rWkRhh1wWil/KBhe8BJsYlcFcR1bwfb8KQRtp34aEfKtZOShA9pAAdJi228p80QvWqochXLt/2tbvZtsaE5N9W84360ojKDwSl/z7ISzBoaRNO2arq47qReNO0FoLbk66JHVYiQzRX1XDs0FbyFPu95Z0fz9mNYA2RhKl9i6HyAwDhZ0rhqWbJ2oT/FtT4EIwQwO3bMdoyDvUCSKZXXlv0QsH5WAR1p+GDeQ0ljJqN4zunCwgGLjbDGDQioa5IQixe/vbZc6heBBl70NgBZVhVjFn/82Y1XdVeEyyDgrxjKCun+E4PI0CEg6ZgA7UJNAY+pnsSnW1Y2wF3Dvl8ivLJddl+xVMLnNUxCXGTVf+FWYT6HuCEBLC9hB20gPSWpiVIPVIHrnSmfNVSJFlntt4znH8KIzFGGvClAfOBZ2kqO7xf4M9cNl8voKRQ6JIkFifhMDqBT/Kqum6SaiX3hbT8nwu5qvgEeyas9rDFcE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(2616005)(508600001)(8936002)(86362001)(6506007)(6512007)(2906002)(26005)(31696002)(38100700002)(6486002)(186003)(83380400001)(66476007)(8676002)(66556008)(66946007)(54906003)(316002)(31686004)(36756003)(6916009)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZlFYZzNjek5Nb2VjR2ZpcDh1NG9uNWRzQjFDdmhoRDZ6ZkhhM1BPUmErbmhN?=
 =?utf-8?B?WGpuaTEyaU9iMGhpZXdTc1c0cjNhM2NwZGdLUDNoRmVPeFFWTXhVc0xuaXU0?=
 =?utf-8?B?UFFoTHQ2YldRcFBLeGV0RDdiRnZ6UWRJK2lHSVF1UVkwenlXSUFuSUs3L1Nj?=
 =?utf-8?B?SFhOMXRZNlU1UE9MTzRwdXQ5OTZ1cjZDZGkvWTgrVk1FQVVhQmtCY0tPOTdk?=
 =?utf-8?B?Sm1WNGE0cHFGZWJXRFIzY0cvLzhlSlpKeFhPQVRNWVJaaFVXNlE5RFd3bk0z?=
 =?utf-8?B?YjhNMGxLU1R5N05tQU5QeEVUU3NtN05ManZ4eldhdnd3ajFlOVVSV2NIUWJh?=
 =?utf-8?B?UEk3ZWZZNkJGV0VtVWUwd0xaaXNEYktEcUk3c3JPSkRPWDJuQWxFNk5BM0pp?=
 =?utf-8?B?YStDN2hXR0hQeVQzU0p5eWpXUm5PSVJHbDlJNUt0cFplVm11SnA4d3lEeEEx?=
 =?utf-8?B?U0JVdjZZdVkwVm1NeHgvd1cyUVhOZEk0RzdYQjhBRGZrS2pCNUxsNHcwTVZ0?=
 =?utf-8?B?N0c5bE0zdnJ4YXpiNHpWM2RRMUNSb2QzU0wycU9sWVdFMEV6NFR1WE5GZ1NG?=
 =?utf-8?B?NldNNGVNT2lwQllDdTkrZEhkaGh1bnlYaG55NVJCVnc5THpicExRNlNIK2VC?=
 =?utf-8?B?SnRSUGx0SEVFbmJZenR2RWJTL0w4V0xONG5pTjg0SEhVRFRCcDVUbUhMRXdQ?=
 =?utf-8?B?T0dudThiMk52RkdJc0pTNGdKVGRkZ2J0TW9yMExDMmdxZWx4NXduMTlTUGxQ?=
 =?utf-8?B?UGJxdXQyOWlOeGdScGtVaEFseEhzNVVlL3I1Zjl5YUt5Z0ZaT3o2MTBGbjZP?=
 =?utf-8?B?SURTUXgzUFZpOVB0ODVxOVYxTEVEbWg0UVhzb0tDdTdJVnZLV0plWFJoZExq?=
 =?utf-8?B?Zy9RRlVOL2xkd0x0czVqRmhpR2YwQzhUdzR2SHAydENuWVMyVUpSRENKZ20r?=
 =?utf-8?B?VE9qeU9WZk1PSzJFUnpQV3hTZ0JOTTNnZGVoQWVoY1FNUDAzb0RuZkh1cjBD?=
 =?utf-8?B?YmxBUEdvS3VNSmQyU0ZXdncySW94Tmd6bUh1OE5zUU9scG5wL2dYL2kxVk91?=
 =?utf-8?B?Z0ZFRVRkNjFqdXIyVG5rbS9MUXBFUG0xdUhHbHBCdWtEN3k0UDNLbHpvL005?=
 =?utf-8?B?MDNLOGtpb000YnRwUkczWWFJVjdQTzhpRVdTUHc1MnQ0SzR1aWp0NWdEZDM3?=
 =?utf-8?B?WUFUUng2WGd0Q0dBZjUwMDFCZmJhRis3QUxxcVlodDJCcUd2M0dFUDM2MUFh?=
 =?utf-8?B?T1hydjFLaUN6WWdhZGMxcmZ5NTByTjBTdC90d3dwdnRCRUdNVGhmei9kQzlY?=
 =?utf-8?B?bmsyWEJrL1B5d3FyWmxML2Z6VFBjNE5FdmE2dkJsVG9DZjRpRGJjdFpYZVA4?=
 =?utf-8?B?dHNLTTVFMExsSWxtVTlDMDVuaEw3RGtNSE1PakZJWGRBN0xxQ3hHOGE1Ni8z?=
 =?utf-8?B?V0tkSHFNSkx5dUJwWXZUeDdOS0p0bWFiUkJQdXNjWHdXNjU0SkNObG9VelAz?=
 =?utf-8?B?Ukk0SDhaK2czZWtaNVkxVlVhMzJPVjBJbUszelZnWU9RSFprZ3N4QzYxc3pH?=
 =?utf-8?B?QkFRZGFYRGVQUDlMSkFzUWdITVd6dW9tcThEM3VQcHZVeC9JMjVValRFY2xr?=
 =?utf-8?B?QVNWOTNub09wQmxmZ0N2TVo5ZytPaXh1WHFmbkVzdTNXdzVOZCsyK2thM2JF?=
 =?utf-8?B?U1BPSzRtbmdvdGhiQzJLa0xnaVF1aFNEaWNmMHZSd3VxTmFvUTc3ZXNhNTJ2?=
 =?utf-8?B?UnVsM1J3SUp4MWlxenlVeVNmUHptK1l0eGJPcUNEb2RmenIrVStBcmt5RUtS?=
 =?utf-8?B?cUMwTEJMWHo1SWJXV3FldmVsUTB5NlpMMnZwRFV4YnlvMjJQc2VIVUgzZXhD?=
 =?utf-8?B?OEZmV2hnUHdFZWI1cXNoWnN1dVQxM0tBRXJWbkpZRHpMblRvTnpDRmpnTHVB?=
 =?utf-8?B?VDFuTlBna0ppMjR3ak5TL1cxSnhIem5YMzYvSWtyK2pPUHFFWndYWHRrSG1B?=
 =?utf-8?B?UnFBUmxWZ24vODArdWxzU1dQbG5jMXlmRTBNNGxaRk1GRTJ5KzdkUnl1eERP?=
 =?utf-8?B?RUJvVS9CVWkxUjcxWDRDYWdCY3A1YmhhMU1QWjRaWTlVWG9zdmc4dk9UQzcv?=
 =?utf-8?B?aDJrc1JWdStTdHd5cjczTUFJbFcyaDdtSnZKZzl5dWNBN2gvSzFLODdUS0lO?=
 =?utf-8?B?THdoNENxU3ZGSjRyN09iTEdmMk96bGxVMFd5dXcxallvMFJQem1CWW1jRFJq?=
 =?utf-8?B?QWwyV3Q4NzRCckdGTE0vdTJxVkFCT3ZmNEd1L2RPb3kra2ZGQXhRK3h1Rk50?=
 =?utf-8?B?dDR0K1ZQajZvS3dkbGNkRkE0M3dMTWZ3WHo2RDlmaElSZTNnVmtaZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f182e83-4d2b-4a78-34b6-08da2697a387
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:43:15.2748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: agMlyq3K+fhi5YuXGvetiyiMKMi6oafnFHppyh2d4gNy0WJhVsZb9SsFfVrYfUX3Q7gO7gM4O8p66QuC5Jrj2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6098

When a page table ends up with all contiguous entries (including all
identical attributes), it can be replaced by a superpage entry at the
next higher level. The page table itself can then be scheduled for
freeing.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Unlike the freeing of all-empty page tables, this causes quite a bit of
back and forth for PV domains, due to their mapping/unmapping of pages
when they get converted to/from being page tables. It may therefore be
worth considering to delay re-coalescing a little, to avoid doing so
when the superpage would otherwise get split again pretty soon. But I
think this would better be the subject of a separate change anyway.

Of course this could also be helped by more "aware" kernel side
behavior: They could avoid immediately mapping freed page tables
writable again, in anticipation of re-using that same page for another
page table elsewhere.
---
v4: Re-base over changes earlier in the series.
v3: New.

--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -81,7 +81,8 @@ static union amd_iommu_pte set_iommu_pte
                                                  unsigned long dfn,
                                                  unsigned long next_mfn,
                                                  unsigned int level,
-                                                 bool iw, bool ir)
+                                                 bool iw, bool ir,
+                                                 bool *contig)
 {
     union amd_iommu_pte *table, *pde, old;
 
@@ -94,11 +95,15 @@ static union amd_iommu_pte set_iommu_pte
          old.iw != iw || old.ir != ir )
     {
         set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
-        pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level),
-                                 level, PTE_kind_leaf);
+        *contig = pt_update_contig_markers(&table->raw,
+                                           pfn_to_pde_idx(dfn, level),
+                                           level, PTE_kind_leaf);
     }
     else
+    {
         old.pr = false; /* signal "no change" to the caller */
+        *contig = false;
+    }
 
     unmap_domain_page(table);
 
@@ -407,6 +412,7 @@ int cf_check amd_iommu_map_page(
 {
     struct domain_iommu *hd = dom_iommu(d);
     unsigned int level = (IOMMUF_order(flags) / PTE_PER_TABLE_SHIFT) + 1;
+    bool contig;
     int rc;
     unsigned long pt_mfn = 0;
     union amd_iommu_pte old;
@@ -447,8 +453,26 @@ int cf_check amd_iommu_map_page(
 
     /* Install mapping */
     old = set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), level,
-                                (flags & IOMMUF_writable),
-                                (flags & IOMMUF_readable));
+                                flags & IOMMUF_writable,
+                                flags & IOMMUF_readable, &contig);
+
+    while ( unlikely(contig) && ++level < hd->arch.amd.paging_mode )
+    {
+        struct page_info *pg = mfn_to_page(_mfn(pt_mfn));
+        unsigned long next_mfn;
+
+        if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags,
+                                false) )
+            BUG();
+        BUG_ON(!pt_mfn);
+
+        next_mfn = mfn_x(mfn) & (~0UL << (PTE_PER_TABLE_SHIFT * (level - 1)));
+        set_iommu_pte_present(pt_mfn, dfn_x(dfn), next_mfn, level,
+                              flags & IOMMUF_writable,
+                              flags & IOMMUF_readable, &contig);
+        *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all;
+        iommu_queue_free_pgtable(hd, pg);
+    }
 
     spin_unlock(&hd->arch.mapping_lock);
 



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:44:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:44:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312588.529907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuK0-0006wu-U9; Mon, 25 Apr 2022 08:43:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312588.529907; Mon, 25 Apr 2022 08:43:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuK0-0006wn-Po; Mon, 25 Apr 2022 08:43:52 +0000
Received: by outflank-mailman (input) for mailman id 312588;
 Mon, 25 Apr 2022 08:43:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuJy-0005as-Th
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:43:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d3cfee6a-c473-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:43:49 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-KWNPR1rNMOqmff3-3asZWQ-1; Mon, 25 Apr 2022 10:43:46 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM5PR04MB2977.eurprd04.prod.outlook.com (2603:10a6:206:a::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:43:44 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:43:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3cfee6a-c473-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876229;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2Ab4csObLsDUSWIHGU1Rqn2fo95dC4MwB105VQU6jBM=;
	b=kn/O4h13ccJFKgaYAjqdu5fZJ84HjjJ6DUjM69fBlyBzHxPTfaVvqNRSHylPD2P0b5nyjk
	snmaxc895CHDlCHzMIW7m+E9chm+9/oqQ1VuLcWVzUA31JaWipQJU62Uo5FJKHCCLVhGVs
	nB7yKUpDzmY+ObDwAN9JnpHfGpOHRz4=
X-MC-Unique: KWNPR1rNMOqmff3-3asZWQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c3sSYpQUGEe8oMQuLwpvxYE7IALALsYNSrxzciq44FAKisvIRZ21WAj4BL4oTKi8QCpEWU0nnfwqf2ofQVeAE2LWvgTcKUNpoII0ZDez+rWwtJz9dsY1WlciEu+eB1oSXMlwnQUQFX3g3bE7qqtWz9MQM6aVJ5+bfv2Z8gvFEmcq8RPw11SsYprDCRHsQrERLK8IHEO3SIsxvg/lbca+BxO4AcwSBSnqbIy76ZvoBFh65yKuEwwYPVYJVa5hhSfNO9q+rXZGAB6/Y7P+NHdWP6n9O3suJZWmRWm9CTfZOVpvqIHpsTrUSTeZxz+Rr8bBNU0BU67xRIctdAP4V1+ivw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2Ab4csObLsDUSWIHGU1Rqn2fo95dC4MwB105VQU6jBM=;
 b=jtjTfb2Xv1Lwdusn/BqZi1ZpIp9lm18sqYVKaQv1dFoH9nReYaLSGs6LLAVl09Ywaz+i+PaPCtDXT4oIVCaTdgbvfkoj09R1xV3tNDujoh74pI8lfwszPjf4uSbo5+dwl6ycQrzh0lL2w50jbEp3JzXksnhBenr3bsHUFaThNk+IhD/vES4jpSXNdLEEx5eSgjUwigMS+yBeMX4QWMH36BOIvIKfGdCEgMc5TOxoGgZJYQbQlMku6KYnONiZAz0ABzv1YbDB8MklTazAukg5pELcBGh7bCH3f4vMmMZLvbfd0ajb8C0kDb6Xq3N2hXApCEEYkhiFTht+DCP1HVNdKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <98553b89-6296-9e4c-4677-9201cd7cdeef@suse.com>
Date: Mon, 25 Apr 2022 10:43:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 18/21] VT-d: replace all-contiguous page tables by
 superpage mappings
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0025.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::35) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 31b50537-6199-46fd-b8f1-08da2697b4e7
X-MS-TrafficTypeDiagnostic: AM5PR04MB2977:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB29774C5948BBD5F51854C31EB3F89@AM5PR04MB2977.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nzZBCILlrNZDOJWCc8bd7Frfg87ffeUqCgCeHxSU/SOuETRVFnnxO26+GxIkSky9IMiWMcK+y7GaRJ7ULk+3kuZSoacbqSbNGrH9MhbvNnuBGm8tf/0DTPoQDd0Z+lWEZ+dnDOd7OmPL0mxBW5eQNWu269Ls0lQv6Tob7hx5iyBN5sbCdUjrzD+n61lMJiJndDYvitL1MkyKTn0K4gEqQrprtsD80KyzRSJxmrQQYDNSWQ/u59BJi8pRQsplCgE9ADDnNoT1S98r+zjmSPEb1+DIh/ypwcTLSBngctxh3vvCRqKHG/hefKf+VM0vIhtFDmoBcLsG4mP3AAaC9dneR7VxN4O6pKLk5AVyIJzAfeK/pwNdjXq+pa8mF3wEur6MRXOELIYiKhVAdZdopgtizEXeFTZMErC4itRFj0DsHBSloL/Yb3cJ/CxyxhdR/a/m6jEo+ZZayo1AlG1Wo8LPEDX4afM/L3z3zs0vM4/Wqgl4WIp3J+cNk3Nmf8UswRdY3XLfwmyX5091J18OoB3h15dSgTJPhYW6+ZUcjvdIyVZK7oB/zGp5Fft1xDIwVgSzCePAZ2WbaCEcjpki4OGfN/ZLwxhVEmN+CziKKWjw0/opH2mbM8fAmSFocUANfoDHCaJ3hyYKULCo6Ma08ETTiDZ9TdDf52jMArHSo64hxkeOH0sikZV76kVDocybJW9RkX4XZ427fHe4itvTvXhZHnZoX1Syb/1Laj3FcX4vBuc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(6916009)(508600001)(38100700002)(26005)(6512007)(6486002)(31696002)(5660300002)(83380400001)(36756003)(86362001)(8936002)(31686004)(2616005)(2906002)(66476007)(66556008)(54906003)(8676002)(4326008)(6506007)(186003)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b0VBYjRkK1ZoVXJzZ3ZxdXp2NVo2dnJXU2NZb0ZsS1g3WmVOUDdPQkxNektG?=
 =?utf-8?B?cmh2UHJoN1dPUGNOMndHd290OXZFVlpiSnJWQXFKd1JCVU5aZFBUQzlBamNz?=
 =?utf-8?B?cDk1WW9NZnNXc3I1VUYxelAzeVlUUzhQQ1VFcE1TME1YMisxNVA4Qm5id2Jo?=
 =?utf-8?B?UGhERkZjck9qLzFjd2xQa21uNm9nQ0t4aGJhSDIvTVVQZWtFTWF0cTVPZFZa?=
 =?utf-8?B?QTZqUUwzbTdpQ2l0VVJjME9vLzBDSWw1VnRWUHcwRzJVODBZdm42QnRuU2hs?=
 =?utf-8?B?YS9sdDJlY3BONDNEV2ZkWGYzU0diL1JLUTBlUCtwTTlpZlJ0elAyTXlRWllq?=
 =?utf-8?B?eU5GRjBaSGl2d0c1OUprRHNmTmZJWXpzMjRjUGlsRDVPUnpCV0lJNWRyUkV5?=
 =?utf-8?B?TWJnTnE4ZG9PYWxLcFVWQ01rM3FTQnBDNHZGZXZvZGNkYnVVc2JvNzF0amg1?=
 =?utf-8?B?bkNCVGhhUnNISGpyV0o2Sy8zZW12N2RqOThjZjFwc094aklndXpvbnVvVlFC?=
 =?utf-8?B?blhEVzFyWnlIYmVYTnp6SktjK1QwaWNBdXRZSG54ZWg2dmUzZE9lY2VZVzNL?=
 =?utf-8?B?TC9QSUJmS09qQk54dEtpN2hpN2JUc0tJVys2V1R3enZWTEFyVVpNVkxEcmht?=
 =?utf-8?B?aHBMY3Y3SmpDOEVPdHo0bjlsOC80LzhNa2d5cVVQRCs4dGNCUi96dGRYK0Ur?=
 =?utf-8?B?eVB5bHpxR3hPVnNPajJtMEw3aDIvL04rdXFlaVdDbm5ZZGZUSlRBdURacWdl?=
 =?utf-8?B?c2VyZjJYNlMrT1NIUHlzZlAvNlN3eGgzQ0lHRXhIV3RUZUpTenRnODZ2YWpZ?=
 =?utf-8?B?dUhYMDB4a3o5dGtkL0hCbjArRTh1eU8wZWkwQWFJbFNGOHYwcytEbEF0N3B2?=
 =?utf-8?B?eWk1TERPUjNNcXF0VEhPK1FZYlhPN0J5V3Z0QnNsNmxLSHNsZUMvcmd4Snhk?=
 =?utf-8?B?UEFLUlMyMk1Dd3poY2NxOVUwbzIvMWcrenhnWG9DTW05Z2U2WTBMbEpNRGRx?=
 =?utf-8?B?RG1YQytkY2dwTDZndExERnUrZGNWNnl0aklxelFUT3F1T21aQm5JQy84SVVW?=
 =?utf-8?B?QTRoWkVtLy9SNUVQaW0xaGFKN0pVSnVBZHlXNlJwcUtaOWxOQVd5YUFYWWRQ?=
 =?utf-8?B?MWJhWHI0RDZCUHRTbGk2M0ZvNTBtc3IyRER6Y1MwMTN6OUhVSHNIeXVnUDZK?=
 =?utf-8?B?eENoQkhaVzlNVkFuSG54cmR2QmNDNjJUSGhYTjkxNm1kWU5YbEVkNmJzK2s4?=
 =?utf-8?B?dFRxWmJTVkRZSGJJQ1Z5Y3V0K2Z3SzloT21IVG9ieUxva0pNU3ZWTkFkRGpR?=
 =?utf-8?B?VEFCaVBlZnJOV09yR3EyWUtjVEhkc2RGdWZnMnBVd21Ec2hlL2JKc3RoaS9T?=
 =?utf-8?B?WVFqbXJsV1A5N1lvTy9QVGpOREFKZmJ3WGZJazFMcEdJWmQzYlZ6dzRPQ3d0?=
 =?utf-8?B?RDJ0SzAwU2krYVRCNE1TK1JxTFZCRHpyVmIxa3V3UE5mRG5SY2NmbVJDZUVt?=
 =?utf-8?B?a0c4eTZ0NjZscDVZLzRLb2x6QjBQLzdnTVRQUDB4czliNFJhUXlEUFlUUzNa?=
 =?utf-8?B?bDRlUll1cTBJTjZVRDltK2FCdGRxMDhJWmRmRWlkMndoYUJsVVFHcWVUMnRv?=
 =?utf-8?B?aXdObkdpWjlES3I5MElTeTdQMjVyeURURXA0RXFZekh3TGNRVjQ1V2VqenJ4?=
 =?utf-8?B?RU92S0JEemlkZDhlT0Jwb2M2TjJoN2NRUTlWcEVHZGRnRnN1V1pqTHdFdm1x?=
 =?utf-8?B?cEVCRVcrZGN5SFNXUGhua0crc1BPcm5RTDhQMkNjUW9XQk9jY1QvMXRhUHRO?=
 =?utf-8?B?OFNNamxRN0Q3dzR3K2FHeDhCQ3czNlI3SjRwOWl5SVNBbHJidGpOYVZWKzkx?=
 =?utf-8?B?MW0rZ281QWttL3JvTnZLNEh3L0xELzZuU25GVEdheXY0RTJOMXZ3RVNnK01o?=
 =?utf-8?B?L0gwWGt6UWpZejBVUEtoV3VMZThIT09qOXhsQmk3RDZZVmNMNy8waTRtRlE3?=
 =?utf-8?B?a3o2NGp0Y2N6ZUVQQ2NLd1NPRTUxNk5lZDJWL3lHV1RkRDJoZzBxSmYwRjRD?=
 =?utf-8?B?c0FjTnkyMkpWRmY0S21sWUZlMXA1MERtYjdmcHUvTGMvUHY1a0o3NDIwWWlX?=
 =?utf-8?B?SkRxQVdMMXltVk5hSzB0Uko4WFc1RkxmL2hPbjJSWElyOFRkc2xnTUxtTFov?=
 =?utf-8?B?Vk42S1lwMVNxNGNqZHB5MlRhVGJrQ0s5Tldkd083eUorTTVWdVFJaWRTN2Vt?=
 =?utf-8?B?dkxFNFZEZGJMa2VoUVVsUUNKcThRUUFlb1hFNnk4MjZ6bGlISjNhZHZRN0sr?=
 =?utf-8?B?Q09RdUdUYU5xRjBpVW1HbjlDOW15UkFPbmNSUFNIUDBIelkvWEhDdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31b50537-6199-46fd-b8f1-08da2697b4e7
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:43:44.4286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QnGPBIna7w5QCA+on4z0BrWmh88J8zzk6jnLn8NuK7xx2FVT0XPddEUHzw6i8DuoGABAlL7oU1NzJe5kpb99OQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB2977

When a page table ends up with all contiguous entries (including all
identical attributes), it can be replaced by a superpage entry at the
next higher level. The page table itself can then be scheduled for
freeing.

The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap
for whenever we (and obviously hardware) start supporting 512G mappings.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
---
Unlike the freeing of all-empty page tables, this causes quite a bit of
back and forth for PV domains, due to their mapping/unmapping of pages
when they get converted to/from being page tables. It may therefore be
worth considering to delay re-coalescing a little, to avoid doing so
when the superpage would otherwise get split again pretty soon. But I
think this would better be the subject of a separate change anyway.

Of course this could also be helped by more "aware" kernel side
behavior: They could avoid immediately mapping freed page tables
writable again, in anticipation of re-using that same page for another
page table elsewhere.
---
v4: Re-base over changes earlier in the series.
v3: New.

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -2216,14 +2216,35 @@ static int __must_check cf_check intel_i
      * While the (ab)use of PTE_kind_table here allows to save some work in
      * the function, the main motivation for it is that it avoids a so far
      * unexplained hang during boot (while preparing Dom0) on a Westmere
-     * based laptop.
+     * based laptop.  This also has the intended effect of terminating the
+     * loop when super pages aren't supported anymore at the next level.
      */
-    pt_update_contig_markers(&page->val,
-                             address_level_offset(dfn_to_daddr(dfn), level),
-                             level,
-                             (hd->platform_ops->page_sizes &
-                              (1UL << level_to_offset_bits(level + 1))
-                              ? PTE_kind_leaf : PTE_kind_table));
+    while ( pt_update_contig_markers(&page->val,
+                                     address_level_offset(dfn_to_daddr(dfn), level),
+                                     level,
+                                     (hd->platform_ops->page_sizes &
+                                      (1UL << level_to_offset_bits(level + 1))
+                                       ? PTE_kind_leaf : PTE_kind_table)) )
+    {
+        struct page_info *pg = maddr_to_page(pg_maddr);
+
+        unmap_vtd_domain_page(page);
+
+        new.val &= ~(LEVEL_MASK << level_to_offset_bits(level));
+        dma_set_pte_superpage(new);
+
+        pg_maddr = addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), ++level,
+                                          flush_flags, false);
+        BUG_ON(pg_maddr < PAGE_SIZE);
+
+        page = map_vtd_domain_page(pg_maddr);
+        pte = &page[address_level_offset(dfn_to_daddr(dfn), level)];
+        *pte = new;
+        iommu_sync_cache(pte, sizeof(*pte));
+
+        *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all;
+        iommu_queue_free_pgtable(hd, pg);
+    }
 
     spin_unlock(&hd->arch.mapping_lock);
     unmap_vtd_domain_page(page);
--- a/xen/drivers/passthrough/vtd/iommu.h
+++ b/xen/drivers/passthrough/vtd/iommu.h
@@ -232,7 +232,7 @@ struct context_entry {
 
 /* page table handling */
 #define LEVEL_STRIDE       (9)
-#define LEVEL_MASK         ((1 << LEVEL_STRIDE) - 1)
+#define LEVEL_MASK         (PTE_NUM - 1UL)
 #define PTE_NUM            (1 << LEVEL_STRIDE)
 #define level_to_agaw(val) ((val) - 2)
 #define agaw_to_level(val) ((val) + 2)



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:44:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:44:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312594.529918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuKo-0007Yd-7c; Mon, 25 Apr 2022 08:44:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312594.529918; Mon, 25 Apr 2022 08:44:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuKo-0007YW-4W; Mon, 25 Apr 2022 08:44:42 +0000
Received: by outflank-mailman (input) for mailman id 312594;
 Mon, 25 Apr 2022 08:44:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuKm-0006Gx-Pj
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:44:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f1c49a42-c473-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:44:40 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-amMb_LFZOMu6XEUgtkPj9g-1; Mon, 25 Apr 2022 10:44:38 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM5PR04MB2977.eurprd04.prod.outlook.com (2603:10a6:206:a::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:44:37 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:44:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1c49a42-c473-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876279;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VKOf5D5gFHYc8NiI8kFeZJqK9EWiOdTIy+CLucDl34s=;
	b=V9WX0lV0t2sza+nXm5ROHZ5dF/dsKoPBlSMFulcSTFGgWlqjo8m9uqKIHyv0bJgtNFSAKd
	ZZt1yrx/fJVm1GosY0GD7ayTovFpimClo0NodGWSRzuC1fCRKjjDpFI/ptIMD7oRSN3JvZ
	WjQENp91kO78ObeQp0HZroxjnbBw1Gk=
X-MC-Unique: amMb_LFZOMu6XEUgtkPj9g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DFKomPZ0ehnH2Tv7nR1rxT+Thg+o1r1+ZOU22OVWCYKdsYc+V3bVmmC7nI7WXSOSwLCNW9fy3wUSyYDt5oXW3MB/IXkpoe6s+XIrlNEgNoSHWtWSRNOOyWchT3VPrGIiD19j7K5kjpCxpK87xf1yV684dmEr8HmC5EWpqV9ZKG9gbMf0rUrvkJG+M1m58cmeEE+1fzRS1PFLU6MpIRx5A7zhkPTAQfhDoGS0RyTO1qRKzSpC8pgO6QnaXiZIDb0Uakx5WY+ZmrI9SMdapC940hSVyZ4V4Jo8zb5egnp0ynrXKSjVRiJg01aF/AvhLBQ1BmZ8LqCG2zLRgWPaO3T8Lw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VKOf5D5gFHYc8NiI8kFeZJqK9EWiOdTIy+CLucDl34s=;
 b=S7aFEpYdwpOcgky23RyKTWbkFXfV+8rfPhhvKiiwi/55q5PgdrPkY0V7mii3l7J+bHimPqFme3we4ukKnPpS8LFMsPQKmTWbnfB3m7UyKQOcRJgqjONfK0o9Xj1eNB5p6gNnMFVVvUgpEdl0BvCc/39mv23S6kay7IReWJEGx+0fXZiTXBM7PszCAcd35EWBbdpyMetrR9Rt9YA8LL006CO+8FhXTBJXf95n9cdwnNyGc+H2eHF3WmHG4zqoX5KbKLyScV7AQYHXRN7BHwncFKkK/4Dwfy6NJEOW7nHWD2ZVcg5gNSfDmGOHiaA8AT/8PFC8dxb8ZxTdDAA1QIjRpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <eec16b83-7f8f-e94d-b1f6-9113ff93fd14@suse.com>
Date: Mon, 25 Apr 2022 10:44:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 20/21] VT-d: fold iommu_flush_iotlb{,_pages}()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0024.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::37) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 70d23c8a-15b3-4f4d-dfad-08da2697d46d
X-MS-TrafficTypeDiagnostic: AM5PR04MB2977:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB2977557DDED8158909CFFD91B3F89@AM5PR04MB2977.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zClWtB2CE9VAH9kzgPKpN/kq1Dx1PNtOm0os0MInwnVppE4seVQOFtVb5OFr/MG8lQK5wBQ2xHsRRe6lG4ong4gYWkVRE5hPHXlZLzydgGniVLjbzKSC6ZfJCkRQlAG7RNB6HyR7a6YN7vq6hJ0MvleWZkW00r9Yo1voVU+9uzap24JrNTRs7vg7S4XNb2pF6fJT45vs5IKT2YCSiF7Xuv5RQOikicMaOSEtzxj6Fl/oKsw6ps97UArEkt9bmWLbU7TndWY8sQAvAbbNkCnVAbLScZTIOlpdo6ITl/oKpJBWotKvjBmcOvBvIiXfSkq4BAj8vNaoiTbwXcjxlLOZGuP0ZhR1RQiLqFtaBYtvngIeB/aaZ3/eTQDojxG4PlTudw2eiLu4Xylo+a4XDl+wNIo1uHzbjReMfbF7NXbpMSmFe+C7wY69ZlYMTOSqOlXTbBIW4GwJl7S2von9anyHxWiPW+MTWxK6QteCyjP7clekbrVgdPcViMT5PNi6Emy3oK9U+nIXAqCin7gEbLbIHF/YJZRrofIEgZ5g0DLR/XI3vdajh2QvtsuNa9nMLSJ9ckWaA5ItXsNVREJqeRABr5NUC5Wffe1F27qXaCEjHrchYmXbvJJWBYZ8SHW+kke6aNjxXZYGjG7TJCPQyf+6y3K3o3wuix6MxpZ5fZ3k1CH61cMuJNql4x7QvBzvxOm4ORVIYrnNcHHvaHvEqwzoHty3HKjkiMKMa3ASnc/9YZo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(6916009)(508600001)(38100700002)(26005)(6512007)(6486002)(31696002)(5660300002)(83380400001)(36756003)(86362001)(8936002)(31686004)(2616005)(2906002)(66476007)(66556008)(54906003)(8676002)(4326008)(6506007)(186003)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N3BOYlRNWVBwbkhoQjZPUmgxSjR5bUg5V1c2MzdqeXRoNWQ1VjB6dVhEdUNJ?=
 =?utf-8?B?UkJucVh6MXlvdFNJUnVuWE8zMkl6eFVZQ2RwWTlHMmF6YVpzUnh6V3N5RFhz?=
 =?utf-8?B?bVZOVVJ2eFBaV2ZNQ3VRRWRPMm5iOXNNazY3ek5Ddzk1K2c4LzQ3RnppNW1V?=
 =?utf-8?B?RXdiWHBDSkkyQllraFFhekpSMmxBSG4yekd5LzF0Z1JTUURyU2ZLSUtGS2Nr?=
 =?utf-8?B?ZTk1TmR6U1FBMHB0T1pDaGdUM0o0d0FCZGUzNW9vbVg4ZWYvdjZMVy9jaVdY?=
 =?utf-8?B?U2JoRXJQZmVUWjdJT3VHK0hqS015VXVtVWN5U2RjVzU2QjNsNVpQLzI1SXZ4?=
 =?utf-8?B?clk3eHV2RENRc0F4MnRDdTdEaU9RNjRKdEUzQTdRUDJycHlOQ3RxVmFWZjd6?=
 =?utf-8?B?ZWVlWGJGVXV0di9Ca0ZsL0Q1Mm1ZYVFSRnVRbjI1VWVmSlRaT1ZTTk5ONnZB?=
 =?utf-8?B?WkNwT1ZwZUV0UzNDbVNVeDVDUE05aHJDK2NKdHpUM3RkRHVTTHZMN252RHlw?=
 =?utf-8?B?Vk5ReS95eGN3WXRIMUpvaFVRL0lZZngxYy9MUnFQOFB0MEN4YnJMTklSQUhu?=
 =?utf-8?B?MUNoNVp0ZHhSOFFwM08vQjNjODhLVWt3a3R3YWpvcVhpWUxBM2lBZWRlRUc3?=
 =?utf-8?B?U0Eza3lzWFBBQUJZbEhSNU8xUzRVbVN0enYzRllYWjBVZHFjSTdOS3RVY0tD?=
 =?utf-8?B?OGxXT3R0S2JOOERBYnV1T1J0MFBZVERCWTRoRGRBS3U3YVIzbDIzVXZZcWFJ?=
 =?utf-8?B?NHJDQ3ZSdWh0TG9nTTZFSWhPM0JaODRma3JEZWZGQURvd1p6aVZzYVFudXBs?=
 =?utf-8?B?cEluSmprTUp3eS9BNGU5NDFnSDJGSm9lR1RuUEw2dy9hcTVIVjVxZEVJdnFR?=
 =?utf-8?B?QlhmUVlmdTdJTHo1MENEcW9sWFJCRHdUcHdOL0NnM1pYK3RCWEk5ZFJGVXVZ?=
 =?utf-8?B?c2MzZkZWVmkyUGpvSDB2SkRocXY1NnZiaTV6ekh3UUc4cG9zZEpVV0YreTky?=
 =?utf-8?B?L0YvNzJIbDhKb2JTZXN6NENKSWNoUUtDQWpXaFRRQUNGS2FXb2pZbU5ZdG1B?=
 =?utf-8?B?RGsweEFWK0JaRTk5UmtFY0xiQ2hoVnhINGNlRThkbEFmai9SS3JiT1lvYUk1?=
 =?utf-8?B?RzNwcTZCN2FBWENhNE5WTXJxdzFzM3BEWEdEZUo3eFVsZFpmcHVKU01yQ0hW?=
 =?utf-8?B?L0sveXpybml1YS9MZENZTkJqK3ZKL2tEOXF2VEFjeXpVRG1SOVVPZURWMUpF?=
 =?utf-8?B?OGtmb3hqODB2U1lJQ3Y4Z0JlRktKTE9Gd0pVd0MwQ3ZsYVR2bTE4ejhRMmxZ?=
 =?utf-8?B?NFJORElDMUQ4WnB5Q0s3SThWc2NLMEtRbEVSZFZ5RXlNZ21TaGNVUk1qZmhy?=
 =?utf-8?B?VG5HV3ZpdTlBbmprNEg5eHpVbzVUb3ErUkVQYUF1OFJuVzRWdG1UWDNPS29N?=
 =?utf-8?B?bTNVNTdMQUdmcUowcTV3L0w5L0pFS0wwcW92UkFrcExiemhXdUtNZzlQWVY3?=
 =?utf-8?B?bmwrYWxtY0xGYXVrdkhuUm12dTNabFZidUhWeTVOYmtKNHRkVFgwRG1ERjFn?=
 =?utf-8?B?YzlDMWNJQXRYa29TNnlKM3RIS25zS0RXTGRGVlRHT09hT1d0Yit2SzF0cnFQ?=
 =?utf-8?B?RmE0eU1zRFp1Q2FOeTV4ejB4dWhYUXphcFpCZmp1U24rTENtdWhqZTZVTGcz?=
 =?utf-8?B?bnQxL3FPWGxmeUc4TUxCWjNVcHo5ejlNL3pJaTBDSTN4eFJWS2pPY0dXQXVk?=
 =?utf-8?B?MnlacHlhS1VscFJBb1gvMGhTRXl4K28wQUNmOFprcmY1Vk1CNTBoSHhoTzVG?=
 =?utf-8?B?RlorUTdrVEU3RkNTYWpvZndMa0w5bWhRM2c5cjQ5dHVPRzJPUms1NTIwakJm?=
 =?utf-8?B?dzVMNnB3eXBhYkhJUWJwTU1EcExJb3hPSHNmZ2N5ZmtOb2Jqb3RQUVlNQUhz?=
 =?utf-8?B?bldiVlc0a3o2UVdJUkduK1NheWVZK0EvTmRsdU1SSDN4clcveUhvdUEwRmFR?=
 =?utf-8?B?d1lISWNWVlhaMUJydnZIYStPUnNwM2FzOVlEb3dwd2V3WS90SUNCcDEwSmZR?=
 =?utf-8?B?cXpFQnpCWDRlYm8rRW9hZHpVd01jeUdPZ2Y3cmtzVXBhN01aUVVIeC94QUI5?=
 =?utf-8?B?cm1TaDJXZXF1bWlLcTRtOCt1QWl3MXp2dEhZVGdHY0pSd0lBUG43bUptTXpn?=
 =?utf-8?B?b1pGcTVIdjMwV3VxZURjUDlnYzVjUDRGeU1ZWGlnRmIxRG9Eb0U0SW56TEY5?=
 =?utf-8?B?YlBmVDFTVTUrTzVyVDh1L3hJekpJdDFxMWRORVBiNHlXdVNHYTAyY0hQRWhk?=
 =?utf-8?B?VXdDRzBrWGZVVENlQUhtS1UyWnh1Vzg4NEVXVjJxRzRXazBVWXQ0dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70d23c8a-15b3-4f4d-dfad-08da2697d46d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:44:37.3171
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k7fAhFoevg0hQXWekoohtYGS79unbsX5B0enOzQDCkaNq6Bo8GhownF1cPEFJG0IIjzLwpci9yftLEm6kAb7cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB2977

With iommu_flush_iotlb_all() gone, iommu_flush_iotlb_pages() is merely a
wrapper around the not otherwise called iommu_flush_iotlb(). Fold both
functions.

No functional change intended.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v4: New.

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -728,9 +728,9 @@ static int __must_check iommu_flush_all(
     return rc;
 }
 
-static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn,
-                                          bool_t dma_old_pte_present,
-                                          unsigned long page_count)
+static int __must_check cf_check iommu_flush_iotlb(struct domain *d, dfn_t dfn,
+                                                   unsigned long page_count,
+                                                   unsigned int flush_flags)
 {
     struct domain_iommu *hd = dom_iommu(d);
     struct acpi_drhd_unit *drhd;
@@ -739,6 +739,17 @@ static int __must_check iommu_flush_iotl
     int iommu_domid;
     int ret = 0;
 
+    if ( flush_flags & IOMMU_FLUSHF_all )
+    {
+        dfn = INVALID_DFN;
+        page_count = 0;
+    }
+    else
+    {
+        ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
+        ASSERT(flush_flags);
+    }
+
     /*
      * No need pcideves_lock here because we have flush
      * when assign/deassign device
@@ -765,7 +776,7 @@ static int __must_check iommu_flush_iotl
             rc = iommu_flush_iotlb_psi(iommu, iommu_domid,
                                        dfn_to_daddr(dfn),
                                        get_order_from_pages(page_count),
-                                       !dma_old_pte_present,
+                                       !(flush_flags & IOMMU_FLUSHF_modified),
                                        flush_dev_iotlb);
 
         if ( rc > 0 )
@@ -777,25 +788,6 @@ static int __must_check iommu_flush_iotl
     return ret;
 }
 
-static int __must_check cf_check iommu_flush_iotlb_pages(
-    struct domain *d, dfn_t dfn, unsigned long page_count,
-    unsigned int flush_flags)
-{
-    if ( flush_flags & IOMMU_FLUSHF_all )
-    {
-        dfn = INVALID_DFN;
-        page_count = 0;
-    }
-    else
-    {
-        ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
-        ASSERT(flush_flags);
-    }
-
-    return iommu_flush_iotlb(d, dfn, flush_flags & IOMMU_FLUSHF_modified,
-                             page_count);
-}
-
 static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int level)
 {
     if ( level > 1 )
@@ -3254,7 +3246,7 @@ static const struct iommu_ops __initcons
     .suspend = vtd_suspend,
     .resume = vtd_resume,
     .crash_shutdown = vtd_crash_shutdown,
-    .iotlb_flush = iommu_flush_iotlb_pages,
+    .iotlb_flush = iommu_flush_iotlb,
     .get_reserved_device_memory = intel_iommu_get_reserved_device_memory,
     .dump_page_tables = vtd_dump_page_tables,
 };



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:45:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:45:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312600.529928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuLK-0008Be-NK; Mon, 25 Apr 2022 08:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312600.529928; Mon, 25 Apr 2022 08:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuLK-0008BX-KF; Mon, 25 Apr 2022 08:45:14 +0000
Received: by outflank-mailman (input) for mailman id 312600;
 Mon, 25 Apr 2022 08:45:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuLJ-0007xd-DJ
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:45:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04f4af2b-c474-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:45:12 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-883xrxsdMsqnka3G6lzhlA-1; Mon, 25 Apr 2022 10:45:11 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR0402MB3589.eurprd04.prod.outlook.com (2603:10a6:209:3::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:45:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:45:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04f4af2b-c474-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876312;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jXroAWCzWdcYKf4JkOt1e3tm2yhGlKfIfFmJbhMkY+A=;
	b=kr7KnmwIPS0SFGtkzRGxOcuaquHDQMxy0Lrudl11hcm1TcEjrmkizs8kXqIRGIHSTPJqhf
	8V4g1WhjsU1gx1tiHB5psTZX9/meI+KkktqWQifKM5PWTX5hsTbt/PnscP/MDj3yBQF3jT
	FlCyG0Y5RJ5bDFy500i5oxW+nCRGKXg=
X-MC-Unique: 883xrxsdMsqnka3G6lzhlA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HInOMlI4Bg+9oFbVpgietINA1BzkEzKrxHWbmndiaqi9B2OYq9MmpV9uHvIn5vMOiZ/s4hFehxZ/hKgpgilB2YXr85ajz9FaL5dHYcbti/5Mtwhe2jv0HObKRK1kkasPcqcu9NmZgM/PSBb3y6NdeDNDkMK5Olu02U/iCX4W+XzOsstZvCyDtHdGIJSAU2SgRdvrXXusN+zqLW/5SLvjX55+bFVdiukUqeEonmFAAA8wiS3onyomkvSWqwBAKrrB0O3svKrdUS1llNOoAQUJNC/iO2cDHBT89XPjxp3AqaulG1uMnr+2pCsVvCy7W0tGbm/Ons5m0Pbx8lMSiVK3cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jXroAWCzWdcYKf4JkOt1e3tm2yhGlKfIfFmJbhMkY+A=;
 b=UJmktIb5WKgJhWQl2o7vw3K/tgnDvU/9G/Rm3SnqXQCiSIRtaNcuYU11TtrmNCoWACN7o8F+QOl5FpEE5nKqDa8hJks1V6n01PiUuxx+rcDoG0TX6GxakFG3DcWrMykV84mArem5Nb0MOrl/1qk00ttzwdD0Cwf8vtecea7VLpxGsYZs98EULABok0++/L5TW7dP85vexLSJVFdKu4vjr/bMrHo+05soCwwLlwceVzyOAHuXdDunsv0gS8HPoXx6wXkOv8IKtoPK4x8NZJrZM8YU7g3VTyd5ETVqDUVniiTrqeAoBBwme9WbmOm83IiTIWT4mses2pRL+JkDF2xu4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4a24a85e-267f-9de5-4009-b32b9ab8aa0d@suse.com>
Date: Mon, 25 Apr 2022 10:45:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 21/21] VT-d: fold dma_pte_clear_one() into its only caller
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0064.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::41) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: abf36fe3-1522-4f9d-a676-08da2697e768
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3589:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3589F6FEEE54DBF4E0084686B3F89@AM6PR0402MB3589.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yPzY50RVEYMGVEFRJHYq9HhHq4nVfj0OeqWX5vARnB16yOCSpV6ggN25iBkI8FrV8bzRAVbeYign74vdpzDp3lcVf1VIS4tY7c+uBQmKp89oy89E8guMr0AXZ5rEwLax1L6ACdVA2uTeHOU3x15ZhGyeVRtO7DhYMXIVFeNf/vus7iUbsQSxXMOzkAwFTMMag5qdriUpRG5riTzS6F/1KE0ZV6E3mRFDrAGG6wxtjQ/KEkNwCycV/ncYcivEyFv/7mEsgC0mD6hWQNV9fTd6ZU0UHQGArnxgO4NIQiY8g37w7WoTX/JDe7ozL0gGHzb0tx9JaB5+Tf8t/JYqqjsVVdbseFFpFCUHXCekUR6DgyOfC5rwsl0F9gj/ifzLEjEntzilbNQAUhSoBDhzTDXEdHbxfNPT1eyOefJliQshLxEFCkQYIxcCKq1rVroKCJsHgLsLfJW4A2xx19bElrlD5L4Xb0WZ4ebJ3u3YanwhZq03B5ZUetM7Pq1su/12/hJbzYkOD/X2+RCJJ0WCeaEBzCVTacOVTwsxkZJWU18ZhA0hvxHrOQgmHA5Dqwc75/8NvE1OWIYLP6r9omoJ7MqDwpThlp1RCHIZbH1J5pQCHawW05iiGVAm++R0g7GUqQPxJsUJrwSP/15z3i05Qi18TE+NO/+yRh3Kd0wpURWpO7ARYt58F6PBz8HH8WeX8j0ZldUwc1IQ0YtpYM5IS+MJwAtVHh+pf+zoIPnDIFytukQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(54906003)(6486002)(5660300002)(508600001)(8936002)(2906002)(31686004)(83380400001)(2616005)(186003)(8676002)(4326008)(66946007)(66476007)(66556008)(26005)(6512007)(6506007)(6666004)(316002)(6916009)(31696002)(38100700002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGt4ZlgvSEU4Mjc3NlZ6TVliT284eXEzWUdBU1RyZUJULys3di9sZE5seEFF?=
 =?utf-8?B?UllnZUgzYWEweTVGd2hQTlVPSVBSMjZzSWRWM0x0ZSt5UUhBajRIWjlVLzl6?=
 =?utf-8?B?YlRiaUt5NkM4bDQrWEJoN3JxVkdENHJOd25pZ3NlMG1rWXNQNyt1Ym5QcVdx?=
 =?utf-8?B?Ty9BZVdlNGowanRtd3hnZm9laGUwVTd2dXN6bjErNEpGNzFyWmdlUVRBdGRr?=
 =?utf-8?B?SmFJd0dNTm8rN01YNkFYcWViUUZYamY0WldDaW9jWlhMV1hBUVAyY0hORWZN?=
 =?utf-8?B?Vnd1amRPYUdMb3hldlZBWGVuV0pVTkVaeVZsUFNCSFUwVForaGp5SkZXN3Yx?=
 =?utf-8?B?czRJZU0vVnlMMU9MSmdmZHVzOXZPR2hicVp0alRWQVBuUWluZUtxSHlkMmg0?=
 =?utf-8?B?UTJWQThNc1NGelBtdDRGMndON3BYcHErSmNrbEhabmRMZGlKMnljMGRRMlQ5?=
 =?utf-8?B?Rk0wUlRMemZxVklmUVhlOVFFZW42N2VVZ1dQZkN5UFZiRXFKc29SRUhUK0ha?=
 =?utf-8?B?NUdNMytTWHRHRzZIS0Z2QTRRa1VTNFZGdThGSDZ1eUZEdXZnWDNTSG9qVlBl?=
 =?utf-8?B?THZtMm9UMnR0VzEvMW1udjdIZDVnbURKQXMvOUdSRHRjWDZocUppT0MrSmlm?=
 =?utf-8?B?S2EyLzh4bGlFOEk1RlR2anoxSjRncGNDV2RPcmd2MjJEbVByY3liRENPejlp?=
 =?utf-8?B?cTJGdlVUbHVpam81OHkyQ2g5YmZLeEZKQkJuZjFObWJGMHhLN21vMkl1Z3dN?=
 =?utf-8?B?WVczYWtSWEdZMHZnMG5lbm5qcHFocXY0UUFuaDh5Y1dlVFJuWGZMWlVNWU5F?=
 =?utf-8?B?RnAwSXVBZVEwaXViZ0ZOZWg4MTF3dmVBaVNoSDdtT0U1bXlFM0d6V2NadG96?=
 =?utf-8?B?S3c5RWI1SiswOFpJUVNnZWJWd0ZJK3pIR0QxKzNxa2NyT2xHVE1QUURpMVlD?=
 =?utf-8?B?VFREMko1OHJNWk1QbDhjZjd4VmorZVh2NGhQNnRERjB5T0FxcTE0bHhlRWkv?=
 =?utf-8?B?WkQ5aG9RZytmekZBcGk3M3ZrOENKSXZXaitnRmJhMHNXUVpyUERhMXJSVHNh?=
 =?utf-8?B?K1NpYlZOcUVWdHJlak5nYkttbEw1VVJBZVV3WmlQL1VzUmtHT0kvbDhManVz?=
 =?utf-8?B?dU9qcW4wS1hqWGgzeHFWTUt2UndTQS9uTHRubE1vaHRpSlpGclRBc1ptQ1RN?=
 =?utf-8?B?eEVaaGhueUl6bHV5ZXJnbllPU29lSmMycHVicGllV2RKWi9TYTR2ZjErVnNm?=
 =?utf-8?B?bk85VWVydzFBUk5LaHpIUGp3SXN1bWVKMkpiZXNkS3dnRVNLRXBRdHk2ZGJZ?=
 =?utf-8?B?K2tUNi92QUZ1SFRGYy9ZNzdxTTYvZEVaMktxNW4vZGNZUmFSVndScWIvUWNj?=
 =?utf-8?B?Z0JZREI4eGpmOHlBZE1pc01XTVBpSGdyUm5BdmtIY3VIVURiR0gxMGE2ZmxO?=
 =?utf-8?B?QjBlYTdxYksyMXBuc0FBb3BtdHF2UW1KZkpKVDlkQUwvUkorR2wzRjhsR0FX?=
 =?utf-8?B?Z05iT2JkTHVaemtrdVRDNjJrdU9LaGVzVHRtVHJLMWxRbEVjNEE0Q0lZMlIx?=
 =?utf-8?B?OTZZRnlIc0JlSERmMWlTWGNMd1lxRlQyNTJndVpWS00vcXZIRU9vY0dNRjl1?=
 =?utf-8?B?MUMzYlhnWkVZSVNBbkUramkxYWVGSkVpdG5CanQ2REdLUXdvSVBPREdJZ0pH?=
 =?utf-8?B?K1lLd2NBSDB2L0Fic1YwZGgwQXNCRk8xdThmT3pqSHJ5aTduc0VJZWNzUjJM?=
 =?utf-8?B?LzEvM0VxSmdsZTB1c1BObHdmV1dsU1R1UkI2ZDI3dUJvQ2RZRmI2c3JJU0J4?=
 =?utf-8?B?M3dIbTcrRDNnUUJ3cE51ZVlSR0pVbUtBTE05bHlrTjRPNWhnQno5WFNpOTJt?=
 =?utf-8?B?dHBxRmF3Ynd1ZUswWUIrWXdxY0hxSGFNNUZlb1dyODRmUW8za1k4ZkFUcTBR?=
 =?utf-8?B?TG1ESFBWZGFhRlIyMk43cFN6OGd4RW54TnVVRmpzdFFmamw0R1AxWlYxZEpX?=
 =?utf-8?B?UGhReXFqeC9WZHVYZlNZS3IyZERzSnpnMUhKN2FJRjc4UTNNbXZYV1AxV3hR?=
 =?utf-8?B?UmRPL3ZQVmdxZDBIMTNBYXJ6U1U0bGREcDE5U1orQkN6UnRORWFveXNBb3ow?=
 =?utf-8?B?SEwzWGdtQVI3WkdXemYwMmlka3QxcGY1TWxDb05WaDBjUy9TMUFSTS9XQVly?=
 =?utf-8?B?c3JpYTZQU2ovTGJac2ZZc0cxUXdNQXJMd3YvSzZBRzRXSW5NU0pEZjhoSHJo?=
 =?utf-8?B?clRUdjhnQjZuUzRaYlFQMFl4UXNQWUdjT3hDNXUxYjdjbkMwTHVuTFFUdW55?=
 =?utf-8?B?cnJjbGZ6UzBTUkw0dE5aQS9yMjlSakVzT3pJV29hY1Z2ZTRDM1d0QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abf36fe3-1522-4f9d-a676-08da2697e768
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:45:09.1596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WTxGIlSfltNLOmE5j3Ebd+5bNFOtLGcC3NzX3aoayucvjIQmLH6Rw/FcV2ERoBJekHWtd19Yw2TBvDOyCxM1/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3589

This way intel_iommu_unmap_page() ends up quite a bit more similar to
intel_iommu_map_page().

No functional change intended.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v4: New.

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -806,75 +806,6 @@ static void queue_free_pt(struct domain_
     iommu_queue_free_pgtable(hd, mfn_to_page(mfn));
 }
 
-/* clear one page's page table */
-static int dma_pte_clear_one(struct domain *domain, daddr_t addr,
-                             unsigned int order,
-                             unsigned int *flush_flags)
-{
-    struct domain_iommu *hd = dom_iommu(domain);
-    struct dma_pte *page = NULL, *pte = NULL, old;
-    u64 pg_maddr;
-    unsigned int level = (order / LEVEL_STRIDE) + 1;
-
-    spin_lock(&hd->arch.mapping_lock);
-    /* get target level pte */
-    pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, false);
-    if ( pg_maddr < PAGE_SIZE )
-    {
-        spin_unlock(&hd->arch.mapping_lock);
-        return pg_maddr ? -ENOMEM : 0;
-    }
-
-    page = (struct dma_pte *)map_vtd_domain_page(pg_maddr);
-    pte = &page[address_level_offset(addr, level)];
-
-    if ( !dma_pte_present(*pte) )
-    {
-        spin_unlock(&hd->arch.mapping_lock);
-        unmap_vtd_domain_page(page);
-        return 0;
-    }
-
-    old = *pte;
-    dma_clear_pte(*pte);
-    iommu_sync_cache(pte, sizeof(*pte));
-
-    while ( pt_update_contig_markers(&page->val,
-                                     address_level_offset(addr, level),
-                                     level, PTE_kind_null) &&
-            ++level < min_pt_levels )
-    {
-        struct page_info *pg = maddr_to_page(pg_maddr);
-
-        unmap_vtd_domain_page(page);
-
-        pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags,
-                                          false);
-        BUG_ON(pg_maddr < PAGE_SIZE);
-
-        page = map_vtd_domain_page(pg_maddr);
-        pte = &page[address_level_offset(addr, level)];
-        dma_clear_pte(*pte);
-        iommu_sync_cache(pte, sizeof(*pte));
-
-        *flush_flags |= IOMMU_FLUSHF_all;
-        iommu_queue_free_pgtable(hd, pg);
-        perfc_incr(iommu_pt_coalesces);
-    }
-
-    spin_unlock(&hd->arch.mapping_lock);
-
-    unmap_vtd_domain_page(page);
-
-    *flush_flags |= IOMMU_FLUSHF_modified;
-
-    if ( order && !dma_pte_superpage(old) )
-        queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)),
-                      order / LEVEL_STRIDE);
-
-    return 0;
-}
-
 static int iommu_set_root_entry(struct vtd_iommu *iommu)
 {
     u32 sts;
@@ -2261,6 +2192,12 @@ static int __must_check cf_check intel_i
 static int __must_check cf_check intel_iommu_unmap_page(
     struct domain *d, dfn_t dfn, unsigned int order, unsigned int *flush_flags)
 {
+    struct domain_iommu *hd = dom_iommu(d);
+    daddr_t addr = dfn_to_daddr(dfn);
+    struct dma_pte *page = NULL, *pte = NULL, old;
+    uint64_t pg_maddr;
+    unsigned int level = (order / LEVEL_STRIDE) + 1;
+
     /* Do nothing if VT-d shares EPT page table */
     if ( iommu_use_hap_pt(d) )
         return 0;
@@ -2269,7 +2206,62 @@ static int __must_check cf_check intel_i
     if ( iommu_hwdom_passthrough && is_hardware_domain(d) )
         return 0;
 
-    return dma_pte_clear_one(d, dfn_to_daddr(dfn), order, flush_flags);
+    spin_lock(&hd->arch.mapping_lock);
+    /* get target level pte */
+    pg_maddr = addr_to_dma_page_maddr(d, addr, level, flush_flags, false);
+    if ( pg_maddr < PAGE_SIZE )
+    {
+        spin_unlock(&hd->arch.mapping_lock);
+        return pg_maddr ? -ENOMEM : 0;
+    }
+
+    page = map_vtd_domain_page(pg_maddr);
+    pte = &page[address_level_offset(addr, level)];
+
+    if ( !dma_pte_present(*pte) )
+    {
+        spin_unlock(&hd->arch.mapping_lock);
+        unmap_vtd_domain_page(page);
+        return 0;
+    }
+
+    old = *pte;
+    dma_clear_pte(*pte);
+    iommu_sync_cache(pte, sizeof(*pte));
+
+    while ( pt_update_contig_markers(&page->val,
+                                     address_level_offset(addr, level),
+                                     level, PTE_kind_null) &&
+            ++level < min_pt_levels )
+    {
+        struct page_info *pg = maddr_to_page(pg_maddr);
+
+        unmap_vtd_domain_page(page);
+
+        pg_maddr = addr_to_dma_page_maddr(d, addr, level, flush_flags, false);
+        BUG_ON(pg_maddr < PAGE_SIZE);
+
+        page = map_vtd_domain_page(pg_maddr);
+        pte = &page[address_level_offset(addr, level)];
+        dma_clear_pte(*pte);
+        iommu_sync_cache(pte, sizeof(*pte));
+
+        *flush_flags |= IOMMU_FLUSHF_all;
+        iommu_queue_free_pgtable(hd, pg);
+        perfc_incr(iommu_pt_coalesces);
+    }
+
+    spin_unlock(&hd->arch.mapping_lock);
+
+    unmap_vtd_domain_page(page);
+
+    *flush_flags |= IOMMU_FLUSHF_modified;
+
+    if ( order && !dma_pte_superpage(old) )
+        queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)),
+                      order / LEVEL_STRIDE);
+
+    return 0;
 }
 
 static int cf_check intel_iommu_lookup_page(



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:49:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:49:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312607.529940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuPf-0000Tu-9C; Mon, 25 Apr 2022 08:49:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312607.529940; Mon, 25 Apr 2022 08:49:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuPf-0000Tn-5Q; Mon, 25 Apr 2022 08:49:43 +0000
Received: by outflank-mailman (input) for mailman id 312607;
 Mon, 25 Apr 2022 08:49:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuPd-0000Th-OC
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:49:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a4ceb4c1-c474-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:49:40 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-q9CrLb4vPLGPfUr5BBNyIQ-2; Mon, 25 Apr 2022 10:49:39 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0401MB2254.eurprd04.prod.outlook.com (2603:10a6:800:28::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:49:34 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:49:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4ceb4c1-c474-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876580;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=chFDKHBsC5izimoPwLLKxQUCJ/4iaPH++rRNrnlfBkA=;
	b=IBFrcdsVLtgP314ygb5clewl3Z9tEQhYOmaixuhnix43LFwxhsyd3OJTujKuFrLrYGklsA
	PlukhmrYH00WHBHZUXops1wWKjOTaVIFhQlEiKG5Lq1KnWfDz3Tnm4AOcc0BM+114kDVNI
	yDTr9Q9X+TMNoytm00Qh9Nyx93pB4bU=
X-MC-Unique: q9CrLb4vPLGPfUr5BBNyIQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KXnyC8+xqObSXjfAQLg+rllX4qZdTM+WjhnNZodE0ngGBrMaMHEr2wQbHft8gNOwllYTzxRlrCmXQbTWIrBkQRaKNCtfYtUX6F4mIsjapgpbWw0mPt5xtC7vFWK8oPTDBxdhjouefTXv2aIGRQKKqGgA6KJTsJjKQNR4GKhfL590Bsz/mqdKW5MDoPzZlmKYYcvjYKifAJunLVLvKMv0GHL1RW6+IaTFul5dohpwcffJHIYVH+x0/M06dQQjXqHTsQgpWGow74lG4a7Vymvfvh1qT890uCwKqXCJG3+/iVripwytO+E6tlWOAFmBFrtwA1SRCi300OKk5dqi5zbJjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=chFDKHBsC5izimoPwLLKxQUCJ/4iaPH++rRNrnlfBkA=;
 b=Nzl+CQg5lhgXm7MNpFLSadkRK/iy3mh1aPeg1raluAxOS+qhyDuC65amkxeKCjXq5QYcKr1InAwT2en6bM/e7lP/yu0C/33lXGW2vtKYXFCtVHvY+dX24YboD1eWhWG9pBsoVYns3FkwGts9olJjV26IcWl1F5Kr/mKcDSSWjhcJMRZxLeAE7F5+T4CC+tOFXwMMxjQ/kzLjLGNQ20O8/c31jixqA+M7ycwr5WY9ugqdjVbMh2zKahCoekR5+SkYDDL2gJmFa1TvIXI3BNcnCsUHTUb12TFn6RbOLKJEGnVVePt0A4YxwlujW93Y7JZZiLt5P7WogofRIfqyPoujhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <368e2d54-09f2-2081-349e-571bfeab13af@suse.com>
Date: Mon, 25 Apr 2022 10:49:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2] x86+libxl: correct p2m (shadow) memory pool size
 calculation
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0087.eurprd04.prod.outlook.com
 (2603:10a6:20b:50e::9) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5867052d-78a8-4c79-ff84-08da26988557
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2254:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB22547F0D5A22D80BED7DACBAB3F89@VI1PR0401MB2254.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iv4cMiK6boozBaPtvN/7PfCXLWEWa9/p617pC6o65i+JsKCOOGm1KxrCjv0EMgoYdbgt81Vq6RyddNLRNxP0l6bmSifOOqIJkvBnox4aVRqq0njSqhE5+LJJvJjpCL67497O1UQblPY/miwI461Xx3KytUWkQUyYLeaci7GvP1750fT7hQENDkiOFw0lMb7a5ohuQAml8LIp8vqy6rtbtqdaJ5QiNbWPOKlNIAHKdLK0SM+JCpNtihfA6evL76Uwlh4NWi9g6IfwLQ2iQYMWnyICjm9+wCl/usRu7kbIDW948f9oDVXtB8L8/pf6H4TFnScNbQ4bTElZqm8GXo3N8cgo3pk6IDBLNb4h2qBF3mGiBwl/APbfcHi0yRc1VMTKd/qrqWJAsNFKdXlz3yo0u9phQwO4UYulSFbNXYYksMCGZuO7CGKQitDEM1/wlyK0bZ8VBLlHS3QLt+hyA5/xKwY0RvzHgZa5q7PSqwVNNFAdcdBhBuPUGA4y7wTNCZjHGzF+FrH0YAxTQnE06Wat5LUyZJEICJPNGh8i+3OEm4Ij4bTIgzTGfIvi0pR2Uk3Gs4W6bqe5h492bTe3xeLAgx0j6w8hw9SgCVcxe4mtqaQz8NpyW7W9Agmd4SLq7gLr79qRmKVoIPhBgsnHDom/QpYuSixV/PlyqtnpoKhFZasKUCz3yj7KpYayXr5SBbF7OhDWo0k7OmwxgsLQjtlIHKVaC1wVHITrRrxjwrjx3Uo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(508600001)(186003)(6486002)(66476007)(8676002)(4326008)(6506007)(6916009)(2906002)(107886003)(66946007)(86362001)(26005)(8936002)(38100700002)(54906003)(6512007)(5660300002)(31696002)(36756003)(2616005)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SFN5cENEUFd4RGZqbkxRUERFZWxaZ05PdnhyOFRIRUMydnVESzVuVHkxT0ly?=
 =?utf-8?B?TkFnT0FYVlBVNThGMDJjb1g5Yk10aHRxc21oUG1IM2hxQkxlZHZnUzlVamc4?=
 =?utf-8?B?a2oyWWI0UFZCRFIzbEdQbDVMR2RDamRhNE9QVlhuS1FaRFZXQy9zK2xDWjFF?=
 =?utf-8?B?N2MxLzBxTDJXcE5ka0FveEVkdDZSL1ZHK1JzQ2hQT1Z1M3lYTUxXNWpGMzdX?=
 =?utf-8?B?SE5rVWVraTJ4NXN0M05kdWd2RXN1blVaeHFqZ0dnblpoRGJ5T2hrVGQ1Wncx?=
 =?utf-8?B?SE04bE41UWNaQXBBVFM3ZVZlSGdLcWt5aWJDOHozKzgrQjl6b2lNWXlaU3c2?=
 =?utf-8?B?WlVUUndhYVAyeFNKTUlPdDlDSmpxYzJ4SVAwelV5b2NiSHh3bi9vL2NmTkxB?=
 =?utf-8?B?OVQ3aHJScE9EUVNpTCs3WHRKbTluQlZHYi9tYXRCc0UxR3c5dWFMNUlacTJm?=
 =?utf-8?B?UmZ1NE92SldycEZLbHJ4SExhd2paa3FiZk85RUd0eXZCWjlWcWpXUTYzWW9o?=
 =?utf-8?B?T3pCOTZ1QUNiSzlnRGRMaDRKOExaMGRIc2VBM0NUejZFckhNV3VQMHRMOXht?=
 =?utf-8?B?bEFGK2NLZE9uaGJVRjJHM0tYelFLL3VTbEM4azdsVkI2N2FybFU1OVBaU2xW?=
 =?utf-8?B?WTUraVFrTHZCTWpIM1hvSG5Cb0RDWDcvT1NIMDM1YUpuREVpMldzUHN0cyty?=
 =?utf-8?B?NjNMV0h1c1p3MTZYY0FnQTdtTkFIMzFMZWRteWFwVkdHTDY0dCtxT252TzN5?=
 =?utf-8?B?WUlhMzZrTWdONjBHL0JadVo4SExpS3A3MUl1WVdkbEtOS3J1aEN5Mm9KMzJI?=
 =?utf-8?B?bVZkZkpjS0xGRU5ncUp5SnVPQUtQRmx4bGh5VnJhR0R5N0dGTlVCZHVUZkt1?=
 =?utf-8?B?akpmNllUd21rRElYT1g5ZUtadWZoTS9hWGd6UnUvbnVTeUxqelhtbWU0WWpt?=
 =?utf-8?B?eUs5dnJTNG1mYzF2Y29YK1g3TVpoWFc4VmNFTElJRTcyM3BGYVF1YnhDeWlm?=
 =?utf-8?B?VVdSeWI1UHNBM3BhQUFpZGVzb1lYbnNYdzFqcVhaVGRmdk80OGJ3Y3pSUG11?=
 =?utf-8?B?bXpDZVcvUzJTY2swRisyNmRNVWx3UVl5azJzeGVDVU8wZjAvMUpoV1E4MDlr?=
 =?utf-8?B?bzllVXlLL3czYnNIZkRLS0UwbDdnTnRuTDE4N094QVhnd0ZUVzl2dTFMdzFp?=
 =?utf-8?B?TG5QSE13dnV2eG1jUkFvK2NtQjBFU0pZVGlVd1hGaXlYSGNFbEFHeWxSOHMz?=
 =?utf-8?B?Q1ozZUpWRXN2dW9UOExmbW01TmlGdktGWEdwUmJUUmphcklBZDlVQ1pralJQ?=
 =?utf-8?B?cTkrWEJuTm02c0M4RE1MajdpMjVnNkFsNnV1UzhNSko0UldhbVIwTlJaemdz?=
 =?utf-8?B?S0NZUTllMEJFeUlBaHhaQllmUk1jWVVXMmljc3RvajQ5TUQ3bHo4VW9RelBK?=
 =?utf-8?B?MWFEUVVlQzhUc1VPNXZNQnBDN3lDOUNtbHhSMGxUZWZvaDlxZXp0d2JuZEpI?=
 =?utf-8?B?VHEyaTFiaGZYaVJybHUyZE9MbHFZeEtaVVE3QUJJZE5MRG9vY1JkNkhzbk9i?=
 =?utf-8?B?bGZzN3hkWTVhSHVPUU1HWHd2ZU9Vb0ZidDFYVkUrdFQ1VFpNQ3FBSG5WUC9N?=
 =?utf-8?B?cWpiNlR4WjFJUEJnZW5kSnpEMThDZkg0NUhGQ2s4MFB1TGpEVUFFa0t6OTBM?=
 =?utf-8?B?UmM0emRHZmkzRWxHTi9LV3pqbUQ5Zm55NDlqMDFPSElaaHAxWGhKYmxGakov?=
 =?utf-8?B?OHRka2Z5T3NlbWIxNU5rSFJzYkREVHpDaWlIN0ZreVlvQ1pBclhoR2haTmtl?=
 =?utf-8?B?NmNIR1pEVHg0blRRakQ4Q0E4SkpnYkFLN05yVFZkZHdad1FTbmR2U1lDcENP?=
 =?utf-8?B?cHFkclRNK1pFeG1vUDVRZ0F1REo5VWtvQTdvejY0OUpnQ0VZZzdKWWx4ZXJH?=
 =?utf-8?B?VGpwOEdRaTVueTZHaDdoTDBCVWNRQ3c0TEVvWnIybENWWHJsdi9kdForUUdL?=
 =?utf-8?B?QUlCcStqMmNZRi9IZ2NJMk5RNDBhR0VSaHJpek1TQUJQckxBcW1HY2I2R0lD?=
 =?utf-8?B?VExBZTNKOEFkS0FBU09RTDY1VUM2SGdZekh6UFdaTzN5VjM3ZHIrYThEa0M2?=
 =?utf-8?B?NU8wYStEbVcweHlGUEZMOERlMGNpTU9YZm5lQ2oxWVRrVlVWYkpFS0x4cHFQ?=
 =?utf-8?B?em54MGdoZ2Z0NlczZHIzN2drRzZwa1FraWVuNWRrUFFNNzRRTklMblpuNEN0?=
 =?utf-8?B?VzJUYjJSSHkwbU5VQWE3anZsSUlHbk5OMTA3Q21CWWRFenRIdnN4NjJFbCtO?=
 =?utf-8?B?YVFGUzNTS0c2cjlUWUhEc2NLK1BlenduWnltREJ4YUw3Z1dKaW5lQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5867052d-78a8-4c79-ff84-08da26988557
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:49:34.1148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zGbaCPizxzDZ0HEp1BKjm5QzQljYq/gwrPCjq8NG2pZ9KG0A44SOz2Ng8VYO0szfx9sh20G7gIISGPDRqdw7zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2254

The reference "to shadow the resident processes" is applicable to
domains (potentially) running in shadow mode only. Adjust the
calculations accordingly. This, however, requires further parameters.
Since the original function is deprecated anyway, and since it can't be
changed (for being part of a stable ABI), introduce a new (internal
only) function, with the deprecated one simply becoming a wrapper.

In dom0_paging_pages() also take the opportunity and stop open-coding
DIV_ROUND_UP().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Introduce libxl__get_required_paging_memory().

--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1017,7 +1017,7 @@ static bool ok_to_default_memkb_in_creat
      * The result is that the behaviour with old callers is the same
      * as in 4.13: no additional memory is allocated for shadow and
      * iommu (unless the caller set shadow_memkb, eg from a call to
-     * libxl_get_required_shadow_memory).
+     * libxl__get_required_paging_memory).
      */
     return !CTX->libxl_domain_need_memory_0x041200_called ||
             CTX->libxl_domain_need_memory_called;
@@ -1027,6 +1027,24 @@ static bool ok_to_default_memkb_in_creat
      */
 }
 
+unsigned long libxl__get_required_paging_memory(unsigned long maxmem_kb,
+                                                unsigned int smp_cpus,
+                                                libxl_domain_type type,
+                                                bool hap)
+{
+    /*
+     * 256 pages (1MB) per vcpu,
+     * plus 1 page per MiB of RAM for the P2M map (for non-PV guests),
+     * plus 1 page per MiB of RAM to shadow the resident processes (for shadow
+     * mode guests).
+     * This is higher than the minimum that Xen would allocate if no value
+     * were given (but the Xen minimum is for safety, not performance).
+     */
+    return 4 * (256 * smp_cpus +
+                ((type != LIBXL_DOMAIN_TYPE_PV) + !hap) *
+                (maxmem_kb / 1024));
+}
+
 static unsigned long libxl__get_required_iommu_memory(unsigned long maxmem_kb)
 {
     unsigned long iommu_pages = 0, mem_pages = maxmem_kb / 4;
@@ -1194,10 +1212,16 @@ int libxl__domain_config_setdefault(libx
     }
 
     if (d_config->b_info.shadow_memkb == LIBXL_MEMKB_DEFAULT
-        && ok_to_default_memkb_in_create(gc))
+        && ok_to_default_memkb_in_create(gc)) {
+        bool hap = d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
+                   libxl_defbool_val(d_config->c_info.hap);
+
         d_config->b_info.shadow_memkb =
-            libxl_get_required_shadow_memory(d_config->b_info.max_memkb,
-                                             d_config->b_info.max_vcpus);
+            libxl__get_required_paging_memory(d_config->b_info.max_memkb,
+                                              d_config->b_info.max_vcpus,
+                                              d_config->c_info.type,
+                                              hap);
+    }
 
     /* No IOMMU reservation is needed if passthrough mode is not 'sync_pt' */
     if (d_config->b_info.iommu_memkb == LIBXL_MEMKB_DEFAULT
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -1569,6 +1569,11 @@ _hidden int libxl__domain_need_memory_ca
                                       libxl_domain_build_info *b_info,
                                       uint64_t *need_memkb);
 
+_hidden unsigned long libxl__get_required_paging_memory(unsigned long maxmem_kb,
+                                                        unsigned int smp_cpus,
+                                                        libxl_domain_type type,
+                                                        bool hap);
+
 _hidden const char *libxl__device_nic_devname(libxl__gc *gc,
                                               uint32_t domid,
                                               uint32_t devid,
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -38,13 +38,8 @@ char *libxl_basename(const char *name)
 
 unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb, unsigned int smp_cpus)
 {
-    /* 256 pages (1MB) per vcpu,
-       plus 1 page per MiB of RAM for the P2M map,
-       plus 1 page per MiB of RAM to shadow the resident processes.
-       This is higher than the minimum that Xen would allocate if no value
-       were given (but the Xen minimum is for safety, not performance).
-     */
-    return 4 * (256 * smp_cpus + 2 * (maxmem_kb / 1024));
+    return libxl__get_required_paging_memory(maxmem_kb, smp_cpus,
+                                             LIBXL_DOMAIN_TYPE_INVALID, false);
 }
 
 char *libxl_domid_to_name(libxl_ctx *ctx, uint32_t domid)
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -317,9 +317,12 @@ unsigned long __init dom0_paging_pages(c
     /* Copied from: libxl_get_required_shadow_memory() */
     unsigned long memkb = nr_pages * (PAGE_SIZE / 1024);
 
-    memkb = 4 * (256 * d->max_vcpus + 2 * (memkb / 1024));
+    memkb = 4 * (256 * d->max_vcpus +
+                 (paging_mode_enabled(d) +
+                  (opt_dom0_shadow || opt_pv_l1tf_hwdom)) *
+                 (memkb / 1024));
 
-    return ((memkb + 1023) / 1024) << (20 - PAGE_SHIFT);
+    return DIV_ROUND_UP(memkb, 1024) << (20 - PAGE_SHIFT);
 }
 
 



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:51:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:51:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312614.529951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuRi-0001wS-Os; Mon, 25 Apr 2022 08:51:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312614.529951; Mon, 25 Apr 2022 08:51:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuRi-0001wL-Ld; Mon, 25 Apr 2022 08:51:50 +0000
Received: by outflank-mailman (input) for mailman id 312614;
 Mon, 25 Apr 2022 08:51:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuIX-0003e7-Mc
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:42:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ed68a8e-c473-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 10:42:20 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-0CaPfVyuOMuCq0QkgcbLoA-1; Mon, 25 Apr 2022 10:42:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB6891.eurprd04.prod.outlook.com (2603:10a6:10:112::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:42:18 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:42:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ed68a8e-c473-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876140;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mS9j+KCKEN6hv0oR924WDhW3Lh9+MjR+9IlswbKwkL8=;
	b=I76/w8DGOZpgW35SScLZK8Mfh3oq3E5u84hjo3ndSjfDTWyL3P4rbqlbB/25bWPxIsEIyK
	+wtbtZZJE6qemVuJtRFhAhzUwfo31vQjAsxcwBVAwI3bN6/bkzkIZoerO4uNbKAcTxw/G9
	EGzw/qpATgJ/6PBlcdpqTy2Nl4czJpY=
X-MC-Unique: 0CaPfVyuOMuCq0QkgcbLoA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SRUjh57B/BFkSVqND4gx+M5oyLYLIjTb2ioq0JI2nOKfFKrDlC2fcypIHjbzwpogWZFibaVtm0Aj2VMyKG0kYReO4PqjH4xIpXS1qAJReuqlnU1NuJlhHb3XxPXMyk/7u1UcTBE8nv7y14Ei9KUnHRnM+FgVm6cguFicahET4e68zmW4ylxmbNN9mSiToqBNCImRsQidj0DoU4nrH7nHGfeUJI1aPam+fZaghqrfwV4mHAaWBmMXGEM3n61O0CeZM/KI/svS6hFyjj91+d96Z+ryr6i9fw0gRPd/UpY67xNbVtI7ZzXzQk+hsjBwO88hhQYocsjBMgcjN0JFnX8eRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mS9j+KCKEN6hv0oR924WDhW3Lh9+MjR+9IlswbKwkL8=;
 b=HS8FiBEfGvy5bXFfl5ZZJw0pwmK+B1s2/2a781d+5SFuBRlK/KfPFlx9nlRms3xVIYYpb6dR/dUnjivS3JcXy0IaAn2OJXIIRZr8kd2jJgBwxmJBdj6T+1VVXknqpZYLuqBHPgZ09qvOKQTKEmKQTjOWAO466TJk35T9e+33Dt8vDvi1I2iAdu1TKO1rA8WoKMQleikUZeMatUuTdHTZiMBX+qoShmclds+MiJcNmRBodWgiDlcumpv3t6sGA+hq+at2V3AdpLihoG0t40UCrPhJ4OgijXwX9Bcw2iVzZ54HZFFB0rD/4pU3eybiJqWBWPESWJomArl0nzg7tHS8Nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <16f5b398-56f6-a70c-9ce0-0ad72eab5058@suse.com>
Date: Mon, 25 Apr 2022 10:42:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 15/21] AMD/IOMMU: free all-empty page tables
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0046.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f3b9e395-2f89-4334-3add-08da26978160
X-MS-TrafficTypeDiagnostic: DB8PR04MB6891:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6891EBD1A6FDA195D75C34A9B3F89@DB8PR04MB6891.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	I0gBddgZfz9sq6a4pIpAEnA7XSRVz2ByjpF0e5hz/z57IZ6KtRO6xJsoSySDSDhotybWUy9goPbPUQfJfCl47A7oFtyR84Z/FnouxFNDF/jR72MgR/D1JewmLds6CR8iFx6anCp/UXUi5GztMbOBZTVfd9fa6FMdof44zIPpZCsZ+xgG4nml0AZstfxrFKZfpnf6xqYpgPPTTa87+8KZd0CUaFQaNYkaEbqE/tdirqb8+k2FsH9Xce7YJw6l4nWwaKeejLWW0PKDm4Pf83lhXP0lwcoFniHxJk4yY8HwUXrvHp7/a1B9Zzhhj53n+PCAusdRj0YZZA2eYv1xUU6wScm0VoFh3ViR7S11cbXlwURFQ8hd75Mzdo+rspWljYqz/DINMEuvV+Tr5sMkWC0qxq4QipBBaYSdON2zdLdXNJH18xIEaQgyiiDbTA7zdYBdthslmblMqBnvyXxI/3UHW2Bx4rb4puYRtAtuUkG5PVOTD1zoyuPBFto1NT8dUNBtlBhnPy2umwpq5ScL3DoNr9T4oFnt7zxyXGCJkCgP5zT7li9PhOgGp9GovU+4L+dq+GuHt6zsuWbGkS6ZlVsxwC5OpilNKODOHzgMLyWaqtwGc0GgrNVDZLYYouPxFuX3SbO2s2GJthEJSIqMG9vvWoTmiR3RILNQ/bb7y6VVrb8+jELrA0TFCB0RO8KdHw/vrZUVC3bMEzAfjlJ29c1SqA+whRKM9GRZrf1WLZXa00g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(26005)(66946007)(6512007)(38100700002)(508600001)(66476007)(316002)(6506007)(83380400001)(54906003)(6486002)(186003)(6916009)(86362001)(31696002)(2616005)(2906002)(5660300002)(31686004)(8936002)(36756003)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YTlSbnowbmNDTmhYRkMzUElGRFc2YVN3cjdBdUpMVWdPY0ZPZDJ6WFBSeU5H?=
 =?utf-8?B?U3JNMWJMZkdmWWZTMk5wZUdLTDBxUWtVMXg4c3dyekNuYzlabW5jdk45ZUs5?=
 =?utf-8?B?T2hLSjBvTElyMyt2MzgvZG56Y0JBTHZTSXBmV3dCMDdQMStzYUxiUm9ydmxV?=
 =?utf-8?B?cmRYNEtPRVlReHBBTjFpZHFMM244Zi9EUytEQWNrWURudU8yS1RkdDZubE9X?=
 =?utf-8?B?OW0wWjhvbTBMT01lVjRVU0wvQjVVS0hSdkllT0dzSlZHODVJZzdPeGpOTjRI?=
 =?utf-8?B?bHNVTk9ianFVaFYyWVdraFRWRWJpYnJlWW5vaks2T1pmaTZWc0YvNlIyMjc0?=
 =?utf-8?B?aS8ybGpDaXZFalI1U081WDhkdEMxRWhhNkxOTzIwblBFaFBmTCs5NkI1L0RO?=
 =?utf-8?B?MkZNMWZsMGhRMkZGbjBDZlFaYkRFMGJtVXBYa1gxNDFBeGRPZWV0V25GRThC?=
 =?utf-8?B?bjFHT0kwRTlJWWpWVVNtdkl6RmJRZzV5T2JGMnk1M0kxblMyUXhxWVRiR2wy?=
 =?utf-8?B?bzZSOHJ0R1ZuMjI3K0E1T3lOb2laNnZZcXE5N3pjbFdubDRMbjRlYlFVMWtK?=
 =?utf-8?B?ZExjdkpvUXZFeDBTc1MrRHBsSlM0OVhUR1ptYmhEQU5IenVuZEZDcHNMZUNP?=
 =?utf-8?B?c3VkWXIwUjhTamFjZWhLZ3VyUlgyK0k5NzM1OXhCZFFOMmp6RVhrQmllMHRu?=
 =?utf-8?B?MEN5dTJQbFpqZ253VlR4bEJNdkt3dDlMRWxNUTdFRUpuaCs3bnVQMkZxTEVo?=
 =?utf-8?B?NFNHY3FoMFhNOUhkV1ZDVnFUZmZ2eFF0NmhWcG1xd0pucHZSZG5pSTgvQXBS?=
 =?utf-8?B?UC9WVHppdlRQMlhucXFTSjZDNm41TytnSEpycHgyRDExcmlmY0ZBTkN4L1lz?=
 =?utf-8?B?QUtSL291MlpvQ3RtQnR6bTUxSFM4Wk9Ebm5aVVlMQkNCM21GcUY2aVFMRktN?=
 =?utf-8?B?UmRVOFE4aUZ2aElQY3pGejdYL3VWVWZiWHlEcHArbmdPTkFZc3RBM09aQXgw?=
 =?utf-8?B?ZlczSGo0TmxpMDBPNXV0aWY5eVh3QUZMWVVtTUJxRlZXbG5wWkJuOFdmSUh6?=
 =?utf-8?B?UE95dDI2S1Jlam1MekREemJITWx0UHBscmMyejNRL2FEZUxNQVRQV25uY25U?=
 =?utf-8?B?Smp2L1NRZUUzZkJlK295enEvOGZBSHRpZ2NrTHVyMGdBRyt3WUNudklCT01m?=
 =?utf-8?B?c3dhYW1hSGVRQnFPdmcrZEJCMEZPK2tLN0ZZRmRnTXgvM3lFWmpPdDU4UHBY?=
 =?utf-8?B?NWtyMklpWTc5TDJOZmhyN3JEdkZmL3J4T1krQSsyajkxUkNmak1QMm52OWdT?=
 =?utf-8?B?bjFyVWNqakVzMFdCSWx4NmQxZVhBTDRYOTU5T0I2ZDJya0RucncxYkNGelhE?=
 =?utf-8?B?T3p2WEhUWXR1QzBYRG1BeXBSVEQzckpSb2cwVEVFT2JqdVdWYno1d29xWlo4?=
 =?utf-8?B?OGkvT0hES2tUYkdVOFNUcjZ6NUhLcmttVVpYNlFpY3Y3U2NxZ0d5dDk0YVJr?=
 =?utf-8?B?SkFpQ1RqL2FJR0pqd3lDc0dIY2t0Z2UzWmoweVVmTHdXbDNTbEdOa0ZLNlg4?=
 =?utf-8?B?VjcvdDlKdnEyVHF5RUQ1U3pjT09PcVJYNVVVWStncmo1cnlXM05UQzFWSGZX?=
 =?utf-8?B?d01uSi93ZWZOWDJBQkFuWER6QWpHZWtuczdGaU5QTDdZQ0p1c2ZMeWRUbE8y?=
 =?utf-8?B?cjI0cEcyMjE0cFZXb0NsNGpQbXZmbWt4aUJYODgzTEp3aVNka0o5MEN1ZDlo?=
 =?utf-8?B?OEFXMW9tVXp5WEF5Sm93Y1k5S0tBUFUwZC94UHVwTjA1VVBCNTBhaEpXeGNW?=
 =?utf-8?B?cHhtKzkvVHZyeEhQRjNuSG1CcjBtbTI2THZhUzJWK0lMOUx3VWg2a01UOUZJ?=
 =?utf-8?B?K0NSQllvblYrbXRvM1d6SzZUQmdodnZESmtFalZqaU95QmhJK0d1VTNMVlB2?=
 =?utf-8?B?UVQ5eS90UHBrbHMrbWxqellOU1NvaTRaTkdFTy9FelpWTWxiMWMvRmdZQnBx?=
 =?utf-8?B?WFFORFJ1NXJweWQwY200cm5lVkVJR3R4ekkwcno4bzhUeCtRTmw0c0dndW5C?=
 =?utf-8?B?WUV1cGY3bkI5Zm9Xc0twS0w4aUgwQi9rcWJxTk9MTXpiMkhOcEh2UUFPMnQ1?=
 =?utf-8?B?M2hTenM0YldXL2tFTW55OW1GeW5mT0tNZDh0WDBRa3AwQ0ZuMGE5cDd3MnF0?=
 =?utf-8?B?NnhrYkpod0hzUlBncGNPUW0wSXo0bENiZjk1M1pOajF3MTY4a25IYitxZlZW?=
 =?utf-8?B?TmQzdDN0YlhiSzA4WU0wbGo2WVBrT1pNWGxUZWVrSjhuNHd1NVZJWXRjZGJO?=
 =?utf-8?B?VGxsVUQrd0hGNUExcjJnbktDY2hBSmZKVTQzQ0kxUEdhMk81ajhXUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3b9e395-2f89-4334-3add-08da26978160
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:42:17.9624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ckv8qioaFNZ4ZHa0ocqeNtfYSlenojKy/sQjR16M66MjYgxEcIqLVoMJWYNO4mVpbqd2BZSFVp1uDjSRcmY3iQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6891

When a page table ends up with no present entries left, it can be
replaced by a non-present entry at the next higher level. The page table
itself can then be scheduled for freeing.

Note that while its output isn't used there yet,
pt_update_contig_markers() right away needs to be called in all places
where entries get updated, not just the one where entries get cleared.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v4: Re-base over changes earlier in the series.
v3: Re-base over changes earlier in the series.
v2: New.

--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -21,6 +21,9 @@
 
 #include "iommu.h"
 
+#define CONTIG_MASK IOMMU_PTE_CONTIG_MASK
+#include <asm/pt-contig-markers.h>
+
 /* Given pfn and page table level, return pde index */
 static unsigned int pfn_to_pde_idx(unsigned long pfn, unsigned int level)
 {
@@ -33,16 +36,20 @@ static unsigned int pfn_to_pde_idx(unsig
 
 static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn,
                                                    unsigned long dfn,
-                                                   unsigned int level)
+                                                   unsigned int level,
+                                                   bool *free)
 {
     union amd_iommu_pte *table, *pte, old;
+    unsigned int idx = pfn_to_pde_idx(dfn, level);
 
     table = map_domain_page(_mfn(l1_mfn));
-    pte = &table[pfn_to_pde_idx(dfn, level)];
+    pte = &table[idx];
     old = *pte;
 
     write_atomic(&pte->raw, 0);
 
+    *free = pt_update_contig_markers(&table->raw, idx, level, PTE_kind_null);
+
     unmap_domain_page(table);
 
     return old;
@@ -85,7 +92,11 @@ static union amd_iommu_pte set_iommu_pte
     if ( !old.pr || old.next_level ||
          old.mfn != next_mfn ||
          old.iw != iw || old.ir != ir )
+    {
         set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
+        pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level),
+                                 level, PTE_kind_leaf);
+    }
     else
         old.pr = false; /* signal "no change" to the caller */
 
@@ -322,6 +333,9 @@ static int iommu_pde_from_dfn(struct dom
             smp_wmb();
             set_iommu_pde_present(pde, next_table_mfn, next_level, true,
                                   true);
+            pt_update_contig_markers(&next_table_vaddr->raw,
+                                     pfn_to_pde_idx(dfn, level),
+                                     level, PTE_kind_table);
 
             *flush_flags |= IOMMU_FLUSHF_modified;
         }
@@ -347,6 +361,9 @@ static int iommu_pde_from_dfn(struct dom
                 next_table_mfn = mfn_x(page_to_mfn(table));
                 set_iommu_pde_present(pde, next_table_mfn, next_level, true,
                                       true);
+                pt_update_contig_markers(&next_table_vaddr->raw,
+                                         pfn_to_pde_idx(dfn, level),
+                                         level, PTE_kind_table);
             }
             else /* should never reach here */
             {
@@ -474,8 +491,24 @@ int cf_check amd_iommu_unmap_page(
 
     if ( pt_mfn )
     {
+        bool free;
+
         /* Mark PTE as 'page not present'. */
-        old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level);
+        old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free);
+
+        while ( unlikely(free) && ++level < hd->arch.amd.paging_mode )
+        {
+            struct page_info *pg = mfn_to_page(_mfn(pt_mfn));
+
+            if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn,
+                                    flush_flags, false) )
+                BUG();
+            BUG_ON(!pt_mfn);
+
+            clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free);
+            *flush_flags |= IOMMU_FLUSHF_all;
+            iommu_queue_free_pgtable(hd, pg);
+        }
     }
 
     spin_unlock(&hd->arch.mapping_lock);



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 08:52:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 08:52:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312621.529962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuS6-0002Wk-2e; Mon, 25 Apr 2022 08:52:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312621.529962; Mon, 25 Apr 2022 08:52:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuS5-0002Wb-Uq; Mon, 25 Apr 2022 08:52:13 +0000
Received: by outflank-mailman (input) for mailman id 312621;
 Mon, 25 Apr 2022 08:52:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niuKN-0005as-UA
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:44:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e2a41c9e-c473-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 10:44:14 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-K12lP_fTMSycn3GH1ByPbg-1; Mon, 25 Apr 2022 10:44:11 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5736.eurprd04.prod.outlook.com (2603:10a6:20b:a8::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 08:44:10 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 08:44:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2a41c9e-c473-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650876254;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Zlfuedf2q4YXfgbpQ1MWK6FkdjlHZbNpmqaza4t7ui0=;
	b=ZqC6XIIk0MO9pqRpiZnKWC4KSX4zb7ptRtfPjJKkB+4+PWgM1PTdSjAzBAqiPAJSIB0FQ0
	4yvio6tmaohuD4Zy2SNbPruBFyXEqP6KrGMYliZGzDHm1M4PinqeB7ku3hiIDvEsZ3V8Xv
	6cvk5SQdcqjGn8l/p3Udiehc2iJVmIM=
X-MC-Unique: K12lP_fTMSycn3GH1ByPbg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PiH9++EK85PyX3TRC6isqEvNAa5XVolEvvmHWXnptDiTS1v9VzfUzNfQnH+UY5IOIn3CuoQbdhMzVBr+Cvk92DvGvjgYD723kjRYw4813rlAHveluyz9owTP5ZK9wpcGQFtE92xgvZ7TorU/XyYrlT3sSmqsmh4fNoy9ichJcnmvZZWcF75RApPFBZZvT/5/CenULZL/6qROR2wMJ3sV6Fs+FCh1uRotFnn6e5R0gzeYDMoEkalonLR2vuPvko0IbKnwiwnMBLW2UyefsYwzB2FXjMpPDh92dWXWLxrfSdKdXmHWn2FaQivZ/S06VdvYyFowFf/yTsUzr5qeKKrcog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zlfuedf2q4YXfgbpQ1MWK6FkdjlHZbNpmqaza4t7ui0=;
 b=fRR/fjHaKZvyftUmmyoxpGxqm0f7bBjHCOaE4R5nWWaR3AuNFlfbO3/2Luf4mSlAwVUYPRRG2ck+0vdPllauErqFP4f0wYwbZWYWYUenQyF3FfqyxbfCcGBN+xD3oYHUKTCxb/3fHEcRSQwkNdHibjUdOMkpsNBlldgyeNHfTcd4/qOlbjbU6XLjqejG+hcfNkjEXL7r9Oo2TjKgKmAJ6mxIm0wQEYLXpGYvv7vWciPNSQhpcfDJZLQfYwpvqTh0dHaMwfEYxL4PPrnEO5sRqp9bQRE5SXeVlDQSBMwyaEOKbrwayG5nBA5eVSDh51fCR2jY5h25w+MhtMAEdfavqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cd077dac-c53c-3369-03db-f2e4260ee94f@suse.com>
Date: Mon, 25 Apr 2022 10:44:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v4 19/21] IOMMU/x86: add perf counters for page table
 splitting / coalescing
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
In-Reply-To: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0071.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 312f22fd-5081-46bf-c97b-08da2697c446
X-MS-TrafficTypeDiagnostic: AM6PR04MB5736:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5736BC88E927256F00D6EE98B3F89@AM6PR04MB5736.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rR0LqJokPUj3LZ21D+k1gdv+6H/uRaLBQ/QkXNTEBMSch/Pho5Tl4jyPYHWOIpuoeT/hZmdHE1ZIt4klNhcq95rp7i3PDo80X+SfxQuJcUJ9uQ3Z4rXvTfUeCZ4n/MDLYNOturgTKri4MUg3xp5tv+Av9cDpF8Xg7wstLEhXWDGu3SywURFgOWzTyabEsMpBiW2H7sr832oNJO+z48ETDrkqiuAv+tfuRPQ80FSH8Brs50FHlKtgxx2GgI6KafGMvw9dgtiKxfqX8P2fYj1k9pP7yWsXkKAHuDDMFpyssolZCWcNCC+HLWFQtSTJViN1//XYIoqKokfhlpknISXO8dYXGLPZcmz+jmh7y6hjynfJvRR2e92uBMCkPf56NxJOl7eHBCq+7GmHQDl/TeQq7WZM4u1GjNt+j6+iPU56M2Tm3GYBkPHa2tnRytvG9kAAD5Hp7Un9HHRJo51vvusUkG8v7K7/CPXbWmuliEX31KHePM0mqiBONf9kiVakUG6aM6cK5HsFmQedSNLjtfdB6Dkv5naxMBjtXNMDtAELxGaUI/OXb610q9Hi+J4BZDZANot/c4wdqZRLtqosd+Y5jhaA8dMmOPHzzsaDvyk2Kq/B2HIkW1Tx91Gr4Fs7Bn93N7ETe4Otrbxrq6IA7sRTDfxha12bUHV3SeSGuOGZc4xJBeua4U8jOec0IoFtDBBQ1tGhWtYbJ4KKp0XlsSqpdpZHGnAfzi3p+Yye8JjA2Lg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6916009)(8936002)(6512007)(31686004)(83380400001)(26005)(316002)(5660300002)(36756003)(6506007)(186003)(2616005)(2906002)(508600001)(86362001)(31696002)(38100700002)(6486002)(66556008)(8676002)(4326008)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cmNuTlgyZnpycjFkT3VuMkdLa1pEc0ZDaUpPZEZyK2xUaTJsTmxnUUtETVRj?=
 =?utf-8?B?Rk9zZ3ViNXBnYTVwQlRnaHgrYWh2QzdOMTlRYmdVSFZtZkYyREtyNWdTNUQ2?=
 =?utf-8?B?QkdXM0pydk1XOExJTnQyUk5KYW9XNUdaYWZFYmRmdFFSZWl5c0dxYTQ4ZU9m?=
 =?utf-8?B?eFFuakFFRGhNMjd5aVByMFBkZVhPeUloNVFoZWpseXkxMGZxUXdVSWNNcjZp?=
 =?utf-8?B?YmoxbU5Xd2ozQ2c0OGxGdTBxUmxrY0QzYWVHcncrNVJwRDlNT0Y5UFJhOFRT?=
 =?utf-8?B?T2FJbTdVSE16aW9nRFpjWFhXdWFTWGZCVjNWOGVSbUhuZFlsRjAxeldKYUpM?=
 =?utf-8?B?K204ZWVOQzY0cEF4K0FRcURZZFhCZjJCd0psN2lpdzljNklhemxnQUNoeGpv?=
 =?utf-8?B?OVZHVzVhMXNCbUZYYU1KTGRIY2tvbi9ZMXMzYXFRU2REclNlN202NWNhbWNl?=
 =?utf-8?B?azlyTFJiT3hud0VYZUYvYTVkL3pKY1dtbDUvTU9HTGRTMzhndVhtcjQ2Yldi?=
 =?utf-8?B?Z2dRTXk3b3p1SG1Td0FVQ3pLZlk2OTdkUXd3dEFPZlEyUXU3bzNwQnVWRVBF?=
 =?utf-8?B?Zm1oT2kyTEhzQVlNeXowWFhmcHV2b3FJS3NRTmRpeXg5WlJNWUtXYVJmdWg2?=
 =?utf-8?B?ak15RU5ON3FvQnoySm5vQzZUYUttNnJHZ21YR1ljMkdwb3pyQlZGWjQ4MHk4?=
 =?utf-8?B?NUVOTEdjQzhJbk1kM0xwRFRRL2Y4Zm1KeCtyMGs1MEVEcTNjRHNyaWYvY3o4?=
 =?utf-8?B?SXQyalo5WFl4L3MyQ0l0OElJTkZkZHJZOFVnZUd3ZVBNWjVqSnBZb3VNbWJh?=
 =?utf-8?B?UmNHRW41NllFZDVFM1FzYnpJMXc3L1lLVnROMG5Mc2ZKcjZDYTFFeUNQSHNP?=
 =?utf-8?B?MHpPc1pYNVhuZEtnVWtRRGtqcGdzbUFybHFQNWUyRk5jQXFON3J0TnNoWFdI?=
 =?utf-8?B?NDJadlpTZ0tGeldhRWlEWU1USllQb0Z2QTB6c3FWU0Fwc0Q4U0h1MXUzYWN1?=
 =?utf-8?B?bmpiOHNOMHpzRTBxNWYwSGxBQ1NkNWVoL3ZoL054WEdKZnY4OVJJVkJKbmVk?=
 =?utf-8?B?a1o1WnF3R1JEc25VZld5YlNPSFRML08yb2dSV3VWNER2LzZ2a0hOTHpMSTc2?=
 =?utf-8?B?NlZTTXVRbVVpTzJnSkd1YnU4bWpYYUkvNVpOajk1YXFVd0hFM05SOGlUckdK?=
 =?utf-8?B?LytZN3BLUitsNUFvakk2Qi96eFdXdldRNUxBdHhwckR4alBza2cvbWpiam1a?=
 =?utf-8?B?RHVuZDlwOHJZSUdQMlNhOU54eFNIVXdWQTBkbG9OTGh3c1ovajVHRmpxclBt?=
 =?utf-8?B?cVJHNXEzS2lDbkw5M2pBVDMyWW1XQk5ZeXUyakZ4MzZjTlhOUGdiRkZ2WU1Z?=
 =?utf-8?B?OFR2WmFCOXBLRis3OGtoY3FYNVI1bkEzZU5BK0hueWlGNjIrMFdXVDIxTll0?=
 =?utf-8?B?aUVlOFFObSsxTUdmM1hUWEtLTU0relV0bmw1ay9GQW56enppMnpVRHMvb0lV?=
 =?utf-8?B?VzVEanltRDRwUndNTEhRUURhK3J2RXRub1h1RzFkaHJWSk9sTkF4Z2NYMUxu?=
 =?utf-8?B?KzBYU2ZLVFFka0hZVk1hZS9uK1Jpa3FTREZ3YmtJbVBmaEQwOHVlcnpLTlQx?=
 =?utf-8?B?Q25zZVBES3BDOGFpUlNITUtQS1p2T0VtL1FRMk1IREtpaGVRRk5ScmluTTll?=
 =?utf-8?B?azV5QVJsWFF3Z1JvOGRHdm11SnZXeCs3QW0xNmRhdzluL1JrRFVuRmdDVWVV?=
 =?utf-8?B?bTFWWVR3c2ltd3RTbWpCR1ZWaWpERDhHd1ZNS0FGQWxlLytvbG8vb1BZZSs5?=
 =?utf-8?B?RTVGUUxYWG10bjhEckVLNmpLelpJMWpjK2dZaFRNUVpQVGMrUFRVQkRzYVlE?=
 =?utf-8?B?QlUwZi9nRlE0Y0V0TDlrK1gvU0xNQTNpbnZQMGJadDcvVmxXakFGcUdOMkFZ?=
 =?utf-8?B?clB5VHdFejliUzU5K1ZjZVFYUzJoeDIvWlBJYXluVy9FM1Q4cW52bDhNbnV4?=
 =?utf-8?B?dzFXa25POFkvSHRsS1ZJQ1J3eVA1NW4yYjIwMTlqMlhvOXp4Q3dkV0dxVE5M?=
 =?utf-8?B?dnRZRmJMSmhUMmNYbnZaSWJJaUVWYTgzUFFFOTduYUh2azZxa043VWJkSmNn?=
 =?utf-8?B?T2FoanM1ZlA0SlpiWUg4OUVMaUR5T1YxOUpURFI3aGYvTDE1NlY3QUg5SUl2?=
 =?utf-8?B?SkpSam5rYy9PL3ZoR01DenJMaEp6eE82Q0V4MmNBNWloZDRSK2VIVjF2Z0hm?=
 =?utf-8?B?NUt2MlBNT1poL3gxZFRnNDg5NVA5cXNIR0FTVzZwTlNRcmtMM1BwOW82UVFF?=
 =?utf-8?B?WVNkZlI5cURaOEdIQ1NqS3pGL2pmS0RKR3RpNW5uVzdtOTRKeUVJdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 312f22fd-5081-46bf-c97b-08da2697c446
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:44:10.2342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wmGHL2u8w04+ko7s6OOlm/kavCHzUpHAjWSk1g4TDrkMbTQdl7w5p9EBiQ2EPgvktGMS0MuoVV9CqrMc0LoXsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5736

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Kevin tian <kevin.tian@intel.com>
---
v3: New.

--- a/xen/arch/x86/include/asm/perfc_defn.h
+++ b/xen/arch/x86/include/asm/perfc_defn.h
@@ -125,4 +125,7 @@ PERFCOUNTER(realmode_exits,      "vmexit
 
 PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection")
 
+PERFCOUNTER(iommu_pt_shatters,    "IOMMU page table shatters")
+PERFCOUNTER(iommu_pt_coalesces,   "IOMMU page table coalesces")
+
 /*#endif*/ /* __XEN_PERFC_DEFN_H__ */
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -343,6 +343,8 @@ static int iommu_pde_from_dfn(struct dom
                                      level, PTE_kind_table);
 
             *flush_flags |= IOMMU_FLUSHF_modified;
+
+            perfc_incr(iommu_pt_shatters);
         }
 
         /* Install lower level page table for non-present entries */
@@ -472,6 +474,7 @@ int cf_check amd_iommu_map_page(
                               flags & IOMMUF_readable, &contig);
         *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all;
         iommu_queue_free_pgtable(hd, pg);
+        perfc_incr(iommu_pt_coalesces);
     }
 
     spin_unlock(&hd->arch.mapping_lock);
@@ -532,6 +535,7 @@ int cf_check amd_iommu_unmap_page(
             clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free);
             *flush_flags |= IOMMU_FLUSHF_all;
             iommu_queue_free_pgtable(hd, pg);
+            perfc_incr(iommu_pt_coalesces);
         }
     }
 
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -404,6 +404,8 @@ static uint64_t addr_to_dma_page_maddr(s
 
                 if ( flush_flags )
                     *flush_flags |= IOMMU_FLUSHF_modified;
+
+                perfc_incr(iommu_pt_shatters);
             }
 
             write_atomic(&pte->val, new_pte.val);
@@ -865,6 +867,7 @@ static int dma_pte_clear_one(struct doma
 
         *flush_flags |= IOMMU_FLUSHF_all;
         iommu_queue_free_pgtable(hd, pg);
+        perfc_incr(iommu_pt_coalesces);
     }
 
     spin_unlock(&hd->arch.mapping_lock);
@@ -2244,6 +2247,7 @@ static int __must_check cf_check intel_i
 
         *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all;
         iommu_queue_free_pgtable(hd, pg);
+        perfc_incr(iommu_pt_coalesces);
     }
 
     spin_unlock(&hd->arch.mapping_lock);



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 09:12:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 09:12:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312631.529973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niulx-0005OM-P3; Mon, 25 Apr 2022 09:12:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312631.529973; Mon, 25 Apr 2022 09:12:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niulx-0005OF-Kb; Mon, 25 Apr 2022 09:12:45 +0000
Received: by outflank-mailman (input) for mailman id 312631;
 Mon, 25 Apr 2022 09:12:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niulv-0005O5-UL; Mon, 25 Apr 2022 09:12:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niulv-0007ms-Rm; Mon, 25 Apr 2022 09:12:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niulv-0002lr-E1; Mon, 25 Apr 2022 09:12:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niulv-00009K-DY; Mon, 25 Apr 2022 09:12:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bODBtSUh7VLCW52jSYkDYeFmRHpV+AE5gonSjIwzIT8=; b=WcEEdC0LeouR0yVEvEIy3bQ38f
	RamyF619vDB6TkM6Lk4QYhusbM78Dk4grZeWvqq6E1/GOvCtfWmzd5dECkhmAdvWgeCoZs02D7JSS
	x81NwwsJsrrCcTz4wZ1308+0NaHFMUA9OfYIOR9iRKqf44YF/5cPv25t3jlwuFrWXFW4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169700-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169700: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=96e1d337e0109d970282de71181a5cc317876829
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 09:12:43 +0000

flight 169700 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169700/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 96e1d337e0109d970282de71181a5cc317876829
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  613 attempts
Testing same since   169631  2022-04-22 21:40:32 Z    2 days   55 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5735 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 09:14:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 09:14:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312640.529984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuo4-00062f-Bf; Mon, 25 Apr 2022 09:14:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312640.529984; Mon, 25 Apr 2022 09:14:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuo4-00062Y-7p; Mon, 25 Apr 2022 09:14:56 +0000
Received: by outflank-mailman (input) for mailman id 312640;
 Mon, 25 Apr 2022 09:14:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Y4oX=VD=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1niuo3-00062O-0j
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 09:14:55 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2aeb6d89-c478-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 11:14:53 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 75DF71F37D;
 Mon, 25 Apr 2022 09:14:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F0F8E13AE1;
 Mon, 25 Apr 2022 09:14:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6nJWOYxmZmKpEwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 25 Apr 2022 09:14:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2aeb6d89-c478-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650878093; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=LxD+ce4AUrEfdda18R4wniDCcWxz9Eqepxe4MqD5yjk=;
	b=e8Mew+GNxXEIiziOIGlK1boajGXRxPWnv1C6nzdj5Cv2lzSriJ7X4lY1kezY0cy7j4KhXn
	w3S30JRFv9cnWZAUbw9MWOl2pQXfJO2wmSq/d3cUh9lAlfDrpsypGOkNpMdPoulGq90emh
	WyXDnoqBBcdIxnYfUX6Q3Zd/18Kt5Qo=
Message-ID: <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
Date: Mon, 25 Apr 2022 11:14:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Content-Language: en-US
To: Christoph Hellwig <hch@infradead.org>
Cc: Oleksandr <olekstysh@gmail.com>, xen-devel@lists.xenproject.org,
 x86@kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Tom Lendacky <thomas.lendacky@amd.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <YmZUpua3hkCPdbfx@infradead.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------3cKMf0pMZzCdnbR0F91OT6d3"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------3cKMf0pMZzCdnbR0F91OT6d3
Content-Type: multipart/mixed; boundary="------------6LRm3VWi03bXvVqBYjAyZb1V";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Oleksandr <olekstysh@gmail.com>, xen-devel@lists.xenproject.org,
 x86@kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
In-Reply-To: <YmZUpua3hkCPdbfx@infradead.org>

--------------6LRm3VWi03bXvVqBYjAyZb1V
Content-Type: multipart/mixed; boundary="------------tzkTspFuEKkqBFjbFcKiNoA0"

--------------tzkTspFuEKkqBFjbFcKiNoA0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjUuMDQuMjIgMDk6NTgsIENocmlzdG9waCBIZWxsd2lnIHdyb3RlOg0KPiBPbiBNb24s
IEFwciAyNSwgMjAyMiBhdCAwOTo0Nzo0OUFNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3Rl
Og0KPj4+IFdvdWxkIHRoZSBYZW4gc3BlY2lmaWMgYml0cyBmaXQgaW50byBDb25maWRlbnRp
YWwgQ29tcHV0aW5nIFBsYXRmb3JtDQo+Pj4gY2hlY2tzPyBJIHdpbGwgbGV0IEp1ZXJnZW4v
Qm9yaXMgY29tbWVudCBvbiB0aGlzLg0KPj4NCj4+IEkgZG9uJ3QgdGhpbmsgY2NfcGxhdGZv
cm1faGFzIHdvdWxkIGJlIGNvcnJlY3QgaGVyZS4gWGVuIGNlcnRhaW5seQ0KPj4gcHJvdmlk
ZXMgbW9yZSBpc29sYXRpb24gYmV0d2VlbiBndWVzdHMgYW5kIGRvbTAsIGJ1dCAiQ29uZmlk
ZW50aWFsDQo+PiBDb21wdXRpbmciIGlzIGJhc2ljYWxseSBvcnRob2dvbmFsIHRvIHRoYXQg
ZmVhdHVyZS4NCj4gDQo+IFRoZSBwb2ludCBvZiBjY19wbGF0Zm9ybV9oYXMgaXMgdG8gcmVt
b3ZlIGFsbCB0aGVzZSBvcGVuIGNvZGUgY2hlY2tzLg0KPiBJZiBhIFhlbiBoeXBlcnZpc29y
IC8gZG9tMCBjYW4ndCBhY2Nlc3MgYXJiaXRyYXJ5IGd1ZXN0IG1lbW9yeSBmb3INCj4gdmly
dHVhbCBJL08gYW5kIHdlIG5lZWQgc3BlY2lhbCBBUElzIGZvciB0aGF0IGl0IGNlcnRhaW5s
eSBmYWxzZQ0KPiBpbnRvIHRoZSBzY29wZSBvZiBjY19wbGF0Zm9ybV9oYXMsIGV2ZW4gaWYg
dGhlIGNvbmZpZW50aWFsaXR5IGlzDQo+IHJhdGhlciBsaW1pdGVkLg0KDQpJbiBjYXNlIHRo
ZSB4ODYgbWFpbnRhaW5lcnMgYXJlIGZpbmUgd2l0aCB0aGF0IEkgd29uJ3Qgb3Bwb3NlLg0K
DQoNCkp1ZXJnZW4NCg==
--------------tzkTspFuEKkqBFjbFcKiNoA0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------tzkTspFuEKkqBFjbFcKiNoA0--

--------------6LRm3VWi03bXvVqBYjAyZb1V--

--------------3cKMf0pMZzCdnbR0F91OT6d3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJmZowFAwAAAAAACgkQsN6d1ii/Ey8r
Ygf/aV/NKOLaArzKrc86hrkP0XV0aIShnHg523LWf4xHhGIQoD8EwkxH45JF86R/MrJs5yfUdyI6
PgLkrQNEPgCKihyoixiBjx4eI3R/lDOcBx7gRpTi2G8TglEHFITlmYeMBVsqg1h614i9G1QkpkK1
ArMDXd3b32jTEnMfRInQ471aXXPsFOmXlFCONHt+K459knDStRY8OP605tSv+cTJj5xBU792ZcDe
NdI+1IP/zdKALsV3FS9eoWdtW9NQ1MWZXJNlyhBYqKdW1AFD7JUFmVe6mnfKfKLRs4bwKRQCGbkk
hHA9RkQLqdnAGyc8UTEMJt5LWU2aYelXSmyMmis2cQ==
=rdmV
-----END PGP SIGNATURE-----

--------------3cKMf0pMZzCdnbR0F91OT6d3--


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 09:26:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 09:26:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312665.530002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuzU-0007qq-Gc; Mon, 25 Apr 2022 09:26:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312665.530002; Mon, 25 Apr 2022 09:26:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niuzU-0007qj-D1; Mon, 25 Apr 2022 09:26:44 +0000
Received: by outflank-mailman (input) for mailman id 312665;
 Mon, 25 Apr 2022 09:26:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niuzT-0007qZ-Nj; Mon, 25 Apr 2022 09:26:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niuzT-000833-KC; Mon, 25 Apr 2022 09:26:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niuzT-0003EP-2z; Mon, 25 Apr 2022 09:26:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niuzT-0005BX-2U; Mon, 25 Apr 2022 09:26:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=11HwlV0Mox1X+BE4FaZv7rbmp2dJ3C0aT9vpCfSsNzs=; b=FLxblXVnMyGydLXjmHf/LQesMH
	X0e2QnrXgqhQJRfBUSRZoqi9+TcDP5Us0FCoIZ0tDqZffELclA4eiiNgNSjJNTbY4k5ocJyp/Iyrs
	+qvXYNlwdVX0vIxmIaOacak9cSGR/vZOFEpVsZJwSzdKE5U9ti6GaooOiBfbzkwm0bYU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169694-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169694: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
X-Osstest-Versions-That:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 09:26:43 +0000

flight 169694 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169694/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169666
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169666
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169666
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169666
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169666
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169666
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169666
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169666
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169666
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169666
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169666
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169666
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08
baseline version:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08

Last test of basis   169694  2022-04-25 01:51:51 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 09:45:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 09:45:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312678.530014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivHS-000271-8F; Mon, 25 Apr 2022 09:45:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312678.530014; Mon, 25 Apr 2022 09:45:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivHS-00026u-4b; Mon, 25 Apr 2022 09:45:18 +0000
Received: by outflank-mailman (input) for mailman id 312678;
 Mon, 25 Apr 2022 09:45:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nivHQ-00026o-T9
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 09:45:17 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 66c4d09f-c47c-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 11:45:14 +0200 (CEST)
Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 05:44:46 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SJ0PR03MB6780.namprd03.prod.outlook.com (2603:10b6:a03:40f::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr
 2022 09:44:44 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 09:44:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66c4d09f-c47c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650879914;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=mHj1wpbu1RnfUXZMZyMMeJPAd2UVuUrTZBPyjsXUzXg=;
  b=QRw/grylIFwWC6QXiF0OQtchma8yrw8LvmRSr2xliug456lGTxSxrQg9
   rPzZBMGBrvPKgjzBhUHHZoU1kYSmM3It/MKTlIONxUMsARzR2inPI6eEz
   m9UOWVH1e/zAWgTigeKiDybgITxUYv7qeDK+JZVMT+Y2K8GtsaK7rA0Dp
   g=;
X-IronPort-RemoteIP: 104.47.55.176
X-IronPort-MID: 70245856
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:YLjVDK3devo7YoxVJ/bD5ZJxkn2cJEfYwER7XKvMYLTBsI5bpzwCy
 GtJDW6POa2CZzf3KdwjOoy19UsH6JfRytdrQANvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy3YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1EjLjrF18OO5HekfofXzQADQxHJLdJreqvzXiX6aR/zmXgWl61mbBEKhFzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfyVu7e03x9p7ixKNezZa
 McDLyJmcTzLYgFVO0dRA5U79AutrianKWEF+A/LzUYxy1rIlB14iefIDJ3YeoDWS+pzjFe2t
 0uTqgwVBTlfbrRz0wGt/mq3g+7TnQvyQI8ICKCj7flunUGSwWoIThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYiXN5XH/w/+Ru64KPe6AaEBUAJVjdELtchsaceWjgCx
 lKP2dTzClRHq7aSVW7b+r6KrCiaIjQcN2sLb2kFSmMt4dDlrJsikxHnQdNqEarzhdrwcRnr2
 CyDpiU6g7QVjOYI2r+98FSBhCijzrDLUwo06wP/Tm+jqARja+aNbYGy9ULS6/oGKY+DV0SAp
 1ANgc3Y5+cLZbmPniGQROQGHJmy+u2IdjbbhDZHE5co+Dus/HqiVZtN+zw4L0BsWu4IdjPkb
 1XakR9A759Uen2xZOl4ZJzZNigx5a3pFNCgXPaEaNNLO8J1bFXeo38oYlOM1WfwlkRqibs4J
 ZqQbcerCzAdFLhjyz21Aewa1NfH2xwD+I8afrijpzzP7FZUTCX9pWstWLdWUt0E0Q==
IronPort-HdrOrdr: A9a23:gxqZkqsO7b3vyKbRYuG0d2kC7skC6oMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH
 PQ3LswmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZXbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczKgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxenkPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesaMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO21GkeKp
 ghMCjg3ocWTbvDBEqp/lWHgebcFEjbJy32DXTr4aeuontrdHMQ9Tpr+CVQpAZDyHsHceg72w
 31CNUWqFhwdL5mUUtcPpZ0fSLlMB27ffrzWFjiUWjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q
 6xG29liQ==
X-IronPort-AV: E=Sophos;i="5.90,287,1643691600"; 
   d="scan'208";a="70245856"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MOhG9+7wB//G87sKT8EO/iiLdzq1W0q5YVwb8I0useuBtyWv9Cn4JD1oEnWYYta6xJqK80Z9DoqGz6mhFxVdgB9wmJv1MIFYoYcO0Vq8xcibUuByLst+DdPK75A8+F2VCQ7DIj6jzNy/PYke/dy/JBCNtxNuvcTLA+k/Jodx3xjbd6OdeFuYziMCKchHzmJDV8U7ekTBatRx7E8UFKpLVBS9aeppVrbNL2vDL+TCko5DePr7Buoag865hqIfVheFtK/L2Z/nxCP+rvc2Qa7Q9ty30gPogS5s9yFjGPpVqTlz5neveRwSyYGcVbusHFcisrRYEGaIeMe9q3xSQ6jVxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bcc+Y9ld8mEbMiHKo68pZae1wKD5BKrF/ijBxuLm+BU=;
 b=lMLoEzhKUbEukTiAj14anO4USbfLNVt7D6ohWuNOyOeVOEZVdzT7Zoe2Xq1jcf7zPFPvIXDetbv7Kd8R8NGZnmlDoQe27qu5KcKP657IIacaO6MM1awhyUUzMrxUuO4h1CVtskG2uJdI20E92szPJOcaO850X5LAakblMAtgt68xlNSPtrbxCtgZrPCdkvZvJ0fSiG34o6nL/ZwcKXJX9ad9FQ88TgWEqJDifViZpOk9WxQXGKs248+7E6QZbwWNeUstt/u6QisHFDcZWEUHxuSbQhs5u5lTIUhlS07gcDpVabDgWfD0wzNPzQXkqWVoCob6n0KQ3uejZb4JJZkysg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bcc+Y9ld8mEbMiHKo68pZae1wKD5BKrF/ijBxuLm+BU=;
 b=FlI/51yIBI8JVhtMs17zKtJ+GnWL2AynSBEElSi09AEFUTdcp3/oMEBms74xMmp5KZNL5ZuVYLvp4X476QNMC/wF61UGKskFsT7GStSe2SnnNOeG1BAikllKuAoKu2NKXjQs+9mDhqSmqT0x6LqMjORBcg/Qk3wpZRS80o1v3RI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 11:44:40 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>, scott.davis@starlab.io, jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote
 after setup
Message-ID: <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
 <20220422163458.30170-2-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220422163458.30170-2-dpsmith@apertussolutions.com>
X-ClientProxiedBy: LO4P123CA0241.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a7::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0ddaa212-79ce-4808-1a7c-08da26a03a8a
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6780:EE_
X-Microsoft-Antispam-PRVS:
	<SJ0PR03MB6780DDF5806198A36C8A7F388FF89@SJ0PR03MB6780.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t/vR10g1B5LE7kUtK1NOCQA6q7J81zyXEavOmnzIbNZfW8tNfiGx3kmpjnnJVNdMcaV69uG6siZOdDcsAbPriGL3x+0KxYgQ47KkjtTb5Iio1lIYIfOktJF6i3rXmJcOGMz/mQu/EBCAU+uJ1CjLbhRGyBg8xxPbSP5yd8mB69tpIsm90BiJlB6qW4wFwQG1UHcgeJUFuDQynRBCprkBzZyOt9wAUyg01vTUVI6ccFU8IhGPNoUe3EJNPC7P2W8R+HQZ37kY8bkGrbhwVAYgiCDr1wf7sBXJ02mgraQVATk2Qn9kQGbU9JnCTicsTlZKgEMns4sKDRpWYHu+VxDxr9K4NxQB2ktjk6B8qkbHHtjJ6zqp4vwxCz2kCj+O4U6NXXxoQ3PQHhlLs+jqiSBmi7+yPLsQvzDy6vHKAqthRHmq3qx2oTrgcVZN9LWXgfYTuLWdN5Y3+KI7ft7UXy7SSaMj8i4XC1RB4v7qzenGWWFjNW1jNiJoOG6uqOt0ETi6T1Wrkb+Ecn6b+irEy8giPryY8hhgGMRMzFIq1KQnMnsRfD7/gwlaRKwIxptWkyzIeo4aPPbNTiOQTqieF0ADbY3DjJfiQH4cNEcacEQQEPkuLICUqfTOPuH+KSzGk5t7ri7XvaDJQkCWV3hp+PlOfg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4326008)(82960400001)(6666004)(66946007)(8676002)(66556008)(2906002)(6486002)(5660300002)(54906003)(85182001)(316002)(83380400001)(6916009)(38100700002)(6506007)(86362001)(7416002)(66476007)(33716001)(8936002)(508600001)(26005)(6512007)(9686003)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TU1TRXlPRmlSdVpENWYvU29ZQS8wWlVRQUdzZ011aGlHeW1NS2ZXd05pMWdm?=
 =?utf-8?B?TENaM2dOcTNILzlYNDloS0FHc0RLM21PK1RJN29qekRHV3pYMXY3QW0vRHpv?=
 =?utf-8?B?MmtrdmJFRlFJS0l1SUpVdk5tZEhRWDZ0V3BmbDQ0VThIZnZlcjZFMytsMEpJ?=
 =?utf-8?B?VDBFLzUwWmF5OVNub3o2eUpmckd1NUxpb2NjUkE0RG5NRkdJTEpldkw1NjRH?=
 =?utf-8?B?b0wvN2Q3cGViZEFkZVVmRTRzYlNQVzJJUFc3WUJVNEFwN0dDMjRMUWV3T1M3?=
 =?utf-8?B?Smt1SWRiR090Yk1uZ1doVElrWUlTbE05Wk91c2NwTXRvWXlYeUlaSnhWWEtR?=
 =?utf-8?B?c1dSTUs5RjlUNmFhbHd0NkFTMUc0TTFmaWI1NG56bVNsQ1h4QkdUQi9MNU9G?=
 =?utf-8?B?RkFOOWxZYk5udE0yOXZoalhjZllsUlpVKzBSdzQwY1hVYlZNS1NXS1hBaTAv?=
 =?utf-8?B?Y0xhayswVEs3WWNZa1k4VjNZeU9OSldDSUx6Wk0xU2hVdFRQU0FNT09Kd1ZH?=
 =?utf-8?B?Q3N6eHF2dWRzcFN5ZGowQnh3T3JHV0NkZWdGaDg1YVFZT3BSSENtNEp4c2tZ?=
 =?utf-8?B?ZWR2NEpvZGxnc0NTczJrRjIySWNDRFE1N2RVUUpuZkpsaVp3ZVg3d2lUbnp1?=
 =?utf-8?B?MnMvVmRyazhSZW9rNkdhOXhSUmR6cjAzV25VMHZyZnRsZWdkb0tsL2ZIMExk?=
 =?utf-8?B?TGU2UXNUY3hyUUFtb2o1d2hONDhtNjY4VVhHdVFlTzBFaUNMd3lGR2Q3Vklh?=
 =?utf-8?B?N0h2ZGMxbDZQbGEzUFMrQ0J1YTNTRDBrNDVjeHZJUEE2eDgxaVpSQXZWaldF?=
 =?utf-8?B?NkhZWjQ0YzBsNStNeE0wL09VYjdWaVlZdEFhSStlK2wvSXg3dUo4R1o4Nk9t?=
 =?utf-8?B?RHFoeDFkd2dQUDZZYzNpd3NiYUZGOU5WOXh5cWg2NGFENVFDa1dZK2Q4WlQr?=
 =?utf-8?B?bUMwL0NOYko0U2p2WWdwS0lWSDZDQ29GeVppbFlPVVlWd2VSaS9FamdhOHp5?=
 =?utf-8?B?QnpJaC9ueHlqRnVMWmk4R0QyTE1KZWxFWWowRGhZaEhpNVdTd3AzNmdueXZz?=
 =?utf-8?B?VlBSaDdrS1VjRktuNnBLTDlGYXlZRUJkOExxWjYwMko2YU8vbmdiTUtyVmpr?=
 =?utf-8?B?T3hJZlM4R0F1SnJzQ0NvZHB5NExha0VYL1BUL3hGbXFVekh6VDdQWVdEQW10?=
 =?utf-8?B?bGwyY0NBRFNxUWVTb2E3dVNvZ2pDSXI1YVk4blZOeS9saXdNYlhCTEhjZXB5?=
 =?utf-8?B?YkcxODNzNTV4akJBRnVWMVpKVnRGQnpSNU0weDEwRnZHQWp5S0dWTmw1WFUv?=
 =?utf-8?B?aDhZR0NYVzhUUmVkWlpMK2pHeUhiRis0VFJocWtlL2U1cm9wQlZIbEdwbjFF?=
 =?utf-8?B?OE96Q3RPREdWc2o3Z3pJcXM2d3dIZXZhSG5yVHZ2dkNTRTdoYlZONDJBc0VG?=
 =?utf-8?B?djF3N3FpMkphUmhjWmRpNEQ4WitxNkc0N1B6bEVnS3N1aENsSERYdzdpN3FP?=
 =?utf-8?B?cmkvdjRFYll0VEkxQ2c0R2gyRUxudkxUd1FZZWdlbkJpeFZSQnZ3R29GY0Yr?=
 =?utf-8?B?YUY4QjVwYUVPRkdqeE9acWk1RExTU3VuaVNRM0VuUnUzTy9rN3U2Y1AzZHhW?=
 =?utf-8?B?QWJaWGl5eWRYbzRzY1VLNXFmY3VrZCt1dkN0S1BlNGc4bHNzcU0vWEZxQTRm?=
 =?utf-8?B?WVlnQXNvRmI1RWJUc1NKeXdmNE0wWkNEcHUzNDhsb1orMUtjME9UVG5MejVv?=
 =?utf-8?B?eTk0T1hLSlhsTjRRV2dIVnFtcVRIU0NjNW5Id2Z2aW4vbTN3K3VmYlpSWUJ1?=
 =?utf-8?B?R0xHVW5xWDdRNlU3eUJXVVM1bDdUQ2VScytYN2ZnVEtUdWRwTm5DWG5VS1ZF?=
 =?utf-8?B?MEMzWkFIN1poWkRKR3dGZUtRNCtHMm9YVGptYVNmcmRkNjJDNWpvdUdabTF4?=
 =?utf-8?B?WlBZQ2MzNEVPNXBGK3hXakpUdDJBdEczbWlmc1JPb2NnVjhYdllyNWJYSnZn?=
 =?utf-8?B?SDdydlRFQnJ3V09nM0ZmN1NMVHdyTktXTk9YUnBtUi9YbGM3MnhmSTZqZnVv?=
 =?utf-8?B?YlAyL2F0MUpyM2didTluYlhQQ3Z0SHNWTVpEOVVnYUhBQVE0a2Ryd2xIdEwz?=
 =?utf-8?B?WEk0Y2h4Z2xWZTFOZDNGUDdjSzMwUXVHK21SOStEM28vOVJyQ044WWhkaUM0?=
 =?utf-8?B?VFMyWWlIcFBEdHQxSm5sSWxkT240TllPTVErL1F1eHo4NmlwN0V3c3pja3Vh?=
 =?utf-8?B?d0pQcllsOTZQV043bnBrbkgwWVB3VlJsREljTmZrWkZBQ3g1djg3L0JGLy96?=
 =?utf-8?B?WVM3ZytpdzZMM3d2RmNqbzFjMWhVQmtwZmpyY25lR1NJZTRLdjdQSEhYdXpX?=
 =?utf-8?Q?UxN6O05k5iWVWmaQ=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddaa212-79ce-4808-1a7c-08da26a03a8a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 09:44:44.6347
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GTf/aVc5JVrdqtO/STaFBnaxXxupjTteH6Qs9NscXvjpGFdp7MzSip6ncne1BwtbL5ji7YKiYNzE5OfchKgLAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6780

On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
> There are now instances where internal hypervisor logic needs to make resource
> allocation calls that are protected by XSM checks. The internal hypervisor logic
> is represented a number of system domains which by designed are represented by

'Some of the hypervisor code can be executed in a system domain that's
represented by a per-CPU non-privileged struct domain. To enable...'

> non-privileged struct domain instances. To enable these logic blocks to
> function correctly but in a controlled manner, this commit changes the idle
> domain to be created as a privileged domain under the default policy, which is
> inherited by the SILO policy, and demoted before transitioning to running. A
> new XSM hook, xsm_set_system_active, is introduced to allow each XSM policy
> type to demote the idle domain appropriately for that policy type.
> 
> For flask a stub is added to ensure that flask policy system will function
> correctly with this patch until flask is extended with support for starting the
> idle domain privileged and properly demoting it on the call to
> xsm_set_system_active.
> 
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> ---
>  xen/arch/arm/setup.c    |  3 +++
>  xen/arch/x86/setup.c    |  3 +++
>  xen/common/sched/core.c |  7 ++++++-
>  xen/include/xsm/dummy.h | 17 +++++++++++++++++
>  xen/include/xsm/xsm.h   |  6 ++++++
>  xen/xsm/dummy.c         |  1 +
>  xen/xsm/flask/hooks.c   | 21 +++++++++++++++++++++
>  7 files changed, 57 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index d5d0792ed4..e71fa3f860 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset,
>      /* Hide UART from DOM0 if we're using it */
>      serial_endboot();
>  
> +    if ( xsm_set_system_active() != 0)
> +        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
> +
>      system_state = SYS_STATE_active;
>  
>      for_each_domain( d )
> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
> index 6f20e17892..a3ce288ef9 100644
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
>      void *va;
>      unsigned long start, end;
>  
> +    if ( xsm_set_system_active() != 0)
           ^ extra space.

Since the function returns an error code you might as well add it to
the panic message, or else just make the function return bool instead.

Or just make the function void and panic in the handler itself (like
in previous versions), as I don't think it's sensible to continue
normal execution if xsm_set_system_active fails.

> +        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
> +
>      system_state = SYS_STATE_active;
>  
>      domain_unpause_by_systemcontroller(dom0);
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index 19ab678181..22a619e260 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
>          sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
>      }
>  
> -    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
> +    /*
> +     * idle dom is created privileged to ensure unrestricted access during
> +     * setup and will be demoted by xsm_transition_running when setup is

s/xsm_transition_running/xsm_set_system_active/

> +     * complete

Nit: missing full stop according to CODING_STYLE.

> +     */
> +    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
>      BUG_ON(IS_ERR(idle_domain));
>      BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
>      idle_domain->vcpu = idle_vcpu;
> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
> index 58afc1d589..3291fb5396 100644
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -101,6 +101,23 @@ static always_inline int xsm_default_action(
>      }
>  }
>  
> +static XSM_INLINE int cf_check xsm_set_system_active(void)
> +{
> +    struct domain *d = current->domain;
> +
> +    ASSERT(d->is_privileged);
> +
> +    if ( d->domain_id != DOMID_IDLE )
> +    {
> +        printk("xsm_set_system_active: should only be called by idle domain\n");
> +        return -EPERM;
> +    }
> +
> +    d->is_privileged = false;
> +
> +    return 0;
> +}
> +
>  static XSM_INLINE void cf_check xsm_security_domaininfo(
>      struct domain *d, struct xen_domctl_getdomaininfo *info)
>  {
> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> index 3e2b7fe3db..8dad03fd3d 100644
> --- a/xen/include/xsm/xsm.h
> +++ b/xen/include/xsm/xsm.h
> @@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t;
>   * !!! WARNING !!!
>   */
>  struct xsm_ops {
> +    int (*set_system_active)(void);
>      void (*security_domaininfo)(struct domain *d,
>                                  struct xen_domctl_getdomaininfo *info);
>      int (*domain_create)(struct domain *d, uint32_t ssidref);
> @@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops;
>  
>  #ifndef XSM_NO_WRAPPERS
>  
> +static inline int xsm_set_system_active(void)
> +{
> +    return alternative_call(xsm_ops.set_system_active);
> +}
> +
>  static inline void xsm_security_domaininfo(
>      struct domain *d, struct xen_domctl_getdomaininfo *info)
>  {
> diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
> index 8c044ef615..e6ffa948f7 100644
> --- a/xen/xsm/dummy.c
> +++ b/xen/xsm/dummy.c
> @@ -14,6 +14,7 @@
>  #include <xsm/dummy.h>
>  
>  static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
> +    .set_system_active             = xsm_set_system_active,
>      .security_domaininfo           = xsm_security_domaininfo,
>      .domain_create                 = xsm_domain_create,
>      .getdomaininfo                 = xsm_getdomaininfo,
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index 0bf63ffa84..8a62de2fd6 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>      return 0;
>  }
>  
> +static int cf_check flask_set_system_active(void)
> +{
> +    struct domain *d = current->domain;

Nit: you should also add the assert for d->is_privileged, I don't see
a reason for the xsm and flask functions to differ in that regard.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 10:07:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 10:07:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312700.530032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivcX-000508-5I; Mon, 25 Apr 2022 10:07:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312700.530032; Mon, 25 Apr 2022 10:07:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivcX-000501-2F; Mon, 25 Apr 2022 10:07:05 +0000
Received: by outflank-mailman (input) for mailman id 312700;
 Mon, 25 Apr 2022 10:07:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Eo9G=VD=citrix.com=prvs=107e1699f=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nivcV-0004zv-Gw
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 10:07:03 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 72a58353-c47f-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 12:07:02 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72a58353-c47f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650881221;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=zGvmq1TIl1lbCHKhcswvVthKTJC5MAI1Qajbd0Y/xNg=;
  b=R/K2ZMrNQ3jdfQTuIosu8ktx930LPXG9Z8QOdRCuWQ14PCReSwM5OF0B
   CEfmn2EzNr3kUYfaV/yX4wGqu2aguc0IRa5FZMa8He8uWEbBbMLCTWoNR
   VaqwCUGvXT3sVYd2+HNqtFlNFog9M3lZlI3iVJzqCAbdhLrqcWoZVnEas
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70247504
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mz6q4qmsdNwXNcRdjhRISdXo5gxsJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXW2+PaaneYjT1LdB1O4vl9R5UvMfQy4QyTlNu+y1hQiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWV/V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYaQNxL5aQwMUhVTZJDC9OIbAexO+ECC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJGMWAzM0mYP3WjPH9JUqA7wLyMiEDNXDdii0qto5RpszTcmVkZPL/Fb4OOJ43iqd9utkSXv
 GXd5EziHwoXcteYzFKt0Fihm+vOliPTQ58JGfuz8fsCqFee3HAJARsaE16yu+Cki1WWUshab
 UcT/0IGk68280C6S8jnaDexqnWEox00VsJZFqsx7wTl4rHP/w+TC2wATzhAQN8rrsk7QXotz
 FDht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHLopw3jx/JZsZuFuiylNKdMS706
 yCHqm45nbp7sCIQ//zlpxad2Wvq/8WXCF5ujunKYo67xiN9PJ+eO9SJ1V70/OlOHJqEFmXR/
 1FRzqBy89syJZ2KkSWMRsAEE7eo++uJPVXgvLJ/I3Uy32/zoiD+JOi89Bk7fR40aZhcJVcFd
 WeJ4WtsCIlv0GxGhEOdS6a4EIwUwKfpDrwJvdiEP4MVMvCdmOJqlRyChHJ8PUiwyiDAcollY
 P93lPpA6l5AVMxaIMKeHbt17FPS7nlWKZnvbZ761Q+79rGVeWSYT7wIWHPXML1hs/7d+F+Er
 owBXydv9/m5eLenCsUw2dRNRW3m0FBhXcymwyCpXrPrzvVa9JEJVKaKnOJJl31NlKVJjObYl
 kxRqWcDoGcTcUbvcF3QAlg6MeuHdc8m/RoTYHx9VX71iiNLSdv+s88im24fIOBPGBpLlqUvE
 ZHouqyoX5xyd9gw02lDPcSl8Nw+JXxGR2umZkKYXdT2RLY4LyShxzMuVlGHGPUmZsZvifYDn
 g==
IronPort-HdrOrdr: A9a23:Lnc81K4AUwhPo/HSMgPXwMTXdLJyesId70hD6qhwISY6TiX+rb
 HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78
 hdmtBFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.90,287,1643691600"; 
   d="scan'208";a="70247504"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Juergen Gross <jgross@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: [PATCH v2] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Date: Mon, 25 Apr 2022 11:06:42 +0100
Message-ID: <20220425100642.14383-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

When CONFIG_GDBSX is compiled out, iommu_do_domctl() falls over a NULL
pointer.  One of several bugs here is known-but-compiled-out subops falling
into the default chain and hitting unrelated logic.

Remove the CONFIG_GDBSX ifdefary in arch_do_domctl() by implementing
gdbsx_domctl() and moving the logic across.

As minor cleanup,
 * gdbsx_guest_mem_io() can become static
 * Remove opencoding of domain_vcpu() and %pd

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Liu <wl@xen.org>
CC: Julien Grall <julien@xen.org>
CC: Juergen Gross <jgross@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

v2:
 * Implement the "split into new function" approach from the RFC.
---
 xen/arch/x86/domctl.c            | 61 +----------------------------------
 xen/arch/x86/gdbsx.c             | 68 +++++++++++++++++++++++++++++++++++++++-
 xen/arch/x86/include/asm/gdbsx.h | 15 +++++++--
 3 files changed, 80 insertions(+), 64 deletions(-)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index c20ab4352715..9131acb8a230 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -816,71 +816,12 @@ long arch_do_domctl(
     }
 #endif
 
-#ifdef CONFIG_GDBSX
     case XEN_DOMCTL_gdbsx_guestmemio:
-        ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
-        if ( !ret )
-           copyback = true;
-        break;
-
     case XEN_DOMCTL_gdbsx_pausevcpu:
-    {
-        struct vcpu *v;
-
-        ret = -EBUSY;
-        if ( !d->controller_pause_count )
-            break;
-        ret = -EINVAL;
-        if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= d->max_vcpus ||
-             (v = d->vcpu[domctl->u.gdbsx_pauseunp_vcpu.vcpu]) == NULL )
-            break;
-        ret = vcpu_pause_by_systemcontroller(v);
-        break;
-    }
-
     case XEN_DOMCTL_gdbsx_unpausevcpu:
-    {
-        struct vcpu *v;
-
-        ret = -EBUSY;
-        if ( !d->controller_pause_count )
-            break;
-        ret = -EINVAL;
-        if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= d->max_vcpus ||
-             (v = d->vcpu[domctl->u.gdbsx_pauseunp_vcpu.vcpu]) == NULL )
-            break;
-        ret = vcpu_unpause_by_systemcontroller(v);
-        if ( ret == -EINVAL )
-            printk(XENLOG_G_WARNING
-                   "WARN: d%d attempting to unpause %pv which is not paused\n",
-                   currd->domain_id, v);
-        break;
-    }
-
     case XEN_DOMCTL_gdbsx_domstatus:
-    {
-        struct vcpu *v;
-
-        domctl->u.gdbsx_domstatus.vcpu_id = -1;
-        domctl->u.gdbsx_domstatus.paused = d->controller_pause_count > 0;
-        if ( domctl->u.gdbsx_domstatus.paused )
-        {
-            for_each_vcpu ( d, v )
-            {
-                if ( v->arch.gdbsx_vcpu_event )
-                {
-                    domctl->u.gdbsx_domstatus.vcpu_id = v->vcpu_id;
-                    domctl->u.gdbsx_domstatus.vcpu_ev =
-                        v->arch.gdbsx_vcpu_event;
-                    v->arch.gdbsx_vcpu_event = 0;
-                    break;
-                }
-            }
-        }
-        copyback = true;
+        ret = gdbsx_domctl(d, domctl, &copyback);
         break;
-    }
-#endif
 
     case XEN_DOMCTL_setvcpuextstate:
     case XEN_DOMCTL_getvcpuextstate:
diff --git a/xen/arch/x86/gdbsx.c b/xen/arch/x86/gdbsx.c
index 6ef46e8ea77d..d8067ec90fd4 100644
--- a/xen/arch/x86/gdbsx.c
+++ b/xen/arch/x86/gdbsx.c
@@ -152,7 +152,8 @@ static unsigned int dbg_rw_guest_mem(struct domain *dp, unsigned long addr,
     return len;
 }
 
-int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop)
+static int gdbsx_guest_mem_io(struct domain *d,
+                              struct xen_domctl_gdbsx_memio *iop)
 {
     if ( d && !d->is_dying )
     {
@@ -178,6 +179,71 @@ void domain_pause_for_debugger(void)
         send_global_virq(VIRQ_DEBUGGER);
 }
 
+long gdbsx_domctl(struct domain *d, struct xen_domctl *domctl, bool *copyback)
+{
+    struct vcpu *v;
+    long ret = 0;
+
+    switch ( domctl->cmd )
+    {
+    case XEN_DOMCTL_gdbsx_guestmemio:
+        ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
+        if ( !ret )
+            *copyback = true;
+        break;
+
+    case XEN_DOMCTL_gdbsx_pausevcpu:
+        ret = -EBUSY;
+        if ( !d->controller_pause_count )
+            break;
+        ret = -EINVAL;
+        if ( (v = domain_vcpu(d, domctl->u.gdbsx_pauseunp_vcpu.vcpu)) == NULL )
+            break;
+        ret = vcpu_pause_by_systemcontroller(v);
+        break;
+
+    case XEN_DOMCTL_gdbsx_unpausevcpu:
+        ret = -EBUSY;
+        if ( !d->controller_pause_count )
+            break;
+        ret = -EINVAL;
+        if ( (v = domain_vcpu(d, domctl->u.gdbsx_pauseunp_vcpu.vcpu)) == NULL )
+            break;
+        ret = vcpu_unpause_by_systemcontroller(v);
+        if ( ret == -EINVAL )
+            printk(XENLOG_G_WARNING
+                   "WARN: %pd attempting to unpause %pv which is not paused\n",
+                   current->domain, v);
+        break;
+
+    case XEN_DOMCTL_gdbsx_domstatus:
+        domctl->u.gdbsx_domstatus.vcpu_id = -1;
+        domctl->u.gdbsx_domstatus.paused = d->controller_pause_count > 0;
+        if ( domctl->u.gdbsx_domstatus.paused )
+        {
+            for_each_vcpu ( d, v )
+            {
+                if ( v->arch.gdbsx_vcpu_event )
+                {
+                    domctl->u.gdbsx_domstatus.vcpu_id = v->vcpu_id;
+                    domctl->u.gdbsx_domstatus.vcpu_ev =
+                        v->arch.gdbsx_vcpu_event;
+                    v->arch.gdbsx_vcpu_event = 0;
+                    break;
+                }
+            }
+        }
+        *copyback = true;
+        break;
+
+    default:
+        ASSERT_UNREACHABLE();
+        ret = -ENOSYS;
+    }
+
+    return ret;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/include/asm/gdbsx.h b/xen/arch/x86/include/asm/gdbsx.h
index 938eb74e2e25..8d357e5c9102 100644
--- a/xen/arch/x86/include/asm/gdbsx.h
+++ b/xen/arch/x86/include/asm/gdbsx.h
@@ -2,18 +2,27 @@
 #ifndef __X86_GDBX_H__
 #define __X86_GDBX_H__
 
-#ifdef CONFIG_GDBSX
+#include <xen/stdbool.h>
 
 struct domain;
-struct xen_domctl_gdbsx_memio;
+struct xen_domctl;
 
-int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop);
+#ifdef CONFIG_GDBSX
 
 void domain_pause_for_debugger(void);
 
+long gdbsx_domctl(struct domain *d, struct xen_domctl *domctl, bool *copyback);
+
 #else
 
+#include <xen/errno.h>
+
 static inline void domain_pause_for_debugger(void) {}
 
+long gdbsx_domctl(struct domain *d, struct xen_domctl *domctl, bool *copyback)
+{
+    return -ENOSYS;
+}
+
 #endif /* CONFIG_GDBSX */
 #endif /* __X86_GDBX_H__ */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 10:09:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 10:09:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312706.530042 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivfE-0005bj-KM; Mon, 25 Apr 2022 10:09:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312706.530042; Mon, 25 Apr 2022 10:09:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivfE-0005bc-Gd; Mon, 25 Apr 2022 10:09:52 +0000
Received: by outflank-mailman (input) for mailman id 312706;
 Mon, 25 Apr 2022 10:09:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivfC-0005bR-Ls; Mon, 25 Apr 2022 10:09:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivfC-0000Qx-Kt; Mon, 25 Apr 2022 10:09:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivfC-0004IB-2y; Mon, 25 Apr 2022 10:09:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nivfC-0006U7-2V; Mon, 25 Apr 2022 10:09:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8NBk7EI53T/F8ivbZLlRgcsmekHvbZXUMvGMt7xoQDY=; b=szY6hd3M3NZOwDg2Y9n1SlRgA8
	/IwTBa3XMtRcO7zx9866yIDdn1ZPK+PxLTFjPEkEMwXB56T0+sOfAHWBa8dBIMIBrP0gay/dv5wc9
	5Gr7SKWXiblv0anyqHqGfgZZLcrrrs8CGu1uQI/PNWdTKyQEtqqBvGuCalQ/zfRgKOJ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169701-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169701: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 10:09:50 +0000

flight 169701 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169701/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  614 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 10:23:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 10:23:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312717.530054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivsd-0008On-2E; Mon, 25 Apr 2022 10:23:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312717.530054; Mon, 25 Apr 2022 10:23:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivsc-0008Og-Td; Mon, 25 Apr 2022 10:23:42 +0000
Received: by outflank-mailman (input) for mailman id 312717;
 Mon, 25 Apr 2022 10:23:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivsb-0008OW-VE; Mon, 25 Apr 2022 10:23:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivsb-0000gZ-S4; Mon, 25 Apr 2022 10:23:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivsa-0004c1-TS; Mon, 25 Apr 2022 10:23:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nivsa-00031O-Sz; Mon, 25 Apr 2022 10:23:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IGn/dj6n0CIvBrERyxC8wRvlY3S8FB4OTfanW1Sok2o=; b=ax9dYbG7bQIFgdbnwQb7Pe6+oh
	5bk65Ck7h8McIhmzVxsmtwlLfKymGaAQ6eo3G4YJ1iLLaajysVubbmPIgKLaF7m3B36ikt04Fmg+4
	HMB/LMZe/h9evpe5rlgGkvQ5ahBqM+rUxkXJJbA5Ry7Cx5mnfP3A/1y0XfYlLXDhzQW4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169696-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169696: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=af2d861d4cd2a4da5137f795ee3509e6f944a25b
X-Osstest-Versions-That:
    linux=5206548f6e6741fccbce8d95cff8faeba0738c99
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 10:23:40 +0000

flight 169696 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169696/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 169686

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169686
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169686
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169686
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169686
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169686
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169686
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169686
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169686
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                af2d861d4cd2a4da5137f795ee3509e6f944a25b
baseline version:
 linux                5206548f6e6741fccbce8d95cff8faeba0738c99

Last test of basis   169686  2022-04-24 19:39:50 Z    0 days
Testing same since   169696  2022-04-25 01:57:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dietmar Eggemann <dietmar.eggemann@arm.com>
  kuyo chang <kuyo.chang@mediatek.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Peter Zijlstra (Intel) <peterz@infradead.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   5206548f6e67..af2d861d4cd2  af2d861d4cd2a4da5137f795ee3509e6f944a25b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 10:24:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 10:24:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312724.530065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivtn-0000bC-CE; Mon, 25 Apr 2022 10:24:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312724.530065; Mon, 25 Apr 2022 10:24:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nivtn-0000b5-92; Mon, 25 Apr 2022 10:24:55 +0000
Received: by outflank-mailman (input) for mailman id 312724;
 Mon, 25 Apr 2022 10:24:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivtm-0000at-2E; Mon, 25 Apr 2022 10:24:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivtl-0000hD-Vd; Mon, 25 Apr 2022 10:24:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nivtl-0004dH-Kn; Mon, 25 Apr 2022 10:24:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nivtl-0003nH-KL; Mon, 25 Apr 2022 10:24:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xy0RykCEM/ukvGg7j1wBTaXzCHKs714EVcQEBMU7Xgk=; b=P0YPbo4ubxYHsvNngbf7WIkZPw
	SucjMdXD22gdzOxBTvvlyUoygTfRZxjoqT7JgSHWPSMFiQ5rLpuMHDbHPDDc4q1CgVBpvNlA074Qd
	ksKQlAkDNRPHszlPaSHTl6HvUxOysAlYN/FxC9pl0+pzBb0uHnmnJtvZPBajkNL447wQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169699-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169699: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=de0a50833f91ad934d5492125b2d636c86a87140
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 10:24:53 +0000

flight 169699 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169699/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              de0a50833f91ad934d5492125b2d636c86a87140
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  654 days
Failing since        151818  2020-07-11 04:18:52 Z  653 days  635 attempts
Testing same since   169640  2022-04-23 04:18:54 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 105272 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 10:36:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 10:36:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312734.530076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niw53-0002Mr-KN; Mon, 25 Apr 2022 10:36:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312734.530076; Mon, 25 Apr 2022 10:36:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niw53-0002Mk-FS; Mon, 25 Apr 2022 10:36:33 +0000
Received: by outflank-mailman (input) for mailman id 312734;
 Mon, 25 Apr 2022 10:36:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niw52-0002Ma-Ez; Mon, 25 Apr 2022 10:36:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niw52-0000t9-Bj; Mon, 25 Apr 2022 10:36:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niw51-0004sA-VU; Mon, 25 Apr 2022 10:36:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niw51-0000Wj-Uw; Mon, 25 Apr 2022 10:36:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IfjksvrcnoRx0eincP1cZJPlZFkA2hYDJVzwI8RFf1I=; b=eXdZB8PGyoiU4liYqedOIEbdqB
	OvawV65QIFz0qe/xt5hTJN97/5YsdOxiLrtY/DwDYK8gZyQVYpRwTR1onU+2SVUcgE84uDceaUiH4
	gBsnoLiLK0c5I7vgyQRJSPBVWwYhLBIAOCvPVPG9ZMUFbw+fpxVVJX8UlC9e+pWor5wk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169702-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169702: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 10:36:31 +0000

flight 169702 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169702/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   55 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  615 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 10:46:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 10:46:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312744.530087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwEd-0003zC-HP; Mon, 25 Apr 2022 10:46:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312744.530087; Mon, 25 Apr 2022 10:46:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwEd-0003z5-EP; Mon, 25 Apr 2022 10:46:27 +0000
Received: by outflank-mailman (input) for mailman id 312744;
 Mon, 25 Apr 2022 10:46:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niwEb-0003yz-OO
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 10:46:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f36575da-c484-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 12:46:24 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-7QKDvqdEMmiiX_QwcYCRbg-1; Mon, 25 Apr 2022 12:46:21 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB4377.eurprd04.prod.outlook.com (2603:10a6:5:37::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Mon, 25 Apr
 2022 10:46:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 10:46:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f36575da-c484-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650883583;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=2IyVjbV4+UozLbWszz088eBp53KB5rBQs/D2spIZ4Eg=;
	b=S+4rPD4YwsHRfcYM/HWoVLiVdt3O0LnoigR3LWy2KXou26kCg4WWeQwJHvnGGVnB9xAIxc
	hJv0dTRXSvwtyw7gSCAZX/e6pOgsrSlzwxknHs85Ds6Wz5sam0U0vaI6EYgRX3j2zO4102
	fULuD5MhAkFN6riU21imipkiBcjlwPw=
X-MC-Unique: 7QKDvqdEMmiiX_QwcYCRbg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JdJZk4Jev86q83corYMJ/iAju7wV01Br4x78DBxCJXMYVKoRnt6q6tOONR7bCouk5tCZnWIXn3s+YhofZSpkMa+UgPEHCoKvZ4UcY0SatLArbWaLEvKSpjNpUxQAjUzMU+xC3lG1Sts9YzfCjsaxhcBcEA6EqPozf/R1JFFIBEU4Y3wsx5QzeJM6i2ncjSZfbj9NuUYTxB3Mwa6dEwrliX48MhkFTJzXS3rTpeFN+wdpDaCvlTfc3bbrodxUCxT/+9EnEb9+bGZibl9C7iF2O0AsJO3DoFRkiBK/c5GslpfiKyHOk6tbhZHji0c2XwIEMLzKrKndOAcXIqITxr01nA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2IyVjbV4+UozLbWszz088eBp53KB5rBQs/D2spIZ4Eg=;
 b=eO9qSrNSnd4/KvbjVNYnnCPT5LzFQ+dBfkx3B97mDuKif8S2wRSEJ7E06Q8ZnalAbO9581NRkrpd46oSDEEU+fOuEgx8pzkJzXSnZJYDT7Mz7AFS7buNAeGmB+tldbo06+aZV+8NW++TzZqlmffaHhWE8tF4BlqypHqS7djChMNkfedkCb5/HH7YHqloWc77gzcYwkydJi+NVXQLSVJKBX3qpx7pZCOoXpL9kjE6zsfsG0k4V2AUuuiFuntd+Goyv08Jwnn87758AbECCpDIkBivJseH2aR74Qm+Dx7OT3SRGEIgk3JIgc4cAN1FMuZHrSsYlzDh3vSpLvqAPhc/jw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <394c1b94-beaf-bdcb-c333-65dd9987be54@suse.com>
Date: Mon, 25 Apr 2022 12:46:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH RFC] EFI: strip xen.efi when putting it on the EFI partition
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0088.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::29) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0ea2bb26-9a84-4b51-0a8e-08da26a8d4d6
X-MS-TrafficTypeDiagnostic: DB7PR04MB4377:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4377BF6A47376826FB163D11B3F89@DB7PR04MB4377.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RBr1rDrryuCt/uQz9VSJSsOdT1yt02oXVMO6iBJ9FjIxIOdt/vA60URIWRxYwT5U6kcslcYlol/aWhIbihEB+xQCFcL1YRFTQc1Oexw55QlqsK23bIWjNGdyeRxwATK237JkhPQKDoi6Ue6OBapHDPUaajBzZgJ27mCwfj2bDXYpM/R+YW4Azq1QmBGRM1DmD00Uc4vb1/pw6dgln5uO/ZPKLZO0FmkV0kLfhXgc+SizeUDZByJdc08vi2oCbDg1QM1TO3wPFmskRRRcxqa1VFsNOa8YfD/usBgqldWF8JXj+ToLRktIVJj1BnMxfHVEup0+BF5EFGUoEQyYPqkwPL7lk+fE6h58XiSOD/2tjqa3soSlOrv+kFTrNQmRjdQq2U3nao1zhcG1mAYcl39Xkho4ItOhy1i8TpCPUDCngxUTFVepcrT+H9K2/AH0fjXYNR0D47kaSWmbpGKYtRf4krNxVPdCxtnliU6rPDgjtD5kFvSR6wy1tw5tpUfH+H0eeMP4GUaTHVNDA4Iqv7yvudx3PlzxdDIr5FxiPYeaZwS1FGd/ynfgIXNu2KnP0olvl65zJpPHqQnm5T1atkeofCQe9cU11wArAuBp4HNFNw3v2FO4oeuzN+w8trCCuJQ+DcK/KkoeVN54bGTOeqMWZy4+RVcpd5SUp6RJ9z5N6g0+nGpG1ZQGtliwnhdSnTDKqwv8Prc99JnIfE1W8XfyP05ptN2k0qL268zOP1ue2EA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(26005)(66556008)(5660300002)(186003)(6486002)(66476007)(8676002)(54906003)(36756003)(6916009)(31686004)(8936002)(66946007)(6512007)(316002)(508600001)(6506007)(83380400001)(2616005)(86362001)(38100700002)(31696002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVZYajB1NiswcU1FRHFQckJoSnY5Wm83bzhHcGJ6Tm0wRDJQczZMVjlCQ2NM?=
 =?utf-8?B?Z2pXQy9TaVVjY3llNGtCM3ZjYm1WUFBxSENPcUduQXV0bUVhZlpRWmZNVkhC?=
 =?utf-8?B?OFlubU1teHdhcVBmQ25EdDJEUmpyYVJxTFFkbFpDZHBGaDVzemRJMFhuNito?=
 =?utf-8?B?NGx4dVVTTTNzRng5NVdiT1R2WWYxS1Q4ZWNxQ2RrMmZsMzBERG5sbUJ1ZUhW?=
 =?utf-8?B?bkFFY1VUbkd2UU8xUWJuRkdqQnU2UTZKai81cE1RYktyc3Z2VGVwTUd4SS9H?=
 =?utf-8?B?UzFvWjN2SHg2WXBKbDNOQ1dzcmNmSzN1dmdhNWl4NE9MZkE2T0JQTnZ6TmJH?=
 =?utf-8?B?QlE1MCtaYlRxN1NVRXhabDVXeUgxeVhrODBpbmNnYjM0U1NxelhpS3E4QlY2?=
 =?utf-8?B?VWZTN2JjUDR2eVdpMS9NOGhyTUlibEkrNElReTJKU3kreWFPcGVKdWI2UDlI?=
 =?utf-8?B?UVYxWjRRNEExdklYTVpxVlV3VkhjclFuOGoxOS95K29FSUJGemRXQzl1YlJv?=
 =?utf-8?B?SU40QWFtSDRTbC9DT3l2eHJYK0hYNVZrcTV3YmRPZzhNeUkxM3YxZmdLd2M3?=
 =?utf-8?B?Y3g3TkNsM0RGdk5wQzRHMGsvWGIzcjZKMmNNZHpWbXN1M2lmT0I2em1QV1o5?=
 =?utf-8?B?bEYxTHlXN3I2SnZweVpPUjlRYjhZVmN3RElRSnMxeGpDL0xTR1h5aHVrTlht?=
 =?utf-8?B?bHR5S3pveC9ENkpQSHRXNWlTVEhEMG53eDcwWFJFTmFQR3VIbFNZNG1CSlgw?=
 =?utf-8?B?bTE2eHp6eXU5bnRRTTNNZUZMayt6WWRaVGh5STJFUDBHZzNUTGdVWGROdU1z?=
 =?utf-8?B?UU16QzA2Sk9vcWxyc1l5Y1dDSEpsNmFRaGJJVVB5MFpqZ2VuekhXMUxhR244?=
 =?utf-8?B?M3puTGZZRitaYXQxM0tqdXZqMTlQOXBGYUthRTVCQWtaWkhZdUVqdTVkaWxI?=
 =?utf-8?B?SzIzT29uMUR4OEpwUWlrVGxjKzFvL1pVK3BNMmE5UzVPbUdkc0VCeE12UFFi?=
 =?utf-8?B?cDVNbXFsVmdXS2dWTXErdUFkVE5TMnZ0NFRyN0FmbDJxVjRwU0ZLY2ZPZFNL?=
 =?utf-8?B?STAySjZiYk0zOWQ2dDh3Q1IzTkplc0R4Y3ZVWTNkdmxBZnJBVFM1K2NXYm1k?=
 =?utf-8?B?S2FJbHcwRTlYUEFXZWpKbjluVGs0MUJ6WEhEVVBITUJManNJTmk5TFI2SGF0?=
 =?utf-8?B?QzdDVnBtdlBKb1QwOXpRbjJCY2dMUnZHMmF1dUllQkd4cHVFODAwMnZPT2dp?=
 =?utf-8?B?UjdMczlxRnNrYUc2eUl2WWlWQzB0Z1Bjby9CSDQvQWdGSytVcDVHVGUxckVm?=
 =?utf-8?B?WXJaaHJCWDR3YWNDcXFUMHNjcHhPeVdyWnlncDloMTk0NHJjTFFxSFNiNG8w?=
 =?utf-8?B?YnRzMk5uWTlOVUlUdGlWRlMrUm1SMlZCSXoyY3NYdzFnNkozV05pOTBCMHR3?=
 =?utf-8?B?cmhjNHNDWUhxWE9ibWVoTjV0MUE1bGhjck1saERGbk95ZWpMbHV3NWFXSFBv?=
 =?utf-8?B?b1dkZ3Z6ekxZc08zUmZwWGZuSHNXWmxOb1B1dlpHSGdIc0xGY3FwQk1TNDNX?=
 =?utf-8?B?OTVxc1gxY3FUd2xhN0ZXWjM1UG10WDcxd0NTRFJ5WExydGJDRFNXQ2lSMkJk?=
 =?utf-8?B?L2xWQ1ZNdlNURUxQeVA5Z0FCbis4THFoZHRMcDBYMUtPbVByN2I3M3IxRjJJ?=
 =?utf-8?B?T1RpWHlwWWFYckg2OEp6WFV5eW1QS1pDeTdwZXFRRTJSOGR4aktpZmt6L0Iy?=
 =?utf-8?B?U2VxZmQrNkZCZWV6QmVFcUkyOHVUMERqSlphaUp5Qk9OQ0ZtY21nN0Rub3lh?=
 =?utf-8?B?QWNlSWdQZXhjWDViQnZrR29TeUJTOFJDM2c1cnhrd2FRajZiRFE3UU1UaERM?=
 =?utf-8?B?UXd1MzBuSVczdk1QUzlCMGJYNnZXQzFxMWg0Sm5GSVFONDhUTzd4ZkwrSFE3?=
 =?utf-8?B?OXV0R0FIU3RjSVRHSTZjMDJ2MTIyVy90S2tzdUxYbUJtN21rc0VWWHUva3ow?=
 =?utf-8?B?VFJpNDRsYkU0Qk8xNUZDSnJRMlh5aE15WU1CSWRyQkgrMG5IMUhBbmlGTEQ0?=
 =?utf-8?B?VjFnR1RSTE4rWWpoWE9VWFJ3cWlPZlY2Yzl2UzAyVkhLai9MRmF2Z1dKUnRy?=
 =?utf-8?B?MEd6dlBiTHlYcXBwSTB5bHAxQW9MdllPaDdEY2xYdGdLbGo2ZUh1NWp4Umpi?=
 =?utf-8?B?bFQvUkhKV2o0ZHZtSkZiQzZNOGF0T2xncWwybDBhdmx2SUFVWThCMkpGcGZ2?=
 =?utf-8?B?S3NwUHlWTG50VE9VSUZUSGg5MGFHTzFWdHVYbWlmU2s2R2NScEkwVmxadzE5?=
 =?utf-8?B?dVZYQ1NaRGNYangwUUcyM0JPaG9taXJiMXhTcGFXYzVuRzdkZVFaQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ea2bb26-9a84-4b51-0a8e-08da26a8d4d6
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 10:46:19.4754
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DsQEmnazSdp3T2NTiKal4fkGQfSRx7XLPYFBG/3HEMstIecCe1SuCpNQLsBNPNCx2R1lG1ZCNS667kxcAvCTOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4377

With debug info retained, xen.efi can be quite large. Unlike for xen.gz
there's no intermediate step (mkelf32 there) involved which would strip
debug info kind of as a side effect. While the installing of xen.efi on
the EFI partition is an optional step (intended to be a courtesy to the
developer), adjust it also for the purpose of documenting what distros
would be expected to do during boot loader configuration (which is what
would normally put xen.efi into the EFI partition).

Model the control over stripping after Linux'es module installation,
except that the stripped executable is constructed in the build area
instead of in the destination location. This is to conserve on space
used there - EFI partitions tend to be only a few hundred Mb in size.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: GNU strip 2.38 appears to have issues when acting on a PE binary:
     - the new file positions of the sections do not respect the file
       alignment specified by the header (a resulting looks to work on
       one EFI implementation where I did actually try it, but I don't
       think we can rely on that),
     - file name symbols are also stripped; while there is a separate
       --keep-file-symbols option (which I would have thought to be on
       by default anyway), its use makes no difference.
     Older GNU strip (observed with 2.35.1) doesn't work at all ("Data
     Directory size (1c) exceeds space left in section (8)").

--- a/xen/Makefile
+++ b/xen/Makefile
@@ -461,6 +461,22 @@ endif
 .PHONY: _build
 _build: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
 
+# Strip
+#
+# INSTALL_EFI_STRIP, if defined, will cause xen.efi to be stripped before it
+# is installed. If INSTALL_EFI_STRIP is '1', then the default option
+# --strip-debug will be used. Otherwise, INSTALL_EFI_STRIP value will be used
+# as the option(s) to the strip command.
+ifdef INSTALL_EFI_STRIP
+
+ifeq ($(INSTALL_EFI_STRIP),1)
+efi-strip-opt := --strip-debug
+else
+efi-strip-opt := $(INSTALL_EFI_STRIP)
+endif
+
+endif
+
 .PHONY: _install
 _install: D=$(DESTDIR)
 _install: T=$(notdir $(TARGET))
@@ -485,6 +501,9 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_
 		ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi; \
 		ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T).efi; \
 		if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \
+			$(if $(efi-strip-opt), \
+			     $(STRIP) $(efi-strip-opt) -p -o $(TARGET).efi.stripped $(TARGET).efi && \
+			     $(INSTALL_DATA) $(TARGET).efi.stripped $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi ||) \
 			$(INSTALL_DATA) $(TARGET).efi $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi; \
 		elif [ "$(D)" = "$(patsubst $(shell cd $(XEN_ROOT) && pwd)/%,%,$(D))" ]; then \
 			echo 'EFI installation only partially done (EFI_VENDOR not set)' >&2; \



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 10:47:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 10:47:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312749.530098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwFa-0004Vl-Ra; Mon, 25 Apr 2022 10:47:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312749.530098; Mon, 25 Apr 2022 10:47:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwFa-0004Ve-OW; Mon, 25 Apr 2022 10:47:26 +0000
Received: by outflank-mailman (input) for mailman id 312749;
 Mon, 25 Apr 2022 10:47:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niwFY-0003yz-IJ
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 10:47:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 16e6f593-c485-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 12:47:23 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-xSdu224CNzWfkOmkjINSUg-1; Mon, 25 Apr 2022 12:47:20 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM7PR04MB6790.eurprd04.prod.outlook.com (2603:10a6:20b:dd::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 10:47:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 10:47:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16e6f593-c485-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650883643;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=gSHZrWWi42V/brh4EXJTJNbSe9aBFjvHmxN0fNwYBR4=;
	b=lCIqY+aLKA03YsIky/6uF2ilA6pUrpuyOVNtC6G4yKnP5lRsUJ/BBvBbRTYuVljmDYovtu
	uPbV1b+WoEdxnfv535UmDolPi8QHbka1dcmblcb0fSYNKwu6mZWX9ALXGBj2ktnTA1r2AR
	ezfDHoUs8Bp+rBJiRXPQSVYtkNFbJHs=
X-MC-Unique: xSdu224CNzWfkOmkjINSUg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gwkCsvwCqPq6Yp5f2zzM2NxLnB8q6/4V+aIqIlhwqTN4R4Xt3HrfiFaHenKEGtnrgS8WUNqF62xIZ3Cd9lg90x94Qlf8ArQb4rlqUNuv7ynN6DuPRCEV9pNzcefmKTR4r0KPfjW8MUaypS2qOQhSKjSaFCG64S8wlqSZYJ4a4EIcZz+WlAyd3/oqVNKcWr20wwfFP5CMt3A0boeA8dwU4hpcaah4U+cSxeOfQ1k5nfhKLGCQkso6uZPAZTzhH1JOQkTsao1RzwhgW5l43jwrB2KQ83VTd5uVX3VFvGUf5LuFvjjzCbYBTtzTQ+CPrxcxjRhSKIc3mNRC4R1lztx7ZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gSHZrWWi42V/brh4EXJTJNbSe9aBFjvHmxN0fNwYBR4=;
 b=LKM3ZAo7p+3+02rZ4Kkrz0k1fzf3oaU5edF2fJp8b8I1VUZwwWRSi+3bOgl7PjPRDFWy3bRMlsdV+Eu0RdY0vaxHmCXH545y1PcRwxGLKOqafELNvLwLubXtdx5O2+n3qDrznTQueWXB6b031GPBxSoY35LWR8aJhL101G9u24SJ06cx7daJjSKnLQjc46aYrFMtdiPzPhrRh9pVd7dk6GcFimmkd6Vt8HiZ03dZiIZuimXgr8Udt/JT166nvqf2QYV5U55+qUS1i00mqfwN9L445I0aSht5cd6xGx1Rjh0u//fgCYBAn0eZqLlNjHELhJc2y17X/goB5lUR9/n3ig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <55e50138-1d41-1e79-f269-df875473b1d2@suse.com>
Date: Mon, 25 Apr 2022 12:47:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] EFI: don't mistakenly delete a file we never installed
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0084.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1c954a15-e5fa-4a2e-2da5-08da26a8f895
X-MS-TrafficTypeDiagnostic: AM7PR04MB6790:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB67902FB331FF41F9C8B8DD4BB3F89@AM7PR04MB6790.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iPO/yqEOFEcdTXEvezUXDHIjKod4ctjpRxg7Bwc4F6a3VnpSqJzUjtaMz0d+yz+H1ZcAwC8oCTf2E3oCsP7JPr7JBLro3PQfqIi724FiDEPIGNb+ffbDUmeQhlpjsnbQtuiQf2FaivWIMNEmKdQI/OJCIXeZKrnwX7JT5hN0Y4HklURpOfe6dY1eaHV2VYOmZDVcO6H0bZmKmq3hhVaZyUTYcyt8+jpYYpwkz/cbsjcGxE8EYfcYc6nhWS2JTinizl4NtbOTxzM/4mpRC7OhG+hJYioX1rQuO/8iC3pegncTGtgUrHrYX4u6LZ7zch/pn1teYn6no4ho+QcypoSlUgE3kFqgXUk4eig+lTignLeIoGjL1VWAFb2D0IOtrzuNZoFsT86EL1ylgfBhAaFTY+p03UWHmxkCzycXSwvGFovPXBXHXH319SHstB3yjhAEmbOg2CypEtSpCV6RjfiwW5czpu2KntTkcw/mM1ehLz1Bga8RzOfNO/uioqBC/YVceW9zq6cJzg1+zSeSbwByfVU0IT/PRrIAOsxmSFaeE+fy64uAp7+VLZrX6uvwSMSPocZN/RrVXmtKO0vA81JAfqgZ9GqLbDsR9QFeGqWEVW/2ltsWaYkd0SLV5QRC0lDMb49EMX88QuF9C+37nNDs0jL2U0uZyX7eTBk3s4TEUacUHY4OLT//njMg2//NWBtrEinmD1G5ryWBeZQ8I18hMmmRJakv2d/QKV+QbSiDpirSiaCYCE26U0ip9u9+wZBj
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(66476007)(66556008)(2616005)(4326008)(66946007)(186003)(38100700002)(8936002)(5660300002)(36756003)(316002)(6486002)(2906002)(508600001)(8676002)(26005)(54906003)(6512007)(6916009)(4744005)(6506007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dEl2SUZpK2JidjdXUkU2RXdYckhGNXJYaXNUWkk0Ui9QM1pId3ZLSWJNb1BG?=
 =?utf-8?B?NDhHdnpkbVRuaGgwL0FtWURTYW1TS2tLZXVwZHp6dWhsNm1pRXlVSWk5RWt4?=
 =?utf-8?B?QUozZHI1QUh3KzFrankzSEhaVW9UNzVaMDdOMFlPUDU5TzJwTXduY2R3YWFr?=
 =?utf-8?B?QzhkVE52SERCMGxXM21LcUVTUG54dWJDWmdQdGl5clp5MnZFeWR5dnB0ZHZQ?=
 =?utf-8?B?Z0c1UC9EaUxKYi91cVBkRDNzSTBBZlk3VXlNMENNM0kxK2FPbVhsdnhtVXFi?=
 =?utf-8?B?WlRzSlo0RlB5U1V5WEY3dFo4ZXZoMVQxdXNLSm90aVZjckpzNWlyRjNQaUVM?=
 =?utf-8?B?T1dHSGpFN0U1SUprWTUyenhEOXh3ZnhCOGtEZFNKL1p1R1VEbFp5em9WTHZ3?=
 =?utf-8?B?NjI2cWxYVmZWRHVid1VGakttdTZ4R0VJbG5TRXRuWnZvSXJLdHNuZkQwRWFy?=
 =?utf-8?B?SE9VS1NzL3hwNDVHdDBIbHkrY1lFZFErVHduT2thSmZuTGw0d1RUaTZYY1N1?=
 =?utf-8?B?ZVNSK2oxclY5NDZTVGJVYWora2hzSzFPd00wQ2U1YzhsWkhaSHFwWExaV2Zn?=
 =?utf-8?B?S3dRMnREeFdOWTI5bTByV1RWZUJyT3daMnVDNXIvSzNjQk00STE1K0p2WWxF?=
 =?utf-8?B?R3k2YTRjZDZITllmaS9MTnM5REMwRWdmQ1dlY2NyUEFhWUY4NjZVeXJCcFJ3?=
 =?utf-8?B?U01uY1QvMEFUR240eTNEM3F4YzJ4L3RISDhtQkpWY3ZteVlRa2pFb1JuYWFX?=
 =?utf-8?B?Q3I5UlQvZ2JSM2grdjB6QjJRa05vcnZBa0VPOUhtZUlodWxjWC9Mclo4UmRB?=
 =?utf-8?B?L2twcTIyZWlmenBJSHlsUSs2MXo5U245TWc2QVNmWi9QZm94Yy9pMldtQU5B?=
 =?utf-8?B?T2p5L21HUG5YZmdRRjZpeDJ6QTdNRHQ0LzZnMVZLMmhMTWV4T3pLWlZvb1Br?=
 =?utf-8?B?YjNRSExtTWQ4MWdqdERrbThhbnhFRGhIY3Q0SXFGWjhNeHdWMkpGNFVlcm50?=
 =?utf-8?B?dEl6T2o2eVJLQzZueGwraTY5MVJ0VDJvTEw3RDJXYVpIYks1ZDhpSCtTUGt6?=
 =?utf-8?B?N1ZTZjNzUWN1MjBweWtKbGZqc1VKbGJPZTFNUk95cDE2MzdYWnd5bmtZbVdl?=
 =?utf-8?B?d3gzdnhRMTU0RjJsVHN4aE1sRTYwZE9hYndqQkptZHcydE0zbUZ6ZXk3dENX?=
 =?utf-8?B?RXEwVFkzU2xUd1dNRzBKdDNJbHhGY1pBMm1uMlRDeFJMVW1VOGFGOHNGSncr?=
 =?utf-8?B?QlFEWnk3Ull6VkwwdjBVd29rZGs4ZVpmRWFrOEw3UzJCTzlLUWRGZzVxajBz?=
 =?utf-8?B?RVlRanQxZUd0dWhDU01LQnIvU1RxNXRselNJSE4ybmhCdUthcnZnVGZRQVAx?=
 =?utf-8?B?dFdjMkQwMkNTWGhGcFFjRDZDRW9lcXpWN3d0amhCOTZ1WER5UDFIbndmdm5i?=
 =?utf-8?B?ditSR1lvRklsRkFPc0g3ZklpcUE5amlMQzZoNHNSZWNhd20xSkdOOEdmczRu?=
 =?utf-8?B?em55NkpYNmhtUFJYLzRhVUFSU1BXbzRNdUUxR1BsTHAzQ0YvbTRRM0FBV0hl?=
 =?utf-8?B?YXpzUERXL042ZWYrQ0YyL01sMVIxTTZjbTEvSk1vU2xPTmlSZ3lEcTk5cUp3?=
 =?utf-8?B?SWxyZWNTU0lpYUphV2hSRktYMFRXT3U2Z2pRMVhSM0Q0dWhKWFZwdEYvT1ly?=
 =?utf-8?B?enhTZ1M5aGE3Wlh6eWVvbkdDaHQ0UWc3OUtBaGUrUk5va2ovVFd1SmRsQ2o0?=
 =?utf-8?B?T2dTd2U2ZXZaYTB0UG9IUjdBVHgwQVZTZEFTRFFkWDZvQUY5MHRVVE9Cb3dB?=
 =?utf-8?B?WFdITmNyK2lUOHM3M2JtTEZxdUdERmYvdjNIYTFwQzFBKy9wcGZobEFvWTQ2?=
 =?utf-8?B?OFlaSmx3L1R4RFZKc0huTHdqbUVUb01FRVRmYXdVQ1Myb0RsVDNYVW9EcS96?=
 =?utf-8?B?YkdLYXRZaS93Uko3Wk0rQUlWdURUZWFrUVZhVzlGNGNaS0RKZWozTllyMDc1?=
 =?utf-8?B?VWRLU1NTeUZvRmYyVmFpdkZKeFNBSEwwNXZoSFVsTDhMYm5EWExRa241bXdx?=
 =?utf-8?B?WUFLaHd5bkVHOXZXQVcyWHZSclRJTUc0WnhrMlAwVlFLZEw4YXhCU1dxa0Vu?=
 =?utf-8?B?ZnZxdE5odlk3eVA0TW1CM0hlcDEwd1QvSGNwQy9vYkJERmp4VlZtS3JCSnFN?=
 =?utf-8?B?UHA0TWhTZHFOVlJhcFdhazIySFZXSFBsKzRLY0RleFBKNzFDbVBYemFOZXFt?=
 =?utf-8?B?L1JLNEEwMGl0WGQ0dG5iN3J1ZXl1YTJmRFk3UFMzYWRXNUJPT1FBYUNubFRH?=
 =?utf-8?B?bVBSWGozQnNYNTJMamZPLzBxM1doWnJ0K1praWg3anBxREE3VHVaUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c954a15-e5fa-4a2e-2da5-08da26a8f895
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 10:47:19.5108
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +ClO3u/esT8/DK9dYcyBTs+o/ZVP/IxqdGIZ2Tbdn0+OOLy9JNVtRZjvC2Gm1TAeZMGp657YeGoEUSSDG5gYqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6790

Just like for "install", make dealing with xen.efi on the EFI partition
dependent upon mount point and vendor directory being known.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/Makefile
+++ b/xen/Makefile
@@ -515,7 +515,9 @@ _uninstall:
 	rm -f $(D)$(DEBUG_DIR)/$(T)-$(XEN_FULLVERSION).efi.map
 	rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi
 	rm -f $(D)$(EFI_DIR)/$(T).efi
-	rm -f $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi
+	if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \
+		rm -f $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi; \
+	fi
 
 .PHONY: _debug
 _debug:



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 10:53:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 10:53:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312758.530109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwLC-0006Ds-Kz; Mon, 25 Apr 2022 10:53:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312758.530109; Mon, 25 Apr 2022 10:53:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwLC-0006Dl-Hx; Mon, 25 Apr 2022 10:53:14 +0000
Received: by outflank-mailman (input) for mailman id 312758;
 Mon, 25 Apr 2022 10:53:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niwLB-0006Df-VC
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 10:53:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e70b25a2-c485-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 12:53:13 +0200 (CEST)
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03lp2168.outbound.protection.outlook.com [104.47.51.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-fsBYCsJgO3agIUnH_B4XZg-1; Mon, 25 Apr 2022 12:53:09 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5038.eurprd04.prod.outlook.com (2603:10a6:803:5f::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 10:53:04 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 10:53:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e70b25a2-c485-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650883992;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/ZfP6s02toHYPEMp6mxxnFkTVTPvnTh1FhSdVHQfn84=;
	b=hhuu+sT9V89Rp62JnHjDXGz2m8qPgRnvHHndJZoMarPBrYxFceUPwP9LhLvrtVZhy4OG5k
	afJ7Y8be1FVBY2Wv7yv/gQiDknLDNJbAisvIdqKSt/L6hj2oi4OFrMy6m/+dBDSU+L391a
	yFtdFNGpOTtQpOvL7UwV8rutVrvfIwE=
X-MC-Unique: fsBYCsJgO3agIUnH_B4XZg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SGOd2w1/9yRf0b1siVodxQXJikefAkVFmU/tTSHikwnvWG1CmDTfBnOxLRf2z1Cra6Q+LLgCO9RvjypPe+3t5+fOu9Gmt8CaA1/YPpwarQRe/lJA+CRs9rncKIsL03cQXZpy7h9LyDQb7xUrRpoxwxqvVQGwqsoQ2gXvMgcWdP81byoVjHUyhDkcpBpAT/4ZwIxKdQEh25F27YYXxPHq/wdNyHNRUsy0FXfpt67hKsRKeT3q0h68fWnKHcCodaxedotpo2On9qgtTRUvQVjPf6DqDFFsc7aj3bgr6NYyLPGYW3WRh2nD3ThwD6643JRvHdlpdvjr6nTv3bXkEnkMnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GWlv0Hwx6m3KHUiLAt+bvdpKPj6a6h2mjmmvKM6k8sM=;
 b=e7a0PW6hnVgqlG1D/d7MPxKA9z3sOlO1T0LKfKFgLp2R2F+Lv2K3kZsVCCGZLtL2Wo5vIqzBWSMc69eDl6+LuH9ol864PC53x/baVFPjGowiZ6/Vu27OGza2Tsub6qxmyEktYXlQbpn/syB+abHStWI7O3XfFURzHktEVzN+jhGw5XooyXshyLHj/mCcCsjOSXln66lIFCFDhXSSkJPXa2iQrGVh3sompcETFf9kKT11OP4TlqDpxoMOoY7f6Onsqh6DKHEqUCiivBqliwDte4Fd1OYFdVZhNpFkigLKLaH/gV8MSf4MeK01J/wDXomM3pDsqd8v73lO7FuMQ4S9KA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1c2875af-bb9f-38ef-dd06-c74d0c20e7c3@suse.com>
Date: Mon, 25 Apr 2022 12:53:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote
 after setup
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
CC: xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
 <20220422163458.30170-2-dpsmith@apertussolutions.com>
 <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0354.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::9) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 81e1aed9-33c2-4db0-46fb-08da26a9c665
X-MS-TrafficTypeDiagnostic: VI1PR04MB5038:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5038CAC9E4B2B5D5178F2289B3F89@VI1PR04MB5038.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QDBH0ogEBZnacSSt54RRSKYp+U0F5MxIhujIKVAfG3Wt+h9QVNIVD4NKhwlTtbk2ANjscYUG1XVkgwobMpVA1ZzuQK/n6FW+lIpjRlFnnzKcej1eDpIhZfxJ1UUcEiNw1MtV3xAy9HoZmVF8GLem/pOQFERcpKxDm31AJ3aFVM88J+4lVfL6sUGAaqXSYB3+p883fltOUtyZI+23zSJQh/feFX2r23gz3To9yLZ04LDyKlS0ui1ObatOThLb0bza2BRkGf3/gByvpWG+gPz93HA/6BkoqIRkEh3jNSYSJ8e7XB40sAFMfqMgnXBnwPytTabLPIdHvwi1DkGVWJMFbgAsTLqntqPC6/8vpRECK9LoC3Wj8W+M7e0LZKDHzKz/Sn0DmGy5NhSe5kYMOfjqRUUoto/7+Mt4KTh3e4ImVrtrHKDsAbqbLGL+kxAsoBhPhXqEFUKiHxuNjepuOwRf4mDDcl3nDfRQTD9Wfhc0Dny/7L75EBcyDg3L9LkIzxzmNw5R2B7PJRywDLILoSIXZ4PRl/GfDECexnfTYs41zxag1Gq4KgvW3qRBRPYLjqFhpHKK1Q/IisFSpRGiFzlYw3DFsHloIiUJw2v7vj87UmB5eWS5gBlN7K0uoqbLSnAJv2YwQLzgoZo8epPdw28DxNxj/5y0GkRR3vNOkNnn2Fvc3vgke/yyuA5x99cgfjVDhCxkZPJSWrmFAGctuMDR2fvUVhWoOxEgZ4yzkYnlwxE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(5660300002)(38100700002)(6506007)(316002)(6512007)(53546011)(26005)(6486002)(110136005)(186003)(54906003)(508600001)(2906002)(7416002)(8936002)(2616005)(4326008)(36756003)(8676002)(66556008)(31696002)(31686004)(66946007)(86362001)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MRRronChdPPO7u8LyK6WSqnUHZYap++NsGmFfuCBG3D24pTsqEmaCw17VWMo?=
 =?us-ascii?Q?YhFP3xk6TprBjk6HQj40jqoX7gw8YHizgLqvGyT7OvrNhZL1RqL1t0rg/3Ng?=
 =?us-ascii?Q?qitjSuqU6QyW0uo2g5zjXZgjeNlybqkBa3zrp2Q1D/cPfMJ9k3BYf4HocX8u?=
 =?us-ascii?Q?s1vQQ6fSbEhyBWjLhAen33MgFWKQlLZkWcV+MK9TSOcn21ACLfIFObAr04wQ?=
 =?us-ascii?Q?RvGiztClwBxSF1hddCZCGhK8rUOOnbp9UuHRkqTZglu45pihTmt/QSo95EEO?=
 =?us-ascii?Q?Is/TlIEHlQkq6rj/t3fN1PprVKfhu5ONB0gatk8TSOIE6XmGXdRIuK1D1JZy?=
 =?us-ascii?Q?AErVytbe9Oddo6NUCB2Ngm9G0HQwYwy8rlKCUiz+owgy2im59fNjvbK6xbe3?=
 =?us-ascii?Q?G3VWW5bmu4rvpySa84lCFtUmeBH8z4cYnu5P2tuisGp4saRsCenZ1/W09uFr?=
 =?us-ascii?Q?9hNn+Rlpvnhb2EG1W56vBNIE9e5Rd/5jLEaahpc3x9/ZQW/7NoMR5o0hmm73?=
 =?us-ascii?Q?YVxRgAoi8emhpAqgJlkF5vmYCTrhoSnD2CVk9Dj4iIRyXWYCgEvumCT8PT0j?=
 =?us-ascii?Q?23byn6V8Hds4JlJYrgMBO5nzEFPoHAd1mEto6tdMudhjGzu7D1gJM7qiSosq?=
 =?us-ascii?Q?vSLGVG7jcrZxxsCyO1BHxbZQFLnHPiVhqwmgqjxguDmHPdr0jZSeiD5rqVJW?=
 =?us-ascii?Q?iq8aP45veBmWxzJZ6nQITKJcsV3H3c9BD6sKiNJWbiGc4TFkNEXnsK2q/IYo?=
 =?us-ascii?Q?m1oFdfuCW7uhZuHGRmkCiLZy85qSoeJ0dRaEb8dbzroAM6wffTYR/udroriA?=
 =?us-ascii?Q?H0G2Yj6ReZUKFvVbbsI+Wc8QV61FsR1xrhZ2YXTTRFURrC2nsgG4LBxtp9yo?=
 =?us-ascii?Q?p2WBX+atb35pNjkRuh2nir3Sq6oTmoY8RE/3457u7KkrkgXP4ndN049+g6eQ?=
 =?us-ascii?Q?qeih22HaW+SI5W9F36UgjLXehpSY6+qvFXH2yavarxuM4pKmyNx8HDuvaED0?=
 =?us-ascii?Q?/RFe7Nwn+YCnzi9fMewNbG0fRLaWcRS0jCz0aGEsEwPDMqn0lb4QG/ZLxn1d?=
 =?us-ascii?Q?wjW08Em/CsqDkxyHaJxbCWNWonn6M9iD4e85SRuAnEdDHZz/WBcB5aXBdKIC?=
 =?us-ascii?Q?otsf4SkAzcU9L8XNmr3MdU6E97/CJSc7wT9DTr/KvTfKjKFsEcMYV640GBBL?=
 =?us-ascii?Q?DBuuX72zOUFjlGJvCUQhV1s4+yq6qnGePeXFDjeC7yQN3fofn3sJYaYcTCqh?=
 =?us-ascii?Q?15vlL+SckaeO92XO0RarVtW/CATPAhQloZOsTGGBgaKqxGdZpcz9+GP/Xu6x?=
 =?us-ascii?Q?hh5m1BBgLwHbfVbC8OUw4OpHrP9DQQCAB67UPjDZ2CGbK8WgaUg979KR1dI4?=
 =?us-ascii?Q?x00uLGUJumvpjb4ITm4Unc/iKUX3yB6ybgrePoX2OVvRKdUuYHTOejbzpiTz?=
 =?us-ascii?Q?dJL+EkJNFjqk0weplYZJsTLSj2fHAQYNVnOn327ML6s21DJhj94FRIHkY6M8?=
 =?us-ascii?Q?et27m2L0ZsATl2Moi2Q3FCFNCynqGU3qToERJfVlQd7AfqwA+nuyhPuIEt9n?=
 =?us-ascii?Q?kFnByYBM0xwY7x1WQ7C3IJi9PCsL03iJ8gp0VYQM4TlJ95Pspm/lD+caRyk4?=
 =?us-ascii?Q?PnK8H7yLlnHdNF4jgOd1PQRiYza3K2LxAAB5xXLuOSP8MiFkhjetQYFNiQ0e?=
 =?us-ascii?Q?JCtl+yBmA0REb4XBW5skRkCUYr5ADfR/3NBE/NTYi4VH/R8lF1VLYtdrU4E9?=
 =?us-ascii?Q?9WLibn883g=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81e1aed9-33c2-4db0-46fb-08da26a9c665
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 10:53:04.7763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /TeOEXATsq4Cm2GkY18NWHJKOY2ej/5ies2ERc5q7CU/NIS3HLnb9vm+H/hjp6zyEWKWBl5IzE/Zfj8J00mJtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5038

On 25.04.2022 11:44, Roger Pau Monn=C3=A9 wrote:
> On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
>>      void *va;
>>      unsigned long start, end;
>> =20
>> +    if ( xsm_set_system_active() !=3D 0)
>            ^ extra space.

Hmm, did you mean

                                         ^ missing space
?

>> --- a/xen/common/sched/core.c
>> +++ b/xen/common/sched/core.c
>> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
>>          sched_ratelimit_us =3D SCHED_DEFAULT_RATELIMIT_US;
>>      }
>> =20
>> -    idle_domain =3D domain_create(DOMID_IDLE, NULL, 0);
>> +    /*
>> +     * idle dom is created privileged to ensure unrestricted access dur=
ing
>> +     * setup and will be demoted by xsm_transition_running when setup i=
s
>=20
> s/xsm_transition_running/xsm_set_system_active/
>=20
>> +     * complete
>=20
> Nit: missing full stop according to CODING_STYLE.

Not really: A single-sentence comment may omit the full stop (while
personally I agree a stop would better be there). Instead starting
with a capital letter is mandated.=20

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 11:01:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 11:01:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312764.530120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwTS-0007gv-Gh; Mon, 25 Apr 2022 11:01:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312764.530120; Mon, 25 Apr 2022 11:01:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwTS-0007go-Db; Mon, 25 Apr 2022 11:01:46 +0000
Received: by outflank-mailman (input) for mailman id 312764;
 Mon, 25 Apr 2022 11:01:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V551=VD=marvell.com=nareshb@srs-se1.protection.inumbo.net>)
 id 1niwTQ-0007gi-H2
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 11:01:45 +0000
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
 [67.231.156.173]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 16837521-c487-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 13:01:42 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
 by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23ONPmwb028740;
 Mon, 25 Apr 2022 04:01:39 -0700
Received: from nam12-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168])
 by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3fmgymd9tp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 25 Apr 2022 04:01:39 -0700
Received: from DM6PR18MB3193.namprd18.prod.outlook.com (2603:10b6:5:1c4::10)
 by CH0PR18MB4211.namprd18.prod.outlook.com (2603:10b6:610:be::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 11:01:37 +0000
Received: from DM6PR18MB3193.namprd18.prod.outlook.com
 ([fe80::854b:68f2:3ff1:e61c]) by DM6PR18MB3193.namprd18.prod.outlook.com
 ([fe80::854b:68f2:3ff1:e61c%6]) with mapi id 15.20.5186.020; Mon, 25 Apr 2022
 11:01:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16837521-c487-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZAf0mLHle1qrOmPX/juPLNzwLeaOYoRjoR1I6l056agEx51IaFW7R3TosSUsFGBQEXwGLyhp/Q30SOOP+tMrN6rzI3hG+hz8dZli4ET+ITD1n2p7UtT0hOmS1tFK8QKR062fmWD1E0qlYUmL7ynYzBoDu8nfiEKhad3QtL8z+kS0pCCdIawmpQBByvpkbygS+uvU6SlbDZukUMTAdNN1tJY6zaqFcfPNjrIfmAOn06wB2h3LR1cPxGDN5VlqnXDxsT5kNJ9kgHWhzWf6AoYF46pZcCLOGzy1hUh2zRr2F/YBISacNyWc1janJvAPrWRJFRyAvkmR4yzSwpASztpskg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vMrGmSzcMKOyH3oAW9hQTtRmv7evMx7ZBE6+j+OOV6Q=;
 b=W8qXz2t48tIuoSsU5Pmv8zi2L7xQ+tWSmbXatoyTR7ZUiELW2h9Fone9fn7LvTxGhN35SZnzt43RSVJ+jBuWJuST1MKYXLexYaetpe5FwNYsfAN6iEuk9P/9zjvu8onhd7LUjfr6pHrCeihr812kS8FhXREsFeU091ZeKybcdovOJyOeff/VrDpuNKJL525ScjSUrFcWpDy+jpb2XvsOEj6r9c3/L3q4mKuNBzuURtTFQ6J0EODeeUU5q4L6V4kgl/h68FerfN0KjQtfK57aWGbsqxRMMyJ8WX4sQpWbpcWebTL8fVu4b7AIe7dd/1+ZaF7gVPTi0ibwwLubJT51uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
 dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vMrGmSzcMKOyH3oAW9hQTtRmv7evMx7ZBE6+j+OOV6Q=;
 b=ViEGlBxiyELzBIxogQxHtOAgA5dzvhyX1YtxA+9YZNmQau2hWttL3w1Q7KqHlIM5quTFWvgQzbtkY888F5J/HWleZVtBm//sF1TotOxyjv1NPIdymFeTdL/yHZ13JBSAOAkntdqj7ZIwycHlEayF00k/di/FVVUgaB9b65gcDxI=
From: Naresh Bhat <nareshb@marvell.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [EXT] Re: DOMU: Virtual Function FLR in PCI passthrough is
 crashing
Thread-Topic: [EXT] Re: DOMU: Virtual Function FLR in PCI passthrough is
 crashing
Thread-Index: AQHYVLOBoc8zYi1khUW56WNBox6p/Kz4xa6AgAe2FfE=
Date: Mon, 25 Apr 2022 11:01:37 +0000
Message-ID: 
 <DM6PR18MB3193E803521B24BB2BBD331AB9F89@DM6PR18MB3193.namprd18.prod.outlook.com>
References: 
 <DM6PR18MB3193BA01B3A6FE2A4A9EAE5CB9F59@DM6PR18MB3193.namprd18.prod.outlook.com>
 <7d1d06ce-6bbb-b4c6-5b59-32ac37e41c4a@suse.com>
In-Reply-To: <7d1d06ce-6bbb-b4c6-5b59-32ac37e41c4a@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
suggested_attachment_session_id: 9f1f0a53-5fa2-a218-d889-a5bb3569783d
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2d5b27c8-05cf-4ed5-5941-08da26aaf84f
x-ms-traffictypediagnostic: CH0PR18MB4211:EE_
x-microsoft-antispam-prvs: 
 <CH0PR18MB4211843DAE06616B6925F13CB9F89@CH0PR18MB4211.namprd18.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lr81oV78svLpt8/sI7b2ZLR2BLNRaSSw2zWaWJRWE4uj1EByVokKU7Mp8a0cCLZoU0a6sqt+1qopk4xwFVW8Nln5mSpGe2O+JFgstWThXjkb4wYlY9oxnOEfEZmDqGRrEoK2XQvQoGf7Ou99NWZk+HR54SAVVP+BUfJ7NTEIHHMRv8nViog+Tzk353au0eg1beOH8+OZc0sslj7xDDy2uvwwW4TkIyus07ebEbY09ipNabhwbG0k9s/hdDUaNeYtD8sSm/998kgKVIC13CG3eZZ4j7nH+uAEeQqwLiWLxL2IkCPTgmaWnTwYcF3UYXqEPzHJJufGlJAHhhg/gA16ySeM7n6Aypkq+l0+VvDBjwLfIjq07pOPtodxbuNZ9vK5A19HPm93o7zqXbHy6oJTUMkCsfnpPJIkX4KTJijUJzYRgTbXL+POOUfw6qNKH+MLgtIlWcZzCcDamMqe/dQyPrBMxaKXI2SfBqNWAHe8Gj3uU660a0hzufS6kVTXy95t+iYHXdIwICc9i6EyZKW9lBt4yAStbD7eLshNimcA2wqTZH+I7aJEcWZuGN+Zc3q1hOKSqw6L14k9SvEW7SEeowYEwBQC7h7VdWD57q+Vt4mrE+J7Xyk70i5h4RPcg2f3FDyhNxMSUzVwt3MlVrlcDR9/ZpvlXHXerZaWNezGLeaFxUWRtMklYmIue4p+ndEgZg8kt23mfvLv1SBnbXnJVQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR18MB3193.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(86362001)(508600001)(66556008)(8676002)(26005)(66476007)(64756008)(33656002)(66446008)(4326008)(316002)(38100700002)(9686003)(55016003)(71200400001)(6916009)(91956017)(76116006)(66946007)(122000001)(53546011)(5660300002)(7696005)(6506007)(52536014)(8936002)(83380400001)(186003)(2906002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?t0zyuROJbXrspJ9wBBBgCYBsawRg8UuFJZXNssVpEM57dhRIoiiC/oABkO?=
 =?iso-8859-1?Q?MF7V5DHbx7Nl4qseHcuFEqKLxt20VyqH8fAnPldqXjByNVYS2Ov8YvHcnY?=
 =?iso-8859-1?Q?gZmJxGRG1fCSM4TesER17xnlevqlm+4rcJjkXtVf7lXKYvn/J3K6KaRNFN?=
 =?iso-8859-1?Q?8CxNC1PQOHNaoBbeAtoULUK2XFHYeWwyt816vwJXbuqiO4GnBWAHv5UvNq?=
 =?iso-8859-1?Q?EZ1bVYL+x+vht/1TuQwSCqh4nQepft+lgkASlfx8M7rjDQNkNt9z+JT3l9?=
 =?iso-8859-1?Q?sIvFp+YHSnnBqcQJgxuR9rcNJi6DdyBbcFJEVhTspGpADvYRBgd18u+uOf?=
 =?iso-8859-1?Q?E/ZkYffMJijpwE1CHe/6bV89+AfsZ6/pJEqhBr80pzwsELpyqwdgakaWOr?=
 =?iso-8859-1?Q?N3DvWFhmFLc3RA05P3sPeZNIfxgR980ohVTdPKHSHnY84a2LymKNm5ckP1?=
 =?iso-8859-1?Q?ZNQguACU+VSRswRIgOmxUCutzkCSDaFQm623UjQX8VZ3O4rE+/Exd8E3UK?=
 =?iso-8859-1?Q?mptcjT1gGK0GnbNfJgMdzm8W1Nj5Cm0GrfwPyjLgs8CsP5fusxJmJXQ6wR?=
 =?iso-8859-1?Q?+KI1j1zSlaD804dour7mOZHiSd+FcmpuSyiVv/IwuZIPClurzpnPzL/bN7?=
 =?iso-8859-1?Q?sJ+ETsZQS70xpSNdB6jfyDyu4JK8i5V7qx5P8+LOb7AJ3Ukx7UmOmu7SuH?=
 =?iso-8859-1?Q?AWrc9zbviOedYRzmQUS8DKfMPTy5XF13Bo6a0YKnfXsy9q+lFeRqA8fWXD?=
 =?iso-8859-1?Q?Tbubw0qsOiEXatpJ6fl1GGw0ddYIhhIWsIqnqZn6OUVL/clm0eCROt/xDP?=
 =?iso-8859-1?Q?zBKJ3nQuHRPL/5EIjj9slp1nE/g0S9+IjPQGnXnsjo2729TdfRFQgX6Y8r?=
 =?iso-8859-1?Q?mEvBiToaW5+H5OaqMxI7wtINU2NLzSmYqX5kSwB0nBjaZtwYbABAeNwMl1?=
 =?iso-8859-1?Q?qjj7dqopylavDEhUosQ5KZ9QIkx1RC21irbw1ZBETfdCXznTbUc9yLvz8X?=
 =?iso-8859-1?Q?MHtuUvmDWiFQ3obl1iYniNWqBLhrh58IEml9TPBQt45Ckl9LThYm2a7NZd?=
 =?iso-8859-1?Q?Lqnb1X9ZjvVyfnSLcMOdGFjSeAWHWXkgBTTWnEo48V7x18LexMN1MGTXOS?=
 =?iso-8859-1?Q?z7F1k5ah9oZ7okhYge/vXifvRNrFouD6U3D1xZrRpLQVJwzqItPrGLG1pA?=
 =?iso-8859-1?Q?ItLhLB68zss5h3CQ9mVX3ZHO6RgxBVUhQswEdkv2lxLxPpk43YSFu2Uylh?=
 =?iso-8859-1?Q?4YsxUs7rhrhgTKwVQDmLkTCbkb79Jp+/RBCsmP/6YhL4FYPO2gt35LrdfT?=
 =?iso-8859-1?Q?/XSfoxmXuNwpIE3eYBPMTq75hnn06KgrE8ZEd7XidIuN5uZdEWCt/BkgB9?=
 =?iso-8859-1?Q?WBmgYNEqS+yAoXRjO0xjfc9/zoFsFb3ibpItKKxWLQITDZNAwFM9yJ40Pq?=
 =?iso-8859-1?Q?IVVpqVruX21WP55hZ2IGQD+c+QYdyrjNblXusU3V5vlHHgjTgi+rQQ5HdW?=
 =?iso-8859-1?Q?Zngy5GbAlAVqrDjJq8mjemiLPXqJHGb/07K/MB/2EFFAbrAGZtrlLECIIV?=
 =?iso-8859-1?Q?1I8m3HqblDrUgIVsqXA1cnQLUlf2w71hA8juEOSqXwS+7J7ecvhGPeEFBD?=
 =?iso-8859-1?Q?pTbiwKWWvF8cDc2ln7z7kTzOpcHWykt3gLFQgtXeHJ8eFJcYqliE9VLR8u?=
 =?iso-8859-1?Q?O46/gUoAuK2HatAV/CHA4avI3MRZC678nepFNYfnMzBkhzPeQi1b9iguG0?=
 =?iso-8859-1?Q?v7fsN2zhdfVeeZvZO+B20gop/wfljeI8w1lzEKOvxMcomB?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3193.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d5b27c8-05cf-4ed5-5941-08da26aaf84f
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2022 11:01:37.8123
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p56d/JH9emLqK6PbwILeNeJD2jWpXApbFP5cbzYKjoFzFJ5KHJgGdzkUrbsLad2CJ9ltfvmIchCm2XaDn9jOmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4211
X-Proofpoint-GUID: R7TDdGAU7cpvdIIsOIBA-jSBEL5xCGg-
X-Proofpoint-ORIG-GUID: R7TDdGAU7cpvdIIsOIBA-jSBEL5xCGg-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-25_07,2022-04-25_01,2022-02-23_01

Hi Jan Beulich, =0A=
=0A=
Thank you very much. Please see my inline comments below.=0A=
=0A=
From: Jan Beulich <jbeulich@suse.com>=0A=
Sent: 20 April 2022 18:37=0A=
To: Naresh Bhat <nareshb@marvell.com>=0A=
Cc: julien@xen.org <julien@xen.org>; sstabellini@kernel.org <sstabellini@ke=
rnel.org>; xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>=
=0A=
Subject: [EXT] Re: DOMU: Virtual Function FLR in PCI passthrough is crashin=
g =0A=
=A0=0A=
External Email=0A=
=0A=
----------------------------------------------------------------------=0A=
On 20.04.2022 14:48, Naresh Bhat wrote:=0A=
> I have the following setup and try to test the Function Level Reset featu=
re.=A0 Any suggestions or pointers will be very much helpful.=0A=
> =0A=
> DOM0=0A=
> Distribution: Ubuntu-20.04.3 (kernel 5.8.0-43)=0A=
> Xen version : 4.11.4-pre=0A=
> =0A=
> DOMU=0A=
> Distribution: Ubuntu-18.04.6 LTS (kernel 5.8.0)=0A=
> PCIe device with SRIOV support, VF (Virtual Function) interface connected=
 to DOMU via PCI pass-through=0A=
> =0A=
> Issue on DOMU: =0A=
> 1. Enable MSIX on DOMU (We have used the following kernel APIs pci_enable=
_msix_range, pci_alloc_irq_vectors)=0A=
> 2. Execute FLR (Function Level Reset) via sysfs interface on the PCIe pas=
sthrough device in DOMU=0A=
>=A0=A0=A0 # echo "1" > /sys/bus/pci/devices/<ID>/reset=0A=
> =0A=
> The following crash observed =0A=
> =0A=
> [ 4126.391455] BUG: unable to handle page fault for address: ffffc9004002=
9000=0A=
> [ 4126.391489] #PF: supervisor write access in kernel mode=0A=
> [ 4126.391503] #PF: error_code(0x0003) - permissions violation=0A=
> [ 4126.391516] PGD 94980067 P4D 94980067 PUD 16a155067 PMD 16a156067 PTE =
80100000a000c075=0A=
> [ 4126.391537] Oops: 0003 [#1] SMP NOPTI=0A=
> [ 4126.391550] CPU: 0 PID: 971 Comm: bash Tainted: G=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0 OE=A0=A0=A0=A0 5.8.0 #1=0A=
> [ 4126.391570] RIP: e030:__pci_write_msi_msg+0x59/0x150=0A=
> [ 4126.391580] Code: 8b 50 d8 85 d2 75 31 83 78 fc 03 74 2b f6 47 54 01 7=
4 6e f6 47 55 02 75 1f 0f b7 47 56 c1 e0 04 48 98 48 03 47 60 74 10 8b 16 <=
89> 10 8b 56 04 89 50 04 8b 56 08 89 50 08 48 8b 03 49 89 44 24 20=0A=
> [ 4126.391606] RSP: e02b:ffffc90040407cc0 EFLAGS: 00010286=0A=
=0A=
The RSP related selector value suggests you're talking about a PV DomU.=0A=
Such a DomU cannot write the MSI-X table directly, yet at a guess (from=0A=
the PTE displayed) that's what the insn does where the crash occurred. I=0A=
would guess you've hit yet another place in the kernel where proper PV=0A=
abstraction is missing. You may want to check with newer kernels.=0A=
=0A=
[Naresh]: We have tested with latest kernel i.e. 5.17.0 kernel, issue persi=
sts.=0A=
=0A=
As to FLR - I guess this operation as a whole needs passing through=0A=
pcifront to pciback, such that the operation can be carried out safely=0A=
(e.g. to save and restore active MSIs, which is what I infer is being=0A=
attempted here, as per the stack trace).=0A=
=0A=
[Naresh]: Any idea when the support will be added to Xen ?=0A=
=0A=
Jan=0A=


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 11:04:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 11:04:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312770.530131 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwWO-0008RY-09; Mon, 25 Apr 2022 11:04:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312770.530131; Mon, 25 Apr 2022 11:04:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwWN-0008RR-SI; Mon, 25 Apr 2022 11:04:47 +0000
Received: by outflank-mailman (input) for mailman id 312770;
 Mon, 25 Apr 2022 11:04:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niwWM-0008RH-OI
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 11:04:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 83f78bfa-c487-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 13:04:45 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-asRGIZ0pMSGpyw3vOiQZyQ-1; Mon, 25 Apr 2022 13:04:41 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4034.eurprd04.prod.outlook.com (2603:10a6:208:63::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 11:04:39 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 11:04:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83f78bfa-c487-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650884685;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=D8LqPUEqPTc5d5HzZHn/6C/8BcpKRavIT4XXO9jbtj4=;
	b=lWBdtO23DkYiqpg0uQgQ0N4PaA3CfdvHHQK9A65jLyTl0UEQbzt89edFKMsR1TOVAxTmmj
	eZmt0luG+yI6M2tbYV5hSgLVn+lnQ82mF37kZC2oUl3lWd49Ty2DbhpSmlddGTSUfUtlJ4
	tDrC0tt7RDbkk0r2FFmZqDgZLuqetmM=
X-MC-Unique: asRGIZ0pMSGpyw3vOiQZyQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PZMP1F0C9KG46MI1Ol5lIrNA/sRRdRhHWVgmI78pUYcNeu8zfBg89OCH833vhRs+cMMn68UdanuvMajycZLD8vvGz5SRdHA9kWuX5Xq8A/AA36TNn97PpR5aSqvSrTWQsA3tPr8awetZHr70oUwC4JeDirgiHqKCktvD6uvS+OrAfOZeGgKMHUr9+sW4cUQRNSHzCtrdpvhChkm7SC3I6k9Ya7d8nFPxGVo2If6QLI4oTzXGWoS+Ve27H/scCHMa4GZpFZaOia/h6rTMhev9qbAMPugDkQg9jGwWym62WAzdjKllHxPIvsrMnM2Ibkf+4cJFBt7LM3T3Fy+Rvbbe4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D8LqPUEqPTc5d5HzZHn/6C/8BcpKRavIT4XXO9jbtj4=;
 b=EDMr+bLHOG0bu1eTFH3ELTMj6N6Mm12B2yr6xvNFw1RlSyHjNQ3cqyb5VLMh/cIYthA9SWuWS7M/x0Cy74+x/7ec65ittqQVClxylVBtoVbhd4EZzdouRO34l+A41jTxUifEGWYHYDllHG6ll/eOUDLa6Z8jxgXbiJCIC1ioli/EP32NWw/kfQLfamu+a5JGHbOoXZGhgXp+3IbVLbxz7BDhFFUQd+t3SW013O2duHiVyHKoEWMlACkJLUekwXogU/mknZJI0vUmQ/BD1O3rVXB2Ei7+J2lij6mvczL+tmsTXuZI2oBfqn5CpCvYwHTsz53P0R/Z2cLcRvLcKYR8Xw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <169f4023-db5f-45ab-b310-2bacb7683ac7@suse.com>
Date: Mon, 25 Apr 2022 13:04:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220425100642.14383-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220425100642.14383-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0077.eurprd06.prod.outlook.com
 (2603:10a6:206::42) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f339e71b-76f1-4e42-30f7-08da26ab646c
X-MS-TrafficTypeDiagnostic: AM0PR04MB4034:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB40344A4598149F53BE1CA82EB3F89@AM0PR04MB4034.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SaDgXrQC+KSLliRmGFokW6ZrPubTETByNCL8KgpNhIJN2jW5EZESe0v23DunJnMsYCs5YzwOPAbVEDhvER3l2JTP80giWhLpTqVhAW45Nb73uTd/dYqyka2SDNPQYzVNkGrKH2l0+Fw0uH1NuQxBJwYRxe/CGIxO/AXynoo6151Xv3FH/mOhJ4jagwW3+YcNU+7FGRXecYIgoQEQ+YBgDBDralD8CahNVg8amMR9A5GGYdrLeWH0r8Xb8/Vrrd+Rth1zz92tqgHsHIdWXJi/2zQUTPcDbl4VKl0h/vsXPWJ4w5Mq153HaQa+mbDktxzW0PhkpK98d6mzrrO4h6JkFjCZqmX5wycsWm1X2p9VU758+EaN/i73YriJjfufDCCBaQzdaReaV0zaOHEfl5qW4Rm81tXST8cjycanbiTp4VDkUoegK8WYiQ57tJzCGzBgl05peYoLMylpg/5ChKJWBbJhRwArv81x1PQGI10P8e7am7e9JjDsLPxPWBzGP58ds5W7uZs+Olq9p9Rd7ocDdAvIsSBsIauHzwB69dfgfsafvo8KHcd7PJ1C/rlU9tffqhr1AYNunNSjU5f21RUREbpugbLXonKBDDelW+hBJDIjJTTCWFLHeLl6kYX+gxVdqR8bZNSJl2cTb11jaYqa7jjkDdeKapoS0Y5f29B6wEyjR9ND47T+2y1eEA+3V842RugyKhxiwhz5EkszxENBRDOfHcZib2KmROmnSruKw6g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(83380400001)(6666004)(6506007)(6512007)(31686004)(26005)(2616005)(31696002)(186003)(8936002)(66476007)(4326008)(66556008)(8676002)(2906002)(5660300002)(53546011)(38100700002)(36756003)(66946007)(6486002)(508600001)(6916009)(316002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q0VxYlpVN05pVVJ0Z1VoRWI0MEJiMjNiaUk0RURZeEV2V05OSllua0tLRGk0?=
 =?utf-8?B?cE5hZ3VJN05iNzl1aXRlYmhndWtqcjlROGZtTTU3S2s3WFpNMkxwamhvdUtQ?=
 =?utf-8?B?cXVSSW5EUHFDRERZZW1kNFhaWjVIZ2JKclkreGIzTVRUa0hBb3h1dTN2TmFl?=
 =?utf-8?B?ZlpRQlRpajN3bVZhUXpBRCt3MFowWVIxR01vYU43UnFQQmZBVmIwUzFFM3J4?=
 =?utf-8?B?TXliZWR3aElaa1Nab0J2eDBBM2F6aHJSc1QvUUc2aytNYmFBUm5TNkFFVyts?=
 =?utf-8?B?cjU4cjUyMVBIVWVXMmJuVWRlRjdUcUI0b2hmS3lxQUtVK3Y0U0VBL09YWnVw?=
 =?utf-8?B?OUJEOTVaS3lFbEkwY3U2K3dqV0h4RzhOT0ptMXJkbjgxaURNcFduQnl5bEUz?=
 =?utf-8?B?MFJGZkFJSlpFQ2JFbDlnSmZvV1B0eHJqeGVJbmp6VzlieERYa2o5RkdhRWR5?=
 =?utf-8?B?SFBhd3NSUFp4SjdZN3ZIcWJsaHc0MTVxbTBPVzI4bFJyZ0pBT3pxcms0bTA1?=
 =?utf-8?B?Z1VhdnVuVkh1bTVKbjAvL2IrZEZWdE9LYTI4STl0WE5wZnZ2M0xLbnpCMUw2?=
 =?utf-8?B?ZDlkNEh0WmVNc2FWSlNLdTNNUFVFN1h0TUMvNnNXa0NaVUFjdlQ1SDdBS25G?=
 =?utf-8?B?QWN1eEJNUjVrbHVJL1NWV0FYZmRBRW1vMHBSNUMzSmU4eEFIM3hjcGpDVDly?=
 =?utf-8?B?UlBxaFAwL0M4MVVueUhNMVNyM2h5UFl6YW4wbVI4Z29XbGd1aWZlbU5kSHNn?=
 =?utf-8?B?WUx2Yll2dmNGYWMyWk10WnZMYVdXOE1pWTlRVkZULzdXUTdrQnBPSGtVL2FY?=
 =?utf-8?B?MGdkU2RPVXlNd2NQZDkrZENWOXFBVGNIR2VBa2ttM3N0aVdXOGUwcy9oTCtU?=
 =?utf-8?B?SXRWWnhPc1BWQnYvdHVkdUwrZ3d6MGwvWE9ERjVOV3hUSFpsUEJrVkhKVzZm?=
 =?utf-8?B?cmlZbFNHekJwSlNUQjJKOGNQeDVoQi8wQVY1SUJscVZxSkZwMXpmSjBmMTFC?=
 =?utf-8?B?cDVKVTlKSGtxQlFWLzVKZ3p6S3B6QUExdk9Zb0M0NVQ2VlRSRzRVNWtQSE1J?=
 =?utf-8?B?SUd6MHlBOC9Ibzh0ZmhEbHd3em9BM0Jwam5PWWxqVitVd2x5TGxZZlNIYVdD?=
 =?utf-8?B?MnJWbGh4TW1ld0NrUy9zV0xDUHRhbUJqR2pVcHNmbWs3SjhGc0gxZHY1T2ts?=
 =?utf-8?B?S2tXTndyQkZkQU1NSXlzMjdpeVNwN0RZWUR4TVpNVllnRys5N2ZnK045aTUv?=
 =?utf-8?B?STBNQ3ZubWMwUmxmQ0ZZSFVQY2crdFZjY2tjVjJxOWRDZzZWMmhORWJ1VTZm?=
 =?utf-8?B?TkhVVjhhUmNMUU9RUjRxRUdUc3RUN1liWCt1OE5vOEo2b1o4cEd6b3J2RGZm?=
 =?utf-8?B?cFBoT3pTQUVoVGI0L0dsa3ozR29naTVsNmdjTkQxVEtCczc0QUlqS3l2MDMz?=
 =?utf-8?B?akdCcEhjZlQrSDRBcm9ZSTEwSFdFS2ZzUlNzV0NtNlkvTWhxazZ0eHdGMFJY?=
 =?utf-8?B?d3lWWjNWMWNzOGxwdEYxVE9zQUFCK2VVY1dnNk43RlJYa3Z6ZDg2YUtZWjd0?=
 =?utf-8?B?N3FNOEJDQ0ZOQjJiMmhwY3hkTlY3azk4a0ZLOTMwajB0b1cyR2VsQlZienFh?=
 =?utf-8?B?eTh6UFRGV1RHOGpLY2ZjZGhmaFBCU0NzRTVxV25GWUtKcWFxZVpBZ21pNjl4?=
 =?utf-8?B?VWE0SmhKd2lIMHB2UFU1SXB2eU1NVTA5RTVibXN4bW5PdXJkb3B5VkJoRGhO?=
 =?utf-8?B?RHkzT25hcm5KdmF6UDd4bUxyTENsMStzQTVucWluNFplZXl1TGhTcVRXSDI5?=
 =?utf-8?B?RGpsL1ZqNytUOEVDWjRzRTVtODQ0U0xHTlhNOHc2ZWk4Q1lrYXN4WXZseTZR?=
 =?utf-8?B?Q0lkbVFOZDB2WU9JTlJ5WitKOFREUmxBUFhDbzlWTXIrVnJuUTl4NFNlZWR3?=
 =?utf-8?B?MWpUTEFFajlqcTdLZUp3Q3o3Lzl0Z25iNzFBaFdQc3Jld210U3U2SHllNHl3?=
 =?utf-8?B?YWFGZmFnSmVqU0RVUzNObW9lMDg2NzUyQXNteEx1VXM3bTN4SWdxQ0hvK0Yr?=
 =?utf-8?B?ZXJjS1JxU25HMlF2SDBRNjRWMnB3b3NVNTZKOTlUZjB6YksyTWZyR0E2ZTFv?=
 =?utf-8?B?QWF4S1hmc05MU2FENGlWZzhFZVNwb2c5VHZNYzBhb09jd2hlOFRDMExOZXJP?=
 =?utf-8?B?Nkhad004dmo1VERxbnYyaE1ieHI2QXI5NnR3TGt2eTM2b3llS3NSZlYrQVNk?=
 =?utf-8?B?bXhCcVVZcTJveFpHM2VRbExUK3RQenlKaWFkUW9IY1lLQkhqUW5TTjZvZVQ1?=
 =?utf-8?B?dDQzZkFOQ1FNM3NCclkvUXA5d2V2SnhKV29VS2Rscm1jS1BJeDZhZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f339e71b-76f1-4e42-30f7-08da26ab646c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 11:04:39.3671
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WsPmB9rFG3uAZTOsW/xxIPneFZzizN0Bax4Ye3fXM0wNfg7vocOnXlcU8KijcZWulLhTJI0iE2R/KFlCrJq8vQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4034

On 25.04.2022 12:06, Andrew Cooper wrote:
> @@ -178,6 +179,71 @@ void domain_pause_for_debugger(void)
>          send_global_virq(VIRQ_DEBUGGER);
>  }
>  
> +long gdbsx_domctl(struct domain *d, struct xen_domctl *domctl, bool *copyback)

Is there anything that requires "long" (and not just "int") here and ...

> +{
> +    struct vcpu *v;
> +    long ret = 0;

... here?

> +    switch ( domctl->cmd )
> +    {
> +    case XEN_DOMCTL_gdbsx_guestmemio:
> +        ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
> +        if ( !ret )
> +            *copyback = true;
> +        break;
> +
> +    case XEN_DOMCTL_gdbsx_pausevcpu:
> +        ret = -EBUSY;
> +        if ( !d->controller_pause_count )
> +            break;
> +        ret = -EINVAL;
> +        if ( (v = domain_vcpu(d, domctl->u.gdbsx_pauseunp_vcpu.vcpu)) == NULL )
> +            break;
> +        ret = vcpu_pause_by_systemcontroller(v);
> +        break;
> +
> +    case XEN_DOMCTL_gdbsx_unpausevcpu:
> +        ret = -EBUSY;
> +        if ( !d->controller_pause_count )
> +            break;
> +        ret = -EINVAL;
> +        if ( (v = domain_vcpu(d, domctl->u.gdbsx_pauseunp_vcpu.vcpu)) == NULL )
> +            break;
> +        ret = vcpu_unpause_by_systemcontroller(v);
> +        if ( ret == -EINVAL )
> +            printk(XENLOG_G_WARNING
> +                   "WARN: %pd attempting to unpause %pv which is not paused\n",
> +                   current->domain, v);
> +        break;
> +
> +    case XEN_DOMCTL_gdbsx_domstatus:
> +        domctl->u.gdbsx_domstatus.vcpu_id = -1;
> +        domctl->u.gdbsx_domstatus.paused = d->controller_pause_count > 0;
> +        if ( domctl->u.gdbsx_domstatus.paused )
> +        {
> +            for_each_vcpu ( d, v )
> +            {
> +                if ( v->arch.gdbsx_vcpu_event )
> +                {
> +                    domctl->u.gdbsx_domstatus.vcpu_id = v->vcpu_id;
> +                    domctl->u.gdbsx_domstatus.vcpu_ev =
> +                        v->arch.gdbsx_vcpu_event;
> +                    v->arch.gdbsx_vcpu_event = 0;
> +                    break;
> +                }
> +            }
> +        }
> +        *copyback = true;
> +        break;
> +
> +    default:
> +        ASSERT_UNREACHABLE();
> +        ret = -ENOSYS;
> +    }

Just as a remark: It's never really clear to me whether we actually want
to permit omitting "break" in cases like this one. It always feels
slightly risky towards someone subsequently adding another case label
below here without adding the suddenly necessary "break". While for
sentinel code like this doing so may be okay, it would seem to me that
we might be better off not allowing omission of "break" anywhere.

> --- a/xen/arch/x86/include/asm/gdbsx.h
> +++ b/xen/arch/x86/include/asm/gdbsx.h
> @@ -2,18 +2,27 @@
>  #ifndef __X86_GDBX_H__
>  #define __X86_GDBX_H__
>  
> -#ifdef CONFIG_GDBSX
> +#include <xen/stdbool.h>
>  
>  struct domain;
> -struct xen_domctl_gdbsx_memio;
> +struct xen_domctl;
>  
> -int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop);
> +#ifdef CONFIG_GDBSX
>  
>  void domain_pause_for_debugger(void);
>  
> +long gdbsx_domctl(struct domain *d, struct xen_domctl *domctl, bool *copyback);
> +
>  #else
>  
> +#include <xen/errno.h>
> +
>  static inline void domain_pause_for_debugger(void) {}
>  
> +long gdbsx_domctl(struct domain *d, struct xen_domctl *domctl, bool *copyback)

static inline?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 11:15:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 11:15:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312779.530142 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwh3-0001jE-1i; Mon, 25 Apr 2022 11:15:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312779.530142; Mon, 25 Apr 2022 11:15:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwh2-0001j7-Uw; Mon, 25 Apr 2022 11:15:48 +0000
Received: by outflank-mailman (input) for mailman id 312779;
 Mon, 25 Apr 2022 11:15:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niwh2-0001j1-Dn
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 11:15:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0e1aef51-c489-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 13:15:47 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-_2Rh9sa7OL-9bSjGcBLjeg-1; Mon, 25 Apr 2022 13:15:45 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR04MB3174.eurprd04.prod.outlook.com (2603:10a6:6:c::30) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.21; Mon, 25 Apr 2022 11:15:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 11:15:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e1aef51-c489-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650885346;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XdJb7m0oKszlbU3WDt9WCRJi6lBQX26euM6HdNAbSIA=;
	b=VZrVbuM97ZCyPj/45FJKWXg37UzfURKmiL0YR5nTvqOT2LTwkZa4TScianpuGK1/gtM/Mv
	gs7qEH6neRVg9lJKXe3LMNmDyFedYxOUC78POiAyBmLW3JNbKPTDbNgaYFKhG8vda0ADUl
	3gnVVwV+Ik8zWUbUNm6RgxIEw+mffI8=
X-MC-Unique: _2Rh9sa7OL-9bSjGcBLjeg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XWsBkm4lqWOxUBKwIYZGi9VQwW2fXMBBbfFjaWDKkVtotqdPZI0fQQRdrYUuu/KQOlw+2kKj6uiGO/6VPkvJ+FZ97NvlryowvF8UxSFSYEEPmRt2dqs8ui76NPQ5Wzyy96flEqAradqmQhhyYQVK604GYSS2glUEFc1LR1yabfRjM6HuG4c55rVtKE9VpmQCYezaaUaR/8PIEen4nA9QaGb40sYidCpNRFxTNrU0HzCYFPWmRHMRnPZsmcQ0relM308zZG5N3cslMQbXE+OePhX6OHXe5IGQCy+/J5n03v/TeRz00TvJJIFqhi4m10sgST0VsJ5bU+jSta+v8/F8wg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lkoC4ma4idfMPFBs/fHpvRbncOgnMKTYgKiGPSBafoM=;
 b=ezrJoyg+jqYvwd2sVY0Y/ANeQ8hVmEjF8FyClgbxC079sYASWKKFb/Ono9V28+ga+oJsGiLTGBshrc7s++3GbZaY/htPUmvfHC4vjNgrphjBD0ofAlFRfXib2HG5C4M+Uv6y34pNM1aG0JUCf/l5n4arpndzow7IGYGx1mV7je9658nR8q9k9T7mbzMyY7dJ7ymAotQlXDooDJRns8CoAddvWbbeLHNkZ/uWXTmdr2acvAb2qway/VkLe3AP7Zg8szUmLMDdZtfi6+ZhxwdvRbgH1oHh4Ba6Ai+WkWihvZEyEgggMTuoY0zpAKlFhcSSjxjL8vCS2Wf+UbwVJknn9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b81be865-55d5-8f8a-020c-6df9fd524ea4@suse.com>
Date: Mon, 25 Apr 2022 13:15:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [EXT] Re: DOMU: Virtual Function FLR in PCI passthrough is
 crashing
Content-Language: en-US
To: Naresh Bhat <nareshb@marvell.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <DM6PR18MB3193BA01B3A6FE2A4A9EAE5CB9F59@DM6PR18MB3193.namprd18.prod.outlook.com>
 <7d1d06ce-6bbb-b4c6-5b59-32ac37e41c4a@suse.com>
 <DM6PR18MB3193E803521B24BB2BBD331AB9F89@DM6PR18MB3193.namprd18.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DM6PR18MB3193E803521B24BB2BBD331AB9F89@DM6PR18MB3193.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0286.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::32) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 429a6ed3-be78-4027-608b-08da26acebaf
X-MS-TrafficTypeDiagnostic: DB6PR04MB3174:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB3174078836B926E0EADFBA43B3F89@DB6PR04MB3174.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KEOhIlTDlHUkeULjZNRd9AyNXWomzHghRyBjLk5usEgvBY7a51vMiq2eMY4FaiEtvtdsZ74OxtJrq2W1V6w81xjK5RpdN2oOfmbBlwcl/WrO0IqN1VlIAtmWRfO29KxH/G9oGXOmwFmWfJgg8e3yrq6/4jeavAzVnv+zMClaOHqGwyuJmOr2Nn/Fer61jEx0eOgz24gmK2iwHAETX0/fFqNxsQzoBg7JMvg0l0b+22Wa4jmaUTEfmTN1HLSHkyjlQJAB7ZLGMCshTR4orG+gUA8hRtGVIXZzNDlpiKf7HnLU+s8prciDE2NrlHTKSvLQ8aHeoUPNRj/j8G7khDYNI6wgEpYhmlvSuyc0n7c1ZXoUO3/mycm+ht3+lR8XkSPZKyebgVhBdXZlp4Jg01lOrhCU67j0KhNKEBc2vhVcwsl3u9wssRCK451jxicV3J7g1z8GPZvNTMBE1lLnXqwsHMnJwBeF6cW50Mq0atyVB93XkWmslQTKpCE0EUNEMZ0ctfzaZMSdPnhP0hyayl7S71i9YPZeIrRtSPBnVc+nWeIlBeCauIadb1P3zlJYv2hg/3rl2Hm/HHOa9SpVLVyGL8D1KxLae9z1I/ftVejjOVrO5Shk+efXH+uT0lmYMYeZ00gng1GFkrNbPcGKp0xdldoNRM0fkXkhdRJ1OARwqAOxpkrNC/sOJNw0HCt1IktVuNFleOIauCnii3nqnM5Kkiqgfp6UZ42Gt0wbybKOJFfIcl/WIQddXAGpRx+UmR36
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(5660300002)(8936002)(6916009)(31686004)(316002)(2906002)(4326008)(6512007)(6506007)(31696002)(86362001)(6486002)(53546011)(508600001)(36756003)(66476007)(83380400001)(66946007)(66556008)(8676002)(26005)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?SmFcvOwHJwZuHbKG8lRhWtzLQDzEUG8MURk6ZChWHalVs4XO8Rt5oUV9Gz9j?=
 =?us-ascii?Q?mzG7J3J+DloM4Fga5dFxkOfkTzo5fCNabDfg0sMjBebBPDvONafppEo2BW9c?=
 =?us-ascii?Q?xkpgYI98yUk7RB0FNauI/gUmziKewiYDm/q+YhgS89wX/NqP2tTIQpPzS2Cu?=
 =?us-ascii?Q?Q6Vh4o0bHCLPyNA+Cfd9+YwOnMJbl66DMIbjDke+iIlLaIeRzRxg6PbhYgVx?=
 =?us-ascii?Q?L0g4wA8943gkScDAAzHXSXf5dmj34JyBAnbavtS+0i51EfcPgze7O7ma0cCq?=
 =?us-ascii?Q?wFU7yQlQtwT9Z678n264OtVH2KyltN+tdA5lFAECaSYnbYxrvuUsdQh++HGe?=
 =?us-ascii?Q?WjBRU49bGP1DWcwMdXnil6DGSBqLE4tkoBKHURWMh8KBWp5Y92+H5B2VTkNR?=
 =?us-ascii?Q?Tkv+kvli93bCHHjqQjWgH/sMgqsXQ8Mf7vNtfER93q7PkLyd9WGcHfaIMW89?=
 =?us-ascii?Q?hEjOkmd67y7BzBicOLvAr5BQyVDhuKld46i6GGz+2kGmloYYsOCmUjWy6j0S?=
 =?us-ascii?Q?tYMErnGFpIw07Zd+A/4WBkTMfIWzx2PkI2Z+HPyJyE87N9x6AlxlXJs/eOEq?=
 =?us-ascii?Q?KZxP4WNygDgVb67zn8XTbkl7HI+KsE/XhWNoNoaDCNkSrU46963c5cxac9fY?=
 =?us-ascii?Q?eOMdhKvTrUl4RUeRyK5mYdGiicFksHU3E2l2NttVGiLEqE0eDC2ULPJaeNbn?=
 =?us-ascii?Q?ipRGSBWCWeVGY/ou250ZO5B8WHmlK4X8P9t2H3nibR/yueIqbc4zhVQw/lIV?=
 =?us-ascii?Q?qlxuKZInLye2jEdRjuEDoWElu4CaNRTx9Y5eTzCNm/KadPZ05ZSNtfT/NjO7?=
 =?us-ascii?Q?ctjQnk08I2edAWkKidT1bb8TATlpPkMBjn8T0BWUjbXQBp37dKuZQcGaNcKi?=
 =?us-ascii?Q?WAB/GSAwIECPyLuNCGXlFlFJZlIdg+tWDhgmm09Kb5j5woR6EL64ksMFjx2S?=
 =?us-ascii?Q?Vj9vlllFYWgb5jlOC9nPYiITXply9go/lH6GtPCXDhIZu7rvO5JthsTdki32?=
 =?us-ascii?Q?+jxjWSQ/3T2l6utn+BhOQ02td2syPFCXA4IhIpQCYJ7b3p+ss90N0hhxHl9j?=
 =?us-ascii?Q?DhJGTdjB5ImPhoW8QcqsMIb77YjeyJgYYrSxK7KUplggc9H2MZJQBGtyp4+O?=
 =?us-ascii?Q?1b8twAeh4wVWYnKI5ZUNv+VB0qMSxFwL9XetJ3Rojswy46eAAzyUwqP6K6gH?=
 =?us-ascii?Q?kQJJMed5yeQigXjb9c4Z4SwixH8GhIcrUiMrrxErLFg9mjK9eKlNDsVJjIH3?=
 =?us-ascii?Q?vJ+so28lnWSM/qVr3FnOP3kj0eb7j84gl4cGj9Z67NO14vA6/Hdmq35xEIHX?=
 =?us-ascii?Q?HkMTaqansGVUIi4WphkCGFy8Wh2igN6ZGWG0rBiQvGL1CDACbNV5r9Gg1I2x?=
 =?us-ascii?Q?PQnP2vgktt+++dfN9/X0ISG2Dq0YA7hf/43ieNdqHrGw4/uJcwUIb0vC+lN1?=
 =?us-ascii?Q?txLvg0j85Ro5aMCk5QIaGPOU7lk1ee/VrSQgM/ZnEimFLWTJoU9ophYd6i7Y?=
 =?us-ascii?Q?xXNcsfuFaIGvCFe5m/7OTiCK7h0PITwAr14zxv+F8szW089mFgsVqI0aPaxU?=
 =?us-ascii?Q?1qWY+BRejuC93ytPLhgbt5a5B5pVlVjCD/R4nsy7mAw8N3YbHNn9LF/2jGpN?=
 =?us-ascii?Q?e55QOEN2YtRiWiM3qgP9QlIKFUcFbjHhGWSFIdnjq2291CHr8a1IQh62TCrc?=
 =?us-ascii?Q?Ex5TzbJJYYqZ/usq5YzUxsVEEOtyoDX8IEOq+d4I0xJi0aWA4B07bq+5jVgZ?=
 =?us-ascii?Q?Iog8yXp+1Q=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 429a6ed3-be78-4027-608b-08da26acebaf
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 11:15:35.9714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lkFciziDoeh35XqUIlEXCVIZWwsEyZJrvQ68YCDCeu6Du3IsVH+g6+/Oz/SptbJVvXRIv8WLfRE4HUlO6n35TA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3174

On 25.04.2022 13:01, Naresh Bhat wrote:
> From: Jan Beulich <jbeulich@suse.com>
> Sent: 20 April 2022 18:37
>=20
> On 20.04.2022 14:48, Naresh Bhat wrote:
>> I have the following setup and try to test the Function Level Reset feat=
ure.=C2=A0 Any suggestions or pointers will be very much helpful.
>>
>> DOM0
>> Distribution: Ubuntu-20.04.3 (kernel 5.8.0-43)
>> Xen version : 4.11.4-pre
>>
>> DOMU
>> Distribution: Ubuntu-18.04.6 LTS (kernel 5.8.0)
>> PCIe device with SRIOV support, VF (Virtual Function) interface connecte=
d to DOMU via PCI pass-through
>>
>> Issue on DOMU:=20
>> 1. Enable MSIX on DOMU (We have used the following kernel APIs pci_enabl=
e_msix_range, pci_alloc_irq_vectors)
>> 2. Execute FLR (Function Level Reset) via sysfs interface on the PCIe pa=
ssthrough device in DOMU
>> =C2=A0=C2=A0=C2=A0 # echo "1" > /sys/bus/pci/devices/<ID>/reset
>>
>> The following crash observed=20
>>
>> [ 4126.391455] BUG: unable to handle page fault for address: ffffc900400=
29000
>> [ 4126.391489] #PF: supervisor write access in kernel mode
>> [ 4126.391503] #PF: error_code(0x0003) - permissions violation
>> [ 4126.391516] PGD 94980067 P4D 94980067 PUD 16a155067 PMD 16a156067 PTE=
 80100000a000c075
>> [ 4126.391537] Oops: 0003 [#1] SMP NOPTI
>> [ 4126.391550] CPU: 0 PID: 971 Comm: bash Tainted: G=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 OE=C2=A0=C2=A0=C2=A0=C2=A0 5.8.0=
 #1
>> [ 4126.391570] RIP: e030:__pci_write_msi_msg+0x59/0x150
>> [ 4126.391580] Code: 8b 50 d8 85 d2 75 31 83 78 fc 03 74 2b f6 47 54 01 =
74 6e f6 47 55 02 75 1f 0f b7 47 56 c1 e0 04 48 98 48 03 47 60 74 10 8b 16 =
<89> 10 8b 56 04 89 50 04 8b 56 08 89 50 08 48 8b 03 49 89 44 24 20
>> [ 4126.391606] RSP: e02b:ffffc90040407cc0 EFLAGS: 00010286
>=20
> The RSP related selector value suggests you're talking about a PV DomU.
> Such a DomU cannot write the MSI-X table directly, yet at a guess (from
> the PTE displayed) that's what the insn does where the crash occurred. I
> would guess you've hit yet another place in the kernel where proper PV
> abstraction is missing. You may want to check with newer kernels.
>=20
> [Naresh]: We have tested with latest kernel i.e. 5.17.0 kernel, issue per=
sists.

Thanks for checking.

> As to FLR - I guess this operation as a whole needs passing through
> pcifront to pciback, such that the operation can be carried out safely
> (e.g. to save and restore active MSIs, which is what I infer is being
> attempted here, as per the stack trace).
>=20
> [Naresh]: Any idea when the support will be added to Xen ?

I'm not sure there's anything in need to be added to Xen, except for
an addition to the related public header (io/pciif.h). It's pcifront
and pciback (part of the kernel) which would need extending. I'm
unaware of anyone having plans in that direction. Maybe you want to
make an attempt?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 11:29:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 11:29:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312788.530153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwto-0003Om-6g; Mon, 25 Apr 2022 11:29:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312788.530153; Mon, 25 Apr 2022 11:29:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwto-0003Of-3j; Mon, 25 Apr 2022 11:29:00 +0000
Received: by outflank-mailman (input) for mailman id 312788;
 Mon, 25 Apr 2022 11:28:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1niwtm-0003OZ-Nj
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 11:28:58 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e3603a5d-c48a-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 13:28:56 +0200 (CEST)
Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 07:28:34 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SA0PR03MB5529.namprd03.prod.outlook.com (2603:10b6:806:bc::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr
 2022 11:28:31 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 11:28:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3603a5d-c48a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650886135;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=8phw4lfF/6CYGGmkNHKbuvG787rzTs4/XXOs+gyVdMU=;
  b=RMIzv59xEh6nx2LuB/H59lSYidshhf5LMSsNUjXY4kq6KYawvUFEQzcE
   6dNY3ETWCUSsYXkJTWyrYwhe1ccXVrb3kFOPWg30ZOSVb+LWu5HyedWrd
   9OKEk+hEun0CPVuYlEZNeOUWGBTmc8Wz/xVldvFMPFKA26bZJAW4nMeu0
   8=;
X-IronPort-RemoteIP: 104.47.70.103
X-IronPort-MID: 72289615
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:csQfXqhWOGmqJMQo+XOoJk04X161FBEKZh0ujC45NGQN5FlHY01je
 htvWGiDO/rYZ2b0f9AnOoS09BxT7ZXRztRhHAFpqSszEn4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nQ4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YV47MrWXvOIyaiJjEGIhYZdi5Jb/E2fq5KR/z2WeG5ft69NHKRhueKc+paNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuocehW9r7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wjP9ftpujW7IApZ2aP3K4bWYd2zRMRogmOU+
 Eue80bSO0RPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BVJ
 lEQ+yEuhbMv70HtRd74NzWnpFaUsxhaXMBfe9DW8ymIw6vQpgyfWW4NS2cZbMR87ZdtAzs3y
 lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obl5jEpMVkcG
 wy3kRU=
IronPort-HdrOrdr: A9a23:+q+nIavxxc0FNju5Ps94hf477skC5IMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79
 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M
 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w
 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a
 6xIm+w81RCMX7TNQ==
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="72289615"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c/2hHNW3e/AbG9yN47A9+gocn8D77l2vvvgFSeo5K+rvzfyct4CZwtsrg9vf8jmMyTlXyFXQ9Y6JEl4o1AqsHwBA39TCDfJiG85fyoMZXYb3b8v5VqUi8z6k379yfWLWI1zoNVNnJnl3VafyJwiw88HCpehM0j8F5rZSXwJVBmtrR6cnA2WXAZoX763zsfb2BeLJDuQ5uroeHektYfV2Q3FRPwiJqGp2byRKASWvFuON0VXOKmMWjK/8zM7aqpsW82E9wfPrZYQWrHUZUN7pUHVW6hucwKR5pFr59VGN/ZoxcWNwBBD/QQgsGfGaFubB8fVtse+Bpi9w6X9l3AlYWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zwruwajnMoFdvrD6u6SQgKnwpS62pvj4c64NXFPwQ2g=;
 b=etsI5rIzch75ejheiVR/pVchDz87VAvpHfY52Zo4dZWQWuoHGwI7lxVWXX7mTAm4vvuHZl8bpFCWIJ3nWb+e/OPoZKvqbpvowO5g7KTIgyNQBnTd+KCQ+mPN+LhcIXxeSTDM+CrxZGxoGS4Y18wiujFnYF4bX2KdP/O0bWYeKwmBLb+bngYWyQSS+wg0XciVTmuh1x4pjsZW111CuAoNMlJIvEvVjqYEeufybHrwcOOXuUY/3nuGRHylg8zNE1xDrpJctANjICOIfW1FRJLSkQOq8UwL6+uLaCHAviJVSKWCHI5wSiNlqLLM4v6UzvBHXN2q86DgXCGFAz3NHbNiwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zwruwajnMoFdvrD6u6SQgKnwpS62pvj4c64NXFPwQ2g=;
 b=Bh6w5iYhRWQtTpwP0GhIagfvABGOImdLsnMTz36OTjg55BGfY8cioY9dcpKP/dD9w2FLA3dPJKZKqRtwERaUl1gkHy1teqA9CgCI2erxCWi4ROGNn8c9hXeRZENPF+jnj3FBGpurVR+wLewBHN2yMZLMvNtyWutLGNOMUY9gFnE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 13:28:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM
 guests
Message-ID: <YmaF2tCNzTj0Gd2H@Air-de-Roger>
References: <20220331092717.9023-1-roger.pau@citrix.com>
 <9f510109-df45-af7d-1c0a-49ef435e371f@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9f510109-df45-af7d-1c0a-49ef435e371f@citrix.com>
X-ClientProxiedBy: LO4P123CA0350.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 203d60f2-71c9-4cc2-7e3c-08da26aeb9ff
X-MS-TrafficTypeDiagnostic: SA0PR03MB5529:EE_
X-Microsoft-Antispam-PRVS:
	<SA0PR03MB552928784945535CFDAB7AC48FF89@SA0PR03MB5529.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eLQbXIS6LJqoJS6+7Ir0ZICidjz8WdLHmgc6Do7zoLdGxOi/SsA7kZhS1Yx55AHDNvEmuCFwNVlF3zAgTh6wwqaHB66EPIqb+4XOIcIRCXrn5xtKok0VrWCPNNqG3wNIn7dtXLvnkcjvkhRxM+gab1CCGFtfI9P2gK9+UeFI0iQd7LP3HBXirz7liJoTSPzFoDyX/hX1LAUn9Mr0YpC/Avg4AkiCTbPILpeaVpCntF0ME7IORhy7R2I5bmrmAeD6PN4FcMmsAPwK/j7Xy5Bw4ntC1u08/HV7Kc4ovT72WzA7zCRMXzgi1oMlDKTeEoAM5p4hKv48KLCnB/fCPWaKQdxRrDa4SBqK2gFXw2Nl/ApZgEiwJMk+XlrBLeufhW06HAKiwXYOgt3EBs4xMkln/kP1c+DA9VtlcQWbgOBRmbcRXrVVnNfKQm//6ZmKZWA/8Fn/kNqVMPTQ2lIGvCqp2yMF4ig+j9MFFxkrCTL/y6GBQXRXFQnKuY4y4VCXfeQpvrhS4dS8jtBeH+VpCelWDfe96AXeMlgZDjL9IADl8FurJ5ADrX15bL0TIkIzXYIzGaBhyXto1Ot7DzukesjvjCMKBnhEGUjGgrielXC+L5l/S9CUKXKHa+rSM53aBSPC1eEpEdFLoIQewjtZwJ6pRg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6636002)(186003)(316002)(66556008)(54906003)(66476007)(33716001)(6506007)(6512007)(6666004)(85182001)(9686003)(26005)(53546011)(5660300002)(66946007)(8676002)(83380400001)(6862004)(4326008)(8936002)(2906002)(508600001)(38100700002)(86362001)(82960400001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bUs5RzRlTEc2M3MrSHVoZmRkOUFKZmtXcHNjMlA2OWRWZmtSNWo0cFFhS3ZF?=
 =?utf-8?B?MUF2K3NyNktCRVA3UlJuYS9YZVNJdDRmY2prQW5pV3ZaeW5TN1lDOEtrZ1pH?=
 =?utf-8?B?bVdMZmJVc1RaSWQ0ajBxTWRJRzhmTGlLNnZiYlg1RTlGYW8wWDJSTXFEYllx?=
 =?utf-8?B?SjdiVFVQSmgxU2VCd2djV2FUdHdNbDRiUytabzBndmpDMmVFMDFhSjkrUk9E?=
 =?utf-8?B?TFVrUWR2RlRjSWpmaGQ3RytTTDlVNGlJUHNZY1dmYWIzb0c2Z21GTFA1elhi?=
 =?utf-8?B?dnd3ZDBxeW1ETVE2VzBqcFFRVTBjZ3pmMVFDMWFQOEpiLzhYK2hHUDJTNVhM?=
 =?utf-8?B?UmNLWE5ycW9WcTNJd2JDbE0zSU1zSnIzNnFETERIaTE5c0piNFNIUUttdFNP?=
 =?utf-8?B?MFY2MjhsRUVSZFRVM3d6eExFaCtRY3Y1TUZVN0RUNm53QzBqUHJ6MjJldGx2?=
 =?utf-8?B?Y0JZaTY3ZDBIV2VUM2ZDRW9WZTU3dDc2YjJLVXREZ1lMTEJQWjRGS2gwTVMr?=
 =?utf-8?B?ekxMdWtqeUQ2bExiUldyZElGVnVOL2dPU2kxNjU1cFhGVkZBZk43SDVWNURw?=
 =?utf-8?B?ZzFwQWpmUVVuc0dQelk1b29PMkVsakVhNm5ob1E4NVIvMWd4cDZpL0d6MHdG?=
 =?utf-8?B?NDdPV0RNd1dDVnVXbEFKUUlWYWFTVzBOUytwcENnVDRjRzRaWURWRE5Sa1pH?=
 =?utf-8?B?NFlSKzJVNzZvRWFBTU5VMjlDNmVFdzMrQW15YTRoajVaMHhBemErMWt6QU8x?=
 =?utf-8?B?YllrWkNLWnpycEVDMTFTeU9VODRUZWVhQVlxNUphaHZIZmZQeVlrRTFyVUZR?=
 =?utf-8?B?Y1pyNXk3eUpiRExNSTlEdm9TbUdmSnF6cVVPamU5RFJ3U3MvY1AvbE01dmFy?=
 =?utf-8?B?NGZNMlVZUXhJWEtNS3k3d0JqWGsva0RRaFlObmlkQjdhcVpWZ0hQSEVZeWl1?=
 =?utf-8?B?TlpLYVRKbzErT2dJRFNzRkFKc3hnbDlBeC8rRmhRdXh1R09IMHVlR0dnaG4x?=
 =?utf-8?B?c2c0QlVFNTlScXhJVmdOa3VuUzIrYW9sMXJXbFNuc0pqTC95SzFwQ2ZGb1A2?=
 =?utf-8?B?YTBDSTFXMUJxOHVMUFYzdjQ2ZlVKQnA2eWhRMko5UXROWHdHOVNZSzUydHRC?=
 =?utf-8?B?Q0piMFlCdFh3ci84NERQcGRIaTkvSHNzaFZrSDJFengxbzgzaHI0S3R6SUJs?=
 =?utf-8?B?ZHF2U1ZnUXpLTUhuZzFlODBLMndVb2F3OFhGSzBlZGppNkF1Uk9VSnlmU213?=
 =?utf-8?B?dTRiaDVYaHUybFJnQTlBb2dvWno3YVRTeGNFd2pUSThpbWp5a2xYamU4ckgv?=
 =?utf-8?B?OG5EVGlxUGxscnhrTW04b2RQSXBZbG00V1o4d05JSGVVLzRxWVlpU1ZHRlJZ?=
 =?utf-8?B?YlEvVGRWVVF6UXFLS1h6dTJWaFlHOXhuUGZrZkJHOHByWWRlWEk3RGV3YUpL?=
 =?utf-8?B?Y2F2QmMxaTdsNmdmcHRjem5nUFhKcUdpUTJjYnhHVi9NbFZseGlEdTQyMTRk?=
 =?utf-8?B?ZEF6SkVyQ0VsT2xGRUw5cGd3bFVBVHh1cEdKcmhnSnlaWUNtTXVISE1xaUp2?=
 =?utf-8?B?RmwycVNlc1hYSnJIYlFvTkgyOG9GSWFEU2xicXNmMlpTRTBheTRqRU1qK2Ft?=
 =?utf-8?B?TXR1NDc3S1JpcXkrTlhobnBKMzdSVjFyenNmSkYyL3NDQVZ3MTVIRytoUmcy?=
 =?utf-8?B?dGk1MEV0WGFBM1R0TTR1VHFtazNPR08xbzhsOGpsZ1VhRURiaUFoODVZZmVH?=
 =?utf-8?B?SlRndzRqdTlleFlaUDZuelMyZk9HVkRVYVh2MTkxWmVmUmNpWmRmSzJsNnlM?=
 =?utf-8?B?REY2SmsxTzdFaGJpVXUxYlNhNU5WR1FlZm5yVHlPb3pIR2V4Wlp1bHd3SzVT?=
 =?utf-8?B?NlhyaE82TTloK00wcmdvc0EySFlHaXo5UngxTDdaMFNOR1BLL3p3aEhrSkc3?=
 =?utf-8?B?RFJhUHgwRW45UTFEREdYdktUYWpNK3ZGY1E4UGJ1OUhPc0J1SlNFS1JCZkhx?=
 =?utf-8?B?U0x4eDN6VG56ZWhJdndHVkhhVDUrd3RPM0FmLzF3bVZLQnMyQWRTanJ2bEpr?=
 =?utf-8?B?L0hTUExrN2RWK1N6R3FFSTFlbjhPaE5CK2NUcGdiVGhtWFpPc3dGRkEyL0Qx?=
 =?utf-8?B?ZXpqLzlxanhJSkNMUWNMd000UjJkUS9HR2NuRVhJTVFTYmJyQjM5alV5YzZY?=
 =?utf-8?B?aTdyRUdieTVpeGJSdmd4MHRQZFhIbHBldjBLYmxRNStQVjFMQ3h3ck9JR1o0?=
 =?utf-8?B?dzFhUWRHd084L2VaRDFVZWEzRXBHL0k0eFFhR0UrMjh5cGY0STRtVGlLQUNW?=
 =?utf-8?B?UnlFSkNpTExOdkNpWU5KTmhvQzJxQTZlWEh3d1psYmRBTXEzUXFNZmV5T3Vo?=
 =?utf-8?Q?7WkTPoX+5OPXmiGQ=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 203d60f2-71c9-4cc2-7e3c-08da26aeb9ff
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 11:28:31.4771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cStnQfNbkBx/PdMTfOnMvUSx1GynVe7suhNCbuMxOfltess+QYn2FuH6dprY3A3lSSQ+BhNOyyfRxmtgofv0tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5529

On Fri, Apr 22, 2022 at 06:49:57PM +0000, Andrew Cooper wrote:
> On 31/03/2022 10:27, Roger Pau Monne wrote:
> > Hello,
> >
> > The following series implements support for MSR_VIRT_SPEC_CTRL
> > (VIRT_SSBD) on different AMD CPU families.
> >
> > Note that the support is added backwards, starting with the newer CPUs
> > that support MSR_SPEC_CTRL and moving to the older ones either using
> > MSR_VIRT_SPEC_CTRL or the SSBD bit in LS_CFG.
> >
> > Xen is still free to use it's own SSBD setting, as the selection is
> > context switched on vm{entry,exit}.
> >
> > On Zen2 and later, SPEC_CTRL.SSBD exists and should be used in
> > preference to VIRT_SPEC_CTRL.SSBD.  However, for migration
> > compatibility, Xen offers VIRT_SSBD to guests (in the max CPUID policy,
> > not default) implemented in terms of SPEC_CTRL.SSBD.
> >
> > On Fam15h thru Zen1, Xen exposes VIRT_SSBD to guests by default to
> > abstract away the model and/or hypervisor specific differences in
> > MSR_LS_CFG/MSR_VIRT_SPEC_CTRL.
> >
> > Note that if the hardware itself does offer VIRT_SSBD (ie: very likely
> > when running virtualized on < Zen2 hardware) and not AMD_SSBD Xen will
> > allow untrapped access to MSR_VIRT_SPEC_CTRL for HVM guests.
> >
> > So the implementation of VIRT_SSBD exposed to HVM guests will use one of
> > the following underlying mechanisms, in the preference order listed
> > below:
> >
> >  * SPEC_CTRL.SSBD. (patch 1)
> >  * VIRT_SPEC_CTRL.SSBD (untrapped). (patch 2).
> >  * Non-architectural way using LS_CFG. (patch 3)
> >
> > This has survived a XenRT basic set of tests on AMD machines.
> 
> Sorry for the mixed feedback, but some is applicable across multiple
> patches.
> 
> First, it is important to know why MSR_VIRT_SPEC_CTRL exists, because
> that informs what is, and is not, sensible to do with it.
> 
> It exists to be a FMS-invariant abstraction of the DE_CFG interface,
> emulated by the hypervisor.  At the time, we experimented with emulating
> MSR_SPEC_CTRL directly, but the results were unusable slow (legacy IBRS
> causing a vmexit on every syscall/interrupt entry&exit) so
> MSR_VIRT_SPEC_CTRL is also an explicit statement that it is an expensive
> operation and shouldn't be used frequently.
> 
> In practice, this means "only for very very important processes, and not
> to be used more frequently than process context switch".  Also, there is
> no hardware which implements MSR_VIRT_SPEC_CTRL, nor will there be.
> 
> Patch 2 has added an extra two vmexits around each vmexit, in an effort

No, it adds just one extra unconditional vmexit, the wrmsr is
conditional to the value in the guest and Xen differing, and it's not
unconditionally executed.

> to let L2 vmexit to L0 rather than L1 for what is likely to be 0 times
> in an L1 timeslice.  It's not a credible optimisation, for something
> which isn't a production usecase.  Yes - nested virt does exist, and is
> useful for dev, but noone runs a fully fat server virt hypervisor at L1
> in production if they care in the slightest about performance.  Either
> way, patch 2 is premature optimisation with a massive complexity cost.

OK, so your recommendation is to trap writes to VIRT_SPEC_CTRL so the
unconditional rdmsr on vmexit is avoided at the cost of taking a
vmexit on all writes to VIRT_SPEC_CTRL, that's indeed fine.

> 
> Furthermore, writes to LS_CFG are also incredibly expensive, even if
> you're not changing any bits.  The AMD recommended algorithm
> specifically avoids rewriting it with the same value as before.

Writes to LS_CFG will only happen if the guest and Xen selection of
SSBD differ, as the guest value is cached.

> Another thing is that Xen shouldn't touch LS_CFG like this if there is
> any hint of a hypervisor on the system.  If there is a hypervisor and it
> doesn't offer VIRT_SPEC_CTRL, trying to play with LS_CFG isn't going to
> make the situation any better.

I would assume that no hypervisor will offer LS_CFG support for
setting SSBD if the guest shouldn't use it, and hence set_legacy_ssbd
will already return false.

> As to the CPUID bit handling, on consideration of the whole series, it
> wants to be "!" only.  ! is there to indicate "something complicated is
> going on with this bit", and life is too short to try and get the
> derivation logic right with both implicit and explicit conditions. 
> Leave it without an s/S (so no auto propagation from the host policy),
> and set it in the max policy for LS_CFG || VIRT_SPEC_CTRL || SPEC_CTRL,
> and set it in the default policy for LS_CFG || VIRT_SPEC_CTRL, which
> will be far clearer to follow.

OK, as both Jan and you agree that using just '!' is fine I can work
with that.

> For `struct ssbd_core`, the name isn't great.  It's more
> ssbd_ls_cfg/state.  Also, each array element wants 64 byte alignment,
> because that's the only way to avoid atomic cacheline pingpong from the
> spinlocks.  Also, the accessors need to be raw, because GIF=0 context is
> weird and working around checklock with irqsave variants is not a clever
> move.  It is not safe to printk()/bug/etc from GIF=0 context, so logic
> needs to be kept to an absolute bare minimum.

Sorry I'm a bit dense today, but I don't seem to be able to find any
raw accessors for our spinlock implementation. _spin_lock_cb will
unconditionally call check_lock and there doesn't seem to be a way to
bypass the checks if lock debugging is enabled.  Am I missing
something?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 11:29:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 11:29:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312791.530164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwuQ-0003tA-Gv; Mon, 25 Apr 2022 11:29:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312791.530164; Mon, 25 Apr 2022 11:29:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwuQ-0003t1-Dd; Mon, 25 Apr 2022 11:29:38 +0000
Received: by outflank-mailman (input) for mailman id 312791;
 Mon, 25 Apr 2022 11:29:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rnYW=VD=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1niwuO-0003OZ-OY
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 11:29:37 +0000
Received: from MTA-12-4.privateemail.com (mta-12-4.privateemail.com
 [198.54.127.107]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb4b5eba-c48a-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 13:29:35 +0200 (CEST)
Received: from mta-12.privateemail.com (localhost [127.0.0.1])
 by mta-12.privateemail.com (Postfix) with ESMTP id 9F71118000A1
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 07:29:33 -0400 (EDT)
Received: from mail-oa1-f47.google.com (unknown [10.20.151.148])
 by mta-12.privateemail.com (Postfix) with ESMTPA id 7AA3B18000A0
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 07:29:33 -0400 (EDT)
Received: by mail-oa1-f47.google.com with SMTP id
 586e51a60fabf-e2fa360f6dso15690897fac.2
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 04:29:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb4b5eba-c48a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650886173;
	bh=qTrCE0w8HVT5Sz7/fTjv5/g16z097wyRfqCLqQjtz6Q=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=Kz/6pD9fyllXoYGtavf0arfn883BDPiwA/SonzcYJR2ybEy5ivU6FLkWwVquWTS3a
	 To43km/XNy5AF9bGTbbLDm/Ubm9IAp7h8rMe/e52sBe2a942JKjP/P3eQmpdOMim2Y
	 NIGpsOullqCF9lipLkRqanAjWIiVHmKfJNLLTfPKHmWa3yvPxBZwUuDSWsHjulBfHb
	 fTS5XF1nPBgiOaecBwgvkg5MX07SjHjNebh9KEAa9Izfw/qU5IX+q2x1Y42aXG/INC
	 HY/1jLaESUG7SCjtFJuZmb29c0ZoIwrQzTURQ+3m39wvGWeAJ+5VGu4dL2i5TGEDZU
	 3TqbfzgJC3Xxg==
X-Gm-Message-State: AOAM532HUHHcmZJIkAT2LmmezG2bGJPtsTk4pHeFxNMmnbC0hsQEfWBI
	TEiz0azYuGaVFVc6IJTL9/QFwnD/naj+B/+lqQg=
X-Google-Smtp-Source: ABdhPJyqEF35es+v6uBjajAmIvzfbEGoFGFP3mQ47R7S5bW875krCP3FsqpSd7nGRTyQ5RgJV2B8O/81AbgNy60PfzQ=
X-Received: by 2002:a05:6870:b295:b0:e9:1c84:3671 with SMTP id
 c21-20020a056870b29500b000e91c843671mr3533748oao.128.1650886172812; Mon, 25
 Apr 2022 04:29:32 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <CABfawhki8YVxycv_zdDqDuOYvBdobdskXnjjdjiF7UND3784cg@mail.gmail.com> <310ab91a-60bd-f4fa-aeee-28aab43aabbe@suse.com>
In-Reply-To: <310ab91a-60bd-f4fa-aeee-28aab43aabbe@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 25 Apr 2022 07:29:21 -0400
X-Gmail-Original-Message-ID: <CABfawhmzz5OwYr93EO7UAnb1X+vBoi3u=YVW6HMV5KpH_iEGeg@mail.gmail.com>
Message-ID: <CABfawhmzz5OwYr93EO7UAnb1X+vBoi3u=YVW6HMV5KpH_iEGeg@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
To: Jan Beulich <jbeulich@suse.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, Alexandru Isaila <aisaila@bitdefender.com>, 
	Petre Pircalabu <ppircalabu@bitdefender.com>, Xen-devel <xen-devel@lists.xenproject.org>, 
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Content-Type: multipart/alternative; boundary="000000000000e531a505dd78e3fe"
X-Virus-Scanned: ClamAV using ClamSMTP

--000000000000e531a505dd78e3fe
Content-Type: text/plain; charset="UTF-8"

On Mon, Apr 25, 2022, 3:49 AM Jan Beulich <jbeulich@suse.com> wrote:

> On 22.04.2022 16:07, Tamas K Lengyel wrote:
> > On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel <tamas.lengyel@intel.com>
> wrote:
> >>
> >> Allow specify distinct parts of the fork VM to be reset. This is useful
> when a
> >> fuzzing operation involves mapping in only a handful of pages that are
> known
> >> ahead of time. Throwing these pages away just to be re-copied
> immediately is
> >> expensive, thus allowing to specify partial resets can speed things up.
> >>
> >> Also allow resetting to be initiated from vm_event responses as an
> >> optimization.
> >>
> >> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> >
> > Patch ping. Could I get a Reviewed-by if there are no objections?
>
> Hmm, this is a little difficult. I'd be willing to give an ack, but that's
> meaningless for most of the code here. Besides a stylistic issue I did
> point out which I'm not happy with, I'm afraid I'm not good enough at
> mem-sharing and forking. Therefore I wouldn't want to offer an R-b.
> Considering the VM event interaction, maybe the BitDefender guys could
> take a stab?
>
> Of course you'd then still need a tool stack side ack.
>

So my take is that noone cares about mem_sharing, which is fine, its an
obscure experiment subsystem. But the only path I see as maintainer to get
anything in-tree is if I hand the task of writing the patch to a coworker
who then sends it in so that I can ack it. This is clearly disfunctional
and is to the detriment of the project overall. We need to get some rules
in place to avoid situations like this that clearly lead to no development
and no improvement and a huge incentive to forgot about upstreaming. With
no substantive objections but no acks a maintainer should be able to get
changes in-tree. That's part of what I would consider maintaining a
codebase to be!

Anyway, to be realistic I don't expect that option to materialize so I'm
very close to just stop all contributions to the project. It's dishartening.

Tamas

--000000000000e531a505dd78e3fe
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Mon, Apr 25, 2022, 3:49 AM Jan Beulich &lt;<a href=
=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; wrote:<br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #=
ccc solid;padding-left:1ex">On 22.04.2022 16:07, Tamas K Lengyel wrote:<br>
&gt; On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel &lt;<a href=3D"mailto:=
tamas.lengyel@intel.com" target=3D"_blank" rel=3D"noreferrer">tamas.lengyel=
@intel.com</a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; Allow specify distinct parts of the fork VM to be reset. This is u=
seful when a<br>
&gt;&gt; fuzzing operation involves mapping in only a handful of pages that=
 are known<br>
&gt;&gt; ahead of time. Throwing these pages away just to be re-copied imme=
diately is<br>
&gt;&gt; expensive, thus allowing to specify partial resets can speed thing=
s up.<br>
&gt;&gt;<br>
&gt;&gt; Also allow resetting to be initiated from vm_event responses as an=
<br>
&gt;&gt; optimization.<br>
&gt;&gt;<br>
&gt;&gt; Signed-off-by: Tamas K Lengyel &lt;<a href=3D"mailto:tamas.lengyel=
@intel.com" target=3D"_blank" rel=3D"noreferrer">tamas.lengyel@intel.com</a=
>&gt;<br>
&gt; <br>
&gt; Patch ping. Could I get a Reviewed-by if there are no objections?<br>
<br>
Hmm, this is a little difficult. I&#39;d be willing to give an ack, but tha=
t&#39;s<br>
meaningless for most of the code here. Besides a stylistic issue I did<br>
point out which I&#39;m not happy with, I&#39;m afraid I&#39;m not good eno=
ugh at<br>
mem-sharing and forking. Therefore I wouldn&#39;t want to offer an R-b.<br>
Considering the VM event interaction, maybe the BitDefender guys could<br>
take a stab?<br>
<br>
Of course you&#39;d then still need a tool stack side ack.<br></blockquote>=
</div></div><div dir=3D"auto"><br></div><div dir=3D"auto">So my take is tha=
t noone cares about mem_sharing, which is fine, its an obscure experiment s=
ubsystem. But the only path I see as maintainer to get anything in-tree is =
if I hand the task of writing the patch to a coworker who then sends it in =
so that I can ack it. This is clearly disfunctional and is to the detriment=
 of the project overall. We need to get some rules in place to avoid situat=
ions like this that clearly lead to no development and no improvement and a=
 huge incentive to forgot about upstreaming. With no substantive objections=
 but no acks a maintainer should be able to get changes in-tree. That&#39;s=
 part of what I would consider maintaining a codebase to be!</div><div dir=
=3D"auto"><br></div><div dir=3D"auto">Anyway, to be realistic I don&#39;t e=
xpect that option to materialize so I&#39;m very close to just stop all con=
tributions to the project. It&#39;s dishartening.</div><div dir=3D"auto"><b=
r></div><div dir=3D"auto">Tamas</div><div dir=3D"auto"><br></div><div dir=
=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquot=
e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol=
id;padding-left:1ex">
</blockquote></div></div></div>

--000000000000e531a505dd78e3fe--


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 11:29:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 11:29:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312795.530175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwuk-0004QM-Sl; Mon, 25 Apr 2022 11:29:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312795.530175; Mon, 25 Apr 2022 11:29:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwuk-0004QF-Pu; Mon, 25 Apr 2022 11:29:58 +0000
Received: by outflank-mailman (input) for mailman id 312795;
 Mon, 25 Apr 2022 11:29:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niwuj-0004O2-5y; Mon, 25 Apr 2022 11:29:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niwuj-0001qn-4G; Mon, 25 Apr 2022 11:29:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niwui-00062M-RT; Mon, 25 Apr 2022 11:29:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niwui-0002Wh-Qx; Mon, 25 Apr 2022 11:29:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sSxbKQ+WxeC2D1nxB45KgSkMXvFkgPyBS8NMtq8oVaw=; b=HwyUac/8BBNPoOqhJxCBedZzqN
	VyaWxIrO2T9sZkCo73akC3WPyUCJkIFnpWrjEyBItOgow8jcKogxv8T9bXPmF78ZGKkKRGzYWaG1K
	hCXAb3USeLqZ9ZbgcU91gqxplSmcXjwXzv4Xrd7ax7AkXP+jMpnXPx2SyLCMDCTciQAw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169703-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169703: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 11:29:56 +0000

flight 169703 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169703/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  616 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 11:31:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 11:31:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312807.530186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwvw-0005xB-7L; Mon, 25 Apr 2022 11:31:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312807.530186; Mon, 25 Apr 2022 11:31:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niwvw-0005x4-41; Mon, 25 Apr 2022 11:31:12 +0000
Received: by outflank-mailman (input) for mailman id 312807;
 Mon, 25 Apr 2022 11:31:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1niwvu-0005wq-EO
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 11:31:10 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 32dc96ec-c48b-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 13:31:09 +0200 (CEST)
Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 07:31:05 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BY5PR03MB5234.namprd03.prod.outlook.com (2603:10b6:a03:219::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr
 2022 11:31:03 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 11:31:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32dc96ec-c48b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650886268;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=+ePuuScs6l4G9f5phnkbNfZbpvdmw3iqIrl4JDB+RoA=;
  b=CrYKDpd2bs1jLWEnc+FqMUKg+LRktBh442fWHfhHWJQRwxFQfrfkfNml
   /caA3vID6gNR7pz3aHZD0uS3VgoiEw2cBlgCyMTwgH7dJOHJDa0Pf7mRZ
   2tWgo3hqb/AL1AZ1xi1ObdkFP2teJ4jGL+1SStNepqBlS7t7O9j0R38Ww
   w=;
X-IronPort-RemoteIP: 104.47.59.175
X-IronPort-MID: 70252679
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:vej8sKO2cqP5AIDvrR3kl8FynXyQoLVcMsEvi/4bfWQNrUpx1jIDn
 2pJDWCGP/2PYzfzKdh+aoiy9UgC6JKByYVhQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1
 fkOjo26FhwVIY7UxcZEUAcbOgtuIvgTkFPHCSDXXc276WTjKiGp79AwSUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7ENaaHPiiCdxwhV/cguhUGvnTf
 YwBYCdHZxXceRxffFwQDfrSmc/33iOiKWMH+Tp5o4IH82vMxQ8hjYLwH4DbdMC4ROB2pUuX8
 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZmmEaWx3ATIBQOWEGnvOKijUqjR9NYL
 VdS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLlYDSjlNedk3rvgcTDYh1
 kKKt97xDDkpu7qQIVqC8p+EoDX0PjIaRUcZbigYUU0J6sfiu6kokhvVSt9pVq+y5vX3EDf82
 SGXrwAxgrwSiYgA0KDT1Uvcnzumq5zNTwg0zgbaRGSo6kV+foHNT4617VnW695QIYDfSUOO1
 FAOltKC9ukIAdeInTaUXeQWNLiz4rCONzi0qVJhFpYu9jOp+la4YJtdpjp5IS9BPskIdDDza
 WfPqAhR49lVJ3LsYqhpC79dEOwvxKnkUNjgCPbda4MUZoArLVDauiZzeUSXwmbh1lA2lr0yM
 ouadsDqCmsGDaNgz3y9QOJ1PaIX+x3SDFj7HfjTpylLG5LHDJJJYd/p6GezU90=
IronPort-HdrOrdr: A9a23:dSzWTKGLFrXPxsD2pLqFepHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH
 PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w
 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q
 6xGm9liQ==
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="70252679"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UwwFCLoBCqwC/HkUrlWftO4wY3KjWKb9maPIWrzSWkDgJSd74quKILDHuVigbUKHb0c/P04Rw6MyExzN3H4K9JaXfaunkjxLdgpvfMZ6TaUsiupto3p7n8HEnyLxpmLAxRVTHZamfymz8o+oHBCq5n+67SvmQMHevlbByg64hYRBzCeJDZsT7ZTlWA7Pn/a8ViEpqQ8PFp9JYvpLnUsHdeEUhjwpnjNmIAVAawPuB8LATKP2+F7i6pHfaAkTIyw6+vPw+AGWxHnDpr6PTitvNaoHkG6AJDOj0RlUOCqqa5YxoX+NMxUU8APD22P98u7NWEwsmyEA4Ebgya3qwT0NJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p/ZO9v9R/w1tir+v/kYfqsH6oY0f/06Vjrne7HI0cQY=;
 b=Eh1q9S7NdVSJj0eU0EtFefKkyzx5nQmYwaWge79Hq5/8d/LLI+1ETlBZT3x16k2i33YkbXhzh+pif72mAjQDbi3w0393GeGaia+v0armq0glNFzENY/ogjdfKen33phhAfMaEx8NAShP1cfXJh5zrYJLGgT/1TD2mhFllo03NNhMhquBc1ytbdcXS0GCWG05mo6SeSEBGywu+62bQXuDA9qUJFPmvk8N8L2KvQx0w4o2D1j2fCn1vq47fo03iBUQyDNx029k7nwr8FTu/KFa3gg5SbiQJG2mIND/VlNMfXbQbF170wvzz9oKE8c1CxmUKAOhTi5ti0f3kodOQJgOIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p/ZO9v9R/w1tir+v/kYfqsH6oY0f/06Vjrne7HI0cQY=;
 b=uQoh7ZYSv2PPWrhq1d1rG+JGhuA+1XdVgCXNW/Y/3msF+RHYi/l+63X76sm2pdCJPGOtrJANIOvzI64g6DqAyyAfBTbjiE0I1HxUfQCek6XukPyqQQQgXgpBQn6YFFLhMpi2zbNp6+N9LviGws0bPcuq9zHZJVG/VMPzY+IVqHo=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 13:30:58 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>, scott.davis@starlab.io, jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote
 after setup
Message-ID: <YmaGcqhx5tTiKl9a@Air-de-Roger>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
 <20220422163458.30170-2-dpsmith@apertussolutions.com>
 <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
 <1c2875af-bb9f-38ef-dd06-c74d0c20e7c3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1c2875af-bb9f-38ef-dd06-c74d0c20e7c3@suse.com>
X-ClientProxiedBy: LO4P123CA0333.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18c::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c95f10d1-fef4-4aab-5775-08da26af1422
X-MS-TrafficTypeDiagnostic: BY5PR03MB5234:EE_
X-Microsoft-Antispam-PRVS:
	<BY5PR03MB5234959F5DDE11FB53BB869A8FF89@BY5PR03MB5234.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yI933n7WxY7Qsx2ySB7pTgcK0urrei2gMQuYEx+1Y91EcUry4hKSvHWOh7XvbpqVPIJ1Z1fOr2qPX7zJetYRXRfNPQkqnJ9SM+Zf04cyR4OC/7lpTL6GtKQ2jwIvbFOobJSVawikMHqOZV0DlNok6yTFX4ASUY7rp2qhjFksO+Bo3uKdDu3tmDTBaFITqoM1FGj9h/vx+w0HRD2JlrSLBDOptAJ2+zdIkeQOpiWlTgeBpppmopXnc5X2moW9k77pOjDMHD6qOyWC6enxZU/9tzazZLh5i309ZGv0HQVCAwmzmdwx8626FoJhKTNLHYMtfxnwsXwp6ljkz9QHMyzHP3s4q3lXAD8fmHxvCqDDgZShYo+JR3KJpVlbw4XA9lyVhtigr8dYu9nPklt7I2KmpnBxX2LTARp1SUW/6t4pajjahwmB2bBgKl4Zl34y94D4w3ASbjh2fgatgHaz7c3BVAclu9G/klUAymthlbhSvwj6I4t5rFUQLiH7hKR3o5UE2tnI0Kjc/f+DpR1/ma2sw3LS0IN8pwG50vsmHjM+US3674gEULwT0HUkcyHC91uGRkDJxJa1eHjeD8UKLbwqUwd36qC5rrZdKSqHESLlc+BKLVl/TBBoo+lYfUoMJ8Z8jvz6UDCR1FjVeMR0Po7uDQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(5660300002)(6486002)(7416002)(8936002)(53546011)(9686003)(85182001)(33716001)(83380400001)(186003)(6506007)(86362001)(26005)(82960400001)(38100700002)(6512007)(6666004)(8676002)(2906002)(4326008)(508600001)(66556008)(66476007)(66946007)(6916009)(316002)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NUNFOEFHMXNyQ0JrSkNnMzF4KzhMSnlscEtDZHRTRTE3Z2lDVzduRVB5NDho?=
 =?utf-8?B?TTgxd3Nkbjl6enMvYTdiTXpkbVY2WTNwUE95a0o2MnVELzhEQUsyVDIwV3dv?=
 =?utf-8?B?cEpYcjJkYzFTczVxdUFXR2RNZHpoRzAwQ3ZqVkg2QnRNaTNua1hIUTNvcUgr?=
 =?utf-8?B?aWhTZTRkYUlPd0ptR3V1K3o3U1RmZ1lDTncvQmJPTHAzTEduclNzK1pVTEJp?=
 =?utf-8?B?TjlXR3Rla1M4R2xmWjdJcFBvaVdZVi9YMWI4eVpBR2N3MFprOEdRZGhqcEQ5?=
 =?utf-8?B?ZU90UmtyVHV1ZG1RZDVMOFV4bFgrbSs3TnVJOVhCaFJ6Ni9yYTB3Z1NZVlg3?=
 =?utf-8?B?bFY3MlVlZVp5Z25tWUU3ZUtESDl1NmNoNFZNNG84R2JZajkrbkJaSVNEcUs3?=
 =?utf-8?B?U014blJkWERYYWsxYWVuTzcrQVhmTXFzWW5ldy9QTUhHNmpYSlg4NXhBWlZo?=
 =?utf-8?B?VXNlSng2VFlkSEJPZ1UyNUVaNi9WRjRwOGcxK3lncVlSYXNmUkZDdUVsMVA3?=
 =?utf-8?B?cWZ3RlFmQVo1ZWZkSjNGT2MvR2VTZk9kQk9tcWpNeVlTL0NQSjZCbUFpUThj?=
 =?utf-8?B?UE1uVGlZRFJ1dHltUzhIclpmWjR3bXhBMm9HZE9aaFRWOUJSc0lhb1kxaFVS?=
 =?utf-8?B?OFNhNkYxTDhIWGJ5Z3lqSk5QTElFMzRHZ1BhSTJpVis2bjNUVlAzallYRUZC?=
 =?utf-8?B?eFdCVVNodjFQSFFYQm4xRTBnd3k0MmJBQTlqVTdONUk3d0tmckw0OGk4eGlN?=
 =?utf-8?B?VkhOSUJhWFh3Q2lFUzFnczNYQ2I4dCtUK3c4dDlzSmc0NzZ1RGpMYlpRVGZu?=
 =?utf-8?B?RkFJTmdBTURwRkhlTVRjcmZpS3FybUJtanZGYkVSRjhlRXRsa1JXSW0xaFZL?=
 =?utf-8?B?dG9HVGpOZU9ockR3bndoTG5MMTljcGRYZVBUMHJWSzB6Ylh6elNxcGMrYkg0?=
 =?utf-8?B?WHVzbzhhMkMyWjBlLzRiRzdoWXNIZXlzUGRaQVV4YVNQREhsRnpWRWJrcmNT?=
 =?utf-8?B?Yk5pNi92ZUhDbTZVQnF5RjV2RklmVEtiZWU5aE9jZEN2V2JHOWRiWngrNzRF?=
 =?utf-8?B?VUdFbEVFYmRNVXhlQXRNUjZPSkFrV0pmWHFhZU9tYmlNYlF0M2lpQmp1cExz?=
 =?utf-8?B?cTdZQ2MvZlJYdzd4R1BQTThwbXpqaUprZTNTa25vMUc4NDRWUlVGRytMOGdz?=
 =?utf-8?B?Y0M5N2V1S240M0xHTlkxMlltM2k0UGIzQjYwc3hHRjRQOXg5V3ZuRzBkNzF5?=
 =?utf-8?B?cmxoc2UyUFM5VGRUeEt0aUJZY3p2NUNnZ3ZJRm9WY0tiU2w4Rkt6R3Z0Z0Rt?=
 =?utf-8?B?ZzFna0RDZGc5TDEyK0UwUnIvcTZBNHMrN0lIS0hTNlY5cGEydDFYcnVqelkx?=
 =?utf-8?B?MHJFcklSOGdKbDVJWTIrL05DQ290VG9KaElmY0ZjMTEweEJZa3VMQ09MYk9W?=
 =?utf-8?B?aGxyb1E3Y0pmTE1WSGZ2eW5BbG8zdzMveVc3bTNoajRDOWVkY2RlaDlwdjJZ?=
 =?utf-8?B?UHpGdVBPQjlqQVIwVHBFaUNRbDEreHZPWTU2RElFRFRYa1RFN2FRZmhyaE5j?=
 =?utf-8?B?RzJsVE5la1ByN2VUbHVnMDA1UDZDMFEzQlRsRGxycVpBYTJISHdkRU5hbWlX?=
 =?utf-8?B?Y0pXUEZTRHVqYitwN3Bsdm5ZdU12K2NoaG9NMThZZ29UTENrKzI2WTBKdHpM?=
 =?utf-8?B?MUpLTmxKZ3hxdUxYa3dCWVJrdlVlcVBaMmREcG5qaldtNkpVRURkeGlkdGV2?=
 =?utf-8?B?Yk13YkRIMmRDZXJ4TFFmaXRQUDdRODR2SzBDbDJhZXRTZGU0c2FBV1M5OXEw?=
 =?utf-8?B?MUJleHZEazFuaXgySUZ3eUhtZVhBcWxQNmNTTTRpZFBITkRMZzVqbjREcXRz?=
 =?utf-8?B?MFZsSXNrSG9mMSt0OFZ4UHZPSEFMRTBEQmFmUHNKWkVjMmlaYjExbTArdTlE?=
 =?utf-8?B?NlpsYS9FaEwvcEhUVllHc0YySEljWGFtVHVOMHMyOGU1U00zZDlsRTFORjl2?=
 =?utf-8?B?Ymp6THJsOGVWeU9ldnIwaW0yRndOamhzRTB4Sy9lNlRoWndUWmk0ZmZtUm9C?=
 =?utf-8?B?dTdJMFE0eXA5bG9wYWpXVTRiOXo2L0JGN0V6MVFOc2tPV28zdzZEbEdlQStZ?=
 =?utf-8?B?MW5GU2svN1ZEcFNLd1EyWVorelZ5V09YY3hXZElyNnBLc0NXeDdiclhyak5l?=
 =?utf-8?B?TWg0ZitnZC9SQXZtbnhGZmk2cmpDenBodjNlaVFWR2hwSW0zSGFPeHU3cTlK?=
 =?utf-8?B?NUtxOExvSUsyV3VndHphRWtrRytyK2xMbzRFMjk2T1JCcGNRWWZDdEhxMHJl?=
 =?utf-8?B?NWZPa2FCVGk1M1hLdkxYMTBqYitCQU11TVBZak1rSGlDSE15aGtUWkhSQ1VI?=
 =?utf-8?Q?NuwJE80hO7muMaRM=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c95f10d1-fef4-4aab-5775-08da26af1422
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 11:31:02.7460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bCjBxw/rI6lzxJ2M4c4s7M3VuUkeTcJoBvf5LwzoSjnDVc/qQo3F9VQ/PQKCBwl89lai6+4a5Zqt72baqPnVBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5234

On Mon, Apr 25, 2022 at 12:53:02PM +0200, Jan Beulich wrote:
> On 25.04.2022 11:44, Roger Pau Monné wrote:
> > On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
> >> --- a/xen/arch/x86/setup.c
> >> +++ b/xen/arch/x86/setup.c
> >> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
> >>      void *va;
> >>      unsigned long start, end;
> >>  
> >> +    if ( xsm_set_system_active() != 0)
> >            ^ extra space.
> 
> Hmm, did you mean
> 
>                                          ^ missing space
> ?

Indeed.  I was switching from a different code context and got
confused.

> >> --- a/xen/common/sched/core.c
> >> +++ b/xen/common/sched/core.c
> >> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
> >>          sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
> >>      }
> >>  
> >> -    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
> >> +    /*
> >> +     * idle dom is created privileged to ensure unrestricted access during
> >> +     * setup and will be demoted by xsm_transition_running when setup is
> > 
> > s/xsm_transition_running/xsm_set_system_active/
> > 
> >> +     * complete
> > 
> > Nit: missing full stop according to CODING_STYLE.
> 
> Not really: A single-sentence comment may omit the full stop (while
> personally I agree a stop would better be there). Instead starting
> with a capital letter is mandated. 

Right, it's a multi line comment but single sentence, and hence the
full stop is not mandatory. Sorry for the noise.

Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 11:41:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 11:41:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312817.530198 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nix5x-0007eA-9u; Mon, 25 Apr 2022 11:41:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312817.530198; Mon, 25 Apr 2022 11:41:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nix5x-0007e3-4Z; Mon, 25 Apr 2022 11:41:33 +0000
Received: by outflank-mailman (input) for mailman id 312817;
 Mon, 25 Apr 2022 11:41:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nix5w-0007dx-3t
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 11:41:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a64d1cb6-c48c-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 13:41:30 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-yDH57CbtPc-o-Iyj1wIjbQ-1; Mon, 25 Apr 2022 13:41:29 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4468.eurprd04.prod.outlook.com (2603:10a6:208:6c::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 11:41:27 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 11:41:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a64d1cb6-c48c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650886890;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8xGJB3x6bOt4UkRisDTcheFJuZGP02K2KtsvDqZG4Tk=;
	b=hNP6b2uwBUklkgEMgEhDbIp5oDSKbbIT54yHnQ6eGlkmE2h+D4rzbtptZ5PxhPx1v/QhF/
	wAp7B2BqFydDsDvm2hIEiB/lxenwedGS+E3tJK7sA47LoX2k3vxGUF38rH7SPd/+5DTQwK
	Pljhr7o1aA5VIg0pXdF4XXit30Ikbrc=
X-MC-Unique: yDH57CbtPc-o-Iyj1wIjbQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gmUpvrUGu03NWH9cOFoa1IWFyW14wg4GhEgEFlQXPV3qWt5NocWtJFIh5ibr0hpFdGXBj4UCrMxCM3hmMxagsO2mSBNU1MpGUpHUvb8nF0jfv5zBueDc+ziCrEl1X7ReceEXm7O8YQC7rT0yx9CHXMjiiGPtbbPyK32CVQDIBxh4yWLhTxLI3kUjhIByHieDJXtuaiLIsVzIyicxWKyX0RRscQz//mKRbGcEGzzb0cOAlb5GYfHOYQ4BNRhDpE/OUwppj5n/WTVlzMjmxRc3Te+HXotyiSaSSNneLBlmGkZFyjcgiijvCNSHS4GoR2wYfC/Bq/upEIeDlzCJ1SQYzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8xGJB3x6bOt4UkRisDTcheFJuZGP02K2KtsvDqZG4Tk=;
 b=kiWd0DyHrFurKjGbkiHalw1EVg9jFoYOy2SsyqpQTLVGJ0Kf6xA7NNDNO4nE+4fgbjMrEVMDEgqeCcjIaXu5dh+PJOQ8KJSUUvkltBEx+6q1UoKimC4ppFjWx88VxIcbOI9EtnXwsHg9RU+tDZ3SZ6KK5OwCnycuU4yFCloU91nz72XFfSoNSZNsd+3jITiL9m9PrACzfmnL8bWARmjdyKMM2Mr/jP41FrO2OgMMOj3vgw022br3cyp8oBDAvFUz44IWoAb2W7VTPB4W/GbciH6KRgmCodXlfw02Ugz4OaHDNUgrQipvz3ZptQZEWbRQ/SKUjMmu6RAJcc6dUTv/Dg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5050d2c3-4053-2d83-1a6d-9ed468ed2492@suse.com>
Date: Mon, 25 Apr 2022 13:41:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
Content-Language: en-US
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <CABfawhki8YVxycv_zdDqDuOYvBdobdskXnjjdjiF7UND3784cg@mail.gmail.com>
 <310ab91a-60bd-f4fa-aeee-28aab43aabbe@suse.com>
 <CABfawhmzz5OwYr93EO7UAnb1X+vBoi3u=YVW6HMV5KpH_iEGeg@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CABfawhmzz5OwYr93EO7UAnb1X+vBoi3u=YVW6HMV5KpH_iEGeg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0321.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a69a9873-8e85-43c0-4c1f-08da26b08879
X-MS-TrafficTypeDiagnostic: AM0PR04MB4468:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB446830E4638465DD188D6752B3F89@AM0PR04MB4468.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dTIQ74rJDuDCjTE81UlKUZG9XcebZN6W4sguEjNXwFBmUjGSOaa0+rAT64yVn84tMr7b/oqQbLnFqTt7o0jwB+8vw067be5DuZ4qfwB52eGuRl8iyOg2zjWIVdgH5bT7UJqgLOsQBFhzA25zDr6ZHdHyi+d7iS2FCAx/XdM1cQ4ShQT6LyxhLLizNP5pP5a3VXT7yslY0ytnV/LBbImwKCPm77VafVCpoF/cl+XxJxYJibPyujzZbSyi6l0uHMGn8WJLt/jZFqOV27UUsg/uZ17N+d4Z3O3O4Ey8EsuWB3sg99pgCNbfT56E871lzXyU2rZ5eUWf/X3OuxEeOWWJgpUBFAe6hSq4BX15IdE+5LL0MP+B91iXIRbu4AZEBL1m3sRgZs/g+UhEM383o+DtxdVRdQckYF6aTGIQyaKMXhfbwAsUc3jOvxadgKgeEkoP9W2bYFWgPJIFZQY+F6257Rg/pcLst6F9hXPT8mjbI8QY/aa8+4Mkh3gHRiZUUqV0l+ki0toWOs+xOtYH9uMEfgBQAhHbqxy33yW10nRe5lg3pIe0vlKRxvrtTxh9vOusI7W31r93XJlWX+LFxLjB8lLJriAurVdUt/V4zGMwtxt6YX3thlNwfPnsOLcWR6/AOsnDJjSc6Z23lgUmXcl0Rf4oA4wf80GPJUl+9maKK6XojjhqxY1V59/MbV6YdQkAtgotvp3tr1gdtsWMSLxE7eR1OtnPcW0uzBhPQBzrwnU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(4326008)(86362001)(66946007)(66556008)(66476007)(8676002)(31696002)(186003)(6512007)(6506007)(53546011)(2906002)(6666004)(6486002)(38100700002)(2616005)(5660300002)(36756003)(83380400001)(508600001)(8936002)(7416002)(316002)(31686004)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZCtKbmZ4Qm9WRDNlcll5aUEvVmQrOWc4QWFPUUFFOVA3QUJod1ZCZXlKek5U?=
 =?utf-8?B?Z0tvVFVaTmlTMWlhVDVHeHptNkt4ZUZJRFpZVHpxMFVEQ3oyMmlpR0FoTXVV?=
 =?utf-8?B?YXBHSUgyV09JZW02NmdpWStMOTNxSVhDcTY2UnFBQTArY3VJWWpvTzlrYXJr?=
 =?utf-8?B?VUJjcTExMm9PVmZWQ3VxeitQVDBmNWpUb0lCaHloT0NTV2Y5bTZraUxyMVJ1?=
 =?utf-8?B?Ri9vVXl0YkhSQVZFdjd4TWFJWkJnSDI0UjEzR0dFQXBESVBQTWp3NE10ZmRI?=
 =?utf-8?B?TS8rdGVLM1AvS01adlUyV0g1R21sR3RuUENIL3gyUlFzYzB5YWhvaWhGREpM?=
 =?utf-8?B?K3NVeXpKRlZWN1dhbllmSDBIM2U0RG5MT1hiWTFnT1ZRRW1XdUtvRG1kaTdt?=
 =?utf-8?B?RUdXVVJBcldZbk1JTkdXOVpaUG9pM1liKzZLNVFuM0xNTUYwdkpZVy9BMFE4?=
 =?utf-8?B?ejdteWxwMG5nOUkzSm9aSXo0UHE2TEFJQjhZdzMweWRDR082VEJhQXB1NUUz?=
 =?utf-8?B?NVA2TTR4RmI4WDA5UTVZQzYrMkh0ZXBBMlBVRmVvNGRxRzJtaDY1VGdDQTZx?=
 =?utf-8?B?alNsTzdQVGc0ZDhNRmdFYmVYNEN6bkdva2VXTGxqT054cGIveEhuc1pydHlN?=
 =?utf-8?B?SHNPcGtjMTNydnQvT080Z1ZpSFRKT3lVUlZ0aCttaGZBWlVOeWdmakFaNVlG?=
 =?utf-8?B?dGEvVFNJK0ZEU0Voay9pVlcwczRXWE8zN0FRZW96RW1ObFZQcTZXTGtIS2sx?=
 =?utf-8?B?c3NhcjBxOTh4K212QXJrczNidWFMaWJuUm1MbTVuSFZMcVlrc2pnYWV2QzVG?=
 =?utf-8?B?SHhObm5md2ExdHQ5NDVZVGYxM1JQVnFqRXdIcDVGZVpYZUVGRWppbk93b3lT?=
 =?utf-8?B?VCtkSlUvT3lKNnFNV0xQYm9kN0NOdEVFY3RIbVRFUEF1cUpaZnEvOW05UHV6?=
 =?utf-8?B?SkZTbEZsMDl3R3VaMEZVM2V6dmlKc1l5VlpTTlAxVStLdVZDc2dYVWNQVFRH?=
 =?utf-8?B?eHl0bVJOOWExOXEzYThPcFJLd21lUXVleDhidkg3ejcxUHZJaUZHUElsWlJm?=
 =?utf-8?B?ZkxTenlhWHVYTlpuZjYxeVUzMjlBSkhTMmFGM0QzS05jenprVi9tSjNKcExR?=
 =?utf-8?B?OXR6YVEvMDk0QWlvT09tLzNFRzJpSmtGQXJLM3o5ZjhUMkZFVXBlU3A5ZVpE?=
 =?utf-8?B?R3FsL0tBSnZYcVpGVG5VWmx5YlZoNzRJM09CdzZsUnhBSUhhVmFPTWl2anRS?=
 =?utf-8?B?a1JaZ0Z4bmNnWGEvdk16eTRVdUNzcFBjYk5zL0lqUU9aallzVlFEUEtQektN?=
 =?utf-8?B?cGg1MHIvSUNDV3AxT3A0ek1xY1M3TWZzam1EemdkYmhiTTJZNDVVdG51VnlD?=
 =?utf-8?B?VGhIRTNzUkZsRm9TV280a0Yrb1BDQXV2anVaUjBiT1JyYVo3VDRzS2VqamM1?=
 =?utf-8?B?d0lUSnlRUDVqMXpJN0tyNnRsbHUxWXoyR0wzMDNGdWVCZ1pDL2RMU3A5TVpC?=
 =?utf-8?B?N0pzR0tUR05mZzB4cVBjOHRWZVpWaUFDTWs3UklCaGNCUHNOVmZERXVHSEpo?=
 =?utf-8?B?TUlyQ2IrV0VPblRKNGdZcUpUR3VtdHRoUnFsWkNwZ1QrVCtIZEVKRWYwbFNP?=
 =?utf-8?B?ZU9OaVZ3Q2NaRFJxMVpXendIN1JPZ051WjNUc3JieGp5Rk5IbWx1anZyQjFC?=
 =?utf-8?B?TXBDR0JjNXJVRnhkL1FOUndtcU9HSjZ2ZG5XNFVrRU85Q0YrZGhBQldITWd0?=
 =?utf-8?B?Smp4VzZRQ0UvbDdRd2MyVkZhYkNFNlI4V0ZQMFg3Z0QwOElCTVl4NTc4L3o5?=
 =?utf-8?B?ZEJpSkhIMjVXdDN0NFl6bVA4OStiNjV3bUNPcGZyYUNBaFFNYzR5L0EyV1gz?=
 =?utf-8?B?YlFaMUFuYUVXUUFSR2hpeTdBblZncmRTbUE1V1pXdHNsQXZsWU5VZkI5SUwv?=
 =?utf-8?B?YXFQdzk5YURwb2pGdFZmWDd6SXQ5VVdsZmc4SEZ0MTFOZDdHb1BPRGlQbnhm?=
 =?utf-8?B?VThtUTJ6ZUNnb1V5d1FxTmlYUXIzN2VFU2VDVkU0NnRTYmxSb09UL1V1MUFs?=
 =?utf-8?B?ejlmVlRPYlBpcjh1NXBVdnZtOVhRbWZMOVpiTS9sNkpIWDFldVBaYWY3WjA4?=
 =?utf-8?B?aFM2OHExVE4zRDRPOTdnVFRYS21HZEVqNzZvMDUvakUyYk11ZXpPczFDRWd3?=
 =?utf-8?B?OWNSWDY0QUhpVGhoZXNDVGJPVDFWck5xeEFBS2NmdWJ0TmFBOGlLNDAwN2U0?=
 =?utf-8?B?dUtlVXMxUTlZRng5T3RCdU0xUjI5cjVQNWFvVnJWTkpVcVA1STJDRmVVVTVX?=
 =?utf-8?B?aDBkMlBDYWUvcTNXbFkvZkFDWmdveDgydDNaN085RFFCeHI1THJ0UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a69a9873-8e85-43c0-4c1f-08da26b08879
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 11:41:27.3672
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ooZ83FOwhXBHZuhMRJdfXhLDaDSfKCMvmbZhRkDOnXCCiQoWzN5P+abnSLiQ84T8VU+JR3z9pCYmryJZPlzVVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4468

On 25.04.2022 13:29, Tamas K Lengyel wrote:
> On Mon, Apr 25, 2022, 3:49 AM Jan Beulich <jbeulich@suse.com> wrote:
> 
>> On 22.04.2022 16:07, Tamas K Lengyel wrote:
>>> On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel <tamas.lengyel@intel.com>
>> wrote:
>>>>
>>>> Allow specify distinct parts of the fork VM to be reset. This is useful
>> when a
>>>> fuzzing operation involves mapping in only a handful of pages that are
>> known
>>>> ahead of time. Throwing these pages away just to be re-copied
>> immediately is
>>>> expensive, thus allowing to specify partial resets can speed things up.
>>>>
>>>> Also allow resetting to be initiated from vm_event responses as an
>>>> optimization.
>>>>
>>>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>>>
>>> Patch ping. Could I get a Reviewed-by if there are no objections?
>>
>> Hmm, this is a little difficult. I'd be willing to give an ack, but that's
>> meaningless for most of the code here. Besides a stylistic issue I did
>> point out which I'm not happy with, I'm afraid I'm not good enough at
>> mem-sharing and forking. Therefore I wouldn't want to offer an R-b.
>> Considering the VM event interaction, maybe the BitDefender guys could
>> take a stab?
>>
>> Of course you'd then still need a tool stack side ack.
>>
> 
> So my take is that noone cares about mem_sharing, which is fine, its an
> obscure experiment subsystem. But the only path I see as maintainer to get
> anything in-tree is if I hand the task of writing the patch to a coworker
> who then sends it in so that I can ack it. This is clearly disfunctional
> and is to the detriment of the project overall. We need to get some rules
> in place to avoid situations like this that clearly lead to no development
> and no improvement and a huge incentive to forgot about upstreaming. With
> no substantive objections but no acks a maintainer should be able to get
> changes in-tree. That's part of what I would consider maintaining a
> codebase to be!

I certainly understand your frustration, the more that I'm similarly
affected with a much larger pile of patches. The check-in policy (see
./MAINTAINERS) is - I'm tempted to say "unfortunately" - quite clear
about there being a need for a 2nd party to be involved. In this case
though I've pointed out a possible route to unblock these two patches
- let's give Petre and Alexandru at least a few days to possibly
react to the ping. Apart from this I can only suggest to put this on
the agenda of the next Community Call; I'm afraid I won't myself, as
I've had this topic there already way too often.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:00:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:00:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312827.530208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixNg-0001A6-VR; Mon, 25 Apr 2022 11:59:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312827.530208; Mon, 25 Apr 2022 11:59:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixNg-00019z-Ro; Mon, 25 Apr 2022 11:59:52 +0000
Received: by outflank-mailman (input) for mailman id 312827;
 Mon, 25 Apr 2022 11:59:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nixNf-00019o-38; Mon, 25 Apr 2022 11:59:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nixNe-0002Mi-IT; Mon, 25 Apr 2022 11:59:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nixNe-0006gV-9i; Mon, 25 Apr 2022 11:59:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nixNe-0001Ov-9C; Mon, 25 Apr 2022 11:59:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lNiArwqgaj6muXgWnPWVZ60vpgfahKaRci1itlfogF4=; b=ZGaJbZ/BnWmOfGWLWxRcyieWqO
	nZegbACrLpVgTaouEBh6VTXfEd3yJ8e4oSIRKedOuUhYbJ99twtxfqZDG8EsQgklXWmXjBOo3s09E
	wH+MsfNW+k2X91hMmQkeGRj2TPlVR1zSGu4lchrKHHOkqPmQ+FqniIhm4FlM4JgbL4KU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169704-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169704: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 11:59:50 +0000

flight 169704 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169704/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  617 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:03:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:03:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312836.530219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixQk-0002nI-Ig; Mon, 25 Apr 2022 12:03:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312836.530219; Mon, 25 Apr 2022 12:03:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixQk-0002nB-EU; Mon, 25 Apr 2022 12:03:02 +0000
Received: by outflank-mailman (input) for mailman id 312836;
 Mon, 25 Apr 2022 12:03:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uj5J=VD=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nixQi-0002n5-OT
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 12:03:00 +0000
Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com
 [2a00:1450:4864:20::22c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a0b66981-c48f-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 14:02:49 +0200 (CEST)
Received: by mail-lj1-x22c.google.com with SMTP id q14so17502641ljc.12
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 05:02:54 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 g15-20020a19e04f000000b004720d33b1easm198984lfj.72.2022.04.25.05.02.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 25 Apr 2022 05:02:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0b66981-c48f-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=Z2QfP3nBSkXabdhdfaB6eqqdio2/U/RhPvB3lPD+Pao=;
        b=lpYDpGtxrOQn5xrajUhJXwbUXhyOxOjdyRzr7m44dbrz+0NPBwe/T+YmCwnySSzN75
         ozEBrTQXeq+PnhUTQuum3IpBoXy4R3v3xTqqJB5DMhLLX42mDe6GG92eDN/i4Z/mzYzq
         xka1M+inBE39A6+dpvucVBJiXgHa4bxBzqecI6IUkNDw9qHHVRxN7jyqRsE0o4Bv5jFl
         KzIyDD+y6I6L89FJ2qM0+/704SmsZsiP3avlvjJEud5YimNIBEKk8SDv2xs/JL+5vPks
         svFZkCse1lOk21sdzupq2B1wAVzbvRkSe/hl5nQT6xyddjFsUaqep0tFUE5XJtYLBl2W
         AwtA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=Z2QfP3nBSkXabdhdfaB6eqqdio2/U/RhPvB3lPD+Pao=;
        b=ww7MPlc8HgaZ3sj4yBigJmDDHwS7lRpwdtxfIlyAeFfg3PVn73qc2olwDG29DE+lMg
         jpIDqNO80Osjb66b6LN5dRkxzt/u8NytRzAiPZQDkLbSWs+N2r9HvF+NLC4uqNm0mfr5
         9zVk0vLSxlCwhSReMEVIQKMNx8EPhOqxkvciL6tfhRW3dix4bjd0kNWbqIZt2WuL28HY
         DjDqGDhIdd3pyBASgsts5gvo5Jrt+99Bqc5337GoITNcLc4Sdjw8nmnyxtRd1t3VqU5i
         /0jSksZLd0JcL9Zm3CxEt9hZHgw2fCSIpXJP/E+6lTugn6nPfDAPfwGl6K9pZq96ngUD
         9EAw==
X-Gm-Message-State: AOAM5310781uQb7Evghx3lzn0TIRWaQLzcYR6O82Bc/W4GHWWddJ7bNB
	4HinT2PVxBKBVhuOmKOlc7o=
X-Google-Smtp-Source: ABdhPJz5gsb9QP2Eu88op0SWGichMTrVkYvbSrxtwObXi7vV5qYjfvKgwGLugVvN4IWtrowVnT6x5g==
X-Received: by 2002:a05:651c:12c1:b0:249:7e8c:d5fc with SMTP id 1-20020a05651c12c100b002497e8cd5fcmr10668804lje.33.1650888173691;
        Mon, 25 Apr 2022 05:02:53 -0700 (PDT)
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <6864c64b-246d-7ca4-371a-61d4953a781d@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <e6858f79-2cc2-2bfc-07db-8c46aa1dd81f@gmail.com>
Date: Mon, 25 Apr 2022 15:02:51 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <6864c64b-246d-7ca4-371a-61d4953a781d@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 25.04.22 10:43, Juergen Gross wrote:


Hello Juergen


Thank you for the feedback.

> On 08.04.22 20:21, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> This patch adds basic support for configuring and assisting virtio-mmio
>> based virtio-disk backend (emualator) which is intended to run out of
>> Qemu and could be run in any domain.
>> Although the Virtio block device is quite different from traditional
>> Xen PV block device (vbd) from the toolstack's point of view:
>>   - as the frontend is virtio-blk which is not a Xenbus driver, nothing
>>     written to Xenstore are fetched by the frontend (the vdev is not
>>     passed to the frontend)
>
> I thought about the future support on x86.
>
> There we don't have a device tree (and I don't want to introduce it),
> so the only ways to specify the backend domain id would be to:
>
> - add some information to ACPI tables
> - use boot parameters
> - use Xenstore

I understand that, and agree


> Thinking further of hotplugging virtio devices, Xenstore seems to be the
> only real suitable alternative. Using virtio mechanisms doesn't seem
> appropriate, as such information should be retrieved in "platform
> specific" ways (see e.g. specifying an "endpoint" in the virtio IOMMU
> device [1], [2]). I think the Xenstore information for that purpose
> could be rather minimal and it should be device-type agnostic. Having
> just a directory with endpoints and associated backend domids would
> probably be enough (not needed in this series, of course).

Just to make it clear, we are speaking about the possible ways to 
communicate backend domid for another series [1], so about the x86's 
alternative of device-tree bindings "xen,dev-domid" [2].
I was thinking we could avoid using Xenstore at the guest side for that 
purpose, but I didn't think about hotplug...
I assume, all Xenstore bits wouldn't go the outside Xen grant 
DMA-mapping layer (grant-dma-ops.c)?


>
> This doesn't preclude the device tree variant you are using, as this
> would be required for dom0less systems anyway.

good


>
> OTOH I'd like you to modify the commit message to make it more clear
> that in future frontend data might be written to Xenstore in order to
> support other use cases.

ok, will do


>
>>   - the ring-ref/event-channel are not used for the backend<->frontend
>>     communication, the proposed IPC for Virtio is IOREQ/DM
>> it is still a "block device" and ought to be integrated in existing
>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
>> logic to deal with Virtio devices as well.
>>
>> For the immediate purpose and an ability to extend that support for
>> other use-cases in future (Qemu, virtio-pci, etc) perform the following
>> actions:
>> - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect
>>    that in the configuration
>> - Introduce new disk protocol field to libxl_device_disk struct
>>    (with LIBXL_DISK_PROTOCOL_XEN and LIBXL_DISK_PROTOCOL_VIRTIO_MMIO
>>    types) and reflect that in the configuration (new "protocol" option
>>    with "xen" protocol being default value)
>
> And with the hotplug option in mind I start to feel unueasy with naming
> the new Xenstore node "protocol", as the frontend disk nodes for "normal"
> disks already have a "protocol" entry specifying 64- or 32-bit protocol.


I noticed the "protocol" node at the frontend side for traditional Xen 
PV block device which handles yet another purpose, but I didn't think 
much about it
since the new "protocol" node in only for the backend's use. If we start 
thinking of frontend's Xenstore nodes, then yes, will clash...

>
>
> Maybe we should really name it "transport" instead?

... For me the "transport" name is associated with virtio transports: 
mmio, pci, ccw. But, I would be ok with that name. Another possible name 
could be "specification".


>
>
>> - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
>>    one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model
>>
>> An example of domain configuration for Virtio disk:
>> disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, 
>> protocol=virtio-mmio']
>
> With Roger's feedback this would then be "transport=virtio", the "mmio"
> part should then be something like "adapter=mmio" (in contrast to
> "adapter=pci"), and "adapter" only needed in case of a device tree and
> PCI being available.

ok, will rename. Can we add "adapter" (or whenever the name would be) 
option later, when there is a real need? For now, I mean within the 
current series which adds only virtio-mmio bits on Arm, we can assume 
that "transport=virtio" implies using virtio-mmio.

BTW, if we named the main option "specification", the secondary option 
"transport" would good fit from my PoV.
For example:
disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, 
specification=virtio, transport=mmio']

But, I am perfectly fine with "transport/adapter".


>
>>
>> Nothing has changed for default Xen disk configuration.
>>
>> Please note, this patch is not enough for virtio-disk to work
>> on Xen (Arm), as for every Virtio device (including disk) we need
>> to allocate Virtio MMIO params (IRQ and memory region) and pass
>> them to the backend, also update Guest device-tree. The subsequent
>> patch will add these missing bits. For the current patch,
>> the default "irq" and "base" are just written to the Xenstore.
>> This is not an ideal splitting, but this way we avoid breaking
>> the bisectability.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> I'm fine with the overall approach and couldn't spot any real issues
> in the code.


Thank you.


[1] 
https://lore.kernel.org/xen-devel/1650646263-22047-1-git-send-email-olekstysh@gmail.com/
[2] 
https://lore.kernel.org/xen-devel/1650646263-22047-5-git-send-email-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/1649964960-24864-1-git-send-email-olekstysh@gmail.com/


>
>
>
> Juergen
>
> [1]: 
> https://github.com/oasis-tcs/virtio-spec/blob/master/virtio-iommu.tex
> [2]: https://medium.com/@michael2012zhao_67085/virtio-iommu-789369049443

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:09:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:09:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312842.530230 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixXC-0003Sl-8h; Mon, 25 Apr 2022 12:09:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312842.530230; Mon, 25 Apr 2022 12:09:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixXC-0003Se-5n; Mon, 25 Apr 2022 12:09:42 +0000
Received: by outflank-mailman (input) for mailman id 312842;
 Mon, 25 Apr 2022 12:09:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Y4oX=VD=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nixXB-0003SY-D5
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 12:09:41 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8f778c08-c490-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 14:09:30 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A29FE210E6;
 Mon, 25 Apr 2022 12:09:39 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 52CF113AE1;
 Mon, 25 Apr 2022 12:09:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 5iLnEoOPZmK/YwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 25 Apr 2022 12:09:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f778c08-c490-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650888579; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9/Tf26Emd3YPjxAeDv9s1PSKm4LldHI3cxTPdJi93NM=;
	b=Y3lez5qVB7s7aDPR6Kas6pisArEMHJ5VtWULiW8rVVdnWOTru0HPV7E1NzxrFU7c0mE+Dx
	fnLtsx1dOqCgmBPGu/xxVfeghhn6/1V8O9RQGKjBnMK8Onw79She54Tswwxaiw4yM5p1si
	yrH9mi2I5OV5+N5Ph69QhJDhe7Z+eEU=
Message-ID: <e657458d-d33e-a340-d9fe-152ec97eefec@suse.com>
Date: Mon, 25 Apr 2022 14:09:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <6864c64b-246d-7ca4-371a-61d4953a781d@suse.com>
 <e6858f79-2cc2-2bfc-07db-8c46aa1dd81f@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
In-Reply-To: <e6858f79-2cc2-2bfc-07db-8c46aa1dd81f@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------LHWQIBAnaq1gZu1OUg0MSNfJ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------LHWQIBAnaq1gZu1OUg0MSNfJ
Content-Type: multipart/mixed; boundary="------------3s00QFrS0Gro6Wx8qDIOt0sW";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Message-ID: <e657458d-d33e-a340-d9fe-152ec97eefec@suse.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <6864c64b-246d-7ca4-371a-61d4953a781d@suse.com>
 <e6858f79-2cc2-2bfc-07db-8c46aa1dd81f@gmail.com>
In-Reply-To: <e6858f79-2cc2-2bfc-07db-8c46aa1dd81f@gmail.com>

--------------3s00QFrS0Gro6Wx8qDIOt0sW
Content-Type: multipart/mixed; boundary="------------YMyFqIogwEBzguV1hNA6Qq5o"

--------------YMyFqIogwEBzguV1hNA6Qq5o
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjUuMDQuMjIgMTQ6MDIsIE9sZWtzYW5kciB3cm90ZToNCj4gDQo+IE9uIDI1LjA0LjIy
IDEwOjQzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPiANCj4gDQo+IEhlbGxvIEp1ZXJnZW4N
Cj4gDQo+IA0KPiBUaGFuayB5b3UgZm9yIHRoZSBmZWVkYmFjay4NCj4gDQo+PiBPbiAwOC4w
NC4yMiAyMDoyMSwgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+Pj4gRnJvbTogT2xl
a3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+
DQo+Pj4gVGhpcyBwYXRjaCBhZGRzIGJhc2ljIHN1cHBvcnQgZm9yIGNvbmZpZ3VyaW5nIGFu
ZCBhc3Npc3RpbmcgdmlydGlvLW1taW8NCj4+PiBiYXNlZCB2aXJ0aW8tZGlzayBiYWNrZW5k
IChlbXVhbGF0b3IpIHdoaWNoIGlzIGludGVuZGVkIHRvIHJ1biBvdXQgb2YNCj4+PiBRZW11
IGFuZCBjb3VsZCBiZSBydW4gaW4gYW55IGRvbWFpbi4NCj4+PiBBbHRob3VnaCB0aGUgVmly
dGlvIGJsb2NrIGRldmljZSBpcyBxdWl0ZSBkaWZmZXJlbnQgZnJvbSB0cmFkaXRpb25hbA0K
Pj4+IFhlbiBQViBibG9jayBkZXZpY2UgKHZiZCkgZnJvbSB0aGUgdG9vbHN0YWNrJ3MgcG9p
bnQgb2YgdmlldzoNCj4+PiDCoCAtIGFzIHRoZSBmcm9udGVuZCBpcyB2aXJ0aW8tYmxrIHdo
aWNoIGlzIG5vdCBhIFhlbmJ1cyBkcml2ZXIsIG5vdGhpbmcNCj4+PiDCoMKgwqAgd3JpdHRl
biB0byBYZW5zdG9yZSBhcmUgZmV0Y2hlZCBieSB0aGUgZnJvbnRlbmQgKHRoZSB2ZGV2IGlz
IG5vdA0KPj4+IMKgwqDCoCBwYXNzZWQgdG8gdGhlIGZyb250ZW5kKQ0KPj4NCj4+IEkgdGhv
dWdodCBhYm91dCB0aGUgZnV0dXJlIHN1cHBvcnQgb24geDg2Lg0KPj4NCj4+IFRoZXJlIHdl
IGRvbid0IGhhdmUgYSBkZXZpY2UgdHJlZSAoYW5kIEkgZG9uJ3Qgd2FudCB0byBpbnRyb2R1
Y2UgaXQpLA0KPj4gc28gdGhlIG9ubHkgd2F5cyB0byBzcGVjaWZ5IHRoZSBiYWNrZW5kIGRv
bWFpbiBpZCB3b3VsZCBiZSB0bzoNCj4+DQo+PiAtIGFkZCBzb21lIGluZm9ybWF0aW9uIHRv
IEFDUEkgdGFibGVzDQo+PiAtIHVzZSBib290IHBhcmFtZXRlcnMNCj4+IC0gdXNlIFhlbnN0
b3JlDQo+IA0KPiBJIHVuZGVyc3RhbmQgdGhhdCwgYW5kIGFncmVlDQo+IA0KPiANCj4+IFRo
aW5raW5nIGZ1cnRoZXIgb2YgaG90cGx1Z2dpbmcgdmlydGlvIGRldmljZXMsIFhlbnN0b3Jl
IHNlZW1zIHRvIGJlIHRoZQ0KPj4gb25seSByZWFsIHN1aXRhYmxlIGFsdGVybmF0aXZlLiBV
c2luZyB2aXJ0aW8gbWVjaGFuaXNtcyBkb2Vzbid0IHNlZW0NCj4+IGFwcHJvcHJpYXRlLCBh
cyBzdWNoIGluZm9ybWF0aW9uIHNob3VsZCBiZSByZXRyaWV2ZWQgaW4gInBsYXRmb3JtDQo+
PiBzcGVjaWZpYyIgd2F5cyAoc2VlIGUuZy4gc3BlY2lmeWluZyBhbiAiZW5kcG9pbnQiIGlu
IHRoZSB2aXJ0aW8gSU9NTVUNCj4+IGRldmljZSBbMV0sIFsyXSkuIEkgdGhpbmsgdGhlIFhl
bnN0b3JlIGluZm9ybWF0aW9uIGZvciB0aGF0IHB1cnBvc2UNCj4+IGNvdWxkIGJlIHJhdGhl
ciBtaW5pbWFsIGFuZCBpdCBzaG91bGQgYmUgZGV2aWNlLXR5cGUgYWdub3N0aWMuIEhhdmlu
Zw0KPj4ganVzdCBhIGRpcmVjdG9yeSB3aXRoIGVuZHBvaW50cyBhbmQgYXNzb2NpYXRlZCBi
YWNrZW5kIGRvbWlkcyB3b3VsZA0KPj4gcHJvYmFibHkgYmUgZW5vdWdoIChub3QgbmVlZGVk
IGluIHRoaXMgc2VyaWVzLCBvZiBjb3Vyc2UpLg0KPiANCj4gSnVzdCB0byBtYWtlIGl0IGNs
ZWFyLCB3ZSBhcmUgc3BlYWtpbmcgYWJvdXQgdGhlIHBvc3NpYmxlIHdheXMgdG8gY29tbXVu
aWNhdGUgDQo+IGJhY2tlbmQgZG9taWQgZm9yIGFub3RoZXIgc2VyaWVzIFsxXSwgc28gYWJv
dXQgdGhlIHg4NidzIGFsdGVybmF0aXZlIG9mIA0KPiBkZXZpY2UtdHJlZSBiaW5kaW5ncyAi
eGVuLGRldi1kb21pZCIgWzJdLg0KPiBJIHdhcyB0aGlua2luZyB3ZSBjb3VsZCBhdm9pZCB1
c2luZyBYZW5zdG9yZSBhdCB0aGUgZ3Vlc3Qgc2lkZSBmb3IgdGhhdCBwdXJwb3NlLCANCj4g
YnV0IEkgZGlkbid0IHRoaW5rIGFib3V0IGhvdHBsdWcuLi4NCj4gSSBhc3N1bWUsIGFsbCBY
ZW5zdG9yZSBiaXRzIHdvdWxkbid0IGdvIHRoZSBvdXRzaWRlIFhlbiBncmFudCBETUEtbWFw
cGluZyBsYXllciANCj4gKGdyYW50LWRtYS1vcHMuYyk/DQoNCkkgdGhpbmsgaXQgd291bGQg
YmUgYW5vdGhlciBkcml2ZXIgdW5kZXIgZHJpdmVycy94ZW4vIHdpdGhvdXQgdGhlIG5lZWQg
dG8NCnRvdWNoIGFueSBvdGhlciBmcm9udGVuZCByZWxhdGVkIGZpbGUgb3IgWGVuLXJlbGF0
ZWQgYXJjaGl0ZWN0dXJlIHNwZWNpZmljDQpjb2RlLg0KDQo+PiBBbmQgd2l0aCB0aGUgaG90
cGx1ZyBvcHRpb24gaW4gbWluZCBJIHN0YXJ0IHRvIGZlZWwgdW51ZWFzeSB3aXRoIG5hbWlu
Zw0KPj4gdGhlIG5ldyBYZW5zdG9yZSBub2RlICJwcm90b2NvbCIsIGFzIHRoZSBmcm9udGVu
ZCBkaXNrIG5vZGVzIGZvciAibm9ybWFsIg0KPj4gZGlza3MgYWxyZWFkeSBoYXZlIGEgInBy
b3RvY29sIiBlbnRyeSBzcGVjaWZ5aW5nIDY0LSBvciAzMi1iaXQgcHJvdG9jb2wuDQo+IA0K
PiANCj4gSSBub3RpY2VkIHRoZSAicHJvdG9jb2wiIG5vZGUgYXQgdGhlIGZyb250ZW5kIHNp
ZGUgZm9yIHRyYWRpdGlvbmFsIFhlbiBQViBibG9jayANCj4gZGV2aWNlIHdoaWNoIGhhbmRs
ZXMgeWV0IGFub3RoZXIgcHVycG9zZSwgYnV0IEkgZGlkbid0IHRoaW5rIG11Y2ggYWJvdXQg
aXQNCj4gc2luY2UgdGhlIG5ldyAicHJvdG9jb2wiIG5vZGUgaW4gb25seSBmb3IgdGhlIGJh
Y2tlbmQncyB1c2UuIElmIHdlIHN0YXJ0IA0KPiB0aGlua2luZyBvZiBmcm9udGVuZCdzIFhl
bnN0b3JlIG5vZGVzLCB0aGVuIHllcywgd2lsbCBjbGFzaC4uLg0KPiANCj4+DQo+Pg0KPj4g
TWF5YmUgd2Ugc2hvdWxkIHJlYWxseSBuYW1lIGl0ICJ0cmFuc3BvcnQiIGluc3RlYWQ/DQo+
IA0KPiAuLi4gRm9yIG1lIHRoZSAidHJhbnNwb3J0IiBuYW1lIGlzIGFzc29jaWF0ZWQgd2l0
aCB2aXJ0aW8gdHJhbnNwb3J0czogbW1pbywgcGNpLCANCj4gY2N3LiBCdXQsIEkgd291bGQg
YmUgb2sgd2l0aCB0aGF0IG5hbWUuIEFub3RoZXIgcG9zc2libGUgbmFtZSBjb3VsZCBiZSAN
Cj4gInNwZWNpZmljYXRpb24iLg0KDQpZZWFoLCBsb29raW5nIGF0IHRoZSB2aXJ0aW8gc3Bl
YyB0aGlzIG1ha2VzIHNlbnNlLg0KDQpTbyBJIHdvdWxkIGJlIGZpbmUgd2l0aCAic3BlY2lm
aWNhdGlvbiIuDQoNCj4+PiAtIEFkZCBuZXcgZGV2aWNlIGtpbmQgKExJQlhMX19ERVZJQ0Vf
S0lORF9WSVJUSU9fRElTSykgYXMgY3VycmVudA0KPj4+IMKgwqAgb25lIChMSUJYTF9fREVW
SUNFX0tJTkRfVkJEKSBkb2Vzbid0IGZpdCBpbnRvIFZpcnRpbyBkaXNrIG1vZGVsDQo+Pj4N
Cj4+PiBBbiBleGFtcGxlIG9mIGRvbWFpbiBjb25maWd1cmF0aW9uIGZvciBWaXJ0aW8gZGlz
azoNCj4+PiBkaXNrID0gWyAncGh5Oi9kZXYvbW1jYmxrMHAzLCB4dmRhMSwgYmFja2VuZHR5
cGU9b3RoZXIsIHByb3RvY29sPXZpcnRpby1tbWlvJ10NCj4+DQo+PiBXaXRoIFJvZ2VyJ3Mg
ZmVlZGJhY2sgdGhpcyB3b3VsZCB0aGVuIGJlICJ0cmFuc3BvcnQ9dmlydGlvIiwgdGhlICJt
bWlvIg0KPj4gcGFydCBzaG91bGQgdGhlbiBiZSBzb21ldGhpbmcgbGlrZSAiYWRhcHRlcj1t
bWlvIiAoaW4gY29udHJhc3QgdG8NCj4+ICJhZGFwdGVyPXBjaSIpLCBhbmQgImFkYXB0ZXIi
IG9ubHkgbmVlZGVkIGluIGNhc2Ugb2YgYSBkZXZpY2UgdHJlZSBhbmQNCj4+IFBDSSBiZWlu
ZyBhdmFpbGFibGUuDQo+IA0KPiBvaywgd2lsbCByZW5hbWUuIENhbiB3ZSBhZGQgImFkYXB0
ZXIiIChvciB3aGVuZXZlciB0aGUgbmFtZSB3b3VsZCBiZSkgb3B0aW9uIA0KPiBsYXRlciwg
d2hlbiB0aGVyZSBpcyBhIHJlYWwgbmVlZD8gRm9yIG5vdywgSSBtZWFuIHdpdGhpbiB0aGUg
Y3VycmVudCBzZXJpZXMgDQo+IHdoaWNoIGFkZHMgb25seSB2aXJ0aW8tbW1pbyBiaXRzIG9u
IEFybSwgd2UgY2FuIGFzc3VtZSB0aGF0ICJ0cmFuc3BvcnQ9dmlydGlvIiANCj4gaW1wbGll
cyB1c2luZyB2aXJ0aW8tbW1pby4NCg0KWWVzLCB3ZSBzaG91bGQgYWRkIGl0IG9ubHkgd2hl
biBuZWVkZWQuDQoNCj4gDQo+IEJUVywgaWYgd2UgbmFtZWQgdGhlIG1haW4gb3B0aW9uICJz
cGVjaWZpY2F0aW9uIiwgdGhlIHNlY29uZGFyeSBvcHRpb24gDQo+ICJ0cmFuc3BvcnQiIHdv
dWxkIGdvb2QgZml0IGZyb20gbXkgUG9WLg0KPiBGb3IgZXhhbXBsZToNCj4gZGlzayA9IFsg
J3BoeTovZGV2L21tY2JsazBwMywgeHZkYTEsIGJhY2tlbmR0eXBlPW90aGVyLCBzcGVjaWZp
Y2F0aW9uPXZpcnRpbywgDQo+IHRyYW5zcG9ydD1tbWlvJ10NCg0KRmluZSB3aXRoIG1lLg0K
DQoNCkp1ZXJnZW4NCg==
--------------YMyFqIogwEBzguV1hNA6Qq5o
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------YMyFqIogwEBzguV1hNA6Qq5o--

--------------3s00QFrS0Gro6Wx8qDIOt0sW--

--------------LHWQIBAnaq1gZu1OUg0MSNfJ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJmj4IFAwAAAAAACgkQsN6d1ii/Ey+r
+wgAighZes82dQ96i/zPzrJc+9wxnH/3ZfjP0k0NdbiJExzsqj6IwC00xM+MlvyXfWc8kj5BMrlB
PWDbNqgbbxZhq1tj0BGVLlLN4uS2/BDOCsUq0hRZ71B3+WiLHDd9HNQ2UpRRM9v5xmCwDDD2LmvR
aRNjyvkAUXKIyAev+Nl4rHOTQaWh6knX8acdO0yg86d87PwJKqNFubAvpF99BlArm+n+aEDi767z
1bJaZmysfiDInN1anFlkwXzjUEfjdvbFTQwwf5mV8HU7cufRZZntiJRbuBktZaUotfJRryCGoHKL
FruWUGc66hxGCIroiKv/lpiYKPeQxbqa4Mc757x2pQ==
=zXYt
-----END PGP SIGNATURE-----

--------------LHWQIBAnaq1gZu1OUg0MSNfJ--


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:26:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:26:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312855.530244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixmy-0006AW-NG; Mon, 25 Apr 2022 12:26:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312855.530244; Mon, 25 Apr 2022 12:26:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixmy-0006AP-KP; Mon, 25 Apr 2022 12:26:00 +0000
Received: by outflank-mailman (input) for mailman id 312855;
 Mon, 25 Apr 2022 12:25:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Eo9G=VD=citrix.com=prvs=107e1699f=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nixmx-0006AJ-87
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 12:25:59 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id daaceafd-c492-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 14:25:57 +0200 (CEST)
Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 08:25:53 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BYAPR03MB4760.namprd03.prod.outlook.com (2603:10b6:a03:13a::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr
 2022 12:25:51 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 12:25:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: daaceafd-c492-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650889557;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=WbIxPqEv/xLRrZH4pYkY3if2CrUkLgZXQoVOuHU3MUU=;
  b=PcnT/SBlIkyqpcCQHU3CvYPGaEy4UdwulT+10Or7WPz13Ed/Mx8jSBnj
   q6OHUujbuwk/OiqkXAjfa+QM8+jgV+73/E35nEYkmlKmgmQckLsDwvjGp
   XNwsDSlKoCigKcBSH1KFb86ngrWrZCSwudgn0a0rjcz3Wm5ssXoWqSM3/
   M=;
X-IronPort-RemoteIP: 104.47.70.101
X-IronPort-MID: 69730507
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:scq5vKO8myC2TxXvrR1FlsFynXyQoLVcMsEvi/4bfWQNrUpzhT1Sy
 jcXXG6HbPmJY2b9ct0iYNu+oUpSvJPcnNQ1Tgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zm
 fx/tbzrTgAVLrT1gcsXfAJnS31hFPgTkFPHCSDXXc276WTjKiOp6dMxSUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB5GdaaG/yiCdxwhV/cguhnG/rEa
 tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2MJ9wnN+PJoi4TV5BByzun0adbSRsHQauQIo1nH+
 lCX72usV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77ncIFBQcWF+/oP+4ok2zQdRSL
 woT4CVGhbc23FymSJ/6RRLQiHyZuh8RXfJAHut87xuCooLW7ByeHXMsVSNaZZots8pebQIt0
 liFjtb4HwtFubeeSW+e3rqMpDb0Mi8QRUcIaDUYVwID75/mqZsqkxPUZt95Fei+ididMSH9x
 XWGoTYzg50XjNUXzOOr8FbfmTWuq5PVCAkv6W3qsnmN6wp4YMuvYdOu4F2CtfJYdt/BFx+Go
 WQOnNWY4KYWF5aRmSeRQeILWra0+/KCNz6aillqd3U8ywmQF7eYVdg4yFlDyI1BaK7opReBj
 JfvhD5s
IronPort-HdrOrdr: A9a23:BKW/0KkrVKA88vLQppoSTWoZ6tfpDfN1iWdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee
 r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp
 gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e
 XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5
 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe
 q1NdZfH+LjRFGebLp04w==
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="69730507"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MB51fat64wZZ9ohmjyFmMuyGIcKN+CNkxE19KfdDDw1GK/yh86Pe2aYzdHDseT8UOMPHc+KOL9ezOd1HOjAS/9PCp1w14FcRSnEjMnNDXG3MnOFBBGMgO/j9lJOPr//j8ON7LaDkl2UoK1izLOKLPqeWtPtahNfQKRrejIAZ2p0pZRczpeCOqAHDI+CDuXfqcO6puaFFVyueaA2XJ+aKwQmszTLnibPdhfJAY6+eNRbZ6H0KTi/CnygnD0QdSbWwG7mPmzv7Se3eOq/6IOatF+IReR4NL1WRg1N9O55hB+btmVOvH5B6OO7hOX6Nqdl/oUplg1VhRJ4jTps52oQCzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WbIxPqEv/xLRrZH4pYkY3if2CrUkLgZXQoVOuHU3MUU=;
 b=l7HsysdYG1MELQidr6PxR1oPWZdA25BrTXASRMpSEgtIZTP6VAAZ3KjJbm7MFXQuF0B6J5PlZGuwdilkDTuhwJsfuMcT/ItRVlJqfkyvlsKLrVH3Dk/1PGw4WPeYkekla6n85oUArL59EqUY/8NRWtDdyaA/1qG7oMq5Gi5paCKbM+vicu38OVrj9NwwN7ZrqDXYTzXBkiAeKQi0gFhMbDKEwvjlgRBaI+RvE5K+ygGCdBstBVPnsl9wi7MEk3wvPd9mutMqSBjt3zq3MoARkjfQ3hkqt+JdMHcpR/68kFpAy0PbhTa1H7QjJQfqsYAa5zegTK7rCS3BkhZJnG11ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WbIxPqEv/xLRrZH4pYkY3if2CrUkLgZXQoVOuHU3MUU=;
 b=DaEkJZHR3qomULRqDpjq2oNFE4rM912Y+I/XANqHwjnUs6G7dM9UH1oGOkMLZthF6r9XTxMyGyAnYIqcJGrJfDaNm2FYQ2cJy8LVndBsOu5UnsRHu7Y5/XEqgnUHgZCK0ngipr/bEv+Og8VwYlznZMCBPlyyA+8XbdMVh8jnANM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Juergen Gross <jgross@suse.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Topic: [PATCH v2] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Thread-Index: AQHYWIw8chvpJExnr0WEKHKghrmtCq0Ad2cAgAAWtIA=
Date: Mon, 25 Apr 2022 12:25:51 +0000
Message-ID: <86e38a1d-5fb0-efe2-1013-f5cf1a1a1451@citrix.com>
References: <20220425100642.14383-1-andrew.cooper3@citrix.com>
 <169f4023-db5f-45ab-b310-2bacb7683ac7@suse.com>
In-Reply-To: <169f4023-db5f-45ab-b310-2bacb7683ac7@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 061f9c53-ff6c-4044-2c1e-08da26b6bc89
x-ms-traffictypediagnostic: BYAPR03MB4760:EE_
x-microsoft-antispam-prvs:
 <BYAPR03MB4760B0F90FE338C4C303FC04BAF89@BYAPR03MB4760.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 6hcf8T90iRj66J3Dh04zuETbb8HuBqo1uE7yBX7PIuwyTZ3s+QoTD3TNg/LI6KfqiYa9clCkXMTeU5A+v3avCl7m5xMy9v+qmXDJV9yphdHMUbmCGt5XBC9yE0MXpl4hthi0ld1iYnsf/oYqFNsCVjnJhKOVJXmJLfMB75QYc53TU4PXQ+/94tLZhE1usNkI5SlDmeHRqPiZY4YqEjlmhTjJcX4+iX/zOit5hsdCPomv4KVwfuAeC19Sl0w9bFymnAsLVG8n7yxRg4XUx9uOeU4HizKB98ZTm+3Xf9a9oVr2e7Cws6WId5Xbs5mu7rih40eiUljSA9bOZNz3tXIROsfRLDSunzZDm2C9yoIk6K9HdQFrHQgmrtDAuXYzDSRMetjoiwx2aiUi4vkfvESZ0eQjkD57YKihPwCLt+dCJ2yFePz/MWx9WwfQMQL1gtswkCtSXnLN5iYKroyTqj7nU1oallRPFNj5kKhDUOPMFRq4IsDHPI6lkAnQIwBdiUSl/P5LFF4S1w9tuuuEPOvlHltwc28ameNVHH0Uvvua0O2lcZ1hQlX/CIO75cVn+oH2u1KZsVQbxTEeFZIHOx3rNOZKHHs99RJ/TS75kxlDqy0KJEiwXVlaYzwg9XU9u26VfGIGBUYYVFQVXnqqCX1+jp85NCk/RAuQSKpK8zjMyxzFBWy9EPIGqqx0yxjA/DfuWY91LpO4xAhjJeaHGfi2svCX9HsPMOm2dLXJtd6NBXG09ILA+I1Be9jgEJ0IuCn8XWlbk6pkSw3PgDLjrwjdIg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(186003)(66556008)(66476007)(76116006)(2616005)(31686004)(66446008)(36756003)(83380400001)(6512007)(86362001)(31696002)(26005)(6506007)(53546011)(91956017)(8676002)(4326008)(64756008)(122000001)(66946007)(2906002)(6486002)(6916009)(54906003)(8936002)(71200400001)(82960400001)(38070700005)(38100700002)(508600001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?cDFQQ3RZbVZndkY0Y2VWN3JkVjVTUi9HWmdMcUwvbGYxaFhDQVk5TDJWVm8x?=
 =?utf-8?B?eE1kTmsxK1Q0RFV6azFZemFMUnZEdUMxTDl0cjZnSmxBMUcydmprTENCdEVa?=
 =?utf-8?B?eGRyck1idzN4MzZBcmV6TzBPWnlBZXVBWUw5U1ZhdlBBRko5d3J0ZDhoRnVF?=
 =?utf-8?B?ZmVQOThZWFFpUjdScEUxdmpnTXlzOEx4Rk1aUUNNc3d5SmtTRmlyOWFXSUU0?=
 =?utf-8?B?QXJhOW5nMS9SWVJuZUhYaElyclR4dElxcWJQS1FoN2hOLytrUUNZMGUrOTBM?=
 =?utf-8?B?L2RBL2tzVVlLUkg2T2JmNGdoSWxBeUdaQnRZM2NpeWxVZlNkdXJrQ3M5cU9M?=
 =?utf-8?B?S0p0RnRRTkZpUllIYW4wUFpyVUxHV1pHM1gxQ0w1Wmo2V0JoZkpoTHJWS012?=
 =?utf-8?B?bXNkVFNUKzlQbzh1ajBTNVhhMk8vOWt4aGZsTUVPTjlSY3ZBT2FIaW5QWWw5?=
 =?utf-8?B?OFhSMDRabEl6NCtMeGxEOXNiSWI4Ukp6T05ycnc1Y1pQV0NyNUVXeDRVTDVz?=
 =?utf-8?B?bWIyeUdkaFdKQVBRNFFFekpDS05MbmF2UDJmbTYxTkx0Qmg4SlNiMWxCdGNy?=
 =?utf-8?B?cDE1S0k1TXVLMS9xMlA2RmpGbmFsV29iNmNZcGxjSkdGNE1NVVcyNVpZSmdN?=
 =?utf-8?B?c2JKWDhueDZvdFZ2NDZSa1BLWUYrSVJHcE5FUmx2ZXc3Q1cwREJjeVZyeUNT?=
 =?utf-8?B?bWx4NDBnKysxYlRHb04zWXh5dmNBUStZc1BCMkQ2RXBJSjczWEtremVWalpa?=
 =?utf-8?B?VVFWa2ZEWVA1Z2ZRZzhmRWFpcmJId0tKWG5lOXNLVHQyN0dqUHd5NWJNQ2Fa?=
 =?utf-8?B?U0g2ZUJwZ1g3QWVRczhwaXkxN0RlZDhwUTU0ZitiR1JzMEFyS2dXUHYwVy9D?=
 =?utf-8?B?ZlFJWWxDRURQdzF0ME5JUHgwZGI3Q1M3N08zM1AwOEVtazcyZTJxTFQ0amdo?=
 =?utf-8?B?T1lyNzRlQk81R05IZnJ4bS9TS1pVSG1YS1RSRGEwa1o4N1RGeEhpUXdkTUVy?=
 =?utf-8?B?ZVVNQXRNdDNNaUhpaUcycTNCS1VVU1dFZ3h1Tlo0azRKcW5QN3BHMGl4dU9N?=
 =?utf-8?B?eWxYSjhkOGYzUmhUNmpsUVFWcURONXRjUXRRb1U4aXJaOEJkOTcxSENXaVRx?=
 =?utf-8?B?N1hJWDJMMHZJVWZ6OWxoTXRSVWU2SWR0VisyZTI3QUd5a2I5ektubFlNNFZR?=
 =?utf-8?B?NGsreEZUVkQrVE1WZ3ZVS3lIM1dpNWd2VllESXJ0aXdOK1Q4a0hDWEJNb0Mr?=
 =?utf-8?B?Yk4xY3pmcm5NQUNUbVhOd0xFcm5qVXBpTzJZbGlWOWNYaWpub2JHdGNUckpV?=
 =?utf-8?B?WC9PbTdtb1pNYUkraDB3WTBSNVFOcHcxQmIxbW44N0xvZUdVRGRXbzdob2Rj?=
 =?utf-8?B?SEpaNVFYMEFYRUtmOTVnc3FPa1B0dlBtOSs4RUFWRU5MalBHUWJZQmZ1NDVu?=
 =?utf-8?B?Z3dEVEtzQU9IVG1mcjF1ZXd2UUgwZFlUU01xWlRIdHJsNlNYZGFQN0RtZCtu?=
 =?utf-8?B?REU4SEYxTzMxcm5yUy9qcUNYMDlpQVB4QXczVDIvVHZoMkJiOEN1VU41V1Ay?=
 =?utf-8?B?Q0FrRE5LYlpZY21MdFluWFRtSC92Q3lyelMvdHhMSUZidUxvajcwWWpDU1B3?=
 =?utf-8?B?VDVRSGhoZWY3OHMxQThrbVZoTGlDSWlZSVoyVXBxZWx3c3B6MEE3ZmtjQUlm?=
 =?utf-8?B?Z1RhWEZ6dWtkNGR1cU9pVWhtQzViQWVESEdFcGFVazIrYjVDL0JJRlFMbFE0?=
 =?utf-8?B?aXlHbktxcThBTmtUK0lYUG9hdE92Z2VvdWdyUjFYS1pVMnZQaDlpSG5HZG85?=
 =?utf-8?B?KzAxNWE2S2ZlWDhTZk54SGdGKzVyUGcyQk83ZFJ1Vk14STZ5bTZmTlA1WnVq?=
 =?utf-8?B?VVZKQUUvNW5qSEZCMzNCaEtzaFRhTVlNSFNjNFE5eXBtVnE4aEQwRE1ZRHBR?=
 =?utf-8?B?VVpmd2Jxc1hpdUJJcGdRUHBsRTI4Vi9PR1hhRTk3ZTRNUDJ4QnVNK2Jrb0J1?=
 =?utf-8?B?SXhyMEpNNVp0anRkWGYzRGdwZkFRZTdxQ2JIaXZuWUExdjdEZWVmazhHaUQ4?=
 =?utf-8?B?Y0hmdnhhYTNsUmxadnVaRGJibG1NTVZuQ2hMS1RHZlpNWTgrREd0RXJnNTBY?=
 =?utf-8?B?N2FNd1A1eWQ5UXg1eHZmVFpCdGdxWFVjaGlRdVpWK3Y4NWhLM2pGNFVIUC9U?=
 =?utf-8?B?MVR6Mkx4V0F4TzhRSEtqbS8yczhVSDlPbXh6N29nMFgyL1pacy82TVZyVXNk?=
 =?utf-8?B?bHBIdkRqTXdZOStUTURiaFBwcU1rNWdGSUs1dVlaeHJaYmh3ZkFTeGYvcjZG?=
 =?utf-8?B?a3pPSTFlS3BmZC9jdFBIZDZXWlBWRzRyNHNaNjJUaTdlQnVkT2NhUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <07E48E1D9D9C854D8324E2873854E0B5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 061f9c53-ff6c-4044-2c1e-08da26b6bc89
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2022 12:25:51.4731
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Spn5cbSoGDNq4GVAyXKwYZmwJKLQFcjCLdlTgvDVrHBRrVQBWWBVy4sQ2TSrrXeOHlHMWQWjEPOv3oov3y8zoSGdhbzr88jgVqBb3biea/E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4760

T24gMjUvMDQvMjAyMiAxMjowNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI1LjA0LjIwMjIg
MTI6MDYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBAQCAtMTc4LDYgKzE3OSw3MSBAQCB2b2lk
IGRvbWFpbl9wYXVzZV9mb3JfZGVidWdnZXIodm9pZCkNCj4+ICAgICAgICAgIHNlbmRfZ2xvYmFs
X3ZpcnEoVklSUV9ERUJVR0dFUik7DQo+PiAgfQ0KPj4gIA0KPj4gK2xvbmcgZ2Ric3hfZG9tY3Rs
KHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCB4ZW5fZG9tY3RsICpkb21jdGwsIGJvb2wgKmNvcHli
YWNrKQ0KPiBJcyB0aGVyZSBhbnl0aGluZyB0aGF0IHJlcXVpcmVzICJsb25nIiAoYW5kIG5vdCBq
dXN0ICJpbnQiKSBoZXJlIGFuZCAuLi4NCj4NCj4+ICt7DQo+PiArICAgIHN0cnVjdCB2Y3B1ICp2
Ow0KPj4gKyAgICBsb25nIHJldCA9IDA7DQo+IC4uLiBoZXJlPw0KDQpDb25zaXN0ZW5jeSB3aXRo
IGl0cyBjYWxsZXIuDQoNCkFsdGhvdWdoIEkgY2FuJ3QgYWN0dWFsbHkgc2VlIGEgZ29vZCByZWFz
b24gZm9yIGFyY2hfZG9fZG9tY3RsKCkgdG8gdXNlDQpsb25nJ3MgZWl0aGVyLCBhbmQgdGhhdCB3
b3VsZCBhdCBsZWFzdCBtZWFuIHdlJ3ZlIG9ubHkgZ290IG9uZSBwbGFjZQ0KZG9pbmcgZXh0ZW5z
aW9uIG9mIHJldC4NCg0KPg0KPj4gKyAgICBzd2l0Y2ggKCBkb21jdGwtPmNtZCApDQo+PiArICAg
IHsNCj4+ICsgICAgY2FzZSBYRU5fRE9NQ1RMX2dkYnN4X2d1ZXN0bWVtaW86DQo+PiArICAgICAg
ICByZXQgPSBnZGJzeF9ndWVzdF9tZW1faW8oZCwgJmRvbWN0bC0+dS5nZGJzeF9ndWVzdF9tZW1p
byk7DQo+PiArICAgICAgICBpZiAoICFyZXQgKQ0KPj4gKyAgICAgICAgICAgICpjb3B5YmFjayA9
IHRydWU7DQo+PiArICAgICAgICBicmVhazsNCj4+ICsNCj4+ICsgICAgY2FzZSBYRU5fRE9NQ1RM
X2dkYnN4X3BhdXNldmNwdToNCj4+ICsgICAgICAgIHJldCA9IC1FQlVTWTsNCj4+ICsgICAgICAg
IGlmICggIWQtPmNvbnRyb2xsZXJfcGF1c2VfY291bnQgKQ0KPj4gKyAgICAgICAgICAgIGJyZWFr
Ow0KPj4gKyAgICAgICAgcmV0ID0gLUVJTlZBTDsNCj4+ICsgICAgICAgIGlmICggKHYgPSBkb21h
aW5fdmNwdShkLCBkb21jdGwtPnUuZ2Ric3hfcGF1c2V1bnBfdmNwdS52Y3B1KSkgPT0gTlVMTCAp
DQo+PiArICAgICAgICAgICAgYnJlYWs7DQo+PiArICAgICAgICByZXQgPSB2Y3B1X3BhdXNlX2J5
X3N5c3RlbWNvbnRyb2xsZXIodik7DQo+PiArICAgICAgICBicmVhazsNCj4+ICsNCj4+ICsgICAg
Y2FzZSBYRU5fRE9NQ1RMX2dkYnN4X3VucGF1c2V2Y3B1Og0KPj4gKyAgICAgICAgcmV0ID0gLUVC
VVNZOw0KPj4gKyAgICAgICAgaWYgKCAhZC0+Y29udHJvbGxlcl9wYXVzZV9jb3VudCApDQo+PiAr
ICAgICAgICAgICAgYnJlYWs7DQo+PiArICAgICAgICByZXQgPSAtRUlOVkFMOw0KPj4gKyAgICAg
ICAgaWYgKCAodiA9IGRvbWFpbl92Y3B1KGQsIGRvbWN0bC0+dS5nZGJzeF9wYXVzZXVucF92Y3B1
LnZjcHUpKSA9PSBOVUxMICkNCj4+ICsgICAgICAgICAgICBicmVhazsNCj4+ICsgICAgICAgIHJl
dCA9IHZjcHVfdW5wYXVzZV9ieV9zeXN0ZW1jb250cm9sbGVyKHYpOw0KPj4gKyAgICAgICAgaWYg
KCByZXQgPT0gLUVJTlZBTCApDQo+PiArICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19HX1dBUk5J
TkcNCj4+ICsgICAgICAgICAgICAgICAgICAgIldBUk46ICVwZCBhdHRlbXB0aW5nIHRvIHVucGF1
c2UgJXB2IHdoaWNoIGlzIG5vdCBwYXVzZWRcbiIsDQo+PiArICAgICAgICAgICAgICAgICAgIGN1
cnJlbnQtPmRvbWFpbiwgdik7DQo+PiArICAgICAgICBicmVhazsNCj4+ICsNCj4+ICsgICAgY2Fz
ZSBYRU5fRE9NQ1RMX2dkYnN4X2RvbXN0YXR1czoNCj4+ICsgICAgICAgIGRvbWN0bC0+dS5nZGJz
eF9kb21zdGF0dXMudmNwdV9pZCA9IC0xOw0KPj4gKyAgICAgICAgZG9tY3RsLT51LmdkYnN4X2Rv
bXN0YXR1cy5wYXVzZWQgPSBkLT5jb250cm9sbGVyX3BhdXNlX2NvdW50ID4gMDsNCj4+ICsgICAg
ICAgIGlmICggZG9tY3RsLT51LmdkYnN4X2RvbXN0YXR1cy5wYXVzZWQgKQ0KPj4gKyAgICAgICAg
ew0KPj4gKyAgICAgICAgICAgIGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkNCj4+ICsgICAgICAgICAg
ICB7DQo+PiArICAgICAgICAgICAgICAgIGlmICggdi0+YXJjaC5nZGJzeF92Y3B1X2V2ZW50ICkN
Cj4+ICsgICAgICAgICAgICAgICAgew0KPj4gKyAgICAgICAgICAgICAgICAgICAgZG9tY3RsLT51
LmdkYnN4X2RvbXN0YXR1cy52Y3B1X2lkID0gdi0+dmNwdV9pZDsNCj4+ICsgICAgICAgICAgICAg
ICAgICAgIGRvbWN0bC0+dS5nZGJzeF9kb21zdGF0dXMudmNwdV9ldiA9DQo+PiArICAgICAgICAg
ICAgICAgICAgICAgICAgdi0+YXJjaC5nZGJzeF92Y3B1X2V2ZW50Ow0KPj4gKyAgICAgICAgICAg
ICAgICAgICAgdi0+YXJjaC5nZGJzeF92Y3B1X2V2ZW50ID0gMDsNCj4+ICsgICAgICAgICAgICAg
ICAgICAgIGJyZWFrOw0KPj4gKyAgICAgICAgICAgICAgICB9DQo+PiArICAgICAgICAgICAgfQ0K
Pj4gKyAgICAgICAgfQ0KPj4gKyAgICAgICAgKmNvcHliYWNrID0gdHJ1ZTsNCj4+ICsgICAgICAg
IGJyZWFrOw0KPj4gKw0KPj4gKyAgICBkZWZhdWx0Og0KPj4gKyAgICAgICAgQVNTRVJUX1VOUkVB
Q0hBQkxFKCk7DQo+PiArICAgICAgICByZXQgPSAtRU5PU1lTOw0KPj4gKyAgICB9DQo+IEp1c3Qg
YXMgYSByZW1hcms6IEl0J3MgbmV2ZXIgcmVhbGx5IGNsZWFyIHRvIG1lIHdoZXRoZXIgd2UgYWN0
dWFsbHkgd2FudA0KPiB0byBwZXJtaXQgb21pdHRpbmcgImJyZWFrIiBpbiBjYXNlcyBsaWtlIHRo
aXMgb25lLg0KDQpUaGF0IHdhcyBhbiBvdmVyc2lnaHQuwqAgSSdkIGludGVuZGVkIHRvIGluY2x1
ZGUgb25lLg0KDQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vZ2Ric3guaA0KPj4g
KysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2dkYnN4LmgNCj4+IEBAIC0yLDE4ICsyLDI3
IEBADQo+PiAgI2lmbmRlZiBfX1g4Nl9HREJYX0hfXw0KPj4gICNkZWZpbmUgX19YODZfR0RCWF9I
X18NCj4+ICANCj4+IC0jaWZkZWYgQ09ORklHX0dEQlNYDQo+PiArI2luY2x1ZGUgPHhlbi9zdGRi
b29sLmg+DQo+PiAgDQo+PiAgc3RydWN0IGRvbWFpbjsNCj4+IC1zdHJ1Y3QgeGVuX2RvbWN0bF9n
ZGJzeF9tZW1pbzsNCj4+ICtzdHJ1Y3QgeGVuX2RvbWN0bDsNCj4+ICANCj4+IC1pbnQgZ2Ric3hf
Z3Vlc3RfbWVtX2lvKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCB4ZW5fZG9tY3RsX2dkYnN4X21l
bWlvICppb3ApOw0KPj4gKyNpZmRlZiBDT05GSUdfR0RCU1gNCj4+ICANCj4+ICB2b2lkIGRvbWFp
bl9wYXVzZV9mb3JfZGVidWdnZXIodm9pZCk7DQo+PiAgDQo+PiArbG9uZyBnZGJzeF9kb21jdGwo
c3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHhlbl9kb21jdGwgKmRvbWN0bCwgYm9vbCAqY29weWJh
Y2spOw0KPj4gKw0KPj4gICNlbHNlDQo+PiAgDQo+PiArI2luY2x1ZGUgPHhlbi9lcnJuby5oPg0K
Pj4gKw0KPj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBkb21haW5fcGF1c2VfZm9yX2RlYnVnZ2VyKHZv
aWQpIHt9DQo+PiAgDQo+PiArbG9uZyBnZGJzeF9kb21jdGwoc3RydWN0IGRvbWFpbiAqZCwgc3Ry
dWN0IHhlbl9kb21jdGwgKmRvbWN0bCwgYm9vbCAqY29weWJhY2spDQo+IHN0YXRpYyBpbmxpbmU/
DQoNCk9vcHMgeWVzLsKgIEkgY2xlYXJseSBuZWVkIG1vcmUgY29mZmVlLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:29:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:29:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312863.530256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixqc-0006q8-Al; Mon, 25 Apr 2022 12:29:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312863.530256; Mon, 25 Apr 2022 12:29:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixqc-0006q1-7c; Mon, 25 Apr 2022 12:29:46 +0000
Received: by outflank-mailman (input) for mailman id 312863;
 Mon, 25 Apr 2022 12:29:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nixqb-0006pr-81; Mon, 25 Apr 2022 12:29:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nixqb-0002u2-5d; Mon, 25 Apr 2022 12:29:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nixqa-0007KX-Ro; Mon, 25 Apr 2022 12:29:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nixqa-0000S1-RM; Mon, 25 Apr 2022 12:29:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yyaUZ6ikHIyUFtpNY8MosmDkLMcV66aBfZahP8DcacI=; b=brLm2M9gH4nWkzBuq8nbbdw7wP
	WvQchKeFOvcLN17BdUA4r/r6BBBsVK1uQ2ZJWrGCMB8toxVrHRnJoaUs7WTzIYdogMWmF3l4hTUaU
	oEkAwFwxk7Erlm6lX4VnaN5PH9GZmuc95t0tR3HI31PFagAOKk/D3blupxNrnRAId5Lw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169705-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169705: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 12:29:44 +0000

flight 169705 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169705/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  618 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:37:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:37:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312874.530267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixyO-0008Ru-4j; Mon, 25 Apr 2022 12:37:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312874.530267; Mon, 25 Apr 2022 12:37:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nixyO-0008Rn-1D; Mon, 25 Apr 2022 12:37:48 +0000
Received: by outflank-mailman (input) for mailman id 312874;
 Mon, 25 Apr 2022 12:37:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Eo9G=VD=citrix.com=prvs=107e1699f=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nixyM-0008Rh-M7
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 12:37:46 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80544ce1-c494-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 14:37:44 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80544ce1-c494-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650890264;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=XQJj0IseyZHMSZc/mrIZz/x+xkn7YoebrjeeAlWQNFo=;
  b=AOT8bLE98jYOT4GiLZL/n81GcFKzx14aHz+qAmSeFpC7Bl4HykchK0W1
   ULXdyi7/8poYreWy17RiNNuxhqcth22yUUl92Atu3qh+sUAdDsrjFhSmo
   AIH6DqgV+q3c0RaB5TeZilmfNufmQv/y77iTT1GLJBPcnm7EHu+v2Or1d
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 72295449
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:64iRqa/eNYGP75oqzEnbDrUDbX6TJUtcMsCJ2f8bNWPcYEJGY0x3z
 WoZCGnQPamKMGTwL413YNvg8k9Uu8SBmocwQQVlpH08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YLkW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncWIa144AYvho/0YVB99C3xyHLdi8oaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 JBDOGczMEWojxtnGEoWDsMOldeTtlLadBp9lwyTi7Y1/D2GpOB2+Oe0a4eEEjCQfu1XkVyfv
 Xnu5HniD1cRM9n34Riv/2+oh+TPtTjmQ49UH7q9ntZgjUeP3GUVBFsTXEGivPiiokekXpRUL
 El80hQpqa8+5Um6VO7XVhezoGOHlhMEUt8WGOo/gCmW0bbd6QudAmkCTxZCZcYguctwQiYlv
 neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty9v+pIA+iDrfQ9AlF7S65vXqHRngz
 jbMqzIx74j/luZSif/9pwqexWvx+N6ZFWbZ+zk7QEr81iEgdbGDSrex7F/dyO4dIKeDalO46
 S1sd9el0MgCCpSElSqoSeoLHa206/vtDAAwkWKDDLF6qW3zpifLkZR4pWgneRw3appslSrBO
 he7hO9H2HNE0JJGh4dTapn5NcklxLOI+T/NBqGNNYomjnScmWa6EMBSiay4gjqFfKsEy/hX1
 XKnnSGEVytyNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXTNr9ktfve8ViPr
 b6z0vdmLT0FCYUShQGNr+Yuwa0idyBnVfgaVeQKHgJ8HuaWMD54UKKAqV/QU4dkg75Uho/1E
 oKVASdlJK7ErSSfc22iMyk7AJu2BMYXhS9rbEQEYAfzs1B+MNnH0UvqX8ZuFVXR3Lc4lqAco
 jhsU5joP8mjvRyapWRANcWt8N0KmdbCrVvmAhdJqQMXJ/ZILzElMPe4Fucz3EHi1haKiPY=
IronPort-HdrOrdr: A9a23:CFfzO6Oqtr7yKsBcTs2jsMiBIKoaSvp037Eqv3oedfUzSL3+qy
 nOpoV+6faaslYssR0b9exoW5PwJE80l6QFgrX5VI3KNGKN1VdARLsSi7cKqAeAJ8SRzIFgPN
 9bAspDNOE=
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="72295449"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Juergen Gross <jgross@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: [PATCH v3] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Date: Mon, 25 Apr 2022 13:37:17 +0100
Message-ID: <20220425123717.18876-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

When CONFIG_GDBSX is compiled out, iommu_do_domctl() falls over a NULL
pointer.  One of several bugs here is known-but-compiled-out subops falling
into the default chain and hitting unrelated logic.

Remove the CONFIG_GDBSX ifdefary in arch_do_domctl() by implementing
gdbsx_domctl() and moving the logic across.

As minor cleanup,
 * gdbsx_guest_mem_io() can become static
 * Remove opencoding of domain_vcpu() and %pd

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Liu <wl@xen.org>
CC: Julien Grall <julien@xen.org>
CC: Juergen Gross <jgross@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

v2:
 * Implement the "split into new function" approach from the RFC.
v3:
 * Switch to int.
 * Insert missing break.
 * static inline for stub.
---
 xen/arch/x86/domctl.c            | 61 +---------------------------------
 xen/arch/x86/gdbsx.c             | 70 +++++++++++++++++++++++++++++++++++++++-
 xen/arch/x86/include/asm/gdbsx.h | 16 +++++++--
 3 files changed, 83 insertions(+), 64 deletions(-)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index c20ab4352715..9131acb8a230 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -816,71 +816,12 @@ long arch_do_domctl(
     }
 #endif
 
-#ifdef CONFIG_GDBSX
     case XEN_DOMCTL_gdbsx_guestmemio:
-        ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
-        if ( !ret )
-           copyback = true;
-        break;
-
     case XEN_DOMCTL_gdbsx_pausevcpu:
-    {
-        struct vcpu *v;
-
-        ret = -EBUSY;
-        if ( !d->controller_pause_count )
-            break;
-        ret = -EINVAL;
-        if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= d->max_vcpus ||
-             (v = d->vcpu[domctl->u.gdbsx_pauseunp_vcpu.vcpu]) == NULL )
-            break;
-        ret = vcpu_pause_by_systemcontroller(v);
-        break;
-    }
-
     case XEN_DOMCTL_gdbsx_unpausevcpu:
-    {
-        struct vcpu *v;
-
-        ret = -EBUSY;
-        if ( !d->controller_pause_count )
-            break;
-        ret = -EINVAL;
-        if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= d->max_vcpus ||
-             (v = d->vcpu[domctl->u.gdbsx_pauseunp_vcpu.vcpu]) == NULL )
-            break;
-        ret = vcpu_unpause_by_systemcontroller(v);
-        if ( ret == -EINVAL )
-            printk(XENLOG_G_WARNING
-                   "WARN: d%d attempting to unpause %pv which is not paused\n",
-                   currd->domain_id, v);
-        break;
-    }
-
     case XEN_DOMCTL_gdbsx_domstatus:
-    {
-        struct vcpu *v;
-
-        domctl->u.gdbsx_domstatus.vcpu_id = -1;
-        domctl->u.gdbsx_domstatus.paused = d->controller_pause_count > 0;
-        if ( domctl->u.gdbsx_domstatus.paused )
-        {
-            for_each_vcpu ( d, v )
-            {
-                if ( v->arch.gdbsx_vcpu_event )
-                {
-                    domctl->u.gdbsx_domstatus.vcpu_id = v->vcpu_id;
-                    domctl->u.gdbsx_domstatus.vcpu_ev =
-                        v->arch.gdbsx_vcpu_event;
-                    v->arch.gdbsx_vcpu_event = 0;
-                    break;
-                }
-            }
-        }
-        copyback = true;
+        ret = gdbsx_domctl(d, domctl, &copyback);
         break;
-    }
-#endif
 
     case XEN_DOMCTL_setvcpuextstate:
     case XEN_DOMCTL_getvcpuextstate:
diff --git a/xen/arch/x86/gdbsx.c b/xen/arch/x86/gdbsx.c
index 6ef46e8ea77d..21442f5dff1a 100644
--- a/xen/arch/x86/gdbsx.c
+++ b/xen/arch/x86/gdbsx.c
@@ -152,7 +152,8 @@ static unsigned int dbg_rw_guest_mem(struct domain *dp, unsigned long addr,
     return len;
 }
 
-int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop)
+static int gdbsx_guest_mem_io(
+    struct domain *d, struct xen_domctl_gdbsx_memio *iop)
 {
     if ( d && !d->is_dying )
     {
@@ -178,6 +179,73 @@ void domain_pause_for_debugger(void)
         send_global_virq(VIRQ_DEBUGGER);
 }
 
+int gdbsx_domctl(struct domain *d, struct xen_domctl *domctl, bool *copyback)
+{
+    struct vcpu *v;
+    int ret;
+
+    switch ( domctl->cmd )
+    {
+    case XEN_DOMCTL_gdbsx_guestmemio:
+        ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
+        if ( !ret )
+            *copyback = true;
+        break;
+
+    case XEN_DOMCTL_gdbsx_pausevcpu:
+        ret = -EBUSY;
+        if ( !d->controller_pause_count )
+            break;
+        ret = -EINVAL;
+        if ( (v = domain_vcpu(d, domctl->u.gdbsx_pauseunp_vcpu.vcpu)) == NULL )
+            break;
+        ret = vcpu_pause_by_systemcontroller(v);
+        break;
+
+    case XEN_DOMCTL_gdbsx_unpausevcpu:
+        ret = -EBUSY;
+        if ( !d->controller_pause_count )
+            break;
+        ret = -EINVAL;
+        if ( (v = domain_vcpu(d, domctl->u.gdbsx_pauseunp_vcpu.vcpu)) == NULL )
+            break;
+        ret = vcpu_unpause_by_systemcontroller(v);
+        if ( ret == -EINVAL )
+            printk(XENLOG_G_WARNING
+                   "WARN: %pd attempting to unpause %pv which is not paused\n",
+                   current->domain, v);
+        break;
+
+    case XEN_DOMCTL_gdbsx_domstatus:
+        ret = 0;
+        domctl->u.gdbsx_domstatus.vcpu_id = -1;
+        domctl->u.gdbsx_domstatus.paused = d->controller_pause_count > 0;
+        if ( domctl->u.gdbsx_domstatus.paused )
+        {
+            for_each_vcpu ( d, v )
+            {
+                if ( v->arch.gdbsx_vcpu_event )
+                {
+                    domctl->u.gdbsx_domstatus.vcpu_id = v->vcpu_id;
+                    domctl->u.gdbsx_domstatus.vcpu_ev =
+                        v->arch.gdbsx_vcpu_event;
+                    v->arch.gdbsx_vcpu_event = 0;
+                    break;
+                }
+            }
+        }
+        *copyback = true;
+        break;
+
+    default:
+        ASSERT_UNREACHABLE();
+        ret = -ENOSYS;
+        break;
+    }
+
+    return ret;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/include/asm/gdbsx.h b/xen/arch/x86/include/asm/gdbsx.h
index 938eb74e2e25..e906be9ea318 100644
--- a/xen/arch/x86/include/asm/gdbsx.h
+++ b/xen/arch/x86/include/asm/gdbsx.h
@@ -2,18 +2,28 @@
 #ifndef __X86_GDBX_H__
 #define __X86_GDBX_H__
 
-#ifdef CONFIG_GDBSX
+#include <xen/stdbool.h>
 
 struct domain;
-struct xen_domctl_gdbsx_memio;
+struct xen_domctl;
 
-int gdbsx_guest_mem_io(struct domain *d, struct xen_domctl_gdbsx_memio *iop);
+#ifdef CONFIG_GDBSX
 
 void domain_pause_for_debugger(void);
 
+int gdbsx_domctl(struct domain *d, struct xen_domctl *domctl, bool *copyback);
+
 #else
 
+#include <xen/errno.h>
+
 static inline void domain_pause_for_debugger(void) {}
 
+static inline int gdbsx_domctl(
+    struct domain *d, struct xen_domctl *domctl, bool *copyback)
+{
+    return -ENOSYS;
+}
+
 #endif /* CONFIG_GDBSX */
 #endif /* __X86_GDBX_H__ */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:53:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:53:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312883.530278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyDK-0002cc-FL; Mon, 25 Apr 2022 12:53:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312883.530278; Mon, 25 Apr 2022 12:53:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyDK-0002cV-C4; Mon, 25 Apr 2022 12:53:14 +0000
Received: by outflank-mailman (input) for mailman id 312883;
 Mon, 25 Apr 2022 12:53:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=mW0y=VD=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1niyDI-0002cP-7y
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 12:53:12 +0000
Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com
 [2607:f8b0:4864:20::112c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a8b74d29-c496-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 14:53:10 +0200 (CEST)
Received: by mail-yw1-x112c.google.com with SMTP id
 00721157ae682-2ec42eae76bso146653967b3.10
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 05:53:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8b74d29-c496-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=oeP4s0HdwdBZvzXoc/7vlPduwrbLkGhkuEwYixC6uho=;
        b=TPK/lE04EMJgYRAiUSz0pRYespb7rtwD9a4Dvwb5Qo2FdPi9tmNNXzSJxuAgiFY20/
         DKP6Rn2Ax1TfLwr7LPjT7DlDagfR7tTVLfV0pWc5/t7MJaWJqKLJnQqWashJ3D4y+N3d
         XBA0lGVjOLqePQuvdcDb13ywU6+q5ud48Fmdtg15dCrUCVAEzCrEIxiYKt4ry4q6SG78
         qMJtPWRHTR3BoNj3YgW24QZbN3u7Sj+ji8F5owQEOEFM8TsMbp4mp5ccBkcLOJKPgB9U
         gWx+nELlpfeI2cyg78v3Co8OPGtUZNoaNanzdspI3O8hMXh91tqEuRu/91sDmwRnbLcC
         okYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=oeP4s0HdwdBZvzXoc/7vlPduwrbLkGhkuEwYixC6uho=;
        b=731PMHpM20HQhRbqIF6YykvGNfa1lPxOsD+2pUsrNts8KWsuF500qx8Z19JKMFKlns
         He4PbdDzGQfBuLt3RM2lQ87f7xlekN+EOz7uzXp9aWS8xaQVdntDUMNKOBKSt9WX9jL0
         gYZGzRliroXqfrVWOEcrn6zuXqgHL5vRe3L+NPB8FnflVnyWgKsVl62SgtGzYVSzOiN+
         CRTxSwq5SmldIqRGzOf2VN4BZ68CJyqdP0phZCWg4KTvQdFcDxxqnZ1jiGg4j8YP9qOZ
         ooUiSVuEJ9EEKApxRdtkkqMBn3vcCAT10HK7qD7pcDylAYXey/zWaPhd0iyPPHcrS+4l
         UO7Q==
X-Gm-Message-State: AOAM533S4Z/o4finnxTInumuCYp8fxzmMo5kq2iNc88I3eNzASmtfyhU
	bRAo813wu3ql5v0UrdxaE3LulfAhKXnDimBZQ9Q=
X-Google-Smtp-Source: ABdhPJwTn9/UmNqF+dCHTr5FEj+nEslCC4Tn3McubAcShYsmLWA3d7yMpBLZ0nDFqslDLWFJGgltzPkdPcQJ68ihEKU=
X-Received: by 2002:a81:7b05:0:b0:2f1:7f75:1d1e with SMTP id
 w5-20020a817b05000000b002f17f751d1emr15771847ywc.520.1650891189229; Mon, 25
 Apr 2022 05:53:09 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <CABfawhki8YVxycv_zdDqDuOYvBdobdskXnjjdjiF7UND3784cg@mail.gmail.com>
 <310ab91a-60bd-f4fa-aeee-28aab43aabbe@suse.com> <CABfawhmzz5OwYr93EO7UAnb1X+vBoi3u=YVW6HMV5KpH_iEGeg@mail.gmail.com>
In-Reply-To: <CABfawhmzz5OwYr93EO7UAnb1X+vBoi3u=YVW6HMV5KpH_iEGeg@mail.gmail.com>
From: George Dunlap <dunlapg@umich.edu>
Date: Mon, 25 Apr 2022 13:52:58 +0100
Message-ID: <CAFLBxZaT1jRo8_KBKOFMdwvM0q=LAoUSxuHNkgOrFA00a9vVdA@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Jan Beulich <jbeulich@suse.com>, Tamas K Lengyel <tamas.lengyel@intel.com>, 
	Alexandru Isaila <aisaila@bitdefender.com>, Petre Pircalabu <ppircalabu@bitdefender.com>, 
	Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien@xen.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>
Content-Type: multipart/alternative; boundary="000000000000e59c3605dd7a0ed5"

--000000000000e59c3605dd7a0ed5
Content-Type: text/plain; charset="UTF-8"

On Mon, Apr 25, 2022 at 12:29 PM Tamas K Lengyel <tamas@tklengyel.com>
wrote:

>
>
> On Mon, Apr 25, 2022, 3:49 AM Jan Beulich <jbeulich@suse.com> wrote:
>
>> On 22.04.2022 16:07, Tamas K Lengyel wrote:
>> > On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel <
>> tamas.lengyel@intel.com> wrote:
>> >>
>> >> Allow specify distinct parts of the fork VM to be reset. This is
>> useful when a
>> >> fuzzing operation involves mapping in only a handful of pages that are
>> known
>> >> ahead of time. Throwing these pages away just to be re-copied
>> immediately is
>> >> expensive, thus allowing to specify partial resets can speed things up.
>> >>
>> >> Also allow resetting to be initiated from vm_event responses as an
>> >> optimization.
>> >>
>> >> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>> >
>> > Patch ping. Could I get a Reviewed-by if there are no objections?
>>
>> Hmm, this is a little difficult. I'd be willing to give an ack, but that's
>> meaningless for most of the code here. Besides a stylistic issue I did
>> point out which I'm not happy with, I'm afraid I'm not good enough at
>> mem-sharing and forking. Therefore I wouldn't want to offer an R-b.
>> Considering the VM event interaction, maybe the BitDefender guys could
>> take a stab?
>>
>> Of course you'd then still need a tool stack side ack.
>>
>
> So my take is that noone cares about mem_sharing, which is fine, its an
> obscure experiment subsystem.
>

My take is slightly different; it's more that the project is large enough
that it's difficult to se where the needs are.  If Roger or Andy or I or
Wei or anyone see a thread with you & Jan going back and forth, it's
natural for us to assume that you & Jan have it in hand, and there's no
need for us to read through the thread.  Jan dislikes asking specific
people for a review, but many of the rest of us have sort of gotten in the
habit of doing so, as a way to solve the "visibility" issue.  The only
other way I can think of to solve the problem is to have a robot try to
assign tasks to people -- a method that has received skepticism, and would
also require a non-negligible amount of tooling to be written.


> But the only path I see as maintainer to get anything in-tree is if I hand
> the task of writing the patch to a coworker who then sends it in so that I
> can ack it. This is clearly disfunctional and is to the detriment of the
> project overall. We need to get some rules in place to avoid situations
> like this that clearly lead to no development and no improvement and a huge
> incentive to forgot about upstreaming. With no substantive objections but
> no acks a maintainer should be able to get changes in-tree. That's part of
> what I would consider maintaining a codebase to be!
>

Another possibility would be to ask your colleague actually do a
Reviewed-by.  The first time or two they might not be "of suitable stature
in the community", but I don't think it should take long to establish such
a stature, if they were doing the review in earnest.

I do agree that it seems like in this situation, the bar seems too high for
you to get your own code checked in.  I'd be open to the argument that we
should change the text of the check-in policy in MAINTAINERS to allow
maintainer modifications with only an Acked-by.


> Anyway, to be realistic I don't expect that option to materialize so I'm
> very close to just stop all contributions to the project. It's dishartening.
>


I can understand why you'd be disheartened if you thought you just couldn't
get any code checked in even as maintainer.  However, there are lots of
escalation paths open to you: you could email the community manager (me);
you could make a wider appeal on IRC for reviewers; you could raise the
general issue at the community call; you could send a patch proposing
changes to the check-in procedure described in MAINTAINERS.

 -George

>

--000000000000e59c3605dd7a0ed5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr 25, 2022 at 12:29 PM Tama=
s K Lengyel &lt;<a href=3D"mailto:tamas@tklengyel.com">tamas@tklengyel.com<=
/a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0=
px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><=
div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" c=
lass=3D"gmail_attr">On Mon, Apr 25, 2022, 3:49 AM Jan Beulich &lt;<a href=
=3D"mailto:jbeulich@suse.com" target=3D"_blank">jbeulich@suse.com</a>&gt; w=
rote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 22.04.2=
022 16:07, Tamas K Lengyel wrote:<br>
&gt; On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel &lt;<a href=3D"mailto:=
tamas.lengyel@intel.com" rel=3D"noreferrer" target=3D"_blank">tamas.lengyel=
@intel.com</a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; Allow specify distinct parts of the fork VM to be reset. This is u=
seful when a<br>
&gt;&gt; fuzzing operation involves mapping in only a handful of pages that=
 are known<br>
&gt;&gt; ahead of time. Throwing these pages away just to be re-copied imme=
diately is<br>
&gt;&gt; expensive, thus allowing to specify partial resets can speed thing=
s up.<br>
&gt;&gt;<br>
&gt;&gt; Also allow resetting to be initiated from vm_event responses as an=
<br>
&gt;&gt; optimization.<br>
&gt;&gt;<br>
&gt;&gt; Signed-off-by: Tamas K Lengyel &lt;<a href=3D"mailto:tamas.lengyel=
@intel.com" rel=3D"noreferrer" target=3D"_blank">tamas.lengyel@intel.com</a=
>&gt;<br>
&gt; <br>
&gt; Patch ping. Could I get a Reviewed-by if there are no objections?<br>
<br>
Hmm, this is a little difficult. I&#39;d be willing to give an ack, but tha=
t&#39;s<br>
meaningless for most of the code here. Besides a stylistic issue I did<br>
point out which I&#39;m not happy with, I&#39;m afraid I&#39;m not good eno=
ugh at<br>
mem-sharing and forking. Therefore I wouldn&#39;t want to offer an R-b.<br>
Considering the VM event interaction, maybe the BitDefender guys could<br>
take a stab?<br>
<br>
Of course you&#39;d then still need a tool stack side ack.<br></blockquote>=
</div></div><div dir=3D"auto"><br></div><div dir=3D"auto">So my take is tha=
t noone cares about mem_sharing, which is fine, its an obscure experiment s=
ubsystem. </div></div></blockquote><div><br></div><div>My take is slightly =
different; it&#39;s more that the project is large=20
enough that it&#39;s difficult to se where the needs are.=C2=A0 If Roger or=
 Andy=20
or I or Wei or anyone see a thread with you &amp; Jan going back and=20
forth, it&#39;s natural for us to assume that you &amp; Jan have it in hand=
,
 and there&#39;s no need for us to read through the thread.=C2=A0 Jan disli=
kes=20
asking specific people for a review, but many of the rest of us have=20
sort of gotten in the habit of doing so, as a way to solve the=20
&quot;visibility&quot; issue.=C2=A0 The only other way I can think of to so=
lve the=20
problem is to have a robot try to assign tasks to people -- a method=20
that has received skepticism, and would also require a non-negligible amoun=
t of tooling to be written. </div><div>=C2=A0</div><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex"><div dir=3D"auto"><div dir=3D"auto">But the only =
path I see as maintainer to get anything in-tree is if I hand the task of w=
riting the patch to a coworker who then sends it in so that I can ack it. T=
his is clearly disfunctional and is to the detriment of the project overall=
. We need to get some rules in place to avoid situations like this that cle=
arly lead to no development and no improvement and a huge incentive to forg=
ot about upstreaming. With no substantive objections but no acks a maintain=
er should be able to get changes in-tree. That&#39;s part of what I would c=
onsider maintaining a codebase to be!</div></div></blockquote><div><br></di=
v><div><div class=3D"gmail_quote">Another possibility would be to ask your=
=20
colleague actually do a Reviewed-by.=C2=A0 The first time or two they might=
=20
not be &quot;of suitable stature in the community&quot;, but I don&#39;t th=
ink it=20
should take long to establish such a stature, if they were doing the=20
review in earnest.<br></div><div class=3D"gmail_quote"><br></div><div class=
=3D"gmail_quote">I
 do agree that it seems like in this situation, the bar seems too high=20
for you to get your own code checked in.=C2=A0 I&#39;d be open to the argum=
ent=20
that we should change the text of the check-in policy in MAINTAINERS to=20
allow maintainer modifications with only an Acked-by.</div></div><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"auto=
"><div dir=3D"auto">Anyway, to be realistic I don&#39;t expect that option =
to materialize so I&#39;m very close to just stop all contributions to the =
project. It&#39;s dishartening.</div></div></blockquote><div><br></div><br>=
<div class=3D"gmail_quote">I can understand why you&#39;d be disheartened i=
f=20
you thought you just couldn&#39;t get any code checked in even as=20
maintainer.=C2=A0 However, there are lots of escalation paths open to you:=
=20
you could email the community manager (me); you could make a wider=20
appeal on IRC for reviewers; you could raise the general issue at the=20
community call; you could send a patch proposing changes to the check-in
 procedure described in MAINTAINERS.</div><font color=3D"#888888"><div clas=
s=3D"gmail_quote"><br></div><div class=3D"gmail_quote">=C2=A0-George</div><=
/font><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex">
</blockquote></div></div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
</blockquote></div></div>

--000000000000e59c3605dd7a0ed5--


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:59:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:59:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312890.530289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyJA-0003Kp-8w; Mon, 25 Apr 2022 12:59:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312890.530289; Mon, 25 Apr 2022 12:59:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyJA-0003Ki-59; Mon, 25 Apr 2022 12:59:16 +0000
Received: by outflank-mailman (input) for mailman id 312890;
 Mon, 25 Apr 2022 12:59:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1niyJ8-0003Kc-Og
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 12:59:14 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8072877f-c497-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 14:59:13 +0200 (CEST)
Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 08:59:10 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by PH0PR03MB5734.namprd03.prod.outlook.com (2603:10b6:510:41::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr
 2022 12:59:09 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 12:59:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8072877f-c497-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650891553;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=kczc593QPFPDyUXv5pbci64pg4O9zshNt3kH9RRv9sk=;
  b=Ma/izKwA7OsGy5gN166yeFVvl1oHkgJFiTfqmiF/VERo/ET39DVp1fG7
   OYFdIJqsqEDcQsz8TLpqgxRLigelhzhtpOWAP4cQe+m1pEfHZ1UtfrNCQ
   8AjeG3Ni+flZZExjkgA11VelqdVRk7egmEg0ikvq7zlTHJSUloJDaJP69
   w=;
X-IronPort-RemoteIP: 104.47.66.47
X-IronPort-MID: 69874314
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:HZ4Wn6t7onhtTQqoYVk6IeOF2OfnVFJfMUV32f8akzHdYApBsoF/q
 tZmKWGFa/rfZTPzeYh+a9ixoE8E6JaAzNFgTVRurig0Qy4Q+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X5
 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8jO/DNqsctfCNGLABENI5e/o/GBCCg5Jn7I03uKxMAwt1IJWRvZ8g9xbwyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4EGmmtv7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9gPF+vZsujS7IApZ8IbTHPXuQvGwAsRknEHDh
 1Oc0TTFO0RPXDCY4X/fmp62vcfNly7mXIMZFJWj6+VnxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzWnpFaUsxhaXMBfe8U45xuK0bH8+BuCCy4PSTspVTA9nMo/RDhv0
 0DTmdrsXGZrqOfNFS3b8aqIpzSvPyRTNXUFeSIPUQoC5Z/kvZ03iRXMCN1kFcZZk+HIJN05+
 BjSxABWulnZpZRjO3mTlbwfvw+Rmw==
IronPort-HdrOrdr: A9a23:yPlUFqPhSOCfO8BcT4/255DYdb4zR+YMi2TDiHoBKiC9I/b5qy
 nxppUmPEfP+UYssQIb8+xoWZPsfZq4z/IFg7X5Uo3SIjUO1FHYSr2KzLGSvgEIeBeOsdK1t5
 0QApSWYeeYZTMU47eekW3IdOrIqOP3oJxAqt2usEuFJjsaE52Imj0JcDpzZXcGPzWua6BJba
 Z0z/A34QaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnA4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlMFtyssHfyWG1SYczegNkHmpDy1L/sqq
 iSn/4UBbUo15oWRBDqnfKi4Xiw7N9k0Q6Q9bbRuwqQnSW+fkNoNyM7v/MkTvKR0TtXgDmlvZ
 g7ql5wbPdsfGT9dP6R3am9azh60kWzunYsiugVkjhWVpYfcqZYqcgF8FpSC4poJlO51GmJKp
 giMCjw3ocXTbqhVQGbgoCv+q3iYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/
 nNdv0ArsALcuYGKaZmQOsRS8q+DWLABRrKLWKJOFziUKUKIWjEpZL76Kg8oOuqZJsLxp0vn4
 mpaiIciUciP0b1TcGe1pxC9R7ABG27QDT208lbo4N0v7XtLYCbcBFqBDsV4oedS952OLyTZx
 9yAuMZPxbOFxqkJW8S5Xy3Z3B7EwhVbPEo
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="69874314"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XGazSG4LpNP2E1rKPUOs/8+J36f2A3hbutcamBZawWoA8xDbS5JX9Hh90Zs/iXKylRAzPJWWhaCm/MdljlnDGy7uhuP2wEV9E+j99mRZz3YtrQHoARhXzEYmxXAS/ZGX9ghkG5l9qrA/Y8P3qRBfkUrleVX3KkIF4DL/rR+6J2IPD/ALhs/6PVuer/OF8zIfSvjs5eHAksmedftwHcOB6u1UOCrSxJ5kEZ3RYdAEf8f+mPhLrX5AY9qj0tCe8ABNx5E3dob+dt9VcmTldlGpqr8HdEkEk9c6urhwPkIHjIBXUBpleJG4Wb2EmTvwTkm5fhw413Hduzwe8JP1Jo9j8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8PyDMa2lIDtTbxbzDU1eV3lPk5v0MMJf5Oc/fUPvnTo=;
 b=H4agiNCbaOOJG5LY5CeA3KFZvP2L9I554bWV1aa2bjSwAWm/q2fKxbEp2Zocp04Q+ULWiiI9cF+Lq6NRKJGWDOQKX6XXxCuuZOhWPLa+pJLHjR3PK3lp0FiBKF0SyqNKet8ajSPSFhOsTHEiEnEvVoLbp7u1i4CqU9oHlCp2hPOhjrJXP4REwjhAWkEYfmb9MUg9oz3vBkv7S/lF0xpkBQauQFrt9InRoJpHbXWR0WMdMo5OmY3sSyJHDd3Rri7Oo7CJ6UTM12g5q4jh01FpFqJ8RCzKz/veCEnAx2JkApUUNuQDox+9/ZTvePth52qWZkn1Y42PkQE5RJTczlSfQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8PyDMa2lIDtTbxbzDU1eV3lPk5v0MMJf5Oc/fUPvnTo=;
 b=KkNqSwtfAr7pEXgRQDbEPYVUPwk4oBep44IoKBibIVtDcY6KA44eiFnQ5t31YHfGpmi1Prk2LRr2kB3mR+DQwdLgH/fqpLd8NDi8WpCOmDzy4LBTo1YVZ19C2A8FhKSI1oJ8QV2bE2GTPik6tFjrIfC4W1XYpVeZCoe4cDIUfCs=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 14:59:02 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Message-ID: <YmabFt952DO29pIA@Air-de-Roger>
References: <368e2d54-09f2-2081-349e-571bfeab13af@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <368e2d54-09f2-2081-349e-571bfeab13af@suse.com>
X-ClientProxiedBy: LO4P123CA0300.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 35c94294-abca-47d3-b903-08da26bb62d3
X-MS-TrafficTypeDiagnostic: PH0PR03MB5734:EE_
X-Microsoft-Antispam-PRVS:
	<PH0PR03MB57346EBFA7CCCE3CCB2755118FF89@PH0PR03MB5734.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3/E2GHOdCBAS/r3AxiYemEQs9VRkpUJEyeKQ98d6mRWDDnkjngjP5xwSix6ulJH07h36YUvOvnEZv6o/aUoSdtrp8EiKHy+MtvQjrVTGdEau55EvR5SC0WpPWQ6qRvgBH/lctne88R33YZCV6Rt/orLsPGCr0nwBNXzUhd8YlZ7HV5DJGnpQ0xDV8EgdWbXfhyh1XkrhUsTOaRusCcI5QFIcjlNiPBITDGqOY/5+bH63aQlhqn8xG7P4q+sJJaUnset/VIg6Zlxgjug/RYbGNMQtNEx5W53i9jH7K4WPlx6lxJO2jFynoXERuLiy1QgDePlAvUGZmsbLjkTQjf5Dn+SNjR4qfaoAb6gGPzhoZvBM24DBCp+nNd9DxzRSHDtWRmXfVQt5694Ul6fZvUr3DiIz1m3L0tJtGi12hkk3CSInxQGQi6ENWW58WPs2mTJcp2GWizw9aBAKMidq9JCCOqy54TF47Tq13QW5+z7fec5BtF6pOsZLoeQQiC1KHBdlY7P+ZxAZhlW76GupwO1yw0Pcle1afTFPSGWwHraRSOm3jns7A9LynYN3i+yA7htwgPs+WgkH7cljxgLLTjPSgq6ldRKg+OhHlVl6fW0yuClZCHAiYX4OoTTFlmpGvQxW5fXT3JefQIUPWhrthrASjQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8936002)(66946007)(508600001)(85182001)(316002)(5660300002)(186003)(6916009)(54906003)(8676002)(38100700002)(82960400001)(66476007)(66556008)(9686003)(4326008)(33716001)(86362001)(6512007)(6486002)(2906002)(83380400001)(26005)(6666004)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aGY2Nk8remhlbjEycVVCRm9vR3ZiSVkrVFJjbzZDdnowVkpCU2RZcTRabU1O?=
 =?utf-8?B?b2JPbDZwemJTNmR5a0J4dXFnenBsaHhwWklHQ3hXdjJPR1lUMC92WnZMcks1?=
 =?utf-8?B?dEJ0dGJJS3FDSkxDQnl1SlFmZEZBUkhiSER4dmgyNVBvUjFWaWdKREdFZ0pP?=
 =?utf-8?B?NnBKaXhFSEVtSEY3NXpzSHo5K1gvWE13bGIvbkxmeWJpWDNVMFljUUdkRFUz?=
 =?utf-8?B?bjQ5WFJobVM2dWRybGU2bVk3K3VsTzVMUWdRSDM1WndtWXppZ0ZlejFjYTJF?=
 =?utf-8?B?L0lxYnhLb0JnclpTV1dvVit0QTNDaTd0ZWw1N0YwS2g2UGlYVmNTbkJlWWxC?=
 =?utf-8?B?VHhkTW5JMSt3TTZQUVgxakhuYTVDY1lKT0dEbFptSm10N044aUl4Q2Q2N1VJ?=
 =?utf-8?B?a3Q5emlVeVl6Tlh0amhXVCtxMXFKeEsydGxqT0FuaURaZWN1aFd3SFhISVEy?=
 =?utf-8?B?MUk1dG5laUFTbFA0TXRsSXRFZmE4ZWhKeGgxTFgzc1c2YkwxUEc3RWVzdU5H?=
 =?utf-8?B?bk1idmxaS3N0Zk00eFIzTUtCVjh3MFpJYVdOMzFQb0o3TlQ1ZHZva21wNzJr?=
 =?utf-8?B?U0xFRUEvODNWcDdDMjJTVzRhYzM5a1drQUlzM1IxSjFLeFVmU2ZUSEcyV3J1?=
 =?utf-8?B?c2N4Y0Q2dXlZWGRNalZieEs1NWgrZ1kxZitpdUhiamsvODVGSWZaNnJTbnFu?=
 =?utf-8?B?WnNZN0JpNVpnazd4RHdkSTBvazk4dGUwSmhkT1FQTU1PTkZXRGVWMTRMVUVU?=
 =?utf-8?B?M1R3eVYxaDRBejFSc3JUbHJpdStsRW43ZXRrYXhlMkRhcXlwU1N1SVorYlZk?=
 =?utf-8?B?aFErUDVtMXF4aGZid3QwUXBYcUN5c1NLYytIancyUStjeTNaWTNyZlV5SHRP?=
 =?utf-8?B?ZkU1citNZWdJbkFyMWJVWXNpUjZtNEVzc2Q5c0ovMTZDTDZnSjZUcVN0MlY1?=
 =?utf-8?B?STVvT00rbk9uOHYzOVlUMUVNUHNlZk50UThVZDZiK0duSmhKS2hZVXNQb1FV?=
 =?utf-8?B?QmdYc1NjcTlaendKSWh1QUtNQ3FoQUJua3VSeTVYekNxakZ2LzFVVVlkbFFJ?=
 =?utf-8?B?MzRMOFMrMExMODJSRnVPQk1qdk5qRWVocXRETXVRVUthTVZHQ0ZQZzFlVXA4?=
 =?utf-8?B?YWVyWWFMcVIxcGc2cEwycitIRWhYS1ZaL3grcTV2ajFWeWV1SXBZK1RGYXds?=
 =?utf-8?B?Z0xybjFkZklCOG9BcjJ4M0RtM0lpbURLc2kwbG96Nzk2eDVjL3VGU1dJWHA2?=
 =?utf-8?B?Nk9YUDBXQTJPS1AzMjhiV1IrZlhsNllwK04vVTc1VU95TW90Y2ZROTdxdFdY?=
 =?utf-8?B?KysrOSszUnFFU0ZDNk92cmpkL1pRYXE1d3RsVXFEdFB1SXp0ZHZCZkZ2emxj?=
 =?utf-8?B?L0xXTkZPNGJrb0JhSzNCNWRyL2p2dE5RY3MwNVBDS0lqbkY5RVo4WXNMVGhE?=
 =?utf-8?B?c29oOTdNd3FHWk5HYWl4aFU1eU9wakdPVThlYk5ZM3piOFpTTjY1ZHQxQ3lF?=
 =?utf-8?B?Zi9NVVh6SkN6TUtQMXcrSmdkN1drVWVHRXJJaUJ2UTJWWUdxc3ZHUlRZOFBl?=
 =?utf-8?B?SWJqSlZmQlk3WVZyQmt3OHpzcC9pT2JwNzNVTExZeGtvMWJCdXhWNG5WMnNq?=
 =?utf-8?B?R3RxdytyL1hHemd2Q0V5VEtLbXZlRTFhSlRjbDIyZFdweUZlUnQ5aU8vM3Qw?=
 =?utf-8?B?WmxCSDQycm5iQXY4d2JtRmhqZm54dkZ6V3d5NjhsTnB4T0xCYWtOQ0loTmFy?=
 =?utf-8?B?VnM0YXZMbUpRVU9yRWZEeHcwUHFreDZBU0ZQcEoyNHNDSlVOSWE3ZDlDR2tZ?=
 =?utf-8?B?dDJxbndIMHlFWDlvcjdpY3U4QXgvUDZNOXVXQzJadmcxWTZFNS9GeGF1dCtj?=
 =?utf-8?B?enRISVkzQzdkc0phZVJrSHk4MG1zNjJDTE8rMHgyamZJL0twWXhKYkVzalpn?=
 =?utf-8?B?QjJoem8rbURNNWsvbHNaQU1ET3owbVNRcCsvdDBDR1VhNTg2RWJ4M0p6WVV3?=
 =?utf-8?B?SjhvV3ZjeDVMSnd6LzlSV1pQbERqaHhWUlVBNCtkRWltaVZMMzFrK1ExWUdD?=
 =?utf-8?B?YklRVjVlRmNETk5sVmpnWjBHbjhFYm9GdFVVNHl4NHluWHE5Y1Q1TkxjWFN4?=
 =?utf-8?B?NVVKY1ZLOVdHVmNUUzRYdFVOclAzbkpqbGNwaDZNaWlGN2NTVVN5WnVrQ0JY?=
 =?utf-8?B?QmlMbEtTdkx1QjFDYWhHRVBRQzBJc3loQ015S0tRdk5GcGUrbmFic1FuR2Nm?=
 =?utf-8?B?eUNWbDN5U0NMYzU1bkdBZG9tQ0pmeUVKWVQrY3cveFdqWk8zSlZTeW92Wkxt?=
 =?utf-8?B?eVVGdHA0TjdqdWVITjdTcW5tVHlJYllxWVE2QnVCUmFJZHpUcDJzS3ZSUUlR?=
 =?utf-8?Q?nbqflyi+LfhAu06I=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35c94294-abca-47d3-b903-08da26bb62d3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 12:59:08.8409
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aCPFw4q0X8XxD9W2RKQCPDkyd6Iigr54p0PIUuFkZBDeIT5NxrAvJ2ywy4Qd3/+UxWLIvRX+ihOUXoH+pYKtCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5734

On Mon, Apr 25, 2022 at 10:49:34AM +0200, Jan Beulich wrote:
>  char *libxl_domid_to_name(libxl_ctx *ctx, uint32_t domid)
> --- a/xen/arch/x86/dom0_build.c
> +++ b/xen/arch/x86/dom0_build.c
> @@ -317,9 +317,12 @@ unsigned long __init dom0_paging_pages(c
>      /* Copied from: libxl_get_required_shadow_memory() */

Could you also update the comment, maybe better would be:

/* Keep in sync with libxl__get_required_paging_memory(). */

>      unsigned long memkb = nr_pages * (PAGE_SIZE / 1024);
>  
> -    memkb = 4 * (256 * d->max_vcpus + 2 * (memkb / 1024));
> +    memkb = 4 * (256 * d->max_vcpus +
> +                 (paging_mode_enabled(d) +
> +                  (opt_dom0_shadow || opt_pv_l1tf_hwdom)) *

opt_pv_l1tf_hwdom is only relevant for PV guests, so maybe it would be
best to use:

paging_mode_enabled(d) ? 1 + opt_dom0_shadow
                       : 0 + (opt_dom0_shadow || opt_pv_l1tf_hwdom)

Or something similar.  Maybe placing this inside the sum will make the
expression too complex, so we could use a separate is_shadow boolean
to signal whether the domain will use shadow pagetables?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:59:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:59:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312893.530300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyJa-0003pe-GY; Mon, 25 Apr 2022 12:59:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312893.530300; Mon, 25 Apr 2022 12:59:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyJa-0003pF-DJ; Mon, 25 Apr 2022 12:59:42 +0000
Received: by outflank-mailman (input) for mailman id 312893;
 Mon, 25 Apr 2022 12:59:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niyJZ-0003o4-BM; Mon, 25 Apr 2022 12:59:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niyJZ-0003PY-8v; Mon, 25 Apr 2022 12:59:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niyJY-0007ye-ST; Mon, 25 Apr 2022 12:59:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niyJY-0007lX-Ry; Mon, 25 Apr 2022 12:59:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8cwABRDIb6k0iCadl+D97tBhfy3BZTZhd6yUecTSj7Q=; b=29X1xGCS/VHYBfy+3jFs0g3exr
	M+eyjoM8oMc0J+8Vpd4uX8Qjqj8VbWBwwQnTEFoKGVyDAvrZ47EuTl8pKVM1AgQ1+z369Tb1yAC+/
	qq0gfqm3T+cQLL8DDl0Qkkvl3T8vvhgyepPSsK9Nqko20KTG+NO39Q+hWlM/bt6/NG/I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169706-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169706: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 12:59:40 +0000

flight 169706 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169706/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  619 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 12:59:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 12:59:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312896.530311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyJe-00047f-PP; Mon, 25 Apr 2022 12:59:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312896.530311; Mon, 25 Apr 2022 12:59:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyJe-00047W-M2; Mon, 25 Apr 2022 12:59:46 +0000
Received: by outflank-mailman (input) for mailman id 312896;
 Mon, 25 Apr 2022 12:59:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uj5J=VD=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1niyJd-0003Kc-Dy
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 12:59:45 +0000
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [2a00:1450:4864:20::135])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 941410cf-c497-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 14:59:44 +0200 (CEST)
Received: by mail-lf1-x135.google.com with SMTP id p10so26017365lfa.12
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 05:59:44 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 c8-20020a2e6808000000b0024f0d945657sm569596lja.106.2022.04.25.05.59.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 25 Apr 2022 05:59:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 941410cf-c497-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=PV1OyG4ThNPMavMonLhk2qdWsUplxU+qfgH+2AePe5c=;
        b=TkZxbLKU87tgO+0xSrzRZL2k/XlviaFVl3KCmRBVQkmOYy9qo3CpJbFP9q7Pejza4L
         6KCzey0npciJq5pn05OZwKbhRBriyAy8PbZdZwwWl32ciN75jF+U6i/lJRrmKT0yFQty
         Z2pS6P1wRGU13Nv0e2yILEt+grspI4qJnvRFksW/orUaC82T78Tx+sztPXi6orJANM3Z
         6i37VzEF1Ep3w55YKaDNBm10p4Sj/ZgbffvzA/gxYd+KD8h0mry5frzfXfoWvqbLloB5
         J1Yaz4xZVG6q9Cz+xVcXYUkyUl2EFbMRYanks261PXlUMtVEh7gtF6NQkPsa4kpACvBe
         dnhQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=PV1OyG4ThNPMavMonLhk2qdWsUplxU+qfgH+2AePe5c=;
        b=2I/kFLZicZzj1UyM0NY/RLgahqh6CtMxDtnp0GOglWTMVrWXiu5wVVxNyVzSHn/c1L
         p0RTL9REpzzE3T6kc4RPGXVLpc2mPSi+VSh5DLuJS5tIM3wVfVpuiokUW+FZoFvaHC5X
         nBrWtW10j9GabxwYucbNjK9Mz8EBiunWbNpFtUzyfvDHNO1ZaBO3roWuZmnpOOdImxY1
         E7j70MyhqCyIJ8n0Xe0E+Vqn+9JUD5c+0LqzfKKLDWVwTykqQllXcBpE91a+aPawo2/u
         E+Y6lUOVjcu/Ha/0FGgRKvLJfN/QTiY+vctL6WE4N2uOFin3DWM70kob0RTxDXeb4A96
         hCCg==
X-Gm-Message-State: AOAM5314gLXQQHurd/AFwZPFMKe8okbHGoC3tCwKH8PACi772f4df9j/
	t6NJzQnXUNi9GjWFn9bA3/g=
X-Google-Smtp-Source: ABdhPJzjR3+jsmAK9OKPkHlmSQpFqNKjXYek6QlWZhfRj0f7Vd5I9TKBY7ScsH0l+dU+xMiZJXyMLg==
X-Received: by 2002:a05:6512:3f86:b0:44a:f5bf:ec9a with SMTP id x6-20020a0565123f8600b0044af5bfec9amr13044251lfa.490.1650891583963;
        Mon, 25 Apr 2022 05:59:43 -0700 (PDT)
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <6864c64b-246d-7ca4-371a-61d4953a781d@suse.com>
 <e6858f79-2cc2-2bfc-07db-8c46aa1dd81f@gmail.com>
 <e657458d-d33e-a340-d9fe-152ec97eefec@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6dcea33d-0beb-d408-ed89-e1989bfa14e8@gmail.com>
Date: Mon, 25 Apr 2022 15:59:42 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <e657458d-d33e-a340-d9fe-152ec97eefec@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 25.04.22 15:09, Juergen Gross wrote:

Hello Juergen

> On 25.04.22 14:02, Oleksandr wrote:
>>
>> On 25.04.22 10:43, Juergen Gross wrote:
>>
>>
>> Hello Juergen
>>
>>
>> Thank you for the feedback.
>>
>>> On 08.04.22 20:21, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> This patch adds basic support for configuring and assisting 
>>>> virtio-mmio
>>>> based virtio-disk backend (emualator) which is intended to run out of
>>>> Qemu and could be run in any domain.
>>>> Although the Virtio block device is quite different from traditional
>>>> Xen PV block device (vbd) from the toolstack's point of view:
>>>>   - as the frontend is virtio-blk which is not a Xenbus driver, 
>>>> nothing
>>>>     written to Xenstore are fetched by the frontend (the vdev is not
>>>>     passed to the frontend)
>>>
>>> I thought about the future support on x86.
>>>
>>> There we don't have a device tree (and I don't want to introduce it),
>>> so the only ways to specify the backend domain id would be to:
>>>
>>> - add some information to ACPI tables
>>> - use boot parameters
>>> - use Xenstore
>>
>> I understand that, and agree
>>
>>
>>> Thinking further of hotplugging virtio devices, Xenstore seems to be 
>>> the
>>> only real suitable alternative. Using virtio mechanisms doesn't seem
>>> appropriate, as such information should be retrieved in "platform
>>> specific" ways (see e.g. specifying an "endpoint" in the virtio IOMMU
>>> device [1], [2]). I think the Xenstore information for that purpose
>>> could be rather minimal and it should be device-type agnostic. Having
>>> just a directory with endpoints and associated backend domids would
>>> probably be enough (not needed in this series, of course).
>>
>> Just to make it clear, we are speaking about the possible ways to 
>> communicate backend domid for another series [1], so about the x86's 
>> alternative of device-tree bindings "xen,dev-domid" [2].
>> I was thinking we could avoid using Xenstore at the guest side for 
>> that purpose, but I didn't think about hotplug...
>> I assume, all Xenstore bits wouldn't go the outside Xen grant 
>> DMA-mapping layer (grant-dma-ops.c)?
>
> I think it would be another driver under drivers/xen/ without the need to
> touch any other frontend related file or Xen-related architecture 
> specific
> code.


ok


>
>
>>> And with the hotplug option in mind I start to feel unueasy with naming
>>> the new Xenstore node "protocol", as the frontend disk nodes for 
>>> "normal"
>>> disks already have a "protocol" entry specifying 64- or 32-bit 
>>> protocol.
>>
>>
>> I noticed the "protocol" node at the frontend side for traditional 
>> Xen PV block device which handles yet another purpose, but I didn't 
>> think much about it
>> since the new "protocol" node in only for the backend's use. If we 
>> start thinking of frontend's Xenstore nodes, then yes, will clash...
>>
>>>
>>>
>>> Maybe we should really name it "transport" instead?
>>
>> ... For me the "transport" name is associated with virtio transports: 
>> mmio, pci, ccw. But, I would be ok with that name. Another possible 
>> name could be "specification".
>
> Yeah, looking at the virtio spec this makes sense.
>
> So I would be fine with "specification".


ok, thank you for the confirmation.


>
>>>> - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
>>>>    one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model
>>>>
>>>> An example of domain configuration for Virtio disk:
>>>> disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, 
>>>> protocol=virtio-mmio']
>>>
>>> With Roger's feedback this would then be "transport=virtio", the "mmio"
>>> part should then be something like "adapter=mmio" (in contrast to
>>> "adapter=pci"), and "adapter" only needed in case of a device tree and
>>> PCI being available.
>>
>> ok, will rename. Can we add "adapter" (or whenever the name would be) 
>> option later, when there is a real need? For now, I mean within the 
>> current series which adds only virtio-mmio bits on Arm, we can assume 
>> that "transport=virtio" implies using virtio-mmio.
>
> Yes, we should add it only when needed.


ok, good


>
>>
>> BTW, if we named the main option "specification", the secondary 
>> option "transport" would good fit from my PoV.
>> For example:
>> disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, 
>> specification=virtio, transport=mmio']
>
> Fine with me.


perfect


>
>
> Juergen

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:12:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:12:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312919.530322 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyVv-0007Ca-3s; Mon, 25 Apr 2022 13:12:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312919.530322; Mon, 25 Apr 2022 13:12:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyVv-0007CT-00; Mon, 25 Apr 2022 13:12:27 +0000
Received: by outflank-mailman (input) for mailman id 312919;
 Mon, 25 Apr 2022 13:12:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1niyVu-0007CN-64
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:12:26 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 574c65a6-c499-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 15:12:22 +0200 (CEST)
Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 09:12:20 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB2492.namprd03.prod.outlook.com (2603:10b6:3:79::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Mon, 25 Apr
 2022 13:12:18 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 13:12:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 574c65a6-c499-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650892342;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=hVRPEx0RduZMFDeuGFqZ54FcyypAa690gIEqpLf767E=;
  b=Yu+kQ5QMIGnlFydJMa+OFxiaSXpWM5e/jBKpmKUinfpnaKpmQKxHRLSL
   Ed3wIf0qe5ycOkMPUhblu0evDhJvnClSSexCDvw6c+YnYHvtDaWZ/mKkg
   jRn6su2mRJwqIE4n4jv+I41SvejHnhegEcCH70VLLXeHGhTEySkjGHeh8
   c=;
X-IronPort-RemoteIP: 104.47.57.168
X-IronPort-MID: 69735420
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:potb0aloWj31QiMoFYvHV3bo5gwSJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKDTzXOP3ZNGL9Lt9xbNjn8EIGvJbXytVnSQtrpXpkEiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWV7V4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYFTw7YabzgskkcxRTPRpifqkWxa35GC3q2SCT5xWun3rE5dxLVRhzEahGv+F9DCdJ6
 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXupkBgmdYasNmRJ4yY
 +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUG+Q3O+PZtuwA/yiRK+rTtaIHtJuCsXMN6zmy8+
 0za8lbmV0Ry2Nu3jGDtHmiXrujLkCDgRJMJFJW38/drhBuYwWl7IA0bUx63rOe0jma6WslDM
 AoE9yw2t68w+Ue3CN7nUHWQp3qJvQUVXdZKJPEr8wGGyqfS4AGxC3ANS3hKb9lOnNAybSwn0
 BmOhdyBLSZoq7ePTnWe8J+bqDqzPW4eKmpqTS0LVwwe+PH4vZo+yBnIS75LC7Wph9f4HTXxx
 TGiryUkgbgXy8kR2M2T/03Dgj+qjojESEgy/Aq/dlyi6gR1dYu0fbuC4FLQ7etDBIuBR1zHt
 38B8+CU4foSF5iLmGqISf8UAbCyz/+fNXvXhlsHInU63zGk+nrmcYUO5jh7fR5tKpxdJ2+vZ
 1LPswRM4pMVJGGtcaJ8f4O2DYIt0LTkEtPmEPvTa7Kif6RMSeNOxwk2DWb44ownuBJEfX0XU
 XtDTfuRMA==
IronPort-HdrOrdr: A9a23:3Ekc36xBWa6mKkGo81guKrPxvuskLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U
 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu
 vg2iMLnUvoRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIF/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF8nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvWOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA
 BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1rop5PzuN5d3B+3Z
 W0Dk1ZrsAxciYoV9MMOA4ge7rBNoWfe2O7DIqtSW6XZ50vCjbql6PdxokTyaWDRKEopaFC6q
 gpFmko/1IPRw==
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="69735420"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nQbkHNoYnIf9F9k8IkRTO7HxNT8FuoNqCv19+AzJX8faYis1uEUU/yv8d83kjTUIE8svvEQrsk7HkSTopn5zWL1R9lEZGwbbWkBtgRxwDK8TrnHkNhASfzesbWTh4McQqJUy21fsnHcSm1pR2PltSbdaLiMAxidmUl2VFlNDV+fMiZl7NIHx9X24lFQm5fYJycokwm/D8TSY4bbl3C9/ONXq5qcUC2yAD8/yafYGuPPC+W2QXgASXFH1/8UH3x0fMo3D6XyaOGRukezeR7EP5vJVrNLbn1Yni+UL5McvbRdV2LKYtLX0/z6lywtey7OL7xX0o7Gycf0qjO9bVD1E3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ueiUv3ANFHhKZifcnbhcc6x3asJ/gBDKdLEmM6uG4D0=;
 b=SR9mRJbeLu26wFKYPxzB9kAWWLzYjiijYHw6/RceZuItd0eKIZI1TOeNdzKE+A6jGx03bfdUat7/iIc2MC6RLA2z7ElCtLJfr7WA1kvwmUCraMNiWrv4O0Xo27GshXJGCBDgIaN8GFU7WW5/gsf7XNU5dR3bQ+EWWxBOE37vmQZzeyzoWhqywTIn1BzYH1J+ceIfr3Luad7h9q86kBZ5Vim0DYass7kjYwDf078G65zLT6Qtd/Rk3UtpyoEtRA5L+pXbBroOcrHC1KneNdbS4R6PY5Gslvr9cPF6S6RHS57rubrW6uRHkz5ic6Vs6T5O+tACY1lG1STyapp2B7hUuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ueiUv3ANFHhKZifcnbhcc6x3asJ/gBDKdLEmM6uG4D0=;
 b=vw+ITYkVDIe14Mjufr3i5BRCTxIdC5deHL56+oLjaFGP0881fBXs3KmTh+M58nXhtxeLcWIuzAdCx3VGtE9+T/3g0/EuJ5P+hd6zd6x7uH9ZKB+QSqF6YFNfY5j33TFsJV4h+zNFNA2UAs4udalfUyRUiVtTLBsy8pgBlsNpTjA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 15:12:13 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@gmail.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
Message-ID: <YmaeLc2iwxUPUAvF@Air-de-Roger>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <YmJ4NLuvA63Irow+@Air-de-Roger>
 <24112cfc-0446-d81e-85f1-ebf9da0afe14@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <24112cfc-0446-d81e-85f1-ebf9da0afe14@gmail.com>
X-ClientProxiedBy: LO2P265CA0107.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:c::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2fef7663-b10f-46b9-1778-08da26bd395e
X-MS-TrafficTypeDiagnostic: DM5PR03MB2492:EE_
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB24926A543BB4A674EB74C9EC8FF89@DM5PR03MB2492.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	j82/i0KHHJrk21CX/1hn8yLlq5qpYCYIUmxT5r0k4h5pmFuv0OHFLYKagxmQdnumFEyPQ44d7kgOziUcC7UXW9eFvpmCv4C5qcYSsHPh2jVzLfofotwXl4zmE0XqPDLivly164B/ZKWpRXoEa/3rFbWjQh6/gBJalQF8LqtDstJFsLi7i+ut8YHT+2RrQtwS2GoRqwq8pV1ADLB55zf+dBKVv8LBBbR3/Ycy6XsRo5TnTNdW6LEHTIB/Jf5CotXBggx2wW5MSN9tBdM9b6CbdYVGwQkYXb0uPakbcHkJa5KWsXi5zALTez6+ZhgZlLr03Qyfa53j2/7TTkysNSu6yrYGac1Kvp+Ur7cvspjvdEIV+8rg9gIBwKCYFE/OygIcwnnEdoFfhmSKKHi6dnzIlVqU0eJ9vpQWah2Ojp3b4stOXYCQoOgTssaOtUsE39ysNHOjmXzjkWzDRNarpmAJ1vpa8P39C9ZspGQKbzQbpsLwxBTnMpHi/BYTXTOcKeQRO+Xys4cwmtJko4XPsSJuHGFkoEl8osGcuj+JPLQb3nyfox1CbcTejqP+Tyk6QA9ikgbpqPAFeyeE0ks4pTZ2G3hBAGsjeopbXbp0e98DbVHj16hTpPsuWINcI9ZXukdbRmjnE+DNT7ZhKEMnB08H6Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(53546011)(186003)(83380400001)(2906002)(9686003)(6512007)(6666004)(6506007)(6916009)(316002)(54906003)(85182001)(86362001)(6486002)(508600001)(5660300002)(26005)(4326008)(66556008)(8676002)(8936002)(38100700002)(66946007)(66476007)(7416002)(82960400001)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?emdCU3JCM2MzcUJoVGIvMG00VTZhYk9NRHdhbXQxRVZaR0ZBVFV1Vkd4ZE8r?=
 =?utf-8?B?Qnd0LzBGY2l0aVZXVkJyREZzNlEvejF3RE9lNll4WmJGMlZkMk03QmxJU0Jx?=
 =?utf-8?B?Um9hODVSaXA1MlFtdUxUTzRNc3JqTVFQcjVtSlBLdDJvQThrWGcwSzBLRXJy?=
 =?utf-8?B?Z1Z6MzVIa0k2cmRIQ3paZ080V251QkJNYVcwaHdtN0JWSFZ1Sk1zeVZsNVZG?=
 =?utf-8?B?ajBkV1RRZGQxR2g5VVZ4OEhCZTQybkkxdmdMNkZSOUFOTys0UEJOSlhBRkRC?=
 =?utf-8?B?OTJFREpaOGk2MUtjb3IrU0VuZU9JRC96bkpIY0ZxRmxsNVlHbHdPRFRLdHh4?=
 =?utf-8?B?ZnA5YjBNNVUrYWJLTCtHNC9odEJyV2dCVkFmQXJDZEdpM3A0Z3k5cXVXSjcy?=
 =?utf-8?B?cHZ1bWgwblBiaWErNWFQbWpxbWtTL25zcXpNRVI4enNIVGJZTU1rMW9ma1Av?=
 =?utf-8?B?aVBGMGx5MTQzblI5VVcwTVp3VmpMelAwMmlQcDd3eUk3bmozQzlzekU0bzdK?=
 =?utf-8?B?V29EKzN6T1BzNGRDaFBCR2tHQmNGdVVNbjkwbmhBVUZnZS82Y01ONFUwVWQ3?=
 =?utf-8?B?SnJoM2JNS0ttUTJsRS84K3VRbERRbE9ILzVVRG53c2RhUkF6MS8wZ3pWWS9M?=
 =?utf-8?B?R0FWWGMrbWJ3dUtYS1VRcVd3SmhYZjJqemxMQ0lkTUc0ZXVpZGJDbndYeStN?=
 =?utf-8?B?bUtLS016bUV2S0ZjekdTWjByZlBHejVsdE1rS2F0Q3BwR3BuaEZtQzhTSlhY?=
 =?utf-8?B?N2VCeXdJOWluOGNYamNHaElHYzNWd242YzVqUDI1TklFa1h0WGgrVWZhTjha?=
 =?utf-8?B?aW52cEw3eVNFOTdteFpDa2ZJS1NLZkY3Q3NpRU8xWGFma3R1ZFZxUDhGQ2J2?=
 =?utf-8?B?OXloNWhXNCt6Nno4Mkt4TFdLeWdlMjJMVmVSbUF3SUcrdnk3UVFHdVdhSjZP?=
 =?utf-8?B?V2tHREs2OFBjc3lYckczeGVreUFsSWo1aVI2SkJ3NG9ZVFFDYXNXZi8yR2dw?=
 =?utf-8?B?OVZsTm1jZk0zTDZEWXRiUitjSXlwdzFSdzBiNGU0WmVLNzRVamZQeE1NRDRv?=
 =?utf-8?B?SXk2eUd4clNmR05WYVpIR3NJeTZCSEQ1Rlh3M0gwWHY4UXd3RWhhajRzRGFN?=
 =?utf-8?B?QVhuODdyT3Z4TzlRMG4rQzZFNFpTdHVtZWxYdUwyR2VJa2w3MXZsdFZCaTdL?=
 =?utf-8?B?NVJyMVp5MVlIeDA0ejVIMUdVRThrd1FvWkpESVlzdWZtV0cxMUNDWjM4Y1BD?=
 =?utf-8?B?cCt6NG05WkhIbnlCWWwzODY4eEZwbjNCT1Ivc1pRSEFXTWUrOXY2ZlhMZ1Y5?=
 =?utf-8?B?bW5TRzhERDdoZXdrcGFNZ1B6R2hXd2UySUQzRE9IeWpiWWtVSFBlNWJXNml2?=
 =?utf-8?B?VUUwRkw5WUhnbmoxRjdSc1hHb1hXQVF5aWVtUy9wY005WmM0bm1tdEFmNW5X?=
 =?utf-8?B?blB1cVpBVVlsQ090V3FDOTdkdUJJOTI4aVVkY1pOSEJwdFJ4bnJLT1lnTkNm?=
 =?utf-8?B?aFBrRmljb3VveFJLOFR0SDJxZHo2emxwOHlQdTNoQ1YzVVB6anVRVTU1VkZv?=
 =?utf-8?B?RlRrRnZ1MjFTYmhaYlhSa3EwWDVvNGdSc0pNTCtTSGMwUEZkYTdoUnpPWEZZ?=
 =?utf-8?B?T0dWY2ZoOHQyZjkwakt2RFBOL2NjWS9STFRreDVSRFY3bGNvQWdwZkdERVhU?=
 =?utf-8?B?dERmZXlpMHZLN1lvNnhRTEo1OVprTHNsZzMvb0R3UVhYVVU3N0FsRENDc0N6?=
 =?utf-8?B?d1YwVUc1WHljQnhGbTVqTVBTaG9FNzZ3dGs3dVlVQlYvK0RlNitHR2hWODdH?=
 =?utf-8?B?cTJrdVIyLzJsT3hTckZ5eXVsUytUK2YrT21yU2hpemhmMUtaRHNpbXNaU2Q4?=
 =?utf-8?B?UWlTMXp2VVBrQ282N0ZhV24vMVF2Qk84RFV6WkdEMG9Mc0Y4SmU3UEZCQ3NC?=
 =?utf-8?B?aTNXeW54Y3ZzYmxRWXRkK043cGcyRTFZUDQ1VTJ5TWRuQXQrR3FKU0lHeGVK?=
 =?utf-8?B?VWdORUJvV2xkdkx1S2VuL1dSWDJiVXp6SWRWQkhKbGtiRWlNeW9pWjZJU0NP?=
 =?utf-8?B?MVVQWG9rNnduN01ldkZTd1F1d1BnbTZCSitvZm9TOWV2TlFWOXRFUzhSd1Bk?=
 =?utf-8?B?TzlRaytSNlhYOUdaZmZXTTI3NHREaTVRaXJoVjlFUXhET3VJcjdxSUtUMWJ1?=
 =?utf-8?B?b2EzWXhZVWZ3UDhIK0l5RDJlR0JHZXAwNWw4N3R3RjJxRTJHV2Q2dXlYSmEz?=
 =?utf-8?B?Wi9VVTU2ajN0cG1ndVJVNGFucFhMcUc4bDNNVWkvMkkyanB1dHNKK0hiZXBx?=
 =?utf-8?B?K1NNVHdGaDFwbHphaHRsc0JvWEZxQ284SlphWkF4UmtEL1ZaNEVpZTdtNTJX?=
 =?utf-8?Q?Rwy4dFY1I7wAnamI=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fef7663-b10f-46b9-1778-08da26bd395e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 13:12:18.3094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oQsvnLpUg9AM0ljlCmgJyKBiaxZzmLzPnRrPPOzr8OsvinCai/Z2aQtTN8wo7JiRHUaRSUI6MhJbWtRSksxb5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2492

On Sat, Apr 23, 2022 at 10:39:14AM +0300, Oleksandr wrote:
> 
> On 22.04.22 12:41, Roger Pau Monné wrote:
> 
> 
> Hello Roger
> 
> > On Fri, Apr 08, 2022 at 09:21:04PM +0300, Oleksandr Tyshchenko wrote:
> > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > 
> > > This patch adds basic support for configuring and assisting virtio-mmio
> > > based virtio-disk backend (emualator) which is intended to run out of
> > > Qemu and could be run in any domain.
> > > Although the Virtio block device is quite different from traditional
> > > Xen PV block device (vbd) from the toolstack's point of view:
> > >   - as the frontend is virtio-blk which is not a Xenbus driver, nothing
> > >     written to Xenstore are fetched by the frontend (the vdev is not
> > >     passed to the frontend)
> > >   - the ring-ref/event-channel are not used for the backend<->frontend
> > >     communication, the proposed IPC for Virtio is IOREQ/DM
> > > it is still a "block device" and ought to be integrated in existing
> > > "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
> > > logic to deal with Virtio devices as well.
> > > 
> > > For the immediate purpose and an ability to extend that support for
> > > other use-cases in future (Qemu, virtio-pci, etc) perform the following
> > > actions:
> > > - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect
> > >    that in the configuration
> > > - Introduce new disk protocol field to libxl_device_disk struct
> > >    (with LIBXL_DISK_PROTOCOL_XEN and LIBXL_DISK_PROTOCOL_VIRTIO_MMIO
> > >    types) and reflect that in the configuration (new "protocol" option
> > >    with "xen" protocol being default value)
> > > - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
> > >    one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model
> > > 
> > > An example of domain configuration for Virtio disk:
> > > disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, protocol=virtio-mmio']
> > > 
> > > Nothing has changed for default Xen disk configuration.
> > > 
> > > Please note, this patch is not enough for virtio-disk to work
> > > on Xen (Arm), as for every Virtio device (including disk) we need
> > > to allocate Virtio MMIO params (IRQ and memory region) and pass
> > > them to the backend, also update Guest device-tree. The subsequent
> > > patch will add these missing bits. For the current patch,
> > > the default "irq" and "base" are just written to the Xenstore.
> > > This is not an ideal splitting, but this way we avoid breaking
> > > the bisectability.
> > > 
> > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > ---
> > > Changes RFC -> V1:
> > >     - no changes
> > > 
> > > Changes V1 -> V2:
> > >     - rebase according to the new location of libxl_virtio_disk.c
> > > 
> > > Changes V2 -> V3:
> > >     - no changes
> > > 
> > > Changes V3 -> V4:
> > >     - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT
> > > 
> > > Changes V4 -> V5:
> > >     - split the changes, change the order of the patches
> > >     - update patch description
> > >     - don't introduce new "vdisk" configuration option with own parsing logic,
> > >       re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk
> > >     - introduce "virtio" flag and document it's usage
> > >     - add LIBXL_HAVE_DEVICE_DISK_VIRTIO
> > >     - update libxlu_disk_l.[ch]
> > >     - drop num_disks variable/MAX_VIRTIO_DISKS
> > >     - drop Wei's T-b
> > > 
> > > Changes V5 -> V6:
> > >     - rebase on current staging
> > >     - use "%"PRIu64 instead of %lu for disk->base in device_disk_add()
> > >     - update *.gen.go files
> > > 
> > > Changes V6 -> V7:
> > >     - rebase on current staging
> > >     - update *.gen.go files and libxlu_disk_l.[ch] files
> > >     - update patch description
> > >     - rework significantly to support more flexible configuration
> > >       and have more generic basic implementation for being able to extend
> > >       that for other use-cases (virtio-pci, qemu, etc).
> > > ---
> > >   docs/man/xl-disk-configuration.5.pod.in   |  37 +-
> > >   tools/golang/xenlight/helpers.gen.go      |   6 +
> > >   tools/golang/xenlight/types.gen.go        |  11 +
> > >   tools/include/libxl.h                     |   6 +
> > >   tools/libs/light/libxl_device.c           |  57 +-
> > >   tools/libs/light/libxl_disk.c             | 111 +++-
> > >   tools/libs/light/libxl_internal.h         |   1 +
> > >   tools/libs/light/libxl_types.idl          |  10 +
> > >   tools/libs/light/libxl_types_internal.idl |   1 +
> > >   tools/libs/light/libxl_utils.c            |   2 +
> > >   tools/libs/util/libxlu_disk_l.c           | 952 +++++++++++++++---------------
> > >   tools/libs/util/libxlu_disk_l.h           |   2 +-
> > >   tools/libs/util/libxlu_disk_l.l           |   9 +
> > >   tools/xl/xl_block.c                       |  11 +
> > >   14 files changed, 736 insertions(+), 480 deletions(-)
> > > 
> > > diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in
> > > index 71d0e86..36c851f 100644
> > > --- a/docs/man/xl-disk-configuration.5.pod.in
> > > +++ b/docs/man/xl-disk-configuration.5.pod.in
> > > @@ -232,7 +232,7 @@ Specifies the backend implementation to use
> > >   =item Supported values
> > > -phy, qdisk
> > > +phy, qdisk, other
> > >   =item Mandatory
> > > @@ -244,11 +244,13 @@ Automatically determine which backend to use.
> > >   =back
> > > -This does not affect the guest's view of the device.  It controls
> > > -which software implementation of the Xen backend driver is used.
> > > +It controls which software implementation of the backend driver is used.
> > > +Depending on the "protocol" option this may affect the guest's view
> > > +of the device.
> > >   Not all backend drivers support all combinations of other options.
> > > -For example, "phy" does not support formats other than "raw".
> > > +For example, "phy" and "other" do not support formats other than "raw" and
> > > +"other" does not support protocols other than "virtio-mmio".
> > >   Normally this option should not be specified, in which case libxl will
> > >   automatically determine the most suitable backend.
> > > @@ -344,8 +346,35 @@ can be used to disable "hole punching" for file based backends which
> > >   were intentionally created non-sparse to avoid fragmentation of the
> > >   file.
> > > +=item B<protocol>=I<PROTOCOL>
> > > +
> > > +=over 4
> > > +
> > > +=item Description
> > > +
> > > +Specifies the communication protocol to use for the chosen "backendtype" option
> > > +
> > > +=item Supported values
> > > +
> > > +xen, virtio-mmio
> >  From a user PoV, I think it would be better to just select xen or
> > virtio here, but not the underlying configuration mechanism used to
> > expose the devices to the guest.
> 
> I got your point.
> 
> 
> 
> > 
> > We would likely need to add a different option to select mmio or pci
> > then, but that should be set by default based on architecture/guest
> > type.  For example on x86 it should default to pci, while on Arm I
> > guess it will depend on whether the guest has PCI or not?
> > 
> > In any case, I think we should offer an option that's selecting
> > between xen or virtio protocol, and the way to expose the
> > configuration of the device shouldn't need to be explicitly selected
> > by the user.
> 
> 
> ok, for now I will use "xen and virtio" values for the "protocol" option,
> then internally toolstack will assume that "virtio" really means
> "virtio-mmio".
> 
> When there is a need to expand that support to "virtio-pci", we will see how
> to deal with it from the configuration PoV, probably like you suggested
> above by adding another option (e.g. "transport") with default values based
> on the architecture/guest type.

I think this likely also wants to be a separate field in libxl_device_disk,
which could be left empty and libxl will attempt to set a default.
For example have the following in libxl_types.idl:

libxl_device_protocol = Enumeration("device_protocol", [
    (0, "UNKNOWN"),
    (1, "XEN"),
    (2, "VIRTIO"),
    ])

libxl_device_configuration = Enumeration("device_configuration", [
    (0, "UNKNOWN"),
    (1, "XENBUS"),
    (2, "MMIO"),
    ])

libxl_device_disk = Struct("device_disk", [
    ("protocol", libxl_device_protocol),
    ("configuration", libxl_device_configuration),
    ])

I don't like libxl_device_configuration much, I think is too generic,
but I can't think of anything better.  Maybe others can provide better
names.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:19:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:19:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312926.530333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyd9-0007rG-RZ; Mon, 25 Apr 2022 13:19:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312926.530333; Mon, 25 Apr 2022 13:19:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyd9-0007r9-N8; Mon, 25 Apr 2022 13:19:55 +0000
Received: by outflank-mailman (input) for mailman id 312926;
 Mon, 25 Apr 2022 13:19:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niyd8-0007r3-DO
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:19:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 640c6a02-c49a-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 15:19:53 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-6TxNJtmjPrWEM34FaYPfDg-1; Mon, 25 Apr 2022 15:19:50 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM7PR04MB7063.eurprd04.prod.outlook.com (2603:10a6:20b:11e::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 13:19:48 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 13:19:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 640c6a02-c49a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650892792;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m/0kzGoXwbe14WooJd/Nl+yIoDBYkoe4bMHCbvRqz98=;
	b=IPeHTCp9ydzqOKzUnEQfBqRDofWVae0kYvVQL8EI+MMobI4LuQNaFrS4K9SYYpZBJlyyEU
	cvv6G05z6Nf3Eg/ckp46zKznkkxfKlcii4PyB1YxaMugks9wVXcj22Iis9LUsQ7goJKNkh
	lc32TSxGfd7xUMy04NSu4xzByT52vZ4=
X-MC-Unique: 6TxNJtmjPrWEM34FaYPfDg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q2Ys+a10r68eQk2aTZX8phs9kMQ9ys6H5uwwJ9sQ+FIXJAunTtc0/7PsmjxEWiub3RVhRAy0K6O22SbeB20GWlAIIv4ew0TMdqJ5cYKhuVDS19W5NMLa+ndxivuTBAnoti9RHhzpbE7yKYohdCeNaMQeW9eyGJs6/SDWvJ028XKJmlT70BHPJggjI0SP/mspg83+jUYYcK4r6rLpGXwtmauxw1aDIdOH1HQj5VxbR3sG9Epba2DxobAl8vCwwpiZvvyuXaFxRKQgvwfwk2e+ZAVsyFbBXNwypAO5oluR6FLgYav26t39pjKfrq9LakrKy6aUGAESCGxSVnX63EduvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kQ1uj6j8FX4J98NPRSUhT/TpPhE1EbUt2Bdu9IlpLpA=;
 b=gUqA03pkAruaRbu82m+4+E9Pvkx4I93112O/002Y0PuPiRr+bMvHK4S8bA06AtCKEOdsQFw+8hV5/gOx2IHgJG7dMg1LjkMnIN8hglrwASrUkbmHTmRx/bYfyocNxPqxjlDk5QvfS901wTKHtVncpaqyxLHBJmMt51Z09TRJAdVNn4vQ5EruifuHwbhuLU+V+ef6yKMwDTAhiljzaXL7yhz03f52/YmH6aj2bHXWGLvnxXyYWskArQAAPYzlfSxW+tPFu9J9VwHtzv3lFQ5sR3b0vSHzealDv21DeWKUhBXJF09Uv6OftUltIXm9f988RVjfOzNwe22bddkCp6eryQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <039010e6-523f-851d-a432-d7f1a2fe5eca@suse.com>
Date: Mon, 25 Apr 2022 15:19:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
References: <368e2d54-09f2-2081-349e-571bfeab13af@suse.com>
 <YmabFt952DO29pIA@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmabFt952DO29pIA@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0202CA0039.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71cb6087-5d0c-4147-3782-08da26be45ad
X-MS-TrafficTypeDiagnostic: AM7PR04MB7063:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB70633749B1C9AFE539372F0FB3F89@AM7PR04MB7063.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TDtW5cbzj1vOOISC69F1Fg6MHmXKv3e4ekmDLTX2B3qua3ND3zMT7wgoEQEH2YOwB4W5CRIv4Q006HynKabTPiG6hnSbQ6L2mIvnNinPt2MVIr9ka4bUekQLqV6A+1mhpuXQS6pKHYBB1pJKJMtfmJpa6MmD/xKdP3oLhsPZdXso01PyBCqj1AnfLq4nI8pydeVXMgUFFSOXdhMlqnvLx20OGCSayYZxi/igkCUUxHIja3te5ojimgma/3bRZlWT2aTUKaJzw009SzVvfLJMGN6DDxTQ1S/1FgSYi0HJP3dBUQ5aOKhgMd6OVNNdeUW/+yNYT0onWt1w5pXtfwhAf3r7QRHa/Nu/fWuNyrFc8ff5zDsc44WNe/+qAQPnFdND/+ya6hoACU+E29rk+nQLerkZj5yslwqdtQWRCQQO2L6oYI2Gv+3TPyOwBZqDSWBu81YOJrVzwgldyXMw6rmZY44WEAEVaHvp8v+zjloc3indA5EpVkjwWtTs1gRX4ieGN9kuYnenTaOxtFuOpNwrT1H1bM3+Z+iyicQY1pbm+ef6NnlyeDluauny/p9tW24pOZS+3nSVa3/6y+HoIvFI2relV1/h5NHpfOmfoI1bohkctoIvyLW6EKMvxMSqSkig8KsaTuQvvtKlD/n04gFOUFbvVawaQcHiu3N8GbB/M9LSsMEzadR0Oe8/sUAx3D6YVaKmHw3p7/JUXJ5LHGD6zOVDuPtIDJlHg+rd7fGhJRU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(26005)(508600001)(31696002)(66476007)(6512007)(54906003)(6506007)(66946007)(66556008)(8676002)(4326008)(86362001)(38100700002)(53546011)(316002)(6916009)(5660300002)(6486002)(36756003)(107886003)(186003)(2616005)(8936002)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FkWRwA5o6Wbm6vjRZJRmicYu0D7uzsUvOASZ7JZt9hExuAcCRAs48gEwAsiU?=
 =?us-ascii?Q?tp+BWfNtyDbgf1Rv14jWGV6+WcUO2dSV9KTRUTbSLFDvj/pR2gOzq7sKxbgd?=
 =?us-ascii?Q?M3jvaSmHaIIRs48ih9kX2SHzT2c5SpyfjzSVliT7xACWHVV20o/3JpsYdwRD?=
 =?us-ascii?Q?x0wG22ZKojz6lVPi24od1tYB7q5aIeN4LALtW9EZZM5A5fcJfv4FLnn9OUai?=
 =?us-ascii?Q?BXjzGW/MNpVOIIoyKeR9TdZechUmoAQXlWx1cmAQQLPeEw3ObTEInZO6wKg3?=
 =?us-ascii?Q?xZr7DHxxAZ2mmgOvA8l9zLJV5NvYzhWTTkniyk2c1YQNeBpDX47uUq2TgmQl?=
 =?us-ascii?Q?pI5EYPJJR3xy17lUx/jKLpyfre1ndkpgNuCwgn2YO5JnbDKywOqAfYFuNqrB?=
 =?us-ascii?Q?6Pfk6ha85BlvtVp8dYcI23NnjVtqppFRc/PL5dFeQTlmiRfhWd0fkbBtntSN?=
 =?us-ascii?Q?S28y8F+UFUI55jxH1CZIkzAldduIboujLdkkQZbh1JZB4Xv2Ix3HnpthGGl4?=
 =?us-ascii?Q?Y1lMI0kLJecmhQ68EVbl1jUPdBPe5WCRgIqFqId7I8nEUkAfE43xfUzpvdHd?=
 =?us-ascii?Q?U8woh0GaykewMzlP9l59LvqdsHx9P/MJK822sYEZ6kCUIw3E8b1VINjNjdql?=
 =?us-ascii?Q?efxnnJDrhuSOvbmXwJ2zhjbHW/t45l2ZvEQGI2zxYXiYtyfQpB05jkWElhV9?=
 =?us-ascii?Q?RErpssVUdkYgR9ydR4s3LENB/GagRJiwaIjw3Xh62BjnNqO9VbvnYJbwIL6D?=
 =?us-ascii?Q?qwQT7JfOtB3Y7JRTAyWztFnwDzSMY8wNTKKNlvzXo+x7kJ9zAEjUhZwem6TQ?=
 =?us-ascii?Q?seHCqzJxqrn+Qw8J1Zc9V/7Xj0fOgEQ1OtCCqqXvby/S3pha6aD+QUlMtP6g?=
 =?us-ascii?Q?EreaqTCKZh5KJKa7AKewx1N9EP8AqdihcD04+AWNNBqKhvfm8z4xYC6oZ7wl?=
 =?us-ascii?Q?j51R4G9zq/fnNWLXhJ5FB8pna9Qo9F0Wet58LSiZyWOVhJHay5M3URz2kdcW?=
 =?us-ascii?Q?Y6yZ2Q3oGyQLDof9t96XI/1Nf5Xix+cJZ7y+Vqd70buXRmIJn8L02GIaSnQF?=
 =?us-ascii?Q?zbdsSsTKg56jYg9CHQQL82X97IiG2i0kSV+l14NjECxc59L67Nrz5Rq0uNGS?=
 =?us-ascii?Q?6jFZVUf2Cyg5s8Z1thBe9IcgEW1lMYRGqtvNcVByh9FEe8C5LN2UbzlnHOId?=
 =?us-ascii?Q?4trkCWxQo4b2EPv94lTRB/PL3gHBhU476FDijnFQkObaIeU4gAuSSm/0Eiai?=
 =?us-ascii?Q?ozvWoGfQtOjqkqQGsK7fGVIdqKASJQrik8EV9PrioBl/vsYxdoQas70j14oW?=
 =?us-ascii?Q?9gszQAyIShOB66oi97kfRdy8O0YeiOsh8pUJ//LdEUWKfOov5H3gOFJxfnOy?=
 =?us-ascii?Q?e6R+OaAbqDlzru9DksSmRjtqQLv8IvI9yj+VxXLMHieUcD+YucaNoqi2Qjg9?=
 =?us-ascii?Q?dghJA+rwo0x8uGDu/SLezeSGnCse6BkdYFng3srig7CdcD8umTNCL4S7tott?=
 =?us-ascii?Q?ViXYkM1x+AEaYcnBWyeFGW7+qR3L2IzCei/E2ksqDcWcIOuEi0r8syg4yete?=
 =?us-ascii?Q?R6/jX9kX3CNRUTkMOF08XfqI6Fdy3RdoxxOg/U7sm4E2mGKZ3BtXZhAKY6v7?=
 =?us-ascii?Q?y7L0LSAU2SLhkDOhc22FsNomXxFJOeRd+9JBVUTK0OaPepGPIrXZQUPs23SB?=
 =?us-ascii?Q?IM+S5u3y/KaxYSMQp2Uu6I+HNZYYwFLc99YB1cms/M7q8M0+SW5TpHmV6G20?=
 =?us-ascii?Q?JWplGM0KFg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71cb6087-5d0c-4147-3782-08da26be45ad
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 13:19:48.4404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P4yq62uMGnHd8NvZyC0VGlbO28EfqHpaJJ7akHUXL7QE+ngbe06hChQaNjW/BhOpsrTCq6oX32rv1xaRPjj7tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7063

On 25.04.2022 14:59, Roger Pau Monn=C3=A9 wrote:
> On Mon, Apr 25, 2022 at 10:49:34AM +0200, Jan Beulich wrote:
>>  char *libxl_domid_to_name(libxl_ctx *ctx, uint32_t domid)
>> --- a/xen/arch/x86/dom0_build.c
>> +++ b/xen/arch/x86/dom0_build.c
>> @@ -317,9 +317,12 @@ unsigned long __init dom0_paging_pages(c
>>      /* Copied from: libxl_get_required_shadow_memory() */
>=20
> Could you also update the comment, maybe better would be:
>=20
> /* Keep in sync with libxl__get_required_paging_memory(). */

Oh, of course.

>>      unsigned long memkb =3D nr_pages * (PAGE_SIZE / 1024);
>> =20
>> -    memkb =3D 4 * (256 * d->max_vcpus + 2 * (memkb / 1024));
>> +    memkb =3D 4 * (256 * d->max_vcpus +
>> +                 (paging_mode_enabled(d) +
>> +                  (opt_dom0_shadow || opt_pv_l1tf_hwdom)) *
>=20
> opt_pv_l1tf_hwdom is only relevant for PV guests, so maybe it would be
> best to use:
>=20
> paging_mode_enabled(d) ? 1 + opt_dom0_shadow
>                        : 0 + (opt_dom0_shadow || opt_pv_l1tf_hwdom)
>=20
> Or something similar.

Originally I was thinking that people simply shouldn't use the option
when Dom0 isn't PV. But meanwhile I've figured that late-hwdom may be
PV even if domain 0 is PVH. So yes.

>  Maybe placing this inside the sum will make the
> expression too complex, so we could use a separate is_shadow boolean
> to signal whether the domain will use shadow pagetables?

I think

    memkb =3D 4 * (256 * d->max_vcpus +
                 (is_pv_domain(d) ? opt_dom0_shadow || opt_pv_l1tf_hwdom
                                  : 1 + opt_dom0_shadow) *
                 (memkb / 1024));

is still okay-ish. Note that I've switched to is_pv_domain() to be
independent of the point in time when shadow mode would be enabled
for a PV Dom0.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:27:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:27:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312937.530343 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niykF-000167-OH; Mon, 25 Apr 2022 13:27:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312937.530343; Mon, 25 Apr 2022 13:27:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niykF-000160-LO; Mon, 25 Apr 2022 13:27:15 +0000
Received: by outflank-mailman (input) for mailman id 312937;
 Mon, 25 Apr 2022 13:27:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rnYW=VD=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1niykE-00015u-9G
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:27:14 +0000
Received: from MTA-11-3.privateemail.com (mta-11-3.privateemail.com
 [198.54.122.105]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 69a4205a-c49b-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 15:27:12 +0200 (CEST)
Received: from mta-11.privateemail.com (localhost [127.0.0.1])
 by mta-11.privateemail.com (Postfix) with ESMTP id ACC9418000B0
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 09:27:10 -0400 (EDT)
Received: from mail-oa1-f50.google.com (unknown [10.20.151.162])
 by mta-11.privateemail.com (Postfix) with ESMTPA id 8407518000A9
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 09:27:10 -0400 (EDT)
Received: by mail-oa1-f50.google.com with SMTP id
 586e51a60fabf-e2fa360f6dso16021407fac.2
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 06:27:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69a4205a-c49b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650893230;
	bh=COUANqa1yBnBucvA/LYW4WhQdaCqOvWHeqJEt+d7qKs=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=CU0BVdTTVCGRKaJgAkONsRrVlwLA7TZxTTcBwnrSh9RZ6x0s6YQHzLZkdmF/jAYq5
	 slS7RVbLmTQa26hLCtwYsT9jy4NSgsTp0CGE3SwBkKJgx4QxqAedd+yJNXu2Meguo1
	 4b+XzGoaG8BbZcmuADABh8CI2PmDxrQdiPbacObkUxjj5qMFJh9/c75Xge78/D6GHH
	 EGISf7dYeqM8x5irSmWTm+qDyZoeLvGz3ldW6O7L0VXrocwpesyeXOV99F3p5ccfCz
	 AXWc0ohqXANvDqZORRSmAMnQ/sNN65lAJcy7yofBg9+CEA53Va9mLqoy2vet08SGyt
	 u68rccyvZGyPQ==
X-Gm-Message-State: AOAM532DegkldgxJcDM1Nj9rTU8F4So5GMysAduk2Jt7sAJxoct9ZOgq
	pL50egccioeLWgxPk1OiG4D3aIylj6jyOLZEeHQ=
X-Google-Smtp-Source: ABdhPJzwcPIL4b0ha9sXZ/VNuRAW/u5l/KqKvAf9MMW06qxRWpKN7QGhU4ZwpbJ/RJPgyvY8uOAPIILW6jUvNAYi5/E=
X-Received: by 2002:a05:6870:b295:b0:e9:1c84:3671 with SMTP id
 c21-20020a056870b29500b000e91c843671mr3789029oao.128.1650893229643; Mon, 25
 Apr 2022 06:27:09 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <CABfawhki8YVxycv_zdDqDuOYvBdobdskXnjjdjiF7UND3784cg@mail.gmail.com>
 <310ab91a-60bd-f4fa-aeee-28aab43aabbe@suse.com> <CABfawhmzz5OwYr93EO7UAnb1X+vBoi3u=YVW6HMV5KpH_iEGeg@mail.gmail.com>
 <CAFLBxZaT1jRo8_KBKOFMdwvM0q=LAoUSxuHNkgOrFA00a9vVdA@mail.gmail.com>
In-Reply-To: <CAFLBxZaT1jRo8_KBKOFMdwvM0q=LAoUSxuHNkgOrFA00a9vVdA@mail.gmail.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 25 Apr 2022 09:26:33 -0400
X-Gmail-Original-Message-ID: <CABfawhkNU0z5_+QRHQny-ZkyWPSyRTgaM3Z9W5gA90a3qY3qFw@mail.gmail.com>
Message-ID: <CABfawhkNU0z5_+QRHQny-ZkyWPSyRTgaM3Z9W5gA90a3qY3qFw@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
To: George Dunlap <dunlapg@umich.edu>
Cc: Jan Beulich <jbeulich@suse.com>, Tamas K Lengyel <tamas.lengyel@intel.com>, 
	Alexandru Isaila <aisaila@bitdefender.com>, Petre Pircalabu <ppircalabu@bitdefender.com>, 
	Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien@xen.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP

On Mon, Apr 25, 2022 at 8:53 AM George Dunlap <dunlapg@umich.edu> wrote:
>
>
>
> On Mon, Apr 25, 2022 at 12:29 PM Tamas K Lengyel <tamas@tklengyel.com> wr=
ote:
>>
>>
>>
>> On Mon, Apr 25, 2022, 3:49 AM Jan Beulich <jbeulich@suse.com> wrote:
>>>
>>> On 22.04.2022 16:07, Tamas K Lengyel wrote:
>>> > On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel <tamas.lengyel@intel.=
com> wrote:
>>> >>
>>> >> Allow specify distinct parts of the fork VM to be reset. This is use=
ful when a
>>> >> fuzzing operation involves mapping in only a handful of pages that a=
re known
>>> >> ahead of time. Throwing these pages away just to be re-copied immedi=
ately is
>>> >> expensive, thus allowing to specify partial resets can speed things =
up.
>>> >>
>>> >> Also allow resetting to be initiated from vm_event responses as an
>>> >> optimization.
>>> >>
>>> >> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>>> >
>>> > Patch ping. Could I get a Reviewed-by if there are no objections?
>>>
>>> Hmm, this is a little difficult. I'd be willing to give an ack, but tha=
t's
>>> meaningless for most of the code here. Besides a stylistic issue I did
>>> point out which I'm not happy with, I'm afraid I'm not good enough at
>>> mem-sharing and forking. Therefore I wouldn't want to offer an R-b.
>>> Considering the VM event interaction, maybe the BitDefender guys could
>>> take a stab?
>>>
>>> Of course you'd then still need a tool stack side ack.
>>
>>
>> So my take is that noone cares about mem_sharing, which is fine, its an =
obscure experiment subsystem.
>
>
> My take is slightly different; it's more that the project is large enough=
 that it's difficult to se where the needs are.  If Roger or Andy or I or W=
ei or anyone see a thread with you & Jan going back and forth, it's natural=
 for us to assume that you & Jan have it in hand, and there's no need for u=
s to read through the thread.  Jan dislikes asking specific people for a re=
view, but many of the rest of us have sort of gotten in the habit of doing =
so, as a way to solve the "visibility" issue.  The only other way I can thi=
nk of to solve the problem is to have a robot try to assign tasks to people=
 -- a method that has received skepticism, and would also require a non-neg=
ligible amount of tooling to be written.

What's the point of the MAINTAINER's file and being automatically CC-d
if you then still separately have to ping the same people by name?
It's fine not to give an a-b/r-b if you still see discussion on some
parts of the patch, but like on this one, where the tools changes are
trivial - why would you wait? To be frank I long consider the
tools-side part of Xen unmaintained with only the most trivial stuff
ever having a chance to make it in. VM forking has effectively 0
toolstack side support in-tree because I never got any feedback from
tools maintainers after sending the patches in for months. I would
consider the toolstack side stuff in this patch for example trivial,
but again, no tools maintainers ever look at it so I was actually
considering dropping it from the patch completely since I really only
need the vm_event interface. Again, that would be dropping an
otherwise potentially useful interface purely due to the dysfunction
of the project's maintenance.

>
>>
>> But the only path I see as maintainer to get anything in-tree is if I ha=
nd the task of writing the patch to a coworker who then sends it in so that=
 I can ack it. This is clearly disfunctional and is to the detriment of the=
 project overall. We need to get some rules in place to avoid situations li=
ke this that clearly lead to no development and no improvement and a huge i=
ncentive to forgot about upstreaming. With no substantive objections but no=
 acks a maintainer should be able to get changes in-tree. That's part of wh=
at I would consider maintaining a codebase to be!
>
>
> Another possibility would be to ask your colleague actually do a Reviewed=
-by.  The first time or two they might not be "of suitable stature in the c=
ommunity", but I don't think it should take long to establish such a statur=
e, if they were doing the review in earnest.

Sure, but clearly still more effort then it should be just to work
around the system.

>
> I do agree that it seems like in this situation, the bar seems too high f=
or you to get your own code checked in.  I'd be open to the argument that w=
e should change the text of the check-in policy in MAINTAINERS to allow mai=
ntainer modifications with only an Acked-by.

Happy to hear! I think such a change would reduce the overhead on
reviewing patches like this that clearly have no effect on anything
else.

>
>>
>> Anyway, to be realistic I don't expect that option to materialize so I'm=
 very close to just stop all contributions to the project. It's dishartenin=
g.
>
>
>
> I can understand why you'd be disheartened if you thought you just couldn=
't get any code checked in even as maintainer.  However, there are lots of =
escalation paths open to you: you could email the community manager (me); y=
ou could make a wider appeal on IRC for reviewers; you could raise the gene=
ral issue at the community call; you could send a patch proposing changes t=
o the check-in procedure described in MAINTAINERS.

Fair point. But when your main job is not working on Xen and you have
a couple weeks in-between other stuff to try to get some improvements
in, it's not really viable to have to go reform the whole project.
That's just the reality. If we can reduce the bar on getting code
upstream in situations like this then I would be happy to continue
working on the project but otherwise I don't see how this is worth
anyone's time.

Tamas


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:28:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:28:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312942.530355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyl8-0001dX-20; Mon, 25 Apr 2022 13:28:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312942.530355; Mon, 25 Apr 2022 13:28:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyl7-0001dQ-Um; Mon, 25 Apr 2022 13:28:09 +0000
Received: by outflank-mailman (input) for mailman id 312942;
 Mon, 25 Apr 2022 13:28:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t3WR=VD=gmail.com=d.vrabel.98@srs-se1.protection.inumbo.net>)
 id 1niyl6-00015u-Al
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:28:08 +0000
Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com
 [2a00:1450:4864:20::432])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8afd2fe7-c49b-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 15:28:07 +0200 (CEST)
Received: by mail-wr1-x432.google.com with SMTP id e24so987488wrc.9
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 06:28:07 -0700 (PDT)
Received: from banana.davidvrabel.org.uk (banana.davidvrabel.org.uk.
 [82.70.146.42]) by smtp.googlemail.com with ESMTPSA id
 u16-20020a05600c441000b0038ebcbadcedsm13537782wmn.2.2022.04.25.06.28.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 25 Apr 2022 06:28:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 8afd2fe7-c49b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=sender:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=q66nx7Wy/YqGPn1l5/c0mTvFEE166ONkgbtWEZVKxwo=;
        b=XsoWHvsZj33NAAIJ9co4HnurggkfaPjaCwv/uJtlnAvB8NFLpyhUJokSRyBtGeCF+J
         LfvpdsGYOU2RRbSS/iZZ39DvqLdSvMYOyMF9Xc5yhqydmeCwS9Z+Z9hCiYzjIgroCo8z
         y8WfEPTfWNCq2hrM0q26CEjiEFwrhpyGQi1ebQ2t2r2iRfaR5W/lcn8LH8M//oTakjCD
         OWZidAiHYIvzPnG08NEf0HYhH9xZaoCJrfgwKvtBjKMH0rR6UaAu0vKES3DmfDrb/hQ3
         j/GkxJDUduyqdj876voK6Q8A6TIquvP1tTtolUUmb7MNu4RkDcZJPEXcsVIcomYYzx2q
         t1/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
         :mime-version:content-transfer-encoding;
        bh=q66nx7Wy/YqGPn1l5/c0mTvFEE166ONkgbtWEZVKxwo=;
        b=nTDo7iubg+O9mZ+X+WkzU/Fiaw3AfDyAxHVxcBqrGcy9SVQpa97dmuCUnKbmQC/cOo
         xUIjQek2HLTFpiu1Lxxgm12yDieWB7q8uyhSbTMRLi/dAI9drN1VwR6HnmbkHVckba4w
         w+R7BsQLrMjGs7JBZm/iKTlwflHMw8Bcn103rbUciKRB8WJpMWr7mo/E3xQoStPkwz3q
         nl2X580ZbGZix6IsTvxBF1uIKhcHav2Ii9SkokMswLI3VrZ/MVd7qcbxHOReFIGGy5Tk
         YPZT3q4SaMayZ/UZVqmQ7Gb75OvE9kyczVnoLyo03qx2jy/D3v6sEeKjhyQoZXg8Qfjm
         GFaA==
X-Gm-Message-State: AOAM530ijQHiYTDFhRVq5cfAYDBt4x/SN5ZmCd66p3ZIYZjoY2ZNFtPA
	oiIKp4NH27m0alhL5FuVu2nD9N0Lkex3IWRD
X-Google-Smtp-Source: ABdhPJzlEkR6bSWED7iMn1nfjEacFr6YymiG8OgEO+YSYywyqtjslo/mBg3bynqhNODC7MjNmj/JXw==
X-Received: by 2002:adf:e10d:0:b0:207:a386:d7b8 with SMTP id t13-20020adfe10d000000b00207a386d7b8mr14559357wrz.671.1650893286927;
        Mon, 25 Apr 2022 06:28:06 -0700 (PDT)
Sender: David Vrabel <d.vrabel.98@gmail.com>
From: David Vrabel <dvrabel@cantab.net>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	David Vrabel <dvrabel@amazon.co.uk>
Subject: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
Date: Mon, 25 Apr 2022 14:28:01 +0100
Message-Id: <20220425132801.1076759-1-dvrabel@cantab.net>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: David Vrabel <dvrabel@amazon.co.uk>

Heap pages can only be safely allocated and freed with interuupts
enabled as they may require a TLB flush which will send IPIs (on x86).

Normally spinlock debugging would catch calls from the incorrect
context, but not from stop_machine_run() action functions as these are
called with spin lock debugging disabled.

Enhance the assertions in alloc_xenheap_pages() and
alloc_domheap_pages() to check interrupts are enabled. For consistency
the same asserts are used when freeing heap pages.

As an exception, when only 1 PCPU is online, allocations are permitted
with interrupts disabled as any TLB flushes would be local only. This
is necessary during early boot.

Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
---
Changes in v4:
- Tweak comment.

Changes in v3:
- Use num_online_cpus() in assert.

Changes in v2:
- Set SYS_STATE_smp_boot on arm.
---
 xen/common/page_alloc.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..739ca6e74b 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -162,6 +162,13 @@
 static char __initdata opt_badpage[100] = "";
 string_param("badpage", opt_badpage);
 
+/*
+ * Heap allocations may need TLB flushes which require IRQs to be
+ * enabled (except when only 1 PCPU is online).
+ */
+#define ASSERT_ALLOC_CONTEXT() \
+    ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1))
+
 /*
  * no-bootscrub -> Free pages are not zeroed during boot.
  */
@@ -2160,7 +2167,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 {
     struct page_info *pg;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     pg = alloc_heap_pages(MEMZONE_XEN, MEMZONE_XEN,
                           order, memflags | MEMF_no_scrub, NULL);
@@ -2173,7 +2180,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 
 void free_xenheap_pages(void *v, unsigned int order)
 {
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( v == NULL )
         return;
@@ -2202,7 +2209,7 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
     struct page_info *pg;
     unsigned int i;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( xenheap_bits && (memflags >> _MEMF_bits) > xenheap_bits )
         memflags &= ~MEMF_bits(~0U);
@@ -2224,7 +2231,7 @@ void free_xenheap_pages(void *v, unsigned int order)
     struct page_info *pg;
     unsigned int i;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( v == NULL )
         return;
@@ -2249,7 +2256,7 @@ void init_domheap_pages(paddr_t ps, paddr_t pe)
 {
     mfn_t smfn, emfn;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     smfn = maddr_to_mfn(round_pgup(ps));
     emfn = maddr_to_mfn(round_pgdown(pe));
@@ -2369,7 +2376,7 @@ struct page_info *alloc_domheap_pages(
     unsigned int bits = memflags >> _MEMF_bits, zone_hi = NR_ZONES - 1;
     unsigned int dma_zone;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
                                       bits ? : (BITS_PER_LONG+PAGE_SHIFT));
@@ -2419,7 +2426,7 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
     unsigned int i;
     bool drop_dom_ref;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     if ( unlikely(is_xen_heap_page(pg)) )
     {
@@ -2738,7 +2745,7 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
 {
     struct page_info *pg;
 
-    ASSERT(!in_irq());
+    ASSERT_ALLOC_CONTEXT();
 
     pg = acquire_staticmem_pages(smfn, nr_mfns, memflags);
     if ( !pg )
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:31:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:31:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312949.530366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyo3-00033d-G1; Mon, 25 Apr 2022 13:31:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312949.530366; Mon, 25 Apr 2022 13:31:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyo3-00033W-Cr; Mon, 25 Apr 2022 13:31:11 +0000
Received: by outflank-mailman (input) for mailman id 312949;
 Mon, 25 Apr 2022 13:31:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niyo2-00033Q-Ju
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:31:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3ead956-c49b-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 15:31:03 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-tPpNObtHPJeVG4mlAbbMXQ-1; Mon, 25 Apr 2022 15:30:54 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB6518.eurprd04.prod.outlook.com (2603:10a6:20b:f8::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 13:30:52 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 13:30:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3ead956-c49b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650893463;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dM3QqwvkL/RyYaonWo+r0tMrDZssVgCQBPKVMgMSKlk=;
	b=R3tAdzjjm4WfU8xS+FWSceZGQb7p+ijwcZULxTcqH5y00liWVRNq6+GyleZC3IdpQ6m1X9
	wsQ7+fPXpu/FkoyijnnAN5d7ucLeuXEajruJ/G3GtSyL9q0y0+0aoIU3S38W34ahUTjr+a
	huEbmdRV477yK+zSEGX/tcGkbIuzFiU=
X-MC-Unique: tPpNObtHPJeVG4mlAbbMXQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WX1RbCXg7LRbPasKbYP/Zu99lZLMBTqJBKGQTREPvjtcU61cy85Z+PhYZvHEvd6nZmcu4LisUahhvDOaT2mHzNthaPqouYm9kr9s8GFuI378ZeH7xKmYmVobZ6w5y7OdCcpR4YGGpYBJ0xfZxd4/yuJCQulObkSdoD+fmKjncUNsc1FfUuGIQza+pOjClqMl4t8XzcbF18oFARtSGE4EcpZjUloGcVro525iAaa9kfKKEuV6wKYZkT4qoQXvG0MPGWrYe1PU2r4NXRrx7pgJy5MUoblK9k8kcD/5ZTc5r7WRwR5q+DcZwF1pdny7/xyfWioOHRfuOShAI/3sytnIOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dM3QqwvkL/RyYaonWo+r0tMrDZssVgCQBPKVMgMSKlk=;
 b=W1sDamvE2I2Ej+7wt3TA1fCyNINcq8E0YyfFU5+v8yaHus2+eJ2Z83clAVt7ueokiphU6C7cQKU9q54WbaiKiXYPLh07oPfFLC8yS0WTIB9Q2/Mp4miGiLhmTS3A8Lw/Szx8qvQPkYqJ2dqXdkzO+d87xg8ijNaPdW3bfHGWzXtVHTWl/f0fVFXfpraOQLw+hK2Hb0zbxOw/oSEob/GkX1rGgQpk5WbYe4Px8T5wL41aLG6upIm5LG8uR4mBWKtiJFEEPRcf4XKS8Pxpf/udo/rG3ay0LxNw65X/Qp7UQSZQ4w3LhHjepQfN8LSkSeDJuTVaSRIs+yxu8H1AurTUuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e03936f3-2f65-79a6-51c1-194d25cd5c1b@suse.com>
Date: Mon, 25 Apr 2022 15:30:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220425132801.1076759-1-dvrabel@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0003.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9c9e5885-fb3c-4b60-438c-08da26bfd179
X-MS-TrafficTypeDiagnostic: AM6PR04MB6518:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB651881EBC1198F422031A5DAB3F89@AM6PR04MB6518.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LW9XUNDlWdiTq318z/OnIUPls7xNCrP1YM3gYBA7QKp6NPxWU/wVfbssn6izeDdWgMagPc9WGrcnyE7ERnr+dhtWUqajn6HMxHREQz3+3N2URq9X0VG0ibe9ywhsGSMp06e4g4V/RyZbBhGpawULsDVzI0LTSTv6ILSlqksurM6vijPDQUZU4bEhjb7zIR3Be5f8alzsF889Exgnsgis25Ech3xqf7QwWWwsEOziXI/HP/szuGfwYVkc5pgiDG09OFqrsDoHzLZef/VQ2VYn3rtoN01SSgEyAXDwvEIcEoOiZbnNQHpU3DgSLMpgFATTotgCJCY2JS7BvO1mpgj0dvhtRVaEJMm1SPNhWWj/SLrPtJkHHkHkMGbKDapZkpL3m3uqWlLglPa1hxvDmAaWuA2BOFoGpHbFGsgaVxWzooF93a+hyRkv82ltR5+BKyYhx7KZSVg4CzyH5nsPMvTlFNLlcs3kyeGwV3aMmC83au8LGA/vjg53CHeA9MHr1t7SUQL0XDkfSvSbIa/Wl7b5xMfO75ZNskMipZXmH0VMnRfQlNlMdy9UoPgS9S4IO37YL2PMbR3pEj706GAnVyq8hJVyUkiXS8uj2mgyjEeRtvuTKHfd57pasYthtGTE2Ui26fZFCB9mvDt5axDcPOgqgb8ZVMLTLbq+ADWWyeHJkQprcJFjzeVsao+6E4Dz77SGYHVFrKNI+kYMyekGZ5bHEwUQDCDbXeCIV1+lzAUgUq8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(6486002)(54906003)(2616005)(8936002)(508600001)(4744005)(2906002)(83380400001)(31686004)(5660300002)(8676002)(186003)(66946007)(4326008)(66476007)(66556008)(26005)(6512007)(6506007)(53546011)(316002)(6916009)(31696002)(38100700002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZXhUb2tia2tJSHlBcGpvRHhHN25zS0wxM2k3MXB1ZDNTbDFpRm1IOEI4VTZX?=
 =?utf-8?B?THR2aXNySVZEY2F1MDd5ZzFqWnBjMWl5R2dldzJUTzFRYUdkNTA1YUViY1Z3?=
 =?utf-8?B?emgvNUpiZXNQSjhkMDNTdWR5MDlYNWVwM3JVWlhWcWFzOE5RdTFnWjUrV0dE?=
 =?utf-8?B?MUxta2VtVW85SGw1OWJZMnNDcWRDODEycDNTcUxhRVNnaXVudlFySjYyZEJJ?=
 =?utf-8?B?K2R4V2IwNnBLMUxDWnM4UnFuaEtDaFh1RU5PSmwrRTZ3eFpKVllMOVo0eGV5?=
 =?utf-8?B?VGRhZS9RNVIzZnpJTVUrS05qQUxmS2srM0pCaW9zVEdLWEh0S3N2WHNlRXYz?=
 =?utf-8?B?QVpldDQxR3JtcVNaUzcwcmE3WVJyR0krZmhVM0taZVZQVXFnRzhuRlB1Z01h?=
 =?utf-8?B?V1dsenplck5JQm9tdVdWWHQ4M3pTcVoyYlFSRXBkZjVJT2IrL1RkVllGQmRx?=
 =?utf-8?B?Y2JuMmVXN3AycFZhRXRHZ3pMeE1nMm8wWWEzWjZnSjEwRWpNUDFqaktONU1v?=
 =?utf-8?B?eHpTTHBkUHNoMExvMW9DQWFjWHkrTlhUVC95WUY5RHVScS85dDJ1SGx3WVUz?=
 =?utf-8?B?WG42T1dPS1BlVFhUcmNPQjdhdnJzUFJVNms2algrcm1DMnNxWGcyUHk5NE8z?=
 =?utf-8?B?YlFPZXc2UG5FMktzN1IxKzdNZExlalRROW9zZEVHYmE1K1Y2YjkyenpBREN3?=
 =?utf-8?B?QUxwdjR1ZTdjWG1XNHNoTkR2NkI2SkVGYkMzTzljYm5jdTZ1ZDRRTXNwRXVF?=
 =?utf-8?B?K2o2bE9IZ0FQN0FlMUpUMDFBeld6QlZKdzJpdk9NR25Fdzd2VzVuY2l4N1ox?=
 =?utf-8?B?VHZJZTFnVllCdUt0RWZmZm8wRXlPakF3c21IS1ZSMnk5eXBJS2dJTjUrL1hP?=
 =?utf-8?B?V0RiRDFNQVpBc29EcUNGMTVFZm91ejg4Ky9GMnQ0RnpmNFhEdDNJWk00UFNB?=
 =?utf-8?B?Zmw0SWlOdDJnL2s3WWF3bGZzL1FLdEhTcGdxOWZacnUxaEhBY0pOaDJVWnQy?=
 =?utf-8?B?L3pyTmlxZDVhOE9zdjVIbjlCcXRJcFR3Y24xc1pidnZmYkpNTDd2UG1wZHZa?=
 =?utf-8?B?Qm9kTFMyNFkrYVNUb01JYzVXUExDam1tL2lKVUttc2hIZml2VDJiSFRmMStO?=
 =?utf-8?B?bmRObWNJQk9naUU2Z1lsNmdibDRHTUJuYXkxWCtqVTBORlVtNUs5V3ppNzBC?=
 =?utf-8?B?NVpSZE1KaWtaV2pkNmRrVUM3dVhkUWFrdmVOTzFQbmZUMm56U3RFR0l0QmFw?=
 =?utf-8?B?THRtRzQxTVpydEUrZmZpUk9SMks0a3ZPeFp3QVBVQVhjSGVHd29sNXdlcVJB?=
 =?utf-8?B?M3ZMd1h6UVBUR2dPcVRZNW5sOVNJblpyVE42emJDSndXdmVoWGRtd1FsZUpN?=
 =?utf-8?B?ajdmSUVWaHZYZ2FlVlZOU0lkbEtDWVdVMC85OEc1d1BadnRFQ2U3MEovY0Ur?=
 =?utf-8?B?ZWh6QUlUS3JsajN4MHc5Z2FTbTVnOEczb3JMR3hDNEdoSXNLUlNYOU11WDY5?=
 =?utf-8?B?UWh2ck5iV1V1ZDhuVHVickZXaHpDN3RBaG1hTWxCWWxYVDBDQ1J2SFhUNEsw?=
 =?utf-8?B?UFN4NVNRbUFiOHgycnhBWk5TbVV3eEhYK3pYL1BpRHI4cUthU0JYUmNSa2po?=
 =?utf-8?B?VHBOazBEUHRZaG5rME8wSTMxcDNrUzlCVHdXSW9pYm5OZWFKc3hiQWRTSFdO?=
 =?utf-8?B?M0JtZUx0NU1LZENaczRzWDhWQzVwaXFhMnFLeEZnZk51UVhIQnBVVkhMZTFO?=
 =?utf-8?B?SDdvWk5iY2x6bmJMcTB4Y1IzVUNQN0FkQldsODFWWTFLbUFQb3MvTWtWRHAw?=
 =?utf-8?B?Sys0ODd4d3RPdmExSWUyNGplRnA3bmN2YWladXc5WExrT2VmUlFrbWh6bUpa?=
 =?utf-8?B?TzE0U05ibHZteERGMmdZM1JSOEVscTBGT3JFQ2JhR1lkdDBtYkU2Uzhiakd0?=
 =?utf-8?B?Y0lOMlJDL1BPaXpwMVUyRkdkQUNleElPK0wwenhJRW5kY2VGQUVsblVQb1Zn?=
 =?utf-8?B?QWYzc1gwQm5waXE4ZXgvR0VuZmgzblNYY3l3RnpiZktReGRjSVhqSGJKWEdi?=
 =?utf-8?B?NHVaWWEvQjRHTlhVTDgxeTJsdnpmS00vMEZ2WWQzaWRrREI5NUtOczQ2c3ox?=
 =?utf-8?B?bDgxVU56OVdIaVZUOWJEcWNEVWkwTVZrWmRkbWFjalVYTFJQM1pRMWFlY2Yr?=
 =?utf-8?B?bjRoeGRtWUZHTnFpWWdlRjk5NXBPNjZTei9IbHg2ZEdpSUVTWHVFb29CUDBR?=
 =?utf-8?B?Q3hSSzBqT05DcUdtMUlqVEYrd1VQY2JsTkNGRy9aQU1FSU5iblVYL3JHS3NK?=
 =?utf-8?B?M01Rb05NM3IwQnNITTZHRUd1aHRjRHNJeTV3b1NSM0JMRG1CYzMrUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9e5885-fb3c-4b60-438c-08da26bfd179
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 13:30:52.2759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ShGefq590y8DB012s027z7Pajw5et5lHd+3rSS8OHG8KqOJ0qBlyGgJd0Eio1Zdk+H/MXKknozeN7u2KHuUPuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6518

On 25.04.2022 15:28, David Vrabel wrote:
> From: David Vrabel <dvrabel@amazon.co.uk>
> 
> Heap pages can only be safely allocated and freed with interuupts
> enabled as they may require a TLB flush which will send IPIs (on x86).
> 
> Normally spinlock debugging would catch calls from the incorrect
> context, but not from stop_machine_run() action functions as these are
> called with spin lock debugging disabled.
> 
> Enhance the assertions in alloc_xenheap_pages() and
> alloc_domheap_pages() to check interrupts are enabled. For consistency
> the same asserts are used when freeing heap pages.
> 
> As an exception, when only 1 PCPU is online, allocations are permitted
> with interrupts disabled as any TLB flushes would be local only. This
> is necessary during early boot.
> 
> Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:34:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:34:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312961.530376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyrL-0003qI-VJ; Mon, 25 Apr 2022 13:34:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312961.530376; Mon, 25 Apr 2022 13:34:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyrL-0003qB-SK; Mon, 25 Apr 2022 13:34:35 +0000
Received: by outflank-mailman (input) for mailman id 312961;
 Mon, 25 Apr 2022 13:34:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1niyrK-0003q5-Jg
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:34:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niyrJ-00043p-LI; Mon, 25 Apr 2022 13:34:33 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.15.211]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niyrJ-0007Za-DY; Mon, 25 Apr 2022 13:34:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=VFA2bwq+N/g1nk5aB6qmDDdBQOpyn63PAsMd+yKpEvc=; b=5f4c6SdmfCTdpk4hcjk0RjAjm7
	VmticDrx/rxshlmf+tSEggBl+ps51jma3Kh7zFeHH2rHrErfSrNybUJKceCgPDz/zAlZaGEOGM2R0
	2iA9pquiU9KFQhqr/x91gZrrXf/PSrjsRyeiDk2nILw52uW5YmMQN1sNTo2TtPl3dHNA=;
Message-ID: <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
Date: Mon, 25 Apr 2022 14:34:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
To: David Vrabel <dvrabel@cantab.net>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>
References: <20220425132801.1076759-1-dvrabel@cantab.net>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220425132801.1076759-1-dvrabel@cantab.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi David,

On 25/04/2022 14:28, David Vrabel wrote:
> From: David Vrabel <dvrabel@amazon.co.uk>
> 
> Heap pages can only be safely allocated and freed with interuupts
> enabled as they may require a TLB flush which will send IPIs (on x86).
> 
> Normally spinlock debugging would catch calls from the incorrect
> context, but not from stop_machine_run() action functions as these are
> called with spin lock debugging disabled.
> 
> Enhance the assertions in alloc_xenheap_pages() and
> alloc_domheap_pages() to check interrupts are enabled. For consistency
> the same asserts are used when freeing heap pages.
> 
> As an exception, when only 1 PCPU is online, allocations are permitted
> with interrupts disabled as any TLB flushes would be local only. This
> is necessary during early boot.
> 
> Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
> ---
> Changes in v4:
> - Tweak comment.
> 
> Changes in v3:
> - Use num_online_cpus() in assert.
> 
> Changes in v2:
> - Set SYS_STATE_smp_boot on arm.
> ---
>   xen/common/page_alloc.c | 23 +++++++++++++++--------
>   1 file changed, 15 insertions(+), 8 deletions(-)
> 
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index 319029140f..739ca6e74b 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -162,6 +162,13 @@
>   static char __initdata opt_badpage[100] = "";
>   string_param("badpage", opt_badpage);
>   
> +/*
> + * Heap allocations may need TLB flushes which require IRQs to be

The comment needs to be updated to reflect the fact that at least Arm 
doesn't use IPI to flush TLBs.

The update can possibly be done on commit.

> + * enabled (except when only 1 PCPU is online).
> + */

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:36:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:36:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312968.530388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niytW-0004Vm-FM; Mon, 25 Apr 2022 13:36:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312968.530388; Mon, 25 Apr 2022 13:36:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niytW-0004Vf-CO; Mon, 25 Apr 2022 13:36:50 +0000
Received: by outflank-mailman (input) for mailman id 312968;
 Mon, 25 Apr 2022 13:36:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niytU-0004VX-Jb
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:36:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c11011b6-c49c-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 15:36:47 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-nEIQsjezN4GN7ckBup66hA-2; Mon, 25 Apr 2022 15:36:38 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB7991.eurprd04.prod.outlook.com (2603:10a6:20b:289::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 13:36:37 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 13:36:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c11011b6-c49c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650893807;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pJjRhj0zC21ekkO4MkALsPFI8gwH5FzS2z+xka8dvOo=;
	b=FEI0JosRSsM92NyRBKPZ0ENocp9dCPDmptUuGlM80J2jZ138N4w1VvcDzEltsq+xPJ9NzT
	dWhrjuXx5tqgekittScejQviSEB3cD2jEzZ5pTEczSJ4hHPNoJOrI5wiM8j08laBRTh9H8
	Gsl2iSgglO8xaf5lmDzKx6Oqp+k+lNo=
X-MC-Unique: nEIQsjezN4GN7ckBup66hA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iypJsdzCf/Pc4GpKjAp4tXANFj6VXrTn7sl42q1pmNOmL+bQgLoIKrGXBcLL4zXy1ZXsRCkbr3EgYdQGv/zNCfJiWwF8PijX9nXM6q1u4M3v11eAi/zI/tcXuivMEM71k/YfXbtbmIId/r1J1SVHTKzy0rNY9MUwUtAEYC++p5T53nRaJBVtnZDFQnb1wHPux+0XTsuyOOq9MIzl9ijJ4Dtaa7pccOi/9/jDGBDCv+KsCGKw7QLVIImH+CQEII1e7dD71CY9kfwNxNVxTPHAUoZy+/WyaeITlBvorbgT14XXP6oQ4Ls4T/xIdtUxIw5Gf33sss2+PPlUsn4bNNrgqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pJjRhj0zC21ekkO4MkALsPFI8gwH5FzS2z+xka8dvOo=;
 b=iBFhZqVxh/H58Oc4BjJkXWZWodY+xJmbDbx/TpqzFcJOyFPLjOnBTQ8wc4zZRbGOL3SRRIW8DPNoKj9CJpVRggFESOPb36xBQ/7nbyE8dTOM8Zse453TuWSLKm3YsXu+Y6cZzGDPlZTf2+kYWYHUynswirYUWdILLgDdwByO7lipiV4cgr/wOrYB7QkeEC5AVvPm7rl/3BJHZ7TbfpxseuXSWc9yfe0mhxo81OZFl3g8+irb5Qj1esoh6y7HKs1V7nOKvPCyiZb8gU81ZTHWT0E+BE+X0G1E9Aj2+npS244NPFfzXUVqnX/zYkcdt7KGLLFGlIQ0s+dGcm84vvJcHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <704c371f-ae25-e2eb-dd90-67493a16fe1b@suse.com>
Date: Mon, 25 Apr 2022 15:36:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3] x86: Fix XEN_DOMCTL_gdbsx_guestmemio crash
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220425123717.18876-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220425123717.18876-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR01CA0048.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fab8ad33-2808-40af-b7e8-08da26c09f01
X-MS-TrafficTypeDiagnostic: AS8PR04MB7991:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB7991035FF1EDE06354521474B3F89@AS8PR04MB7991.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ltw+qS7bPoQgJAbqWvjm/cfD9B1i8BzqMygTtjuM540MPojTBumQYjk/Dqe91SFxL0mN801WNEmc2kNJM+Z8luw5udIlUrvj+cLcf3ENDkBn51LzVB4dgbxQMSvEBh93IkCgcVU9ZUO6DMBASQOu7U2h7f4bfovR22+fzn1eoP0r2G7MbYD6G5AfMcn+TuTEbNODNWkwjWNABoiADslLc0bodsh3kshTGbD45+F7lXsuaG2Y+bxhYI6ZUvObWeWoRjoxSA8oQYHpQ8Nh4oZCD565tcscrHHOShCpwDYS7lnx8e6KcNJI78eXnZN0NSOXIZFgAGZq/nYcgdc8Y/TQ/Hhl8kNOwekpPZlzE4xVN/2nEVvhhpHCKgsCKDfE/mdLv0XfaZfBMOvFqKQaoynoeNCqT1FoSD2YOQ03vI2Bj0/pmOE9paSbVzglohmp4U22GT4TmrgJfEzTDNx5VU/6/bkKMxe2aj0EUJIK+aNcp7NL4HUKGAI9BuTsYPUWWSChztfhFnCBi+kvslg6lDSjsPI1qX3oIuH1NvxH76Lzt69X0VU0hfOrzH83IxGuvNKazVj7uAK/S1odXrty8DvE7AyaFNFhG0KdIiDQI5nRqBbBlupRKcnFXMv7b+JzaGOOJ6byDwZUPdmXBhVfCe4SQ5fuUtR99PSALVhSJqRnO2Yi1036zJxX/1RIVEvCXafOWkyOK2IL8pfANrJ9Id3ijGuJnJyNaViV7Czdmkz7sF4R9ERpVNKGxR+G1re/aXfX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(8936002)(5660300002)(8676002)(508600001)(4326008)(31696002)(86362001)(2616005)(316002)(31686004)(6916009)(66476007)(66556008)(66946007)(54906003)(38100700002)(83380400001)(36756003)(53546011)(6486002)(186003)(26005)(6506007)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bmlOUzdQOHpyTVowOFMrekVRZDhIREtpUnBzT2l1NzRuNHM1Rm5XM2xXT1Rr?=
 =?utf-8?B?RUMvUWRCZ05xMlU1VjVkbjVDYmVXSHlEYnVuKzM3NDMvODZsNnhsRktncmNz?=
 =?utf-8?B?OVZheEpaYkZJY241YTdtT0xiaWVGTVdaVXluYUQwUmw1OXZPYlMrU1dTVXJy?=
 =?utf-8?B?NGY2RnE4MjRWbUJVaVJxVlRxUTM1RkozZktFV1lOR21aM01rUzdlR2NFckRP?=
 =?utf-8?B?RVNPVUlBRjh5WTU3SWZ5WngxQTNMSHZYTHVkeTJTZGVuZUQ2aHJkdmh2QTFh?=
 =?utf-8?B?Vmx3NDBWdXFIUEkwWjNvckdrVVhxQUNaNzBsSlRIN0JVdWRiYTBMUjludnNu?=
 =?utf-8?B?RXdpTUxFUHhENmtBMElXRTV1VWo0ZFRzRTBBQWtyZjNIcEZyMnlUOW5Gb3ph?=
 =?utf-8?B?d1NLOU1SM25zQ1VUSmhLdEh3czYxMmVvNSsvVEhObC9paW5NaVhUNnM0Y0Z4?=
 =?utf-8?B?K1lwdDFvd3Y4UDZ5QmZLK1VrK2VkdkhIaDd3Z2ppVUhNam9qUDZURE5vaEtQ?=
 =?utf-8?B?YnBZN3Y0YkRrN1hDMHQ0WXovUGNlUkRkL3J3UGJzSjFOd3k2VmNUMG5ZTHJY?=
 =?utf-8?B?eVpaaE9TWGZLUE5JblVrdk5KWEhEVXdtY1E5SzY2YWVJd21JTHpGekZIbUV6?=
 =?utf-8?B?UVJZNU5wdE5vSTBxN2lnSmN0YzlqZVdsbmN0LzlUSzZRaWhjWnlmenY0L21Y?=
 =?utf-8?B?ZlptM1YzVVhleDJCM2dMSXBVZFc0N3puTHV1VEJYQ2tWZWhrN2tlSFR4a2xj?=
 =?utf-8?B?TjFhSk1lZTgzQm5RQTBwME41bEFSczJQcFRxeGNZandaY0NkYnFER2d1K3pu?=
 =?utf-8?B?UUpmalJ2eWJXNm5lYzFJNmJCN3BFU1EySEU1OTRyVFlhMktzdDVHb0FaU242?=
 =?utf-8?B?VUtQMlBseCthOS9HMHliYjdCcEtKcnRUY1E4REN0cmFSUFF3ZENxdCs2bTVV?=
 =?utf-8?B?Zk5QcU5KM3J2NjlmVXpXOWs2SVdMYzNWSmNLR0w1anlPTVJTdmQxOTZnRnl0?=
 =?utf-8?B?N25yRXpFS3dyTkZGNDMxMUZCMEE4eTFtK0JYOXdKWmp5d29SMDlEN2FwQUNC?=
 =?utf-8?B?bzBCL2l4NWZTalJacWFlNTl0cVBOQjlaZEcycGlsRGVSdnFybkpxWDEwbFA2?=
 =?utf-8?B?OTEyUHdGK3JRZ2cyYURlWEdibXB4eU5FaDJpQ2lrY2x2Zk9lbUdLaEtoL3Qy?=
 =?utf-8?B?cnpiK3YxNUlsVkd3YVpmb0FWRk5SM25ZTGxYbE02QjVYRFQ1WUtpdVB6SVNn?=
 =?utf-8?B?WHFUTHBQOHdyQWZqNHhxZmFZZHAwc1pCeGRJSnJ2Um43ZDJmb1pRTjI1MlQ5?=
 =?utf-8?B?cmlyY1JxcE9lUjhoSW15dEpHWHE5T1ZPQ01PbEY3S0dqTnoraXg5MDdHQXIr?=
 =?utf-8?B?UWc1NStQOTJtSDdrOU02cGkyaHJJM2YvbC85YUs1eW03QnE0SThxYTJrT3o5?=
 =?utf-8?B?blphUkFVUlYvY0YxY1RSSnVhOGorSEFIaTcrVUdFYjh0NkozbmZSN3NoNmc0?=
 =?utf-8?B?ZVhKTHQ2dk5SSzB5Y21iVDRSeEdNNTB5UFZRM0ZTb3RMbWFBeFpQYXI5ZVZD?=
 =?utf-8?B?R1kxcm9mN21ic2tYbUxQOXhqYmdQOVhKNnRwZEh4eTJVTmc4S1h4b1VjVnVm?=
 =?utf-8?B?YnZ4cXRiQzdYSGVLREVnSW40MnBpdlFBYStzemZUZ1JORzNzcXNvTnhHanZr?=
 =?utf-8?B?dkRXSDQzSHR2NzhKVGNjR3ljaHVkWjJJcWc4NjJUZTN5Z2JBc1dDTEE0Y0V5?=
 =?utf-8?B?KzdndjJkdFdraFNJcnJpK2NONkx3bEd4bjdmUU1PSVBIVnJyU01NMGd4OHVS?=
 =?utf-8?B?YTZMSzd0YWxJUkhQSEFnd3N3R1dTdklXYXNuVW9teGhhK09ONFhqdkZQTXg0?=
 =?utf-8?B?RXErNXNiUWlUZXJ3UDZBYTBYcFVqN0lRNlkwU0R1YkVmQ1pvRkZCcXBGTHIz?=
 =?utf-8?B?Q29WdzR4S3ZLckFzVlFQMXI0RUZQaldvY2laRGo5OXBZOW1ZemhFSFE4VlpM?=
 =?utf-8?B?TlRnbGtyTldyb3N5THkwRGRvTGdtV3BDL0dWQWFYUWc0WnRlWUZqQmY5ZUx0?=
 =?utf-8?B?ZjVRN0YrWGhwTEI1TTlqcWpYQWQ4YjREVWFhdGZrc0RYNnE1OGtuSm1DMWht?=
 =?utf-8?B?UWRoOUpaeTJ5RWFsSzlFWkk5S04zWTBmMitKSnBKRnUrY3Vxbmp1TzJJRVJS?=
 =?utf-8?B?OHR4KzkrYU1ZMHhibVVHajFnVGVHSEY4SCtLc3VXeVZTTTFldzNVOERNOGxZ?=
 =?utf-8?B?QWFrQVNCVHVjMmtkT0hlUFpFbE90SDFjS1ZLVTR5djZOajZmNHZIYU9JclV1?=
 =?utf-8?B?cE9FOG1rUUJGMnFXaDRsbDUyU2RTQkg3MFI0SXAyWEtHZDZiclpiZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fab8ad33-2808-40af-b7e8-08da26c09f01
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 13:36:37.1031
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NDzzkoCNdeV2Y9tZsh3uFXLwQs4O04R3+N9U86RaAcW6T7iVv484dg8mfjUz5vY1wHZRjHseJfTqcjbHNQgGVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7991

On 25.04.2022 14:37, Andrew Cooper wrote:
> When CONFIG_GDBSX is compiled out, iommu_do_domctl() falls over a NULL
> pointer.  One of several bugs here is known-but-compiled-out subops falling
> into the default chain and hitting unrelated logic.
> 
> Remove the CONFIG_GDBSX ifdefary in arch_do_domctl() by implementing
> gdbsx_domctl() and moving the logic across.
> 
> As minor cleanup,
>  * gdbsx_guest_mem_io() can become static
>  * Remove opencoding of domain_vcpu() and %pd
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Technically
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Yet as mentioned before, ...

> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -816,71 +816,12 @@ long arch_do_domctl(
>      }
>  #endif
>  
> -#ifdef CONFIG_GDBSX
>      case XEN_DOMCTL_gdbsx_guestmemio:
> -        ret = gdbsx_guest_mem_io(d, &domctl->u.gdbsx_guest_memio);
> -        if ( !ret )
> -           copyback = true;
> -        break;
> -
>      case XEN_DOMCTL_gdbsx_pausevcpu:
> -    {
> -        struct vcpu *v;
> -
> -        ret = -EBUSY;
> -        if ( !d->controller_pause_count )
> -            break;
> -        ret = -EINVAL;
> -        if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= d->max_vcpus ||
> -             (v = d->vcpu[domctl->u.gdbsx_pauseunp_vcpu.vcpu]) == NULL )
> -            break;
> -        ret = vcpu_pause_by_systemcontroller(v);
> -        break;
> -    }
> -
>      case XEN_DOMCTL_gdbsx_unpausevcpu:
> -    {
> -        struct vcpu *v;
> -
> -        ret = -EBUSY;
> -        if ( !d->controller_pause_count )
> -            break;
> -        ret = -EINVAL;
> -        if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= d->max_vcpus ||
> -             (v = d->vcpu[domctl->u.gdbsx_pauseunp_vcpu.vcpu]) == NULL )
> -            break;
> -        ret = vcpu_unpause_by_systemcontroller(v);
> -        if ( ret == -EINVAL )
> -            printk(XENLOG_G_WARNING
> -                   "WARN: d%d attempting to unpause %pv which is not paused\n",
> -                   currd->domain_id, v);
> -        break;
> -    }
> -
>      case XEN_DOMCTL_gdbsx_domstatus:
> -    {
> -        struct vcpu *v;
> -
> -        domctl->u.gdbsx_domstatus.vcpu_id = -1;
> -        domctl->u.gdbsx_domstatus.paused = d->controller_pause_count > 0;
> -        if ( domctl->u.gdbsx_domstatus.paused )
> -        {
> -            for_each_vcpu ( d, v )
> -            {
> -                if ( v->arch.gdbsx_vcpu_event )
> -                {
> -                    domctl->u.gdbsx_domstatus.vcpu_id = v->vcpu_id;
> -                    domctl->u.gdbsx_domstatus.vcpu_ev =
> -                        v->arch.gdbsx_vcpu_event;
> -                    v->arch.gdbsx_vcpu_event = 0;
> -                    break;
> -                }
> -            }
> -        }
> -        copyback = true;
> +        ret = gdbsx_domctl(d, domctl, &copyback);
>          break;
> -    }
> -#endif

... I'm not overly happy with the retaining of the case labels here
(and the knock on effect it'll have for other subsystem domctl-s),
so unlike usually this R-b isn't implicitly an A-b. Which doesn't
matter in practice, aiui ...

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:37:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:37:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312973.530399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyuZ-00055H-Q3; Mon, 25 Apr 2022 13:37:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312973.530399; Mon, 25 Apr 2022 13:37:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyuZ-00055A-MM; Mon, 25 Apr 2022 13:37:55 +0000
Received: by outflank-mailman (input) for mailman id 312973;
 Mon, 25 Apr 2022 13:37:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niyuX-00054s-Mh
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:37:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e7db6dd1-c49c-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 15:37:52 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-bsDO0eSuMlC1ameI3lo_gw-1; Mon, 25 Apr 2022 15:37:48 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB7606.eurprd04.prod.outlook.com (2603:10a6:20b:23e::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 13:37:46 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 13:37:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7db6dd1-c49c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650893872;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RSsxJi9LYlPJl+IIMTs5uDaDxpOJHdoiSIxtw0NZvLI=;
	b=YnANsN2RfWpU8HNQFvl3tjWk54tdE2QmBqFF6P7lThfgOGFUENMkUleVuQMdPn805HSIMM
	DX6Xb999C9JSz+LqVZqGu0rhKzhsOqwZcij6uZnTbuOFiT1KGyfK9oXoumBubJvaVOi365
	EzY/C67mwdv1EpyeB8ZyZvIWOsNNnng=
X-MC-Unique: bsDO0eSuMlC1ameI3lo_gw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OX6d23fwd/V3C+QSd2afj/UyNYQnC+i723y2FqPjGeUR/dmaRlkwW4TK5gmotiC8xYhx/+SV72Io4yMcKa7a1Qmb/lXtHhzyWv0oXQK/qm/JML8PsIzrSzBAFRLkZSt5mLYVxsgopmzsH4qG5m/xNeN9Nv1jUT605mmu7zHdc8QBoGHcsh17+Fbd5YZBuHGL8xbJIvEJC/DUXgtfAinpUKg4ERVeR53FskA+Ctqf5CV5sfKJK++mqit2JP5sYac1FHjSxnNiO4sN/QGQGGD4yhYLC2z6WRH5/SZUGpIpf0G2Y+O65vbzKSMrKE5fkSMzyI4PcL2n3dr/sP2NTG8Gag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RSsxJi9LYlPJl+IIMTs5uDaDxpOJHdoiSIxtw0NZvLI=;
 b=finOw7y2zHliiZogVk1iEjGTkXx5fIRyKK2MzcNDsfvaTIqTTQw7TSsPysjo2/pBODWi7588Tzg0i7/K3uLhDe6Fe+p5QADIHkuZ+l5qcw0L/rukTTeGLX9STkDzCWkCmTjXv/mdxM55oRJsKIm0/cF57q0dRIaplc4DI0d+dndqCtlTa+ZvDXkeVNo8emMaJyyHS3i4MPm+ry7eqYSHW6PXh0Nsm58DQG/UyrIf1eN9DgLt5/Xuh3QkQ+10PdsnSzzcp/CCtY1a7Ur22ziodUmXP1R9p8cPn1YxdfMFIOGtjldbiPq97PZuxM6+7CbJ7kvbkzdhPqS8p2bFl3sH4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <afb15744-5e80-6c40-069e-6fc076e40e3d@suse.com>
Date: Mon, 25 Apr 2022 15:37:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, David Vrabel <dvrabel@cantab.net>,
 xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0027.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::40) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4e135b17-9957-44bb-10da-08da26c0c88d
X-MS-TrafficTypeDiagnostic: AS8PR04MB7606:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB7606D0110502DCCC73A78852B3F89@AS8PR04MB7606.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lI6wJFyMSjHlQV68gxlVTUaZhYiXgt3l9WGY2+xy+jcd1iNU9xcoUXEe8IpkOYw6XS683byJpJ/TsBok57PGwfIG7eZzxbEGNiucyl3h3nT29sZq7piZVzUEqa2uoEBiq3Gc5ULkjek+XKm5NTN9gAd6lp3GDO/djr1gvJFaYDjkvboEvYL4PLiG5r4CYTDsq0NLxgHPBqUuFkX8B6cSkr6SZ8kzSpZskWXkdtrHCxR3dtreVlcCz0jOl+Nuj64uXj5B1le9b1t4zoMlEwY5NFkhT8tSrskAVx4SfkEmrIQ8hgbKv8Wlb8z4N6BgO2sNC2ASOj+HDuLaUGKieg0Y/LAeU8LYUVTIkhT5sO2xnYFprxwVMV4lHUmd3Ye9zUSPPnTV1tOrDiVFYSK2QwnPdkQ5kDYqgOGVeJc+HuHyxECtywHIVTSZRxi2yAwATXazwwUW+ihw/Ypwh/nfMyYhLkwYaGAa+HcQAVET8xT/JhmeOQBguNVRGyosFcT1qg0ClDlOxsbEurksdtjLacwOGShbWM4vjXlbTyjRjjqfaMum6FyWVi4ikQWbtanQLuRfQeHjC4qlARXi16udgxyzc/0WgY/Mukz3trpw7Uf0w5CyQDFVuiu/TIcr8pzciuVPS/bEw2+9m/RK/W+6A5egLifDTo8dPiZJPWrtAzj4PUbqmmV5CI46X/nYYUYVQdf1sbdFRxCSAYjg+8nKigUiV2TgkexhmVQCFHNOkEmEwsajVLGOmMI4dQy3ljkQU2G7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(86362001)(26005)(6506007)(31696002)(38100700002)(2906002)(54906003)(6916009)(316002)(8676002)(4326008)(66946007)(66476007)(66556008)(508600001)(8936002)(53546011)(36756003)(4744005)(6486002)(5660300002)(2616005)(186003)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OVVTRzVOaGJ0dDluRnFSaGJtaGtOYlkvem8xeEN0NVdYZjNYRlBSbFN6SFg2?=
 =?utf-8?B?U0g2Qm1hZ1NsVVYwcU9sUkl6UjZma203bUl6RENoUUZ4V2pVWHZjYmM2WkVV?=
 =?utf-8?B?UW4rSy9tcSt3bk9WeEY1c2Y2aTNxNnp2VndpOHgrSGFpVXpSekpCbGpjNitz?=
 =?utf-8?B?ZUtzOUdzZmVJTEdKS0FPZUhQZ2JHRkF6SUtqS3pXZ1ZjcmNQVE9wSU0wT1V1?=
 =?utf-8?B?VEIzaVAyRGNRTU93aTVvc0h1SFNORlVTcUtVY1l6c1hDYnBVWmhFMFN0ejUw?=
 =?utf-8?B?QzY3V2Vyd0JnRGc4ZGtWdUFXQ2N3dWswWS9UTkg4eXhjRXJ6UnpqVnAzaUNy?=
 =?utf-8?B?ZytQS3RzL2NiUHYxNjlMWWUwM0JTOWtvTWxBUXZ1SHJZcHpJNFlDS0owMDND?=
 =?utf-8?B?OHMwQ0VobTVCeTlJZHpEcVYyMXdEYzBiYUsyam9pNlYyM0FyaXg0VzRNU2Mw?=
 =?utf-8?B?cVk1aHpEaVFSQTlnckJOL3c5a2J3cEdOazhsVFBObiswSnRQeWRsYVN1dHZP?=
 =?utf-8?B?ZUZrTGpYUUl5Z2lWN2VPYjZSM1IxMXMzSFlFbTQzcDRIR0tKRTlCSmV6R0xQ?=
 =?utf-8?B?cnh2Ni92TlVhVjNBT1U2TXdidGpyYjlqNWpsa3BwSFh3d2ZlUldZY2t2OGNU?=
 =?utf-8?B?c25qWHdDVFJlRkFYN2pWK2ZPNmxwMmdZeU50dUpITUU0OUhUcWZTeTJLM2Vx?=
 =?utf-8?B?d0NZaDF5WFRvNkE5NCtRN3l6WnVWMmMyN0VWZjJJUXhZN2sybG1GanZxQThM?=
 =?utf-8?B?RFl3NVBUK3p4S0hOM0ZvR0NWTW9RSVM1SVlEQ2J6SzVlZDlzTFdzcjIrWElu?=
 =?utf-8?B?VUh5VTAwSUpVVHlxWDRDM1BJSklRZ2ZXQ0FBZi9uTzFCMXBhbURySmtSb3RF?=
 =?utf-8?B?T25jN0JHWmxhRUwwN2xGY2JSelU3RUZDbGRPOWZlcUUyVVlIZXo1dThyeGdm?=
 =?utf-8?B?RlJEOGZPNHVRRUFoSytqaU85QU9mWVFEUWpFSFQ4UzNNZ2xQUTU3TEFUVExY?=
 =?utf-8?B?ajJSNzVxYWowUnhicVNPOGhQQWVLTk9FYnJHMCtBdzhEbEtWRitOekxwcmt0?=
 =?utf-8?B?ckUvQUpFUU5KTUpmZEFkNWZjaS81TVQzNlRIYjJJNFdJS3BJSmFzNnJZWmx5?=
 =?utf-8?B?eUREOU1SalMwY3FmanU5WEpCdnhaMklJdGdFdDNLQVEvbGRkV2VzbFNkRnlK?=
 =?utf-8?B?ckg5alJ4b3QzNzFKakFidjRCU0VzbkRVczljSjNjK05tYkZjT0c3QS9iRFJM?=
 =?utf-8?B?V0ZlVGtyOGJ6UWFtUjdXY1RPNlAzcE0vb0gwQVhqU1FjeHNYUERVRDc5Zlpz?=
 =?utf-8?B?WkZSWXlOck0wazVxZk50blYvYjNoMzlURmJleVptQSszU0dnbHd3dlY4V1dQ?=
 =?utf-8?B?cWJWak00UElFV1RBTWFQZ3pRQkpuaEtQODB4NWp0eVY5ODlVQlhDRzZiRWJu?=
 =?utf-8?B?RzFhbGFpMlEyTlR0MjM4bFZOTEZxQllmQ2p2QTV1V2gyN3BWeWJtNlA3Tk5a?=
 =?utf-8?B?eVdnL2lDVmtFbldUOGdZUFVTYm5uakNmRzJDd2IzYm1sOVo0VlJnMGRiaEhM?=
 =?utf-8?B?UFRENWhIdHJBWVYzaFExR1F3M0dIa2Z2MWdPb0MzTHB1N3lJemEvU1F0UFVS?=
 =?utf-8?B?VmNPZmsvRksyMzd6WXVRcU9KRGc3N215aVBTL1VYQ3hpQmhybXNmRTgwWkdk?=
 =?utf-8?B?YkhPc08wWkF5WXgvV0VUemltT3YveGFERU9qa1dyZHMwc0s1ZHFOUjJQU2c5?=
 =?utf-8?B?UzdtTlVtT2hvZ1Q5WGJQYlRwcHFVc3RmVDBHTFBHNWtQMHA4c2RjWjF5ZTA4?=
 =?utf-8?B?N1E5QWZ3VXZhOEhMdldFd3FRZXpaVlh4YlVoSlVuZmhxMCt5ZG0zWDV2S3pW?=
 =?utf-8?B?SG90aE82cTAreDNvSTlOREtlQjMvMjhHeUV2TFlKdTZzZC9kY0Q3dENrKzNi?=
 =?utf-8?B?cjJzNklRNjNTR2ZKMGNaNzFUTDBlamZVNU0waGxuTjFJL0NrUm5VZkNPQkUy?=
 =?utf-8?B?UVNJRXE4L0R1djg5VW5PNXJ3STRsZE9uWWZKMUZlbmtHbXFVelFOaWNxS2s2?=
 =?utf-8?B?My96TklGSHFmaWtMK2c5UU5lRWZhUDJsQWx5RC9iME83aE1sWmJCbkU1KzZ0?=
 =?utf-8?B?dGZpNzJDY25rT0VlRThJZDlKNmNFMUJTcG10UU5sbXRvRDJXYlRkN2FVb0hO?=
 =?utf-8?B?aXJZSHJLV1JWUmt1WUIvN3NTU1RNNHkyMlh1NEdzNDlwODVCbDREK1hZeGk0?=
 =?utf-8?B?OEZoamFnMFAwWmM4c1RSSnF0UGVUeURlRjhPekhhbk81QnRaWFYyUTRuR2NX?=
 =?utf-8?B?aW1QRS94RmtRdUZiaWJvYUpSalpEa0hVVWl1Mk00UkhlYUhJdGZ5QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e135b17-9957-44bb-10da-08da26c0c88d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 13:37:46.8016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kbCzoluF0ZYcs1mj0WhrhZfwSv08bM6BQC7yXjWFi/2xJTOO/EI4AyKD7EA5BbFkRbezbQyq4U5+wYTFf2p7/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7606

On 25.04.2022 15:34, Julien Grall wrote:
> On 25/04/2022 14:28, David Vrabel wrote:
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -162,6 +162,13 @@
>>   static char __initdata opt_badpage[100] = "";
>>   string_param("badpage", opt_badpage);
>>   
>> +/*
>> + * Heap allocations may need TLB flushes which require IRQs to be
> 
> The comment needs to be updated to reflect the fact that at least Arm 
> doesn't use IPI to flush TLBs.

I thought the use of "may" was satisfying your earlier request?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:40:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:40:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312980.530410 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niywz-0006RL-76; Mon, 25 Apr 2022 13:40:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312980.530410; Mon, 25 Apr 2022 13:40:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niywz-0006RE-3i; Mon, 25 Apr 2022 13:40:25 +0000
Received: by outflank-mailman (input) for mailman id 312980;
 Mon, 25 Apr 2022 13:40:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niywx-0006R4-Vz
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:40:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 416cfc23-c49d-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 15:40:23 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-zCGxp_kVOSelJhb4C6iAXA-1; Mon, 25 Apr 2022 15:40:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8277.eurprd04.prod.outlook.com (2603:10a6:20b:3fc::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 13:40:17 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 13:40:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 416cfc23-c49d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650894022;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=q6YyUpGFd6NHtkrn3PKi5UvcIQfaq414X/N9X/i5nDk=;
	b=mGufJvg7O4Yv8L3gJFhs/jSovr10vFqmZQvxB1GXEW8etBjx8/fr6gYLelYLu+4k7O7azA
	b+dBMo4lhGEkKo3FicDZEVvO/ZpMZDzZQwncZd3pWqsEwDXUwmrMsPQXgF+y5ELFHEjkQY
	xX+YnLU5m8AXJGIdbheUtM+EwB3rBSg=
X-MC-Unique: zCGxp_kVOSelJhb4C6iAXA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l3alwh2IHvYTowJvtRTeAgoVDfcGHFCMHfDpCXnYt5OlBEAzn8bNrpFGKLGblbrIGnp5bjweWp++c0CGZQiAIYbEohj00g2tAwKRom7Imj3KmnKZ9AoFeS9rtMXLYVWgLPMe4GfrGjdM9A4i4DG4sCwhdk8DG0NpL3RS13Vj3moAw8jwzNKC0M0eqSLmr3xLcYpSgCX+h3bwVbkGJHjAANf/Zod8k4V0LE+/mVwoNOyXYxX12JwowmJe0p9iEqphom1XHmbwVYyCdjBrABdLGfvCNmGmlK62rMXcwt6krpCdvZiqSP5Nq8wg3zg6CWmdF7V/kJMcaBCs2yvGdBrzhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QnDgujrzOyfv1pJFIwtkjskpKyMN9g/CFoxbb1Ik1a0=;
 b=M45mMG7IJ1s4iXoZS+Tmu1eTql7xmellqSwlUrg3oaWCDjCLW+aR9nL56gAUq+7Pef84MjY5hB4VVeHZHuU5mIzHL3I1E6xkW8/rmDe5RbJ9kiHxhUt+GPz/TcViuGgv4vjiXIBKw406qI1E1Ic8PPxmaCPCAWmCgk+Fm/J9LWjadRCciVIt0LWEZ67E5nBJw1JFI5wMvAURC5NGQlSMJFleRcU644HEtklEQeYTsQDQlVu3388FPg3p9XzoGJrl03Fb3EQQfaThBkeURTdt9gQXxhHsjAGpM9AiOf1l0ujQKhOuJWFT6ro/ULGq0e9dkGWpXtcaJa5J3bgqlh2HGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <601b900b-daea-93be-ae7d-f2cbe956a973@suse.com>
Date: Mon, 25 Apr 2022 15:40:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Bobby Eshleman <bobby.eshleman@gmail.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220420141307.24153-1-andrew.cooper3@citrix.com>
 <20220420141307.24153-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220420141307.24153-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0068.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 53c0600d-44fa-4b9d-e1e7-08da26c1227d
X-MS-TrafficTypeDiagnostic: AS8PR04MB8277:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB82777346FD58E9B87576718AB3F89@AS8PR04MB8277.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IQK6mEGvIAu95RuN40u3W+jRVJgaUUotxLWmKo4j3khNBny5m+zjv4E7/aze9FQQ6xUL2100e+pqob3WsIBD4YyQYz2lUP/U3Mge2/2kKvuK7Nz3t6JRwP3RPFOVlRSSQtFG6ccAcqNiIk6k2oZZ+ADrshnX1RklQ4xz7FXvv22aGQlEQZ8tQsaxx19ml6NlcAXwCtLPoBf0x+APCmw9uez9LDblPeLScW1rJiTbpyMphgb9F5yE8VFeiNY+PpJlwLJAzedqu/TB9mKwBItgfLrLS6kuAVk43i/JTjd7D8xmHaMxAmAj+6uCYUQb8ghV1++ConwbHi/9wKTnJYMpBEQQRWB/x2/U1jq2kt65bGafkgQzSdVxX3tpp4NKAYrFAKLWS43W8S8QMeRKhPsL6VNy5WziyGMfCSAiouqZjTbUe1tEj8/MUL0Ip85rCTO2WH55Xx5yv+R2k/AS7E3dUxEh/8CYlcyw1bA+4XYBnjhwdzNkdJ2+4tGc8cKYonY8RGZF+/jdVNeHIFGBxkJ9V+UwfyLp9WAjWPxAA5L20Xiks0nyJFt8qKjE4CbvDDjwfEF/cajcyQf5f+iH7JW9UzDTLXNWvH7l1JtFYW+LEQOLahN1R3Ly0ogeY0mJPBE9bqeMAOPD/Ai0mElsrgcuBaKnuEJPhEax+mTRHAQBeFwgwuHJf9Mw2nAa6/QOhUHhRt69Q7cV6cFoXga20xhY4DocCSIbxqnpyMiMIZotm6GfQxT/Q/jhNqD2SQkUvChK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(66476007)(4326008)(2906002)(508600001)(31686004)(8676002)(5660300002)(53546011)(2616005)(186003)(83380400001)(38100700002)(86362001)(26005)(6506007)(66946007)(8936002)(6916009)(36756003)(66556008)(316002)(31696002)(54906003)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+SuhSw6//hTi9rUYn61OIQoc6nTHKI49uSAU3T+4CTB0qVPjoXbeNDJO6cen?=
 =?us-ascii?Q?QWRda2CmbAkHjgnVLcC/yGvOsd7Z1T2dWpyxNRiIwGpqhFMA42pgIWEPd0m1?=
 =?us-ascii?Q?XkDI1k6bwyqercG0NQ33n78UXnk4OD2hJoD7Av/u8nXQNNcwWrB7aSxINxJJ?=
 =?us-ascii?Q?WIj54UTHaLU7/8ZDH5ifBKBpsHAuekKnZUfP/hy7NsqsswIf9V6cHjQexoBF?=
 =?us-ascii?Q?yPLJccVADLb71kutJLEX+vhC7AnFLE2xS0iM7FLiS8NWY5pNYpnVFUkxRocZ?=
 =?us-ascii?Q?Jk/b1adH4yc8O7K7dwVriNBXdJS1zTsl/nTWPoU7K0xDSAPATi4iE8uwq5X6?=
 =?us-ascii?Q?DYCqoPfdL1lzLZ9HkPUuETIOqkr/7VKA0expAsu09bmqUwyZu0wXalGOEdbz?=
 =?us-ascii?Q?kTOfWdGJ/RKXDTyxcJ1o4YpaAKWot+OuEvTb37q4RgH6aUBso8ARBHW45VKH?=
 =?us-ascii?Q?2XQevRWSN9CAynFfFrwZX8fKd9GA9Q6xADw35ZwgS8Kld7HreVrc4FHXVodP?=
 =?us-ascii?Q?BcUkrWbyFgbELTa++L9471AqbFsERUjweM97C4iXJflJJkjQNiSrQ5b/CtEx?=
 =?us-ascii?Q?9FRAc+JlfaCi+a8pHH9uEw07zugaguPDgYBIupelN+yjOKpwuNDjuSsBVq6f?=
 =?us-ascii?Q?bSOuoK5yQPqx16oQWbfY2yFOlhYOl1uk2MBnHypN2i00iV5XGTXR/fBMCSwj?=
 =?us-ascii?Q?/9Xd23A3ZS2bvUrZEvsvApM+7C8J5g08fDIaevlOPqND/5X2Kj9bCWKvGilx?=
 =?us-ascii?Q?4YCnDGx5Zsjxr9Vy7bCsWbAIUBbWDhT8KRibYDaUjtZBQvjd3kwqGJdnNLSP?=
 =?us-ascii?Q?wu9suv+wuJ/VMYHOzMP0g3IGyIYW6zc0YZp+KEKaYzBIIlyeqMkpKthOkPhA?=
 =?us-ascii?Q?SsZSmsF0Ne32GrZ7Ry/hx2J8vxOIUXhQ6PEU4sUfILE61plBqL+SENRpSlFv?=
 =?us-ascii?Q?e2aD897qoHHKzwLz9ICoFH2Kz1XYnntyyHvqJIW0GFv6Dsz0g10fyGTWM5iP?=
 =?us-ascii?Q?ECDKMUJlpHlZ+S7uxzBxKwEqymQ7qgVQcVZjRdv4o8NWGOadQld5rgkFE4zt?=
 =?us-ascii?Q?I0pZxF/XJM/+WsBlmu/MlZFSZ8iJVGfQcIU6G2WZKDaN8AiB+b7LhXASY2X4?=
 =?us-ascii?Q?vBfyYev3pNLFYtTU6EnZm6lFQKb5ffwCVldpMxHPgONDl1vZfCOF+bbBLQ0m?=
 =?us-ascii?Q?JArfnppm/tznnIAyCpViZ0ssFdetqs/W3Pbdzp4NJVGCaNvBpv7Dw3NLQhYQ?=
 =?us-ascii?Q?kOqXG78MNM5eRnmB4dNiWV0tC+Qkf5dRYzRkZOHuQMWGj4w9cY8m8eauLffM?=
 =?us-ascii?Q?GznU0vSz+/HYTmvWYkdtbjtoR8MpeYOe2U+Ch8ahVmwnp+VLha1w/pLVamnD?=
 =?us-ascii?Q?QAVK4kNciYy5nSrDz/eBFl4OxGD+qINiYhqDci4mOXEGV8h1kKlT3VKH+sBY?=
 =?us-ascii?Q?kb3PCxXRvrr5ykmhvzokzhIDKQUPL/65c8M6PfASQjZTnib0io3/jK3TjRk1?=
 =?us-ascii?Q?6j5tBAdGXh9ereu75zpaSUZ+5pOe3MOfr2f7VZssej4sNz1ed+fZooziFQfR?=
 =?us-ascii?Q?nG0BfeHD9uWEibG1g/73YFdIemXG052qYg4orLnWAaMloHJIWrGDyIsjc0QJ?=
 =?us-ascii?Q?lwx3TfP9vLsy3gUvuaL5ynHzgvXk3f/mTVuz0oxWJQTq8Be4+KUKbhZBNU49?=
 =?us-ascii?Q?p02L6ZpR7cVPVPk2wCPtp+/eQDY+4vNzLOgGa8HiHTEuemF53FwqWuTm27fJ?=
 =?us-ascii?Q?OY4XyrzkSg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53c0600d-44fa-4b9d-e1e7-08da26c1227d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 13:40:17.7139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HsqusbgknzfqYw167MvudIPMNcudWVswGvlXo89R8TpO8403/w/NJDdhQNzeNlKufjM8pCh0O641FS8JApypdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8277

On 20.04.2022 16:13, Andrew Cooper wrote:
> From: Bobby Eshleman <bobby.eshleman@gmail.com>
>=20
> debug.c contains only dbg_rw_mem().  Rename it to gdbsx.c.
>=20
> Move gdbsx_guest_mem_io(), and the prior setup of iop->remain, from domct=
l.c
> to gdbsx.c, merging it with dbg_rw_mem().
>=20
> Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
>=20
> v5:
>  * Consolidate hunks from multiple v4 patches
>  * Rewrite commit message
>=20
> The semantics are rather broken.  XEN_DOMCTL_gdbsx_guestmemio only sets
> copyback when there's nothing to copy back, and skips copying back in the
> -EFAULT case when the iop->remain field is relevant.  Furthermore, it can=
 be
> asked to move up to 4GB in one go, with no continuability whatsoever.
> ---
>  xen/arch/x86/Makefile               |  2 +-
>  xen/arch/x86/domctl.c               | 14 ++------------
>  xen/arch/x86/{debug.c =3D> gdbsx.c}   | 23 ++++++++++-------------
>  xen/arch/x86/include/asm/debugger.h |  6 ------
>  xen/arch/x86/include/asm/gdbsx.h    | 13 +++++++++++++
>  5 files changed, 26 insertions(+), 32 deletions(-)
>  rename xen/arch/x86/{debug.c =3D> gdbsx.c} (89%)
>  create mode 100644 xen/arch/x86/include/asm/gdbsx.h

As I've realized only while reviewing your newer gdbsx patch, this
should have come with an update to ./MAINTAINERS. Quite possibly one
simply deleting the entire entry there.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:43:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:43:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312988.530421 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyze-0007K0-P5; Mon, 25 Apr 2022 13:43:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312988.530421; Mon, 25 Apr 2022 13:43:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niyze-0007Jt-M3; Mon, 25 Apr 2022 13:43:10 +0000
Received: by outflank-mailman (input) for mailman id 312988;
 Mon, 25 Apr 2022 13:43:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1niyzd-0007Jn-VA
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:43:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niyza-0004DA-GV; Mon, 25 Apr 2022 13:43:06 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.15.211]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niyza-0007yW-9K; Mon, 25 Apr 2022 13:43:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=SIRyqshOu0DGw1xfId/vUcFwO7nyD0yx3usILzwM/Jc=; b=62WbAMgoZEwCA0AztidelRDKRW
	qEzXS6kO7TsnRUrGeJe1/6OSnKAVGF0BVGxwotJ47hnoeQuixyIUk+odrKHtmxo5EiTWmXuKxeJ0W
	U+nsNR6xL4oYKezVCqbieil3cVcyV8O2KXw9fJcsF+qK30Sg8TkSkNUDH0thVdaUe9tk=;
Message-ID: <74500983-79f8-07a9-7dcf-54a7bc162061@xen.org>
Date: Mon, 25 Apr 2022 14:43:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, David Vrabel <dvrabel@cantab.net>,
 xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
 <afb15744-5e80-6c40-069e-6fc076e40e3d@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <afb15744-5e80-6c40-069e-6fc076e40e3d@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 25/04/2022 14:37, Jan Beulich wrote:
> On 25.04.2022 15:34, Julien Grall wrote:
>> On 25/04/2022 14:28, David Vrabel wrote:
>>> --- a/xen/common/page_alloc.c
>>> +++ b/xen/common/page_alloc.c
>>> @@ -162,6 +162,13 @@
>>>    static char __initdata opt_badpage[100] = "";
>>>    string_param("badpage", opt_badpage);
>>>    
>>> +/*
>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>
>> The comment needs to be updated to reflect the fact that at least Arm
>> doesn't use IPI to flush TLBs.
> 
> I thought the use of "may" was satisfying your earlier request?

Maybe I read wrongly this comment... To me, anything after 'which' is 
optional (it is a non-defining clause) and describe how the TLB flushes 
works. So the 'may' here is referring to the possibility to use flush TLB.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:44:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:44:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312993.530431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz1C-0007u8-42; Mon, 25 Apr 2022 13:44:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312993.530431; Mon, 25 Apr 2022 13:44:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz1C-0007u1-1C; Mon, 25 Apr 2022 13:44:46 +0000
Received: by outflank-mailman (input) for mailman id 312993;
 Mon, 25 Apr 2022 13:44:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niz1A-0007tp-9G; Mon, 25 Apr 2022 13:44:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niz1A-0004HR-8T; Mon, 25 Apr 2022 13:44:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1niz19-0000Vl-JN; Mon, 25 Apr 2022 13:44:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1niz19-0000mC-Iy; Mon, 25 Apr 2022 13:44:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8snh572TTYAZzLOhofsdic+RAzsNOMwzDNW3brRIppc=; b=V7mHdrLtxh/U+jFwwLrs74GZVH
	Wf7MiSZhHBHrd5OFSq7T+4FM8sJ4znNm0t1d/qLihc3Vo/NhUt+UQjs9bYu8923+slAeClw410VTW
	mZtM/D1Byq+T5Shl/eTwZn0oGjXrp6jTo972whczfxoVZ/anTK2xCv9ocjbWmiY5z/R8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169707-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169707: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 13:44:43 +0000

flight 169707 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169707/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  620 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:44:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:44:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312997.530443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz1L-0008Ea-Ck; Mon, 25 Apr 2022 13:44:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312997.530443; Mon, 25 Apr 2022 13:44:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz1L-0008ET-97; Mon, 25 Apr 2022 13:44:55 +0000
Received: by outflank-mailman (input) for mailman id 312997;
 Mon, 25 Apr 2022 13:44:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1niz1J-0008Di-RW
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:44:53 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niz1J-0004HW-6X; Mon, 25 Apr 2022 13:44:53 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.15.211]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niz1I-0008EI-W7; Mon, 25 Apr 2022 13:44:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=nfheuvvxeT/yA4RR2e89QWM+Rncu8jKMASmPZoOTpzw=; b=EilFge4DOlN4DTF71CMoxCiRGX
	uKfz0e2IM4VRGNly9PmmehcDzDrhTamXVTX162+1L+P+/kJU7saErtLA38m88OlCpb2CFtP5GuF8c
	H9gnSy10e+6ApiZv4LrulZIEKkh795ezR3qQg4ZsKXnwMHrCegdwdSuycgIqjzS9utDw=;
Message-ID: <645b2e0c-7ba3-03d0-7438-07cc432f6b11@xen.org>
Date: Mon, 25 Apr 2022 14:44:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
To: David Vrabel <dvrabel@cantab.net>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>
References: <20220425132801.1076759-1-dvrabel@cantab.net>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220425132801.1076759-1-dvrabel@cantab.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 25/04/2022 14:28, David Vrabel wrote:
> From: David Vrabel <dvrabel@amazon.co.uk>
> 
> Heap pages can only be safely allocated and freed with interuupts

The typo I pointed out in v3 has not been addressed. For reminder, this is:

s/interupts/interrupts/

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:45:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:45:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.312998.530453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz1Q-000092-KJ; Mon, 25 Apr 2022 13:45:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 312998.530453; Mon, 25 Apr 2022 13:45:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz1Q-00008q-HU; Mon, 25 Apr 2022 13:45:00 +0000
Received: by outflank-mailman (input) for mailman id 312998;
 Mon, 25 Apr 2022 13:44:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OfhB=VD=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1niz1O-00005U-VQ
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:44:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e5649175-c49d-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 15:44:58 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-Dygxzp6NONOg9F3gDWX1jQ-1; Mon, 25 Apr 2022 15:44:53 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr
 2022 13:44:51 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 13:44:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5649175-c49d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650894297;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ghY+xzaSACVfn+rBM7XU56+JSQXJZR3ojZ70fLF589w=;
	b=iN3d8rOjTXAWxeJE08dT5d5WLtwiYkXp5E4hPNlvYnFzBr+Z3svm+rxz8nVQprQDBCdRv1
	hhjp27xZIlMmx4P6YlCIemFofWW0mNCGhwmeZ+b38rkiTghLMTT5sIAxJ6vHG7oXxzof8/
	j1chSvRpVr6OPChZ95AM3bl7pOPFB+o=
X-MC-Unique: Dygxzp6NONOg9F3gDWX1jQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hWCAVO7jZrtVX5t3waFgag+HDxFvcWeizvRhEk6bDAJxtcFkVdKIshZCun8ZcDqtKJ7fC5dM3RNaL6EmP/2IjYIixQmIbkNNbaReIBZMP1UAwDLRXaC0xRAjQL/0O/jlyraOUBil3fc0MDoIu0TFlXTgTLH8X7KzIB8Pu9zX4zD6CnlH3CbtPb4ZzktHBWi6sH7VuLX0YVn53YxjJAYj2gTPVB70B76evUcJ1Rh0A9Ht+glM07LfTPodi6HgIIl7CfQ0e6TZWcwXC8DNyq4j5w3ALnyaC++1lHuM7QZeAyhdsB+sevrWnX491v5Oipfhg8/H3Y53BgyJn6sDV0rslw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ghY+xzaSACVfn+rBM7XU56+JSQXJZR3ojZ70fLF589w=;
 b=b5bDtJP+v1AcWaNMEQFkqrhBQZMZDOjkhAsKFMugudXPINoHsdQDpLOtNjQp0izOIeOENyelLoZsBX1W2d64ScVr2bU1SYVjGf2wDZDdz+zM/D/ejM1V8yWFLQD5C5r6R6sHGsEmsgk+BdaNzSv6SrmVgzGyCPKPP395RuiG4+t4Bw4f+7mzbzdSL7jN72YQsisvdXXQMFYF4M2ylSAGqVGZB7Fk37cP0M8pliZW63V9zYAudmI4FBqtxuWAdDtRF6lJ2oSGZQ2OW/UpSlEfe8Dx+AaUfv1EfIpyJug6RLR+fl29C5RZTL2FgoOy9XVifb7we36s2F6VxGvx4f+neQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <efcf913a-0549-3d5b-08c1-82e3d7a26349@suse.com>
Date: Mon, 25 Apr 2022 15:44:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, David Vrabel <dvrabel@cantab.net>,
 xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
 <afb15744-5e80-6c40-069e-6fc076e40e3d@suse.com>
 <74500983-79f8-07a9-7dcf-54a7bc162061@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <74500983-79f8-07a9-7dcf-54a7bc162061@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0167.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 917f0aa8-71a3-41ce-9d31-08da26c1c5cd
X-MS-TrafficTypeDiagnostic: DU2PR04MB8951:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8951CC86B524AF41F5892B58B3F89@DU2PR04MB8951.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A+Oq8Hxi8uOKLv0y2XIbG25sjPpE3prHwT8yaqMwJPtvggcgwmEeOzpHRyxvGPgGMlbmpeDCyqun3wggNDXkJ/6fBdZH+M+IAFpMAoqQIySwYlOJXFxIADooaMCJwtNF73HZ+8F7F9Ntx8o8qeO/Tqwcw5Opct7drA3v+y0TOLfYeoEFvRzw/OF5ztZmkrzDu4tJD33Zf1+oV7mwsvvZTmGt7u4Hq9scGU20lyAyt3JJsqJs+gC5JDPcEUyUCKxKNUJnf65fRdJK9IcDl5PmK8D81nDK+8xWdELEgwI2AFZavczYlu4lY+ijFeifXGdnbWXXj1IY7le3VC3PppKNHrGULyDYXgxT0TMJM0XcI14KaxoIYP0PQWvVn3PKo7iFTERlI2noTzOk/E53JO0bweEujfhlKJrd6y3wD+qer2kSGxmOC60mUUNj6sxCxO9PTmrPvpNnIijwZFf2lBAg8T76jlk9eEIls65HT/wY3FRfv/a/ocHhWzevolbbUGrwxZPOEvdcQgGd2BC/mrdGUcTSWGqjP1RiXhPEzb3epWAugTAbmYCNgJuq5JBompzTaTpuyHPu/XJVRbpfY/Ut3MJrH4qJHhQxXtRDmjJ/uDY1ssJKxZs+EduUyfj7JeSSqDhz5p9aS2Nl1NTgu3B/Jvvno6vOkfIZEOYvXKkWC625v8nLon87LvrO3hkvnuZ/Hmqew2C3D4UyLOQKD9mjtXCmM/Pja6xKIhDb/VdsT1AUpf8cTAuQBtT43S6CXk+2
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(66946007)(508600001)(316002)(36756003)(5660300002)(54906003)(6916009)(186003)(31686004)(4744005)(8676002)(31696002)(66476007)(66556008)(38100700002)(4326008)(86362001)(6512007)(2616005)(6486002)(2906002)(83380400001)(26005)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eTVqNStRR01ValZoNkhkWG9uaU53U2dkNEY5dFllbHJrRTlpV3FzK1Ezd1B5?=
 =?utf-8?B?NkJvRTMvcHN3NnpuTURPYnFESzlRSXdHL1VLSmlpNytJRk8vOXRucjI2REJI?=
 =?utf-8?B?QlVtVk5QcGJYVEVTM1ZzZGVCQ3I0Njd1dUtOK0lqOHEyaUYzeVk3ZnlWTWRC?=
 =?utf-8?B?djNjSVV2L0o5OXF4ZWNJdE1pV3ZSaGVQRkdGWlVTRlkwRHhBMlozSk9NZm51?=
 =?utf-8?B?NWdvYlJOc3BKcWozZk8vMEhBU2ZWSUVTdVFCeDhCbUU4d1V1UWZMVTZBakNT?=
 =?utf-8?B?VTVBQ2NpYzV1Y2Zib3N0QTQ4Vk1ybVliZmFUeFhtQ3M3UFNhZE9VZVBldGZp?=
 =?utf-8?B?SXV2azdGY1ZlVERjckE4NHZhdzh4aUQzUDgzdXlvY1RoU3ZWUmNFYnQ1ZG9R?=
 =?utf-8?B?RjBNSkI2MVJWSTNrVUI3WTlOazVUaUdxVjNrdm9XQzRueU43Q091WTdYMHhI?=
 =?utf-8?B?VTcxTTJTaEo0UHdkbk9TRUxJLzJ2OSs1ZlQxYk4yOW0xaStmaEdEdXlSSGNo?=
 =?utf-8?B?d21tWE1UcnZpVHFLVGpxOS92YWNZU1c3ZDVORVQzcVdzZnNBQmRDUlorQXo1?=
 =?utf-8?B?aElYZmttYWlzeTVHSWFWRGc3cU8zMDV1bmQ3T1NGN2JHZDBCeEdrVVc5d2xC?=
 =?utf-8?B?anZnU05TNW1Vb1daeGhNWTA3SHY2STZ4R3Z5UWs4Z1dLMXVESFZiNTlTUmUw?=
 =?utf-8?B?T3RJWC9BR21wN3NucE9xbFF5VzdUT1FLR3dsTTAyb2ZqUVZqOWh0QzlBOVdw?=
 =?utf-8?B?Ri9UdHU4NmcyOWRQZEtJK1EyUU56MlpGSWpyWGx2dGtUK1U4TGhIbzRGYWVG?=
 =?utf-8?B?cUVRTng0ZmEzZlUwTitoRG5VOWRrQnp5NWxIMmFWQXl0blBxMEYzREpzajho?=
 =?utf-8?B?bjlVQ3E4VEdnSHVnV1B2RDc5c3JiVTlaRFdTN01KY2RLQ01qRHVPRGd6eW54?=
 =?utf-8?B?LzRKU0tLZGtZNmVoSkQwWWpxaEJVbGY0bG4wNXM4UGlKN01pWGs4TGdSTmZ2?=
 =?utf-8?B?V0ZsQVhUdzkzNU0yd25oU2JMTXhnUXY5eWhlQjRnN2JCY0lKZXVvSnc1bURv?=
 =?utf-8?B?ZGNRMmtjQUROa2NpWDQwbWZoNzEzWVE5QnRtaEUxM1NXdWpqV0dlM0VNSlhP?=
 =?utf-8?B?RFVVWG5wem9BaGZteTBaRW1NZ3AwbUU0MTJEVXRCeXQ5bmliM2hvQlNIeXZj?=
 =?utf-8?B?RHg0cWlmeEtGQU1jOEFweHBYOHJPMG0rNnJ6Umd6Q3RMYVFnQ3dnSTRYN1hs?=
 =?utf-8?B?dXlrZVdJbTdnQlMrYkxIT1NBaldGdm5hd1d6RXBodENyREhWVWVYU3BKVzlk?=
 =?utf-8?B?SnI4VE9SdFNJQldsY0YxZUM1YkpieC9aVy8yQ2ZhdXFoOHZqNWJYQ1BFR29a?=
 =?utf-8?B?T2ZQNWFjQTVlOUtpSFZXcURLYkRzZmFQYklCMFBnMnBWVEJqcnpySXprME9N?=
 =?utf-8?B?aEo3WmQwNFhJalZ2QkdqMEZwZ3o1djFxOFZRaUd0UTlmMmVGL2xXNjVVY1dy?=
 =?utf-8?B?V2ZJeEV3K3BOTFVEeEtrNm9US3FCSFZWTUVaVS9OMEd3M2wxZGxvY1A0eUhr?=
 =?utf-8?B?Mnl5Z1A1Tk5lbzFuaDQ3b2pLdVhZMzRRYzRSd2dYK1doU3hNY1Izbk93aE8r?=
 =?utf-8?B?NzFmTXUyeTdVdyt5dzRCNHJLdlBlQlp2Vy96c0RqdjB0aXcvR2taV2d1cHZI?=
 =?utf-8?B?TnhMQytSa2Y4VnppMk01REkwREFnMHFvUWpFSEFtcnZFQk5FaHRtNDNtNjE4?=
 =?utf-8?B?QXVXVlZmVkJCT0ZaMmhFUm9RN0tRWlNpa2lidEYvOWhEeS9GbDFTZWFqQlpV?=
 =?utf-8?B?NkZqMkcxODVCb0xGN3VlRWFJWGVMcm5OdGJmMUsreEY4YWRhNmJRRGxVdFVZ?=
 =?utf-8?B?elVLUDZWaThpcmVBdmhqOG5GcW8vbjB3cXFTV0c2ZXBMSjZYSndzbjRGZnlQ?=
 =?utf-8?B?UXZybVBwRjhNNnN5VjFydFhadGFIbHFHckIzK1RaYUhTUnR4SnoxemxQUzJV?=
 =?utf-8?B?MkVTaXZhUzZxN1prZCtmYXpNQ0tjQU93RnRwNmRQeWpLZWtRUFRTNnI5TFBn?=
 =?utf-8?B?QlFnYmt5bFcvUWZCZHVVK3hyWEdpd2Y0R3o1aWhxSXJnanUrZmtoc2dCMHpa?=
 =?utf-8?B?K0hzem1PdjVWb2VnM1RXK0NMTWt4ZUhSODg4WkFBUktEZ3VjeWY2YXFZUTNU?=
 =?utf-8?B?VGlnM3N1aVZxRlJFT0RWQUEyZUliNmpYbjAwc2twLzkwWTRRTWorUTlrOWJV?=
 =?utf-8?B?QUdNOGJxODZJVDRDMTJBeEpUN0lQeURQWDBGQmVCRFJmMFRpT21Rb2VtWWov?=
 =?utf-8?B?L0JJN2JRendoWkc5bVpsT01lcEdIdGg0NytodDZmeURMYW0xbWhlQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 917f0aa8-71a3-41ce-9d31-08da26c1c5cd
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 13:44:51.6566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: svuwPtnbx5cdEKtMvxtXU0JktfqNf/fKECt10AjYQm2/UZeL+YMoYlPGA/Olj72/YFywrG0DtFxypHMxPAeODA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8951

On 25.04.2022 15:43, Julien Grall wrote:
> On 25/04/2022 14:37, Jan Beulich wrote:
>> On 25.04.2022 15:34, Julien Grall wrote:
>>> On 25/04/2022 14:28, David Vrabel wrote:
>>>> --- a/xen/common/page_alloc.c
>>>> +++ b/xen/common/page_alloc.c
>>>> @@ -162,6 +162,13 @@
>>>>    static char __initdata opt_badpage[100] = "";
>>>>    string_param("badpage", opt_badpage);
>>>>    
>>>> +/*
>>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>>
>>> The comment needs to be updated to reflect the fact that at least Arm
>>> doesn't use IPI to flush TLBs.
>>
>> I thought the use of "may" was satisfying your earlier request?
> 
> Maybe I read wrongly this comment... To me, anything after 'which' is 
> optional (it is a non-defining clause) and describe how the TLB flushes 
> works. So the 'may' here is referring to the possibility to use flush TLB.

Oh, so you'd like to have a 2nd "may" inserted later in the sentence.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:46:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:46:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313011.530465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz2j-0001Dn-0f; Mon, 25 Apr 2022 13:46:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313011.530465; Mon, 25 Apr 2022 13:46:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz2i-0001De-Tu; Mon, 25 Apr 2022 13:46:20 +0000
Received: by outflank-mailman (input) for mailman id 313011;
 Mon, 25 Apr 2022 13:46:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1niz2h-0001DT-Pv
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:46:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niz2d-0004KK-S6; Mon, 25 Apr 2022 13:46:15 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.15.211]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1niz2d-0008Gm-Kw; Mon, 25 Apr 2022 13:46:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=OT3lX2wxKjyP1ikRxs70CbS7owqzKDFpdU0NAcLlsDw=; b=LxF659F5DHDox1VDuaW9NCLe3L
	HR6Cbnu29I8etUWf+V43tayU3D5n0oUChyyrmjEPwMMEWkowLbr0SKqdYEKRNCe3VdYyppqvvqZpB
	o1fhKkUt34usZG18p++ieppKmd3GlkFHkpVIc4dufrLzHs9nwaJ7YwX7hLMokLyH3/3w=;
Message-ID: <bd25ea0e-e22a-587a-58ad-f17d46fa120a@xen.org>
Date: Mon, 25 Apr 2022 14:46:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, David Vrabel <dvrabel@cantab.net>,
 xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
 <afb15744-5e80-6c40-069e-6fc076e40e3d@suse.com>
 <74500983-79f8-07a9-7dcf-54a7bc162061@xen.org>
 <efcf913a-0549-3d5b-08c1-82e3d7a26349@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <efcf913a-0549-3d5b-08c1-82e3d7a26349@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 25/04/2022 14:44, Jan Beulich wrote:
> On 25.04.2022 15:43, Julien Grall wrote:
>> On 25/04/2022 14:37, Jan Beulich wrote:
>>> On 25.04.2022 15:34, Julien Grall wrote:
>>>> On 25/04/2022 14:28, David Vrabel wrote:
>>>>> --- a/xen/common/page_alloc.c
>>>>> +++ b/xen/common/page_alloc.c
>>>>> @@ -162,6 +162,13 @@
>>>>>     static char __initdata opt_badpage[100] = "";
>>>>>     string_param("badpage", opt_badpage);
>>>>>     
>>>>> +/*
>>>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>>>
>>>> The comment needs to be updated to reflect the fact that at least Arm
>>>> doesn't use IPI to flush TLBs.
>>>
>>> I thought the use of "may" was satisfying your earlier request?
>>
>> Maybe I read wrongly this comment... To me, anything after 'which' is
>> optional (it is a non-defining clause) and describe how the TLB flushes
>> works. So the 'may' here is referring to the possibility to use flush TLB.
> 
> Oh, so you'd like to have a 2nd "may" inserted later in the sentence.

Yes. The first 'may' was already there and I suggested to add a second 
'may' in v3. But it didn't seem to have been added in both the commit 
message and here.

Cheers,


-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 13:51:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 13:51:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313020.530476 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz81-0002h8-KT; Mon, 25 Apr 2022 13:51:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313020.530476; Mon, 25 Apr 2022 13:51:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niz81-0002h1-HN; Mon, 25 Apr 2022 13:51:49 +0000
Received: by outflank-mailman (input) for mailman id 313020;
 Mon, 25 Apr 2022 13:51:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1niz80-0002f0-6W
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 13:51:48 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d78c31e0-c49e-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 15:51:45 +0200 (CEST)
Received: from mail-bn8nam11lp2174.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.174])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 09:51:42 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by PH0PR03MB6708.namprd03.prod.outlook.com (2603:10b6:510:113::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Mon, 25 Apr
 2022 13:51:41 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 13:51:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d78c31e0-c49e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650894705;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=swq/NFteAEPZCqMmD+DtSbe1Hkzh3tvf2p83sT0lqsc=;
  b=Pm33D1vEE4T+R1c3MPeAHcOyu5bEjx0v7KRpE5M7NyYL/DJUvz1fx7wZ
   ooFgmFTNouGj9gQyH/gb3pSFmEq9Hg56qM9ATzoR/baaUVXAAAh3gBcJl
   ryvRY6txEhBA4Faiw7mgC2Y/5DxGl5g49JwLnME7e8+H0p33o/mVhabIM
   0=;
X-IronPort-RemoteIP: 104.47.58.174
X-IronPort-MID: 69862307
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Prdj5qDahT6/3hVW/y7iw5YqxClBgxIJ4kV8jS/XYbTApDIqhDMPm
 jFNXD+Eb/bcYWbxKoglbNmw/E0AupODyIM2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj39Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhj0
 9Jj5LiraD4XBZ/Hnd4BWgdiLhlhaPguFL/veRBTsOS15mifKj7G5aUrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mcH80m5vcBtNs0rtpJEvvEI
 dIQdBJkbQjaYg0JMVASYH47tLn51ielKGUHwL6TjZU67C/d8Rxq6qSuO8HzUOyNH8EWgX/N8
 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAa60iDXtT7GRqirxasvBEGXMFLO/Yn8wzLwa3Rizt1HUABRz9FLdYg5Mk/QGVz0
 kfTxoy1QztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC
 RjRxMTir93/VfI26pg=
IronPort-HdrOrdr: A9a23:OlDAOKP/7gokycBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5
 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa
 Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd
 WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19
 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d
 78bG8=
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="69862307"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T3RJsEHBESslkmubEFr1N5L5hb7bFGFk1M8sOTlHr9L4RHfIvWSNHJhRnNYU/ILZ365xygV126whpj+9K0ZCldlRqPpLI8DDE588wrM8k+LxwhJmYK4nW1di4ta5fXeo5Ln8rPfdQvLsyhMpE6sMpelFbd8JbRcHqjKuAwhacBAQm+IAm/HoQjuO+xggK+mACKqipJGuH2vBjkVl5ElTRso7rSSENlLGFtLU8jvgVrwvpLo1PS62NcIGu071UOpDDzWcEeLBa/ePv2IUiEUemiUU8iA+XmjMSrzVl/pCRuFPygeiEKJNYppHs2aOc6uus0so5jgA1eszKvW1EtC3Qg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=du4FYpbAWINry80qew7JSN2mE9addizpxnnZcNhWFmM=;
 b=eQC0mJvW2dM9LKhLWsP059KUHkCTfYSiPt449FQYxLeWLicWjnd5CHo4N7/PEN/B67k8Cah5fd5gLdBljd4rGVQGwNQ8rU2E5rgafsQ4vMUVQpgNuYhH0vOsRkrSmez0nhK7a7yRLHv1TDjSUsTOTqQ/F0pQY6MvJKG2xC7AJxMqhwlR4MAGyhHfJM/DVqOnzrwJpHmKrUv62PBded7Co8a63xFenZiKHlkG/RKtRNOuLMttOHImu1kA1ShbuIDwZdIXb/aIwcFRszOXL4F4xrgv+XhyUuhbAAnqMbKSrxEjsUW6N9sM2Mh+LZmbZQnTqCVYb85QM65h9Z5NbUscvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=du4FYpbAWINry80qew7JSN2mE9addizpxnnZcNhWFmM=;
 b=qhP+MmhXN6ELsSD80SIi3/i9jlqRHtKSRXF+49RVHGZfqiDtokLmgZcqZxY6A9VJMw6wpzO4zoINZewIZHi+Vgrk16xRvhvyet7ssIWzk83Ki1/mqpocNy9Ij7kFYlaK+pl6gJTwIUUiut69m8dS0ZG41hqWYlRQe1D2rK9M02Q=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 15:51:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Message-ID: <YmanaIcSMviCmuf4@Air-de-Roger>
References: <368e2d54-09f2-2081-349e-571bfeab13af@suse.com>
 <YmabFt952DO29pIA@Air-de-Roger>
 <039010e6-523f-851d-a432-d7f1a2fe5eca@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <039010e6-523f-851d-a432-d7f1a2fe5eca@suse.com>
X-ClientProxiedBy: LO2P265CA0291.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a5::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 37170875-bf2a-4a83-de91-08da26c2b9a5
X-MS-TrafficTypeDiagnostic: PH0PR03MB6708:EE_
X-Microsoft-Antispam-PRVS:
	<PH0PR03MB6708D1FB69DC9265ABA3F81E8FF89@PH0PR03MB6708.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+Rl5ntBd1uPj4DyAsNjQmaN0xR4P0koLZL37/vlix+fcDaF0QPMZxTmtoO1f17iCYucOVfgKxp8VVlZUg+Kkx4F0bXbBL+UMuKTnQcGEagzk1Qp4RyV2LGCdoCKTtOV9Or4rQHa2IyVCgP1NK22NJ0j6SSZFjFDYo9kb3i9rEq0f9gLfea6TLC3iZDgY6uioxFF9tV5CEAtrbF2ti5VGU59di+j5J7wja9ufEjhIJODaHZC3rYvwWqJmQRA9Wy0sIeP9DcY/jdhklC7csIbuZYrl4wF4trajXLNIZM0S0uQ6xixr1WylX5Dp7XcVvPiG652VAPdw3WVJXGzMuCHtBRrvECH8tHkLRIC4TUlKGzcbs4kqI2p85hBGnHWqJBD97lTYjH9lutOLycGfclGhqQhgN5qLvrS6ryiWev4HtqXDM6/O4tbqWVPxLr8BVqWYN9Fp0XBLnkeKNcxeO3Y7pz/11mAZRz5jhX+K7C2z+dclHXGot1jYM1D8kTxFScp9ztqlrRlUPVtowIn4wsOe0FoND2mDuCf1IkClpfE8i7f2qZCkC0J+6lXPbE+SHrs+UlAnQSrnX4992shVzqVQ4tzBr+vksoNqvAzN2eZW1bKC38TTS2wPpQH1N5pn0VxVDe16AU5ZyxIWh/zvd+WeHQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(53546011)(4326008)(83380400001)(8936002)(66556008)(66476007)(5660300002)(316002)(8676002)(2906002)(85182001)(66946007)(33716001)(86362001)(82960400001)(38100700002)(6486002)(6666004)(508600001)(54906003)(26005)(6512007)(9686003)(6916009)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZFNYT2paWTF2NFdQWnJMcThzTUpQQzJaQnFjYmxCZ2E3Uk01M3VMR1p2ZHRZ?=
 =?utf-8?B?amFpei9HN1EvaW5vSG9QbGIraVUxNU9Tc2IrQ3B3RXlLckRQalJ3eWg0WlJP?=
 =?utf-8?B?ZS9zMTFSaDErVGdPTm1UYzdxT2JjdGRjRUdpaE9oNGxES0xaMWdPTUgrM0FF?=
 =?utf-8?B?WW51RjdrQkxuQkRqNDliNndidWhiTGk5N1ZYVW9xeXlaMnpaQTlUY1o2NGZ3?=
 =?utf-8?B?TzNaTWwxVHJiVm01OVhXK1NTbldrRWZ1anREdlR1N0RiNzI4MDh6MXBkZkhv?=
 =?utf-8?B?TUhaVWkzcjE3Nkk1aWh4Y0lDWUNQK3kyYzlRUjFGd3JKTmU4Ylh6aEZ4cG93?=
 =?utf-8?B?VEtxSVVTeDVUYUIycVE1VlNhei9TWDJLbk1PamtQWE5ZbldxNk1JYVdoZlZS?=
 =?utf-8?B?MGIrUko4SzB6YjFmOWU4Y3d6dXUxb3krWWE1dWpPdm9CZmE2NnZlY0JKTUpY?=
 =?utf-8?B?WGswWXJXeS85ZzlBaHJMblhUVDYxL082SEJ3ek5oazFqU3JQdU5xVXNIVnAv?=
 =?utf-8?B?WDhEL3lKT2NaRm5CQVhHRWlTeWxoMlgyZkdzYVR4dm16MnR0REVnakMrVWJn?=
 =?utf-8?B?NmhBTWZwak42QXN0U1lsNm9vQVhSVHk1MGJsSUp5ZEJ2K0QwQTByU1g4S3V4?=
 =?utf-8?B?SnEzMWdJYVpoR2l5dTl2QzlTQXM4VnFMUTlWV3RGNU5jRzBFbWlFalNLTHJ1?=
 =?utf-8?B?b2picnN0cjVGdGJBL1JRNlB5SDgrUFJqSDRiN1JxWFlielkxd0tyeUFPdzdO?=
 =?utf-8?B?aml0WE84V3Q4M3JqYXpZVHFFbjY3TDAyeC8wYzdoQit5U2haRzlqT0ZWUEww?=
 =?utf-8?B?VWdMSFAxR25mYjlEd3djQ1lxWUVhSFJBOEMvYnN6RXZqMlRWRG0wc0tkWnZ5?=
 =?utf-8?B?azZyQUl3bGpYS0Z3N0NmdDR0WWJkcG9mVGI4bituOUxXZTZ3QUE0cmFCKzh0?=
 =?utf-8?B?THVyUmR0LzV4VmxBTHdXQzFBMTl6RFVJMjFqTlJubU5nWkhyaTFqMW5GUmFs?=
 =?utf-8?B?d093NXpGUlRiNnArU055NmdubDBUZUJiNnhRdXZPTDhwenp4UkNsT1phTmdq?=
 =?utf-8?B?T0xTOHFRSWI0aG96Z2JDWUdmYWNoenRNSTI2djNKY0Zzd0NCOUxmMHI4eDJo?=
 =?utf-8?B?aG5NSWtING0xY0tDeFkvZ0hCa3UyZzFzVXJQamJSNExWZUhGMWsweks3dHRu?=
 =?utf-8?B?N1JyQ05zVlZ4QVFmSVB3RHdUOHBTdkhyRjFKVk5lWXZiMkpjNlZVeitMeXA0?=
 =?utf-8?B?b0kvbDRZTE02N1cya2xGWjhISzV0OS9UYUE5SHNJbVBDMTRwMU9ETTQ4YjFR?=
 =?utf-8?B?N2c4eWgyN0FHWXNuK25kQkVpd2FmckRwZktiWTIxWUZzWXdmRWdQV2xNazhG?=
 =?utf-8?B?aUJIN3ZsUzhabWQ0N0tLTXVVbDZ1ajhHS3JFWi9YcmNQSDBuVTBNOTVFY0U2?=
 =?utf-8?B?ODdyRmZidWFYYkMxSUJIUW9FOTRQckErcWVhN0ZqWEhKUnRVbHRCcElTK0pU?=
 =?utf-8?B?SlpuZUhPUlZtdWZkNW81bWE5ZUdnbG1Mck83N0FST2RWM3hTUVdhNGc5TWx0?=
 =?utf-8?B?R296eDJha281VmlOSVNJdXZ0ai9WdXAvU1NtaGszdElmdlVtdzF4eGQveUo2?=
 =?utf-8?B?WXd3bzJHbnZWZkVqUzdBejlGY2lSVGJFTExPVDlUMVlQMjlpb3YvOGNFNVdT?=
 =?utf-8?B?Um1uT2liVzErbDgvNmsvRTYwbkJHN3hxWHRmSTZwVjN5TE41UG1YNlVjUTdK?=
 =?utf-8?B?UTM0ZlZ5b0FDc1JLY1BoZThkYWY4Q0QzSlRRdEo5NHp3ODl5SWp6bVJ4VGph?=
 =?utf-8?B?WVN2WU5XVVl1ZTBaQ1JjbnRVNnRDYkJnek53R254d2pEcGJkUGJZczBMaExa?=
 =?utf-8?B?ZVdMdkdGUmx5UUZibS9YS0hXV2VDejBPWnc5MlhEVWJUVktvWjJmT0I4alpG?=
 =?utf-8?B?b1E3MlBzWXNmekxQTTA4T3AzczlqVlNUZVhGOWZ2ZDlSU3BYOFQ1aittKzYx?=
 =?utf-8?B?cDFtWHNDSDJjR2J5Q1Z2cWE2YU9jc0sxQTBLWk5wd2NINTJwejFOWlo5OXhi?=
 =?utf-8?B?cG1ubVQ0cEl0eERiVFdHYU51N040QTZ6YkNVNzBWNzNFU3hSeEpFTGNCRVhF?=
 =?utf-8?B?SGZrUVU4WURLOTY1M0o1cEp4T1pjMUN1R1R3b09ZWXAvRW1VK1lUUUpQUmRp?=
 =?utf-8?B?VUF0ZTVjVkpva2NMdnNJUzRDOWdtQmRLNlhCUEliSU00VjhSMFBIbml6Z2FG?=
 =?utf-8?B?L3gyNzQ4VzVaUmUzTEhpcWNqOVNwOVJ6RUg3NkZUQlVKRnpuRUY5aVRtRzM3?=
 =?utf-8?B?TTkvbFdiYmg1ZUxQS0JJUkFGZ1VMMnNmL250U1NBQnE2RHp1bEpZR1QxYVRq?=
 =?utf-8?Q?wiF5pdyrjmv0+8DE=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37170875-bf2a-4a83-de91-08da26c2b9a5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 13:51:40.9025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z3e2n65RWswRYc5QDcKmK93hJ8jq9hPLWF1nfyro4hNqYUah/c/gsls/vnQ5JD2YUPbhf0DXDPQ5JLaJO/+x6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6708

On Mon, Apr 25, 2022 at 03:19:46PM +0200, Jan Beulich wrote:
> On 25.04.2022 14:59, Roger Pau Monné wrote:
> > On Mon, Apr 25, 2022 at 10:49:34AM +0200, Jan Beulich wrote:
> >>  char *libxl_domid_to_name(libxl_ctx *ctx, uint32_t domid)
> >> --- a/xen/arch/x86/dom0_build.c
> >> +++ b/xen/arch/x86/dom0_build.c
> >> @@ -317,9 +317,12 @@ unsigned long __init dom0_paging_pages(c
> >>      /* Copied from: libxl_get_required_shadow_memory() */
> > 
> > Could you also update the comment, maybe better would be:
> > 
> > /* Keep in sync with libxl__get_required_paging_memory(). */
> 
> Oh, of course.
> 
> >>      unsigned long memkb = nr_pages * (PAGE_SIZE / 1024);
> >>  
> >> -    memkb = 4 * (256 * d->max_vcpus + 2 * (memkb / 1024));
> >> +    memkb = 4 * (256 * d->max_vcpus +
> >> +                 (paging_mode_enabled(d) +
> >> +                  (opt_dom0_shadow || opt_pv_l1tf_hwdom)) *
> > 
> > opt_pv_l1tf_hwdom is only relevant for PV guests, so maybe it would be
> > best to use:
> > 
> > paging_mode_enabled(d) ? 1 + opt_dom0_shadow
> >                        : 0 + (opt_dom0_shadow || opt_pv_l1tf_hwdom)
> > 
> > Or something similar.
> 
> Originally I was thinking that people simply shouldn't use the option
> when Dom0 isn't PV. But meanwhile I've figured that late-hwdom may be
> PV even if domain 0 is PVH. So yes.
> 
> >  Maybe placing this inside the sum will make the
> > expression too complex, so we could use a separate is_shadow boolean
> > to signal whether the domain will use shadow pagetables?
> 
> I think
> 
>     memkb = 4 * (256 * d->max_vcpus +
>                  (is_pv_domain(d) ? opt_dom0_shadow || opt_pv_l1tf_hwdom
>                                   : 1 + opt_dom0_shadow) *
>                  (memkb / 1024));
> 
> is still okay-ish. Note that I've switched to is_pv_domain() to be
> independent of the point in time when shadow mode would be enabled
> for a PV Dom0.

Thanks, LGTM.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 14:12:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 14:12:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313030.530490 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nizRT-0005gH-Gv; Mon, 25 Apr 2022 14:11:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313030.530490; Mon, 25 Apr 2022 14:11:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nizRT-0005gA-Ck; Mon, 25 Apr 2022 14:11:55 +0000
Received: by outflank-mailman (input) for mailman id 313030;
 Mon, 25 Apr 2022 14:11:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nizRS-0005g1-1q
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 14:11:54 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a6672530-c4a1-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 16:11:52 +0200 (CEST)
Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 10:11:48 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BYAPR03MB4597.namprd03.prod.outlook.com (2603:10b6:a03:12c::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Mon, 25 Apr
 2022 14:11:44 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 14:11:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6672530-c4a1-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650895912;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=xkmkcNp5vjY0kJMx0puCoSnGEar2K03bnvM6ZKhH3mw=;
  b=aEjvFuppRpXPsoLW1WLOpQGsbH8YMUu1PZPsgwremkmF+N0YnA2WYu6i
   8kqSFjfmZCfj7jQrCIpzyEPL62hzzovE5mzaJ+/N4aIruYPcYT1tv/qbw
   6q+P/z17jkSYdXVQxknN0Tw8HjjtHVJO4IIC+wQZAgj0T2SsaP8qVsksm
   s=;
X-IronPort-RemoteIP: 104.47.57.171
X-IronPort-MID: 69262940
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:olxYDapBOO8i8QDDGi8PB5TWGQleBmKQZBIvgKrLsJaIsI4StFCzt
 garIBmFbvncYGKgKYh0PI+x8BwFv8XWyt8xSlZorX8yQSkQ+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 46q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBAaHGkcc+fBBiPwpENI9G04D4DXflvpnGp6HGWyOEL/RGKmgTZNRd1sMpRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFg3Fp2Zkm8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrL9PBpuTmPlGSd1pCyF9jxQoOpGflQxEihj
 2LN0VX7LVIjYYn3JT2ttyjEavX0tT/yXYsJUrm18PF7jVm7x2oPBRlQXly+ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c8VUO/037keK0KW8ywSWHG8fVRZadccr8sQxQFQC1
 FWEgtfoDjxHq6CORDSW8bL8hTGvPSkYK0cSaClCShEKi/H4u506hB/LStdlEYa2g8fzFDW2x
 CqFxAAijrAaluYX1KG2+1/WjjbqrZ/MJiY85x7eX2asxgl4eIKoaYGu5VXBq/1HKe6xVkGAp
 nMNn8GU8cgEDI2BmSKARukABvei4PPtDdHHqVtmHp1k+zHz/XemJNlU+Gsnex4vNdsYczj0Z
 kOVoRlW+JJYIHqta+lwfp61DMMpi6PnELwJS8zpUzaHWbApHCfvwc2kTRT4M7zF+KT0rZwCB
 A==
IronPort-HdrOrdr: A9a23:jrAE/62lgr75uUerC98tswqjBSByeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp
 uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6
 Dsm/av6gDQMEg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iosKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6N2H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCulqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv60vouqhNDqWs3N
 60Q5iApIs+MPP+UpgNdNvpYfHHfVAlEii8Rl57HzzcZdI6EkOIjaLLy5MIw8zvUKA07fIJ6e
 b8uRVjxCQPR34=
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="69262940"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cYL2yx1FYPRgfgMRSWubP/kSlzVUfq+rrVk98rhJtCBiS6vcMD44rHIDwaj357vbGPlbz9qmNo/62P4b+W9kbCGvVvvy/vHOA3ObvqSFpYOIqj5Q29b03CIIVujCRhIfQTLF+wnlELUZATkiM4xe3BmxpXaD7o9PbXkHvcZ/e1Rt4oV0vwFDLV9iiuIbYP1S3vNGz8xF6UGM/qUuArgp3xGdqQXnVzXchzNwddhhOse7d1VmsHD2NSg4tacSQaV72uVy6je/RjahbwKCvvhM5Ol+ObuiuagGWlNtlaLPRNUQwkpdmDT4ph4wHxK+774aOl6cncCSEIsXjn8Q7Xa4aw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h4ikID8eT+vgIa8f/6lN1MNLyj10nnkMkVbOfXLaKxg=;
 b=mDNO5Ud5JacsR6Mrme8+UFs0pknEpS68dHloJq3k+zcSvkZzZzGp6I+DpLUeXPidMATF5osH5u5xJWWoF+ow2SOgIuOVcJktJRTjnWX3CBm3YQWQrrOJcMJJCgzgPPc3tKC+KhLPd6qC6dbDQNhn6MoFWO2ssUnsk9/VCgbg1tuNXg6CMbXH3pjRYQRH9QZUzu27sWseoesF5orZUOUrMfJ6aJrDkjbyb8wZw9vqfqjsyfPXYO55+OviSsaJ2Xzpkez65vSaDfodzqzKnP5QYuSlOUJ5PXlDvaz5WZtdttsxGSXHxAvI6jxX65AnO62GbNrNpXADjqN1fUaX2cJFdg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h4ikID8eT+vgIa8f/6lN1MNLyj10nnkMkVbOfXLaKxg=;
 b=hzXHcX1Zw9SMqUNyBD+rWJg0egFSynnYPpA4zQxfGDzEkbkDJlN9YbozRtMCIx8/NDmu8wDDM5ibhM0VAo/A0vFbw529sgqm3wIXxrdLJgnopRHl9g4fXgGjfCZp4raXVwNFqke5BVdXX5bMfu4txIiycoNi5R24ZCy1o+LEHQE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 16:11:40 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
Message-ID: <YmasHAT0YkeJVMbv@Air-de-Roger>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
X-ClientProxiedBy: LO4P123CA0026.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:151::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fda3ff71-c160-4bd3-6540-08da26c5871f
X-MS-TrafficTypeDiagnostic: BYAPR03MB4597:EE_
X-Microsoft-Antispam-PRVS:
	<BYAPR03MB459749787E88F8FC44CE13788FF89@BYAPR03MB4597.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0YtwZLAnZfi5XYxErXqX+wT04uuJl4cOxgJd/x41dQF7kGsKVwW9uf+4Ewo4Tk94fMwRboNRudB8R6wYlqnBBBMizca5lw9NAUvElZOzv+4wvwwwO23EPd/uYMmfiEtTWKB9D4J5h5XXsS5RRMS261mDDpmwyx41CYua62RJc8wM21BnvN43Y+hlj3mzVfnEVSIAkBkoInXx4U/cMuUMLeSS31ij1jjpVDSd5a22Tn01x6JkQk4JZBYmp+xoA+M9Ci+Qr5D+G1FOKW3MJ/Acws7YpOu7vXD1GLoHy120rBAVQdMEic9jGzPecxDHIeQBMd0y5WXIsOaGD68Lca+aKuL58DQB9C2DG4ZvxJnAsr84OGkjTzwQ4sIbLF6t3mCIHQHADLN9RT3p9cnTESdqgwJwdg1f5LzWYU4bVhMN9SZW5s4dIN2b4yT3y6Gey9cRib0ttAKH7F3AsE06B6Fao0uTHPjUdmrDglFMxf7HdModDJMDGxUtR0kakXyezNQjln5e77Gpq7iuBxSPqjjKwQgQ6jHbPdRH+gE/QKPHHkdTUuXPtv9oi5z78XcXesEbgbliRcT6D2vMiBBBXW+NbirfXbA4cTVCch3BZaUQYXOxjIZMIY27RX92r8pwuQAcj94mCVWjSFBKaH6IwcnMUg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(33716001)(186003)(6486002)(316002)(66946007)(54906003)(85182001)(6916009)(4326008)(83380400001)(66476007)(8676002)(66556008)(8936002)(508600001)(6506007)(7416002)(86362001)(5660300002)(82960400001)(38100700002)(9686003)(6512007)(2906002)(26005)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OUgrdndEOFE4TUdIRkREY2k2K2lEMVFiWEFkK2I3RitlYTBLa3M3K1Bvck9L?=
 =?utf-8?B?eTNtemg5ZFkyRjFjSC9LTGQyTk8rcm5vMXpncFZkTGk0cFZVRWtqMEthcHhF?=
 =?utf-8?B?UlkvUUoxVXJVMDBtMXJWencxKy9ScXN2QmJSaVBjeUtzU2JpOW9ZVm02V05K?=
 =?utf-8?B?RGVZSVZSQlUzRUFST0NUZExBT0RhUmgvWDlLK285Q0NSeFRjbzlrN1h6bmd5?=
 =?utf-8?B?UnVOY3pHaEl4bVNCcnpvYVBxTVNGUEdRRGo2NHJiMEpqRGtRNmFtc2kvMmVl?=
 =?utf-8?B?Tjd3eUFHNmJHMkg2Syt5WjlHOHJCL290OGRQUmdWVXJCNW5nR0E3NndEd1VL?=
 =?utf-8?B?WnBNRnU0OWlQeG50M1lmUnZaS21jUnFkSDdrUDdPTnU0WjhaemRBeFRrZ0lG?=
 =?utf-8?B?Z0pJSnZtdjRrNXBrbERtV1Q3ak5lTDYwRWtyZ2tUOTU4dG5nQzVXZkF4OThm?=
 =?utf-8?B?Z05WeFVNTGxycm0xRGd5MC9MTk82TUFLV2hMWUh0WThTT3BjMkxOMDk5L0Fz?=
 =?utf-8?B?bnhZOEpsdHVDWG1lbFJkL3MybG82UUI1b002aEhYWGdYMHFsYXhJb05QaFhm?=
 =?utf-8?B?ZGpDdGxyL2JnajE2TSszZzRlNDY4TkxydjRuVXU5S1JUcTVjR2l4V0ZNNUpx?=
 =?utf-8?B?YlMvdlNMbDNRT2RqZGxxWXVwUXZ0c2p1eU5VTWx6cG9XaFh0aFhIbUhpMFlm?=
 =?utf-8?B?QjNLZ2Q5YUdBeVFTRDhMNkNKSEg2cVZCblJpU1JEZThqWHQ2ZlgrbVRYd1lL?=
 =?utf-8?B?SE02UG1mOXNVSlFTWWtzQXBXNWRsZWJoNWZmV2VYRnB6NEQ4a2M3cmhKcVg1?=
 =?utf-8?B?NzdZb2VFd2l1ZkJjRXFvNXYwOHljenpEcnpSRi96TWk5ZitvbkJKTXFocU4z?=
 =?utf-8?B?bmlFdWpwazdhOVFCdjQyZi9WWWJibnRYVnkrOVVQbDZNcmVmYnpvZnZmTzJO?=
 =?utf-8?B?WUFTaXV3UDBpSWtPVWZ6bkh4ZVlRODhBU1JkQll6QXFHVlhDTVNHYVdod0t6?=
 =?utf-8?B?Z1JaTHJ5ZnBYMG1XU0xIeTVsdGUvcVlDT2tTRzNwT1diR1lmdHVjOGZTaGJw?=
 =?utf-8?B?RUFhMnNOdFVnVlN6VEhLcCtWTFFuQ3ROTUd0eVl4cXRWNGVxMStPZ3NxbFgx?=
 =?utf-8?B?QUx2RkYwZG41LyszZE9ySk5pQTd4RitCdDJVa2NqRWcyYnpNMlpqZDBqR3Fj?=
 =?utf-8?B?cDNDMThRMElyY3RvL2dNTzVqVU9FYW1HOHg4Qkx3aWxiM3dYZzJ2cTJGbGFx?=
 =?utf-8?B?NkRLSHBUZzZIN3RJcUhFUFFqcjNlRHVPcTZNWVlCRnROQnZ0bzFieWxEK3Zw?=
 =?utf-8?B?N0psNHNhV2o5UVdxRFdxdWYxaThQaWd3S3V2ZUxrTXFmRzN4d05RTEN1WE1E?=
 =?utf-8?B?Zm1mcmFBa2tLTXBEeE1uUWIzUlBORFhzRmNsd3hjM3lSNGgwYmlxLzFiS0VB?=
 =?utf-8?B?SVBwUmc5V0FVRHk2aGN5dTBSRUE4bjdKMzNCZ3hGYW5nV1JWZklCMVE1djZK?=
 =?utf-8?B?QUpQTmp3bnB1NWRaSlhNbHkvUGczclhCNVQ1UzRWZ1l0b2x2N3BlUDNjNkl2?=
 =?utf-8?B?akVuOHpZeHNENklDcjB5WWVzR291N0k3TjZPWEI2VFJLNkN6OE9kYUtqWGMz?=
 =?utf-8?B?NHlaWDBOeVFQcjFLUys4SmZVNjYyaVhRMnB1K3V3WVQ5MDZ1dFJrcWVzVXVO?=
 =?utf-8?B?RGlsbkdmMEpPNVV4ZldkeXFNU05tdDNkU1ZHUTVHWnJYaUJRNnI4MG82VFFa?=
 =?utf-8?B?UEY2VjByQjVnZVBLV2ZYdnVWRDVuNzVpQWpNUG9ZbVBBWHNhR3lmcldlWFIr?=
 =?utf-8?B?cFpPeERvRzk3MHJyRVFRekJLSlJMYVpnTTlmYTZNSUVpS015OUc2bERBYXI2?=
 =?utf-8?B?TDJXMWRVbGM2NXdYS3UxVlhGSmZLd1gvUHozRlJLNGM3Q2tIa3VyTWdCa3Vl?=
 =?utf-8?B?eDRqend4eW5nelExTGZlNFM0WkFjaCtsMDdpeE9kSGl0SVdDd0Q5RlJmV2di?=
 =?utf-8?B?NlFZbE5JVG8xVWhMamZveVhUUVZld3lFN1IrNmh6SENNa24xa1JJVERJWVdC?=
 =?utf-8?B?a0QzbmtCRFRRT0h4RkpVdTMrblVZM28ya2xSZ1hMUmZEWElaM2NvZTdUWE45?=
 =?utf-8?B?NzRGQjd3WXJuSEhWWDc1ZzBmeFpMRVc4ZFFNZW04VktOYUVFSDRsOW1oTDRD?=
 =?utf-8?B?UVVUaU12Y3lQWGxPSXRFMXBtTk85SnhoaVBqdHR6VU5UTEVMb2Jvb2xQQlpv?=
 =?utf-8?B?K2x2N1B0d1Bob3hKQ3cwVjU4YXhnN0lQRy8wNVM4Z0RzKzNCTEIyRkk1bVRx?=
 =?utf-8?B?S3ZFOXFIa0hyQm45NGk5b3JVTzhlajlrU2kxZG92MmlDS1FidjRzM1phVGhV?=
 =?utf-8?Q?BPWuuXzZEOsYtG1E=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fda3ff71-c160-4bd3-6540-08da26c5871f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 14:11:44.4990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: leVp8/Fga0PXNX1280qWTP8yBGjNSB33BR3wKH8+tfCW1b7VQnWDeKGbDjZ/Hx45qIEDtslMMq7HR02N+t78Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4597

On Wed, Apr 13, 2022 at 09:41:51AM -0400, Tamas K Lengyel wrote:
> Allow specify distinct parts of the fork VM to be reset. This is useful when a
> fuzzing operation involves mapping in only a handful of pages that are known
> ahead of time. Throwing these pages away just to be re-copied immediately is
> expensive, thus allowing to specify partial resets can speed things up.
> 
> Also allow resetting to be initiated from vm_event responses as an
> optiomization.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> v4: No change
> v3: Rebase on simpler approach after dropping empty_p2m feature
> v2: address review comments and add more sanity checking
> ---
>  tools/include/xenctrl.h                |  3 ++-
>  tools/libs/ctrl/xc_memshr.c            |  7 ++++++-
>  xen/arch/x86/include/asm/mem_sharing.h |  9 +++++++++
>  xen/arch/x86/mm/mem_sharing.c          | 24 +++++++++++++++++++-----
>  xen/common/vm_event.c                  | 15 +++++++++++++++
>  xen/include/public/memory.h            |  4 +++-
>  xen/include/public/vm_event.h          |  8 ++++++++
>  7 files changed, 62 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> index 95bd5eca67..1b089a2c02 100644
> --- a/tools/include/xenctrl.h
> +++ b/tools/include/xenctrl.h
> @@ -2290,7 +2290,8 @@ int xc_memshr_fork(xc_interface *xch,
>   *
>   * With VMs that have a lot of memory this call may block for a long time.
>   */
> -int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain);
> +int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain,
> +                         bool reset_state, bool reset_memory);
>  
>  /* Debug calls: return the number of pages referencing the shared frame backing
>   * the input argument. Should be one or greater.
> diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c
> index a6cfd7dccf..a0d0b894e2 100644
> --- a/tools/libs/ctrl/xc_memshr.c
> +++ b/tools/libs/ctrl/xc_memshr.c
> @@ -257,12 +257,17 @@ int xc_memshr_fork(xc_interface *xch, uint32_t pdomid, uint32_t domid,
>      return xc_memshr_memop(xch, domid, &mso);
>  }
>  
> -int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid)
> +int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid, bool reset_state,
> +                         bool reset_memory)
>  {
>      xen_mem_sharing_op_t mso;
>  
>      memset(&mso, 0, sizeof(mso));
>      mso.op = XENMEM_sharing_op_fork_reset;
> +    if ( reset_state )
> +        mso.u.fork.flags |= XENMEM_FORK_RESET_STATE;
> +    if ( reset_memory )
> +        mso.u.fork.flags |= XENMEM_FORK_RESET_MEMORY;

IMO would be clearer to init mso fields at definition.

> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
> index 84cf52636b..d26a6699fc 100644
> --- a/xen/common/vm_event.c
> +++ b/xen/common/vm_event.c
> @@ -28,6 +28,11 @@
>  #include <asm/p2m.h>
>  #include <asm/monitor.h>
>  #include <asm/vm_event.h>
> +
> +#ifdef CONFIG_MEM_SHARING
> +#include <asm/mem_sharing.h>
> +#endif
> +
>  #include <xsm/xsm.h>
>  #include <public/hvm/params.h>
>  
> @@ -394,6 +399,16 @@ static int vm_event_resume(struct domain *d, struct vm_event_domain *ved)
>              if ( rsp.reason == VM_EVENT_REASON_MEM_PAGING )
>                  p2m_mem_paging_resume(d, &rsp);
>  #endif
> +#ifdef CONFIG_MEM_SHARING
> +            if ( mem_sharing_is_fork(d) )
> +            {
> +                bool reset_state = rsp.flags & VM_EVENT_FLAG_RESET_FORK_STATE;
> +                bool reset_mem = rsp.flags & VM_EVENT_FLAG_RESET_FORK_MEMORY;
> +
> +                if ( reset_state || reset_mem )
> +                    ASSERT(!mem_sharing_fork_reset(d, reset_state, reset_mem));

Might be appropriate to destroy the domain in case fork reset fails?
ASSERT will only help in debug builds.

> +            }
> +#endif
>  
>              /*
>               * Check emulation flags in the arch-specific handler only, as it
> diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
> index a1a0f0233a..f8d26fb77d 100644
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -541,12 +541,14 @@ struct xen_mem_sharing_op {
>                  uint32_t gref;     /* IN: gref to debug         */
>              } u;
>          } debug;
> -        struct mem_sharing_op_fork {      /* OP_FORK */
> +        struct mem_sharing_op_fork {      /* OP_FORK{,_RESET} */
>              domid_t parent_domain;        /* IN: parent's domain id */
>  /* Only makes sense for short-lived forks */
>  #define XENMEM_FORK_WITH_IOMMU_ALLOWED (1u << 0)
>  /* Only makes sense for short-lived forks */
>  #define XENMEM_FORK_BLOCK_INTERRUPTS   (1u << 1)

Should you add:

/* Only for OP_FORK_RESET. */

> +#define XENMEM_FORK_RESET_STATE        (1u << 2)
> +#define XENMEM_FORK_RESET_MEMORY       (1u << 3)

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 14:13:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 14:13:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313035.530501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nizSq-0006Dx-RD; Mon, 25 Apr 2022 14:13:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313035.530501; Mon, 25 Apr 2022 14:13:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nizSq-0006Dq-O4; Mon, 25 Apr 2022 14:13:20 +0000
Received: by outflank-mailman (input) for mailman id 313035;
 Mon, 25 Apr 2022 14:13:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SHgk=VD=cantab.net=dvrabel@srs-se1.protection.inumbo.net>)
 id 1nizSq-0006Di-AW
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 14:13:20 +0000
Received: from smarthost01c.ixn.mail.zen.net.uk
 (smarthost01c.ixn.mail.zen.net.uk [212.23.1.22])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id da34e773-c4a1-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 16:13:17 +0200 (CEST)
Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk)
 by smarthost01c.ixn.mail.zen.net.uk with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <dvrabel@cantab.net>)
 id 1nizSj-0003rs-UH; Mon, 25 Apr 2022 14:13:13 +0000
Received: from apple.davidvrabel.org.uk ([82.70.146.43])
 by pear.davidvrabel.org.uk with esmtp (Exim 4.94.2)
 (envelope-from <dvrabel@cantab.net>)
 id 1nizSa-00101r-6N; Mon, 25 Apr 2022 15:13:13 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da34e773-c4a1-11ec-8fc2-03012f2f19d4
Message-ID: <54e0a438-e3ce-98d6-1b7f-ce2d69d45c7a@cantab.net>
Date: Mon, 25 Apr 2022 15:13:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-GB
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
 <afb15744-5e80-6c40-069e-6fc076e40e3d@suse.com>
 <74500983-79f8-07a9-7dcf-54a7bc162061@xen.org>
From: David Vrabel <dvrabel@cantab.net>
In-Reply-To: <74500983-79f8-07a9-7dcf-54a7bc162061@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 82.70.146.43
X-SA-Exim-Mail-From: dvrabel@cantab.net
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	pear.davidvrabel.org.uk
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,NICE_REPLY_A,
	SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no
	version=3.4.6
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000)
X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk)
X-Originating-smarthost01c-IP: [82.70.146.41]
Feedback-ID: 82.70.146.41



On 25/04/2022 14:43, Julien Grall wrote:
> Hi Jan,
> 
> On 25/04/2022 14:37, Jan Beulich wrote:
>> On 25.04.2022 15:34, Julien Grall wrote:
>>> On 25/04/2022 14:28, David Vrabel wrote:
>>>> --- a/xen/common/page_alloc.c
>>>> +++ b/xen/common/page_alloc.c
>>>> @@ -162,6 +162,13 @@
>>>>    static char __initdata opt_badpage[100] = "";
>>>>    string_param("badpage", opt_badpage);
>>>> +/*
>>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>>
>>> The comment needs to be updated to reflect the fact that at least Arm
>>> doesn't use IPI to flush TLBs.
>>
>> I thought the use of "may" was satisfying your earlier request?
> 
> Maybe I read wrongly this comment... To me, anything after 'which' is 
> optional (it is a non-defining clause) and describe how the TLB flushes 
> works. So the 'may' here is referring to the possibility to use flush TLB.

Oh dear, you're using formal grammar with a native English speaker who's 
never seen a grammar rule in any of his schooling.

I think this should be:

"Heap allocations may need TLB flushes that require IRQs..."

i.e., "that" instead of "which"

David


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 14:41:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 14:41:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313053.530512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niztu-0001ML-1v; Mon, 25 Apr 2022 14:41:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313053.530512; Mon, 25 Apr 2022 14:41:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1niztt-0001ME-TT; Mon, 25 Apr 2022 14:41:17 +0000
Received: by outflank-mailman (input) for mailman id 313053;
 Mon, 25 Apr 2022 14:41:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2itc=VD=citrix.com=prvs=107928106=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nizts-0001M8-Ic
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 14:41:16 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c14ec5c8-c4a5-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 16:41:14 +0200 (CEST)
Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Apr 2022 10:41:11 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB3226.namprd03.prod.outlook.com (2603:10b6:4:3c::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Mon, 25 Apr
 2022 14:41:09 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022
 14:41:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c14ec5c8-c4a5-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650897674;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=+YpPP5xDDrLsUxyJJhXhRZsb2f68JgBr6jvzZw3v7FQ=;
  b=RlXR+i1YY2h3XietLUCyexuUU6m/dvnksUcw0/6YUykubBn8YNSv7UYh
   10qKDoNoi9h3QnmVa5y6rgg28nFpNuliOehf1NXXSG2AIIZrS0lO1aICM
   nGhDtVdwvwLemqjQCzVuMlD7lvAsitPwxv5SnKaG7cdqBIMguJHzgbW9K
   I=;
X-IronPort-RemoteIP: 104.47.70.102
X-IronPort-MID: 69265422
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:KGBiSak2uIFiI991fC3pF2jo5gw/J0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaWTuDb6rcNGr8ftB1Ydm3ph4D78fVm4Q1TgFqrno1HyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWV7V4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYRh8lPI7Jo8YnURwELnl8EYh81IaaPi3q2SCT5xWun3rE5dxLVRlzF6tHv+F9DCdJ6
 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOVvZkBhG1YasNmRJ4yY
 +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUG+QjL+PZtuQA/yiR/36jNM8D1aOaHBsoPjkSpp
 Unk0XT2V0Ry2Nu3jGDtHmiXrvPGmCrgHoYfErKp+/pCgVuPy2hVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslgEYc8pdFas98g7l4qjb+QGCHUAfUyVMLtchsaceRzYny
 1uIlNPBHiF0vfueTnf13rWJqTK/PwAFIGlEYjULJSMe+MXqqow3ihPJT/5gHbSzg9mzHiv/q
 xiWpS03nJ0PjsoG0aqq8FSBiDWpzrDATxU85wHedmik8g90aoOja4Gyr1Pc6J5oNJ6YVFKIu
 HEOhuCU7fwCAJ+AkiCAWqMGG7TBz/SYNnvaiF1mHZgk/hys/WKuecZb5zQWDERkLMcCPyPoa
 Un7uAVN6ZsVN3yvBZKbeKq0AsUuiKLmStLsU6mMasIUO8ArMgia4CtpeEicmXj3l1Qhmr0+P
 pHddtuwCXEdCuJsyz/eq/oh7ILHDxsWnQv7La0XBTz+uVZCTBZ5kYs4DWY=
IronPort-HdrOrdr: A9a23:XaH7862OlwPAXUl+58b4nwqjBSFyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtrp
 uIEJIOdOEYb2IK6voSiTPQe7hA/DDEytHPuQ639QYRcegAUdAF0+4WMHf4LqUgLzM2f6bRWa
 Dsr/au4FGbCAQqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt
 //Q9pVfYF1P7ArhJ1GdZY8qOuMexvwqEH3QRSvyWqOLtB1B1v977jK3Z4S2MaGPLQ18bpaou
 WybLofjx95R37T
X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; 
   d="scan'208";a="69265422"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MLDnRVbsHOMbZo0AnnYidU59nosDHArmPUzCzecRev6tDckM58gpUAawFuOTZcKN2CRIppYV13PcGpJkHZ8tF7xzaJHtWvm8Qx6zTtpxWv2I4jXOVt0m98wmKeOT/014w2zuHYTTVsxwKNwSbytG8IG19sGRr3Qa0RE5WxYAWQquaGNy8YPicxx6cP5GwGY5QZSFF4tQl4w6mBYJPQsIQ9Dltg0RS2jXbBHSmI6Q/qhQgekdZIeucx4xcc5CDiF1AlihW4d97TKwYfyKVh8K1A4jYLA4XkcXZ8z/LNH38IIB65ahg2jsq2loDJsinBOPXFRQJmP1EduoJCylBsUGTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9GwjZTDD4ojp0t9nolpKDohc5+E9y4eqAXMQ7TfNhHU=;
 b=eB4wupBJXXxj41ibbgdpADTNc1iYC0iTtrpRssIM6TrhNKF12xGpqLGim1bh98ppHNFQm+CsgIVCNxrxwRct20a8Oim6tFYjqmRRdu3cRYQqm9X8xR1KSS5TW8T6cl925bTAtauvQxLW2Cdvs60r3rdHIjMAvyPas5hTk5YxMATBDzPCwKSQax6gejhJE17uV9Wix+3LoADcZdlbJ9HdAfawB6KkLOtGvQ7qzi0gmOAHgWZSPBuA5sEBbsLXoxd1kLg+9ZcT3QL0TN9G05ZnnOFjDPPA0wb0T2ihNYKFG8wiqQjv+rWYxMhnd3YJboxCnjLMHY7KL0w5iYQr9PFNzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9GwjZTDD4ojp0t9nolpKDohc5+E9y4eqAXMQ7TfNhHU=;
 b=kH0QISUV64Hfz2aFsXirtTDRDkcyGPOoziOAaoCm/QWc65tRojpTw53m6EolFR+ENVLk1n21Vc2shvVf4pplCIGhWoz/8aT/0FHsU0Yg36Aer4L7h69O/TxsDvs1cF/ltUuKPESPYVqwxzmUlZ1yFknN+FaS7ZKm5FXVBu+JVKU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 25 Apr 2022 16:41:05 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v4 2/2] x86/monitor: Add new monitor event to catch all
 vmexits
Message-ID: <YmazAdHL4LWOdDDv@Air-de-Roger>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
X-ClientProxiedBy: LO2P265CA0076.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 051fab6e-cac0-480a-b358-08da26c9a2f3
X-MS-TrafficTypeDiagnostic: DM5PR03MB3226:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB3226ECA692320731A0E8DF788FF89@DM5PR03MB3226.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DXztcDvnTXKBMC3GGELEExHga1TjfICRSRMSpAlNkQed3WaC5LgbzYZENMXGQeemhZJhwQjxK6BoYPFPub+0zFtrRJ9q3It4qbZqtgz8f6AKcRySJQXTi8yDXwqFAequ9June/8uPeTkkIYntgezL0dqjA0hIw8WGFRmFcUcd97/pHQq5qcN7e7jNBoC5Uxn8b1rGrY8FcaWP/kuMZtDCgB+PdM7zooEIcTXZ2kw6st1LPPYJhheNAnHS1CEu4EjwIs831uU+RbT1DT1v/EbiCvgUH8T/oVPqhCv7ugLIjlhF8Bzvl9/9rSpuT6AOiGcvDjVT4I9nhbWPFb3ylDwJEBIkCCHlP0b1oPlgOwRKfC/tF0mapBnupUdRmCVY+5FyDAUgZMiiED0cv62oKT3G9SkxeLgeU314tn/nBN4uerh9PQtbx3vH0dFgLLSjaLpDEMdfR59VwZhPXsRQGvlyYbrT/bXN+afLvSga8Z+kYifL2URKspRTvkH5uXWOt+NOaYVjSh6fQMgIQU8ObTxwF13lZ99lEay5SIm7mlcENQzXUze8fU6vZ6Hu05UcpMVSsBIG3NteHZ4ieHLlkqzKEoBAtjGVKEt0k/P3Aob1k1pry0zVW0ushCqDIValqRj0b6FM5DF9zyt13+Li0c+VnFQjRnkt2ZTsLj4zq4G8mkKZi6XUDbhXC4sKPoQuixGm6Lbs6N3smVfp8Uh6OEL6Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6512007)(86362001)(26005)(6666004)(7416002)(6506007)(38100700002)(82960400001)(54906003)(6916009)(316002)(8676002)(66946007)(66476007)(66556008)(4326008)(508600001)(2906002)(8936002)(9686003)(85182001)(6486002)(5660300002)(186003)(83380400001)(33716001)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aG9DaGNBOERpdUM0YWNJNVlKaDg0QTJBSzdncndzd3JSNVRZNVFyRlRmblNP?=
 =?utf-8?B?emJTYkRWUHRxMUh1MWlCNTVjL2pva3ZKUTg1T2d5NE1NUy9KMnNwWGYvOHFE?=
 =?utf-8?B?enRoMElDZ0JHVk1aeDNvMXB6UGJCVlowbGE1UFhtZXdOaVJuczhFNnl2c3FN?=
 =?utf-8?B?eTlJUGpkRktkNmVGMDJoM0hSN1ZTYnNtR0xlVnp3TkVROG55MklTem9BTXFP?=
 =?utf-8?B?Zkd4YUZoc0ZZM2dtenNEcmxrWGVGa1FmR3MwRGdnY1hybE84MEltOWkvQi95?=
 =?utf-8?B?UmhROU5RckRnQklMdTNLcnhSdDBVeTZ2Z3JYNjV6YllRQm1Bb3BjR29ScVMv?=
 =?utf-8?B?Rnk3QlBVS05KVnRuWFVGeTNvNzdCR2xOVmMxUUE3YVZIZ09JYlQ4OHA4Rnd0?=
 =?utf-8?B?Z2o1RmFqVlFZcStqWHN5WU5hYVVzNFZUUnhZMGR0MzFxMTNMY1NKZnJVMGV4?=
 =?utf-8?B?YVRBZDhUbVJUTFA0bmtVdE9zRGplU05yTTV3VjBBNjM2Vm5zQkxxeXh5enE3?=
 =?utf-8?B?OGNtaHdJRk9LdDRBVE1TdTFERERoS0c1WFdXZTg5OFRGaEVCOWI3U1BQSzZl?=
 =?utf-8?B?RXp6SEhyQ09SeFE1bkVxV1NUbzBhT3ZXSUtQSzBrbHpyb2t4ZjN3LzBEZUhO?=
 =?utf-8?B?Ris2WmVrazJvOWlXS0JnRlBleGlsOFp2ZDJJZ0ZRc0FUZzZUbVZUL2QrbjVJ?=
 =?utf-8?B?eU9jelJSelBxbC8veHh6c3VSK1pqOUM2cFVSTmVpZURTNzJyVyt3YVMvOU5m?=
 =?utf-8?B?dWtrQlN2QmpyZmtUb3dkTXh3OFJSU1R2MDgwRGdDY0s3eFJZTGhHbUtZSVlk?=
 =?utf-8?B?WW4rK0xrMEkzOGtuM0oyMGdpQWVvN055dVBSWkF2ckFwbHBoc0ZycW81azlQ?=
 =?utf-8?B?djZkSTBYNngvQXR3MWRFSGNzSnNONE1TNXZpaGpBWGorYncvdzYwYVAybzhE?=
 =?utf-8?B?ZFd1ZlR0V1FveU41OExOZXcydjFmaFBvcUU3YUczS0xicm0zb01maUZ5SFJG?=
 =?utf-8?B?d2xMcm1YNnM4ZWErckRkSWlBQVl4YVd5ZGdneVpvTFA0Y1RXN3JjU0VZVTU3?=
 =?utf-8?B?ZHgvbnBySmYzYi9SdEprdWoya3VBVzlZYW1KSFZYY2dBMkhZblVKUlhCeTF5?=
 =?utf-8?B?UnJqaGIyWlJ4U3VRUEdLYzdWenpaM3Z5cVVWVWZRUTd5Um5YNmZZSUhHd3I3?=
 =?utf-8?B?Rnl6dXNWTWRwRkFsNUNwbFZBdGt0Tlg1NHVwNTdjTklMMDZ0ZkVGelhhOEJw?=
 =?utf-8?B?NGFQRTYwM3l5L2E4WGFTejIwZWlFM01YaWsvQ2d5elhjdmZxaUxYaHhxNS9o?=
 =?utf-8?B?VG9obUE4SVFuWVJvc01lSFZ2aTBjRWR5QU1tVEJuU25GdXQxdzhKbUdsbHIz?=
 =?utf-8?B?RXFHc3FlMGZuZnRsczdqUkNGTUM1Z3dUODNFa3pTVUgxTXQvYTYzWUQray9w?=
 =?utf-8?B?RGxEMnV4aGx2aUFEL0VWMU9qWElRYjllTUZXTHNPMTJsckxkcktuUEUzK25z?=
 =?utf-8?B?U0ZGN3NmalhNbjRZSllIVWkrMENxemZVZHR6NUsyelBMa2NueUNmWVRxSjNO?=
 =?utf-8?B?QkdVZXU4aTQwRmppTjR6eXFTWEMyUTJ3emFBN3ZoRU5MeTRzSDlCMWd6Rll1?=
 =?utf-8?B?eHl5clcxTUJtR1dRMlo1Vms1VjVUcUhGd3VyRzMrT3FKdWV0VnZGMkFKRmsx?=
 =?utf-8?B?MjNzZE1wV2tCeDZqZjFRdFpOaXBnelJmc1BXQU5NQTBtQlZ1VlNJdWhGenFJ?=
 =?utf-8?B?QjZJalBRNGdrS1JyRlBvUXJQSDRLUlZrQk1LNlJTZVFlRDMyN0Z2bU5UNVU0?=
 =?utf-8?B?OS92SG1CVXhRSi9oUzhCaHhreWhGZEtTNWhuSWdNd2tlb2RtWG8ySWE4dG4z?=
 =?utf-8?B?MGJMdURYSmpBb2NDMklneE04ME5IaVV2QlFHOVluL0ZrT2hUdzNRbEkwaDZ0?=
 =?utf-8?B?MXBxQmZmWThuR3FPODU4M2hzUENBTklVaU5PeEhOdndONStGRzJtbC9rUlBG?=
 =?utf-8?B?STN1aDdBa040dk1Xem52U2dvUnpDWWtINzhlV2Eyb25Ec3g1bk9uWkpYVk10?=
 =?utf-8?B?L3hzbkVkRlgvOHVYUFhBeTV3ekpjTWd3Rng5MkhBK1pwTkdwMXpVUzlpNTdN?=
 =?utf-8?B?WkRRSHl2QTdUV0xpNmY1VnFNWVBZY0tMcGdpU1FmR2FvVkhaNWJ6b0xtZUpi?=
 =?utf-8?B?UTNOdHR3dVo1MGxqeUVaVkppVlJRZFQ3alNqWEpnc0VzeHp1VU51NTBscklm?=
 =?utf-8?B?TmVpcmlOeHFoOXpsTnE3dWM4VDUxNmhQczFqN1AwQmlCa0hnK3Noa3RxTzFy?=
 =?utf-8?B?elBuZU95Q0ozSkVYbUdNR2dDZDNtQ1U1Q0tJMkk5NGxQL2hUUlByTStHaGYz?=
 =?utf-8?Q?VZa1y71yjhhZaits=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 051fab6e-cac0-480a-b358-08da26c9a2f3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 14:41:09.1914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fvNTxFWbVE90FVu2MrWgvSe3B1V+hot928Hd6RfDJWmQj2C5N/tgVbiIjHKlGh6zjEw+FA/vWY2OcFGgIeH5MQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3226

On Wed, Apr 13, 2022 at 09:41:52AM -0400, Tamas K Lengyel wrote:
> Add monitor event that hooks the vmexit handler allowing for both sync and
> async monitoring of events. With async monitoring an event is placed on the
> monitor ring for each exit and the rest of the vmexit handler resumes normally.
> If there are additional monitor events configured those will also place their
> respective events on the monitor ring.
> 
> With the sync version an event is placed on the monitor ring but the handler
> does not get resumed, thus the sync version is only useful when the VM is not
> expected to resume normally after the vmexit. Our use-case is primarily with
> the sync version with VM forks where the fork gets reset after sync vmexit
> event, thus the rest of the vmexit handler can be safely skipped. This is
> very useful when we want to avoid Xen crashing the VM under any circumstance,
> for example during fuzzing. Collecting all vmexit information regardless of
> the root cause makes it easier to reason about the state of the VM on the
> monitor side, hence we opt to receive all events, even for external interrupt
> and NMI exits and let the monitor agent decide how to proceed.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> ---
> v4: Minor tweaks and more verbose patch description.
> 
> Note: making the sync version resume-friendly is specifically out-of-scope as
> it would require significant rearrangement of the vmexit handler. As this
> feature is not required for our use-case we opt for the version that minimizes
> impact on the existing code.
> ---
>  tools/include/xenctrl.h                |  2 ++
>  tools/libs/ctrl/xc_monitor.c           | 15 +++++++++++++++
>  xen/arch/x86/hvm/monitor.c             | 18 ++++++++++++++++++
>  xen/arch/x86/hvm/vmx/vmx.c             | 12 ++++++++++++
>  xen/arch/x86/include/asm/domain.h      |  2 ++
>  xen/arch/x86/include/asm/hvm/monitor.h |  2 ++
>  xen/arch/x86/include/asm/monitor.h     |  3 ++-
>  xen/arch/x86/monitor.c                 | 14 ++++++++++++++
>  xen/include/public/domctl.h            |  6 ++++++
>  xen/include/public/vm_event.h          |  8 ++++++++
>  10 files changed, 81 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> index 1b089a2c02..159eaac050 100644
> --- a/tools/include/xenctrl.h
> +++ b/tools/include/xenctrl.h
> @@ -2096,6 +2096,8 @@ int xc_monitor_privileged_call(xc_interface *xch, uint32_t domain_id,
>                                 bool enable);
>  int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
>                                    bool enable);
> +int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
> +                      bool sync);
>  /**
>   * This function enables / disables emulation for each REP for a
>   * REP-compatible instruction.
> diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.c
> index 4ac823e775..c5fa62ff30 100644
> --- a/tools/libs/ctrl/xc_monitor.c
> +++ b/tools/libs/ctrl/xc_monitor.c
> @@ -246,6 +246,21 @@ int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
>      return do_domctl(xch, &domctl);
>  }
>  
> +int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
> +                      bool sync)
> +{
> +    DECLARE_DOMCTL;
> +
> +    domctl.cmd = XEN_DOMCTL_monitor_op;
> +    domctl.domain = domain_id;
> +    domctl.u.monitor_op.op = enable ? XEN_DOMCTL_MONITOR_OP_ENABLE
> +                                    : XEN_DOMCTL_MONITOR_OP_DISABLE;
> +    domctl.u.monitor_op.event = XEN_DOMCTL_MONITOR_EVENT_VMEXIT;
> +    domctl.u.monitor_op.u.vmexit.sync = sync;
> +
> +    return do_domctl(xch, &domctl);
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
> index b44a1e1dfe..64a38e8fa7 100644
> --- a/xen/arch/x86/hvm/monitor.c
> +++ b/xen/arch/x86/hvm/monitor.c
> @@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
>      return monitor_traps(curr, true, &req) >= 0;
>  }
>  
> +int hvm_monitor_vmexit(unsigned long exit_reason,
> +                       unsigned long exit_qualification)

Should this maybe live in vmx code or have 'vmx' in the name
somewhere, so that if an svm counterpart is added this doesn't need to
be renamed?

> +{
> +    struct vcpu *curr = current;
> +    struct arch_domain *ad = &curr->domain->arch;
> +    vm_event_request_t req = {};
> +
> +    ASSERT(ad->monitor.vmexit_enabled);
> +
> +    req.reason = VM_EVENT_REASON_VMEXIT;
> +    req.u.vmexit.reason = exit_reason;
> +    req.u.vmexit.qualification = exit_qualification;

You could set those fields at definition.

> +
> +    set_npt_base(curr, &req);
> +
> +    return monitor_traps(curr, ad->monitor.vmexit_sync, &req);
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index c075370f64..2794db46f9 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>          }
>      }
>  
> +    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
> +    {
> +        int rc;
> +
> +        __vmread(EXIT_QUALIFICATION, &exit_qualification);
> +        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
> +        if ( rc < 0 )
> +            goto exit_and_crash;
> +        if ( rc )
> +            return;
> +    }

Just for my understanding, is there any reason to not do this before
updating the altp2m?  AFAICT the update of the active EPTP won't
affect the call to hvm_monitor_vmexit.

> +
>      /* XXX: This looks ugly, but we need a mechanism to ensure
>       * any pending vmresume has really happened
>       */
> diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
> index e62e109598..855db352c0 100644
> --- a/xen/arch/x86/include/asm/domain.h
> +++ b/xen/arch/x86/include/asm/domain.h
> @@ -430,6 +430,8 @@ struct arch_domain
>           */
>          unsigned int inguest_pagefault_disabled                            : 1;
>          unsigned int control_register_values                               : 1;
> +        unsigned int vmexit_enabled                                        : 1;
> +        unsigned int vmexit_sync                                           : 1;
>          struct monitor_msr_bitmap *msr_bitmap;
>          uint64_t write_ctrlreg_mask[4];
>      } monitor;
> diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h
> index a75cd8545c..639f6dfa37 100644
> --- a/xen/arch/x86/include/asm/hvm/monitor.h
> +++ b/xen/arch/x86/include/asm/hvm/monitor.h
> @@ -51,6 +51,8 @@ bool hvm_monitor_emul_unimplemented(void);
>  
>  bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
>                             uint16_t kind);
> +int hvm_monitor_vmexit(unsigned long exit_reason,
> +                       unsigned long exit_qualification);
>  
>  #endif /* __ASM_X86_HVM_MONITOR_H__ */
>  
> diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/asm/monitor.h
> index 01c6d63bb9..d8d54c5f23 100644
> --- a/xen/arch/x86/include/asm/monitor.h
> +++ b/xen/arch/x86/include/asm/monitor.h
> @@ -89,7 +89,8 @@ static inline uint32_t arch_monitor_get_capabilities(struct domain *d)
>                      (1U << XEN_DOMCTL_MONITOR_EVENT_DEBUG_EXCEPTION) |
>                      (1U << XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG) |
>                      (1U << XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED) |
> -                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT));
> +                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT) |
> +                    (1U << XEN_DOMCTL_MONITOR_EVENT_VMEXIT));
>  
>      if ( hvm_is_singlestep_supported() )
>          capabilities |= (1U << XEN_DOMCTL_MONITOR_EVENT_SINGLESTEP);
> diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
> index 3079726a8b..30ca71432c 100644
> --- a/xen/arch/x86/monitor.c
> +++ b/xen/arch/x86/monitor.c
> @@ -332,6 +332,20 @@ int arch_monitor_domctl_event(struct domain *d,
>          break;
>      }
>  
> +    case XEN_DOMCTL_MONITOR_EVENT_VMEXIT:
> +    {
> +        bool old_status = ad->monitor.vmexit_enabled;
> +
> +        if ( unlikely(old_status == requested_status) )
> +            return -EEXIST;

What about if the requested status is the same as the current one, but
vmexit sync is not?

IOW, I'm not sure this check is helpful, and you could likely avoid
the old_status local variable.

> +
> +        domain_pause(d);
> +        ad->monitor.vmexit_enabled = requested_status;
> +        ad->monitor.vmexit_sync = mop->u.vmexit.sync;
> +        domain_unpause(d);
> +        break;
> +    }
> +
>      default:
>          /*
>           * Should not be reached unless arch_monitor_get_capabilities() is
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index b85e6170b0..4803ed7afc 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1057,6 +1057,7 @@ struct xen_domctl_psr_cmt_op {
>  #define XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED    10
>  /* Enabled by default */
>  #define XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT     11
> +#define XEN_DOMCTL_MONITOR_EVENT_VMEXIT                12
>  
>  struct xen_domctl_monitor_op {
>      uint32_t op; /* XEN_DOMCTL_MONITOR_OP_* */
> @@ -1107,6 +1108,11 @@ struct xen_domctl_monitor_op {
>              /* Pause vCPU until response */
>              uint8_t sync;
>          } debug_exception;
> +
> +        struct {
> +            /* Send event and don't process vmexit */
> +            uint8_t sync;
> +        } vmexit;
>      } u;
>  };
>  
> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
> index 81c2ee28cc..07f106f811 100644
> --- a/xen/include/public/vm_event.h
> +++ b/xen/include/public/vm_event.h
> @@ -175,6 +175,8 @@
>  #define VM_EVENT_REASON_DESCRIPTOR_ACCESS       13
>  /* Current instruction is not implemented by the emulator */
>  #define VM_EVENT_REASON_EMUL_UNIMPLEMENTED      14
> +/* VMEXIT */
> +#define VM_EVENT_REASON_VMEXIT                  15
>  
>  /* Supported values for the vm_event_write_ctrlreg index. */
>  #define VM_EVENT_X86_CR0    0
> @@ -394,6 +396,11 @@ struct vm_event_emul_insn_data {
>      uint8_t data[16]; /* Has to be completely filled */
>  };
>  
> +struct vm_event_vmexit {
> +    uint64_t reason;
> +    uint64_t qualification;
> +};

You are exposing an Intel specific interface publicly here.  Might be
worth adding a note, and/or adding 'intel' or 'vmx' in the structure
name: vm_event_vmx_exit, so that a vm_event_svm_exit could also be
added in the future.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 14:53:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 14:53:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313063.530522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj05m-0003Dv-8A; Mon, 25 Apr 2022 14:53:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313063.530522; Mon, 25 Apr 2022 14:53:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj05m-0003Do-4w; Mon, 25 Apr 2022 14:53:34 +0000
Received: by outflank-mailman (input) for mailman id 313063;
 Mon, 25 Apr 2022 14:53:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj05k-0003De-JS; Mon, 25 Apr 2022 14:53:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj05k-0005Zj-H7; Mon, 25 Apr 2022 14:53:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj05j-00020X-Uv; Mon, 25 Apr 2022 14:53:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj05j-0007XL-UV; Mon, 25 Apr 2022 14:53:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/MnHXHp7qybGTtBIPRiywbbIFsB/ggO0cQBy9QnOqm4=; b=ciVgkENdKlCuieRGRFXH19UAwe
	vrM132vQtTIC27QdYE/EOrHTXvvyksTb7cOr3F4aSu9CfwSvxZFDCxsfh9eh2piSMe9OiiNTxHy4o
	xsFFshCG+P5OGf6zCMs4L3Pj71bp2dZlCqBK8awlvgHlGdPAb5iX0CRKYI6GnyYDDh4I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169708-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169708: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 14:53:31 +0000

flight 169708 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169708/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  621 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 15:25:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 15:25:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313078.530533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0aW-00070s-NS; Mon, 25 Apr 2022 15:25:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313078.530533; Mon, 25 Apr 2022 15:25:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0aW-00070l-Kc; Mon, 25 Apr 2022 15:25:20 +0000
Received: by outflank-mailman (input) for mailman id 313078;
 Mon, 25 Apr 2022 15:25:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rnYW=VD=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nj0aU-00070f-Q5
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 15:25:19 +0000
Received: from MTA-08-3.privateemail.com (mta-08-3.privateemail.com
 [198.54.127.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e838cae8-c4ab-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 17:25:17 +0200 (CEST)
Received: from mta-08.privateemail.com (localhost [127.0.0.1])
 by mta-08.privateemail.com (Postfix) with ESMTP id 1C5FF18000A1
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 11:25:15 -0400 (EDT)
Received: from mail-oi1-f174.google.com (unknown [10.20.151.185])
 by mta-08.privateemail.com (Postfix) with ESMTPA id E942918000A7
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 11:25:14 -0400 (EDT)
Received: by mail-oi1-f174.google.com with SMTP id r8so17482698oib.5
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 08:25:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e838cae8-c4ab-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650900315;
	bh=MkKuORuPDUh2uPnmqS+0+j8y+u89+kSTWJQyAa1QNdw=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=NBWuN64bZuCIwq1ygJrbVz2ZB4XlNfMPx15qjFTB3sjd0PaUHELfP//tP3MCUo3lW
	 RXAA2Umr/8cQdz0+Io26EsitOv1W+FSrbteRRRH7dSzTDkNumFMGzAr1OUrXOANDK0
	 8Z5/Mtc6u3dmwzkuGH7Re1lWZGwS081iKD+QY+oiDr0HOQBFC/IUSNpxg2rX9TMZvS
	 y0sPLhuZjuF5GpAcbQiCBKbwDJkQNAQmjt4VNqcOv6yJRdR9MGTE2JBQWUMppCwSYk
	 hpeoZq6+XiskalDlCcsz0LMoZO/ol9JnPqY7QrNxlV1a+vpqFo3/R87ck9GTAy1/wS
	 LIKh10TgI22eA==
X-Gm-Message-State: AOAM532hTGQD7SlcPtY3xLTg2QOUxxHIWzZttEmhTj0uGZOEzVlcWrKE
	CXphMGqANYdD8chCzqwvpuXXlcCNeYWoI+MOsaA=
X-Google-Smtp-Source: ABdhPJwZQqS53HRrr1UxQRHGTEtnkw0mHieWfMIGDZz1yIdlGHtNoDsuLa7TevocsMF3ajeKxQeZ67/dfczcofQMpnc=
X-Received: by 2002:a05:6808:302b:b0:2f9:eeef:f03 with SMTP id
 ay43-20020a056808302b00b002f9eeef0f03mr13049180oib.128.1650900314214; Mon, 25
 Apr 2022 08:25:14 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <YmasHAT0YkeJVMbv@Air-de-Roger>
In-Reply-To: <YmasHAT0YkeJVMbv@Air-de-Roger>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 25 Apr 2022 11:24:37 -0400
X-Gmail-Original-Message-ID: <CABfawhn=6KVVPZD6AVRH2=NJFd5ZwtPpxDn__LdEFJQx6bhCXA@mail.gmail.com>
Message-ID: <CABfawhn=6KVVPZD6AVRH2=NJFd5ZwtPpxDn__LdEFJQx6bhCXA@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, xen-devel@lists.xenproject.org, 
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Alexandru Isaila <aisaila@bitdefender.com>, 
	Petre Pircalabu <ppircalabu@bitdefender.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP

On Mon, Apr 25, 2022 at 10:12 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.com=
> wrote:
>
> On Wed, Apr 13, 2022 at 09:41:51AM -0400, Tamas K Lengyel wrote:
> > Allow specify distinct parts of the fork VM to be reset. This is useful=
 when a
> > fuzzing operation involves mapping in only a handful of pages that are =
known
> > ahead of time. Throwing these pages away just to be re-copied immediate=
ly is
> > expensive, thus allowing to specify partial resets can speed things up.
> >
> > Also allow resetting to be initiated from vm_event responses as an
> > optiomization.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thank you!

> > ---
> > v4: No change
> > v3: Rebase on simpler approach after dropping empty_p2m feature
> > v2: address review comments and add more sanity checking
> > ---
> >  tools/include/xenctrl.h                |  3 ++-
> >  tools/libs/ctrl/xc_memshr.c            |  7 ++++++-
> >  xen/arch/x86/include/asm/mem_sharing.h |  9 +++++++++
> >  xen/arch/x86/mm/mem_sharing.c          | 24 +++++++++++++++++++-----
> >  xen/common/vm_event.c                  | 15 +++++++++++++++
> >  xen/include/public/memory.h            |  4 +++-
> >  xen/include/public/vm_event.h          |  8 ++++++++
> >  7 files changed, 62 insertions(+), 8 deletions(-)
> >
> > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> > index 95bd5eca67..1b089a2c02 100644
> > --- a/tools/include/xenctrl.h
> > +++ b/tools/include/xenctrl.h
> > @@ -2290,7 +2290,8 @@ int xc_memshr_fork(xc_interface *xch,
> >   *
> >   * With VMs that have a lot of memory this call may block for a long t=
ime.
> >   */
> > -int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain);
> > +int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain,
> > +                         bool reset_state, bool reset_memory);
> >
> >  /* Debug calls: return the number of pages referencing the shared fram=
e backing
> >   * the input argument. Should be one or greater.
> > diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c
> > index a6cfd7dccf..a0d0b894e2 100644
> > --- a/tools/libs/ctrl/xc_memshr.c
> > +++ b/tools/libs/ctrl/xc_memshr.c
> > @@ -257,12 +257,17 @@ int xc_memshr_fork(xc_interface *xch, uint32_t pd=
omid, uint32_t domid,
> >      return xc_memshr_memop(xch, domid, &mso);
> >  }
> >
> > -int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid)
> > +int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid, bool reset=
_state,
> > +                         bool reset_memory)
> >  {
> >      xen_mem_sharing_op_t mso;
> >
> >      memset(&mso, 0, sizeof(mso));
> >      mso.op =3D XENMEM_sharing_op_fork_reset;
> > +    if ( reset_state )
> > +        mso.u.fork.flags |=3D XENMEM_FORK_RESET_STATE;
> > +    if ( reset_memory )
> > +        mso.u.fork.flags |=3D XENMEM_FORK_RESET_MEMORY;
>
> IMO would be clearer to init mso fields at definition.

Not sure what you mean exactly, mso =3D { ... }; ? I think the logic is
pretty clear as-is and I don't have any preference for one style vs
the other.

>
> > diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
> > index 84cf52636b..d26a6699fc 100644
> > --- a/xen/common/vm_event.c
> > +++ b/xen/common/vm_event.c
> > @@ -28,6 +28,11 @@
> >  #include <asm/p2m.h>
> >  #include <asm/monitor.h>
> >  #include <asm/vm_event.h>
> > +
> > +#ifdef CONFIG_MEM_SHARING
> > +#include <asm/mem_sharing.h>
> > +#endif
> > +
> >  #include <xsm/xsm.h>
> >  #include <public/hvm/params.h>
> >
> > @@ -394,6 +399,16 @@ static int vm_event_resume(struct domain *d, struc=
t vm_event_domain *ved)
> >              if ( rsp.reason =3D=3D VM_EVENT_REASON_MEM_PAGING )
> >                  p2m_mem_paging_resume(d, &rsp);
> >  #endif
> > +#ifdef CONFIG_MEM_SHARING
> > +            if ( mem_sharing_is_fork(d) )
> > +            {
> > +                bool reset_state =3D rsp.flags & VM_EVENT_FLAG_RESET_F=
ORK_STATE;
> > +                bool reset_mem =3D rsp.flags & VM_EVENT_FLAG_RESET_FOR=
K_MEMORY;
> > +
> > +                if ( reset_state || reset_mem )
> > +                    ASSERT(!mem_sharing_fork_reset(d, reset_state, res=
et_mem));
>
> Might be appropriate to destroy the domain in case fork reset fails?
> ASSERT will only help in debug builds.

No, I would prefer not destroying the domain here. If it ever becomes
necessary the right way would be to introduce a new monitor event to
signal an error and let the listener decide what to do. At the moment
I don't see that being necessary as there are no known scenarios where
we would be able to setup a fork but fail to reset is.

>
> > +            }
> > +#endif
> >
> >              /*
> >               * Check emulation flags in the arch-specific handler only=
, as it
> > diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
> > index a1a0f0233a..f8d26fb77d 100644
> > --- a/xen/include/public/memory.h
> > +++ b/xen/include/public/memory.h
> > @@ -541,12 +541,14 @@ struct xen_mem_sharing_op {
> >                  uint32_t gref;     /* IN: gref to debug         */
> >              } u;
> >          } debug;
> > -        struct mem_sharing_op_fork {      /* OP_FORK */
> > +        struct mem_sharing_op_fork {      /* OP_FORK{,_RESET} */
> >              domid_t parent_domain;        /* IN: parent's domain id */
> >  /* Only makes sense for short-lived forks */
> >  #define XENMEM_FORK_WITH_IOMMU_ALLOWED (1u << 0)
> >  /* Only makes sense for short-lived forks */
> >  #define XENMEM_FORK_BLOCK_INTERRUPTS   (1u << 1)
>
> Should you add:
>
> /* Only for OP_FORK_RESET. */
>
> > +#define XENMEM_FORK_RESET_STATE        (1u << 2)
> > +#define XENMEM_FORK_RESET_MEMORY       (1u << 3)

I think the flag names are really descriptive already that these apply
to the FORK_RESET case but I would have no objection to that comment
being added at commit.

Thanks again,
Tamas


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 15:29:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 15:29:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313084.530545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0eX-0007e4-9b; Mon, 25 Apr 2022 15:29:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313084.530545; Mon, 25 Apr 2022 15:29:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0eX-0007dx-6F; Mon, 25 Apr 2022 15:29:29 +0000
Received: by outflank-mailman (input) for mailman id 313084;
 Mon, 25 Apr 2022 15:29:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fQr/=VD=intel.com=ira.weiny@srs-se1.protection.inumbo.net>)
 id 1nj0eV-0007dl-Kv
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 15:29:27 +0000
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7b24ca21-c4ac-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 17:29:24 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Apr 2022 08:29:21 -0700
Received: from kruparel-mobl1.amr.corp.intel.com (HELO localhost)
 ([10.213.188.223])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Apr 2022 08:29:19 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b24ca21-c4ac-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1650900564; x=1682436564;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=0GDQj58/ILWl4MZTREe62fOIDZzmstbJgN8ixfUIGG8=;
  b=Xdj5ypi86khoKGVWDcfudSwQzLzZDnYpsAy0DL4OyuwzVwtzWidIN4ly
   UnasAfrmkqrVR+HmQ1KRW1OnLxTz7W6yTVEBrxKRSbn17sR6ljDWO7Gcn
   wnplGTcyx8eDk4LgsQ7hSq70EepJY3m83MkL1feE8t1Jn++k5jG24OFOg
   49V1CTPz4GolKY2JkDo96E3VgzFvCLIi8D/GmDV4zmrT2JACgVKTUaI5W
   YiiIzHAFoBYu3qovZtDlDl0jqI/y4S6XX5wWP43qFs0aZx+PfeN31wwIy
   ou0vnYqAGNURvBCs+pd0UQexZBOIOwID7KjMjkAvOPvPfzU47/a3kPBpl
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="245844588"
X-IronPort-AV: E=Sophos;i="5.90,288,1643702400"; 
   d="scan'208";a="245844588"
X-IronPort-AV: E=Sophos;i="5.90,288,1643702400"; 
   d="scan'208";a="677259037"
Date: Mon, 25 Apr 2022 08:29:19 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Julia Lawall <julia.lawall@inria.fr>,
	Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
	outreachy@lists.linux.dev, boris.ostrovsky@oracle.com,
	jgross@suse.com, sstabellini@kernel.org,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
Message-ID: <Yma9zvvuZGyAeRBG@iweiny-desk3>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com>
 <3990312.6PsWsQAL7t@leap>
 <alpine.DEB.2.22.394.2204201556330.2937@hadrien>
 <2538961.9Mp67QZiUf@leap>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2538961.9Mp67QZiUf@leap>

On Wed, Apr 20, 2022 at 04:07:36PM +0200, Fabio M. De Francesco wrote:
> On mercoled� 20 aprile 2022 15:57:14 CEST Julia Lawall wrote:
> > 
> > On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:
> > 
> > > On mercoled� 20 aprile 2022 15:40:10 CEST Julia Lawall wrote:
> > > >
> > > > On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:
> > > >
> > > > > On mercoled� 20 aprile 2022 08:03:05 CEST Julia Lawall wrote:
> > > > > >
> > > > > > On Wed, 20 Apr 2022, Alaa Mohamed wrote:
> > > > > >
> > > > > > > kmap() is being deprecated and these usages are all local to 
> the
> > > thread
> > > > > > > so there is no reason kmap_local_page() can't be used.
> > > > > > >
> > > > > > > Replace kmap() calls with kmap_local_page().
> > > > > >
> > > > > > OK, so from a Coccinelle point of view, could we do
> > > > > >
> > > > > > @@
> > > > > > expression e1,e2,x,f;
> > > > > > @@
> > > > > >
> > > > > > e1 =
> > > > > > - kmap
> > > > > > + kmap_local_page
> > > > > >     (e2)
> > > > > > ... when != x = e1 // not stored in any location and not passed 
> to
> > > > > another function
> > > > > >     when != f(...,e1,...)
> > > > > >     when != x = e2
> > > > > >     when != f(...,e2,...)
> > > > > > -kunmap(e2)
> > > > > > +kunmap_local(e1)
> > > > > >
> > > > > > julia
> > > > > >
> > > > >
> > > > > I've never spent sufficient time to understand properly the syntax 
> and
> > > > > semantics of expressions of Coccinelle. However, thanks Julia, this
> > > code
> > > > > looks good and can be very helpful.
> > > > >
> > > > > Only a minor objection... it doesn't tell when 'e2' has been 
> allocated
> > > > > within the same function where the kmap() call is.
> > > > >
> > > > > In the particular case that I cite above, I'd prefer to remove the
> > > > > allocation of the page (say with alloc_page()) and convert kmap() /
> > > kunmap()
> > > > > to use kmalloc() / kfree().
> > > > >
> > > > > Fox example, this is done in the following patch:
> > > > >
> > > > > commit 633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from
> > > > > sgx_ioc_enclave_init()") from Ira Weiny.
> > > > >
> > > > > Can Coccinelle catch also those special cases where a page that is
> > > passed
> > > > > to kmap() is allocated within that same function (vs. being passed 
> as
> > > > > argument to this function) and, if so, propose a replacement with
> > > > > kmalloc()?
> > > >
> > > > It looks complex in this case, because the allocation is in another
> > > > function, and it is passed to another function.
> > >
> > > This is not the special case I was talking about. In this case your 
> code
> > > for Coccinelle tells the right proposal and it is exactly what Alaa did 
> in
> > > her patch (which is good!).
> > >
> > > I'm talking about other special cases like the one I pointed to with 
> the
> > > link I provided. I'm sorry if my bad English made you think that Alaa's
> > > patch was one of those cases where the page is allocated within the 
> same
> > > function where kmap() is.
> > >
> > > I hope that now I've been clearer :)
> > 
> > Ah, sorry for the misunderstanding.  If you have an example, I can take a
> > look and propose something for this special case.
> > 
> > julia
> 
> Yes, I have the example that you are asking for. It's that commit 
> 633b0616cfe0 from Ira Weiny.
> 
> Let me copy and paste it here for your convenience...
> 
> diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/
> ioctl.c
> index 90a5caf76939..2e10367ea66c 100644
> --- a/arch/x86/kernel/cpu/sgx/ioctl.c
> +++ b/arch/x86/kernel/cpu/sgx/ioctl.c
> @@ -604,7 +604,6 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl, 
> void __user *arg)
>  {
>         struct sgx_sigstruct *sigstruct;
>         struct sgx_enclave_init init_arg;
> -       struct page *initp_page;
>         void *token;
>         int ret;
>  
> @@ -615,11 +614,15 @@ static long sgx_ioc_enclave_init(struct sgx_encl 
> *encl, void __user *arg)
>         if (copy_from_user(&init_arg, arg, sizeof(init_arg)))
>                 return -EFAULT;
>  
> -       initp_page = alloc_page(GFP_KERNEL);
> -       if (!initp_page)
> +       /*
> +        * 'sigstruct' must be on a page boundary and 'token' on a 512 byte
> +        * boundary.  kmalloc() will give this alignment when allocating
> +        * PAGE_SIZE bytes.
> +        */
> +       sigstruct = kmalloc(PAGE_SIZE, GFP_KERNEL);
> +       if (!sigstruct)
>                 return -ENOMEM;
>  
> -       sigstruct = kmap(initp_page);
>         token = (void *)((unsigned long)sigstruct + PAGE_SIZE / 2);
>         memset(token, 0, SGX_LAUNCH_TOKEN_SIZE);
>  
> @@ -645,8 +648,7 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl, 
> void __user *arg)
>         ret = sgx_encl_init(encl, sigstruct, token);
>  
>  out:
> -       kunmap(initp_page);
> -       __free_page(initp_page);
> +       kfree(sigstruct);
>         return ret;
>  }
> 
> I think that Coccinelle might understand that "initp_page" is allocated in 
> the same function where later it is kmap()'ed. But I'm not able to write a 
> Coccinelle check to find out these kinds of special cases. In these cases 
> the correct solution is not to use kmap_local_page(). Instead delete the 
> alloc_page() and use kmalloc().
>

Sorry about missing this thread last week...

I've lost the Coccinelle scripts I wrote before but the ones which helped were
documented in patches I submitted when Coccinelle was used.

I think Coccinelle can help a lot.  And probably a lot more than I know since
I'm not an expert in the language either.

However, In addition to the example Fabio shows above here are a few other
things to look out for when writing Coccinelle scripts.

1) The addition of mem*_page() functions means sometimes the entire kmap/kunmap
   can be removed.  Check out the Coccinelle script for that.[1]

2) kunmap_local() has ordering rules which often requires some manual
   review.[2]

3) kmap/kunmap is often wrapped in other subsystem helper functions.  I was not
   sure how to deal with that in Coccinelle.  Julia is this easy in
   Coccinelle?[3]


Ira


[1]
https://lore.kernel.org/lkml/20210205232304.1670522-3-ira.weiny@intel.com/
https://lore.kernel.org/lkml/20210205232304.1670522-5-ira.weiny@intel.com/

[2]
https://lore.kernel.org/lkml/20210217024826.3466046-3-ira.weiny@intel.com/
https://lore.kernel.org/lkml/20210217024826.3466046-4-ira.weiny@intel.com/

[3]
https://lore.kernel.org/lkml/20210217024826.3466046-5-ira.weiny@intel.com/

> 
> Thanks,
> 
> Fabio
> 
> 
> 


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 15:30:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 15:30:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313089.530556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0fZ-0000Ww-Ji; Mon, 25 Apr 2022 15:30:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313089.530556; Mon, 25 Apr 2022 15:30:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0fZ-0000Wn-Gf; Mon, 25 Apr 2022 15:30:33 +0000
Received: by outflank-mailman (input) for mailman id 313089;
 Mon, 25 Apr 2022 15:30:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj0fY-0000WV-ER; Mon, 25 Apr 2022 15:30:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj0fY-0006DA-BB; Mon, 25 Apr 2022 15:30:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj0fY-0002nw-08; Mon, 25 Apr 2022 15:30:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj0fX-0000b5-W1; Mon, 25 Apr 2022 15:30:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=98dFnmu5Bm2Qc15rtwNROXGxly/TwV8q2R9sIpnDug4=; b=5ydooEAyVbecNmeHhLd5IKH3/2
	zitDzqZnH+0sCFtlS7qRPik25/LnXY6sDrcs2ExEtfDl7/rlh+MRPB8db1+WEG3PRCNemA9MK0Bp6
	tPA0KCjKTMpwpfZrjj3BgigInP89u/yp/bzm6DBjqIEjZudkAF2xHjCWsdfu4hkcT+Ok=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169709-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169709: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 15:30:31 +0000

flight 169709 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169709/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  622 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 15:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 15:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313102.530567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0jw-0001Qf-A9; Mon, 25 Apr 2022 15:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313102.530567; Mon, 25 Apr 2022 15:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0jw-0001QY-7A; Mon, 25 Apr 2022 15:35:04 +0000
Received: by outflank-mailman (input) for mailman id 313102;
 Mon, 25 Apr 2022 15:35:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qlrd=VD=inria.fr=julia.lawall@srs-se1.protection.inumbo.net>)
 id 1nj0jv-0001QS-4o
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 15:35:03 +0000
Received: from mail3-relais-sop.national.inria.fr
 (mail3-relais-sop.national.inria.fr [192.134.164.104])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4501050a-c4ad-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 17:35:01 +0200 (CEST)
Received: from ip-214.net-89-2-7.rev.numericable.fr (HELO hadrien)
 ([89.2.7.214]) by mail3-relais-sop.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 17:35:00 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4501050a-c4ad-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=inria.fr; s=dc;
  h=date:from:to:cc:subject:in-reply-to:message-id:
   references:mime-version;
  bh=2BAVYOzHyLn6mrUTsnozcnawOl0hxdkWwXi8fyQF4Ik=;
  b=LbaA6wKuIm3B3fXzADjns8BtJVZsRwYNKdhnolZfvhz3lF127+ipZpoM
   yr+P61xyB7QYhdNgJOGf6TzE9Q8/eU5hniKcHFWqNiI3av3jnsb6sTpEv
   miliijm9jLUO0TLCtzgB/hGEwEr1YdVJdkTbpsPBj5C/hSVtM25LMyVFg
   4=;
Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr
X-IronPort-AV: E=Sophos;i="5.90,288,1643670000"; 
   d="scan'208";a="12375271"
Date: Mon, 25 Apr 2022 17:34:59 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
X-X-Sender: jll@hadrien
To: Ira Weiny <ira.weiny@intel.com>
cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>, 
    Julia Lawall <julia.lawall@inria.fr>, 
    Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>, 
    outreachy@lists.linux.dev, boris.ostrovsky@oracle.com, jgross@suse.com, 
    sstabellini@kernel.org, xen-devel@lists.xenproject.org, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen:  Convert kmap() to kmap_local_page()
In-Reply-To: <Yma9zvvuZGyAeRBG@iweiny-desk3>
Message-ID: <alpine.DEB.2.22.394.2204251733420.2718@hadrien>
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com> <3990312.6PsWsQAL7t@leap> <alpine.DEB.2.22.394.2204201556330.2937@hadrien> <2538961.9Mp67QZiUf@leap> <Yma9zvvuZGyAeRBG@iweiny-desk3>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1172987651-1650900900=:2718"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1172987651-1650900900=:2718
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT



On Mon, 25 Apr 2022, Ira Weiny wrote:

> On Wed, Apr 20, 2022 at 04:07:36PM +0200, Fabio M. De Francesco wrote:
> > On mercoled� 20 aprile 2022 15:57:14 CEST Julia Lawall wrote:
> > >
> > > On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:
> > >
> > > > On mercoled� 20 aprile 2022 15:40:10 CEST Julia Lawall wrote:
> > > > >
> > > > > On Wed, 20 Apr 2022, Fabio M. De Francesco wrote:
> > > > >
> > > > > > On mercoled� 20 aprile 2022 08:03:05 CEST Julia Lawall wrote:
> > > > > > >
> > > > > > > On Wed, 20 Apr 2022, Alaa Mohamed wrote:
> > > > > > >
> > > > > > > > kmap() is being deprecated and these usages are all local to
> > the
> > > > thread
> > > > > > > > so there is no reason kmap_local_page() can't be used.
> > > > > > > >
> > > > > > > > Replace kmap() calls with kmap_local_page().
> > > > > > >
> > > > > > > OK, so from a Coccinelle point of view, could we do
> > > > > > >
> > > > > > > @@
> > > > > > > expression e1,e2,x,f;
> > > > > > > @@
> > > > > > >
> > > > > > > e1 =
> > > > > > > - kmap
> > > > > > > + kmap_local_page
> > > > > > >     (e2)
> > > > > > > ... when != x = e1 // not stored in any location and not passed
> > to
> > > > > > another function
> > > > > > >     when != f(...,e1,...)
> > > > > > >     when != x = e2
> > > > > > >     when != f(...,e2,...)
> > > > > > > -kunmap(e2)
> > > > > > > +kunmap_local(e1)
> > > > > > >
> > > > > > > julia
> > > > > > >
> > > > > >
> > > > > > I've never spent sufficient time to understand properly the syntax
> > and
> > > > > > semantics of expressions of Coccinelle. However, thanks Julia, this
> > > > code
> > > > > > looks good and can be very helpful.
> > > > > >
> > > > > > Only a minor objection... it doesn't tell when 'e2' has been
> > allocated
> > > > > > within the same function where the kmap() call is.
> > > > > >
> > > > > > In the particular case that I cite above, I'd prefer to remove the
> > > > > > allocation of the page (say with alloc_page()) and convert kmap() /
> > > > kunmap()
> > > > > > to use kmalloc() / kfree().
> > > > > >
> > > > > > Fox example, this is done in the following patch:
> > > > > >
> > > > > > commit 633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from
> > > > > > sgx_ioc_enclave_init()") from Ira Weiny.
> > > > > >
> > > > > > Can Coccinelle catch also those special cases where a page that is
> > > > passed
> > > > > > to kmap() is allocated within that same function (vs. being passed
> > as
> > > > > > argument to this function) and, if so, propose a replacement with
> > > > > > kmalloc()?
> > > > >
> > > > > It looks complex in this case, because the allocation is in another
> > > > > function, and it is passed to another function.
> > > >
> > > > This is not the special case I was talking about. In this case your
> > code
> > > > for Coccinelle tells the right proposal and it is exactly what Alaa did
> > in
> > > > her patch (which is good!).
> > > >
> > > > I'm talking about other special cases like the one I pointed to with
> > the
> > > > link I provided. I'm sorry if my bad English made you think that Alaa's
> > > > patch was one of those cases where the page is allocated within the
> > same
> > > > function where kmap() is.
> > > >
> > > > I hope that now I've been clearer :)
> > >
> > > Ah, sorry for the misunderstanding.  If you have an example, I can take a
> > > look and propose something for this special case.
> > >
> > > julia
> >
> > Yes, I have the example that you are asking for. It's that commit
> > 633b0616cfe0 from Ira Weiny.
> >
> > Let me copy and paste it here for your convenience...
> >
> > diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/
> > ioctl.c
> > index 90a5caf76939..2e10367ea66c 100644
> > --- a/arch/x86/kernel/cpu/sgx/ioctl.c
> > +++ b/arch/x86/kernel/cpu/sgx/ioctl.c
> > @@ -604,7 +604,6 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl,
> > void __user *arg)
> >  {
> >         struct sgx_sigstruct *sigstruct;
> >         struct sgx_enclave_init init_arg;
> > -       struct page *initp_page;
> >         void *token;
> >         int ret;
> >
> > @@ -615,11 +614,15 @@ static long sgx_ioc_enclave_init(struct sgx_encl
> > *encl, void __user *arg)
> >         if (copy_from_user(&init_arg, arg, sizeof(init_arg)))
> >                 return -EFAULT;
> >
> > -       initp_page = alloc_page(GFP_KERNEL);
> > -       if (!initp_page)
> > +       /*
> > +        * 'sigstruct' must be on a page boundary and 'token' on a 512 byte
> > +        * boundary.  kmalloc() will give this alignment when allocating
> > +        * PAGE_SIZE bytes.
> > +        */
> > +       sigstruct = kmalloc(PAGE_SIZE, GFP_KERNEL);
> > +       if (!sigstruct)
> >                 return -ENOMEM;
> >
> > -       sigstruct = kmap(initp_page);
> >         token = (void *)((unsigned long)sigstruct + PAGE_SIZE / 2);
> >         memset(token, 0, SGX_LAUNCH_TOKEN_SIZE);
> >
> > @@ -645,8 +648,7 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl,
> > void __user *arg)
> >         ret = sgx_encl_init(encl, sigstruct, token);
> >
> >  out:
> > -       kunmap(initp_page);
> > -       __free_page(initp_page);
> > +       kfree(sigstruct);
> >         return ret;
> >  }
> >
> > I think that Coccinelle might understand that "initp_page" is allocated in
> > the same function where later it is kmap()'ed. But I'm not able to write a
> > Coccinelle check to find out these kinds of special cases. In these cases
> > the correct solution is not to use kmap_local_page(). Instead delete the
> > alloc_page() and use kmalloc().
> >
>
> Sorry about missing this thread last week...
>
> I've lost the Coccinelle scripts I wrote before but the ones which helped were
> documented in patches I submitted when Coccinelle was used.
>
> I think Coccinelle can help a lot.  And probably a lot more than I know since
> I'm not an expert in the language either.
>
> However, In addition to the example Fabio shows above here are a few other
> things to look out for when writing Coccinelle scripts.
>
> 1) The addition of mem*_page() functions means sometimes the entire kmap/kunmap
>    can be removed.  Check out the Coccinelle script for that.[1]
>
> 2) kunmap_local() has ordering rules which often requires some manual
>    review.[2]
>
> 3) kmap/kunmap is often wrapped in other subsystem helper functions.  I was not
>    sure how to deal with that in Coccinelle.  Julia is this easy in
>    Coccinelle?[3]


Thanks for the pointers.

[3] would depend on how much risk you are willing to take.  The arguments
are the same, except for the array index, for example.  But one may prefer
to be sure that nothing complex happens between the two calls.

julia

>
>
> Ira
>
>
> [1]
> https://lore.kernel.org/lkml/20210205232304.1670522-3-ira.weiny@intel.com/
> https://lore.kernel.org/lkml/20210205232304.1670522-5-ira.weiny@intel.com/
>
> [2]
> https://lore.kernel.org/lkml/20210217024826.3466046-3-ira.weiny@intel.com/
> https://lore.kernel.org/lkml/20210217024826.3466046-4-ira.weiny@intel.com/
>
> [3]
> https://lore.kernel.org/lkml/20210217024826.3466046-5-ira.weiny@intel.com/
>
> >
> > Thanks,
> >
> > Fabio
> >
> >
> >
>
>
--8323329-1172987651-1650900900=:2718--


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 15:40:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 15:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313130.530596 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0pa-0003jq-CF; Mon, 25 Apr 2022 15:40:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313130.530596; Mon, 25 Apr 2022 15:40:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj0pa-0003jf-85; Mon, 25 Apr 2022 15:40:54 +0000
Received: by outflank-mailman (input) for mailman id 313130;
 Mon, 25 Apr 2022 15:40:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rnYW=VD=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nj0pY-0003iJ-FD
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 15:40:52 +0000
Received: from MTA-05-3.privateemail.com (mta-05-3.privateemail.com
 [68.65.122.15]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 14b860ca-c4ae-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 17:40:50 +0200 (CEST)
Received: from mta-05.privateemail.com (localhost [127.0.0.1])
 by mta-05.privateemail.com (Postfix) with ESMTP id A5B96180009E
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 11:40:48 -0400 (EDT)
Received: from mail-oi1-f172.google.com (unknown [10.20.151.149])
 by mta-05.privateemail.com (Postfix) with ESMTPA id 7F4D918000A5
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 11:40:48 -0400 (EDT)
Received: by mail-oi1-f172.google.com with SMTP id a10so17506440oif.9
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 08:40:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14b860ca-c4ae-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650901248;
	bh=wogc9opKNvjdbZ9ltiRKfMo3505ImiITi0CQ4uaa0F4=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=N+HfI2cejrFFWu0eqPGVtcYygfvlF9wWb9gYcoqkPjGA9uhU8qYF+aMBCgyoR778k
	 /KjM8099Yt4WsxfKcriP1XUGYUt4QL9BHwdWmgpSKkMYtPunpahj8hRsi7xYJsDoSh
	 T0/qtBR52wUGSTQGNMJ/0tgxmMmNJZpFbJUvgOKnDRVT3hl8w95W7JFCtsJg9uixFt
	 Ia90tggWNbq316TCIq1KKUJjVa8N65Sx7Fmtp2DmaAsiDGgqesOrWBXCeG3z4bBMgb
	 cN+rl4MbOZkLEwwZSI+Ao/z36V279Iv9o9AZ4EngD804vwqh9upNd1dTXitVXZB2bT
	 RCgLmAZyufCFw==
X-Gm-Message-State: AOAM5335vGNn/S6LULk3FFOqzJUqUP5jr1NVV26M5U28IFHOpjeE8eIb
	6hbg2SRyRkHqPrvxu0ewpoLe5kzaJ8gE8Rg4QOA=
X-Google-Smtp-Source: ABdhPJwPJ823EFBYHbCA+c2iWCDp2WOSVdxRklONsMUh/vtgTjL3xh5rCa8mjvxwI8fwYUCxmZMvcSa/nx7KCjSYgKk=
X-Received: by 2002:a05:6808:302b:b0:2f9:eeef:f03 with SMTP id
 ay43-20020a056808302b00b002f9eeef0f03mr13087651oib.128.1650901247627; Mon, 25
 Apr 2022 08:40:47 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
 <YmazAdHL4LWOdDDv@Air-de-Roger>
In-Reply-To: <YmazAdHL4LWOdDDv@Air-de-Roger>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 25 Apr 2022 11:40:11 -0400
X-Gmail-Original-Message-ID: <CABfawh=Z1_88p14ivkqrBAUKbfw39f-frXN9uNsdVt9BDp+4bA@mail.gmail.com>
Message-ID: <CABfawh=Z1_88p14ivkqrBAUKbfw39f-frXN9uNsdVt9BDp+4bA@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] x86/monitor: Add new monitor event to catch all vmexits
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, xen-devel@lists.xenproject.org, 
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Alexandru Isaila <aisaila@bitdefender.com>, 
	Petre Pircalabu <ppircalabu@bitdefender.com>, Jun Nakajima <jun.nakajima@intel.com>, 
	Kevin Tian <kevin.tian@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP

On Mon, Apr 25, 2022 at 10:41 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.com=
> wrote:
>
> On Wed, Apr 13, 2022 at 09:41:52AM -0400, Tamas K Lengyel wrote:
> > Add monitor event that hooks the vmexit handler allowing for both sync =
and
> > async monitoring of events. With async monitoring an event is placed on=
 the
> > monitor ring for each exit and the rest of the vmexit handler resumes n=
ormally.
> > If there are additional monitor events configured those will also place=
 their
> > respective events on the monitor ring.
> >
> > With the sync version an event is placed on the monitor ring but the ha=
ndler
> > does not get resumed, thus the sync version is only useful when the VM =
is not
> > expected to resume normally after the vmexit. Our use-case is primarily=
 with
> > the sync version with VM forks where the fork gets reset after sync vme=
xit
> > event, thus the rest of the vmexit handler can be safely skipped. This =
is
> > very useful when we want to avoid Xen crashing the VM under any circums=
tance,
> > for example during fuzzing. Collecting all vmexit information regardles=
s of
> > the root cause makes it easier to reason about the state of the VM on t=
he
> > monitor side, hence we opt to receive all events, even for external int=
errupt
> > and NMI exits and let the monitor agent decide how to proceed.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> > ---
> > v4: Minor tweaks and more verbose patch description.
> >
> > Note: making the sync version resume-friendly is specifically out-of-sc=
ope as
> > it would require significant rearrangement of the vmexit handler. As th=
is
> > feature is not required for our use-case we opt for the version that mi=
nimizes
> > impact on the existing code.
> > ---
> >  tools/include/xenctrl.h                |  2 ++
> >  tools/libs/ctrl/xc_monitor.c           | 15 +++++++++++++++
> >  xen/arch/x86/hvm/monitor.c             | 18 ++++++++++++++++++
> >  xen/arch/x86/hvm/vmx/vmx.c             | 12 ++++++++++++
> >  xen/arch/x86/include/asm/domain.h      |  2 ++
> >  xen/arch/x86/include/asm/hvm/monitor.h |  2 ++
> >  xen/arch/x86/include/asm/monitor.h     |  3 ++-
> >  xen/arch/x86/monitor.c                 | 14 ++++++++++++++
> >  xen/include/public/domctl.h            |  6 ++++++
> >  xen/include/public/vm_event.h          |  8 ++++++++
> >  10 files changed, 81 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> > index 1b089a2c02..159eaac050 100644
> > --- a/tools/include/xenctrl.h
> > +++ b/tools/include/xenctrl.h
> > @@ -2096,6 +2096,8 @@ int xc_monitor_privileged_call(xc_interface *xch,=
 uint32_t domain_id,
> >                                 bool enable);
> >  int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_i=
d,
> >                                    bool enable);
> > +int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enab=
le,
> > +                      bool sync);
> >  /**
> >   * This function enables / disables emulation for each REP for a
> >   * REP-compatible instruction.
> > diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.=
c
> > index 4ac823e775..c5fa62ff30 100644
> > --- a/tools/libs/ctrl/xc_monitor.c
> > +++ b/tools/libs/ctrl/xc_monitor.c
> > @@ -246,6 +246,21 @@ int xc_monitor_emul_unimplemented(xc_interface *xc=
h, uint32_t domain_id,
> >      return do_domctl(xch, &domctl);
> >  }
> >
> > +int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enab=
le,
> > +                      bool sync)
> > +{
> > +    DECLARE_DOMCTL;
> > +
> > +    domctl.cmd =3D XEN_DOMCTL_monitor_op;
> > +    domctl.domain =3D domain_id;
> > +    domctl.u.monitor_op.op =3D enable ? XEN_DOMCTL_MONITOR_OP_ENABLE
> > +                                    : XEN_DOMCTL_MONITOR_OP_DISABLE;
> > +    domctl.u.monitor_op.event =3D XEN_DOMCTL_MONITOR_EVENT_VMEXIT;
> > +    domctl.u.monitor_op.u.vmexit.sync =3D sync;
> > +
> > +    return do_domctl(xch, &domctl);
> > +}
> > +
> >  /*
> >   * Local variables:
> >   * mode: C
> > diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
> > index b44a1e1dfe..64a38e8fa7 100644
> > --- a/xen/arch/x86/hvm/monitor.c
> > +++ b/xen/arch/x86/hvm/monitor.c
> > @@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, gfn_=
t gfn, uint32_t pfec,
> >      return monitor_traps(curr, true, &req) >=3D 0;
> >  }
> >
> > +int hvm_monitor_vmexit(unsigned long exit_reason,
> > +                       unsigned long exit_qualification)
>
> Should this maybe live in vmx code or have 'vmx' in the name
> somewhere, so that if an svm counterpart is added this doesn't need to
> be renamed?

I don't follow. Why would this need to be renamed? I would presume the
same function would be used on both if it comes to that, perhaps with
a unified input structure if the two are not compatible as-is. In any
case, there is no vm_event/monitor support for AMD at all (not just
for this particular event type) and no plans on adding it any time
soon so IMHO we should cross that bridge when and if that becomes
necessary.

>
> > +{
> > +    struct vcpu *curr =3D current;
> > +    struct arch_domain *ad =3D &curr->domain->arch;
> > +    vm_event_request_t req =3D {};
> > +
> > +    ASSERT(ad->monitor.vmexit_enabled);
> > +
> > +    req.reason =3D VM_EVENT_REASON_VMEXIT;
> > +    req.u.vmexit.reason =3D exit_reason;
> > +    req.u.vmexit.qualification =3D exit_qualification;
>
> You could set those fields at definition.

Sure, but this is the established style throughout the file.

> > +
> > +    set_npt_base(curr, &req);
> > +
> > +    return monitor_traps(curr, ad->monitor.vmexit_sync, &req);
> > +}
> > +
> >  /*
> >   * Local variables:
> >   * mode: C
> > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> > index c075370f64..2794db46f9 100644
> > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > @@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *re=
gs)
> >          }
> >      }
> >
> > +    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
> > +    {
> > +        int rc;
> > +
> > +        __vmread(EXIT_QUALIFICATION, &exit_qualification);
> > +        rc =3D hvm_monitor_vmexit(exit_reason, exit_qualification);
> > +        if ( rc < 0 )
> > +            goto exit_and_crash;
> > +        if ( rc )
> > +            return;
> > +    }
>
> Just for my understanding, is there any reason to not do this before
> updating the altp2m?  AFAICT the update of the active EPTP won't
> affect the call to hvm_monitor_vmexit.

The currently active altp2m information is included in the vm_event
that will be sent out, so it is good to have the correct info for it.
I don't currently plan on using altp2m with this particular even type
but we should make sure it doesn't send out stale info in case someone
wants to use it differently. Certainly no point in sending the event
before it as the exit condition in the altp2m update blob is really
just dead code and can't actually be reached.

>
> > +
> >      /* XXX: This looks ugly, but we need a mechanism to ensure
> >       * any pending vmresume has really happened
> >       */
> > diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/a=
sm/domain.h
> > index e62e109598..855db352c0 100644
> > --- a/xen/arch/x86/include/asm/domain.h
> > +++ b/xen/arch/x86/include/asm/domain.h
> > @@ -430,6 +430,8 @@ struct arch_domain
> >           */
> >          unsigned int inguest_pagefault_disabled                       =
     : 1;
> >          unsigned int control_register_values                          =
     : 1;
> > +        unsigned int vmexit_enabled                                   =
     : 1;
> > +        unsigned int vmexit_sync                                      =
     : 1;
> >          struct monitor_msr_bitmap *msr_bitmap;
> >          uint64_t write_ctrlreg_mask[4];
> >      } monitor;
> > diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/incl=
ude/asm/hvm/monitor.h
> > index a75cd8545c..639f6dfa37 100644
> > --- a/xen/arch/x86/include/asm/hvm/monitor.h
> > +++ b/xen/arch/x86/include/asm/hvm/monitor.h
> > @@ -51,6 +51,8 @@ bool hvm_monitor_emul_unimplemented(void);
> >
> >  bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec=
,
> >                             uint16_t kind);
> > +int hvm_monitor_vmexit(unsigned long exit_reason,
> > +                       unsigned long exit_qualification);
> >
> >  #endif /* __ASM_X86_HVM_MONITOR_H__ */
> >
> > diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/=
asm/monitor.h
> > index 01c6d63bb9..d8d54c5f23 100644
> > --- a/xen/arch/x86/include/asm/monitor.h
> > +++ b/xen/arch/x86/include/asm/monitor.h
> > @@ -89,7 +89,8 @@ static inline uint32_t arch_monitor_get_capabilities(=
struct domain *d)
> >                      (1U << XEN_DOMCTL_MONITOR_EVENT_DEBUG_EXCEPTION) |
> >                      (1U << XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG) |
> >                      (1U << XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED=
) |
> > -                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT)=
);
> > +                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT)=
 |
> > +                    (1U << XEN_DOMCTL_MONITOR_EVENT_VMEXIT));
> >
> >      if ( hvm_is_singlestep_supported() )
> >          capabilities |=3D (1U << XEN_DOMCTL_MONITOR_EVENT_SINGLESTEP);
> > diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
> > index 3079726a8b..30ca71432c 100644
> > --- a/xen/arch/x86/monitor.c
> > +++ b/xen/arch/x86/monitor.c
> > @@ -332,6 +332,20 @@ int arch_monitor_domctl_event(struct domain *d,
> >          break;
> >      }
> >
> > +    case XEN_DOMCTL_MONITOR_EVENT_VMEXIT:
> > +    {
> > +        bool old_status =3D ad->monitor.vmexit_enabled;
> > +
> > +        if ( unlikely(old_status =3D=3D requested_status) )
> > +            return -EEXIST;
>
> What about if the requested status is the same as the current one, but
> vmexit sync is not?

You need to clear the currently registered event first, then register
the new one.

> IOW, I'm not sure this check is helpful, and you could likely avoid
> the old_status local variable.

It is helpful on the callee side. Usually the callee needs to keep
track of the state of what events are enabled so that it can clean up
after itself and if it ever runs into trying to set the event to
something it's already set to then that indicates its state being
out-of-sync.

>
> > +
> > +        domain_pause(d);
> > +        ad->monitor.vmexit_enabled =3D requested_status;
> > +        ad->monitor.vmexit_sync =3D mop->u.vmexit.sync;
> > +        domain_unpause(d);
> > +        break;
> > +    }
> > +
> >      default:
> >          /*
> >           * Should not be reached unless arch_monitor_get_capabilities(=
) is
> > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> > index b85e6170b0..4803ed7afc 100644
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -1057,6 +1057,7 @@ struct xen_domctl_psr_cmt_op {
> >  #define XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED    10
> >  /* Enabled by default */
> >  #define XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT     11
> > +#define XEN_DOMCTL_MONITOR_EVENT_VMEXIT                12
> >
> >  struct xen_domctl_monitor_op {
> >      uint32_t op; /* XEN_DOMCTL_MONITOR_OP_* */
> > @@ -1107,6 +1108,11 @@ struct xen_domctl_monitor_op {
> >              /* Pause vCPU until response */
> >              uint8_t sync;
> >          } debug_exception;
> > +
> > +        struct {
> > +            /* Send event and don't process vmexit */
> > +            uint8_t sync;
> > +        } vmexit;
> >      } u;
> >  };
> >
> > diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_even=
t.h
> > index 81c2ee28cc..07f106f811 100644
> > --- a/xen/include/public/vm_event.h
> > +++ b/xen/include/public/vm_event.h
> > @@ -175,6 +175,8 @@
> >  #define VM_EVENT_REASON_DESCRIPTOR_ACCESS       13
> >  /* Current instruction is not implemented by the emulator */
> >  #define VM_EVENT_REASON_EMUL_UNIMPLEMENTED      14
> > +/* VMEXIT */
> > +#define VM_EVENT_REASON_VMEXIT                  15
> >
> >  /* Supported values for the vm_event_write_ctrlreg index. */
> >  #define VM_EVENT_X86_CR0    0
> > @@ -394,6 +396,11 @@ struct vm_event_emul_insn_data {
> >      uint8_t data[16]; /* Has to be completely filled */
> >  };
> >
> > +struct vm_event_vmexit {
> > +    uint64_t reason;
> > +    uint64_t qualification;
> > +};
>
> You are exposing an Intel specific interface publicly here.  Might be
> worth adding a note, and/or adding 'intel' or 'vmx' in the structure
> name: vm_event_vmx_exit, so that a vm_event_svm_exit could also be
> added in the future.

All vm_event monitor events are for vmx only right now. We can
certainly do that abstraction if and when someone decides to add svm
support, the ABI is versioned and no structure here is set in stone.
No guarantees are even implied for the structures to remain the same
in any way between one version of the ABI to the next. So with that I
don't see the need for complicating the structures at this time.

Tamas


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 16:27:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 16:27:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313147.530607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj1Xv-0000y8-S7; Mon, 25 Apr 2022 16:26:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313147.530607; Mon, 25 Apr 2022 16:26:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj1Xv-0000y1-Ow; Mon, 25 Apr 2022 16:26:43 +0000
Received: by outflank-mailman (input) for mailman id 313147;
 Mon, 25 Apr 2022 16:26:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj1Xu-0000xr-QS; Mon, 25 Apr 2022 16:26:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj1Xu-0007hL-Om; Mon, 25 Apr 2022 16:26:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj1Xu-000423-AF; Mon, 25 Apr 2022 16:26:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj1Xu-0005Ll-9n; Mon, 25 Apr 2022 16:26:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=H/lI7DGQtFZzgDnltuLRH8/LkgfKG4bgEWP5+aybuwM=; b=fIgmIkuKXlh0ySe5OJObAMAaED
	fI5FWGDNBjFvD1/lWqzFSTNRBsXS4RtM1L0wZvJfi4ogu3Pps+fopJMJlZKg+DCrdfGSqFEKxvGe8
	JxjihJlFCP6h46BaG4o3RNs/10nCMfTGanbGdkTNqORpYMqlElkRMBGND0k5SEg1QDhE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169710-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169710: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 16:26:42 +0000

flight 169710 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169710/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  623 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 16:40:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 16:40:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313156.530618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj1l6-0003QK-6w; Mon, 25 Apr 2022 16:40:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313156.530618; Mon, 25 Apr 2022 16:40:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj1l6-0003QD-3w; Mon, 25 Apr 2022 16:40:20 +0000
Received: by outflank-mailman (input) for mailman id 313156;
 Mon, 25 Apr 2022 16:40:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sCC+=VD=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nj1l4-0003Q7-4P
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 16:40:18 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 61d607bb-c4b6-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 18:40:16 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650904806180862.5046296680043;
 Mon, 25 Apr 2022 09:40:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61d607bb-c4b6-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650904811; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=mWCJzmsJNq8Hyv2eKRVDQIDWMXQ22kXT3GCWqPyvXt7D+Zzc1xBNK/l6/EMVIH2Ot5QPYiYfaGqccmqF9yUUgYi59gcGImJNC14sXkpl6jXTmW/tlVzoeAk6qAI6Fx8B6YplCxquBnzt7SUcGxlGvf8AENhZsGpWxIaxDzoRZGs=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650904811; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=ZSHKqxplFaoyQHqPsuyiLL3AeTm49HrjGqGEx9onC2s=; 
	b=N0Zo7Df5eWb70BC7opogI7PlsbhDNw9gpn0KQTOScYw0bW+6TgJC6JpyOVWASZelzmAk1yuPVfGrA2FEs3R33NIhj8oT7KJe304FOhq/lypoZpbriR2PiT+k7j0xZToo8frdOzlrcUDAXJDQRXmEXwee7k4BKnUhPz7SQf8G4OQ=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650904811;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=ZSHKqxplFaoyQHqPsuyiLL3AeTm49HrjGqGEx9onC2s=;
	b=lsWyR3A9+XMU4Kp3Q3abyHzR1a9R1qmKCY+vLzD5p6nCFkGg+Sx4Zh4rE3qe3IM7
	eJXDYP6OsMpQrM+tw63Ju8qsXlYpACFMKNOWqR/q7Avbd7TQEdlVkMsD9S93oXkvA1F
	yAqAoYjVkL8oSRGX/14ZumRnnHJ7dQ5qD9xbE798=
Message-ID: <25e701d4-62ae-278d-b165-2201459c7cee@apertussolutions.com>
Date: Mon, 25 Apr 2022 12:39:17 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Jan Beulich
 <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
 <20220422163458.30170-2-dpsmith@apertussolutions.com>
 <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote
 after setup
In-Reply-To: <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 4/25/22 05:44, Roger Pau Monné wrote:
> On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
>> There are now instances where internal hypervisor logic needs to make resource
>> allocation calls that are protected by XSM checks. The internal hypervisor logic
>> is represented a number of system domains which by designed are represented by
> 
> 'Some of the hypervisor code can be executed in a system domain that's
> represented by a per-CPU non-privileged struct domain. To enable...'

Ack, will reword.

>> non-privileged struct domain instances. To enable these logic blocks to
>> function correctly but in a controlled manner, this commit changes the idle
>> domain to be created as a privileged domain under the default policy, which is
>> inherited by the SILO policy, and demoted before transitioning to running. A
>> new XSM hook, xsm_set_system_active, is introduced to allow each XSM policy
>> type to demote the idle domain appropriately for that policy type.
>>
>> For flask a stub is added to ensure that flask policy system will function
>> correctly with this patch until flask is extended with support for starting the
>> idle domain privileged and properly demoting it on the call to
>> xsm_set_system_active.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
>>  xen/arch/arm/setup.c    |  3 +++
>>  xen/arch/x86/setup.c    |  3 +++
>>  xen/common/sched/core.c |  7 ++++++-
>>  xen/include/xsm/dummy.h | 17 +++++++++++++++++
>>  xen/include/xsm/xsm.h   |  6 ++++++
>>  xen/xsm/dummy.c         |  1 +
>>  xen/xsm/flask/hooks.c   | 21 +++++++++++++++++++++
>>  7 files changed, 57 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>> index d5d0792ed4..e71fa3f860 100644
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset,
>>      /* Hide UART from DOM0 if we're using it */
>>      serial_endboot();
>>  
>> +    if ( xsm_set_system_active() != 0)
>> +        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
>> +
>>      system_state = SYS_STATE_active;
>>  
>>      for_each_domain( d )
>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
>> index 6f20e17892..a3ce288ef9 100644
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
>>      void *va;
>>      unsigned long start, end;
>>  
>> +    if ( xsm_set_system_active() != 0)
>            ^ extra space.
> 
> Since the function returns an error code you might as well add it to
> the panic message, or else just make the function return bool instead.
> 
> Or just make the function void and panic in the handler itself (like
> in previous versions), as I don't think it's sensible to continue
> normal execution if xsm_set_system_active fails.

After reflecting on it, I believe that was not the correct action. The
policy should handle setting/checking all access control state and fail
with an error of why and then allow the hypervisor logic decided what to
do with that failure. For the policies that are present today, yes it is
an immediate panic. Ultimately this will future proof the interface
should a future policy type be introduced with a more varied result that
could allow the hypervisor to continue to boot, for instance to a
limited and/or debug state.

>> +        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
>> +
>>      system_state = SYS_STATE_active;
>>  
>>      domain_unpause_by_systemcontroller(dom0);
>> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
>> index 19ab678181..22a619e260 100644
>> --- a/xen/common/sched/core.c
>> +++ b/xen/common/sched/core.c
>> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
>>          sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
>>      }
>>  
>> -    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
>> +    /*
>> +     * idle dom is created privileged to ensure unrestricted access during
>> +     * setup and will be demoted by xsm_transition_running when setup is
> 
> s/xsm_transition_running/xsm_set_system_active/

I missed one, apologies.

>> +     * complete
> 
> Nit: missing full stop according to CODING_STYLE.

Ack.

>> +     */
>> +    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
>>      BUG_ON(IS_ERR(idle_domain));
>>      BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
>>      idle_domain->vcpu = idle_vcpu;
>> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
>> index 58afc1d589..3291fb5396 100644
>> --- a/xen/include/xsm/dummy.h
>> +++ b/xen/include/xsm/dummy.h
>> @@ -101,6 +101,23 @@ static always_inline int xsm_default_action(
>>      }
>>  }
>>  
>> +static XSM_INLINE int cf_check xsm_set_system_active(void)
>> +{
>> +    struct domain *d = current->domain;
>> +
>> +    ASSERT(d->is_privileged);
>> +
>> +    if ( d->domain_id != DOMID_IDLE )
>> +    {
>> +        printk("xsm_set_system_active: should only be called by idle domain\n");
>> +        return -EPERM;
>> +    }
>> +
>> +    d->is_privileged = false;
>> +
>> +    return 0;
>> +}
>> +
>>  static XSM_INLINE void cf_check xsm_security_domaininfo(
>>      struct domain *d, struct xen_domctl_getdomaininfo *info)
>>  {
>> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
>> index 3e2b7fe3db..8dad03fd3d 100644
>> --- a/xen/include/xsm/xsm.h
>> +++ b/xen/include/xsm/xsm.h
>> @@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t;
>>   * !!! WARNING !!!
>>   */
>>  struct xsm_ops {
>> +    int (*set_system_active)(void);
>>      void (*security_domaininfo)(struct domain *d,
>>                                  struct xen_domctl_getdomaininfo *info);
>>      int (*domain_create)(struct domain *d, uint32_t ssidref);
>> @@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops;
>>  
>>  #ifndef XSM_NO_WRAPPERS
>>  
>> +static inline int xsm_set_system_active(void)
>> +{
>> +    return alternative_call(xsm_ops.set_system_active);
>> +}
>> +
>>  static inline void xsm_security_domaininfo(
>>      struct domain *d, struct xen_domctl_getdomaininfo *info)
>>  {
>> diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
>> index 8c044ef615..e6ffa948f7 100644
>> --- a/xen/xsm/dummy.c
>> +++ b/xen/xsm/dummy.c
>> @@ -14,6 +14,7 @@
>>  #include <xsm/dummy.h>
>>  
>>  static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
>> +    .set_system_active             = xsm_set_system_active,
>>      .security_domaininfo           = xsm_security_domaininfo,
>>      .domain_create                 = xsm_domain_create,
>>      .getdomaininfo                 = xsm_getdomaininfo,
>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
>> index 0bf63ffa84..8a62de2fd6 100644
>> --- a/xen/xsm/flask/hooks.c
>> +++ b/xen/xsm/flask/hooks.c
>> @@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>>      return 0;
>>  }
>>  
>> +static int cf_check flask_set_system_active(void)
>> +{
>> +    struct domain *d = current->domain;
> 
> Nit: you should also add the assert for d->is_privileged, I don't see
> a reason for the xsm and flask functions to differ in that regard.

This goes back to an issued I have raised before, is_privileged really
encompasses two properties of a domain. Whether the domain is filling
the special control domain role versus what accesses the domain has
based on the context under which is_control_domain() is called. For
instance the function init_domain_msr_policy() uses is_control_domain()
not to make an access control decision but configure behavior. Under
flask is_privileged no longer reflects the accesses a domain with it set
will have, thus whether it is cleared when flask is enabled is
irrelevant as far as flask is concerned. For the ASSERT, what matters is
that the label was set to xenboot_t on construction and that it was not
changed before reaching this point. Or in a short form, when under the
default policy the expected state is concerned with is_privilege while
for flask it is only the SID.


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 16:43:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 16:43:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313162.530629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj1ne-0004Cx-Ma; Mon, 25 Apr 2022 16:42:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313162.530629; Mon, 25 Apr 2022 16:42:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj1ne-0004Cq-IB; Mon, 25 Apr 2022 16:42:58 +0000
Received: by outflank-mailman (input) for mailman id 313162;
 Mon, 25 Apr 2022 16:42:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sCC+=VD=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nj1nc-0004Ch-Ux
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 16:42:56 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c1180422-c4b6-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 18:42:55 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650904970169140.77981176062337;
 Mon, 25 Apr 2022 09:42:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c1180422-c4b6-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650904972; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=GOZuL7rHmbOLcLD18zgWFg8YXScDUFvS8LClTmJEE6CNiQvrd7QApmLutrqWOCajaM7MTHEsljL9i05CD1+076/fHrcmErzm9lkHqDFt1JDnmbktLI4BxxOpSv3rn+mNf0duPHtEgEjgV2PPs99Wzm2ScAszNEXN2aAkrYRNLkI=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650904972; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=fdPdl1eYR2TgNCzIg4GWQ8agZHJt3bxu/2KlgAWoj+0=; 
	b=EHl1h23WA0SY8CwLbQUkq5UxlTy2PoOPMVwmEcdf/zDVy8rJKhdd4GTxkbi89BtumiPOuU7kEp/+wjdrYa3xYwQAP+b6dEq8Zl+VgvJvPg7qZ8z7jVIUaF9a/aFez5YwBGFRy41GTNA4/q6F4toj35QWzbtuu/UQ7vJO+gvUrZY=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650904972;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=fdPdl1eYR2TgNCzIg4GWQ8agZHJt3bxu/2KlgAWoj+0=;
	b=aNxrWD9mG/lmMNYjdSR8sq2bLFX0TGRIb39MOQvcxm7RFlgnmElDSIRUbqFwad96
	IkYoQbEBP4k94qao/D5GnoEnAY4lcmFw5GyAfQCRlLOXtDE+b3Eqrv8AeHsl8RBZmsG
	IgT7A1dc6w+a0RgZYhn0eCTgCvOR+tYA9GNmsH24=
Message-ID: <cf5e1151-a33f-8699-153c-4db7cf474576@apertussolutions.com>
Date: Mon, 25 Apr 2022 12:42:02 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v3 2/2] flask: implement xsm_set_system_active
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Scott Davis <scott.davis@starlab.io>, Daniel De Graaf
 <dgdegra@tycho.nsa.gov>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
 <20220422163458.30170-3-dpsmith@apertussolutions.com>
 <CAKf6xptRBMwjrE_m+rQEoS+ZoC=7qFO+NGg3eUQYuC6x66Uauw@mail.gmail.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
In-Reply-To: <CAKf6xptRBMwjrE_m+rQEoS+ZoC=7qFO+NGg3eUQYuC6x66Uauw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/22/22 12:58, Jason Andryuk wrote:
> On Fri, Apr 22, 2022 at 12:35 PM Daniel P. Smith
> <dpsmith@apertussolutions.com> wrote:
>>
>> This commit implements full support for starting the idle domain privileged by
>> introducing a new flask label xenboot_t which the idle domain is labeled with
>> at creation.  It then provides the implementation for the XSM hook
>> xsm_set_system_active to relabel the idle domain to the existing xen_t flask
>> label.
>>
>> In the reference flask policy a new macro, xen_build_domain(target), is
>> introduced for creating policies for dom0less/hyperlaunch allowing the
>> hypervisor to create and assign the necessary resources for domain
>> construction.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> ---
> 
>> @@ -188,8 +188,12 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>>
>>  static int cf_check flask_set_system_active(void)
>>  {
>> +    struct domain_security_struct *dsec;
>>      struct domain *d = current->domain;
>>
>> +    dsec = d->ssid;
>> +    ASSERT( dsec->sid == SECINITSID_XENBOOT);
> 
> Extra space before dsec.

Ack.

> With that fixed,
> Reviewed-by: Jason Andryuk <jandryuk@gmail.com>


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 17:00:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 17:00:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313170.530640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj24n-0006ht-4S; Mon, 25 Apr 2022 17:00:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313170.530640; Mon, 25 Apr 2022 17:00:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj24n-0006hm-1L; Mon, 25 Apr 2022 17:00:41 +0000
Received: by outflank-mailman (input) for mailman id 313170;
 Mon, 25 Apr 2022 17:00:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj24l-0006hc-O8; Mon, 25 Apr 2022 17:00:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj24l-0008JC-JG; Mon, 25 Apr 2022 17:00:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj24l-0004ka-Br; Mon, 25 Apr 2022 17:00:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj24l-000500-BF; Mon, 25 Apr 2022 17:00:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uCUIzt3YI9HVCc2MdvL2rT3lAqo4XnBc5qOQ8/yDySM=; b=g9Czm4OAaxz5y6EXY7s1voxV2l
	9T0DpmGe6geop7zJe2JoHdyDm7TxnYrEup8WHC/JBIAR9OWTmY/AV+iYkhlRcJBKOE/OH9iIHEivD
	nv54ghNIixYTU9kVJ3supil6f7B2LJUqMcp82UK3Vs1sr64I5cOXcXrY4M/ZmQS2HHwE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169711-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169711: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 17:00:39 +0000

flight 169711 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169711/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  624 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 17:19:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 17:19:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313180.530650 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2Mi-00009k-Ny; Mon, 25 Apr 2022 17:19:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313180.530650; Mon, 25 Apr 2022 17:19:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2Mi-00009b-KT; Mon, 25 Apr 2022 17:19:12 +0000
Received: by outflank-mailman (input) for mailman id 313180;
 Mon, 25 Apr 2022 17:19:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=t3J5=VD=phptrix.de=einsle@srs-se1.protection.inumbo.net>)
 id 1nj2Mh-00009Q-Of
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 17:19:11 +0000
Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d1c97b61-c4bb-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 19:19:10 +0200 (CEST)
Received: from mail.phptrix.de ([93.233.17.36]) by mrelayeu.kundenserver.de
 (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id
 1MBltK-1nbMrh1wx2-00C8jO for <xen-devel@lists.xenproject.org>; Mon, 25 Apr
 2022 19:19:09 +0200
Received: (qmail 15505 invoked by uid 210); 25 Apr 2022 19:19:08 +0200
Received: from rhombus.phptrix.de (HELO ?192.168.139.169?)
 (einsle@192.168.139.169)
 by portfish.phptrix.de with ESMTPA; 25 Apr 2022 19:19:08 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1c97b61-c4bb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=phptrix.de;
	s=default; h=Message-ID:Date:MIME-Version:User-Agent:To:
	Content-Language:From:Subject:Content-Type:
	Content-Transfer-Encoding; bh=4UfAQPyV98urAiFS1w8+89YVdLw=; b=IY
	wRLAUKn/mBEHWMbayerC6COgY3Br8WcaqLWHSbREFLKwvwXClw9tdfPX9XyxstDj
	C2cme8c5Ky33mn63dMCyLHI5CWz/4RQ94LPp8rwQvqQj0KrZlKCZlgaaDkWViLwH
	NnkkUyHG2915YnT2wjrQyHG5tFft2pMCuEIweVseA=
DomainKey-Signature: a=rsa-sha1; q=dns; c=simple;
  s=default; d=phptrix.de;
  b=Zln6VEjByRAM4gG7yMHcBy/2est7Q2jfwBFgu6xMGOBxJrjkr3SDSSPgKpKhdmtWGPRogV55Y/hoBhvXrX3X9ODzs1p9NXDdClYES2H0V+OSQRneZpF8xbqtD0tLolK6CrOt2iYE6oHUx682EJ4o2WuwObykc0TE/u8xAERpLcA=;
X-Qmail-Scanner-Diagnostics: from rhombus.phptrix.de (einsle@rhombus.phptrix.de) by portfish (envelope-from <einsle@phptrix.de>, uid 201) with qmail-scanner-2.11st 
 (clamdscan: 0.100.1/26337. spamassassin: 3.4.1. perlscan: 2.11st.  
 Clear:RC:1(192.168.139.169):. 
 Processed in 0.021636 secs); 25 Apr 2022 17:19:08 -0000
Message-ID: <18bd542a-a649-c78b-b575-c62b4d533e44@phptrix.de>
Date: Mon, 25 Apr 2022 19:19:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101
 Thunderbird/100.0
To: xen-devel@lists.xenproject.org
Content-Language: de-DE
From: Steffen Einsle <einsle@phptrix.de>
Subject: DomU Windows Server Essentials crashes with xen 4.16 but works with
 xen 4.14
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K1:EPwCpCi73g/zq/68nNA0dEnyalW0bj1HKsh9WuwGSXtq6pbrGus
 UCJNtV2pulSvtUwekM+i1hhHToT5hFQCPlrWnK+8s9LxhV3u5jSYrOhwUm+sPgVT7ozriLn
 Pl11MRXeUmDcqIPPpdZwH2IbRgLbbmuCEGGhH0vPd5tXQV65kAAckj2let5HCdQ6BiBZww9
 v4tzEDn0LgGmp9mFVdLAA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:GpPV7pM/Vzk=:/bSCkh3z/Wk/2FcNorMQXr
 jdaVEcpuPm6G/MWPLPimhKzYn7kJcy6fUKfM/aJWIiuX2dgeibDsvmRqQytBVDPiTA7RuXUc+
 VKx5rb5vFe/skhFJgAGelaVa0kvhM4EFZBPYq+auIWmegNVup0K3frnYp6nxYHkhXF6r6/u4n
 9kQYM2lD7V+CF6C2Ms3aPny0pAEpFCOX8BpnTQJr5JxIPMxknv0k6KRxqj61vrI2yoBIoX4dF
 TprEjZ5NziH/Sia38SOBWYdDMjdCv015VkoMh+i68/qs7oQjUvwTgd5DIuiqJXnLbSzgkDppE
 84HLzO4GlWtKhfqjqtmZ4yg0skM81lXa8WhR3vrmxF9yuw1gK5VvXqtFp/QKuqvruhhdjvq7T
 KI7YfsHW1PCrFeTIIIf94qfHrpdPimSXFbrlhGzzf8ze+OSLc1iWi9RdhLMWB4iBPcf1XOh9y
 G7/MAKiacSpKF+HeB+Is8Sa+g6oVaMPKQDTDil3YGxUSJ6bMUj/4NjrsS7uwjFf+8rYIhp7YJ
 FnFw6dqBQszvu4gxVj/oGLA8w1SQyJ7ly1zKjueTlhh5E1azNEJJTFovc2U6mNprM9xJIdMlJ
 zEQaEo/uZUbsHDlyZWvXvNkH6HdkVvWZySHshUiMvoK+GeDQvPskqxE5KxklauseUfRUKPL/j
 MaOsl6SqL3BQ4+HGnXHVtlSgK1bRIcikI3w7I25LTvvp637IX2NH8K7oN3HR3/s3IFBw=

Hello Everyone,

I have some xen servers I recently tried to update from xen 4.14 to xen 4.16

Everything worked without problem, except for the Windows Server 
Essentials DomUs.

With xen 4.16 those domains crashed (reproducable) during boot - 
KMODE_EXCEPTION_NOT_HANDLED.

I tried to install a new DomU Windows Server 2019 Essentials - this VM 
crashed at the first reboot
(still in the installation routine) with the same error. No PV-drivers 
installed yet.

I switched back to xen 4.14 and all VMs booted ok without problem.

All other VMs (Linux-PV, Windows-HVM (2008r2, 2012r2, 2016, 2019, 2022)  
show no problems, only
the Windows Server Essentials crashes with xen 4.16.

The system is a gentoo kernel 5.17.3, qemu-6.2.0-r4, xen-4.16.0-r5, 
xen-tools-4.16.0-r1

My working configuration is gentoo kernel 5.17.3, qemu-5.2.0-r2, 
xen-4.14.3-r2, xen-tools-4.14.3

My DomU config file looks like this

name = 'DC-Server'
type = 'hvm'
memory = '8192'
vcpus = '6'
vif = [ 'mac=00:16:3E:ab:cd:50,bridge=br0' ]
disk = [ '/dev/vg1/ServerSys,raw,hda,rw',
               '/dev/vg1/ServerData,raw,hdb,rw' ]
viridian = 'all'
localtime = '1'
vnc = '1'
keymap = 'de'
vnclisten = '0.0.0.0:10,websocket'
usb = '1'
usbdevice = 'tablet'
on_crash  = 'restart'
boot = 'c'
xen_platform_pci = '1'
max_grant_frames = 128

I tried disabling viridian but this made no change.

Is this a known problem?


-- 

Steffen




From xen-devel-bounces@lists.xenproject.org Mon Apr 25 17:22:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 17:22:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313187.530661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2QC-0001mL-Bt; Mon, 25 Apr 2022 17:22:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313187.530661; Mon, 25 Apr 2022 17:22:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2QC-0001mE-8Z; Mon, 25 Apr 2022 17:22:48 +0000
Received: by outflank-mailman (input) for mailman id 313187;
 Mon, 25 Apr 2022 17:22:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sCC+=VD=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nj2QA-0001m7-NJ
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 17:22:46 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5160dcd0-c4bc-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 19:22:45 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650907358533423.51309031262167;
 Mon, 25 Apr 2022 10:22:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5160dcd0-c4bc-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650907362; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=ESfvTbpA7jL2dBIsUgFquA4az2OLW0ndJHK12tWRVo9W2qaETbyVKENcDbZAZ3RR8m/61cBQAQN7u8vuPX/xaS1TPIy2xkJAFit6yBspZwbZmtkczpxAONpE4Lxbs9PkjnF32lLqxKXB+8R79VJ6HF3b7J5Xe0zRZ5IRBcxV/b0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650907362; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=jb7DIZpJG+PpAxtH2k2IxIIsQBdNEM3UGi2u20z+AQk=; 
	b=IbLR76Jb7CgrZHul9DN0ibscjXinJU+VZyebmoMahK0O0V7mIpjahbl4rLTBinzziRbX5Oxkmw44rmvGX9CgirJPujcCINyeuB0CP0L3jgPwLmMe8dD3kHmSqT3DS+E9uyDIMFlQ8tSUfxTZsJ59P1nR5xkb2M3XJU/4xeLZteI=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650907362;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=jb7DIZpJG+PpAxtH2k2IxIIsQBdNEM3UGi2u20z+AQk=;
	b=GpRypCL/1JIRBNFFROpBVuse5JNiHQjkZeARLYeaLBnj42Cv6/FcM1ODiQxEMSde
	kfBC3nkgtzbaPJHWrmmpoBFJdA05fn6+v+GBgaRJJhDYT1VaxDBD/NhxDPMUZdQErDn
	EbODTBsJUiokJk+qS1lldq0enHg0EFihOGgXZpkI=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	scott.davis@starlab.io,
	jandryuk@gmail.com
Subject: [PATCH v4 0/2] Adds starting the idle domain privileged
Date: Mon, 25 Apr 2022 13:22:29 -0400
Message-Id: <20220425172231.27401-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This series makes it so that the idle domain is started privileged under the
default policy, which the SILO policy inherits, and under the flask policy. It
then introduces a new one-way XSM hook, xsm_transition_running, that is hooked
by an XSM policy to transition the idle domain to its running privilege level.

Changes in v4:
- reworded patch 1 commit messaged
- fixed whitespace to coding style
- fixed comment to coding style

Changes in v3:
- renamed *_transition_running() to *_set_system_active()
- changed the XSM hook set_system_active() from void to int return
- added ASSERT check for the expected privilege level each XSM policy expected
- replaced a check against is_privileged in each arch with checking the return
  value from the call to xsm_set_system_active()

Changes in v2:
- renamed flask_domain_runtime_security() to flask_transition_running()
- added the missed assignment of self_sid

Daniel P. Smith (2):
  xsm: create idle domain privileged and demote after setup
  flask: implement xsm_set_system_active

 tools/flask/policy/modules/xen.if      |  6 ++++++
 tools/flask/policy/modules/xen.te      |  1 +
 tools/flask/policy/policy/initial_sids |  1 +
 xen/arch/arm/setup.c                   |  3 +++
 xen/arch/x86/setup.c                   |  3 +++
 xen/common/sched/core.c                |  7 ++++++-
 xen/include/xsm/dummy.h                | 17 +++++++++++++++
 xen/include/xsm/xsm.h                  |  6 ++++++
 xen/xsm/dummy.c                        |  1 +
 xen/xsm/flask/hooks.c                  | 29 +++++++++++++++++++++++++-
 xen/xsm/flask/policy/initial_sids      |  1 +
 11 files changed, 73 insertions(+), 2 deletions(-)

-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 17:22:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 17:22:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313188.530673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2QH-000249-Jj; Mon, 25 Apr 2022 17:22:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313188.530673; Mon, 25 Apr 2022 17:22:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2QH-000240-G3; Mon, 25 Apr 2022 17:22:53 +0000
Received: by outflank-mailman (input) for mailman id 313188;
 Mon, 25 Apr 2022 17:22:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sCC+=VD=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nj2QF-0001m7-Hk
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 17:22:51 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 547a57f6-c4bc-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 19:22:50 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 165090736101574.01795310864475;
 Mon, 25 Apr 2022 10:22:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 547a57f6-c4bc-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650907364; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=Ax7o3r8U6B4PFgzUw5bx5r5LBu41GigSNecUltuuR8dSVKqxbPPtGcByzXoFgDjdADU7QKgB1uZXGmjVUff6lm7NXHWOL9n0sjS2mM6pb823DSF7vTfb/O6zGQ3rz6uISOYXYcmKI4ggGXkHITATaLgqXss6mHvF93u3Bx3ELOs=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650907364; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=oWUECp0uPTpkjJDOsexyWnv+2pg/Sqhs5LeSRzZUWDE=; 
	b=EUv11YhBQ0tOe10FRarzQEXENGkwHC6k4Hr+uvouLRTLMaVYAkzXXB5pKl+j07RfbEsFStv0pjQrAd5dxtEFgOpnM9OpFMMME3uPG1+F5mUxjtfmCY7scXme17aR6qDkoH8MUMJbMjKKiBG9K0liFnWhZ8xtszbRJr2Bcwt0PjE=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650907364;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=oWUECp0uPTpkjJDOsexyWnv+2pg/Sqhs5LeSRzZUWDE=;
	b=q7+Vq5H27jfV2rMgnQ1pGolKGQKsX1cUXzzyM5cwDvejg7q1HW84xnh2x5VncO3K
	aPXYPMuv0zooJEuuyopcldSPizgpKZwRFLqYo+36n1w1rP8417RHaWnQtO+czrWk7zF
	KOe2jjbkIOJRJjiSNjyRZAgZYkpevehOAOBPc3qE=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io,
	jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: [PATCH v4 1/2] xsm: create idle domain privileged and demote after setup
Date: Mon, 25 Apr 2022 13:22:30 -0400
Message-Id: <20220425172231.27401-2-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20220425172231.27401-1-dpsmith@apertussolutions.com>
References: <20220425172231.27401-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

There are new capabilities, dom0less and hyperlaunch, that introduce internal
hypervisor logic which needs to make resource allocation calls that are
protected by XSM access checks. This creates an issue as a subset of the
hypervisor code is executed under a system domain, the idle domain, that is
represented by a per-CPU non-privileged struct domain. To enable these new
capabilities to function correctly but in a controlled manner, this commit
changes the idle system domain to be created as a privileged domain under the
default policy and demoted before transitioning to running. A new XSM hook,
xsm_set_system_active(), is introduced to allow each XSM policy type to demote
the idle domain appropriately for that policy type. In the case of SILO, it
inherits the default policy's hook for xsm_set_system_active().

For flask a stub is added to ensure that flask policy system will function
correctly with this patch until flask is extended with support for starting the
idle domain privileged and properly demoting it on the call to
xsm_set_system_active().

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
---
 xen/arch/arm/setup.c    |  3 +++
 xen/arch/x86/setup.c    |  3 +++
 xen/common/sched/core.c |  7 ++++++-
 xen/include/xsm/dummy.h | 17 +++++++++++++++++
 xen/include/xsm/xsm.h   |  6 ++++++
 xen/xsm/dummy.c         |  1 +
 xen/xsm/flask/hooks.c   | 21 +++++++++++++++++++++
 7 files changed, 57 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..dc0bdef6b7 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset,
     /* Hide UART from DOM0 if we're using it */
     serial_endboot();
 
+    if ( xsm_set_system_active() != 0 )
+        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
+
     system_state = SYS_STATE_active;
 
     for_each_domain( d )
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 6f20e17892..e7a0ac9183 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -621,6 +621,9 @@ static void noreturn init_done(void)
     void *va;
     unsigned long start, end;
 
+    if ( xsm_set_system_active() != 0 )
+        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
+
     system_state = SYS_STATE_active;
 
     domain_unpause_by_systemcontroller(dom0);
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab678181..7b1c03a0e1 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
         sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
     }
 
-    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
+    /*
+     * The idle dom is created privileged to ensure unrestricted access during
+     * setup and will be demoted by xsm_set_system_active() when setup is
+     * complete.
+     */
+    idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged);
     BUG_ON(IS_ERR(idle_domain));
     BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
     idle_domain->vcpu = idle_vcpu;
diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index 58afc1d589..3291fb5396 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -101,6 +101,23 @@ static always_inline int xsm_default_action(
     }
 }
 
+static XSM_INLINE int cf_check xsm_set_system_active(void)
+{
+    struct domain *d = current->domain;
+
+    ASSERT(d->is_privileged);
+
+    if ( d->domain_id != DOMID_IDLE )
+    {
+        printk("xsm_set_system_active: should only be called by idle domain\n");
+        return -EPERM;
+    }
+
+    d->is_privileged = false;
+
+    return 0;
+}
+
 static XSM_INLINE void cf_check xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
index 3e2b7fe3db..8dad03fd3d 100644
--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t;
  * !!! WARNING !!!
  */
 struct xsm_ops {
+    int (*set_system_active)(void);
     void (*security_domaininfo)(struct domain *d,
                                 struct xen_domctl_getdomaininfo *info);
     int (*domain_create)(struct domain *d, uint32_t ssidref);
@@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops;
 
 #ifndef XSM_NO_WRAPPERS
 
+static inline int xsm_set_system_active(void)
+{
+    return alternative_call(xsm_ops.set_system_active);
+}
+
 static inline void xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 8c044ef615..e6ffa948f7 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -14,6 +14,7 @@
 #include <xsm/dummy.h>
 
 static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
+    .set_system_active             = xsm_set_system_active,
     .security_domaininfo           = xsm_security_domaininfo,
     .domain_create                 = xsm_domain_create,
     .getdomaininfo                 = xsm_getdomaininfo,
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 0bf63ffa84..8a62de2fd6 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
     return 0;
 }
 
+static int cf_check flask_set_system_active(void)
+{
+    struct domain *d = current->domain;
+
+    if ( d->domain_id != DOMID_IDLE )
+    {
+        printk("xsm_set_system_active should only be called by idle domain\n");
+        return -EPERM;
+    }
+
+    /*
+     * While is_privileged has no significant meaning under flask, set to false
+     * as there are times in hypervisor code privilege checks check this
+     * directly instead of going through XSM.
+     */
+    d->is_privileged = false;
+
+    return 0;
+}
+
 static void cf_check flask_domain_free_security(struct domain *d)
 {
     struct domain_security_struct *dsec = d->ssid;
@@ -1766,6 +1786,7 @@ static int cf_check flask_argo_send(
 #endif
 
 static const struct xsm_ops __initconst_cf_clobber flask_ops = {
+    .set_system_active = flask_set_system_active,
     .security_domaininfo = flask_security_domaininfo,
     .domain_create = flask_domain_create,
     .getdomaininfo = flask_getdomaininfo,
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 17:23:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 17:23:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313193.530684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2Qb-0002kF-Ro; Mon, 25 Apr 2022 17:23:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313193.530684; Mon, 25 Apr 2022 17:23:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2Qb-0002k8-Om; Mon, 25 Apr 2022 17:23:13 +0000
Received: by outflank-mailman (input) for mailman id 313193;
 Mon, 25 Apr 2022 17:23:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sCC+=VD=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nj2Qa-0001m7-DI
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 17:23:12 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 60fb6af2-c4bc-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 19:23:11 +0200 (CEST)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650907363231921.5550060723041;
 Mon, 25 Apr 2022 10:22:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60fb6af2-c4bc-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650907366; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=OlazOEOxrzK71WPG5H8FLehZgfFhBMIxHWiE9u9g3o46mKGyUvf1OYZ4C7hs0IEB5S6PpUO3i61WvUTUyvjGo58jKTc3rheE/Y4NdPwswhSg38qjT7CgcdhelzLcF3acqEclZmDCNmNzzHavdEXZwOWFg0g6MPtBcmU3Dsshw7w=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650907366; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=KWwhu/Y5NhROHWkvOXJZlEXNvPhlxjXhIy0qoopiWYs=; 
	b=eP8FPD14esptgZwJ3FYiRoIlHF4131EjKavFEB7uwscWKHEbjsu8SnT+VD+WIR85CpxZpNJjhIrl0hzsflKTDVaxjBHaWNI+p8D6ovt4fOhjzZ2NsbeBPUNV5cDgnbATOpGAKejblVi3Yfl42BEkDAiQZBtXppYnd9jbW3tDFFE=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650907366;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To;
	bh=KWwhu/Y5NhROHWkvOXJZlEXNvPhlxjXhIy0qoopiWYs=;
	b=TWDLb6r3vZiKb3mne6i3FruqyO2GfsEabmT2Qurqyhs2Nj+Cv78ZWD/wsiTft9v9
	sZBuLEcZHPQ08Dib9X//dotRVKKRPhpxwLDUY2KyPunlAxFm2DlVMIA1L8gHqtYgPLx
	nmzOOcl60cwrnUaxm9GnDIGWkrMn1LAealv+32n4=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io,
	jandryuk@gmail.com,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v4 2/2] flask: implement xsm_set_system_active
Date: Mon, 25 Apr 2022 13:22:31 -0400
Message-Id: <20220425172231.27401-3-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20220425172231.27401-1-dpsmith@apertussolutions.com>
References: <20220425172231.27401-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit implements full support for starting the idle domain privileged by
introducing a new flask label xenboot_t which the idle domain is labeled with
at creation.  It then provides the implementation for the XSM hook
xsm_set_system_active to relabel the idle domain to the existing xen_t flask
label.

In the reference flask policy a new macro, xen_build_domain(target), is
introduced for creating policies for dom0less/hyperlaunch allowing the
hypervisor to create and assign the necessary resources for domain
construction.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
---
 tools/flask/policy/modules/xen.if      | 6 ++++++
 tools/flask/policy/modules/xen.te      | 1 +
 tools/flask/policy/policy/initial_sids | 1 +
 xen/xsm/flask/hooks.c                  | 8 +++++++-
 xen/xsm/flask/policy/initial_sids      | 1 +
 5 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if
index 5e2aa472b6..4ec676fff1 100644
--- a/tools/flask/policy/modules/xen.if
+++ b/tools/flask/policy/modules/xen.if
@@ -62,6 +62,12 @@ define(`create_domain_common', `
 			setparam altp2mhvm altp2mhvm_op dm };
 ')
 
+# xen_build_domain(target)
+#   Allow a domain to be created at boot by the hypervisor
+define(`xen_build_domain', `
+	allow xenboot_t $1_channel:event create;
+')
+
 # create_domain(priv, target)
 #   Allow a domain to be created directly
 define(`create_domain', `
diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modules/xen.te
index 3dbf93d2b8..de98206fdd 100644
--- a/tools/flask/policy/modules/xen.te
+++ b/tools/flask/policy/modules/xen.te
@@ -24,6 +24,7 @@ attribute mls_priv;
 ################################################################################
 
 # The hypervisor itself
+type xenboot_t, xen_type, mls_priv;
 type xen_t, xen_type, mls_priv;
 
 # Domain 0
diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/policy/initial_sids
index 6b7b7eff21..ec729d3ba3 100644
--- a/tools/flask/policy/policy/initial_sids
+++ b/tools/flask/policy/policy/initial_sids
@@ -2,6 +2,7 @@
 # objects created before the policy is loaded or for objects that do not have a
 # label defined in some other manner.
 
+sid xenboot gen_context(system_u:system_r:xenboot_t,s0)
 sid xen gen_context(system_u:system_r:xen_t,s0)
 sid dom0 gen_context(system_u:system_r:dom0_t,s0)
 sid domxen gen_context(system_u:system_r:domxen_t,s0)
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 8a62de2fd6..92eb12ddb1 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
     switch ( d->domain_id )
     {
     case DOMID_IDLE:
-        dsec->sid = SECINITSID_XEN;
+        dsec->sid = SECINITSID_XENBOOT;
         break;
     case DOMID_XEN:
         dsec->sid = SECINITSID_DOMXEN;
@@ -188,8 +188,12 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
 
 static int cf_check flask_set_system_active(void)
 {
+    struct domain_security_struct *dsec;
     struct domain *d = current->domain;
 
+    dsec = d->ssid;
+    ASSERT(dsec->sid == SECINITSID_XENBOOT);
+
     if ( d->domain_id != DOMID_IDLE )
     {
         printk("xsm_set_system_active should only be called by idle domain\n");
@@ -203,6 +207,8 @@ static int cf_check flask_set_system_active(void)
      */
     d->is_privileged = false;
 
+    dsec->self_sid = dsec->sid = SECINITSID_XEN;
+
     return 0;
 }
 
diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/initial_sids
index 7eca70d339..e8b55b8368 100644
--- a/xen/xsm/flask/policy/initial_sids
+++ b/xen/xsm/flask/policy/initial_sids
@@ -3,6 +3,7 @@
 #
 # Define initial security identifiers 
 #
+sid xenboot
 sid xen
 sid dom0
 sid domio
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 17:29:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 17:29:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313205.530695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2Wh-0003ah-Hi; Mon, 25 Apr 2022 17:29:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313205.530695; Mon, 25 Apr 2022 17:29:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2Wh-0003aa-EP; Mon, 25 Apr 2022 17:29:31 +0000
Received: by outflank-mailman (input) for mailman id 313205;
 Mon, 25 Apr 2022 17:29:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj2Wg-0003aQ-9d; Mon, 25 Apr 2022 17:29:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj2Wg-0000N7-7i; Mon, 25 Apr 2022 17:29:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj2Wf-0005Nh-Qv; Mon, 25 Apr 2022 17:29:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj2Wf-0003ql-QT; Mon, 25 Apr 2022 17:29:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=E3djtlTvvTrskcZVruSilDpHaGDQCvkQ/Mn9xyEEVCo=; b=RsJMlVOt3JAlfQaSCFYaRBohRV
	YFhPvjBFEahH41fP5gziisOQ0pkQHQRragIRotcqnV+obrC8219oTHDRKRchq3Q+no8/8VfLP53yk
	+dGOiTv3iqWdS8H4tVwsT1g21/nrPqAxnWdlLSj9z5xdDJGL+SAxLzY0N+PVEPvsRFMg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169712-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169712: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 17:29:29 +0000

flight 169712 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169712/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  625 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 17:56:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 17:56:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313219.530706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2wk-0007U9-RZ; Mon, 25 Apr 2022 17:56:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313219.530706; Mon, 25 Apr 2022 17:56:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj2wk-0007U2-NI; Mon, 25 Apr 2022 17:56:26 +0000
Received: by outflank-mailman (input) for mailman id 313219;
 Mon, 25 Apr 2022 17:56:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Eo9G=VD=citrix.com=prvs=107e1699f=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nj2wj-0007Tw-Dk
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 17:56:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03d89e87-c4c1-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 19:56:23 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03d89e87-c4c1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650909383;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=/tKAjkkYSMDllU9JnQF69uN0fUng2lAXH77fLoP809k=;
  b=bUSmQQ2BV6fsem5C1CANsQTWge1UeXHKJzsSeqUNwjj6TfhoTpD/LXO7
   e+wsCCVH4o8PpNop51FON/MaxspcQs1cKR52rh4qJV6mCfUkr9s4rb7lf
   lzOfbHvE1pmAkFFUBr2RK4AEB8fgyj1Ll4SETnAjus25YY6TN7QJDLyT1
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70288496
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JkWh/KlXmhG5at+vrnXN1Zjo5gz9JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIYCjzUaPyMazegKt91PI2+9U5T68ODzNBrSVA/pXhhRiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWV7V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYeAoEbrfBqOchQxhRGCJDOvFkouPAGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJGMWA/PEiRPXWjPH89J6o6n+Slm0D/YmMb+RWYiIMw4DX6mVkZPL/Fb4OOJ43iqd9utlmcj
 nLL+SL+GB5yHP61xCeB83msrvTShi69U4UXfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN
 woT4CVGkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwDCA5/rO7jaaOngFRzVCVdt6lpVqQgV/g
 zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmqm
 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGt56sz67DFzFtW
 UTofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmwmexowapxVJGW3C
 KM2he+3zMUKVJdNRfUpC79d9uxwlfSwfTgbfq28giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZylkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLCgMnSPrd5PfDjn7xETXPjLliCeTcbbSiIOJY3rI6W5LW8JE2C9o5loqw==
IronPort-HdrOrdr: A9a23:Tvv1Fq8kiWOlDCp+ntNuk+DUI+orL9Y04lQ7vn2YSXRuHPBw8P
 re+8jztCWE7Ar5N0tBpTntAsW9qBDnhPtICOsqTNSftWDd0QPCRuxfBOPZslvd8kbFl9K1u5
 0OT0EHMqyTMWRH
X-IronPort-AV: E=Sophos;i="5.90,289,1643691600"; 
   d="scan'208";a="70288496"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/nospec: Fix evaluate_nospec() code generation under Clang
Date: Mon, 25 Apr 2022 18:56:03 +0100
Message-ID: <20220425175603.21086-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

It turns out that evaluate_nospec() code generation is not safe under Clang.
Given:

  void eval_nospec_test(int x)
  {
      if ( evaluate_nospec(x) )
          asm volatile ("nop #true" ::: "memory");
      else
          asm volatile ("nop #false" ::: "memory");
  }

Clang emits:

  <eval_nospec_test>:
         0f ae e8                lfence
         85 ff                   test   %edi,%edi
         74 02                   je     <eval_nospec_test+0x9>
         90                      nop
         c3                      ret
         90                      nop
         c3                      ret

which is not safe because the lfence has been hoisted above the conditional
jump.  Clang concludes that both barrier_nospec_true()'s have identical side
effects and can safely be merged.

Clang can be persuaded that the side effects are different if there are
different comments in the asm blocks.  This is fragile, but no more fragile
that other aspects of this construct.

Introduce barrier_nospec_false() with a separate internal comment to prevent
Clang merging it with barrier_nospec_true() despite the otherwise-identical
content.  The generated code now becomes:

  <eval_nospec_test>:
         85 ff                   test   %edi,%edi
         74 05                   je     <eval_nospec_test+0x9>
         0f ae e8                lfence
         90                      nop
         c3                      ret
         0f ae e8                lfence
         90                      nop
         c3                      ret

which has the correct number of lfence's, and in the correct place.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/include/asm/nospec.h | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/include/asm/nospec.h b/xen/arch/x86/include/asm/nospec.h
index 5312ae4c6f31..7150e76b87fb 100644
--- a/xen/arch/x86/include/asm/nospec.h
+++ b/xen/arch/x86/include/asm/nospec.h
@@ -10,15 +10,26 @@
 static always_inline bool barrier_nospec_true(void)
 {
 #ifdef CONFIG_SPECULATIVE_HARDEN_BRANCH
-    alternative("lfence", "", X86_FEATURE_SC_NO_BRANCH_HARDEN);
+    alternative("lfence #nospec-true", "", X86_FEATURE_SC_NO_BRANCH_HARDEN);
 #endif
     return true;
 }
 
+static always_inline bool barrier_nospec_false(void)
+{
+#ifdef CONFIG_SPECULATIVE_HARDEN_BRANCH
+    alternative("lfence #nospec-false", "", X86_FEATURE_SC_NO_BRANCH_HARDEN);
+#endif
+    return false;
+}
+
 /* Allow to protect evaluation of conditionals with respect to speculation */
 static always_inline bool evaluate_nospec(bool condition)
 {
-    return condition ? barrier_nospec_true() : !barrier_nospec_true();
+    if ( condition )
+        return barrier_nospec_true();
+    else
+        return barrier_nospec_false();
 }
 
 /* Allow to block speculative execution in generic code */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 18:08:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 18:08:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313226.530717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj38K-0000lA-Tk; Mon, 25 Apr 2022 18:08:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313226.530717; Mon, 25 Apr 2022 18:08:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj38K-0000l3-Ql; Mon, 25 Apr 2022 18:08:24 +0000
Received: by outflank-mailman (input) for mailman id 313226;
 Mon, 25 Apr 2022 18:08:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Eo9G=VD=citrix.com=prvs=107e1699f=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nj38J-0000kx-Uy
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 18:08:23 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b0afe9ad-c4c2-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 20:08:22 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0afe9ad-c4c2-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650910101;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=tbWrgfjjL76MDqACwCF7hzNlTtB6RXM7lo0C1GDYeNM=;
  b=EdNUhXykgiazlmQEfNwIDzSpxBzi4W8leZujx+LmkkKeuNoYCOgAvL7h
   FN44zmDx3NDID914koycCeJJ4yIymUiVvUujTfx87dHICmvzXCiRj3WOh
   af6YqHs4I0KucadIVG03IjklncAHI/4Eg9keuq3RioBtgf0ifZkjW/Up0
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69761879
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:W4Lu5aln1A9UgjP5ZA5VsNHo5gxSJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIWX2HSM/fZZmDzeI8lYd7j901SuJWBx4I2TlE6+Sg2RSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWV7V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYdhslboDigvwnCxxSEy9FAKlN4aeEGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHOGUxNUSfMnWjPH8pIrNkxbqwhEC4egdopUy5mLoJuC/cmVkZPL/Fb4OOJ43iqd9utl2Du
 mvM8mD9AxcbHN+S0zyI9jSrnOCntTz/cJIfEvu/7PECqF+Owm0eDjUGWF39puO24maccd9CL
 00f+gI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQqu8M7SiYj/
 kOYlNPuQzp0ufuaTmz13ruMtjazJSg9JHcPfzMZVhAC58T/oYY1lVTESdMLLUKupoSrQ3eqm
 WnM9XVgweVI5SIW60ml1W/bj2KBiILRdFYw7AXZZV+h5RphJ7fwMuRE9mPnxfpHKY+YSHyIs
 34Fh9WS4YgyMH2dqMCeaL5TRe/0vp5pJBWZ2AcyRMd5q1xB7lb5JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiJNLKigbArLWdrGR2CgmbKggjQfLAEy/1XB
 HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG82jkEn+ieDPOSTLIVvgDLdoRrpghE9jiF+Lm
 +uzyuPQk0kPOAEASnS/HXEvwaAiciFgWMGeRz1/fe+fOAt2cFzN+NeKqY7Nj7dNxvwP/s+Rp
 ynVchYBmDLX2C2WQS3XOysLQO6+Av5CQYcTYHVE0aCAgCN4P+5CLc43KvMKQFXQ3LE9naMsE
 6lZKq1twJ1nE1z6xtjUVrGlxKQKSfhhrVvm0/aNCNTnQ6Ndeg==
IronPort-HdrOrdr: A9a23:Q60ka65cJJIcj/OCSgPXwMTXdLJyesId70hD6qhwISY6TiX+rb
 HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78
 hdmtBFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.90,289,1643691600"; 
   d="scan'208";a="69761879"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, Daniel Smith <dpsmith@apertussolutions.com>, "George
 Dunlap" <George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Julien
 Grall" <julien@xen.org>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>
Subject: [PATCH] xsm/flask: Fix build with Clang 13
Date: Mon, 25 Apr 2022 19:07:56 +0100
Message-ID: <20220425180756.29738-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Clang 13 chokes with:

  In file included from xsm/flask/flask_op.c:780:
  xsm/flask/flask_op.c:698:33: error: passing 4-byte aligned argument to
  8-byte aligned parameter 1 of 'flask_ocontext_add' may result in an
  unaligned pointer access [-Werror,-Walign-mismatch]
          rv = flask_ocontext_add(&op.u.ocontext);
                                  ^

and the same for flask_ocontext_del().  It isn't a problem in practice,
because the union always starts 8 bytes into {xen,compat}_flask_op_t, but the
diagnostic is based on type alignment alone.

struct xen_flask_ocontext has the same layout between native and compat, but
does change alignment because of uint64_t, and there is only a native
implementation of flask_ocontext_add().

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
CC: Daniel Smith <dpsmith@apertussolutions.com>
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Liu <wl@xen.org>
CC: Julien Grall <julien@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>

Slightly RFC because there don't appear to be any good options here.
---
 xen/include/public/xsm/flask_op.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/xsm/flask_op.h b/xen/include/public/xsm/flask_op.h
index b41dd6dac894..80dc35122320 100644
--- a/xen/include/public/xsm/flask_op.h
+++ b/xen/include/public/xsm/flask_op.h
@@ -146,7 +146,7 @@ struct xen_flask_ocontext {
     uint32_t ocon;
     uint32_t sid;
     uint64_t low, high;
-};
+} __attribute__((__aligned__(8)));
 typedef struct xen_flask_ocontext xen_flask_ocontext_t;
 
 struct xen_flask_peersid {
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 18:33:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 18:33:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313234.530728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj3W9-0004Ne-RL; Mon, 25 Apr 2022 18:33:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313234.530728; Mon, 25 Apr 2022 18:33:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj3W9-0004NX-Nr; Mon, 25 Apr 2022 18:33:01 +0000
Received: by outflank-mailman (input) for mailman id 313234;
 Mon, 25 Apr 2022 18:33:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nj3W8-0004NR-3O
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 18:33:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nj3Vy-0001Ud-EG; Mon, 25 Apr 2022 18:32:50 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.15.211]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nj3Vy-00067o-7j; Mon, 25 Apr 2022 18:32:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=zv9BxEVRn9GYifPEYqdEettuFRh9fIcE+pyD1HVACXo=; b=19XpiR4ea09mFeUvpND3Or9bU0
	rq6Jza/nq+uFre2TkzkC04SyCTmXcVrPufDq3dLovsuCaoDDNBWMBeo7lWvtKyf328n5OwhqQXJvy
	2TKnco6emgS8XBtGvZRETqToXfkkDszBTPyluGesykKw+S4vugnFIdEk6uPgRV7QiPQg=;
Message-ID: <c5273a0c-082c-0e10-a394-fa43654f1d24@xen.org>
Date: Mon, 25 Apr 2022 19:32:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
To: David Vrabel <dvrabel@cantab.net>, Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
 <afb15744-5e80-6c40-069e-6fc076e40e3d@suse.com>
 <74500983-79f8-07a9-7dcf-54a7bc162061@xen.org>
 <54e0a438-e3ce-98d6-1b7f-ce2d69d45c7a@cantab.net>
From: Julien Grall <julien@xen.org>
In-Reply-To: <54e0a438-e3ce-98d6-1b7f-ce2d69d45c7a@cantab.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 25/04/2022 15:13, David Vrabel wrote:
> 
> 
> On 25/04/2022 14:43, Julien Grall wrote:
>> Hi Jan,
>>
>> On 25/04/2022 14:37, Jan Beulich wrote:
>>> On 25.04.2022 15:34, Julien Grall wrote:
>>>> On 25/04/2022 14:28, David Vrabel wrote:
>>>>> --- a/xen/common/page_alloc.c
>>>>> +++ b/xen/common/page_alloc.c
>>>>> @@ -162,6 +162,13 @@
>>>>>    static char __initdata opt_badpage[100] = "";
>>>>>    string_param("badpage", opt_badpage);
>>>>> +/*
>>>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>>>
>>>> The comment needs to be updated to reflect the fact that at least Arm
>>>> doesn't use IPI to flush TLBs.
>>>
>>> I thought the use of "may" was satisfying your earlier request?
>>
>> Maybe I read wrongly this comment... To me, anything after 'which' is 
>> optional (it is a non-defining clause) and describe how the TLB 
>> flushes works. So the 'may' here is referring to the possibility to 
>> use flush TLB.
> 
> Oh dear, you're using formal grammar with a native English speaker who's 
> never seen a grammar rule in any of his schooling.
> 
> I think this should be:
> 
> "Heap allocations may need TLB flushes that require IRQs..."
> 
> i.e., "that" instead of "which"

I am fine with that.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 18:53:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 18:53:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313240.530739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj3pq-00072M-Ea; Mon, 25 Apr 2022 18:53:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313240.530739; Mon, 25 Apr 2022 18:53:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj3pq-00072F-BW; Mon, 25 Apr 2022 18:53:22 +0000
Received: by outflank-mailman (input) for mailman id 313240;
 Mon, 25 Apr 2022 18:53:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj3po-000725-Oo; Mon, 25 Apr 2022 18:53:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj3po-0001pv-La; Mon, 25 Apr 2022 18:53:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj3po-0007BZ-EX; Mon, 25 Apr 2022 18:53:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj3po-0005cj-E5; Mon, 25 Apr 2022 18:53:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3ceuJv05Vdpr5TYMC6f0BqHmR/tSSew0ugagT4wRKgU=; b=GFi8f4NUklLatUfb/BkfQtvB1Z
	ys+CaaEopE1jIUJcdUGT+tQz/KkILO17eR4Vw2jruDpwgo0wwF94CsdTOU90EmnTcHSW8bR8VAMRW
	jif5RN5gnlOsS1y8M1YSXauthTOqnq6agXUDEUG6Xna7vHAchIQ7N5WAkfJcj+IgB1w0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169713-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169713: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 18:53:20 +0000

flight 169713 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169713/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  626 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 19:37:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 19:37:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313251.530750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj4Vs-0003Po-Q7; Mon, 25 Apr 2022 19:36:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313251.530750; Mon, 25 Apr 2022 19:36:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj4Vs-0003Ph-Mi; Mon, 25 Apr 2022 19:36:48 +0000
Received: by outflank-mailman (input) for mailman id 313251;
 Mon, 25 Apr 2022 19:36:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OPyJ=VD=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nj4Vr-0003Pb-GS
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 19:36:47 +0000
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com
 [2a00:1450:4864:20::129])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0aa006f8-c4cf-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 21:36:45 +0200 (CEST)
Received: by mail-lf1-x129.google.com with SMTP id x33so28068160lfu.1
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 12:36:45 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0aa006f8-c4cf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=VjBbzPepFaGP/uN3sVsbzKuVqOQ2IKhG6bvnrfO4aSo=;
        b=WfxD5XgKPnR8aOo7PfcnUBJa5hpPBf2mw/o2HtuZ7E9gru/LfgOeilZZgtVZoUj/nk
         B9Wxk8LuC0FrHqXq0uYzz2k8P0m1d+8hnO0a4rcWbdJWO5pIgKCTbc6Jpm0vRUO6O8QD
         SAbbnbBZXe9FNmaKssUc2mZ+h3uVg18ECPEPuIW6Qak+plYugagGHWm4s/IB3ZKhZKX9
         V2z+SFkyFfVaXglvvSYJlABPiYDo6KSjZ1kwWrM81pXU9htdMFAoqhvMVgmwsRirrb2A
         D0cLC0GvS2O/iOuZVb1UQcn2oAh2b2pFSmGsjDNhbDn5+kUrqYGWjLqrQDgSn9L5upTY
         utXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=VjBbzPepFaGP/uN3sVsbzKuVqOQ2IKhG6bvnrfO4aSo=;
        b=11dTLPP1goW2nS4oBJxXGAC/CnO39hn5oqouPec2VY1TiH7OASEOUDJ8Lcarx3oBan
         flUQw20WD6whnrGmm8prtvQD/PyxmOLlT8kkFysF5e1WC7UJv8YDXH//YXtt3Lhqk0Xj
         X2YUm6W8xfugaStVbvDOZDXSLrC4tFYOv6x2YF8UO9WIyS39ddX4azu3pbLJ+AdT270f
         bJ2M1wvgbs+TyY5j0jQ/hba1Ruk7L60UlB+nf8rVdOG5w7lxdACdRn1tDIvUrQbrjFoe
         u9g2OMdpcVTqixBPzcBDmIVx0G/pzJfZd96uWzAW8cNcuvHD7Ned04iOlWsoBn9UV57V
         5+GA==
X-Gm-Message-State: AOAM5309lEY2w+GlMLHem1cqs5EWRsglP8w+MxOrK24SFPwJ1YBm17wB
	OX5CBDjHmXSXNTsl2rnkP8dhJ6Kr7S82a+IdwNL8Uhj7+7A=
X-Google-Smtp-Source: ABdhPJxnMYGmP3jq8rBO0FLB/SCCMl+rj9r9HX+eksyvtLC9EFBfPV9/NjoX7hccMPSWhQf4Fjm+pORWC1USO2Y85A4=
X-Received: by 2002:a05:6512:110d:b0:471:94ad:2bf4 with SMTP id
 l13-20020a056512110d00b0047194ad2bf4mr14579289lfg.128.1650915405327; Mon, 25
 Apr 2022 12:36:45 -0700 (PDT)
MIME-Version: 1.0
References: <20220422194344.9318-1-dpsmith@apertussolutions.com> <5b199cfb-98c8-c382-82b3-a60819a0e977@citrix.com>
In-Reply-To: <5b199cfb-98c8-c382-82b3-a60819a0e977@citrix.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Mon, 25 Apr 2022 15:36:34 -0400
Message-ID: <CAKf6xpt-WoKM6uR2spgbYBARSttpyLLZvhE9RMVUjsQ38=2bHQ@mail.gmail.com>
Subject: Re: [PATCH] xsm/flask: code style formatting
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 22, 2022 at 7:07 PM Andrew Cooper <Andrew.Cooper3@citrix.com> wrote:
>
> On 22/04/2022 20:43, Daniel P. Smith wrote:
> > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> > index 0bf63ffa84..e2ebbc7716 100644
> > --- a/xen/xsm/flask/hooks.c
> > +++ b/xen/xsm/flask/hooks.c
> > @@ -120,8 +121,8 @@ static int get_irq_sid(int irq, u32 *sid, struct avc_audit_data *ad)
> >          struct irq_desc *desc = irq_to_desc(irq);
> >          if ( desc->msi_desc && desc->msi_desc->dev ) {
> >              struct pci_dev *dev = desc->msi_desc->dev;
> > -            u32 sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
> > -            if (ad) {
> > +            uint32_t sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
> > +            if ( ad ) {
>
> Brace on newline, and in the subsequent hunk.  Can be fixed on commit.
>
> Otherwise, LGTM.  Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jason Andryuk <jandryuk@gmail.com>


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 19:45:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 19:45:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313257.530760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj4dq-00050H-L3; Mon, 25 Apr 2022 19:45:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313257.530760; Mon, 25 Apr 2022 19:45:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj4dq-00050A-Hr; Mon, 25 Apr 2022 19:45:02 +0000
Received: by outflank-mailman (input) for mailman id 313257;
 Mon, 25 Apr 2022 19:45:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj4dp-000500-Gn; Mon, 25 Apr 2022 19:45:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj4dp-0002jR-DN; Mon, 25 Apr 2022 19:45:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj4dp-0000nz-2W; Mon, 25 Apr 2022 19:45:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj4dp-0004Rs-27; Mon, 25 Apr 2022 19:45:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DMsxbl1SETjVCtyguCvGnG0LVKzuSBdvFwqz9z4ztVo=; b=dK8Tiq0+8juwe7CXzwGC6lOATx
	DLLkKWcCtjPBDImuVFYAtqPopLFV0Sf/xBTaWWDEz/j2zMtfmsA/xeYitmMKLUG6GqN6vK5xF0YZB
	ZNfE/+ffl5Ck8e9wAs7M7usMzoRliKJrXXUhQLFUPKxZEgCEF/Vi4R3OoMhGmcPwKNL8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169715-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169715: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 19:45:01 +0000

flight 169715 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169715/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  627 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 20:39:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 20:39:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313267.530772 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj5Tm-0002ZX-VO; Mon, 25 Apr 2022 20:38:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313267.530772; Mon, 25 Apr 2022 20:38:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj5Tm-0002ZQ-S0; Mon, 25 Apr 2022 20:38:42 +0000
Received: by outflank-mailman (input) for mailman id 313267;
 Mon, 25 Apr 2022 20:38:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uj5J=VD=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nj5Tl-0002ZK-4Q
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 20:38:41 +0000
Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com
 [2a00:1450:4864:20::231])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b0108320-c4d7-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 22:38:39 +0200 (CEST)
Received: by mail-lj1-x231.google.com with SMTP id 4so5804208ljw.11
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 13:38:39 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 k10-20020a192d0a000000b0047210d2a984sm151624lfj.194.2022.04.25.13.38.37
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 25 Apr 2022 13:38:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0108320-c4d7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=ILv9teSoP4aYBf6xbxudr1p2VEvSoGOnfNFBeXl3R7I=;
        b=fZeZl2Kwvt4eb47jsj7b9dqLTKA5hsNa/sySJVGqjq6U3w2+LmTwQJExnt/XNPaCZK
         4xysJPg2ngKepEL7PL914QEcvlGSWtShIldwOovqXozQjHzx8fouMu2ylG6ORxnHj9wH
         Pp5U/iHR6OWJpWrZtjkTJ671qf26P4CpLLXOCmzWkfHBLgFlwtahcBV087RzVueuebp/
         XaDp+7AKM37d+QmgErhZ5iqAbuc1mJvGczx8MmTUDGRw3YgmijNmH3nHKzm6X3xKk4Do
         eClxdCIBZCG/CFC4tQdaRY5lY7lsSqNNIYvC3LGUx71pypdfugyTgWOUKqQIh/NxrmYg
         efBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=ILv9teSoP4aYBf6xbxudr1p2VEvSoGOnfNFBeXl3R7I=;
        b=Xx6vOHJitCrIiEROkbt/d90UH88+wDHP+twnvnH7kebZrjwv3uypBoR6c+0gkkTjd7
         8XJIFXFT9YnKFFqmi0Fk+EkQaAkRNKbt3Xk/83D9VOLKLsgjiHS4RtvGQ2xOx8qHXDRL
         oW2TSXMf56q0E1iQStK5TGyM6Sp5xl0wKrCNiRuKTAftZAgk4lqx9GMhZ1XS8tfqUX+K
         JL+K+r6821VbEOrF8XWtQFJbzNm0Z0vXHttpInV32aplg1EVrdAE0IETrrxNSIYj2pN1
         nEDhjhT6WJLt+5598oE7QPoNqalQXUakK/APOZCO19TQsQ6DnSAb+i9nj9ywT/lTq55C
         WgpA==
X-Gm-Message-State: AOAM533PLfL01zg5Ut7UzOR3M30u8H6P1wcGSHIpaShTkSXzvyFmkZDD
	PKpDydHWLroC7qRl6W9cyDQ=
X-Google-Smtp-Source: ABdhPJxqOK8Wi+cHV2hwafjT2TF0m9x1sQnllf3glnSRUlek2UP+fsukD/q4rxgK8QtsK9A4ogCzNg==
X-Received: by 2002:a2e:a793:0:b0:24e:e3bd:b3a8 with SMTP id c19-20020a2ea793000000b0024ee3bdb3a8mr12004192ljf.457.1650919118643;
        Mon, 25 Apr 2022 13:38:38 -0700 (PDT)
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
To: Juergen Gross <jgross@suse.com>, Christoph Hellwig <hch@infradead.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
 Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Tom Lendacky <thomas.lendacky@amd.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
 <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com>
Date: Mon, 25 Apr 2022 23:38:36 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hello all.


On 25.04.22 12:14, Juergen Gross wrote:
> On 25.04.22 09:58, Christoph Hellwig wrote:
>> On Mon, Apr 25, 2022 at 09:47:49AM +0200, Juergen Gross wrote:
>>>> Would the Xen specific bits fit into Confidential Computing Platform
>>>> checks? I will let Juergen/Boris comment on this.
>>>
>>> I don't think cc_platform_has would be correct here. Xen certainly
>>> provides more isolation between guests and dom0, but "Confidential
>>> Computing" is basically orthogonal to that feature.
>>
>> The point of cc_platform_has is to remove all these open code checks.
>> If a Xen hypervisor / dom0 can't access arbitrary guest memory for
>> virtual I/O and we need special APIs for that it certainly false
>> into the scope of cc_platform_has, even if the confientiality is
>> rather limited.
>
> In case the x86 maintainers are fine with that I won't oppose.
>
>
> Juergen


[I have discussed with Juergen on IRC about it.]


Well, if cc_platform_has() is a way to go (at least on x86), below some 
thoughts about possible integration (if, of course, I got the idea and 
code correctly).

1. We will need to introduce new attribute 
CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED
as we can't reuse CC_ATTR_GUEST_MEM_ENCRYPT (in case of Xen the Guest 
memory is not encrypted). New attribute is automatically set if Guest 
memory encryption is active (CC_ATTR_GUEST_MEM_ENCRYPT is set). Also new 
attribute is set if restricted memory access using Xen grant mappings is 
active. This will allow us to have a single check in
arch_has_restricted_virtio_memory_access() which covers both cases: Xen 
and SEV

int arch_has_restricted_virtio_memory_access(void)
{
     return cc_platform_has(CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED);
}

2. We will need to introduce new vendor CC_VENDOR_XXX for our case (I 
have chosen XEN, although I am not sure it is a good fit) which deals 
with new attribute only.
3. Xen code then will call cc_set_vendor(CC_VENDOR_XEN) for different 
modes (PV, HVM, etc) during initialization if restricted memory access 
using Xen grant mappings is enabled.

Below the diff (not tested and without x86's PVH) how it could look like:


diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index ec5b082..0284aa7 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -409,6 +409,14 @@ int __init arch_xen_unpopulated_init(struct 
resource **res)
  }
  #endif

+#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+int arch_has_restricted_virtio_memory_access(void)
+{
+       return IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain();
+}
+EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
+#endif
+
  static void __init xen_dt_guest_init(void)
  {
         struct device_node *xen_node;
diff --git a/arch/x86/coco/core.c b/arch/x86/coco/core.c
index fc1365d..9020a60 100644
--- a/arch/x86/coco/core.c
+++ b/arch/x86/coco/core.c
@@ -44,6 +44,7 @@ static bool amd_cc_platform_has(enum cc_attr attr)
                 return sme_me_mask && !(sev_status & 
MSR_AMD64_SEV_ENABLED);

         case CC_ATTR_GUEST_MEM_ENCRYPT:
+       case CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED:
                 return sev_status & MSR_AMD64_SEV_ENABLED;

         case CC_ATTR_GUEST_STATE_ENCRYPT:
@@ -67,7 +68,19 @@ static bool amd_cc_platform_has(enum cc_attr attr)

  static bool hyperv_cc_platform_has(enum cc_attr attr)
  {
-       return attr == CC_ATTR_GUEST_MEM_ENCRYPT;
+       switch (attr) {
+       case CC_ATTR_GUEST_MEM_ENCRYPT:
+       case CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED:
+               return true;
+
+       default:
+               return false;
+       }
+}
+
+static bool xen_cc_platform_has(enum cc_attr attr)
+{
+       return attr == CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED;
  }

  bool cc_platform_has(enum cc_attr attr)
@@ -79,6 +92,8 @@ bool cc_platform_has(enum cc_attr attr)
                 return intel_cc_platform_has(attr);
         case CC_VENDOR_HYPERV:
                 return hyperv_cc_platform_has(attr);
+       case CC_VENDOR_XEN:
+               return xen_cc_platform_has(attr);
         default:
                 return false;
         }
@@ -115,3 +130,11 @@ __init void cc_set_mask(u64 mask)
  {
         cc_mask = mask;
  }
+
+#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+int arch_has_restricted_virtio_memory_access(void)
+{
+       return cc_platform_has(CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED);
+}
+EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
+#endif
diff --git a/arch/x86/include/asm/coco.h b/arch/x86/include/asm/coco.h
index 3d98c3a..6395ec1 100644
--- a/arch/x86/include/asm/coco.h
+++ b/arch/x86/include/asm/coco.h
@@ -9,6 +9,7 @@ enum cc_vendor {
         CC_VENDOR_AMD,
         CC_VENDOR_HYPERV,
         CC_VENDOR_INTEL,
+       CC_VENDOR_XEN,
  };

  void cc_set_vendor(enum cc_vendor v);
diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
index 50d2099..dda020f 100644
--- a/arch/x86/mm/mem_encrypt.c
+++ b/arch/x86/mm/mem_encrypt.c
@@ -77,8 +77,3 @@ void __init mem_encrypt_init(void)
         print_mem_encrypt_feature_info();
  }

-int arch_has_restricted_virtio_memory_access(void)
-{
-       return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT);
-}
-EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access);
diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
index 85246dd..79cb30f 100644
--- a/arch/x86/xen/Kconfig
+++ b/arch/x86/xen/Kconfig
@@ -8,6 +8,7 @@ config XEN
         depends on PARAVIRT
         select PARAVIRT_CLOCK
         select X86_HV_CALLBACK_VECTOR
+       select ARCH_HAS_CC_PLATFORM
         depends on X86_64 || (X86_32 && X86_PAE)
         depends on X86_LOCAL_APIC && X86_TSC
         help
diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index 517a9d8..11c3f4e 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -195,6 +195,9 @@ static void __init xen_hvm_guest_init(void)
         if (xen_pv_domain())
                 return;

+       if (IS_ENABLED(CONFIG_XEN_VIRTIO))
+               cc_set_vendor(CC_VENDOR_XEN);
+
         init_hvm_pv_info();

         reserve_shared_info();
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 5038edb..2fe5aaa 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -109,6 +109,9 @@ static DEFINE_PER_CPU(struct tls_descs, 
shadow_tls_desc);

  static void __init xen_pv_init_platform(void)
  {
+       if (IS_ENABLED(CONFIG_XEN_VIRTIO))
+               cc_set_vendor(CC_VENDOR_XEN);
+
         populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP));

         set_fixmap(FIX_PARAVIRT_BOOTMAP, xen_start_info->shared_info);
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 313a9127..d3179f8 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -339,4 +339,16 @@ config XEN_GRANT_DMA_OPS
         bool
         select DMA_OPS

+config XEN_VIRTIO
+       bool "Xen virtio support"
+       depends on VIRTIO
+       select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
+       select XEN_GRANT_DMA_OPS
+       help
+         Enable virtio support for running as Xen guest. Depending on the
+         guest type this will require special support on the backend side
+         (qemu or kernel, depending on the virtio device types used).
+
+         If in doubt, say n.
+
  endmenu
diff --git a/include/linux/cc_platform.h b/include/linux/cc_platform.h
index efd8205..d06bc7a 100644
--- a/include/linux/cc_platform.h
+++ b/include/linux/cc_platform.h
@@ -72,6 +72,19 @@ enum cc_attr {
          * Examples include TDX guest & SEV.
          */
         CC_ATTR_GUEST_UNROLL_STRING_IO,
+
+       /**
+        * @CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED: Restricted memory access to
+        *                                       Guest memory is active
+        *
+        * The platform/OS is running as a guest/virtual machine and uses
+        * the restricted access to its memory. This attribute is set if 
either
+        * Guest memory encryption or restricted memory access using Xen 
grant
+        * mappings is active.
+        *
+        * Examples include Xen guest and SEV.
+        */
+       CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED,
  };

  #ifdef CONFIG_ARCH_HAS_CC_PLATFORM
(END)


On Arm I left simple variant simply because of no users of cc_platform.

int arch_has_restricted_virtio_memory_access(void)
{
        return IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain();
}

But, we could have something simple here:

bool cc_platform_has(enum cc_attr attr)
{
     switch (attr) {
     case CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED:
         return IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain();

     default:
         return false;
     }
}

int arch_has_restricted_virtio_memory_access(void)
{
     return cc_platform_has(CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED);
}


Any thoughts?

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 21:08:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 21:08:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313275.530783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj5wh-0006Jd-BZ; Mon, 25 Apr 2022 21:08:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313275.530783; Mon, 25 Apr 2022 21:08:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj5wh-0006JG-77; Mon, 25 Apr 2022 21:08:35 +0000
Received: by outflank-mailman (input) for mailman id 313275;
 Mon, 25 Apr 2022 21:08:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=32Y1=VD=kernel.org=song@srs-se1.protection.inumbo.net>)
 id 1nj5wg-0006JA-Nr
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 21:08:34 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc6000d7-c4db-11ec-8fc2-03012f2f19d4;
 Mon, 25 Apr 2022 23:08:32 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 222AF61348
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 21:08:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89AADC385B8
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 21:08:30 +0000 (UTC)
Received: by mail-yw1-f176.google.com with SMTP id
 00721157ae682-2f7b90e8b37so84988497b3.6
 for <xen-devel@lists.xenproject.org>; Mon, 25 Apr 2022 14:08:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc6000d7-c4db-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650920910;
	bh=yN2FFsgqiwWmpQIWXC94b82E2wpYjQTq/CU/u3g3cjE=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=pdKHj+9jtFEKRxbFIKbp6BN5W0SKHdhPUGdQDXd7Xqx9vi4EpkMV1Y4FokX/IkPYa
	 fcHGk/4On2XWYf3uADhfEsr+7LxnZ49Mj82N7KMHrZLd/dwLJ08US+RaehkUasA6/k
	 ULzEmN8W11D5KZ+Cm4S93JoYXPgu2ne6zBKyDbG+PP7TNy6nKJUI/Prlkq4aTHvM+N
	 eDTgN5VZZLATieGxC8vMqcHVTHdQIL63mmQQGdiCPeBj+cARAR4cnGnqJ35UI9ZFbn
	 uSL8Ys/PCGOp1a6uCJDJdZhN6mhZ0J51T+/xZ6Bj+aFJUo7nkxoRQiwNXWKGnT6ByK
	 ZiFdXEcFhWfZg==
X-Gm-Message-State: AOAM533ZNvMSDVeVcgUasI0FfLdbIDXzqaB4J4huqrStbgYMvlZ3OTGN
	SvK/O6RWF7hAdy2copdUj1kU41jFQqtNb+VytBk=
X-Google-Smtp-Source: ABdhPJxgUnh58spmwdi5KGXzmrzAEx/WM60nf6Oi6YSWPgwfZEJsfaGjWIDBRUKlPyettQyT9R0PC00gVw9kzJ9ffYQ=
X-Received: by 2002:a0d:e343:0:b0:2f7:cefb:577b with SMTP id
 m64-20020a0de343000000b002f7cefb577bmr9909411ywe.472.1650920909604; Mon, 25
 Apr 2022 14:08:29 -0700 (PDT)
MIME-Version: 1.0
References: <20220418045314.360785-1-hch@lst.de> <20220418045314.360785-7-hch@lst.de>
In-Reply-To: <20220418045314.360785-7-hch@lst.de>
From: Song Liu <song@kernel.org>
Date: Mon, 25 Apr 2022 14:08:18 -0700
X-Gmail-Original-Message-ID: <CAPhsuW7fpiAqAf+U491dTH4mWORZQCxfyT6zWQwN=4r5WJ429Q@mail.gmail.com>
Message-ID: <CAPhsuW7fpiAqAf+U491dTH4mWORZQCxfyT6zWQwN=4r5WJ429Q@mail.gmail.com>
Subject: Re: [PATCH 06/11] raid5: don't set the discard_alignment queue limit
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>, 
	Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, 
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>, 
	"Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Mike Snitzer <snitzer@kernel.org>, Stefan Haberland <sth@linux.ibm.com>, 
	Jan Hoeppner <hoeppner@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, 
	linux-um@lists.infradead.org, linux-block@vger.kernel.org, 
	nbd@other.debian.org, virtualization@lists.linux-foundation.org, 
	xen-devel@lists.xenproject.org, linux-raid <linux-raid@vger.kernel.org>, 
	linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, 
	dm-devel@redhat.com
Content-Type: text/plain; charset="UTF-8"

On Sun, Apr 17, 2022 at 9:53 PM Christoph Hellwig <hch@lst.de> wrote:
>
> The discard_alignment queue limit is named a bit misleading means the
> offset into the block device at which the discard granularity starts.
> Setting it to the discard granularity as done by raid5 is mostly
> harmless but also useless.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Song Liu <song@kernel.org>

> ---
>  drivers/md/raid5.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 59f91e392a2ae..39b0afdf40d0a 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -7749,7 +7749,6 @@ static int raid5_run(struct mddev *mddev)
>                  */
>                 stripe = stripe * PAGE_SIZE;
>                 stripe = roundup_pow_of_two(stripe);
> -               mddev->queue->limits.discard_alignment = stripe;
>                 mddev->queue->limits.discard_granularity = stripe;
>
>                 blk_queue_max_write_zeroes_sectors(mddev->queue, 0);
> --
> 2.30.2
>


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 21:20:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 21:20:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313281.530794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj68I-0000GA-Dw; Mon, 25 Apr 2022 21:20:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313281.530794; Mon, 25 Apr 2022 21:20:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj68I-0000G3-A9; Mon, 25 Apr 2022 21:20:34 +0000
Received: by outflank-mailman (input) for mailman id 313281;
 Mon, 25 Apr 2022 21:20:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj68H-0000Fs-5u; Mon, 25 Apr 2022 21:20:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj68H-0004Rw-3b; Mon, 25 Apr 2022 21:20:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj68G-0005IY-N8; Mon, 25 Apr 2022 21:20:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj68G-0002Ou-Me; Mon, 25 Apr 2022 21:20:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RiOMe8sB9NydSfP4Dtkw15dpILuOapX24VY2aaMIu+o=; b=TOwQ400gu6OcEIvKLQcBdI62bq
	+adAL8+lLC38yJttpUi2qBYSs39WMwpD+f4U3XIojX+fnnzF5YeGwH64x8zrQedx/g6UfCplof2fd
	+XRtHWNjPm8Z2RX9ZfkUkXZDr0lDTMBU8r1BlxRzbQfdtzTu08zXYsDRfRtUXf17FQGo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169716-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169716: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=483d3bb716bfd1a90fde165a761067c50c482d4e
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 21:20:32 +0000

flight 169716 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169716/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 483d3bb716bfd1a90fde165a761067c50c482d4e
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  628 attempts
Testing same since   169701  2022-04-25 09:42:57 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5750 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 21:26:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 21:26:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313290.530805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj6Dp-000172-2D; Mon, 25 Apr 2022 21:26:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313290.530805; Mon, 25 Apr 2022 21:26:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj6Do-00016v-VX; Mon, 25 Apr 2022 21:26:16 +0000
Received: by outflank-mailman (input) for mailman id 313290;
 Mon, 25 Apr 2022 21:26:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=dJ7t=VD=alien8.de=bp@srs-se1.protection.inumbo.net>)
 id 1nj6Dk-00016p-Kb
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 21:26:15 +0000
Received: from mail.skyhub.de (mail.skyhub.de [2a01:4f8:190:11c2::b:1457])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5119f943-c4de-11ec-a405-831a346695d4;
 Mon, 25 Apr 2022 23:26:07 +0200 (CEST)
Received: from zn.tnic (p5de8eeb4.dip0.t-ipconnect.de [93.232.238.180])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B81DA1EC04A6;
 Mon, 25 Apr 2022 23:26:01 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5119f943-c4de-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
	t=1650921961;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VzCRn9yN2ByyCFR5QKv9+K8B8VcoQwcA3ZVz2Ifi7JQ=;
	b=fNnh8YiUMApB0I9iM+V6r0nvmh8FA7oNdMa5U7S15/LCpqbI1/jM6tKwfyZ0aDGbo5ZAAv
	UISb+73NpqVJqWCi+Fa1hLJKqxhd+c42n4JjVcHL1lptzDXi9IsAxaLj9BDartlz8vh+99
	YmQB5O8tl20QGO/Fbc7aZfQyJMnzDYU=
Date: Mon, 25 Apr 2022 23:25:57 +0200
From: Borislav Petkov <bp@alien8.de>
To: Oleksandr <olekstysh@gmail.com>
Cc: Juergen Gross <jgross@suse.com>, Christoph Hellwig <hch@infradead.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Message-ID: <YmcR5bfaYh1z7VUq@zn.tnic>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
 <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
 <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com>

On Mon, Apr 25, 2022 at 11:38:36PM +0300, Oleksandr wrote:
> diff --git a/include/linux/cc_platform.h b/include/linux/cc_platform.h
> index efd8205..d06bc7a 100644
> --- a/include/linux/cc_platform.h
> +++ b/include/linux/cc_platform.h
> @@ -72,6 +72,19 @@ enum cc_attr {
>          * Examples include TDX guest & SEV.
>          */
>         CC_ATTR_GUEST_UNROLL_STRING_IO,
> +
> +       /**
> +        * @CC_ATTR_GUEST_MEM_ACCESS_RESTRICTED: Restricted memory access to
> +        *                                       Guest memory is active
> +        *
> +        * The platform/OS is running as a guest/virtual machine and uses
> +        * the restricted access to its memory. This attribute is set if
> either
> +        * Guest memory encryption or restricted memory access using Xen
> grant
> +        * mappings is active.
> +        *
> +        * Examples include Xen guest and SEV.

Wait, whaaat?

The cc_platform* stuff is for *confidential computing* guests to check
different platform aspects.

>From quickly skimming over this, this looks like a misuse to me.

Why can't you query this from the hypervisor just like you do your other
querying about what is supported, etc? Hypercalls, CPUID, whatever...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 22:11:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 22:11:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313329.530834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj6vl-0007pz-2M; Mon, 25 Apr 2022 22:11:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313329.530834; Mon, 25 Apr 2022 22:11:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj6vk-0007ps-VL; Mon, 25 Apr 2022 22:11:40 +0000
Received: by outflank-mailman (input) for mailman id 313329;
 Mon, 25 Apr 2022 22:11:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj6vk-0007pi-Ak; Mon, 25 Apr 2022 22:11:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj6vk-0005Il-7Y; Mon, 25 Apr 2022 22:11:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj6vj-0007cV-UN; Mon, 25 Apr 2022 22:11:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj6vj-0000sC-Tv; Mon, 25 Apr 2022 22:11:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fxJLQrimnTDHI3X4+pfpYq8qvXwxLDmfQYh6UZKAQfc=; b=J9qGp+Gt6bef7Psdgg+Z+fY+J0
	GoJcoSKhHq18FgIhR9YTH453oRCsgdTvJg8Az2rHCb2wFbbgmRw2qxMtc+itIeDoFmXut0b0sX7ch
	hPPKL/qDXwqRsOkVn1UQvllvK1DRmFm0mL6VD7uU1+BtiuCIf3CO9dokBREVrI0GBAC0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169718-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169718: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 22:11:39 +0000

flight 169718 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169718/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  629 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Apr 25 23:07:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 23:07:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313340.530845 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj7nl-0005T6-20; Mon, 25 Apr 2022 23:07:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313340.530845; Mon, 25 Apr 2022 23:07:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj7nk-0005Sz-Ub; Mon, 25 Apr 2022 23:07:28 +0000
Received: by outflank-mailman (input) for mailman id 313340;
 Mon, 25 Apr 2022 23:07:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Eo9G=VD=citrix.com=prvs=107e1699f=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nj7ni-0005St-Le
 for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 23:07:26 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 765b44ac-c4ec-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 01:07:24 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 765b44ac-c4ec-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650928043;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=HfuahNNpA+hqwith49r0QNNc51ox4xCiXZ+yHc0fjTY=;
  b=KU0bUiUy2ozYnfJ+NjEXLQ+t+c9gtFthNfM44KhzxJOGkSiejhwMI2d0
   s/HfSI2cSkuls9XrIUZ3yxR4dQymkvODnSKCTzM0ENpfeq3WcPQ0tKE/r
   rp5sCkA7j3zV1lfaqTHvRBmXLFqlrjUIUDOV2ft0f8aw7EM41zobCamSu
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70306352
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Hm4m164Q52iyieOs0OxA3gxRtNXHchMFZxGqfqrLsTDasY5as4F+v
 jBLUWyPMvfeYmTzedtzPdvn/U4PucOAmIU1TVE5/ixnHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjXlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurS0FgILZojhpd9EQkB/PwcgF4oF5ZPudC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5VBMmIxN0maC/FJEkkWT5MewuiJvFa8IjtamAKtt7g8/HeGmWSd15CyaYGIK7RmX/59oEGco
 W7X+nXjNTsTPtef1Dmt/2qlg6nEmiaTcJkJCLSy+/pugVuS7m8eEhsbUR28u/bRolG6c8JSL
 QoT4CVGhaov8E2mSPHtUhv+p2SL1jYWVsBMCeQ85EeIw7DN/geCLmEeS3hKb9lOnN87Q3km2
 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgcqZyAeShAey8L+u4x1hRXKJv5BOqOoitz+GRnr3
 iuH6iM5gt0uYdUjjvvhuwqd2nT1+8aPHlVdChjrsnyN6lx8RtaASrGTsEmCytpmcqy+DUStl
 S1R8ySB19wmAZaInS2LZewCGrC1+vqIWAHhbU5T84oJrGr0pSP6FWxEyHQnfRoybJ5YEdP8S
 BWL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJy9z23+KTPuftmU
 Xt+TSpLJSxHYZmLNBLsG48gPUYDn0jSP1/7S5Hh1AiA2rGDfnOTQrptGALQM7hmsfrc+lSIq
 Yg32y62J/N3CrSWjs7/q9B7ELz3BSJjWcCeRzJ/K4Zv3TaK6El+UqSMkNvNiqRunrhPl/egw
 51OchQw9bYLvlWecV/iQik6MNvHBM8vxVpmbX1EFQv5gBALPNfwhJrzgrNqJNHLAsQ4lqUqJ
 xTEEu3daslypsPvpmpNMMGh/NAzHPlp7CrXVxeYjPEEV8YIb2T0FhXMJ2MDKAFm4vKLiPYD
IronPort-HdrOrdr: A9a23:9EpvrK7h17oH/7aZvAPXwMTXdLJyesId70hD6qhwISY6TiX+rb
 HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78
 hdmtBFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.90,289,1643691600"; 
   d="scan'208";a="70306352"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>,
	Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] xen/build: Fix build failure from LDFLAGS mismatch
Date: Tue, 26 Apr 2022 00:06:56 +0100
Message-ID: <20220425230656.12808-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

In a GNU compatbile makefile, $(LDFLAGS) are passed to $(CC), not $(LD).

In a default CentOS 7 build environment, $(LDFLAGS) is set to -Wl,-z,relro,
which causes the Xen build to explode with:

  ld: unrecognized option '-Wl,-z,relro'
  ld: use the --help option for usage information

It turns out that many downstreams identify this as a breakage in Xen's build
system and bodge around it in various ways, mostly by unsetting all of
$(CFLAGS), $(AFLAGS) and $(LDFLAGS).

However, that is a security issue because it means that tools/ is not built
with the distro-wide hardening flags that are otherwise expected of
packages (relro, _FORTIFY_SOURCE, stack-protector, etc).

tools/ specifically should honour the packaging environment's choice of flags,
while xen/ must not pass $(LDFLAGS) to $(LD), and should not be influenced by
the others either.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Wei Liu <wl@xen.org>

RFC, because CFLAGS/AFLAGS need nuking too, and they're rather more entangled.
I expect this to cause some disgreement, but Xen is behaving in a very
nonstandard way even among embedded projects and all downstreams are suffering
security problems as a consequence.
---
 xen/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/Makefile b/xen/Makefile
index ec34524ed21d..a8e1de54823b 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -254,6 +254,8 @@ export KBUILD_DEFCONFIG := $(ARCH)_defconfig
 # reparsing Config.mk by e.g. arch/x86/boot/.
 export XEN_TREEWIDE_CFLAGS := $(CFLAGS)
 
+LDFLAGS :=
+
 # CLANG_FLAGS needs to be calculated before calling Kconfig
 ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
 CLANG_FLAGS :=
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Apr 25 23:42:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Apr 2022 23:42:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313349.530856 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj8LZ-0001hm-ON; Mon, 25 Apr 2022 23:42:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313349.530856; Mon, 25 Apr 2022 23:42:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj8LZ-0001hf-Kb; Mon, 25 Apr 2022 23:42:25 +0000
Received: by outflank-mailman (input) for mailman id 313349;
 Mon, 25 Apr 2022 23:42:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj8LZ-0001hV-5j; Mon, 25 Apr 2022 23:42:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj8LY-0006pj-Pw; Mon, 25 Apr 2022 23:42:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj8LY-0004I5-Cm; Mon, 25 Apr 2022 23:42:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj8LY-0001yf-CH; Mon, 25 Apr 2022 23:42:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TsYOCu0/R5avdji4pfz15CFJQEGO8hLR8H275QugZuo=; b=AU9MDunr9VZrX1Yty/aGHReN+/
	ghCxFFrXb7mNaHX0ptx6svKUpdLDqdrvKAZ82BzJnFvQg1yURwa4jBpBhtS4ZbbgmZzReAnHzMkqT
	zGwGbES2+kwcZCnIILC1nILJrfb8oC/27/I9eLn/6t0Rot/EJn2nAy2cHOZu8cjHX/Uc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169719-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169719: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Apr 2022 23:42:24 +0000

flight 169719 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169719/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  630 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 00:27:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 00:27:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313360.530867 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj92n-0007Cs-38; Tue, 26 Apr 2022 00:27:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313360.530867; Tue, 26 Apr 2022 00:27:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj92m-0007Cl-VQ; Tue, 26 Apr 2022 00:27:04 +0000
Received: by outflank-mailman (input) for mailman id 313360;
 Tue, 26 Apr 2022 00:27:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj92l-0007Cb-2d; Tue, 26 Apr 2022 00:27:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj92k-0008Di-VZ; Tue, 26 Apr 2022 00:27:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj92k-0005qQ-JK; Tue, 26 Apr 2022 00:27:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj92k-0001yh-It; Tue, 26 Apr 2022 00:27:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pyHxShVOCTyP4/JyUwfKk8ZiH0fCggz6ZRAr8KOsYcI=; b=hYL1g1neRRigFm88Wue9Dl2rKa
	52gFBdakK7YMgpFvMI/MVqLqi8WDOGXA8wObAeDwJZWHSKJb8ijlDrfdF7SjifbbWigWZIrTvt3Go
	sshp2CuOeWvRkf6D/aXGeO23rzxQfbNSD/o7H2HKRUHwGzYEwQ1e0gWyTuQC2YC85AJI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169714-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169714: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit1:host-ping-check-xen:fail:heisenbug
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=d615b5416f8a1afeb82d13b238f8152c572d59c0
X-Osstest-Versions-That:
    linux=af2d861d4cd2a4da5137f795ee3509e6f944a25b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 00:27:02 +0000

flight 169714 linux-linus real [real]
flight 169720 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169714/
http://logs.test-lab.xenproject.org/osstest/logs/169720/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl           8 xen-boot            fail pass in 169720-retest
 test-armhf-armhf-xl-credit1  10 host-ping-check-xen fail pass in 169720-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 169720 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 169720 never pass
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 169720 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 169720 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 169696
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169696
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169696
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169696
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169696
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169696
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169696
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169696
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169696
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                d615b5416f8a1afeb82d13b238f8152c572d59c0
baseline version:
 linux                af2d861d4cd2a4da5137f795ee3509e6f944a25b

Last test of basis   169696  2022-04-25 01:57:56 Z    0 days
Testing same since   169714  2022-04-25 18:09:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jaegeuk Kim <jaegeuk@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   af2d861d4cd2..d615b5416f8a  d615b5416f8a1afeb82d13b238f8152c572d59c0 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 01:04:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 01:04:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313373.530878 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj9cj-0001pl-Uy; Tue, 26 Apr 2022 01:04:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313373.530878; Tue, 26 Apr 2022 01:04:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nj9cj-0001pe-Rb; Tue, 26 Apr 2022 01:04:13 +0000
Received: by outflank-mailman (input) for mailman id 313373;
 Tue, 26 Apr 2022 01:04:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj9cj-0001pU-0l; Tue, 26 Apr 2022 01:04:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj9ci-0006iu-Sm; Tue, 26 Apr 2022 01:04:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nj9ci-0007h8-GR; Tue, 26 Apr 2022 01:04:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nj9ci-0005GB-Fv; Tue, 26 Apr 2022 01:04:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zwMtj4IFztv0BrPCd/YqeqituM4cETACNk3/+Gmn45Q=; b=47CDRWAQjsy8ElaD6PcbpVVOL2
	l405P0pymK2ld8irdmV2ZVJehAdrH3FsaeyG1JMGvyJxJXUdeSMNvGj5FF5OgYV0mWsJyn82GWcv/
	X9o+S8U8flCRAc0duzUUqUQRNz9/fb9lbcKl1SYlDY9GGtIty1XT2Rf5HB9Bp0pgxRM8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169721-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169721: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 01:04:12 +0000

flight 169721 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169721/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  631 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 01:36:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 01:36:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313384.530889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njA7k-0005ZC-Dh; Tue, 26 Apr 2022 01:36:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313384.530889; Tue, 26 Apr 2022 01:36:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njA7k-0005Z5-9O; Tue, 26 Apr 2022 01:36:16 +0000
Received: by outflank-mailman (input) for mailman id 313384;
 Tue, 26 Apr 2022 01:36:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgZt=VE=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1njA7j-0005Yz-7J
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 01:36:15 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3f9e5054-c501-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 03:36:11 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23Q1ZnqI032875
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 25 Apr 2022 21:35:55 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23Q1ZmND032874;
 Mon, 25 Apr 2022 18:35:48 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f9e5054-c501-11ec-8fc2-03012f2f19d4
Date: Mon, 25 Apr 2022 18:35:48 -0700
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
        xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: OS Headers hypercall.h/hypervisor.h
Message-ID: <YmdMdBLbly1ae0l2@mattapan.m5p.com>
References: <Yj+ekdLdRa9U7dfa@mattapan.m5p.com>
 <alpine.DEB.2.22.394.2203281523230.2910984@ubuntu-linux-20-04-desktop>
 <c999faa3-ded7-64af-7bf1-f6b8e5620425@suse.com>
 <YkUAlWH6imVV9D00@mattapan.m5p.com>
 <701a0bdc-a8d3-06c3-7e40-e741dfa45361@xen.org>
 <e4b554db-5adf-91c3-476f-05721e74c069@xen.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e4b554db-5adf-91c3-476f-05721e74c069@xen.org>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

I dislike the adding yet more junk into the global namespace, so I had
opted for use of inline functions.  The approach of adding underscores
to globals though does generally work.


I took a look at the file arch/x86/include/asm/xen/hypercall.h in the
Linux kernel.  The only explicitly listed author is Keir A Fraser and
has the GPLv2 or MIT license like most of the Xen headers.

Clearly though there was a heavy rewrite by Jeremy Fitzhardinge at
e74359028d54.  Interestingly, the current header doesn't need much
adjustment to work for with Xen/ARM.  The registers have distinct names,
ARM doesn't clobber as many registers and the instruction for the
hypercall is different.  Yet since these are all isolated as distinct
macros, adding ARM support would be easy.


What I really need is advice for the direction the project of getting
FreeBSD operational on Xen/ARM should take.  Should I use
Stefano Stabellini's hypercall.S file?  Should I try to merge headers
together and share the main body of the hypercall.h header?

I like merging things due to less work in the long term, just I'm
concerned there is a trap waiting for me if I go this direction.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Tue Apr 26 01:44:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 01:44:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313394.530900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njAFP-00076z-A3; Tue, 26 Apr 2022 01:44:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313394.530900; Tue, 26 Apr 2022 01:44:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njAFP-00076r-4N; Tue, 26 Apr 2022 01:44:11 +0000
Received: by outflank-mailman (input) for mailman id 313394;
 Tue, 26 Apr 2022 01:44:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njAFN-00076h-VZ; Tue, 26 Apr 2022 01:44:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njAFN-0007UK-U9; Tue, 26 Apr 2022 01:44:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njAFN-0000Jw-FH; Tue, 26 Apr 2022 01:44:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njAFN-00008c-Eq; Tue, 26 Apr 2022 01:44:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=I64tWMJmnE+HYslsNzk4bjNrUMAz/2XtBeIGIyUlE0g=; b=eBUu7q2jDr05US0UHk8ntx6Qbl
	HHWQ/BL5/qzYOpZ/zLM382OL+7DYJuyT0aU3K7DqySwS/vyPY5JfcZxoP1XawFw4kBR3gDJJIIJmn
	OhM36gIXMRSULrBSM666V63wHHx7egvEa07iKGWfAkZAB1/ujgNLueFLqA93mBHmrYp0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169722-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169722: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 01:44:09 +0000

flight 169722 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169722/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   55 days  632 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 02:34:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 02:34:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313403.530911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njB2C-0004sv-1N; Tue, 26 Apr 2022 02:34:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313403.530911; Tue, 26 Apr 2022 02:34:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njB2B-0004so-Tc; Tue, 26 Apr 2022 02:34:35 +0000
Received: by outflank-mailman (input) for mailman id 313403;
 Tue, 26 Apr 2022 02:34:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IJm2=VE=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njB2A-0004si-DJ
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 02:34:34 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 678b061a-c509-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 04:34:33 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0EBEFB81BA9;
 Tue, 26 Apr 2022 02:34:32 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55AFCC385A7;
 Tue, 26 Apr 2022 02:34:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 678b061a-c509-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1650940470;
	bh=A7Fx2dBy23978ttmxnVbfI3IAfe7cU81rx3fd4TQUDY=;
	h=Date:From:To:cc:Subject:From;
	b=NQO40yBLGnJTyl3Liu+N5J5XfU26shXgGlFlpKVYTk4qYiZ3AE19fTvcYR9iogHOY
	 0YWCKbhp0fJQPhygwRfZkA8Y7VYpCA4rZeW8/Zh0//kCFs/8uJe+819Tf8LgpRmoF9
	 WyiRpWkir99hYjRRYLzxkylvsNXiT/cqqXkVSWY0zTdawgVEPf6HJcyTHTqmO+gKf/
	 xFfH1C9L+hV2SIprvrrXQ2GVY2at9g6yuRo9vyt6TM2xmK5pTo1rRz63o0JeSffjTg
	 yvn7HyiqM+MHOf7vqsvcQLf6+onHxTJhMj5wXsKedodDiETPVakD0RAr9ddwhlhUH5
	 9oJomjRJMkxRw==
Date: Mon, 25 Apr 2022 19:34:30 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: jbeulich@suse.com, andrew.cooper3@citrix.com, julien@xen.org, 
    Bertrand.Marquis@arm.com, roger.pau@citrix.com
cc: sstabellini@kernel.org, george.dunlap@citrix.com, 
    xen-devel@lists.xenproject.org, Artem_Mygaiev@epam.com
Subject: Xen MISRA C meeting
Message-ID: <alpine.DEB.2.22.394.2204251730000.915916@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi all,

I would like to schedule a meeting to discuss Xen and MISRA C with the
Xen community. I have a proposal on how to make progress in terms of
MISRA C adoption in Xen and I would like to get your feedback on it.

The meeting is open to anybody. The Xen x86 and ARM maintainers' input
is required to make progress, please fill the Doodle poll by the end of
Wed Apr 27 if possible.

https://doodle.com/meeting/participate/id/elY67vja

If no slots work in the Doodle poll for everyone we could consider
re-using the Xen Community call slot (it is one of the Doodle poll
slots).

Cheers,

Stefano


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 02:42:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 02:42:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313409.530922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njB9v-0006Tx-Qy; Tue, 26 Apr 2022 02:42:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313409.530922; Tue, 26 Apr 2022 02:42:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njB9v-0006Tq-Nz; Tue, 26 Apr 2022 02:42:35 +0000
Received: by outflank-mailman (input) for mailman id 313409;
 Tue, 26 Apr 2022 02:42:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njB9v-0006Tg-6r; Tue, 26 Apr 2022 02:42:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njB9v-0000T2-3Q; Tue, 26 Apr 2022 02:42:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njB9u-0001mL-Nv; Tue, 26 Apr 2022 02:42:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njB9u-0005TB-NT; Tue, 26 Apr 2022 02:42:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PTMaBGZ7CpDYY/ldzW3Lxh2SV2b26WGrzUEyBywrDQM=; b=eoSEEnuL4XNtGp4HNQPA2Tgpv4
	PBtjxOmjXAgJGPCyrvjZddylMW03fA16VL+WVoc//D5hH5E8bPWwoGzw+cftTcoBSAPnX/kxpPdqs
	kQbRGO0y77R/O2UPZEpCdZt9dUDonTgn+C87l4tBVm6WhrjqbEe8gyHdUK2z00e2qdJk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169717-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169717: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c49abc8406086398de4062ce9b58f67a23b0ca1f
X-Osstest-Versions-That:
    qemuu=754f756cc4c6d9d14b7230c62b5bb20f9d655888
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 02:42:34 +0000

flight 169717 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169717/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169629
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169629
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169629
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169629
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169629
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169629
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169629
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169629
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c49abc8406086398de4062ce9b58f67a23b0ca1f
baseline version:
 qemuu                754f756cc4c6d9d14b7230c62b5bb20f9d655888

Last test of basis   169629  2022-04-22 18:42:21 Z    3 days
Testing same since   169717  2022-04-25 21:07:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Richard Henderson <richard.henderson@linaro.org>
  Sakshi Kaushik <sakshikaushik717@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   754f756cc4..c49abc8406  c49abc8406086398de4062ce9b58f67a23b0ca1f -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 04:05:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 04:05:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313422.530933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njCRO-0007OS-0K; Tue, 26 Apr 2022 04:04:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313422.530933; Tue, 26 Apr 2022 04:04:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njCRN-0007OL-TO; Tue, 26 Apr 2022 04:04:41 +0000
Received: by outflank-mailman (input) for mailman id 313422;
 Tue, 26 Apr 2022 04:04:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njCRM-0007OB-KW; Tue, 26 Apr 2022 04:04:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njCRM-0001xu-Ck; Tue, 26 Apr 2022 04:04:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njCRM-0006wp-2M; Tue, 26 Apr 2022 04:04:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njCRM-0007tZ-1s; Tue, 26 Apr 2022 04:04:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xdwL7s3kwb5TccwaaqDZkncUzBhaID4hNMBFzfnxB+o=; b=oEz9Pg7hEWPayQzgdV/XvAIp3x
	oGi1qTMtFdydzys7UbaC++pfV+xbj5OP9PMwihGZh4HJwrgubJbeYAdxkK65Gwuc2Ydl7/mtnggqz
	SfzaGgjI4gvBvqQQ7uhJtPXQBsXtU9n0KdVGRe/jg/zh/re9BpnPrWrXOdpPKYAQptV8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169724-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169724: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 04:04:40 +0000

flight 169724 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169724/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  633 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 04:16:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 04:16:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313430.530944 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njCdB-0000qg-4u; Tue, 26 Apr 2022 04:16:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313430.530944; Tue, 26 Apr 2022 04:16:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njCdB-0000qZ-1H; Tue, 26 Apr 2022 04:16:53 +0000
Received: by outflank-mailman (input) for mailman id 313430;
 Tue, 26 Apr 2022 04:16:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jBxj=VE=oracle.com=martin.petersen@srs-se1.protection.inumbo.net>)
 id 1njCd9-0000qT-AX
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 04:16:52 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b0679aa3-c517-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 06:16:48 +0200 (CEST)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23PLV6sI022232;
 Tue, 26 Apr 2022 04:16:28 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmaw4d0w8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 26 Apr 2022 04:16:28 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23Q4AR5j012450; Tue, 26 Apr 2022 04:16:27 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3fp5yj4940-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 26 Apr 2022 04:16:27 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by DM6PR10MB3129.namprd10.prod.outlook.com (2603:10b6:5:1a9::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr
 2022 04:16:24 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::d1db:de4e:9b71:3192]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::d1db:de4e:9b71:3192%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 04:16:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0679aa3-c517-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=VgShOSuxQqfoj97gAL6GK2pWBCOuBmWMfHpOmNYmLms=;
 b=OtYmsq8G8b5RI22dbLOhM5Jw4sreT66i/r4obiHaBmE7x18GcwopAR6A8LjRsyP0yrwu
 /ChcpAp6Eb+flbIKuNrqgeGzAo2MUWXRoZreohyeg2Rk5mO6D+sfmjFltbiKlvM+ELq4
 RwcStAPaLz8AX9im04VlQ59ayyK9WPT2W0QQoZYXQ8mY8foBidZ4jI6BX78BsHu0SlDP
 0e3v4HGavanW1GE7bFS/xzTyDjsi91O1EhjtH7JLEwO9tlcmdUNIQJ+4n3n660UGzZCo
 qfqJQCDk0chCqM7CUmiA+I094CYXxG4ZZB7SXmK+GU4U6eIyF00KFboyDbWOLXmL5mGc 2A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZUOhLZKNL3vrNl/maSq9xt45/b5a9NdXwIhXvstJAYwIsAi0DxupEQl/Yvix7bJkhWOcyWDMj1Z86LqzR2sBaF9Njm7mKI0E7iPfS6tvhupy6YoXis7wjl2yAmEg3XVwIwnRD7TXGS7Lp4uSKHm+D+vNIIKsp07IgnqK3C/esfCnpvAQspS/rwxCLYikKu3NATPpsD8FIckfWAfsADoxVsInmB+mfKQ5CeQKCpwTgVdzibDwYWjb0/FhMPRYu+CM7azS0uotfZMZj4EMLuozZJHZhuyydbp/FNVzkBbrTHENZwrGfiMYt1NkVjqWTGu+IUDuJEm5vrAdkdX6U4bYvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VgShOSuxQqfoj97gAL6GK2pWBCOuBmWMfHpOmNYmLms=;
 b=MELrS1W3JzftJQi7nfd3yt907GKzrEuF69GOSkRcSt/yRF0P26S8bQJ3u5SkwIh0cbPh/4ivs7IazWwxNEzZuDmdrvufbsv1y9r2NtHzoWo80/GIyAOCopQpRS3vQYoRIo4eGWfsudOh0C6qucCJFG21qOmmTOxEKGvrOsUO+etVxSrAc947LtMJM6bXqTIh5nhnlWjxNB0GOtSQ6vZTzyBo+HadFY+E5bfv6pIpzk5wldicLOXEXu+ZRKS1179vvO1XHRQsi8So10WAuPLIms6ajGHbjwXkzrTBwQxPBvDCMrIfTM0degoP/A7PqMTdRDHZbTcDPtXzs1+/+qwQGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VgShOSuxQqfoj97gAL6GK2pWBCOuBmWMfHpOmNYmLms=;
 b=A3am2cwBpuqjfY9kIPSeyfS7WwrY3aqquCThNKiIOdYqL981QzGx0dyEc11s46jGa6ebZeevTJj/79eFZ394X8QAkoUzqgK1xhVr0SGikjY+BNh5NjuNlE+uzRx6fhSULKfR/dmqEh9lDelXfGMgep7VN1yBS1p98+BvJXLcSAU=
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>,
        Johannes Berg <johannes@sipsolutions.net>,
        Josef Bacik
 <josef@toxicpanda.com>,
        "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
        Jack
 Wang <jinpu.wang@ionos.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Roger Pau =?utf-8?Q?Monn=C3=A9?=
 <roger.pau@citrix.com>,
        Mike Snitzer <snitzer@kernel.org>, Song Liu
 <song@kernel.org>,
        Stefan Haberland <sth@linux.ibm.com>,
        Jan Hoeppner
 <hoeppner@linux.ibm.com>,
        "Martin K. Petersen"
 <martin.petersen@oracle.com>,
        linux-um@lists.infradead.org, linux-block@vger.kernel.org,
        nbd@other.debian.org, virtualization@lists.linux-foundation.org,
        xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
        dm-devel@redhat.com
Subject: Re: fix and cleanup discard_alignment handling
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1tuagv5xw.fsf@ca-mkp.ca.oracle.com>
References: <20220418045314.360785-1-hch@lst.de>
Date: Tue, 26 Apr 2022 00:16:21 -0400
In-Reply-To: <20220418045314.360785-1-hch@lst.de> (Christoph Hellwig's message
	of "Mon, 18 Apr 2022 06:53:03 +0200")
Content-Type: text/plain
X-ClientProxiedBy: BYAPR07CA0082.namprd07.prod.outlook.com
 (2603:10b6:a03:12b::23) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 835a5865-72d0-4ac4-b537-08da273b86d0
X-MS-TrafficTypeDiagnostic: DM6PR10MB3129:EE_
X-Microsoft-Antispam-PRVS: 
	<DM6PR10MB31292380D74F76EFD145BA388EFB9@DM6PR10MB3129.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	X0D6KBg3dYE7LKh6WthP6tgUSgJnyXvQVuy37VB7bVFWKyTyZpiYPqKVs3Jzizuwg+Sf92KHStLxr+xa3JI22N1hfVbIdR+D/hINi8ev2jXI5RPeztSc9M7Pfv8wN/KlfccpqYFzZlCo5fZC0qJe9mn6+euobijLQ+ae3W1Q4ZSSK+k6g3gj1X9rr3ZFeCf9R4oOxgqjLqE//AGw5JJz14O+wIKv8oOUSl5DbPRYYE5pYch3DXESswFS7q0LgWDkyynxnMeCOwM3I+ZcXRp0HDOOw38bg1/UmGwk7R6kKoQT09BnhshRQptOGkKJbk1TqA3ojIMkvwsO3BvRvme7OKVzKhtfYOrpHTxE1nDe7oUu1zaDggjj9Hx+tUiT2rsXAHF4nqmCzuVh5sZx8O3Fr3KQAaZ0iGVMV17moVVHaqC7x0Ze//UiVG51Ku4RDI3eHLUHWoAnGy3IJzDuYBG/otHNI3ceEV+qLsmjxX8+cDTfHXvH4dK89dvlqS3ADewVSJmXUQBL3kRw79LXhxkRdbBZckOUrZjGYfDlE6UNpH3ka85nzwyCT15D+xxviw7SVLIkB+uYD47wiiadu9xCVEbX7c1Bbglyrs2g+wOET49yX+M04p188Ceo0MX4Z0s/fEANDpsEvkPbetZ+B9iMa8H7On2NO3ifD93u8aM1pkJwPcnEAW2NFb6Go6fxxHT6CptTyDO4NAfDFQ+CIZFuRA==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(52116002)(8936002)(186003)(4744005)(86362001)(7416002)(508600001)(2906002)(6666004)(6512007)(6506007)(26005)(36916002)(38100700002)(38350700002)(83380400001)(5660300002)(316002)(6916009)(4326008)(8676002)(6486002)(66476007)(66556008)(54906003)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?TB4tA924ES23Jbjeya1BYJTs1OvtA/zZv6THpxhMU79cce2hBvRPpiS49za3?=
 =?us-ascii?Q?mUONwmtJsiCknSg/EcY91oV51b/6kYP1mGaQV91M1HhGLu1bE/mmUjgXe5BE?=
 =?us-ascii?Q?SqqnyHd99Z6KyY5CLuitjo7OSNvyWpQ3ukZ8SyjQEJIcvnq3Gg3EkU5R+HG3?=
 =?us-ascii?Q?F8fUv9n6HOda4W/bB+HraU/tzreM8+EWPjk2HYGDdAC7U32s3JGn4V6pFdjc?=
 =?us-ascii?Q?EyZC/gXEK2RXovs+rqNtiXAn8Y1xnn5A0A4Nh1NIJFpuaTiTpo2VmTYmol6m?=
 =?us-ascii?Q?0UbCryYNd+ZCvW5dW/X4TU1Qv+oPKgMV9lqUzmk7xOYKt+9B/hPqNDcHBglp?=
 =?us-ascii?Q?XTeDDi8XHXO1D5P3WLajf6NjFpitG4XqaV9vmUxClpxedVXvRbi98PBuLTeF?=
 =?us-ascii?Q?BKRu/8UIxZUe9pthO/CO66KVDUBcGOnzELJEsoRFs08hY/UG2sqncy7tgt0t?=
 =?us-ascii?Q?nvA55r3YQu8SSkHhw50KmjFF706K/czmMyEdVi2HXCzcPiOxOs7KvhJywE1B?=
 =?us-ascii?Q?Eh1gGP/2tgTCaYhCTSs1zZ+ZFeoSw0ocq/HEgpIntTv6HJtpQx6KqSRGOXV7?=
 =?us-ascii?Q?JcDQxbe1XhEdhnAbfzp6vEcG6YCNbs0SIxKP6hS7jAteqV8nRLnAjLRy1Pph?=
 =?us-ascii?Q?H6E+hxLB1CInAKwRT0/+o/fAsfmcGgoDJAnIfVg8BZ67BgRdV2VALulbozvP?=
 =?us-ascii?Q?2wnmKY+uku255u0vK1dEoptoo6YpiOODxrPEKu2rm5dJklw426eL7Pcbf6mB?=
 =?us-ascii?Q?2jo0Q1xNQoM3RmwrrrIufsvxMNGmz1mWqLgExox8rn0CGer6iwJVzl7MHvtx?=
 =?us-ascii?Q?WSisn2XeQ31GZs2Ays3lwTmolcCHLf1sN39+oJQziOJg5iSOUBlrE3qY9ryn?=
 =?us-ascii?Q?Ddy2KZo9oGxfl0CzSidZvVjfHjOQuDCpI794Pucgfowl2w2KruGMXZS3GVgl?=
 =?us-ascii?Q?QB4KWlnDOPGRepoOY18EgaS2wd3XXbdWYFxh7NY0ySmiq96j9DUNERGzOtGP?=
 =?us-ascii?Q?ke8nRsN6Uts+l5dXLI1WLLJtOTOMskxZ5cqzXGXbWfs6cnqNc4N47g+MOOMi?=
 =?us-ascii?Q?khwSby0iMLA5fQsyRHYHr+Yt2+cgpCymS7woTMu5/GYc2Qz71IwKaYYrE0T4?=
 =?us-ascii?Q?yiHlseLzNfilBiXLRkBdCfz1quf0+RtPshsIz4+ucUYTNDgmJi75SEuIBUEP?=
 =?us-ascii?Q?Aqhzuj7AMa3Y9agTnz1W+7vd7+L4aj3Hz1KF6fS2W+PqHp6HVS757X8KtSDp?=
 =?us-ascii?Q?00DgbNPViQTRs9TQ//lU3PUutFq7odj+TM3IxVZlfds0Qyg3pxbOo0g4JNg1?=
 =?us-ascii?Q?sMXx2p6R35Wqw94RidfoO22d7QrxNBSa2tC5TV1fuA5Xo0CrGQkdrvgBTJVO?=
 =?us-ascii?Q?6YNaMJanUjQJVYnjGO6DkWgTuVC/n+nGFzYXeqdMymlT1wFUzJlaASPKrpyF?=
 =?us-ascii?Q?SQJvJ90b4tiE3DW5z5HBnA85+dXINGsNFxdRxipwE6F0s4T4sLeeFObSgiNe?=
 =?us-ascii?Q?0PU//rhhc23Negk43JrkvaDsNkInRzuILS80NmHqquWDI/2TR1/Jwq2acRt+?=
 =?us-ascii?Q?pDpZbxqRYu0dB0FOfOHQwMQMUtJXNwhRUEyyKvKFB1kh9YRCqY7Le4w8GOcL?=
 =?us-ascii?Q?68r28By/gaXsB3HU2N6tNEWEddQVidZzuQSCRzX6xxDgwLEGc1T4y59QDQ3m?=
 =?us-ascii?Q?XW6XaDzoV+2/HLCd7yg08CDJxvE5dwpDDIETeYfsVF8WLkmnrhL6SSnsWcHg?=
 =?us-ascii?Q?//ysxLiDUE8tILEWYPxrVO9Squzf3gk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 835a5865-72d0-4ac4-b537-08da273b86d0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 04:16:24.7224
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nf2TI3DEgT4qtSJndbWmRFqMGbzkMS2vq7+Y5mOBDAJDRs7oHXuyNKkAk9ybd0dRtdbzLEe54D/bHDq4bXF1AdU2cnvLzYXAEPCE3V3v7Ak=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3129
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-26_01:2022-04-25,2022-04-26 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204260025
X-Proofpoint-GUID: 76EsLqdiuyTX3yre8fbQOOLA-RdU5MY-
X-Proofpoint-ORIG-GUID: 76EsLqdiuyTX3yre8fbQOOLA-RdU5MY-


Christoph,

> the somewhat confusing name of the discard_alignment queue limit, that
> really is an offset for the discard granularity mislead a lot of
> driver authors to set it to an incorrect value.  This series tries to
> fix up all these cases.

Not sure how I ended up with "discard_alignment" when I called the
corresponding I/O parameter "alignment_offset".

Anyway. All this looks good to me.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 05:16:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 05:16:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313436.530955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njDYk-0007MV-Fj; Tue, 26 Apr 2022 05:16:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313436.530955; Tue, 26 Apr 2022 05:16:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njDYk-0007MO-CM; Tue, 26 Apr 2022 05:16:22 +0000
Received: by outflank-mailman (input) for mailman id 313436;
 Tue, 26 Apr 2022 05:16:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YDip=VE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njDYi-0007MH-W0
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 05:16:21 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 00b3a8ab-c520-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 07:16:18 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C9084210E8;
 Tue, 26 Apr 2022 05:16:17 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4315913223;
 Tue, 26 Apr 2022 05:16:17 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id K1XhDiGAZ2LFRwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 26 Apr 2022 05:16:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00b3a8ab-c520-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650950177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZCoeM4JLJRZv91zVqOeQJ5/8H6MTwPNt5+hI8rEBIkQ=;
	b=FlUkqw3Ln42pNuaVZf+kmf/aR9cWXGsmQEKD97mh3r6JbfW0u3oMjgCmWKi38Kkt4d660F
	qs6klxlojz1emAoKpJ0SefGfQ+uGjWi9UDCeNTz33wBn2AZoDgaJbvmlyEDTcWg2DX9Kpu
	SQzfr8ELHJmexAo+VX1ZdJQmVRYjgZk=
Message-ID: <7d89848a-3a1c-415d-957a-564ffdd3712d@suse.com>
Date: Tue, 26 Apr 2022 07:16:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>, Oleksandr <olekstysh@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,
 x86@kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Tom Lendacky <thomas.lendacky@amd.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
 <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
 <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com> <YmcR5bfaYh1z7VUq@zn.tnic>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
In-Reply-To: <YmcR5bfaYh1z7VUq@zn.tnic>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------0OFpyagCUbHUsEPp0MKRIkcF"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------0OFpyagCUbHUsEPp0MKRIkcF
Content-Type: multipart/mixed; boundary="------------Lg4Hw02qSJPGaq60PuAa8cdb";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>, Oleksandr <olekstysh@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,
 x86@kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <7d89848a-3a1c-415d-957a-564ffdd3712d@suse.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
 <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
 <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com> <YmcR5bfaYh1z7VUq@zn.tnic>
In-Reply-To: <YmcR5bfaYh1z7VUq@zn.tnic>

--------------Lg4Hw02qSJPGaq60PuAa8cdb
Content-Type: multipart/mixed; boundary="------------akIgyRCybXfK1tmLdSdEvfDU"

--------------akIgyRCybXfK1tmLdSdEvfDU
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjUuMDQuMjIgMjM6MjUsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gTW9uLCBB
cHIgMjUsIDIwMjIgYXQgMTE6Mzg6MzZQTSArMDMwMCwgT2xla3NhbmRyIHdyb3RlOg0KPj4g
ZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvY2NfcGxhdGZvcm0uaCBiL2luY2x1ZGUvbGlu
dXgvY2NfcGxhdGZvcm0uaA0KPj4gaW5kZXggZWZkODIwNS4uZDA2YmM3YSAxMDA2NDQNCj4+
IC0tLSBhL2luY2x1ZGUvbGludXgvY2NfcGxhdGZvcm0uaA0KPj4gKysrIGIvaW5jbHVkZS9s
aW51eC9jY19wbGF0Zm9ybS5oDQo+PiBAQCAtNzIsNiArNzIsMTkgQEAgZW51bSBjY19hdHRy
IHsNCj4+ICDCoMKgwqDCoMKgwqDCoMKgICogRXhhbXBsZXMgaW5jbHVkZSBURFggZ3Vlc3Qg
JiBTRVYuDQo+PiAgwqDCoMKgwqDCoMKgwqDCoCAqLw0KPj4gIMKgwqDCoMKgwqDCoMKgIEND
X0FUVFJfR1VFU1RfVU5ST0xMX1NUUklOR19JTywNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqAg
LyoqDQo+PiArwqDCoMKgwqDCoMKgwqAgKiBAQ0NfQVRUUl9HVUVTVF9NRU1fQUNDRVNTX1JF
U1RSSUNURUQ6IFJlc3RyaWN0ZWQgbWVtb3J5IGFjY2VzcyB0bw0KPj4gK8KgwqDCoMKgwqDC
oMKgICrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEd1ZXN0IG1lbW9yeSBpcyBhY3RpdmUNCj4+
ICvCoMKgwqDCoMKgwqDCoCAqDQo+PiArwqDCoMKgwqDCoMKgwqAgKiBUaGUgcGxhdGZvcm0v
T1MgaXMgcnVubmluZyBhcyBhIGd1ZXN0L3ZpcnR1YWwgbWFjaGluZSBhbmQgdXNlcw0KPj4g
K8KgwqDCoMKgwqDCoMKgICogdGhlIHJlc3RyaWN0ZWQgYWNjZXNzIHRvIGl0cyBtZW1vcnku
IFRoaXMgYXR0cmlidXRlIGlzIHNldCBpZg0KPj4gZWl0aGVyDQo+PiArwqDCoMKgwqDCoMKg
wqAgKiBHdWVzdCBtZW1vcnkgZW5jcnlwdGlvbiBvciByZXN0cmljdGVkIG1lbW9yeSBhY2Nl
c3MgdXNpbmcgWGVuDQo+PiBncmFudA0KPj4gK8KgwqDCoMKgwqDCoMKgICogbWFwcGluZ3Mg
aXMgYWN0aXZlLg0KPj4gK8KgwqDCoMKgwqDCoMKgICoNCj4+ICvCoMKgwqDCoMKgwqDCoCAq
IEV4YW1wbGVzIGluY2x1ZGUgWGVuIGd1ZXN0IGFuZCBTRVYuDQo+IA0KPiBXYWl0LCB3aGFh
YXQ/DQo+IA0KPiBUaGUgY2NfcGxhdGZvcm0qIHN0dWZmIGlzIGZvciAqY29uZmlkZW50aWFs
IGNvbXB1dGluZyogZ3Vlc3RzIHRvIGNoZWNrDQo+IGRpZmZlcmVudCBwbGF0Zm9ybSBhc3Bl
Y3RzLg0KPiANCj4gIEZyb20gcXVpY2tseSBza2ltbWluZyBvdmVyIHRoaXMsIHRoaXMgbG9v
a3MgbGlrZSBhIG1pc3VzZSB0byBtZS4NCg0KQ2hyaXN0b3BoIHN1Z2dlc3RlZCAocmF0aGVy
IGZpcm1seSkgdGhpcyB3b3VsZCBiZSB0aGUgd2F5IHRvIGdvLg0KDQo+IA0KPiBXaHkgY2Fu
J3QgeW91IHF1ZXJ5IHRoaXMgZnJvbSB0aGUgaHlwZXJ2aXNvciBqdXN0IGxpa2UgeW91IGRv
IHlvdXIgb3RoZXINCj4gcXVlcnlpbmcgYWJvdXQgd2hhdCBpcyBzdXBwb3J0ZWQsIGV0Yz8g
SHlwZXJjYWxscywgQ1BVSUQsIHdoYXRldmVyLi4uDQoNClRoaXMgaXMgbmVlZGVkIG9uIGd1
ZXN0IHNpZGUgYXQgYSByYXRoZXIgaHlwZXJ2aXNvciBpbmRlcGVuZGVudCBwbGFjZS4NCg0K
U28gYSBjYXBhYmlsaXR5IG9mIHNvbWUgc29ydCBzZWVtcyBhcHByb3ByaWF0ZS4NCg0KQW5v
dGhlciBzdWdnZXN0aW9uIG9mIG1pbmUgd2FzIHRvIGhhdmUgYSBjYWxsYmFjayAob3IgZmxh
ZykgaW4NCnN0cnVjdCB4ODZfaHlwZXJfcnVudGltZSBmb3IgdGhhdCBwdXJwb3NlLg0KDQoN
Ckp1ZXJnZW4NCg==
--------------akIgyRCybXfK1tmLdSdEvfDU
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------akIgyRCybXfK1tmLdSdEvfDU--

--------------Lg4Hw02qSJPGaq60PuAa8cdb--

--------------0OFpyagCUbHUsEPp0MKRIkcF
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJngCAFAwAAAAAACgkQsN6d1ii/Ey8R
Fgf/cb5IBTZcx7aS+LRpOM25mHfb/IvUsF1FOM+Oqb5mC5sfdn9j8s5KfWbL7jR3pOYw932FG4B9
HibQvCEsGLrsOHmafIEeU1WPni37diDLE6B8/T3ZaXbp9xfFfx45jb9nQqn3xKZ0eTxSZwo/vJal
jgo54wIoFm3apt2GkDQTcwRxNZRtBASPqAmQ2pGpTkaewbT74E1HayVhOkjbZ1vvpVugEKI6I8Le
yTEt7zBzAdcU3wfCLCjA58ddXd4g2/Rs8iXky8Hdr2XSOQ1qIHCwhsEyLnjkfy7IVwZ5obUiV/4V
MOPVUmPZWdZjqpjJUw3SNiznFfzOXSRsxZMku4jQQQ==
=KXAT
-----END PGP SIGNATURE-----

--------------0OFpyagCUbHUsEPp0MKRIkcF--


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 05:59:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 05:59:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313443.530966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njEES-00038W-SY; Tue, 26 Apr 2022 05:59:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313443.530966; Tue, 26 Apr 2022 05:59:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njEES-00038P-PV; Tue, 26 Apr 2022 05:59:28 +0000
Received: by outflank-mailman (input) for mailman id 313443;
 Tue, 26 Apr 2022 05:59:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njEER-00038F-NS; Tue, 26 Apr 2022 05:59:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njEER-0004J8-HW; Tue, 26 Apr 2022 05:59:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njEER-0004vA-6d; Tue, 26 Apr 2022 05:59:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njEER-0002cp-6A; Tue, 26 Apr 2022 05:59:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=D4QkAcYdlxJD52UI0wHUN3LOlar0wfSjrBzrv526mZE=; b=zztQ3QW30cA4EEof6sPBrZu04U
	MJusU5J7f0vPri2yfoRlScATgqFzABUErKPEnsk79SAN2FlGQPB7r0fd6ToSJlGOxZI5rVsBbrotJ
	ZjH1IQrQ02uk0kycxrJ5Y25nw7Cm0xdgjBkMsSWHZZ0rzU+obrcAhtXgL1JTygb+y7tI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169726-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169726: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 05:59:27 +0000

flight 169726 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169726/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  634 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 06:36:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 06:36:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313452.530976 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njEnT-0007M5-L5; Tue, 26 Apr 2022 06:35:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313452.530976; Tue, 26 Apr 2022 06:35:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njEnT-0007Ly-I4; Tue, 26 Apr 2022 06:35:39 +0000
Received: by outflank-mailman (input) for mailman id 313452;
 Tue, 26 Apr 2022 06:35:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njEnS-0007Ls-Eb
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 06:35:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 14a3e837-c52b-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 08:35:36 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-nsfmmzyNMU287z33FuIIng-1; Tue, 26 Apr 2022 08:35:32 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PA4PR04MB7630.eurprd04.prod.outlook.com (2603:10a6:102:ec::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 06:35:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 06:35:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14a3e837-c52b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650954936;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qcCVFyv0cbzKV80b6CyuFDTdQsQeNKXTwHyhv2INAVE=;
	b=H8iIYx55/tKYVnaYJkeSppfQ7WYBnOVbxn8XOyBLpX84gEoWuhhoOaFZV8SQuyHBUkfYB0
	fdes0d5BD6NZIi04XarhCWQaeuch3Pa2v0eGDuqJaQzC1tD3/0eQaLd/LbT7nlOMMeLKRH
	C3zj+fqHKaNEAj7gtKsaXsqILm06KKk=
X-MC-Unique: nsfmmzyNMU287z33FuIIng-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mr/V+WuMa/jZlQzFO4AL1ifw5fpXjI+HORwp0QX1O/0P/XfHvaBHp6IZwpX8IZHgz4MbsZfTJZKGsh7DZ0993Xf+WNE3+Cl3QK0tZjUIHaUEqjJnCFIvzHEKRavhBbzlLmp7igZvUrMCcl2MFfkMgRJJClwYpyyL3oGS5RwVe0+yhzHB2NumOOzO5CWac7wwl/UFflDVwbgiKV+QaEXDmcESmtCxz1MG/fZEgFtWHTmUKN2b3/qSU9lwtLJoCggJyeccf9CH2wUqOPefeRhLs1Zy4Mwic+7q8AyNPFSjLgXVqwTFcvDoLNumrHDk1RY/+s33MGuy5DYT9VL7wo2OSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qcCVFyv0cbzKV80b6CyuFDTdQsQeNKXTwHyhv2INAVE=;
 b=Y285KV6nbBG7YCafQFAJ/QeH5KGLV/JEw/7r58a/33RKfbfCmR0J/Z9onhsJuPnQqLhYGy6qbLl5/4r480H2FphyhIl8jOpRKAk83l4E2Z1btkcET+c+cOl+ClcCFNd8JyLWWiQQ61Bo+52I8mP8BhoH1P45WbUR+pFw4LB1ajYjrCBCRFadz4LYfDqhe3E1qgNW192VYVczsxOCM7X5IaDM0bqz678GGJ/VYP8N5fN7OuuoUjB48W2GtRzeMVm8LZfXQ7SWH4DvHJdvYtE9r8D9luWchKoJ0INNHBV74pudm7mo6jZw7i+CP1XbesO8uLrh2km9SwsxHaMrocAnVg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f82679b4-8b2a-ff9c-cc2c-60ba9b737de9@suse.com>
Date: Tue, 26 Apr 2022 08:35:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4 1/2] xsm: create idle domain privileged and demote
 after setup
Content-Language: en-US
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>
References: <20220425172231.27401-1-dpsmith@apertussolutions.com>
 <20220425172231.27401-2-dpsmith@apertussolutions.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220425172231.27401-2-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0115.eurprd04.prod.outlook.com
 (2603:10a6:20b:531::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 208bc49d-0715-42ad-3f57-08da274ef4dd
X-MS-TrafficTypeDiagnostic: PA4PR04MB7630:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB7630E2F2CA92909598E1D538B3FB9@PA4PR04MB7630.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	647psJ0X9/286433INnsi3Y/8VWBtOndCPU1nlLJPTmqcbo3H3hI9m/0JZyF18aGdV5p8dDHymr6B4PeufjNZZlPzIZhF0DivLVN9VGM57poyRkOqnKvNikSY0NpuM6/iDUw7NetMXWmp7qu567KMwvEXYbvTbjyp26R8vzJVtqN7dBKNvX7nz8RjLp5Pc+sW8yYVXP4Q5U3gnRUwQxLwFLirPF8MTfScGiY9BnfQW4+blvJqBM8bj1RDhgpscHVoYKhEEdv/sr8/u3DTosRlct2EwsErM0RU4nBrG1WK401S31cIRM/otclWOCHFQdAA9M0vPZqUFKC5ibSQH/ESf209YILdephJbksP5bsM/UnQHjiaQqcmFi9h7liQJtnyWi1u5PM6NcInqfX8utpfyJirE8nziIUE1R+V4QPvnYF+/2IEObv37eUJUYcPwDXFanLdaYJ6vSW2cOed9rAg0mtFI5O/Ll8S0k2WzYh0Y7d9TV5xujEPuRBwgIPKLb/4y+RGCZXMidlROaqWEdFDlOiAWHIv2pInJbhvDfJV2xDowmI0kWbSOpL+KDFABLpPTX2ze9w2TrghQDJtrL05rS3nnURcS347jKoX/NUYt2C13lvKTVi1uwXoAtPHjm3vdi7NU9kTsrb2S+K8WlACOiJJokSXCAO3uLLUEpV8XHeHIdlTa4LQFDlV5w5Zz5/DdhCaOyDHcn8nyF16S5+QhaI1nYjygSwIf2PMfdPTftupyujHw5uH6mA1mw4oug7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(5660300002)(8936002)(83380400001)(36756003)(26005)(4326008)(31696002)(53546011)(7416002)(2906002)(66476007)(186003)(31686004)(86362001)(508600001)(8676002)(2616005)(6486002)(316002)(66556008)(38100700002)(66946007)(54906003)(6916009)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Um9wd2F6QkFEODdPanB5L2xPRnJqNENtb2NERFdLVnNIL1o1SDVZN3FEb1pk?=
 =?utf-8?B?ekt2dnI4Um9NSTNRRmM0aVF2Y05SZml1bGxYNG5xZWI0ODRTNmdMSkg4UDlv?=
 =?utf-8?B?em41djlDZlAzdjAxR2JWSEluc296cGs1UVhPWHhsczV2TWJ1UHQrem9vNFdB?=
 =?utf-8?B?QUdWdmN3emdtcVRPZ1FXdHQ5SW1aY1JQSDM0ZHliaWk2Ui94QTVYMnVyTWRQ?=
 =?utf-8?B?bUo1cmJRUmV2WkIwRnRIVHFlZm1ydURodkZ0d0pRRmc2QUVoWFlvOXVXWGhF?=
 =?utf-8?B?eVY0LzI0YWlwY0hJQklXZG11b2wvdW1GL0F3d1NHRlI3T0c3cEFBM2RiYkoz?=
 =?utf-8?B?bm9GNHVwTyt2dno1WWtTR0lZZEtOL1BkNEhRVldBbURKdlU0WU5PLzIxdGdY?=
 =?utf-8?B?bmFhWDZGY2l0czJZbGRPTGh2dDhnRDd6a3dneDZPZUdQQXpmampUQUV4OTJt?=
 =?utf-8?B?YjFXaFo0WGtWRnYyY0dFNjAycU1JcGl3RklsWGwzSDZNRWduVEVNUjd6Y1FY?=
 =?utf-8?B?ZXkySW5xajZtaUxTOHB6QnQ5ZnZQRldhNHVOV2NKZ3Z1VnFUcGtyWWxaK2lK?=
 =?utf-8?B?WGdZZFNaMXJWUXlINmlJcU5DOTYzQ0FOdVl6RmtOYVZJOWgyaldZUklqOWlZ?=
 =?utf-8?B?M2NUM0UvckFFRm42Skw4TkloRFNOUE5INXY3MzFyMXRTd2RaUzIxMEdBOVFG?=
 =?utf-8?B?RWxPRFkrZ20zZHUyMm05SHM5Y3BSTlg3c1hUaDBtL0tjK29RUlE1eEQ5d1Bs?=
 =?utf-8?B?NFJRaFNSM2NyRHY4d3FHd1JQTGx4ZWhiUDkyeGJpY3diRGMwYzgzN3RFUEpq?=
 =?utf-8?B?VldUcmpNYnkrZGJSSkp3WUNxbXNuUjd5aGxqdHBLckhsZFRBTCtpbjRLSzV6?=
 =?utf-8?B?M29WaTZmbWJrQ1k4RWJCSjh6c1ZkakFmK1gwUXBmZ2hYTU1Jd3NuUlBENnNx?=
 =?utf-8?B?RW44TjdVZS9MTXR1aEc0bDVJWnRoT0g5SjVaOUxCWTdRbzBLVENZZm1kZTE5?=
 =?utf-8?B?VXM2SGs4Ujc2d25RNmZWUGNPWFo2SndHL3A1bW5PaW5OVkkxTXRrK2gvUkZ0?=
 =?utf-8?B?YTN4RGxNTFVWSGliSVJtRGJwVzdNbkZNWmR0VVJwWldrdXh5d1pwanRIRGda?=
 =?utf-8?B?TzZTSVI2WDY0OHZSSkk0M1pZTU9NWDFhcm55RXlHUjU0YnJRbU51YmZ3RHhs?=
 =?utf-8?B?b2x3TXRldnhNekpxc0JHR2xvSGFDUWRvaHBSVmtYcW1kQ0dldXhtTGdFRzZG?=
 =?utf-8?B?dkxsSU5kem5rcm04cyt5UlVnQUpaTUtNejFxbURZZnhPWWJYSE5LOUFZa2RB?=
 =?utf-8?B?N0Q4VUxvYU9HVTNJQjBBWXEvRUFUNHhmNER1OXhSUXppRHVLd0FaeXpDcWVL?=
 =?utf-8?B?QlpNUElKTDRERHNzaEZibXl4RGp5dnJ0VnBzOVdBdkovZjBkKzh1eTZSd0dC?=
 =?utf-8?B?SSsrMGNFaUNXcGxXc2pEZFNDRlpreWJkV3kzZ3kvbk5kTFlPMzhjbjhiQVpE?=
 =?utf-8?B?eU1PTkh4dHZkRGxTZFlsRWxWc21SVGpocWJZNmFrQTJ2djJJa3lSQTVRRWIw?=
 =?utf-8?B?ek1nQWFpZnNzdHB5VFNDeUkxS3hIODhYUk12anhKMHpqckVadG9vNVV6R3J4?=
 =?utf-8?B?MjFhS2pJOFZmVHNJdldGRGVoYlhnVHRYRG5zMTFLRzA3UlpScWVkbkw2YjJ6?=
 =?utf-8?B?dHhWcjBGSDdjZDkxd3hzNkRPTTV2eXE1MFRCTmwzaGg0T3ROZXR4U2kxOXky?=
 =?utf-8?B?QzhYeGIzMmRCMzMzdHRSM0Z5MGtOVUxOMlVxaWlkZ2YyZ2F1WXVOQll2akNj?=
 =?utf-8?B?c1JBWWFselBPbzQ4TVVwQkZiOGJHN0dxb29pWXdEeGF6a0ZUM0NaVjdWRXpC?=
 =?utf-8?B?QzhoNG15ZUV1WXA4WCt6eXVnbWRoT0V5bUVIcFNzaEZYYzRxQWRDNTc2dUJU?=
 =?utf-8?B?SGhpTjNrSFFLVE0wYXVHcyttMlZFM3FkekxOMUF2N2hleHhCK21TUU9ualV3?=
 =?utf-8?B?WElBN2tsVmEzTVZYeEcvajJyUWFaSFE5WVZoYm5MSUQ0Y0dRRThzTzRmaVR4?=
 =?utf-8?B?TjdEQVRudHZ0SjBReHZEK2xHc2pzamRoZkxTYTZ2dUJWWVlWeDlqSG5kOStC?=
 =?utf-8?B?UmlUVEdqMjh5d3ViZTNEYmIreWhjZTV3TU9uOFpCT2ZhcUtRR3NXbmxMd01s?=
 =?utf-8?B?K3hVbUN0RzU4S2hEQjcyMjc0ZE9ycFFsKythd2dEdzNBVmtMTzZUV05CSUpu?=
 =?utf-8?B?R0RkNFNHK290cEtFRk9CS3V4SGRnbml3ZzBzRW10NUNxaExnTkpXNHRCMHdv?=
 =?utf-8?B?dlRRb1p2d3JyTW1SSHJMSkpmeWxCT2FVbytuSWRKbk84eTEvdk5Bdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 208bc49d-0715-42ad-3f57-08da274ef4dd
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 06:35:29.6356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bH6igb/3nXytBz5WCXzmH/tTUDXBHeRrvFyx51OCmHtHyNZf/TC1Ldfm8GyyIH91+KlgriaRVhMPBMVUunVSPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7630

On 25.04.2022 19:22, Daniel P. Smith wrote:
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
>      void *va;
>      unsigned long start, end;
>  
> +    if ( xsm_set_system_active() != 0 )
> +        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");

Roger did request that the panic() either also report the error
code, or that the function be returning bool. You did neither,
and your earlier verbal reply also didn't really respond to this
part of Roger's comments.

> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>      return 0;
>  }
>  
> +static int cf_check flask_set_system_active(void)
> +{
> +    struct domain *d = current->domain;
> +
> +    if ( d->domain_id != DOMID_IDLE )
> +    {
> +        printk("xsm_set_system_active should only be called by idle domain\n");
> +        return -EPERM;
> +    }
> +
> +    /*
> +     * While is_privileged has no significant meaning under flask, set to false
> +     * as there are times in hypervisor code privilege checks check this
> +     * directly instead of going through XSM.
> +     */

It feels as if there is "which" missing between "checks" and "check",
or something else (better fitting "as there are times"), without which
the sentence is a little hard to follow.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 06:43:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 06:43:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313458.530988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njEvM-0000Q0-DE; Tue, 26 Apr 2022 06:43:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313458.530988; Tue, 26 Apr 2022 06:43:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njEvM-0000Pt-A3; Tue, 26 Apr 2022 06:43:48 +0000
Received: by outflank-mailman (input) for mailman id 313458;
 Tue, 26 Apr 2022 06:43:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njEvL-0000Pn-0F
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 06:43:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38308c10-c52c-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 08:43:45 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-bKGG0EMaN_KxcxaYJfKWzA-1; Tue, 26 Apr 2022 08:43:44 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5287.eurprd04.prod.outlook.com (2603:10a6:20b:7::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 06:43:42 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 06:43:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38308c10-c52c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650955425;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mbpB8bXWJ8os4uKsHgZoARTuDXfvIZfhceEPa9udbPE=;
	b=mmEc4Fxcc4697ZzwlwRjdXng6XkbuaentZ4dPzAXQzDFt2cYoEDi+qVV0qCUDIcJaRUwVt
	VHyH+tjw6mPpx59gp9EgHqk08g+sXk5M34V9A4cT3sGUYMjJXNRNcjSgaOl2W4cS0uksJb
	Acc19ObAj/02iEL9J8YyWmG85mwTcwQ=
X-MC-Unique: bKGG0EMaN_KxcxaYJfKWzA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C5e7l9y+nciH2ZNl0KrcaNd462fuE4DDlyrVoUsI97VXm61ESvSMcXIrg/lH1IOZcNX0vP6MUHiuOzwQEwD3ucBqyxzJUISg98NEhkXieTPpJgxg6pcrpbvdsFX1MGRWjQ8WzUCUMbv7UTFJP4iK9iPY1GzS7YMa7fF9tZOMr9/6FJy85LtxT2KiqzIbpKlA9Y1GWa6gTlD+WO8XCjpq4RjeAjSYS5PPZHAZzquaG1eFN2/JL8eO9wxnQOcLcmhU3t5jjSnLE8/ySeDXX7onN7OaQyd9Agmx0ZewieKuiAW7yzhrVVlL3dCFcrcoWVe2rM+eVENSH46UVg7+GwM9zA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mbpB8bXWJ8os4uKsHgZoARTuDXfvIZfhceEPa9udbPE=;
 b=XN3oFKSPO74lUMp/uke5cA5CBoiWC56fQUNUSLYJqn+3qt1KHh/a0A3CUaFT3O3W4qjDHL86J/SCuSp+6kVxRXxc+hthcUEUExb+0ZZwpIT0QCxnFFh9HvjLyfnsN6V3DK+0JpAO81IZOct2b31fGIciQwVY1TTtAeKN+zf0sURYfWFyCTGh7Leud4CysUzr8g7s3+xTjb75l4SnUOi8rJlsrjMrR8TEDeyOjR3SVcfuJbctqDHW08O6M99CeYGrwyCirhMFNl7vFv51J0mxU8t8LcQ2ZWIhs7AXsQXo6qVtcirRZb6oANJxCN22cEm1zgU9ounEW01kdT/VPddeqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d93fee60-0d17-06ee-bb8f-e68ad5aa4fb4@suse.com>
Date: Tue, 26 Apr 2022 08:43:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86/nospec: Fix evaluate_nospec() code generation under
 Clang
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220425175603.21086-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220425175603.21086-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0165.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d89d52cf-f18b-42e6-5cb4-08da27501aa1
X-MS-TrafficTypeDiagnostic: AM6PR04MB5287:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB52875C8BC290579EB634EEF4B3FB9@AM6PR04MB5287.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4hOLuVAn7pDTIBagXttPhliM+wyt9JXq0PSL1+/mY7AhtRigdia3pCoF/yo44ojmAILwopFfXj6cd6C1BLZKL599v8OD96M1i4vvr4AlxShRiRhYuGtHB2Psi5zujkpK5MFJgMjCNiTeT2eijz09ACV0MgCS/dOaafmdbhnyLZTQgx5HU5M8LAAA+W4UGkk5R2jJWJjmwfM57tZBqEuBPR5lF+gTDDOn1HqeIoyWWSVXJFSHmF19a4HNJAgjVsKiab6oIlVXVLZ8yZNKDP3pPPJaP5kQXeuZovNjqkd4l1rNYK9zvk8SaphRbvyMwAuyYXCmkjg5519mthsDdPxsb2dDyBWPKs0pk7U5LWEmMRbKBRIXGz8g+1zlF3rmCSwsR6K6UgC7lVpw0SNNiCYOtbmsyFhwsOonIc1X3rcHijwOI0UzIgmXITAX220ZMUcJKfyWGVVGNWE8YRyQOyflcncGyotkd+q3aVSlSzjNI4RSxVIKd50+MSAC3aZaMbNw3m3s0NIDofyRM1GxGn38ommdDpr45xNYcbBpPUM+B10883OEOZwIB2GxC5PrJ47vfIIhyXNaXwrfdpPrgWzT4L6oU7lgKL/WjS5X1g7NGQ1EZKI0/55Ktjx7ktI+8PuhY+ddWWeTXSNJUsd4Npsu49bFgJI6O2KFXs5vsvI6VDU9QIvV4TnUpTkRRn6Qjh1QfTqXgI8xBgSxCbtDCkP3YrENDEb8d0hsqPS7WlKcJ419hYUMm+ab2kAYt3YMN5H4
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(4326008)(6486002)(508600001)(66556008)(66476007)(8676002)(86362001)(31696002)(6916009)(54906003)(38100700002)(66946007)(6506007)(5660300002)(53546011)(2906002)(36756003)(6512007)(83380400001)(31686004)(26005)(186003)(8936002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WUhBOU1LNjRhOFVuTUExdzhIOS9EN0pld2MvbE1hR0ZBMG8rZExobk02ZzB6?=
 =?utf-8?B?TUU1T204aGJPM1ZWOUZ6T2NUYWY3RVhxQUJCWW9qdVVjSFlkbXlIYnhBSzJp?=
 =?utf-8?B?UG15VUFibTgyU1A2emlKUlJJbWkwMWM1YWRLQVFPWjNZV1ZZV0N6ZVpiRjFa?=
 =?utf-8?B?eTZNU1JlVlZMZXBpRzJseDQvOFBRTDY0M3daRnZCKysxK29jaVpMMUdlUGth?=
 =?utf-8?B?dUFqVzlXbG0yUXpjRUFwdTZvOWtIY0hXdVZrc3VsV1FBcEFaMkpwcEYraXlY?=
 =?utf-8?B?Qy9oMVprcis1WjUzSHk5TnlkUjRKTzc3VzQzblFmalFidFhPSTdKd3B5RUdD?=
 =?utf-8?B?T1lqeHVLcWVVRXFULzZhVXBTZnJqdm81RS9hNXNSZzJhclQvUnlEK1NzQm9F?=
 =?utf-8?B?Yy9pTS95MHhPNTArNmpXUzA0K3dNWVpBemNST0RSQXFPVFhlQ3crNzFzb0F0?=
 =?utf-8?B?NW5aaFBZOWlISWozRWZ1S2tTOVRhaW9LMUVlTTFhUUhidDcxWVVFVUJuYlZy?=
 =?utf-8?B?VGM2RkltRE90LzNjdVVid0Irc3o0dFlHTEtYM21EZkkveDJJK0xaaTFURG41?=
 =?utf-8?B?ODJRNzI1UHVpeWtJSDZFTkpiZ0FueHk1Q0I2VHhlTFp5Lzh0Y3Q3MTIwanRO?=
 =?utf-8?B?S21UTTNpcCthNzZncUQvWjQxcHZKVFY4N3hsUDJnMjdka3V0Z2ppdnhLU2VG?=
 =?utf-8?B?RmRpL2pHY2svWUZwNStCbnp1ZGxTNjh5Y1Yxb1RSQVY4QisrQkVoSzdZZHh5?=
 =?utf-8?B?c3VJTDJXb3BJQU9Ub1ZRb3dqNk84NjN3amRLY2hRME5uZnMyQWo3bzVHa0tR?=
 =?utf-8?B?THBKbzRkR3RHSjVMRmhqdjF3bEphT0lmK3hYYjBOUmVTbXovZFpaOE5vVVA2?=
 =?utf-8?B?dE1FSE5rVmlFU3pXVk40d3Frak9JYURrdmd2SzdqZGFYd01CSVI5NTN0bDhR?=
 =?utf-8?B?MGF5a1hRQVZnTWNiUVBEbDc2cVJWYjh2QVBzcHVEY1c4Y05KMXlROVZZS3F6?=
 =?utf-8?B?V1lnSmc5aGx0dkhNQmFabDlSMG1rdXFqTjlHa3ZxdW5McFRwT1FpWkdyajlE?=
 =?utf-8?B?YlZhSjNnU0JFQlF3WW9mZzA0S1lscm5acTg2eG9NMkxBYmxnQm94MXU3M1FG?=
 =?utf-8?B?RjNVdVpvZVhOMEk5bEpLWXN6cGJOMm1oOFJnOU42YzRnSm12U24wdHF0cU02?=
 =?utf-8?B?dmdCWE1GT1dJdlhoMnkvMnd4RU1zQ0s3b3JabGtGVEM1OGM4L1NkQVdnb2Zp?=
 =?utf-8?B?UXlhYVMyT1hTS2VtbDhGWmdRU2U2RDdtQTFSUFFZblNRb1dOTFFpSnl3MVY4?=
 =?utf-8?B?RkQyMEpDQWdZRElSY2Q5dHMydE9TMWR1cnFUUVpOUUxaYUdRbXdVUVpkQmJt?=
 =?utf-8?B?djZGTWtrbURTUG9FM1BQRnRUSjRHQUNqTG1rWkVXWHcrMTVTdG5NV2tyc0pD?=
 =?utf-8?B?MVJENzgzR3ZvSkxkK1BLelRGK3U0dU1iUjZzUnN6Y3V4Uzh2by82bTViSFZn?=
 =?utf-8?B?cFRnelVIZWJoNmEvZjJSY1MyWExYUmY2VzZxZUwvRTVHWW5vTTlWWDJjZ25N?=
 =?utf-8?B?SzY5K2U0UDgvVlZDeHFBYW9uS3Z5WmlJN21NVnRiT1phNGJsdmM2dUJ4T1lF?=
 =?utf-8?B?am5KYkpHVHNHVGZxRUxMcm9PcXE1bG04MVNtengwc3V1dWpFUUpjUDg0dkZD?=
 =?utf-8?B?eDE3bVhTdDNrRWNrSFBNeXpGZ2VBM2VndGRBVUx4cHVoQzdEbU5xR09ZQVl3?=
 =?utf-8?B?S1M0SFlVeGVVRFhUclplVzY0cEdHZWREeWxabE45dHk4UGk3WXdOdCt2aDli?=
 =?utf-8?B?eW1YN3F0K2s4SW5qdE85WFpYZEFCU0pTS3pBODFhRkczNnlwTW5yN2JUR29D?=
 =?utf-8?B?T0NnbWZjK0JyUzYvZVpZb1FZT3g4TnVIaG1CRkVXVkg4azhaUFVRbDB0bktp?=
 =?utf-8?B?TlNsZXUyNTU0MUFKbzhDMHRFMmJjUEpBeDc1M0dzS1JPZW5STzBYelFwVzNj?=
 =?utf-8?B?bFlmd0pRZEcyaXBBalhaMWUvRm9Namg2UHBSblVpNW1nNE4xQk9IRjlMbG43?=
 =?utf-8?B?YXdKdjY0aDJUMUJzNSs4SXMwQjJiNUVwdHhsOWkwN0xOQXdiMFFJSEluendX?=
 =?utf-8?B?S2ludVNLSlZwUnBOWVJHNEpSRE5PMVRGdlNPUnVidytEclZGMkdhbGYrdGZ0?=
 =?utf-8?B?RjVYdGZCbjdyaTF5cGR4VFh6Qi9oaHVEcysxa2FCZGk4RnhURi9GSDkvSHNy?=
 =?utf-8?B?OGdQOEsyK1R0U1p3TVh2Nno5OCtNU0Nlc1ZnaTIzTXN4RktQK0ttL3BsMURl?=
 =?utf-8?B?RHBxZVVLWVhaYWFGQVNVZVhrVWExZTRUNGJCdUdYZ0YxT3JzekRYZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d89d52cf-f18b-42e6-5cb4-08da27501aa1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 06:43:42.5089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XprUknWbFbNbWRx6SUpaw9FQi3Uqg2HvYjy0uCujSf7yUTjOmagBsfsMx8dcEky+HYDz4S5Olxh255IO2o6WPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5287

On 25.04.2022 19:56, Andrew Cooper wrote:
> It turns out that evaluate_nospec() code generation is not safe under Clang.
> Given:
> 
>   void eval_nospec_test(int x)
>   {
>       if ( evaluate_nospec(x) )
>           asm volatile ("nop #true" ::: "memory");
>       else
>           asm volatile ("nop #false" ::: "memory");
>   }
> 
> Clang emits:
> 
>   <eval_nospec_test>:
>          0f ae e8                lfence
>          85 ff                   test   %edi,%edi
>          74 02                   je     <eval_nospec_test+0x9>
>          90                      nop
>          c3                      ret
>          90                      nop
>          c3                      ret
> 
> which is not safe because the lfence has been hoisted above the conditional
> jump.  Clang concludes that both barrier_nospec_true()'s have identical side
> effects and can safely be merged.
> 
> Clang can be persuaded that the side effects are different if there are
> different comments in the asm blocks.  This is fragile, but no more fragile
> that other aspects of this construct.
> 
> Introduce barrier_nospec_false() with a separate internal comment to prevent
> Clang merging it with barrier_nospec_true() despite the otherwise-identical
> content.  The generated code now becomes:
> 
>   <eval_nospec_test>:
>          85 ff                   test   %edi,%edi
>          74 05                   je     <eval_nospec_test+0x9>
>          0f ae e8                lfence
>          90                      nop
>          c3                      ret
>          0f ae e8                lfence
>          90                      nop
>          c3                      ret
> 
> which has the correct number of lfence's, and in the correct place.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

I can live with us going this route, so
Reviewed-by: Jan Beulich <jbeulich@suse.com>

However, I'd like alternatives to be considered: Would two asm()s
perhaps not be candidates for merging when they have different
(perhaps fake) arguments or clobbers? If so, would this be less
fragile than relying on comments, which clearly any layer could be
viewed as free to strip off (when the same isn't true for arguments
and clobbers)?

Also you did say you'd open an issue with Clang to try to get their
view on relying on comments here. Could you please add a reference
to that issue in the description here?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 07:06:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 07:06:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313466.530999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njFHh-0002vT-E0; Tue, 26 Apr 2022 07:06:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313466.530999; Tue, 26 Apr 2022 07:06:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njFHh-0002vM-B2; Tue, 26 Apr 2022 07:06:53 +0000
Received: by outflank-mailman (input) for mailman id 313466;
 Tue, 26 Apr 2022 07:06:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cQU5=VE=citrix.com=prvs=10866150f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njFHf-0002vG-Of
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 07:06:51 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7024ae3a-c52f-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 09:06:49 +0200 (CEST)
Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 03:06:46 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BYAPR03MB4838.namprd03.prod.outlook.com (2603:10b6:a03:131::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 26 Apr
 2022 07:06:43 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 07:06:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7024ae3a-c52f-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650956809;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=mNKzBOORQKlziI4DJ7+vFlSWrz3yE7Flrx0i8KYJWws=;
  b=S0I5wTUl4OXbvVio/hnr1t8lkSlu9CNb9OoIknZYn0IZL4Yr8WQtiUEa
   79aLOoXAt2LMQxs9dx4cgwVlOKlKb2ffbRJRZEFPQNJfPFNOnvHyKT6Rb
   wSgJV6KIQsbOM03T2WEsrLq+hAaAxVDenyB3E4eOlGgSyn5qF72gniwJW
   k=;
X-IronPort-RemoteIP: 104.47.57.174
X-IronPort-MID: 69320574
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:6nIhYqrPo2sfcCAt8Qjz7dcWKx5eBmJ4ZBIvgKrLsJaIsI4StFCzt
 garIBmPM/bbM2Lyfdt+YIW1oU9SuZGByoA1GVQ4qH00Ey5AopuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 42q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBY4/1lNsiWgdkPGJYBqwB54XrIWCBmJnGp6HGWyOEL/RGKmgTZNRd1sMpRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFg3Fp2Zwm8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrL9PFtuzWMkGSd1pDmKeTbQNy7FfkE3U+jt
 z+ZvGjhBDwFYYn3JT2ttyjEavX0tS76XpkWGZWg9uZ2mlyDgGAeYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQnZKflhsVWt4VH+hk7giIk/PQ+1zAWTRCSSNdYts7ssNwXSYty
 lKCg9LuA3poraGRTnWesLyTqFteJBQoEIPLXgdcJSNt3jUpiNhbYs7nJjq7LJOIsw==
IronPort-HdrOrdr: A9a23:Ygb+Nq6WObQAaDH2pgPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN
 MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt
 gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd
 L6IRlliVI=
X-IronPort-AV: E=Sophos;i="5.90,290,1643691600"; 
   d="scan'208";a="69320574"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YvEv63oGToaaibB+CFhYB4TDJiSOSieY2a6MWs9L2TpYnhRfzv+8/BcF5D2DbIDskL/1SqLFC3V7IyS1zSrNgRbEy+qYqLPaZY9ojFanAewfOC8Ciuq/iGJ8tgPQhSb+M06VPcTNuagIimVTbfvCuXJDXyy46s1e57XnSZkNu5t0UWG/dEKE1b0eMAEKbFWHRbk1/7gnwQJ5IzCFLobj4YhmK7/6a1F5rRvo3qxJ4b7LDnlyt7TqOYIZygvS26hVQqb/NmX5FXh5Nu1FLGfMFLWCsWBx3tHbyjMvaH5TsfUNwe9ECvPRLcAWgdBMMXYuo+eRif3hZThHmbxX0zS4fA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tb5knrh+daCPNrHN00hxV2sQj33vMgeL3TVFsgtYrPE=;
 b=XOv3aQCTSfMAy7BIJhqz0mrvQK/Eh38KMn6dLs9DqQiq2u4VQkMyqv0FtHi6dj47o9aIxuV1+33g+uGgjdgHinYfgm9KiPg8LEiBCJYPFgInCsJXG2si4cO6qlEvk4qgpxzUNFpJ2WOIKO0cEDsq+MFUTBIfn+0hzbCw5oM7F79W5qcKXH6f42WRdoVoOWpznxxbXZynuLiioHjW4RmIcfTDQ7Vic4ARPGuagoPn1MoBtPVxHzA6zdSfsbmEBHGfF6AP5AYgyjY6xWYfyL4tHJt/M0vff+Aob0FCF1lqxYn1RoZEV7vpKEZNGVTKrfzgZldE8SIwrjJ6tqAXaSmBqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tb5knrh+daCPNrHN00hxV2sQj33vMgeL3TVFsgtYrPE=;
 b=M4h6bF4iwH34hdXYq/RDysQ4Xf+weuxV7+w8FDf/17zxWGlPj/EvrT1gtQTg44Wt6PCFdsCdY13SIX5LPKvjj3IkQ7Gyz+oOTPQ5kFWd4k+s9wmOQQZy/sHLPZpStbCJoxvV0JvwF90r29RXNTd2JvkY+9IquDmeTckn6wrBtfM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 26 Apr 2022 09:06:39 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Steffen Einsle <einsle@phptrix.de>
Cc: xen-devel@lists.xenproject.org
Subject: Re: DomU Windows Server Essentials crashes with xen 4.16 but works
 with xen 4.14
Message-ID: <YmeZ/8wtKJy7zzmS@Air-de-Roger>
References: <18bd542a-a649-c78b-b575-c62b4d533e44@phptrix.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <18bd542a-a649-c78b-b575-c62b4d533e44@phptrix.de>
X-ClientProxiedBy: MR1P264CA0129.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bae1e054-b9bb-4453-139f-08da275351ce
X-MS-TrafficTypeDiagnostic: BYAPR03MB4838:EE_
X-Microsoft-Antispam-PRVS:
	<BYAPR03MB48383E2EABB717647292B5E58FFB9@BYAPR03MB4838.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dek1hTQsXV+S1MsD9WGJpdFjS0q5gUVHChIOBNlscPCy84v57+NSpq5gZFWfKlIKleVuGfsqhZEGw5EkCfWDZa6ILpZBAaYhtPZdSdOtmN5a15WPY4q0W9uDJO50YbY0nZEGBr3JknWL86YbCfH/lYitEM1HZAu1nEkSTGbpVglfnYAUwLE3p3pyXpSfk0PR+PU80CE/oUAR7ykb8Twl9jLTgrDu07B19TlW7naCstSSSqe8Ug52NgyQ2hhvwbbyU0O+lxVvXIt8M9oVboH+R7Wx/Z65xBL6/86cnwnTwfMluBmKFg9Vqw1QIPu6PTe04HbfafYVDAU8ejyAzY3juXzuXCW+uRt0GqF8+kuBYMRoyYss49u3qtUJwFvgNk2ctlMuZ4V5LrSiU3J53J7BaxYF1pYUVyVeqvFyhc+AAvHw7osIR+dU5rUF3yH31sOmWYO89ujUsj7HMl69I3EJPdSrZ5wlTQ6c8u1TMG68+bYaWX4H1B3vmyWDdbRbimdiRGGfjzIZnoAqflbabtHD23Ap2vpjnwjl3n71Ds3U+heuGFkxbzk9oAAivEkicrOYX9nTALXNBHHblS6sQiGWJobh8bTwARW/UidZBfXGRhnD/LC3E/X0lHmn5+ofJC1kS//d7rYXNx1BbQLKcIV5uA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8936002)(38100700002)(85182001)(8676002)(66946007)(66476007)(66556008)(5660300002)(4326008)(26005)(2906002)(186003)(6512007)(6666004)(6506007)(9686003)(83380400001)(6486002)(508600001)(316002)(6916009)(86362001)(82960400001)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cDJGcllEZ1QzVGU1UlI0b1h5NGRXOXliOUhoeW42UWxCUlJUVnNpbGtYRS9n?=
 =?utf-8?B?R21peEdiOXptaGdNWlFoVUFjZFc0bUdlS3YrVHU4dURybExEWjd0MjhnTXQ0?=
 =?utf-8?B?Vnc4UmRRYjBYZlV5K1RsRXJrdGxGVFhiZlhBdDNTbVluNWhQSzd5NGtuaVBu?=
 =?utf-8?B?V1h1amh0L29EWW1xdUZ2L3RqYzF3Ui9TZk1LaWdyKzNxNmhWWC9VbHZldGxD?=
 =?utf-8?B?TjVRNXA4YWF1N1R6Q2kwaTg0a1FXdmUxcGlraEF4MWNsRXVqWHBxRFEreTJ0?=
 =?utf-8?B?YytCdHVVREFJVzZxeVFCYkcxb3lvWWx1QWx0OHR3N0czSnVySGtyOTdpek5Y?=
 =?utf-8?B?M2lqTkJ6cGcySEZZTE9qNTM5TU1rZmk4R2NyMEFUZjNZc1hFNXlIdUpPSVBL?=
 =?utf-8?B?K2o5UkQwSW16VWw5aXdYSTFCYXlQeERmWHFscys1NnEzYTRrc3VIL1BabkRt?=
 =?utf-8?B?WUlOd1BLT1Z6dldRTEZycGNqUlFDcld4dDduY00zSVB6TW9rMDFkNE1Id2tN?=
 =?utf-8?B?MmJ2Vi9UMWF1V3NHdm9zTGtYbmk1YUsrTm5wNCs5VmRnQmJLL1hYblA3WlR3?=
 =?utf-8?B?YjlKWjNGWkFPNTlQV2dnSGJDQ3Z1eTlNR2wzR3VEWTV1dmF0WURWYkhpTTFn?=
 =?utf-8?B?YkphZHI3UExQTkRodFRZZWF4emw0MUZkTzZwSi84cFJBU3c1c0lzeTQyR0sy?=
 =?utf-8?B?R25yMTlxcUNIYzNhSXhFaEdIK3Jpb2Y3UlRCYjEzdlJnTDNPQVpHYnFRdnRQ?=
 =?utf-8?B?dE53bEk3V3VzeEZzWXY2eFBqenc0alVseWtGclMxZXl2czFlNDAyTmY4V0Iy?=
 =?utf-8?B?dmRQTm9DM2x2RGhtZDh2V001N0x5NUJDUHh2NVpCeG96aFpGaFl5WWN6bzZ1?=
 =?utf-8?B?ZDI4RERORS9Kenc5UnNsVTd2VTZxc0kwUlFZOXVqblIxYkxqdmkwemFtMjJJ?=
 =?utf-8?B?MTgyYllJbUVzWUtac1d5bFNoeGFBaWtjUmlicTNUT3dTd2tNWW9aS3N1R0Ju?=
 =?utf-8?B?RkpXRDVwaTE5eVVRS2tuL0FHdjRoNFloaFFOSjRxMExTdGRiTGNQdFdVVHdL?=
 =?utf-8?B?bWlYNGFzSHZmaytsQXpGSEZYQXZaSTdSUU5xZGJLTVc4ZS9FeldQTTRqVUFC?=
 =?utf-8?B?L0VmYXJ3ME5OeDBaNUgyeWx4eWhWc2dPeTdXS2tZZE9Dd1lJNmNCMlNrajc5?=
 =?utf-8?B?V09ZYk1jYWxadCtXakdIcDFJUElhc29SM1Nyc0FHUW5KQU01MkZVSGp1MDVo?=
 =?utf-8?B?N0lZaWt0bVY1TENjRnBxT2JENmhPREIzUHorUitwOWJnam9BaTVGWTNWV21H?=
 =?utf-8?B?cGVaSldXcmNNWVFiN2tWL2RHeU16N1U3K2hBK1BvQ25KQ3lzdUdvNmlHT1hh?=
 =?utf-8?B?ZUpocWhyK0wzUXExUG9laXhNQ0tSTGc1Ti95Vk0rR0VFamxrTjdGdWhSWDg4?=
 =?utf-8?B?SC9Id2hCbDk0QU1lbCtFb3FhcFIrVnNwam1NYjFvTm40NTE0SVErTHZwYjUw?=
 =?utf-8?B?VHdzMXRnSDJrR2RoYW54ZFE3OWhXZlJvcWszTlduRzgra2VUWlpJd1FqZ3pi?=
 =?utf-8?B?dFpnVlIyQjk2cFNNcEQ3OVNwM1VpLzZxeXVyL09rSUZwSlEwQWZQeERvdVJ1?=
 =?utf-8?B?VVVLNzBsUk9DMmJJZENaaEF3NE9nWU96MllqU0hNV1F4ODRMTitaSHM3REla?=
 =?utf-8?B?eVRmN25qTitxaU80R01rbWlrVVE1MEhYUktoelpRQmw1MkVqaTVpZnZXcFNs?=
 =?utf-8?B?amVQTGw4ZUkvTDdsTjBlTWc3blY4RlM0ZzB5NER6M3VxUmY2bUxucXoxMERU?=
 =?utf-8?B?MG9WVDFjb3VYbkU5REhOb3FRRUVRTisyemZYakF2NjFqRVZ3dlhuSzFtVDNJ?=
 =?utf-8?B?WnRvcGtwSEtBRUNEWWYyeldDL1RDL2JGOHVEMjV2OWFQeUcwZzBlViswZFhC?=
 =?utf-8?B?UUZJeGdIOG0yUlZ1Vml2eGJFT0w5b1ZkL1FtWldodmdEUWJsS3FTQzIzSWhI?=
 =?utf-8?B?UDNJWnpiZVg5NDdGcktjMlJsUEVFdGl4cVB6TXZzT0xSVzNvditsNnd0Z3Fn?=
 =?utf-8?B?L2E0NFVrVUROYW5HWklSM3Zoa3lteTMrc0xZZUg2TUoweWVNT3l5cjVSYlZk?=
 =?utf-8?B?Tzd0dUFiNWUvWE9pbW1xQTdjNVBNVVNtNEM3aFJrTFpiYW5UZmt1VmJmZWxY?=
 =?utf-8?B?TllDVnFZdk5ZZzZHQlE3RFhlRFBJYW9TUFJuVE03T3pzNWpNNjBlazIvMGNX?=
 =?utf-8?B?V2YzbEFSVXVQZmlNOE5UY1NZdk04aWVEb0V3anBuMzhFZ3FmeFNyU3B3VkF5?=
 =?utf-8?B?ejBORVJDemlRRVRBMzJFTlEwODdUV3UwRzFwZ0Y3c294NFpVbUJCUT09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bae1e054-b9bb-4453-139f-08da275351ce
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 07:06:43.7855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YMYHnaDiHQtjud+JSgMbzX8YsAc/2jd+fmmmGRc1GLHtUxG3uBgcWpoTeUYMaC6KFTr2J+96Do1gwzV08RfgXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4838

On Mon, Apr 25, 2022 at 07:19:08PM +0200, Steffen Einsle wrote:
> Hello Everyone,
> 
> I have some xen servers I recently tried to update from xen 4.14 to xen 4.16
> 
> Everything worked without problem, except for the Windows Server Essentials
> DomUs.
> 
> With xen 4.16 those domains crashed (reproducable) during boot -
> KMODE_EXCEPTION_NOT_HANDLED.
> 
> I tried to install a new DomU Windows Server 2019 Essentials - this VM
> crashed at the first reboot
> (still in the installation routine) with the same error. No PV-drivers
> installed yet.
> 
> I switched back to xen 4.14 and all VMs booted ok without problem.
> 
> All other VMs (Linux-PV, Windows-HVM (2008r2, 2012r2, 2016, 2019, 2022) 
> show no problems, only
> the Windows Server Essentials crashes with xen 4.16.
> 
> The system is a gentoo kernel 5.17.3, qemu-6.2.0-r4, xen-4.16.0-r5,
> xen-tools-4.16.0-r1
> 
> My working configuration is gentoo kernel 5.17.3, qemu-5.2.0-r2,
> xen-4.14.3-r2, xen-tools-4.14.3
> 
> My DomU config file looks like this
> 
> name = 'DC-Server'
> type = 'hvm'
> memory = '8192'
> vcpus = '6'
> vif = [ 'mac=00:16:3E:ab:cd:50,bridge=br0' ]
> disk = [ '/dev/vg1/ServerSys,raw,hda,rw',
>               '/dev/vg1/ServerData,raw,hdb,rw' ]
> viridian = 'all'
> localtime = '1'
> vnc = '1'
> keymap = 'de'
> vnclisten = '0.0.0.0:10,websocket'
> usb = '1'
> usbdevice = 'tablet'
> on_crash  = 'restart'
> boot = 'c'
> xen_platform_pci = '1'
> max_grant_frames = 128

Could you try adding:

msr_relaxed=1

And see if that makes a difference?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 07:13:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 07:13:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313472.531010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njFNl-0004Lv-46; Tue, 26 Apr 2022 07:13:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313472.531010; Tue, 26 Apr 2022 07:13:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njFNl-0004Lo-14; Tue, 26 Apr 2022 07:13:09 +0000
Received: by outflank-mailman (input) for mailman id 313472;
 Tue, 26 Apr 2022 07:13:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cQU5=VE=citrix.com=prvs=10866150f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njFNj-0004Li-Oq
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 07:13:07 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 508fa306-c530-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 09:13:06 +0200 (CEST)
Received: from mail-bn8nam11lp2171.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 03:13:02 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DS7PR03MB5447.namprd03.prod.outlook.com (2603:10b6:5:2c7::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr
 2022 07:12:58 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 07:12:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 508fa306-c530-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650957185;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=PgQeWTlh78mDe08LpMccbH2oq7ntRqKFwtKSvEB0Tzo=;
  b=IjEqSTDJHb+sW2EM667f7+OAkftFkFM9FQH+XUQc36HH8OoYfCQUYrGF
   Rvz3Zm160+R8OnZsH177Si0mkbZ++eBdtDa4l+PexJPoSz3GlGDBRQl+b
   c49uiRP+5T5Yi1pqvCTRRzUn+0MhzKCB88UWzpysO4oKNQyym/QqK2yeb
   o=;
X-IronPort-RemoteIP: 104.47.58.171
X-IronPort-MID: 69320991
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Yd0JtK3ZwINvDms0X/bD5ZJxkn2cJEfYwER7XKvMYLTBsI5bpzxVz
 2caWmuFPa6CZGX3edlwadjlp08BvZGGz9I2HQU5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy34Dga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1vj4SvcxgGGZSTifoAWSgJKBAnAqNJreqvzXiX6aR/zmXgWl61mrBEKhFzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82TBfyVvLe03x9p7ixKNezZa
 McDLyJmcTzLYgFVO0dRA5U79AutrieuKGcA+QPMzUYxyzjD/AtQ2pLECtHuW4aBVO8Isx22h
 kuTqgwVBTlfbrRz0wGt/mq3g+7TnQvyQI8ICKCj7flunUGSwWoIThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYiXN5XH/w/+Ru64KPe6AaEBUAJVjdELtchsaceWjgCx
 lKP2dTzClRHq7aSVW7b+r6KrCiaIjQcN2sLb2kFSmMt4dDlrJsikxHnQdNqEarzhdrwcRnr2
 CyDpiU6g7QVjOYI2r+98FSBhCijzrDLUwo06wP/Tm+jqARja+aNbYGy9ULS6/oGKY+DV0SAp
 1ANgc3Y5+cLZbmPniGQROQGHJmy+u2IdjbbhDZHE5co+Dus/HqiVZtN+zw4L0BsWu4IdjPkb
 1XakR9A759Uen2xZOl4ZJzZNigx5a3pFNCgXPaEaNNLO8F1bFXeo3goYlOM1WfwlkRqibs4J
 ZqQbcerCzAdFLhjyz21Aewa1NfH2xwD+I8afrijpzzP7FZUTCf9pWstWLdWUt0E0Q==
IronPort-HdrOrdr: A9a23:RiSeT69N2rh/UECPIttuk+FKdb1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO
 JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe
 ehD4d81nOdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInhy6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXgIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6X9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfFz9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcwa+d
 FVfYDhDcttABOnhyizhBgt/DXsZAV/Iv6+eDlNhiTPuAIm3kyQzCMjtbkidzk7hdcAoqJ/lp
 X525RT5c9zp/AtHNJA7cc6MLyK4z/2MGTx2Fz7GyWVKIg3f1TwlrXQ3JIZoMmXRb1g9upBpH
 2GaiITiVIP
X-IronPort-AV: E=Sophos;i="5.90,290,1643691600"; 
   d="scan'208";a="69320991"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WW6ZmzaZQzWPfcSTHoorTjjH4Yu98jl/t2Rs/WjTgh5f63Cvt6TLTnD5HNynwH/zJ9DirV5ruTe88M9gY0H62pzu0llFRhcjx495c4J6FlNEH7gJ9ulsXIUag5fiKy4BSx1NXdPE8hvY4C34+XQZmcDzheRLKmLOaK/tYL3RFROh0TuifZSSoM98yeJxPQl0nUWS181YyJ8e4u4CYe0AuZ+Q4ec2+RebAk29UNNlpq4w/M0go0gbt0znMoXNK7V3L011Bm24K8yGRSKXd2FrhM3+4BbtePd+McnZRq87lFS4IcT7IvTbBCGSDhJ2YYG3eHjHVqV5A/a4UyTkuquRsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mnAj+ibkU6zymtcm59DbtnqdExUD9SINdw3zagV1Wfc=;
 b=NiaAisvznkeBuWfCkhjiSTOlunf+P7vtnuhaX4JM/xEyLL9hK52ME929f9uZwTec8QXY+0UFTRVBJEKGSl4PyRQMCTfuqY6fx6FDFcCW2DecqbUdTojJZ68Szjmkz8pw/tgb/IA61o3h8SXRq3OXVJsfBeyu2RQNfuqE5Lfr/tAekcK979bpn00IavnxbOB32plsevvdomVoJCuQr7QYj3PGIOlJ3L4V2lq9NgmGfHQAfy1/HdlS7iCC7+t5FB2pU4LW/NncEYE54dHpxCnGFY10gd5sLQJqY2HQqXYqgOit6V+tyxYfOxTExQ8kLs1RdUqdxAIS8C6B+g3jMP/plQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mnAj+ibkU6zymtcm59DbtnqdExUD9SINdw3zagV1Wfc=;
 b=HoRlk0LbxDCsN+cXMkpLcN3y2TbiTLLlDXRgWMowXPGyPwAwL3cuYBZeb+kg0Gh87CoVOUaty18UGYHT+0OZ9iTNt0QB4az1+ottnngFcQ4Va+eZqKjgDo8ngcubL381xYZelbpLERosvHVTy3+2QuQ31cuUcjzyY7nZec9jFLw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 26 Apr 2022 09:12:53 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>, scott.davis@starlab.io, jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote
 after setup
Message-ID: <YmebdccTfa7wKc9U@Air-de-Roger>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
 <20220422163458.30170-2-dpsmith@apertussolutions.com>
 <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
 <25e701d4-62ae-278d-b165-2201459c7cee@apertussolutions.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <25e701d4-62ae-278d-b165-2201459c7cee@apertussolutions.com>
X-ClientProxiedBy: MR2P264CA0074.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0a05ced1-b7c5-4ac7-8bfc-08da27543115
X-MS-TrafficTypeDiagnostic: DS7PR03MB5447:EE_
X-Microsoft-Antispam-PRVS:
	<DS7PR03MB5447D1EC7465DF09B187707F8FFB9@DS7PR03MB5447.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	M1Rz4U5W3ym/XIxD0pX7LaCA3EuCuO3xNFxGmfHDcg0qqPUUl0rzslTONp6FfX+d+NcuTd+1wT6FWZF6B8a82zcE6hU+wOK0CkAUZv4D5J2yHAtaHhp5CwcD+Z+Wt0jrYuFgra+j/OhCjJTqO3imeVkZ5bHD9YZSTjpXDTFmM9A7K0s5fjMgGkVLPMOY/Qq9UZvYivCsK+nclbIDhO9gtYy5Wijb5kHYPIzYtJhbZ/J5QT6/bTj0EE28IRXw2fDzncDXFY38jYGnfGaSVHdHp3j3DdbUCX2GfyJLDezIm8PyI+zxzP9SshDen81X8noglYFUyrGI2ACxJvgUYCVC+0Ln4Gz14G/UomaY67GR2aQnXdaMJpUpGg0+ameYwPTNVsVkDpChf40A/vSYt555JWZR80hrN5iOhNDuJdSEtWvOiJUpRlAlYwvWf+R08+KlMOOLfROm865ekJPwIpQ8PNu3l+ooHk4HM9LlQRazBm+xlMXhPkI/wKulaTFgGi4q0xjyrMvdERgis4QkQ8ekByvNsCDDyc+ZEKqn06/CtCu8nFMM66YEadiZxhRueXjIStE2QBrWaJNgvDceAq0VHKBBfGP94/tbw6h8LvGmeqZIM9J+3LgiCn9XWTreSgkF8Wt7QxsDAutXChKEBzFtwQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(53546011)(26005)(186003)(54906003)(6916009)(6512007)(9686003)(6506007)(33716001)(85182001)(508600001)(6486002)(5660300002)(38100700002)(86362001)(7416002)(2906002)(316002)(6666004)(82960400001)(83380400001)(8676002)(4326008)(8936002)(66556008)(66946007)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZU1MRko0UnNiMnZRZGU3TUs2a2p5aHlSTmxtVjAwTGhFVEdmd3NrbVM5K3F1?=
 =?utf-8?B?RWlYeXV6cWxyY04rT1pER0JlOHJDYUhLWnRlWUx3dmxFblc3dmozYjRkOFNl?=
 =?utf-8?B?UHhUV0xSL2MvaGlYZ1lkSmNJZmkvczBCcVcwUDJROVJPQ0RwZnl3b2MxUEkz?=
 =?utf-8?B?a0Rjbi9aNjZkWmxnSW9ub0lWRFUyc2VIbyt1eXdIUXh6Smc5T2I5dWxyYXNT?=
 =?utf-8?B?eDN1SmtYVzNqSENsRkMzR29MejZlNkl6QVpoN3BQRll6SDlybTdoUDBuZnJB?=
 =?utf-8?B?NGdldXdtdi8wbkxOQnZsNEoyQ3FmMWhyTThUSzVTUkRzUThlRXA0V2lyODBw?=
 =?utf-8?B?NGRVYnQ4K2VVYS9OR3JGTzNtT0VSTTZHYW5sMTZnaXEwc21GTkV3ZmpJeGM2?=
 =?utf-8?B?VEQvbm5JaUdCdmVZUVZyaHpxdzZ1U2ZuWlpncEIzMVRJN0VPbGV0SHFZc0k0?=
 =?utf-8?B?UHZveit0M2ZXdUIyR2IzU2RpVTBXV3FjaU4vNWhodmo5cXZkR1pManhjZDZF?=
 =?utf-8?B?Y044WTVDUm1EOXBBR1JkTDRFc1ZkUDJWRGorcXllYTBVYVlmYTdUaWEwWGd0?=
 =?utf-8?B?OVEvOUZlcG9wN2Jqblh2TXlXUDhSNExzZFBqM05HdzVyYnNXYUdtTmVVdUUv?=
 =?utf-8?B?Ynl2bmU0YzB2d0d5QnFHOEJRa0pwSE5GempubEs2U3VhZ3BYR1RZUnJTSzJ2?=
 =?utf-8?B?V0E5bUJNTk9mVmlqRWtGS1FMbmZ2bUtFUCtDUXM0MkxiNlVHTWs5dTBNaVUy?=
 =?utf-8?B?WjZSVlVraHVFUzB2MFVKREtYSnM4M0p1Q1R4SEFka200TlprS3Q2YnF5OEVS?=
 =?utf-8?B?dzZXSVJoSytxNkhYcXhrTXYzdW95Uk4wTzNQSHlLdkJwc2pGMkhKM1UzOVVE?=
 =?utf-8?B?eU9yRk8rbXovbjZUZkFYRGVVbW90K1Z0dUUyV2Fta29LaFpldmxNNmFVSG8v?=
 =?utf-8?B?SWJUWVNYUm5XdmhKUVkzclBNSlNVeHhraDdnUU9BblorT1BGdGRVbVl5YnBK?=
 =?utf-8?B?Tjc2RXN5djlwYVNsWHVFenpRMkVZbXJkMGlFdE9YWnlMRmVRYThKY0g4bWcr?=
 =?utf-8?B?b29WdjZIQ3E3OHhIcXo3UU15VDdJTi9ZTnFpNyt1cnp4ejBKTmh5Rk1QNmF0?=
 =?utf-8?B?VkRKcCsxSW40c3BqYzl2RTFPczlHOVBNbGgydEJuUWxLb3YxaHhoV1M3WlJ6?=
 =?utf-8?B?eitBMS9mdzFjcEo3Z2gwVFRleU9pWFVpcTRkR3pwRWYrUTZDdW9BZ2tnUUZr?=
 =?utf-8?B?eURqNTd2NGpxVmhSNlBkeGw0Sk0zR2tuWGJhMW1RdHNocTBMcEovNjZoUExs?=
 =?utf-8?B?WUgvTENsdnEvbmtuWlBQZlNTNGl2c2ZQM0s2YjJrWXBxQVowOUhvZjI4WDd5?=
 =?utf-8?B?TDRxT0x5LzNKVTZSNFlKUW14d21DZXRrdytKZmpQbGUxWm9XS01OcGFZWGdW?=
 =?utf-8?B?SXRXZjBqbkhOQ2NNNGdwSUd3Mk1kWU5HdkVUdENhY3o0WU9JWi94Ni91WUZs?=
 =?utf-8?B?QjBFTzQyYjhrcWxRLzhmYmZSTDZpcXg4NW5qTG1RSy8rdlVMSUxNVzExN3B6?=
 =?utf-8?B?bXIvREt5SDBuaXVRNDh6L1QzbHZGK0pjdUdQWjZ4VG43SHUxYjhBb2VScksv?=
 =?utf-8?B?WCtKOE9NQXgwUGZXS0RVS3dzZ054T0VTWFRLNmpqbGZSbnQwMGF4VkFtM2dW?=
 =?utf-8?B?TUtZTXhSejRPVzA2Z21VOFJWUGJsSVZsMFFqRXJhdjExOEFLVHg4Mm54YmxP?=
 =?utf-8?B?QVpjb0thcUhMOU1ncUJzVUs4TmlEODFIUUJnZ1pkZ3NKSkN3UmVEN1FpZnRI?=
 =?utf-8?B?Q0ZJNWFFYzN6Y2NiWFkvSDd4S1ZoK1UwUEsyRVFSZTkrTVlUN0pCR3FXREhw?=
 =?utf-8?B?UXRNMlFtekFvdk5zcndOYStGYWwxZjREVFRpY00rU1RFL2NBTkxXaklpdFJn?=
 =?utf-8?B?TVFocXFlNUJ2Y0V0aG85NXVaZTk1WGlDUEhqV3RrSjBMUWRBazNLNGZxTE5V?=
 =?utf-8?B?SzF5SW1BRTA0Qzk1dTY5Snl2MjIzZDdtaTFLcTRhcHlpcUxLWHp2MDVWRVcv?=
 =?utf-8?B?Y0NmNTRNT1JPZnJVRHhkMStETkl2OGQ5UDJkN3RHRFBtbkhoSUlXNXdWOHlL?=
 =?utf-8?B?eGJMczczVXNWL2ZPYjFvazFuMy9CUjQwcVB2Z2psK0ZBbitXR2YzaVRLZ2RB?=
 =?utf-8?B?RkxjOXlKeFVsRmNHM2VnWjBFRjBBWm1kZmdoZ1FwNjdLaytjVE1zcG9PbVYx?=
 =?utf-8?B?YlVYK2dnekx1dlBWSE1QNVhudFVZTVVnYXpXTmg1aUdvdnd0aFdZd042SHFy?=
 =?utf-8?B?RHhmMWxVWjZMMjlyWXVEaGtLOGR4dlBtZDB4cGFHb092dVNVSXBkRWdwL2RW?=
 =?utf-8?Q?EFO/cYdwUed17WH8=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a05ced1-b7c5-4ac7-8bfc-08da27543115
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 07:12:58.1984
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SsaYWfSZbO6Tb8obsdsHnZledTekxdYoZLaPrTLuKhetINGOVPpWF/v5YAz6lyfRB5pTUhB/9e/lMX/F7v+8uQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5447

On Mon, Apr 25, 2022 at 12:39:17PM -0400, Daniel P. Smith wrote:
> On 4/25/22 05:44, Roger Pau Monné wrote:
> > On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
> >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> >> index d5d0792ed4..e71fa3f860 100644
> >> --- a/xen/arch/arm/setup.c
> >> +++ b/xen/arch/arm/setup.c
> >> @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset,
> >>      /* Hide UART from DOM0 if we're using it */
> >>      serial_endboot();
> >>  
> >> +    if ( xsm_set_system_active() != 0)
> >> +        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
> >> +
> >>      system_state = SYS_STATE_active;
> >>  
> >>      for_each_domain( d )
> >> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
> >> index 6f20e17892..a3ce288ef9 100644
> >> --- a/xen/arch/x86/setup.c
> >> +++ b/xen/arch/x86/setup.c
> >> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
> >>      void *va;
> >>      unsigned long start, end;
> >>  
> >> +    if ( xsm_set_system_active() != 0)
> >            ^ extra space.
> > 
> > Since the function returns an error code you might as well add it to
> > the panic message, or else just make the function return bool instead.
> > 
> > Or just make the function void and panic in the handler itself (like
> > in previous versions), as I don't think it's sensible to continue
> > normal execution if xsm_set_system_active fails.
> 
> After reflecting on it, I believe that was not the correct action. The
> policy should handle setting/checking all access control state and fail
> with an error of why and then allow the hypervisor logic decided what to
> do with that failure. For the policies that are present today, yes it is
> an immediate panic. Ultimately this will future proof the interface
> should a future policy type be introduced with a more varied result that
> could allow the hypervisor to continue to boot, for instance to a
> limited and/or debug state.

That's all fine, but if you return an error code, please print it as
part of the panic message.  The more information we can add in case of
panic, the better.

> >> diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
> >> index 8c044ef615..e6ffa948f7 100644
> >> --- a/xen/xsm/dummy.c
> >> +++ b/xen/xsm/dummy.c
> >> @@ -14,6 +14,7 @@
> >>  #include <xsm/dummy.h>
> >>  
> >>  static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
> >> +    .set_system_active             = xsm_set_system_active,
> >>      .security_domaininfo           = xsm_security_domaininfo,
> >>      .domain_create                 = xsm_domain_create,
> >>      .getdomaininfo                 = xsm_getdomaininfo,
> >> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> >> index 0bf63ffa84..8a62de2fd6 100644
> >> --- a/xen/xsm/flask/hooks.c
> >> +++ b/xen/xsm/flask/hooks.c
> >> @@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
> >>      return 0;
> >>  }
> >>  
> >> +static int cf_check flask_set_system_active(void)
> >> +{
> >> +    struct domain *d = current->domain;
> > 
> > Nit: you should also add the assert for d->is_privileged, I don't see
> > a reason for the xsm and flask functions to differ in that regard.
> 
> This goes back to an issued I have raised before, is_privileged really
> encompasses two properties of a domain. Whether the domain is filling
> the special control domain role versus what accesses the domain has
> based on the context under which is_control_domain() is called. For
> instance the function init_domain_msr_policy() uses is_control_domain()
> not to make an access control decision but configure behavior. Under
> flask is_privileged no longer reflects the accesses a domain with it set
> will have, thus whether it is cleared when flask is enabled is
> irrelevant as far as flask is concerned. For the ASSERT, what matters is
> that the label was set to xenboot_t on construction and that it was not
> changed before reaching this point. Or in a short form, when under the
> default policy the expected state is concerned with is_privilege while
> for flask it is only the SID.

I certainly don't care that much, but you do set d->is_privileged =
false in flask_set_system_active, hence it would seem logic to expect
d->is_privileged == true also?

If not for anything else, just to assert that the function is not
called twice.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 07:19:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 07:19:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313481.531021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njFTR-00053u-Uc; Tue, 26 Apr 2022 07:19:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313481.531021; Tue, 26 Apr 2022 07:19:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njFTR-00053n-RS; Tue, 26 Apr 2022 07:19:01 +0000
Received: by outflank-mailman (input) for mailman id 313481;
 Tue, 26 Apr 2022 07:19:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cQU5=VE=citrix.com=prvs=10866150f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njFTQ-00053h-Vq
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 07:19:01 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 23359098-c531-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 09:18:59 +0200 (CEST)
Received: from mail-bn8nam11lp2173.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 03:18:56 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM6PR03MB4601.namprd03.prod.outlook.com (2603:10b6:5:185::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 26 Apr
 2022 07:18:54 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 07:18:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23359098-c531-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650957539;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ZaBPHFEhsIEy5z7h3TQK5CZLvSHf/Jsh4a8FdEdKN9E=;
  b=fRLab8rdwSf2QWH4b14q+1zwFPnLNmpwZ7yBskRX8+y6sOexWntagG5v
   JEU1bqWsTsJZunOSrQbCUqkJaW3cwKq/2L4na6TWO0qd0S7g7u/4wpdof
   gDtVixTq3kHJwPQa7o2ghaqlVDbhi365Jw1gnDiEO1FUFFvneIhvFDPVC
   8=;
X-IronPort-RemoteIP: 104.47.58.173
X-IronPort-MID: 69943304
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:KBqmCaKUZKR/06OgFE+RpZQlxSXFcZb7ZxGr2PjKsXjdYENS02ZSm
 GcbDWzXaKvYNDbzetEjbY/lo0wAvJHTnNRmS1BlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQ22YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PBRrbWOQw13BbSSw8M4QTlHHQBBEKITrdcrIVDn2SCS52vvViK1ht9IXAQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMCFGvqRjTNb9G5YasRmB/HRa
 tBfcTNyRB/BfwdOKhEcD5dWcOKA2CiuL2YD8A79SawfpGjL5w0s4OTXMuXnX9jaVfpOoVScu
 TeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTiduTh1O6WtlfA
 1cJ4Sdopq83nGS0SvHtUhv+p2SL1iPwQPJVGuw+rQuLmqzd5l/AAnBeF2EaLts7qMUxWDomk
 EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw=
IronPort-HdrOrdr: A9a23:/kifKq4PjsxZfLjBwwPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN
 MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt
 gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd
 L6IRlliVI=
X-IronPort-AV: E=Sophos;i="5.90,290,1643691600"; 
   d="scan'208";a="69943304"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ar+Nelhxf1YXlIeqkjTmja1CoxuTHljBPQFGlersq13MsCLEpcnbvj3OId+qhQ1PPmKIZ5neDg8FsmRW0gwo7brFzUkVXzkv/ZSou/pmLkxV9sBgDlXMdEUJ7zShzUttosDjHOzPQ1NJfCFpQ0Uk0rUmRKDH4pmmPqVVjkqxKz7O32NkO6zxAyq3WYCo97MEvIu4fDbqBm3A8dONP0AJGwWpsMbeGTmNvU0WxwfCuAetO11KGaBgMfanCthfTSoqzThcWMz9NCSz+GsTA+7nB2NuMZrOc30/N3EWabbMOt5rC5PWr72nPf+vjzZPw9wlxkydOGdLSpveZrWVay0ZJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2VA7SvFpQMmBLN71emlYqmPV1v/s2k3j7xy4Z5BhQiY=;
 b=JC0GIdcZk/lpgh3XKHECTeptf9hVF5UMaKAr5gl0fYUT8M/CvWnsv+0bWjTvmonCzFLjdJeU/VLANrap8uG2ZNj7U0JEJSW7wgWdTTigkXwStCDHnJRP3nLh64hwTwdaQSE6L0ybxV6e5AXZEPcDu2nQCDWwSDfHNASeJ3Y8xvYYAMVIX6+rrdXRdoe0fnvrZes2XMlEeHlAzkdlh7kQG4gtQso0YFnHzYrYRJ2GnVr6zk7BeB3LQ2IYUHZeCOma8fgzaK3TM1lKIu09aAW439rrMdIXdtYvVcP7U4XmUw7O9sqF6IRSyv7HOC6AConsM878SmjNznWbwM7cneG9hw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2VA7SvFpQMmBLN71emlYqmPV1v/s2k3j7xy4Z5BhQiY=;
 b=jDfjIXQ3DuvlA1TI/lX1ZGsaCLFVdjft6bMo8X1JMumYTMcpMhqjJvvsVcZSB0o3gV2uEFQGfwPgLZdJQ2iWGzDugl84yhTHco0ATucmwH8t4hnfWfpLDDH91MAByuIAyIBlzwgwoWaRAPlWtbU/QoXVGqZgriyLIdAQmrI5JCc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 26 Apr 2022 09:18:48 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <JBeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/nospec: Fix evaluate_nospec() code generation under
 Clang
Message-ID: <Ymec2P8YnyYA2XUO@Air-de-Roger>
References: <20220425175603.21086-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220425175603.21086-1-andrew.cooper3@citrix.com>
X-ClientProxiedBy: MRXP264CA0017.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:15::29) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 189398b8-848f-4b8d-d6b5-08da27550522
X-MS-TrafficTypeDiagnostic: DM6PR03MB4601:EE_
X-Microsoft-Antispam-PRVS:
	<DM6PR03MB460170F266DD2A5415D6B5208FFB9@DM6PR03MB4601.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0As7rgvYtkCmf1oyFNjJSL+hKa1jwt0ghgeDH13ysVHxruM+f7f+Q1izVzYEVjicN3Yutvicrzay3u092g3m6mB31rIhLiGcAHoKgiCSKgUI90d8ksOnAqs/enta4BQ/x5S7zao50GrWvZCtYoGWnmzkVIUnHfSlfOKk0eMcdZSFHcTmS8asrkk14GkPpl04FdGWDoIAoprfHWdgKKIqNrMoAiIEEeNBotZ6Fg33U+8XDBXnlM1/yN8oqcUtZj1hBFunRt/YiF1PeJQKFbd+NkFlk+fKUqgyYeoEmuIuSCVhOLXpoYHexaxmnZol9f8uz572UhNK8qVk6zkwuS19WUisvJV+tZF5U06GtA8/noZk3VqJ5kCkoI9XS5tnmMU33qrs3OcKR1gf66wDeGpvj2HgK6RlunFjUUR7RSHRatDFmfo90RHsiY7Pc7NiDTqtHl2T82H/nzoZsatdahUVacsn+tmuO91ZryqNRwe80Lt3bUvwTTxYRtVuSNymo5lPU9PQ1x8Pfa8nEYEsScIKk201OsPu1qx7Z7xDUs7d9fAqJGf96CQVgqrjUXyU4Kjzji3jeuKvWTRK07GNIIaBbF6oIFLCFZy15z6KYvnWEAAkbm9aOsmx8dNDJth/c9EGeV91MjT8J0DA7SS7cKpGKw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(316002)(4326008)(6666004)(6862004)(6486002)(508600001)(8676002)(66556008)(66476007)(86362001)(82960400001)(54906003)(6636002)(66946007)(38100700002)(6506007)(5660300002)(2906002)(85182001)(83380400001)(9686003)(6512007)(26005)(186003)(8936002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dXFIbzJkVEVFdm1PWXZmV21hdlhnNU11Zng2U1R3b0kzSkJ5azNUWHRWclRJ?=
 =?utf-8?B?YjdiVkVhdVJ2am1BQ28ybGVYNk42bWtFSzNlMnFaNFVFdm16V3VCQ2ZNZzdJ?=
 =?utf-8?B?YWZIZloyN3JHTkJRUFpNcmtwWVdjaW91U2dMQytJSVhhY3NuY3NyYmFiMVBH?=
 =?utf-8?B?TlBZTFJuZXB0RnlDeWhlZzBiMVhtTHNseUhwL0VLNUxHQUZFbzBvd09ob1lO?=
 =?utf-8?B?cmovM2dOL01aRVBIYm9yc1ZYQklnVm1LWGx0MHBjWWJMM0Q0TC9aM1pUNkt2?=
 =?utf-8?B?U1UwRWhhbjQrZDI5ZTdnSlVlek9SNVNESmJURUF3L2MxdW5WY2pVR3dDNWla?=
 =?utf-8?B?b0ZGZXQxMXRUWkJ1aURIeWNNQUtBbEhqL3hwQk1paUgrYm9YQWtHR1NKNUJs?=
 =?utf-8?B?RlJ1OHVEL014bVNOWXNIT1dhdUsrS3Voc0ZKODhRRzVKQXRXOWVtbitYQUIx?=
 =?utf-8?B?WENtdmpOQ1JWOURveTBQTUZQUmk0bG9kL3VWZXQ2bFhLWXpUdUpDQTZZNEV1?=
 =?utf-8?B?Vk82dGYrRDZPMFV6ZmprdVE3blJ1QWhQZ2lTc0hzR1FtMG5seXFwK1I1bk40?=
 =?utf-8?B?eGlia0d2NWtLSEtsK3RuWDBxckY0TVBwWnZjenpvZFQ1WkpOMjh3UjNNbFlT?=
 =?utf-8?B?RjV4RzNZS1pmb3VLTWNqYkJZcmdjU0d0THdFMnh4M0FXN3RmamNqN2hnU0ha?=
 =?utf-8?B?bUhBaHVwcDNicEtZd3FYUEpFVytsYldlcGErVzFIczFiMzV1dVRFQ3FGNE9m?=
 =?utf-8?B?VXhIc1VkUGhXSHlrZDdhTkxuUUJrVWhkVnVRTkZqSi9FUFlyaGJuaGx3eFo3?=
 =?utf-8?B?YnIxeFVzeFBmMDkxN3BnclpabkVHNmI5SG5nVVViMmFuLzlickh4RjVOQjE3?=
 =?utf-8?B?ejc1WWtnQlZDbjhqbVV4QkswUjYyS2FqYlV2NThoK3A2UUIxUWh0R2k3cm8w?=
 =?utf-8?B?RExubC9oYkw1enBjL2RORnZTd3BaUXk2WWN1eDY5djdNSEtVcjEvQnF3Zlov?=
 =?utf-8?B?cUpjeElPYm1OZ3Z0QmZySWYvdWtkLzhuOUJQSnNabWxzSTR3ZVB2dnpDckRN?=
 =?utf-8?B?TDV6cXhJM2hhZjd4NW5HRUdZMW4wcmYvTUU5dTFJRUZ3b3Z2SXkySnUxWFlB?=
 =?utf-8?B?UnludGxYTGFVR204ejJLckVUZTZpTjFqc250YkxmaDhIRTZ1anFGSS9senF6?=
 =?utf-8?B?aWpzK285Z1FqeHlkbnVoemNHUEoxdFI0alhzR20zSEtLUHR4V2ZiWU82MjlW?=
 =?utf-8?B?WFZyYmhrRVhBbm1WK1hVdURaWWM0WVNBVTZ5ek1iNkN6OHpOcDM3Rm90T1A3?=
 =?utf-8?B?VUE3R0F4NVhsYVRGM2V6c1dYRGdkVzVFZWZGbEZsRkZ2SG9WdkZicVJDWEw4?=
 =?utf-8?B?UEwxSUlKM0VsYTRqVzNBdXc3U25waGdnc3RqQW5TYlJvWkFUV2tPVUNHbTI4?=
 =?utf-8?B?VEl3Y2hFTThqeFFOdzRjcCt4QlBsNHRYYTRtR3A0azF1MlRSS0RSeG5xb2t1?=
 =?utf-8?B?NDZ6RjM0c1ZBUFhrWGpTSEJWWE1Ya3V5N1BUSzc0TFZKcVU3OVB3K3hCeGdK?=
 =?utf-8?B?Z1pOMmdWRStDOEltOXJHNlA3YVNibmJyS25CSjZROHFEM2hDVyt4ZVlkWkNa?=
 =?utf-8?B?WGFEZS9MNlBSL2NXeE5rMjZBeTVWSGRrcFJPY1FPaE93RTFDUHlVdHhkK1dF?=
 =?utf-8?B?MWFKUnVNMFhNeFdSUTlydGFwZjNpbm14K2ttelQxcGhBTFh3clBwS01XRXhT?=
 =?utf-8?B?eitQL2g4ckhHWWhqai9hVFI5Uk5JSmJDbFJ1ZGNqQXF3NDBiZzk1RGhmVzRS?=
 =?utf-8?B?dDdLOWtER2tPWkZFZ3U2M1M4dWkrM2JtZTVrck5YR1VhMjFQV1hiK2pwMkxq?=
 =?utf-8?B?UGJnU1NkVGR2VmtPSWRxbFZJc3c2eHNTOGltN29jdWVnSEErZm1keThuN3dq?=
 =?utf-8?B?cW01TUhSRzdLbTEzU3lyaHEyVmJjUDM5RllrTzZGWmlRa1luN09SY0g5VDdB?=
 =?utf-8?B?cHpnVmwydlJsZlM1MWxxaloyd2JlMWdGcUF6QktTWHVvNk5SNk5FK3g2STY4?=
 =?utf-8?B?WDRFcUwrakNQT0xSc1dYclZHTWRXWVkzRWhNOTJTcWpXS2dsRFdXSFRwSzZH?=
 =?utf-8?B?dnRzN3g0a21LNXBZOHZIMit0WmloUHpRTTRibXRqMDVpV0k1OHU0S083aThN?=
 =?utf-8?B?bENHemJFTzdnRjJtbUZwSzFXWC9KZzloTEw0TjExQjJBYVFEOXlxeUNNemxJ?=
 =?utf-8?B?RG9MeXBieVMzeXMrblY1NUprMC9UV2xLWjNnTG9IYllQaGxRQWZOdisxamJi?=
 =?utf-8?B?b0RRcTdjQ0JyNk13cVQ3ZkZUM2pzY3c4UW4wa3g4L1FQK0hpNGhUZEpLVysx?=
 =?utf-8?Q?0tsUeLVoevwO3RpE=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 189398b8-848f-4b8d-d6b5-08da27550522
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 07:18:54.0562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jdApY045z5LGE/3dI81fitPAJbzJ/qH7uQLPd5gSXvjFB0fFAun3XreR7EwPKYCEKhdhGw49G2/lDZTgAQX0Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4601

On Mon, Apr 25, 2022 at 06:56:03PM +0100, Andrew Cooper wrote:
> It turns out that evaluate_nospec() code generation is not safe under Clang.
> Given:
> 
>   void eval_nospec_test(int x)
>   {
>       if ( evaluate_nospec(x) )
>           asm volatile ("nop #true" ::: "memory");
>       else
>           asm volatile ("nop #false" ::: "memory");
>   }
> 
> Clang emits:
> 
>   <eval_nospec_test>:
>          0f ae e8                lfence
>          85 ff                   test   %edi,%edi
>          74 02                   je     <eval_nospec_test+0x9>
>          90                      nop
>          c3                      ret
>          90                      nop
>          c3                      ret
> 
> which is not safe because the lfence has been hoisted above the conditional
> jump.  Clang concludes that both barrier_nospec_true()'s have identical side
> effects and can safely be merged.
> 
> Clang can be persuaded that the side effects are different if there are
> different comments in the asm blocks.  This is fragile, but no more fragile
> that other aspects of this construct.
> 
> Introduce barrier_nospec_false() with a separate internal comment to prevent
> Clang merging it with barrier_nospec_true() despite the otherwise-identical
> content.  The generated code now becomes:
> 
>   <eval_nospec_test>:
>          85 ff                   test   %edi,%edi
>          74 05                   je     <eval_nospec_test+0x9>
>          0f ae e8                lfence
>          90                      nop
>          c3                      ret
>          0f ae e8                lfence
>          90                      nop
>          c3                      ret
> 
> which has the correct number of lfence's, and in the correct place.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Like Jan I wonder what the clang devs think of this solution.  Is
there any test in clang to assert that comments won't be stripped from
asm blocks before optimization?

> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> ---
>  xen/arch/x86/include/asm/nospec.h | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/include/asm/nospec.h b/xen/arch/x86/include/asm/nospec.h
> index 5312ae4c6f31..7150e76b87fb 100644
> --- a/xen/arch/x86/include/asm/nospec.h
> +++ b/xen/arch/x86/include/asm/nospec.h
> @@ -10,15 +10,26 @@
>  static always_inline bool barrier_nospec_true(void)
>  {
>  #ifdef CONFIG_SPECULATIVE_HARDEN_BRANCH
> -    alternative("lfence", "", X86_FEATURE_SC_NO_BRANCH_HARDEN);
> +    alternative("lfence #nospec-true", "", X86_FEATURE_SC_NO_BRANCH_HARDEN);
>  #endif
>      return true;
>  }
>  
> +static always_inline bool barrier_nospec_false(void)
> +{
> +#ifdef CONFIG_SPECULATIVE_HARDEN_BRANCH
> +    alternative("lfence #nospec-false", "", X86_FEATURE_SC_NO_BRANCH_HARDEN);
> +#endif
> +    return false;
> +}
> +
>  /* Allow to protect evaluation of conditionals with respect to speculation */
>  static always_inline bool evaluate_nospec(bool condition)
>  {
> -    return condition ? barrier_nospec_true() : !barrier_nospec_true();
> +    if ( condition )
> +        return barrier_nospec_true();
> +    else
> +        return barrier_nospec_false();
>  }

Is the switch from using a ternary operator also a requirement for
clang not optimizing this? (I would assume not, but better ask)

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 07:20:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 07:20:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313486.531032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njFV8-0006Nl-Az; Tue, 26 Apr 2022 07:20:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313486.531032; Tue, 26 Apr 2022 07:20:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njFV8-0006Ne-7C; Tue, 26 Apr 2022 07:20:46 +0000
Received: by outflank-mailman (input) for mailman id 313486;
 Tue, 26 Apr 2022 07:20:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njFV6-0006NW-Jb
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 07:20:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 61f85ff9-c531-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 09:20:43 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-SqvMo6YqPSGI-k4OX7jqcg-1; Tue, 26 Apr 2022 09:20:40 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB6035.eurprd04.prod.outlook.com (2603:10a6:208:138::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 07:20:37 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 07:20:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61f85ff9-c531-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650957642;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hu3XjBfndRFS7kaQGKdcObWEE04oHKkTNxI49/Uo9Gg=;
	b=azpNmtJxW//dQypX+/X/6m/U0WNAyU6Z3mSrQRwotCWxVlZeA5Aa4cAAGi6TDAjgkrkdX8
	Um12RYxxfSfhJlWILSgQv5/OEbFpbfL7c3vCr9IO05yt9oaf+YuZddsX4JhtX6Qlvoe5pH
	pz8rP6lY6nTwZ+wCkEvRF67WaItcqYk=
X-MC-Unique: SqvMo6YqPSGI-k4OX7jqcg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d7JL5PFtHyngTFD1dF1zSHA/TqyAvKgIwg9NLZEoFyWB576Ns5zzUtTnyft+MvJzTX9nYSk9bVhibd8toPtQNRcuwdlTBPFzPHw9byavSaUqY9UOx09KevKHn38N2VJH+oZGKaLLT/f3RSFMjyPQxhqd0mzodS4bbsMeKZA+IEu8UhYiNMx3SprQqhSX8qWjiJV//rTmGEG9gluwUJV+EHZU3hYPcr4zOBG1d1RJRhPUu8YYjcOPTv1Api71IWkZkq1tFuQH5fbn+RM5Itj6VDgGJ2RlwNAtrOzR2a/q/x6Dtfqj3kHEENrrhDwWqJ2e9CUdLjhORqIg+uVmaRcHww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AfWdct7/ks7y+3bhXjDQexMqtYWIYdzZ67UZ2gVJpfw=;
 b=WLWNIWNc2pomhcATlniS4L/Bnhd81CFY8b6BUEk1PAac+8xZfkRTjsgR1D5xBluNuv9epd7H8OUhEJPIdq33qt0ZYTtoABPZ1z0TsPeW53+wx0ddhcF+xJCGIWOEiUPckLNrfNqBTLl2cI2I8kWiJk6pJuAUSPYkXZoxU5II43Yx0sLOhRO+G/7X2+UsVPZbtEPsS9wPMfH5chT9CsgOLMCQ6RTI3bexMJtg6DRoDiKxUF1bAhV6Mo30gfmo/WrHchqgW7dHNE8DPSG0yFow8VKnpfZ1u0hqftId3WaQQ1VklHdE+nRy0D4q8A0+GWaMSU1D/FO/IbfBlzho33Bjlg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d76db1d0-6026-b043-44cf-dc36fed04864@suse.com>
Date: Tue, 26 Apr 2022 09:20:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xsm/flask: Fix build with Clang 13
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 Daniel Smith <dpsmith@apertussolutions.com>,
 George Dunlap <George.Dunlap@eu.citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220425180756.29738-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220425180756.29738-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0076.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ab92ff82-1049-4c98-96f1-08da2755427b
X-MS-TrafficTypeDiagnostic: AM0PR04MB6035:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB603579DD3F1E56AD0EB79071B3FB9@AM0PR04MB6035.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nkbSD9VwhJJdumI7u+LXf0DycO06s3ngtqYiR2oRlWFKUf8RgaSwCRmBhYrQpdb2W4zeGRbHMJ5cS+t1T+5A0fuCdxVwFJiZxORsqoJApiigTcUrzu7nym3CKCIJ4YykEssdFWSVijq9GONHxf2kuSorCvHMc0BiKgyHrFUFWZISs+7dTjNnH+/M8DK9w6Nvnm/zAAnylzE5rar1CR5MoiKYTXJmbkkhUnzaD12Sa7BMtXyIIW5rmuc9KxPwO9JZzal5l8Lb5nGw136yJX+1EQVsBZmfl5H3xGO4LBNZ6LccxPOG3ShEecKaOJJKLnotSpYrtljgakrN5Z/xkJ4tQk3KDrbTO2G+uE2LcRY0N371PU2giRjkzdQ+3KzOwYZp/NbRy4xYNYMvk8z3IC+GbAUzS0Wv7YE1WRDodh+j42JthciaAuC2k84Obb6COeGktb2SGzGKq1IE3nGWBCjZplqk24wEjrc4xxzvdf6pDSTsOe/2QFAkB85tuJtPbdbMR0A9f0FN2FYtn+8SYcY8bZOzEbegqzcT5Sblm8DKNTT4WJ83tLfS0kGCnkVI9yrMr6cnoJgYAERFUf3YNkxDEDTrE9oGeKF+A+/+YLSUhHd5SHjYqVLAGpfVU9hfsazzD4EBKeDeWnD/pNbD6s9hOQQfwLbg9vkqoeXD94CNusFI7kDWH4yust3nvH+ZFhClrHTLRtlO+0mVI5w9HznWj8j7XZ2yM3SsPVo9WmEQYyo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(6512007)(5660300002)(8936002)(26005)(66556008)(316002)(2616005)(2906002)(86362001)(38100700002)(31696002)(508600001)(6486002)(66476007)(4326008)(54906003)(6916009)(8676002)(186003)(83380400001)(53546011)(6506007)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?dgW/9EJ15HCLxrm/5HVyL4kJI2T++L1/0kcSGnLFKVVk7KpC0hk7WGERvCCY?=
 =?us-ascii?Q?kCjTRXEpLpYrvKM1s2p0naE/GyCRb83fqpbd9Vhz0JB6dSRNH+kecA0s7CfQ?=
 =?us-ascii?Q?SW6JtRH7tuew2D1xmGijcBx2h15/0aI/wxjVeSucI3BGaGzPLpT6wDtenlVj?=
 =?us-ascii?Q?tdSL6RCCtZwC26yBgQIo2Gy0DwNTeZtpEOYopMnarBJ1/QQ4Krh03lW/0LPc?=
 =?us-ascii?Q?Mbnkqy0JUJokIQFqnQObhmzMhh6cgOWeLEj3Pw4UF6+H8ftUSbSJyesuyZmu?=
 =?us-ascii?Q?TTXSb53QoRUqXlJqUKMZbCYD4CMNmJT+b69p38dxFFQjKC5vOYCr9DJgtQmY?=
 =?us-ascii?Q?5puv4nUphnTrEoxSfpBPZv0ZP1pMwGYZK6u23hIJ02zGqBAzYYeCE5rz2Lnq?=
 =?us-ascii?Q?LadMGNdaE7MDYM3J5VxZ1/qqld6BafraDyivAy/fE+48PRMZp3BiDSsv3ALF?=
 =?us-ascii?Q?7GYqlDaOGXES9SGCQNUNRIGjgKQFvOCeoau9Qr6Quh1W/1rS0bY8xQAzTPLS?=
 =?us-ascii?Q?jviXLt6zeivmgpLxiAT0z77RQ7SuH9dGvbuDDtzPkwdzZSUt6OqlKs3Dbwip?=
 =?us-ascii?Q?PI5ldErdrAW/RhOSw15QacMJ2hsdWlZh7orMbbENfhIcnv5A1jwJ8Lf9d2SN?=
 =?us-ascii?Q?Y3p1S1R5nHIP7j6RgSCqB0NKvgy8CVoTXavh9/ruxXvo0smwob0PqzlKTGKU?=
 =?us-ascii?Q?6MMOrsvA6KjrnsHwZaBzrYTJiCZG5pI/5bMaf0esL41g5n/WgtaeuouZsq0H?=
 =?us-ascii?Q?HBF6d9anXhfEtEuOAauK2s2TmLAHqNbJ4iQpigI4wbYrO/Bn92B7qdxEaUWc?=
 =?us-ascii?Q?rEixN31h2mJvvUF+6Rqrz1tEM16Wc3xr4gbb9cZcCjzIUJKWjL3em99nP/7u?=
 =?us-ascii?Q?XgO608/3y8Go3U6iYQzAfO2Gch/m1eRdU4S+xuSDtsmv3uZYq8Rkv0Jyojxb?=
 =?us-ascii?Q?tgvDo2hnEE5pM6c0x++U1l9w/eTTUHeAOPYfVE3fVSQ/9d5z4Rdg1NEo+jSx?=
 =?us-ascii?Q?b4Fv+vuW6qBhdGMjALOKhVmuyX+r4rYWKomwdt7gKoxZA1LfVNaSadD9gfJ2?=
 =?us-ascii?Q?OaOu4ZM3Xhl6f8U51mccrKBuoc34ajkrCxMb/vpV/9Yt67pW7sF4Z7lDW7gZ?=
 =?us-ascii?Q?ghTRcQ/hAVfNq/h7BRUb9JB4GrDR92j8sQBkY5kD8ObRKzvTjCFzG5qCjSKz?=
 =?us-ascii?Q?UgO9vxrrG3RS+AzqOChQ+GQ4zxteZW9wYcef6rTsncuoc/EQAhQewxoftDA8?=
 =?us-ascii?Q?0NkpWpc/8Q5eV3o6Uecj3/oJxcT1kCF+rtwQCUIHRdvhYi81LA7xyqNDpG0F?=
 =?us-ascii?Q?TbMVTqJQla7+rAjkhxeR5/OhDh01Mg/1aQHarhEwuDe4pdrcYF9DnrqWhyJU?=
 =?us-ascii?Q?npCBKE/f/1d8urBXTd8JEOGEpWbXLTSdNK+GrtNMWA/oNTaVxqb+CJRHLIHX?=
 =?us-ascii?Q?TbM7xJDr0bYSdyDwoOlxrDLs6SrcQRFWQ6SAtu+/iq7Bv5gCK2RjZCCoD6Q4?=
 =?us-ascii?Q?xsRKxFdt1uO9B0uXGmI4lWWjlxaWORbqjAjR1iIVeZfa0kQD+9vmMFEVVVNm?=
 =?us-ascii?Q?Z3vsXpN/jLeTg8+7Ps4II0BFxtgU2XNjcwLFk2DhQ/gT6LqMMYcEp9WZMr0f?=
 =?us-ascii?Q?A6WtNYZkrJyS8sPskT7ApjoDDmaKBfrls/015tQipFyGsmhuNiHHpSjIUFip?=
 =?us-ascii?Q?h/RyWDtrep6dwgW87ORvRPE6rRdmOQRadmghk7BJWl2F12MYEyv+hPEsiF8x?=
 =?us-ascii?Q?xRoX2AWlQw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab92ff82-1049-4c98-96f1-08da2755427b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 07:20:36.8383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7rqXbnimmGZUUwiYEobW7X8qR+4JDhcEGPIUHPpX5MiMbm+U6rSKotmq5OTcSSau9ZwHBz1ZCNVvYJCT2GqLIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6035

On 25.04.2022 20:07, Andrew Cooper wrote:
> Clang 13 chokes with:
>=20
>   In file included from xsm/flask/flask_op.c:780:
>   xsm/flask/flask_op.c:698:33: error: passing 4-byte aligned argument to
>   8-byte aligned parameter 1 of 'flask_ocontext_add' may result in an
>   unaligned pointer access [-Werror,-Walign-mismatch]
>           rv =3D flask_ocontext_add(&op.u.ocontext);
>                                   ^
>=20
> and the same for flask_ocontext_del().  It isn't a problem in practice,
> because the union always starts 8 bytes into {xen,compat}_flask_op_t, but=
 the
> diagnostic is based on type alignment alone.
>=20
> struct xen_flask_ocontext has the same layout between native and compat, =
but
> does change alignment because of uint64_t, and there is only a native
> implementation of flask_ocontext_add().
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> CC: Daniel Smith <dpsmith@apertussolutions.com>
> CC: George Dunlap <George.Dunlap@eu.citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Wei Liu <wl@xen.org>
> CC: Julien Grall <julien@xen.org>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>=20
> Slightly RFC because there don't appear to be any good options here.

We cannot address this by altering the public header. Besides us having
previously agreed to avoid the use of extensions outside of tools-only
parts of these headers (or else you could simply use uint64_aligned_t),
you're also altering the ABI for compat guests by changing the alignment.

On irc yesterday we had

18:12:06 - jbeulich: With alignof() =3D=3D 4 the compiler could put the var=
iable on the stack, but not 8-byte aligned (if something else occupies anot=
her 32-bit slot).
18:13:34 - andyhhp: well - it can't in this case
18:13:37 - andyhhp: I agree it can in principle

which I don't understand, but which I'd like to understand in this
context: Why would the compiler not be allowed to place
compat_flask_op()'s op variable 4-but-not-8-byte aligned on the stack?
Then, if forcing 8-byte alignment of op, the compiler still issuing a
diagnostic would be a (minor) bug imo, as taking into account variable
alignment and offset into the structure would be enough to know that
_this instance_ of the struct cannot be misaligned. (Of course this
wouldn't help us, as we'd still need to work around the deficiency.)

One possible way to deal with the problem that I can see (without
having actually tried it) is to make the two functions take a parameter
of compat_flask_ocontext_t *. That's type-compatible with struct
xen_flask_ocontext *, but has reduced alignment. Of course this will
require ugly #ifdef-ary because the type won't be available without
CONFIG_COMPAT. Otoh any approach avoiding #ifdef-ary (like introducing
yet another typedef matching that of compat_flask_ocontext_t, just
without reference to struct compat_flask_ocontext) would needlessly
impact !COMPAT builds.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:05:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:05:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313500.531043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGBn-0002lK-5X; Tue, 26 Apr 2022 08:04:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313500.531043; Tue, 26 Apr 2022 08:04:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGBn-0002lD-21; Tue, 26 Apr 2022 08:04:51 +0000
Received: by outflank-mailman (input) for mailman id 313500;
 Tue, 26 Apr 2022 08:04:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njGBm-0002l7-6G
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:04:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8a6d93fe-c537-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 10:04:48 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-07ImwbkFNV--x8Nj3TsdTg-1; Tue, 26 Apr 2022 10:04:46 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBAPR04MB7208.eurprd04.prod.outlook.com (2603:10a6:10:1a8::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 08:04:41 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 08:04:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a6d93fe-c537-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650960287;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wSEbWyfkd3Vts7MZQe+N0h3vIdDUe9n+9BmIm5uJE5A=;
	b=H+sIxJx3TMabEg47YXHv5RUk+WPvMae0jcov7UZIzwLA+1q1b/jCMHV5frpfkRT1u+8T/x
	XtuShUhAwCKy9BGNTaVCmVNsR5rvZ5KMVvje/m5mGy6endcM9BUqYwxpF/eR8E8QKljisX
	2YidOgqh+2iZspd93H4XdX/6vhG/UeM=
X-MC-Unique: 07ImwbkFNV--x8Nj3TsdTg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DQ2b5MPBUAqjRiVQKCRaVGxntuaHV0MHmhqzN12QPUGhzl7Sxi4Bk8wA/18L2Iuz/lITPs4gdJdyHCwYOqnisgdMuYIRmtkeziG8eb3wipO4C7ghAVFGolc9mpGnlHRhaT5xLkJzNjT3feHPYRrXyoqgdG3obrHaouNLtPUnvN45BI7pYe+X0AGuzs9oLzLOIK+FnnwmRUNH03FRKwmz9TPi6p3JXRmPIU0kQyXYHN5DyQqFPSXeHxNtI5kK2+0y4kNogRj4od9LsSTj0eR7M97Tx3ozI5Ffdx1tU0+rSj0w9857WDVMWmsot0Oj2zUzkZke+DiwjUP2p3N42xV13w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wSEbWyfkd3Vts7MZQe+N0h3vIdDUe9n+9BmIm5uJE5A=;
 b=mrhADl5mjmIcaRPF7G1Xoce1Kaez0LyA2s7A7Cdkli77COiyL/1gNLnkbUsU9DswPyHvGSV6vKqa7gwt6TIQ8X8xBvbFZuUfpkOJercvH8SpZGkVKbrjxktkbG80l1EnxxzXr2UYLVrPKP3erMAU6yGmKpzeJqiFdlT7h1XY2rHFq5ECoz/XDfYZl/Cyav1SiYmlAN/dNbcN/pOtgN06PJ5OVZjfa2tMi69Ok+Xw/fdUUc/b9ZcFIEt4DrrdYK58bfGuoxCCWdw2BZePvLUFHAjrpxVeXKKu0JpufdilBdt9+ofGH1vsE+wlLm7yqlGDfx3v6K50GWs1xVjQuHPbvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3c84e70c-9cc3-5818-d453-b53354650771@suse.com>
Date: Tue, 26 Apr 2022 10:04:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/build: Fix build failure from LDFLAGS mismatch
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 George Dunlap <George.Dunlap@eu.citrix.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220425230656.12808-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220425230656.12808-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0025.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::8) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 23d81701-ed3f-4abc-a2a8-08da275b6aff
X-MS-TrafficTypeDiagnostic: DBAPR04MB7208:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB72089F035B76482276E3B5DFB3FB9@DBAPR04MB7208.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kZ22ydMvLTdsIxrjYSV8lcni0U5biySyPwR0amLdXMWHJHzfQXkf26r3TbNXjzbTBdzuug4xl6Rg+3HYOFdCEt5Emj8WOlBKSow53m4TTDbsvJpWZB3WTqtcbmlzkI7SFdkw9ZKUlsMHS5F6qcG9VTFV14W8dpHraCKZuRZwFn+ESDJQfbKGHGeiTuG4BkVbWPBHFhfOIonGN4HQpl/vi5AfnsbBLVJuxOxJgEXmW9nDnRnPKgc7nEA2KPbfp0Z8JM64686OPcDgkcUuLRvs+7JXVnMmHJkwf4imyki/reUxX03YOl+rs55lr6vaqaNqjnf7N15lGLvTw0HjJGwP6XhbSTRvwe1Vv07MGyUn2dEGplKch++0oKKWqdYqhGB82DlzhiK5Hih4CNi4aqPPQVoyvnjR0eX2xLetqb8LuhEzVM8/yJq41PZzfzO0yddnf5gvy2RHzZdh98i81yIaYtTiz435N1pYf5PwnQAw5VFkY8No03SSV6ldoL3ih8qnBbPLis+Jcc3iJirQU9mk3Jz2pDghJk/lEC0ukBGsGhtKw7zG9ccpBwGkwAxB5YOdw3NmlPtqaZCnsgVSTwyWuwUe3JyU9z1TNZ2t+27UiVporYSDfasTdGM2Uv+pmADgSVuvlyVG8xqTo5gk5ldegDI6ZcBlwMZWv1I5UKdJkcLYB0/lKMMuSQrJxT5/071bmaSC5xaWHs6qJe/OR4+raIqv+gDT4JK1QSX7MnudSH0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(316002)(2906002)(2616005)(5660300002)(38100700002)(7416002)(8936002)(66556008)(8676002)(4326008)(66946007)(66476007)(83380400001)(6512007)(6506007)(53546011)(26005)(186003)(54906003)(6916009)(508600001)(6486002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZWlHT2p0UU05cGplWmNpZ3h0cE1jVzd3aUZudnFla2cxNzNQSjFiUmQ5ZVZW?=
 =?utf-8?B?a1NSZ2xHRlB1VVRIRHBiSzlEbWVzcWR1UmhTQnZrOFd6SHE1MGhMeHpreWNv?=
 =?utf-8?B?Yk9WbXQreUZZOHJXTTdKbyt5OXRSeDhJWlJnYnJ2bGgxanpiOHovd0E4dnU1?=
 =?utf-8?B?cmgvMXUvMmhtVXFQNi96Q2svdUJtQVQ1VHowTkk1TjZLNlVodVRLZlU2Y3Nt?=
 =?utf-8?B?cFV0QkgxaFFPUGdpSmhmMXBPK1hyaUFmcE8yRitsalJ4YytOcTcrenlSaXc0?=
 =?utf-8?B?enlkMHpRTWR4SEU4K1NIRnUrYWRRQkMza21UOUx5WEpwU3lzcFdHMnkvMTdX?=
 =?utf-8?B?RzU1RW4wVDdoRmFpUHNRQ1BlcUJ1RkloZUpCWXhaSHpWaCt3bE5abmZDNXJs?=
 =?utf-8?B?a1k2SmFiSEYzYmVNN1pNVWpMUVMwMVcwU2ZCMXRRNkN5ZE5idEQyNUVQdlY0?=
 =?utf-8?B?WXFoOXpMZXVTeUhEVjAxYmpQNEpmTFpFTW05NkczVmo5dWhvbS8vTWxuVE9r?=
 =?utf-8?B?ek9FamQrZGllMjZBc2x5Y05TeFFsOTR1YmFibWJGSjYyMHhpZXF2c2pRakxn?=
 =?utf-8?B?cDhSV3RMa0NDMzVTN3VYQTNxa25PeEtSS0diLzlNZTJUdEMrajc4S3R6NTZB?=
 =?utf-8?B?bFRWK2ZLMXpCT3dQMysxeGhqKzU3diszVDZtLzQ2UWhGQ0hPR2IwSXpHV3Jw?=
 =?utf-8?B?UFZpc0g3cEhqY0E2c3FZbkZrdWkyVUJhSjQ2SENXOUxncFRsaENnS1VkUVJE?=
 =?utf-8?B?a0lydlJzT1dGQWZFeVVEQm9VcDZMYW1OWGlsWExpUXdGNzIrQnY4dHdvRVNw?=
 =?utf-8?B?RWFISmpYc2hHbWNBOUxPTEFXV0VSV3NuY2ZLZzAvemlCWFI3WitraXJDbkpo?=
 =?utf-8?B?UldVM1pJZnpFODRCdjNiS0VyNEJjb0VUWDJacU15ZVA0c3FqcFBEam5mUjR1?=
 =?utf-8?B?SGdnNEhOdmMrZFE5Y25hT05uYytPQ3p2V3lzQkN5cDJ1OXE4a1pyK2ZYVSs3?=
 =?utf-8?B?bzRZQWV3RHVNS05mdFRxTmd1Q3dTOHhILzZ1QzBPdzFHNFZNTzVtcjBVS3F1?=
 =?utf-8?B?cHVodGhrL3hJVitRM1dNSUVVWE4wZ3pBNzBBdmRqVEt1MVFUQm9PT1prL0p0?=
 =?utf-8?B?eGd2VTRtdHVkU1FsU3ZMMFQ4WHVZaDJtaTlxelFZQVRvMFdpSkV2eVBjYUJW?=
 =?utf-8?B?b3dnM2ZJc1BnWFh1ektQbVBkVGlyMFpUR3RXSmRRTTBqM2RrMExYN3pxMU9k?=
 =?utf-8?B?Zit4WG90Qm5JK1dsN2Y1bXNHSDhqYUlpQ3kwTVFFVGtqVkt3NExsYUJHU3c1?=
 =?utf-8?B?Y2srd09wRlVrVTBYM2JqRnFidXovaFIrcjVRd2JvSk8yUlR4anJRU2djWnJ5?=
 =?utf-8?B?dHBpUDN3Y2xmUU9IM1ZIZFVyc2VHQkRMOXRNNmtqMDFtYXhZQ2VuZmFkcTg4?=
 =?utf-8?B?SEE4eFM5SVJ3OFVWR1V2Q3RwTkg5WGpqcWhaT0V1MGdTQ1ZWWTN4SExaZXZN?=
 =?utf-8?B?OGxYRldYMURhcE96Z3d5and0ME15aHZneDZlWS9JOGN0MCtnQkxGUU1OcEdF?=
 =?utf-8?B?d3Q2SHhZQkdPc0pGQjkyd2NhQmRoQmNuRDRSdmczaDF6dS9qcncrQ0tncG8v?=
 =?utf-8?B?bkZKRG1Sdk5jRkgwV0dsaWpUR2JzR09zRWFzZVdnb2ZDSzBtYzR3MGhZa1E0?=
 =?utf-8?B?Y3BKeXRDTVN3WjJUTXZvQXExZWtKNGRCRHNXL21vS3hRb1ZZby9EcityczJk?=
 =?utf-8?B?MnpFRWg5eVM4Z0pqNFQ5VEhWMHM4aXRWbmM1dVp3QWovY3dDbmxCZ3oveFRD?=
 =?utf-8?B?ZUVhRHdWMnNkeUUwdUdpK1V0MFdPM0xiVnhCbSt0RWNKYUdOalBDaU1kTFgv?=
 =?utf-8?B?eGJYMlpKT04yZGZYL2x6cy9DT3FnRXArd3dMM3h2bnlpUW9USHRJV2hWUjlB?=
 =?utf-8?B?Z21BTFBJc1pIQlU1Z25adklXME9MeEVLdzJlbE8wUU5CRG1MTnlJa1dzd21S?=
 =?utf-8?B?MXRjbTBmM1h3ZE1vQ0pXWERzQjNVK2dTZEtRZjhwSWhtTEpEMWpGWkFJNUhS?=
 =?utf-8?B?SDM0VTMxSnV0SW5DUlJ6ZnNoditIMFdVRVhzVmxiWmswaWx0NGxFd1pBSlZj?=
 =?utf-8?B?SzRnYTVhSEhVb2s1d1JNcmVPa1dKN3ZyZlV2YjBtMFNNSW5vRkhpUktHbDZ1?=
 =?utf-8?B?ZWNwYzlzQjhiT1dwK2VacjZ1R1Z4cy9IdER0Mk56UmZoN3ZTcjJqRDlxSmVo?=
 =?utf-8?B?YXpCSHUrQTZ5Vm5XNlZ3VnNTK2kvYTk1Q0UxWHRJVmgvRGdlOUhueWxIQUFx?=
 =?utf-8?B?bzhBU2hEWWVXdmhueERXUnlTNHlzenBOQmhVQWpON1oyVDFCYzlmdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23d81701-ed3f-4abc-a2a8-08da275b6aff
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 08:04:41.8866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aYrWI6aR8V4a2CIsjdRX7gFNWXq04IeFrmnc17T6uUu/OLrf3QUblCOTZ6gKcy7ASYNh6FMioynDlD4UN9Bnfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7208

On 26.04.2022 01:06, Andrew Cooper wrote:
> In a GNU compatbile makefile, $(LDFLAGS) are passed to $(CC), not $(LD).

I have to admit that I have always been puzzled by this anomaly.

> In a default CentOS 7 build environment, $(LDFLAGS) is set to -Wl,-z,relro,
> which causes the Xen build to explode with:
> 
>   ld: unrecognized option '-Wl,-z,relro'
>   ld: use the --help option for usage information
> 
> It turns out that many downstreams identify this as a breakage in Xen's build
> system and bodge around it in various ways, mostly by unsetting all of
> $(CFLAGS), $(AFLAGS) and $(LDFLAGS).
> 
> However, that is a security issue because it means that tools/ is not built
> with the distro-wide hardening flags that are otherwise expected of
> packages (relro, _FORTIFY_SOURCE, stack-protector, etc).

This "security issue" is introduced by them, I would say. They simply
shouldn't build everything in one go, but rather build "tools" with
the flags left intact and "xen" with the flags suitably pruned. (We
do build "xen" separately, albeit for different reasons.) The way
./Config.mk works this would look to be advisable anyway. And
xen/Makefile should perhaps arrange for Config.mk to skip this
massaging when including it.

> tools/ specifically should honour the packaging environment's choice of flags,
> while xen/ must not pass $(LDFLAGS) to $(LD), and should not be influenced by
> the others either.

I'm not convinced of the last part of what you say. Why should it be
impossible to say "make CFLAGS=... xen" just like "make CC=... xen"
can be used?

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -254,6 +254,8 @@ export KBUILD_DEFCONFIG := $(ARCH)_defconfig
>  # reparsing Config.mk by e.g. arch/x86/boot/.
>  export XEN_TREEWIDE_CFLAGS := $(CFLAGS)
>  
> +LDFLAGS :=

Instead of this, why don't we do away with the few uses of $(LDFLAGS)?
If I haven't overlooked anything, there are exactly two lines (three
if also counting a comment) which would need changing.

Or why don't we transform -Wl,... into the form understood by $(LD)?
-z relro, for example, looks to be benign to the linking of Xen, the
more that this option can also be enabled by default and we haven't
found a need to disable it (afaics this option solely determines
which linker script to use when none was specified).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:10:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:10:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313507.531054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGHR-0004DF-Te; Tue, 26 Apr 2022 08:10:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313507.531054; Tue, 26 Apr 2022 08:10:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGHR-0004D8-QT; Tue, 26 Apr 2022 08:10:41 +0000
Received: by outflank-mailman (input) for mailman id 313507;
 Tue, 26 Apr 2022 08:10:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=8/O6=VE=phptrix.de=einsle@srs-se1.protection.inumbo.net>)
 id 1njGHQ-0004D2-F9
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:10:40 +0000
Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5bb8f13c-c538-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 10:10:39 +0200 (CEST)
Received: from mail.phptrix.de ([93.233.10.210]) by mrelayeu.kundenserver.de
 (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id
 1MQNF3-1nVsFz2OSv-00MKFC for <xen-devel@lists.xenproject.org>; Tue, 26 Apr
 2022 10:10:38 +0200
Received: (qmail 2393 invoked by uid 210); 26 Apr 2022 10:10:37 +0200
Received: from chromecast.phptrix.de (HELO ?192.168.139.156?)
 (einsle@192.168.139.156)
 by portfish.phptrix.de with ESMTPA; 26 Apr 2022 10:10:37 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5bb8f13c-c538-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=phptrix.de;
	s=default; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:
	References:From:In-Reply-To:Content-Type:
	Content-Transfer-Encoding; bh=mklG6v4vScYJWt3mI0Idt2vqOo0=; b=B/
	MkorV3hlxS9LB+1F0/Yd9lhP92DIDjaDszSoDsVPjmPOW0b6s9uOIkNtVslGpBti
	HSmeXAMo0fNiVSpgqJS0EqTuQRNn0fQPrXJAMP7tHvl6M1S+EmQLS3eogHTQuhc4
	noaKJ9DnH/YOOdkOHLXHS40lKd8iKYsyw4+PUPB8Q=
DomainKey-Signature: a=rsa-sha1; q=dns; c=simple;
  s=default; d=phptrix.de;
  b=J+1lp8v2D3jl97b7bRGmTPWyGJTPplkCcTgCDvDPTHzIFpw2tnDg874+yGm437wVWvo2ujTxVPH/pR430pexoD8fjq0w+7E/l7bFOETG81h3KDlf31fhBfKt+wuBRDaQZQt98vDCp61WJ5WRwmYGnh5hRACHB8T4pNE1nITJulw=;
X-Qmail-Scanner-Diagnostics: from chromecast.phptrix.de (einsle@chromecast.phptrix.de) by portfish (envelope-from <einsle@phptrix.de>, uid 201) with qmail-scanner-2.11st 
 (clamdscan: 0.100.1/26337. spamassassin: 3.4.1. perlscan: 2.11st.  
 Clear:RC:1(192.168.139.156):. 
 Processed in 0.021908 secs); 26 Apr 2022 08:10:37 -0000
Message-ID: <8ec2423f-d968-54d4-4bc4-fd8ded3d1fa0@phptrix.de>
Date: Tue, 26 Apr 2022 10:10:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101
 Thunderbird/100.0
Subject: Re: DomU Windows Server Essentials crashes with xen 4.16 but works
 with xen 4.14
To: xen-devel@lists.xenproject.org
References: <18bd542a-a649-c78b-b575-c62b4d533e44@phptrix.de>
 <YmeZ/8wtKJy7zzmS@Air-de-Roger>
From: Steffen Einsle <einsle@phptrix.de>
In-Reply-To: <YmeZ/8wtKJy7zzmS@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K1:nqWzTxYPosD4SQBFaBmtju1gWh84mfbVDG0oXobudHlQc8MM5VC
 rMX7PvYMwL0CiCb4JJjgyUsHdHVH4HZ9z8iAm6GhrceELlRNMFv3GZueSbzkTGIiq4IAbvh
 3yy0/cJZCB08jKfTjXSJxpRRqmwyU+yB/PcgCfNzyVC6h2e2DvLjLUcVrbvu57gbvvjXdlM
 ZdspJbHrxb9Z67D4qsJKQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:aBFFIyY4FVE=:JjRN1nieKepL8YEnJT6g1j
 AFZXjRcsIP/F6Y+K82fpqMHP5riIjVGmpqYaGDSUz6xXyZ1KEpMWaQRl968mAIb8QAJZ8uix9
 XJqXrK0s1e0HEn5JrQYNmftS2+lrWywAp7tX+VwATF3oLx4cLNmImZ8rFBZpeDmUtMoqcgZF8
 paTzyrfuS6EjDK0xry4imypwhbj2N3oGQ8FoK/aTXLGhxEl+GnHoDBATiUX+yf4A1K7Q8ElOY
 qY+PL0jld5lYzcUmdg8vizZC0H654OvGbXjVBXt4gSJOC3+477sta8W8xEEgPbDduL4PfutFI
 mM9HYJ0HOCnIJ52yoQVXF31xnpI5pkN1clkHLCZHNEqc2REoPtw8zM3o8RGBsrBMd2t7M2+5P
 cRtLbqsEZn3/VQQq998uaJPCUTk3gCCYkIZrMPkQYQKejxSF/PTEa8yfeIh/tfU9Ud0/nQo59
 fqw8T3yngPU6JhXgz3bmyPYqkkVGmONqpBNh+Ry4Lm01kUrWVQmoIKy9A1FB5rUcP7K8HnNp5
 72yHWq3sSagbRu7xPwFHGcyda/s51HBuSDqF2Qs+kTOnoGj9pxqdccq1FgpbEf7E7VpLfj1fY
 FdzbZNr8a2pxeuysfF+USaG27kVzaf8JaBfepYjzFhwcvI6pKU0YcBxd4rmSi5kNK8TktR7DD
 okU7Nytzjzsn7ZxJYoqEWsCLvcLF88vuFtmp0rZoeT7QMohvCE2JIgj7XSxtMV30LRz4=

Hello,

I can confirm that "msr_relaxed = 1" solves the problem with Server 2019 
Essentials crashing.

Am 26.04.2022 um 09:06 schrieb Roger Pau Monné:
> On Mon, Apr 25, 2022 at 07:19:08PM +0200, Steffen Einsle wrote:
>> Hello Everyone,
>>
>> I have some xen servers I recently tried to update from xen 4.14 to xen 4.16
>>
>> Everything worked without problem, except for the Windows Server Essentials
>> DomUs.
>>
>> With xen 4.16 those domains crashed (reproducable) during boot -
>> KMODE_EXCEPTION_NOT_HANDLED.
>>
>> I tried to install a new DomU Windows Server 2019 Essentials - this VM
>> crashed at the first reboot
>> (still in the installation routine) with the same error. No PV-drivers
>> installed yet.
>>
>> I switched back to xen 4.14 and all VMs booted ok without problem.
>>
>> All other VMs (Linux-PV, Windows-HVM (2008r2, 2012r2, 2016, 2019, 2022)
>> show no problems, only
>> the Windows Server Essentials crashes with xen 4.16.
>>
>> The system is a gentoo kernel 5.17.3, qemu-6.2.0-r4, xen-4.16.0-r5,
>> xen-tools-4.16.0-r1
>>
>> My working configuration is gentoo kernel 5.17.3, qemu-5.2.0-r2,
>> xen-4.14.3-r2, xen-tools-4.14.3
>>
>> My DomU config file looks like this
>>
>> name = 'DC-Server'
>> type = 'hvm'
>> memory = '8192'
>> vcpus = '6'
>> vif = [ 'mac=00:16:3E:ab:cd:50,bridge=br0' ]
>> disk = [ '/dev/vg1/ServerSys,raw,hda,rw',
>>                '/dev/vg1/ServerData,raw,hdb,rw' ]
>> viridian = 'all'
>> localtime = '1'
>> vnc = '1'
>> keymap = 'de'
>> vnclisten = '0.0.0.0:10,websocket'
>> usb = '1'
>> usbdevice = 'tablet'
>> on_crash  = 'restart'
>> boot = 'c'
>> xen_platform_pci = '1'
>> max_grant_frames = 128
> Could you try adding:
>
> msr_relaxed=1
>
> And see if that makes a difference?
>
> Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:17:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:17:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313513.531065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGNv-0004uz-KN; Tue, 26 Apr 2022 08:17:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313513.531065; Tue, 26 Apr 2022 08:17:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGNv-0004us-HL; Tue, 26 Apr 2022 08:17:23 +0000
Received: by outflank-mailman (input) for mailman id 313513;
 Tue, 26 Apr 2022 08:17:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cQU5=VE=citrix.com=prvs=10866150f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njGNt-0004um-R8
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:17:22 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4937b1c0-c539-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 10:17:19 +0200 (CEST)
Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 04:17:15 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by MW4PR03MB6428.namprd03.prod.outlook.com (2603:10b6:303:123::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr
 2022 08:17:12 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 08:17:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4937b1c0-c539-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650961039;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=v33cqw5ky5sHlL35G+v6bFoFFbiObpPnCXptq4QJZVY=;
  b=DzPgjWE3kCDV+wLqW6YFgdd6CYtRI7bC2EDeAEURjNzhDcyvBZlGHtFw
   Px0TogrqqFYKcW3A+iM3UILQbUiSKS07ntfy+a6hXxiPYG37jrOV2iJEb
   mWs/0rnSVph3sbRxtSh1DkiUb9ghrQ5o0JPLSdIKWoV43BbQ9tX4f+gOc
   0=;
X-IronPort-RemoteIP: 104.47.58.104
X-IronPort-MID: 69925523
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:D1Hp5qKhO4BK3SJQFE+RWZQlxSXFcZb7ZxGr2PjKsXjdYENSgWAHn
 zFLUTyGPv/YY2WjeN92bIu19EsHuZ6Dzt5hTwFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQ22YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Ix867quST4xB+qWg8AhCBBiLDBiZ4QTrdcrIVDn2SCS52vvViK0htlLUgQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMCFGv2WjTNb9G5YasRmB/HRa
 tBfcTNyRB/BfwdOKhEcD5dWcOKA2CiuKWAF8gn9Sawf5WL2yCEg94XWMoTyXczRQvgEt1Saq
 TeTl4j+KlRAXDCF8hKZ+3elncfTnif2Xo0DGbn+/flv6HWPz2kaE1sSWF20sPS9ok+4R99bb
 UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6GAkAUQzgHb8Yp3Oc0SiYtz
 UShhM7yCHpkt7j9YXCX+6qQrDiyETMINmJEbigBJSMH/t3irYcbnh/JCNF5H8adlcbpEDv9x
 zSLqikWhLgJi8MPkaKh8jjvijO3r5nNRyY/5xnbU2yo6A90fsiuYInAwUDD7OxLJYKQRESpt
 nkYl8WQ4eYCAIvLnyuIKNjhB5ms7veBdTHZ31hmGsB58yz3oib/O4dN/Dt5OUFldN4efiPka
 1PSvgUX44JPOHytbul8ZIfZ59kW8JUM3O/NDpj8BueiqLAoHONb1EmCvXKt4l0=
IronPort-HdrOrdr: A9a23:/KbNH6ic8FSKMCsJrISMwZG+mnBQX0h13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ
 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH
 LKjfA32gZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot
 gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf
 36ISFlXCgJCgjTNfE=
X-IronPort-AV: E=Sophos;i="5.90,290,1643691600"; 
   d="scan'208";a="69925523"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kuo+/hg+LXd1reBELxcvAbFpLgB+gCq5e/S5D/hUlxzSVm/GMWLEPfdfQrohIWZIFe5Pn0/mFuMa+a/YiO+YAUIDNffzxJGYkw+u7VMAAcLU0PcU1t0IRUP1KaT2SWsIjkJoiDyErWz6t4OzSE6Rgq6/aI7YevchWfgJhOjM5EzDYDvf043XTkv908O4rB23VMgMsbN8oECsQlV9H9L+lkUipRXlfcGCqedjqSPjVJVjoUPN4+GJZcThWfZ2nWz1mSdQ6rufL4hvUsw3md8kr+E+wxuhKmBY64flAMED3pY2r1sUh9R+LGSzAamS1PYuUCE5Mb/c9pJfB4aK9JrGBg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6tB7mwREtH9hXWZOjxAw4PFbuWSk/rwMnHYktINV4es=;
 b=VXGmHsX/t+Xq0586B5M1W+TA9MDlpz7W9YOG0n3+LbR8PdTw+I71C0HmGfFbrOivh/8cV6Sj4i5GF3MN6ihDoY/YsFhNj3QVGlqoNEL0dGbBNXHwZlwlYQT8Edi54aiIn9cVf+AHZacUQ+FgTN3zrdr917MKYJlnZEfvAYhdW5I/tqR4rgmsjgECkn5RIJebQjU8DvN5TUsBeRktNQec528G+3XxwsL9R/SCLl+zzAHryET0EArFmksTOZOqE0ELU6xG7LIiDvKj8nDXN5C1bVC+c9vw3UxzPyY2mN7B6s5OepdPRimTJ6maLJLlxQTLuS6RKpGVPXHTeWIKh6+1EA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6tB7mwREtH9hXWZOjxAw4PFbuWSk/rwMnHYktINV4es=;
 b=jLAabFM6COLcG6ql9TfYub5u0PFAhDU3fTbAGPaMm18D0rLimbqheetgZSz+IcBRH0ShCV37XpIucSqr+Na4wgd9nZotiuFVS5aLFySSDstU9hp8o0QjVdsGBT0OpTBloWspnrG7+626k1HHOk261Gx9HWsBBAdxT4BpgbjZka8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 26 Apr 2022 10:17:07 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
Message-ID: <Ymeqg+UmOl2mN5Dz@Air-de-Roger>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <YmasHAT0YkeJVMbv@Air-de-Roger>
 <CABfawhn=6KVVPZD6AVRH2=NJFd5ZwtPpxDn__LdEFJQx6bhCXA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABfawhn=6KVVPZD6AVRH2=NJFd5ZwtPpxDn__LdEFJQx6bhCXA@mail.gmail.com>
X-ClientProxiedBy: LO4P123CA0067.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d7ec7c20-8ba8-4f75-f14a-08da275d2a4b
X-MS-TrafficTypeDiagnostic: MW4PR03MB6428:EE_
X-Microsoft-Antispam-PRVS:
	<MW4PR03MB6428408A04146D784747FE758FFB9@MW4PR03MB6428.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Pm8sCyoDq+E7FAb0LG/uu9RzS87ajErgvMCxseqZUwO4SVl9GIIqV9zTrEfQOiOwvqykTC+4ANWr8wpr6NCeTFhrej8EYttZjRWs1PwDYhySrraIjpQeCpMZtVlakye7ISc2KDtoF7jK0I8Ppem2IFQT2ztU/aADjn2YY4mJtZ3V3q4xdVwPwntC21AjsvvLKtgd3yr4yrm09n04pbwexbhOiBaQ+AWtmf0gW/q09UxpAg8rlPHUq+l993tt9ax6VBduojO6wpX6yZsbwiJTRpfazJif3isHjF/9+yuWU0Dra6DGi+UrK1ESTZ52/Q9RqyXJT/xg2xYJyo0Z6eFqn1kWOtbik27rtNlmExUFERypGhGevn78/MNW5TcBLkYawEfnUnoqfqtc/oWjkodjThVBEEsqiCgr+3eobifFMH1ndgX949h0o2likUgdniY4FXv25rwNYWXrfTymYLXc91j1mu9UUYAvm0/wCGeNo8Ws5czY5EVWkDvlR9MEjiFd9FWbU/T2g9Qs2gFMCqTxYuOgxtn/TZ2rV0K6jhHbg5P4Bm201fFRqDGumqsdgCuAQAnHB0yk4YpCoPf3qTf/fpsMUOSFghldV07yvyU5H5fdJ8/aSTGNyvsNunge7vsy/yPV7bIZr9iUCgM4Wb67rzCp45s9ThEloSURSEW7gUbcMbXWapuaowjLX9yVBpRdO0Maj+HD5Xt8a7HTnRGj5Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6486002)(316002)(33716001)(7416002)(85182001)(6506007)(53546011)(8676002)(26005)(508600001)(2906002)(82960400001)(6916009)(9686003)(54906003)(6512007)(4326008)(5660300002)(66946007)(86362001)(66476007)(66556008)(38100700002)(8936002)(6666004)(83380400001)(186003)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NW53eVE4YzIwUUFYQVpYZXpWREVMTEl6cTJaeTZabXV0SHRrUUJKelRKd1Zp?=
 =?utf-8?B?YnpOSWVCRTFFaWc5REErd093a0RmcU9lQ2Y4MXJQS3RjTEdqNGNHQmx1UmN0?=
 =?utf-8?B?eGQ4cTl0Nm5xbk5TYUw3UFpWbTFuM0l5UTV6MDhiL3ZQTFgrTE1NNEZLcFJh?=
 =?utf-8?B?a1NDYVlLVk95NUY0dXdKOFh2NHNyK3VqaXJnTXFGSjg3Wndia3hRZXJ0Vllm?=
 =?utf-8?B?NGpBeDVUQm1tWm0vZkFUTU5lTXpuaVgrY2ZYMlFpdkY5Q09Sb0M3UnlBZUlC?=
 =?utf-8?B?MFZIRThUZUl6bTZGM2dVYUpzMm10bFhXKzNNY0lreUQxWjJhYklTb3RZaWMv?=
 =?utf-8?B?eXBJMnpLRnRQNlFMU29EQTV3WXp3L3hjMTRzRC90NzVTa1R1cFV0aVVUNmpi?=
 =?utf-8?B?MDU0Sm5MRTNqNHNKa212dTQzcS9mTkpFaS9iNkQwVzNqYnZxU0pXazVvcGVT?=
 =?utf-8?B?UnEvL1E4ckI2ZlFBYTg3aU5zcWpJYUtPVzYyMUlmTkFsQ3VhRGxnV2tPRm1n?=
 =?utf-8?B?MFJnQWtJWmtDaUl6NWFrL21QdFkvaFBYNXRkNk94aEJ3dmRCU0d4ampoTXJs?=
 =?utf-8?B?UDBpcTlhdUpkVXByOElFVVBZN2FDR1YyQmtQTjJvMm9MaG9nM3M4RkpLTmhj?=
 =?utf-8?B?YmhCcDY0eWo5WTk5K1pPa3FyVkRDR3E0cmhZdGs2bktxWGJMMzgwM1ZqbUo4?=
 =?utf-8?B?Q3pYRitOYy9mVVExVUs4aHFOQktMaFhQNVZNL08vdWozYWxKQkZyVWNYRTg1?=
 =?utf-8?B?T0hJWE51V1NDTmxjcjFWRWxxOXlLdUVSNnoxMGlkOXVzL2R3ZlRjNURvT2N5?=
 =?utf-8?B?WCtUM3A4b0oxVjFyZko0T3RaK01vaWIwd3AwRXJnV1Avd01WbjRaTWkzcmk3?=
 =?utf-8?B?QW9YQkJ6UFE0MXNhTHY5U3phciswVWZqd0syU2t2aFFhNFpFUEswMzF6NEZz?=
 =?utf-8?B?QkU0ZjZ5NkVQd1FmSlRIQWdURzhyUWxlS3lZMzk4Zll0NVoreUpqSGZ5K1hI?=
 =?utf-8?B?dHB5OUVodmdiY05DS2t3SWZkTnp0ZDRSZit4U3VFUlNESlhBU2FTMC9sQThq?=
 =?utf-8?B?Yy8vS2tOcUhYUlJzKzlsT3pDQ0RKYUxRbXNuTTVVMDkwMDZHUmw3aXVrM0d1?=
 =?utf-8?B?aHJ2U01sMm5uMXh2MGcwc2NTR3JvME01VEtXL25zVm1sZW5iZVVOS0FFMnZV?=
 =?utf-8?B?QVQ5UDlkVWkrY1RVY20yeFFOUTRzS0JybW1mV3FpYzRvNHpMb09PcEdOeGNB?=
 =?utf-8?B?VWlYS0hYNTZwQmF4UGI0ZWlNcDNGRnVCdlU3VUUwd2dhekNDdFhxamx4cVFz?=
 =?utf-8?B?SGZ3YTFHY2lXaExIK3FlQkJ5Z1Z6TGQ5aE1VQk5IdENLYzRMUU40bzVpSEF3?=
 =?utf-8?B?blMzY3VObVM1MlhiWnA4QmJjTW8wK3R3SXQ1ZkxhSDFVWGhEaHBBd1hjL1Bw?=
 =?utf-8?B?MERRZ1paZExKK3ByZDNTTm9UdWZIUWM4WXdXY3VwckRtbWhtbkNJOEJJa05H?=
 =?utf-8?B?SnY3TStyaUNrejR5cDVqb1k1MXBoa1hEOWZrNUlhRW1TTWpkUVdEc05kckN5?=
 =?utf-8?B?TWl2QThmN21qd1RHWWdEZHJoTkZzM1NJR1NSYUtLTFh5NkJET0phNjFOZmlH?=
 =?utf-8?B?bkFESzNFVkFsbExmNmVwZ09kSHJweEJIWmUrQUJIcjBvUjJueUpkUmFjcnFa?=
 =?utf-8?B?OTJDcmUrZWh2SHpoN2pmZEZSdlhxbnpIbzVkTFpTZ1ZEWHU2VzVzVXhrd3VK?=
 =?utf-8?B?M1YvbmJtby85djRZZHl0REVlb1J4YUIrdEc3Wm9KdjJzYU83MG82MXZrN1Rl?=
 =?utf-8?B?Y3BYMUh0ZWExQUZReXZDS1dqUmJVZ0pSZWV5c3pWNXRUdEZ2V3NaRnFKS0M4?=
 =?utf-8?B?MnNyNVdnNFFsYm9OMTZJdk5qZ1JvSDhzVHZaZE12MW93MkttdFlHeUNHeFdM?=
 =?utf-8?B?WmpwZWVYNWlxaFJQUlZMZHd4aFdySzI1aDU2aVZrMWFaNC8yZ1EvVzVuWUpJ?=
 =?utf-8?B?b3k3c00vQ1AxWE1Ec3ZUbjhzVU5QWERrcUhqL0dmVFl6QmpUYzFYMjVBaG1U?=
 =?utf-8?B?OWNtVWJXTVpJVUFjR0hvY1VYV1hNRTdKcnBTZE5zR2R3U3BJMWk1T3dpNENv?=
 =?utf-8?B?OG1teVdscE9oQ3ZSR003NlA3a21IUTZoN0JjcUQrYTArZTlnU0tNOUxRa0Vr?=
 =?utf-8?B?ZkhoYVdYK3NjNzVCelp6T1NsRUttcXU4b3JxQktsNU9hTXlBcUkxTVJoSDhs?=
 =?utf-8?B?RGd6LzhLQWF4SzdOQ2R2RzZuTDZrVyt1SC9XWlhkTUdhSmc2Yk9PTU5qTS9T?=
 =?utf-8?B?eXBDUTdmYVc3QkpyOSs4NmJMREZBQ2tSMUIybDdieXBXWEdNbmU5QmdSY3o5?=
 =?utf-8?Q?Cr50TH81ehgbiA3I=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7ec7c20-8ba8-4f75-f14a-08da275d2a4b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 08:17:12.3126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v8FaY5ialNLjK15jvKOD+TCFWgd6N0dadnbquIfbBRxFl8kKULNbrAnMf6tNAyXOTdvwnTThvbkA0lo14xBV2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6428

On Mon, Apr 25, 2022 at 11:24:37AM -0400, Tamas K Lengyel wrote:
> On Mon, Apr 25, 2022 at 10:12 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
> >
> > On Wed, Apr 13, 2022 at 09:41:51AM -0400, Tamas K Lengyel wrote:
> > > Allow specify distinct parts of the fork VM to be reset. This is useful when a
> > > fuzzing operation involves mapping in only a handful of pages that are known
> > > ahead of time. Throwing these pages away just to be re-copied immediately is
> > > expensive, thus allowing to specify partial resets can speed things up.
> > >
> > > Also allow resetting to be initiated from vm_event responses as an
> > > optiomization.
> > >
> > > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> >
> > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Thank you!
> 
> > > ---
> > > v4: No change
> > > v3: Rebase on simpler approach after dropping empty_p2m feature
> > > v2: address review comments and add more sanity checking
> > > ---
> > >  tools/include/xenctrl.h                |  3 ++-
> > >  tools/libs/ctrl/xc_memshr.c            |  7 ++++++-
> > >  xen/arch/x86/include/asm/mem_sharing.h |  9 +++++++++
> > >  xen/arch/x86/mm/mem_sharing.c          | 24 +++++++++++++++++++-----
> > >  xen/common/vm_event.c                  | 15 +++++++++++++++
> > >  xen/include/public/memory.h            |  4 +++-
> > >  xen/include/public/vm_event.h          |  8 ++++++++
> > >  7 files changed, 62 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> > > index 95bd5eca67..1b089a2c02 100644
> > > --- a/tools/include/xenctrl.h
> > > +++ b/tools/include/xenctrl.h
> > > @@ -2290,7 +2290,8 @@ int xc_memshr_fork(xc_interface *xch,
> > >   *
> > >   * With VMs that have a lot of memory this call may block for a long time.
> > >   */
> > > -int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain);
> > > +int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain,
> > > +                         bool reset_state, bool reset_memory);
> > >
> > >  /* Debug calls: return the number of pages referencing the shared frame backing
> > >   * the input argument. Should be one or greater.
> > > diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c
> > > index a6cfd7dccf..a0d0b894e2 100644
> > > --- a/tools/libs/ctrl/xc_memshr.c
> > > +++ b/tools/libs/ctrl/xc_memshr.c
> > > @@ -257,12 +257,17 @@ int xc_memshr_fork(xc_interface *xch, uint32_t pdomid, uint32_t domid,
> > >      return xc_memshr_memop(xch, domid, &mso);
> > >  }
> > >
> > > -int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid)
> > > +int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid, bool reset_state,
> > > +                         bool reset_memory)
> > >  {
> > >      xen_mem_sharing_op_t mso;
> > >
> > >      memset(&mso, 0, sizeof(mso));
> > >      mso.op = XENMEM_sharing_op_fork_reset;
> > > +    if ( reset_state )
> > > +        mso.u.fork.flags |= XENMEM_FORK_RESET_STATE;
> > > +    if ( reset_memory )
> > > +        mso.u.fork.flags |= XENMEM_FORK_RESET_MEMORY;
> >
> > IMO would be clearer to init mso fields at definition.
> 
> Not sure what you mean exactly, mso = { ... }; ? I think the logic is
> pretty clear as-is and I don't have any preference for one style vs
> the other.

IMO it's clearer to initialize the fields at declaration using
mso = { ... } because then you avoid the memset.

> >
> > > diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
> > > index 84cf52636b..d26a6699fc 100644
> > > --- a/xen/common/vm_event.c
> > > +++ b/xen/common/vm_event.c
> > > @@ -28,6 +28,11 @@
> > >  #include <asm/p2m.h>
> > >  #include <asm/monitor.h>
> > >  #include <asm/vm_event.h>
> > > +
> > > +#ifdef CONFIG_MEM_SHARING
> > > +#include <asm/mem_sharing.h>
> > > +#endif
> > > +
> > >  #include <xsm/xsm.h>
> > >  #include <public/hvm/params.h>
> > >
> > > @@ -394,6 +399,16 @@ static int vm_event_resume(struct domain *d, struct vm_event_domain *ved)
> > >              if ( rsp.reason == VM_EVENT_REASON_MEM_PAGING )
> > >                  p2m_mem_paging_resume(d, &rsp);
> > >  #endif
> > > +#ifdef CONFIG_MEM_SHARING
> > > +            if ( mem_sharing_is_fork(d) )
> > > +            {
> > > +                bool reset_state = rsp.flags & VM_EVENT_FLAG_RESET_FORK_STATE;
> > > +                bool reset_mem = rsp.flags & VM_EVENT_FLAG_RESET_FORK_MEMORY;
> > > +
> > > +                if ( reset_state || reset_mem )
> > > +                    ASSERT(!mem_sharing_fork_reset(d, reset_state, reset_mem));
> >
> > Might be appropriate to destroy the domain in case fork reset fails?
> > ASSERT will only help in debug builds.
> 
> No, I would prefer not destroying the domain here. If it ever becomes
> necessary the right way would be to introduce a new monitor event to
> signal an error and let the listener decide what to do. At the moment
> I don't see that being necessary as there are no known scenarios where
> we would be able to setup a fork but fail to reset is.

My concern for raising this was what would happen on non-debug
builds if mem_sharing_fork_reset() failed, and hence my request to
crash the domain.  I would have used something like:

if ( (reset_state || reset_mem) &&
     mem_sharing_fork_reset(d, reset_state, reset_mem) )
{
    ASSERT_UNREACHABLE();
    domain_crash(d);
    break;
}

But if you and other vm_event maintainers are fine with the current
approach and don't think it's a problem that's OK with me.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:33:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:33:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313520.531075 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGdg-0007Dx-1b; Tue, 26 Apr 2022 08:33:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313520.531075; Tue, 26 Apr 2022 08:33:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGdf-0007Dq-UJ; Tue, 26 Apr 2022 08:33:39 +0000
Received: by outflank-mailman (input) for mailman id 313520;
 Tue, 26 Apr 2022 08:33:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njGdf-0007Dk-Fm
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:33:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njGda-00088S-Li; Tue, 26 Apr 2022 08:33:34 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.15.135]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njGda-00025K-FA; Tue, 26 Apr 2022 08:33:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=h4YX8rqQzCmA8T91YPdPLIYmjjKLa55vnhuZa5+Iirg=; b=cfFaZv3CcrxfCT0ZTQqGLjUV9j
	Q/orSv6HDRRSF+lFkS3HqZn8H43tfQ2lfzSrhDyGvx7qsfzR1oFuGeZDz2l9SNl94TeTjx8kEoehP
	OLVV8AGHHK3pF6xmF08UKQK0H6VOIoESg8yk6ANIc3a9ApBl2EYX+/atsoq2xX4LcDHk=;
Message-ID: <bce39358-9739-c39d-c97f-6bae216da89b@xen.org>
Date: Tue, 26 Apr 2022 09:33:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
 xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <YmasHAT0YkeJVMbv@Air-de-Roger>
 <CABfawhn=6KVVPZD6AVRH2=NJFd5ZwtPpxDn__LdEFJQx6bhCXA@mail.gmail.com>
 <Ymeqg+UmOl2mN5Dz@Air-de-Roger>
From: Julien Grall <julien@xen.org>
In-Reply-To: <Ymeqg+UmOl2mN5Dz@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 26/04/2022 09:17, Roger Pau Monné wrote:
> On Mon, Apr 25, 2022 at 11:24:37AM -0400, Tamas K Lengyel wrote:
>> On Mon, Apr 25, 2022 at 10:12 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
>>>> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
>>>> index 84cf52636b..d26a6699fc 100644
>>>> --- a/xen/common/vm_event.c
>>>> +++ b/xen/common/vm_event.c
>>>> @@ -28,6 +28,11 @@
>>>>   #include <asm/p2m.h>
>>>>   #include <asm/monitor.h>
>>>>   #include <asm/vm_event.h>
>>>> +
>>>> +#ifdef CONFIG_MEM_SHARING
>>>> +#include <asm/mem_sharing.h>
>>>> +#endif
>>>> +
>>>>   #include <xsm/xsm.h>
>>>>   #include <public/hvm/params.h>
>>>>
>>>> @@ -394,6 +399,16 @@ static int vm_event_resume(struct domain *d, struct vm_event_domain *ved)
>>>>               if ( rsp.reason == VM_EVENT_REASON_MEM_PAGING )
>>>>                   p2m_mem_paging_resume(d, &rsp);
>>>>   #endif
>>>> +#ifdef CONFIG_MEM_SHARING
>>>> +            if ( mem_sharing_is_fork(d) )
>>>> +            {
>>>> +                bool reset_state = rsp.flags & VM_EVENT_FLAG_RESET_FORK_STATE;
>>>> +                bool reset_mem = rsp.flags & VM_EVENT_FLAG_RESET_FORK_MEMORY;
>>>> +
>>>> +                if ( reset_state || reset_mem )
>>>> +                    ASSERT(!mem_sharing_fork_reset(d, reset_state, reset_mem));
>>>
>>> Might be appropriate to destroy the domain in case fork reset fails?
>>> ASSERT will only help in debug builds.
>>
>> No, I would prefer not destroying the domain here. If it ever becomes
>> necessary the right way would be to introduce a new monitor event to
>> signal an error and let the listener decide what to do. At the moment
>> I don't see that being necessary as there are no known scenarios where
>> we would be able to setup a fork but fail to reset is.
> 
> My concern for raising this was what would happen on non-debug
> builds if mem_sharing_fork_reset() failed, and hence my request to
> crash the domain.  I would have used something like:
> 
> if ( (reset_state || reset_mem) &&
>       mem_sharing_fork_reset(d, reset_state, reset_mem) )
> {
>      ASSERT_UNREACHABLE();
>      domain_crash(d);
>      break;
> }
> 
> But if you and other vm_event maintainers are fine with the current
> approach and don't think it's a problem that's OK with me.

The current approach is actually not correct. On production build, 
ASSERT() will turn to NOP. IOW mem_sharing_fork_reset() *will* not be 
called.

So the call needs to move outside of the ASSERT() and use a construct 
similar to what you suggested:

if ( .... && mem_sharing_fork_reset(...) )
{
   ASSERT_UNREACHABLE();
   break;
}

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:36:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:36:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313526.531087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGg7-0007qC-Fm; Tue, 26 Apr 2022 08:36:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313526.531087; Tue, 26 Apr 2022 08:36:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGg7-0007q5-C3; Tue, 26 Apr 2022 08:36:11 +0000
Received: by outflank-mailman (input) for mailman id 313526;
 Tue, 26 Apr 2022 08:36:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njGg6-0007pz-Ka
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:36:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ea809fbb-c53b-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 10:36:07 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-eq2SiM7AOMGmI1JAqQ31Ng-1; Tue, 26 Apr 2022 10:36:05 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4029.eurprd04.prod.outlook.com (2603:10a6:803:40::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 08:36:04 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 08:36:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea809fbb-c53b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650962166;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wE0dAcNpuab9EHgItkLtAH1Is0Jr9wHHOKbDprsJ5xg=;
	b=I21GFxN027wXN69KCAG1R2KGsEXXZPraHswOGOzwPrK7aTpf6l6IvhEz+i0sC27NixTKea
	drHzUppPiLsiIRHIh+eNqPuvV5NFLRtXMXOEVvtLmZ0PDAF1vISqXUgR6RuVWscmfg/vjd
	NyEwk1NpA+PibpZ211SEdj0s/7q62rA=
X-MC-Unique: eq2SiM7AOMGmI1JAqQ31Ng-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DoRq/TrnxBnBcE7HZDvBiqVDPDxHzbr/mIcowe0auIr1814kgJLaRq90jGjOnVxZruQ/sowY3UoE2SKjzpyhU6v/n+cmg5SaNyYmhOyI5yuqbADWxUhn34PM3CXPxf6O0T76oP9wNK3g+twf+o0cruV7ZlFOYClV4IZUtSI2CtxEkRR4P7rxrHMw2UlZPA5pQ7pMlhMus/9vADHP1clOo4x9HpKjiOkRE22sg84p2M9HcKaFHCjcNFQwT2lnOQVTekQh6zCtVbeH+GBK1pUnx1ZP7q3noPZll/XNacNpyUKELz4dc3DM13NkZgpYlBclGI7Wl9eeUtyKd/BYubiftg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VxNmv+Qb/xUW1DVBPzy4gL03WTVj/O8Is4qts9N9Tys=;
 b=AyvzC7u835b+mD8n0ddEbH3ISP8tYQ1J6A4EYd/o/5y8E7/MYnXw76K1L1e9gyq3Rlss8aUcrVp32+O/EOJ//nu3puHiNVxeGiUOEeDCoOcHghcmnYax5l6l+wYNcS/b+9c5Vo7OVfgHXgM6jVgo3T7PkQAljAc62+gI1hujwZGDgm0IG6QZlrfVaUCLB+4IbVTJ0hcxXGSG/MJXKk2ePIJJjhKk2hItsvOx089i1jkQUS2pgTgmMwqj2gmBppti1L7qp3P9fkfka0q8cvaPEumnjgRU0R8QskwL+zgbgAtFU0z+MQzmTj1jCZ/8IFDiet/7VbpON4fC3QUoutvJ5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9da91b7b-7dc4-ef2f-6e72-e921b0d5651f@suse.com>
Date: Tue, 26 Apr 2022 10:36:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: Julien Grall <julien@xen.org>, David Vrabel <dvrabel@cantab.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <4fbc28f9-5a0e-5ed2-12a7-d2bfd63af633@xen.org>
 <afb15744-5e80-6c40-069e-6fc076e40e3d@suse.com>
 <74500983-79f8-07a9-7dcf-54a7bc162061@xen.org>
 <54e0a438-e3ce-98d6-1b7f-ce2d69d45c7a@cantab.net>
 <c5273a0c-082c-0e10-a394-fa43654f1d24@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c5273a0c-082c-0e10-a394-fa43654f1d24@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR07CA0014.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::11) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c61f5f81-c599-43ed-b1c0-08da275fccd0
X-MS-TrafficTypeDiagnostic: VI1PR04MB4029:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB40291CDDC3FBC9BE6935DA00B3FB9@VI1PR04MB4029.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fDwjym9w4XLJZoVE6e2VWFuneThkDOHJRwDuBQSXYp+0/sKikEKW+qe2yHaqdoQt4Ig7M5eAnywOrgMisNxfn73db4hUv8dNg9ce8nJCqXvTGpMq8XBzZIltU5YBtnUFUpi+4sYxFdpmwILcHmPcm+qrI2yZbE7NM5TvAFU7fv52HYHoLLI1Reub7qq7naOcwollpJhDEJSXhICp4E4G4q//xz0pFmCXLjuL5jJZeewT7udfpP77fHljvqaddly+F3uXdn6E/8rbpsGSRgpJJht/hZcCHEqUfLEq8YpHUFFlgSK7UA557mM6aegNj6mvGtvsLoElE6vGY05IqdqJMX8cCmunpZ+mQolwK4v/Sjr4+dFu/aiNomxkwCeSutTfaL9sEnRV1SajsyXjmmqPrDTqEmlqeILww/uHfJNLrnPq8caA6k20BO4nC16mYj45lkdK6tQUj1FIpA7e1sk/VdKdIjc8sbwe5Ipfc0et8feKlmuMQiEqg+xReDta96OiTZHxJ73tamIWiV3A4XW9UfTfcujPKjFnRFmhXTWDYAM3ggLgeVrgU46Ms4Dpk5Xi4tD6vLajkDT9ooYd56Hv2N1RVW9vZ2FnR0iBOWayibf2vUkg1A2CrjwwfW5dygutzh9MT//Opqt6AbFeF1FGOiPrOEF36nmWeWo/LJfReUZv8/kuEVJZAZwLTxHcYVOqxbOt0NnLEN/XcEkUw5qewS/UoMsS+0QMfGELBFPQU7g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(54906003)(66946007)(6512007)(66556008)(8676002)(66476007)(4326008)(2616005)(26005)(316002)(36756003)(508600001)(53546011)(6506007)(110136005)(86362001)(186003)(83380400001)(38100700002)(2906002)(31686004)(8936002)(5660300002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?idxyGms2D+7k67xMVUVuoVyJDbSbzr/76pSszljtXgWSr7G/8J5uDlzKfjzm?=
 =?us-ascii?Q?q7vGs7TuWst2rtw0yyAVzWxA8+sIqTs3Z+YtfWJxXm+uEmq1w5qQcjlGGPUZ?=
 =?us-ascii?Q?YfFO9rADqLf1tvCFE0MtVlgKNmKYU/BcyciKNfcPWswluqZGjorQg4FTANMW?=
 =?us-ascii?Q?0L5sIueQE+t0IuBFsqpypISLnqFBpr6HhyfW0D/W6uMvPHoZHn5O/RSYVwd5?=
 =?us-ascii?Q?MSYpEl7GV2SzZyW7xzQ5silr0Jtv6gd7K8/6OZCm8lTEJl+h195gliBo0uqR?=
 =?us-ascii?Q?DaFKCXCs1c+hXfkZsLjTkRn5os9zGTp+FEtlDk9K+fVXJmsZ5g1tnKp1cl/K?=
 =?us-ascii?Q?MfElCEaz6oFvIaVZHYVaUz3NJinrsMJuzQJYhu3j8NropHfVGXCrgScacK6I?=
 =?us-ascii?Q?ZaBKCRJUI1Mlb/zFypalGqYi8Wxdl4ay7HvLJJiho73szu318JngR9VJqcLL?=
 =?us-ascii?Q?56XitBt4Hx/faO2Efu/0P13taMgm4kPCm4kytWlmRzrBxH412xFVQ/wQ/0QV?=
 =?us-ascii?Q?3DQgCRj+WJs36WSflHxUrwcZ4Sdc4hdFz6z8twbuMuN9mTIA5r0w6MgQzczw?=
 =?us-ascii?Q?w6iNOsGP5JhekI9rLF3CACJ4Wtbo7VkgMqRkbcGKObEqwU8tA8cJIb7zVIVL?=
 =?us-ascii?Q?MQY1UU6xzb+zKuI041a8trAjM5aFws3RWNwlCCTSIORKThiD/NS3OTY6zwFD?=
 =?us-ascii?Q?VkFmyqsIf9GDQfWvV1RnLrRICr7NaghreVu/0f+trW1D9xlYDQZ2ydrq+ZGh?=
 =?us-ascii?Q?I6Ov896VYZFLeq09xDPnbm3oFO3TQjNC5fIDLAheR8oQq6fBhlBwvXITw5J6?=
 =?us-ascii?Q?j9hIixSLziIGr0pRi6kxiVEDm5TVRPT/7q3x6GFhOx6d8n9NfaQzyQRwTY5e?=
 =?us-ascii?Q?xU/KutoB8KlNrWTUBs+M6PlIhazV6nFff4z+gKm0fUyUcuPXbwEyuo29Y9q8?=
 =?us-ascii?Q?/dImL5ynWAKiobZLfpXycJMgWnT+X31Ozquept3tnLsFPx6YiaRTadA3Kpzf?=
 =?us-ascii?Q?qP1uu8XdNYUYZ64x7soM1G0gKJZhtpoeKacEIDcKANqVB+6V69nQI7JFSYH1?=
 =?us-ascii?Q?9YJOMb+tj9w+spEKUyLcKoJ3nqMV+OE6s1nzUgfTSphiibdXJ6Tp7Bd3D0xD?=
 =?us-ascii?Q?nL0Y/4mOyxPGGi/RbEjLgg0fT7S8ctE3w0p/2u96EtzfpjD9INQZzp4CHlsJ?=
 =?us-ascii?Q?gqzQRWfs1gdc31ZDiBUvVx1AggDJZlAyf82nuw5KPvyFEmY1zP59uI05ca5i?=
 =?us-ascii?Q?7OErBNMH2uyv5snSkzlyYST9D5cDV5L1lzeFGyW1H7x2GWb/AoLp+O41p4g5?=
 =?us-ascii?Q?XgTh4OGhf18WM7053Pzqk4Q35SYjnmn+nDz90ybgezSQjzpL+1Nu+ZPnNX20?=
 =?us-ascii?Q?ln4lqOx6ZE8HijZNY4f8yT3FcJJfKpIM34wtnbPdybsLNaBtOxN5Z19XiE/s?=
 =?us-ascii?Q?wwb9ObLm75J6MFcGiAFxj5i9vNQgPxo1JZhUtg25f4Lq1IT9ZtFk4aMKQTiQ?=
 =?us-ascii?Q?k+64qQUESxI0+iVvf0gXOmKsEeR7fdUZqvD4xDbrf5JYaM/Y8xWsQFu2zvFs?=
 =?us-ascii?Q?o4XDteb9xUyC1nvB785//voclX1H7vYBQFpCVweBk2tTfaD2k4g6r2CUeP5A?=
 =?us-ascii?Q?6pbRYmlr2gFdlz7JF519d2b2bz6DPMOOWWjOxsJ8oF+uO+rRuX8k+rWwnyBl?=
 =?us-ascii?Q?ao76gmA9PNWVTAIZI9mM63pQ51RKy3rwPlWWkuLxJjIKYnAKjkUoaWy3BaSu?=
 =?us-ascii?Q?YtVg5O1c5g=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c61f5f81-c599-43ed-b1c0-08da275fccd0
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 08:36:03.9514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xl/KR8v3vO+tEcb1yiBNvw87os6KNyiluVtVOJhDlUTQ/rfQpEKyJuEij5S/YNx2iRqKDFJFgrRAF99rrcjaSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4029

On 25.04.2022 20:32, Julien Grall wrote:
> On 25/04/2022 15:13, David Vrabel wrote:
>> On 25/04/2022 14:43, Julien Grall wrote:
>>> On 25/04/2022 14:37, Jan Beulich wrote:
>>>> On 25.04.2022 15:34, Julien Grall wrote:
>>>>> On 25/04/2022 14:28, David Vrabel wrote:
>>>>>> --- a/xen/common/page_alloc.c
>>>>>> +++ b/xen/common/page_alloc.c
>>>>>> @@ -162,6 +162,13 @@
>>>>>> =C2=A0=C2=A0 static char __initdata opt_badpage[100] =3D "";
>>>>>> =C2=A0=C2=A0 string_param("badpage", opt_badpage);
>>>>>> +/*
>>>>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>>>>
>>>>> The comment needs to be updated to reflect the fact that at least Arm
>>>>> doesn't use IPI to flush TLBs.
>>>>
>>>> I thought the use of "may" was satisfying your earlier request?
>>>
>>> Maybe I read wrongly this comment... To me, anything after 'which' is=20
>>> optional (it is a non-defining clause) and describe how the TLB=20
>>> flushes works. So the 'may' here is referring to the possibility to=20
>>> use flush TLB.
>>
>> Oh dear, you're using formal grammar with a native English speaker who's=
=20
>> never seen a grammar rule in any of his schooling.
>>
>> I think this should be:
>>
>> "Heap allocations may need TLB flushes that require IRQs..."
>>
>> i.e., "that" instead of "which"
>=20
> I am fine with that.

But that's still not necessarily correct. I've gone with adding the 2nd
"may".

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:38:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:38:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313533.531098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGiX-0008VN-2M; Tue, 26 Apr 2022 08:38:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313533.531098; Tue, 26 Apr 2022 08:38:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGiW-0008VG-UR; Tue, 26 Apr 2022 08:38:40 +0000
Received: by outflank-mailman (input) for mailman id 313533;
 Tue, 26 Apr 2022 08:38:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njGiV-0008VA-Oh
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:38:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4448cc15-c53c-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 10:38:38 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-W7UOOZBiORi6oRTKcpaLXA-1; Tue, 26 Apr 2022 10:38:35 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB5840.eurprd04.prod.outlook.com (2603:10a6:803:e1::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 08:38:33 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 08:38:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4448cc15-c53c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650962317;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lBkE7eTF7d8RIZyk7nlXKHsUIrYN4gx/wA2E5Wwapdo=;
	b=k4pDhH99WEWbBULT9NLmtzfdInFkD9Id8DIeFKYUZYz3mxmHfuOBx4AcoPAWsdqCIzKuMI
	+wK+dKNgjmPSYjtpwGQjooY0O/1nYJEKX4KAuvfTfKHVAKA7oUb1YZbPv9nUckVKnjO8lp
	b02018vPsdxsxBAW0PvvgYnyFaqYbAw=
X-MC-Unique: W7UOOZBiORi6oRTKcpaLXA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SxuVTCMIxQr1ZNkyg6Dl21wBDHaYWv9ESKkNtFGerNwtYT2YA/+oXuK6hNo/K8eWTqEsEFm6lkF3ZDH21yfLdbe0xacrM+sny+k3hdoRmC2h9zol16xxqXU70m8urQ5Tuk3us8y8AiCRfKI+N44Z7BmYmbePF5zzwvDpXySLQEu0s3clS+mFBS907VL1Vg1l7MFrpUaFzHspBthiq/PrGXFJy/EzjzZ9e4fCz/jkznqG3t/fesYy9s92dH66zfnUMWox3bZDLSV+RJNqg1bYaHBHh+20c1qqELDP9uHcy+/bfwrQJ5Efy9BUfdOIxS6idh+afMxkIUwFg7n+hNSxLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=39gSxaZarIGiWvuuRq88Gim1WO3liOaPHyJBScEprdk=;
 b=E6ZooCZ3gOfhKb05PtCxPCj/oVTHfBCLz38bBecFzAU77G7ja6Ue2m7QIdsM82XzSSrvDKCxZrtkt7BGtqVgftirFfXOkmhczslMC/54cHPSjNvvU8oMHMekRtaZ6GJYLUm9yoW/kzF6NcvlyUWTCovZA34fap9nkSuBI7HexheBx6BgvnsagR7RT4O6nZO2XVpvI0WT7x6afY5E9tMmytbS82dDh89dfqJ7ei8xpF+Cj1CHqhFrvcqh5h4qtBFLmGHBgiOq/VryayWeV8Eb7AWuiCSIQwXJrh/fynQBrGO1NP7Sw7u8gzhZ3aGm0kRVV/gOXhluyPwCcjxG031R5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0e2724dc-bde8-a477-24aa-4bec5da55548@suse.com>
Date: Tue, 26 Apr 2022 10:38:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xsm/flask: code style formatting
Content-Language: en-US
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
CC: "jandryuk@gmail.com" <jandryuk@gmail.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220422194344.9318-1-dpsmith@apertussolutions.com>
 <5b199cfb-98c8-c382-82b3-a60819a0e977@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5b199cfb-98c8-c382-82b3-a60819a0e977@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0162.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::17) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9d566740-9ce9-424d-2bd1-08da276025f2
X-MS-TrafficTypeDiagnostic: VI1PR04MB5840:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB58403F3579ABAF2B3992F20CB3FB9@VI1PR04MB5840.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Y7LpAismS6zmSaLITx6ln13QzpnYBX9+jY1ghn1wbMaqEBCZgdTz9KJFuF04SZYsB2rJ/AilQBLKEx1pAXPmNtZXOPaEaUJ7tjW04R0nCleMFn2W5/49rQMpXRNhrYyQq0UJ62Via6jYjkWsDw+3bKajDgJxw72IlocZe0Cks5cLceed9PTqoazO/moBC2yYuXwa8vhuHutOyv17WoSfmQjLoZhCC9Ng4DdqSuRMhmAIsK2AD2bmcY/I6GoLW40XyZgiP9aE1ZF54x92Uk7NZoyClfUvhZyGJe8VlsPsQ2loJo2Hn9i8buAZUabTtfNMsDSzCXkpplF5yX7EzQt9y4mBFevkHyJec423CpSK/CXQb/TgwF7bfgCRow/qotb6BXb0lkS1SN6RoqdSiYWmDYwHPUiT1byHx5FByapvYD5PpgvM8edwEqyIP+xYhjpZKPfRzYnIEeRly1SkzsuiZdMXCU9MeIuH+dol7GJH4VyN2XFT2YZB6MtcqSviKGp6206B7n4IhO+OzqXmX3EHPuvgYLMbGiimplHRyir/1hLAETQq5fwYQDLmK9EW8c7leodbIEQmG8fr1nr/A2xrQNlyaoj3+T3pFPLZdDZ3CXUzBIRYu+X8VsaiarbyOsnsUKWzwI37uwkk4MhxjFppaTPq/dtYWJWFgCWAmTX9ubWXn5Tn2wjn4Q5wzF2i8f/r95tY5nd5HZR8Gqb0owrXp5JYaPA+GHDO2gk3w7yHS+OwIpLZIOiBFRlgQPrRVUhV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(26005)(6916009)(6486002)(6512007)(4326008)(53546011)(66946007)(6506007)(508600001)(66556008)(8676002)(316002)(38100700002)(54906003)(36756003)(2906002)(8936002)(2616005)(5660300002)(186003)(31686004)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kxGkzjW7VrNTywFdIgZvgI79AOVXphx8MrZpp/C2RTbDJMMpPTQm6UmA9bmY?=
 =?us-ascii?Q?j7nLOAxXLeEz2KJWjhGPtUi8bQkUb30EYy+PXcCUEG5B280+wLAlht22+Mpq?=
 =?us-ascii?Q?aiQs7iOVaeCTCGT5K6FDbXFbRyas616Ouve65ZVRt4I90+1e88SsmUXHntED?=
 =?us-ascii?Q?UYDGRx6wDiypBZ2v6HCMJJS0QOqL5vfog9khe4U+vTcGADnI6mevS+zVG88S?=
 =?us-ascii?Q?mhIiTCnvcY7II30tzJC0e3w86cGUrlc3IAzjebhIOP3NJgkAMJPnvOSuQHQw?=
 =?us-ascii?Q?T3m8kJnj7NeTLbRSIn7vOz3eiagRA0DLBy4NiMnBtf2SsL2auHiJhcHHW0a/?=
 =?us-ascii?Q?SIN8cvuLFFHqliGqwMGtk2g9NVi14apncS7xqVhKmFRbrfESBwBQ1iY04YXt?=
 =?us-ascii?Q?nwL6p7dSvMVMn3X6vSmw0krLvVNAHxSdrSz/NqwgWFE6AX9JKKWuN+pEU39w?=
 =?us-ascii?Q?pdGWrVe/QRX0Ch5jlzEz3yq4XdwNOFhosiDA/PGVpIHK8LignI90tBtybM85?=
 =?us-ascii?Q?Mf+v0JwYZQ7WeD8sYjc5DgG+uFPVV7GuJOt6NWQ8K266VZMoEl1JnLb7ta6G?=
 =?us-ascii?Q?rp/Gd8TWKDSBoM9SulQMJKJmsrOJSl6uQ7uFNX3dre/G8BlYSdaO/KvgQnzm?=
 =?us-ascii?Q?dsJjiBnwxlMsq4gdWCFO33iGF1QwJPX3/WEkbd+1KeY9Gx0nfzqTHfW6VrTl?=
 =?us-ascii?Q?sBEfQpeZcnsRdbmO9hoqkHNIUnS44l6CmAUQBxwmVI3QGa3IzqfpGFQ79G4m?=
 =?us-ascii?Q?UyFLsBx3FEoiDeS1cNaejkvhwppi4lCjnmyyrGGsOOUkNNGXsM7l3GE5m6Gy?=
 =?us-ascii?Q?WkIZv278y34J0/IC4MCYWf5m2yJ9SSq0mqkbYQ8t2mn+O9igrMYUHT4KmKt9?=
 =?us-ascii?Q?lW4dzvUenbraM2Bhn4kY7o0TxHFkb4jG+jsYDUBWuLw8Ojs2j2pzOkkn2AhN?=
 =?us-ascii?Q?uxFHdxWd0pMDOMkL7X00+QTHHRjcVIqwH9DUJdYm+WLryMTf2Nz833iUK6uh?=
 =?us-ascii?Q?jY9t9tWeuiqRvE4mY0lf6cCgqaUCb1u9OEP7/uggn4ufLFn7hxBdotGMzTc4?=
 =?us-ascii?Q?5mPwTkk4SOiVvlkiiX+JbbzvLs89wq482D+82jqlS0mW5esDanawTN08muEU?=
 =?us-ascii?Q?ra3zrCc9PucPo/HA5hTC8fpO6eFBfz6Qx/Q4JTtiOxJq2uM840qUms41segh?=
 =?us-ascii?Q?5nkReMYLRc5CPPm3Q7Rm9jkCRJp7flZI8e1zrRsxMvAMJi3pB7e7Kqi14nz9?=
 =?us-ascii?Q?Ei72UyzlfuVAwnEEb7F/+hNhsG1UA5/t0aEIxJtxD6Rbx0vu6bj4yStfoh3M?=
 =?us-ascii?Q?u066d+seHSfrhwI3kST3EYJ8j+N01F6ttSXtpHM62uUsXvJvyETj+M/CK2Cy?=
 =?us-ascii?Q?BsOQ6CTSlMcfZ/6rIO8ZQUH5BqY+YFeGiLcV246RCQwZy6Dx1UIU8ryBzpMD?=
 =?us-ascii?Q?X0T8loL3bh+ct3rZ8hNgTTlOCOvI+gjBKOsEusaUmMJxKxfrD3c4gHsrlSPN?=
 =?us-ascii?Q?JJd0btoqNRHdkddpbaEHvQZaR/cl0BjIU42RLYweQ+5z+sBOkBtfNv4cAsW0?=
 =?us-ascii?Q?yMu0kdAtq4QhO7D0T3Iz7n+wlBa46QmdOdjflL0eTQurOGdo9aQ24K0gheCK?=
 =?us-ascii?Q?JaPMmM/Dpz1tiOQVUl6eedEbtkE8/M+2OYTwOGCbWMpLO0VXMQiRVkEqHILt?=
 =?us-ascii?Q?RiChrQA7DpP6/m5L5/GQqaswU6+G6NLZBVV/ya1iHYCHRqHSJVAwrpvxl3v1?=
 =?us-ascii?Q?NXPwA41Icg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d566740-9ce9-424d-2bd1-08da276025f2
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 08:38:33.5192
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +fqkhybcIlHAZ6yqUjVHAkyDpzGfBmBsSXC5FPw399wWtER0OLkpOCJRVAA+TDIzgWWbKbHvM4qplbBQtgkfYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5840

On 23.04.2022 01:07, Andrew Cooper wrote:
> On 22/04/2022 20:43, Daniel P. Smith wrote:
>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
>> index 0bf63ffa84..e2ebbc7716 100644
>> --- a/xen/xsm/flask/hooks.c
>> +++ b/xen/xsm/flask/hooks.c
>> @@ -120,8 +121,8 @@ static int get_irq_sid(int irq, u32 *sid, struct avc=
_audit_data *ad)
>>          struct irq_desc *desc =3D irq_to_desc(irq);
>>          if ( desc->msi_desc && desc->msi_desc->dev ) {

I've elected to also fix this misplaced brace while committing.

>>              struct pci_dev *dev =3D desc->msi_desc->dev;
>> -            u32 sbdf =3D (dev->seg << 16) | (dev->bus << 8) | dev->devf=
n;
>> -            if (ad) {
>> +            uint32_t sbdf =3D (dev->seg << 16) | (dev->bus << 8) | dev-=
>devfn;
>> +            if ( ad ) {
>=20
> Brace on newline, and in the subsequent hunk.=C2=A0 Can be fixed on commi=
t.
>=20
> Otherwise, LGTM.=C2=A0 Acked-by: Andrew Cooper <andrew.cooper3@citrix.com=
>

Strictly speaking the u32 -> uint32_t conversion was getting us only
half the mileage, but I've committed the change as is (in this regard)
nevertheless. In many of the cases "unsigned int" or alike should be
used instead.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:41:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:41:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313539.531108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGlA-0001Sp-EY; Tue, 26 Apr 2022 08:41:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313539.531108; Tue, 26 Apr 2022 08:41:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGlA-0001Si-Bb; Tue, 26 Apr 2022 08:41:24 +0000
Received: by outflank-mailman (input) for mailman id 313539;
 Tue, 26 Apr 2022 08:41:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=c92l=VE=alien8.de=bp@srs-se1.protection.inumbo.net>)
 id 1njGl6-0001SW-6h
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:41:22 +0000
Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a34bf32c-c53c-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 10:41:17 +0200 (CEST)
Received: from zn.tnic (p5de8eeb4.dip0.t-ipconnect.de [93.232.238.180])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 947631EC04A6;
 Tue, 26 Apr 2022 10:41:12 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a34bf32c-c53c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
	t=1650962472;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
	bh=WDgzj5odytfvHWYC79oVcVHBLZLoY6i/6Y3HutpD6F4=;
	b=RNjGzXao8IjCAZdnyz+sxuWaGQkZ/vd2mBMQcXkorVlHxF8aZwOhjFv4yzyb07IC1cWtdD
	ULYpgmsRwGJlrKq9s0lT+lGWYaOvYXAN7z6VNXS1lWrwLuV/e11t2Bk/YoGWr2WZKy1VVj
	Dqp/f/bCRwbcGI72KlCyWMGc2WUv3AY=
Date: Tue, 26 Apr 2022 10:41:09 +0200
From: Borislav Petkov <bp@alien8.de>
To: Juergen Gross <jgross@suse.com>
Cc: Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Message-ID: <YmewJaxWS1KGVkTf@zn.tnic>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
 <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
 <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com>
 <YmcR5bfaYh1z7VUq@zn.tnic>
 <7d89848a-3a1c-415d-957a-564ffdd3712d@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <7d89848a-3a1c-415d-957a-564ffdd3712d@suse.com>

On Tue, Apr 26, 2022 at 07:16:16AM +0200, Juergen Gross wrote:
> Christoph suggested (rather firmly) this would be the way to go.

Yeah, I saw it but I don't think it is the right way to go.

What happens the next time a guest needs to query the platform
underneath? Misuse these interfaces again?

Because people will see the Xen use and say, hey, look, I will use this
for my funky HV too.

Even worse: what happens if Xen decides to implement SEV/TDX? Then
you're in for a world of fun.

Now, if we want to *extend* the interfaces to have something as generic
as, say, platform_has() and that should be the way for generic kernel
code running in the guest to query the platform capabilities, then sure,
by all means.

> This is needed on guest side at a rather hypervisor independent place.
> 
> So a capability of some sort seems appropriate.
> 
> Another suggestion of mine was to have a callback (or flag) in
> struct x86_hyper_runtime for that purpose.

This becomes an issue if the HV is not x86 - then you need a different
method of querying it, which then underneath will call the arch-specific
interface.

I don't know how much of querying guests need to do and how they've been
doing that so far. Depending on the requirements, we probably should
think about a clean design from the get-go instead of homegrown things.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:49:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:49:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313549.531135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGt5-0002Ka-D0; Tue, 26 Apr 2022 08:49:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313549.531135; Tue, 26 Apr 2022 08:49:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGt5-0002KT-A5; Tue, 26 Apr 2022 08:49:35 +0000
Received: by outflank-mailman (input) for mailman id 313549;
 Tue, 26 Apr 2022 08:49:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cQU5=VE=citrix.com=prvs=10866150f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njGt4-0002KN-7G
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:49:34 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c925ead4-c53d-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 10:49:31 +0200 (CEST)
Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 04:49:27 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN8PR03MB4771.namprd03.prod.outlook.com (2603:10b6:408:99::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 08:49:22 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 08:49:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c925ead4-c53d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650962971;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=qLeY1JKC+QeH8TRDdEaxaq3kp7kqYz4CnmpDSRATwjE=;
  b=IpxKqpCCcPBDPj0ATO1mYQrK3xddnZ3unsObhcTTjNyHM2013PLkNQXL
   qFcw/HO+Qq7TTVwZhV+hHLYMdygnqeuhQX+GIbdxe1V6XlCXrcdaqsf2A
   2djev62wCyVKqynfw2wGLsTQASKm8k7LfbGZXf+3mK6XDR8BB7SwTdbDK
   Q=;
X-IronPort-RemoteIP: 104.47.55.108
X-IronPort-MID: 69807588
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:O0fF3K0KJz0wuhJycfbD5W1wkn2cJEfYwER7XKvMYLTBsI5bp2NTm
 DcfWzuFbK6LYjbwc9Fxbozj8UtT78fWx4dqHgZtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy34Dga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1otr+gYhk2IJeRu8IiS0RbSS91Y/BZreqvzXiX6aR/zmXgWl61m7BLMxtzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfyStbe03x9p7ixKNezZa
 McDLyJmcTzLYgFVO0dRA5U79AutrieuI2UH9QLFzUYxy0iP4CZowZTACsHYQvaEeu9fuBeRm
 0uTqgwVBTlfbrRz0wGt7nupj/TngSD/VYQdBbC8sPVthTW72mUWAQZQUVa9rui0jma/Xc5SL
 wof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xGWwsXjNHLts8u6ceRzMw0
 USSt8j0HjEpu7qQIVqf/LqJqTK5OQAOMHQPIyQDSGMt4cTnoYw1pgLCSJBkCqHdpsbuBTj6z
 jSOrS4/r7Yel8gG0+O851+vqzutvZHISgcd7ATLUm+r4wV1aZTjbIutgXDD9fdaJ4+dR1Ocl
 HIFh8ST4u0IAZyX0ieKRY0lHqyvofCMMzTegFtmN5gn6zmpvXWkeOh44zxgJUEvLscNfxfoZ
 lPevUVa45o7AZexRap+Yob0Dttwy6HlTIzhTqqNNooIZYVtfgia+i0ofVSXw23mjEkrl+c4J
 IufdsGvS30dDMyL0QaLegvU6pdzrghW+I8ZbcqTI8iPuVZGWEOodA==
IronPort-HdrOrdr: A9a23:u36iwK64LE9JJHqMcgPXwUGBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A37wZJPh8sH7eGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heYAotd/lq
 D5259T5cBzp/8tHNxA7dg6MLuK40z2MGTx2TGpUB3a/J9uAQO+l7fHpJMI2cqNRLskiLMPpb
 WpaiIsiYd1QTOiNfGz
X-IronPort-AV: E=Sophos;i="5.90,290,1643691600"; 
   d="scan'208";a="69807588"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J25SFzOfSjaojSf4K+mB+H2Snbdp+BNoGAH8IFWyB0XclLdovbvMJVLegwO4GynG5+GQhsyqhXhTAdNVGZ4vic6iRkjP8sLXx9e5U11TU80yUBIIj1BO7KZ3UlW71JF7tpcvjajy8JojMptA5603HdgVIsf3hQGYLpW5PmQflWZ/+V3tjyaxxegxm0ozJzuwX5o7Wq7j/kGyAr+ePLwTYqtZFtaFs2K4/Z6U7K/zYTkh14UB34HLw2mB1AhwaInDD/MczzA+KzscaE7x6KUWVLQt0ONLTfb8pFu6Gt6ygBVJoUyXASGZT3dsXanYvYOQvDg9r41zITvtxoQ5nrIkfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e4Zdbtn7eCo7nRYWxtLMmkGw8kPz1psaB2Mmh5sT3iU=;
 b=VdTk7+lrkCbbhqO/jYYjPTMljYC/ZDZD0BhzayGz2bDjKRxcsd5sehoW5zfpf+r9uRFTaIiF/eYh0XYLAZ/1SmCSaCImaSVlFN10TKIs/tDmBy1aXsnd1rt6uDktQFt7yxd5rUjyMUk5M3eKKJEh/qDE4YuOP30wjeI4we9t56qPNVwx+3Ca54IWxPhK4YfMXGt+DSaaaBpBGC3y/oJQ2JhrdemkXtVoq9mnmCRY6SDjDU/UdPor3ncXyyCeU5pR354U3qjlq3xn4Jw+5/k74IUxjxZAdqOqt2pfY+uOg3gcc+rjMBpwhWzo1Ixx/FCfA7rTeJ769bEe3W5if9YEmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e4Zdbtn7eCo7nRYWxtLMmkGw8kPz1psaB2Mmh5sT3iU=;
 b=nw6mMQiaZhi5HmWKi7QV2WzGtzLic6H+LtJIJFgo907ARPy9EfxwejvN7BRgmr1sgsw95GOcZ1dfAWCmUODKFgs1zREaAcbj2yp2E320yYCDmg5SaAVSUkUCTEljUix0Xw5XGLYGlyJFwNfpZ5wject+h/9oo/ElRGnZHdl6HHQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 26 Apr 2022 10:49:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v4 2/2] x86/monitor: Add new monitor event to catch all
 vmexits
Message-ID: <YmeyDRYcwfgg7mwC@Air-de-Roger>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
 <YmazAdHL4LWOdDDv@Air-de-Roger>
 <CABfawh=Z1_88p14ivkqrBAUKbfw39f-frXN9uNsdVt9BDp+4bA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABfawh=Z1_88p14ivkqrBAUKbfw39f-frXN9uNsdVt9BDp+4bA@mail.gmail.com>
X-ClientProxiedBy: LO4P123CA0142.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0fb539d3-3eb5-4a29-6c45-08da2761a861
X-MS-TrafficTypeDiagnostic: BN8PR03MB4771:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<BN8PR03MB477135FB073ADD3541EF155B8FFB9@BN8PR03MB4771.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PYEXZWlep5DlCYNHPX/hOVwkF7qyyPuihEW+H8KqXj83ZvAWeP9zewT3CMdrMS9M4+C4OkaQfSQ5WI4pl8JYfDHGIGE6DpxlpOxtWLBK7SzTdcGO90aL4QkqGmEER2d6nL9ssdcAhutRieEgeclMqSiLFoBl2jDM6bLxCr4hhpAsRsyCGwfFUV4aJvB3A3qaEWQ0yJ6/lbWt2fRc4Q5a5a+qRRfbf4rQa4El8cATQf1LOC6dkKbev/acBwVbXT9vF/u/ROK6rhCfrap34D061zCD0LM0DQQWzSZ7coP4MhAzfpWQtVo9ZFZg9IDPreT+y9FzI8pUXGRU/Ihu4qfiNZMgxEuFkg+QK1MGXq+nbh9aFrn+ApM9k7lN2tqjkBq0YUaj46gzRTS1dlH8FxxzFpnEp4GcNqk2wrAJ7fzfrgUi1qfRJuLpBu92/F6stWA8netpk9vkYU5enXasLSs35CKccww02MGqMh416XqT5zWN/o9eRI7n9Fb7x4lcbX64Plpucx9tp4z9kZB32MpaZBVZo55t/3MoL82bRKiuLjCiisIybkRRp7st/HWQ1wyyBDe3UPLPcjqJZYdZngRW+ehzdGcIk57bZgOgl/QUg6f1SBCl8PMe+100LGciEuzMlkB/+Z5x92sOVHQxaWUKTYW1bAXyD+oZgTiiGN7jwAnQ+ECiOp5EYxJD9DoLS7zA/9ZzzVMQQr3dmokeWiykEA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(5660300002)(2906002)(53546011)(6506007)(33716001)(8936002)(186003)(30864003)(85182001)(9686003)(26005)(6512007)(7416002)(83380400001)(6666004)(4326008)(508600001)(316002)(6486002)(54906003)(6916009)(38100700002)(66946007)(8676002)(66556008)(66476007)(86362001)(82960400001)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cmk2Qmhmc0NVTGRnWmRkbjV2RnZnZ1lVcHlFQzVXa0diUzZEcWYwd0tucHJR?=
 =?utf-8?B?clkxVWNRZGw1amZ2TE52Q3UxSy9pNHFPN0x0ZkVuUkx3RDQzU3kwNncwbWpX?=
 =?utf-8?B?RlFTTnRxQ3JPSi9jRUhTU2RtSlZCVHM5eVlnSnRmV2xPc3pRUUZHSUJkRzg3?=
 =?utf-8?B?SzhyS2k5RWg2QlRSNE4xTVAvT3hhUEI3bHVIMGgwbnMyei92M2VHclV0WVFV?=
 =?utf-8?B?LzBIY0NlU05xcDRMZERLSUltU1dZYllKQUpvTVlLTDVqbjQzYVZxWE1jZCs3?=
 =?utf-8?B?NStYMWNxVFdrcUtWWktkMzJQUC9ncUZCT0krQ1JSdTUzRE92YWhXRTNFdUpq?=
 =?utf-8?B?dXIrdWxwamNaQ2RPZnlXb0pSTkY3L1FWTXo5ZStJWm55VS95Z2xBQVdHK0FM?=
 =?utf-8?B?dTd1WTBybUpMUEJTSEFrWm8yUWFOKzB1LzNkcTlMaVFaZ1htalJSUkU4RFFH?=
 =?utf-8?B?YURMSmNoUHIrNkFHaUplN2J6TGJka2RxWTJmMElmK3VVS1Ribktwc0RmNnBl?=
 =?utf-8?B?S2pwUjJzaUZyL2R0NnBrSzlncytaZFlwRUp5T1VVaXpDeHNYSkdyNWhxT01W?=
 =?utf-8?B?VDg0TTJrdWxrb1NYcHdwZ1ZLQ2lES3ZrSDRPRmZGRTVzdVBLK3dSeWx4VzFs?=
 =?utf-8?B?S0VZS3FGcEozVFJaMXJKVWVkelVUN0l6Q3JTc0doTDdtMHBaZkpnRTRrc2pw?=
 =?utf-8?B?endPVjcwVFdUSW93MHcxeHJmbHNlNDRKNXhSV2xMUzB5WDBSdXI4ZHlUTDlZ?=
 =?utf-8?B?QmtpNXUyVnA5UVRjbERRQUpyVFZRQmlIWStBWTZYUXljMnVaOE5lSEE4WXla?=
 =?utf-8?B?VzV6aUVvdzlvUlg2SlN6UUJMMnI1OS9keEQrTEFQK2UrQ3dXd1dBQkt3ckF5?=
 =?utf-8?B?OTNNVnpWbXRhZEt3R0JJRmtJdkJWVjUxbjVDZi9NODg1cU1aWVF3M1JBYSs2?=
 =?utf-8?B?UlRhTE9RMWRQWnhpeVVxN2pwQ1BnWWdsUU9vVVlaNnFUaWlGWHhOc0MvckpU?=
 =?utf-8?B?Z1ZaM2FTUFFLZW54enlBMWpvUWVlWlpwdm1kZitjdnh2b1FNaE5iaEVWOUl6?=
 =?utf-8?B?TytJN0JTZUJ0Q28xQVpvcy90WHpaMnJ3UVZOdnNoZWkybjJPTm9RN0FyMG9B?=
 =?utf-8?B?aUdkYWI4T2dtMjY0ZU5CcTMvVnprcTVlMFlaeVpkM0p0bDFLa0lLQXA4aDVw?=
 =?utf-8?B?MzAzTGtWYXVBUGtQbE1GdmhlMS9NdmlnTmZjNDk2MlhHRThUYjJJcW1aOVFy?=
 =?utf-8?B?Tyt4UWJGS2VTU2Q3c3pEaTRmNzR1SGMweWFKRGR1Ui9RNXFKL0U1UWw3WVhJ?=
 =?utf-8?B?TkNCUUQ5ZVB6Umhud1duU2V6ckRpMm01c1E2MWpHMy9TZmMwNHErNFNzUjdI?=
 =?utf-8?B?WHVWYytINnhVTDBCTVNxTHQzZ3Q0MllMUzhwbVdZVzg1YjhXNlBuN2hWV204?=
 =?utf-8?B?Z2pObTFjMmxHUHNoTjIzaWFFN2ZZa054WkdqbXFCYVUzUXprdE5yMG55VHU5?=
 =?utf-8?B?ZDNqRmxKNzhwOUVvdC9ld0tuQmM4T0VhNXNwcnZIVEV0TUJDUHNrYTRJbldU?=
 =?utf-8?B?OE0yVzdnS290TlRkNmozS2NGZldJMnAwNjZtejFwM1J4M3RXalNlN0xmSjFM?=
 =?utf-8?B?eWtvSlFLRjdhVmcvL1hxZ0J3d2djck5WOTN3dzd5OUJ1aVNVaG9kRmZTeld5?=
 =?utf-8?B?eXhJUEVvRnFxS2V0V2d6N2VjSWs4b0p6VXF1YVcrQUd5VWVXcGdGOFFJZmhB?=
 =?utf-8?B?NGE5WEMzZFhJVE0xblNvOFlhaFQ1YU4yZHlxN2pqQXBpbXRoN05TcFhOaGF6?=
 =?utf-8?B?eW1JSVQrNXN5NmtLZ2kybzM4SjZpVmpoWWloOSs0ZkVROXlkU3F6YkxqblZK?=
 =?utf-8?B?anlLeThWbldpbGhQNFY2aGlUWFdaZXpqbmF6LzE4MHVhcnRkek5XNGF4M3Zh?=
 =?utf-8?B?TjJOT1haZHBxb1NMVnBPUXlJT2hadnQydlMxUzZId3FQRldTY3BLbGRDRUhD?=
 =?utf-8?B?MjIwNzF6MVBDVDlqK1FSSGEzZnRRMkx3dHZmczVPb2l6aUxOa3hUaUI2a2FB?=
 =?utf-8?B?VVhiNWxQa0JTSm96SW5KUnptRE5LcXZVeVg3aFhtcGxncHdKaGpHR1RBNk5D?=
 =?utf-8?B?Wi9CSjJKdDFUVnZPQVlWSk9BU2JocDVNTjNTV3o0c2g0dFR0Nng5ZEpmcUJU?=
 =?utf-8?B?ZXFPYzh4YUpYeVpmbU11dXlQMjlkRElleFZsZTlFamxUSWRuc3pYdmNGeEQ4?=
 =?utf-8?B?Y0NyMFkwbDY5NVk4SjgxVXQrSTZCOGZCTnA0TVNVWnBaakROS3Z0aVNJUmk1?=
 =?utf-8?B?OGJ6aE9ZOENjbzNTb2RlYndHazV5a05BNUZxaHFoQ083bjF2cGlaRkhFY1J2?=
 =?utf-8?Q?2GBaEkg2txBR3+i4=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb539d3-3eb5-4a29-6c45-08da2761a861
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 08:49:21.8176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uwn3t+HDul3wWjNIs4Ks9lLZqyEkNlqERsv6ShAK6pY8PoJcA1Zjea9hsqckAbH89Fgh/sJ8lBHMBSrXUz89uA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4771

On Mon, Apr 25, 2022 at 11:40:11AM -0400, Tamas K Lengyel wrote:
> On Mon, Apr 25, 2022 at 10:41 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
> >
> > On Wed, Apr 13, 2022 at 09:41:52AM -0400, Tamas K Lengyel wrote:
> > > Add monitor event that hooks the vmexit handler allowing for both sync and
> > > async monitoring of events. With async monitoring an event is placed on the
> > > monitor ring for each exit and the rest of the vmexit handler resumes normally.
> > > If there are additional monitor events configured those will also place their
> > > respective events on the monitor ring.
> > >
> > > With the sync version an event is placed on the monitor ring but the handler
> > > does not get resumed, thus the sync version is only useful when the VM is not
> > > expected to resume normally after the vmexit. Our use-case is primarily with
> > > the sync version with VM forks where the fork gets reset after sync vmexit
> > > event, thus the rest of the vmexit handler can be safely skipped. This is
> > > very useful when we want to avoid Xen crashing the VM under any circumstance,
> > > for example during fuzzing. Collecting all vmexit information regardless of
> > > the root cause makes it easier to reason about the state of the VM on the
> > > monitor side, hence we opt to receive all events, even for external interrupt
> > > and NMI exits and let the monitor agent decide how to proceed.
> > >
> > > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> > > ---
> > > v4: Minor tweaks and more verbose patch description.
> > >
> > > Note: making the sync version resume-friendly is specifically out-of-scope as
> > > it would require significant rearrangement of the vmexit handler. As this
> > > feature is not required for our use-case we opt for the version that minimizes
> > > impact on the existing code.
> > > ---
> > >  tools/include/xenctrl.h                |  2 ++
> > >  tools/libs/ctrl/xc_monitor.c           | 15 +++++++++++++++
> > >  xen/arch/x86/hvm/monitor.c             | 18 ++++++++++++++++++
> > >  xen/arch/x86/hvm/vmx/vmx.c             | 12 ++++++++++++
> > >  xen/arch/x86/include/asm/domain.h      |  2 ++
> > >  xen/arch/x86/include/asm/hvm/monitor.h |  2 ++
> > >  xen/arch/x86/include/asm/monitor.h     |  3 ++-
> > >  xen/arch/x86/monitor.c                 | 14 ++++++++++++++
> > >  xen/include/public/domctl.h            |  6 ++++++
> > >  xen/include/public/vm_event.h          |  8 ++++++++
> > >  10 files changed, 81 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> > > index 1b089a2c02..159eaac050 100644
> > > --- a/tools/include/xenctrl.h
> > > +++ b/tools/include/xenctrl.h
> > > @@ -2096,6 +2096,8 @@ int xc_monitor_privileged_call(xc_interface *xch, uint32_t domain_id,
> > >                                 bool enable);
> > >  int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
> > >                                    bool enable);
> > > +int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
> > > +                      bool sync);
> > >  /**
> > >   * This function enables / disables emulation for each REP for a
> > >   * REP-compatible instruction.
> > > diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.c
> > > index 4ac823e775..c5fa62ff30 100644
> > > --- a/tools/libs/ctrl/xc_monitor.c
> > > +++ b/tools/libs/ctrl/xc_monitor.c
> > > @@ -246,6 +246,21 @@ int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
> > >      return do_domctl(xch, &domctl);
> > >  }
> > >
> > > +int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
> > > +                      bool sync)
> > > +{
> > > +    DECLARE_DOMCTL;
> > > +
> > > +    domctl.cmd = XEN_DOMCTL_monitor_op;
> > > +    domctl.domain = domain_id;
> > > +    domctl.u.monitor_op.op = enable ? XEN_DOMCTL_MONITOR_OP_ENABLE
> > > +                                    : XEN_DOMCTL_MONITOR_OP_DISABLE;
> > > +    domctl.u.monitor_op.event = XEN_DOMCTL_MONITOR_EVENT_VMEXIT;
> > > +    domctl.u.monitor_op.u.vmexit.sync = sync;
> > > +
> > > +    return do_domctl(xch, &domctl);
> > > +}
> > > +
> > >  /*
> > >   * Local variables:
> > >   * mode: C
> > > diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
> > > index b44a1e1dfe..64a38e8fa7 100644
> > > --- a/xen/arch/x86/hvm/monitor.c
> > > +++ b/xen/arch/x86/hvm/monitor.c
> > > @@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
> > >      return monitor_traps(curr, true, &req) >= 0;
> > >  }
> > >
> > > +int hvm_monitor_vmexit(unsigned long exit_reason,
> > > +                       unsigned long exit_qualification)
> >
> > Should this maybe live in vmx code or have 'vmx' in the name
> > somewhere, so that if an svm counterpart is added this doesn't need to
> > be renamed?
> 
> I don't follow. Why would this need to be renamed? I would presume the
> same function would be used on both if it comes to that, perhaps with
> a unified input structure if the two are not compatible as-is. In any
> case, there is no vm_event/monitor support for AMD at all (not just
> for this particular event type) and no plans on adding it any time
> soon so IMHO we should cross that bridge when and if that becomes
> necessary.

SVM has at least 3 fields related to vmexit information AFAICT:
exitcode, exitinfo1 and exitinfo2.

Instead of having an union in hvm_monitor_vmexit to cover all possible
vendor formats it might be easier to just have vmx_ and svm_ specific
functions, so it's contained in vendor specific code.

Or maybe that would be worse because you would have to expose a lot of
vm_event logic to vendor specific code in order to put the request on
the ring?

> >
> > > +{
> > > +    struct vcpu *curr = current;
> > > +    struct arch_domain *ad = &curr->domain->arch;
> > > +    vm_event_request_t req = {};
> > > +
> > > +    ASSERT(ad->monitor.vmexit_enabled);
> > > +
> > > +    req.reason = VM_EVENT_REASON_VMEXIT;
> > > +    req.u.vmexit.reason = exit_reason;
> > > +    req.u.vmexit.qualification = exit_qualification;
> >
> > You could set those fields at definition.
> 
> Sure, but this is the established style throughout the file.
> 
> > > +
> > > +    set_npt_base(curr, &req);
> > > +
> > > +    return monitor_traps(curr, ad->monitor.vmexit_sync, &req);
> > > +}
> > > +
> > >  /*
> > >   * Local variables:
> > >   * mode: C
> > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> > > index c075370f64..2794db46f9 100644
> > > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > > @@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
> > >          }
> > >      }
> > >
> > > +    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
> > > +    {
> > > +        int rc;
> > > +
> > > +        __vmread(EXIT_QUALIFICATION, &exit_qualification);
> > > +        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
> > > +        if ( rc < 0 )
> > > +            goto exit_and_crash;
> > > +        if ( rc )
> > > +            return;
> > > +    }
> >
> > Just for my understanding, is there any reason to not do this before
> > updating the altp2m?  AFAICT the update of the active EPTP won't
> > affect the call to hvm_monitor_vmexit.
> 
> The currently active altp2m information is included in the vm_event
> that will be sent out, so it is good to have the correct info for it.
> I don't currently plan on using altp2m with this particular even type
> but we should make sure it doesn't send out stale info in case someone
> wants to use it differently. Certainly no point in sending the event
> before it as the exit condition in the altp2m update blob is really
> just dead code and can't actually be reached.

Ack, thanks for the explanation.

> >
> > > +
> > >      /* XXX: This looks ugly, but we need a mechanism to ensure
> > >       * any pending vmresume has really happened
> > >       */
> > > diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
> > > index e62e109598..855db352c0 100644
> > > --- a/xen/arch/x86/include/asm/domain.h
> > > +++ b/xen/arch/x86/include/asm/domain.h
> > > @@ -430,6 +430,8 @@ struct arch_domain
> > >           */
> > >          unsigned int inguest_pagefault_disabled                            : 1;
> > >          unsigned int control_register_values                               : 1;
> > > +        unsigned int vmexit_enabled                                        : 1;
> > > +        unsigned int vmexit_sync                                           : 1;
> > >          struct monitor_msr_bitmap *msr_bitmap;
> > >          uint64_t write_ctrlreg_mask[4];
> > >      } monitor;
> > > diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h
> > > index a75cd8545c..639f6dfa37 100644
> > > --- a/xen/arch/x86/include/asm/hvm/monitor.h
> > > +++ b/xen/arch/x86/include/asm/hvm/monitor.h
> > > @@ -51,6 +51,8 @@ bool hvm_monitor_emul_unimplemented(void);
> > >
> > >  bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
> > >                             uint16_t kind);
> > > +int hvm_monitor_vmexit(unsigned long exit_reason,
> > > +                       unsigned long exit_qualification);
> > >
> > >  #endif /* __ASM_X86_HVM_MONITOR_H__ */
> > >
> > > diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/asm/monitor.h
> > > index 01c6d63bb9..d8d54c5f23 100644
> > > --- a/xen/arch/x86/include/asm/monitor.h
> > > +++ b/xen/arch/x86/include/asm/monitor.h
> > > @@ -89,7 +89,8 @@ static inline uint32_t arch_monitor_get_capabilities(struct domain *d)
> > >                      (1U << XEN_DOMCTL_MONITOR_EVENT_DEBUG_EXCEPTION) |
> > >                      (1U << XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG) |
> > >                      (1U << XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED) |
> > > -                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT));
> > > +                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT) |
> > > +                    (1U << XEN_DOMCTL_MONITOR_EVENT_VMEXIT));
> > >
> > >      if ( hvm_is_singlestep_supported() )
> > >          capabilities |= (1U << XEN_DOMCTL_MONITOR_EVENT_SINGLESTEP);
> > > diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
> > > index 3079726a8b..30ca71432c 100644
> > > --- a/xen/arch/x86/monitor.c
> > > +++ b/xen/arch/x86/monitor.c
> > > @@ -332,6 +332,20 @@ int arch_monitor_domctl_event(struct domain *d,
> > >          break;
> > >      }
> > >
> > > +    case XEN_DOMCTL_MONITOR_EVENT_VMEXIT:
> > > +    {
> > > +        bool old_status = ad->monitor.vmexit_enabled;
> > > +
> > > +        if ( unlikely(old_status == requested_status) )
> > > +            return -EEXIST;
> >
> > What about if the requested status is the same as the current one, but
> > vmexit sync is not?
> 
> You need to clear the currently registered event first, then register
> the new one.
> 
> > IOW, I'm not sure this check is helpful, and you could likely avoid
> > the old_status local variable.
> 
> It is helpful on the callee side. Usually the callee needs to keep
> track of the state of what events are enabled so that it can clean up
> after itself and if it ever runs into trying to set the event to
> something it's already set to then that indicates its state being
> out-of-sync.

Hm, right.  I wonder if you should also check that the ring is empty
before changing the status?  So that the callee doesn't change the
status while requests are still pending on the ring from the previous
type?

> >
> > > +
> > > +        domain_pause(d);
> > > +        ad->monitor.vmexit_enabled = requested_status;
> > > +        ad->monitor.vmexit_sync = mop->u.vmexit.sync;
> > > +        domain_unpause(d);
> > > +        break;
> > > +    }
> > > +
> > >      default:
> > >          /*
> > >           * Should not be reached unless arch_monitor_get_capabilities() is
> > > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> > > index b85e6170b0..4803ed7afc 100644
> > > --- a/xen/include/public/domctl.h
> > > +++ b/xen/include/public/domctl.h
> > > @@ -1057,6 +1057,7 @@ struct xen_domctl_psr_cmt_op {
> > >  #define XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED    10
> > >  /* Enabled by default */
> > >  #define XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT     11
> > > +#define XEN_DOMCTL_MONITOR_EVENT_VMEXIT                12
> > >
> > >  struct xen_domctl_monitor_op {
> > >      uint32_t op; /* XEN_DOMCTL_MONITOR_OP_* */
> > > @@ -1107,6 +1108,11 @@ struct xen_domctl_monitor_op {
> > >              /* Pause vCPU until response */
> > >              uint8_t sync;
> > >          } debug_exception;
> > > +
> > > +        struct {
> > > +            /* Send event and don't process vmexit */
> > > +            uint8_t sync;
> > > +        } vmexit;
> > >      } u;
> > >  };
> > >
> > > diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
> > > index 81c2ee28cc..07f106f811 100644
> > > --- a/xen/include/public/vm_event.h
> > > +++ b/xen/include/public/vm_event.h
> > > @@ -175,6 +175,8 @@
> > >  #define VM_EVENT_REASON_DESCRIPTOR_ACCESS       13
> > >  /* Current instruction is not implemented by the emulator */
> > >  #define VM_EVENT_REASON_EMUL_UNIMPLEMENTED      14
> > > +/* VMEXIT */
> > > +#define VM_EVENT_REASON_VMEXIT                  15
> > >
> > >  /* Supported values for the vm_event_write_ctrlreg index. */
> > >  #define VM_EVENT_X86_CR0    0
> > > @@ -394,6 +396,11 @@ struct vm_event_emul_insn_data {
> > >      uint8_t data[16]; /* Has to be completely filled */
> > >  };
> > >
> > > +struct vm_event_vmexit {
> > > +    uint64_t reason;
> > > +    uint64_t qualification;
> > > +};
> >
> > You are exposing an Intel specific interface publicly here.  Might be
> > worth adding a note, and/or adding 'intel' or 'vmx' in the structure
> > name: vm_event_vmx_exit, so that a vm_event_svm_exit could also be
> > added in the future.
> 
> All vm_event monitor events are for vmx only right now. We can
> certainly do that abstraction if and when someone decides to add svm
> support, the ABI is versioned and no structure here is set in stone.
> No guarantees are even implied for the structures to remain the same
> in any way between one version of the ABI to the next. So with that I
> don't see the need for complicating the structures at this time.

Well, it's just altering the name slightly, but the structure layout
would be the same.  Just so that someone wanting to add SVM support
doesn't have to go and rename the VMX specific structures.  I think it
also makes it easier to identify what's vendor specific and what
should be shared between vendors.

I don't think it adds any complications to the code you are adding,
but would make it easier for someone wanting to add a new vendor
support in the future.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:52:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:52:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313556.531147 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGvS-0003m7-V5; Tue, 26 Apr 2022 08:52:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313556.531147; Tue, 26 Apr 2022 08:52:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGvS-0003m0-Rs; Tue, 26 Apr 2022 08:52:02 +0000
Received: by outflank-mailman (input) for mailman id 313556;
 Tue, 26 Apr 2022 08:52:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njGvR-0003lg-V1; Tue, 26 Apr 2022 08:52:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njGvR-0008Tb-Kn; Tue, 26 Apr 2022 08:52:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njGvR-0007XD-Ai; Tue, 26 Apr 2022 08:52:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njGvR-0004lu-AF; Tue, 26 Apr 2022 08:52:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WTTayxdF9hYf8jIWNMGdNbjPoJNk67lUBgTJ0EwuwcQ=; b=n9+Mb+go2pnWiMfyZplaELnwrM
	nBVjjBaOal9BKPxjbhcwJ3LV1Ju7suvfVYWH6dUqL0FLvB0fzNYHjr8/VX/O2o+MoRBbotNNZBdl3
	tF3Suuh/qAKE8MLX8lQO6xqcPpOI0328GC1U+kTiWi67bBOGYQ+dAcycb8Tkrd6WTI+4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169728-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169728: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 08:52:01 +0000

flight 169728 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169728/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  635 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 08:54:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 08:54:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313565.531158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGxQ-0004OS-D7; Tue, 26 Apr 2022 08:54:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313565.531158; Tue, 26 Apr 2022 08:54:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njGxQ-0004OL-9h; Tue, 26 Apr 2022 08:54:04 +0000
Received: by outflank-mailman (input) for mailman id 313565;
 Tue, 26 Apr 2022 08:54:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njGxO-0004OB-QR
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 08:54:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6ad862c5-c53e-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 10:54:01 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2052.outbound.protection.outlook.com [104.47.8.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-ucKoAe8RO7KpfGUQJAcsSQ-1; Tue, 26 Apr 2022 10:53:57 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM7PR04MB7127.eurprd04.prod.outlook.com (2603:10a6:20b:113::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 08:53:56 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 08:53:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ad862c5-c53e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650963241;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mQoK8qMH+pmcRX0aCwjGFUHjI0xneEzZZ2wQfZ8XyL8=;
	b=QeJblDmIbL2nhTCQoQuT+VHkyicbAODsEshiNMoWpflj86U94dknXaocDjwph/fwDhNQbk
	/cowzHMLBeNXVHijBRfMA/koel5G7yC2fyGM/kiygqteAbMghoZ1r1PQCoLWsgJWF/PVwz
	uz3eaduFhA1LkYWGx8hwRIn1e7yCJKY=
X-MC-Unique: ucKoAe8RO7KpfGUQJAcsSQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C8QUhMGQKATdgz7yWpH5NlZZbnsOhBQqsU2qhsoAcAy6MmU80U3pYtqn1UU0cnPttmopBF2PZXlnyunuqqRQ7Nk0iYM+tYc/bVZdiWTSxMLdNKOnL4q+xr+abvP67dY8OQZ9MH7ATtUC6hbSieGvR5+C3gUR0LmZeIFYqxRebgGARVpMYRtv/XR+gUoCSuL1JbilwqXEdu/XAmBbaH3JjfXrrh02ILn3V9JMZhxTb2psqae2wL13elgRUqKjlnByb+KQn36U8RWGpGsG++doOSugVCJmNY4Ja4KQX2Rq84Q2CGpW8YJxz4Ptmuugk15sta4gsmNCdLdoDAhjiWSG2g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mQoK8qMH+pmcRX0aCwjGFUHjI0xneEzZZ2wQfZ8XyL8=;
 b=D+dZOKM3XbywCz2DIH7bclVJxEJQ3/PJwUXCChetyGqSM01FmPT/va9W8+QCCZNhl2YkzuUPGsWtOkUjkLknlqdwlK9oE2N0qX9Ccwcnv4X/jB80WyJ8Hh1LMVpVtolioXc1O9vuCDY+2Nm3JQvZkUHyUwBUCvzMBN5PI9/1QdLgKcRr6U1D5Q2itLfagChoT1HG1ZxEx3/+H7Ughx4S7bSHMak1fULsRl3OULgU34V4EQvnyR6efhfmjBlGMVN6jD2e1hX33z5Hq7u/1+cCol5K3OFUUmQ7GZeFmqD2cZOf6kLe9rDL/jAqMf21DgDx1q4q/Kv3dUGW5nHzSeyxCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3e5b9708-7732-a56c-f2e8-d5d39fd2093e@suse.com>
Date: Tue, 26 Apr 2022 10:53:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from
 x86 to common
Content-Language: en-US
To: Wei Chen <wei.chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-3-wei.chen@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418090735.3940393-3-wei.chen@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0246.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::12) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5bc78357-a958-4262-0a67-08da27624c20
X-MS-TrafficTypeDiagnostic: AM7PR04MB7127:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB71270D14AA9836268DBEB342B3FB9@AM7PR04MB7127.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3swJVC4BBANn1YrsbHulGAyGPGSGEkPViS27bQ0XHEs1mbMtCsu0SbAX3aVkPbgTJ0eHesvA3K5iHUyNR3I9rKhkfbpJKL7FE9L6/A6ETt0/03y8zWbjS++OzPOo/ME3wZfAQ54w8PJrNAARqY3in/dxPuvzoaRBL5HabP+iF8UU7JibZsrsxD+1KkSU0KQOh9JDtvj/0f83uqveNyW1ytNoizHiT5eaUckHLa3tBdiI/qVR/++e2/j2U36NjzUIu3PEq7DLKAKxoxG8J6t9krKHCs2Gsx3NF7gZ3ZQri2Ue4oTxDCFtOHVbAzPcApb14FS2yBIbeXHK6qA9gDQgNRrFFtk75AsvpOF67e47zY36PN89n/H0QQQSeReu5xwduocrgHxNuLSBMO9nMOxirR1s7z9fhP/ad+3x7Kl8DBeq70Ml+x/B2KLU6q0A3YJPFH+aD2OV+PcFVU/hCzeptwBXjEmT3QPr61FkK6O48X58E+1AXe1M/lhtT+J6JmI7oQZBtVOzGdRTOkGAxEd9G3ak9MkO35u/wJSsziVLtvzo61WW9/g0gP63i1BHhFpLmGIHr8OYfE/9g07nte75YjM5fHpeZjcrrylh4O1aJwHb1PWswtvKRkXhCdrlN9PAUcZksEcHlS56up1B245bfFX9OMGjAxC+8T6q/doukYFzY3PIru9sKLvRaF/RmygRrRcMXQS1RHisI8FBkfckiUyFVjr6GXEZ4mdhRIU0j/ldNS0Y6X8KDUnZlghpo/ev
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(8676002)(66556008)(31696002)(86362001)(66946007)(54906003)(2906002)(53546011)(5660300002)(38100700002)(186003)(316002)(2616005)(6916009)(8936002)(4326008)(31686004)(36756003)(6506007)(508600001)(6486002)(6512007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFE4ZS8yWlZQK0haWEJsOHVpMGRzQ3JHd2hLZzJ2SGJ2Y3lyaU5DMEtsb2NK?=
 =?utf-8?B?YllaYXlIUEEzVUc3NFQwbUxiZUE2SHRrRVlaOEFJSTdCWTEwczJMblJWMFVG?=
 =?utf-8?B?Y2xUaE9WSEdEMVJ2Wll0d1FXV2xlVGsvQWNmNnp4STJWNjJweFRyS2lYZUpV?=
 =?utf-8?B?MGUxNDJCMnZHM2U5YjJzeG5ETVQ4SmVCU2JoK296VElKMHVzcWhlWThSandz?=
 =?utf-8?B?dWxuWHRqSXhsc2JJTlRxZVAxY3d5Y2pjeUJrQ2c5THE3VE9qaU9mMDIrWHhX?=
 =?utf-8?B?aFhJZW9OMzhtY0FnKzZHUkpTdkhxdTVmZmVNaUtkczd0L0NkWVk0Z1ZQL3FK?=
 =?utf-8?B?S1NVb0tYWDBNbjFMNTRjN2V1UXczdjVrRnVzeDFES093bnRlaTNKcTIvMnlu?=
 =?utf-8?B?K2lvMGdwUXUrVGlYY1AzcG84S0ZmMzhFWGR5VVREblpQbU95azl6ZWdPWkk3?=
 =?utf-8?B?YWJlaWoxUW1jVXZoaXoraFYrUExCVlZaR2FER3lvcWcycEtnMGh0Z2xKUnhi?=
 =?utf-8?B?eU9wd3RMMXJWRGpoaU1XVmJTUFlaM1kxSDZLZWJSSmY5ckJLYmNzaTNBcmYw?=
 =?utf-8?B?YmU5TGZ4dUVOZzQ1VWtXN3RtK1lMOG9FZW90bWNybW95QUNSdzFyUjBJT3FQ?=
 =?utf-8?B?QUg0MUdORlBVSVZRZ2pCVXFwM1lnRS94M1N6bHQ0eXViVWMrSk9KNjhneFZT?=
 =?utf-8?B?WlFTdGVCS2l1SGVLcHFDd1JORk1wODlZUHM2Y1o1Z2J6cjFiOWZaUzAwend5?=
 =?utf-8?B?MVFhc2ZJaG9JWFJKSWdVYlozeXBQQitDMlNpK01uQjJQT2lNMzZsMWRNOUtq?=
 =?utf-8?B?T1NTZUZYdHE1ZTYzQ0RXZEQxTUo2bzVDdkpDR2RzcFFwTnRsZjFVaUovVFZz?=
 =?utf-8?B?b3psK004Y29lb1ZOaXpSNzZHakFNN3JiV2VBNnN0VFdWdlRoZkg0RkJXWDIy?=
 =?utf-8?B?dUtZYTRCSmJvblVja3hHbis0Q2w2QXlsOWxsWDU2bHBNMFRiK2xoRWc3Z2ZV?=
 =?utf-8?B?SlNybGxXTVZOdG1NYkxLVDdPblZzSFhFRSs0NytEZWFORjVLWEZDNmpCRVJ0?=
 =?utf-8?B?OWcwV0toL1FsZzRHRVZQd2h2TTFmKzkyYUNhcGRNell5U2xrS3EvbFJBUjJZ?=
 =?utf-8?B?b05Zd3IwcDBXQ0R3WEgyU1FPTzFIQ2JncFhJdkF0UGRlMHZmeTBNZWUrY3NM?=
 =?utf-8?B?V0VtUkNrTWpiaEtWRDk2cHozUGo3NFhDT3d3UmJSYnlyV1JyZm5KU0NVVGNy?=
 =?utf-8?B?QklHQXR3ekJaSU1KRlpQZExRd2NXOVQ0YWplb3grWTIwSDFBUkZtNlg4N1g4?=
 =?utf-8?B?YW44Rk1ZTzNtckVEakliWnhiZ3krMGk0U3AzdDZaOXF3aVR1bmpnSVFjYWsy?=
 =?utf-8?B?UVl3Z1NIclE4WU1SdnNIeU9OOUZOYkE0amZUVk45eSs3V1dPQ2Fkc3JyUWpq?=
 =?utf-8?B?a1I1U1JXRVJqWUQ1VkYraThmblNKZ3hBc1A0SE5RQ01pYW90YWZmSjdSdkZG?=
 =?utf-8?B?dXR4clFkbkxJckdWR1JuTFp0WndhUnozaEk2VlFTWDRFVkN4QVZ1ZXZuaTJh?=
 =?utf-8?B?czRUYjAwY3hZTHU4RGxGck9kditoS3U3My9jU0lLZHhCQjBiY1dsR3p1TTRD?=
 =?utf-8?B?STZpL3IxL1JrQ2lnUEkzb2NEQUtaZ2dWTkw4YXVuMEwyTW83bDEvUVdZT0wv?=
 =?utf-8?B?b0xLVFpjY2RuczdFTFZnV3JGSUVCZzhnVCt3cU42Y1laZ0lHdnIwOFUxWXFo?=
 =?utf-8?B?dlBRdyt3RlJHL2xVR1gvYktyVHAvS3JKcnRkaE9iampxZm9TMGdiMG52UDNI?=
 =?utf-8?B?aGFwdlhVaGV0L1JQbVE1TDZRRTZuWjJHUkNZa1I3NkxLSThFUDZNM29vRm85?=
 =?utf-8?B?VDZUamp3eldnL0ZHRm1WeXVuZ0c4NEs2ZlI5azBDL0QrNzlrOWthK3M3RHJq?=
 =?utf-8?B?Zm5nSGJqUTcyT0ZnS1JzalZIa0E0UElzc2JqNkxocUtkZ2xBN3FZSmpkNjUy?=
 =?utf-8?B?ZnBja1pocDEvM2l0WHc1cWNZQWI3U2dwMFpRZFBhRStaM1JVZXUyNzN0b3M2?=
 =?utf-8?B?dXJYcWhrRFIzNi91eXh3S3BTbHVMOHlTU2NRejR3T0t6TUc5QTNsYWVnZHMy?=
 =?utf-8?B?L1VhMndwTDBMYkxkSnBJNVh1UmdrekpKdzZFaXVVZ1lMd0d1cVg5NzVaZzlo?=
 =?utf-8?B?K0J6MkkzS2Z3K2tZNndieGtWTUxXbVVOaG1Lc1duaDZKLzdRMHlPbmdNaGtF?=
 =?utf-8?B?Uk9QMUJkRUE5QkxkdkJXZHJVSDc4azhEWDlGRXdVZ2JjM2IxOHpZTm5nK21C?=
 =?utf-8?B?ZmplRitWVUd5My9pU0I0OWJUb3dUenAwMXJDVS9NaUNjRmNXQW9Zdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bc78357-a958-4262-0a67-08da27624c20
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 08:53:56.4574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fAqFBU7dUXTtfeAUaxtzEbpdhmt9qigoV0Y31H3/QWGrcIriZwQ7juRuWqqOEKL0OxJY2yYg6lsDsqWsJY3kYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7127

On 18.04.2022 11:07, Wei Chen wrote:
> diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub-x86.c
> similarity index 71%
> rename from xen/arch/x86/efi/stub.c
> rename to xen/arch/x86/efi/stub-x86.c
> index 9984932626..2cd5c8d4dc 100644
> --- a/xen/arch/x86/efi/stub.c
> +++ b/xen/arch/x86/efi/stub-x86.c

I'm not happy to see a file named *x86*.[ch] under x86/. I think the
x86 file wants to simply include the common one (and the symlinking
be suppressed when a real file already exists). Naming the common
file stub-common.c wouldn't help, as a similar anomaly would result.

> --- /dev/null
> +++ b/xen/common/efi/stub.c
> @@ -0,0 +1,38 @@
> +#include <xen/efi.h>
> +#include <xen/errno.h>
> +#include <xen/lib.h>
> +
> +bool efi_enabled(unsigned int feature)
> +{
> +    return false;
> +}
> +
> +bool efi_rs_using_pgtables(void)
> +{
> +    return false;
> +}
> +
> +unsigned long efi_get_time(void)
> +{
> +    BUG();
> +    return 0;
> +}
> +
> +void efi_halt_system(void) { }
> +void efi_reset_system(bool warm) { }
> +
> +int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
> +{
> +    return -ENOSYS;
> +}
> +
> +int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *)
> +    __attribute__((__alias__("efi_get_info")));

I doubt you need this outside of x86.

> +int efi_runtime_call(struct xenpf_efi_runtime_call *op)
> +{
> +    return -ENOSYS;
> +}
> +
> +int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *)
> +    __attribute__((__alias__("efi_runtime_call")));

Same here.

Even for the non-compat variants the need is un-obvious: Are you
intending to wire these up anywhere in Arm or common code? This
of course is once again pointing out that such code movement would
better be done when the new consumers actually appear, such that
it's clear why the movement is done - for every individual item.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:02:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:02:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313571.531169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njH5x-0005t3-9D; Tue, 26 Apr 2022 09:02:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313571.531169; Tue, 26 Apr 2022 09:02:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njH5x-0005sw-64; Tue, 26 Apr 2022 09:02:53 +0000
Received: by outflank-mailman (input) for mailman id 313571;
 Tue, 26 Apr 2022 09:02:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njH5w-0005sn-1M
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 09:02:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a650bfbd-c53f-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 11:02:50 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-4js75XMLPaOgpmiNv9y9lQ-1; Tue, 26 Apr 2022 11:02:47 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4836.eurprd04.prod.outlook.com (2603:10a6:208:cd::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 09:02:44 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 09:02:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a650bfbd-c53f-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650963770;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=x35vDbHqDus8D94MvlrwML05cIVW0G4PvZ4nKACIxOU=;
	b=WXaNzujVFZ9Aq7PuBx5ob1W5Cl7dlBd4VZ1ungoh9+SPQekzSHaLEgCEFPp26nNpbsP1mo
	7A0F1LTR0esnUlKvh2R4loT+rxEH6Fijf8But1ddlF4xlwlTC/qqRmVB7c+cmIUcflbrj3
	A6axOQ0YVBFwehKYvQmD8PGK7tXtI+E=
X-MC-Unique: 4js75XMLPaOgpmiNv9y9lQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YRtS06mtuDq0oylCJVG5/ZUTiMyV1TWrj2kApCtBGLLmAjVeABTYxzU+X+nqOJ24wcsMsh/dYg/XsZ8TGgsdEejm0B6JaPqHc/yi1ErmFAc4uviULa+BlDJFrk8GZS9R8vCEAGrkxdqIISJkfflY+vtGBnv1t21k0z6sJ8sVCy6fz0mxCt0EEfXxWMr8ZiiVI4uIZtJjDODzUdRcCB6O+ABZNS3DrzAFvloQ+IaPRCbDi0/w62L/9nI3S+zJm1iXOg5TGmXlOfZYvjmFEPhVfyWzExKdOGPtUZToOqtJp1b6edboBZNX7ALyG6D+4PeHigdpI7UdMtzsccJ7vXm2yQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x35vDbHqDus8D94MvlrwML05cIVW0G4PvZ4nKACIxOU=;
 b=JboabU6dHi8CWB/w/wP692hSbgJYp+dsjXoqPPTMCpTje9xhTzbkrrUWUgt2Yo3IBHdtmgT22TCKKDdJWUJ7ctetKqrzSwgTgyNkTZbKXudJZrSSb2hvVBLgTz6o4Hz8rCGt928xgzR/T0aLH9U7M3SJi4gLZNwKroPJGSH+z1Ohiqx04B+uuDYCSKtsFXcgE/DXWuSVI1nW9w85PPfuOnbDxscdUP+d3pcQp4aHaoN0H7yJktKszbFJ3F0jlyiCPMhG1M/vdT9LWTUZV6mW7PXy5oy106Wm0ilmSbm8M5iSAhb5iJp1zstNv26r0KSmJy/QzdzxtiMBUo+zuvjHwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6d666aa4-c0d3-b8ed-9fca-e9d2179564d3@suse.com>
Date: Tue, 26 Apr 2022 11:02:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON
 for phys_to_nid
Content-Language: en-US
To: Wei Chen <wei.chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-6-wei.chen@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418090735.3940393-6-wei.chen@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0046.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: da545736-9dc7-4fb6-8300-08da276386c1
X-MS-TrafficTypeDiagnostic: AM0PR04MB4836:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4836156694FE503149FC1776B3FB9@AM0PR04MB4836.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	APUqBa+YBRY99wfJNRT3SYu2lRQXqSwHTIJF3267sMMG8ktoJYoBnSCvMDisABhoVTCtwYV8a/+wZKMDgYzjJ2p/sNu1XUIBogchhQwS11a0uPEjXcnzybOBPrP/DI4BUz2NIKGXEZklNWmu0wiv9MkdhSqvmBZtUpnWQO/lpMpNyHz3SNhJAGPsJ9nI2ZtMNbY3MXn8mlsUkWlY0FngjEwwPyBicF4N6OIM2FxCYevWxyX2xh43Ze0ouxdQmk+mj6CbA3rd9jvEm8qummNSmTMq7gI8qjg2SylGMI7KsoeqdsBcPX2PNfkbSpmYXyUjHbn0sGE5vvVRsKKkJ8Sk50Mbc+PncwcjEWofngUyehGCzGsNHk9ppK46UL1Gg7BICyYh8nk4E9TaVz5txkfWtHip+8qkcvhn9DO0Rwvpi2OSzp27JfYDfuDEJO0IEvoZxr3wZ3Vt7YhtKSQh5wJFRX3I7PSjnBXYhP0adIouDm67eLHCH29jDEOnIMZxFMjnVYGUY62a12HLqoH+/MjBhoJTVJUpSFp5xLYlgdnP9lWLhEp4gR+gIf92NJkCnpNeofBqoUca3RsMs0XGSpbbTIHboU2Hjl6C8/635OvyWHBnLAqmcbPZHThfftks46k8g0TxBYHOUrOJj7zY90VjzycjaLlKD7G/m1h8Ah7fIh/necp6eWfz7sY+syl+Hyq+aKPVluSmaxlafjCEamQX/Y8WiHA6jfFU2TgBRwZlYxePTrrNZYY+pa7wumLLgPOV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(66946007)(26005)(6506007)(86362001)(31696002)(66556008)(316002)(36756003)(6512007)(54906003)(6916009)(6486002)(66476007)(8676002)(5660300002)(4326008)(508600001)(2906002)(31686004)(186003)(38100700002)(83380400001)(2616005)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eWxVU0FQVkFiSENyYmVMMmhpcTh2VmdtamcvU09RdzhjQnVicUR3TlpkTU5K?=
 =?utf-8?B?dytTc0RDREw5ZWxhOFEyWk5QSEw0V25hS203bS84NDBsekNLbWwrTlZUTXZt?=
 =?utf-8?B?VDJHU3UzUlY2Q3M1QVdtK2x4ZExnS0cydVFvYnoweXhVa3hpcU52QU9QTFJ4?=
 =?utf-8?B?VFRmVzV4OFVxcHdzM01ISFlROEpmd2s3dndkZFVkcFBMYTZ4S3BNeFd2UUZH?=
 =?utf-8?B?bDFrRGNSNXNlZmsvT2ZUZ3ZuMTVwV1l4L1dtbjF6NkRJMFlaeExWSmRpSEZB?=
 =?utf-8?B?azVjb2E0Q05JZnJTRnlQOVdRSmlpWWZtc0dhWTVDVTdhcWRLcjRJUHl0bzRa?=
 =?utf-8?B?bVFyWHZEZW4rSTBJTm55blB1ZnhOODRTU3ZRWVh2YUpPV29hTDdobzdIenll?=
 =?utf-8?B?aGFnWXNCcVR3aTEwTFhsblk4V3F6V2pZRzNyME9Od2kwbFZ1U1NhSDBYcHFM?=
 =?utf-8?B?ZkF3QTZiQlFYZkppN3J0TSs1MVM5MjhpZ1N4R2tUVWpQNVlqUHU3aHVNK1R5?=
 =?utf-8?B?bGxXYWtQOWR1RDk2V3pWaGw5UzMvSXZXbWRZaC9zcW5aTTQrT1RhVVRzSnU2?=
 =?utf-8?B?UnU0bnQwQlYvVS9OVkRTRHJTSUZOMEVZWkY1SVR2WklBTFNUNjhwcE9IRGV3?=
 =?utf-8?B?bU5JeWtxTHd1alVrV2hxVFlVanNuVEZURmRwWmNXRDNIc0JRQlBNUStnUi8y?=
 =?utf-8?B?b3VyemVkT3JYOHJnWThtNmxJcXhBZkhra1hOajVlK3hrRUt2SW9KZ2phSjA4?=
 =?utf-8?B?R3NGcU9BaXNnRDErYk1wWXVKd2VWT3pWakhhL2J0TC8xYlNMMTFQVmkxbGRp?=
 =?utf-8?B?YVpwNXVicG4xZWxlcm9QQVNrVnVOb1hYU3owWlFYL2Q3K2k4bFA4MHlnNEZp?=
 =?utf-8?B?eGpiOThUdTZPeEpmMG1ocHNId0JCL1JxUnRRckFPeGF0bU40WkcvU0lKblNG?=
 =?utf-8?B?cGdRTU9DUmpPeVBOWVg4MVZ4bGo5MDlwZWVBTTJLZytHZHVScjFpZjJhQ2s4?=
 =?utf-8?B?T0ZOa0R2cXoyckxrUlNoZDkvVE0xKy90akhrR0kxNjB0RDNkak5LY2s5dDla?=
 =?utf-8?B?aG80d1Z3U0t5VS9PQS9TQjhTWWlDVjlqT1Vzb0Fxb1BiRTJmYjgyZFl3L2hO?=
 =?utf-8?B?YklaZnRDM2tXRVU5M1R3YTZ5NTRHV3NKanpqOEJUNkhyM3g5bmsxSnpFUW1s?=
 =?utf-8?B?WHQ5THhRZS9ESGFtYnhJVGhzblM2U2QwQ1JvL1dRRS8wTjFlbktmN3BPL1BV?=
 =?utf-8?B?UmgrNS94TUZrNnhJUFVuOWlZQVpPVEU5MGUyaFhXYzdwRjJCbitnamJCbkQz?=
 =?utf-8?B?MXhoQmJsbFhIVjg3NytMZ01NK242ZUVsSUxtRkg0UzRjc2RncktaRnZ0ZUl1?=
 =?utf-8?B?c05zck5mdGpad2d3SVNnY05UWXR1RHpzZzYrWjhWZHo0bW5RbmF5T3lUQlVL?=
 =?utf-8?B?YzlDSlVFM0hFbkhNSDVOdnFoZDlCTlViTWtzU0xIQlZoYU4rUkdxRTRQQnRN?=
 =?utf-8?B?dWFRRTZUSlhKOEpQLytIbXR2N2NYcStGc25IUml3cHJHZGYrWkplajhFdTQ3?=
 =?utf-8?B?ekNFTWw4dy9aTUJMdmR6STlPTHJvYmlnQ3pIc2l3RDRFWlVaOWNtbTJpWklx?=
 =?utf-8?B?bUJjSTQ1TFlscjRvZTI4eVVQSE5YLytSUEtrQ0ZjblBMMmpZMHZETUZLaEdq?=
 =?utf-8?B?RHVJb0dNMCtmSXgwblBQZDNISEh5cEMvMzNWcE1xdXc4dmg0azFiL2xzU1dv?=
 =?utf-8?B?dCtJc2dOVU9QMGkrOTZycGh4OVBkV2VpakVVRnhQazlwak1xUEdRN3pkNFlJ?=
 =?utf-8?B?a2dxL0FJNTN6cWZ5UlpUR1F2S2p5aG1ZYlpCb0kvWUgzZ0E4Vy9DWkkzTE80?=
 =?utf-8?B?YkNXa0xTUHRaelZZTHI0blRvTEZDQXVvZGRZY3dCNW9LRzkvVHg2YW1RK2dY?=
 =?utf-8?B?b1hmRHBtWklvS3NuNlJOVmFZZ29sa2RYdERoZU5uQ2NsbERKRVZydTZ0aVMy?=
 =?utf-8?B?TUxHNy8xRmVodGhaeDBJSXpJK2tuTkNDWVc5eTVXTEYvblNod2NnS3cvamlv?=
 =?utf-8?B?MGoxbVZNREZFWUUzMGhNYmdJbVlaalJNVFhHRHJPOXJ1Z08xaHh0RnlESENo?=
 =?utf-8?B?WEVra0h4ZWh3dHNlN0lPZ01VVnV0VWJCZ0hDV2tPR3V6Z3gxSmJaQzN0U0Ja?=
 =?utf-8?B?bURpckpDVVRpaHBMeU05MVJRODlXQmY0M3QyMnBnSHJVczN4ZFdFNkpSNEdy?=
 =?utf-8?B?ZTZTOFVSYktPZ3ozU3h3b2wxQlY1MzhtbU41Q1VMbXJRQ0RtV0hPR2FlOWlp?=
 =?utf-8?B?QnJWWjM0bFJvdlhZWmxSd1d6Z1VDMjYzVW9iNWNzTTdEanZreC94UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da545736-9dc7-4fb6-8300-08da276386c1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 09:02:44.4139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NuYjgQn+iSsGfqK8DdJyJDlhkUFPAPAmqttwoL01LBso+BvA47Lvk5rzvBzSXT9i9DGRvMAc5V6bTB1uXpcd4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4836

On 18.04.2022 11:07, Wei Chen wrote:
> VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This
> results in two lines of error-checking code in phys_to_nid
> that is not actually working and causing two compilation
> errors:
> 1. error: "MAX_NUMNODES" undeclared (first use in this function).
>    This is because in the common header file, "MAX_NUMNODES" is
>    defined after the common header file includes the ARCH header
>    file, where phys_to_nid has attempted to use "MAX_NUMNODES".
>    This error was resolved when we moved the definition of
>    "MAX_NUMNODES" to x86 ARCH header file. And we reserve the
>    "MAX_NUMNODES" definition in common header file through a
>    conditional compilation for some architectures that don't
>    need to define "MAX_NUMNODES" in their ARCH header files.

No, that's setting up a trap for someone else to fall into, especially
with the #ifdef around the original definition. Afaict all you need to
do is to move that #define ahead of the #include in xen/numa.h. Unlike
functions, #define-s can reference not-yet-defined identifiers.

> 2. error: wrong type argument to unary exclamation mark.
>    This is because, the error-checking code contains !node_data[nid].
>    But node_data is a data structure variable, it's not a pointer.
> 
> So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
> enable the two lines of error-checking code. And fix the left
> compilation errors by replacing !node_data[nid] to
> !node_data[nid].node_spanned_pages.
> 
> Because when node_spanned_pages is 0, this node has no memory,
> numa_scan_node will print warning message for such kind of nodes:
> "Firmware Bug or mis-configured hardware?".

This warning is bogus - nodes can have only processors. Therefore I'd
like to ask that you don't use it for justification. And indeed you
don't need to: phys_to_nid() is about translating an address. The
input address can't be valid if it maps to a node with no memory.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:06:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:06:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313578.531179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njH9R-0006Zx-Uq; Tue, 26 Apr 2022 09:06:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313578.531179; Tue, 26 Apr 2022 09:06:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njH9R-0006Zq-Ry; Tue, 26 Apr 2022 09:06:29 +0000
Received: by outflank-mailman (input) for mailman id 313578;
 Tue, 26 Apr 2022 09:06:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njH9Q-0006Zg-Op; Tue, 26 Apr 2022 09:06:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njH9Q-0000KA-Kz; Tue, 26 Apr 2022 09:06:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njH9P-0007vS-L6; Tue, 26 Apr 2022 09:06:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njH9P-0004l9-Kg; Tue, 26 Apr 2022 09:06:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Q7DiAbbNjb24vZvG4oBE/Yb1c5oRsTtajY9JQiy+Lsg=; b=pIsK6YmPcesOeFScIuUZA3ZbZt
	df0jKEWHWuwiQZwDiZBpEGcE+PeBNIRjmhy/aE18A/QbDxgrnNtyEPLoE3sZkWIGRQ+aFq6f8XFY+
	gqDyAIjsRf9sclmRZMjo/d9klM+UpzKxgqDomY1oq6l01P8l55FsC/dxFbjXotiOm4Ps=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169723-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169723: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
X-Osstest-Versions-That:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 09:06:27 +0000

flight 169723 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169723/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169694
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169694
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169694
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169694
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169694
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169694
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169694
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169694
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169694
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169694
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169694
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169694
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08
baseline version:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08

Last test of basis   169723  2022-04-26 01:51:45 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:08:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:08:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313585.531191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHB9-00079c-Bg; Tue, 26 Apr 2022 09:08:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313585.531191; Tue, 26 Apr 2022 09:08:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHB9-00079V-8M; Tue, 26 Apr 2022 09:08:15 +0000
Received: by outflank-mailman (input) for mailman id 313585;
 Tue, 26 Apr 2022 09:08:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YDip=VE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njHB8-00079N-78
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 09:08:14 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6690b280-c540-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 11:08:13 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id BD7FF1F388;
 Tue, 26 Apr 2022 09:08:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A26AB13223;
 Tue, 26 Apr 2022 09:08:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id dSArJny2Z2LbKwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 26 Apr 2022 09:08:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6690b280-c540-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650964092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=5ePbnWGj078M5rHzgpCHA5ttcI0pSrUoZ/F8e+XsuHY=;
	b=jaNJr2TbX//2L6PODaycWGPhMzLA+c7yMPSTeG2PmeD3Ms3q9WfqXGdqrdIX8LzlKySI2F
	4NM3oHaXRaGsTJp0Khdae3nq3Wbzy3H1mb9Mua1J1l5sVory1vdiZbSmdESEiguaVimh1G
	hgLtqUN3ScKwXwUXAMg/lMPT53tyKok=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>
Subject: [PATCH] xen/public: add new macro to ring.h
Date: Tue, 26 Apr 2022 11:08:10 +0200
Message-Id: <20220426090810.28616-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

For the initialization of a ring page by the frontend two macros are
available in ring.h: SHARED_RING_INIT() and FRONT_RING_INIT().

All known users use always both of them in direct sequence.

Add another macro XEN_FRONT_RING_INIT() combining the two macros.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/include/public/io/ring.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/include/public/io/ring.h b/xen/include/public/io/ring.h
index 277af36e61..3925d6ad95 100644
--- a/xen/include/public/io/ring.h
+++ b/xen/include/public/io/ring.h
@@ -184,6 +184,11 @@ typedef struct __name##_back_ring __name##_back_ring_t
 
 #define FRONT_RING_INIT(_r, _s, __size) FRONT_RING_ATTACH(_r, _s, 0, __size)
 
+#define XEN_FRONT_RING_INIT(_r, _s, __size) do {                        \
+    SHARED_RING_INIT(_s);                                               \
+    FRONT_RING_INIT(_r, _s, __size);                                    \
+} while (0)
+
 #define BACK_RING_ATTACH(_r, _s, _i, __size) do {                       \
     (_r)->rsp_prod_pvt = (_i);                                          \
     (_r)->req_cons = (_i);                                              \
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:11:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:11:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313592.531202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHE8-00007H-Qs; Tue, 26 Apr 2022 09:11:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313592.531202; Tue, 26 Apr 2022 09:11:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHE8-000075-Nt; Tue, 26 Apr 2022 09:11:20 +0000
Received: by outflank-mailman (input) for mailman id 313592;
 Tue, 26 Apr 2022 09:11:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njHE7-00006y-GR
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 09:11:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d4cd3b6d-c540-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 11:11:18 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-_u4PrxltPMGBvvwVy1fedg-1; Tue, 26 Apr 2022 11:11:14 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB6432.eurprd04.prod.outlook.com (2603:10a6:803:122::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 09:11:12 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 09:11:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4cd3b6d-c540-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650964277;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SbukDmSwJmoRBCLIetA2B8ev7EKGSo+vjX3+6kuuQ8A=;
	b=lXx5ITZXtke/8TCCHNvy3hAchaYbc4sXB7WPP+Ana5bH4ruetCmum/baz2wzQfc2a6mGTk
	qqDfeYHAjzL5WBADcpwyk3gCH8EQmk9c9J2ESv6R0hFPmyF9OSrD6qxc9A5d1K6iDkEKU5
	QBHx6ZOPNzxAsKpQBJkzDLt/7nM0az0=
X-MC-Unique: _u4PrxltPMGBvvwVy1fedg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TuVQp1BI8O0I/AMOyLPrRBFTdv+AqH22O8kqU+Ipi+j8KDxg+zcZIcoHHKsk0hvrHg21i3itUICml1KIja7QoUY/HqvKrsERVdwwvXrGwvymYAdKkn/qnLpWvs+CGExJHZNmhiX+1VXLJMIzEjwLzdTAVsoAtO6ZWT6quU/7/q289v9cM+E8vuFoXSok9r1JnRvSxHWHoUQtN6ajvpk4nh387AWh5DuwGSqgl43n7j5I4vmrUVOAtl+k07KnX00Ez1jXfApBehnQ1zD7GGbg//b015LQdBvYnG8lqMlb2Yq4NCchV+GuPZGG30JxdauOnH91PKHpH47MoCbxk732nA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SbukDmSwJmoRBCLIetA2B8ev7EKGSo+vjX3+6kuuQ8A=;
 b=jvt5FIKnZ8FFOrmDqDvlnhGg5ZpPiK5SAQnYK6JjAZ2YA0Fx9MXn99HOxPVQBClwvPI6uU0bg44mlt5hCWlVdYU4ASp3wZ1T3caz+frropuIoBfjlKQnHyhPx7PWO1RZE1pWZ/umVWJANMjb8Ie/DihIq2lcJtAW2XaNKuz5+jgXKb6p1F5k5hh7yG9SmLQ5GQvItvLKKxhoTuQ8ZT2WCck0/2C6yHX1tt8FJpuM4aVf6BboXk6OwgQbvNz6/IhipHN2UtwRMwUcLvHLodRIkI8EMS6wuYKK4ibcE4EvDRyeKNSJCVFqh5dXkCOR9HLbNICRrK7p6MBM6UVsLKfDFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8a966300-e3a7-64db-b8dc-cb8386b2d11a@suse.com>
Date: Tue, 26 Apr 2022 11:11:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 09/10] xen/x86: use paddr_t for addresses in NUMA node
 structure
Content-Language: en-US
To: Wei Chen <wei.chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-10-wei.chen@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418090735.3940393-10-wei.chen@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0021.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fc8b5dc0-58f2-496d-4a6e-08da2764b5a4
X-MS-TrafficTypeDiagnostic: VE1PR04MB6432:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB643263CDA6422523C4F4B4F9B3FB9@VE1PR04MB6432.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	37VHx37uJjxcgypKIkqC9BbCdnw+Xcd3iIEOGNDBWiYSGDgBpseqQ/tBVpCCiRxaQZgkHweNAXSbZb5bNTihN0C6Ee7xR5X/xpVSspaz+HHLzQxD5NS/6f3HNQTqv3E7Q/3eKDvvX0D1Cak9WE/qcmhWwrlL/l/9uCZJFWbr9740MCjqn0p5qJ+sSsmsS0XuBpLptMwoOVhq3ouIknxdRBki+aL4mq9eKahIHtAjTIC2lK08cXzX1FkoumUcLQTmDSygE043CSBjw9ILIaE/l72Ko+TXFmPbiFTg/YQUhh+JBnOELHQAj2pnPMoq9ZaTS6MqEFz8XfE3gHO+/X8l2dvzGzwXYYXDAei7B0dcnQfQiYMHNZIHmtFQA/uEXGuKlNozy2Kr45Cxkzc2+rP1cLXEi+MwCoQ4qLKNenjEES7YMQouYszKHHN2RnCjawU3DXSv5KtrFqRrAjk1fDmoGT6+vfU4e5AGKFWaQ+p7cmUu7euKzXan3+zXmh3og921ypJtWM2ZIqlWEYiBIsVFWxFA+VWVdxK5qJWgXIsspX2oZSK4+5ZcC+Xnr2QBM0NmThl88ejQrO1yx8ihIkLekAgDxCjDYKdr96fe12S1uM6NKv4ZGnMv3G5jlEwVNdveerdM/QJlQWl0r+gomdIg0wxKCyQsSmKk0E5cqwydKaeNNVvRyVDBAiWLvW7PUE1DGRuMxIFd5tZYxumK1dLS/eyJE5Ao0RYipi3CPQyKz7S/9Zq/buybtD+6j+0QZw7r
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(86362001)(2616005)(54906003)(508600001)(8936002)(2906002)(31686004)(5660300002)(4326008)(66946007)(66476007)(66556008)(186003)(8676002)(6506007)(26005)(6512007)(6916009)(316002)(53546011)(31696002)(38100700002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RGdXc0dtYkhETkhnWmErU3dtTENjd0lzR2ZVSXZtNlNOTkZGNTQyd09QK2R5?=
 =?utf-8?B?NFRDOWRxVStpc0ZtdXkyNGl5Q1lvMFlUWjREZlkrMkE5VVhaY3JKa3hlS0Fs?=
 =?utf-8?B?bmd2bUhYR0UzZi9VRmhLU1VmV1FCWjA5VTBDYmFsdjhzdEVyNnIvQnBMZFMz?=
 =?utf-8?B?YlQxOUdvTXRoNm91QmhzY1d1WWVQYkRMbDlDSGdBU2padUFYTm5GbFNwNWV2?=
 =?utf-8?B?dGtqWmE2RUhwcUlIc2FXSW9EVGNBVXpZc0ZLRnNQT3BFTmczY29mdXRyTERk?=
 =?utf-8?B?ZzMvVVR5ZHA1c3NUTEtsaERzNWVOWHY4WU1ZMU9ERllTdUxVTVlXN3I0YUZQ?=
 =?utf-8?B?M2pGSlR4dHFkaUNtalFMaVJFYVdSdGJKcFg3MVR5MHl2SDRoZDRpRWRXTktz?=
 =?utf-8?B?S0JpcVhTL0VSUkUrOUZlNUE0MURPaFRROGgvWDJQNy9xODlVZ0h6RExWNnVH?=
 =?utf-8?B?anZzcXBXcUtUdDNac1hmQW4xcy8zODVpMlZxYml0NmFBSDVHTnhyYWVzaTJH?=
 =?utf-8?B?dE5wcFZRNUlFbW5oaFkxRUZMZjZtdDFQdDA5ZzMyMllOOEZhOEpJTmxuM05k?=
 =?utf-8?B?QjA3dzFETmx6cGFCM09NZHdsYW50SytRRXdSS2lDVE81cnlpUkQvQlNUYzlI?=
 =?utf-8?B?UDl1UjFoa29iMUxWQWptR2FhZ2FuWmd6RExsaWlHQVgwUW9OQmE0S2pzdURr?=
 =?utf-8?B?eTBxeEFUWW10ajU4dVFFR1lSNkJYMHBJV2wxZ2Y0TUhDRkdROVJ6dmQ0anM0?=
 =?utf-8?B?OXJicHVlT2ZEWWFmUG5Bd1R5YkpWQzZlOThJcXcrNkVMUHdjUGt2Ky9tSFZr?=
 =?utf-8?B?UWNUMThESzRPdE5pL25nWWJ3MkM5WTFoM1JYVXoxd1BFbEdQZEhQZm1yenZa?=
 =?utf-8?B?NmtsYWxraEZyQVhTN2trUEliN2paV053OWc3VHFyU2RUQ29VWndldHdBOGlW?=
 =?utf-8?B?U2dUTjlFRkVYMVl5bmRsQTMzQnMrWmNiOWVKclpkUUZFcUo5dzZ2dm1nVDJH?=
 =?utf-8?B?TUFiaFFIeUlQcE9ESXZLOWdaaERyVDVxZU9aK053WGt4OGEwUW1ETHBPYzZQ?=
 =?utf-8?B?eGc0aXlVai96TjV0MjhVeG0yWVl5T2E3SEtvU0QrTUNHM3FWa1E4cGxxcXVn?=
 =?utf-8?B?dlN1Q2xtb1YzYjN0WlVJSkFnMzd4YUVnTjdMeXAyYTlzT1hGbFJCVkd0elk0?=
 =?utf-8?B?YitJZ3pKNTVSVktjVVE0MTRiUDlpQkFZQ0JWd0RSVTdJeEdJNjlRNXphOC9F?=
 =?utf-8?B?NVIvcFh5SVNGRElNOW1xM1l3alg3TExoNmN4VGFtaW45TlRaMEVCNjd4QTA0?=
 =?utf-8?B?ejZGVm1tWTd6TG5qbUU3bGtPM2JPRXFMK2lZZlFGcHBhL09CMU5HbVFETi9S?=
 =?utf-8?B?RUlBYllkYmNxRjM1bVQvNTNENHJldFRGcCtmazNUbXloMzZ0UkM4d2swQ3h2?=
 =?utf-8?B?SDZtZlpHTnZHeXE0anErcldHajFIQmk3RjRzSFBZSzE4TC81Rkk4V3NqSSt2?=
 =?utf-8?B?NDVJOGRxVEFNT0tKdEZJUnN4YkNSVCt2c3BzTHVEVk5ueit1R0xQbGlIaHA1?=
 =?utf-8?B?OVpkalNMNUJTN2NpT3V5emZXRTJtMlB3aWtPNnhWakV0cUF2cTRuUFJWc1Ry?=
 =?utf-8?B?bmIrVjNiUGlnbEorVU0vZmhmd2N1UE5QUDRuWlFDWkNlTnVzcW1rV1JLb2h4?=
 =?utf-8?B?NWxJdDdtc0RjQ1FGZ0tJMUF5QWlCd0NueU9lczVvaE1WeXF0NHhrU0YrWDBl?=
 =?utf-8?B?SjdUYmduVVgzdlJSaG1LYlZGdUdlUWNTU2FWZGJja2c4SEZDVlZuM1ptZWtS?=
 =?utf-8?B?bmRwVDlESUxncUlaeVQ3VlgyVGxTdlNUUXZMam0wRjRwcjRIcGFoempxT081?=
 =?utf-8?B?Y0hrUE9qejErdktLeGRpYVM3VWZPdWpxRnl3eE5kR3RNTUdBdG5kL0NORnRD?=
 =?utf-8?B?UHFuUTF2U1RSSG1rYXhXRmkzeUNSNzlBQ1k4cWhYYU5PcHkxVjBvNGN3Mk0r?=
 =?utf-8?B?S0lkT1dPVXBKaDUwdlNPY09taWhXOTJ0cHMrVm1rVSt5VTAvekc1RU9WS25D?=
 =?utf-8?B?S2pmMkZDalI3UTJOenRScDZZTVZyUWlNU2Rnend6MlRIS3FqMzBLcDRSTmRF?=
 =?utf-8?B?YzJxRTFsa3FmM2FQT2ZyRWhlVVZPRUUxQlBtUDE1Y3EwNUZNZUNnK1ZxNzBT?=
 =?utf-8?B?WjlRVE93WUtESXBSZ0czMFJ1djltTi9xNTcvVUpHSjlmUitVY0tRTktEem1l?=
 =?utf-8?B?QW5VVyt1ckNza0ZQTUhhTElrenF6WStCOGE0RFJhMy9jdTNuWHVmWnNRdVdp?=
 =?utf-8?B?Um5HbkxUVm1SRHpVU0lQRnBPTlpPUEZDTDBVaEgxWVZxWTVSSnZ3Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc8b5dc0-58f2-496d-4a6e-08da2764b5a4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 09:11:12.5408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JzTmK0IBD5j4t/7GPmcnN+lXdn1QSWr8UAJP9ShTWzl8NFxSb9t7iVyVVhaF+FVZX9FUXwQGNMzEkcdstogEXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6432

On 18.04.2022 11:07, Wei Chen wrote:
> v1 ->v2:
> 1. Drop useless cast.
> 2. Use initializers of the variables.

Would have been nice if this was extended to ...

> diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
> index 680b7d9002..2b3a51afd0 100644
> --- a/xen/arch/x86/numa.c
> +++ b/xen/arch/x86/numa.c
> @@ -162,12 +162,12 @@ int __init compute_hash_shift(struct node *nodes, int numnodes,
>      return shift;
>  }
>  /* initialize NODE_DATA given nodeid and start/end */
> -void __init setup_node_bootmem(nodeid_t nodeid, u64 start, u64 end)
> -{ 
> +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end)
> +{
>      unsigned long start_pfn, end_pfn;
>  
> -    start_pfn = start >> PAGE_SHIFT;
> -    end_pfn = end >> PAGE_SHIFT;
> +    start_pfn = paddr_to_pfn(start);
> +    end_pfn = paddr_to_pfn(end);

... these as well.

> @@ -218,9 +219,9 @@ static int __init numa_emulation(u64 start_pfn, u64 end_pfn)
>      memset(&nodes,0,sizeof(nodes));
>      for ( i = 0; i < numa_fake; i++ )
>      {
> -        nodes[i].start = (start_pfn<<PAGE_SHIFT) + i*sz;
> +        nodes[i].start = pfn_to_paddr(start_pfn) + i*sz;

Please add the missing blanks around * while touching this line.

> @@ -489,7 +489,8 @@ int __init acpi_scan_nodes(u64 start, u64 end)
>  	/* Finally register nodes */
>  	for_each_node_mask(i, all_nodes_parsed)
>  	{
> -		u64 size = nodes[i].end - nodes[i].start;
> +		paddr_t size = nodes[i].end - nodes[i].start;

In numa_emulation() you use uint64_t for a size; here you use paddr_t.
Please be consistent.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:20:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:20:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313599.531212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHMp-0001d6-PC; Tue, 26 Apr 2022 09:20:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313599.531212; Tue, 26 Apr 2022 09:20:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHMp-0001cz-MB; Tue, 26 Apr 2022 09:20:19 +0000
Received: by outflank-mailman (input) for mailman id 313599;
 Tue, 26 Apr 2022 09:20:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njHMn-0001ct-Nl
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 09:20:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 15a1253c-c542-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 11:20:16 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-J2tDk-h2M9unXc8YMuWRZg-1; Tue, 26 Apr 2022 11:20:14 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3567.eurprd04.prod.outlook.com (2603:10a6:803:c::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 09:20:12 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 09:20:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15a1253c-c542-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650964816;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FlthTxj6EWGBFF0coUuh7CPEUxrvDwcDZDRl6EyQg1Y=;
	b=Mh6P1Y1af09z21FIxgt3YmoAxJodYY/bNBs+p1IC1WEC+h2fNqOoBmVCP4IaqWGweNNzVm
	Lgzq2qx0KlnJoekUF9yjhTVegPfUTf/F0AQ1dAB9iDO5CCwmyyX06nQd7+ddbLM5s29FZR
	D+pFpp2AA09TllmNK0Xl36/3kem71iM=
X-MC-Unique: J2tDk-h2M9unXc8YMuWRZg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UFNfesPaOj9tWjQAiIxkXhSLcgCsBlc9/cD3LsDriUjf5XPGAaAHdcfIvpmegf0/cXcWx1AO0TwpdortDpZQv++MrgJY1KgHm3PTOaU8nwlInHDi75BmdqW26blaArgbHh7+ahAV/83nMfaNfnXAFkkNU+X3HCX3LQrWnttu4KCsopuN7jrjhHkrKTtFLC+C+ZKxwVNiM+16lU7hef4YJvo1hhYUWKjhKp+uOxLDaqobkkFL2Y09YhwdZXjroRBnpSkISywWcQ4YBJ7ME+tGaYPGXkDlEC5PlRtSxisO8pl3R8o2m8R9umAWsDBXk9tVPjWK5LyULIu4Rv6eEboneA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FlthTxj6EWGBFF0coUuh7CPEUxrvDwcDZDRl6EyQg1Y=;
 b=OU+srI7cE1EI7YYJKL9c0U4+SgQCWoQNiQCTbnvrXHl2xDww8yt8c14zeCDjGTvn68Wx/Rzm0G7kXKZrK37x+7lzlVUC/hA+Ip+4iVrV7e/r7kFmL3L3fMV7gBLLECT6JeqHJD5dNlF5UhabRSJF7Lx/CatfOdDjwHT+rxYRk2XZZ1HCIfhQXZhDY2eJvuvGeJTiybWUblh/VqfDKLfhxIP8hGLUJwIz5pKvA9Z6IDLLAV/h5TSVQx+BB2yHrQRnHc73bzrn3rOFEgRa8yow3NyTBtwJwIIxoC+dNcLd3wqH1EgSgEdV8HDeQYP2LMOyq/waXP0C1J7suPUQ0xd0iw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <22591300-a09f-1ab2-fd6b-6c4875641035@suse.com>
Date: Tue, 26 Apr 2022 11:20:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 10/10] xen/x86: add detection of memory interleaves for
 different nodes
Content-Language: en-US
To: Wei Chen <wei.chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-11-wei.chen@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220418090735.3940393-11-wei.chen@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0033.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 59c0f04b-3a92-47a8-a7e8-08da2765f743
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3567:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3567391D17F495DAB0326CC6B3FB9@VI1PR0402MB3567.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SnlNVQsOBk4kv5f8UN+uc3HQM6nLiP3kNGb8lrxV+BRo7ASYYCQg/ukOJ3TAOpdoGzkuzoLj6uSYqHkzX7IGbdQJ74YnpJFtGPgwjQ9ChSGMdUgO0mo5eekL1OW0uoyIAU2RdaqXZnWcucTLO68OiuuOWK/1XIv23gvjj3j+APqrLjsHtI+MqjyjcKqlke9bzbxzbzP6LNmPGEJZ8RARvHSR77RlMS/qvgJ1Igh9k/9FJ42Rl4V1oUooaslzVeWefScVbP9PjfNaPA23YVGpZhrPVmhpafVeaQKj2i969IL9OHZ4lDDZ1zQ3ju9zDaPaNgrrk2hXfthD16hkERWvVtosRYX5DmJTWa+xO/kTxMwNI57d0ccshbue4RyvEvAKCD51a6Q7oEQJUL+xmpgBKfDHZ5PXwePyBMYo/D6R4gSjtxihB5PwMiSLCsiFHbIuCIcLX8hVRqm7iFT12G2Wvq6oaMtLcvXEL8CLa9XBKfbXNmarutCL8loq+Etuv2EGcXg2LravMXvR99Peb2wejgN8Dd+0SgLuiEFS2BFKauPHS0NkSM8IJdEkYvWUCkknms9FawQL5E7aio5lbGRgi2gxD99JNgxHSeOVRp9ZouPretpaXNqwbHfu7IxibI7kjXs897cDw+Vw4MzoII8izQaqtLU0FER4zjp5+BIMW+DCaHtNkj+wBlaTJHJLHi8tQB2K1vQjH+S+TO+NjJxO71/6GKRsP21+1fixI+6igBZyc2zp7QcCbLGPvI/xfuAx
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(4326008)(8676002)(2616005)(66476007)(31696002)(86362001)(316002)(83380400001)(66556008)(54906003)(66946007)(6512007)(186003)(38100700002)(5660300002)(508600001)(2906002)(36756003)(8936002)(6486002)(31686004)(53546011)(6506007)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZUdyNkNNTFZsZ1pTVWNjL2l3VzRUSDVGSGFtR3NHYys0NW5Ka3BPNzNmdlNp?=
 =?utf-8?B?NDl3VGNUZkJJK1dleC9NUjlFQkU0azRZMVU3ai9neDNXcWVjaEJjQ25YR2xz?=
 =?utf-8?B?YzFaRW9vU2YwTEhWeFRWa2c1cWkyQzhQVDV2a1daLzU0U2t2YlNod2U4RFg0?=
 =?utf-8?B?ZytsR2VlcjZkYVlTekkzczlxYTFwbERSaTR0bmtjWkZGQzJJRWE1QytWSE9H?=
 =?utf-8?B?UzJXUHpmQjBma3NEM1VRR002K3h4aVNMQUhxdHdQSW9xTDFNNmpZdlJIbk90?=
 =?utf-8?B?YWhTYVNLVE1Ed3BZZ25HS01YZmIrS29GclA1Y29tUUxzOC9IMjZiYkNueXdQ?=
 =?utf-8?B?eldvWGpYZW9OQ3V5a25qUko0dVE0bFFoQVc5bFhBdzA0MG83YkhBazVzZTFS?=
 =?utf-8?B?aFdGR3A5K2tPTUZ6UUZ0ZmJyeFNDUHdKTTFsVFhqUE1ob3VwSFB6SEcrbENN?=
 =?utf-8?B?RnFDeGJNR3Y1dERVQkdQcTJneVA3WFdGVmdxUzdpUGlIVkQwWlNPeFdhc3Ju?=
 =?utf-8?B?QmhHWGhkWjFMK0Izc0NzNzFDL0ZMSk4wVVdTS1J3UjI5a0s1ZnZkcCsxbUhX?=
 =?utf-8?B?ZHlIOHZyZTdRbk1NYy9FVFBkVDNLUGN2MDF3UUJyMkdaM0g2dEk3VlIvbGZz?=
 =?utf-8?B?UnZqWm9IcWJDUzE5RjRMcjdadVBKb1VFNU9vN3VXaEJycjZlNkZUcG11ZURy?=
 =?utf-8?B?c2lMZTJCNmpOV1ZTTVVVb2EwK0FiTElYazNhVStiTEd6dDZSN3RWVXYrUlho?=
 =?utf-8?B?dkhVRDJueGFvNXloV1hHam51Q1J1cXRteFdmS1hnT2Q5NVNqTTJCeFJQMDlZ?=
 =?utf-8?B?dVdyVEFoYloydWR1bmhwWHdZZHoxZGt3SmtaM0Vwc3BzbzB1aUpiejlkeThR?=
 =?utf-8?B?S2VZeVErUHV5bTdabDVlOEhRZkF6dVZJYVh4VVFMQzdNcTNFZWJndUlPS3hX?=
 =?utf-8?B?K2FpSlRoa29VYjZLNnh3SHFmTDhtaHFqRzRnM2NiZTg0ditmUlZhM1dUVDU3?=
 =?utf-8?B?V1g4ZEdoRmhvZlJKVzg0MHplOE0wa3YzN0JGUkNUcEpJclBhR0ZKVHNXRUdw?=
 =?utf-8?B?UGhEd251VVMyNldiTWdYVTRwWWFrVUFyZmNjTDc1d0hIQ0tQdGJLRWJHYms1?=
 =?utf-8?B?dFJNRStMcDcrK0RJUTdseW1VZytzN0VrL2dnUWFvbCtLOE1xd0t2MXZwOU1Q?=
 =?utf-8?B?ZW5qSGhaUTcyLzhYSUNLNUxvVWlOeVhvajVwa3RnYmZkK3UxMG1JYUlLVW1V?=
 =?utf-8?B?VmdBZEltRHhJeDNUbjF5YUl5YWJQZ3paR1VIaG9iRCtjMlBtSk1RWVg4ZVdT?=
 =?utf-8?B?cWh0cytSbW15RTF1RFhmdml6R2NmL0VXd1FjeHJSd1YvSHVmWkFGQVIzbFpC?=
 =?utf-8?B?blloWXRjb25KTmx3VkEvckliSk1oVkxWbW04WVRxMG1ERmUzQXFIY3hMOEs5?=
 =?utf-8?B?WUovejVrSzdHQS8yMW5Ud2NoN0lPUVREOFIrRHFPaUtwZnl6a20zc1l3UEdO?=
 =?utf-8?B?c2lSVDRaNnJYMzg2SjViaTZpM0VRbm1FTjVqbStrMWNYY3d0cERzUkNBZXhx?=
 =?utf-8?B?Q0JrKzhXcXN3dEFhQlVmYlhWcVY2d1pkeVNYTDRKazlOZE9rUFNaS1ZzdTMz?=
 =?utf-8?B?cFBuY2EzRFNKQThiNHVaKy8zOG5NMitqMDVod0tveUJSbUp3NFdOamZwWGNw?=
 =?utf-8?B?MG5JelYzam1yRjJEUTBTRU54U0ZKQlU4RlQ4R2RjL0Q3eVpIMFhldXJKRWNT?=
 =?utf-8?B?eFQ1aHRHRWdjczZ3N29TdjJaTmpXYkFZMmFxa1FHZkVCeml3S0JjYjFFOHdw?=
 =?utf-8?B?T1V5bXVVVFBlczFOT1FTOGM3MGkxM2NuZ0hHMmNOOUM2akxXblJCMVlZd2w4?=
 =?utf-8?B?bUFQMEdMT3dJNkN1WHVDR2lPSGFFQlVWaFAwMkVkTXcza0haaEdldDJBdktK?=
 =?utf-8?B?TmYyUE1FeXJrQndEdjlxOG10T244cjNwRWdxaTQxTGhSK2FvQ1VBMk14aHJ0?=
 =?utf-8?B?MldCT3NrMEhTNXhKZXQxT3pyaEp5NlBTWnQrWXpYSEdMYUhFeWpDSGpIVHYx?=
 =?utf-8?B?RkQwU2l1QWl3T0tXMEZmWS90Tzk5dktjam9URzVYazg1TXMrR1N6VkRreVZV?=
 =?utf-8?B?RWdTUnV5RzBkcDJGMm13ZlU2aVpKRDBPQ2xwYmo2NVlWZmhCVnA3Zy9POFY1?=
 =?utf-8?B?WlJtNnc0VkV5Zy9Ta1RCWTF5TDFVbkZkN3Y5YWI2SStkVXFLMFhKcFBnTUt1?=
 =?utf-8?B?Q3pxRFZCeDZsZmtqSlZtMjQyNFZXVkJBNS85dEtpczFpODlsWUpHbHkzTTFn?=
 =?utf-8?B?ZlBZdG1ocE1zMWF5MnlGUmZUSWQzUDVKYlltcnF1R0ZrTkx1SHBIZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59c0f04b-3a92-47a8-a7e8-08da2765f743
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 09:20:12.1963
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XlntY5fSi7Ar9F35KinfqtTJwMjTwuaQ88ahgns7+OiYHdocLW0xtbybOsrRKswPQIXg00tKjO7uKTfgRIxALg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3567

On 18.04.2022 11:07, Wei Chen wrote:
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -271,6 +271,35 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
>  		       pxm, pa->apic_id, node);
>  }
>  
> +/*
> + * Check to see if there are other nodes within this node's range.
> + * We just need to check full contains situation. Because overlaps
> + * have been checked before by conflicting_memblks.
> + */
> +static bool __init check_node_memory_interleave(nodeid_t nid,
> +                                                paddr_t start, paddr_t end)
> +{
> +	nodeid_t i;
> +	const struct node *nd = &nodes[nid];
> +
> +	for_each_node_mask(i, memory_nodes_parsed)
> +	{
> +		/* Skip itself */
> +		if (i == nid)
> +			continue;
> +
> +		nd = &nodes[i];
> +		if (start < nd->start && nd->end < end) {
> +			printk(KERN_ERR
> +			       "Node %u: (%"PRIpaddr"-%"PRIpaddr") interleaves with node %u (%"PRIpaddr"-%"PRIpaddr")\n",
> +			       nid, start, end, i, nd->start, nd->end);
> +			return true;
> +		}
> +	}
> +
> +	return false;
> +}
> +
>  /* Callback for parsing of the Proximity Domain <-> Memory Area mappings */
>  void __init
>  acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
> @@ -340,10 +369,22 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)

Just up from here there already is overlap detection (via a call to
conflicting_memblks(), and you even mention that in the earlier
comment). If that doesn't cover all cases, I think it wants fixing
there rather than introducing a 2nd checking function. But afaics
that code covers the "fully contains" case.

Jan

>  			nd->start = start;
>  			nd->end = end;
>  		} else {
> -			if (start < nd->start)
> -				nd->start = start;
> -			if (nd->end < end)
> -				nd->end = end;
> +			paddr_t new_start = nd->start;
> +			paddr_t new_end = nd->end;
> +
> +			if (start < new_start)
> +				new_start = start;
> +			if (new_end < end)
> +				new_end = end;
> +
> +			/* Check whether new range contains memory for other nodes */
> +			if (check_node_memory_interleave(node, new_start, new_end)) {
> +				bad_srat();
> +				return;
> +			}
> +
> +			nd->start = new_start;
> +			nd->end = new_end;
>  		}
>  	}
>  	printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIpaddr"-%"PRIpaddr"%s\n",



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:26:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:26:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313606.531227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHSd-0002L8-IK; Tue, 26 Apr 2022 09:26:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313606.531227; Tue, 26 Apr 2022 09:26:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHSd-0002L1-DU; Tue, 26 Apr 2022 09:26:19 +0000
Received: by outflank-mailman (input) for mailman id 313606;
 Tue, 26 Apr 2022 09:26:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njHSc-0002Kv-5V
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 09:26:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ec5f28be-c542-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 11:26:16 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-p4-dLgQlNtSitW9GzNhyCA-1; Tue, 26 Apr 2022 11:26:15 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB3982.eurprd04.prod.outlook.com (2603:10a6:803:49::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 09:26:13 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 09:26:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec5f28be-c542-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650965176;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3K54S1SujMEbj4tNb1lHJwPgChdxiwinUVOH9r/0H4c=;
	b=n6BOd0dNSp4SwvEMx9J+RdXkwiq2ph84r8r2m+qraZZBbrQfYIrSgPd8L/3kaeBk4WGfV6
	kYpyJYELJ1B82laUIaYCRw0xHqGWkJyhSS3xJcaxUy0XdJgkWLW2r0qDcqTYyntwogIy7N
	Ew+Soar+J389kSfXzP5etBbOZX062f8=
X-MC-Unique: p4-dLgQlNtSitW9GzNhyCA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lAYpMD7vTno90vAm3DYcJmUPeqKD8mR7XVyifz2rdB+Ia/PiXdaevZdaqBO5L2kM3d6gaW9Ea1aWpXH65AQXhgqQyT5BSuiNznnvl2GJDMqRTsV8MLK38v2lMKRBQg988S20hjQJTbboR4VWawIOPGGEAaVEabmSwG99xHhDm9lYwfvzYtxkkVSX0FaboHMprXLrw0xHRwXLGVkN3KGkNDlc9L/JRtM7hF0IR+o7Fo0sxv1Mf1MA9nPndfk1ADc0UAXplA523mqGYiSaXHZxwKl2Od6rvrXJZID2c7TqNQgbjCxphTwODjdfnwxlbJgCmdI5s4ZhrKhUXw+YaI+Xaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=l8rBkaGs/rdefEP+tisAIrHBmA42h46x1RHh1GtL95U=;
 b=jweDtHnKskaZ/KIcM12UZ/l7rXsSR12IEPi0TnIbRU/iw/4+QCuxV6AhcUV//13NSfNGuTp7D0vkZQIvbcqeB3adtu5ZILHYnFBgvkqmGuuQMAEPCTU8OyZpfZeFLG1GsBUNjKZHrygAfBf3TGjQUmbXSquTfxpHQe5ZdkP9qxZRzQvwC25RPpv1wuz9t4CLHS0+YIDH+XrVY2py+NAvWCP1jcow8GtUVGWdsOJKAu/3V9ovx6SxFCeQP6d/YGiFPpEwerts0eTFWVCz7nim6HOVNfkTi3N0pk8mLvkjcvu+PLuZrLvJWHVvzF6aek4cBrg1o9pQIEKFWiU9qx157A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cf714bdb-4384-d674-2e11-9a9227ed566c@suse.com>
Date: Tue, 26 Apr 2022 11:26:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 1/2] x86: improve .debug_line contents for assembly
 sources
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <e4bf47ca-2ae6-1fd4-56a6-e4e777150b64@suse.com>
 <23509d85-8a73-4d81-7ade-435daf46fcd6@suse.com>
 <YlgWKGmR+u41zSsw@Air-de-Roger>
 <04f9bd9c-70da-0966-afa6-96f81e290204@suse.com>
 <YlgiLhvsKVYKKvrr@Air-de-Roger>
 <2eab851f-0fe3-8462-cdbf-b438dc01ade1@suse.com>
 <YlhFiWYQMbjsOOAc@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YlhFiWYQMbjsOOAc@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0299.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7670d938-fed7-4406-86bf-08da2766ce4f
X-MS-TrafficTypeDiagnostic: VI1PR04MB3982:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB39820EE1ACD8ED6BA8DF78F0B3FB9@VI1PR04MB3982.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KfsplwQ/JZE1bbZOZm2CnqzgGp/l1Sf9YndUpb+Mc7pm3hMtjHhL1Gh7kWf6vKqzZ0xDA5Eg4YTjFIjbkTMLwYYH+tBIdTHBj2+EvVVJ+95o37z+9StlRqtlpxxV+HGYG9T6VRlluZnsJUSK+l7gL7XVmmIxRW65fYnkNkNSwXCKuZr3px3CtFqthkjtxsJLYbSTA7jvatJXIWwE+G4TvZeLxm3oo5vbVQXKrLEwLMMmN9uQ+SY9TBRIuZa0p2UaEQVbOi2qYKi+rrQ3CSvodMeTN+/XhLy/K41ZdQFj9P8NA/R8KrtO+CQ3cIPclj1f0y7anB7vhJkQJt4kubJ+vOUph7YXX1vpwJoF+vyxJ1va/FuuhJrbGLUtQ8v+erP/UC7tktKAGAp81qgeXrOH4noIPjUa7d+HFm3UmqNdhWZhJk5AxEiTn/RuFFyvYTXNA3dNScStkAhXTqvB/X1CDtQ02a7wxD9HQdN9v21dpervEERa/qcQeD1eZeAdVvXRYO+CYScE6P/1OIFOvWpOZOMeaHkf2Eg8doxvHxn+yW+2Rl4oaTEs0FKqvYRIHwuAlXjYWlx9NnpKJiwbuQpHBkwG1tKFoT/7KIBBa5CcxX7eGvjipU3TWrUgeLatmcika0Hnei07uHeIqXg+ffzzqO35qO1fri1dQDpMViN/b4K1Ilt3Y5tS420aFpnL5cE4xh3DnEFA0AqfSKlZcjEKX1nsSgcUOO4L5aV3Iaz/51RpjNcstOu9NopmfvevuJLXeCg0q+2CNK1fiMVBMWqWVGomlvuO1gPR6Qu9wy+zYzY63ONOyaDSOSz63ax9+0hsH315q4b0nrCpuM9pGGduPQNp3tarScOWPpO7HPBFYaRnCpvCM+2YAMXqFKzX4B/2a2xjypEGKCvQN2CD8aFkjA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(8676002)(8936002)(966005)(2906002)(86362001)(5660300002)(316002)(31686004)(6916009)(66946007)(54906003)(38100700002)(4326008)(31696002)(508600001)(83380400001)(36756003)(53546011)(6486002)(186003)(26005)(6512007)(6506007)(66556008)(66476007)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4gXitXcIhvh8fY11fI+De2d9s91yYdQY91g2S/DPk26DBf1DqjRIPpZ/KPv1?=
 =?us-ascii?Q?D8CVL/u/U9rH5QKeTuV8H71cZDzFq0SWYHDEa63zJTe9AvGFdaWhfLiSAuhE?=
 =?us-ascii?Q?/+o+zWIpjuIhgnodUyJQoYGF6kKm6mTYTgHoaUu/nwlGa7ntIsWoRyZtFeZn?=
 =?us-ascii?Q?nEwTNTcsHV+j8F7jv3O/EgWRTrvSzJu3DmDAzIpY7kr5L1kcyV7Ab1tVuOzQ?=
 =?us-ascii?Q?Dak+kmzPxmdDQVjtqkG1KswXKSJCAz5IaE4H6jxrINJniNXcki3IUlqF5+PH?=
 =?us-ascii?Q?zcPlC9ZBc7Zm5gEGAgpg7Qb0G/BZu7I06kjmPHmXsuypYVRpnxgHSv04JoWR?=
 =?us-ascii?Q?ZwWpWylQgwSR2bDXF9ScIIY5q1aZfg7tm7wOR3BYJ9i9phK7JQVlnF1H+YMj?=
 =?us-ascii?Q?omhSbAvjAGlZohhJUs1teGqvsmpBK/ZogLKtO4BzP/Lpi0JzIuZxjHq+1nlP?=
 =?us-ascii?Q?RgekotBQfxYL/68Cck7mG9NFOeOgTO7tP8YhJwWoc1IuNWLkH8k4cC9e7q1H?=
 =?us-ascii?Q?Nily77kbK4lF4DWT8alt9s46eaaAK/Fxot4Nq3MfgmXKB0MzbHinLQq1gIAA?=
 =?us-ascii?Q?V0XASnUB2f4cUJIlbLVQ8zCj4ON8tUAbUMrGia13xm47WaPKoFnoLmOuCVE5?=
 =?us-ascii?Q?R6hu2Em5Qr/50phffyT2ZdEdewpCPWWGXg8OgTRDJ4o/GKCCJFHl6SQsNUqO?=
 =?us-ascii?Q?MD44Tor/l7VqPiS5T9CZvFTlCJgPKEIGN0dKPT9/cwokedhd9s8jSjH9KG+n?=
 =?us-ascii?Q?dk6iGQjDJ/qQQbtDbZZ6MrRiJptNRG4r1CeX0QKcPtuHe1UrMNDNDRhOgSix?=
 =?us-ascii?Q?oAG7O4z1TpBmXRtNexXLEvNTQYuRr4l4omTXCAXcu9wmIDsuPc8RUtRjPqwb?=
 =?us-ascii?Q?k20EvVwsz6eJYhUK7M5B4171f4ZrtkzjDOL7AF743KaxEcB8Jb99qYmpa4RJ?=
 =?us-ascii?Q?9KYM2e8hj2LvM4FXh96LZEMKESryIfVDfdc+dwPgUjWUx0O/oKvr2bQBmWSO?=
 =?us-ascii?Q?CNCAVtniMMu96NiYtKmCHW27TKdmB9hLpGuLBq/+so/TBm41Qi/xJ6hX8Hei?=
 =?us-ascii?Q?HZGgzQIELefbrXKWssBpvLGghLpR6+1DL1NncNEUi1Uxli6EDlhEYNOBwc5z?=
 =?us-ascii?Q?11lTqAf+sKOQRe4/T6BQ7qVc9aTrhfJNm7NVgTkyjmayhLihWTH+Wv7yJleM?=
 =?us-ascii?Q?92OJmlbXO+ppO4SIa56JlBHEmm1h+YkvZ7x52DgUspHUywWjf4/AxipC8dmN?=
 =?us-ascii?Q?EuMKnJ8z4Yri/kn4GpXNOueaWOi8g7Y0rX1GxFggKXW3Ntb4wyxKt0sAGNY/?=
 =?us-ascii?Q?JVJpPQT9vZ/EL2ZsFMjIhIc1BWSc/BzHjHfcLuy8CRV8mueim0bXaXDpNNYf?=
 =?us-ascii?Q?V7Yxja8J9VDAtwNFoGRlw6AFDYvx6GH8ygUwCijiPrvTdRY3U+kVYEPl3Ade?=
 =?us-ascii?Q?8mduyc0vmdhflojAvaEN+OKFWActG4QuYpMdlMYPxFkCpDJ2oGiqj43PeaU4?=
 =?us-ascii?Q?EcquZ1x5inoJ1akEdXYreSlxaA6mKlRBZ75+excpbXbX/h19e/3U6Kkfq5GF?=
 =?us-ascii?Q?4wh467aO8Tn9ufQ43ORNIW2dqdDKszrVmll9C/Fn/exyy7J6+IZ3+d4j5p0X?=
 =?us-ascii?Q?YDop7uY7OsNINx5DPLGiGxYc5+U9pQSimOx4HvoRk1dIa8pn7HJFq6ZdlKgx?=
 =?us-ascii?Q?DY6cu8I7EJOfclRE809PXWU/DcGybtvN758+bMUFVEqqCzVc6iVh9fmLlmjI?=
 =?us-ascii?Q?bp+oe9iIPA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7670d938-fed7-4406-86bf-08da2766ce4f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 09:26:13.0155
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UfCLtC2fR9KEhmyBPbtiqninr+VcoCkw4S5FRcR2I/3W/ua4VH3UU5NEd/Zl9wowaNTnWJFiY5OLGm1spuGyPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3982

On 14.04.2022 18:02, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 14, 2022 at 04:15:22PM +0200, Jan Beulich wrote:
>> On 14.04.2022 15:31, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Apr 14, 2022 at 02:52:47PM +0200, Jan Beulich wrote:
>>>> On 14.04.2022 14:40, Roger Pau Monn=C3=A9 wrote:
>>>>> On Tue, Apr 12, 2022 at 12:27:34PM +0200, Jan Beulich wrote:
>>>>>> While future gas versions will allow line number information to be
>>>>>> generated for all instances of .irp and alike [1][2], the same isn't
>>>>>> true (nor immediately intended) for .macro [3]. Hence macros, when t=
hey
>>>>>> do more than just invoke another macro or issue an individual insn, =
want
>>>>>> to have .line directives (in header files also .file ones) in place.
>>>>>>
>>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>>>
>>>>>> [1] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D7992631e8c0b0e711fbaba991348ef6f6e583725
>>>>>> [2] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D2ee1792bec225ea19c71095cee5a3a9ae6df7c59
>>>>>> [3] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3D6d1ace6861e999361b30d1bc27459ab8094e0d4a
>>>>>> ---
>>>>>> Using .file has the perhaps undesirable side effect of generating a =
fair
>>>>>> amount of (all identical) STT_FILE entries in the symbol table. We a=
lso
>>>>>> can't use the supposedly assembler-internal (and hence undocumented)
>>>>>> .appfile anymore, as it was removed [4]. Note that .linefile (also
>>>>>> internal/undocumented) as well as the "# <line> <file>" constructs t=
he
>>>>>> compiler emits, leading to .linefile insertion by the assembler, are=
n't
>>>>>> of use anyway as these are processed and purged when processing .mac=
ro
>>>>>> [3].
>>>>>>
>>>>>> [4] https://sourceware.org/git?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h=
=3Dc39e89c3aaa3a6790f85e80f2da5022bc4bce38b
>>>>>>
>>>>>> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h
>>>>>> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h
>>>>>> @@ -24,6 +24,8 @@
>>>>>>  #include <asm/msr-index.h>
>>>>>>  #include <asm/spec_ctrl.h>
>>>>>> =20
>>>>>> +#define FILE_AND_LINE .file __FILE__; .line __LINE__
>>>>>
>>>>> Seeing as this seems to get added to all macros below, I guess you di=
d
>>>>> consider (and discarded) introducing a preprocessor macro do to the
>>>>> asm macro definitons:
>>>>>
>>>>> #define DECLARE_MACRO(n, ...) \
>>>>> .macro n __VA_ARGS__ \
>>>>>     .file __FILE__; .line __LINE__
>>>>
>>>> No, I didn't even consider that. I view such as too obfuscating - ther=
e's
>>>> then e.g. no visual match with the .endm. Furthermore, as outlined in =
the
>>>> description, I don't think this wants applying uniformly. There are
>>>> macros which better don't have this added. Yet I also would prefer to =
not
>>>> end up with a mix of .macro and DECLARE_MACRO().
>>>
>>> I think it's a dummy question, but why would we want to add this to
>>> some macros?
>>>
>>> Isn't it better to always have the file and line reference where the
>>> macro gets used?
>>
>> Like said in the description, a macro simply invoking another macro,
>> or a macro simply wrapping a single insn, is likely better to have
>> its generated code associated with the original line number. Complex
>> macros, otoh, are imo often better to have line numbers associated
>> with actual macro contents. IOW to some degree I support the cited
>> workaround in binutils (which has been there for many years).
>=20
> Seems a bit ad-hoc policy, but it's you and Andrew that mostly deal
> with this stuff, so if you are fine with it.

Actually I think I'll withdraw this patch. After quite a bit of further
consideration, it should really be the assembler to get this right, and
once properly working there the directives added here may actually get
in the way.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:36:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:36:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313612.531237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHci-0003oC-Fj; Tue, 26 Apr 2022 09:36:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313612.531237; Tue, 26 Apr 2022 09:36:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHci-0003o5-Ck; Tue, 26 Apr 2022 09:36:44 +0000
Received: by outflank-mailman (input) for mailman id 313612;
 Tue, 26 Apr 2022 09:36:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YDip=VE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njHch-0003nj-Fc
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 09:36:43 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 612a2529-c544-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 11:36:42 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C2CDB1F388;
 Tue, 26 Apr 2022 09:36:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F80D13223;
 Tue, 26 Apr 2022 09:36:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mQLCDSm9Z2IYOwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 26 Apr 2022 09:36:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 612a2529-c544-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650965801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=EUQK0UrRdBk8Q2sGZ93kmWFjUqFp5PWkpPtI0Lm2aRY=;
	b=gvWd353VWSRyhGWYpimQX7SXcbn7XsHgb6+XaL3pkb6m2iMa5Q/slz24DEoqEXuAmpQ2yL
	itCgfBRlISGkb0HGvoUHJa+5xwQ4mVJpI1la2KXF1qGAVGJGpMZaLq/KOqDDXoFngrjLHC
	BX6DvnP0D5iUv9fqmoCoExsoLxMcP1I=
Message-ID: <cbd4cd8a-0271-5a53-4688-59d6cc6ee3db@suse.com>
Date: Tue, 26 Apr 2022 11:36:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,
 x86@kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Tom Lendacky <thomas.lendacky@amd.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
 <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
 <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com> <YmcR5bfaYh1z7VUq@zn.tnic>
 <7d89848a-3a1c-415d-957a-564ffdd3712d@suse.com> <YmewJaxWS1KGVkTf@zn.tnic>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
In-Reply-To: <YmewJaxWS1KGVkTf@zn.tnic>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------MEdTqrYFN27Y5WG0EBQDaTQK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------MEdTqrYFN27Y5WG0EBQDaTQK
Content-Type: multipart/mixed; boundary="------------0rFmA268sw5cKzSrXO9Tr00V";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,
 x86@kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <cbd4cd8a-0271-5a53-4688-59d6cc6ee3db@suse.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
 <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
 <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com> <YmcR5bfaYh1z7VUq@zn.tnic>
 <7d89848a-3a1c-415d-957a-564ffdd3712d@suse.com> <YmewJaxWS1KGVkTf@zn.tnic>
In-Reply-To: <YmewJaxWS1KGVkTf@zn.tnic>

--------------0rFmA268sw5cKzSrXO9Tr00V
Content-Type: multipart/mixed; boundary="------------xZCHaritzSJ0S00pyzbCiDcg"

--------------xZCHaritzSJ0S00pyzbCiDcg
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjYuMDQuMjIgMTA6NDEsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVHVlLCBB
cHIgMjYsIDIwMjIgYXQgMDc6MTY6MTZBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN
Cj4+IENocmlzdG9waCBzdWdnZXN0ZWQgKHJhdGhlciBmaXJtbHkpIHRoaXMgd291bGQgYmUg
dGhlIHdheSB0byBnby4NCj4gDQo+IFllYWgsIEkgc2F3IGl0IGJ1dCBJIGRvbid0IHRoaW5r
IGl0IGlzIHRoZSByaWdodCB3YXkgdG8gZ28uDQo+IA0KPiBXaGF0IGhhcHBlbnMgdGhlIG5l
eHQgdGltZSBhIGd1ZXN0IG5lZWRzIHRvIHF1ZXJ5IHRoZSBwbGF0Zm9ybQ0KPiB1bmRlcm5l
YXRoPyBNaXN1c2UgdGhlc2UgaW50ZXJmYWNlcyBhZ2Fpbj8NCj4gDQo+IEJlY2F1c2UgcGVv
cGxlIHdpbGwgc2VlIHRoZSBYZW4gdXNlIGFuZCBzYXksIGhleSwgbG9vaywgSSB3aWxsIHVz
ZSB0aGlzDQo+IGZvciBteSBmdW5reSBIViB0b28uDQo+IA0KPiBFdmVuIHdvcnNlOiB3aGF0
IGhhcHBlbnMgaWYgWGVuIGRlY2lkZXMgdG8gaW1wbGVtZW50IFNFVi9URFg/IFRoZW4NCj4g
eW91J3JlIGluIGZvciBhIHdvcmxkIG9mIGZ1bi4NCg0KQXMgdGhlIHN1Z2dlc3Rpb24gd2Fz
IHRvIGFkZCBhbm90aGVyIGZsYWcgdGhpcyB3b3VsZG4ndCBiZSBhIHByb2JsZW0gSU1PLg0K
DQpCdXQgSSBhZ3JlZSB0aGF0IGNvY28gbWlnaHQgYmUgbm90IHRoZSBiZXN0IHdheSB0byBn
byAoYXMgSSB3cm90ZSBhbHJlYWR5KS4NCg0KPiANCj4gTm93LCBpZiB3ZSB3YW50IHRvICpl
eHRlbmQqIHRoZSBpbnRlcmZhY2VzIHRvIGhhdmUgc29tZXRoaW5nIGFzIGdlbmVyaWMNCj4g
YXMsIHNheSwgcGxhdGZvcm1faGFzKCkgYW5kIHRoYXQgc2hvdWxkIGJlIHRoZSB3YXkgZm9y
IGdlbmVyaWMga2VybmVsDQo+IGNvZGUgcnVubmluZyBpbiB0aGUgZ3Vlc3QgdG8gcXVlcnkg
dGhlIHBsYXRmb3JtIGNhcGFiaWxpdGllcywgdGhlbiBzdXJlLA0KPiBieSBhbGwgbWVhbnMu
DQoNCkkgYWdyZWUuDQoNCj4gDQo+PiBUaGlzIGlzIG5lZWRlZCBvbiBndWVzdCBzaWRlIGF0
IGEgcmF0aGVyIGh5cGVydmlzb3IgaW5kZXBlbmRlbnQgcGxhY2UuDQo+Pg0KPj4gU28gYSBj
YXBhYmlsaXR5IG9mIHNvbWUgc29ydCBzZWVtcyBhcHByb3ByaWF0ZS4NCj4+DQo+PiBBbm90
aGVyIHN1Z2dlc3Rpb24gb2YgbWluZSB3YXMgdG8gaGF2ZSBhIGNhbGxiYWNrIChvciBmbGFn
KSBpbg0KPj4gc3RydWN0IHg4Nl9oeXBlcl9ydW50aW1lIGZvciB0aGF0IHB1cnBvc2UuDQo+
IA0KPiBUaGlzIGJlY29tZXMgYW4gaXNzdWUgaWYgdGhlIEhWIGlzIG5vdCB4ODYgLSB0aGVu
IHlvdSBuZWVkIGEgZGlmZmVyZW50DQo+IG1ldGhvZCBvZiBxdWVyeWluZyBpdCwgd2hpY2gg
dGhlbiB1bmRlcm5lYXRoIHdpbGwgY2FsbCB0aGUgYXJjaC1zcGVjaWZpYw0KPiBpbnRlcmZh
Y2UuDQo+IA0KPiBJIGRvbid0IGtub3cgaG93IG11Y2ggb2YgcXVlcnlpbmcgZ3Vlc3RzIG5l
ZWQgdG8gZG8gYW5kIGhvdyB0aGV5J3ZlIGJlZW4NCj4gZG9pbmcgdGhhdCBzbyBmYXIuIERl
cGVuZGluZyBvbiB0aGUgcmVxdWlyZW1lbnRzLCB3ZSBwcm9iYWJseSBzaG91bGQNCj4gdGhp
bmsgYWJvdXQgYSBjbGVhbiBkZXNpZ24gZnJvbSB0aGUgZ2V0LWdvIGluc3RlYWQgb2YgaG9t
ZWdyb3duIHRoaW5ncy4NCg0KWWVzLg0KDQpwbGF0Zm9ybV9oYXMoKSBkb2Vzbid0IHNlZW0g
dG9vIGJhZCBJTU8uDQoNCkkgd2lsbCB3cml0ZSBhIHBhdGNoIGZvciBzdGFydGluZyB0aGUg
ZGlzY3Vzc2lvbi4NCg0KDQpKdWVyZ2VuDQo=
--------------xZCHaritzSJ0S00pyzbCiDcg
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------xZCHaritzSJ0S00pyzbCiDcg--

--------------0rFmA268sw5cKzSrXO9Tr00V--

--------------MEdTqrYFN27Y5WG0EBQDaTQK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJnvSgFAwAAAAAACgkQsN6d1ii/Ey/H
Awf+OWyEuHlu+jo4GkGrpUTd1hChqcn6K5a+V6S7bfOqp0oHIurgszQN9Siz56jgGXrIaHEGsPIh
sc2hEa46FXLZsBUOHbaxma8m0C+nGLw3WPMa2JJBumk2kI6mP2hkZlpgmdVH1Md8+W4J4gA4eV80
lAp/xRqVyuppUbr+BEgxTVlPw0utV/wxP9ZUnvSMFlWEBI83Y3TFZBGyfo0ADIuFYPRkCCs7qRhC
EIHe5sVASG18BlfRy+qmdX9rainyhwK9CESLO3dpFOocsa/gD8VHknmxOssKBpt4b7P8SDQateeL
AmZK/5+s+hS4VLvtwWQysUA8Wgf4tksIB83pXwzvJQ==
=UGmD
-----END PGP SIGNATURE-----

--------------MEdTqrYFN27Y5WG0EBQDaTQK--


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:38:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:38:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313619.531248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHei-0004T3-1O; Tue, 26 Apr 2022 09:38:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313619.531248; Tue, 26 Apr 2022 09:38:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHeh-0004Sw-UU; Tue, 26 Apr 2022 09:38:47 +0000
Received: by outflank-mailman (input) for mailman id 313619;
 Tue, 26 Apr 2022 09:38:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njHeg-0004Sm-Is; Tue, 26 Apr 2022 09:38:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njHeg-0000tP-HD; Tue, 26 Apr 2022 09:38:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njHeg-0000pi-7x; Tue, 26 Apr 2022 09:38:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njHeg-00010d-7R; Tue, 26 Apr 2022 09:38:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UyH+YGqE+KszI4Jiylf5TMiYxGwNCjYrzHNezHtYYxI=; b=eYV71V3vjkp5F3jvj5Ln2Nl+WA
	RLuIqPvHCKchdXBlbiGLaB4/6rg2cV2r5sHc5I0TpEPcBvnA3VkzZQ0zTayTfbRrwqBBzF+wd6K0h
	5QHGDOMS27WTaTc1PoL+ebYNbw+Za6o/fUim0zNJXFcmz3dbwRQb+94bQpARjiUR5yjo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169730-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169730: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 09:38:46 +0000

flight 169730 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169730/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  636 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 09:43:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 09:43:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313627.531260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHjM-0005sg-LB; Tue, 26 Apr 2022 09:43:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313627.531260; Tue, 26 Apr 2022 09:43:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njHjM-0005sZ-I4; Tue, 26 Apr 2022 09:43:36 +0000
Received: by outflank-mailman (input) for mailman id 313627;
 Tue, 26 Apr 2022 09:43:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njHjK-0005sT-MY
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 09:43:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5648841b-c545-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 11:43:33 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-8miIKrbOMcS4MvmG43Q9kg-1; Tue, 26 Apr 2022 11:43:32 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0402MB3519.eurprd04.prod.outlook.com (2603:10a6:803:8::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 09:43:30 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 09:43:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5648841b-c545-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650966213;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aBsKKHlyLqmSn2knHH9wbNuOYlQtIABaamErmqRjfhA=;
	b=g0KafCneORV4Z+VcEBS6DMHMjocH4OBdInoqHkJD66ll+r2yke1UVs2Qb+w8EREocV2tMQ
	5IneNlvQmBU7ha9c07+XBjJT26nzbIeDodEYNhCMhUoChBo2vQlTIyyaNGKb7Kf8RaL6Mi
	/NPflKE+rMDSlRrKu/B3K5xUJLwp1QY=
X-MC-Unique: 8miIKrbOMcS4MvmG43Q9kg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m0LkS7shb2rF/UkJXwtsY5DImXpZ6zWwq2DQcty4kg44wTpE+nfZ4LlPjrDjST6C5pYwnEALufqW3TCzUhx7BDn4+jqrF4jXDOWQwBe+bUFigGmfANpdjHgiFzzfGGyG4ff8hSiGHcN238KLmonjv1VVBUgK1sJWhRk98S8rYf9GforyncLcG/c1K/L/8gv6DGxCwIhoQE/qGBEBI25KP1vnx9sIQegynldK9g18ugc7mIS7/fwj4Kh1hgOSiQEp1n4UqYxY6vlnZCCyK6fhrCchyhCT5exsBOUDrM9nrnz82iuiImK6o2B926I0dYIU60JilKoP/6+JLya1GZG41w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aBsKKHlyLqmSn2knHH9wbNuOYlQtIABaamErmqRjfhA=;
 b=RRVdTnwLy95u3ADtpxuDRlgYHfAQ+9xuuh4NBMu2nDV4rAa/KdKfbr/AbfpRhiBCj8pbcDjiGmvjXPhx2Fvd76A79u7M17/wukuPN5sIy3D3YnDAot4O5VCVPePPlokXSTJ4O+otRNBX/XDySyS24MGL63uyIL5gSpwiopddZF4zlUCbHU0BLMDdUyMfjrKx1omZ5x5jUk2pR1Awbp5Elbig3iz+/FdG8wi2RvN5PFIuFvOdYdQ344rxGbNqkxjYl2ubQbvU/JgZXF4QR9jNvc7QlnJvHMFHOw9zhpNYYzWn7Z3k5cZe0OtwhtvsTV9fN9UdWhtoujPSoQW4VUsMsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2942e8ed-e839-c3d7-69af-25f926d11da0@suse.com>
Date: Tue, 26 Apr 2022 11:43:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/public: add new macro to ring.h
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
References: <20220426090810.28616-1-jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220426090810.28616-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0015.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9586b037-2941-498d-e22c-08da2769389d
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3519:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3519B157645819EB4430CC10B3FB9@VI1PR0402MB3519.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	irX1JomIHdpE54To9qz5lsCpqolsy58Kcm4D/8+NajzBqUmLKWZzsmi9HKslXHaI60v9itagD+85OI96yfiePzK2IvtaxxAgtWhSB8IYonRVTjTKJQHBxWH8pisVN5CnSvNvQJkUaF+/88fy/462EQM80Csq7rRr8r7yZ+efx45ZIceFCejxJCwSeeje3QmCbJCkyfB+Eh4VIDbAl+XTnyMJi+veMUV5H7xLSoK9EiRa3Y31RxZeA/7JUwojsdACwS6DRqgCpU1Co/3DdxRqUlVX7Xt5DxXZF839a37dKrmZer5ZETGB1m4r8e+/WpVP7+H2+v4wSispJEYvmT8Ozdj0M3ni2BPwVGFu4HglWZP1BLJK4z8FjoUu3GJDhpPNk85fIcdLwzXRX3SW5Uh4RiUj37inoUFjwnw6N8XgL+edhApc4nsZvBSXirmEWg11T8Vaq7/L8tkUGqCfSza/dBfFNrmn2n70rS7MMPe96fgrCEFHdmODd9U5k6qbVsTp0B4BMQ8r2Y753sXDRWHMjVyqkay9q9U5CsnOHzdcyFQHzZFSUqfxAoVkWJbzuKONQW969MtWPnbaCRxMpny2ZPGNXDVWTeVVqb4T3TpJQKc7ZC69i7MWDXshzi+X6aBgLeRpkURrIK9YjmP3mf0sDYck0DluR35pOQxq0P4XcR2PDNA1GHhaWKSkbQlfoVBXxjDgnLO8/LNsRv/c3ZR4ujytKApuKwQJKpffXPRUyrVbYoSbPEEny+T4/QTXz+z/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(66946007)(66556008)(26005)(66476007)(38100700002)(6486002)(37006003)(4326008)(508600001)(86362001)(6506007)(6512007)(31696002)(186003)(53546011)(6636002)(2616005)(2906002)(5660300002)(8936002)(4744005)(36756003)(31686004)(8676002)(6862004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eU9CYmZ1QmR6THdUWDRmMCswSy96WU8zbS95OTFCNUZuajdrZ0tYeE5vK0Jw?=
 =?utf-8?B?bG14N1Vxek83VCtjR0Y1WXF3Y2ZYRkp5d2ZmZU1SU3V3YldZaUw2UnNsQzVs?=
 =?utf-8?B?TTlGZmhFRDhISnNFb0pxT1NqN1lzZXdQZkNCQ0R2enNFM3ZjRHpqR1d0Rk1S?=
 =?utf-8?B?S3FjTXhyVndQcjVyM0VLWTlwcUxsWUtZNnpxdnlkK2lvbXdFZ2lKeVhMZk9M?=
 =?utf-8?B?QXUyTXgzUmxyRjBZSk9CZDhNbnBIYXhCdjFobzBzSXFXRjVXTm1YMVBITEE3?=
 =?utf-8?B?UXpwZ0RuQjA3UTVxWUZjak5TeXlnVU1qMk5LWWU5bU9jZ0xWeE1CL3J1ZGlh?=
 =?utf-8?B?aWxZYlFBTnNrN1U5WkhMaklyZ20vUU5Tb2FGcytlbTRybHVxUEpKN3NqOXFH?=
 =?utf-8?B?YmY5K2lsaThxWFBONWZZVUlBcGdkWDh1aXo1QnVMY0cvaVBPWEV4Q0lqbm94?=
 =?utf-8?B?UmEzNm4xZVNTZk1PdTJJY2s2RW1oYnZjcVc4REp0Z1RRbUxDQ1RQbEdFbHRn?=
 =?utf-8?B?V0s4bkFZeC95aDNXRVpnbEVjaWp4YjdzNkdYVFNBRkk2YjROZUFCS05VWXd3?=
 =?utf-8?B?MjhUNi9RNEV1TTVrS3NwbEFXR2c3cVFoYmVxM09OWGxLcjEyMU5Za1doR1dw?=
 =?utf-8?B?VmhleTlPTHVTc3VzSk9mTmtSZEJIbzRUOEhLWVAxZWU4RlJhWHhQN0xxUDYx?=
 =?utf-8?B?L0ZRSEsyNGloeTBlQ3Q1aWVkV0krT1FKSFpvVlYvV3U3emtNdW5oS0JwZXRQ?=
 =?utf-8?B?eGFhVGNjNWdzQ0hkc250VTFwNVJyQ3VvRzhMQ0U3Y0xINzZNL0ZxYmhWNXpx?=
 =?utf-8?B?Y0lGN0xRNE52bUlSSG8ybzljcldiUWxkTitwcDA4UHFDT0h5MG9YY1RFckpt?=
 =?utf-8?B?YjNUV2tTWWZUd21TeDFSUzR1dWdZWFA1NWpIZ3I4NDVpemZTc21POUlVdUdX?=
 =?utf-8?B?UkRPNW50SU4reE1PV2VPRTJBNUdyWDh4aDNqZjQ2V2JvZW8wUW9JN2R1VzlS?=
 =?utf-8?B?Sk9CdzdPMjFVYW0yc3BLNGd4eVJMbjlINENHWlB3RjhIUXYxd0xPcXk2VzNH?=
 =?utf-8?B?cm00aXVNRXY3TkZpdEVvYU52YUgza2pXSFh5ZmlpMGJzRUt3TWNtUXpLaUd5?=
 =?utf-8?B?K1BNREV0M1BndDJnVEw0cDBuSThhK2QzT05mVW9OYUw1MTFiOFZkblczLzdt?=
 =?utf-8?B?QS9ka3Y3Y1oyaHhyZU1uaDB2T2M1Q1NLZUJmR2t6akF2K29jMmtRR0Y3OUpT?=
 =?utf-8?B?eHF4MXNIRWJ1Ymt5N09kNGQybHhGeDl2UkxlTnkwY2RNSmdxT0QrcXgwUUx0?=
 =?utf-8?B?N3l4NEM4UHpkV3dOSmdKT2VqMW5uZk9EK2llZGNsU0pWR1A3d2ZUVC9zMkV2?=
 =?utf-8?B?MVA0RmJOcDhsNVdKcnM3V3RSTjM2T0h3TUh1ZXRVZzY5eFNKN2hkQ3ppcTNC?=
 =?utf-8?B?RWFyVndNRC84YURmQ1B4U3krSkxzeGJoUFQvUXVyMXdKdHBEZFBEd0F4SCtw?=
 =?utf-8?B?UXl5dG9oWW81a3pKZVZtY3pWRXpCMlBHUGRGdk5LYWJqcnZuNkNRdVNUZXB4?=
 =?utf-8?B?NFROY0pBZE9TamN0RlpqNnp4QnExUEJzZ3B3NHgvU2RMMENwU2Z2YStGczJT?=
 =?utf-8?B?RWI1dnBYanFRWEljNis0dC9Lelkrd3Z2MFhYU0hTb2YzZUw5UUFBMktSUWFF?=
 =?utf-8?B?UzNndFU1dUxRam1hVVl1MDlJNTJoQURrcWVhZGdWWDRHL2tzamd4MlFJeGVY?=
 =?utf-8?B?MklxMzlmL1pyVFlPWWt2cmNJYjViZUZQVE5ab1ZmVi93SkYzZFJERjdUaFBT?=
 =?utf-8?B?cFNpQmV4TExFL1dwTFdWaDlGOVBraitOamRNT2pwNFBQUGErQ0pwcXJydEJp?=
 =?utf-8?B?UHl5ckFlUFhVdGdkT241VjN2eURGR1haOVptcGhveEdoeXgyZEt4L0lHU3lP?=
 =?utf-8?B?VnJQVWdaSFlNeXJBWFRibzRtL2dNaU1USHllMFhJRlNWSmFwcE5vdXp4YzJ2?=
 =?utf-8?B?QnhDMGFZS05FS1BJalVqTkRpMUt3TzhSbEFYcFhuTTJmK2xxR1Zxdm4rN2VV?=
 =?utf-8?B?MXZkTTZBcVF5Zk5nYlplK3Jzd3lMMlJpN2hUaXdzbUVJRWFmMGYwQ2svRDE5?=
 =?utf-8?B?ZXhwbVhYV1ZKMm00T21jbmEvQjFPN3dORXlGMUFPbWV6bmxrRU9ra1hiaWo1?=
 =?utf-8?B?WGtvS0RjU1UzMDZweGQwU3RibTFwSGpjclYwUkJLdXQ2bGlRaDZUN2NldnJU?=
 =?utf-8?B?N1VBelY5ZzhVMktsUDM4QmVDb0F0YzBpeDE4QlkvZEorNTJYaXJDSnFFVXBz?=
 =?utf-8?B?OEpMTzFma2s0QXN4N2t3aFdKOXlhYUhZZnoyK2M4SXd6bWFVbURJQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9586b037-2941-498d-e22c-08da2769389d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 09:43:30.2672
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p1/1msx7KTa/Cv4WMVGjxBR1aKfdJqrKXjx+qWPX6r5j3q32hcyNKm6iiUeEsVTCeHWpSRYH+MfzxevpfNrAtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3519

On 26.04.2022 11:08, Juergen Gross wrote:
> --- a/xen/include/public/io/ring.h
> +++ b/xen/include/public/io/ring.h
> @@ -184,6 +184,11 @@ typedef struct __name##_back_ring __name##_back_ring_t
>  
>  #define FRONT_RING_INIT(_r, _s, __size) FRONT_RING_ATTACH(_r, _s, 0, __size)
>  
> +#define XEN_FRONT_RING_INIT(_r, _s, __size) do {                        \
> +    SHARED_RING_INIT(_s);                                               \
> +    FRONT_RING_INIT(_r, _s, __size);                                    \
> +} while (0)

I think it would be good for the comment around line 100 to also
have a reference to this.

As to style: Could I talk you into not further proliferating the
inappropriate use of underscore-prefixed names as macro parameters?
Even more so one with a double underscore?

As to functionality: I take it that it is not viewed as an issue
that many of the macros here evaluate their arguments multiple
times?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:04:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:04:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313633.531271 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njI31-0008JC-A6; Tue, 26 Apr 2022 10:03:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313633.531271; Tue, 26 Apr 2022 10:03:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njI31-0008J5-78; Tue, 26 Apr 2022 10:03:55 +0000
Received: by outflank-mailman (input) for mailman id 313633;
 Tue, 26 Apr 2022 10:03:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njI2z-0008Iz-42
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:03:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c0bb95e-c548-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:03:51 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-9pNfqGGgP6Gj0_s_zLXjOw-1; Tue, 26 Apr 2022 12:03:50 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0402MB2700.eurprd04.prod.outlook.com (2603:10a6:3:d7::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:03:48 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:03:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c0bb95e-c548-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650967431;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=yatpKeRHw67LhXWVtbu1bwRRmESxGbKhP7f48u5Z6qI=;
	b=D3bd3s4hDj9C0jRDHEDPzvPhvi2x59aM16y1ZYiYXWLn8AIREP12DEY9E2XAcoA9pKkPHb
	l4YEnPqD81klryv9XJbdSPqMeGm7ldSD2t+5n7RIdKDsjKPGou9xXkr6n426xnzOp2flXo
	xtKe0cVZ5NseMY5jp0934ctAkrhWoIM=
X-MC-Unique: 9pNfqGGgP6Gj0_s_zLXjOw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=efJ8a8ryHzgy+pEVjsD4svlRRg1CHQw8sleMwVsj71mxscvICN0FYnfNNhWxXt6XGkppOSSdqQqMGvKZ3RhagR46ki1XwbzGLXOl1hOj1TYIwRoIUOOokoAsla/0fcwR/2WobbY4AAcZoetDVGUzh3mKcs9bInJT024uEtgXWSJ0fh8C2MvueNUa57TRE71MERVzGV1fumFik003eL+zLDtrM9xqdcxFI+0+Nwa/+9wE67TJv5ZvAUZ9D9NyxPvls1OxyHs+PXiiSqeXrabxhyt2ee+FV+mzW0sQCZ7MTFuuzWLp5s0/ufi6K2oYvaBn0L3wXjX727xEan+OTQQIUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yatpKeRHw67LhXWVtbu1bwRRmESxGbKhP7f48u5Z6qI=;
 b=DXg8PsX81dfWiGFxHitDPIW2c6yXhmQ7Dlt3WdBEvEZ+iX4E0wX+29CErXPPrKsV8NuCcaByJjzzfT7OYaYUtWblrC4kY1WD2ycbT6A1CNkyu6YNYvfPsi2NNPOaatTXsNlBKYdJJYOMEPBtGXETeA2DKvyH2m46lFIsjlWYvGbPpSAh8eiJno2NeCc1Llsfatzwk96dvkXS5vkiV7McF+bdNFvIMdpTyNqknXLnpUwoK5xqOQ8P55OJIfyAOD9xDX7BA9kN0HP3vdJOu5sasQbTPfqA8qWqbQ3Z0J21YImo5ywaou0JY1YckDe0gGn7fFgJ6DSLFPl75h4C55LwNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
Date: Tue, 26 Apr 2022 12:03:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/4] x86/mwait-idle: (mostly) SPR support
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::21)
 To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cc1c67c0-8e33-4135-e528-08da276c0ecc
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2700:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB270050B26FAC0CB79A233EA4B3FB9@HE1PR0402MB2700.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cEbYRqZwfz33GNSyUBOuNKGzOJPGg/EX/Y+mG8wyq2zeITXgj4Pt059KlK0qDjb+xrKObO3QmDKjktgt/za7zZhFitmLL2aN0TGzJZ/Z1LssLKBlJ7MT2BlSQaeotW/WGbx2p+iUnXdlYyMLSxr7mcLQg/uKPQ3Zae5OpJwlVqmtEWwFWIISVqN7ehxrr1eLXbX9JHVFLMdqyicfpldr2qExZ1ySllG2QmGJ8DhLfELjq4r9x/mnFJW5yNszieHK6eXK4Q6Rv8Tf80DtBI4igspoK5iMZyQ4D9XLkfkBSgPCqIIfkGbxQaGBEkY/co8jxccR/zCGsNS+b2GytW7B0NMXmwUy7QTmKO0ATkbKho/RJtOBorLpqTDJLB7kGYDKLSQWkCwn9BqmsnPw8PVX3j0CY2rF9y6Rzoz4R7vi0STK2r0laDkp7ACwhcNS4aN6QoqaSX3zmGngvKErX886QopTaoZzyvdk3TVwe+tcipFV/dJzTm7IdbBNnnncRe7hUqWPtNFfUz45gpjYeRoTNi+SPM3L4+RXnEDe6cwqZgAOshI/zH834vwhSUd9BNyACfEnl2JZ8bfOu4JzE4aLXfBf9/N8QjJSm1YIitk06aADSVxfnIEk0UOHmbnw/Hx17ApRkpz4K/xSR3eW1qa74mCQdwMhuKC3+HYkq4VzSpGgnccbqb/sr8xWZO1j7j05au+R6jYhfdrprmPKV1jpAbJ7hpPnEtK8fzh2KMuebGc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(31696002)(6486002)(38100700002)(2906002)(558084003)(66476007)(8676002)(4326008)(66556008)(66946007)(86362001)(8936002)(316002)(6916009)(5660300002)(54906003)(83380400001)(26005)(31686004)(6512007)(2616005)(36756003)(6506007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SWd4VUJpV05iUHlGTXdUNHFIU1JlNFNNNXpBZDJtY0FJUmJLOWwveHcvYTIv?=
 =?utf-8?B?c3dNamYzVVdZNmdpVDBiaTAwb2NWSjJjMzVoQnNNbmIvSXN2WEhoNkVUSTNC?=
 =?utf-8?B?WjFHeHNiRDdlSVNGQWR2T044bU1OSDFZdi8xM0RROE9KbE9ZcmNodzZUd3JO?=
 =?utf-8?B?aWJIRm1pdEZVRkprT2Y2cEpjenZOci9YbUF4NnQ1M2VoKzRYMUwweTlNNlg2?=
 =?utf-8?B?ZXIxZmNVdFgvR2g5TjVCdjlua2hXUlpqTTZUaUhLZVNuMWZucWVoY3I2Sndn?=
 =?utf-8?B?ZXRFQlNXN0trMGg5NWpWYXlsK0J0cUNkZnNoRHN1U1N5OUNKUmhGR0NNMkJl?=
 =?utf-8?B?a0F0bFh6TXhCMGZZdDRwL2xZbjhDL2tOOFVGTHp4SU1YeDNFRGU0SzhPdm9k?=
 =?utf-8?B?SXNIbnRnQWFBRWVzeGJrV2h6VUxEMzFmMm5wTkRTOUg5NVhYZGtId2xRRXc2?=
 =?utf-8?B?V290QndtOTVzeSttc28yaE1Nc2VUNVRiN3BNVkZFN1dNU1lEc2g2cTB3SnI4?=
 =?utf-8?B?T0JjQnNwZ3pISGxVV2xvWnFHOWtqSjlUYS9qWVl6MVk5RFhyWW5SME1WRTZv?=
 =?utf-8?B?ZmFySGN0SExRdzRicDVzazJxNVB0aUgyam5HQlpMV3A2KzNub2g1TVdhbmlK?=
 =?utf-8?B?djE1cGx6ekgyRG9WM3BwNExTN0sxcTZNa3htQ1JBY2x1c2E5VlcyeW44ZDhr?=
 =?utf-8?B?UFFKbjEySFN1Q0I2WjRZc1diUjN6MWpDMm8zTllnaTRrdlozaWp3YlU1RGFw?=
 =?utf-8?B?OEZuK1BnYlpqdVRTNTlNZG9xb1hMK1dtMFR4NG5VVjVBTjFQK3BiNWpXczZK?=
 =?utf-8?B?cWRCdWZYejZFSUI3Wm9IZjhSR0UzZ29uRk83aGhjbEhCTHl5alVlM1J6Smwr?=
 =?utf-8?B?K2pCSS9TQnVMK2lZNWpTUWh3aC8xQ2d2aFVDZi9Ca2srQXhGTHFhZktYWERD?=
 =?utf-8?B?RElHbDdSOXd6b2MzbThmN24xdzFsQUpxVkdnR082bXRMZkFHT3NkSkNqRngx?=
 =?utf-8?B?ditIanJkeWpjdFNqRURMc2RRUnlnMkMwRm9BY0ViK1Q0cCtRaEREbzM0SXZy?=
 =?utf-8?B?ZVRIc3ArQnlhZlE5VVVYMTRqUk94b1hXY29wUGdwdHdCZEl6c01JVTNMcUZK?=
 =?utf-8?B?di96M1I4Q0Q0Q3BYaWtrYkVsNDcvc2txZlhmcVpkQnIvTkNzU1ZMZHlIRjdk?=
 =?utf-8?B?VWdZVStRQVRFeWptbnQzakIwcVpXdnhaK0h1UFpZdncrd2kxM1l1My9OdTVx?=
 =?utf-8?B?NjVOK0JUWHdsRnd1QXNPMW1KeFZyQmJTQUtzNG1jR3M0L0ZUZzNOMURETkZF?=
 =?utf-8?B?Z1BuejlLOWhmc0h6YU9CM054cmNDRkFXemhBakYzNzNKem03SHNMOUErOVFv?=
 =?utf-8?B?VGJsdTBqYXNldkVYTS9jbWNEVkdGK3FkbkpCT2NTYTlqMFNxRWtuVHIyU281?=
 =?utf-8?B?UU12ZjZ5M1plVG83a3Arayt4V1hDeElYejlTRlJjYVFiNFNoWEJFRkJ5bGtT?=
 =?utf-8?B?K2hqL0phbXdrZ0dZS1BId3J5K3pFNmpVbWNpSEpsMEZYMHdMTXE2UFk1ZCtW?=
 =?utf-8?B?V0F3V0tmcldzeGpFVWJXUGZqcXhvUDY5bWJQazlhZHlZV05xanE2U1BZMGdJ?=
 =?utf-8?B?MTRuQVBRSkpqa2tBc0hobHFDWmF6OURKQlNLcVV4VWFyMEZzVk1XNFVodVNz?=
 =?utf-8?B?THFKMGFhcjd4YXYrdUw3Zi8yVHk2OGU1QmlGTjc2MllSL1JJVUlHK1pOZjFl?=
 =?utf-8?B?OFlsZGZ5Vm5mSllKR1QxZkROOHo4cy9qWXZXd3JZdG9RemVzVzQwUWwrc3VH?=
 =?utf-8?B?TkZHTFp5SHpGR1FVSTJpRi9kTXVKRDdzYXJ3SjMyZks3bno4MGVoVnM3d3Uv?=
 =?utf-8?B?ZGNtVURZa3dLcHJveTFtaE8yQ09TZTh6VlJDU2E3M1gyOVdaUXpWQUFDYlh3?=
 =?utf-8?B?angyT3Z0amxIYXVGUEloZWhBOW1NNXo4K0NiZkFpU0NsVDcwQzZhNVZVMHdU?=
 =?utf-8?B?OTRIWjVzYUtwM01MRVdSU2VyWk8vd0E3ZlZwNWE4VE1mVUN0UVkrWEJGRWdT?=
 =?utf-8?B?WDR5NjlNemZxUVBoTUwvTVdTMSt6UE9HM2p5bWNmV0w4L1hOcS84OE1VRmMx?=
 =?utf-8?B?bWxMQmpKS1N6TFdGbGRlOTlrYW0zZ2Rlc211SzIzR3AyZ1ZkbDRITUNibjhT?=
 =?utf-8?B?M2VlNjMvTWh4VVJhQWdkWG1oaGVVUUJGVFRqMytzeXJ1UVY4Zm1qc2VvQ2Qx?=
 =?utf-8?B?eTRXcDA1NG0rbFM1WjNKeENuQzV5QTcrcFQ2MkRKdmpHNnlOTVB5TEZ0WTE3?=
 =?utf-8?B?MmR5SzIybU5qa2ZKT216OEVnT0ZNMjl5RktJZ1NsZVVIUUtrRTZkdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc1c67c0-8e33-4135-e528-08da276c0ecc
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:03:48.6325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AjKj94vOajl0UEr34MZOE74dXjM9sVZ4JwdhyXJAlKNTjMSIZA+qSZ2rBE+ee1iOxEwJDjvmdsY4yNCUzolqjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2700

Fresh from Linux 5.18-rc (and with adjustments to address issues noticed
while porting), except for the 1st patch.

1: switch to asm/intel-family.h naming
2: add SPR support
3: add 'preferred_cstates' module argument
4: add core C6 optimization for SPR

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:04:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:04:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313636.531283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njI3w-0000Ns-Mx; Tue, 26 Apr 2022 10:04:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313636.531283; Tue, 26 Apr 2022 10:04:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njI3w-0000Nl-HA; Tue, 26 Apr 2022 10:04:52 +0000
Received: by outflank-mailman (input) for mailman id 313636;
 Tue, 26 Apr 2022 10:04:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njI3v-0000NY-Mo
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:04:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4f45fbac-c548-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:04:50 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-x_HgQ9plPkSOtXWqm449xA-1; Tue, 26 Apr 2022 12:04:48 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB7358.eurprd04.prod.outlook.com (2603:10a6:800:1a5::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:04:47 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:04:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f45fbac-c548-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650967490;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nfvkLKxgZzpvNh45ZE00gKlfe5dLJE1wRsQWU7S2WTw=;
	b=dmBEL6ci7IJVafYDD8mRxnxqUBaa7QccA2bOj4TtcMcqnOP5rj11yVDfRW+pngA0FuO3Mi
	4GRdrAEO0Qn9N15M4aGHaoXmHJ0bNrQ1dI/as5FVkju1kBXA0wbogre+wCZ4gh1ZVNkFI9
	aaCvXyz1BXdGWke+Sa+tzb8lFqr1EFE=
X-MC-Unique: x_HgQ9plPkSOtXWqm449xA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PAz+FdWzrIJ+uQarPrKlgDZRWGEO24nSTJhhJgbW39Y/91X7auGdApdW4WBvsgJi3v70L+bJdi8VUnNHxKQNcEiTU7XgmqT7y8mfRuudtzDUQyTMxGMA83rAMY0fvBc61aSBXpV0qH0euqAqGcle3A0aW2NIhySlmWRnh4xugEXvFjxgUZ8BnXqoocK8xM/HSUzaC1VXYZsiHotdCxA6CiXXbq2SzH9P7WU+QpP/bOr1xaBGbfYqElPVkrHFEwlRYST9QtfCGHi79fHm+jIE+nLq2sCUOQ5qIwzM+BA3Oq58tus32XBpmEEL3vWiih74OBEslIV9URtuSNbDy9qKCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nfvkLKxgZzpvNh45ZE00gKlfe5dLJE1wRsQWU7S2WTw=;
 b=J0rwVSM9JCqGuJm04XFmAE8avLQbMgghsc47M2yGUpI15jCV1KPZQGUcBC40XE2KRrPa7D3ci67UGk+J90M4pf+9iBjX8NuXyaA7+OYq8rQAQxWU1T4QFfllLuw5AofQlkHDd8zbPywIhu3q0cRVKFoTMGQ+h3FRgE7Eyyb2ckxoZgOfc6ga/3YLw+rYC92ItXnoFwwmYRBghjmGFw3E0OIIJgP7mOjntvtWgjIErDuunj3/Xsm40BZnAgTX5S12U0Xl8XAGMCKMx/eLFAKvkcXDc0K9nVTnoUmyGEgb4LKDm2FwWX5aDp0JtLHgSM/u7XzVijJNBsY+hZuDw4lhaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <974cdc87-cae1-2c5a-4c3a-98c5d98a5425@suse.com>
Date: Tue, 26 Apr 2022 12:04:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH 1/4] x86/mwait-idle: switch to asm/intel-family.h naming
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
In-Reply-To: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::17)
 To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 28725fb3-0321-465d-df02-08da276c31ae
X-MS-TrafficTypeDiagnostic: VE1PR04MB7358:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7358BBFA6BF4A7B50F3AB59AB3FB9@VE1PR04MB7358.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UWde5jewysNqQP9v9Q008uj2g2kEB78DSO7jKcQmU3teBs/zPCVHBJcjwstdzPh+ECiWR9P/CYJ/yt+MlFwE3sks0+zj/bO7wZpOxUl2JtZOvwyi05Jsr0RA+tb4SSmfHNfiFRT1YhTdMZhHDpJ7Cfy8xqlPlvvokZv1gdsc9/rR20UnXzsEtlIsa+7tOZzRVZu31JnhzFXoCJbblDEM+SB+iIHeZofRu3DOnfkhFzu64eocjCfsFj4znkf5Dn0NePnT9tVY0Cs+KzjbcgeeB3ose5UzO6+rnbdJK3zmyzS7CWIyQeHhtrYcgM25Ub5WGqmyEnxzZsKQOsk8rZRqml07h8rytQuqr1u7ggvBS8zm2Xjmtch4lUC/GbcT9v9ikO5dU+W4IIyyQ+5okmeNxpiDj2vuVMhv3PxGP65DcLyJbK4TAOeGLfVNWYtOokTczv+471rRG6I59zG3pidnNEWjNuqaZhDFYF1weRAgx1TzBaDnxGG2PKboP5CDhiApOHV7OYk8KUsNvn6y2VRWUBZqBDWWdrkheULbMA8Z18sCezG4TdvU9UfztPHbA+PsuTxMu50u4Tb2NTiWNbb63D4sbiEKOeORvqOe1DY3/iQftF8Edb5j9CwziDX/jrGNLyj4hcNGzFfswKS9nrYOvWw25wEO/zkQT2ZD3Cdahl0W83VhY46oQR44O16zWb/OCS7VrjpIyOI/Tw2gZbav4PkuR2mAH3fzx0hOtIVMEgzXEFetywFS7CG/j/eWEKiT
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(2616005)(8676002)(5660300002)(186003)(2906002)(31686004)(83380400001)(316002)(54906003)(6916009)(6506007)(66946007)(66556008)(66476007)(26005)(6512007)(8936002)(6486002)(31696002)(38100700002)(508600001)(86362001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YlladmJJZEZJQlVSTDVSVlBmeVlLL2pTUFZSaC8wb0xxb0VJVjNuNU9ycVF0?=
 =?utf-8?B?YzcwTStiWVNXZDZqYzhjeFRMWTBYcGIydzVtVHpWOUlSSGRjcTY0VVN5TkJw?=
 =?utf-8?B?NnRrTTFCUTBKYlJ3TXZUdDZxMFp0czY1KzdrMHBYUm9zaHFQYVRpa3BKM0RL?=
 =?utf-8?B?UFdFNHBkbEpaaTUrV2g0QUVlM2Rad2xualdxanc2K1hhdmhLN3R0WEZiT0JC?=
 =?utf-8?B?WGNITkYydFNkOXBHVGIrUWxybDdYTHRzR3k4Q1ZkOElVL29PSk1kKzlKRDVQ?=
 =?utf-8?B?KzRHcmNkRG1OdU9LTUx1U2tXa0pLNkZxUnV0cHFTUDZFQkZkWmRJdTFjR2tp?=
 =?utf-8?B?WWNGdHkvZ2t0V0NuWm5EcDJNb2VZbWtjSGZpVGRwNnlrSEdtUTFTSW9pODVN?=
 =?utf-8?B?K0FGQzUyMVJhMXNVRXY2Z1B4VkJSQWh4RU5qM0s3ejNhaXBob2N5ejgvQ2RF?=
 =?utf-8?B?NTJUS00vN3ZPa1JmSmkxdG52aGNWbnhYQmhsbEZxUHh5ZjRpRDY5QWhpendC?=
 =?utf-8?B?azFyS1l2UEdFc0RWQy9YQXZ0b05kc0xNVWllMWZ4dE9NOUpuWTErWG0zVmJh?=
 =?utf-8?B?dDQrekthTXhmTkUyWTFXWEtyeHRLUStnRXM4eTdtUVZSZWpzTlcyeGY3UjY1?=
 =?utf-8?B?dTRUbmRXN2ZRek1OVVlsMmFIWVFVZTdIZEhDN0pRWFYxWlBLeTVEVENEeE40?=
 =?utf-8?B?MVNBTlRRZkpway9wTitFWElDMlBMWUQwVTdaRDFYYjVJWnY2N3JOK2FFWXpP?=
 =?utf-8?B?QkFJNk1HYXl6UnEvMVUrQTh4c2V1dzhLQTV3a2d0U2RZRld6bURoYm10cjBj?=
 =?utf-8?B?SmV1aDl6RDlhSjNzTjVDdENFc0ZFTlltOFAxYkZCN2p3bnc5TmhoNS9zdys5?=
 =?utf-8?B?bGpuS2ZqZDF3d2xDNE5MVHdOQVQwSDVuZDhHWHY4eVNBcGczS1F4b016bUxl?=
 =?utf-8?B?aW9yTTdRdC9lcVlrRVZBMjlyVkYyZXVXaWtMNHN1a1ZXb2tuSUpTZ3E5eTZD?=
 =?utf-8?B?RFFUWnF3TmZyYlZ3d05NMHR6NHpwSXJBcHRLZTNzYUF0ZTg3WmtSRDVoZURu?=
 =?utf-8?B?UWliSXM1SzVLbitUcVVQS0ZKSHJDWi9lNHNuMjZJNUJmd2RBNkVLeWpYcG92?=
 =?utf-8?B?djRPSGtwRG1rbDBpeEFwSmFqdGFzeXR1ay96MXQ5R3E2VFJGMy90dnYwRjNS?=
 =?utf-8?B?cjRTU0YzNkVyVFE1QXIvVkJzV3lpK05oVURtdU9sazFpcVhoSzcvczcxR2ZV?=
 =?utf-8?B?UEFsMkRTVE5Jby9pL3hhUTZRYkhFRTE4K25vUW1JZHFuNHh5dkVYSUZYaXNI?=
 =?utf-8?B?ZFA3ckZKNVJFNGc1TFJXQmNJYjF2b21zSEQ4Y3grS0pnL3hYbXArUmx3anF3?=
 =?utf-8?B?SDNtNVFGMnJSbU5QOTVLSEpUS1FTS3IxL1NpMldsclVCdVUxTHZmM0Rwa2tT?=
 =?utf-8?B?eVhkeHdHek1FQWloajNtd3FzWWhraXlqUlpkeTNwYS9KbnZsQUtCRTE4am5O?=
 =?utf-8?B?YzlORHZUckh4YjdUbFFmUjMxU05jY1dQQ3cvMC93MDdZVzVKMCthcndOQk9L?=
 =?utf-8?B?NWRYT0EzMWNrbkVJcm5HelFmeWtMWUNBTnRsM0pheHZORFB1dzdkMkJmaUZx?=
 =?utf-8?B?VFBxK1B1cjdvOG03djFqSmduZitpUzhBWlpVNEpLOWFicWpnN0FDd0JFLzlR?=
 =?utf-8?B?SnZKM0MraVBEQmJHY1l4NVBrakJ3VmhNWlE2LzhTUUVncHJ1d3dvRE9HVXFY?=
 =?utf-8?B?RGY5aDJyUkpGclBCYUhRWVpPUXUwZERYZ1EvK0tkU01XSVZIWXpYQnVFbW9F?=
 =?utf-8?B?NW0wd1R6cmthUUlESUh4MEpKOEVqUFZlSFZQdExDdjRhSHpPYTVhQ3J3NUdr?=
 =?utf-8?B?dEZkQ3ZXRWkzdkpvV3oreG1lSk5CMHBmQkk4MWhQNnUrYzhjakpRaUJteVds?=
 =?utf-8?B?RXorZzhvMnp6T3hNRnZ6eVVnRXhuZ2RyMHl2eCtZU0grMlFDNVB0NEIraXZM?=
 =?utf-8?B?amJSVllWK1M2T05ET3dsUW91d0tBMURDSnZsQUt4SzNCNUwwN2FCNTVyUzBK?=
 =?utf-8?B?RGFvcyszazE4eGRsZVU0UXY4ZDJpU3BWb0xKekR5S0ZDKzJvNGVDVnhadkg0?=
 =?utf-8?B?bWlvWUM0L1JEVElTM2xxQjlWRnR0ZUc5VkF6MG1sQTRNbmw1OFJIemdVbmJr?=
 =?utf-8?B?aXFyRGRuUnZyN1JiVEUwNDlqOG1sVERTOWpDc3ErTnVUL0VHdlh5TDM0UXll?=
 =?utf-8?B?K3VlWktiWkplYVR2T0h1WUcwTWpaZ0xldUllakU2QWd1ajVidUU3U2NjQWkw?=
 =?utf-8?B?d2NPc05VakIwMzlMbTh3cTZSb1doWGI0NVRtdVNtME54Szg5TkVhQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28725fb3-0321-465d-df02-08da276c31ae
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:04:47.1560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hBV+t2uBUdzGowcA+Z6ueNeVzwUYz/5zASu7Fj9AZqOkiLBZZLoeHEMvqgizAM+skfSwoRlHCeF3YaU9J3WdNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7358

This brings us (back) closer to the original Linux source.

While touching mwait_idle_state_table_update() also drop a stray leading
blank.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -61,6 +61,7 @@
 #include <xen/trace.h>
 #include <asm/cpuidle.h>
 #include <asm/hpet.h>
+#include <asm/intel-family.h>
 #include <asm/mwait.h>
 #include <asm/msr.h>
 #include <asm/spec_ctrl.h>
@@ -996,48 +997,49 @@ static const struct idle_cpu idle_cpu_sn
 };
 
 #define ICPU(model, cpu) \
-	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ALWAYS, &idle_cpu_##cpu}
+	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_ ## model, X86_FEATURE_ALWAYS, \
+	  &idle_cpu_ ## cpu}
 
 static const struct x86_cpu_id intel_idle_ids[] __initconstrel = {
-	ICPU(0x1a, nehalem),
-	ICPU(0x1e, nehalem),
-	ICPU(0x1f, nehalem),
-	ICPU(0x25, nehalem),
-	ICPU(0x2c, nehalem),
-	ICPU(0x2e, nehalem),
-	ICPU(0x2f, nehalem),
-	ICPU(0x1c, atom),
-	ICPU(0x26, lincroft),
-	ICPU(0x2a, snb),
-	ICPU(0x2d, snb),
-	ICPU(0x36, atom),
-	ICPU(0x37, byt),
-	ICPU(0x4a, tangier),
-	ICPU(0x4c, cht),
-	ICPU(0x3a, ivb),
-	ICPU(0x3e, ivt),
-	ICPU(0x3c, hsw),
-	ICPU(0x3f, hsw),
-	ICPU(0x45, hsw),
-	ICPU(0x46, hsw),
-	ICPU(0x4d, avn),
-	ICPU(0x3d, bdw),
-	ICPU(0x47, bdw),
-	ICPU(0x4f, bdw),
-	ICPU(0x56, bdw),
-	ICPU(0x4e, skl),
-	ICPU(0x5e, skl),
-	ICPU(0x8e, skl),
-	ICPU(0x9e, skl),
-	ICPU(0x55, skx),
-	ICPU(0x6a, icx),
-	ICPU(0x6c, icx),
-	ICPU(0x57, knl),
-	ICPU(0x85, knl),
-	ICPU(0x5c, bxt),
-	ICPU(0x7a, bxt),
-	ICPU(0x5f, dnv),
-	ICPU(0x86, snr),
+	ICPU(NEHALEM_EP,		nehalem),
+	ICPU(NEHALEM,			nehalem),
+	ICPU(NEHALEM_G,			nehalem),
+	ICPU(WESTMERE,			nehalem),
+	ICPU(WESTMERE_EP,		nehalem),
+	ICPU(NEHALEM_EX,		nehalem),
+	ICPU(WESTMERE_EX,		nehalem),
+	ICPU(ATOM_BONNELL,		atom),
+	ICPU(ATOM_BONNELL_MID,		lincroft),
+	ICPU(SANDYBRIDGE,		snb),
+	ICPU(SANDYBRIDGE_X,		snb),
+	ICPU(ATOM_SALTWELL,		atom),
+	ICPU(ATOM_SILVERMONT,		byt),
+	ICPU(ATOM_SILVERMONT_MID,	tangier),
+	ICPU(ATOM_AIRMONT,		cht),
+	ICPU(IVYBRIDGE,			ivb),
+	ICPU(IVYBRIDGE_X,		ivt),
+	ICPU(HASWELL,			hsw),
+	ICPU(HASWELL_X,			hsw),
+	ICPU(HASWELL_L,			hsw),
+	ICPU(HASWELL_G,			hsw),
+	ICPU(ATOM_SILVERMONT_D,		avn),
+	ICPU(BROADWELL,			bdw),
+	ICPU(BROADWELL_G,		bdw),
+	ICPU(BROADWELL_X,		bdw),
+	ICPU(BROADWELL_D,		bdw),
+	ICPU(SKYLAKE_L,			skl),
+	ICPU(SKYLAKE,			skl),
+	ICPU(KABYLAKE_L,		skl),
+	ICPU(KABYLAKE,			skl),
+	ICPU(SKYLAKE_X,			skx),
+	ICPU(ICELAKE_X,			icx),
+	ICPU(ICELAKE_D,			icx),
+	ICPU(XEON_PHI_KNL,		knl),
+	ICPU(XEON_PHI_KNM,		knl),
+	ICPU(ATOM_GOLDMONT,		bxt),
+	ICPU(ATOM_GOLDMONT_PLUS,	bxt),
+	ICPU(ATOM_GOLDMONT_D,		dnv),
+	ICPU(ATOM_TREMONT_D,		snr),
 	{}
 };
 
@@ -1208,20 +1210,20 @@ static void __init skx_idle_state_table_
 static void __init mwait_idle_state_table_update(void)
 {
 	switch (boot_cpu_data.x86_model) {
-	case 0x3e: /* IVT */
+	case INTEL_FAM6_IVYBRIDGE_X:
 		ivt_idle_state_table_update();
 		break;
-	case 0x5c: /* BXT */
-	case 0x7a:
+	case INTEL_FAM6_ATOM_GOLDMONT:
+	case INTEL_FAM6_ATOM_GOLDMONT_PLUS:
 		bxt_idle_state_table_update();
 		break;
-	case 0x5e: /* SKL-H */
+	case INTEL_FAM6_SKYLAKE:
 		sklh_idle_state_table_update();
 		break;
-	case 0x55: /* SKL-X */
+	case INTEL_FAM6_SKYLAKE_X:
 		skx_idle_state_table_update();
 		break;
- 	}
+	}
 }
 
 static int __init mwait_idle_probe(void)



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:05:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:05:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313641.531293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njI4J-0000qN-2N; Tue, 26 Apr 2022 10:05:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313641.531293; Tue, 26 Apr 2022 10:05:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njI4I-0000qG-VD; Tue, 26 Apr 2022 10:05:14 +0000
Received: by outflank-mailman (input) for mailman id 313641;
 Tue, 26 Apr 2022 10:05:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njI4H-0000hM-8i
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:05:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c6381f8-c548-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:05:12 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-3_r9ETmuNiu4y_DjjBqywA-1; Tue, 26 Apr 2022 12:05:10 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB7358.eurprd04.prod.outlook.com (2603:10a6:800:1a5::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:05:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:05:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c6381f8-c548-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650967511;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hsBeSiMQBYJ8DaiSl7aINKcWykVorNvddkc7DYO2PHw=;
	b=RReMBECklLBtC4e48YVr6FugeZjwv76psssQ6vpbOjYtB29JEJhCRlHKo61JiVlFMmmy5t
	vB3yB/2EYyyk6Uhz2rC4jUCVivhnNT/dF29nBgOfLmh+7zR37KlzLxfh6M4kJvRDN7y08A
	slQTN+yL5kgS0qzEm55+Yv88CWhuLVY=
X-MC-Unique: 3_r9ETmuNiu4y_DjjBqywA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XghLsbtarZ+nw6G3zHhyO98g6+2iz88I3rGIIqj28nwMXqiQCuXHKEImXDIKyZ3r/aTH80FnK0l3MfAyG9ebhZWB9xDqHbq8XoUorZZSBsxzWSYVhSs2J35A8drSwtR07krSdJHlJp50DCgElsu2NfkaIPW87WMl6UPmNfrTLvw5J2VZRteROKk5pwYS973vBKiGnqEmDrRJmaIOW6DYXRoXHl8ipLBKHT+b3GOeG9luQGrgRznF+oDP4WbcFXoD5egTMCxvkJgfdurU1XqKnKss9wyF+LI0MYig/AiEoGbS76X4KR+OR+qtc9yYzERJlMk9HEo+zPgacr7cnLnXxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hsBeSiMQBYJ8DaiSl7aINKcWykVorNvddkc7DYO2PHw=;
 b=aP9miXisitKiumBjpUBYEuwJg6BtO/wyqbtZhQJ/OLKNluavjv9cgYux5N1asaWCNWHZXIYYVA9JCBYNgrE+db6OEHthlEL7v8kI8yZWoO3aBVeY5iAAWby/LvYE0AdKDRWMdTCj6XUFDeHfXBC67+bZJlWtV65LBk7C8uiivtjvuKNcXo6Vv95Qyphbpm/FGU1m2lAufhr8s4A3OI71H0XkYpg6zQc3EWQOSnpeuVW+Q7L2EUkKST1oFVKPM/fnn/k4XT31wEPODmmM/zUa9yey3ZagfmWki+0qC656Yb1CsknxGS/PGk6+T+GFheZtsTw22Sb14PHxTjizkjzrVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <722833a9-e6bf-1a63-e866-aed0648c785e@suse.com>
Date: Tue, 26 Apr 2022 12:05:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH 2/4] mwait-idle: add SPR support
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
In-Reply-To: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0765.eurprd06.prod.outlook.com
 (2603:10a6:20b:484::19) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c3009757-dc59-4d9f-595f-08da276c3f2f
X-MS-TrafficTypeDiagnostic: VE1PR04MB7358:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB73586B4D962395D5818FB0EAB3FB9@VE1PR04MB7358.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	d7vxolkD7qJQyEtil8oiep6UiDKzJzAXOx/dBe09YFLxOdiGGtYgAKYf6jgAG7OqXguvm914R/JrhI4ZQCbs0Hty6ZXMLy0jPF2AEsu8+cooEe9DO+beqbWEhIx8kOYou3JVw1SjvbaKVh+LasshZ3rynjK6xGVrDmxcd8EV/+FKlBGotwPht8xmHgYzwEDUt6BwPjI8yBNovA9G3OP5ml6jeFAOb4jQOIIYsurtz5YqjCabLFbk3E6oNGYv4dFFwNB1pdiV9BJ2eJjfkEpboXC69TujRXayGIRTTPZVlf36GAFDXXKiFVmxzW2MhGlFy20UHHyDeoaZyujjhyeGVmSUhg+qabLSGZhsX0dUYI0/c7r7AYp+cj6Lnz0Qm4jD5OgW+xf3VnoTZ1eTMw5JzqaWXV8gL1YaHH0RRVAwVEEnYHcMYDu1NSjxDZNeQL9kYl8VIInySgbnApNXptcSKduR7qx7a/M8TfG/cgrB5hpleCtzStOVLhgRsIPipA1xMKPz8CHUo2LT8fhw4eQieOoEKZqKctWwePHJUAx0pwcgqyNKm0RvwTA4dyolGM+qoflRxCyf2w1obP1vb+/LDXwWBA0ePTRjr2IGm5fzBk1LODsXJ76ONiv5sJrUvHdsX1mgdq3YlmQPJ6xRzD8EiUJDJBjwibS68/HIGeYZFggvUF1eZj0QwKTkbssTRqkLjOq21sPNtinIf9mtdyuB4+tilF1hJXiAC0oH7HPt5/FnZMC+E6za1xwcb7yujQDMhB7UTHMj+E/ZmMZdvPYWKhblNX5yF00N4mt2NbCH6taNpAJhccmDcKNVJ5TSLfreRBM4xxzskNppHLbDXiLXmQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(2616005)(8676002)(5660300002)(186003)(2906002)(31686004)(83380400001)(316002)(54906003)(6916009)(6506007)(66946007)(66556008)(66476007)(26005)(6512007)(8936002)(84970400001)(6486002)(31696002)(38100700002)(508600001)(86362001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZXdZS1I4cWs0dkdUTGNoNk1mbmxIamhYODEzRGxYUEJ0RW1oNlRkL01tc1Ez?=
 =?utf-8?B?RFN1RDA1ZCtrVTN4L3FyeXRSOXMrbHBla1c2QVJPUW4rUExoY1cvQnJ0LzBH?=
 =?utf-8?B?UUFBeWpQVlRNZ1pXcGYwK08zQTJXTGZiVHBvaktOaTBLZ2VRdHBNcDlyK25i?=
 =?utf-8?B?U0ROS2tPbnRtaEhLN1ZzOFh4R05KMFgzZVNERjZReVltY1NJMmorR3pVeHpk?=
 =?utf-8?B?YnF0bkxBVXpKaXdGY3g3UnF2SUFUcUJPMUtNejJBZHR6V01EZmJNVCtITkIr?=
 =?utf-8?B?SGlTam11aWZoeVEwRnREZGVlSktFejcxelZwcURpZ3RZSWJrOFNKcWZ5UkVi?=
 =?utf-8?B?VVJ5bjZWZWpPdXp1bzB2ZUYzVVFBQy9yaUxjWnR5VFVzNTd3RWp3U3gxcDBS?=
 =?utf-8?B?c1JwZ01sUy9qbzNpYzhwRkVtVzV3Y0NoaHFIM2Jra0QyTTRVL045bU8xUzAy?=
 =?utf-8?B?UHdNQUoxaWhnUnRXNm9ucmNRSFg2cGlKWnlQeW5udDk4Z1MzT05PVGI3Z2Yr?=
 =?utf-8?B?a3dpbHE5NzB1dlBrVGNFRE01VDEvdW9DenhJU3lrRjBUcFRUc0ZjU21Da1Zr?=
 =?utf-8?B?WlUyaXNYM1F6WnkvQ2oyYWNLU05zSVJ6ZytVSnFMQzlubkhmSjdyaFhhL0VM?=
 =?utf-8?B?aWwxTWRlUmV2Vk5pS0FGK056eW9KekY3eXVkNlZIMnJsdDJ3ZXlaZHlSVzV2?=
 =?utf-8?B?ZlhFNi9lQVNRd3BVMW0rMHhmMVVxeEhUS1A5WFJXN1NVd0FJWG80NWw5b3Bs?=
 =?utf-8?B?SjNaQnhPeHNwRE9oRktoUE1hMlRtTmQwUkVjSHI4dktRaWtFQUxrdGI0RjlN?=
 =?utf-8?B?ckFRYnV0WHhrVi95UlFlRnJES3dXaUVCL28yWDJRSUZ5QmxQUHg1S2Y3WnpV?=
 =?utf-8?B?dTJTK3FycnIzRkJUTTBBVE9leHNwVExiNkRWSHRnaXluaHROaStMT2FVZ29C?=
 =?utf-8?B?Q01EZzZtcmRZNEF3Vi95ajI1eXZwOUh5SmlRM1licmM5dm9sS2xNSEF0RFVJ?=
 =?utf-8?B?TmdOa1h2N01DQy9jTmI4cDdhck5yUmFnOG82NHd3QW4vVVA2MDRpanZOMXpz?=
 =?utf-8?B?bkZZZkZYSVdMSTVXS1Q3eFlUb1VMeWprMG52T21LNUtZT0pLUkFMRTlYd0dS?=
 =?utf-8?B?aDI1WWFqdDlBMHEwNlZHcG11VERtTmJkZ01pQjB1U2djdW9PZ0N1c25JNUZr?=
 =?utf-8?B?WFEwY1Z3MHJnQWdIcVNGcndxNG9UaVhva0MwTEJJNGZGOWxKWm1DV1JIOG4y?=
 =?utf-8?B?YS9MTEx1NGdDR01SeHpTcWVtZnpKT1N2NEhuYXkwUjRqOW1ielRFbm1nMFZG?=
 =?utf-8?B?U1FGNGY0YU5HYVFWa01uRU0rdzBITEtMQTlHaUZtOW5lWEVRMDlUNHltT3M4?=
 =?utf-8?B?dk83YnN4V1J5YTlNZWszMDRuSDJmQStIT2lvbzJPYlMyMmFXYmxFVm5JZU1L?=
 =?utf-8?B?am1yTlplTHVTRFc5SEduaXhTaVhySTdWS2Nmdmh6SC9Odzl4Z0tpbWJSeSt0?=
 =?utf-8?B?TnlNY0tRTmJFQ0h3RjBRMXlZOVJwRWFVYXc0bkpkNzhHREVzbWQ4M1JWTDhq?=
 =?utf-8?B?N2FKRTFFK3JhTWhYd20zVE91WmIxQmZMY0hYZ21ZYklqU3VXWXYwVWpGSmJn?=
 =?utf-8?B?UmM0aEpTWjFGMjdrSnFJbnhBbFN4WHVBSVVycnZrcGhqMVcwTWxqVTFsUXd3?=
 =?utf-8?B?WjlGTUhZeVRDLzBydVFJVWZOaXMxbkh5K0tQWm9lT0szWTVOSmNocFhhZ0NP?=
 =?utf-8?B?SWIzbGRLQkJIdUFUMzY5WFBMNlh5U09tYXZuUnNvaUhWVTJORml2RkdsQkUv?=
 =?utf-8?B?VU9yclJ3aHdtN2lSUG5KN3RabnZucXNGUTZ3WWhyK01mQWtiUUFXSG1mZ1hz?=
 =?utf-8?B?clpyaWRmVVpFQTloVzNUQjR6VGh2N1BEUEsyRlhsRjdKdlV2NTZ1WGI0Mytj?=
 =?utf-8?B?U3BLWjFGZk04dzl6VGQ3NFdNV2dJQVZMdkNmeEduK1ROS2plQnlxcDBEcmhR?=
 =?utf-8?B?RXlYMlJLYXZ5Z3c0WmtvcFFqVlRraFQyamU3NTArd0ZuZStJajMzUmNHQVpC?=
 =?utf-8?B?WkJiVWdrcGVYSS9hbE4xM09YN3lUNVJCek55M2pGVEVHS3lQTDhCNUhndHh3?=
 =?utf-8?B?Yi91NmV3N3E3VzV2b3JsdmJ5aDFjUCs0b0RtckMrdm03dCs3VklUcFBSbFVW?=
 =?utf-8?B?RjhhVTNUb2U3RkNQbElXRGxuZ2hwWkxpdFBySU5STkpNc2dEYUxEdDJUdG4x?=
 =?utf-8?B?LzFieXFVMmdEQXNmOWN4aGYyOTVPa3B3eVZyYU0xeUo5dUJ4U1NpOFhMZHE2?=
 =?utf-8?B?a1F6VEdwT29hNm1IaU1GYTZnSmhMZnBTK2k3TG5zb1UzcGxpRTNaUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3009757-dc59-4d9f-595f-08da276c3f2f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:05:09.7615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u9DnEWv9EIsHO3Gjde+7/pof9Dosdf7EKBvxzdagGcUeDDZuknahFib4XyoWvAgdnv0zQecWcQzDTFqlL7OswA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7358

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Add Sapphire Rapids Xeon support.

Up until very recently, the C1 and C1E C-states were independent, but this
has changed in some new chips, including Sapphire Rapids Xeon (SPR). In these
chips the C1 and C1E states cannot be enabled at the same time. The "C1E
promotion" bit in 'MSR_IA32_POWER_CTL' also has its semantics changed a bit.

Here are the C1, C1E, and "C1E promotion" bit rules on Xeons before SPR.

1. If C1E promotion bit is disabled.
   a. C1  requests end up with C1  C-state.
   b. C1E requests end up with C1E C-state.
2. If C1E promotion bit is enabled.
   a. C1  requests end up with C1E C-state.
   b. C1E requests end up with C1E C-state.

Here are the C1, C1E, and "C1E promotion" bit rules on Sapphire Rapids Xeon.
1. If C1E promotion bit is disabled.
   a. C1  requests end up with C1 C-state.
   b. C1E requests end up with C1 C-state.
2. If C1E promotion bit is enabled.
   a. C1  requests end up with C1E C-state.
   b. C1E requests end up with C1E C-state.

Before SPR Xeon, the 'intel_idle' driver was disabling C1E promotion and was
exposing C1 and C1E as independent C-states. But on SPR, C1 and C1E cannot be
enabled at the same time.

This patch adds both C1 and C1E states. However, C1E is marked as with the
"CPUIDLE_FLAG_UNUSABLE" flag, which means that in won't be registered by
default. The C1E promotion bit will be cleared, which means that by default
only C1 and C6 will be registered on SPR.

The next patch will add an option for enabling C1E and disabling C1 on SPR.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9edf3c0ffef0
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- unstable.orig/xen/arch/x86/cpu/mwait-idle.c	2022-04-25 16:48:58.000000000 +0200
+++ unstable/xen/arch/x86/cpu/mwait-idle.c	2022-04-25 17:17:05.000000000 +0200
@@ -586,6 +586,38 @@ static const struct cpuidle_state icx_cs
        {}
 };
 
+/*
+ * On Sapphire Rapids Xeon C1 has to be disabled if C1E is enabled, and vice
+ * versa. On SPR C1E is enabled only if "C1E promotion" bit is set in
+ * MSR_IA32_POWER_CTL. But in this case there effectively no C1, because C1
+ * requests are promoted to C1E. If the "C1E promotion" bit is cleared, then
+ * both C1 and C1E requests end up with C1, so there is effectively no C1E.
+ *
+ * By default we enable C1 and disable C1E by marking it with
+ * 'CPUIDLE_FLAG_DISABLED'.
+ */
+static struct cpuidle_state __read_mostly spr_cstates[] = {
+	{
+		.name = "C1",
+		.flags = MWAIT2flg(0x00),
+		.exit_latency = 1,
+		.target_residency = 1,
+	},
+	{
+		.name = "C1E",
+		.flags = MWAIT2flg(0x01) | CPUIDLE_FLAG_DISABLED,
+		.exit_latency = 2,
+		.target_residency = 4,
+	},
+	{
+		.name = "C6",
+		.flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED,
+		.exit_latency = 290,
+		.target_residency = 800,
+	},
+	{}
+};
+
 static const struct cpuidle_state atom_cstates[] = {
 	{
 		.name = "C1E",
@@ -972,6 +1004,11 @@ static const struct idle_cpu idle_cpu_ic
        .disable_promotion_to_c1e = true,
 };
 
+static struct idle_cpu __read_mostly idle_cpu_spr = {
+	.state_table = spr_cstates,
+	.disable_promotion_to_c1e = true,
+};
+
 static const struct idle_cpu idle_cpu_avn = {
 	.state_table = avn_cstates,
 	.disable_promotion_to_c1e = true,
@@ -1034,6 +1071,7 @@ static const struct x86_cpu_id intel_idl
 	ICPU(SKYLAKE_X,			skx),
 	ICPU(ICELAKE_X,			icx),
 	ICPU(ICELAKE_D,			icx),
+	ICPU(SAPPHIRERAPIDS_X,		spr),
 	ICPU(XEON_PHI_KNL,		knl),
 	ICPU(XEON_PHI_KNM,		knl),
 	ICPU(ATOM_GOLDMONT,		bxt),



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:05:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:05:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313644.531303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njI4d-0001Nv-BJ; Tue, 26 Apr 2022 10:05:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313644.531303; Tue, 26 Apr 2022 10:05:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njI4d-0001No-7o; Tue, 26 Apr 2022 10:05:35 +0000
Received: by outflank-mailman (input) for mailman id 313644;
 Tue, 26 Apr 2022 10:05:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njI4b-0000NY-7R
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:05:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 681e441b-c548-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:05:31 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-NP51lWqxPAmzj90HzgZXIQ-1; Tue, 26 Apr 2022 12:05:30 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB7358.eurprd04.prod.outlook.com (2603:10a6:800:1a5::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:05:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:05:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 681e441b-c548-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650967532;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=V8XyV84mse8tuFsetJlisN+guE7TcB4fbUoJF+UDFJg=;
	b=CAUNz5ZKUWLY3PgMhUchKbN8QW3Msn3Se2+L/KRj3vlUNDq17tuZgschKxDMHD6BScy2hM
	LjaB+S5YLGiFNEGkxHBPLg+tAtlZd7Cy79WW9Up0glNiYCaFS0ylJ4I9cHxWnBjmJ6UjJS
	zqJ33Km5GVXYYryhO+LFgKOn3aS+z+s=
X-MC-Unique: NP51lWqxPAmzj90HzgZXIQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d2n1mtdYf5goyiy6WnINRTy+oihxM/HzRoQx32gLrFLijXCf8OMfJ+rifivITAAtPUzcBg7KDkS/jNxUgGPB41Gguv7UuUN5C7Ell+JlDiBXRha0pau0ZgVBcWR32Ki9/kj6ET2GbjEw5UvpenfGMAnMoLx9yovRhL0CrvlVqSOxF+8nbILq6P1fis+XFL6UF8e6cfXju6EmHD/Fn9XuHfFeMh2swTyl8/lg9VZGyz2GL29q4Q0z48UoBfm6lNZH9ejb39TljPkWSRlZNjcp1R3FeNd+h7GDYHLLB7L2Lo0D2Se1R4BJhUiAi4QpEO/Q4FDVBI+qw0JYprhnHhlIiw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V8XyV84mse8tuFsetJlisN+guE7TcB4fbUoJF+UDFJg=;
 b=V0GuZJiIA8qw9T4O8sf1sA+Xb/B+t8tLjCbXR+YXVwV0m7bClNVFMul5hrSnH3FhcgT8Lsa/5gihQfC0DI7HKnlH8cEW5fOUjTeDO7MUf77MrSNygGykHW1FMlbapRSP/taZynjtKWRT1jRwQAEznL/imvRHP4ttEUyrWmzhkFvYGL3jyK50d1PKMVPTLe2YTdiEPFgCH+Av585Ea66ivjdGzV17usqZ+w0yi7tLYvDi5AH2EzqC0EMHKzKkPQDmNQ00gqDXs8YaETjTCK5/FYGvtAu95zamcNQKFnAgRnJNsKdY7zi42wlwGS1tt8M5ZB8FlGpCkPw7rsxqfAUxpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
Date: Tue, 26 Apr 2022 12:05:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
In-Reply-To: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0176.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97e59483-66da-4853-cc83-08da276c4b08
X-MS-TrafficTypeDiagnostic: VE1PR04MB7358:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7358621D07AAEA705F141C9DB3FB9@VE1PR04MB7358.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o3s7Ck4QIaIWdnIVdHjwsv2sz/S3hCPoEZ4NGPJvYY76QNtqU5AVHSt8OZyOVH+jeR093xhUXZr5myMVDd3XtqfxHRLZl1VZ36CKxw2Nkz+NYPQbSUgd+ineLZGe3jP/4H0GYSDu0PF5DBzJUazsLmVWSSRkVTAL1H6GWQdO8RqLQu91G7SgYSP7g3k+YT2hcttJ9pMcLKATYghBhWHwr5xUrjkdjJlprR8OUit27lzgYA+ydqcicdp6+3QdhBLF6H0kA8rZuRWs2sdWk73Tz88UO5NIckgV6ZZWSwsNCB1HWSAowSopeb7Av/XJpvIL+RWu2BeJ08VIgK3s18JQ7hBMPNa6lXS/sM4JQMz8iq1uN5RJOEbnjKEICDgYk9e9VaGimMM9sQKU5UKikBhHSAZz7lwkBtb3WntAutF57rwKNRoeFdUmSTPOiOvGvqpQLGjn5H+F2sCjooOtXDvYAjM2NOP/XcLgKuUZVqhSwld9X38g/k29fgkLq6meU3PHy9xjol6X6bJbDetPKIn5WnxjWtzgO+s3TVzXYmRk76Kx4CtE41V3MloGuBl4wDWIKpGpmMUM8MsXTu8yE6o79qI3qiPVl3uECVczCi4ch3XyxZqzErnljfCZfMdfIcx6KKet9L2kxKIg2DjqS8ALwIEpmUOyR57WCcPiu2WhwfSoDFA73KLWSyPYL8mYzdAeRdzLPYEoi72D3QCwdqygVr/ObqJyt907vw8hIdEwkfQx/XMRQV5WAHF3PT5unko3QqH8MNW09NAo+q5dfaVGujVPq/9PIFbuIaVf7RIrGp+ZS0+eSTCl6xoCA5R6+dl69VqcHUxZ9+GGmzlnBOf2cw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(2616005)(8676002)(5660300002)(186003)(2906002)(31686004)(83380400001)(316002)(54906003)(6916009)(6506007)(66946007)(66556008)(66476007)(26005)(6512007)(8936002)(84970400001)(6486002)(31696002)(38100700002)(508600001)(86362001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?anczRFlHTEdvT3pUb09xTVg2THVLUkJFQ2szQWY4YzBzenpWZmRoNVRkUGds?=
 =?utf-8?B?RGs4NUcySUVJaElWZGdsWDJFOXV5V0wyV2xKa2ljZzN3NmpjcXpjallsKzR4?=
 =?utf-8?B?d3JYSWZsUXdmaTBSdCtFYWFzRW8vczl0QXhsUUFkV0p2S1lLWmMrK0NnaTNB?=
 =?utf-8?B?My9BcTRIYUgwNytIVUY3dGIrOHY1QzNRN3JqdmtuSTc1cElVU1B3aEFobzFP?=
 =?utf-8?B?enE3ZDYzYm8vN2lTZitYb0hNL1BlS0xGSEdYZ0N5V0xJcFBiZFhrMEVqMjV5?=
 =?utf-8?B?MjIxOGdPeXQwdTZoaDUzS1ZVUzRJK3NjNytBaGpROUdxU1Bid2phSGEwU0d0?=
 =?utf-8?B?UnAwamZHVmkxNjR4TTVmanVsWjhsamhQNEZUbVdaQWFKcDExQlF4eWxWWWhB?=
 =?utf-8?B?S2dtN3hrYkRQQjVOa1AvdHhoalY2UFV0T0M0V3EvRmdjZ0czOURlajJKM1g5?=
 =?utf-8?B?MGxnV3VMTjZjRHQrOUtTQUlRRTIyNmozd2hzaDBYRytUQUlqeCtpeTZpMjlm?=
 =?utf-8?B?aGtUZnpVeWxsQUQvWnVrTW5rYVQrdThmWGh6YjZvVGkzc0VMMUVrcjRIYlNH?=
 =?utf-8?B?UHBDbGV4Ymc1cGRldTVoNU56UXhkUUVReWJFdFpRNVBqTjRZZUtERmZYSnhG?=
 =?utf-8?B?c1d2REJteXdzSXBXSERqR0VyN2VBM1BMWDVMV1E1NSt1QUdnQ251R0J4bnQ0?=
 =?utf-8?B?N3ExaXp6MkRSSHE0Yy9oT24xd3RPL09hTHQxTFJ3NTViVFIzRzd5QytleFdz?=
 =?utf-8?B?aEZnTXNENXJWSVp2YmhETFJaSW8vdi80WE42Nnh5ZDUrOUJYMXlFNG4vYkVw?=
 =?utf-8?B?R3lua2p0VGhsaWZSdmQrcnBWWDVYY1RDVCtCbDJ1aFRRQmc1N2xENEQ2S2py?=
 =?utf-8?B?ZXh5Z1hkU3hDUEw5OWN2cWJEeFA3ZUQvdkk2QWdxUFFSNlhBRHhzZUtIYVRQ?=
 =?utf-8?B?elVDUlN0Ujl6b3FtYUJDM2ZFby94OXJjR1c2bEcxaEdyZnAyUHJZVlFBMnc1?=
 =?utf-8?B?MmMzUVBsSUtObnpBTDI1bmpqblpTemFmL1puOWZpaFRLeGRoMkRwa0JtQWRF?=
 =?utf-8?B?bmVWWW1iOUt5cGtlYnFnTGF0dFB5SDdLQU80VG9ZNVQxVUI5NGM4Q2lYWm8w?=
 =?utf-8?B?eXVSOVA2dTlyTFkyZkQyVWkrUThEbHRIZEFpU3IrZkdrQWZ1LzhYZFVQakl6?=
 =?utf-8?B?Z2RDUndPSHNLa3lxYi9GUmkzNzdIYlp6ZkFhTFYvZFBET05GYkZxUkNuemRY?=
 =?utf-8?B?R2U4VmJVMnoxM00zQTExQ3dpVzZ1TTFxZnBRWk1mSVMxLzR1OVJpaUxtWUgw?=
 =?utf-8?B?ejlzVmdLb2tETC9Xc3NOc2kra0NBcEoxZzRWVGlsVDJCTjQ1bEYrSEVHelAx?=
 =?utf-8?B?b3dJaExEYVBaRWxBV2ZKZWpraUY5bDFzZjVPL0dBZXRSc0U5bnEvM2RqdDlm?=
 =?utf-8?B?OW1oekR0anMzRlh0ekRiMmVwVDJ3VStaUXVOekxVSG1qR000SEdUTFlkLzNp?=
 =?utf-8?B?emlnMEU4Tk9QLzBWVzcvK3R6Nks0dEF0d1JXQmVtK0R3bkVUYjV4cG96c0Rl?=
 =?utf-8?B?dnlDTjk3amR5RFNRem1lZGhhM1VIaVhCaU9FUWFOWE90NkJYVWxXajFGalA5?=
 =?utf-8?B?TEJaZXNPQ2xIclJPQWJYL3dMajVyT3Y2VW5WdktLYWlDWTU2QWltTnY0Q1dv?=
 =?utf-8?B?TjZCeElhWklCaUlUTklSQlluQjV2SlhvTVRaWU0rM0pSTXVlelo5MzB4K3pw?=
 =?utf-8?B?YnFRTGQ3dHhtWTdSNE4zbm53SVlWb1I5akNoazVBVjBDSXROOGZvVXBaY2I1?=
 =?utf-8?B?Zi9HU0NjOXJZMERkRktXeDErSWhLSTZmT2VCK3VYNzBRRnR5dEM5dmVwWFRB?=
 =?utf-8?B?SXJzSE5zU0NoVTAxeVduNk16RGdpV1lsUnArSTZvdVg5V3RrRUVvNGN4QU81?=
 =?utf-8?B?cVRJcnNHSnYwSzBuM3crSzlZaUNia3RBdnVsSkRIR0d3WVpyT1k0TGZacE9u?=
 =?utf-8?B?YVR5b1NmenJNUjRQcTBRT3pMa3VBdzV3UGdFY3NFdEcrS1dYbnpkN1RGWEUz?=
 =?utf-8?B?b2k4ajgrTEM4SE9VUVVpbm5hMnpBajJDUHVrOW56dkZjOHdCK2NOTTh5RWN4?=
 =?utf-8?B?QVdVMTR2eElPRlhReHdsamowTkVibXBYWFEvRFNHQ2tjZnFxT1o1UFhkS29o?=
 =?utf-8?B?YlVsemcrNC9qNHdWbGpUNkJkUS9PUUczOTJYRHFnbXM5YTBZbVc1VVVha2Rk?=
 =?utf-8?B?VXFEMS9ORTVwakhHOW16OHRQUDlueGxlSDdxQk1ycmtWWjF3RUNDYzQvZlF3?=
 =?utf-8?B?ait3aDd0RlljT3dEclFYTkRLcEZZZjl2ekJIQjNOZFVyaEo0QzFMUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97e59483-66da-4853-cc83-08da276c4b08
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:05:29.6415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NL2RYUiyXHdJUODnunlo5VMp5ZHrOsY0UoRLdwsW25thE3RDB/DI5LYB2XJ91PDUG+kriTalr6iRP/a+Ez6d1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7358

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually
exclusive - only one of them can be enabled. By default, 'intel_idle' driver
enables C1 and disables C1E. However, some users prefer to use C1E instead of
C1, because it saves more energy.

This patch adds a new module parameter ('preferred_cstates') for enabling C1E
and disabling C1. Here is the idea behind it.

1. This option has effect only for "mutually exclusive" C-states like C1 and
   C1E on SPR.
2. It does not have any effect on independent C-states, which do not require
   other C-states to be disabled (most states on most platforms as of today).
3. For mutually exclusive C-states, the 'intel_idle' driver always has a
   reasonable default, such as enabling C1 on SPR by default. On other
   platforms, the default may be different.
4. Users can override the default using the 'preferred_cstates' parameter.
5. The parameter accepts the preferred C-states bit-mask, similarly to the
   existing 'states_off' parameter.
6. This parameter is not limited to C1/C1E, and leaves room for supporting
   other mutually exclusive C-states, if they come in the future.

Today 'intel_idle' can only be compiled-in, which means that on SPR, in order
to disable C1 and enable C1E, users should boot with the following kernel
argument: intel_idle.preferred_cstates=4

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git da0e58c038e6

Enable C1E (if requested) not only on the BSP's socket / package.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- unstable.orig/docs/misc/xen-command-line.pandoc	2022-04-25 17:59:42.123387258 +0200
+++ unstable/docs/misc/xen-command-line.pandoc	2022-04-25 17:36:00.000000000 +0200
@@ -1884,6 +1884,12 @@ paging controls access to usermode addre
 ### ple_window (Intel)
 > `= <integer>`
 
+### preferred-cstates (x86)
+> `= <integer>`
+
+This is a mask of C-states which are to be use preferably.  This option is
+applicable only oh hardware were certain C-states are exlusive of one another.
+
 ### psr (Intel)
 > `= List of ( cmt:<boolean> | rmid_max:<integer> | cat:<boolean> | cos_max:<integer> | cdp:<boolean> )`
 
--- unstable.orig/xen/arch/x86/cpu/mwait-idle.c	2022-04-25 17:17:05.000000000 +0200
+++ unstable/xen/arch/x86/cpu/mwait-idle.c	2022-04-25 17:33:47.000000000 +0200
@@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
 
 static unsigned int mwait_substates;
 
+/*
+ * Some platforms come with mutually exclusive C-states, so that if one is
+ * enabled, the other C-states must not be used. Example: C1 and C1E on
+ * Sapphire Rapids platform. This parameter allows for selecting the
+ * preferred C-states among the groups of mutually exclusive C-states - the
+ * selected C-states will be registered, the other C-states from the mutually
+ * exclusive group won't be registered. If the platform has no mutually
+ * exclusive C-states, this parameter has no effect.
+ */
+static unsigned int __ro_after_init preferred_states_mask;
+integer_param("preferred-cstates", preferred_states_mask);
+
 #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
 /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1. */
 static unsigned int lapic_timer_reliable_states = (1 << 1);
@@ -96,6 +108,7 @@ struct idle_cpu {
 	unsigned long auto_demotion_disable_flags;
 	bool byt_auto_demotion_disable_flag;
 	bool disable_promotion_to_c1e;
+	bool enable_promotion_to_c1e;
 };
 
 static const struct idle_cpu *icpu;
@@ -924,6 +937,15 @@ static void cf_check byt_auto_demotion_d
 	wrmsrl(MSR_MC6_DEMOTION_POLICY_CONFIG, 0);
 }
 
+static void cf_check c1e_promotion_enable(void *dummy)
+{
+	uint64_t msr_bits;
+
+	rdmsrl(MSR_IA32_POWER_CTL, msr_bits);
+	msr_bits |= 0x2;
+	wrmsrl(MSR_IA32_POWER_CTL, msr_bits);
+}
+
 static void cf_check c1e_promotion_disable(void *dummy)
 {
 	u64 msr_bits;
@@ -1241,6 +1263,26 @@ static void __init skx_idle_state_table_
 }
 
 /*
+ * spr_idle_state_table_update - Adjust Sapphire Rapids idle states table.
+ */
+static void __init spr_idle_state_table_update(void)
+{
+	/* Check if user prefers C1E over C1. */
+	if (preferred_states_mask & BIT(2, U)) {
+		if (preferred_states_mask & BIT(1, U))
+			/* Both can't be enabled, stick to the defaults. */
+			return;
+
+		spr_cstates[0].flags |= CPUIDLE_FLAG_DISABLED;
+		spr_cstates[1].flags &= ~CPUIDLE_FLAG_DISABLED;
+
+		/* Request enabling C1E using the "C1E promotion" bit. */
+		idle_cpu_spr.disable_promotion_to_c1e = false;
+		idle_cpu_spr.enable_promotion_to_c1e = true;
+	}
+}
+
+/*
  * mwait_idle_state_table_update()
  *
  * Update the default state_table for this CPU-id
@@ -1261,6 +1303,9 @@ static void __init mwait_idle_state_tabl
 	case INTEL_FAM6_SKYLAKE_X:
 		skx_idle_state_table_update();
 		break;
+	case INTEL_FAM6_SAPPHIRERAPIDS_X:
+		spr_idle_state_table_update();
+		break;
 	}
 }
 
@@ -1402,6 +1447,8 @@ static int cf_check mwait_idle_cpu_init(
 
 	if (icpu->disable_promotion_to_c1e)
 		on_selected_cpus(cpumask_of(cpu), c1e_promotion_disable, NULL, 1);
+	else if (icpu->enable_promotion_to_c1e)
+		on_selected_cpus(cpumask_of(cpu), c1e_promotion_enable, NULL, 1);
 
 	return NOTIFY_DONE;
 }



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:12:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:12:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313658.531314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIAh-00038G-1z; Tue, 26 Apr 2022 10:11:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313658.531314; Tue, 26 Apr 2022 10:11:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIAg-000389-VM; Tue, 26 Apr 2022 10:11:50 +0000
Received: by outflank-mailman (input) for mailman id 313658;
 Tue, 26 Apr 2022 10:11:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njI5N-0000hM-4g
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:06:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 84e6b137-c548-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:06:20 +0200 (CEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2059.outbound.protection.outlook.com [104.47.0.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16--YC4MvI1N-uzH8laZoD-Hg-1; Tue, 26 Apr 2022 12:06:18 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by HE1PR0401MB2666.eurprd04.prod.outlook.com (2603:10a6:3:86::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:06:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:06:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84e6b137-c548-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650967579;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lpUvuCK3/tdepTPtfGMVhvunTplLc3OBdRwg9JqsTOQ=;
	b=TWrUM/0ZhosWgdYBQiQ50NkCsxjAa2qd+5dUhIkRiXhHYiIVwdhB+UWiZAOjPlYliwLmZv
	pxxFIqEsbiJXz9xhnzkC+nvKVN4SDNwPZFr3neRZwwFKvft7wznT2YknSl2LattBYB26+a
	gXrLRnRheMFlHcvG0f5zdhvCWOCwH3s=
X-MC-Unique: -YC4MvI1N-uzH8laZoD-Hg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i+lypYBWvaPmIT/v3xxOzx74rBP464cpHoyt5WPJ77xg9RxhpPu3f3+gldUrzR+cZVo5rJ/0kJ0urDShMKEM32uSxUuuWi+pbAaEXNN9jvxn/FLc5nbOAVtX78+5igofmbjeoZUN9ghE0h5vrG2XFJmLnGy5zma7xlSuWtfI2Hmf2KV24GIBgBW3Wl3xTLyS3LfBt7XBySRCWY507lRqf/CTYfXVKm0ncnVBoIz99LNf7I/rbvZsPvPzBXd+1VB/VKkihbknLxNucnutqA7/GeuKD0o3wB3mxZalj2d5S8ChxkvU6TcIvlak+iQf4ZFpEMEFzq+xCaHNmkMENEocaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lpUvuCK3/tdepTPtfGMVhvunTplLc3OBdRwg9JqsTOQ=;
 b=X1SmGk4UwPq8ENE09fFWvm3alOr+1dAGDZWi9bWQISGwE76O+3NJcWRDzUP8ofSnaLpeA2V1rBtmvxSJFhP8Y+V1JFu13gsxBofID7nERiMdQNnO8vYQwW6z5LtNdtriFvHNBvK8+9e69ueyt/a1o5P30aS/OhUYtgxAkmi0EEyvdCDsnlbsEWE7NTtAkC81x0g51ViFkGLgn7+pK9PnhguGvYE1wpcDqCmEARq/WOgB1ANmGw/K5Oyv1lQzI6hm7dzIftI/olveZNaerZnBZE9OdRAgu3xWqlSSfXolpZD/I+zZzl8he3zVTYujnNNkxPbhiMyELNQYhJ3tcEWQSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <002d7dbc-8290-10d3-6e6e-c5947c1ace82@suse.com>
Date: Tue, 26 Apr 2022 12:06:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH 4/4] mwait-idle: add core C6 optimization for SPR
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
In-Reply-To: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0018.eurprd03.prod.outlook.com
 (2603:10a6:206:14::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e5daaec-e975-48a5-2c86-08da276c6693
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2666:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB26668F3EA74E691824624814B3FB9@HE1PR0401MB2666.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	e1G2+/1a/erlHpnJfSytMeVX/EBOrw+rwbaBE6np7t8+M8YrQeJS9KJLRiO37V9moIfkCGVo3k94zbqUI7KwlzGPoukkXLc6kUJr/fTj+p08TRS1sRO1eC4GcKGJm5Hc8CiAWlGw/0U9J3CetsnEcvhJWB349w5K6V0TOQCr0p+qlYYzJMEAxU4CSAW/Fi6A6lnb6aAkaSZrscYX8LJEHTr21ZDa+UZQ4vaP8LUKfso638P16IxOvQAOcjyhyMdUW4nZoL6tDU4hy8IjNqPiuoeSqO3/HP0dmGeNr0AlaDcxAscyHfbqG/H/qNLOf59BTDCVpkhtrQ4lx0vPd8JsA7lEsdhKHraep794GME0f3ZepvG1snltzw0Wwc+7djvmhAV/KYKwhHu6d2l64ngHzEhPaCO0FZSfeUZ/Hn185tx1u29TTsQutipJxYDQW4vUK6y7UWX/FZXLTo5XbKeyDgg9m6bH0IeqxxU7wtuy3MUw3T6DwLbq63pLWtHeGAZJqTnK0DvaIZQv6YpD/bu5B5XaQ8VZAMMSnWHvTzWETCVQ5theVT6XgxRHdnGIzk5EpUqdscaSsjjdtobT5PkP9LKligG9q1tdEgZZp9FKHITJ3cco/XW7C9TW2EeXgvb9ttUYvad3wZ4XnV7Dka3xkw8rQ/OsuXT7dK3ozedwz3BIHYu3PjmW5PNwi+L69Ttpj+0kL9jt5nOgYtx/iroW5pw1+dUrZQAPn1T3HUFfwbtqeYeDxEnXPoTdU4hMux/9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(38100700002)(83380400001)(6506007)(508600001)(86362001)(8936002)(36756003)(5660300002)(31686004)(2906002)(4326008)(2616005)(6916009)(26005)(66476007)(54906003)(31696002)(8676002)(66556008)(6512007)(66946007)(316002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OUFnemlONGFwUk42TFB5NVc0NkFFNHBrT0VVcmdqdURYSE15VXY5Q3RCTzNW?=
 =?utf-8?B?L0VQRGJ2aFJaN0hDL1F6Qmt2bDRyWnpzRUw1OVkvYmxtajhEVW1yMFFnenJy?=
 =?utf-8?B?S1Z0QWk5TTl2ZSszQXN5QkUvRUhkWFh4aTRqekgwWVdXbkltRUFkY3l5Z1RC?=
 =?utf-8?B?RHl4ZXNLbmlxRzhER3JTb01ENk8wU0lKUTNiYlIvZys0OE1SZU80Ky9tZnda?=
 =?utf-8?B?Q0s0ZDVYdld4VVRwZHpHL2JSdzYrLzZRdkhiUjNxT2hNOFc5UEl5eEoyUG9R?=
 =?utf-8?B?YzBHaktJUUNUM2lMKzN4R1pwUXRjUEVueGh4Yi80M1FQVm1uQmIzWVZrWldS?=
 =?utf-8?B?eTl6YnpMT1NlYkdxcGlLTUE3ZVF5eVozdEkzdmtVVTNNM0c2YkExMmpJTkgv?=
 =?utf-8?B?cUlLY0hyVnpNT3Awb3ZpVVdYTkJRalNYOXpsYlVKSVgzZkZqNEdoOUZ5QTdH?=
 =?utf-8?B?QUI2UDRwM1JDeENtZERva3RJY0lscGZ5ZDZLeGxjZzA4ak42YW1FeTJrSmpG?=
 =?utf-8?B?VFFZb3kwODhWTDFkRmxvWUh4UDhFRDExQkpNV3dhaFhOL29VbWRaby9vbEpo?=
 =?utf-8?B?UVlqRDNqdVE5SjFQN1ArdHN4MkRUdkdjR3VrYXZTT1VDbXhPZWhEeStxdWg5?=
 =?utf-8?B?R1hsQmZHVVY4QTJaai9sRTNpYTFOVG4yOURVN0VFTEJwTFJuRWp0UkI2VjRw?=
 =?utf-8?B?UnF1aGpGYWRVdjhlRDNtYzJHQlRPRTg1cm5KY2lKdkVWM1VOQXhlM3RnSDFi?=
 =?utf-8?B?ZGlHaFJhUk1ESVpTM3VjWUIwczExTlM5R0tyK05ZaVR4Y3RSMzBCdTdsa2RS?=
 =?utf-8?B?WXZ0NVZVbEg5WkpEc0Vjanl5MmdPTFdCZnl4WEF2OE1NRVh6d29QUG5vZjVH?=
 =?utf-8?B?Z0ljTDJ6dzU2RTZCOHJJMHJIZHpCeUs1ZXFBZHZjTGpqdXN4SlhoMWhUOHBZ?=
 =?utf-8?B?YStreWEvU01aMUVqSmFGVkdEVnFpZDZYTFFMamdDNlBNUHIwYUQ4UGwzc1NK?=
 =?utf-8?B?SENvMkJkMmZJL0Z6QWRvbkw1QXdaNytZU0J6d0RDQjV5dmswVU4xdGlyK2ww?=
 =?utf-8?B?N0dubEZYUzczZWRqN2RHOXV1dEdnaWZkT2JLRlFnQlBHd1NmbUFYNTZ0cnlS?=
 =?utf-8?B?M3pxTjV5UkxXK0xTSytMQzh1ZzlXSXBERVNRcmZ1THBMdUdDeDFxZlJlRkRx?=
 =?utf-8?B?TDdzRHVyaUVqSFNnamNEUnZkSktyTEZHNU1rVVFrVDkzeThjR3FPeHhuR0lN?=
 =?utf-8?B?TzBhcC9YbElHQjRKS3VJN3RQRlhUTm1wMGdFTnlUZmNocTBldGoxUVJEaUtO?=
 =?utf-8?B?cnZ0Q25BWDkxUnVmWUwzKzM5TW51Ykp1RGVKbktvM1lBVEJXSHVMSmV0TmVM?=
 =?utf-8?B?SC94L1c5SW92S1FxdzF5djlwQjM4QlhLQnpST295dWZmRm9ySjBJZXRkN2Jp?=
 =?utf-8?B?V0J6d09aZ0IzM0pVRUtGYmV6N0NaWXJFenUxd2tzVGR0ZW9Pd21rcWdzUDhB?=
 =?utf-8?B?aWxnRWc4M1d1N0NZS0cyVnBITGpnUTg3OVp0OTE1YWg2VTArVDBKNnV1U1Qw?=
 =?utf-8?B?SVM2NkY0NG5wLzFjQTdPdzQwSDQ2RWhTd3FSMEt2ZlFwNGtZRjdxdUJnamEv?=
 =?utf-8?B?cjB2NjhremVLV2dpeWhBaEVibU54NDJIaGpkRjFFRHovRUk4Y1VJcVkycUV0?=
 =?utf-8?B?bDI5eVYxdGtIYWRXYXpmR0xmc2RKcGg0R2V3VWk4Y3hDWEhJem44Q0RvZXZT?=
 =?utf-8?B?K2lYdXdoT1ExcHFCcGZ2VDNna0puQzEwSWtVdDBoNXo5cnJLRkRqSDdLTTV6?=
 =?utf-8?B?K0tsOFVBRDA4NVg1Qmc4WVRxQndxT2w2VC9Wb0plSFd4TW9ua3FaYWtKcm5O?=
 =?utf-8?B?S1EzekNXTUNKRzVnMTdoVFYvL3JLcFRoWnBCUTBwZ0VqRExUc3F1aHRnMm0r?=
 =?utf-8?B?ZWF0TW1kSkp5Nm9IMjQ5NURzckZZa0RuOVR4Z2k4bi8yWGtaTGx4M1h0alRt?=
 =?utf-8?B?YTdMSFVHOTM1Y3BBMUtGcFJJSnlCYW5rRWpwY0FnYzdVaThEMVkwQnorOGdR?=
 =?utf-8?B?R3BkQklwamZGb2tpWUVBS1ZhT2NQZG5xcjFBZVNWbGROc2ZJbEY5VkRXN3R6?=
 =?utf-8?B?enNFYU5DeGdGOUt5NU5vaU4rc2poYk9JK3o1eWxxQStmamlLaHZVSDZjUXVl?=
 =?utf-8?B?NmwzVWhGYVhRZThrRVZEYm5SZ2RGbmdCcUtMOEorZ2VVS1VTNGduSFVJZ2RH?=
 =?utf-8?B?RWw0b2dZRkZuUkx3RWl2VSs5WkppVDFNYnlmL25sVFdKZFpuSVFsQithdXRB?=
 =?utf-8?B?UkR1YzU0bHdPTjg3MFZBVjcrL3J6MmQzKzM1dko5U2tuRllVcHVRQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5daaec-e975-48a5-2c86-08da276c6693
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:06:15.8468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HJ0U6WSTdIWfPCzWEDzyCQTco/ctFyL3rfPv1pdHoW2mSQ5GudMwIMT1NQhgscUDA77cwyEdfr5jTLvuMfLeZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2666

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Add a Sapphire Rapids Xeon C6 optimization, similar to what we have for Sky Lake
Xeon: if package C6 is disabled, adjust C6 exit latency and target residency to
match core C6 values, instead of using the default package C6 values.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3a9cf77b60dc

Make sure a contradictory "preferred-cstates" wouldn't cause bypassing
of the added logic.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -1267,12 +1267,12 @@ static void __init skx_idle_state_table_
  */
 static void __init spr_idle_state_table_update(void)
 {
-	/* Check if user prefers C1E over C1. */
-	if (preferred_states_mask & BIT(2, U)) {
-		if (preferred_states_mask & BIT(1, U))
-			/* Both can't be enabled, stick to the defaults. */
-			return;
+	uint64_t msr;
 
+	/* Check if user prefers C1E over C1. */
+	if (preferred_states_mask & BIT(2, U) &&
+	    /* Both can't be enabled, stick to the defaults. */
+	    !(preferred_states_mask & BIT(1, U))) {
 		spr_cstates[0].flags |= CPUIDLE_FLAG_DISABLED;
 		spr_cstates[1].flags &= ~CPUIDLE_FLAG_DISABLED;
 
@@ -1280,6 +1280,19 @@ static void __init spr_idle_state_table_
 		idle_cpu_spr.disable_promotion_to_c1e = false;
 		idle_cpu_spr.enable_promotion_to_c1e = true;
 	}
+
+	/*
+	 * By default, the C6 state assumes the worst-case scenario of package
+	 * C6. However, if PC6 is disabled, we update the numbers to match
+	 * core C6.
+	 */
+	rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr);
+
+	/* Limit value 2 and above allow for PC6. */
+	if ((msr & 0x7) < 2) {
+		spr_cstates[2].exit_latency = 190;
+		spr_cstates[2].target_residency = 600;
+	}
 }
 
 /*



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:17:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:17:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313665.531326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIGS-0003qL-Qp; Tue, 26 Apr 2022 10:17:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313665.531326; Tue, 26 Apr 2022 10:17:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIGS-0003qE-Ne; Tue, 26 Apr 2022 10:17:48 +0000
Received: by outflank-mailman (input) for mailman id 313665;
 Tue, 26 Apr 2022 10:17:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIGR-0003q4-DG; Tue, 26 Apr 2022 10:17:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIGR-0001f5-AQ; Tue, 26 Apr 2022 10:17:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIGR-0001rL-11; Tue, 26 Apr 2022 10:17:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njIGR-0005fJ-0b; Tue, 26 Apr 2022 10:17:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Vj88/pNfLBW4s4Nbb8VgiAnLiVS7PyntCrTkhouPA3Y=; b=d8g03NaLas1/qZXITr6QEZYud1
	YSo7qocmTzAIS2bzfYHLo4Akq4yCOKZ/S6v8lwzvo3gpH3hAyKAS5gMD8pom0vxgqNwbOTnxgjs+w
	IBTfWr5xMM7VrsNbbzxE2UMBAf+VDu4Of7L9fHhKEcfPyuqkG2TdcNkacbr6g5XrQGzg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169731-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169731: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 10:17:47 +0000

flight 169731 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169731/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   56 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  637 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:20:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:20:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313673.531337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIJ9-0005Cp-AT; Tue, 26 Apr 2022 10:20:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313673.531337; Tue, 26 Apr 2022 10:20:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIJ9-0005Ci-6U; Tue, 26 Apr 2022 10:20:35 +0000
Received: by outflank-mailman (input) for mailman id 313673;
 Tue, 26 Apr 2022 10:20:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njIJ8-0005Ca-B9
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:20:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8149ef11-c54a-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:20:33 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-CfLYma4wN4-v4LJADd9CQA-1; Tue, 26 Apr 2022 12:20:31 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB3PR0402MB3802.eurprd04.prod.outlook.com (2603:10a6:8:f::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:20:28 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:20:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8149ef11-c54a-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968432;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=8mF7sdl0jbfeZ0WAUgPUUQdPB6IKJPyJIzvkMw/O2vk=;
	b=kClV7PoNpTaqE86wVw+y2onooiLJwPThAs22jfqRmJfIok+MTdVV/JpmnDN3NC8uDgi6mo
	XxRrFkGeri+Ue45ca2834KI/MhM0lenqqMxJ35xUmig+5y5sz35V8H8Odf+swpm0nJgJ94
	D5uO75Gz83+1K4Gu9XyNbh2MNRr8qoM=
X-MC-Unique: CfLYma4wN4-v4LJADd9CQA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WhKmIofS9ZOShRW+BUCLulQDksLhhnECYVcp4ZCn15+pKtm0AO7ZWDjDsSY0q0f+ek8zkdiyIIZXD0l6/XJnofUOUAApgC1UFUCyqBPwn1PMW/hk4nA8A5m7+B1xigMBx2QowmLUKlYuQ1Xo2tg+CF43Y+DgdzpYFmkW584fRXvhOslMPC3FtC4LP3KY41WvsslDhfblFiHguU2/xK/pn65UEV09amJmZzW7y2r/I3PZSBbToK7KB+tRY/tQdHdIcoHfrLVdR/V4vPpnoUjTPZ8aLDROy+XVqYaSGl9R/ZqGupGb+NZ6hglJgQR9pBGA49K1YTIe4fqSwqNFREhdpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8mF7sdl0jbfeZ0WAUgPUUQdPB6IKJPyJIzvkMw/O2vk=;
 b=SmZYrStnqxHetS1O4zb4nBGnGn49IXxo9uVWkY4ol1jt8/0WBRQPMIfiITo77n1TeadRN1HRAC6XbuECStTh9n0Fewar/E7Sdi6ZGNm0vLx00/MIJXQ9M325kNZ6+rWPXxVj7HVZbjWW+LUZLv+UFSFBVN4LfZyHrwSaiw2IY9bdX2Z873IM/Efu+8lstxXIjgld62NCqIx9fZjhZZavT9loLrr27QSBaRtVr2AUPhfBKjne4xOcgZEQONtSrdkIJ3Z/56RcsJD4P04u6xme9HHSdPgwC3294n9ozyIVPQqb54c5mbLmnvj0jXn15pTAZBVsii/orwtvaEIaid+vIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Date: Tue, 26 Apr 2022 12:20:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 0/8] x86: more or less log-dirty related improvements
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Juergen Gross <jgross@suse.com>, George Dunlap <george.dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0027.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3da4a929-3b05-4ece-d1b4-08da276e62df
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3802:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB38025CC6F923C64C6A5B60AEB3FB9@DB3PR0402MB3802.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZLW0Pu/lgFwTPEApEDWqJqo2/I+vcxqAjBlUzfxNDRiyzZUg1biqk5UNypjo0+D0FRUHxZf6UT4AG0BjdZ9J7lpF7KUghHkEuBWiZfeY+YKYKaYtoTi6VTmx4IG4/BNN3zGMeGidmPdp2Ht1IrO/GOUMxi5H96oaQfWa7VZpo5ftztpDvLjpVhrbgmNhLrFD0SwTVcwcaivasTq2Aavj09wewsDaSwtcFSb/H9XpYtu/eTbLbnlZAP2y1a9HDCQa5/2qUhM0GG6IX0UqY4CAesm7+9LwBDhSVRGLdERaU03mbG/Tg77ZDOH213LdKADlluoVZUYSxK31SXcbOqPqVkeFfIcaMUDit3I1moZCSY8s7BG0RNw3CABxOwt6gWnHD+uznNGxp2pU0+xOmpJ2+b/eE3IxLKoRMXLH7+vDHyC3gfd+EB0bgX//S4EDvQgmMOAMvIb00CGTTkGzFXfISnXdgevwPXMNzW/xd4jiW2dWvmMjweO3i0oS9GpTs2rgEeG91Uw9TYu6+nBEfRMvGzjxTtDlmz7aJRfcCa7abiRZYf5IOp2EI39b8oDT0ozBspYRBsbIIML8LbVseS0ANy28Zk8WZflFEn6aZhhX1cdQXi6hi2eIl/8eJng6oshlJlq7TpcVpLQvrnJE7GjZeZenn+6Ong2S4BWQnfRnagCLaV5uv9uGwX6vT+Dr9PscEelpljaUFCS0/xoNy03I1PUOalwhiQxX6J+b3blI3Uj/OMlFPWv/+S0xGhgDLEfT9GD7+TB0ANOXk1JXX3Zwyg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(8676002)(66476007)(4326008)(186003)(36756003)(31686004)(316002)(86362001)(66556008)(66946007)(31696002)(8936002)(5660300002)(26005)(6512007)(6916009)(83380400001)(6486002)(54906003)(6506007)(508600001)(38100700002)(2906002)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NUF1Tmw0VkVzMURRejE5M0Ivb3NmZEI3K0Zod0R1MXlGNmpBK0prYWdTZDh4?=
 =?utf-8?B?bE5pUUQ2dnFCaXlBT0crZGJEbng3dzFoemVlRXhzVGtrMytGbkRqNEZKc0tr?=
 =?utf-8?B?NXdacXV2L0hmYjFnYk45V3Q1V0tndlh1bGp1SER0RDdoVGVZa2tFNHo0bXY1?=
 =?utf-8?B?d1ZySW9ZUkpEM2UrckgrSDQ0eHJNWlJ2THpGTmNEZGFsUDUvNmd1NGVBRHgw?=
 =?utf-8?B?RlJyd3ZVMDA0RVNYUHozS01lTmZjblQrVWxGbHhiakkvUEVYSFpELzNUUkg2?=
 =?utf-8?B?YjBURkdmR0xsVXVJSU1JejF4RWNVU2pheGpzdXUrWHlPMDNsWkxvRWxDL3I2?=
 =?utf-8?B?UEIxazcyYnJSeFBQUnArWm84UEtiN1FjOHJYNFNFMmNuMnN4NU40UDdpcXVm?=
 =?utf-8?B?b0ppRE4wdEpCMElCUTNpK3NmZjFUaEFFR1F5ZlVZdVBpSE40dTNoSzlXRkE2?=
 =?utf-8?B?S3FhRWsrRGZlaFB5NVBlN0lVMUdFWk1XMEJQMVlHa0FDcWppSXN6dGRJc0NN?=
 =?utf-8?B?ZmxMWXlQVHgrcnQyakw0b3JtZDZyU2N0ZC96N1BNa291b25OdG9JN2JRdE5F?=
 =?utf-8?B?Z041d1IveVU5RWVjeXlxREp3ZUo1T1VZbHBrK21XTGFOMkxaRmJvMHM5MFJX?=
 =?utf-8?B?TTFEek5sMjVxVmtpNklTdllza0xPaFN6ZUl0N2RUM3BkbjBtbzVvdUNkWmo4?=
 =?utf-8?B?dlNSeTUvSFJCU1ErVGV4VC90NmF1NytsUys1VlVoTTFiRGMvWTFsenpZamdn?=
 =?utf-8?B?cm1xaXppdkQwUHhtQmNUOXgrSG9SSVAvcDZDbVBvS1F6VEo4OTYvMDBjaTJS?=
 =?utf-8?B?SUtEMU1NRWJBdDRBSDU5bEpNalR6b0hSR05iV3dHUlRoR3BEdUpUdWM0bkls?=
 =?utf-8?B?UnU4NGhnbGhGY2ZIZlVnR3ByTHIxQlZDQk9sWmtDME5HdVFBUW0xc1gwQXJN?=
 =?utf-8?B?SXFLSEE5V3BSaDdZSWE2L2xBakRQVXhheVR3cEx0SXV6dFBQRTJ1TWJtcjJM?=
 =?utf-8?B?VFVVN0Y4cjFOOWcxT2Y1eGlGb0R5VytTeS9MdVNpbVJ2RzNKUzdMdFhBNG5G?=
 =?utf-8?B?ckQzV05VcHNiTHYzTDh6MFhSZC9yRkpzMERkWUJVKzU5bFBpTFJDYkYzZXIw?=
 =?utf-8?B?cXRwWWNIZnl6NkU3bFVqV0VIWGE0eU9VK1JFbVlyamQ1QlV3UldXYi8zRUV0?=
 =?utf-8?B?dDRHRlJkYWZCSDRObEY1KzRZeXlRYnJwZTlaR1BPaDN0ME02YUhaZDFjYTZ3?=
 =?utf-8?B?R0FJQTVYalp6VmErV2NKanJlTTR3dENzdS9sU2dBd2huMVhWNE5ac2hJN1lH?=
 =?utf-8?B?b24yR1hPaVNQaitTRDRJMExVU1ZucnJRUjhLaDFCVkRBWllpazhLYzNnMWFR?=
 =?utf-8?B?dFQwNlNtRjBXaVJIMkhaTkYxaEkyR2FEMnkyQzhwdi9jQk5tYmQwcVd6bStZ?=
 =?utf-8?B?WitnNDNQTXgreVNoQXpMcmE2VzlGWVRLcmtmR3lXT2pmcnBOMHRrcFBxNE5a?=
 =?utf-8?B?R1d1cVZJaVFjL0d1SUM5Kzd3ZXhGb3NuclNRSjJ3dnBLeFBoUmNGVm1ROXlD?=
 =?utf-8?B?YUV5ZldkVVRvRUZSSVNkcVY5NERoOENTMTZDYStFYnJGdVFOblhXblh4VExh?=
 =?utf-8?B?Qmd6YXNXSGRiSk9rRXphL2hZK29FQTVzb0pQTUN6aHBxc1RJMkQ0TGlFVDRZ?=
 =?utf-8?B?R0lkdXVkMkt0dHEzWkxEd2JBUzZDUFJOT1djYzNuamQxbFNFV0ZUZWZjOHo3?=
 =?utf-8?B?amEwWEpQMHJjcjRGQUtOdlpjVE9DUURoa3lKbGpjVXk3UytabjM4NG9nVEJO?=
 =?utf-8?B?ZG53cE9iK3p2bDJwaFBsTDR4M0h4WjVnUldsN3ptSEFYbVV4V051cXA2dDNE?=
 =?utf-8?B?cDZ0cWtBTm5RbUZyTzJWMlgydEtocWNhcnUrdWZvTVdYdWQ3WEk4bExudEtR?=
 =?utf-8?B?N1FLZlJQelNQK0t6SHlYdFpCeE5GVzNHazVFM011S1RyZ3lYSEFQVTVjSHNu?=
 =?utf-8?B?akNERk1OZnA0MUw5ZUhtT2JhVmVLcnhZTElOSTlJWHE2YUVBelVwY3gzR0k2?=
 =?utf-8?B?TUE2Q1BsSkREK2gydkU2RTZnajNMeVYyNnV5VWxBbTFSMXJKNkpSQ0FRMldO?=
 =?utf-8?B?ZUo0ejZTYTZQdDh3RFhYUG1zUER1bjdFWVBuaDBTMWozMHB6UDlUdTYwelpJ?=
 =?utf-8?B?SzlJazVRdmdsemtmUUs2K1pNTGNlc3NwQzFXaTFpdTlWQ05JTENqTm1IWVpx?=
 =?utf-8?B?bmxlb3VxWVk3djY4cXhPc0VacVFPMFFkRm5QSDY1YmdZSEN1OTRtWTBPVzRj?=
 =?utf-8?B?SDlidCs1L2NKbHYwalVpUGY2U0g2bzFtWFFJSTNvWEF4VUtBRUIrZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3da4a929-3b05-4ece-d1b4-08da276e62df
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:20:28.6161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4K3BDar9uOuBMOFRttqipKstCslqDGlqwsWzNrx7nKxf+vZxHGmySmW3Oeu2EYrpO6R0N3mNDT+TVVnfKSahHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3802

... or so I hope. This series continues the attempt to deal with
the ovmf change putting the shared info page at a very high address
(which is now planned to get reverted there, but the general
problem doesn't go away by them doing so). There are further issues
with truncated value, which are being dealt with here. But there
are also not directly related changes, when I simply spotted things
that aren't very likely to be right the way they are. And then
there are also adjustments to the underlying hypervisor
implementation, with the goal of making the returned data more
useful to consumers.

With these changes in place, a 1Gb guest which has "inflated"
itself by putting a page right below the 16Tb boundary migrates
successfully, albeit the process takes from some 20 minutes to over
half an hour on my test system.

No significant changes in v3 (individual patches have details); a
controversial patch was moved later in the series.

1: libxenguest: short-circuit "all-dirty" handling
2: libxenguest: avoid allocating unused deferred-pages bitmap
3: libxenguest: guard against overflow from too large p2m when checkpointing
4: libxenguest: restrict PV guest size
5: libxenguest: deal with log-dirty op stats overflow
6: x86/paging: supply more useful log-dirty page count
7: x86/mm: update log-dirty bitmap when manipulating P2M
8: SUPPORT.md: write down restriction of 32-bit tool stacks

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:20:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:20:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313674.531348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIJK-0005Wr-Hz; Tue, 26 Apr 2022 10:20:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313674.531348; Tue, 26 Apr 2022 10:20:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIJK-0005Wk-EV; Tue, 26 Apr 2022 10:20:46 +0000
Received: by outflank-mailman (input) for mailman id 313674;
 Tue, 26 Apr 2022 10:20:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuZH=VE=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1njIJI-0005Ca-60
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:20:44 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03on0613.outbound.protection.outlook.com
 [2a01:111:f400:fe08::613])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 876ffa8b-c54a-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:20:43 +0200 (CEST)
Received: from AM6PR02CA0022.eurprd02.prod.outlook.com (2603:10a6:20b:6e::35)
 by PAXPR08MB7599.eurprd08.prod.outlook.com (2603:10a6:102:23e::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.18; Tue, 26 Apr
 2022 10:20:32 +0000
Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:6e:cafe::61) by AM6PR02CA0022.outlook.office365.com
 (2603:10a6:20b:6e::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend
 Transport; Tue, 26 Apr 2022 10:20:32 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 10:20:31 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Tue, 26 Apr 2022 10:20:31 +0000
Received: from 5a9e5d68d459.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F054EF5A-200F-48C6-AF04-264CDA370597.1; 
 Tue, 26 Apr 2022 10:20:25 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5a9e5d68d459.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 10:20:25 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM0PR08MB3329.eurprd08.prod.outlook.com (2603:10a6:208:57::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 10:20:22 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:20:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 876ffa8b-c54a-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Kdg9zGBmcvBqjhfHXhjdyLyAVYZajORcqlZhqe8DMrlpyHkxxNKTlvON3/beSsXOVW6H8q8UVoCh97wvROlefyIIln1HLI1yLUvLh7f3z1nHfhaqIyf6wkIRox7m6bAkXlhawEwvdd38xqi/u0DHsrsXjL4MXYDKSxYdlKwEAatywdQtIvezQm8RxJQcJHisqeyF7d/Zvw2gfXE6otalwCM/dPIdjfan8vaoAIYJBiezQ1QWN1pPmvgScbLpqPi1u8GZLXaqlDcfYuACYwlmWGT13YCOQd0LlJ/CicwTKRyg3dzp7rGGbE/EKAbepV848gr5rOhGSQVadPJ3vZ77FQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tscUQdUglwfema12OFYVNsKYu0QcYLEJLvV9gkBCL6I=;
 b=AUl0ZpR9tnOpiYuW6PWUDJvwu1TDa3q14wgCDV2RFcuNrM4j3HHxiblDRXJHzuUVKKwpHa6wteY04IHw1DgxMShpRvwZsEGaBp4HvONyuF+dJu+8SH+BoRUGQUvENl0HAImNX1iUTp556pRyoSvrG2KNfsO61reO9amEVQF9FkiJ6deNA9tTh3elM4ezkSb1ztO1G0NZMKSES58A5EfJm8w6uHyNBccBBVqB0hCbdEFP/4qboZMZwVdfXMIL+GkZo0O57WEXpad1j8JUZd3JZqaDMjX7omAh5Oco+Vz+NExM1/GZ4nMsEQpx7xKWXqhqSEDEntvOM8mZTb1RUFQ/7g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tscUQdUglwfema12OFYVNsKYu0QcYLEJLvV9gkBCL6I=;
 b=xWeFPWFo7fGlpdN8/Gg5jN0f8fv0aQRwy9HO4n6Bc867iJ7oio5F3mmateX2l1r4gYyqSmS61GvVh3UtYhr6Ek0EDQBMAA193RjXoeCC28dyPeOzyXD3hX5AAOjI2F2UvQdxaBK1znhNE78mnauJVEHzoArIySFLB9Uq5Zv46wo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4b1efb985ecdaded
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U6a9kgC55y1eKvUZJi3XTAUDo9HFHASGMGhoPCuHKGXgqUflV5SJZG0UXEtZs/Xq0RD0IKS6nezFniyHp0ghicVElVqzAQcE2dslrIhEyp2Rw2sGgXJtSAY0X8dBJGC4Zkbfxi3ZSCokNg2KqWxRtk/CVLb/uoKr42zU+8wSubRkcG+C1bukIo1vN6C2mvc0o1yddqs1xseBLicylW/Z2J2bGDRbXuMupwsMBWGfzKg7C4oT6AD73ganafbMUUYz9Vwp2xZ0H3zPAxNWJELfudyVHXn0QL19bGran6iQn9M7OjRbWISOp4idQ6p3+klKf75n9xsnhpGLD3WpOc0Dww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tscUQdUglwfema12OFYVNsKYu0QcYLEJLvV9gkBCL6I=;
 b=Dp3NHjnelROHGOMPncnjjDet8Aa527ZLuhq37ODiYAIblUTxmsanRg/6nlZB4RmxoRsda/rNroJZxVaKEOfOJxLlNAO0PmYhQQgDwMMsDRAJZYsN0yvcNK/iW2J4F2igjbE8Z/YkA4YAaGP7eLlewh1x4JLMrqv8+FKq+buKUOny9ftKd3+oxj6UAo6eZgPMHuqCMUPIHD2GVUquCfAEBPQBDQPIGH/u3b3uIYSeIgJlckvqrIffiFV9KEE+uDo4B0CZU3UBMGX7DRWbQ/cCtZYApoKTE9fIW3XFKPNePn0uxcrFH31AyAzzlAvosPwIHaixDbVoW4lAlwUAY2CoPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tscUQdUglwfema12OFYVNsKYu0QcYLEJLvV9gkBCL6I=;
 b=xWeFPWFo7fGlpdN8/Gg5jN0f8fv0aQRwy9HO4n6Bc867iJ7oio5F3mmateX2l1r4gYyqSmS61GvVh3UtYhr6Ek0EDQBMAA193RjXoeCC28dyPeOzyXD3hX5AAOjI2F2UvQdxaBK1znhNE78mnauJVEHzoArIySFLB9Uq5Zv46wo=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Jan
 Beulich <JBeulich@suse.com>, Juergen Gross <jgross@suse.com>, Julien Grall
	<julien@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/build: Fix build failure from LDFLAGS mismatch
Thread-Topic: [PATCH] xen/build: Fix build failure from LDFLAGS mismatch
Thread-Index: AQHYWPk+OteSOJ5lX0epW57I3+JqnK0B/IQA
Date: Tue, 26 Apr 2022 10:20:21 +0000
Message-ID: <BABB5651-D588-4453-A2BE-03FE7D105901@arm.com>
References: <20220425230656.12808-1-andrew.cooper3@citrix.com>
In-Reply-To: <20220425230656.12808-1-andrew.cooper3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: e31daf54-6dc2-4456-754e-08da276e64fb
x-ms-traffictypediagnostic:
	AM0PR08MB3329:EE_|VE1EUR03FT049:EE_|PAXPR08MB7599:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB759930342E56E99EA7B79C439DFB9@PAXPR08MB7599.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 G/hi7hFYFy0DMhCu0dEtgwwOQfhoShSBnbVxG2BBn8b2zVNbdOgZAqfWSmfnW322sMHhFUSAQSJaveFBgaraijXibT8jp15+XVjOmVKY6zw8yrX7nSDtbrgqxYi+/Y4+77UP8rvtTQ0ZHP6BRkZ/P08/6Tc7O811oq6fZV+X7hk5jYsoCJ8w2mYAuO1eB6us/APGVIicXOeU0Ttz6JIOT8tJBi37fBzAB6NeDY6+RXVk6XMIVcVpEJ4BRJoQtLnCktGiZLo31c98f/ooPbxqcHnm7hY1gy2q3KH7pEc4T/fnmoQD00LAxXsinAtYk57cNZeVQlFNrORdaNxVXBc9oKFrEO9D0LWo+dRsZKIXVHoCRs0p0yvk+hLZ6Dde0BUSIE6KOqiDyJHJFVDQRovVQizUql80qMFOLxKUGJb3hFaJKSk9TpALn0TytvTTa+kSuJvSYWUr0kMXXjQydqenX88pNjo5A5eTEWBC5UJUozT8ihOnmOgbE/Oo47mehaRtyIj8YA9A4TU4o+qNrde+V75oGrR+xXvJQCHoH5rfTJ4Xf1Vf5cire/xPjOYbs8ljzkFf28BRIemnUnEz6rpcJEhyzIKTHZYRpTwtFhGAI/FJUSr086pg6hOj+ZWpIP25m6tPTXGMtiRiPcKVS+2jPzBsq4FHdrO2njdaEn3uEk8nMe4mgDbxGnGfuN8U6s8Y+NYh1f4mfdgFy7w1N9O8HKjBreiOtOx4od/uOxUBCC2+N37fP4urDx3pKGwet2MF
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(26005)(186003)(54906003)(6916009)(6506007)(71200400001)(6512007)(91956017)(36756003)(33656002)(6486002)(508600001)(2616005)(5660300002)(86362001)(2906002)(316002)(7416002)(38100700002)(83380400001)(8676002)(4326008)(8936002)(64756008)(66446008)(66556008)(66946007)(38070700005)(76116006)(66476007)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <70F71EEA88D0ED4DA35FD26D2983393D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3329
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d08617e7-b0ae-47d3-0296-08da276e5e99
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1bY8Gd+zwoh7lUW0NQeqvkgUqgaF6A/zin5l4mr1cUs97TVUT1hgClgX/NGj15Uf4ARVt4B+JTflYOum5D6BQbuOilgdX84cfE+Ne4uCIf91lFl+brXja8f41OIWNCRKU1Kp6S+HAp9dqkfkpKjZ+b0VF4RMenMNwb2feQjNJfQWSPJ06T03esZ0ZFxE9mHZNYjMPKMlP2X0KqRu20tE88MX+Gzrt8ZUckzE5HQ279Wg90/y5Yi2jDwKRh7W9Q2qjFnrY28JCy1zSKD9Yo7DruNmhSrdw6nJy7WAnRIXDtrYr3wJijMuCHBTJ+N7T4hYM93E904766T4IFbh+DxvQyYup8q95ZQSW8XdGAOHoDzgnebhKpQpMmMYzMe0scu+mAT/4Px6KODuMPjQAfDmR5rYJxZJjFFxx5sMfHfIbEldelQwyHRT8ffs4G/yNv98lnyX5F7rKAHlAsTPnr7IsJRirOkKWyOl47laLG5kyedYkZjweos7zfOyPsGRcocjPM0kTKNWgzWIatC0SHFQJMAF8TV0CxcXWAcCPwKBuV0JXBMIN7PsVRklm+76rEqRw0w7HCb3w1Z/X477MsaLvwJCpAVjZSbquYo9LAxrO28sDrJk/o7rZXreGWoVXjJcWvFxB58KxUHJBb5A/odVRl4tvQau32QDdGMCGoSAwoVcZXEHwT5pm9MrdQ3kdos8
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(6486002)(40460700003)(36860700001)(54906003)(508600001)(4326008)(81166007)(70206006)(8676002)(33656002)(6862004)(86362001)(356005)(70586007)(336012)(82310400005)(36756003)(83380400001)(47076005)(316002)(5660300002)(26005)(6512007)(2906002)(53546011)(6506007)(186003)(2616005)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:20:31.9339
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e31daf54-6dc2-4456-754e-08da276e64fb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7599

SGkgQW5kcmV3LA0KDQo+IE9uIDI2IEFwciAyMDIyLCBhdCAwMDowNiwgQW5kcmV3IENvb3BlciA8
YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBJbiBhIEdOVSBjb21wYXRi
aWxlIG1ha2VmaWxlLCAkKExERkxBR1MpIGFyZSBwYXNzZWQgdG8gJChDQyksIG5vdCAkKExEKS4N
Cg0KWW91IG1lYW4gYmVjYXVzZSBDQyBpcyB1c2VkIGZvciBsaW5raW5nIG9yIGV2ZW4gd2hlbiBj
b21waWxpbmcgb2JqZWN0IGZpbGVzID8NCg0KSWYgbm90LCB3aGF0IGlzIHRoZSBleHBlY3RlZCB3
YXkgdG8gcGFzcyBsaW5rZXIgZmxhZ3MgPw0KDQo+IA0KPiBJbiBhIGRlZmF1bHQgQ2VudE9TIDcg
YnVpbGQgZW52aXJvbm1lbnQsICQoTERGTEFHUykgaXMgc2V0IHRvIC1XbCwteixyZWxybywNCj4g
d2hpY2ggY2F1c2VzIHRoZSBYZW4gYnVpbGQgdG8gZXhwbG9kZSB3aXRoOg0KPiANCj4gIGxkOiB1
bnJlY29nbml6ZWQgb3B0aW9uICctV2wsLXoscmVscm8nDQo+ICBsZDogdXNlIHRoZSAtLWhlbHAg
b3B0aW9uIGZvciB1c2FnZSBpbmZvcm1hdGlvbg0KPiANCj4gSXQgdHVybnMgb3V0IHRoYXQgbWFu
eSBkb3duc3RyZWFtcyBpZGVudGlmeSB0aGlzIGFzIGEgYnJlYWthZ2UgaW4gWGVuJ3MgYnVpbGQN
Cj4gc3lzdGVtIGFuZCBib2RnZSBhcm91bmQgaXQgaW4gdmFyaW91cyB3YXlzLCBtb3N0bHkgYnkg
dW5zZXR0aW5nIGFsbCBvZg0KPiAkKENGTEFHUyksICQoQUZMQUdTKSBhbmQgJChMREZMQUdTKS4N
Cj4gDQo+IEhvd2V2ZXIsIHRoYXQgaXMgYSBzZWN1cml0eSBpc3N1ZSBiZWNhdXNlIGl0IG1lYW5z
IHRoYXQgdG9vbHMvIGlzIG5vdCBidWlsdA0KPiB3aXRoIHRoZSBkaXN0cm8td2lkZSBoYXJkZW5p
bmcgZmxhZ3MgdGhhdCBhcmUgb3RoZXJ3aXNlIGV4cGVjdGVkIG9mDQo+IHBhY2thZ2VzIChyZWxy
bywgX0ZPUlRJRllfU09VUkNFLCBzdGFjay1wcm90ZWN0b3IsIGV0YykuDQo+IA0KPiB0b29scy8g
c3BlY2lmaWNhbGx5IHNob3VsZCBob25vdXIgdGhlIHBhY2thZ2luZyBlbnZpcm9ubWVudCdzIGNo
b2ljZSBvZiBmbGFncywNCj4gd2hpbGUgeGVuLyBtdXN0IG5vdCBwYXNzICQoTERGTEFHUykgdG8g
JChMRCksIGFuZCBzaG91bGQgbm90IGJlIGluZmx1ZW5jZWQgYnkNCj4gdGhlIG90aGVycyBlaXRo
ZXIuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj
aXRyaXguY29tPg0KPiAtLS0NCj4gQ0M6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBj
aXRyaXguY29tPg0KPiBDQzogQmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0u
Y29tPg0KPiBDQzogR2VvcmdlIER1bmxhcCA8R2VvcmdlLkR1bmxhcEBldS5jaXRyaXguY29tPg0K
PiBDQzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPg0KPiBDQzogSnVlcmdlbiBHcm9z
cyA8amdyb3NzQHN1c2UuY29tPg0KPiBDQzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4N
Cj4gQ0M6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBDQzogU3Rl
ZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBDQzogVm9sb2R5bXly
IEJhYmNodWsgPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBDQzogV2VpIExpdSA8d2xA
eGVuLm9yZz4NCj4gDQo+IFJGQywgYmVjYXVzZSBDRkxBR1MvQUZMQUdTIG5lZWQgbnVraW5nIHRv
bywgYW5kIHRoZXkncmUgcmF0aGVyIG1vcmUgZW50YW5nbGVkLg0KPiBJIGV4cGVjdCB0aGlzIHRv
IGNhdXNlIHNvbWUgZGlzZ3JlZW1lbnQsIGJ1dCBYZW4gaXMgYmVoYXZpbmcgaW4gYSB2ZXJ5DQo+
IG5vbnN0YW5kYXJkIHdheSBldmVuIGFtb25nIGVtYmVkZGVkIHByb2plY3RzIGFuZCBhbGwgZG93
bnN0cmVhbXMgYXJlIHN1ZmZlcmluZw0KPiBzZWN1cml0eSBwcm9ibGVtcyBhcyBhIGNvbnNlcXVl
bmNlLg0KPiAtLS0NCj4geGVuL01ha2VmaWxlIHwgMiArKw0KPiAxIGZpbGUgY2hhbmdlZCwgMiBp
bnNlcnRpb25zKCspDQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL01ha2VmaWxlIGIveGVuL01ha2Vm
aWxlDQo+IGluZGV4IGVjMzQ1MjRlZDIxZC4uYThlMWRlNTQ4MjNiIDEwMDY0NA0KPiAtLS0gYS94
ZW4vTWFrZWZpbGUNCj4gKysrIGIveGVuL01ha2VmaWxlDQo+IEBAIC0yNTQsNiArMjU0LDggQEAg
ZXhwb3J0IEtCVUlMRF9ERUZDT05GSUcgOj0gJChBUkNIKV9kZWZjb25maWcNCj4gIyByZXBhcnNp
bmcgQ29uZmlnLm1rIGJ5IGUuZy4gYXJjaC94ODYvYm9vdC8uDQo+IGV4cG9ydCBYRU5fVFJFRVdJ
REVfQ0ZMQUdTIDo9ICQoQ0ZMQUdTKQ0KPiANCj4gK0xERkxBR1MgOj0NCj4gKw0KDQpUaGlzIHdv
dWxkIHJlcXVpcmUgYSBjb21tZW50IGluIHRoZSBNYWtlZmlsZSB0byBleHBsYWluIHdoeSB0aGlz
IGlzIGRvbmUuDQoNCkFsc28gaG93IGNvdWxkIGFueWJvZHkgc3BlY2lmeSBsaW5rZXIgc3BlY2lm
aWMgZmxhZ3MgaWYgdGhpcyBpcyBkb25lID8NCg0KUmVnYXJkcw0KQmVydHJhbmQNCg0KDQo+ICMg
Q0xBTkdfRkxBR1MgbmVlZHMgdG8gYmUgY2FsY3VsYXRlZCBiZWZvcmUgY2FsbGluZyBLY29uZmln
DQo+IGlmbmVxICgkKHNoZWxsICQoQ0MpIC0tdmVyc2lvbiAyPiYxIHwgaGVhZCAtbiAxIHwgZ3Jl
cCBjbGFuZyksKQ0KPiBDTEFOR19GTEFHUyA6PQ0KPiAtLSANCj4gMi4xMS4wDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:22:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:22:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313685.531358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIKw-0006SQ-0z; Tue, 26 Apr 2022 10:22:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313685.531358; Tue, 26 Apr 2022 10:22:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIKv-0006SJ-UN; Tue, 26 Apr 2022 10:22:25 +0000
Received: by outflank-mailman (input) for mailman id 313685;
 Tue, 26 Apr 2022 10:22:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njIKu-0006S6-3V
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:22:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c2aeb2b0-c54a-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:22:22 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-emKarZHHM46xiNh5QyzeEg-1; Tue, 26 Apr 2022 12:22:21 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR0401MB2325.eurprd04.prod.outlook.com (2603:10a6:4:49::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:22:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:22:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2aeb2b0-c54a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968542;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2D6z8DLOg+aZWIepU3LxQZQ51kG6eQiRLZZZoiI9SdQ=;
	b=TWK4NmAs0K0bkuB1jJafkyFRHV5+Q0zMShg4EobDJiTD8Y+/zX8yjSvt96GE15hkQtkIB+
	OJ67MZXKcsg+m9wCt6q2wlnerZpDCgfd4ss+Gx20/LkSdAahS2s+2KfhXfMMpes4wFsc3B
	IrMuToTS1PzIDBoRMfUXQM0wdmm7awI=
X-MC-Unique: emKarZHHM46xiNh5QyzeEg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KcfiAISGD904hY1BVLrMSBXTF1Fn2Dq5hmClD0/zX0R29JLFW77xLVZY8a9HTBL1DKH5CahiyzYtpQUKGxHcYf6sDUCv4xFc3ztVvyqBglVICd/X4UrJSrE51ZeF9JeRo4G2egcSI3fMlnFzC+QzzQ1Hp2h2VL23TP2GZccP6v9LUVqDOT7UP8D/TsONZA8idbo0RQrj3q3VlyApMFYroHZALftTCelF+p3gplnCGu77vHluvmOPrBeGyqvjEj+vtLdbMe3blPvI0F1jeCO1z+XmOXDohpxmA0awkxdUyp8dC1qddynvnBTrSV9oOvgk1WpmPKBAhfIio96lk493HQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2D6z8DLOg+aZWIepU3LxQZQ51kG6eQiRLZZZoiI9SdQ=;
 b=QxUJNP+ZfgXq0xuROprm48P3Vmwrqr7Tloz+6fwvLFu9vYJIPc/D7nF1wGo1VCLYaRX5TWyeT91kZjVAi8B4HlBr4bqz+qfGMvAGMcUboB9+JXrBV/IwcAnc+kU7zoQ/dtWylWWtIoiW/PlIHXMpHYqRahAlv1HzFZg/QpCcsyEa1vyDTePdVL+9WfJDtXyloMPKDU+DGP1MYYXNBC0K6INcXPBV04ByLQbtqtTVTW85JLeapDGiqOME+PppQ1xYviK56L2gfPTaKMh7wDEATTeTTqyJNXbjwiNK+XbHrVk3r/I3SEw/WnM37o7eV4V/Z2ZJR464UpvTzcDrgJcHlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c4b2b732-0015-e354-e4ac-6c6102e3fc25@suse.com>
Date: Tue, 26 Apr 2022 12:22:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v3 1/8] libxenguest: short-circuit "all-dirty" handling
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Juergen Gross <jgross@suse.com>, George Dunlap <george.dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
In-Reply-To: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0101.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::42) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 64e5fe35-b3a7-400b-e428-08da276ea51d
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2325:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB232500D226017D994E992907B3FB9@DB6PR0401MB2325.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FrA29hiqSta82wVniLc7JJvfOcp5uZKSocQ77MtamLuiZp1Le9LllPpiw8RupOEZgjYB6sH1PtM8/SVSwW/QzeepYLgO3cg8UEApVp2Yn6y1Hx+asS2ZQfqcbNWgjuFNnTnzM+TJq2NjXygQGAxYtmzQoK0cof142Co+StYfUh3f9WaAFqt5Eg2rNjml1+eA7vbhJxfzvxbRiHbKO3ZQsJ08lfdGaqnE3jhwzNT7ic4JEeciEnSQA35l1YaflFqr125+830sP+IoTszSiG6E03wU6nEx9GLIYmMvcBHT3IxT+hruyRmrpw2aTOQi93J6SYh7vXhPoiK5oX202KmcZzb+ir0uHCGIfMD09s7H3RR/Ul3Oea4E8obeO4GK7LHmvOyKyKNnTO2/4Q53dJ8QNi+fy8fCW9cNsC+SPHy14ij3veo2NpvJfTW0qca+OW/K9hlPVDjPQF0mAsgmUJKDRIS1hFP/3pIDAoM2Ol+6M9lCkW62KMVTceq8YZzAZA8c3L1kGNfXN36OFb4hdVAPDUTUqVaRt4GG8Y7pWxCUBQqGcxBFfpOriI6eKgniucbX1ei1uZmlyTXJwJ6E3SQq3WkON7A0zeJM7+lO9iLoHI9adn4zJZTYlMw1FzBuOzH8bI7pP29UO2pJV5rvxsb9JqHv65c2XkPhW5zPjBT2Bo8WjABj2r/rcmCjULoyHSjqshrhhHnrkaG+Dg5GBRdUFKpOd/CLiLpTOIlvs9GCfQAASlWfJnTCZD++cW85z5qWYWPSjXNlOOnfLtIDxNoK1Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(6512007)(5660300002)(8936002)(2616005)(26005)(66556008)(54906003)(6916009)(316002)(2906002)(86362001)(31696002)(38100700002)(6486002)(508600001)(66476007)(4326008)(8676002)(83380400001)(186003)(6506007)(31686004)(36756003)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjNmODg3YjF3bk1uWm5ydFVUSkpDdlFSZW9xdUowdFoxVWRSbThhL2Z0cEc3?=
 =?utf-8?B?STh5Yi8ydkN2dVpTMm1ReDlRYzB1THE3VnRaMitINW1XWTVndWQyaEdGemdL?=
 =?utf-8?B?dUFxODRmSFp4Y1lYTTVRTlZrMTl4bzN3K2N0eG5iUXpGajBlUGtCU3hqc0I2?=
 =?utf-8?B?alR5c0JpLzRxeUcxRzFCV3dndktHUW1kbUlRdjlkNDVkblgxR2QreUJXOXpH?=
 =?utf-8?B?S2RVMUhRdG42d1VJVXFGcXV5MFpTcUh5SDIwTnJhd0Y5NzVwb1Q1RjJHdmhv?=
 =?utf-8?B?NUdidDVEbHVtTXFSdHEvSkJlNkRrR3FrRktleHpMRWs1TGlDMjZVQURuRThB?=
 =?utf-8?B?UDZCOE1zdWRMRGk4Qy9CLzVDV2RncWdDR0lXV0xCUlc2cjhWK3QvQ2V2QTNx?=
 =?utf-8?B?Mm91SU0zTVVPMldUdGtZTnFJY2tDVVcxbmc3UzhUblhlbXhqcDVka0VxeFVv?=
 =?utf-8?B?RW5CQndkZFFzMXhPbmt5WDh2dHFXbjVuVGJhNlM2dkpzdm5FYU5rOFNnOC9j?=
 =?utf-8?B?RWhjYlBDT08xbkpqRm1vUXNUdUt2WEFNblcyYVJxbXd3MnZLM0tNblc1bnIz?=
 =?utf-8?B?Q1NFekZBSS9MSGhlQ2E1eW1veTdJTkU4VHRmUFdtL1lHNW9qVjBWZTlXZVIx?=
 =?utf-8?B?WVRGYk4zcFFaMk9yNWVvSE1IWXpvTUlUK1NNZVp4NDZJeU9HdFlRdXVhVzdC?=
 =?utf-8?B?Y2ExMGU1RFJ5eFN4bnZoZXVMWThUazk5eGhSTnpucit1S0JwSW4rWHlxQ2lO?=
 =?utf-8?B?WFg0SXVIYkJkUjdVeFpDRnNRbkk1ZjB5RnN0QlYzTjM2LzJNdXZGVDlXVmdp?=
 =?utf-8?B?TjEwcVFLaXJwNzZxQmNlaCtqRjJCTkt3QmxJSy9Kc1lNQnpiVVNwM3p5OGFT?=
 =?utf-8?B?dDBNNGFoQnNCeThUVFY0NFp2cVpjK21hZWdMdVpGQ0xMcWlNdXB2OG5GdFNZ?=
 =?utf-8?B?MmR0QlVjcHV1YjFjUTFkVzFxTlExSjdReWpaK3ZNZnVCY3JiZHdiZUlpbDVL?=
 =?utf-8?B?cC80b09nb2J5a2c1TFlBRGZEalpXeWtzU3g4WDJOTFVDZUJxL0xTNlFicWlh?=
 =?utf-8?B?RzFuV08yR2MzQzRqcEoyYmxNSnlmbUJxeUJsUHZIL1VVanplUnVyL2JYaWQ4?=
 =?utf-8?B?L0hLczlWVXJxNkpGR2oza3Y5NVozSExEU1UyaWVJa2NjbDdoMDZnZks5S3Bp?=
 =?utf-8?B?WG1MSmduQUUvQ25sZGJhd0tJRjk1T0t2NTBPRmx6SCs2ZXdENktMVWxaYUF4?=
 =?utf-8?B?YkhoMGxBMldVZ2w0Q2ZDSzI4Q0o0blpTQTJuYWJRNEY0VXBZckQzKzJ3RTBC?=
 =?utf-8?B?VWhkTnZZM2JqVlloUWZIaWVVcjdQSXhxQjUyVHlOL1oxdWFCUUVvdllCK3hE?=
 =?utf-8?B?dUx4d2d1eXloeVEvMUtJU3hLdzdOS202aUx3ZTk1MUd1aUhnNUpiYVJZeFFD?=
 =?utf-8?B?UmhvdVU4QStKVWNhNHRjWUdNbFN6Sm1HdWY2aEZlS2cxV1hvVFpCUWZ3VzNQ?=
 =?utf-8?B?ZWhBcUNSaDhZZWhETHVwaW1yKy93VDYwdGs0aWlDMThNN0FTaktielNNWFJL?=
 =?utf-8?B?bFJ3ZEd4MlZpSWFQUFVFc0NrNC9CdVkyU0hsZHczVENROERJeUp3Zi9GaDBZ?=
 =?utf-8?B?VjE0bUtCMkNsMlNXNkc4elJQUVFEWkdzRGd5d1VtVXl3RGJVL1RTbnRXUVFq?=
 =?utf-8?B?M2oyMmkrbDErQzRBQWx0MEU0L2FHOEpuM3YyU0c4Z3JXdWNTbEx2QkVWSkRW?=
 =?utf-8?B?ZVNuL2poVEZMUDRobTRuWENBU2kxWkhkMVJXeTYxN3ZsUVRzUUliZGkrRFZC?=
 =?utf-8?B?TGt4ODA5bDR4cFJrWTZ6dU05Z0pmcHgvbi8wanBhTUlKM2phY3FFL0tZR2Yx?=
 =?utf-8?B?eXNvZUU3bEhKNzk3STU4eXlQd3pvN2h1cFhrYlRVZmpMQ2pvMTczdWIzcEor?=
 =?utf-8?B?Sytrd2JvL0doMlVBQkxKOENlWFhMam12eTJzd2p2aFoxdmkzemZsQTdzdnRy?=
 =?utf-8?B?SGN0dmxHVmVxMk8yUnhFUittWHZ6VHZIRkxBSnFOZTlJMWcwOGhDWXBrMkdE?=
 =?utf-8?B?T0xHNmNXNGtTTXdpME5zV3U4MVFzSzExYkhiOHhDMndSeDdBRUY0S3Rwem5I?=
 =?utf-8?B?SFE5NjdEWVR4Tmx5TVAwbmR3QVd0c201aWNzc1pRUnR0Zmp1QS96L3lINGJu?=
 =?utf-8?B?YVVwWld4dFJqeGxYWHIxNzhxdzBySnZjdkxOZlR5ZEJDSFFjM2tTUjd2aTcz?=
 =?utf-8?B?bllUMzM5NzNyeTZnY2w2aWZETHhsNzU3aW16b0V0YjdzVlhvbVpuYVUxNjRt?=
 =?utf-8?B?bnNsck1XRWJuc2ZqUXp4ckdjMjhJQ3c4VmpnVWxKMmM0N2dKQURpdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64e5fe35-b3a7-400b-e428-08da276ea51d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:22:19.7369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ouC7P2uP3uskeKkA0NP9JBtxfd+PnQVCQCCIx8v6sC469xCKHqjsBcXyvuk2I00cmeq5seqRG0mJBNWFXpWbPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2325

For one it is unnecessary to fill a perhaps large chunk of memory with
all ones. Add a new parameter to send_dirty_pages() for callers to
indicate so.

Then it is further unnecessary to allocate the dirty bitmap altogether
when all that's ever going to happen is a single all-dirty run.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Acked-by: Ian Jackson <iwj@xenproject.org>
---
NOTE: Ian demands that this not be committed without also committing
"libxenguest: avoid allocating unused deferred-pages bitmap" (because
of the ugly -1L).

--- a/tools/libs/guest/xg_sr_save.c
+++ b/tools/libs/guest/xg_sr_save.c
@@ -364,7 +364,7 @@ static int suspend_domain(struct xc_sr_c
  * Bitmap is bounded by p2m_size.
  */
 static int send_dirty_pages(struct xc_sr_context *ctx,
-                            unsigned long entries)
+                            unsigned long entries, bool all_dirty)
 {
     xc_interface *xch = ctx->xch;
     xen_pfn_t p;
@@ -375,7 +375,7 @@ static int send_dirty_pages(struct xc_sr
 
     for ( p = 0, written = 0; p < ctx->save.p2m_size; ++p )
     {
-        if ( !test_bit(p, dirty_bitmap) )
+        if ( !all_dirty && !test_bit(p, dirty_bitmap) )
             continue;
 
         rc = add_to_batch(ctx, p);
@@ -407,12 +407,7 @@ static int send_dirty_pages(struct xc_sr
  */
 static int send_all_pages(struct xc_sr_context *ctx)
 {
-    DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
-                                    &ctx->save.dirty_bitmap_hbuf);
-
-    bitmap_set(dirty_bitmap, ctx->save.p2m_size);
-
-    return send_dirty_pages(ctx, ctx->save.p2m_size);
+    return send_dirty_pages(ctx, ctx->save.p2m_size, true /* all_dirty */);
 }
 
 static int enable_logdirty(struct xc_sr_context *ctx)
@@ -502,9 +497,6 @@ static int send_memory_live(struct xc_sr
     int rc;
     int policy_decision;
 
-    DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
-                                    &ctx->save.dirty_bitmap_hbuf);
-
     precopy_policy_t precopy_policy = ctx->save.callbacks->precopy_policy;
     void *data = ctx->save.callbacks->data;
 
@@ -522,8 +514,6 @@ static int send_memory_live(struct xc_sr
     if ( precopy_policy == NULL )
         precopy_policy = simple_precopy_policy;
 
-    bitmap_set(dirty_bitmap, ctx->save.p2m_size);
-
     for ( ; ; )
     {
         policy_decision = precopy_policy(*policy_stats, data);
@@ -535,7 +525,7 @@ static int send_memory_live(struct xc_sr
             if ( rc )
                 goto out;
 
-            rc = send_dirty_pages(ctx, stats.dirty_count);
+            rc = send_dirty_pages(ctx, stats.dirty_count, x == 1);
             if ( rc )
                 goto out;
         }
@@ -681,7 +671,8 @@ static int suspend_and_send_dirty(struct
         }
     }
 
-    rc = send_dirty_pages(ctx, stats.dirty_count + ctx->save.nr_deferred_pages);
+    rc = send_dirty_pages(ctx, stats.dirty_count + ctx->save.nr_deferred_pages,
+                          false /* all_dirty */);
     if ( rc )
         goto out;
 
@@ -801,8 +792,11 @@ static int setup(struct xc_sr_context *c
     if ( rc )
         goto err;
 
-    dirty_bitmap = xc_hypercall_buffer_alloc_pages(
-        xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size)));
+    dirty_bitmap = ctx->save.live || ctx->stream_type != XC_STREAM_PLAIN
+        ? xc_hypercall_buffer_alloc_pages(
+              xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size)))
+        : (void *)-1L;
+
     ctx->save.batch_pfns = malloc(MAX_BATCH_SIZE *
                                   sizeof(*ctx->save.batch_pfns));
     ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size);



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:23:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:23:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313690.531370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njILX-00070W-BA; Tue, 26 Apr 2022 10:23:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313690.531370; Tue, 26 Apr 2022 10:23:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njILX-00070P-82; Tue, 26 Apr 2022 10:23:03 +0000
Received: by outflank-mailman (input) for mailman id 313690;
 Tue, 26 Apr 2022 10:23:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njILW-0006S6-JL
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:23:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d9bec955-c54a-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:23:01 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2058.outbound.protection.outlook.com [104.47.9.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-6J0kHTrZPsScE7Om-U38Cw-1; Tue, 26 Apr 2022 12:23:00 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM7PR04MB7157.eurprd04.prod.outlook.com (2603:10a6:20b:118::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:22:57 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:22:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9bec955-c54a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968581;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i2Oz0ufU5ia0z18sXCTR49UR80Yr0jdm8EcVB0xMZ4o=;
	b=Cfh/VbTx+tWH7JWKLbmOS5f5sNk/jTyS2KA0yfOLjoA7jnLuonyqcfa8i/DT3IK8sxSmUL
	Kd28uVNOGwQsMz3zETMsMODoykfIpGCvGmxnfeBW6TLfjbV4Gxh/OD1KR/EtbNvd7oZgJQ
	dqHQ8kqw9y8V4T6l8DfXAvi4ZDN/e5A=
X-MC-Unique: 6J0kHTrZPsScE7Om-U38Cw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j6y6d2WGVl1MPJyg5hlOK5lOLKJ2xMQgRCHBfCG4utAIiS4GtyNOBk3kQbYS+RLcVvt88M1AvwqOuqCcqHhT/pDV9H7o+fWjBvWHeDqq31zR7cuD8bBstXgajaeq1RxAgq0/A02a+Qaf2krgB8OZgb6DhcFPEiLlxs9xgEQBSyMzMHJJuMBunc6u60SQ9hxalXc7OJFkFHetTIOVd98JyDFfuoMediXffgpxl/gLbeDXnyZfV30yWS8niajOhFC5NA42t8Bgb5d7Qw3qK7Uu6q4C/Gqv7GTzmIQyot8qI30qeK7D+cYCCUS1wKpJ66MrusbXEWOPDJq2WtvNrqDjSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i2Oz0ufU5ia0z18sXCTR49UR80Yr0jdm8EcVB0xMZ4o=;
 b=MFMy+yHGcm0SjH8qUbzBLYTFhi9CaHs7lwpy9lMLkJSVAD5li8GgWUtzMcy8015hYuSCyU5ZPS7GUUikYlYyd6BuNEhCA7nxu99QEdmzOTih+og64JxEd3uEV2OmPD3vdXn9iJgSsB/2t/owIzfQg6tpo08kNNaTP+EkHrjjz3dC+R3VipgUJudRD5z/D++MOUfor4st3BiUJbP1osEX61Mgp+KGMX8/si0M1ka/+/ZxSua4Z6/PyFDQgd6a8S/ePA74aWuQmFLAKttN6P/gJKauRUxRCsBfDSNwW5DXqIuN/D/w1kWgPj3NLZ8relthi7Xf7sK2bREgdrPkItxitA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1f89601c-3226-d604-5681-aada9b3421d2@suse.com>
Date: Tue, 26 Apr 2022 12:22:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v3 2/8] libxenguest: avoid allocating unused deferred-pages
 bitmap
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, George Dunlap <george.dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
In-Reply-To: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0104.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::45) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6f56708a-076f-4bef-02a1-08da276ebbce
X-MS-TrafficTypeDiagnostic: AM7PR04MB7157:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB7157EB3956A4EFD089601397B3FB9@AM7PR04MB7157.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XEejfc+DVGCnsWMm5hkNE2oyxQhLwA4Fl0icFZCn+AUXoW/vGIUX7Fh/eC2SpfgPOa4UaZyAx4NPfVLp+y65VrnV1YzxDXFjYcMxutukbCYoE5DVOjZ4jmYgU2AbBZvGlzPoUGXYB3GV4Gd/EAkqDN6Y++cKOQCYe2GCmZAKv+AZOzq+eeeDI7vyjuN+mI+X27LZ8rfGlDkQbwo/bLTES7whwGaEGp50L5ZnLPD0ZaNt4c4Ftya4G18N4M/hOUL1na1Fi1PpvGutKe/wqBG3cVvvZksAqZoFOcZMnQcrSE9sOyfUk6TonqadBaGpzJb0gzGWwuhYz4wldEtraXIWituB4jj9PNTKsYvR5Q85kw5eJ1N0ck/8HZ/zGHDTcc/oEo6pWedOiRSWHE2ecvCh4N51cnokin96UaAHC+BhUZnJ13LekbYR7AwJ7RhBwdBAwlDXTgdejAxcV3/02Ei1rZpQUh53+SrFgDaoSf7XexiUYhYrtrrpxyYRiwcCuyua1TCw1n45IOhQT9ehs1aO1pogQub1M13DMZjipWmV03I1TM+XgfdIibjegG7C/270hqrncbqw8ZwPM7/BCJmqXfJwmnqcYNeTbDjOI1uOe1Xen9Dbj+zG0TSOrkCiTMhPWn/S8358cMKlyKvmKgzbBFfJIKGmVgUX4B2X+l/0B9LncTIoA2WN79pOIehogX0ep0vOhg58X4SYmvRgq8mdxESCR9AKf7EEEmPMPX/NABJfYxOKBXq2C9gQOHYrYHZG
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(508600001)(316002)(6916009)(8676002)(4326008)(31686004)(5660300002)(8936002)(38100700002)(6506007)(86362001)(31696002)(66476007)(66556008)(6486002)(6512007)(186003)(26005)(36756003)(83380400001)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cFJ0bnBEZnNKM2N5STJlVDZWbEpaVXdmdmYxVEhPbUJRS29abWxja0k1RTlv?=
 =?utf-8?B?Q29YbCtJZlRyaXYxT0dWeDlrd05SaU5aUTduTW01dTdzVFR0WktTS3RTOGlJ?=
 =?utf-8?B?bGR0NmRhWHFJY3l4bE80ZXhoaGxTN0gzMGx5a1ZNT2g1OUZpUmxtYXFEZ2hU?=
 =?utf-8?B?MWdlcHV4RCtzbU1uM0ZGc0NKTko0blZmYzBGVjlWL3hCWSsySE9xRmNiNUc3?=
 =?utf-8?B?NWVWUSsxTW9sYzZXbUhKTVlqSlJodVNCR28rMkU4aFJtSS9jWDNHRVFubmFr?=
 =?utf-8?B?NW1IRFREemNRdHpFQ25LRko5WmdWbGJSU3BLVVY5RkdPLzVCSThuWFJleW1Z?=
 =?utf-8?B?Sys3c1ZSaWVjN2NTVElQVk9uWk9kVkQzVGNLSmhyeXh0dER5NUxzTSs1UVA5?=
 =?utf-8?B?L0VUaGhPV3JvTDJXSWhzZitIUE9yYjNDb0xpVHlLTSthaHJQVlo4RlRic3RB?=
 =?utf-8?B?YlNFTkhqRzVBNkhRY1J0dTN5cUpMaGtvWk0zRDlsSld3TG5TTEtHT2F4bWJh?=
 =?utf-8?B?S1N2RDQ5SFFzRzFwRk03dDRUMGVrT1dJaWV5ckJLUllDQlk2emoxajlndy9z?=
 =?utf-8?B?d3RBTkJFM3NkWU9sYjhnbHlYSlJTcktuT2l6ZUNmUXdiYlpLbFo4dkk1VlJ4?=
 =?utf-8?B?bmhjNU8wVENxVTBKMjZVdkF4VTZzZkY1WndUQ1g3MlgvVUNMRVFrak1NNGNJ?=
 =?utf-8?B?WUcxOURoRzQ4SmZTY2xOOWxTejA2a1pxTXBrTXZtbXZWZFVrdFVzQ0pYbGVV?=
 =?utf-8?B?em5qTGEzRjByZEh3cTlSZkdZRGNNR29GTko0b3RnUzh4WUhBQ3NuNzRQMU1P?=
 =?utf-8?B?dlFQc1Y2eTgrVU0yZS9iZ0kwQktiOWpQSUJ0eXRqU09yNkcxU0UxK3c3a2Fn?=
 =?utf-8?B?QURXb0JXVFZHTFN2M0xMK3J1NGFvNWx4N3VseUZkaXlOUkRoY2tDRStPTGp0?=
 =?utf-8?B?UTUvUFNoeDFPbnpDR2Rrc3NHTGhIL0l2ck9VT09jM2wvcFQrNXM5YlVWYklX?=
 =?utf-8?B?R0txWFdGcHNsc21vMmNmNzRJRm1uMGUxQ2NBUXg1bHhqUlJZVWdyM0VuM1dv?=
 =?utf-8?B?bmoyVXUrbXNUeko1cGtzQ0E2cUxudHhMNVViVlZvOWhzbGVYM0NDRU96UnJ5?=
 =?utf-8?B?RGhkR1BnajdneEZmOGt6NlpiL3A5M2JNTkVhVm1TenpTblorVk1iNHU5dHMw?=
 =?utf-8?B?STA5WFpDUDBxV1pkVERsVUxIV01tUDI5MWJNSEJNYnhrUWJaR0pSY25PKzNj?=
 =?utf-8?B?ZEtEL0wrRk9vNy82Q25jNHd4QlpQZStZb0pBamlmaFFxQWtqRGFzVlU1ZjFk?=
 =?utf-8?B?UGlPVC9XK1liZU9LUWZLZkl5TCtyT3ZoWGc2VDRVMElvdHZLS1JPRENXYklI?=
 =?utf-8?B?R0oyMWY2OWhQdU1QN1I5cFp4UXFOaEROVmV5TFJqT3craDBTcGhiQ3lnUHRJ?=
 =?utf-8?B?N0NySEZ3NWhLYXl1bk53Z1lYOE50ZVJKb2o2TWxOZklVYm9kakN3cnIwalNV?=
 =?utf-8?B?Yi9rSmk3cEwvaDFaVnNOcVpHM3RCbVM2ck9WSE5hTWhFOUpjaWtMMXJvaUZG?=
 =?utf-8?B?UkJpU1dWVktMRVdoZ0t1L3VtQmhWRkgvRGlET1VZNEo4QkZ5L3hROGd4cXZo?=
 =?utf-8?B?b0ZJYmNPWE9vSFVsUmx2VVZ1QTNGVUhRS2pHWnNpU2Z0SE5TZWdzTXR4c1NL?=
 =?utf-8?B?OVBYWHNKWUxmVUN5eU9heTFWaVVHSkRDWmlpNzV1QmdYR1NNbk9qV2VrUE81?=
 =?utf-8?B?U0M2UmZZYXRBSzlScW1OajVDajRhSkE2WDZxNVdocDFpQ1ZEWStxYmZoZXFr?=
 =?utf-8?B?aGJBZmJiYkovK1dXaDBVY2VJWmU3MllxTk9XS2RtRGlIUENuVnZ0VG1HTW1i?=
 =?utf-8?B?NzBJYVg3aDErVWRPRkdTTk5vblh3WGVibDIvU1V5S2RGWGZOcE9pb0NkSWFX?=
 =?utf-8?B?SHZmdUJ4eFpNL1dnNWNJR3ZWOVZSM0JrM2doUjhuL1BmZi9RYkdnYTAwUWFh?=
 =?utf-8?B?cWJSQXI1UE1WTFRkT1ZzS1lvY3Z1dlJ0dXB0MzNRajN4U1pUclN0akFTQXVH?=
 =?utf-8?B?MUdtVXZlQkMvM21xa0FhbjJJTDM5elFJUEZUWnlGWnVmUTZVVmRSK3FOZUF5?=
 =?utf-8?B?aThYUUdLWnRWOGZlaXZIb080eVIvMDhwYjROeVhVZndPdE5lVFBRd0pUb29u?=
 =?utf-8?B?NUlTV1pTNS96bis4TmwvT0JxdFM5b0orTUlIMUk3Ny9xQjlUOXU1UFRIVTc1?=
 =?utf-8?B?VFBZRnVFcWZ0dXZtUm5HMnVJUGZUODFZdGw0ZksrOWgxeGFMNGZUZGdqb0dK?=
 =?utf-8?B?bUF0SUhyL0ZGS0pvRXF6aVkvU2ljdFpSanhwc01pWDQvdWNLSkFmQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f56708a-076f-4bef-02a1-08da276ebbce
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:22:57.8166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DIPhLCoUEr6SNGg0CyemDOFdLzvL8fkkIgoF9ou7Q541UVBe4QiPK/NXuaEXlSDhhDVBATYMSjsyC9R0CT02zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7157

Like for the dirty bitmap, it is unnecessary to allocate the deferred-
pages bitmap when all that's ever going to happen is a single all-dirty
run.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>

--- a/tools/libs/guest/xg_sr_save.c
+++ b/tools/libs/guest/xg_sr_save.c
@@ -130,7 +130,7 @@ static int write_batch(struct xc_sr_cont
                                                       ctx->save.batch_pfns[i]);
 
         /* Likely a ballooned page. */
-        if ( mfns[i] == INVALID_MFN )
+        if ( mfns[i] == INVALID_MFN && ctx->save.deferred_pages )
         {
             set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages);
             ++ctx->save.nr_deferred_pages;
@@ -192,8 +192,12 @@ static int write_batch(struct xc_sr_cont
             {
                 if ( rc == -1 && errno == EAGAIN )
                 {
-                    set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages);
-                    ++ctx->save.nr_deferred_pages;
+                    if ( ctx->save.deferred_pages )
+                    {
+                        set_bit(ctx->save.batch_pfns[i],
+                                ctx->save.deferred_pages);
+                        ++ctx->save.nr_deferred_pages;
+                    }
                     types[i] = XEN_DOMCTL_PFINFO_XTAB;
                     --nr_pages;
                 }
@@ -659,7 +663,8 @@ static int suspend_and_send_dirty(struct
     else
         xc_set_progress_prefix(xch, "Checkpointed save");
 
-    bitmap_or(dirty_bitmap, ctx->save.deferred_pages, ctx->save.p2m_size);
+    if ( ctx->save.deferred_pages )
+        bitmap_or(dirty_bitmap, ctx->save.deferred_pages, ctx->save.p2m_size);
 
     if ( !ctx->save.live && ctx->stream_type == XC_STREAM_COLO )
     {
@@ -676,7 +681,8 @@ static int suspend_and_send_dirty(struct
     if ( rc )
         goto out;
 
-    bitmap_clear(ctx->save.deferred_pages, ctx->save.p2m_size);
+    if ( ctx->save.deferred_pages )
+        bitmap_clear(ctx->save.deferred_pages, ctx->save.p2m_size);
     ctx->save.nr_deferred_pages = 0;
 
  out:
@@ -785,24 +791,31 @@ static int setup(struct xc_sr_context *c
 {
     xc_interface *xch = ctx->xch;
     int rc;
-    DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
-                                    &ctx->save.dirty_bitmap_hbuf);
 
     rc = ctx->save.ops.setup(ctx);
     if ( rc )
         goto err;
 
-    dirty_bitmap = ctx->save.live || ctx->stream_type != XC_STREAM_PLAIN
-        ? xc_hypercall_buffer_alloc_pages(
-              xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size)))
-        : (void *)-1L;
+    if ( ctx->save.live || ctx->stream_type != XC_STREAM_PLAIN )
+    {
+        DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
+                                        &ctx->save.dirty_bitmap_hbuf);
+
+        dirty_bitmap =
+            xc_hypercall_buffer_alloc_pages(
+                xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size)));
+        ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size);
+
+        if ( !dirty_bitmap || !ctx->save.deferred_pages )
+            goto enomem;
+    }
 
     ctx->save.batch_pfns = malloc(MAX_BATCH_SIZE *
                                   sizeof(*ctx->save.batch_pfns));
-    ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size);
 
-    if ( !ctx->save.batch_pfns || !dirty_bitmap || !ctx->save.deferred_pages )
+    if ( !ctx->save.batch_pfns )
     {
+    enomem:
         ERROR("Unable to allocate memory for dirty bitmaps, batch pfns and"
               " deferred pages");
         rc = -1;



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:23:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:23:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313695.531380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njILx-0007ZG-L0; Tue, 26 Apr 2022 10:23:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313695.531380; Tue, 26 Apr 2022 10:23:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njILx-0007Z9-I0; Tue, 26 Apr 2022 10:23:29 +0000
Received: by outflank-mailman (input) for mailman id 313695;
 Tue, 26 Apr 2022 10:23:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njILw-0006S6-F0
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:23:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e952a98c-c54a-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:23:27 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-ipV6PnBsNTyxy3yjjMQcPw-1; Tue, 26 Apr 2022 12:23:24 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM7PR04MB7157.eurprd04.prod.outlook.com (2603:10a6:20b:118::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:23:23 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:23:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e952a98c-c54a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968607;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Poou7+ywHc4+47fsnUn586v0ma66GxF2Bm5uaMw2apo=;
	b=TqtgYcwvRS73UvUcPWSnbV36c/aHhPnGFPgV0BifDy7twyWu4K2hdcfPQ3CyUWtFr5Qo7+
	5LJioFxhF5NC9IbiJG/1ey7CYIsCvmLlEEUzNTM31bAkNbQKz33a/DvhxEvHUoAJzgnsUS
	VvlYoNivBO5Rc65PFt4Nd7rVl2riz/E=
X-MC-Unique: ipV6PnBsNTyxy3yjjMQcPw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lqkb4fOqLW6z91GNCzD+oIYyhISDu9h7dgaadXi5FqpuISqLwzNqFwwqxVc3qRPNZ7t7qknWslMCnvHqxZVdwfWUJTowN/0BATaBFnUFDrUqUufgHLJdBH6RumldcDERrMPfnFbkOBXnzRGow9RyKv0OYDvoiMfE1vih/6JhSgX16WicLpFZAXGgSJUlAHfJHVwAUqhjXlhZs6eAhbirTuqf3HMapKBlO3V3JRyN7L52yTIJq1aRXeTkQOJhp5ES8Q9AaGr2lnXlt9KI9IBb9Bc2lqMzLhHmuIkY821WbQMpCIzvJA1fPuZhxoL3jTvWSDAlHCL0hA9R7nrUBZW4Pw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Poou7+ywHc4+47fsnUn586v0ma66GxF2Bm5uaMw2apo=;
 b=OafK9F/udmJjYocg0DJ1QQvIMYy+x4Y00+tCEMUII2OvuZKqLgqFZnqX7PyDyz4cEaO2Fs1XoWvK3n9zReJAlrSDzljO+jycBH1FB+ZkWvD8SB+G82KpnQHL7WnyoGRO0zNcMMVb3T1bfaNM610vY6r42+cSbUfF52qChtVKz5gc/ynBi7OrKUIqX8ivH8yqa3Ue+KEmbvVRmNtGd83/qt4aFn/riSNHkbAQhZrlhcjZU2WvVKS8Zame27hlS8yxSocBPrP6vfgzvzibPg9VkHWlsXKqSxzt96OFsab9Obc+uCabCj9uWk4nkdMZWNy4RfrrOM5+8nl/ETADR0F+Kw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <53a64a0c-6286-01e5-7eab-1de1543a9241@suse.com>
Date: Tue, 26 Apr 2022 12:23:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v3 3/8] libxenguest: guard against overflow from too large p2m
 when checkpointing
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, George Dunlap <george.dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
In-Reply-To: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0030.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::43) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e8779b6c-4163-424f-eeae-08da276ecac7
X-MS-TrafficTypeDiagnostic: AM7PR04MB7157:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB715742A966EDE938FCDDA2EAB3FB9@AM7PR04MB7157.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2iDo67v2IT0AFej4WUcufwEnd1j90FvqjDMtwKPsfiN4WWbk11eEpVZI8DW4OrlnVmd0xP/4oyOhba0xc1iE1dIMJbvEigeRHmDE22LDS16lc+iZUUMujzUV1M5S654mLWWVq/790AVVKFwv9DxVUr+Cbu7l7961Im8wx1h83hkrVCGXxkYB+hZKZ1XRlMnF7oJm0NEk82p+CcRqFcer68GJWvH7bTHjYRAJBvL6MfTtfHxcX9nxEUAf7091q+zLKktsX/MYxFutsvc7ZmGiu+lA/Le0JaKKmK+aL6IBwOUAtXEruOeBRgdujplzmN21YUWtmzJSFqT8/KcDj+qK5/G9LYBuuj8VodxMNelYFERIF/Ri6qZlsmde7vLM2isUaZ+htdbNqEtiUhIoUVEdLhnlHDsvE9NpcU7E6WDquv3aQD2hZKfnS7N+DmnbtPG5QjkWK5Bw5bL57GMG/hRDv1oqK7nnU44u+7vQ6byeBbZZbu8xpaevgHmVJ3IP7wSQWW4yV3fiZrP9CGb4HLSItM2ugtwOcFInHbtpYK3/U84tLcLaT8A6yjhTdZPAjuwobPctvJQOqSCdoiADky9HPlJGclcCHb8WGThJ2rdNh820BrhyorZFIlXMr6xxjROreaBsblI++RmzU+uoNa4lYGl6DTZXHsooopInG6u0vuzFsUq0jXfCF8lAzcoqBv2DzWZ1BMIRxEObKyTCQPwaut/GrRybbc/GTluEDjQQpoVFor86JjXyzo6NUYU6WL/M
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(508600001)(316002)(6916009)(8676002)(4326008)(31686004)(5660300002)(8936002)(38100700002)(6506007)(86362001)(31696002)(66476007)(66556008)(6486002)(6512007)(186003)(26005)(36756003)(83380400001)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z1BFcXA5ZFVJZ3pOaVZtdzd6VXdIQVUzeFhuUkJHdEttMGVkRGp2OE9kOHQw?=
 =?utf-8?B?N3FWN0RseWlDWUMrMW1ONjFZeE96TGx4MkJ0TklsZ0V1bWZPS2p6d2ZlQ3hK?=
 =?utf-8?B?cGtxVVl3M1NpRHFSV0FoME5DNW8wWEZhTDhYUU5YQjFBSTJVQ052QUhzdkVT?=
 =?utf-8?B?eVFJYmlNTHVDc3BNVDF2Z2Y1bDhpMXJ3SXJFOVdJSmxER0dkVmFoTmpiQ1FE?=
 =?utf-8?B?SGRUZXppQmUxSGRJbzBoMjRBeG9WRnRFdTVudkY0akxMRHF1NGxYMStlWjFR?=
 =?utf-8?B?dE1XeDQ2SEEyeHptcmlLUDhwMTlFZVIrZE1rV0VGYUx6WTRvMy9NRDBXNnp4?=
 =?utf-8?B?MnN5TnlLUjU3SEZDZE9NTzRpbVdSdjh0QXJaNm5EeGtObWVsb28wczlSbld4?=
 =?utf-8?B?NmZzMy9QdDNhV2MzTzAyZTgxOGpkaERDcVlDQWQ4a2crZ3k0R1AyVDZZYVpU?=
 =?utf-8?B?TkYrV1pYejJXUjlvVTdDU1JwL0l6Nk9IU2RTQmg2ZXFPNlJ4MGdNK2NUK2Rm?=
 =?utf-8?B?eVZlY3ZwSzUvOVdOa2prTnBoYTRKSC81WlpKd1NJblA2QTIzK3BJU0lMV0xP?=
 =?utf-8?B?TDQyWkQ4MmNVazE3WEhkSU1CcGFlVUl3L0tzOFJoV0dnMFhPbTQxcC9LK25W?=
 =?utf-8?B?cXJCTXpucmNkQzJZRTVqWlJaUDYydkVnenUvTVhuVWpRWU9FRzUzaStRb3Ju?=
 =?utf-8?B?ZlVFNGkxTXJSNlZrZkZnUG15OFZUei9ER2FJaVFWZDN5Y2JpRWFscWsweURE?=
 =?utf-8?B?c2d1KzFrbTdWV0ZNZWFlMXR2OUVTUTZGYURpblE3bkhLK0dLM0trQ0kyTGw2?=
 =?utf-8?B?OGVwTkdJRTBSWHJLK3hmSVV1am9xY2V2N045R3lSR2orNVU5d1pLaGN6U3ZS?=
 =?utf-8?B?LzFKczRyWDZmaWF2Nkc0WkVubmJXcExFNWhLVkM5MlBldkVGblhLRS9HbEVq?=
 =?utf-8?B?akhHVDQxVEJHeW1lRERxWCs4U2JMMk8vdEcvWDEwZ1FBNUJva0RqZDJaeE5m?=
 =?utf-8?B?NGRwUDZkQ0I2ZzFOWVRpVnlnVkVmdmVyUUJBSGpNbjJlWHR4REE1Yi84WFh6?=
 =?utf-8?B?SE1SVVk2N0xFZDN5Sm9ITFZNNVpibmZ3eW96UnhLTGpYUzFSWDhWb3JSOEpY?=
 =?utf-8?B?RUtUMEt5eXhGOXRzOExUOUZES0E3Uzl1aEdraGV5SVZaRGN2d3lZSmQ4UVNL?=
 =?utf-8?B?NWVpNlZZRGxxUHdmZnZYMVJ1V1F1Nlowb1VqNDFsOWNOcUVlSlE4a0hKUWl2?=
 =?utf-8?B?dXgxQ1A1d042U2ducUN3NUtEVnptbE9senVDZzczUlkzT05WN1RtQ1JCeU1N?=
 =?utf-8?B?MS93blgzNmNiT1VHZE15ZHczaDIrVDViOVcvM1A1VGFYRDJ2Mm1mSzFuMzd5?=
 =?utf-8?B?c3V5WDdGdXAyMmdON1VtdFBNSmhwUkhqaW1RaC9VenM5TlBmVHhpb0ZaSTN4?=
 =?utf-8?B?RTRaTGRpSGpscVRNWjVmbC90VXFPVWZUWXhiaUJYVUcvOXJTb1M5eGtDNFFW?=
 =?utf-8?B?c1EzMUorRFpEWGZmcmNGb1VmRWltbU5TeUdmNmp6L3E3UXpvNVN1YXRlL09W?=
 =?utf-8?B?MmVLQkJIMU0weE8zcWZiUWtVbWN6MjJZYnE0SGFiVmRwbXh3bWJkZk9OT25M?=
 =?utf-8?B?amt4UmJTZ3pDOFZqd0NvMUtVVHRLOGVnTVVISDNTdGlPb0ZMWFBkK1NNenZw?=
 =?utf-8?B?VVJMcXkvUnNZWXJzbUdJTkpFQWR0Wjk0bU1UdjJqbjhHaTFwWG5vZi9OSHho?=
 =?utf-8?B?eGdvTjg0QWFCQzl2eE9LZmxnSi9RV3dSY01RNVVUS2E2dFpzcVlNYytYU2RW?=
 =?utf-8?B?ZmhxZU9FQ1hzWi9OVVpQUkhzaWY2K1JtLzhJaDZ4Wk5VVTh1aVBSd01aTTJD?=
 =?utf-8?B?Wis2cW5Qc3FhUEVaa3BQc0pESVRYb3lpVHhnd1VxTlNtZXhTZEorS1M0RVFt?=
 =?utf-8?B?Yi9SVDRCSTEzWll0YjJidkNvaWdPL3JkVVRSMlplUFBQYTBoYzI2Rjd2M1RX?=
 =?utf-8?B?WWdIMWFjOWp5TmNDTXVzNGFGVjFqS2lkbmhPbjQwMVhRTG5IVU1ydmFUb1hB?=
 =?utf-8?B?K0dGTEU2dERTZXdudGJDTU1CS1FYQloyUEhiUlRtVFIzaXYxdlhTYWdrQkVD?=
 =?utf-8?B?dkw3TDB6Mm5sZmFvcHNtc0h4S2FwQnZ1U05mWGk2NW9mUDZuQmd6MWJ2Ujkv?=
 =?utf-8?B?VEpEaHBNZ2ZGZWh2S1hyQTJsM05YaHlQSDY4cUJyaGJ3MHpubExLdHBUNmxx?=
 =?utf-8?B?Uk5DeWN0akZJSFpucWxCbSt1MHlJejFRbmJRK01Fc2tVWmlPMVhjNkFxOEl2?=
 =?utf-8?B?dGZQb2crZG1yTis1QjlnZEZOOFB0bTRnRDVmanR4UjBPY25hbGUwQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8779b6c-4163-424f-eeae-08da276ecac7
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:23:22.9270
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YFzjwZRNhgVTL184s5Lrk72Zyjz+NI+Ea3fjUTe+UATCcnmHkyUQr9AKcTLuNdxUhjArOeLBjqvzv9XtS5E4Ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7157

struct xc_sr_record's length field has just 32 bits. Fill it early and
check that the calculated value hasn't overflowed. Additionally check
for counter overflow early - there's no point even trying to allocate
any memory in such an event.

While there also limit an induction variable's type to unsigned long:
There's no gain from it being uint64_t.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Of course looping over test_bit() is pretty inefficient, but given that
I have no idea how to test this code I wanted to restrict changes to
what can sensibly be seen as no worse than before from just looking at
the changes.

--- a/tools/libs/guest/xg_sr_restore.c
+++ b/tools/libs/guest/xg_sr_restore.c
@@ -424,7 +424,8 @@ static int send_checkpoint_dirty_pfn_lis
     xc_interface *xch = ctx->xch;
     int rc = -1;
     unsigned int count, written;
-    uint64_t i, *pfns = NULL;
+    unsigned long i;
+    uint64_t *pfns = NULL;
     struct iovec *iov = NULL;
     xc_shadow_op_stats_t stats = { 0, ctx->restore.p2m_size };
     struct xc_sr_record rec = {
@@ -444,16 +445,28 @@ static int send_checkpoint_dirty_pfn_lis
 
     for ( i = 0, count = 0; i < ctx->restore.p2m_size; i++ )
     {
-        if ( test_bit(i, dirty_bitmap) )
-            count++;
+        if ( test_bit(i, dirty_bitmap) && !++count )
+            break;
     }
 
+    if ( i < ctx->restore.p2m_size )
+    {
+        ERROR("Too many dirty pfns");
+        goto err;
+    }
+
+    rec.length = count * sizeof(*pfns);
+    if ( rec.length / sizeof(*pfns) != count )
+    {
+        ERROR("Too many (%u) dirty pfns", count);
+        goto err;
+    }
 
-    pfns = malloc(count * sizeof(*pfns));
+    pfns = malloc(rec.length);
     if ( !pfns )
     {
-        ERROR("Unable to allocate %zu bytes of memory for dirty pfn list",
-              count * sizeof(*pfns));
+        ERROR("Unable to allocate %u bytes of memory for dirty pfn list",
+              rec.length);
         goto err;
     }
 
@@ -479,8 +492,6 @@ static int send_checkpoint_dirty_pfn_lis
         goto err;
     }
 
-    rec.length = count * sizeof(*pfns);
-
     iov[0].iov_base = &rec.type;
     iov[0].iov_len = sizeof(rec.type);
 
@@ -488,7 +499,7 @@ static int send_checkpoint_dirty_pfn_lis
     iov[1].iov_len = sizeof(rec.length);
 
     iov[2].iov_base = pfns;
-    iov[2].iov_len = count * sizeof(*pfns);
+    iov[2].iov_len = rec.length;
 
     if ( writev_exact(ctx->restore.send_back_fd, iov, 3) )
     {



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:23:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:23:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313699.531391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIMR-0008C8-2f; Tue, 26 Apr 2022 10:23:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313699.531391; Tue, 26 Apr 2022 10:23:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIMQ-0008C1-Vi; Tue, 26 Apr 2022 10:23:58 +0000
Received: by outflank-mailman (input) for mailman id 313699;
 Tue, 26 Apr 2022 10:23:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njIMP-0006S6-C6
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:23:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fa69d5e6-c54a-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:23:56 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-05FTq-RQNNW-XRPLGOZsDA-2; Tue, 26 Apr 2022 12:23:54 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4245.eurprd04.prod.outlook.com (2603:10a6:209:4f::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:23:51 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:23:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa69d5e6-c54a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968636;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7XE0MZ5Q/V0/alHvDtFRmInLwfamZyLpxplt2pkODz8=;
	b=P0MJVeAB6UEjCsi/r6Zlz39ExjXLUzY3kMOcCk+zPodraQb/llf4r59p5IZHFRDAXFrjZZ
	ByDrrHZ6lTjjO7V8V30UBoBxpOJX4vcJ2DMk1z94yMmdgcCbsLGS05phvXDFFAPCblwl7C
	CillbuAGf8NO6ifT3jtQxLwUVB8emIA=
X-MC-Unique: 05FTq-RQNNW-XRPLGOZsDA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O57Qh6FhRQ0Xc8/yaMe26SYHIOBBRcV2A2QXeyX2OtPC2q6IPpiysUXiPnFcyFzK9ZK3NdyvU9LAD5qRTxE45NOAdPmhJUzo8t4ziMBciMqjiDAk5K8l3dwjNx9CISK0WKlEN0xWM+bns4vNnhkiHHfX9eLcSub2wj0cpgfKfJcD2pdu5Ujx+/q/GTw8RMNRCCRPHFBk8Wg5cHPjaxz7Xw/2jsdb/hR9wtuQQzTOBHqyhSc6MgwWt8Yhn/EKqfIJKolxlRFKy8bZdF3epQ23qNO7C4JYXBtJLVaVct+BhMjmo8UXtpePgRp2g8rfhPPVqH7OADWwN6RY6pWWVyN9dw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7XE0MZ5Q/V0/alHvDtFRmInLwfamZyLpxplt2pkODz8=;
 b=FV7IjQn4DEXPLLcYFUqPyaSY5ExVF2ELKJzKoGyAL3xY9IYC61MWgcXt6WQRmICs2p/ZsRKhjqqz3IZIX64objIj9H+hU3nARo2ZrvD04Jzkr+cp3UMJXolKUcEq4THV6GppxfSpVYgvRt0Jz1tEB1unfcAuDkXUThboyQRNayLyvWCa2/VoczsJkBqifxzehKAPNnIjf+ehKle0U863YZRie42XwmPlf12HwFB9p5uOmYiKgMUEEyFOwLYun0Y3MD04Kkrd+H4Tr6T63gAcq7KNFRgvMIIHjUe9EQrkQl9qvZA2jcO1ZpaGGEtEQCVcKaHLBs2B16YfgGkBiP3rQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1744d775-4446-69b4-152f-c81d36e4996c@suse.com>
Date: Tue, 26 Apr 2022 12:23:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v3 4/8] libxenguest: restrict PV guest size
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, George Dunlap <george.dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
In-Reply-To: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0064.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::41) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 635dfd18-0c15-4153-b886-08da276edb94
X-MS-TrafficTypeDiagnostic: AM6PR04MB4245:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4245772E936C7E496A993AB2B3FB9@AM6PR04MB4245.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DjYboPnQ/p/2Zsazk6LIrJywIyRlsHPxOTqzm7vuLH9yYmk1Hum3hbf/znFQH6c7N+frPkUQ3w3AyKHs01lUFLY0l+HrXqy4QGDdMgj06eW2ij0H7A1MSH7oBpHd1XbYVDoqgyV/4DxhS+WKofJwBjkOoGPoozLvqL1vwa0MHDEnCLCXFSqjpgRLwQk0Kl7w3N71xxl2QzqsFLnF6qh+9IT3hvcEzzw8x5noMBUTnOALNKkEIaW3sx5sPE1A4R65TeuGnXhTjmW8Rzjv6MU+1yEUbDb9Zp3WFWcrtT8TyiwkztcjBki4cD0gzpMMGfI8Q52+BiQUCMz8FtLcgYLOCm2gdmX2gjWvpjrFboR95j1mrMPRBFHZcBhxw4Y6fpdeRxARCdttidEXmgjSFaKiVvsD7n7gOI43cfrW9dUB1B79bWvijqhcID5L6Pcs0g7ZDV3Z8Lg+HNPbY/vPi+DE3vIfgfDLXmOor8XjvhcGaM/LIJT4TMdNn/xuoXb+GDhJ9x9LGlqIptGZ7T6BVdY2ptLV3ZoGOBifsfvfRG144BDy3t4SJJRXlBGymYj/ILUUPmzFmz279WuhgqaRky6z81XK11N1p1MjXI4NbGr9WMRXPLG4jDLeJMhfIJOKEtGy3pmkvWBBcqUlWpNyTU6/SfxtR7RJfY78ikiTFm3YrD/FCeQHoKzBTT6zuFVBHfcyu4363Qme6p0yUlg6p5q0Hd/g0s09Cq1614jy7rYxGYU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(31696002)(508600001)(6506007)(6512007)(6916009)(86362001)(186003)(36756003)(31686004)(8936002)(4326008)(38100700002)(2906002)(5660300002)(66556008)(66476007)(66946007)(26005)(316002)(54906003)(6486002)(83380400001)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bk1sbkdvcHQybXpnenN2ejR5YS81VDY1SkIwSmdxT0VDRy9ZdElVVEJrMDhk?=
 =?utf-8?B?VFF6S2tZdTIrWlJhc2xNKzJjWkZWTUFiU3o1bWNNM1dTTk0vVmtYdXZsQU9Y?=
 =?utf-8?B?V2NWaXBsMEFCMDVUSkp3OE5ZV2pIOVY0MzdTKzltSFFMZy9xbHU4Vjl2V1RS?=
 =?utf-8?B?aE9lWVp6cDJDbFZnTXJtemliL09MMGpOMWZkWXF3THN2SGZTcnFjN2tTc25r?=
 =?utf-8?B?N0lWc0FITVZSVHpDL29QbWI1ekNJNWpDQ3ZaY0svQzhQT2lmN3FrVGhEMld1?=
 =?utf-8?B?dFlCM21qc0tXaUhnaG0ybTdQZE9TWGtqM2RicUFXelVpNWU4d2t6RU12WVJN?=
 =?utf-8?B?ZThXa0hSWW5HLzdIWXFFdkxXbzBXRXNLalp2NE9FN3N3QTkvR1lBdTAwVWcw?=
 =?utf-8?B?OWxRSFVqVjhvejJhaGFDT1puQzA5alJZSmpNdzZPVDl0VHUrL2NuckNxZEZH?=
 =?utf-8?B?ZHhvN25iNzcyS0NIWnBlWmFVejA1elVvbDJyZ2tGMk9EcUE3Qmx2UnJncXcz?=
 =?utf-8?B?YloxSWhPdXU4ZUlWZ3UrTzFTMnZKcXp3YVIzMG1rai8weGgrRzkrR0xwRStp?=
 =?utf-8?B?WmljbFpWREoxTzF1UzVlVC90VUl3RTN4QWRvYzl5VWZsVk5NcTZFZTVPS2cy?=
 =?utf-8?B?OFFUZysvdDNKa2hzcnkrL1ppVklyMGkvQTEwSTFsVzBGelJ2cExjUEN5eGRw?=
 =?utf-8?B?emo1ZEsxYmJ2M3o2SG1aWFRTOFhXOUN3RnkyRC9Bd1dmdlVaSmk2V2dBUmVW?=
 =?utf-8?B?aWx3OTNtOStoY0VETU5nS2JVd0xPcHNMV2JwSDM3bXFIajV3NXcyTlNJcURS?=
 =?utf-8?B?QWhNRGVaQUpkSXd4TEVLdVo5WW5UNzRhQTlqZWE1VnRnaWFTcTNvTmFCdHF1?=
 =?utf-8?B?TVFEUDRadGR1clVERW84dzh3cGErd3JFN2d5M2JwaWhCeEZwZlFsSEtwTWdt?=
 =?utf-8?B?bTAybDN6Rk44VTVwQlJzR2xKbWttK043eDJJamY1dCs1clBjUEtYdjE1ZEE1?=
 =?utf-8?B?QzlxL1dWVmlEc2pOR29BZGRIUmFsclVIajMreEt4NklSMDltNlRBK0VISHpD?=
 =?utf-8?B?RXUwMkJ1MC9melVvTm1rQnFpeVVDdGFNRmtIRWh0SkVpSW1YbVZrR2FSZU1y?=
 =?utf-8?B?bUY2b25FdnZIOUZsRm1nRDEvb0NqVlN0Y0pKTzFTUDBkUzBIUVhwZFJmTWxM?=
 =?utf-8?B?eDhLdnA5dFJkZEV4QUNVZ01HdWRjbFlUQUQyS2k1SGVQc2NSa2g4M3ViU1gy?=
 =?utf-8?B?MTdiOUJWa2l0UXVVUHJybHBMQkxQS09kanNkakU1ZDk1UEV2KzhGWWZPN2xP?=
 =?utf-8?B?T2tpM3k0SUlIUHExTGw5bVZGM1cwMjRVdmp6TW96Mk1oUmZVRXA1eUlLWnhO?=
 =?utf-8?B?Y1lSMitoendHRG9VWHFpYmJZeWhPbCthVEZhL096eHFyeFpDa0pGZy9kai90?=
 =?utf-8?B?dnBzeFV6WlAzdzcxSU4wMVVjVHN3TS9IcHZsdUszYmd2cHVNTEx2eEdubkQ3?=
 =?utf-8?B?YU9wZElDbWV5eUxkVmY2OWtkNTMyOUtYS2VpZGRTUlJaYTNIN081a3g1bmww?=
 =?utf-8?B?TVRPWXk5YW50a1EwWUYwcGpVZHQ0NDhjeFJadE9yOTJNTFNEdDMwMXJ3ZWk5?=
 =?utf-8?B?dGdmY2NjamJBV0Njd244SEk2enhnQm9IR2dBUVh6YXV2T1V2RXFIRjAyUmt3?=
 =?utf-8?B?Ym5LakE1cXp2T2c4OXhNdTlpQ2x0NnFBNFBFSUpRYU1TdlNKVEptZ0p0bEFz?=
 =?utf-8?B?ajdnSEU5S0M3YkNLeFJKYlBMblQwZ2p4bGNHalBNTWk1L1VqN0lqZjR1dHdV?=
 =?utf-8?B?YVlKWTJLZmxEd3FUcXJhK09oRDdmUllPSVlPZ3R5cXplOXNhOVN1SUdlWnZt?=
 =?utf-8?B?M3RDMG1ldFNNcjRhYm5oSDhPOThyZ29GY0dteFVvc0ttOGprVndwdXBQL3lM?=
 =?utf-8?B?OSs1eVN4NmF3Mi9BaWRkbWRMenhzanl2REp5RzNEcGFEVytOMlZiaW8rVjRG?=
 =?utf-8?B?WEROdEhHSjlaUTdYY2JxemEyWWtUaVYwQkJydnRJaFAvR2c5OVptRmpGUWJD?=
 =?utf-8?B?TDNCRHhBd0JlRDlTMHNpNTJYL2c5VzNvYnpLeXZXZG1WZklQYmJsZDdIc0FL?=
 =?utf-8?B?aDJVZWwxdVl4dUhEc2ZWa1dwd1J5dTdqNG1kb29VS3JDZ1hzeklnZ2FPYmEw?=
 =?utf-8?B?akwrc2c4cW5NL0hwZGFYVTdiL2lTMEVJYUtINUlBckgzT3Y4cUtmeHE3bmVQ?=
 =?utf-8?B?TS9oaDdYaEtCRU5jeHdFZFBCSDR4VmI4bERpQlZnL2hJUFBrOHNGSTRqZnJZ?=
 =?utf-8?B?dmR1NnYyQmxSNVFBN2cxQ2lzYVNLbHJwWFlZM1NFeWRRMzh3MTd1Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 635dfd18-0c15-4153-b886-08da276edb94
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:23:51.1282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tlmkGKa4+uwA2DbbFUXoZap0+sx7AubJo80rVCAlQk0SrCi9WrspeGs4jTAckoYAISmG12e6sSUXAgf+/9aYWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4245

The P2M, the use of PFNs, and hence the maximum valid PFN are purely
software constructs in PV. In principle a guest is free to use arbitrary
PFNs. However, at least page table normalization requires that PFN space
be, like MFN space, limited to the architectural 40 bits (52 address
bits). And of course a 32-bit tool stack places further constraints.

Bounding the values also makes sure that various subsequent calculations
won't truncate values and then continue with inconsistencies (see e.g.
fl_entries vs ctx->x86.pv.p2m_frames in map_p2m_tree()).

While there correct an adjacent error message with wrong way round
wording in restore code and another slightly malformed and misleading
(off by one) one in core dumping code.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Integrate into series.
---
In case the save/restore changes don't make it obvious enough: It
escapes me why struct xc_sr_rec_x86_pv_p2m_frames has p2m_pfns[] with
uint64_t element type but {start,end}_pfn both as uint32_t. Imo all
three can sensibly only ever be of the same type.

--- a/tools/include/xen-tools/libs.h
+++ b/tools/include/xen-tools/libs.h
@@ -13,6 +13,10 @@
 #define ARRAY_SIZE(a) (sizeof(a) / sizeof(*a))
 #endif
 
+#ifndef sizeof_field
+#define sizeof_field(type, field) sizeof(((type *)0)->field)
+#endif
+
 #ifndef MAX
 #define MAX(x, y) ((x) > (y) ? (x) : (y))
 #endif
--- a/tools/libs/guest/xg_core_x86.c
+++ b/tools/libs/guest/xg_core_x86.c
@@ -59,6 +59,43 @@ xc_core_arch_memory_map_get(xc_interface
     if ( xc_domain_nr_gpfns(xch, info->domid, &p2m_size) < 0 )
         return -1;
 
+    if ( !p2m_size )
+    {
+        ERROR("Cannot map a guest without P2M");
+        errno = ENODATA;
+        return -1;
+    }
+
+    if ( !info->hvm )
+    {
+        unsigned int guest_width;
+
+        if ( xc_domain_get_guest_width(xch, info->domid, &guest_width) != 0 )
+        {
+            PERROR("Cannot get address size for PV guest");
+            return -1;
+        }
+
+        if ( p2m_size == (guest_width > 4 ? ~0UL : ~0U) )
+        {
+            ERROR("Cannot map a PV guest with invalid P2M");
+            errno = ENODATA;
+            return -1;
+        }
+    }
+
+#ifndef __i386__
+    if ( (p2m_size - 1) >> 40 )
+#else
+    /* Very large domains (> 1TB) will exhaust virtual address space. */
+    if ( (p2m_size - 1) >> 28 )
+#endif
+    {
+        ERROR("Cannot map a guest with P2M size %#lx", p2m_size);
+        errno = EOPNOTSUPP;
+        return -1;
+    }
+
     map = malloc(sizeof(*map));
     if ( map == NULL )
     {
@@ -333,10 +370,30 @@ xc_core_arch_map_p2m_rw(xc_interface *xc
 
     if ( dinfo->p2m_size < info->nr_pages  )
     {
-        ERROR("p2m_size < nr_pages -1 (%lx < %lx", dinfo->p2m_size, info->nr_pages - 1);
+        ERROR("p2m_size < nr_pages (%lx < %lx)", dinfo->p2m_size, info->nr_pages);
         goto out;
     }
 
+    if ( !info->hvm && dinfo->p2m_size == (dinfo->guest_width > 4 ? ~0UL : ~0U) )
+    {
+        ERROR("Cannot r/%c-map a PV guest with invalid P2M", rw ? 'w' : 'o');
+        errno = ENODATA;
+        return -1;
+    }
+
+#ifndef __i386__
+    if ( (dinfo->p2m_size - 1) >> 40 )
+#else
+    /* Very large domains (> 1TB) will exhaust virtual address space. */
+    if ( (dinfo->p2m_size - 1) >> 28 )
+#endif
+    {
+        ERROR("Cannot r/%c-map a guest with P2M size %#lx",
+              rw ? 'w' : 'o', dinfo->p2m_size);
+        errno = EOPNOTSUPP;
+        return -1;
+    }
+
     p2m_cr3 = GET_FIELD(live_shinfo, arch.p2m_cr3, dinfo->guest_width);
 
     p2m_frame_list = p2m_cr3 ? xc_core_arch_map_p2m_list_rw(xch, dinfo, dom, live_shinfo, p2m_cr3)
--- a/tools/libs/guest/xg_sr_restore_x86_pv.c
+++ b/tools/libs/guest/xg_sr_restore_x86_pv.c
@@ -709,10 +709,23 @@ static int handle_x86_pv_p2m_frames(stru
         return -1;
     }
 
+#ifdef __i386__
+    /* Very large domains (> 1TB) will exhaust virtual address space. */
+    if ( data->end_pfn >> 28 )
+#elif 0 /* sizeof(data->end_pfn) > 4 */
+    if ( data->end_pfn >> (ctx->x86.pv.width > 4 ? 40 : 32) )
+#else
+    if ( 0 )
+#endif
+    {
+        ERROR("End pfn in stream (%#x) too large", data->end_pfn);
+        return -1;
+    }
+
     if ( data->start_pfn > data->end_pfn )
     {
-        ERROR("End pfn in stream (%#x) exceeds Start (%#x)",
-              data->end_pfn, data->start_pfn);
+        ERROR("Start pfn in stream (%#x) exceeds End (%#x)",
+              data->start_pfn, data->end_pfn);
         return -1;
     }
 
--- a/tools/libs/guest/xg_sr_save_x86_pv.c
+++ b/tools/libs/guest/xg_sr_save_x86_pv.c
@@ -464,11 +464,40 @@ static int map_p2m_list(struct xc_sr_con
  */
 static int map_p2m(struct xc_sr_context *ctx)
 {
+    xc_interface *xch = ctx->xch;
     uint64_t p2m_cr3;
+    uint64_t max_pfn = GET_FIELD(ctx->x86.pv.shinfo, arch.max_pfn,
+                                 ctx->x86.pv.width);
+
+    if ( !max_pfn )
+    {
+        ERROR("Cannot save a guest without P2M");
+        errno = ENODATA;
+        return -1;
+    }
+
+    if ( max_pfn-- == (ctx->x86.pv.width > 4 ? ~0UL : ~0U) )
+    {
+        ERROR("Cannot save a guest with invalid P2M");
+        errno = ENODATA;
+        return -1;
+    }
+
+#ifndef __i386__
+    if ( max_pfn >> (sizeof_field(struct xc_sr_rec_x86_pv_p2m_frames,
+                                  end_pfn) > 4 ? 40 : 32) )
+#else
+    /* Very large domains (> 1TB) will exhaust virtual address space. */
+    if ( max_pfn >> 28 )
+#endif
+    {
+        ERROR("Cannot save a guest with maximum PFN %#"PRIx64, max_pfn);
+        errno = EOPNOTSUPP;
+        return -1;
+    }
 
     ctx->x86.pv.p2m_generation = ~0ULL;
-    ctx->x86.pv.max_pfn = GET_FIELD(ctx->x86.pv.shinfo, arch.max_pfn,
-                                    ctx->x86.pv.width) - 1;
+    ctx->x86.pv.max_pfn = max_pfn;
     p2m_cr3 = GET_FIELD(ctx->x86.pv.shinfo, arch.p2m_cr3, ctx->x86.pv.width);
 
     return p2m_cr3 ? map_p2m_list(ctx, p2m_cr3) : map_p2m_tree(ctx);



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:24:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:24:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313705.531403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njINK-0000Oh-D0; Tue, 26 Apr 2022 10:24:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313705.531403; Tue, 26 Apr 2022 10:24:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njINK-0000Oa-9z; Tue, 26 Apr 2022 10:24:54 +0000
Received: by outflank-mailman (input) for mailman id 313705;
 Tue, 26 Apr 2022 10:24:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njINJ-0000OM-9R
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:24:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1bb3dfa3-c54b-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:24:52 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-1QHNAdYYNG6iJ4FVQXsp7Q-2; Tue, 26 Apr 2022 12:24:50 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4245.eurprd04.prod.outlook.com (2603:10a6:209:4f::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:24:47 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:24:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bb3dfa3-c54b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968691;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hFvLQFBwZFZ943lsxU2fJYaMKf9GbC+9+84gYPaYpQU=;
	b=B8oenL1GHZZ1IRScLfbi/hpPVXwtIX/wpmNWpPGbEQ9VOm4yKtqFZrgGUkii1L/G5P2fog
	cwfe+xgCCfrwPKW0LZEgxqcM/eqFTGbCfH5t7jx+W+eNgRUeJP24ymNvSQRQltB/sntEod
	sDBVscdGsOFK/DO852pCMh9fjdGM47o=
X-MC-Unique: 1QHNAdYYNG6iJ4FVQXsp7Q-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EJMZb0YFQg6Vgc3dr0BrFVZO2A3Ertnoj0WIucML22+TaT11MvOL5v7QM9D0Ts5wJy3KrhAlfziIKk5UIUNEjqzQYhhpvNb3D5UYs1tIyxM/joTcao2L4gJCm/uMr6NPtbnlfTgnfjxSN9wQveKvCuBfxykbfCWi1gbTuaDn38uaCxr9Fn50TOCMP/0uQNy6uROVnUnrk+lA1ur1ns6KO8phOB+3ftdvAJE9PpNyhB/gB4pmI2sqHhnOzBagM01NTvAgAMwU7XIGO3LqXWu6IShqEm42CHjj1r2T02VcbYwH993a6kqoavJBLvbj+tPBhY1A+wXhN46+e+Qe8vYmFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3OGFK6t8lL7gQvWrJvHU3Kqh9Nzt0xlpqwNOIjr8wDA=;
 b=Oo6mlrmHOaj738rt5GqDGWjfTcaNdVAhl6sMXmzbPxctPETg0SLMwOmNNUSoc91OFQEYSSCcYU0+P/zh/YMKh3OXsHqSmgIuTpmxb6koLDcPE2dyR0Mum/Xn2N5WCJKW6LhA18A61hH90WEi3O3RIwheyzGS5VyQBoyGbbK9L62dJX4zRVyBC2TJ7+DFhgMpIdwCBLPIx5hfKfZleRuKPMsY3g0F4Xsa0L03G+VkrI803ZovA4Y4ox/z393VUK6emoQ0Wkg+pdzQx6IBDi3PtLYBAbKiapXHzCI2XAzOTPHOswBE+e3V1xxLLF4b9Q5mxdb4IQ2TH8QqRajjqBXRkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1b24d2b5-14ff-6e4f-6fa5-d91d75e315a4@suse.com>
Date: Tue, 26 Apr 2022 12:24:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v3 5/8] libxenguest: deal with log-dirty op stats overflow
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, George Dunlap <george.dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
In-Reply-To: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P250CA0002.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::7) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b10f9922-ef7d-45e7-9214-08da276efd38
X-MS-TrafficTypeDiagnostic: AM6PR04MB4245:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB42454F87500EE5696AD2BEB1B3FB9@AM6PR04MB4245.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	n9X5T8hx4jB60E3PWHnxpf1XsKPUTIChMdEwHdRsZBJyTOnMKS5dOi8bJ+lq22Zw3TjrL4oMNagIje2ISBNi59yIdhRtK/FxdSMGlsQq/sTW1/2x7/Kt3cRcLA2eBM52lmwWuOBF4c5yP0uXuC3XSRHZD7rvQVW75aRHcgldhbmb7RrHCG5NYyJNRtz1tTSNKwMEzLKtvBMRDbGOEcfUGjEDKNtb7QuXkzaDPwFYk3cpK/WQhPvIx+iYQw2NEG2pO/BZPnTaDFt5Uf1k2VXNIsVsIQRaumGpImAxlGtMz/m5OXIazTFqEegHcrv1H9mLoNb6ZBcQxv34mrp7igOW+6gMy9ZamPrp/Caalo4k8Yc4NlD9UPD8bQ8ZJIZAGseVLAn1jTYln45iUyYZz5RvcCraz/45MR+/PvEVGS0PNTvIb5h0vzrQpvXrxvFBEHWKYQ0tnoTE2vqraKzLCyfP3mMTJkmJLJBKrcbsk7zxKhyafOXMBJhwKb+D7SsMP8pTyADasbuhPDhYtoZbrZySosHK0qLIZHLFlD1PWNTIf1Z/wM5+bjV/znPHOLqnD9VZEG0SxmbWU8KV2ww/wVIZLen39hKBAlkNs9MQfchhGC0bDe88mKjy9CWlLh9UQTMF00kxpk6KgwPVJZS5TJJ9uF3pekoO4lUnm3b4Of7dy1u1lNsSg3oAMCsIwiqsaeizUy2BT+Y1oGWHnmnkn/+BZrSlswTtk4vnruG+FhGU270BfVhif6D2Ndo8rdm9GssY9ajnNfb+8GqrCtu6UAE4gQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66574015)(2616005)(31696002)(508600001)(6506007)(6512007)(6916009)(86362001)(186003)(36756003)(31686004)(8936002)(4326008)(38100700002)(2906002)(5660300002)(66556008)(66476007)(66946007)(26005)(316002)(54906003)(6486002)(83380400001)(8676002)(14143004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?c89B0axlDoAn2GDpXRrBO8yToGYF7KXCSXzo9CmM7XclDj5bj5jgZXzd9X4F?=
 =?us-ascii?Q?ahOM9AfN/Ov6MjbzghE09iLMDR5bryTh4fF4kHC1ERTj70DsGWEXLyoyheCI?=
 =?us-ascii?Q?cS/D/Cul57xToipyg/TupECtsRjS6Xu+qYJN0pQFv6RZqARx6mWsesJmW26U?=
 =?us-ascii?Q?g9uTqOt5w/cnw5ud0v4VnWPT+/eGbJyCK6MX8xv4PDHGjpD5f7Or0FTFI2mh?=
 =?us-ascii?Q?MsXpLtq7FM+Gc9NL3J3+t65Sd7pAyp1cI3JpLDQxMXAbs3Y0zom3ieQqS2uQ?=
 =?us-ascii?Q?VVRWOszxQKX5jEM6JVpx1ScdKsKvjk8+pftayP6xOwAk2VZA/fOfHTq4XO7f?=
 =?us-ascii?Q?f820dUMn7iz96FUnaN7uFa7khbhbL3bJ4VcMmXL4W1CtdlxgJegTfLKewr8w?=
 =?us-ascii?Q?Jizg8TAJU1esAfgOtsS9uhbN9LvGMl1QPObT3UpuxcbhyROlaBw31y0c0gSu?=
 =?us-ascii?Q?ZDDrrUjd4JinhETzu2n5v+/Lj8hq4n9QcyJBomdX/nZf2FGIvZ+y6HsD4mmc?=
 =?us-ascii?Q?TZyEuTmor4Cld8CNzKImM1+qBEw/1Gj/Bj1drt1V5AFNNyl3FviYDcTp8aOP?=
 =?us-ascii?Q?yM7XVJL0iWLD21sehKZd9evihcqi388zTwE4Z2X9TnWXkIrpK6p43z1iqUCO?=
 =?us-ascii?Q?MN5Ca5MNONsWzwHA31H7ER3zsk4DgTkSK5QUPHa0z09FGXMRbpaAgPeE/LdT?=
 =?us-ascii?Q?arOTQdqFs8zmfJJCBs53GaY3J5u0t55ALYKLSSDuMeYuYKgkm/mu/1RgZA/O?=
 =?us-ascii?Q?SSJ/gqVH1sd4m7fAGSYFpsz+2yorpB0JdP5xV8QcKohxuJLNoMy6fOgcUuPE?=
 =?us-ascii?Q?rQEbfXgDeZOrDxBBtSHi304sGLI8yJ+mltoF8s7JKQuKgw8FB5O1Zz+0Z5fh?=
 =?us-ascii?Q?+C7sM/r/CoyiUBWpCCxIm+9MRv3xoaBuFZtIMG1ndK2AXTB10hPmas2Qqv8q?=
 =?us-ascii?Q?jUeiTnN3cbsIJuHcO7NnbwS3r3pwBi8cUOxAbsPoUbOFH7fsOspwQmAX8Wbr?=
 =?us-ascii?Q?tqkOGIqh5tpBvXZ+zShlEBCgpUo1/OzjndQXtefnmBXeneBPFmsLa7O/juSX?=
 =?us-ascii?Q?xaLc/I8QRGv9KkyYCmFTCCSS6EXpz0Qks7GuyQk4TNeq6jU2eZUyv5aSiRIv?=
 =?us-ascii?Q?CjBPyjqJluWFiIFa7o/nE1FSDMqsblrU0zIhaZv/eClRQhHrYcTyPu/x0Wfo?=
 =?us-ascii?Q?/zlWnOxGqxLa75lhn/2FKVvQ5EU63no17TMGtLonaLmRWVO0G1Ob7+na3Mxo?=
 =?us-ascii?Q?AeZSmLAkIZRkDstPwt23wONYlSnP04OLuzac434ZuYZxQ5tbWiQ6BL1uhxpA?=
 =?us-ascii?Q?03partCZlgsfQLJIopQijDNjkRUnyjW3HR8q2rcSl25TdymGIDORYX7t31hb?=
 =?us-ascii?Q?z5oqZrG4EJ3WT5SwhUgjzK8YBzVeKbI7x2PC5qN3+gs89gAodHGtp8ae9JVX?=
 =?us-ascii?Q?cPUpnt2wYXnCq8hwlhnSX+/qmPWvAJCLf4PMvsTozyz+ncgIpbQ0st6qJ0t4?=
 =?us-ascii?Q?e3ksSAY6Js6ez2skiEHyaBT9rTLxSFhisogbZv9Eh6guEBjDIm5UTfxMYYQL?=
 =?us-ascii?Q?ZKjQQJuf2Y4WS9CgkuSMsLj4QQCujn1FgRSP8Q1nFxn1DPrWP419dkgbKvvj?=
 =?us-ascii?Q?YSbPmgtz+KUmrhmdk1UVQou4MZVNOBci3tpCvsqsVOvFmCWc7P+S1s/78oc/?=
 =?us-ascii?Q?POjZMfAas8UQcjF3yNxdfSH77MzGY729OB2HJamJmvs/4405/T7q8M1fwUYG?=
 =?us-ascii?Q?C9xFt3Ywig=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b10f9922-ef7d-45e7-9214-08da276efd38
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:24:47.7387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VNFZxoShOn2H5jv/F0NglxLAcX4RnlxBbhVkdkTMDnCmjlmVvB6+w7FqPat3sMubNKwGHPfZ5CTLMPb/DN069A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4245

In send_memory_live() the precise value the dirty_count struct field
gets initialized to doesn't matter much (apart from the triggering of
the log message in send_dirty_pages(), see below), but it is important
that it not be zero on the first iteration (or else send_dirty_pages()
won't get called at all). Saturate the initializer value at the maximum
value the field can hold.

While there also initialize struct precopy_stats' respective field to a
more sane value: We don't really know how many dirty pages there are at
that point.

In suspend_and_send_dirty() and verify_frames() the local variables
don't need initializing at all, as they're only an output from the
hypercall which gets invoked first thing.

In send_checkpoint_dirty_pfn_list() the local variable can be dropped
altogether: It's optional to xc_logdirty_control() and not used anywhere
else.

Note that in case the clipping actually takes effect, the "Bitmap
contained more entries than expected..." log message will trigger. This
being just an informational message, I don't think this is overly
concerning.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
TBD: To address Andrew's objection, J=C3=BCrgen suggests to widen struct
     xen_domctl_shadow_op_stats'es fields; yet within this same series
     we had settled on there not being a need (17e91570c5a4).

--- a/tools/libs/guest/xg_sr_restore.c
+++ b/tools/libs/guest/xg_sr_restore.c
@@ -427,7 +427,6 @@ static int send_checkpoint_dirty_pfn_lis
     unsigned long i;
     uint64_t *pfns =3D NULL;
     struct iovec *iov =3D NULL;
-    xc_shadow_op_stats_t stats =3D { 0, ctx->restore.p2m_size };
     struct xc_sr_record rec =3D {
         .type =3D REC_TYPE_CHECKPOINT_DIRTY_PFN_LIST,
     };
@@ -437,7 +436,7 @@ static int send_checkpoint_dirty_pfn_lis
     if ( xc_logdirty_control(
              xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
              HYPERCALL_BUFFER(dirty_bitmap), ctx->restore.p2m_size,
-             0, &stats) !=3D ctx->restore.p2m_size )
+             0, NULL) !=3D ctx->restore.p2m_size )
     {
         PERROR("Failed to retrieve logdirty bitmap");
         goto err;
--- a/tools/libs/guest/xg_sr_save.c
+++ b/tools/libs/guest/xg_sr_save.c
@@ -495,7 +495,9 @@ static int simple_precopy_policy(struct
 static int send_memory_live(struct xc_sr_context *ctx)
 {
     xc_interface *xch =3D ctx->xch;
-    xc_shadow_op_stats_t stats =3D { 0, ctx->save.p2m_size };
+    xc_shadow_op_stats_t stats =3D {
+        .dirty_count =3D MIN(ctx->save.p2m_size, (typeof(stats.dirty_count=
))~0)
+    };
     char *progress_str =3D NULL;
     unsigned int x =3D 0;
     int rc;
@@ -511,7 +513,7 @@ static int send_memory_live(struct xc_sr
         goto out;
=20
     ctx->save.stats =3D (struct precopy_stats){
-        .dirty_count =3D ctx->save.p2m_size,
+        .dirty_count =3D -1,
     };
     policy_stats =3D &ctx->save.stats;
=20
@@ -633,7 +635,7 @@ static int colo_merge_secondary_dirty_bi
 static int suspend_and_send_dirty(struct xc_sr_context *ctx)
 {
     xc_interface *xch =3D ctx->xch;
-    xc_shadow_op_stats_t stats =3D { 0, ctx->save.p2m_size };
+    xc_shadow_op_stats_t stats;
     char *progress_str =3D NULL;
     int rc;
     DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
@@ -694,7 +696,7 @@ static int suspend_and_send_dirty(struct
 static int verify_frames(struct xc_sr_context *ctx)
 {
     xc_interface *xch =3D ctx->xch;
-    xc_shadow_op_stats_t stats =3D { 0, ctx->save.p2m_size };
+    xc_shadow_op_stats_t stats;
     int rc;
     struct xc_sr_record rec =3D { .type =3D REC_TYPE_VERIFY };
=20



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:26:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:26:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313711.531413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIOh-00013j-On; Tue, 26 Apr 2022 10:26:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313711.531413; Tue, 26 Apr 2022 10:26:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIOh-00013c-LV; Tue, 26 Apr 2022 10:26:19 +0000
Received: by outflank-mailman (input) for mailman id 313711;
 Tue, 26 Apr 2022 10:26:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njIOg-00013U-BN
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:26:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4e52ba7e-c54b-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:26:17 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-znyZVbpfM7mJ5CTMB9ZfXA-2; Tue, 26 Apr 2022 12:26:14 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR04MB3125.eurprd04.prod.outlook.com (2603:10a6:6:11::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:26:11 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:26:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e52ba7e-c54b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968776;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5Q+RLUWEAn0J5puyRnSo+x/9eyF00ihd4YhFDt3Vc+8=;
	b=mUyFmhOk4fRwoAHI29yxH4AnPwNJTKVTxDnrg7E2vW1MAqGwoj5SGHARK0lIKunBinZZzE
	Px8G8GGxjn3lKqb38my4X8fNsjuG5hULxW+pLiSl09VyRnhYIK85+zykHUKRs2SKyEKIjN
	7d/D84mNI9NlF7Tr9uQhh7U3SiEPnC0=
X-MC-Unique: znyZVbpfM7mJ5CTMB9ZfXA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GgkKastVMkpb9sCWYrpzUs8hIBXcmfMJY1IgiLFAUECLx7cXNkux2fzsJVYpyhSv/9wfII3cUJvBMoiFZMAqZNO3PLkRZyYw48iLLsM7iZredjIzbc/sWbde9rMxSda4p2qK5ErqpmXKIeRHiCCPMTc9Pk5CKu1c42x2EMmRLfT1Damf26VSDT5YTxsO62MM6z21dsBD1rWTgEze9Smiwvv/KI8EVEE96H+eDbbkTDk217PXZ1MmUFa80wjUv1rYkaet3fFd0pp+YLXZzI1Di6wofXMvMAatAlyMwqoD0nRziKvEl8XnRCkSJxLiin14sAOZAOWmwMksDdNW4B3H8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Q+RLUWEAn0J5puyRnSo+x/9eyF00ihd4YhFDt3Vc+8=;
 b=YPDtUrpoEll7gkLoHPBVssJsLGPy/RUGhqGxccva3WDKrEHHZ/AtGmCYiXe3E/6BqPY9JaXKTn59nXEXbCidGcMakxzhWjom96DpPR9MuU5Z7nYtYHquajnbdFYAIMHNbYD/60ox4vnwG+MszKMUcJgmZbwnyGFDf0L8hTXKlDSqF3J5/m2yOyl/tBaqyWFSHIbczeLKJ9SxGRKzAzVNsuF7PRIvGTTdMrr+ee40x3E2lZOQdT9vL1KpCymkaGdWxi6fuTVeCqJCjm5WrYVFJFit6NDmurRaD6/is3RwVkXAM6qFxrznkqRr/X75pjNbqQT6Pt3pRCezFEoffcRWhA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d47d01dd-0289-370d-7b5e-bd80f9e0a911@suse.com>
Date: Tue, 26 Apr 2022 12:26:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v3 7/8] x86/mm: update log-dirty bitmap when manipulating P2M
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Juergen Gross <jgross@suse.com>, George Dunlap <george.dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
In-Reply-To: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0048.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 14cec660-fa7f-4f18-a78f-08da276f2f2b
X-MS-TrafficTypeDiagnostic: DB6PR04MB3125:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB3125AFE5E4485EA1C852A9ACB3FB9@DB6PR04MB3125.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IsEWNuUjS6P44Mv8BTQy7Zm4YKSfUntqlej39dZoxTPjCs0qA2loKwWJs5kVsR++TpdX8CvRuJ8eB/kocoL1Ds5QAqtim7FmWuqH4gebhuIb9umeBYXr9UY9RA+LQTP9kWWERJLcX3bPEjvZDugUg+dur3mkMLpPt0HuDJlXy/lwO8Qvtl2UUeNCiLZaPJVMfFV5fdmMQV+BhTYvKgcdAbWW+Gr8fVB1Mc4WPT+uiN7xd6S24nPbzOw6jkDWt6n45kFVhMuie1d3SV+zocKOfBnn17UU5ez6iWOi6vhuZUeTYe6cpjT0r5lFEEp5wW6rxWjo6k5PAUrAR9iZ1FMTj7/TTezPHrOkaEHpkCECCSiO9BdvgAihmIoejFrHEPz5T/5ea8cMRn5TCUILWpZdrTxeo9IHFbRw2u/pXoY1XVGgyAO3NmAocR3fgfFf7+Sl9js2cd4PfNHdrOKXMkCK/26bo9itNCwBDPo2YSxQNEH2DDgIdjkRKc8WJuA2w/qp8Dv9tt2yzFGXHosWm7bP3oAAvULxuB0Nzmhfcy8kxYBcGZNgO4UZVkn2BqQg4Qd88/SIEnQGjoPh1DU1GdT0O7TauCi7e7PCWNHe9N8HQ9ufk1lJ0NzTSjFlvHIKGnPiegDRbW4AKydDtvxyppKzFLPjmDsntZPjI+AXj5UpqRfYRtMW4s6ckpk1Dn6WJDtW4gCYl5jiTAcSfYcrnD5xi6D67xbRVgfsitb31nTVxr/Lpr9iByphc9oZ8NWS6OvJX+y5WQfCsZ83UlVv+p8rZg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(66556008)(86362001)(6486002)(6506007)(31696002)(5660300002)(15650500001)(6512007)(316002)(8936002)(26005)(186003)(8676002)(508600001)(66476007)(31686004)(4326008)(83380400001)(2616005)(36756003)(6916009)(54906003)(38100700002)(14143004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a09TSTBPRkJVY1p5dnRaY3ZRWFFYaWxRMjBrTjlHUEYreFREaTFkcWR4MW5B?=
 =?utf-8?B?eGxIbitxVW5KNnA5Szd5cHBuNHV5T1Rwd0xLUGtxc0todTJnZFNHdFlMdWxz?=
 =?utf-8?B?MDVJaHlrMHF5OTIzQmtKR2Jzc3dCb2grUjE2R0poaVZ4aTh1QndYVU5neWRP?=
 =?utf-8?B?NVdzTkJ1M1oxbVRlNmJWdlRiSTFXSXh5WnlhWkkvK3FxYUZkV1NjUVg3Wktz?=
 =?utf-8?B?WWhzcVpEOUpaa3FvajNXbHVtdlJHYXNqeExKWWNoMk5udmh5cytVTEM2bGcv?=
 =?utf-8?B?bms5M3FXc3FFUTVzWWFrRmFWakk0eE1LZmpwR1FjYnRJZGVHVWc1dXFQdFlI?=
 =?utf-8?B?a3FkK1VubFFPbU1HcGtLTVRrVHMxd05SNnI0bmJqOVdQWXVQSkFKb0Q1ZFl2?=
 =?utf-8?B?cFhRczdxaXhRV1k0UW1BZFhmaDAwWUVvTTNxSm91SWl6ajl6dU82a1lwSkpI?=
 =?utf-8?B?TFBZMnYwVk1wMEZlV0xkWDZ1MERTOGpKSFpRV1hxVjFJTEhYdGo2T2RUZFZQ?=
 =?utf-8?B?WDBJaWVyeHBreWNhTjFqb1ZxQkx2Mlp6K1BFMS9FbzVJbGVmamlaajNVWjlt?=
 =?utf-8?B?ak9FcGkwMlp1b3BXZFpHTEpqK3E3UnBoVGFOaFp4MUN4UjRtc3RoNDlhYm51?=
 =?utf-8?B?R3djT0dTUnlLaVF0OGd4eFBSZUVVT2xSWEFaL2daMWVkQXRBblF4TUorMXB1?=
 =?utf-8?B?OWp4Nm04STBxT0RhMjg4eHA3cmh4KzBKWkgwWjI3VG4yVEtHWk8wekR5SWdv?=
 =?utf-8?B?ZEkwS21sUm51R1BaZXAxTWpmNmxNUU1uTTY1dE9Ec0luRkVtY3llY25seDRa?=
 =?utf-8?B?VittaDFLQjlaem12THlNSHZSRTFVWEt3VWhicjBRVlREYWdNWkd4bG5GMExZ?=
 =?utf-8?B?c2huU3lKOTBVV0krMXlubDlHL1RuWk1KMFpDeW15S0w0UTJ1OUQzWEpwODdr?=
 =?utf-8?B?YmE4REppSVYxaXpmd0FNTjcvU2lEZ3pBNytSajM1Sk9yUnN5MXVVYzg2eXM1?=
 =?utf-8?B?RW00RVBUTm56T2wyOW1ab1d5Vk5zRTJON29WcE5MOFBBL1haNmZEM1NUbnUw?=
 =?utf-8?B?b0tSTm5TdWhpMGR3aDRDdFViWXJ3QW04cUxCSE95b0tJTmJ6d1BoMGJsSXVS?=
 =?utf-8?B?eUxoL0dxK3doS3I2ejlqYzN1WjVuczJmWjVuRkhFczVpaFJPaFRXR0lZME9h?=
 =?utf-8?B?elpyTnd2QllVd3ZJbC9JMmtYRVVJRURBK002a2ovM3lpMFJUR2JBbWQ3aVh6?=
 =?utf-8?B?SDJVWXhFSjgrMFBmUlFuamZBV2FuV2NwVEVSajE3eG45dWx1enU5eTJPT2Z1?=
 =?utf-8?B?SURnNGNQaEdzN0l5VEZnVnhJbFpDa29lSWQ0akkzZ20xZFdEVnYrczFCYlhK?=
 =?utf-8?B?Nll6Z0lpOEhhNnBVcmNkeUlHeHBFdE1IQW50Um1aSzR6bzhlMHB4UEJwTnBr?=
 =?utf-8?B?Nm52em1JODd1VENCRTNwYU9yVThQd2IzbHpzTWdqNWREaG16T0pDYUsvUGt3?=
 =?utf-8?B?eDBTTjdkdHZONW5WNzRDcHA3V2hJbkdoQ2xacXJaNDZna0pMMjBNaFFJbERG?=
 =?utf-8?B?bEJUK0dFYnNTTVpPZ3N3UFpoYk00OG5weW1RY0hTNE42V1MvVGRRQWgvbkwv?=
 =?utf-8?B?bHQ1T2ZGclY5M2k2N3R6VmlZOEc1ZUg2ZktndS92Y3ZtSnVQN0FqblJvQi9k?=
 =?utf-8?B?MnFlNTdwRTRqRWpIa1ZuS1R0MWZZcTlzSXJUaE1oZXNXL2oxNDRSSlpvY2VL?=
 =?utf-8?B?c3c2WlFweXRuOGpaTzNiZG9nRmthZkxFbEg3NE9kM2NyVVBkYXA5b1J4bzJs?=
 =?utf-8?B?SERXRSs4OE5CbURnQ0trdXFpOXBMU3JxVEMvSFZtamlKVEl4WWNMN0pJYU9S?=
 =?utf-8?B?Umk0YUR4ZlM1M3Z6TnJ6Wk1zSTBUKzlaMjlQaGxHejhSbmtFaDdWY0dtajh3?=
 =?utf-8?B?QTIzeEt0Q3Y3K0w1b2wxVnBWRjNIaWQyZ2xEdEdpUmQ5cEgwTWxRMWNrQVE4?=
 =?utf-8?B?dmhBWjQ4OWMxVHpQZm0xdUl3ZUVtdEc1a0lMNFRLa01Ba1M2TmI1ZFh1U0Jw?=
 =?utf-8?B?Y1dUbTVtbTdHNjJWU0ZVUE9EVUJWWEtBMXlpZXNxMmtXZ3NCd3ZsL3pzbzl3?=
 =?utf-8?B?Y0JzeEZPUmdDNHVaRUgzdnF3Y0lCRGUwMTREckpyMHBzRFplUUhpVllieDVx?=
 =?utf-8?B?N3NONElQR3FIWStmQVMrM2FuT3ozWWx6QkpTVWJYQVVob1pJSkREL2dnL2Vn?=
 =?utf-8?B?VGQ2N2hXUnEzcVBRaVFYcDZoazBQY29nVlZLbytoOWlLMlVaMEZpejFOQTYv?=
 =?utf-8?B?Z0Zpcm95S1R4UEpxcnA3NTFVbUtEVTNGbWRWcVAySlNtVHhJclc2UT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14cec660-fa7f-4f18-a78f-08da276f2f2b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:26:11.3839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9nr95IJ+qfJmgLr+UyPPZki/mIUr2wfDEbi6hP0/lXqIzMXhhWOwQgXO4p7l6fDC2I4CZEEabdnKqTjmzOw3Sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3125

Just like for PV guests MMU_MACHPHYS_UPDATE implies marking of the
respective page as dirty, additions to a HVM guest's P2M should do so.

For HVM the opposite is also true: Pages being removed from the P2M are
no longer dirty at their prior GFN; there's no point in telling the tool
stack to try and copy that page, when this will fail anyway (until
perhaps a new page gets placed there). Introduce paging_mark_pfn_clean()
(intentionally without a paging_mark_clean() counterpart) to handle
this. Note that while there is an earlier call to set_gpfn_from_mfn() in
guest_physmap_add_entry(), but there's little reason to mark the page
clean there when later in the function it'll be marked dirty. This is
even more so given that at this point it's only the M2P that gets
updated, with the P2M still left unchanged.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
p2m_add_page()'s error handling looks bogus in this regard anyway: If an
error occurs before an MFN actually is assciated with the new GFN, the
M2P entry ought to be restored imo. But of course a guest is still hosed
if the operation succeeds partially.

Note that I've not even checked mem-paging and mem-sharing code for
whether they may need similar adjustment. At least the latters is, aiui,
incompatible with log-dirty mode anyway.
---
v3: Re-base.

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -549,7 +549,10 @@ p2m_remove_entry(struct p2m_domain *p2m,
         {
             p2m->get_entry(p2m, gfn_add(gfn, i), &t, &a, 0, NULL, NULL);
             if ( !p2m_is_special(t) && !p2m_is_shared(t) )
+            {
                 set_gpfn_from_mfn(mfn_x(mfn) + i, INVALID_M2P_ENTRY);
+                paging_mark_pfn_clean(p2m->domain, _pfn(gfn_x(gfn) + i));
+            }
         }
     }
 
@@ -737,8 +740,11 @@ p2m_add_page(struct domain *d, gfn_t gfn
         if ( !p2m_is_grant(t) )
         {
             for ( i = 0; i < (1UL << page_order); i++ )
+            {
                 set_gpfn_from_mfn(mfn_x(mfn_add(mfn, i)),
                                   gfn_x(gfn_add(gfn, i)));
+                paging_mark_pfn_dirty(d, _pfn(gfn_x(gfn) + i));
+            }
         }
     }
     else
@@ -1096,6 +1102,7 @@ static int set_typed_p2m_entry(struct do
                 {
                     ASSERT(mfn_valid(mfn_add(omfn, i)));
                     set_gpfn_from_mfn(mfn_x(omfn) + i, INVALID_M2P_ENTRY);
+                    paging_mark_pfn_clean(d, _pfn(gfn_x(gfn) + i));
 
                     ioreq_request_mapcache_invalidate(d);
                 }
@@ -1117,6 +1124,7 @@ static int set_typed_p2m_entry(struct do
         {
             ASSERT(mfn_valid(mfn_add(omfn, i)));
             set_gpfn_from_mfn(mfn_x(omfn) + i, INVALID_M2P_ENTRY);
+            paging_mark_pfn_clean(d, _pfn(gfn_x(gfn) + i));
         }
 
         ioreq_request_mapcache_invalidate(d);
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -657,7 +657,10 @@ decrease_reservation(struct domain *d, g
             }
             p2m_tlb_flush_sync(p2m);
             for ( j = 0; j < n; ++j )
+            {
                 set_gpfn_from_mfn(mfn_x(mfn), INVALID_M2P_ENTRY);
+                paging_mark_pfn_clean(d, _pfn(gfn_x(gfn) + i + j));
+            }
             p2m_pod_cache_add(p2m, page, cur_order);
 
             ioreq_request_mapcache_invalidate(d);
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -260,7 +260,7 @@ static int paging_log_dirty_disable(stru
 }
 
 /* Mark a page as dirty, with taking guest pfn as parameter */
-void paging_mark_pfn_dirty(struct domain *d, pfn_t pfn)
+static void mark_pfn_dirty(struct domain *d, pfn_t pfn, bool dirty)
 {
     bool changed;
     mfn_t mfn, *l4, *l3, *l2;
@@ -291,14 +291,15 @@ void paging_mark_pfn_dirty(struct domain
 
     if ( unlikely(mfn_eq(d->arch.paging.log_dirty.top, INVALID_MFN)) )
     {
-         d->arch.paging.log_dirty.top = paging_new_log_dirty_node(d);
+         if ( dirty )
+             d->arch.paging.log_dirty.top = paging_new_log_dirty_node(d);
          if ( unlikely(mfn_eq(d->arch.paging.log_dirty.top, INVALID_MFN)) )
              goto out;
     }
 
     l4 = paging_map_log_dirty_bitmap(d);
     mfn = l4[i4];
-    if ( mfn_eq(mfn, INVALID_MFN) )
+    if ( mfn_eq(mfn, INVALID_MFN) && dirty )
         l4[i4] = mfn = paging_new_log_dirty_node(d);
     unmap_domain_page(l4);
     if ( mfn_eq(mfn, INVALID_MFN) )
@@ -306,7 +307,7 @@ void paging_mark_pfn_dirty(struct domain
 
     l3 = map_domain_page(mfn);
     mfn = l3[i3];
-    if ( mfn_eq(mfn, INVALID_MFN) )
+    if ( mfn_eq(mfn, INVALID_MFN) && dirty )
         l3[i3] = mfn = paging_new_log_dirty_node(d);
     unmap_domain_page(l3);
     if ( mfn_eq(mfn, INVALID_MFN) )
@@ -314,21 +315,22 @@ void paging_mark_pfn_dirty(struct domain
 
     l2 = map_domain_page(mfn);
     mfn = l2[i2];
-    if ( mfn_eq(mfn, INVALID_MFN) )
+    if ( mfn_eq(mfn, INVALID_MFN) && dirty )
         l2[i2] = mfn = paging_new_log_dirty_leaf(d);
     unmap_domain_page(l2);
     if ( mfn_eq(mfn, INVALID_MFN) )
         goto out;
 
     l1 = map_domain_page(mfn);
-    changed = !__test_and_set_bit(i1, l1);
+    changed = dirty ? !__test_and_set_bit(i1, l1)
+                    : __test_and_clear_bit(i1, l1);
     unmap_domain_page(l1);
     if ( changed )
     {
         PAGING_DEBUG(LOGDIRTY,
-                     "d%d: marked mfn %" PRI_mfn " (pfn %" PRI_pfn ")\n",
-                     d->domain_id, mfn_x(mfn), pfn_x(pfn));
-        d->arch.paging.log_dirty.dirty_count++;
+                     "%pd: marked mfn %" PRI_mfn " (pfn %" PRI_pfn ") %s\n",
+                     d, mfn_x(mfn), pfn_x(pfn), dirty ? "dirty" : "clean");
+        d->arch.paging.log_dirty.dirty_count += dirty ? 1 : -1;
     }
 
 out:
@@ -337,6 +339,16 @@ out:
     return;
 }
 
+void paging_mark_pfn_dirty(struct domain *d, pfn_t pfn)
+{
+    mark_pfn_dirty(d, pfn, true);
+}
+
+void paging_mark_pfn_clean(struct domain *d, pfn_t pfn)
+{
+    mark_pfn_dirty(d, pfn, false);
+}
+
 /* Mark a page as dirty */
 void paging_mark_dirty(struct domain *d, mfn_t gmfn)
 {
@@ -349,7 +361,7 @@ void paging_mark_dirty(struct domain *d,
     /* We /really/ mean PFN here, even for non-translated guests. */
     pfn = _pfn(get_gpfn_from_mfn(mfn_x(gmfn)));
 
-    paging_mark_pfn_dirty(d, pfn);
+    mark_pfn_dirty(d, pfn, true);
 }
 
 #ifdef CONFIG_SHADOW_PAGING
--- a/xen/arch/x86/include/asm/paging.h
+++ b/xen/arch/x86/include/asm/paging.h
@@ -165,8 +165,9 @@ void paging_log_dirty_init(struct domain
 
 /* mark a page as dirty */
 void paging_mark_dirty(struct domain *d, mfn_t gmfn);
-/* mark a page as dirty with taking guest pfn as parameter */
+/* mark a page as dirty/clean with taking guest pfn as parameter */
 void paging_mark_pfn_dirty(struct domain *d, pfn_t pfn);
+void paging_mark_pfn_clean(struct domain *d, pfn_t pfn);
 
 /* is this guest page dirty? 
  * This is called from inside paging code, with the paging lock held. */



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:27:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:27:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313718.531424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIPn-0001h9-62; Tue, 26 Apr 2022 10:27:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313718.531424; Tue, 26 Apr 2022 10:27:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIPn-0001h2-2z; Tue, 26 Apr 2022 10:27:27 +0000
Received: by outflank-mailman (input) for mailman id 313718;
 Tue, 26 Apr 2022 10:27:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njIPm-00013U-1E
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:27:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 77036a99-c54b-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:27:25 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-SQPZjC1tNVe3H6HnzLSA_w-1; Tue, 26 Apr 2022 12:27:16 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB6490.eurprd04.prod.outlook.com (2603:10a6:10:10d::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:27:14 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:27:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77036a99-c54b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968845;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lOjHQbvjAHuNhYfaLpMKdkqXrWxqv6HPbYChJwJDg6s=;
	b=J91soNFfJrWW9E+zp9jZod1w9Rt8yKlgfNMEE7lnBgeKohrP1xDdKr5Xwtu4HGmKRXx0mt
	dkK9ZZxPpX0QCnhyflzej1YGDUM8OH8jX+Ef7WSer+GazybQfZzMP/RjGXjbRdig3bzBpH
	VvI0L5OOjX9kVmtxv6imso7FszeOa3o=
X-MC-Unique: SQPZjC1tNVe3H6HnzLSA_w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a0HCQxy/rwcoRNVQWgX8z16CNC3WzwCyj2163Gs0HBp0Ce0gxIOLNT8OTXXZyvoEhbtCFVH4jWb0WabqQ83hkfHfNwAoBrKB8VtKAFJ4XHnAmyzeACoYAgv/7esL1O3Pj9464fL05vLuFTPMTA4NBbLCNsR2/ydRnWISluHthAQwwy9feRb16YjtyXvFQC6exCGoqRt2tmoDTq+xOaq4Y0j73cLIx4Cx5KO2ZAVfIJXgW5OE3rR3QRNo2TUPjVKXfDIC8m0TegoJmo3m8cRPUU52un1xud5qnNZhii6shMpPv8CvS6BTOvKU2odqQmsZyooiIr/TboQ3PfnHp9tjbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lOjHQbvjAHuNhYfaLpMKdkqXrWxqv6HPbYChJwJDg6s=;
 b=Tm0PVVMHKmQFK701yt4mUv5vTgKqGdesq+YvqpPauhwgkK1kpAs7s790mhHh/cWCQOARrViWPGpg+t0Soa9UwJQAkImAaLJwE/UENTTltLhPZg+w5lABA+IWxaHnQH/7HJ+S1YY1A8FxdC8B7K83CjfbO4y0tSXR+tBQ5qKYYLhhmNlWS1PqYMePEYL3/izTu5mllWh3m7mlJV5TpypicM20FnoYc5YtQUXYLfP+JPAVMQnfH5Jcv4NMdSydOXE8yobbQ/JH4v9mm+DOqGFD10AUysdYWhi7hk8NkURuaX5mtMfg83hEnn2Qu+RaqEn+P4/I9G4DkSffNYJRhZqhwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6d6144f6-489e-d9b0-b590-f5d65c385116@suse.com>
Date: Tue, 26 Apr 2022 12:27:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v3 8/8] SUPPORT.md: write down restriction of 32-bit tool
 stacks
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Anthony Perard <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
In-Reply-To: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0113.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 34508f68-a06f-4300-a9a5-08da276f550c
X-MS-TrafficTypeDiagnostic: DB8PR04MB6490:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6490FA6918410292AA7C4831B3FB9@DB8PR04MB6490.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8xGre95ZSjcj67qXqX0hYLjNpjOMkrPryKyqzMqMLZUb2pvG2SmRpOA9i+HriCPZiKnYQNKRmYQIrjEQJ5Q83h3ug5IhEqLqLQoEFSTYfxom1IA7Hom8dZzj5uckkIJiYOf0e2DCQOt2ieY8olBrYYnzZtPk2ZIJO51C9gBHaF9mhCgF7MLZXWJTO2JDPqK/mQ7hQCXfAk7b2WhYtNzEx1ycq/P2yAl+h7gR5iXHsD8ngQH6JckU/SJFyf8XhhiMxy9CaJqAGumohTK8Cv8dF0jHTNso6nzgr5OkayMkImZB8ijbHTOofwl0/3gLd+Jw7EhWsK7sW/Bq+XGk29Zh3Tq3qhx6LvsRuW00dM4343l2psE+6FpdYUxSIcKX79tX3VhGB0GVeT8vGYhs1FkuGZ7gbAA6OjXeb/Q28apVLi6x67qMPPfp62piWt4fJdiOIOtdAbk0DMCpDhclWmsPDsERTxUZHplVPzH/yDeo8k2iWLqIlXchS4M765okTqzDWe8I3JvexUeyEusb+jsVo1UH9gcHc/pQEHOXwfZXicCyTMueXPaLkxS90WAOuHZ37HV4o35lbJWoxH/TYeLE+p3+YJzHQp/5aU4HYMqwPjwesmwxTitdIZHa2Xl2Rdr+CNRpfOpYBjkCaEJDRv4KRIXSaa5RtoowWTz5coVkPpfIGkrn1pHssr5TJMxfBu95htELP1N5gx/bqEGuXPce2fZ0DlQhfE8iMWIng7TLb4M9aMeJ3SEt6prLR1A5Ia8m
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(26005)(38100700002)(6486002)(6512007)(66556008)(508600001)(36756003)(4744005)(5660300002)(2906002)(31686004)(8936002)(2616005)(66476007)(66946007)(8676002)(4326008)(186003)(54906003)(6916009)(31696002)(316002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VzlZdmFmeldUdnFnN0w4d1h1SDZCbUkwakJUL2FueFBBNjFxOTQwZ0ljVDNM?=
 =?utf-8?B?YzBiQTE5NFI0cE1hWlljZGpVdGNOMjNqZUI3Rlh4SVVsVVJVY1JBMXRDNmVS?=
 =?utf-8?B?bWhrWmJLSUhIaWtBMVBSQy9VaVJtckl4V2tzQ0tqVTJKRmJjUlZZbjVxQnEx?=
 =?utf-8?B?aElhK0xVbUN1Rk9YMW9UN3RCWTZCZVJyUUhEc25kaWUvbXdNQys0UWlsdUpo?=
 =?utf-8?B?cXB2TUZqdEhPNTBDTU5IemVPeEhmYlgxUHM5bDRUSEdHSyttMmhuVVRkemtK?=
 =?utf-8?B?QUJYOVJweHozekJoM1d0TFF5VVdHUTR1VFd2MkowNU1BS3pDZlFzRzVVTHY0?=
 =?utf-8?B?SmIzUyt0VEFQZVdXQm1XaFBJUFA5ZVlZRGR2NDlCMHRWdytzMUxQc0xobEJj?=
 =?utf-8?B?bXVRTFBXaTdLZkFqTGJvcmZsZFYxYWd0ck1PMDNqOFRjZDZSYnQ5WXlmU1pL?=
 =?utf-8?B?ZWhva2pwb0ZvZmRiYWxUUVVMNzloTG5ZcWxLekdpb24wL0k1dkxnNERkY1d2?=
 =?utf-8?B?dzBHZTBZRnRxK1hZaGkvSUEyS1Qzd2FLMDlrZkgrMldXTWlIRWRULzlqMUhL?=
 =?utf-8?B?VmZ4UlJaUytHaUJ2ejNrQlQ3Tk5zTzFyMXA3aEd0UXFCVGFTQk9ONHExN1Fh?=
 =?utf-8?B?ZVV5ZkVkQ0JXeTd5OCtvOVF6LzlBaFZna3E1ZVM5bFpVN2FrSGNXdUlZUGpT?=
 =?utf-8?B?Und3SVFwU0szcGlocXo4V0VhY2luMHZEZ1pjUm1MY09EdTFHQktZbDdLWjhU?=
 =?utf-8?B?Ni8xR3A5RlcwNnI2RGE0NEwvZzRtdFVvVGFSeFNxYXM5ZGE3eElmSTkrVjlZ?=
 =?utf-8?B?S1hTTjNralNkU3BrZkQ5V21yT2Z4TnlXaUdXVHBLOHVaK3hOL213d1IxbmFV?=
 =?utf-8?B?c01wWU5kOFMydjZJWTJweFlBTVAxWHVYSnUvTzVQOGFaRXBEZUFsbmZGb3FO?=
 =?utf-8?B?UlhGdVlXckxmVTNWNGpoQTRSZkl6OHVuMTRNYWVqamhJY3QyZ3F6bWQxenQ2?=
 =?utf-8?B?RUg0SU5xYnFrWmcvNkhRaS8zVnp1SkZWaVFocVRXNUs4citQZVhqdll6US94?=
 =?utf-8?B?NStqakpaUWorNTViREFFazZnRG1ZQ2lPOURsZmdMTTlseW1rQWMydDdaTGlQ?=
 =?utf-8?B?eXh3Y1lGdzJCbDlLNHJLZjV0QjcvT1RKejJ2bzVtVmMrcnlOT0Fza0ZwQ1dZ?=
 =?utf-8?B?c1hkb2U0cXZ0OE04KzZxb2FzQklqQk9LM29tcVcxZWVLeW9USk1OR0w1T1Jy?=
 =?utf-8?B?bWhjRFFLVUhjRE94SXA2YnZsU3B2aHU2ZWt6Y0JzeUJVbUFyTmRmVFM5MGpv?=
 =?utf-8?B?Nll3ZFNMVXB2azErSmhIa0RzNVhyOTROaVNFZTFMTVVDaGY0VjdYWlR6MEVo?=
 =?utf-8?B?MElvc1hkK21UTjg1SVkrSlNweG9yQ2pZb2RlM1U5Ti81MGpYZzQ5cHlWOGky?=
 =?utf-8?B?UzR2NHVYbmM3U2VzYVB5VW1nYlNvRG5DbjlLVXp1TEVrc05YY0Y4K0IyK2JT?=
 =?utf-8?B?OGJjcjRPNFZlNFNlcGl4K3FhMllrYnpTRVlaYWc2SmtrK0RpWms3WVZaSWx2?=
 =?utf-8?B?bzZicUl6WFZ1cGVoZlN4Q0RRLzVud0xrWHhoeFRaQzRrcHM0ZmtKOGxVd29s?=
 =?utf-8?B?RktVRTVkekFndTc3dGc3L0ZBekhUb25DemtNT1JMWDI5MUQwcnJpcXF4MkZC?=
 =?utf-8?B?RzZyQ3R6RHg0Tjh4aHhUS0FTYThaaGtCVHh2SW5adFRJejR3NWRaVnIvaTc2?=
 =?utf-8?B?czhkZndLakhLUDd2eTFLOXhmOFdUa04wU1V4OEhYVFpjRWlWZFZxT1laSzVB?=
 =?utf-8?B?OHFrVnpSeklSb2p4a0U5bCtCSkNQY050NXhqalNuR1V6Nm1HbnFzVThvWHFv?=
 =?utf-8?B?ZDc4TFZqSVNwOWV1a1pFYm5hc1lFeFlDQTJZZllzR2kySW95OGR6UW9lVHYr?=
 =?utf-8?B?b21INXQrRkl6SVhFbEluMWZWVm9RNGt0eGh1dFBmQkxOVXZXQXZEbnkrZ0FO?=
 =?utf-8?B?dVlMTHRwci8yKzU4TWxUNFB3OEJLU2lCL0c1Lzh1eHNWTlk0a2VGc29xdER0?=
 =?utf-8?B?YlJBTkRHN203NEsxbU0rNDFlVStiOFVPQ1A1b0VZT2N5alJyTjhzd3NPT216?=
 =?utf-8?B?VXovOVN5Ylhtdzk0ZHl1VW51V2lrRk8yTHlVeHAycllGNTlrVmxGL0lXRmJI?=
 =?utf-8?B?bFN2RWVoaUlPbjRjVDZWU0pkM1dIeXBPa3E2OUhaS3p4V0kyZlRRYkVkMU1B?=
 =?utf-8?B?VUY3NkdtNHU1R0xkb0NlaGJZKzRBZGlSWVkzOU9Sd2daU3c5RC9HYzlGR29r?=
 =?utf-8?B?Q1dDQjdZU3NSaE5wSWkyOWZvVVVTdjFVdFR3dWMxb0FJS2Vuc3cwUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34508f68-a06f-4300-a9a5-08da276f550c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:27:14.9030
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gccFYk4qLYQUz+duNfWhpYOzOGh6cOrusuHzq7P+M/JLlSFjle2cfNCSL+WEYcBHRkMz0bZN//3mWOwjV+Mq2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6490

Let's try to avoid giving the impression that 32-bit tool stacks are as
capable as 64-bit ones.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Wording adjustments as per review discussion.

--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -137,6 +137,12 @@ ARM only has one guest type at the momen
 
 ## Toolstack
 
+While 32-bit builds of the tool stack are generally supported, restrictions
+apply in particular when running on top of a 64-bit hypervisor.  For example,
+very large guests aren't expected to be manageable in this case.  This includes
+guests giving the appearance of being large, by altering their own memory
+layouts.
+
 ### xl
 
     Status: Supported



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:31:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:31:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313730.531435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIU3-00038J-OF; Tue, 26 Apr 2022 10:31:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313730.531435; Tue, 26 Apr 2022 10:31:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIU3-00038C-Kt; Tue, 26 Apr 2022 10:31:51 +0000
Received: by outflank-mailman (input) for mailman id 313730;
 Tue, 26 Apr 2022 10:31:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njIO9-000707-0X
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:25:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3a561eab-c54b-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:25:43 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-HQjnU6s_OFq7ccEn-YbM4Q-1; Tue, 26 Apr 2022 12:25:42 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB6684.eurprd04.prod.outlook.com (2603:10a6:10:105::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:25:40 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:25:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a561eab-c54b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650968743;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CpxLoT33b7I8wFn5AiNrMktbKi2AOwgyFO+mknPIv+0=;
	b=in0QdvpfjAkL0dTrSi569dZeLp4B19d1FRf9p5RqfhQK8U0kCAMXsZqX0+CMYnKDaSCioy
	3Pdxf/1LFEuhryYqsZ4rXPRR+NYRRsR3dyhorG39RU7dB2bHVe1VceRyBpEKNDWUlmv6WU
	V340bkcQ+hzpYpMFzuAZmNfPtB2ydvQ=
X-MC-Unique: HQjnU6s_OFq7ccEn-YbM4Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LtP4j6gnTwbLIrXrAUFHzFY822/n16j2FmyoX5UNlM9sh+TkJ0Hjj3Z0ZZ5mIawZA+oLBo18yR0vHoxAfAABum0mt4iwXGmA7J7+N6AiKhpEPwX314Hav1On8g+o0AjKH99+LEQy67fy6KdxTGU9W3/T/os1XV27jRMzVB6ORIFDg5ysZePKiGm7IfOOGSyT8jm5xXYpWVxzWgzfFAx3A1IsWPTsNvnwIxcv5fALt16oNh/hpvkH+zDZKcjPndiiutKtULyIfnKxk9AlGlNWMDxQhInJccg/G7QwZiNumYM/dN3Z2Ix22/M7uCotkt0Pq/s777Pdc2BdeQUPEJ5P2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CpxLoT33b7I8wFn5AiNrMktbKi2AOwgyFO+mknPIv+0=;
 b=f8yN7f5T7cQsghg7paHTWO415OgEoBw1tngrbq4+4nYs0L2wEWoPWRIGq6GiIlBC/fEV1yPg2is3lZTYZKigP2sJ2t7t5kYYLU+YUz5oLFP9liWD7WcPRK8GE9xl/ZomUcf9QPimk6lkCeI2yemqKBtXhY+2EnWYNNhD31HQpizkCFjIBBwnxlNN5vg4lpwBCzFPc8klPd3Zi/nauRVzce+C6ZNI+Vba6CrogqQim3g11a+n8E4XYmhcRVqpINfqfGDpiwpAhS13H717MDm9TB7UIAYfpwWB1nNGyE8ZyO0AIjHlNWwOc0yAIidPLqs2IkZZBuKOkhF5pOwDSwEX6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b35501dd-0462-4961-3574-42b84b637933@suse.com>
Date: Tue, 26 Apr 2022 12:25:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: [PATCH v3 6/8] x86/paging: supply more useful log-dirty page count
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Juergen Gross <jgross@suse.com>, George Dunlap <george.dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
In-Reply-To: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0194.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::19) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1274e413-09fd-4269-26be-08da276f1cb8
X-MS-TrafficTypeDiagnostic: DB8PR04MB6684:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB66847273B1935B2E18497926B3FB9@DB8PR04MB6684.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6I7TDLLE8bi3LR8WMxc0OUSQNqGz11nIgK2sj2X1fl+yOjLocVc1uvv/07YzagZqVEU9Z6dfAViH1Lgj1daGdrVYub3SPlw5SsLiX6Yvzzo3PKWlVMmrFEgwWPacQ/Dl82pjliTnoewkYpd2t7Aq3+I0deyH3t/Yr6SiIML3oK/FPTEmx2QCaLebgdG8pEERUkEx/DNnET+SpkLDx5DcfmU7MKO/q1bNuGi2DyFhrWozgcdSj3MkaKro2pYCO8p9MpdiN6ZfGy4PwVyCFeRqeo5O9z9VEQ3yyMjiVDR8hOWMRi2yBWYFrkZF4k8aSt72KkDlvjlm4xbS/c3sAybvTScLZO9NfbuEzgOoALBOYb4ccFaSm2LVXP7ifnX2ulvBEPOZBDnVAhgJ4V0CP8cdQRNQ/ztci29JwckV1GyMf2TPDlNCR5dpYrERO+gjc79xWSC4OtsuQnVB40nuv3X65JcnX5gTAGJig81oM47TWI7KyUdG+6zm+7VeEVpb5WIwlFXwaJiWLHPd4vF4yo+aVPKZTNuWoMdnmcmHYQ3OvDgvCr6cNMRvVQm8P0yd4v62XVOomHLcRNUuAgfuRpnUWcdmVxERi6lxpX7r8GDD5lUet+QcX06CyCc5Aq7OqloB3rBfCNeNPApJbEZuADSQaz/AtSlIh6lzPfy3fTkIpYyrwoOrquohyXReyqHUCDytFSMdFfF1IRotefWE7M9+QfmE6WmjibZ9Klat/fWsZ8hjrAzQjg17f7dR+bgpZ39Tm+zC5Ui+uuQDVgZI5OEMfA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(38100700002)(83380400001)(508600001)(86362001)(8936002)(36756003)(6506007)(5660300002)(31686004)(30864003)(2906002)(2616005)(6916009)(26005)(66476007)(4326008)(54906003)(31696002)(8676002)(66556008)(6512007)(66946007)(316002)(6486002)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aWthTHBGZmlYSlQvSEgzd1JLSlRlSXd3bUhER3ErUEJwQXZ6WUtCWjdOUjEv?=
 =?utf-8?B?VUJZMzJWMnBEdGZ3aVBqQUd1eFZTTXlOR01hWGdiRVA0N0YyV2F3UUVlaUJJ?=
 =?utf-8?B?MzZXcEIxTjdIWXN5RkxIVWliWEk4K1Q2UEFEQ1NFWjRLNjdQNkV4eGRDRERS?=
 =?utf-8?B?RzBTUGJubjRxblFJLzBWY0F2OTJCeWQxRURJeUJJS0JzMUx6SlI4S3dBbmlT?=
 =?utf-8?B?b1oveWx6V0p2YzlFaUZXS1V0UGhuMENGQ0lRMWNrTU9BUTgvM0p3OWFHWHJ6?=
 =?utf-8?B?WWdOV3VpcS9vYTFiK1lPcG5JVW5YNk1vVldaTit0TnhsL2xXOGNOaFVhc1du?=
 =?utf-8?B?djJab01rc2dTQUFrNFp3SWxmaTZkc2pTVW1ya0ZMSUhLRm40eC90MzdMWFBH?=
 =?utf-8?B?bllsOSsrK1pwYnZydThCL2JMcDNNZnlkQzJlTkJES1FvdGdUTEZLMUZFMjV4?=
 =?utf-8?B?anR4WC9XSjNpd0hCRWZDRWZsUk9CeUNuVGVWRjZKSjB2MWJhVFgzZEt0V0dK?=
 =?utf-8?B?NnVESWg1eTFNeG5nUXJyUmwrNS9YV1VpT2lORXJqU2tJM2VtYUwzQVgwemJq?=
 =?utf-8?B?TTFsWW5JRGptc3Q1YVl6TzJmaHJ6WExGYkJIc3NFdEM4YmMyYmp5a3YvRkJ2?=
 =?utf-8?B?VDFwTG5pTHlicmdQYkJxNTI2NC95SUd3MlNWZENUaFk2bmxObmZlOVRsZ0Vu?=
 =?utf-8?B?RVlmeWRJWWpaaElCQ0Y4TXFtdWVZOWRnTFhWT2NTd0V4bkp0WVNxazBOem84?=
 =?utf-8?B?U05tZENzWTJuZFJBOGcrRERlQTZqWldDczMxUjRBRUtVcEJucitSTjkxTzlM?=
 =?utf-8?B?UCtyQUFLeDhwM3NMTjRUbCtWSFhrNVZUMUxxaWlxdFg0aCtMWkZxWTlJSVpE?=
 =?utf-8?B?QUFBMjRWaVUvZWQyQ2l3SUdJdzJUMURMUnNVM25SUjBoa3k4bEdVUU5qazUy?=
 =?utf-8?B?UWtkYm43UXMxVlcwb0RMdm1wTWFaT2xKNDJlVW93TE4wby82TlRnY0lESVls?=
 =?utf-8?B?djNzb0pPZURMemZyQXZOMGxRSVJPTHFQT2ViYUgrbmpBWEZ6Lzgva2s1OWM4?=
 =?utf-8?B?bC85V2NJMlQ2clVkMGV3eXdYQjZacVZRN25jQ1gyR2dZREpNMEtQVXdCS0pm?=
 =?utf-8?B?R3FGWUpvOE55K1J5Z2k0LzNYc2pJR01uVVoyQTBXZ0V4ZXRCMmk3eklPQkVY?=
 =?utf-8?B?eVVhWjN5bjJSMStXTXRmbGhCeXNRRVFCQkhtbTZCQnlDbzlVV3BEUFkzU2JW?=
 =?utf-8?B?MVRZUkxTbmd3aG51eWxIYkJmcmVqZ0tPOGpValRheEdkZUdMcVJGNk9VRzF6?=
 =?utf-8?B?eDBlQ3J5SGgwa05Jc1ZYQ1FRbk83SFc5K2d5Z0poYVFlazNJdVFWS2QrWmlG?=
 =?utf-8?B?N0JnYzZwVnZTbHBjQUx6YUI1VEJlOVRiQVhWeE5CQU9naWZxKzJoMUpSa2R5?=
 =?utf-8?B?eUUvUWkwY25mZkJJUnlyb0pMWVhLNXNyWE53cGkwS3JVNmVQZnF0T3Z0NEkv?=
 =?utf-8?B?NGh5cXJaQzhyRm4wNW5SNml3ZXFGNEZlUFhHN3VnaERkWnFLZ0lwbXJkR2N2?=
 =?utf-8?B?bXhxalVOcXR6dHdjTmRXSmZPYlpSVWVudVdNc21FUmVYWEtqTFFkYnd4c3NW?=
 =?utf-8?B?YjFteDBXRk1NZWNnNG9waVhPL0tqamEyVG1OcnVFekF6cDhjOGxNaEl3QUdJ?=
 =?utf-8?B?dm1SeStZRFFqWUxxTkZJV1c1ZGhDNU5sd1hJNFRvZnBGNnkyR3JJbklJMEx6?=
 =?utf-8?B?anhUVGVvTFlpdE9FRllBYmhIc3U0bTM1U1puWHA3MDVLSnB2Q1ZqSkZHbWpx?=
 =?utf-8?B?M2hiWUUwUk9Id1FNSkx0SkY1c0lzTXNKeE9nOHZRLzBTWFRRSkVZbWZLTHlk?=
 =?utf-8?B?SitGbXAxZGRCcUZyd3JvU1hIQ05ob2NXcFN4OVFSRVFsQ3liWlNvYXhESEQ2?=
 =?utf-8?B?c0UwdCtQT0NySTlPY0hhaW1oVTNNN1NxK291a28vNERLd3NQcVZQOHI2VEZn?=
 =?utf-8?B?Uk94eXhFSkp4dnFXS1E0WVA0UnVaTU5rQS9rbC9oUFlNWk5TNEVoMVZNcVlS?=
 =?utf-8?B?R0hLc0J6TFRTZnB5YVYxWmlRQWR2THptZGZFaWlSdXlZdGlpSlc4UHpiUjYr?=
 =?utf-8?B?ZUxOcE85Z2xmVGJtVzJrRTVUZHY3NThneDhtL0xlZUNTeTZXc25Cd2hXZml3?=
 =?utf-8?B?Y1JOdDc5SlJMZ1dWR21TaklZSEFaaENHMkdTTU1ySkZRbnU4VXpuWGxEMEpV?=
 =?utf-8?B?YWlQbUQvb0JJd1F0bUg3RnVPSm1CbTBMWDVQbmxNRjRJTno5UVFZVHFOU0kx?=
 =?utf-8?B?aktodDJmRURVRGczQVQ3Z3YzOFBRTjJpQ3cxd1ZhTWRsR0Nnd1NBQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1274e413-09fd-4269-26be-08da276f1cb8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:25:40.4123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xU8hTMCl6VDCL/d/e9cW+VeqQMawNROhzFW+Siu/0mCTdY5mwM1bjwfn90Zf+m355EpZr1inhpMt9a6O17vUiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6684

In paging_log_dirty_op(), always update the count of pages field:
- if more pages were specified than the guest has ever accessed (HVM) or
  marked part of the p2m (PV), there's no point for the caller to
  inspect bits beyond the one for that last page,
- if the guest's p2m size has grown in the meantime, the caller would
  have no indication that it may not have caught all dirty bits.

Also exit the loop once having passed the last valid GFN. To balance
overhead and savings, do this before inspecting a new L2 table.

Adjust libxenguest accordingly, albeit these changes are necessary only
for guests which actually alter their P2M size while under migration.
They do, however, additionally open up the option of the hypervisor
eventually zapping large ranges of trailing zeros from the bitmap when
providing it back to the tools.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Of course this still is far from ideal: At the very least a perhaps
large tail of zeros could very well also result in a reduced page
count.
---
v3: Replace mfn_valid() by !mfn_eq(, INVALID_MFN) (and rebase
    accordingly).

--- a/tools/libs/guest/xg_sr_common.h
+++ b/tools/libs/guest/xg_sr_common.h
@@ -237,7 +237,16 @@ struct xc_sr_context
             /* Further debugging information in the stream. */
             bool debug;
 
+            /*
+             * Counts of bits (each representing a guest page), expressing
+             * respectively
+             * - obtained P2M size,
+             * - allocated bitmap size,
+             * - range actually filled with valid data.
+             */
             unsigned long p2m_size;
+            unsigned long p2m_alloc_size;
+            unsigned long p2m_used_size;
 
             struct precopy_stats stats;
 
@@ -245,6 +254,7 @@ struct xc_sr_context
             unsigned int nr_batch_pfns;
             unsigned long *deferred_pages;
             unsigned long nr_deferred_pages;
+            unsigned long used_deferred_pages;
             xc_hypercall_buffer_t dirty_bitmap_hbuf;
         } save;
 
--- a/tools/libs/guest/xg_sr_restore.c
+++ b/tools/libs/guest/xg_sr_restore.c
@@ -424,7 +424,8 @@ static int send_checkpoint_dirty_pfn_lis
     xc_interface *xch = ctx->xch;
     int rc = -1;
     unsigned int count, written;
-    unsigned long i;
+    unsigned long i, p2m_size;
+    long long ret;
     uint64_t *pfns = NULL;
     struct iovec *iov = NULL;
     struct xc_sr_record rec = {
@@ -433,22 +434,29 @@ static int send_checkpoint_dirty_pfn_lis
     DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
                                     &ctx->restore.dirty_bitmap_hbuf);
 
-    if ( xc_logdirty_control(
-             xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
-             HYPERCALL_BUFFER(dirty_bitmap), ctx->restore.p2m_size,
-             0, NULL) != ctx->restore.p2m_size )
+    ret = xc_logdirty_control(
+              xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
+              HYPERCALL_BUFFER(dirty_bitmap), ctx->restore.p2m_size,
+              0, NULL);
+    if ( ret < 0 )
     {
         PERROR("Failed to retrieve logdirty bitmap");
         goto err;
     }
+    if ( ret > ctx->restore.p2m_size )
+    {
+        ERROR("Guest has grown its p2m too much");
+        goto err;
+    }
+    p2m_size = ret;
 
-    for ( i = 0, count = 0; i < ctx->restore.p2m_size; i++ )
+    for ( i = 0, count = 0; i < p2m_size; i++ )
     {
         if ( test_bit(i, dirty_bitmap) && !++count )
             break;
     }
 
-    if ( i < ctx->restore.p2m_size )
+    if ( i < p2m_size )
     {
         ERROR("Too many dirty pfns");
         goto err;
@@ -469,7 +477,7 @@ static int send_checkpoint_dirty_pfn_lis
         goto err;
     }
 
-    for ( i = 0, written = 0; i < ctx->restore.p2m_size; ++i )
+    for ( i = 0, written = 0; i < p2m_size; ++i )
     {
         if ( !test_bit(i, dirty_bitmap) )
             continue;
@@ -713,8 +721,10 @@ static int setup(struct xc_sr_context *c
 
     if ( ctx->stream_type == XC_STREAM_COLO )
     {
+        unsigned long pages = NRPAGES(bitmap_size(ctx->restore.p2m_size));
+
         dirty_bitmap = xc_hypercall_buffer_alloc_pages(
-            xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->restore.p2m_size)));
+            xch, dirty_bitmap, pages);
 
         if ( !dirty_bitmap )
         {
@@ -722,6 +732,8 @@ static int setup(struct xc_sr_context *c
             rc = -1;
             goto err;
         }
+
+        ctx->restore.p2m_size = pages << (PAGE_SHIFT + 3);
     }
 
     rc = ctx->restore.ops.setup(ctx);
--- a/tools/libs/guest/xg_sr_save.c
+++ b/tools/libs/guest/xg_sr_save.c
@@ -74,6 +74,16 @@ static int write_checkpoint_record(struc
     return write_record(ctx, &checkpoint);
 }
 
+static void update_deferred_pages(struct xc_sr_context *ctx, xen_pfn_t pfn)
+{
+    if ( !ctx->save.deferred_pages )
+        return;
+    set_bit(pfn, ctx->save.deferred_pages);
+    ++ctx->save.nr_deferred_pages;
+    if ( pfn >= ctx->save.used_deferred_pages )
+        ctx->save.used_deferred_pages = pfn + 1;
+}
+
 /*
  * Writes a batch of memory as a PAGE_DATA record into the stream.  The batch
  * is constructed in ctx->save.batch_pfns.
@@ -130,11 +140,8 @@ static int write_batch(struct xc_sr_cont
                                                       ctx->save.batch_pfns[i]);
 
         /* Likely a ballooned page. */
-        if ( mfns[i] == INVALID_MFN && ctx->save.deferred_pages )
-        {
-            set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages);
-            ++ctx->save.nr_deferred_pages;
-        }
+        if ( mfns[i] == INVALID_MFN )
+            update_deferred_pages(ctx, ctx->save.batch_pfns[i]);
     }
 
     rc = xc_get_pfn_type_batch(xch, ctx->domid, nr_pfns, types);
@@ -192,12 +199,7 @@ static int write_batch(struct xc_sr_cont
             {
                 if ( rc == -1 && errno == EAGAIN )
                 {
-                    if ( ctx->save.deferred_pages )
-                    {
-                        set_bit(ctx->save.batch_pfns[i],
-                                ctx->save.deferred_pages);
-                        ++ctx->save.nr_deferred_pages;
-                    }
+                    update_deferred_pages(ctx, ctx->save.batch_pfns[i]);
                     types[i] = XEN_DOMCTL_PFINFO_XTAB;
                     --nr_pages;
                 }
@@ -365,7 +367,7 @@ static int suspend_domain(struct xc_sr_c
  * Send a subset of pages in the guests p2m, according to the dirty bitmap.
  * Used for each subsequent iteration of the live migration loop.
  *
- * Bitmap is bounded by p2m_size.
+ * Bitmap is bounded by p2m_alloc_size, but populated only up to p2m_used_size.
  */
 static int send_dirty_pages(struct xc_sr_context *ctx,
                             unsigned long entries, bool all_dirty)
@@ -377,7 +379,10 @@ static int send_dirty_pages(struct xc_sr
     DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
                                     &ctx->save.dirty_bitmap_hbuf);
 
-    for ( p = 0, written = 0; p < ctx->save.p2m_size; ++p )
+    if ( all_dirty )
+        ctx->save.p2m_used_size = ctx->save.p2m_size;
+
+    for ( p = 0, written = 0; p < ctx->save.p2m_used_size; ++p )
     {
         if ( !all_dirty && !test_bit(p, dirty_bitmap) )
             continue;
@@ -522,6 +527,8 @@ static int send_memory_live(struct xc_sr
 
     for ( ; ; )
     {
+        long long ret;
+
         policy_decision = precopy_policy(*policy_stats, data);
         x++;
 
@@ -548,15 +555,23 @@ static int send_memory_live(struct xc_sr
         if ( policy_decision != XGS_POLICY_CONTINUE_PRECOPY )
             break;
 
-        if ( xc_logdirty_control(
-                 xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
-                 &ctx->save.dirty_bitmap_hbuf, ctx->save.p2m_size,
-                 0, &stats) != ctx->save.p2m_size )
+        ret = xc_logdirty_control(
+                  xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
+                  &ctx->save.dirty_bitmap_hbuf, ctx->save.p2m_alloc_size,
+                  0, &stats);
+        if ( ret < 0 )
         {
             PERROR("Failed to retrieve logdirty bitmap");
             rc = -1;
             goto out;
         }
+        if ( ret > ctx->save.p2m_alloc_size )
+        {
+            ERROR("Guest has grown its p2m too much");
+            rc = -1;
+            goto out;
+        }
+        ctx->save.p2m_used_size = ret;
 
         policy_stats->dirty_count = stats.dirty_count;
 
@@ -610,7 +625,7 @@ static int colo_merge_secondary_dirty_bi
     for ( i = 0; i < count; i++ )
     {
         pfn = pfns[i];
-        if ( pfn >= ctx->save.p2m_size )
+        if ( pfn >= ctx->save.p2m_alloc_size )
         {
             PERROR("Invalid pfn 0x%" PRIx64, pfn);
             rc = -1;
@@ -638,6 +653,7 @@ static int suspend_and_send_dirty(struct
     xc_shadow_op_stats_t stats;
     char *progress_str = NULL;
     int rc;
+    long long ret;
     DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
                                     &ctx->save.dirty_bitmap_hbuf);
 
@@ -645,16 +661,22 @@ static int suspend_and_send_dirty(struct
     if ( rc )
         goto out;
 
-    if ( xc_logdirty_control(
-             xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
-             HYPERCALL_BUFFER(dirty_bitmap), ctx->save.p2m_size,
-             XEN_DOMCTL_SHADOW_LOGDIRTY_FINAL, &stats) !=
-         ctx->save.p2m_size )
+    ret = xc_logdirty_control(
+              xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
+              HYPERCALL_BUFFER(dirty_bitmap), ctx->save.p2m_alloc_size,
+              XEN_DOMCTL_SHADOW_LOGDIRTY_FINAL, &stats);
+    if ( ret < 0 )
     {
         PERROR("Failed to retrieve logdirty bitmap");
         rc = -1;
         goto out;
     }
+    if ( ret > ctx->save.p2m_alloc_size )
+    {
+        ERROR("Guest has grown its p2m too much");
+        rc = -1;
+        goto out;
+    }
 
     if ( ctx->save.live )
     {
@@ -666,7 +688,8 @@ static int suspend_and_send_dirty(struct
         xc_set_progress_prefix(xch, "Checkpointed save");
 
     if ( ctx->save.deferred_pages )
-        bitmap_or(dirty_bitmap, ctx->save.deferred_pages, ctx->save.p2m_size);
+        bitmap_or(dirty_bitmap, ctx->save.deferred_pages, ctx->save.p2m_alloc_size);
+    ctx->save.p2m_used_size = MAX(ret, ctx->save.used_deferred_pages);
 
     if ( !ctx->save.live && ctx->stream_type == XC_STREAM_COLO )
     {
@@ -684,8 +707,9 @@ static int suspend_and_send_dirty(struct
         goto out;
 
     if ( ctx->save.deferred_pages )
-        bitmap_clear(ctx->save.deferred_pages, ctx->save.p2m_size);
+        bitmap_clear(ctx->save.deferred_pages, ctx->save.p2m_alloc_size);
     ctx->save.nr_deferred_pages = 0;
+    ctx->save.used_deferred_pages = 0;
 
  out:
     xc_set_progress_prefix(xch, NULL);
@@ -698,6 +722,7 @@ static int verify_frames(struct xc_sr_co
     xc_interface *xch = ctx->xch;
     xc_shadow_op_stats_t stats;
     int rc;
+    long long ret;
     struct xc_sr_record rec = { .type = REC_TYPE_VERIFY };
 
     DPRINTF("Enabling verify mode");
@@ -711,15 +736,18 @@ static int verify_frames(struct xc_sr_co
     if ( rc )
         goto out;
 
-    if ( xc_logdirty_control(
-             xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_PEEK,
-             &ctx->save.dirty_bitmap_hbuf, ctx->save.p2m_size,
-             0, &stats) != ctx->save.p2m_size )
+    ret = xc_logdirty_control(
+              xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_PEEK,
+              &ctx->save.dirty_bitmap_hbuf, ctx->save.p2m_alloc_size,
+              0, &stats);
+    if ( ret < 0 )
     {
         PERROR("Failed to retrieve logdirty bitmap");
         rc = -1;
         goto out;
     }
+    if ( ret > ctx->save.p2m_alloc_size )
+        IPRINTF("Guest has grown its p2m too much");
 
     DPRINTF("  Further stats: faults %u, dirty %u",
             stats.fault_count, stats.dirty_count);
@@ -800,13 +828,14 @@ static int setup(struct xc_sr_context *c
 
     if ( ctx->save.live || ctx->stream_type != XC_STREAM_PLAIN )
     {
+        unsigned long pages = NRPAGES(bitmap_size(ctx->save.p2m_size));
         DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap,
                                         &ctx->save.dirty_bitmap_hbuf);
 
         dirty_bitmap =
-            xc_hypercall_buffer_alloc_pages(
-                xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size)));
-        ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size);
+            xc_hypercall_buffer_alloc_pages(xch, dirty_bitmap, pages);
+        ctx->save.p2m_alloc_size = pages << (PAGE_SHIFT + 3);
+        ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_alloc_size);
 
         if ( !dirty_bitmap || !ctx->save.deferred_pages )
             goto enomem;
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -400,6 +400,20 @@ bool paging_mfn_is_dirty(const struct do
 }
 #endif
 
+/*
+ * This is used to provide a rough (upper) estimate to the caller of how many
+ * more pages we might have data for.
+ */
+static unsigned int last_valid_entry(const mfn_t *tbl, unsigned int idx) {
+    unsigned int last = LOGDIRTY_NODE_ENTRIES;
+
+    for ( ; idx < LOGDIRTY_NODE_ENTRIES; ++idx )
+        if ( !mfn_eq(tbl[idx], INVALID_MFN) )
+            last = idx;
+
+    return last;
+}
+
 /* Read a domain's log-dirty bitmap and stats.  If the operation is a CLEAN,
  * clear the bitmap and stats as well. */
 static int paging_log_dirty_op(struct domain *d,
@@ -407,10 +421,10 @@ static int paging_log_dirty_op(struct do
                                bool_t resuming)
 {
     int rv = 0, clean = 0, peek = 1;
-    unsigned long pages = 0;
+    unsigned long pages = 0, extra = 0;
     mfn_t *l4 = NULL, *l3 = NULL, *l2 = NULL;
     unsigned long *l1 = NULL;
-    int i4, i3, i2;
+    unsigned int i4, i3, i2;
 
     if ( !resuming )
     {
@@ -482,6 +496,15 @@ static int paging_log_dirty_op(struct do
               map_domain_page(l4[i4]) : NULL);
         for ( ; (pages < sc->pages) && (i3 < LOGDIRTY_NODE_ENTRIES); i3++ )
         {
+            unsigned long max_gfn = domain_get_maximum_gpfn(d);
+
+            if ( (i4 * LOGDIRTY_NODE_ENTRIES + i3) *
+                 LOGDIRTY_NODE_ENTRIES * PAGE_SIZE * 8 > max_gfn )
+            {
+                i4 = LOGDIRTY_NODE_ENTRIES;
+                break;
+            }
+
             l2 = ((l3 && !mfn_eq(l3[i3], INVALID_MFN)) ?
                   map_domain_page(l3[i3]) : NULL);
             for ( i2 = 0;
@@ -505,18 +528,36 @@ static int paging_log_dirty_op(struct do
                         goto out;
                     }
                 }
+
                 pages += bytes << 3;
+
                 if ( l1 )
                 {
+                    if ( unlikely(pages >= sc->pages) )
+                        extra = (PAGE_SIZE - bytes) << 3;
+
                     if ( clean )
                         clear_page(l1);
                     unmap_domain_page(l1);
                 }
             }
+
             if ( l2 )
+            {
+                if ( unlikely(pages >= sc->pages) )
+                {
+                    i2 = last_valid_entry(l2, i2);
+                    if ( i2 < LOGDIRTY_NODE_ENTRIES )
+                        extra = ((i4 * LOGDIRTY_NODE_ENTRIES + i3) *
+                                 LOGDIRTY_NODE_ENTRIES + i2 + 1) *
+                                PAGE_SIZE * 8;
+                }
+
                 unmap_domain_page(l2);
+            }
 
-            if ( i3 < LOGDIRTY_NODE_ENTRIES - 1 && hypercall_preempt_check() )
+            if ( pages < sc->pages && i3 < LOGDIRTY_NODE_ENTRIES - 1 &&
+                 hypercall_preempt_check() )
             {
                 d->arch.paging.preempt.log_dirty.i4 = i4;
                 d->arch.paging.preempt.log_dirty.i3 = i3 + 1;
@@ -524,10 +565,21 @@ static int paging_log_dirty_op(struct do
                 break;
             }
         }
+
         if ( l3 )
+        {
+            if ( !rv && unlikely(pages >= sc->pages) )
+            {
+                i3 = last_valid_entry(l3, i3);
+                if ( i3 < LOGDIRTY_NODE_ENTRIES )
+                    extra = (i4 * LOGDIRTY_NODE_ENTRIES + i3 + 1) *
+                            LOGDIRTY_NODE_ENTRIES * PAGE_SIZE * 8;
+            }
+
             unmap_domain_page(l3);
+        }
 
-        if ( !rv && i4 < LOGDIRTY_NODE_ENTRIES - 1 &&
+        if ( !rv && pages < sc->pages && i4 < LOGDIRTY_NODE_ENTRIES - 1 &&
              hypercall_preempt_check() )
         {
             d->arch.paging.preempt.log_dirty.i4 = i4 + 1;
@@ -537,8 +589,19 @@ static int paging_log_dirty_op(struct do
         if ( rv )
             break;
     }
+
     if ( l4 )
+    {
+        if ( !rv && unlikely(pages >= sc->pages) )
+        {
+            i4 = last_valid_entry(l4, i4);
+            if ( i4 < LOGDIRTY_NODE_ENTRIES )
+                extra = (i4 + 1) * LOGDIRTY_NODE_ENTRIES *
+                        LOGDIRTY_NODE_ENTRIES * PAGE_SIZE * 8;
+        }
+
         unmap_domain_page(l4);
+    }
 
     if ( !rv )
     {
@@ -565,8 +628,8 @@ static int paging_log_dirty_op(struct do
         return rv;
     }
 
-    if ( pages < sc->pages )
-        sc->pages = pages;
+    sc->pages = min(pages + extra, domain_get_maximum_gpfn(d) + 1);
+
     if ( clean )
     {
         /* We need to further call clean_dirty_bitmap() functions of specific
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -272,7 +272,8 @@ struct xen_domctl_shadow_op {
 
     /* OP_PEEK / OP_CLEAN */
     XEN_GUEST_HANDLE_64(uint8) dirty_bitmap;
-    uint64_aligned_t pages; /* Size of buffer. Updated with actual size. */
+    uint64_aligned_t pages; /* Size of buffer. Updated with actual (or
+                               potentially needed) size. */
     struct xen_domctl_shadow_op_stats stats;
 };
 



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:33:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:33:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313737.531447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIW2-0003mw-9r; Tue, 26 Apr 2022 10:33:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313737.531447; Tue, 26 Apr 2022 10:33:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIW2-0003mp-63; Tue, 26 Apr 2022 10:33:54 +0000
Received: by outflank-mailman (input) for mailman id 313737;
 Tue, 26 Apr 2022 10:33:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njIW1-0003mh-Kk
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:33:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5dc1518c-c54c-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:33:52 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-8ANpQQuqNriiBUF16WuF7Q-1; Tue, 26 Apr 2022 12:33:50 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB7785.eurprd04.prod.outlook.com (2603:10a6:10:1e7::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 10:33:47 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:33:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5dc1518c-c54c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650969232;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=CwmrpSe4Pw1W+yGYAm1bkOFDuNoRZOMh4sYLYOv9c1Q=;
	b=lLuAvcXYWAdHU+zWT8oo7/ANshZobtR9JZFV8RcvEst1bqMbkMZo+H9lbSVHltbtShOlGj
	tMX+DhnE4vFyOAfxHm/D/7JTgdFQVs/dZeTqluSfL3eo8QY3zog82zZXQWFzrJOaVzaZf9
	x4EwLN11kN3CuB+VmiDsgpQzdVX4JEQ=
X-MC-Unique: 8ANpQQuqNriiBUF16WuF7Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iEZswY+zDzt6D+JLGSv8NcbdQ0m40KbmEURIuHq+kl/c578jd5/zAA5OL8Ey6UIi1b/rQX8/7Y0tnZwDd79awy+BdRY5pXID/F5rUR+j1CZv5oFdPH9QQqA0acZu0B4nWT/D9c8fNjMygCOmRmPUrorN0rxrrSkez3S6Y3zDazguwvVoXPy50FEIqH9HN9rNI1wW7vfSlLvOxgemqI7my8RqmWfSrqcqO2bsPXwIbmnPbmVf6mr5RNKf64vTLkXgL8BbJt6qdAAIBBpQRov9aNdoo+n+ccjm1bSuQzaPOwAoccGKV1rzmS2ltYqBmMkfRwsCHF9bD08ehIuR4qwZlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CwmrpSe4Pw1W+yGYAm1bkOFDuNoRZOMh4sYLYOv9c1Q=;
 b=M5utKc4lyUOZmypDSJJE/T5uklOqMy83J07QS+hE+nPeloMaKIR46qM+eMNpYTZHH/5gLfPEVMuZpRLfJMrf3HUFu+WIFP9bh1ntelk9E212knqovkmrq1qw/ReMKSvfqzrrLxxNHH5wY89NGG6P1unVS9fiiAFbsScxYkvqntm4lQzZeWG3W8r/wxwZ++KdEmPdXEbC1AknNZEmhxmkZSNwaTuFmA7XZIbLbpzZZKUjzZq4F1XVrF4wjRo3hoKVwRvQOhx7cvO3cDFPelf5R0LXBs1NQIOw7s1f1+0o3nuuybl3QiQWjipcf/lbHVYSNRfEEvZQtz0OUJ+LSr8Yuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <acd0dfae-b045-8505-3f6c-30ce72653660@suse.com>
Date: Tue, 26 Apr 2022 12:33:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v1.1] evtchn: add early-out to evtchn_move_pirqs()
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0005.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 162d85c6-39db-4f04-9ecf-08da27703f1c
X-MS-TrafficTypeDiagnostic: DBBPR04MB7785:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB77852EC061845C3E723EA89FB3FB9@DBBPR04MB7785.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oZPVwWgkOTXAvy1A62TpepsXeK5cMP4DUNVUhQYwmmGDOneu8I9Qt2lo0Zp4otZ9xvjPtdY3vaM7b8AWQs8cx9o0fWknJRsWlFQThsKv6mkmvDmZJ34XwU9puazqNo+Pz7lwF/iT8EH4hVBRJnhu2ol589xsAdCLa8YfmrAmQcVz6RQIFqXSdbFoLcvZ9KNkKrwjDwN1gW+i7Esqqx7QSLWYGy0nbDs+S8c+NyYV8vcX+hfnA4DL6Ontf7jO0Za6aQCw6FU8n3zYhcWhtZxb5AEEii+NDIFZdl9yW4Str3Q3eifE0y2QbEFrPIlzzwotIzU/jPDJ33rwnxmXdMKBvUkfmMyPfPbhoW/pVbaxBPxLudqXX3KT1E74k6wVXvbdJbgz28PlJH5L5pbidrKWteheqbUf7DcxG/2xA4557mfZjJ/vLZBi/jWT3k1Lgw+9oSr8O+czp3MVVgovkdya3R6JYnm48Xx4UbRu2Ldbzu51mfWwbK5fiZa6m0NrnWsE0pdRk6LahD3Tt1YdkHig8tuA16V1kMl41pgIpR7Np64BaDxmnSNREbn5kdvgZ0SXOxPDvIYfT40ZWstJZn0WuVpV0A/TEgCytrgfDB1802a7qW3LMMXwFIalmaY8exMiKvYPBVOSNzxMT6LyU22Tb5T3MpgiiLYqG4TnEpxvZ/XQJTzh3IO4xYPMY1KtZDilpcSCmALN/tOCwBSeH/9xR8B8iPQVqqHP+F8KGoIIo/7M8OPIvnHVW94JPye/hQAK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(66476007)(86362001)(316002)(2616005)(66946007)(107886003)(8676002)(5660300002)(38100700002)(83380400001)(2906002)(66556008)(6512007)(6506007)(4326008)(8936002)(26005)(186003)(54906003)(6916009)(508600001)(6486002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MW9jMUZRZkhObGRWNW90NnBsTEJENnZNZ0dHbm5hR2UyVm1kMFZtcVRlY1pv?=
 =?utf-8?B?d1FBZ3YwNHcxeGx0UFdEQ1ZidktkanpoODNlYW9LR2lDVVNSMGdkVWNwVW5K?=
 =?utf-8?B?V3VacHk4WWtOMWFDTmhLeUtjdzNFVjhyTWZnTmJDRmNHbDFvWG9FY2NkSFFq?=
 =?utf-8?B?aDZicnRDUUhYN1grU1ZidE94b25IUWNXS0MrSDFEZGdjSS9tTnU3WEVBVko2?=
 =?utf-8?B?QzVRcFU1Nk5XUU9ZUExjRGRvNmxXSG4wVmMrMmNXMGF5UktLTWdxK2F0UENt?=
 =?utf-8?B?UFg0aVdDWU8wZjZJcUd3MlAybWZ1L2FmZ3JiSjM5dTVXN1p4dlQzdWZTTE1W?=
 =?utf-8?B?UGFZZzEwcVZYeXJyUHV2K3htQmNmYllJN2FYZFQzNEVCZ0lOYlBDU3pTekpH?=
 =?utf-8?B?TVNqemJlazJiV3VHQjRzWElreEJrR3lXTkxxQmZTcFl3Z2VsYWVpaWRiTmRy?=
 =?utf-8?B?cXRHMUNXbE9aWEZNakJieVFrZ1oySjRuVCtBR0JKa29CaW9kdGFlNDJFNVRI?=
 =?utf-8?B?VXJCYXhJS3ZCS01qd28xNTBocUdlclluWWxlWjduV2pnYmo3L3BhK1VMYTVZ?=
 =?utf-8?B?cTBKYXc4ZEJNOWJFdnltMnM4REh4dUtaYnR0UnRRdzhUeXREZTVQTC9WUklX?=
 =?utf-8?B?KzZZVkt2SDNNMHRmTCtZRTg5eC9yejBoSXdxQVhISlpybW53NFQyRDZWV3Rl?=
 =?utf-8?B?MlB1TGRwR0V3VzBCYTFyMnNsaUlyZm56THBxUzkvOXhPMmEzcnUrcklWWmcw?=
 =?utf-8?B?dmZ4NjVVa1lmNVorTWsyZEVZRC9GQ1dTYzgwaGdld0R6WFVLVEduMVB4MjNR?=
 =?utf-8?B?dVlhVzRhWTVNSGJ2TWw5R3cyUGxGWWkzRHNzNlVQYkEvSkRwZjd0SGVjNkQ2?=
 =?utf-8?B?ZElvd3MveGw2Z1pEL2VvR2ErNVdNZ0tFSFowRVRYa2h2eUdMM0tBazVZaXpp?=
 =?utf-8?B?c3ZBVERaQkpPMzgvSkhJK3FJci9yMlBSd0tNdkhKbUY4RUZ5M01SU0hLUERa?=
 =?utf-8?B?VkE5QnJHQkJrS1ozVHlwZTZUWjNnaVZwcC9BUnk5NU9Pa2pLdFNhYjd1RnVj?=
 =?utf-8?B?eDllMDl6OFdXZEFoS0s1SE53T1JRbDY0VVpMUmU1L3ZJc0M2V0pNQldDYy80?=
 =?utf-8?B?MndjbWRuc1ZrYm13R1dSeEE3WXRGT1RTdGV1U2NZK1NLcUU5Nm1mem1xL1lz?=
 =?utf-8?B?ajd3a1c3TU5UbG1MVXEzZjlIOXZSS1ZlTUtPdytiMnM4MnBhQW9SWk1iandt?=
 =?utf-8?B?TlZBdVUya09oVHBXS1pxbGVPVENFc0JDMjhIeHRBUlhiNi9yMGRIQjc2YWdh?=
 =?utf-8?B?VDZXMDNFM012UlE2bHdOUmQ4VmRkNmlXMnBqNUY3VUJWK3k5Z2Q2TjhhdmRQ?=
 =?utf-8?B?M0dXeEVzZ2czMUw2N1lSVzRiZytqT0UyUU9mTjZoNEZKSGdEU01VdzgzSlJJ?=
 =?utf-8?B?RjJVb0xPUXNLUUpKOUhUS1BOL1FQekJzNVBnWU5Dajh6WmdiYUVsaithTm91?=
 =?utf-8?B?WmFaZ2JUWkJ3R0RsVnVzeE5mci8xS2x2Rzc4RjB3MGVlaEsyUWZ1ZUxRWUha?=
 =?utf-8?B?cExoRy9xdW5pVW5STlRybWhXSm1aVCtCSCtEZ0tFa3piTTdvdXRXMDhHUkcv?=
 =?utf-8?B?RHFQSTBVS0hOZGRkMHpYOFBHbWhrRG5HRkNCQldibVZ3UHNiS2UwMWtvbEpY?=
 =?utf-8?B?ajFUMzRUcmVqRkdmWkZ2T0FETUJyNnkvUzE2UXpjWG9SQ3FZVnF4ekhVK0FZ?=
 =?utf-8?B?ZHJEL2dTbUZaQjdGTU5SZUVPM3NqZHUzWndEZkNKRWFpemZOdWFnTVlYQTNU?=
 =?utf-8?B?RlN4U0dkTjQxK01rcW5OS0pxaGxJcjFMZStReGxsTXJKQTMxMldENXBrNmZB?=
 =?utf-8?B?d0RaT3BDZW5ZK2Nmb2VWLzBhb05uTi9JV2lYZ3hVcXRQSXhLaE1xOEdTNm95?=
 =?utf-8?B?RERWenp6aHVFYkdVaXlPd3BDblBpd243TkVZM0dOVUtIRVRoOXMwRUFMNEFK?=
 =?utf-8?B?QWwxNG9SWlFnaWtpanM4VjRkb2JneC96a0lSdW85UTQxMUJFV2dMSlhRNU1k?=
 =?utf-8?B?THBaQ2dSSmhveDlpZWVBVmtGRjZ3Q0J2T0J1VmN0by9ZYzZWcVJKaXNPWE82?=
 =?utf-8?B?UWZFa3FNNmNSZ1dTUzBJN1ZXOTJyelJiRHFyU0VaZXpIQmRNZEJEdks2MW9V?=
 =?utf-8?B?WnZ3V3d6Mzd5cTJ6N1JmTWNPcXBuUE1HeDc5MkdtN3NjZUxKQ2xBcEUrN05r?=
 =?utf-8?B?aUhRTjRldHIzNVR4Z0dQS0N1STNQbjcyb0h4Rkp4NktRYk1leUxPeVBXOURX?=
 =?utf-8?B?dlJBYzhraytHcVhFQy9pSXVYd2NPbGx3aURDSS96NXcyL2VpU09FUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 162d85c6-39db-4f04-9ecf-08da27703f1c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:33:47.6100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iaEI3f+nRMFE76BclNJOQBcOR/zzJvGFWSctUv57eORlJeFgriyuEnTQ5EYLjWqTd8GXHNU3FAAF6FEElNfH0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7785

See the code comment. The higher the rate of vCPU-s migrating across
pCPU-s, the less useful this attempted optimization actually is. With
credit2 the migration rate looks to be unduly high even on mostly idle
systems, and hence on large systems lock contention here isn't very
difficult to observe (as was the case for a failed 4.12 osstest flight).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Luca Fancellu <luca.fancellu@arm.com>

--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
     unsigned int port;
     struct evtchn *chn;
 
+    /*
+     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
+     * vCPU-s they're to be delivered to run on. In order to limit lock
+     * contention, check for an empty list prior to acquiring the lock. In the
+     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
+     * until the vCPU is migrated (again) to another pCPU.
+     */
+    if ( !v->pirq_evtchn_head )
+        return;
+
     spin_lock(&d->event_lock);
     for ( port = v->pirq_evtchn_head; port; port = chn->u.pirq.next_port )
     {



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:33:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:33:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313738.531457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIW5-00043q-Hn; Tue, 26 Apr 2022 10:33:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313738.531457; Tue, 26 Apr 2022 10:33:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIW5-00043i-ET; Tue, 26 Apr 2022 10:33:57 +0000
Received: by outflank-mailman (input) for mailman id 313738;
 Tue, 26 Apr 2022 10:33:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIW4-00043J-Il; Tue, 26 Apr 2022 10:33:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIW4-000202-GS; Tue, 26 Apr 2022 10:33:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIW4-0002Dm-1W; Tue, 26 Apr 2022 10:33:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njIW4-0001aL-13; Tue, 26 Apr 2022 10:33:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=O7p7uT5IGKJ/dcBi8UuGVpSdhTm2sTpe0NXxMrk3ePA=; b=S/Eo7DfMNT0x2zDY7JZQWeq3Yd
	2sCSZF2UvNx05wwY2gxcH8B1f9bDSjSBcZQ+sAlJRXZVtf1tNaIUcJQu/ANWSs2Ttr2i/HmO3sduI
	TVM/cG4GBMm1zuFS1sWN2Vnarmq37QeMY+hx9DmK+0PB7cpzdkbRPmAWIA05ypXzHG2M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169725-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169725: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=a1755db71e34df016ffc10aa0727360aae2c6036
X-Osstest-Versions-That:
    qemuu=c49abc8406086398de4062ce9b58f67a23b0ca1f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 10:33:56 +0000

flight 169725 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169725/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169717

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169717
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169717
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169717
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169717
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169717
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169717
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169717
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169717
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                a1755db71e34df016ffc10aa0727360aae2c6036
baseline version:
 qemuu                c49abc8406086398de4062ce9b58f67a23b0ca1f

Last test of basis   169717  2022-04-25 21:07:09 Z    0 days
Testing same since   169725  2022-04-26 02:47:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Dr. David Alan Gilbert" <dgilbert@redhat.com>
  Denis V. Lunev <den@openvz.org>
  Eric Blake <eblake@redhat.com>
  Hanna Reitz <hreitz@redhat.com>
  John Snow <jsnow@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   c49abc8406..a1755db71e  a1755db71e34df016ffc10aa0727360aae2c6036 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:38:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:38:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313752.531468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIa8-00057d-87; Tue, 26 Apr 2022 10:38:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313752.531468; Tue, 26 Apr 2022 10:38:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIa8-00057W-4z; Tue, 26 Apr 2022 10:38:08 +0000
Received: by outflank-mailman (input) for mailman id 313752;
 Tue, 26 Apr 2022 10:38:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BNuI=VE=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1njIa6-00057Q-Qz
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:38:06 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20603.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::603])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f48a06d0-c54c-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 12:38:05 +0200 (CEST)
Received: from AS8PR04CA0170.eurprd04.prod.outlook.com (2603:10a6:20b:331::25)
 by AM7PR08MB5350.eurprd08.prod.outlook.com (2603:10a6:20b:101::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr
 2022 10:38:02 +0000
Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:331:cafe::be) by AS8PR04CA0170.outlook.office365.com
 (2603:10a6:20b:331::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend
 Transport; Tue, 26 Apr 2022 10:38:02 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 10:38:01 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Tue, 26 Apr 2022 10:38:01 +0000
Received: from ddb4c6f02d13.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CC082240-04B6-4CEF-9852-2CC1FCF65259.1; 
 Tue, 26 Apr 2022 10:37:54 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ddb4c6f02d13.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 10:37:54 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by DBBPR08MB4490.eurprd08.prod.outlook.com (2603:10a6:10:c5::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 10:37:52 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:37:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f48a06d0-c54c-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=SZTIuKZKyyV/DEcTdQtLzpMWS0tXCxML5g6aeQnQa8qiHwDuynIzQsu5pYtbzPKRJXkRSpooDpmdy672eVvzlf5BX0xR0AIUuUH1PgN/gQ8aQnUjNH6fOsj0Lg0SVtomuYxe8i231Bf0vqcYYbt43SWNTs7FpDcZy038roHc9c7lvUS7PE+i0tmJzTfRsmhEPxd9bWOIPy2VaAv7qHdddnAMjLp/fQ1TcQmt0lzIrHrnEJpQtYKbSGSCtHbVkbPIwmlyfnEiYFRa4PgbZgvHH3bHhd1TAY8wf7+kXJTD0DrRyob9dNqjkVQfm+YENhb6mb31LxWtmwxMR3BBU+oYhg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z1FOdQPbwu+U7H+tA7xv7lJ1j2B+Y3tQm4KthetOVbg=;
 b=XQP4++EmpR63ScxCUSlc2yLlyxD/jEX5kNddTI4b1rJFmyTfHxfrNmB6HmlUCX/pu2HnRpbYqKXQ5LGp+n6PUipxnOAunmLX8BjaGeRpYpHKgdpOa5NOjDzd1nsf61kIGh+qMrJUTwHmR1O8hiC0WAnjP08LI7fvS0LnqkHyRroq5+vUgZqQluGUir5PoRJA8oOUk4UQQQ9dPKzCbFFojom9sDmkCoelqYuxXij9896qjwjX/OtzzXvsnGNriJsYzM7lzi29aDhjcmrg1uP91Ffs567p/BdydO0FNJlUuBlxBP8GtDCf/ttIM0Gu6Ocjnqsy496Ul+GXxZ4xs+7eGQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z1FOdQPbwu+U7H+tA7xv7lJ1j2B+Y3tQm4KthetOVbg=;
 b=cmTRs+vu+YYSPZli/gBK+zLbsRe9VMC7AZ4eZ6HJgzYJhOdKubjF0DfLbbgYlunACx0U0iIkdtk56hKWDwrJ/Y1GSdByX8fYhbSDiKJBBYnpt51DgDOlXirtG/kKOUjOgxMTrkvtAn4ckRE7r6LH0RsXCC6FAaPIOcr32HDpm20=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ff616086da003c50
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=InSCoix0qvmQbZO9tr4sojLYqyoQWWy9yvdbqUmu7Ib8gtJ2QdW5GmFciePSEsXKVRhUSVGt553YgkPFgL2hGzAe66K2Sb1tiBTs2r5HvptZjo4eWTK6fvbzZ7dFeQEblJqImZUHqbKgracxKD9sfs0/z6AaAkcTl4YAyhNfn/DVZzZ/InKzALIe5fI9m9eC1wPvqrFHbdPZJfpNwfBkN1DY8jNFKlagONl6KzSY7gNYAxrcFQBq89pRcJ3Iv2wJlVEThwUHWKmEreAS2QeaO7K/fZOies1u44ROdNLF0q4CGoaMYP9TXQZZRPYZ8vpWTdc0HT/foyuLVFPfnKyUtA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z1FOdQPbwu+U7H+tA7xv7lJ1j2B+Y3tQm4KthetOVbg=;
 b=JHSRFFkOQCX+5a54aBHV4NYUFMx+Cj6HjHg0jta9sFay7fp03jRz20WXc0RQzMfBQVbQ232WmdqIyI4Jy0+CWiwro36MORmGg1elSya0hWUV8JjXqFo5YgQjimZj2iqJrmPmQInnoOksmsu1PTUod1VPGURiQVDJ1VUArfrPZSpzAqznoNfZ/JxkNcwwSUF8LOd+5cXR9xK+9T4ohsRaKkIN/oz6tl2xFERGI9OONw7ZiNKI/gOhtTUXhlkjQv39bxal844hU47NsPLqUGoUrCF5IaUSGoWugFDgXxOiriUyT5qMcM/Lyp1e1E0TOyoMv+LqN6w8806/nuDgk+RTPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z1FOdQPbwu+U7H+tA7xv7lJ1j2B+Y3tQm4KthetOVbg=;
 b=cmTRs+vu+YYSPZli/gBK+zLbsRe9VMC7AZ4eZ6HJgzYJhOdKubjF0DfLbbgYlunACx0U0iIkdtk56hKWDwrJ/Y1GSdByX8fYhbSDiKJBBYnpt51DgDOlXirtG/kKOUjOgxMTrkvtAn4ckRE7r6LH0RsXCC6FAaPIOcr32HDpm20=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <ed949bf4-ba9e-9ad7-b2fe-c63526ca42e5@arm.com>
Date: Tue, 26 Apr 2022 18:37:44 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from
 x86 to common
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-3-wei.chen@arm.com>
 <3e5b9708-7732-a56c-f2e8-d5d39fd2093e@suse.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <3e5b9708-7732-a56c-f2e8-d5d39fd2093e@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SGBP274CA0018.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::30)
 To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: f1e5961a-2bbb-467b-387c-08da2770d6c0
X-MS-TrafficTypeDiagnostic:
	DBBPR08MB4490:EE_|VE1EUR03FT051:EE_|AM7PR08MB5350:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR08MB535027C500C86D63D97F69469EFB9@AM7PR08MB5350.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 lnmyRRHeWwwnmioaQD7cF6aGYEs8PDaPVI7shwOykjgQ/K01+skqQ7E+5GOB0BpQg2e/8OZJ7Iy5T4U1CIkk3yGkX+Mu0xnat+tZaw57QE6c3gQPTITinOe/G6sgRsQ+RXVKxulCJjTPTqY1UMFOQfNsOwX0CZUrY9bVrXqk4sMcUik8JEqsYASvPGJPNmfcSs7i7tXkPjdeywHOIm3JwIOtjSayqIeoiy+9IxAz63JpXTf4R9KZIr/Cuk29igq4n8x9g4fzxqS9BqMvNQqgQcm7653PqsXsU8gmODR39n/VdsQ9AUDJTxXx/lFpa1qdWNjZwXli6qzePwcygZ1ksf0ldK11WGXTHTLSS2G1otGyDSoo9TubCecx+/zTFmHwIwlQ9yjxgK6i0cHiI/95Df7ETI9lFYN7taV3JxKvMilOhUZWX4M/DpCFLYqP9d54f5wvVygPwMI/Gh1kdTeLfkQeWrJhNEMxyo+BM9rkD2UfOADHbnJukkao8VOcbyxJ+yswProw6XrU8E7Ydh/e7kBr+DNTmjw723ShD6WaONdVmp0lJsua158B8pIcM/OGQ9jMX1Y6e9o6EbbVXEGQiwXgMzKwi5SBi2btrQ0F6hebwV3yAv/qXudyxyhmrC9drwkEx8Xe6dyRNLZSYrcV3Ssx9QLC7/9Il2iIg+yKLw8w2BmPSKWobAkyAE4WwNJmkabGwANaIRxiyOvPQHyAKt0CB1foull8X0LLyTAi1UA=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(508600001)(31686004)(2906002)(8676002)(6486002)(66476007)(4326008)(53546011)(2616005)(186003)(83380400001)(38100700002)(6506007)(86362001)(6666004)(8936002)(66946007)(26005)(6916009)(31696002)(66556008)(316002)(36756003)(54906003)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4490
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f0fce29e-0c41-4f8a-a4b0-08da2770d09a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NDJISO/Knfh7+65bWUE3A5Wx/SXdswB1lfbCVYQj8vMufs+1o1uBF8C9322zPgfr1FKL8jysx21gFoxZ8peTNqeHaPmZ4N2kJoMfjbDlQW7iJD6IHmjFX2R54AMT98nGl6vIsj+Ps8yyEckM8cYUpnadKvs+XZX8f/Nggy1G/o8c6etxh/fWEvLB0MjuOCsdDOl0txDOg1fZ3eX41S87qru/NKHn24OMfU71THJBIsgCLYIVsscgJ+toLe8UcEQgLAkG6WjgbnNQd/rbSInhu2A2ITomZYXLwbd0GdkkSQ3D/08kcj4Wxe11dJeNF1m8iC2lguMDsgbPOUQmrWJ4CsJQS8cScEV97PT63lWmB6Wiji4bNnHRMxLOHDKRaGeKGTjvreGHsAdpop3ElNCxUHIu0w2/IngupJD1Ep05jk6NMHCUqtaQTCwoIciVNB7ByhP42LYp8KMjeWY9BD0Y9iNO10zMNaEfjBIC4m0ta/XcAsNTUXGYt6+8dJHIIZ7y824G6E8LUbW4ecHIa8oDx444YrwZxEV2iZ2cX/wacpMrOKVeV0Kylwct+Tp6b3V9lBdcev2reb08h71pUbiVfCxLnBnrpuLaQvcnx2qX+h6frHTMXfMK0BOv9bLeWCmk43x/5wl9tOkJXYzDqDfSgVbr9o6cQbnjSs/39ULbN1mZzrFbCMjahoJLAYRpu+zbTENVTQQnXxOZL80TCL6FBg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(36756003)(6486002)(6862004)(316002)(70206006)(2616005)(6506007)(356005)(53546011)(26005)(8676002)(2906002)(508600001)(82310400005)(54906003)(6512007)(81166007)(5660300002)(4326008)(36860700001)(70586007)(86362001)(31696002)(8936002)(6666004)(47076005)(336012)(186003)(83380400001)(40460700003)(31686004)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:38:01.7994
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f1e5961a-2bbb-467b-387c-08da2770d6c0
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5350

Hi Jan,

On 2022/4/26 16:53, Jan Beulich wrote:
> On 18.04.2022 11:07, Wei Chen wrote:
>> diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub-x86.c
>> similarity index 71%
>> rename from xen/arch/x86/efi/stub.c
>> rename to xen/arch/x86/efi/stub-x86.c
>> index 9984932626..2cd5c8d4dc 100644
>> --- a/xen/arch/x86/efi/stub.c
>> +++ b/xen/arch/x86/efi/stub-x86.c
> 
> I'm not happy to see a file named *x86*.[ch] under x86/. I think the
> x86 file wants to simply include the common one (and the symlinking
> be suppressed when a real file already exists). Naming the common
> file stub-common.c wouldn't help, as a similar anomaly would result.
> 

How about using stub-arch.c to indicate this stub file only contains
the arch specific contents? However, we cannot predict what link files 
will be created in this directory in the future. If someone needs to
create a stub-arch.c link file in the future, can we solve it at that
time?  Or do you have any suggestions?

>> --- /dev/null
>> +++ b/xen/common/efi/stub.c
>> @@ -0,0 +1,38 @@
>> +#include <xen/efi.h>
>> +#include <xen/errno.h>
>> +#include <xen/lib.h>
>> +
>> +bool efi_enabled(unsigned int feature)
>> +{
>> +    return false;
>> +}
>> +
>> +bool efi_rs_using_pgtables(void)
>> +{
>> +    return false;
>> +}
>> +
>> +unsigned long efi_get_time(void)
>> +{
>> +    BUG();
>> +    return 0;
>> +}
>> +
>> +void efi_halt_system(void) { }
>> +void efi_reset_system(bool warm) { }
>> +
>> +int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
>> +{
>> +    return -ENOSYS;
>> +}
>> +
>> +int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *)
>> +    __attribute__((__alias__("efi_get_info")));
> 
> I doubt you need this outside of x86.
> 
>> +int efi_runtime_call(struct xenpf_efi_runtime_call *op)
>> +{
>> +    return -ENOSYS;
>> +}
>> +
>> +int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *)
>> +    __attribute__((__alias__("efi_runtime_call")));
> 
> Same here.
> 

You're correct, I check the code, Arm doesn't need above two
compat functions. I will restore them to x86 specific file.

> Even for the non-compat variants the need is un-obvious: Are you
> intending to wire these up anywhere in Arm or common code? This
> of course is once again pointing out that such code movement would
> better be done when the new consumers actually appear, such that
> it's clear why the movement is done - for every individual item.
> 

Yes, but I didn't deliberately ignore your comment from the last
series. I also hesitated for a while when constructing this patch.
I felt that this independent work, maybe it would be better to use
an independent patch.
I will merge patch3 with it, indicating that this movement is to
share the EFI stub for Arm.

Thanks,
Wei Che

> Jan
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:42:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:42:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313758.531479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIeT-0006W1-Pw; Tue, 26 Apr 2022 10:42:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313758.531479; Tue, 26 Apr 2022 10:42:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIeT-0006Vu-N3; Tue, 26 Apr 2022 10:42:37 +0000
Received: by outflank-mailman (input) for mailman id 313758;
 Tue, 26 Apr 2022 10:42:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BNuI=VE=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1njIeS-0006Vm-LQ
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:42:36 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20600.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::600])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9568683f-c54d-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:42:35 +0200 (CEST)
Received: from AM6P192CA0050.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::27)
 by VI1PR0802MB2205.eurprd08.prod.outlook.com (2603:10a6:800:9d::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Tue, 26 Apr
 2022 10:42:31 +0000
Received: from AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:82:cafe::b) by AM6P192CA0050.outlook.office365.com
 (2603:10a6:209:82::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Tue, 26 Apr 2022 10:42:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT035.mail.protection.outlook.com (10.152.16.119) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 10:42:31 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Tue, 26 Apr 2022 10:42:31 +0000
Received: from a0d89235cae0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 88B32DFD-2546-4D97-9D78-87E720E2570D.1; 
 Tue, 26 Apr 2022 10:42:24 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a0d89235cae0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 10:42:24 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by VE1PR08MB5261.eurprd08.prod.outlook.com (2603:10a6:803:10d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.16; Tue, 26 Apr
 2022 10:42:23 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:42:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9568683f-c54d-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=RucakaD6zxeQsL+/ALY/nGZ2tuEUDf2kwPjWX19/T+COnxtAMe7ISXU8VnQ4hiTrHNUsE9T8io4r89rrf5UOHuD4OO9ryU2xgLwgL2rkpHVzz4eHDQ5VI48NmLpRd3CxbER1M0Pi9GqCzh49WtJJxbHX/evxyFc1AogbsiT1MSNN901KP5IqpmlFZ6RC4QJTiEGfNHbMlrGzmzkJAhtvzn3nsXP76IyFcMcVpIqR1pSsU50U6ycEQj8iu/TxukHaSgQ5yDol6XOc0Mgn3U0xia1maXrw+5dwnl6KUjQOd4MeAq0W5eaehSfO2DcSrBFNEI0MCO29CYZOAWgwUdXqAw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zOOZTuLcj0JpB7z4ygWsT6hFRft+aPwJKGfkraf1cM4=;
 b=hwE4vqH4pNa30Aabi3HUWVdz1YJpqeZHz7bY2tiuCkm6uXoLfx7BOb0w7bmsBdX82tB/uRC8GWpPp1R7wYj3bqzID0VsxUeVJ3hjpYzQ4m1iOcUlc+DhN+G6hRcCWSvGjVFhy0EL/s5xBh0V67fdtJVqLAm3xVRYKyQrswDJAivHcn8gKA6I/4efGBnDSG8aO1YHyPwIe2g2FrbWTCUwVCASnQp+RjL8ceTcn/doXFnD2BOywomO5KpSar9jzFgT8Z5z3xyTGPbYmo1LpHQjoQFeitUXl+H1ZROKOg9DQERQsox9uIVMKHrIpLCvYh/fapWaRSiIHNFGcSMeg4dTig==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zOOZTuLcj0JpB7z4ygWsT6hFRft+aPwJKGfkraf1cM4=;
 b=cEfvDZK0Mor/sASckSM7s2P3X+aUNcEzSmEmXS/GRQDhfAqTv1L7ZX8VqNrpdQwaG8tvdoswlko55cTxRX2Xt51ACwbTg9gRREdawo+bAJSRFT0SAoZJEdYIoHOkZ6ozuh7Mh2FzRGOSML3JC6II9ex0K50ubmV+lABRGUm8DlE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c8726107b3360404
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jGMI8j5NuRfCyKyG4b1dXXanr3pne4Xmx6G4InvMpwG4Mnix9JBtgOGcSbMBKHvb8R77R9Bqctwnnu3BQGzIrYBhf/4iTBmryFTneKcBniGVNOVV8jCWpIfe9AGli1hBmDs8DrjtvPNeSa/22pTBPp3JM9JznMVDOkRYGatu7A4AFv7T37XPV+2XCDwBQlMTturh295OCMm4uAXc1arKCcdY+hSHELbvgVN+KwSnNwMR8BogoX1Op5PrFhur5xTYqbyIbiq6zqVaI9N1NIwT8sRxJ83oTHky0GwDwT9T4bxCds7NVgmv7WbyUwdVrwlhuQJjB7aHd5WVrtOxH2sRpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zOOZTuLcj0JpB7z4ygWsT6hFRft+aPwJKGfkraf1cM4=;
 b=REy/3bKIAuOgn43QNXPkOL0ICOkBJQtMx5OgT51NkZrBrPDS04UHyCPh3KO4wkytAbpme+/T5qttA9wmD+i0u8qmafIa2EOQyT+no2bbZ7OWWTkFQf1Rj2aqdIcWeNYZi+ZKH/mGSQZdvIPWOwhjRgiZWukuWRoSjFvtVQhSq2XBoiZk+aE2to+HZUKOxkkw8AhJ1WMX/DWf36RBZsQIrb9bwuMMh1wAC+iGs0BnA2uMbPoHzPlkkK66ydtaiXNGgtNj0poS7oN4jcjtLneT15aKoEpBnrSefTC5VmqRSj6yHgUP+bOkUTXc+Z39K3WRF7rrOs+3o+2j/9iy5nHDNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zOOZTuLcj0JpB7z4ygWsT6hFRft+aPwJKGfkraf1cM4=;
 b=cEfvDZK0Mor/sASckSM7s2P3X+aUNcEzSmEmXS/GRQDhfAqTv1L7ZX8VqNrpdQwaG8tvdoswlko55cTxRX2Xt51ACwbTg9gRREdawo+bAJSRFT0SAoZJEdYIoHOkZ6ozuh7Mh2FzRGOSML3JC6II9ex0K50ubmV+lABRGUm8DlE=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <86c88329-ddca-a566-ddb9-e50917b8ba80@arm.com>
Date: Tue, 26 Apr 2022 18:42:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 09/10] xen/x86: use paddr_t for addresses in NUMA node
 structure
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-10-wei.chen@arm.com>
 <8a966300-e3a7-64db-b8dc-cb8386b2d11a@suse.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <8a966300-e3a7-64db-b8dc-cb8386b2d11a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SGXP274CA0013.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::25)
 To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 72477d30-4e93-45af-07cd-08da2771777a
X-MS-TrafficTypeDiagnostic:
	VE1PR08MB5261:EE_|AM5EUR03FT035:EE_|VI1PR0802MB2205:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB2205DFCDB51FBF34D5250B679EFB9@VI1PR0802MB2205.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Kr7MoyI4kBiSPp+7pVlmZXDXq2VE5B3BzQVmBiDCfWeMfLuCazlNtfo5bPVcqMNX4teuWsamDdnuRPvDKHOthwlcBDCZTUyaWeWZCOraYw3Y2ZYtFdR6L5cLRi/atGumkxYhLBSZMQrG2GDemLVbNFrOVADg4LJ1faA1lO0CvDM+YcJhWeZbQ5p/v3NOfrEssCy0nSx4MZndU/QIKvPT/6OiAzpma3YH6RT4U2J6o4pYGoNF6f3S1KaHqu8UyTE6UuVtg9AiqriMRZpK7BGdNdzF2EztpfseZ5ZyBCr5Y9X4300FGTh6AVG3c4YzaUUNRCgjh3rK8IIbmpKA0uxJeu5AVEey7Fa9HQVfvAGxXyBrYJ7bicBGMVM913UQOILFwl3dnYOzj3+2kP/d7A78oK3RZhZ9gXrfxF1H9RXrVOOKt+bzf5lPyQ9mvKZRGVxGOCkBfqFnx6nW5USI0CGWdZ8Qa0odj8+dIPrwpBSOj4GqOV8eu/+9SuTL9gzulMzo4/I+Jl4CwtRjSg9d9fqgSpFR1e613wnih2i9rODNOxSEZOMAln5YLmnMAwZE+Mk7KbOeBey8/y0vW6yNbUdHvJFQbrwkO7dOWFTXnLY1ROfqrkniFP9GRmMIb4nWnE+CiK8FiOOtIEC3Yz/jaRsaCYKwvFEGXSGasKWPyF5kDDWecrBMQbbQvwcwLkYotTKHL2gTeufvmdZw+0lND1pQDwCTXvLJGaoTfay3KTyh/qc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(8676002)(186003)(66476007)(4326008)(5660300002)(66946007)(36756003)(38100700002)(31696002)(6506007)(6666004)(26005)(6512007)(53546011)(316002)(6916009)(86362001)(54906003)(2616005)(6486002)(2906002)(31686004)(8936002)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5261
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9fdd53ac-0de3-4f8f-8da5-08da27717261
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aEfeMYcWurAXkGD0aaMtbG6UM+hgSSmX0Pt4Q/R2jx3QIaiImyJB4n0RPOHjgVOzDJNfUL2qBJv+fvisz+GKRPH1+YRi+Jg6NEV83LVX/SPMvfpWIXSNMRVf03XAODGUkzncpRXe2oXIxWXSBFI+3bOL/lq4jFBkldJP9BxSNAfPvYW9A9oM81aLgrGOj/shfEnxixhGO4YsL0lGTUEyohS+Bon91Z+cma/h92UTVuJF6Fl7f3WJZsKqzj51mQZAnrKEOtGD+0KVwf0+X4taEP2asEimsRdtAZQPemycxJIiz8dehYxdqrbW/+6cV8gIGEyhOs8twzs+ZXPLEdNaXnx/MnfmrC/X++Mep+jBOOUBbfBhpqTFE0E+KHG6HNpYRRIQSsa6nDaGD3wxMoGUYRZQ4en1Co43zs2+InqDFtj0ZUiFeVnIPdy4ukmSWb1sVReyi+9RV2ESZM+30x98QBqOIMfKFWyiy/uY8d1pcGS7UZIqoL22Cc+8QTkhfUFx7+hDVoKqg8Rq1UqapcLrsH5RzW6k2Yh7+QDawVRNYrfGaYbmjnlqTlLuGmKTx0NwnxddkW0jvgSMiWFnxU2sIrSLWE6ujMMZR/J+ezGFQHx7mHodtWL3WcVhh46yBGsxRrJNTeX1bDeePyAvC2ULzNwZdH41SB680Cgc/GAoS1oXXzOSs5WAY39vMsX3zzGmkSfRFh1qpnWOc3dUhoJW0Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(6486002)(54906003)(186003)(508600001)(8676002)(36756003)(70206006)(70586007)(4326008)(6862004)(86362001)(356005)(31686004)(31696002)(2906002)(8936002)(2616005)(47076005)(26005)(336012)(5660300002)(82310400005)(40460700003)(36860700001)(6666004)(53546011)(6512007)(316002)(6506007)(81166007)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:42:31.5016
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 72477d30-4e93-45af-07cd-08da2771777a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2205

Hi Jan,

On 2022/4/26 17:11, Jan Beulich wrote:
> On 18.04.2022 11:07, Wei Chen wrote:
>> v1 ->v2:
>> 1. Drop useless cast.
>> 2. Use initializers of the variables.
> 
> Would have been nice if this was extended to ...
> 
>> diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
>> index 680b7d9002..2b3a51afd0 100644
>> --- a/xen/arch/x86/numa.c
>> +++ b/xen/arch/x86/numa.c
>> @@ -162,12 +162,12 @@ int __init compute_hash_shift(struct node *nodes, int numnodes,
>>       return shift;
>>   }
>>   /* initialize NODE_DATA given nodeid and start/end */
>> -void __init setup_node_bootmem(nodeid_t nodeid, u64 start, u64 end)
>> -{
>> +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end)
>> +{
>>       unsigned long start_pfn, end_pfn;
>>   
>> -    start_pfn = start >> PAGE_SHIFT;
>> -    end_pfn = end >> PAGE_SHIFT;
>> +    start_pfn = paddr_to_pfn(start);
>> +    end_pfn = paddr_to_pfn(end);
> 
> ... these as well.
> 

Ok, I will do it.

>> @@ -218,9 +219,9 @@ static int __init numa_emulation(u64 start_pfn, u64 end_pfn)
>>       memset(&nodes,0,sizeof(nodes));
>>       for ( i = 0; i < numa_fake; i++ )
>>       {
>> -        nodes[i].start = (start_pfn<<PAGE_SHIFT) + i*sz;
>> +        nodes[i].start = pfn_to_paddr(start_pfn) + i*sz;
> 
> Please add the missing blanks around * while touching this line.
> 

Ok.

>> @@ -489,7 +489,8 @@ int __init acpi_scan_nodes(u64 start, u64 end)
>>   	/* Finally register nodes */
>>   	for_each_node_mask(i, all_nodes_parsed)
>>   	{
>> -		u64 size = nodes[i].end - nodes[i].start;
>> +		paddr_t size = nodes[i].end - nodes[i].start;
> 
> In numa_emulation() you use uint64_t for a size; here you use paddr_t.
> Please be consistent.
> 

Ok.

> Jan
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:44:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:44:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313764.531491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIgO-000760-7B; Tue, 26 Apr 2022 10:44:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313764.531491; Tue, 26 Apr 2022 10:44:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIgO-00075t-47; Tue, 26 Apr 2022 10:44:36 +0000
Received: by outflank-mailman (input) for mailman id 313764;
 Tue, 26 Apr 2022 10:44:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njIgN-00075n-Lo
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:44:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njIgN-0002D5-HJ; Tue, 26 Apr 2022 10:44:35 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.15.135]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njIgN-0002Yn-9p; Tue, 26 Apr 2022 10:44:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+e68LPkInZ1uO46tqfE6PlUwwKXp+5BEWR8drb64tCU=; b=GPmgf+1KdR/jPKi4P6jOdNao5G
	mb7bEDc9xUrNN1nF3kuOz+Vv5V+jIQYthnxHcKUpiqbNZUWUBoM8mgrG8vLc2ZhdWxTp6NMHFrJNT
	1HRx352i8Yl91/OORavOMAms41yW1rTSMSTViSCJlXPAQ4grKs2Eg95xVhPiKwNI60QY=;
Message-ID: <8bca62e3-1075-f1f7-1a92-1a4c58ba2aeb@xen.org>
Date: Tue, 26 Apr 2022 11:44:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v1.1] evtchn: add early-out to evtchn_move_pirqs()
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <acd0dfae-b045-8505-3f6c-30ce72653660@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <acd0dfae-b045-8505-3f6c-30ce72653660@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 26/04/2022 11:33, Jan Beulich wrote:
> See the code comment. The higher the rate of vCPU-s migrating across
> pCPU-s, the less useful this attempted optimization actually is. With
> credit2 the migration rate looks to be unduly high even on mostly idle
> systems, and hence on large systems lock contention here isn't very
> difficult to observe (as was the case for a failed 4.12 osstest flight).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: Luca Fancellu <luca.fancellu@arm.com>
> 
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v)
>       unsigned int port;
>       struct evtchn *chn;
>   
> +    /*
> +     * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the
> +     * vCPU-s they're to be delivered to run on. In order to limit lock
> +     * contention, check for an empty list prior to acquiring the lock. In the
> +     * worst case a pIRQ just bound to this vCPU will be delivered elsewhere
> +     * until the vCPU is migrated (again) to another pCPU.
> +     */
> +    if ( !v->pirq_evtchn_head )
> +        return;

I was hoping Andrew would give some insight (hence why I haven't replied 
to your previous answer).

I am still not really convinced about this optimization. Aside what I 
wrote about the IRQ raised on the "wrong" pCPU, the lock contention 
would still be present if an OS is deciding to spread the PIRQs across 
all the vCPUs.

So it seems to me switching to a rwlock would help to address the 
contention on all the cases.

> +
>       spin_lock(&d->event_lock);
>       for ( port = v->pirq_evtchn_head; port; port = chn->u.pirq.next_port )
>       {
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:44:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:44:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313766.531502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIgh-0007ZJ-Iq; Tue, 26 Apr 2022 10:44:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313766.531502; Tue, 26 Apr 2022 10:44:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIgh-0007Z6-Fu; Tue, 26 Apr 2022 10:44:55 +0000
Received: by outflank-mailman (input) for mailman id 313766;
 Tue, 26 Apr 2022 10:44:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bVWk=VE=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1njIgg-0007XV-93
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:44:54 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e633d383-c54d-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:44:52 +0200 (CEST)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650969886537818.2673685055015;
 Tue, 26 Apr 2022 03:44:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e633d383-c54d-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650969887; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=iUfO5XZhhaxFKUapN+vEdfaDWAfsfylK5KWGJjm3l3yF/PfNTrFVxs0DW05GTOJwbkhn50V0A1QezI5K2YdQ8xMD+91QLP4t0UIRn9nDKlcmB3/l4ec5rC/tW4Wa0spTy6kP50rXSi1FSz90KczW5XaMjxXKXKPnEU+WI0XXBTY=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650969887; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=hj+dEkNlqWhPGTS1YlWUm/Kq/vBPWzD4km56q01emc8=; 
	b=BM3XT+M9a3hxMB4Bh0kBrBKyJ2A9bPQeUQQ+iMdzujGHCNr4g76Ogb7+VZ55fEnP6AgsdOvvJerDpENglM6CWy1RZOqhk8FQvuy29GToHZAiNxYhrkbGiki8LyERhQNXQWrHEo7Bv0dY1FVuJEi1VxXZ1O0X+PgqpUP2VdsPHkc=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650969887;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=hj+dEkNlqWhPGTS1YlWUm/Kq/vBPWzD4km56q01emc8=;
	b=ZiSNxSDhjYtBUr6RklVCOered6CAK3/x0yXnqCVrLkqV4WufoRZVqDudx3j6RBHE
	XQ1H8mRgqbJeQl2izLtnBQnBPZmlOXYw0xRFj2x3TDb4i8LcMNmYupOgCu9W8KxqFk6
	nnFm5rYrqPmQ11atfSZl+rq/02l+qSZNiBzUMLwU=
Message-ID: <7e3b375b-f5f2-588f-692f-4ccf092d6db6@apertussolutions.com>
Date: Tue, 26 Apr 2022 06:43:54 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v4 1/2] xsm: create idle domain privileged and demote
 after setup
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>
References: <20220425172231.27401-1-dpsmith@apertussolutions.com>
 <20220425172231.27401-2-dpsmith@apertussolutions.com>
 <f82679b4-8b2a-ff9c-cc2c-60ba9b737de9@suse.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
In-Reply-To: <f82679b4-8b2a-ff9c-cc2c-60ba9b737de9@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 4/26/22 02:35, Jan Beulich wrote:
> On 25.04.2022 19:22, Daniel P. Smith wrote:
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
>>       void *va;
>>       unsigned long start, end;
>>   
>> +    if ( xsm_set_system_active() != 0 )
>> +        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
> 
> Roger did request that the panic() either also report the error
> code, or that the function be returning bool. You did neither,
> and your earlier verbal reply also didn't really respond to this
> part of Roger's comments.

Opps, my apologies. I meant to add his suggestion of adding the error to 
the panic message.

>> --- a/xen/xsm/flask/hooks.c
>> +++ b/xen/xsm/flask/hooks.c
>> @@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>>       return 0;
>>   }
>>   
>> +static int cf_check flask_set_system_active(void)
>> +{
>> +    struct domain *d = current->domain;
>> +
>> +    if ( d->domain_id != DOMID_IDLE )
>> +    {
>> +        printk("xsm_set_system_active should only be called by idle domain\n");
>> +        return -EPERM;
>> +    }
>> +
>> +    /*
>> +     * While is_privileged has no significant meaning under flask, set to false
>> +     * as there are times in hypervisor code privilege checks check this
>> +     * directly instead of going through XSM.
>> +     */
> 
> It feels as if there is "which" missing between "checks" and "check",
> or something else (better fitting "as there are times"), without which
> the sentence is a little hard to follow.

You are correct, will fix.

v/r
dps


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:45:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:45:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313774.531512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIhT-0008F6-Sa; Tue, 26 Apr 2022 10:45:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313774.531512; Tue, 26 Apr 2022 10:45:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIhT-0008Ex-Pb; Tue, 26 Apr 2022 10:45:43 +0000
Received: by outflank-mailman (input) for mailman id 313774;
 Tue, 26 Apr 2022 10:45:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1SWQ=VE=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1njIhR-0007XV-Sa
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:45:42 +0000
Received: from MTA-06-4.privateemail.com (mta-06-4.privateemail.com
 [198.54.122.146]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02fce9c0-c54e-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:45:40 +0200 (CEST)
Received: from mta-06.privateemail.com (localhost [127.0.0.1])
 by mta-06.privateemail.com (Postfix) with ESMTP id 4234218000A7
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 06:45:38 -0400 (EDT)
Received: from mail-oa1-f51.google.com (unknown [10.20.151.196])
 by mta-06.privateemail.com (Postfix) with ESMTPA id 165A818000AE
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 06:45:38 -0400 (EDT)
Received: by mail-oa1-f51.google.com with SMTP id
 586e51a60fabf-e68392d626so13865154fac.4
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 03:45:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02fce9c0-c54e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650969938;
	bh=nlcZFBj/6nclOGGfSsnO6KzzvshtblHXrPlXqt2RQ4s=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=gnQksIipZW0zNS5d9+KpQ1wBHl/SdcstUkvRE6CpzLgkuIELsrDLUv0DAkf8OyrlZ
	 G3HO3iYsLoG+3PWyQhMMJz7kZmWJJYWylIOH6/iEFT7EMumnU+syq8iGY3EdaROtZG
	 s8CwBqnpZ/cuw8IrgQht5Zwf/TpTFG4Zzt1MQTTAtNKRbRX4sDI8SmOItXn75fPRJq
	 wehvG0+rrbc0CzeHtVDlOD6lqGIYpFaJ+S5Wfn3tVeFmaqjriN/ZYhyQbJaJ02AX1J
	 8/l2sjgTCUF8GtIkaylO2/jQpV43PjQ4XPG2fOLmC7tY0imJ8SDs/qOuXHrJiVnnvr
	 skNcv04yXFfRw==
X-Gm-Message-State: AOAM5335wWMuWocP/Vi7XUDXAXdsolpq9iMPR0q7ClqhnotcdnVMR1gl
	2zMMMpKGfYrYrB8+r9ZSggDIL0wOQF7IdQxsrck=
X-Google-Smtp-Source: ABdhPJy4tz+rhYYRXIj7a050byoO+TuVX3OmhzfsKiFg4b/ChYKYW2btPr+kDdvsTD07g6Om4JIMoEkIBbo7Kemyt94=
X-Received: by 2002:a05:6870:b295:b0:e9:1c84:3671 with SMTP id
 c21-20020a056870b29500b000e91c843671mr5770214oao.128.1650969937362; Tue, 26
 Apr 2022 03:45:37 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <YmasHAT0YkeJVMbv@Air-de-Roger> <CABfawhn=6KVVPZD6AVRH2=NJFd5ZwtPpxDn__LdEFJQx6bhCXA@mail.gmail.com>
 <Ymeqg+UmOl2mN5Dz@Air-de-Roger> <bce39358-9739-c39d-c97f-6bae216da89b@xen.org>
In-Reply-To: <bce39358-9739-c39d-c97f-6bae216da89b@xen.org>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Tue, 26 Apr 2022 06:45:26 -0400
X-Gmail-Original-Message-ID: <CABfawhnbo-Yy1Se8sz-RKveRes-z_wTdfznzsBbQ0tAXkuN=vg@mail.gmail.com>
Message-ID: <CABfawhnbo-Yy1Se8sz-RKveRes-z_wTdfznzsBbQ0tAXkuN=vg@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
To: Julien Grall <julien@xen.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Tamas K Lengyel <tamas.lengyel@intel.com>, Xen-devel <xen-devel@lists.xenproject.org>, 
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Alexandru Isaila <aisaila@bitdefender.com>, Petre Pircalabu <ppircalabu@bitdefender.com>
Content-Type: multipart/alternative; boundary="000000000000a6c43f05dd8c6482"
X-Virus-Scanned: ClamAV using ClamSMTP

--000000000000a6c43f05dd8c6482
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 26, 2022, 4:33 AM Julien Grall <julien@xen.org> wrote:

> Hi,
>
> On 26/04/2022 09:17, Roger Pau Monn=C3=A9 wrote:
> > On Mon, Apr 25, 2022 at 11:24:37AM -0400, Tamas K Lengyel wrote:
> >> On Mon, Apr 25, 2022 at 10:12 AM Roger Pau Monn=C3=A9 <roger.pau@citri=
x.com>
> wrote:
> >>>> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
> >>>> index 84cf52636b..d26a6699fc 100644
> >>>> --- a/xen/common/vm_event.c
> >>>> +++ b/xen/common/vm_event.c
> >>>> @@ -28,6 +28,11 @@
> >>>>   #include <asm/p2m.h>
> >>>>   #include <asm/monitor.h>
> >>>>   #include <asm/vm_event.h>
> >>>> +
> >>>> +#ifdef CONFIG_MEM_SHARING
> >>>> +#include <asm/mem_sharing.h>
> >>>> +#endif
> >>>> +
> >>>>   #include <xsm/xsm.h>
> >>>>   #include <public/hvm/params.h>
> >>>>
> >>>> @@ -394,6 +399,16 @@ static int vm_event_resume(struct domain *d,
> struct vm_event_domain *ved)
> >>>>               if ( rsp.reason =3D=3D VM_EVENT_REASON_MEM_PAGING )
> >>>>                   p2m_mem_paging_resume(d, &rsp);
> >>>>   #endif
> >>>> +#ifdef CONFIG_MEM_SHARING
> >>>> +            if ( mem_sharing_is_fork(d) )
> >>>> +            {
> >>>> +                bool reset_state =3D rsp.flags &
> VM_EVENT_FLAG_RESET_FORK_STATE;
> >>>> +                bool reset_mem =3D rsp.flags &
> VM_EVENT_FLAG_RESET_FORK_MEMORY;
> >>>> +
> >>>> +                if ( reset_state || reset_mem )
> >>>> +                    ASSERT(!mem_sharing_fork_reset(d, reset_state,
> reset_mem));
> >>>
> >>> Might be appropriate to destroy the domain in case fork reset fails?
> >>> ASSERT will only help in debug builds.
> >>
> >> No, I would prefer not destroying the domain here. If it ever becomes
> >> necessary the right way would be to introduce a new monitor event to
> >> signal an error and let the listener decide what to do. At the moment
> >> I don't see that being necessary as there are no known scenarios where
> >> we would be able to setup a fork but fail to reset is.
> >
> > My concern for raising this was what would happen on non-debug
> > builds if mem_sharing_fork_reset() failed, and hence my request to
> > crash the domain.  I would have used something like:
> >
> > if ( (reset_state || reset_mem) &&
> >       mem_sharing_fork_reset(d, reset_state, reset_mem) )
> > {
> >      ASSERT_UNREACHABLE();
> >      domain_crash(d);
> >      break;
> > }
> >
> > But if you and other vm_event maintainers are fine with the current
> > approach and don't think it's a problem that's OK with me.
>
> The current approach is actually not correct. On production build,
> ASSERT() will turn to NOP. IOW mem_sharing_fork_reset() *will* not be
> called.
>
> So the call needs to move outside of the ASSERT() and use a construct
> similar to what you suggested:
>
> if ( .... && mem_sharing_fork_reset(...) )
> {
>    ASSERT_UNREACHABLE();
>    break;
> }
>

Ah, good call. Thanks!

Tamas

>

--000000000000a6c43f05dd8c6482
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Tue, Apr 26, 2022, 4:33 AM Julien Grall &lt;<a href=
=3D"mailto:julien@xen.org">julien@xen.org</a>&gt; wrote:<br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc so=
lid;padding-left:1ex">Hi,<br>
<br>
On 26/04/2022 09:17, Roger Pau Monn=C3=A9 wrote:<br>
&gt; On Mon, Apr 25, 2022 at 11:24:37AM -0400, Tamas K Lengyel wrote:<br>
&gt;&gt; On Mon, Apr 25, 2022 at 10:12 AM Roger Pau Monn=C3=A9 &lt;<a href=
=3D"mailto:roger.pau@citrix.com" target=3D"_blank" rel=3D"noreferrer">roger=
.pau@citrix.com</a>&gt; wrote:<br>
&gt;&gt;&gt;&gt; diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c=
<br>
&gt;&gt;&gt;&gt; index 84cf52636b..d26a6699fc 100644<br>
&gt;&gt;&gt;&gt; --- a/xen/common/vm_event.c<br>
&gt;&gt;&gt;&gt; +++ b/xen/common/vm_event.c<br>
&gt;&gt;&gt;&gt; @@ -28,6 +28,11 @@<br>
&gt;&gt;&gt;&gt;=C2=A0 =C2=A0#include &lt;asm/p2m.h&gt;<br>
&gt;&gt;&gt;&gt;=C2=A0 =C2=A0#include &lt;asm/monitor.h&gt;<br>
&gt;&gt;&gt;&gt;=C2=A0 =C2=A0#include &lt;asm/vm_event.h&gt;<br>
&gt;&gt;&gt;&gt; +<br>
&gt;&gt;&gt;&gt; +#ifdef CONFIG_MEM_SHARING<br>
&gt;&gt;&gt;&gt; +#include &lt;asm/mem_sharing.h&gt;<br>
&gt;&gt;&gt;&gt; +#endif<br>
&gt;&gt;&gt;&gt; +<br>
&gt;&gt;&gt;&gt;=C2=A0 =C2=A0#include &lt;xsm/xsm.h&gt;<br>
&gt;&gt;&gt;&gt;=C2=A0 =C2=A0#include &lt;public/hvm/params.h&gt;<br>
&gt;&gt;&gt;&gt;<br>
&gt;&gt;&gt;&gt; @@ -394,6 +399,16 @@ static int vm_event_resume(struct dom=
ain *d, struct vm_event_domain *ved)<br>
&gt;&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (=
 rsp.reason =3D=3D VM_EVENT_REASON_MEM_PAGING )<br>
&gt;&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0p2m_mem_paging_resume(d, &amp;rsp);<br>
&gt;&gt;&gt;&gt;=C2=A0 =C2=A0#endif<br>
&gt;&gt;&gt;&gt; +#ifdef CONFIG_MEM_SHARING<br>
&gt;&gt;&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( mem_sharin=
g_is_fork(d) )<br>
&gt;&gt;&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {<br>
&gt;&gt;&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 b=
ool reset_state =3D rsp.flags &amp; VM_EVENT_FLAG_RESET_FORK_STATE;<br>
&gt;&gt;&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 b=
ool reset_mem =3D rsp.flags &amp; VM_EVENT_FLAG_RESET_FORK_MEMORY;<br>
&gt;&gt;&gt;&gt; +<br>
&gt;&gt;&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 i=
f ( reset_state || reset_mem )<br>
&gt;&gt;&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 ASSERT(!mem_sharing_fork_reset(d, reset_state, reset_mem));<b=
r>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; Might be appropriate to destroy the domain in case fork reset =
fails?<br>
&gt;&gt;&gt; ASSERT will only help in debug builds.<br>
&gt;&gt;<br>
&gt;&gt; No, I would prefer not destroying the domain here. If it ever beco=
mes<br>
&gt;&gt; necessary the right way would be to introduce a new monitor event =
to<br>
&gt;&gt; signal an error and let the listener decide what to do. At the mom=
ent<br>
&gt;&gt; I don&#39;t see that being necessary as there are no known scenari=
os where<br>
&gt;&gt; we would be able to setup a fork but fail to reset is.<br>
&gt; <br>
&gt; My concern for raising this was what would happen on non-debug<br>
&gt; builds if mem_sharing_fork_reset() failed, and hence my request to<br>
&gt; crash the domain.=C2=A0 I would have used something like:<br>
&gt; <br>
&gt; if ( (reset_state || reset_mem) &amp;&amp;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0mem_sharing_fork_reset(d, reset_state, reset=
_mem) )<br>
&gt; {<br>
&gt;=C2=A0 =C2=A0 =C2=A0 ASSERT_UNREACHABLE();<br>
&gt;=C2=A0 =C2=A0 =C2=A0 domain_crash(d);<br>
&gt;=C2=A0 =C2=A0 =C2=A0 break;<br>
&gt; }<br>
&gt; <br>
&gt; But if you and other vm_event maintainers are fine with the current<br=
>
&gt; approach and don&#39;t think it&#39;s a problem that&#39;s OK with me.=
<br>
<br>
The current approach is actually not correct. On production build, <br>
ASSERT() will turn to NOP. IOW mem_sharing_fork_reset() *will* not be <br>
called.<br>
<br>
So the call needs to move outside of the ASSERT() and use a construct <br>
similar to what you suggested:<br>
<br>
if ( .... &amp;&amp; mem_sharing_fork_reset(...) )<br>
{<br>
=C2=A0 =C2=A0ASSERT_UNREACHABLE();<br>
=C2=A0 =C2=A0break;<br>
}<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto"=
>Ah, good call. Thanks!</div><div dir=3D"auto"><br></div><div dir=3D"auto">=
Tamas</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">
</blockquote></div></div></div>

--000000000000a6c43f05dd8c6482--


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:50:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:50:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313783.531524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIm6-0001Ji-CP; Tue, 26 Apr 2022 10:50:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313783.531524; Tue, 26 Apr 2022 10:50:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIm6-0001Jb-9D; Tue, 26 Apr 2022 10:50:30 +0000
Received: by outflank-mailman (input) for mailman id 313783;
 Tue, 26 Apr 2022 10:50:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bVWk=VE=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1njIm4-0001JU-T1
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:50:28 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ae407c12-c54e-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:50:27 +0200 (CEST)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1650970222258997.9651052220515;
 Tue, 26 Apr 2022 03:50:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae407c12-c54e-11ec-8fc2-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; t=1650970224; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=VA/LgwvKPyhMEL87ZqPVOX+nNpOGv7cDnLFnV7DcptEDb90erKtqd+0dT+/J709R+epTxNU6tZPM99k22ErjEXIrmhidRDtF34neaIaelEOEw0THD6I8kW79/BIblJTxKBRBDJKYEK2MP/kxMdBSFEncxjozyLIrM9fY/v9U0cY=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1650970224; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=3NQrrNyZoAl0l1fOEv3Xq3z7Xgge+LjZzQZC2mC6AAI=; 
	b=nsBqNXT+aDzm//EV9+QzlDRujpBx/zxnG/Z9gf817YDhilhgahRtW6o9NC3/P4P6gftXFPucMYEDmOShqqyW762fLPjQN52Iu4NzvAlyuU9OUzGFLmVC9twn9bMJ+V7MvhSotG3DGfTJ5DPqOtmfS8n5KYbll+wrIM2HWEyjTCM=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1650970224;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=3NQrrNyZoAl0l1fOEv3Xq3z7Xgge+LjZzQZC2mC6AAI=;
	b=pgquhFaBPXkDdhM4LkMWxz3KzA8udZqEByQk2p1u16F0Yphyg+jD0ZIZZJT250X/
	1vI3I52ZcVvYAnyL4frN1fS2l4AWJdaFwaLQjXXsdVf9/6x5EmiU2d38VvENEhlqV0Z
	7Qa/JzcVS1IR6FnF70o10xS00MhzxwHMq/H61wmg=
Message-ID: <76db9e2c-7552-f316-ea57-1fc59244389d@apertussolutions.com>
Date: Tue, 26 Apr 2022 06:49:31 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] xsm/flask: code style formatting
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: "jandryuk@gmail.com" <jandryuk@gmail.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220422194344.9318-1-dpsmith@apertussolutions.com>
 <5b199cfb-98c8-c382-82b3-a60819a0e977@citrix.com>
 <0e2724dc-bde8-a477-24aa-4bec5da55548@suse.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
In-Reply-To: <0e2724dc-bde8-a477-24aa-4bec5da55548@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External



On 4/26/22 04:38, Jan Beulich wrote:
> On 23.04.2022 01:07, Andrew Cooper wrote:
>> On 22/04/2022 20:43, Daniel P. Smith wrote:
>>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
>>> index 0bf63ffa84..e2ebbc7716 100644
>>> --- a/xen/xsm/flask/hooks.c
>>> +++ b/xen/xsm/flask/hooks.c
>>> @@ -120,8 +121,8 @@ static int get_irq_sid(int irq, u32 *sid, struct avc_audit_data *ad)
>>>           struct irq_desc *desc = irq_to_desc(irq);
>>>           if ( desc->msi_desc && desc->msi_desc->dev ) {
> 
> I've elected to also fix this misplaced brace while committing.

Ack.

>>>               struct pci_dev *dev = desc->msi_desc->dev;
>>> -            u32 sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
>>> -            if (ad) {
>>> +            uint32_t sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
>>> +            if ( ad ) {
>>
>> Brace on newline, and in the subsequent hunk.  Can be fixed on commit.
>>
>> Otherwise, LGTM.  Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Strictly speaking the u32 -> uint32_t conversion was getting us only
> half the mileage, but I've committed the change as is (in this regard)
> nevertheless. In many of the cases "unsigned int" or alike should be
> used instead.

Thank you, I can add a review of uint{X}_t usage to the list of updates 
for flask.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:54:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:54:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313789.531534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIqK-0001yp-UY; Tue, 26 Apr 2022 10:54:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313789.531534; Tue, 26 Apr 2022 10:54:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIqK-0001yi-R6; Tue, 26 Apr 2022 10:54:52 +0000
Received: by outflank-mailman (input) for mailman id 313789;
 Tue, 26 Apr 2022 10:54:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=b/nE=VE=citrix.com=prvs=108c91f88=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njIqI-0001yb-Nm
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 10:54:51 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49ced712-c54f-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 12:54:48 +0200 (CEST)
Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 06:54:46 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM4PR03MB6858.namprd03.prod.outlook.com (2603:10b6:8:41::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 10:54:42 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:54:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49ced712-c54f-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650970488;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=2EXOvYM0vLVDX3/5XUuLCCDxGie+Sm6ZAc+WzdG2tIk=;
  b=bfwx/o5XWt4ZgT4olVvmO8iazzzGTrJL7v9eeSkqwjQaoARgelUUWwKG
   jDR0oRmpqaW2n8DsuGxQALiszFgQSh0QDe20A7EkOda08MvLi5vUok3Uh
   46rUe4Q6QVkIyPbb7WHZkbkBpEx2xt1vNF8EkyEZGj/ug6jyI5qS/cpSD
   o=;
X-IronPort-RemoteIP: 104.47.70.101
X-IronPort-MID: 72381383
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:4Kxp8q/duMIhpDVmSrTZDrUDgn+TJUtcMsCJ2f8bNWPcYEJGY0x3m
 mpNCj+GM/mPM2eje9p/aoWwp0wP6pOGzd5rS1c++Cs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YLnW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaGNWVYMffyLo+gUchJHHgpkfvdl+YaSdBBTseTLp6HHW13F5qw2SWsQYsgf8OsxBnxS/
 /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHP2MvIcBtNszrpkm8fL2T
 swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK//FnujODl2Sd1pD2KNyPQtmEafl3l0Wb9
 mbWoF75IjsFYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiGGAlg4RXZxXCeJSwAOC0K3P+C6CG3MJCDVGbbQbWNQeQDUr0
 hqDmYzvDDk26LmNEyvFr/GTsC+4PjUTISkafygYQAAZ4t7l5oYukhbISdUlG6mw5jHoJQzNL
 /mxhHBWr90uYQQjjc1XIXivb+qQm6X0
IronPort-HdrOrdr: A9a23:P+a7/KAYJ6XGMs/lHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U
 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca
 Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G
 DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z
 /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkmlGy0TtegPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59as5Vza/ppVFZql/1XwKqVKuZzIAvqrIQ8VO
 V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u
 TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ
 zEFEhVsGYjEniefvFmHKc7hiwlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.90,290,1643691600"; 
   d="scan'208";a="72381383"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b208NmdORNmvXWmtemFyZjtiXUN27g4wYDyV8izTPHOazFCNviudUodIVmHcpY8k4umwv6CfIpHIFH2+lMCclVQUYI663fBOmY8Xcj5UMGD+yCQ4wsVMFI1h+nJjDVDIi5KydyrFt4GpYyXC4MjN09TDlKaWFth0tsmYwjnGrfXwmkcBH/RJHWVA/R8IS+NXBgjPgVzp48M7duwHA5USK7AF+0F9gfhYS2nfHkXQqaYBEdrIfV3d3Hm02mbkVy2oUI+o6iZlOIFnLlM2grJ7LyUdKw8YAWplzwn/Es6MumjxTjdFA+iNI+BKWk5ILgMxT2TDy+PHWFEuaPPUkDAREQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2EXOvYM0vLVDX3/5XUuLCCDxGie+Sm6ZAc+WzdG2tIk=;
 b=YyKlFUGgN8xnv6SAvVC1srZg6TW31JMuv1URcmzmrj+kn4V+gjk+0m7QTYDM5s6fcqJP98uD0ROQTi2aB7oDCrEXbbUyxkfOx8tfbL29Q7ofMQWA5lb09S7GjkKscwCPCYI7AIBqPiPpTB+3w+EOltptgbHHxTyGQIoGznZBfYQB2T9E8nbF8laa4pgS1hfuP/plMQ+M60fpN1r1DLCNTDSYQXttM0HDUZkJLhMDbbLTCba8X5N7VcOCKBGRcWQNoTW8APPoeK7bHBszef0lDRF5XPPVnmcKV41jiJaJXGfGHS0dnb4Sweeupjbn5ePc+ixC+6QP5jEGVKyQfW9Ufg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2EXOvYM0vLVDX3/5XUuLCCDxGie+Sm6ZAc+WzdG2tIk=;
 b=akIqsodMP3zLY3z7PEU2b4SzBsihQesw/wEocEe0HVCggmX2FsDz+8FeWWBvYbU3tKYU/N7P4za5ZxQ+1T2HrObpy6YpXbX5JHJItrZEsD5sXgeBi727q5ym25ks+6Os9/VfxnviOectYuxo70nM3jh8ZRSvq32Ikq9BDnJwT8s=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, George Dunlap
	<George.Dunlap@citrix.com>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH v3 5/8] libxenguest: deal with log-dirty op stats overflow
Thread-Topic: [PATCH v3 5/8] libxenguest: deal with log-dirty op stats
 overflow
Thread-Index: AQHYWVfhm+zZwj1KrEGTWozLvDKzrK0CBWEA
Date: Tue, 26 Apr 2022 10:54:42 +0000
Message-ID: <068a468d-a7a4-bf24-264a-ac86b910dd82@citrix.com>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
 <1b24d2b5-14ff-6e4f-6fa5-d91d75e315a4@suse.com>
In-Reply-To: <1b24d2b5-14ff-6e4f-6fa5-d91d75e315a4@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 33bf66ec-31d9-4ca0-95e0-08da27732b38
x-ms-traffictypediagnostic: DM4PR03MB6858:EE_
x-microsoft-antispam-prvs:
 <DM4PR03MB68586590EEECAA0E86DD94DBBAFB9@DM4PR03MB6858.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 ysLXSyUqoDGkG8ukWA/7pQkLd9iMSasOEfYh/VElPhMoaPLQ4+M9LnEhAZGvIDa8XWyKqrDRHthuFHJNxzuzp7ys+3bYOa11B/4GjeGwRCYP0C0y5DAgBYXkZkRxUvme0DA1cZN/jhRLlss6giypdKkHgni9Nr83tWuS1HnoE811zg0JNN0AlyVc7hRRcYzBg7/8slfs8+QbthlXsnK55r7/Dpr5pJMUIKFSKA+7MLoHYNyj1yFdK4m3aHifUQmpD74rpbY5+ymLI8IBXY4RdD74zALxQFNqdRflly8YO7qlJX7O7jjhpv7frBf3oLgJhzipqsSeFr/C0HIUtiCpylzfHYhKacqrjvJUhHeLxwrQdC5VaF+N/15kGNg1guV7Wsw1oU6TN0FAulwGp2WI31YJiPB4r/7eMVanjYp3ahhJRcENi6L88uGTogGh4HE4qW+h/GfWXDWvw8NcPst3VtuhmsD7P+Nf4oRQsakQpvk+14HsPwskHJ2THDSDYqrYG6Gb6TmxA30/gWyAUpZ9vU7eu/+ihA0rQiFflYPQSjSn/wQyfm3xAIVF7T1HPVgRuArfmYfXvMNa2dYDIusema6cJnPhPs7U2k0DIImPZQDfj8rTZ79STXjq3fRdtQKh2BSlMqEdXIzN5k64dyswckqm6SMmZaEZHtWxfChm33c1CxbHxEpd2SmHosksEtZFVkDrx9vbaw2QI+EYZv9Br1jnhzCvUHWcaoWx7yEZhqnQPBPNAgIOnuTrCnlQMZsOdMDcZzsLZ4z6THrxpwY9N7uR4JEIu8hROmUb8/jyqSM=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(508600001)(316002)(36756003)(8936002)(31696002)(64756008)(8676002)(110136005)(54906003)(76116006)(82960400001)(107886003)(91956017)(31686004)(186003)(5660300002)(6512007)(4744005)(66476007)(66556008)(38100700002)(38070700005)(86362001)(4326008)(66446008)(71200400001)(2616005)(122000001)(2906002)(6486002)(26005)(6506007)(53546011)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?UmF6WThTRXFFVWthSFJqaFRKTkNucmNLUzBhN3lKanNzaEZuSTczbXdJVC96?=
 =?utf-8?B?VlFzYllTSmgzaS9CbGxNeVVTdGkvWTQzekVZZThYb2lzU1hUazJSSFVpTG0y?=
 =?utf-8?B?WTJkalpvK2Vib0czU0xHUEpoZXM0Rjg0NmJLc2FoN2hSbzUrR2l1ZnR0UWVh?=
 =?utf-8?B?NFUrU1lCdjFVTGlhT3htZVpwMFJxTXkySVNIUGZSTlFSZGttd1RTL1NDcHMw?=
 =?utf-8?B?WSt6MzJoR1ZlUkh2QzRxeHNEaEhWcUFrK0s3UlpXdTVqN29WcUVXZTMza1l1?=
 =?utf-8?B?c28vc0ZHbmVYVENIY3lIdHJBK3FmL0FTcUwxd0w4VzdhbGZIVm9aNlIzT1Jt?=
 =?utf-8?B?Mmt6MTU4L3JrZHFPc0JzQmltZHNuYzM5c1NVcTNlQW5yR2lBMnZ1L3hIVjdr?=
 =?utf-8?B?QUZuWWZBcHBOdXkwaVFwMTdicTNhSERDdTFqSDg1b1d5UzhSb0hpenEwY2pz?=
 =?utf-8?B?MzRXZFduMnRVak93UUFJQm1JVUV3TEpnc3BrRFpSaVhZTndwcnFXVkMvVWNB?=
 =?utf-8?B?ZDg3TDlvT2FUSUE4THpLcUgzd2pLRTZaa2pwL0wwbjRFa1VIN3F3TGFSQXdZ?=
 =?utf-8?B?VDFibHg3a3NSSzhZQklJZWlWdWVUTmdpaGJGc0Uxa2FMOUllQmhtajZxRWVS?=
 =?utf-8?B?YkRUY2pXRk8xb0pQbmZKWTU4NlpFZXREWCsyajhJTjU3V1l6WEVVTjg1VXA5?=
 =?utf-8?B?bDZsanFubE5ydmQralpaTk5zQjdIcUdnMEN5NjVWUTBkZzc2WUpkeko1Tnd3?=
 =?utf-8?B?YUVRaURhd1pQZW9XSTUzcVlCOGh6VnVxOW1mYzd2R0ZZOC93M2ZwYjVFTmNJ?=
 =?utf-8?B?L2lxVjB0MmNhbHNhQzFzbXo3cnJCY2hwVk5DRUswTjNkZVZTbFV5M0RCOXVW?=
 =?utf-8?B?bHdhb0VCU3ZSVnVQalVrc2tEN3k3Mk1MTStJZW55aFBlMnVET3BhUXFwMkNq?=
 =?utf-8?B?K1RTUTJXQUc0MGhnQTBiUDAyLzNpM0JVT2NOT3VTKzg3OVdMU0ZnRzQzb21G?=
 =?utf-8?B?dU4ydm1PZlVYVXNpS2RmcnUvbmRTdnN0RlRTNXhWTnMwcnBmTEFRcG9hUHFB?=
 =?utf-8?B?RE1TVXVuV3cwcGlwb3EvT0F6MW1RazI1SVhpSXo2WFRHRWJvbzBjV3pZTUgr?=
 =?utf-8?B?RUo3VEtjZDQ3VHlxNWJtOU5WSG11VWVqNlJtWHNrUk1pR0RPNnJBYUF4OGVP?=
 =?utf-8?B?bVNlVG9acm5zeDdLRExoTHE2VUdoQlJmMmJRU2twUHNBTXFoOFByVGhOaUdF?=
 =?utf-8?B?aXU2ZERKdGtoSFJXclR3QnZXUHp3SjZlQkk3Tk9KTjdHd004QWNOcEd2VEtj?=
 =?utf-8?B?dFk0YXloQy9kWXRFM2drWHE0cDAwU2RXNkVvQm1STlVMbEovOXBHeUxFQkZL?=
 =?utf-8?B?QVY0N092d3AxZ1pxalM3anZZdytxRGliNmFZeDY4Nm0xUXd2WmFKN2cyb0lZ?=
 =?utf-8?B?QWw2d2dlWE11L2NFVDVLQ2xLbmRLQzNKNXloL0xJNVVPSEZOUElweGVjOGRB?=
 =?utf-8?B?Slc3cmF5c3crVzd2K3BGS0UvSkNzTkdKeEFkazBNcFlFZWk3QURNYUpTMmxp?=
 =?utf-8?B?UXRVZ1RiKzVzR2xsaThlZWtyK3AyRG5JR0s0Z2c5ZGxRTXlKOXROUlBpTHBP?=
 =?utf-8?B?QTZFVThydVJQK1FNSmZVeC9NWUJDd2pSMmZSZS81UHZ5Q0dJNmVsbVh2TjFC?=
 =?utf-8?B?YVRmV00yNHFCV2hmbk5uRFgrdG1CZ0NVS2VHNjVYbDZNazh6ZXh1dFhDYVUx?=
 =?utf-8?B?UmdXQzVkZkdhOEZocTNZRVMzU3UyRlhKVnBQdXdobDhGRXFlMVNKVGh1VWNu?=
 =?utf-8?B?TmdqclNXbkJDRXU0bXVWSUJjYWVyUmdBU2dFNUR6WGZWRktVYVp5U1F6ZmN6?=
 =?utf-8?B?endsWFBKWFRIaTJmdkJaZGd4N2NiNjloRzNXRjQ1bU9kanlyRUJaUG9XK0Rz?=
 =?utf-8?B?VTQvOXhrb3VDQitlS2w0bVdsWmQ4ajBXWWFhT3VnSlBodDhHTlErWjFBK0tP?=
 =?utf-8?B?ZHkxUzVHcExxWU5jTDRVWFNRcFVOU0dpR2Y2TXNkYzN2eGs1SVgyWWtTS1JQ?=
 =?utf-8?B?N3BtbUJ1MmhNV1FScWZiSzFFQUdlbmdYb0o3WWVWYW50dFJNdjJvUTRuY2R6?=
 =?utf-8?B?ZTJPcEtHZkNzOExsblJON3RsRU1KLytnMEs0SDhJY08reE5GVzVucGJUWHdX?=
 =?utf-8?B?eHIxc1VnSzNBd0RGS2t2NVRIWUZXeTdldUNFbzNzNllFUGhFd0xORXgwQU9Z?=
 =?utf-8?B?bGVJWThIRkJUck9qc21WOS9vOTQ5WWFWcWJMTkgxUWpGelBmVEtiUURBdEx0?=
 =?utf-8?B?QW43VXJZbEt5aVFLdmgzVllIc2Jkc0d2dlpHUCtpL1J0QWJvV3dkUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <18C478770D12384DA2AF4940A51B9CCA@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33bf66ec-31d9-4ca0-95e0-08da27732b38
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 10:54:42.5885
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8lUK/QAPEM0nphQ6ct7Xcy15RU9+mHmnZvF7Tmp8/eGAYx15+vY6V5djZl7iB77SWZeWiWfwuCo4DjDHN4ysfKvb7xAhv+AmwdiGk3ZV9e0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6858

T24gMjYvMDQvMjAyMiAxMToyNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEluIHNlbmRfbWVtb3J5
X2xpdmUoKSB0aGUgcHJlY2lzZSB2YWx1ZSB0aGUgZGlydHlfY291bnQgc3RydWN0IGZpZWxkDQo+
IGdldHMgaW5pdGlhbGl6ZWQgdG8gZG9lc24ndCBtYXR0ZXIgbXVjaA0KDQpZZXMgaXQgZG9lcy4N
Cg0KQW5kIGFzIHlvdSBrZWVwIG9uIHJlZnVzaW5nIHRvIGFjdHVhbGx5IGZpeCB0aGUgYnVncyBw
b2ludGVkIG91dCBkdXJpbmcNCnJldmlldywgdGhpcyBlbnRpcmUgc2VyaWVzIGlzIE5BQ0tFRCwg
c2VlaW5nIGFzIHlvdSd2ZSBhbHNvIHJlcGVhdGVkbHkNCmZhaWxlZCB0byBhZGRyZXNzIGZlZWRi
YWNrIGZyb20gcHJldmlvdXMgcmV2aXNpb25zIG9uIG90aGVyIHBhdGNoZXMuDQoNCn5BbmRyZXcN
Cg==


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 10:59:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 10:59:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313797.531545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIuf-0002g9-Jt; Tue, 26 Apr 2022 10:59:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313797.531545; Tue, 26 Apr 2022 10:59:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIuf-0002g2-H2; Tue, 26 Apr 2022 10:59:21 +0000
Received: by outflank-mailman (input) for mailman id 313797;
 Tue, 26 Apr 2022 10:59:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIue-0002fs-Ee; Tue, 26 Apr 2022 10:59:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIue-0002Uo-C1; Tue, 26 Apr 2022 10:59:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njIue-0002mN-2h; Tue, 26 Apr 2022 10:59:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njIue-0000PI-2I; Tue, 26 Apr 2022 10:59:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=n8/0HX8ETSU74B9yCX4E7jNtraAAqpOA4GSwm72NT18=; b=EsWep9gpFCf+BNfo+9XZVJJRsp
	o0wkxyccNx8G/wvdc03Wgchtw/b/c2hYQd1ymE/VR8VXRCyIrbERUrYpPz9PJqy6OzvDn+M5gxu/b
	95ddKg2SNIwK0mjmgsuoE0gHUiYwdJwNyZ/2GRuN/QWBSqmNEp/1DmWfL3e8ftNY69hQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169732-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169732: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 10:59:20 +0000

flight 169732 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169732/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  638 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 11:00:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 11:00:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313804.531557 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIvN-0003vs-VF; Tue, 26 Apr 2022 11:00:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313804.531557; Tue, 26 Apr 2022 11:00:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njIvN-0003vZ-Rj; Tue, 26 Apr 2022 11:00:05 +0000
Received: by outflank-mailman (input) for mailman id 313804;
 Tue, 26 Apr 2022 11:00:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BNuI=VE=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1njIvM-0003A7-6F
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 11:00:04 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on061d.outbound.protection.outlook.com
 [2a01:111:f400:fe05::61d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 05bc11d6-c550-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 13:00:03 +0200 (CEST)
Received: from AM6P191CA0025.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::38)
 by PAXPR08MB7573.eurprd08.prod.outlook.com (2603:10a6:102:24f::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 26 Apr
 2022 10:59:59 +0000
Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8b:cafe::1d) by AM6P191CA0025.outlook.office365.com
 (2603:10a6:209:8b::38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Tue, 26 Apr 2022 10:59:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 10:59:58 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Tue, 26 Apr 2022 10:59:58 +0000
Received: from d9a305b031af.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D01BA725-81AB-41D3-986D-296903CEA585.1; 
 Tue, 26 Apr 2022 10:59:51 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d9a305b031af.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 10:59:51 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM9PR08MB6177.eurprd08.prod.outlook.com (2603:10a6:20b:283::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 10:59:49 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 10:59:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05bc11d6-c550-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p3bV0rwMkei3xP2B21Qm5LGLf8dYE6TXpI/IbhNWhMs=;
 b=OVVUr+S1SblObs0ueg9cgFuCPSbKNJjrc1kGqseKkGqnR+QBo7XAUP1clQXwThNBtn1c4FjG5WJJ2zHb95xTq5pkIpNc+hddeYDFfO+LjomE7j86ljUucA0xaIRtu5UcpX+JLnp4IFVyGYwSw6atasJIM/4Zo+f2J+t5K2iU+Tw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 90c8565e809cb89c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ER0oBGjFfwndL5qkuE56CyJYTE6aw+UKLXs5RjO02bBCE6o1qyUmmRkcWN0WnK//Cyxptm7bibiAIpHux8t1zYCDerOEkB7ZwgW6P9qPcMMojEMCfGiczjDrUjz7s9wP0BCL9RNjqzKNHuec654hIf9tlZsTJjY1FsS5Fm1xaVuZ66UOmOSh4iyDl+loUIlYU7sLPGKzrTbEOnGEQCFmgAlZKLrFtZC0dxSmKJgSPlmE6SRKRpTWHG17qnp+qH6mht/FTjaNyrUC6D4DyO0frxNEgSVT0mEGXIWcgROtS39HoFxcK2Pajz19kSucPGST78qfPLki3ucs1N1EudlxnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p3bV0rwMkei3xP2B21Qm5LGLf8dYE6TXpI/IbhNWhMs=;
 b=NX7LHT5D8cPr5Ianrtq/x+y5b3Y0tAXRkQo3M34o89e/z9nN+hRzNr3aQu1DwtOR5jA7t82i5nywDdO4IbIdmNlAQkdCxkGjXRVlQfhkQpDiohlUJBsi+P9wQCGEVfTx1lReD/s/PLxt/pDkQx8Ecae0bD+M1Kx9RmHsbrC8SwVox++REBFSDZsR6pB8ZfJ0w2a9PW4EpA4kqyy293mMQcJNCsagjhTnrCkdvQT3MUJBHlK03/P6J2BcvpCfNpGHRjcNZJ7JHJMACCFmMLyH11OCiyNtXAGA3dpaCPrZChpTfA0eBb8amOHtMQCb77rG8BoV8lFKnNUOOwkHlBw72Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p3bV0rwMkei3xP2B21Qm5LGLf8dYE6TXpI/IbhNWhMs=;
 b=OVVUr+S1SblObs0ueg9cgFuCPSbKNJjrc1kGqseKkGqnR+QBo7XAUP1clQXwThNBtn1c4FjG5WJJ2zHb95xTq5pkIpNc+hddeYDFfO+LjomE7j86ljUucA0xaIRtu5UcpX+JLnp4IFVyGYwSw6atasJIM/4Zo+f2J+t5K2iU+Tw=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <7d7fc887-20a3-49c3-0754-3bca3442ccce@arm.com>
Date: Tue, 26 Apr 2022 18:59:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON
 for phys_to_nid
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-6-wei.chen@arm.com>
 <6d666aa4-c0d3-b8ed-9fca-e9d2179564d3@suse.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <6d666aa4-c0d3-b8ed-9fca-e9d2179564d3@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SI2PR04CA0001.apcprd04.prod.outlook.com
 (2603:1096:4:197::12) To PAXPR08MB7420.eurprd08.prod.outlook.com
 (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: ade1cad8-57b1-4f88-6c73-08da2773e79e
X-MS-TrafficTypeDiagnostic:
	AM9PR08MB6177:EE_|AM5EUR03FT033:EE_|PAXPR08MB7573:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB7573DD76F6490F183B2D7FF09EFB9@PAXPR08MB7573.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 lL/JIo3sY2B4jt9B5u+gOE3qsNDlth1Wm8XnpyLrGCoEDdecknA4my0Rfp8mpi9v7r44mAJQFTNvgteRAYjqNXi7LRzhiI/BHlXLYTpHmQu0OeFhK0lSE7mEwJXVcIS7cMuSQxd/mLIfT81fU9GQZOTUc3suMvx0cqBfjBB/JQjC23qPVSbjt0C7yTHn9iFnzYuXZg3bIcW+24fWoglrMaGVH+XE0KPS7AEQ6ky8jSxqBPobjZamxcemqgkuPdwr3mYOC478otMF/vd8A3SbdQBEQCUtGBeijuPUul+pclmHXU20x5zW5fKSDcuIY/uHPgW4CTV+HHJ7gB7vQejxwr6t8R3DiGbR9l51InnUH77mHRzviJEGtXcOXK7oE6zcSpagmduwdaQAL5N4xDJQc1bdITajfTaCxr7vywzxf8+nmY10xgClrrgI+eH79wsqaZMWWXwYYDq/k7o8mRCzrD1nSYpS5hDmtD4WQGtLeJOIym68mDfQb2+bdWGpS13vtT4uVGLZbTXBbot0pK56fLNjQGVcIqQPEbBCfPkeNcD7Y0QL3b27iWFrhoNqOxDBbZgRcoF4UKgQlupav+Bl7QHPAKv4BldvqQ00Du4u3PN+YmpJ22BYtRckn9DgFmZdS0lGCX8ftZO1V/b93aWbTEKL6OKohwfQxU7Istr+f1zgTsJlOZ3qIE1SkTRiPcuYDfabyyynqMlxhEFHWCvrgZEE57k8a8IrYA0fFSDwzPY=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(26005)(508600001)(31696002)(54906003)(6916009)(66476007)(6506007)(6666004)(8676002)(4326008)(6512007)(86362001)(316002)(66946007)(66556008)(38100700002)(53546011)(6486002)(5660300002)(36756003)(186003)(2616005)(8936002)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6177
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6219f4c6-fb9f-414c-771a-08da2773e1c7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WNogcQ8tUh0+NRxGY9a6yCrt0YKicrTu+abH7p4vIIemamfMiYEa0orPnXteLgemu5MFq23nQbgDxEfsEWdBrycEG69eIwr/IUdgFL4M/+zOP67KNGAAurMDjBWCSp5C+So5ErwfuAGFENkT/LXh6nfEYLThSMX24u6wuHHdRni+TFclP0PQpL4umUo7wQFVf5Uz+Bz5glzAMEWDatu2z8Tyy/1FmEsPn5mw4H0Pwyw54/05rDZ1PP9omqPb6z8AIsck9RB8zgGKeb8DC5O2POtdy7t7Ot4+5UHiYKEeIXRWRyVaYOWFdM6/48TtkBmmrA3+hEzGiigwkYCfnQp53OcoCe6LF6RQ6EtWhEm2G3s9IwyvneM76Bi+mPGtMx79geM7Ia1IRsA/OFG+Zokj5E/2wib3WzqZirrWQ7wFToJNVIQFGepeO7/7031VU1qAkGvhQhdYeb9cHM9qijMSZoo/JvvUC1OBEBgwjietunhcyy08Uq+tpZQE7pEhVP13Mds3imaQLfgrnTQY0sf95pm0ez7fvALfN9TQStXBkCmW1c1maq21HMPDfWDBKpmc0dE+jVOxqFvriPyvlz4V3BPp3nSjPUupkYvZ9HB81IdYRfaU4d6ldH1oZ/EE+VZZ5H9CvXuI9S19a0PePXF8XiheHthagXpbCzXI+8giAO1aE5xkHyRZsOq0Kp/62A/C68wqT8mL7QnxCyWMmpgcqQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(5660300002)(82310400005)(36756003)(81166007)(53546011)(70586007)(54906003)(70206006)(316002)(6486002)(508600001)(8676002)(2906002)(356005)(86362001)(83380400001)(31686004)(26005)(6506007)(6512007)(6666004)(36860700001)(8936002)(6862004)(4326008)(40460700003)(336012)(186003)(2616005)(47076005)(31696002)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 10:59:58.6363
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ade1cad8-57b1-4f88-6c73-08da2773e79e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7573

Hi Jan,

On 2022/4/26 17:02, Jan Beulich wrote:
> On 18.04.2022 11:07, Wei Chen wrote:
>> VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This
>> results in two lines of error-checking code in phys_to_nid
>> that is not actually working and causing two compilation
>> errors:
>> 1. error: "MAX_NUMNODES" undeclared (first use in this function).
>>     This is because in the common header file, "MAX_NUMNODES" is
>>     defined after the common header file includes the ARCH header
>>     file, where phys_to_nid has attempted to use "MAX_NUMNODES".
>>     This error was resolved when we moved the definition of
>>     "MAX_NUMNODES" to x86 ARCH header file. And we reserve the
>>     "MAX_NUMNODES" definition in common header file through a
>>     conditional compilation for some architectures that don't
>>     need to define "MAX_NUMNODES" in their ARCH header files.
> 
> No, that's setting up a trap for someone else to fall into, especially
> with the #ifdef around the original definition. Afaict all you need to
> do is to move that #define ahead of the #include in xen/numa.h. Unlike
> functions, #define-s can reference not-yet-defined identifiers.
> 

I had tried it before. MAX_NUMNODES depends on NODE_SHIFT. But
NODE_SHIFT depends on the definition status in asm/numa.h. If I move 
MAX_NUMNODES to before asm/numa.h, then I have to move NODES_SHIFT as 
well. But this will break the original design. NODES_SHIFT in xen/numa.h 
will always be defined before asm/numa.h. This will be a duplicated 
definition error.

How about I move MAX_NUMNODES to arm and x86 asm/numa.h in this patch
at the same time? Because in one of following patches, MAX_NUMNODES and
phys_to_nid will be moved to xen/numa.h at the same time?

>> 2. error: wrong type argument to unary exclamation mark.
>>     This is because, the error-checking code contains !node_data[nid].
>>     But node_data is a data structure variable, it's not a pointer.
>>
>> So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
>> enable the two lines of error-checking code. And fix the left
>> compilation errors by replacing !node_data[nid] to
>> !node_data[nid].node_spanned_pages.
>>
>> Because when node_spanned_pages is 0, this node has no memory,
>> numa_scan_node will print warning message for such kind of nodes:
>> "Firmware Bug or mis-configured hardware?".
> 
> This warning is bogus - nodes can have only processors. Therefore I'd
> like to ask that you don't use it for justification. And indeed you

Yes, you're right, node can only has CPUs! I will remove it.

> don't need to: phys_to_nid() is about translating an address. The
> input address can't be valid if it maps to a node with no memory.
> 

Can I understand your comment:
Any input address is invalid, when node_spanned_pages is zero, because
this node has no memory?

Thanks,
Wei Chen

> Jan
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 11:08:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 11:08:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313811.531568 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njJ2w-0004ks-OV; Tue, 26 Apr 2022 11:07:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313811.531568; Tue, 26 Apr 2022 11:07:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njJ2w-0004kl-LK; Tue, 26 Apr 2022 11:07:54 +0000
Received: by outflank-mailman (input) for mailman id 313811;
 Tue, 26 Apr 2022 11:07:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BNuI=VE=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1njJ2v-0004kf-4X
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 11:07:53 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0628.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::628])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1cf6ae52-c551-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 13:07:51 +0200 (CEST)
Received: from DB9PR01CA0030.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:1d8::35) by DBBPR08MB4363.eurprd08.prod.outlook.com
 (2603:10a6:10:ce::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 26 Apr
 2022 11:07:49 +0000
Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d8:cafe::b8) by DB9PR01CA0030.outlook.office365.com
 (2603:10a6:10:1d8::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Tue, 26 Apr 2022 11:07:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 11:07:49 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Tue, 26 Apr 2022 11:07:49 +0000
Received: from 4ffcf29158da.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 680C3B81-ADB5-48CF-8C9F-15F77D8E4F01.1; 
 Tue, 26 Apr 2022 11:07:43 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4ffcf29158da.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 11:07:43 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM8PR08MB6369.eurprd08.prod.outlook.com (2603:10a6:20b:354::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 11:07:39 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 11:07:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1cf6ae52-c551-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k5BqB17tVcu5/rRvTTNBFR/32NiBn8L7cdCLyzRYD3o=;
 b=Z6IcTUy8c/NwcOtD9SEn8NHumM+O5mnDSeHozwW74j8i5UM4Jgjcry6p4dpsksblBs2w3Y+WOqi0AQBC5z/rqdb2b7/K0hr4wrd9ogyiCTwwbUIZaVc3kvvmmOdeNM8tpsur4mq96DsWCsdK1bSTwUWZYtBGb0WtUifrzOHO3Io=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 296156087e89cfc3
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jprzCejm7E5Qhw1V7RZ4TfxdIdS/dZNCMZDua7S6Af7rZRuCgX+rRn0M2Ed3QB4Un7i8Mz2i4OHjuGmMC1qsOkK1zvlg9eq02G5rGHnVsqEYxtkDvODyoDabgCZCyNg1UjNxxJ6bzW6ExBVxTiLnzjO/quhBif/ur2jp0j+G2QgnbvlCeqN4LSboQTVLlKR1Jat32AenSnzjaytM98ZZCWYtQ4Z7sfmEW1bfavdmvZDzMoHcbDhMeMiILfHbdRDRYUhO93ihUJ+tdpQL2MctQUKB0KmURce7I85WIFHFaHC5xagDKj7/Mr0fTDlUo+folVBo06A0vvDP/vqrLRThSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k5BqB17tVcu5/rRvTTNBFR/32NiBn8L7cdCLyzRYD3o=;
 b=NjF1/wsMt+QSzjUfV6OW3qAEDYmGu5cOoBFkgB7GdjD25WqTfjqC/Nk3xPalxCoxLTQ4I1TAdm4UeJ/jvn2TKT9s6Qa7+beT5FkiYVBfLhS1V8859gtmacZ7XETrde/Ueir8hKj7M7uzimdlJ+QZeHicl9/jfh7ergAJx3o+f7Ni1bGqOo2+M8A7i4yxqwMzVGnqbY8tWqvY6fIi1Nff/xBbJ0A89YvOYSNmNAgSVS79GH4SZjuIg0nLWShj2n2Cl490bhW+wK7pAD1AxBr0yb3aeltZEUXsRahvQ9fYBo5N84AbTCpQ2uArHSX5ItJt6uluzZCvIfdPxdqcf2++wA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k5BqB17tVcu5/rRvTTNBFR/32NiBn8L7cdCLyzRYD3o=;
 b=Z6IcTUy8c/NwcOtD9SEn8NHumM+O5mnDSeHozwW74j8i5UM4Jgjcry6p4dpsksblBs2w3Y+WOqi0AQBC5z/rqdb2b7/K0hr4wrd9ogyiCTwwbUIZaVc3kvvmmOdeNM8tpsur4mq96DsWCsdK1bSTwUWZYtBGb0WtUifrzOHO3Io=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <efc5dd55-0fc9-5741-520e-f98000ddb324@arm.com>
Date: Tue, 26 Apr 2022 19:07:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 10/10] xen/x86: add detection of memory interleaves for
 different nodes
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-11-wei.chen@arm.com>
 <22591300-a09f-1ab2-fd6b-6c4875641035@suse.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <22591300-a09f-1ab2-fd6b-6c4875641035@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SG3P274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::17)
 To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 72356f91-fc81-4ad7-b4e3-08da27750017
X-MS-TrafficTypeDiagnostic:
	AM8PR08MB6369:EE_|DB5EUR03FT034:EE_|DBBPR08MB4363:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB4363BA6917C22D4C51C628E99EFB9@DBBPR08MB4363.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 wqvI/wPJLao+dV3a/FRnE5M9PlUDZUT3se/cdjZi6Q9yL7QpBEgOqRFRn/PwJ5Sn5B46qCqgT29odjUG1yTpWKHf/SKSQAF9jbBqIPYkwt88fdPVKAmRqKZtH2V+O+rCsKXf3UEVLUj9RiTLwb9ZT2p9FnUvrouNqQRobvUZxClIQkNp6oUjvPDAPhft052bkj29k/N7tFvUMkR2nC8ctXrddNYaNaD64eRA4NAcYGqu1NpydDcTPvx1GO1g8tdjwtELWLy8/3NlKpjRF8ZTZVKlN1YMOBWrkpXb2oWmS5a5hozceSM5/JrjZMpUTOm+PZAZuuuI+833ZPMPiuBwMY0+lkyTRHAT7kgRAWUNwsPytjVYwIJLXhRZeIJi0njcn/UXx548NxEjynVC7gPf4CjFkqA4jZpQBd25DKmFuyZXEdZnrf20Y6AcemVIM7sVqMjB5kFZ/Xt8afde9GEF9CZflHtz17MyT7G2DH2Q991TxROmyvZ5t/HKPepMtMdvO1rSe0eH6pD0qaPAKmdMJ7K+QwGINHm0pzIeZXJeRmgzqRyxaVFQyktrIs5cdaG/bCkW3frSxeo6/E5+xdGuNc3SUkeqrIJt+B7vdMcQPuuZVQsJX4X3zt3J+euHzvR/4RckvEoZsqLVTHm7WyzCPh0PEHmD8VLW+6PCr2oHCn9KiVgLtcjuWRrzAVFLuP8sVLZ4Z5p+6LBe2m2t2nCPutasctNktQ90tH8CYaTaSyBW+6PW8ZVhJzMRC1k1fWhq
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31686004)(83380400001)(316002)(6512007)(26005)(8936002)(6916009)(86362001)(5660300002)(36756003)(6666004)(186003)(6506007)(53546011)(2616005)(54906003)(38100700002)(2906002)(508600001)(31696002)(6486002)(66556008)(4326008)(8676002)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6369
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2cd4a7ab-e09c-492f-0d38-08da2774fa13
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iMteELIlrbMs1SJVLGsAehHyj/I4olADr3HHO9GTLMGFk6X/Sp72JZDN0hjMsvVQPSX3TYipgHXEeXa7ZL3u1lbGl3gUDoIAyd+ty8qSNjwuJJRlEZZZZNV+jv8PLugBlLuehNODhGXia1Vvcrv/8SUULEGGeB1KPtqsdIvw0/2FwOyN0TDkAjx/JHWPNXi8Gh1fYg6hqD/fgtX91+rEw5bCu7LBhvDFFYamxxAF389wE3ca0+e+1C+02yntIQaT471VYac6iqH6DICYhiV5B7PNaxjulDV6rpoHROeQwyAnq8V9DzsSb2+UomoJlnAqoYr/nvyLT14AjxZftDToFCnw5cgP7wiVByrSrVz/g5WOOyvXY56wvAcbeVR3U4f/HV+M0iDF2E0yTsJvKUsurOGBxQtJl6Vg9AI1gRb2gD7afjuwl2R4bHi0TLbwKoujFME6vlIGDGIQv2u3B5hpi0o+6EFLCDK6LTIedxEHKROVJxO3jE+RuDsc3mWVi6XW9yARiG9g0fBG1xZKLkT4t4oloya4HM6KNo5jO3pJPTODdV7vTaTPvEBCKB40S2jyYdPiAxpOhCNn/GflK/ELo7zRBu94m70keB4FnDaBQ78mkGYVlSrP6BNxrAOkc85ffS2B5phmkItUgyCFDTIruFbzTKvPoSzVWyNSXwEx+QOrh5RxuQsC5QI0NcX63ayvaCaO3eEqmqnhnRuJZ2K9ug==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(2616005)(4326008)(8676002)(186003)(36756003)(336012)(47076005)(31686004)(81166007)(316002)(86362001)(31696002)(6862004)(36860700001)(8936002)(5660300002)(82310400005)(26005)(40460700003)(6512007)(70586007)(70206006)(83380400001)(6486002)(54906003)(508600001)(6506007)(53546011)(6666004)(2906002)(356005)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 11:07:49.2472
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 72356f91-fc81-4ad7-b4e3-08da27750017
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4363

Hi Jan,

On 2022/4/26 17:20, Jan Beulich wrote:
> On 18.04.2022 11:07, Wei Chen wrote:
>> --- a/xen/arch/x86/srat.c
>> +++ b/xen/arch/x86/srat.c
>> @@ -271,6 +271,35 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
>>   		       pxm, pa->apic_id, node);
>>   }
>>   
>> +/*
>> + * Check to see if there are other nodes within this node's range.
>> + * We just need to check full contains situation. Because overlaps
>> + * have been checked before by conflicting_memblks.
>> + */
>> +static bool __init check_node_memory_interleave(nodeid_t nid,
>> +                                                paddr_t start, paddr_t end)
>> +{
>> +	nodeid_t i;
>> +	const struct node *nd = &nodes[nid];
>> +
>> +	for_each_node_mask(i, memory_nodes_parsed)
>> +	{
>> +		/* Skip itself */
>> +		if (i == nid)
>> +			continue;
>> +
>> +		nd = &nodes[i];
>> +		if (start < nd->start && nd->end < end) {
>> +			printk(KERN_ERR
>> +			       "Node %u: (%"PRIpaddr"-%"PRIpaddr") interleaves with node %u (%"PRIpaddr"-%"PRIpaddr")\n",
>> +			       nid, start, end, i, nd->start, nd->end);
>> +			return true;
>> +		}
>> +	}
>> +
>> +	return false;
>> +}
>> +
>>   /* Callback for parsing of the Proximity Domain <-> Memory Area mappings */
>>   void __init
>>   acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
>> @@ -340,10 +369,22 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
> 
> Just up from here there already is overlap detection (via a call to
> conflicting_memblks(), and you even mention that in the earlier
> comment). If that doesn't cover all cases, I think it wants fixing
> there rather than introducing a 2nd checking function. But afaics
> that code covers the "fully contains" case.
> 

Yes, that makes sense, I will try to add this case check in 
conflicting_memblks.

Thanks,
Wei Chen

> Jan
> 
>>   			nd->start = start;
>>   			nd->end = end;
>>   		} else {
>> -			if (start < nd->start)
>> -				nd->start = start;
>> -			if (nd->end < end)
>> -				nd->end = end;
>> +			paddr_t new_start = nd->start;
>> +			paddr_t new_end = nd->end;
>> +
>> +			if (start < new_start)
>> +				new_start = start;
>> +			if (new_end < end)
>> +				new_end = end;
>> +
>> +			/* Check whether new range contains memory for other nodes */
>> +			if (check_node_memory_interleave(node, new_start, new_end)) {
>> +				bad_srat();
>> +				return;
>> +			}
>> +
>> +			nd->start = new_start;
>> +			nd->end = new_end;
>>   		}
>>   	}
>>   	printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIpaddr"-%"PRIpaddr"%s\n",
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 11:17:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 11:17:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313818.531579 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njJBu-0006Gd-Ot; Tue, 26 Apr 2022 11:17:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313818.531579; Tue, 26 Apr 2022 11:17:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njJBu-0006GW-LJ; Tue, 26 Apr 2022 11:17:10 +0000
Received: by outflank-mailman (input) for mailman id 313818;
 Tue, 26 Apr 2022 11:17:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=c92l=VE=alien8.de=bp@srs-se1.protection.inumbo.net>)
 id 1njJBs-0006GQ-NC
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 11:17:08 +0000
Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6779b7c2-c552-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 13:17:06 +0200 (CEST)
Received: from zn.tnic (p5de8eeb4.dip0.t-ipconnect.de [93.232.238.180])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 333FA1EC0503;
 Tue, 26 Apr 2022 13:17:01 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6779b7c2-c552-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
	t=1650971821;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
	bh=0/pzm9e2iDycI7rO928zqJLiV9GuD5I4xPzZfSe633g=;
	b=QKn7p9c+Xx58HkrgfK0vaZ0Hq8RwnOhXDyfVc1uhejI5I0GIt/UsYcC87wFSHsiwlfBDip
	KIXZVbnVxB9vh/6WhJoc0woZlZd+mvo/f1R0qgbcG+6qGZNU8S4gmoJ+P8RlLJPQXSVns4
	hu2B8sKa65pKnilCIQ3ZuI1qd8xMtrw=
Date: Tue, 26 Apr 2022 13:16:58 +0200
From: Borislav Petkov <bp@alien8.de>
To: Juergen Gross <jgross@suse.com>
Cc: Oleksandr <olekstysh@gmail.com>, Christoph Hellwig <hch@infradead.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Julien Grall <julien@xen.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Message-ID: <YmfUqlKnk0Mbmvpk@zn.tnic>
References: <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
 <abc5d23d-3d38-d198-4646-e886df2e83d4@suse.com>
 <YmZUpua3hkCPdbfx@infradead.org>
 <147f68f6-7d67-1884-bd14-5040639b3396@suse.com>
 <67c7460a-3001-35a6-8e5b-f367270b257a@gmail.com>
 <YmcR5bfaYh1z7VUq@zn.tnic>
 <7d89848a-3a1c-415d-957a-564ffdd3712d@suse.com>
 <YmewJaxWS1KGVkTf@zn.tnic>
 <cbd4cd8a-0271-5a53-4688-59d6cc6ee3db@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cbd4cd8a-0271-5a53-4688-59d6cc6ee3db@suse.com>

On Tue, Apr 26, 2022 at 11:36:40AM +0200, Juergen Gross wrote:
> As the suggestion was to add another flag this wouldn't be a problem IMO.

We had a problem already with adding one flag would break the same flag
on the other guest type. That's why we added cc_vendor too. So it can be
tricky.

> platform_has() doesn't seem too bad IMO.
> 
> I will write a patch for starting the discussion.

Yeah, I guess such a proposal would need a wider audience - maybe CC
linux-arch...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 11:29:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 11:29:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313824.531591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njJNJ-0007k5-RS; Tue, 26 Apr 2022 11:28:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313824.531591; Tue, 26 Apr 2022 11:28:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njJNJ-0007jy-Mf; Tue, 26 Apr 2022 11:28:57 +0000
Received: by outflank-mailman (input) for mailman id 313824;
 Tue, 26 Apr 2022 11:28:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njJNI-0007jo-2L; Tue, 26 Apr 2022 11:28:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njJNH-00031t-W4; Tue, 26 Apr 2022 11:28:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njJNH-0003PR-Kb; Tue, 26 Apr 2022 11:28:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njJNH-0007sQ-KA; Tue, 26 Apr 2022 11:28:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pQ0tIqpR0vgXrpUaiavYuPb1Zq++B2EBNF9kW+Mg9H4=; b=0Mbm7mjKfWgTnxRbmFJjZZUksY
	1Gc72Gb9IRHncxFrnE3SV/zSEKQfSCuy49UtGX7eIOm7iZPMJjpNvBjxzT/mD5SBgckR/L3ekVk3o
	dXrGjDPvws7rOt8AH4mIPgb4qZWyvtNufGpwD+A9e6krK6qMMTRZjmai5pENSSInTMkU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169733-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169733: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 11:28:55 +0000

flight 169733 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169733/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  639 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 11:40:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 11:40:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313832.531601 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njJXv-0000mc-RX; Tue, 26 Apr 2022 11:39:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313832.531601; Tue, 26 Apr 2022 11:39:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njJXv-0000mV-OX; Tue, 26 Apr 2022 11:39:55 +0000
Received: by outflank-mailman (input) for mailman id 313832;
 Tue, 26 Apr 2022 11:39:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njJXu-0000mL-OQ; Tue, 26 Apr 2022 11:39:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njJXu-0003D7-Lb; Tue, 26 Apr 2022 11:39:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njJXu-0003eV-AG; Tue, 26 Apr 2022 11:39:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njJXu-0000A3-9m; Tue, 26 Apr 2022 11:39:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XBE7WlqYMfdYDyfRVKTNDRW1UMtHTyMQPAJV8EbQ2DY=; b=Tv9Qux9bNuLu8/9tS7NgUPGkJM
	pnx81j+kOyrbghgqKMk3V4ealF71xoxJiKZnuSbsoKfLV6jj7oq0kzs99yOv32vYrDUJE8JuTPkLY
	hEV6qjhXBcF3HX76AnqffUWVX7TZjIrC9a2AFbcRho+zOvVppCh8olyVl3eebMDKnZYI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169727-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169727: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=de0a50833f91ad934d5492125b2d636c86a87140
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 11:39:54 +0000

flight 169727 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169727/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              de0a50833f91ad934d5492125b2d636c86a87140
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  655 days
Failing since        151818  2020-07-11 04:18:52 Z  654 days  636 attempts
Testing same since   169640  2022-04-23 04:18:54 Z    3 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 105272 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 12:10:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 12:10:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313849.531612 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njK1G-00053M-Mz; Tue, 26 Apr 2022 12:10:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313849.531612; Tue, 26 Apr 2022 12:10:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njK1G-00053F-Jl; Tue, 26 Apr 2022 12:10:14 +0000
Received: by outflank-mailman (input) for mailman id 313849;
 Tue, 26 Apr 2022 12:10:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuZH=VE=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1njK1E-000539-LY
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 12:10:12 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on060d.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::60d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d1de92ee-c559-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 14:10:11 +0200 (CEST)
Received: from AS9PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:20b:48b::24)
 by AM6PR08MB3653.eurprd08.prod.outlook.com (2603:10a6:20b:4c::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 12:10:09 +0000
Received: from AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:48b:cafe::95) by AS9PR04CA0075.outlook.office365.com
 (2603:10a6:20b:48b::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend
 Transport; Tue, 26 Apr 2022 12:10:09 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT050.mail.protection.outlook.com (10.152.17.47) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 12:10:08 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Tue, 26 Apr 2022 12:10:08 +0000
Received: from 2cda222bb88c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DCBAA8FB-CA31-47FB-BF45-DCD3C065EACD.1; 
 Tue, 26 Apr 2022 12:10:01 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2cda222bb88c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 12:10:01 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS4PR08MB7430.eurprd08.prod.outlook.com (2603:10a6:20b:4e2::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr
 2022 12:10:00 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 12:10:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1de92ee-c559-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oCKw1nkpsgceXVHb8Mi4DlC2gPqh+4l4lId6VzMWBRg=;
 b=c34mp695Unbmx6bTDMYt/4pEK5DW1jUPqIQtk32w8KEIufHCBQiaGpJZ0ayVhN5F9AKagIhMr83y6H68ZfCfo39uqVr2zXY7RyHrcdGqUP+h9Q9FI5B0ocNXqpx8fJMRWmliai+uJBYRWa1BuvPM45Pqhiwq8LiGc+LUF+BPKsI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f9014eba0ee3b770
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KPNR0prR1Hk6icDkPX7KiDEjxhlF+mlTLMiXskP07CGaU/tFw9zjGqA3A0GU4jhzSrhMDTF/cES0rvnlfk3dO11S28JGBBcA8lxvk6igdpRqtzu7tbl2hA1WHNfzyING8afk0TnRUxtqD9Gg01b5JaAKK7uXhXnkk+gn7e76VQ8WkDFXFE8U52EeihAS6bgrgg+ylGx4iFJXQZYoH1JH0FetbVJuxDfXQ1LuMstcfZLqkiPyvELRVR4SWkp9cjpSN0M3FIRyKYMrMLxyGMNt7FQ3+WHeaSQ0fFT/H89uMLIef/xhdpKCC2td9B9CEeU9FrvQpnpQMAj2VFdcZeRevA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oCKw1nkpsgceXVHb8Mi4DlC2gPqh+4l4lId6VzMWBRg=;
 b=ggHxmCGlf7ygPOkoApxW5+aAz872T+8+bo0PWg/GMXcood7DNm+Fu+RnWNiBVvx2il9AgZv6CA9tzObM6h7+wnMz1T6OA/Crn+NoRNuahgICDKDGPkaCZzkrMviE0KfvNQwjMqvIsDepTtUToaIyn+ebknvhcdcckWxafNtCcm1QO6h/ZHIQ+Pu6KRCfJFZkQlNjfJZ6SDkleh84F3Jda7d5ivoSwLplcX/a4Mjt+F9/HpoMlO5bPREv1/K5IZ+2HQC4qw1kA+UI1904JtSXnPzv+moYIza1B9KGPlZ5KtQVE9UCd09SDkYYEmwyY2vN195OOo/TD/ZFRlTVADuC/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oCKw1nkpsgceXVHb8Mi4DlC2gPqh+4l4lId6VzMWBRg=;
 b=c34mp695Unbmx6bTDMYt/4pEK5DW1jUPqIQtk32w8KEIufHCBQiaGpJZ0ayVhN5F9AKagIhMr83y6H68ZfCfo39uqVr2zXY7RyHrcdGqUP+h9Q9FI5B0ocNXqpx8fJMRWmliai+uJBYRWa1BuvPM45Pqhiwq8LiGc+LUF+BPKsI=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH] EFI: don't mistakenly delete a file we never installed
Thread-Topic: [PATCH] EFI: don't mistakenly delete a file we never installed
Thread-Index: AQHYWJHnY72yQgrHIUiap4LuJb9TMa0CG/WA
Date: Tue, 26 Apr 2022 12:10:00 +0000
Message-ID: <3627405C-9D5A-45F8-8ABD-CE46D30C8BB5@arm.com>
References: <55e50138-1d41-1e79-f269-df875473b1d2@suse.com>
In-Reply-To: <55e50138-1d41-1e79-f269-df875473b1d2@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: e0f5c563-4ac6-4831-2270-08da277db4eb
x-ms-traffictypediagnostic:
	AS4PR08MB7430:EE_|AM5EUR03FT050:EE_|AM6PR08MB3653:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB365309E3F02D03C8E38EF8089DFB9@AM6PR08MB3653.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0D1YARbhBa5ArqHAiK3BywZv7Uz45li/QmUruTAXii2HE1TG6Jg15/srNxYUvfWUsq0GDCgQyBx8Zmo61CVc3FGWh0IReg4gsr9ARiOfYTQvYGAzECKD94nM6jZRW35SUgi20pSmHkFLaMnTAAele3rbpIs4jtdEzhVeU04qUSJsOVQqZMR8MTUwoBTI81i/UrLoNHI/SGQXGG6fKj6ClMj4EIt3UisEGVDpOmdp5Lr3vA3mShovVAyoMScunBRJBsG7T+t6bv62tltQJ6jgnj88KYvt9vJsANEO/zL52T2C+pO298ghhHtKlAUZPa6fX+riiwjpUdwHDYxxQ1yl3vuzHYwXfaAzAzTnXksWfEOlp7FjsKPFnpiPjxUC7MJLIakDSN5LS+8XNu5c7ItJEkQJi3UJqMf6u/DZz0o2qYFEK0RoprLVauu0uOUbHsBpTAwgPpo4QxjGLMr833C5KZZrNVzoK305q5uINjczuNnrgTNRFkLo16G+dM+O9yUvcNjklu1eLjjXZPxfHM1US5ypFXhGzkKKJee0Bz80LF6H1HwNVMP7QzENm7Ts/aErlX+T4Xgc8A3X3Byd29HL/cYpvt7kqvIRZfWYmHjy19WQoWywVRC38do/UP0rewSH3AzZFiXUm9GHb55IR50qzx1TRzEgFUWNnb3dphTRxdN7g1ayxdeNg18WNtZcFjQLNMA7JM/d2D2QzePqrFC6iLAqPjYJt22Ib26Trxw4lURY+7HdNk0FDdbtMT3/3GET
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(2906002)(91956017)(4744005)(6506007)(2616005)(71200400001)(53546011)(6916009)(64756008)(66946007)(76116006)(8676002)(66446008)(33656002)(316002)(4326008)(5660300002)(8936002)(36756003)(66476007)(66556008)(6486002)(54906003)(6512007)(26005)(38070700005)(122000001)(38100700002)(508600001)(186003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31EA3147A65F6343BC2A6B906842790F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7430
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	025e20f1-75d7-4d6f-84f9-08da277daff5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	krVgezGzwoteG3HJjlACfcYmNuOCdOGkLO5fP5wFUy0p9mqI/VuYg0OhR6DTptEZzENhUc4kvNQ9RS/s5mOmLkSmHIfz/ejo95380MKFkkClE98VVi5pq/eXi8HpV99cgoQ7dqZhx4t1K6Q41PBrjTi2WmA5vwlC/ScGF4GvjN1nzsFHixiHqvIuhWdoGlJYBM6ZGdB4/tkYZycX6YjkE/IDJKQoPmPWwhT4Fqkup8ZHi9EiVy1p9W8WVV4uyeSenztLn8NAJEaMfOEhkrQH60T0+7iCrCbVUApKbsp2DpUir45QeOl+Mm1o72lGTNkQ993EdvRTxt0b+Z3/yhACXYe81gJiQcYaZOKIoEARFjKV8GHRutNHWqvrKDx6H2+vByQ32FHkleuy78YYFnOKEtH7Ks4/w3GEQsJETb0irMZpKODW+y/mRej3h93KwwA16OiaEv2Z1AbBx/iDLenjJL6ZRbFFtlJM+2/3oc0ZVQC5VajVyM/bZGZujdY1VmoHRnZwfzNmkNtEIXGYNrEMEBhJN1MpjFiY+4yvW+x9IIfHaibZB0ZTglX60PP5/IhYdAz4EkCMWA0ZDAyT3Ktj1lKmdrHp/0itLR8nuonsKAXIr6WUzVRMIHQHtoduAdFGb4DM22wdEMggQR9Tg4968TkHaYbzDByIBZ1ls7GIFzYCIAa5eJeMM8fwONMRUUxU
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(316002)(6512007)(26005)(8936002)(86362001)(5660300002)(36860700001)(33656002)(47076005)(81166007)(186003)(36756003)(6506007)(53546011)(2616005)(54906003)(4744005)(82310400005)(2906002)(508600001)(6486002)(356005)(40460700003)(8676002)(70586007)(4326008)(6862004)(70206006)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 12:10:08.5425
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e0f5c563-4ac6-4831-2270-08da277db4eb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3653

Hi Jan,

> On 25 Apr 2022, at 11:47, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> Just like for "install", make dealing with xen.efi on the EFI partition
> dependent upon mount point and vendor directory being known.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

>=20
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -515,7 +515,9 @@ _uninstall:
> 	rm -f $(D)$(DEBUG_DIR)/$(T)-$(XEN_FULLVERSION).efi.map
> 	rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi
> 	rm -f $(D)$(EFI_DIR)/$(T).efi
> -	rm -f $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).e=
fi
> +	if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \
> +		rm -f $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).=
efi; \
> +	fi
>=20
> .PHONY: _debug
> _debug:
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 12:26:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 12:26:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313855.531623 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKHC-0006bL-3L; Tue, 26 Apr 2022 12:26:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313855.531623; Tue, 26 Apr 2022 12:26:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKHC-0006bE-0G; Tue, 26 Apr 2022 12:26:42 +0000
Received: by outflank-mailman (input) for mailman id 313855;
 Tue, 26 Apr 2022 12:26:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuZH=VE=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1njKH9-0006b7-Mz
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 12:26:39 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on060f.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::60f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e9ab812-c55c-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 14:26:38 +0200 (CEST)
Received: from DB6P191CA0018.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::28) by
 DB7PR08MB3756.eurprd08.prod.outlook.com (2603:10a6:10:79::20) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.13; Tue, 26 Apr 2022 12:26:35 +0000
Received: from DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:28:cafe::5b) by DB6P191CA0018.outlook.office365.com
 (2603:10a6:6:28::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Tue, 26 Apr 2022 12:26:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT054.mail.protection.outlook.com (10.152.20.248) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 12:26:34 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Tue, 26 Apr 2022 12:26:34 +0000
Received: from 4bb3d6bd8488.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B4D65FD0-0894-42CE-B3E3-C8081EBF12B0.1; 
 Tue, 26 Apr 2022 12:26:28 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4bb3d6bd8488.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 12:26:28 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB8064.eurprd08.prod.outlook.com (2603:10a6:20b:54d::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr
 2022 12:26:26 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 12:26:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e9ab812-c55c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KNUztbPFo3Lr9FHKh0MxM/uivONhzKNC1jZQvPVxjdM=;
 b=BcXj/TJcfBZR8cwPn+Yk+ni+vmiFWY0aKhAowybT7j1H1gHxcqBtbUE4BDNqvXTvXjGwQ0uNcx1CKg76ON52gfcRxWsHaEmThiPIK0EQUCsPNB8REg9tccic2hRnaefEHQKUEyq+eE+FVkTOCStqf+6OtyKKnRGF0oFd7qBLHOg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f5e674d52120ff84
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jebITiMSQi0k0NeAz+8J65Dkiez/w+WKRpBwCBZUsxnQNNbU3N/STtzV6iNUaIqr3u+hpfzkkTcusrhlWsobP0/ZyAVUEWGozgGLrkVuLsSmybc1N21esmr1kgI+cIveOaHQplK9Xkb4Oi162zW+x0FIAe/UigXCkyf6ODrXsxgQYIor89VltuFfFZq7cZfUTduFQyCli4DhMMl2Cice/TfVt4d9RAMY7a9W1BM1BpsRJ0zW2apBhps1PFl2pROYFnk0rFA/6zh5L4roWkT14P33d+vx9yVqqfnPzBkRepm83Hwfu3mARaoK2g78vc4srE2fVl8x73yWyybw6rqw7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KNUztbPFo3Lr9FHKh0MxM/uivONhzKNC1jZQvPVxjdM=;
 b=fpWR+RGgcM48dI75Ia3IbZ20h3IgJ+DUKXpkFYNIp2hDI2lFSfjVDUjGOqWt5YTmn+qUPt0ppRVBNa96J4r0UgTP08xdxx+WLXiZj/78UtyKJLy6fAgVDEKK0MyVLnWi8RMrPcKx/vQTjGBHl7CcUHUqz4wYon/Zsm114JYNNU85lFrZGf0DFrcZ2Z+Vf47fqmMzrvevMCQTXaaqrPQG5KZOTebgXZIabFt9LqP0/gnTiGOR6p1F2Qq6NnCYP5kNFHahQsSZ03rvrSznJeB88tzqRBFF+tfYFMYUYxlLW3v6J7dPZWQs6Ub3BmwmYcDZgf5xftL2xded9ncf1lhsQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KNUztbPFo3Lr9FHKh0MxM/uivONhzKNC1jZQvPVxjdM=;
 b=BcXj/TJcfBZR8cwPn+Yk+ni+vmiFWY0aKhAowybT7j1H1gHxcqBtbUE4BDNqvXTvXjGwQ0uNcx1CKg76ON52gfcRxWsHaEmThiPIK0EQUCsPNB8REg9tccic2hRnaefEHQKUEyq+eE+FVkTOCStqf+6OtyKKnRGF0oFd7qBLHOg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH RFC] EFI: strip xen.efi when putting it on the EFI
 partition
Thread-Topic: [PATCH RFC] EFI: strip xen.efi when putting it on the EFI
 partition
Thread-Index: AQHYWJHILrDj2EEGDUWtEVYmIvMHMK0CII4A
Date: Tue, 26 Apr 2022 12:26:26 +0000
Message-ID: <DFF300CA-944E-47D9-9674-6858790D45C2@arm.com>
References: <394c1b94-beaf-bdcb-c333-65dd9987be54@suse.com>
In-Reply-To: <394c1b94-beaf-bdcb-c333-65dd9987be54@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 401b9f54-094a-4a93-f219-08da278000ba
x-ms-traffictypediagnostic:
	AS8PR08MB8064:EE_|DB5EUR03FT054:EE_|DB7PR08MB3756:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB37563505E234CFCFFB132A149DFB9@DB7PR08MB3756.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 p/vPayEi3jQETSOJRiKCt1NJSvUnOyyHOGXzJREPAcBiEtHQZg58zlISMQ/iLHRFtA+mOpWswCqaLg+GqVqIs4iMOv4QPdOINieQYhgYck8UpELuP5a4pMGNChnD2ckzepZU6uZ0pnRqEcCekiAnD0gLdb4uAvoJ4E5R6VXKiCKaPmxgG69wXwsCGQMV6dAxUCmKsqextOUxXL0eY+6sv6oWtebY/Eqr57kqrVWzhpoqqmv+zqqeVTGS29R5dvPQT/ptjiDn9KGYlcDMK5WfCZG2/my5k1nimQtY5PQ5SokYXwEUOjdGKoWotiwBgWMmcAO2VY1XO898DQT1XI9V+cqbjdm57H4CuHoyVcArs+nO9I0sScSXzCUY3YO+fInZgzrCQxDCSX/H/VguzgKMQpOHkPW4lsAyCVSpxic2s0ULBDuQbCvTFtMq48NDuo8O1fvqiPecoPf/GaVJUWsFIOJKBXtHfswVv0AL5RvZ8JtMHM7XAy/KhkXE3LGwaXWB7HT/NwP+6i5ODiNuKZIt8ZU7hroBuw/KVu1OlOp8++NIjvb4NrsO6eW27A/oRr+h43wokg2oA0HCXO8TvGsxR6L01ppvLmlvWBFlBMQ+tEpWy8iV8u5CKNW+SoSk7iTEsdHE0ZwNe2wfe4JVkQkpx+Hy25aB2/sT3owp4dUXhWq+HUSY/ndW7D1LhTB2ceDaUFYyhLr5FfYBYoNYtJByU+TZjUS6evvIea70rDT7VOiNtF6hWbUIJ6+K+J80MRiU
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(64756008)(66556008)(186003)(66476007)(66446008)(4326008)(5660300002)(66946007)(38100700002)(36756003)(38070700005)(26005)(6506007)(6512007)(53546011)(6916009)(316002)(76116006)(86362001)(54906003)(122000001)(2616005)(33656002)(6486002)(2906002)(83380400001)(508600001)(71200400001)(8936002)(91956017)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <3AB5A1C968F2464E8AA9BCECDC12EF32@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8064
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ea85392e-ec76-44a7-83b7-08da277ffbfa
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/ZaQYPLrVKy9E731ehp79QvdwQZRm8iDjcA45sSz5fOAmPrcSPzSDTCJCn6CEu1XmL6Nte6IWIjVJlU+083rVpHqNwO2yoI3ZW0U72AUkurFIjVQtkh0NSHpmAw0jc+3+o3he5nP1LqrVIguAOJic/g5TKq7u5w395Hm35HxEr7uJYKLx5VBBBuVo6ucohZREHDcPku/ml9IvVIjOz7ivcdCKmrvNDPcx4USGv7gyBvf34imH/kjC6DARFWu6PzdmxdFpHIgdnoyRgyOXDaY5F+eWpkKotueSj4uX3WZOpdMkHZ6UR4yzyZ7riL/wqm9Y0iQL6Juizmb6xrQ+8xBt+QaQbOONhm1BMSpBuPTKry4uOTBImJJMZDT1d3uIr/ayjnObHH+4eQKz6r2GVVAALzWDnuLonM4Rlq6TAkQ8TP3tmvSkO1pF/jTjW1LitZB8HEKWz79tBln9TQdrGf/Sew/OgLVwHujjwgVh1ZQ9iVcBHP54BBA4oLPY1ZEf+OCHKz2GMq2506+9CCuN5w99QPbgmSba0i92ctvDYJgdQCVa5yk6ZqXGs//FsKSVUtMol5wZw9vJ3CnuapDnE3PpXnoI2knn2i+qoXDtLb6z9SUVSIiqh03Kl71/qo4QWuGU0zETOzJ7iBilfCtCROandNuUvrazyc1Dul9LAfXP5JSVRyAJBTE4cZ2+djIG3gN
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(70586007)(47076005)(6862004)(8936002)(4326008)(2616005)(33656002)(8676002)(70206006)(86362001)(508600001)(83380400001)(6486002)(356005)(6506007)(53546011)(40460700003)(2906002)(6512007)(336012)(5660300002)(82310400005)(81166007)(26005)(54906003)(186003)(36860700001)(36756003)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 12:26:34.7739
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 401b9f54-094a-4a93-f219-08da278000ba
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3756

SGkgSmFuLA0KDQo+IE9uIDI1IEFwciAyMDIyLCBhdCAxMTo0NiwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IFdpdGggZGVidWcgaW5mbyByZXRhaW5lZCwgeGVu
LmVmaSBjYW4gYmUgcXVpdGUgbGFyZ2UuIFVubGlrZSBmb3IgeGVuLmd6DQo+IHRoZXJlJ3Mgbm8g
aW50ZXJtZWRpYXRlIHN0ZXAgKG1rZWxmMzIgdGhlcmUpIGludm9sdmVkIHdoaWNoIHdvdWxkIHN0
cmlwDQo+IGRlYnVnIGluZm8ga2luZCBvZiBhcyBhIHNpZGUgZWZmZWN0LiBXaGlsZSB0aGUgaW5z
dGFsbGluZyBvZiB4ZW4uZWZpIG9uDQo+IHRoZSBFRkkgcGFydGl0aW9uIGlzIGFuIG9wdGlvbmFs
IHN0ZXAgKGludGVuZGVkIHRvIGJlIGEgY291cnRlc3kgdG8gdGhlDQo+IGRldmVsb3BlciksIGFk
anVzdCBpdCBhbHNvIGZvciB0aGUgcHVycG9zZSBvZiBkb2N1bWVudGluZyB3aGF0IGRpc3Ryb3MN
Cj4gd291bGQgYmUgZXhwZWN0ZWQgdG8gZG8gZHVyaW5nIGJvb3QgbG9hZGVyIGNvbmZpZ3VyYXRp
b24gKHdoaWNoIGlzIHdoYXQNCj4gd291bGQgbm9ybWFsbHkgcHV0IHhlbi5lZmkgaW50byB0aGUg
RUZJIHBhcnRpdGlvbikuDQo+IA0KPiBNb2RlbCB0aGUgY29udHJvbCBvdmVyIHN0cmlwcGluZyBh
ZnRlciBMaW51eCdlcyBtb2R1bGUgaW5zdGFsbGF0aW9uLA0KPiBleGNlcHQgdGhhdCB0aGUgc3Ry
aXBwZWQgZXhlY3V0YWJsZSBpcyBjb25zdHJ1Y3RlZCBpbiB0aGUgYnVpbGQgYXJlYQ0KPiBpbnN0
ZWFkIG9mIGluIHRoZSBkZXN0aW5hdGlvbiBsb2NhdGlvbi4gVGhpcyBpcyB0byBjb25zZXJ2ZSBv
biBzcGFjZQ0KPiB1c2VkIHRoZXJlIC0gRUZJIHBhcnRpdGlvbnMgdGVuZCB0byBiZSBvbmx5IGEg
ZmV3IGh1bmRyZWQgTWIgaW4gc2l6ZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNo
IDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gLS0tDQo+IFJGQzogR05VIHN0cmlwIDIuMzggYXBwZWFy
cyB0byBoYXZlIGlzc3VlcyB3aGVuIGFjdGluZyBvbiBhIFBFIGJpbmFyeToNCj4gICAgIC0gdGhl
IG5ldyBmaWxlIHBvc2l0aW9ucyBvZiB0aGUgc2VjdGlvbnMgZG8gbm90IHJlc3BlY3QgdGhlIGZp
bGUNCj4gICAgICAgYWxpZ25tZW50IHNwZWNpZmllZCBieSB0aGUgaGVhZGVyIChhIHJlc3VsdGlu
ZyBsb29rcyB0byB3b3JrIG9uDQo+ICAgICAgIG9uZSBFRkkgaW1wbGVtZW50YXRpb24gd2hlcmUg
SSBkaWQgYWN0dWFsbHkgdHJ5IGl0LCBidXQgSSBkb24ndA0KPiAgICAgICB0aGluayB3ZSBjYW4g
cmVseSBvbiB0aGF0KSwNCj4gICAgIC0gZmlsZSBuYW1lIHN5bWJvbHMgYXJlIGFsc28gc3RyaXBw
ZWQ7IHdoaWxlIHRoZXJlIGlzIGEgc2VwYXJhdGUNCj4gICAgICAgLS1rZWVwLWZpbGUtc3ltYm9s
cyBvcHRpb24gKHdoaWNoIEkgd291bGQgaGF2ZSB0aG91Z2h0IHRvIGJlIG9uDQo+ICAgICAgIGJ5
IGRlZmF1bHQgYW55d2F5KSwgaXRzIHVzZSBtYWtlcyBubyBkaWZmZXJlbmNlLg0KPiAgICAgT2xk
ZXIgR05VIHN0cmlwIChvYnNlcnZlZCB3aXRoIDIuMzUuMSkgZG9lc24ndCB3b3JrIGF0IGFsbCAo
IkRhdGENCj4gICAgIERpcmVjdG9yeSBzaXplICgxYykgZXhjZWVkcyBzcGFjZSBsZWZ0IGluIHNl
Y3Rpb24gKDgpIikuDQo+IA0KPiAtLS0gYS94ZW4vTWFrZWZpbGUNCj4gKysrIGIveGVuL01ha2Vm
aWxlDQo+IEBAIC00NjEsNiArNDYxLDIyIEBAIGVuZGlmDQo+IC5QSE9OWTogX2J1aWxkDQo+IF9i
dWlsZDogJChUQVJHRVQpJChDT05GSUdfWEVOX0lOU1RBTExfU1VGRklYKQ0KPiANCj4gKyMgU3Ry
aXANCj4gKyMNCj4gKyMgSU5TVEFMTF9FRklfU1RSSVAsIGlmIGRlZmluZWQsIHdpbGwgY2F1c2Ug
eGVuLmVmaSB0byBiZSBzdHJpcHBlZCBiZWZvcmUgaXQNCj4gKyMgaXMgaW5zdGFsbGVkLiBJZiBJ
TlNUQUxMX0VGSV9TVFJJUCBpcyAnMScsIHRoZW4gdGhlIGRlZmF1bHQgb3B0aW9uDQo+ICsjIC0t
c3RyaXAtZGVidWcgd2lsbCBiZSB1c2VkLiBPdGhlcndpc2UsIElOU1RBTExfRUZJX1NUUklQIHZh
bHVlIHdpbGwgYmUgdXNlZA0KPiArIyBhcyB0aGUgb3B0aW9uKHMpIHRvIHRoZSBzdHJpcCBjb21t
YW5kLg0KPiAraWZkZWYgSU5TVEFMTF9FRklfU1RSSVANCj4gKw0KPiAraWZlcSAoJChJTlNUQUxM
X0VGSV9TVFJJUCksMSkNCj4gK2VmaS1zdHJpcC1vcHQgOj0gLS1zdHJpcC1kZWJ1Zw0KPiArZWxz
ZQ0KPiArZWZpLXN0cmlwLW9wdCA6PSAkKElOU1RBTExfRUZJX1NUUklQKQ0KPiArZW5kaWYNCj4g
Kw0KPiArZW5kaWYNCg0KVGhpcyBkb2VzIHNvdW5kIHZlcnkgY29tcGxleCBhbmQgdXNpbmcgY29t
YmluYXRpb24gb2YgaWZkZWYgYW5kIGlmZXEgb24gYW4gZXh0ZXJuYWwgdmFyaWFibGUgaXMgbm90
IGRvbmUgYW55d2hlcmUgZWxzZS4NCg0KSG93IGFib3V0IHNwbGl0dGluZyBpbnRvIGEgdmFyaWFi
bGUgdG8gdHVybiBzdHJpcCBvbiBvciBvZmYgYW5kIGxldCB0aGUgdXNlciBvdmVycmlkZSBhIGxv
Y2FsIHZhcmlhYmxlIHNldHRpbmcgdXAgdGhlIHN0cmlwIG9wdGlvbnMgaWYgaGUgd2FudHMgdG8g
Pw0KDQpTb21ldGhpbmcgbGlrZToNCg0KRUZJX1NUUklQX09QVElPTiA/PSAi4oCUc3RyaXAtZGVi
dWciDQoNCkFuZCB0aGVuIGp1c3QgdXNpbmcgSU5TVEFMTF9FRklfU1RSSVAgdG8gc3RyaXAgb3Ig
bm90IGR1cmluZyB0aGUgX2luc3RhbGwgcGhhc2UgDQoNCk9uZSB3YW50aW5nIHRvIHVzZSBubyBz
cGVjaWZpYyBvcHRpb24gd291bGQgaGF2ZSB0byBwYXNzIElOU1RBTExfRUZJX1NUUklQPTEgRUZJ
X1NUUklQX09QVElPTj3igJzigJ0gZm9yIGV4YW1wbGUuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0K
PiArDQo+IC5QSE9OWTogX2luc3RhbGwNCj4gX2luc3RhbGw6IEQ9JChERVNURElSKQ0KPiBfaW5z
dGFsbDogVD0kKG5vdGRpciAkKFRBUkdFVCkpDQo+IEBAIC00ODUsNiArNTAxLDkgQEAgX2luc3Rh
bGw6ICQoVEFSR0VUKSQoQ09ORklHX1hFTl9JTlNUQUxMXw0KPiAJCWxuIC1zZiAkKFQpLSQoWEVO
X0ZVTExWRVJTSU9OKS5lZmkgJChEKSQoRUZJX0RJUikvJChUKS0kKFhFTl9WRVJTSU9OKS5lZmk7
IFwNCj4gCQlsbiAtc2YgJChUKS0kKFhFTl9GVUxMVkVSU0lPTikuZWZpICQoRCkkKEVGSV9ESVIp
LyQoVCkuZWZpOyBcDQo+IAkJaWYgWyAtbiAnJChFRklfTU9VTlRQT0lOVCknIC1hIC1uICckKEVG
SV9WRU5ET1IpJyBdOyB0aGVuIFwNCj4gKwkJCSQoaWYgJChlZmktc3RyaXAtb3B0KSwgXA0KPiAr
CQkJICAgICAkKFNUUklQKSAkKGVmaS1zdHJpcC1vcHQpIC1wIC1vICQoVEFSR0VUKS5lZmkuc3Ry
aXBwZWQgJChUQVJHRVQpLmVmaSAmJiBcDQo+ICsJCQkgICAgICQoSU5TVEFMTF9EQVRBKSAkKFRB
UkdFVCkuZWZpLnN0cmlwcGVkICQoRCkkKEVGSV9NT1VOVFBPSU5UKS9lZmkvJChFRklfVkVORE9S
KS8kKFQpLSQoWEVOX0ZVTExWRVJTSU9OKS5lZmkgfHwpIFwNCj4gCQkJJChJTlNUQUxMX0RBVEEp
ICQoVEFSR0VUKS5lZmkgJChEKSQoRUZJX01PVU5UUE9JTlQpL2VmaS8kKEVGSV9WRU5ET1IpLyQo
VCktJChYRU5fRlVMTFZFUlNJT04pLmVmaTsgXA0KPiAJCWVsaWYgWyAiJChEKSIgPSAiJChwYXRz
dWJzdCAkKHNoZWxsIGNkICQoWEVOX1JPT1QpICYmIHB3ZCkvJSwlLCQoRCkpIiBdOyB0aGVuIFwN
Cj4gCQkJZWNobyAnRUZJIGluc3RhbGxhdGlvbiBvbmx5IHBhcnRpYWxseSBkb25lIChFRklfVkVO
RE9SIG5vdCBzZXQpJyA+JjI7IFwNCj4gDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 12:30:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 12:30:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313861.531633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKKn-0007xl-JZ; Tue, 26 Apr 2022 12:30:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313861.531633; Tue, 26 Apr 2022 12:30:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKKn-0007xe-Gp; Tue, 26 Apr 2022 12:30:25 +0000
Received: by outflank-mailman (input) for mailman id 313861;
 Tue, 26 Apr 2022 12:30:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njKKn-0007xU-3C; Tue, 26 Apr 2022 12:30:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njKKm-00046g-Ud; Tue, 26 Apr 2022 12:30:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njKKm-0004k2-J5; Tue, 26 Apr 2022 12:30:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njKKm-00054F-Ia; Tue, 26 Apr 2022 12:30:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rHzZIcLH13s00kwnX/TBoHLvpwoEev8/EWcwCFvqV4s=; b=UC7ekLb93AyozueGEagOuSTLhC
	wSSqtNb4M4INqED/d9H/jr4m4BjLNM3+d/JW5h3+2txGThkN00Qcb/amuKPIRgmr+vtl4HhVQ2Ew+
	f2rGrjH6P8dBVZ5Y6HiQv+Hi0R2Q/HqBaszRhgyBZiuLcoyf8PkLYJNsfUMcQiQOZRp0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169734-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169734: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 12:30:24 +0000

flight 169734 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169734/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  640 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 12:39:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 12:39:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313870.531645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKT5-0000II-Jd; Tue, 26 Apr 2022 12:38:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313870.531645; Tue, 26 Apr 2022 12:38:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKT5-0000IB-Gd; Tue, 26 Apr 2022 12:38:59 +0000
Received: by outflank-mailman (input) for mailman id 313870;
 Tue, 26 Apr 2022 12:38:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuZH=VE=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1njKT4-0000I5-EQ
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 12:38:58 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id d6d4e53e-c55d-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 14:38:57 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7939823A;
 Tue, 26 Apr 2022 05:38:56 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 282903F774;
 Tue, 26 Apr 2022 05:38:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6d4e53e-c55d-11ec-8fc2-03012f2f19d4
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Michal Orzel <michal.orzel@arm.com>
Subject: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules
Date: Tue, 26 Apr 2022 13:38:41 +0100
Message-Id: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

cppcheck can be used to check Xen code quality.

To create a report do "make cppcheck" on a built tree adding any options
you added during the process you used to build xen (like CROSS_COMPILE
or XEN_TARGET_ARCH). This will generate an xml report xen-cppcheck.xml.

To create a html report do "make cppcheck-html" in the same way and a
full report to be seen in a browser will be generated in
cppcheck-htmlreport/index.html.

For better results it is recommended to build your own cppcheck from the
latest sources that you can find at [1].
Development and result analysis has been done with cppcheck 2.7.

The Makefile rule is searching for all C files which have been compiled
(ie which have a generated .o file) and is running cppcheck on all of
them using the current configuration of xen so only the code actually
compiled is checked.

A new tool is introduced to merge all cppcheck reports into one global
report including all findings and removing duplicates.

Some extra variables can be used to customize the report:
- CPPCHECK can be used to give the full path to the cppcheck binary to
use (default is to use the one from the standard path).
- CPPCHECK_HTMLREPORT can be used to give the full path to
cppcheck-htmlreport (default is to use the one from the standard path).

This has been tested on several arm configurations (x86 should work but
has not been tested).

[1] https://cppcheck.sourceforge.io/

Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes in v3:
- add more checks in merge script and catch all possible exception from
the xml parser (suggested by Stefano)
Changes in v2:
- catch parsing errors during merge and tell the user to update cppcheck
- fix alignments in Makefile
- use srctree and objtree instead of BASEDIR
- remove SCTLR invalid change
- add a check of cppcheck version and mandate version 2.7 or greater
- rework a bit the merge script to make it faster and display progress
---
 .gitignore                           |  3 +
 xen/Makefile                         | 84 ++++++++++++++++++++++++++-
 xen/arch/arm/include/asm/processor.h |  2 +
 xen/include/xen/config.h             |  4 ++
 xen/include/xen/kconfig.h            |  5 ++
 xen/tools/merge_cppcheck_reports.py  | 86 ++++++++++++++++++++++++++++
 6 files changed, 182 insertions(+), 2 deletions(-)
 create mode 100755 xen/tools/merge_cppcheck_reports.py

diff --git a/.gitignore b/.gitignore
index c6d2c4b4f1..18ef56a780 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,7 @@
 *.o
 *.d
 *.d2
+*.c.cppcheck
 *.opic
 *.a
 *.so
@@ -296,6 +297,7 @@ xen/.banner
 xen/.config
 xen/.config.old
 xen/.xen.elf32
+xen/xen-cppcheck.xml
 xen/System.map
 xen/arch/x86/boot/mkelf32
 xen/arch/x86/boot/cmdline.S
@@ -316,6 +318,7 @@ xen/arch/*/efi/runtime.c
 xen/arch/*/include/asm/asm-offsets.h
 xen/common/config_data.S
 xen/common/config.gz
+xen/cppcheck-htmlreport
 xen/include/headers*.chk
 xen/include/compat/*
 xen/include/config/
diff --git a/xen/Makefile b/xen/Makefile
index ec34524ed2..255360440e 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -449,7 +449,7 @@ endif # need-config
 
 __all: build
 
-main-targets := build install uninstall clean distclean MAP
+main-targets := build install uninstall clean distclean MAP cppcheck cppcheck-html
 .PHONY: $(main-targets)
 ifneq ($(XEN_TARGET_ARCH),x86_32)
 $(main-targets): %: _% ;
@@ -537,15 +537,17 @@ _clean:
 	$(Q)$(MAKE) $(clean)=tools/kconfig
 	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
 		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
-		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
+		-o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \
 		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
 	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map
 	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
 	rm -f .banner .allconfig.tmp include/xen/compile.h
+	rm -f xen-cppcheck.xml
 
 .PHONY: _distclean
 _distclean: clean
 	rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS .config source
+	rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR)
 
 $(TARGET).gz: $(TARGET)
 	gzip -n -f -9 < $< > $@.new
@@ -619,6 +621,84 @@ cloc:
 	    done; \
 	done | cloc --list-file=-
 
+# What cppcheck command to use.
+# To get proper results, it is recommended to build cppcheck manually from the
+# latest source and use CPPCHECK to give the full path to the built version.
+CPPCHECK ?= cppcheck
+
+# What cppcheck-htmlreport to use.
+# If you give the full path to a self compiled cppcheck, this should be set
+# to the full path to cppcheck-html in the htmlreport directory of cppcheck.
+# On recent distribution, this is available in the standard path.
+CPPCHECK_HTMLREPORT ?= cppcheck-htmlreport
+
+# By default we generate the report in cppcheck-htmlreport directory in the
+# build directory. This can be changed by giving a directory in this variable.
+CPPCHECK_HTMLREPORT_OUTDIR ?= cppcheck-htmlreport
+
+# Compile flags to pass to cppcheck:
+# - include directories and defines Xen Makefile is passing (from CFLAGS)
+# - include config.h as this is passed directly to the compiler.
+# - define CPPCHECK as we use to disable or enable some specific part of the
+#   code to solve some cppcheck issues.
+# - explicitely enable some cppcheck checks as we do not want to use "all"
+#   which includes unusedFunction which gives wrong positives as we check file
+#   per file.
+#
+# Compiler defines are in compiler-def.h which is included in config.h
+#
+CPPCHECKFLAGS := -DCPPCHECK --max-ctu-depth=10 \
+                 --enable=style,information,missingInclude \
+                 --include=$(srctree)/include/xen/config.h \
+                 -I $(srctree)/xsm/flask/include \
+                 -I $(srctree)/include/xen/libfdt \
+                 $(filter -D% -I%,$(CFLAGS))
+
+# We need to find all C files (as we are not checking assembly files) so
+# we find all generated .o files which have a .c corresponding file.
+CPPCHECKFILES := $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c, \
+                 $(filter-out $(objtree)/tools/%, \
+                 $(shell find $(objtree) -name "*.o"))))
+
+quiet_cmd_cppcheck_xml = CPPCHECK $(patsubst $(srctree)/%,%,$<)
+cmd_cppcheck_xml = $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \
+                   --output-file=$@ $<
+
+quiet_cmd_merge_cppcheck_reports = CPPCHECK-MERGE $@
+cmd_merge_cppcheck_reports = $(srctree)/tools/merge_cppcheck_reports.py $^ $@
+
+quiet_cmd_cppcheck_html = CPPCHECK-HTML $<
+cmd_cppcheck_html = $(CPPCHECK_HTMLREPORT) --file=$< --source-dir=$(srctree) \
+                    --report-dir=$(CPPCHECK_HTMLREPORT_OUTDIR) --title=Xen
+
+PHONY += _cppcheck _cppcheck-html cppcheck-version
+
+_cppcheck-html: xen-cppcheck.xml
+	$(call if_changed,cppcheck_html)
+
+_cppcheck: xen-cppcheck.xml
+
+xen-cppcheck.xml: $(patsubst $(srctree)/%.c,$(objtree)/%.c.cppcheck,$(CPPCHECKFILES))
+ifeq ($(CPPCHECKFILES),)
+	$(error Please build Xen before running cppcheck)
+endif
+	$(call if_changed,merge_cppcheck_reports)
+
+$(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h $(objtree)/include/generated/compiler-def.h | cppcheck-version
+	$(call if_changed,cppcheck_xml)
+
+cppcheck-version:
+ifeq ($(shell which $(CPPCHECK)),)
+	$(error Cannot find cppcheck executable: $(CPPCHECK))
+endif
+ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1)
+	$(error Please upgrade your cppcheck to version 2.7 or greater)
+endif
+
+# Put this in generated headers this way it is cleaned by include/Makefile
+$(objtree)/include/generated/compiler-def.h:
+	$(Q)$(CC) -dM -E -o $@ - < /dev/null
+
 endif #config-build
 endif # need-sub-make
 
diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
index 852b5f3c24..ef37cfa16f 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -219,9 +219,11 @@
                          SCTLR_Axx_ELx_A    | SCTLR_Axx_ELx_C   |\
                          SCTLR_Axx_ELx_WXN  | SCTLR_Axx_ELx_EE)
 
+#ifndef CPPCHECK
 #if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xffffffffffffffffUL
 #error "Inconsistent SCTLR_EL2 set/clear bits"
 #endif
+#endif
 
 #endif
 
diff --git a/xen/include/xen/config.h b/xen/include/xen/config.h
index 85c6f59be9..d888b2314d 100644
--- a/xen/include/xen/config.h
+++ b/xen/include/xen/config.h
@@ -7,6 +7,10 @@
 #ifndef __XEN_CONFIG_H__
 #define __XEN_CONFIG_H__
 
+#ifdef CPPCHECK
+#include <generated/compiler-def.h>
+#endif
+
 #include <xen/kconfig.h>
 
 #ifndef __ASSEMBLY__
diff --git a/xen/include/xen/kconfig.h b/xen/include/xen/kconfig.h
index 4d58c5bb3c..a717b0819c 100644
--- a/xen/include/xen/kconfig.h
+++ b/xen/include/xen/kconfig.h
@@ -8,6 +8,10 @@
  * these only work with boolean option.
  */
 
+/* cppcheck is failing to parse the macro so use a dummy one */
+#ifdef CPPCHECK
+#define IS_ENABLED(option) option
+#else
 /*
  * Getting something that works in C and CPP for an arg that may or may
  * not be defined is tricky.  Here, if we have "#define CONFIG_BOOGER 1"
@@ -27,5 +31,6 @@
  * otherwise.
  */
 #define IS_ENABLED(option) config_enabled(option)
+#endif
 
 #endif /* __XEN_KCONFIG_H */
diff --git a/xen/tools/merge_cppcheck_reports.py b/xen/tools/merge_cppcheck_reports.py
new file mode 100755
index 0000000000..1c1b63ba56
--- /dev/null
+++ b/xen/tools/merge_cppcheck_reports.py
@@ -0,0 +1,86 @@
+#!/usr/bin/env python
+
+"""
+This script acts as a tool to merge XML files created by cppcheck.
+Usage:
+    merge_cppcheck_reports.py [FILES] [OUTPUT]
+
+    FILES  - list of XML files with extension .cppcheck
+    OUTPUT - file to store results (with .xml extension).
+             If not specified, the script will print results to stdout.
+"""
+
+import sys
+from xml.etree import ElementTree
+
+def elements_equal(el1, el2):
+    if type(el1) != type(el2): return False
+
+    if el1.find('location') is None: return False
+    if el2.find('location') is None: return False
+
+    el1_location = str(el1.find('location').attrib)
+    el2_location = str(el2.find('location').attrib)
+
+    if el1_location != el2_location: return False
+
+    return True
+
+def contain_element(new, lst):
+    for elem in lst:
+        if elements_equal(new, elem):
+            return True
+    return False
+
+def merge(files):
+    try:
+        result_xml_root = ElementTree.parse(files[0]).getroot()
+    except:
+        print("Xml parsing error in %s\n" % (files[0]))
+        print("Please upgrade your cppcheck to version 2.7 or greater")
+        sys.exit(1)
+    insert_point = result_xml_root.findall("errors")[0]
+    curr = 1
+    total = len(files)
+    numelem = len(insert_point)
+    for xml_file in files[1:]:
+        try:
+            xml_root = ElementTree.parse(xml_file).getroot()
+        except:
+            print("Xml parsing error in %s\n" % (xml_file))
+            print("Please upgrade your cppcheck to version 2.7 or greater")
+            sys.exit(1)
+        curr_elem_list = list(insert_point)
+        new_elem_list = list(xml_root.findall("errors")[0])
+        for xml_error_elem in new_elem_list:
+            if not contain_element(xml_error_elem, curr_elem_list):
+                insert_point.insert(1,xml_error_elem)
+                numelem = numelem + 1
+        curr = curr + 1
+        sys.stdout.write('\r')
+        sys.stdout.write(" %d / %d" % (curr,total))
+        sys.stdout.flush()
+
+    sys.stdout.write('\r\n')
+    print("Done: %d elements" % (numelem))
+    return result_xml_root
+
+def run():
+    files = []
+    output = None
+    for i in sys.argv[1:]:
+        output = i if '.xml' in i else None
+        files.append(i) if '.cppcheck' in i else None
+
+    result = merge(files)
+
+    if result is None:
+        return
+
+    if output is not None:
+        ElementTree.ElementTree(result).write(output)
+    else:
+        print(ElementTree.tostring(result).decode('utf-8'))
+
+if __name__ == '__main__':
+    run()
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 12:42:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 12:42:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313880.531656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKWL-0001gp-3t; Tue, 26 Apr 2022 12:42:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313880.531656; Tue, 26 Apr 2022 12:42:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKWK-0001gg-W5; Tue, 26 Apr 2022 12:42:20 +0000
Received: by outflank-mailman (input) for mailman id 313880;
 Tue, 26 Apr 2022 12:42:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kigu=VE=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1njKWJ-0001ga-Qy
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 12:42:19 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on062a.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::62a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4e4bc882-c55e-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 14:42:17 +0200 (CEST)
Received: from AM6PR02CA0025.eurprd02.prod.outlook.com (2603:10a6:20b:6e::38)
 by AM0PR08MB3793.eurprd08.prod.outlook.com (2603:10a6:208:fc::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr
 2022 12:42:15 +0000
Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:6e:cafe::fd) by AM6PR02CA0025.outlook.office365.com
 (2603:10a6:20b:6e::38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend
 Transport; Tue, 26 Apr 2022 12:42:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 12:42:14 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Tue, 26 Apr 2022 12:42:14 +0000
Received: from e55cec08fd35.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3BBE8150-544A-4F7F-8436-8981F38CC46D.1; 
 Tue, 26 Apr 2022 12:42:07 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e55cec08fd35.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 12:42:07 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by DB8PR08MB3930.eurprd08.prod.outlook.com
 (2603:10a6:10:a7::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 12:42:06 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 12:42:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e4bc882-c55e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MyKzq2UAvrhg15ra8M0T/BGn8DgqfBBRNVgrD6r3Vso=;
 b=0rpaxsfxgs2ttgQzPHGK1WS17SrlSoR2M/9ocvNArEVePCd7rTB668o0WxtwiUTnlybs3GsJQetKGk8HbzRHZHpqLBefOVlQwfJhp2uQgW6TXXL+3v9fJPG7QcbIUyaGTlKldTO15QYTIxdTw2bEbo0i4/duIEdbp1nNEbFn+rc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 63f394be43e7bd14
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ixc8sclWishHAAEIioee+9Q3p1q9SiWXyv63Yg8xtsioAc0y37BBhoZu66lgyPOkXePWrkT/KI2hPdZLCJzFqazT+4d8SsMyCZHuCnoWRehyUMClxdLFq1Ip24p46yp414ZxJbVnVXcxNUXyRLDFRCEVvcwsLvZ6H8QUoGxvwptX1+Alf9ZfuON1bO2ltJmobsJSIPUy3TF9xKc27FAXFVy9ZUgXhWZLpKOmJ6rlHTN77ATq5P3nQEMYFHRe/IFq2GizyPgErPS38V3MlDUtxfXp7aEkeOlPUb8P7Bh7IZlIicGYGi9GcZCm6iouCUy5b7kOacXMxdlSJC2XFo/Q1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MyKzq2UAvrhg15ra8M0T/BGn8DgqfBBRNVgrD6r3Vso=;
 b=eauBuKNn/RPhcdm7M7vxoT1XbajmPl2oGyxPwdwt3ENr3srQbK2GpMAsxO9HOynEgv+hgi1JYaBKOad1w+xn2BCHtox7bBmk6mMLDQpsE3ru50WdmhsXHkxmSaHRMAC9h1DjsOvgzYWPc816y4lRJwz3JRMTTuB5ecVn40FMeuSrmvAptT+pdFiyol2hcDBNIDsEcp9EoAs1IQgwYrNY0Li8ouwcEctdiwRcTHcPEpbPopLPLllRx3UDk40yse9rOfeH7hq3lCzEdhHxCIIqbbL/WjLoVhxCnC/nwqHpfb3jOHjj6ZL4XvOEO9Eg9GeXdn+UGaCywcr2UC90tI/c0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MyKzq2UAvrhg15ra8M0T/BGn8DgqfBBRNVgrD6r3Vso=;
 b=0rpaxsfxgs2ttgQzPHGK1WS17SrlSoR2M/9ocvNArEVePCd7rTB668o0WxtwiUTnlybs3GsJQetKGk8HbzRHZHpqLBefOVlQwfJhp2uQgW6TXXL+3v9fJPG7QcbIUyaGTlKldTO15QYTIxdTw2bEbo0i4/duIEdbp1nNEbFn+rc=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Christoph Hellwig <hch@lst.de>
CC: Stefano Stabellini <sstabellini@kernel.org>, "jgross@suse.com"
	<jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
Thread-Topic: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
Thread-Index: AQHYVzWiSClsigwCc0OWmoGO41dp7a0CJ6aA
Date: Tue, 26 Apr 2022 12:42:06 +0000
Message-ID: <7124886B-04C8-483E-8062-870D94157DBB@arm.com>
References: <20220423171422.1831676-1-hch@lst.de>
In-Reply-To: <20220423171422.1831676-1-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: cda83697-9ce4-486a-5efc-08da278230fe
x-ms-traffictypediagnostic:
	DB8PR08MB3930:EE_|VE1EUR03FT024:EE_|AM0PR08MB3793:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB379304D46867CCBF6D0D024EFCFB9@AM0PR08MB3793.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ofLPT9J5cyDLt1cL18Ae36BiKjcBJ2ww2cxxovInqRWl7I+JanViCGOWzxjQcXvx7yJwyPMVZSQUe18RZ7mdsD6nBoUlI/Qcr/uG1AWLuhmjuJvy6J8x4NwnMFsSdhdW3gtpQw3ayDevrI/+dqIQT4cFYdcrH2u9pHzg3SEtP1idBv3equJTF1xIVFcuAplIjlsKflaQrkMGiKntpal9d630EZxkbbmxQVRNRqqFJ+zCbmDIP4vjqjOAjIIJ2l2dKZt/MtQl4ZF1Sr2ONqCk+axme82jiI6yuGUnj4g9hbH9ypu8OX7YSXfM6ttpxe4tY0U7uEhbseuHZFBYDE+IEWN6vdzCUryNThypbizhenNVrnZZxQUWX5qy0XH4O7EU1apB8UhXSBblYpQ4DtQ3zqdUIEafl1F2HHF7fBwbb1/vW2L8G69jK3ozWJtgNPIWghSzI9iFj7CSfNK2fJLqd36fXcJZJyVE4UOCRhRFJmGo4WkqoTR8l6amVKOPGQNCxc9MX+hJbuA4tC8JRKfoAysVQlNAJbacs7bZkS4gfHuYK4DmiUh7xLY2zwL3UPpN+v2ZslwbJ9yRiKLcR/PBjj/AvGVQDDZL5GNGg68OsVb7UReIJH4VdkZ3QXd1pT47yWpXYD6C2wGkmVqHrEjQ7bCls74acDdEDBNXxP2YHpzbp7bMszW+S9JXhgIeTG0MShvmUC2QXhO4CnKrVBmkwqBK436iEM1bN6d2pr56UCcJnBJDFqleBwjHkoOFzZFw
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(66946007)(64756008)(8936002)(8676002)(91956017)(66476007)(66446008)(66556008)(4326008)(33656002)(508600001)(83380400001)(6486002)(6506007)(122000001)(53546011)(86362001)(2906002)(6512007)(2616005)(5660300002)(26005)(38100700002)(54906003)(30864003)(71200400001)(186003)(6916009)(36756003)(316002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1EF09590D70D2343B591E27DD3C8395A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3930
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2c177aac-e643-4337-9833-08da27822bd2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yt4Tr2YX8iMPYiaG9ataKEefCXxKd1pAMWmFuQZLHABNrWChWU+bDdlc7ScP5DPaZHEoLWSO6i6CucrjfmVclTTfxBevk2GSlZ01uyKaWHG1dgUwll6x6OiPhBl/VI1h7uameeNyHvxyNhZRpZ3mpN8d1bvLkIlQHmCl8n6rZ/0PasrabwCQNhyjXLb3DX1Z9nBYme4oXgsohaQ8Ryr8YyzhgvbVcKzTyrfcYYr2ms1MFgPa2po5GpBLzGalJwIiNpCWhJhp3GCtgjuwL1q9gqfrYj2OIr8mFjO563rmhouN+1feX6GhttyKfzH53cZb0BihZ3aqRzL+AXVk2xI8f3ZhJ720/TUAwpkTwaiq20WyvBAl2bLG4P3Wjz3Uufesz76btFIPADxGV33OslJRCJyenoRBifxY4c9eynQAf1Jljq3whLi9IC5oTkVrBubXO8qmjGVc7U+cpIE8m7PV3pQwyMgGiL+TyDO38CqI3Sa42FiSQ2Rc4mAurPCW9XetabsE5hRaPychm3zUocsnsDTkj0tKrRA6T4DJlb0zS+MMP/uxHDE3hiL/v3LorNOY+evaLDhnRipBKAGYw+3mHfpfKVsCjqu5+5wBIWIOB/eAm3SVuuPtTPegsrtryc5VtHCRCTjdLSWblB8g3A+YK42SRgeNZgJL2DiNhIkfycih7DKqy2WAEtEgITF7jiid
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(81166007)(82310400005)(2906002)(70206006)(70586007)(508600001)(356005)(30864003)(316002)(40460700003)(8676002)(4326008)(47076005)(6862004)(5660300002)(8936002)(6506007)(86362001)(53546011)(36860700001)(6486002)(107886003)(33656002)(6512007)(186003)(26005)(36756003)(83380400001)(336012)(2616005)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 12:42:14.6148
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cda83697-9ce4-486a-5efc-08da278230fe
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3793

Hi Christoph,

> On 23 Apr 2022, at 6:14 pm, Christoph Hellwig <hch@lst.de> wrote:
>=20
> swiotlb-xen uses very different ways to allocate coherent memory on x86
> vs arm.  On the former it allocates memory from the page allocator, while
> on the later it reuses the dma-direct allocator the handles the
> complexities of non-coherent DMA on arm platforms.
>=20
> Unfortunately the complexities of trying to deal with the two cases in
> the swiotlb-xen.c code lead to a bug in the handling of
> DMA_ATTR_NO_KERNEL_MAPPING on arm.  With the DMA_ATTR_NO_KERNEL_MAPPING
> flag the coherent memory allocator does not actually allocate coherent
> memory, but just a DMA handle for some memory that is DMA addressable
> by the device, but which does not have to have a kernel mapping.  Thus
> dereferencing the return value will lead to kernel crashed and memory
> corruption.
>=20
> Fix this by using the dma-direct allocator directly for arm, which works
> perfectly fine because on arm swiotlb-xen is only used when the domain is
> 1:1 mapped, and then simplifying the remaining code to only cater for the
> x86 case with DMA coherent device.
>=20
> Reported-by: Rahul Singh <Rahul.Singh@arm.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
> ---
> arch/arm/include/asm/xen/page-coherent.h   |   2 -
> arch/arm/xen/mm.c                          |  17 ----
> arch/arm64/include/asm/xen/page-coherent.h |   2 -
> arch/x86/include/asm/xen/page-coherent.h   |  24 -----
> arch/x86/include/asm/xen/swiotlb-xen.h     |   5 +
> drivers/xen/swiotlb-xen.c                  | 106 ++++++++-------------
> include/xen/arm/page-coherent.h            |  20 ----
> include/xen/xen-ops.h                      |   7 --
> 8 files changed, 45 insertions(+), 138 deletions(-)
> delete mode 100644 arch/arm/include/asm/xen/page-coherent.h
> delete mode 100644 arch/arm64/include/asm/xen/page-coherent.h
> delete mode 100644 arch/x86/include/asm/xen/page-coherent.h
> delete mode 100644 include/xen/arm/page-coherent.h
>=20
> diff --git a/arch/arm/include/asm/xen/page-coherent.h b/arch/arm/include/=
asm/xen/page-coherent.h
> deleted file mode 100644
> index 27e984977402b..0000000000000
> --- a/arch/arm/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#include <xen/arm/page-coherent.h>
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index a7e54a087b802..6e603e5fdebb1 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -118,23 +118,6 @@ bool xen_arch_need_swiotlb(struct device *dev,
> 		!dev_is_dma_coherent(dev));
> }
>=20
> -int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> -				 unsigned int address_bits,
> -				 dma_addr_t *dma_handle)
> -{
> -	if (!xen_initial_domain())
> -		return -EINVAL;
> -
> -	/* we assume that dom0 is mapped 1:1 for now */
> -	*dma_handle =3D pstart;
> -	return 0;
> -}
> -
> -void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int orde=
r)
> -{
> -	return;
> -}
> -
> static int __init xen_mm_init(void)
> {
> 	struct gnttab_cache_flush cflush;
> diff --git a/arch/arm64/include/asm/xen/page-coherent.h b/arch/arm64/incl=
ude/asm/xen/page-coherent.h
> deleted file mode 100644
> index 27e984977402b..0000000000000
> --- a/arch/arm64/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#include <xen/arm/page-coherent.h>
> diff --git a/arch/x86/include/asm/xen/page-coherent.h b/arch/x86/include/=
asm/xen/page-coherent.h
> deleted file mode 100644
> index 63cd41b2e17ac..0000000000000
> --- a/arch/x86/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _ASM_X86_XEN_PAGE_COHERENT_H
> -#define _ASM_X86_XEN_PAGE_COHERENT_H
> -
> -#include <asm/page.h>
> -#include <linux/dma-mapping.h>
> -
> -static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_=
t size,
> -		dma_addr_t *dma_handle, gfp_t flags,
> -		unsigned long attrs)
> -{
> -	void *vstart =3D (void*)__get_free_pages(flags, get_order(size));
> -	*dma_handle =3D virt_to_phys(vstart);
> -	return vstart;
> -}
> -
> -static inline void xen_free_coherent_pages(struct device *hwdev, size_t =
size,
> -		void *cpu_addr, dma_addr_t dma_handle,
> -		unsigned long attrs)
> -{
> -	free_pages((unsigned long) cpu_addr, get_order(size));
> -}
> -
> -#endif /* _ASM_X86_XEN_PAGE_COHERENT_H */
> diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/as=
m/xen/swiotlb-xen.h
> index 66b4ddde77430..558821387808e 100644
> --- a/arch/x86/include/asm/xen/swiotlb-xen.h
> +++ b/arch/x86/include/asm/xen/swiotlb-xen.h
> @@ -10,4 +10,9 @@ extern int pci_xen_swiotlb_init_late(void);
> static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }
> #endif
>=20
> +int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> +				unsigned int address_bits,
> +				dma_addr_t *dma_handle);
> +void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int orde=
r);
> +
> #endif /* _ASM_X86_SWIOTLB_XEN_H */
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 47aebd98f52f5..557edb9c54879 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -36,7 +36,6 @@
> #include <xen/hvc-console.h>
>=20
> #include <asm/dma-mapping.h>
> -#include <asm/xen/page-coherent.h>
>=20
> #include <trace/events/swiotlb.h>
> #define MAX_DMA_BITS 32
> @@ -104,6 +103,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, =
dma_addr_t dma_addr)
> 	return 0;
> }
>=20
> +#ifdef CONFIG_X86
> static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
> {
> 	int rc;
> @@ -129,6 +129,12 @@ static int xen_swiotlb_fixup(void *buf, unsigned lon=
g nslabs)
> 	} while (i < nslabs);
> 	return 0;
> }
> +#else
> +static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
> +{
> +	return 0;
> +}
> +#endif
>=20
> enum xen_swiotlb_err {
> 	XEN_SWIOTLB_UNKNOWN =3D 0,
> @@ -256,97 +262,60 @@ void __init xen_swiotlb_init_early(void)
> 		panic("Cannot allocate SWIOTLB buffer");
> 	swiotlb_set_max_segment(PAGE_SIZE);
> }
> -#endif /* CONFIG_X86 */
>=20
> static void *
> -xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
> -			   dma_addr_t *dma_handle, gfp_t flags,
> -			   unsigned long attrs)
> +xen_swiotlb_alloc_coherent(struct device *dev, size_t size,
> +		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
> {
> -	void *ret;
> +	u64 dma_mask =3D dev->coherent_dma_mask;
> 	int order =3D get_order(size);
> -	u64 dma_mask =3D DMA_BIT_MASK(32);
> 	phys_addr_t phys;
> -	dma_addr_t dev_addr;
> -
> -	/*
> -	* Ignore region specifiers - the kernel's ideas of
> -	* pseudo-phys memory layout has nothing to do with the
> -	* machine physical layout.  We can't allocate highmem
> -	* because we can't return a pointer to it.
> -	*/
> -	flags &=3D ~(__GFP_DMA | __GFP_HIGHMEM);
> +	void *ret;
>=20
> -	/* Convert the size to actually allocated. */
> +	/* Align the allocation to the Xen page size */
> 	size =3D 1UL << (order + XEN_PAGE_SHIFT);
>=20
> -	/* On ARM this function returns an ioremap'ped virtual address for
> -	 * which virt_to_phys doesn't return the corresponding physical
> -	 * address. In fact on ARM virt_to_phys only works for kernel direct
> -	 * mapped RAM memory. Also see comment below.
> -	 */
> -	ret =3D xen_alloc_coherent_pages(hwdev, size, dma_handle, flags, attrs)=
;
> -
> +	ret =3D (void *)__get_free_pages(flags, get_order(size));
> 	if (!ret)
> 		return ret;
> -
> -	if (hwdev && hwdev->coherent_dma_mask)
> -		dma_mask =3D hwdev->coherent_dma_mask;
> -
> -	/* At this point dma_handle is the dma address, next we are
> -	 * going to set it to the machine address.
> -	 * Do not use virt_to_phys(ret) because on ARM it doesn't correspond
> -	 * to *dma_handle. */
> -	phys =3D dma_to_phys(hwdev, *dma_handle);
> -	dev_addr =3D xen_phys_to_dma(hwdev, phys);
> -	if (((dev_addr + size - 1 <=3D dma_mask)) &&
> -	    !range_straddles_page_boundary(phys, size))
> -		*dma_handle =3D dev_addr;
> -	else {
> -		if (xen_create_contiguous_region(phys, order,
> -						 fls64(dma_mask), dma_handle) !=3D 0) {
> -			xen_free_coherent_pages(hwdev, size, ret, (dma_addr_t)phys, attrs);
> -			return NULL;
> -		}
> -		*dma_handle =3D phys_to_dma(hwdev, *dma_handle);
> +	phys =3D virt_to_phys(ret);
> +
> +	*dma_handle =3D xen_phys_to_dma(dev, phys);
> +	if (*dma_handle + size - 1 > dma_mask ||
> +	    range_straddles_page_boundary(phys, size)) {
> +		if (xen_create_contiguous_region(phys, order, fls64(dma_mask),
> +				dma_handle) !=3D 0)
> +			goto out_free_pages;
> 		SetPageXenRemapped(virt_to_page(ret));
> 	}
> +
> 	memset(ret, 0, size);
> 	return ret;
> +
> +out_free_pages:
> +	free_pages((unsigned long)ret, get_order(size));
> +	return NULL;
> }
>=20
> static void
> -xen_swiotlb_free_coherent(struct device *hwdev, size_t size, void *vaddr=
,
> -			  dma_addr_t dev_addr, unsigned long attrs)
> +xen_swiotlb_free_coherent(struct device *dev, size_t size, void *vaddr,
> +		dma_addr_t dma_handle, unsigned long attrs)
> {
> +	phys_addr_t phys =3D virt_to_phys(vaddr);
> 	int order =3D get_order(size);
> -	phys_addr_t phys;
> -	u64 dma_mask =3D DMA_BIT_MASK(32);
> -	struct page *page;
> -
> -	if (hwdev && hwdev->coherent_dma_mask)
> -		dma_mask =3D hwdev->coherent_dma_mask;
> -
> -	/* do not use virt_to_phys because on ARM it doesn't return you the
> -	 * physical address */
> -	phys =3D xen_dma_to_phys(hwdev, dev_addr);
>=20
> 	/* Convert the size to actually allocated. */
> 	size =3D 1UL << (order + XEN_PAGE_SHIFT);
>=20
> -	if (is_vmalloc_addr(vaddr))
> -		page =3D vmalloc_to_page(vaddr);
> -	else
> -		page =3D virt_to_page(vaddr);
> +	if (WARN_ON_ONCE(dma_handle + size - 1 > dev->coherent_dma_mask) ||
> +	    WARN_ON_ONCE(range_straddles_page_boundary(phys, size)))
> +	    	return;
>=20
> -	if (!WARN_ON((dev_addr + size - 1 > dma_mask) ||
> -		     range_straddles_page_boundary(phys, size)) &&
> -	    TestClearPageXenRemapped(page))
> +	if (TestClearPageXenRemapped(virt_to_page(vaddr)))
> 		xen_destroy_contiguous_region(phys, order);
> -
> -	xen_free_coherent_pages(hwdev, size, vaddr, phys_to_dma(hwdev, phys),
> -				attrs);
> +	free_pages((unsigned long)vaddr, get_order(size));
> }
> +#endif /* CONFIG_X86 */
>=20
> /*
>  * Map a single buffer of the indicated size for DMA in streaming mode.  =
The
> @@ -549,8 +518,13 @@ xen_swiotlb_dma_supported(struct device *hwdev, u64 =
mask)
> }
>=20
> const struct dma_map_ops xen_swiotlb_dma_ops =3D {
> +#ifdef CONFIG_X86
> 	.alloc =3D xen_swiotlb_alloc_coherent,
> 	.free =3D xen_swiotlb_free_coherent,
> +#else
> +	.alloc =3D dma_direct_alloc,
> +	.free =3D dma_direct_free,
> +#endif
> 	.sync_single_for_cpu =3D xen_swiotlb_sync_single_for_cpu,
> 	.sync_single_for_device =3D xen_swiotlb_sync_single_for_device,
> 	.sync_sg_for_cpu =3D xen_swiotlb_sync_sg_for_cpu,
> diff --git a/include/xen/arm/page-coherent.h b/include/xen/arm/page-coher=
ent.h
> deleted file mode 100644
> index b9cc11e887ed5..0000000000000
> --- a/include/xen/arm/page-coherent.h
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _XEN_ARM_PAGE_COHERENT_H
> -#define _XEN_ARM_PAGE_COHERENT_H
> -
> -#include <linux/dma-mapping.h>
> -#include <asm/page.h>
> -
> -static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_=
t size,
> -		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
> -{
> -	return dma_direct_alloc(hwdev, size, dma_handle, flags, attrs);
> -}
> -
> -static inline void xen_free_coherent_pages(struct device *hwdev, size_t =
size,
> -		void *cpu_addr, dma_addr_t dma_handle, unsigned long attrs)
> -{
> -	dma_direct_free(hwdev, size, cpu_addr, dma_handle, attrs);
> -}
> -
> -#endif /* _XEN_ARM_PAGE_COHERENT_H */
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index a3584a357f353..c7c1b46ff4cd4 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -42,13 +42,6 @@ int xen_setup_shutdown_event(void);
>=20
> extern unsigned long *xen_contiguous_bitmap;
>=20
> -#if defined(CONFIG_XEN_PV) || defined(CONFIG_ARM) || defined(CONFIG_ARM6=
4)
> -int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> -				unsigned int address_bits,
> -				dma_addr_t *dma_handle);
> -void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int orde=
r);
> -#endif
> -
> #if defined(CONFIG_XEN_PV)
> int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr,
> 		  xen_pfn_t *pfn, int nr, int *err_ptr, pgprot_t prot,
> --=20
> 2.30.2
>=20



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 12:51:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 12:51:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313887.531667 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKec-0003CH-2S; Tue, 26 Apr 2022 12:50:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313887.531667; Tue, 26 Apr 2022 12:50:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njKeb-0003CA-VN; Tue, 26 Apr 2022 12:50:53 +0000
Received: by outflank-mailman (input) for mailman id 313887;
 Tue, 26 Apr 2022 12:50:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njKea-0003BE-Ag; Tue, 26 Apr 2022 12:50:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njKea-0004Sz-8s; Tue, 26 Apr 2022 12:50:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njKeZ-0005BH-UY; Tue, 26 Apr 2022 12:50:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njKeZ-00089p-U4; Tue, 26 Apr 2022 12:50:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+aPvecj6owoVIMJAHIvq7P4n3XsoWDC+Vqc1dflaqjc=; b=blpwoq7UzGoIC1prUhsnGIIoT8
	OiYYYcYqw636brCyZ7e5mpb2a5fLxzWWHalhOMvEB9rW0X6SMW6uQJwIZB0rUzgp6/K84Ikum+YCV
	0oTNgcxhx/KeKL58XZnyDFHkNmtvorm/P8ptc2PMHdYTIIiaiFkGOQXI2uh0W4tGCNbY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169729-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169729: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:xen-boot:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=88a037e2cfe11a723fe420d3585837ab1bdc6f8a
X-Osstest-Versions-That:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 12:50:51 +0000

flight 169729 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169729/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 169630
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 169630

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  88a037e2cfe11a723fe420d3585837ab1bdc6f8a
baseline version:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08

Last test of basis   169630  2022-04-22 20:01:46 Z    3 days
Testing same since   169729  2022-04-26 09:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 88a037e2cfe11a723fe420d3585837ab1bdc6f8a
Author: David Vrabel <dvrabel@amazon.co.uk>
Date:   Tue Apr 26 10:33:01 2022 +0200

    page_alloc: assert IRQs are enabled in heap alloc/free
    
    Heap pages can only be safely allocated and freed with interrupts
    enabled as they may require a TLB flush which may send IPIs (on x86).
    
    Normally spinlock debugging would catch calls from the incorrect
    context, but not from stop_machine_run() action functions as these are
    called with spin lock debugging disabled.
    
    Enhance the assertions in alloc_xenheap_pages() and
    alloc_domheap_pages() to check interrupts are enabled. For consistency
    the same asserts are used when freeing heap pages.
    
    As an exception, when only 1 PCPU is online, allocations are permitted
    with interrupts disabled as any TLB flushes would be local only. This
    is necessary during early boot.
    
    Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit c266f974148d3d1b21d01b8bb243017943786444
Author: Daniel P. Smith <dpsmith@apertussolutions.com>
Date:   Tue Apr 26 10:30:31 2022 +0200

    xsm/flask: code style formatting
    
    This is a quick code style cleanup patch for xsm/flask. The files flask_op.c
    and hooks.c are Xen specific, thus full code style rules were applied. The
    remaining files are from Linux and therefore only trailing whitespace was
    remove from those files.
    
    Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jason Andryuk <jandryuk@gmail.com>

commit fa4d84e6dd3c3bfd23a525b75a5483d4ce15adbb
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Apr 26 10:25:54 2022 +0200

    IOMMU: make domctl handler tolerate NULL domain
    
    Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX,
    XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed
    here, when the domctl was passed DOMID_INVALID.
    
    Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...")
    Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Paul Durrant <paul@xen.org>
    Reviewed-by: Juergen Gross <jgross@suse.com>

commit 9cd7e31b3f584e97a138a770cfb031a91a867936
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Apr 26 10:23:58 2022 +0200

    xen/iommu: cleanup iommu related domctl handling
    
    Today iommu_do_domctl() is being called from arch_do_domctl() in the
    "default:" case of a switch statement. This has led already to crashes
    due to unvalidated parameters.
    
    Fix that by moving the call of iommu_do_domctl() to the main switch
    statement of do_domctl().
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> # Arm
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 13:13:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 13:13:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313896.531681 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njL0i-0005bg-1V; Tue, 26 Apr 2022 13:13:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313896.531681; Tue, 26 Apr 2022 13:13:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njL0h-0005bZ-Tm; Tue, 26 Apr 2022 13:13:43 +0000
Received: by outflank-mailman (input) for mailman id 313896;
 Tue, 26 Apr 2022 13:13:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njL0g-0005bP-U3; Tue, 26 Apr 2022 13:13:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njL0g-0004t6-St; Tue, 26 Apr 2022 13:13:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njL0g-0005fw-AP; Tue, 26 Apr 2022 13:13:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njL0g-0006ru-9x; Tue, 26 Apr 2022 13:13:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mgIBNdyyv47jkHNf8EiwF2n8SNIMsAgBHP/w5YBDFxA=; b=uy56oF2qPQTvZ1/BOxTEIvtDcs
	lighSgp1SevQ7j/ANEifKEFH5r9oGejAeAmrnJXbeEj7kMeSMQAipddlZ/FsSVddgXEbF9TAWXO4p
	qqGIR9P/1HdTZf6VOlIz7uqX6UHV+NovOMo3CMk0AY0lKhXfKrOIFFoWEi3cTzzXNc/Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169735-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169735: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 13:13:42 +0000

flight 169735 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169735/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  641 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:00:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:00:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313906.531698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njLjI-0001M1-JW; Tue, 26 Apr 2022 13:59:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313906.531698; Tue, 26 Apr 2022 13:59:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njLjI-0001Lu-Fh; Tue, 26 Apr 2022 13:59:48 +0000
Received: by outflank-mailman (input) for mailman id 313906;
 Tue, 26 Apr 2022 13:59:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njLjH-0001Lk-Je; Tue, 26 Apr 2022 13:59:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njLjH-0005dj-G4; Tue, 26 Apr 2022 13:59:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njLjH-0006im-6C; Tue, 26 Apr 2022 13:59:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njLjH-0002fN-5l; Tue, 26 Apr 2022 13:59:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UEQUBl/mJfmEBfhcbGd4YtgjG23CTjlrpHho/zp/pVo=; b=F6GOPysSyL6kliKSSGY1/c0t05
	0VMXxEMPRx+hrK9TfhpaCR/V/CNco0JQQo+2gDIHWBc8XnYz59guSDWVeMYjgdatrep/twmdqyJTt
	+DQOLF51z9wbuf8mX0BUKUMzZ0dTnnpdr5osjjeehMJdjXbZc4gTUtVjKBizA4ECYsMc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169738-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169738: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 13:59:47 +0000

flight 169738 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169738/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  642 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:01:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:01:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313913.531708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njLl2-0002lg-VB; Tue, 26 Apr 2022 14:01:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313913.531708; Tue, 26 Apr 2022 14:01:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njLl2-0002lZ-SH; Tue, 26 Apr 2022 14:01:36 +0000
Received: by outflank-mailman (input) for mailman id 313913;
 Tue, 26 Apr 2022 14:01:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njLl1-0002lO-CZ
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:01:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 61b3c5dc-c569-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 16:01:34 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-DdyyxF-FOZaX5suXCnQNbQ-1; Tue, 26 Apr 2022 16:01:31 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4053.eurprd04.prod.outlook.com (2603:10a6:209:50::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 14:01:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 14:01:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61b3c5dc-c569-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650981694;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Rw5u93cJDYWEddNdIN73iKCk9IJj9XNE6SNSWcsFc40=;
	b=cJzP8JqZoFNkPol3YzCgPrq/xKgDUiiIw6WWw/2xJQO9sEYWu0zs9EJl3TViKZxAHfSI5L
	F6PlbE4kSX3uqsc2088Mq26osIdq8af2uVlMBbPCirXNJtMUGfsarKjE/+g9vZOk17Ynms
	5wGfxhj+CdBtczIFHzfaNIyVdfaZK3g=
X-MC-Unique: DdyyxF-FOZaX5suXCnQNbQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N7+xem0bp4A3ntgLamZHeH1a1VCrW9XGxjfp4G5AA7DmHpEzyQiJ5eRqe6tN6MdpG5xqW8vdizWty6KNjAzFObdqAwB132o3PgMI2fPQac92eb/AjVZQBLdN9PuaWWGQrqN3yWGqJDgf0kZlCp7OcUWzxvARPafirRF+8cwIHuY9DYw/0O2sXWSPJtCopMvr3XCbVwEF/uWFNfj7RaNinVDA8CGMnchpIWF8AmVOzpgHlvEYRfQmaw25wBqeh9HIcPSB8lsaGY3kNiXEDRRLb1FtwSK2JX02UQGjIgJnPMC74nBqfK9cwCnxMGBLNckHC2dAUlcvb4CvR2eQkioZbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Rw5u93cJDYWEddNdIN73iKCk9IJj9XNE6SNSWcsFc40=;
 b=EDwtknJUCUhg0XbX1GxBFJu9mYJCEXkC4re3Y1Xfi7GX9bNwka7JwTYSOzSNj8cnnpy3i08E5X99SDnH87Mw7DFrreeyr5AnJqqa28yLinxlfNZA2Ov+8E9Rhezw/SiMGPKRFM8RYqGueBjeyCRuE9k4li5DHQSnmHQnx0quRHrjFh8mr25pH9DLhCQXGIWd53EBD/1ZfypNTkHk/q7OK8jgcupnHUVadB8T3r+AenMD0I8JaveEFiiJfq+sI5JhRctR4PMweOtm3OSRwvrmZVjNbyGf6YBoZLDrnfADI9B8lTC8vqnNsmqDS9ZbmiSAmDivXATd+WtRavLjtHNpEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f5a45b8e-644d-15aa-951f-aa6d89ce4c5b@suse.com>
Date: Tue, 26 Apr 2022 16:01:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
Content-Language: en-US
To: David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220425132801.1076759-1-dvrabel@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0050.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::27) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 48a2505e-07f4-4c10-2ad5-08da278d42e8
X-MS-TrafficTypeDiagnostic: AM6PR04MB4053:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4053B8E2CF040269274C761CB3FB9@AM6PR04MB4053.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JFpSChrd8dJ7LrKrulVJoeDpEvIwd4y2oO37RnbjpufXFvtoaDQzndlzDEDCWjbBk9bCzZkbYBSM7hnnEpeqDJN4zAhxf7GE7x74qp4Fwvg1Zih2LUyUdsFe/uYpyO6MyfIMGj3YIig2h9qGRpMeAmqD4ZBCYWYEiHp/6tnTdzV2PSZ+Jv5E142e23W4KKc0Lwb49zFfybEeCMAwGWBcj8217TvNrmbsXIIP4U17PH/mX4FMr6ry435udvVpjETaau42l+sKV/1nJdkLOcBgGkxWJBKfFhL/J/WOYeJMotk9DH/TkUo3CrYlKG/e3LM5dX1rYhToRMkt9JCHcJ17CqaoPEnfapDMFSn+h3aaiWEe/HZN9er4f75NnbJ8khfuiV6EmaH3FAWLnxX58uk1WqB97w8EEKk6Jrs8wpr1p9Ypiz1P7PG9hMAhopnLy4vAyz/yjQaTZ5qMqM7GcKXQX7hUgYFn9lOMfY08DH/LaadjbyrwcTw1vhcMLMfKUjP/1Z3Ugi/g8nuCpX6CnTS2+8uRDQjbPm/yzlsDCLFJrQnmZMYB4pXC9q9efJ9UXRG6PVh2oIvDJ/mzY/CosHEgWDrQNqmHHlbfyH+1r2YVr8pSvYluzs60MEMOmhoStUeZhdOv/Tw/3TMTNlXBXw2+qZlu4XyqdjyGpNNcl34n0P9BXA1KjAIyrpIan0X28fNdZoVOEmnEe8KFuWWrDsJw9lv1BFxXBy6OaidsOfhVmBwbMDYVf2WSpcgnyNo9aoQY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(8676002)(4326008)(66476007)(54906003)(6916009)(83380400001)(31686004)(36756003)(6506007)(53546011)(316002)(66556008)(2616005)(26005)(8936002)(66946007)(6512007)(5660300002)(6486002)(508600001)(31696002)(4744005)(86362001)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFFSWjViSmxLUlZiSkFDeTNGdFFHU2VNTXNSM0huTTZQWTZIbGpLS25SSnlt?=
 =?utf-8?B?dGh2cjNxTUdvUHBKNXNkcFhyWWR3NkNuTVlOYUd1Qm9ySmhQMjdzc3laVFRY?=
 =?utf-8?B?WktSRFdhNjQybDNxVHNEUXpPRExJbGR4NWxzc3hiWUNJd2V0VDBoamZCaUM2?=
 =?utf-8?B?SkZza3YveW4rTm9FWDBBU1JNUEtGSjhwNjBmemM4Zzg0N2t6aWRPZ1BpRUk1?=
 =?utf-8?B?QklKdUgzSnFHVktyMVVQUmxpbnUrNVRJRFFWSHdmWGRXeGVhMTBvU1ZMSzhu?=
 =?utf-8?B?RjlnS3dCNkZhaTV5bVUvT1JMR3h3L3doSjJ1YjZna05waldkdVdaeGF1K0Nw?=
 =?utf-8?B?SUYwVE5hQTBQeFIrUHJrakZMa1ZpVzZ5WHBicWJxNzF6VmpIOTJIWURhWld0?=
 =?utf-8?B?M25KZ3ZnZVdmRnJ0U1NMYWpHWnUramI1WVBYY3UvSEFORC93RHhBMzNuVWpK?=
 =?utf-8?B?THl2TjNmSFFzSjFNR2xvNC9ib0VxODJtZC90SXBMZ2M3MFFEL0tjNE5udmtq?=
 =?utf-8?B?bjVsMmxNdlZDSEtSZkRJenZhMHovREo3aHNYRHRXU2dKSXBCSnB2SG5iV2tp?=
 =?utf-8?B?dWE4U3pmYm1zUExPSFBrREdEZDhRb2V6R2IvUnlaa2NEaDBYTXVTR2VnN1F1?=
 =?utf-8?B?eGlRUEsvNVJWclN4akRuZ3NKT1htVHNWS2xFR001UkZOYkNUcDNwbGlFa2kz?=
 =?utf-8?B?Yzd0S0M1REhOTHJrTGRpMEFJVkJqSWxjRnB5b1FsaHpuZVBKN3Irc3JqeitI?=
 =?utf-8?B?czBxYUZQVm5XTGdMMEUrQU5jUFlzZjVCaUE2WTZLNkFEc2h5OS9IMTlPbnlX?=
 =?utf-8?B?cmJNMU4vYlIvZXpmUHkyKytHSU1yOHN5eWQ3c2t6V1NpTi92cGdiOVRlSXU4?=
 =?utf-8?B?TDNWRUZsQzBHWnZucEh1d1FmMmUrUnJPRDlhekVvbFRIV1lwQXhZQ2JDYmJW?=
 =?utf-8?B?cEVrODhmNEhDZHRxWElXM3hPL0xnVk91amtmZ0kvclFHeVBUWnVoei9acGZO?=
 =?utf-8?B?Y0ZxdSt2RzgrRVRkVzNoVVdHdk5KRE5uZzdwOTJ5V1k5OGhxbmtyZC9YWitm?=
 =?utf-8?B?UC9lUFVHK01GZ3ZVbG52eGZNeGxIRnNacm1jYXpTVG5Mc002cDZ3bzlSQVpC?=
 =?utf-8?B?TUdwN1R4ZzBVNUg3NDJQdXd3ZWEzeEdjY0RvaUVFemhYMlpMd0s1ckVFSUhI?=
 =?utf-8?B?SWx2YzA4VWNJcWZ4Rm9tVm9lNE5mRjNBRzlVTGhxSFFoUmVMVjhocnp2Qmt3?=
 =?utf-8?B?dVVnZVBNdURHOW5FVE9TZzNYZjhqdmtUNWtiMVZZaVJVMVlCTmtudVZsLzF3?=
 =?utf-8?B?SkpZcWNZSldOeDNEcjRBUkk5bUZvTTRZZERwNGxxeXVyd0d2TUZmcEVkdmdG?=
 =?utf-8?B?TytOdEZjczhmTmNkUjFBdkVVZUJsR25TdktOVVYzWFVvNnpiTUZzRWd6TWMr?=
 =?utf-8?B?K1REbmdwdGNDSWxORnJzUFgxckdteFh2ZnNTUEV2b0drYnV0YXd5V3IvRWFz?=
 =?utf-8?B?VWpwQys4QklBQlBzYWhmejQ3RUlCM3I0THJuVHpOejdPdExPNDEzWnpjSFlF?=
 =?utf-8?B?aFJoQnFqSnE0d2ZrZzR0dGlhQ1dJZFhFZDF1Z2R4dGNqekVFZGtINUd5d3Jw?=
 =?utf-8?B?NERwZ2ZMUFhlOFd2eHRLWm9NV3d4anZqVTU1QnEvR0dJcW9GQ0F4QTJhSzF2?=
 =?utf-8?B?TjZWUHhGdUNJMEthdjRLeXpOM1BqdmRLVnY4Tnp6MkZGOGFLNXVUYVRtK1Uw?=
 =?utf-8?B?OTFwWk1CQlcyOWVLWXF5dlQ3RkJyWCthME9RZWRoNHJ3OHRDNGsySG9VeTZV?=
 =?utf-8?B?SnFIK1dNSG43a0RtbmthOFpBRThoTWlsRDFPL1lhZjVZQ2lMYnhKclNEOXVP?=
 =?utf-8?B?QTBPS1dOSG1uOStkYXk3THAwYlhIeTlRV0hnZUZpSmgvL3BBREZ2N0o1M3RH?=
 =?utf-8?B?WWJZM0wxYXQ5bnpIRHMwWnF0YmdhM3ZlR3BNMjZhNm1FUXg2OVFUN0R0M0t5?=
 =?utf-8?B?UTViSU9xWDNCOVdTb1FnSmpTMnNMRzQ2bGFKTHpIVktqdXhmcm9nRUM2Zi9S?=
 =?utf-8?B?cHBiWU8rWlFVNHd5TG9MY21Id0lZQ2VFREt1Smo5RW9XWUZhLzVhdUxWSFk0?=
 =?utf-8?B?dnZnTjZ3WDA0MTAySVJBeHlKSjcwU1VUdUxpOUdmUGNqZVI1WlhSczBuUXBP?=
 =?utf-8?B?MGlVc2NIdStOcEtOcVFvUW1tTElQdVJJUEJHT2pFaTBVWnJ2TTg4M0RaREgr?=
 =?utf-8?B?d0pwUUh2NUIvM1JiWjdLYlliaFBTcTA2R0NWazRtNGZwY2hIWDhxMkdMakRm?=
 =?utf-8?B?Z2prNCtiS25kbEJPM0xacHdVMEFqVnVEdTRsbVRSRWVmTUQrN1oyQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48a2505e-07f4-4c10-2ad5-08da278d42e8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 14:01:29.4610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KoaKqKf3W1M6TSV7FZttDRUidEQpYvI4mjyBdJ082Z0T++n2xFPbRvsUs/Ihjl1ib8Cf7IE+dnZdw2ncmpwXfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4053

On 25.04.2022 15:28, David Vrabel wrote:
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -162,6 +162,13 @@
>  static char __initdata opt_badpage[100] = "";
>  string_param("badpage", opt_badpage);
>  
> +/*
> + * Heap allocations may need TLB flushes which require IRQs to be
> + * enabled (except when only 1 PCPU is online).
> + */
> +#define ASSERT_ALLOC_CONTEXT() \
> +    ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1))

At least one of these tightened assertions triggers on Arm, as per the
most recent smoke flight. I'm going to revert this for the time being.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:09:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:09:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313921.531720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njLsp-0003YG-T4; Tue, 26 Apr 2022 14:09:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313921.531720; Tue, 26 Apr 2022 14:09:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njLsp-0003Y9-Pi; Tue, 26 Apr 2022 14:09:39 +0000
Received: by outflank-mailman (input) for mailman id 313921;
 Tue, 26 Apr 2022 14:09:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njLso-0003Y3-Lo
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:09:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 815c46d9-c56a-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 16:09:37 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-FAObKtcmNI-3OMbYHTUfIg-1; Tue, 26 Apr 2022 16:09:34 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4030.eurprd04.prod.outlook.com (2603:10a6:803:49::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 14:09:32 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 14:09:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 815c46d9-c56a-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650982176;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CJ7xTwVcN92bkCRasKR6rQANUiBONI7e6u3lc9vkCPo=;
	b=IMrTyg75+4ie/GgNqW/0KGGq4fD6c3eWby1lu1hd8qReeXFno7TZNiqLd5nhYtiC/I8I25
	z7D3l+wzyfqF134mIvlVOkT3aUAsrFuqQBEUKBtkjhddxrzie+ZDlAn93uUgGeFsiAiGmq
	rI4/fy/h2Lb1FJOpfst7I3thyoofMwc=
X-MC-Unique: FAObKtcmNI-3OMbYHTUfIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TdtoVV1OPryTj10MBJkFvE1BKa97UBPLtXUo1++gOeo5DRqD7H72nAkeaSNU7nrChuJ7Czd781sCZ1sFfwU0wCvlYHYRexfycw9UICKDG5cOzpUa8uOOwLP1vWSH2uyi9D+ONMY+cvwq06a8W5fxGBpZnk1tpw6QjrvLgdny3jBKZV4YoGechiOimjGIYNQgPBp/Tz7o3HZCNtTKTOigyQukKaR4Htd8d2jLGxpklwTa17UW38qMrXJkBmUMKqlXDjNz+itsujZlaoIwe4Slo7LyUEbjqEzXjsBzO3AZZpdzLTDu1i92FPqaIUsROWitdEDOfjFMX8eARKihfOS4Qw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DO5po+E7MPCUDJzb1BT7deuy5c5ILJTTSeQUEc/P2Ag=;
 b=FnPZl2RT0/FwQpjv+pS8x+S6nYJT9hYcm2+xXRiPVLQ9Y6mygKunUuzBARVQ4L1bpPBctwMBNYvxTsvxF1eGSEJ01A1MlLmUWhXaz6x6z1pc9OAxkV7LHdJCBFkgWlPNh6KK1zyFpvh1IH4WoUH4gXHzlMjRAouSl0Y2C5gOkI64M5eAHBT7s2q2qgyrx3tmaepzJgabjdOfIUcd8iXMZGdiL9I9vZI26itr0jEN5bs3yf0sDDJH2dAXAynF3ZU1V/begzxOAbF1Z7PkwDfj6m/p+LbqDYm58PuYYh3J6UE26XMohl9hA7cTwFueFlcMkJofiHZHkgEEzngW6ebVPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <07281533-7967-bf67-d68c-3ce1bd5de157@suse.com>
Date: Tue, 26 Apr 2022 16:09:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH RFC] EFI: strip xen.efi when putting it on the EFI
 partition
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <394c1b94-beaf-bdcb-c333-65dd9987be54@suse.com>
 <DFF300CA-944E-47D9-9674-6858790D45C2@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DFF300CA-944E-47D9-9674-6858790D45C2@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0112.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::27) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5c2139a7-2b39-476f-82d1-08da278e62f8
X-MS-TrafficTypeDiagnostic: VI1PR04MB4030:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB40302AAD09A9F82470F8E7BEB3FB9@VI1PR04MB4030.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XVqcD+EN/YcVrEax8XuMzaTyH4fJ23w+Rk1bxQtZjF9nM8w/PAUtB+l6IAic0iZe+4C3s4gM3ikzcmF1zsGvmYhKVJCyFE7ZI6yFeQg3AnYikG1rTG5+mCPgGtfP+rSd7PUm2pXPs81X5GjkkWAU64A3bZJOvaLJQc/6AKRf5nV34Y4dfU0nZH7/TS8my+TKl7OGROB8P1KLN3v8bvSKjHNnC96E1NMsPcHdFwcNMtlDxVM1KS9KvDb+MJFEgNVro57iXm+dZsuqslf5FItMOQmeMS5QHeuIA7VCPbtMf1sONJ8IaduhmBzbSc7j38+Ua59TcaRTUmOHrQxRlSaS/ys7dEW1qPgs7P8I82pv4fk/0OOuI16hGtGEu/vpSqfqPIS9za9fGZihgExR2oHFZj7EQ+syrT7qFOHTqd2f7yFIjWdr9Fk6qjk907eMWceUh6E9GHatmzCQfVWJwxf9RNo/jx8yTNZKBrQjzrFdUw/3BE7FULK4xvtNmRiy+H2w0BYmuPrrohDa/FC8UAv6QXY9FrE7FIP3OPouaW8zldFk6K9wUuBP4uu74ghY6i1FJVGHK7b/YygN3KuikuX2QaX6vubExtVILn9nU1Fw6OsreeppFoV0Izqcgu39rfpDGNn/yx8ilpdvdfwVoyZJPq6uOOhNEoq0gwP3eg7YNjbVyJFVUyIoYSkTCc596uHBgMdYhV7OcPK42ici8iNjg/UHM/rnlUTQssJWlog7iuE/qePvtK2VuM8cCGTL74dw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(54906003)(508600001)(53546011)(6506007)(83380400001)(6916009)(2906002)(38100700002)(316002)(31686004)(86362001)(66556008)(66946007)(66476007)(4326008)(186003)(8676002)(2616005)(36756003)(5660300002)(8936002)(26005)(6512007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0N6T0AFgtrHn4pNFeEZDhu5iz4qRwlNhM8wgVIm/e/7XXMcrPHgDDmWNxhXl?=
 =?us-ascii?Q?R2FUOZ3usbJ/yWk3XrixV4Pr75dm8Gq2miM2rjLOTjxWPVsIo7gSNGrTLXcu?=
 =?us-ascii?Q?Hjw3+/COm7yjDheWANVWDJBV1BBcwOQBRtp4/gYpvrTGFDHu576nNpN1Vblz?=
 =?us-ascii?Q?OIj8NKCjIDyYliLoqnjdrElQT02phZ5zbMZpkQC8SeRjRQ2VfZ1uN62xOQhk?=
 =?us-ascii?Q?4b0+z76UvDS+BpyGoQiX0+6thYLryAaa3HxMAzBg6jjrQpgmQhjOxZID8Ddo?=
 =?us-ascii?Q?D93Jvjn3wMjn73oEvCAV+bFQcx1llTktfmNzBmWhJvmnDPCYpExuZnzL54Yv?=
 =?us-ascii?Q?0aobEQYCrwW84HYmW8WdNc7zjWgbJCJcOh30B0u6EpghH3jAvpBj1+1HiS7b?=
 =?us-ascii?Q?3G/dQO3l4uFNkQNPThXk/iYS1aLERWO8j0J6KHpIBM7mb7yPzw2udW+Sy3sC?=
 =?us-ascii?Q?4NuGGNX9NsHkp09klSZK5T1YQhLsYxsgCA6B8SAZ9Ay5g2saKrJGSaKICXp3?=
 =?us-ascii?Q?MvKKhI16/Wb8K+luby1ZomoKfhp70Z1DHU9D9RGr0/MXBA+kXMhMeo79odRR?=
 =?us-ascii?Q?P2Yh0mJrMdj0Yo16IZpREUgiSlyd9MIhntA363F1+6DVSLULppohplHfBNiN?=
 =?us-ascii?Q?vzvHJj/8+pojZbYSJWs1YaXqct+KU2zY+eBQOWRk7siaMm8KlYLUJlGI9xzi?=
 =?us-ascii?Q?HCKd129mJDQDdOvgT8raankMLHsi7hjfrHS74Wj+2UJP8llHrE375G9l0wr+?=
 =?us-ascii?Q?qrmjKFsyRmgThr8iLhiY7C9tRaFnDUxHwRaYbPYGQ1pmVftqVWG0tGMFpu90?=
 =?us-ascii?Q?6CCmxNc65E3MgsjnWfRqxUi0zKfsV9aiDGIWEa3CQoUgPxn5HNm82Uas05Hu?=
 =?us-ascii?Q?GiJnARvA54kweSIrGRtV90XFB3zruDdeaYEWiGOGx264I1vRZFfLk/+VGtt+?=
 =?us-ascii?Q?Z6OYKrSOBcSCdfN+ej0Qey8rH5Boi0U7T5z9kzXHm3JnMwnHr922CouRP77r?=
 =?us-ascii?Q?BEbb51ueO86eYoDM5g7168sfGLXQmh8NwxOYZ/xup5Nya1i+QB4ubTH5/2UY?=
 =?us-ascii?Q?frIORF4xOlfOGGYHQ1vWOxfAa4H+C1yrq4HoaIeyJoDq1gctFOaLSkpVy7gb?=
 =?us-ascii?Q?ZvmWkMz4MkqDSoyvBqOmgvgmWnYbTR6g2LMY+B62NHGwb+mKCqhpyppxYVSZ?=
 =?us-ascii?Q?urr4d8H/+xmyVLkeaNLL9LXWq2M0JJRPNn9t/JnVJObIRLoyLCyESvUlnbgp?=
 =?us-ascii?Q?hbRyUC9RmJQAVdG2XgSEqUIZHna/yQwLo5H/c/adjxXVgC3+ERTcjvx9YQb6?=
 =?us-ascii?Q?QCcO4Cyvyjv0jU7Lau0DeIskl5JFB13CZDPV5InzisNC4XToHyqkDcOEBk4J?=
 =?us-ascii?Q?Otfe02YK0zGG3Ckt7OFKJ6OtQbKFGPzECFdOvp+XwPvhlvpfryEO1cnJndfN?=
 =?us-ascii?Q?+ZKD1Gb4qPF3dUXJbgvqj/8F6abuUL3PSZnuP7Voo37gWJo5QVZk9Vedq46t?=
 =?us-ascii?Q?qPD356GUZgzOlibFXQ1hx4HB+Q9hfxRsYV08bM9x/666ITkfJzD6RXr0dqA6?=
 =?us-ascii?Q?MASesOBGrOyEX/HlhpXyv+Mt8DKJ4qyY6jihUrd5Rv9hRIWaSx87HVnWfQWs?=
 =?us-ascii?Q?2j2tMQRNveFITw9ZLGOTZsEqvv550285IBb+iul6p6hSjcK5yQCc0jqXNBH6?=
 =?us-ascii?Q?bhFEHRimkHJ6Tz+5tcubCXZiFYKR8Rd8qkgmHSiOcA4sZfP2tP5wBHZiSN87?=
 =?us-ascii?Q?VCvZ/ijbVQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c2139a7-2b39-476f-82d1-08da278e62f8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 14:09:32.7514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3KKPkC7bX9YEVzF17B1uK0MEcjIWkNIdcrIr9UMMQGBBOy/gCTb4IlMIXQbr4BO+kTbsrfViLE/oCPV/0m2Dzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4030

On 26.04.2022 14:26, Bertrand Marquis wrote:
> Hi Jan,
>=20
>> On 25 Apr 2022, at 11:46, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> With debug info retained, xen.efi can be quite large. Unlike for xen.gz
>> there's no intermediate step (mkelf32 there) involved which would strip
>> debug info kind of as a side effect. While the installing of xen.efi on
>> the EFI partition is an optional step (intended to be a courtesy to the
>> developer), adjust it also for the purpose of documenting what distros
>> would be expected to do during boot loader configuration (which is what
>> would normally put xen.efi into the EFI partition).
>>
>> Model the control over stripping after Linux'es module installation,
>> except that the stripped executable is constructed in the build area
>> instead of in the destination location. This is to conserve on space
>> used there - EFI partitions tend to be only a few hundred Mb in size.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> RFC: GNU strip 2.38 appears to have issues when acting on a PE binary:
>>     - the new file positions of the sections do not respect the file
>>       alignment specified by the header (a resulting looks to work on
>>       one EFI implementation where I did actually try it, but I don't
>>       think we can rely on that),
>>     - file name symbols are also stripped; while there is a separate
>>       --keep-file-symbols option (which I would have thought to be on
>>       by default anyway), its use makes no difference.
>>     Older GNU strip (observed with 2.35.1) doesn't work at all ("Data
>>     Directory size (1c) exceeds space left in section (8)").
>>
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -461,6 +461,22 @@ endif
>> .PHONY: _build
>> _build: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
>>
>> +# Strip
>> +#
>> +# INSTALL_EFI_STRIP, if defined, will cause xen.efi to be stripped befo=
re it
>> +# is installed. If INSTALL_EFI_STRIP is '1', then the default option
>> +# --strip-debug will be used. Otherwise, INSTALL_EFI_STRIP value will b=
e used
>> +# as the option(s) to the strip command.
>> +ifdef INSTALL_EFI_STRIP
>> +
>> +ifeq ($(INSTALL_EFI_STRIP),1)
>> +efi-strip-opt :=3D --strip-debug
>> +else
>> +efi-strip-opt :=3D $(INSTALL_EFI_STRIP)
>> +endif
>> +
>> +endif
>=20
> This does sound very complex and using combination of ifdef and ifeq on a=
n external variable is not done anywhere else.
>=20
> How about splitting into a variable to turn strip on or off and let the u=
ser override a local variable setting up the strip options if he wants to ?
>=20
> Something like:
>=20
> EFI_STRIP_OPTION ?=3D "=E2=80=94strip-debug"
>=20
> And then just using INSTALL_EFI_STRIP to strip or not during the _install=
 phase=20

This "just using INSTALL_EFI_STRIP" is what we have with the present
version as well, and I'm not really looking forward to have two
separate variable to act upon. It was for this particular reason that
I took Linux'es module installation process as a "template".

> One wanting to use no specific option would have to pass INSTALL_EFI_STRI=
P=3D1 EFI_STRIP_OPTION=3D=E2=80=9C=E2=80=9D for example.

This particular example wouldn't strip anything aiui, and hence would
needlessly touch the binary (and perhaps make changes to it just as a
side effect: For example I'm observing the string table growing, which
I have yet to investigate in binutils).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:14:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:14:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313928.531734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njLxC-00050f-FM; Tue, 26 Apr 2022 14:14:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313928.531734; Tue, 26 Apr 2022 14:14:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njLxC-00050Y-Cc; Tue, 26 Apr 2022 14:14:10 +0000
Received: by outflank-mailman (input) for mailman id 313928;
 Tue, 26 Apr 2022 14:14:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njLxB-00050M-4E
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:14:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njLx4-00060m-QS; Tue, 26 Apr 2022 14:14:02 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.15.135]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njLx4-0007ME-KH; Tue, 26 Apr 2022 14:14:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=LnLZK9Ky1sRVX0UAQejY+HIaD84FqEF5E8jM+59MwMY=; b=zqE8kSvAn/VEO2t4HZmkZmhh5Y
	6PPAMCyzTZReST2FJOefNEvmFiqLxGCLRHIEjw98Zh4/dsd0XpPIIWuT/QDRBrAIAZ/IiJfPUuEt1
	Z4oTMQhTr0KVHkNVbrea8hqFHvIt2g4hkgB12DhN6qcgTkU0bX4MYziS2AMp1FBBpazs=;
Message-ID: <ecb4876e-c6d4-4bff-d964-92af83d39dff@xen.org>
Date: Tue, 26 Apr 2022 15:14:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
To: Jan Beulich <jbeulich@suse.com>, David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <f5a45b8e-644d-15aa-951f-aa6d89ce4c5b@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <f5a45b8e-644d-15aa-951f-aa6d89ce4c5b@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 26/04/2022 15:01, Jan Beulich wrote:
> On 25.04.2022 15:28, David Vrabel wrote:
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -162,6 +162,13 @@
>>   static char __initdata opt_badpage[100] = "";
>>   string_param("badpage", opt_badpage);
>>   
>> +/*
>> + * Heap allocations may need TLB flushes which require IRQs to be
>> + * enabled (except when only 1 PCPU is online).
>> + */
>> +#define ASSERT_ALLOC_CONTEXT() \
>> +    ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1))
> 
> At least one of these tightened assertions triggers on Arm, as per the
> most recent smoke flight. I'm going to revert this for the time being.

 From the serial console [1]:

(XEN) Xen call trace:
(XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
(XEN)    [<00000000>] 00000000 (LR)
(XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
(XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
(XEN)    [<00236864>] __vmap+0x400/0x4a4
(XEN)    [<0026aee8>] 
arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
(XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
(XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
(XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
(XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c

So we need to move out the vmap() from the 
__apply_alternatives_multi_stop() to apply_alternatives_all().

The patch below (only compile tested so far) should do the job. I will 
do further testing and confirm there are no other issue on Arm.

diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
index 237c4e564209..8004fc8a7d1a 100644
--- a/xen/arch/arm/alternative.c
+++ b/xen/arch/arm/alternative.c
@@ -170,7 +170,7 @@ static int __apply_alternatives(const struct 
alt_region *region,
   * We might be patching the stop_machine state machine, so implement a
   * really simple polling protocol here.
   */
-static int __apply_alternatives_multi_stop(void *unused)
+static int __apply_alternatives_multi_stop(void *xenmap)
  {
      static int patched = 0;

@@ -185,22 +185,9 @@ static int __apply_alternatives_multi_stop(void 
*unused)
      {
          int ret;
          struct alt_region region;
-        mfn_t xen_mfn = virt_to_mfn(_start);
-        paddr_t xen_size = _end - _start;
-        unsigned int xen_order = get_order_from_bytes(xen_size);
-        void *xenmap;

          BUG_ON(patched);

-        /*
-         * The text and inittext section are read-only. So re-map Xen to
-         * be able to patch the code.
-         */
-        xenmap = __vmap(&xen_mfn, 1U << xen_order, 1, 1, PAGE_HYPERVISOR,
-                        VMAP_DEFAULT);
-        /* Re-mapping Xen is not expected to fail during boot. */
-        BUG_ON(!xenmap);
-
          region.begin = __alt_instructions;
          region.end = __alt_instructions_end;

@@ -208,8 +195,6 @@ static int __apply_alternatives_multi_stop(void *unused)
          /* The patching is not expected to fail during boot. */
          BUG_ON(ret != 0);

-        vunmap(xenmap);
-
          /* Barriers provided by the cache flushing */
          write_atomic(&patched, 1);
      }
@@ -224,14 +209,29 @@ static int __apply_alternatives_multi_stop(void 
*unused)
  void __init apply_alternatives_all(void)
  {
      int ret;
+    mfn_t xen_mfn = virt_to_mfn(_start);
+    paddr_t xen_size = _end - _start;
+    unsigned int xen_order = get_order_from_bytes(xen_size);
+    void *xenmap;

      ASSERT(system_state != SYS_STATE_active);

+    /*
+     * The text and inittext section are read-only. So re-map Xen to
+     * be able to patch the code.
+     */
+    xenmap = __vmap(&xen_mfn, 1U << xen_order, 1, 1, PAGE_HYPERVISOR,
+                    VMAP_DEFAULT);
+    /* Re-mapping Xen is not expected to fail during boot. */
+    BUG_ON(!xenmap);
+
  	/* better not try code patching on a live SMP system */
      ret = stop_machine_run(__apply_alternatives_multi_stop, NULL, 
NR_CPUS);

      /* stop_machine_run should never fail at this stage of the boot */
      BUG_ON(ret);
+
+    vunmap(xenmap);
  }

  int apply_alternatives(const struct alt_instr *start, const struct 
alt_instr *end)

Cheers,

[1] 
http://logs.test-lab.xenproject.org/osstest/logs/169729/test-armhf-armhf-xl/info.html

> 
> Jan
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:23:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:23:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313934.531745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njM62-0006Uk-87; Tue, 26 Apr 2022 14:23:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313934.531745; Tue, 26 Apr 2022 14:23:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njM62-0006Ud-5E; Tue, 26 Apr 2022 14:23:18 +0000
Received: by outflank-mailman (input) for mailman id 313934;
 Tue, 26 Apr 2022 14:23:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=g8dr=VE=citrix.com=prvs=1083bc031=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1njM60-0006UX-KV
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:23:16 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 676409bc-c56c-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 16:23:14 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 676409bc-c56c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650982994;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=D4biCrex0PAqtimq9XcrlTuJ8+JgxJ9q9HH6bGP6ayQ=;
  b=EyP42WRK4hE+n0LdWju6L/LxtCHjmBb3MGfBMgaRIdpX4VsKiyj8xuRW
   zjMG+RcGcDEZ8uwUhQH2yUPblhYSl/r6ood8DLPQ8bmXEi1yaD/vtV7YN
   3Bp+NC/h4q2mWWIWePuZUrzppz4rDBKPkKXdOeVAv7tVIR8gvwjtkMlXy
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69354459
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5jJiGaO/TK0V/1DvrR2Gl8FynXyQoLVcMsEvi/4bfWQNrUor0zUDn
 TQZDD2OafqKN2vwLtxzaNix/R9T6MeBzdI1HAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z2
 vZAkK3zVykSYYrliu8CCglSTSFjIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQTK2DO
 5ZEOFKDajyQaQ1kIVkmUKgYhdv0g0HifDhyqUi88P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u12b2GBYBL/SE1CGItHmrg4fnmCrhXYsIGb6Q9/h0gUaSzGgeFB0XU1SgpfCzzEW5Xrp3K
 UUS9jA/sKsa+0miT927VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/
 gbXxZWzX2Up6eDLDyLGnluJkd+sETo2IEozJjEqdlQiysvov9gjhEzPU8k2RcZZkebJMT33x
 jmLqg03iLMSkdMH2s2HwLzXv96/jsOXF1Bov207Skrgt1okP9D9O+RE/HCBtZ59wJClok5tV
 ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRzwoxZPnqgKuVmSwXuF1e5eJFfUj
 Lf741852XOqFCLCgVVLS4ywEd826qPrCM7oUPvZBvIXPMUpJVTbpnkxPhXKt4wIrKTLufthU
 ap3jO72VSpKYUiZ5GfeqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9eWGZimtsRtfveyC2Mq
 o43H5LTm313Db2vCgGKoNV7BQ1bchAG6WXe9pU/mhireVE9RgnMypb5nNscRmCSt/kLxrqQo
 iHhCye1CjPX3BX6FOlDUVg7AJuHYHq1hShT0fAEVbpw50UeXA==
IronPort-HdrOrdr: A9a23:cArWzK8qvkjJih6u9u9uk+DaI+orL9Y04lQ7vn2YSXRuE/Bws/
 re+8jztCWE7Ar5N0tNpTntAsa9qDbnhPhICOoqTNKftWvdyQiVxehZhOOIqVDd8m/Fh4xgPM
 9bAtFD4bbLbWSS4/yV3DWF
X-IronPort-AV: E=Sophos;i="5.90,291,1643691600"; 
   d="scan'208";a="69354459"
Date: Tue, 26 Apr 2022 15:23:07 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>
CC: <xen-devel@lists.xenproject.org>, Marek
 =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2] libxl: Retry QMP PCI device_add
Message-ID: <YmgAS9jZ/at06PIU@perard.uk.xensource.com>
References: <20220422140703.13614-1-jandryuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220422140703.13614-1-jandryuk@gmail.com>

On Fri, Apr 22, 2022 at 10:07:03AM -0400, Jason Andryuk wrote:
> PCI device assignment to an HVM with stubdom is potentially racy.  First
> the PCI device is assigned to the stubdom via the PV PCI protocol.  Then
> QEMU is sent a QMP command to attach the PCI device to QEMU running
> within the stubdom.  However, the sysfs entries within the stubdom may
> not have appeared by the time QEMU receives the device_add command
> resulting in errors like:
> 
> libxl_qmp.c:1838:qmp_ev_parse_error_messages:Domain 10:Could not open '/sys/bus/pci/devices/0000:00:1f.3/config': No such file or directory
> 
> This patch retries the device assignment up to 10 times with a 1 second
> delay between.  That roughly matches the overall hotplug timeout for
> pci_add_timeout.  pci_add_timeout's initialization is moved to
> do_pci_add since retries call into pci_add_qmp_device_add again.
> 
> The qmp_ev_parse_error_messages error is still printed since it happens
> at a lower level than the pci code controlling the retries.  With that,
> the "Retrying PCI add %d" message is also printed at ERROR level to
> clarify what is happening.
> 
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> ---
> v2:
> Only retry when a stubdom is present.
> Move pci_add_timeout initialization.
> Use pas->aodev->ao directly.

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:24:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:24:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313939.531757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njM7R-00073n-JL; Tue, 26 Apr 2022 14:24:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313939.531757; Tue, 26 Apr 2022 14:24:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njM7R-00073g-G6; Tue, 26 Apr 2022 14:24:45 +0000
Received: by outflank-mailman (input) for mailman id 313939;
 Tue, 26 Apr 2022 14:24:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njM7P-00073Y-Qb
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:24:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d301747-c56c-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 16:24:42 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-AwlGhSk5O8Gtz6tGEvvu4w-1; Tue, 26 Apr 2022 16:24:40 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB9PR04MB8075.eurprd04.prod.outlook.com (2603:10a6:10:25d::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 14:24:37 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 14:24:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d301747-c56c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650983082;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GvQAGQAD/xjMH0rOFAgUmcx+I/82BCesuCMRj1nAJ9A=;
	b=DEm8uouKlXwZ+MGU+5f17YPBz0F48CjFXSXlNKhRtCWD/4u+a8bXkaG9eMuiOJW7zvJe8Q
	Tg8iZ7lwH0saK4RWqteOInWcFXEmETEzZLgjAEjmgSyxLrKAxM610VOUSpRKqRtDRVSKK4
	bwGsXXMarx1jGvW9ekc0xsoJSUjvk88=
X-MC-Unique: AwlGhSk5O8Gtz6tGEvvu4w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vu9S39fVbpQmqo5ZOv3bMbo7KuNja0QE+aUVLcUUC//R3p7KwncE+MGMO3F1SgBPV1qlWPUsnMiv0UlN3hvATiB98TmmbTi0ABvK1Lt2giIdXLEfYrGfyDS7J44FcUxbGUBs3VocpsaMazhKC5cWLHaJs1+cQGKOzErbJRs8qSSMVcbgLwH1ffViyPvWs6nFMz9TE0788leRo4KFP7AbcUQfreIQDGK3yRz6/Dx/1oH3kWQi68VY0WtP5n4iOv8wI9tMXAxSl2lvOnnDsrXPlonviy8BLzqdjoMq5pPyCQMcaFsii4HQDqRKMm3LirzCLZelnXRmscAM/Wj1+fJRig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kSUemzqtohV91lkmhBaOzyt4zzjFEIQ8k/mkTXSWZcE=;
 b=M1/S0mdFTfzhkcKOjfHuOdkA5Zwf7jnNDK4ZTdMkYBMVCTb/nsiGyCFcmsMYqkBkg6JkunFRIlnULqOJepvIcK3v8KH6aruuKIq6Bhc///3TkTFKS/Q/EgM+XBV6qMhYRZVOGQDAV+cb22C+8TeqAkc5LytzaakpexQXEUNpBBtuMcXhEf1UCMtdSGmXBAhua6Hz6+/IfJqNHCCv/ynYoDHWUfoK0rYIyjx4Wx3p/pPth+eDqzNPXA49txHLHO6Xd2wfK5N7hDEVO9fCiPc7ztpUv+HU7F00dIe+g6behe8BtS4KU5Mnrg6qgtwYNXYjynHCdC03/DxN8Ho5Obrzrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <16d9b9a6-b80d-ebbc-9577-c8579a6b5b17@suse.com>
Date: Tue, 26 Apr 2022 16:24:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 5/8] libxenguest: deal with log-dirty op stats overflow
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 George Dunlap <George.Dunlap@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0f019c5-4089-e19c-6041-044d6e93d80b@suse.com>
 <1b24d2b5-14ff-6e4f-6fa5-d91d75e315a4@suse.com>
 <068a468d-a7a4-bf24-264a-ac86b910dd82@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <068a468d-a7a4-bf24-264a-ac86b910dd82@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0012.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5c6684bd-c9bd-4e86-9b05-08da27907e21
X-MS-TrafficTypeDiagnostic: DB9PR04MB8075:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB807516D9F5D4B400EDC79A9EB3FB9@DB9PR04MB8075.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	08RNdbQDps5liaf+OrDg5W4CEHdl7KHtAmhWSQL0G8cLKaES3S2R0UVVZbvyz7aGQoyEC44HHIwluzfQtAjkEztqIFMBhnjoc2XZFVrC979Rg/RntJgpHb6JQE0G12IQ16iIx7vv0qoipPoM4n+5PN9DuCWEq4l1fKzCKxUGsg4Yeygk731IwPdUITiQEbnFnRLj2SEgY/eASgd2ooI2rFLvrsVoi3vEyJJmi7+4TDe+jG6EJKYu8vHO4HUUopsgFxJSCjAE2WFhyTHGpAAliORLqy3kg3HF0fGWIUaYe+reIn8OGsLk1OucO8rB//PEs9vHSiRDllSH6HL99yvakTmOqwK82nqnT3Shz0r/r8gYjVf7dHIevwmNGhmgnEOuMez6vQAP59c4sHFI9oLR6i4cLIHhOy8Ebz9/wOfSEmB75ro+H4PMjvjd52fvfzivUhpBqFkW09aQUiAeGRcFORGrsEYnfOAEs0rIBm2WUOqhSnODSSLl/zOMBy493lRXJmQOSpZVBQ0EJpbW2eVuW2gm16g1+GuF7AYTVT/cOECQFnQfj5nmKu3UB0uM/u7J9mHUGejHu1h5BgRFS3eb1qCFYV/fTaddzJR8tk1MN2E/wtNuQhR91T9bBTJQmSRSmoB/UPKLEtinBHykWnHVncrPvp/QkHqt/dK3gX6wnrha0rKJ0Uks3FaDoyyYMkAlPwT3erFzbSHXypiYlpHeuZ0q9ldQrkwVdfsCt5SEhMUTsPD8ZW2gWYIeKK8sa63oljpNRrvCBJFr/rpVhlDcwQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66574015)(8936002)(66476007)(4326008)(66556008)(8676002)(508600001)(83380400001)(6486002)(6506007)(53546011)(86362001)(2906002)(6512007)(2616005)(5660300002)(26005)(31696002)(38100700002)(54906003)(186003)(6916009)(31686004)(36756003)(316002)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oOP1Pj62YgBou+aXsOyAkC8h3jsy5eaqIIR8b0gOvZNvQrZeThCh8qEArbi2?=
 =?us-ascii?Q?ij5AgPc2xLWqa6djBu5Znr2r54csVD7cnU6ARnKpydA/LG1SHdIcaNWSsnOP?=
 =?us-ascii?Q?ppvvSf4n3/Qpp2fkK2hlml5C4h7Kw7Vz25vn6pkOzrVLAginC+Cj9Isg+Jvr?=
 =?us-ascii?Q?UygreyRL/oIzCyyfqTVJILtutcGV9Owcj7J08mYlPDSvtkasCN5gchCNKiFT?=
 =?us-ascii?Q?9Me82Sh6W4rPq2P+aj0vVU8319wwcBpeX2J9XcbIoxl1AiYCpCnIfuX6ExG6?=
 =?us-ascii?Q?Iv/xy0eCxirgeNKQkyPaSjq70zvKcIs8QoFnkR3K0PBLKA+srzCkfTb1QElB?=
 =?us-ascii?Q?a6NoOvYbqzUHseeXjoOR44zQqZ3IyNgYB9VzsrPjyxNYc55VhZVI4/uX61II?=
 =?us-ascii?Q?azKyp3VNL7WFZrQRmVmQ+kq1gV4yXy9fwKtnlX6syqXqjRgFmmkvJo6/Ar/O?=
 =?us-ascii?Q?EGAl05tSAK/VQmEZXvtlIFLEDT32qjZLhF8/burClN7OyflJWIpwNTeG5cIo?=
 =?us-ascii?Q?8ubS+Z+asllczgIuoAJZJ8Tph96DjRzcC4AUGlblSXcd0FWDI/+WdHF6CzNx?=
 =?us-ascii?Q?w88fofifUKJzNEeH8MJBnZBCN5Wr04HnsFgOUD6GIO7pc5knTgh/ADhQT82Q?=
 =?us-ascii?Q?qQMVzmXzN0/OoukS0BMFWuO1RIo2MRnK6p/exaIXg5ZxIhiLr85HGOdylx1t?=
 =?us-ascii?Q?7rAUFPBHXTKDGmjNJwnHQrLoFi9PmQohY4rpI62LFLVnqVEZ4Ciz/SzRiDaW?=
 =?us-ascii?Q?IdIBKSsZPMyMpH+u0Y/MSFYqLrzBIWvIeKMVExZj/57Bdvso/gQlf9Xd5CM+?=
 =?us-ascii?Q?9ZwkhQ2qG1n6VJDLURCpteZeYcsoTTYvt7xDiEmUhaDHDMpV09Iay+yJNN9W?=
 =?us-ascii?Q?/frEW7pyahpSNFiODNGPeQgpYdqUeHHrzsW6qfVDi37NyUfzwclULYIQrvA2?=
 =?us-ascii?Q?h05r3IbMjXsmR6m76cCAoGyny2Ou87o/PseNGS3br5p2kar6fIXFrWwzFRqL?=
 =?us-ascii?Q?DUqWptG0iCcSzpkJJGRGy/5X+gRxYLyMfsD3t2/Ca0/fEaUWuDgJqOeizFEG?=
 =?us-ascii?Q?oqRav09UehxPlIgTHTwvE7rT4kftH5PWHwwJ0copCmSc8+EYEDaeWsEWLGgW?=
 =?us-ascii?Q?0rhtdP2slziseSwOCAn+lRwHuhdvG9tQ7w4xjKTgWOr/80mm/ynEhUhnn23A?=
 =?us-ascii?Q?zYeXC+njPLWJQ5n8dDfQ+/WgO4Jf/3URZLnE2gSYVeglZQlGUb0Pknv85rYC?=
 =?us-ascii?Q?RzRftVA82DkE+5lWPPT1Ke/hKDSrlkwj5TsP8xl9Qc9Kn6uvknCVrMv5CMUg?=
 =?us-ascii?Q?S6M73rr7dnQGDPW+JDeJSWtVfYiDDv/oQrK1ScVOKn3ay6UyyCVYaAwl1UVS?=
 =?us-ascii?Q?/uLm2XVHMMUKQKW2jjxx0cxIhbtBOTbF1znw37qZAziiO+UYWIT7CztDwQqw?=
 =?us-ascii?Q?yhkN7EqiAiQ67sHGMR14njOAPYFnnAjyXda8bQ/JaIAzeKVL4qmffOdtK4NV?=
 =?us-ascii?Q?TC7lnGXeYL+lck08R+k5pYeN1tizVsBe5AQDW7atrgZWrCP4X5kvq07e3zpL?=
 =?us-ascii?Q?+/k8MLfhfwL17RrM43Y9VdnNaVvOdi8/kd9uG2dmKpdj9vtMxW3vTkOrGYr5?=
 =?us-ascii?Q?xgQIAOCLo3V0zQYeT1ptxzfUKlCl0Z8S7yN57uC3c7cELQI97NCtGubV9pa6?=
 =?us-ascii?Q?icGjEWrGIhZkNtoKGsSOq7mSG7tLYQCpOT+5lYaeDPCzlLM59zO6ry2B7L4f?=
 =?us-ascii?Q?MpoyEDGWpQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6684bd-c9bd-4e86-9b05-08da27907e21
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 14:24:37.3127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fFcn/tEDOzEYvEtrRvh3Jkm+vGCiu6X9kJIQ567XNWXStLgPXXyTwvPMRql40mY9ECgZEHd+RY6poyxYQDUvFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8075

On 26.04.2022 12:54, Andrew Cooper wrote:
> On 26/04/2022 11:24, Jan Beulich wrote:
>> In send_memory_live() the precise value the dirty_count struct field
>> gets initialized to doesn't matter much
>=20
> Yes it does.
>=20
> And as you keep on refusing to actually fix the bugs pointed out during
> review, this entire series is NACKED, seeing as you've also repeatedly
> failed to address feedback from previous revisions on other patches.

Excuse me? Afair I did respond back, requesting further input from you.
It is this input which hasn't come forward; I don't see how I could
have made changes when I don't know what exactly I need to do. This is
emphasized by Ian giving a provisional ack on 'libxenguest: short-
circuit "all-dirty" handling', depending on you not proving him,
J=C3=BCrgen (who had reviewed what is now the first two patches), and me
wrong. There again was no response from you. In such a case no
response can only mean "what I've heard back was satisfactory".

Also may I remind you that you're not in the position to NACK this
entire series. You can latch '"open" objections', yes, but it is at
best unfair to record objections without then working towards
resolving them, by simply remaining silent towards the request for
further input. This looks to be a repeating pattern, which is rather
frustrating. I fully recognize that in many areas you know things
better than I do, but this doesn't mean you're always right and I'm
always wrong. Therefore, like e.g. for patch 1 in this series, you
will want to actively convince the three people who think the change
is okay, rather than simply saying "no" with apparently none of the
three understanding why you say so.

I also view it as at least questionable behavior to NACK an entire
series when there are clearly issues which want taking care of. If
not by the patches in their present shape, then by whatever is
suitable (working out of which is why discussion needs to continue
until clarity is actually reached).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:25:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:25:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313944.531767 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njM81-0007dn-04; Tue, 26 Apr 2022 14:25:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313944.531767; Tue, 26 Apr 2022 14:25:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njM80-0007dg-TW; Tue, 26 Apr 2022 14:25:20 +0000
Received: by outflank-mailman (input) for mailman id 313944;
 Tue, 26 Apr 2022 14:25:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2CTZ=VE=gmail.com=sagigrim@srs-se1.protection.inumbo.net>)
 id 1njM7y-0007dO-VY
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:25:18 +0000
Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com
 [209.85.221.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1e53f04-c56c-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 16:25:17 +0200 (CEST)
Received: by mail-wr1-f54.google.com with SMTP id v12so18906770wrv.10
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 07:25:17 -0700 (PDT)
Received: from [192.168.64.180] (bzq-219-42-90.isdn.bezeqint.net.
 [62.219.42.90]) by smtp.gmail.com with ESMTPSA id
 j39-20020a05600c1c2700b00393ee3deaf1sm5525786wms.9.2022.04.26.07.25.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 26 Apr 2022 07:25:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1e53f04-c56c-11ec-a405-831a346695d4
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=nWpDQmZNg8zKVk12QskQ7NNS05C4fI/JmZBKLdKyu8Q=;
        b=XQem0bzqYPnbs6HwBCdmcZg/pJT8ewyp1Xn3qGt3fjUnBD8NmYwAGDLvvM4EtcOA+z
         QqmYmbPI1Tx6L/TzyT67ONA/mOk498hT1CKZ8i1u46vloGLVllv2i3ctvCFr9TOQ8WKX
         0R8Tm95ycFmlU6Fj1O6jwno+8vNR2NlvM2QbTQwSOyPjQZRaOIpebK8ellnh6v6TjNts
         deRPPz9oqVdZR25iNqdPC/4b53jo2ZubGpcMaO1OPPrRdQemHsL+bTqn2UwGBWi1raPq
         Od9ARu/1A/WYAjGputqh2XGOSxmW4UetznNbe/hoMvirRMZ9c6pGMcg9yThDfoENhVUB
         Y8dA==
X-Gm-Message-State: AOAM533QIH2yp6H288Jl+iF0K8NTv64vTe6FwdiopW7OczDt3LledD3K
	5s1Dut3TqPB5LewzpbcfyWg=
X-Google-Smtp-Source: ABdhPJx+tGjrozc2v+hkDAQGkKaaKd6tvj25GGtU09S+2P3NV6/kZmjHHHaKsKLq0MduUfwGvhoEcw==
X-Received: by 2002:a05:6000:1a8d:b0:20a:ab7c:efb1 with SMTP id f13-20020a0560001a8d00b0020aab7cefb1mr18901071wry.716.1650983116938;
        Tue, 26 Apr 2022 07:25:16 -0700 (PDT)
Message-ID: <c658f5cc-7b9a-84ee-ac22-cefc03e3dbf2@grimberg.me>
Date: Tue, 26 Apr 2022 17:25:12 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 09/11] nvme: remove a spurious clear of discard_alignment
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
 Johannes Berg <johannes@sipsolutions.net>, Josef Bacik
 <josef@toxicpanda.com>, "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
 Jack Wang <jinpu.wang@ionos.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Jason Wang <jasowang@redhat.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Mike Snitzer <snitzer@kernel.org>,
 Song Liu <song@kernel.org>, Stefan Haberland <sth@linux.ibm.com>,
 Jan Hoeppner <hoeppner@linux.ibm.com>,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 linux-um@lists.infradead.org, linux-block@vger.kernel.org,
 nbd@other.debian.org, virtualization@lists.linux-foundation.org,
 xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org,
 linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
 dm-devel@redhat.com
References: <20220418045314.360785-1-hch@lst.de>
 <20220418045314.360785-10-hch@lst.de>
From: Sagi Grimberg <sagi@grimberg.me>
In-Reply-To: <20220418045314.360785-10-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:29:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:29:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313958.531778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMBl-0008Pa-GF; Tue, 26 Apr 2022 14:29:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313958.531778; Tue, 26 Apr 2022 14:29:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMBl-0008PT-DO; Tue, 26 Apr 2022 14:29:13 +0000
Received: by outflank-mailman (input) for mailman id 313958;
 Tue, 26 Apr 2022 14:29:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njMBk-0008PN-DG
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:29:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njMBk-0006Gt-2o; Tue, 26 Apr 2022 14:29:12 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.15.135]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njMBj-00085q-T7; Tue, 26 Apr 2022 14:29:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:Subject:From:Cc:To:
	MIME-Version:Date:Message-ID; bh=jw5zm+ekx7e9OO3oJJ/BOJGfx66IPecbc828Mg2vnQw=
	; b=Fw75YzsWHiADtHGk1tvUPOhYTurm1Tv6RwBWby0FNsITLX9Q1Q1ulswRVT5y34KbIVYiym2MS
	B8xqwXO7W7EitL3ClPEhdulHEItV6s0f/IeGFdvxoUTb5iSI5f1FP4CowoabkOX00C8KFhv4JFDcX
	WjEO9Ccv7QfbSk0WURdqg=;
Message-ID: <e57eae94-6b25-0425-12f0-c09d1233e27a@xen.org>
Date: Tue, 26 Apr 2022 15:29:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Paul Durrant <paul@xen.org>
From: Julien Grall <julien@xen.org>
Subject: Potential race between shutting down a domain and handling I/O
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

While looking at the I/O handling code, I noticed that hvmemul_do_io() 
contains the following code:

  333             rc = ioreq_send(s, &p, 0);
  334             if ( rc != X86EMUL_RETRY || currd->is_shutting_down )
  335                 vio->req.state = STATE_IOREQ_NONE;

Looking at history [1], it looks like the second part was added to cover 
the case the I/O was not handled because the domain is shutdown down 
(i.e. vcpu_start_shutdown_deferral() returned false).

However, I think, it would be possible that the request to shutdown 
happens *after* vcpu_start_shutdown_deferral() returns true. In which 
case, we would set the state of the I/O to NONE. It is not clear to me 
what could go wrong, but from the commit message it looks like this 
wasn't the intended behavior as the I/O would have been sent to the IOREQ.

For completeness, I think a similar issue would happen in handle_pio(). 
We would end up to re-emulate the I/O which may have side-effect (?).

Note that the race is tiny and I haven't been able to reproduce it so 
far. Can someone confirm my understanding?

If there are a bug, then I am thinking to extend hvm_vcpu_io to indicate 
whether the I/O handling was deferred. Any other suggestion?

Cheers,

[1] 
https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=0c0cbf72cf9f28070cc5d49955b0a00df5c1d114;hp=d1370961810d3b1630e0ad5e28e5cfc8dcfe2b9b

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:31:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:31:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313964.531790 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMDs-0001Kz-UC; Tue, 26 Apr 2022 14:31:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313964.531790; Tue, 26 Apr 2022 14:31:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMDs-0001Ks-R8; Tue, 26 Apr 2022 14:31:24 +0000
Received: by outflank-mailman (input) for mailman id 313964;
 Tue, 26 Apr 2022 14:31:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njMDr-0001Km-Jv
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:31:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b57953c-c56d-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 16:31:22 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-Ecu4GaVEPv-IjKhEEyeTbQ-1; Tue, 26 Apr 2022 16:31:20 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB5105.eurprd04.prod.outlook.com (2603:10a6:208:c6::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 14:31:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 14:31:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b57953c-c56d-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650983482;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CI/BjeY9k8CyU3N0LNknU8J47Xrk2Iq06GNdksumwdM=;
	b=Yhao4i9/lnfWMAlyfDyBoj79nP+dCmHClZCXY+CnELDCc/eAjQLSIuwFPxYoFuJHgWvMxx
	4jpdHJNzjXakBXgE4Q4FgOijCs3a53VRe41XLgxP9i3TL5cCZgf9j4uxmfEl21l9ad6khI
	ff69yrvkWhSsHX53mDJd9UfLhpb6JJM=
X-MC-Unique: Ecu4GaVEPv-IjKhEEyeTbQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=McFq7a9dkaJ9Gn6lB1ip39MSBmz6G2qcm1yJYuEv/XdslMob0avYvp34zPoTbp4okCUU/i4HKF9F7FccJ8YQcfrNI+3rOrfXjEEHV6YDiQ67nLJrlTzPNPHQaEiGpFsnCkVRbNFSKn67rPIpB7eXrmhvbYHeUMGlhYdFSribHWM2CqPHn4ZMnFNaMV46fKWhVcQ/6SdEgJMA9IYov0wxiuoHNBZ6l4gVhFDInEqCKvrfkj96SjgeVMG9izGCE9R0nQegNkrwpwgCgYvjPkQb1IvgzaH19E1lfI1Jr/OTXfelsCvJVOIROffz+JxOkzMj5rElVA/hvCkPxLqB/2PDbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CI/BjeY9k8CyU3N0LNknU8J47Xrk2Iq06GNdksumwdM=;
 b=mTHX6DqM/ibEzd/F6BqaY7XRUloqb4QDx9BV1qsGxAQilZQBUZXc8l+ePQCrJ/yDI6m9WC1mKRxqdySyQE9BHbsQI5d0FvDor8Hm4BBXtMXX13NfobSTdIW2195VG94IjuwM2Ob0GRk5EvbxF0qKhQXnaJH6Wq7BdPPU5jjwPJMYCaMJRPs0OeNavG2ga8fE8ywZ0EgKQgfUr1667hFvmnZHP3BkMqOcFZWhx+cGvJBTLeXyCEpkjJP8SEqu0MaKkcVFDhYaih7+Ocv98wsaTyEvmz+C+6wVa8bB4E8K1RNIFm28OphsMKGxohl/mV8bJUk9TC1B7NL0N/Hn29NNag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <413651ff-55a4-61cf-efed-7ac82f7c6723@suse.com>
Date: Tue, 26 Apr 2022 16:31:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from
 x86 to common
Content-Language: en-US
To: Wei Chen <Wei.Chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-3-wei.chen@arm.com>
 <3e5b9708-7732-a56c-f2e8-d5d39fd2093e@suse.com>
 <ed949bf4-ba9e-9ad7-b2fe-c63526ca42e5@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ed949bf4-ba9e-9ad7-b2fe-c63526ca42e5@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0008.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::21) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ab8e3a80-baa8-4ab2-94d2-08da27916d84
X-MS-TrafficTypeDiagnostic: AM0PR04MB5105:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB51057814A1AFD3165E7A877AB3FB9@AM0PR04MB5105.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wqHd65fZl0RxQkAN6GGU6m7RQVk1vRpkP61dzeqXzfJ8M+ZQo4t0As2y9DUkH3ZhKI+1vb7Et6wxR7orinmO1feViflvVXRI54sgPzG25AzaVP975iYtce9T6YyhKtiPkNGvBaULnNrBFoqpABlpyF9H15MVhWK9ltkBfS8hcYWQyMTlPuyAgJzMvMrgYNIWN6hFOcWQd1jQ/FykMzlWmjcfL2C8KkFCz0uu/LxAJSpaAV8RbyVNVo5OlTU4HPjAf1n5nNbLiTwY04mDAtYnZJpZtKJK8Luay217VdN54jY2kmwZCU0PwPu3e1UK1YGADPI09e8D9jMHHWDZqAnJYtLjEBaFGTJ57AI6rVSp11uD/ZIMQFIG0aRKqQV99WCcI1VVq5i3JaaGFflCDAsbeUyk4bgyNDtw8oDoP6UGSfIleLjsYAoJ+piigTHt9vjlyvf4xSFtPSGyYjTo2R2+AkvpGV7kbM2XKdbAf04IfjZ5JUyOSoI7tzc/UwC42i6YXMMB9BGlBX3hxG7NMhPxRN42VMAo1Lck96O+4aI3Z4Cc+tou4ouX3XpPYpDD6b63BHFHK29pkWc6dKVXoa2mOuYg2iwoHET4NXzlER80n2uHw1GvlAoZIUp+XKDUStqWnywzYISpCK35kuhJAZ9adQHcF+FGgVdGPIOKTOpAejnqpgiw20xqdZ1G+yQzlNxGqxhzjeq+0372b3ThjpAG4ck3RbY1QcPyi+bL4iKS8lpWlBCcOVM1Wkm7LtFMj//R
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(2616005)(8676002)(66946007)(4326008)(66476007)(186003)(316002)(86362001)(31696002)(31686004)(66556008)(8936002)(5660300002)(6512007)(26005)(83380400001)(6486002)(54906003)(6506007)(508600001)(53546011)(6916009)(38100700002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TUdJWExxK3o0YlVZMTQvUit6WUFDaE1kMEkvWU9zSkhTQ25yUHdaR1Y1RWJj?=
 =?utf-8?B?STZ5ZDhJdmg2WjRXa2N4MW45SVA2ZWJFSXpCWUR0anRKOGNvSURrUnQwem9X?=
 =?utf-8?B?aVBJYWhoK1E4cjF5bzRMNmZqRVJxblRTWnRubExFSllQU0cvUm9MNnhRbTJP?=
 =?utf-8?B?RDdCWW9wbWcxTGg1TmNrRzFwMFZ3Y2NLeWQxMExiTi93UFZhQzZzUFZ6enBZ?=
 =?utf-8?B?djUzYjk1NzM2N0cvZ05lK1dZZHlSSXlGRmI0eTd5TkZZNHdxWjhRQkd1dk85?=
 =?utf-8?B?cXBxRDFhS1FmUXR3ZFUrYTVUTW56cFJ4QzdxZFMrUXQwbER2c0VrdXpjVXVM?=
 =?utf-8?B?L2xHTEp2TnhwQUp1bll1c2VHU0dLQmdOTmltUHloeUhudTVtalZLZC8wa0tD?=
 =?utf-8?B?V1J0ME1WQTRTZlN2YkNhN3FHZGRSMkVDbWFHZHc1Tm96VjQzYmNIeGJlWTBL?=
 =?utf-8?B?ekhobUkvQlhBSFJ5dVVUNnNhTTVVOVlMczdrSmpaRzc5UGlHZ1pIcG5XaUNF?=
 =?utf-8?B?ckJrU2c5OVFDWGVadzFEUmRRK3YxRXFPNm5WNEhJV0d5OWVIRDExNDNwcHpm?=
 =?utf-8?B?SzdwZUtXT1VMUUx1ZmNlYTBZZ3hsV3RaWmNsS0pQV245eDIxdVQ1UzhtSXhH?=
 =?utf-8?B?RWVFaTZsTUVlYVRQbzR2c1ZsWVh5MHgzSXlib1pwTmtZMGhmVDNUc3Q3YW0y?=
 =?utf-8?B?MzRVWDI0L0tnQllDZFpJVU5ITHdybmxhdEw0SFVmMnlNc1JyM05SRGZjZzNx?=
 =?utf-8?B?NTRqdHRYWG1yS0RNWG41eHU1aUd5Ujh2dmlIZ252dHhOamtsd0lwQ2xoUGpy?=
 =?utf-8?B?VGtkN0dFaGw5SnRnMm5DQnVXdHFrQ0N4RHhaenhQUkhPVndKb2lVd2Q0dk1Y?=
 =?utf-8?B?MzVSVmYvbFN3WWY4THpiWWdDTlIxayt5cmt0RjliK2hjbzd0QnZFNUJUaXJO?=
 =?utf-8?B?SncvVmZndk41QUFQQlRIWEY1L0dveVJkVU0wMm9jUS9ab2hZQVFtTjdFUkdF?=
 =?utf-8?B?bXljV2kxWlh4MTBMeWtmWlRMTDU5Ym9QTm5ESTJVVUw1TERHU21oWENlZXEx?=
 =?utf-8?B?Skl6YnoxNTMxeE1Mc3pDaTE3QmFmbnNxRG84bEp0WldwWmtOTlhiaURZYW5S?=
 =?utf-8?B?Q3A4ajNaOTFoNWlNRGozemE5SHVuUDM3SXIxNDIrRzA5ODM0aXNuT2hTL1Rl?=
 =?utf-8?B?TVdmc3hXUk5EaWc3Ui9FWk1UeTBpcVd2bFNzUkRDQ0FQdnhhNHI2NGUveFpu?=
 =?utf-8?B?NktFVmE5ajVkcDhxRHk4VHZnTHVlMThPZTB3ZlVWL0xETmQvN1cyQlQ1aUgz?=
 =?utf-8?B?MmpJSkpQbU16U1l6aEw1ejFUNjlUcGUyT1RWZlZwb2ZYSE5nalRZV3c1dWVw?=
 =?utf-8?B?alZSRlA0NTlVMEM4MlRxRjJNTGxqQUFKUXkvSVpBT0JSTmlDcEZqK2FYNVIr?=
 =?utf-8?B?TnBackNLZ1IxK0l3WXhhdDIvRUlYRG1HaENRQURERTlhZlBKbE11YUpVK2Qz?=
 =?utf-8?B?U1NJVDUyM1FVT3dFemxxZkw5c0gxSWt6Q0hLblNabVJVUjRENmRNV1Bkd1NN?=
 =?utf-8?B?cEVxV2J0SnpZWkVvcTBpN2NVem8ya09CWUMxY0tQeUNLWjFOVDhvU0piMGJo?=
 =?utf-8?B?YlZyVmdxTVdiMHF5ajVPWm5TL3UweTFOeEpZVk9XTDJqRmlPTzdid3VhenFV?=
 =?utf-8?B?Mm9kZlNMcXBVbmVmNGJuMWk2ak1FbG1nSFlIaUMvSEpNUzh2cUxjSFA3a2Nn?=
 =?utf-8?B?U1hUc1NxR3ZoZnRIZE82N01DWDdkeDhlTHNmTWtuT0lteGtiNDduOS9PSXZK?=
 =?utf-8?B?Q3VMOTYyTDduNlFHbWhCSHR6cDI4U2RBRkQ5VDFPRG5mS05YUEViK09kQ1JB?=
 =?utf-8?B?N1Evc2M3emlSNW52djdOTUdaaVdmU0lGV0RJY2xEYjVaOTF1QkFJMUhCMzA4?=
 =?utf-8?B?R25RSTY0RzNKcGdLdlVjOVoyM0FVVk50VFhpV0FZdzIvdnVQTUJONTE5dklX?=
 =?utf-8?B?c0Y1ajRVemNMQUdWTTV2TC9GUVRWRE5RcVRhdG5XNmN5QWQ2Uy9hcmhwcUZa?=
 =?utf-8?B?UlFRT0krOWpyZ2MvVGdPdjVNQnREL3BiaUlZWnpqUG9wd2RHNWt5RE9Ud0V1?=
 =?utf-8?B?TUFiR2tEUTgyREYyenBJMnlaYWxFZzZ0Wmcwc3Y4QzY3NzlEMjNHOThGbHd5?=
 =?utf-8?B?WDRzNnJVWVRrWTFIeVZLQjRvYW82dWY4YXJ3bzg3bFZHczZ3c1RvWFExTEl4?=
 =?utf-8?B?NWNSVjZNUjBkcjdRTjhOY00vSnFScDIydUlPQUdsdTkySVdOQW5vcVI1Rncz?=
 =?utf-8?B?TmlncEkzeC95czlqbmpNaUErZE42WVVTb0JtdHoxT0RKcHpXbU81Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab8e3a80-baa8-4ab2-94d2-08da27916d84
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 14:31:19.0152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ddXO7VX/MMX30/y2wiuageXV57I6uRSWqUraqd+iBwX1c8c54O3tsq4yiSV/9k2mOrwhd3iKZs0mR2gf7K897A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5105

On 26.04.2022 12:37, Wei Chen wrote:
> On 2022/4/26 16:53, Jan Beulich wrote:
>> On 18.04.2022 11:07, Wei Chen wrote:
>>> diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub-x86.c
>>> similarity index 71%
>>> rename from xen/arch/x86/efi/stub.c
>>> rename to xen/arch/x86/efi/stub-x86.c
>>> index 9984932626..2cd5c8d4dc 100644
>>> --- a/xen/arch/x86/efi/stub.c
>>> +++ b/xen/arch/x86/efi/stub-x86.c
>>
>> I'm not happy to see a file named *x86*.[ch] under x86/. I think the
>> x86 file wants to simply include the common one (and the symlinking
>> be suppressed when a real file already exists). Naming the common
>> file stub-common.c wouldn't help, as a similar anomaly would result.
>>
> 
> How about using stub-arch.c to indicate this stub file only contains
> the arch specific contents? However, we cannot predict what link files 
> will be created in this directory in the future. If someone needs to
> create a stub-arch.c link file in the future, can we solve it at that
> time?  Or do you have any suggestions?

I did provide my suggestion. I do not like stub-arch.c any better than
stub-x86.c or stub-common.c.

>>> --- /dev/null
>>> +++ b/xen/common/efi/stub.c
>>> @@ -0,0 +1,38 @@
>>> +#include <xen/efi.h>
>>> +#include <xen/errno.h>
>>> +#include <xen/lib.h>
>>> +
>>> +bool efi_enabled(unsigned int feature)
>>> +{
>>> +    return false;
>>> +}
>>> +
>>> +bool efi_rs_using_pgtables(void)
>>> +{
>>> +    return false;
>>> +}
>>> +
>>> +unsigned long efi_get_time(void)
>>> +{
>>> +    BUG();
>>> +    return 0;
>>> +}
>>> +
>>> +void efi_halt_system(void) { }
>>> +void efi_reset_system(bool warm) { }
>>> +
>>> +int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
>>> +{
>>> +    return -ENOSYS;
>>> +}
>>> +
>>> +int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *)
>>> +    __attribute__((__alias__("efi_get_info")));
>>
>> I doubt you need this outside of x86.
>>
>>> +int efi_runtime_call(struct xenpf_efi_runtime_call *op)
>>> +{
>>> +    return -ENOSYS;
>>> +}
>>> +
>>> +int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *)
>>> +    __attribute__((__alias__("efi_runtime_call")));
>>
>> Same here.
>>
> 
> You're correct, I check the code, Arm doesn't need above two
> compat functions. I will restore them to x86 specific file.
> 
>> Even for the non-compat variants the need is un-obvious: Are you
>> intending to wire these up anywhere in Arm or common code? This
>> of course is once again pointing out that such code movement would
>> better be done when the new consumers actually appear, such that
>> it's clear why the movement is done - for every individual item.
>>
> 
> Yes, but I didn't deliberately ignore your comment from the last
> series. I also hesitated for a while when constructing this patch.
> I felt that this independent work, maybe it would be better to use
> an independent patch.

Well, it of course depends on further aspects. If it had been clear
that what is moved is actually going to be wired up, this being a
standalone patch would be okay-ish. But with this unclear (and, as
per above, actually having gone too far) it's imo better to move
things as they get re-used.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:33:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:33:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313970.531801 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMFn-0001wT-BD; Tue, 26 Apr 2022 14:33:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313970.531801; Tue, 26 Apr 2022 14:33:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMFn-0001wM-7j; Tue, 26 Apr 2022 14:33:23 +0000
Received: by outflank-mailman (input) for mailman id 313970;
 Tue, 26 Apr 2022 14:33:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cWqi=VE=cantab.net=dvrabel@srs-se1.protection.inumbo.net>)
 id 1njMFm-0001wG-1s
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:33:22 +0000
Received: from smarthost01b.ixn.mail.zen.net.uk
 (smarthost01b.ixn.mail.zen.net.uk [212.23.1.21])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d1c981fe-c56d-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 16:33:20 +0200 (CEST)
Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk)
 by smarthost01b.ixn.mail.zen.net.uk with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <dvrabel@cantab.net>)
 id 1njMFh-0003Fq-Cr; Tue, 26 Apr 2022 14:33:17 +0000
Received: from apple.davidvrabel.org.uk ([82.70.146.43])
 by pear.davidvrabel.org.uk with esmtp (Exim 4.94.2)
 (envelope-from <dvrabel@cantab.net>)
 id 1njMFf-0018Vq-4c; Tue, 26 Apr 2022 15:33:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1c981fe-c56d-11ec-8fc2-03012f2f19d4
Message-ID: <0b7c4df3-e6f2-7791-4e8e-9655eb8c6f6f@cantab.net>
Date: Tue, 26 Apr 2022 15:33:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-GB
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <f5a45b8e-644d-15aa-951f-aa6d89ce4c5b@suse.com>
 <ecb4876e-c6d4-4bff-d964-92af83d39dff@xen.org>
From: David Vrabel <dvrabel@cantab.net>
In-Reply-To: <ecb4876e-c6d4-4bff-d964-92af83d39dff@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 82.70.146.43
X-SA-Exim-Mail-From: dvrabel@cantab.net
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	pear.davidvrabel.org.uk
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,NICE_REPLY_A,
	SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no
	version=3.4.6
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000)
X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk)
X-Originating-smarthost01b-IP: [82.70.146.41]
Feedback-ID: 82.70.146.41



On 26/04/2022 15:14, Julien Grall wrote:
> Hi,
> 
> On 26/04/2022 15:01, Jan Beulich wrote:
>> On 25.04.2022 15:28, David Vrabel wrote:
>>> --- a/xen/common/page_alloc.c
>>> +++ b/xen/common/page_alloc.c
>>> @@ -162,6 +162,13 @@
>>>   static char __initdata opt_badpage[100] = "";
>>>   string_param("badpage", opt_badpage);
>>> +/*
>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>> + * enabled (except when only 1 PCPU is online).
>>> + */
>>> +#define ASSERT_ALLOC_CONTEXT() \
>>> +    ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() 
>>> <= 1))
>>
>> At least one of these tightened assertions triggers on Arm, as per the
>> most recent smoke flight. I'm going to revert this for the time being.
> 
>  From the serial console [1]:
> 
> (XEN) Xen call trace:
> (XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
> (XEN)    [<00000000>] 00000000 (LR)
> (XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
> (XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
> (XEN)    [<00236864>] __vmap+0x400/0x4a4
> (XEN)    [<0026aee8>] 
> arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
> (XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300

An allocation inside a stop_machine_run() action function. That is what 
the asserts were designed to catch.

I did try the run the GitLab CI pipelines but it is setup to use runners 
that are only available to the Xen Project group, so forking the repo 
doesn't work.

Can my (personal) GitLab be added as a Developer to the Xen Project 
group? I think this is the intended way for people to run the CI 
pipelines on their own branches.

David


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:36:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:36:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313980.531811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMIy-0002ag-Pm; Tue, 26 Apr 2022 14:36:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313980.531811; Tue, 26 Apr 2022 14:36:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMIy-0002aZ-Mi; Tue, 26 Apr 2022 14:36:40 +0000
Received: by outflank-mailman (input) for mailman id 313980;
 Tue, 26 Apr 2022 14:36:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=b/nE=VE=citrix.com=prvs=108c91f88=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njMIw-0002aS-IY
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:36:38 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 45deecf5-c56e-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 16:36:36 +0200 (CEST)
Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 10:36:33 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM5PR03MB3274.namprd03.prod.outlook.com (2603:10b6:4:40::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 14:35:19 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 14:35:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45deecf5-c56e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650983796;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=fbINpKt/1RYyj1cWGsZ3YaiNFHNjyGzplUSls67ClYA=;
  b=WLO4eMCrCrL6pQBla3Wx1S0qfrLzBID9DNcvLe0YvZ4XWPH53X2kTtbq
   gCjq3FtY7bbSz+2ZpHlt3tRQNVugda2nwv1C81VUU+u1puAGKr3WKuyM+
   SFYrdJhU84kwYGk/T9jBmpUKZSOb1RfH5l2GvTs/bWWiVZumQiiavVIN6
   4=;
X-IronPort-RemoteIP: 104.47.70.103
X-IronPort-MID: 69836072
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:WQ41U6i7ikOCkDdkR1pweS+AX161rREKZh0ujC45NGQN5FlHY01je
 htvC2mDOP+IZGL3Lot2aoqy8U4P7cXRzYcwTQNlrS8xQSIb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nT4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YVowI/WUh8YgaSRjPXBgFK9a0oKbGWfq5KR/z2WeG5ft69NHKRhueKc+paNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuocehW9r7ixNNa+2i
 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJpsjiIklQuitABNvLrI5/Vd5l8r3qD/
 FjB/ULiHigWN/2AnG/tHnWEw7WncTnAcI4MDrSy+/pCi1SV2mUZThsbSTOTo+S9i0O4c8JSL
 QoT4CVGhao4+VGvT9L9dwalu3PCtRkZM/JLCPEz4gyJzqvS4i6aC3ICQzoHb8Yp3OcpQRQ62
 1nPmMnmbRRjrqecQ3+Z3r6RpCG1P24eKikfZkcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y
 CzMqzIx74j/luYO3qS/uFrB3DSlo8GRShZvv12MGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu
 H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWF6bKzN/HNLwiQxkM=
IronPort-HdrOrdr: A9a23:GGSoA6hep5nQz/YYUdvsabe0x3BQX4N23DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bvYOCUghrTEGgE1/qs/9SAIVyyygc578
 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3vpxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu
 v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+
 O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3PARDAhKd/apw7gpMycxonBQwu2Vms
 hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfdsRKEkjTVo+a07bWvHAUEcYZ
 tTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYYit2ZF8Ih4R4hP5u
 zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tXKyaRw4PvvdI0DzZM0lp
 iEWFREtXQqc0arEsGK1I0jyGG7fIx8Z0WY9ihz3ekIhlSnfsubDcSqciFcr+Kw5/MCH8bcR/
 G/fJpLHv6LFxqaJbp0
X-IronPort-AV: E=Sophos;i="5.90,291,1643691600"; 
   d="scan'208";a="69836072"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mLtWvV62/heFLSh5WSAaMY8soQ1ZTDwu/Mj4wWssomCFBY+Shhwcc7dOkjz4AObwH2X0fMAeSfOrcz1KWd9ibQ9BC2fPmVORZezgRSshzoxZxbRnnNKlSHf8pSqdpuDZ/0PEdDQ/20QP6NxPbJGqWpJp0up6VfjdvupJC4ojjyk1MlndX7UiefyUjlxkBVIjLKom40BSGD7MG/B94EIqw7pnrbmsmXFFxpZi1RSF4a4WVthrzE1u9p938mq2VCyXpn6MGrioSZ0TY/6Fdt9HyX1c/YimBmWgpm1ly3EcydUKwdf4K3vm0sSGd+z3ILYxKHmcJTyZbGbbRAfwPU2weA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fbINpKt/1RYyj1cWGsZ3YaiNFHNjyGzplUSls67ClYA=;
 b=hxEOfS42U5prvuuMJ3ch1YabQqJuM5OVxoqotD+1k6aQo8NSaM4y+3oLs/yAmPykcVuYYSNZBQ+pw5xcA8K7Bbw1MpfUNfJuFUX/IxoM+V7fkO0dlbM1naWb6s/VvmNDteSowbcnJ5rLGxWcBZM1EpViwFGUj8bBApJFIU0ydjpWJntZCpnpW28gCuApP+4oKIA4p5BnJO/vhLHEj2gHwJmgLoVIGf9SNvGydcFMl6jJJVSjRMYdd7ddZB/0xtA6tgSudcLzq5LMQjJyAxyJ/lEcRmivNvo5sX9GY7DUc3CqPSFoGLokrWLa+62KAnyyrpmx8v+qGXGLO+5v6rd5IA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fbINpKt/1RYyj1cWGsZ3YaiNFHNjyGzplUSls67ClYA=;
 b=agHZlpJUQ6uwthH7h9EeJxnyCMl5pZGDQtp+xM72nbcJWMxHHNrQihgF6MxDa8bgH9DPL6tjZlFz18hKPLkpia/R1eyjRmbVy8znPD+szTPneumx1jnvl2cmbUvMsO1UthnKl56/4qtj48sHxlxNBziTzJqqo3T8Gy/b/vJFjnU=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: David Vrabel <dvrabel@cantab.net>, Julien Grall <julien@xen.org>, Jan
 Beulich <jbeulich@suse.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, David Vrabel
	<dvrabel@amazon.co.uk>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
Thread-Topic: [PATCH v4] page_alloc: assert IRQs are enabled in heap
 alloc/free
Thread-Index: AQHYWKhQkHRex9QHaUa4HuRkaWqbCK0COu2AgAADggCAAAViAIAAAJKA
Date: Tue, 26 Apr 2022 14:35:19 +0000
Message-ID: <cd228d72-59ab-087e-92f8-c056a1478e15@citrix.com>
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <f5a45b8e-644d-15aa-951f-aa6d89ce4c5b@suse.com>
 <ecb4876e-c6d4-4bff-d964-92af83d39dff@xen.org>
 <0b7c4df3-e6f2-7791-4e8e-9655eb8c6f6f@cantab.net>
In-Reply-To: <0b7c4df3-e6f2-7791-4e8e-9655eb8c6f6f@cantab.net>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c91a2b3f-9bdf-497c-57f1-08da2791fd1d
x-ms-traffictypediagnostic: DM5PR03MB3274:EE_
x-microsoft-antispam-prvs:
 <DM5PR03MB3274DD2FA5D193D637FE53BEBAFB9@DM5PR03MB3274.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 xc+FYn5jTrz6LpTCEv1xEPMwSE1C4/BLGxlmt8cxUUYwoMcJTLEBjBXsCFSUzTik1PtjG6nb4AYGzP0XP4NWcse9zOsLPHJKbACObcGgaQmXql3pNGBnoMr+097QB7FQBUioVAkAl2elbqDD76twhTeVkng40lwiJzcrfvteneU63cNKUjE5z9UAI6JMf/4OgoFk0SG7iOfPPez9MR/rVYpSndpnVoawi6mJXDL8ZbER6AWZOA5NwevNrMXXraj8su/u8iwV8VYrn+EBn84YM6+fq0Hq21XaH4zsj1itVh4InIjLI2kQhtABeLA5hXmrAvzMI3RQx/EaeLA/xx6uSe00tW5R4iGcrKivYLOLSfa/E5BaJ++Y6NBm1LrUdqIGVo7U1mJ2LKmh5xvJAhtJ/Tusz2Uknu0FQe9UqcVVl9ih0nadtpTr+JBu6mK/Q3yMwi2++3Y2FafFFnZ9f8iQPXBrI38NMejWyJu+UAuvIUCg1vs0+2QEJroeRcNuwK9UT8cZ0fDvBcU8gClGAWxr7KoeG8jbQMd0TFzc6xBjK+PHTPXiOQsBhivwZfvbesxUU+roiSZeRGrr5dQSdsZQKMaicQW2BTt9dAoA2PtTQpqR8VWZ6PxRw7ANl7Egi15YUMUOVAVTCIvdjF/HIMVXtGOq8RI1sW95fTSWy1y3JErZpKW444pmsZWFtwsV3i1HH2Zj8XYuZcrImuvy8d8YoNpMcZeGlaXl56rr0M1S/9qHqmn168YhWZgJZjyhuIWZ2tAF+7U4fqE9xBz1QmTa/w==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(82960400001)(26005)(31696002)(38100700002)(316002)(53546011)(6512007)(86362001)(38070700005)(91956017)(122000001)(5660300002)(508600001)(6506007)(83380400001)(186003)(6486002)(36756003)(71200400001)(8936002)(76116006)(66556008)(8676002)(66446008)(2906002)(110136005)(66476007)(64756008)(54906003)(4326008)(31686004)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bEJLZkJKdGFzeVBCUHpzbEd4T0NGZzBkSThFV1RTakpOY1BYS3lmNm81Ukk0?=
 =?utf-8?B?aGVMT09mSTVRanVoR2IrbWQ5U3paRjJLbyt0RlFNdkdSVGc1WE1TZndyOCt0?=
 =?utf-8?B?UWo3Uy9OY1JDQzNWMFdQNGh5UHByTlpUeUJVRkdFbE1yR2F2V0dIK0hPUW5y?=
 =?utf-8?B?SG9ZdDcyWEd5bGR4SHNIUGhMMnZlU0RkQTNWQkxwOC95U1Z2ZU1JWnZmU1pz?=
 =?utf-8?B?cGRIY0kxVEpJS3gzQ2RVOTV5WE03VSs5TGhNUUdMWFk4c3lGaGNFZkZyR0Rn?=
 =?utf-8?B?OGtGci9VcHpWdFUwMU03SnZqbXlsRXNud243eFRlVElwQ3RpQngydDZLWVRq?=
 =?utf-8?B?SWd5WStSNTFLbUd1dU9JOE1oelZIM0hoR1ZPSnZFNFExeWZyVksvUjA4WU1r?=
 =?utf-8?B?MVp4MnlaaFlRaUFOUi9DVkIvbFI2MGNKdGxXYjVKcXZTWlNpSnFvVGxnN3Zv?=
 =?utf-8?B?WWVNOGVtaGJEUnVwSGo5bG82alVFdFNra08xaU5yVmJqU3BxRWlXazMrWDEz?=
 =?utf-8?B?bVIwU3FYUXpZeU9NeFFZckk3Y2xOelkyeXJKVWZXR2V6ZFBzeGFPOFRtTFlO?=
 =?utf-8?B?bExmMk92eWNaV3E2NXM0am9oTTFkQVFrL015TzN6OWpNNWtoYk10UEl1YUJP?=
 =?utf-8?B?cWY2M091TjFqTXB3ZlFpSk5uQTcxa29VbmFKUStGMGI3VDYvY1dLcE5TZExY?=
 =?utf-8?B?b012bVhKd050YVNRUkZ3RnF1T3ZwWml6T3JoN0VHM3BWV0tRaVhXY1lmTi9s?=
 =?utf-8?B?TEpzVXlJQTVsK0NPaEVBWndwQkoySVI1bjhFWUxuZUxvS1BKa0wwcEtsTUQv?=
 =?utf-8?B?cDJvbnQrUVkyaTJ0L3BSZzdhQ0gvNGdVamc1R2hmUWFlaElaNHBGUjQ1eU1R?=
 =?utf-8?B?K3NMRlRmd29UOTBrcEhTRGdQeGQ3TUw5NkhFYU9qdmtIVTlaOGZ3Y2ZVYVBY?=
 =?utf-8?B?azYvMUdUWU4rR1BkMlo0aXVOTHdKR05yL24rcHVHUC9QRDJ0Y3FYRWtqOFpm?=
 =?utf-8?B?S3VSSzdBcnZJc1JTcklnYWd6RXRRK0VWc2l1ZFJvZHJoK2dLMExxNXpEaVhC?=
 =?utf-8?B?MUNlYkVLOHdXN2YwSlQxYnZrbkFEV0diYW10SmRwY2V6ZkIrUDVlS3hSdDZL?=
 =?utf-8?B?QWwyYTFCTmJPa1pVZFZHNlQ1SVZoUW51QUxYUXllVDNSMzZtSGNEeHppU2Jm?=
 =?utf-8?B?Y1JYRkJsZEpSNklBOHRZaWRTaEloeWdab2thOVo5cGczcE5lTzhPZjR0YUxp?=
 =?utf-8?B?M2dVN0pNZDVBR2Vpak45VnVBU1hRUm1HQThwVE83Z1JHb0tpRUtTM3lQWU9S?=
 =?utf-8?B?MytWN29POVk1VHBES1l6dEdHelgydHlGQUV5cHVzTkp0Y1ZVWGR2MlkyWmVz?=
 =?utf-8?B?NjVlRTV4SVhiTUtmNW0wa3U1VHlMVXh2NWRnRlpvdGQ5SEVTbVNSaXRiSnF6?=
 =?utf-8?B?aGkvV3M5OHovNjJNdVdzNlZYbkRRU0NPeThJYi9MTHBFdUxnbmEwT2JWTStQ?=
 =?utf-8?B?QW1UemtjNWFCRUFSTyszK1V3OUV6b25KTGd0dWxvTUtucXg0RGRHNkxIVHF1?=
 =?utf-8?B?SnZtc0d3WVpPU2w3dkZXM0JxTXIrR1YwcWdLU1JNSWh1amJEWWV1bnhuQnpn?=
 =?utf-8?B?Z09vakl1bTZjVnBkZ2FQZnVCQkx1TTh3bWtYa3IvQjlRTnFZTzJEL3BvYzIr?=
 =?utf-8?B?aGpGLzdtemY2Rm41NmJNMmhrTmpoSjB6Uk0zQ1hRQVVLbkZJTVZ1TlNrZVlt?=
 =?utf-8?B?ZzhhNHVrOUZ4MzFsMjdYbUV2MXZEZ3JnZ29EajM4bUtwanpFOVBtd3ZuOUcw?=
 =?utf-8?B?ZzllSGpvZHkrLzFrYzZHbHdJY3prNnFCQVlVMWlMbHpWS0dqOVg4WXg5bHJt?=
 =?utf-8?B?dGlBQzR0SWtaVC9YdmdpWWdhamJianJHbHZkTGl6VEpzNnhJY3VEem12QTUv?=
 =?utf-8?B?b241RERvR3JqQmNwRWFUNlg4RmdoaDJXbkk2ZGZWOFlYZmR1aTdXSFhjWDdm?=
 =?utf-8?B?REFwN2ljbXNPSjlRSXRBRDUzdGhuR3JKQ0cyaVVGdldKc2Myd2FONW9laHlF?=
 =?utf-8?B?S3ZtazRvb2tmQWNuMkxQNlRLeGd0bDZ5S25DRVhndEFqS0JaK01OWERDaXMy?=
 =?utf-8?B?cHlFVStTc0Y5RTNtWHVRbTRHZ2Z5TEtyUWVQbTVkWDhpOWJpRkZxQzd3TktI?=
 =?utf-8?B?NnFZVjhyS3NaUXlLN29mVG5lRjBxa1A5L1VYWXJYSkYrMGkzbGJFbHdsRkho?=
 =?utf-8?B?SVlGUjdRam9EckJlSjJvSzZ2a3E3eVd0aUw3cEloaytCMDhXVVRGczJqOVd3?=
 =?utf-8?B?UVk5QjBpd0NzTjdaUEwrakNNNkViQ0NqQWgwMW5vd2NMVDNDU2luSEN3ckxv?=
 =?utf-8?Q?9F4JJwIunSuq/wnY=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D005DB15A6FA5D45BCEFDFC05818B51D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c91a2b3f-9bdf-497c-57f1-08da2791fd1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 14:35:19.6490
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sO+0RPtD0u2FywNoS/KJ2oVRbd4Dlhom8zX9Fn5QVLAGMbJxyXqyAq2MLQGiJkhv+fMdmloKCuzinGI7uZtA2G8PC1oW9nb1gvo1gqH1Ai0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3274

T24gMjYvMDQvMjAyMiAxNTozMywgRGF2aWQgVnJhYmVsIHdyb3RlOg0KPg0KPg0KPiBPbiAyNi8w
NC8yMDIyIDE1OjE0LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+PiBIaSwNCj4+DQo+PiBPbiAyNi8w
NC8yMDIyIDE1OjAxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAyNS4wNC4yMDIyIDE1OjI4
LCBEYXZpZCBWcmFiZWwgd3JvdGU6DQo+Pj4+IC0tLSBhL3hlbi9jb21tb24vcGFnZV9hbGxvYy5j
DQo+Pj4+ICsrKyBiL3hlbi9jb21tb24vcGFnZV9hbGxvYy5jDQo+Pj4+IEBAIC0xNjIsNiArMTYy
LDEzIEBADQo+Pj4+IMKgIHN0YXRpYyBjaGFyIF9faW5pdGRhdGEgb3B0X2JhZHBhZ2VbMTAwXSA9
ICIiOw0KPj4+PiDCoCBzdHJpbmdfcGFyYW0oImJhZHBhZ2UiLCBvcHRfYmFkcGFnZSk7DQo+Pj4+
ICsvKg0KPj4+PiArICogSGVhcCBhbGxvY2F0aW9ucyBtYXkgbmVlZCBUTEIgZmx1c2hlcyB3aGlj
aCByZXF1aXJlIElSUXMgdG8gYmUNCj4+Pj4gKyAqIGVuYWJsZWQgKGV4Y2VwdCB3aGVuIG9ubHkg
MSBQQ1BVIGlzIG9ubGluZSkuDQo+Pj4+ICsgKi8NCj4+Pj4gKyNkZWZpbmUgQVNTRVJUX0FMTE9D
X0NPTlRFWFQoKSBcDQo+Pj4+ICvCoMKgwqAgQVNTRVJUKCFpbl9pcnEoKSAmJiAobG9jYWxfaXJx
X2lzX2VuYWJsZWQoKSB8fA0KPj4+PiBudW1fb25saW5lX2NwdXMoKSA8PSAxKSkNCj4+Pg0KPj4+
IEF0IGxlYXN0IG9uZSBvZiB0aGVzZSB0aWdodGVuZWQgYXNzZXJ0aW9ucyB0cmlnZ2VycyBvbiBB
cm0sIGFzIHBlciB0aGUNCj4+PiBtb3N0IHJlY2VudCBzbW9rZSBmbGlnaHQuIEknbSBnb2luZyB0
byByZXZlcnQgdGhpcyBmb3IgdGhlIHRpbWUgYmVpbmcuDQo+Pg0KPj4gwqBGcm9tIHRoZSBzZXJp
YWwgY29uc29sZSBbMV06DQo+Pg0KPj4gKFhFTikgWGVuIGNhbGwgdHJhY2U6DQo+PiAoWEVOKcKg
wqDCoCBbPDAwMjJhNTEwPl0gYWxsb2NfeGVuaGVhcF9wYWdlcysweDEyMC8weDE1MCAoUEMpDQo+
PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwPl0gMDAwMDAwMDAgKExSKQ0KPj4gKFhFTinCoMKgwqAg
WzwwMDI3MzZhYz5dIGFyY2gvYXJtL21tLmMjeGVuX3B0X3VwZGF0ZSsweDE0NC8weDZlNA0KPj4g
KFhFTinCoMKgwqAgWzwwMDI3NDBkND5dIG1hcF9wYWdlc190b194ZW4rMHgxMC8weDIwDQo+PiAo
WEVOKcKgwqDCoCBbPDAwMjM2ODY0Pl0gX192bWFwKzB4NDAwLzB4NGE0DQo+PiAoWEVOKcKgwqDC
oCBbPDAwMjZhZWU4Pl0NCj4+IGFyY2gvYXJtL2FsdGVybmF0aXZlLmMjX19hcHBseV9hbHRlcm5h
dGl2ZXNfbXVsdGlfc3RvcCsweDE0NC8weDFlYw0KPj4gKFhFTinCoMKgwqAgWzwwMDIyZmU0MD5d
IHN0b3BfbWFjaGluZV9ydW4rMHgyM2MvMHgzMDANCj4NCj4gQW4gYWxsb2NhdGlvbiBpbnNpZGUg
YSBzdG9wX21hY2hpbmVfcnVuKCkgYWN0aW9uIGZ1bmN0aW9uLiBUaGF0IGlzDQo+IHdoYXQgdGhl
IGFzc2VydHMgd2VyZSBkZXNpZ25lZCB0byBjYXRjaC4NCj4NCj4gSSBkaWQgdHJ5IHRoZSBydW4g
dGhlIEdpdExhYiBDSSBwaXBlbGluZXMgYnV0IGl0IGlzIHNldHVwIHRvIHVzZQ0KPiBydW5uZXJz
IHRoYXQgYXJlIG9ubHkgYXZhaWxhYmxlIHRvIHRoZSBYZW4gUHJvamVjdCBncm91cCwgc28gZm9y
a2luZw0KPiB0aGUgcmVwbyBkb2Vzbid0IHdvcmsuDQo+DQo+IENhbiBteSAocGVyc29uYWwpIEdp
dExhYiBiZSBhZGRlZCBhcyBhIERldmVsb3BlciB0byB0aGUgWGVuIFByb2plY3QNCj4gZ3JvdXA/
IEkgdGhpbmsgdGhpcyBpcyB0aGUgaW50ZW5kZWQgd2F5IGZvciBwZW9wbGUgdG8gcnVuIHRoZSBD
SQ0KPiBwaXBlbGluZXMgb24gdGhlaXIgb3duIGJyYW5jaGVzLg0KDQpJdCBpcy7CoCBVc2VybmFt
ZT8NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:42:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:42:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313988.531823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMOb-00044I-Hs; Tue, 26 Apr 2022 14:42:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313988.531823; Tue, 26 Apr 2022 14:42:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMOb-00044B-EK; Tue, 26 Apr 2022 14:42:29 +0000
Received: by outflank-mailman (input) for mailman id 313988;
 Tue, 26 Apr 2022 14:42:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=urB8=VE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njMOa-000445-V8
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:42:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17f646ee-c56f-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 16:42:27 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-14-ICHN2OMuEZxmKIWLK_Q-1; Tue, 26 Apr 2022 16:42:25 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBAPR04MB7430.eurprd04.prod.outlook.com (2603:10a6:10:1aa::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Tue, 26 Apr
 2022 14:42:23 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 14:42:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17f646ee-c56f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1650984147;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KvWIhYE4cEBXVy3Ooxi1iGKA9YQ/B58YM7J25bpT9dM=;
	b=HkScXG3xTC4T1BBLGMXSqVfhM0QcXC3tQFUmsTsILAizTW0CWXJ5GnEgrIcrp5lI9TLkWD
	wKLMOhvzcVazT4Z34mggjCRPL89WI0zgi+1AsijpIxrZMse/xpQnXJVr3vygKHOsEwg/8x
	+waCMzv/WQcFui0W6Ryvevm3dtypDeY=
X-MC-Unique: 14-ICHN2OMuEZxmKIWLK_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dBoIHk7C1/Y+zbV21qYEFcEwJqWPZqKYI5gvnVc/lwpoXVqvZsKxV1AHWcXudRzBKMgMBsfIIaHHCbFLIAZbgOKei1miejZWZBeE7KyWluANYvgxzwllJcn3017jcIgEeifpJ+QZnn++GGn8XnuiWYUMuZGt5P3Fe9IZFMv7zdTw9T9dWocrW2AA2gOzPrbeCe7jJwlfAMpuCajcL7EzsDtWfuPwZ/H96q70rJQtiicK3ODG0YWn7XwmLzvPmYdEToKWkRhSyZGJ8CdAxfx9MjU6ksEThO1Ucjaog1PMSY+QjdBBdhW0roH3IK4yLAFGWnMTkWbg3Fy7kEzwMwaazA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KvWIhYE4cEBXVy3Ooxi1iGKA9YQ/B58YM7J25bpT9dM=;
 b=J6cyBWi3cpWGWX2T80cQ8UG3ynMUNkusmCpBq5mRbm7cao9yO7RAl8IatE6RHMXjQ0rtLCZr6ijh6Jq6qga6W1eirGL/VVTrF8+fqIjRvUNsk+H1UP1AlHB3zSRaoqCdXzqN9nIXAexBndtsOzLn/ko3BlEhSpA4Cp2w6oM2N+ZbNCLT5MB9EQf0I8FhTHdA4XpHOtlnoN5vnYua/p13OwXb6RdzQfV3eGYEkIm3tHL8Mfj9nNvMDFCUy84JcSGPTgUJSwqhZHqwUxAe4yl4cG6b2den5I2fYQyCBhbhULJgSGl6Wh1r+4YZEwSJQIFfU8pYmASHUd37DKJEmbqlDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <79e3fc8d-7064-e981-b90c-d0f7fa0aafae@suse.com>
Date: Tue, 26 Apr 2022 16:42:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON
 for phys_to_nid
Content-Language: en-US
To: Wei Chen <Wei.Chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-6-wei.chen@arm.com>
 <6d666aa4-c0d3-b8ed-9fca-e9d2179564d3@suse.com>
 <7d7fc887-20a3-49c3-0754-3bca3442ccce@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7d7fc887-20a3-49c3-0754-3bca3442ccce@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0029.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::39) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a7c2b2bf-0ae4-4312-238d-08da2792f99c
X-MS-TrafficTypeDiagnostic: DBAPR04MB7430:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB7430864A4B941166BC313761B3FB9@DBAPR04MB7430.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pEIy9Ctsmi/Kxg2uPNZ6+lR/X2klJjVRdaEnHJKNsZwcwcOOXOAJXZ5uIKe55J2aek320dHaLgc3lYcu7OR6yZHRZ4YhRooGCp5iNKwegkR7YkmRmM6+q0jMSUxDRxdmsplBiWfmZQslxVXuVVLuOPZh7QMtMV39+0R4pc83mwCxAGJPf6pptsHsFjt6M5q2DxWJJhc8SJSxZlPmR+V0jkywbRnRDwYCZjINu3j/3M3HEQARZkMPz55jJ2GKH818boy0Hv9VLh5sJJOoq5iXd5McG6mRWZ3J0xU6axoz2NQ+pgRJnoxY/OkezGGul86vG1wUABdpxInHbqX8eAZIC3vyqtgV0WqFpowhxGp1cy2ZUJnFd9imKc/nrFxhguijiiBJGANcqCaD0YIFq8n7wU6kKv29oQPvLYLNE56wSbvvJXtxH9u4C/7zRtYpv7A0nIZBLLoojERvBgNXg7BGX2FyQ6cPbcAvCbRf0A1Yp4V05y5pLVNFpeEHe/7BMyAQJlLQPwouD+u33Gwq8vJ5YwMKaO5eSQm/XCSR2gmWdMFzYKlGLHfQj9W6O11zxGzRIVsJDRYbjYQ7qAQt4eE1cEEOQxqJkdW97ZE0L2jb5Q0B5MX/MS7mYJa2vK4IgDcLL707DhxT012HcTSxeOopKyVSKm3k7x0iNmQLEhPAnHMQy4owI4qoNNOWQksC0WEe1NLZ8Ukur8uavRjyzsCGvnF5K3wFpVN8XOAfmDeNvPI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(508600001)(6916009)(83380400001)(6506007)(66476007)(31696002)(54906003)(8676002)(4326008)(6512007)(86362001)(316002)(66946007)(66556008)(38100700002)(53546011)(6486002)(5660300002)(36756003)(2616005)(186003)(2906002)(8936002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cVdicUhCRVNNOXhqYmVORStIYTJOSVlGNFMzbjdTdmFieW11NFB1M2FFSXdt?=
 =?utf-8?B?MDFlUU5nNW1Xai9ad2RYOUl1SU5OemE0VWJnNmpjYVdxVGNsdkhjUjVTaHdk?=
 =?utf-8?B?OVp4MmlMNHNyUlpGTDB6UGlsa3F5WXhsblpkNVFkRGx0WXlhWUNUcEIvL0Iw?=
 =?utf-8?B?dE1MK3BQckRxMGZscW15VHVrVWVBdnE0WUc2QTh1TkVHMHhmVFk1QnBoNjRN?=
 =?utf-8?B?WHpRTkVjNVBwbjJjRjE1S2JxUXJQblloY0duWG9HK0IvSTd6b0hYWmlQQSs3?=
 =?utf-8?B?UjFZb2xNS2tSS0dJbWNXMVBvSEtLd05ORWIyemM1Y0FmaEY0R291dTUrdk9t?=
 =?utf-8?B?Q3FtQkVzT1ZObkIzZVV2cEpuN0czMVVPb1p2QzQ4ZUdyRWJXM25lYWh4SlBs?=
 =?utf-8?B?bGdWRVRLQ3VWR0hwRmRKeGNKSDVzY0ZoMm4xWlRBZ1A2MmJiWVJOdFN0OFFU?=
 =?utf-8?B?ZmpVb1NPUHJIbHVpZmJTbjdYakZvNWlROWhvQ3ZWU0F6OXl6RjYxYkViVy8v?=
 =?utf-8?B?TDdmNUhWZDlUZVpxQUZzc3pEbTErWC9qRENGTU9HTjduSWlpWFREZjY2bnJT?=
 =?utf-8?B?UkhIQjBUYm9xZStrNHZHZXVtNldrTzRYbnE3MW8yTHFCOGNMczdTMWE1WTl0?=
 =?utf-8?B?MlBUbHdGV2hjc1E1S1RxdERRYThqTks0RFhJNHFWNytEQmV1R2ZRbmFudXhp?=
 =?utf-8?B?WFlIS0FWUGE1Uzgyb0ZGbEJDcUNIcVFuRXM4Y0tjRFUvaDJmbjJXT0F4TlFi?=
 =?utf-8?B?VnhMcDhOM0FmRjhQa2lraFpheEt3U25vTmNUdi91M2Z0SGM3bkk5bjd2eFVG?=
 =?utf-8?B?aWpFZExWWGNpWW1OaUQ1Zlk2bUV3MVcvOWdDcXhVTUFxTkVNTVVHTG9GL0NH?=
 =?utf-8?B?WkM0MkdlSTIvN1RpQnZvOW9RL3JyMURjZi9wMmttTUsvVVRUVitpQmtKbjlK?=
 =?utf-8?B?QytESG1EQ0JBemI5VjU1Z1AwY3Z0WXA4ZzdWVHJYVEh6V3FyREF1bEI1WXZx?=
 =?utf-8?B?eWpXYnpudkNERitkQnc3Y2dKK05oOHV1eHFsTE5VdnYzMFliS1pFSDFsSWc2?=
 =?utf-8?B?aElwZjNwSUdZSUl1RlZKalhWaEtmZ1RmRXFkdnhyWDZLN1hsam9YTHdRUEJl?=
 =?utf-8?B?UFBscytoeUFRV0pVZ3pCNFdRQWpmMVZTdnkwUy9iYUoxOUI3Q0VzRWhBZys1?=
 =?utf-8?B?ejREbHgwbnY4TGJQdkdJeEFVUVRsWWp6WWxSNU5KYzFlVXBBNW1qc3I0WHBS?=
 =?utf-8?B?RFRzdEJJMkZYcGRPT052NE9obDZLckg4RVB3K2dDWDdINHZHYkJzN21hYnUw?=
 =?utf-8?B?Y213eE5yWHFFaDZnNGM2NGVCcXg0YkE4NE1WOGRUZ0haSHZXc292TzZtM0Nl?=
 =?utf-8?B?bkZ3VnJzc3d3N0ZFN2JCN0JYUWZPRm9iTlpSeE0yT3RDa3c5V3QrTGticEFo?=
 =?utf-8?B?NEsyNm9uN3BidWEzZWlhek02V2RlVzZERXpPVnBCQndqREd6TVFJV3dHdEpn?=
 =?utf-8?B?Y0FNN25hd1QzMWJtbE5tWlZNcjdZSlZXSkE4SkxlZ3hWQ3pkMmhNaXRnV0N1?=
 =?utf-8?B?NFZyREdhZ0JTcU15ZXZHRHZiZllpNlhVYnM1Zkk0S0hWd2ovcXJUSUNHL0k3?=
 =?utf-8?B?TzN5UWNLdERBS3ZGUzVVMFJIU29QWThYdjJ4ZExvdXBJK09vcSs1eGRxdHk2?=
 =?utf-8?B?OXFLV2Q5MWRkT3JlTmNGSzExN2RGNi9qdlFjR0ZjRSs0VVFITkUxUUNseEha?=
 =?utf-8?B?Q0xxdU4xVUM0Rm1XRVNQK0hxci9wc3Z2VkZjWHdnYlV3akJaNXFTcXlzM0NT?=
 =?utf-8?B?ZkFKL3AwdXN2aVJzUmQ4U2V0Tm4yNTdXNTZ2dGxqMktkNlQvSEd0RzdxU0Q5?=
 =?utf-8?B?NTQ1QmpDS1ozeXpqa0U5UDFuczBxTWNFMGxCSm91ZG5ST2hKYXZNS1JFSUZp?=
 =?utf-8?B?V3VjaGpPT2F3V1d1eG93bzVRSUJOUXBrbWNYNUFlbldUQ1lieTJ4WjRNVVJW?=
 =?utf-8?B?ZEZINjYwdDVMYlNYZmt0VE55SUlKM05WdzlkL3V4T2xEZk1xMkgvMkxWcHRw?=
 =?utf-8?B?SUxpemVvWU0xYW9aa2VCZHNFMHM3SnpNZFE3REpyU1hkdDJlbzVuRmlCZStn?=
 =?utf-8?B?a2d4K1QvMTdPV2FnT1hPVitNU3dSeWRuRExBVEd1Y2RhVXAwRHdlekhreVpn?=
 =?utf-8?B?YUlER2IwOFluSW1SaWZqTFkwVFRWRHR2azFsaHlpK2ZZQlBwcy96amdMbXho?=
 =?utf-8?B?cGdoRWtNMHQ0MWpEeFlXMDY2RDI2bVRIcGhtWktZZVNTcGV4dnlmRDRjWFhz?=
 =?utf-8?B?Qmp4dzZleFhVV2xzbWRUUjFXS2dVdFN0eUtSQ1NUczFPaU9jYnJqQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7c2b2bf-0ae4-4312-238d-08da2792f99c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 14:42:23.4857
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yVNYPeEZ1zwxigJkZmxf8kqCt46HfOJ18PqhnbhZ+R1/ukgAm0XOV8UpylCw0hIO2JSVFaqiRzd1AqLslM5jLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7430

On 26.04.2022 12:59, Wei Chen wrote:
> On 2022/4/26 17:02, Jan Beulich wrote:
>> On 18.04.2022 11:07, Wei Chen wrote:
>>> VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This
>>> results in two lines of error-checking code in phys_to_nid
>>> that is not actually working and causing two compilation
>>> errors:
>>> 1. error: "MAX_NUMNODES" undeclared (first use in this function).
>>>     This is because in the common header file, "MAX_NUMNODES" is
>>>     defined after the common header file includes the ARCH header
>>>     file, where phys_to_nid has attempted to use "MAX_NUMNODES".
>>>     This error was resolved when we moved the definition of
>>>     "MAX_NUMNODES" to x86 ARCH header file. And we reserve the
>>>     "MAX_NUMNODES" definition in common header file through a
>>>     conditional compilation for some architectures that don't
>>>     need to define "MAX_NUMNODES" in their ARCH header files.
>>
>> No, that's setting up a trap for someone else to fall into, especially
>> with the #ifdef around the original definition. Afaict all you need to
>> do is to move that #define ahead of the #include in xen/numa.h. Unlike
>> functions, #define-s can reference not-yet-defined identifiers.
>>
> 
> I had tried it before. MAX_NUMNODES depends on NODE_SHIFT. But
> NODE_SHIFT depends on the definition status in asm/numa.h. If I move 
> MAX_NUMNODES to before asm/numa.h, then I have to move NODES_SHIFT as 
> well. But this will break the original design. NODES_SHIFT in xen/numa.h 
> will always be defined before asm/numa.h. This will be a duplicated 
> definition error.

I'm afraid I don't follow. MAX_NUMNODES depends on NODES_SHIFT only as
soon as some code actually uses MAX_NUMNODES. It does not require
NODES_SHIFT to be defined up front. Of course with the current layout
(phys_to_nid() living in an inline function in asm/numa.h) things won't
build. But wasn't the plan to move phys_to_nid() to xen/numa.h as well?

Otherwise I'd recommend to introduce a new header, say numa-defs.h,
holding (for now) just NODES_SHIFT. Then you'd include asm/numa-defs.h
first and asm/numa.h only after having defined MAX_NUMNODES. But
splitting the header should only be a last resort if things can't be
made work another way.

> How about I move MAX_NUMNODES to arm and x86 asm/numa.h in this patch
> at the same time? Because in one of following patches, MAX_NUMNODES and
> phys_to_nid will be moved to xen/numa.h at the same time?
> 
>>> 2. error: wrong type argument to unary exclamation mark.
>>>     This is because, the error-checking code contains !node_data[nid].
>>>     But node_data is a data structure variable, it's not a pointer.
>>>
>>> So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
>>> enable the two lines of error-checking code. And fix the left
>>> compilation errors by replacing !node_data[nid] to
>>> !node_data[nid].node_spanned_pages.
>>>
>>> Because when node_spanned_pages is 0, this node has no memory,
>>> numa_scan_node will print warning message for such kind of nodes:
>>> "Firmware Bug or mis-configured hardware?".
>>
>> This warning is bogus - nodes can have only processors. Therefore I'd
>> like to ask that you don't use it for justification. And indeed you
> 
> Yes, you're right, node can only has CPUs! I will remove it.
> 
>> don't need to: phys_to_nid() is about translating an address. The
>> input address can't be valid if it maps to a node with no memory.
>>
> 
> Can I understand your comment:
> Any input address is invalid, when node_spanned_pages is zero, because
> this node has no memory?

It's getting close, but it's not exactly equivalent I think. A node
with 0 bytes of memory might (at least in theory) have an entry in
memnodemap[]. But finding a node ID for that address would still
not mean that at least one byte of memory at that address is present
on the given node, because the node covers 0 bytes.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:44:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:44:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.313996.531840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMQw-0004hB-09; Tue, 26 Apr 2022 14:44:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 313996.531840; Tue, 26 Apr 2022 14:44:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMQv-0004h4-TW; Tue, 26 Apr 2022 14:44:53 +0000
Received: by outflank-mailman (input) for mailman id 313996;
 Tue, 26 Apr 2022 14:44:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njMQu-0004gs-Gv; Tue, 26 Apr 2022 14:44:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njMQu-0006aR-FN; Tue, 26 Apr 2022 14:44:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njMQu-0007k9-5f; Tue, 26 Apr 2022 14:44:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njMQu-0004fJ-5B; Tue, 26 Apr 2022 14:44:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mjBrNtWBmcOQbvrFDRQpsFXOVqhCvR8QvLnHSfRBRNo=; b=iFZi9NpGQ4GZ+7MnK6oasK1TDO
	nGfFubKBNnnlvDt9jBlD069BWdsJ2VgatLbx335N+YqJ7XbrtoHlDhwe/nUBNQ6MgyTHwKJF9Ohxu
	epDG/+/usik8kDsExLDpgjA+90WWDi0VTem79GPxC6KBx/8JXg5a23qnQRHvBq7leHGQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169740-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169740: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 14:44:52 +0000

flight 169740 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169740/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  643 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 14:52:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 14:52:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314004.531851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMYH-00069u-Qk; Tue, 26 Apr 2022 14:52:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314004.531851; Tue, 26 Apr 2022 14:52:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njMYH-00069n-NA; Tue, 26 Apr 2022 14:52:29 +0000
Received: by outflank-mailman (input) for mailman id 314004;
 Tue, 26 Apr 2022 14:52:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuZH=VE=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1njMYG-00069h-9j
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 14:52:28 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03on061d.outbound.protection.outlook.com
 [2a01:111:f400:fe08::61d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7ad96b47-c570-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 16:52:23 +0200 (CEST)
Received: from AS9PR06CA0290.eurprd06.prod.outlook.com (2603:10a6:20b:45a::8)
 by DB6PR0801MB1943.eurprd08.prod.outlook.com (2603:10a6:4:74::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 26 Apr
 2022 14:52:25 +0000
Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45a:cafe::fc) by AS9PR06CA0290.outlook.office365.com
 (2603:10a6:20b:45a::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Tue, 26 Apr 2022 14:52:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 14:52:24 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Tue, 26 Apr 2022 14:52:23 +0000
Received: from ac1be0867598.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 556E669F-F083-49C6-A3B8-7631CD5D9CE1.1; 
 Tue, 26 Apr 2022 14:52:17 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ac1be0867598.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Apr 2022 14:52:17 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DB9PR08MB7424.eurprd08.prod.outlook.com (2603:10a6:10:36f::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 14:52:16 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 14:52:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ad96b47-c570-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Xychuhd/drgQfE8IV6MMGuwhLrsZ1KRNAdZ4b7LeQUs=;
 b=lfqic7eNpdrC1m4voZIcTFznlPZxcqc2IXVT0l5NicQB1H91dy+GpnokMV+XbZz92xGD7XvVHfBlE0QR/mw+HShJn6siV2n+2zZpE9c2sna8xFviXCFieHhbUol06hS5C3aVdhpk0XGJ9Y5aEEcggP0TxsXmC6amT23YvxXvEKo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f8302540c7c34612
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gSZhzj73L1LiOPnmmqUxPkD4qiTQU3boAH7leeVA2IwQQ5XJebMdEpIldMzwYCt7XqdKq9NehZKNhreomLxC6zHbSRf3bQ2/fXkpkC8BdxUlFFS627HIaOCVMxfDOBmdC/d45HTkeSUZS2XOvukZD8QkN1qurtTetQVaaL2BFMK0gunaCeA+Fah4+eLsDIUuf5XdnEirhVyAR7HFe0rwqQFX5Qr4JHC8ZtkPzbt4Dr2Cl2Cv3RW/+gDPontT0HKf18zgOjUBcs+oLefjEib9Y0EF8mGlCHKlg/vzWMsITSmA7NhgfNhPlOj2+KiKxJbDamYjv5zc1NGVM1BOuW5K8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xychuhd/drgQfE8IV6MMGuwhLrsZ1KRNAdZ4b7LeQUs=;
 b=YCgQ9KiuU/1KvP/JA+gaha585e/5WdnVrQEaYP3E9M5fV6+pN7Io+fdYxUGeACcnoBSMaJHOBU+lFWLEfEWpY3wQjC157zmdDfRt/Po80+y6vtBsv0+s2O4fQfdwLqpjYamS7X4EvYXumzmtMtv0ygQCSngJ9wNS0JYH/G3yiPuwWDF4Hyj+NgFFWaBZAEw+ru6sqwmTRV1xkDYtcQl2wndr1Hh5yzqQqo11en7syIW6aijRuIcJTgOIKm3F852OSsxhUgRC9jTKrjdhKGdYDebQlmfDxvB83jUmawHvpNlbi3ZhxVpGKjgd0C4edA+hPQyurJu2ETkC+6xQo9RMEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Xychuhd/drgQfE8IV6MMGuwhLrsZ1KRNAdZ4b7LeQUs=;
 b=lfqic7eNpdrC1m4voZIcTFznlPZxcqc2IXVT0l5NicQB1H91dy+GpnokMV+XbZz92xGD7XvVHfBlE0QR/mw+HShJn6siV2n+2zZpE9c2sna8xFviXCFieHhbUol06hS5C3aVdhpk0XGJ9Y5aEEcggP0TxsXmC6amT23YvxXvEKo=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH RFC] EFI: strip xen.efi when putting it on the EFI
 partition
Thread-Topic: [PATCH RFC] EFI: strip xen.efi when putting it on the EFI
 partition
Thread-Index: AQHYWJHILrDj2EEGDUWtEVYmIvMHMK0CII4AgAAczYCAAAvxgA==
Date: Tue, 26 Apr 2022 14:52:16 +0000
Message-ID: <9B9C6B2C-9E2A-4F8D-8C7D-951E6166A892@arm.com>
References: <394c1b94-beaf-bdcb-c333-65dd9987be54@suse.com>
 <DFF300CA-944E-47D9-9674-6858790D45C2@arm.com>
 <07281533-7967-bf67-d68c-3ce1bd5de157@suse.com>
In-Reply-To: <07281533-7967-bf67-d68c-3ce1bd5de157@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: a84f447a-91e0-4aae-424a-08da27945fe5
x-ms-traffictypediagnostic:
	DB9PR08MB7424:EE_|VE1EUR03FT010:EE_|DB6PR0801MB1943:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0801MB19439CAD7EB213BF51C867489DFB9@DB6PR0801MB1943.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 fEaxlqkO6JC3AJMmOEMcGaMuO0XSfZX/KpFN/qZsgvMMfQokcRdrLsNso1AAhv/EnbPaXMoaU2E/PTpgQ7ogzJZZTCCjA43/KxKEdO7Jw/clYoSwTDxWoLF3ttREgpQ+k+02sWrO5kWpprXK8nKkIoytivUT4QcfwZRBD0AhsZHr2O2i4HW0aSOkCO/RX3vC2kkI83vqeWiGfujPpYfpXi1xOZ1/NIy0qxJuoQFx4HkcXjaVLzahkcTpgJ30qFEe7xxJZ41nKryJ9XynusYEAeIBZaIG5rvepV/2+XWOb+CDekkocL5tsNb0qQiS/GBZF8B5XkbiputeGPKpSSS5UUvt8OeL9OAU3SPxBHiDjeLUp4aiyeRtFEFM4BigmjBEuFktrVQQqoJsbrpXO2ZklqsP3KnfQMkR0VsPoqkkuk283QjKfMTM+r4ieiznRI9VD/LaIj1bCrLQS/AyzY7G7Q5F00pK7nPUjAvzxZ/QxnLyW2Aav41ZVxapRQsHQG8jmL6Ry/taJ6E/umLxSJAcQSN4i2TrzSFFOy20JWCQycn9Wf1MlrVrrR1pl8bbNcDSERm4xEqjcKspahhLSl1+gAQUgOoyJ4tHB8rom2OuhZ3T9qgy9dWHicKmlXOoYcNtvsL4Vn7nJAcb8WmR4g0EZLpBUjIZlQ7g4AKgQXVCktwxQ+a/sXaXLEvpB9p67e5hnEB/a5prssofNfHPH227117l9MjLJJX7uHQyrHYtg/Jqb9YwjY4MAoty0czsR+VD
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(316002)(6512007)(26005)(8936002)(86362001)(5660300002)(66446008)(33656002)(186003)(53546011)(6506007)(2616005)(36756003)(64756008)(38100700002)(2906002)(122000001)(508600001)(38070700005)(6486002)(71200400001)(66556008)(4326008)(8676002)(66476007)(66946007)(91956017)(76116006)(54906003)(6916009)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <D595F9A2481E3243B38594C795C488B2@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7424
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2f1f1007-3e67-4b0b-47a8-08da27945b20
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QjgugFWTFiPvP5j0FojpsBaJAIu/ZNLdzj4oNMAceMbgmsr4qmft7N2KBzYuLhgQgTWG003u2F24Kahp5H3c3+c71raRA5Ddc8lb5lzpGK8aiJ+0+c0IuCzGC/mq3n70MsD6R7f7F6ee1DgL0/WjVUhPoTuRNBG8cFRV7s4rTCPj3kF5TfXtkEjv4DzrfA4zKFm67+X9f22/sqVIG2FgYUwVaZDg0Fz++SzTCdWij7j6A4xg2Ngh95M7KB5GjQPzuYsyEWIs8LQAPnuMMjEBqMc+eKACzm9YvU6d4C95pp+revzEtv0XjYd3jWIjIU/GN+yNzeUjAZ1bXpon3oFEMDzs7jHWkJqe6MbJkhfR3lReOQ6AiXnbJJEOZW8RJ8sOyMBcPiKODDlN6bm7k4DU/x+Hh7cN3ofn++wfk1M7Fg6o6bTXbphMBEk/ta/xgn+BtnbJpW8bu3Sy9IcbemR8m/43PKIBQTvXScLF6gf0G3flG5N4AOgZuArDJ760Hzkdmi+YPKTMeqNcj9+Q2nLNBVEk9keA89Ygm5teLUHS5qFXsoshGcJsySNcw4aufhlZpMnDmqIpkhRqDsWjsH1T0C/DoCX9HxJrBtgkTIg00d5RZi0/fQ/OWS4baXzwdtgvbOjCufd1YLL1vD2EGzz5bUY4t3GryiHiB2FiMWqjAQ6ap2mOrMaaG63fkXMGmc4A
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(356005)(2906002)(53546011)(70586007)(70206006)(81166007)(82310400005)(33656002)(54906003)(36860700001)(6506007)(4326008)(6512007)(6862004)(8676002)(26005)(86362001)(40460700003)(8936002)(47076005)(508600001)(186003)(5660300002)(336012)(316002)(83380400001)(2616005)(6486002)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 14:52:24.2443
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a84f447a-91e0-4aae-424a-08da27945fe5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1943

SGkgSmFuLA0KDQo+IE9uIDI2IEFwciAyMDIyLCBhdCAxNTowOSwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDI2LjA0LjIwMjIgMTQ6MjYsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKYW4sDQo+PiANCj4+PiBPbiAyNSBBcHIgMjAyMiwgYXQg
MTE6NDYsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4g
V2l0aCBkZWJ1ZyBpbmZvIHJldGFpbmVkLCB4ZW4uZWZpIGNhbiBiZSBxdWl0ZSBsYXJnZS4gVW5s
aWtlIGZvciB4ZW4uZ3oNCj4+PiB0aGVyZSdzIG5vIGludGVybWVkaWF0ZSBzdGVwIChta2VsZjMy
IHRoZXJlKSBpbnZvbHZlZCB3aGljaCB3b3VsZCBzdHJpcA0KPj4+IGRlYnVnIGluZm8ga2luZCBv
ZiBhcyBhIHNpZGUgZWZmZWN0LiBXaGlsZSB0aGUgaW5zdGFsbGluZyBvZiB4ZW4uZWZpIG9uDQo+
Pj4gdGhlIEVGSSBwYXJ0aXRpb24gaXMgYW4gb3B0aW9uYWwgc3RlcCAoaW50ZW5kZWQgdG8gYmUg
YSBjb3VydGVzeSB0byB0aGUNCj4+PiBkZXZlbG9wZXIpLCBhZGp1c3QgaXQgYWxzbyBmb3IgdGhl
IHB1cnBvc2Ugb2YgZG9jdW1lbnRpbmcgd2hhdCBkaXN0cm9zDQo+Pj4gd291bGQgYmUgZXhwZWN0
ZWQgdG8gZG8gZHVyaW5nIGJvb3QgbG9hZGVyIGNvbmZpZ3VyYXRpb24gKHdoaWNoIGlzIHdoYXQN
Cj4+PiB3b3VsZCBub3JtYWxseSBwdXQgeGVuLmVmaSBpbnRvIHRoZSBFRkkgcGFydGl0aW9uKS4N
Cj4+PiANCj4+PiBNb2RlbCB0aGUgY29udHJvbCBvdmVyIHN0cmlwcGluZyBhZnRlciBMaW51eCdl
cyBtb2R1bGUgaW5zdGFsbGF0aW9uLA0KPj4+IGV4Y2VwdCB0aGF0IHRoZSBzdHJpcHBlZCBleGVj
dXRhYmxlIGlzIGNvbnN0cnVjdGVkIGluIHRoZSBidWlsZCBhcmVhDQo+Pj4gaW5zdGVhZCBvZiBp
biB0aGUgZGVzdGluYXRpb24gbG9jYXRpb24uIFRoaXMgaXMgdG8gY29uc2VydmUgb24gc3BhY2UN
Cj4+PiB1c2VkIHRoZXJlIC0gRUZJIHBhcnRpdGlvbnMgdGVuZCB0byBiZSBvbmx5IGEgZmV3IGh1
bmRyZWQgTWIgaW4gc2l6ZS4NCj4+PiANCj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8
amJldWxpY2hAc3VzZS5jb20+DQo+Pj4gLS0tDQo+Pj4gUkZDOiBHTlUgc3RyaXAgMi4zOCBhcHBl
YXJzIHRvIGhhdmUgaXNzdWVzIHdoZW4gYWN0aW5nIG9uIGEgUEUgYmluYXJ5Og0KPj4+IC0gdGhl
IG5ldyBmaWxlIHBvc2l0aW9ucyBvZiB0aGUgc2VjdGlvbnMgZG8gbm90IHJlc3BlY3QgdGhlIGZp
bGUNCj4+PiBhbGlnbm1lbnQgc3BlY2lmaWVkIGJ5IHRoZSBoZWFkZXIgKGEgcmVzdWx0aW5nIGxv
b2tzIHRvIHdvcmsgb24NCj4+PiBvbmUgRUZJIGltcGxlbWVudGF0aW9uIHdoZXJlIEkgZGlkIGFj
dHVhbGx5IHRyeSBpdCwgYnV0IEkgZG9uJ3QNCj4+PiB0aGluayB3ZSBjYW4gcmVseSBvbiB0aGF0
KSwNCj4+PiAtIGZpbGUgbmFtZSBzeW1ib2xzIGFyZSBhbHNvIHN0cmlwcGVkOyB3aGlsZSB0aGVy
ZSBpcyBhIHNlcGFyYXRlDQo+Pj4gLS1rZWVwLWZpbGUtc3ltYm9scyBvcHRpb24gKHdoaWNoIEkg
d291bGQgaGF2ZSB0aG91Z2h0IHRvIGJlIG9uDQo+Pj4gYnkgZGVmYXVsdCBhbnl3YXkpLCBpdHMg
dXNlIG1ha2VzIG5vIGRpZmZlcmVuY2UuDQo+Pj4gT2xkZXIgR05VIHN0cmlwIChvYnNlcnZlZCB3
aXRoIDIuMzUuMSkgZG9lc24ndCB3b3JrIGF0IGFsbCAoIkRhdGENCj4+PiBEaXJlY3Rvcnkgc2l6
ZSAoMWMpIGV4Y2VlZHMgc3BhY2UgbGVmdCBpbiBzZWN0aW9uICg4KSIpLg0KPj4+IA0KPj4+IC0t
LSBhL3hlbi9NYWtlZmlsZQ0KPj4+ICsrKyBiL3hlbi9NYWtlZmlsZQ0KPj4+IEBAIC00NjEsNiAr
NDYxLDIyIEBAIGVuZGlmDQo+Pj4gLlBIT05ZOiBfYnVpbGQNCj4+PiBfYnVpbGQ6ICQoVEFSR0VU
KSQoQ09ORklHX1hFTl9JTlNUQUxMX1NVRkZJWCkNCj4+PiANCj4+PiArIyBTdHJpcA0KPj4+ICsj
DQo+Pj4gKyMgSU5TVEFMTF9FRklfU1RSSVAsIGlmIGRlZmluZWQsIHdpbGwgY2F1c2UgeGVuLmVm
aSB0byBiZSBzdHJpcHBlZCBiZWZvcmUgaXQNCj4+PiArIyBpcyBpbnN0YWxsZWQuIElmIElOU1RB
TExfRUZJX1NUUklQIGlzICcxJywgdGhlbiB0aGUgZGVmYXVsdCBvcHRpb24NCj4+PiArIyAtLXN0
cmlwLWRlYnVnIHdpbGwgYmUgdXNlZC4gT3RoZXJ3aXNlLCBJTlNUQUxMX0VGSV9TVFJJUCB2YWx1
ZSB3aWxsIGJlIHVzZWQNCj4+PiArIyBhcyB0aGUgb3B0aW9uKHMpIHRvIHRoZSBzdHJpcCBjb21t
YW5kLg0KPj4+ICtpZmRlZiBJTlNUQUxMX0VGSV9TVFJJUA0KPj4+ICsNCj4+PiAraWZlcSAoJChJ
TlNUQUxMX0VGSV9TVFJJUCksMSkNCj4+PiArZWZpLXN0cmlwLW9wdCA6PSAtLXN0cmlwLWRlYnVn
DQo+Pj4gK2Vsc2UNCj4+PiArZWZpLXN0cmlwLW9wdCA6PSAkKElOU1RBTExfRUZJX1NUUklQKQ0K
Pj4+ICtlbmRpZg0KPj4+ICsNCj4+PiArZW5kaWYNCj4+IA0KPj4gVGhpcyBkb2VzIHNvdW5kIHZl
cnkgY29tcGxleCBhbmQgdXNpbmcgY29tYmluYXRpb24gb2YgaWZkZWYgYW5kIGlmZXEgb24gYW4g
ZXh0ZXJuYWwgdmFyaWFibGUgaXMgbm90IGRvbmUgYW55d2hlcmUgZWxzZS4NCj4+IA0KPj4gSG93
IGFib3V0IHNwbGl0dGluZyBpbnRvIGEgdmFyaWFibGUgdG8gdHVybiBzdHJpcCBvbiBvciBvZmYg
YW5kIGxldCB0aGUgdXNlciBvdmVycmlkZSBhIGxvY2FsIHZhcmlhYmxlIHNldHRpbmcgdXAgdGhl
IHN0cmlwIG9wdGlvbnMgaWYgaGUgd2FudHMgdG8gPw0KPj4gDQo+PiBTb21ldGhpbmcgbGlrZToN
Cj4+IA0KPj4gRUZJX1NUUklQX09QVElPTiA/PSAi4oCUc3RyaXAtZGVidWciDQo+PiANCj4+IEFu
ZCB0aGVuIGp1c3QgdXNpbmcgSU5TVEFMTF9FRklfU1RSSVAgdG8gc3RyaXAgb3Igbm90IGR1cmlu
ZyB0aGUgX2luc3RhbGwgcGhhc2UgDQo+IA0KPiBUaGlzICJqdXN0IHVzaW5nIElOU1RBTExfRUZJ
X1NUUklQIiBpcyB3aGF0IHdlIGhhdmUgd2l0aCB0aGUgcHJlc2VudA0KPiB2ZXJzaW9uIGFzIHdl
bGwsIGFuZCBJJ20gbm90IHJlYWxseSBsb29raW5nIGZvcndhcmQgdG8gaGF2ZSB0d28NCj4gc2Vw
YXJhdGUgdmFyaWFibGUgdG8gYWN0IHVwb24uIEl0IHdhcyBmb3IgdGhpcyBwYXJ0aWN1bGFyIHJl
YXNvbiB0aGF0DQo+IEkgdG9vayBMaW51eCdlcyBtb2R1bGUgaW5zdGFsbGF0aW9uIHByb2Nlc3Mg
YXMgYSAidGVtcGxhdGUiLg0KDQpZb3UgbmVlZCAyIHZhcmlhYmxlcyBvbmx5IHdoZW4geW91IHdh
bnQgdG8gY2hhbmdlIHRoZSBkZWZhdWx0IG9wdGlvbi4NCkFueXdheSB1cCB0byB5b3UgYnV0IEkg
dGhpbmsgdGhpcyBpcyBhIGJpdCB1bnVzdWFsIGFuZCB1c2luZyBpZmRlZiBmb3Igbm9uDQppbnRl
cm5hbCB2YXJpYWJsZXMgaXMgbm90IHNvbWV0aGluZyBJIHdvdWxkIGRvLg0KDQo+IA0KPj4gT25l
IHdhbnRpbmcgdG8gdXNlIG5vIHNwZWNpZmljIG9wdGlvbiB3b3VsZCBoYXZlIHRvIHBhc3MgSU5T
VEFMTF9FRklfU1RSSVA9MSBFRklfU1RSSVBfT1BUSU9OPeKAnOKAnSBmb3IgZXhhbXBsZS4NCj4g
DQo+IFRoaXMgcGFydGljdWxhciBleGFtcGxlIHdvdWxkbid0IHN0cmlwIGFueXRoaW5nIGFpdWks
IGFuZCBoZW5jZSB3b3VsZA0KPiBuZWVkbGVzc2x5IHRvdWNoIHRoZSBiaW5hcnkgKGFuZCBwZXJo
YXBzIG1ha2UgY2hhbmdlcyB0byBpdCBqdXN0IGFzIGENCj4gc2lkZSBlZmZlY3Q6IEZvciBleGFt
cGxlIEknbSBvYnNlcnZpbmcgdGhlIHN0cmluZyB0YWJsZSBncm93aW5nLCB3aGljaA0KPiBJIGhh
dmUgeWV0IHRvIGludmVzdGlnYXRlIGluIGJpbnV0aWxzKS4NCg0KVGhlIGV4YW1wbGUgd2FzIG5v
dCBtZWFudCB0byBiZSB1c2VmdWwgYnV0IGp1c3QgdG8gc2hvdyBob3cgYW4gZW1wdHkNCm9wdGlv
biBjb3VsZCBiZSBhY2hpZXZlZCBhcyBvdGhlciB1c2UgY2FzZXMgd2hlcmUgcXVpdGUgb2J2aW91
cy4NCg0KQmVydHJhbmQNCg0KPiANCj4gSmFuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 15:30:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 15:30:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314013.531868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njN8a-0001AM-Pd; Tue, 26 Apr 2022 15:30:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314013.531868; Tue, 26 Apr 2022 15:30:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njN8a-0001AF-MN; Tue, 26 Apr 2022 15:30:00 +0000
Received: by outflank-mailman (input) for mailman id 314013;
 Tue, 26 Apr 2022 15:29:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njN8Y-0001A5-V6; Tue, 26 Apr 2022 15:29:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njN8Y-0007Ld-UB; Tue, 26 Apr 2022 15:29:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njN8Y-0000H0-K6; Tue, 26 Apr 2022 15:29:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njN8Y-0007re-Jh; Tue, 26 Apr 2022 15:29:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2DtSX1Epo91tGM6TvVwBjod27jBz1GrLxL4Omom0gMM=; b=2v0eVi/+6+9Pdvo+488Kv0a8VF
	tIEAZScSiXQOFor63C4cD9O8g10SxfeayxVmK/tKo2Dhu+yWEyZQES0DkByd12FAG5xfRjZ4EzJfV
	9eUPHganhXqgJ6YMuvtDCUyvQN4nUoKBK3c+VY9jqcFrsWxoFy93xjH/Tmu96oN1YSfA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169742-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169742: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 15:29:58 +0000

flight 169742 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169742/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  644 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 15:31:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 15:31:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314020.531879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNAG-0002UQ-57; Tue, 26 Apr 2022 15:31:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314020.531879; Tue, 26 Apr 2022 15:31:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNAG-0002UJ-22; Tue, 26 Apr 2022 15:31:44 +0000
Received: by outflank-mailman (input) for mailman id 314020;
 Tue, 26 Apr 2022 15:31:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YDip=VE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njNAE-0002U9-Eb
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 15:31:42 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f861761c-c575-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 17:31:41 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CB0121F388;
 Tue, 26 Apr 2022 15:31:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B303813AD5;
 Tue, 26 Apr 2022 15:31:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id u5RYKlwQaGJ7aAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 26 Apr 2022 15:31:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f861761c-c575-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1650987100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=04SFVKgCeYCKWYZR9XGSPFG9GG/Fo/laSe4hlrKtfJo=;
	b=eq3SuacIsh4FoEIo8jf5SrdKs+WZCJ+OwETCV8MmNXyHaa1wpm/yWZcXXGM7CmsNYIs2kC
	6NX/Le4f5R893LOlb6MX6JIERQ3vsOamkIyKiVrQLIu+MAxPzWrH8SGfZX23CRUWs8N5XC
	EsAL0EiKIBda6sEf3E3++pKpBzItxOc=
Message-ID: <7041654b-1fe2-b3a3-fb87-7a4d4d3dad8f@suse.com>
Date: Tue, 26 Apr 2022 17:31:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
References: <20220426090810.28616-1-jgross@suse.com>
 <2942e8ed-e839-c3d7-69af-25f926d11da0@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/public: add new macro to ring.h
In-Reply-To: <2942e8ed-e839-c3d7-69af-25f926d11da0@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------XF6tThLcAogi91YjYKBF4DVS"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------XF6tThLcAogi91YjYKBF4DVS
Content-Type: multipart/mixed; boundary="------------0QzTqAK0jY90Wh0WhmSXuagA";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
Message-ID: <7041654b-1fe2-b3a3-fb87-7a4d4d3dad8f@suse.com>
Subject: Re: [PATCH] xen/public: add new macro to ring.h
References: <20220426090810.28616-1-jgross@suse.com>
 <2942e8ed-e839-c3d7-69af-25f926d11da0@suse.com>
In-Reply-To: <2942e8ed-e839-c3d7-69af-25f926d11da0@suse.com>

--------------0QzTqAK0jY90Wh0WhmSXuagA
Content-Type: multipart/mixed; boundary="------------uaiJ0CzkVQXnu79mW1S0SoqO"

--------------uaiJ0CzkVQXnu79mW1S0SoqO
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjYuMDQuMjIgMTE6NDMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNi4wNC4yMDIy
IDExOjA4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEveGVuL2luY2x1ZGUvcHVi
bGljL2lvL3JpbmcuaA0KPj4gKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2lvL3JpbmcuaA0K
Pj4gQEAgLTE4NCw2ICsxODQsMTEgQEAgdHlwZWRlZiBzdHJ1Y3QgX19uYW1lIyNfYmFja19y
aW5nIF9fbmFtZSMjX2JhY2tfcmluZ190DQo+PiAgIA0KPj4gICAjZGVmaW5lIEZST05UX1JJ
TkdfSU5JVChfciwgX3MsIF9fc2l6ZSkgRlJPTlRfUklOR19BVFRBQ0goX3IsIF9zLCAwLCBf
X3NpemUpDQo+PiAgIA0KPj4gKyNkZWZpbmUgWEVOX0ZST05UX1JJTkdfSU5JVChfciwgX3Ms
IF9fc2l6ZSkgZG8geyAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4+ICsgICAgU0hBUkVE
X1JJTkdfSU5JVChfcyk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBcDQo+PiArICAgIEZST05UX1JJTkdfSU5JVChfciwgX3MsIF9fc2l6ZSk7ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXA0KPj4gK30gd2hpbGUgKDApDQo+
IA0KPiBJIHRoaW5rIGl0IHdvdWxkIGJlIGdvb2QgZm9yIHRoZSBjb21tZW50IGFyb3VuZCBs
aW5lIDEwMCB0byBhbHNvDQo+IGhhdmUgYSByZWZlcmVuY2UgdG8gdGhpcy4NCg0KT2theS4N
Cg0KPiBBcyB0byBzdHlsZTogQ291bGQgSSB0YWxrIHlvdSBpbnRvIG5vdCBmdXJ0aGVyIHBy
b2xpZmVyYXRpbmcgdGhlDQo+IGluYXBwcm9wcmlhdGUgdXNlIG9mIHVuZGVyc2NvcmUtcHJl
Zml4ZWQgbmFtZXMgYXMgbWFjcm8gcGFyYW1ldGVycz8NCj4gRXZlbiBtb3JlIHNvIG9uZSB3
aXRoIGEgZG91YmxlIHVuZGVyc2NvcmU/DQoNCk9rYXkuDQoNCj4gQXMgdG8gZnVuY3Rpb25h
bGl0eTogSSB0YWtlIGl0IHRoYXQgaXQgaXMgbm90IHZpZXdlZCBhcyBhbiBpc3N1ZQ0KPiB0
aGF0IG1hbnkgb2YgdGhlIG1hY3JvcyBoZXJlIGV2YWx1YXRlIHRoZWlyIGFyZ3VtZW50cyBt
dWx0aXBsZQ0KPiB0aW1lcz8NCg0KSSBkb24ndCB0aGluayB0aGlzIGlzIHByb2JsZW1hdGlj
Lg0KDQoNCkp1ZXJnZW4NCg==
--------------uaiJ0CzkVQXnu79mW1S0SoqO
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------uaiJ0CzkVQXnu79mW1S0SoqO--

--------------0QzTqAK0jY90Wh0WhmSXuagA--

--------------XF6tThLcAogi91YjYKBF4DVS
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJoEFwFAwAAAAAACgkQsN6d1ii/Ey9B
SAf/Urz7t5V+WagqRW5kN0EGk2TWRo53CnEQSxgc2FVk41YJY0gRxn5SiULF+6ueiRMkxXd7+tc3
3ykyPoiz6pHCHSowOt8ynxtzJ6G/k4sVaBwckoOujIaXzN3Uhbqo0lX9n+J2BMtm6MJ2mi9kW9un
XPGE51zr2Nf86Xz7iDgRkBqF4zKmD1fYjftY7j8OqFy1EfOigLXKfqIwo9KQw9WLOS/0LNmL5mhP
UDEPrYZFtoAYY2LocLyqdZglhR2KMgOQu7xx3BO7t77GzE2nasV4Y7Qdn/x65lgNUvbbNp+04p48
J8ZWa+ZZ0ZxIKv58/VdFACAS9Dqeav/TD9wpxOiygg==
=nll9
-----END PGP SIGNATURE-----

--------------XF6tThLcAogi91YjYKBF4DVS--


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 15:38:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 15:38:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314027.531890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNGI-0003CM-Q1; Tue, 26 Apr 2022 15:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314027.531890; Tue, 26 Apr 2022 15:37:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNGI-0003CF-MP; Tue, 26 Apr 2022 15:37:58 +0000
Received: by outflank-mailman (input) for mailman id 314027;
 Tue, 26 Apr 2022 15:37:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ckxI=VE=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1njNGH-0003C7-91
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 15:37:57 +0000
Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com
 [2607:f8b0:4864:20::633])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d722a0ef-c576-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 17:37:56 +0200 (CEST)
Received: by mail-pl1-x633.google.com with SMTP id u7so15227021plg.13
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 08:37:56 -0700 (PDT)
Received: from [192.168.0.18] ([118.33.58.98])
 by smtp.gmail.com with ESMTPSA id
 a187-20020a6366c4000000b003ab9d95794esm1746674pgc.16.2022.04.26.08.37.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 26 Apr 2022 08:37:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d722a0ef-c576-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:to:references:from
         :cc:in-reply-to:content-transfer-encoding;
        bh=IebQ5LigAN+2AhkZSSlulrmlCDIY0obAkVvfez4z1qI=;
        b=MV4go5IgBXg3ZAZr56JI9xUZkkKa+g5qPYEhj4/Oadap/rPtW7RSpGG6ZQlMogBpW/
         Jxa1CtOgljbF89WJRxbZJQ0s2JK4tO+kVryUu5ryyNe08nwkR/LDFuZwoaXYr7UIWyzH
         CANzRAfIDtmtZI0lWEG2a5uzyMsXFCyzGn6c+nbd2qZMzN8Svb6feNJvXHhb9JCNJo32
         xiaE9n86c296FEyHCF8CboZzQzS3wxCCRIrYgNDiG+a1tbs/gt+NNXE+2cML3lKMHm/z
         CqzpNWHfjgxa5x5TjssbRMvsnu7LHuL5DzrvhWJqLGBzp3nqNP8qb9cNpdaxRTMJcGUL
         Sclw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :to:references:from:cc:in-reply-to:content-transfer-encoding;
        bh=IebQ5LigAN+2AhkZSSlulrmlCDIY0obAkVvfez4z1qI=;
        b=yLpblui4IRJ6XPcYMpqokqjg6tROPn68MFjstLXgZIRVbIuNalIGOXiBeKAlNpIFRP
         +zIRV/8NOBtrz5o4nT+KjASFNbbQiUSOc6oNcbc/9R3IkqWqaAX/Z1xyULPDnngpbIdc
         +nBiy5Z2LVGXzaAO6M8+pHv9j8vWTGnSkSdS2GVmZxtI313U5I2ot1nN5vcbQi37DRvq
         wopwgUbwhZpD+qg+VOCpB67hE+XOz1ZvKFBA5ZFYRx2bxtdhDMzggMKC8rKNuhZnz8WT
         8a29cK5IHvHT1ke7CF+xDEQNvJ9MkUWXHCwmBrzl5Ou4ezTEaCFsJX6FhdJbDAOIy9T+
         WERg==
X-Gm-Message-State: AOAM533+GnOZKYDJ91QdX0unSbVuqYhfRpqBGGPz2xMrp/2km8U6noc0
	CV+2S9XyTqkOAOaPHn1Wgus=
X-Google-Smtp-Source: ABdhPJw4FKqwhsBZUQggWtx7osrAP35i5qIddJJpY4OP9TdJBplRv+ivJ4mhvzDYfG7mfyJ+h5H96A==
X-Received: by 2002:a17:902:b606:b0:158:f7d1:c085 with SMTP id b6-20020a170902b60600b00158f7d1c085mr23769167pls.12.1650987474107;
        Tue, 26 Apr 2022 08:37:54 -0700 (PDT)
Message-ID: <086069c4-406b-ac33-7c44-8433980026fc@gmail.com>
Date: Wed, 27 Apr 2022 00:37:50 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/arm: p2m_set_entry duplicate calculation.
To: Julien Grall <julien@xen.org>
References: <20220421151755.GA4718@DESKTOP-NK4TH6S.localdomain>
 <a160a77a-1cb2-c7cb-7d93-7334772620fe@xen.org>
From: Paran Lee <p4ranlee@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
In-Reply-To: <a160a77a-1cb2-c7cb-7d93-7334772620fe@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello, Julien Grall.

Thanks you, I agreed! It made me think once more about what my patch
could improve.
patches I sent have been reviewed in various ways. It was a good
opportunity to analyze my patch from various perspectives. :)

I checked objdump in -O2 optimization(default) of Xen Makefile to make
sure CSE (Common subexpression elimination) works well on the latest
arm64 cross compiler on x86_64 from  Arm GNU Toolchain.

$
~/gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu/bin/aarch64-none-linux-gnu-gcc
-v
...
A-profile Architecture 10.3-2021.07 (arm-10.29)'
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 10.3.1 20210621 (GNU Toolchain for the A-profile
Architecture 10.3-2021.07 (arm-10.29)

I compared the before and after my patches. This time, without adding a
"pages" variable, I proceeded to use the local variable mask with order
operation.

I was able to confirm that it does one less operation.

(1) before clean up

0000000000001bb4 <p2m_set_entry>:
    while ( nr )
    1bb4:       b40005e2        cbz     x2, 1c70 <p2m_set_entry+0xbc>
{
    ...
        if ( rc )
    1c1c:       350002e0        cbnz    w0, 1c78 <p2m_set_entry+0xc4>
        sgfn = gfn_add(sgfn, (1 << order));
    1c20:       1ad32373        lsl     w19, w27, w19   // <<< CES works
    1c24:       93407e73        sxtw    x19, w19        // <<< well!
    return _gfn(gfn_x(gfn) + i);
    1c28:       8b1302d6        add     x22, x22, x19
    return _mfn(mfn_x(mfn) + i);
    1c2c:       8b130281        add     x1, x20, x19
    1c30:       b100069f        cmn     x20, #0x1
    1c34:       9a941034        csel    x20, x1, x20, ne  // ne = any
    while ( nr )
    1c38:       eb1302b5        subs    x21, x21, x19
    1c3c:       540001e0        b.eq    1c78 <p2m_set_entry+0xc4>  // b.none

(2) Using again mask variable. mask = 1UL << order
code show me   sxtw    x19, w19    operation disappeared.

0000000000001bb4 <p2m_set_entry>:
    while ( nr )
    1bb4:       b40005c2        cbz     x2, 1c6c <p2m_set_entry+0xb8>
{
    ...
        if ( rc )
    1c1c:       350002c0        cbnz    w0, 1c74 <p2m_set_entry+0xc0>
        mask = 1UL << order;
    1c20:       9ad32373        lsl     x19, x27, x19   // <<< only lsl
    return _gfn(gfn_x(gfn) + i);
    1c24:       8b1302d6        add     x22, x22, x19
    return _mfn(mfn_x(mfn) + i);
    1c28:       8b130281        add     x1, x20, x19
    1c2c:       b100069f        cmn     x20, #0x1
    1c30:       9a941034        csel    x20, x1, x20, ne  // ne = any
    while ( nr )
    1c34:       eb1302b5        subs    x21, x21, x19
    1c38:       540001e0        b.eq    1c74 <p2m_set_entry+0xc0>  // b.none

I'll send you a follow-up patch I've been working on.

BR
Paran Lee

2022-04-25 오전 1:17에 Julien Grall 이(가) 쓴 글:
> Hi,
> 
> On 21/04/2022 16:17, Paran Lee wrote:
>> It doesn't seem necessary to do that calculation of order shift again.
> 
> I think we need to weight that against increasing the number of local
> variables that do pretty much the same.
> 
> This is pretty much done to a matter of taste here. IMHO, the original
> version is better but I see Stefano reviewed it so I will not argue
> against it.
> 
> That said, given you already sent a few patches, can you explain why you
> are doing this? Is this optimization purpose? Is it clean-up?
> 
>>
>> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
>> ---
>>   xen/arch/arm/p2m.c | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>> index 1d1059f7d2..533afc830a 100644
>> --- a/xen/arch/arm/p2m.c
>> +++ b/xen/arch/arm/p2m.c
>> @@ -1092,7 +1092,7 @@ int p2m_set_entry(struct p2m_domain *p2m,
>>       while ( nr )
>>       {
>>           unsigned long mask;
>> -        unsigned long order;
>> +        unsigned long order, pages;
>>             /*
>>            * Don't take into account the MFN when removing mapping (i.e
>> @@ -1118,11 +1118,12 @@ int p2m_set_entry(struct p2m_domain *p2m,
>>           if ( rc )
>>               break;
>>   -        sgfn = gfn_add(sgfn, (1 << order));
>> +        pages = 1 << order;
> 
> Please take the opportunity to switch to 1UL.
> 
>> +        sgfn = gfn_add(sgfn, pages);
>>           if ( !mfn_eq(smfn, INVALID_MFN) )
>> -           smfn = mfn_add(smfn, (1 << order));
>> +           smfn = mfn_add(smfn, pages);
>>   -        nr -= (1 << order);
>> +        nr -= pages;
>>       }
>>         return rc;
> 
> Cheers,
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 15:49:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 15:49:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314033.531900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNR9-0004fo-R1; Tue, 26 Apr 2022 15:49:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314033.531900; Tue, 26 Apr 2022 15:49:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNR9-0004fh-Mt; Tue, 26 Apr 2022 15:49:11 +0000
Received: by outflank-mailman (input) for mailman id 314033;
 Tue, 26 Apr 2022 15:49:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ckxI=VE=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1njNR8-0004fb-If
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 15:49:10 +0000
Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com
 [2607:f8b0:4864:20::1030])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 68b76703-c578-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 17:49:09 +0200 (CEST)
Received: by mail-pj1-x1030.google.com with SMTP id iq10so5402519pjb.0
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 08:49:09 -0700 (PDT)
Received: from localhost ([118.33.58.98]) by smtp.gmail.com with ESMTPSA id
 p1-20020a056a000a0100b0050ac9c31b7esm17145655pfh.180.2022.04.26.08.49.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 26 Apr 2022 08:49:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68b76703-c578-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition;
        bh=tPv0CVXqU70KWoKIiR1mvzTdX3vbXAGSStsF5ep6zGY=;
        b=aB1kcoPYNJrsemdnI8inT9YidIrM/5nIdL44JDIQccNsFCbrNEWYaIyRrG5mSJhnN9
         m4mXbD5Zzqw8LeGt1WPhu5c5VFHR2Xkpgq2QABh5onREUcNyHmz8g463XzQty8vqnQiw
         xSCyxM9dzK+Cc0LjuThOinbSXcCneNFxccq4DbmGxm23yNoKpr4npFgBAEPPA/qXL9vB
         CoOi7CNa5q+8+RLdY9Epv8h48IcR+0FNoFbz4OryDAQlEQcPfgxq8D7ivwZ/aJ455iWY
         Glfr03/HhRVzJxeFs6cUQQS8RUU3EnsUrMYdHqotqXqHUIbAH9BRQ4Cq2RcPEU0/AGcH
         t/Ww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition;
        bh=tPv0CVXqU70KWoKIiR1mvzTdX3vbXAGSStsF5ep6zGY=;
        b=egZ6qOknP4/mzcksaaBVQAJm0PGeVprjifgleEVz3LqA4aP/TpuWPG2Q5uo9SzlHgb
         SzeoAS10qDX3LqHsBLnFGj28jm3zjjr+IjxPs8sR6+hszFZZ0h8l+AgVOjTeW3xUi6JK
         zWVtdcnjOpwC+hd+LjY4n2H1sjZjBpsM3aXMl6b26GgD5eCx6AqqU19B8QGIypBamexG
         p6gdWL7Hdarq1qJyaxCDqbEeeLR8+kgm7Lk41wX6teddGRQUxxHZAEWMPzQ99P8C1Dfw
         qEvzHfqTy8uMC0yq2YBD/neSX/o/qJAUOUKmnsyTOAPDOayTA844kXvszDmQh6a8NKfN
         pkBQ==
X-Gm-Message-State: AOAM530jHdLUPtR0trusiunGQfyJVP8PrDgTtzTxNvSMpRYNS8eNf1+1
	E8FbAUct1/YMurG9+6K2p24=
X-Google-Smtp-Source: ABdhPJzJxmrVBJ8YNTOD/sZSY5ZT08VM8ql6hEsaUNdgvvYURMQnFOU3ghmv7F3FPWzOlLJpzlff5w==
X-Received: by 2002:a17:902:da85:b0:15d:3a9a:aad1 with SMTP id j5-20020a170902da8500b0015d3a9aaad1mr2928463plx.113.1650988147963;
        Tue, 26 Apr 2022 08:49:07 -0700 (PDT)
Date: Wed, 27 Apr 2022 00:49:04 +0900
From: Paran Lee <p4ranlee@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: austindh.kim@gmail.com, xen-devel@lists.xenproject.org
Subject: [PATCH v2] xen/arm: p2m_set_entry reuse mask variables
Message-ID: <20220426154904.GA11482@DESKTOP-NK4TH6S.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Reuse mask variables on order shift duplicated calculation.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 xen/arch/arm/p2m.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 1d1059f7d2..cdb3b56aa1 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1118,11 +1118,12 @@ int p2m_set_entry(struct p2m_domain *p2m,
         if ( rc )
             break;
 
-        sgfn = gfn_add(sgfn, (1 << order));
+        mask = 1UL << order;
+        sgfn = gfn_add(sgfn, mask);
         if ( !mfn_eq(smfn, INVALID_MFN) )
-           smfn = mfn_add(smfn, (1 << order));
+           smfn = mfn_add(smfn, mask);
 
-        nr -= (1 << order);
+        nr -= mask;
     }
 
     return rc;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 16:06:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 16:06:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314040.531911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNhZ-0007aq-BO; Tue, 26 Apr 2022 16:06:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314040.531911; Tue, 26 Apr 2022 16:06:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNhZ-0007aj-8W; Tue, 26 Apr 2022 16:06:09 +0000
Received: by outflank-mailman (input) for mailman id 314040;
 Tue, 26 Apr 2022 16:06:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WOtE=VE=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1njNhY-0007ad-3d
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 16:06:08 +0000
Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com
 [2a00:1450:4864:20::331])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c4b1748d-c57a-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 18:06:02 +0200 (CEST)
Received: by mail-wm1-x331.google.com with SMTP id
 u9-20020a05600c00c900b00393e729e655so1897782wmm.0
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 09:06:02 -0700 (PDT)
Received: from zen.linaroharston ([51.148.130.216])
 by smtp.gmail.com with ESMTPSA id
 r10-20020a7bc08a000000b0039049f8b3f9sm11378886wmh.27.2022.04.26.09.05.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 26 Apr 2022 09:05:59 -0700 (PDT)
Received: from zen.lan (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 150621FFB7;
 Tue, 26 Apr 2022 17:05:59 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4b1748d-c57a-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=hh56RWc6gtXA2z6EUyK7Tz0GoSjRWtZffKf8c4j7OtA=;
        b=zXfKHGVCeCGOr1jTvH9lgimkEkGlncrojjkrWGXtbijpA1UCpw9CnlLpqHlxBaW7Wk
         5PtvmkDz4dJekc/HCHkMywb8e2mNKBuFx4XjjQokmq9iGbz5R2asZsHS+ycVJabIXL0m
         ezHXhG0I2BsEmKAuFI9Q+qwjTwWQ+9JmyM8NExFCN8EYgQvdpvVZSJ9atdD6rfkAUtBL
         q11A6KB0Sy59ImliEskLR3BW3GG54VI0itO5eJA1CjyIYQz355t5UADul81zeaf2pJhU
         BsQ4eluDfIGTz01OZwxX0ZtMDXU3QhQI1qfnOU5fvMj+IGDsXjq/nWD16XruGC8CMGjF
         L9LA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=hh56RWc6gtXA2z6EUyK7Tz0GoSjRWtZffKf8c4j7OtA=;
        b=MAYLLuFuO6jj/5MZqtd4+Pbeokq25vwKtTyheLkydf7jJcIaNGzGB/kd4a/79tmucG
         7hiZ2C4+g7G8B/jBxY/AEajAAXbVYbtDmJJ5KzfH1IEqA/Cs+ahNajkknln1RWO0FP4D
         lMNPCc9rv6Om+ntFU8odlBDEzhUBEdEh72895Gtck51tWm7c1TvrhVxeOkMq/sb5MsE+
         JSMwp2TH2HqZ2iQAEGUyIJZYzx4ppXBE/WoL5t0kTXdCDNlpqVlGU383BcoGU5TQuPQY
         Dlw0pfl1jipAc3OTIWR60aUpvqj0Xj77D5P91eS0AVBaHJzHhJK5et3aIRn2vdjIZsVc
         7LIw==
X-Gm-Message-State: AOAM532+ziBn77AmQpAzif8rVRo06XYdVq3dEcXhhb7+B6vgcXrdL3xI
	pn91787C3QL0Z6HJvQrtZ/0nZg==
X-Google-Smtp-Source: ABdhPJxuOifDtw16drRhavIhgXI9N5/w9xRdfPjmcPMaJpX8kFneUoW/8IpdgEIaeuYoPOlVqR5TRg==
X-Received: by 2002:a05:600c:4808:b0:393:fbd3:f1fa with SMTP id i8-20020a05600c480800b00393fbd3f1famr2233860wmo.100.1650989161449;
        Tue, 26 Apr 2022 09:06:01 -0700 (PDT)
From: =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: stratos-dev@op-lists.linaro.org,
	=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC PATCH] xen/arm: p2m don't fall over on FEAT_LPA enabled hw
Date: Tue, 26 Apr 2022 17:05:48 +0100
Message-Id: <20220426160548.2020794-1-alex.bennee@linaro.org>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When we introduced FEAT_LPA to QEMU's -cpu max we discovered older
kernels had a bug where the physical address was copied directly from
ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commits
the same error by blindly copying across the max supported range.

Unsurprisingly when the page tables aren't set up for these greater
ranges hilarity ensues and the hypervisor crashes fairly early on in
the boot-up sequence. This happens when we write to the control
register in enable_mmu().

Attempt to fix this the same way as the Linux kernel does by gating
PARange to the maximum the hypervisor can handle. I also had to fix up
code in p2m which panics when it sees an "invalid" entry in PARange.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>
---
 xen/arch/arm/arm64/head.S | 6 ++++++
 xen/arch/arm/p2m.c        | 9 ++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index aa1f88c764..057dd5d925 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -473,6 +473,12 @@ cpu_init:
         ldr   x0, =(TCR_RES1|TCR_SH0_IS|TCR_ORGN0_WBWA|TCR_IRGN0_WBWA|TCR_T0SZ(64-48))
         /* ID_AA64MMFR0_EL1[3:0] (PARange) corresponds to TCR_EL2[18:16] (PS) */
         mrs   x1, ID_AA64MMFR0_EL1
+        /* Limit to 48 bits, 256TB PA range (#5) */
+        ubfm  x1, x1, #0, #3
+        mov   x2, #5
+        cmp   x1, x2
+        csel  x1, x1, x2, lt
+
         bfi   x0, x1, #16, #3
 
         msr   tcr_el2, x0
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index fb71fa4c1c..e5a88095f8 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -2030,7 +2030,7 @@ void __init setup_virt_paging(void)
         unsigned int root_order; /* Page order of the root of the p2m */
         unsigned int sl0;    /* Desired SL0, maximum in comment */
     } pa_range_info[] = {
-        /* T0SZ minimum and SL0 maximum from ARM DDI 0487A.b Table D4-5 */
+        /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */
         /*      PA size, t0sz(min), root-order, sl0(max) */
         [0] = { 32,      32/*32*/,  0,          1 },
         [1] = { 36,      28/*28*/,  0,          1 },
@@ -2038,7 +2038,7 @@ void __init setup_virt_paging(void)
         [3] = { 42,      22/*22*/,  3,          1 },
         [4] = { 44,      20/*20*/,  0,          2 },
         [5] = { 48,      16/*16*/,  0,          2 },
-        [6] = { 0 }, /* Invalid */
+        [6] = { 52,      12/*12*/,  3,          3 },
         [7] = { 0 }  /* Invalid */
     };
 
@@ -2069,10 +2069,13 @@ void __init setup_virt_paging(void)
         }
     }
 
-    /* pa_range is 4 bits, but the defined encodings are only 3 bits */
+    /* pa_range is 4 bits but we don't support all modes */
     if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits )
         panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", pa_range);
 
+    if ( pa_range > 5 )
+        pa_range = 5;
+
     val |= VTCR_PS(pa_range);
     val |= VTCR_TG0_4K;
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 16:17:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 16:17:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314048.531928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNsE-0000eP-FJ; Tue, 26 Apr 2022 16:17:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314048.531928; Tue, 26 Apr 2022 16:17:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNsE-0000eI-Bm; Tue, 26 Apr 2022 16:17:10 +0000
Received: by outflank-mailman (input) for mailman id 314048;
 Tue, 26 Apr 2022 16:17:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njNsD-0000e8-1M; Tue, 26 Apr 2022 16:17:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njNsC-0000GR-VX; Tue, 26 Apr 2022 16:17:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njNsC-0001K1-Je; Tue, 26 Apr 2022 16:17:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njNsC-0001Ab-JC; Tue, 26 Apr 2022 16:17:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5aTIj5pBchQERfxwhPQx91wkBCsis3iSoP4/L+ZFsCI=; b=YSK8uAsg2syFe9vf67lnjBHsv9
	CPM2i1NlWRXBhKuDHvWtR/fLxZ+hx+6AjOENouk3ksB3krk7z+sy7PwfD9cQFEDgEWk6h3h5rTVKW
	NaczTk845/LacDIq7KnreZqDZIR4d5+NZmm7aFgSOT79oqMInr8iGPQBEHPMRD+fHHX4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169744-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169744: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 16:17:08 +0000

flight 169744 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169744/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  645 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 16:18:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 16:18:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314055.531939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNtf-0001DJ-QR; Tue, 26 Apr 2022 16:18:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314055.531939; Tue, 26 Apr 2022 16:18:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njNtf-0001DC-Nc; Tue, 26 Apr 2022 16:18:39 +0000
Received: by outflank-mailman (input) for mailman id 314055;
 Tue, 26 Apr 2022 16:18:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njNtd-0001Cu-S5; Tue, 26 Apr 2022 16:18:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njNtd-0000JB-RB; Tue, 26 Apr 2022 16:18:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njNtd-0001LJ-Gt; Tue, 26 Apr 2022 16:18:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njNtd-0001DN-GQ; Tue, 26 Apr 2022 16:18:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LNNKHs3PBjAiqKK4ScbZN+UqK4y2o2VEbOtu1qOa7QM=; b=vqq2TKfm88g5GSD63WYmIM/g+T
	3oFD1lEhz6NBgbKStdWRrcRfVs4C7Znkjujgd73Wso7VpX5185N+M1rYSyoO/b0vMYs67056pyocy
	O3bPu0/zIapA0jim1gNgtjy9KizEqq2PJkzyvn1daCOdte9oISpJr070wm0rEJi0PVdQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169737-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169737: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:xen-boot:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=88a037e2cfe11a723fe420d3585837ab1bdc6f8a
X-Osstest-Versions-That:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 16:18:37 +0000

flight 169737 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169737/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 169630
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 169630

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  88a037e2cfe11a723fe420d3585837ab1bdc6f8a
baseline version:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08

Last test of basis   169630  2022-04-22 20:01:46 Z    3 days
Testing same since   169729  2022-04-26 09:00:28 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 88a037e2cfe11a723fe420d3585837ab1bdc6f8a
Author: David Vrabel <dvrabel@amazon.co.uk>
Date:   Tue Apr 26 10:33:01 2022 +0200

    page_alloc: assert IRQs are enabled in heap alloc/free
    
    Heap pages can only be safely allocated and freed with interrupts
    enabled as they may require a TLB flush which may send IPIs (on x86).
    
    Normally spinlock debugging would catch calls from the incorrect
    context, but not from stop_machine_run() action functions as these are
    called with spin lock debugging disabled.
    
    Enhance the assertions in alloc_xenheap_pages() and
    alloc_domheap_pages() to check interrupts are enabled. For consistency
    the same asserts are used when freeing heap pages.
    
    As an exception, when only 1 PCPU is online, allocations are permitted
    with interrupts disabled as any TLB flushes would be local only. This
    is necessary during early boot.
    
    Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit c266f974148d3d1b21d01b8bb243017943786444
Author: Daniel P. Smith <dpsmith@apertussolutions.com>
Date:   Tue Apr 26 10:30:31 2022 +0200

    xsm/flask: code style formatting
    
    This is a quick code style cleanup patch for xsm/flask. The files flask_op.c
    and hooks.c are Xen specific, thus full code style rules were applied. The
    remaining files are from Linux and therefore only trailing whitespace was
    remove from those files.
    
    Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jason Andryuk <jandryuk@gmail.com>

commit fa4d84e6dd3c3bfd23a525b75a5483d4ce15adbb
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Apr 26 10:25:54 2022 +0200

    IOMMU: make domctl handler tolerate NULL domain
    
    Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX,
    XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed
    here, when the domctl was passed DOMID_INVALID.
    
    Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...")
    Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Paul Durrant <paul@xen.org>
    Reviewed-by: Juergen Gross <jgross@suse.com>

commit 9cd7e31b3f584e97a138a770cfb031a91a867936
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Apr 26 10:23:58 2022 +0200

    xen/iommu: cleanup iommu related domctl handling
    
    Today iommu_do_domctl() is being called from arch_do_domctl() in the
    "default:" case of a switch statement. This has led already to crashes
    due to unvalidated parameters.
    
    Fix that by moving the call of iommu_do_domctl() to the main switch
    statement of do_domctl().
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> # Arm
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 16:38:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 16:38:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314064.531951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njOCB-0003Zq-En; Tue, 26 Apr 2022 16:37:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314064.531951; Tue, 26 Apr 2022 16:37:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njOCB-0003Zj-B5; Tue, 26 Apr 2022 16:37:47 +0000
Received: by outflank-mailman (input) for mailman id 314064;
 Tue, 26 Apr 2022 16:37:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cQU5=VE=citrix.com=prvs=10866150f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njOCA-0003Zd-Gg
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 16:37:46 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 30d1c43e-c57f-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 18:37:42 +0200 (CEST)
Received: from mail-bn1nam07lp2042.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 12:37:39 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SJ0PR03MB6453.namprd03.prod.outlook.com (2603:10b6:a03:398::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 26 Apr
 2022 16:37:36 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 16:37:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30d1c43e-c57f-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650991062;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=oRGEQ/a3qRcufvp+NQRpZn/g6XWsiVDMi/nMRlk52jM=;
  b=HZfdxcGWLmOTcMIEPy150zwG9jCbp6M2m63kuU1kMIL4AHa+kaDTrTXb
   +LTBEaO2p+5stGUYjJGtXqTq9fNkRWl+sx5fOxnhGcFWW8Ns94GB+Nc4C
   a5j5vu16la3wfRIfmsI0KGZmKd3Qt6D69/+xEqLkuOitF94/lR1gbsj/F
   Y=;
X-IronPort-RemoteIP: 104.47.51.42
X-IronPort-MID: 69367535
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:1O65KKy0/lXvy+shR4d6t+dWxyrEfRIJ4+MujC+fZmUNrF6WrkUCm
 DZLXm/XbqyON2WnKN9wa4vi905UvZLTnIVqQVBrriAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024bhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpliIa6WA0XEJD3vN8GYzt6TSBzYfRE9+qSSZS/mZT7I0zuVVLJm68rJmdveIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeGuOWv7e03x9p7ixKNezZa
 McDLyJmcTzLYgFVO0dRA5U79AutrieuKGMH9QnIzUYxy3rqlQ9Pj//uC/PqZNiIe8xOo0WIn
 1uTqgwVBTlfbrRz0wGt/3OqnevCtTv7QJ4IFa3++vMCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySWosLVWhS5pDuOuEcaUt8ITOkislnRkOzT/hqTAXUCQnhZcts6ucQqRDssk
 FiUg9fuAj8pu7qQIZ6AyoqpQfqJEXB9BQc/ieUsFGPpP/GLTFkPsy/y
IronPort-HdrOrdr: A9a23:QTtTXqAzILuF7n/lHegwsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80lKQFmLX5WI3PYOCIgguVxe1ZnOjfKnjbalbDH41mpN
 tdmspFebrN5DFB5K6VgTVQUexQpuVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dOwEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfbHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+0+VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qZ5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 529lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ5o+a87bWzHAb0cYa
 hT5Jm23ocXTbraVQGSgoBX+q3iYpxpdS32AXTruaSuokprdT5CvgklLfck7wk9HaIGOuZ5Dt
 v/Q9VVfZF1P7srhPFGdZA8qfXeMB28fTv8dESvHH/AKIYrf1rwlr+f2sRH2AjtQu1C8KcP
X-IronPort-AV: E=Sophos;i="5.90,291,1643691600"; 
   d="scan'208";a="69367535"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xr+QLAheRvgXf0+hWQPfi0ac2M+1hC8/RFNZ9ZHNm0ka6jcsepO3Y4/94EKEh9aM6azSz/EpD2swTZ/CIGVeyUurvZC9XmIX1yRXOtmLUOhu9FS/zf+iayNRMMoiNGBcTzxF4XLbj4qhsm6b02AdwMtGCoGFRixb54leJd2VEmgC8insZVFF74NcJSV0lVP/KkbDlJ8ARfRkc1CLpUyydeHguu0lPSqe/tKaethEx6A2rYMLdxH6r0KDiwyMiQ+TJRIDl83hL1cVzp/BJf7SR3AQ2uDVxOCM2S32XlQFqd5WmnX8xBekGTI4kiU3j9uVdFF8CXErWldmQl8ACkmWLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mDw+djdBhuaVxWhxTwQI6KRWuP2cyo9PZ6Zor841pD0=;
 b=WOXvbgVvAd8QjouVxwkVA1CmSOmV4A1/Ul1xcHX8EpqzilFJgXW2FBRTi5aIRl2w4njLkEryz/uK82JQ53EcUxWcGMdeLgP61VFKtYIfuwk4LbKgaTJC3EhllgPnbEHL5L7TEfeKcyaJfY3UeDESd0YMZc3/9kpH3YvVHKyiKEjysVCYZu5yF85vivpjSErba7t5rHFC+Qehyq2ArPdHrPDoDdALsKXHjDi//2l/yFwWqXtOyg+N3rAxwX/XwXBZs8Ywwt5WRaf3Zb+AuM7WqPemR4SmV9Ynkya8qoWdGhoqo8DON3iQCgo7oSBCyNNTFyzeKyO14W3szqW8ExHeMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mDw+djdBhuaVxWhxTwQI6KRWuP2cyo9PZ6Zor841pD0=;
 b=q0wXy4DIvH1mtgfech3x+9U4hFeGXdBpNu1tj9NyuSbJP5MgDYu+HgY274FZ2Vr9qSl+5SPKV419gALGNIV0ghPWmuis7LK64go/EhfFNJbxuld8A/mNlI6iMr+1URyM8tsEyGdareIqZBi14rnRO04R7/5LenXl91jpQ9UiRko=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 26 Apr 2022 18:37:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Steffen Einsle <einsle@phptrix.de>
Cc: xen-devel@lists.xenproject.org
Subject: Re: DomU Windows Server Essentials crashes with xen 4.16 but works
 with xen 4.14
Message-ID: <YmgfyXXke4RYpXPm@Air-de-Roger>
References: <18bd542a-a649-c78b-b575-c62b4d533e44@phptrix.de>
 <YmeZ/8wtKJy7zzmS@Air-de-Roger>
 <8ec2423f-d968-54d4-4bc4-fd8ded3d1fa0@phptrix.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8ec2423f-d968-54d4-4bc4-fd8ded3d1fa0@phptrix.de>
X-ClientProxiedBy: LO4P123CA0220.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f39361c-9491-4292-eea1-08da27a3121a
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6453:EE_
X-Microsoft-Antispam-PRVS:
	<SJ0PR03MB6453608F5FFAEBC55EA9FDC08FFB9@SJ0PR03MB6453.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yCK5dUR0r0KL6c20stm3lV+abQe2T5KOVAdrkYp59q8qFNWBDsL6iC5Qbe/IGYahI/WPyZOVaXzE6spyGLwEWAP2tHV2P8QVKUMdfozVQsgvEyyFct4BqoSI4sVS7sL0euiq9cQBtB8tjZQ478otSWaDyFyKrcV+tswYpvZivvSZCnrIU6emlDzzMawQalY/ku7dOY5L/+YtIm/zM6b1S5mPPuNOCOEJWuAi1Plv8wn8nRAaHFtaCfx4L5OZQWKSHr4FWg77u8NVAjoW0cspKt6DpTM8u7/F4BhN874vEth0G7ga7bgHhSFa8H1oA5Z/M3ZWdd8i0fOlXDAFVZ+a4LGd2uSVLvb8drBqV0ll4rUmRUWTCAprsAIXYtVDqddWswNcIaPF/od4RUsfQy1nzF4MSg605zF6AWvsYBJ1MDLSj2GBQRUBFJf1tx9LL0llHiXoGEz6HYluOTtt4KlkdFPXQYA4ZEMmzaBlNJtv+uzsuzUtdm2ceGu5sdM/gle1p6OL9NkPtZEmu+gNvpj8Hm/Rj81YiEIhd/WL/9sPLnjTv5rDoIgGmNdodgVU5NAB4TNUG8zsNQfzGT7BeFui+RmYqQ+pEJRA9v5JqI5kv06RU8Sh1ubjpo4VW771HncTIWPOpJGLPQrPLMgrekBF5w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6512007)(5660300002)(86362001)(558084003)(8936002)(66476007)(66556008)(9686003)(6666004)(4326008)(66946007)(33716001)(85182001)(2906002)(316002)(6486002)(508600001)(8676002)(82960400001)(83380400001)(38100700002)(6916009)(186003)(6506007)(26005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cU8wRzBYbnlGalNERGtEakdpWnEvK3I4VFF4RjdMeGc0RWZRT1JXd3ZjQ3A3?=
 =?utf-8?B?SHZ5S1huL2R3a2UyekRJZldvUUJNSEwrRXR5Wnp2YlEvUFcyK0FleitrVEUr?=
 =?utf-8?B?OXN3cmJYM1ZnaURCbjZGemhpb2wxSWM5YnBWU2hVNVQxblN2aXpBK0JEVmRm?=
 =?utf-8?B?bEtvMGZSSWg1Si81T25YcnVEdVpiK1BUTGRJY1RHSG0yUDNwSlhKUEtUUk9h?=
 =?utf-8?B?UUhQaUNOcy96ZndzY1BtaUZZN3BYMXFGaVhVd1lZRE8vZGdGQ0cxTEhOUWRW?=
 =?utf-8?B?RSsvYUZoR05WTWo2ZjV2U3NFdTFMNnI3NFFpY3JwVldvV2FSQ1dIamIyMXhB?=
 =?utf-8?B?L3dweHI1RlB2eFpYNExuUEwrWFk5eStvdFl3OE01RzFIdzQ5YzZUSGpHcFFY?=
 =?utf-8?B?b1hSay9JdkdUWkxLWEptL1JhQmpNQ2Z1bG5aRmRiU1NEWVRrR2pyTGJyOHBm?=
 =?utf-8?B?ODdYaG5nZ01NRkRSd1ZuK01FVlBRQTNFNktHRkJDb1ZpOXhhSU9TZGIrZmx2?=
 =?utf-8?B?QnlMSWFrQkxKVEJFQ1lsTXJHaHFnbnoySUgzR0tUK2NhOWtxYjA1V08weG1y?=
 =?utf-8?B?TXdqT2REa1ZGbzkwNjYrL0lZTGdLRFZVQ1M3OFVRdDFFYzU2L3U0MUNhZG52?=
 =?utf-8?B?ZFhwbXFSRGlyWDMzT2NiVjROTktqWXZXaUt4NEVLYlZGdFZFS3Z0V2RsUFg5?=
 =?utf-8?B?WDBkMGlaSWFVRHFwdU1LSUJQZm1NUjNweXB1ZzV4WTVEN204VDBYdy9vWnE0?=
 =?utf-8?B?TjFwbnZjeng1VkFjK1NQZysvcmF1RTRTaGRka1dyNGp1SWFTTnlQd1dUdGJS?=
 =?utf-8?B?YWtiNGdpUmx1M0l2N3FsNTl5Vi9zL1JYeitqS3BDOTdPVGE4emprSStvWHAx?=
 =?utf-8?B?ZDRCNjNPU0pyMWVOOEEycmRXZUV6bnZGVUsydHRaY1U1akdsenFtVWFUeFZN?=
 =?utf-8?B?bU5hbTlnV2dwd1BidWQ4Vnl1cVNqT1BSNUtuR0k4ZjBOb1BEa1luV3l2WklR?=
 =?utf-8?B?T3hWSlJBOFdaUnNYcEZzYUx5QmZad0UzalRPU1psSm82YVlsbTF2L3IyWDZT?=
 =?utf-8?B?Z1NHTU8zdWFWL0QrRFgrYTlVc2Zhbkhrclcxb0ZhVGIvVnFoZGdYdmtMZmlx?=
 =?utf-8?B?aC9mRFJkZWR1a2xJTWE2czd1MGJaUzhCeDFTekJYeFA3dlFlYmVGODRQQlFU?=
 =?utf-8?B?UHhjQnVlWTYxbG92RVQ2UC9UYStXVXBSRXJxdGplTWg0MlJRTk9QWlBEalF0?=
 =?utf-8?B?S1UwRUdiZVNQS3NjMGpLWHN6c1FiWTBLc2lEa2lZZnp0dUNZM1IrVC84VTky?=
 =?utf-8?B?aVJZSUpGNUZYbjRiWHZHTVh1bUVIRmxSeVUwKzBWZWxnNU9GMzZFUGcvSjJk?=
 =?utf-8?B?OEl1L1RaOEZibGJpcVR5Q3Znc3JiQzZ3UEdxSFl2RHZIWm81MjlESzQ1Y2FC?=
 =?utf-8?B?OGE3THpkTGlJWkxJckNOV3Exa0QwbjY3U3lXWUY3eENVVFh4b1VSL2plMnN1?=
 =?utf-8?B?cUZTUU4rQ1ZRTjhzL2xoSXR4MVVCT05VNjY1WDdUY2dSY0U0U01VcG0rTjc4?=
 =?utf-8?B?anM2d0JWb0ozU1IzcmRaVGJ4TERHYVAxWUVxTmZUN1NqazFpLytVL2RSWjRr?=
 =?utf-8?B?NlZvdnN5NjBBTXZDSTM3ZmhNcmNkY25zRWU5WGZHTS9rNjZaRmRxSXZCZDVV?=
 =?utf-8?B?dmtiV1ExTWk0dWdvd0JsYXVTcDBPVTcrM20wc2paWVAybHdpOWZQRG1CVlZt?=
 =?utf-8?B?SUtDa3lOMG0yZVlPMHA0KzNNdXpTTW5WaGNMVGxNK0xJVWNPWCtldndLZU0y?=
 =?utf-8?B?S2RPK1V3MHBiamQ4SVkrZURDdVhMcFZwU0dTS3FXeGdCbVBGelJYelJKcE1E?=
 =?utf-8?B?Zk1ndXRydU5hRHkrN2lSNzRmQWg1aU5SS3VvY1FNWkUxZ1NSMUlmTzdLTEFv?=
 =?utf-8?B?U1daUGUzUnRlR3I0cTFLZXcyYlR5ay85NDQvc3pDS202Q21MT1NwSFVvTWx0?=
 =?utf-8?B?Y1N1MzZCSVgzVHVrQnphVmVuR0hVOU9vTVBFbjZDbU1ENGJnak1ZbC9xTVU4?=
 =?utf-8?B?cTFoOVRJZVllS0JvY2NiZUJEUk5kQVJQME5Nb1J2RUExRW9kYWZXeTh1dEVl?=
 =?utf-8?B?eXZPUFdVUDFqUkY4YlFNTVh3U3NiVTk3OG5IZHkwSEkrSmpNbW1odEsycjc3?=
 =?utf-8?B?Tk95ZXI2ZlpPa0ZNTUI1YjBac3F0NnV4MTdhNEpaeC9yKytGRHRxa1UrL0ZR?=
 =?utf-8?B?QjRUQksvanVSYi9wc25Eb1NXbGFpZGx2TUN1NjMvQWZBVWNsQWdJMWNGNWYw?=
 =?utf-8?B?cVMydEJ4OW9xM09GWWFhak5sMEs2enZHZFN5dTJUUWNvbjM3Y0JWUT09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f39361c-9491-4292-eea1-08da27a3121a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 16:37:36.4972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AtHG0zhPu/R+hw5eJhUVj6XBw6R0cf1IeXntiwoTi1eakJ1cplvAMPiDSOgfBcdf0rVYVUvFBM88ImM9yhim9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6453

On Tue, Apr 26, 2022 at 10:10:37AM +0200, Steffen Einsle wrote:
> Hello,
> 
> I can confirm that "msr_relaxed = 1" solves the problem with Server 2019
> Essentials crashing.

Can you post which CPU model are you using?

A dump of the first CPU entry in /proc/cpuinfo will do.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 17:02:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 17:02:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314074.531968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njOaS-0006r0-J5; Tue, 26 Apr 2022 17:02:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314074.531968; Tue, 26 Apr 2022 17:02:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njOaS-0006qt-GI; Tue, 26 Apr 2022 17:02:52 +0000
Received: by outflank-mailman (input) for mailman id 314074;
 Tue, 26 Apr 2022 17:02:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Qz8a=VE=gmail.com=raphning@srs-se1.protection.inumbo.net>)
 id 1njOaR-0006qk-Cg
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 17:02:51 +0000
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com
 [2a00:1450:4864:20::42a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b43beedf-c582-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 19:02:50 +0200 (CEST)
Received: by mail-wr1-x42a.google.com with SMTP id s21so11654983wrb.8
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 10:02:50 -0700 (PDT)
Received: from [192.168.15.219] (54-240-197-232.amazon.com. [54.240.197.232])
 by smtp.gmail.com with ESMTPSA id
 z6-20020a1c4c06000000b00392b49c7ad4sm11609653wmf.3.2022.04.26.10.02.48
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 26 Apr 2022 10:02:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b43beedf-c582-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:to:cc:from:subject
         :content-transfer-encoding;
        bh=QgGA29WYYss0uXnrZthmQcUKUJ5ool5DKmGzaQtvt7E=;
        b=AYtMUeMpCbkxR6IZ25vCX9hRC6af9ygPQno9E7h1YG7LA5JzHwQ3EHSdP2QGJX/UqV
         u7CY6ntoATzwnoyCPdimbQjKGOcTpVCCnLCqwSwcS2QEh/CsYxBum4Qd03diD5hnUU2X
         H/4QAsyrBKPZ2OQB/Izd3/BIUE5fNACljiTH4TxqxO8BWRPecF5o+a+Wuw3z+fKVndJY
         0g320z52SUK7qZT3pYY5IE1jkKMrVF2uHdSAl17TmBmlJ+f3TAk72Arz0JtLoij5aPdI
         d7ct+zd6a9QcI5zaDK3TE16fYQRKUCK7ZXZPgGvlCQF90hbE4BmVj8KQR6DRuQHIN8ST
         0YNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:to:cc
         :from:subject:content-transfer-encoding;
        bh=QgGA29WYYss0uXnrZthmQcUKUJ5ool5DKmGzaQtvt7E=;
        b=cJvc6LMaagIhJO8VG3INX0q8hI67pqCwPYjwrAi6BNIKf60FG08xa8wy3i5QkQ1piy
         AHRh9aEGvBDre8E3Hn8mMUikz42GVYL+T3/+cuA2A9IsVTK43foUmKDwy7cuV16d1GQo
         aQESKIJqJ5Z9mxGI4IRO2xilvKgB83oHPH+NY3xdXJWNSeTDw3LwuvEByA3WzOgoJ5SU
         xkt0Pc8RwWY+F/m2fet5s2v0Nk8M1hK3OvCD3hndH820sGuKNJUKDGeGuOzqSHF0hgPi
         K7rGwbT77/OWqdjRmhwKbq/7tw50HSl4c0TN712bY9HwT0M15JhbSscEOcq2QThtUZxU
         Blug==
X-Gm-Message-State: AOAM533hCK2GFuzWiEXx2OeOaD+A2yCf+7PH7fX8A9moCmUvBMS9LtUv
	2coQVllesIfCKkh0rMa/mr8Ql8vnZ/wCqQ==
X-Google-Smtp-Source: ABdhPJx/FrZSa50T8fmwAMPz4mUtT5p7EdOg4Ki77fof+NAxQL5w1AiyEBK7qqQv+u3dQ1VcLWZKbQ==
X-Received: by 2002:a05:6000:1a44:b0:20a:ccde:c139 with SMTP id t4-20020a0560001a4400b0020accdec139mr16390537wry.320.1650992569536;
        Tue, 26 Apr 2022 10:02:49 -0700 (PDT)
Message-ID: <eb024e77-17f4-cc89-f621-a9d5b879c184@gmail.com>
Date: Tue, 26 Apr 2022 18:02:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
From: Raphael Ning <raphning@gmail.com>
Subject: [cxenstored] Potential bug in special watch event firing
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

While reading C xenstored code, I noticed that it may send special events like @releaseDomain to (privileged) clients that only watch the root node (/). That's probably not the intended behaviour.

For example, when firing @releaseDomain, fire_watches() is called with exact == false:

https://github.com/xen-project/xen/blob/2419a159fb943c24a6f2439604b9fdb1478fcd08/tools/xenstore/xenstored_domain.c#L234

As a result, it will check whether @releaseDomain is a child of the path being watched:

https://github.com/xen-project/xen/blob/2419a159fb943c24a6f2439604b9fdb1478fcd08/tools/xenstore/xenstored_watch.c#L195

And when the parent path is /, is_child() unconditionally returns true:

https://github.com/xen-project/xen/blob/2419a159fb943c24a6f2439604b9fdb1478fcd08/tools/xenstore/xenstored_watch.c#L66

The xenstore documentation is not clear about whether @<wspecial> should be considered children of /. But I find it counterintuitive that clients may be notified about a special event without explicitly subscribing to it. Is it a bug?


Thanks,

Raphael



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 17:27:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 17:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314080.531979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njOy7-0000oU-Ff; Tue, 26 Apr 2022 17:27:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314080.531979; Tue, 26 Apr 2022 17:27:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njOy7-0000oN-CF; Tue, 26 Apr 2022 17:27:19 +0000
Received: by outflank-mailman (input) for mailman id 314080;
 Tue, 26 Apr 2022 17:27:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njOy5-0000oD-NY; Tue, 26 Apr 2022 17:27:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njOy5-0001U6-Lq; Tue, 26 Apr 2022 17:27:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njOy5-0002pt-Ae; Tue, 26 Apr 2022 17:27:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njOy5-0003GD-AC; Tue, 26 Apr 2022 17:27:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GeXjQSIWVG1cgQjBBdl64plbl91SG9caYmlbXZQJ+kg=; b=Gc2c0no5NCPmHPfY82jMZGZmnz
	mT3v/3mZizmeV0bdLH3CTVT5ByVtwpa+pAyfS0ebOLoN0QKv9UIKOcJ7JcCX6P2sUwAkWaOZh9lLP
	4m3DtWM+JRtBczWJq6syws82LDhax9BPI+ZaEVn7aZ+KgtOmYWJeJyZmzelVcczsxvSQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169746-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169746: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 17:27:17 +0000

flight 169746 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169746/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  646 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 17:51:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 17:51:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314090.531995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njPLk-0003yc-FV; Tue, 26 Apr 2022 17:51:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314090.531995; Tue, 26 Apr 2022 17:51:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njPLk-0003yV-CX; Tue, 26 Apr 2022 17:51:44 +0000
Received: by outflank-mailman (input) for mailman id 314090;
 Tue, 26 Apr 2022 17:51:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=b/nE=VE=citrix.com=prvs=108c91f88=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njPLi-0003yP-Pg
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 17:51:43 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8584125a-c589-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 19:51:40 +0200 (CEST)
Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Apr 2022 13:51:37 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN8PR03MB4817.namprd03.prod.outlook.com (2603:10b6:408:9f::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr
 2022 17:51:33 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022
 17:51:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8584125a-c589-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1650995499;
  h=from:to:cc:subject:date:message-id:content-id:
   content-transfer-encoding:mime-version;
  bh=LZrlXuDr5SRMqD6btn73rSUnTkYmGZLru5ydx+LYhIo=;
  b=VauqNQtCOgS12Na5GSQcdxsjnAO9CPII6XScQmnY+vbg8V3e4dT9IOb/
   w3g+D2eH5CttVnhQsg0hWx/Tn7jP7BItSyuiL/kLNe3a+PPYSRd/OGueo
   f3a9/jLdz/izv3Z5j8HUaXhoa1RE3mp+7j4y+yqRWt5TFS/V+vxzLFa7/
   M=;
X-IronPort-RemoteIP: 104.47.55.177
X-IronPort-MID: 72426798
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:w1ulCayVzbwwdNBAyHh6t+cyxyrEfRIJ4+MujC+fZmUNrF6WrkUFn
 TFNWjjQa62ON2P3ctsib9/i8E8B65CAx9U2SVNtrSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024bhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpliruVQCoCN5H1yO0+UhwGFw1PO6NsweqSSZS/mZT7I0zuVVLJmq8rJmdmeIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHuOTuoAwMDQY36iiGd73Y
 cYDZCUpRxPHexBVYX8cCY4knffujX76G9FdgA3P+fBpvDmDpOB3+JrqOov0aNnQf9hYn2md/
 jjmpGKlPyhPYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWQo3OavxhaR9tZFcU77h2Azuzf5APxO4QfZjtIadhjvslmQzUvj
 wWNh4mwWmMpt6CJQ3WA8LvStSm1JSUeMW4FY2kDUBcB5N7g5oo0i3ojU+peLUJ8tfWtcRmY/
 txAhHFWa2k75SLT65iGwA==
IronPort-HdrOrdr: A9a23:FrujtKg28nzMwM1Bnko2KKuYn3BQX3l13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQZVpQRvnhP1ICRF4B8buYOCUghrREGgE1/qv/9SAIVy1ygc578
 tdmsdFebrN5DRB7PoSgzPIXOrIouP3lpxA7N22pxgCcegAUdAD0+4NMHf+LqQAfngiOXNWLv
 qhz/sCgwDlVWUcb8y9CHVAdfPEvcf3mJXvZgNDLwI76SGV5AnYqYLSIly95FMzQjlPybAt/S
 zuiAri/JiutPm911v1y3LT1ZJLg9Hso+EzRPBky/JlaQkEuDzYIbiJaIfy+AzdZ9vfr2rCpe
 O84SvI+f4DrU85MFvF+CcFkDOQqwrGo0WSs2Nwx0GT7/ARDQhKd/aoz+hiA2bkwltls9dm3K
 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DMfeEEo/gxiuKYlGchsRLYkjTVo+VY7bVHHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0WS9igF3ekHhlTVfsubDQSTDFYzjsCnv/ITRsXGRv
 fbAuMlP8Pe
X-IronPort-AV: E=Sophos;i="5.90,291,1643691600"; 
   d="scan'208";a="72426798"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AZ9wkzOOjmjv5d3wao2fkRSUw+WFEYo93PpOTfDLVBqh+JmOl9Nd+fkY1INEZ4UxReQuDLrH39qzO4P06s2HHXy1KG4FoE78xfuCzDCc3PM325QCB5BxzVpWZ28RFv/I8fHtmLSrXuLsyc+cHI8zktao07BD4GVja2qsyRHIiShOVf0ldQ52bVKc9qOCYw7EHO0iFgHJxbR/I45nwd8mnK0k2volOkrDVxOMvyqQl1jiLQEUYe2dep7Zb2oc4ZSWBcnr8xzaJDoE2fWSyhYrATk0O1cbCHxK+RvBAVLlsWk2BDxxUb8bZCQ2QdUdwwtCU/tWw6hAO2ymfMl7kBmG3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LZrlXuDr5SRMqD6btn73rSUnTkYmGZLru5ydx+LYhIo=;
 b=iWpnxLoJzy/tIYOsyjkC1JYD1SsGlg3EDw5NEuXPwqR7QQ2LTviIz7LPjpNNnmDo2eE7x/cNXJtp1Lci19gam4SadaB20ckwuFjUCJEmL9yFU8aEmAzDf7vzUJY7IYwwNWqiZerD5uDHPrGk0rLYdVZorvw+ixgPZCpMI4yrsbbfYCmNVPtAjAXoC//xH9wJ6CcqzdMki/yKY28DBAL54+wrenlxJAEpe7a+t6e25q6KzcfQ9j/87Mc1phBXhITe8Df6eT/mSwL6fPko23x5b6WwgeUQZA5dMI9Ibs9KEamzDZwMnGwIQyWiCicgOzjYoRl99Boic5z4qEiPn8WGcw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LZrlXuDr5SRMqD6btn73rSUnTkYmGZLru5ydx+LYhIo=;
 b=g8R7TYbTdZcSWbkkfxBE59Axpx+CTn+P3n5XUTySf3RGqAXMz2KdFxpLN3WdDi9Rq9UnLkKATbPj/vaWM+4fB0+rezAS32uNRJemd0wVfXcDSydwciaciXhqN7BD7lJsrrsrwLbtKS8BSrdDWU4PG4tWC3r4J4n2KdywxsQPUVE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Kevin Tian <kevin.tian@intel.com>, Edwin Torok <edvin.torok@citrix.com>
Subject: RMRRs and Phantom Functions
Thread-Topic: RMRRs and Phantom Functions
Thread-Index: AQHYWZZDIrEkmq9fL0+3qLNT2+7QyA==
Date: Tue, 26 Apr 2022 17:51:32 +0000
Message-ID: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: de86fec3-cff5-455c-1e5a-08da27ad6658
x-ms-traffictypediagnostic: BN8PR03MB4817:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs:
 <BN8PR03MB4817D17190CF730762912A69BAFB9@BN8PR03MB4817.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 UmQLoCLVzY43GOTSZu1Rd/gFaBfupjkj22JsfUwr7I/Z7XgRWLQu90ILFlaJ30gQkWvN9fRnRPNaChFekCjIGV008EzwRNvEgxfM/5cdU2N6UFJh8eSTpxs4E0TGXfsyZl3C7st0fpNDPaHYxVVI87EXNtHSawBc+kpOmqvrN4jbaWU24/QqxATfndc6E0dEVFdqVSe53BSyOpDB4SmKytZe0Pg7N+YduKAcznnkJihxQLo4lwP84BfjjLlIVzBvPUgjAj59f5cOS0dSEpt5afaUJIwRe2vgBmE6tE2Rs+zEoND02TwaF0G6Lat0G5RMuZiOV0mO7UUAuhJDbspRufmOZzyeayUC/Gl5a36igaHa2IQ/J9Vz25/emnDUHTG2ZTq2SYanztBdpJemIzBuk1KsfRLiaTdV4CLjVb+vK0i6EdwnOYomZT5Pm/cKBm4Bs+zuGQ25/AcCHXB/kxtqxg9ZdjHzfq95ayOic3ceS8QIIIlVtfbcHEMMZ8yDOTPulpiKhUIn+mw8Ni5Cz4/W+y7WPx7hdT2J6ECkiawe2I671Qoh0J3VkIkhGhaRciw3b8M/RUCcndg9yKdzyfpUZPo+CwAVbO0/AjWAEjnifZG82X4uS4XD4X4h1RcEbgtxy3oWr9l+lGg9JBNsjLFHlJtIOKTY+1d5o/ZIThxgM/D6lfQcdw2XLLWIWu9vNpTlXuivb7qeMMWguTCWDgUmAPbsNR7nVYVUtSAYvTp+rbeAi6Ot6RBKJDgm/nXPHfzT2HDlKys8xmXnrjlROceGTg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(38100700002)(3480700007)(26005)(86362001)(6512007)(71200400001)(82960400001)(31696002)(6916009)(316002)(8936002)(54906003)(91956017)(8676002)(2906002)(66946007)(66476007)(76116006)(66446008)(4326008)(64756008)(508600001)(66556008)(6506007)(5660300002)(6486002)(36756003)(2616005)(186003)(83380400001)(107886003)(31686004)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?cHNWYm9OZW41Ujhadk82ZHFRclNYRlBDaVhmYklONzA1TGpGYUFlNXNuZDgy?=
 =?utf-8?B?R2hOSTlpclMxaHgxMmtjTlFZL09BVExpa1pkL0F2Mi8rSm95NDdYYzN2NEdP?=
 =?utf-8?B?NGR6eU9jdnZ3Z3BUSk1iNEJsZWRUWDZtd3dlTlZKZFJOcnFpeDZYRjNEWWpJ?=
 =?utf-8?B?VGcyODBvb3h2QS9Bb0tHZXV3eC8rcmtZelRzTjBKeG4rN3NtbDBKRnp3UkZG?=
 =?utf-8?B?SmpNaitibERHeU4zQzdLQkkxKytHL0dpanlBbHhPWHJCeS9vV0tyaVMzNWU0?=
 =?utf-8?B?bXB0UHZvZVd0WHFOSjJCU2wvV2h6RUFXS1k2OEo2OEhMZzBHUE8xVnRXZE1t?=
 =?utf-8?B?ZzlBWExyU0RzbmJhSnh5YnZlMlo4cURvWUFyWlpVempaRjRsZFo0bTR5T25P?=
 =?utf-8?B?aVBoUk1Wd1Zid0lDNnZXeFRYeno0K0hNdzA1dkRiSHZOcFFkTkwrdGlKSVU2?=
 =?utf-8?B?VllhQXZYa1gxa29UVENWODEzM1Z2YnBoOFJxMENXVHhaRnlyRVp5aUdlbTJN?=
 =?utf-8?B?aFF2MVFpWTlNWVpwWmZLOXl4SFFsbFdWRGhQejJBM2preWNacCtLeG1zeFRN?=
 =?utf-8?B?QW5aTTl0NXlPV2o3T2RGclZTZy9QVk5YVUJqSnY1TlF2VGMzVE5HQ2FLNzRr?=
 =?utf-8?B?ZmZiN1NPRmJLN1ovTTVabzZjL1BmeXhZZEFNYldEVkRMcEZkMnZIWFEzK2Zk?=
 =?utf-8?B?TXhjRlFncE9ucjYzNnMwUkUrSFFpNmdEOEI5UVpJNVE0encwbThwN0R4MUN3?=
 =?utf-8?B?VkJpUkN2eU5tdnhvN3I0cld2NDY4OGFLSjRtTHVJa2dZY2dXeXJyeG5XT2RJ?=
 =?utf-8?B?UnkzSlU0NTJPT1BrNUpGZ2RDRStDZkJUdXI0Ymp5dXpWMTZWOG5Delc0Smtk?=
 =?utf-8?B?Z0lDMUFsOG0zRCtvK2VmT1dJSDd5ZXExZmpVWlRjMUFCeVl3VUxadW55ZGRy?=
 =?utf-8?B?MGkyWHg2UUlVTVdWYXovcjcxTzh1dnM5OVNvMzA4bXlPd0dnSnREcnpkZm5J?=
 =?utf-8?B?U1JpUnd0cFVaZXBleTFuMGJ0ZTJhdG0valVseVNyTWxrRE80ZnRFOHRKMGFk?=
 =?utf-8?B?M3VmUVpNSGkxYmpCUjVmNmhjZUVHNjFhaERpQkhUZmgyK1VqS3BPdTJJNGNK?=
 =?utf-8?B?ZXNINW5oQ3l3ZkRGaUFiakozT1RCazduTmdicTAzTlBTQ1FhYXJKMGJUN0F2?=
 =?utf-8?B?T3FMTmVUZXkvcVdIZ2dRdytzS0RhQnJFK1RiL0xqeFkvTUlwa2ZreC9GaEpJ?=
 =?utf-8?B?SUdQMTBwR29jblZoNkcweXgvTy9RTHYvcDlHd3JPRGFlYjZJRWZQUE5va055?=
 =?utf-8?B?VFU5WG1oc0tPeUxRRS9PT1plVE9UWmcxYlkxNjgyVHl4Z1hDeG9jbVFUZC9I?=
 =?utf-8?B?cC85OEJlMjJuVzNJMzNBZDd3Tm9wRENCMGJ6TXArRTJscm9NVEd4VXV5RlVm?=
 =?utf-8?B?SEh6eDRTdjRHQ0w1d2x2NWxKajB5TjRlazhWbWlGZUFFWlFUdnFjZGJYampY?=
 =?utf-8?B?dkNUTDJHRnc5bkVyRHVCSzQ1NGUvamI2ZmJZR2FiNDZjNW1FSlZ0QnZpUy9n?=
 =?utf-8?B?dGRHNEFXdXpvcFR2Q3I3a0k5OW1WbDE2aUJucGdQV2NvdVVVbnR6bTJhQkZI?=
 =?utf-8?B?MjJ3VHBKL1M0RFNxdCtEQmNnVDhLS1kzdytIM1lmRVhuR0pqUThnTG1SeFdP?=
 =?utf-8?B?eVEwZnNvVElpWmc3YTF6ZndKSnJ2d1dwZDk0U2xaZ0ZKNlBLdkI5TmFkVlIr?=
 =?utf-8?B?bDFsWEdPb0ovNE91MnlXSFQyc3FsWDdzYVc3RXVDZmIwL2t1OEtmUXRrbHd6?=
 =?utf-8?B?VlFOYUNGZ3dTTWhVdXpWeVdEeXlGaFJaWkIxTVQzN1VkYkxtLzZNQkNqRjVs?=
 =?utf-8?B?bzFKcldGcGFlalhiQkhtL1huMmVVQUwvdWNPQkh1bmdJQTdXaUYxZ296cmlI?=
 =?utf-8?B?S2ZFTllWbGZvUjZ1RGtIb2hXajRxWUo5Qlpvbk5IOVVpWUU5N3JaaXA2MzRP?=
 =?utf-8?B?bUk2QXNaQTNBak84dE9FdnNaYWptdG9NSFAyR00yK2RvSWpGcmp0elpLZGtD?=
 =?utf-8?B?LzR2ZUh0eWJaQk5PcFNZS2Rld3hxb2ZZRkJNeFBYaVorQzJJWVFBS1Mvb0w3?=
 =?utf-8?B?VElrSHJkMERlRU0vYmZWdE5HWkRVMDVYb0pLTEhEQ01aUm50UEFkbldwN3hK?=
 =?utf-8?B?SGx2R3VtWW5lVjJNWUhsck1FbXEwa2lkbCsrVVkxbXRiMllCMlgycnFTa0FI?=
 =?utf-8?B?ZCtvczh2TGF4Q3EzaVg5eDBUZmxFMWEwdWhqRTZFdjZKNWFMOTNnaUpZUGpC?=
 =?utf-8?B?bzhhbjQ5M3dzbGowU1VVN0ZLREZlVmkzeXB4RlRNUjNESDJWZG1JTFRTSDE2?=
 =?utf-8?Q?c3X6NQ/o718HZ+sQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2E18A4C9D1DE2C43A3F90840146AB3F9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de86fec3-cff5-455c-1e5a-08da27ad6658
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 17:51:32.5754
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Eu8jzzgrxltl48ivJIwtEmxuq9Dyu33U6posPZX9y8HG5msn8lBTZIRHu4l+wLqpr6yPSn1le6Y64iwhvAzE+14iC5hrnja1c0BZjrZcx20=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4817

SGVsbG8sDQoNCkVkdmluIGhhcyBmb3VuZCBhIG1hY2hpbmUgd2l0aCBzb21lIHZlcnkgd2VpcmQg
cHJvcGVydGllcy7CoCBJdCBpcyBhbiBIUA0KUHJvTGlhbnQgQkw0NjBjIEdlbjggd2l0aDoNCg0K
wqBcLVswMDAwOjAwXS0rLTAwLjDCoCBJbnRlbCBDb3Jwb3JhdGlvbiBYZW9uIEU1L0NvcmUgaTcg
RE1JMg0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICstMDEuMC1bMTFdLS0NCsKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCArLTAxLjEtWzAyXS0tDQrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKy0w
Mi4wLVswNF0tLSstMDAuMMKgIEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2IgTklD
DQooYmUzKQ0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
ICstMDAuMcKgIEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2IgTklDDQooYmUzKQ0K
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICstMDAuMsKg
IEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2INCmlTQ1NJIEluaXRpYXRvciAoYmUz
KQ0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwtMDAu
M8KgIEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2INCmlTQ1NJIEluaXRpYXRvciAo
YmUzKQ0KDQp5ZXQgYWxsIDQgb3RoZXIgZnVuY3Rpb25zIG9uIHRoZSBkZXZpY2UgcGVyaW9kaWNh
bGx5IGhpdCBJT01NVSBmYXVsdHMNCih+b25jZSBldmVyeSA1IG1pbnMsIHNvIGRlZmluaXRlbHkg
c3RhdHMpLg0KDQooWEVOKSBbVlQtRF1ETUFSOltETUEgV3JpdGVdIFJlcXVlc3QgZGV2aWNlIFsw
MDAwOjA0OjAwLjRdIGZhdWx0IGFkZHINCmJkZjgwMDAwDQooWEVOKSBbVlQtRF1ETUFSOltETUEg
V3JpdGVdIFJlcXVlc3QgZGV2aWNlIFswMDAwOjA0OjAwLjVdIGZhdWx0IGFkZHINCmJkZjgwMDAw
DQooWEVOKSBbVlQtRF1ETUFSOltETUEgV3JpdGVdIFJlcXVlc3QgZGV2aWNlIFswMDAwOjA0OjAw
LjZdIGZhdWx0IGFkZHINCmJkZjgwMDAwDQooWEVOKSBbVlQtRF1ETUFSOltETUEgV3JpdGVdIFJl
cXVlc3QgZGV2aWNlIFswMDAwOjA0OjAwLjddIGZhdWx0IGFkZHINCmJkZjgwMDAwDQoNClRoZXJl
IGFyZSBzZXZlcmFsIFJNUlJzIGNvdmVyaW5nIHRoZSB0aGVzZSBkZXZpY2VzLCB3aXRoOg0KDQoo
WEVOKSBbVlQtRF1mb3VuZCBBQ1BJX0RNQVJfUk1SUjoNCihYRU4pIFtWVC1EXSBlbmRwb2ludDog
MDAwMDowMzowMC4wDQooWEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDE6MDAuMA0KKFhFTikg
W1ZULURdIGVuZHBvaW50OiAwMDAwOjAxOjAwLjINCihYRU4pIFtWVC1EXSBlbmRwb2ludDogMDAw
MDowNDowMC4wDQooWEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDQ6MDAuMQ0KKFhFTikgW1ZU
LURdIGVuZHBvaW50OiAwMDAwOjA0OjAwLjINCihYRU4pIFtWVC1EXSBlbmRwb2ludDogMDAwMDow
NDowMC4zDQooWEVOKSBbVlQtRF1kbWFyLmM6NjA4OsKgwqAgUk1SUiByZWdpb246IGJhc2VfYWRk
ciBiZGY4ZjAwMCBlbmRfYWRkciBiZGY5MmZmZg0KDQpiZWluZyB0aGUgb25lIHJlbGV2YW50IHRv
IHRoZXNlIGZhdWx0cy7CoCBJJ3ZlIG5vdCBtYW51YWxseSBkZWNvZGVkIHRoZQ0KRE1BUiB0YWJs
ZSBiZWNhdXNlIGRldmljZSBwYXRocyBhcmUgaG9ycmlibGUgdG8gZm9sbG93IGJ1dCB0aGVyZSBh
cmUgYXQNCmxlYXN0IHRoZSBjb3JyZWN0IG51bWJlciBvZiBlbmRwb2ludHMuwqAgVGhlIGZ1bmN0
aW9ucyBhbGwgaGF2ZSBTUi1JT1YNCihkaXNhYmxlZCkgYW5kIEFSSSAoZW5hYmxlZCkuwqAgTm9u
ZSBoYXZlIGFueSBQaGFudG9tIGZ1bmN0aW9ucyBkZXNjcmliZWQuDQoNClNwZWNpZnlpbmcgcGNp
LXBoYW50b209MDQ6MDAsMSBkb2VzIGFwcGVhciB0byB3b3JrIGFyb3VuZCB0aGUgZmF1bHRzLA0K
YnV0IGl0J3Mgbm90IHJpZ2h0LCBiZWNhdXNlIGZ1bmN0aW9ucyAxIHRocnUgMyBhcmVuJ3QgYWN0
dWFsbHkgcGhhbnRvbS4NCg0KQWxzbywgSSBkb24ndCBzZWUgYW55IGxvZ2ljIHdoaWNoIGFjdHVh
bGx5IHdpcmVzIHVwIHBoYW50b20gZnVuY3Rpb25zDQpsaWtlIHRoaXMgdG8gc2hhcmUgUk1SUnMv
SVZNRHMgaW4gSU8gY29udGV4dHMuwqAgVGhlIGZhdWx0cyBvbmx5DQpkaXNhcHBlYXIgYXMgYSBz
aWRlIGVmZmVjdCBvZiAwNDowMC4wIGFuZCAwNDowMC40IGJlaW5nIGluIGRvbTAsIGFzIGZhcg0K
YXMgSSBjYW4gdGVsbC4NCg0KU2ltcGx5IGdpdmluZyB0aGUgUk1SUiB2aWEgcm1ycj0gZG9lc24n
dCB3b3JrIChwcmVzdW1hYmx5IGJlY2F1c2Ugb2Ygbm8NCnBhdGNoaW5nIGFjdHVhbCBkZXZpY2Vz
LCBidXQgdGhlcmUncyBubyB3YXJuaW5nKSwgYnV0IGl0IGZlZWxzIGFzIGlmIGl0DQpvdWdodCB0
by4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 18:42:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 18:42:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314099.532012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njQ8Q-0000dv-BK; Tue, 26 Apr 2022 18:42:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314099.532012; Tue, 26 Apr 2022 18:42:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njQ8Q-0000do-85; Tue, 26 Apr 2022 18:42:02 +0000
Received: by outflank-mailman (input) for mailman id 314099;
 Tue, 26 Apr 2022 18:42:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njQ8O-0000de-9R; Tue, 26 Apr 2022 18:42:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njQ8O-0002oG-7b; Tue, 26 Apr 2022 18:42:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njQ8N-0005bh-Sm; Tue, 26 Apr 2022 18:41:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njQ8N-000588-SM; Tue, 26 Apr 2022 18:41:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oQVwKcqZ7+3M0ZtPPC5QV5VodKNxc1KAU98sAYRNB/k=; b=kFMRNAaskuUJIQt2So44S+BgNK
	G3DUz9vKTilhceB0EFK+3r+wxiF5EetvckbLSp6dYujCqL1srfRSm0MTqguzbFNBgRMo2EZIsITn5
	ar/T+eEj9pa0L7NSiIVhcR9A1B/iZA/TuvxCEDaJC1N+PgaBVxK4+VjxDpaVCsG5ax2g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169750-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169750: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 18:41:59 +0000

flight 169750 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169750/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  647 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 18:54:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 18:54:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314108.532023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njQKb-0002BZ-HX; Tue, 26 Apr 2022 18:54:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314108.532023; Tue, 26 Apr 2022 18:54:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njQKb-0002BS-EO; Tue, 26 Apr 2022 18:54:37 +0000
Received: by outflank-mailman (input) for mailman id 314108;
 Tue, 26 Apr 2022 18:54:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1SWQ=VE=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1njQKa-0002BM-PK
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 18:54:37 +0000
Received: from MTA-05-3.privateemail.com (mta-05-3.privateemail.com
 [68.65.122.15]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f278be4-c592-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 20:54:34 +0200 (CEST)
Received: from mta-05.privateemail.com (localhost [127.0.0.1])
 by mta-05.privateemail.com (Postfix) with ESMTP id 00FD718000A6
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 14:54:32 -0400 (EDT)
Received: from mail-oi1-f182.google.com (unknown [10.20.151.196])
 by mta-05.privateemail.com (Postfix) with ESMTPA id D0CC118000A3
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 14:54:31 -0400 (EDT)
Received: by mail-oi1-f182.google.com with SMTP id l203so10859026oif.0
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 11:54:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f278be4-c592-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1650999271;
	bh=CnnrZw9uJI8shnn+j2DekIUDtB6mwGNt/vYlFhVvNQY=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=GCPpruVD7AxgpyIDivEJim6d0e9jXG5qpUOxARuzL/06arHlJ5DmYqjuDiqZec0Go
	 ORt7jbwR2CR5WOOrQxuyW/K7hW2dWBVHYSTBgnBMENnf59l4MR9tewZz8c99dqpyVN
	 MnLp4bdMTTPzQcfHjAjsFxzq20eJ+Wzy4A+OJGaVdHiZWkA0YPy7ulbvjXszaIhBZf
	 eTh3UoQm1ym124FJSdovi2lseVoUSFAZf71FM2GLimWFLaHCMwIqKZ4uVn96qKACe8
	 5B9WXravhICbmO+jrnCraQMylIKgwYaW7VidHaUTyTINtzWSh4ArtLQ8WsT+az2CGu
	 e4zDpKeCTeQiA==
X-Gm-Message-State: AOAM533a+j7TCkE2zKKVfxDiuTxDM2eqv67OWQaGbcmC8FiX2rZgFRso
	vJXSQqNsP/H3848uTHuq6aWqxWtdk8iVh2i7pLI=
X-Google-Smtp-Source: ABdhPJyv7kIrcm8hh0lA36fEL4EFv0nNvAy3Y12YdQz2U6WgP+QvTqjh6ycodRMAnT1QhsrfCAVviuW7c+Z7gtXDUnU=
X-Received: by 2002:a05:6808:302b:b0:2f9:eeef:f03 with SMTP id
 ay43-20020a056808302b00b002f9eeef0f03mr16070669oib.128.1650999270942; Tue, 26
 Apr 2022 11:54:30 -0700 (PDT)
MIME-Version: 1.0
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
 <YmazAdHL4LWOdDDv@Air-de-Roger> <CABfawh=Z1_88p14ivkqrBAUKbfw39f-frXN9uNsdVt9BDp+4bA@mail.gmail.com>
 <YmeyDRYcwfgg7mwC@Air-de-Roger>
In-Reply-To: <YmeyDRYcwfgg7mwC@Air-de-Roger>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Tue, 26 Apr 2022 14:53:54 -0400
X-Gmail-Original-Message-ID: <CABfawh=gb0_oyjqq9DwioaVZfnrkbbFLJi14oyN4o5njrK9xgg@mail.gmail.com>
Message-ID: <CABfawh=gb0_oyjqq9DwioaVZfnrkbbFLJi14oyN4o5njrK9xgg@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] x86/monitor: Add new monitor event to catch all vmexits
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, xen-devel@lists.xenproject.org, 
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Alexandru Isaila <aisaila@bitdefender.com>, 
	Petre Pircalabu <ppircalabu@bitdefender.com>, Jun Nakajima <jun.nakajima@intel.com>, 
	Kevin Tian <kevin.tian@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP

On Tue, Apr 26, 2022 at 4:50 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.com>=
 wrote:
>
> On Mon, Apr 25, 2022 at 11:40:11AM -0400, Tamas K Lengyel wrote:
> > On Mon, Apr 25, 2022 at 10:41 AM Roger Pau Monn=C3=A9 <roger.pau@citrix=
.com> wrote:
> > >
> > > On Wed, Apr 13, 2022 at 09:41:52AM -0400, Tamas K Lengyel wrote:
> > > > Add monitor event that hooks the vmexit handler allowing for both s=
ync and
> > > > async monitoring of events. With async monitoring an event is place=
d on the
> > > > monitor ring for each exit and the rest of the vmexit handler resum=
es normally.
> > > > If there are additional monitor events configured those will also p=
lace their
> > > > respective events on the monitor ring.
> > > >
> > > > With the sync version an event is placed on the monitor ring but th=
e handler
> > > > does not get resumed, thus the sync version is only useful when the=
 VM is not
> > > > expected to resume normally after the vmexit. Our use-case is prima=
rily with
> > > > the sync version with VM forks where the fork gets reset after sync=
 vmexit
> > > > event, thus the rest of the vmexit handler can be safely skipped. T=
his is
> > > > very useful when we want to avoid Xen crashing the VM under any cir=
cumstance,
> > > > for example during fuzzing. Collecting all vmexit information regar=
dless of
> > > > the root cause makes it easier to reason about the state of the VM =
on the
> > > > monitor side, hence we opt to receive all events, even for external=
 interrupt
> > > > and NMI exits and let the monitor agent decide how to proceed.
> > > >
> > > > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> > > > ---
> > > > v4: Minor tweaks and more verbose patch description.
> > > >
> > > > Note: making the sync version resume-friendly is specifically out-o=
f-scope as
> > > > it would require significant rearrangement of the vmexit handler. A=
s this
> > > > feature is not required for our use-case we opt for the version tha=
t minimizes
> > > > impact on the existing code.
> > > > ---
> > > >  tools/include/xenctrl.h                |  2 ++
> > > >  tools/libs/ctrl/xc_monitor.c           | 15 +++++++++++++++
> > > >  xen/arch/x86/hvm/monitor.c             | 18 ++++++++++++++++++
> > > >  xen/arch/x86/hvm/vmx/vmx.c             | 12 ++++++++++++
> > > >  xen/arch/x86/include/asm/domain.h      |  2 ++
> > > >  xen/arch/x86/include/asm/hvm/monitor.h |  2 ++
> > > >  xen/arch/x86/include/asm/monitor.h     |  3 ++-
> > > >  xen/arch/x86/monitor.c                 | 14 ++++++++++++++
> > > >  xen/include/public/domctl.h            |  6 ++++++
> > > >  xen/include/public/vm_event.h          |  8 ++++++++
> > > >  10 files changed, 81 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> > > > index 1b089a2c02..159eaac050 100644
> > > > --- a/tools/include/xenctrl.h
> > > > +++ b/tools/include/xenctrl.h
> > > > @@ -2096,6 +2096,8 @@ int xc_monitor_privileged_call(xc_interface *=
xch, uint32_t domain_id,
> > > >                                 bool enable);
> > > >  int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t doma=
in_id,
> > > >                                    bool enable);
> > > > +int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool =
enable,
> > > > +                      bool sync);
> > > >  /**
> > > >   * This function enables / disables emulation for each REP for a
> > > >   * REP-compatible instruction.
> > > > diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_moni=
tor.c
> > > > index 4ac823e775..c5fa62ff30 100644
> > > > --- a/tools/libs/ctrl/xc_monitor.c
> > > > +++ b/tools/libs/ctrl/xc_monitor.c
> > > > @@ -246,6 +246,21 @@ int xc_monitor_emul_unimplemented(xc_interface=
 *xch, uint32_t domain_id,
> > > >      return do_domctl(xch, &domctl);
> > > >  }
> > > >
> > > > +int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool =
enable,
> > > > +                      bool sync)
> > > > +{
> > > > +    DECLARE_DOMCTL;
> > > > +
> > > > +    domctl.cmd =3D XEN_DOMCTL_monitor_op;
> > > > +    domctl.domain =3D domain_id;
> > > > +    domctl.u.monitor_op.op =3D enable ? XEN_DOMCTL_MONITOR_OP_ENAB=
LE
> > > > +                                    : XEN_DOMCTL_MONITOR_OP_DISABL=
E;
> > > > +    domctl.u.monitor_op.event =3D XEN_DOMCTL_MONITOR_EVENT_VMEXIT;
> > > > +    domctl.u.monitor_op.u.vmexit.sync =3D sync;
> > > > +
> > > > +    return do_domctl(xch, &domctl);
> > > > +}
> > > > +
> > > >  /*
> > > >   * Local variables:
> > > >   * mode: C
> > > > diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.=
c
> > > > index b44a1e1dfe..64a38e8fa7 100644
> > > > --- a/xen/arch/x86/hvm/monitor.c
> > > > +++ b/xen/arch/x86/hvm/monitor.c
> > > > @@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, =
gfn_t gfn, uint32_t pfec,
> > > >      return monitor_traps(curr, true, &req) >=3D 0;
> > > >  }
> > > >
> > > > +int hvm_monitor_vmexit(unsigned long exit_reason,
> > > > +                       unsigned long exit_qualification)
> > >
> > > Should this maybe live in vmx code or have 'vmx' in the name
> > > somewhere, so that if an svm counterpart is added this doesn't need t=
o
> > > be renamed?
> >
> > I don't follow. Why would this need to be renamed? I would presume the
> > same function would be used on both if it comes to that, perhaps with
> > a unified input structure if the two are not compatible as-is. In any
> > case, there is no vm_event/monitor support for AMD at all (not just
> > for this particular event type) and no plans on adding it any time
> > soon so IMHO we should cross that bridge when and if that becomes
> > necessary.
>
> SVM has at least 3 fields related to vmexit information AFAICT:
> exitcode, exitinfo1 and exitinfo2.
>
> Instead of having an union in hvm_monitor_vmexit to cover all possible
> vendor formats it might be easier to just have vmx_ and svm_ specific
> functions, so it's contained in vendor specific code.
>
> Or maybe that would be worse because you would have to expose a lot of
> vm_event logic to vendor specific code in order to put the request on
> the ring?

I would say it would be worse, I rather not have this code be littered
all over the place unless it must be.

>
> > >
> > > > +{
> > > > +    struct vcpu *curr =3D current;
> > > > +    struct arch_domain *ad =3D &curr->domain->arch;
> > > > +    vm_event_request_t req =3D {};
> > > > +
> > > > +    ASSERT(ad->monitor.vmexit_enabled);
> > > > +
> > > > +    req.reason =3D VM_EVENT_REASON_VMEXIT;
> > > > +    req.u.vmexit.reason =3D exit_reason;
> > > > +    req.u.vmexit.qualification =3D exit_qualification;
> > >
> > > You could set those fields at definition.
> >
> > Sure, but this is the established style throughout the file.
> >
> > > > +
> > > > +    set_npt_base(curr, &req);
> > > > +
> > > > +    return monitor_traps(curr, ad->monitor.vmexit_sync, &req);
> > > > +}
> > > > +
> > > >  /*
> > > >   * Local variables:
> > > >   * mode: C
> > > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.=
c
> > > > index c075370f64..2794db46f9 100644
> > > > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > > > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > > > @@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs=
 *regs)
> > > >          }
> > > >      }
> > > >
> > > > +    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
> > > > +    {
> > > > +        int rc;
> > > > +
> > > > +        __vmread(EXIT_QUALIFICATION, &exit_qualification);
> > > > +        rc =3D hvm_monitor_vmexit(exit_reason, exit_qualification)=
;
> > > > +        if ( rc < 0 )
> > > > +            goto exit_and_crash;
> > > > +        if ( rc )
> > > > +            return;
> > > > +    }
> > >
> > > Just for my understanding, is there any reason to not do this before
> > > updating the altp2m?  AFAICT the update of the active EPTP won't
> > > affect the call to hvm_monitor_vmexit.
> >
> > The currently active altp2m information is included in the vm_event
> > that will be sent out, so it is good to have the correct info for it.
> > I don't currently plan on using altp2m with this particular even type
> > but we should make sure it doesn't send out stale info in case someone
> > wants to use it differently. Certainly no point in sending the event
> > before it as the exit condition in the altp2m update blob is really
> > just dead code and can't actually be reached.
>
> Ack, thanks for the explanation.
>
> > >
> > > > +
> > > >      /* XXX: This looks ugly, but we need a mechanism to ensure
> > > >       * any pending vmresume has really happened
> > > >       */
> > > > diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/inclu=
de/asm/domain.h
> > > > index e62e109598..855db352c0 100644
> > > > --- a/xen/arch/x86/include/asm/domain.h
> > > > +++ b/xen/arch/x86/include/asm/domain.h
> > > > @@ -430,6 +430,8 @@ struct arch_domain
> > > >           */
> > > >          unsigned int inguest_pagefault_disabled                   =
         : 1;
> > > >          unsigned int control_register_values                      =
         : 1;
> > > > +        unsigned int vmexit_enabled                               =
         : 1;
> > > > +        unsigned int vmexit_sync                                  =
         : 1;
> > > >          struct monitor_msr_bitmap *msr_bitmap;
> > > >          uint64_t write_ctrlreg_mask[4];
> > > >      } monitor;
> > > > diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/=
include/asm/hvm/monitor.h
> > > > index a75cd8545c..639f6dfa37 100644
> > > > --- a/xen/arch/x86/include/asm/hvm/monitor.h
> > > > +++ b/xen/arch/x86/include/asm/hvm/monitor.h
> > > > @@ -51,6 +51,8 @@ bool hvm_monitor_emul_unimplemented(void);
> > > >
> > > >  bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t =
pfec,
> > > >                             uint16_t kind);
> > > > +int hvm_monitor_vmexit(unsigned long exit_reason,
> > > > +                       unsigned long exit_qualification);
> > > >
> > > >  #endif /* __ASM_X86_HVM_MONITOR_H__ */
> > > >
> > > > diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/incl=
ude/asm/monitor.h
> > > > index 01c6d63bb9..d8d54c5f23 100644
> > > > --- a/xen/arch/x86/include/asm/monitor.h
> > > > +++ b/xen/arch/x86/include/asm/monitor.h
> > > > @@ -89,7 +89,8 @@ static inline uint32_t arch_monitor_get_capabilit=
ies(struct domain *d)
> > > >                      (1U << XEN_DOMCTL_MONITOR_EVENT_DEBUG_EXCEPTIO=
N) |
> > > >                      (1U << XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG)=
 |
> > > >                      (1U << XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEME=
NTED) |
> > > > -                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFA=
ULT));
> > > > +                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFA=
ULT) |
> > > > +                    (1U << XEN_DOMCTL_MONITOR_EVENT_VMEXIT));
> > > >
> > > >      if ( hvm_is_singlestep_supported() )
> > > >          capabilities |=3D (1U << XEN_DOMCTL_MONITOR_EVENT_SINGLEST=
EP);
> > > > diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
> > > > index 3079726a8b..30ca71432c 100644
> > > > --- a/xen/arch/x86/monitor.c
> > > > +++ b/xen/arch/x86/monitor.c
> > > > @@ -332,6 +332,20 @@ int arch_monitor_domctl_event(struct domain *d=
,
> > > >          break;
> > > >      }
> > > >
> > > > +    case XEN_DOMCTL_MONITOR_EVENT_VMEXIT:
> > > > +    {
> > > > +        bool old_status =3D ad->monitor.vmexit_enabled;
> > > > +
> > > > +        if ( unlikely(old_status =3D=3D requested_status) )
> > > > +            return -EEXIST;
> > >
> > > What about if the requested status is the same as the current one, bu=
t
> > > vmexit sync is not?
> >
> > You need to clear the currently registered event first, then register
> > the new one.
> >
> > > IOW, I'm not sure this check is helpful, and you could likely avoid
> > > the old_status local variable.
> >
> > It is helpful on the callee side. Usually the callee needs to keep
> > track of the state of what events are enabled so that it can clean up
> > after itself and if it ever runs into trying to set the event to
> > something it's already set to then that indicates its state being
> > out-of-sync.
>
> Hm, right.  I wonder if you should also check that the ring is empty
> before changing the status?  So that the callee doesn't change the
> status while requests are still pending on the ring from the previous
> type?

No, that becomes tricky because really the only way to ensure the ring
remains empty from the userspace is to pause the domain, which is very
heavy handed. There is nothing wrong with asking Xen not to produce
more of a certain type of request while still being able to handle the
ones that are already on the ring. For setups where the two should
happen at the same time is where the toolstack first pauses the
domain, clears the ring, then disables the event. Both are valid
approaches.

>
> > >
> > > > +
> > > > +        domain_pause(d);
> > > > +        ad->monitor.vmexit_enabled =3D requested_status;
> > > > +        ad->monitor.vmexit_sync =3D mop->u.vmexit.sync;
> > > > +        domain_unpause(d);
> > > > +        break;
> > > > +    }
> > > > +
> > > >      default:
> > > >          /*
> > > >           * Should not be reached unless arch_monitor_get_capabilit=
ies() is
> > > > diff --git a/xen/include/public/domctl.h b/xen/include/public/domct=
l.h
> > > > index b85e6170b0..4803ed7afc 100644
> > > > --- a/xen/include/public/domctl.h
> > > > +++ b/xen/include/public/domctl.h
> > > > @@ -1057,6 +1057,7 @@ struct xen_domctl_psr_cmt_op {
> > > >  #define XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED    10
> > > >  /* Enabled by default */
> > > >  #define XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT     11
> > > > +#define XEN_DOMCTL_MONITOR_EVENT_VMEXIT                12
> > > >
> > > >  struct xen_domctl_monitor_op {
> > > >      uint32_t op; /* XEN_DOMCTL_MONITOR_OP_* */
> > > > @@ -1107,6 +1108,11 @@ struct xen_domctl_monitor_op {
> > > >              /* Pause vCPU until response */
> > > >              uint8_t sync;
> > > >          } debug_exception;
> > > > +
> > > > +        struct {
> > > > +            /* Send event and don't process vmexit */
> > > > +            uint8_t sync;
> > > > +        } vmexit;
> > > >      } u;
> > > >  };
> > > >
> > > > diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_=
event.h
> > > > index 81c2ee28cc..07f106f811 100644
> > > > --- a/xen/include/public/vm_event.h
> > > > +++ b/xen/include/public/vm_event.h
> > > > @@ -175,6 +175,8 @@
> > > >  #define VM_EVENT_REASON_DESCRIPTOR_ACCESS       13
> > > >  /* Current instruction is not implemented by the emulator */
> > > >  #define VM_EVENT_REASON_EMUL_UNIMPLEMENTED      14
> > > > +/* VMEXIT */
> > > > +#define VM_EVENT_REASON_VMEXIT                  15
> > > >
> > > >  /* Supported values for the vm_event_write_ctrlreg index. */
> > > >  #define VM_EVENT_X86_CR0    0
> > > > @@ -394,6 +396,11 @@ struct vm_event_emul_insn_data {
> > > >      uint8_t data[16]; /* Has to be completely filled */
> > > >  };
> > > >
> > > > +struct vm_event_vmexit {
> > > > +    uint64_t reason;
> > > > +    uint64_t qualification;
> > > > +};
> > >
> > > You are exposing an Intel specific interface publicly here.  Might be
> > > worth adding a note, and/or adding 'intel' or 'vmx' in the structure
> > > name: vm_event_vmx_exit, so that a vm_event_svm_exit could also be
> > > added in the future.
> >
> > All vm_event monitor events are for vmx only right now. We can
> > certainly do that abstraction if and when someone decides to add svm
> > support, the ABI is versioned and no structure here is set in stone.
> > No guarantees are even implied for the structures to remain the same
> > in any way between one version of the ABI to the next. So with that I
> > don't see the need for complicating the structures at this time.
>
> Well, it's just altering the name slightly, but the structure layout
> would be the same.  Just so that someone wanting to add SVM support
> doesn't have to go and rename the VMX specific structures.  I think it
> also makes it easier to identify what's vendor specific and what
> should be shared between vendors.
>
> I don't think it adds any complications to the code you are adding,
> but would make it easier for someone wanting to add a new vendor
> support in the future.

I really don't think it's necessary at this point but oh well, I'm not
going to get hung up on that.

Tamas


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 19:09:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 19:09:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314114.532034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njQYS-0003jR-OY; Tue, 26 Apr 2022 19:08:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314114.532034; Tue, 26 Apr 2022 19:08:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njQYS-0003jK-Lk; Tue, 26 Apr 2022 19:08:56 +0000
Received: by outflank-mailman (input) for mailman id 314114;
 Tue, 26 Apr 2022 19:08:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1SWQ=VE=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1njQYR-0003jE-MY
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 19:08:55 +0000
Received: from MTA-08-3.privateemail.com (mta-08-3.privateemail.com
 [198.54.127.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4fe9a531-c594-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 21:08:54 +0200 (CEST)
Received: from mta-08.privateemail.com (localhost [127.0.0.1])
 by mta-08.privateemail.com (Postfix) with ESMTP id 824D518000A1
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 15:08:52 -0400 (EDT)
Received: from mail-oi1-f169.google.com (unknown [10.20.151.166])
 by mta-08.privateemail.com (Postfix) with ESMTPA id 5DA2618000A0
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 15:08:52 -0400 (EDT)
Received: by mail-oi1-f169.google.com with SMTP id z2so21764344oic.6
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 12:08:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fe9a531-c594-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1651000132;
	bh=yPbcqqdvrqY4PHs11jvQLiX38T1X301iId1E0jTb5+M=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=qTUd6af6HB147lkpwNM+UscRiZZ12ZjKfJ8zgQ40TW8Ixdju0szKYeGLHOPP6hoyO
	 9F3A1kCPvLHUX4jfo+QbsW6ugzTsGFrBOY1Wo2HdFQuVJH3L6i6vC+nGSnRGbCFFGr
	 Qwxb6xq8IGWxzSx1n9LTXKUDJC83dLAZUlGVHPnp/bZvxeLK7llyDcJjAGwqF8qeMz
	 rrvddObCADd5waQvG/ZRNp7hLvZGcZLs2pQqSSWHQtoWIjZmYuyx4ey/HsX3N+/FRv
	 xj4leGm1xefw6MmYJiA3XOJyFZD8Nf7Zs9yPLWTDbAwGh1EbJtXe3mD6SAotF9Y+0n
	 zWAaFQCQOEKPg==
X-Gm-Message-State: AOAM530lrAr+pJsckG6OwfCcFlc9j+wTgzNCpOHgnj6g64K+oZo3meEN
	JtVGXtKwDgdDTssWBJSvPbhxhl4cTwGmdu5/rFk=
X-Google-Smtp-Source: ABdhPJz5RSTxm5VEA6NqBXvUGgr6HegqnqBrTjnsZAmoxHBeJswuBRXwUceIecdDKC8tfrrj0tWJB1SKPGtLNsv01Kk=
X-Received: by 2002:a05:6808:302b:b0:2f9:eeef:f03 with SMTP id
 ay43-20020a056808302b00b002f9eeef0f03mr16102819oib.128.1651000131698; Tue, 26
 Apr 2022 12:08:51 -0700 (PDT)
MIME-Version: 1.0
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
 <CABfawhk-oCAoz-99LOaOYKD-N1FvRnFvM9_AUCgsPEF16F=VCA@mail.gmail.com>
 <BN9PR11MB527672E1BF038742F290A7798CF59@BN9PR11MB5276.namprd11.prod.outlook.com>
 <7a9e02b5-e24e-0b55-e52f-0e45e41eafc6@suse.com>
In-Reply-To: <7a9e02b5-e24e-0b55-e52f-0e45e41eafc6@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Tue, 26 Apr 2022 15:08:15 -0400
X-Gmail-Original-Message-ID: <CABfawhm54w_jm1-cz-e7fDNSxkFQtbw_4RJGGrpq1YsHvDAe4w@mail.gmail.com>
Message-ID: <CABfawhm54w_jm1-cz-e7fDNSxkFQtbw_4RJGGrpq1YsHvDAe4w@mail.gmail.com>
Subject: Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state
To: Jan Beulich <jbeulich@suse.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Nakajima, Jun" <jun.nakajima@intel.com>, 
	"Cooper, Andrew" <andrew.cooper3@citrix.com>, =?UTF-8?Q?Pau_Monn=C3=A9=2C_Roger?= <roger.pau@citrix.com>, 
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, 
	"Lengyel, Tamas" <tamas.lengyel@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Wed, Apr 20, 2022 at 2:50 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 20.04.2022 08:39, Tian, Kevin wrote:
> >> From: Tamas K Lengyel <tamas@tklengyel.com>
> >> Sent: Tuesday, April 19, 2022 2:43 AM
> >>
> >> On Fri, Mar 25, 2022 at 9:34 AM Tamas K Lengyel <tamas.lengyel@intel.com>
> >> wrote:
> >>>
> >>> During VM forking and resetting a failed vmentry has been observed due
> >>> to the guest non-register state going out-of-sync with the guest register
> >>> state. For example, a VM fork reset right after a STI instruction can trigger
> >>> the failed entry. This is due to the guest non-register state not being saved
> >>> from the parent VM, thus the reset operation only copies the register state.
> >>>
> >>> Fix this by adding a new pair of hvm functions to get/set the guest
> >>> non-register state so that the overall vCPU state remains in sync.
> >>>
> >>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> >>> ---
> >>> v5: Switch to internal-only hvm funcs instead of adding to hvm_hw_cpu
> >>
> >> Patch ping.
> >
> > I'd like to hear opinions from Andrew/Jan first. Obviously they have
> > different thoughts when reviewing the earlier versions.
>
> Well, I certainly would prefer if migration was taken care of at the same
> time, but I can understand if Tamas doesn't want to put more time into
> getting that case working. Plus, aiui, this solution to his problem won't
> prevent the eventual wider scope change to be used also for the specific
> purpose here, perhaps by simply fully replacing what is being done now.

Can we move forward with this patch then? As Jan points out, it
doesn't prevent anyone coming up with a fix to the migration case,
whatever shape that might take.

Thanks,
Tamas


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 19:41:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 19:41:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314120.532046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njR3W-0007kM-8V; Tue, 26 Apr 2022 19:41:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314120.532046; Tue, 26 Apr 2022 19:41:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njR3W-0007kF-5W; Tue, 26 Apr 2022 19:41:02 +0000
Received: by outflank-mailman (input) for mailman id 314120;
 Tue, 26 Apr 2022 19:41:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njR3U-0007k9-R1
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 19:41:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njR3U-0003tu-6M; Tue, 26 Apr 2022 19:41:00 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njR3U-0006mY-1F; Tue, 26 Apr 2022 19:41:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=it1Hz+xCN6O26EgCOKuU9vyMbulIsA7t/NkfKbffepE=; b=N7DTjZdhlLDQC2Sy9fRVkS3C7Y
	Ff5ztZI0tX2/gCtmgyDtTXmvnvVCLr6cvrmjJBneYPrN9hBHpXmqXNaT2byn8XM7voJ7GxKR9F8AJ
	T0PypRglxAA1YxDoATOVW85yJqFpZxahC8umPCv3nhfSMNIntlm/pO4/ZZMvT+Zxeabo=;
Message-ID: <f943aff3-4d70-fd30-a981-f4e78ffd363d@xen.org>
Date: Tue, 26 Apr 2022 20:40:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: Paran Lee <p4ranlee@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Austin Kim <austindh.kim@gmail.com>, xen-devel@lists.xenproject.org
References: <20220421151755.GA4718@DESKTOP-NK4TH6S.localdomain>
 <a160a77a-1cb2-c7cb-7d93-7334772620fe@xen.org>
 <086069c4-406b-ac33-7c44-8433980026fc@gmail.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH] xen/arm: p2m_set_entry duplicate calculation.
In-Reply-To: <086069c4-406b-ac33-7c44-8433980026fc@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 26/04/2022 16:37, Paran Lee wrote:
> Thanks you, I agreed! It made me think once more about what my patch
> could improve.
> patches I sent have been reviewed in various ways. It was a good
> opportunity to analyze my patch from various perspectives. :)
> 
> I checked objdump in -O2 optimization(default) of Xen Makefile to make
> sure CSE (Common subexpression elimination) works well on the latest
> arm64 cross compiler on x86_64 from  Arm GNU Toolchain.
> 
> $
> ~/gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu/bin/aarch64-none-linux-gnu-gcc
> -v
> ...
> A-profile Architecture 10.3-2021.07 (arm-10.29)'
> Thread model: posix
> Supported LTO compression algorithms: zlib
> gcc version 10.3.1 20210621 (GNU Toolchain for the A-profile
> Architecture 10.3-2021.07 (arm-10.29)
> 
> I compared the before and after my patches. This time, without adding a
> "pages" variable, I proceeded to use the local variable mask with order
> operation.
> 
> I was able to confirm that it does one less operation.

Well... I don't think the one less operation is because of introduction 
of the local variable (see more below).

> 
> (1) before clean up
> 
> 0000000000001bb4 <p2m_set_entry>:
>      while ( nr )
>      1bb4:       b40005e2        cbz     x2, 1c70 <p2m_set_entry+0xbc>
> {
>      ...
>          if ( rc )
>      1c1c:       350002e0        cbnz    w0, 1c78 <p2m_set_entry+0xc4>
>          sgfn = gfn_add(sgfn, (1 << order));

1 << order is a 32-bit value but the second parameter is a 64-bit value 
(assuming arm64). So...

>      1c20:       1ad32373        lsl     w19, w27, w19   // <<< CES works
>      1c24:       93407e73        sxtw    x19, w19        // <<< well!

... this instruction is extending the 32-bit value to 64-bit value.

>      return _gfn(gfn_x(gfn) + i);
>      1c28:       8b1302d6        add     x22, x22, x19
>      return _mfn(mfn_x(mfn) + i);
>      1c2c:       8b130281        add     x1, x20, x19
>      1c30:       b100069f        cmn     x20, #0x1
>      1c34:       9a941034        csel    x20, x1, x20, ne  // ne = any
>      while ( nr )
>      1c38:       eb1302b5        subs    x21, x21, x19
>      1c3c:       540001e0        b.eq    1c78 <p2m_set_entry+0xc4>  // b.none
> 
> (2) Using again mask variable. mask = 1UL << order
> code show me   sxtw    x19, w19    operation disappeared.
This code is not only using a local variable but also using "1UL". So, I 
suspect that if you were using 1 << order, the instruction would re-appear.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 19:43:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 19:43:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314127.532056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njR68-0008OL-Pb; Tue, 26 Apr 2022 19:43:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314127.532056; Tue, 26 Apr 2022 19:43:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njR68-0008OE-Ma; Tue, 26 Apr 2022 19:43:44 +0000
Received: by outflank-mailman (input) for mailman id 314127;
 Tue, 26 Apr 2022 19:43:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njR67-0008O6-1j
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 19:43:43 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njR64-0003yL-K3; Tue, 26 Apr 2022 19:43:40 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njR64-0006u2-Ee; Tue, 26 Apr 2022 19:43:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=Br5U3gJizTxRRDgynqD5Dfbji+NcUWjzCSSQUqnlHbs=; b=cmQfSfIkl1RemHeYo51D+ObHFI
	cRKk0t6tqY9dfryTxmiLVZGshQIlLKzaTY1Pw+s5IDRt9cTl/WYaWcd0O0Cx2kDVsjt1efEuuKrsY
	seNvE9To7JTO/NqMSlX0Gj1B3rjyFdyhsUIPA8/61yTDEdvSSwE4duhsP6NJGZ33eLJM=;
Message-ID: <0028b769-ff2b-cadd-d85c-ec7885304b73@xen.org>
Date: Tue, 26 Apr 2022 20:43:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
To: Paran Lee <p4ranlee@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: austindh.kim@gmail.com, xen-devel@lists.xenproject.org
References: <20220426154904.GA11482@DESKTOP-NK4TH6S.localdomain>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v2] xen/arm: p2m_set_entry reuse mask variables
In-Reply-To: <20220426154904.GA11482@DESKTOP-NK4TH6S.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 26/04/2022 16:49, Paran Lee wrote:
> Reuse mask variables on order shift duplicated calculation.
> 
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> ---
>   xen/arch/arm/p2m.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)

It is common to add a changelog after "---". This helps the reviewer to 
know what changed in your patch.

> 
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 1d1059f7d2..cdb3b56aa1 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1118,11 +1118,12 @@ int p2m_set_entry(struct p2m_domain *p2m,
>           if ( rc )
>               break;
>   
> -        sgfn = gfn_add(sgfn, (1 << order));
> +        mask = 1UL << order;

"1UL << order" refers to the number of pages and not a mask. So I don't 
think re-using the local variable 'mask' is a good idea because the code 
is a lot more confusing.

Instead, I think your other patch is the way to go with a small tweak to 
use 1UL (which BTW should be mentioned in the commit message).

Either Stefano or I can deal with the change on commit.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 19:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 19:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314135.532074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRDS-0001UD-JF; Tue, 26 Apr 2022 19:51:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314135.532074; Tue, 26 Apr 2022 19:51:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRDS-0001U6-GG; Tue, 26 Apr 2022 19:51:18 +0000
Received: by outflank-mailman (input) for mailman id 314135;
 Tue, 26 Apr 2022 19:51:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ckxI=VE=gmail.com=p4ranlee@srs-se1.protection.inumbo.net>)
 id 1njRDR-0001Ty-VQ
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 19:51:18 +0000
Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com
 [2607:f8b0:4864:20::52a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3bc0209c-c59a-11ec-8fc2-03012f2f19d4;
 Tue, 26 Apr 2022 21:51:17 +0200 (CEST)
Received: by mail-pg1-x52a.google.com with SMTP id bg9so16896906pgb.9
 for <xen-devel@lists.xenproject.org>; Tue, 26 Apr 2022 12:51:16 -0700 (PDT)
Received: from [192.168.0.18] ([118.33.58.98])
 by smtp.gmail.com with ESMTPSA id
 y16-20020a63b510000000b00398d8b19bbfsm13720448pge.23.2022.04.26.12.51.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 26 Apr 2022 12:51:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3bc0209c-c59a-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:to:references:cc
         :from:in-reply-to:content-transfer-encoding;
        bh=fU0UOb7Z4Jp4qPhNb2hjMnu4rnkA/7cO1b1V5zl7bE0=;
        b=i8lUw+XadwiyCJwS2QOtYSjK8igaaGd0k6XljQc4RrDTHDGM8VIV+cV4DjlGJouMDY
         WvmJLQIv4wJKpYS0q+U5nvh5Dsww0fNnJQtnNAbRxY8mdYJSItro7mzMPcRqG7+cMlNY
         bCb5SX3FzS/VNEAEqlyuqZhJHPa8IzoI0NKhtDGY+pjP13PAhKtL8Qy8hJyTa29Z9DoH
         PgVUHegZGeZA+y/iiujyffi0W7M2QrR1K5PkwDuRyghuK6xCfi/gfqiYnjroe+Vh420A
         ipYT2tE2pu9npouqaC5l38fyEiVBjYatWFpik4G5oLnBvmhTz0+B0T5ruNqltdbMuylZ
         7zBQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :to:references:cc:from:in-reply-to:content-transfer-encoding;
        bh=fU0UOb7Z4Jp4qPhNb2hjMnu4rnkA/7cO1b1V5zl7bE0=;
        b=BmcinyEzDjE5G4mpY0FadAIClD43mm8PyaOxrHstk3p/TA/7L9tRl4yc1Kx7JdQLwQ
         gkOnIAtgP8ShVN6iXjn5wGpra+YcozbUcBkdKS4vTBVvzOM4lCPoi8CXuQlgWjLlg+ue
         0Z6yvWb9yu2OYHeQaG0Jfhj3qnperqrBd7PvEQ7y7B3rhEAq59yilaRw0DtvXg1Hxc2D
         9Mzt7G8FSlY7Lm46V1exfCE7jDIQP1tRQfBukUmhI+7nAup9Ql9E1yYqnVJVzgYEM/zT
         +rD5UKrgs1aRzH4XHxkIceO7R7SjW5QyqXNrUBI0zyXTKr1jWmViEw7GuvmOcOupXyWz
         D8ww==
X-Gm-Message-State: AOAM530JU5i35OfSi5DzCzOVLzSOiLvm/PYS0mWfJ1P2NQHssLcvjv2Z
	Jto2cU54UhkcaqTB2wzDNR2+/i3tL5JuTgpM
X-Google-Smtp-Source: ABdhPJxUkew1k0H1MehvqYcLrXPgZ7SDsjP/PbmlHXvTS+Q69bkmtrbwgemDAi8mwEkGfnXq436MIA==
X-Received: by 2002:a63:6ac9:0:b0:3bc:321e:6d56 with SMTP id f192-20020a636ac9000000b003bc321e6d56mr684654pgc.490.1651002675319;
        Tue, 26 Apr 2022 12:51:15 -0700 (PDT)
Message-ID: <cc689445-20b3-7648-e447-ac0b2a61d0ea@gmail.com>
Date: Wed, 27 Apr 2022 04:51:11 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2] xen/arm: p2m_set_entry reuse mask variables
To: Julien Grall <julien@xen.org>
References: <20220426154904.GA11482@DESKTOP-NK4TH6S.localdomain>
 <0028b769-ff2b-cadd-d85c-ec7885304b73@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, austindh.kim@gmail.com,
 xen-devel@lists.xenproject.org
From: Paran Lee <p4ranlee@gmail.com>
In-Reply-To: <0028b769-ff2b-cadd-d85c-ec7885304b73@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Thansk!

> It is common to add a changelog after "---". This helps the reviewer to
> know what changed in your patch.

I think this experience will be very helpful for the next more
meaningful patch.

>
> "1UL << order" refers to the number of pages and not a mask. So I don't
> think re-using the local variable 'mask' is a good idea because the code
> is a lot more confusing.

I agree too.

> Instead, I think your other patch is the way to go with a small tweak to
> use 1UL (which BTW should be mentioned in the commit message).
>
> Either Stefano or I can deal with the change on commit.

Thank you so much for your detailed patch review.

BR
Paran Lee


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 20:05:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 20:05:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314141.532084 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRQY-00034S-Q3; Tue, 26 Apr 2022 20:04:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314141.532084; Tue, 26 Apr 2022 20:04:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRQY-00034L-NF; Tue, 26 Apr 2022 20:04:50 +0000
Received: by outflank-mailman (input) for mailman id 314141;
 Tue, 26 Apr 2022 20:04:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njRQX-00033v-7r; Tue, 26 Apr 2022 20:04:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njRQX-0004Qo-5m; Tue, 26 Apr 2022 20:04:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njRQW-0001C8-P1; Tue, 26 Apr 2022 20:04:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njRQW-0006Hs-OW; Tue, 26 Apr 2022 20:04:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=07/t19Vd+lY/hqhFhTPlc9DaLFEn/4/+vBP43FImGSs=; b=waG+iSkqCBhBpfNfA6fVQUnmpI
	J/67qKqAe6hTLTuTg5sSQ8WtJ/FXWw3OptaaQD0rHKtEp1ajohqsx9ey3thfxtKiHnXStvoasQsBh
	5e11rjpLCju6oh1r4jQ0fdYZcrm13LsM+/ehEwnKU6BskpXjHTB2wJpAPTMSwkHEU67k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169748-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169748: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3f5d61466345ed2213de2d7e391b6cd6d4b86015
X-Osstest-Versions-That:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 20:04:48 +0000

flight 169748 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169748/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  3f5d61466345ed2213de2d7e391b6cd6d4b86015
baseline version:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08

Last test of basis   169630  2022-04-22 20:01:46 Z    4 days
Failing since        169729  2022-04-26 09:00:28 Z    0 days    3 attempts
Testing same since   169748  2022-04-26 17:00:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2419a159fb..3f5d614663  3f5d61466345ed2213de2d7e391b6cd6d4b86015 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 20:06:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 20:06:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314148.532095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRSG-0003eZ-7j; Tue, 26 Apr 2022 20:06:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314148.532095; Tue, 26 Apr 2022 20:06:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRSG-0003eS-4Z; Tue, 26 Apr 2022 20:06:36 +0000
Received: by outflank-mailman (input) for mailman id 314148;
 Tue, 26 Apr 2022 20:06:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njRSE-0003eK-Ho
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 20:06:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njRSE-0004SG-6T; Tue, 26 Apr 2022 20:06:34 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njRSD-0008Ly-U1; Tue, 26 Apr 2022 20:06:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=cXpV0bZL990t71BRKzeJL0a98IyOZGTem4wwEkwMQyU=; b=Zc96Rk
	RpPopW2ikP6HSuiiipn5dNz0twcJDARU0CqVcjHNof3SLC48dhoGsh4SQhzajyKzzbYwJgZ9Rku0C
	o4ag5v+r2bZlMzof6NmhAxTIooJ2679btH3Bl+GVQF+D0GhOu29VDj1Zk5R1DyaTa8BUddjC6ieIN
	l1J/XVfVJ64=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	David Vrabel <dvrabel@amazon.co.uk>
Subject: [PATCH] xen/arm: alternative: Don't call vmap() within stop_machine_run()
Date: Tue, 26 Apr 2022 21:06:29 +0100
Message-Id: <20220426200629.58921-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap
alloc/free" extended the checks in the buddy allocator to catch
any use of the helpers from context with interrupts disabled.

Unfortunately, the rule is not followed in the alternative code and
this will result to crash at boot with debug enabled:

(XEN) Xen call trace:
(XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
(XEN)    [<00000000>] 00000000 (LR)
(XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
(XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
(XEN)    [<00236864>] __vmap+0x400/0x4a4
(XEN)    [<0026aee8>] arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
(XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
(XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
(XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
(XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c

The interrupts will be disabled by the state machine in stop_machine_run(),
hence why the ASSERT is hit.

For now the patch extending the checks has been reverted, but it would
be good to re-introduce it (allocation with interrupts disabled is not
desirable).

So move the re-mapping of Xen to the caller of stop_machine_run().

Signed-off-by: Julien Grall <jgrall@amazon.com>
Cc: David Vrabel <dvrabel@amazon.co.uk>

---

I managed to successfully boot Xen with this patch and dropping the
revert.
---
 xen/arch/arm/alternative.c | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
index 237c4e564209..f03cd943c636 100644
--- a/xen/arch/arm/alternative.c
+++ b/xen/arch/arm/alternative.c
@@ -170,7 +170,7 @@ static int __apply_alternatives(const struct alt_region *region,
  * We might be patching the stop_machine state machine, so implement a
  * really simple polling protocol here.
  */
-static int __apply_alternatives_multi_stop(void *unused)
+static int __apply_alternatives_multi_stop(void *xenmap)
 {
     static int patched = 0;
 
@@ -185,22 +185,9 @@ static int __apply_alternatives_multi_stop(void *unused)
     {
         int ret;
         struct alt_region region;
-        mfn_t xen_mfn = virt_to_mfn(_start);
-        paddr_t xen_size = _end - _start;
-        unsigned int xen_order = get_order_from_bytes(xen_size);
-        void *xenmap;
 
         BUG_ON(patched);
 
-        /*
-         * The text and inittext section are read-only. So re-map Xen to
-         * be able to patch the code.
-         */
-        xenmap = __vmap(&xen_mfn, 1U << xen_order, 1, 1, PAGE_HYPERVISOR,
-                        VMAP_DEFAULT);
-        /* Re-mapping Xen is not expected to fail during boot. */
-        BUG_ON(!xenmap);
-
         region.begin = __alt_instructions;
         region.end = __alt_instructions_end;
 
@@ -208,8 +195,6 @@ static int __apply_alternatives_multi_stop(void *unused)
         /* The patching is not expected to fail during boot. */
         BUG_ON(ret != 0);
 
-        vunmap(xenmap);
-
         /* Barriers provided by the cache flushing */
         write_atomic(&patched, 1);
     }
@@ -224,14 +209,29 @@ static int __apply_alternatives_multi_stop(void *unused)
 void __init apply_alternatives_all(void)
 {
     int ret;
+    mfn_t xen_mfn = virt_to_mfn(_start);
+    paddr_t xen_size = _end - _start;
+    unsigned int xen_order = get_order_from_bytes(xen_size);
+    void *xenmap;
 
     ASSERT(system_state != SYS_STATE_active);
 
+    /*
+     * The text and inittext section are read-only. So re-map Xen to
+     * be able to patch the code.
+     */
+    xenmap = __vmap(&xen_mfn, 1U << xen_order, 1, 1, PAGE_HYPERVISOR,
+                    VMAP_DEFAULT);
+    /* Re-mapping Xen is not expected to fail during boot. */
+    BUG_ON(!xenmap);
+
 	/* better not try code patching on a live SMP system */
-    ret = stop_machine_run(__apply_alternatives_multi_stop, NULL, NR_CPUS);
+    ret = stop_machine_run(__apply_alternatives_multi_stop, xenmap, NR_CPUS);
 
     /* stop_machine_run should never fail at this stage of the boot */
     BUG_ON(ret);
+
+    vunmap(xenmap);
 }
 
 int apply_alternatives(const struct alt_instr *start, const struct alt_instr *end)
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Tue Apr 26 20:09:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 20:09:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314155.532106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRUb-0004Ib-Kc; Tue, 26 Apr 2022 20:09:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314155.532106; Tue, 26 Apr 2022 20:09:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRUb-0004IU-Hl; Tue, 26 Apr 2022 20:09:01 +0000
Received: by outflank-mailman (input) for mailman id 314155;
 Tue, 26 Apr 2022 20:09:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njRUa-0004IM-5u
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 20:09:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njRUV-0004Vr-9R; Tue, 26 Apr 2022 20:08:55 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.15.135]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njRUV-00007Y-3m; Tue, 26 Apr 2022 20:08:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=AqXK2Cd6KjaYTOf+NulERg4VoBVgzIiaHCbedl7nyXU=; b=tnc8mbEBXPR2l6xNuqhsadwk2R
	yH/vZ3WXiObzp7sIPia8HieHlRXMCnlbwnEstSlMAw9wD/2ZMycBF2IRIjEbK0TMLO/7FfNlGmGkX
	KmDIyZR24W3VywHw1ecOLFn8viz9UAR+rcZYphtjV05v6F/7W3kG7a4ysR/1gnajZfjk=;
Message-ID: <4e4392d3-2078-35c8-f72f-57d1324e0541@xen.org>
Date: Tue, 26 Apr 2022 21:08:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>, David Vrabel <dvrabel@cantab.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220425132801.1076759-1-dvrabel@cantab.net>
 <f5a45b8e-644d-15aa-951f-aa6d89ce4c5b@suse.com>
 <ecb4876e-c6d4-4bff-d964-92af83d39dff@xen.org>
In-Reply-To: <ecb4876e-c6d4-4bff-d964-92af83d39dff@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 26/04/2022 15:14, Julien Grall wrote:
> On 26/04/2022 15:01, Jan Beulich wrote:
>> On 25.04.2022 15:28, David Vrabel wrote:
>>> --- a/xen/common/page_alloc.c
>>> +++ b/xen/common/page_alloc.c
>>> @@ -162,6 +162,13 @@
>>>   static char __initdata opt_badpage[100] = "";
>>>   string_param("badpage", opt_badpage);
>>> +/*
>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>> + * enabled (except when only 1 PCPU is online).
>>> + */
>>> +#define ASSERT_ALLOC_CONTEXT() \
>>> +    ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() 
>>> <= 1))
>>
>> At least one of these tightened assertions triggers on Arm, as per the
>> most recent smoke flight. I'm going to revert this for the time being.
> 
>  From the serial console [1]:
> 
> (XEN) Xen call trace:
> (XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
> (XEN)    [<00000000>] 00000000 (LR)
> (XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
> (XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
> (XEN)    [<00236864>] __vmap+0x400/0x4a4
> (XEN)    [<0026aee8>] 
> arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
> (XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
> (XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
> (XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
> (XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c

I have sent a formal patch:

https://lore.kernel.org/xen-devel/20220426200629.58921-1-julien@xen.org/
Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 20:28:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 20:28:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314161.532117 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRn1-0006dU-7W; Tue, 26 Apr 2022 20:28:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314161.532117; Tue, 26 Apr 2022 20:28:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njRn1-0006dN-4J; Tue, 26 Apr 2022 20:28:03 +0000
Received: by outflank-mailman (input) for mailman id 314161;
 Tue, 26 Apr 2022 20:28:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IJm2=VE=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njRmz-0006dH-OK
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 20:28:01 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4ec61c00-c59f-11ec-a405-831a346695d4;
 Tue, 26 Apr 2022 22:27:35 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id CC8AAB822B1;
 Tue, 26 Apr 2022 20:27:34 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50F91C385AD;
 Tue, 26 Apr 2022 20:27:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ec61c00-c59f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651004853;
	bh=8+xdsPhWMfI5r99cdhsKwN+dtPwe0XNRTrWsh2XN7lY=;
	h=Date:From:To:cc:Subject:From;
	b=UXo0GsTvo7XDBlxfetK5/LEdGG0fjPXB8UNsm9WdHR4YTu5T/XhijPnl8h0KOv5vU
	 aPjpKYrMz4RkA8qGyotXhXVhCVYZaSZre0xDt3TkafdTFQ0ZicA1LcHTgy3iFT8IyC
	 fL29+5nDmfyqLqRc8DCKQ7ti8xEsyvzBCQV4tcfeoZalw6FbC0W47ixoXWQ23HOGSa
	 D2bhgmhQWHea1oEp3T3yXRBS8vuhKmYEL4GrqC6iVIw0r0TYHJYqDz8429l7ecxZvI
	 UEra3OTMACMLrIaelFUrUthBWd9/12BEET/AdoQMR3hUy1u7kPs9CMa056Nlk6/F0G
	 eYaWQy22ccQqA==
Date: Tue, 26 Apr 2022 13:27:32 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, julien@xen.org, rahul.singh@arm.com, 
    Bertrand.Marquis@arm.com
Subject: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer
Message-ID: <alpine.DEB.2.22.394.2204261323430.915916@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Add Rahul as ARM SMMU maintainer. Create a new explicit entry for "ARM
SMMU" also with Julien which is the original contributor of the code and
continues to maintain it.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>


diff --git a/MAINTAINERS b/MAINTAINERS
index 2a47fafe85..ba0d1c0c1b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -248,6 +248,12 @@ F:	xen/drivers/passthrough/arm/
 F:	xen/include/public/arch-arm/
 F:	xen/include/public/arch-arm.h
 
+ARM SMMU
+M:	Julien Grall <julien@xen.org>
+M:	Rahul Singh <rahul.singh@arm.com>
+S:	Supported
+F:	xen/drivers/passthrough/arm/smmu.c
+
 ARM SMMUv3
 M:	Bertrand Marquis <bertrand.marquis@arm.com>
 M:	Rahul Singh <rahul.singh@arm.com>


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 21:23:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 21:23:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314168.532132 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njSeI-000410-Cb; Tue, 26 Apr 2022 21:23:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314168.532132; Tue, 26 Apr 2022 21:23:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njSeI-00040t-9k; Tue, 26 Apr 2022 21:23:06 +0000
Received: by outflank-mailman (input) for mailman id 314168;
 Tue, 26 Apr 2022 21:23:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njSeH-00040j-KL; Tue, 26 Apr 2022 21:23:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njSeH-0005rA-Gd; Tue, 26 Apr 2022 21:23:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njSeH-00075q-4w; Tue, 26 Apr 2022 21:23:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njSeH-0001Xm-4T; Tue, 26 Apr 2022 21:23:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Bg/4c1dSnrtF6FYcLssOBZoO2Hwb+dS+Ny3tHDLWHv4=; b=XCVsc/lpRov5nVL19DK16Q5r/9
	5v50I6nhji0vVZDBgwx/nOtbD+1DOCjVYhEnH/70Uol/i/F+cAEsmzhAs4e9981U+4PXq9WAdVHek
	cVlUKJln5Wf9iF+5zyiDMwnMh7InCWZzlVHK1HQLQiHC3kc2HrK9UOdgZVPj++SBiXqs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169754-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169754: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 21:23:05 +0000

flight 169754 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169754/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  648 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    0 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 22:25:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 22:25:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314212.532161 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njTcV-0002bs-Ie; Tue, 26 Apr 2022 22:25:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314212.532161; Tue, 26 Apr 2022 22:25:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njTcV-0002bl-FN; Tue, 26 Apr 2022 22:25:19 +0000
Received: by outflank-mailman (input) for mailman id 314212;
 Tue, 26 Apr 2022 22:25:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njTcT-0002bb-Ri; Tue, 26 Apr 2022 22:25:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njTcT-0006wS-PR; Tue, 26 Apr 2022 22:25:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njTcT-00028w-D8; Tue, 26 Apr 2022 22:25:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njTcT-0007CJ-CU; Tue, 26 Apr 2022 22:25:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8p0QZYodHz1ppl9WqTyE3CPxr4QmB0yJ3+v7+g6azkQ=; b=aEFt5XHqbkJYwXj1p0yXcbcU49
	TCpZ1jKz1VZ4JGwbPDcM5I+RdFqaqMl3SrNS6+ifonfpuU/kPrVsAWvist7ocU4b/ixEdmiGTqa6e
	aM8Wsm6LFmtZ4FslgFGZOtUqUxmOhy0nsp3OwPjrp+27OUDkiVmrdXrGmr/jaiOdC0BA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169757-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169757: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 22:25:17 +0000

flight 169757 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169757/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  649 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   21 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 23:07:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 23:07:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314220.532172 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njUHe-0006mN-RF; Tue, 26 Apr 2022 23:07:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314220.532172; Tue, 26 Apr 2022 23:07:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njUHe-0006mG-Nk; Tue, 26 Apr 2022 23:07:50 +0000
Received: by outflank-mailman (input) for mailman id 314220;
 Tue, 26 Apr 2022 23:07:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IJm2=VE=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njUHd-0006mA-VZ
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 23:07:50 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b05c382e-c5b5-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 01:07:48 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id AB431B823EC;
 Tue, 26 Apr 2022 23:07:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10ECFC385A4;
 Tue, 26 Apr 2022 23:07:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b05c382e-c5b5-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651014466;
	bh=eeJYfFoAZBepUsgAkPLVDsENreNRy8kROauHQZqFYFM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=f6mukTfGaXrZtQx930X97Y4kI+ApmUr00UB80ww7b/SvbSzvqugz+Y4JLN/YTtdNQ
	 jZMy3Ci7YST3yTxsmuI9awa3iWhvaOEEODf8zU3oLo71N0cq1EnpGDs3TuuoejhV8J
	 RlKDLw5+BiQhzrIhThL8DPYZ/0k7nv1AnniNR9UhGbLKrtD/3t3Y/dVJeIYJDBrB4N
	 lPDSjEVQ4zFP4BuSYwray4TwyqIy7oTFroLifvfOMDgYWmNgrLa2d1WhdqYQDvUt52
	 Au3v4b6j307u1NOWinNuegaRwcPbpk4D3BHuK3vH8Idvcf4NhL+cbGsQzJ46JRYh3E
	 eyIWnI77jw64w==
Date: Tue, 26 Apr 2022 16:07:45 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Christoph Hellwig <hch@lst.de>
cc: sstabellini@kernel.org, jgross@suse.com, xen-devel@lists.xenproject.org, 
    linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, 
    Rahul Singh <Rahul.Singh@arm.com>
Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
In-Reply-To: <20220423171422.1831676-1-hch@lst.de>
Message-ID: <alpine.DEB.2.22.394.2204261605420.915916@ubuntu-linux-20-04-desktop>
References: <20220423171422.1831676-1-hch@lst.de>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 23 Apr 2022, Christoph Hellwig wrote:
> swiotlb-xen uses very different ways to allocate coherent memory on x86
> vs arm.  On the former it allocates memory from the page allocator, while
> on the later it reuses the dma-direct allocator the handles the
> complexities of non-coherent DMA on arm platforms.
> 
> Unfortunately the complexities of trying to deal with the two cases in
> the swiotlb-xen.c code lead to a bug in the handling of
> DMA_ATTR_NO_KERNEL_MAPPING on arm.  With the DMA_ATTR_NO_KERNEL_MAPPING
> flag the coherent memory allocator does not actually allocate coherent
> memory, but just a DMA handle for some memory that is DMA addressable
> by the device, but which does not have to have a kernel mapping.  Thus
> dereferencing the return value will lead to kernel crashed and memory
> corruption.
> 
> Fix this by using the dma-direct allocator directly for arm, which works
> perfectly fine because on arm swiotlb-xen is only used when the domain is
> 1:1 mapped, and then simplifying the remaining code to only cater for the
> x86 case with DMA coherent device.
> 
> Reported-by: Rahul Singh <Rahul.Singh@arm.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  arch/arm/include/asm/xen/page-coherent.h   |   2 -
>  arch/arm/xen/mm.c                          |  17 ----
>  arch/arm64/include/asm/xen/page-coherent.h |   2 -
>  arch/x86/include/asm/xen/page-coherent.h   |  24 -----
>  arch/x86/include/asm/xen/swiotlb-xen.h     |   5 +
>  drivers/xen/swiotlb-xen.c                  | 106 ++++++++-------------
>  include/xen/arm/page-coherent.h            |  20 ----
>  include/xen/xen-ops.h                      |   7 --
>  8 files changed, 45 insertions(+), 138 deletions(-)
>  delete mode 100644 arch/arm/include/asm/xen/page-coherent.h
>  delete mode 100644 arch/arm64/include/asm/xen/page-coherent.h
>  delete mode 100644 arch/x86/include/asm/xen/page-coherent.h
>  delete mode 100644 include/xen/arm/page-coherent.h
> 
> diff --git a/arch/arm/include/asm/xen/page-coherent.h b/arch/arm/include/asm/xen/page-coherent.h
> deleted file mode 100644
> index 27e984977402b..0000000000000
> --- a/arch/arm/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#include <xen/arm/page-coherent.h>
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index a7e54a087b802..6e603e5fdebb1 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -118,23 +118,6 @@ bool xen_arch_need_swiotlb(struct device *dev,
>  		!dev_is_dma_coherent(dev));
>  }
>  
> -int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> -				 unsigned int address_bits,
> -				 dma_addr_t *dma_handle)
> -{
> -	if (!xen_initial_domain())
> -		return -EINVAL;
> -
> -	/* we assume that dom0 is mapped 1:1 for now */
> -	*dma_handle = pstart;
> -	return 0;
> -}
> -
> -void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order)
> -{
> -	return;
> -}
> -
>  static int __init xen_mm_init(void)
>  {
>  	struct gnttab_cache_flush cflush;
> diff --git a/arch/arm64/include/asm/xen/page-coherent.h b/arch/arm64/include/asm/xen/page-coherent.h
> deleted file mode 100644
> index 27e984977402b..0000000000000
> --- a/arch/arm64/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#include <xen/arm/page-coherent.h>
> diff --git a/arch/x86/include/asm/xen/page-coherent.h b/arch/x86/include/asm/xen/page-coherent.h
> deleted file mode 100644
> index 63cd41b2e17ac..0000000000000
> --- a/arch/x86/include/asm/xen/page-coherent.h
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _ASM_X86_XEN_PAGE_COHERENT_H
> -#define _ASM_X86_XEN_PAGE_COHERENT_H
> -
> -#include <asm/page.h>
> -#include <linux/dma-mapping.h>
> -
> -static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t size,
> -		dma_addr_t *dma_handle, gfp_t flags,
> -		unsigned long attrs)
> -{
> -	void *vstart = (void*)__get_free_pages(flags, get_order(size));
> -	*dma_handle = virt_to_phys(vstart);
> -	return vstart;
> -}
> -
> -static inline void xen_free_coherent_pages(struct device *hwdev, size_t size,
> -		void *cpu_addr, dma_addr_t dma_handle,
> -		unsigned long attrs)
> -{
> -	free_pages((unsigned long) cpu_addr, get_order(size));
> -}
> -
> -#endif /* _ASM_X86_XEN_PAGE_COHERENT_H */
> diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h
> index 66b4ddde77430..558821387808e 100644
> --- a/arch/x86/include/asm/xen/swiotlb-xen.h
> +++ b/arch/x86/include/asm/xen/swiotlb-xen.h
> @@ -10,4 +10,9 @@ extern int pci_xen_swiotlb_init_late(void);
>  static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }
>  #endif
>  
> +int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> +				unsigned int address_bits,
> +				dma_addr_t *dma_handle);
> +void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order);
> +
>  #endif /* _ASM_X86_SWIOTLB_XEN_H */
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 47aebd98f52f5..557edb9c54879 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -36,7 +36,6 @@
>  #include <xen/hvc-console.h>
>  
>  #include <asm/dma-mapping.h>
> -#include <asm/xen/page-coherent.h>
>  
>  #include <trace/events/swiotlb.h>
>  #define MAX_DMA_BITS 32
> @@ -104,6 +103,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_X86
>  static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
>  {
>  	int rc;
> @@ -129,6 +129,12 @@ static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
>  	} while (i < nslabs);
>  	return 0;
>  }
> +#else
> +static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
> +{
> +	return 0;
> +}
> +#endif
>  
>  enum xen_swiotlb_err {
>  	XEN_SWIOTLB_UNKNOWN = 0,
> @@ -256,97 +262,60 @@ void __init xen_swiotlb_init_early(void)
>  		panic("Cannot allocate SWIOTLB buffer");
>  	swiotlb_set_max_segment(PAGE_SIZE);
>  }
> -#endif /* CONFIG_X86 */
>  
>  static void *
> -xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
> -			   dma_addr_t *dma_handle, gfp_t flags,
> -			   unsigned long attrs)
> +xen_swiotlb_alloc_coherent(struct device *dev, size_t size,
> +		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
>  {
> -	void *ret;
> +	u64 dma_mask = dev->coherent_dma_mask;
>  	int order = get_order(size);
> -	u64 dma_mask = DMA_BIT_MASK(32);
>  	phys_addr_t phys;
> -	dma_addr_t dev_addr;
> -
> -	/*
> -	* Ignore region specifiers - the kernel's ideas of
> -	* pseudo-phys memory layout has nothing to do with the
> -	* machine physical layout.  We can't allocate highmem
> -	* because we can't return a pointer to it.
> -	*/
> -	flags &= ~(__GFP_DMA | __GFP_HIGHMEM);
> +	void *ret;
>  
> -	/* Convert the size to actually allocated. */
> +	/* Align the allocation to the Xen page size */
>  	size = 1UL << (order + XEN_PAGE_SHIFT);
>  
> -	/* On ARM this function returns an ioremap'ped virtual address for
> -	 * which virt_to_phys doesn't return the corresponding physical
> -	 * address. In fact on ARM virt_to_phys only works for kernel direct
> -	 * mapped RAM memory. Also see comment below.
> -	 */
> -	ret = xen_alloc_coherent_pages(hwdev, size, dma_handle, flags, attrs);
> -
> +	ret = (void *)__get_free_pages(flags, get_order(size));
>  	if (!ret)
>  		return ret;
> -
> -	if (hwdev && hwdev->coherent_dma_mask)
> -		dma_mask = hwdev->coherent_dma_mask;
> -
> -	/* At this point dma_handle is the dma address, next we are
> -	 * going to set it to the machine address.
> -	 * Do not use virt_to_phys(ret) because on ARM it doesn't correspond
> -	 * to *dma_handle. */
> -	phys = dma_to_phys(hwdev, *dma_handle);
> -	dev_addr = xen_phys_to_dma(hwdev, phys);
> -	if (((dev_addr + size - 1 <= dma_mask)) &&
> -	    !range_straddles_page_boundary(phys, size))
> -		*dma_handle = dev_addr;
> -	else {
> -		if (xen_create_contiguous_region(phys, order,
> -						 fls64(dma_mask), dma_handle) != 0) {
> -			xen_free_coherent_pages(hwdev, size, ret, (dma_addr_t)phys, attrs);
> -			return NULL;
> -		}
> -		*dma_handle = phys_to_dma(hwdev, *dma_handle);
> +	phys = virt_to_phys(ret);
> +
> +	*dma_handle = xen_phys_to_dma(dev, phys);
> +	if (*dma_handle + size - 1 > dma_mask ||
> +	    range_straddles_page_boundary(phys, size)) {
> +		if (xen_create_contiguous_region(phys, order, fls64(dma_mask),
> +				dma_handle) != 0)
> +			goto out_free_pages;
>  		SetPageXenRemapped(virt_to_page(ret));
>  	}
> +
>  	memset(ret, 0, size);
>  	return ret;
> +
> +out_free_pages:
> +	free_pages((unsigned long)ret, get_order(size));
> +	return NULL;
>  }
>  
>  static void
> -xen_swiotlb_free_coherent(struct device *hwdev, size_t size, void *vaddr,
> -			  dma_addr_t dev_addr, unsigned long attrs)
> +xen_swiotlb_free_coherent(struct device *dev, size_t size, void *vaddr,
> +		dma_addr_t dma_handle, unsigned long attrs)
>  {
> +	phys_addr_t phys = virt_to_phys(vaddr);
>  	int order = get_order(size);
> -	phys_addr_t phys;
> -	u64 dma_mask = DMA_BIT_MASK(32);
> -	struct page *page;
> -
> -	if (hwdev && hwdev->coherent_dma_mask)
> -		dma_mask = hwdev->coherent_dma_mask;
> -
> -	/* do not use virt_to_phys because on ARM it doesn't return you the
> -	 * physical address */
> -	phys = xen_dma_to_phys(hwdev, dev_addr);
>  
>  	/* Convert the size to actually allocated. */
>  	size = 1UL << (order + XEN_PAGE_SHIFT);
>  
> -	if (is_vmalloc_addr(vaddr))
> -		page = vmalloc_to_page(vaddr);
> -	else
> -		page = virt_to_page(vaddr);
> +	if (WARN_ON_ONCE(dma_handle + size - 1 > dev->coherent_dma_mask) ||
> +	    WARN_ON_ONCE(range_straddles_page_boundary(phys, size)))
> +	    	return;
>  
> -	if (!WARN_ON((dev_addr + size - 1 > dma_mask) ||
> -		     range_straddles_page_boundary(phys, size)) &&
> -	    TestClearPageXenRemapped(page))
> +	if (TestClearPageXenRemapped(virt_to_page(vaddr)))
>  		xen_destroy_contiguous_region(phys, order);
> -
> -	xen_free_coherent_pages(hwdev, size, vaddr, phys_to_dma(hwdev, phys),
> -				attrs);
> +	free_pages((unsigned long)vaddr, get_order(size));
>  }
> +#endif /* CONFIG_X86 */
>  
>  /*
>   * Map a single buffer of the indicated size for DMA in streaming mode.  The
> @@ -549,8 +518,13 @@ xen_swiotlb_dma_supported(struct device *hwdev, u64 mask)
>  }
>  
>  const struct dma_map_ops xen_swiotlb_dma_ops = {
> +#ifdef CONFIG_X86
>  	.alloc = xen_swiotlb_alloc_coherent,
>  	.free = xen_swiotlb_free_coherent,
> +#else
> +	.alloc = dma_direct_alloc,
> +	.free = dma_direct_free,
> +#endif
>  	.sync_single_for_cpu = xen_swiotlb_sync_single_for_cpu,
>  	.sync_single_for_device = xen_swiotlb_sync_single_for_device,
>  	.sync_sg_for_cpu = xen_swiotlb_sync_sg_for_cpu,
> diff --git a/include/xen/arm/page-coherent.h b/include/xen/arm/page-coherent.h
> deleted file mode 100644
> index b9cc11e887ed5..0000000000000
> --- a/include/xen/arm/page-coherent.h
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _XEN_ARM_PAGE_COHERENT_H
> -#define _XEN_ARM_PAGE_COHERENT_H
> -
> -#include <linux/dma-mapping.h>
> -#include <asm/page.h>
> -
> -static inline void *xen_alloc_coherent_pages(struct device *hwdev, size_t size,
> -		dma_addr_t *dma_handle, gfp_t flags, unsigned long attrs)
> -{
> -	return dma_direct_alloc(hwdev, size, dma_handle, flags, attrs);
> -}
> -
> -static inline void xen_free_coherent_pages(struct device *hwdev, size_t size,
> -		void *cpu_addr, dma_addr_t dma_handle, unsigned long attrs)
> -{
> -	dma_direct_free(hwdev, size, cpu_addr, dma_handle, attrs);
> -}
> -
> -#endif /* _XEN_ARM_PAGE_COHERENT_H */
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index a3584a357f353..c7c1b46ff4cd4 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -42,13 +42,6 @@ int xen_setup_shutdown_event(void);
>  
>  extern unsigned long *xen_contiguous_bitmap;
>  
> -#if defined(CONFIG_XEN_PV) || defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> -int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> -				unsigned int address_bits,
> -				dma_addr_t *dma_handle);
> -void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order);
> -#endif
> -
>  #if defined(CONFIG_XEN_PV)
>  int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr,
>  		  xen_pfn_t *pfn, int nr, int *err_ptr, pgprot_t prot,
> -- 
> 2.30.2
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 23:17:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 23:17:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314226.532183 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njUR9-0008F5-OR; Tue, 26 Apr 2022 23:17:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314226.532183; Tue, 26 Apr 2022 23:17:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njUR9-0008Ey-L3; Tue, 26 Apr 2022 23:17:39 +0000
Received: by outflank-mailman (input) for mailman id 314226;
 Tue, 26 Apr 2022 23:17:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njUR8-0008Eo-CL; Tue, 26 Apr 2022 23:17:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njUR8-0007p2-BE; Tue, 26 Apr 2022 23:17:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njUR8-0004p8-1k; Tue, 26 Apr 2022 23:17:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njUR8-0006wY-1D; Tue, 26 Apr 2022 23:17:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WM6qyWdKBJBwRutxrRHdx1BumXUPmOEF1A6vI/uJcT4=; b=1lBU9NDnb85UtjxfnNb+VzzWah
	taHMoHzNyC7MTJG9oReLI32lhWsEx6bpAVYkkJN0dkvhIEtyeQ/LR2tT8UQcuK135YLcBw2r5M7V9
	HVOYpAE1JlhNQ2SXZYZ1Qfu39PJm4XqfspP4A68BYt7n5wOFpAsUfwfB6e7lkYio59eA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169758-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169758: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Apr 2022 23:17:38 +0000

flight 169758 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169758/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  650 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   22 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 23:36:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 23:36:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314235.532194 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njUia-0002B1-Di; Tue, 26 Apr 2022 23:35:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314235.532194; Tue, 26 Apr 2022 23:35:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njUia-0002Au-AU; Tue, 26 Apr 2022 23:35:40 +0000
Received: by outflank-mailman (input) for mailman id 314235;
 Tue, 26 Apr 2022 23:35:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IJm2=VE=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njUiY-0002Ao-NT
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 23:35:38 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 926b4922-c5b9-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 01:35:36 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 28D20619F1;
 Tue, 26 Apr 2022 23:35:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34058C385A0;
 Tue, 26 Apr 2022 23:35:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 926b4922-c5b9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651016134;
	bh=KXgLpXDC1Ub3aKfhDQgdSP7l4ipuTdlRezyIEtbEMcY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=KtDbdithHLXbf7PBpFlEaOhBPzTh0kkDgHcjjne9Vvt6KtuVOlxKzJbx+6kdXrdon
	 c6rHlhsrkl0zNZ4INcHaJzFcMgLifyuzdUOSTukIHVXMJYpAaAuwplMJPTSYg8eQwd
	 pK76WB43uyVbgpri1BOhTZ1jjoUMMkHd3YXsBGVexW+Arv8b1kuvaved4g3I0D6Dbs
	 5DsPhwfnCiLp1Lqv28OsDENLpRw+ZZxmDQ9Jw0EwClMaXGYHuWdFhi/4FTpl6ouU2m
	 3KLRlLm55OoqVb7pidzW7VJ5Xt/i52vKbRCUJNUt2iWHj9nfOapzZ8C6JfPsxXLX4m
	 VN5FmAoXqQZoQ==
Date: Tue, 26 Apr 2022 16:35:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    David Vrabel <dvrabel@amazon.co.uk>
Subject: Re: [PATCH] xen/arm: alternative: Don't call vmap() within
 stop_machine_run()
In-Reply-To: <20220426200629.58921-1-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204261635250.915916@ubuntu-linux-20-04-desktop>
References: <20220426200629.58921-1-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 26 Apr 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap
> alloc/free" extended the checks in the buddy allocator to catch
> any use of the helpers from context with interrupts disabled.
> 
> Unfortunately, the rule is not followed in the alternative code and
> this will result to crash at boot with debug enabled:
> 
> (XEN) Xen call trace:
> (XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
> (XEN)    [<00000000>] 00000000 (LR)
> (XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
> (XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
> (XEN)    [<00236864>] __vmap+0x400/0x4a4
> (XEN)    [<0026aee8>] arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
> (XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
> (XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
> (XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
> (XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c
> 
> The interrupts will be disabled by the state machine in stop_machine_run(),
> hence why the ASSERT is hit.
> 
> For now the patch extending the checks has been reverted, but it would
> be good to re-introduce it (allocation with interrupts disabled is not
> desirable).
> 
> So move the re-mapping of Xen to the caller of stop_machine_run().
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> Cc: David Vrabel <dvrabel@amazon.co.uk>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> 
> I managed to successfully boot Xen with this patch and dropping the
> revert.
> ---
>  xen/arch/arm/alternative.c | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
> index 237c4e564209..f03cd943c636 100644
> --- a/xen/arch/arm/alternative.c
> +++ b/xen/arch/arm/alternative.c
> @@ -170,7 +170,7 @@ static int __apply_alternatives(const struct alt_region *region,
>   * We might be patching the stop_machine state machine, so implement a
>   * really simple polling protocol here.
>   */
> -static int __apply_alternatives_multi_stop(void *unused)
> +static int __apply_alternatives_multi_stop(void *xenmap)
>  {
>      static int patched = 0;
>  
> @@ -185,22 +185,9 @@ static int __apply_alternatives_multi_stop(void *unused)
>      {
>          int ret;
>          struct alt_region region;
> -        mfn_t xen_mfn = virt_to_mfn(_start);
> -        paddr_t xen_size = _end - _start;
> -        unsigned int xen_order = get_order_from_bytes(xen_size);
> -        void *xenmap;
>  
>          BUG_ON(patched);
>  
> -        /*
> -         * The text and inittext section are read-only. So re-map Xen to
> -         * be able to patch the code.
> -         */
> -        xenmap = __vmap(&xen_mfn, 1U << xen_order, 1, 1, PAGE_HYPERVISOR,
> -                        VMAP_DEFAULT);
> -        /* Re-mapping Xen is not expected to fail during boot. */
> -        BUG_ON(!xenmap);
> -
>          region.begin = __alt_instructions;
>          region.end = __alt_instructions_end;
>  
> @@ -208,8 +195,6 @@ static int __apply_alternatives_multi_stop(void *unused)
>          /* The patching is not expected to fail during boot. */
>          BUG_ON(ret != 0);
>  
> -        vunmap(xenmap);
> -
>          /* Barriers provided by the cache flushing */
>          write_atomic(&patched, 1);
>      }
> @@ -224,14 +209,29 @@ static int __apply_alternatives_multi_stop(void *unused)
>  void __init apply_alternatives_all(void)
>  {
>      int ret;
> +    mfn_t xen_mfn = virt_to_mfn(_start);
> +    paddr_t xen_size = _end - _start;
> +    unsigned int xen_order = get_order_from_bytes(xen_size);
> +    void *xenmap;
>  
>      ASSERT(system_state != SYS_STATE_active);
>  
> +    /*
> +     * The text and inittext section are read-only. So re-map Xen to
> +     * be able to patch the code.
> +     */
> +    xenmap = __vmap(&xen_mfn, 1U << xen_order, 1, 1, PAGE_HYPERVISOR,
> +                    VMAP_DEFAULT);
> +    /* Re-mapping Xen is not expected to fail during boot. */
> +    BUG_ON(!xenmap);
> +
>  	/* better not try code patching on a live SMP system */
> -    ret = stop_machine_run(__apply_alternatives_multi_stop, NULL, NR_CPUS);
> +    ret = stop_machine_run(__apply_alternatives_multi_stop, xenmap, NR_CPUS);
>  
>      /* stop_machine_run should never fail at this stage of the boot */
>      BUG_ON(ret);
> +
> +    vunmap(xenmap);
>  }
>  
>  int apply_alternatives(const struct alt_instr *start, const struct alt_instr *end)
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Tue Apr 26 23:37:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Apr 2022 23:37:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314241.532205 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njUkj-0002ml-QL; Tue, 26 Apr 2022 23:37:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314241.532205; Tue, 26 Apr 2022 23:37:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njUkj-0002me-N8; Tue, 26 Apr 2022 23:37:53 +0000
Received: by outflank-mailman (input) for mailman id 314241;
 Tue, 26 Apr 2022 23:37:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IJm2=VE=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njUki-0002mD-G0
 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2022 23:37:52 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e2c01ce3-c5b9-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 01:37:51 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 07DEFB8239F;
 Tue, 26 Apr 2022 23:37:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3803FC385A0;
 Tue, 26 Apr 2022 23:37:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2c01ce3-c5b9-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651016268;
	bh=YE9YLQzw9ENo9x7H0w3OgmMdjFjl9v8cSbC2PgqSlCk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=OX+a6NR9mzlXjwCyN8c8yla5kNPzkSYu5EogDzLExI+1ubQNO4VZqf40PRiAswlAz
	 th1V7+UtCbqvlKJJdZc1ydBkZf5k/qAc8q67jCYep7Jv1JgEyUryWTYzC4PoseBtRk
	 33LGNnu2rFwJ06I1Xm09Z3+BdThfzc77VM/EJvIluB3Q6A2/vjJX2q6PQGrEEjayq+
	 /fVYxPEmfI7bh3TdnJMaUWG3Z/BeP2whkVhzDRhqtYrT4b50Mcmq2T9GPI6smCAxrK
	 Yk6ZakKseFp8/goDjLHB9EEiZ/UAVZHsFNEzgi+IuWYhRt/mSuXrftfahuO0NqhQef
	 7uXXwLTo9++7w==
Date: Tue, 26 Apr 2022 16:37:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
cc: David Vrabel <dvrabel@cantab.net>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, George Dunlap <George.Dunlap@citrix.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
    David Vrabel <dvrabel@amazon.co.uk>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap
 alloc/free
In-Reply-To: <cd228d72-59ab-087e-92f8-c056a1478e15@citrix.com>
Message-ID: <alpine.DEB.2.22.394.2204261635490.915916@ubuntu-linux-20-04-desktop>
References: <20220425132801.1076759-1-dvrabel@cantab.net> <f5a45b8e-644d-15aa-951f-aa6d89ce4c5b@suse.com> <ecb4876e-c6d4-4bff-d964-92af83d39dff@xen.org> <0b7c4df3-e6f2-7791-4e8e-9655eb8c6f6f@cantab.net> <cd228d72-59ab-087e-92f8-c056a1478e15@citrix.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1498627440-1651016269=:915916"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1498627440-1651016269=:915916
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Tue, 26 Apr 2022, Andrew Cooper wrote:
> > Can my (personal) GitLab be added as a Developer to the Xen Project
> > group? I think this is the intended way for people to run the CI
> > pipelines on their own branches.
> 
> It is.  Username?

David, let us know if you have any issues with gitlab. Once added, you
should be able to trigger gitlab-ci runs, which include 3 ARM runtime
tests dom0 and dom0less. You should be able to see the failures with
your original patch and the failure being fixed with Julien's patch.
--8323329-1498627440-1651016269=:915916--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 00:35:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 00:35:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314247.532216 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njVeY-0000nf-AK; Wed, 27 Apr 2022 00:35:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314247.532216; Wed, 27 Apr 2022 00:35:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njVeY-0000nY-69; Wed, 27 Apr 2022 00:35:34 +0000
Received: by outflank-mailman (input) for mailman id 314247;
 Wed, 27 Apr 2022 00:35:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njVeX-0000nO-QS; Wed, 27 Apr 2022 00:35:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njVeX-0001J2-Ou; Wed, 27 Apr 2022 00:35:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njVeX-0000fz-7L; Wed, 27 Apr 2022 00:35:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njVeX-000827-6v; Wed, 27 Apr 2022 00:35:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ubgtiMLWlfb0/Sc4HbjrFvtJywFi9tegOIMlhB1JhpA=; b=CFA7elmZ8ZPsG8Qu/H/RcYWuuZ
	UOrcr2az+n0CT3jNaRlwGhU226dZLQB7BczDHAYNm/QK0lo7SuIvxIET/72WBUT0GFdx4zuz9BfYx
	ELkrmBgRVN7d6DnANbQY7331aKWh6O1lcjaoUCBD3K6SVZQGRu8a+/uCvI9WS1OpofuA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169759-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169759: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 00:35:33 +0000

flight 169759 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169759/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  651 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   23 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 00:38:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 00:38:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314255.532227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njVhS-0001Q6-Oq; Wed, 27 Apr 2022 00:38:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314255.532227; Wed, 27 Apr 2022 00:38:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njVhS-0001Pz-LL; Wed, 27 Apr 2022 00:38:34 +0000
Received: by outflank-mailman (input) for mailman id 314255;
 Wed, 27 Apr 2022 00:38:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=83Ve=VF=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njVhS-0001Pt-3B
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 00:38:34 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5cae34aa-c5c2-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 02:38:32 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6926A61A71;
 Wed, 27 Apr 2022 00:38:30 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57BA8C385A4;
 Wed, 27 Apr 2022 00:38:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cae34aa-c5c2-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651019909;
	bh=Dbm/WTOJGlznwBy/NNY7zd7knuH35fdhKZhJ4BJatG8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Cxen2MNArQ1ZpLg+VDBNQ+0KK+SUmpjcB8it0Bx8BwEb/ZxOFOpL4yTAtd1sVOm4j
	 AMsZpAc22oVyPv5nJgr/Aw11XXr1RppnaN0k4M9bkXQFe5IAdCYWzmAmNfkHpcBdlg
	 Renf9tphxJ+MAOm1Ly+wRWZH1rV1UFAhCV5PGZwe27IeLnrO4yPP/GHqeJ9AbTrNgu
	 2N597OL4liwDm7sN0XLDLOrptlF8RbAC0ZmlABUgDaFCmudBgIrmRK2Ri4aIRoQ1gR
	 IM1OlE5uoflsD0EHCUYm7sdtHeaU3T14dKmdJzPwrg9qJyLUPmLES3P/I6hp3lKF2B
	 9UhuNv/2YQelg==
Date: Tue, 26 Apr 2022 17:38:28 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <bertrand.marquis@arm.com>
cc: xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make
 rules
In-Reply-To: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com>
Message-ID: <alpine.DEB.2.22.394.2204261716370.915916@ubuntu-linux-20-04-desktop>
References: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 26 Apr 2022, Bertrand Marquis wrote:
> cppcheck can be used to check Xen code quality.
> 
> To create a report do "make cppcheck" on a built tree adding any options
> you added during the process you used to build xen (like CROSS_COMPILE
> or XEN_TARGET_ARCH). This will generate an xml report xen-cppcheck.xml.
> 
> To create a html report do "make cppcheck-html" in the same way and a
> full report to be seen in a browser will be generated in
> cppcheck-htmlreport/index.html.
> 
> For better results it is recommended to build your own cppcheck from the
> latest sources that you can find at [1].
> Development and result analysis has been done with cppcheck 2.7.
> 
> The Makefile rule is searching for all C files which have been compiled
> (ie which have a generated .o file) and is running cppcheck on all of
> them using the current configuration of xen so only the code actually
> compiled is checked.
> 
> A new tool is introduced to merge all cppcheck reports into one global
> report including all findings and removing duplicates.
> 
> Some extra variables can be used to customize the report:
> - CPPCHECK can be used to give the full path to the cppcheck binary to
> use (default is to use the one from the standard path).
> - CPPCHECK_HTMLREPORT can be used to give the full path to
> cppcheck-htmlreport (default is to use the one from the standard path).
> 
> This has been tested on several arm configurations (x86 should work but
> has not been tested).
> 
> [1] https://cppcheck.sourceforge.io/
> 
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

I tested the patch and it works fine for me.

Tested-by: Stefano Stabellini <sstabellini@kernel.org>

In regard to the review, merge_cppcheck_reports.py looks OK now. It
handles all the exceptions and errors properly. I don't have any
comments on the Makefile changes, they look OK.

For the headers (processor.h, config.h, kconfig.h), it is not ideal to
have #ifdef CPPCHECK but given that they are the only changes needed to
be able to do a full cppcheck scan of the Xen source, I'd say that it is
a small price worth paying.

So overall:

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v3:
> - add more checks in merge script and catch all possible exception from
> the xml parser (suggested by Stefano)
> Changes in v2:
> - catch parsing errors during merge and tell the user to update cppcheck
> - fix alignments in Makefile
> - use srctree and objtree instead of BASEDIR
> - remove SCTLR invalid change
> - add a check of cppcheck version and mandate version 2.7 or greater
> - rework a bit the merge script to make it faster and display progress
> ---
>  .gitignore                           |  3 +
>  xen/Makefile                         | 84 ++++++++++++++++++++++++++-
>  xen/arch/arm/include/asm/processor.h |  2 +
>  xen/include/xen/config.h             |  4 ++
>  xen/include/xen/kconfig.h            |  5 ++
>  xen/tools/merge_cppcheck_reports.py  | 86 ++++++++++++++++++++++++++++
>  6 files changed, 182 insertions(+), 2 deletions(-)
>  create mode 100755 xen/tools/merge_cppcheck_reports.py
> 
> diff --git a/.gitignore b/.gitignore
> index c6d2c4b4f1..18ef56a780 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -7,6 +7,7 @@
>  *.o
>  *.d
>  *.d2
> +*.c.cppcheck
>  *.opic
>  *.a
>  *.so
> @@ -296,6 +297,7 @@ xen/.banner
>  xen/.config
>  xen/.config.old
>  xen/.xen.elf32
> +xen/xen-cppcheck.xml
>  xen/System.map
>  xen/arch/x86/boot/mkelf32
>  xen/arch/x86/boot/cmdline.S
> @@ -316,6 +318,7 @@ xen/arch/*/efi/runtime.c
>  xen/arch/*/include/asm/asm-offsets.h
>  xen/common/config_data.S
>  xen/common/config.gz
> +xen/cppcheck-htmlreport
>  xen/include/headers*.chk
>  xen/include/compat/*
>  xen/include/config/
> diff --git a/xen/Makefile b/xen/Makefile
> index ec34524ed2..255360440e 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -449,7 +449,7 @@ endif # need-config
>  
>  __all: build
>  
> -main-targets := build install uninstall clean distclean MAP
> +main-targets := build install uninstall clean distclean MAP cppcheck cppcheck-html
>  .PHONY: $(main-targets)
>  ifneq ($(XEN_TARGET_ARCH),x86_32)
>  $(main-targets): %: _% ;
> @@ -537,15 +537,17 @@ _clean:
>  	$(Q)$(MAKE) $(clean)=tools/kconfig
>  	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
>  		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
> -		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
> +		-o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \
>  		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
>  	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map
>  	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
>  	rm -f .banner .allconfig.tmp include/xen/compile.h
> +	rm -f xen-cppcheck.xml
>  
>  .PHONY: _distclean
>  _distclean: clean
>  	rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS .config source
> +	rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR)
>  
>  $(TARGET).gz: $(TARGET)
>  	gzip -n -f -9 < $< > $@.new
> @@ -619,6 +621,84 @@ cloc:
>  	    done; \
>  	done | cloc --list-file=-
>  
> +# What cppcheck command to use.
> +# To get proper results, it is recommended to build cppcheck manually from the
> +# latest source and use CPPCHECK to give the full path to the built version.
> +CPPCHECK ?= cppcheck
> +
> +# What cppcheck-htmlreport to use.
> +# If you give the full path to a self compiled cppcheck, this should be set
> +# to the full path to cppcheck-html in the htmlreport directory of cppcheck.
> +# On recent distribution, this is available in the standard path.
> +CPPCHECK_HTMLREPORT ?= cppcheck-htmlreport
> +
> +# By default we generate the report in cppcheck-htmlreport directory in the
> +# build directory. This can be changed by giving a directory in this variable.
> +CPPCHECK_HTMLREPORT_OUTDIR ?= cppcheck-htmlreport
> +
> +# Compile flags to pass to cppcheck:
> +# - include directories and defines Xen Makefile is passing (from CFLAGS)
> +# - include config.h as this is passed directly to the compiler.
> +# - define CPPCHECK as we use to disable or enable some specific part of the
> +#   code to solve some cppcheck issues.
> +# - explicitely enable some cppcheck checks as we do not want to use "all"
> +#   which includes unusedFunction which gives wrong positives as we check file
> +#   per file.
> +#
> +# Compiler defines are in compiler-def.h which is included in config.h
> +#
> +CPPCHECKFLAGS := -DCPPCHECK --max-ctu-depth=10 \
> +                 --enable=style,information,missingInclude \
> +                 --include=$(srctree)/include/xen/config.h \
> +                 -I $(srctree)/xsm/flask/include \
> +                 -I $(srctree)/include/xen/libfdt \
> +                 $(filter -D% -I%,$(CFLAGS))
> +
> +# We need to find all C files (as we are not checking assembly files) so
> +# we find all generated .o files which have a .c corresponding file.
> +CPPCHECKFILES := $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c, \
> +                 $(filter-out $(objtree)/tools/%, \
> +                 $(shell find $(objtree) -name "*.o"))))
> +
> +quiet_cmd_cppcheck_xml = CPPCHECK $(patsubst $(srctree)/%,%,$<)
> +cmd_cppcheck_xml = $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \
> +                   --output-file=$@ $<
> +
> +quiet_cmd_merge_cppcheck_reports = CPPCHECK-MERGE $@
> +cmd_merge_cppcheck_reports = $(srctree)/tools/merge_cppcheck_reports.py $^ $@
> +
> +quiet_cmd_cppcheck_html = CPPCHECK-HTML $<
> +cmd_cppcheck_html = $(CPPCHECK_HTMLREPORT) --file=$< --source-dir=$(srctree) \
> +                    --report-dir=$(CPPCHECK_HTMLREPORT_OUTDIR) --title=Xen
> +
> +PHONY += _cppcheck _cppcheck-html cppcheck-version
> +
> +_cppcheck-html: xen-cppcheck.xml
> +	$(call if_changed,cppcheck_html)
> +
> +_cppcheck: xen-cppcheck.xml
> +
> +xen-cppcheck.xml: $(patsubst $(srctree)/%.c,$(objtree)/%.c.cppcheck,$(CPPCHECKFILES))
> +ifeq ($(CPPCHECKFILES),)
> +	$(error Please build Xen before running cppcheck)
> +endif
> +	$(call if_changed,merge_cppcheck_reports)
> +
> +$(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h $(objtree)/include/generated/compiler-def.h | cppcheck-version
> +	$(call if_changed,cppcheck_xml)
> +
> +cppcheck-version:
> +ifeq ($(shell which $(CPPCHECK)),)
> +	$(error Cannot find cppcheck executable: $(CPPCHECK))
> +endif
> +ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1)
> +	$(error Please upgrade your cppcheck to version 2.7 or greater)
> +endif
> +
> +# Put this in generated headers this way it is cleaned by include/Makefile
> +$(objtree)/include/generated/compiler-def.h:
> +	$(Q)$(CC) -dM -E -o $@ - < /dev/null
> +
>  endif #config-build
>  endif # need-sub-make
>  
> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
> index 852b5f3c24..ef37cfa16f 100644
> --- a/xen/arch/arm/include/asm/processor.h
> +++ b/xen/arch/arm/include/asm/processor.h
> @@ -219,9 +219,11 @@
>                           SCTLR_Axx_ELx_A    | SCTLR_Axx_ELx_C   |\
>                           SCTLR_Axx_ELx_WXN  | SCTLR_Axx_ELx_EE)
>  
> +#ifndef CPPCHECK
>  #if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xffffffffffffffffUL
>  #error "Inconsistent SCTLR_EL2 set/clear bits"
>  #endif
> +#endif
>  
>  #endif
>  
> diff --git a/xen/include/xen/config.h b/xen/include/xen/config.h
> index 85c6f59be9..d888b2314d 100644
> --- a/xen/include/xen/config.h
> +++ b/xen/include/xen/config.h
> @@ -7,6 +7,10 @@
>  #ifndef __XEN_CONFIG_H__
>  #define __XEN_CONFIG_H__
>  
> +#ifdef CPPCHECK
> +#include <generated/compiler-def.h>
> +#endif
> +
>  #include <xen/kconfig.h>
>  
>  #ifndef __ASSEMBLY__
> diff --git a/xen/include/xen/kconfig.h b/xen/include/xen/kconfig.h
> index 4d58c5bb3c..a717b0819c 100644
> --- a/xen/include/xen/kconfig.h
> +++ b/xen/include/xen/kconfig.h
> @@ -8,6 +8,10 @@
>   * these only work with boolean option.
>   */
>  
> +/* cppcheck is failing to parse the macro so use a dummy one */
> +#ifdef CPPCHECK
> +#define IS_ENABLED(option) option
> +#else
>  /*
>   * Getting something that works in C and CPP for an arg that may or may
>   * not be defined is tricky.  Here, if we have "#define CONFIG_BOOGER 1"
> @@ -27,5 +31,6 @@
>   * otherwise.
>   */
>  #define IS_ENABLED(option) config_enabled(option)
> +#endif
>  
>  #endif /* __XEN_KCONFIG_H */
> diff --git a/xen/tools/merge_cppcheck_reports.py b/xen/tools/merge_cppcheck_reports.py
> new file mode 100755
> index 0000000000..1c1b63ba56
> --- /dev/null
> +++ b/xen/tools/merge_cppcheck_reports.py
> @@ -0,0 +1,86 @@
> +#!/usr/bin/env python
> +
> +"""
> +This script acts as a tool to merge XML files created by cppcheck.
> +Usage:
> +    merge_cppcheck_reports.py [FILES] [OUTPUT]
> +
> +    FILES  - list of XML files with extension .cppcheck
> +    OUTPUT - file to store results (with .xml extension).
> +             If not specified, the script will print results to stdout.
> +"""
> +
> +import sys
> +from xml.etree import ElementTree
> +
> +def elements_equal(el1, el2):
> +    if type(el1) != type(el2): return False
> +
> +    if el1.find('location') is None: return False
> +    if el2.find('location') is None: return False
> +
> +    el1_location = str(el1.find('location').attrib)
> +    el2_location = str(el2.find('location').attrib)
> +
> +    if el1_location != el2_location: return False
> +
> +    return True
> +
> +def contain_element(new, lst):
> +    for elem in lst:
> +        if elements_equal(new, elem):
> +            return True
> +    return False
> +
> +def merge(files):
> +    try:
> +        result_xml_root = ElementTree.parse(files[0]).getroot()
> +    except:
> +        print("Xml parsing error in %s\n" % (files[0]))
> +        print("Please upgrade your cppcheck to version 2.7 or greater")
> +        sys.exit(1)
> +    insert_point = result_xml_root.findall("errors")[0]
> +    curr = 1
> +    total = len(files)
> +    numelem = len(insert_point)
> +    for xml_file in files[1:]:
> +        try:
> +            xml_root = ElementTree.parse(xml_file).getroot()
> +        except:
> +            print("Xml parsing error in %s\n" % (xml_file))
> +            print("Please upgrade your cppcheck to version 2.7 or greater")
> +            sys.exit(1)
> +        curr_elem_list = list(insert_point)
> +        new_elem_list = list(xml_root.findall("errors")[0])
> +        for xml_error_elem in new_elem_list:
> +            if not contain_element(xml_error_elem, curr_elem_list):
> +                insert_point.insert(1,xml_error_elem)
> +                numelem = numelem + 1
> +        curr = curr + 1
> +        sys.stdout.write('\r')
> +        sys.stdout.write(" %d / %d" % (curr,total))
> +        sys.stdout.flush()
> +
> +    sys.stdout.write('\r\n')
> +    print("Done: %d elements" % (numelem))
> +    return result_xml_root
> +
> +def run():
> +    files = []
> +    output = None
> +    for i in sys.argv[1:]:
> +        output = i if '.xml' in i else None
> +        files.append(i) if '.cppcheck' in i else None
> +
> +    result = merge(files)
> +
> +    if result is None:
> +        return
> +
> +    if output is not None:
> +        ElementTree.ElementTree(result).write(output)
> +    else:
> +        print(ElementTree.tostring(result).decode('utf-8'))
> +
> +if __name__ == '__main__':
> +    run()
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 00:51:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 00:51:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314262.532237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njVuL-0003kt-36; Wed, 27 Apr 2022 00:51:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314262.532237; Wed, 27 Apr 2022 00:51:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njVuL-0003km-0A; Wed, 27 Apr 2022 00:51:53 +0000
Received: by outflank-mailman (input) for mailman id 314262;
 Wed, 27 Apr 2022 00:51:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njVuK-0003kc-75; Wed, 27 Apr 2022 00:51:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njVuK-0001cQ-1I; Wed, 27 Apr 2022 00:51:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njVuJ-000289-Og; Wed, 27 Apr 2022 00:51:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njVuJ-0004ay-OA; Wed, 27 Apr 2022 00:51:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6zAfma9MrX7PMcFHIr61+1tjqOBkpOtkapQwoZxoaJ8=; b=X0VAQC1HuCGpP9rEmp2UkFjuxl
	S+kM1ZJqUN2cTFYP5S7BjeOdiTYyj0Oz16Q5ebRx30H7RNoTePsdyUH/AxL0bTkyIyHMyfGZbbehz
	Uv8g1BH4OZ+wWNfcNYQgj2eego+bL3uXZWOo31+wprpaifVePN92P6QT6BYeawxHfl4g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169749-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169749: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-shadow:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=80a172de5592b5c33aa6bc30da6f16c4ad1ae390
X-Osstest-Versions-That:
    qemuu=a1755db71e34df016ffc10aa0727360aae2c6036
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 00:51:51 +0000

flight 169749 qemu-mainline real [real]
flight 169760 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169749/
http://logs.test-lab.xenproject.org/osstest/logs/169760/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-shadow 20 guest-localmigrate/x10 fail pass in 169760-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 169725

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169725
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169725
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169725
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169725
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169725
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169725
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169725
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169725
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                80a172de5592b5c33aa6bc30da6f16c4ad1ae390
baseline version:
 qemuu                a1755db71e34df016ffc10aa0727360aae2c6036

Last test of basis   169725  2022-04-26 02:47:03 Z    0 days
Testing same since   169749  2022-04-26 17:07:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Eugenio Pérez <eperezma@redhat.com>
  Jason Wang <jasowang@redhat.com>
  Laurent Vivier <laurent@vivier.eu>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Weil <sw@weilnetz.de>
  Thomas Huth <thuth@redhat.com>
  Yuval Shaia <yuval.shaia.ml@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   a1755db71e..80a172de55  80a172de5592b5c33aa6bc30da6f16c4ad1ae390 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 01:01:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 01:01:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314270.532248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njW3M-0006cs-0E; Wed, 27 Apr 2022 01:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314270.532248; Wed, 27 Apr 2022 01:01:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njW3L-0006bz-Sf; Wed, 27 Apr 2022 01:01:11 +0000
Received: by outflank-mailman (input) for mailman id 314270;
 Wed, 27 Apr 2022 01:01:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njW3K-0005we-BU; Wed, 27 Apr 2022 01:01:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njW3K-0004Qh-9j; Wed, 27 Apr 2022 01:01:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njW3K-0002e6-2r; Wed, 27 Apr 2022 01:01:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njW3K-0002Cz-2M; Wed, 27 Apr 2022 01:01:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sMLa2ffsYJUIECBoxWbAnCloN4MtwZA2IJ8nOQDySGM=; b=PALeEeFtqSQhrfTOuRrhPysbXo
	JmJapdewObk+5BuRexsNs6/lp+FQ3IEbbkv4hS8S1dxrgH3NKMSuePGfopVyij5kcpu8XCnFIxOHP
	Gi1InVeT+12GwHZBE5+x/8ChsSLzINzO2iWwkjiXkoJj+aDEoJzLRpanD9g1rLd/kEJI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169761-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169761: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 01:01:10 +0000

flight 169761 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169761/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   56 days  652 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   24 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 02:24:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 02:24:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314278.532260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njXLj-0003NT-6N; Wed, 27 Apr 2022 02:24:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314278.532260; Wed, 27 Apr 2022 02:24:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njXLj-0003NL-0C; Wed, 27 Apr 2022 02:24:15 +0000
Received: by outflank-mailman (input) for mailman id 314278;
 Wed, 27 Apr 2022 02:24:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njXLh-0003N4-7p; Wed, 27 Apr 2022 02:24:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njXLh-0001dT-64; Wed, 27 Apr 2022 02:24:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njXLg-0006QB-NN; Wed, 27 Apr 2022 02:24:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njXLg-0004sr-Mr; Wed, 27 Apr 2022 02:24:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NCbfmIAhNugcrd98BWjWc9mS9tR+ryuXyftY80GjV70=; b=c5cC+vU2jgVGAH0/fx2mv2+pon
	zlRP0bNPeJhkFdr3e4RfFCn8dL1GGX5/3EsfkTgOhb0seOc7MOXamfm2dWZ7a7EZgeJ2ndP1Eoe0e
	072mM41AKWWD+yRKITS8+SbNoTuQZlgpfAOIJyz+0TaQCKsvbZzpBZr85ThK6DNys+JM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169763-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169763: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 02:24:12 +0000

flight 169763 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169763/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  653 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   25 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 02:57:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 02:57:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314287.532270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njXrZ-0006nu-Qm; Wed, 27 Apr 2022 02:57:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314287.532270; Wed, 27 Apr 2022 02:57:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njXrZ-0006nn-Nt; Wed, 27 Apr 2022 02:57:09 +0000
Received: by outflank-mailman (input) for mailman id 314287;
 Wed, 27 Apr 2022 02:57:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Q6ah=VF=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1njXrY-0006nh-UH
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 02:57:09 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on060d.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::60d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b9120876-c5d5-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 04:57:07 +0200 (CEST)
Received: from AS8PR04CA0122.eurprd04.prod.outlook.com (2603:10a6:20b:127::7)
 by AM0PR08MB3874.eurprd08.prod.outlook.com (2603:10a6:208:108::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 27 Apr
 2022 02:57:02 +0000
Received: from VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:127:cafe::c1) by AS8PR04CA0122.outlook.office365.com
 (2603:10a6:20b:127::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23 via Frontend
 Transport; Wed, 27 Apr 2022 02:57:02 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT020.mail.protection.outlook.com (10.152.18.242) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 02:57:02 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Wed, 27 Apr 2022 02:57:01 +0000
Received: from fdcfb8b21f48.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9DC56541-3E2D-488E-A026-C58694ADF2F4.1; 
 Wed, 27 Apr 2022 02:56:56 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fdcfb8b21f48.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 02:56:56 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by DBBPR08MB4822.eurprd08.prod.outlook.com (2603:10a6:10:da::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 02:56:48 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 02:56:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9120876-c5d5-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ZGr+4liXdb4ROwukegBJSPuvtq3fqY0mGWmBEd9TmEYx6y65YLpQQYT4OcOn5SGUugmI2AZ5vGj3e5LK3Y/rEF9hWpIBqi6UJ5CWUxlWIQnNJswAnm34Pl8fP+MShOSMDzS7KOmJqFLE//VoFaXTNnStvxlUz+aObCwbQ2zJWMKDSZ1qMHMstZf7Ho71OhOy1JZFO4H1eCo0sssxt0xc9xWNvlrNwtrCkgjkol2O3IT4altq5ALBUzBEIBGJLuU9MfkO+EzjuqchA+eQ17LFk27lhVPYnvEsMp/7f85JbBf7uHNjMYaGY42DJwJ71Wkx72tow4eYhqErJ/NbGCIm2g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+eiHFMmyAILD3D274G2StM4c98d3voMhn9ruOzklON8=;
 b=FxlkGlyAQ5DPobpSycKLkLyMKGKfsuHeUKtuCY9uTNPVbscYE1vygqvHy1QTi9PGNg/wA8Cxz//maC4EbyWdMds6FmtYfwCjwbesqroYOxQB7WzWHiIIuDZfKXlgqlQcX2PQsj5Lwes731wlvhIYwR/rM0sRyvURSMoGnU61rqkOxocC4Fful9FY94RtP6JYbEDDfvvP2Vm+uIVQUk4PSwcZc9IzCacXVI3+1FvtlxGUcRrljoDjP2pqG6ceuiGCtkAq5JEPRpYzm3JQex+UiSIaoq/g/IB6SapaI6lIjUbE7HBbI/VJZwWPxzN4/nCs6bZdLEKF6Y3R9h39lJ40GQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+eiHFMmyAILD3D274G2StM4c98d3voMhn9ruOzklON8=;
 b=4yvd5ZCC5mZRxZsffTWJckUj7E17a793KGEbx6yzbgM1tMuKNE5YmHGVBxf547Tbai4Mozf4XBY8T1txrSgIlNnbuZVXnShlyxq0/f0muHRxUY2oHeBZYQrziTZnxP9KIftx6p8DXcCCPqMku0SKNdmaq6PJAXWN4rI50XmIJ4o=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E7aHnPdJoazaEZdN8bq6xfGG5U449DmZws6qM1GSoRpciLs2ULZ7kjyqN7E4tibRUlqQKvL/dYfprL/y53pIc2FrmNkH6xh0Cz/hqqZkfnJhQPInc7sP2y22+b+6J2KbpPL86yiQfve1eX9+74HB8U/XPO24Es0YzAovKtFHeAcueqh3dFg9qdY+9CPmhHGs1xSsYdn9HW/SfFLMrkXrxaYaZqxGQlTDwuQUByZRJ3EZNeOTiXCUfwM1euumN8m1iofOJ/UBmH77pw9mVUA4SFXm6vJ4u9prRF3whuAmVmRFI8OPJ4fsI5KEO0iRfDetfZS8DsLR0W3QkdeqW3U23g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+eiHFMmyAILD3D274G2StM4c98d3voMhn9ruOzklON8=;
 b=EqMvgq17B8ICDG7ZkZx9p8+9ElNmJpi6jY9sPjKaOgbJTYdEqAmajhL7xgjfjP/7qKT9YK/bvDxUDuaTAoEF664hb6Og08bfKLK9myEBDVffGDKyJQJ+LJtl/Th1A7aSSAxVhL5Kv1WDsKetLosoJ64mIAGtEN2/LyxS3R28HJ5Fx2Iv2BpXeQttvghHEpbHqePMSeiy10bQ8mibvVHqSKvJAuwHKwauX4IyvO7132YrhgvxhD2tbsUgAj9YjogBN9DUHO9+ctiiLbuJ1RPw+8waapZXTn8Kpld9t2TQgkpnrV3SxMbB8QSYwTG9o43bT2/fdAIsdSzWP+wiqsLEMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+eiHFMmyAILD3D274G2StM4c98d3voMhn9ruOzklON8=;
 b=4yvd5ZCC5mZRxZsffTWJckUj7E17a793KGEbx6yzbgM1tMuKNE5YmHGVBxf547Tbai4Mozf4XBY8T1txrSgIlNnbuZVXnShlyxq0/f0muHRxUY2oHeBZYQrziTZnxP9KIftx6p8DXcCCPqMku0SKNdmaq6PJAXWN4rI50XmIJ4o=
From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from
 x86 to common
Thread-Topic: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from
 x86 to common
Thread-Index: AQHYUwP3lRK/2WFhVk685C9kDsNXZq0B8EgAgAAdAwCAAEFBgIAAx9fQ
Date: Wed, 27 Apr 2022 02:56:47 +0000
Message-ID:
 <PAXPR08MB74202E608E9A967458664E7A9EFA9@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-3-wei.chen@arm.com>
 <3e5b9708-7732-a56c-f2e8-d5d39fd2093e@suse.com>
 <ed949bf4-ba9e-9ad7-b2fe-c63526ca42e5@arm.com>
 <413651ff-55a4-61cf-efed-7ac82f7c6723@suse.com>
In-Reply-To: <413651ff-55a4-61cf-efed-7ac82f7c6723@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: E096F2BC68C35D489F3FF3C3650CF201.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 7b45806c-ede2-4b63-62b6-08da27f99aac
x-ms-traffictypediagnostic:
	DBBPR08MB4822:EE_|VE1EUR03FT020:EE_|AM0PR08MB3874:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB387483A9B3CF8A4D4B318FC69EFA9@AM0PR08MB3874.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 AYU7rvYAX/95ANRIuo+SBB2GZHHMJ0RpoO9YXSeqPNN+iAU3muHCZ6EJ6/MLQuLFw97xok74eJPq33fNXuVsyjFVIjZd1jJywzVzEjmThUN5BzKDj6bDv4/R+tTE5zTy9ZMD2gqTy9Ppx7+CdrCab7lNzhVdgDkAIy0W0ERFQERiiB6+VQ3SzmnOvwAmVUjui+9BgNlLLr4ZXp5SqSY7ZBtt+bZhOnpb33RSJjVixreybPJSAcGv/AEdMnQRspEVHj2jwomu1+wP82d7QgKjEQdef3eog7odt8TaWwzTuArmMQBN8CHM7QhH0v0aaXvLTjcdkTdqJ6EDtSEVyTEj+VlguS8WI77YMKH58S+POFGR7/WR2OgHOpObyWrRq2XpwR2N7iRzFKQPGE+brKKUk4CpWnEem6lokmGkRLsIdgjvBNvsD9gbWkU4bHxwzcdIvedjCxmuvXXgKKjdNI7vaG+pF9doxB6+bgZPTkdTQF6Zc6TVH2z2ZfQfyJ17+D+Tdf8otr4Teb6Ziu/vvjjTbgjcIA6fTQXMGQ7csywcMscMZcKvud6DiMeWIAWZzoA0olg2V+fkIycUog38F1HinKavDIbAHuuMjFu4+Al0DTmOc7ABBUJ+VNB2/6cff5oIKOvuLTCmrKIPPfvwUIvspjPwJXR3eSzRsuDvw6VHI9QZNpGBBZwSJAgB6u57wXsUm3mocEbKBxqmJQ9B4hPESA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(9686003)(5660300002)(83380400001)(26005)(8936002)(52536014)(54906003)(6916009)(33656002)(6506007)(186003)(53546011)(7696005)(122000001)(38100700002)(2906002)(508600001)(38070700005)(86362001)(71200400001)(55016003)(66476007)(76116006)(8676002)(4326008)(66946007)(66556008)(64756008)(66446008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4822
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	dee6a041-c748-47eb-f8d8-08da27f99208
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JoCj1iP74FWdaNPH7zVoIgGhSMJ7cRNBV/N0M7eFCQriH6Up3OeGpjSuWNMl2zt9jekKW27sjQR5jjPECdyfWy/Xq8myLVGl5WouvbHxxwc0eAKgU9yXQ89Ri6M5BUmtR/ywoHOgYojENEk87vu+Orl4Q7++1ioSnoZJr4U7v74TPlNodBxMkcuakVGBImquFRwdJiInEtVAZlk/RjLe3d/9YdWURsx2XOHWhLboScKWUL6OgT9CWJGql+c4sCi+vgKCrfSAEQ3c8pNCSL9WLVqRO8ReNopwwxgWF3fLD/lbOP2HUsQZWDsOUObdCgTH/yLKmdJk30c/m2/42+n2Brh95xJL+YIgJn+GJiQZWYKkt1yELOJP1kP5og1nXzNmSlTX/sGampgqZ9QuKR+TLKHaIHwhl1oNv0rQ1O7Ufcid/GEIM23KUiGVivRROYCmWuZjG6F1UDJJsXd2kIXuwA/GNIfBDLSXRKOwt+I/h0VwySER0dE4UIXVOVyuh1pBDnBmqOpp51ZTFrkRrUlXnvG8LQmk8TmberY/4NDAuLlBVf4MyWTc42oGyU0kVRdoj3N9/EvWHAdvxLXwn6MfV+pSyZPlMfbpQyHWi96kUZ2qfrLw4OPWf8UatMSSmcqCqsJ3Wcu7uY1H5pFUi7c6hYQykAJ6UZeE39VMoQfIs42e9HlAR/AWHTDpcsfF4lVi
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(55016003)(508600001)(82310400005)(316002)(52536014)(33656002)(5660300002)(70206006)(8936002)(8676002)(83380400001)(336012)(81166007)(54906003)(47076005)(6862004)(4326008)(86362001)(70586007)(26005)(40460700003)(186003)(2906002)(356005)(36860700001)(6506007)(9686003)(7696005)(53546011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 02:57:02.0269
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b45806c-ede2-4b63-62b6-08da27f99aac
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3874

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDTmnIgyNuaXpSAyMjozMQ0K
PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47
IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4t
DQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIg
MDIvMTBdIHhlbi94ODY6IG1vdmUgcmV1c2FibGUgRUZJIHN0dWIgZnVuY3Rpb25zDQo+IGZyb20g
eDg2IHRvIGNvbW1vbg0KPiANCj4gT24gMjYuMDQuMjAyMiAxMjozNywgV2VpIENoZW4gd3JvdGU6
DQo+ID4gT24gMjAyMi80LzI2IDE2OjUzLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPj4gT24gMTgu
MDQuMjAyMiAxMTowNywgV2VpIENoZW4gd3JvdGU6DQo+ID4+PiBkaWZmIC0tZ2l0IGEveGVuL2Fy
Y2gveDg2L2VmaS9zdHViLmMgYi94ZW4vYXJjaC94ODYvZWZpL3N0dWIteDg2LmMNCj4gPj4+IHNp
bWlsYXJpdHkgaW5kZXggNzElDQo+ID4+PiByZW5hbWUgZnJvbSB4ZW4vYXJjaC94ODYvZWZpL3N0
dWIuYw0KPiA+Pj4gcmVuYW1lIHRvIHhlbi9hcmNoL3g4Ni9lZmkvc3R1Yi14ODYuYw0KPiA+Pj4g
aW5kZXggOTk4NDkzMjYyNi4uMmNkNWM4ZDRkYyAxMDA2NDQNCj4gPj4+IC0tLSBhL3hlbi9hcmNo
L3g4Ni9lZmkvc3R1Yi5jDQo+ID4+PiArKysgYi94ZW4vYXJjaC94ODYvZWZpL3N0dWIteDg2LmMN
Cj4gPj4NCj4gPj4gSSdtIG5vdCBoYXBweSB0byBzZWUgYSBmaWxlIG5hbWVkICp4ODYqLltjaF0g
dW5kZXIgeDg2Ly4gSSB0aGluayB0aGUNCj4gPj4geDg2IGZpbGUgd2FudHMgdG8gc2ltcGx5IGlu
Y2x1ZGUgdGhlIGNvbW1vbiBvbmUgKGFuZCB0aGUgc3ltbGlua2luZw0KPiA+PiBiZSBzdXBwcmVz
c2VkIHdoZW4gYSByZWFsIGZpbGUgYWxyZWFkeSBleGlzdHMpLiBOYW1pbmcgdGhlIGNvbW1vbg0K
PiA+PiBmaWxlIHN0dWItY29tbW9uLmMgd291bGRuJ3QgaGVscCwgYXMgYSBzaW1pbGFyIGFub21h
bHkgd291bGQgcmVzdWx0Lg0KPiA+Pg0KPiA+DQo+ID4gSG93IGFib3V0IHVzaW5nIHN0dWItYXJj
aC5jIHRvIGluZGljYXRlIHRoaXMgc3R1YiBmaWxlIG9ubHkgY29udGFpbnMNCj4gPiB0aGUgYXJj
aCBzcGVjaWZpYyBjb250ZW50cz8gSG93ZXZlciwgd2UgY2Fubm90IHByZWRpY3Qgd2hhdCBsaW5r
IGZpbGVzDQo+ID4gd2lsbCBiZSBjcmVhdGVkIGluIHRoaXMgZGlyZWN0b3J5IGluIHRoZSBmdXR1
cmUuIElmIHNvbWVvbmUgbmVlZHMgdG8NCj4gPiBjcmVhdGUgYSBzdHViLWFyY2guYyBsaW5rIGZp
bGUgaW4gdGhlIGZ1dHVyZSwgY2FuIHdlIHNvbHZlIGl0IGF0IHRoYXQNCj4gPiB0aW1lPyAgT3Ig
ZG8geW91IGhhdmUgYW55IHN1Z2dlc3Rpb25zPw0KPiANCj4gSSBkaWQgcHJvdmlkZSBteSBzdWdn
ZXN0aW9uLiBJIGRvIG5vdCBsaWtlIHN0dWItYXJjaC5jIGFueSBiZXR0ZXIgdGhhbg0KPiBzdHVi
LXg4Ni5jIG9yIHN0dWItY29tbW9uLmMuDQo+IA0KDQpXaXRoIG15IGxpbWl0ZWQgRW5nbGlzaCBs
ZXZlbCwgSSBjYW4gb25seSBzZWUgdGhhdCB5b3UgZG9uJ3QgbGlrZSB0aGlzLCBidXQNCkkgY2Fu
J3QgZ2V0IHdoYXQgeW91IHdhbnQgY2xlYXJseSBmcm9tIHlvdXIgY29tbWVudHMuIEkgY2FuIG9u
bHkgZ3Vlc3M6DQpGb3IgIng4NiBmaWxlIHdhbnRzIHRvIHNpbXBseSBpbmNsdWRlIHRoZSBjb21t
b24gb25lIjoNCjEuIERpZCB5b3UgbWVhbiwgeDg2IHN0aWxsIGtlZXBzIGl0IHN0dWIuYyBhbmQg
aW5jbHVkZXMgYWxsIGl0cyBvcmlnaW5hbA0KICAgY29udGVudHMuIFRoZSBjb21tb24vZWZpL3N0
dWIuYyBsaW5rIGJlaGF2aW9yIHdpbGwgYmUgaWdub3JlZCwgYmVjYXVzZQ0KICAgb2YgeDg2IGhh
cyBhIHJlYWwgc3R1Yi5jPyBBbmQgY29tbW9uL2VmaS9zdHViLmMgc3RpbGwgY2FuIHdvcmtzIGZv
cg0KICAgb3RoZXIgYXJjaGl0ZWN0dXJlcyBsaWtlIEFybSB3aG9tIGRvZXNuJ3QgaGF2ZSBhIHJl
YWwgc3R1Yi5jPw0KICAgQnV0IGluIHByZXZpb3VzIHZlcnNpb24ncyBkaXNjdXNzaW9uLCBJIGhh
ZCBzYWlkIEkgY3JlYXRlZCBhIHN0dWIuYyBpbg0KICAgQXJtL2VmaSwgYW5kIGNvcGllZCBBcm0g
cmVxdWlyZWQgZnVuY3Rpb25zIGZyb20geDg2L2VmaS9zdHViLmMuIEJ1dA0KICAgcGVvcGxlIGRp
ZG4ndCBsaWtlIGl0LiBJZiBteSBndWVzcyBpcyBjb3JyZWN0LCBJIGRvbid0IGtub3cgd2hhdCBp
cw0KICAgdGhlIGVzc2VudGlhbCBkaWZmZXJlbmNlIGJldHdlZW4gdGhlIHR3byBhcHByb2FjaGVz
Lg0KMi4gS2VlcHMgc3R1Yi5jIGluIHg4Ni9lZmksIGFuZCB1c2UgaXQgdG8gaW5jbHVkZSBjb21t
b24vc3R1Yi5jLg0KICAgSSB0aGluayB0aGlzIG1heSBub3QgYmUgdGhlIHJpZ2h0IHVuZGVyc3Rh
bmRpbmcsIGJ1dCBJIGNhbid0IHRoaW5rDQogICBvZiBhbnkgb3RoZXIgdW5kZXJzdGFuZGluZy4N
CiAgIEFuZCBwbGVhc2UgZm9yZ2l2ZSBteSBsaW1pdGVkIHJlYWRpbmcgbGV2ZWwgYWdhaW4hDQoN
Cj4gPj4+IC0tLSAvZGV2L251bGwNCj4gPj4+ICsrKyBiL3hlbi9jb21tb24vZWZpL3N0dWIuYw0K
PiA+Pj4gQEAgLTAsMCArMSwzOCBAQA0KPiA+Pj4gKyNpbmNsdWRlIDx4ZW4vZWZpLmg+DQo+ID4+
PiArI2luY2x1ZGUgPHhlbi9lcnJuby5oPg0KPiA+Pj4gKyNpbmNsdWRlIDx4ZW4vbGliLmg+DQo+
ID4+PiArDQo+ID4+PiArYm9vbCBlZmlfZW5hYmxlZCh1bnNpZ25lZCBpbnQgZmVhdHVyZSkNCj4g
Pj4+ICt7DQo+ID4+PiArICAgIHJldHVybiBmYWxzZTsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+
PiArYm9vbCBlZmlfcnNfdXNpbmdfcGd0YWJsZXModm9pZCkNCj4gPj4+ICt7DQo+ID4+PiArICAg
IHJldHVybiBmYWxzZTsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArdW5zaWduZWQgbG9uZyBl
ZmlfZ2V0X3RpbWUodm9pZCkNCj4gPj4+ICt7DQo+ID4+PiArICAgIEJVRygpOw0KPiA+Pj4gKyAg
ICByZXR1cm4gMDsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArdm9pZCBlZmlfaGFsdF9zeXN0
ZW0odm9pZCkgeyB9DQo+ID4+PiArdm9pZCBlZmlfcmVzZXRfc3lzdGVtKGJvb2wgd2FybSkgeyB9
DQo+ID4+PiArDQo+ID4+PiAraW50IGVmaV9nZXRfaW5mbyh1aW50MzJfdCBpZHgsIHVuaW9uIHhl
bnBmX2VmaV9pbmZvICppbmZvKQ0KPiA+Pj4gK3sNCj4gPj4+ICsgICAgcmV0dXJuIC1FTk9TWVM7
DQo+ID4+PiArfQ0KPiA+Pj4gKw0KPiA+Pj4gK2ludCBlZmlfY29tcGF0X2dldF9pbmZvKHVpbnQz
Ml90IGlkeCwgdW5pb24gY29tcGF0X3BmX2VmaV9pbmZvICopDQo+ID4+PiArICAgIF9fYXR0cmli
dXRlX18oKF9fYWxpYXNfXygiZWZpX2dldF9pbmZvIikpKTsNCj4gPj4NCj4gPj4gSSBkb3VidCB5
b3UgbmVlZCB0aGlzIG91dHNpZGUgb2YgeDg2Lg0KPiA+Pg0KPiA+Pj4gK2ludCBlZmlfcnVudGlt
ZV9jYWxsKHN0cnVjdCB4ZW5wZl9lZmlfcnVudGltZV9jYWxsICpvcCkNCj4gPj4+ICt7DQo+ID4+
PiArICAgIHJldHVybiAtRU5PU1lTOw0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICtpbnQgZWZp
X2NvbXBhdF9ydW50aW1lX2NhbGwoc3RydWN0IGNvbXBhdF9wZl9lZmlfcnVudGltZV9jYWxsICop
DQo+ID4+PiArICAgIF9fYXR0cmlidXRlX18oKF9fYWxpYXNfXygiZWZpX3J1bnRpbWVfY2FsbCIp
KSk7DQo+ID4+DQo+ID4+IFNhbWUgaGVyZS4NCj4gPj4NCj4gPg0KPiA+IFlvdSdyZSBjb3JyZWN0
LCBJIGNoZWNrIHRoZSBjb2RlLCBBcm0gZG9lc24ndCBuZWVkIGFib3ZlIHR3bw0KPiA+IGNvbXBh
dCBmdW5jdGlvbnMuIEkgd2lsbCByZXN0b3JlIHRoZW0gdG8geDg2IHNwZWNpZmljIGZpbGUuDQo+
ID4NCj4gPj4gRXZlbiBmb3IgdGhlIG5vbi1jb21wYXQgdmFyaWFudHMgdGhlIG5lZWQgaXMgdW4t
b2J2aW91czogQXJlIHlvdQ0KPiA+PiBpbnRlbmRpbmcgdG8gd2lyZSB0aGVzZSB1cCBhbnl3aGVy
ZSBpbiBBcm0gb3IgY29tbW9uIGNvZGU/IFRoaXMNCj4gPj4gb2YgY291cnNlIGlzIG9uY2UgYWdh
aW4gcG9pbnRpbmcgb3V0IHRoYXQgc3VjaCBjb2RlIG1vdmVtZW50IHdvdWxkDQo+ID4+IGJldHRl
ciBiZSBkb25lIHdoZW4gdGhlIG5ldyBjb25zdW1lcnMgYWN0dWFsbHkgYXBwZWFyLCBzdWNoIHRo
YXQNCj4gPj4gaXQncyBjbGVhciB3aHkgdGhlIG1vdmVtZW50IGlzIGRvbmUgLSBmb3IgZXZlcnkg
aW5kaXZpZHVhbCBpdGVtLg0KPiA+Pg0KPiA+DQo+ID4gWWVzLCBidXQgSSBkaWRuJ3QgZGVsaWJl
cmF0ZWx5IGlnbm9yZSB5b3VyIGNvbW1lbnQgZnJvbSB0aGUgbGFzdA0KPiA+IHNlcmllcy4gSSBh
bHNvIGhlc2l0YXRlZCBmb3IgYSB3aGlsZSB3aGVuIGNvbnN0cnVjdGluZyB0aGlzIHBhdGNoLg0K
PiA+IEkgZmVsdCB0aGF0IHRoaXMgaW5kZXBlbmRlbnQgd29yaywgbWF5YmUgaXQgd291bGQgYmUg
YmV0dGVyIHRvIHVzZQ0KPiA+IGFuIGluZGVwZW5kZW50IHBhdGNoLg0KPiANCj4gV2VsbCwgaXQg
b2YgY291cnNlIGRlcGVuZHMgb24gZnVydGhlciBhc3BlY3RzLiBJZiBpdCBoYWQgYmVlbiBjbGVh
cg0KPiB0aGF0IHdoYXQgaXMgbW92ZWQgaXMgYWN0dWFsbHkgZ29pbmcgdG8gYmUgd2lyZWQgdXAs
IHRoaXMgYmVpbmcgYQ0KPiBzdGFuZGFsb25lIHBhdGNoIHdvdWxkIGJlIG9rYXktaXNoLiBCdXQg
d2l0aCB0aGlzIHVuY2xlYXIgKGFuZCwgYXMNCj4gcGVyIGFib3ZlLCBhY3R1YWxseSBoYXZpbmcg
Z29uZSB0b28gZmFyKSBpdCdzIGltbyBiZXR0ZXIgdG8gbW92ZQ0KPiB0aGluZ3MgYXMgdGhleSBn
ZXQgcmUtdXNlZC4NCj4gDQoNCk9rLCBJIHVuZGVyc3RhbmQgaXQgbm93Lg0KDQpUaGFua3MsDQpX
ZWkgQ2hlbg0KDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 03:22:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 03:22:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314293.532282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYFp-0001Yi-SG; Wed, 27 Apr 2022 03:22:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314293.532282; Wed, 27 Apr 2022 03:22:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYFp-0001Yb-P4; Wed, 27 Apr 2022 03:22:13 +0000
Received: by outflank-mailman (input) for mailman id 314293;
 Wed, 27 Apr 2022 03:22:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njYFo-0001YR-F9; Wed, 27 Apr 2022 03:22:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njYFo-0002cm-Bv; Wed, 27 Apr 2022 03:22:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njYFn-0001W5-Tc; Wed, 27 Apr 2022 03:22:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njYFn-0003Br-T8; Wed, 27 Apr 2022 03:22:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FfC/jot4UqPzYnx35y7X4T2y2tYaIRliUxYLg+1Z4Dc=; b=twfqoIKNZJhtg+1X0B4oeZJjxr
	r0gA+d94m0QLujOD7v5NheHCGhAjZ7+bD1tfM1RnRheN9A08hUAI/bvnA3lX90X0FegADcK2lzSEB
	7D+3/FDScSEbG/G36VcHql/nbVuH4ujGntbO/wohEZ5JFJfjOIJj3F8/vZR+VkBmcTSo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169764-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169764: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 03:22:11 +0000

flight 169764 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169764/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  654 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   26 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 03:39:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 03:39:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314301.532292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYWG-00035o-BT; Wed, 27 Apr 2022 03:39:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314301.532292; Wed, 27 Apr 2022 03:39:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYWG-00035h-8J; Wed, 27 Apr 2022 03:39:12 +0000
Received: by outflank-mailman (input) for mailman id 314301;
 Wed, 27 Apr 2022 03:39:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/sE=VF=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1njYWE-00035V-GO
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 03:39:11 +0000
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95d948be-c5db-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 05:39:06 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Apr 2022 20:39:03 -0700
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orsmga003.jf.intel.com with ESMTP; 26 Apr 2022 20:39:03 -0700
Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 26 Apr 2022 20:39:02 -0700
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 26 Apr 2022 20:39:02 -0700
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 26 Apr 2022 20:39:02 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by PH0PR11MB5829.namprd11.prod.outlook.com (2603:10b6:510:140::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 03:39:00 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb%2]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 03:39:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95d948be-c5db-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1651030746; x=1682566746;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=P4sda8vTB8u+PTFtV9QVyGUfwdsWbCqqA2coi5Sv3wg=;
  b=egYBCBIrn0OYCxAFuB/KRKmH8dTavPPPVlEb5nU7bmQFdmZLn5OGOO3Z
   z5DCcH24NL+W1uvlpEEoDD8Cb/GDN7zUvASGNb+OVou47BIq/GRcRKYgV
   xENK80Y8/8gIb98wJoMYMvTo4/XS8JmnhX4IsO5nuBk20LTSxOgzQIigZ
   XizdWMUrGmryCJnY1USqYcHe7OeissFv+xYitfAY5ZGrl2kvOTno0sztS
   BknqfEAXk9tB4PXQL8zgpckW2qtOhIs3DfRj1zBqEDVStlqWO9O0Ox6bJ
   +AQulWtRUIrWgTdmteYg6q31u3pJWIAdckD91989JXws4XPUhoJlE/QBi
   w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="245724112"
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="245724112"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="513476546"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nwGHg0VblUxCdJGADxdXx833Xxdm4UqEbj3MXxX1GeJ0crilLPLHguwSQYFs1OS8BgDABaZ3hbG3X0weY8lmipSDsCa/u8ujTjswlrmLWG0T2ayZdF89m1jltDEnURBrwTrB+Hi22VxU59dtVMckdX1PAjl98v7BvLZG5Od9YYgccg7iBWo+rtIFu8DHGT5hwYAR4FcJ59WMp1ZIUkWwlzwV1AcVC0hoG8ZOoUpWALl8lKwq4ltiL+PwX+1nQo4H3Qv19r8FKwiFaPAINJSRu/2JM7Ubm+WIOv5RDfy+5ilGGzilgZ75jTnOj3+Klywm/3lcexsWynQ5tID/kIBWiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P4sda8vTB8u+PTFtV9QVyGUfwdsWbCqqA2coi5Sv3wg=;
 b=Dy/9GnrgOw/vwdJRFjF7Bc3s/3jHTIGwUxBEVofogqriip5h9iqNEP/k6JhpdabuXutELLdUZKDLNQg5McQNPoSp3EaodccJw1Oy9/2RXk8g8q2mdKcdw2nkp/AYPUYs05w9hcTfJo+Y2370B9lPs1oK3PpKjx+bdjvnD/T0QY7sMnzxSsDgD4qXkIwgDLvQ4unpWfOIk8m5C9xqT0QS4ACg6i0i0uDYdpkEioaPapleTP/TnC34uE6YgwDDZzRan2G4lBU3s0qYrJpOCYaTt9ENn+uFo7/aPf7tS1gnweM2zuzofChG7RmFbikR8bkKKbvVAyJut3wz7nYwT5APgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Cooper, Andrew" <andrew.cooper3@citrix.com>, xen-devel
	<xen-devel@lists.xenproject.org>
CC: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>, "Beulich,
 Jan" <JBeulich@suse.com>, Edwin Torok <edvin.torok@citrix.com>
Subject: RE: RMRRs and Phantom Functions
Thread-Topic: RMRRs and Phantom Functions
Thread-Index: AQHYWZZDIrEkmq9fL0+3qLNT2+7QyK0DHAnA
Date: Wed, 27 Apr 2022 03:39:00 +0000
Message-ID: <BN9PR11MB5276C91F31AA5119CD2B1B038CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
In-Reply-To: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bae4c92a-8aa1-4a71-d204-08da27ff7796
x-ms-traffictypediagnostic: PH0PR11MB5829:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <PH0PR11MB58292149DF46ACBE9E1E08D18CFA9@PH0PR11MB5829.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: UUYW34Ypi1+5iyy1CUGZnkEAyyToJLfY6s+bAMShMDYCuBbelALCwtyzW2cbuzMlUUW+2f7RXXB+waaswd/FDYlgXHxX4i3Dfbq0q3JH8KMh6iOhbvnakoOi/N2OAO71GAv6CJv5hF0fl2V9K6LHB6Z4f1zP6CYkaJ64i+gznAzmogx9wuNv2Taa6RYYfFxs4ymHT0TjHXFSdAf5XsEf3y3qvphorBO9yHTtmqOgN0OeLfJNynqPnPg8yWT3XUzZm7DAOXUX2qgFIgG1r0bJm83aon3yd5Jvfyr/G71TKnok/rokEwJlLfpVnJi4/EZuFk7rH6md7s+6fCnrHq/xiJObrzLx8ILeh8cO4kiXZHQKHMZojBQ3RxhNmPIOpCmZEjm9Awvt3VAp7eO+8NSw7NxM1fUudSLLv0lnawwcYQi3Z+gA1IGZ9SbwhoCAL4SPCT0p1AQVXO5ATi2/e1BbTR89aLzAEqP+mTiankFOequlGJgHIaakNM6qVzubsYT4BCOqBBMJRxdNzAYmo/STvVw4b33R8A5FqnUTWq2YxQFqEv+fnQSSCY5KfB5F7uWM0EKZW4e9lQPPP7bcijDPt2cwM9rycemuyMsMrY7ey9kA7IMVTRPQBPsd4wRwL1gHqnn3M3FiZSV+5exrrIiBBr6GGA5omJAUaTCQlxq/hbS9BhQfY8T531C7Z6ZEZ+0B/XrUPVabW84l+c5Qs2c1oA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(38070700005)(38100700002)(54906003)(2906002)(122000001)(508600001)(71200400001)(66476007)(66556008)(66946007)(64756008)(66446008)(8676002)(76116006)(3480700007)(186003)(33656002)(52536014)(316002)(86362001)(26005)(55016003)(82960400001)(7696005)(8936002)(6506007)(9686003)(110136005)(5660300002)(83380400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U0RWQUp5ZUhreGRpMmxSUlY2M2JjVGQ5dHV6ZSszREVycjVYaXcrYjVCU3dZ?=
 =?utf-8?B?RWFDQkdZVHArRDhHVTl0bVl2NUVoeHRVSk40bXZwYk9PblRrd3ZxZkJVSWRC?=
 =?utf-8?B?Uk9EU2kzYyt5VjUrWXVVQjBib0wxUFZrUklKeXFMS21VUEIrOVZydW5wOGQ3?=
 =?utf-8?B?dHA0RWdpZ0dZam84OFdOOVN1anFKMFRnMC81WTU0LzN4dlF4TERQZzdEZXZu?=
 =?utf-8?B?TERWaTB2RmlrM1E2ckZraEFIMUNjbEt2d240cUJkT1o5dmlOTUJKR2VDWDk0?=
 =?utf-8?B?Ukl6ZWpuU1ZOQThpMFBuY0JaZWJjUXlydlQ3V2k1UVgvcjRpUm4rUDVUbWlV?=
 =?utf-8?B?eWdzZnYwYWFlNjZkM2hYS0g0QW1ybmY5U1RnTFNWa21pd1pVbzVTSmNmWG5E?=
 =?utf-8?B?L0RoSEZXZVZIZkJPUjNmVjMzbjh2TmdYT1dRZm5pR0lPZmlic3RtMmVwSnlK?=
 =?utf-8?B?VitOdTYyUExSUkxxNEVPbU8wRkZVZDlQcDQ1Mm9KblJya2l1ME1QYnZwQXh3?=
 =?utf-8?B?Lytma0xTcGdrQXhUWVh1M0lzU0psSEpWOENJTnYveGxvSm1DMGlOSDE5K1hr?=
 =?utf-8?B?YitjUXVYaUMreVpuYkNFTE5zYjN4V1dHaC9JUEt3ZGg3NzlWcDRYZ0tKM0NU?=
 =?utf-8?B?T3RUZ2VTUkdJQ29GanpFUm4wbHRkejNnd3g1TGZIbjRSYithN2N3VHdWa0dO?=
 =?utf-8?B?cjdtOTJVU29KUGJ2T3dQUElRNHorN1BVVndNVGdpYzBxZjJRdzU3QzJYWFBr?=
 =?utf-8?B?MnlWc20xWk9FZVVadmhxY2Z0S1BFdytoRmwvNjYrSldWUVIrc3lyeStaMSsv?=
 =?utf-8?B?Q2dwN0pmSkQzcEpHdnZqZDhNWjljdHlvWi9XNmVYSCtaN0ZwOHhKT2tjS2wr?=
 =?utf-8?B?T3pUTi9tNFF1YmxiTmpVc3JUNHF0eWdFMVh5QzErOXk3MnRwd1pXWjdKbXR0?=
 =?utf-8?B?SVBwQkE2REY0R3FaSHdPbW12d1JyUVIwUnNDekpkQ1VHTC9DQm1OUzJmTnBl?=
 =?utf-8?B?V2gzTDdwd1FRakRwa2VzTVNHTU1tZEVocHMwOWtUR1dIc2JrdDUrSEk1ZUor?=
 =?utf-8?B?Q2t0VzdOakxtS2JJdklnN290WFk0U3FoRmhvdjVLbllZRE1hRy9TQ1lTOTdz?=
 =?utf-8?B?QTlINWIrSHJBL0JyYU80RGhvVzNsMTZFVTFlWWpMQjI4RktBWGp5NzA1dmow?=
 =?utf-8?B?QUk2OFpIYzRtT3BnWHh1dzNaeUlRRFJ5a1Ryb1Z6M3ViS1E3SkRmNGovN01G?=
 =?utf-8?B?ejdOaWN1L01sY3RrS2xLVzhEbGh0ZmxQSFpjM1VGOVZnQXZVa0VtVEZpVFpS?=
 =?utf-8?B?QkVBbnhGTnlTRlM3cXFqMERnNDVlVk44ZVdYU0hhS0g5RDRTaUJWdWp3bDYx?=
 =?utf-8?B?d2tPbDZyaWEvdzFBeHdNeVk1RHBSN2dCYkgzM3E3RGxVUzl2Y0VBRllWeDR5?=
 =?utf-8?B?WUNNREFpZHdQVlF6S1RLeGJYbkc0ODJsbW5NcXlhWVFJUEFhWlhkT1pRWUVj?=
 =?utf-8?B?UEd0S25Yd1lZZzF1VkpNNk1uWUdpbXkxYzMweXg4ZTNqdC9WbitoVU9ZNmtW?=
 =?utf-8?B?bW5STVRnazN2MWlJRDZsUVpNdkRVTy9odkJ2MllOWHpGUlhORTNxZTRWQzRt?=
 =?utf-8?B?ZG15UHV6ZlV3Myt2UmtrTVIvTDFrZDAySzFERjFLMG0yN0taWWd5eHM2M2hV?=
 =?utf-8?B?c2RCOEppRWxubk1mTjkrYkRGZmlpSXZqMmxMb0plNDBMR0pzU0FnSTJJeDQ1?=
 =?utf-8?B?dDZQSnBsNGk5dTR6Zzgram1aL29YQU1QT2UvSGFuclZtVjhHRUdmVHMzMDZQ?=
 =?utf-8?B?dmVOSW90bi8zd2luaWNVVTJ2YWVnY2VQa3pKeVlBK2tyeC9zQ1NFdE9zR2Rh?=
 =?utf-8?B?NUtnYzNtN2FCcjhPU1BXQytIVjY1aVAxYzd4b20zK2M5Q0YxZVNvTThoUnly?=
 =?utf-8?B?NXlabHZob1BwbWlWTXFXa0FUN3JKaWZFby9Hd3huczZydWpmQzQrME9sdXht?=
 =?utf-8?B?dnJHTXpoSys4eHRncEl6cDIwL1BodVZnSnROeEhhVXBBenBxc3FTWmVxblM4?=
 =?utf-8?B?MHlPMGJMdm5qODd2aTJ6SE02c3JwWmp0WVlMcDhjRElFYjZxeG02d2hUUjJE?=
 =?utf-8?B?ZUxjaTJPWG0zdCtqNTUyMEdBbnJPQ0pvTVJQRDVzczlEZW5hcGlhN245aGRu?=
 =?utf-8?B?UGdiN0Y3cmxqNDFRR29ZY0xOTXdTeXhJN0JLc01NK0Y5UEE2OGdWSVZNbnZO?=
 =?utf-8?B?TllrMGJIb0t4TklUalVCd0RVby9ZN0NVekYxSDcrQzVHNEF4aHFJTVo2c3NY?=
 =?utf-8?B?UHhNWUgvNTVGK0lIaGEySitRai84TjJ5RjdHQnpLd2FySWNhUGpPdz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bae4c92a-8aa1-4a71-d204-08da27ff7796
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 03:39:00.2394
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rBDcfxl7Cm0nfq8BZJeqDOhgF18/NC5rvfajVUorJhuxK7Mto2rg0mcB3ZRqLjQabJUvAC2KXfwqoF7cG59K3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5829
X-OriginatorOrg: intel.com

PiBGcm9tOiBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPg0KPiBTZW50
OiBXZWRuZXNkYXksIEFwcmlsIDI3LCAyMDIyIDE6NTIgQU0NCj4gDQo+IEhlbGxvLA0KPiANCj4g
RWR2aW4gaGFzIGZvdW5kIGEgbWFjaGluZSB3aXRoIHNvbWUgdmVyeSB3ZWlyZCBwcm9wZXJ0aWVz
LsKgIEl0IGlzIGFuIEhQDQo+IFByb0xpYW50IEJMNDYwYyBHZW44IHdpdGg6DQo+IA0KPiDCoFwt
WzAwMDA6MDBdLSstMDAuMMKgIEludGVsIENvcnBvcmF0aW9uIFhlb24gRTUvQ29yZSBpNyBETUky
DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCArLTAxLjAtWzExXS0tDQo+IMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCArLTAxLjEtWzAyXS0tDQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAr
LTAyLjAtWzA0XS0tKy0wMC4wwqAgRW11bGV4IENvcnBvcmF0aW9uIE9uZUNvbm5lY3QgMTBHYiBO
SUMNCj4gKGJlMykNCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgICstMDAuMcKgIEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2IgTklDDQo+
IChiZTMpDQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCArLTAwLjLCoCBFbXVsZXggQ29ycG9yYXRpb24gT25lQ29ubmVjdCAxMEdiDQo+IGlTQ1NJIElu
aXRpYXRvciAoYmUzKQ0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgXC0wMC4zwqAgRW11bGV4IENvcnBvcmF0aW9uIE9uZUNvbm5lY3QgMTBHYg0KPiBp
U0NTSSBJbml0aWF0b3IgKGJlMykNCj4gDQo+IHlldCBhbGwgNCBvdGhlciBmdW5jdGlvbnMgb24g
dGhlIGRldmljZSBwZXJpb2RpY2FsbHkgaGl0IElPTU1VIGZhdWx0cw0KPiAofm9uY2UgZXZlcnkg
NSBtaW5zLCBzbyBkZWZpbml0ZWx5IHN0YXRzKS4NCj4gDQo+IChYRU4pIFtWVC1EXURNQVI6W0RN
QSBXcml0ZV0gUmVxdWVzdCBkZXZpY2UgWzAwMDA6MDQ6MDAuNF0gZmF1bHQgYWRkcg0KPiBiZGY4
MDAwMA0KPiAoWEVOKSBbVlQtRF1ETUFSOltETUEgV3JpdGVdIFJlcXVlc3QgZGV2aWNlIFswMDAw
OjA0OjAwLjVdIGZhdWx0IGFkZHINCj4gYmRmODAwMDANCj4gKFhFTikgW1ZULURdRE1BUjpbRE1B
IFdyaXRlXSBSZXF1ZXN0IGRldmljZSBbMDAwMDowNDowMC42XSBmYXVsdCBhZGRyDQo+IGJkZjgw
MDAwDQo+IChYRU4pIFtWVC1EXURNQVI6W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZpY2UgWzAwMDA6
MDQ6MDAuN10gZmF1bHQgYWRkcg0KPiBiZGY4MDAwMA0KPiANCj4gVGhlcmUgYXJlIHNldmVyYWwg
Uk1SUnMgY292ZXJpbmcgdGhlIHRoZXNlIGRldmljZXMsIHdpdGg6DQo+IA0KPiAoWEVOKSBbVlQt
RF1mb3VuZCBBQ1BJX0RNQVJfUk1SUjoNCj4gKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAwOjAz
OjAwLjANCj4gKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAwOjAxOjAwLjANCj4gKFhFTikgW1ZU
LURdIGVuZHBvaW50OiAwMDAwOjAxOjAwLjINCj4gKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAw
OjA0OjAwLjANCj4gKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAwOjA0OjAwLjENCj4gKFhFTikg
W1ZULURdIGVuZHBvaW50OiAwMDAwOjA0OjAwLjINCj4gKFhFTikgW1ZULURdIGVuZHBvaW50OiAw
MDAwOjA0OjAwLjMNCj4gKFhFTikgW1ZULURdZG1hci5jOjYwODrCoMKgIFJNUlIgcmVnaW9uOiBi
YXNlX2FkZHIgYmRmOGYwMDAgZW5kX2FkZHINCj4gYmRmOTJmZmYNCj4gDQo+IGJlaW5nIHRoZSBv
bmUgcmVsZXZhbnQgdG8gdGhlc2UgZmF1bHRzLsKgIEkndmUgbm90IG1hbnVhbGx5IGRlY29kZWQg
dGhlDQo+IERNQVIgdGFibGUgYmVjYXVzZSBkZXZpY2UgcGF0aHMgYXJlIGhvcnJpYmxlIHRvIGZv
bGxvdyBidXQgdGhlcmUgYXJlIGF0DQo+IGxlYXN0IHRoZSBjb3JyZWN0IG51bWJlciBvZiBlbmRw
b2ludHMuwqAgVGhlIGZ1bmN0aW9ucyBhbGwgaGF2ZSBTUi1JT1YNCj4gKGRpc2FibGVkKSBhbmQg
QVJJIChlbmFibGVkKS7CoCBOb25lIGhhdmUgYW55IFBoYW50b20gZnVuY3Rpb25zIGRlc2NyaWJl
ZC4NCj4gDQo+IFNwZWNpZnlpbmcgcGNpLXBoYW50b209MDQ6MDAsMSBkb2VzIGFwcGVhciB0byB3
b3JrIGFyb3VuZCB0aGUgZmF1bHRzLA0KPiBidXQgaXQncyBub3QgcmlnaHQsIGJlY2F1c2UgZnVu
Y3Rpb25zIDEgdGhydSAzIGFyZW4ndCBhY3R1YWxseSBwaGFudG9tLg0KPiANCj4gQWxzbywgSSBk
b24ndCBzZWUgYW55IGxvZ2ljIHdoaWNoIGFjdHVhbGx5IHdpcmVzIHVwIHBoYW50b20gZnVuY3Rp
b25zDQo+IGxpa2UgdGhpcyB0byBzaGFyZSBSTVJScy9JVk1EcyBpbiBJTyBjb250ZXh0cy7CoCBU
aGUgZmF1bHRzIG9ubHkNCj4gZGlzYXBwZWFyIGFzIGEgc2lkZSBlZmZlY3Qgb2YgMDQ6MDAuMCBh
bmQgMDQ6MDAuNCBiZWluZyBpbiBkb20wLCBhcyBmYXINCj4gYXMgSSBjYW4gdGVsbC4NCj4gDQo+
IFNpbXBseSBnaXZpbmcgdGhlIFJNUlIgdmlhIHJtcnI9IGRvZXNuJ3Qgd29yayAocHJlc3VtYWJs
eSBiZWNhdXNlIG9mIG5vDQo+IHBhdGNoaW5nIGFjdHVhbCBkZXZpY2VzLCBidXQgdGhlcmUncyBu
byB3YXJuaW5nKSwgYnV0IGl0IGZlZWxzIGFzIGlmIGl0DQo+IG91Z2h0IHRvLg0KPiANCg0KV2hh
dCBpcyB0aGUgWGVuIHZlcnNpb24/IERvZXMgaXQgaW5jbHVkZSBKYW4ncyBjaGFuZ2UgZm9yIHBl
ci1kZXZpY2UNCnF1YXJhbnRpbmU/DQoNCmJ0dyBpdCdzIHdlaXJkIHdoeSB0aG9zZSBOSUMgZGV2
aWNlcyByZXF1aXJlIFJNUlIgaW4gdGhlIGZpcnN0IHBsYWNlLi4uDQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 03:46:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 03:46:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314308.532304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYd3-0004aj-6I; Wed, 27 Apr 2022 03:46:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314308.532304; Wed, 27 Apr 2022 03:46:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYd3-0004ac-2v; Wed, 27 Apr 2022 03:46:13 +0000
Received: by outflank-mailman (input) for mailman id 314308;
 Wed, 27 Apr 2022 03:46:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/sE=VF=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1njYd1-0004aV-Rx
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 03:46:11 +0000
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 92997f2e-c5dc-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 05:46:10 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Apr 2022 20:46:08 -0700
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2022 20:46:08 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 26 Apr 2022 20:46:07 -0700
Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 26 Apr 2022 20:46:07 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 26 Apr 2022 20:46:07 -0700
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169)
 by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 26 Apr 2022 20:46:07 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DS7PR11MB6293.namprd11.prod.outlook.com (2603:10b6:8:97::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 03:46:04 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb%2]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 03:46:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92997f2e-c5dc-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1651031170; x=1682567170;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=ED0zf14XLPDcAAB3Y/J2KkZc5MWKv9PWCbkFeXzBf/w=;
  b=MG2WohwmOp+ARkX/UXeLKI9LhNzgfROiA3nHbzp14K9Hdq/1xAl16tiw
   JEAnDZE+ph9pL6woZEd9gbIm8xEkxckKFZ4AQfCmtTsOYsFEoSHrRVhgK
   82qhh/z1AqBcz4L2zA3tJ11iksem6T2ReP6xO6mDee/VbNqKbCYz0pYTd
   1ej3cTQA+7w8GryCWXSvVBoEEXrmk/XaSf1xa8lF80jyQsPSffrwvNCiE
   qvy2pvWnlU6Txxk9IB+z98MZzm+QZHCgz0mEgqxM9VxCPgfNq4UCXTf/l
   geDCpctN5SvWbvzyrHsWdNS0mC2Qx0+oEi/irY8MZMurlY6zn/oQNi46R
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="263392588"
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="263392588"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="650509562"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W35q4bBPWOTvaRH7fUOKQk3b3FmYx2ysaFfNEsTo5F0nlw9JdY4b61R6qPYbvh4aKj3jn897ummhj9cC70ADgTdooJoociLrE7KGkUIh42uSOaf+3aDy6hCk3gyY1mRQhVAIIrhBvOVTwtaSIJE3S8pczeEHsaU8WSt88pFz1tEGAvm+11upA3x19qX7qXfA0IkEoVq1ekbXvubct7UTvSr7fDVgYhix7mRCxTg6hTV3R1eSAzmI6Wkspq9dGeNRXMmeowlg6sbFF6gecXacD6ODi+nWtEdnZ8x65EvY/Ty1DYskflOgomeMGn8atExK9MoRsIQwynlQMttYibhKAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MESCVaAqrZZfas5dAL1T/f210czPz9VfNXs2i7kXDdI=;
 b=dn4amNsr4qVUzDf+bCxlmWxK7zIkUrRvd0cMzz0yxsNcfHd2oCtwOlcuuOSsjoDYuRNSlOMS6n0V0Peoj3syQfUDxB5EGj1SfF6nOBqUw5KeZH+JAJYPB1mg5urGfjFRfQ29UiUaOMbXMEUI1l9nRY2nXpUZBU3iVuin6Tn6OE9sH3eKz/EcY2gdEwpssy1p2QxwyZxTbIPB/jZ3Bed5mPoA1YWa+3AKm0ODz8UnLtpxDkVisr/cda/X+Gmxg9xdDtPObv9qrWaj8lBeIMJ4fCJhClVoG9DEU4Y0xbK+ah/SacZWFLBgkjeHb2FlDwW5bE43FhqX8BZbHFP3hwUhFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Lengyel, Tamas" <tamas.lengyel@intel.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "Nakajima, Jun" <jun.nakajima@intel.com>, "Beulich, Jan"
	<JBeulich@suse.com>, "Cooper, Andrew" <andrew.cooper3@citrix.com>,
	=?iso-8859-1?Q?Pau_Monn=E9=2C_Roger?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>, George Dunlap
	<george.dunlap@citrix.com>
Subject: RE: [PATCH v5] x86/vmx: add hvm functions to get/set non-register
 state
Thread-Topic: [PATCH v5] x86/vmx: add hvm functions to get/set non-register
 state
Thread-Index: AQHYQE0JDO4TZ1lTNEeFxdnKer9Q960DUDGQ
Date: Wed, 27 Apr 2022 03:46:04 +0000
Message-ID: <BN9PR11MB527638D2BE6087C1A4D796D48CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
In-Reply-To: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1347a452-7bad-42fc-11c7-08da28007460
x-ms-traffictypediagnostic: DS7PR11MB6293:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DS7PR11MB629353C9AE08981BB19B121A8CFA9@DS7PR11MB6293.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: amAh4NrbGMk290MawpG17Lku3SO5Snq/dEn4K3UYPLjXjm7yNQe5VSEIUo5/LkbthsbrqCydDb+V5+mZtoqHx+O40YPVw23zwG5JEx20EgKnGJyWtohXUYliDv1JigCJVivLysiTpfqwGZeGDMw/+ZV3aV2q3LQ6IpbbhHRfiAomTfMYuxnTaB5FJyVa7rZVxLBPSRTD1Axj3+L9eXb3rLFaxbcZeaOOj02u15L8QzTvPgA5I4BK7NX74JBR3Ik0MYNEFwygoi5D9VnLP4rioA+lebs3WvrS/YI6M+jRXkyz38rIvvPSMm5FYNWtFCBn08Y+M+x6C1VkcZpEyVZjFVDbYmzvJwlnP03Ptv1jSf+RgA06pDN+1w0Q29fbgl0P+de5YhMvYcJ/c0iktZgP4r/J4WklVcTetjF6zYFI86385NIwcd7oUJsovTB0oLbXJe1uqcM7wqkHMwyhd/EIk4JjjTw3XB25fDIFeeDRUD58/SkRg8mlshSbX/bN9wF6wcSdW5/bWdAGbujUR+zNDGW05KiMcby4XOL3DaeUISYHQcAPcFI4YKxZ8IgT4+aQ4Ylq+XCs+QQyMFejSvD9qL02jWAwkoN9A83WnITZ+AKL/hF8OzuXBB3yZX9g+JkKOowdtfyAgDMJO4ok91/qKxUoLW+CQODGoM985AFvPhpeQXh+DZh/4lvAdCiHCTge4f1SnpaJj4tLqk/7CwamlQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(76116006)(6506007)(122000001)(4326008)(8676002)(66446008)(64756008)(83380400001)(110136005)(5660300002)(55016003)(82960400001)(186003)(316002)(54906003)(2906002)(8936002)(9686003)(71200400001)(508600001)(66476007)(66556008)(38100700002)(38070700005)(7696005)(52536014)(86362001)(26005)(33656002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?gRdNpACfKHsV84aOeqI87LQjmCVHbRhyHqnRb4+eiLxaOrwiTfK6YVfn+t?=
 =?iso-8859-1?Q?Fl50DZ2b4tjp56ZR722RFCr0kA5RgqX7IJ5R11Y7EipCXC7Gl3jP/LNDkT?=
 =?iso-8859-1?Q?mpxMuqxH802jFYh3i3nu/at1beTzm6wa+6+fQjH/Hvpa05mm2CpSzOWpp4?=
 =?iso-8859-1?Q?U6ZnphHhcyxtF72UXSeZ1+CRhZ9XJbRxAlJ+AJPvVZu939WV0udOiskycY?=
 =?iso-8859-1?Q?8SUsvXHY8vUD2FxxY/CAM79KpYzhQgXBUjWHzcpXqvH6nA5w2jpsotir9+?=
 =?iso-8859-1?Q?JBQ02mDOLs9qS9q7qJomOmADsxSsOpQ7OVH+uBSqYzyrS9iD/5C59viPxF?=
 =?iso-8859-1?Q?y6buoFWrt0JvSClpbLZMDJBwWk+G03ep7LQhJXQp1BlZyaxQSeq50rj7RP?=
 =?iso-8859-1?Q?GoxBZMxV7LjCaK+yRf8OEITxCjlc2DbUZGfZbVtayer/eDTczqrjzzDSe6?=
 =?iso-8859-1?Q?57Yb+HXVGolPlW8kGPgGBe6y4t14AfgHiUJjjWsdTKhAAu22UOnt4EaUh+?=
 =?iso-8859-1?Q?Wu0RkcLuIB7BQZpKt/vmPYOC5xpuAgZmeT3kHJr5Emd6cw5oY2HAtY09st?=
 =?iso-8859-1?Q?6h83TLA9omzK0ID5A8qlqtiJXWpqFk8d3+kA2GyrdWB9IiL18JehYBZK+C?=
 =?iso-8859-1?Q?Z2XOpUpASbRkSrFkHqxe1jgHhD3q5Hw5qiPpWQvU9Yita8lXJMq3a9SI9D?=
 =?iso-8859-1?Q?Yz4toN+AVdNv4WfEgrBAY2J3vJUiE86ab7MWaRqYqsJKYhatNaOA+Sjh6g?=
 =?iso-8859-1?Q?UGhP/wamx65nOMtx9fVoMHcgIhtIZB09HXgS1VJFd3jTFvPnL8i5nsxRiz?=
 =?iso-8859-1?Q?rTTG78NVrAfTBWds3VFlQl4466dKQFw+6MJuUxxQ4zDOiOUFfNhKdE03cE?=
 =?iso-8859-1?Q?903CUwqvMKFD7e1nUr8bZYF8FFwvz07vMpestmMDBjVBVyxa9NZhTvuJ6I?=
 =?iso-8859-1?Q?nm3SglhuI0nA03GpoykWN8yMzJoPwZKvx268mdQVKCrBsuTZKJzS5iBFKZ?=
 =?iso-8859-1?Q?y8vF0U2Hb/Nqw9agRMcBFs6BkHc7Ensbjn4t4SrNbs5/63TzU1BkOtj1/h?=
 =?iso-8859-1?Q?cHMtZJg/irtf+OHGHAj9kO/5Qvj8Buo7BMtheoHEa8SpsOJH96Vn0RZcYB?=
 =?iso-8859-1?Q?GW8j54XvN+hGk5ZatSAmmIpxS+55T5727WovtqassP5aj9xDYd6lgcvmj2?=
 =?iso-8859-1?Q?rKzuv2YQkvqB5wtbtPXOaByvbWS2A7+I56LcWM0p33i6mIeD7mUx3SkPQz?=
 =?iso-8859-1?Q?qt6e39sLkkFbUJExg/flFqBR6o0qrKQLordaHGl+/U9KCq5TRDMG31gIRL?=
 =?iso-8859-1?Q?rZUCtxiOBAI7AifrcGFQ1pOjSh4Mlu5vNEOxRloQ/wtSKFvRPVUF/Rvinb?=
 =?iso-8859-1?Q?Y+UQ+L4FAvKifUYTCfBOQkp5RYYLC3OZKGxi+ZPBr5rkfU/5+MMu6+d/zW?=
 =?iso-8859-1?Q?6GxtUcc0Qcp7IGw9avisOKFfL2Hipvcgu+XQ7nGjVokQ0POk68yNEb5cn2?=
 =?iso-8859-1?Q?NvwNcaqKYzJfmScZS9+2j7UIkyOBjXB0ghcdoG0ouiQ6UXsUkkhFypEbFe?=
 =?iso-8859-1?Q?nycUIsCL0mlkm1CgRUOVTQrUiwcNFZ0Fz00rhq4VdOKBwBKZow9wqQxrUu?=
 =?iso-8859-1?Q?PrPlKt5gYVaJRj+ZVqAT4cozMw3e2zVjnOsrnAH3iY4SNU/z3IDInKwnDB?=
 =?iso-8859-1?Q?5wxTovQeNyqhM3ZPIy0tco7b0jF29+OhkFFuuZEbxBKFmwVcHOe5nQE5G/?=
 =?iso-8859-1?Q?+KpOgvtm+DrmDfrfhSI+DD86ywsZuQBD8yRA1/9Rr4oq+3BAedDHdjXf52?=
 =?iso-8859-1?Q?pPvc53MUsw=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1347a452-7bad-42fc-11c7-08da28007460
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 03:46:04.3285
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uByuK9Uvsxnylahf2PzaaoPu4ha1zfBBa2H0G0YgnKCsNzU4ZjpNnQAnwcN8AVa7/LlbVvLUxIwxNMnUauoqvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6293
X-OriginatorOrg: intel.com

> From: Lengyel, Tamas <tamas.lengyel@intel.com>
> Sent: Friday, March 25, 2022 9:33 PM
>=20
> During VM forking and resetting a failed vmentry has been observed due
> to the guest non-register state going out-of-sync with the guest register
> state. For example, a VM fork reset right after a STI instruction can tri=
gger
> the failed entry. This is due to the guest non-register state not being s=
aved
> from the parent VM, thus the reset operation only copies the register sta=
te.
>=20
> Fix this by adding a new pair of hvm functions to get/set the guest
> non-register state so that the overall vCPU state remains in sync.
>=20
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>

> ---
> v5: Switch to internal-only hvm funcs instead of adding to hvm_hw_cpu
> ---
>  xen/arch/x86/hvm/vmx/vmx.c         | 32 ++++++++++++++++++++++++
>  xen/arch/x86/include/asm/hvm/hvm.h | 40
> ++++++++++++++++++++++++++++++
>  xen/arch/x86/mm/mem_sharing.c      | 11 +++++++-
>  3 files changed, 82 insertions(+), 1 deletion(-)
>=20
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index c075370f64..2685da16c8 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -1334,6 +1334,36 @@ static void cf_check vmx_set_interrupt_shadow(
>      __vmwrite(GUEST_INTERRUPTIBILITY_INFO, intr_shadow);
>  }
>=20
> +static void cf_check vmx_get_nonreg_state(struct vcpu *v,
> +    struct hvm_vcpu_nonreg_state *nrs)
> +{
> +    vmx_vmcs_enter(v);
> +
> +    __vmread(GUEST_ACTIVITY_STATE, &nrs->vmx.activity_state);
> +    __vmread(GUEST_INTERRUPTIBILITY_INFO, &nrs-
> >vmx.interruptibility_info);
> +    __vmread(GUEST_PENDING_DBG_EXCEPTIONS, &nrs->vmx.pending_dbg);
> +
> +    if ( cpu_has_vmx_virtual_intr_delivery )
> +        __vmread(GUEST_INTR_STATUS, &nrs->vmx.interrupt_status);
> +
> +    vmx_vmcs_exit(v);
> +}
> +
> +static void cf_check vmx_set_nonreg_state(struct vcpu *v,
> +    struct hvm_vcpu_nonreg_state *nrs)
> +{
> +    vmx_vmcs_enter(v);
> +
> +    __vmwrite(GUEST_ACTIVITY_STATE, nrs->vmx.activity_state);
> +    __vmwrite(GUEST_INTERRUPTIBILITY_INFO, nrs-
> >vmx.interruptibility_info);
> +    __vmwrite(GUEST_PENDING_DBG_EXCEPTIONS, nrs->vmx.pending_dbg);
> +
> +    if ( cpu_has_vmx_virtual_intr_delivery )
> +        __vmwrite(GUEST_INTR_STATUS, nrs->vmx.interrupt_status);
> +
> +    vmx_vmcs_exit(v);
> +}
> +
>  static void vmx_load_pdptrs(struct vcpu *v)
>  {
>      uint32_t cr3 =3D v->arch.hvm.guest_cr[3];
> @@ -2487,6 +2517,8 @@ static struct hvm_function_table
> __initdata_cf_clobber vmx_function_table =3D {
>      .load_cpu_ctxt        =3D vmx_load_vmcs_ctxt,
>      .get_interrupt_shadow =3D vmx_get_interrupt_shadow,
>      .set_interrupt_shadow =3D vmx_set_interrupt_shadow,
> +    .get_nonreg_state     =3D vmx_get_nonreg_state,
> +    .set_nonreg_state     =3D vmx_set_nonreg_state,
>      .guest_x86_mode       =3D vmx_guest_x86_mode,
>      .get_cpl              =3D _vmx_get_cpl,
>      .get_segment_register =3D vmx_get_segment_register,
> diff --git a/xen/arch/x86/include/asm/hvm/hvm.h
> b/xen/arch/x86/include/asm/hvm/hvm.h
> index 5b7ec0cf69..9dee0f87a3 100644
> --- a/xen/arch/x86/include/asm/hvm/hvm.h
> +++ b/xen/arch/x86/include/asm/hvm/hvm.h
> @@ -84,6 +84,17 @@ enum hvm_intblk {
>  /* update_guest_cr() flags. */
>  #define HVM_UPDATE_GUEST_CR3_NOFLUSH 0x00000001
>=20
> +struct hvm_vcpu_nonreg_state {
> +    union {
> +        struct {
> +            uint64_t activity_state;
> +            uint64_t interruptibility_info;
> +            uint64_t pending_dbg;
> +            uint64_t interrupt_status;
> +        } vmx;
> +    };
> +};
> +
>  /*
>   * The hardware virtual machine (HVM) interface abstracts away from the
>   * x86/x86_64 CPU virtualization assist specifics. Currently this interf=
ace
> @@ -122,6 +133,10 @@ struct hvm_function_table {
>      /* Examine specifics of the guest state. */
>      unsigned int (*get_interrupt_shadow)(struct vcpu *v);
>      void (*set_interrupt_shadow)(struct vcpu *v, unsigned int intr_shado=
w);
> +    void (*get_nonreg_state)(struct vcpu *v,
> +                             struct hvm_vcpu_nonreg_state *nrs);
> +    void (*set_nonreg_state)(struct vcpu *v,
> +                             struct hvm_vcpu_nonreg_state *nrs);
>      int (*guest_x86_mode)(struct vcpu *v);
>      unsigned int (*get_cpl)(struct vcpu *v);
>      void (*get_segment_register)(struct vcpu *v, enum x86_segment seg,
> @@ -744,6 +759,20 @@ void hvm_set_reg(struct vcpu *v, unsigned int reg,
> uint64_t val);
>          d_->arch.hvm.pi_ops.vcpu_block(v_);                     \
>  })
>=20
> +static inline void hvm_get_nonreg_state(struct vcpu *v,
> +                                        struct hvm_vcpu_nonreg_state *nr=
s)
> +{
> +    if ( hvm_funcs.get_nonreg_state )
> +        alternative_vcall(hvm_funcs.get_nonreg_state, v, nrs);
> +}
> +
> +static inline void hvm_set_nonreg_state(struct vcpu *v,
> +                                        struct hvm_vcpu_nonreg_state *nr=
s)
> +{
> +    if ( hvm_funcs.set_nonreg_state )
> +        alternative_vcall(hvm_funcs.set_nonreg_state, v, nrs);
> +}
> +
>  #else  /* CONFIG_HVM */
>=20
>  #define hvm_enabled false
> @@ -863,6 +892,17 @@ static inline void hvm_set_reg(struct vcpu *v,
> unsigned int reg, uint64_t val)
>      ASSERT_UNREACHABLE();
>  }
>=20
> +static inline void hvm_get_nonreg_state(struct vcpu *v,
> +                                        struct hvm_vcpu_nonreg_state *nr=
s)
> +{
> +    ASSERT_UNREACHABLE();
> +}
> +static inline void hvm_set_nonreg_state(struct vcpu *v,
> +                                        struct hvm_vcpu_nonreg_state *nr=
s)
> +{
> +    ASSERT_UNREACHABLE();
> +}
> +
>  #define is_viridian_domain(d) ((void)(d), false)
>  #define is_viridian_vcpu(v) ((void)(v), false)
>  #define has_viridian_time_ref_count(d) ((void)(d), false)
> diff --git a/xen/arch/x86/mm/mem_sharing.c
> b/xen/arch/x86/mm/mem_sharing.c
> index 15e6a7ed81..857accee58 100644
> --- a/xen/arch/x86/mm/mem_sharing.c
> +++ b/xen/arch/x86/mm/mem_sharing.c
> @@ -1643,6 +1643,13 @@ static int bring_up_vcpus(struct domain *cd,
> struct domain *d)
>      return 0;
>  }
>=20
> +static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu
> *cd_vcpu)
> +{
> +    struct hvm_vcpu_nonreg_state nrs =3D {};
> +    hvm_get_nonreg_state(d_vcpu, &nrs);
> +    hvm_set_nonreg_state(cd_vcpu, &nrs);
> +}
> +
>  static int copy_vcpu_settings(struct domain *cd, const struct domain *d)
>  {
>      unsigned int i;
> @@ -1651,7 +1658,7 @@ static int copy_vcpu_settings(struct domain *cd,
> const struct domain *d)
>=20
>      for ( i =3D 0; i < cd->max_vcpus; i++ )
>      {
> -        const struct vcpu *d_vcpu =3D d->vcpu[i];
> +        struct vcpu *d_vcpu =3D d->vcpu[i];
>          struct vcpu *cd_vcpu =3D cd->vcpu[i];
>          mfn_t vcpu_info_mfn;
>=20
> @@ -1694,6 +1701,8 @@ static int copy_vcpu_settings(struct domain *cd,
> const struct domain *d)
>=20
>          hvm_vmtrace_reset(cd_vcpu);
>=20
> +        copy_vcpu_nonreg_state(d_vcpu, cd_vcpu);
> +
>          /*
>           * TODO: to support VMs with PV interfaces copy additional
>           * settings here, such as PV timers.
> --
> 2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 03:53:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 03:53:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314314.532315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYjY-00061A-UK; Wed, 27 Apr 2022 03:52:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314314.532315; Wed, 27 Apr 2022 03:52:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYjY-000613-RA; Wed, 27 Apr 2022 03:52:56 +0000
Received: by outflank-mailman (input) for mailman id 314314;
 Wed, 27 Apr 2022 03:52:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Q6ah=VF=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1njYjX-00060h-Gp
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 03:52:55 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20629.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::629])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 83f55933-c5dd-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 05:52:53 +0200 (CEST)
Received: from AS8PR05CA0025.eurprd05.prod.outlook.com (2603:10a6:20b:311::30)
 by VI1PR08MB4029.eurprd08.prod.outlook.com (2603:10a6:803:ec::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 03:52:38 +0000
Received: from AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:311:cafe::ca) by AS8PR05CA0025.outlook.office365.com
 (2603:10a6:20b:311::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend
 Transport; Wed, 27 Apr 2022 03:52:38 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT044.mail.protection.outlook.com (10.152.17.56) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 03:52:37 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Wed, 27 Apr 2022 03:52:36 +0000
Received: from d2d29c3c7d81.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F596CB6B-64C9-4AE7-880C-66FEB5A79F13.1; 
 Wed, 27 Apr 2022 03:52:31 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d2d29c3c7d81.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 03:52:31 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by AM0PR08MB5505.eurprd08.prod.outlook.com (2603:10a6:208:18e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 03:52:29 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 03:52:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83f55933-c5dd-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=l3+dSZTCEJMFXhRnWKoWaU5jqCF7ovPFpWfhQB5ByorNTVUVSUl9XWhaJct48mOQpLfidI+rdfRzFDf8ZEwCQ55F0XQq8frgnwnwrz4Y8hVcfJSYmHpioPukiZkUU/qIO54OQeFruvZicQIhJye1XzAi7lR+RMNfmzDWd5vAxjHEdkOGb02keELB6D7uu/r3XJxo/vbQ78TNpglVxURyRs1sGb3zsmVPIwPA4I5WMBswsuLXnDCoiCvVcv39fCXiYi++f9JhYenp20kRnh+oV57eKxNB1D1IVPoZ/hSVr38lxQb61JUT7sTL3vGe3irnP5eZ9ajq1gwyUD9pOdSglA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pceHUH/SelruKIeUg8IoL4G9TiVeeobEpOyMvTiaeKI=;
 b=D+l26pi0o8P6EjJ0FzSCuIxXUHkoAqSV4H7VwKlIEpshfZRYoRoUxHfK0nX/pxwLc9ryNSJgx66XKTCqRct2NktIq7eAA32Ps948rXRaaBk7jh1b+m9bwsVE7ocE/b+89QZY/ApOjULXUfA7rjft+22EKyri9pVeV4/pFgC4lZpWw4A4Z8wURzSL9/OLeEe/Riyy7HDwq5unTcMaC8GGw2FjppnX906DAGS66Oh8p7vZdOOys4k/5AwtbdrAfz6G4S9ClF7Mu27aoAK6gnddh1EeXYAIbDe6JhqFxPTb2O4fcHRT9twAZw/zSMwPnWSFzb35Ov5eFF3UMNDxasXH/A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pceHUH/SelruKIeUg8IoL4G9TiVeeobEpOyMvTiaeKI=;
 b=wW1Vs0Wc+gPzarZSvZSca+BFti5AVvgOCU4Fe9kL4MW3ajp8xvxzEClb0lWjC4adO3Os91G/sRWEwRB2VPOBQ3p5Bz4PbYWJuBy35OAGRFb2EAiIvWtw566FiNBa0gA7iFAhfXWk4uWt020zOMqKM9moj/3WZLOEAfpoQQGw1BE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C9G2ozMMY/qOJN4nR/0x5iqUx5SZCLbRgXHJdyC9S+alojjw29XaSjyIlmi5pufKxTaRImVuH9MF6j2eFOZxwFscdO20cXSB22+Kq9TlzRxcXmTvciSerdXcNVBNL3p4CpFsmF8b2Gp/XJBGcmrGb7Q8AskZnI0UrlOUcQWXvIZDB1g3UDg31/ssL1seG0luuIG1drfKTZ00uQij5NGGt1g/e2KMFL+NKFAM2FvWNfms5o84vP0XiB13IQO3fPN9l8m9Gzbb/rydbZ4mDkfyN9KIXpXaw69PrhXqadXGO/HT9jfKjvsJ7INNa/BDptTfmjjny0ytrgrrzRjYdfBD/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pceHUH/SelruKIeUg8IoL4G9TiVeeobEpOyMvTiaeKI=;
 b=LdlFuJTC0NgrkCO30UJG3okc/OtU8jb59tlkaAeIIROI0EAJtmjc7lwuMaRZHFn4TK4NmNIIn5aBIK7iwzJ5QCkLeHj6GYvwTukNIz1Dn9l2YbJLRpq7Xy4eg0CKWiGKFbaVPQ8Pq9DM4S9Zre7xsmE4v85iLOyNDEzZchWOYGIDT1yEXyUxTq+2L+X1m5s/TH3hA95vZzB6imse3lKQU2pEaxacohU/VKC41+i1geseO07H9QicNIAkyuXSZTthwfxmLJMePsk63WDkP+fbBe77lzpzRdmvgY60wrRaEi1lCPiNTnaGmQZ52Mp0NWyqvEAic5xJWXegjmgepdMmsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pceHUH/SelruKIeUg8IoL4G9TiVeeobEpOyMvTiaeKI=;
 b=wW1Vs0Wc+gPzarZSvZSca+BFti5AVvgOCU4Fe9kL4MW3ajp8xvxzEClb0lWjC4adO3Os91G/sRWEwRB2VPOBQ3p5Bz4PbYWJuBy35OAGRFb2EAiIvWtw566FiNBa0gA7iFAhfXWk4uWt020zOMqKM9moj/3WZLOEAfpoQQGw1BE=
From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON
 for phys_to_nid
Thread-Topic: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON
 for phys_to_nid
Thread-Index: AQHYUwP8rcNxDcW2QEyqIlyEGMAP4q0B8r0AgAAgsICAAD42gIAAz9Gg
Date: Wed, 27 Apr 2022 03:52:28 +0000
Message-ID:
 <PAXPR08MB74209F0F6F0B189FA10D04FA9EFA9@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-6-wei.chen@arm.com>
 <6d666aa4-c0d3-b8ed-9fca-e9d2179564d3@suse.com>
 <7d7fc887-20a3-49c3-0754-3bca3442ccce@arm.com>
 <79e3fc8d-7064-e981-b90c-d0f7fa0aafae@suse.com>
In-Reply-To: <79e3fc8d-7064-e981-b90c-d0f7fa0aafae@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 673D8F9C32B4A74A9D7988E1CF6ED389.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: acc88254-3c2b-42eb-531e-08da28015ea0
x-ms-traffictypediagnostic:
	AM0PR08MB5505:EE_|AM5EUR03FT044:EE_|VI1PR08MB4029:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB402937E99949B3207463E3739EFA9@VI1PR08MB4029.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 dLIxk3NkT0958x1petdcsd39ww/2wQg09RivLEK8d0d3Y+2MznmPXG/CGOHbM6rhxi14OfJJQAKkKoBKZmFeB04mFvQbLeRZGkVSjxdNICJSFzezZINXh212YseaKWp2BJmgy6kE6Jnip+eb3ANbcTbzz6jXPlmAatD33OtwAQcYd/Gc1qfxoZI6SRt4nvyE2i9FHju0mSXS983WObKptbiGZdtt5+X1QRnXk/xv5q3klv/PnshDQo7DPHgQjCzRd0Ms3qyvx0MXtaS3FwXC1jnS+bZUB+jl71H2GxLFTmkihGkbm+xGXTjlpd7zZj3SRtf2XCfInADmJRbuRppZOVo8JkvQ9FDZd2LwxzcxOyKYDuqC+adRcNUgCA5JCYACaubO2ztsSJnfawzR8W+tFRIuvd3uLBu4vj17v0EphsyZyL/4/h+/jVwNft/izfFO4DlpszMUKCe3t4yGUxC3Zn3oMoXblDu6sNUHUIGLPFk6cFl2gY2VEz2yxrImB7myu8bcjYAwholXCD/UL+Dn+wwoseckhERAh+Uiyg7+Ca7JOuEggvd3ad912i9cF/ZYGOOSyHUMKTfvssHV+zGncF5IxJPNrFtj2Gs+ZBqhcOpSFsbZs7lA4OEfG1pbYx36nI44WbCA68Nes2UR4MPjw3rrCUgZb7mPBUe/7oufdu8CBuTjsub7WJ46z5WrZ+t79GCV3v6q9zMaAiKe2RSHYA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(26005)(66946007)(76116006)(33656002)(8936002)(6506007)(66446008)(71200400001)(66556008)(54906003)(52536014)(316002)(6916009)(7696005)(66476007)(508600001)(4326008)(122000001)(64756008)(8676002)(5660300002)(2906002)(38070700005)(186003)(55016003)(38100700002)(83380400001)(53546011)(9686003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5505
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6a66e5c3-43c9-4b1c-7a32-08da28015977
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JqcvEDgwDN7BcBI7htUEOtdawBkMD4/t/8j46twPJuswh27ge0BKlK6MtMqlkvje3xF1xGoGESdk7d4yTq6q2oU89w03Rse4nm9UKa7vuTpt+0xa7bcf/Re2ecwgD8QHj+EpBXHvugg6TVzLmCPNecMmStkF5Vuaw4hfp7Je2A+usA0Ytw1t7UJbLtfGcWVh1zGYwVT+awESGVlfbMFuJNO3H7TIKC4mSUyTZwFQHcBxl90qZ4Z9kQ2lIUvfYgsWJZmnCIxLfTJ6Z+2Ppb4kF7LEiIiulTm2SfLxrzw42STGIDHuNmF5OMfLjQcti1sRmbx42yYqRK+YjJkAEi/DiLsGS26P2wDnQ5F9S6NEHmJoLt+jrpSlxFcRD4gJyqKrLzc6GBeTcT068RQCia8f8RS4vkeVACjHgPSNt5vVw596RdjQyLL5M6mU5JdD91X1hhBHFpL3jHAt9ydA2JIqVEkdZlqqF0ZbPhxA7I57ZtHOKyS7LC1qteGuQoZUNc0iyhy6b1Lk+kUZK19Yp71SfjxOm1UdbZzpBX0ORRzUEeAMR3QzTOHvjW46c0Pnrbeuiu2sR8X5EOttvw5yY/JY7LqGNIm32UWINtRz7pZJ8MueC8POR3s8ZhkYF3HO1FRo620g/SkMeNVrecSZGhKN2mM7KRpB4rz7MAa7qV/BrXSX8ftmrM7IetYFjKqz34wc
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(2906002)(70586007)(70206006)(54906003)(81166007)(356005)(53546011)(9686003)(82310400005)(33656002)(86362001)(36860700001)(7696005)(6862004)(8676002)(4326008)(6506007)(26005)(47076005)(508600001)(186003)(8936002)(40460700003)(55016003)(5660300002)(83380400001)(336012)(316002)(52536014);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 03:52:37.3208
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: acc88254-3c2b-42eb-531e-08da28015ea0
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4029

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDTmnIgyNuaXpSAyMjo0Mg0K
PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47
IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y
Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1
bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu
b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU
Q0ggdjIgMDUvMTBdIHhlbi94ODY6IFVzZSBBU1NFUlQgaW5zdGVhZCBvZg0KPiBWSVJUVUFMX0JV
R19PTiBmb3IgcGh5c190b19uaWQNCj4gDQo+IE9uIDI2LjA0LjIwMjIgMTI6NTksIFdlaSBDaGVu
IHdyb3RlOg0KPiA+IE9uIDIwMjIvNC8yNiAxNzowMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4+
IE9uIDE4LjA0LjIwMjIgMTE6MDcsIFdlaSBDaGVuIHdyb3RlOg0KPiA+Pj4gVklSVFVBTF9CVUdf
T04gaXMgYW4gZW1wdHkgbWFjcm8gdXNlZCBpbiBwaHlzX3RvX25pZC4gVGhpcw0KPiA+Pj4gcmVz
dWx0cyBpbiB0d28gbGluZXMgb2YgZXJyb3ItY2hlY2tpbmcgY29kZSBpbiBwaHlzX3RvX25pZA0K
PiA+Pj4gdGhhdCBpcyBub3QgYWN0dWFsbHkgd29ya2luZyBhbmQgY2F1c2luZyB0d28gY29tcGls
YXRpb24NCj4gPj4+IGVycm9yczoNCj4gPj4+IDEuIGVycm9yOiAiTUFYX05VTU5PREVTIiB1bmRl
Y2xhcmVkIChmaXJzdCB1c2UgaW4gdGhpcyBmdW5jdGlvbikuDQo+ID4+PiAgICAgVGhpcyBpcyBi
ZWNhdXNlIGluIHRoZSBjb21tb24gaGVhZGVyIGZpbGUsICJNQVhfTlVNTk9ERVMiIGlzDQo+ID4+
PiAgICAgZGVmaW5lZCBhZnRlciB0aGUgY29tbW9uIGhlYWRlciBmaWxlIGluY2x1ZGVzIHRoZSBB
UkNIIGhlYWRlcg0KPiA+Pj4gICAgIGZpbGUsIHdoZXJlIHBoeXNfdG9fbmlkIGhhcyBhdHRlbXB0
ZWQgdG8gdXNlICJNQVhfTlVNTk9ERVMiLg0KPiA+Pj4gICAgIFRoaXMgZXJyb3Igd2FzIHJlc29s
dmVkIHdoZW4gd2UgbW92ZWQgdGhlIGRlZmluaXRpb24gb2YNCj4gPj4+ICAgICAiTUFYX05VTU5P
REVTIiB0byB4ODYgQVJDSCBoZWFkZXIgZmlsZS4gQW5kIHdlIHJlc2VydmUgdGhlDQo+ID4+PiAg
ICAgIk1BWF9OVU1OT0RFUyIgZGVmaW5pdGlvbiBpbiBjb21tb24gaGVhZGVyIGZpbGUgdGhyb3Vn
aCBhDQo+ID4+PiAgICAgY29uZGl0aW9uYWwgY29tcGlsYXRpb24gZm9yIHNvbWUgYXJjaGl0ZWN0
dXJlcyB0aGF0IGRvbid0DQo+ID4+PiAgICAgbmVlZCB0byBkZWZpbmUgIk1BWF9OVU1OT0RFUyIg
aW4gdGhlaXIgQVJDSCBoZWFkZXIgZmlsZXMuDQo+ID4+DQo+ID4+IE5vLCB0aGF0J3Mgc2V0dGlu
ZyB1cCBhIHRyYXAgZm9yIHNvbWVvbmUgZWxzZSB0byBmYWxsIGludG8sIGVzcGVjaWFsbHkNCj4g
Pj4gd2l0aCB0aGUgI2lmZGVmIGFyb3VuZCB0aGUgb3JpZ2luYWwgZGVmaW5pdGlvbi4gQWZhaWN0
IGFsbCB5b3UgbmVlZCB0bw0KPiA+PiBkbyBpcyB0byBtb3ZlIHRoYXQgI2RlZmluZSBhaGVhZCBv
ZiB0aGUgI2luY2x1ZGUgaW4geGVuL251bWEuaC4gVW5saWtlDQo+ID4+IGZ1bmN0aW9ucywgI2Rl
ZmluZS1zIGNhbiByZWZlcmVuY2Ugbm90LXlldC1kZWZpbmVkIGlkZW50aWZpZXJzLg0KPiA+Pg0K
PiA+DQo+ID4gSSBoYWQgdHJpZWQgaXQgYmVmb3JlLiBNQVhfTlVNTk9ERVMgZGVwZW5kcyBvbiBO
T0RFX1NISUZULiBCdXQNCj4gPiBOT0RFX1NISUZUIGRlcGVuZHMgb24gdGhlIGRlZmluaXRpb24g
c3RhdHVzIGluIGFzbS9udW1hLmguIElmIEkgbW92ZQ0KPiA+IE1BWF9OVU1OT0RFUyB0byBiZWZv
cmUgYXNtL251bWEuaCwgdGhlbiBJIGhhdmUgdG8gbW92ZSBOT0RFU19TSElGVCBhcw0KPiA+IHdl
bGwuIEJ1dCB0aGlzIHdpbGwgYnJlYWsgdGhlIG9yaWdpbmFsIGRlc2lnbi4gTk9ERVNfU0hJRlQg
aW4geGVuL251bWEuaA0KPiA+IHdpbGwgYWx3YXlzIGJlIGRlZmluZWQgYmVmb3JlIGFzbS9udW1h
LmguIFRoaXMgd2lsbCBiZSBhIGR1cGxpY2F0ZWQNCj4gPiBkZWZpbml0aW9uIGVycm9yLg0KPiAN
Cj4gSSdtIGFmcmFpZCBJIGRvbid0IGZvbGxvdy4gTUFYX05VTU5PREVTIGRlcGVuZHMgb24gTk9E
RVNfU0hJRlQgb25seSBhcw0KPiBzb29uIGFzIHNvbWUgY29kZSBhY3R1YWxseSB1c2VzIE1BWF9O
VU1OT0RFUy4gSXQgZG9lcyBub3QgcmVxdWlyZQ0KPiBOT0RFU19TSElGVCB0byBiZSBkZWZpbmVk
IHVwIGZyb250LiBPZiBjb3Vyc2Ugd2l0aCB0aGUgY3VycmVudCBsYXlvdXQNCj4gKHBoeXNfdG9f
bmlkKCkgbGl2aW5nIGluIGFuIGlubGluZSBmdW5jdGlvbiBpbiBhc20vbnVtYS5oKSB0aGluZ3Mg
d29uJ3QNCj4gYnVpbGQuIEJ1dCB3YXNuJ3QgdGhlIHBsYW4gdG8gbW92ZSBwaHlzX3RvX25pZCgp
IHRvIHhlbi9udW1hLmggYXMgd2VsbD8NCj4NCg0KWWVzLCBJIHdpbGwgZHJvcCB0aGlzIHBhdGNo
IGZyb20gcGFydCMxLCBhbmQgbW92ZSBpdCB0byBwYXJ0IzIuIFRoaXMNCnBhdGNoIHdpbGwgZm9s
bG93IHdoZW4gd2UgbW92ZSBwaHlzX3RvX25pZCgpIHRvIHhlbi9udW1hLmguDQoNClRoYW5rcywN
CldlaSBDaGVuDQoNCj4gT3RoZXJ3aXNlIEknZCByZWNvbW1lbmQgdG8gaW50cm9kdWNlIGEgbmV3
IGhlYWRlciwgc2F5IG51bWEtZGVmcy5oLA0KPiBob2xkaW5nIChmb3Igbm93KSBqdXN0IE5PREVT
X1NISUZULiBUaGVuIHlvdSdkIGluY2x1ZGUgYXNtL251bWEtZGVmcy5oDQo+IGZpcnN0IGFuZCBh
c20vbnVtYS5oIG9ubHkgYWZ0ZXIgaGF2aW5nIGRlZmluZWQgTUFYX05VTU5PREVTLiBCdXQNCj4g
c3BsaXR0aW5nIHRoZSBoZWFkZXIgc2hvdWxkIG9ubHkgYmUgYSBsYXN0IHJlc29ydCBpZiB0aGlu
Z3MgY2FuJ3QgYmUNCj4gbWFkZSB3b3JrIGFub3RoZXIgd2F5Lg0KPiANCj4gPiBIb3cgYWJvdXQg
SSBtb3ZlIE1BWF9OVU1OT0RFUyB0byBhcm0gYW5kIHg4NiBhc20vbnVtYS5oIGluIHRoaXMgcGF0
Y2gNCj4gPiBhdCB0aGUgc2FtZSB0aW1lPyBCZWNhdXNlIGluIG9uZSBvZiBmb2xsb3dpbmcgcGF0
Y2hlcywgTUFYX05VTU5PREVTIGFuZA0KPiA+IHBoeXNfdG9fbmlkIHdpbGwgYmUgbW92ZWQgdG8g
eGVuL251bWEuaCBhdCB0aGUgc2FtZSB0aW1lPw0KPiA+DQo+ID4+PiAyLiBlcnJvcjogd3Jvbmcg
dHlwZSBhcmd1bWVudCB0byB1bmFyeSBleGNsYW1hdGlvbiBtYXJrLg0KPiA+Pj4gICAgIFRoaXMg
aXMgYmVjYXVzZSwgdGhlIGVycm9yLWNoZWNraW5nIGNvZGUgY29udGFpbnMgIW5vZGVfZGF0YVtu
aWRdLg0KPiA+Pj4gICAgIEJ1dCBub2RlX2RhdGEgaXMgYSBkYXRhIHN0cnVjdHVyZSB2YXJpYWJs
ZSwgaXQncyBub3QgYSBwb2ludGVyLg0KPiA+Pj4NCj4gPj4+IFNvLCBpbiB0aGlzIHBhdGNoLCB3
ZSB1c2UgQVNTRVJUIGluc3RlYWQgb2YgVklSVFVBTF9CVUdfT04gdG8NCj4gPj4+IGVuYWJsZSB0
aGUgdHdvIGxpbmVzIG9mIGVycm9yLWNoZWNraW5nIGNvZGUuIEFuZCBmaXggdGhlIGxlZnQNCj4g
Pj4+IGNvbXBpbGF0aW9uIGVycm9ycyBieSByZXBsYWNpbmcgIW5vZGVfZGF0YVtuaWRdIHRvDQo+
ID4+PiAhbm9kZV9kYXRhW25pZF0ubm9kZV9zcGFubmVkX3BhZ2VzLg0KPiA+Pj4NCj4gPj4+IEJl
Y2F1c2Ugd2hlbiBub2RlX3NwYW5uZWRfcGFnZXMgaXMgMCwgdGhpcyBub2RlIGhhcyBubyBtZW1v
cnksDQo+ID4+PiBudW1hX3NjYW5fbm9kZSB3aWxsIHByaW50IHdhcm5pbmcgbWVzc2FnZSBmb3Ig
c3VjaCBraW5kIG9mIG5vZGVzOg0KPiA+Pj4gIkZpcm13YXJlIEJ1ZyBvciBtaXMtY29uZmlndXJl
ZCBoYXJkd2FyZT8iLg0KPiA+Pg0KPiA+PiBUaGlzIHdhcm5pbmcgaXMgYm9ndXMgLSBub2RlcyBj
YW4gaGF2ZSBvbmx5IHByb2Nlc3NvcnMuIFRoZXJlZm9yZSBJJ2QNCj4gPj4gbGlrZSB0byBhc2sg
dGhhdCB5b3UgZG9uJ3QgdXNlIGl0IGZvciBqdXN0aWZpY2F0aW9uLiBBbmQgaW5kZWVkIHlvdQ0K
PiA+DQo+ID4gWWVzLCB5b3UncmUgcmlnaHQsIG5vZGUgY2FuIG9ubHkgaGFzIENQVXMhIEkgd2ls
bCByZW1vdmUgaXQuDQo+ID4NCj4gPj4gZG9uJ3QgbmVlZCB0bzogcGh5c190b19uaWQoKSBpcyBh
Ym91dCB0cmFuc2xhdGluZyBhbiBhZGRyZXNzLiBUaGUNCj4gPj4gaW5wdXQgYWRkcmVzcyBjYW4n
dCBiZSB2YWxpZCBpZiBpdCBtYXBzIHRvIGEgbm9kZSB3aXRoIG5vIG1lbW9yeS4NCj4gPj4NCj4g
Pg0KPiA+IENhbiBJIHVuZGVyc3RhbmQgeW91ciBjb21tZW50Og0KPiA+IEFueSBpbnB1dCBhZGRy
ZXNzIGlzIGludmFsaWQsIHdoZW4gbm9kZV9zcGFubmVkX3BhZ2VzIGlzIHplcm8sIGJlY2F1c2UN
Cj4gPiB0aGlzIG5vZGUgaGFzIG5vIG1lbW9yeT8NCj4gDQo+IEl0J3MgZ2V0dGluZyBjbG9zZSwg
YnV0IGl0J3Mgbm90IGV4YWN0bHkgZXF1aXZhbGVudCBJIHRoaW5rLiBBIG5vZGUNCj4gd2l0aCAw
IGJ5dGVzIG9mIG1lbW9yeSBtaWdodCAoYXQgbGVhc3QgaW4gdGhlb3J5KSBoYXZlIGFuIGVudHJ5
IGluDQo+IG1lbW5vZGVtYXBbXS4gQnV0IGZpbmRpbmcgYSBub2RlIElEIGZvciB0aGF0IGFkZHJl
c3Mgd291bGQgc3RpbGwNCg0KSSBoYXZlIGRvbmUgYSBxdWljayBjaGVjayBpbiBwb3B1bGF0ZV9t
ZW1ub2RlbWFwOg0KNzQgICAgICAgICAgc3BkeCA9IHBhZGRyX3RvX3BkeChub2Rlc1tpXS5zdGFy
dCk7DQo3NSAgICAgICAgICBlcGR4ID0gcGFkZHJfdG9fcGR4KG5vZGVzW2ldLmVuZCAtIDEpICsg
MTsNCjc2ICAgICAgICAgIGlmICggc3BkeCA+PSBlcGR4ICkNCjc3ICAgICAgICAgICAgICBjb250
aW51ZTsNCg0KSXQgc2VlbXMgdGhhdCBpZiBub2RlIGhhcyBubyBtZW1vcnksIHN0YXJ0ID09IGVu
ZCwgdGhlbiB0aGlzIGZ1bmN0aW9uDQp3aWxsIG5vdCBwb3B1bGF0ZSBtZW1ub2RlbWFwIGVudHJ5
IGZvciB0aGlzIG5vZGUuDQoNCj4gbm90IG1lYW4gdGhhdCBhdCBsZWFzdCBvbmUgYnl0ZSBvZiBt
ZW1vcnkgYXQgdGhhdCBhZGRyZXNzIGlzIHByZXNlbnQNCj4gb24gdGhlIGdpdmVuIG5vZGUsIGJl
Y2F1c2UgdGhlIG5vZGUgY292ZXJzIDAgYnl0ZXMuDQo+IA0KDQpBbmQgYmFjayB0byB0aGlzIHBh
dGNoLCBjYW4gSSBqdXN0IGRyb3AgdGhlIHVubmVjZXNzYXJ5IGp1c3RpZmljYXRpb24NCmZyb20g
dGhlIGNvbW1pdCBtZXNzYWdlPw0KDQpBbmQgZm9yIHRoZSBib2d1cyB3YXJuaW5nIG1lc3NhZ2Us
IGNhbiBJIHVwZGF0ZSBpdCB0byBhbiBJTkZPIGxldmVsDQptZXNzYWdlIGluIHBhcnQjMiBzZXJp
ZXMsIGFuZCBqdXN0IGtlZXA6DQpwcmludGsoS0VSTl9JTkZPICJTUkFUOiBOb2RlICV1IGhhcyBu
byBtZW1vcnkhXG4iLCBpKTsNCmJ1dCByZW1vdmUgIkJJT1MgQnVnIG9yIG1pcy1jb25maWd1cmVk
IGhhcmR3YXJlP1xuIiwgaSk7ID8NCg0KVGhhbmtzLA0KV2VpIENoZW4NCg0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 03:58:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 03:58:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314321.532325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYp6-0006ip-Mn; Wed, 27 Apr 2022 03:58:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314321.532325; Wed, 27 Apr 2022 03:58:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYp6-0006ii-JW; Wed, 27 Apr 2022 03:58:40 +0000
Received: by outflank-mailman (input) for mailman id 314321;
 Wed, 27 Apr 2022 03:58:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njYp5-0006iY-Mi; Wed, 27 Apr 2022 03:58:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njYp5-0003FJ-HW; Wed, 27 Apr 2022 03:58:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njYp5-0003Wg-4v; Wed, 27 Apr 2022 03:58:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njYp5-0006Ih-4T; Wed, 27 Apr 2022 03:58:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2HWGcZAqbUPjGoxIKdN9+ap9qYSr0hy80C+4Sq8oQFM=; b=oL9VhgLHq5chptFgq6EMxQdH4T
	46QJKczNiW4MIP4upkixAKNqdv0ZbbcdVH/I9Ht/AdMEEge4hN8XrRlpKNPzvZBibqQlbXkyorFN7
	wkwV4Yllwj3IfCJrbAA5Hu4cw6xDtUfGqE9e/WAOeBu9yvXErMrwUsLC3+wMDnedk0Cc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169753-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169753: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=cf424ef014ac30b0da27125dd1fbdf10b0d3a520
X-Osstest-Versions-That:
    linux=d615b5416f8a1afeb82d13b238f8152c572d59c0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 03:58:39 +0000

flight 169753 linux-linus real [real]
flight 169765 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169753/
http://logs.test-lab.xenproject.org/osstest/logs/169765/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 169765-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     18 guest-localmigrate       fail REGR. vs. 169714

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169714
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169714
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169714
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169714
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169714
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169714
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169714
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169714
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                cf424ef014ac30b0da27125dd1fbdf10b0d3a520
baseline version:
 linux                d615b5416f8a1afeb82d13b238f8152c572d59c0

Last test of basis   169714  2022-04-25 18:09:34 Z    1 days
Testing same since   169753  2022-04-26 19:11:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Shiyan <eagle.alexander923@gmail.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  David Sterba <dsterba@suse.com>
  Filipe Manana <fdmanana@suse.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Haowen Bai <baihaowen@meizu.com>
  Helge Deller <deller@gmx.de>
  Jakob Koschel <jakobkoschel@gmail.com>
  Janusz Krzysztofik <jmkrzyszt@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Naohiro Aota <naohiro.aota@wdc.com>
  Ondrej Zary <linux@zary.sk>
  Pavel Skripkin <paskripkin@gmail.com>
  Wang Qing <wangqing@vivo.com>
  Zheyu Ma <zheyuma97@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   d615b5416f8a..cf424ef014ac  cf424ef014ac30b0da27125dd1fbdf10b0d3a520 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 04:09:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 04:09:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314329.532337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYzf-0008Qm-OQ; Wed, 27 Apr 2022 04:09:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314329.532337; Wed, 27 Apr 2022 04:09:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njYzf-0008Qf-LG; Wed, 27 Apr 2022 04:09:35 +0000
Received: by outflank-mailman (input) for mailman id 314329;
 Wed, 27 Apr 2022 04:09:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/sE=VF=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1njYze-0008QZ-9P
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 04:09:34 +0000
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d5861b15-c5df-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 06:09:32 +0200 (CEST)
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Apr 2022 21:09:28 -0700
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orsmga006.jf.intel.com with ESMTP; 26 Apr 2022 21:09:28 -0700
Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 26 Apr 2022 21:09:27 -0700
Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by
 fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 26 Apr 2022 21:09:27 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 26 Apr 2022 21:09:27 -0700
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 26 Apr 2022 21:09:27 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by CO1PR11MB4804.namprd11.prod.outlook.com (2603:10b6:303:6f::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 27 Apr
 2022 04:09:24 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb%2]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 04:09:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5861b15-c5df-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1651032572; x=1682568572;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=5CEBpfM0nnYYOZ8kAid6Ce67P6Tfk0FK38+Fe9mQ86Y=;
  b=mFGvGljAZOGOFSjwk0SQD78ukkrv6VorfjPzhUmbnpgb/ShvBDXzHtRr
   O18JzJWN+1NSVv9VJju5V6fceyZvA8sDpruq0VFiVZt+2yND6oyX9MG8r
   XKu6PaqCretZVdTr2gLPi8oO7N5QFhMW6CTZu2SoKQ+nea3Wncd70Fjuq
   uigMpMPjKTrcE5QfnxCRz3MeTolSokfpj1FP1ewdDfygbeESa6BcRkfxH
   yJVRyeIR4PlKTy6mAhFBgN9H0BCP8kTLcDFjjrVth4MkDVLDKsbUuRETN
   Sd23uA7KWrq4gHAzJhk/L40R5dguTKy2PJMdKT3pyB0XfCalzBKBVEP92
   A==;
X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="290955640"
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="290955640"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="533006992"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VsTVSQC8BJBsI0SOwqOFaGe17iQvNwXboEB0tK4RoWvhgx7uIRNSDeVwImFecr3D3apZlSLJ2/9uKmZBhZibAE/PHIvi2H41eAniiDtxrsLzyEWG9/WjTIZaFgdEaZ7Zs/XtcoMrhj3mW9LTv8YvU2GDU79kDRsDxyp2xWvd6OyYgHLUhRxN45NQPiNY/kSv/yY5McVmEbO6U1aIOpVBs9qjHkJo7G/JPDgBqgkIjHvbF33FBwwdEwNzzbBYc2eKgS25LWGNbyKrTCBqaf8Dt13yPcIJn0042CYClbm74rTf6ps+dh7RdKgToH4/L6TJcsqd5rWpbCR681zSVneVww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5CEBpfM0nnYYOZ8kAid6Ce67P6Tfk0FK38+Fe9mQ86Y=;
 b=eYlFX7p1qR5kBjP5+QosPLxCKg1Kz+3lFrJY6eT6Nqs8OnqAA7yikLTD4OrbS/Y3Rcb6+k12C+3uciTDyA7pyoEPJi96VAQ52lp6ElbBEIUNyeU++nhMeRR9bBuPA40hIYPzdcV4ADDsXtk/v5ROg6JB2dhD/ywScmd3+F8PKRnXGg7iCEIRn7GUeHvRM24hYhbNWYjSLbEYQ/XTKybOSVbOQLlgZQFAXDjPi+JDViGW3I0iQ5PYmlRZtEGEhlnpNTQWSzkkDaezmCbe2LYmPRcXd3SFiZYRUQnCz1leBhQTtOnnm0b4m3X8WQBLqPt/NMZeTWFTtbBQWhLbPl9cuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH v4 16/21] VT-d: free all-empty page tables
Thread-Topic: [PATCH v4 16/21] VT-d: free all-empty page tables
Thread-Index: AQHYWIB55LiJis4LlU+Of8jQSBwnua0DJPWw
Date: Wed, 27 Apr 2022 04:09:24 +0000
Message-ID: <BN9PR11MB52769CDA1125C76E74EA0F658CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
 <b9a2be8d-3bb9-3718-6e3b-f07f6dcdde20@suse.com>
In-Reply-To: <b9a2be8d-3bb9-3718-6e3b-f07f6dcdde20@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 655ab111-d532-4683-83cf-08da2803b71d
x-ms-traffictypediagnostic: CO1PR11MB4804:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <CO1PR11MB4804DF94A838270CFA5D35638CFA9@CO1PR11MB4804.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: RXhnWxkzcVK8Bhl98ov5t9lSSdCByfiHRn7m2GdSj7+mV4s+1GxD2tXZ+RxMJ64QUdp94z2bDnnTnamVaT1PMxI9bTFD3qf4Ka1uvsTsm9RUPYELe6ULp1eEhApJlynHwaEk/ZLBTlEeWEXWCBrAMxVpktIF8vEbR1uN2mUv1M74zbHqekx69NEyKuUce5qpu24WIQGMtS0F3wLMsukXe6rxmnMHvr6f2TGft0qXfDJuIkVVKmfz363LB+XxSPKqmkXOVz30tOMTKjjmao7s2JdhpjIEfvVay49/SJbuyedzsQziXTimhTK7qCgnMd8OjkTmmts0MpAKglRycV8O+t4TWaUCJ1gg8c6K14kjqq56Sel6f6orN0GWPmeH8QpFWWz5Cp2uGacalzjnrR4kXqq0w8G9xzS+RRliT8rX79OBhhfdKKt9Adqtp7/QN+nI2xGRMCZMgv0Ax5c1UOdNnpiOSBPx0LwzJBWMkH7dkgSYMdxw/vHHSi6LIbESwS+/0tvPxm7nG1gTavk+81/p9FPy5JbHgWQZrEPCcuqNIzkNMIb3xC8seugjKAQHcmxBE6d9MniaueAIOTV+Wymy/fBxKxOVLs8uSZq5KuOsGlIweoueLA2RyV/+RK2WDzvj4tW8C0FD9p6I8zw5TQcrfvJhBbkC3RNxlsm0/58UuAkNwpx5hldEtashPjAalA3am+//Fe2UgXSutvMYlHnRAQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66476007)(66446008)(64756008)(8676002)(26005)(2906002)(186003)(83380400001)(71200400001)(76116006)(66946007)(66556008)(9686003)(86362001)(7696005)(6506007)(508600001)(52536014)(5660300002)(33656002)(8936002)(38100700002)(55016003)(38070700005)(54906003)(316002)(82960400001)(110136005)(122000001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Tk96MFYzVHIxV0Y2V2RIbU9pNWdBUk9uaHNqdFIxOEEwU2FpUVF4Qm84QmNx?=
 =?utf-8?B?Wi9taXNaZmxCVDczQUsydks5RFJHRzlHTGlDMG9XUVNpWlBWZ290d2JIaW5p?=
 =?utf-8?B?ZUVNcXJrc0wySmZyRWpVSC9EZXB5NnhlYVhIcVZvbTF5MFVhdGJPRFVOaHJq?=
 =?utf-8?B?dkxIWHF4RElBcFJsaXBKSGdiQU8rdXFuc3g3YTZaY2JwT29hS0w0NHgranRs?=
 =?utf-8?B?MWlsdnZBdzFmKzBTOHpsRkY1T0laejQ4TnFtVlI5elNVaXFnQmNoQW50eVZo?=
 =?utf-8?B?TDZpaHpET2xPdVF5VmRZdFozQisxeFlUZ1g3ZjVMendxbVkycm02Q2FFcW1v?=
 =?utf-8?B?VU5KQjROdFhTbGdVRHV5YlpGelZNZ0FjRFJYTjdTSWs1cEkwQ0pXYjNNdzdw?=
 =?utf-8?B?SDFEVm5oRkExcGp2bytvVXpPbDdhQUw3RWZPZi9ySnNoOVh3V2ZrTnBWRnJx?=
 =?utf-8?B?V1RTOWxyZ1F4dTNNMGM2RWJEL21EYU42YWVEK29ldHpiZVR0REUxdDZPQ08v?=
 =?utf-8?B?NG9nUlNJdXkzWU9mT1V6Z1FrK1N4Y1YwYlNrcGdGV01XSTREaDdzM2J3YStG?=
 =?utf-8?B?Vml3ejBGYlFKbzB3TVNtV3NCckFsdmJva25yczEvVHhwak5XY3RDMk8yQnpH?=
 =?utf-8?B?QTliNTdpZjAvYVJYcDY3MWpLQ3B0aUpmUVFoczVFbXNGNGtNdit1Rk9pekx1?=
 =?utf-8?B?dm9ycXdwRjRVeDRJTVBkdTZVOUlkTytQVXcraVRQRlR0T3dROXRIWGZQT1Vi?=
 =?utf-8?B?QXJrcGdPSDJueDdWNUdCSDBEWlhSbVNwU0NJRXdQbS9hUUVWWVVaU0ZBNzc2?=
 =?utf-8?B?U0RUSE52MCt0T21uZmdRSmFqc3h0cktOSTkvdDJhZWoxVmdUUDZvUWpHVTd3?=
 =?utf-8?B?c20zaEJLc2RKOXFFTFE3NFZvTEdGU0Z6bEh2bDQrdldzZUN2bDFhVTJMT3R6?=
 =?utf-8?B?NWZmN25zWkNucmlJK3RaQkFBYU9oVWJ1SHpoVUEwLzlhWmlMcXA2Rzhjb2Fz?=
 =?utf-8?B?VkVGVFU5Nk5va294V3lRMUk5TGZWeHJiYncwZG14QmZCeE1CYjNONkRwek1y?=
 =?utf-8?B?cXBIREVzeDNmNkJuWWhXTElrUVljRW1NK00zMmxicnlqSUVzNXNCblNxMFpa?=
 =?utf-8?B?QVk3RC9qcEl0eElxaFVzMHFXQ1oxdmZvTlhScVRjRGRWTnpFdlR0cHRwVGps?=
 =?utf-8?B?NVNIVit6aWNiSTFncEJ2QnNGMStmVjFEbEJNSHBhUUIwQU9TWEhrcG5odW0w?=
 =?utf-8?B?ZWhHeE4zYjZKVm5Hc3pGZzJPSkRSN214U0I5MWFMc2o2TVJjbGkzdDZYZWRV?=
 =?utf-8?B?YzdzbGpHcWU3cVBmYmRjQUx5OWZ1YjZqUzRQME1VdEMyb2V2MTIvamZlZm5a?=
 =?utf-8?B?QmxXQjlRWXhFUFFCeWdIaFZOUC9NR05LbEgwVjhvMjBHN1IvVDFtWmlWVDAw?=
 =?utf-8?B?RElPbjV1eVhIOTl5bHhpMTBZbXErRG9EV1lKcEFuVHorc2Y0bU9peGhxdDNS?=
 =?utf-8?B?czVqbGtpYjJ2K1QvNUluVitQL0pwNGdZSXlOd3R1TFRpRVVCU0tSbWp3VklR?=
 =?utf-8?B?YlNWRkhOdzRRVTVuWVpWS3JjTlRhbTRzVUJBNHI2YzA1Z2YyVUdHb1lRVXpE?=
 =?utf-8?B?dGJQSldBK2wvTnJ1N3hUQ3JIRkZpTWNVeWNReFFIZ3lVTHo2OXZ5Zm1wdVB1?=
 =?utf-8?B?OS9uYnB1bFBxS3FDWFVlbzZVd0JyM2FwUzhReXdwUWpWS3puam5LaTZzNHdZ?=
 =?utf-8?B?QWhjejVLNFhuOE5CVWtiVjJmbkRNNEJxekhPODhtTVlabE5idkVzL0VNUjM4?=
 =?utf-8?B?eU1ORUlZOWVvK2paZXRtZDhpTWltS2JSaHdaMnZCUDhpWEwxUmlaTjUzeUFl?=
 =?utf-8?B?V05lQW1Hd2xGTUs5TGFqTy80VGxYTkZmNm1ENWhYUVdyS1hJUytqeEw4YzFk?=
 =?utf-8?B?OW9oYUdrOGM3eHF5a0xEcWFzMUFBTWxYTnUxRzNzRFpxNHV0cU0yajJaZGFR?=
 =?utf-8?B?QmhudEs5WHprTE44aDI0R010TWRoS0d2N296RjZRdzhTYjZ0NHJMOEVlM1FQ?=
 =?utf-8?B?YThlbGI4SFA4Z210NTIvM0dXVUdPNzhId2J3VCs0T2hJSE1QUzBCYVhCOERo?=
 =?utf-8?B?RC8zWWVTcmJRVXlQNnBraFoxVzc4UldvZWpNM3czbWZQZmVhZXNhdjdaV1Qz?=
 =?utf-8?B?Zmo3aEx2QW03cHRPdU56ZDZMcEhJT2E3SDBPSmhjeE1zNmNxZ21FK2V6aThn?=
 =?utf-8?B?OGRHWCttaHhpSzh5TzQrQVNFckZQRnU4SW9IdnRMTG44OXY2L1kwakpkVXVZ?=
 =?utf-8?B?TXQwMzFodC94VTBPQm1weUxJTm5hRUM1RjJnR0hoQ01HYzBCZjc2dz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 655ab111-d532-4683-83cf-08da2803b71d
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 04:09:24.8368
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fSLQKKB1ButPZv/q9siv/bepivx9/r8TjrBL9dXWuDBk4N33z8qcNYglESv3Q0wr+6omaNum0hKKCfhW38HHYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4804
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMjUsIDIwMjIgNDo0MyBQTQ0KPiANCj4gV2hlbiBhIHBhZ2UgdGFibGUgZW5kcyB1cCB3
aXRoIG5vIHByZXNlbnQgZW50cmllcyBsZWZ0LCBpdCBjYW4gYmUNCj4gcmVwbGFjZWQgYnkgYSBu
b24tcHJlc2VudCBlbnRyeSBhdCB0aGUgbmV4dCBoaWdoZXIgbGV2ZWwuIFRoZSBwYWdlIHRhYmxl
DQo+IGl0c2VsZiBjYW4gdGhlbiBiZSBzY2hlZHVsZWQgZm9yIGZyZWVpbmcuDQo+IA0KPiBOb3Rl
IHRoYXQgd2hpbGUgaXRzIG91dHB1dCBpc24ndCB1c2VkIHRoZXJlIHlldCwNCj4gcHRfdXBkYXRl
X2NvbnRpZ19tYXJrZXJzKCkgcmlnaHQgYXdheSBuZWVkcyB0byBiZSBjYWxsZWQgaW4gYWxsIHBs
YWNlcw0KPiB3aGVyZSBlbnRyaWVzIGdldCB1cGRhdGVkLCBub3QganVzdCB0aGUgb25lIHdoZXJl
IGVudHJpZXMgZ2V0IGNsZWFyZWQuDQo+IA0KPiBOb3RlIGZ1cnRoZXIgdGhhdCB3aGlsZSBwdF91
cGRhdGVfY29udGlnX21hcmtlcnMoKSB1cGRhdGVzIHBlcmhhcHMNCj4gc2V2ZXJhbCBQVEVzIHdp
dGhpbiB0aGUgdGFibGUsIHNpbmNlIHRoZXNlIGFyZSBjaGFuZ2VzIHRvICJhdmFpbCIgYml0cw0K
PiBvbmx5IEkgZG8gbm90IHRoaW5rIHRoYXQgY2FjaGUgZmx1c2hpbmcgd291bGQgYmUgbmVlZGVk
IGFmdGVyd2FyZHMuIFN1Y2gNCj4gY2FjaGUgZmx1c2hpbmcgKG9mIGVudGlyZSBwYWdlcywgdW5s
ZXNzIGFkZGluZyB5ZXQgbW9yZSBsb2dpYyB0byBtZSBtb3JlDQo+IHNlbGVjdGl2ZSkgd291bGQg
YmUgcXVpdGUgbm90aWNhYmxlIHBlcmZvcm1hbmNlLXdpc2UgKHZlcnkgcHJvbWluZW50DQo+IGR1
cmluZyBEb20wIGJvb3QpLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRl
bC5jb20+DQoNCj4gLS0tDQo+IHY0OiBSZS1iYXNlIG92ZXIgY2hhbmdlcyBlYXJsaWVyIGluIHRo
ZSBzZXJpZXMuDQo+IHYzOiBQcm9wZXJseSBib3VuZCBsb29wLiBSZS1iYXNlIG92ZXIgY2hhbmdl
cyBlYXJsaWVyIGluIHRoZSBzZXJpZXMuDQo+IHYyOiBOZXcuDQo+IC0tLQ0KPiBUaGUgaGFuZyBk
dXJpbmcgYm9vdCBvbiBteSBMYXRpdHVkZSBFNjQxMCAoc2VlIHRoZSByZXNwZWN0aXZlIGNvZGUN
Cj4gY29tbWVudCkgd2FzIHByZXR0eSBjbG9zZSBhZnRlciBpb21tdV9lbmFibGVfdHJhbnNsYXRp
b24oKS4gTm8gZXJyb3JzLA0KPiBubyB3YXRjaGRvZyB3b3VsZCBraWNrIGluLCBqdXN0IHNvbWV0
aW1lcyB0aGUgZmlyc3QgZmV3IHBpeGVsIGxpbmVzIG9mDQo+IHRoZSBuZXh0IGxvZyBtZXNzYWdl
J3MgKFhFTikgcHJlZml4IHdvdWxkIGhhdmUgbWFkZSBpdCBvdXQgdG8gdGhlIHNjcmVlbg0KPiAo
YW5kIHRoZXJlJ3Mgbm8gc2VyaWFsIHRoZXJlKS4gSXQncyBiZWVuIGEgbG90IG9mIGV4cGVyaW1l
bnRpbmcgdW50aWwgSQ0KPiBmaWd1cmVkIHRoZSB3b3JrYXJvdW5kICh3aGljaCBJIGNvbnNpZGVy
IHVnbHksIGJ1dCBoYWxmd2F5IGFjY2VwdGFibGUpLg0KPiBJJ3ZlIGJlZW4gdHJ5aW5nIGhhcmQg
dG8gbWFrZSBzdXJlIHRoZSB3b3JrYXJvdW5kIHdvdWxkbid0IGJlIG1hc2tpbmcgYQ0KPiByZWFs
IGlzc3VlLCB5ZXQgSSdtIHN0aWxsIHdhcnkgb2YgaXQgcG9zc2libHkgZG9pbmcgc28gLi4uIE15
IGJlc3QgZ3Vlc3MNCj4gYXQgdGhpcyBwb2ludCBpcyB0aGF0IG9uIHRoZXNlIG9sZCBJT01NVXMg
dGhlIGlnbm9yZWQgYml0cyA1Mi4uLjYxDQo+IGFyZW4ndCByZWFsbHkgaWdub3JlZCBmb3IgcHJl
c2VudCBlbnRyaWVzLCBidXQgYWxzbyBhcmVuJ3QgInJlc2VydmVkIg0KPiBlbm91Z2ggdG8gdHJp
Z2dlciBmYXVsdHMuIFRoaXMgZ3Vlc3MgaXMgZnJvbSBoYXZpbmcgdHJpZWQgdG8gc2V0IG90aGVy
DQo+IGJpdHMgaW4gdGhpcyByYW5nZSAodW5jb25kaXRpb25hbGx5LCBhbmQgd2l0aCB0aGUgd29y
a2Fyb3VuZCBoZXJlIGluDQo+IHBsYWNlKSwgd2hpY2ggeWllbGRlZCB0aGUgc2FtZSBiZWhhdmlv
ci4NCj4gDQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+ICsr
KyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+IEBAIC00Myw2ICs0Myw5
IEBADQo+ICAjaW5jbHVkZSAidnRkLmgiDQo+ICAjaW5jbHVkZSAiLi4vYXRzLmgiDQo+IA0KPiAr
I2RlZmluZSBDT05USUdfTUFTSyBETUFfUFRFX0NPTlRJR19NQVNLDQo+ICsjaW5jbHVkZSA8YXNt
L3B0LWNvbnRpZy1tYXJrZXJzLmg+DQo+ICsNCj4gIC8qIGRvbV9pbyBpcyB1c2VkIGFzIGEgc2Vu
dGluZWwgZm9yIHF1YXJhbnRpbmVkIGRldmljZXMgKi8NCj4gICNkZWZpbmUgUVVBUkFOVElORV9T
S0lQKGQsIHBnZF9tYWRkcikgKChkKSA9PSBkb21faW8gJiYgIShwZ2RfbWFkZHIpKQ0KPiAgI2Rl
ZmluZSBERVZJQ0VfRE9NSUQoZCwgcGRldikgKChkKSAhPSBkb21faW8gPyAoZCktPmRvbWFpbl9p
ZCBcDQo+IEBAIC00MDUsNiArNDA4LDkgQEAgc3RhdGljIHVpbnQ2NF90IGFkZHJfdG9fZG1hX3Bh
Z2VfbWFkZHIocw0KPiANCj4gICAgICAgICAgICAgIHdyaXRlX2F0b21pYygmcHRlLT52YWwsIG5l
d19wdGUudmFsKTsNCj4gICAgICAgICAgICAgIGlvbW11X3N5bmNfY2FjaGUocHRlLCBzaXplb2Yo
c3RydWN0IGRtYV9wdGUpKTsNCj4gKyAgICAgICAgICAgIHB0X3VwZGF0ZV9jb250aWdfbWFya2Vy
cygmcGFyZW50LT52YWwsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
YWRkcmVzc19sZXZlbF9vZmZzZXQoYWRkciwgbGV2ZWwpLA0KPiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGxldmVsLCBQVEVfa2luZF90YWJsZSk7DQo+ICAgICAgICAgIH0N
Cj4gDQo+ICAgICAgICAgIGlmICggLS1sZXZlbCA9PSB0YXJnZXQgKQ0KPiBAQCAtODM3LDkgKzg0
MywzMSBAQCBzdGF0aWMgaW50IGRtYV9wdGVfY2xlYXJfb25lKHN0cnVjdCBkb21hDQo+IA0KPiAg
ICAgIG9sZCA9ICpwdGU7DQo+ICAgICAgZG1hX2NsZWFyX3B0ZSgqcHRlKTsNCj4gKyAgICBpb21t
dV9zeW5jX2NhY2hlKHB0ZSwgc2l6ZW9mKCpwdGUpKTsNCj4gKw0KPiArICAgIHdoaWxlICggcHRf
dXBkYXRlX2NvbnRpZ19tYXJrZXJzKCZwYWdlLT52YWwsDQo+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgYWRkcmVzc19sZXZlbF9vZmZzZXQoYWRkciwgbGV2ZWwpLA0KPiAr
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxldmVsLCBQVEVfa2luZF9udWxs
KSAmJg0KPiArICAgICAgICAgICAgKytsZXZlbCA8IG1pbl9wdF9sZXZlbHMgKQ0KPiArICAgIHsN
Cj4gKyAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGcgPSBtYWRkcl90b19wYWdlKHBnX21hZGRy
KTsNCj4gKw0KPiArICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UocGFnZSk7DQo+ICsNCj4g
KyAgICAgICAgcGdfbWFkZHIgPSBhZGRyX3RvX2RtYV9wYWdlX21hZGRyKGRvbWFpbiwgYWRkciwg
bGV2ZWwsDQo+IGZsdXNoX2ZsYWdzLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgZmFsc2UpOw0KPiArICAgICAgICBCVUdfT04ocGdfbWFkZHIgPCBQQUdFX1NJ
WkUpOw0KPiArDQo+ICsgICAgICAgIHBhZ2UgPSBtYXBfdnRkX2RvbWFpbl9wYWdlKHBnX21hZGRy
KTsNCj4gKyAgICAgICAgcHRlID0gJnBhZ2VbYWRkcmVzc19sZXZlbF9vZmZzZXQoYWRkciwgbGV2
ZWwpXTsNCj4gKyAgICAgICAgZG1hX2NsZWFyX3B0ZSgqcHRlKTsNCj4gKyAgICAgICAgaW9tbXVf
c3luY19jYWNoZShwdGUsIHNpemVvZigqcHRlKSk7DQo+ICsNCj4gKyAgICAgICAgKmZsdXNoX2Zs
YWdzIHw9IElPTU1VX0ZMVVNIRl9hbGw7DQo+ICsgICAgICAgIGlvbW11X3F1ZXVlX2ZyZWVfcGd0
YWJsZShoZCwgcGcpOw0KPiArICAgIH0NCj4gDQo+ICAgICAgc3Bpbl91bmxvY2soJmhkLT5hcmNo
Lm1hcHBpbmdfbG9jayk7DQo+IC0gICAgaW9tbXVfc3luY19jYWNoZShwdGUsIHNpemVvZihzdHJ1
Y3QgZG1hX3B0ZSkpOw0KPiANCj4gICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UocGFnZSk7DQo+
IA0KPiBAQCAtMjE4Miw4ICsyMjEwLDIxIEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGNmX2No
ZWNrIGludGVsX2kNCj4gICAgICB9DQo+IA0KPiAgICAgICpwdGUgPSBuZXc7DQo+IC0NCj4gICAg
ICBpb21tdV9zeW5jX2NhY2hlKHB0ZSwgc2l6ZW9mKHN0cnVjdCBkbWFfcHRlKSk7DQo+ICsNCj4g
KyAgICAvKg0KPiArICAgICAqIFdoaWxlIHRoZSAoYWIpdXNlIG9mIFBURV9raW5kX3RhYmxlIGhl
cmUgYWxsb3dzIHRvIHNhdmUgc29tZSB3b3JrIGluDQo+ICsgICAgICogdGhlIGZ1bmN0aW9uLCB0
aGUgbWFpbiBtb3RpdmF0aW9uIGZvciBpdCBpcyB0aGF0IGl0IGF2b2lkcyBhIHNvIGZhcg0KPiAr
ICAgICAqIHVuZXhwbGFpbmVkIGhhbmcgZHVyaW5nIGJvb3QgKHdoaWxlIHByZXBhcmluZyBEb20w
KSBvbiBhIFdlc3RtZXJlDQo+ICsgICAgICogYmFzZWQgbGFwdG9wLg0KPiArICAgICAqLw0KPiAr
ICAgIHB0X3VwZGF0ZV9jb250aWdfbWFya2VycygmcGFnZS0+dmFsLA0KPiArICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBhZGRyZXNzX2xldmVsX29mZnNldChkZm5fdG9fZGFkZHIoZGZuKSwg
bGV2ZWwpLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZXZlbCwNCj4gKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgKGhkLT5wbGF0Zm9ybV9vcHMtPnBhZ2Vfc2l6ZXMgJg0K
PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKDFVTCA8PCBsZXZlbF90b19vZmZzZXRf
Yml0cyhsZXZlbCArIDEpKQ0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyBQVEVf
a2luZF9sZWFmIDogUFRFX2tpbmRfdGFibGUpKTsNCj4gKw0KPiAgICAgIHNwaW5fdW5sb2NrKCZo
ZC0+YXJjaC5tYXBwaW5nX2xvY2spOw0KPiAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShwYWdl
KTsNCj4gDQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 04:12:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 04:12:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314336.532348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njZ2W-0001Rp-B4; Wed, 27 Apr 2022 04:12:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314336.532348; Wed, 27 Apr 2022 04:12:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njZ2W-0001Ri-79; Wed, 27 Apr 2022 04:12:32 +0000
Received: by outflank-mailman (input) for mailman id 314336;
 Wed, 27 Apr 2022 04:12:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/sE=VF=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1njZ2U-0001Rc-PY
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 04:12:30 +0000
Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e4e806d-c5e0-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 06:12:27 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Apr 2022 21:12:24 -0700
Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15])
 by orsmga005.jf.intel.com with ESMTP; 26 Apr 2022 21:12:24 -0700
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
 ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 26 Apr 2022 21:12:24 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
 orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 26 Apr 2022 21:12:24 -0700
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101)
 by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 26 Apr 2022 21:12:23 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM5PR11MB1850.namprd11.prod.outlook.com (2603:10b6:3:112::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 04:12:15 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb%2]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 04:12:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e4e806d-c5e0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1651032747; x=1682568747;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=V2idaFxucHiJGDXQSdaMMES8a8n6WWlBDcoqFbA5KEU=;
  b=MVcf1EEdXtgL/jI3SthBpCHUpgLax13xpG9v0KtvaSoacqjN2ikvTAaw
   6sfos+lUPOfDHgtZGn3T4MNRP2D4AQkEKkglTnaSfnb0r51hTvoy1wQWi
   qiHT6Q7rVm9vx/eyjRZCqOoWJ35RTiap+Bb1XGx0FFdcnK95QFlW4Lfjx
   LF8cw2J47uvJekI8JhNWvL4KjqGGPmdp4zXtr7XftW+JNWDKtacNucDbg
   gZrLrT2os8lV+IPvIbSX7lajbRlYrnsHNjsIJOLwMHDLgfCkrQNKqQhSc
   v8GWgTvaTgISOcIKmf1AIa3d1VwsQaQXSAShs755QnzPOff5YzuiOVd4p
   A==;
X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="326297039"
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="326297039"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="730597254"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LBMIMU9MKCWTx12g9jQmq+rxMmBH5uCWl0n4L1GfqvCYBtuhDDZgTS5VBcyEKjtWZJY1V7LM1vsgAIY8o5vSX3dc9PgLJzO+sTXFaiN8yFTN4qzdDArUMGVM2YM9qkxfbkUxfbwtI5K4UQdsO7L4B8AjDskIm/WHZ29iECKrubdhCHJSd4Cfd8hTzhNqDj2nwu98baG2X7C76KeCjTjn4A0E5icnO7AYd+KOLpMULSo8VPXCqfbtK3vzw3y6xFjG1wKJL7SYsZ6qys6b8dfohEvvgkT3PRfJcHlhRbug0+fdUvd/ayHWgP/PNkoRoL+wr7EqQGyNy0TcBFICX0wbTw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V2idaFxucHiJGDXQSdaMMES8a8n6WWlBDcoqFbA5KEU=;
 b=KkKrSY/JDVLSieQrCzmbdqUqExX4FxznUZJu8kRc36za2bny655Qwpq+BdUp/Bm84uEnBMhqJbvQoQpGDQQYlDMJptImhn8e0NYkQwGJVaoO9V2af/ycW7AzgFjsKmyBZw9Vioxx9dnJqnersrzYVP/Ub10u7G/FDtjghO3oTCczwsj/33Kl+zDEQ2mpFmIao7niGRpze23NHeqJg901OsXpHMp8t3sJeZqgrww5F7SxLeWYw2yNDhfB4HgUsHs9P3S0HsVIpAEFMe/fW5rvbj2nK3XJuirvFVi8iEz0c2XrCSr7Z38k7ECZnZe1mpqL3x6ygE1DgFrSJ02jRHbCAQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH v4 20/21] VT-d: fold iommu_flush_iotlb{,_pages}()
Thread-Topic: [PATCH v4 20/21] VT-d: fold iommu_flush_iotlb{,_pages}()
Thread-Index: AQHYWIC6Eez4ojrFhkKf16nX7g3O4a0DKNrw
Date: Wed, 27 Apr 2022 04:12:15 +0000
Message-ID: <BN9PR11MB5276FFEA0150548AA4BDEA698CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
 <eec16b83-7f8f-e94d-b1f6-9113ff93fd14@suse.com>
In-Reply-To: <eec16b83-7f8f-e94d-b1f6-9113ff93fd14@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3e2059fd-d291-42b0-48e6-08da28041cf9
x-ms-traffictypediagnostic: DM5PR11MB1850:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM5PR11MB1850D6337EB3305900B525218CFA9@DM5PR11MB1850.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: VPjMTssCydOlT/KOp2M41XMcQkSBAqG4GOFCoO8YxJI5MAIuPLpFFrIuDpX7IH4FaTwRZr7hlbqtLMjv3GSBomIa5Y5CmrV6kliV1ra30dCfiPGWH51R+6Wq0R5dnIniSzZpJ/y/jZWf0nx/MDOvybBzPXRBzdLE1Df0NglZaOIG7U+STzhQlgM9In0tXt9E7EOHzzs46FJpQ1teHVmFmsQ0nOYQc0X8m5BBOz7CeMTjC1PJ4/XGVr+ZrjgMR1NPFpaboJ1Ucerjt5GvfxpL0N/ijOmLEEPvGaruv1HJTqLOOTMEZFfqIcOEBX8V3OBakiM+tWWOcHfcdXfXv466DIMgRdrVtCQFw5zagjKzbZE1eX8xXzenLwZq4WB3sRQvMSKeWIx8HoWwAMBHQ0IoF/duolv+NJLtnE9ARy2n7bCLfYHcC04rpSOz6bqwf0fHZROsZdUWco2DYKn92vD9ZxUs8dfsas6orUojSme3r9sO5e8nT9pt06jQjxEc5z0G1FTSen9dyak1LNId/qJme9waZ1NQ+JZpXpIACSERbd7DryhAYseFp9Wktz35xFNaWQ6oDdejJ+/VK58bmwafSBFhN8TwUPdkcBdklyfvfhzW7VEGu5LY5zxdPLoNwZhfYb6fQE4jF7BnnQ2eRJ7VDla0dopFmpcT8pZ5UlM8uMm5fUVDWQuKk2IPooEcNm5FZ6YnMMTlFMVl2gqm7RAqAQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(71200400001)(83380400001)(66476007)(66556008)(66946007)(76116006)(64756008)(54906003)(5660300002)(66446008)(316002)(110136005)(4326008)(8676002)(52536014)(122000001)(86362001)(508600001)(186003)(8936002)(55016003)(82960400001)(38100700002)(38070700005)(7696005)(6506007)(26005)(9686003)(33656002)(2906002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VVFISTllK1VaODBqT1dQemt2d04vYTJUalRxWHUxYldMeFkwODB1WlVWUEM3?=
 =?utf-8?B?b0pmaWFGMFRVUlRhR1V5aU5kMzBMTEhuSWY0VmI1allkdy95VnhXTlhzKzNM?=
 =?utf-8?B?UVE2RllTbWFDL0dFN1dwUWVyQS9mbnUvb0puSWJWSWMyM1dmL2FqRzZKYWZ3?=
 =?utf-8?B?M2hvSk5STUR6K0RFV3JoRi9DQ0wxZ0MwMHh6d1RSWlMwb2pqVUJ3SGEwZTBF?=
 =?utf-8?B?aUVtNVNBekpJeVIvWTErOFNpZTh1c3QzRmFic1RxM0NoUUdESlJuSXJVTjZB?=
 =?utf-8?B?eGczcWM1aEZUK2svQ3h5R1lGNTdINGh6N3ZEYjM5dWhzYVhEeWtXbExRanJw?=
 =?utf-8?B?cFNsU3lsU2Z5S1hSait4TlRFSDhLYWlPSyt0Q2JVb0JxbFp4WDhJSzk0TTR0?=
 =?utf-8?B?WlpHQ2tnYjBlQzYwU1J1QnpUU0RWMHRZdmxYRnRZOWlRcTdmSkNPSVBnY05s?=
 =?utf-8?B?MVFDUnpkMU9QZ1g1ajVVeWpqSmV0aUw3Qi9EQkVWd05LZzNjTlBsNG1GMklJ?=
 =?utf-8?B?ZkEwQy9TOStQek1oUzQ2dFhXSkR4VHh3UzJ4eXd2R2RRcG5WSjlFa0NtajVi?=
 =?utf-8?B?RjRIb0p3dEFRbnpxYWxtMHBkZFpYM2Z5R3B2UmVrV2VCVGVUNzQvWUxQT1JR?=
 =?utf-8?B?V25yN0Q3VjN3UC9TZnRMa25meWt2SWliUE9OR3ppUW1oRmtFWFh2Yjdvcmcr?=
 =?utf-8?B?UUNabFhLNko1aTZ2L0NtZzhpUnNVNjlUUmdVWUVJM1JtUDhrSk9EMnpGeG01?=
 =?utf-8?B?VDc1dk9hZ2U3bzR2bnoyUlR0bERjZmc5NkFUeHZMRFVpU0p4OS9rN2xGbmJ2?=
 =?utf-8?B?dURDbVN0Ym9wWlNKMG5SeGFtSUEzVmJUakkveWplYTczdlFXUlltdEVkSkZm?=
 =?utf-8?B?RnpxTmFJS2t6UHpXWXZJN0UramQxMmZEU3VFTkRYWlEySWw5OENhVEhyYUxV?=
 =?utf-8?B?akxMSWtOeWZsYTVCeExFbTlONHFBN2ZTLzJEbTVsRXNKOWQrbzNFbTZreEhv?=
 =?utf-8?B?Z3BGejYxbVZqQmJyMDlTNU9pYlhueGlVb1VQWFBYZENZNVJyUy8vWDd6V2xa?=
 =?utf-8?B?RUVja2N0S2lnOHJOWFpoTjRiUVVCbjgzaXg5elVPZVAwSFVvWk81V2djSVl0?=
 =?utf-8?B?dzVSc2dBNWV2c2xGOW5VMFRDNlUyVmhzaHNuMkIrUjZ6NFd4SS9CdTJDcUov?=
 =?utf-8?B?NGpRSVZtQzE3cUM2WWw4WlRtcHVvb3pRN1lmVk1QOEY5dER0U0N4KzBmV0xV?=
 =?utf-8?B?V3RZVHd5TXZKVFE0c1kvWkg2N1Y2VmhSVkpUUGVEMDIxMXA0S3pndE8wTzhR?=
 =?utf-8?B?Tkp2bDJmcWJCT3RzZzRCdEZOLzFIZGo4U2NRdHcrWWlMTzVnN0xiMkpWMHZC?=
 =?utf-8?B?YmhqSDlFMkVFTnVrMmtZbzRiclc2dkw1R2ZZWUVydFNGSVRGbHM3M0FQQnBh?=
 =?utf-8?B?UDF4dnBCUlRWdlpMenphV1R4Tm94bHYwMGJqL1pFQnNycXVtZE42TmRkWTRH?=
 =?utf-8?B?R21BZjEyelBmaGFnZWUyRXMySks2ZUFzMEcrRnpZYjY5ZkNLdDlPREJYeFB0?=
 =?utf-8?B?RFEza1RLQnJzcDJaY3JvSkZpdDdMckhLbGYrVFRtbklkbDZHdlZib2xjQWZx?=
 =?utf-8?B?Z1pKclBJMUhpSTZsV1Q1ZndDWXppaVhPMTVNaFhEZVR1MktHbVhMMFhpRDJE?=
 =?utf-8?B?YjBrdnlZZTM4Myt0Z2k1VlAxQUcrdmZoZStDeU9FemIwOW5yalhmOE8wUjRB?=
 =?utf-8?B?cHRvYi9GYmlqRDhOWWQzZkRzL2FQQmNBbUlpSi9xaTgxSHZxM20rQXpQOWI1?=
 =?utf-8?B?ME1nYmp1cnpUL2l5QjZxeUxtY2ExL2ZVMElkaDMrVW1tUjNHVHRKd2RyQ2hw?=
 =?utf-8?B?TmxMbzFwa3lqb1MvSUQrckhSUWJzUndjZXNtWE5MZUlYU3JXQ0NvdVJBTzNE?=
 =?utf-8?B?dlpIb1dKcmpTK1FGdUJEdW45MGZDN1JEV0RGMzEyVXFkaWdMRzlUcFlIWW96?=
 =?utf-8?B?WlpFTlpSUWlScXhOTWV4anhzQTgwYzFodTIwUmVYUElUZmg5bDJWR2M1R21q?=
 =?utf-8?B?L21vSFFVZVcyS2EvTERCdnJyRUs0eWNrb2h6Y0ZJV09FZmdvanhXU3o5WHdU?=
 =?utf-8?B?Wjc4V3Z2ZWZTVmp5YjUySlNVdW9sbm9KUVBjc0xrOW9KUU42ZHFyUHZJTjVD?=
 =?utf-8?B?c1dZNXVjUmsxVXV3MVhkME1aSFlWSFhjS2ZUMUhlYWRlcmxEKzNVMFozU3Fn?=
 =?utf-8?B?dkZjVlZoZlNjcUtuNU9DWnJON0JiNmhnY05SMUdTYXE3N0R2TUV3S1UyVWhw?=
 =?utf-8?B?WEFzcStBSm9LRkI2WFdadVo0K1BqSVhWY0kwK0ZYS1N2b0VjbUxTdz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e2059fd-d291-42b0-48e6-08da28041cf9
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 04:12:15.6801
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6SybKiNX8BSUwYkIfTFRadLnr65bcP+iaO9Tgz1Td4ojleWwEwnz1h6+nOPmg2EEf7e1LoKGoWrBmjHaqkJd7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1850
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMjUsIDIwMjIgNDo0NSBQTQ0KPiANCj4gV2l0aCBpb21tdV9mbHVzaF9pb3RsYl9hbGwo
KSBnb25lLCBpb21tdV9mbHVzaF9pb3RsYl9wYWdlcygpIGlzIG1lcmVseSBhDQo+IHdyYXBwZXIg
YXJvdW5kIHRoZSBub3Qgb3RoZXJ3aXNlIGNhbGxlZCBpb21tdV9mbHVzaF9pb3RsYigpLiBGb2xk
IGJvdGgNCj4gZnVuY3Rpb25zLg0KPiANCj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UgaW50ZW5kZWQu
DQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoN
ClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg0KPiAtLS0N
Cj4gdjQ6IE5ldy4NCj4gDQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21t
dS5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+IEBAIC03
MjgsOSArNzI4LDkgQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgaW9tbXVfZmx1c2hfYWxsKA0K
PiAgICAgIHJldHVybiByYzsNCj4gIH0NCj4gDQo+IC1zdGF0aWMgaW50IF9fbXVzdF9jaGVjayBp
b21tdV9mbHVzaF9pb3RsYihzdHJ1Y3QgZG9tYWluICpkLCBkZm5fdCBkZm4sDQo+IC0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sX3QgZG1hX29sZF9wdGVfcHJl
c2VudCwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2ln
bmVkIGxvbmcgcGFnZV9jb3VudCkNCj4gK3N0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGNmX2NoZWNr
IGlvbW11X2ZsdXNoX2lvdGxiKHN0cnVjdCBkb21haW4gKmQsDQo+IGRmbl90IGRmbiwNCj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVk
IGxvbmcgcGFnZV9jb3VudCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbHVzaF9mbGFncykNCj4gIHsNCj4gICAgICBz
dHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsNCj4gICAgICBzdHJ1Y3QgYWNw
aV9kcmhkX3VuaXQgKmRyaGQ7DQo+IEBAIC03MzksNiArNzM5LDE3IEBAIHN0YXRpYyBpbnQgX19t
dXN0X2NoZWNrIGlvbW11X2ZsdXNoX2lvdGwNCj4gICAgICBpbnQgaW9tbXVfZG9taWQ7DQo+ICAg
ICAgaW50IHJldCA9IDA7DQo+IA0KPiArICAgIGlmICggZmx1c2hfZmxhZ3MgJiBJT01NVV9GTFVT
SEZfYWxsICkNCj4gKyAgICB7DQo+ICsgICAgICAgIGRmbiA9IElOVkFMSURfREZOOw0KPiArICAg
ICAgICBwYWdlX2NvdW50ID0gMDsNCj4gKyAgICB9DQo+ICsgICAgZWxzZQ0KPiArICAgIHsNCj4g
KyAgICAgICAgQVNTRVJUKHBhZ2VfY291bnQgJiYgIWRmbl9lcShkZm4sIElOVkFMSURfREZOKSk7
DQo+ICsgICAgICAgIEFTU0VSVChmbHVzaF9mbGFncyk7DQo+ICsgICAgfQ0KPiArDQo+ICAgICAg
LyoNCj4gICAgICAgKiBObyBuZWVkIHBjaWRldmVzX2xvY2sgaGVyZSBiZWNhdXNlIHdlIGhhdmUg
Zmx1c2gNCj4gICAgICAgKiB3aGVuIGFzc2lnbi9kZWFzc2lnbiBkZXZpY2UNCj4gQEAgLTc2NSw3
ICs3NzYsNyBAQCBzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBpb21tdV9mbHVzaF9pb3RsDQo+ICAg
ICAgICAgICAgICByYyA9IGlvbW11X2ZsdXNoX2lvdGxiX3BzaShpb21tdSwgaW9tbXVfZG9taWQs
DQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZm5fdG9fZGFkZHIo
ZGZuKSwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdldF9vcmRl
cl9mcm9tX3BhZ2VzKHBhZ2VfY291bnQpLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIWRtYV9vbGRfcHRlX3ByZXNlbnQsDQo+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAhKGZsdXNoX2ZsYWdzICYgSU9NTVVfRkxVU0hGX21vZGlmaWVk
KSwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsdXNoX2Rldl9p
b3RsYik7DQo+IA0KPiAgICAgICAgICBpZiAoIHJjID4gMCApDQo+IEBAIC03NzcsMjUgKzc4OCw2
IEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGlvbW11X2ZsdXNoX2lvdGwNCj4gICAgICByZXR1
cm4gcmV0Ow0KPiAgfQ0KPiANCj4gLXN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGNmX2NoZWNrIGlv
bW11X2ZsdXNoX2lvdGxiX3BhZ2VzKA0KPiAtICAgIHN0cnVjdCBkb21haW4gKmQsIGRmbl90IGRm
biwgdW5zaWduZWQgbG9uZyBwYWdlX2NvdW50LA0KPiAtICAgIHVuc2lnbmVkIGludCBmbHVzaF9m
bGFncykNCj4gLXsNCj4gLSAgICBpZiAoIGZsdXNoX2ZsYWdzICYgSU9NTVVfRkxVU0hGX2FsbCAp
DQo+IC0gICAgew0KPiAtICAgICAgICBkZm4gPSBJTlZBTElEX0RGTjsNCj4gLSAgICAgICAgcGFn
ZV9jb3VudCA9IDA7DQo+IC0gICAgfQ0KPiAtICAgIGVsc2UNCj4gLSAgICB7DQo+IC0gICAgICAg
IEFTU0VSVChwYWdlX2NvdW50ICYmICFkZm5fZXEoZGZuLCBJTlZBTElEX0RGTikpOw0KPiAtICAg
ICAgICBBU1NFUlQoZmx1c2hfZmxhZ3MpOw0KPiAtICAgIH0NCj4gLQ0KPiAtICAgIHJldHVybiBp
b21tdV9mbHVzaF9pb3RsYihkLCBkZm4sIGZsdXNoX2ZsYWdzICYgSU9NTVVfRkxVU0hGX21vZGlm
aWVkLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWdlX2NvdW50KTsNCj4gLX0N
Cj4gLQ0KPiAgc3RhdGljIHZvaWQgcXVldWVfZnJlZV9wdChzdHJ1Y3QgZG9tYWluX2lvbW11ICpo
ZCwgbWZuX3QgbWZuLCB1bnNpZ25lZA0KPiBpbnQgbGV2ZWwpDQo+ICB7DQo+ICAgICAgaWYgKCBs
ZXZlbCA+IDEgKQ0KPiBAQCAtMzI1NCw3ICszMjQ2LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBp
b21tdV9vcHMgX19pbml0Y29ucw0KPiAgICAgIC5zdXNwZW5kID0gdnRkX3N1c3BlbmQsDQo+ICAg
ICAgLnJlc3VtZSA9IHZ0ZF9yZXN1bWUsDQo+ICAgICAgLmNyYXNoX3NodXRkb3duID0gdnRkX2Ny
YXNoX3NodXRkb3duLA0KPiAtICAgIC5pb3RsYl9mbHVzaCA9IGlvbW11X2ZsdXNoX2lvdGxiX3Bh
Z2VzLA0KPiArICAgIC5pb3RsYl9mbHVzaCA9IGlvbW11X2ZsdXNoX2lvdGxiLA0KPiAgICAgIC5n
ZXRfcmVzZXJ2ZWRfZGV2aWNlX21lbW9yeSA9DQo+IGludGVsX2lvbW11X2dldF9yZXNlcnZlZF9k
ZXZpY2VfbWVtb3J5LA0KPiAgICAgIC5kdW1wX3BhZ2VfdGFibGVzID0gdnRkX2R1bXBfcGFnZV90
YWJsZXMsDQo+ICB9Ow0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 04:13:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 04:13:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314341.532359 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njZ3N-0001zm-LK; Wed, 27 Apr 2022 04:13:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314341.532359; Wed, 27 Apr 2022 04:13:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njZ3N-0001zf-Ha; Wed, 27 Apr 2022 04:13:25 +0000
Received: by outflank-mailman (input) for mailman id 314341;
 Wed, 27 Apr 2022 04:13:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/sE=VF=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1njZ3M-0001k0-De
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 04:13:24 +0000
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5fda170c-c5e0-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 06:13:23 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Apr 2022 21:13:20 -0700
Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86])
 by fmsmga001.fm.intel.com with ESMTP; 26 Apr 2022 21:13:20 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 26 Apr 2022 21:13:20 -0700
Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27; Tue, 26 Apr 2022 21:13:19 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.27 via Frontend Transport; Tue, 26 Apr 2022 21:13:19 -0700
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104)
 by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.27; Tue, 26 Apr 2022 21:13:19 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM5PR11MB1850.namprd11.prod.outlook.com (2603:10b6:3:112::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 04:13:11 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::24dd:37c2:3778:1adb%2]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 04:13:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fda170c-c5e0-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1651032803; x=1682568803;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=TuKrAf6OA0DwT66o2+6ye9e++dhZiNMNwvQGFdNxR/0=;
  b=ZTIyfn20jlYlrj8FyS5e72iVjGavE9VgWfLXGwsgzE/tVv34o5YIIxzE
   nHrfaIaoGFuVx4Z6sabW1iLRiXu0/Gv5szoZv4y4NWPmpDfv8oK0CvmQW
   AiCCvFvSi77zfQdZKS/mvzpxeux+oudau57bYrijsFd0G3yWm3rplCzLv
   RAee4ePDDcEgvgqRdzl7dko7hEe+730w8T7LjIRiA5Ap4CCRm3xE4VNHA
   8al2AFrLCWYZKVvSy0vM4xV4/y4GN28gpLAWgO4i7UiS2gT99gJwW33Vv
   XFU5ISNLxTsVqdhRmbv9lrHzLxsw90CoL+6j5yCGJ6Iym0H+948c9a0dC
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="245730240"
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="245730240"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; 
   d="scan'208";a="705365061"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b/IcKbyMNhFK5MpRzRXPjSmbF3UKmHwWbRFfqtWxB1sf/q5HFeUh/TcIZJbVIAUL5Z9G19SQmhDDssd+a64JFzCsF4SJiF++J/96rPUp0K9EUzwAcCAb+6YidcxKQ1a+AcVeVwwZ6YxcuEbUB+buuS5jfGKRzknAOhBh7DvMbNwmRzUV1JE+II4mt0oyQb5gwf6+I2CX+/HcKypvkLgkTXwiK1sQ1rCc38VfRo5/F11ixDSn2+dTEdmrNZnPU6QG2x0FOOyfDfzhcarl2Zn4PKrK5Ta6qFNSWAaGpm48OYlO7zuZ61BxhfX1VdVuJ9DcRpbWrNDdctgl6HiIPPIAgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TuKrAf6OA0DwT66o2+6ye9e++dhZiNMNwvQGFdNxR/0=;
 b=d96z/F3vujFvI/poTD5lyOMTNCCOBnaWsKXB/nbcOgteCvqWrVNflHZBrs9UyRiPmN0+sTU1FPT69kW7WrELuLJQzbzmkpKEBg5KuAOUHaxvel4O3kCPsBAupExpiMjp4Is7p8roF+1N3e3ebOzVBN2EykSw0XmXaq5w5JK/yMivp/NtULH647MN6gHKZ02G02oRrNWgvhj9OxIefSN3JN3A7SM2KKodKd6jZ5uBcWRn1SYdGY/m42EpYoFtsIgbtxDJVIo9OD9dXyWMln3AJ0BF8Ksp9caQ8kQHsfqL7oBd869T4GGbBu3UQiGCemt43nYmflgSyytrM+v9Q0wy3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH v4 21/21] VT-d: fold dma_pte_clear_one() into its only
 caller
Thread-Topic: [PATCH v4 21/21] VT-d: fold dma_pte_clear_one() into its only
 caller
Thread-Index: AQHYWIDPpY/WdqPWHkWCZK6rwaQRsK0DKRsg
Date: Wed, 27 Apr 2022 04:13:11 +0000
Message-ID: <BN9PR11MB52768648BBD4F64235F717C08CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
 <4a24a85e-267f-9de5-4009-b32b9ab8aa0d@suse.com>
In-Reply-To: <4a24a85e-267f-9de5-4009-b32b9ab8aa0d@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0c4c4275-a5f0-4da7-7480-08da28043e41
x-ms-traffictypediagnostic: DM5PR11MB1850:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM5PR11MB185008B70A5CE69538BFBF2F8CFA9@DM5PR11MB1850.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: yg1rrKzNKSDvZIrdbJulT4qjFzhj+ITh3ZORLPoF9TaMyyGXT+lDofD7E4GtuFRW0OSTGgM6SOvvh30V7UsuD5AOg13WesZwaXldVowtohL517cW34rxJ8hQGJWq1hSZND8LIHQgH6SEDJL5yZu4P0CuJeQ/FW3yETv398hGIdlXh1ONWfrxz8Ia/Lpq0nZo+63gijOmDjm2q/otWdS/3b42gDZtARBHibwLbHnFdVIRlLaoUX5/HTn7BQVrKILmrNeYJjpxw2KO3PyiH2HWa97OzcR73367ZooBx6s2keFq6Zmr/Xw1VlQn620C/2DGKHumf13B4UdTsPyNscb61v2aLeX1KWsq0wzGEjcZBx/JH2dYEQK8A1O85Lmjw/s9wYfd05xFZQNg4IjN96v6vTOJlOxd6dajpxW9bASBb/MuusMpwc2jFEfFBhN9ggZKDxUkCdtLY4VCmeJlaIHfHyAzpDbS+sNtur2DYmvXtR4ltIjjBt/1IZ9tOjWCr1SxIx/9W09ifrU8mwPJpf0I+2kkYBcdkpgY6zuJA9Z9cCumjPoyu/cNAmf3RfkzKoWs3TSv0vVjq/ZRu0X3niWEn0ZLFU29npAYy5QnpgorplvpAdcQE+Pef3zM7K5KKNdLsPiPgdfAp5EXsnhSAV8coQjpmkMVZb6UI3tgAjjrm1X/S2MeVX4iYARUO+4QApqW0mToVvJrulSKGlNkF2U/YA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(71200400001)(83380400001)(66476007)(66556008)(66946007)(76116006)(64756008)(54906003)(5660300002)(66446008)(316002)(110136005)(4326008)(8676002)(52536014)(122000001)(86362001)(508600001)(186003)(8936002)(55016003)(82960400001)(38100700002)(38070700005)(7696005)(6506007)(26005)(9686003)(33656002)(2906002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aG1QV2U0Y1pMQ2tSaWJ2Q2t6R3RJRmk0TkhYUWhqUE5uVHg2S2daQlNCZ1Zl?=
 =?utf-8?B?QVByM21HQnViMDA5QThMcjBqVTFBTDVxMmRHYk1nSERKUVNQOEdwbW9WUU1Q?=
 =?utf-8?B?VEZNVjJsMk5tWEZsWnJCaXNtdzJwY2h5MXJ6QjNCOXZ0andyYjR3MlBmcFht?=
 =?utf-8?B?TlYwdUFMVG41T2pFWjQ1V1BrQVFaVENoMnlRd04zUURQQU1QWHBrSWhjUmF2?=
 =?utf-8?B?d240UVNMTnUyUCtGMTB3cVMzbFBYRE92NVRrTmxidFVkTEsvbmowdmdsOVh6?=
 =?utf-8?B?cHd1YTVUZ0VwckVVVVlQekxpd2UzVXVFbnJ4eWFpQmVRSEEzUlBnR3hyVkdU?=
 =?utf-8?B?Rmx6U0Q4STF2UkcrUUZpSzBTTmJOMVdaZm1TTFBQQWw5bGVKSFgyWU11SGgy?=
 =?utf-8?B?V3laMUhxYXBRcFQwbFNoTkdBYlFpUlZXWTFsYks5M3dmaFZhNWNKMUthWVdl?=
 =?utf-8?B?Q1FydTN5eWdvc3lxQzkycGMvekJ1ZmxsQ0dKL2JuMXZkdE43NDhNNmNrWmUv?=
 =?utf-8?B?aTh2RWg1WDlkRSsxTExBMm4zNnc1SVA4SDNwRTR2L29IYjNGRFJXanZFNmFM?=
 =?utf-8?B?Tm5BcXV3VnJneWQ4Qm42cUREWDlQSzlHWU8vRDhBZ21yWFViYjYyUUZ2cUls?=
 =?utf-8?B?ajFCWWEyTCt0OUlsNGtQU2xnYnlvZjhJOWdWN3hIYmdnWFNERmJmU05xVm9U?=
 =?utf-8?B?Z0FFWmtHNm5nM3FPUXpZQ3dPWThaMkJyaXhuTmZZaUcrdXZ0ZGlCTzZCWnE0?=
 =?utf-8?B?REc5V0ZPU1NCdENJdmJFRkoyQ1pZVHRhckRGbEh0YTVrWjdWWVVuVHBIQVVM?=
 =?utf-8?B?VEJaY00wWE90cUhBa2JsMVI1VWtNazRuLzIxNGpiSHh4SzNVaVlkTCswUXhP?=
 =?utf-8?B?djJwYVlOdjIzNmI0ZG5ER3V3N1BVZDl6WU9VZUo1cUliTno5NlZ3dU0zQUZs?=
 =?utf-8?B?bi94N1lUTk90VzVHWWQybUVnNnBxWGtRemlJM3RLWXhHWXdGTVo4enJwZndy?=
 =?utf-8?B?TVVWYVRTcWtwTXVDdnNYSTdPRE4rSkhTZWZHd3VCU29EY2ViZW1aMENYSlZU?=
 =?utf-8?B?aFNDRU1iZW1keXQyRVpJYVBnRENiMERYRmx5UmtOYmQydk5XNmhZejVIY3Fr?=
 =?utf-8?B?N1BTc0lKZjhwdmlER25qR3F1S1R2eFFyN2Yvb2NTTFpRc0ZSZ1cvWWZiUy9p?=
 =?utf-8?B?REQzVG5ESlZKb1V2dVJIZE44aUdjRkhIVzlJeWVxdkgrbWtOb2pRTlVLTDhV?=
 =?utf-8?B?MGRhR2l2aFpJY3JhK3Fva0ZtVFlwMXlxUmkrK2MxaGc0TlN6TnRGdVJ4UVgr?=
 =?utf-8?B?VlJrRzlyamlNaTJQdHR4Y1VQV0hzMzRFUXFncHQ2WHpMR0hMUVVyd0Nra2J0?=
 =?utf-8?B?cTcvZWprRTE0WkFiclgyeVVnZW42TG1YZ1hvd0Y4VkgyMXZhTTkvR3VhbnN0?=
 =?utf-8?B?VFFuNHdjbEZZeG5JTHlEd0NWVFRSN01JNVFtSUM3MWZ6am5PL2hGR1prZDNx?=
 =?utf-8?B?QzJuZmNoZGo2SkVEeGlxT1dtcGtFZ3g3ZkY4dzV4clFibk9Fc3Vhb09QS09s?=
 =?utf-8?B?Szk4UUpubGJBUll4bWlMQ1owL3dmNFh1ZzFlYXFCbUFmSlBrVlN3eGxyYTQr?=
 =?utf-8?B?UlVKSTBFeEtzTm1CR2FDTlVUUXFSK1ZpekY2czdnS3FlaDlnUEN5Mml1WWlu?=
 =?utf-8?B?Yjh6blZrcVFhTTFucEhQaDlMUVJqdElVb0Z3SmVVNWxSUVZ5d2RkenBzQ1hp?=
 =?utf-8?B?SkdlbGNVbE9reXlCbDZQN2t1YUdyMzhCWHoxNmNzOWk2N0YyRWpEWkt3SGsx?=
 =?utf-8?B?eUkrQU9rR2xOMklPbE5MRlExOFAvOXRkTG5SYS9ZNTYyTHRYcEgxckJUVTY4?=
 =?utf-8?B?YytNNzYyOFRNdmtCY2c1aDhZQThwN1BrSS9XZ29lNHZDYlFEYXZIUm03Ni9Y?=
 =?utf-8?B?dWdCY01zdWVqemhwb200cGRMdllPZS9vUS9GZFlEaU51R1NoK0Fvd2U1a090?=
 =?utf-8?B?cTBmVThnTGpCdXVGNzN0TDdPS0RhVGZ6a0JzSWFndTZ6aDY4R1cwZlcrU3dQ?=
 =?utf-8?B?RFgrMThQSFVlVTVRaVlQenJvMWkyS29LZkZyNFQvMUEwNmxWWm9GRU92SzRL?=
 =?utf-8?B?dE5ZUUlLVk1KbE52MjRkUk5xZVdZV04vckozME5pY3BRVG9xclNta1JiQncv?=
 =?utf-8?B?L0Jvb0tzYWt4VDY1V282T29TbkQrYURQM0JpNDdlbEw1aVVnVVhMWEhrekNV?=
 =?utf-8?B?aXJldi8vaUt5dWQzTWdoNTRkZkloSHNkZk55Y2J1WVJpRFNITWhCMFVNMUdV?=
 =?utf-8?B?WE04bkVpM25LN0k3N3g4YmZaVEpWZDBzbm16dk9wY2dmempQNG16Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c4c4275-a5f0-4da7-7480-08da28043e41
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 04:13:11.5335
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A5A99SZwAKnLDPMUlklSltmK8LBKCjpLwp6ozSu1+KJxsJJjIhXh8UQho3gZ6zkXWevmKlZQSe0+P1tzavNi/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1850
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
QXByaWwgMjUsIDIwMjIgNDo0NSBQTQ0KPiANCj4gVGhpcyB3YXkgaW50ZWxfaW9tbXVfdW5tYXBf
cGFnZSgpIGVuZHMgdXAgcXVpdGUgYSBiaXQgbW9yZSBzaW1pbGFyIHRvDQo+IGludGVsX2lvbW11
X21hcF9wYWdlKCkuDQo+IA0KPiBObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRlbmRlZC4NCj4gDQo+
IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmV2aWV3
ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KDQo+IC0tLQ0KPiB2NDog
TmV3Lg0KPiANCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMNCj4g
KysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMNCj4gQEAgLTgwNiw3NSAr
ODA2LDYgQEAgc3RhdGljIHZvaWQgcXVldWVfZnJlZV9wdChzdHJ1Y3QgZG9tYWluXw0KPiAgICAg
IGlvbW11X3F1ZXVlX2ZyZWVfcGd0YWJsZShoZCwgbWZuX3RvX3BhZ2UobWZuKSk7DQo+ICB9DQo+
IA0KPiAtLyogY2xlYXIgb25lIHBhZ2UncyBwYWdlIHRhYmxlICovDQo+IC1zdGF0aWMgaW50IGRt
YV9wdGVfY2xlYXJfb25lKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgZGFkZHJfdCBhZGRyLA0KPiAt
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgb3JkZXIsDQo+IC0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCAqZmx1c2hfZmxhZ3MpDQo+IC17
DQo+IC0gICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZG9tYWluKTsNCj4g
LSAgICBzdHJ1Y3QgZG1hX3B0ZSAqcGFnZSA9IE5VTEwsICpwdGUgPSBOVUxMLCBvbGQ7DQo+IC0g
ICAgdTY0IHBnX21hZGRyOw0KPiAtICAgIHVuc2lnbmVkIGludCBsZXZlbCA9IChvcmRlciAvIExF
VkVMX1NUUklERSkgKyAxOw0KPiAtDQo+IC0gICAgc3Bpbl9sb2NrKCZoZC0+YXJjaC5tYXBwaW5n
X2xvY2spOw0KPiAtICAgIC8qIGdldCB0YXJnZXQgbGV2ZWwgcHRlICovDQo+IC0gICAgcGdfbWFk
ZHIgPSBhZGRyX3RvX2RtYV9wYWdlX21hZGRyKGRvbWFpbiwgYWRkciwgbGV2ZWwsIGZsdXNoX2Zs
YWdzLA0KPiBmYWxzZSk7DQo+IC0gICAgaWYgKCBwZ19tYWRkciA8IFBBR0VfU0laRSApDQo+IC0g
ICAgew0KPiAtICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsNCj4g
LSAgICAgICAgcmV0dXJuIHBnX21hZGRyID8gLUVOT01FTSA6IDA7DQo+IC0gICAgfQ0KPiAtDQo+
IC0gICAgcGFnZSA9IChzdHJ1Y3QgZG1hX3B0ZSAqKW1hcF92dGRfZG9tYWluX3BhZ2UocGdfbWFk
ZHIpOw0KPiAtICAgIHB0ZSA9ICZwYWdlW2FkZHJlc3NfbGV2ZWxfb2Zmc2V0KGFkZHIsIGxldmVs
KV07DQo+IC0NCj4gLSAgICBpZiAoICFkbWFfcHRlX3ByZXNlbnQoKnB0ZSkgKQ0KPiAtICAgIHsN
Cj4gLSAgICAgICAgc3Bpbl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7DQo+IC0gICAg
ICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShwYWdlKTsNCj4gLSAgICAgICAgcmV0dXJuIDA7DQo+
IC0gICAgfQ0KPiAtDQo+IC0gICAgb2xkID0gKnB0ZTsNCj4gLSAgICBkbWFfY2xlYXJfcHRlKCpw
dGUpOw0KPiAtICAgIGlvbW11X3N5bmNfY2FjaGUocHRlLCBzaXplb2YoKnB0ZSkpOw0KPiAtDQo+
IC0gICAgd2hpbGUgKCBwdF91cGRhdGVfY29udGlnX21hcmtlcnMoJnBhZ2UtPnZhbCwNCj4gLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhZGRyZXNzX2xldmVsX29mZnNldChh
ZGRyLCBsZXZlbCksDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGV2
ZWwsIFBURV9raW5kX251bGwpICYmDQo+IC0gICAgICAgICAgICArK2xldmVsIDwgbWluX3B0X2xl
dmVscyApDQo+IC0gICAgew0KPiAtICAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZyA9IG1hZGRy
X3RvX3BhZ2UocGdfbWFkZHIpOw0KPiAtDQo+IC0gICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFn
ZShwYWdlKTsNCj4gLQ0KPiAtICAgICAgICBwZ19tYWRkciA9IGFkZHJfdG9fZG1hX3BhZ2VfbWFk
ZHIoZG9tYWluLCBhZGRyLCBsZXZlbCwNCj4gZmx1c2hfZmxhZ3MsDQo+IC0gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSk7DQo+IC0gICAgICAgIEJVR19PTihw
Z19tYWRkciA8IFBBR0VfU0laRSk7DQo+IC0NCj4gLSAgICAgICAgcGFnZSA9IG1hcF92dGRfZG9t
YWluX3BhZ2UocGdfbWFkZHIpOw0KPiAtICAgICAgICBwdGUgPSAmcGFnZVthZGRyZXNzX2xldmVs
X29mZnNldChhZGRyLCBsZXZlbCldOw0KPiAtICAgICAgICBkbWFfY2xlYXJfcHRlKCpwdGUpOw0K
PiAtICAgICAgICBpb21tdV9zeW5jX2NhY2hlKHB0ZSwgc2l6ZW9mKCpwdGUpKTsNCj4gLQ0KPiAt
ICAgICAgICAqZmx1c2hfZmxhZ3MgfD0gSU9NTVVfRkxVU0hGX2FsbDsNCj4gLSAgICAgICAgaW9t
bXVfcXVldWVfZnJlZV9wZ3RhYmxlKGhkLCBwZyk7DQo+IC0gICAgICAgIHBlcmZjX2luY3IoaW9t
bXVfcHRfY29hbGVzY2VzKTsNCj4gLSAgICB9DQo+IC0NCj4gLSAgICBzcGluX3VubG9jaygmaGQt
PmFyY2gubWFwcGluZ19sb2NrKTsNCj4gLQ0KPiAtICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShw
YWdlKTsNCj4gLQ0KPiAtICAgICpmbHVzaF9mbGFncyB8PSBJT01NVV9GTFVTSEZfbW9kaWZpZWQ7
DQo+IC0NCj4gLSAgICBpZiAoIG9yZGVyICYmICFkbWFfcHRlX3N1cGVycGFnZShvbGQpICkNCj4g
LSAgICAgICAgcXVldWVfZnJlZV9wdChoZCwgbWFkZHJfdG9fbWZuKGRtYV9wdGVfYWRkcihvbGQp
KSwNCj4gLSAgICAgICAgICAgICAgICAgICAgICBvcmRlciAvIExFVkVMX1NUUklERSk7DQo+IC0N
Cj4gLSAgICByZXR1cm4gMDsNCj4gLX0NCj4gLQ0KPiAgc3RhdGljIGludCBpb21tdV9zZXRfcm9v
dF9lbnRyeShzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSkNCj4gIHsNCj4gICAgICB1MzIgc3RzOw0K
PiBAQCAtMjI2MSw2ICsyMTkyLDEyIEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGNmX2NoZWNr
IGludGVsX2kNCj4gIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGNmX2NoZWNrIGludGVsX2lvbW11
X3VubWFwX3BhZ2UoDQo+ICAgICAgc3RydWN0IGRvbWFpbiAqZCwgZGZuX3QgZGZuLCB1bnNpZ25l
ZCBpbnQgb3JkZXIsIHVuc2lnbmVkIGludCAqZmx1c2hfZmxhZ3MpDQo+ICB7DQo+ICsgICAgc3Ry
dWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7DQo+ICsgICAgZGFkZHJfdCBhZGRy
ID0gZGZuX3RvX2RhZGRyKGRmbik7DQo+ICsgICAgc3RydWN0IGRtYV9wdGUgKnBhZ2UgPSBOVUxM
LCAqcHRlID0gTlVMTCwgb2xkOw0KPiArICAgIHVpbnQ2NF90IHBnX21hZGRyOw0KPiArICAgIHVu
c2lnbmVkIGludCBsZXZlbCA9IChvcmRlciAvIExFVkVMX1NUUklERSkgKyAxOw0KPiArDQo+ICAg
ICAgLyogRG8gbm90aGluZyBpZiBWVC1kIHNoYXJlcyBFUFQgcGFnZSB0YWJsZSAqLw0KPiAgICAg
IGlmICggaW9tbXVfdXNlX2hhcF9wdChkKSApDQo+ICAgICAgICAgIHJldHVybiAwOw0KPiBAQCAt
MjI2OSw3ICsyMjA2LDYyIEBAIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIGNmX2NoZWNrIGludGVs
X2kNCj4gICAgICBpZiAoIGlvbW11X2h3ZG9tX3Bhc3N0aHJvdWdoICYmIGlzX2hhcmR3YXJlX2Rv
bWFpbihkKSApDQo+ICAgICAgICAgIHJldHVybiAwOw0KPiANCj4gLSAgICByZXR1cm4gZG1hX3B0
ZV9jbGVhcl9vbmUoZCwgZGZuX3RvX2RhZGRyKGRmbiksIG9yZGVyLCBmbHVzaF9mbGFncyk7DQo+
ICsgICAgc3Bpbl9sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOw0KPiArICAgIC8qIGdldCB0
YXJnZXQgbGV2ZWwgcHRlICovDQo+ICsgICAgcGdfbWFkZHIgPSBhZGRyX3RvX2RtYV9wYWdlX21h
ZGRyKGQsIGFkZHIsIGxldmVsLCBmbHVzaF9mbGFncywgZmFsc2UpOw0KPiArICAgIGlmICggcGdf
bWFkZHIgPCBQQUdFX1NJWkUgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgc3Bpbl91bmxvY2soJmhk
LT5hcmNoLm1hcHBpbmdfbG9jayk7DQo+ICsgICAgICAgIHJldHVybiBwZ19tYWRkciA/IC1FTk9N
RU0gOiAwOw0KPiArICAgIH0NCj4gKw0KPiArICAgIHBhZ2UgPSBtYXBfdnRkX2RvbWFpbl9wYWdl
KHBnX21hZGRyKTsNCj4gKyAgICBwdGUgPSAmcGFnZVthZGRyZXNzX2xldmVsX29mZnNldChhZGRy
LCBsZXZlbCldOw0KPiArDQo+ICsgICAgaWYgKCAhZG1hX3B0ZV9wcmVzZW50KCpwdGUpICkNCj4g
KyAgICB7DQo+ICsgICAgICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOw0K
PiArICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UocGFnZSk7DQo+ICsgICAgICAgIHJldHVy
biAwOw0KPiArICAgIH0NCj4gKw0KPiArICAgIG9sZCA9ICpwdGU7DQo+ICsgICAgZG1hX2NsZWFy
X3B0ZSgqcHRlKTsNCj4gKyAgICBpb21tdV9zeW5jX2NhY2hlKHB0ZSwgc2l6ZW9mKCpwdGUpKTsN
Cj4gKw0KPiArICAgIHdoaWxlICggcHRfdXBkYXRlX2NvbnRpZ19tYXJrZXJzKCZwYWdlLT52YWws
DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWRkcmVzc19sZXZlbF9v
ZmZzZXQoYWRkciwgbGV2ZWwpLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIGxldmVsLCBQVEVfa2luZF9udWxsKSAmJg0KPiArICAgICAgICAgICAgKytsZXZlbCA8IG1p
bl9wdF9sZXZlbHMgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGcg
PSBtYWRkcl90b19wYWdlKHBnX21hZGRyKTsNCj4gKw0KPiArICAgICAgICB1bm1hcF92dGRfZG9t
YWluX3BhZ2UocGFnZSk7DQo+ICsNCj4gKyAgICAgICAgcGdfbWFkZHIgPSBhZGRyX3RvX2RtYV9w
YWdlX21hZGRyKGQsIGFkZHIsIGxldmVsLCBmbHVzaF9mbGFncywNCj4gZmFsc2UpOw0KPiArICAg
ICAgICBCVUdfT04ocGdfbWFkZHIgPCBQQUdFX1NJWkUpOw0KPiArDQo+ICsgICAgICAgIHBhZ2Ug
PSBtYXBfdnRkX2RvbWFpbl9wYWdlKHBnX21hZGRyKTsNCj4gKyAgICAgICAgcHRlID0gJnBhZ2Vb
YWRkcmVzc19sZXZlbF9vZmZzZXQoYWRkciwgbGV2ZWwpXTsNCj4gKyAgICAgICAgZG1hX2NsZWFy
X3B0ZSgqcHRlKTsNCj4gKyAgICAgICAgaW9tbXVfc3luY19jYWNoZShwdGUsIHNpemVvZigqcHRl
KSk7DQo+ICsNCj4gKyAgICAgICAgKmZsdXNoX2ZsYWdzIHw9IElPTU1VX0ZMVVNIRl9hbGw7DQo+
ICsgICAgICAgIGlvbW11X3F1ZXVlX2ZyZWVfcGd0YWJsZShoZCwgcGcpOw0KPiArICAgICAgICBw
ZXJmY19pbmNyKGlvbW11X3B0X2NvYWxlc2Nlcyk7DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgc3Bp
bl91bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7DQo+ICsNCj4gKyAgICB1bm1hcF92dGRf
ZG9tYWluX3BhZ2UocGFnZSk7DQo+ICsNCj4gKyAgICAqZmx1c2hfZmxhZ3MgfD0gSU9NTVVfRkxV
U0hGX21vZGlmaWVkOw0KPiArDQo+ICsgICAgaWYgKCBvcmRlciAmJiAhZG1hX3B0ZV9zdXBlcnBh
Z2Uob2xkKSApDQo+ICsgICAgICAgIHF1ZXVlX2ZyZWVfcHQoaGQsIG1hZGRyX3RvX21mbihkbWFf
cHRlX2FkZHIob2xkKSksDQo+ICsgICAgICAgICAgICAgICAgICAgICAgb3JkZXIgLyBMRVZFTF9T
VFJJREUpOw0KPiArDQo+ICsgICAgcmV0dXJuIDA7DQo+ICB9DQo+IA0KPiAgc3RhdGljIGludCBj
Zl9jaGVjayBpbnRlbF9pb21tdV9sb29rdXBfcGFnZSgNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 04:55:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 04:55:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314349.532370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njZhA-0006Da-WB; Wed, 27 Apr 2022 04:54:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314349.532370; Wed, 27 Apr 2022 04:54:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njZhA-0006DT-Sr; Wed, 27 Apr 2022 04:54:32 +0000
Received: by outflank-mailman (input) for mailman id 314349;
 Wed, 27 Apr 2022 04:54:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njZh9-0006DJ-Fm; Wed, 27 Apr 2022 04:54:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njZh9-0004Ob-Cb; Wed, 27 Apr 2022 04:54:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njZh8-00068l-UK; Wed, 27 Apr 2022 04:54:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njZh8-0002YT-Ts; Wed, 27 Apr 2022 04:54:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=j9yVAjHpg6QIbsmSNHxMJUYdT06tqQrNDY6vTSf7oYk=; b=OeyunH/LEKpLr+qB5mTO/k4lov
	3aBAlgeJUmTfK7DXlDD7PGEDMx4HR8Ck5bimm3ad0oR4sAUtL8FElQuRRSdUDrFhhBBfoq6SyS7Od
	TrmxJzMr7kWzsGNnqQbNltR0+Ggpd6AVErW1W+VFrU1BBZEGAqjlSwtyZRQuBmU0jOng=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169766-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169766: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 04:54:30 +0000

flight 169766 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169766/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  655 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   27 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 05:54:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 05:54:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314358.532392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njadI-0004Fm-QZ; Wed, 27 Apr 2022 05:54:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314358.532392; Wed, 27 Apr 2022 05:54:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njadI-0004Ff-NX; Wed, 27 Apr 2022 05:54:36 +0000
Received: by outflank-mailman (input) for mailman id 314358;
 Wed, 27 Apr 2022 05:54:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njadH-0004C8-AZ; Wed, 27 Apr 2022 05:54:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njadH-0005hB-8A; Wed, 27 Apr 2022 05:54:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njadG-0000jB-TO; Wed, 27 Apr 2022 05:54:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njadG-0007cw-Sy; Wed, 27 Apr 2022 05:54:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ltU+CG39EfEs8bnXhamC3751jth+6J467oe60ilgcKs=; b=acuG1+nvR8t4fNzHSHbMWW/4gS
	yhXXTMq0vm/WI/YOwRxnMDCfUTtGLaNRoQVij8sf3CAG4gioZ5788G7h7bAEXHwa75DrkSnT8dpzV
	+XF4bba8lX3CUdgFIZMDYSP3/ioYWiImByNqCzrkOgNszNfCGs16VyIeF84ICNoKr0oo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169769-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169769: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 05:54:34 +0000

flight 169769 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169769/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  656 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   28 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 05:54:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 05:54:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314357.532380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njadG-000406-JK; Wed, 27 Apr 2022 05:54:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314357.532380; Wed, 27 Apr 2022 05:54:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njadG-0003zz-G0; Wed, 27 Apr 2022 05:54:34 +0000
Received: by outflank-mailman (input) for mailman id 314357;
 Wed, 27 Apr 2022 05:54:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njadE-0003zt-Uy
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 05:54:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 81913fce-c5ee-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 07:54:31 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-vkMsQOt7OGikxPbhx1BjoA-1; Wed, 27 Apr 2022 07:54:29 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4341.eurprd04.prod.outlook.com (2603:10a6:209:50::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 05:54:24 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 05:54:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81913fce-c5ee-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651038870;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0hQVZO4XlnPaC8aVKdysPy1Olg+8wdfP09s68bP3b2w=;
	b=Y/m/MdeC/d8RetDnnnhl/wuu0f+t8OXiEpFzc9/d/dWCWVnG2gW2k9qwSxEcRZDvSvu483
	AzXbHiV2Fp5NViVwGECiJu0+31YPfN1MFqZJpLMM411b4SFCE+knsI+uXOJUm+9u7JQOZf
	u8/Nkack7UcJ4tQU8YWU6K24gM8YqGs=
X-MC-Unique: vkMsQOt7OGikxPbhx1BjoA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gW0878Y49zZic1f5cn/UbsuEjT9s8Sx0c+BLrlKfpB7RrWSF8F8QoWGDpcTFG3sVzZGBBRDhJ/OBzDWuJ86URv9x89E6C3dqJKcuYUAi8uy/+o+zKpLnqw7WBdO0b1pIiuvRFpux5x5lqt2kqVJ6aiNyVYrzW79C4XgiAhzIgowv4MCui/L0/ZdEViKyLV5pdwBrpi22UEXjVbdPj73MSVjb+cHG/3I9jSo4UGSPy3EkBX250IASZFvej6R74qA2Z+9fBbAMk+X/wp3Ppg11eRVeuIbTi93vuYJBWu7YQKJ3DR0glmO0btdWKhkZD1U6JPA8BKLooxQnQYzAaH7RXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dg+cNINhUkLElAC1/aUcHqA2yaSIByX9fe4l8QBYAHs=;
 b=JvKrE2C8bVc61ejQeDP5Dm97ueO5OFOwU6bTDfsQguQNvnGCYUXtCM1LxT8hh4IdrwxonX4YhC9e1X04k4ixqt9XUyZqg9PhJPHTeJNZ0zVgs+ty/a8k8vxQzuuTvFo/KQlF/F+IyM3Wh1+CfkPKfO9bC0gK41BGOKkDX0Ly/jzY3+zVBJewO5dwHLoEe2YmFVy5cc8GXD+PYYTkCrCUIEfG5N7TVdjkjeqBc0Qo7g7umRs2k5LVnSfuAKZkv9aWU2cwWhByyxGmBnSiSD0yph3lAZY3Yh2jt9M1niz/r6floGxnT6jgCp1AsJemq4cnmiBl9XGYPbSibhjQc1mzqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bcb8a2e1-7670-8a53-4d81-114a30963a66@suse.com>
Date: Wed, 27 Apr 2022 07:54:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from
 x86 to common
Content-Language: en-US
To: Wei Chen <Wei.Chen@arm.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, "xen-devel@lists.xenproject.org"
 <xen-devel@lists.xenproject.org>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-3-wei.chen@arm.com>
 <3e5b9708-7732-a56c-f2e8-d5d39fd2093e@suse.com>
 <ed949bf4-ba9e-9ad7-b2fe-c63526ca42e5@arm.com>
 <413651ff-55a4-61cf-efed-7ac82f7c6723@suse.com>
 <PAXPR08MB74202E608E9A967458664E7A9EFA9@PAXPR08MB7420.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <PAXPR08MB74202E608E9A967458664E7A9EFA9@PAXPR08MB7420.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0011.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 396be4fc-209b-497e-345d-08da281261f2
X-MS-TrafficTypeDiagnostic: AM6PR04MB4341:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB43411B47204FA37CF08F7CD3B3FA9@AM6PR04MB4341.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Fuqmw5TZTqM5+/RYI0xv+12l8vtuk/9+acKZpavUe2jWOYvorNuMGvpMaRY97un2bT0nvO6asBPckq2EY6cVI7/ax0Rp8xsPJ19Dn2NozV+1eBODwDoU/Mv2lWlZfwDQi5bFbyeW7Rro1e5fw5fHCr7+GkRnbm663ezM/zTC2uo4u8nQYqWjtmOGkqKMOLVZlMVsJOy9T/9dydF8l4hA/gbd6T1VdoI+hdHyRW49ZdB3p6HQ33xa8H7V/Qim5r7qXRc07HwyJf9NqhdxSm8nPFG0KBON4078MujtWeGJ9rlCw1L2bvVYdu7XS9YmyQ9JxDRQadvRWrpJjN6UfZ+UR9R3JQlKU1EcU6y9ChmajJd+mGJ3tkVfqMC09Qmu0g2Kn3kylpB/E6AsFobAw9ijWP9bXZV/6QYV7mkh9H7OELQmqUHbCH8aS6qHFQpoq1gtFLm1KjfZltWsgECTbxlCZ91AoOJ1EANShOhVdopY2Z67bWy2Cq1T43WbmVXjB3K5Mf8NAXKob95eYXjNFoDxB7/TE5BpDUpIUks5fSlXyIy+jEz4c6CM+o5K7zAwMZ8X3LiJs7qqILbz8BxfGfUvudlgHxB69Ay4l5ANWuwF0GQlms461k8sc5yCVZLDphn3woZdpIej1dYLnogVKL3RigHrGg6fessJnrHGx/VPErkitQrJJdhRI1Gx60rQr74g+0a81RPe41xKn5H0h/6t0EyyhmCcOco3V0o8UUTJ6ElD+UGPsLRG2B4Nh9w6+Lz9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(31696002)(54906003)(66556008)(8676002)(6512007)(66946007)(26005)(66476007)(4326008)(2616005)(316002)(6486002)(6506007)(186003)(86362001)(53546011)(508600001)(38100700002)(83380400001)(2906002)(8936002)(5660300002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?aKzmZFhdeCGHhVYaqz2fdHtl2UwMNgKd6XNTUgijakBvoOEWnVkF/94Je5G5?=
 =?us-ascii?Q?8jXVN6SJ0emLEdQqUwkk5CW13AkRIssjhENcp5WdHxXmkgh3i3sQQ8aWBrkZ?=
 =?us-ascii?Q?hqqirCIlQWoXKs1HyxEba2SmzrjMdW9uQjzj+lfhenJsFgWMc93GBe1h01yx?=
 =?us-ascii?Q?E7jz/hDFxfjJohySMmAD0zewh88lAG6ha4f2Z3KZnUO+6KahayV1znvS8dh5?=
 =?us-ascii?Q?NFVe3IfWZrwgj1h/OcGBmZXxBIlXRmf7cVnSe+2imDjuYa528hpOr3r44q2e?=
 =?us-ascii?Q?zYmqMQfjK+ly4pMP4zzbnKLL5VWDybSyO1Kr135205MntZRrgOSNLz1+gINE?=
 =?us-ascii?Q?BwVU35RLTmHPUu32XWTqOH8Zl+QWgTdSyvnl3QiAw+JWlBaLYcbRFvlUIL7t?=
 =?us-ascii?Q?H3rmW4uUw2olx1CJ7oyWTvWwOwP+GLxOPCXUPH0ArM+s4OI+wF11vbmq8soR?=
 =?us-ascii?Q?1bP6CNZfcSaxhvIUxmtJ5ZCyf88VFgFt+uRA5PHb+8I40GIOLu1aj64xok78?=
 =?us-ascii?Q?31RSCaQwnija0dV0HeLFXt4Azn5BTYQK6zfrDk+mevScFZV8x2pcXbmoUt30?=
 =?us-ascii?Q?AoBxlRe5Jy7R1YjRkIsNIDG9/6LnNRDYckMbS7RcqDTI1ExtDj8pxBb4tz7g?=
 =?us-ascii?Q?ei3Hwk7J8W2g19usdMvUFHaUEPwMV/OdwUhiWkTXVbXiZ9hNLbSkc/3J/D75?=
 =?us-ascii?Q?rx3hxRm6vSzjD1t1SKmgBD8Pvjia1ryDrlH62/vDs91zs5zJV63cwBeaY3z8?=
 =?us-ascii?Q?iy/l8nahyB9mSUBFiVaMCKvDCXLhR9aLApvcwMzo8G9RfSpx3dXaM2W9o6jk?=
 =?us-ascii?Q?ISFUolqYQvxf1EX3/tfpKOkWu1NhamjqjyA78cS6REUIlpF+3WnXtYcuSkYd?=
 =?us-ascii?Q?BbP+cKT/rFAM/SixTgkKJ3JebTeYT0W12OiA1URmcMzevlhQgyNfj8PRQlVv?=
 =?us-ascii?Q?VCd99nZKXol61/HnYqiTVOf/2SATg0IwAOqO7TNXSDn3NK1g2NxE/8Z3+0ol?=
 =?us-ascii?Q?X0ASopWeOw5ErFw8nWDFB3Mx8nkazKeKME9igOe44VK2PbaIAxhUIOBagiNU?=
 =?us-ascii?Q?oZFYMcB7qiazES4p1m8C7B8tTCQ9ndKMvMa4P5SK5+1JtAmfszPDU1XdkFk6?=
 =?us-ascii?Q?HxWdE+Jlf+5d1r6kJdkZaxjT0uLZlMyM/OTt7sjSg/DHcKOw+YLPChGZF22j?=
 =?us-ascii?Q?f/7ayWgIWd0rK4dy6Q84FRN+UDT0y0LvLDI0ipGKxgtWLq7qpjTyUGGH6Mvs?=
 =?us-ascii?Q?msx/3t2dDvCKgP12VGBeS7Y/w6CHfIIyQIOGFKb8frp34PpsHdWCqmVYMwx4?=
 =?us-ascii?Q?AjMQbOpzXZOHA7+rzJddfDcfwzIQElvPZugfpZceOYmKXyCzchV9hKPpxdli?=
 =?us-ascii?Q?OUcHI6JKJSsCVJXkTRrbGBnIDqY0m1EwDAKbrGa2ASVtTz0hfMueKaa1SivP?=
 =?us-ascii?Q?jmyxjOibwxclxpUHPKamcgszRd+uaSH/vkqabNEB0Jk4vUVvTGSvv6Nqxka9?=
 =?us-ascii?Q?ZWYQXrfP9pYxJKyyr8mxFNrxGCvhhXoFsPXO8pP62HVaJq0BbS6nIB+JohNf?=
 =?us-ascii?Q?jwURz25J6VvuEZcCxRG2GiWYVh8NdTStdPWfgQ7/ZzLNjQWhM4phHW9Wj9sL?=
 =?us-ascii?Q?AqaEjy/diMWjLWu5aZqYd/tT6qVmhgRNingSwxKV6hq0Xtx6XQUUdRsx55FA?=
 =?us-ascii?Q?xGNDcieY7PoEdf6ertOuP5/c0MidhHHZfa+a2baVTus7O7Fy8GpTdypys++N?=
 =?us-ascii?Q?Ss4QOmNoyQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 396be4fc-209b-497e-345d-08da281261f2
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 05:54:24.5081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WOFLyiDjZSYG3pQ46KRwyqSrvwJfVG+KBd+zFHHJHFeNaH8Y7PssmS6fEOruVITAKYnog3Pr3Wir1gCAXsiqfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4341

On 27.04.2022 04:56, Wei Chen wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: 2022=E5=B9=B44=E6=9C=8826=E6=97=A5 22:31
>>
>> On 26.04.2022 12:37, Wei Chen wrote:
>>> On 2022/4/26 16:53, Jan Beulich wrote:
>>>> On 18.04.2022 11:07, Wei Chen wrote:
>>>>> diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub-x86.c
>>>>> similarity index 71%
>>>>> rename from xen/arch/x86/efi/stub.c
>>>>> rename to xen/arch/x86/efi/stub-x86.c
>>>>> index 9984932626..2cd5c8d4dc 100644
>>>>> --- a/xen/arch/x86/efi/stub.c
>>>>> +++ b/xen/arch/x86/efi/stub-x86.c
>>>>
>>>> I'm not happy to see a file named *x86*.[ch] under x86/. I think the
>>>> x86 file wants to simply include the common one (and the symlinking
>>>> be suppressed when a real file already exists). Naming the common
>>>> file stub-common.c wouldn't help, as a similar anomaly would result.
>>>>
>>>
>>> How about using stub-arch.c to indicate this stub file only contains
>>> the arch specific contents? However, we cannot predict what link files
>>> will be created in this directory in the future. If someone needs to
>>> create a stub-arch.c link file in the future, can we solve it at that
>>> time?  Or do you have any suggestions?
>>
>> I did provide my suggestion. I do not like stub-arch.c any better than
>> stub-x86.c or stub-common.c.
>>
>=20
> With my limited English level, I can only see that you don't like this, b=
ut
> I can't get what you want clearly from your comments. I can only guess:
> For "x86 file wants to simply include the common one":
> 1. Did you mean, x86 still keeps it stub.c and includes all its original
>    contents. The common/efi/stub.c link behavior will be ignored, because
>    of x86 has a real stub.c? And common/efi/stub.c still can works for
>    other architectures like Arm whom doesn't have a real stub.c?
>    But in previous version's discussion, I had said I created a stub.c in
>    Arm/efi, and copied Arm required functions from x86/efi/stub.c. But
>    people didn't like it. If my guess is correct, I don't know what is
>    the essential difference between the two approaches.
> 2. Keeps stub.c in x86/efi, and use it to include common/stub.c.
>    I think this may not be the right understanding, but I can't think
>    of any other understanding.

2 is what I've been suggesting.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 05:57:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 05:57:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314371.532403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njafX-0005BJ-BS; Wed, 27 Apr 2022 05:56:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314371.532403; Wed, 27 Apr 2022 05:56:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njafX-0005BC-6s; Wed, 27 Apr 2022 05:56:55 +0000
Received: by outflank-mailman (input) for mailman id 314371;
 Wed, 27 Apr 2022 05:56:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njafW-0005B1-9d
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 05:56:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d5f7478a-c5ee-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 07:56:52 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-KNQ6w1caPxe_bYjBX7VWLw-1; Wed, 27 Apr 2022 07:56:51 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4341.eurprd04.prod.outlook.com (2603:10a6:209:50::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 05:56:49 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 05:56:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5f7478a-c5ee-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651039012;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vsAd/H91RmiB2xGqRw7rgCXE2zQSxc0KH/3Ia5JCkmI=;
	b=YwDOe5JfJp4Z+l/VGhPt09A1fIjHhd/BkGV2Iq/yELIRTNkx/AVjIgCm4r5JvE3Qc9dCqZ
	ShFHsM6bvnRahv4LUzuMGj6QvmnQ2lcAEjTCv/czIvW4BUo/hHjVCexv4GQ3MCFM/1bNuJ
	gCLYLGrxaoBnO3aXEZbkgg+c0PfPiIY=
X-MC-Unique: KNQ6w1caPxe_bYjBX7VWLw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hN+6demHQXGVCtRByGAxn9EuXC4cu8beqrw3u2ek0BjpeTeWlU78dTgiDpMFHo64T84UqYPMxv0P8idb+vQaGtj6HUOaktMDUHo12IcxpVoVCl3e1fwciEn/FdbK/i38BPNJkihf3fduppSdyEtSi9VJcyQ5Fd/URmM01BUtejDbeW8Ty44eNrttP3Yz3AyLtZ+8pLKTRFmJ8mzUs0vyVfg8+bBez93gtkFV7FJ2bIw30a8YYwEtNUuoU6405B5mCz6lDYjxBTEBLXEZOfOOUmZMiI8b14jZZBmIAVT0nnc3argUWT+vyxT9fMdQ7eX7h0+1dE9LsEs+eWA72ZmUug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lbKitOelmPXblbKTvzwSDY3ph0VV9YlpwIwvC8edFjc=;
 b=YUUMf6brsnIMHjWQbGofCQmbOazHZr7EnA64hRG4NiclWBa07YUStsQ6Z+fVbnRw8LjdaOGQAsflN/WGTsDYPnHuM8iQ23vqqNsvcjbcdt0DGHtsZVTrgApfjiPkX2zHidwANfZ+ogEnovuXFdK0d/zf+0SFKHoxrc+/5SIjQBQrsTZyZcztZpvdy5zQ1N9cqbrA9n6RV8nV1OnENmHvu1O2fHP9UbPjJcgtQ/+Z/rE3Nx+STbWMwa7nnOVwd2yxW/isUBgQNfrxpFgihOo89NJB14SOz9u6oYUCATcC3Y3FbEI6sgNKJ9AErWzwPNHABJvYYqQzGjXgJktkRtZqzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cb36bf58-4c24-7f2e-ba26-980359ad06eb@suse.com>
Date: Wed, 27 Apr 2022 07:56:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON
 for phys_to_nid
Content-Language: en-US
To: Wei Chen <Wei.Chen@arm.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-6-wei.chen@arm.com>
 <6d666aa4-c0d3-b8ed-9fca-e9d2179564d3@suse.com>
 <7d7fc887-20a3-49c3-0754-3bca3442ccce@arm.com>
 <79e3fc8d-7064-e981-b90c-d0f7fa0aafae@suse.com>
 <PAXPR08MB74209F0F6F0B189FA10D04FA9EFA9@PAXPR08MB7420.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <PAXPR08MB74209F0F6F0B189FA10D04FA9EFA9@PAXPR08MB7420.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0098.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2019b174-b7e2-4484-24bb-08da2812b888
X-MS-TrafficTypeDiagnostic: AM6PR04MB4341:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4341DC1FF45C93828B56970FB3FA9@AM6PR04MB4341.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iEdIAYKFn7lqokt8xlpZVC5hy5WiaCjMBq0FJOW9n4C7u/16Iad9nAzrYZXSmxyIr9XdHFecuYwo1+U1eXnnUec1L87qUS9Pob9N0biKJJl+6bv+YisiLIdz7HrY2rW3kcaiJzfOMrgmexHVrw319ULTPFt3nzG+A5hwSyVigweKbZWt5dsBQeA2Io7+lMKejKVMDJwVUFGDKzYs299LxLacpO2TCw238dUR09BjH3LSF6F1Pv5qUxYY9/F/Nttvf4l1mpwCcqU324wiVeQ8rIKxiCPUBbr1DK1COp4Z7RXXY9HRsOBDTB3VKpX3UnLyVp6oAFZe1joTU4BS2yI6aB0fDX9AMzypKdMKZTCFFfubG9uq7JhMs2nIIHfUmk0wlBRnOhJYM6/p686ZeFHFzZRimQVV+JxFGf2oQmxM/6AsSaKM7V7TVXNi2K+/wUjEzW2yeN9+suB1V0wr+exqAG/cjxYzSKy1UPnPsVXbntBCs5qYh8+zDIxheu7cJle1ClhYy6lhQk+BM9nOrfzzm5pQSg3/r1eC89iWsZz7uSywtvOcvfo12vwcAlbOl55BnuAK2vpSqqPwxidsthNW/+HvfdBRwo6ppcxln4Q0uCeC3Bv/TmTxrSWQ8Ip39MHGwSbc8FOxqFoMmNQtpOMtMlAxJ/TEapiTmti60Z+DNksUiRtBq4dAuW5C3zRHwF964N/XmsFVU4XRleAGZJANEanZQlUUXANG+Dr/GaLxr+bEzri/4otJ9g9z+AhBLwfO
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(31696002)(54906003)(66556008)(8676002)(6512007)(66946007)(26005)(66476007)(4326008)(2616005)(316002)(6486002)(6506007)(186003)(86362001)(53546011)(508600001)(38100700002)(83380400001)(2906002)(8936002)(5660300002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bvt2Ya+TM1gA6ZEOJAgn4SWeEUuvL4WltIgSV6xll8Q456DoCbN7m/Vv6Nl7?=
 =?us-ascii?Q?sLQ33CcencCO1bCZVNZj85B5A4PQDNQGTwe+yraK3MC8vLqv+/0QcE4b/noY?=
 =?us-ascii?Q?MwQ4JnKy9X7llD4tMhNM3IAmCMTynoNJdz2VSxDZhLSjH0VmMmKPdZXC9nsW?=
 =?us-ascii?Q?fuc+dpP0UO5PN40fZFIA/6wy6BBvm0ihAxZC2TGxqe+3CghpiFU22h6itmkz?=
 =?us-ascii?Q?/g6eKh6JAQfn+7LBLe96StOAxFskj/86F48+M6EGGkgh3F8A1NrYwaNJkgTb?=
 =?us-ascii?Q?wnMdQ8DCQ7CcaAidLixah+nKU5icODN8WtJVG1/REqlpdLrtvtrMdmhyg8jq?=
 =?us-ascii?Q?fyGNobQgn6F/8mrk0/lzwt2cDMCzSU/AKuM7lYtfHd7r5lyA6CjJXMgG09Xv?=
 =?us-ascii?Q?tk83hY0KfpDcADwWvifRfT8zODZSgBXV66Fb3T88u5csGfv1WUKToV4gyT6p?=
 =?us-ascii?Q?kNnUTFLSTRny6i9x/7KW8yJjfWk4DpkY3oba+4qHMck83l9wbmXNXqo1E7Jz?=
 =?us-ascii?Q?XVnhd8JxjyxgwJWUnj6YwN/kskg1+wJao73iMts3nTj49P+CxJuDBRpDY79B?=
 =?us-ascii?Q?gpnNYRRsMUxlsQu4K3sagTfZTkR/TDHB41cwkb2WJWDffd7J3iOEAQl3p+uc?=
 =?us-ascii?Q?HMkCO/ZF/kh6csNV/kmKwkV/saDMJbvINuMAea40kkciinWmlS51c/fNa3LY?=
 =?us-ascii?Q?5P3BFgOjVR7GQCuDCcV8j1CyCWruOCdxhXNNUdVPvd/XjBj0Sl3XU2L347Ni?=
 =?us-ascii?Q?cXkB9DxMyTcG4Nm9imfaCUA/Rp8XN9mbd3+QcBzojmFL7wWXlTtLpB73reUv?=
 =?us-ascii?Q?w3+LJ25UCJEGKrP4/UYH5gOmgf9K2OmmxCLC0kiUv9ecd1tN9U7w9B8bheft?=
 =?us-ascii?Q?UrpRwKs9PciBorXBoMgZn+YNE7WdkMxlS7V0tQKZfRhh/JfuH/zDkYqgX6x4?=
 =?us-ascii?Q?1rMI3qjJkY12fZ7/6wxVu9GDb8jl7BHzpNvZPkxOl+uIv1iP/UlZ51kRYHQO?=
 =?us-ascii?Q?D3fZHpnV9R7rg7AfKJkthtp3Vk6kJylcUsahQXmMfOCP+/VSoU9OcOOowozQ?=
 =?us-ascii?Q?QMz9Vg8WocWOgGItKC3G8nHzxBwBYPFKEiymPSoRXLz+LeOO96GvWkU38hSf?=
 =?us-ascii?Q?/Bx85CM31y+iPrD+pSFUuMMW0KDmTWBJcBU4LELjzp/Yd0oCLSja0tQdD3oD?=
 =?us-ascii?Q?2l3V4OXBrBEWfUrZfG2lk4Xu0tU1RcdfoPgUTxHN7ljzLESF/1C7J3/qyDhb?=
 =?us-ascii?Q?QZfdFBKp0bWB6kQQFTP0x3lJqKo7fUJZakxecHo7ZVUUw6uBnvvmbgHPQG07?=
 =?us-ascii?Q?qd6d2MePe/hnmP5r4ijvAEUQP+LGtiWIMD+NbasNqlBldybBW+4l7G+n3S/v?=
 =?us-ascii?Q?fIvDmoujmQyRYRnXp5TqpJl2r9MOjVmAASpHrIs2s8BxO9CW32rQ3rQeC1dI?=
 =?us-ascii?Q?fyFOwf9Gv8WW5vJZ0w/boV50SFLNth9dA+Z427mAAPPL9Ln8fiM9hybM4uru?=
 =?us-ascii?Q?7y4CkWXo9sx/A1YEQObHbdflZcTgPnbgjZ9kMpznjIO5l/pOUmu9sItPyTVJ?=
 =?us-ascii?Q?N3Km+qo4WHMGQMvjmhaXGhmcZHb+przgloryMzbR7FRsNiN2yoHzvamRkdoF?=
 =?us-ascii?Q?PAKXIFKPHXBglczBirdEUKPWpeP/9vqthPNYjsJqNzYKAQJV1gV1KDCXUovc?=
 =?us-ascii?Q?LtFJBfh1npK5+cKc0YN9/uNzwkv+aJm/jlFZ9wpWEtwidFU6sfMc5fAF2xxs?=
 =?us-ascii?Q?/d1RRmVAYg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2019b174-b7e2-4484-24bb-08da2812b888
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 05:56:49.7892
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YjDIBh+hghjsoqRayF2qDcGxlJtFzhceceras3Ggzvotb4jfXwDHbQG8CBBnkvz+AlPPZ4wkjHpgt1RHBnbMIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4341

On 27.04.2022 05:52, Wei Chen wrote:
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: 2022=E5=B9=B44=E6=9C=8826=E6=97=A5 22:42
>>
>> On 26.04.2022 12:59, Wei Chen wrote:
>>> On 2022/4/26 17:02, Jan Beulich wrote:
>>>> On 18.04.2022 11:07, Wei Chen wrote:
>>>>> 2. error: wrong type argument to unary exclamation mark.
>>>>>     This is because, the error-checking code contains !node_data[nid]=
.
>>>>>     But node_data is a data structure variable, it's not a pointer.
>>>>>
>>>>> So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
>>>>> enable the two lines of error-checking code. And fix the left
>>>>> compilation errors by replacing !node_data[nid] to
>>>>> !node_data[nid].node_spanned_pages.
>>>>>
>>>>> Because when node_spanned_pages is 0, this node has no memory,
>>>>> numa_scan_node will print warning message for such kind of nodes:
>>>>> "Firmware Bug or mis-configured hardware?".
>>>>
>>>> This warning is bogus - nodes can have only processors. Therefore I'd
>>>> like to ask that you don't use it for justification. And indeed you
>>>
>>> Yes, you're right, node can only has CPUs! I will remove it.
>>>
>>>> don't need to: phys_to_nid() is about translating an address. The
>>>> input address can't be valid if it maps to a node with no memory.
>>>>
>>>
>>> Can I understand your comment:
>>> Any input address is invalid, when node_spanned_pages is zero, because
>>> this node has no memory?
>>
>> It's getting close, but it's not exactly equivalent I think. A node
>> with 0 bytes of memory might (at least in theory) have an entry in
>> memnodemap[]. But finding a node ID for that address would still
>=20
> I have done a quick check in populate_memnodemap:
> 74          spdx =3D paddr_to_pdx(nodes[i].start);
> 75          epdx =3D paddr_to_pdx(nodes[i].end - 1) + 1;
> 76          if ( spdx >=3D epdx )
> 77              continue;
>=20
> It seems that if node has no memory, start =3D=3D end, then this function
> will not populate memnodemap entry for this node.
>=20
>> not mean that at least one byte of memory at that address is present
>> on the given node, because the node covers 0 bytes.
>>
>=20
> And back to this patch, can I just drop the unnecessary justification
> from the commit message?

Well, you'll want to have _some_ justification for that particular
aspect of the patch.

> And for the bogus warning message, can I update it to an INFO level
> message in part#2 series, and just keep:
> printk(KERN_INFO "SRAT: Node %u has no memory!\n", i);
> but remove "BIOS Bug or mis-configured hardware?\n", i); ?

This sounds at least plausible to do.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 06:27:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 06:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314378.532414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njb8s-0000Bf-Ty; Wed, 27 Apr 2022 06:27:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314378.532414; Wed, 27 Apr 2022 06:27:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njb8s-0000BY-QU; Wed, 27 Apr 2022 06:27:14 +0000
Received: by outflank-mailman (input) for mailman id 314378;
 Wed, 27 Apr 2022 06:27:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Q6ah=VF=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1njb8r-0000BS-5z
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 06:27:13 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0601.outbound.protection.outlook.com
 [2a01:111:f400:fe02::601])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11c1ddc2-c5f3-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 08:27:11 +0200 (CEST)
Received: from AM6P191CA0038.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::15)
 by HE1PR0801MB1882.eurprd08.prod.outlook.com (2603:10a6:3:4e::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 27 Apr
 2022 06:27:07 +0000
Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:7f:cafe::2f) by AM6P191CA0038.outlook.office365.com
 (2603:10a6:209:7f::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend
 Transport; Wed, 27 Apr 2022 06:27:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 06:27:06 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Wed, 27 Apr 2022 06:27:05 +0000
Received: from 5802543eca52.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 15867770-A631-4EB3-8778-CB18276260B7.1; 
 Wed, 27 Apr 2022 06:26:58 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5802543eca52.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 06:26:58 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by VI1PR0802MB2590.eurprd08.prod.outlook.com (2603:10a6:800:ad::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 06:26:56 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 06:26:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11c1ddc2-c5f3-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=JSbA1aE6Na+q1MZ2qXsAPt0LwtSFphwApCVi1Nx+yG87IwkBs7ng88vQ7yEfXo92Gni9hZRTzZqSwjWz6KSul3RbfQWZY/FBTxLHYp0bvYnepotbT3q02JDX1jjxYniX7cvBVGdRbrhCrAKARtQe8BrV7QbA+C0oiiy9SsoilIOyMNCLNU8ySvFrMWErozBS08o7qqXeGgh3hMhYcZ5/b4iUhcTJCPREuv7H00umQJEeJ8E5R9ChsSLt0J2NT/aJcGONZV8fcuMBcU0A55ojqxjR9ADoZwV8y23zNJrHyVtYRFHuj01lqUPWz0A/YrShsGIPd8RpPt8yNHiL2Wwwzg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I5h1RGpd18C//EniB6JdZ2FKRhqfZ1+dLqJqi6X25ds=;
 b=Hl90H58MSVD3qq0Kc+L9M/xI8lTDinF7JsvchLfGVcOI/59j1KOUkFH0hq1/e3TCiYz6nQ6cbKX/OpAninAMF20b6YWNwuny0xjM431V183YfstNy0XMkVKOIql37ClUDgp3mwts2nHBs2JvvGeiJoiN5U4nl/rbSeun83Kc6xLMw5D6rNwmf2DvlivL72VE8CBcCO1ZFSeA9NGUmAiJ1SdIo/t/nfbgIhxCerpHPthKjN8v1sT3FmspMNaFfbOfcxi/DqEGPmEJBGQZugaMMq9IyhCbS3UDv1Y0ng+Mem5rMGQ6Q0XbYrQkIacVs5bi50B9OzXcv4ZBS9B7Wxkhcw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=temperror (sender ip
 is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=arm.com; dmarc=temperror action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I5h1RGpd18C//EniB6JdZ2FKRhqfZ1+dLqJqi6X25ds=;
 b=fyT3KZsY7MPa222r9f5hpA9PuQ19CxG3jURYU4FhC6yd8t5rgS4r7DyvC++84cdTf9flZ6E5BXVq4kW5+R97vlVUk4ukk2uSzddMNMbEM9j4/LGAwi60ha0qhgl40HrGriUIQLhghPrgRw6LM+i7zWvksqMudi1cCm6PdaAlXYA=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=temperror action=none
 header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: f0416e6d0d7e8328
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lOpknIYWaqYv2GCHOdyfmAuVUD4L9itzCSO94eOgHTP03OYMlq6YslHNBn/sz1A9dXAwP1VMVeyTRoRv4Z1nX6p187TSXCIk0lvv0Ttqc/5ZHMkr9jYRxXqdDlqTrLELWwvmyKjeKLeayIWA2C7Ug3tjkEOAU2d+QkzjZGhf68lKw7UM6AtEHc4Qg1LkVd6nJeCjrfix/gLx7n7hz/Zzi7Q19CAVutz1o0Zn0l98TPBvT16zh4xqOwXqaDShqMPdtgvMw0NjVr3mdhSFfViisPAl9W9mTPC+b3Qbx7ZDSaEucQ3HRbN1sBUU+02BK9cSLZzSCUtaNIloVMl1RM6Aow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I5h1RGpd18C//EniB6JdZ2FKRhqfZ1+dLqJqi6X25ds=;
 b=K3bmFASUNXy24Hq2EaS1/YmM1dFtxzgmpqlmkU+NsV+8tbcdjTm5e07WgiG5VERQyTx+/gCxjg78F/lJI9DsYoG+/YNQC4T+bo4+b4dBisFF2WDrvVMcARTB/f1snB3WBQPEmPExLsSt0myXzzz7AE3++ihQ6KlS4LzKAqitSKXzb8ikH5DLTMw0v2Q9qpku/WGAJWGmPhPFK+k2T9jRexalWJtkrUXuZc8y5Ol6TdLb2fd2psmFGhYVnpKQe0T4J43JFJyd8MExyHa1dm6naG4ZEgw4iU4XYeVfeW1KWglXXoOYyLIr7FrVYhAS63/P+ec2hOvWZP0kQBLYJAIevw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I5h1RGpd18C//EniB6JdZ2FKRhqfZ1+dLqJqi6X25ds=;
 b=fyT3KZsY7MPa222r9f5hpA9PuQ19CxG3jURYU4FhC6yd8t5rgS4r7DyvC++84cdTf9flZ6E5BXVq4kW5+R97vlVUk4ukk2uSzddMNMbEM9j4/LGAwi60ha0qhgl40HrGriUIQLhghPrgRw6LM+i7zWvksqMudi1cCm6PdaAlXYA=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <d70072d3-bac7-63e8-a2fa-3e724c53c5f7@arm.com>
Date: Wed, 27 Apr 2022 14:26:50 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from
 x86 to common
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, "xen-devel@lists.xenproject.org"
 <xen-devel@lists.xenproject.org>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-3-wei.chen@arm.com>
 <3e5b9708-7732-a56c-f2e8-d5d39fd2093e@suse.com>
 <ed949bf4-ba9e-9ad7-b2fe-c63526ca42e5@arm.com>
 <413651ff-55a4-61cf-efed-7ac82f7c6723@suse.com>
 <PAXPR08MB74202E608E9A967458664E7A9EFA9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <bcb8a2e1-7670-8a53-4d81-114a30963a66@suse.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <bcb8a2e1-7670-8a53-4d81-114a30963a66@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SI2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::9)
 To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 2c91990f-0f88-4e81-8a9b-08da2816f32f
X-MS-TrafficTypeDiagnostic:
	VI1PR0802MB2590:EE_|AM5EUR03FT005:EE_|HE1PR0801MB1882:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0801MB188242A5F1F395CFE87021E39EFA9@HE1PR0801MB1882.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Hnbj68cbsyE/n+LTwRTSbXMfbzDRp86iFxNEcSxIa7x5cuuFpwe5iBonjpqX25/oC2HDTrKJIHsbWL23tOQyxm4yWBtw1Ig2QI8ECN0eWKjR+rCPXxaXrsp+dnFE6LVfMSVfNS6DyB3lQVlsinjZpArsfnCTQBwj9o5P2l6vXHMO4YGH15AXVBMEu1cmVWoxQbJdztnpH2JDTrdhtPRBNLuB9PXQy2zze7JdHnNq/CQ99PKc3wxgwoqMMPaxS17KPX1whJ7JHlBDTbGOX24r7PRzZxHXBeMRWDClGQBQNO3hMcR72kg+ZFjJF0pJDOgbhdSQNunE+8UB0bx7Du/uK6xVH3t/kyBzJLqazxRX61EkGVzlOQ/dLKolXpOYC3/Mb8kVtoSmyCwEHOUIcTtQqCs6rN3/U3AG8fsisP65OcdRpJFc7+bx/RQOk+f3sRItVnx2e+NNOyNBukrfxCFxWuyQl9t5GV6Xra9Y+HBCHKJaQrCcXOoYrDMEV2X+fZbFQdW52ccKBFNwegbBoEtk57+nrEhM7AI+DyVQ7EmvNwJQbjVuawLiFWmiBxwVWBNloZjPeBbxr5esX/0JrqGFh2LL9Nd7bYRMSLVvhnsC4njzma5DN/zEVoh2bwg8nqdfD1vgi30Q7asOXnwJaQ1J57iCqLUgS+nyNRj+/aOAdOK9a/yYdmksPDbHWwWTv6ytio0tbP8wBb3flisvVuuBM1NeCRuWIujDR0cvbTy/634Eg0xR0KrntXtywlI0nCO/
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(38100700002)(83380400001)(186003)(6506007)(53546011)(508600001)(31686004)(8936002)(36756003)(5660300002)(2906002)(66476007)(4326008)(2616005)(54906003)(31696002)(6916009)(66946007)(8676002)(66556008)(6512007)(316002)(6666004)(6486002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2590
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7931ab2a-4851-4584-5cae-08da2816ecc4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wxWAuLj0w5WRD8RHbBkbuJTaO21mZgcUP9+PiLxyzN43HsvmXgTUT4B22BeZlu48sbb/IyMQtPoZe0Pao9ZMylJLbyZyeU7AhobmO87Teljp2bepSseURRs8cF14jNUwXpb1fx5SfBT8d2P0rdlKEtxOmsdHpwecjZMGlyXDuutkTaJxqwoMGmaZZlHn52ATDCUvGCVMcgGX05yeslV7+QDYCZgFV+INx3DUwVBNtBoFZq/DKpBzAyPd+c2f2hS6JhCXmIHwMM+dv1mQKlkvFY6Es74ahIvFqXnGu0sT6tgLShTLyS/10QehTXEc+y6mZsGPs+9HWbGOl4IHAU0maUcJzwXOXsdPv4r1yw6nzBLgZqEPQ62Ybb1kSTJRs38FW6gPWx990H8OKWVoZAxquXc1QsXgS0e5iNB9Q7xzU6GNPmzjvXJSWZBtX7Uv6p8BYS2OyOoTwpxvC/gwxAZjTwYOCV5X9wiQvCFZd5zgN7bVKZCDI4j3nyVCvhiefXPZl86Z0kpgDhnsuiA/fvmuxTQtYnXTWZaikKuRv7Jbe/PTm+oqQ8x+cn4tXrYNfYdHzGYhFsqlkSl/SntIcqP6LzJXFEg+/67suNfNsXv/Z0Z+vfP7r+V+lyqfYbeb4ZXgwh5d05bNuYw+n1pzGRuIV/OFw1gp5PTPDF65LoVBanRzgup21qAzNHhmgmBmw6Fcyc1xsNKxMz5HLxibi5Q1I0Y0k93gd/FdGv6a36SFlGyCZpXvAxNQ83b7O1BCiZMU
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(316002)(86362001)(2906002)(2616005)(36860700001)(81166007)(336012)(40460700003)(186003)(70206006)(5660300002)(70586007)(36756003)(83380400001)(47076005)(356005)(82310400005)(6666004)(53546011)(6506007)(6512007)(31696002)(26005)(4326008)(6862004)(8936002)(8676002)(31686004)(63350400001)(54906003)(63370400001)(508600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 06:27:06.0092
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c91990f-0f88-4e81-8a9b-08da2816f32f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1882

Hi Jan,

On 2022/4/27 13:54, Jan Beulich wrote:
> On 27.04.2022 04:56, Wei Chen wrote:
>>> -----Original Message-----
>>> From: Jan Beulich <jbeulich@suse.com>
>>> Sent: 2022年4月26日 22:31
>>>
>>> On 26.04.2022 12:37, Wei Chen wrote:
>>>> On 2022/4/26 16:53, Jan Beulich wrote:
>>>>> On 18.04.2022 11:07, Wei Chen wrote:
>>>>>> diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub-x86.c
>>>>>> similarity index 71%
>>>>>> rename from xen/arch/x86/efi/stub.c
>>>>>> rename to xen/arch/x86/efi/stub-x86.c
>>>>>> index 9984932626..2cd5c8d4dc 100644
>>>>>> --- a/xen/arch/x86/efi/stub.c
>>>>>> +++ b/xen/arch/x86/efi/stub-x86.c
>>>>>
>>>>> I'm not happy to see a file named *x86*.[ch] under x86/. I think the
>>>>> x86 file wants to simply include the common one (and the symlinking
>>>>> be suppressed when a real file already exists). Naming the common
>>>>> file stub-common.c wouldn't help, as a similar anomaly would result.
>>>>>
>>>>
>>>> How about using stub-arch.c to indicate this stub file only contains
>>>> the arch specific contents? However, we cannot predict what link files
>>>> will be created in this directory in the future. If someone needs to
>>>> create a stub-arch.c link file in the future, can we solve it at that
>>>> time?  Or do you have any suggestions?
>>>
>>> I did provide my suggestion. I do not like stub-arch.c any better than
>>> stub-x86.c or stub-common.c.
>>>
>>
>> With my limited English level, I can only see that you don't like this, but
>> I can't get what you want clearly from your comments. I can only guess:
>> For "x86 file wants to simply include the common one":
>> 1. Did you mean, x86 still keeps it stub.c and includes all its original
>>     contents. The common/efi/stub.c link behavior will be ignored, because
>>     of x86 has a real stub.c? And common/efi/stub.c still can works for
>>     other architectures like Arm whom doesn't have a real stub.c?
>>     But in previous version's discussion, I had said I created a stub.c in
>>     Arm/efi, and copied Arm required functions from x86/efi/stub.c. But
>>     people didn't like it. If my guess is correct, I don't know what is
>>     the essential difference between the two approaches.
>> 2. Keeps stub.c in x86/efi, and use it to include common/stub.c.
>>     I think this may not be the right understanding, but I can't think
>>     of any other understanding.
> 
> 2 is what I've been suggesting.
> 

Got it, thanks!

> Jan
> 


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 06:28:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 06:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314382.532425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njb9e-0000it-7f; Wed, 27 Apr 2022 06:28:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314382.532425; Wed, 27 Apr 2022 06:28:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njb9e-0000im-3j; Wed, 27 Apr 2022 06:28:02 +0000
Received: by outflank-mailman (input) for mailman id 314382;
 Wed, 27 Apr 2022 06:28:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Q6ah=VF=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1njb9c-0000BS-R0
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 06:28:01 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02on0602.outbound.protection.outlook.com
 [2a01:111:f400:fe06::602])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ec2378f-c5f3-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 08:27:59 +0200 (CEST)
Received: from DB9PR01CA0003.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:1d8::8) by AS8PR08MB6726.eurprd08.prod.outlook.com
 (2603:10a6:20b:39a::5) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 27 Apr
 2022 06:27:58 +0000
Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d8:cafe::b2) by DB9PR01CA0003.outlook.office365.com
 (2603:10a6:10:1d8::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend
 Transport; Wed, 27 Apr 2022 06:27:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 06:27:57 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Wed, 27 Apr 2022 06:27:57 +0000
Received: from 4e5aeb66da96.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CA430BC6-F33E-4878-9751-063B18499023.1; 
 Wed, 27 Apr 2022 06:27:51 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4e5aeb66da96.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 06:27:51 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by VI1PR0802MB2286.eurprd08.prod.outlook.com (2603:10a6:800:9e::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Wed, 27 Apr
 2022 06:27:47 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::c9c3:bf08:ecb8:1feb%8]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 06:27:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ec2378f-c5f3-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=IOpAZbse73k1qE/VI1xBX1kgVEm3meYIwMqXWeD+xOFTSy+MQ1lPshLDeEnjVVz52eAnU3BTyWkOjMnEl2UVIfdv+KR9gm0p/fBLS0qYxyn4L0wGpJBRJgDK6CGuS97x6suV/o1ROGgYWUlkZLzGu6bLG7Fj73guGIrUjZXHnRDyEQF4Ns1poQnQtU5sRh1XDL9Um3MDWUji/jYoMX7t0MnMTBwBtGDJgsEPwpGx83jO2vjrhDMwPEYCAsC0AKsfLnslqdJc3f3VLJgc40KX+H9G+YK1WEkoHe2lAdcGyz5JAmNoUoB65P/GGkJ7XczilYcEKW8TwKgYzqP4Hf/oqA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=If2X0BlV/dg9z6xzoWqRbdLtn4k0nYahiIeBt+aBCRY=;
 b=V0+bLIIgPCShs+GiIoJgQUj5RAbEoG60IXBDxFCL/Oe6XWeAoozeaImguJVPeHYnObBO2LzGvfoRQST269kfsdziG2U5/vnpSUWjxVOLM7MhnDldUL88w74smAJwf5v1ACcaBD0Pa+Qii5fGponAGUnYOITH8VGTf1WCsiUtjkBeV92sVEQ76HN6eBa9aL5O6hQmM6mhukLltzfgpAtCNmJVY4Meim3baJj6rzZOAYD7Lv45INaeo/gNMYUyQTixHWjRvrcQoa3uxpY68T2oQ3GsU5Z7gJ1eoR3A8GWj0H6ugiPsWjKC035xbHXBvI/jiPwNHVtQilh6D2U9KEJchA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=If2X0BlV/dg9z6xzoWqRbdLtn4k0nYahiIeBt+aBCRY=;
 b=W5gWy/6jlKf0BcgwNfFr7InvqRFUQU8p/4RnAYhqOUk2/1i4hyTKoS+lB8N4sz/diJ7W88Q+VLy09O5hj1hBNVIYLO3TUkaY/OTUw+7VNtWjyMcjEv4+WLYbAbrD9oItMisUjfJCbYmhsQkmUZuuWvyYph5MjLgwvwhEr7ijDZM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8482fed2bc0f6dc2
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mvcC7AAvNDFPzijd4lOPHT4vLO5Mtvg2kXIr6mtbmnHMk63bBMOS5nxlHS63rSBhLTSfSDX2IWXnKigrPdSqlhk57u5Ay7yE/E0Vb0aofdOYfXK2K99SxVD9MNxT+9xpoJXISk3ZtDZR/RrBUXJ83oCnUBtBfJSclHpkBMS22eGsJryR4OxLn+rRYWk0Cem9TImwVdsemriJoVrLq/BQRd5uWUGLYhebzkSkzWK/NfO6kyAVFr4t92V8hm2V2nfrVqMBNgh9dpZH/kntbXMqrzN2qq6M04nHyz7uuAuEVP13uDcHYgWYaoK2vSybXwZk6SbrY76hDQ8IhoEHSuVRTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=If2X0BlV/dg9z6xzoWqRbdLtn4k0nYahiIeBt+aBCRY=;
 b=fwhWdk6v0ex5wNoKv7Ek3YUVgAIsFdIus35TwjPNHKCvF9RiAMdpD8QcA1d9H0zBevxRrGqRlQpJJaYHC9q8F3No5yUp5bsS6atDwe0RZcRgvw0XorOznPQgA6zde/qRMd4UhTd1zODgmIBtSTmXPhtq7mI4ZhVtXcDrumhEftFtVSw4Yy6bYyd//U4CpAae7nlyEl/jkZEG3ODtjdGxkzgD18ICWnYNfTCh0WdbxV6bWfFyjVUvqLfHnFRxUPSqmz3UrmR5jjvT+AhFwHcM+rgS3c541KNczllN1Zt/jdjB6CWAaObqR/wYXKpCeaPN9pbnAdE2Thi4XPjXXY+7zA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=If2X0BlV/dg9z6xzoWqRbdLtn4k0nYahiIeBt+aBCRY=;
 b=W5gWy/6jlKf0BcgwNfFr7InvqRFUQU8p/4RnAYhqOUk2/1i4hyTKoS+lB8N4sz/diJ7W88Q+VLy09O5hj1hBNVIYLO3TUkaY/OTUw+7VNtWjyMcjEv4+WLYbAbrD9oItMisUjfJCbYmhsQkmUZuuWvyYph5MjLgwvwhEr7ijDZM=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <f43f29af-dbc7-e326-dcd3-3fe295101340@arm.com>
Date: Wed, 27 Apr 2022 14:27:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 05/10] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON
 for phys_to_nid
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220418090735.3940393-1-wei.chen@arm.com>
 <20220418090735.3940393-6-wei.chen@arm.com>
 <6d666aa4-c0d3-b8ed-9fca-e9d2179564d3@suse.com>
 <7d7fc887-20a3-49c3-0754-3bca3442ccce@arm.com>
 <79e3fc8d-7064-e981-b90c-d0f7fa0aafae@suse.com>
 <PAXPR08MB74209F0F6F0B189FA10D04FA9EFA9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <cb36bf58-4c24-7f2e-ba26-980359ad06eb@suse.com>
From: Wei Chen <Wei.Chen@arm.com>
In-Reply-To: <cb36bf58-4c24-7f2e-ba26-980359ad06eb@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SI2P153CA0027.APCP153.PROD.OUTLOOK.COM
 (2603:1096:4:190::22) To PAXPR08MB7420.eurprd08.prod.outlook.com
 (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 23ebb044-0c93-439c-9b8e-08da28171209
X-MS-TrafficTypeDiagnostic:
	VI1PR0802MB2286:EE_|DB5EUR03FT046:EE_|AS8PR08MB6726:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB67267FF19CE0316A5D52CAAF9EFA9@AS8PR08MB6726.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 sYlE8n7yYrKd9Ff+GxfymmHZtwgjdd9ufA4DstSwDXRsq0UmQkP/hpInRA5/uiweFDv+GB1WeI01FVVi/gq3LI0NCPX46muYkjiOw3izfVKRskYj3BiuVFo5I1TsbT5h3qfxu3whI4t9o2ZNiIC1FtKLGxqD25MNsI+tP7QXosWQWVaHPvsSGkqnuhLm8cxcp6Z/nVxPpKvX+ArvqHDvWVq3HsPtZi9DVM3D6XwBJk31I0sQABdrSje3d92VCpBPcIYt9Uam9Sdp3vbDxCMbIwEtJ7JfWH8fbx39/UiXDO/nomgYD1qEmJO87HuAlve2a8ykUOtVDkCCf3JOjA+WZ/JdZ7JbOA5sDbs4Q8EegvD1MJ4qKI7XBBZzqRH9c+VwmZD0OoBdADCB2YKB0bH4c39pi4P+oMrkdC3VhsX2cdNpztJD0zwWyPR14ay0wEpkPmrhmKIu1Kjo/Wq+oTWh9DXlN4d0cMSFkgyJuQxMm7tSwMYRSFPv8xGBOUddJugPokp+Zr2Gydon7ybAwBn0l8vhHbUDd+XC7kZU1vaDgubC7owyzR83O1S4emJJVH6PYb4YH5qCkEhXIZ4LRc9kcv+QkYlIRgWbE+VHzE/ttRdXn2OloLHAZqwCE1TyG53jsOxxWPrhE58TViq/Se5oCAK75DjgiiWwZ8MiuyZNo7Wgi1Fuqa3yEVk4W8dPIkKVP7gvuAjpQFxA3oe9ZWOUdFGTV0GzEOj73bT3LZruJmM=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(6486002)(6916009)(38100700002)(54906003)(508600001)(8676002)(66946007)(66476007)(31696002)(4326008)(36756003)(86362001)(31686004)(66556008)(2906002)(8936002)(2616005)(26005)(5660300002)(83380400001)(6512007)(316002)(6666004)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2286
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	84c2b984-489e-4294-a9a8-08da28170bca
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9WvpJvOY4/LpoVMKD/AlRK0qfOramiPCNbB9WkED3i+QQUsTkJ0QvfFYZrfiJClVy6GBnnj4IHlqn4EuaTTleFztIFFZkiA5rGudCvw5qelwbMF+Z2qCt1ny01Aeq93ZGmy1oj6Ipd2Y0TjvyjyS2w/ZwiY+V1sqG7JA8LdebXdciQ4o7WUJOOBbWZkEMWWCoFarSMHzcFgasqtIV/++gYhxQPBXnD69bqnXDII4eGZpMizpa5uk77zhaOiwVW3rYiTZntA3JedXDtin+8dwVvZ0iGcelFVTUrYQ2JsMuTE4Ife+ECKeHmvU32Ki5XjEjufjHmki953lpMUziA5HrIEkhPtfHQIDpp8kxos2DlM6hN/K8NDmvZy9uK0zrBg0uFBt5Sn/+QwbFNk6szytQ7bALDl8/Qbq7aKzUNf8Cdzv5l2ye8ED5tJ/1tLjx1aYfqMzyx16O3Zk3i8iLksAM1WUPiGq6aXXlH0odm5gPNYoE83bj9JIQ7bNWfkKU4f0lgQaFmHDwaXC3Wjz5o2gqVDnUtiYnYYsEDb3aVgp2g90AWDtNCUQpr/s34Kx9Hy2sqIhHFayrVMYXPekHQcutqJAfIQY8HTd86qWQTO/YsL6UVp9A25MBm+9CJvFdsKoebKERpIY3DQIfq8o6N9Px0oZMUSqJ0wd2/oTRK0NK5f/51Dpqwq+zfxbACXrZ07OhtCjN8qRaFzuNvbEbu3DOQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(336012)(53546011)(6506007)(8936002)(36756003)(83380400001)(5660300002)(4326008)(31696002)(186003)(36860700001)(2906002)(31686004)(8676002)(6862004)(2616005)(26005)(86362001)(508600001)(47076005)(6486002)(316002)(81166007)(70586007)(70206006)(82310400005)(6666004)(40460700003)(356005)(54906003)(6512007)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 06:27:57.8324
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 23ebb044-0c93-439c-9b8e-08da28171209
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6726

Hi Jan,

On 2022/4/27 13:56, Jan Beulich wrote:
> On 27.04.2022 05:52, Wei Chen wrote:
>>> From: Jan Beulich <jbeulich@suse.com>
>>> Sent: 2022年4月26日 22:42
>>>
>>> On 26.04.2022 12:59, Wei Chen wrote:
>>>> On 2022/4/26 17:02, Jan Beulich wrote:
>>>>> On 18.04.2022 11:07, Wei Chen wrote:
>>>>>> 2. error: wrong type argument to unary exclamation mark.
>>>>>>      This is because, the error-checking code contains !node_data[nid].
>>>>>>      But node_data is a data structure variable, it's not a pointer.
>>>>>>
>>>>>> So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
>>>>>> enable the two lines of error-checking code. And fix the left
>>>>>> compilation errors by replacing !node_data[nid] to
>>>>>> !node_data[nid].node_spanned_pages.
>>>>>>
>>>>>> Because when node_spanned_pages is 0, this node has no memory,
>>>>>> numa_scan_node will print warning message for such kind of nodes:
>>>>>> "Firmware Bug or mis-configured hardware?".
>>>>>
>>>>> This warning is bogus - nodes can have only processors. Therefore I'd
>>>>> like to ask that you don't use it for justification. And indeed you
>>>>
>>>> Yes, you're right, node can only has CPUs! I will remove it.
>>>>
>>>>> don't need to: phys_to_nid() is about translating an address. The
>>>>> input address can't be valid if it maps to a node with no memory.
>>>>>
>>>>
>>>> Can I understand your comment:
>>>> Any input address is invalid, when node_spanned_pages is zero, because
>>>> this node has no memory?
>>>
>>> It's getting close, but it's not exactly equivalent I think. A node
>>> with 0 bytes of memory might (at least in theory) have an entry in
>>> memnodemap[]. But finding a node ID for that address would still
>>
>> I have done a quick check in populate_memnodemap:
>> 74          spdx = paddr_to_pdx(nodes[i].start);
>> 75          epdx = paddr_to_pdx(nodes[i].end - 1) + 1;
>> 76          if ( spdx >= epdx )
>> 77              continue;
>>
>> It seems that if node has no memory, start == end, then this function
>> will not populate memnodemap entry for this node.
>>
>>> not mean that at least one byte of memory at that address is present
>>> on the given node, because the node covers 0 bytes.
>>>
>>
>> And back to this patch, can I just drop the unnecessary justification
>> from the commit message?
> 
> Well, you'll want to have _some_ justification for that particular
> aspect of the patch.
> 

Ok.

>> And for the bogus warning message, can I update it to an INFO level
>> message in part#2 series, and just keep:
>> printk(KERN_INFO "SRAT: Node %u has no memory!\n", i);
>> but remove "BIOS Bug or mis-configured hardware?\n", i); ?
> 
> This sounds at least plausible to do.
> 

Ok.

> Jan
> 


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 06:42:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 06:42:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314391.532436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbNo-00039n-G4; Wed, 27 Apr 2022 06:42:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314391.532436; Wed, 27 Apr 2022 06:42:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbNo-00039g-D6; Wed, 27 Apr 2022 06:42:40 +0000
Received: by outflank-mailman (input) for mailman id 314391;
 Wed, 27 Apr 2022 06:42:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njbNm-00039X-P8
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 06:42:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3a1c01f9-c5f5-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 08:42:37 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-J9KvaoYlOveM_zSY0z7J_A-1; Wed, 27 Apr 2022 08:42:31 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 06:42:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 06:42:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a1c01f9-c5f5-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651041757;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yTJXMMcoQiypeivkIZdPtIMIr8CDJ5JMmO2GxSpbJ6I=;
	b=J0cbet5g3V2VXCbCxNep53XvC6Tw2SV8WrMOG8fVSBsmgCD+MvNkzoRWwOrjV0Z02ItqRk
	fwC+cUC4LgS02ArO1NcCUIX5sD2rdlVLco27rrgVp05Z2gfyI0zNE91FkNdkgfoaKq+Qx9
	U5O+JlZCpp/6eT8uYr8bfLB4lYM5+6Y=
X-MC-Unique: J9KvaoYlOveM_zSY0z7J_A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ODmGsZ6LD3qsnzB00qrpwwHdo84mtwiuLwozWXEsrrwZtf2Aq050oDdJsAkku5kcEFn3TsRBWGahYsdx9MHIw2AsA094a0cmDlBpA1sM3YscM4BT0zevs8MnnK9vKv5gSF/ApRpLws7AzWPL3fcCD8nVwgmRReVueNNIYMJrbPiTgTW7hId3wZkLFUGdQhiNsAMdrvGdOMT/Ke1p17yc5uPHzIi+GrqZPoGyMMKyB9Dw0B1SXo8Adz03p0FCHpyNSDs0kQbYAmdrhyi/M5CYK/I4iZLAk9A5Y4iQgq5CFbJpBNAt9tamtploYKWt23V30pVsmqZJ2js7KE3+3jzVkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yTJXMMcoQiypeivkIZdPtIMIr8CDJ5JMmO2GxSpbJ6I=;
 b=NgzXRfXqFVEOojZ6Ie/530jglEITw+oFsFloex5aBHdNVDtivQvHiEd8IWbQOHasNQyzIbU3m/kAro5O5LJApCP0NrAs2TY8M7KEANHO61eKMDJcXgPgFN+srH4TuO0WIRcU+ZncXNQi0YEL+nPCrcjc676j9VbzxEHQeOdqQfsgqO8PnNd3S6pAIs2ZZKB6OQL9BduI8K7Y2y6XmLvOa2/iJhvz84FIzJNLRLx02e/pBsVJAV3S+vwLJITktn1TFim6Z35oX/xDBGKNEa9dLzY/zBACurixj/pFD/dn4m6Bizc2+Gl+UL79L2pGXO0gLQwGQ6GGCq2gKgu5uYP8+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0aacc53d-279f-2e0d-b495-217133e75e03@suse.com>
Date: Wed, 27 Apr 2022 08:42:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/arm: alternative: Don't call vmap() within
 stop_machine_run()
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220426200629.58921-1-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220426200629.58921-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0005.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::10) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 96f6f247-84f2-4dc4-0950-08da28191937
X-MS-TrafficTypeDiagnostic: DU2PR04MB9081:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB9081D9F095E98E5314223A8BB3FA9@DU2PR04MB9081.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	48ev6PPBhHfj9CmfMcaNj8sgS7aProxYxWNU+189BCcA3+GzQNwVlWkbSap2ps8czEPh4+UbBD5k2uQmkWDBAAkzIo4Susd7vRb6mAv0Y2f3MywIU39Xe1q7iBpTwypvV9/Uiq3T9+TXjvGmETafJCSpuwzFlG3NDmFjhm8KORY/vMj+FGjtjADeA9D593EXkJMFHe5uMsUaImQo7xFrIaZSc3bkr6xHCe3dTDix5vXW/ivZeUl6ZcMYkBOEy6c0iI0qL3brBGRBdRDI871LiRZ526+QunHsLi29fFiB/27pXTsLquTr29/fal5m6CN0Pt9xg2QkWlA6zicS0/JkDrI5NZktda9TUy0WP1hD8LFYAGgsCKGrN5a/tEL8YTkiVskP12NLxCumTZcPfLBLupXuw1SOHSOI6bNyR7l8/3OROISE62av3c28l22uvCFOsibm3qlHNxFqFZI9hegXndnjnw7YrEFaP0OaXU7ihvn1GdNwvBLFK5qknxxsjnGmryJOGh3Z2jtdRs5K3/YeAUYLg6LVvoj/m4VKKasPEMLz0Fg4JyECt6XgAgacYmLfApGLcfIGgq7UpV5quStJEMBgxU6yJjrjrlJZ1iiqX4XQJGRZf8I4bHqrffXcNVps8SaWoztCGu3KLJMrDyFGD3Hy5hn1D85pMTjKVD2HqMHyWb4AXfpnGuXpzmc53N/PZ5H3rKGBGoOVRpKxYNrE6nF6nVM+0Zw1M2pyD6EWUU+RlOYnBrejGD5kXwSmjboQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6916009)(86362001)(6512007)(26005)(31686004)(186003)(2616005)(2906002)(36756003)(66946007)(66556008)(66476007)(8676002)(4326008)(5660300002)(83380400001)(38100700002)(6506007)(53546011)(316002)(508600001)(6486002)(8936002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MXZTWFRHSVYyKytraXFPK1h5d1AxNTNWNjRWcjgrWGxGRWFtLzF4cU1vR0Rq?=
 =?utf-8?B?YWJBWEl2T3lwemNiOXluTDFQVFZTQ0NUb1BoY3ByRjdMNndROTRSUmVpL0JQ?=
 =?utf-8?B?NkJ3RzU4SUQxT2EwYis1azBrVzIzK08vYlluanlmV0dCMGtuRXFiMlhXUm1M?=
 =?utf-8?B?dE9ZL09DVmd0WnpUM1IwSDcra3crQVluYjFvd2NvLzRXWEc3czVEYlJlZDZ0?=
 =?utf-8?B?WjgxWkV5OGUzRFBMcTdoMkIvYmF1R1J4TlljNkIreWpXTEZBdTVMQmNvdWdP?=
 =?utf-8?B?aXBSZkVhWHk2bXFSbGNYQzA5STUxdWVjNEo3SXdPa3pXdlBPNU9Yc29YbmUw?=
 =?utf-8?B?ZkhTeU40OGRxWmxrSC9uV1BlUGphOE5Vd3E2b0tkaTNmVkV5RHVoaW8rTzBG?=
 =?utf-8?B?VUo2dWx5K1ZCSG1INmt4dGlwSW9LMlBNeSs2NCtnSHhvZ1dPQVdRazRkVFNo?=
 =?utf-8?B?YlgyKzQrazF5WG02UUZVbmx3WHFpRVhvaDQwTC9jT0xOYlZwQmgvM2dvYTJn?=
 =?utf-8?B?a01HUFg1RDlQbG9RWDdvc2F5SUhQek1iS05seDdsMC9sOGtleXUrN0tGd05P?=
 =?utf-8?B?dktqak5Ja29hemFnOVpXRmF2Vm5raUsyTVJVOG9KdGxjQVNXOGRzZFNOd0FB?=
 =?utf-8?B?MlFPWVBISllKVS8wZkhHN3ZmblVOaFdudTdOYXZwa0hWb2c2VVFjRmdZUEI1?=
 =?utf-8?B?ZS9aY1BFUWZqNmM0a0puaVd6MXk5aDh1T2tJTTZjVTNGRS9BQWRURlNEWGtM?=
 =?utf-8?B?M0FaTkxucU9hakRNclZNcVZXSXlOcDRpZnluR0xhZ05JL09vVzNQcEtMblc0?=
 =?utf-8?B?YnhPSFBXcHhxRitHQ2Y2OVBmampWQ3pjWG50Q21GYjlod01uR3dDMjAxcFpk?=
 =?utf-8?B?eHVJVzZ3QTRGQnZlTDRXV2RpM05iN1pIb1VWMnpFdW5WeTJpQ0t5SGlCUkJn?=
 =?utf-8?B?Y0xqRXhkTjlsNmI1UHFmSkNJVEFTa0U0K2c3ZFg0MEhiSmEwVE93dEtleTVR?=
 =?utf-8?B?RWlhczF1M25FeGk1OUc5WXMrVHdaUzdlWlpEL2t3Z3JURnNhamtYN1JTaWdQ?=
 =?utf-8?B?V1pRUmI1MGgwTGFjRVFTS3NBTWM4cldNckJ2SjVxWVphdDdhTitwNDRWWC9z?=
 =?utf-8?B?MjR3STRFTEpjMlVnM1RmQ2oxd0M0QlM0RzlXUjg3UFh6dVRWTWlFQnl4OXMw?=
 =?utf-8?B?alNIaHpUK0dKbTFOYzJyWTJseTJPN2lJOE9nL2YxUHpPeitta1FxRmxFWFkr?=
 =?utf-8?B?Y2x6dU5FcEhjNkRCTUxFbWRJQ2RLcFQ1L1B3V3JzbThUbDJhL3ExTFhaMWZ1?=
 =?utf-8?B?OFhpWmhJQVVLSzF4YWVEdU1KWUlJd0o4cThmbmxNekJHUjd0N3pkWDNQZFh4?=
 =?utf-8?B?SnNLazU3NWF5SXNYQk5MeVRhZ2g1eWxXWWpDcW1NTk5zRUtlN1lVQ2wwVkkv?=
 =?utf-8?B?UmNORFVzckhHSEljNjJxUC96bGtWcm9sSHRHY1ZYV2Nsc3gzWUpkOVpxdDRY?=
 =?utf-8?B?SllGZW8zanFrZDBkMnU0aitsVHBGaURRWmlhWnA0OW96REpjQlBQSUo1a3JK?=
 =?utf-8?B?NjlscGRBMkZIQTZJZFMwYU1KeXdKWWtub2ZMcndSdmhvbWkwaWdsdUlIU1Rn?=
 =?utf-8?B?S2cyR0FEdEpUaGZ4VTh4VXNMMzhNYWV1WUxmU2xjclJ0K2c3Ty9UeDJJMUYz?=
 =?utf-8?B?ZkxUMmZIcmUxV2ZoajQ4K0dpTkNETTdBNWd2UEhFS0djWW5BZHV1Uk04bUg4?=
 =?utf-8?B?ZlUxVDgzaUREaStBeUt5bWoxSlVYVzlOSEcrYW1tYTZRV01MMlpUazRZeENa?=
 =?utf-8?B?ZUsyWmdaUHduSnBqTzF3cFMrb2wyUVhCeFVZOTd0a254bHVRN2RxWU1yeVNY?=
 =?utf-8?B?TmRIOUx6OXFVVVR4SURlYkxDbDVENEdFejJGZkl5eW5BNVJ2Z0xQQkxSemhC?=
 =?utf-8?B?YklDZFlmdDBDM1hDR1JBMEVnNTlrUkRTaHZBd0crNkFGdVArRUc3am9NZ2xq?=
 =?utf-8?B?OTdGTi9NY3V3b3lJeXlaTS9MQkV1dzZKNFFCQUcremlGOWZielpyZGxXUXY2?=
 =?utf-8?B?d0QraWt5T293b1FyOEtyM3RnYzk3dk5vZ1Ywd0RqL3FHZUJDeGZMamtweDRj?=
 =?utf-8?B?YUJmTDNQaWM1enVGdVhZTER2akVZVm5HV0d3WC9zRGhveWFyV3VHRmZVWU1S?=
 =?utf-8?B?aXJJMnI1emE5QWJINVJzN2dFVkJIN2krcnp2aGhGUWNld0YzOCszVTVYS1d5?=
 =?utf-8?B?cjd3SVg3bjgzY21iaFdzK21IQzlkZndkaWlWdUwxMEZvSjZGWDl6bFB3aDFW?=
 =?utf-8?B?djZ1WFR5MW1iWVZQRnJJcmNzcW9aYnhkWlFLOVhZWmp5ZG9DaGFGQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96f6f247-84f2-4dc4-0950-08da28191937
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 06:42:28.9302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ttVB7Ep2naETa8LrHwPArMpnfP2Ucg/6L0U9gNrLmF+4tjTA5q1kw63xMlDuRLVauG0RICS7dKi9vJ1qnBDyDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9081

On 26.04.2022 22:06, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap
> alloc/free" extended the checks in the buddy allocator to catch
> any use of the helpers from context with interrupts disabled.
> 
> Unfortunately, the rule is not followed in the alternative code and
> this will result to crash at boot with debug enabled:
> 
> (XEN) Xen call trace:
> (XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
> (XEN)    [<00000000>] 00000000 (LR)
> (XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
> (XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
> (XEN)    [<00236864>] __vmap+0x400/0x4a4
> (XEN)    [<0026aee8>] arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
> (XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
> (XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
> (XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
> (XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c
> 
> The interrupts will be disabled by the state machine in stop_machine_run(),
> hence why the ASSERT is hit.
> 
> For now the patch extending the checks has been reverted, but it would
> be good to re-introduce it (allocation with interrupts disabled is not
> desirable).

We definitely should re-apply that patch once the one here went in.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 06:59:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 06:59:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314397.532446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbeD-0004iO-RQ; Wed, 27 Apr 2022 06:59:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314397.532446; Wed, 27 Apr 2022 06:59:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbeD-0004iH-OT; Wed, 27 Apr 2022 06:59:37 +0000
Received: by outflank-mailman (input) for mailman id 314397;
 Wed, 27 Apr 2022 06:59:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njbeC-0004iA-LL
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 06:59:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 988641d9-c5f7-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 08:59:35 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-M7M8_L-YNYCL6Ni2QHImvg-1; Wed, 27 Apr 2022 08:59:31 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5271.eurprd04.prod.outlook.com (2603:10a6:20b:11::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 06:59:29 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 06:59:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 988641d9-c5f7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651042774;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xJLFZngs4T0hXtxzxy+ozR9TggHtnXGmtAt5BMNxhIc=;
	b=gvSsDY/1Od9ObZiW5v17v75w4GdH+EopnkVyeIBiMpgpSvL9GOYmLkXDbQyYaGiSst4LL/
	riF9HbNRRFoUHe+SFkrogPxMz6wQo58m8J5sCQYut0vXIQcoYXxgvwlR0F8X0ZTZDB3+nS
	+YpQsb8ybIazrUuhXQ8kpOGTBr+dFj8=
X-MC-Unique: M7M8_L-YNYCL6Ni2QHImvg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bplxmPlKnN4oWlFBssBagWNWzoPhK5ayy1XjOy3ABWUxuPUaCKXJ6pxAB5JK/6NVsqbEeztYG+w2u2soss6y8MbdkUeOuXknqz5lVGRwqppVl2o9p3ZvYF/xuhO38SSSnPSfsfTzYjoBJeP86Pv38FDEs3WZwkn+0Eq+Y/pEp3m30vALueRJGiO+QDAf9Uv96HCB7o2uNjRo86GN5/r3j4zXiqZJ08G7IdyZxFA8JJWRpSGa0JBUrXd9VFvbTOb1s0g7nO1H2mmYLL3+oqbgmnLI7bU4Ff7ouFPz3KorKU1hDRxHUyqNHQY/0Cd2kZQBfviaInBFgbjgmEIJUwYQYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZqQup/KvJeUQBuhgw0cKHBszX0Zjc6ityX+RiB4ZOqE=;
 b=Dbb3myhxkVOa8mO+UwkBZiC3PuWjAxjQSjHFA93OVuPANqouqUtW4gmHWnna41Art8CVgqYmBL2IxF8/MupxZ+AtkGdcq/hQV+HmXVQZdtK85rLjccfdTlqBszWlWdR0d0RbG1CRO3Cci+cBX1uVAWOiFZRYQzby5e6jZZ+oFHXclgN6lVTVnyC6Ijd5wlb4kxvxAmLLA+dEXI/Z945YYmV5vQyIwqPQkvXJHQRzoRlCETJ/MsQa3SBrEIBfVvpovbk5GPe2fWg/jRy1vA7dcffXS9cFRu53qGmWJ7+054gSPhsvEJ6zVyAkZRbLWUWRS/0jxSWt/KZ6xBMGmon2Mw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ec1efb6f-9d41-c018-582b-718254b55aa4@suse.com>
Date: Wed, 27 Apr 2022 08:59:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: RMRRs and Phantom Functions
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Kevin Tian
 <kevin.tian@intel.com>, Edwin Torok <edvin.torok@citrix.com>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0010.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 90046e19-6d3d-4698-2cb1-08da281b7915
X-MS-TrafficTypeDiagnostic: AM6PR04MB5271:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB527165C01889B411D6330E8EB3FA9@AM6PR04MB5271.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	R21cCM02MJSzV5bbeN3JofcgAfGyIvpy6HN7jNmYWYq6vuRQuJ8bxhAYo7WWyPgWWF3lL2N2rtOpwXLZUv4pGL3/00TAhLcUYLWZX9UjxXIz/1C1Q5UJO1VSkNOBOq37DNuIlbUS3z1kYaNf1gusFTJUC0Qn9ASp2QqQYNSYoCDZHqeX88bWPFxzmVAoIIKzMAyjJVjY3LWLCJiP0yIfSsx4pEbMfQk0ulVbnjQsOoVAEPh41BkBzfyNUD8Kad4IlSWzz5VoZFF2z5XbePSLEw120k1Ob9cH2GsWT5yyfIFZEZpzGOGKTjAczNYX8K2dQRctxZ11JCTukxQ3C7ibJIeB0A7e78PbemjENYhGp6QetBMdcowvGRYBubk6NExARs7mEWGEyQgG1Om8PDVvRfLGhgLPiYydZPW8kIhSTVKGRCcWceGrBnpEMJ5YFEf5sGO0IUMjm/HtPOon5VQE5+SlAm41x9u9RBeW2fFmlTCaX0iFSsJlO+RAZOPe71hh0dE0qDaP+tAYxwo2c0MNhec/xjoTpAA5dLkFkh7pChk9WoQUBwkds7jSlewFnjsTDBLX13SMur7yxOmscRLdq3H5XNw0p68FjoS6UQBiCAvg4HOpIsJZIDHECobSLXBmixQoIdnDWFpm7gDR61VtcT4Wfb5erS73Uoo7fSKWtfHqF/k4QeJcgcvWRU3pLphoJW9mGDK4h/uoZb8rowZbNSdbSBbhg0IolNZr0PjE2dICRbq9SdnKwmuer1bpHkeN
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(5660300002)(83380400001)(26005)(31686004)(6512007)(6916009)(54906003)(8936002)(186003)(36756003)(6506007)(53546011)(2616005)(508600001)(38100700002)(3480700007)(31696002)(2906002)(6486002)(8676002)(66556008)(4326008)(66946007)(66476007)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?J8pxpn64VMXfIjXnvrS+9YdQR6odPfD9pnfvh0CvjGss67O11ERvVk+1BoB0?=
 =?us-ascii?Q?oL6GDECZZDtVlohg/6yMpAvx03W/XVh/nF1HNTQWbCC71QES+4EjhP+ySu9s?=
 =?us-ascii?Q?y3mkUFcuZkO9AOifAOWJRXyMqDn9Pb/UK74R93zpQwNfW0xdNGkzL+kgoSST?=
 =?us-ascii?Q?Wl4kI/9LLlIgGCLJbFHWQL43ecuQXe2MxJI6sMkC47YaPEpIYouRmIOLgA+Y?=
 =?us-ascii?Q?6eBGfWc8agnQT6B4YMjWng+AK7CSQ0QcGTGUXcTdaq9j8p/KUb22E4OAkwga?=
 =?us-ascii?Q?eEdYuGF1jA+1WErNY/uQtQQ0Tvzh0/s2R5B4ExV/cLWnvWxll4OPf1DbwCEQ?=
 =?us-ascii?Q?Am5uMYCkcAbFjSfQqAFHF0QSFyEWnqcId1aTqhOotH02UUJV7ILOYI8F/AsX?=
 =?us-ascii?Q?l6jEH4tf8arrfjquOB4EH6LJaLF3vSDTZ26TeLjqv36bhlymBvU1pJZyhAjS?=
 =?us-ascii?Q?GVkfDqZncO4dEtncOx1p28sQeHaxqi5tn+SyRtS+gWDqYU46fk3PasKXFItQ?=
 =?us-ascii?Q?BNw8ZR1I2hzZ9f5pzHuRtQt/c6ei+AkiFAdzoMo47It/XksmlmN2CvCDIWkZ?=
 =?us-ascii?Q?+IWziLzNoqfNLlqPdOF8npNbPxW9Rw9uQyfubh1pYiRhEYxH4QswmGFEbho1?=
 =?us-ascii?Q?htxoDaWuLQA+9FA+k/yuqE/byW+VIMEdcYUfaKZEqzFV2QDcJxW499eD/cBg?=
 =?us-ascii?Q?iN2766VR+WTPTwTyj9EDalrrY8S/0ylTdxZK8beJQkAKsJNgGNAGcul5Nlde?=
 =?us-ascii?Q?c5fAmKfMvWOBJVuOCHuB9LOT0uWgHTLu/c4Koamw0zhWNv3DQuDKUGme4GkA?=
 =?us-ascii?Q?XlgaodP13zA7hhk/sklK8p3wPmB+tJvGDv4akOmQ1tmSoFXP3X+pZUjdwjXO?=
 =?us-ascii?Q?LMrVACh9UwpSXJIE9MMsAAwHMr8YRiQef03ky+Qns/5h8bEfMJjiXeCRpOyD?=
 =?us-ascii?Q?0NQV6VN1NIwiSn2096hPrAAcAQsnHQmhzTfrzs38EEBqNkZVj1PgBubV2VWa?=
 =?us-ascii?Q?waa8mC7+Wm/hli8i+/5sYAsPIJxJNX63Z/DnmWPaRI7wRhfeBdbUkzz63Zpc?=
 =?us-ascii?Q?mkuGIdL0Bn6QqLWaMG98sMba8t+vQ1rkvtPocTBrTUJFZ8ZD2BhqW/TSqxxq?=
 =?us-ascii?Q?w/o3tXDYgP0hHT5Fd0RmD/aziLjXAPmvureNSF0k8zeF2/CDGlEEHqPMd3fT?=
 =?us-ascii?Q?vnX84E/zV/YCBOTcT7e5i5Cbw2HnfIdSX5htD5HmfZ6lU0ps5SpmHaBv0aew?=
 =?us-ascii?Q?4E46anSJmg19BprpfyHemoVzKFkl9i4mDEGW/KG3xDAh9Sdr3G4+wUkwKTH4?=
 =?us-ascii?Q?Tk/J2q23ECi36OaGOcCQt+0hMnCw/AZsSHtM0dqsatjPTgdwfYSxvQmISpaJ?=
 =?us-ascii?Q?SeuO2t+aaukGX0Q34bpCTXnuPHB5gh2RopAlu4FGAJehZyXDMR7Ci1C7V07y?=
 =?us-ascii?Q?83gzLfVa4Rso4GE0Nqw5w7JWMbiekmq9t9bNC8Rcwp0KVtHYGoQOl5uridfV?=
 =?us-ascii?Q?Jya0HtXAQYtXbYIbzP3A4hz783mW85ALvWQsB+Zl6DmmkVR+mhsVlFcdYKUi?=
 =?us-ascii?Q?zo04Y6MfAUrM7aKe/Hb/RvUSSH/nNca5kxxOCltzdnzyOgCTukogbRNvQHQS?=
 =?us-ascii?Q?hnv18OQgD8sxxO5EKg4uVYuI1U0WKCWyKmZvBOXVeHSzMXB8DUqaj32ARVrA?=
 =?us-ascii?Q?fL8xlLjMwa368fLPPyim7e5COb3M6A7wwWcIe/XtFJL4zo9wYIObbdvZf5ri?=
 =?us-ascii?Q?rLSlsL9rQg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90046e19-6d3d-4698-2cb1-08da281b7915
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 06:59:28.8411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iNK8ezkAr3Sc2jd/DI4pk/OTvzJnYNvPf1wWjBXuSYcHW35IYFeJnmAcNmxLafkYugQMk3kmFX1gQQQDJAizKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5271

On 26.04.2022 19:51, Andrew Cooper wrote:
> Hello,
>=20
> Edvin has found a machine with some very weird properties.=C2=A0 It is an=
 HP
> ProLiant BL460c Gen8 with:
>=20
> =C2=A0\-[0000:00]-+-00.0=C2=A0 Intel Corporation Xeon E5/Core i7 DMI2
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
+-01.0-[11]--
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
+-01.1-[02]--
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
+-02.0-[04]--+-00.0=C2=A0 Emulex Corporation OneConnect 10Gb NIC
> (be3)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 +-00.1=
=C2=A0 Emulex Corporation OneConnect 10Gb NIC
> (be3)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 +-00.2=
=C2=A0 Emulex Corporation OneConnect 10Gb
> iSCSI Initiator (be3)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
|=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \-00.3=
=C2=A0 Emulex Corporation OneConnect 10Gb
> iSCSI Initiator (be3)
>=20
> yet all 4 other functions on the device periodically hit IOMMU faults
> (~once every 5 mins, so definitely stats).
>=20
> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.4] fault addr
> bdf80000
> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.5] fault addr
> bdf80000
> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.6] fault addr
> bdf80000
> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.7] fault addr
> bdf80000
>=20
> There are several RMRRs covering the these devices, with:
>=20
> (XEN) [VT-D]found ACPI_DMAR_RMRR:
> (XEN) [VT-D] endpoint: 0000:03:00.0
> (XEN) [VT-D] endpoint: 0000:01:00.0
> (XEN) [VT-D] endpoint: 0000:01:00.2
> (XEN) [VT-D] endpoint: 0000:04:00.0
> (XEN) [VT-D] endpoint: 0000:04:00.1
> (XEN) [VT-D] endpoint: 0000:04:00.2
> (XEN) [VT-D] endpoint: 0000:04:00.3
> (XEN) [VT-D]dmar.c:608:=C2=A0=C2=A0 RMRR region: base_addr bdf8f000 end_a=
ddr bdf92fff
>=20
> being the one relevant to these faults.=C2=A0 I've not manually decoded t=
he
> DMAR table because device paths are horrible to follow but there are at
> least the correct number of endpoints.=C2=A0 The functions all have SR-IO=
V
> (disabled) and ARI (enabled).=C2=A0 None have any Phantom functions descr=
ibed.
>=20
> Specifying pci-phantom=3D04:00,1 does appear to work around the faults,
> but it's not right, because functions 1 thru 3 aren't actually phantom.

Indeed, and I think you really mean "pci-phantom=3D04:00,4". I guess we
should actually refuse "pci-phantom=3D04:00,1" in a case like this one.
The problem is that at the point we set pdev->phantom_stride we may
not know of the other devices, yet. But I guess we could attempt a
config space read of the supposed phantom function's device/vendor
and do <whatever> if these aren't both 0xffff.

> Also, I don't see any logic which actually wires up phantom functions
> like this to share RMRRs/IVMDs in IO contexts.

See for example deassign_device():

    while ( pdev->phantom_stride )
    {
        devfn +=3D pdev->phantom_stride;
        if ( PCI_SLOT(devfn) !=3D PCI_SLOT(pdev->devfn) )
            break;
        ret =3D iommu_call(hd->platform_ops, reassign_device, d, target, de=
vfn,
                         pci_to_dev(pdev));
        if ( ret )
            goto out;
    }

The hook is invoked with a devfn different from pdev's, and the VT-d
function then looks up the RMRR based on pdev while populating the
context entry for the given devfn. Or at least that's how it's
intended to work.

Jan

>=C2=A0 The faults only
> disappear as a side effect of 04:00.0 and 04:00.4 being in dom0, as far
> as I can tell.
>=20
> Simply giving the RMRR via rmrr=3D doesn't work (presumably because of no
> patching actual devices, but there's no warning), but it feels as if it
> ought to.
>=20
> ~Andrew



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 07:03:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 07:03:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314403.532458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbhi-0006BC-AX; Wed, 27 Apr 2022 07:03:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314403.532458; Wed, 27 Apr 2022 07:03:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbhi-0006B5-7b; Wed, 27 Apr 2022 07:03:14 +0000
Received: by outflank-mailman (input) for mailman id 314403;
 Wed, 27 Apr 2022 07:03:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1GEo=VF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njbhg-0006Ax-W2
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 07:03:13 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19cb4761-c5f8-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 09:03:11 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 67BAF1F380;
 Wed, 27 Apr 2022 07:03:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4ED0813A39;
 Wed, 27 Apr 2022 07:03:11 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KKP3Ea/qaGKFHQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 27 Apr 2022 07:03:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19cb4761-c5f8-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651042991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=Vjq7etHyeCtmVd5oMifGmezFnWjw8TaQ+sfePAnJ0yU=;
	b=SqSGRdaDvgxvKxoZnuP8dtYB2r5OwsnhDD4YAtuEOBOg+R6/s6aIUT5StEbsZPg8waQU9B
	nd83w01dfhfusz6TkZ9dole9/1UzrgiQYiGnHJVZn6ZEPBYyL0frYACbU0L7sxgXCBTAG3
	ckWVryhTgfjsPfKaPza2VJIMTSS2Hu8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>
Subject: [PATCH v2] xen/public: add new macro to ring.h
Date: Wed, 27 Apr 2022 09:03:09 +0200
Message-Id: <20220427070309.15090-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

For the initialization of a ring page by the frontend two macros are
available in ring.h: SHARED_RING_INIT() and FRONT_RING_INIT().

All known users use always both of them in direct sequence.

Add another macro XEN_FRONT_RING_INIT() combining the two macros.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- modify comment (Jan Beulich)
- drop underscores from macro parameters (Jan Beulich)
---
 xen/include/public/io/ring.h | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/xen/include/public/io/ring.h b/xen/include/public/io/ring.h
index 277af36e61..ab3439bd58 100644
--- a/xen/include/public/io/ring.h
+++ b/xen/include/public/io/ring.h
@@ -95,9 +95,8 @@ typedef unsigned int RING_IDX;
  * of the shared memory area (PAGE_SIZE, for instance). To initialise
  * the front half:
  *
- *     mytag_front_ring_t front_ring;
- *     SHARED_RING_INIT((mytag_sring_t *)shared_page);
- *     FRONT_RING_INIT(&front_ring, (mytag_sring_t *)shared_page, PAGE_SIZE);
+ *     mytag_front_ring_t ring;
+ *     XEN_FRONT_RING_INIT(&ring, (mytag_sring_t *)shared_page, PAGE_SIZE);
  *
  * Initializing the back follows similarly (note that only the front
  * initializes the shared ring):
@@ -184,6 +183,11 @@ typedef struct __name##_back_ring __name##_back_ring_t
 
 #define FRONT_RING_INIT(_r, _s, __size) FRONT_RING_ATTACH(_r, _s, 0, __size)
 
+#define XEN_FRONT_RING_INIT(r, s, size) do {                            \
+    SHARED_RING_INIT(s);                                                \
+    FRONT_RING_INIT(r, s, size);                                        \
+} while (0)
+
 #define BACK_RING_ATTACH(_r, _s, _i, __size) do {                       \
     (_r)->rsp_prod_pvt = (_i);                                          \
     (_r)->req_cons = (_i);                                              \
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 07:07:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 07:07:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314409.532469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbm3-0006pA-TL; Wed, 27 Apr 2022 07:07:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314409.532469; Wed, 27 Apr 2022 07:07:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbm3-0006p3-Pp; Wed, 27 Apr 2022 07:07:43 +0000
Received: by outflank-mailman (input) for mailman id 314409;
 Wed, 27 Apr 2022 07:07:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njbm2-0006ox-Qv
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 07:07:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id baa00c15-c5f8-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 09:07:41 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-OgBtSbAbMhyJyoJMcLcegg-1; Wed, 27 Apr 2022 09:07:38 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM5PR04MB2962.eurprd04.prod.outlook.com (2603:10a6:206:6::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 07:07:35 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 07:07:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: baa00c15-c5f8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651043261;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Lb9B0eYhSQb3LyWAZxhNXx7pYUyYE2DyU1ePw2QmiEM=;
	b=X+PqnXG3+RnqTk+bHJQl97ec5ZukD15JWC4jLwDpia+2p6iZ+FBbv8lB45XGUPM/LJvksq
	q63tDVmlYDITT+4fznZyldaFjeH6U8mnHlBJUMMQINGVlk9zILMsQm4Lh/FIPwG+RCSmCj
	Lh+CwQ6rR3rSjCN5h1lcs/2NkJsB4pA=
X-MC-Unique: OgBtSbAbMhyJyoJMcLcegg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BVFQfXfJ5f+/jtXeS3nr1n0oLLokXF7mgH/8glcxfQoYbVBVyrQzQ9MbTQLx/LX2+t8BPB96WSXytv7/UrG9hIK97iMjJ5HGD5EpQH7JhopAdEyKpfogyoE697m0p7MDs+soS2vaf6mmYQss9IrV5e8ZDcU1JHb/Opo/XA+aVDKC2uqOLiaRZNjKBvFFqx2iKXkxU9n+luDrc6FUbyf5VZ2f0yPJ8E8qbOJdF8SrShym/2BMGfdZ92tYYsh2WUU97l0baY+MZEDlqaVRCRnfnnp7AiE3oEML+2p00Tmv6qNy/KVQRvNMo0P3Av86lYAKUo9zdlczW6qp+HW8gsIWTw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lb9B0eYhSQb3LyWAZxhNXx7pYUyYE2DyU1ePw2QmiEM=;
 b=iW7bN/4HTa5cCqPFbAHtraUdlIaykvuStFQTOr7ISczZmPz8TAq9p+xBDt2NHotuWQlgmX2cO2LW9IFJFMFlGZHMfBpHesGYmydGf9I/9jhfmln7whpcPP3Io4R5083LNFcW+Xp/TCE+gSuZTFZl1dSd+FRuihqI2OYkuM8NhJaVpCv6jaUp52nbkItpEkFSJrCu6QkyrmXEFg/ngHU47zZKsyziH6RXimR+eRI0u57Z7EEZ9CXbkzXItWN+0hIRD43h2puUPj5nOD1/Xy+OESAjnQDZqjsYW/TWO/LZzztSRDMy2Bou8qPz0Jq+MM90qVde3+5c1ksp8Z7gJP9fVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d6c2b3b5-6eb4-e094-fc9f-5214f8c12df0@suse.com>
Date: Wed, 27 Apr 2022 09:07:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register
 state
Content-Language: en-US
To: "Lengyel, Tamas" <tamas.lengyel@intel.com>
Cc: "Nakajima, Jun" <jun.nakajima@intel.com>,
 "Cooper, Andrew" <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Pau_Monn=c3=a9=2c_Roger?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>,
 George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "Tian, Kevin" <kevin.tian@intel.com>
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
 <BN9PR11MB527638D2BE6087C1A4D796D48CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <BN9PR11MB527638D2BE6087C1A4D796D48CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0489.eurprd06.prod.outlook.com
 (2603:10a6:20b:49b::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 15eadbb1-39fc-439f-42c4-08da281c9b66
X-MS-TrafficTypeDiagnostic: AM5PR04MB2962:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB29629B9D40FBB98B29C009D0B3FA9@AM5PR04MB2962.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	K/dGHFK/RAdUKtRx3/NQC0aBg99VGagiX1OiF/A4frLhummPEaSU3mJNcozvw19GOYq88B/shzIuuUMiWLQYoq68mYaOpX1F9D32XrrwD5PjFM/j8rCo3i9PHgJi9RzG/tNnbTDr7SjjfoElJn+tsbtfynL4r6E1PBlXjypnumO/w8fHxW+1Dd8CB5ZHGoNwikGvlWrYiS+5B9Tx0H8oUDRrhudCjI46AKp0hC3PYinQ69/9HwGigzWghu765HK6PqEPsLQHn+ARtaCPPwnoAmzSrFg64Yp/PCtuj6X8vBOp1unpsD08vcSEEHRpwXny7oUhrV+iysXISy0PJV+/62NnV8mzeIT/afF841awiZxONLrEYuCHkkLe2bJ0FApSdi5AnDYwFAf2bb72qh58gS7oqLQPFpT5wv6CrPs+VsRp8EruS9wFe5CR50IcwQw8VTsAaaXIybnxmZXMXO/i1nZ6F1oc8TF78qKN+ALqXhmFeuxjyHeVtDu39f1jkfm0SkBbIHYtl/0jaYC8wBBROAO/PAqWLw6LsRY0xOpZPdg2YkaHxaZ26nZ36pwcyAkHWZeNeS/DZvKFWxjNK10qUFrM1J2xyhxhHo8/6XsBJsQQSie03T1xj2GnfH7stgM963f7hcFudJrC5WP30PfT6IhgM4D6SECimVAMvgQ0oRgRnTXx1GugEhUMcBXYSNvxMJci5toBDei1TKpHfRw9Akp+MKwh4PrQFNXMjE5fkr3iWuh+v7Cr2NYVEZhTjSqc
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(31686004)(54906003)(26005)(6916009)(38100700002)(5660300002)(6506007)(31696002)(53546011)(4326008)(66476007)(86362001)(8676002)(66946007)(66556008)(36756003)(2906002)(8936002)(508600001)(316002)(186003)(2616005)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K2NLQWxSYURPQzYyR0FvVUVGOW1KWTExczRwN040Yno3OW5QV2ZLOW1tN043?=
 =?utf-8?B?N2lBbnFvL0JNek9lenJDZFJDbTBhUFJReGpSYTNIVXRSQ0NhQTdDVWFMRXFn?=
 =?utf-8?B?djluZkt4ZjF2aFRyT2NZc2d1TlUwM2FYWWpxVFlRbDMvUDFPYWNhTGhtV2VK?=
 =?utf-8?B?eEZwZGRQNktSNWY4WFNwbVd4WFRmV2M4b2VyWnZRMkpCQmprVVlUT3MrdFhT?=
 =?utf-8?B?MUNxVEpwVnVEclVvRkxyQ3MyWkdzb3pXbk1xSWhqcXZxQS93TWVBbmFnZEsx?=
 =?utf-8?B?ZlpUc0xzdmw5NkNtL2xpbGNBV3hXM2lHQjlOQnU3anh0bzNkTTFoOG9nL2NK?=
 =?utf-8?B?Vy9ZM3o0dzlJNFhQUjVuVzBXQTFNcVRmVXV0RHNYektHcWwrU1RsTlBkUDIy?=
 =?utf-8?B?Ni9JZ2U5c3hkUTFIalZGUEgxL0N1a1ljRWNNMFBZZ0o3Rlh4R3VsaGdtMktr?=
 =?utf-8?B?R0tsVWtLUWFXQnROYmVBRkduR2h4djU4MCtraVZYRmUxU3BVdW5wSVZmM3NU?=
 =?utf-8?B?aFUwb1hidEZBTk9PUWJwL0tlaS9KSkNMbk1NT1o4dDFQSkE4dTdIZ2JrZ3NY?=
 =?utf-8?B?RVk5SzNsT3pHcHRaUHRYS3hmYStJSms1VDIwUXV5T0dBZ2h4Nml1UnJJbG5F?=
 =?utf-8?B?M0pLNkxFZFZOVld1TmE0cGMwMWFDWWxzalVHamZ1azVIU29pdXc4YkUwUW5u?=
 =?utf-8?B?bmgvY2c3cDZOTHNNQ0dmWTM2TVFFS1N4UkpmSHk0UDhpV01HVmNiQnNIT0lQ?=
 =?utf-8?B?WmVXYnVIcnZxOHBOWHorb3k3ajlZT2JuWnRGZm1rOXdrTVA1cW4xSy9XUU5y?=
 =?utf-8?B?c20rUGhSYlVwQTlRbnlibmNmSzQya2tjUEtlbDAwZ2o3U2R5OFJSdFM2emF1?=
 =?utf-8?B?a1UxOFJkazZRS1NuQ0Z4bjFmNnQrbEN2L3JnTGhCQkl2b0J2Z01kdk1tY3pU?=
 =?utf-8?B?OUhSVHVESG04NWtyZG1uQjZmZTIwZVBCNmhpUldoZHFiTlFhWDhPVHR1TEd6?=
 =?utf-8?B?T1NpRzgwajlZajBmNzZ6M2MvNnpOVVMxN3FLaE14UWdMV3FVSDJEbE5OaHdl?=
 =?utf-8?B?dFphcHk4V1F3bVhzY2hzNWk0TzRQMHNjQWJVRU9RRGpua0NmbkZZdXFpY3dP?=
 =?utf-8?B?KzhacWs5bzhFTlRkelhHNHlaNGZTT2NsV3N2RmhrRGFydGE0TUFpYUtCMEI5?=
 =?utf-8?B?Y1FCRjVGSjlKU1VMU1lmT0xTVWFuaTNsdmJWbnYyTURUWEhDTE5JV0RiWEox?=
 =?utf-8?B?bXZsWExxT3pld3JXVVB6WmRISzYrU0R2Y3prWUtCOGN0QWxoTjBSUVpaU0dM?=
 =?utf-8?B?TERFd08ySERQZlArdDVOeUlHanZPUkNleEJSemRsTFZuY2E2ME05NHhHYkxH?=
 =?utf-8?B?bFNkbU0vWXBaOGx0N0VNbTZHdFRPNE1HYmU1RlkxbXZkSXp6YWdwN1RaU09u?=
 =?utf-8?B?KzNRY3dEYjNRRWhZM3R2QTlQek9zeTRaVGU0QmExSTZQakZDOVdXeFFOK1Zm?=
 =?utf-8?B?NTBNZGp1TkYwUklkay9uaUVBUE9FbFBWZC8veEgzQ1drZENZRDJRRUR5VkRs?=
 =?utf-8?B?ODFmY0g1WFlTM1NhZHc0UmpTMzRzNWhEWnlNUkJ5cVhrTUMxZjhQZmpidUNM?=
 =?utf-8?B?Vjh5bUNqRUhVaTlYVXZwL2VPaDM3UUdVWE5vMHNFUzAvR2ZSVUFxeXRlV2Vl?=
 =?utf-8?B?SEc2TktjS1hjRnV1UERyU0FKTGhWaXBPNHB6SWkwTzZWNEh3T2ZNbVdOVmJJ?=
 =?utf-8?B?M2ptclg3cmJ1VmRwNXlWaEx0SHJsWVJhdGtDZ0c2YmJnYWkzei9ycm9kd0s2?=
 =?utf-8?B?Y1plaXNtMXZzY25GdS9WY3VxWFlQbXhwcHp0ZlZ3bG1oT3VRemxTUlVQSmFZ?=
 =?utf-8?B?NHdERGF4cVpFMDQweE96OGViWmZNQkpLdjhJZDBYSklXanE1Tjl4YVdVOFpz?=
 =?utf-8?B?bVU0eWE2Q0dSTlpsR2Y2TEtXeGgwZEhDeTZVNnNnc0FKUTY0WGREcGFCMnQw?=
 =?utf-8?B?MWdlcnMzR3hCUW8wQzNQL0hiVHk3VEhJaERaMWJPSnJtYWkxUVB3Tm81MG1C?=
 =?utf-8?B?TzZiR2hJcTh1Mnk0c3htNEZVRDhhdUFJY1RsQ3pUdlBGMVd4SlppdXZUcms0?=
 =?utf-8?B?SUE2UTZnMnp0VytPemNGTXhCQi9pb1JBZCtzUCthUUtmQkF5TkpuUFJMUmFy?=
 =?utf-8?B?K09SNXByTytUd2hZUzQ4bzhnUVZGcm9JQ0hZZzZVS1pVMHJOT296UEl3NzUv?=
 =?utf-8?B?aDIrV21UUW9Bekd2NDhMMURQbnNhTlR5RUFmQjZDSHU0QVBGZzZqcUk5aXZ6?=
 =?utf-8?B?UXBoQXVUTkhHZnZNSnp6WGkralIzWHlyaElaeUxNTFNkRjk2bzBudz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15eadbb1-39fc-439f-42c4-08da281c9b66
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 07:07:35.8649
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wi64s7SDjpgrzzjv0NtNw1B2KYqLjVpDuidYQ+hXjSBz4ngjeqn2Sn6REqHjxbcsfeQYAQD67of1J20jU1pD1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB2962

On 27.04.2022 05:46, Tian, Kevin wrote:
>> From: Lengyel, Tamas <tamas.lengyel@intel.com>
>> Sent: Friday, March 25, 2022 9:33 PM
>>
>> During VM forking and resetting a failed vmentry has been observed due
>> to the guest non-register state going out-of-sync with the guest register
>> state. For example, a VM fork reset right after a STI instruction can trigger
>> the failed entry. This is due to the guest non-register state not being saved
>> from the parent VM, thus the reset operation only copies the register state.
>>
>> Fix this by adding a new pair of hvm functions to get/set the guest
>> non-register state so that the overall vCPU state remains in sync.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
with ...

>> @@ -863,6 +892,17 @@ static inline void hvm_set_reg(struct vcpu *v,
>> unsigned int reg, uint64_t val)
>>      ASSERT_UNREACHABLE();
>>  }
>>
>> +static inline void hvm_get_nonreg_state(struct vcpu *v,
>> +                                        struct hvm_vcpu_nonreg_state *nrs)
>> +{
>> +    ASSERT_UNREACHABLE();
>> +}
>> +static inline void hvm_set_nonreg_state(struct vcpu *v,
>> +                                        struct hvm_vcpu_nonreg_state *nrs)
>> +{
>> +    ASSERT_UNREACHABLE();
>> +}

... these unnecessary stubs dropped (they should be introduced only
once actually needed, i.e. when a caller appears in a file which is
also built when !CONFIG_HVM), and ...

>> --- a/xen/arch/x86/mm/mem_sharing.c
>> +++ b/xen/arch/x86/mm/mem_sharing.c
>> @@ -1643,6 +1643,13 @@ static int bring_up_vcpus(struct domain *cd,
>> struct domain *d)
>>      return 0;
>>  }
>>
>> +static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu
>> *cd_vcpu)
>> +{
>> +    struct hvm_vcpu_nonreg_state nrs = {};
>> +    hvm_get_nonreg_state(d_vcpu, &nrs);

... this missing blank line inserted between these two lines. I'll
make both adjustments while committing.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 07:12:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 07:12:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314439.532498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbqH-0000gc-08; Wed, 27 Apr 2022 07:12:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314439.532498; Wed, 27 Apr 2022 07:12:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbqG-0000gV-RV; Wed, 27 Apr 2022 07:12:04 +0000
Received: by outflank-mailman (input) for mailman id 314439;
 Wed, 27 Apr 2022 07:12:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njbqF-0000Lx-C1
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 07:12:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 561d86c3-c5f9-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 09:12:02 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-7o_dKtAfNoWfR5-OsPqdOQ-1; Wed, 27 Apr 2022 09:12:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB6334.eurprd04.prod.outlook.com (2603:10a6:803:102::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 07:11:56 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 07:11:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 561d86c3-c5f9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651043522;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=C+Itu8ukV/UjIqOAoynxGEAGLz9QbPd4mNuWdPdhqkY=;
	b=S7+OnG8ZBnnvZuinEf1Cd6JIhvItwCRFo4B/RRvdHFZ/K2S7k8dhOyZ0Go62Ji8JxeB1M9
	zHc/J3MNLL58F6YkpdkG66ngWwPcv+msrikXr0EGbUyA91GE+jHNT83PgGHDIgMyZu2/aL
	T3gFe6mqMlzF3hVgQc3nlRzCngYfgyg=
X-MC-Unique: 7o_dKtAfNoWfR5-OsPqdOQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QgGEMVaCXbKSkseTH0hmcDOoB5xLnTWfV1qZb/PPkhb2WvpX0yYZJTlMB3FiB9i7az5xxnQe3VM/XZaCViehn/Ofs6AUJMRO15vv1dAIYNJ60CuOX4OHaaJoxO0pvmRa3p83GUzerBiDeCmF9kXGopAze9Xtvm/Yfi2VpUMOSQ2wZqrUUdHy77wAt+2eMP+II/zkFTRIRKiHLwxc3IzBCaadlvMue76nuEYO1YDZ2ciegc/luWeqyWskPc23M68M2YArOJEz6mPo2JLpmHvZEAITk/f5fy9Reec9byc5Gq7dA7Kr4rZE3spflIIIhYQe2BX6VHSAoPIN/OYJjQ6yJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=C+Itu8ukV/UjIqOAoynxGEAGLz9QbPd4mNuWdPdhqkY=;
 b=drWLndu5vYgesZOLyCY6/NGmZKjLZ2hJujTRFB0I0gsGZJ++wZv2lfNLSBqV14gBWWFqN6uH4bmKEfnTOaHH6KoJXQRhD9rTrfnNfhmpLw4ac9Sn9onR3OkcH6KQso+0Irip20tODG8IYNxK5qebubZ2GSqMeW6n7RFmsap4UAE0BxPjGDOl+T6lnfDINvR2EJULSUyHdDjxmOVKpNbKuYwl8Ye28+pwkQqJwqFcPWxcBQBXCqouaaF4e+tYXvykbLz6f0HVD3YQf8AqdXmpOhK3o29WAcdpAH4Op4RGzR/8wv9Gx1yT2d6Q8iHArPjketo/TRyEFRAqw6J8jsZKoQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f2fe0788-ff74-b5a4-8714-e4eed4d73f14@suse.com>
Date: Wed, 27 Apr 2022 09:11:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2] xen/public: add new macro to ring.h
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
References: <20220427070309.15090-1-jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427070309.15090-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::14) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2a5b3f9e-6675-43c9-f7a2-08da281d36d8
X-MS-TrafficTypeDiagnostic: VI1PR04MB6334:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6334A69F9EE075CEA48608F5B3FA9@VI1PR04MB6334.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9c8geRuAXd6ti7vZ/5tty/z7DWMuMY65xGy9Fo6R6iQ7hJ+4hpkgQu4aDLQakOjMhD+gTL+Gh8OO8wP3ubuyc8sTa5SN/rzGMJgckfjocPIIpsnuPMNI8b3tLPUYTXVKhpwww0vh/sZq0JqDfUAkgr45l2p0H/F2hOHVZvljdFAj4/z29uXzedT+ocQx3AVRc2TsBWm3vhrYluJpXZPaPs8vuKtH/arTozZd8FWajRfrR9MaucWc4M6x/cKt2TQusdi9qquCm32qd+DXmYNZGPoB53cKME0wdIt3jM2Zmew7vjLMtChFS5Bygz9hETakSqe5bGe0gRrON5wqW16Yn00PDTDZ6XF5Eag/AKtKM5kiFrnoLu8aPiiqbujK9YfrvOQPFUkDAcSKQYZGGjZW5BdjNUAfR8mx5YhfOhctCfH72rbFFlnnqqLJd9L/lUOQNV8kjZknG3OnovBemoTL7TIGKG4Cq9RIgsYddO5eiyABR3f3v0eHW/5gmTZ+fuNfrF+iKlTk+aAFl2a2Hd7jN6DixIsA/rDsyBX9VBLHh0SVt7C343eXOoysK+D90U+Tg9JmZBSfs9JPxZmp4b5xIjiX18DUa/Rhj6gKfOUK/nX47pzD8y5jxnwaZitIBEyD8OUoFsvxLkTM2kw4xQKvKzfcHAglBXV24dZoCtyPY1Jo1pVKt9oo2u3GUqyx1UIu9FMkDy0mgUJrOFbvVPLbsvZ8fUwnwWBqTtbqkUanquyY0ZotL/vW4rnnz8xct44F
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(2906002)(6862004)(4326008)(8676002)(26005)(6506007)(66946007)(53546011)(66556008)(66476007)(5660300002)(38100700002)(186003)(31696002)(316002)(6512007)(86362001)(8936002)(6486002)(36756003)(37006003)(31686004)(6636002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dGlBTGVHNVp1WnlwUld1MENCS0pXU25Dd2VBQng5SXZvaXFlTDdQVmxlWktO?=
 =?utf-8?B?eDBWNEovRVE0SXNwejlHMThwTzEycnJaMjZrUG41YlBDSjVjVVltamJTVkVr?=
 =?utf-8?B?dndqNnhmWjlhMDFmeXNlNDVUdDYzQ2Y0WmI0U0VCOXZYbXZiTDdGUGV3T3kw?=
 =?utf-8?B?U0Q1Z29RN1cwdVBNRHJKWXkxSzJCOVl6QXNVbEJxZUZsUEdFY3BxcG9JR0FR?=
 =?utf-8?B?OWJMVHNpWmhueXdIRStLbGZGRWloUG40WEt3T1Z3b0pFcHErQ2FwU0lrVWo5?=
 =?utf-8?B?UWJRL3pqUUVoTlIvekNiSUVjV1c3MC92SkpmdDJNdm1NRTRZSllreFhBTzdQ?=
 =?utf-8?B?UWo5aHdTSmtnazNEKzFvUmlnc2c0VmNwTUZQSGxJQmhaKzBzWjlBeC9ybEVO?=
 =?utf-8?B?UTVjRUo4SFZNSFpRVi9HMG5GZGMwcE50ZGhiNWlCd3N0SFFSYWhpRksydUZV?=
 =?utf-8?B?aFQrYlJtQmtsY3VKZHYzTThEa2xOYlMyMEczUTVFL1FSZXNHbXJtalhnM3hT?=
 =?utf-8?B?bVlObFFwMlAzYitPTmh4Y3hGaXNjT053THU0NVFxdHlFZWVqcVhHcEtlWGxZ?=
 =?utf-8?B?dWpOUkRNUzFuVlh3U3BmRlR3UVhjTGtXQ2M0MjZ5MmZNUURxUEgyQkxFN2N6?=
 =?utf-8?B?VFhCbVRtMXhDTGhhanBhaVdVUjJCSE1Vam1WVzJ2WXoyRzhpZHQ2STJXQ0Ey?=
 =?utf-8?B?bjVyWXhYUmhqaW9qbzFXbmdLQmYzUXNiNEo5cy83RVRhQ3F0blRtZ1hhOWJ6?=
 =?utf-8?B?bFgzamhsdFVFODVLc1llQjRSSUtJSU5ueWI1Qk9iTWZyMUxEeEhoM2JxN2Rl?=
 =?utf-8?B?c2NDY2lnT1J1S1daVTNDVXN5QW8zanVkNlRpKzQweWozQlhJaWl2bk4vSzNO?=
 =?utf-8?B?c2ZabnhxdkVXcWNhOHBQNitOSFR5b3ZnTW03US9uTjVoeHByMCs3RFREbmRE?=
 =?utf-8?B?QWdFQ2tNYUFlb2FUY2JuaFVnTXpKRzhWKzB6d3ZScmQ2L0VaNDZ4QkFqMnZr?=
 =?utf-8?B?UHFMTm1WTXhrZktQY0VpczBCMzUvdXpOTWlLVGtLalYrOVhDcHRvblB3dS90?=
 =?utf-8?B?bGtKNUNyeUdjZUNHWHRvM2hjNWtXTFYxUEJ0L3RDcU8xTHRYQyt6MzNDdkR4?=
 =?utf-8?B?Q29ka0M0SzdrZlZ3QzZwMUQzcW56c3FEa2l1MHJ0Y3I4Nkgxd0NUcjBCQmZ4?=
 =?utf-8?B?T3p1Q2NLU2h0QXhHNXFmUTJQZ3orTStPdXA5VlVRaUZmNUJ1c1h6bDlqaU4x?=
 =?utf-8?B?aUJHMW51SjlZQjh2bEl2U2FIenFnOFY5K2JsRG9oNmJHWGRmckxwOGV3TGpp?=
 =?utf-8?B?a3hjOEtSaWdzY3UrUGkzNHVVcUh3alRpSzlBTmw4MlBiR2tjdXhaMXdHbGg0?=
 =?utf-8?B?R1BQT1VyR0VCS0hUTnNjOUtxMmtSVjRzSktmbHp1YkNKQmo3aC9BN0Z1bmtq?=
 =?utf-8?B?WTNMNTNLL013bnk3NzJYMFZzZ2s2MkZnd05rejFROXNFZmNjU0xSQURkT1hL?=
 =?utf-8?B?YlcyamZ0RzJMczNVSlV5bzN6ZGRXOW8rcnpjcW1NVmJjNGpuYnNPTDBqMzBP?=
 =?utf-8?B?ZERuajUzV29qWDhlYWxVWUJMR3dUb3RqTDdYaUVTQzFqYTZXVEY1T1Q4Yk9N?=
 =?utf-8?B?dUtITWlDNCtpT0FucEJDUDJQajBsSW8zQmFxTDZvYVRKbm0vOXEyclVNM2pV?=
 =?utf-8?B?a05SY2FCd0lJS3pNQ0JvYnhzTmNMcmV5Q3VOUlVocmtidlh0MHNyYmdpM3dm?=
 =?utf-8?B?eUdFb0hOL1dwWFAwbGkwbFRRQkhRVjBqRUxVdDN3QkNQR2J2VjE2TW9lazUw?=
 =?utf-8?B?aVQ0UllMZklNdjcxR1NNbTRGWW5NRGtmR2RSQ3poVG5jV05QY2VuOTRNMnNT?=
 =?utf-8?B?cU1pclZHTEZCd2M5SzJlcklpQ1JtN3dzbTEwWWJrY2lqYW5rVlVVdEwxcTJP?=
 =?utf-8?B?ZFpsVGF2ME5FOU5IZ1ViZDlWZkRtMUwzSkl0RVZZSDdJVm1GQitXTTlvWGtL?=
 =?utf-8?B?ZkMxSkxSOTZ1RHpaS2I5MDN6ancxNHZvQVpWdUNIRzNlYUpIQXJjT2pUZk9X?=
 =?utf-8?B?UzIwdDJQaXJrTG1Sd0JLNkNlTDFLbWxnOEJraCt5ck1nNG1jRVpNcHpxMlRw?=
 =?utf-8?B?TUl1Mlg1UzJSUjFqYmZja1hXTjFxNU8zYmdKbkljdVdaRjNSbUNJQ0FiRTRn?=
 =?utf-8?B?TUI4N25HV0V6T1djU3YwQ1Z2Yk9yTXExYkNxb2VtRDVxZEgrYTh0SWdUZFNn?=
 =?utf-8?B?ZUg2Q1duRHRlaFMxQ09pNWxjbFhXMW1XTC8rMUxhYXpkcGJ4QUdHQlpCeEhx?=
 =?utf-8?B?Nm8yK1FWS1BrT2lLS3RSZjYvNnFyQ01XOXBsdm5tTGpsZUV3dWpHQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5b3f9e-6675-43c9-f7a2-08da281d36d8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 07:11:56.7260
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XnGxW9ZKFVe2bIOxFHQEhRRe9s3diBtNQni/I5Dm4iaq4UFKBZ6TI43WGU+leUY/BCVs+H13gKtr22fGCkH6Yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6334

On 27.04.2022 09:03, Juergen Gross wrote:
> For the initialization of a ring page by the frontend two macros are
> available in ring.h: SHARED_RING_INIT() and FRONT_RING_INIT().
> 
> All known users use always both of them in direct sequence.
> 
> Add another macro XEN_FRONT_RING_INIT() combining the two macros.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
albeit ...

> --- a/xen/include/public/io/ring.h
> +++ b/xen/include/public/io/ring.h
> @@ -95,9 +95,8 @@ typedef unsigned int RING_IDX;
>   * of the shared memory area (PAGE_SIZE, for instance). To initialise
>   * the front half:
>   *
> - *     mytag_front_ring_t front_ring;
> - *     SHARED_RING_INIT((mytag_sring_t *)shared_page);
> - *     FRONT_RING_INIT(&front_ring, (mytag_sring_t *)shared_page, PAGE_SIZE);
> + *     mytag_front_ring_t ring;
> + *     XEN_FRONT_RING_INIT(&ring, (mytag_sring_t *)shared_page, PAGE_SIZE);

... I had hoped for the original text to remain and the new macro
being suggested as a shorthand. But you're the maintainer ...

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 07:14:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 07:14:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314447.532509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbsK-0001QG-AF; Wed, 27 Apr 2022 07:14:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314447.532509; Wed, 27 Apr 2022 07:14:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbsK-0001Q9-7M; Wed, 27 Apr 2022 07:14:12 +0000
Received: by outflank-mailman (input) for mailman id 314447;
 Wed, 27 Apr 2022 07:14:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njbsI-0001Pt-LQ; Wed, 27 Apr 2022 07:14:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njbsI-0007Cr-I4; Wed, 27 Apr 2022 07:14:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njbsI-0004cm-3U; Wed, 27 Apr 2022 07:14:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njbsI-0006bb-36; Wed, 27 Apr 2022 07:14:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1GV/0RbZz0vmUuprgtYBJbgmz/Ds4w7PcxrPr0tr3VM=; b=vZE80bL4XZUt5uhKBU5VaUqusj
	aD3wHs/FjW6d/yTciEvDlD/4+kb1sdbbvYIuq1v3pXKIkiKfVPlJ4SQzdlOuX/kzg7TNCJpt5aQ1v
	PFJc370GxFE/TQnSWX+sIdQHQ2bb3Fxz1DSNxE0DrhrT3GMIdfLeM8zSKdyrfKLDC6nI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169770-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169770: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 07:14:10 +0000

flight 169770 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169770/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  657 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   29 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 07:14:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 07:14:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314450.532519 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbsQ-0001ig-JH; Wed, 27 Apr 2022 07:14:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314450.532519; Wed, 27 Apr 2022 07:14:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njbsQ-0001iW-Fq; Wed, 27 Apr 2022 07:14:18 +0000
Received: by outflank-mailman (input) for mailman id 314450;
 Wed, 27 Apr 2022 07:14:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1GEo=VF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njbsP-0001i2-Jk
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 07:14:17 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a5d77231-c5f9-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 09:14:16 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EA286210EB;
 Wed, 27 Apr 2022 07:14:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D2ABB13A39;
 Wed, 27 Apr 2022 07:14:15 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ZkvsMUftaGIsIgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 27 Apr 2022 07:14:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5d77231-c5f9-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651043655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SdjsoceP1idfPJtfOz3JxfMbE90qN49iAVy3UNsLWlc=;
	b=j75iKNrB0fsnKUe9dlS16j6EmX9TbtrhdPiqjKV7O8ET/zFDa/E5+v22ht0w02mDUwrQJY
	9W+GxOyQG2LQMiB1rPrbAwP7WBZnvd4vJSAF/iVis0ZOnh2t9b2dUIOGnWeWlCyCA8WrW/
	0u0qNNUC83LRqeHMDiaoi2IjpW7UD6w=
Message-ID: <24f49b4c-9682-d224-7b15-774ee5795350@suse.com>
Date: Wed, 27 Apr 2022 09:14:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] xen/public: add new macro to ring.h
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
References: <20220427070309.15090-1-jgross@suse.com>
 <f2fe0788-ff74-b5a4-8714-e4eed4d73f14@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <f2fe0788-ff74-b5a4-8714-e4eed4d73f14@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------CuI8A3qOkSsiuA9owP7fPD0n"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------CuI8A3qOkSsiuA9owP7fPD0n
Content-Type: multipart/mixed; boundary="------------t9J87nOorznInzZnZp5048Ud";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
Message-ID: <24f49b4c-9682-d224-7b15-774ee5795350@suse.com>
Subject: Re: [PATCH v2] xen/public: add new macro to ring.h
References: <20220427070309.15090-1-jgross@suse.com>
 <f2fe0788-ff74-b5a4-8714-e4eed4d73f14@suse.com>
In-Reply-To: <f2fe0788-ff74-b5a4-8714-e4eed4d73f14@suse.com>

--------------t9J87nOorznInzZnZp5048Ud
Content-Type: multipart/mixed; boundary="------------WsOdLrRvG54ey5lshX075Em6"

--------------WsOdLrRvG54ey5lshX075Em6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjcuMDQuMjIgMDk6MTEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNy4wNC4yMDIy
IDA5OjAzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gRm9yIHRoZSBpbml0aWFsaXphdGlv
biBvZiBhIHJpbmcgcGFnZSBieSB0aGUgZnJvbnRlbmQgdHdvIG1hY3JvcyBhcmUNCj4+IGF2
YWlsYWJsZSBpbiByaW5nLmg6IFNIQVJFRF9SSU5HX0lOSVQoKSBhbmQgRlJPTlRfUklOR19J
TklUKCkuDQo+Pg0KPj4gQWxsIGtub3duIHVzZXJzIHVzZSBhbHdheXMgYm90aCBvZiB0aGVt
IGluIGRpcmVjdCBzZXF1ZW5jZS4NCj4+DQo+PiBBZGQgYW5vdGhlciBtYWNybyBYRU5fRlJP
TlRfUklOR19JTklUKCkgY29tYmluaW5nIHRoZSB0d28gbWFjcm9zLg0KPj4NCj4+IFNpZ25l
ZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gDQo+IFJldmll
d2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IGFsYmVpdCAuLi4N
Cj4gDQo+PiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvaW8vcmluZy5oDQo+PiArKysgYi94
ZW4vaW5jbHVkZS9wdWJsaWMvaW8vcmluZy5oDQo+PiBAQCAtOTUsOSArOTUsOCBAQCB0eXBl
ZGVmIHVuc2lnbmVkIGludCBSSU5HX0lEWDsNCj4+ICAgICogb2YgdGhlIHNoYXJlZCBtZW1v
cnkgYXJlYSAoUEFHRV9TSVpFLCBmb3IgaW5zdGFuY2UpLiBUbyBpbml0aWFsaXNlDQo+PiAg
ICAqIHRoZSBmcm9udCBoYWxmOg0KPj4gICAgKg0KPj4gLSAqICAgICBteXRhZ19mcm9udF9y
aW5nX3QgZnJvbnRfcmluZzsNCj4+IC0gKiAgICAgU0hBUkVEX1JJTkdfSU5JVCgobXl0YWdf
c3JpbmdfdCAqKXNoYXJlZF9wYWdlKTsNCj4+IC0gKiAgICAgRlJPTlRfUklOR19JTklUKCZm
cm9udF9yaW5nLCAobXl0YWdfc3JpbmdfdCAqKXNoYXJlZF9wYWdlLCBQQUdFX1NJWkUpOw0K
Pj4gKyAqICAgICBteXRhZ19mcm9udF9yaW5nX3QgcmluZzsNCj4+ICsgKiAgICAgWEVOX0ZS
T05UX1JJTkdfSU5JVCgmcmluZywgKG15dGFnX3NyaW5nX3QgKilzaGFyZWRfcGFnZSwgUEFH
RV9TSVpFKTsNCj4gDQo+IC4uLiBJIGhhZCBob3BlZCBmb3IgdGhlIG9yaWdpbmFsIHRleHQg
dG8gcmVtYWluIGFuZCB0aGUgbmV3IG1hY3JvDQo+IGJlaW5nIHN1Z2dlc3RlZCBhcyBhIHNo
b3J0aGFuZC4gQnV0IHlvdSdyZSB0aGUgbWFpbnRhaW5lciAuLi4NCg0KSSBwcmVmZXIgdGhl
IHNpbmdsZSBtYWNybywgYXMgaXQgaXMgbGVzcyBjb2RlIGFuZCBoYXMgdGhlIHByb3Blcg0K
bmFtZSBzcGFjZS4NCg0KDQpKdWVyZ2VuDQo=
--------------WsOdLrRvG54ey5lshX075Em6
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------WsOdLrRvG54ey5lshX075Em6--

--------------t9J87nOorznInzZnZp5048Ud--

--------------CuI8A3qOkSsiuA9owP7fPD0n
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJo7UcFAwAAAAAACgkQsN6d1ii/Ey+q
Lgf9Gyx0CrFsP2ttcQxYJ1YXlATQw4Mg/gr+nJRyQi+BuWCC9r1bttuUXyd65bQez7Zfc5lIzNh7
u4uV2Gs0oXfwlDjrXCBXdptNlD5wuHrGEFW/8SK2tpZe0UJld6tfb+D8+nfGVxVlMa4gdYDD8bNA
FI+tRkkdXMkJQzXwUc/myAp/GSAhv3zymNQd9qwNiuVMEErqXLX7vQ+vgWGkoWrwgaq5ic+e5xjb
S4+nU6NGzld5MrgRODktjZs8vWnuug3+o43/5MjJeqcEKxdVunXAWz/n8nyZSlh++mcY1Q927E2G
1ysSYlnG9YYX1zzJcS4hT8kSkI5Ii0UY+LR62QdSNw==
=fqF4
-----END PGP SIGNATURE-----

--------------CuI8A3qOkSsiuA9owP7fPD0n--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 07:30:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 07:30:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314477.532543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njc8H-0004b2-1g; Wed, 27 Apr 2022 07:30:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314477.532543; Wed, 27 Apr 2022 07:30:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njc8G-0004av-UN; Wed, 27 Apr 2022 07:30:40 +0000
Received: by outflank-mailman (input) for mailman id 314477;
 Wed, 27 Apr 2022 07:30:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1GEo=VF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njc8F-0004ap-MC
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 07:30:39 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eeef3593-c5fb-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 09:30:38 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 95551210E1;
 Wed, 27 Apr 2022 07:30:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 761D513A39;
 Wed, 27 Apr 2022 07:30:37 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id /wk1Gx3xaGIGKgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 27 Apr 2022 07:30:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eeef3593-c5fb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651044637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=EuzQ5ZDycxlMgDon7eKwQVHn36wPidVeXg9XkRZSS3I=;
	b=ZJ1EqV913xnNeZDmuCCOryX/PFes2jRREr5tCytJN0fmgeZA9N3F7wduY84Qz/4n17M51X
	8POghiRot5NVuC2zpoG66I+Iyc2D+CAgf6uteJ06YVSu7wi2/Ak3sJRTWd7qHNQC0atLoz
	RqyAxCRJho0U5OMm2imeUHEysrm16Gw=
Message-ID: <13c29d5b-a9e4-9690-7988-767caf0c44b5@suse.com>
Date: Wed, 27 Apr 2022 09:30:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [cxenstored] Potential bug in special watch event firing
Content-Language: en-US
To: Raphael Ning <raphning@gmail.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien@xen.org>
References: <eb024e77-17f4-cc89-f621-a9d5b879c184@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <eb024e77-17f4-cc89-f621-a9d5b879c184@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------genfbMfkTj1RyuLeYexr6ky0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------genfbMfkTj1RyuLeYexr6ky0
Content-Type: multipart/mixed; boundary="------------5pry8zVJ7wY5YDtz129AgZBi";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Raphael Ning <raphning@gmail.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien@xen.org>
Message-ID: <13c29d5b-a9e4-9690-7988-767caf0c44b5@suse.com>
Subject: Re: [cxenstored] Potential bug in special watch event firing
References: <eb024e77-17f4-cc89-f621-a9d5b879c184@gmail.com>
In-Reply-To: <eb024e77-17f4-cc89-f621-a9d5b879c184@gmail.com>

--------------5pry8zVJ7wY5YDtz129AgZBi
Content-Type: multipart/mixed; boundary="------------70Bv9OJ3HHY4Wj2AfYKHb03C"

--------------70Bv9OJ3HHY4Wj2AfYKHb03C
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

SGkgUmFwaGFlbCwNCg0KT24gMjYuMDQuMjIgMTk6MDIsIFJhcGhhZWwgTmluZyB3cm90ZToN
Cj4gV2hpbGUgcmVhZGluZyBDIHhlbnN0b3JlZCBjb2RlLCBJIG5vdGljZWQgdGhhdCBpdCBt
YXkgc2VuZCBzcGVjaWFsIGV2ZW50cyBsaWtlIEByZWxlYXNlRG9tYWluIHRvIChwcml2aWxl
Z2VkKSBjbGllbnRzIHRoYXQgb25seSB3YXRjaCB0aGUgcm9vdCBub2RlICgvKS4gVGhhdCdz
IHByb2JhYmx5IG5vdCB0aGUgaW50ZW5kZWQgYmVoYXZpb3VyLg0KPiANCj4gRm9yIGV4YW1w
bGUsIHdoZW4gZmlyaW5nIEByZWxlYXNlRG9tYWluLCBmaXJlX3dhdGNoZXMoKSBpcyBjYWxs
ZWQgd2l0aCBleGFjdCA9PSBmYWxzZToNCj4gDQo+IGh0dHBzOi8vZ2l0aHViLmNvbS94ZW4t
cHJvamVjdC94ZW4vYmxvYi8yNDE5YTE1OWZiOTQzYzI0YTZmMjQzOTYwNGI5ZmRiMTQ3OGZj
ZDA4L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyNMMjM0DQo+IA0KPiBBcyBh
IHJlc3VsdCwgaXQgd2lsbCBjaGVjayB3aGV0aGVyIEByZWxlYXNlRG9tYWluIGlzIGEgY2hp
bGQgb2YgdGhlIHBhdGggYmVpbmcgd2F0Y2hlZDoNCj4gDQo+IGh0dHBzOi8vZ2l0aHViLmNv
bS94ZW4tcHJvamVjdC94ZW4vYmxvYi8yNDE5YTE1OWZiOTQzYzI0YTZmMjQzOTYwNGI5ZmRi
MTQ3OGZjZDA4L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jI0wxOTUNCj4gDQo+
IEFuZCB3aGVuIHRoZSBwYXJlbnQgcGF0aCBpcyAvLCBpc19jaGlsZCgpIHVuY29uZGl0aW9u
YWxseSByZXR1cm5zIHRydWU6DQo+IA0KPiBodHRwczovL2dpdGh1Yi5jb20veGVuLXByb2pl
Y3QveGVuL2Jsb2IvMjQxOWExNTlmYjk0M2MyNGE2ZjI0Mzk2MDRiOWZkYjE0NzhmY2QwOC90
b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYyNMNjYNCj4gDQo+IFRoZSB4ZW5zdG9y
ZSBkb2N1bWVudGF0aW9uIGlzIG5vdCBjbGVhciBhYm91dCB3aGV0aGVyIEA8d3NwZWNpYWw+
IHNob3VsZCBiZSBjb25zaWRlcmVkIGNoaWxkcmVuIG9mIC8uIEJ1dCBJIGZpbmQgaXQgY291
bnRlcmludHVpdGl2ZSB0aGF0IGNsaWVudHMgbWF5IGJlIG5vdGlmaWVkIGFib3V0IGEgc3Bl
Y2lhbCBldmVudCB3aXRob3V0IGV4cGxpY2l0bHkgc3Vic2NyaWJpbmcgdG8gaXQuIElzIGl0
IGEgYnVnPw0KDQpJIGFncmVlIHRoaXMgaXMgYSBidWcuDQoNCg0KSnVlcmdlbg0K
--------------70Bv9OJ3HHY4Wj2AfYKHb03C
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------70Bv9OJ3HHY4Wj2AfYKHb03C--

--------------5pry8zVJ7wY5YDtz129AgZBi--

--------------genfbMfkTj1RyuLeYexr6ky0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJo8R0FAwAAAAAACgkQsN6d1ii/Ey8g
Dwf/fj9XtEQOCB2wm1CuUeMGANTGdY/sSRALpAdn/1R6MWz8ecg2HFdWNpqhwJKaseC6hAq6hUve
wdMXOEmFmKH9XXVWwZ3E+HGnaw18j2e3IBeWNmuaDeLmAN1F1pNknnVRuRvCeeFL7cRaTU+fP7p3
Bkftw98DLG6LHidkPT2ZL0q4gc1si50f23bY9LjICu2x26meuIc4023RSyJTMBiGrSL7D+TsjLQK
BUHg5rSptXCp81jGlYFPP1C2k8ebgWF5o68ZCbsiAwJm/0n2DpGSN8jkGCcZA4KFU0OLbbOjHc+/
56uxQ+bWObeg5FQigqHD82l3EtHxUSgbFE5So/FV6Q==
=8QC0
-----END PGP SIGNATURE-----

--------------genfbMfkTj1RyuLeYexr6ky0--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:04:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:04:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314490.532554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njceX-0008WG-50; Wed, 27 Apr 2022 08:04:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314490.532554; Wed, 27 Apr 2022 08:04:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njceX-0008W9-1u; Wed, 27 Apr 2022 08:04:01 +0000
Received: by outflank-mailman (input) for mailman id 314490;
 Wed, 27 Apr 2022 08:03:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njceV-0008W3-Aa
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:03:59 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 938ea47e-c600-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 10:03:56 +0200 (CEST)
Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 04:03:50 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SJ0PR03MB5455.namprd03.prod.outlook.com (2603:10b6:a03:27b::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 08:03:48 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 08:03:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 938ea47e-c600-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651046636;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=F7NYIhxeUpb0L6PFKMN7AjZE2buHjL9O5cHSPgFflDw=;
  b=JURoCTn4MYMteiwAWcBPbboOh4meMe9uEXGra17sUZA+0V6yoFTFKcnm
   S+I7Orvs3LpI3r87XlWvFzAxki2CmD2FrCmy675yPwlAPLsOEbvWX1GqG
   xtdyVBowR8miIjYZ8xwdniH1kisJc5Wbuvl++bWJF4XnMVbx72p+8BSKB
   o=;
X-IronPort-RemoteIP: 104.47.55.173
X-IronPort-MID: 72474057
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:uAN0P6DWaL9WnxVW/1fiw5YqxClBgxIJ4kV8jS/XYbTApGh21zwOz
 jFNW2/QbveOMGbxcotyaI60oE1QsMXTx4NnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj3NYz6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhSl
 PlLlMeCFD5qEbTBwfshCkBATSBhaPguFL/veRBTsOS15mifKT7G5aUrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t7B8mcGM0m5vcBtNs0rtpJEvvEI
 dIQdBJkbQjaYg0JMVASYH47tLjy2iajK2AHwL6TjfQw6iv55yBM6/vKa+HLQfHXZe9axH/N8
 woq+Ey8WHn2Lue32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXO5q/Skjk+1W/pEN
 lcZvCEpqMAa90G1T9+7QxyxplaFuAIRX5xbFOhS1e2W4q/d4gLcDG5USDdEMYYirJVvGmds0
 UKVldT0AzApqKeSVX+W6raTq3W1JDQRKmgBIyQDSGPp/uXenW36tTqXJv4LLUJ/poed9e3Yq
 9xSkBUDug==
IronPort-HdrOrdr: A9a23:LO7wFKOI03aT4sBcT0j155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5
 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa
 Dsrvau4FGbCAcqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP0f2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aqSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7uvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wM9HdwGOt15Dt
 //Q9VVfYF1P7ErhJ1GdZc8qOuMexrwqEH3QSuvyWqOLtB0B1v977jK3Z4S2MaGPLQ18bpaou
 W1bLofjx9+R37T
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="72474057"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H6Xm5jngDy5P7Pg6daiXUsYWE2lMSSIhsIpe4xXmxyEZ/j4KiaIkne1c/sQsifr+eKZImuNJzeIGpSuNndmXXmOiBwdEw7y9B32KrZd1wL6LXuOuD1yscIp4gL9itE0nEbb5DdWF5t1AkthY8UFol0RaDIeggopoDWCO1W++FoCch+dnR4G0sGP1JVAfpthVJX37TqrQCdiEai0JcPZYhs/CpE8exXLANjjdSoSbpn1YUmFAoMfeMa3Aa5snzuKYhdj1odGDIqmTZIYUdyOk3sU2659e3wr5XHBLEJlDmcOItsTxYZzMqYTGoEwSNJCoRW2IELMtSNS4XI+Drwwkgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x3857EKIiRgMECL1axKYb89+TdkuiPe6fyL1azL8axA=;
 b=CFGxvdA1fhbT0tOH8ZWF6V0kOSFIu3ttBcOD6H5gUAFB0lscHLvShALpgII6gBRDOxJSzNeUKj7fbWBEAJpaQc6Yr/yOAZElKhDqrFKO1fnMHdjT0vLuWb32qOERF16mYim5Ebgn/ZcJaJtsPAW2aAiACOfd1XcN9LV/3axRnPRw3Mo3HgAm6RCW1AH0dVRkw4TUSwHPNhObsC3t+CjbyTgFndrQlVvad0YgMz9FHpZQPmkKTtB4JbygQWL8Xn2gP1n3AjHMTrirFA1AHYvAlhBSN6t3ZFT/t+u2RYc8UMtLCvvp1TXkHoyp+3BmPLdXmLRerqHzRtXJFrDS71wIrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x3857EKIiRgMECL1axKYb89+TdkuiPe6fyL1azL8axA=;
 b=EkhT4nNmltxRX6W1z3ACfZoerVfEiWmQiJ4gjtgPod4o06eMqBQI1RXFF3r84r8JUjCVIY7qmj7Qg9hEQCKeDlo0Ikii4J9jfNSXu3mucR5p4Amucdb4Nq/CHJ6HMWb0OHA/+j1CoeNM5BBG4u4XWeVqlzXowe+/fZY7nTc2hYY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 10:03:43 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Kevin Tian <kevin.tian@intel.com>,
	Edwin Torok <edvin.torok@citrix.com>
Subject: Re: RMRRs and Phantom Functions
Message-ID: <Ymj435hWOcY9BK36@Air-de-Roger>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
X-ClientProxiedBy: LO4P123CA0156.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a9a31a37-eb14-4675-f8f2-08da28247566
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5455:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<SJ0PR03MB545501308C0F458732F416B98FFA9@SJ0PR03MB5455.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5y+XdEQjKD61ZAGgppzbsuKHwznrw0oJ8ZakVLWZKp0VljPA3uKx/k2WSSM9F5Owdie2EE3MrdITI7c7TF/YRjoEom6Z2vJvdD8FAnbxlH5zsJgyKD3xjzG5XeOthQncg68KJDd5brvMSQM0uyDdAfbit+GkRq0jEDB+K/+aCAFdQ7AlRDXcC7OANg9D0UUndKyiOo4RP5NFetRWWXuglBC6OZ3ZKFN+htXrt01OaE2PDsGSB4NtZruH5kozlqjA8dajepBDQj4LbWcIlHNJAIC7t0oN+yo9p9J0zkotD5Gi7I6hvRS135OO7yB0cuF2BJuwm8R6OI1OGKn+ZtNpKNsXKo6U3K0ph6sbr80sFi7X8b+JtFMp6WivrwNSa45E5gCsCpDBFiLbJe2geYBDBfv8MY5XG3iqlnGtpNS7BXnPF5nlGIQn2kxbQj+qZPLV1cjeKiCRVpUu5Fj9FvqDVm/TzOhz7HTzTKvrjpnVjMsWk1938inWhXScS793u89Drud5GKR22Fp5RiYL5Mp+yHoEHMBRUtf9yMZ3+t182798dmynR6kFekuhgzYrDf9rl+Q4fUyG3S7ioHOLQ2Q8Ea2JZdNNPud/RXSj/sZ31BBoDt78zI70TkllA/xvBP2GBpOVBM+i8mOrACxI89WhAw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6666004)(107886003)(5660300002)(82960400001)(6512007)(8936002)(4326008)(66556008)(54906003)(66946007)(26005)(316002)(38100700002)(33716001)(2906002)(86362001)(508600001)(6486002)(8676002)(6862004)(66476007)(9686003)(83380400001)(186003)(3480700007)(6506007)(85182001)(6636002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?emxKemxaMUxuUmxOYnJhRzdJVm1FRDJhR0g3eHlSeTJxK08rTXhCZWF2VWdp?=
 =?utf-8?B?emdSWVNoUEx1QzBxSVEwSFFDNjJJcUVZRXZVS1h0MWoveE91R3J0N2ZjY2lT?=
 =?utf-8?B?aVlUbGVITEJRWkFvcE51NWYxN3FFMFpQaWNpTlMzU2greHZXc3hmUkdTRTFl?=
 =?utf-8?B?RDdZclB4Sk93ZzVycnp1V2hMdGNpTktvdWE5MVUyMGFRRjZzd09uV2ZsSVlH?=
 =?utf-8?B?U2JpRThaaXB5dytDU0Z0dml2WGY2V3dWMnFyMzBDdkNKUjcvNnRLY2xObTFF?=
 =?utf-8?B?cnFXN0Y3UnRkZUdSamdySHBqZlBZdWFSRlpwTWxLLzBNVnhVOCtHb2JMODhn?=
 =?utf-8?B?T1dLT29PUERDRzlNSUFhckZFdmoxYUdyZkVTaDFmazU3LzhhZDlZcmlFSTVR?=
 =?utf-8?B?K0RBcFVhQ1dtRHoyV3FnOFVGVzh4bnpWeW5DL1Z2Mm1xMDdQZlFDb2hRUDdV?=
 =?utf-8?B?ZThqYVdlYUE3QXZLMERzdGpyaWtHZ2QzQ2orSXRWQ1ZHZGlWY3VsYWIxK1Ev?=
 =?utf-8?B?SlE3dEdRTUlBdW9JaVFVYTdEdXZKcmt0VXdMbmZDc3NqeCtSQy9YbUJoQ0lp?=
 =?utf-8?B?K0txMUN4eGhmNy9za2pvSmlqYzVMZ3BvTWNFWGIwajZybFlvVk1EK1lQUDRG?=
 =?utf-8?B?aERacGttMFE0Z1N3QzNvWXBnRGhrV2JHTXJpb3RoZzFkbkk1Q0ZKMElQK3JU?=
 =?utf-8?B?NzUyaFlXcVg3VWoyT1lyblBKZFZ3Z3lzTHFyMU4yK0JSY1o2QTNzbFJwRVRT?=
 =?utf-8?B?bmJQdEZoV0VSdHBHdlNiK1BIV2FWOUJIK1BZZnIwdkR3K1d2ZWd3TkVHdCsr?=
 =?utf-8?B?dkE5RS9ucXdvL2ZWZlhaNXBQcEI2Mis2ZHppMVJsekgxZ3hYcEN1VndTQS92?=
 =?utf-8?B?cUFGV2xQQ2xQOUFsWEx6c2dFZzBXdWtNa3MyS2Q5TzZUbjZsaUlPQk1BU05B?=
 =?utf-8?B?c1VVdUVOU0pOU3pvTkFXcmlCUmlRU0FrNW8xY2VXM1owS2tsd0ZRSVFCOUFr?=
 =?utf-8?B?cHNMZmdPQm5DWXlicyttNWFBcGw0NHJDcXo5U0tlUUQrVVlRZTVReXVRbG1t?=
 =?utf-8?B?QThoZXlFWmRQS3dOSFFzS1VGNTdlU1kyNVgwSGpkRzJpVld3N0pvVXR5REpX?=
 =?utf-8?B?Z1lTYXdqSDZsZHR4TDJ2Z0FjTVlQMVRsMWszQ3ZPQlRnNlRWRG1qMk84Skdm?=
 =?utf-8?B?RjYzZlB5dSs0anlvL2pjRFliSU5kQjdqaU5nb3hraGV2MW44ODhUUmxtcDZt?=
 =?utf-8?B?V0pNLzIrMDVHRktnSjlxTUZUbHpyR2JOTjhNZjVTU1ByQU5yQUUwb1YrbkdZ?=
 =?utf-8?B?Mk5nVlRPVDA2Q29CeTdVN2pZaVhuazRaRmExME8veDlicDlQd3JpbWxuR0l6?=
 =?utf-8?B?dW8zUll4UFA1bmxMRm9FazdHLzR2TlZNL1lTYklLY1R0WFk1Vjc2cWlOS2VK?=
 =?utf-8?B?Z1FJcG1hbUtseG0rYTI4K04xU2hrT0pUVktzNWMwMGJqVTd6NmNWNWtQYmFM?=
 =?utf-8?B?RElNVGZPSDBMM3dLVkQ0cTE4YnhVY1FDeEh3ajN5OFpWUjBwS0hZTU1ESEZw?=
 =?utf-8?B?Z1ZpQ0ZNVVVEODlRYXViRFp0bFVRRHNBallPM0NYMmlHZ3pQRHFtRGZoeURo?=
 =?utf-8?B?NnV5WFduYXZQRy8zckUxRDNjVFVvNWRNMldyb0o4NHhGZFFIbUphcWtaRnJV?=
 =?utf-8?B?a0JVMkM0Z040QUpVNkVOdDRQQVdrY25jODhKcU1qRHFQNkFDY0xrSjJGei81?=
 =?utf-8?B?QW1kWnBXdnRNanlmNk5WRmtMSFFqQ0ZySzZHRzZIRlgycUFaMWNoaUhVN3cz?=
 =?utf-8?B?NFNmRFh6bzEzZ1NXSmwxU2ViZmNQTWYzMUl6MjZWaWlXdmZMZW4rZGlUWWJV?=
 =?utf-8?B?WnFBUklkb0tIWWNMYWQ4L0J5Skw3TzRjTW4zVTZjclg5M0hVNjBuVDRRT3VU?=
 =?utf-8?B?RWhvK2tNclJyWkpWWUMzYjh5cGpUc0JkKy9nSlBRODMzRlVoUy9jSWVNaXRa?=
 =?utf-8?B?aVFlLy9IcDFiSFQ0ZXRZd28vaTNCMEY1cFBQbDlpMENRaDZCenFzTFFBUjlG?=
 =?utf-8?B?cnFib2lSejduczV6aXhaM0RoOG4wSVBieUxWZHJCZXlOeHpwR2VFbGFDWFFo?=
 =?utf-8?B?SkdKeFMrdkhYZERJOWQxQU5wUEc4NWhTaFJmdjJHSXd1bFdRSDJ2ZEJMVlZX?=
 =?utf-8?B?RktKaHlYNFEwcENuT1FWcHB3U05SYjlQRit2WUtPa3VLWWZmeHpCYjJEcnJX?=
 =?utf-8?B?SFY5T0wxRk8xQk0rSmpLaXdUWEI3OHFXTjU1TXdLVkxodmUxSUhwZHhpUnNj?=
 =?utf-8?B?UHVaSVNPRmtheGpJN3pGeHB5bjZmMUttMGVLK1k3Z0doWW1ETU02dz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9a31a37-eb14-4675-f8f2-08da28247566
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 08:03:48.1212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cejawdy0HFwN7B3StxVWINUBnQuoOIkBgCJ3WsjSNZiFdCHLPdww5Ai6bC+80b0XYrh8//PWUOHp/2rUhStT6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5455

On Tue, Apr 26, 2022 at 05:51:32PM +0000, Andrew Cooper wrote:
> Hello,
> 
> Edvin has found a machine with some very weird properties.  It is an HP
> ProLiant BL460c Gen8 with:
> 
>  \-[0000:00]-+-00.0  Intel Corporation Xeon E5/Core i7 DMI2
>              +-01.0-[11]--
>              +-01.1-[02]--
>              +-02.0-[04]--+-00.0  Emulex Corporation OneConnect 10Gb NIC
> (be3)
>              |            +-00.1  Emulex Corporation OneConnect 10Gb NIC
> (be3)
>              |            +-00.2  Emulex Corporation OneConnect 10Gb
> iSCSI Initiator (be3)
>              |            \-00.3  Emulex Corporation OneConnect 10Gb
> iSCSI Initiator (be3)
> 
> yet all 4 other functions on the device periodically hit IOMMU faults
> (~once every 5 mins, so definitely stats).
> 
> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.4] fault addr
> bdf80000
> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.5] fault addr
> bdf80000
> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.6] fault addr
> bdf80000
> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.7] fault addr
> bdf80000
> 
> There are several RMRRs covering the these devices, with:
> 
> (XEN) [VT-D]found ACPI_DMAR_RMRR:
> (XEN) [VT-D] endpoint: 0000:03:00.0
> (XEN) [VT-D] endpoint: 0000:01:00.0
> (XEN) [VT-D] endpoint: 0000:01:00.2
> (XEN) [VT-D] endpoint: 0000:04:00.0
> (XEN) [VT-D] endpoint: 0000:04:00.1
> (XEN) [VT-D] endpoint: 0000:04:00.2
> (XEN) [VT-D] endpoint: 0000:04:00.3
> (XEN) [VT-D]dmar.c:608:   RMRR region: base_addr bdf8f000 end_addr bdf92fff
> 
> being the one relevant to these faults.  I've not manually decoded the
> DMAR table because device paths are horrible to follow but there are at
> least the correct number of endpoints.  The functions all have SR-IOV
> (disabled) and ARI (enabled).  None have any Phantom functions described.

According to the PCIe spec ARI capable devices must not have phantom
functions:

"With every Function in an ARI Device, the Phantom Functions Supported
field must be set to 00b. The remainder of this field description
applies only to non-ARI multi-Function devices."

> Specifying pci-phantom=04:00,1 does appear to work around the faults,
> but it's not right, because functions 1 thru 3 aren't actually phantom.
> 
> Also, I don't see any logic which actually wires up phantom functions
> like this to share RMRRs/IVMDs in IO contexts.  The faults only
> disappear as a side effect of 04:00.0 and 04:00.4 being in dom0, as far
> as I can tell.

I think I'm slightly confused, so those faults only happen when the
devices are assigned to domains different than dom0?

It would seem to me that functions 4 to 7 not being recognized by Xen
should also lead to their context entries not being setup in the dom0
case, and thus the faults should also happen.

> Simply giving the RMRR via rmrr= doesn't work (presumably because of no
> patching actual devices, but there's no warning), but it feels as if it
> ought to.

Xen should likely complain that there's no matching PCI device for the
provided RMRR regions, and so they are effectively ignored.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:09:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:09:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314497.532565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njcjW-0000jj-Oo; Wed, 27 Apr 2022 08:09:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314497.532565; Wed, 27 Apr 2022 08:09:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njcjW-0000jc-Ky; Wed, 27 Apr 2022 08:09:10 +0000
Received: by outflank-mailman (input) for mailman id 314497;
 Wed, 27 Apr 2022 08:09:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njcjU-0000jM-Me; Wed, 27 Apr 2022 08:09:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njcjU-0000EZ-Iv; Wed, 27 Apr 2022 08:09:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njcjT-0006PZ-UQ; Wed, 27 Apr 2022 08:09:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njcjT-000828-Tv; Wed, 27 Apr 2022 08:09:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JGhrjRKKq25U0Rl4wEDjezMpUtGE4IanKbsAJYUwwXg=; b=pfggDgcb4UBoY75HNvozO1UDNe
	hV6IBwhcLnn7AaiGinLzw3Y8QDtDTOfYbna2N32d9RgH3WssmH6KPBXmj8EbcOjG+6EG/gHDQify0
	nGdd+HRpxuGAq8B4GJTpB2SzTDyvz7Auf0aTknUXcTSmcfg7vJadGx44gMzxh2kwlEb0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169756-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169756: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3f5d61466345ed2213de2d7e391b6cd6d4b86015
X-Osstest-Versions-That:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 08:09:07 +0000

flight 169756 xen-unstable real [real]
flight 169771 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169756/
http://logs.test-lab.xenproject.org/osstest/logs/169771/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 169723

Tests which are failing intermittently (not blocking):
 test-amd64-i386-pair     10 xen-install/src_host fail in 169771 pass in 169756
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 169771 pass in 169756
 test-amd64-i386-pair        11 xen-install/dst_host fail pass in 169771-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169723
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169723
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169723
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169723
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169723
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169723
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169723
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169723
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169723
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169723
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169723
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169723
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  3f5d61466345ed2213de2d7e391b6cd6d4b86015
baseline version:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08

Last test of basis   169723  2022-04-26 01:51:45 Z    1 days
Testing same since   169756  2022-04-26 20:07:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         fail    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 3f5d61466345ed2213de2d7e391b6cd6d4b86015
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Apr 26 16:02:21 2022 +0200

    Revert "page_alloc: assert IRQs are enabled in heap alloc/free"
    
    This reverts commit 88a037e2cfe11a723fe420d3585837ab1bdc6f8a, as
    it break booting on Arm.

commit 88a037e2cfe11a723fe420d3585837ab1bdc6f8a
Author: David Vrabel <dvrabel@amazon.co.uk>
Date:   Tue Apr 26 10:33:01 2022 +0200

    page_alloc: assert IRQs are enabled in heap alloc/free
    
    Heap pages can only be safely allocated and freed with interrupts
    enabled as they may require a TLB flush which may send IPIs (on x86).
    
    Normally spinlock debugging would catch calls from the incorrect
    context, but not from stop_machine_run() action functions as these are
    called with spin lock debugging disabled.
    
    Enhance the assertions in alloc_xenheap_pages() and
    alloc_domheap_pages() to check interrupts are enabled. For consistency
    the same asserts are used when freeing heap pages.
    
    As an exception, when only 1 PCPU is online, allocations are permitted
    with interrupts disabled as any TLB flushes would be local only. This
    is necessary during early boot.
    
    Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit c266f974148d3d1b21d01b8bb243017943786444
Author: Daniel P. Smith <dpsmith@apertussolutions.com>
Date:   Tue Apr 26 10:30:31 2022 +0200

    xsm/flask: code style formatting
    
    This is a quick code style cleanup patch for xsm/flask. The files flask_op.c
    and hooks.c are Xen specific, thus full code style rules were applied. The
    remaining files are from Linux and therefore only trailing whitespace was
    remove from those files.
    
    Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jason Andryuk <jandryuk@gmail.com>

commit fa4d84e6dd3c3bfd23a525b75a5483d4ce15adbb
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Apr 26 10:25:54 2022 +0200

    IOMMU: make domctl handler tolerate NULL domain
    
    Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX,
    XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed
    here, when the domctl was passed DOMID_INVALID.
    
    Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...")
    Reported-by: Cheyenne Wills <cheyenne.wills@gmail.com>
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Paul Durrant <paul@xen.org>
    Reviewed-by: Juergen Gross <jgross@suse.com>

commit 9cd7e31b3f584e97a138a770cfb031a91a867936
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Apr 26 10:23:58 2022 +0200

    xen/iommu: cleanup iommu related domctl handling
    
    Today iommu_do_domctl() is being called from arch_do_domctl() in the
    "default:" case of a switch statement. This has led already to crashes
    due to unvalidated parameters.
    
    Fix that by moving the call of iommu_do_domctl() to the main switch
    statement of do_domctl().
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> # Arm
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:13:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:13:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314506.532576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njcnG-0002Cc-De; Wed, 27 Apr 2022 08:13:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314506.532576; Wed, 27 Apr 2022 08:13:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njcnG-0002CV-9s; Wed, 27 Apr 2022 08:13:02 +0000
Received: by outflank-mailman (input) for mailman id 314506;
 Wed, 27 Apr 2022 08:13:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bzB+=VF=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1njcnE-0002CP-JO
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:13:00 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2060d.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::60d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d988b941-c601-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 10:12:59 +0200 (CEST)
Received: from AS9PR06CA0735.eurprd06.prod.outlook.com (2603:10a6:20b:487::20)
 by VI1PR08MB3952.eurprd08.prod.outlook.com (2603:10a6:803:de::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 08:12:55 +0000
Received: from AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:487:cafe::6f) by AS9PR06CA0735.outlook.office365.com
 (2603:10a6:20b:487::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Wed, 27 Apr 2022 08:12:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT062.mail.protection.outlook.com (10.152.17.120) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 08:12:55 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Wed, 27 Apr 2022 08:12:54 +0000
Received: from b202a583f085.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BDEF377D-C5B6-413C-A6D2-C47681B6D1E9.1; 
 Wed, 27 Apr 2022 08:12:48 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b202a583f085.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 08:12:48 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DB7PR08MB3371.eurprd08.prod.outlook.com (2603:10a6:10:4c::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 08:12:47 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 08:12:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d988b941-c601-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=TDG9eJQLD7B2HVr4adVIuOlKU16Z4nIRqeafqwlrp4yxe4fWeAE0Qnjl54h0H4n/ClFfQKNFmWU/Vn+o7AheddgADTL2W3JokuNksWRq53mqiyIWtjyMlsNsAUHZRAvGD/IAj/TyzzzwDLS6ayKdfekiwVYnLRl3DTM03XxQY24HTaYfzXeKN9zwV5kRio74iIrnb2W/+XHTujwWMdlJZ7Rb+pSN38BdCF1XkxfN1SQqUepMQqapHeNoX+IK87TqHBGam02Rz6otsXMoy0hGxJU8/rO3M7K0i6jxMs+lI7fGnqMr7VbUsUuaX1oj5vsz0z4O3FdOCtarflWHXEvKpA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DnDFM0XdNufK2hfUh6YAx6J7z9vdXM9v7Wi7AfxjQ98=;
 b=KfvASQUXcF4INvxBc1KpsbRNe8iF0sqfcfEB78Ap3d4yWsWTyntXKnAJJ/Tw03fd+yS/oang/da81VZNdvbJ6X/Wg0sbcbNeTjhOta+WrFX4zOYLNrnmfSRoP+26YV8Wz+e9ZTxilSHtPjwd9OSR+T4jtEl46jQGcff4uWbVJj6jyOBxTBmau1NWqcpaleHCswwKlPzM3Hv+Jayy9WVWt+6/wlqO33z3n+v8g1Lr586BCI7wS85LbKucvA4FdFCUqeA4Fhm41QoR4IlIuqpeMoSFV2EtZ88cNhtqvCN/4PErKNzc+sMEFdGjXwRq/YiXz5Zjr0pQxzjROk2TI2rzbA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DnDFM0XdNufK2hfUh6YAx6J7z9vdXM9v7Wi7AfxjQ98=;
 b=ik6P/St+osZohU08MlAP7jEs1x0Y2BYShM0PlNV0qd9Cbl9FosZ3A+iqFvB7tKkYM8MtkR5I/1qELP8EP94mrIOMwOxzMpRLSwb9ksJXKSdBhLYVHh6ewlw+fpOB1fA8Pk2hkFeIYJQiw+viuxhitiuvZP6wO8Mjps7ueHPwmFU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: aebccca3d5444551
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OJ3sU7cobiYEQ6y0zZaIuCIB5rOMCinIvfLebmm0rMEBLwfh5pNyT7ds5j77F+lcAzyLonI+6U4jB7zVDuGFBVvmViJi8wPK3hVRv0mYkIN3LDjyNcQ4P5P9G0brmzT91rS2MUGKXZJjDhm3PZRolRWDpEscUVEuLC09Wbr3+sQDEtEf93z6sAsQmEgn8iYh6XiaA3QKc+D1pre9LslTnve09DitCp9awHkDQwjP4BfNcqlG/OsBQ4KncMgonsTKUX/PRfa/aOVQoYEcLMbljAWTLMIca6W4+a+0hBHX3NdjrwAfz/pK2jSHiuGqYKJm6vATL8HU40FC2+j2kPUihw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DnDFM0XdNufK2hfUh6YAx6J7z9vdXM9v7Wi7AfxjQ98=;
 b=Cb4speQYZD8KRYh/43PcDeSCzhF7k7gCg0oBbqSOuQn4ipeyfCJrp0Cmdr0pZo8PROeC5RJqbWcxmn5h/hNHa6tFs2WLiTLtX4+tcOsiHmuO4tJSvHi71tEcrHcAFduatyMOi2k+sjWJV51WBleeLv2sdRsemFUhR8iP3rmxIolXFdVtHslBzha7YorpfCS8edocDsarZassl2ytBSAoG8zYKFzlX0BdcM1MY4omBgvTrBWzr6u6AkrEDE5rvwzEHMyeH/pbfaeZUqe20GdCblVwxEB7Tcy8cgYDDjnbLIecRqHnAV4P+wVU5IA4dwMKI7Ml5l0g4s5O/s5JYBUNkg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DnDFM0XdNufK2hfUh6YAx6J7z9vdXM9v7Wi7AfxjQ98=;
 b=ik6P/St+osZohU08MlAP7jEs1x0Y2BYShM0PlNV0qd9Cbl9FosZ3A+iqFvB7tKkYM8MtkR5I/1qELP8EP94mrIOMwOxzMpRLSwb9ksJXKSdBhLYVHh6ewlw+fpOB1fA8Pk2hkFeIYJQiw+viuxhitiuvZP6wO8Mjps7ueHPwmFU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, Rahul Singh <Rahul.Singh@arm.com>
Subject: Re: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer
Thread-Topic: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer
Thread-Index: AQHYWawa/Ktd+NEW1kSyeaDQHfVyLq0Dac8A
Date: Wed, 27 Apr 2022 08:12:46 +0000
Message-ID: <FBE32543-4BBC-4416-8DE5-364D3C380D0A@arm.com>
References:
 <alpine.DEB.2.22.394.2204261323430.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204261323430.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: bb54c42b-5bf7-4e83-c1a2-08da2825bb8c
x-ms-traffictypediagnostic:
	DB7PR08MB3371:EE_|AM5EUR03FT062:EE_|VI1PR08MB3952:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3952FF817A8296ACD00E4D329DFA9@VI1PR08MB3952.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0rg6lHDrRzYDn+WsmszzkIZ8v3L1OMFGIPIacxKmoRcFxky4QvOJkgh2jLyI1fxTpDMD6YU9u3Kdt6ygb3kQYsMPZAc9J/pmtkAMCx0woAii8ssgZpD6nhgVQKT8NrjwwE2axhJ30SMw+jckZrXQ/Rvbl2EU4MqqYhlUej41F3peHAcyGQY3e3I7/lgpQzbTdmqzFQc8guDVXnME6Yn6VzXCm9Nz6kxkkxG9Z/GjA9lCPcZrblDoNWJco385EMlkufSOCysPl7bPUi2/UGg2vG0be/OfCUSEe2bGMtiHXSfIifRoM34bDiW8AZfR3klQB7CYzz888WswbuoHBOEx0TmqL83HGaistFKJsLX+mEUilSRUjiF5O+FMUMImGJZd6HhKM0NStNgPDeONgAku86BFmsiOW4Bi4Z3IJ0TFDVEUeRSubwdjeb4l9pqAFfAT5G913E0tgrVbSn4T8oJOdSDYTuTjSO1Htev1+4fQd8kRc+aXDn/v/oggj3wDC0DcRvP4WoO+eocMdtyZ7VPjtTmAw0R2sNTHEpXQDHFjkgdOwLGivUuuPXLrqYK+KVVRMWt5hi4Pxi2+6F0WO5qvemp32PimtDQ+Xh9NanYQRAMI+2CpxOahaR2Q60ezJzALhv6bnesGIjQ25xFghVUb8tjCmFrRp1M2L0SYWXb/InSl3LOOuxxzwSBeMd87Gwkm/EoGxYXuwxsH5Viq048S2ggQ1p3IrCstYbvtv/qd+ncUIRTdYgpMo1UQEZS3ID7U
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(6512007)(186003)(2906002)(2616005)(53546011)(6916009)(316002)(86362001)(54906003)(33656002)(36756003)(508600001)(6486002)(91956017)(5660300002)(76116006)(26005)(71200400001)(4326008)(122000001)(4744005)(66946007)(8936002)(38100700002)(38070700005)(66556008)(64756008)(66476007)(8676002)(66446008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B9AF8F93789B8047877423B25BE8EA47@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3371
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e8eef5ec-db05-4c26-5618-08da2825b6ac
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lA2o2/dF51JY1PcOJCN1SKnz3o7z72yMXVQN1m0fH4j4Pjh7Ge8G6uUOeCgclSfXGmdQXjqZ1wjLn7Gnj4pYMlf2RIYzGV89RPL21CtpcFpOlNwAfjBZjH/MkjLmyf/+AjhSgXrSwsQLdx2I9qQ4g707v45ic8xlKBSOFOTE/WUpQ+ja3i6Ue+RfOxtwSg/W+LMddLLWRV1Wt08q1DwH2sQBwplgDA0bSmcIqiVG3N5Bl2K4YAkthfjeqsumUO5FHBsj9cdi/tFhCVMh78ouZkFChZxQ0Ej/6MQK8wddMaZ9D7SuK5Hgue99H8FSHr3jbZpME0OnlWwCWNPX0xMIwyp7IIeP6cj1iVP3i07US48nOe8EpIP5wIB2kFBKnF5RzqPuhEtsxYuanrLSHex3mQIMr6iZ3LHqzEfJvGt1vCaOfbSDxfIlQFCJyzU3oTi3poNrae7mfB3eQp7pWxRoU+CEKJVTLEQqtTLC7ieJ/DDUZcfWDLiHxLtZKtEmuLELF+yahSNStbu0uQOy51aTpjIYF7mZDbtKmJ71qjOHt6om1gMICk7Tf5/FcvPPzPK02m+bPYdiShgmAfw4LU8nLLFeJtiDMXeP/Ga4hfA/0vfszpOetAaCD4jS3v8t/ibMMMSw0keXsBzXceK1k2BZzag8/Uk5pgnwFZwdSR/sR4FQ2jA7To5+4GXk7vZUv8kD
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(82310400005)(2906002)(6486002)(508600001)(4744005)(70206006)(4326008)(6862004)(81166007)(70586007)(8676002)(356005)(40460700003)(86362001)(54906003)(8936002)(5660300002)(36860700001)(316002)(6512007)(26005)(2616005)(36756003)(53546011)(6506007)(186003)(47076005)(33656002)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 08:12:55.1182
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bb54c42b-5bf7-4e83-c1a2-08da2825bb8c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3952

Hi,

> On 26 Apr 2022, at 21:27, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> Add Rahul as ARM SMMU maintainer. Create a new explicit entry for "ARM
> SMMU" also with Julien which is the original contributor of the code and
> continues to maintain it.
>=20

Thanks Rahul to step up to handle this :-)


> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

>=20
>=20
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2a47fafe85..ba0d1c0c1b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -248,6 +248,12 @@ F:	xen/drivers/passthrough/arm/
> F:	xen/include/public/arch-arm/
> F:	xen/include/public/arch-arm.h
>=20
> +ARM SMMU
> +M:	Julien Grall <julien@xen.org>
> +M:	Rahul Singh <rahul.singh@arm.com>
> +S:	Supported
> +F:	xen/drivers/passthrough/arm/smmu.c
> +
> ARM SMMUv3
> M:	Bertrand Marquis <bertrand.marquis@arm.com>
> M:	Rahul Singh <rahul.singh@arm.com>



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:20:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:20:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314513.532590 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njcu9-0003ci-75; Wed, 27 Apr 2022 08:20:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314513.532590; Wed, 27 Apr 2022 08:20:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njcu9-0003cb-40; Wed, 27 Apr 2022 08:20:09 +0000
Received: by outflank-mailman (input) for mailman id 314513;
 Wed, 27 Apr 2022 08:20:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cYrv=VF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1njcu7-0003YD-Qi
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:20:07 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d86bf5eb-c602-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 10:20:06 +0200 (CEST)
Received: by mail-lf1-x12b.google.com with SMTP id x33so1832092lfu.1
 for <xen-devel@lists.xenproject.org>; Wed, 27 Apr 2022 01:20:06 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l21-20020a194955000000b00471f0aea31fsm1730534lfj.39.2022.04.27.01.20.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 27 Apr 2022 01:20:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d86bf5eb-c602-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=dhf1reZJOa45GC0I46wPwCpg+/0wqt7dtK9ioMi1z3s=;
        b=NGx49lM7BRPmlL8qfpvveyxCVdNoxG7Apvew4FdejhMmqSEj4pmpZhTC5h/PAV7INZ
         nPk3MRuwrHuLn1J+7Yxchs81i7gSWnQCSIeWEA5C5HEQIJRVK+yUKDbCwoMoMmeJq06D
         R1pjHA4IhvKaBzolr7/Z6xgKFPQ3APEZUsylqYPjCBMhggWGVdMb5lXBRQzHp3XM0yu9
         wOMX6cIUvl4Kxy3t7ug0lUkQiYcXkv63JVxYBREdmvJS2AAbLX0jCyU9h2WKPRI0asqG
         efOsYwpWAREj2BLBuDeN29NBLdrzXX8HFO8S9qFU9niv9bysNc0s0fE0IZMjxsIHEIpw
         Uzrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=dhf1reZJOa45GC0I46wPwCpg+/0wqt7dtK9ioMi1z3s=;
        b=SbcRwJqjtKFVjaa0aKsiRF2KtAqtjfUbatEpto2x7VkTXRDopd0cKCUM7C7z36T5e2
         QsSpNacTvcsNa1tD2u18gCfnAtrZ0vEFz2cb4a2qBs0PeKuY2NmtVbkqyQ31tMcYFMfH
         LENfx2eHAeqNMEP1xwvz8yfIxnzkHUbm80aeNdkKY8MrfJ6/49McLs1IumjzDY6RUvMv
         b9Mn5s67eD0Y05nJj30tNk3hD8ZCNllhf9KAC8oOCiTqUzjwYiPNkOgfYj5KAIk27WKf
         +EBX4lYtefrIS7V7D9KA2tqY+IGwpB1JvKBmDKSqBwiNsv+BO5sL3TJ3zWwRGbr1WTEY
         C/Eg==
X-Gm-Message-State: AOAM533LxLfqwpxyVHr1ZgrpC6fARQmEpXasGoGY8U4DzC7Kohu3vL34
	CNpevn/KsPTFcKJPMW0KEQM=
X-Google-Smtp-Source: ABdhPJzOYbX5/ai8O4gWVRe2se2gUadbxtiXn6Xt7xDuWkEhH2CdERQFgltLDZHF+SGz1qkrO3yk8A==
X-Received: by 2002:a05:6512:12c3:b0:471:9d1d:3f46 with SMTP id p3-20020a05651212c300b004719d1d3f46mr19332172lfg.155.1651047605857;
        Wed, 27 Apr 2022 01:20:05 -0700 (PDT)
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <YmJ4NLuvA63Irow+@Air-de-Roger>
 <24112cfc-0446-d81e-85f1-ebf9da0afe14@gmail.com>
 <YmaeLc2iwxUPUAvF@Air-de-Roger>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <57bfc576-48d5-9121-a32e-fa00be64d6a9@gmail.com>
Date: Wed, 27 Apr 2022 11:20:04 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YmaeLc2iwxUPUAvF@Air-de-Roger>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 25.04.22 16:12, Roger Pau Monné wrote:


Hello Roger


> On Sat, Apr 23, 2022 at 10:39:14AM +0300, Oleksandr wrote:
>> On 22.04.22 12:41, Roger Pau Monné wrote:
>>
>>
>> Hello Roger
>>
>>> On Fri, Apr 08, 2022 at 09:21:04PM +0300, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> This patch adds basic support for configuring and assisting virtio-mmio
>>>> based virtio-disk backend (emualator) which is intended to run out of
>>>> Qemu and could be run in any domain.
>>>> Although the Virtio block device is quite different from traditional
>>>> Xen PV block device (vbd) from the toolstack's point of view:
>>>>    - as the frontend is virtio-blk which is not a Xenbus driver, nothing
>>>>      written to Xenstore are fetched by the frontend (the vdev is not
>>>>      passed to the frontend)
>>>>    - the ring-ref/event-channel are not used for the backend<->frontend
>>>>      communication, the proposed IPC for Virtio is IOREQ/DM
>>>> it is still a "block device" and ought to be integrated in existing
>>>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
>>>> logic to deal with Virtio devices as well.
>>>>
>>>> For the immediate purpose and an ability to extend that support for
>>>> other use-cases in future (Qemu, virtio-pci, etc) perform the following
>>>> actions:
>>>> - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect
>>>>     that in the configuration
>>>> - Introduce new disk protocol field to libxl_device_disk struct
>>>>     (with LIBXL_DISK_PROTOCOL_XEN and LIBXL_DISK_PROTOCOL_VIRTIO_MMIO
>>>>     types) and reflect that in the configuration (new "protocol" option
>>>>     with "xen" protocol being default value)
>>>> - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
>>>>     one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model
>>>>
>>>> An example of domain configuration for Virtio disk:
>>>> disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, protocol=virtio-mmio']
>>>>
>>>> Nothing has changed for default Xen disk configuration.
>>>>
>>>> Please note, this patch is not enough for virtio-disk to work
>>>> on Xen (Arm), as for every Virtio device (including disk) we need
>>>> to allocate Virtio MMIO params (IRQ and memory region) and pass
>>>> them to the backend, also update Guest device-tree. The subsequent
>>>> patch will add these missing bits. For the current patch,
>>>> the default "irq" and "base" are just written to the Xenstore.
>>>> This is not an ideal splitting, but this way we avoid breaking
>>>> the bisectability.
>>>>
>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>> ---
>>>> Changes RFC -> V1:
>>>>      - no changes
>>>>
>>>> Changes V1 -> V2:
>>>>      - rebase according to the new location of libxl_virtio_disk.c
>>>>
>>>> Changes V2 -> V3:
>>>>      - no changes
>>>>
>>>> Changes V3 -> V4:
>>>>      - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT
>>>>
>>>> Changes V4 -> V5:
>>>>      - split the changes, change the order of the patches
>>>>      - update patch description
>>>>      - don't introduce new "vdisk" configuration option with own parsing logic,
>>>>        re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk
>>>>      - introduce "virtio" flag and document it's usage
>>>>      - add LIBXL_HAVE_DEVICE_DISK_VIRTIO
>>>>      - update libxlu_disk_l.[ch]
>>>>      - drop num_disks variable/MAX_VIRTIO_DISKS
>>>>      - drop Wei's T-b
>>>>
>>>> Changes V5 -> V6:
>>>>      - rebase on current staging
>>>>      - use "%"PRIu64 instead of %lu for disk->base in device_disk_add()
>>>>      - update *.gen.go files
>>>>
>>>> Changes V6 -> V7:
>>>>      - rebase on current staging
>>>>      - update *.gen.go files and libxlu_disk_l.[ch] files
>>>>      - update patch description
>>>>      - rework significantly to support more flexible configuration
>>>>        and have more generic basic implementation for being able to extend
>>>>        that for other use-cases (virtio-pci, qemu, etc).
>>>> ---
>>>>    docs/man/xl-disk-configuration.5.pod.in   |  37 +-
>>>>    tools/golang/xenlight/helpers.gen.go      |   6 +
>>>>    tools/golang/xenlight/types.gen.go        |  11 +
>>>>    tools/include/libxl.h                     |   6 +
>>>>    tools/libs/light/libxl_device.c           |  57 +-
>>>>    tools/libs/light/libxl_disk.c             | 111 +++-
>>>>    tools/libs/light/libxl_internal.h         |   1 +
>>>>    tools/libs/light/libxl_types.idl          |  10 +
>>>>    tools/libs/light/libxl_types_internal.idl |   1 +
>>>>    tools/libs/light/libxl_utils.c            |   2 +
>>>>    tools/libs/util/libxlu_disk_l.c           | 952 +++++++++++++++---------------
>>>>    tools/libs/util/libxlu_disk_l.h           |   2 +-
>>>>    tools/libs/util/libxlu_disk_l.l           |   9 +
>>>>    tools/xl/xl_block.c                       |  11 +
>>>>    14 files changed, 736 insertions(+), 480 deletions(-)
>>>>
>>>> diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in
>>>> index 71d0e86..36c851f 100644
>>>> --- a/docs/man/xl-disk-configuration.5.pod.in
>>>> +++ b/docs/man/xl-disk-configuration.5.pod.in
>>>> @@ -232,7 +232,7 @@ Specifies the backend implementation to use
>>>>    =item Supported values
>>>> -phy, qdisk
>>>> +phy, qdisk, other
>>>>    =item Mandatory
>>>> @@ -244,11 +244,13 @@ Automatically determine which backend to use.
>>>>    =back
>>>> -This does not affect the guest's view of the device.  It controls
>>>> -which software implementation of the Xen backend driver is used.
>>>> +It controls which software implementation of the backend driver is used.
>>>> +Depending on the "protocol" option this may affect the guest's view
>>>> +of the device.
>>>>    Not all backend drivers support all combinations of other options.
>>>> -For example, "phy" does not support formats other than "raw".
>>>> +For example, "phy" and "other" do not support formats other than "raw" and
>>>> +"other" does not support protocols other than "virtio-mmio".
>>>>    Normally this option should not be specified, in which case libxl will
>>>>    automatically determine the most suitable backend.
>>>> @@ -344,8 +346,35 @@ can be used to disable "hole punching" for file based backends which
>>>>    were intentionally created non-sparse to avoid fragmentation of the
>>>>    file.
>>>> +=item B<protocol>=I<PROTOCOL>
>>>> +
>>>> +=over 4
>>>> +
>>>> +=item Description
>>>> +
>>>> +Specifies the communication protocol to use for the chosen "backendtype" option
>>>> +
>>>> +=item Supported values
>>>> +
>>>> +xen, virtio-mmio
>>>   From a user PoV, I think it would be better to just select xen or
>>> virtio here, but not the underlying configuration mechanism used to
>>> expose the devices to the guest.
>> I got your point.
>>
>>
>>
>>> We would likely need to add a different option to select mmio or pci
>>> then, but that should be set by default based on architecture/guest
>>> type.  For example on x86 it should default to pci, while on Arm I
>>> guess it will depend on whether the guest has PCI or not?
>>>
>>> In any case, I think we should offer an option that's selecting
>>> between xen or virtio protocol, and the way to expose the
>>> configuration of the device shouldn't need to be explicitly selected
>>> by the user.
>>
>> ok, for now I will use "xen and virtio" values for the "protocol" option,
>> then internally toolstack will assume that "virtio" really means
>> "virtio-mmio".
>>
>> When there is a need to expand that support to "virtio-pci", we will see how
>> to deal with it from the configuration PoV, probably like you suggested
>> above by adding another option (e.g. "transport") with default values based
>> on the architecture/guest type.
> I think this likely also wants to be a separate field in libxl_device_disk,
> which could be left empty and libxl will attempt to set a default.
> For example have the following in libxl_types.idl:
>
> libxl_device_protocol = Enumeration("device_protocol", [
>      (0, "UNKNOWN"),
>      (1, "XEN"),
>      (2, "VIRTIO"),
>      ])
>
> libxl_device_configuration = Enumeration("device_configuration", [
>      (0, "UNKNOWN"),
>      (1, "XENBUS"),
>      (2, "MMIO"),
>      ])
>
> libxl_device_disk = Struct("device_disk", [
>      ("protocol", libxl_device_protocol),
>      ("configuration", libxl_device_configuration),
>      ])
>
> I don't like libxl_device_configuration much, I think is too generic,
> but I can't think of anything better.  Maybe others can provide better
> names.


Here [1] we had a discussion regarding user configuration options. 
"protocol" cannot be used as it will lead to the confusion (at least 
with Xen PV block device which already has "protocol" frontend's entry 
in Xenstore).

Preliminary, we had agreed on the following names:
1. specification: xen or virtio
2. transport: mmio or pci

Please tell me, are you OK with them?


[1] 
https://lore.kernel.org/xen-devel/e657458d-d33e-a340-d9fe-152ec97eefec@suse.com/


>
> Thanks, Roger.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:23:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:23:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314519.532601 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njcxY-0004G9-NT; Wed, 27 Apr 2022 08:23:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314519.532601; Wed, 27 Apr 2022 08:23:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njcxY-0004G2-K3; Wed, 27 Apr 2022 08:23:40 +0000
Received: by outflank-mailman (input) for mailman id 314519;
 Wed, 27 Apr 2022 08:23:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njcxX-0004Fw-Ro
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:23:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 56be714d-c603-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 10:23:38 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-9ig4BNOlM_i6x3xx6bEYuQ-1; Wed, 27 Apr 2022 10:23:36 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB7816.eurprd04.prod.outlook.com (2603:10a6:20b:2a3::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 08:23:34 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 08:23:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56be714d-c603-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651047818;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IL3Fx0qFFzIpeqVv/DoVmusloahGUNLdrxYU5jQBYJs=;
	b=NWkM2sUHRFciuatMXqDASbdV5oL0omGag8QZ1LwZqzeWj8vp9UDQVosvFelAS6hXuR7sSW
	Xpg/hXHudQQz9xRED3kRcIl//MK89VGEuq3OmybmQKalo/8Iia1Qic4Dyru83ze/YpgFAF
	A2Vjnh6pGQrKMAjDE+/bTipsnStzh7Q=
X-MC-Unique: 9ig4BNOlM_i6x3xx6bEYuQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gfTBvPc6IuMk6yye55zpD4kBWoBpTUDellm/Ivj8Ab6+MRkzMOoCUZI/fSF4d8ayCTDPg9ZmDBeuRsYvgKzcpaahtNwey3GnM/WV4Ei9k0fvU8o7aJU9Gm6+8FMhjdHq/yrYuvemx/T/+F4AsSPhZIF1W6IH+Paywkakj0EKhHY9tBLJb31xb5g846skxm/9J59BBCs9DOSmlcTRu9BZFpEvBwdCfmVQ08u975fPuHLP++pLrn6UHiJh4X+mWh+C7bI/8jY6DS5UuZGxrI+hUqw048wix5Pagxh8B61StsfV8HTJSCtsGQlMG3QIJrRRR9rLp6anAQj/y1VeJcv7Uw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IL3Fx0qFFzIpeqVv/DoVmusloahGUNLdrxYU5jQBYJs=;
 b=bPGf/cJ8PwgmSKOsYOEJfnYaSnqFnBHIk8z+VE3FFuUI2XxdaMfwVkRcVIc4fV2nMDO78skgvGz7gNwsMp+fg53ProqXJSBnb3M4CYAuuY3YTFHSpqyYdksEotpdCfSD/6WiQ5Z8xDhSaXDX6twyK3ewaShFG12HzG2FPajayPauCIikAI3OFasmppUkgYViS6mKpro+pKEMGMfYBdapfdo3l7KeOFPOQSYth+cuPoRGM3tCOKe/iMXbcMZIjJeaQINz6vPaCofbdRYPcJXBzbrhiyqMa6jvcM2GJy2Kigjj3AteBajYxVw7Oo/Qm7++0hRbJja4VKBCOYHnkywKEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5ccd53e7-d651-434a-ad05-72cdf468127e@suse.com>
Date: Wed, 27 Apr 2022 10:23:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <Yl7WHv6+M+eJwQep@itl-email> <Yl7X3mAJhR5ENSpl@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yl7X3mAJhR5ENSpl@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0389.eurprd06.prod.outlook.com
 (2603:10a6:20b:460::7) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ae190da5-d835-4be3-4555-08da28273840
X-MS-TrafficTypeDiagnostic: AS8PR04MB7816:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB78164564216D3856A98D3E77B3FA9@AS8PR04MB7816.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vppckT2/dfQ8r/Mr4KdGSgwRKZ+ZolFWHf4az52VBl1a6sZVr6pslYjHBzU2D5MGFWuzEkND6mXik8ECgpUXY/SaEmW6YYBmOXA7S5Vie5HMIJPXy5EHcsTcALDwr+BX3tjvlvNoL/oUmrShuQt2wj0dApnIu/zhQRP1LIuIag5j7bECfZpRpOJhgrQkzs8cpdbjyeIFgwyWcMQCkZgDK/0fil+HaTe4CsE02lUa2X5dqb34RHswagjZJxMbqZmp2M1j4eSp5H7xSxEhnuZm/bca056rJEKx2Eo6OhUD7a4A8JcoWPbWgbFsuN1qy7OQf3d0XBebGXXJklQAidYVejxmR+IT3uB7MMOonJzxJX54uPTWFaqug6NDs6SILJwpvWvPHh05SWRQrKvxSeTImlKBVJ+fyjuURtKc1t4Kc7hL4F8J7azTWzvCEuYyv9M+h/z4qN+JRM5aJPNG7tRtgeCDEOHvx0/wgaIFJclUl8931Nk0syWHcPYGVMdB+sGh4lfH2XZU1i6ZMKWJGEXY6xS6QvsYeJV0pdulwGENfANeTpkalqy4lAZJ8/fxeNEqaLo3R+Ff5sY2yXrdIzBPJCNWjABG3R/phqUaLkren8Ej6UGe2YtCf/y36NxjlLspr2nEIzq2KEwjR6sFL42pHaiH69JFsRbWG/nXFqgya3y0SS0YdBMjctbdvvj4wkeTJEzq31uLcFkuKar9B9uacipBotxqXO352kxPIWFEOwo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(54906003)(66476007)(31696002)(2906002)(38100700002)(31686004)(4326008)(316002)(66556008)(86362001)(53546011)(6916009)(8676002)(66946007)(6486002)(83380400001)(26005)(186003)(508600001)(36756003)(2616005)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TzhDVlhzL3BXY0pzTW1FbXhkazJxN0txNE9NVHlsVUYxcnYzRk5RYnRKcm8v?=
 =?utf-8?B?TzNZWWFYRkxRK0RYYXZsaHNMM3NYVTFtbmFKczRyYXJDS1E5R3ZiQlBZSlkv?=
 =?utf-8?B?NUtteU9SQXFCSW5aWm1BLzNPcU9FMVBSaXVsb3JsNjI4b3B5UTFkWGMyME43?=
 =?utf-8?B?UitDUTcxUkdXYWl4Z29tN1huVGRDUG43RUN5cktEeEJMYndNYlFVa1FYUFMx?=
 =?utf-8?B?SkpVK09IRUNqblNnRGYyMDlWY3l4RjRkN3lINEtGMWI1dncxT3pHalZYVXQv?=
 =?utf-8?B?S21GeFI4OHA4bm84RlU4aUFGdmN3dElpMDN5TVZHQi8zbkd2c2E1VUxndzZP?=
 =?utf-8?B?TWNhRzB5WTZ5eFd0SGxScWlNNDJhcENUODR1aVhnVkJLVTNZdHpySWtvckJt?=
 =?utf-8?B?SWxaTjRHVUZHS1BkTEgxbEN3dVRkOHlrcWV6aW01Z1QwZ25TWlF3dXFYZWtM?=
 =?utf-8?B?RWpYbGJRbWV1RzBJNDdrRTUyNVNDYzZaWEUxcUdTT3lESXF3bTdwUFk1dWxT?=
 =?utf-8?B?U2ZXcTdhWnNUK29DZG9aUUMwZFk3bTdHQUF3akJNdk1lb0FCOW5LbkxySjYx?=
 =?utf-8?B?RDVRNFhxVGVJbUNBOWk2UXpyR1g5WFRGWmZoMDJ2UjFtcmxtbm16NWozc3Rl?=
 =?utf-8?B?YkR6d0ltUStBRTFNeEhnY1VOVzFwT21BUHRiWkF4ci96OVY1NnMzY1N6aHJa?=
 =?utf-8?B?aDkxY0IrbFhJWVRJOEJya20yTHhIR2pHOFZmSEhjLzRwOU9rdEtNeE92MXZN?=
 =?utf-8?B?LzBZUWVPYXo3NFo3YkZYYVorTFprRGFleTc4eDNGT1B1R0p0UmJOeVoxc0ND?=
 =?utf-8?B?OTdPZ2VCTTdZZUc3Nk1tRW9KQTdtN3FQWDd6VVpueVhWa0dNdTBKQks0R2da?=
 =?utf-8?B?Wi9tb3VwczhXbDlqTEZvKzRZRlhPTXJNQjRwdzRNQmRKWlhZemcvak1KbzNT?=
 =?utf-8?B?ZkhSS0NTeVJMdDlpNlN0dzViYTlPNWFpcStibnV5SllZZW1UbjV3VTVLRzFB?=
 =?utf-8?B?SUZmckdqZEFsaVJrVFZ0dkRhM1p3b0hJRWkvd1VrWnNmdENWK0k0dG84RlBX?=
 =?utf-8?B?eDZ6aGkzdUZsRVFlWldYdEtKcDN5d2F1TVh6R0JUd1N6MnhHTXRVZVpDVHlE?=
 =?utf-8?B?WlFvYVNiR3VBMXJnemo2eHZONUc2UFA2MEZHYy9YZm0vcFBDTVRzN1FzZmNC?=
 =?utf-8?B?cDI4TUY1eDMvY2lJSnhxMFZXSER1bnZ1U3NQSW1ZellyVUl2cS9Pc3JRVFRU?=
 =?utf-8?B?ZjZHVXl1YU1wRFpIREpHcTkvbHo4d1l2Y2xHTmtaRzFVVzFKblZOazZON1lR?=
 =?utf-8?B?bTlUMFZCM1dKaVp5MEpYSGxZM0RSQ042a2VnNFJoRkRpWWMzTUsxQ1NKbHBw?=
 =?utf-8?B?NFhSVVBPTWxOcTloaDZvUWdsZ1RPQTVTZGw2NGJoSTE3SmFzSWQ3MitGTUtZ?=
 =?utf-8?B?cHNmZCtHbVU1alJxcmV5RWFBUlFqdnFGaVU0blhvczBqOWhRdlVxcTU3STdz?=
 =?utf-8?B?YTQ5MjE1MklHQ2hCbnBOeGRSbVZVOEY2RVNVM3h6anFaQkQzcEcxUmRkY21s?=
 =?utf-8?B?UExSQ21PdHJCcnMyaVNzY2pYU1RKY1hrRXM0cndERktSeWFDQ0k2SDkxNS81?=
 =?utf-8?B?RCtFdTU3ZkRFYUNsMXNiTGxGSWVHT21aaFpjVkVzTkZ2UThiRnZFZ0lEeDZ1?=
 =?utf-8?B?MzhiM0dCTzIvRWY3REd6UDM5bWtOVzZtS3N6MitUL1BCY2VVZ2J3WEk2Lyth?=
 =?utf-8?B?dG9WeWsxbjRIK3QwaGlPeTNKSm85NldZTHR3TDJaSEdwbVk4YUlwNDNBcDdn?=
 =?utf-8?B?THFFYjI1bW83Vk9nNktvTUY1Y0U4UEhpNU15WWxTTHcxOTFKNWV0VnpJWXF3?=
 =?utf-8?B?MERvYU1EVjdrelk1dTJyUVdCUWk3ZHJ3Sy9SS2wrM21TMnBUbXBWY20zRDF4?=
 =?utf-8?B?VDJ1T3FTdWI3UXczWFhqMWI4Q2pkOGQzT0xUK0dNbnQ5YnVpcUdtZnd2M1dn?=
 =?utf-8?B?cDdYdXVKQmhzWEVONDAwSjd1T2phdDNNMVZwMlJ6bjlwSHVVak94VHVmWHJL?=
 =?utf-8?B?eFFjeHU3dlV2MzBIMXg5K3FRclRsdWZOUGNSSGNOV3FocXNENlRUSXZXVkFn?=
 =?utf-8?B?WUdhMXV6YUhDS3pEUXIvMjNQUkZBeXl6MEdhM0dqVEFEckRyc3BsUlM0VGNY?=
 =?utf-8?B?aFJjb0tSMExoNTI2WVpXS1UwUmVNN0dLaFJFb3RmOWpmeTJDazBXT3hLV2RI?=
 =?utf-8?B?SVEvZzU1Y3VSa0o0V2FnK0dVdHQ3WGZWcVBzSU1mMFRxK0dXaUNFM3k3K3ps?=
 =?utf-8?B?alczdUN5TThBUEdEQ0h2T1o5RTBrbVgxUVVhYlpiQUpqdEZqTi9Sdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae190da5-d835-4be3-4555-08da28273840
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 08:23:34.0180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a3B2zkbhMeXvjizAj8aHUNUWPtSiya16wdTkvA5c8YDm3hgAagWCs7YXXmDRzSmJJxo++yBjgT7wfaPZRDVOGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7816

On 19.04.2022 17:40, Demi Marie Obenour wrote:
> --- a/xen/arch/x86/efi/efi-boot.h
> +++ b/xen/arch/x86/efi/efi-boot.h
> @@ -171,7 +171,7 @@ static void __init efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable,
>          {
>          case EfiBootServicesCode:
>          case EfiBootServicesData:
> -            if ( map_bs )
> +            if ( map_bs || desc == (EFI_MEMORY_DESCRIPTOR *)esrt_desc )

No need for the cast afaics, even more so that it casts away const-ness.

> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -567,6 +567,38 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image)
>  }
>  #endif
>  
> +static UINTN __initdata esrt = EFI_INVALID_TABLE_ADDR;
> +
> +static bool __init is_esrt_valid(
> +    const EFI_MEMORY_DESCRIPTOR *const desc)

As indicated elsewhere before, while we want to have const on pointed-to
types whenever possible, the 2nd const here is unusual in our code base
and hence would imo better be omitted.

> @@ -1056,19 +1091,19 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste
>      EFI_STATUS status;
>      UINTN info_size = 0, map_key;
>      bool retry;
> -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
>      unsigned int i;
> -#endif
>  
>      efi_bs->GetMemoryMap(&info_size, NULL, &map_key,
>                           &efi_mdesc_size, &mdesc_ver);
> -    info_size += 8 * efi_mdesc_size;
> +    info_size += 8 * (efi_mdesc_size + 1);

What is this needed for? Does this perhaps belong into a later patch?

> --- a/xen/common/efi/efi.h
> +++ b/xen/common/efi/efi.h
> @@ -10,6 +10,23 @@
>  #include <xen/spinlock.h>
>  #include <asm/page.h>
>  
> +typedef struct _ESRT_ENTRY {
> +    EFI_GUID FwClass;
> +    UINT32 FwType;
> +    UINT32 FwVersion;
> +    UINT32 FwLowestSupportedVersion;
> +    UINT32 FwCapsuleFlags;
> +    UINT32 FwLastAttemptVersion;
> +    UINT32 FwLastAttemptStatus;
> +} ESRT_ENTRY;
> +
> +typedef struct _ESRT {
> +    UINT32 Count;
> +    UINT32 Max;
> +    UINT64 Version;
> +    ESRT_ENTRY Entries[];
> +} ESRT;

The names in the spec, which (as said before) we're trying to follow along
with the gnu-efi package, where we would generally be taking things from,
are EFI_SYSTEM_RESOURCE_ENTRY and EFI_SYSTEM_RESOURCE_TABLE. The field
names of the former also don't all start with "Fw". The field names of the
latter are still quite far off of what the spec says.

Also, why did you move this here? There's no need to expose things in a
header which are used by a single CU.

> @@ -269,7 +270,7 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info *info)
>      case XEN_FW_EFI_MEM_INFO:
>          for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size )
>          {
> -            EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i;
> +            const EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i;

While I don't mind this change, it also looks unrelated. Perhaps again
needed by (and then supposed to be in) a later patch?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:26:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:26:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314526.532612 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njd0V-0004xG-9X; Wed, 27 Apr 2022 08:26:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314526.532612; Wed, 27 Apr 2022 08:26:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njd0V-0004x9-5W; Wed, 27 Apr 2022 08:26:43 +0000
Received: by outflank-mailman (input) for mailman id 314526;
 Wed, 27 Apr 2022 08:26:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sRcl=VF=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1njd0T-0004x3-L9
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:26:41 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20602.outbound.protection.outlook.com
 [2a01:111:f400:7d00::602])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c320af4b-c603-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 10:26:40 +0200 (CEST)
Received: from AS8PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:20b:310::16)
 by AM6PR08MB4200.eurprd08.prod.outlook.com (2603:10a6:20b:a8::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 27 Apr
 2022 08:26:35 +0000
Received: from AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:310:cafe::94) by AS8PR04CA0011.outlook.office365.com
 (2603:10a6:20b:310::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend
 Transport; Wed, 27 Apr 2022 08:26:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT050.mail.protection.outlook.com (10.152.17.47) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 08:26:35 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Wed, 27 Apr 2022 08:26:35 +0000
Received: from b551cff8048e.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7F300C4D-A513-4E5D-B6A9-A0463826C3D5.1; 
 Wed, 27 Apr 2022 08:26:28 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b551cff8048e.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 08:26:28 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by VE1PR08MB4862.eurprd08.prod.outlook.com
 (2603:10a6:802:a7::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.18; Wed, 27 Apr
 2022 08:26:26 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 08:26:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c320af4b-c603-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=nOG8ZkJzTBfe+DpCrAtOewt19xnQkDKUIjKI7UOSViIznQ/h/i6+XuvcuD32gtKzucDCcvTddNgqUei7S81axhjwIOgkgr0US0kWXa2zHcc5wrg3Ojac8wO42eHYjbBcjS1GoQMTrUmWH5hPmLiH2+V28QL6UQSDNNGnd+sbnRd2yJlXCclmgEfHPxM9vqYsvmYJ1/hGmKuxvO1NkVMxMjq+s4nHT1ZU41nW6tPwqphMjtjHDXvYdIYV69cyTTHZY+QIYq+pKxtWNzZtrb0RKDSzlt1yEjcu6m7IIQPCX5w4w6+dLFlSMhnofAqy3a2vGmgd1SQ6bbnLj/zHQnCjAg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZZoGGGbvoZpPaT6ShyhCcIsyOKXVQV2pCxi7zchFQSA=;
 b=ImKwFXazi1njxJXa2Jc+svciC7790lKYw0aCUE36Sy/QreViMpxNciB0x5c9g5EQRgYtRoYqlIbFxcrnW0bAGQ0DCYjjo6WLxpum2GCx7KFekOf3wWW6OLSOzrv4JysMZRa6zhwjusF5IcXeXfJrlUU6M6ASzoVxCVLiHGvZI5saOuieneqEA1sMNnGc2u4a2LRTj171WOLESFjJguexdsM1fTP8iHjCx21aizT0sNuAxCO2ZYx9XRSArP0PI0tn9F9j7v8idbYq0yGmHxkZ3pI35iPpyqU5Yz4aXttiLeoXJf5hukyIQwBB2Ybjr0lZ7b4iE6YbGb1V/vK4n5fsOQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZZoGGGbvoZpPaT6ShyhCcIsyOKXVQV2pCxi7zchFQSA=;
 b=Wqydk2Ge5TXQ3fvl15bjfZPjcWk2l9Q/7v0wH/DGJLGVKJr8V2bO0JwQhGSkEex8VA4Jailc0Mus67kLqfPZK9Aih0796RlKRyCB3g1WuNVFSzyR1d1eb19dtG4uF5COZqbelNCnbF05DeN8L9gxGrz68ho5S4Usic4bgPjDdW4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fffc2d48008eb437
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VAaQJ8SzNnn+MQg5wMCS5D2AldZ8JwMMwcqba29WeU4Ak0tuxYqlIaWRwbos8a8BrZHGHUryAF7rtMiiy2IwvVJP7zD7cEoxYXBmQ6A2Gixhhd/dEDSE8s3TcO5pnvl8MH/Cd3inP0Xclre8TRwT1N8PXWfgvRgvcCqUIduhFGtjBKez0Ua0lZqzdPro8kxKmtAQWfXJtSQCIEJ/Q9WFnOYALKbC79boL6OvJuM+lqyf7gj0Lk2wstwdcpXr9M4kK1H0iQj+SohUv0PhWHhxq20BjBVTMODPba/c2cSg3SyEh0KCV6Xvprs4KozJcoehHphn1BQNwN8YVj4wk51IAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZZoGGGbvoZpPaT6ShyhCcIsyOKXVQV2pCxi7zchFQSA=;
 b=fdm9Gv6bRYXd6an+UXUTmE8/kLeW9fvvcXcFOtEcTKsIMgnIer3QZRO7fJjG8+C3RbQol409jbttqFcUBx/QyQRLIiPrvmoSI/9BOCWHLbaPmhigCxWYRixrTYcBr9h915x+vxreOPtFYfRijpGcsOA9eLjDPelJOgVLvwfq6BfPuH5B3sL8B8tb/HSIY84PkhIvi7lTKOcesECUBqrEU8rjtMlQ8Ao26jJjssaPTfgsrJXI5zhJsjhXCGmZKyIFFqnraaUuowBJihRFjo+O64Mns9PHSh15yv3sV1kBreufVHZy82QSGlao76++YuyIING6hK6Pv+H9n3/CSmHQAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZZoGGGbvoZpPaT6ShyhCcIsyOKXVQV2pCxi7zchFQSA=;
 b=Wqydk2Ge5TXQ3fvl15bjfZPjcWk2l9Q/7v0wH/DGJLGVKJr8V2bO0JwQhGSkEex8VA4Jailc0Mus67kLqfPZK9Aih0796RlKRyCB3g1WuNVFSzyR1d1eb19dtG4uF5COZqbelNCnbF05DeN8L9gxGrz68ho5S4Usic4bgPjDdW4=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, "julien@xen.org"
	<julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: Re: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer
Thread-Topic: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer
Thread-Index: AQHYWawa4PHvuVIG8kueApmZ9/tXlq0DbaAA
Date: Wed, 27 Apr 2022 08:26:26 +0000
Message-ID: <E1C5D40A-C070-4CEE-976D-3514B40898CC@arm.com>
References:
 <alpine.DEB.2.22.394.2204261323430.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204261323430.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: f07a68bc-5862-455c-b008-08da2827a49e
x-ms-traffictypediagnostic:
	VE1PR08MB4862:EE_|AM5EUR03FT050:EE_|AM6PR08MB4200:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB42006C65A33D459462A6F4EFFCFA9@AM6PR08MB4200.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 eXvSGl8PpFyVsgu7JgQ8nfa2PrxWIrAEDkRUDJpinzODvT0v0B1JWjbFly9GPnUybNQtUmEYMSrStp+DQwz0lI92jsGuh/EFFcE9Od5pnAm6+e8iAEuJEVSSJhli69RHqiTOIJa311+84Z7qQ0rQUW1OGZGeBfHnGncrDUclToHnVNPO1izBJ/cX8Jm4hdWDd2xInEj7hcmMyhZsCU3qgXEiDE8jkwnySGChbsJ+QBduirm6Z0WVBZILPebavB5Kwz4yDFofS6KOFnXI0EdONFQE9M9Vl9d3eNCJ7OijPwlYwwRk9CrCTNZJqvlwEtjtvshobx1vxn/VSn+qCLtmacMeAXuEPiMv4/SM03dNn2HgYIcKX/wN/F8KogovXHh1uZLMGn5kVrN+FYYefyw3nl3prXa2O40ZrrX4KAyLOlS7BmJv1ms0YbRRL4KWwGFCJivmpNqo/7FN0b/f0VdsS6w7kydB+YSrCtDtWgy10eVZc9Lykwb9tnXNps1mtobqCYKzJKg7XYeSrDkGIwxGD/t27l1yaVz7sN5GiAdkYY39/f40UmPNEpI2SjhlXqbAr96MlisnZtMXOKeoqFS+vFb7cdWewZ1mf203b5AJDkzm3nxU5W6aQb+zCPGAoeBkEt2odFbfoA+adsD1iucB/vkgNHr9Ygx5Vx6gJdOYAe5qIorGfZ1W/qr4OteBNwSqjvtYNCjpR7SGWVVuS3ZAvDV4DeRTg1iNCzkVv1q2p0rYyj53DH83KqbYpEs71S3s
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(38100700002)(38070700005)(122000001)(316002)(53546011)(71200400001)(6506007)(6512007)(26005)(54906003)(508600001)(6916009)(186003)(6486002)(8936002)(2906002)(4744005)(2616005)(91956017)(4326008)(66946007)(66476007)(8676002)(66556008)(36756003)(66446008)(64756008)(76116006)(86362001)(33656002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <48EA5F4E356815419DA2436058D290BA@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4862
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5bbce26c-9b55-4252-fbdc-08da28279f3c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FJqiby5W6AJtGcISMQYjb/LygVVu9KYYPnLEdwX7kQqBHttK5XVRIljN07Qtg7RkgRIXmcjUokxeFYZif6RIeeYAIcW5j9EhJYE8avfmhrWJ/nUhBHIeJ2EYIHj/mMo+MrvRrdg44rK2MA1G5arqIWY98yNuwPFnWhte04OXaJimsEFiBu5blOpicRctwiiO3AmxIbgaXcj114C4cZUxcsuFTMzO7oBQEfat97JIVs9fLkwIWlXf1iTf6OXwMFEYiSu8YXxqsrv5EwGxRCmuz6f+sOm1sH7bhJ2y8Uzehy38VU2VtwLyuPh5Jw+XErHClIVyUSbD5jx8QMwhHRoYuU8qTvJKdFknieQG7vA5oq5LOYPTT0n9UqBZi6Ld1vQXaA1IQtzHl4t/TKBf977looDQ27YzkS0Wt5EV0J6u70iHbCsT6YOCIsO86I4AQhdFy+9YrVqB7vhmMyjPw155vv/QLvFe2OYeAqt2ydsVb1p4hgCw6UWT8vEGb4nhq1i2iwYYZSo11JEmHlcjZecGKZy0MMiYvzTuZgIbmOjeFWRbhDHW9qQzKfxM7IzEjwl/EPtuqJMsVVQZ6Urdb3GGidLBye2ufdufHO+3/28uQpWwVKrwXnzDXQ65rKptS93TBmYIK22kJ15VtTjrb4v8VfmxRg96accMhGq0rWXT0DJuOOBFLMhBFDXSDqJeRGZC
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(54906003)(356005)(5660300002)(8936002)(6512007)(81166007)(36756003)(316002)(2616005)(33656002)(6486002)(6862004)(186003)(26005)(6506007)(82310400005)(8676002)(4326008)(53546011)(47076005)(508600001)(70586007)(70206006)(86362001)(36860700001)(40460700003)(2906002)(336012)(4744005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 08:26:35.6386
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f07a68bc-5862-455c-b008-08da2827a49e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4200

Hi,=20

> On 26 Apr 2022, at 9:27 pm, Stefano Stabellini <sstabellini@kernel.org> w=
rote:
>=20
> Add Rahul as ARM SMMU maintainer. Create a new explicit entry for "ARM
> SMMU" also with Julien which is the original contributor of the code and
> continues to maintain it.
>=20
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

Acked-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
>=20
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2a47fafe85..ba0d1c0c1b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -248,6 +248,12 @@ F:	xen/drivers/passthrough/arm/
> F:	xen/include/public/arch-arm/
> F:	xen/include/public/arch-arm.h
>=20
> +ARM SMMU
> +M:	Julien Grall <julien@xen.org>
> +M:	Rahul Singh <rahul.singh@arm.com>
> +S:	Supported
> +F:	xen/drivers/passthrough/arm/smmu.c
> +
> ARM SMMUv3
> M:	Bertrand Marquis <bertrand.marquis@arm.com>
> M:	Rahul Singh <rahul.singh@arm.com>



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:27:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:27:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314531.532623 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njd1U-0005V4-J3; Wed, 27 Apr 2022 08:27:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314531.532623; Wed, 27 Apr 2022 08:27:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njd1U-0005Ux-Fa; Wed, 27 Apr 2022 08:27:44 +0000
Received: by outflank-mailman (input) for mailman id 314531;
 Wed, 27 Apr 2022 08:27:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njd1S-0005UT-P3
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:27:42 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e61f7643-c603-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 10:27:41 +0200 (CEST)
Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 04:27:37 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SN6PR03MB3613.namprd03.prod.outlook.com (2603:10b6:805:4d::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 08:27:35 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 08:27:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e61f7643-c603-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651048060;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=4OwIQ+2J736J6CmQAC0IqmdQsGFut6DEzlFudpTNk3I=;
  b=Yv/65soOWwxxfoLvv/AFuEvE2EFCtO3grnBKvL3zSillf/9++KXXsejb
   pS4xW/98ogCYII9VflbEoqo1RojE8MxAm86K52MGByU91GMPhtAH3Aw+i
   x8VcqIeiSBxcQCL9bhHwMhEUOmupZgWBZ/4mib/CLZjAi55/SmXqWoAnQ
   c=;
X-IronPort-RemoteIP: 104.47.59.175
X-IronPort-MID: 69420012
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:3sGa3a4JXcq8pqI1yjYoEAxRtKvGchMFZxGqfqrLsTDasY5as4F+v
 jQXWGCHbPyNamX9eo11O9/l80gAu5LUz9VjSQA6/CsyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjXVvW0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSoeVp1DveXx98MaEVkMX5nL59o5pjudC3XXcy7lyUqclPK6tA3VgQaGNNd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfibo4YHgV/chegXdRraT
 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2MJ9AjN/fNti4TV5Ddbyoi3OvT1Rs2Xe/tph0eGj
 0jJ8GusV3n2M/Tak1Jp6EmEgevCnjjnSZkSPLK9//9uxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzW/pHOHpRcaV8BnD/wh6AqNx6zX5C6UHmEBCDVGbbQOq8seVTEsk
 FiTkLvBHzt0uqeSTnGb3riRpDK2fyMSKAcqZyAeShAey8L+u4x1hRXKJv54C7K8hNDxHTD2w
 hiJoTI4irFVitQEv4254FTGjjSEtpXPCAkv6W3/YGWh6Q9oYZ+/UKah41Pb8PVoIZ6QSx+Ku
 31ss8KT9vwUBJeB0imEWvwQHaqB7uyAdjbbhDZS84IJ8j2s/zuveN5W6TQnfkNxaJ9bJHnuf
 VPZvh5X6NlLJny2YKRrYoW3TcM30aznEtejXffRBjZTXqVMmMa81HkGTSatM6rFySDATYlX1
 U+nTPuR
IronPort-HdrOrdr: A9a23:zg4ccqAKH5doKsXlHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN
 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d
 enl4N6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1wjegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvW/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdb11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa
 hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj4lLYIk7zI9HakGOuh5Dt
 T/Q9pVfY51P78rhIJGdZA8qJiMexrwqSylChPgHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou
 WKbG9l
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="69420012"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hhg1fQfV6K6/b7uqeXjmbMxFZLlEX1RHkzfejleBqdjho7ZdjBmtxlWuQuMOX9N0gds+X0AUdMXsCz5ic4sOMeOzFAe3sGF73G9U6ZwKiXeTwZIKWPskF5LQFAkETEjMTfn8B7j2PxspdiIiW7BaD/DWNOg9a37XOEIuPkg7ubyvB/Ng1yJpGfz7xYMVhR8KCHOL2dl5tiEQWXeRMSHmqhZki3Uc91RTWWEMkWKHTFWfKvRRxl4xseckd/KYbOGFNs12p2gxy5ahkoInCnLjMvsFwQW7E2WcSewbVwHk6VE++Y7Sj3nM8eox9fYAunTBISzmyjKOAOuGmh/dDMxBew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GsXDIthQjx5xO+nvjnKloZWxmayyyz5OMdUOQZhTM5I=;
 b=l5oj4xEcTlSo09E8eqrHrasOOstmKjmE/8SJuulJZ/WVTu6T7+c5H+knaTbn7NFKnggDeb5/ZhTWpvQRhsXyXYtaXx5zPS3lZ7jSvLdXRxz5FH7/Uui3Dc71q2uCxlwoPBSa7ZEPBhN+2RLiIMfA79qy4XkdQ3W4pjdp4N6xe8ijmzt9xdfM9wyw017Cammc0KKOHm14zDRggiMc5qQ0tpArnmOfYJjNpsxqH/dOB7QJoiwQ3o9aOS/yX+eql1+7uun0MIXj2olMDVpeJd9apwfTDHhwiTuCvxrTjN0tPRBJ8nyzN7l23j+cBxxyN8nswRJ6wMiB+AHTtKzROgv6Mw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GsXDIthQjx5xO+nvjnKloZWxmayyyz5OMdUOQZhTM5I=;
 b=UVbsuDFF2+JcEPTY1iNFds6zjKaXUPskTPTMnv3nWq30dwN994MBF5RNuq9p5xw5uA2zeXnjLcY75ZAJTINiHXaAKri+pGwtJuZIUwTzfFIP46jc6bc4dzZW8p6JmVCyqA48nUU/NzZHAORODoVl9Z8rxDkFPF6QeL21bXrlZzU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 10:27:31 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@gmail.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
Message-ID: <Ymj+c1nmOgbiw/M8@Air-de-Roger>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <YmJ4NLuvA63Irow+@Air-de-Roger>
 <24112cfc-0446-d81e-85f1-ebf9da0afe14@gmail.com>
 <YmaeLc2iwxUPUAvF@Air-de-Roger>
 <57bfc576-48d5-9121-a32e-fa00be64d6a9@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <57bfc576-48d5-9121-a32e-fa00be64d6a9@gmail.com>
X-ClientProxiedBy: LO4P123CA0435.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97323777-dba5-48bd-d403-08da2827c7e1
X-MS-TrafficTypeDiagnostic: SN6PR03MB3613:EE_
X-Microsoft-Antispam-PRVS:
	<SN6PR03MB3613A14C49E19766EAD93C948FFA9@SN6PR03MB3613.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tWBwKnRYO0VCzltjuZLNqDUI+dTpWXu7WIw/R1SKtHMylUjQ5KZl+2CB6a35JCo9GLRci2TRLGqcc5z1Y6z/JNi4bXSURPjhMxWNUuV/fX50CbT2/2qofMIJ5aKONLRpApL7gbWh8Y0/Hn+kNnD8Ai95HeQ3fOO2Yk64ggNV0r4bTPnta3njvhG3H7zLz1k8p0G1ja55ZVg1ezzkUDs8C8G1EpnEPh3X1HqcDFSJrF051znhVZT9zBN/ic0UPNrQSHY4R8II6luIZFCQ8lr8RB5OvFSr81Vn6VZ377d+fZwN2efHEP/Juw6wTFBgfLJlq8g3jVFHDaFCtqRQup2Hn39gEqU9KYaqDYj8jQrbN8ke7tBnAew6RXyRc7Lyp8InzpSaOLTLdlTgOZWY9NQ+4fhs+Gk5YO1oTw/Hg6rkTaLJ8zaJw1/p5mFE0/rWHvqN8BQmvzsAZ6JA6A2Q6m9suirFm6BcqPP6bn1tRD+ePThEP+NJge0yRj3wcNPjaP3/rWsY+jb+LRGLlJJHQVPv5Yh2aiDE5kayVHjQyskEtHReTOg74N3pG4hHgN7+Y/VVThyZFTPETHU6frD/t0emHvw98gOyhcLGhXP9Bg1Ergb1cnQ5KlExu9zlyiS2UrWQ8wHmh6ezCu3mluNTlYdYqQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(186003)(8936002)(53546011)(7416002)(86362001)(33716001)(6512007)(6506007)(26005)(6666004)(9686003)(2906002)(82960400001)(38100700002)(83380400001)(5660300002)(6916009)(316002)(4326008)(8676002)(66476007)(85182001)(66556008)(6486002)(66946007)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bk9ZSlBVUnNtUmVqcm1vTW1HMW5MRkdCMHdBeFh4YjJHdHZnVnhlUkVmQWdh?=
 =?utf-8?B?dEViM0pJbHVGRzJnYlVXcXJJMU1WZWttVXVlNW1qRmNCL1NjMUMwVU9IUGNy?=
 =?utf-8?B?WTB2UVRISXFxdXIwY0hPSzNJa1A1dXdJYk5yaWhlT2xtTmlLYWVvTW1XWGt0?=
 =?utf-8?B?R0MwQ2l1dFFFaXgxTHMyd0hIL3VzdEthcmxDQy9MNnRmSDdXTlBSM3M2em1a?=
 =?utf-8?B?U2pqM282dVQvVVhaNmdkZXJ6MzlEeGZQMHdRWGxFclBFYVVNZHM3SWlUMTcy?=
 =?utf-8?B?eGJFT1VVSWNDRE90MTFMZW9wblRsazN2V1diVjdML29SODFzc08weEtBVExs?=
 =?utf-8?B?T3V5dXFqK3JLTGpIcDVneTZUSEMrRkhEZWZjaGlBZnZ4bzZDMjlieCtQQ2VC?=
 =?utf-8?B?TE5zWlVUVC9CZ0YyK1NObjJwUmI0cEhVbjFrTjhpeDY5Q01oSTBWSmNWQWxU?=
 =?utf-8?B?ZU5hN2JxczVCbGFRYXdOOUdkUzB0YmhQTU9IMFpMMzlrQjdiNnBiZWthdGVr?=
 =?utf-8?B?UVZ4Z2tBeFYwendId0hyZHJHT2xRd3pXU0dNc3RlbisveVk0SzArUFBad1RJ?=
 =?utf-8?B?cUNFOWNrT01uYk5QeTRjOEdlUWh6alM5bnJSanAvSGZ1ZWdsbHIvZUloekI2?=
 =?utf-8?B?ZDJRZGZCZXJxVzB4bFllYnJGa3JKZGFJc1g2MmErT2NJYURiL1dkbVZCVm9X?=
 =?utf-8?B?VklDV3grTjdOWUMwWFhCcTFpY241RzRYUTlrZXZIMldLVGFMUEZBeVhVeHpv?=
 =?utf-8?B?OERLS1JqNkRxNlloc01SeHVDK3NJZ1lUTHFlSUwyajhsRXJhc2hlVHQ2NjdE?=
 =?utf-8?B?UlY3eWlmL0JCRFJ5MXpUa2tDNXlNZGJvTTZWOFNGbUdVdnVZY2pDWFZSeHRt?=
 =?utf-8?B?Njlwa2x5S0dsWldwaUx1RlVkcXpUMEYvY1hXU2ViMytORXd5dVlaS3l1RjB4?=
 =?utf-8?B?Y25tb2RaOW9FSkZiUThrdDB4WTA3a2k1WTBQekcrUnF6Mys2bkl0ZWZEdDdU?=
 =?utf-8?B?cllxZ2FOZld5RkJleXVIZnpJSWN1ekR0SlRPSlcvNnhrcmY1TE93emE3MnlU?=
 =?utf-8?B?ZDNHRW8wTDdQWit3ZlVaTCs0cjJQNmNhQmVGTzE4M1NidUJEaGN2TEZKTGVn?=
 =?utf-8?B?MDVZZ0U0a0l0akJWVmFhNnByZ3V3djRLRzNtYmo0WHNWb2RTTlE4WE1pcThF?=
 =?utf-8?B?R28xRVBheCtIQk1vMVR1NGdHUjlvbHRqU1JQb3llazhqVGNZeE5xbFAwQ1Fz?=
 =?utf-8?B?N0lZMENNbEtTYnV3aUtVUlJ0aWtaTGprejhIalUrTjVka1BSaG0wd2JRM0hi?=
 =?utf-8?B?NEFnUFVCa2pPUDNvMDRVekttVkl5bG43Q0M5R2p3MXlxNFAyQWlqc3JiWk1h?=
 =?utf-8?B?Sm1INU53QlJRRUc3MDVqeDErdVFJTG5EbDFSbU9Vajc3UDZPR1QwdnR5RUM0?=
 =?utf-8?B?NWtJVWFHbmU4RWVQazBYSnBheWptV08yWm5EWVdwRW1DcVRMUW1ySm9kbUIw?=
 =?utf-8?B?VnVqWTd1alQ4M3l3bkFYYk9NWExTaXN6R3YrdGtaTWhSZjhDOWl5bWFFTUVh?=
 =?utf-8?B?K0lkd2tqb0JEWW9JcnZJbXlLOTExTlpNWkRMbnEveXMrZVorcThTSytBdjV4?=
 =?utf-8?B?NEtuZ0hFL09VN0t4NERpQktTbFhNMjNzcmR0ZFFNWkVKSUthWk1HdVJacnB2?=
 =?utf-8?B?Tm5XOVFXMDQrbGhHYm1GcjdDTW9ScVlwUFB4WG80YUJKSTRYVkxpZG54RGpE?=
 =?utf-8?B?MjJDYVNBdUd0WFRFVkp3WTNha0lmMmxKdUlWOHI5eXcxMkhFc1JqT04zRzUy?=
 =?utf-8?B?bkpJc2JpcXhkYlRML3NXK2piT2U0Slo0SkdKQ3RUOGUyR0VWVmFHM2lucnhC?=
 =?utf-8?B?ajdzQkF5Q1JXUHpRR2NZR3JBUitBQUU1d0k4UFhJaGF3NW9PUVB4aWhqNkJY?=
 =?utf-8?B?eXY3TndTWjJTOHVnazl1RDBqeDQxVVRkVlBLSlpOaDlCby8weXg2QTcyUnV3?=
 =?utf-8?B?UGhCSnpCOGNNQlQwcHhJL2FrVFIrN3FWYnZDdy9kMjJVK0s3SVorN2RoL21v?=
 =?utf-8?B?c0xGdU5CaDMxY28rUVk5RytwR29JVkE2eDNZc2JpR0tpZzVnL2dtNHk3VWYy?=
 =?utf-8?B?U2lFb3BSVHc3ZUJQV3ZlZDY3Y2tINndvdWNYaWZrTndtMzRKRUNhWjV5L0tW?=
 =?utf-8?B?bExETDRsK1RuR2J5NDdpVlJ3T0QyK1BhS2F2dWNBODhlazZpeTRzRUc2OGhM?=
 =?utf-8?B?b0tPQlorK0tuemlBaHUySWZONitlRVhXQSs5SjRWVGRKeTgyemdJL0dLM0tw?=
 =?utf-8?B?SFhwQUJ3Z3JiVGdlOFNGWTJaaEVKUFAyMEErWjlwQ0puYWFTd2o4bGZrMU53?=
 =?utf-8?Q?dVLNFNwl5jHKmt2I=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97323777-dba5-48bd-d403-08da2827c7e1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 08:27:35.0053
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rJYKyIxuOyqFF9GnucpTHQ13jesZqj566jSoe4hp7YmmO8vPqcdENtWZ66Cw6+zvNaN0Om0jM10K30WOaaTqRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3613

On Wed, Apr 27, 2022 at 11:20:04AM +0300, Oleksandr wrote:
> 
> On 25.04.22 16:12, Roger Pau Monné wrote:
> 
> 
> Hello Roger
> 
> 
> > On Sat, Apr 23, 2022 at 10:39:14AM +0300, Oleksandr wrote:
> > > On 22.04.22 12:41, Roger Pau Monné wrote:
> > > 
> > > 
> > > Hello Roger
> > > 
> > > > On Fri, Apr 08, 2022 at 09:21:04PM +0300, Oleksandr Tyshchenko wrote:
> > > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > > --- a/docs/man/xl-disk-configuration.5.pod.in
> > > > > +++ b/docs/man/xl-disk-configuration.5.pod.in
> > > > > @@ -232,7 +232,7 @@ Specifies the backend implementation to use
> > > > >    =item Supported values
> > > > > -phy, qdisk
> > > > > +phy, qdisk, other
> > > > >    =item Mandatory
> > > > > @@ -244,11 +244,13 @@ Automatically determine which backend to use.
> > > > >    =back
> > > > > -This does not affect the guest's view of the device.  It controls
> > > > > -which software implementation of the Xen backend driver is used.
> > > > > +It controls which software implementation of the backend driver is used.
> > > > > +Depending on the "protocol" option this may affect the guest's view
> > > > > +of the device.
> > > > >    Not all backend drivers support all combinations of other options.
> > > > > -For example, "phy" does not support formats other than "raw".
> > > > > +For example, "phy" and "other" do not support formats other than "raw" and
> > > > > +"other" does not support protocols other than "virtio-mmio".
> > > > >    Normally this option should not be specified, in which case libxl will
> > > > >    automatically determine the most suitable backend.
> > > > > @@ -344,8 +346,35 @@ can be used to disable "hole punching" for file based backends which
> > > > >    were intentionally created non-sparse to avoid fragmentation of the
> > > > >    file.
> > > > > +=item B<protocol>=I<PROTOCOL>
> > > > > +
> > > > > +=over 4
> > > > > +
> > > > > +=item Description
> > > > > +
> > > > > +Specifies the communication protocol to use for the chosen "backendtype" option
> > > > > +
> > > > > +=item Supported values
> > > > > +
> > > > > +xen, virtio-mmio
> > > >   From a user PoV, I think it would be better to just select xen or
> > > > virtio here, but not the underlying configuration mechanism used to
> > > > expose the devices to the guest.
> > > I got your point.
> > > 
> > > 
> > > 
> > > > We would likely need to add a different option to select mmio or pci
> > > > then, but that should be set by default based on architecture/guest
> > > > type.  For example on x86 it should default to pci, while on Arm I
> > > > guess it will depend on whether the guest has PCI or not?
> > > > 
> > > > In any case, I think we should offer an option that's selecting
> > > > between xen or virtio protocol, and the way to expose the
> > > > configuration of the device shouldn't need to be explicitly selected
> > > > by the user.
> > > 
> > > ok, for now I will use "xen and virtio" values for the "protocol" option,
> > > then internally toolstack will assume that "virtio" really means
> > > "virtio-mmio".
> > > 
> > > When there is a need to expand that support to "virtio-pci", we will see how
> > > to deal with it from the configuration PoV, probably like you suggested
> > > above by adding another option (e.g. "transport") with default values based
> > > on the architecture/guest type.
> > I think this likely also wants to be a separate field in libxl_device_disk,
> > which could be left empty and libxl will attempt to set a default.
> > For example have the following in libxl_types.idl:
> > 
> > libxl_device_protocol = Enumeration("device_protocol", [
> >      (0, "UNKNOWN"),
> >      (1, "XEN"),
> >      (2, "VIRTIO"),
> >      ])
> > 
> > libxl_device_configuration = Enumeration("device_configuration", [
> >      (0, "UNKNOWN"),
> >      (1, "XENBUS"),
> >      (2, "MMIO"),
> >      ])
> > 
> > libxl_device_disk = Struct("device_disk", [
> >      ("protocol", libxl_device_protocol),
> >      ("configuration", libxl_device_configuration),
> >      ])
> > 
> > I don't like libxl_device_configuration much, I think is too generic,
> > but I can't think of anything better.  Maybe others can provide better
> > names.
> 
> 
> Here [1] we had a discussion regarding user configuration options.
> "protocol" cannot be used as it will lead to the confusion (at least with
> Xen PV block device which already has "protocol" frontend's entry in
> Xenstore).
> 
> Preliminary, we had agreed on the following names:
> 1. specification: xen or virtio
> 2. transport: mmio or pci
> 
> Please tell me, are you OK with them?

Yes, that's fine. My main point is that libxl_device_disk should
contain both fields, so a 3rd party toolstack can set 'specification =
virtio' and let Xen decide the transport to use.

I'm dubious whether we want to have a xenbus transport for xen
specification to use, but I guess it's fine to say that for
specification == xen transport is ignored.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:36:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:36:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314540.532633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njd9i-00074h-Kf; Wed, 27 Apr 2022 08:36:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314540.532633; Wed, 27 Apr 2022 08:36:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njd9i-00074a-HI; Wed, 27 Apr 2022 08:36:14 +0000
Received: by outflank-mailman (input) for mailman id 314540;
 Wed, 27 Apr 2022 08:36:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1GEo=VF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njd9h-00074U-84
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:36:13 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17a17fd1-c605-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 10:36:11 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4B0901F388;
 Wed, 27 Apr 2022 08:36:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E40381323E;
 Wed, 27 Apr 2022 08:36:10 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id g9JONnoAaWIFSAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 27 Apr 2022 08:36:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17a17fd1-c605-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651048571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=NPK63+EPMrMO8igtS0GNvcuwQjx9S9Iq0VxYrpeJRoQ=;
	b=hz70znOIlxsgr9udWyXJYHyIs18NwtkS8giH1uHwfY3jayI73pGas96aJ94Z0geu+YnGC0
	7wT12iTDPEGjQWgyKZMcJ79r1wju0mJkbGMwUy5y2tR2qPp/ZL0iuiWPq/Mj13Y1RXCh1B
	9DlnQunKQtEziyXAvJ2YIoZZqyM4rGA=
Message-ID: <7e5759fa-739f-1311-ff00-1cc60729a9f3@suse.com>
Date: Wed, 27 Apr 2022 10:36:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <YmJ4NLuvA63Irow+@Air-de-Roger>
 <24112cfc-0446-d81e-85f1-ebf9da0afe14@gmail.com>
 <YmaeLc2iwxUPUAvF@Air-de-Roger>
 <57bfc576-48d5-9121-a32e-fa00be64d6a9@gmail.com>
 <Ymj+c1nmOgbiw/M8@Air-de-Roger>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <Ymj+c1nmOgbiw/M8@Air-de-Roger>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------FIzAwdqNMBmBZhiY9R8540FZ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------FIzAwdqNMBmBZhiY9R8540FZ
Content-Type: multipart/mixed; boundary="------------UCBgqSGYzC1zm4vGl5RGNWKQ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
 <rosbrookn@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Message-ID: <7e5759fa-739f-1311-ff00-1cc60729a9f3@suse.com>
Subject: Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration
References: <1649442065-8332-1-git-send-email-olekstysh@gmail.com>
 <1649442065-8332-2-git-send-email-olekstysh@gmail.com>
 <YmJ4NLuvA63Irow+@Air-de-Roger>
 <24112cfc-0446-d81e-85f1-ebf9da0afe14@gmail.com>
 <YmaeLc2iwxUPUAvF@Air-de-Roger>
 <57bfc576-48d5-9121-a32e-fa00be64d6a9@gmail.com>
 <Ymj+c1nmOgbiw/M8@Air-de-Roger>
In-Reply-To: <Ymj+c1nmOgbiw/M8@Air-de-Roger>

--------------UCBgqSGYzC1zm4vGl5RGNWKQ
Content-Type: multipart/mixed; boundary="------------8vDgqUOfvNFyTWrm7Ru4wXmJ"

--------------8vDgqUOfvNFyTWrm7Ru4wXmJ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjcuMDQuMjIgMTA6MjcsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIFdlZCwg
QXByIDI3LCAyMDIyIGF0IDExOjIwOjA0QU0gKzAzMDAsIE9sZWtzYW5kciB3cm90ZToNCj4+
DQo+PiBPbiAyNS4wNC4yMiAxNjoxMiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+DQo+
Pg0KPj4gSGVsbG8gUm9nZXINCj4+DQo+Pg0KPj4+IE9uIFNhdCwgQXByIDIzLCAyMDIyIGF0
IDEwOjM5OjE0QU0gKzAzMDAsIE9sZWtzYW5kciB3cm90ZToNCj4+Pj4gT24gMjIuMDQuMjIg
MTI6NDEsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+DQo+Pj4+DQo+Pj4+IEhlbGxv
IFJvZ2VyDQo+Pj4+DQo+Pj4+PiBPbiBGcmksIEFwciAwOCwgMjAyMiBhdCAwOToyMTowNFBN
ICswMzAwLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBGcm9tOiBPbGVr
c2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+
Pj4gLS0tIGEvZG9jcy9tYW4veGwtZGlzay1jb25maWd1cmF0aW9uLjUucG9kLmluDQo+Pj4+
Pj4gKysrIGIvZG9jcy9tYW4veGwtZGlzay1jb25maWd1cmF0aW9uLjUucG9kLmluDQo+Pj4+
Pj4gQEAgLTIzMiw3ICsyMzIsNyBAQCBTcGVjaWZpZXMgdGhlIGJhY2tlbmQgaW1wbGVtZW50
YXRpb24gdG8gdXNlDQo+Pj4+Pj4gICAgID1pdGVtIFN1cHBvcnRlZCB2YWx1ZXMNCj4+Pj4+
PiAtcGh5LCBxZGlzaw0KPj4+Pj4+ICtwaHksIHFkaXNrLCBvdGhlcg0KPj4+Pj4+ICAgICA9
aXRlbSBNYW5kYXRvcnkNCj4+Pj4+PiBAQCAtMjQ0LDExICsyNDQsMTMgQEAgQXV0b21hdGlj
YWxseSBkZXRlcm1pbmUgd2hpY2ggYmFja2VuZCB0byB1c2UuDQo+Pj4+Pj4gICAgID1iYWNr
DQo+Pj4+Pj4gLVRoaXMgZG9lcyBub3QgYWZmZWN0IHRoZSBndWVzdCdzIHZpZXcgb2YgdGhl
IGRldmljZS4gIEl0IGNvbnRyb2xzDQo+Pj4+Pj4gLXdoaWNoIHNvZnR3YXJlIGltcGxlbWVu
dGF0aW9uIG9mIHRoZSBYZW4gYmFja2VuZCBkcml2ZXIgaXMgdXNlZC4NCj4+Pj4+PiArSXQg
Y29udHJvbHMgd2hpY2ggc29mdHdhcmUgaW1wbGVtZW50YXRpb24gb2YgdGhlIGJhY2tlbmQg
ZHJpdmVyIGlzIHVzZWQuDQo+Pj4+Pj4gK0RlcGVuZGluZyBvbiB0aGUgInByb3RvY29sIiBv
cHRpb24gdGhpcyBtYXkgYWZmZWN0IHRoZSBndWVzdCdzIHZpZXcNCj4+Pj4+PiArb2YgdGhl
IGRldmljZS4NCj4+Pj4+PiAgICAgTm90IGFsbCBiYWNrZW5kIGRyaXZlcnMgc3VwcG9ydCBh
bGwgY29tYmluYXRpb25zIG9mIG90aGVyIG9wdGlvbnMuDQo+Pj4+Pj4gLUZvciBleGFtcGxl
LCAicGh5IiBkb2VzIG5vdCBzdXBwb3J0IGZvcm1hdHMgb3RoZXIgdGhhbiAicmF3Ii4NCj4+
Pj4+PiArRm9yIGV4YW1wbGUsICJwaHkiIGFuZCAib3RoZXIiIGRvIG5vdCBzdXBwb3J0IGZv
cm1hdHMgb3RoZXIgdGhhbiAicmF3IiBhbmQNCj4+Pj4+PiArIm90aGVyIiBkb2VzIG5vdCBz
dXBwb3J0IHByb3RvY29scyBvdGhlciB0aGFuICJ2aXJ0aW8tbW1pbyIuDQo+Pj4+Pj4gICAg
IE5vcm1hbGx5IHRoaXMgb3B0aW9uIHNob3VsZCBub3QgYmUgc3BlY2lmaWVkLCBpbiB3aGlj
aCBjYXNlIGxpYnhsIHdpbGwNCj4+Pj4+PiAgICAgYXV0b21hdGljYWxseSBkZXRlcm1pbmUg
dGhlIG1vc3Qgc3VpdGFibGUgYmFja2VuZC4NCj4+Pj4+PiBAQCAtMzQ0LDggKzM0NiwzNSBA
QCBjYW4gYmUgdXNlZCB0byBkaXNhYmxlICJob2xlIHB1bmNoaW5nIiBmb3IgZmlsZSBiYXNl
ZCBiYWNrZW5kcyB3aGljaA0KPj4+Pj4+ICAgICB3ZXJlIGludGVudGlvbmFsbHkgY3JlYXRl
ZCBub24tc3BhcnNlIHRvIGF2b2lkIGZyYWdtZW50YXRpb24gb2YgdGhlDQo+Pj4+Pj4gICAg
IGZpbGUuDQo+Pj4+Pj4gKz1pdGVtIEI8cHJvdG9jb2w+PUk8UFJPVE9DT0w+DQo+Pj4+Pj4g
Kw0KPj4+Pj4+ICs9b3ZlciA0DQo+Pj4+Pj4gKw0KPj4+Pj4+ICs9aXRlbSBEZXNjcmlwdGlv
bg0KPj4+Pj4+ICsNCj4+Pj4+PiArU3BlY2lmaWVzIHRoZSBjb21tdW5pY2F0aW9uIHByb3Rv
Y29sIHRvIHVzZSBmb3IgdGhlIGNob3NlbiAiYmFja2VuZHR5cGUiIG9wdGlvbg0KPj4+Pj4+
ICsNCj4+Pj4+PiArPWl0ZW0gU3VwcG9ydGVkIHZhbHVlcw0KPj4+Pj4+ICsNCj4+Pj4+PiAr
eGVuLCB2aXJ0aW8tbW1pbw0KPj4+Pj4gICAgRnJvbSBhIHVzZXIgUG9WLCBJIHRoaW5rIGl0
IHdvdWxkIGJlIGJldHRlciB0byBqdXN0IHNlbGVjdCB4ZW4gb3INCj4+Pj4+IHZpcnRpbyBo
ZXJlLCBidXQgbm90IHRoZSB1bmRlcmx5aW5nIGNvbmZpZ3VyYXRpb24gbWVjaGFuaXNtIHVz
ZWQgdG8NCj4+Pj4+IGV4cG9zZSB0aGUgZGV2aWNlcyB0byB0aGUgZ3Vlc3QuDQo+Pj4+IEkg
Z290IHlvdXIgcG9pbnQuDQo+Pj4+DQo+Pj4+DQo+Pj4+DQo+Pj4+PiBXZSB3b3VsZCBsaWtl
bHkgbmVlZCB0byBhZGQgYSBkaWZmZXJlbnQgb3B0aW9uIHRvIHNlbGVjdCBtbWlvIG9yIHBj
aQ0KPj4+Pj4gdGhlbiwgYnV0IHRoYXQgc2hvdWxkIGJlIHNldCBieSBkZWZhdWx0IGJhc2Vk
IG9uIGFyY2hpdGVjdHVyZS9ndWVzdA0KPj4+Pj4gdHlwZS4gIEZvciBleGFtcGxlIG9uIHg4
NiBpdCBzaG91bGQgZGVmYXVsdCB0byBwY2ksIHdoaWxlIG9uIEFybSBJDQo+Pj4+PiBndWVz
cyBpdCB3aWxsIGRlcGVuZCBvbiB3aGV0aGVyIHRoZSBndWVzdCBoYXMgUENJIG9yIG5vdD8N
Cj4+Pj4+DQo+Pj4+PiBJbiBhbnkgY2FzZSwgSSB0aGluayB3ZSBzaG91bGQgb2ZmZXIgYW4g
b3B0aW9uIHRoYXQncyBzZWxlY3RpbmcNCj4+Pj4+IGJldHdlZW4geGVuIG9yIHZpcnRpbyBw
cm90b2NvbCwgYW5kIHRoZSB3YXkgdG8gZXhwb3NlIHRoZQ0KPj4+Pj4gY29uZmlndXJhdGlv
biBvZiB0aGUgZGV2aWNlIHNob3VsZG4ndCBuZWVkIHRvIGJlIGV4cGxpY2l0bHkgc2VsZWN0
ZWQNCj4+Pj4+IGJ5IHRoZSB1c2VyLg0KPj4+Pg0KPj4+PiBvaywgZm9yIG5vdyBJIHdpbGwg
dXNlICJ4ZW4gYW5kIHZpcnRpbyIgdmFsdWVzIGZvciB0aGUgInByb3RvY29sIiBvcHRpb24s
DQo+Pj4+IHRoZW4gaW50ZXJuYWxseSB0b29sc3RhY2sgd2lsbCBhc3N1bWUgdGhhdCAidmly
dGlvIiByZWFsbHkgbWVhbnMNCj4+Pj4gInZpcnRpby1tbWlvIi4NCj4+Pj4NCj4+Pj4gV2hl
biB0aGVyZSBpcyBhIG5lZWQgdG8gZXhwYW5kIHRoYXQgc3VwcG9ydCB0byAidmlydGlvLXBj
aSIsIHdlIHdpbGwgc2VlIGhvdw0KPj4+PiB0byBkZWFsIHdpdGggaXQgZnJvbSB0aGUgY29u
ZmlndXJhdGlvbiBQb1YsIHByb2JhYmx5IGxpa2UgeW91IHN1Z2dlc3RlZA0KPj4+PiBhYm92
ZSBieSBhZGRpbmcgYW5vdGhlciBvcHRpb24gKGUuZy4gInRyYW5zcG9ydCIpIHdpdGggZGVm
YXVsdCB2YWx1ZXMgYmFzZWQNCj4+Pj4gb24gdGhlIGFyY2hpdGVjdHVyZS9ndWVzdCB0eXBl
Lg0KPj4+IEkgdGhpbmsgdGhpcyBsaWtlbHkgYWxzbyB3YW50cyB0byBiZSBhIHNlcGFyYXRl
IGZpZWxkIGluIGxpYnhsX2RldmljZV9kaXNrLA0KPj4+IHdoaWNoIGNvdWxkIGJlIGxlZnQg
ZW1wdHkgYW5kIGxpYnhsIHdpbGwgYXR0ZW1wdCB0byBzZXQgYSBkZWZhdWx0Lg0KPj4+IEZv
ciBleGFtcGxlIGhhdmUgdGhlIGZvbGxvd2luZyBpbiBsaWJ4bF90eXBlcy5pZGw6DQo+Pj4N
Cj4+PiBsaWJ4bF9kZXZpY2VfcHJvdG9jb2wgPSBFbnVtZXJhdGlvbigiZGV2aWNlX3Byb3Rv
Y29sIiwgWw0KPj4+ICAgICAgICgwLCAiVU5LTk9XTiIpLA0KPj4+ICAgICAgICgxLCAiWEVO
IiksDQo+Pj4gICAgICAgKDIsICJWSVJUSU8iKSwNCj4+PiAgICAgICBdKQ0KPj4+DQo+Pj4g
bGlieGxfZGV2aWNlX2NvbmZpZ3VyYXRpb24gPSBFbnVtZXJhdGlvbigiZGV2aWNlX2NvbmZp
Z3VyYXRpb24iLCBbDQo+Pj4gICAgICAgKDAsICJVTktOT1dOIiksDQo+Pj4gICAgICAgKDEs
ICJYRU5CVVMiKSwNCj4+PiAgICAgICAoMiwgIk1NSU8iKSwNCj4+PiAgICAgICBdKQ0KPj4+
DQo+Pj4gbGlieGxfZGV2aWNlX2Rpc2sgPSBTdHJ1Y3QoImRldmljZV9kaXNrIiwgWw0KPj4+
ICAgICAgICgicHJvdG9jb2wiLCBsaWJ4bF9kZXZpY2VfcHJvdG9jb2wpLA0KPj4+ICAgICAg
ICgiY29uZmlndXJhdGlvbiIsIGxpYnhsX2RldmljZV9jb25maWd1cmF0aW9uKSwNCj4+PiAg
ICAgICBdKQ0KPj4+DQo+Pj4gSSBkb24ndCBsaWtlIGxpYnhsX2RldmljZV9jb25maWd1cmF0
aW9uIG11Y2gsIEkgdGhpbmsgaXMgdG9vIGdlbmVyaWMsDQo+Pj4gYnV0IEkgY2FuJ3QgdGhp
bmsgb2YgYW55dGhpbmcgYmV0dGVyLiAgTWF5YmUgb3RoZXJzIGNhbiBwcm92aWRlIGJldHRl
cg0KPj4+IG5hbWVzLg0KPj4NCj4+DQo+PiBIZXJlIFsxXSB3ZSBoYWQgYSBkaXNjdXNzaW9u
IHJlZ2FyZGluZyB1c2VyIGNvbmZpZ3VyYXRpb24gb3B0aW9ucy4NCj4+ICJwcm90b2NvbCIg
Y2Fubm90IGJlIHVzZWQgYXMgaXQgd2lsbCBsZWFkIHRvIHRoZSBjb25mdXNpb24gKGF0IGxl
YXN0IHdpdGgNCj4+IFhlbiBQViBibG9jayBkZXZpY2Ugd2hpY2ggYWxyZWFkeSBoYXMgInBy
b3RvY29sIiBmcm9udGVuZCdzIGVudHJ5IGluDQo+PiBYZW5zdG9yZSkuDQo+Pg0KPj4gUHJl
bGltaW5hcnksIHdlIGhhZCBhZ3JlZWQgb24gdGhlIGZvbGxvd2luZyBuYW1lczoNCj4+IDEu
IHNwZWNpZmljYXRpb246IHhlbiBvciB2aXJ0aW8NCj4+IDIuIHRyYW5zcG9ydDogbW1pbyBv
ciBwY2kNCj4+DQo+PiBQbGVhc2UgdGVsbCBtZSwgYXJlIHlvdSBPSyB3aXRoIHRoZW0/DQo+
IA0KPiBZZXMsIHRoYXQncyBmaW5lLiBNeSBtYWluIHBvaW50IGlzIHRoYXQgbGlieGxfZGV2
aWNlX2Rpc2sgc2hvdWxkDQo+IGNvbnRhaW4gYm90aCBmaWVsZHMsIHNvIGEgM3JkIHBhcnR5
IHRvb2xzdGFjayBjYW4gc2V0ICdzcGVjaWZpY2F0aW9uID0NCj4gdmlydGlvJyBhbmQgbGV0
IFhlbiBkZWNpZGUgdGhlIHRyYW5zcG9ydCB0byB1c2UuDQo+IA0KPiBJJ20gZHViaW91cyB3
aGV0aGVyIHdlIHdhbnQgdG8gaGF2ZSBhIHhlbmJ1cyB0cmFuc3BvcnQgZm9yIHhlbg0KPiBz
cGVjaWZpY2F0aW9uIHRvIHVzZSwgYnV0IEkgZ3Vlc3MgaXQncyBmaW5lIHRvIHNheSB0aGF0
IGZvcg0KPiBzcGVjaWZpY2F0aW9uID09IHhlbiB0cmFuc3BvcnQgaXMgaWdub3JlZC4NCg0K
QXQgbGVhc3QgZm9yIG5vdywgSSBndWVzcy4gSXQgbWlnaHQgYmUgYSB0aGluZyBpbiBjYXNl
IHNvbWVvbmUgZGVjaWRlcw0KdG8gYWRkIGFyZ28gc3VwcG9ydC4NCg0KDQpKdWVyZ2VuDQo=

--------------8vDgqUOfvNFyTWrm7Ru4wXmJ
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------8vDgqUOfvNFyTWrm7Ru4wXmJ--

--------------UCBgqSGYzC1zm4vGl5RGNWKQ--

--------------FIzAwdqNMBmBZhiY9R8540FZ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJpAHoFAwAAAAAACgkQsN6d1ii/Ey8g
oQgAie06/soLud4Jt3AcwaPweRfZESO0pcsU4WEeuIm4PMm38KbvEIKdcqZSmD1Xn95U6bLKrQse
1wttyLFYAsmDmRK1BO8umW9th+O3rO8hfMG4+zAVxwI8lwn9vrMNo/VSCnMprSf1+X6ePQEgCI8y
SRrXru3t7YmOiqZnLUkFAsB5ReY3O7WBSCngBpzrx8SJZn+G83b56cEDhT44qnk3EAuJ43IBByCc
3h2B7ZVYlNdTciaYnVTdAVYpi6yIq9W6PC5ASdvDfdlIDRCCtcqkXodCF1mR5yi/xQwl7rCxebgU
nZYqGYZWMg/UquNq/blVm261AF9H23rXm3mUA9n11g==
=u7OG
-----END PGP SIGNATURE-----

--------------FIzAwdqNMBmBZhiY9R8540FZ--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:40:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:40:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314546.532644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdDa-0008R2-51; Wed, 27 Apr 2022 08:40:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314546.532644; Wed, 27 Apr 2022 08:40:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdDa-0008Qv-1l; Wed, 27 Apr 2022 08:40:14 +0000
Received: by outflank-mailman (input) for mailman id 314546;
 Wed, 27 Apr 2022 08:40:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njdDY-0008Qp-La
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:40:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a6269c87-c605-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 10:40:11 +0200 (CEST)
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03lp2173.outbound.protection.outlook.com [104.47.51.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-JWBsU11sMNiWZiIqB3pU4g-1; Wed, 27 Apr 2022 10:40:09 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR0401MB2488.eurprd04.prod.outlook.com (2603:10a6:4:35::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 27 Apr
 2022 08:40:08 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 08:40:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6269c87-c605-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651048810;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Y5QjRMoLiHAlv2i4iqi7JlyFkL8HZ1i6/D6f562725Y=;
	b=nyqMid5SnUMLlcgSGHZYzeKIooGtBDfQcTq3uE54IM0xmT7/bzGwp5/1+ZSIWn6LrkpwYV
	EjB05WCFILc5fKhIsMDAu4xJ6EcrTP3JR5fgG+eTnP2D1+fJTgXVvR35CLvYCAiZwDIZXD
	NP1WikXstppvLpC4/d2zUZqvV/IQF3E=
X-MC-Unique: JWBsU11sMNiWZiIqB3pU4g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PHRZL/zTLQJd/RfbH5zDXMZBvOZUoTJN/P+HOnDi+QZynkZ6LlZ4kZ+6rKcNk8ZqMsFLbC0+VjnZ0pYyIFpzV41BO19faN3cxnU5GA2VB/b3whG46/b/CM7LIkcM8m+/fQOlI8qWOxMX3ha7ixBoDIR80MDmMXCD3VCEqCtINRd8S6RapVVv4wnjyvoaluwfeJ3nEIT0x9i2AxJu/tK5pLIVinkn5MIlaMwdeLwW1oKlI7MUnf3q24kYXy3IWflDbWPxNBL3d6KLy4hYOy6ffZzMl6ZGSVTWotYcqnJVwUMBN6/BC6bdL3f1bsR4Slit/gyIrSLxmTyGvZF32S1aYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y5QjRMoLiHAlv2i4iqi7JlyFkL8HZ1i6/D6f562725Y=;
 b=Qb8xsDx8jJWf3K6qAD6OsTIrP3Cs0+0xfHRCWQjatkHPIJ5LsbPDIz+NCkzWTrWQ6sdkSv+fewd7jHXL9g7Wz2ZdIgz+b2ZZJC/Pfv7A5+P9a/imOdSN82uZgJ9ugRVdX8yjBzxuJTO7AZfb9pB5hXT+6qSMPdaE2suKw6DXaK2FA69UxcSf6zaLB6a4lzX5eqeqcrEAtIZnDGq2DSjn2YljW2wlgUwvU1T1a+oHL5gc4hiVgZ2ZypZQ3JcDcr1Qyybw+rzyOTtCMHh1evd/Bg5MqoOMNlh0vv1PPN0b54IoM2HxqhWDNOUlODHd6YNiiIm8vl4E8sGrlwoNzfOozQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4ab7cc30-73b4-e08c-3731-94c7bbb25adc@suse.com>
Date: Wed, 27 Apr 2022 10:40:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 2/4] Add a dedicated memory region for the ESRT
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <Yl7X/dT39vvhZmho@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yl7X/dT39vvhZmho@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0076.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::17) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cfb7216f-a037-48b4-8ee8-08da282988d3
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2488:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB2488E3BA6FF52C6CE887F583B3FA9@DB6PR0401MB2488.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HfhnaQtclaVZFBnjCcgkZxCvzj85dpFg6v55D2EG6Ewzfa0QUGMAiiVE/hu429jA9WVCweCaPSqwjXwfTlmfPP/WKabgyqHw0Cc3UOivlMoHjy+8vYp4uwFafhopbs7LqyY869JrYEM0QKG4YUPoMNjaclsDsPIwsAQR3DoUV64D9Xcs4JOY2Uh8eHW3YykqjbFdwmSJFbJW0dlKOHs0HTarNPLnr+r0ruqnvmF8QRZXKgePzuVdotXCdOWgUb/dSbWl5fbDictLOxiF15ahREr7uf7Om+H5SBH6CmKismbGiaBzXPuEiyUmlWxddoNyoTqFc7agKAU3F6uVkekfVYkKhaku42nlYsWkZu3vhv+4sTZgqBFJVSJvLD5Bo9tKp7zi03yKPr4etEeSCaK1wxjw2oEZM/vj6dxfSLLTqd6pyD8Kz6hN8fSCVdos/L1zeGsW7Ch06JRp7YLLsl1rHs+MYotm9jeGGfm3GKWwdkXY6CvSDzkD7ofs8mu+RSR1MMLxyOnc1Rhrz3IpcbDJRrhU+gzaVCr/W0palgVNjMwtMz97NF8EJBstdupr3tPK5QZrYS/0KKCl89uJdx7ZvVSDYpU1kQOgefYQQf0KEZ6Srdr0tdG2KI3Df/zgwd777zQJe/B0CqkWHPMRSPblC3ML7v9pPeYDl6rwkb76fjwjGvuz5dCGODLFb1/xYuqbCushUUpXO4icSkOCZGwN6/uH2Qsn2/o1jfWr5RXi9BnNDYt/zmrFX/51B8a5tDsi
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(66946007)(66476007)(66556008)(186003)(6512007)(31696002)(8676002)(4326008)(86362001)(36756003)(26005)(6506007)(2616005)(508600001)(6486002)(53546011)(6916009)(316002)(2906002)(54906003)(83380400001)(38100700002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SmhVaytlNlRTUFZxbm1hVkVLUE4yQ1VUMHJwaGJHZmdORklyeDNEcXJJYmpB?=
 =?utf-8?B?U1Z3cHpYUE50RytKazVCN0xxMy9tRVo4c2ovZmJTSldsWXh5OENHSnh2SVhS?=
 =?utf-8?B?bU1zNWVDS0hwVzFYazl4N0RyM1hic0xWREtrT3ptYmlWaWwvQmZOTm04TXhk?=
 =?utf-8?B?T1ZUUDMzZldmSUZZM0FKUTFhcm1TV0dXaDFJR3pWY2NmbjBCc0RIRklTdW13?=
 =?utf-8?B?OG9vOXY1a0VlWC84WjI2aGZRZSt3cVN6cjAxRkNZbkRQcWtXRXZ3WHlFTEl0?=
 =?utf-8?B?Z3FsZkwvalhKL3AvREVaZGhhSUx1WXppNU5yTjZ4d05mWmZkdnVZVXFTUmZa?=
 =?utf-8?B?UjJZQ2pyMTNGQ3FGR3RjREdmNTVpeHI2dngyTGY3KzkzaW9HS0lFaXRhY3BZ?=
 =?utf-8?B?enF5TXhvOFpydU1XWUcvQzhsc1BHTFAzYzQyVWROclJ5ZEpNaDduR3E0UTBR?=
 =?utf-8?B?WVJCWXQzTWJGRmpzcG91RzdQYk1LYjU0TiswckNZZS9nYU8vRlY3NzM2aFdI?=
 =?utf-8?B?NUpDVmxiSENMb0JBSWVUYnZ6d3A3UG5oRFNpbW1EOFA0SUp1VDJBV21Fb29o?=
 =?utf-8?B?NTVnSkNUSytTd1ZZbnBSdDZBTFFyNWh3cS9ETmdHOXpMUzR4bVZRUllsVW5r?=
 =?utf-8?B?bUhQTEhYREZHR0VVYXllY01scWNJNE4wOWQ5R2ZsUHVTRmdobFpxNFFGZndR?=
 =?utf-8?B?U0tRL3hFcUtMMTNhQnQrSkpMUyt4NTYvMDJuV2ZpYVNOdmJleFJEQmRaQm5m?=
 =?utf-8?B?SXRHUlBySG5sSTRjblNQTmdvc2cyOHBhMkpMbXVnaUFWNFAxcmNsenZGYk80?=
 =?utf-8?B?N2dxVjBjZTk2Y2VwMmVvSzlQUE9BQ2dEV0JTM0xxSmQ2eTF5MkROZEprK2Qx?=
 =?utf-8?B?WGljUk1YckV6UndIN3JpdGZoZjF3UzNkZW9jTW1icVprNFE0SlF5SVRLWG1j?=
 =?utf-8?B?UWswTGFUSDVJNFlVcDlRN1l2and5bXRzWWVmNjVrZld6aHpEdDlRZEk2N25P?=
 =?utf-8?B?a09rTlNEY2Evd2RTeUtBQkZwSk5wYmRLRXFIbUZzY0MzUWZTOWczSE5wQW5N?=
 =?utf-8?B?UXJLc0ZzRmNRVGFNRzd3Znl1dHQwaXdZQi85bjVHT1VnL0xqQytWVnpWWnVG?=
 =?utf-8?B?Mjk0RjZEenFHY2tRVXRMeWhPZm5sNERRdWc0QXk5YjlMTmdsbCtpUk1EbG9Z?=
 =?utf-8?B?emVadExMd21ZMUNDdXlNMUVDL05VdHpGYnFuODBXQU9wZUJWMHlLZzFEek9T?=
 =?utf-8?B?RUREQktha3J5dHBqSXZ2d1Y2MXF1b2E3S0lUUmR6Q2JTM0xFSzRqNG1IV2RD?=
 =?utf-8?B?THF5cUZqMGVKS1NGdGJtQ3ZsUmgyLzFlUndSR1dKc05tRlplblEvdWVEcWw0?=
 =?utf-8?B?WHptYm9PY1pRNEpUNjAzT0MrdWlnbXVUSDl4L2VMQmpkYUgwTU1wTzlWN282?=
 =?utf-8?B?Z2JjQ1BCbFBYRmVKNmtENFdtcDJBbUpreXNmU1R1alFjbkhOMzFQWlBNTldq?=
 =?utf-8?B?K282VUdmZjVDVjd4YStmMGJ0SFRUby9kQk5TYXlvSElKbEFSUFdLWDFlOU9z?=
 =?utf-8?B?dkhKb0hqbHJmbTY4K0ZUV2c4MFliWGk1a0FScXQ0cmpGaG1SYlc3NXV5YTQ2?=
 =?utf-8?B?VWRZWWQ5WXRKdEZmYkJhblRUZnIwWlBpazAyZnBFVElvUDU0U0FsUVlVYUdv?=
 =?utf-8?B?YUx6Z2o2TU9uOVVQbXowWGdxdDNQOFIvbmlsaWFkZ0p5a1A5WEZvZlFEbTNl?=
 =?utf-8?B?N21oMUdiMGFycWhWdHpCdnRmYWROcy9peWZuMVFwNVlDSk5EZ1k0RFVlQk9S?=
 =?utf-8?B?YXh3bFphekc2c3E5bGJYNmVWNi9yQXYwSWVLSi9oSXRQUHpBTk1rM3NVNGQz?=
 =?utf-8?B?bUJKUFpmTnJuRXpUYit1TXdtSjhCUENscmljQUhqck1ObVIrYmNtM0E1alRl?=
 =?utf-8?B?ZnJNZnZSNGJBdWI5Vy9jMFhsVmxOekE2UmJuMWdxRlpxVkVNM3NGcnlhWmRP?=
 =?utf-8?B?WWZNVGRHYWdUbEM3WkFTMmlpUDU2RlVlbGRpWUJIWE9uTHNoV09Za3NsK0Rt?=
 =?utf-8?B?YVdQVlNtMEhMMWtzaFpGRFJhRTdveGdKZUZ6ZExyV3FmclFlbDUzZzFOQlpq?=
 =?utf-8?B?eVpFQldSNXBmYWxBMkdFSS9SUTVvZ1ZlMHJjaHlPOUhSYWZhK1g2QlFDcEM3?=
 =?utf-8?B?RDY4NmtCNGJ1WUpNSDg4SmQwNTRWUDdUYWNScm5SUkhUOHRZUFdpTEh5MFIx?=
 =?utf-8?B?b3NvT1J0VXUvSXlhbndWMEwvYjRFcDg0WHVBR1krWFVpbFA5TkhiWlY2SzA0?=
 =?utf-8?B?akRoWm45azZ5c1EzWVpNRUF6bUhNZWh4bjlVWE5Pd1N5azlRU3ZPQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cfb7216f-a037-48b4-8ee8-08da282988d3
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 08:40:08.2401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wRj41nujdnXFOfUFHrUosb5xC6GK5b0aL7zYu6hYf+v11954O2GgbRY2xSBG9q3Dv+K6/3BtEtdxvFl5+0gCQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2488

On 19.04.2022 17:40, Demi Marie Obenour wrote:
> This allows the ESRT to be marked as reserved without having to waste a
> potentially large amount of memory.  This patch assumes that Xen can
> handle memory regions that are not page-aligned.  If it cannot,
> additional code will need to be added to align the regions.
> ---

This lacks an S-o-b and perhaps also a Suggested-by or Requested-by.

As to the mentioned assumption, I'm of the opinion that you as the
author would need to check whether the assumption holds or whether,
as you say, more code needs to be added. Or else I think such a
change would want tagging as RFC.

> @@ -198,21 +199,57 @@ static void __init efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable,
>              type = E820_NVS;
>              break;
>          }
> -        if ( e820_raw.nr_map && type == e->type &&
> -             desc->PhysicalStart == e->addr + e->size )
> -            e->size += len;
> -        else if ( !len || e820_raw.nr_map >= ARRAY_SIZE(e820_raw.map) )
> -            continue;
> -        else
> +
> +#define ADD_ENTRY(len, type_, physical_start)                           \

I think the order would be less unexpected as (start, len, type),
especially when actually seeing the macro in use further down.

> +        if ( len )                                                      \
> +        {                                                               \
> +            if ( e820_raw.nr_map && (type_) == e->type &&               \
> +                 (physical_start) == e->addr + e->size )                \
> +                e->size += (len);                                       \
> +            else if ( e820_raw.nr_map < ARRAY_SIZE(e820_raw.map) )      \
> +                continue;                                               \
> +            else                                                        \
> +            {                                                           \
> +                ++e;                                                    \
> +                e->addr = (physical_start);                             \
> +                e->size = (len);                                        \
> +                e->type = (type_);                                      \
> +                ++e820_raw.nr_map;                                      \
> +            }                                                           \
> +        }                                                               \
> +        else                                                            \
> +            do {} while (0)

This is odd to see. What we usually do in such cases is to enclose
the whole construct in do { ... } while (0), or to convert the
statement to an expression, by enclosing it in ({ }).

> +        if ( desc == (EFI_MEMORY_DESCRIPTOR *)esrt_desc )
>          {
> -            ++e;
> -            e->addr = desc->PhysicalStart;
> -            e->size = len;
> -            e->type = type;
> -            ++e820_raw.nr_map;
> +            const ESRT *esrt_ptr;
> +            UINTN esrt_offset, esrt_len;
> +
> +            BUG_ON(physical_start > esrt);
> +            BUG_ON(len < sizeof(*esrt_ptr));
> +            esrt_offset = esrt - physical_start;
> +
> +            BUG_ON(len - sizeof(*esrt_ptr) < esrt_offset);
> +            esrt_ptr = (const ESRT *)esrt;
> +
> +            BUG_ON(esrt_ptr->Version != 1);
> +            BUG_ON(esrt_ptr->Count < 1);
> +
> +            esrt_len = (esrt_ptr->Count + 1) * sizeof(*esrt_ptr);
> +
> +            BUG_ON( len - esrt_offset < esrt_len );

Nit: Excess blanks immediately inside the parentheses.

> --- a/xen/arch/x86/include/asm/e820.h
> +++ b/xen/arch/x86/include/asm/e820.h
> @@ -16,7 +16,7 @@ struct __packed e820entry {
>      uint32_t type;
>  };
>  
> -#define E820MAX	1024
> +#define E820MAX	1026

Why?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:42:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:42:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314553.532656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdFx-0000hB-NV; Wed, 27 Apr 2022 08:42:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314553.532656; Wed, 27 Apr 2022 08:42:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdFx-0000h4-K0; Wed, 27 Apr 2022 08:42:41 +0000
Received: by outflank-mailman (input) for mailman id 314553;
 Wed, 27 Apr 2022 08:42:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njdFv-0000gv-OG
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:42:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fdf159e7-c605-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 10:42:38 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-PYhgKIAyPbiTLHHxK0L5Ww-1; Wed, 27 Apr 2022 10:42:32 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB5516.eurprd04.prod.outlook.com (2603:10a6:10:80::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 08:42:31 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 08:42:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdf159e7-c605-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651048957;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Wd/lS6DAzvGxXNKYuj+6202qrNiR9inebJj7nAq0WMg=;
	b=bBzdHNhkTD2tlwYy5pNrixSfPTTIyhrfas9VllOzjvxgKkJBJcWed1YZMIRJnnBKzU0WBc
	JY0Oyddlb94myBuZZ3JbiXH+JrGqpX558oy/fIjinqQ1QryMyA2WlW7CWTrl7xW/BXfYBd
	rpKmUC4zFHXKG3AcQobFpTihi2p1Co0=
X-MC-Unique: PYhgKIAyPbiTLHHxK0L5Ww-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nXHqLgEHOt0rnfe1GhPxF16ciy/sWVg4in7lCd945NrmkZ7xsxU8TO2tTgXPCergBnnnHPS8XB9aePhCDYRPJXdDGQfas+ocpcajpFx7K4cNUdGx7jYTsdXylyosZc9AIPYM6iflMrkYtQtjaqYUT3GlqEhlMTxdKfGI/1j0LViPAsdFOGjqRZN3uASDcjlPCAv9ZREVJvPqBHY8V3RKEV5nD0g/s+YH8uO214zOqxVw3lftsLFACoXVz+3H6IkXDWt3sa4ufO7QXTjXC+CmFAvBf/Xx83EFpw2iRHotCZeE7mp/Bmgmp5b2gV61XfwgIMT+BKqrOtOySxnRjEjlkA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Wd/lS6DAzvGxXNKYuj+6202qrNiR9inebJj7nAq0WMg=;
 b=gdXl8INe217FLIqvlqIOVdTYIyAMVV/2uQFw7oTEDmgZ4y0XBptfJs2q8eMzHhW3zoqoQGZ3L+ZGlNKMc/CFuV47IixHDGKRPri+tPaYDpbA4+FAaRLCfNlzB2wMORf8ZB3Xw4/mQNEd5uT7VkZZ4pdM2zBhUL8jmaEZUl28nnurwq4EsCeiNKnyI5mymUv2bg5rq0h5trvaSqU7ereGJR3vN129sSRAsPKFWT0POmAU4AWGxQZhyCruufo++ftamR/T1I2d4M/MhGt9LqjX962+BsFul7aaylnPwTTsJHecEYG6Mu1rDGGesp+qTch+zcV5ho614gPlHjjtUiYPiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0644ecd8-51cc-897a-5555-62d4c9ee9461@suse.com>
Date: Wed, 27 Apr 2022 10:42:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <Yl7WHv6+M+eJwQep@itl-email> <Yl7X3mAJhR5ENSpl@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yl7X3mAJhR5ENSpl@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0307.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::32) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8fd6251c-7ae0-49ee-d0b4-08da2829ddfe
X-MS-TrafficTypeDiagnostic: DB7PR04MB5516:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB5516F27DBDDE1E84574C684FB3FA9@DB7PR04MB5516.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oT9kvhrhbU0iu48A5RNUCv4TmQJs9ELNVr/w/0oWab+rRFZaThpqBhvZpFH58UJz9UAb76U0S4aHcUUjBuhN7qyCg3osvE8ECPkKJ6bEa+9aBku75yWWVI8Xdb7CyBi6GZeFtgIUTLUsfLRnHlUjUnoK3NtX14BzmwMRBg/XpU/7gD0WGoJmj7kkh0IUMFM1MX5kq6S+ZQlZChTdJ4cmQh0oE5EgE/A3P2/ZIKHd9ZiEZt75OAXgtHC32OsR41VG/XxIJjaGTV3YtnIAV8rofz4kJQpQIQ7+KaqNsCEs3q1CabeLtRlpIYqyDNCdb7VpE3cph5PFLQg+bLCZKXA9ZDQXGovsGWJgZnoURfUqXPC3ozmE1pV+d2We27Rn3HnC0LN+/j3oMRES3aKLCCXVree1mItsEAsfqpWdY1tXpp4SmdKvlgm2KD/R6ec+0fpm2G9ii45NIXpT1Pr9ZbTvQl5P+quwZAlM709wRZF3RYB09g1cpT/7WNQvVGYeN6Sq0u1WtYm9i5qBiXalQPbCYg1nSPddnb0um4xUG/3gjuJFNNCj2GVOyRRL+Gvs6uPRzyPHm/P1jYM3iDQKU7jB9dGI2mfnOXi1lDXocvBsKudTugvWQCG8HpLTL/+uAEYgVIvCe+jgEf4lyu2yywq1n8/cypdLOAtWI7wKtLJFarXpjCgRUpY1zPGE+RPfNSOgNaRQTng+cdbHCnGP1wJ+cmA1DO98H/PoA8zxaz6+w28NQ56zj7x+j5r3I8MeyMcU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(8676002)(2616005)(5660300002)(508600001)(2906002)(8936002)(316002)(31686004)(6916009)(54906003)(66946007)(66556008)(66476007)(38100700002)(36756003)(4744005)(4326008)(31696002)(53546011)(186003)(26005)(6486002)(6666004)(6506007)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RTkwWGZDaDFRWlpIU3B1NVA5QVhVMTduVXlvMGlpOFZYbUtKVW9RTzRndWZZ?=
 =?utf-8?B?aERPUWFTSCtMeG5jeFlOQnZzTkdpc1VOZ3V6KzVBVlN6MmpRbDJuUFFZTWN3?=
 =?utf-8?B?ZnJlbHI3SDBxcFczSlEzZytkeVBiOGVBZmlGYTFkZ3cvMXM4QVdHbTBISGpm?=
 =?utf-8?B?YXNGTTBmZ3JZdGJqdGs0anJqMG1paWpiWlgySVFCYW94ZU1tT3NPRld6RGlE?=
 =?utf-8?B?TDZOVWw3N2JRWmJCSnpOdmVJNStyWVpTdFBYeUZhbEhOSzhHYUMweXNkNUxj?=
 =?utf-8?B?alVRbFhVQUNYVFQvOEN6MFhVSllSR3lRMUoxazN5OE9CbnhXWUpOb0x0T01p?=
 =?utf-8?B?Z2VuL1BsLzN1QWZ4OHplUEZMRjlWdU5qUjJTRjZLTEtPZllkby9VZitjLzIx?=
 =?utf-8?B?a2FrVFJ6OFphbTFpa1VOeEFVTFRJRVFEY1pTaFBlZkhuVHFka2Y1cGVIS1Iy?=
 =?utf-8?B?NnpMQTlIZTZ4RXdhWlBJNm5XU3lrcmt5SSsyRnV4V3lmUDlZS1oycjQ1RlNO?=
 =?utf-8?B?M2V2Q1dKdWxuWTdGL1BKS0QySlRReE1Gb2ZDUkpab1Qvb0k1bnYxMzgzazRj?=
 =?utf-8?B?UlBjdElPU2ZrajVTY25JK0RrNzFYVlE0Rkx6aXdIMTJvL1NWZHRKY3l3QUJU?=
 =?utf-8?B?YXhjUFNyZG9YQ3l3MWFGRXJ4dGU5QUxWczYxUGFRWGFUdFRaNDQ4TW5zV2VP?=
 =?utf-8?B?VkFVVWNKY0dOTnk5ejI4QjdPek4rK1hibTk4MU5GOTROV2xST0ErN0VMaHFz?=
 =?utf-8?B?MEdtQmFHZ1NZSjVTM0wrcTFsOXFkb2NlMWJ1clVLd042b2dXOWNWMWtIeG4v?=
 =?utf-8?B?Q1Z6aGY1c3FhVjVsOTJOcGNPR29JSjRJKzlHK3ZMODRFeERuUzJqQlBDV2lQ?=
 =?utf-8?B?dHlHd3pqZGNMS1dIazBZanYzOE1CNm8vUGhlT2w2OHVCUk9IMy95S0cxTklr?=
 =?utf-8?B?Qk1IVEdPeHUrT203clRJb0dhcVNhL0NGMWFUWEpnUDVwZXlaNXFrbjB5M2pZ?=
 =?utf-8?B?VWVhSkh3dVFtYnFZMVdiY0xsYytTWW1UNXh0Y2llek1qV3Z6VVJLWm9GTFQ4?=
 =?utf-8?B?K29RTzEyeU91RTUyQXgwWTFCamR6QjVrcXhKT0srd3Rqb0puM1BxY3VhOHdl?=
 =?utf-8?B?dnVKNy9JaDZQQ1ArTWdZVEdBeGRIMWlFcTY2RnArTUZYS1FYOENULzA2d1pz?=
 =?utf-8?B?OXk0NnRDY05MdmxXSk5QNXc0ZTlKSFNRcitaNld5RitueUtteHpDaVk5dDdW?=
 =?utf-8?B?Ty9xc245S1EzRUpmWW9KUWxUU0xoaDFiOVJTQmlYaWdlNGdiY0IyNC83Q1Nr?=
 =?utf-8?B?UVZFc1hOTGVjelo1V0ZPczRjdmpvUjVRaGFJUHhpMlpKeXJpWXkvSzVXU3M3?=
 =?utf-8?B?WGxFM0JYc2NWMUZINlE0anVzelVHK1RxdFNoQmFTRHo4WkpuY1BaSldtc0F6?=
 =?utf-8?B?QkxnMzR1M0tEdFBTaTcyUkQrd1dMdTB2RENMc2J5T29VQWpnVkxGRWdJemti?=
 =?utf-8?B?UmFZdHZubE1rOTRWL0VIU0VZN1B0Mzg5Z3RpbEE2dTN3QU1Nc3MrQ1liWWFt?=
 =?utf-8?B?QnU1cUp4dTBVV3grN0ZURXhRS2JaU255UXJZUHUwRzJRVDhUUGtwajZaUXk3?=
 =?utf-8?B?eTBGTTlVRExxd3pWV2Z3TDdsVHkyQVBTVjd3QStNcnZySURZR216djUzOVB4?=
 =?utf-8?B?WkJTNG1xQ2xUOXJjUFZjKzlnRzBsQ3ZTVnlJMjc2ejF6WmhJZlh3bGQrcmJT?=
 =?utf-8?B?eTBBMFQzekpUeDN0U0tuemN5bVp3dnFPQWY1YVFCWitueDFpb0tmdkNUU1Nk?=
 =?utf-8?B?dkVoYm5WR2NGc1pDMEVtN1JEdkR3eHdkbTRWcnphTXBoZzdDRkI1VHJPL0ZX?=
 =?utf-8?B?MUtlRG1hS3ZBa0d5ZTY2cUFaUlJ5RTMybVVtRzJ3RmEvRVltOFZhQnBpb1o3?=
 =?utf-8?B?ZU9CQlJzRTBCcWtEd1RkZWpyOW01azNGMXR6N3FHb0Q1ZzZndVFvM3hjZDVJ?=
 =?utf-8?B?R3AxZ2lQVzBNclFBek56REFIck5KZHp6K09Jek1lMVFCWS92bjlzWE1pM1BG?=
 =?utf-8?B?KzlMeWJiOUhmS2IwSzYwSno0c0d4dmRQT1hHTkdSajYzbkw4VWFLZTV2dVVt?=
 =?utf-8?B?QXo4d1dNVU5KOG5ScDZrK1d1V3QxVFFWQWNTaUp0QjNBSWh4enVJVzZhQ3U5?=
 =?utf-8?B?WkNMUFpmSHJvRGxjdWZvelc4NEpkWk5pUlVCWElyeHRRUmd6YWVZeUxUVGVH?=
 =?utf-8?B?NTZ2ZThXaFR4RzJIVy9STTFkUjllT2VkYVJOSnJXVy80Ri9wUFNEQTY4SnNr?=
 =?utf-8?B?cGtncHZSWVZvbjd5b1hLRDlUdjRRV3VvVXlhbWs0S0NpOWdYTnJVQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fd6251c-7ae0-49ee-d0b4-08da2829ddfe
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 08:42:31.1143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w4xZJy1IvrjZpqI/Ns9uNySfNNBGBnewkQuHz8jzb6SKhbSCc6WLDWOs2FqWI+PuiVIBh58AFhh9OA5lrsjo0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5516

On 19.04.2022 17:40, Demi Marie Obenour wrote:
> @@ -1056,19 +1091,19 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste
>      EFI_STATUS status;
>      UINTN info_size = 0, map_key;
>      bool retry;
> -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
>      unsigned int i;
> -#endif
>  
>      efi_bs->GetMemoryMap(&info_size, NULL, &map_key,
>                           &efi_mdesc_size, &mdesc_ver);
> -    info_size += 8 * efi_mdesc_size;
> +    info_size += 8 * (efi_mdesc_size + 1);
>      efi_memmap = efi_arch_allocate_mmap_buffer(info_size);
>      if ( !efi_memmap )
>          blexit(L"Unable to allocate memory for EFI memory map");
>  
>      for ( retry = false; ; retry = true )
>      {
> +        esrt_desc = (const EFI_MEMORY_DESCRIPTOR *)EFI_INVALID_TABLE_ADDR;

Sorry, one more question here: Why is NULL not good enough?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:43:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:43:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314558.532667 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdHA-0001Gq-2t; Wed, 27 Apr 2022 08:43:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314558.532667; Wed, 27 Apr 2022 08:43:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdH9-0001Gj-V7; Wed, 27 Apr 2022 08:43:55 +0000
Received: by outflank-mailman (input) for mailman id 314558;
 Wed, 27 Apr 2022 08:43:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njdH8-0001GZ-Sn; Wed, 27 Apr 2022 08:43:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njdH8-0000rx-RE; Wed, 27 Apr 2022 08:43:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njdH8-0007MQ-Fr; Wed, 27 Apr 2022 08:43:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njdH8-0006ZM-FQ; Wed, 27 Apr 2022 08:43:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oft3j9mcOGXPIV8g5ZcH3fosc9gtHSZsZq8A+LqKe5I=; b=r43mSF8C+rAZEq70v45QAc239w
	NbhaX0Y9EqrKWXBaC2Ms/aMYmh87dJilq7IemtpVAJ9ZCDrH7NY5KyumXnrG44KJdjtWub2O1JGHf
	DcLJ3eUzvpjtxvVsSZ/wUTBx4PEKrdGO4LuWMga/Oymp4ef/idga4JtiCdA/Ld1lrJ04=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169772-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169772: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 08:43:54 +0000

flight 169772 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169772/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  658 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   30 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:51:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:51:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314567.532678 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdOD-0002jN-RO; Wed, 27 Apr 2022 08:51:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314567.532678; Wed, 27 Apr 2022 08:51:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdOD-0002jG-OF; Wed, 27 Apr 2022 08:51:13 +0000
Received: by outflank-mailman (input) for mailman id 314567;
 Wed, 27 Apr 2022 08:51:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8dk3=VF=citrix.com=prvs=109ad7ccf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njdOD-0002jA-2C
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:51:13 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2e424e74-c607-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 10:51:10 +0200 (CEST)
Received: from mail-dm6nam10lp2108.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.108])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 04:51:07 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BYAPR03MB4038.namprd03.prod.outlook.com (2603:10b6:a03:7c::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 08:51:04 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 08:51:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e424e74-c607-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651049470;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=bU/9Sn70oi4SD9AvXpyG3UJzes5PrW1s7e/YT2xyo2o=;
  b=gik0NKtT/i9qtJLkb7twvPK09oaqf1yGEYJjjH8Vjs7/4EDiK4viBWRS
   78dAdulIoM0x7Tlr4igko9RDiNCCxZ4PW1T/okRSZ/c3BYES8SNTQ9zsA
   ipOPKi1YB0zi1/JTr3R2Vn6p0GQcjUmbT4mNyqdJs4c8syIJ8K97xTbnT
   8=;
X-IronPort-RemoteIP: 104.47.58.108
X-IronPort-MID: 72476703
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:uyq+G6trxDl9gwQ2ku/ingCegufnVFNfMUV32f8akzHdYApBsoF/q
 tZmKTiCafjZYGrzc4siOYzk900A7ZSDy98xTFY6+S1jEShB+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X5
 4upyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8GE7zcwLkRVSUAGnBmLZ9I3eDNPEGw5Jn7I03uKxMAwt1IJWRvZcg037gyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5o1qiiHt6HD
 yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvDKPk1IuiOOF3Nz9edWGHfwPtGGjh
 nPK7Tr+PkBDd8fF1m/Qmp6rrqqV9c/hY6oRGaO58Lh2gVSV7m0VFBASE1C8pJGRmkO4Ht5SN
 UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JyOeAn7ACGyoLP/h2UQGMDS1Z8hMcOscY3QXkm0
 wGPltawXTh36uTNGTSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6
 2jihEADa38716bnC43TEYj7vg+R
IronPort-HdrOrdr: A9a23:LOPDn608itE8oJ3ujNSzCgqjBEgkLtp133Aq2lEZdPU0SKGlfg
 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5
 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq
 a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="72476703"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZlN5PrO6UYGb/C8dVTtRnRfEMaO0mN1UQjzRiLC2OdyT94UXmtZ6bNe9cmckdSYTCUCZBJUamqPRPiMAvFhi8BefGfMpGoiI/4UZU3yDcKwxv4D6cO7yy26AXbbBGR1y30l5HZN+O+rw1F1VuuGps2DmKjG/LE2Ojlurk4EEeFGJKvIec4O/25imdIFZqzJLQwfd1Z/kEJQiS31EdOb8KL30H3vF2SeLzoJm170ae+AkYvlTaEMfi3fbgfKwjm9qjDioTH+JgscErT9DampJsPdsNB85wwxBZLtgoTOogIWKnX5mBLHB118y5WCStPIADskPdB8G+lOWUfWINNB8rA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bU/9Sn70oi4SD9AvXpyG3UJzes5PrW1s7e/YT2xyo2o=;
 b=I+nyq7bCc3/oms19XeCzDpGIxH0Hnl1C9OIWoAf8AniqWHhHZ7HGVUcuT114C58RYj/qjbV5J+SwmgTxYOQQ1xlT0B8mCA9Vv6fLSFkb9/1yRCY44rQq5YBzerZeYtXzvndT/GOZxGk6sJOi7PeJPWPVJAn3aOpLkTTTUcoOJcIpeXi33V6LrHUxI4N4laKVbtfJeuZtPBAkohTvtXUICZZHt7tm0IPVW44mEfNgly92PI1cvDASDnP5uT6RggRc3JX1liQHtPAQIJFGPnPt5fhE1P//JOjc/SCecl7uKh7O2NxJVJxLLKTwg3jK3nglODPqpYrHldRyo93R5K/uFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bU/9Sn70oi4SD9AvXpyG3UJzes5PrW1s7e/YT2xyo2o=;
 b=jG6yYCwR7DIxJHb9is0+HknnuXEbQkdi6q/otxHHpxNI6iDQwvpq5Szg4ZguWXVYll6Vxa2M7yEcldkK/iVGRRakb0IOt2t/jAHQHZc54NyXkrHR1hEiPT2PnZvaTV7+M03QfxPIIIc9BTiSqm0SjkWhnQZE/3KKW+Y79E0D+KQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Kevin Tian <kevin.tian@intel.com>, xen-devel
	<xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, "Beulich, Jan"
	<JBeulich@suse.com>, Edwin Torok <edvin.torok@citrix.com>
Subject: Re: RMRRs and Phantom Functions
Thread-Topic: RMRRs and Phantom Functions
Thread-Index: AQHYWZZDIrEkmq9fL0+3qLNT2+7QyK0DHAnAgABYo4A=
Date: Wed, 27 Apr 2022 08:51:04 +0000
Message-ID: <3e5b0cff-bcc1-580a-1fd3-8e87d2d50b31@citrix.com>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
 <BN9PR11MB5276C91F31AA5119CD2B1B038CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
In-Reply-To:
 <BN9PR11MB5276C91F31AA5119CD2B1B038CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e7f0cd39-a6ad-4087-c594-08da282b0fd6
x-ms-traffictypediagnostic: BYAPR03MB4038:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs:
 <BYAPR03MB403816E4613B7DE46BFBDDF0BAFA9@BYAPR03MB4038.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 TYpMI8HCx+aC1Wc/ltwrqRCJlURDGtoSN29q2xdSMn9Io9nUtgj5E5oUWB+RU/DuvVoYZbXhig5u8YEZjL+EX6qT8e8cQ39HZ/0ulrd33RKR4xdTUZIDNmU97qm9XEooy3OHs+ZZxXtIq1xOP7eM/n89fEsi8yB7oCISheR8hHI28PuFAl01wijAGrGN8sRnNpNkMlzX7DB6ex8c5wQjR6LVR0xMYlpjAfkmIexyY8ilOu7Fwh9FK6q6owNUDf5B+MVKdQmPMk/J4RK9lxaDW6koQbG7xF3HSA3eqgjVqW9zlAL0lzNte9sPTWslkk0tRmEXHTGNcUQvDMERJzA0GQZM3EvC1DxbSfH5+xelEdN0vSXrFAoU7TH+DQhn2frg86xUk9xvF7xsaSubt/l5YMensPESjhD5GCmnN23PJQup2Z/GMi++Psr5alt/DGbi11TZ5QwzoYBseb7Mu7unuSAqmd+YS6zs9d8hK6T5r4Zy3TTWjwORYn7wHfuXF0ZV3+7lYjtrFNXjnivjfnIF59LA36ku5uJvKKiaUnX52Z+gaQy3f3hy36Gx62yLVO73HrajLwXkA3S2rJI1qQzQVmAeN4uQa0qBgen3QnBhN65T/dr051PQjBzAcgyhvK59OesSH6Prfbb5d5fTY7lusvhWIh8U0akDoN1G1p+dJcqAjvA3qjGgY0txH49Gb+Dwv0U5qrpZv6sjbjTPa3wKK6sGwPxE5DaDGkeRX02JBNjN7irC7rqgoiNXwTVwn2La5XL1pgvHSiHVEpcgJo8y9Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(2906002)(5660300002)(6506007)(54906003)(38070700005)(38100700002)(6512007)(26005)(31686004)(8936002)(36756003)(107886003)(2616005)(83380400001)(186003)(6486002)(508600001)(3480700007)(71200400001)(76116006)(66946007)(91956017)(86362001)(316002)(31696002)(64756008)(66446008)(66476007)(66556008)(8676002)(110136005)(4326008)(122000001)(82960400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?eXlKSGFNcjdOWGZTUXJSN1ozdWw2cUlDMjRvWml3dXJwTkNCaEtYTUxvRVl5?=
 =?utf-8?B?d3AzWkRSQlJuTHdDdEcySlltTkp1bVZSV1FMOU9VMnFWc3FRajEwUUM0L01l?=
 =?utf-8?B?cGhucmFsN2NHR0dacXFWemtLR1psd2cvNGJDaU5NL3FLazRod0Iwb3pvZkJI?=
 =?utf-8?B?VWUwVmczYWJibU8zT0hLZmdpMm1vTzNxRXF2amE2NDlrVjNja2VsdEZtdzYv?=
 =?utf-8?B?cFdoU1RUcStVRzVSODR1MEFmV28rYVA0M0d2R2crUVhOLzZxanFCbmMrckhD?=
 =?utf-8?B?NmlGOVlOdWRVM005aUE1WmZTWWEyOUVkK2tNWURDYXdSa1A3UUlTY2wyZDR0?=
 =?utf-8?B?M2ZKTmVpRDVQKzBMN2lWUHBmM1QzazJJUXNoZWo0YjVNL0N1NEpEUjZxZU1Z?=
 =?utf-8?B?U0VoZ0dMMXp3ZzQ2Q0JabXk0NVU5bUR0WWNHYlNwL3NHTXpEZFNjeVhQd243?=
 =?utf-8?B?N21Vb0R0WWpZV3NRM2didzllZkdJYzROeDVsQm5GcmNCblFHSTlMc1ZEd1hr?=
 =?utf-8?B?UThtckdVMEhmczVrb0NISjNyVEZaREVmRnI1aDQ2K28vUWltcm5vanRmWkJu?=
 =?utf-8?B?Sys1VE9ySWU2MkFHUGhJRnFzRGVPYW9kMmh4Q1FVejUybk8zc3MzVlFsR1Qw?=
 =?utf-8?B?NkdmWUZYRVdpZHU0bFl0ODR0VlVrVE5QQXZGajFGNUV6Qm00ZnpQdkJKL0E2?=
 =?utf-8?B?ZHFGeUJScUI5cm5pc3M4Qmp6V3lES3pTbkN0eVY0VGZEM2F5NEtpZnFieTVE?=
 =?utf-8?B?cnJPT1ZYU2trN1d4bzd1bkh4NzhxNnlDUklVSWZ4MWswaUQrY0VIRkRVZytp?=
 =?utf-8?B?d0VKWWcrazE1VXpnTnMyMllsWm1ORThseUFQY2pnMVFnU0dMVjVVUCtrMlNh?=
 =?utf-8?B?cERWU0l6NU5IYjJPOCtDRlpYenBSYmlBQjE0cXgwRzJ3eE1xc0g0bEt5VERi?=
 =?utf-8?B?aEo0ODZ1SEhtaG5BdUxuNWp0YjJPaE1jMlJORGkwMUx2N3hqWm0waWVSbFVv?=
 =?utf-8?B?dnRvQWZuQlF4eHJBaDEwWEh3MmVya1ZjaTJrbnlmZEFKdTFyUVJaOHFJTzZH?=
 =?utf-8?B?ZE5ZSW55TEh5a21CK1NUZ3lXcFQ2bDNud3FKN2NMV1RLVUtCc3BySkJjeVlZ?=
 =?utf-8?B?aGNLK3N6NW8vb0FkR01XdGxVWTVzaVp4cm85ZlI5cnc2UzRzYy95d2ZJNkxQ?=
 =?utf-8?B?VEMzWENYNk1yK2w0R2ZyVWFlNVJ1Um1pN2V3T2pWYm9HNHJmLzNReDJWdnNE?=
 =?utf-8?B?cUJsbk90Mm5ac3crN1hlRXcwTFBqQkVuRWg1NndJTzF5bFRHUG4zZ2Fxdkcw?=
 =?utf-8?B?Zi9tMktUT2xueGVqSmV3T1UwYWJjQVBDMFBpQjBaYTRJeTB1NFpKOHNZUjRL?=
 =?utf-8?B?WEVWejAyMkZOVG9VUWhCN1FqWENyVmFnNnFkeUc0SllvVkpXRWVyN3plc2xK?=
 =?utf-8?B?cjJIVmNCYjc3aGc4bk1wV3duM1VBc1BSc2F6bnBacWlBaGEzeFpKUDVxU1gv?=
 =?utf-8?B?MGZUQ3pvUFN6OUdIZjVMdzN1ejB4VVY5c1I0TUxSalUwbE9NNUU4NWN0WFFT?=
 =?utf-8?B?TU9kbjdlUWJyRlEzZnlqZ3VMM1NUWFI1MUwyQ1lPSjMwaVdaZDl4bjhCdkt3?=
 =?utf-8?B?eC9qaTNWNFJoYTJuSVYrMGxmL3k5Qisvald3TGFIaWJPc1RIZVhWYVdHT3Fk?=
 =?utf-8?B?MHpXWjRrTWFmYWhaL1FteVh4VXF4Q3dCRzNGeUU3QUROSEFvSC84S21VNUlz?=
 =?utf-8?B?MDUxUWhHcmJmc1RPNXYzQmsxNVllYjZWNkNVY2hsY1J2SlJvMm11cEhIaTNN?=
 =?utf-8?B?NHcxMi9BUFowQTVDdHhET2V4Nk1HUjI1Nkp5UjdkWlIxcE5jYTloOEY4WGda?=
 =?utf-8?B?NllaT2ltRVNhSEpiYUJ4TUVzN2toRng1K0UwNU1RbjVvMTZoakZCTzk5d040?=
 =?utf-8?B?MEM5cXlBRU5KUWhzRkIzK3RsWlh1bzhFQWprc3o0RUxOdnNyMTlQSHhwSXJO?=
 =?utf-8?B?bklrZzk0S1V2NEVVcmMvU21iSnQ1QUhOZkhBd0I4eUI5bGkzbnNFVUlOTE5j?=
 =?utf-8?B?Z0NXV3B6MWV2MEp6d04yL2lWZGlqRUpCK08rRmVrZWNYR0xDdkQ0OGZoSVoy?=
 =?utf-8?B?ZE5xaGI1OTBtK09xUzJRaGJvdXZ6ZnpCR1VDQUs1N2lZZGxyZWVIU2FlTmU0?=
 =?utf-8?B?SEZ4bnp5UW9zY0orTVFEUUwvRlFlcGZDOXJoOTUzbTdrWGhyaDJhcE01aGpC?=
 =?utf-8?B?U0RnOGwrcWthcFI2TWVmbG5EQTZxZEVLZm9SaDZHanBPOXpra016ZUdBd1h1?=
 =?utf-8?B?K3JSdGp1cjJIY3pheFRYNkM2UVBvVzUyN0o5dWkrMVNPanZOTFJPMEcySmtj?=
 =?utf-8?Q?VMmYg3DnnVffWWhE=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FCC06F06D4A7414C83044B1642F0A27B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7f0cd39-a6ad-4087-c594-08da282b0fd6
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 08:51:04.0159
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BimzCMDgMX43qx3yQq+61f8SaT/gWCbueoGFQ4sF+NEkTl5CjI2gSMtMujh1xwHnOhczS1/l/eLky2JlKOBkOAfILfeve3FxTChnc60N8sM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4038

T24gMjcvMDQvMjAyMiAwNDozOSwgVGlhbiwgS2V2aW4gd3JvdGU6DQo+PiBGcm9tOiBBbmRyZXcg
Q29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPg0KPj4gU2VudDogV2VkbmVzZGF5LCBB
cHJpbCAyNywgMjAyMiAxOjUyIEFNDQo+Pg0KPj4gSGVsbG8sDQo+Pg0KPj4gRWR2aW4gaGFzIGZv
dW5kIGEgbWFjaGluZSB3aXRoIHNvbWUgdmVyeSB3ZWlyZCBwcm9wZXJ0aWVzLsKgIEl0IGlzIGFu
IEhQDQo+PiBQcm9MaWFudCBCTDQ2MGMgR2VuOCB3aXRoOg0KPj4NCj4+IMKgXC1bMDAwMDowMF0t
Ky0wMC4wwqAgSW50ZWwgQ29ycG9yYXRpb24gWGVvbiBFNS9Db3JlIGk3IERNSTINCj4+IMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCArLTAxLjAtWzExXS0tDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgKy0wMS4xLVswMl0tLQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICstMDIuMC1b
MDRdLS0rLTAwLjDCoCBFbXVsZXggQ29ycG9yYXRpb24gT25lQ29ubmVjdCAxMEdiIE5JQw0KPj4g
KGJlMykNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCArLTAwLjHCoCBFbXVsZXggQ29ycG9yYXRpb24gT25lQ29ubmVjdCAxMEdiIE5JQw0KPj4gKGJl
MykNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAr
LTAwLjLCoCBFbXVsZXggQ29ycG9yYXRpb24gT25lQ29ubmVjdCAxMEdiDQo+PiBpU0NTSSBJbml0
aWF0b3IgKGJlMykNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBcLTAwLjPCoCBFbXVsZXggQ29ycG9yYXRpb24gT25lQ29ubmVjdCAxMEdiDQo+PiBp
U0NTSSBJbml0aWF0b3IgKGJlMykNCj4+DQo+PiB5ZXQgYWxsIDQgb3RoZXIgZnVuY3Rpb25zIG9u
IHRoZSBkZXZpY2UgcGVyaW9kaWNhbGx5IGhpdCBJT01NVSBmYXVsdHMNCj4+ICh+b25jZSBldmVy
eSA1IG1pbnMsIHNvIGRlZmluaXRlbHkgc3RhdHMpLg0KPj4NCj4+IChYRU4pIFtWVC1EXURNQVI6
W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZpY2UgWzAwMDA6MDQ6MDAuNF0gZmF1bHQgYWRkcg0KPj4g
YmRmODAwMDANCj4+IChYRU4pIFtWVC1EXURNQVI6W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZpY2Ug
WzAwMDA6MDQ6MDAuNV0gZmF1bHQgYWRkcg0KPj4gYmRmODAwMDANCj4+IChYRU4pIFtWVC1EXURN
QVI6W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZpY2UgWzAwMDA6MDQ6MDAuNl0gZmF1bHQgYWRkcg0K
Pj4gYmRmODAwMDANCj4+IChYRU4pIFtWVC1EXURNQVI6W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZp
Y2UgWzAwMDA6MDQ6MDAuN10gZmF1bHQgYWRkcg0KPj4gYmRmODAwMDANCj4+DQo+PiBUaGVyZSBh
cmUgc2V2ZXJhbCBSTVJScyBjb3ZlcmluZyB0aGUgdGhlc2UgZGV2aWNlcywgd2l0aDoNCj4+DQo+
PiAoWEVOKSBbVlQtRF1mb3VuZCBBQ1BJX0RNQVJfUk1SUjoNCj4+IChYRU4pIFtWVC1EXSBlbmRw
b2ludDogMDAwMDowMzowMC4wDQo+PiAoWEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDE6MDAu
MA0KPj4gKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAwOjAxOjAwLjINCj4+IChYRU4pIFtWVC1E
XSBlbmRwb2ludDogMDAwMDowNDowMC4wDQo+PiAoWEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6
MDQ6MDAuMQ0KPj4gKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAwOjA0OjAwLjINCj4+IChYRU4p
IFtWVC1EXSBlbmRwb2ludDogMDAwMDowNDowMC4zDQo+PiAoWEVOKSBbVlQtRF1kbWFyLmM6NjA4
OsKgwqAgUk1SUiByZWdpb246IGJhc2VfYWRkciBiZGY4ZjAwMCBlbmRfYWRkcg0KPj4gYmRmOTJm
ZmYNCj4+DQo+PiBiZWluZyB0aGUgb25lIHJlbGV2YW50IHRvIHRoZXNlIGZhdWx0cy7CoCBJJ3Zl
IG5vdCBtYW51YWxseSBkZWNvZGVkIHRoZQ0KPj4gRE1BUiB0YWJsZSBiZWNhdXNlIGRldmljZSBw
YXRocyBhcmUgaG9ycmlibGUgdG8gZm9sbG93IGJ1dCB0aGVyZSBhcmUgYXQNCj4+IGxlYXN0IHRo
ZSBjb3JyZWN0IG51bWJlciBvZiBlbmRwb2ludHMuwqAgVGhlIGZ1bmN0aW9ucyBhbGwgaGF2ZSBT
Ui1JT1YNCj4+IChkaXNhYmxlZCkgYW5kIEFSSSAoZW5hYmxlZCkuwqAgTm9uZSBoYXZlIGFueSBQ
aGFudG9tIGZ1bmN0aW9ucyBkZXNjcmliZWQuDQo+Pg0KPj4gU3BlY2lmeWluZyBwY2ktcGhhbnRv
bT0wNDowMCwxIGRvZXMgYXBwZWFyIHRvIHdvcmsgYXJvdW5kIHRoZSBmYXVsdHMsDQo+PiBidXQg
aXQncyBub3QgcmlnaHQsIGJlY2F1c2UgZnVuY3Rpb25zIDEgdGhydSAzIGFyZW4ndCBhY3R1YWxs
eSBwaGFudG9tLg0KPj4NCj4+IEFsc28sIEkgZG9uJ3Qgc2VlIGFueSBsb2dpYyB3aGljaCBhY3R1
YWxseSB3aXJlcyB1cCBwaGFudG9tIGZ1bmN0aW9ucw0KPj4gbGlrZSB0aGlzIHRvIHNoYXJlIFJN
UlJzL0lWTURzIGluIElPIGNvbnRleHRzLsKgIFRoZSBmYXVsdHMgb25seQ0KPj4gZGlzYXBwZWFy
IGFzIGEgc2lkZSBlZmZlY3Qgb2YgMDQ6MDAuMCBhbmQgMDQ6MDAuNCBiZWluZyBpbiBkb20wLCBh
cyBmYXINCj4+IGFzIEkgY2FuIHRlbGwuDQo+Pg0KPj4gU2ltcGx5IGdpdmluZyB0aGUgUk1SUiB2
aWEgcm1ycj0gZG9lc24ndCB3b3JrIChwcmVzdW1hYmx5IGJlY2F1c2Ugb2Ygbm8NCj4+IHBhdGNo
aW5nIGFjdHVhbCBkZXZpY2VzLCBidXQgdGhlcmUncyBubyB3YXJuaW5nKSwgYnV0IGl0IGZlZWxz
IGFzIGlmIGl0DQo+PiBvdWdodCB0by4NCj4+DQo+IFdoYXQgaXMgdGhlIFhlbiB2ZXJzaW9uPyBE
b2VzIGl0IGluY2x1ZGUgSmFuJ3MgY2hhbmdlIGZvciBwZXItZGV2aWNlDQo+IHF1YXJhbnRpbmU/
DQoNCkl0J3MgYW4gdXAtdG8tZGF0ZSBYZW5TZXJ2ZXIsIHNvIFhlbiA0LjEzIGJhc2VkLCBidXQg
eWVzLg0KDQo+IGJ0dyBpdCdzIHdlaXJkIHdoeSB0aG9zZSBOSUMgZGV2aWNlcyByZXF1aXJlIFJN
UlIgaW4gdGhlIGZpcnN0IHBsYWNlLi4uDQoNCkl0J3Mgc3RhdHMgdG8gdGhlIEJNQy7CoCBUaGlz
IEVtdWxleCBjYXJkIGlzIHBhcnQgb2YgdGhlIGRlZmF1bHQNCmNvbmZpZ3VyYXRpb24gb2YgdGhl
IHN5c3RlbSBmcm9tIEhQLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:53:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:53:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314574.532689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdQY-0003OU-BP; Wed, 27 Apr 2022 08:53:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314574.532689; Wed, 27 Apr 2022 08:53:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdQY-0003ON-8Q; Wed, 27 Apr 2022 08:53:38 +0000
Received: by outflank-mailman (input) for mailman id 314574;
 Wed, 27 Apr 2022 08:53:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njdQX-0003OF-2O
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:53:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njdQR-00012C-9X; Wed, 27 Apr 2022 08:53:31 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njdQR-0005z0-2N; Wed, 27 Apr 2022 08:53:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=LQto5+T4vhDW1jL85sCepWhHMkn7MmtO53Pn/SK4/G0=; b=Y83yQ49vn9Qb6LawcYuIfTOU1l
	8OvqRr9LCIiBuSF7KfKlnJAlMk2oC7S8852tETGomMu6/FFx8r2HAh+owLb34y1y8gM+lWWSWSw7h
	syuqWt/RGSlQ4oadF0419fa1DG8jgvIqdEZpN7ZiiyglTGlqNETKWrO7ZjIrNH5CvG34=;
Message-ID: <50127f0d-121b-4e9f-b5da-d78cdb41f8fa@xen.org>
Date: Wed, 27 Apr 2022 09:53:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH] xen/arm: alternative: Don't call vmap() within
 stop_machine_run()
To: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 David Vrabel <dvrabel@amazon.co.uk>, xen-devel@lists.xenproject.org
References: <20220426200629.58921-1-julien@xen.org>
 <0aacc53d-279f-2e0d-b495-217133e75e03@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <0aacc53d-279f-2e0d-b495-217133e75e03@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 27/04/2022 07:42, Jan Beulich wrote:
> On 26.04.2022 22:06, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap
>> alloc/free" extended the checks in the buddy allocator to catch
>> any use of the helpers from context with interrupts disabled.
>>
>> Unfortunately, the rule is not followed in the alternative code and
>> this will result to crash at boot with debug enabled:
>>
>> (XEN) Xen call trace:
>> (XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
>> (XEN)    [<00000000>] 00000000 (LR)
>> (XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
>> (XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
>> (XEN)    [<00236864>] __vmap+0x400/0x4a4
>> (XEN)    [<0026aee8>] arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
>> (XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
>> (XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
>> (XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
>> (XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c
>>
>> The interrupts will be disabled by the state machine in stop_machine_run(),
>> hence why the ASSERT is hit.
>>
>> For now the patch extending the checks has been reverted, but it would
>> be good to re-introduce it (allocation with interrupts disabled is not
>> desirable).
> 
> We definitely should re-apply that patch once the one here went in.

I have commit this patch and also re-apply David's patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 08:56:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 08:56:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314583.532707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdTV-00048B-TN; Wed, 27 Apr 2022 08:56:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314583.532707; Wed, 27 Apr 2022 08:56:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdTV-000484-Px; Wed, 27 Apr 2022 08:56:41 +0000
Received: by outflank-mailman (input) for mailman id 314583;
 Wed, 27 Apr 2022 08:56:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njdTU-00047y-MD
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 08:56:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f382204f-c607-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 10:56:39 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-tPPjMRP9Pju0xuilONgCQA-1; Wed, 27 Apr 2022 10:56:37 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB5073.eurprd04.prod.outlook.com (2603:10a6:208:c9::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 08:56:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 08:56:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f382204f-c607-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651049799;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hJgAgIyE6IlrZhdygWFn95C0pk/xjUHBEyq+DZ54MXk=;
	b=NKB/gsrSGGZdVpBR3Z9RdUX1YWPKSJE/Ai1a2MLow09Gy2OJL7kpFbO4sPSwjziDCkGddT
	3LDD21OPxK5tJswCjS5smIix4zb5OyaTUyHhZ0mTwP/Srsn86iEvpI3ja4vlaJvYNphmDS
	TEdl74JIf93ronPvn0eJJD+rYjkAXZY=
X-MC-Unique: tPPjMRP9Pju0xuilONgCQA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iCxXrY3GClAJp5Nb0zrLSy5WOoiFLpiCN9ayP3WqmUEjRY74aX8XfAxy+p0kjmR7SsGfy5hoVwJbpDI5AgIkV0gaLkyHhbaw3NlipZDNtQPdCx4Orb/VSu4lazXa9Rx2AvOAbaQVfQXbfqxLtJe8VOe2Idinvvma9nYryzhPxfnpr7VLfhtVcT/GpV8qAkMbRGDkFnCMzg7gbTn7bnSLuLxcY+0v/BM8ObuEu72jUS1iAZXAkiIVBCw2I9k43DDQSDe7WeYPZi+6CEYSzDz2oxmtEemuoK7y+7GlMaRQElhaR7ErFiVRMa4JNC3RbGLxbQfzDVYYySQNXBdwwE91iQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hJgAgIyE6IlrZhdygWFn95C0pk/xjUHBEyq+DZ54MXk=;
 b=X9pM+IBRF7beYmeZY6eG6sKQiSRadjkKb/EMmVckHGgv3ydBJt9vEzbTRXN1+R/VZFcjwfDLRLl8eWifc3QXcAcgrZI8V7Siqbw4MLCTjBUGkdDSMDWlSywZjxcHQXSZfaJf5QtQbq9NhVoZH6V0I2wHIuZIwL+1krzPBQJpMEdL1gxFVbGMeAh33tsxSxdt3fwYFhqhqXhZAiJB1vGvgddBJjNXpOiLkYb0HAgL6et4lvAPEFnvBEilV9G9229mWkJGLp1VgJHD6V1HbC9piFFsMWHViXnNbFO+uZxBDnnvKFhDEjs3zYT9kYwxlmMSCMUfOZEValqGktxq0SN5iw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com>
Date: Wed, 27 Apr 2022 10:56:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <Yl7aC2a+TtOaFtqZ@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yl7aC2a+TtOaFtqZ@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0311.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::8) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d1ff8997-821f-458d-90a9-08da282bd5a6
X-MS-TrafficTypeDiagnostic: AM0PR04MB5073:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB50734320D0F6ECF626147CAFB3FA9@AM0PR04MB5073.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	67CsV9Wd0oJD2AXNHBlpBqsGHXiSTyTq4jRb9mwVWC1NJg9clW1ItEjZ08Em4Alkcm/xkJfr+8SGfwwB8BYA6fCFkHQvl1UAfE4awQyWVaeZt4tu8nMYH2KLdZlHeGO+bLVD00KwPEM8zznp8TvnUIsQb0UNv7EuV6aGt90PRm4OOfD4efIFMr57j7SgSVc36Dk81MynZZO12/M3gE0HaYdt/mVQ3DLZD8iHEVYeM0p7mr3ixls8mdN6D7aK+N4Re51P8R+krVuO9RQezy3DoDvSYcyUrHOtYsz90FOml0jAOlQLQFbdTZBnMOtUuiwVluPZYKA9SR94ozjET1y0Iktu61ptM+qdhrfk13cRZMIiLulIvkJhH9S+htTnNv0H+PuoX77O/IDPA38Zi21aD/TiZ0kDvxX8r5dfz2TT2wUZQwKf8HvWMMrZYfSVBH4Z12gbfV+ROlvhGg7rY9DgPYbDDLPMoazBDR2UipN6c7C2xe8pSfnqCvWaYNt0Aqdw3caz0YPgTp6tY++46v2M4Fr5eYrxJC09ouqgl8LEtJHAXJlrE96N9lyLC1XpFcL1EBMvOp4x/wUJ9cfqVIYGlZOjnLEleItjVw05v9A4q7LoTfMxUFJOXdo/Q6+zBAue8g5vekXOuYE8f07k7BB8g8cf111kPJxmRTdNoGc6XAPF4+iwC2/DeaTDPBi+3HL/LT+PCIlcYoMj4jIPMlhJUcD0vocyfRmckAEAhuTEEdqogAWj4uKpaBxtVtRuJTNTOuCNSln3b9Usn3zz5R7Sow==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(83380400001)(6916009)(54906003)(53546011)(8676002)(4326008)(2616005)(31686004)(316002)(186003)(66476007)(66946007)(36756003)(26005)(6486002)(66556008)(4744005)(2906002)(508600001)(38100700002)(6512007)(5660300002)(6506007)(31696002)(86362001)(15583001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b2toSmh6RmNwUzN3c1NnR1JxcERZbTU5bm9XdjNDYk0xaWNpM1daQk9QR3lS?=
 =?utf-8?B?eXc5OWJGNjFKRjBJbmlGNHpmelRFSXU0OGhmMmpPTVVRdG51K0lkTUhNSUh5?=
 =?utf-8?B?RmVKbEMyK2hFYy9xUzN1blZ5bDdLeWJHQUdtL3haN2tqb2swK1d6VlZWTi8x?=
 =?utf-8?B?WTdYdzhBazdHcFZTaHF4KzhIWGo5ZmZkcVZUR1IzOVk0bExZenI5TzNoeTVt?=
 =?utf-8?B?QlhXalR0REF3ODNSUWJka3hmRi8rUkI0UmxRZHliNHVpRXlJQzdWUEEyTVNz?=
 =?utf-8?B?NkwxTWMrTlJhazZPdys2cm1JZC9mMGVvVjQ4SCtYNTlZVXY0YlB2VzlyVFU4?=
 =?utf-8?B?OE5GUDZraFJqTWhDbGVmSENpb2VmTWVaYmk2RkhDUHUra1owTWFIdklGTnZR?=
 =?utf-8?B?TzFLeGcxc201SXg2eEVaUVpEZ3B4R3RJQnRnVnVNdFZndWFhTWFBNDhISVJ5?=
 =?utf-8?B?eUl5SE5LRGdFSkhISElxUzBieUdkUTluMDRWeWRRM2tYWHhlYW0yMnJKcHV1?=
 =?utf-8?B?K0NSK05MTHdKY3ZkSEJYeGdwQ2U0M2cyYkJlSVFhMGZ0K0VVK0U1SnNjbnRt?=
 =?utf-8?B?Y21qL0I3UENIKzBPUEhCeXNSU29YRjJmVlpJZ2RvNzNpS2FtMWZkQWR3RGxM?=
 =?utf-8?B?Wi9CK1ZxWkg5TFBPQkFhdkNzSSt6LzkrTjBHeDNyY2I3c1lnT2lERXBqQnNs?=
 =?utf-8?B?M2dreWxTdlhYTkJMb3RVUWtuY0R1NEZzK0FMQTI5MStTNVpVeWFGR3ZldzNE?=
 =?utf-8?B?NEN0TWwyUkZmQ1h3U0xSWVNQZzVaSG1SNThUeDhuMmMwWUFyZUJuWmN5SEdK?=
 =?utf-8?B?S2RDVUJFVGk2Um01ZHBnOHR5aTNXYmRZeGhkNnU3cTY1WXJBTEVjRWR0eG13?=
 =?utf-8?B?R2w2WGNZMkR1RXhjdUNIYWJGYWRBL0ZaczVhUUF4em9EdXBnWW5pSTlqeW1R?=
 =?utf-8?B?ZGxSbkd3SWduK05pOCsxSFI4bEk2dFZLaTZBTmw0ZC9CNFlFbEpXQ3FDSzU0?=
 =?utf-8?B?TnlXRXlLTDhxeUpNVzBlc2JZNGRaS0t0SmppUWtZRGJobXV1SE02bDRTZFY2?=
 =?utf-8?B?WUdzN0lUWm5XU2xDaVdERUtUVW1zSWQwZS83QzdjNmNEdktvYVdvOVlCNk95?=
 =?utf-8?B?OUkyUDBOVkM3VWVmcUdUN0hkR3AvYVVvSDZ1VENqZlkzK3JTcHRQeGEyMU5s?=
 =?utf-8?B?cklDbHQ3QzlGeGVtZnYxWS9mbFJlQjdUTVBJbnBIMSs2c0JMSDYxK2JCNVVh?=
 =?utf-8?B?RjFoMEFTdUlibE16d3N5cEFldjU5QmFZWHQ4d0dWSFlsSjVBeHBRMFN5QlNG?=
 =?utf-8?B?Wk9va2dUb2c3ZUZ6dFRNbEtiU0g4TnV2Zi84cXZlS3dlWGVCeTBkOG0zRXJX?=
 =?utf-8?B?T2ROY0ZXN284ZGVKUkZGWngxVkdJME9CS1NXSElEY3lRZ0g3cFVGMkkzdHpO?=
 =?utf-8?B?WFI2T1BkYzd2UDlpOFJGQlFBU1NSMXFvSnVreGxwenhERkV5TjJTaFV2L1VU?=
 =?utf-8?B?b0xFQzNOWWhwbEZub0FYelZ6QW5JRGFkM1JwZmlDVm85VjdUQVc3MFFjVGdP?=
 =?utf-8?B?a2plWGgrVzZiVnRqS0RKakhUYWI5aHVPdnVoU2xvTXI1bVY0L0NTdVY2akxu?=
 =?utf-8?B?MW9QaVlGR3hoZFdlT0lpZWEvdW1NSklnWXRzdGZNNnd2amFLaGxEQTBMa1JW?=
 =?utf-8?B?R29qWHdMSEFYNTNSdFk1Tm1iWFQxNkZGWjN1czdQbDJBS1Q3eGFuT1hYdkpk?=
 =?utf-8?B?ZUxhcXZNeTEvT2VRVTNDT1BvK05jakFocUJMRnZEZHR4NUlEamlZU3RqSmJW?=
 =?utf-8?B?WGZnc2I2NjVRTlA0MGdxWC9sem9zOEFKMzFsQ0hNbnkyWGVMYWY0MmFzWnZk?=
 =?utf-8?B?S1REWjczWm9Fd2pYc3ZoeTNSTVR1RTR2NENZdzVLb1pORGs1K0FoNTFTWXYw?=
 =?utf-8?B?TDJNZVQ4cTJ6MVM3UzRXRTE0M0w1ODMzV01wQ1h2eWFzRmRCREpKSkFWMWw4?=
 =?utf-8?B?M1dJc1FQY0JGMFA0ZE1jQWo4RTA5b2hOYTRrOVNvMnRHL1ZiNnlQY1Raampj?=
 =?utf-8?B?eHlOdXpYenNLVVpFazhGQ3ZDSUQ1WEswMTl3OTExamxmVGVqYzdNbEg0eHd4?=
 =?utf-8?B?OEd0c2lnZFJmZVFFLzhlV0dFZlpJVlVqUFZhejNxUzk3S1BUeE00OTRPTmE0?=
 =?utf-8?B?eks4MkY5TGdlSklsUzFkOFBRZ3N5eHlwZmRZNlRpSEZzVlEyVDYxdGZhNGYw?=
 =?utf-8?B?UndPdW9xdy9md2JVcklwMHJuZnRBRlZIU3g5YjNBejV0WTMzQ3M4OTlrc1g5?=
 =?utf-8?B?QXVxMHVhdlJ2MFA3QXJBdTdXZjdLcDRCanUvbVJOVWpVSG5TZkR2dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1ff8997-821f-458d-90a9-08da282bd5a6
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 08:56:36.0451
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XUck6YmjK9SLYi7myMzsVZK77UYIkVPcf5Gq+Ofv2oXJ8lVRzGxPee+osfft4BQ4q/pZrFlLX1RvO6r4AHfj/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5073

On 19.04.2022 17:49, Demi Marie Obenour wrote:
> This hypercall can be used to get the ESRT from the hypervisor.  It
> returning successfully also indicates that Xen has reserved the ESRT and
> it can safely be parsed by dom0.

I'm not convinced of the need, and I view such an addition as inconsistent
with the original intentions. The pointer comes from the config table,
which Dom0 already has access to. All a Dom0 kernel may need to know in
addition is whether the range was properly reserved. This could be achieved
by splitting the EFI memory map entry in patch 2, instead of only splitting
the E820 derivation, as then XEN_FW_EFI_MEM_INFO can be used to find out
the range's type. Another way to find out would be for Dom0 to attempt to
map this area as MMIO, after first checking that no part of the range is in
its own memory allocation. This 2nd approach may, however, not really be
suitable for PVH Dom0, I think.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:00:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:00:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314589.532719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdWs-0005WK-CX; Wed, 27 Apr 2022 09:00:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314589.532719; Wed, 27 Apr 2022 09:00:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdWs-0005WD-9Q; Wed, 27 Apr 2022 09:00:10 +0000
Received: by outflank-mailman (input) for mailman id 314589;
 Wed, 27 Apr 2022 09:00:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njdWr-0005W7-5G
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:00:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6fd47819-c608-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:00:08 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-V9ehCNQAPh-eT3EzJ1gtoQ-1; Wed, 27 Apr 2022 11:00:06 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB6189.eurprd04.prod.outlook.com (2603:10a6:803:fd::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 09:00:03 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 09:00:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fd47819-c608-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651050008;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Sb514sV2BkgQgmqKHrSdZIm03KhAsgFYXTM0bUtyV4Y=;
	b=MmVxiLMdNbRmnv1zmM44xldqRy5JssQPn3zwuvpBs67UE5DQ0Z+JMrjxuYH01rqJ42xTY0
	E6lCO/kk9V4nIzw9rahoN1v00CeIjcj+apjvYnGsAvCEnO3ZTrFsTkhWLx398LfjWQDmzH
	xfhbDD8cicUJ/In7/k0ixv1bwlBWlcI=
X-MC-Unique: V9ehCNQAPh-eT3EzJ1gtoQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aJJBVd7w63y8NtH9w+EqK5s86kk3aD1Ax5KmmuzMs5hDcozecR50+RCz4Evjz+EZIO2h0WSvZKreNmJ6K6lcc980Eu2fIJFjzpcUDQxWZmrW4whpkgrjh4HVlEu0PX+PouZejx7d3x0MkHno9MT+eWjReswJUCmLsgKYO/yMZoSnn50NWPuHG2hUVuKpRBVIAkD93G3Lwiv4qzs1I5H1h+9RxuZE4Cr+b5/TDun2tywFkbaQVWCIGp/0SDoKoyGz8Shi6tlDaj4bkCLNqlqjGWGRLf6j1V9z47nnkwCXJX5FGBwjEX/1W9A3s3GFugOoXIkad4ydpwHn0XrKavLoWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Sb514sV2BkgQgmqKHrSdZIm03KhAsgFYXTM0bUtyV4Y=;
 b=BgV3Cmhvse0dqK0C1AjmYHdWLLIXpbBZC6xRX111BPzZj/RkooGurrawaVbSLSZWcg+PT7GA27U7roc7pkMC6DlY1k+ZCtsp91Rp/zxSJ/gBrSq2ZpZ+bK67EOI2Q+EE6uCgOOidRLKwgVVbX+gD3J8+M7XGAEvzwVcvBlRKSmNzh1+OuPTG2iIO45lskYaV4dbGjn5fxjzB4EQs9CJjNbWd4lAjC7AR7ITca+/OwkvVP9sAIuM/G2EFAAHxVAb94AkAyJb49QutdglZ7Wk9bVGOTcN+fCAdKPIhUydfIOlNkIcrrpU3JBG7h4266KQQ3rtUSLPcjUiVk3yfDyp8mA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <22fd4b2e-fb50-d393-cbc6-a5ac83b2a2c4@suse.com>
Date: Wed, 27 Apr 2022 11:00:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <Yl7WHv6+M+eJwQep@itl-email> <Yl7X3mAJhR5ENSpl@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yl7X3mAJhR5ENSpl@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0007.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6f1ae725-1bfa-46ea-b326-08da282c5161
X-MS-TrafficTypeDiagnostic: VI1PR04MB6189:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB618911E0B9996B11EA4A0E0DB3FA9@VI1PR04MB6189.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FqhuHPRBsfDGHhpKl/C2t4pckBwFrc40Ye8M7o+tQSDLH4HePvpjIIJjjLxHKKG4MmAmh6x3Blh0y0WvauKwCpr4vAfvx4IuiKjwZYRp8w9+krEGr4jBAxB8GTGaEQirG1UDALmfZu0Cn3xNWX/n2w8TPM/mtp4TivWNGEzYZmnq5/ETRiRN6SDIKXeGPBh4C3tk/xRearWwuTlJynEQGYVzbnlT0tTn8iJmIz/QZhIqN/OgZbtvSllQMpp5u1ODF3DS26z7oRWADph7Eb7CBvRsMQuSopNmXQvvD8gDue2KH5TzmOaz5/4CXo0g61FToxTQu7PyH07w9ogih9c20TBYVzAhXCcpfonNDlUFyPC/FYtyfxsGNRC1E7JNmsmvezIjkoM419YvBTGfLHMc4J2U7OKw8dQ4nlTYLLD0As2XIJsAg4dfGD2SVKUBTHEhUBk0MWrd155jGj/NVNM/KR30P077DUfQmZ/kabURkKYWRBfY6Vg8nPtqKobX+u3L/bw7FJCVvFOCzBgehDJlKs2+9Cp97RK6+gZL6dqGDm7Ez9s5CNZ2wMk1kHl8MIACYJGnQrNq6Ver63V5U5poXjYFj/LLneHQ4gwQwRMuGatAiNL13LjHgNtjFqvTPH//QiSd4xbsk+U4tKrK5dDKfgd2wtU3WJ4BBfZu4gsgJ5fX+7MiHSyLZ7ZSAwDeUa2dTqModWMFZ+FWhv7vkWvvUQCkGPw1uWNMYUGL96A++UQfIgsEkUcjETEB/CCT2xnV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(2616005)(6916009)(6486002)(31686004)(508600001)(54906003)(316002)(8936002)(53546011)(5660300002)(4744005)(26005)(6506007)(2906002)(31696002)(86362001)(6512007)(36756003)(186003)(66476007)(66556008)(8676002)(66946007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VjN3cm1yYWROMkNINDlWdzBiMCtqODNWNVY1OCswaG04NDVOdmE3d0V6ODRm?=
 =?utf-8?B?cndURGJiL3ozQmRCZmJzUnp5QldidnA1L0kyMmtQb2xJSGdIemkyb2p5YWJJ?=
 =?utf-8?B?bThuMTRiVXJIQ1hSZzF1R0tib0ZFRm9GYVpqc284dFNIa2dPR3RKTkxVZmRs?=
 =?utf-8?B?VzJCd2RNWWdPZ3YyT2JrOXVVbUJUQTVHYUZDaVlvT3NVdzJBNXBiOVdiTll1?=
 =?utf-8?B?ck5iU2lzVHFFTmdXMXBhUk9vVmNvWGhEQTM2d3ZQZUZvYnl6ZW9xckhOTHFy?=
 =?utf-8?B?NWRrT1VBM2E0RGdXZW9UL3E5V2FCK1VnTU9IQlVEWDJSRXErNUpEdGNJODVq?=
 =?utf-8?B?TVpZTTlOQWFSKzk4YWxaQ2psM0E1S1A4Lzc5TnpIK2VMZE1tY2FjOFlCeDRM?=
 =?utf-8?B?VmF1YlFBVzQ0bmNrdlI0dWNKd0FmUS9CYWlzeDB3L2JIUmowR3YxN1h4TnNN?=
 =?utf-8?B?enhQQ0tPTldnOXJOUElRdlBkV2VJcUJQUFFuYVpINTBaMnVkelQvWjc3K1JW?=
 =?utf-8?B?N254QW1CdkV4US9PRGtrMWVheHFJK2lPN2F2U1o2czl5S1A3SDBqK2VYSENL?=
 =?utf-8?B?aEtpazlCUWszMGNSb1JKUEVmNFU5VFJTTTVGR0tyRkM0WGNRSklJN3BpNFZF?=
 =?utf-8?B?cm5qaU4reXlTTk5RNXo1cjNrS3Z2QTZGSGFFdHdsSm4yRXUvUnhaQ2lwQ0ow?=
 =?utf-8?B?Z1hjay9MQ3Q3T0FGaG1tbDk0blczVEZkTzd5TnorWmlJalR0cG9TVUpoczY4?=
 =?utf-8?B?c0Y0a1VTZVR6TWRBU1dmOVc1d2xQeVVXL1VpelNxOGJlSjRVWjVMcEViK3ZL?=
 =?utf-8?B?Wml2L2gzSEVkaTF5b0g3NGRmSXhpaDUzMCtucVRQbXZpdTF3dW1aMEVqdEhJ?=
 =?utf-8?B?M2tkT09PQVZYWUJnTTVGbzhPVGJKUERMRUZMTURBQmlET0FuaHkyTmdHdXIz?=
 =?utf-8?B?czFIYVVGemxISjY2d0RGdGF5ZnQxUkxoRWdXb1hsNmhTdWU4dTBUQmdJYU5o?=
 =?utf-8?B?T09BeTJaT0lpYXViaFpPU3VzVzlxdVhvUys2RFhBOUV6SElwTVc1MlFEWmpS?=
 =?utf-8?B?MjNnVW0rTmU0K09aYWpHdW9UbFVHL3g1QS9YNmZvLzZtck14YzNDaXVGajY4?=
 =?utf-8?B?T1dpWW1qZXY1c0d5TVpiallIL2QwYzJYT2g2bjduY2V5ejkyV1BPVUpybE9K?=
 =?utf-8?B?dEtPcGtyM2t2K1BibE8vZUJhOVp5bU9HNGhNbXFXZHpJSW5Samg4bWVGNFVK?=
 =?utf-8?B?VXl1SEM0K1BnaVNNWU9QQUZCMEFvR2VlWWJ3bS85d2NLK3E5UmQwYUpRTy96?=
 =?utf-8?B?MVJhajNHQkNIRytqV28wRG5xbmZLVThIeGJBekltY0pxUG5CQWRibkVFYURG?=
 =?utf-8?B?UGtRS25JQkVFd0g5SDlQZkVkNkpoSFdyS2hLYk12N29hWUE0MmVGMUJITWxj?=
 =?utf-8?B?WElURkp0VUZBOGYyTlpLdUd2dm1RY3VEUXcxUmxTcVh1RWd3Ni9nRlRmZklB?=
 =?utf-8?B?bUlKeE5PS01NWEEwaVZVL3EwbWR0Z0x4bFZhd0dNL3U4cUlzNk9ycDBpOFJE?=
 =?utf-8?B?ZytjQmVTUzZGdmNpZmtXNnRTY2NuNGJ5VHcwK0JLelRIRTZFY0tCVWppZm9p?=
 =?utf-8?B?d3ROaUJEWGRIMXhFbnBFNXhJYjBsa2srMFN1WjBaREx5TENZdS80R3Q2YXJE?=
 =?utf-8?B?WGN4dlRCRnZ1QVBRNkM2bGpuZncwamhidVR0RjA4UmFHc0NVUlJ3a0c1UXFZ?=
 =?utf-8?B?ZFd0aVRjRHI2dWR0MXFFUHlJWDNBSjhOVi8zMmh5Rk4raDFHVUZKZ3Y1ckNR?=
 =?utf-8?B?NGgreFRXVkozTk5lbVN0K3pKcWZiOXB1cGpqRGFlNit2OFltMkMrV3gydHdv?=
 =?utf-8?B?Nm5heWc4OGVDVURWa3BSb0dhNUdFVi9SNFJ0UFZZZXltY2xRN1BtcjhURE9E?=
 =?utf-8?B?QlNqeHZpcDFaQXZiZ3YrcGpiZ25WMU02YStHNlU2ako0NldZSzFQYjduVjBW?=
 =?utf-8?B?bnZkU0JYcjJ5UnJzZFd0MW9YeEFaQkxKQnk4bjZ4SnRBWU5ZcDc0aUVJVWdG?=
 =?utf-8?B?SFdLcTFoRlV5c01KeXBFVVZaV25pOXU4N1gvNEw0U1VPZTBOZW5ISHplcUxw?=
 =?utf-8?B?N0JWbDFvL2JWQUVYcStDVm9rTGJQL0JyQTlZMmJWYVY4TTk0WVlDeUxDazZT?=
 =?utf-8?B?WmhKMDQwRXZxSlpEMkY1RnRlSXZLZXBpUmVPL2VqNko2cWNTRGc4V1Mxc2VL?=
 =?utf-8?B?bW9vS0o3WFNISzNMUTVOang4UUIyMzVFT3dncTh3WUR1T3VxOVIzdGpLNUpz?=
 =?utf-8?B?UDk5aEg4QXd0V0J4K29sMUk1RFdua0dSRm9OeE1PNG1rODEvU1Zudz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f1ae725-1bfa-46ea-b326-08da282c5161
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:00:03.6469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HxR7xewLtCLVnRa2Kiur4nclsZJnCgW2pj6cH1vEBnA+p9gcsjIHp5TBTguErWmCL/78KOlQXCrDazRENYLylA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6189

On 19.04.2022 17:40, Demi Marie Obenour wrote:
> --- a/xen/include/efi/efiapi.h
> +++ b/xen/include/efi/efiapi.h
> @@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES {
>  #define SAL_SYSTEM_TABLE_GUID    \
>      { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d} }
>  
> +#define ESRT_GUID    \
> +    { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21, 0x80} }
> +

I'm sorry, yet one more remark: This should go here only if the gnu-efi
package also has it there. Otherwise it should be added next to the
other GUIDs in efi/boot.c. This is to make updating of this header from
newer gnu-efi versions as straightforward as possible.

Also please once again use the name from the spec,
EFI_SYSTEM_RESOURCE_TABLE_GUID.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:17:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:17:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314595.532730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdnV-00076m-QF; Wed, 27 Apr 2022 09:17:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314595.532730; Wed, 27 Apr 2022 09:17:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdnV-00076f-MK; Wed, 27 Apr 2022 09:17:21 +0000
Received: by outflank-mailman (input) for mailman id 314595;
 Wed, 27 Apr 2022 09:17:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=y66U=VF=citrix.com=prvs=1094d0c61=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1njdnU-00076Z-P1
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:17:20 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d512c2a9-c60a-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:17:18 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d512c2a9-c60a-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651051038;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=kD9gd6yBs5xJbovJEpul4l2qlNLIMfUWkVJNVNBDV7E=;
  b=CDwjuOO+eO28S93QLwDcSfgoi4C2zTnOPW8mmtkiztAPU6kzdaISVoDp
   AX0IEBv+GwTQB6k2FMg3iqhOI9U3FAEBFYauO0HNr2ibaSNIzPuM51Vxe
   bFBUictttQFKnPVL2+GJAvLKSO50JK5QyYNnmF9Xa0lohgtaW+D3nOhrY
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69422833
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gAShyKJGHopCg9jHFE+R15UlxSXFcZb7ZxGr2PjKsXjdYENShTJWn
 2sZDWyOPPfZYmXzLdgjboq0pEsG7MDRyoM3S1FlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQ22YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PNxn5npQgECB7HnxOkNczZeIXA5IqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ6eCP
 ZBJMmEHgBLoTTlPPHs5DtEEh+a13DqnIh9gmmOJnP9ii4TU5FMoi+W8WDbPQfSSSdhPhE+eu
 krP+m3rBRdcP9uaoRKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuwj0OlHsJSL
 WQY+ywhsqE28AquQ5/gXHWFTGWs50BGHYAKSqtjtV/LmvG8Dxul6nYsaAJrbYUtsuQPWRd22
 0+psNXbVHtwv+jAIZ6CzYu8oTS3MCkTCGYNYy4YUAcIi+XeTJEPYgHnFYg6TvPs5jHhMXSpm
 m3R8nBi71kGpZRTv5hX62wrlN5FSnLhagcurjvaUWu+hu+STN70Ptf4gbQ3ABspEWp4crVjl
 CVc8yR9xLpXZX1oqMBqaL9QdIxFH97fbFXhbadHRvHNDQiF9X+5Zpx36zpjPkpvOctsUWa3P
 ReC4l8LvMAIZyHCgUpLj2WZUZpC8EQdPY69CqC8giRmP/CdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqDLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/rNBDcAhWfSRqbX00wuQOHtO+zsNdMDlJI5fsLXkJIeSJQ4w9ej/0w
 0yA
IronPort-HdrOrdr: A9a23:DiLj2aOxuOnsZcBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy
 nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM
 xbEpSWZueeMWRH
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="69422833"
Date: Wed, 27 Apr 2022 10:17:13 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: James Dingwall <james-xen@dingwall.me.uk>
CC: <xen-devel@lists.xenproject.org>, <pdurrant@amazon.com>
Subject: Re: [PATCH] fix invalid frontend path for set_mtu
Message-ID: <YmkKGVa1NeKBQV9M@perard.uk.xensource.com>
References: <20220301093513.GA3187840@dingwall.me.uk>
 <YlV4lXZHz52xPBzt@perard.uk.xensource.com>
 <20220419120418.GA232637@dingwall.me.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220419120418.GA232637@dingwall.me.uk>

On Tue, Apr 19, 2022 at 01:04:18PM +0100, James Dingwall wrote:
> Thank you for your feedback.  I've updated the patch as suggested.  I've also
> incorporated two other changes, one is a simple style change for consistency,
> the other is to change a the test for a valid mtu from > 0 to >= 68.  I can
> resubmit the original patch if either of these are a problem.

The style change is fine, but I'd rather have the change to the
mtu check in a different patch.

Otherwise, the patch looks better, thanks.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314603.532741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdsT-00008E-GS; Wed, 27 Apr 2022 09:22:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314603.532741; Wed, 27 Apr 2022 09:22:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdsT-000087-DP; Wed, 27 Apr 2022 09:22:29 +0000
Received: by outflank-mailman (input) for mailman id 314603;
 Wed, 27 Apr 2022 09:22:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njdsS-000081-GI
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:22:28 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ccc1ea5-c60b-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:22:26 +0200 (CEST)
Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 05:22:23 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SA2PR03MB5674.namprd03.prod.outlook.com (2603:10b6:806:114::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 09:22:21 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 09:22:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ccc1ea5-c60b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651051346;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=0P6WrWdvHZjEGxpZdcQgIZ5XhEUQWQHcHZS+IAWsPag=;
  b=F0YwqU3E2WLZEJNPpxv9LWBX/qrRlWZhA7JYYHFDshqKGPa/5CFD/+Hm
   e66rAYyJlN1v/GWvshp7Qx3SV2NiVONwT7HuLcDWnEvzATuaikiojTxtB
   Ill94YxhG9Ha7VxEGWam+nUU1TtvtzeqndF9BQgzAdaIHUjOUJxo8Pk0i
   o=;
X-IronPort-RemoteIP: 104.47.55.109
X-IronPort-MID: 69423072
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:y9oIpKnF8YGL/6MRS5QGbJno5gw/J0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZX2CHP6qDN2Pxf4xya4y19k0Ov8TRmNVjTFdp+30zHiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWV3V4
 rsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYSyIMIaDUs9Yma0N2T3B8IrQXxYb6GC3q2SCT5xWun3rE5dxLVRlzGLJCv+F9DCdJ6
 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBhGZYasNmRJ4yY
 +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUG+Q7P/vJouQA/yiRP3bbwPvXbdeewTOFvwxekl
 EjP2m7QV0Ry2Nu3jGDtHmiXrvPGmCrgcJ4RELC++e9nhBuYwWl7IAEfUFKg5/20jEGvVtZ3K
 koI9y5opq83nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZiFFQMwrsokxXzNC/
 l2GhdTyHhR0raaYD3ma89+8rzm/JCwUJm8qfjIfQE0O5NyLiIMuihPCSP5zHajzicf6cRnr2
 CyDpiU6g7QVjOYI2r+98FSBhCijzrDATxU85wHedmik8g90aoOja4Gyr1Pc6J5oNJ6YVFKIu
 HEOhuCU7fwCAJ+AkiCAWqMGG7TBz/SYNnvaiF1mHZgk/hys/WKuecZb5zQWDERkLMcCPyPoa
 Un7uAVN6ZsVN3yvBZKbeKq0AsUuiK3/T9LsU6mMasIUO8AgMgia4CtpeEicmXj3l1Qhmr0+P
 pHddtuwCXEdCuJsyz/eq/oh7ILHDxsWnQv7La0XBTz+uVZCTBZ5kYs4DWY=
IronPort-HdrOrdr: A9a23:Z9wKSa297hoFJHJjDL2v+wqjBTtyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp
 uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6
 Dsm/av6gDQMUj+Ka+Adwo4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 LxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72PeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu15Dq
 r/Q+BVfYp1P74rhJJGdZk8qPSMexzwqDL3QRSvyAfcZeg600ykke+E3JwFoMeXRbcv8Lwe3L
 z8bXIwjx9GR6upM7zC4KF2
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="69423072"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F8nwkKQV9RMjXKUEpj5KmJJLjj2X7QNYxSxzgJ1qKhb/KPafP2fXkJ6qaRMkdKFoHSpwndxDAECGziYGoahXPG7yI0CoeILWi5ZCsqVx2xy0dDZpFcEB9RU9HLfy8yYs72BhPA3zINqdr/qHSxn43nhD6vO7QlHpGvYPmegqso2q0Jb+779/+d9QlE8ZY6iW2wcFibWYydSNSWkpwF7jqwr0m3jShnJbQHSTKoUTVOjTtsDF/c22PCSODM9dMOEe5476QW/ygte63HqLcGGrk+aC6eRvqGelkKW1pkNd5v0eL6ujZi6+3zR7FZKfXfJ0wC9/zbQBZHW6KrWkKvzoIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RnlJQZcjgUTUpsRsT1TXqVmTTBHXsxQJSZtrXBDpBrU=;
 b=f81erv32yU29M04QCFWC/vu4WcXyYVuu9MpNFBwLb2JSgbukiDrWQn3F7P/QQ26otxSW15MrbRW9JorYOuH1ppQMa8igqXNpPvCdBvB1724m6cueq02BxCa/v3I8zBd3uvcvRf+OYwHzlv2Pvgy1pdL0RiLysOnYyPwy30fDaiL5HRGp1e3At2V06yX6w3/lWDcY11nFMqU83TjwJVEI/rcqrckTnrxOUWZlu7Jh5sBPmhaIvppvyG1gk+idssYQdNbQkk8AJ0YQRp1JqSwQddt8anMHzVy0eMgc/ZkJKfE6CpEt4p6jRpZ/viRARQmw3o0vXhFL0f0t63Bmjt6nxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RnlJQZcjgUTUpsRsT1TXqVmTTBHXsxQJSZtrXBDpBrU=;
 b=SSFlBy+UFPv7FbEt2/JJnhRMSMZGlJOoqZVzeib+mqXOJHH5UohNXPPY/6f/Ec8asxtwXVvTE1xDovOfc3C0/njv4eXs42HHekWC1z8/JuQwGtyR+efodvLehU+3x/+wctrxONRjK4yLaWqeEsuMAilQaOYMwX30AfRGK9BV8Wc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 11:22:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v4 2/2] x86/monitor: Add new monitor event to catch all
 vmexits
Message-ID: <YmkLSclSQtKVhfb2@Air-de-Roger>
References: <bc13e07cdb651afc2c8a97dde1be9c2158160307.1649857162.git.tamas.lengyel@intel.com>
 <4b456c15829c11914b698654937c28e313d2d522.1649857162.git.tamas.lengyel@intel.com>
 <YmazAdHL4LWOdDDv@Air-de-Roger>
 <CABfawh=Z1_88p14ivkqrBAUKbfw39f-frXN9uNsdVt9BDp+4bA@mail.gmail.com>
 <YmeyDRYcwfgg7mwC@Air-de-Roger>
 <CABfawh=gb0_oyjqq9DwioaVZfnrkbbFLJi14oyN4o5njrK9xgg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABfawh=gb0_oyjqq9DwioaVZfnrkbbFLJi14oyN4o5njrK9xgg@mail.gmail.com>
X-ClientProxiedBy: LO4P123CA0283.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:195::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4d1213a7-cbc4-4f74-cc6a-08da282f6ed1
X-MS-TrafficTypeDiagnostic: SA2PR03MB5674:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<SA2PR03MB5674958FF3DB058F45589F938FFA9@SA2PR03MB5674.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fthgtOP5bi6QLN2q5NO89m8rC+nOm6iMrV7uQs8spAZ3yYs1w6XAdvGHsr7HU3q9wzeWTFAZOGcDluCuXn1iDqthkWCmjIl4hpwQee3afFbge921ezWnIHIRQTRhEwdQIhsFhdNbPccMO2aZHDR9sLE229m/FVKkiTo5nWOAaUO8aYbGSWzzQML6oVpWyZ1MN6Lu8YupP+UvggKBi+AHR4BmM6T2beGHtKHzPRlMU02xc3m1HzsRxzyxL6JAtMYRR9zycF45Ow9iNiP8fQhnJO7oelUiNwQn6uGDHd0412482y288i+YSLbiheKHSsTVwY2z4V/r4+on7fqdjbWqz4FHdaGl5MyGeP4fydhxchVfCkI32kDrk+njCA3yQ+Ko2IxwSwTpQ0z/Wr01WWyurZ3c7wCP8ED89QZRzhueTaJqOX8/vcmjT1oxgWDf46ukSWk9cSG5G7cv3llJ5RPB4kSqc4ppve68P+/kog353Osjo/j/yQDaLx33Vlc7ikvN4jkiVIixQMlT2zZDdmvK8yrwP3+9Z0EuYDfL9Et6vs1iGW/xtvT3ooFgpyQTBC149a+xg+PZsdbKbeqQfAWkxZc/PSmwymiSJfpNk9QllJGsbVO6+Pna+nYZYLZH23Jdf2wUPCID1NO1T080/53+Rg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(5660300002)(6486002)(508600001)(8936002)(7416002)(66476007)(66556008)(66946007)(26005)(82960400001)(8676002)(4326008)(6512007)(9686003)(86362001)(53546011)(6506007)(316002)(54906003)(6916009)(6666004)(186003)(83380400001)(85182001)(2906002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1Bqa3E4MFF1dWUveDA2U2VSMjNwTVd4V2dtYkhkcTBNWUZNdkVYaFdkMVQ4?=
 =?utf-8?B?ZklFcGVrWjNJampVcktmc0VWeUxGYlpwUXdzbzZoRjYxV0RxYTh6QzhGZHhI?=
 =?utf-8?B?NDJWdHpoQkd0V00ramVQMlFGMUlDUzVCbjhNUXIvclpXK2M4b1dmV3lQcHU0?=
 =?utf-8?B?d3pNZm5BU1J6YXhsaG1QbkdVK2NCSnl3ZW5kWkJWK1B1Um1PZE9ISGxUbEUy?=
 =?utf-8?B?UmNva2w1VGthMnVMZjFVOXAwLzA4cFJyam1VZkROem55VlRjNy80bFE2eUxm?=
 =?utf-8?B?djZ5a3Z2RDJ6a09nNGg0SjVybzBQN2FMVzljRGE0SEkreTQ0eHJ6U3cxczVw?=
 =?utf-8?B?cUhXUUNxVzkyOFZVbVRsZW1Qa0YzTEdKVmpUZnAyditmbHVoU2R2bXFhM29m?=
 =?utf-8?B?WGFqSFRrTWhYUFdqaDBaZlNvRlo3dzk1Wmoxem5RclhnbTI4bFVwTmllYmZX?=
 =?utf-8?B?aVhxaE9ueldzZmRQWnNraXF2QzlKSVVkWTFQMHVJVzF0VHg5UitFeGdwemgy?=
 =?utf-8?B?NmtaOE0zUENTSHE1ZGNmU0JqUU1IeXlOWmtXUWlMcVo2anpHWXdQOUZtdHNk?=
 =?utf-8?B?WUtDNkJSZlJKRVFJdmdjT1NZS0lqaE9IcGxheUtBUEQ3em9UdUxkZnlBanRW?=
 =?utf-8?B?NTFpSnJlT0lvS0ZsbHVjb0dtWmpGRnhnRjdPajVQZ1NSRnAwY25SU1hVcG9I?=
 =?utf-8?B?UnBZN2N2clIvRi9kZVZqMDVSMkVKb24rdngwb1BFMWlkSTJrUlo3Z1pCWnhF?=
 =?utf-8?B?SzkwdFVpM2haejFpME1MVkZnSGVTMm93QVE0NWFGN3ozUDJLeTl1WEhlTVY3?=
 =?utf-8?B?ZWRUWXRLL3I1Nm14UUo2U01jTDNsb1BtQ21FZ25XejhmS3ZwYlMwRHQxdGE0?=
 =?utf-8?B?cStFSTg2Tjd2U0d2T0FkVWlhc2IxZHV5N0VMTWVLSnB2aXF0V2djSk9rNFdr?=
 =?utf-8?B?Z3hXOGpEMFZMdjFtb0ltQUxiQTdQbTMvSmt5ZFQ5bUlmS2JRWmhEUmRTVm0y?=
 =?utf-8?B?ZjJiNlUycldjUU0wNDUwcjhia0YycVpPVEVvdlZ0d0JINE1LVU9SQVpycjNl?=
 =?utf-8?B?bDduUUZXMVFpVlF6bjVVWTI2cVVOc3RWZUJPLzlHVUZJVGVaY2FXb0ExbE55?=
 =?utf-8?B?RGQ4aU9oRlU5WXMvZkVDZ2ZGOEVkTEFZN0lOVlJ2YzBmekZxS1pwdmFuZmJr?=
 =?utf-8?B?RVdETHkwT0pxYjZUNzJKUjZndlN4Z2RwcDMwaUFyUDArRDFLZ1VXeEd3Wk9y?=
 =?utf-8?B?b0pnOFVTaElMRFJHTEVEcFN5R0pDSVNHbU05NkxYQXJrR0lZYkk2N28rSXd2?=
 =?utf-8?B?NUVOWkE2dmFrYmNkeDlJRmNyVVI3TG8zQkZtNzY2ckhxN2FtZ3JvMWtBN0pP?=
 =?utf-8?B?WXAyaFNjZmNMWUFhdGc3amxWVjlDcHN3OTFHMHNKSFlUdG41bVp2UWI4L084?=
 =?utf-8?B?VmpwSHgyNHNON3l3ZEEzb0YyeEthellHVmhsWEh5SW1vTVVBUnpkUCt5TDVp?=
 =?utf-8?B?ajdiTE1BY3FvNTJaVTk4bDlNbjB6QUpsMXpjRjh6aDhOR3BObkNWME9Hc2tE?=
 =?utf-8?B?aHFHalg1Zk90NXBIeFc2WDJwdS9SaVNvbGpiaEJHd0U1bHhUVlQ3bXRML3hh?=
 =?utf-8?B?Lzhwd1h6TWJaUjBqcXRhVEpVdXpSZS9LejRxOXpOQVJCS1BHZmQzL01Zc2JS?=
 =?utf-8?B?RGVUR3NNMldCTlVBU3Q5blIrWFlZc3o3TlAxR3pKS3FyUUNNaC82Ylg2Rm5K?=
 =?utf-8?B?REtKZzBNR0U3eWxoM2V3K2g2SGwzZ3QyTmFTak5oNlJtSkpXd2pSODdkVTRx?=
 =?utf-8?B?TTRFU24rVzNVdWJqbHkyZWJ4alNMVGYrbk1BaWJwS2h3UktQT3RvU1JBV3Yz?=
 =?utf-8?B?UXRCdDJwd0lPbW1YY0xId0tRdERpazFBcGZaMjlXcnEyVjMxS04vV09lWkxI?=
 =?utf-8?B?WmVaRnYxSlE5c1BLRXJsekVpMWdxWjRpWFR2cDVLdzlEY0pOUmRncHdvUXM0?=
 =?utf-8?B?eVJiK3duY3UyeTdIbEc5WTN0OXJNQnlpa05lS2k4LzNPRVQvaVZ3NXNvV2Fa?=
 =?utf-8?B?NG81T0k5eU1hRENsOHMwVTB6eVpIQjU3MGFsNDV0QlRiTkpQSUpXT2xPTjdI?=
 =?utf-8?B?UzEzVnhTWU41Y3Z4eFVCUURocWh6bG1nbWRPdUFBWEF5S1d3RUVZc1pJNXVF?=
 =?utf-8?B?NmJOTUZLdXpDNld5MDRYVWVLaUZ4Y3ZpUVFwMGZPY2pwU3I4YXVUMkQ0QnVm?=
 =?utf-8?B?bzIrcGxJWitnZytuY2pTbmhKay9tK0ZoM2V3QnRZQzA4eVFTcVdpVm5MRGw4?=
 =?utf-8?B?d2dhM0xObTczRWNmUi9BUWxuUHNsdWx0YlZYaE1IcVdQUGFDdkMwb0tWWmpm?=
 =?utf-8?Q?+TFpkYmZvJglPeC0=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d1213a7-cbc4-4f74-cc6a-08da282f6ed1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:22:21.6531
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3asx4UONpa6zT9y8zYfBjoeoMURtdQeNo9xzNq0SZDPswQyVzRBbl7cbaL/2PwYJduv6Sb6oEOqvJjMORtur+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5674

On Tue, Apr 26, 2022 at 02:53:54PM -0400, Tamas K Lengyel wrote:
> On Tue, Apr 26, 2022 at 4:50 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
> >
> > On Mon, Apr 25, 2022 at 11:40:11AM -0400, Tamas K Lengyel wrote:
> > > On Mon, Apr 25, 2022 at 10:41 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
> > > >
> > > > On Wed, Apr 13, 2022 at 09:41:52AM -0400, Tamas K Lengyel wrote:
> > > > > diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
> > > > > index 3079726a8b..30ca71432c 100644
> > > > > --- a/xen/arch/x86/monitor.c
> > > > > +++ b/xen/arch/x86/monitor.c
> > > > > @@ -332,6 +332,20 @@ int arch_monitor_domctl_event(struct domain *d,
> > > > >          break;
> > > > >      }
> > > > >
> > > > > +    case XEN_DOMCTL_MONITOR_EVENT_VMEXIT:
> > > > > +    {
> > > > > +        bool old_status = ad->monitor.vmexit_enabled;
> > > > > +
> > > > > +        if ( unlikely(old_status == requested_status) )
> > > > > +            return -EEXIST;
> > > >
> > > > What about if the requested status is the same as the current one, but
> > > > vmexit sync is not?
> > >
> > > You need to clear the currently registered event first, then register
> > > the new one.
> > >
> > > > IOW, I'm not sure this check is helpful, and you could likely avoid
> > > > the old_status local variable.
> > >
> > > It is helpful on the callee side. Usually the callee needs to keep
> > > track of the state of what events are enabled so that it can clean up
> > > after itself and if it ever runs into trying to set the event to
> > > something it's already set to then that indicates its state being
> > > out-of-sync.
> >
> > Hm, right.  I wonder if you should also check that the ring is empty
> > before changing the status?  So that the callee doesn't change the
> > status while requests are still pending on the ring from the previous
> > type?
> 
> No, that becomes tricky because really the only way to ensure the ring
> remains empty from the userspace is to pause the domain, which is very
> heavy handed. There is nothing wrong with asking Xen not to produce
> more of a certain type of request while still being able to handle the
> ones that are already on the ring. For setups where the two should
> happen at the same time is where the toolstack first pauses the
> domain, clears the ring, then disables the event. Both are valid
> approaches.

OK, so we rely on the callee to drain the ring properly when wanting
to change VMEXIT events.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:28:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:28:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314610.532752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdyU-0000nM-7k; Wed, 27 Apr 2022 09:28:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314610.532752; Wed, 27 Apr 2022 09:28:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdyU-0000nF-4A; Wed, 27 Apr 2022 09:28:42 +0000
Received: by outflank-mailman (input) for mailman id 314610;
 Wed, 27 Apr 2022 09:28:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ksbQ=VF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njdyS-0000n9-Gb
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:28:40 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on20619.outbound.protection.outlook.com
 [2a01:111:f400:fe1a::619])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6b3ab4ae-c60c-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:28:38 +0200 (CEST)
Received: from FR0P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::22)
 by DU0PR08MB8188.eurprd08.prod.outlook.com (2603:10a6:10:3ef::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 09:28:34 +0000
Received: from VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:49:cafe::ca) by FR0P281CA0069.outlook.office365.com
 (2603:10a6:d10:49::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT015.mail.protection.outlook.com (10.152.18.176) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:28:32 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Wed, 27 Apr 2022 09:28:32 +0000
Received: from e80068fc07bd.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 668B4725-7378-4FF6-B55E-2C37948E30C0.1; 
 Wed, 27 Apr 2022 09:28:25 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e80068fc07bd.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 09:28:25 +0000
Received: from AS9PR06CA0721.eurprd06.prod.outlook.com (2603:10a6:20b:487::7)
 by PAXPR08MB6848.eurprd08.prod.outlook.com (2603:10a6:102:132::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 09:28:24 +0000
Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:487:cafe::d1) by AS9PR06CA0721.outlook.office365.com
 (2603:10a6:20b:487::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.18 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:24 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:28:23 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr
 2022 09:28:10 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b3ab4ae-c60c-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=K08o6O1AwpferyJhswLpdKBDSM0V/K1ozBzCSwVYV5LMVnMwtnzgzEnvzIhr1Yf8GEjCjIyzA9Af3bZJ67l0u0BnsDhuzmu5SRzSkfO3JzJDpFSNxUP9HUJQ6ALNK68NTadT9hE7NF+rrur0pGk0K4PPuX3vFYZx5jub9bE6ElhgH2vKwBb/lmoRP6PLarwiU1NHsiKNlfrD+GC7K5m88/P3T0Rw0/Yo042fc3y+iisD/bs5Jkn0g4/sXq1Qcj/frQbxlRdi+cuuHBPasBNU51k8f5JYZT8z+2doGuSXlONOCoMS/hOLG1sR4BWhJ13vuKiBGB0L1oL0AWOP9FrsZg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ThmgOFurEe0Rf5be44HpvcHVKFyzQoKYs/DLnSQbE24=;
 b=PaOnLmcxulfs4HP6Ub+TZ1zzrA6UiUnxeVUpJ4gHwZv615G1aWSUSVEcpgdd731HmsDtTuB97c2iTReYP5C1DEWKR6jy/cmg0k3ugS5Tgrd9WvE484Zz+u0VF4AEBm3Wt3ZILh3eDGhvYWJzSSN1iINqenapZ2coxRMwhGXxatxTC03f+K25xDUIyuSMHeEa+b7AZRSj+QRW3kvIB9sYfdCAX4m+RP0IqSg95rFCkd1qeGReEGuWa4eUFRx4P/oQrl48bpRxNpbWEll09nUDNgUvq//fvh7hCe4KKD+pvyHEuZyZP11KBg5R6monwXl9xAUDY3whXzkAmSorCIKWoQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ThmgOFurEe0Rf5be44HpvcHVKFyzQoKYs/DLnSQbE24=;
 b=d/y8uXtZ0SaqQYjjcrtcVW5fHX74YkRhgzGuvWnmFtRHSfVewsfG02ixnv0BaThcgETc49Es9nbK6rh+RZ2pWsuZ53tuWEk1A5DmcHjRSaIWZy4wJbTHy0mZPJ3LrnHznL0gZjt68Q8WEHJRUUWNiwOVNnej8yNnZTbaKLEjfx4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4703d742c6b2843c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SA66BvvohOxPwB61GD+ZOmlDMjU03Uz8CJdasnve97yQ0yWuvg8O5uciIzzVVQDm8LzOU3yCXi44fuk9S7nT0NR/hAvl9ergHUYlomRxZnkRLdJlxu9Iv4MCP20yrVn5lwAAhFqfIVZF4Cq9VKH3JIB5UJES/1+azyclZ26EqTMjTIcbnFELROMHvBDeo6QOpdeFqt+UlmGtL65H7QalOh2RFncydFoQTUnz9zY2vBUjPUwYO7Y+k4rH+Pie9/p7iYgkSoItSNfdMj31ropYV673bg26xGY8jhPhH0ZVGvYIXu04R+vxm+PnJADcbGMioJLmUTMoEaLE6cbVis8jvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ThmgOFurEe0Rf5be44HpvcHVKFyzQoKYs/DLnSQbE24=;
 b=XXdLT8u9o8E14+lzXiEn88cTNvUh8yG2JqGQTS6Z4MM49zl1wtp4AUrcgFMirK1BKON8Ekp+O4agCh3yd3QvtnJofkwC0RJGEZGJkez+d5Kb4Uu4MJSL66dHdmbKW9Sr0S7jTElj/bM2/vBpVXHKKA/0FzpvJQbpGWLePIn0aDCaypfS4Kyj36ruCqAFs3vpSsZ7d+42QBTh4tvhCq3jWqvIHDrWdSbVaFnw6vXQlPVFWWD8P7Q31Uq9kY7sWuh4oCAwQ43KNB6XciHynaq6uocucQ6gkUF4br+wCiC399yE2fqvlg9rQ3AJ+AbzT1KDua6xbnxV3EsUWFJ9fwoUFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ThmgOFurEe0Rf5be44HpvcHVKFyzQoKYs/DLnSQbE24=;
 b=d/y8uXtZ0SaqQYjjcrtcVW5fHX74YkRhgzGuvWnmFtRHSfVewsfG02ixnv0BaThcgETc49Es9nbK6rh+RZ2pWsuZ53tuWEk1A5DmcHjRSaIWZy4wJbTHy0mZPJ3LrnHznL0gZjt68Q8WEHJRUUWNiwOVNnej8yNnZTbaKLEjfx4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, <henry.wang@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: [PATCH V3 0/6] populate/unpopulate memory when domain on static
Date: Wed, 27 Apr 2022 17:27:37 +0800
Message-ID: <20220427092743.925563-1-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: de60fa74-325e-4225-bfdb-08da28304c56
X-MS-TrafficTypeDiagnostic:
	PAXPR08MB6848:EE_|VE1EUR03FT015:EE_|DU0PR08MB8188:EE_
X-Microsoft-Antispam-PRVS:
	<DU0PR08MB8188A38BCC8B66388FA54029F7FA9@DU0PR08MB8188.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NAyh367RXljibv3TngpBi5cuXJ2nKBWLxVfj2s6KBoNCaqkQZ8WdXV15YyRIYWaPBpylqCwhG9rQ1mE5yCX29NgNSnRqBzjDJEdoQOZHpA8VmqFD1v+2ygliFJeQfYxk60drDROGK473ak6RSHwX2cTJkTYc598gb7lMOjZ/UzXbBJHeISxNmGRL7LAOmS3cdg3y+HykVvaM+KQsiGM4c+ErLaxUoN3X4+O8IO3ffPFX9QT5ncYYBKev8njw3P8TTlGtd8NRbrUxHoBtXY+wpqMQNkL6twlEqtrZuDJ8IwRIH7SZtiEfXjcxhOYEhl8YZpV7l4p/ofBye0P05OOGtRhE8YIhAWZ+xhtcJI1ZTy4INkLu96C7bv16Xtr711J7egpZ3dUgnvI+imE90xs9UaB92GmDX7wHlQzn6Fdq+UXRNCxXfx0JVIsoCFRDFmbap7LQ+n/zvN1UflzowpglTnR5ufc8HYR/AOWU3y5+yQWByeZqCjLnw8RiukuKyZWYhMqzTkx9/0siWiXESVhHvSyHvtOC7mqVzOhX9ee000mmQQb0VPAqBAiuehS/9prpff351PED9XZQPInMuM9ShCdU9CWpwicyGVlVOSSPXxs3gXL5RdRayHMz28P+3EWSVLYnjk9yWjdJHHr9+wYZo/8hGwJQez5IWRW/T+w6b0a53dkspnO4eUhFS7fxXzQKtlZ62bDFZ3vFZ++j70lsOLLCflbwKMOjBKEuVVFsu1w=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(316002)(26005)(8676002)(2616005)(47076005)(86362001)(508600001)(6916009)(54906003)(70206006)(70586007)(81166007)(82310400005)(40460700003)(356005)(6666004)(426003)(5660300002)(4326008)(7696005)(8936002)(336012)(36756003)(83380400001)(1076003)(186003)(2906002)(36860700001)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6848
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1a7321a1-4644-4da3-13ec-08da283046cc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xc5nn9u6MolxMoB0KAtyJolSg+DcStNgnyI16geSD2INiS6yyiGRNScK94mvK7kN/9vIk9kNUvpLhJIyszDOAw0tfDasqv533tiFNtuMzzqJcySDTfQjDbx0qSMJrehsgLtSYb4Fj3/jfbQCAxZAvsn4ILHhaVyuYGK79CTHdmTecIDrTWmpkS413EPdEEbAXZavF+kVRT9ZFCeZIUVaVn7+lBs5cFgqHnKtmjiZ1ZYrb2sCQN7eryDfcSIw4ooAgZ2cMqymf2yH55DRSqU919TSeFeITi1+bGNezhhfFWkdioGM7iFXR5E9psL0rUmuleeLa7o5tIQdYbVYasz/okb6CXTZOf4Gkhkq0WOi+Gg0cfhslqZUihOZwLiwt/G68ZI7A4YNzapwXJkNZ/OtD17RdemmHl2YDSLz84k2O9M9uCHXEdX6zELBFs7ee6+TV6H7J4R1gOTaDiC30vmEdbgE/0V/6JOWFm3t2MOoG5AI3h4qTl+JqenlOcpQWFNzso0jJGtZnoPDz17roql3Etc1tkNOd9SmB+hNKxwNRZwzBGeYRknghRce1OCRIflt72K/ZzqH2eGNkh12EvHdtbDHHiIv/ul0CoMQgg+bpmoULEBma0BP1IqHC/vOCqUeGtRuZmQFCwT1kFDIILY1Gm6kHQx7bqnxOe+mQFBOAC5iqDIMJRXbGCSSXFI32V261PcvEjlnKG9M0Y51e1j1hw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(107886003)(1076003)(2616005)(4326008)(86362001)(186003)(426003)(336012)(8676002)(47076005)(36756003)(83380400001)(82310400005)(2906002)(26005)(6666004)(5660300002)(316002)(7696005)(36860700001)(6916009)(8936002)(70586007)(70206006)(508600001)(81166007)(40460700003)(54906003)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:28:32.9547
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: de60fa74-325e-4225-bfdb-08da28304c56
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8188

Today when a domain unpopulates the memory on runtime, they will always
hand the memory over to the heap allocator. And it will be a problem if it
is a static domain.
Pages used as guest RAM for static domain shall always be reserved to this
domain only, and not be used for any other purposes, so they shall never go
back to heap allocator.

This patch serie intends to fix this issue, by adding pages on the new list
resv_page_list after having taken them off the "normal" list, when unpopulating
memory, and retrieving pages from resv page list(resv_page_list) when
populating memory.

---
v3 changes:
- fix possible racy issue in free_staticmem_pages()
- introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case
- move the change to free_heap_pages() to cover other potential call sites
- change fixed width type uint32_t to unsigned int
- change "flags" to a more descriptive name "cdf"
- change name from "is_domain_static()" to "is_domain_using_staticmem"
- have page_list_del() just once out of the if()
- remove resv_pages counter
- make arch_free_heap_page be an expression, not a compound statement.
- move #ifndef is_domain_using_staticmem to the common header file
- remove #ifdef CONFIG_STATIC_MEMORY-ary
- remove meaningless page_to_mfn(page) in error log
---
v2 changes:
- let "flags" live in the struct domain. So other arch can take
advantage of it in the future
- change name from "is_domain_on_static_allocation" to "is_domain_static()"
- put reserved pages on resv_page_list after having taken them off
the "normal" list
- introduce acquire_reserved_page to retrieve reserved pages from
resv_page_list
- forbid non-zero-order requests in populate_physmap
- let is_domain_static return ((void)(d), false) on x86
- fix coding style

Penny Zheng (6):
  xen: do not free reserved memory into heap
  xen: do not merge reserved pages in free_heap_pages()
  xen: add field "flags" to cover all internal CDF_XXX
  xen/arm: introduce CDF_staticmem
  xen: unpopulate memory when domain is static
  xen: retrieve reserved pages on populate_physmap

 xen/arch/arm/domain.c             |  2 --
 xen/arch/arm/domain_build.c       |  5 ++-
 xen/arch/arm/include/asm/domain.h |  5 +--
 xen/arch/arm/include/asm/mm.h     | 12 +++++++
 xen/common/domain.c               |  7 ++++
 xen/common/memory.c               | 23 +++++++++++++
 xen/common/page_alloc.c           | 57 +++++++++++++++++++++++++++++--
 xen/include/xen/domain.h          |  6 ++++
 xen/include/xen/mm.h              |  3 +-
 xen/include/xen/sched.h           |  6 ++++
 10 files changed, 116 insertions(+), 10 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:28:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:28:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314611.532763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdyc-00016a-KM; Wed, 27 Apr 2022 09:28:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314611.532763; Wed, 27 Apr 2022 09:28:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdyc-00016O-GT; Wed, 27 Apr 2022 09:28:50 +0000
Received: by outflank-mailman (input) for mailman id 314611;
 Wed, 27 Apr 2022 09:28:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ksbQ=VF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njdyb-00015W-8G
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:28:49 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02on0601.outbound.protection.outlook.com
 [2a01:111:f400:fe06::601])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 70d3dad0-c60c-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:28:48 +0200 (CEST)
Received: from DB3PR08CA0005.eurprd08.prod.outlook.com (2603:10a6:8::18) by
 DB9PR08MB6537.eurprd08.prod.outlook.com (2603:10a6:10:250::22) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.13; Wed, 27 Apr 2022 09:28:38 +0000
Received: from DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:8:0:cafe::76) by DB3PR08CA0005.outlook.office365.com
 (2603:10a6:8::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:38 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT055.mail.protection.outlook.com (10.152.21.30) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:28:38 +0000
Received: ("Tessian outbound ab7864ef57f2:v118");
 Wed, 27 Apr 2022 09:28:38 +0000
Received: from f7af931dfd82.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B8337183-C9E2-4605-9B2C-0756620C920D.1; 
 Wed, 27 Apr 2022 09:28:32 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f7af931dfd82.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 09:28:32 +0000
Received: from AS9PR06CA0126.eurprd06.prod.outlook.com (2603:10a6:20b:467::25)
 by PA4PR08MB6255.eurprd08.prod.outlook.com (2603:10a6:102:f1::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 09:28:30 +0000
Received: from VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:467:cafe::17) by AS9PR06CA0126.outlook.office365.com
 (2603:10a6:20b:467::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:30 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT040.mail.protection.outlook.com (10.152.18.210) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:28:29 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr
 2022 09:28:29 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70d3dad0-c60c-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ipdc3e1RnMQb/YeZhjG0nay+i9AURQsGfGhypTtQTZBqjqeA9i1hApU0hUe9Wr3wPIucwiG1kkHWS1MsjeBCr7HDQiKOtwpcLkiDM3smNsap0Y8Lz3FbQ5u9Pvkd8muWFg2HT8M6Ro3RL8Qn890P9j0+1DiVkZcbzh1DUyjLvw2MaCOT11mLNZCJxpNRKUKJsRpuJWsisboguWkhyIajD2eO35+y2VeI1lodA1oTfiTHGh0EgBp3jAdNxNnUIo//x0LJ+aVBYk2ZP3xWcojfzYDPM0r026re0cG+0hSJull+TSY5/IhUxGsNFJHxQ8klTPCb4rab4qDFuBVUUKiiQA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0qA9JxuQq7jj4LbeGwyi4Yeymfcd0bnxAGCmwirOLIs=;
 b=UnGIenCDFTFWpHO9cAVCJmo83LymqJR/v3K80WDoRgcyFxDxBCp0lsblpqoyW0AzMz983963X7BfShy250GpM6w9j52N7/UGLWkTDV3cy6LAbm5a/ok/BB8xXlJ2FrPAoOAJ2EQTVQnuAae9sLT4TtMRVxgFYj1B24YSvI8n4pXiUNXQJoqXXQZ1NPIv9qg6UN/ZCtVruyorbzLgFGltGdUDulYwrrnXdau8xYDJcKFcB52c7gZZ+zTvp/f3QvikryY8ewUvLiOXh/7yZyVT3bkEOvXIAWj1dihIoXm6yWHBw7XduA7eyOB+kkBdog2LxTzJbZQ/UDHQqOrKvd8YNQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0qA9JxuQq7jj4LbeGwyi4Yeymfcd0bnxAGCmwirOLIs=;
 b=JZyVFCDJR6FeRXHZ3xmBdZYzD0/AjkKfeu91czzeGKit2Y5lZWkyCS1EWLxhvdhtEuyb35XASBV23ldIXbm+6IWuqh6OpK+fe4bgRX+WpyIJIO+lHNnB4RinTqQD+aWp9k7B7G1rU+wcF1DaUzSpRj4/tPMwYwm/Sxf5Y0KsuRc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: e3ddfc275cec7f16
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bMXZ6FPmUhRUIoKeaT3JrAo8nAdFFV9SBwmfJP3MEhKo5LqfY7j/C1Jr0fQFO+K0frNx5ScqEL9QkS50SCTUMbktq7oSQGSHFtC3SI/ENmZHwWbVNNsn8jjEI92fSwTbYRXbAkGozf0nz0v4ihMSIvRzI0IqREswNB0hd5//mLq/iiktZ2CSztWATJ80F9YyoK532EAaDFuQ1a4jk1l89gmUdkZeQWIQ4cG2bDIUdjn8Z562eLfkyzl7kRldcRqP+F05pggqYp3HIWUzMakQUUMlNCRpmaQndVgcWemNaCGcNCt19Gp7vFjRNegBdVHsWwZR/pAph5hCjjlL8If2pA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0qA9JxuQq7jj4LbeGwyi4Yeymfcd0bnxAGCmwirOLIs=;
 b=AGCRo13vVysLgQ6zELxmR1cV2W+kcH1WTsGqo+iCVRX+ef9bU5Dtnuae/zTT8BIHFBGfcSUivV1IIkSGKUkpDXC7adCruk76l78OQG2gnBmPFUSd6OywHR+JcMWRDHoNtk8XpognIlFFhkXBEH4BnsWau8ptyBpVFqVv9Ludv7INS/xoXXRD7jHDJkaJtY1Fq6fKpHoycxD09lkcW6CuuohgUXyG3BsJpwORvXQnAqaREGuvBEenlXtHIoA8zKFq36p6fOv6WSDy0aIncI1DkgGldgTFapsVo8iorr9gN7bBaFaZvTeNjKjgWRwbvKBsUKENxd1uHd8RF4S+z0OLNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0qA9JxuQq7jj4LbeGwyi4Yeymfcd0bnxAGCmwirOLIs=;
 b=JZyVFCDJR6FeRXHZ3xmBdZYzD0/AjkKfeu91czzeGKit2Y5lZWkyCS1EWLxhvdhtEuyb35XASBV23ldIXbm+6IWuqh6OpK+fe4bgRX+WpyIJIO+lHNnB4RinTqQD+aWp9k7B7G1rU+wcF1DaUzSpRj4/tPMwYwm/Sxf5Y0KsuRc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, <henry.wang@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Penny Zheng <penny.zheng@arm.com>
Subject: [PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages()
Date: Wed, 27 Apr 2022 17:27:39 +0800
Message-ID: <20220427092743.925563-3-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427092743.925563-1-Penny.Zheng@arm.com>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 36b494a7-3363-4682-2fb8-08da28304f97
X-MS-TrafficTypeDiagnostic:
	PA4PR08MB6255:EE_|DB5EUR03FT055:EE_|DB9PR08MB6537:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB65375AB60748B8361E97C88FF7FA9@DB9PR08MB6537.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 AWx/5t2DB2QmJrYK1Or6f3Y5sa0SXa6EFCN5YLjEx5KHn9BJdpQv38GHQlCMwbPVymr1F/ARdUQ+dm6aKyGntpSNm0x8YGSGc4XInMKb30T2kSUyZcx+d9uz8e3W/ab7hesVTDhiC+eveRzHPR+VFunHucfr0KdVryGqWmVzoB4Sc91AHSf74QcZDDCASXgXbZaOFl53LIFXygRhU/SKMWl+Q7ao6RQ1wDXs6lct1QJ/t3Yi0WFY7jbpA0PJY8ymDjKEPEtDL+yjDy1bX+BgzCAZM6BQ9cohni3qWdZ67EoB1BZ71pG5v/zr8oWZMnsvgSAF2ZdwTfldrLzBnYCJJFuzxrUhPaWAQvXZH7Z/iuQzr1rlsJ+C6tNIZqyXdWmc51nhk/9aV8TCz2aKM0ex1rWmbjbqjieQ+3GvzYNW2lcgjxqeauprjPCyvpJ3bORMF/I57VPQFrMiq+fe95HcGliDpMzZPH2nAMHXuLO8lV6gu61cHLxZJcZc8FzZbX2mCvQgMsYbzue+AW5MTm3z4zRzoc3zvsuya64UwXWyCXA3lqleaunvlHpeFUR8fXejnG77V8DrmvMvwe9oY5OaHmfd/O2G7CqUartwVEbHyAGAVhLtI9s7dva+QDTCDGzv/gjLqLCRAYxpp1zwj/AamuEPPY9aT30L3O85VXuBUM2rfOIJRlftYwk6+U2jmP+861xG3wgH91NilCfQiW2wDg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(8676002)(4326008)(70586007)(356005)(83380400001)(70206006)(7696005)(2616005)(86362001)(54906003)(6916009)(316002)(47076005)(186003)(1076003)(336012)(426003)(81166007)(6666004)(508600001)(40460700003)(26005)(36860700001)(8936002)(2906002)(5660300002)(36756003)(82310400005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6255
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	663a81de-99b2-440f-259f-08da28304a57
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HTwKq9JaZ7EHMetoVjuvKD/tQyU5DNbsuAvE3bSa6SjQqR9lCMIpttuUAKwyxZ5lBy36ZBCc3qxQuk4gNsSp+wnVq/udnYXLAHUP9I074S0RgFEXFkx5jBX1hFLUoHPE+aC1Y5EK0glRLPFdeNBDKSUpGKDzjSKTQfM28o+0XDJKi2gpzU4JfAhd2oO5GEzXjJJDejnYojUZm3uQx703f/a3SiEsSSXHJUwXBwJlfvcoBPw+P7dI5kTKgPjedF/YUUKca2vtZ6uYZnILMAihqFzrUQxQvxOU5OnRKqqNPgN6zoA/CPFJrCYt01pU1lb2x2L+WmleS7z0pVbgpijIkBqxFLAYQCTw8VtX2fAeLkOYdP+r3VZViq0NnIjoJh03PCRay3/pa7qMPdwrE6TdUBDxg/u9raVacGVh0BNXpd1RfCPugMdNbRa82taB2Njq2p7A7eawTYIPNzKFFO0zYwQ1xH8AdeaDkkIOEz2nLYNHY78PYGWDQkvWrwgfR+t3azZhinx/yzE6gXCKfutBEO/YH8LqesomMZplzWxE7frqmtpkPKl4fhIMcJ4t+7XHt8rq9TToKZcuZ7nbX4vBec69IkQc1BUjAnN505wEB99bqvhpDeRX/ogXJDQR/35C0ZvH0yzhzEG86JuisjruhN1qPpUkfhk5RI+GVkuglisiXRopNwu1PiYhtY0Fkhl5
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(70206006)(8676002)(70586007)(36860700001)(2906002)(4326008)(40460700003)(6666004)(86362001)(5660300002)(8936002)(508600001)(26005)(83380400001)(7696005)(2616005)(47076005)(6916009)(54906003)(316002)(1076003)(36756003)(336012)(426003)(81166007)(186003)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:28:38.5195
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 36b494a7-3363-4682-2fb8-08da28304f97
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6537

There is a slim chance that free_heap_pages() may decide to merge a chunk
from the static region(PGC_reserved) with the about-to-be-free chunk.

So in order to avoid the above scenario, this commit updates free_heap_pages()
to check whether the predecessor and/or successor has PGC_reserved set,
when trying to merge the about-to-be-freed chunk with the predecessor
and/or successor.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v3 changes:
- no changes
---
v2 changes:
- new commit
---
 xen/common/page_alloc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index be501582a3..1f3ad4bd28 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1483,6 +1483,7 @@ static void free_heap_pages(
             /* Merge with predecessor block? */
             if ( !mfn_valid(page_to_mfn(predecessor)) ||
                  !page_state_is(predecessor, free) ||
+                 (predecessor->count_info & PGC_reserved) ||
                  (PFN_ORDER(predecessor) != order) ||
                  (phys_to_nid(page_to_maddr(predecessor)) != node) )
                 break;
@@ -1506,6 +1507,7 @@ static void free_heap_pages(
             /* Merge with successor block? */
             if ( !mfn_valid(page_to_mfn(successor)) ||
                  !page_state_is(successor, free) ||
+                 (successor->count_info & PGC_reserved) ||
                  (PFN_ORDER(successor) != order) ||
                  (phys_to_nid(page_to_maddr(successor)) != node) )
                 break;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:29:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:29:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314616.532774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdyr-0001bD-Ub; Wed, 27 Apr 2022 09:29:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314616.532774; Wed, 27 Apr 2022 09:29:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdyr-0001b6-R3; Wed, 27 Apr 2022 09:29:05 +0000
Received: by outflank-mailman (input) for mailman id 314616;
 Wed, 27 Apr 2022 09:29:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ksbQ=VF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njdyq-0000n9-8I
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:29:04 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on060d.outbound.protection.outlook.com
 [2a01:111:f400:fe02::60d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7953a565-c60c-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:29:02 +0200 (CEST)
Received: from FR3P281CA0026.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::17)
 by DB9PR08MB7116.eurprd08.prod.outlook.com (2603:10a6:10:2c9::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 09:29:00 +0000
Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1c:cafe::ab) by FR3P281CA0026.outlook.office365.com
 (2603:10a6:d10:1c::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.6 via Frontend
 Transport; Wed, 27 Apr 2022 09:29:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:28:59 +0000
Received: ("Tessian outbound 62985e3c34b6:v118");
 Wed, 27 Apr 2022 09:28:59 +0000
Received: from eae4235bb0d5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 77FF16C7-2200-46AB-9358-7ABC31E92AE4.1; 
 Wed, 27 Apr 2022 09:28:52 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eae4235bb0d5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 09:28:52 +0000
Received: from AM6P192CA0086.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::27)
 by VI1PR08MB5453.eurprd08.prod.outlook.com (2603:10a6:803:132::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 09:28:49 +0000
Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8d:cafe::bc) by AM6P192CA0086.outlook.office365.com
 (2603:10a6:209:8d::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:49 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:28:48 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr
 2022 09:28:39 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7953a565-c60c-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ca957iFd3GwcadLwUBIDY2Xk61wjByJebQxyw/mmKDb2q7Lh7ol7sDSmTmR+2Nwcy+Bvy/gez8fYIiZyrGpXL7M4llq5SrqjBJg6ofioBE9OIUE1LMalh7b1CSrh4L039WY0wtqfSAw/rmPVWG1KwWWW+0ci7BkmsfdKmC8zI2/TMcsSnR55zcLzAm9E445ecNlybVKsurELMx8Rz9zkZhjraIvjit3beCjljzJMUisgnH/O5QmZAlpU5DNxHofDV5zsQGgVebT8x1kKUCi6dA4pcN1/3fQF4UYkPN6Pm8rI6mpwsTLrI8X/gUSCW/yhtoFvc0sEkk3smr4h6huzLQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gKV5xiCmhipxoNF2c34Y3bk6wQOs8dxWyNC/VQODx1s=;
 b=iyTOPSfCeh1M3ZF4i1u6E685Nd0i9+Z7Gk+YOSKwh/uUcXYKvA5b2FAvrcSpgfs41GFE8aF89XShXRQbWDERhGtpQElMvzPW3Ki8IVGx6Gnb3JMqTHGc4vcPkS4JgfLS+SuIQ0Tn8Sv5nxJ7o9/nP6wP6qZ9d8h0ASyp2G0TAqprEFR6M16nGK4Ba5dxMO+b4R8SYORo6Efzq1eKkXC5eeUTFdKlmcQPO7rXVREz0oIR9GyRPnYKTXCVgbur+fz5SRgkEGHDwbj1wKBVj1EIvsSrLjcDG4+2saV+TsUUXIRjV+gmAyuuqe7s95LVzhTeV0l/axZLvhYLwOApTWyoNA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gKV5xiCmhipxoNF2c34Y3bk6wQOs8dxWyNC/VQODx1s=;
 b=k83bgoeH6Jm7PC8uN4PicxtmnmTachNYARFHrkVtBnRB8GUpcdzh81NOQiO7vxnHx+Fosgep6kT+96mgbb07DHsczyTxyhOSRV5Dg3q17mGiyvYBvE37aNkinQvRU9BH3DwK6mL8HJAy2KiXvb+ctC6d70jDk6TfdeeaFghqx4M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b0351bf2feed9c09
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iSLOTXDgBsOyagF0KTsSY8SYlON3Zr/TSjLE/RM73no0g98EKxpShw9hVHGsSm6w4IV41y0FvlBefX6wgllPHlkNMYgUXps+/gQj9uFxcSaIJhq0yHFtPHHKo6mPbExs5l8DGS8BdNo79MUVxbHGbtmNAU418R5JkCmYu35OwJauJGjXIYOgjKYBP0tNMhHapZtRiZyCgS4I/pC+bT8cZemSafM+UX7RiY+EKwRxkIMD2E4bil2AmuaEkKKEQ45W64DbGCuptsDjyo+as/biqdH+vMqSu917KJTCtlGSC4zd1XRCuWhgoGJs7dPUbuTntqwo6DzCaxV2sRfj8WZUzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gKV5xiCmhipxoNF2c34Y3bk6wQOs8dxWyNC/VQODx1s=;
 b=NAQEzoOpN30dQe3a5WB1YHDHkrcOVZ5h4X7W+2dFKuAPZPsJ6rIKtiAhfiNrs7bpvhWJZL65912LxhJ+T6YqkIKnqSkFYFDHCmx4GZo+rqVljPCoKdlGG8iI+Dy4PAaIVeLdDTllIyl40ckau6iyRO3otr95ATrYXRUEUZFnTAtI+PVFatnzt2dkR/Cp/1dHeYSQsRc55hAo6Y9H9JrG4Eb5nz5G2jxz+ljrIB24i9YC1npziFyHoIvZVeCE4BR0SDAEaUrr6pIcOtcoiiEj1uuQqmoYe/kBuAI4Ts213nc0k7m/mN+aE4eeLqoVm7pxxoyBQ2YOc8AbkfHdXbe6tA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gKV5xiCmhipxoNF2c34Y3bk6wQOs8dxWyNC/VQODx1s=;
 b=k83bgoeH6Jm7PC8uN4PicxtmnmTachNYARFHrkVtBnRB8GUpcdzh81NOQiO7vxnHx+Fosgep6kT+96mgbb07DHsczyTxyhOSRV5Dg3q17mGiyvYBvE37aNkinQvRU9BH3DwK6mL8HJAy2KiXvb+ctC6d70jDk6TfdeeaFghqx4M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, <henry.wang@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, "Julien
 Grall" <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Penny Zheng
	<penny.zheng@arm.com>
Subject: [PATCH v3 3/6] xen: add field "flags" to cover all internal CDF_XXX
Date: Wed, 27 Apr 2022 17:27:40 +0800
Message-ID: <20220427092743.925563-4-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427092743.925563-1-Penny.Zheng@arm.com>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: cc2d2d35-9304-4bf6-c4d2-08da28305c34
X-MS-TrafficTypeDiagnostic:
	VI1PR08MB5453:EE_|VE1EUR03FT057:EE_|DB9PR08MB7116:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB7116DCF4CE8D30A6AE170F2DF7FA9@DB9PR08MB7116.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 LPrdKLX2hlNxyN93t931MKCbSZb/Fau2N51CeW6V9aPu9cTp1mH0/QIG4d1JkB9I4KxCWPROI0hEk+Df4x1L0JWtRFq3ZbWEL8Fzo6HVDlIQIwexvvBjEwf1a6xAnXCJf51/BZ2eu1dBydGp7n6ER0cUiv33BRyi1QWlcnyEYlCdGr3j1KHs0aUL7OlkPvkmiNKw5Ci8qQBcW1haindCBmEm2EohDTNsTGbokPUSy2o88cN7jcDv0t++nHo4bHPb25jYkm7BbONbV5gDhxxwtOBfXdu9+jpmle2MzxOdHyGLYyKzmkP2xlJaRftY5/0Z0DtIi8jbKJkylmDVrs9933v7sX5lmyoa+QHIfy3150SFBQFjCj/JGTKYf4SC+G/+FPcXv4UvVnoEbe5Mu10oMefCFKQp09Kxi4pMU4KhR7EfNZoqUBtiQR4PteUvnsnFZdVcNatMZc0LmADgxgYTk2d2pPJMco+O6OsWK+fetZ9R4lTLqkEu7pWFu0n6Y0OHTj8v+ej6sOP1F3Y5yqWjH0qHx25MvPQHWyaWwQottYCo4wVduxByjAlpxIeoCY7FvkQRJL4Qxreg8KF78Pw9rgME6p34HNJZgPZScw4pZwrqmXIrty/OHKloNayHd4ndsy+nWEv2AsnIJX3ppKH2/hdLg0z6/KZUw+In5GaQQ4EUUH48DXXIJHzqqoaBq+W6oQDHmmnjSbcCOLXokh8k8xuq+fGANlcFtAaukGLhbDk=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(426003)(336012)(508600001)(82310400005)(2616005)(47076005)(86362001)(40460700003)(1076003)(26005)(356005)(81166007)(6666004)(7696005)(186003)(2906002)(316002)(36860700001)(70206006)(36756003)(5660300002)(8936002)(70586007)(54906003)(4326008)(83380400001)(6916009)(8676002)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5453
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fcf7d022-2bed-4ff2-1992-08da283055b7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wJa8vUXa5eCEqu7ecyfTe8VMJbdBIBjxpTRdrxEnh83UBVsA7CQ8kC4UyRpZ2UaNsT7U1R2cOyP5M14p7cB6B0ekwbsIQ/WNbVj6XybJR98k+vpOVpoOPOyFJzSM6HGm446HEmwdNObx42wkUO/ETsmMeF6d991rvWDbeQK7f5+JaO/g+LR4MBpLsVn4T/tnt3XJ5aBbxA566Sh4vA1dxQbOygXvXN5aSKa6ZLGF1CF0NETocCMiCYXXw8shaFebDrBiPfHbG6lsxB+TFlwsg2vt8WoOS57Ftv6brOb9P1kOpOw9wltq6mJMuDffObOfA3i3rz1Cfi+aUZcyuiWDg9isIE/ECeVpb2owNbJ1JqIP7+gDq3T7d/j5k2wnSV2WmgAf89+An6cyujhTH8LuTj0kz2r20tRbobz14oDaGMmCSjOVxqYEK9UY8u6Qyk5myy+jnD+hTwkTqG7CHHuqN16iXctqNcHOie2wIiW+nfrWXbnTYNTAnwlOpPZ0YiQ3MXV3lNl0Kz6q3UZFm187rCGOlOO4lslHKdcczbJ+XZGGEYl8QOOtC2vBKkzFA5xiMOI0pAEbvlpsQJqOsZOxhwmwXBcQAUoEeg/QboIKRFflf50M/vxlQEaWt4EKLiecnC3lSwHSa9QXKrSnFgDdsCsqO+eFw5OBcEYXnEgA+Uz3dxzePuFMft9VsSqLMZLC5x4Ehgb/Vba0ffzVv7lJRA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(36860700001)(26005)(7696005)(6666004)(54906003)(83380400001)(86362001)(47076005)(336012)(2616005)(186003)(426003)(1076003)(8936002)(4326008)(40460700003)(8676002)(2906002)(5660300002)(82310400005)(36756003)(81166007)(508600001)(70586007)(6916009)(316002)(70206006)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:28:59.5443
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cc2d2d35-9304-4bf6-c4d2-08da28305c34
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7116

With more and more CDF_xxx internal flags in and to save the space, this
commit introduces a new field "flags" in struct domain to store CDF_*
internal flags directly.

Another new CDF_xxx will be introduced in the next patch.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v3 changes:
- change fixed width type uint32_t to unsigned int
- change "flags" to a more descriptive name "cdf"
---
v2 changes:
- let "flags" live in the struct domain. So other arch can take
advantage of it in the future
- fix coding style
---
 xen/arch/arm/domain.c             | 2 --
 xen/arch/arm/include/asm/domain.h | 3 +--
 xen/common/domain.c               | 3 +++
 xen/include/xen/sched.h           | 3 +++
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 8110c1df86..74189d9878 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -709,8 +709,6 @@ int arch_domain_create(struct domain *d,
     ioreq_domain_init(d);
 #endif
 
-    d->arch.directmap = flags & CDF_directmap;
-
     /* p2m_init relies on some value initialized by the IOMMU subsystem */
     if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
         goto fail;
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index ed63c2b6f9..fe7a029ebf 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -29,7 +29,7 @@ enum domain_type {
 #define is_64bit_domain(d) (0)
 #endif
 
-#define is_domain_direct_mapped(d) (d)->arch.directmap
+#define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap)
 
 /*
  * Is the domain using the host memory layout?
@@ -103,7 +103,6 @@ struct arch_domain
     void *tee;
 #endif
 
-    bool directmap;
 }  __cacheline_aligned;
 
 struct arch_vcpu
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 8d2c2a9897..6373407047 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -567,6 +567,9 @@ struct domain *domain_create(domid_t domid,
     /* Sort out our idea of is_system_domain(). */
     d->domain_id = domid;
 
+    /* Holding CDF_* internal flags. */
+    d->cdf = flags;
+
     /* Debug sanity. */
     ASSERT(is_system_domain(d) ? config == NULL : config != NULL);
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index ed8539f6d2..49415a113a 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -591,6 +591,9 @@ struct domain
         struct ioreq_server     *server[MAX_NR_IOREQ_SERVERS];
     } ioreq_server;
 #endif
+
+    /* Holding CDF_* constant. Internal flags for domain creation. */
+    unsigned int cdf;
 };
 
 static inline struct page_list_head *page_to_list(
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:29:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:29:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314618.532785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdyw-0001yM-9x; Wed, 27 Apr 2022 09:29:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314618.532785; Wed, 27 Apr 2022 09:29:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdyw-0001yC-6A; Wed, 27 Apr 2022 09:29:10 +0000
Received: by outflank-mailman (input) for mailman id 314618;
 Wed, 27 Apr 2022 09:29:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ksbQ=VF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njdyu-00015W-SB
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:29:09 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20610.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::610])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7ce389f7-c60c-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:29:08 +0200 (CEST)
Received: from AM7PR03CA0014.eurprd03.prod.outlook.com (2603:10a6:20b:130::24)
 by AM0PR08MB5347.eurprd08.prod.outlook.com (2603:10a6:208:17f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 09:29:06 +0000
Received: from VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:130:cafe::72) by AM7PR03CA0014.outlook.office365.com
 (2603:10a6:20b:130::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend
 Transport; Wed, 27 Apr 2022 09:29:06 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT031.mail.protection.outlook.com (10.152.18.69) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:29:06 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Wed, 27 Apr 2022 09:29:05 +0000
Received: from 561f0d3f7380.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7981905B-B85C-4EA6-9582-316B10F5BBC5.1; 
 Wed, 27 Apr 2022 09:28:59 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 561f0d3f7380.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 09:28:59 +0000
Received: from AM6P192CA0107.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::48)
 by DB6PR0802MB2503.eurprd08.prod.outlook.com (2603:10a6:4:97::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 09:28:56 +0000
Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8d:cafe::49) by AM6P192CA0107.outlook.office365.com
 (2603:10a6:209:8d::48) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:56 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:28:56 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr
 2022 09:28:49 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ce389f7-c60c-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=HfhCtJnwBt2pArU8TSVp6ZpUqeJ6J/UwQmD085e9c1UPnLTKkn0WCBwxeKajleyCO3qw+QGQ0EAv2ZYNJI8Ii7qen6wLncCZoJKfW02uh6DHPXCzs7ksmq/GYTuOfKPCjcvZHzXXCXHs1/0eMsuM2m7rzNZs1q3hsfpi/2gXylR2ZsGScnuZNxzDbyQfMJ4heY9P78hNtUtS8+vYpCNozbVuEW9XgB4eby4+i0yfvbj9hoeRVOyK3UAgvBBNSCYMLK1mxqxd03w5Zv0kRFSvzJETCXe8RNMGB7IxbQRkUKZhhlaBn3+Xtbrhlq5Fi2fV6S6dsAvas6xbLq6cNcmyZw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tc8bIziiDz6ap/XVy6bFd+Wj+r4OC2m3pmrld4YMMWs=;
 b=c6MavAhP3pQhqZTHg/lHz0VNXg2URbwNGXkoOK/v9gUt8sjVCmmrkJSPu78Cv4MmIZrxvPAb/r1E8n1eA7AFrEkepLxrldL70BDv7ujptA48EYB1iLA9sc+whXs+awzhWUezsfT4OtaJ1UwSBn3emtc5BcGys6Gz376EOLp1HAoB7+JHUAntHC73RpLsSow9UQbpLVERwPbMe5UTrGqqifP6F/2eVTJOUE/wsIi0NO1swP1gX96dHmel79U3LCi73v6w/gWDhIGDPxffh3/0Dd0onB3D+j+8ifKTKtqlLWGpGFBy/sIYjB5jqRfsvcOdoKTQkpd+cgm/XX0Yyg15Qg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Tc8bIziiDz6ap/XVy6bFd+Wj+r4OC2m3pmrld4YMMWs=;
 b=7RG4tWEsQW3NIPjwW4pcs/oC2d8R1dWDgACz9tTHTnFiTmB/CBoxapq02dHGxR5V+z2fcW6DFyxHf6oG+uP2ns2hDlrCTwLOIiiYwrmwViHlC0jqoRy2WT4/6uNf3R/ip4vEwsy7XRyPVjbxexkPDFe4KcaQqxiAnvG6zPFmmL8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 10335ee396b426b7
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aH//NYMbAvLuGgJ/sm1XUff/yS1pY3tckyIsUDdmF8xKdo835V3dAfU87+8T7yoEeLX5XadkcnpufcatcX2jjpxtTuDe7G5IMJtqMMfUV/gxwrdC6KM3IVOStiYlEshI5joKKHGZEcEHFOs8IB5melE3GLssooOi3yDOnKUnezfWDDWG1wF5fj2176pR/XlQkODIJ6blyF76rcMs7+O/ebySeYAFNThwi0vdoChXuJKU1ewkPsOyEoTZiF9KhPmgYqbd9XRTi5tZ+Oxmlgl6dhTFebMtQ/H1AA9T5yo9ZPST26p0SDpeU4KBfIzUserAz+0retsW9s0RVEdfTUNVTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tc8bIziiDz6ap/XVy6bFd+Wj+r4OC2m3pmrld4YMMWs=;
 b=LpTS85ObVdYtRSONaujt9ujFWoDXizGd7S0gIe4A4ynK4pVQ+MPT7MDG1BwYV8cRcn+onbHoYQBWx+N17uNK3r683qqImPRC57CMqjLxwa1N8hv/Jz4nfx8tNtjeSumPdD5KZxPq52IQv1lm9sqjeeuBWyoSwhlbugdQTeVeG4umLLD/UF++uP0yRoIxQq0Y/0DK0Yo+QRPUPA5hHLwAIw/Ty4/lEsRy1SJq8cKj6EvlUel4mPeTo+KBCsPalAvIEQzNEaHEV4k7vR5t38IHYXOeXODxHqUpIT4S0wKXCWoVq6NDq5vPAReLrUtzBedGyxYbWkqeZV945K64JvANBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Tc8bIziiDz6ap/XVy6bFd+Wj+r4OC2m3pmrld4YMMWs=;
 b=7RG4tWEsQW3NIPjwW4pcs/oC2d8R1dWDgACz9tTHTnFiTmB/CBoxapq02dHGxR5V+z2fcW6DFyxHf6oG+uP2ns2hDlrCTwLOIiiYwrmwViHlC0jqoRy2WT4/6uNf3R/ip4vEwsy7XRyPVjbxexkPDFe4KcaQqxiAnvG6zPFmmL8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, <henry.wang@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, "Julien
 Grall" <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Penny Zheng
	<penny.zheng@arm.com>
Subject: [PATCH v3 4/6] xen/arm: introduce CDF_staticmem
Date: Wed, 27 Apr 2022 17:27:41 +0800
Message-ID: <20220427092743.925563-5-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427092743.925563-1-Penny.Zheng@arm.com>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 50ef8318-7abc-4890-77da-08da2830601a
X-MS-TrafficTypeDiagnostic:
	DB6PR0802MB2503:EE_|VE1EUR03FT031:EE_|AM0PR08MB5347:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB53479AD255EBC9565E14CFDCF7FA9@AM0PR08MB5347.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 hvLdJQuIGXtdgN1+lpJUggGxQq09Vc9J7Y10f+zhmSJVU3k61A9mj/FCBmJwceM4dI54kVJoG/AtGRPoFDp+Tp0+zk77WGGzHbxuuVJN7l5DZyorbSregzNQGOz4aF1qdWfwy82jjMAEH/SnHg2xyvRAOwYehTJyPdrJsiQs68WxZbUZtnDSnpxmb2uWZd4sVXhBQYqZa9KVeoyjjlBM5/lQdtbxggGljoG6g0dlGiUBOyTU8iII4w/4HM5bY/ctcqZlhOacPsQZtKGjBi6Wvl8cev75zajHyhBLv7HyLwHC4PBTofwMl1IU7KZC8Gzk8umGPpOgQ4Wwrq7RIAeNukD4Ay97VcDKDwJJ1OoxT49olc8wwRuw3dYivq3kXaTAwLhLaLMK/mhJuyMZ5N1N/phqNcOKWvV0JrldetK0AQ9RHvNna95ReWY2WT6yHBQ+Ty5YBzepTnU6EJlrRDfMskmI+ZKFGUd7lpAUsZvtv13f3rBjm+NxUMG2cbbOyQm4IlnZ2hTANeN3nSK5ccMeLaPZPhOwTK0Mk2itmyIgK5iP3T8RiJrkUUSZeOV2Hnz/C9o9MRXB+iIswF9DV98K+r+mD79tTIlxqmBqzQTHxyrh0ICiKwdIdPbhwoMie3VXv24ZEQz4e9GfEapnS8So23mfa/EHHeZps7jPX+g52b43sFqPxLiPF43BiYrojwYFDWPHlTg2VR9RWfsVZQBtbQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(86362001)(26005)(82310400005)(36860700001)(70206006)(70586007)(8936002)(36756003)(54906003)(356005)(316002)(81166007)(6916009)(40460700003)(4326008)(508600001)(8676002)(5660300002)(2906002)(186003)(336012)(426003)(47076005)(1076003)(83380400001)(2616005)(7696005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2503
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	df0ac107-1037-4f61-bc3d-08da28305a1e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gkdHmxSDSsLUbrY1LLxOo5/uoGWtPiu8gowBhQhZO69roIGNhaQySzLSmBYzB/7QiNJDY0Aj9I5FicfE2VHZW+gR5xVPIiob6QdcYhRdxj9iOYU7Id6m5pmceByAaVPt/PlMae1OGHb7q9fjMWpS2kFSo/Juhwp/nN4bFTj8xY3ob9GuUiNefEyu5SOqASJMvA4aqfmO+2ULb0Z3jz5XJXmEbwjU3Tfw0B73WljlkVsXVa+isEHikDJlV1D+rU/Jg/obExJROyVhr+CNhedT5gX4l1a7mEbtTwmNRkVXg9zOlz5LStnyMyCKQaFqQ7axfavF0EJEfEGTbh5ujFX7moUqhyQbCu2911LgzjcrMMojsrA+xzvIPfwaR9jUHpz2EyBxDqE/AM0ga2do68JHsh5TB3UPPFI4D2j1Vmks1+KoLSzDmon59VQUxbh+UvcUaB9dSvWRpdNGUPB852a2p87xZ+zOjTKuA+BJGdUuIyVJL+wqT7nzFI3EL6vKh8TzH3EiT6Fg9yaZxezkoKZTZw5/pXEk4CsFbfftHGkiP7hHrhOH8uu3G0y4RgrAHzgTcUJx2t1qVH/WTwTxamkCV8QI9I9Wg1m2MN4a0Rg5sd36gw8OXeu/krmVY24EJfwCCSVzPChaRQyUkKKDvan1vflrdqGCcguovtDptJriTOcppXqQsOF+Dk3/QrUvw+/a
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(508600001)(26005)(40460700003)(81166007)(2906002)(5660300002)(82310400005)(36756003)(36860700001)(8936002)(7696005)(70206006)(2616005)(8676002)(4326008)(70586007)(83380400001)(1076003)(47076005)(186003)(336012)(426003)(54906003)(6916009)(86362001)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:29:06.1297
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 50ef8318-7abc-4890-77da-08da2830601a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5347

In order to have an easy and quick way to find out whether this domain memory
is statically configured, this commit introduces a new flag CDF_staticmem and a
new helper is_domain_using_staticmem() to tell.

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v3 changes:
- change name from "is_domain_static()" to "is_domain_using_staticmem"
---
v2 changes:
- change name from "is_domain_on_static_allocation" to "is_domain_static()"
---
 xen/arch/arm/domain_build.c       | 5 ++++-
 xen/arch/arm/include/asm/domain.h | 2 ++
 xen/include/xen/domain.h          | 2 ++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 1472ca4972..6830a282a0 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3190,9 +3190,12 @@ void __init create_domUs(void)
         if ( !dt_device_is_compatible(node, "xen,domain") )
             continue;
 
+        if ( dt_find_property(node, "xen,static-mem", NULL) )
+            flags |= CDF_staticmem;
+
         if ( dt_property_read_bool(node, "direct-map") )
         {
-            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) )
+            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !(flags & CDF_staticmem) )
                 panic("direct-map is not valid for domain %s without static allocation.\n",
                       dt_node_name(node));
 
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index fe7a029ebf..110c672589 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -31,6 +31,8 @@ enum domain_type {
 
 #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap)
 
+#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem)
+
 /*
  * Is the domain using the host memory layout?
  *
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 1c3c88a14d..35dc7143a4 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -34,6 +34,8 @@ void arch_get_domain_info(const struct domain *d,
 #ifdef CONFIG_ARM
 /* Should domain memory be directly mapped? */
 #define CDF_directmap            (1U << 1)
+/* Is domain memory on static allocation? */
+#define CDF_staticmem            (1U << 2)
 #endif
 
 /*
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:29:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:29:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314623.532796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdz8-0002YE-I7; Wed, 27 Apr 2022 09:29:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314623.532796; Wed, 27 Apr 2022 09:29:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdz8-0002Y3-EU; Wed, 27 Apr 2022 09:29:22 +0000
Received: by outflank-mailman (input) for mailman id 314623;
 Wed, 27 Apr 2022 09:29:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ksbQ=VF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njdz6-0000n9-J9
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:29:20 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on060c.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::60c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 83515e1a-c60c-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:29:19 +0200 (CEST)
Received: from DB6PR0402CA0002.eurprd04.prod.outlook.com (2603:10a6:4:91::12)
 by DB7PR08MB3913.eurprd08.prod.outlook.com (2603:10a6:10:7c::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 09:29:17 +0000
Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:91:cafe::c2) by DB6PR0402CA0002.outlook.office365.com
 (2603:10a6:4:91::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend
 Transport; Wed, 27 Apr 2022 09:29:17 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14 via Frontend Transport; Wed, 27 Apr 2022 09:29:17 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Wed, 27 Apr 2022 09:29:17 +0000
Received: from 9e0162dee0fb.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 88035E24-03D7-4FEC-8848-972454D7FA5F.1; 
 Wed, 27 Apr 2022 09:29:10 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9e0162dee0fb.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 09:29:10 +0000
Received: from AS9PR04CA0105.eurprd04.prod.outlook.com (2603:10a6:20b:50e::27)
 by AS4PR08MB8096.eurprd08.prod.outlook.com (2603:10a6:20b:58b::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 09:29:08 +0000
Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:50e:cafe::e1) by AS9PR04CA0105.outlook.office365.com
 (2603:10a6:20b:50e::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend
 Transport; Wed, 27 Apr 2022 09:29:08 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:29:08 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr
 2022 09:28:59 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Wed, 27 Apr 2022 09:28:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83515e1a-c60c-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Lp14PJgJSL8DfRY/vNVSTgnaJP2+SXMtOOaxSIdSN0G4aM5/fBYLJIYOAFjptaxa+83YZhxJED9CAGp+7zwj0E6fc0Qlfr9XBRJP+HDrXXEwd4Ow1xEiEMDKbnJ7J/lJednUxQsCAF02YPLXXpfaapzeuSYqvg7+RZ7RW4ZylLhZY/72Xkgp8AkvrpnQFr0iU+dLU40fgzOvBoBtIRlpg2qVviFOVl5Rv78ey7WWnNbIOqduYP8ZxAAxmXTGMv7Y0YYVT9SOsQz6xRROZUUw/yP/vleGtXsZ+DHJTxDCSFoJoZNHH2A1DxRF8SFld7T7EQ74K7FFjW8KvRrukTVJOw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rCND5tjX5cKrs7fmmCD71EclFIECccAGVb3ArYFdizM=;
 b=RBR5KkIyVp5gpUt7Eu4MJi3NvQluON6G3W3eywgyhW9bNwt1g4NZWmt+Ru31RFbvfYUP+cOPVrxUQzhhYIbfeMhuiMtCHxWidRRPsiCQOTKZTr9aRJWsN4QdXQp70SP2IX5J0n5I+F871AyI0ZYgG/7gLkjvdzIj+rQjYQk2hD+4oemlveXIL0XueuMvZuuprBHo7P6Qo+KoVopsWdw/NiHlxQd8me98rk05A5E0S5vzW712fPpDAqOBupprT9Dp1TgAAjboFl2n3C4R0ritHDUgNE+1ubPapzaadJDGYkTF34O8k4JVpq3oRS9S6EBPm5+7bZIbM8nYTjNhnmagPw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rCND5tjX5cKrs7fmmCD71EclFIECccAGVb3ArYFdizM=;
 b=wkowdLebUts6R/rCfiZDkpGh6/X2YaY/K24k60FdILdg972WFRUaytQ1xDsAxyL86ms3pw2bSuuCPC0KKlCHw4oxLKQSnZCM7iZr3wqQFYaNDUJcJGON7L2t+PmYNa3ZUN8+9gyw7dVIl8Grp8gZL9Ed63tmK5ceo4u9F2WuH+c=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: aafece6b67b8cb1f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DW8tuW/3PO3wj6ibJeBkmJxfFZgNLMjZ7tiByBHf0tda8nRNSZ3rplcFJROl57zqMDK5i9Zb/EPy8DzeA1ItH60aptA44Ok7GNKXGPSkuIpQPvBQQwZT/HvsAH5UXUEWd+DlpE+n3Oo0iaKwiFrrlnKY3k6isataHH7eQG6QNnsWKYG4p7tQPAYWFy9qhyCU0fGHnTimmMZYYhkxhyva1Q9CQMCzpcD0Vdj/o/EjOqdwb4g6lWjmzBNME9V6VKHFAo73/qhYRwLfVLqaqHi3SQnCHxetujQUsFNm17oZu7A56smfPc49t2Pjo0PO3nBakb+1PV9TgTscui6Rej1DIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rCND5tjX5cKrs7fmmCD71EclFIECccAGVb3ArYFdizM=;
 b=mYTkotw3LsfsobX6sYZ/FfNfEwK2wW2W/6vpMvVudajP5GD65FAepkRcYH8f1b5CMBt8ORrtDJRvAxAYmblIm5bzQlQwfFbTZly71kA/muxJfGcC2uMFTKEkPAbn4cjNRwxVvKMuLou7rLSAIQmIE4VeRGrHSYCFNji7xZzLSBYY3NanwpPQmkf9BCR2vpix/JSxXgumoypDs8p1EOL6ncOSOTqXmhHZAu/xPSufOCJhV5tLsbCiEeELTIjqI5FIXzszeFRmYrz3Rj0O1WN+NF0Vxx7YayIvopDEHuhg03mWbut+GrAeZiudxFFyfLYbU3yZeZPt3TJ1teQ3/kJMVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rCND5tjX5cKrs7fmmCD71EclFIECccAGVb3ArYFdizM=;
 b=wkowdLebUts6R/rCfiZDkpGh6/X2YaY/K24k60FdILdg972WFRUaytQ1xDsAxyL86ms3pw2bSuuCPC0KKlCHw4oxLKQSnZCM7iZr3wqQFYaNDUJcJGON7L2t+PmYNa3ZUN8+9gyw7dVIl8Grp8gZL9Ed63tmK5ceo4u9F2WuH+c=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, <henry.wang@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, "Julien
 Grall" <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Penny Zheng
	<penny.zheng@arm.com>
Subject: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
Date: Wed, 27 Apr 2022 17:27:42 +0800
Message-ID: <20220427092743.925563-6-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427092743.925563-1-Penny.Zheng@arm.com>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: f4131831-1799-4b14-1aad-08da283066d5
X-MS-TrafficTypeDiagnostic:
	AS4PR08MB8096:EE_|DB5EUR03FT063:EE_|DB7PR08MB3913:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3913943753B17E25B0951544F7FA9@DB7PR08MB3913.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DqS6UQL8zbObI10JODmPFKntvpE/EsMonDE2eqCLZxVxP8Abuf5MJrkGyL4EjwW+Y/w2tI+0XnzgFiTyGLhzvF6XIr2DG24yt8jT9bJqqlumkMeg2NBDmG2St3PUH1SuDJGw+nMxvbW5awgeAYbXBX2L0PPsHmz1Yw3DGmLJ1UWQBDv9oS9bECIXkPU+uKtx6jcJsEDygybn0Qs/Xahx4E13BVv+U5u7UH0sWF9XAN/E/iX9H7Q1jlosi+MzkowgOzQvMkKzheyN997mTVJlyy/44HUdKs1P8y9ZL3N2Tn/2IpOZm6AvBRjOPBJiAxoUz5XZcTD/5zTmu3lFP3XZxCj3QeBdoYKeEDSAexLoUPNUlanPSRvMVKi49dzvJFNstMOCQQ7pVXBbjVa6dl39TDwcGh7BmNcw4k7BA2uKeAo5ZSut3e1pl4QrcyTEaRMIDbGQqzptuEY4n5NvNlQ7m25rJQS1KApTUtLFfamvjOWLVuJCSH8hxe++7i6pCRUo82lFBC0ibfnaui2Zx5esk9Ya3ZVj/3DSp1XQCoihb+ddZbqUTxWZt+LJClcz5Hjx9jo2JDPGBevWlqh5Nc2+eTFFc4wOGDM94reWbkUPDIdbhyJ0rd0UzKiWVnN1ZGYI4GUWjOld4tZ7pmfhmYbYXhJo1TP+juQtmxH35OLPIbgMD7JNmY21Q9UBAinODzYQichS5nDfU95Cuy0dJXBTWw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(40460700003)(81166007)(70206006)(70586007)(47076005)(4326008)(8676002)(2906002)(356005)(54906003)(6666004)(316002)(36756003)(6916009)(7696005)(508600001)(83380400001)(5660300002)(336012)(82310400005)(2616005)(426003)(1076003)(86362001)(186003)(26005)(8936002)(36860700001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8096
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0b5be69e-92ff-44d8-95d7-08da2830616e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zRNPADpIKlJhypvZvuOdckqGNnMcN6kYoOSHTuQXffMVNngTfSRABTypNlW/1OkspLYmjqCAu8G+Iyqyt1wTHru2yYM5mdrwCR5fEvLnBv1SUFrKoJEr8wrU29QTjFo9vVMOLu6/ntAR0F3S2kNbscmEwi+ve3az2RIeS2kAReLYEYwiUiPa9dqX8k1bGQ+9qrk1qAlb7dEFoYcKKzqnk1HiXkk1HFg7m8faexs39MGvYxyOkXiwbGghdcqNXaEa4zauGlNsBfo0gDn21rLQ6dMWnznvJPnAGEk2pYX5idSj2JrylOi+1ZeRvqwR6hPLQ+YuM3F/5sgLPd8ld9B58a9sm/XJqs8EIKTmZP9PSQGMl/euzNDVnRxPBspcEf2x4nQ4Yj5f0ikwjdThYx1hFoR0vTkdr9S1zlbQtrwfXt+pXcRxfQcNbey1qEbdOFik9HC7MT/VZ8OSsmsZl0slEwg3ZWWXioUjI4tAwO1WDQppo131sijS1zWH2QRw7juEzlWn/SBJ0aO3mSVY8rjeSMJ3zZz8tq43fqPMMJeNoBARAbbeVwLjbeT7fCnDUlY48Gtaswf2Ce7oRiSlNp9UC0rCGzqgOPfjFuk+eUIaINrxMf4FGA4YBYUhL5y8q1aFRV5qEKVKOdAIjfdfaX4HNxk4bwCpf4S0v4xqKjoao2Yu8jxxoLCnr2AiAotWhe6M
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(2906002)(316002)(86362001)(81166007)(5660300002)(8936002)(70206006)(70586007)(4326008)(8676002)(6666004)(83380400001)(47076005)(40460700003)(1076003)(7696005)(336012)(26005)(186003)(426003)(54906003)(6916009)(2616005)(508600001)(36860700001)(82310400005)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:29:17.4973
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f4131831-1799-4b14-1aad-08da283066d5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3913

Today when a domain unpopulates the memory on runtime, they will always
hand the memory back to the heap allocator. And it will be a problem if domain
is static.

Pages as guest RAM for static domain shall be reserved to only this domain
and not be used for any other purposes, so they shall never go back to heap
allocator.

This commit puts reserved pages on the new list resv_page_list only after
having taken them off the "normal" list, when the last ref dropped.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v3 changes:
- have page_list_del() just once out of the if()
- remove resv_pages counter
- make arch_free_heap_page be an expression, not a compound statement.
---
v2 changes:
- put reserved pages on resv_page_list after having taken them off
the "normal" list
---
 xen/arch/arm/include/asm/mm.h | 12 ++++++++++++
 xen/common/domain.c           |  4 ++++
 xen/include/xen/sched.h       |  3 +++
 3 files changed, 19 insertions(+)

diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
index 424aaf2823..c6426c1705 100644
--- a/xen/arch/arm/include/asm/mm.h
+++ b/xen/arch/arm/include/asm/mm.h
@@ -358,6 +358,18 @@ void clear_and_clean_page(struct page_info *page);
 
 unsigned int arch_get_dma_bitsize(void);
 
+/*
+ * Put free pages on the resv page list after having taken them
+ * off the "normal" page list, when pages from static memory
+ */
+#ifdef CONFIG_STATIC_MEMORY
+#define arch_free_heap_page(d, pg) ({                   \
+    page_list_del(pg, page_to_list(d, pg));             \
+    if ( (pg)->count_info & PGC_reserved )              \
+        page_list_add_tail(pg, &(d)->resv_page_list);   \
+})
+#endif
+
 #endif /*  __ARCH_ARM_MM__ */
 /*
  * Local variables:
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 6373407047..13fe7cecff 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -604,6 +604,10 @@ struct domain *domain_create(domid_t domid,
     INIT_PAGE_LIST_HEAD(&d->page_list);
     INIT_PAGE_LIST_HEAD(&d->extra_page_list);
     INIT_PAGE_LIST_HEAD(&d->xenpage_list);
+#ifdef CONFIG_STATIC_MEMORY
+    INIT_PAGE_LIST_HEAD(&d->resv_page_list);
+#endif
+
 
     spin_lock_init(&d->node_affinity_lock);
     d->node_affinity = NODE_MASK_ALL;
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 49415a113a..368e5c1c53 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -376,6 +376,9 @@ struct domain
     struct page_list_head page_list;  /* linked list */
     struct page_list_head extra_page_list; /* linked list (size extra_pages) */
     struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */
+#ifdef CONFIG_STATIC_MEMORY
+    struct page_list_head resv_page_list; /* linked list (size resv_pages) */
+#endif
 
     /*
      * This field should only be directly accessed by domain_adjust_tot_pages()
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:29:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:29:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314624.532806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdzD-000308-0J; Wed, 27 Apr 2022 09:29:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314624.532806; Wed, 27 Apr 2022 09:29:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njdzC-000301-TH; Wed, 27 Apr 2022 09:29:26 +0000
Received: by outflank-mailman (input) for mailman id 314624;
 Wed, 27 Apr 2022 09:29:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ksbQ=VF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njdzC-00015W-5x
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:29:26 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02on0630.outbound.protection.outlook.com
 [2a01:111:f400:fe06::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86fdbeb6-c60c-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:29:25 +0200 (CEST)
Received: from AM6PR05CA0017.eurprd05.prod.outlook.com (2603:10a6:20b:2e::30)
 by HE1PR0802MB2363.eurprd08.prod.outlook.com (2603:10a6:3:c8::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 09:29:22 +0000
Received: from AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2e:cafe::c6) by AM6PR05CA0017.outlook.office365.com
 (2603:10a6:20b:2e::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend
 Transport; Wed, 27 Apr 2022 09:29:22 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT052.mail.protection.outlook.com (10.152.17.161) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:29:22 +0000
Received: ("Tessian outbound 9613c00560a5:v118");
 Wed, 27 Apr 2022 09:29:22 +0000
Received: from ef1b70aa2845.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 19911613-40BF-4E00-8FCF-3EEB1596DE4F.1; 
 Wed, 27 Apr 2022 09:29:15 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ef1b70aa2845.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 09:29:15 +0000
Received: from AS9PR04CA0096.eurprd04.prod.outlook.com (2603:10a6:20b:50e::26)
 by GV2PR08MB8052.eurprd08.prod.outlook.com (2603:10a6:150:75::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Wed, 27 Apr
 2022 09:29:13 +0000
Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:50e:cafe::19) by AS9PR04CA0096.outlook.office365.com
 (2603:10a6:20b:50e::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend
 Transport; Wed, 27 Apr 2022 09:29:12 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 09:29:12 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Wed, 27 Apr
 2022 09:29:09 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Wed, 27
 Apr 2022 09:29:06 +0000
Received: from a011292.shanghai.arm.com (10.169.190.94) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend
 Transport; Wed, 27 Apr 2022 09:29:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86fdbeb6-c60c-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=lx3muvo1NlYjIRnnCg1kt3OFOpKsUqq0PYoEogUasjlIPigg1ZmUPEWmGE8MPto+mhdGkXhvUEMqgN2DIsuUw3SITjghayxLbPY1iRZ615rwJoVHKZT0ECKEodfPDYpvPyqNBg+STctti5BCCHWS3OE2t+vMvWWt7Tprwt0RSjfFvD4xt871CdAdYpaNlWa/7UuvMcccvfSYnj7WXzNPocpdlQ+ki6PLkDgxLjz1kANfJpC+40TY8ma1mt7R/aLjd7E9/NzIh1KLSIT3qCKYYDVd1eCPs9olwbKrKRqNcDPbq413PVsT9RXJRbkJao8mEJmccJ62vmWgWVcogrYvuQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nqcTO4An0BbV9XfJHUHLhj5Zal3nPygOYB8CUZJHxi4=;
 b=jIRWwNoqH63Jm5Ju9lr39dEPu1WB4gYILPphBCrzKJXIvMDlVbv2K7rHjARfbMQs/hFp36hYxbBKZu25x/wWRGshnyb6y/4naQIdiVw6eZwpRb5Q/qo98d2MIKSkwLTKnIEeSyfwNMMa5s9UKvoSR1jGA9UonP7TEa/6SzhZj9myrvng+9yWDdsIUbH1HVPeEf5f8ewsaNrYxxav6Ub5U2lBUX76SN9QlCmGGyoyt2Lc1fgN1FYy49LsabucmL6zjAF47NbkzI3BG0N4id4RGYqWtMmjUkRNcAFvEoIkwm4xIGYHJkjsRj5Bdt9OrEGcRBP8F1Kg3/hVZ155Pw/CZw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nqcTO4An0BbV9XfJHUHLhj5Zal3nPygOYB8CUZJHxi4=;
 b=3abGuENAl1r7u00mChf+Xh6QW0FI1QdciX/j9njLNLntUMdBeVQ+Rby01mdCyfAEUrGgi2EslaG9EJapZapwyMEJWNr5WogyjpzjX9PGyRNZsDO4KV6iK2piB3UINbrWRQK86vFmNIx1dbLNHtIx1GP2ZVJ4ayzGiLPzIWFthNU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b06a487819eedf4d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NHWeu1xM4N6IL9tfKciKbagCXC/TR8susY2uFAgeyrPFuoSt7c3VJ9FOu55myfqqrC3yd0FpMAX2uIOgIpc/lWh2Cszj5KyAd+gX5LylJUr59KeY0Qrx1kgpB0j13h9i1kOLCHUXZex7yuP5yWCMfFGx8RP7feakMJQ3gBHDSH9+DqywR9HAOODAv5VwPqc0PDx1xLwRI91+Yq8eo3EvXRs5DO9czhMWnWagEDUbpYiZ7L48ViH1IPeY4pXkfCU5oKvNeohT81SFx67G0dfsjzLeAmlEeiR7H8mbXHxhvFeuZmQBi6v2d9vGuxM9X+cFzwO/1ybJF1eAHXShsL6/fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nqcTO4An0BbV9XfJHUHLhj5Zal3nPygOYB8CUZJHxi4=;
 b=U1eEY0dqSIK+Ysny16f3TO96ijWbwrS1A/NYGj6Dp9jQNLQCr2LfiRVp2Dxob/3WtcjU/bZ67D+N708WyvxOcfC0zeVCXMjGTKbkUfhHIcD6EoQYfA35RgAFHMj+LVDVyPUo/oiNdEF8gD0Fibtd0fxopNXJmQQP20m/dB5b+W52mLsaqkKM4BLW+Jqyet1gzP9G9vQuRNy2hgysgFViDvfiTEkkESmHcHygWfBJ8tynGl4LLyPoQvmPuzzJZOni/LFAVWfIpHCdBvSRo3kApZM8cQ3CYZ/8K7nK2breLxKFjZjN1wE+oK3ESoweMU4Q0xY3Dtr1Xs5N/DrchT+CAQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nqcTO4An0BbV9XfJHUHLhj5Zal3nPygOYB8CUZJHxi4=;
 b=3abGuENAl1r7u00mChf+Xh6QW0FI1QdciX/j9njLNLntUMdBeVQ+Rby01mdCyfAEUrGgi2EslaG9EJapZapwyMEJWNr5WogyjpzjX9PGyRNZsDO4KV6iK2piB3UINbrWRQK86vFmNIx1dbLNHtIx1GP2ZVJ4ayzGiLPzIWFthNU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <Penny.Zheng@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <wei.chen@arm.com>, <henry.wang@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Penny Zheng <penny.zheng@arm.com>
Subject: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap
Date: Wed, 27 Apr 2022 17:27:43 +0800
Message-ID: <20220427092743.925563-7-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427092743.925563-1-Penny.Zheng@arm.com>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 2508ef9c-4a05-4230-4942-08da283069c4
X-MS-TrafficTypeDiagnostic:
	GV2PR08MB8052:EE_|AM5EUR03FT052:EE_|HE1PR0802MB2363:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0802MB2363F4FCD50681354AEA2BC9F7FA9@HE1PR0802MB2363.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 gdoBoYK/OIMyiV9XnuWnT9a4L/tOa2B7LKMnWSi9Vf2nobRNq3qs63KqyhChWntCK2glnDqwqIBE9BdOELgXzIqi8sq4ewMhnkwR5buLsvvAeQyu8+JpQm1JWi9g74wYBlB/3BOgaVmhZUCgdo+o2m/4XQCyq5uqt08VMM4vGRvFXTkr5VtdXW1qsFfljHfFSGjhUkKeaTox+10crtHtlPu65/g4xdvKY6u5NoskMx7XFf/tkTx6p1e0Nnj5JI1EqFR0pGKJxwEWddEHqYRvmZieDfTEKhiTR1Kar4+pJTSfPxDn8eTj46bhIzZnP5s3JKhyACQW2FVHMoUbyTaUKdbGMPb0BKcSYgsk7Isvfmhl0lA8wqhmNIh5grLEaaSraqBPJHL8T8Cx1hOOV+xShTybNbF7I9NgKyoHFVdJ2HljvumXajrMIX7d80WcKjFc5sOpsZpVuVUTFlKB+EzxUkWEqL7dFyIIGeARldnzyupBeiYgE6t0rv9PCJUVH29mYB9CH7PkX+mQf/3FlBG4h8VhbxORxcpZ5wXkRtpTsoRcnfUuMaa9HpQFmL0jB/vyA9ckx8GfqgBg6bhS28S7IdWnD6thKZZjLy2bbxGpwnZB8k8fhmS9zO/FLj06JYbw8uB2Iu9wCyQzita4F2NVJHrPNFpvE6W1vN8ZpY8M4dSPmBc4x31UrvpnimtHN+q3YuLtfwWTRtqwJfj/pT7DhA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(47076005)(2906002)(6916009)(7696005)(70206006)(6666004)(83380400001)(70586007)(356005)(186003)(86362001)(36860700001)(4326008)(40460700003)(8936002)(54906003)(8676002)(508600001)(426003)(26005)(36756003)(336012)(81166007)(82310400005)(5660300002)(2616005)(316002)(1076003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8052
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a46b7fa6-f55f-4a58-3f5a-08da28306406
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N6c1Ihfe0cmjtFPH2PJbQqLz+tAeMGs3Fi3nrezTzXJjUV0RMnHbV6rVTIrR3+6AcZp1j/TT22y3cvLI57krMU4nUJYdYldfxD4GtWtvPoQn0ngZkhsZpISYiIfpNDSvWIXjPPYwjS/t/AI4ibayAAKAuez51FMJINcqJlYBEOEn6FN+pJxKS7teoFF32cDTXgl937MgkCR2Ztc61JspYSj2I2p/6j+vGP1mvgq5S3xr8JRsKVLKoKJ0wWPzC0gOoFp1agUfVfqb/CZgd0F0tBVF3NoCMbRJZ+UnOJ7udXj6ew4uwIJf8Eihrr/3OpJIavraki6T06CiQIBLmIFhxHJ87RsGnLj1dYXaFHeHOXW0Um6t/dYd+HhzsVAJHtvlk9Ns3L+jw/qaW9VTorug3t+GnizC6QJBKImNYBa39RjTWRt/lGO6zByiMA0s1VFvyWYMlr/wZrDRqtiTPO3YezqVkW0BzBAIvlNUOr0LAXYyx2Wi2ei8L1MgzEuKz2ld9mwmx61XwvAl5oUbODw2gBymcS2SzF68UfvLFWybyhu5bImF4loWPuwOF8/n3QjX26rSNJCBn+D7T/bJ5K0IQLr0WF/nPNDNraBKGKu4YLYczFp2huNoZ6EXDKyLkGDsSzUgzjCKQ2Z7g2EBi/2YlwXkoOgLvOgxdnnmQUFqTXzcx66gC8/Z+JvMunjDb8Xh
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36860700001)(26005)(6666004)(7696005)(54906003)(83380400001)(86362001)(47076005)(336012)(2616005)(186003)(426003)(1076003)(8936002)(4326008)(40460700003)(8676002)(2906002)(5660300002)(82310400005)(81166007)(36756003)(508600001)(70586007)(6916009)(316002)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:29:22.3734
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2508ef9c-4a05-4230-4942-08da283069c4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2363

When static domain populates memory through populate_physmap on runtime,
other than allocating from heap, it shall retrieve reserved pages from
resv_page_list to make sure that guest RAM is still restricted in statically
configured memory regions. And this commit introduces a new helper
acquire_reserved_page to make it work.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v3 changes
- move #ifndef is_domain_using_staticmem to the common header file
- remove #ifdef CONFIG_STATIC_MEMORY-ary
- remove meaningless page_to_mfn(page) in error log
---
v2 changes:
- introduce acquire_reserved_page to retrieve reserved pages from
resv_page_list
- forbid non-zero-order requests in populate_physmap
- let is_domain_static return ((void)(d), false) on x86
---
 xen/common/memory.c      | 23 +++++++++++++++++++++++
 xen/common/page_alloc.c  | 38 ++++++++++++++++++++++++++++++++++++++
 xen/include/xen/domain.h |  4 ++++
 xen/include/xen/mm.h     |  3 +--
 4 files changed, 66 insertions(+), 2 deletions(-)

diff --git a/xen/common/memory.c b/xen/common/memory.c
index 69b0cd1e50..6cee51f0e3 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a)
 
                 mfn = _mfn(gpfn);
             }
+            else if ( is_domain_using_staticmem(d) )
+            {
+                /*
+                 * No easy way to guarantee the retreived pages are contiguous,
+                 * so forbid non-zero-order requests here.
+                 */
+                if ( a->extent_order != 0 )
+                {
+                    gdprintk(XENLOG_INFO,
+                             "Could not allocate non-zero-order pages for static %pd.\n.",
+                             d);
+                    goto out;
+                }
+
+                mfn = acquire_reserved_page(d, a->memflags);
+                if ( mfn_eq(mfn, INVALID_MFN) )
+                {
+                    gdprintk(XENLOG_INFO,
+                             "%pd: failed to retrieve a reserved page.\n.",
+                             d);
+                    goto out;
+                }
+            }
             else
             {
                 page = alloc_domheap_pages(d, a->extent_order, a->memflags);
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 1f3ad4bd28..78cc52986c 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -2769,12 +2769,50 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
 
     return 0;
 }
+
+/*
+ * Acquire a page from reserved page list(resv_page_list), when populating
+ * memory for static domain on runtime.
+ */
+mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags)
+{
+    struct page_info *page;
+    mfn_t smfn;
+
+    /* Acquire a page from reserved page list(resv_page_list). */
+    page = page_list_remove_head(&d->resv_page_list);
+    if ( unlikely(!page) )
+    {
+        printk(XENLOG_ERR
+               "%pd: failed to acquire a reserved page from resv_page_list.\n",
+               d);
+        return INVALID_MFN;
+    }
+
+    smfn = page_to_mfn(page);
+
+    if ( acquire_domstatic_pages(d, smfn, 1, memflags) )
+        return INVALID_MFN;
+
+    return smfn;
+}
 #else
 void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
                           bool need_scrub)
 {
     ASSERT_UNREACHABLE();
 }
+
+int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
+                                   unsigned int nr_mfns, unsigned int memflags)
+{
+    ASSERT_UNREACHABLE();
+}
+
+mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags)
+{
+    ASSERT_UNREACHABLE();
+}
 #endif
 
 /*
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 35dc7143a4..c613afa57e 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -38,6 +38,10 @@ void arch_get_domain_info(const struct domain *d,
 #define CDF_staticmem            (1U << 2)
 #endif
 
+#ifndef is_domain_using_staticmem
+#define is_domain_using_staticmem(d) ((void)(d), false)
+#endif
+
 /*
  * Arch-specifics.
  */
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index 9fd95deaec..32b0837fa0 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -88,10 +88,9 @@ bool scrub_free_pages(void);
 /* These functions are for static memory */
 void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
                           bool need_scrub);
-#ifdef CONFIG_STATIC_MEMORY
 int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns,
                             unsigned int memflags);
-#endif
+mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags);
 
 /* Map machine page range in Xen virtual address space. */
 int map_pages_to_xen(
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:39:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:39:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314657.532821 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nje92-0005NZ-45; Wed, 27 Apr 2022 09:39:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314657.532821; Wed, 27 Apr 2022 09:39:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nje91-0005NS-Ve; Wed, 27 Apr 2022 09:39:35 +0000
Received: by outflank-mailman (input) for mailman id 314657;
 Wed, 27 Apr 2022 09:39:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nje90-0005NM-FW
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:39:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nje90-000288-0O; Wed, 27 Apr 2022 09:39:34 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nje8z-0000QF-QH; Wed, 27 Apr 2022 09:39:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=I+28T+DDvm4eITMDqJNGSBnDw1r1vdwO2PyWoGHOrjw=; b=2JyXxoBxbbVlvjiX0674G5Y7/U
	ixywtufH+Vz3FSgMcvV1eNr3OJpHZx85ALLxwsVxhsehre2Yt6hneJsizlb5sTb1vQGoXwU+miPPu
	3f1MlrYl1JNwT1edw22JDERUOSXetI0b8yCtaYhAWcYfHTS+fnN9u04vBTdyoUBTJsac=;
Message-ID: <6d7a3a35-4244-6c10-024e-9e7ada318d48@xen.org>
Date: Wed, 27 Apr 2022 10:39:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v3 2/6] xen: do not merge reserved pages in
 free_heap_pages()
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, henry.wang@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
 <20220427092743.925563-3-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427092743.925563-3-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/04/2022 10:27, Penny Zheng wrote:
> There is a slim chance that free_heap_pages() may decide to merge a chunk
> from the static region(PGC_reserved) with the about-to-be-free chunk.
This sentence tells me that the merge can happen but it doesn't tell me 
the cases. I think the second part is more important to know.

The code in free_heap_Pages() will try to merge with the 
successor/predecessor if they are suitably aligned. So the issue can 
only happen if the pages reserved are right next to the pages given to 
the heap allocator.

> 
> So in order to avoid the above scenario, this commit updates free_heap_pages()
> to check whether the predecessor and/or successor has PGC_reserved set,
> when trying to merge the about-to-be-freed chunk with the predecessor
> and/or successor.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
> v3 changes:
> - no changes
> ---
> v2 changes:
> - new commit
> ---
>   xen/common/page_alloc.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index be501582a3..1f3ad4bd28 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -1483,6 +1483,7 @@ static void free_heap_pages(
>               /* Merge with predecessor block? */
>               if ( !mfn_valid(page_to_mfn(predecessor)) ||
>                    !page_state_is(predecessor, free) ||
> +                 (predecessor->count_info & PGC_reserved) ||
>                    (PFN_ORDER(predecessor) != order) ||
>                    (phys_to_nid(page_to_maddr(predecessor)) != node) )
>                   break;
> @@ -1506,6 +1507,7 @@ static void free_heap_pages(
>               /* Merge with successor block? */
>               if ( !mfn_valid(page_to_mfn(successor)) ||
>                    !page_state_is(successor, free) ||
> +                 (successor->count_info & PGC_reserved) ||
>                    (PFN_ORDER(successor) != order) ||
>                    (phys_to_nid(page_to_maddr(successor)) != node) )
>                   break;

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:41:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:41:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314662.532832 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeAe-0006kM-Dl; Wed, 27 Apr 2022 09:41:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314662.532832; Wed, 27 Apr 2022 09:41:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeAe-0006kF-AV; Wed, 27 Apr 2022 09:41:16 +0000
Received: by outflank-mailman (input) for mailman id 314662;
 Wed, 27 Apr 2022 09:41:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTkK=VF=gmail.com=raphning@srs-se1.protection.inumbo.net>)
 id 1njeAd-0006k0-7E
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:41:15 +0000
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com
 [2a00:1450:4864:20::42c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2d6e079e-c60e-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:41:14 +0200 (CEST)
Received: by mail-wr1-x42c.google.com with SMTP id x18so1718865wrc.0
 for <xen-devel@lists.xenproject.org>; Wed, 27 Apr 2022 02:41:14 -0700 (PDT)
Received: from [10.7.236.33] (54-240-197-224.amazon.com. [54.240.197.224])
 by smtp.gmail.com with ESMTPSA id
 p125-20020a1c2983000000b0038e5ca446bcsm1191730wmp.5.2022.04.27.02.41.12
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 27 Apr 2022 02:41:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d6e079e-c60e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:to:cc:references
         :from:in-reply-to:content-transfer-encoding;
        bh=e7D4L2zo/iScrOJGIxSEH4U+pJJP3ttdUouBNECk0Lo=;
        b=FNKTrzCsXUIXMkkxusaBodeKzZqcmZ/E7YQwJ4AYQMEQQQSePnkdE3tY+NI8bL3v/H
         hyCGrxU/mLWFfh857MFzQUceLsBKguJvFwv4MfiDO5dxfSgUpssbpRODEPwKd/CpUVDJ
         UGhQydEkQxcKimaqszf6lt3j7K2qN5Od6k5qeymcZmWN21jxvhDGSQ+tjHw3dZbJk0ki
         hcnduSmNuxQdcMbbLgTAYZziXbrOrSXX+Mkc4LzJRRw+tt4aljj2T4g6MChJNGCRMo8u
         Vh2GbYgFXaeJGVwD8+giTN8yC8QwEzw1aQaVUbOvkfMNSLPsQM0hykAuXWg+hMnoQ8Nj
         dOqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :to:cc:references:from:in-reply-to:content-transfer-encoding;
        bh=e7D4L2zo/iScrOJGIxSEH4U+pJJP3ttdUouBNECk0Lo=;
        b=5y0BhjcFEjf7ULddHKWF4yWZ6uBTQj2pqXS9Dz5WGbYdT/5qYlPcYDy/mmrrTCR5+E
         FtqnrPBpiB5tHIU1blqQV0pPqldJmINUqqG+wfU3OzQzKIGuPm3D/+hKBxguPWueSclv
         1tBz5NI44xVZE9dTBlde1bdPtIMVqqd7ofwFAG2WLiKADn04LWQeM4NJoQDd2zB7FsFH
         y0XsBGaIpa7uHb9sXEZ9tLaBMhzcEm6hfnZBtfiQ5iQ8Ead1iIVXGIKATOlkekg5JoKf
         jY6HIXTEAaW5TLkeuRgXlPsfZgF6OXs9ZnXkDAYNbHyLgK4/VYg32JwrN6Bo72xLE0WC
         42qA==
X-Gm-Message-State: AOAM530jZ91IlgrtWOVGm/2BTsDqa47Nzkjcehyu/5nL0hlZXOrNrbpO
	KiDYtMK3ISOjVm+hwRfzl+M=
X-Google-Smtp-Source: ABdhPJwx5CjEeRRMUXX2U0g05MwOiB8wp6r5svuIZveDRqXg4jEOaQ63WFamQAA5Kzrcz3wU6pfEEg==
X-Received: by 2002:a05:6000:49:b0:20a:da03:951f with SMTP id k9-20020a056000004900b0020ada03951fmr11779927wrx.519.1651052473187;
        Wed, 27 Apr 2022 02:41:13 -0700 (PDT)
Message-ID: <18c1113e-cba2-1f99-324e-d146a3ff5cdd@gmail.com>
Date: Wed, 27 Apr 2022 10:41:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [cxenstored] Potential bug in special watch event firing
To: Juergen Gross <jgross@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien@xen.org>
References: <eb024e77-17f4-cc89-f621-a9d5b879c184@gmail.com>
 <13c29d5b-a9e4-9690-7988-767caf0c44b5@suse.com>
From: Raphael Ning <raphning@gmail.com>
In-Reply-To: <13c29d5b-a9e4-9690-7988-767caf0c44b5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Juergen,

On 27/04/2022 08:30, Juergen Gross wrote:
> [...]
>> The xenstore documentation is not clear about whether @<wspecial> should be considered children of /. But I find it counterintuitive that clients may be notified about a special event without explicitly subscribing to it. Is it a bug?
>
> I agree this is a bug.


Thanks for confirming that. I can send a patch to fix it, but it probably won't happen until later next week. If anyone else can get it done sooner, please feel free to do so.

Raphael



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:43:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:43:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314670.532845 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeCv-0007Mv-Qg; Wed, 27 Apr 2022 09:43:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314670.532845; Wed, 27 Apr 2022 09:43:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeCv-0007Mo-Np; Wed, 27 Apr 2022 09:43:37 +0000
Received: by outflank-mailman (input) for mailman id 314670;
 Wed, 27 Apr 2022 09:43:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njeCt-0007Mi-KR
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:43:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njeCt-0002Gb-0i; Wed, 27 Apr 2022 09:43:35 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njeCs-0000do-R0; Wed, 27 Apr 2022 09:43:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Fo45BY6CEq22mHXoDnz15YgIr+nzRGiHzVUkPEClkuI=; b=Jasqfe18audLp/RJ+LahMYwt0Z
	PJEDWDLG6k6NwMhFKdBqy1Y6kortIdwa/ledlACpnSm0UpYXBtrZZ4Qw3EoDLxHZXVI1NBezPmFSm
	P23ihxoXFkx85L2hqDbqam8F8I56W4iQj8xSLNM+6SmUy/agdnQ+TNJcUg9Wt4qu9uvw=;
Message-ID: <d1fcbb5b-5373-ea1b-1894-50a9b065c604@xen.org>
Date: Wed, 27 Apr 2022 10:43:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v3 3/6] xen: add field "flags" to cover all internal
 CDF_XXX
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, henry.wang@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
 <20220427092743.925563-4-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427092743.925563-4-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/04/2022 10:27, Penny Zheng wrote:
> With more and more CDF_xxx internal flags in and to save the space, this
> commit introduces a new field "flags" in struct domain to store CDF_*
> internal flags directly.
> 
> Another new CDF_xxx will be introduced in the next patch.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314681.532879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ5-0000Av-61; Wed, 27 Apr 2022 09:49:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314681.532879; Wed, 27 Apr 2022 09:49:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ5-0000Ai-22; Wed, 27 Apr 2022 09:49:59 +0000
Received: by outflank-mailman (input) for mailman id 314681;
 Wed, 27 Apr 2022 09:49:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJ3-0008Li-MM
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:49:57 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 64f5fa1a-c60f-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:49:56 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B5F7A1480;
 Wed, 27 Apr 2022 02:49:55 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DEFA23F774;
 Wed, 27 Apr 2022 02:49:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64f5fa1a-c60f-11ec-8fc2-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 2/8] efi/boot.c: Remove unused-but-set variable
Date: Wed, 27 Apr 2022 11:49:35 +0200
Message-Id: <20220427094941.291554-3-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Function efi_start defines and sets a variable size but does not
make use of it. Remove this variable.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/common/efi/boot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index ac1b235372..a25e1d29f1 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1226,9 +1226,9 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
     {
         EFI_FILE_HANDLE dir_handle;
         EFI_HANDLE gop_handle;
-        UINTN depth, cols, rows, size;
+        UINTN depth, cols, rows;
 
-        size = cols = rows = depth = 0;
+        cols = rows = depth = 0;
 
         if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode,
                                &cols, &rows) == EFI_SUCCESS )
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314679.532857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ2-00086F-Mg; Wed, 27 Apr 2022 09:49:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314679.532857; Wed, 27 Apr 2022 09:49:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ2-000868-Jn; Wed, 27 Apr 2022 09:49:56 +0000
Received: by outflank-mailman (input) for mailman id 314679;
 Wed, 27 Apr 2022 09:49:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJ1-00085x-6a
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:49:55 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 6317100a-c60f-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:49:53 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A693A1480;
 Wed, 27 Apr 2022 02:49:52 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0037A3F774;
 Wed, 27 Apr 2022 02:49:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6317100a-c60f-11ec-a405-831a346695d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Wei Liu <wl@xen.org>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH 0/8] xen: Remove unused-but-set variables
Date: Wed, 27 Apr 2022 11:49:33 +0200
Message-Id: <20220427094941.291554-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Fix all the gcc findings related to unused-but-set variables when performing
Xen compilation using target allyesconfig on arm32 and arm64. This is done by
temporarily removing flag -Wno-unused-but-set-variable set in Config.mk.

This series acts as a prerequisite to get rid of this flag one day.

Michal Orzel (8):
  xen/arm: bootfdt.c: Remove unused-but-set variable
  efi/boot.c: Remove unused-but-set variable
  gnttab: Remove unused-but-set variable
  xen/arm: smmu.c: Remove unused-but-set variable
  xen/sched: Remove unused-but-set variable
  platforms/xgene: Make use of dt_device_get_address return value
  platforms/omap: Remove unused-but-set variable
  drivers/exynos4210: Remove unused-but-set variable

 xen/arch/arm/bootfdt.c               |  3 ---
 xen/arch/arm/platforms/omap5.c       |  3 +--
 xen/arch/arm/platforms/xgene-storm.c |  2 +-
 xen/common/efi/boot.c                |  4 ++--
 xen/common/grant_table.c             |  6 ++----
 xen/common/sched/core.c              |  3 +--
 xen/drivers/char/exynos4210-uart.c   | 10 ++++++----
 xen/drivers/passthrough/arm/smmu.c   |  3 +--
 8 files changed, 14 insertions(+), 20 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314680.532861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ2-00089D-UR; Wed, 27 Apr 2022 09:49:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314680.532861; Wed, 27 Apr 2022 09:49:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ2-00088U-Qr; Wed, 27 Apr 2022 09:49:56 +0000
Received: by outflank-mailman (input) for mailman id 314680;
 Wed, 27 Apr 2022 09:49:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJ1-00085x-Vs
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:49:55 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 64240b9e-c60f-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:49:55 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F56414BF;
 Wed, 27 Apr 2022 02:49:54 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 084053F774;
 Wed, 27 Apr 2022 02:49:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64240b9e-c60f-11ec-a405-831a346695d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH 1/8] xen/arm: bootfdt.c: Remove unused-but-set variable
Date: Wed, 27 Apr 2022 11:49:34 +0200
Message-Id: <20220427094941.291554-2-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Function device_tree_node_compatible defines and sets a variable
mlen but does not make use of it. Remove this variable.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/bootfdt.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index e318ef9603..29671c8df0 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -36,11 +36,8 @@ static bool __init device_tree_node_compatible(const void *fdt, int node,
                                                const char *match)
 {
     int len, l;
-    int mlen;
     const void *prop;
 
-    mlen = strlen(match);
-
     prop = fdt_getprop(fdt, node, "compatible", &len);
     if ( prop == NULL )
         return false;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314682.532890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ7-0000X5-Ek; Wed, 27 Apr 2022 09:50:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314682.532890; Wed, 27 Apr 2022 09:50:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ7-0000Wc-B6; Wed, 27 Apr 2022 09:50:01 +0000
Received: by outflank-mailman (input) for mailman id 314682;
 Wed, 27 Apr 2022 09:49:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJ5-0008Li-Eh
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:49:59 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6648801b-c60f-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:49:58 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 187241480;
 Wed, 27 Apr 2022 02:49:58 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23F0F3F774;
 Wed, 27 Apr 2022 02:49:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6648801b-c60f-11ec-8fc2-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 3/8] gnttab: Remove unused-but-set variable
Date: Wed, 27 Apr 2022 11:49:36 +0200
Message-Id: <20220427094941.291554-4-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Function unmap_common_complete defines and sets a variable ld that is
later on passed to a macro gnttab_host_mapping_get_page_type. On arm
this macro does not make use of any arguments causing a compiler to
warn about unused-but-set variable (when -Wunused-but-set-variable is
enabled). Fix this by removing ld and directly passing current->domain
to gnttab_host_mapping_get_page_type.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/common/grant_table.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index febbe12eab..71b1107999 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -1556,7 +1556,7 @@ unmap_common(
 static void
 unmap_common_complete(struct gnttab_unmap_common *op)
 {
-    struct domain *ld, *rd = op->rd;
+    struct domain *rd = op->rd;
     struct grant_table *rgt;
     struct active_grant_entry *act;
     grant_entry_header_t *sha;
@@ -1569,8 +1569,6 @@ unmap_common_complete(struct gnttab_unmap_common *op)
         return;
     }
 
-    ld = current->domain;
-
     rcu_lock_domain(rd);
     rgt = rd->grant_table;
 
@@ -1608,7 +1606,7 @@ unmap_common_complete(struct gnttab_unmap_common *op)
         if ( pg )
         {
             if ( gnttab_host_mapping_get_page_type(op->done & GNTMAP_readonly,
-                                                   ld, rd) )
+                                                   current->domain, rd) )
                 put_page_type(pg);
             put_page(pg);
         }
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314683.532895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ7-0000b1-Sq; Wed, 27 Apr 2022 09:50:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314683.532895; Wed, 27 Apr 2022 09:50:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ7-0000aH-LZ; Wed, 27 Apr 2022 09:50:01 +0000
Received: by outflank-mailman (input) for mailman id 314683;
 Wed, 27 Apr 2022 09:50:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJ7-0008Li-4C
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:01 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 67496221-c60f-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:50:00 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D6BB01480;
 Wed, 27 Apr 2022 02:49:59 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 73CDB3F774;
 Wed, 27 Apr 2022 02:49:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67496221-c60f-11ec-8fc2-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH 4/8] xen/arm: smmu.c: Remove unused-but-set variable
Date: Wed, 27 Apr 2022 11:49:37 +0200
Message-Id: <20220427094941.291554-5-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Function arm_smmu_init_context_bank defines and sets a variable
gr0_base but does not make use of it. Remove this variable.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/drivers/passthrough/arm/smmu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
index 5cacb2dd99..c21c4f3ac0 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -1086,10 +1086,9 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain)
 	bool stage1;
 	struct arm_smmu_cfg *cfg = &smmu_domain->cfg;
 	struct arm_smmu_device *smmu = smmu_domain->smmu;
-	void __iomem *cb_base, *gr0_base, *gr1_base;
+	void __iomem *cb_base, *gr1_base;
 	paddr_t p2maddr;
 
-	gr0_base = ARM_SMMU_GR0(smmu);
 	gr1_base = ARM_SMMU_GR1(smmu);
 	stage1 = cfg->cbar != CBAR_TYPE_S2_TRANS;
 	cb_base = ARM_SMMU_CB_BASE(smmu) + ARM_SMMU_CB(smmu, cfg->cbndx);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314684.532911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJA-0001Ib-52; Wed, 27 Apr 2022 09:50:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314684.532911; Wed, 27 Apr 2022 09:50:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJ9-0001IA-W4; Wed, 27 Apr 2022 09:50:03 +0000
Received: by outflank-mailman (input) for mailman id 314684;
 Wed, 27 Apr 2022 09:50:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJ8-00085x-Ps
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:02 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 683cf94c-c60f-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:50:02 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E6EA14BF;
 Wed, 27 Apr 2022 02:50:01 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 525183F774;
 Wed, 27 Apr 2022 02:50:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 683cf94c-c60f-11ec-a405-831a346695d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH 5/8] xen/sched: Remove unused-but-set variable
Date: Wed, 27 Apr 2022 11:49:38 +0200
Message-Id: <20220427094941.291554-6-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Function schedule_cpu_add defines and sets a variable old_unit but
does not make use of it. Remove this variable.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/common/sched/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 19ab678181..8a8c25bbda 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3104,7 +3104,7 @@ int schedule_cpu_add(unsigned int cpu, struct cpupool *c)
     {
         const cpumask_t *mask;
         unsigned int cpu_iter, idx = 0;
-        struct sched_unit *old_unit, *master_unit;
+        struct sched_unit *master_unit;
         struct sched_resource *sr_old;
 
         /*
@@ -3128,7 +3128,6 @@ int schedule_cpu_add(unsigned int cpu, struct cpupool *c)
             if ( cpu == cpu_iter )
                 continue;
 
-            old_unit = idle_vcpu[cpu_iter]->sched_unit;
             sr_old = get_sched_res(cpu_iter);
             kill_timer(&sr_old->s_timer);
             idle_vcpu[cpu_iter]->sched_unit = master_unit;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314686.532923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJC-0001qA-Fa; Wed, 27 Apr 2022 09:50:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314686.532923; Wed, 27 Apr 2022 09:50:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJC-0001pU-AS; Wed, 27 Apr 2022 09:50:06 +0000
Received: by outflank-mailman (input) for mailman id 314686;
 Wed, 27 Apr 2022 09:50:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJA-0008Li-MV
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:04 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 695eb213-c60f-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 11:50:03 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54D7014BF;
 Wed, 27 Apr 2022 02:50:03 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C278B3F774;
 Wed, 27 Apr 2022 02:50:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 695eb213-c60f-11ec-8fc2-03012f2f19d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH 6/8] platforms/xgene: Make use of dt_device_get_address return value
Date: Wed, 27 Apr 2022 11:49:39 +0200
Message-Id: <20220427094941.291554-7-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently function xgene_check_pirq_eoi assignes a return value of
dt_device_get_address to a variable res but does not make use of it.
Fix it by making use of res in a condition checking the result of a
call to dt_device_get_address instead of checking the address
stored in dbase.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/platforms/xgene-storm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c
index fced4d7c2c..befd0c3c2d 100644
--- a/xen/arch/arm/platforms/xgene-storm.c
+++ b/xen/arch/arm/platforms/xgene-storm.c
@@ -51,7 +51,7 @@ static void __init xgene_check_pirq_eoi(void)
         panic("%s: Can not find interrupt controller node\n", __func__);
 
     res = dt_device_get_address(node, 0, &dbase, NULL);
-    if ( !dbase )
+    if ( res )
         panic("%s: Cannot find a valid address for the distributor\n", __func__);
 
     /*
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314687.532934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJE-0002OO-VA; Wed, 27 Apr 2022 09:50:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314687.532934; Wed, 27 Apr 2022 09:50:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJE-0002Nw-OE; Wed, 27 Apr 2022 09:50:08 +0000
Received: by outflank-mailman (input) for mailman id 314687;
 Wed, 27 Apr 2022 09:50:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJC-00085x-Og
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:06 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 6aa984d6-c60f-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:50:06 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 754AF1480;
 Wed, 27 Apr 2022 02:50:05 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC4BC3F7D8;
 Wed, 27 Apr 2022 02:50:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6aa984d6-c60f-11ec-a405-831a346695d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH 7/8] platforms/omap: Remove unused-but-set variable
Date: Wed, 27 Apr 2022 11:49:40 +0200
Message-Id: <20220427094941.291554-8-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Function omap5_init_time defines and sets a variable den but does not
make use of it. Remove this variable.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/platforms/omap5.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/arm/platforms/omap5.c b/xen/arch/arm/platforms/omap5.c
index aee24e4d28..5cf424a23e 100644
--- a/xen/arch/arm/platforms/omap5.c
+++ b/xen/arch/arm/platforms/omap5.c
@@ -48,7 +48,7 @@ static int omap5_init_time(void)
     void __iomem *ckgen_prm_base;
     void __iomem *rt_ct_base;
     unsigned int sys_clksel;
-    unsigned int num, den, frac1, frac2;
+    unsigned int num, frac1, frac2;
 
     ckgen_prm_base = ioremap_nocache(OMAP5_CKGEN_PRM_BASE, 0x20);
     if ( !ckgen_prm_base )
@@ -78,7 +78,6 @@ static int omap5_init_time(void)
     }
 
     frac2 = readl(rt_ct_base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET);
-    den = frac2 & ~NUMERATOR_DENUMERATOR_MASK;
     if ( num_den[sys_clksel][1] != num )
     {
         frac2 &= NUMERATOR_DENUMERATOR_MASK;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:50:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:50:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314690.532944 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJG-0002kH-Hg; Wed, 27 Apr 2022 09:50:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314690.532944; Wed, 27 Apr 2022 09:50:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeJG-0002jB-9W; Wed, 27 Apr 2022 09:50:10 +0000
Received: by outflank-mailman (input) for mailman id 314690;
 Wed, 27 Apr 2022 09:50:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njeJE-00085x-P7
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:08 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 6bd0b73f-c60f-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:50:08 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6924C14BF;
 Wed, 27 Apr 2022 02:50:07 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D14C63F774;
 Wed, 27 Apr 2022 02:50:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bd0b73f-c60f-11ec-a405-831a346695d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH 8/8] drivers/exynos4210: Remove unused-but-set variable
Date: Wed, 27 Apr 2022 11:49:41 +0200
Message-Id: <20220427094941.291554-9-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Function exynos4210_uart_init_preirq defines and sets a variable
divisor but does not make use of it. Remove the definition and comment
out the assignment as this function already has some TODOs.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Commenting out a code is a bad practise as well as using TODOs.
However the only alternative would be to get rid of divisor variable
and TODO comments. I'm open for solutions.
---
 xen/drivers/char/exynos4210-uart.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos4210-uart.c
index fa7dbc0391..43aaf02e18 100644
--- a/xen/drivers/char/exynos4210-uart.c
+++ b/xen/drivers/char/exynos4210-uart.c
@@ -101,7 +101,6 @@ static void exynos4210_uart_interrupt(int irq, void *data, struct cpu_user_regs
 static void __init exynos4210_uart_init_preirq(struct serial_port *port)
 {
     struct exynos4210_uart *uart = port->uart;
-    unsigned int divisor;
     uint32_t ulcon;
 
     /* reset, TX/RX disables */
@@ -113,9 +112,12 @@ static void __init exynos4210_uart_init_preirq(struct serial_port *port)
     /* Line control and baud-rate generator. */
     if ( uart->baud != BAUD_AUTO )
     {
-        /* Baud rate specified: program it into the divisor latch. */
-        divisor = ((uart->clock_hz) / (uart->baud)) - 1;
-        /* FIXME: will use a hacked divisor, assuming the src clock and bauds */
+        /*
+         * TODO: should be updated
+         * Baud rate specified: program it into the divisor latch.
+         * divisor = ((uart->clock_hz) / (uart->baud)) - 1;
+         * FIXME: will use a hacked divisor, assuming the src clock and bauds.
+         */
         exynos4210_write(uart, UFRACVAL, 53);
         exynos4210_write(uart, UBRDIV, 4);
     }
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:53:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:53:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314758.532956 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeMB-0005nd-8g; Wed, 27 Apr 2022 09:53:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314758.532956; Wed, 27 Apr 2022 09:53:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeMB-0005nW-5A; Wed, 27 Apr 2022 09:53:11 +0000
Received: by outflank-mailman (input) for mailman id 314758;
 Wed, 27 Apr 2022 09:53:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njeMA-0005nM-Ha
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:53:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njeM9-0002WG-Vx; Wed, 27 Apr 2022 09:53:09 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njeM9-0001CS-PR; Wed, 27 Apr 2022 09:53:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=4AFEn0CHrznKpx8Ja/X3cAyPwuX2ZoOxVjBpcS7EBFE=; b=Z3ZIOv+q07dwvxhd2PhGFjpKUf
	rfs0hSqfrf1oyPZA6fnF8p5AXsHioZDTagW+LyKgsHE0bsHDosm8YKdJgZJXZljlN0NVK6TEQD9uv
	U+4eYS17PLTrUmk/tgQSX2TmeQNRwREcOv487q5qEjDScwDDPmJgLv4B9eT20dPdeSe4=;
Message-ID: <a4746106-771d-aec7-20c0-82650ee62f61@xen.org>
Date: Wed, 27 Apr 2022 10:53:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v3 4/6] xen/arm: introduce CDF_staticmem
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, henry.wang@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
 <20220427092743.925563-5-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427092743.925563-5-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 27/04/2022 10:27, Penny Zheng wrote:
> In order to have an easy and quick way to find out whether this domain memory
> is statically configured, this commit introduces a new flag CDF_staticmem and a
> new helper is_domain_using_staticmem() to tell.
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

The reviewed-by tags should be after signed-off-by tags.

Cheers,

> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
> v3 changes:
> - change name from "is_domain_static()" to "is_domain_using_staticmem"
> ---
> v2 changes:
> - change name from "is_domain_on_static_allocation" to "is_domain_static()"
> ---
>   xen/arch/arm/domain_build.c       | 5 ++++-
>   xen/arch/arm/include/asm/domain.h | 2 ++
>   xen/include/xen/domain.h          | 2 ++
>   3 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 1472ca4972..6830a282a0 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3190,9 +3190,12 @@ void __init create_domUs(void)
>           if ( !dt_device_is_compatible(node, "xen,domain") )
>               continue;
>   
> +        if ( dt_find_property(node, "xen,static-mem", NULL) )
> +            flags |= CDF_staticmem;
> +
>           if ( dt_property_read_bool(node, "direct-map") )
>           {
> -            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) )
> +            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !(flags & CDF_staticmem) )
>                   panic("direct-map is not valid for domain %s without static allocation.\n",
>                         dt_node_name(node));
>   
> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index fe7a029ebf..110c672589 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -31,6 +31,8 @@ enum domain_type {
>   
>   #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap)
>   
> +#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem)
> +
>   /*
>    * Is the domain using the host memory layout?
>    *
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 1c3c88a14d..35dc7143a4 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -34,6 +34,8 @@ void arch_get_domain_info(const struct domain *d,
>   #ifdef CONFIG_ARM
>   /* Should domain memory be directly mapped? */
>   #define CDF_directmap            (1U << 1)
> +/* Is domain memory on static allocation? */
> +#define CDF_staticmem            (1U << 2)
>   #endif
>   
>   /*

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:57:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:57:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314764.532967 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeQA-0006TS-PY; Wed, 27 Apr 2022 09:57:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314764.532967; Wed, 27 Apr 2022 09:57:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeQA-0006TL-MN; Wed, 27 Apr 2022 09:57:18 +0000
Received: by outflank-mailman (input) for mailman id 314764;
 Wed, 27 Apr 2022 09:57:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njeQ9-0006TF-6n
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:57:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b16edec-c610-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:57:16 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-rJFEUM0rOfKxV6NZ5tJv8Q-1; Wed, 27 Apr 2022 11:57:13 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB6911.eurprd04.prod.outlook.com (2603:10a6:803:12e::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 09:57:12 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 09:57:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b16edec-c610-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651053435;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hFBQHEQ6JEOBTHZKPMnzsFZL/okDtiHCSU8+PHJ7Pio=;
	b=eU5/2rjzMVwXm3/2RIDUWdhnX5+HPiP0GF8NYajTqNXfYiQGZx48o0sEC5GjsVOFTfPoUG
	/714ydS8Cb3xwdnufO5tFaSD53DY5229CXgcjOwcd6fJQ9wvtaz3tR+jpi0u3KincnCOlV
	BRiJ1IOfDGosMWyTf31f+V69FPB/GCI=
X-MC-Unique: rJFEUM0rOfKxV6NZ5tJv8Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bWUeKKj8/uc/ea08i8BBUo5wCN2NqDzjzUVIgsTiMG58i5T9p2UwTuXtIrs4929+UpBHXt0aAyev6BCMNRw4vrSkrSavpz/5TdIOphHLwqfjihq9Gur+6MyOS4kdW4/pDh2fH12X0tEW2B1BRP9LJkYeALeiWdeXdoxhLUnlfuwGTpz5qr1JasNlmT6KI6KVghTsZUn3HTChX/iH6yh5V4DFCOK33E4rb6RqRY3wBnQQR1Id6HF7ao+tCxuPCAkr0gh758k6WPnSNtRWxWYqrCd6gNTl3vq+TMbI05BTsjyfUrMc5XWt4OXDE5F/w2fm456hDrWSN45YDBFHBg+ALw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hFBQHEQ6JEOBTHZKPMnzsFZL/okDtiHCSU8+PHJ7Pio=;
 b=hXX/U/N0/ETJxEX4KetsR/gWDmB/khrrp36qpC/TIy1C/fqbJpBAksybI0esKi8FuQyTx+s4uKQ+gLi1vI6QTuVCnh+L3Asx5To1VZczJkq5j+OujeQ3MajF0544o9QnFaIpXgbKEcLtIN+Ta4d70DnobAKxY/DwPrqWwUxK2GAztodkJFsEPKpD2wVZqOzTWiiBz9mp9Kh+kmaCnTP62H//T6UZE0r4RyBMqGS5VKNwNZMr9EOfcS4XCDEw9PzDE6iDGnWOQ+QGKfcMGd74daAFUxQOLCYGtSLTAIUTQRJmz9a+4KiqgLiitxlz6QvJ0R/5lGVX6180EjUmHm0ugg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <36488778-02f9-1453-aac0-37e6729d9f22@suse.com>
Date: Wed, 27 Apr 2022 11:57:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 2/8] efi/boot.c: Remove unused-but-set variable
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-3-michal.orzel@arm.com>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427094941.291554-3-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0010.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a7d72a7-d475-4e91-98fd-08da28344d4e
X-MS-TrafficTypeDiagnostic: VI1PR04MB6911:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB69117420BCC8D9B4BC28BC71B3FA9@VI1PR04MB6911.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8fh52TJ2ZSYCLDfpO9rBFPJltqjzAgd4jo/GsZ8lIsvxecvXtBbeZg6n3zadVwzaAZBKTIWMNrTcN76j6xX+0BY1+CAcUaPnyGuyArb+0KalmvyKWWSGBJ6B6nU7vLJZBwiybCgnkQevIwcvQ3r0GlDaOpkf+zyVL/pfqmpeQQzKFM+bywI8G7QUjuBFbm/KLYFbZQhWXoQhq0wDLSrRYIuI7u/gfbYeHX+CpXpeRfVEsFwmkBo9MhKNGp0MqzFIb05gTiYFzljvTT8JbJ4IFZmrA6cRzsyrGrx1x+LDsu/NADDYeI6RIn51MvLWa8DE+BNZIRU63G76tXyxyWDVXXU+riAmz0duhdQXwLYtOXhJu/hmS36W+PgGKB9U+mTh3Qr468l/NMdyHkLpuIsPShl+SbC3vJgVyZGGqlLm1JcCL99piGoBvI/3+V46iG7duvjc7rAD5/RMkPvDLc3AVJ+sSI/hFKbwWEPxH6jp81fEIh1t5HEDbEGwDZgH1iF0APfzmxb3piMsQPukiglclcMTxTRp6/zVDANex373TSaqcP0/SsIf6xrHEKb2yGIhTm3pvAQeZMAYhXR9AiBinRxZMH9g0W5RUnixxWON3QgnFeBL1za35UW2/LzhqJOmK0n9LfA8hm2CGgtl+/E/V3kwFaFNSCOqGysaeD//NbbooT5Kzpf2yFJjyurqD3fCYfdtT5NzPHnL4qwm7lYx/SkupQyz7OHJ5Fu+WJlL3Gs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(5660300002)(31686004)(2906002)(558084003)(508600001)(4326008)(6486002)(66476007)(53546011)(2616005)(186003)(38100700002)(8936002)(6506007)(86362001)(26005)(66946007)(6916009)(36756003)(66556008)(316002)(31696002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WkdJOGdDNGFySG8yWGsvenhLYnJXUzA4QUV6TGxkbHVHcW9Za3hhTXpaMFBo?=
 =?utf-8?B?MFZ0T0k2clpadi9RRGFLTXZhUWFrczFkSXVVeFFOS0VaWmJZc2JHUUhPaDEr?=
 =?utf-8?B?VjJUWlhXd2Q5dEV5TmdTN1ViLzJQS1NNTGNEdTFBRzR1R0tyY3dCVHBNMXFH?=
 =?utf-8?B?QlhhQnRGNXVLYXFLeXBWRnRqMVZpWEhaYk9tMUpzWXJkRnVUNGRaUlZvUmYr?=
 =?utf-8?B?UllwWWVGbG13OG9vZlR2MEhNUnl2WllSS1E0T1FRWWtxRnByZGdYUzlGcE1k?=
 =?utf-8?B?b3FVdXJOSEkyaFR5SnkzVzlERnJ6cGVVSlRRcmYzUlFiVmJsUS9FbjN3Z0Fv?=
 =?utf-8?B?L3RzS0lQTEZqSDg2aCtUTklsRTNnZE5xUjBRSkFHbGRmcnZRbHBIOHI3WWRD?=
 =?utf-8?B?bWp6VHRkWGZSTE5Jb3oxT3prUUJ6MEwrOE9neHhNalBGNzZhdDZJWnFUcUQ5?=
 =?utf-8?B?bkFTRlBmcnJ3SUpWSWovOXRHQnhRK1NORHBRZlRxSjkycTl3YkhYQk0wR2g1?=
 =?utf-8?B?M0hDMC84V2dRYjJpeWt2NXZ3SitEWlg3YmlzM1ZZT0ZHUzVxSEJhRUhpSmto?=
 =?utf-8?B?SkdMVjRGbXpKY3NwMHVRTklmZjgwMC9OUkpBeXIranpFMUUyWDl4M0FNdjI3?=
 =?utf-8?B?bmJTV0JicDh3Sk8wTFhrZ0VxdTc5UU1wVUlJVkRzSllLU3NJaE9ZQ0JZb2s5?=
 =?utf-8?B?R1FLbjg3TWh3cmhXMjAzNjlzUUN5cUhySkFrL3l5NmVqUHcrdWQ4TTgzbkxo?=
 =?utf-8?B?aUdLdnJCMEZ4N25WUlRlamJxMllEMWs1alpqbzFKUnpxYWZXTmROY1BUU1lt?=
 =?utf-8?B?ek8zaHRxcUkrdTFhWHVGdVJ4azBHc0lrbE5HN2NZRzM1enY1RUR4TDUydk45?=
 =?utf-8?B?OFVhZkl3d1o3ZjBsdE5ra2kzeFdCNE11SDc2VkYrWTI3cHhzT2dudjBvTFBv?=
 =?utf-8?B?ZEk1d2NMYVdEYWFEVlFSY3I1RW5pRXNTQWN5aGcxL2dNYjFJaXJGMVNnYmNE?=
 =?utf-8?B?VzJqbWpaSndrUng5QXo2cDhQcEpvZVNMZzc5Z0tDcDVmMkUrRm1CYm1HSW5H?=
 =?utf-8?B?cURSMWVGT1NJVk5UeG1sWVBtMm1ZSHQwaFBsK2I4bGovK1lEdjU5UWJaak5v?=
 =?utf-8?B?aHdUQ1R2TkxhaXhPcW8waERmWHdxQkRQK2N5dUsyY254dUNJK0FVNXB4Mk1W?=
 =?utf-8?B?anU1M2ttWnFudmZHRE1QY1EzaEswSnA0Rms4Q2tRSnhjU25iOXBiZnlvS3lM?=
 =?utf-8?B?SzlOM2QvTWlxTG1wWC9CR1lGN2k4ZjB2WjlUcnVvZm9hWTNMd1lBcVBtUVN4?=
 =?utf-8?B?UmZWRG5rR3lkUVp3MUJ2dnordnNMN1NHU0JtclRROWN6N2MrYXpzUjIvUHdn?=
 =?utf-8?B?WHFtYTZWQTh5WkFzaWNkYyticEZsbk5zb1RtdFlxU3ZqaHhWeFhVbVlDU3hw?=
 =?utf-8?B?blptTUE3aHdXNnVnVk15KzNaeHR5VXlNZXNaRFBQN1JDZlkvNzROTWVyb0pR?=
 =?utf-8?B?Zzk5QWJIVnEwc3A0WnNHRVQ2MXNKZllhcnMvajUzYjVBMFZpbDJaUVNrR2dt?=
 =?utf-8?B?OS9CTnFwSDc2Zms1aHZ1WWtCdWdhRkxEcmFTZ0JaZkw1dFFpSFVWOTQ0dFpz?=
 =?utf-8?B?SERPZzJmcHdOMGhjQ2FaeGZPTmRVanFWN1l4b1NHVVkxMEtsMHozTnZhNCtL?=
 =?utf-8?B?eTVRTkNGUHpVMDRCU1J5M0pCbmJrZlFuMGpudDRxVWs3MHVRU2FoaEp6OEcr?=
 =?utf-8?B?V0oxZFFJYlI0TzJvcmw3Ky9pN012TnFMVkw3emtjWjcrTytVVld1WFA5bEg1?=
 =?utf-8?B?d0gxWk0wTG94M01JaTRMYTIvRmJFRytVL3F6aGFlNWpvTzlYcW5Db0oweUhJ?=
 =?utf-8?B?bDlUOWd4RVJkb2F5Um9CSy8yNmtRRkpoQjk5WHh2TVhWOTk1dGw5UjV6NENF?=
 =?utf-8?B?KytMR3NiL2ZTZU1IWEZtSHp4Y2ppNHpPMExVNzlkTzVmRVNxUFVTMG0wdk1s?=
 =?utf-8?B?ZEh0TmJuWVoyMWJZVnNOczZqcWF1WU5aOGR4T2R4R3BKMldQZnhnZWZXSWIz?=
 =?utf-8?B?ZCtLaVRMYU91OGV3UndIUUVRRElCbGJJZ1UwajhNYTFkN0swODNGbFE5TU51?=
 =?utf-8?B?QS8ya0JmZFlmZkJMMkhKL0hqd3dxUXhPdklBeGN4Wi9Ydm03MktSeXBCbmlk?=
 =?utf-8?B?WDFIRWJvcitnaXRsYjNNcGM0Z0M1NWxNYlk2eGpOVU1FN2hveDZVbHEvTEVN?=
 =?utf-8?B?QUhGYVJWSHpHSkhaK0hvSGJpamhBUXVmUDZnd0M5MnV4L2ozN1hsRHhqQ2x1?=
 =?utf-8?B?MlI3WWF1aXBuMmZPWExPcCtPak51eXV3Wm5FUDNmZTdTb0hleGswZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a7d72a7-d475-4e91-98fd-08da28344d4e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:57:12.8171
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: miruTujMx9FpUa9bqzJ7ThtfJxGjulFBCSsMssdmIO2ie8NeLowtbaoQB+IsDdAs5KLOC0zLwAbDdA4fDcjoNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6911

On 27.04.2022 11:49, Michal Orzel wrote:
> Function efi_start defines and sets a variable size but does not
> make use of it. Remove this variable.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 09:59:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 09:59:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314770.532978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeSV-00073y-6J; Wed, 27 Apr 2022 09:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314770.532978; Wed, 27 Apr 2022 09:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeSV-00073r-3I; Wed, 27 Apr 2022 09:59:43 +0000
Received: by outflank-mailman (input) for mailman id 314770;
 Wed, 27 Apr 2022 09:59:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njeST-00073j-Rc
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:59:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c158519b-c610-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 11:59:41 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-ajdErQyMP6a36yr8FDNNMQ-1; Wed, 27 Apr 2022 11:59:36 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8520.eurprd04.prod.outlook.com (2603:10a6:10:2d3::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 09:59:34 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 09:59:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c158519b-c610-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651053580;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5td2FdYA/G1v27qOZaOflsBMkVwmcDVOxrFdmF7XrQg=;
	b=hj7ZDQE+koFzXiwYKIXNseS6pCGFa6QZxHkaG+iWweGuBjETZaWicwq4DQ6q0YF3oKxD6y
	xd78/WurRiT72ST7gd2Le7jSZLFOGM1X3tIT7C/H4HsRKK2vGkgQ4GHi397hv5pWDhzmSQ
	DCrRL9TR4baAsbKKBGhG5+iKGg9q3Xk=
X-MC-Unique: ajdErQyMP6a36yr8FDNNMQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DBEyMechVssUhMLieaCdDJkPRK29DDeL13vUKkuxFfojvat3do2g1+tps12Y7CQNBRBQ8oZfkDyCPR1Zqkt1MKhUUXpoxGg1sMt9QiUTVxAODyayuaDWD2JUYf/VmY3tAc9Xcg/KTDlMDerxNQVq8G9p0e5Gqje4g/XH/p7zjDlW5lvJN3YWcuvz4vOcdYMRsiL2igdTzSSxBmpmsjih7EMLImVA4fEE2ynL3tSvGZzFVIeeryO2ifuROylrnYq0giXbToDg/rkVfaxTLUkmyWVWzSd8nxKmbAmdMVbL3RudrEmW9XVzZuB92oqP6Ys2oFXvOWTaWutOFjZ73P4CWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5td2FdYA/G1v27qOZaOflsBMkVwmcDVOxrFdmF7XrQg=;
 b=n0Eeb4JZd2gyMPzBSHC/YtOlaEBFlzkwDsgsOwkOPFwMxJjFSKObsL/nfgzX6m+1yXFcGsFcFTdaM3pN0WrXR70HO5JZpbsPzUzhhYHpqRL1NBdoM4DTgJsHNWKYCucUYwH9U1pnx1XsnVf8sCcnlNf2WBeoz2JMArzSmNAzMYRRO5nZ6ytyWsPbdyZ94fRAbiztuogMWIDdRBwlt/wBVierMGAxiYfpNRejBqZ4HKwU+t5BTtICAFBYad6/4Ink98Swu80QjCdOivgd3HNxsnzk8v9AhO192MQQfvMCyVdk/DGjxfZ/gZo8SNvYKNMX0Pjfq0LhdDZDjaHwyMKlbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
Date: Wed, 27 Apr 2022 11:59:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-4-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427094941.291554-4-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0007.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 68edcd34-7911-421b-3d80-08da2834a191
X-MS-TrafficTypeDiagnostic: DU2PR04MB8520:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB852038D35AFD123205808A57B3FA9@DU2PR04MB8520.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+4RCAEkGSPppwCA1ZtCnaRamEEP0oOyahsbVn4L5WHdVkLfBDoqBaJKcta2UvIWy4OOlEnzKwdXfpvFdaFSiMSvlGAAwNRcvaVWn5/OSk8O614YDNXr40XI/uSp+IFXtimXtuRCFcmtB+7lx+UAq3btGKaPyCVc/+HtLIfC8mIVT1EBAmtVOdoW1RLWJ4xor0V7mz/UUNeuUVysUjm6I6EVtW1wDALkW49zr8PlFjLkWgKr3cPJBDjOnkDS72mTaMhA/csYvWotmfXxoe8ZvpV3notQQuOWABdx+9pUM5I6hVEubR3RlduOdWae5gUIAwwyDrzNBjzPTDReRWV7tOn1Aeq4fM5/UsD++hYUQ2+VXlT6RDyykUMpHKyrNlxZ2cSrTaqc0znz2dFWCHL3YUuasTj7bIH3A1gA3WEkH5V646y1UOgMllH6vvG4MPZ6ebeITWQTrM3AtoDuYEuqJxSk7kbQjpRUUjfYrRzOQ3rlOV5XqlrUGQNeoxmGYg6Yu2OLSCWmAeiFEd+LE2ybA1occNowRbYBcplXzCtI8vFxgPvUETNGwAOXciQk4ZES9bSDuNg+70Y4jNbGimvDzJtZk+Qr0adYOWOIHR7xjHWBrjtGmTw6/SjRpHBjMOfulnhNySYktd1y5mmYsvxf/O4VF8rYn96Hjk37ENkkUo8EUp7vte69zvP9jtfz6b51vB0OoO84pQLsxwxc28gTVchXjcg3W6Tx3ztZafphFkLUdqY++Kt0z0fczU4j8GQNt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(508600001)(2616005)(31696002)(86362001)(6512007)(26005)(53546011)(6506007)(38100700002)(6666004)(186003)(2906002)(4744005)(66946007)(66556008)(66476007)(316002)(36756003)(5660300002)(8936002)(54906003)(31686004)(4326008)(8676002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WHAvOHdhYkRRRFREQjJrZGNCdWR2N1EwcUl1WVRCRW5NMHBvMmZIWWFyQ3dh?=
 =?utf-8?B?cUdCSWdoUm1oZ3NkK3VVeXhNUFdtYXdrbmk4N01YTWJYVDVSUm93MWdPbWxh?=
 =?utf-8?B?b0M5d3FGRlZWeG8wOEpNNHhEUk5BbGs3MnFCUmVnQVBXUFhaS0lrcnJGMzNH?=
 =?utf-8?B?Ym9Zb1IxdzVLVWZEb3JkYnZmcVRRVFhkRmtIWEZKcU53Y2JIeGxrL1dDT3d6?=
 =?utf-8?B?Y1JnQW5GRklYUmFvcW5zeHkxOCtoQ29Qbk9YVUxHaHZuWmhLV090dUVzR2Ra?=
 =?utf-8?B?d1NJbDB4ZU5xanB6SUkvSHhleXFkbm1HTE1MTzl0WFN1WnZHRXNvOWNlT0FD?=
 =?utf-8?B?UmVxNEt0cG5YTTNaZ1UzeXJWSGI2UDFLc1pyb0dudnlTVHNBNmJoZVhjWVFZ?=
 =?utf-8?B?aFJrcnU5OTJieUcybW9Mc3liTURWZ2s0eVFZVGVOMnJ2Zno4UFhRQmttUGFU?=
 =?utf-8?B?UmY5by94d1NBeEJtYlpYeFRQUUdYOCtiS0p6eTRWc21ranBKMTBRMzdManc0?=
 =?utf-8?B?dXJ2M2VHTUEyUGRTamlzVFVZTVNkb0tjZ1VXNzU3MU1ZQkloSVBPVWRWVCth?=
 =?utf-8?B?UTY2UFZ3bTFibk1BRnVtZ3U2aHlYMFZ1WHdlYlRoS1V2TDlDRUxCSkJqZlRa?=
 =?utf-8?B?UFNRYTFLclo3MlJSdlFpdDJuKysrNWRqQlVCS3BKeW1ocFFPamZ1Mk5yYktm?=
 =?utf-8?B?UHFtTkZma0xyN0owV25QQ1BQVHR5dC9EMm1oUlp6bGhWNmt0WUtLTjhpRHpQ?=
 =?utf-8?B?K21oVWowSnIwT1BzVVp2SjNTK2l1ZDRPeEFWSndWNm5HSHRxbFlHQWFrUDNh?=
 =?utf-8?B?SHlPUDk2UTRPY1NEbG9JMkV0QVhTckFxeFRzQ3kvR2N5UDNSWERWSUJUdmMz?=
 =?utf-8?B?cWpWYkdvUzRqeGt5b2lzdjhuQ0lxZWtIdHAyTnc0TU9FVm52aE9GenJvZHgz?=
 =?utf-8?B?OFNIQlFTT0tOWUxvSzh5NTlqMEllaFFHNlo2b3NZNjdyWWxGalg0aUphZ25P?=
 =?utf-8?B?cWJaSi9aZjI2UXJ4VHV6bXRPNG1qWU1CQnpHc3lPWU1WU2V4TGwwQjFtNkRt?=
 =?utf-8?B?cUlnSG9FRVZHTHJqRStnWFdkbVpYZEJCeXdsdkZJTDNEZWxWZ1Q3Y1B3Y1NE?=
 =?utf-8?B?MjVxMHIrdUluYzJ2YTNxd2c0SDB4NDVGdXpGcjJFU3NvOHMwYU9NQ2o1M3JI?=
 =?utf-8?B?UUxNdU96QVZGT0NnZ0EzbXNUWEdqL09MZUIwbXdsSjhKTkFJZmZXTmw5aXZs?=
 =?utf-8?B?S1BDS09TUkR4NXVER2NDVkhPdm1YWWRkV3FCSWdHR1dTa2lUVnUwZTZqSUVs?=
 =?utf-8?B?NFczSHVkL3M3ZWx3Z0k2Y2h1SmdRdUIwbG5wckVNR3BPL1JMeWhxWnhxNFJs?=
 =?utf-8?B?QUNrbFV4UHdRVE0zL3RuMFRMUEEvMW1pQXlTKzJKc2RQMU9TTHhSV0tRUFFE?=
 =?utf-8?B?NUlNQmdlOFdyc1NJcUU5eFlKTGdweDNWbmsxeXBVeVNwWFY2UTNlNXZGRHU1?=
 =?utf-8?B?WjM1NDF1NjFVckd4bE5FNW1jcUhrM3pxNE4zSlRMUFF1TTRTYUJWdFJ1NUY2?=
 =?utf-8?B?a3hRbHI1M29mcnZxbFhTUldsdjNVK2srUjRhYkw4UUUxTU1KRGRDL2xvRkxu?=
 =?utf-8?B?YjNPc05TWnpIeFozOVRqa2hHK0RjdnpWUGhHb055S20zVGhyU2g2eThhV1hm?=
 =?utf-8?B?c09nU0hSMnV4cm50MHZzVkU5eHVhbm9XYytrS1dRbVZuc2psNVpqTEFyQ2Na?=
 =?utf-8?B?UFlISXh3VUJmZ2dsdmRjY1hPSTgyOTJVbzBvR2tLTWp2NHNPM1owU2NFUDg5?=
 =?utf-8?B?dGVZTUtXVHZSZHFmeFF0VW9LWS9lM2VnN084WjNYV2xwd0NPekZabTA4NTBx?=
 =?utf-8?B?bEVydnBCZ3pmZjlIbkM1WjdiaUo1enkzQ0hOSjROVkVkd1A5RXFHMzRPdHMy?=
 =?utf-8?B?VGUwazg4NG5veThwVW02QUJUR0o1K0dIRElnV3pWTmQ1WUpMZmdsUVRjZUZi?=
 =?utf-8?B?VzlSWDNiRjE0RlhHRnB4ME5URjlDczNjclVsYnVNOWZPcGt3UkFQWGpBdFVX?=
 =?utf-8?B?T1ZldnEyTU9kQUVOSUtUcjV4SWZRdzBEVTExc2JUUUsrRnZmWVRYcmM0WEFQ?=
 =?utf-8?B?dFZDQiszWkxqQnlzWitpcEpxTjdQTmNvVEdWVGczVjNMYmdtVHFwZFZXN1l0?=
 =?utf-8?B?dHowc0hCSHZISDArQnlQZzVVTGJBSXMrMFpKS0RjekVMRWc3bU5tUlRRQ0hJ?=
 =?utf-8?B?S1NzV1ppdE55MnZyeThnb3JKdlUrYnpEVThTQW5LdGZuVktzcnJOaGJaOUNz?=
 =?utf-8?B?NlBrRks1OG9hc1JPaG5pQXUzVTBRNG9vRnoyWk54d3Roak1QNGI5QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68edcd34-7911-421b-3d80-08da2834a191
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 09:59:34.1669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W4CiRuDHLSQMbxd/otfNf8njuUQ6ZPycBXMM3DQZj5inaBmbgcI7cYRR5ORlC1V2fs7I4ogxzqmkPDJ6XbriLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8520

On 27.04.2022 11:49, Michal Orzel wrote:
> Function unmap_common_complete defines and sets a variable ld that is
> later on passed to a macro gnttab_host_mapping_get_page_type. On arm
> this macro does not make use of any arguments causing a compiler to
> warn about unused-but-set variable (when -Wunused-but-set-variable is
> enabled). Fix this by removing ld and directly passing current->domain
> to gnttab_host_mapping_get_page_type.

I think we want to retain the ld / rd notation. Therefore I think it's
rather the Arm macro which wants adjusting to not leave this argument
unused.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:02:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:02:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314776.532988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeUr-00005E-KI; Wed, 27 Apr 2022 10:02:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314776.532988; Wed, 27 Apr 2022 10:02:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeUr-000054-HS; Wed, 27 Apr 2022 10:02:09 +0000
Received: by outflank-mailman (input) for mailman id 314776;
 Wed, 27 Apr 2022 10:02:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njeUp-00004s-Tx; Wed, 27 Apr 2022 10:02:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njeUp-0002nN-Qo; Wed, 27 Apr 2022 10:02:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njeUp-0003Yu-EW; Wed, 27 Apr 2022 10:02:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njeUp-0007qt-E2; Wed, 27 Apr 2022 10:02:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ULmNZrf8DriNS6yiJZwmKu4cDxT/kuzGIN9x8eI7EXw=; b=L4xxv6XEtVAoPcSf917U3jSUPT
	wbWn7nue689YAHn8UzIC7lzQKtTHPLYus7pNAL3uFmiSapD/6HeqSPZxjF65xAxnAhlWKqkQEyhf1
	n6YRtxbUOCuoH2eqz7gIW8X3Jk99pLhR5Ijldt1ngO2/0Om2uIRfwg3Zpx5K3TQCnCfw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169776-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169776: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 10:02:07 +0000

flight 169776 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169776/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   57 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  659 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   31 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:06:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:06:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314786.533011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeYo-00015f-K6; Wed, 27 Apr 2022 10:06:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314786.533011; Wed, 27 Apr 2022 10:06:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeYo-00015W-Gm; Wed, 27 Apr 2022 10:06:14 +0000
Received: by outflank-mailman (input) for mailman id 314786;
 Wed, 27 Apr 2022 10:06:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1GEo=VF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njeYn-0000oY-FA
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:06:13 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aae641b9-c611-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 12:06:12 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 467D51F388;
 Wed, 27 Apr 2022 10:06:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F97213A39;
 Wed, 27 Apr 2022 10:06:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YyhVBpQVaWL6dAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 27 Apr 2022 10:06:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aae641b9-c611-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651053972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uFHwLzsiRN5ko7Hc3eYRpiPMTBTkxADLB1wsv4NSG0g=;
	b=i0xmzbxKeG/MWOOs41U5H5GkpJy6T/B1LzSksD/GKyVVpQNZCG982XRo1D+6Cn3NogxSb3
	7zWX6bXu9ALUYXubYdFSRX8q/tf+VmIWxdDSUWnps5Ag2KOt+Wq9ZkATtKPn8rc7PDzNcr
	AluKGSaeu/JMP/PZtet2KRHpG/jmwx4=
Message-ID: <aa77a8a6-6ccc-89ec-ef27-9d685dc07ae9@suse.com>
Date: Wed, 27 Apr 2022 12:06:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 5/8] xen/sched: Remove unused-but-set variable
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-6-michal.orzel@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220427094941.291554-6-michal.orzel@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------3YXXpsNUc9AR5vRJvXOAYO0k"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------3YXXpsNUc9AR5vRJvXOAYO0k
Content-Type: multipart/mixed; boundary="------------78E0dhMwQ8bgZPbK5XQB1l9R";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>
Message-ID: <aa77a8a6-6ccc-89ec-ef27-9d685dc07ae9@suse.com>
Subject: Re: [PATCH 5/8] xen/sched: Remove unused-but-set variable
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-6-michal.orzel@arm.com>
In-Reply-To: <20220427094941.291554-6-michal.orzel@arm.com>

--------------78E0dhMwQ8bgZPbK5XQB1l9R
Content-Type: multipart/mixed; boundary="------------7b0Ah062ikJnBN7VpSs0QTmL"

--------------7b0Ah062ikJnBN7VpSs0QTmL
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjcuMDQuMjIgMTE6NDksIE1pY2hhbCBPcnplbCB3cm90ZToNCj4gRnVuY3Rpb24gc2No
ZWR1bGVfY3B1X2FkZCBkZWZpbmVzIGFuZCBzZXRzIGEgdmFyaWFibGUgb2xkX3VuaXQgYnV0
DQo+IGRvZXMgbm90IG1ha2UgdXNlIG9mIGl0LiBSZW1vdmUgdGhpcyB2YXJpYWJsZS4NCj4g
DQo+IFNpZ25lZC1vZmYtYnk6IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFybS5jb20+
DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0K
SnVlcmdlbg0K
--------------7b0Ah062ikJnBN7VpSs0QTmL
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------7b0Ah062ikJnBN7VpSs0QTmL--

--------------78E0dhMwQ8bgZPbK5XQB1l9R--

--------------3YXXpsNUc9AR5vRJvXOAYO0k
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJpFZMFAwAAAAAACgkQsN6d1ii/Ey/L
XAf+OBQKVPRNVoyM1dlkKEW9eholiX+e4Esh55i9a93y8cIC0Sb1PahPqy6+GTgB1izE3Nure+Td
O2YeiFpr0lJwqRQg0l5dluarx3ZTQJ48MLpxZl3QEQEfrTkDIcETNkWkk5PYHR2vQtwU12+X8Gbn
KXCErkWKnoqniLjItEldafZt43Jo2pTNDWDpQOQVYhFtIASJuPUHftJUKxztbDj847U8K578HzZI
8vOsfVRBuvrfajXmbxNCrmtyfsCFB00QqMP+tSbaffAaxAx9tBxqODQch1VjKO0GCc6rn4HldJds
0P39bHMiKKZuf78JsxMOwu3gVutl+fgD5ZR4Oav/gw==
=ZK3H
-----END PGP SIGNATURE-----

--------------3YXXpsNUc9AR5vRJvXOAYO0k--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:06:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:06:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314785.532999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeYn-0000ps-Al; Wed, 27 Apr 2022 10:06:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314785.532999; Wed, 27 Apr 2022 10:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeYn-0000pl-7f; Wed, 27 Apr 2022 10:06:13 +0000
Received: by outflank-mailman (input) for mailman id 314785;
 Wed, 27 Apr 2022 10:06:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8dk3=VF=citrix.com=prvs=109ad7ccf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njeYl-0000oY-EE
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:06:11 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a824c0eb-c611-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 12:06:09 +0200 (CEST)
Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 06:05:58 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM5PR03MB2618.namprd03.prod.outlook.com (2603:10b6:3:48::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 10:05:55 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:05:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a824c0eb-c611-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651053969;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=xuH8RRONxl+DQX/OIKIJJ9vSVJLrKLopyzbW8H3FAnE=;
  b=JYrUK/iHXNuvhmSLLGGsJ8VuI5j7uGUBpPPXbM0Dmsi7KeDW1mvOatOw
   I+7VgknHOdQXrCEdoyR7UkDvN8tIM1Gka2IMmNPiVFQyGLncF66MrmMeY
   t59V2H84sECduXdehbSjwpmbgifw83oAX2DroIItzGcqYLBA5ztz7X+wR
   s=;
X-IronPort-RemoteIP: 104.47.58.104
X-IronPort-MID: 70432517
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:aF+OG67nPKkoT/vjqUXiagxRtDzGchMFZxGqfqrLsTDasY5as4F+v
 msbD2CAPayKM2Dxed13Ot7k/U0AvMODxtFmTQdp+XpjHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjXVvW0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSNdBcYOaPQod5HXhNpTgEjG7RhwJzudC3XXcy7lyUqclPK6tA3VAQaGNNd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YAgF/chegXdRraT
 +MfZSBic1LrZBpXN01MIJk/gP2plj/0dDgwRFe9+vJruDKOlVMZPL7FbIrqR4ySR/5vgWGUl
 kXbw3b6XRI6DYnKodaC2jf27gPVpgv5Uo8PELyz9tZxnUaegGcUDXU+VlaloP//lk+3XfpeL
 VAZ/mwlqq1a3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQA5oiVpbdUnsIo6QGIs3
 1rQx9fxX2U37PuSVG6X8aqSoXWqIy8JIGQeZCgCCwwY/93kp4J1hRXKJjp+LJOIYhTOMWmY6
 1i3QOIW3ux7YRIjv0ljwW36vg==
IronPort-HdrOrdr: A9a23:NwaSvKEBzSDElh6epLqFt5LXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNFICPoqTM2ftW7dySWVxeBZnMffKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj4Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWna4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlWFtyssHfsWG1SYczEgNkHmpDo1L/sqq
 iUn/4UBbU215oWRBDsnfKi4Xi67N9k0Q6e9bbRuwqenSW+fkN7NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxEC3/rFuGoO5gLZvtX+9Kq1wVB4SKbpXZd
 VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFoifA3jzMF7tYwWpNE7+
 PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94aLf8fEw/qWnaZYIxJw9lN
 DIV05Zr3c7fwb0BciHzPRwg2bwqaWGLEPQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP
 v2MI5KApbYXB/TJbo=
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="70432517"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TaYzN+GLsTuGjJVbNIANTyQJNgdDME/RCeB2nKLNXTp909joZ0JwYybxIh4zJQVq+ju7HQyeNMbzcgGVU3a6RPjvsEX8R2kX61+bohR1djpjTO64j7HTT2lgPjGIFmVjMTVbzXZi3pmxZvTL9/Ks6o3wB+bau4rFhOnDRUeNqaOJActHRpNuWhGPJhoO0zibNBD8T3YVEWm8Fu6nheQb8NJkRkc74DzYdRLVCBQcWRmlzoSlM30q7mG/Xhn2W20d48mtXzh8ZKn+8MtZ1VvmmBaL2K5B+JS4RyL0Vjr7yAJtzV7qSO/AckKaEfw7QyALsPZ0LXRInUc2jtVy1rsT4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xuH8RRONxl+DQX/OIKIJJ9vSVJLrKLopyzbW8H3FAnE=;
 b=gmYauG9WlsWjL1c2a19BWabZKHekClzJURbtfm+qQVXZOOxUD8/JsqQ6cWQLw/XiHM93FxujIKGUXIYM+M0Ie8kTBhROXKYaqKMfCxGR3PXNVvhhBV03Qb8vwGdfAyeA0crhnkPeEN++h7qLaVu5rr6Uxaii8WO/YzpiejeDKRezHJVTmj2SIAuJmkWGgUtsHfjBsxd4D1pbsbEPjXuRdxh3DG+u9iKmHC8g4GUk+hg55zLA/PlQd3hMmbtj56vevl+S92nmCZJleMu31o3KTOnmjLV5tddtdlA5TbBJbNfR9TdW2OEPVjntpn25VcNGLovDkogN8gBOTgSCQemH1A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xuH8RRONxl+DQX/OIKIJJ9vSVJLrKLopyzbW8H3FAnE=;
 b=tI3nMDGXPuXZQEOTxjIEgPlUINd6nXXFC/6PMWVmY0hHfD9kBIds1b8APRFpMEJLyeWj6rSbY4tB+jlnv7MYHkrVv7D9bWNYZsVgaygLiQDMvNEkXiSXdybA8OPseja+eErH06xHU++SKTFdLPjbyxKZ1jkzZmFjaMJHkdloGT0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Kevin Tian <kevin.tian@intel.com>,
	Edwin Torok <edvin.torok@citrix.com>, xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: RMRRs and Phantom Functions
Thread-Topic: RMRRs and Phantom Functions
Thread-Index: AQHYWZZDIrEkmq9fL0+3qLNT2+7QyK0DVX0AgAA0GQA=
Date: Wed, 27 Apr 2022 10:05:54 +0000
Message-ID: <f77ed15f-3dfe-e4f4-2790-7eca18ca9dfe@citrix.com>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
 <ec1efb6f-9d41-c018-582b-718254b55aa4@suse.com>
In-Reply-To: <ec1efb6f-9d41-c018-582b-718254b55aa4@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 63e658b1-ca4e-45f8-4348-08da283584a1
x-ms-traffictypediagnostic: DM5PR03MB2618:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs:
 <DM5PR03MB26189C592AD7B4872A849639BAFA9@DM5PR03MB2618.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 4wPBu401OvQkUbdUKBNillSCykwrUWTkMnar2t7hYl8z33K6AW6lrXynQNlQan+d5aLML1rpHUZx+ELFTO7NG+9WtNM0L0bI6IjuyOS1no+TbStw8sSsIXUDNf/Sc0Mb5Cgia5BaXgLFAb2EZAtFpoR/taTmhfXeXvRCpHsrPOp7EUCFvcQ6B4jghzN8ca3S1ouzCFL/EIbEMEz0PsetMC+4G4iXvT+lxudkqUmebB9N4bWpKFDnVohPhPUJP5fpLvUj5v1/M74e7lCEuTI/rdu4GLGwGinIIun5sw5w4mvvBCjcUmRWc655qjwah9hS5Zki/H0bxaVcXV4kHmuSPp2KU72Ez4+SKsJVIFyfuDVGLPfwstIDChYCN+nDTTc/c03+UdwD/w/C9Op8k6+W1/cmYdQD+bSG7QnlW3mMwE/DKVYLYV9Fe8//YQQFKSPvTvXS4l+t0tVe8T0RwBk7CfmvTtasU65kQdVuMSJ8Fw/16epubWxNemOyUkE+e7h+kB1wDSZg9XCyksWo066lK8Of+f24tf6dulfteE4G+qiuAU9kmaEBAwwuDVplIbFf8pxHqb/2oTWXW0HR7piHj53yuFiDXozKjlfAbFgrFjfmxxts7gOpSwokjr8w+YqeAWoxhULPB2ZGPDDerQpaOxhMOgc3S3ozARB1MbvHDqneQ5UnnNeSgx2oGDxjwnDvybh23jzqLu4Yy1DaqYfic8VKZpJtp78wWHlVFiUtleAiUGBTY0+r1TYAuwEcAy5h1hgn2NNubtACa1GR52p5Cg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(316002)(31686004)(6512007)(26005)(83380400001)(86362001)(8936002)(54906003)(53546011)(186003)(36756003)(6506007)(2616005)(66446008)(6916009)(122000001)(508600001)(38100700002)(3480700007)(31696002)(38070700005)(2906002)(6486002)(71200400001)(82960400001)(4326008)(76116006)(8676002)(66946007)(66556008)(66476007)(91956017)(64756008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?c24yTGV2RmtMV0hSQWlDNW9mNkJUdXczZ1BCNnF3ZHEwSTcvVVd1MFpEQUc1?=
 =?utf-8?B?MWpZV2V2bzRCSHl6OGFMamViSlhzbXRRb1JkYVlBdTM1VWJOcENRTyt6MnZh?=
 =?utf-8?B?dWJqVW5xanJqR0t3ajE3cHc2cW0xTFJCY09WWWVZZWhmWDl0VS9sdlpiYi9z?=
 =?utf-8?B?Q0NacXNrQ2VCakdaRXM3a2I4YmxhRTEwSUVReWt2dVROallpVHg0TWxqcitQ?=
 =?utf-8?B?Ymd6YzY1VStDbVRUNmV0Szl3SUNlL25DQ1NrdjUwNi9FbGhkdXZINndnbmdN?=
 =?utf-8?B?d1duaXFLdThwaDJmUzJuNW5EN1dTRnM0SVFLenBydkNMWWhzV2lMc1UvQjJx?=
 =?utf-8?B?WjhuRW9lREI5YVltVUZnMVlMcWsrVVBNeHVqV0V4dUc5aGkycFI2am10WW1M?=
 =?utf-8?B?a1dmMmMvK1JoR2o4OWlWajNHenE2dlJKV3Fzb3hrWnQreXhsNkZmd1JUQlNu?=
 =?utf-8?B?d2p2MGkzMGNTT1lhdnJyYzRyd1hQOGMyQ2V5SUJaM2w1VWlacmlRdytiTVJl?=
 =?utf-8?B?Wm9jUW5SL0pPZUZ2ZUtodXZ2V2NKNndrTGM4VkZia2s3S2pKeHcrZkRVRThI?=
 =?utf-8?B?SmJsRmhUeENSbllYZkJTMGg3NVJrTmJ3L0NWbWRNN2lCWTB0ZUZYMklTRFVx?=
 =?utf-8?B?YXRRSkNlWlRNaVA3anNwYXR1VDRmNjUxR1pJQlpqYUxrd1lTZVlUalNnWGpv?=
 =?utf-8?B?Z1kvbmhkNmpyaWpIS1JVdEFaRXkyQjhKRzkza2hKbEpSdzJReXhzSmFtb2My?=
 =?utf-8?B?MWVJNUFWZXVtdmZBd3B0b2h1SmhJbWorLzd2ZDRDaVh5RFFSU0lWL0VjUDdW?=
 =?utf-8?B?T05sTDdlY0h6MmRERzgyekRTOTJqdDJnd29EVUZDckxuZlo0M0pNeXJCR0to?=
 =?utf-8?B?VFRMNWdzV2lLQjhlZmhkYTRmMzVIOTNIMHlVZzNldjU2Q3ZYdGM4cWhtbTg5?=
 =?utf-8?B?cHBzUnJaUGwvemcxYWxjM2RvVllkdzc1elJhVVpXNWRTZnZCZ0IrS3B4V21v?=
 =?utf-8?B?SjJZVlk3YmhMUlpKQXdNbVh0TEpZbFVDRmxBeklJaFpUVEJyTEUxR2lYS3Y0?=
 =?utf-8?B?YzdXWXF3R0dabmdxbVNWSnJ2cFFtZG9jbnJiRFl5QUl4TGxia3NyK2RPSUFx?=
 =?utf-8?B?WnljQlM0d2VxKzJjQ2xlVWV5cWdWUWFyN3ZSRWxCZDVxaWpndGh2alhDbUFx?=
 =?utf-8?B?Rkt6cDIvMkgyUkJwVitTdW9XR0hLMkdxU1UvcEI5N0I4Kys3eVZrSVliUi9M?=
 =?utf-8?B?cEMrQnprMWFNc3prSWdLbTExWmoxc1pQNDVpeHNrR0s0c24rWWEwdTJPYkFS?=
 =?utf-8?B?N1BVeWc4NTJPZ1dFWjFIQ0Q3S2VBNGVaOWF6eFM5M3dYWjJRMFNYL3o5ZURn?=
 =?utf-8?B?RHJGazNiM0ZsVW9yaHJycFM4NU5JMlZXYys0SjFoTmpodGRaUHJuL1BmZUc1?=
 =?utf-8?B?YjZpWi9OUHMyaGZvL1hWN2xLN2x2WUF5TzBCU3o0VGI2L1pYUVBjZnRuVFlp?=
 =?utf-8?B?NDVEcmVQU2JmODU3cHd6KzFETXFFMmRQelRzU3FSTUpGSG5HczdsY1M1VG1V?=
 =?utf-8?B?MDEzUWRxRU5LQ3lwWUQyVzAzamtZTk01c0J1WkdjdkNza2pHSVBDY2NIQ3NX?=
 =?utf-8?B?WXFZL0xXT0RQRmhzejRvaTZocHZnRzIvQlFPQU05L3RjVkdwNU1qMU9ZS1p2?=
 =?utf-8?B?bitXYXNob1hYTit0RW05aklqU2lmWXZyTXNoQitMUVhvcGVRNC84MkdlQkgy?=
 =?utf-8?B?eStZZHlJODNJS3RNdGtiSURkRjJMd05YbHRvWG9PQ3BVRm5vREFyZEJMMldm?=
 =?utf-8?B?WHJQOU13SFhmZUNiUm5YSVJ3T2FwYlNFbTl1T04rZ3VGOHYvczBXQTFYYlFO?=
 =?utf-8?B?WUM0enFOT3FsRFNDR05IMmJ0eGZGdnpKa0VuTVlxVmk3TG1VcEIxZDhNK0VR?=
 =?utf-8?B?ZHpNbnpENE9URUxLQmRkdnN3OGNqRnNyRWQ4ZE9zd1hVNDQ0NFR4TzFnbzRO?=
 =?utf-8?B?dlRyZ0lZdGN6RkVGUjRPUHhsT25jbkdnUWtNZVBKcGMzUTRRcVpYdUVGdkhO?=
 =?utf-8?B?V0RWWllpbStKSFk1K0VnZ3NNb1pyRmRqamJrWHhVMUtVNHdhaWJJdE91eWVj?=
 =?utf-8?B?Z3EyZ2hmNVovY1c5eFlzUTV1aStFRVNLeUdVczlDSHpuNHoxTGtGRGVMVG1I?=
 =?utf-8?B?WU5VV2ZRUjhRbGhhZytBTkpOZmMvZGtuMlJzOWpSb3p1L2t1TFRxcU81dy8v?=
 =?utf-8?B?UFljWWVVTkkvditjTStrZmIvZWJoa2dBMXRTSmdlMm1wTlBMTVZiVXpqeWZy?=
 =?utf-8?B?ZktxNGR0U1A0Sm1iQmt3SHZ1bzJQaFhiVlc5YTNIMlY4TXAva2dpOGxQU3g2?=
 =?utf-8?Q?LaI1eICihYXXS/s0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A2897CEE37CF8044B116798A43AE9F93@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63e658b1-ca4e-45f8-4348-08da283584a1
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 10:05:54.9260
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /zp4Wem48cAPlnkFoD2qHUYTcBs+/g+3IOSsqFjt7bgvrInT1B/Mjxt3CC8UJqnNz4HRo5RGbm/E31ZXVLu2EBHcAfJXTaaG5CBNGmpIEd4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2618

T24gMjcvMDQvMjAyMiAwNzo1OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI2LjA0LjIwMjIg
MTk6NTEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBIZWxsbywNCj4+DQo+PiBFZHZpbiBoYXMg
Zm91bmQgYSBtYWNoaW5lIHdpdGggc29tZSB2ZXJ5IHdlaXJkIHByb3BlcnRpZXMuwqAgSXQgaXMg
YW4gSFANCj4+IFByb0xpYW50IEJMNDYwYyBHZW44IHdpdGg6DQo+Pg0KPj4gwqBcLVswMDAwOjAw
XS0rLTAwLjDCoCBJbnRlbCBDb3Jwb3JhdGlvbiBYZW9uIEU1L0NvcmUgaTcgRE1JMg0KPj4gwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgICstMDEuMC1bMTFdLS0NCj4+IMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCArLTAxLjEtWzAyXS0tDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKy0wMi4w
LVswNF0tLSstMDAuMMKgIEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2IgTklDDQo+
PiAoYmUzKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgICstMDAuMcKgIEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2IgTklDDQo+PiAo
YmUzKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
ICstMDAuMsKgIEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2INCj4+IGlTQ1NJIElu
aXRpYXRvciAoYmUzKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIFwtMDAuM8KgIEVtdWxleCBDb3Jwb3JhdGlvbiBPbmVDb25uZWN0IDEwR2INCj4+
IGlTQ1NJIEluaXRpYXRvciAoYmUzKQ0KPj4NCj4+IHlldCBhbGwgNCBvdGhlciBmdW5jdGlvbnMg
b24gdGhlIGRldmljZSBwZXJpb2RpY2FsbHkgaGl0IElPTU1VIGZhdWx0cw0KPj4gKH5vbmNlIGV2
ZXJ5IDUgbWlucywgc28gZGVmaW5pdGVseSBzdGF0cykuDQo+Pg0KPj4gKFhFTikgW1ZULURdRE1B
UjpbRE1BIFdyaXRlXSBSZXF1ZXN0IGRldmljZSBbMDAwMDowNDowMC40XSBmYXVsdCBhZGRyDQo+
PiBiZGY4MDAwMA0KPj4gKFhFTikgW1ZULURdRE1BUjpbRE1BIFdyaXRlXSBSZXF1ZXN0IGRldmlj
ZSBbMDAwMDowNDowMC41XSBmYXVsdCBhZGRyDQo+PiBiZGY4MDAwMA0KPj4gKFhFTikgW1ZULURd
RE1BUjpbRE1BIFdyaXRlXSBSZXF1ZXN0IGRldmljZSBbMDAwMDowNDowMC42XSBmYXVsdCBhZGRy
DQo+PiBiZGY4MDAwMA0KPj4gKFhFTikgW1ZULURdRE1BUjpbRE1BIFdyaXRlXSBSZXF1ZXN0IGRl
dmljZSBbMDAwMDowNDowMC43XSBmYXVsdCBhZGRyDQo+PiBiZGY4MDAwMA0KPj4NCj4+IFRoZXJl
IGFyZSBzZXZlcmFsIFJNUlJzIGNvdmVyaW5nIHRoZSB0aGVzZSBkZXZpY2VzLCB3aXRoOg0KPj4N
Cj4+IChYRU4pIFtWVC1EXWZvdW5kIEFDUElfRE1BUl9STVJSOg0KPj4gKFhFTikgW1ZULURdIGVu
ZHBvaW50OiAwMDAwOjAzOjAwLjANCj4+IChYRU4pIFtWVC1EXSBlbmRwb2ludDogMDAwMDowMTow
MC4wDQo+PiAoWEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDE6MDAuMg0KPj4gKFhFTikgW1ZU
LURdIGVuZHBvaW50OiAwMDAwOjA0OjAwLjANCj4+IChYRU4pIFtWVC1EXSBlbmRwb2ludDogMDAw
MDowNDowMC4xDQo+PiAoWEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDQ6MDAuMg0KPj4gKFhF
TikgW1ZULURdIGVuZHBvaW50OiAwMDAwOjA0OjAwLjMNCj4+IChYRU4pIFtWVC1EXWRtYXIuYzo2
MDg6wqDCoCBSTVJSIHJlZ2lvbjogYmFzZV9hZGRyIGJkZjhmMDAwIGVuZF9hZGRyIGJkZjkyZmZm
DQo+Pg0KPj4gYmVpbmcgdGhlIG9uZSByZWxldmFudCB0byB0aGVzZSBmYXVsdHMuwqAgSSd2ZSBu
b3QgbWFudWFsbHkgZGVjb2RlZCB0aGUNCj4+IERNQVIgdGFibGUgYmVjYXVzZSBkZXZpY2UgcGF0
aHMgYXJlIGhvcnJpYmxlIHRvIGZvbGxvdyBidXQgdGhlcmUgYXJlIGF0DQo+PiBsZWFzdCB0aGUg
Y29ycmVjdCBudW1iZXIgb2YgZW5kcG9pbnRzLsKgIFRoZSBmdW5jdGlvbnMgYWxsIGhhdmUgU1It
SU9WDQo+PiAoZGlzYWJsZWQpIGFuZCBBUkkgKGVuYWJsZWQpLsKgIE5vbmUgaGF2ZSBhbnkgUGhh
bnRvbSBmdW5jdGlvbnMgZGVzY3JpYmVkLg0KPj4NCj4+IFNwZWNpZnlpbmcgcGNpLXBoYW50b209
MDQ6MDAsMSBkb2VzIGFwcGVhciB0byB3b3JrIGFyb3VuZCB0aGUgZmF1bHRzLA0KPj4gYnV0IGl0
J3Mgbm90IHJpZ2h0LCBiZWNhdXNlIGZ1bmN0aW9ucyAxIHRocnUgMyBhcmVuJ3QgYWN0dWFsbHkg
cGhhbnRvbS4NCj4gSW5kZWVkLCBhbmQgSSB0aGluayB5b3UgcmVhbGx5IG1lYW4gInBjaS1waGFu
dG9tPTA0OjAwLDQiLg0KDQpBcyBhIHF1aWNrIHRhbmdlbnQsIHRoZSBjbWRsaW5lIGRvY3MgZm9y
IHBjaS1waGFudG9tPSBhcmUgaW4gZGVzcGVyYXRlDQpuZWVkIG9mIGFuIGV4YW1wbGUgYW5kIGEg
ZGVzY3JpcHRpb24gb2YgaG93IHN0cmlkZSB3b3Jrcy7CoCBJJ3ZlIGdvdCBzb21lDQppZGVhcyBh
bmQgbm90ZXMgam90dGVkIGRvd24uDQoNCkRvIHdlIHJlYWxseSBtZWFuICw0IGhlcmU/wqAgV2hh
dCBoYXBwZW5zIGZvciBmdW5jdGlvbiAxPw0KDQo+IEkgZ3Vlc3Mgd2UNCj4gc2hvdWxkIGFjdHVh
bGx5IHJlZnVzZSAicGNpLXBoYW50b209MDQ6MDAsMSIgaW4gYSBjYXNlIGxpa2UgdGhpcyBvbmUu
DQo+IFRoZSBwcm9ibGVtIGlzIHRoYXQgYXQgdGhlIHBvaW50IHdlIHNldCBwZGV2LT5waGFudG9t
X3N0cmlkZSB3ZSBtYXkNCj4gbm90IGtub3cgb2YgdGhlIG90aGVyIGRldmljZXMsIHlldC4gQnV0
IEkgZ3Vlc3Mgd2UgY291bGQgYXR0ZW1wdCBhDQo+IGNvbmZpZyBzcGFjZSByZWFkIG9mIHRoZSBz
dXBwb3NlZCBwaGFudG9tIGZ1bmN0aW9uJ3MgZGV2aWNlL3ZlbmRvcg0KPiBhbmQgZG8gPHdoYXRl
dmVyPiBpZiB0aGVzZSBhcmVuJ3QgYm90aCAweGZmZmYuDQoNCkF0IGEgbWluaW11bSwgd2Ugb3Vn
aHQgdG8gd2FybiB3aGVuIGl0IGxvb2tzIGxpa2Ugc29tZXRoaW5nIGlzIHdvbmt5LA0KYnV0IEkg
d291bGRuJ3QgZ28gYXMgZmFyIGFzIHJlamVjdGluZy4NCg0KQWxsIG9mIHRoZXNlIG9wdGlvbnMg
dG8gd29yayBhcm91bmQgZmlybXdhcmUvc3lzdGVtIHNjcmV3dXBzIGFyZSBhcHBsaWVkDQp0byBh
biBhbHJlYWR5LW5vbi13b3JraW5nIHN5c3RlbSwgYW5kIHRoZXJlIGlzIGFic29sdXRlbHkgbm8g
Z3VhcmFudGVlDQp0aGF0IG5lY2Vzc2FyeSBmaXhlcyBtYWtlIGFueSBraW5kIG9mIGxvZ2ljYWwg
c2Vuc2UuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:10:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:10:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314798.533021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njedO-0002nr-6q; Wed, 27 Apr 2022 10:10:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314798.533021; Wed, 27 Apr 2022 10:10:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njedO-0002nk-3u; Wed, 27 Apr 2022 10:10:58 +0000
Received: by outflank-mailman (input) for mailman id 314798;
 Wed, 27 Apr 2022 10:10:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njedM-0002ne-Q4
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:10:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njedM-0002wm-Bp; Wed, 27 Apr 2022 10:10:56 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njedM-0002Pm-5S; Wed, 27 Apr 2022 10:10:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Swv8BnOE/ILYeOAyzk6Q96DEZl1xyulyMQzFat9OreE=; b=GYjn5stC2BOP5VjLVjj5V4G7ns
	GGg1AUkUX+tvlKynQX45OVgOsx/dv2iIL7XWml5Pia8k/2W97fSeBfMOOIH9P7QMhrtZRpHNnqAcW
	tVFy4ndUp/TFYQD2DUc4DcB/l9408dyVFh0e9EEP6ve3KAigqe0c0AzzJBLPqkiPvTPk=;
Message-ID: <95b1d82e-92fa-7468-d3aa-038f0de937d9@xen.org>
Date: Wed, 27 Apr 2022 11:10:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, henry.wang@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
 <20220427092743.925563-6-Penny.Zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427092743.925563-6-Penny.Zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 27/04/2022 10:27, Penny Zheng wrote:
> Today when a domain unpopulates the memory on runtime, they will always
> hand the memory back to the heap allocator. And it will be a problem if domain
> is static.
> 
> Pages as guest RAM for static domain shall be reserved to only this domain
> and not be used for any other purposes, so they shall never go back to heap
> allocator.
> 
> This commit puts reserved pages on the new list resv_page_list only after
> having taken them off the "normal" list, when the last ref dropped.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
> v3 changes:
> - have page_list_del() just once out of the if()
> - remove resv_pages counter
> - make arch_free_heap_page be an expression, not a compound statement.
> ---
> v2 changes:
> - put reserved pages on resv_page_list after having taken them off
> the "normal" list
> ---
>   xen/arch/arm/include/asm/mm.h | 12 ++++++++++++
>   xen/common/domain.c           |  4 ++++
>   xen/include/xen/sched.h       |  3 +++
>   3 files changed, 19 insertions(+)
> 
> diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
> index 424aaf2823..c6426c1705 100644
> --- a/xen/arch/arm/include/asm/mm.h
> +++ b/xen/arch/arm/include/asm/mm.h
> @@ -358,6 +358,18 @@ void clear_and_clean_page(struct page_info *page);
>   
>   unsigned int arch_get_dma_bitsize(void);
>   
> +/*
> + * Put free pages on the resv page list after having taken them
> + * off the "normal" page list, when pages from static memory
> + */
> +#ifdef CONFIG_STATIC_MEMORY
> +#define arch_free_heap_page(d, pg) ({                   \
> +    page_list_del(pg, page_to_list(d, pg));             \
> +    if ( (pg)->count_info & PGC_reserved )              \
> +        page_list_add_tail(pg, &(d)->resv_page_list);   \
> +})
> +#endif

I am a bit puzzled how this is meant to work.

Looking at the code, arch_free_heap_page() will be called from 
free_domheap_pages(). If I am not mistaken, reserved pages are not 
considered as xen heap pages, so we would go in the else which will end 
up to call free_heap_pages().

free_heap_pages() will end up to add the page in the heap allocator and 
corrupt the d->resv_page_list because there are only one link list.

What did I miss?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:18:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:18:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314805.533033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njekD-0003Ys-23; Wed, 27 Apr 2022 10:18:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314805.533033; Wed, 27 Apr 2022 10:18:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njekC-0003Yl-V6; Wed, 27 Apr 2022 10:18:00 +0000
Received: by outflank-mailman (input) for mailman id 314805;
 Wed, 27 Apr 2022 10:17:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8dk3=VF=citrix.com=prvs=109ad7ccf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njekA-0003YK-VZ
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:17:59 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4d2e7f20-c613-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 12:17:56 +0200 (CEST)
Received: from mail-mw2nam08lp2170.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 06:17:53 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SN6PR03MB4399.namprd03.prod.outlook.com (2603:10b6:805:fe::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 10:17:50 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:17:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d2e7f20-c613-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651054676;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=64WkSlMfxmMClRJnN3KRM3zv1EcSh3KQ22VB0ss8hyY=;
  b=UP3t8uSHK1sdiJJDYfaRy/MtdcCazLt/7kSM3ynRI7+d9bx6tna612Km
   WC2c0u/lZSVUNpMUOthX5WKveThdnecOLRUgTwwajqhUJVwsMxskDZ2VQ
   QEmwaHgL/ZLHJk//Z6BTZ1XehbtoOahA9aqImOQvQKcd3eQkSyZJ/ouJW
   E=;
X-IronPort-RemoteIP: 104.47.73.170
X-IronPort-MID: 70048556
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:PQGFWqKbxipoRd2sFE+R1JQlxSXFcZb7ZxGr2PjKsXjdYENS0jcOy
 zNNX2DTOvjbYGOjc9lxbIyypkhUuZDRzt9qGgtlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQ22YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Ilqt8KLFwg0BPXjotUkfCBnLzshHqITrdcrIVDn2SCS52vvViOwhtBRVgQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHsuFGvqSjTNb9G5YasRmNPDSf
 ccGLxFoawzNeUZnMVYLEpMu2uyvgxETdhUH8ArJ9fdqvQA/yiQv8/vcLsX3PeCsTMNPlUuUh
 HPqokDAV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWdhSN
 kgV8SoGtrUp+QqgSdyVdx61vn+C+AIdUtx4Eusm5QXLwa3Rizt1HUABRz9FLdk57sk/QGR60
 kfTxoyxQztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC
 RjQxMTir93/VfI26pg=
IronPort-HdrOrdr: A9a23:LuEZpKzLis7RLViPFhP5KrPxc+gkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMYs1MSZLXPbUQyTXc9fBOrZsnHd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadg/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZcbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESvtu/oXvUlZ1SxhkFznAid0idtrD
 AKmWZ4Ay1H0QKUQohym2q05+Cv6kd015ao8y7kvZKqm72EeNt9MbsAuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGrf2x4Uh37D30XklWavoJhiKoLzP0d
 Meef309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw9ArfZv00so5dY4Ud1J9u
 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCaZIEjhFqsAJ3XRwqSHqokd9aWvYtgF3ZEykJ
 POXBdRsnMzYVvnDYmU0JhC4nn2MROAtPTWu7ZjDrRCy83BreDQQFy+oXgV4ridiuRaBNHHUP
 CuP58TC+P/LALVaPJ04zE=
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="70048556"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WcQURrpCnRL3BEgoif38/oEjcKzKjG4qlJpMIzp1ll51h6sWt4J4g7jdF9uaDk9GavZ/qZJyBPnGpM+FSAHTFOWJprsb3bQIpkwX3svtZBE2HFqO6gZwXC6t+ueUfzlFyamd1bwLdyznLetghxdnW/vSUPX8fVxX71PAy4DPVMSR7vN+dm+Y+D1q3CvacFnFpCnkObcCrastirIXWK33u8l3ULX52nh7g+KpeiIc04506SG11w2fseWT/6PI6C4oAdKujqlklGnkebh36RfZLQ7DjAR0QNes1sfo3iBDp4PVZa5HDEqjPhxQtcKAwxy1TBXeQ62l7b0QwwL5EZO2aw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=64WkSlMfxmMClRJnN3KRM3zv1EcSh3KQ22VB0ss8hyY=;
 b=cFqchBBi10wW3s+BmgJg3KtOW0siJXHiKQUHc45NSIpsatFXG9hQEqVG54FTmCL42y9bOAnKeYuEQIu0QObC8TNO/QiZ1YrDqEK4dEhFwxaaPC4Z1RfKRy/dodevTLinGBS57gGFNqxQqpMS2QzHWZJr2dYREwneGVDmb3VLl6ov5BsgKAfyhoOKR3nR8tuR280AbR6qGZp8G+qEDLpWQf8FHssQzQvC91MkG6JxPECe8EIu15AjTaIRQV8stBsap2CbtGA+OQaC3jaRWseEIADRn4RKxhz7HgDzA1b4TUJ5+LQ/mGMbfDYl8ivOkur8rWsTWr7hoplx2rY/dCHNxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=64WkSlMfxmMClRJnN3KRM3zv1EcSh3KQ22VB0ss8hyY=;
 b=RTF9P4vgn9hDiFnhWqjUw4JAF8Gp7nlpDxcRmVtHSuq+TpICksNLuK1qUwY8YhiF2cK9ak9Sj10rEljl4Hmu2lxlqkWESvacfy5qIupDiQZgEaZgeQwa0pATHaYkrGJOSb8iOLUqHJq1Ydma/z6XfmCsq4exH3nR/zhJ/ZOH7wg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<jbeulich@suse.com>, Kevin Tian <kevin.tian@intel.com>, Edwin Torok
	<edvin.torok@citrix.com>
Subject: Re: RMRRs and Phantom Functions
Thread-Topic: RMRRs and Phantom Functions
Thread-Index: AQHYWZZDIrEkmq9fL0+3qLNT2+7QyK0DZ3OAgAAld4A=
Date: Wed, 27 Apr 2022 10:17:49 +0000
Message-ID: <c3c83d6d-dc84-bd81-4087-1eece1acb18a@citrix.com>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
 <Ymj435hWOcY9BK36@Air-de-Roger>
In-Reply-To: <Ymj435hWOcY9BK36@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 932ee59e-f330-4e67-284e-08da28372ebc
x-ms-traffictypediagnostic: SN6PR03MB4399:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs:
 <SN6PR03MB4399082CAE650EE5D82C4147BAFA9@SN6PR03MB4399.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 2RbXbkY3aX3Hh3SuB1rmEztlTuJDG4HjkCqWM46ZN+qENX2hHZI9TREqEvFZ0OgxpPlhdLx5+GCesaKfxe5pmiUmIJZZiBLiLfqQgoHwE43iP95n3vveZnUOKWSEy+BFRKsknlwBKqajsSWZbcOPWuEiQUozbovLDUW5wnH5P1dNNsZFmz5JW68IndZ0ahdRPC3AgFOFzrRn6kC8MwYI5BbiNEViTjxoVftJeK+6w2RfIXGoLIMOAWu3/kDamJIZHjnaPtEFzJwjB10Pc6bYpTYTd20Uul8sBygCeLForOtiWSune6zzAyw2aIw+b8b2dlK3O+4CNNlWis82xgAHmzsMfWxt2SvNWQbQ7UMEkfwRljCi6QXx8KfMGu86bjGV4V9tbK6sTS6FYDc4lbplkZJ+jvDuLIDFmynmpbVVELAd+a4umfr++48Ef3rqDz886NumEChwp2Xt927L5xPGImOPRXYZXqLYD9URTNvdxCNMLJDB4RP38Z9yFHIAEHFVwXF+NNMfO14jLr9CynW3SQQVpM/phJgs5kWflt1A5qlWk1srnfQrZixmvyg0NUbEcLjFwt5yAV34nS68z0EMuN1aB4olNxqebb6dbuFwmVarJ2p8YmSPmT4k9kJgQkftqIEV6inHoUuCbFbqvxa6bEfcUTm/0XD+xMVaUFdH3pgPMQ6hkrI8lqYDChf0aw3YmqEqyBtHk5j+7eHJ+c/6JwqZW/PZckv0W9F/i8y4+aRkALmu7RHTuZU4M56XxUfxWjBF4zZiGhdeQXFPFQrvoQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(37006003)(6486002)(54906003)(122000001)(76116006)(86362001)(6862004)(2616005)(508600001)(71200400001)(8936002)(2906002)(107886003)(31686004)(83380400001)(82960400001)(91956017)(66946007)(4326008)(5660300002)(3480700007)(8676002)(186003)(64756008)(66556008)(66476007)(66446008)(26005)(6512007)(6636002)(6506007)(316002)(53546011)(38100700002)(31696002)(38070700005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?a09kZ0Z0YmZjTUgySm83ODN5eklzK2ZxVFErZ1I3anJnaW50elkvcXpCYWQ5?=
 =?utf-8?B?NFo1R0Q2N1JmRGdYcWtOSmY3Rk8zdG5wUHBJNHVhMXpzVVJGOWc4blRCZVA2?=
 =?utf-8?B?NVlRL0lFM0JHdEJqMld5OTJRUzdVazNjVEhYY1haYlUvOVBEdDhNZFRaa2ZT?=
 =?utf-8?B?YTJGaFpWQnpWTTV3ZzRVZjVrNGZESlRiS25KbHA2dVFOVHRsamNaeWo4Nk1w?=
 =?utf-8?B?QVpMdjd3LzhEN3h1Ync5LzZOdTJ3Z29zcituTmlsRlNydXc3NFNuYm9RK0U5?=
 =?utf-8?B?WUZzSlhVTHFwSlFDTysvRTV5b2F6RnlqYkhuOUthSVlBZHg2VEMxbEdMcCtY?=
 =?utf-8?B?bEhrdVpvdjhTdmFIbEFRSW1Hbm05d0RDQWNTVGpBcVRwNjJvZFhFRlNOd2U2?=
 =?utf-8?B?Z0lxamdDTDNDOE03YXZtalJnRGpYTDJYQVJvT0kwVTRjbzI5UHFRV3k0dkk3?=
 =?utf-8?B?M1ZYdkVMN1VnWkRUMDFBWStzL3NjSXlPMEx0Qno3VlJoQ1NNUVV4UktTRVpy?=
 =?utf-8?B?VjdaV3NDaEdyLzM2RW12azhRdVd4RVJkREdvOUE5eldsVlVWSFFlTEtaU1Zt?=
 =?utf-8?B?WURVSzBJbHdpZlZYVy8wd2FRZ05aT0FnazlENDZFK041MlZQS3B1cjJzMHRK?=
 =?utf-8?B?b3ZoNkFzRzk2SDBFVkNtZTJJeWcxSFpzZEVlTk4yT3hLbE1mcXJITE5hMERK?=
 =?utf-8?B?MmdMY0JJdCtad3B3YVQvTW5YQTVRR1E3SFJaNUd3TW5Wb2tJdk96Vkt0eHhy?=
 =?utf-8?B?cFh5VUtxQkI0STVXdVlNeUdFZEo5Sm96MWNQNVA2eHV4NTVZMzF1aTdXd0NF?=
 =?utf-8?B?YUJZeFVHbVh0aWpIaUVCRjJ4U0RFLzNhVzRENlVhUU5nQVVIY2IvTDhnNXQ5?=
 =?utf-8?B?WXE0eXRMdEFwM3lLeno2NFk4TXRCdkgyQzZZbmNmZFJyUDdlQWNhMWY1bGdq?=
 =?utf-8?B?YjZvenBvSUV6bmllV1VCejBCQ1RVQVFWdExWUXhndWdFY05zeHdZVVZlYlkw?=
 =?utf-8?B?ZnJ1YXNTQVJFU1luVERjaHE0U0NCZlZhTVQ3dEJiNDA1U0VWTVNzY1Z4cDF6?=
 =?utf-8?B?bnU5U2g0L3dEcldKeHgwWVQ3QWludExmMDhzbkoyclArNlA5K2xtWXBqMmxv?=
 =?utf-8?B?SVYrN1gwa3dndi9nMFZVWTJiQmVaVzNiZ2ZzZ1J3N2tTbnRqMDBZMGVsT0xP?=
 =?utf-8?B?NHlYYXMyQzB5OVdxSkZYcS9lSDlmVm1VQW1FZGowdkliaWVwcUJ2TS9PbkJQ?=
 =?utf-8?B?WEJ2enhtRFFrOWFZeDdiUVk2WEErZk5pWXZuTGZEZUZIYlJtV3I2VTQ2MmZl?=
 =?utf-8?B?bVEya0N4a1E1WlI4aEdkejh1Qzg4MlNOTjMyRlZra20xTVROdWVZK3RmRFJL?=
 =?utf-8?B?UkRVd292cTh3bUxFajZJVk4rejRSVUdZRVE4NHdldSthN2ppK2ZsV2V5anlU?=
 =?utf-8?B?Z2RnKzdReUVhVm1yVENMeUxyOVdlMkVwN3F3VXNqOFVPZkRqdFh0NFlzR1l4?=
 =?utf-8?B?cUF3WmU3RVNZNWo3SE55K2xkYmFKNG5RanR0YVJITEkvWmwrNzg4MHJZOGxi?=
 =?utf-8?B?a1Fpb2NXMjNTNDZEWTNQRlB2UnEyN3FjcTc2NHZMY1hNY1dEeUpaUVJGVlZ2?=
 =?utf-8?B?ZkhrT3Y1MFVINEJmaUt3L2prbVI2bE0rM3NOc1pRbGdhNzFKOFNxOGFlaTc3?=
 =?utf-8?B?Qm1MTUkxdk54TzA0UVgzUUoxVHJ6VElJR0d3T1dJbDhwaW9nelVKL0Q2TDFk?=
 =?utf-8?B?Y3pSZ0RReXRrNDQzT3hOUGVBaDZOMzV5d3ZvZTdyNkUrS1FTT2hhVkRBSG40?=
 =?utf-8?B?TXlRaUtXZ3pISHFkQU9nd3E4TlN1V243VWo2T0pJZTRPb1JEQ0tWclBEVVZu?=
 =?utf-8?B?Z3hWNE9RSjF0SGt5UTRQRWprakNyd3Q3amZQR29vK3BXOSttWi8zd3FiVjRP?=
 =?utf-8?B?UDFOTjJjMGZIUEVwd3Z5R2NScnhHaVVLYTVQRjBxSXNrazFGQ01Vcit2czk3?=
 =?utf-8?B?cTZOUG9Oby9MQTRVekdRSGxicTVZbzlaSEt2SzZpSzlDeDRHNk1JNVdld1RE?=
 =?utf-8?B?MmxiVGZ4VHpRS1hVc0w3NXJHSktkelR1TDQ4YnlveEM1SEx6OEhaVFJrYTRp?=
 =?utf-8?B?bDFRUG01clQ4bW5RbW9BQ0gwMCtIUVowL1cxTCtBRVhkRGRSeFEyOCtOTnpT?=
 =?utf-8?B?amdoa2NsVXJITFBUUG9BU1RjclUvSWE3TVRCdlhnVzJuS2xIRUJva0x3S1F4?=
 =?utf-8?B?U3JiWFpzWlBXNjg3OUtZeVJXeUg1c3QxWHJXV3VaMkRjejh4QXNrTG9SaHlp?=
 =?utf-8?B?YXpneVdlR0VPZ2dlQWFIQmV2SmczOVoxTlNDMGl3STR4dnlBNWVKYk1nWUxU?=
 =?utf-8?Q?HnfipKI9lkLLbZMM=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <16D5E46699AC1F41AE670EE230BEEE75@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 932ee59e-f330-4e67-284e-08da28372ebc
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 10:17:49.8116
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bus0SasxhmQc1TtJ4YDhauE48by3StEyJISF9Gvsv2/3xpgetOOx71CzMwA8fJwmqnqYILfAQSHBUqIMpXSCebHI2RFbxhmHfx1ONsMiE1A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4399

T24gMjcvMDQvMjAyMiAwOTowMywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBPbiBUdWUsIEFw
ciAyNiwgMjAyMiBhdCAwNTo1MTozMlBNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4g
SGVsbG8sDQo+Pg0KPj4gRWR2aW4gaGFzIGZvdW5kIGEgbWFjaGluZSB3aXRoIHNvbWUgdmVyeSB3
ZWlyZCBwcm9wZXJ0aWVzLsKgIEl0IGlzIGFuIEhQDQo+PiBQcm9MaWFudCBCTDQ2MGMgR2VuOCB3
aXRoOg0KPj4NCj4+IMKgXC1bMDAwMDowMF0tKy0wMC4wwqAgSW50ZWwgQ29ycG9yYXRpb24gWGVv
biBFNS9Db3JlIGk3IERNSTINCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCArLTAxLjAtWzEx
XS0tDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKy0wMS4xLVswMl0tLQ0KPj4gwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgICstMDIuMC1bMDRdLS0rLTAwLjDCoCBFbXVsZXggQ29ycG9yYXRp
b24gT25lQ29ubmVjdCAxMEdiIE5JQw0KPj4gKGJlMykNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCArLTAwLjHCoCBFbXVsZXggQ29ycG9yYXRpb24g
T25lQ29ubmVjdCAxMEdiIE5JQw0KPj4gKGJlMykNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCArLTAwLjLCoCBFbXVsZXggQ29ycG9yYXRpb24gT25l
Q29ubmVjdCAxMEdiDQo+PiBpU0NTSSBJbml0aWF0b3IgKGJlMykNCj4+IMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcLTAwLjPCoCBFbXVsZXggQ29ycG9y
YXRpb24gT25lQ29ubmVjdCAxMEdiDQo+PiBpU0NTSSBJbml0aWF0b3IgKGJlMykNCj4+DQo+PiB5
ZXQgYWxsIDQgb3RoZXIgZnVuY3Rpb25zIG9uIHRoZSBkZXZpY2UgcGVyaW9kaWNhbGx5IGhpdCBJ
T01NVSBmYXVsdHMNCj4+ICh+b25jZSBldmVyeSA1IG1pbnMsIHNvIGRlZmluaXRlbHkgc3RhdHMp
Lg0KPj4NCj4+IChYRU4pIFtWVC1EXURNQVI6W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZpY2UgWzAw
MDA6MDQ6MDAuNF0gZmF1bHQgYWRkcg0KPj4gYmRmODAwMDANCj4+IChYRU4pIFtWVC1EXURNQVI6
W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZpY2UgWzAwMDA6MDQ6MDAuNV0gZmF1bHQgYWRkcg0KPj4g
YmRmODAwMDANCj4+IChYRU4pIFtWVC1EXURNQVI6W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZpY2Ug
WzAwMDA6MDQ6MDAuNl0gZmF1bHQgYWRkcg0KPj4gYmRmODAwMDANCj4+IChYRU4pIFtWVC1EXURN
QVI6W0RNQSBXcml0ZV0gUmVxdWVzdCBkZXZpY2UgWzAwMDA6MDQ6MDAuN10gZmF1bHQgYWRkcg0K
Pj4gYmRmODAwMDANCj4+DQo+PiBUaGVyZSBhcmUgc2V2ZXJhbCBSTVJScyBjb3ZlcmluZyB0aGUg
dGhlc2UgZGV2aWNlcywgd2l0aDoNCj4+DQo+PiAoWEVOKSBbVlQtRF1mb3VuZCBBQ1BJX0RNQVJf
Uk1SUjoNCj4+IChYRU4pIFtWVC1EXSBlbmRwb2ludDogMDAwMDowMzowMC4wDQo+PiAoWEVOKSBb
VlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDE6MDAuMA0KPj4gKFhFTikgW1ZULURdIGVuZHBvaW50OiAw
MDAwOjAxOjAwLjINCj4+IChYRU4pIFtWVC1EXSBlbmRwb2ludDogMDAwMDowNDowMC4wDQo+PiAo
WEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDQ6MDAuMQ0KPj4gKFhFTikgW1ZULURdIGVuZHBv
aW50OiAwMDAwOjA0OjAwLjINCj4+IChYRU4pIFtWVC1EXSBlbmRwb2ludDogMDAwMDowNDowMC4z
DQo+PiAoWEVOKSBbVlQtRF1kbWFyLmM6NjA4OsKgwqAgUk1SUiByZWdpb246IGJhc2VfYWRkciBi
ZGY4ZjAwMCBlbmRfYWRkciBiZGY5MmZmZg0KPj4NCj4+IGJlaW5nIHRoZSBvbmUgcmVsZXZhbnQg
dG8gdGhlc2UgZmF1bHRzLsKgIEkndmUgbm90IG1hbnVhbGx5IGRlY29kZWQgdGhlDQo+PiBETUFS
IHRhYmxlIGJlY2F1c2UgZGV2aWNlIHBhdGhzIGFyZSBob3JyaWJsZSB0byBmb2xsb3cgYnV0IHRo
ZXJlIGFyZSBhdA0KPj4gbGVhc3QgdGhlIGNvcnJlY3QgbnVtYmVyIG9mIGVuZHBvaW50cy7CoCBU
aGUgZnVuY3Rpb25zIGFsbCBoYXZlIFNSLUlPVg0KPj4gKGRpc2FibGVkKSBhbmQgQVJJIChlbmFi
bGVkKS7CoCBOb25lIGhhdmUgYW55IFBoYW50b20gZnVuY3Rpb25zIGRlc2NyaWJlZC4NCj4gQWNj
b3JkaW5nIHRvIHRoZSBQQ0llIHNwZWMgQVJJIGNhcGFibGUgZGV2aWNlcyBtdXN0IG5vdCBoYXZl
IHBoYW50b20NCj4gZnVuY3Rpb25zOg0KPg0KPiAiV2l0aCBldmVyeSBGdW5jdGlvbiBpbiBhbiBB
UkkgRGV2aWNlLCB0aGUgUGhhbnRvbSBGdW5jdGlvbnMgU3VwcG9ydGVkDQo+IGZpZWxkIG11c3Qg
YmUgc2V0IHRvIDAwYi4gVGhlIHJlbWFpbmRlciBvZiB0aGlzIGZpZWxkIGRlc2NyaXB0aW9uDQo+
IGFwcGxpZXMgb25seSB0byBub24tQVJJIG11bHRpLUZ1bmN0aW9uIGRldmljZXMuIg0KDQpMb3Zl
bHkuLi4NCg0KPg0KPj4gU3BlY2lmeWluZyBwY2ktcGhhbnRvbT0wNDowMCwxIGRvZXMgYXBwZWFy
IHRvIHdvcmsgYXJvdW5kIHRoZSBmYXVsdHMsDQo+PiBidXQgaXQncyBub3QgcmlnaHQsIGJlY2F1
c2UgZnVuY3Rpb25zIDEgdGhydSAzIGFyZW4ndCBhY3R1YWxseSBwaGFudG9tLg0KPj4NCj4+IEFs
c28sIEkgZG9uJ3Qgc2VlIGFueSBsb2dpYyB3aGljaCBhY3R1YWxseSB3aXJlcyB1cCBwaGFudG9t
IGZ1bmN0aW9ucw0KPj4gbGlrZSB0aGlzIHRvIHNoYXJlIFJNUlJzL0lWTURzIGluIElPIGNvbnRl
eHRzLsKgIFRoZSBmYXVsdHMgb25seQ0KPj4gZGlzYXBwZWFyIGFzIGEgc2lkZSBlZmZlY3Qgb2Yg
MDQ6MDAuMCBhbmQgMDQ6MDAuNCBiZWluZyBpbiBkb20wLCBhcyBmYXINCj4+IGFzIEkgY2FuIHRl
bGwuDQo+IEkgdGhpbmsgSSdtIHNsaWdodGx5IGNvbmZ1c2VkLCBzbyB0aG9zZSBmYXVsdHMgb25s
eSBoYXBwZW4gd2hlbiB0aGUNCj4gZGV2aWNlcyBhcmUgYXNzaWduZWQgdG8gZG9tYWlucyBkaWZm
ZXJlbnQgdGhhbiBkb20wPw0KPg0KPiBJdCB3b3VsZCBzZWVtIHRvIG1lIHRoYXQgZnVuY3Rpb25z
IDQgdG8gNyBub3QgYmVpbmcgcmVjb2duaXplZCBieSBYZW4NCj4gc2hvdWxkIGFsc28gbGVhZCB0
byB0aGVpciBjb250ZXh0IGVudHJpZXMgbm90IGJlaW5nIHNldHVwIGluIHRoZSBkb20wDQo+IGNh
c2UsIGFuZCB0aHVzIHRoZSBmYXVsdHMgc2hvdWxkIGFsc28gaGFwcGVuLg0KDQpGdW5jdGlvbnMg
NCB0aHJ1IDcgZG8gbm90IGV4aXN0IGluIHRoZSBzeXN0ZW0uwqAgVGhlaXIgY29uZmlnIHNwYWNl
IGlzDQphbGwgfjAncy4NCg0KQXMgdGhleSBhcHBlYXIgdG8gYmUgbm9uLWV4aXN0ZW50LCBubyBJ
T01NVSBjb250ZXh0IGlzIHNldCB1cCBmb3IgdGhlbSwNCmhlbmNlIHRoZSBETUEgZmF1bHRzIHdo
ZW4gdGhlaXIgc291cmNlIGlkIGlzIGFjdHVhbGx5IHVzZWQuDQoNCldoZW4gc3BlY2lmeWluZyBw
aGFudG9tLCB3aGF0IHdlJ3JlIHNheWluZyBpcyB0aGF0ICJmdW5jdGlvbiAkWCB1c2VzICRZDQph
cyBhIHNvdXJjZSBpZCB0b28iLsKgIE9yIGluIG90aGVyIHdvcmRzLCB0cmVhdCAkWSBhcyBpZiBp
dCB3ZXJlICRYLsKgIEluDQphIHRoZW9yZXRpY2FsIGZ1dHVyZSB3aXRoIHdvcmtpbmcgSU9NTVUg
Z3JvdXBzLCB0aGlzIHdvdWxkIGZvcmNlICRYIGFuZA0KJFkgaW50byB0aGUgc2FtZSBJT01NVSBn
cm91cCBhcyB0aGV5IGNhbid0IGJlIHNlcGFyYXRlZC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:18:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:18:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314810.533044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeky-00044h-BG; Wed, 27 Apr 2022 10:18:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314810.533044; Wed, 27 Apr 2022 10:18:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njeky-00044a-7q; Wed, 27 Apr 2022 10:18:48 +0000
Received: by outflank-mailman (input) for mailman id 314810;
 Wed, 27 Apr 2022 10:18:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njekw-0003vx-OT
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:18:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a690e7b-c613-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 12:18:45 +0200 (CEST)
Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 06:18:42 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by CY4PR03MB3125.namprd03.prod.outlook.com (2603:10b6:910:53::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 10:18:40 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:18:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a690e7b-c613-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651054725;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=SoUA/36O8AChsf5IzVXqZgjp1qN8ewt+AVYDPB54nuA=;
  b=FSEVK7coARjbZUooANlWd1kP4GxsxWg3fyLM8oMJFRmeFt1eY+VxzOGQ
   EIt/gWb4YXuUurJ18U+56u2yKciFW/6IiYTe5gBRaF7fJDxLmDzDQ26lY
   E3HkfQuAXsFzKJlTcYwZlcCgHb+mJ1o53QXylIvn2i+gO0oW9j05PgsTp
   8=;
X-IronPort-RemoteIP: 104.47.56.170
X-IronPort-MID: 70048602
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:EWxbOqpDieoFwz/7TZCuq7qWAaFeBmJmZBIvgKrLsJaIsI4StFCzt
 garIBmCbvaJZWfwLtB0YI+0phkH6JPXmoUxTFFs+XphH3tG8JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 42q+KUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBGrDVgN1acB5jCGJHMa1B2eTsDyP8mJnGp6HGWyOEL/RGKmgTZNRd0cEuRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFgnFp2Zgm8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK/fJrszaLlmSd1pCzPMCMR/7XRPwSxBvHr
 GiY4GrSXAAjYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUVWEW6p7+li0e4c9NZN
 0EQvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWblXoVRZEYd0i8cQxHDoj0
 wbQm8uzXGM39rqIVXia67GY6yuoPjQYJnMDYilCShYZ597ko8c4iRenostfLZNZR+bdQVnYq
 w1mZgBk71nPpabnD5mGwG0=
IronPort-HdrOrdr: A9a23:UD9us62czgqiqFKQjtgD5gqjBTtyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp
 uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6
 Dsm/av6gDQMUj+Ka+Adwo4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 LxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72PeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu15Dq
 r/Q+BVfYp1P74rhJJGdZk8qPSMexzwqDL3QRSvyAfcZeg600ykke+E3JwFoMeXRbcv8Lwe3L
 z8bXIwjx9GR6upM7zC4KF2
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="70048602"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FrgHbd2+ZqcvuxOVgcgUqMi7zaAW6wX2LXklgpkovc3NWkUhKqEO3DD7FtgMFAyL8hpQJvybeXur8lD9GWoC2y90d0OHv6fQ+l14thWC9tiKNTqkughAXJhOl/R9IscGGkCOchLfFqi4TK/wx3Xh/kIMn5WFeJ4+JItKdZouYsbZrQjbA4K+NzJAENij5O4UDJOHESxmMbjxrKWISGGJKLEohmK2SAdog7Crvgwz7+vQzoexTU5y5I6xYqkem8hct/tZaLb813McSPG+yQBE0/iu4e7Xhj/bIagNWBvSDTArt6JI92Pb52uv/1UNcEnIThnHFxHDzQDuV6uLX4MSFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DsC2Spo7snQqRCQysI7Uh60F8HhrNIZf0ocSbWN6/1Q=;
 b=WoOFDc+mIh4LuiwixKnCkwzlDU9uPnHLV/tl8jUVTXveSVdZNXzjzhgHEcQGonXD9FaiiNp7ijrEsOFQuPGIP+VNl2av7u9BM0bkVdYZV0oi7tG9T9AcIpiUMsRsVahd3Q+aGcFhLLBZ2qsTNSNAkLeFxg+kQINog4vdkR9qxsAqR+i5Q/MXtVwcZuRUB20sXXmVQj0OX0f5WqIZ01t7FFuYdk/3xXkUQMSrVsTnLihgylTLnz3OLMB4srgIRUy9iOaFbVoQ9wA815cEX9ZIF1EZRhKJyDOufNmga4Jole7j+5LS+/UPYKmNv84IQPrJlmegApz1pjYKNNLxTWGnTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DsC2Spo7snQqRCQysI7Uh60F8HhrNIZf0ocSbWN6/1Q=;
 b=PGZvnIUnZlKVBJBrS8RMNfubv7SMQNEulAROmSb6UX4bo264ojMbaCw3g/sI6ox7L9lCICRTvnrdY+uwy5EKuVAGhTfVhoxNCwhwwptfZUtZ4YehRcTEiFa4UD30pp3oi8E9V4GE7BBy45w/eCKQ/I9hFD4gT3PGk2dUcElq/yc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 12:18:35 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>, Kevin Tian <kevin.tian@intel.com>,
	Edwin Torok <edvin.torok@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: RMRRs and Phantom Functions
Message-ID: <YmkYe+prpf6qzMmJ@Air-de-Roger>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
 <ec1efb6f-9d41-c018-582b-718254b55aa4@suse.com>
 <f77ed15f-3dfe-e4f4-2790-7eca18ca9dfe@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f77ed15f-3dfe-e4f4-2790-7eca18ca9dfe@citrix.com>
X-ClientProxiedBy: LO2P123CA0101.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:139::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 53a806d4-3c5c-4b9d-ca31-08da28374c99
X-MS-TrafficTypeDiagnostic: CY4PR03MB3125:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<CY4PR03MB31254DE247893B9E0EACE9EF8FFA9@CY4PR03MB3125.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/zX6WDQtZgd40x4nmojyyqt5NSGsF89ZEsxKjF15z3vURSILjJ0IpJ05BRSpWcxAN7Yag5CPR8MHeRRILlxxQxhRXKKvMs95Jnp/TBp/F8/0zEcti4ww6HNs8hlIsXqgyQYFRopedum0C7KrLkfYxl/AYbouHUcYIhoW2w33Ivf/sxv4vkFpjiLI5QIl1P1YV0idjHG1XM3eG3XRyr1xdrvOrgEybQakAlqa9Fb1WI9NLaic3UdIT/xfuEYx41wEhhfrtdx4gVeoY4X0yQKWsWGZs0jbUQwXEBWw78MYMSOvtizSJk0AxVFwgT3azkDSFND5NolGTs/mGWPyc5fN+zh7GtFejnZ3oZsUSMQ0nZGqfBgs2V+06FcOhB+75Y8xQSfkXiqEcLc2KBx8JBJkxo1I5afFN3KdsD9V2pqL7anu+Qy8ArgsYW/orKpeU1wYsQuTPKkbBy1vP7PbR0IjHrkVp4gYJYxQFMEarVw+hSleZ6bUZ6apJOjX9GoWgWqe8tq1XfkSeKZcjc/WLbTdiO+qb3KnKuJfl+VvFMyyuOyIbUR/IlpT4Bnrk0H+2JEiXseUNYLxkSF18/7hjnXnHH/k9VGvAVAF8H4HkUZcaNMnX83H+FZlxqrp5l+W3Q09RwsEr/9NkrYlG67nFaPLZAnmnKR3h5vfGtHCDS+GYbw7gOaqCuM5NOQ8YRBtdrSd1cXc9GNwbCLEtvaHxHtNqA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(83380400001)(186003)(6506007)(53546011)(86362001)(508600001)(85182001)(5660300002)(8936002)(2906002)(33716001)(26005)(4326008)(66476007)(82960400001)(54906003)(6636002)(9686003)(6512007)(8676002)(66946007)(6862004)(66556008)(3480700007)(316002)(6666004)(6486002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WHc0cHJWUzQ2bmNoakNlQ2hUY0o1anVNK2plZXBVaWxIRVJqTlg5b292My9z?=
 =?utf-8?B?WjBzOFFCQzBOQkY1WXhSeFNNODAwM0x6R2VQeVprdVBHeFVQWjB2Mk9xR25C?=
 =?utf-8?B?bFVHUVZCLytrTVlVeFUzZG10QW5NaU9jNnd6TWdXQWo5a3hVOWN0YjhQeGJz?=
 =?utf-8?B?TVpSUWhDVzVKcHBVZGdBRmVzQ3RueU1RdThLYmYvK0ExdVVEYTM3M2txaE9r?=
 =?utf-8?B?ZkdhOHVnVlAxbXNjTFpFZkdURUNhU0JqTmFqWkJTOGlJYk9EOFVPb0JRcXVE?=
 =?utf-8?B?OVk3c0RmZVZFWndTdjBpWUoxbTlzRmZBb1NaV0ZhNlFhNHduUXBsQXkvWko5?=
 =?utf-8?B?Y3RqcHN1aWVGblpvVlB4bzYwTVZhWXllY1NMK08yU2lkbWs3SnRBb2R2K0FL?=
 =?utf-8?B?bzdFNjhyZjNYeTNESzNIOXpXblZyZ3ZuQXhQZEJRSzd0dytsYklRMmloTFIz?=
 =?utf-8?B?eUkvNlFsV3MzSWl3aUYvaHk2a2FnNFYyMWpDT1BuWm1uaEYrclJibkVwMFpI?=
 =?utf-8?B?VnZhTllSSEFhRzdhL3VxWmZ4UWlveVhQNm96RUpXU3ZaWXpvWmJVYWtaeGIx?=
 =?utf-8?B?bHlkem14ekp3L1huaGs3NytWVlpZbnNkYXA3anpRUS90ek16cXVtcThyaEdw?=
 =?utf-8?B?a3RieWZYV2NpRFZQZCtEZTFpKy9Cb1ZJV0FWVnp1cW1RbUhaU1U3RkJtenQ4?=
 =?utf-8?B?cXhjT3VoMGpraGNRK3JZWDFqbUtncGRhSWZjVjJCV0VPMTB0aTJta2tQeCtj?=
 =?utf-8?B?N1FpdVdWUllBSW9aUDU5VlBlVDUrTk1ob1UwNHR2THY1bm9DeUR6WXlIUmYv?=
 =?utf-8?B?WHVTQlg5WWplMyt2aExhT3pwRlJaWFVOTEQ3eDdWZitkanBOTk1tU2lVY2NE?=
 =?utf-8?B?NFpoVitBc2R5RllzM0J1TkcvOUlsaE1mTk13TGt5OUoxS25xTGxreHFnQlVt?=
 =?utf-8?B?dEZJS3VneEJaYWRQek5tS1lJNzU5aDlBalJqb04vcjdFZ21FVU96cWxLWUMr?=
 =?utf-8?B?bERUU2FJRUVVaFRMdHJvQm1wMi9xVkpBR2ZlS2ZzeXYxNmNNcmJRSk03RW8x?=
 =?utf-8?B?SGJjQytGODV0NUZkbFZBL3hjWkJrLzIyWHpjaitMeGpPbkc3UkgwMnNIN3BM?=
 =?utf-8?B?K2ZKcDlyWXh3R2JYODEwZUNMYlZzWEZLeUpZbVhTT0JLM3dVSTB1WXd4MWxB?=
 =?utf-8?B?Sjg3c0VxeTZaazNTNUZlVFJlamVSRUZKNUx3NjkyUFVTaURlWGJjQStKbk9Z?=
 =?utf-8?B?T3NZdzdUblpoZ29aZXlKWVgvY0xyS29YZ0pLWnUzMi9BTm5DUFBTaEdOTmJL?=
 =?utf-8?B?dkNZUUdRSTNUQWN5am44dEJBQ0tDWSs2OFJpQVcydHlHRjF1U0h4RHJRS0FM?=
 =?utf-8?B?TCtrcE9qSHQvR0FVTTVPWHBTS2ZXdGxxOFJQRmJ4NElQMTY4SW4zenJ2d1ho?=
 =?utf-8?B?VHNsR3Nia0cwUTZTQ3hzY2RXcmw0aVhhcE1yaExGRXR0MHQ1UmVIKytycURm?=
 =?utf-8?B?R0hKS1BsT3hzbXVQT01vaUljNHZkNytjWmpjU0tJT1JoZjZQdnMwKzJoSlRQ?=
 =?utf-8?B?MjRwdE5JMnkycnRnMnJqRmZrcDVnZTEyejVieCtCeEZPTjNLT1IwYUZHMldy?=
 =?utf-8?B?aE0wUUNwcVlocVZFTHVHUG1sRHBGd0hudEJ5VGxVdHlJRk1OVmd2cXNjUzcv?=
 =?utf-8?B?eXNUa2RqQWl2UWlwZUg0K2tCZWtmL1BxY2tHVWt0Q1c5S1dvVnBFdzlZSGdC?=
 =?utf-8?B?TFZHWkpBTU1KZy81aDlXc0NVOEphT25uRGlqVGJ5dVd1Z3Y3Mjh3WkRHbVBK?=
 =?utf-8?B?OVdqNTNlOCtLU3cwUjdRSWNrdFdRMWQxZDhsVTlPRVNjRC9MSzJ2VzdIRHIw?=
 =?utf-8?B?Tmd4Zm5IbTlGb1VSVm9xclRHUGQ4ZHZmK3A0NlNrSzk1dTFZU0pKZ21TZXk1?=
 =?utf-8?B?VmdqREFUYlAzRm9McDh4c0VFUGM2d3BnVnB2c1FGVWNweUtRSWNtMXk0S1ZB?=
 =?utf-8?B?S0E5UFJSMnBjaGVuak9QV2d4Q0EwTWt4TkxxRUVPWStJUGY0NVZZd1hGOU5z?=
 =?utf-8?B?cStVL3ZUM2lEY2ZNMlZ4VWdoa2FoK25RZUJtdVA3YzhnekE2Rk52Sk1COHNS?=
 =?utf-8?B?UTZGZng2RXVraFhTZnB0WjRmSTB6T0xaRSt6a0NmSFRhSDZETVI3UWF1WEh3?=
 =?utf-8?B?dVlVRHpicVloTHViam1CeWVhOVFJa1cwOGhoTy9xY3F1aEhZTHNEVzZxb3gv?=
 =?utf-8?B?dDF6ajhNcHBhWjY3Zlg5SjdBU3pLODNPZ0FaeEhwdVFKR1IvS24vdytabWJq?=
 =?utf-8?B?T2gyOGMxOWZyYU9FM1JzczdKTjF3dHZib2ZFaXo2OEl3YkN0VldITzBaMFlm?=
 =?utf-8?Q?4rvED2x+aGXQr5XM=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53a806d4-3c5c-4b9d-ca31-08da28374c99
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:18:40.1055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9T4wBi9g15l21iO8+f2CX3uC4R2YVdFBJ3hFMzB+QENioTUVzCMEkc/NVK643Pf7Ksq4R2522hSTS2y/3P2c+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3125

On Wed, Apr 27, 2022 at 10:05:54AM +0000, Andrew Cooper wrote:
> On 27/04/2022 07:59, Jan Beulich wrote:
> > On 26.04.2022 19:51, Andrew Cooper wrote:
> >> Hello,
> >>
> >> Edvin has found a machine with some very weird properties.  It is an HP
> >> ProLiant BL460c Gen8 with:
> >>
> >>  \-[0000:00]-+-00.0  Intel Corporation Xeon E5/Core i7 DMI2
> >>              +-01.0-[11]--
> >>              +-01.1-[02]--
> >>              +-02.0-[04]--+-00.0  Emulex Corporation OneConnect 10Gb NIC
> >> (be3)
> >>              |            +-00.1  Emulex Corporation OneConnect 10Gb NIC
> >> (be3)
> >>              |            +-00.2  Emulex Corporation OneConnect 10Gb
> >> iSCSI Initiator (be3)
> >>              |            \-00.3  Emulex Corporation OneConnect 10Gb
> >> iSCSI Initiator (be3)
> >>
> >> yet all 4 other functions on the device periodically hit IOMMU faults
> >> (~once every 5 mins, so definitely stats).
> >>
> >> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.4] fault addr
> >> bdf80000
> >> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.5] fault addr
> >> bdf80000
> >> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.6] fault addr
> >> bdf80000
> >> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.7] fault addr
> >> bdf80000
> >>
> >> There are several RMRRs covering the these devices, with:
> >>
> >> (XEN) [VT-D]found ACPI_DMAR_RMRR:
> >> (XEN) [VT-D] endpoint: 0000:03:00.0
> >> (XEN) [VT-D] endpoint: 0000:01:00.0
> >> (XEN) [VT-D] endpoint: 0000:01:00.2
> >> (XEN) [VT-D] endpoint: 0000:04:00.0
> >> (XEN) [VT-D] endpoint: 0000:04:00.1
> >> (XEN) [VT-D] endpoint: 0000:04:00.2
> >> (XEN) [VT-D] endpoint: 0000:04:00.3
> >> (XEN) [VT-D]dmar.c:608:   RMRR region: base_addr bdf8f000 end_addr bdf92fff
> >>
> >> being the one relevant to these faults.  I've not manually decoded the
> >> DMAR table because device paths are horrible to follow but there are at
> >> least the correct number of endpoints.  The functions all have SR-IOV
> >> (disabled) and ARI (enabled).  None have any Phantom functions described.
> >>
> >> Specifying pci-phantom=04:00,1 does appear to work around the faults,
> >> but it's not right, because functions 1 thru 3 aren't actually phantom.
> > Indeed, and I think you really mean "pci-phantom=04:00,4".
> 
> As a quick tangent, the cmdline docs for pci-phantom= are in desperate
> need of an example and a description of how stride works.  I've got some
> ideas and notes jotted down.
> 
> Do we really mean ,4 here?  What happens for function 1?
> 
> > I guess we
> > should actually refuse "pci-phantom=04:00,1" in a case like this one.
> > The problem is that at the point we set pdev->phantom_stride we may
> > not know of the other devices, yet. But I guess we could attempt a
> > config space read of the supposed phantom function's device/vendor
> > and do <whatever> if these aren't both 0xffff.
> 
> At a minimum, we ought to warn when it looks like something is wonky,
> but I wouldn't go as far as rejecting.
> 
> All of these options to work around firmware/system screwups are applied
> to an already-non-working system, and there is absolutely no guarantee
> that necessary fixes make any kind of logical sense.

AFAICT with stride = 1 Xen will treat functions 1-7 as phantom
functions depending from function 0, which means the pdev struct won't
get updated when those phantom functions are assigned to a domain as
part of assigning function 0.  That would imply that functions 1 to 3
will be considered phantom but would also have a matching pdev that
allows them to be independently assigned to a domain, nothing good
will came out of it.

I agree with Jan that we need to explicitly reject strides that cover
functions that would otherwise be considered devices (ie: have valid
config space entries).  Or alternatively we need to remove the pdevs
for those functions now considered phantom.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:20:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:20:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314817.533055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njemP-0005W6-Ps; Wed, 27 Apr 2022 10:20:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314817.533055; Wed, 27 Apr 2022 10:20:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njemP-0005Vz-Md; Wed, 27 Apr 2022 10:20:17 +0000
Received: by outflank-mailman (input) for mailman id 314817;
 Wed, 27 Apr 2022 10:20:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ksbQ=VF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njemO-0005Vt-HX
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:20:16 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2060f.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::60f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a0d17f4d-c613-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 12:20:14 +0200 (CEST)
Received: from AM6PR08CA0024.eurprd08.prod.outlook.com (2603:10a6:20b:b2::36)
 by AM4PR0802MB2148.eurprd08.prod.outlook.com (2603:10a6:200:5c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 27 Apr
 2022 10:20:12 +0000
Received: from AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::34) by AM6PR08CA0024.outlook.office365.com
 (2603:10a6:20b:b2::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend
 Transport; Wed, 27 Apr 2022 10:20:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT056.mail.protection.outlook.com (10.152.17.224) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 10:20:12 +0000
Received: ("Tessian outbound 78191104f1b7:v118");
 Wed, 27 Apr 2022 10:20:11 +0000
Received: from a2528813ef94.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 01FF046E-D387-40C5-A665-A6F69F14045B.1; 
 Wed, 27 Apr 2022 10:20:01 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a2528813ef94.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 10:20:01 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by AM5PR0802MB2545.eurprd08.prod.outlook.com (2603:10a6:203:a2::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 10:19:58 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%9]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:19:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0d17f4d-c613-11ec-8fc2-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=HfonyERqP8mwV+NGWFPMrW/ZlAnyRpavMMSp6lgd1l1rUJDLJ8MPcQHoI/KsOZ8Iu+vJchkx9ve9UmHSc3if4d74i8RJghqKkWVjgLNyIBHH/2vKGWweoTqg6cxeBDE8dO9/cCC0F1jMmNhtEwDBCTh1CAytUdBvMm1pWvDwFtmewoafQ+kU2/dTBH1+LweuITodCU74pdF50iIx4RYD3tE74+EwA01Tei/PfLStaGDOdBoli3nao+5x2N7aEdR6XcQ+LWb/S2jTSravbawkrT3LbEJYfImm1cIXUDihykzzFOzLmXBid69InAqtyHjq14ry1mc8cJsJkyl2969/vQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZIVys0Ko2yB62h5Lv29829teqGadVMHuVqXj9DPbCpM=;
 b=Uy6yst1yAbTWGqKvwmNqfI72fwmWwH1MUDHMZgXPdCfaYoppYoMJRpC9AT8tzxZYxjRq0C3obLHPr4Rp6TCCsCfkNXctR01QIqZh2IgSsM4YAH+ySsafwi3H5Hfr8/KAvBIwlsmoO+2WJYfIigIJtzgxIn1LgaoSSlkkGmdaTYZlFi0pS4OCD86vHo8it4UoeAOaEy9qVct973N+YDwCYc6EfLeLrE/cL2+MITGVxdUeeiFQqceBeYNhRS0mActlJqtFjtNo4gKXxPR4icPagtTz2MbdqBjbAp/3dFeWBmdt4GbYsqVPy6qyhWu7OUc0A0evevVzTR1hbby3GHI8Xw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZIVys0Ko2yB62h5Lv29829teqGadVMHuVqXj9DPbCpM=;
 b=B1EyIYKbCcJKjJcm7U3SKENzkDDOIctgIgK/8L2f/CL9vSc3byV66tPCdIe00lGq9XmgRu9Vx/7bwxgcVxsbeJKu6+9MI4RcGsdLoyFN4j8CNI0OJsaRpU77pFNXUXclpp5aMYLTL9FGpdooAHvmn62JfWL6Gf4wXx69iCUgfvQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YMWWvYQJU7l3o4Z7ZyFZJEu5P31faqie/hzgDgqCtAs70Vll52phMu+yVScmw0ESFyuPYq6Z2SG2Sg4NMPUfisMMY7k1cJpNmB9ir/1KmyfxYtM9p+IHwPvS6E8Za5L+tpPF1KljfgLYDK3qJhATixORw8MgWonqAbisJwSczSwFRZdRd4Somj03HSe8GcWqkbFYKXgS4rSsB9Ak2eEZAScSKD1QmO2GAKKTU1Dj+zrvHOXROkbYG61BfjOo3iZStOXKUXjHgwAuXcmOdFCWGfkQ/YwnlIlojsBtTKc+2tMlJ3KxdEEcFaW83MP7+gVVHReTRQXufFsz9TpjPP/0Aw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZIVys0Ko2yB62h5Lv29829teqGadVMHuVqXj9DPbCpM=;
 b=OdmM1QOqA+lJXHj/wt7iI7NXTVf66IL9iUSDZf3gLRpTmPy22VDRUvCGqG8mLFkYkoOHUEbPn8QfdWQ90phFdgmKr8OZxtOJVjLuiLIDxhBWocOKdoYq+0mI3+HfNW4pUPE4B/hpOg9Ih1Y3ZbkOR0K636VozPwEPUN7QUbIsGRD4tMri8Qyn7n0LwQkB3ye/ToFUS+FAemzWtGFSC7O6fPD5g0Sl5ZQrvxjXoIyhBg0retUwtHzaVApdLNvDGOMJiVk3lDUHRtONhxEXRGwgIZfvxgBxtMMG2Vn/75jx9BZRjdWVmMBbSftLcXR8joJ6ThOz55ApALayhr77VTqVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZIVys0Ko2yB62h5Lv29829teqGadVMHuVqXj9DPbCpM=;
 b=B1EyIYKbCcJKjJcm7U3SKENzkDDOIctgIgK/8L2f/CL9vSc3byV66tPCdIe00lGq9XmgRu9Vx/7bwxgcVxsbeJKu6+9MI4RcGsdLoyFN4j8CNI0OJsaRpU77pFNXUXclpp5aMYLTL9FGpdooAHvmn62JfWL6Gf4wXx69iCUgfvQ=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>
Subject: RE: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
Thread-Topic: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
Thread-Index: AQHYWhk9pvmpyYf9yk6PCG0TATWN+q0DifWAgAAAvZA=
Date: Wed, 27 Apr 2022 10:19:58 +0000
Message-ID:
 <DU2PR08MB73250D118F81DF1FF2C89DAFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
 <20220427092743.925563-6-Penny.Zheng@arm.com>
 <95b1d82e-92fa-7468-d3aa-038f0de937d9@xen.org>
In-Reply-To: <95b1d82e-92fa-7468-d3aa-038f0de937d9@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 041C02CBE2E6764894F8FB6A94070653.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: bc195353-c75a-4d77-f30d-08da2837838e
x-ms-traffictypediagnostic:
	AM5PR0802MB2545:EE_|AM5EUR03FT056:EE_|AM4PR0802MB2148:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR0802MB2148C7D95D70DA30ED60CE0BF7FA9@AM4PR0802MB2148.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 VCXDpr1eQZkzFyo9AsHrC9cOZb6m1wzu1ElZaJBp11PeCTjTW445/ggWRYzSw8uC0R1wP+545AWSxRwPm5oafynQw3LDThxfYa3GN+7XTPKel3f/K4xd8qLX7u2mfYOeXjli9OpQM5xDPkfuA9hICUwHA2kqufOKsDhRVDNKh2JhJtueSe50HZnX1ssUplnd/9CQcZF903aK4uJvgcllZ8DouqHR0BlOJEYRQMAQ2w4b0sZmE0207DbkkEz2J6F4wo0qXC0rXIjL7fhyDkKz8Fn2zvVFR0dylRaI+2t4sJQfWkwkIrHClTjgBUHrS7tAHWOEQR7fl1lm4qrdtt9vXjnycng5t7QJGkvpXpMyaZwPEC9Ue3h8nGXaGp62FKkrtum/DgYEHNoAJy9x7BQ/uBlWEsVWj5QSnBaBWJHgSjBZDKf3LmdYfVHZfEMjEnK4pFDJNzBF9ohBng9H3XBKiDuk1AUQ1TOZ+GwYURGOx8yLFTsirt2X3yy6RNuuX/MVdePQJkTWe9GPCkJtPpNdOm0x4g0GcedhFCWDtwx3Ysud8QjzNJeHA0vqYmhh+tJEivD9u/+AMvTQcS+gUtL2WIi7uhrnsVVff8dJ7xWavnQzTL+di6WX4NAVvPpUnIOJnbYyUC7FQXbxr0Mq0pUOrbQ+I2zmOnjRPiShf2TzrPy31jNLxKnVe4rY4QCT4689DOUshNYWXQaLf2mRQTP1mQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(26005)(508600001)(83380400001)(33656002)(38070700005)(76116006)(55016003)(66476007)(54906003)(122000001)(86362001)(316002)(9686003)(64756008)(8676002)(4326008)(66556008)(66946007)(66446008)(53546011)(110136005)(38100700002)(7696005)(5660300002)(52536014)(186003)(8936002)(2906002)(6506007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2545
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ebc437c3-2714-4cf9-4a06-08da28377b72
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9ZUtYyKrTfoEyHpz2F3bMSlJryFZRXxJ8yKW85v3v5TT/1YVGj3qPJOqybr4d7ZiRN1jmvvNhUz5aAu6BgFLTrKe2IpKZjbM/4cebt3EhEzEaWfqLk3XjkLYiMSZf6cDsSrlKvjuosnZc3jWkEHnH9doZwjgqqsAZYpwiy8aFFgmgUcx9UvksyWU776NrJxDuAXICzQQOgVDAtoZmHLqOL0YZqRyAMvA9zvl7v1ycmJrAdR4bn8VeRRhrTBPitOuwj03NhwG5pIkQQwOtyokNN+8/dp2bG0zL9dkt35UHNsyS3HPxP6/EGYDYB2WLhxyx8BN74qriIi0XmSLADSWs9d1ZBdQ0e2Kg1ZYg44DmOGd+/ueVu3e8nrArPFSWsDur0Ejbb17jtMRTBIdLet11fJwzok/B5EjXdXSjvw7+uI5PvDjDL+70V+tw3bvNLOYyBVuC1lLl7rNum/v7LCcGmViqxE4gUgJhC4vdgITc3zUVngNfZmq+/oGqitJJC79zfI8SG+GOtPANeyrFii9mMxNdlJ7AITIKFD06+T5EYJezxUuWFovapx0Yb7RsbEN0CpgLQCifA9OI5Za8SlQB41x7VydIU1SM59hj+t0TUBsWeTkTb7jUkpqG20zmU2A2fIi3d4VlQ4s1TZqVlZHOCPJtXV/wSZvX5N/q813TySTB38S8xgseTculb59wVCn
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(110136005)(81166007)(356005)(316002)(40460700003)(70586007)(54906003)(55016003)(508600001)(7696005)(86362001)(83380400001)(186003)(53546011)(6506007)(5660300002)(36860700001)(82310400005)(33656002)(52536014)(2906002)(26005)(9686003)(8676002)(47076005)(336012)(4326008)(70206006)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:20:12.1217
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bc195353-c75a-4d77-f30d-08da2837838e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2148

SGkganVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogV2VkbmVzZGF5LCBBcHJpbCAyNywgMjAy
MiA2OjExIFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1k
ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5j
b20+OyBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+Ow0KPiBTdGVmYW5vIFN0YWJlbGxp
bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0cmFu
ZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFiY2h1aw0KPiA8Vm9sb2R5bXlyX0JhYmNo
dWtAZXBhbS5jb20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t
PjsgR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsNCj4gSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPjsgV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4gU3ViamVjdDog
UmU6IFtQQVRDSCB2MyA1LzZdIHhlbi9hcm06IHVucG9wdWxhdGUgbWVtb3J5IHdoZW4gZG9tYWlu
IGlzDQo+IHN0YXRpYw0KPiANCj4gSGkgUGVubnksDQo+IA0KPiBPbiAyNy8wNC8yMDIyIDEwOjI3
LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBUb2RheSB3aGVuIGEgZG9tYWluIHVucG9wdWxhdGVz
IHRoZSBtZW1vcnkgb24gcnVudGltZSwgdGhleSB3aWxsDQo+ID4gYWx3YXlzIGhhbmQgdGhlIG1l
bW9yeSBiYWNrIHRvIHRoZSBoZWFwIGFsbG9jYXRvci4gQW5kIGl0IHdpbGwgYmUgYQ0KPiA+IHBy
b2JsZW0gaWYgZG9tYWluIGlzIHN0YXRpYy4NCj4gPg0KPiA+IFBhZ2VzIGFzIGd1ZXN0IFJBTSBm
b3Igc3RhdGljIGRvbWFpbiBzaGFsbCBiZSByZXNlcnZlZCB0byBvbmx5IHRoaXMNCj4gPiBkb21h
aW4gYW5kIG5vdCBiZSB1c2VkIGZvciBhbnkgb3RoZXIgcHVycG9zZXMsIHNvIHRoZXkgc2hhbGwg
bmV2ZXIgZ28NCj4gPiBiYWNrIHRvIGhlYXAgYWxsb2NhdG9yLg0KPiA+DQo+ID4gVGhpcyBjb21t
aXQgcHV0cyByZXNlcnZlZCBwYWdlcyBvbiB0aGUgbmV3IGxpc3QgcmVzdl9wYWdlX2xpc3Qgb25s
eQ0KPiA+IGFmdGVyIGhhdmluZyB0YWtlbiB0aGVtIG9mZiB0aGUgIm5vcm1hbCIgbGlzdCwgd2hl
biB0aGUgbGFzdCByZWYgZHJvcHBlZC4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpo
ZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+IHYzIGNoYW5nZXM6DQo+ID4g
LSBoYXZlIHBhZ2VfbGlzdF9kZWwoKSBqdXN0IG9uY2Ugb3V0IG9mIHRoZSBpZigpDQo+ID4gLSBy
ZW1vdmUgcmVzdl9wYWdlcyBjb3VudGVyDQo+ID4gLSBtYWtlIGFyY2hfZnJlZV9oZWFwX3BhZ2Ug
YmUgYW4gZXhwcmVzc2lvbiwgbm90IGEgY29tcG91bmQgc3RhdGVtZW50Lg0KPiA+IC0tLQ0KPiA+
IHYyIGNoYW5nZXM6DQo+ID4gLSBwdXQgcmVzZXJ2ZWQgcGFnZXMgb24gcmVzdl9wYWdlX2xpc3Qg
YWZ0ZXIgaGF2aW5nIHRha2VuIHRoZW0gb2ZmIHRoZQ0KPiA+ICJub3JtYWwiIGxpc3QNCj4gPiAt
LS0NCj4gPiAgIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9tbS5oIHwgMTIgKysrKysrKysrKysr
DQo+ID4gICB4ZW4vY29tbW9uL2RvbWFpbi5jICAgICAgICAgICB8ICA0ICsrKysNCj4gPiAgIHhl
bi9pbmNsdWRlL3hlbi9zY2hlZC5oICAgICAgIHwgIDMgKysrDQo+ID4gICAzIGZpbGVzIGNoYW5n
ZWQsIDE5IGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v
aW5jbHVkZS9hc20vbW0uaA0KPiA+IGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL21tLmggaW5k
ZXggNDI0YWFmMjgyMy4uYzY0MjZjMTcwNSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0v
aW5jbHVkZS9hc20vbW0uaA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9tbS5o
DQo+ID4gQEAgLTM1OCw2ICszNTgsMTggQEAgdm9pZCBjbGVhcl9hbmRfY2xlYW5fcGFnZShzdHJ1
Y3QgcGFnZV9pbmZvDQo+ID4gKnBhZ2UpOw0KPiA+DQo+ID4gICB1bnNpZ25lZCBpbnQgYXJjaF9n
ZXRfZG1hX2JpdHNpemUodm9pZCk7DQo+ID4NCj4gPiArLyoNCj4gPiArICogUHV0IGZyZWUgcGFn
ZXMgb24gdGhlIHJlc3YgcGFnZSBsaXN0IGFmdGVyIGhhdmluZyB0YWtlbiB0aGVtDQo+ID4gKyAq
IG9mZiB0aGUgIm5vcm1hbCIgcGFnZSBsaXN0LCB3aGVuIHBhZ2VzIGZyb20gc3RhdGljIG1lbW9y
eSAgKi8NCj4gPiArI2lmZGVmIENPTkZJR19TVEFUSUNfTUVNT1JZDQo+ID4gKyNkZWZpbmUgYXJj
aF9mcmVlX2hlYXBfcGFnZShkLCBwZykgKHsgICAgICAgICAgICAgICAgICAgXA0KPiA+ICsgICAg
cGFnZV9saXN0X2RlbChwZywgcGFnZV90b19saXN0KGQsIHBnKSk7ICAgICAgICAgICAgIFwNCj4g
PiArICAgIGlmICggKHBnKS0+Y291bnRfaW5mbyAmIFBHQ19yZXNlcnZlZCApICAgICAgICAgICAg
ICBcDQo+ID4gKyAgICAgICAgcGFnZV9saXN0X2FkZF90YWlsKHBnLCAmKGQpLT5yZXN2X3BhZ2Vf
bGlzdCk7ICAgXA0KPiA+ICt9KQ0KPiA+ICsjZW5kaWYNCj4gDQo+IEkgYW0gYSBiaXQgcHV6emxl
ZCBob3cgdGhpcyBpcyBtZWFudCB0byB3b3JrLg0KPiANCj4gTG9va2luZyBhdCB0aGUgY29kZSwg
YXJjaF9mcmVlX2hlYXBfcGFnZSgpIHdpbGwgYmUgY2FsbGVkIGZyb20NCj4gZnJlZV9kb21oZWFw
X3BhZ2VzKCkuIElmIEkgYW0gbm90IG1pc3Rha2VuLCByZXNlcnZlZCBwYWdlcyBhcmUgbm90DQo+
IGNvbnNpZGVyZWQgYXMgeGVuIGhlYXAgcGFnZXMsIHNvIHdlIHdvdWxkIGdvIGluIHRoZSBlbHNl
IHdoaWNoIHdpbGwgZW5kIHVwIHRvDQo+IGNhbGwgZnJlZV9oZWFwX3BhZ2VzKCkuDQo+IA0KPiBm
cmVlX2hlYXBfcGFnZXMoKSB3aWxsIGVuZCB1cCB0byBhZGQgdGhlIHBhZ2UgaW4gdGhlIGhlYXAg
YWxsb2NhdG9yIGFuZA0KPiBjb3JydXB0IHRoZSBkLT5yZXN2X3BhZ2VfbGlzdCBiZWNhdXNlIHRo
ZXJlIGFyZSBvbmx5IG9uZSBsaW5rIGxpc3QuDQo+IA0KPiBXaGF0IGRpZCBJIG1pc3M/DQo+IA0K
DQpJbiBteSBmaXJzdCBjb21taXQgImRvIG5vdCBmcmVlIHJlc2VydmVkIG1lbW9yeSBpbnRvIGhl
YXAiLCBJJ3ZlIGNoYW5nZWQgdGhlIGJlaGF2aW9yDQpmb3IgcmVzZXJ2ZWQgcGFnZXMgaW4gZnJl
ZV9oZWFwX3BhZ2VzKCkNCisgICAgaWYgKCBwZy0+Y291bnRfaW5mbyAmIFBHQ19yZXNlcnZlZCAp
DQorICAgICAgICAvKiBSZXNlcnZlZCBwYWdlIHNoYWxsIG5vdCBnbyBiYWNrIHRvIHRoZSBoZWFw
LiAqLw0KKyAgICAgICAgcmV0dXJuIGZyZWVfc3RhdGljbWVtX3BhZ2VzKHBnLCAxVUwgPDwgb3Jk
ZXIsIG5lZWRfc2NydWIpOw0KKw0KDQo+IENoZWVycywNCj4NCj4gLS0NCj4gSnVsaWVuIEdyYWxs
DQoNCkNoZWVycywNCg0KLS0NClBlbm55IFpoZW5nDQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:20:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:20:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314818.533065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njemW-0005nz-2J; Wed, 27 Apr 2022 10:20:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314818.533065; Wed, 27 Apr 2022 10:20:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njemV-0005nq-Ur; Wed, 27 Apr 2022 10:20:23 +0000
Received: by outflank-mailman (input) for mailman id 314818;
 Wed, 27 Apr 2022 10:20:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njemU-0005nI-BS
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:20:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a4983544-c613-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 12:20:21 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-eVWiP18JPtOdnUeTVHGJ4Q-1; Wed, 27 Apr 2022 12:20:19 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB7PR04MB4345.eurprd04.prod.outlook.com (2603:10a6:5:25::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 10:20:17 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 10:20:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4983544-c613-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651054820;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oFcAJJD7wZUtZ3smuXsQeyj7/hBvpybWVkJBpPSY8PQ=;
	b=FKnb1fzadFpkVCbJwupA59+7z1eMXGL9XF7l1JTYMsGcJFEDsQxJ5LU/FrpTRQ7VPcj1st
	I4/xsR4fg45tb5V1ovxaGPRADcZRC07rWIt5Yc6HjUGK/RG8QLLQ3eTf4BqHc0BkIPRKSd
	X2qGjXaM4Pw23neuuzC+gMm+ceYHXWw=
X-MC-Unique: eVWiP18JPtOdnUeTVHGJ4Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UBY8qcI1Z5Xk7YtnKYu+2TWqk/ioJRH/qOvTN/XrS/wpFwzsB43eVeHfiJTb7tcIKkOxqgc4ZTMm8Zbm8EkBcdnP1DhyyWaRh7I6flTk+QRlIowHE0FSYk1wpbQg6WoEz1VObsGPVEnVciQOWIFk6Rk40NnY6fdDka7F/DJxc4as1O/GdpL09m6JanNpc3Uo4b6IIL3ofLMeU0y5lN8tFI6fsOw7mIY6KX9Db6QWmAhmWFplg2gkMRgYJU6t/sXAfa6p7Cu63+KC7x3fO35e/kEiOvelCzKWIZeECzMNWPyekXgyN1uhrjkI+YwqMesJS8c4IpmLz4Mg9o80Z17lzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jbQKfysjlsQbCx8NstU6XjoUwqPZYVhthJIJrWJvnH0=;
 b=YWdMMc0nZKAVNarB/Nm1miUMBNsBO+A+DmhvKiUYOKwJSUpn26qZtOkFeJx3JGpVNFW/tfKFVm9j8SuajOSmHBlS7oPG1tmnfI3Qub4IT3ze05v0btjX+0iv/eof+mM5LjNW88B7ASSQahCgtiwBCsarnq2ncmWAk8ckZf8sFQtBLOIxJ8Nvh3TOUK9z45hhV94AwTqUEX4ijrg1HgHh65xCGQba8ulDd89zp8L4cJVSBP1gUmq9HgebA4rAjEZhklMG1ONZ+mM5OzFflWVZ/bdIGffJdHmKKJ9gAeunwMWIdEua/zsmYE0whe7kAHeG1+RBIj1TkR2iOOKRypAo6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cf90610c-cf86-2d67-c069-63315ce1dabb@suse.com>
Date: Wed, 27 Apr 2022 12:20:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: RMRRs and Phantom Functions
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Kevin Tian
 <kevin.tian@intel.com>, Edwin Torok <edvin.torok@citrix.com>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
 <ec1efb6f-9d41-c018-582b-718254b55aa4@suse.com>
 <f77ed15f-3dfe-e4f4-2790-7eca18ca9dfe@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f77ed15f-3dfe-e4f4-2790-7eca18ca9dfe@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0044.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::35) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c9ddd710-d49f-465b-4c57-08da2837867f
X-MS-TrafficTypeDiagnostic: DB7PR04MB4345:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB43450179C437F67F581B9921B3FA9@DB7PR04MB4345.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oOD8ArH2/Qi2G7qt2SVHyHo9T4WlxXpBzdUenNXnIYIJ5Rws500KpiRCKtxXX4HYBxUZKOg3TQ2eDIXBJgVi74XKRs0vUqRK438rlGTE5K6HbLiu5LeES3uZNEnTDcP5/RCGe+pHfAzdG9XN8tiMf5H2tJly2108/ldp0llZIoWXSPTsJ6HuMVr9761575z4NTJEiYBf3kJqUHSj0UPsIlwu8K37Uq5XBpnpr0IG3qzegk/+XI0jv2Ff2027a3gSf4QgPceiSYJg1xlDoxhNHbhrlrQHwQjPKH/XRDiUcZt5F8E/Tn+OOjMfxbC+5Y0eJ59ma7hrJ0vUq4a10wSkktsTOOMvQWLJg5WXZ5inyYE3dhpoGfC5TK56WZkZ6k27xTbM3jfpJKAOGlJxBrlobDs21AATsd9k74kWFHxm5E5w5pu/9rwbgcdvJBE7RKZESKZxSdhbb7xWXHo5qWDD75xp9pTidwwfguiB9yOrldU8eYQ68XwBjNLOQSzy7pgTKjRpa0CElBNDuFWIS9cZK/QYfDkgbVzRpbfTxNvCg188ttbKQJAbKG5ULhYJU2fnmK9dICCIGWpP/AQP6PIwgy/tzli+hFeOYDsofcm/1g9OhMFeIBQuwpUEM5wlbKO9fVXeCpgpRnsIp3oI0THgcjel/KBQvfb3LC9WFkCuglPmXXcp5QbjnqmtEMQiOXJjjV6cj//ZxbTwefjXabwD43m4aSS8owa8dMPaBQOr0Gw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(2616005)(83380400001)(186003)(38100700002)(8676002)(66946007)(66556008)(66476007)(36756003)(31686004)(4326008)(508600001)(2906002)(3480700007)(6916009)(6512007)(5660300002)(54906003)(26005)(316002)(6506007)(8936002)(6486002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FD3y9mGA0zTmWzEipZnelG0tAa+yNaguqqnD6Q32nAfxaC7D3m3bIfFZCgRQ?=
 =?us-ascii?Q?Zen4uep87UxvF6OUt9WclqXRy7hKqd5IXxJY0b10ItYjSXuOYRdHD1Iyfoxq?=
 =?us-ascii?Q?fuW8mW3K+dnXWc0yhiSSDcPVwsbRcruEjL/OxkiSVXkFGTnxWScs/x3U2aeh?=
 =?us-ascii?Q?+4J3du46UjV4Ws/IlaiD/AXHo5MsXrPmoWcDlHqMZMUmbo+D43vpYD4JdH/I?=
 =?us-ascii?Q?wMpKfVKte7XlbFlR321fS9cFoQhnwlnC81wSYTSYJXCEq8XyMm5248yNMwlO?=
 =?us-ascii?Q?BGgRWGY0tEjqSSAfINU0HMDiEEHsnPTKt9SjQ4AkefzNysqPxPZWNpZwFCSB?=
 =?us-ascii?Q?l2l1jPLCmKyWqRh/7KYHR/lXAQI5CKwUBYJD3BOqOsUEOOgEFF33hsGyqEPj?=
 =?us-ascii?Q?vgxAUmyWDz31j0TlvbWG9H+nt2QkF6nYryVuzb9maFOI1YqBogvI6GbBJIEx?=
 =?us-ascii?Q?aHmrZHFIEE2Ei0siVy3LrV1TA8Vs/7N6y/1HJXQBoadDyTb+wQpFfEt8zHQj?=
 =?us-ascii?Q?Ixq2Fpwa2Hj2Ab07u0fEqIGMGFT2Um/xTy3y4m9ZxPe0mOla7o/CXRwjG74u?=
 =?us-ascii?Q?mV3alq9uo8w+gMpdG1KQNv7+Yk1R8cZ3XC6Tc84Q5MdUrG5y2lovc7riAxWW?=
 =?us-ascii?Q?5f9gzCHeV3g2KgDXuNXij6jaf9ngqFuhalnMwGdXDhxRG0RyZXbsJ6IbqVcZ?=
 =?us-ascii?Q?nJu3qhJkI7OPelRiwXbZsEVWVSaNS0exiXb+cWyQQN7YZ4KlsPR8Kp+11BIG?=
 =?us-ascii?Q?XSub7qhfPtK0Gs+j40uIE//UC9LOBXm5bo6SpW2/MgXbBxDU+ZDTEihe5XW3?=
 =?us-ascii?Q?vAPNDQiDWicOJUOQWYDDdBs3WU0LLwSkt21VSkImQngNMbRUWSpnvI0MKyyV?=
 =?us-ascii?Q?4oRrFjtI7VuImWNqLGNzKcDiKxFcivm+qQjJkDdC+BP1mRYUhxCilH934zfr?=
 =?us-ascii?Q?csVIUhZldo4wXMzI6VeGpRdlqQ3vjGTQ4LEIBcEDHb2myWlZoeoA8rEV8p6Z?=
 =?us-ascii?Q?7+bgVljl2KDjgq5bc/I8SgqG9iVt3DT3vAEbfpH5zOnoZCk2wmJlQomvu8c0?=
 =?us-ascii?Q?ftX6p0SJyQ6axHLLCdE7yQOaENd65Xd+bDyoYe4gnSgKVVQN6zcA3dnF2/33?=
 =?us-ascii?Q?M+77orfb0CHBUIlRtJ4S1dHLB/2amQcNuEUEB7ogu0Jm1QI3AEgDz0NFIo5u?=
 =?us-ascii?Q?R8onCvjaYjNCRvUbitl3uQZsS698USYqBg/ccmgUL3SC22o7oM7NYbaV0Ctw?=
 =?us-ascii?Q?vVBSP2HIRGu6Jdvnw7VsK+VJUbD61yK2BS2S9ZTgDOPadY8GnXgq8FYoxXN4?=
 =?us-ascii?Q?fTi9hMa2c0z7qqUXRCpCXIyerP5SaJ84K3VpLw3tXaibgkbTOeMUzg0Nlrr+?=
 =?us-ascii?Q?1ySOH1G0+x4rZi37EUAynHc+bZdmNLX70tokEa+COMsW0z5Fyl2c/S0yHwnf?=
 =?us-ascii?Q?7Mi+b3m4ItdULXCzelNSFpAqE30plqU/eVoPE37OE4CxUMW1RYQwKUBNsMC2?=
 =?us-ascii?Q?3o2KpmCtfif9bmyK54GFoq8Voqy2+Ru61GDBTzSKrAy1yOOBZ7qA3lD9UWQG?=
 =?us-ascii?Q?NIGkHcnoEwuXQpQxvIrDNCWi4SZWEvrxUS7i2nvHvSXfeyABKRhEA/ytmHz3?=
 =?us-ascii?Q?FAO85ERn+HknHpvrkOL+ls92WTRu/9ai/QXRGFuMjfi9j0CUFkyssWFi2G/E?=
 =?us-ascii?Q?p6Ww2oGpvDH5dDglk9EQH4n2lP98bD+QebyHVk0qHvvUn/WortWXYhOxOekQ?=
 =?us-ascii?Q?mCdjuKZxXw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9ddd710-d49f-465b-4c57-08da2837867f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:20:17.2241
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vcvEikoRCD5UbYi4g0KUAditOvAND7vFcKxuZcPAGTFJH0Aw4LuRidbdGuWgDvEppuuo4+dvVcfvEM1ERRK2+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4345

On 27.04.2022 12:05, Andrew Cooper wrote:
> On 27/04/2022 07:59, Jan Beulich wrote:
>> On 26.04.2022 19:51, Andrew Cooper wrote:
>>> Hello,
>>>
>>> Edvin has found a machine with some very weird properties.=C2=A0 It is =
an HP
>>> ProLiant BL460c Gen8 with:
>>>
>>> =C2=A0\-[0000:00]-+-00.0=C2=A0 Intel Corporation Xeon E5/Core i7 DMI2
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 +-01.0-[11]--
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 +-01.1-[02]--
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 +-02.0-[04]--+-00.0=C2=A0 Emulex Corporation OneConnect 10Gb NIC
>>> (be3)
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 +-0=
0.1=C2=A0 Emulex Corporation OneConnect 10Gb NIC
>>> (be3)
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 +-0=
0.2=C2=A0 Emulex Corporation OneConnect 10Gb
>>> iSCSI Initiator (be3)
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \-0=
0.3=C2=A0 Emulex Corporation OneConnect 10Gb
>>> iSCSI Initiator (be3)
>>>
>>> yet all 4 other functions on the device periodically hit IOMMU faults
>>> (~once every 5 mins, so definitely stats).
>>>
>>> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.4] fault addr
>>> bdf80000
>>> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.5] fault addr
>>> bdf80000
>>> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.6] fault addr
>>> bdf80000
>>> (XEN) [VT-D]DMAR:[DMA Write] Request device [0000:04:00.7] fault addr
>>> bdf80000
>>>
>>> There are several RMRRs covering the these devices, with:
>>>
>>> (XEN) [VT-D]found ACPI_DMAR_RMRR:
>>> (XEN) [VT-D] endpoint: 0000:03:00.0
>>> (XEN) [VT-D] endpoint: 0000:01:00.0
>>> (XEN) [VT-D] endpoint: 0000:01:00.2
>>> (XEN) [VT-D] endpoint: 0000:04:00.0
>>> (XEN) [VT-D] endpoint: 0000:04:00.1
>>> (XEN) [VT-D] endpoint: 0000:04:00.2
>>> (XEN) [VT-D] endpoint: 0000:04:00.3
>>> (XEN) [VT-D]dmar.c:608:=C2=A0=C2=A0 RMRR region: base_addr bdf8f000 end=
_addr bdf92fff
>>>
>>> being the one relevant to these faults.=C2=A0 I've not manually decoded=
 the
>>> DMAR table because device paths are horrible to follow but there are at
>>> least the correct number of endpoints.=C2=A0 The functions all have SR-=
IOV
>>> (disabled) and ARI (enabled).=C2=A0 None have any Phantom functions des=
cribed.
>>>
>>> Specifying pci-phantom=3D04:00,1 does appear to work around the faults,
>>> but it's not right, because functions 1 thru 3 aren't actually phantom.
>> Indeed, and I think you really mean "pci-phantom=3D04:00,4".
>=20
> As a quick tangent, the cmdline docs for pci-phantom=3D are in desperate
> need of an example and a description of how stride works.=C2=A0 I've got =
some
> ideas and notes jotted down.
>=20
> Do we really mean ,4 here?=C2=A0 What happens for function 1?

With stride 4 function 1's single phantom function is function 5. With
stride 1, as you had it before, functions 1...7 would all be considered
phantom functions of function 0.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:23:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:23:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314832.533076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njepW-0006qt-Mp; Wed, 27 Apr 2022 10:23:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314832.533076; Wed, 27 Apr 2022 10:23:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njepW-0006qm-Js; Wed, 27 Apr 2022 10:23:30 +0000
Received: by outflank-mailman (input) for mailman id 314832;
 Wed, 27 Apr 2022 10:23:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njepU-0006qg-PF
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:23:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njepU-0003Ed-8G; Wed, 27 Apr 2022 10:23:28 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njepU-0003Cz-21; Wed, 27 Apr 2022 10:23:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=yyH+NTdb5aFo6DqjZPL8BPt+tc+8CVzRwLJFZqn5viQ=; b=pWMggW8tLh4jG7tzm6nmjDhvw/
	NLE5kl/6k0gQB0EbOPtC/ASKlzyAEJDkqev2H4UNypLmZR+Dj/vgLwrVlngQ6lAV9h+CfU+n6SOaN
	AoahTZJyV3AaaRH1Z85fSvD/LASFXAFWinkh7QrGa0DYGqC/iGJ9Rjtcdhg2sLsxxe3k=;
Message-ID: <433f9e2a-9da7-662f-04b5-0379eca7496f@xen.org>
Date: Wed, 27 Apr 2022 11:23:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
To: Penny Zheng <Penny.Zheng@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
 <20220427092743.925563-6-Penny.Zheng@arm.com>
 <95b1d82e-92fa-7468-d3aa-038f0de937d9@xen.org>
 <DU2PR08MB73250D118F81DF1FF2C89DAFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <DU2PR08MB73250D118F81DF1FF2C89DAFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 27/04/2022 11:19, Penny Zheng wrote:
>>> +/*
>>> + * Put free pages on the resv page list after having taken them
>>> + * off the "normal" page list, when pages from static memory  */
>>> +#ifdef CONFIG_STATIC_MEMORY
>>> +#define arch_free_heap_page(d, pg) ({                   \
>>> +    page_list_del(pg, page_to_list(d, pg));             \
>>> +    if ( (pg)->count_info & PGC_reserved )              \
>>> +        page_list_add_tail(pg, &(d)->resv_page_list);   \
>>> +})
>>> +#endif
>>
>> I am a bit puzzled how this is meant to work.
>>
>> Looking at the code, arch_free_heap_page() will be called from
>> free_domheap_pages(). If I am not mistaken, reserved pages are not
>> considered as xen heap pages, so we would go in the else which will end up to
>> call free_heap_pages().
>>
>> free_heap_pages() will end up to add the page in the heap allocator and
>> corrupt the d->resv_page_list because there are only one link list.
>>
>> What did I miss?
>>
> 
> In my first commit "do not free reserved memory into heap", I've changed the behavior
> for reserved pages in free_heap_pages()
> +    if ( pg->count_info & PGC_reserved )
> +        /* Reserved page shall not go back to the heap. */
> +        return free_staticmem_pages(pg, 1UL << order, need_scrub);
> +

Hmmm... somehow this e-mail is neither in my inbox nor in the archives 
on lore.kernel.org.

Cheers,
-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:31:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:31:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314841.533088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njewz-0008In-Gq; Wed, 27 Apr 2022 10:31:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314841.533088; Wed, 27 Apr 2022 10:31:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njewz-0008Ig-DB; Wed, 27 Apr 2022 10:31:13 +0000
Received: by outflank-mailman (input) for mailman id 314841;
 Wed, 27 Apr 2022 10:31:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njewy-0008IW-Uo; Wed, 27 Apr 2022 10:31:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njewy-0003Ll-Rc; Wed, 27 Apr 2022 10:31:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njewy-0005KL-FV; Wed, 27 Apr 2022 10:31:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njewy-0006Z2-F4; Wed, 27 Apr 2022 10:31:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9dUOE4mgEqSz/y4zPcoMcBQJaQVjMKPDZjFKCTdLoL0=; b=1CFQxkmWZQCkDck3lYgL5vxWXP
	5iXJ/BR/0IM21RSAHB5UhXvsNH0aPPLFIhxGQbN01vdMFP41evOtTMtmtabdujoEV55zD8yI36JQ2
	x1HeY+H6NGSdIHy8aNWyHvf5J6Cb7X6vLT5AptlgKGM/LZDXW+4tqkeAqpdYzSAnkb90=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169762-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169762: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=a72d9008092e39c2c37e47a91bae4e170d0f1b33
X-Osstest-Versions-That:
    qemuu=80a172de5592b5c33aa6bc30da6f16c4ad1ae390
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 10:31:12 +0000

flight 169762 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169762/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169749

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169749
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169749
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169749
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169749
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169749
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169749
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169749
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169749
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                a72d9008092e39c2c37e47a91bae4e170d0f1b33
baseline version:
 qemuu                80a172de5592b5c33aa6bc30da6f16c4ad1ae390

Last test of basis   169749  2022-04-26 17:07:01 Z    0 days
Testing same since   169762  2022-04-27 01:08:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Amir Gonnen <amir.gonnen@neuroblade.ai>
  Daniel P. Berrangé <berrange@redhat.com>
  Eric Blake <eblake@redhat.com>
  John Snow <jsnow@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   80a172de55..a72d900809  a72d9008092e39c2c37e47a91bae4e170d0f1b33 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:32:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:32:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314847.533099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njexr-0000QN-TN; Wed, 27 Apr 2022 10:32:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314847.533099; Wed, 27 Apr 2022 10:32:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njexr-0000QG-Oc; Wed, 27 Apr 2022 10:32:07 +0000
Received: by outflank-mailman (input) for mailman id 314847;
 Wed, 27 Apr 2022 10:32:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ksbQ=VF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njexq-0000Ma-QS
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:32:07 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on0621.outbound.protection.outlook.com
 [2a01:111:f400:fe09::621])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4822cb55-c615-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 12:32:05 +0200 (CEST)
Received: from DB7PR05CA0071.eurprd05.prod.outlook.com (2603:10a6:10:2e::48)
 by HE1PR08MB2810.eurprd08.prod.outlook.com (2603:10a6:7:37::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Wed, 27 Apr
 2022 10:32:01 +0000
Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2e:cafe::92) by DB7PR05CA0071.outlook.office365.com
 (2603:10a6:10:2e::48) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend
 Transport; Wed, 27 Apr 2022 10:32:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 10:32:00 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Wed, 27 Apr 2022 10:32:00 +0000
Received: from 18b0e8e7a600.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 848905E9-CEA4-4FEF-A2BC-8F21197FE4B4.1; 
 Wed, 27 Apr 2022 10:31:49 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 18b0e8e7a600.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 10:31:49 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by AS1PR08MB7514.eurprd08.prod.outlook.com (2603:10a6:20b:481::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Wed, 27 Apr
 2022 10:31:47 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%9]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:31:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4822cb55-c615-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=eTs1R2inM40Fop8O2Rx+BQY7yz2GtTm/6iFuoqjZZygmNKb54OFAbgglo72mZ4Ito7PX8BrzMxla74ZBh47CuZMmkYeKlMbo/S+MeYRK2S/FUu5c3w7MX0/SO6qMnrv8xSmdVTMlZr3d4GGqrmx2MtXR6aKcfEHg6X6MpyzqZkpMa38SSJyi+p5c9BM6+8V+cvL3xdA2A2peQP4Fy6unUyfKAWfnQ3RweRISs7xkbkMKTWXfuQpHpvyjNnbqjm1J8kKIq4cqbkLde9sv3BwTs64XlslA73he6Tn0dQEJfsSzCTmHjggalD7CU7o7YY29M4Mf2SQzdE1Mn+07Nh1Wng==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AM7MWqmL5pFftgoohB0muhAA5IdoLr9JxzahZUAs0XE=;
 b=Ge2dNKJ0xwIg3+jrX3/4jrmUtinqdagWDCzMmhvbgZAZA8Jt/aSyP6AUe3GLQSCwq09+wmeTVx3uD+pfvM1GTHkX9AZz5UAZRJjguI1uQB6oR/Mu/Kk2H69KTKN1URDguJy9GKRj4JhDqe0kX1irUyK1Y/Kie0QHDp/+MdQwBFgjKaGVwQFtef6M3B1x7L2OIP2XwWQ/512p6OVvjGRvDC5tp+GqoEBsAo/2ZPYwA1upnNCx7emXw0a5YqOq4c3gSYI9Tl2S+DzwRq5FMwGeI9Y/ThxHlxjDJoY9czV+IQNojPhLAwT6QULZ0WVBqWFW4y9vGcn4O5+x3yKIIdvjjQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AM7MWqmL5pFftgoohB0muhAA5IdoLr9JxzahZUAs0XE=;
 b=UgJMua7iA1w4SKPtCdkECxc3gdkDLLWfpKWBE2BX8bmVcRxvs2OzEiPmVwi1/PUGj5OVnHlXFrjmSb7tvoYaGDFbo/wIp4N2dcSddWUOmnm22SGFLzCsMkPtB+JxxO0UoSWvXkXEqfEeLoImT5aHVvHQ1pWC6/NoRA5HqQI/9IE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JUtwmQtX4LuhUS3olBX69lGkp2gQuXGjbOZ/XfsNnWELtX5j8Z984zMRA2Q5CySsgBCad8tyBGp+UEVzykbOObfI3MVcl1bKcQfHxae69yonY7V3BhGg/Cfj+TMpIxl4i3HScldRwC0rDxrCPBXs0VXWwpx07QmxmONsv8Hj4OrZ9zLvh8zs7b+NF3znRWSVhcdmo2P4G/eLGq+UqbpAMMsZ68CykRZYt3FLHfIP1+ShXMJR956q/rtZnsoUarFoRa8+aG7uK0741B5z3/pA7DJlBdggv875arqBsKnfw824oAIgKkAq8zbYNwcQoi3FyBpn8iyqfnsA4Rr8jSqhrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AM7MWqmL5pFftgoohB0muhAA5IdoLr9JxzahZUAs0XE=;
 b=XRNENRfbqp1gCVr19scDm7UNK7bLms0psFQw4ZLjnyo5poJXBWYNdgnaxABVF1YjU2FQr+vcr9pKw7Hajmx61bQGWhYhIpWOgaRPljKOGqpKzrGzWmK2s7/uXCAFFsGXVb0C0D5SoYf/J+VRv3nkHc923urMN84bJvy/iaIGhSohPbXZOuISDyZ7iVwu24A41ejEvx1am/VFYCztV6j8a/7MnbKPEDT/p9woS/IZGSfiHVYhb/wIIp1sXkxGs41Dv3AXL2WBLbRbMbmO1HHAG8AXWtPBfKbtOUn8iNEMIgtEUWRLaR5/J34IwfJag4QkO8pyKxz0fkiPGRMqHzBZqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AM7MWqmL5pFftgoohB0muhAA5IdoLr9JxzahZUAs0XE=;
 b=UgJMua7iA1w4SKPtCdkECxc3gdkDLLWfpKWBE2BX8bmVcRxvs2OzEiPmVwi1/PUGj5OVnHlXFrjmSb7tvoYaGDFbo/wIp4N2dcSddWUOmnm22SGFLzCsMkPtB+JxxO0UoSWvXkXEqfEeLoImT5aHVvHQ1pWC6/NoRA5HqQI/9IE=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>
Subject: RE: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
Thread-Topic: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
Thread-Index: AQHYWhk9pvmpyYf9yk6PCG0TATWN+q0DifWAgAAAvZCAAALDgIAAAKBg
Date: Wed, 27 Apr 2022 10:31:47 +0000
Message-ID:
 <DU2PR08MB73250C2576634910269805CFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
 <20220427092743.925563-6-Penny.Zheng@arm.com>
 <95b1d82e-92fa-7468-d3aa-038f0de937d9@xen.org>
 <DU2PR08MB73250D118F81DF1FF2C89DAFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <433f9e2a-9da7-662f-04b5-0379eca7496f@xen.org>
In-Reply-To: <433f9e2a-9da7-662f-04b5-0379eca7496f@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 0A04D3E68C4DBA46AFB508680CD40F79.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: b0cf5223-5090-4815-91fc-08da283929ae
x-ms-traffictypediagnostic:
	AS1PR08MB7514:EE_|DB5EUR03FT045:EE_|HE1PR08MB2810:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR08MB2810508179391819BA4B44B4F7FA9@HE1PR08MB2810.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2vwtZy+2WDiAjBj/NXQGsaZn7vtoS4zmNrIGuauS9WjENwW7vP5XBAoYZEy+DoHapIQq/jV6Qibepm/lWMOg1sdMBmzhZ0bOqD8NflwVmCbf7YXd0Sy15855ccZ2hoLukDL1ZTjCP15BswQ/KKCKuj7BZbR6XodrZmftGMxW3h0hj5lV64Y1vFrppO8nC3geI0mDlsOzkLWJGucYQBOpXMUmBf7fTPhbdad3uIl6Xjla6ScIHJeIrmsygMYEHXTayyCw856cPOIaawC/g/wGXdo641w50YS87nbBUJRrr5sG6pM0fkXYExjnbvuBOQISnfOeLH0qCyMn/FlwLPSHH9RnDIXk18dK1jKPHCzR7Pyt61u0XirRJ58hEYDlDKwIGj5duCOhpCT85QXk50I/VzvxrZVIEfICBm5tY4bxbB3Iwa/HmkK8A/A7MYkEDehNwG/wRusMnMz2p0xscGUcMgiP0myCN5KF8sr7fKugzDQZrDki2fm2zOmpnt4ilF/HXhYjZs1HtdjoohTRDnJOsPtfld+7oZzKTotXGg0bhTIHsuSI/xGe9EMkisiibzAof92WLCzef20R8sr0mF/bDEs2FYGRy+lSQGLfnLLvUm3a+7Z8HNS4/NUmxjOvIfYaRDUeAxCVbLsErtOu+n3Ek2MfkSx4nLu10o26V2htXz7fkVCLPPQQVk7PqGnpDvqimW0jZtLZwpw7scZ3/YSH9RdNdwtXdiBDvzRuK0VU2m8C+o42u9v1MEEJP0xq93sf
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7696005)(64756008)(53546011)(76116006)(54906003)(83380400001)(86362001)(508600001)(26005)(4326008)(33656002)(9686003)(5660300002)(55016003)(71200400001)(66476007)(186003)(6506007)(8676002)(316002)(122000001)(52536014)(38100700002)(66556008)(66946007)(110136005)(2906002)(38070700005)(66446008)(8936002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7514
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bb33fc0c-c974-4446-3ba8-08da283921db
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5HRGUShpSpPBlK3EtK8ClpTHlW55CxWIo+ukcbaaSYlTXncvhjpKSo/4GTbKe+1dk+epacDaRIF2fY8IsUS0/qPXiCIXjgLRzJJxDO1ltBzBC8ERNYvDK3bQCXzJo/6dIT6/BvI+OK3DRjqpYFbSDr8JxIUBZt+IlDy2Qv1s6/x089Ok1DMAipP/EpNUFbI9vubgcCX8oRujnDOyGo75cajI6vQMIYxxiVC+JwyrhNQ7eyi89QiZcecWb0GndiXSqyXS4PJR/Jh1Kun41y/Z+ONntzERJn+Hegx8ILLOcQnXVtC1GkHAHoX0forE+bTUMSLvHfVziBSCnv6MMNShDrNG40Ea9dZ3TD6IXLjnPMHOeZtERCXDJvgkVpnOTS/bgfIvMC/kHrmCefy2AmqjD8VfPHOxg5K71UyvBWCgxpDVKPlCnh91RnmOS9I2sQVbHmcZk96EIkjNPXVtnNawxKje5qatnhknvAyKpoz2eyZK6WGyE9Dk9J+E+/OBjbBNjnacdjhOUzWwCEImKKEIABStFmlLPbDPZb5/rKrTuuhjdCXWm24wR6rPEKbb/54m3+pCZ4NPgKeUp9mUQemAJF06J58Lu3YdKFetwH0o31IyyZdtV92QyM02RZ6r/3bCgLIHBT2AwFnz3CmpngpwRhwcG8hYOqoDxVisdZTJnuGolCwP37l46GWQ3rWxcMwS
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(110136005)(52536014)(508600001)(54906003)(186003)(8676002)(70206006)(70586007)(4326008)(33656002)(86362001)(336012)(2906002)(8936002)(47076005)(26005)(5660300002)(82310400005)(83380400001)(55016003)(40460700003)(36860700001)(53546011)(9686003)(316002)(6506007)(7696005)(81166007)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:32:00.3743
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b0cf5223-5090-4815-91fc-08da283929ae
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2810

SGkganVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogV2VkbmVzZGF5LCBBcHJpbCAyNywgMjAy
MiA2OjIzIFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1k
ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5j
b20+OyBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+Ow0KPiBTdGVmYW5vIFN0YWJlbGxp
bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0cmFu
ZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFiY2h1aw0KPiA8Vm9sb2R5bXlyX0JhYmNo
dWtAZXBhbS5jb20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t
PjsgR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsNCj4gSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPjsgV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4gU3ViamVjdDog
UmU6IFtQQVRDSCB2MyA1LzZdIHhlbi9hcm06IHVucG9wdWxhdGUgbWVtb3J5IHdoZW4gZG9tYWlu
IGlzDQo+IHN0YXRpYw0KPiANCj4gSGkgUGVubnksDQo+IA0KPiBPbiAyNy8wNC8yMDIyIDExOjE5
LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPj4+ICsvKg0KPiA+Pj4gKyAqIFB1dCBmcmVlIHBhZ2Vz
IG9uIHRoZSByZXN2IHBhZ2UgbGlzdCBhZnRlciBoYXZpbmcgdGFrZW4gdGhlbQ0KPiA+Pj4gKyAq
IG9mZiB0aGUgIm5vcm1hbCIgcGFnZSBsaXN0LCB3aGVuIHBhZ2VzIGZyb20gc3RhdGljIG1lbW9y
eSAgKi8NCj4gPj4+ICsjaWZkZWYgQ09ORklHX1NUQVRJQ19NRU1PUlkNCj4gPj4+ICsjZGVmaW5l
IGFyY2hfZnJlZV9oZWFwX3BhZ2UoZCwgcGcpICh7ICAgICAgICAgICAgICAgICAgIFwNCj4gPj4+
ICsgICAgcGFnZV9saXN0X2RlbChwZywgcGFnZV90b19saXN0KGQsIHBnKSk7ICAgICAgICAgICAg
IFwNCj4gPj4+ICsgICAgaWYgKCAocGcpLT5jb3VudF9pbmZvICYgUEdDX3Jlc2VydmVkICkgICAg
ICAgICAgICAgIFwNCj4gPj4+ICsgICAgICAgIHBhZ2VfbGlzdF9hZGRfdGFpbChwZywgJihkKS0+
cmVzdl9wYWdlX2xpc3QpOyAgIFwNCj4gPj4+ICt9KQ0KPiA+Pj4gKyNlbmRpZg0KPiA+Pg0KPiA+
PiBJIGFtIGEgYml0IHB1enpsZWQgaG93IHRoaXMgaXMgbWVhbnQgdG8gd29yay4NCj4gPj4NCj4g
Pj4gTG9va2luZyBhdCB0aGUgY29kZSwgYXJjaF9mcmVlX2hlYXBfcGFnZSgpIHdpbGwgYmUgY2Fs
bGVkIGZyb20NCj4gPj4gZnJlZV9kb21oZWFwX3BhZ2VzKCkuIElmIEkgYW0gbm90IG1pc3Rha2Vu
LCByZXNlcnZlZCBwYWdlcyBhcmUgbm90DQo+ID4+IGNvbnNpZGVyZWQgYXMgeGVuIGhlYXAgcGFn
ZXMsIHNvIHdlIHdvdWxkIGdvIGluIHRoZSBlbHNlIHdoaWNoIHdpbGwNCj4gPj4gZW5kIHVwIHRv
IGNhbGwgZnJlZV9oZWFwX3BhZ2VzKCkuDQo+ID4+DQo+ID4+IGZyZWVfaGVhcF9wYWdlcygpIHdp
bGwgZW5kIHVwIHRvIGFkZCB0aGUgcGFnZSBpbiB0aGUgaGVhcCBhbGxvY2F0b3INCj4gPj4gYW5k
IGNvcnJ1cHQgdGhlIGQtPnJlc3ZfcGFnZV9saXN0IGJlY2F1c2UgdGhlcmUgYXJlIG9ubHkgb25l
IGxpbmsgbGlzdC4NCj4gPj4NCj4gPj4gV2hhdCBkaWQgSSBtaXNzPw0KPiA+Pg0KPiA+DQo+ID4g
SW4gbXkgZmlyc3QgY29tbWl0ICJkbyBub3QgZnJlZSByZXNlcnZlZCBtZW1vcnkgaW50byBoZWFw
IiwgSSd2ZQ0KPiA+IGNoYW5nZWQgdGhlIGJlaGF2aW9yIGZvciByZXNlcnZlZCBwYWdlcyBpbiBm
cmVlX2hlYXBfcGFnZXMoKQ0KPiA+ICsgICAgaWYgKCBwZy0+Y291bnRfaW5mbyAmIFBHQ19yZXNl
cnZlZCApdGhhdA0KPiA+ICsgICAgICAgIC8qIFJlc2VydmVkIHBhZ2Ugc2hhbGwgbm90IGdvIGJh
Y2sgdG8gdGhlIGhlYXAuICovDQo+ID4gKyAgICAgICAgcmV0dXJuIGZyZWVfc3RhdGljbWVtX3Bh
Z2VzKHBnLCAxVUwgPDwgb3JkZXIsIG5lZWRfc2NydWIpOw0KPiA+ICsNCj4gDQo+IEhtbW0uLi4g
c29tZWhvdyB0aGlzIGUtbWFpbCBpcyBuZWl0aGVyIGluIG15IGluYm94IG5vciBpbiB0aGUgYXJj
aGl2ZXMgb24NCj4gbG9yZS5rZXJuZWwub3JnLg0KPiANCg0KT2guLi4uIEkganVzdCBnb3QgZW1h
aWwgZnJvbSB0ZXNzaWFuIHRoYXQgdGhleSBoZWxkIG15IGZpcnN0IGNvbW1pdCwgYW5kIG5lZWRl
ZCBteQ0KY29uZmlybWF0aW9uIHRvIHNlbmQuIFNvIHNvcnJ5IGFib3V0IHRoYXQhISENCg0KSSds
bCByZS1zZW5kIG15IGZpcnN0IGNvbW1pdCBBU0FQLg0KDQo+IENoZWVycywNCj4gLS0NCj4gSnVs
aWVuIEdyYWxsDQo=


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:47:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:47:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314857.533109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfCw-00024l-BJ; Wed, 27 Apr 2022 10:47:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314857.533109; Wed, 27 Apr 2022 10:47:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfCw-00024e-8L; Wed, 27 Apr 2022 10:47:42 +0000
Received: by outflank-mailman (input) for mailman id 314857;
 Wed, 27 Apr 2022 10:47:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njfCv-00024Y-5s
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:47:41 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 744b84b8-c617-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 12:47:39 +0200 (CEST)
Received: from mail-sn1anam02lp2042.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 06:47:36 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB3403.namprd03.prod.outlook.com (2603:10b6:4:43::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 10:47:35 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:47:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 744b84b8-c617-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651056459;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=jUMIlGilCjPKdgN0Li3CPh0Zf4sGeK+N1M3b773spPQ=;
  b=cPTA7bSze5T221YAfSNWv5QUYwL7Tj3qXMSaav4vi9g+UcMBTnnmlArx
   PppDknO3jvO1u6300kbtPgRIczQDI3ADYgYs1qz6cfO61kUn3FXt4r58r
   z1+mMwf83w+V4FXu/A+ZkuYGoAg/ahO/ykxSi4sUcTxnfrjAcjb7MuapB
   s=;
X-IronPort-RemoteIP: 104.47.57.42
X-IronPort-MID: 69911451
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:UdSpYamd0Ji+hsEmi9FeWB/o5gz1J0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKWz+Abv2KN2bwet5xb4S3/EhXv5bdzYNhSlc4r3hhEiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWV3V4
 rsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYYlwHYPzBnsokQQREAWJxDIpj/JmAPi3q2SCT5xWun3rE5dxLVBtzBqtBv+F9DCdJ6
 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXupkEhl/chegXdRraT
 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2MJ+QvM+fdui4TV5FNXyLXgM9jTQcDJY8hKhUO7q
 jnZ42usV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL
 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJt//YS7QiMzu/P5V+QAGEBFmRFcIZ+6JVwQiE23
 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPfdYgHdcd0o/
 w23kQ==
IronPort-HdrOrdr: A9a23:mY40faBRdgzysPLlHehKsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ++xoX5PwOU80lKQFmLX5WI3PYOCIghrNEGgP1+vfKl7balDDH5BmpM
 BdmsFFYbWfbGSS5fyKmjVQeOxQpeVvnprY5ts3mBxWPHpXguxbnnBEIzfeNnczaBhNBJI/Gp
 bZzs1bpwC4cXBSSsigHHEKU8XKutWOzfvdEFc7Li9izDPLoSKj6bb8HRTd9hACUwlXybNn1W
 TeiQT26oiqrvn+4B7B0G346YhQhbLau61+Lf3JrvJQBiTniw6uaogkc7qevAotqOXq01oumM
 mkmWZTA+1Dr1fqOk2lqxrk3AftlBw07WX59FOeiXz/5eTkWTMTEaN69M9kWyqcz3BlkMB30a
 pN0W7cnYFQFwn8kCP04MWNfw12l3CzvWEpnYco/jZiuLMlGfBsRLEkjQ1o+M9qJlO61GlnKp
 gkMCjk3ocbTbvABEqp/lWGw7SXLwcO91m9Mws/U/euokdrdUBCvjclLfMk7wk9HeoGOv95Ds
 T/Q9FVfeJ1P7srhZwUPpZxfeKHTkrwfDnrDEW+ZXzaKYBvAQO8l3ew2sR82N2X
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="69911451"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HNCXDRJ94QlKXBC371x6IIINfAmsfqD9zwGmVQvwWO+LBAqIPMdIgwg32bYP/oekand++FuLWuTikjSaX4jr4gvodzxm4OIZNPOmw9L4HVx6p5u4vM7aVVWVhJEx3JKEj74bUux62p0TxqsfQwCxRHo7bJN08n5M8N64+h5hKDsiE52NhDU5mqpD1bfWDlbekfFKcHTm8zl0tGBV8HxQ8lh6pwrOOaGylrDVAPLtYBqGFAwWElqG0NCn053OS5Tfs3xya9/GYRHJ9cNWFlJBs/Bys6zzPhWBsfWCAnjJy/3Z3dFFXvIPGnRx0D7CS6oqmhISgZ4x5nmMKLupgWnBCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WUWhJgu0Yz9j8XsfOkeyy6+r8LNCGTJ8eRrnaODXvM4=;
 b=c/jtEPESyU2Q6WNvleloo+iXGZSwmuofPQhe2WM6AOYigBT+7MaKSnvqkZtDjLIxy+IdVH0QZ6RYNlnJW9wEXqNPCqMuunXEUr1xrZsT75jHs/vuND9miIAhvBEiCRyuWc/M3DcTNJ9DGWNJ3Ffz9LeOBZpBSG/4SpPKMoSMNdB0uZRrgazAMYrcLb01ODcIPthQn87kEfIdYv+j4c1nnx1UyRA7tNBRvpBzzjBE4vCifpm4XlSsVl/kYO82SfM2ydJCse5t5VDOwmVAOtOHD7RrT7USqYU5Y/vqzxQT+gea/c51G3tsum5ygTI+r4d6Odq9BTRdPD1u9i7XmItiPQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WUWhJgu0Yz9j8XsfOkeyy6+r8LNCGTJ8eRrnaODXvM4=;
 b=qNSVVMnxo+6mX1eYqU9O11wiMBklRQFQ1BLmOH0TBrdhTW3sSRJbusEdl1/rZCu5UwLDX/XTSuL+8gBG2U1xEM5IWj8wVlw5vtqiQs/tr5qUYQUYPivYsNBKlBusVsCXqENfD2jFWj+BWPZwMzqHqiMRtBFHVzorz5z/yjrnH8Y=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v4 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests
Date: Wed, 27 Apr 2022 12:47:15 +0200
Message-Id: <20220427104718.81342-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0110.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8fac5354-1d50-4992-428c-08da283b56aa
X-MS-TrafficTypeDiagnostic: DM5PR03MB3403:EE_
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB340394DE9FEF5BE8FF64CE6A8FFA9@DM5PR03MB3403.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hk1GTzfvwGsT88lmHRvplE05VEzPJe3F/jSXDN6VYvCWgWQUuz2zx2SPMiI9iSM2R81mZw4fgW6O0WaQZcX3x60yPMQxa6VC7Mxg3I5ipQ0lUSkKaK6+amMYfDUl4vO2sG8owhBiHJxJIL1F22S9+V5Ehyw/RQHYy6DPCHWTRkKCe1FltXuNyB05zbCQVqx+0Y3xVMSnle2ZTQOt+hQ7dEX8SIh4bIdahscMdDYiFHPeN4CvJO8ImmKe+KTxnI2Fg0cF50imk8PY928x1i2U5mNZpnqGJncnCtvoWw1DJqpBBmVqj7+dE3wFZAbBVElPu6Ei/+TDOsTLa9haTpDHemAkRstKmFkkmsGH/K/XLFNSJir+/Q4KHpM6fMfc6Ocl2+EmTUPpLNjag9a+jz6OfMDfZTewj3c7UR2K42YNMoSewrTomHhIXtW1xZTyULRHaCIL+boYVYEnObbf2zjyeXYwYe4RYqdcOeKEndulkiz+lPZZVy7J/CI/08kphDq3Xe5bfis+gl+344Jwrk0yswzIESd0Xi0HJ7e8OB0ytb5kfiFJhH+GRL0PwMysrMhXfIE1y19FTF9FZ293H44OGcrGMJtx5C05fJtztDInO3qzSIgj/SMarY+xrvO8Nicum3nl+whSwcpUSRXaO4gku8BEmtJ2Fi/O9z4D9oRzwYGRT/DvFpw4WFQoByyU6+kv
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(6486002)(6666004)(8676002)(66476007)(66946007)(86362001)(4326008)(66556008)(6916009)(54906003)(38100700002)(36756003)(82960400001)(6506007)(1076003)(6512007)(316002)(83380400001)(2906002)(26005)(186003)(5660300002)(8936002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZWFtdUhBKytpSURJL0FDd202RitiVjV5OE1PTzhhMC9yQmVKK0VjdGNnR0FW?=
 =?utf-8?B?OUhjeVpCK081NW5xaVQwVW1SVk5Na1VMbytjbjZvVjVRUmg5VVZFaFlDeGcz?=
 =?utf-8?B?UFdYNmwzakpFRmFHdXN4THFKb05qUVlmY2FiTkQ4Zk43ZUdnWjdBZEdSd2JE?=
 =?utf-8?B?Ukp1SmlxYUJoQ2hvdU9wNXdGZzNqcEJiZCtNSmwwc0E2VG1LSklkMlEzTDd2?=
 =?utf-8?B?Z2p4aE5YejhlTUxydDVoRVYyTTBjNDVyZ2d6Vit6aUI3bk1iaXRLQ0IvdFUz?=
 =?utf-8?B?MGNReittVDJhY2JoVTBGWk9XczZ1M1BZa2d3aCtiQWRGY0ZhbHE2TG94OW1U?=
 =?utf-8?B?aXBTdXU3M0RoaWlXUlRhTGtWQmllREdYV1F2N1NuZzA4RjZZZzJBVmdQZExk?=
 =?utf-8?B?eDRuNzhYYU1XVmd2QjJ3czVVK3B5OG40cTJaT1NOWUp6MFF4U0VYR3hScDRN?=
 =?utf-8?B?eC8xcnFhR3U3Ym5DOUVPa3F3cEQvUVJDaWp4R09rYUF4QkNrMHd0TXlUMFZU?=
 =?utf-8?B?SEkvazRKaUkyc3E1R3V3QVdyNk9QODl2a3p5NkJWcHNVVXF0d1RLc3ZnL3Fl?=
 =?utf-8?B?ajFuNlJCaklXSzFsdXlzYUx1UGlBRDZKMERyb0prNVJsZlBzODBaQjl1dE9M?=
 =?utf-8?B?WG04NG1TZjlUZDhkNitKNTVrSWdCVDZqbUhiZUEreStWR3V1eGgrdnVJb1Nu?=
 =?utf-8?B?WkZod1JidmpMU2hKdmJyMkFNdmpWQlVLWHNDbm9YOGlRRHIxR2lkWFBudWZq?=
 =?utf-8?B?eFpjY2FOcGNST05JUS9CZ3NkWEtQTU1qakJicVpXNCtCOUw5dWdhM3dzVkxm?=
 =?utf-8?B?UkxjM1Y3SzFzODhWenczYkhlazQvSXNvYlQ0bkVLQU9RWjlaS1hSMStDOTJW?=
 =?utf-8?B?dVVYOFNONEpzUVJFRTdoMWFDRDFGa015T3E5ZXNHbnpXUU5uM2E2ZS9oekZE?=
 =?utf-8?B?TjRSZUhNL0RzdFRHa2dHQ1lXa3dhSGxYZXR0QVRmendJem9hTmZyRFQvL0JM?=
 =?utf-8?B?Mk1NV3FmODVkNGVneW9LdkVBLzMvNFFqamF0OUd1bk1KU2ZNRlN5WHJ5bUJr?=
 =?utf-8?B?YWRiUjhOVnlvUm9wT3JXaUdtNmdEd2VvSUFpRmVaa3BNTmlmV05jbDlRc2Rq?=
 =?utf-8?B?QzVoU2IrUEpYRWp5S3Q2U0tDK1V3bG5oWVBDeUFlNXVMS0RIRnlsSnpsY2J3?=
 =?utf-8?B?cU1XMHg4bEdsSWYzSk41eDYzVWQ2eXYrUThQeGNPb0dPTUFPU0RwYlFYTjA1?=
 =?utf-8?B?aHZYRkdqN3Fta3ZtUEd0WU1vQy9MUDlvamVkUWszR25sL2FzcnZ0U1lHSzZQ?=
 =?utf-8?B?WDM2bUZLTEtpZkNlYUo4TmtlMG9QeWk4aXR6VEdGZlpSWWtIU0ZOeUI2V3Jl?=
 =?utf-8?B?cjdqTFR6a09uYTJ5TldsdWNEUTQvZVRYMUdPemcxU2VSNE9pQXMzbkF4NmtD?=
 =?utf-8?B?YWhzVjJaMjNLMWVkVVhKR2VVNlIwYTVQeGNCOXBtV0F3TVN3aGhRTHRML1h5?=
 =?utf-8?B?aHFPNy9QOUg3a1RYbHJNbkZMYklickNzNmdkcXY5bXB1dXNIcyttTWJSWXdo?=
 =?utf-8?B?c0p6VmhZWDIvLzJYTDVkeHBXOEpwclhBVHJlY3BLUFZVd1k0ZkViU09nd3JR?=
 =?utf-8?B?TEJMSnRVSUhwUjRKNDBXTnMrd200TTJmbUNuSWJNdDQ4akpKY2U4aURwS3BB?=
 =?utf-8?B?djh3VFdwdStjNTByb2ViTVkzNWNrcXNXZVp6Q0J0NHlzbE9KTmYzMis5NFB0?=
 =?utf-8?B?U0w4NlAwckpKZHpYbVQ1R1owbjQvQ09kZ25ESUg3b0g1VjBONWowNW00TDNI?=
 =?utf-8?B?UjlZVlJyY21WeTJ2SWp4aVVablF2SDdlZEJDZGN3eDNHa1dSbzZRT25SdHZZ?=
 =?utf-8?B?eW0rYVFxcHZ2eG1MdG0zZlRJU1p0MTNEVERteEVuNE5sY1p0djcvSGxxWktK?=
 =?utf-8?B?VWlkMi9zNGg4cGxiWDltazZ3VUo4S0dLcnpIdk5hQlg5aWJCejRqYmVYcHJ3?=
 =?utf-8?B?S3JRdlhEazBxQ1R6Z3RQVVBZMDJkSExhcVBxOHJGVEVDeHFicjMyUWJpZTZy?=
 =?utf-8?B?TzVFaUs0Zjk0UUkxZjk2dVNCSmFLRGNlR1hleVp3REw3QUpTei9TMk9YdFd6?=
 =?utf-8?B?by9maE16eGQ5cXI1b2J0YkUvN1dtaVJlU2NqVnFlTng4eHJWbVJmWnRZam0v?=
 =?utf-8?B?ZlFYcmZIRTRQTGh3T3hmYWp0SGZ0Qyt4RS9UK3JDYjF1SUlPdVNvYVE4Qmpm?=
 =?utf-8?B?ZkQvVldqS1pzUzhnNmtVQ2hYK25MOC9iTk1vNFY1TDJnRC9aMkVpSjlRTFFo?=
 =?utf-8?B?L0RnM05Wd0lLYzZpeE9NU2wwZ2pKSnFkUCtGa2pyZnM3aktLNEoyN2xtUVU2?=
 =?utf-8?Q?fSMGmscKqdF971r8=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fac5354-1d50-4992-428c-08da283b56aa
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:47:35.0244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0E9MWusB5mBaLY3fdnYtIXhmh84jFoZd08W/bQ9DM4yvp1llAZMr251KdzcZ+tPfqboCdjMmipsj76pzYz7W/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3403

Hello,

The following series implements support for MSR_VIRT_SPEC_CTRL
(VIRT_SSBD) on different AMD CPU families.

Note that the support is added backwards, starting with the newer CPUs
that support MSR_SPEC_CTRL and moving to the older ones either using
MSR_VIRT_SPEC_CTRL or the SSBD bit in LS_CFG.

Xen is still free to use it's own SSBD setting, as the selection is
context switched on vm{entry,exit}.

On Zen2 and later, SPEC_CTRL.SSBD should exist and should be used in
preference to VIRT_SPEC_CTRL.SSBD.  However, for migration
compatibility, Xen offers VIRT_SSBD to guests (in the max cpuid policy,
not default) implemented in terms of SPEC_CTRL.SSBD.

On Fam15h thru Zen1, Xen exposes VIRT_SSBD to guests by default to
abstract away the model and/or hypervisor specific differences in
MSR_LS_CFG/MSR_VIRT_SPEC_CTRL.

So the implementation of VIRT_SSBD exposed to HVM guests will use one of
the following underlying mechanisms, in the preference order listed
below:

 * SPEC_CTRL.SSBD: patch 1
 * VIRT_SPEC_CTRL.SSBD: patch 2.
 * Non-architectural way using LS_CFG: patch 3.

Roger Pau Monne (3):
  amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL
  amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests
  amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

 xen/arch/x86/cpu/amd.c                      | 119 +++++++++++++++++---
 xen/arch/x86/cpuid.c                        |  28 +++++
 xen/arch/x86/hvm/hvm.c                      |   1 +
 xen/arch/x86/hvm/svm/entry.S                |   8 ++
 xen/arch/x86/hvm/svm/svm.c                  |  40 +++++++
 xen/arch/x86/include/asm/amd.h              |   4 +
 xen/arch/x86/include/asm/cpufeatures.h      |   1 +
 xen/arch/x86/include/asm/msr.h              |  14 +++
 xen/arch/x86/msr.c                          |  26 +++++
 xen/arch/x86/spec_ctrl.c                    |  12 +-
 xen/include/public/arch-x86/cpufeatureset.h |   2 +-
 11 files changed, 236 insertions(+), 19 deletions(-)

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:47:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:47:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314858.533121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfD4-0002Mg-LS; Wed, 27 Apr 2022 10:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314858.533121; Wed, 27 Apr 2022 10:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfD4-0002MV-Hy; Wed, 27 Apr 2022 10:47:50 +0000
Received: by outflank-mailman (input) for mailman id 314858;
 Wed, 27 Apr 2022 10:47:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njfD2-0002LY-Ix
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:47:48 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 785cc2eb-c617-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 12:47:46 +0200 (CEST)
Received: from mail-mw2nam08lp2168.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 06:47:43 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB3403.namprd03.prod.outlook.com (2603:10b6:4:43::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 10:47:39 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:47:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 785cc2eb-c617-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651056466;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=zdmBQ2lSYlZPiHjFHT8xjLwtwTyxFKhXvcBkDbhK3Fw=;
  b=Ix8rGebHY7LPRtQf09+9OOmN3bDQIlm/4iwMQ6VA0kiUNRL40DCnXgNN
   R7ZabUNGOEi0ZG/zplimcWsfIL1jaB7PgpWJJxcWAmdrhdCGJixCj5wuK
   4YstAmjlO1hU4wQ6U5dtMY4DlpmFrBwULOzJ2APPczWM4eTXR72XF4nqN
   k=;
X-IronPort-RemoteIP: 104.47.73.168
X-IronPort-MID: 72483394
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:faaTva15ow74yeX14PbD5aRwkn2cJEfYwER7XKvMYLTBsI5bpzwFm
 zNNWDzUPv+OMWvyeIt/bt7nph5QsZHXndNjHFY9pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy34Dia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1didvhZiA2BJHpws4PTD9eER4nY5N/reqvzXiX6aR/zmXgWl60n7BLMxtzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+YBfyUtbe03x9p7ixKNezZa
 McDLyJmcTzLYgFVO0dRA5U79AutrialL20D8wPJzUYxy0L0xxJ+/YPUDMHqftiqQM5Yrn2Vp
 W2TqgwVBTlfbrRz0wGt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydG7gEOjX9NUK
 2QP5zEj66M18SSDUd3VTxC+5nmesXYht8F4FuQ77ESI1fDS6gPBVmwcFGcfOJohqdM8QiEs2
 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnF4wL/HKd5jEtJQzN/
 g==
IronPort-HdrOrdr: A9a23:MSOXUqhO6BaGSCLB3iemP5s3knBQX0h13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hqAV7CZnichILMFu1fBOTZslnd8kHFltK1kJ
 0QCpSWa+eAcmSS8/yKhzVQeuxIqLfnzEnrv5an854Ed3AXV0gK1XYdNu/0KDwUeOEQbqBJaa
 Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN
 MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt
 gsAp4Y6o2mcfVmHZ6VfN1xJ/dfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf
 36ISFlXCgJCgjTNfE=
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="72483394"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bwa/TuB4iODCqcpCNT00EGZCFmvZu9cKpUpbnilU+gvq9UEb8tjD/ULq9SLZErsZj4kkwWb1i3wjjeb+UGR9UZDLbmW1KN0sTdZjDViAe/6oz6H3wu0c/2RVEexfPFXzv5BAXn+FMfRfy1Jf/ogHjLzoMFBs3yzp2aUdP86PnXjziJK3Sc54Mj3QJDvL5lPp9IENKYVHbOwbmFboqpekN3jX26UEQ6aylxtYIlcbPIhPoVLxlNUCrmoUlqUmqb5HM5XRcrSZhL9NKhOYkvudICWpdYraYzDFufV0NlVoCOQX7djtC3TDyk5/bJY1MmJCqsOXcb9B7PxpC2f88gboOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9awa4GHJOZs7bmYCimKBd6r5RU7QuG94g/4ySbfQYEk=;
 b=LWb4Nt1NoXDuxRp6ZM6jskzLfeklXvQWt2rzHrpZdHmbcP4kPT6UgHOBhDOHG5RPZfngq5xtuthYLjHuz4dMX26N2KzWOwHsCpPFocBwCSiE4IE5pK4Oq3nRJfiNAEa7TkZqHZjsbBwr4zImvHr/tdkYRhWM8PXB+CEOcxWq8IdGfVBLEnNDo22jmdwP1Zzspr2ZJ0qv8sN4/bjnFozcINOhD9a1tBcGtruh9ELx1TJSLNPk6Um/n1+qyeSYpgMhtFNGh5AhB644lk6VDoXDf+GdxYo6uO2000Gr/lRxW58fHSWbmaFGHMi+J5GHKmfTXOEgQo7ge0/sXlz7ixMeJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9awa4GHJOZs7bmYCimKBd6r5RU7QuG94g/4ySbfQYEk=;
 b=phHQhBv1fD0iB9Sz+emBSaW1sXPApp+vT9VqVyoeqPvaRUDe8gBfXck7BKzMSja/MjG2+Nuxz9LxbBzHDsHbpI3Doy6KrLMV35wTt5Eg+baQ+2CN6kcISlunIrgdV438VyPbVpaEnVXYrvy25j/f7o8yDX4M0hrOpBi9YIuW8yE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v4 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL
Date: Wed, 27 Apr 2022 12:47:16 +0200
Message-Id: <20220427104718.81342-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220427104718.81342-1-roger.pau@citrix.com>
References: <20220427104718.81342-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0059.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 192e296a-f008-49e7-2431-08da283b5960
X-MS-TrafficTypeDiagnostic: DM5PR03MB3403:EE_
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB3403F3953DDC3FB9A5369C288FFA9@DM5PR03MB3403.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZSpWIjMQ/bMEvwZtJPIUV9LWgQiqDe4Kro155ClmkOcTteTLldz1Rj92xEm4vREXqjDDMdTv6j3VjODOeb5nv4HI/RM0QbrZe4hbAUmFuSjrjFECS+gpJ/eqI9vznaS8K6WQ1surCcRUMgobM1GIoVcJ20oj9udBNYtYXhMECtDi+HvXEsOWj0XwhhE7JFMIc/XsfIB4zZUmkeH0QyiiJNa0NHPGfF8faOXoKwmBusAZLJPkszSQWC+56q+w9Y3YLwZ1Z/VB/lbwqrm0eYAQR92QZxtyISRnl7ecIBr+BdJm34xMSTCQAKpQwdRLYMp6YHIUMLxT7/uV1daKmP843buACyuTo8ed+xIOjX29TjL9iRfLtMouNMHScKBeZHYpoj3Xp+1XXC3REGspxVXj4EsXms5We6yUqPwgknbcR8t24J7yxQ5I92aj4j70zMlt963sXxi7U/mCnEptnZX0tSijO/LcmJ9a4FfmR+ZbuPR+e9Rj283SlYUd/of8tYJJH29/p7owTkuXGERdnJmv2kwXkGnOsXgh10G9MgOgy7fCGYuuAma/7uxyVkz2xL6cmdrmcqMaW02WjdHVFjWkZL07FoCLyVr8hQNUG8C3Ouse3nXu7OQ8zPMJXJldGpUP6sPvbvQj3EQ6x8KutERGo6KNPuy0TzZVJzcdYms0Eql0ZK6tAxaw5qQxBotd9+5l
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(6486002)(6666004)(8676002)(66476007)(66946007)(86362001)(4326008)(66556008)(6916009)(54906003)(38100700002)(36756003)(82960400001)(6506007)(1076003)(6512007)(316002)(83380400001)(2906002)(26005)(186003)(5660300002)(8936002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?amE5OGZhblJiMTdKREZLemRRN1JFdERlODRubkhYUERqSjlFSWJmaEVxdmtx?=
 =?utf-8?B?S2NpZnZZNnNRbHlVS0UyTHdMSEhuZnpkUTlDKzNtTU1lZnp2czhNWkgwNUNQ?=
 =?utf-8?B?NW5FN3c5eEt4aUM5ZG5OSjUxYjdCazVSOUovT0FNWE9GQ214Q1l4dWVHVHRs?=
 =?utf-8?B?MktWdms2d0dldThadmpYSkJvTUxDL2N3SXhsUXVHTkg1MlN4OWtqOUJqNXVG?=
 =?utf-8?B?dXdabWVLUlBKUVNUck92QVFzbU9YajRmanN0ZEExazVtYjdFUTMrZ3l5d0xv?=
 =?utf-8?B?ZHZzMHBFQnpFQ3BhRzlTY1BLSXBrMWRrNWJOVkwxMFVxdnoxL2E5aGhJUm1D?=
 =?utf-8?B?V1VHVmJLQ2h1KzNVaEFxcDk1di9jaUZVMXVnQ2tFSFRCRGZYcllJTmVobVp5?=
 =?utf-8?B?TzhwYklBOG41SnFnWWw5RjJqNDloNFhzWG1Qb2J0ZXNXRVl3NHdDbGFOVUxx?=
 =?utf-8?B?Tkx3NG1Ib1NvSnhQbzRrQkxaelF2SExsSE15cFlUdDNPQWIzT1ljZnoycmUy?=
 =?utf-8?B?SjRoOVpIWVFtQmtDaFp3dkpBWHBjUmZyTWtnRDAzZytIUzVxck80TzRxUzBx?=
 =?utf-8?B?K2I3S2tHSlp1QnhGUG1oTndmVTQ4Q1cvL1NUYm1UV2RpNUdsWGJHc0tCMkVY?=
 =?utf-8?B?RE1ueGxxNmJpTlpXdWRSbkVDYStsRWZ5c1dWQ281S2dkTTFCSmp0empJWmha?=
 =?utf-8?B?OVRZaDN3bVRNSUt3d2tvVUJUdUxiVEVIa1k1ZmFDSDM4VEpSLzRrQ3FOdEx4?=
 =?utf-8?B?d1FqNGQ2Mkd0SXpSNitEWEI2WDdXZndUb2g5bkFHa0RtbFhWdFVDWHh6dG9n?=
 =?utf-8?B?OFZTUTdncE5JRGYrd2lGdkRNWnFId292VE5JWFBPRHRya0Q3TWxwMzFzeENv?=
 =?utf-8?B?ZWdtbDZ3SzdTZWx1SjN0amJtb3VKcHhqYjc0WEhFelFicUV5V1ZDOE5JRm52?=
 =?utf-8?B?RHhkbkhqMFVQTGNnbjVOc2UyVm9EUk5wN0RWU0p3R0doRGtUeDdCNUM4eTNs?=
 =?utf-8?B?dzRuY2VLWEZNWnBsQ2djK0hQM0swSllaMHV0Ulc3QzdEQ1pxOGdJR28vSFNT?=
 =?utf-8?B?cTVpZS9JYloxaFJQVVg1TlNTdytvWXJRUE03cDUwcHcrM28zOHgzN3VCTklz?=
 =?utf-8?B?My83LzdvSGJzQ09JWTl6c0xUL0ozZDZjRVYzQlZtNmt0VDF1S3BuREp3OWpu?=
 =?utf-8?B?eDRDKzlxZ210LzZVWDYvVm5pWXlnempYSHBTbUlUcEdmaHVvUElaMmswWEl0?=
 =?utf-8?B?V1kyV0RQQU1uVWNhUG4rQVRPeVhNTjJpNDgxYWJJbllXQnVDa1lpbjZ4RnZO?=
 =?utf-8?B?amJUOFpBay9uZGllVm1WbE5LSDh4djYrMVVvV2w2bEFhamplalF5TWNBcDR1?=
 =?utf-8?B?SzdiUHEwZHhzZCtod1ZPOU1WUm5SY3JBSm1TM0w0TVY4MUp0R2pVZ21QYlhQ?=
 =?utf-8?B?UWRsQ2RMQyt5RzMzeUhsM1pHMjYxSTRscXpIVVd6Z1I0UXpSZmErUXd1amxU?=
 =?utf-8?B?OFB2YVErQlJaZCtjdTRXcEZvMzEwc0p4ODdUcFBHN052WkRDTXNTUkptTk5S?=
 =?utf-8?B?QWJyTk1SVllkOWdrbVlReTdpcExTcDJGNXo5UWVqSWtIOGtrMC9pWG9scGFG?=
 =?utf-8?B?Z3cyUEEyeXhkZnY4a3JlaUV6U2dZdEhSOFZ5Nll6dVpWQ285RUJKb2Z4LytK?=
 =?utf-8?B?ckRUQ3JEbFI1eTNKTUNqc3hQU3BjbG5MdGxHc3ozT1lpZVN2cnY0TUlPa09q?=
 =?utf-8?B?OFlxd3Y2TXZqMW90ZEVQZGNYdW5GMnNvdERBSmFNNmVLRkVoYWJINlI3V3NT?=
 =?utf-8?B?V0g2TkRPTnBZZjRKallBRDFkY3U2OVV4QjdncW9nS2g1TFkrVW83OS8yUFdo?=
 =?utf-8?B?VDhwTkV0RTV3d3dYOTFMbk5oMFF2NkIrMXVYZitlSEM3L2dDYTRJSm96U2VE?=
 =?utf-8?B?N29zYzJudDUydmo5NnFrKzlLTHlla3F2TEpSUnd1eXM1V1lSd1lUYU56UllX?=
 =?utf-8?B?Z1ZyMjNPV1RiTWhZK0lnS0V2RFl3YzNKYmx0NlpEMHdNRUJ6T09SNmFMTGV5?=
 =?utf-8?B?UnBEUy9Vb0hhMit3UlltbnVUMFFHZndFMmtCeW9qNW9ENXhzQ1hTNVdrVlRS?=
 =?utf-8?B?M0FYZHd0QzBFU3ZsazlZRnRBVW9JMVA3bDBnVXNnc211N25Ubnc4WVN5dWdS?=
 =?utf-8?B?TDZLaGg1NHU5ME11OHJKTWNTUE1lTnFUdmlpeEpUb21KSldDenRSLzdMMzF4?=
 =?utf-8?B?SDdEU3RUVFFSQkZ5dFNMQzZvd1VsMnI2ZnhWMUZabWd1Z3N5dlRBcXNwUUVR?=
 =?utf-8?B?R1NncFJPQnVWUlY4emRHR3NSRVBINjI3c04xOElYQ1ZWaE5KVDNadnpKRk0z?=
 =?utf-8?Q?jzjTcf8BONchls8A=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 192e296a-f008-49e7-2431-08da283b5960
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:47:39.5094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h3reVVk5mwrf2ZO43BL1KgjBCrk98wx1RlkHQHbBZm2N1mrljnrnbULsN05R4fQjvpvxDtY3UQBIECVFh8vGaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3403

Use the logic to set shadow SPEC_CTRL values in order to implement
support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM
guests. This includes using the spec_ctrl vCPU MSR variable to store
the guest set value of VIRT_SPEC_CTRL.SSBD, which will be OR'ed with
any SPEC_CTRL values being set by the guest.

On hardware having SPEC_CTRL VIRT_SPEC_CTRL will not be offered by
default to guests. VIRT_SPEC_CTRL will only be part of the max CPUID
policy so it can be enabled for compatibility purposes.

Use '!' to annotate the feature in order to express that the presence
of the bit is not directly tied to its value in the host policy.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v3:
 - Use '!' to annotate the feature.

Changes since v2:
 - Reword reasoning for using '!s'.
 - Trim comment about only setting SSBD bit in spec_ctrl.raw.

Changes since v1:
 - Only expose VIRT_SSBD if AMD_SSBD is available on the host.
 - Revert change to msr-sc= command line option documentation.
 - Only set or clear the SSBD bit of spec_ctrl.
---
 xen/arch/x86/cpuid.c                        |  7 +++++++
 xen/arch/x86/hvm/hvm.c                      |  1 +
 xen/arch/x86/include/asm/msr.h              |  4 ++++
 xen/arch/x86/msr.c                          | 18 ++++++++++++++++++
 xen/arch/x86/spec_ctrl.c                    |  3 ++-
 xen/include/public/arch-x86/cpufeatureset.h |  2 +-
 6 files changed, 33 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 7e0b395698..979dcf8164 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -550,6 +550,13 @@ static void __init calculate_hvm_max_policy(void)
         __clear_bit(X86_FEATURE_IBRSB, hvm_featureset);
         __clear_bit(X86_FEATURE_IBRS, hvm_featureset);
     }
+    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) )
+        /*
+         * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed
+         * and implemented using the former. Expose in the max policy only as
+         * the preference is for guests to use SPEC_CTRL.SSBD if available.
+         */
+        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
     /*
      * With VT-x, some features are only supported by Xen if dedicated
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 5b16fb4cd8..db8f95ef7c 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1334,6 +1334,7 @@ static const uint32_t msrs_to_send[] = {
     MSR_INTEL_MISC_FEATURES_ENABLES,
     MSR_IA32_BNDCFGS,
     MSR_IA32_XSS,
+    MSR_VIRT_SPEC_CTRL,
     MSR_AMD64_DR0_ADDRESS_MASK,
     MSR_AMD64_DR1_ADDRESS_MASK,
     MSR_AMD64_DR2_ADDRESS_MASK,
diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h
index ce4fe51afe..ab6fbb5051 100644
--- a/xen/arch/x86/include/asm/msr.h
+++ b/xen/arch/x86/include/asm/msr.h
@@ -291,6 +291,7 @@ struct vcpu_msrs
 {
     /*
      * 0x00000048 - MSR_SPEC_CTRL
+     * 0xc001011f - MSR_VIRT_SPEC_CTRL (if X86_FEATURE_AMD_SSBD)
      *
      * For PV guests, this holds the guest kernel value.  It is accessed on
      * every entry/exit path.
@@ -306,6 +307,9 @@ struct vcpu_msrs
      * We must clear/restore Xen's value before/after VMRUN to avoid unduly
      * influencing the guest.  In order to support "behind the guest's back"
      * protections, we load this value (commonly 0) before VMRUN.
+     *
+     * Once of such "behind the guest's back" usages is setting SPEC_CTRL.SSBD
+     * if the guest sets VIRT_SPEC_CTRL.SSBD.
      */
     struct {
         uint32_t raw;
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index 01a15857b7..72c175fd8b 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -381,6 +381,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
                ? K8_HWCR_TSC_FREQ_SEL : 0;
         break;
 
+    case MSR_VIRT_SPEC_CTRL:
+        if ( !cp->extd.virt_ssbd )
+            goto gp_fault;
+
+        *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD;
+        break;
+
     case MSR_AMD64_DE_CFG:
         if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) )
             goto gp_fault;
@@ -666,6 +673,17 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
             wrmsr_tsc_aux(val);
         break;
 
+    case MSR_VIRT_SPEC_CTRL:
+        if ( !cp->extd.virt_ssbd )
+            goto gp_fault;
+
+        /* Only supports SSBD bit, the rest are ignored. */
+        if ( val & SPEC_CTRL_SSBD )
+            msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD;
+        else
+            msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD;
+        break;
+
     case MSR_AMD64_DE_CFG:
         /*
          * OpenBSD 6.7 will panic if writing to DE_CFG triggers a #GP:
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 1408e4c7ab..f338bfe292 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -402,12 +402,13 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
      * mitigation support for guests.
      */
 #ifdef CONFIG_HVM
-    printk("  Support for HVM VMs:%s%s%s%s%s\n",
+    printk("  Support for HVM VMs:%s%s%s%s%s%s\n",
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
             boot_cpu_has(X86_FEATURE_MD_CLEAR)   ||
             opt_eager_fpu)                           ? ""               : " None",
            boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
+           boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_VIRT_SPEC_CTRL" : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
            opt_eager_fpu                             ? " EAGER_FPU"     : "",
            boot_cpu_has(X86_FEATURE_MD_CLEAR)        ? " MD_CLEAR"      : "");
diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
index 9cee4b439e..5aa3c82fc6 100644
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -265,7 +265,7 @@ XEN_CPUFEATURE(IBRS_SAME_MODE, 8*32+19) /*S  IBRS provides same-mode protection
 XEN_CPUFEATURE(NO_LMSL,       8*32+20) /*S  EFER.LMSLE no longer supported. */
 XEN_CPUFEATURE(AMD_PPIN,      8*32+23) /*   Protected Processor Inventory Number */
 XEN_CPUFEATURE(AMD_SSBD,      8*32+24) /*S  MSR_SPEC_CTRL.SSBD available */
-XEN_CPUFEATURE(VIRT_SSBD,     8*32+25) /*   MSR_VIRT_SPEC_CTRL.SSBD */
+XEN_CPUFEATURE(VIRT_SSBD,     8*32+25) /*!  MSR_VIRT_SPEC_CTRL.SSBD */
 XEN_CPUFEATURE(SSB_NO,        8*32+26) /*A  Hardware not vulnerable to SSB */
 XEN_CPUFEATURE(PSFD,          8*32+28) /*S  MSR_SPEC_CTRL.PSFD */
 
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:47:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:47:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314859.533127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfD5-0002T3-7X; Wed, 27 Apr 2022 10:47:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314859.533127; Wed, 27 Apr 2022 10:47:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfD5-0002Q2-0j; Wed, 27 Apr 2022 10:47:51 +0000
Received: by outflank-mailman (input) for mailman id 314859;
 Wed, 27 Apr 2022 10:47:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njfD3-0002LY-Rf
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:47:49 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7a5636d0-c617-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 12:47:48 +0200 (CEST)
Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 06:47:46 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB3403.namprd03.prod.outlook.com (2603:10b6:4:43::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 10:47:44 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:47:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a5636d0-c617-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651056468;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=gJk53F/q9++Yykf3w3/00zdaz/po9ma+zUHwq6eUR9k=;
  b=N2ce/Ltwa2UFCmG8uHh8BJoZzdb14cnWbQMxycjpba797bovQzWSbPTo
   lJilv6pQfFKfSyQlqYk0rTalPbDJGAQM6DDEn+uze++an2+TTkZGiscYX
   mo834jXkVKcQV97RGTYlx2sD90s/lVp/5yoyYEvBHkDvTr5QEen8aHVUL
   k=;
X-IronPort-RemoteIP: 104.47.70.104
X-IronPort-MID: 72483420
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:OrmLmKK0Hh6ltIjpFE+RpZQlxSXFcZb7ZxGr2PjKsXjdYENSgzxVx
 2UeWGGBOfbYMWWmL4sgOork/U5TvMPXyN8xQAVlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQ22YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NBD6KC+ZDsWAvfdivQ7UD5CTi9bFoQTrdcrIVDn2SCS52vvViK0ht9IUwQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHsiFGv2WjTNb9G5YasRmB/HRa
 tBfcTNyRB/BfwdOKhEcD5dWcOKA2SOjI2YE8gr9Sawf2lfZllVf2ZfWFtPOYdCAGv4Es0qqu
 TeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuzh1O6WtlfA
 1cJ4Sdopq83nGS0SvHtUhv+p2SL1iPwQPJVGuw+rQuLlazd5l/BAnBeF2YdLts7qMUxWDomk
 EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw=
IronPort-HdrOrdr: A9a23:sCAOg6FcOh3nffhzpLqFepHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79
 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+txKL
 Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+wLzGomjMlFx9fy7Yr9m
 bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHfhWK1RH5m5+BwlquCm71gn1P
 HKvhcbJsx2r0jce2mkyCGdrzXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t
 MF40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIYLH45JlO61GkbKp
 gvMCmFj8wmMm9yLkqp81WH+ebcEEjaRXy9Mwo/Us/86UkioJk29Tpc+CUlpAZwyHsMceg72w
 36CNUZqFg3dL5xUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q
 6xGm9liQ==
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="72483420"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BAt4R7JdivKYP02Pfr+PP2bQYaU/8bJpVNg2l87fmR4wWyi8fg3vfAiNXH+Of3hW1B5WqZ+Y5oflAlFR2dmiVgT3K40NNz+Mon+cgGAXiM20jm68CNGMI1VAs1+3bSiTYx4zkScMfbbPGbMNWIjxQr48Xjo107itTGMuxkflG83fPkwSXr5rF6e/cVjwb5TMG5vEqgpMGTHgs00NF+LWWBArotERRcvcRGx8w/lqZi3Gy3p5Iopn29WcpDhWzvvXWeoVKCcwmajKBVLzw50WXcBUMSMH1up/6mcP4cUSwyzjWODrA+54uqUEA1I+StAKVk8VObVYCu+EPSvaBjMAyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0nJcqzCrAaZuoAasqr/4AZsjYRE4vPluffqUl2JGCbs=;
 b=ImE8XNoMUZp2Q0lI7TiwwTougptENsgf3RAyELoUEx7GlBxNdfkswffY8NIPKOIDhPsj27TPIx4byM+OSK/8ikMkwx8KJRfy5k/wDE4onjPd7gmGp/7hj5gkBFr7uxAwNMixdbr+PGaK9T1fxAK7rJkjh7jA7URZH9Xbtgzkt8X0TgwbZEd+96iIQsQ79zeRz5cQqk6n3PGuLsKhJRvNjnn++05GG7NNCmzGl4hZ7BRDIt+Dr0wkh8TUrRXW0ilRY4l7ZCeekhunpB+uHCB3jF9cY1ULE6tjVYUuqlMMXIweZ0xFgVr4WZvPYMLOH+dYPNtXmwKvcLpjhwgO9pXQ8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0nJcqzCrAaZuoAasqr/4AZsjYRE4vPluffqUl2JGCbs=;
 b=L4YFGQ7A6/IUvNNkiIq9MZHsWvHKkPCb+1DwAZgY2Po5514/SPrq3uBt14zjIAflmNOPWKCpppFPfzF2bBH95bfzNYzX7Lc7w/40HJitJ6pttNG853fxLYmcrmeueNa6DfVljmAfBUiVlfFyhtqmbObcswSqmyfZ0IzqxPO3Ddk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v4 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests
Date: Wed, 27 Apr 2022 12:47:17 +0200
Message-Id: <20220427104718.81342-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220427104718.81342-1-roger.pau@citrix.com>
References: <20220427104718.81342-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0514.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 37c19f4d-ef8f-4210-e66a-08da283b5c15
X-MS-TrafficTypeDiagnostic: DM5PR03MB3403:EE_
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB3403953B1442249953D3DD128FFA9@DM5PR03MB3403.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gvqwvbdkP5cws7KFNWhMZAdGgfpuE9A04vLPGe27MKjmrka9hZ0RistC183jx6pOCg1MEbJ8dR2ixs3snUo+rWq6cwUJF/cI3mNNUVR2Hmr/uJU3YM8isJY+Ra8kTE4R47qyK0AOJ4dvp8rmAiBv9KfTasBpC0QZmUiEIq+nSOwdE+HW8s3v/zLPJYzliwTxuRdfVdxcg8rTbL/zMJs73TtblLsfSeMr472WsnA6jG2/i0Rycx8Yw+W9/SRID6WeRvFxzBtCj+JW1gmfSLkAr28VKL6VkLIMub+4JPYFtzGELp1+108FaqqanoJIKO6HMkBwVMQHBf+NxJcRtY2I8R5TtmYOE5gzY9+LIWuatBTD/HggV+eKGI+Y5L4hCbQIcy+xUY3swa15BF5P9v1I8b1F5EjwEK7zf/C2mG4UV02YA0EstTa+qoLsJoSTtCynJR+HFMeNFafzTq7Z607df9nqP0yY1d3Bj0Q9xEw0sOvjqwqxbmemGjJNNo/y+ZyvRQGo6YIMV5SjmmicOAvsettRw/Dc0wtFMYjkcAfw13nGHhxzBcx2gLI2+v8//fKI8gk6+XWz2ZwpoF0Pi6QegLrUeK0cYJkXk7FYeLOI70PwaPFKup0/bn1mLIfbwbYcT8ea/uUZfHdU9L4pYivPbtnLIKxdOMoMR1yA33JtoK4VPhKRTNU7Px2QBSO2iEot
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(6486002)(6666004)(8676002)(66476007)(66946007)(86362001)(4326008)(66556008)(6916009)(54906003)(38100700002)(36756003)(82960400001)(6506007)(1076003)(6512007)(316002)(83380400001)(2906002)(26005)(186003)(5660300002)(8936002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eFZHM3E4eXBoTWcyN3lGSy9BN0dzcVBOOXZOUE9qdGZZTjlUMFBubUlvMHcy?=
 =?utf-8?B?aElhL1dBMlhWd2Y0MTV5dThFZmJWMDJTSDk0akFUUVRsV1ZwYSt3ZTVTZWpk?=
 =?utf-8?B?ZHVSMU1NeVk2dlBSb1lrRWhydlNBdy9iMnpaOWNhUlB0RWxrZVlpSmNqcTJB?=
 =?utf-8?B?SWg4Undlaks2V1dhOXZzbXFzemVnS2F6SXRVdGJKNkJoMjVzZVQ3RllMNEVk?=
 =?utf-8?B?djFzT0ZRcGhWWmhyTWVCMXVVRkdhM29FZEt0U0JPNGFDbmlWNUg5VGVkM0hi?=
 =?utf-8?B?ZEVYV2E1b3FCb1RNNVljSjV4dWNJQ1k0WmVkRlhVT3UrSVhHUlFXUXI3Ly9s?=
 =?utf-8?B?THZUbEZBbWtXNS9wMFNpUUlCdHJrZzRrM0tXbGo3VlJ6Rm9kZUJsMDFnWm90?=
 =?utf-8?B?VXR2eHBjc0hXSkd3cFVzQmR3eldRZU5vb3ZNeHZmeW1RaGgyWkNmdEdnc3Zu?=
 =?utf-8?B?dWhUOW1lSHYxZURrU2FoVXd4WTA1ZVoxMnFVQXlVdHFXSEc2Z1laQlk0WjFC?=
 =?utf-8?B?YVQxVEU5MGZTWDhvd1ZVVCtZREI1ZEZpaklubEFSaUIvTHZIMGwwSXhIOTBn?=
 =?utf-8?B?Z1JyaVEzcnNrNGc3eWJkUjlyTVFsTDRwdFpld3pwWDdLVGdPcmRIdmtOS0Ny?=
 =?utf-8?B?K1liN09qRnhtb3VLekZHUU0zS3Y3eGVLSFp2WGE5VGFjcG9qeFkrdzAwLzM2?=
 =?utf-8?B?eE9uSk1OTEloVFhtNnM1Si91QW1pdGRjVFBUQVhIckQyRlY4QUdBZGlScHA3?=
 =?utf-8?B?anpzSWdDL0N4ZUtBT28yYWdSb1FJYjNyenlGYUJtdVE1WFJ3L0hUb0tRK3Bx?=
 =?utf-8?B?QTJMMDBkZlRrcG1idVcvM3c3WUZIdjUxV08xMVZBMkhpSm1abWdVNHlsYVJs?=
 =?utf-8?B?Y3FEM1VrbFZqeWRFdU02bU5MRUFxb0g1dWlzNEpsb2ZaT2hnRG9SY0FtcExU?=
 =?utf-8?B?UzV5NEIxVmFMUUVWZUFKOHc5dVo4LzY4M0hQaEJ5VnhwOEk1dHlkb2xLY0xp?=
 =?utf-8?B?NmNycFM5d1Q3ZHl0VnBEeXNZcWpjSWk2WTF6T0wxZlRxcXZuV2hKY2Rxcm14?=
 =?utf-8?B?VnNsUmtGRmFNeUVGdDNuSlVhc2pLaGVDVkhiQWtPVzlaNGMyRDdLeldIVWRs?=
 =?utf-8?B?ZVV3bDNyUGYxZW4yV1lBQmtnT1NQa2FBMFhGVlZmbTNBZEFHVk9WbnhWcUdF?=
 =?utf-8?B?MG9UeDZWYlZHazk2cmVJZ1hlVVk0aUZpV2tEZytuVmp6OXlQcUdXcDNBdGM3?=
 =?utf-8?B?aFBqbjBDQ2piWm9TMnlkZHIwdk05WWFxZndRMFBrVERjZW5IN2Q1S1JId0FH?=
 =?utf-8?B?dllsMEVjUWZ1Y0RTdnlEaFZkVzR4OUFsN2M1a2hPRnJtenVPZnpCSmIwVE5Z?=
 =?utf-8?B?Vy9vZnVwTVlZcC9DZXVJcTMyeUFpRjg3S3gwNFdjYitVdmZ6S2h1dnlzc0hF?=
 =?utf-8?B?WGplekhub3lEbHFJZjk2LzJUb2tSL0lYN3krbDZkRzNNcFY2VzUvajg2N3do?=
 =?utf-8?B?WFJRMzRpeHhFeTBrdkNLb2tjTDhuYit4YWc2bU5acDhjY0hyeU5SZlVqWVF0?=
 =?utf-8?B?bzZmNllkRTA3WmF2Q1p2bzQ0b2pubDJrOCsrSTZQUjJVN1FYVjVtUys0MWt3?=
 =?utf-8?B?cUplM0FVeWlhWW9kQ1FsV0VMNnNKTitzbEpubzlWN2ltamJwcVFuNUY4ZU9R?=
 =?utf-8?B?VnRjTDF2S3E1RE4zS0Jybzl6MFlRdS9IU1hnQlhQcXJHT0NGRGtVRnlTcU1l?=
 =?utf-8?B?MFpCTmUrVHRYTUxzOWhybHVZQzdPTnFvbFZWTXNLZEVMVVNwSkxBNHpkU1k3?=
 =?utf-8?B?NjJlSUdPNnYyRmtlckhTMVAxNXVTcHRNUVp0SzlRTk5YMWcvL0dpT3VzQ0Zv?=
 =?utf-8?B?Z1MxNDZHWUw3V0ZOejRmNEp5a3VvV0d2MHFrV21jNmJ6YTljeW9UaVJ2Y2k0?=
 =?utf-8?B?RzNaR29BNW9zK1RuN0NhazdPVWROTHBsMzRZUlJXek9sNXdwTTgrMGNWU2J0?=
 =?utf-8?B?UFZsTlZvL0dOOXBubVFDRnBUM1pqOHljTXZCdHovczN2dURGb2NCSzJXWHpy?=
 =?utf-8?B?azNtM0g0UUhPSFZ3ZyszTmtUekRwQ1FRZjNVNGYrWVNCeXBGR3YwODBMeThF?=
 =?utf-8?B?OHBsVXhCNWJ1TlFOdVVFQzNJSEMvZ1hJSG11T3FsODd5ZU1DeGd2dTdrcTNG?=
 =?utf-8?B?TmFDQytwM25SQ0NDeUVJa1c4elFaT3VLc3JWN0JDem1QenQ2V1cydE15STdt?=
 =?utf-8?B?V3RSeW9BQ2MzMCtjZ3FXVm0xZGZtZlg1ZTRWN2xMOFFYcEg3azFCd0dFQ2dC?=
 =?utf-8?B?MFZneTV5S21wTWZKZFRTb0trVEZ5YzVlQm9ldHhGTTZRdS92Mm9mYXhVUkNQ?=
 =?utf-8?Q?VFLr2lgNjJMDedlY=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37c19f4d-ef8f-4210-e66a-08da283b5c15
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:47:44.0644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kGhaQnmsyibjR4xWwdvCx+D1vk4uazPcBynnb5L7R8H3qqqB1rLW9gtoDDrWMj7yjFMNwfkQ6sLooIZbcSPgeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3403

Allow HVM guests access to MSR_VIRT_SPEC_CTRL if the platform Xen is
running on has support for it.  This requires adding logic in the
vm{entry,exit} paths for SVM in order to context switch between the
hypervisor value and the guest one.  The added handlers for context
switch will also be used for the legacy SSBD support.

Introduce a new synthetic feature leaf (X86_FEATURE_VIRT_SC_MSR_HVM)
to signal whether VIRT_SPEC_CTRL needs to be handled on guest
vm{entry,exit}.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v3:
 - Always trap write accesses to VIRT_SPEC_CTRL in order to cache the
   guest setting.
 - Do not use the 'S' annotation for the VIRT_SSBD feature.

Changes since v2:
 - Reword part of the commit message regarding annotation change.
 - Fix MSR intercept.
 - Add handling of VIRT_SPEC_CTRL to guest_{rd,wr}msr when using
   VIRT_SSBD also.

Changes since v1:
 - Introduce virt_spec_ctrl vCPU field.
 - Context switch VIRT_SPEC_CTRL on vmentry/vmexit separately from
   SPEC_CTRL.
---
 xen/arch/x86/cpuid.c                   | 11 ++++++++
 xen/arch/x86/hvm/svm/entry.S           |  8 ++++++
 xen/arch/x86/hvm/svm/svm.c             | 35 ++++++++++++++++++++++++++
 xen/arch/x86/include/asm/cpufeatures.h |  1 +
 xen/arch/x86/include/asm/msr.h         | 10 ++++++++
 xen/arch/x86/msr.c                     | 16 +++++++++---
 xen/arch/x86/spec_ctrl.c               |  9 ++++++-
 7 files changed, 85 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 979dcf8164..9a8c73f067 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -541,6 +541,10 @@ static void __init calculate_hvm_max_policy(void)
          raw_cpuid_policy.basic.sep )
         __set_bit(X86_FEATURE_SEP, hvm_featureset);
 
+    if ( !boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
+        /* Clear VIRT_SSBD if VIRT_SPEC_CTRL is not exposed to guests. */
+        __clear_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
+
     /*
      * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional
      * availability, or admin choice), hide the feature.
@@ -597,6 +601,13 @@ static void __init calculate_hvm_def_policy(void)
     guest_common_feature_adjustments(hvm_featureset);
     guest_common_default_feature_adjustments(hvm_featureset);
 
+    /*
+     * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus
+     * VIRT_SC_MSR_HVM is set.
+     */
+    if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
+        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
+
     sanitise_featureset(hvm_featureset);
     cpuid_featureset_to_policy(hvm_featureset, p);
     recalculate_xstate(p);
diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S
index 4ae55a2ef6..2f63a2e3c6 100644
--- a/xen/arch/x86/hvm/svm/entry.S
+++ b/xen/arch/x86/hvm/svm/entry.S
@@ -19,6 +19,8 @@
 
         .file "svm/entry.S"
 
+#include <xen/lib.h>
+
 #include <asm/asm_defns.h>
 #include <asm/page.h>
 
@@ -57,6 +59,9 @@ __UNLIKELY_END(nsvm_hap)
 
         clgi
 
+        ALTERNATIVE "", STR(call vmentry_virt_spec_ctrl), \
+                        X86_FEATURE_VIRT_SC_MSR_HVM
+
         /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */
         /* SPEC_CTRL_EXIT_TO_SVM       Req: b=curr %rsp=regs/cpuinfo, Clob: acd */
         .macro svm_vmentry_spec_ctrl
@@ -114,6 +119,9 @@ __UNLIKELY_END(nsvm_hap)
         ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM
         /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */
 
+        ALTERNATIVE "", STR(call vmexit_virt_spec_ctrl), \
+                        X86_FEATURE_VIRT_SC_MSR_HVM
+
         stgi
 GLOBAL(svm_stgi_label)
         mov  %rsp,%rdi
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 2455835eda..e15c9754d7 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -52,6 +52,7 @@
 #include <asm/hvm/svm/svmdebug.h>
 #include <asm/hvm/svm/nestedsvm.h>
 #include <asm/hvm/nestedhvm.h>
+#include <asm/spec_ctrl.h>
 #include <asm/x86_emulate.h>
 #include <public/sched.h>
 #include <asm/hvm/vpt.h>
@@ -610,6 +611,16 @@ static void cf_check svm_cpuid_policy_changed(struct vcpu *v)
     svm_intercept_msr(v, MSR_SPEC_CTRL,
                       cp->extd.ibrs ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW);
 
+    /*
+     * Always trap write accesses to VIRT_SPEC_CTRL in order to cache the guest
+     * setting and avoid having to perform a rdmsr on vmexit to get the guest
+     * setting even if VIRT_SSBD is offered to Xen itself.
+     */
+    svm_intercept_msr(v, MSR_VIRT_SPEC_CTRL,
+                      cp->extd.virt_ssbd && cpu_has_virt_ssbd &&
+                      !cpu_has_amd_ssbd ?
+                      MSR_INTERCEPT_WRITE : MSR_INTERCEPT_RW);
+
     /* Give access to MSR_PRED_CMD if the guest has been told about it. */
     svm_intercept_msr(v, MSR_PRED_CMD,
                       cp->extd.ibpb ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW);
@@ -3105,6 +3116,30 @@ void svm_vmexit_handler(struct cpu_user_regs *regs)
     vmcb_set_vintr(vmcb, intr);
 }
 
+/* Called with GIF=0. */
+void vmexit_virt_spec_ctrl(void)
+{
+    unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0;
+
+    if ( val == current->arch.msrs->virt_spec_ctrl.raw )
+        return;
+
+    if ( cpu_has_virt_ssbd )
+        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
+}
+
+/* Called with GIF=0. */
+void vmentry_virt_spec_ctrl(void)
+{
+    unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0;
+
+    if ( val == current->arch.msrs->virt_spec_ctrl.raw )
+        return;
+
+    if ( cpu_has_virt_ssbd )
+        wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, 0);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h
index 7413febd7a..2240547b64 100644
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -40,6 +40,7 @@ XEN_CPUFEATURE(SC_VERW_HVM,       X86_SYNTH(24)) /* VERW used by Xen for HVM */
 XEN_CPUFEATURE(SC_VERW_IDLE,      X86_SYNTH(25)) /* VERW used by Xen for idle */
 XEN_CPUFEATURE(XEN_SHSTK,         X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */
 XEN_CPUFEATURE(XEN_IBT,           X86_SYNTH(27)) /* Xen uses CET Indirect Branch Tracking */
+XEN_CPUFEATURE(VIRT_SC_MSR_HVM,   X86_SYNTH(28)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */
 
 /* Bug words follow the synthetic words. */
 #define X86_NR_BUG 1
diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h
index ab6fbb5051..460aabe84f 100644
--- a/xen/arch/x86/include/asm/msr.h
+++ b/xen/arch/x86/include/asm/msr.h
@@ -375,6 +375,16 @@ struct vcpu_msrs
      */
     uint32_t tsc_aux;
 
+    /*
+     * 0xc001011f - MSR_VIRT_SPEC_CTRL (if !X86_FEATURE_AMD_SSBD)
+     *
+     * AMD only. Guest selected value, saved and restored on guest VM
+     * entry/exit.
+     */
+    struct {
+        uint32_t raw;
+    } virt_spec_ctrl;
+
     /*
      * 0xc00110{27,19-1b} MSR_AMD64_DR{0-3}_ADDRESS_MASK
      *
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index 72c175fd8b..a1e268eea9 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -385,7 +385,10 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
         if ( !cp->extd.virt_ssbd )
             goto gp_fault;
 
-        *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD;
+        if ( cpu_has_amd_ssbd )
+            *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD;
+        else
+            *val = msrs->virt_spec_ctrl.raw;
         break;
 
     case MSR_AMD64_DE_CFG:
@@ -678,10 +681,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
             goto gp_fault;
 
         /* Only supports SSBD bit, the rest are ignored. */
-        if ( val & SPEC_CTRL_SSBD )
-            msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD;
+        if ( cpu_has_amd_ssbd )
+        {
+            if ( val & SPEC_CTRL_SSBD )
+                msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD;
+            else
+                msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD;
+        }
         else
-            msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD;
+            msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD;
         break;
 
     case MSR_AMD64_DE_CFG:
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index f338bfe292..0d5ec877d1 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -406,9 +406,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
             boot_cpu_has(X86_FEATURE_MD_CLEAR)   ||
+            boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ||
             opt_eager_fpu)                           ? ""               : " None",
            boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
-           boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_VIRT_SPEC_CTRL" : "",
+           (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
+            boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM)) ? " MSR_VIRT_SPEC_CTRL"
+                                                       : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
            opt_eager_fpu                             ? " EAGER_FPU"     : "",
            boot_cpu_has(X86_FEATURE_MD_CLEAR)        ? " MD_CLEAR"      : "");
@@ -1069,6 +1072,10 @@ void __init init_speculation_mitigations(void)
             setup_force_cpu_cap(X86_FEATURE_SC_MSR_HVM);
     }
 
+    /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */
+    if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && cpu_has_virt_ssbd )
+        setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM);
+
     /* If we have IBRS available, see whether we should use it. */
     if ( has_spec_ctrl && ibrs )
         default_xen_spec_ctrl |= SPEC_CTRL_IBRS;
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:47:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:47:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314860.533143 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfD9-0002y8-FI; Wed, 27 Apr 2022 10:47:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314860.533143; Wed, 27 Apr 2022 10:47:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfD9-0002y0-Br; Wed, 27 Apr 2022 10:47:55 +0000
Received: by outflank-mailman (input) for mailman id 314860;
 Wed, 27 Apr 2022 10:47:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njfD8-0002LY-Bc
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:47:54 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7c427951-c617-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 12:47:52 +0200 (CEST)
Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 06:47:50 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB3403.namprd03.prod.outlook.com (2603:10b6:4:43::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 10:47:48 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:47:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c427951-c617-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651056472;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=BpP0m7aKbLABzlgc2LX2HlH4wa0142cM46ZjDoJX6eY=;
  b=htk4p4878Gp0Xzb52RijzVkziUAAxCBKEjTtC7aouZLEAVUV3cSbWppu
   9G0Y563Xi/luvZ3LUKmHLkSuHu537MTqykIFAHUvxOdipH0XT2sK1ZL/Y
   p/KDWZeMkNr2aPZ/CG4ewE8eO0OvLG4v6EPzWot7p1XHzBZ57WymMS2xL
   Y=;
X-IronPort-RemoteIP: 104.47.70.109
X-IronPort-MID: 72483422
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:mECP9KMFyhjdZP/vrR3RlsFynXyQoLVcMsEvi/4bfWQNrUoj0zBTn
 DAYWzyGPf7cZDDwfNtwPNiw8ENU6pCAzYdjHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NAw2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 tRdt7juTVsTNZLFlsgTA0MFHxhMMvgTkFPHCSDXXc276WTjKiOp6dMxSUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB5GdaaG/SiCdxwhV/cguhUGvnTf
 YwBYCdHZxXceRxffFwQDfrSmc/33CWvKGEC8jp5o4It+mL80RRe4oHcPYPQWoKIfeEMgF6X8
 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1a3FOvZsnwWVu/unHsg/IHc99ZEul/4gfSzKPRul6dHjJdFm8Hb8E6vsgrQzBsz
 kWOg97iGT1otvuSVG6Z8bCX6zi1PED5MFM/WMPNdiNdi/GLnW35pkunogpLeEJtsuDIJA==
IronPort-HdrOrdr: A9a23:VabN8KyG9kkuYdfKA2OQKrPxvuskLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scu9qBTnhORICOgqTMyftWzd1FdAQ7sSibcKrweBJ8S6zJ8l6U
 4CSdkANDSPNykcsS+S2mDRfbcdKZu8gdiVbI/lvgtQpGpRGsRdBmlCe2Wm+hocfng6OXN1Lu
 vU2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnS4j4uFxd0hZsy+2
 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUoZ5Sy+BQO5M2/4lcjl9
 fB5z8mIsRI8nvUOlq4pBP8sjOQpAoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L
 gj5RPXi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZNIMvD0vFnLA
 BSNrCd2B4PGmnqLEwx/1MfjeBEZ05DUCtvGSM5y46oOzs/pgEN86JX/r1bop46zuNNd3B13Z
 W7Dk1WrsA/ciZvV9MaOA4ge7rBNoWfe2O7DIqtSW6XZ50vCjbql6PdxokTyaWDRKEopaFC6q
 gpFmko/1IPRw==
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="72483422"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CwL18PuxYiUSYXw1mfZo4CE9EtW1nAdyiz3XuNCS5OVi5J4JGH/qVW2iN5ApP4EhO7gi9kdPJANq9G73Rk5KiibkqsmkABWTsX5Bet+iXJMmKZkMD5oVRWpz0K3/sdGmu/Syg2jSMfV9D6NqqJa99Mnv5oGaFKlZOd1+YNnVFXhtwLpAiwhT5KvzXC/6QXj2ZloEWXwy7WQW335vcmMo40lEAy4uPvxBM8+DICuh+2FAjg+n5yfY506ZhCb4niuWTWU0PVha7DMyiVauYLwU7vQFfZ881+4huJZfX9KAbLeCN8BrZHpGtxe1HmVkPdtw25tHUxabcYavdeneQEnQ3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z12lg9DG0wvGLeF3XX3a2VomQuQ550jjqifJz8ePXvE=;
 b=RtTXLaPO4GF1HsvCHr0+FINX809520fZj/k46blPLVnmhSp6oMjo3de++nYb93R+lzleBeSJy1Ju6RoXE9Ct/X/NJfJCsRvyHdQ+n0kGpmcE+GoFljdrpND1tnZb3Uxli5XfEhJfZU+YIGfjX3exw9bKSPphhj/CedYTVhh636RJiITW0gzbKScmru5a8QhEd/Npja4IDmx7mCHN5x9njqsjD33QmNU3MEFFzRHtdfPhCy9IMTKyeOgHMyV9uS2AJdQRUQY0outcctOMYBbhQLhId9Va2+onsHk1YKb911IJspHWc2oe0DMx9tKizC+h16GoPYl/jIW1pq3XK7SYrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=z12lg9DG0wvGLeF3XX3a2VomQuQ550jjqifJz8ePXvE=;
 b=I7538quEMle03dYlt9D3+d/sCUZkioAkjlYB+X/y+t+uG5W7YWNunn/vZpWw5ynJyedkOW+cJp90wYI6nzYvw5noBkHi6Kzh0kiQILcZwaQHnSCTWARQfbGJtbR3bUoOEjvQ9fImAvKCNWsfwobb87otP4QbQu9lRZClEo9P94o=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD
Date: Wed, 27 Apr 2022 12:47:18 +0200
Message-Id: <20220427104718.81342-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220427104718.81342-1-roger.pau@citrix.com>
References: <20220427104718.81342-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0304.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a5::28) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 04e68e45-9edc-42a3-f8cc-08da283b5e8f
X-MS-TrafficTypeDiagnostic: DM5PR03MB3403:EE_
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB340300BE1E5AB1B4F898065D8FFA9@DM5PR03MB3403.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+KX6jJb0kutyHhzD0I8J+waPvkHnUStq10QFwfq3DvlPGvwNrBQS+ORF0daBa8ucZucHHpnYWDGx34e+IpzS+mXMmfr8ARhPo8Fi3E0PGOZCk6iainldPrFXWhSTQTIAXd6dpmo1vNU2InTdztS4vtkbcZ4N0c3/L36Gz2eLW2J/Y3MvT4gSsM3WC2yUl9FI8OkiRrriJY8A4Ymrh84VOt3Cmd8if/LLImOcWP7v9xCGYGWx6Oygw7B6UFUbbXZUt/Iatmkv+iKTY59+cwHLKPW5npPXrWIIguGq24+j581SvYAfS6l/3eizaxHvYhcJG2mEqbbbjmcrCHt1y4rLfT3nwxIq8gtkTMOb8XcfciUS+gwBW3WIDYocyFAkGlu0PCMj4xFQDFXD4RZaIjGNz1lyzAu4TDfhEcujDzuX/oyYEpc1dPACB78696UWtbnsPEtbzCYFA7Eh7+j1dFDNaKZTGFtmvRyGdSWtU5XjiLslR8deduYCxj/UnHBqF5/OQRfXguA2QWBPZPN1dmcB/9fzXK6IhzI1NHHGSX5QWiP6DWIKfyGMK7vQFd6YFHyviG4VHh8wzetMbsmkaNQFE1IvxHiZrOnalNcokv2bgmeUrL+bYleCln+Z0tejd75qp2Fa0MVB18EqQDVP4RyWukjoYs1uKqDqADKwd8guLdo7zAKYgpvhGvIrpoK36M0nUMTJL/MXzygODz3b1PTlGEAXKwsSYnnpy6lEltmxadxnI1NPZzNwr/zk6SNuxG8hgs9wc2Bph903INSPXEdsiItYcaKqEi1TEZdEBKpxPqA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(966005)(6486002)(6666004)(8676002)(66476007)(66946007)(86362001)(4326008)(66556008)(6916009)(54906003)(38100700002)(36756003)(82960400001)(6506007)(1076003)(6512007)(316002)(83380400001)(2906002)(26005)(186003)(5660300002)(8936002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MEV5TGxtWHI0VFVXUHBlaUgrNll1UHRQcW92T1M0SkdiTVh6cGVLQ0pIdFhL?=
 =?utf-8?B?YmxOOGZEUmdJWmxpdE9wbk5QZmwwa2FmRUhaZ0hxVnVhZVY5Mlh2cEg4dzRG?=
 =?utf-8?B?MStJbmY3MDF2eWlxUE9sbTBTeDhwUkJWQWxBQXRmcHJsRkJCay8yYm12bmZP?=
 =?utf-8?B?Rm5nNVBPZDFTNWRKZlhNNHVBZGRzZUNVM0JEcDl5VHdheERsRUtlZVlQay9y?=
 =?utf-8?B?Y1NIUGlKVkk2aHNtQVRUSS8vaE5PdHZPYnpZQVVoTGFFMFBXNmlaTkRoUzNS?=
 =?utf-8?B?TXFHRStNR3ZzRjdmdW43ZFExNnViQUFxSUZCNDMyVHdaZnc3Uk9pempmWWdG?=
 =?utf-8?B?TU1udS9zTy9HbW9MN0Zlblg2YjZLVXVaaG9OUmo1bDh1Y2h2aUdwTU5wdmJj?=
 =?utf-8?B?TVF0V1h4TnhxUFNpY1hwQ2V2cGZiM2FMdTd4TzRrSjkxN29DNnFJNFBnR2VX?=
 =?utf-8?B?aGVTeHplWGtvaVZZUmZ1ejhGbGVEbXYrTU11ZktaMFdRNm4za1dzcjBVbzRo?=
 =?utf-8?B?eFM3ZmZRNmpTSUF4T1o0cnR3bFlqaCt0TmpPT0h1d1RudlFFYys1TGxwMkt4?=
 =?utf-8?B?M1dwOTBYdi9tdXFCcm9zNS85SEQyLzNrZ2JkZmFBYi9NMmM3aHZxellycms1?=
 =?utf-8?B?Wnk2RUJuVkF5a0xPQnM2STRhVklWRWFNSytuSUNWNWhBcS93QVA5TWtkUUVh?=
 =?utf-8?B?VHlYejVxejRteDhnendmdnM3b3hKVkZQS1dVTHpTdVZ3MWZRbWhqMUdRdlNw?=
 =?utf-8?B?SDRmNFdVVUtTVHVnMTNCMlRJYmowdHNucDRwMFlCSE8vc1l5RW1tS3Brdms2?=
 =?utf-8?B?S1prdmZaRzZLT1JkRWpmWEVraFRtVENPYzYwWnovd3UxUHpWY3MyeGxVcWZj?=
 =?utf-8?B?QWdJZG9aTEl2Tytuc0x6MEd6REZwbm1tUDFhMkhmWkVpTWhtRnVUN1ZQd05M?=
 =?utf-8?B?OHF0SVVSZGV1eldZOVJKcjdnMXZ5UmZiajF5d2JQRkhXS0dUa29ReXlGbTgy?=
 =?utf-8?B?NVlQWTZDcXVoaGVEMkFUaXVzT1FTTnB0bml4NkpkWDRJQmNNbWZscW5lTkMv?=
 =?utf-8?B?TDF6MndibnNtSTBrTzMwR2o3UjljT2d3dkt2LzJPOXUwVTNlY3YwS1Blak9h?=
 =?utf-8?B?V2FxcFF4UEVjV056M0JTV3ZMSHNUamlVWEswckR2c0wxT0JSU1JpT3l5ZS9w?=
 =?utf-8?B?SXZPTVFhQVN3b0xqYUhnVEgwd2ZkTTdpRjZSUGp6bm50NnZ6MFF1UEdRbjd1?=
 =?utf-8?B?aTJ4YlJkTjI0YjgyOTZocXd1VXlrMm1RVWlqUEM2VnRyTThReVMxSGNkcW9J?=
 =?utf-8?B?QmM5cUxzcWRDQTY1MEdHdGMxaEMwSDJCWUZMM1hvb1RkL0dVV0x2eUkvY3Rh?=
 =?utf-8?B?RHlWZGg3d0J6SW1NOEk4L3VDc3YyQVFRQmp5ank1Y3lCNGkrL1ROWGJva0M0?=
 =?utf-8?B?SnNtSlFtY015bkhGcDJURm5IYUQ0YW9DSWE0bHFMOHFaTkhTVUpKekE3NFBQ?=
 =?utf-8?B?SG5rUHlrOFE2NStZZElaR3FiWTNnSndoQzlkT2hzWTg1dUVHOGl4bWRDV2M2?=
 =?utf-8?B?aGZIOWcvNjEvV0Q5cElxNnlmUTNpejQwODc4b3ppTE11VSttKzVmZ0srdmFG?=
 =?utf-8?B?LytkUWFyd1FmS3dXMytFakYrQVVmdDFRdUhuRWhoVndlMk5lbkh2czMzNDJu?=
 =?utf-8?B?Q0tueFRYSUZsYzJiWHJaek8xVnpOd0JBRVJFNjdhSDVPNU92TTV1RUxITWhG?=
 =?utf-8?B?M25SNktRZ1B2OE42c1VyTzJCU25sYTJNU284c2lZaXZsYXppSUx2VFF4cnNI?=
 =?utf-8?B?YW9VOVM4RnVyYi9EcWliNlZvRVR6Tjh6VytoOFdoWS9ZZlEwRkQ1L2ptQnpW?=
 =?utf-8?B?WjR3RlhQczNJa3VTT1ZLR3dyUitqd2ptaGVpYytuQ0RaUDBZVzdZUjdsRG5u?=
 =?utf-8?B?Nm5kVUhNQ0wveDl3STA0U3Y5MTd5b1RCRGxBNFJmbnl5eDZFbjJCaFFWZksy?=
 =?utf-8?B?Z3NFQ0FRazN5eWwvZUtid0I4Q3VBZExIWU8rbS9YZFdzWkRaMHVqSXd5S3BW?=
 =?utf-8?B?c1FRZjBCRHZobzhGMzUzTmx4VmU3b0lCdHBodzdaUTkvWC9QUFQzdDh4YWpv?=
 =?utf-8?B?U29udUY0RnhoTFRDRjVaTjFxWlhzZ2c5ZVZ0eTFpWmdBajlXNFErMHdJSldy?=
 =?utf-8?B?WGRVRDl4T1BwdzBoWXNqSTlJTk1jQ2tCbEFwVm13c1VGb2hLV1h1Y1hKT0VY?=
 =?utf-8?B?VnZRM2l2Z1c5OW1UaVcyK042Q0Y3UVdKK0MvV2hOVHE0NnB0RzdnVzMrcGc3?=
 =?utf-8?B?L1JMd1RDUncyVVVDUFE3WHEzM1ZhNDVEbVpxVlhLOElDeDB1dnpPOEcySXhC?=
 =?utf-8?Q?syxRIgWj0yGfpRJ8=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04e68e45-9edc-42a3-f8cc-08da283b5e8f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:47:48.2583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gji5NHHtghA0t5WwpjUQspkvClDM+SVBFsO/I2asCS566eGvuV402ZeyforX/brpyZm9lu+J5qxoUzkOPJsOfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3403

Expose VIRT_SSBD to guests if the hardware supports setting SSBD in
the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU
families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD
allows for an unified way of exposing SSBD support to guests on AMD
hardware that's compatible migration wise, regardless of what
underlying mechanism is used to set SSBD.

Note that on AMD Family 17h and Hygon Family 18h processors the value
of SSBD in LS_CFG is shared between threads on the same core, so
there's extra logic in order to synchronize the value and have SSBD
set as long as one of the threads in the core requires it to be set.
Such logic also requires extra storage for each thread state, which is
allocated at initialization time.

Do the context switching of the SSBD selection in LS_CFG between
hypervisor and guest in the same handler that's already used to switch
the value of VIRT_SPEC_CTRL.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v3:
 - Align ssbd per-core struct to a cache line.
 - Open code a simple spinlock to avoid playing tricks with the lock
   detector.
 - s/ssbd_core/ssbd_ls_cfg/.
 - Fix log message wording.
 - Fix define name and remove comment.
 - Also handle Hygon processors (Fam18h).
 - Add changelog entry.

Changes since v2:
 - Fix codding style issues.
 - Use AMD_ZEN1_MAX_SOCKETS to define the max number of possible
   sockets in Zen1 systems.

Changes since v1:
 - Report legacy SSBD support using a global variable.
 - Use ro_after_init for ssbd_max_cores.
 - Handle boot_cpu_data.x86_num_siblings < 1.
 - Add comment regarding _irqsave usage in amd_set_legacy_ssbd.
---
 xen/arch/x86/cpu/amd.c         | 119 ++++++++++++++++++++++++++++-----
 xen/arch/x86/cpuid.c           |  10 +++
 xen/arch/x86/hvm/svm/svm.c     |   5 ++
 xen/arch/x86/include/asm/amd.h |   4 ++
 xen/arch/x86/spec_ctrl.c       |   4 +-
 5 files changed, 124 insertions(+), 18 deletions(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index 4999f8be2b..a911e2e50a 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -48,6 +48,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe);
 
 /* Signal whether the ACPI C1E quirk is required. */
 bool __read_mostly amd_acpi_c1e_quirk;
+bool __ro_after_init amd_legacy_ssbd;
 
 static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo,
 				 unsigned int *hi)
@@ -685,23 +686,10 @@ void amd_init_lfence(struct cpuinfo_x86 *c)
  * Refer to the AMD Speculative Store Bypass whitepaper:
  * https://developer.amd.com/wp-content/resources/124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf
  */
-void amd_init_ssbd(const struct cpuinfo_x86 *c)
+static bool set_legacy_ssbd(const struct cpuinfo_x86 *c, bool enable)
 {
 	int bit = -1;
 
-	if (cpu_has_ssb_no)
-		return;
-
-	if (cpu_has_amd_ssbd) {
-		/* Handled by common MSR_SPEC_CTRL logic */
-		return;
-	}
-
-	if (cpu_has_virt_ssbd) {
-		wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0);
-		return;
-	}
-
 	switch (c->x86) {
 	case 0x15: bit = 54; break;
 	case 0x16: bit = 33; break;
@@ -715,20 +703,117 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
 		if (rdmsr_safe(MSR_AMD64_LS_CFG, val) ||
 		    ({
 			    val &= ~mask;
-			    if (opt_ssbd)
+			    if (enable)
 				    val |= mask;
 			    false;
 		    }) ||
 		    wrmsr_safe(MSR_AMD64_LS_CFG, val) ||
 		    ({
 			    rdmsrl(MSR_AMD64_LS_CFG, val);
-			    (val & mask) != (opt_ssbd * mask);
+			    (val & mask) != (enable * mask);
 		    }))
 			bit = -1;
 	}
 
-	if (bit < 0)
+	return bit >= 0;
+}
+
+void amd_init_ssbd(const struct cpuinfo_x86 *c)
+{
+	if (cpu_has_ssb_no)
+		return;
+
+	if (cpu_has_amd_ssbd) {
+		/* Handled by common MSR_SPEC_CTRL logic */
+		return;
+	}
+
+	if (cpu_has_virt_ssbd) {
+		wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0);
+		return;
+	}
+
+	if (!set_legacy_ssbd(c, opt_ssbd)) {
 		printk_once(XENLOG_ERR "No SSBD controls available\n");
+		if (amd_legacy_ssbd)
+			panic("CPU feature mismatch: no legacy SSBD\n");
+	} else if (c == &boot_cpu_data)
+		amd_legacy_ssbd = true;
+}
+
+static struct ssbd_ls_cfg {
+    bool locked;
+    unsigned int count;
+} __cacheline_aligned *ssbd_ls_cfg;
+static unsigned int __ro_after_init ssbd_max_cores;
+#define AMD_FAM17H_MAX_SOCKETS 2
+
+bool __init amd_setup_legacy_ssbd(void)
+{
+	unsigned int i;
+
+	if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) ||
+	    boot_cpu_data.x86_num_siblings <= 1)
+		return true;
+
+	/*
+	 * One could be forgiven for thinking that c->x86_max_cores is the
+	 * correct value to use here.
+	 *
+	 * However, that value is derived from the current configuration, and
+	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
+	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
+	 */
+	if (boot_cpu_data.extended_cpuid_level >= 0x80000008) {
+		ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
+		ssbd_max_cores /= boot_cpu_data.x86_num_siblings;
+	}
+	if (!ssbd_max_cores)
+		return false;
+
+	ssbd_ls_cfg = xzalloc_array(struct ssbd_ls_cfg,
+	                            ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS);
+	if (!ssbd_ls_cfg)
+		return false;
+
+	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
+		/* Record initial state, also applies to any hotplug CPU. */
+		if (opt_ssbd)
+			ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings;
+
+	return true;
+}
+
+void amd_set_legacy_ssbd(bool enable)
+{
+	const struct cpuinfo_x86 *c = &current_cpu_data;
+	struct ssbd_ls_cfg *status;
+
+	if (c->x86 != 0x17 || c->x86_num_siblings <= 1) {
+		BUG_ON(!set_legacy_ssbd(c, enable));
+		return;
+	}
+
+	BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS);
+	BUG_ON(c->cpu_core_id >= ssbd_max_cores);
+	status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores +
+	                      c->cpu_core_id];
+
+	/*
+	 * Open code a very simple spinlock: this function is used with GIF==0
+	 * and different IF values, so would trigger the checklock detector.
+	 * Instead of trying to workaround the detector, use a very simple lock
+	 * implementation: it's better to reduce the amount of code executed
+	 * with GIF==0.
+	 */
+	while ( test_and_set_bool(status->locked) )
+	    cpu_relax();
+	status->count += enable ? 1 : -1;
+	ASSERT(status->count <= c->x86_num_siblings);
+	if (enable ? status->count == 1 : !status->count)
+		BUG_ON(!set_legacy_ssbd(c, enable));
+	barrier();
+	write_atomic(&status->locked, false);
 }
 
 void __init detect_zen2_null_seg_behaviour(void)
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 9a8c73f067..7607155875 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -544,6 +544,16 @@ static void __init calculate_hvm_max_policy(void)
     if ( !boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
         /* Clear VIRT_SSBD if VIRT_SPEC_CTRL is not exposed to guests. */
         __clear_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
+    else
+        /*
+         * Expose VIRT_SSBD if VIRT_SPEC_CTRL is supported, as that implies the
+         * underlying hardware is capable of setting SSBD using
+         * non-architectural way or VIRT_SSBD is available.
+         *
+         * Note that if the hardware supports VIRT_SSBD natively this setting
+         * will just override an already set bit.
+         */
+        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
     /*
      * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index e15c9754d7..cee11bb244 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -3126,6 +3126,8 @@ void vmexit_virt_spec_ctrl(void)
 
     if ( cpu_has_virt_ssbd )
         wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
+    else
+         amd_set_legacy_ssbd(opt_ssbd);
 }
 
 /* Called with GIF=0. */
@@ -3138,6 +3140,9 @@ void vmentry_virt_spec_ctrl(void)
 
     if ( cpu_has_virt_ssbd )
         wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, 0);
+    else
+        amd_set_legacy_ssbd(current->arch.msrs->virt_spec_ctrl.raw &
+                            SPEC_CTRL_SSBD);
 }
 
 /*
diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h
index a82382e6bf..6a42f68542 100644
--- a/xen/arch/x86/include/asm/amd.h
+++ b/xen/arch/x86/include/asm/amd.h
@@ -151,4 +151,8 @@ void check_enable_amd_mmconf_dmi(void);
 extern bool amd_acpi_c1e_quirk;
 void amd_check_disable_c1e(unsigned int port, u8 value);
 
+extern bool amd_legacy_ssbd;
+bool amd_setup_legacy_ssbd(void);
+void amd_set_legacy_ssbd(bool enable);
+
 #endif /* __AMD_H__ */
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 0d5ec877d1..495e6f9405 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -22,6 +22,7 @@
 #include <xen/param.h>
 #include <xen/warning.h>
 
+#include <asm/amd.h>
 #include <asm/hvm/svm/svm.h>
 #include <asm/microcode.h>
 #include <asm/msr.h>
@@ -1073,7 +1074,8 @@ void __init init_speculation_mitigations(void)
     }
 
     /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */
-    if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && cpu_has_virt_ssbd )
+    if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd &&
+         (cpu_has_virt_ssbd || (amd_legacy_ssbd && amd_setup_legacy_ssbd())) )
         setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM);
 
     /* If we have IBRS available, see whether we should use it. */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:51:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:51:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314877.533154 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfGO-0005Jd-58; Wed, 27 Apr 2022 10:51:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314877.533154; Wed, 27 Apr 2022 10:51:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfGO-0005JW-1m; Wed, 27 Apr 2022 10:51:16 +0000
Received: by outflank-mailman (input) for mailman id 314877;
 Wed, 27 Apr 2022 10:51:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njfGM-0005JQ-G8
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:51:14 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f38f1fa4-c617-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 12:51:13 +0200 (CEST)
Received: from mail-sn1anam02lp2048.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.48])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 06:50:58 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB3403.namprd03.prod.outlook.com (2603:10b6:4:43::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 10:50:56 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 10:50:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f38f1fa4-c617-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651056673;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=T9+Eru50HHTCFWqklLKuhnB31us5TFNPWKeGPeRMmzk=;
  b=a94xqBx6xId2GwLI15bO3apIO9ciA1G03nVF/voclQ4vJrNMysI+KPvG
   K9Z4SD7jNTkewDLrvkHDQr60f2ukQIsgExfcox8nbwGOoasIEtPzyUKcR
   E1ZmP0jQdU6/OkphTfN4iCLD4yMBiEDqVa1WB9NPMsvoCLcxFBqx4MdOw
   8=;
X-IronPort-RemoteIP: 104.47.57.48
X-IronPort-MID: 70435113
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:DHGppKuYeVxn8pP+69O9Y9QBpufnVChfMUV32f8akzHdYApBsoF/q
 tZmKWGAOviMMWqnftx1PNy2pk8A6JPTyNRqT1dp+S00F34S+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X5
 4upyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8UGLCXxuBGaiV1TSBeL5F48rLGDyOw5Jn7I03uKxMAwt1IJWRuZ8gj3L8yBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IHmmtg7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wrJ/vduujO7IApZjYXyF8vfRNezeeptol+ev
 CHCol7VK0RPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BVJ
 lEQ+yEuhbMv70HtRd74NzW7rWCFuFgAWtNWO+w89AyJjKHT5m6k6nMsSzdAbJk9spY/QzUvj
 gWNh4mxWWwpt6CJQ3WA8LvStSm1JSUeMW4FY2kDUBcB5N7g5oo0i3ojU+peLUJ8tfWtcRmY/
 txAhHZWa2k75SLT65iGwA==
IronPort-HdrOrdr: A9a23:9YB6h650I9JgHDxumAPXwUGBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A37wZJPh8sH7eGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heYAotd/lq
 D5259T5cBzp/8tHNxA7dg6MLuK40z2MGTx2TGpUB3a/J9uAQO+l7fHpJMI2cqNRLskiLMPpb
 WpaiIsiYd1QTOiNfGz
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="70435113"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j+uWBHemHiZ/gq4fGVvJs3oplT8PHz1EHBBQY6xuvbeQn4xtRe17oSbKHAy3z3h1jSYU6rK+9hJPJgoC1CsBo1zWbk7ztUpM+IeKjstEGI4Fx7vR5Hib1vgRj79j4uRZksJeWejyJU1Tc4a0y8mO5dPKOf5er9Nu7yi3vZMmlFklHyQUQ5xmYcWeDe9xgBjKpLsnVd1ICtwNqcenq/jy2J4zLwXlDTzk1F7BOvd/0aeJfkBWVvMcUFHwuBMbsCqi1psq9ffpKDHEFO1ZLGVw0J5PYDLHLJETcGSMP7Xttj9TzCd81p0dKQ4Uux3u4S5l4lBXlxC3/9UDBbpFtgxFBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SjnXHUcCFjxyuujOHquhftOVGMvvskz6Ww51NGPCPos=;
 b=aUEFA31WHgIVw+1/8Igq8B+DMMtguELR/zE9rKXurD9WRsdsavcnsoL0LVloq9kmjuDd9u7zpMvJ3T/7VmM3yUwLnKU5oWqecg+FcEnC6ZaXAAFJf1Hsuqcx+Xa09XYdnq1rlkQ39HkcGb5AtLrHPVc4ErAL0PfMk9SJqetzwiqIdCkO7BCn7cBv/dddJVYR8UG961RGgKUD5qpGXGrfT1plfGPeMVCBNpDtmyyDDx3RiPhdIorjN3O3HKz6bJEAYgAr+NSfAcw9CYDyEEZowQ6M5dgnzQHz6XqvfjONikSAqhAA4h/RY/K94oTYEgVHRIuSejPppNKqwmS4OCWOKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SjnXHUcCFjxyuujOHquhftOVGMvvskz6Ww51NGPCPos=;
 b=gBKkJwpUezU7p4NTjLyLvO4ReBAh7kIRMgKosSiZUB+O9EGZpORHFY7Uq4OwmhZqagu12vQvJGa984f52Efb/poLoqJtvtnEv3jpjFGsaUbQXAAjg7k8FVnYOSFDF6byKGyTqRnerBRurOGsb5C9y/2zWKjfu9YxXTEmK9kt79w=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 12:50:53 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Kevin Tian <kevin.tian@intel.com>,
	Edwin Torok <edvin.torok@citrix.com>
Subject: Re: RMRRs and Phantom Functions
Message-ID: <YmkgDSXYaQMbDOv/@Air-de-Roger>
References: <5364e8de-9c45-41d1-abbf-8be70c524e72@citrix.com>
 <Ymj435hWOcY9BK36@Air-de-Roger>
 <c3c83d6d-dc84-bd81-4087-1eece1acb18a@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c3c83d6d-dc84-bd81-4087-1eece1acb18a@citrix.com>
X-ClientProxiedBy: LO2P265CA0516.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cdc42b61-82b7-4cfe-0180-08da283bceef
X-MS-TrafficTypeDiagnostic: DM5PR03MB3403:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB3403DC9EE8112F7020CBBCE48FFA9@DM5PR03MB3403.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VVwZeinj+Y/peMJGRcan/mQIgTy6MJcHYwg6tOt4jekaD3M0F17wHCw/65vo8bNuu3JffhBeGgqPLg4YNkQbYM0Ivn8y5Fe6FfBhQqpX+7P3vsCWT8hW60hsuOB8sr5QU9zDJ7hi8Ij8vQgF9GHfAepNqV8FUvxUC+VGGCHCFgHS9frVR+VdsAyQBLE4P0E2EOUkUEh1uryqOFUtnTKtpEjdHpsFg+AUR2+vRYz33WBLJ/bmm51zBQXnIDm8Psm3EGyeig+DD0iOjr7GdxED7HSM1EAtBZcRF0XJivWkf0GbAXmt0km+Kk6jDa+bJWtvTSf2j+msygMvMUFGRqgYSXuD+fsp8P6HfNpmwaDh33Lj9vEuypma923cY8xHhJPfdF0+Dq0PJXFpuoW7N5OOu0q6e34zHOnvlMET9tWkzTBFx71s4MiVound6E41Nnvt4fgW6+s0ilqjv/ogjyHBegwJk0Uhi1FNBEyRwRD3dmfVCUBAWGMmfw8mIlabwmDJroPs/67IAVMRs7bF6c/w8+O2mz+cVgNIuG3AUZTgC7/rZYsLpQbHuD/ORka1cy8qQ2ft6z5cWWN7LLz55cM/j5AgjQqQYX0v1PVaJG6b2EWepmRwqsnVWgC/xewPgrHU6IVHv6JrWtKfCnyV5R/IXZ+McSSFtW9kMDJd/WixuQWda7Xl2cM3Ktpb3GVotSpm/0CThp4YimHpKmUwxg+Jzg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(6486002)(33716001)(6666004)(8676002)(66476007)(66946007)(86362001)(4326008)(66556008)(85182001)(54906003)(6636002)(38100700002)(6862004)(82960400001)(3480700007)(9686003)(107886003)(6506007)(6512007)(316002)(53546011)(2906002)(26005)(186003)(5660300002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K21EQk8zZ1puSnQrdFBwcDVXeTJ0N2lJTklRQ3VMeDQ0SjVQNHdWYndDWmtU?=
 =?utf-8?B?Nks1a0RVVDRtN2J6YUJDeTJhTE5rVUs4NWp3VmFQdmMyUDFzbkQ4eVNrclpL?=
 =?utf-8?B?WDhQNGlvUkYrVFY1aXk5YW9pWHN1MUNDK2cybW1CYVN0N2FWZHZodnl6U1Bs?=
 =?utf-8?B?THltTTVRcmExNnhoenorVVJyb2twZmwwNm1ZUmtQTjFoNVhma3VqemJGNk5W?=
 =?utf-8?B?K1ZjaEpsM1B5Rk1ydS9KRzZDSFM4UHd0dTNzS01WT1Z4NFQ1ZjZrSjkrbGlM?=
 =?utf-8?B?L0Q3cW4xK2grQWE3Tjk3UDlwWHZ2Z3RjQjlUY2dsQ2JHSGxsWXZydXVLOXB2?=
 =?utf-8?B?R0lJYmhvYTNUeERxeUx1L3FGT2FRWkphTFhRL29aRzU5cFNuVFpyb09FMDlJ?=
 =?utf-8?B?WkZ4dGhYK1hTK3hyc2lyMk11dDdyYWdsb0t4YWVvdEliWnZlcU5VNWxXNDB0?=
 =?utf-8?B?NGtMTVljN00zdkhzVkZxSnN4K2xqV1lSWG11R3piUXVHRWc5eWNCN1AyZWJB?=
 =?utf-8?B?YkgrVDYzZHJzQ2ZnRlYrc3dGUXhmZktkbjVKbEcyZTdoZS9SMEdoQjZadmdJ?=
 =?utf-8?B?MlFBd0toVFRGTjZjV01XQzk2UGlrYjdCbnBieGxlYTNGeCtUUlBHdExwVllQ?=
 =?utf-8?B?cUtWM0NWRzVQQTQ2NzFBMXF0cE42RHNpNFUySVduN2tzNnB3ZmJVYjREelZG?=
 =?utf-8?B?Ky9TMDltRE04MVNvN0MxYlJwZ3VtQXpGRUl3a3Q1eW1tS01yY2t0dWpOTXlZ?=
 =?utf-8?B?ZnhJYnZKV24yVUNtSS9LdFVtM08vYjRXYnhYb1BNTTcxeUhkaGlJN0xXL21k?=
 =?utf-8?B?UjUrZGYrN0V1QnB0dzlCM1c3TUxHa0UvNzhVZWlKQ1VWaXFMdkcydDVXUDMy?=
 =?utf-8?B?QVB3SVRLaGU5aVZWU1RZUHdCOGhPaVZKSFBpZ2xpenVLbU1FL1A1QUZZTWVj?=
 =?utf-8?B?cnQ3WGZCdHlRSlM4bFdVdHlNekNUemhXK1Jad0hDRkxjMDNQSzJTRHRCNzZO?=
 =?utf-8?B?QU1Ic01uVk1VUk9TT1F5NWVQaE53TXJ4L3R2Sk9Lb1FzMlV0aExhZmR2cEJK?=
 =?utf-8?B?MCtJV3dMcExVZWZqYU8ybXpXd25EUHJiRmdFbDBGZk5OWnNyMkdacnJwOUt4?=
 =?utf-8?B?dEFWd3FmZDJVMEtFRno5NmhDeWNTV1BYL0tEN0Y4blB4cm1zdFNLby9xcmFS?=
 =?utf-8?B?VksrRmFCUGRBbklPaUNVSXg4VVhkaldHdGhyN3h2N1BCVlhCaGR2d1NyMlRq?=
 =?utf-8?B?RWZYM2lJNDBuQlRCVUZlcTlsdWQ3VFhQNWh2WnZvems3ZGRlQkF0aDY1S3NF?=
 =?utf-8?B?ZUNZK0c3aUg4NW1rbzJkMEU0TDJWWC9LNklLTjBwSyt1RkNiZkNzaHFVSmZ1?=
 =?utf-8?B?M0Zmc1liSVMyckxVU1J1dlBueDYyRlNMSUh0RTBGOStwQTU3cVQ2QlBVaHc3?=
 =?utf-8?B?bm1DcCtkd2VkMmJYdjVab2d3bFZqeFlvL3Y4QzBHcEdBeG9FMDM3dEpiRUp2?=
 =?utf-8?B?enRBT0pRTEUvcEFJRW9RSDNaOEJHMkFZd0tXNTRHNjRocUt1cVF0SDlWVXNH?=
 =?utf-8?B?a1NnNnp3U1ZKTFhONjhxUXNnYXhuS05NcHMxc2tHTEl0UXYrUlM2ejVKWk00?=
 =?utf-8?B?cm83eEdxT09UZ2YwYnRNSEhLMkxXWVk5aXI1T0JjNTV2VXBRRmU3YjFjTU9W?=
 =?utf-8?B?M3FjVnk3aU53U0czMzhrZlhpZHVkNWxWeFNtVDRDcjY1RTlNRDdVM1FPLzBh?=
 =?utf-8?B?Mm80bWRhaG9lQmVGQnowekk3OUg0TThKTzhYYWJ3clZIUW9nZnAzZ0V2MHRV?=
 =?utf-8?B?eEJ6ZnZkUGY5WmllWTFWUG9NYWdMdy9CTk5lNXBwWnd5K1RUMWJIczNvUStk?=
 =?utf-8?B?NXBNYjJJQklGek5BN1pHNTAyOFlJeHZ1NHZMYy9tbnJOeW5FZnlPREF4cTRu?=
 =?utf-8?B?ajB3Z3ZJZmx2TTB1b3lhaVlodXphMHl0cXJLbnY2SGQyb3RHMmtncTFlUmlR?=
 =?utf-8?B?eStrVUJGSlA2N0huWU90VldJNXVla1NvSHRNdUx1MS9qZUF4TVZPL3M3SEVh?=
 =?utf-8?B?ajQ0MFlNL1lpc0puQ3RxQ2ZubFZWUXpPbFFYbkhsNFhpQXEwV3BaSW1tenQ0?=
 =?utf-8?B?OGd5N0tVS3hWTkcyRTMrdkRvU2xpK3VZQlpCY0lCTTh3bWprTVhVanNXakZG?=
 =?utf-8?B?Q2NnSTBoVldLeXoybkpWb0JwaG5nYWwvZDdoVHEybXpzR2lCclF2Z3lNQ09k?=
 =?utf-8?B?VWRiaDFWaUdTbXkzM2ZITzJlalZuOU9icGRoaWY3bjhSYWR3djgzTll5Vktn?=
 =?utf-8?B?SWpneEpDL0hZL0x4V3hLZkJiOXhKL1RxcEVOYWxYU1dOWWVmQ1hPSW9zVEJN?=
 =?utf-8?Q?n4kxBUVbMezZeeDA=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdc42b61-82b7-4cfe-0180-08da283bceef
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:50:56.8172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zGQ5Z3aR3pKH942Vqt4CJJe5oe4+7Yi9xgej6FfVHLzZV8DtZD4LNMketThdocqKLGYHSVwXtfsAgBREF0aL1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3403

On Wed, Apr 27, 2022 at 10:17:49AM +0000, Andrew Cooper wrote:
> On 27/04/2022 09:03, Roger Pau Monne wrote:
> > On Tue, Apr 26, 2022 at 05:51:32PM +0000, Andrew Cooper wrote:
> >> Specifying pci-phantom=04:00,1 does appear to work around the faults,
> >> but it's not right, because functions 1 thru 3 aren't actually phantom.
> >>
> >> Also, I don't see any logic which actually wires up phantom functions
> >> like this to share RMRRs/IVMDs in IO contexts.  The faults only
> >> disappear as a side effect of 04:00.0 and 04:00.4 being in dom0, as far
> >> as I can tell.
> > I think I'm slightly confused, so those faults only happen when the
> > devices are assigned to domains different than dom0?
> >
> > It would seem to me that functions 4 to 7 not being recognized by Xen
> > should also lead to their context entries not being setup in the dom0
> > case, and thus the faults should also happen.
> 
> Functions 4 thru 7 do not exist in the system.  Their config space is
> all ~0's.

Yup.

> As they appear to be non-existent, no IOMMU context is set up for them,
> hence the DMA faults when their source id is actually used.

Right, somehow I read your initial description as the faults only
happening when the devices are assigned to guest, but not when in
dom0.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:55:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:55:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314894.533165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfKt-0005yx-OC; Wed, 27 Apr 2022 10:55:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314894.533165; Wed, 27 Apr 2022 10:55:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfKt-0005yq-Kc; Wed, 27 Apr 2022 10:55:55 +0000
Received: by outflank-mailman (input) for mailman id 314894;
 Wed, 27 Apr 2022 10:55:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njfKs-0005yh-Lo
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:55:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9b4252d8-c618-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 12:55:53 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-fxsvVFLNMsWTI_i7R87Xtw-1; Wed, 27 Apr 2022 12:55:50 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB6613.eurprd04.prod.outlook.com (2603:10a6:20b:f4::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 10:55:47 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 10:55:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b4252d8-c618-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651056952;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=skwrGfE8+Sl7mGdnYdHqvyOb61t/CInea/7lOr5rcj4=;
	b=dxD+uqxQ2nsVOh90udvghmf22l++MXymhKrWOfSU4zSZhqTgNbYi7QXcblUxR+wFQr8jV8
	k8KgYNjTOcbxakIW66DBSjJfUm60Ie5K9iqlf0zohmLDnZgkMH3z+pPt1z/bf1vzgf0hZb
	X0spHod+RC6i1GyKabAzLZBMUrhkqcA=
X-MC-Unique: fxsvVFLNMsWTI_i7R87Xtw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eg++lbbF1ENAZ0g9R5j0Iyg+Kh+mitm0d0gaLy6yjnF29LXfj2WukO5aSxlpFy0GdiC/Fi2lPdpKF6LJm+FK9AaWeihZlRzUgKai/XcNZ2/DyPathh9lDJAhURy/tOu5D+QKTq7WOziFbB15WlPBEGrL0j0d6s7TyOKpI/R/IFGBWueZLMIYMHo5ZsKLg7d/x5srB5Wscp5OUNwtf9ypTJ7wLrznH6fduRxa7mOkmatMdGVvEsN00AWmxV3Ke1bERZtx2g8tU7pKNKTOx57nv3h2f8dk89C8fJxzMKEhWAJPgBqtMkkP1fx2BKLSMFnOnYwb/rHQEYTJuYb7S3jt4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=skwrGfE8+Sl7mGdnYdHqvyOb61t/CInea/7lOr5rcj4=;
 b=A8UeITQpkS+VbklQSWYmxBstamVZpn7qtuqkB+KRM4vrCVgO67H+7QfSn7vtFCmNE/bYeihKlZuYc9TDnS3vJLRnb+mhmVr/PyeoKc2jr5HtT4Cs0dw7oZg9ByuqxzHcMyGa3vU5zRba3uOO2cWj8mdnhMSbmvaHvKQeMu6StiZKBrUHMewtRFA7HkiIbQpQyDt4K1Mu3LfoPlxIOFW3vC1tqma09nlWe4cGt59IuCur0/YoCLLJHgyMnEpXz66jY99iwAGmRUfDCetOwMwC7jxQWDqH8SNLYFC+gAxyMcn86JSyp6myeUfeA/TmiiB/InjVe0NC9ZtLCyzFfab+1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <58aad4ba-af15-0189-5336-698aadfcf905@suse.com>
Date: Wed, 27 Apr 2022 12:55:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] bump default SeaBIOS version to 1.16.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0077.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e565a385-1949-458d-27ea-08da283c7bef
X-MS-TrafficTypeDiagnostic: AM6PR04MB6613:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB66134908E91EEBC8EE42C23CB3FA9@AM6PR04MB6613.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FfyewvEex8FmStUyfLnAuJzTTaM4eiZgSKo/oT+zgtF6Qj+QRbprWBM1OErJ7K6rUU1G1oILJPkEZVxsvVpJ8ciEDYrfEQp+ZdY1D0Lj/MsxTitRsroMhJ6gAwEihr85mYolD2XYSsq1M2PQPPvOGr/3PiOCJPW45k+5iv1Wg2aDM7kOArDKhf2KYtCkFyUxtr7AJbtOeDQE1BK/iUGVmUwo6r7o9/4tD1pMLxqCpjQip6vJ74xNZ58uQuxStSQhTwfIOhHzlzmqzXFV2WKxJ1nJImu4pQfylGtTOvCajER04PislsfGnfX8I/DcL3spaYlabP2cURE0jdruUEE/dZpOg+hHREy6VVGuCtHfB3cKZ0KzUpE1DAV2GjhsTdIwMcjYedakosRnRhJNg7TL+WkoDPThywNbp8rHQ6HwCqr15GsuRjYSyVaJQOUvT5GaEQlshpIrmtg7dK16j4dENn0C2IIijROWGyZWPP6xHXG+dxVzqIRGeg0mBODtR5ZMbennL9ioLbckjdy87/k+9qXi7GrGapboKUDAggHFhICfEOPfnrBNAD59WT7cZPwv0Cte1RWuiT8c6Wz/SGidSO060/hbQjOP4AXk4I+RAVI31Nv6BoT9GCR1qEwAJcYtIV/j4rf+Fj9dhw4fweXgqZ+U830WE3kya1xQRyxtrwXbCMOSIbw21Dvm0BUBXbuIHlWgid3Jm51M/mi3cqcg9DMdah84U9CRQv8tNp+AeCG52dL/1+T09SEmmSiF3I/N
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(6512007)(6506007)(86362001)(31686004)(2616005)(186003)(31696002)(4744005)(8936002)(4326008)(66476007)(66556008)(8676002)(2906002)(5660300002)(38100700002)(66946007)(36756003)(6486002)(508600001)(316002)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NjhCYkFBTURGRVk1WFBIS3o4OCs1SWNWRTFVWllKQjluOWhvOFpTTXZ2NG1B?=
 =?utf-8?B?NlJZTCszMm1vMWYzVDZCZkNSRnk4VjJUNktNdFE0N0pTdnFBYjNSOXo3cGVC?=
 =?utf-8?B?Wkw0azNQOUNFOW05V1NIMGpNQU9jVDYyVUt6YzFCSkNVQXgxQjZiQ3F2dWZy?=
 =?utf-8?B?eVBwL29qaEtyQk4zVjJiRE1ESkhsRWhsY0RNVnpKR1RnM1pRUnM1MHk5UXB2?=
 =?utf-8?B?bmMvbTQxRi9mQVRKL2Qvb25yQkc2SlZoK2NKNkpjaTQzTk00cVZLN1hHQ2xH?=
 =?utf-8?B?ZGlBQ2RoSlJVb1F6VmI4V3hWQlZXMm53cDdZakVOaTZxUkVHNzNpamlNUnRn?=
 =?utf-8?B?VEYyNElOQXg3T2tYMTg4Mk9tTE1laE5VZElJSzdUYnB5SjE1aDlJMEs2eXVX?=
 =?utf-8?B?aTlHS0JjeDZDY1V2NTgvVXVpbnkvSXl3bUZpWm04cndLSzRhSEw0Z3U2aGpP?=
 =?utf-8?B?aWJCTVA5dWZUUWtOVGRSVjdMMi96bWZuQkkyU3lNZ1A2elk0T2RReUtLOWZr?=
 =?utf-8?B?dGlTMllWeFFqWE02OW9xUUlSRkhxWUNPb0lFdTV6ZHRRalZkTTFPVmVvWEk5?=
 =?utf-8?B?V3R3YUpFOUE1ZWJKVkJDc2pqMEdFVStub0JpcWtuWlpnb3QyMG5IZkVSTTJH?=
 =?utf-8?B?M3JXQWhnVklsZXFwMkh5UHZlbVJZblpidXFrM2RVcGtVbW9OMkJvTXZGUHZp?=
 =?utf-8?B?cld3S09EVXFiTjNmZ3dNRWNBQWJDSUc3SG81dUpsVER1QUJiK2xKMmVheFhz?=
 =?utf-8?B?NVByckhGTm5JVXR4L2NsbHNTK2Z4eTVTWlljSW9ESVp6eFM2dklaVWdyUWRi?=
 =?utf-8?B?blJsSGdrSGNGd1BSNjRqZERPaVRQQTRXdE1NTmYxRE90NWl3ek42UUo4YjJE?=
 =?utf-8?B?ZXFEQTJROFVJRDJZTkx2cE10UHo5K3FhSXZXdng4M291YnYvdEdNN1h3UDBI?=
 =?utf-8?B?S0pIN1pZbGUvU29taEhYZ1dKVjBac0VLbTByMkJsbEdFR0p5WEtJeW40NkdB?=
 =?utf-8?B?ZEE5VEZRVmI0aHpzZ0RyUUNialVvSFVLaFJtaGJpRFRMaVkwb3RYb2ZOT0Yv?=
 =?utf-8?B?Z1lUSzJTNnFubUIwa2YrSkpEVERnY0F4anFSR3JJbHRLbDlLb204ZjRia2Vw?=
 =?utf-8?B?dW04bTBVYUV3S2hmV01kK3RlU3phMEVBOHdoTmQyNGoxSi9DNTgvVGtDSUU4?=
 =?utf-8?B?L1pRZ0J5QlJNcE1xQnBoRUdDSVRORjNweE94U21tdDFISXhPUFJIRnNXZzNU?=
 =?utf-8?B?U2tZL1hLNmFyMUVRSXBjWU5SSnNWK0JkanVpQ2tVTHh5bkdqU0xkL3lIUnhQ?=
 =?utf-8?B?Ylpla0FQQ1ZqK0laVmNYT1hlMTV0b1RQaElZbVRaMXluSGRCYXJyZEorUWt6?=
 =?utf-8?B?bmlpR0wwS2Y2UXk4aUI1NVVLbXJBUjh2WE1xZVhHUXFVS1QvemZ5Qy9QZlBu?=
 =?utf-8?B?V053WWFpYlBlNHFsRlFabWdQSGNqMitjeGhRMHk1WmNnTDNBc2Y3N2FyNVU0?=
 =?utf-8?B?R3hCMS9oQXVTZjd2Qm9rZVM3aUFpdTkwMGRIYTRLM1c2dUJFbEpyL2x2Yk5U?=
 =?utf-8?B?Y3l3cTg1UG8xaUs0Q0lRVmsrWDBGOVpyUXprd2FHRkNGaU8vMkNNakdjaU5W?=
 =?utf-8?B?Q0xwYldwbm0yMWtpTHJubFhob3VFSUtVUFNpd3lQQUhONUhCQTljalVKL2dt?=
 =?utf-8?B?VTAxZG9FUFFwVjBGNWtqVVUvSnFnc0pSeWlCSVRtdHN1aVZmRHpMa0k0WG10?=
 =?utf-8?B?c3ZqSTZ6VVpDSkkrMGVnTEdqSXRLdnp5bWhhWVBJREZGV2RjbGJCSTg3ZzM3?=
 =?utf-8?B?d2Nhb3VuRURBK3hRL2d3UWlBN2ZDa2ZpZ2pka3ZBOXNXeldRaU5icURFOEgw?=
 =?utf-8?B?TDY4Z2RNU2ZON0RKZ2h6QU5HZ09WblkzVzAvNVJoQ3hHc0MzN3lHOWdTQXRD?=
 =?utf-8?B?azFGSU8vaEZHRklFS3Q1ZFUvSDVLQ0R2UnNxQStNWkZTUzRPY2U1VGlhQVNl?=
 =?utf-8?B?aFdzL1NoeW54UkFFa1drMHVrM0dKUHlTWkswOXgwcEFoOHhoNlRRL3BLUDc1?=
 =?utf-8?B?dGxmMzgxU0VqaFhlek5UdHZ1YTBpZ3ptNTd3L2VFQmEycm9FTjFkQU5Hc3hJ?=
 =?utf-8?B?WUNFdFlUZk9SOVhZUVRIRU0yZ1J3YjRWOTZieTZqSk1uY3NpVkswVHBGTWtD?=
 =?utf-8?B?TUlzQjFMVFJKaTdaRXYxdnpOOUFaQkpCT21mVnQ0dHB4Z1RrMVhWZCtrNEdh?=
 =?utf-8?B?ZGhnNmpRamE1NDI5ZDRhSHFLcG1xbkZBMXpISjZZVVowSzRvMGcvVytjTzlo?=
 =?utf-8?B?eXduUXlqZVVhY2htS1RVSElNSVA5Wk9IaFYyTkpRczJsV0RxczZPZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e565a385-1949-458d-27ea-08da283c7bef
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:55:47.0797
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 53KssKYXgIEa6DcY8RQsjXxkr2878WbO0VprWkir70f81tPj/Q2kYMFIf8qot3RTxh7rTGL5TsanLk/4tzbYng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6613

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/Config.mk
+++ b/Config.mk
@@ -232,7 +232,7 @@ OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c1
 QEMU_UPSTREAM_REVISION ?= master
 MINIOS_UPSTREAM_REVISION ?= 83ff43bff4bdd6879539fcb2b3d6ba5e61a64135
 
-SEABIOS_UPSTREAM_REVISION ?= rel-1.15.0
+SEABIOS_UPSTREAM_REVISION ?= rel-1.16.0
 
 ETHERBOOT_NICS ?= rtl8139 8086100e
 



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 10:57:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 10:57:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314899.533176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfMK-0006Yx-48; Wed, 27 Apr 2022 10:57:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314899.533176; Wed, 27 Apr 2022 10:57:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfMJ-0006Yq-W8; Wed, 27 Apr 2022 10:57:23 +0000
Received: by outflank-mailman (input) for mailman id 314899;
 Wed, 27 Apr 2022 10:57:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njfMI-0005yh-PX
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 10:57:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d029cfa0-c618-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 12:57:21 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-rO4iQjY-PHWxUV11zXxh5A-2; Wed, 27 Apr 2022 12:57:20 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBBPR04MB6185.eurprd04.prod.outlook.com (2603:10a6:10:c9::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 10:57:18 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 10:57:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d029cfa0-c618-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651057041;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=yLsc49pkrpA56zUyBj4602Mqp4cWTKF+G8J0s3Z4fRg=;
	b=n7LlQBLqBx0iwnV+icIpILtplnc/NK5ST/fuVBc3Hzt4toHEPy568Dg83BfJNAu+sGqiVa
	EO4/iHETS/OZ+cF874iJcDOZZMKnSssThsmYzAxMwm3lbBG5BNyAHhi1FLyF6PwubP4HWQ
	dcUq0VDRf2A76Rkf4VKuolHKqaSAWn4=
X-MC-Unique: rO4iQjY-PHWxUV11zXxh5A-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cDwhmVTvsJh79p3LJPi+I2/HnbILotQW4DB7i+l03roi6lhmIezfy5VMdZ2ixKsXI+My6X8xOZ4Zc36Rj5ual+bwlJWvjQicieaRJlZ7oHuI5wHXAY2axHU2Wh2cAC5AkCMDtx1Gqt3xSOMPHfAHZnOnlpivqIpKlC+pXOwLHuQUYlHcSy0XGidaIpSD61PokjQwlIIyD/HSLXNBU98A1QqeckieR22XUfKVvOztMdYnk1m65mjoZkr1qpESsE1m5oyVbDGkkzwvgezIHrAha2lSgBlVHT5sIZNmleQ4x8NpoyUrpCck+eWYYtaE89fbc4wdn7tVJdAiTjWi9NIOFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yLsc49pkrpA56zUyBj4602Mqp4cWTKF+G8J0s3Z4fRg=;
 b=IIxGXsqPv+mufyWXk3Y3Ok080Ujlz2mF5WAvGEL2LEKE+N+0TObSJpMU+OP5RHd/ph6LzJ+uZXNUf86Yvx3/RNqDrkdfMJipt0dpYXbSUi2jcnJ2LvQhHCb9ELz6MAhamtzWlC+ZwTTJTHqNMsGt50X4pF9ecbHIxqC7xCWa0KgiH0eTcD9odhnXMYug5GxcC64blfI1sSg60jdGjCIh/RFoCXGUalkzux/11nreFqkbC+3HauWGRRV67pFSKr7z5ezEUuBmDD6a8O64Cyi5c5YE+DmCP3fRt78LDWLGaWjPbpK0Dzpdz/1KPWWWJoAWLjLHc4YZGEHviRhQqnf+Sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <81ba388c-66ff-e191-0098-2f88a004105c@suse.com>
Date: Wed, 27 Apr 2022 12:57:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3] x86+libxl: correct p2m (shadow) memory pool size
 calculation
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0027.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::40) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c62aca91-2660-42d5-f177-08da283cb267
X-MS-TrafficTypeDiagnostic: DBBPR04MB6185:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB6185C19CA820052E1ED85A08B3FA9@DBBPR04MB6185.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RbDpOik6dQOOQaiCLo846KbmMKV/HHziwgCWB+fD8TaawyQ3V+YrWu2Amtqjfnb2NRgWSEmVvmRrp6fOYlKeSUJv3gOcuKKaOWzFhgliykQ9+T6UGZXIZqlv9kGSxFZBtx5nfi/dsqY35SNo+/dFZfpJfp4K/VyVTwKNkEIO+fJN8hzScHTGj43+Rw2Hg6VvJH9dx/cFm8sUHxG7CwLLAqDv23JWYo2T2awX/B4mJSQarZp2YUlkQ4DOTrp3h21EKxRmkHcnbPIaXXJZftC5kcxEeqQxjqpzV5iYFhEMEZDyIYykXaBbyyKUorn0zFr4cDblpJNTRiU0UQLgJd46JUAQPSmVo8sHwPtSO7wY9JW68uN1VXGkcJb6wfj97gKbz3gdyC0u6Zm4FwFmVkA9+bsNoLTzi1ZzOJvN084xSegZcpj60+XeXoLDu9aU3se4huKCpyyN+4H/6Q+E7lWP5uc69WmrL/Di8pEMpTgMz6h6QgjjASIK45ZAtddR6WEcBqgYlS9yEM8xRE/HEmfWdW59HZ/q4WsrbWyHxBEzVbDr7c/YpfmWaW49gw4E9egVIbQokD2XjsDkOmu7roous6JLIeN8fKPxEpD1kytnoAJoqyFZS1NGqbWlC3ctXtlznW/HZvwzwohfR3qCRziGsbmF6wcA5eBu6QRHpMVxQyI7gQXUJQabia+uCf3AaOAVnpETNo+sbbeiEld4vWb20m12FFyaVTbk0XtMVuyUOo9nEuta112jtTWXRDBRvcD/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(36756003)(6506007)(31686004)(4326008)(6512007)(5660300002)(26005)(508600001)(6486002)(54906003)(66556008)(8676002)(66476007)(83380400001)(66946007)(31696002)(86362001)(316002)(2616005)(6916009)(186003)(107886003)(2906002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K1crSmtKZG91YThjQkZTR0xOV2NGenlOYVhTMVlpNjJNTFRzdnBVcEYwemRN?=
 =?utf-8?B?UXVSZGxCYUJjbzdMcEpFZ1kyQTlDK3ArYWpXSlJINmNNZ2IvMkNrZzNYbWgr?=
 =?utf-8?B?Z0t3QTBRQUc0VXBwTFBsSUFvWTFyYm5CTS9OWFVDcEo1T1NqclVvMkNKMHp6?=
 =?utf-8?B?eCsrYVZVK1RnRlFFWkM3eW1qZi92eGdKem1wUTArbi85NXA3bU5XT29YeDZs?=
 =?utf-8?B?SGxDelpvUHdtQkJoTlY1WTJjVEE4ajQ2ZWRMNGVEL25scnlPbWhKM0cyNWFz?=
 =?utf-8?B?QjlOWndGWjA1RXJITklWQ0dwbnhBVU9wRjlRNElreVBxc2ZCb05aeWgzSHIv?=
 =?utf-8?B?N0NLR3krSUhjUExoU3Z4VDV6Sk9hNmtxZVZnKzZ3MExHU296UFkrbGRYb2pl?=
 =?utf-8?B?aG9jakF4anBjenNDLzc5WVVpZXB2RENwbUFYZHJDL2FIclJuMkRIWGpCVHpN?=
 =?utf-8?B?QTVNYlR0QnBlR2lRc0Q4N001dDB2bG54U3lRUlF1cHBocTZKOTNScGVhSFRo?=
 =?utf-8?B?Tjc1V0xCN1kxQVoxYzY5Q2J4NmI1NHlGZGlaSlNDdHlzU1FlSEN3Q2RaTXpu?=
 =?utf-8?B?eVBWS1puQUkycUxhcHpNc3c3dndXbEljL2pxUEoyRDNsS2ZCRlJlTnJucXlH?=
 =?utf-8?B?SUVCSVU4Tmd2Z0FVOFFKbkQzekoyRGpxem5tdTdyL2lTb1M0b3Y1V0JlemRt?=
 =?utf-8?B?Zk9oUVlrMjh5VEdsVnF2NGlJWmljdGJuTWY0QTI1QWJXY2QyYzNLbkEybmZn?=
 =?utf-8?B?Vndpc2xua2JhbDM3Ukl5Q1d0a1ZYSWxvUU12Ym05dXY0VmFJM285OTVvN2tF?=
 =?utf-8?B?MWNDMmk4YlloREZ4dkR5N2FoUFpwUERWei9uYThhMHY3UU5NV0FIZXNJd0tD?=
 =?utf-8?B?WmZSTWdsUmJuUmd1VkptUjRVVkhGTExjelUxU2FQaDBNU1R3MGV3VGZoMjcy?=
 =?utf-8?B?NzhQOW9CQko0dU5TZUVHWlNUNW5ySlZ2cGxUN28zRWNUU2t4bzJQOEhyVThL?=
 =?utf-8?B?bnE5ZHpFTkdkSUZjQWFLUUgxZlpsRDBNbHp1UHRxL05rWlhkZlJXaVphWnl3?=
 =?utf-8?B?YkZYTjZ6d3c1Y3FaRXFPMjBLT0J6Z21ML2FmTDFhVVZuZHFMWGlaRGd3RXFh?=
 =?utf-8?B?ajMyQTJJUFpRN2tZa0hyQld2Z3RMR3lEeUFWZTlZdHZDWk5rTXQ5S21abVF3?=
 =?utf-8?B?Q3I5b2JZVG94Z2J5VGRqZUw3V05SdXZjQW9COHFXeUJMTUNYSGxPL1RMSFg0?=
 =?utf-8?B?RW1kNFZIaVU3RVFKVHU3cnpmUEdlY2REK1BlTXltMjVPeTVBSUxDdEdMSU1U?=
 =?utf-8?B?ZGtDdU9Ja2RpeDVkdjRpOVhyeXgrbTNvS2hDYW9mTkhoSzl6YkI1N0ZUMDRk?=
 =?utf-8?B?c3A4NEVPcTlzcS9rbm01aTgzSXlYSFEyYmhhOUdQZ2s3a2RsWGowZkdyOXI0?=
 =?utf-8?B?dkk2UDhrVlE0eXUwUFg3U1g1elhGWE1kM0RmZi9jZkZpcW5DVVk4aDFLQ2t0?=
 =?utf-8?B?NFhSaXhMUEVITHhBRVU3ZTV5SUd0aEpvbllQQ0ZYdEo5VjhSQ3c3Q21jcFVP?=
 =?utf-8?B?M2ZBL1ZDWUJiTlZ3ZWNsOVpRSHdwMVBKalRCUDJDQnUyNmRoOHFKV0E0eVdC?=
 =?utf-8?B?bGJNQVV5VTkwK0NQS1lNK0kxRWwxdlgyakV4OWNqSFRBWS8rcysxVHkvK3Jz?=
 =?utf-8?B?ZytJbWxDMWRqbnZrNUc1SVFzZlNXTlEzNnNLQklId0JjRndhSFBEK0p1VzNZ?=
 =?utf-8?B?cWdDSUxuOUZFS0xkUWJwNnFoQUlMVDNreXpMM1A2V0Fta1JvYmQ5RTdMU2FI?=
 =?utf-8?B?VkVreGxXL21uWEhGRXpwT3h2WW9WK042VWN2WHFITitVVXpLVUViUjg3T2lm?=
 =?utf-8?B?OUxRbEN2eXNxMjZramRaaVgrNHBiZHNSakpMbFI2akVEN3pRbG81Y0lYeFRW?=
 =?utf-8?B?QXY0V05ldWJsamU2c2NtbGEzOWZtUVBlRGxXYkVtalNxRXcvRjYvVWVyNDBX?=
 =?utf-8?B?TzhvVmVOKytER21vMnFUYkVKZXVTSy9nL01kT0lOdzltOHdDT0NBTWttOGR6?=
 =?utf-8?B?V2FScnd5Z2lVbkVQQXF6NmlJaDBLTkxRZGhGZFZOdEkyeUY5eUJ0ajRWVzBT?=
 =?utf-8?B?YXhrNms0TU1tYmMySmpEQVg4ZzV4eWVvN3M2RVZzRmJEbGoxelBGMzdJcHg0?=
 =?utf-8?B?RWZIS1VVN1BWVGgwNEUzL0h4L1AyTnFOYmdEWFUyV29tRWlrN2hmWkg4N3Uz?=
 =?utf-8?B?S2pTcGdPdEtaRExtL2hsbWVmcUh3aWgrM2h5aHNyYWZsVU80VlZzV2NIeU1C?=
 =?utf-8?B?Yk1RNm9rRmdLb052d0pQd1M5YS9LcCtOdkVlZ2dvY3RkMGtiUHhaQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c62aca91-2660-42d5-f177-08da283cb267
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:57:18.3901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MZwGBkSBPtoBz83ubd3jPJRtCzILdamRIcyQgonByYbG624bZDnCVFpTC1g4GVIP7R1BhEFRMzpFfplC56xeyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6185

The reference "to shadow the resident processes" is applicable to
domains (potentially) running in shadow mode only. Adjust the
calculations accordingly. This, however, requires further parameters.
Since the original function is deprecated anyway, and since it can't be
changed (for being part of a stable ABI), introduce a new (internal
only) function, with the deprecated one simply becoming a wrapper.

In dom0_paging_pages() also take the opportunity and stop open-coding
DIV_ROUND_UP().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v3: Refine expression in dom0_paging_pages(). Update comment there as
    well.
v2: Introduce libxl__get_required_paging_memory().

--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1017,7 +1017,7 @@ static bool ok_to_default_memkb_in_creat
      * The result is that the behaviour with old callers is the same
      * as in 4.13: no additional memory is allocated for shadow and
      * iommu (unless the caller set shadow_memkb, eg from a call to
-     * libxl_get_required_shadow_memory).
+     * libxl__get_required_paging_memory).
      */
     return !CTX->libxl_domain_need_memory_0x041200_called ||
             CTX->libxl_domain_need_memory_called;
@@ -1027,6 +1027,24 @@ static bool ok_to_default_memkb_in_creat
      */
 }
 
+unsigned long libxl__get_required_paging_memory(unsigned long maxmem_kb,
+                                                unsigned int smp_cpus,
+                                                libxl_domain_type type,
+                                                bool hap)
+{
+    /*
+     * 256 pages (1MB) per vcpu,
+     * plus 1 page per MiB of RAM for the P2M map (for non-PV guests),
+     * plus 1 page per MiB of RAM to shadow the resident processes (for shadow
+     * mode guests).
+     * This is higher than the minimum that Xen would allocate if no value
+     * were given (but the Xen minimum is for safety, not performance).
+     */
+    return 4 * (256 * smp_cpus +
+                ((type != LIBXL_DOMAIN_TYPE_PV) + !hap) *
+                (maxmem_kb / 1024));
+}
+
 static unsigned long libxl__get_required_iommu_memory(unsigned long maxmem_kb)
 {
     unsigned long iommu_pages = 0, mem_pages = maxmem_kb / 4;
@@ -1194,10 +1212,16 @@ int libxl__domain_config_setdefault(libx
     }
 
     if (d_config->b_info.shadow_memkb == LIBXL_MEMKB_DEFAULT
-        && ok_to_default_memkb_in_create(gc))
+        && ok_to_default_memkb_in_create(gc)) {
+        bool hap = d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
+                   libxl_defbool_val(d_config->c_info.hap);
+
         d_config->b_info.shadow_memkb =
-            libxl_get_required_shadow_memory(d_config->b_info.max_memkb,
-                                             d_config->b_info.max_vcpus);
+            libxl__get_required_paging_memory(d_config->b_info.max_memkb,
+                                              d_config->b_info.max_vcpus,
+                                              d_config->c_info.type,
+                                              hap);
+    }
 
     /* No IOMMU reservation is needed if passthrough mode is not 'sync_pt' */
     if (d_config->b_info.iommu_memkb == LIBXL_MEMKB_DEFAULT
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -1569,6 +1569,11 @@ _hidden int libxl__domain_need_memory_ca
                                       libxl_domain_build_info *b_info,
                                       uint64_t *need_memkb);
 
+_hidden unsigned long libxl__get_required_paging_memory(unsigned long maxmem_kb,
+                                                        unsigned int smp_cpus,
+                                                        libxl_domain_type type,
+                                                        bool hap);
+
 _hidden const char *libxl__device_nic_devname(libxl__gc *gc,
                                               uint32_t domid,
                                               uint32_t devid,
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -38,13 +38,8 @@ char *libxl_basename(const char *name)
 
 unsigned long libxl_get_required_shadow_memory(unsigned long maxmem_kb, unsigned int smp_cpus)
 {
-    /* 256 pages (1MB) per vcpu,
-       plus 1 page per MiB of RAM for the P2M map,
-       plus 1 page per MiB of RAM to shadow the resident processes.
-       This is higher than the minimum that Xen would allocate if no value
-       were given (but the Xen minimum is for safety, not performance).
-     */
-    return 4 * (256 * smp_cpus + 2 * (maxmem_kb / 1024));
+    return libxl__get_required_paging_memory(maxmem_kb, smp_cpus,
+                                             LIBXL_DOMAIN_TYPE_INVALID, false);
 }
 
 char *libxl_domid_to_name(libxl_ctx *ctx, uint32_t domid)
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -314,12 +314,15 @@ unsigned int __initdata dom0_memflags =
 unsigned long __init dom0_paging_pages(const struct domain *d,
                                        unsigned long nr_pages)
 {
-    /* Copied from: libxl_get_required_shadow_memory() */
+    /* Keep in sync with libxl__get_required_paging_memory(). */
     unsigned long memkb = nr_pages * (PAGE_SIZE / 1024);
 
-    memkb = 4 * (256 * d->max_vcpus + 2 * (memkb / 1024));
+    memkb = 4 * (256 * d->max_vcpus +
+                 (is_pv_domain(d) ? opt_dom0_shadow || opt_pv_l1tf_hwdom
+                                  : 1 + opt_dom0_shadow) *
+                 (memkb / 1024));
 
-    return ((memkb + 1023) / 1024) << (20 - PAGE_SHIFT);
+    return DIV_ROUND_UP(memkb, 1024) << (20 - PAGE_SHIFT);
 }
 
 



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 11:06:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 11:06:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314907.533186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfVT-00088s-5W; Wed, 27 Apr 2022 11:06:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314907.533186; Wed, 27 Apr 2022 11:06:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfVT-00088l-1a; Wed, 27 Apr 2022 11:06:51 +0000
Received: by outflank-mailman (input) for mailman id 314907;
 Wed, 27 Apr 2022 11:06:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njfVS-00088f-0R
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 11:06:50 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 21e43128-c61a-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 13:06:48 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCBA8ED1;
 Wed, 27 Apr 2022 04:06:47 -0700 (PDT)
Received: from [10.57.13.174] (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 73DE23F5A1;
 Wed, 27 Apr 2022 04:06:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21e43128-c61a-11ec-a405-831a346695d4
Message-ID: <590d34a8-744f-4170-74a6-1b02013488df@arm.com>
Date: Wed, 27 Apr 2022 13:06:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-4-michal.orzel@arm.com>
 <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Jan,

On 27.04.2022 11:59, Jan Beulich wrote:
> On 27.04.2022 11:49, Michal Orzel wrote:
>> Function unmap_common_complete defines and sets a variable ld that is
>> later on passed to a macro gnttab_host_mapping_get_page_type. On arm
>> this macro does not make use of any arguments causing a compiler to
>> warn about unused-but-set variable (when -Wunused-but-set-variable is
>> enabled). Fix this by removing ld and directly passing current->domain
>> to gnttab_host_mapping_get_page_type.
> 
> I think we want to retain the ld / rd notation. Therefore I think it's
> rather the Arm macro which wants adjusting to not leave this argument
> unused.
> 
I would agree provided that the ld variable was used in more than one place.
As it is not, it does not seem very beneficial to keep a variable that is used
just in one place and stores the macro value.

When it comes to gnttab_host_mapping_get_page_type macro, on Arm it is defined as (0)
so modifying it seems to be a quite big overhead.

> Jan
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 11:19:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 11:19:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314917.533198 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfhr-0001Ch-AT; Wed, 27 Apr 2022 11:19:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314917.533198; Wed, 27 Apr 2022 11:19:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfhr-0001Ca-7a; Wed, 27 Apr 2022 11:19:39 +0000
Received: by outflank-mailman (input) for mailman id 314917;
 Wed, 27 Apr 2022 11:19:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njfhp-0001CU-9Y
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 11:19:37 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9b61202-c61b-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 13:19:34 +0200 (CEST)
Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 07:19:31 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by MWHPR03MB2782.namprd03.prod.outlook.com (2603:10b6:300:48::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 11:19:29 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 11:19:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9b61202-c61b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651058374;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=t+i3Novkn8tMp3ysrMO4pnR0fLCcf0RVPYOCY+xohWY=;
  b=iZPAGonIwSFylsm7WjGX2zwhZXhD/0vG7GL0gp7toCPjYMHyqVg7+PPu
   ItlPDGJP4hZJbS5rbk4xykTSKrmtVQNp0iCiH8dafPtnikjWeInE1TNSP
   nDFU4a+GkHCr0Pzau1d6a7g8HHGSMQknBxaTR1SplpAQHqRxPeRm33yOr
   0=;
X-IronPort-RemoteIP: 104.47.58.103
X-IronPort-MID: 69429414
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Pypr3qrX71Vqep9u8Jw3tlq879VeBmIfZBIvgKrLsJaIsI4StFCzt
 garIBmDbv2DNDH0eo92Ooixo0sGucTTmNYxTgA4qys9QigV95uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 42q+KUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBI5DsssU4dwtkMzBjJot49+XVHSOhiJnGp6HGWyOEL/RGKmgTZNVd1sMpRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp3psm8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrL9PZtsjSKkGSd1pDIP/+WR92sZf9Wh3SXi
 z6d9lv1GQMFYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiGGAlg4RXZxXCeJSwAOC0K3P+C6CG3MJCDVGbbQbWNQeQDUr0
 hqFmo3vDDk26LmNEyvFrfGTsC+4PjUTISkafygYQAAZ4t7l5oYukhbISdUlG6mw5jHoJQzNL
 /mxhHBWr90uYQQjjs1XIXivb+qQm6X0
IronPort-HdrOrdr: A9a23:fWcrOqMKhjn/wMBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5
 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa
 Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd
 WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19
 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d
 78bG8=
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="69429414"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kxT88RWJNaAwQXsd0sRfhcuCU8iCj5+HBviiZSKzG8mvP+ngW0Sfe9RAMJqHHkjsWnxEyvKAq651IgkeVRR4weRZxPO9JtETTQhM4AOGCezdC3u51KvAMqGAAEBVnQ1+EeDL4tWKK+NoubHJaihWCSytMTouGVRQOBoZD+bimfgug2sgRi0ND9QtY+P0HV+ZxpM0zd40/XBG8c8ot0MLIY78KzG59OpmKxOX0jC0EvK5WTBob+Jpbqk4WKjwgTm3rNxy6gWf8WrGO7LmosOTrYqL0fmxF7nLuNJOSQNkQVNEtL1ISKXl0r1zNi0ekUn948fnDQ/doUyMHepkPltQwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WXyimPO8GqWMB0c+fniYlSrLe26pCV/voCpPA6FK4u8=;
 b=Tpl6oHOS9hQ0nY472LSVHepbSGI+PPyuCDJLCp9nryNekcVPrkw7wCtWLigyKKQ0ArgpA2IXp/haar6wyrCJQykyDKlzYmVwMpgwIBXp7dGgPauJfxEfgYQCBP+T/N1sLaPGl6WdJwtOKgkmQnMNyayuq2Bdv06vm+oCYT2RucmNRAIr6dHg2Nmqvj2FdAqmWbOMHOeqp+UOjtpBfXhd8uOCYL14rzzZvXgJvlRAIg6xtkuTzMoLbS53U2x7IZImId17aQT7+OFvzl6wDToPmieU/eG1E3aswyb0ARLJFzXfhWf0/xKZcvUrXQmzQWlMOgXUMfAnLyPBeBjHyLMZxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WXyimPO8GqWMB0c+fniYlSrLe26pCV/voCpPA6FK4u8=;
 b=E4Cs0ykK18ygsOB0l6ZNx7UJWl3veBz7ym+yFKPFgRpKgEBIFRE96wsoojSXiRCvxm9KJjxCtb//vvIgTHo6FoASS2waYzPll9rtTfuGZL87rFO31tDayGarp3YDIwaiAg0Hf97wlaoMAOa3/CM6chXUfOQfpc3MNS08fv+TNFo=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 13:19:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Message-ID: <YmkmvrE5jTQN2cFj@Air-de-Roger>
References: <81ba388c-66ff-e191-0098-2f88a004105c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <81ba388c-66ff-e191-0098-2f88a004105c@suse.com>
X-ClientProxiedBy: LO2P265CA0097.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:c::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c30ef4f9-8913-41f9-e4e0-08da283fcbcc
X-MS-TrafficTypeDiagnostic: MWHPR03MB2782:EE_
X-Microsoft-Antispam-PRVS:
	<MWHPR03MB2782ED7610738971A68CD6668FFA9@MWHPR03MB2782.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PbxlNXtY2/pKiZ2S64rxKTRjY1slNiCnEM4Qs9cqE64WVNOxLRL5Raa7UvpDS+rkK4HGpsWiz7pJYNWxH5SSu160ApeIg9nzVqwIL6OC9c9Lxy9o8BZBrcQZYcDVSa/meBErp40+IrGdFQpR5EzE4SreGnwPT+FXieZ4NGcp5QMjwDPJbVM2wUsLdR1g4PIrGCOehyW89dksdoI5ImgK+UxdERNSyAYyu1waCa7rLxknifDzhTYFU91Qzgbh9TwXL+jtelqq2v5B33istLASPLwn03EW/jUsn7MxrcY6wFNQBL+IjYTNuhQVSMQvjMFfriHwZpzxUKOOJAwlYnyTlZRMZuPR4fHAjZbFFf7+TvoQgFvqanraFRtBYMgboBldLznpbNFCzDToNBMh9ZDw5vu1fvZBaMY4B0gr4QbkHjU46XAmOkE1EuPadxn2bZ7qvOe/PMD+eqIajZJMTBUgvx9LdPC826R82t0HjzPlQuh7EBoz4u0pk0/19SmRc1jX1zr0LvJMDytVg2L6NcrZr+H4KSsxhTcB53GzSrf/QS4QArJAKagiQZLKAuXCyzWocp7hnKoIDOy9vgW+lcR77yxamfYfn2SDC6gQDrogrAkpCADCYdd2CKJB88YtxFxdOGvpUToBCnrDdFKS18jxAw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(186003)(66476007)(66556008)(66946007)(4326008)(5660300002)(38100700002)(6506007)(6666004)(26005)(6512007)(9686003)(6916009)(85182001)(316002)(54906003)(86362001)(6486002)(2906002)(33716001)(82960400001)(508600001)(4744005)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aXRMUjUxZzdpMGt3aXdEZkR0d1NOUUxVTUdZQXFPeXpBbXhrZ0t2YVZBS2pD?=
 =?utf-8?B?eGM5TDNWR25helhaOUY5YUt3ZnRNeVIxRU9LQUdGR1hmZ1BBQnJhMm1qT3pE?=
 =?utf-8?B?bkwwUHkySE1FdkFpQkpJd2ZQT1ZPL1J2ODdQKzBwV2svNnltUndMREYzemt5?=
 =?utf-8?B?V1BIVjZYdzB5QTI4ZzZzK0pvUnZ2VllWMXNNak13SWVFSGhNTjUwTDdadmZX?=
 =?utf-8?B?S3hnVnlNaXhzZnNRdkVwSkhtbDAxS0Yxd0FQdE14RnZTWGhqSG00RDdVOGNQ?=
 =?utf-8?B?dk5tQ0pQNENHVHpQVnpzTUdmZ1lyRjJ0dWdWSVBxcTJtRkwxSC94R0ZvY3Z4?=
 =?utf-8?B?akUyQ2ZWVTVwWGllWVhxRi9ib3JFNDhPMFR3RFpXRGx1eExjUXZwN3RMbW1I?=
 =?utf-8?B?WHhiY0IrRlNTWVB1NGpmMzhubTl1R3VabTVZYTRJYU1XaWJWdGxDMnNkWVND?=
 =?utf-8?B?NnVSLzNYWlRrc1NEdjd4ZWk2YkcxM3cydG1FMU9Hb2VOMTNpRFY2cXZ6NXJT?=
 =?utf-8?B?dS8wRXlRZndLRUM4YTJ6cGlGbFpUY01NWXJXVmd6S0RvaEtSMEJZQXcxMEpT?=
 =?utf-8?B?SFN2TXorcEh5VjlZZWpNNVJzZlZzOHZ6ZU5iOWt4aG9nNyt3K2RYeUNSMDJX?=
 =?utf-8?B?U1ZkRXczUW1wek5iVm9kSmMyQnBqS3pEazdscFk4WVByYkhjK0hnSUkxMlZj?=
 =?utf-8?B?V2EzSFNwbmVENEVtOTdBQ2ZMY0FEM3IvNjE2dE9TcHJDTU1CSE9jUzFKelF2?=
 =?utf-8?B?c2trbERXOGd6N29oNTYvYmtoeklncFJuSUZnMldLelFiUUJNd2JhMWltc3k1?=
 =?utf-8?B?dzVleE1iaUQ2d2xndmloODhwYzM5anRzWk5uNnUyZUJ4WE5zbFh5dFRybVBy?=
 =?utf-8?B?Q2xodHVNVjBEVUhwdGlpemVYN1p6R1d6dzFBc0pKK0J0bU5kZUVLbkljd24z?=
 =?utf-8?B?M2lkMFRYdm9JWFJoSnNYVjN4L1VFbWEwK0xpcXZoZVR3UTlkS3NNUHZueHpX?=
 =?utf-8?B?ZUc2SlRmM0FvdGh5cXhHTjZZY0puVzF3Ni9vMytBZkFRZkVBckpzZUJIRCtU?=
 =?utf-8?B?OEZISStBektrQTFLOVlnNGJBS0Y2SVNVbGh0YkZMUlIxVW51MnVsUk0rSDAy?=
 =?utf-8?B?QnE2UUoxQmRTQjhDREJuQWJIRm42WGhGSzQxSkZEUkRKeWVoU3VsRFRWa1pY?=
 =?utf-8?B?UEhpcFNJL1ZiamFlQVFUODRSajFocU90dkdZOGg4VVovSDdWZnYzRWNCUGRx?=
 =?utf-8?B?T1NBMklVVGc1MGZxZ0ppbjYrUFBaRnBIN2ptbjJXa2Z1MWU4YTJUc3ZqckZD?=
 =?utf-8?B?ZWEwbVhwSHAxdGM5UjhjdVBKcXNRMi9oRGNmQ2dYZnhORjhENjNWWHJYQWdk?=
 =?utf-8?B?ZDJrWjBSckxxREpiaUtON2JGUFZvR1N6OFI3czhjYmF0a09tVURNZmpWNnZS?=
 =?utf-8?B?aUpIVm9kL2FBb3ZhWndHQkNtejRuZUFGWnJycE1CRXlMYlY2M3g3UmJTaXkx?=
 =?utf-8?B?NTBETkszWU5iRzJyVEl1YVhNbUNESllIdWRJN0hCN2YxWjV0dXA5aG1NSmkw?=
 =?utf-8?B?bnAraW5RcnRPUXoydmN5OVM4YW1FWEY1QnVyd1dBTERIR2tucWhDR2hrd0hG?=
 =?utf-8?B?UjRkV0JNZDVyMVFyblpXM2hBRnBiWmNqRTVFYVFGdGNnUStLYlUrTmpKUEdr?=
 =?utf-8?B?NCtjZjBUd3ZlRGNlOUkyTTk4U0llK2FhVE4wcHhoRlhhRnJZdlZ2TTFpTisr?=
 =?utf-8?B?VUhoMmlrVTZDbUpNeGpwckZDTDYzejd1bVpEVlhSL3pNODN0TGFFb2xKbDVC?=
 =?utf-8?B?Uk4zemphMnA4aEQ3ZjV2VzZKQ1htTldOam92M3p4R3IwV1ZnS3lOOHczTjFH?=
 =?utf-8?B?NVBhVWNIblZNSlJoTk5YMDFGUDJDeEFHVkFtWEdlUEIvai95VzE2SCsxanYy?=
 =?utf-8?B?Z2pEaGFBWTZNSENvbm91MkErVGFvYzR5b1VXL0RsR1l3eDFVL2NrNXhrak1W?=
 =?utf-8?B?anNRTWoyQjlZQzhIUVNFK3Q2MkJ4cFhERHZmaE9Ya3FjYWQwSUp5OTNKWjJB?=
 =?utf-8?B?U0tnMVhmN2p0My83K1R4RmViNGhtaGtPWFRXMXcrTVZuUk5jZzFrcXVHQmFR?=
 =?utf-8?B?MDFWR0F3Vld6UXlvdkdCWDZkY2VyakU1Y0x5V20rajVvUVJTdGNFdXJIQTFu?=
 =?utf-8?B?SVNuS0VhNG9MNlBnZHdTUElBZWc5MVJjNUhBS3F2V3NHamNQckdwNSt3Sm9s?=
 =?utf-8?B?N3UyMDQ2TWIwMVQvYjFDb2tTMHlGNUtrQnBDblg4alk1SUtSVW04cEF2TDdZ?=
 =?utf-8?B?Y2hzZTVKRVhwSlhVRDlzMnE5NGpXbnQ5bzRlOHB0SmN6TzA5NXhValpVYWhK?=
 =?utf-8?Q?yXw1o4D+CMuTkElc=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c30ef4f9-8913-41f9-e4e0-08da283fcbcc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 11:19:29.4537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +dJx4A79vh2ajWMQ06yU/WoMttTGmlbck9s1KRiLRlRtHipAsm3SpUfJWBcP5cYlwvY6TPYu2yOhuQOezSiIKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2782

On Wed, Apr 27, 2022 at 12:57:17PM +0200, Jan Beulich wrote:
> The reference "to shadow the resident processes" is applicable to
> domains (potentially) running in shadow mode only. Adjust the
> calculations accordingly. This, however, requires further parameters.
> Since the original function is deprecated anyway, and since it can't be
> changed (for being part of a stable ABI), introduce a new (internal
> only) function, with the deprecated one simply becoming a wrapper.
> 
> In dom0_paging_pages() also take the opportunity and stop open-coding
> DIV_ROUND_UP().
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 11:21:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 11:21:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314923.533209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfjq-0002YL-O8; Wed, 27 Apr 2022 11:21:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314923.533209; Wed, 27 Apr 2022 11:21:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfjq-0002YE-LA; Wed, 27 Apr 2022 11:21:42 +0000
Received: by outflank-mailman (input) for mailman id 314923;
 Wed, 27 Apr 2022 11:21:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njfjp-0002Y4-M2
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 11:21:41 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 34bb57b6-c61c-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 13:21:40 +0200 (CEST)
Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 07:21:37 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SA0PR03MB5402.namprd03.prod.outlook.com (2603:10b6:806:b7::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 11:21:35 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 11:21:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34bb57b6-c61c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651058500;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=YZdDvLvzrBoudTZN6i9OlsFEJmcT2XSPB9LkQp4UyNA=;
  b=hu89QPd0LUzkWP3Jo9C0hqIjoBNtz6Jb2dPxgxr2PkmSFPPltLRrJEnd
   VsB09L9Vd+1LcEpeat7mzBqCVOJElvhdGB9pwmNZYgIGpfRxOeh1RPqk5
   qnjFql1tpUBAP/FvovF3ci/UiUEltnENJzyWFKu2qPSwLdQRzAQSjeq1o
   g=;
X-IronPort-RemoteIP: 104.47.66.42
X-IronPort-MID: 72485354
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:A2MWLa0G9B2o/kiUvfbD5aZwkn2cJEfYwER7XKvMYLTBsI5bp2dVm
 mUWC22OOqmDZzH0LtpyPNiy8ksHvpDRx9NhHVNtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy34Dia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1g7qS5VS0UIJfoo6M9XCFnSnpSYK9/reqvzXiX6aR/zmXgWl61mbBLMxtzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B86dBfmQjTNb9G5YasRmB/HRa
 tBfcTNyRB/BfwdOKhEcD5dWcOKA2SOjI2AD9Q79Sawf2FaJ0iYq+p7Rc9/PRoOvZudSuB2xn
 zeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL
 E4Z8TZoqrI9nGS0SvHtUhv+p2SL1iPwQPJVGuw+rQSSkKzd5l/DAnBeFmIbLts7qMUxWDomk
 EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw=
IronPort-HdrOrdr: A9a23:TnfUOKFLXMF+hPJwpLqFepHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH
 PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w
 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q
 6xGm9liQ==
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="72485354"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a+9Yi3xBLwOKf1Hxvnx+8qRMBedHgEu0cCIg+8BS7q+qC/fuTl46ULgb1SCk1boV5RQ6v1Dv274VBRTVZE/Kyc/m2ESvIaizY2P+SkCjC+LFAeK2nySXD/E8oTaJnYcneFOj3+RIHuLeFjGGxO+sDcVr/U36jEeIEZwarvtTFv+MIIqQKA6rS9wg03G/hDOxZS+4bPhMIstPnae9ziOgymfGu/oXEUx1HiAuSzEA72U0Q0Z3cQuUsXYyNFt8t9bdUw9Aa0GAygxrSED6VpEBYuoAkD6T7lWEXnXfdHtgmUiZPFyIUwVxAiA0wIHfu1OZnFB0ArCXVtXt8DDNfrZJvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CLTZUAFDLMjVQ7Q3AcHgPPwPN0XA8/KzsCebQAZWL1A=;
 b=RBsORbcBMFjYMH+VrLfjAfVmQTYbroPu84GB2yXWSgyE49QdFSXwh/B2R3M+G742olkmrsIUlxTNoyNH2tKRpwagLaw5c4sIEX1yphUa+TptVxW4M6zeCwC3tIvjTtFhgAwSuNpDR04Zhe6mSOls1AOHWZRzTjJoFjMcbSkg8c/BgeFDKN1jCLxe0Pm0JReJXn9xAcaEj2Lw6WmBpKxgPjmpLgXZMq2E6ejzPH42Q6jecYINUCi3E9YnKwcj1lwx7mx2r2n1IzwhaGtr98ZjstneB0o47/Eprad1DYbeQ9F0bilPclUHZ/S4UR9d3nBP+yfSn8Fd5HqTcobYqfCGZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CLTZUAFDLMjVQ7Q3AcHgPPwPN0XA8/KzsCebQAZWL1A=;
 b=F67Cxi/qX+hCkkw83bQ75IO/GawEXgdwBzm7CsbjGWlk6O1J9gjC/cEc127XU5eaFbl/DRhEMyJ8792JZTuusHqHhLCyHUV9nJ4tvKcBdBajDQSzr7BtoEdtHKO1Aj3gia0tJGMRtXJHzs5xPKnlxUAq8DvmumKnZqrSpnfqsjY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 13:21:31 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/4] x86/mwait-idle: switch to asm/intel-family.h naming
Message-ID: <YmknO4Bf2eEzbqtu@Air-de-Roger>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <974cdc87-cae1-2c5a-4c3a-98c5d98a5425@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <974cdc87-cae1-2c5a-4c3a-98c5d98a5425@suse.com>
X-ClientProxiedBy: LO2P265CA0433.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:e::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d7878f7e-a559-49f6-9b78-08da284016dc
X-MS-TrafficTypeDiagnostic: SA0PR03MB5402:EE_
X-Microsoft-Antispam-PRVS:
	<SA0PR03MB54020A038DE551364A4E9CF98FFA9@SA0PR03MB5402.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	idFbyzGsn5X5ys+L4NqxqcXI+/0gxvHuiQghPNry4biQcfTZDJKTYjHHA2xnWyiFfnV/nhtyhQPDAttUWla4Vj1EAeJU1E3TzI9NUYf8KGHvzT4z6zE//Gmi/7GrMM3eIplG22o/Isvf4EP5bV99wVn3tDxCUsx0jRAL20yClSobpe3hEhi8gbHzPqAUicARfz3qWc00hrzvtgYBdh7ZzxYDGciJs2F1WUAV5QgsdMwiFob011Fzx8gw5ZeqJCzi8+axUp/9Y2ppzERJLISpKl97txmb2Cw2aeZZolfDN+EBcX3ScjTR3YdRoPF59KT2HDP7t/GMznCoFXkjISJ5B8zQkZLMI3TmB5h3KE5JN1rsRUb4ALaxHDlmmLRLEycV74vyuhNMYkS9eTqwrZupbhYFoxTd6/uBHxBiYIV0xqlLGPo6sBJafRJ9FB56cD5MpOwTH9S8yR5xL7dYTr9MDbFcoGCeqbhZupiPlAifEuVGi/XxuoDbR1ipICYAf7P2z/uxEBEie2STAWAIWxc1VhRPSi1q2h7EKoj1AM1YgBUyIsxypEe/s/Ht43xpxJIIhjAz+306UuP0OVzNlTgqnnZpsbIQXM9CsmhAo+97QmkldbxWGlFmzcRjggF2BsIUnYJqr/tElZBsy4/K+jSskw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(66476007)(33716001)(6506007)(26005)(66556008)(66946007)(9686003)(6512007)(54906003)(6486002)(316002)(6916009)(86362001)(508600001)(82960400001)(186003)(38100700002)(83380400001)(4744005)(2906002)(8936002)(85182001)(5660300002)(4326008)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVBpeXU3OXp0RFBJd2VTS3hLYmsvdks2ZiszV3k1S01RRlgyWTdSM2ZRVEhy?=
 =?utf-8?B?WHVaSVJWT2hoS0pidXorQ2pUdEpkNW9IYzQrZ2IrU2dUN3cvdFZvOU5nZ1RI?=
 =?utf-8?B?RTFwV21YcWVxQ3BQQzhJQmtISStwVlkxS1V3b0tuczRTL2NzUytDSnZaaUFn?=
 =?utf-8?B?VUxaZWZIald2Mk5FOWFRY0hEdkowTG1UUWNmamhueDg3U2wzQy9mMUE4dHN0?=
 =?utf-8?B?UDZDY2NwS1h5cmozMlJpUkowU3ZoaVRIeExjSm9OM25vRTB0UnBMc0F2QkZB?=
 =?utf-8?B?RHAxMUYyZXkydmhHK2JaSitiVTZ2dlFnSHRCTFJMdjhsTEp1Vk44dTU1azAr?=
 =?utf-8?B?ZW1DeWM3WkJOSmNRbVZ1MzM0MHNUMC9zWFF6bEpqME1iTDNPNU00Zll4MVRp?=
 =?utf-8?B?WWFqRVYxNHpPRnNKbW1HRDl3R1g3SFBQWXpzamIva29yMjhyQ2xPMFB4NFNR?=
 =?utf-8?B?UVlIaVpkeTErWk1jT1RNOExYZ1gwa1N2dkZzNnc4WHRpWk1RaDFTYU1YeTBS?=
 =?utf-8?B?R3pSOCt5WFhyY3BuQXlJcVkvZGFPblJIb2NHWHczYnNKbHVMbStTNzlZM1kx?=
 =?utf-8?B?ZVRUTGpXZitJQndzdzlWMnZJMVJOVTd0L2pFUlJwQzJ4NHAva2FOMXdDQWJD?=
 =?utf-8?B?WW1La21mM21CMVY1UzhoVHpXWStYc29XVlJQK3paVTE5M3Z0aEphNVdjUkR1?=
 =?utf-8?B?UkFsWWk2ZVZ0UXk3bGt6K21NM2I0NGxsL0pVcnBybzlTdG5xa3BJdW1sZ3kw?=
 =?utf-8?B?N2IwNnNHcG5zQVVOV2gxc0p6RHFCY3E2aGU1OTJUdEdxbk1NeVc4cENTSWM4?=
 =?utf-8?B?WkRPR25hNytLT1loTCtmMDRCYW5NSWpUeDNnNTVYYXpVZm9JSGNEYnNET0pv?=
 =?utf-8?B?dWhhZllLTnRBT3dFbXJtcnNtVGdtODFXQU5vem5rVjRPcHVPYzFoK1ZtVzlJ?=
 =?utf-8?B?VXBjSWgvcW9qd0t1THBTbmYwQkdFdXRKdGZHd1F5anFDUytsVmtXZ1lUNXZw?=
 =?utf-8?B?RVdwUUNkcWVoU3cyMmdQaEFWVWNmUXZCZnVrcExhVmc1ZVMzL0tmZ3hwSi9Q?=
 =?utf-8?B?d0dUVUx2eVd6Q2ZIVitqZW9uSnpNY0RjQ1k3VDd6bTRCWmV3Y3dpemlJZUdo?=
 =?utf-8?B?aUFMTDB0VWtoQ0g2eGF0UlFqNHRVNExoTHo3eXl6MnhyanBndmR4M0oycVVq?=
 =?utf-8?B?RkpJbWlmNHNaZzVNeHZlL1BGMmh0aFdhbiswdjA5VGFvcU5CVFJ6U1pUZnE5?=
 =?utf-8?B?MzdPckRaSnVLOUcrRVFoYTd4djFISHhLeDRBVy9jZHhsUzc2WVFkd2J5ZkxB?=
 =?utf-8?B?WnRBTG50NERNc2hWMG1uY2hIdVEvT0tDQmlUejkyMDZ4WHJqNHRuWVk5VWNK?=
 =?utf-8?B?eTY5RUJlTDByQ0RUeGczSWZVR0pBTVJlcHZEREJXeFRjN0JmT25rdjZlem5R?=
 =?utf-8?B?QjE1WHNkNzBaY2pQWEUwelFSUFUzdmhBSEVWd0tSN3RuV2E3akhsZ2V3MGdR?=
 =?utf-8?B?MkRPVEszQi9uVFhBaVIxeUIvblVRbHB2aVEwdnIyUU9VTmJZNnlPc2VvRG94?=
 =?utf-8?B?Ujl4cW5RQkFNSFpLVVp5bGt3c21SbTlhTktYSlRRT004VW5JVUxOWjFDcDIy?=
 =?utf-8?B?MVlJTVBKQnR6czV1aWNtOUdjRHhBcWFKVk94MEQ0NWcwRm1NOHNhdUlKUHNZ?=
 =?utf-8?B?VVZxd2I0VWl2dU5vYkt4Q2FPRHNMMlJNY1l2K2MwZEFQbURqSzJ3L1RZMGlZ?=
 =?utf-8?B?VkZwV3N4M04za01JQmduV1VWMERvYldnYVE3azFVVTRidTFtVVpJUUZQOEFF?=
 =?utf-8?B?WnIzYVk1S2tKbW5zNkQxNTAwQXVKQW9TQVVOWm4velFXbFBIeWtPKzdDQ1hm?=
 =?utf-8?B?bStldVpnRDVxTTg2MUwvanhFVkJrTGpNR0k3YjhwanRDd0VBd1IxbXpBSG54?=
 =?utf-8?B?d3BjcVE4Vkl2bFZzL3ZWK09nWFNDR1VNcDEwTDBZbWI2N2Q2Y3hncmhTSWp1?=
 =?utf-8?B?aGRNcVJ0UGhSdk9LcDJzK1NMYTRqZGQ0T2JHa1pPY2FhN3dHTXBrdE12ZHpk?=
 =?utf-8?B?Um5oZWl6NXRiOTRaVDJjNkpIOS8wVUswNlRxbzQ2VFZYb0RHZ20rYnhhdnl0?=
 =?utf-8?B?emFuRzQrR3BURHFYaEdkQjRiMHlwZDI1c3p5YXZEVDh3VWxkV2RJLzFHNlZh?=
 =?utf-8?B?SVdud3V6YkZzL0NzNDFOSTRNd1k3Y1VhNnc3WjZsNy9vMXNWRVhhQkxDTnow?=
 =?utf-8?B?Yk05cXhINmpsdFpQSDg0Qmg1RkRjblVlUlFSQmtHMm5vLzJjWnFJUlBXcWFM?=
 =?utf-8?B?dUc2K0d3amFrNTdnYUhVczRPVHRldC9TcHBLWU1BOW1Ud0c1ZTNzdjBsVzFP?=
 =?utf-8?Q?gP4fGJuY619T9ZG8=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7878f7e-a559-49f6-9b78-08da284016dc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 11:21:35.4170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FK3gy5fIvx5XvMhtUoGVuPl1tNjpTxgT+eFxXYLXo0wGSJubq2ROkGA0hOROt2LUvKFHllnjlRkkNU1g9TZGSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5402

On Tue, Apr 26, 2022 at 12:04:45PM +0200, Jan Beulich wrote:
> This brings us (back) closer to the original Linux source.
> 
> While touching mwait_idle_state_table_update() also drop a stray leading
> blank.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 11:25:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 11:25:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314931.533219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfnB-0003CN-8A; Wed, 27 Apr 2022 11:25:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314931.533219; Wed, 27 Apr 2022 11:25:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njfnB-0003CG-5F; Wed, 27 Apr 2022 11:25:09 +0000
Received: by outflank-mailman (input) for mailman id 314931;
 Wed, 27 Apr 2022 11:25:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njfn9-0003C6-Vr; Wed, 27 Apr 2022 11:25:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njfn9-0004L6-U7; Wed, 27 Apr 2022 11:25:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njfn9-0008MU-Ja; Wed, 27 Apr 2022 11:25:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njfn9-0007yM-J5; Wed, 27 Apr 2022 11:25:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DvcOG0eQXOD3iMf9mNlqHvR9qMXw1kwULDw/hcla4Mw=; b=wFgCl2E8qEqagJu8Wj31QSAgL8
	2YV07ptlKWRH7xVBQA6l0Aa3/VGCelp0wed8zaz0jyHASBr43tXhL4ldwKNUTZJsAganAFeY1er3x
	5PHK4BbZY2EY/bmmKrHo5lzj5Fm4KW2XLTiXad4XjN8YAPE71tDK1oU5LhwgIOdRlfzg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169778-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169778: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 11:25:07 +0000

flight 169778 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169778/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  660 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   32 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 11:40:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 11:40:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314942.533237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njg1d-0005NE-Ox; Wed, 27 Apr 2022 11:40:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314942.533237; Wed, 27 Apr 2022 11:40:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njg1d-0005MW-LY; Wed, 27 Apr 2022 11:40:05 +0000
Received: by outflank-mailman (input) for mailman id 314942;
 Wed, 27 Apr 2022 11:40:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njg1c-00054I-9i
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 11:40:04 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c5946bc8-c61e-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 13:40:02 +0200 (CEST)
Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 07:39:59 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BYAPR03MB4056.namprd03.prod.outlook.com (2603:10b6:a03:7b::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 11:39:58 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 11:39:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5946bc8-c61e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651059602;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=eNBRGcRxM+DQ2AXmxHr+lDpn1AbxrvkOAep6hdog9PA=;
  b=gPwHKp2Qkh/qsQilFOZobEviJhFMcjmSeniw9B2sbrre/wqkhBDmOL4n
   De64UsAU6Bj9fuwyUIV8JkJxzorAKjqS8jamZGj+7nA2om3fo2iIAsemS
   6NqopLs+7V/E+LbAnDbP/oI6+g167ErHVJeOnpkFhdT5eYP9D5yKsrbeG
   M=;
X-IronPort-RemoteIP: 104.47.66.46
X-IronPort-MID: 69914283
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ep2mhqgGLUTjz0IGOMnBAefSX161FREKZh0ujC45NGQN5FlHY01je
 htvUGrTOfvZZ2Wmfdh2aouwpx4AuZLXn9NjG1E//Hg9Hiob9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nT4
 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQMoBPOPquYbbxljCyI5EPBh447oOHfq5KR/z2WeG5ft69NHKRhseKgnoKNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMu4EegGlYasNmRJ4yY
 +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUG+QPM+fBnuAA/yiRNz7PGaNSMJ+WVBtRkhmCm9
 lzW5GDAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO
 0ES4jApr6U56AqsVNaVdwK8iG6JuFgbQdU4LgEhwASEy66R5hnDAGEBF2RFcIZ+6JFwQiE23
 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPfdYgHdcd0o/
 w23kQ==
IronPort-HdrOrdr: A9a23:68zpQ6EUQxIJa9jXpLqFepHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH
 PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w
 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q
 6xGm9liQ==
X-IronPort-AV: E=Sophos;i="5.90,292,1643691600"; 
   d="scan'208";a="69914283"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eVBy74tPO57BVaSDTptol90ItEvFbmjnoXBI8RXlTGFVu4O63S8+DS5DvoxHyDz1/izPCWakaQzhpfWbj4dHtYhaIYogHF1yJOLSudPCDjtStxXlJmDaomKoh0J3O291yoiFzYGYK4b/Y6Kd0uvs8ALamZ9AJ9rws99qybKlJJ+nw4YexMrS2a+LUmR/cJMUHUYz1REI+7tGz0MwRLE2QMEn05LZV6h0iONWYKxFNDdpzdkBn6Jb8D/zinp4tswc69S6eklXIND0sdnCFPm2Trw62dswsxy3nFetmBtbVPqCB/VkQVvb7zE8T7c7V/JFEmy2EcLrsikpjWvBuoLcMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oZrcf9kLv/d52n7gJCUeGAp31IHwN1zUO+wj439yMcc=;
 b=gW/TRey1PhnOYsmFuIRhf257vSWLyyegcD52RcCUJXj0ksEwFVtDT+oEwCyMxCtY2/W+mluiBhwKc4gtyAf8Qf5CoCHhN8fLwGbKXZnzYe8wKD9CyQ/LqVVpmSkqEbfBfiL/pzvFbl1oNZgIqSXpbXDXtaA9kp8tSvoomZVP+gCiI3RiKCK5quQqRF7fu8RiE+4NAgwXStu1oyD28z+Mtcq0YmL72XCgxV7o2IrB54iqTRxvbjesiT1kUZSkTrVCg+9wGckY9Kf5a8nyO/zXNuwss1td6lplLBMG0rvIdYyaHJPWLXKzag8v3rLnOX9ffMnN+Sl9SaM6GaWsBVJTrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oZrcf9kLv/d52n7gJCUeGAp31IHwN1zUO+wj439yMcc=;
 b=JDafCfE6MtyDRFi+nfzWNB02i+gcqBm5Yk7AhiIv+VlB2f9D0/LHlElyqGpuwpy4wyRaNzSRKN9l+c5eT7xKpWArMNyTwi2uJIaxB/ccjB/onDl0fhRAbsxDctgSCXsJH0G5MUzU3SWUR+p5y8CU3PvmV0L0uJNQLgN9alT5UZI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 13:39:52 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/4] mwait-idle: add SPR support
Message-ID: <YmkriORufeJv6Pel@Air-de-Roger>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <722833a9-e6bf-1a63-e866-aed0648c785e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <722833a9-e6bf-1a63-e866-aed0648c785e@suse.com>
X-ClientProxiedBy: LO4P123CA0142.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 770b7061-10d7-49fa-20b2-08da2842a7fb
X-MS-TrafficTypeDiagnostic: BYAPR03MB4056:EE_
X-Microsoft-Antispam-PRVS:
	<BYAPR03MB40564A3E745896A4B8BA3FEB8FFA9@BYAPR03MB4056.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A+kVZE9tPsWFnayCvq09b3WVidXLibI4O3mGEGfzupEq/9P+jtzeDfpZIeasBA/E0EMHaySZwIErm51mz7Dd9Hvkk/XLjdWMEyFn1Pxa+9+m36huPDFwmHE2Hha2Zc8vSBqrlC2vjp2lHwrCu9Tq1+xu1OeCvTbSdXIpCH12F32KbCrZRyPy1MJt8aK4+pPqUsuKMRynsq9GC5Ud8fhs4P4Vo0r1jg/DPE95WXaTuO1eb1wyzN9e1L+r/KuIgwSxSt7lNRzXRR4m+QjZXs0f0Yi/kS+zErJ/HG2mI62TdgNQgujo25xHDSEkA4UOR7xGKYj0SxrzATmxo/qv6NSG5WxaCvm/nLigE7fgHVqAtxxXp5JrSQW8YGV8NV5LwsWNe74dFpfU2KhA8PKbBuuXK8jERbKeqWng6apotShMewk+LYEdALDaToNNkrz29zGmZ1bhgBKiCmhJawPZUyWkgZqxjD8XWxFVUCn5Vkk5p9edic88Ef3qKMWyX+/xcDh8JvjGIZseZiUi7krzfvl2LsR1bd/4qoJgX/hBFZ1I4EsOhzORruRJksX4nc1wiCdJrx8IygqqkFV9aoaAkl9H3htwJEzmdeQ/fW/EXVfQEVaW8VGS7h0di5LY5WRoF5tN2pD/kUEwTgaBj+CdIjt6sA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(6486002)(508600001)(6666004)(38100700002)(66556008)(66946007)(8676002)(4326008)(86362001)(66476007)(33716001)(82960400001)(6916009)(54906003)(8936002)(316002)(5660300002)(26005)(6512007)(83380400001)(85182001)(9686003)(186003)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y0YwcStOcE4zME5ieC9IMm52SnZtWHFvYlpGNVY2YWJwL29pbmdYV3M1THVv?=
 =?utf-8?B?KzVGS3RHeSs3b2ZrbDBSd3hvVHFVanpzTGdRYWhKMGo4emV5M3V0MVVxK25S?=
 =?utf-8?B?NUtVK1pSWVlhNy9JSVRhaGJ0OUF6ejNmYVowd3k4M3dJaFh5Y0loU3BBSW54?=
 =?utf-8?B?bHpFbmovR2tqTThEUW0rUWo4bVdSNEtHa29RczYvUnNSR0xta3ZOcnBCbk1F?=
 =?utf-8?B?aUhGbXZDbW1tcEJMYW5PeWFhelNFWGhrNE16aW4weGxsSlFjZFlpUUpWbFNl?=
 =?utf-8?B?YnpUU1JXV1VGNTFCSFpmMkxDQm1GWUlHb3hrV1ZaU3VYZytDTG12czVuVTlm?=
 =?utf-8?B?VUVVV2lYditaOVRGN1lyOGVjZzdEbmtkZUwvdVZ2R2FGTFFRa1NJSlNtSFAz?=
 =?utf-8?B?TXlqcExMa1lCYjJBcVczQXpKc2JjYlE4SmZnQzl6U2IxODR5ZXZpYWpKK1Qy?=
 =?utf-8?B?THhaYUdOcVNNWmNBM3Q1aVplZFZjay9FeGpMMXNNR3g5L2tWUkhId050WTkv?=
 =?utf-8?B?NEtNc21GZVNBREpxTEEwMXNRelFkUUh3RGVldHhjNmN2YkhhU0Nqd3BiNDhH?=
 =?utf-8?B?M2JOSjJNUW5vZUoxVVdmR2tnVjk3SFJRVDFDc25IZ1VSRy9yY01lK1V3Vmkv?=
 =?utf-8?B?bDJzeG8zek1NR3Vhb2pCVUQ3M25iSCtwblUwSG43V1pHU1N5YkFrUHJiZDRX?=
 =?utf-8?B?SnVsaTBaWGNUeHhKeUZjclJBUU1hdzJyVzBTdHJ6bTExcVU2Vk1aUzVSNGhM?=
 =?utf-8?B?cHFpeTlFL3ltRkJuSEZuZWZSaTdTcC9tbWJ6aXk2VGNCalU5dGhDN1RKbXUw?=
 =?utf-8?B?NGNIZUwvSkdGT05sS3RWNmlwb0VUQzdFQWdsdzlnTHpWQm9CbTYrM3JaWFl2?=
 =?utf-8?B?ellvS2t1NTcxWnVpUGRXeFNuanlLNysvUXBpREloaVhjc0pEbTZjYkhUeER4?=
 =?utf-8?B?RFJBWHZkUXd4SCtBa3lZK05uWURnYmJzdHNsSGg2TkpJWFIxQ092RHYraVNO?=
 =?utf-8?B?b0VPOVpTOFNJN3RUY2RTanpWQVhReHAxcHAwTklkZHZCRkdJN2xDRTh1L3o4?=
 =?utf-8?B?RHN5Ky9tdEZ4TlN0a2lPUkMyU01TeWNVNjNGa09NOWJlSU1DUjU3R0xoZDBT?=
 =?utf-8?B?Y3A1Y2NBRjJXOThaSExhQnJRbUNzSjBXa2taSUkrYno5Sm9nOWxHaS90WGRN?=
 =?utf-8?B?T25uS1RIWkNtS0haUlgxTGsrZ3lWWWFESlUxQ3VlTmVuM0p4ZUp2TjM1d28z?=
 =?utf-8?B?dzhsaE51NHRSc0IyeitUMWUzSGNGS05tYWRtVk5CZmF1TFIzcVR6L0cweTlD?=
 =?utf-8?B?dGNJdFg5NTIrSllQVzRsSGV4S21NVWp4QVR4VE9sVE9IRndFNHgyOU9tYjlV?=
 =?utf-8?B?dDVQbnRDbFNXaTI3Z3NYRHJmeUx3NTM3bmRmWlN4TXlVZFFhWkFuNWRXQUQ1?=
 =?utf-8?B?M0RoUzV5K2ltYWdiT0pPbVBLZG1sRWlHMStvQ0F6NmtTMXhTZG14UXBvOVdh?=
 =?utf-8?B?Yytqc1RtUEJTWW5NZ1pNWm5JVWcwT1ltbzBpa0g2ODR5RlgxWEdHbVpTM24r?=
 =?utf-8?B?ei9BNnZBUVF0ZjZ5c3RRK2FhdVhEME9jYlRPeDhadWNNWEJKbFptTjZ2UEFF?=
 =?utf-8?B?bXlCQlBEUUlzS0poZVcvK0JaOWRsRG5iS3lONmZqMFpKaVFuWk9OOXZGNXdw?=
 =?utf-8?B?K0NTR3lkS3FYcnk3enJOUW9DREdrZWlwSXA2M1JYbVN4eW9TRUZ0d0sxVzFU?=
 =?utf-8?B?a0tXeEJVbFY3QVpKSjF0aG5STlN3V2R1Wkg5UCszSTNTNkZMcE56S0d3aTV6?=
 =?utf-8?B?eWZ1dHV1NVI2R1lCNW1vSXY2VTA4WmZndWdTVC81aXhaZGFhcXpGSE9ob2g5?=
 =?utf-8?B?bURmbDN6Rk1nUDQ3UmVtb0lLbnRlQ3lYNGI5Uzg1eHFvSHhRT1hNUURnVStZ?=
 =?utf-8?B?YXhkQ1M4Zi8ydlBkRHVSUGtVSzFkanlXTW04aEhTZUR0Zld4cVVvaXJvcG5q?=
 =?utf-8?B?YitpaXVaRVdPaU16UU5XUXB5R1pnaisrMjFVT1hNU08rRkhtY3pPTjV2VjJD?=
 =?utf-8?B?dHV2R2wrWk4reEVaM0RzWnJKMkI3WTdwdUoyY011MVhrTnZuWkNWMHl0bVlk?=
 =?utf-8?B?TlkwbnY5UnVJbmt3UytlSDBoVEgvcW1tSzVNV2dnYVZrTE5YUnFETUx6Uldh?=
 =?utf-8?B?NjRSUmVlOHl5MWVMWEFvaWVCcEFUUGdBUFJqQ3BUZFhyQTJXRHNmZkRrT3Bj?=
 =?utf-8?B?ZXhZQzZ5dmxCRHJBM2RvZ2d0Qm1lRUk1Z1JBZGZiaWxtdFR4YmtqcUEySEFn?=
 =?utf-8?B?WmVMSHlUaWxNQkdMTSt2MC9pSDFHenE3Q3dVOXJYaEpiMklTWkVDVE5wdzF0?=
 =?utf-8?Q?T2wndjc1+IkdL55A=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 770b7061-10d7-49fa-20b2-08da2842a7fb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 11:39:57.9739
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AlLox8+Pwh4/BO2CABKgBRGHnZwlVFLGDbthUxMc1lPTH+gw6ZPvk6kqNPbE1YVxjo9bIen7OTgXnRylFv4F2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4056

On Tue, Apr 26, 2022 at 12:05:07PM +0200, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> Add Sapphire Rapids Xeon support.
> 
> Up until very recently, the C1 and C1E C-states were independent, but this
> has changed in some new chips, including Sapphire Rapids Xeon (SPR). In these
> chips the C1 and C1E states cannot be enabled at the same time. The "C1E
> promotion" bit in 'MSR_IA32_POWER_CTL' also has its semantics changed a bit.
> 
> Here are the C1, C1E, and "C1E promotion" bit rules on Xeons before SPR.
> 
> 1. If C1E promotion bit is disabled.
>    a. C1  requests end up with C1  C-state.
>    b. C1E requests end up with C1E C-state.
> 2. If C1E promotion bit is enabled.
>    a. C1  requests end up with C1E C-state.
>    b. C1E requests end up with C1E C-state.
> 
> Here are the C1, C1E, and "C1E promotion" bit rules on Sapphire Rapids Xeon.
> 1. If C1E promotion bit is disabled.
>    a. C1  requests end up with C1 C-state.
>    b. C1E requests end up with C1 C-state.
> 2. If C1E promotion bit is enabled.
>    a. C1  requests end up with C1E C-state.
>    b. C1E requests end up with C1E C-state.
> 
> Before SPR Xeon, the 'intel_idle' driver was disabling C1E promotion and was
> exposing C1 and C1E as independent C-states. But on SPR, C1 and C1E cannot be
> enabled at the same time.
> 
> This patch adds both C1 and C1E states. However, C1E is marked as with the
> "CPUIDLE_FLAG_UNUSABLE" flag, which means that in won't be registered by
> default. The C1E promotion bit will be cleared, which means that by default
> only C1 and C6 will be registered on SPR.
> 
> The next patch will add an option for enabling C1E and disabling C1 on SPR.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9edf3c0ffef0
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 11:58:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 11:58:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314949.533248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njgJF-0007A7-4c; Wed, 27 Apr 2022 11:58:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314949.533248; Wed, 27 Apr 2022 11:58:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njgJF-0007A0-1V; Wed, 27 Apr 2022 11:58:17 +0000
Received: by outflank-mailman (input) for mailman id 314949;
 Wed, 27 Apr 2022 11:58:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njgJD-00079q-83; Wed, 27 Apr 2022 11:58:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njgJD-0004t7-5Y; Wed, 27 Apr 2022 11:58:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njgJC-0001Kv-PJ; Wed, 27 Apr 2022 11:58:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njgJC-0006Er-Os; Wed, 27 Apr 2022 11:58:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ad/TlVQ9VAgCJtjBDE2I4hyR/nMjC5Q7tGHHB2O/iQs=; b=Fl0/wqWEiygNdV+w/TQ/o9isGB
	umtuOO6z2d7ZCp9UVNTbpGeqvVqnDK6z4MRVpnnSnkKFqLhfkrUg3mhEOkgeFT0jo5SvGisgjTSgW
	/gX4/9ZXJ/9uwBPWSdcrPS1/WvXJfl/EpFP5faI/CT51ZZMei0r+kAeGjk3qUOl5Ocmc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169773-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169773: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=163071b1800304c962756789b4ef0ddb978059ba
X-Osstest-Versions-That:
    xen=3f5d61466345ed2213de2d7e391b6cd6d4b86015
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 11:58:14 +0000

flight 169773 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169773/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  163071b1800304c962756789b4ef0ddb978059ba
baseline version:
 xen                  3f5d61466345ed2213de2d7e391b6cd6d4b86015

Last test of basis   169748  2022-04-26 17:00:24 Z    0 days
Testing same since   169773  2022-04-27 08:01:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Tamas K Lengyel <tamas.lengyel@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   3f5d614663..163071b180  163071b1800304c962756789b4ef0ddb978059ba -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 12:33:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 12:33:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314968.533262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njgrI-00034B-8W; Wed, 27 Apr 2022 12:33:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314968.533262; Wed, 27 Apr 2022 12:33:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njgrI-000344-4P; Wed, 27 Apr 2022 12:33:28 +0000
Received: by outflank-mailman (input) for mailman id 314968;
 Wed, 27 Apr 2022 12:33:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nU4i=VF=redhat.com=thuth@srs-se1.protection.inumbo.net>)
 id 1njgrH-00033y-4C
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 12:33:27 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b3ffa49-c626-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 14:33:26 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-371-pUyrpyLNMPWNyG7PDLHo0Q-1; Wed, 27 Apr 2022 08:33:20 -0400
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com
 [10.11.54.9])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B808803D4E;
 Wed, 27 Apr 2022 12:33:19 +0000 (UTC)
Received: from thuth.com (dhcp-192-232.str.redhat.com [10.33.192.232])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 4CE5A5742F4;
 Wed, 27 Apr 2022 12:33:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b3ffa49-c626-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1651062804;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Qet0lokKOWtqzVKSO0FqVbZx/S8u2uKt2DstxZ7gIoo=;
	b=Yg8PmfxUVhjy+9RhBwDWjmzpdqmfZGHKlYMixnUlPDpogbqMayP0+fjOgZ5mwjOE8Gj2C7
	Y/UTqWAbyaS4lJIDhOE7DZ0x9so8mvylTINtpDYJ0oViSznRklfCvBP/tGPFTLnRTPV2ak
	orUzqvf+CO7GFAyVoJ0xHH4zIff1NXg=
X-MC-Unique: pUyrpyLNMPWNyG7PDLHo0Q-1
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kraxel@redhat.com,
	qemu-trivial@nongnu.org,
	xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in
Date: Wed, 27 Apr 2022 14:33:16 +0200
Message-Id: <20220427123316.329312-1-thuth@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9

The 'xenfb' parameter for the '-vga' command line option is currently
always enabled unconditionally (since the xenfb is not a proper QOM
device that could be tested via its class name). That means it also
shows up if Xen is not enabled at all, e.g. like this:

 $ ./qemu-system-sparc -vga help
 none                 no graphic card
 xenfb                Xen paravirtualized framebuffer
 tcx                  TCX framebuffer (default)
 cg3                  CG3 framebuffer

Let's avoid this situation by fencing the parameter with the
CONFIG_XEN_BACKEND switch.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 softmmu/vl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/softmmu/vl.c b/softmmu/vl.c
index 06a0e342fe..e26421b815 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -934,10 +934,12 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
         .name = "CG3 framebuffer",
         .class_names = { "cgthree" },
     },
+#ifdef CONFIG_XEN_BACKEND
     [VGA_XENFB] = {
         .opt_name = "xenfb",
         .name = "Xen paravirtualized framebuffer",
     },
+#endif
 };
 
 static bool vga_interface_available(VGAInterfaceType t)
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 12:34:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 12:34:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314970.533273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njgrs-0003Zo-Ho; Wed, 27 Apr 2022 12:34:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314970.533273; Wed, 27 Apr 2022 12:34:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njgrs-0003Zg-DL; Wed, 27 Apr 2022 12:34:04 +0000
Received: by outflank-mailman (input) for mailman id 314970;
 Wed, 27 Apr 2022 12:34:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8dk3=VF=citrix.com=prvs=109ad7ccf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njgrq-0003S8-D4
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 12:34:02 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4ec05ece-c626-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 14:33:59 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 08:33:56 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CY4PR03MB3111.namprd03.prod.outlook.com (2603:10b6:910:58::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 12:33:54 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 12:33:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ec05ece-c626-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651062839;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=jcSWMsu+ye1FmhpUtNcMpYFV8lPJ0FX4pB78h56vxjE=;
  b=XYLIl39nFkF/f+vPba7QOUa9v+wON5HmuoYlnqECaYXDV3QKwlIkqIuP
   mwk5YQfcxz1cs48xX8z1RuUe5vk/HNTnHU3v1AssdNOwJCx+89klBbAMk
   VFb59d74P8q/CgxL+sjLiZI34cE6g9/ETR6/ZwKSoVCrVCzkHGLr1lkeF
   s=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 70441926
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:DkWCkKwBDmmrsItlrkl6t+cBxyrEfRIJ4+MujC+fZmUNrF6WrkUHy
 zRLD2rVb62LMTGnc9snaI7loR5QvMWAzNEyGlRuqCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024fhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl65uNE1kWOKP3huEWdAJmTHtBFK5X9+qSSZS/mZT7I0zuVVLJmq8rKX5seIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtadHeOWube03x9p7ixKNd/Ya
 9AUdnxEaxPYbgcUElwWFIg/jKGjgXyXnzhw9wrJ+fNmuTa7IApZ0Z7JbffeS8a2G8RZhEbHq
 mOa+VjyHURPXDCY4X/fmp62vcfKnCj7UYZUE6eq+/pCiUeWgGcUDXU+V1G2vP24gU6WQM9EJ
 gof/S9Ghaov8E2mSPHtUhv+p2SL1jYHQMZZGeA+7ACLy4LX7hyfC2xCSSROAPQ5sOcmSDps0
 UWG9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLnW0ophfGT9ImFbHviNTwQGv02
 2rS8HR4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl
 CJsdxS2hAzWMaywqQ==
IronPort-HdrOrdr: A9a23:hYs+Uq4q+/bcUjwZxQPXwZGCI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+843WBjB8bZYOCAghrmEGgC1/qu/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXerIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonis2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaQkEyzzYJriJaYfy+Azdk9vfr2rCV+
 O85SvICv4Drk85uFvF+CcFlTOQiArGoEWStGNwyUGT3fARAghKSvapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuKYlGclsRLYkjQpo+VY7bVDHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TpE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZeo6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z44HSKyGG4fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv
 fbAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="70441926"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MZlsvSl40YEISjVcVSJ5Ac3TzvVIznr89U89ZLZw1Sva8kRmysaV0QVfgrV7aoQCcE6l7U1jnrO6rsdjQq3ESyDSWudR47wC2F6j8JA8Otw7b+IZ7Ipc6IZlzVWLC1s1D6JFKGvRvoltlt4HupriagDOnocjqUr59BSzvANCiiCnUkGArXlJLwop3Q6HuFLgT4Q/BP8zhj9wlc1Zepaz1wi935K+1MVw8eOfwJtSS364/u29m3sBXH+zSaLyJj+hq6KaS2zmDh0aZc0TRNNR4Qu2xQFI8H3D7y7BXScr/M1lkF/WmpDB9hb8hNw/hdx8na7xtM1GiiWK233aGRdlrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jcSWMsu+ye1FmhpUtNcMpYFV8lPJ0FX4pB78h56vxjE=;
 b=c1EvqSSrV+y8zJeufToGuYHgEH/vQXi3AzOI6Baa7hLQv4npN4IlwKosLjA8OJaOFTZ/n4pwnXPabT8D3Rm7pCRbshM9/FmzC8RW3ZGfB8mwiCHc9/8z9EBbXUalBQOKoJZCIXX/4FKQxQePeS5td4DtNi1fwvgflH7S/XAWU1j8Z9A0v7B9LU81UkZqN4IBskPXAbr7ulFnnHqlHNJz9woisPdQLI+3En0QMPrwbt8fHQvFkrrtRWgmnDSaMRmCX7NKPhBRrk4CuDEi1dHlno3EcLFzxC/ZtmrM987OXsGxPklD89syX26aIAtAN19hVKJ1HnY6SqLJwRLfGmI7WA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jcSWMsu+ye1FmhpUtNcMpYFV8lPJ0FX4pB78h56vxjE=;
 b=EW+w6N7xLNCqd3w7YU2i3YOQlZuKhZjqz92WOfVZlgWA81e7+ROwE3WPrEM+/pS9ffCv9/IiTNboKL4Ag/L2DPXN/ANgRxIez93YehutUlQ4aBEBS01xwlX24/ll/WkNwdX8kzP7ZyTlSgw0LiCZnUSkPlGVmPPQed+42mgswNY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Michal Orzel <michal.orzel@arm.com>, Jan Beulich <jbeulich@suse.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
Thread-Topic: [PATCH 3/8] gnttab: Remove unused-but-set variable
Thread-Index: AQHYWhwqFegaNlTxvU6FmW06six2Eq0DhsKAgAASwwCAABhegA==
Date: Wed, 27 Apr 2022 12:33:53 +0000
Message-ID: <0c067fff-32a9-0d21-2410-611ec9a2b91c@citrix.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-4-michal.orzel@arm.com>
 <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
 <590d34a8-744f-4170-74a6-1b02013488df@arm.com>
In-Reply-To: <590d34a8-744f-4170-74a6-1b02013488df@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 54984854-34bb-4422-ca80-08da284a30f8
x-ms-traffictypediagnostic: CY4PR03MB3111:EE_
x-microsoft-antispam-prvs:
 <CY4PR03MB31112B4171897CC98DE11FFABAFA9@CY4PR03MB3111.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 9Djc6ODlfPCRpfhFdvu7pwAeAsqDJz3L3EjxZj6sTAKneGHFohOl/ydAOElvhyJscQ+WkeWT+/StkUR+2e+7Nn2LpUnKcqOL7fbFZiIicyoLV4L69vgFOoaKGxtVOzsueK4Sw3DUnto1/uDbxBfCwe7Zc5m4xiwInhV9Gmu5TEZpkcdEkwhCn4abejWSOuzVas82kRxn+boPDLTWAxqUev7qahJQA+vES+J1olS/ai8ns/A/C+7F+C+lSlyxNR7vX2aI8GmdynZG9nJfvaVEhzc4BvFD8KT18EuRYSaz/apP/yVm9o+VopPkO2gtZ0ajyrkfDlIlbIjTBVNf79iKJdEbXZN9BjUV+l77Saoani53Pb/Kwp/xX7enc6vPSlgAyVe1n2y0zmnMD7JrLYwOhrKaP/K1/8uvb60duRrvs5EHLv2fLdMrhKTC0SDt7LII1PTPAYiGyGpjkyhZu3Gef2gVqoS4hO/gLqL1yTq9ocTRhhxaZyzqIpbNKnecMRr1CYYMmKpeepx4Qu1azQ7riK/X7sQBtxdcdrJcEXi5LbSoBllDBHHK6SEqEImzVAmpzjG55lrMcKrYm3+QWeuPNTRun8S2TVrEUvi8766xotmtWRpV2XL33Kh3UDKMifWqI70sFMPT7DkwX1jVZULeCvUwkXsimXMknNuLx2ynj4sVLSROPB+vnAwj/K62nijLy3Z73e48Jqplu9nDITj4I7Ir0OV1UwwxEACtwyY4HKcV7VaAh3imEVc6QrS1dmH+Bk/4sDwyRoFNzBeJsPobCg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(2906002)(66946007)(91956017)(66446008)(66476007)(66556008)(76116006)(6512007)(71200400001)(64756008)(186003)(8676002)(53546011)(508600001)(8936002)(5660300002)(26005)(31696002)(86362001)(110136005)(54906003)(6486002)(6506007)(31686004)(122000001)(36756003)(316002)(38100700002)(82960400001)(38070700005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?UkVFTGdlaFM5d2JJUkkyVUduU1FpOHJJODZHRThGcFNUUlhVS0N0VXNDRUF1?=
 =?utf-8?B?a2xJaHZrcmNGZUs2eE5pVEhtSmJUenB0QitnK2M4ekNqNDNVTUhXS1lWYU9V?=
 =?utf-8?B?b2dkM0llME5wUUZhU2RhU1EwTHJUUjkrTmlvc1lsaloxZytGQnlUVVZCNkQv?=
 =?utf-8?B?VEVOWEppSHFpSjAwZDlJUzFOSFNJL2Z4QlFtZlNlWkd1cVBrOEtEb3VGMXJn?=
 =?utf-8?B?aDRJcVpNdCtmdkoyU2tiYXlvdDlkb3k1alFuWmIzVk04bGNHcERPZFFkaHps?=
 =?utf-8?B?amJjOFBNcWt3eVZYdmY0ZFVYL2hpUjFsSzM0Vk5VdWVtT1R1M2lYNWtZV1dK?=
 =?utf-8?B?b3ZTWFhOZ2VudjVMNjhVMlh3dXJXSGdBY0w2TEh4ajh6N2dBVnpUZGpSRkVn?=
 =?utf-8?B?eXFENjBaYnBCUTkyMjlFU2xLZ3ZHRHpYcXpsUWhzQVdPK3d2c0JkZHdBd0FV?=
 =?utf-8?B?b2VHaVY5dUlMUHZ3bDhVbHZoU3RxWXJrbnA5NzAwR2d6SUFUZE9oL1BSZDNo?=
 =?utf-8?B?OW5zOHVDTDRFdXJOc3ZpNXZCN1RPdWJwb1o0T3lMWnNCeVdVRXhkSEphaUQx?=
 =?utf-8?B?R3BZMUZnMkhNMEh5TkZnRzdzUXpPSTBjS3R3dUZEVU13UTdFWWNqTThlTTl0?=
 =?utf-8?B?aG9RZDQ0cWM1elJpNmlNaTBSbXA2ZXdoaXd3bUdqYUVEdzU0Z1c2NU1HWkJj?=
 =?utf-8?B?UFBDZXFqTEx6aVBrcGVCSlFhdzY5QTJQckJtTi9ob3hvZ01GeGhQcDB2cTds?=
 =?utf-8?B?d2hjQ29PNmNBaUQyRHo1bFRGUjBvUWt0ckpWNmRFcVFIcmJmdmZzVTJUM1Vi?=
 =?utf-8?B?VENDN25MYzBiZ0hoME9GRVRycXNkVktTMU1KZ3JvRWF6dWYxNkNmMkNGTXhU?=
 =?utf-8?B?NDBzRU1nd0g0d1g3TGd4cWR4M0pVUmZzdnFxcks3bUd2WUJTNjNNSzZTbEVa?=
 =?utf-8?B?L0MyaStRRC9zSDVjMlVmOElQL3F3YVRNVzhlWFBWM0FXZU5yZldLN1hCTE9K?=
 =?utf-8?B?cmJNNVJVVjNHbHlKM2dvVnNSYW9ka3BzMkU3NHVIays5WDdxTWhVdXVQVWIy?=
 =?utf-8?B?RkhuN2phOUt0ODU4VTQzM2RmaTBWWkRFTGVrdGtUOFhQdmcwSHUyYWl5MWNl?=
 =?utf-8?B?d0pUUTBrQTRBaFZTWXNPTmtFbU9SM3FYVERONTRuVmIxSGpNbzErdjFMa3ZY?=
 =?utf-8?B?UFFwaEpZYUcrZHBraFFHanlnZFpZQ3FDcHFXOHpEMS9RWUdqdXYwV0NQSGhx?=
 =?utf-8?B?SzI5bWtFVDNncFcwVkFvcEg4Y0lsaHh1cjZFcVpQdHg3dkNGNkxWdnVtZzlT?=
 =?utf-8?B?RUxRVjB0cVk1bkpleXdsYU9zV2lCR0xGWjg4S0craDJtaE1PUVpSQUV1emFO?=
 =?utf-8?B?MGE1V1BsdVo5Z245WnFWZDUzRHpEekxwL0VlUFkvRGxsSmdHZUtCZGRnZVNs?=
 =?utf-8?B?a0dFbWZCL1JWWnI5SGJGRFN1K0hRdjBPVjk3WWtSZHBLbTRkS00yaFVMWkJK?=
 =?utf-8?B?VFNwY1BKK1RjSWZWSEtVYjVHb0NrWm5jdkhTQnBCSytYQzB1aER2WThxeVdJ?=
 =?utf-8?B?STFyR2tlY0pkWFdnOGVYa0VMWUEzck5ycEtzL0F0WWR3WUdBdmU5RkNKdWE2?=
 =?utf-8?B?Q2lkeVRTOVcwUU15TFFEVHVMZnZkWHhZZGl6dktKU1h5cElQTGRibTlDQmZw?=
 =?utf-8?B?ZnB5eThzVHlzMlhkNFVjQlE4TG1LbGwxT0VtdGtzQ0tCTWRJUUhKcDRKV2x2?=
 =?utf-8?B?NXQrellib29ZdEcwVzhYR3daaFNRZWtuT2VmdlZERjhwbUQzNXkxbkxHM2Jm?=
 =?utf-8?B?dTFWMGFKUEp2dzZlRkhLblFyQWZMY01Jd3pSM2NaRHo5SGhMdi9vQjJjelhu?=
 =?utf-8?B?U1VwbVZpOHZDbEsyRmdENnBjQytUSjZGMFpzSGNpMmpGK2UxVXlSUjdXak1D?=
 =?utf-8?B?S2dRUjN2SnZCSXNyeUlNU2RCVzluZFgrWjV6V2dUcHVoR1lESk1VQnlLRlFk?=
 =?utf-8?B?Nm45Q3ZCb0hKbWQ2QmpkbjBFaldMM296bngwVDZFOTRTZ0xPWjlBdlBwOXBo?=
 =?utf-8?B?WkN0bVFCQ01ZV2pwMmZDcGt6NW9xQ3BzeEtKc05xa2VyWENYVlVZdlZvR1JN?=
 =?utf-8?B?bkZ4OXdtR2xFdm4wa29YaGRRRzRhZkNER0VkVFk2WHUzbVRSYUV3WElFNE1R?=
 =?utf-8?B?bERYWjkyMUdVMDkyb1U1WUpITFphclNIQ3NudHA5Z0NBYXJYV3pKMHdVQ3BF?=
 =?utf-8?B?SHN5V0R1R1doMURkUTlsQ3loVEwzblNEZlZiMUNsclZDZXFKbjd2TkxWQ1J1?=
 =?utf-8?B?MHFiZzFFMnhqQjJ1YTE4REg2UkRzajVzUHJPSlh3ZW9CQ2FOWFRpaXBYa2VP?=
 =?utf-8?Q?zqm5vnk6oplvaH4A=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B6783FD0F1CA364EA861243B1EB36640@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54984854-34bb-4422-ca80-08da284a30f8
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 12:33:54.0023
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uc4UmA/DFY4qlQCoIUYrXct/kMYgEEnY/WHbARXkDVyYxPaK/y9QTWaRkkVyn44MF9A3cXDmluk8q8CHqpT/ezN+LOou5kgZoWHgELpxgoY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3111

T24gMjcvMDQvMjAyMiAxMjowNiwgTWljaGFsIE9yemVsIHdyb3RlOg0KPiBIaSBKYW4sDQo+DQo+
IE9uIDI3LjA0LjIwMjIgMTE6NTksIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMjcuMDQuMjAy
MiAxMTo0OSwgTWljaGFsIE9yemVsIHdyb3RlOg0KPj4+IEZ1bmN0aW9uIHVubWFwX2NvbW1vbl9j
b21wbGV0ZSBkZWZpbmVzIGFuZCBzZXRzIGEgdmFyaWFibGUgbGQgdGhhdCBpcw0KPj4+IGxhdGVy
IG9uIHBhc3NlZCB0byBhIG1hY3JvIGdudHRhYl9ob3N0X21hcHBpbmdfZ2V0X3BhZ2VfdHlwZS4g
T24gYXJtDQo+Pj4gdGhpcyBtYWNybyBkb2VzIG5vdCBtYWtlIHVzZSBvZiBhbnkgYXJndW1lbnRz
IGNhdXNpbmcgYSBjb21waWxlciB0bw0KPj4+IHdhcm4gYWJvdXQgdW51c2VkLWJ1dC1zZXQgdmFy
aWFibGUgKHdoZW4gLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZSBpcw0KPj4+IGVuYWJsZWQpLiBG
aXggdGhpcyBieSByZW1vdmluZyBsZCBhbmQgZGlyZWN0bHkgcGFzc2luZyBjdXJyZW50LT5kb21h
aW4NCj4+PiB0byBnbnR0YWJfaG9zdF9tYXBwaW5nX2dldF9wYWdlX3R5cGUuDQo+PiBJIHRoaW5r
IHdlIHdhbnQgdG8gcmV0YWluIHRoZSBsZCAvIHJkIG5vdGF0aW9uLiBUaGVyZWZvcmUgSSB0aGlu
ayBpdCdzDQo+PiByYXRoZXIgdGhlIEFybSBtYWNybyB3aGljaCB3YW50cyBhZGp1c3RpbmcgdG8g
bm90IGxlYXZlIHRoaXMgYXJndW1lbnQNCj4+IHVudXNlZC4NCj4+DQo+IEkgd291bGQgYWdyZWUg
cHJvdmlkZWQgdGhhdCB0aGUgbGQgdmFyaWFibGUgd2FzIHVzZWQgaW4gbW9yZSB0aGFuIG9uZSBw
bGFjZS4NCj4gQXMgaXQgaXMgbm90LCBpdCBkb2VzIG5vdCBzZWVtIHZlcnkgYmVuZWZpY2lhbCB0
byBrZWVwIGEgdmFyaWFibGUgdGhhdCBpcyB1c2VkDQo+IGp1c3QgaW4gb25lIHBsYWNlIGFuZCBz
dG9yZXMgdGhlIG1hY3JvIHZhbHVlLg0KPg0KPiBXaGVuIGl0IGNvbWVzIHRvIGdudHRhYl9ob3N0
X21hcHBpbmdfZ2V0X3BhZ2VfdHlwZSBtYWNybywgb24gQXJtIGl0IGlzIGRlZmluZWQgYXMgKDAp
DQo+IHNvIG1vZGlmeWluZyBpdCBzZWVtcyB0byBiZSBhIHF1aXRlIGJpZyBvdmVyaGVhZC4NCg0K
ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ncmFudF90YWJsZS5oDQpiL3hl
bi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ncmFudF90YWJsZS5oDQppbmRleCBkMzFhNGQ2ODA1ZDYu
LjlmNjhjMmEzN2ViNiAxMDA2NDQNCi0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ncmFu
dF90YWJsZS5oDQorKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZ3JhbnRfdGFibGUuaA0K
QEAgLTMxLDEwICszMSwxMCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgZ250dGFiX21hcmtfZGlydHko
c3RydWN0IGRvbWFpbg0KKmQsIG1mbl90IG1mbikNCsKgDQrCoGludCBjcmVhdGVfZ3JhbnRfaG9z
dF9tYXBwaW5nKHVuc2lnbmVkIGxvbmcgZ3BhZGRyLCBtZm5fdCBtZm4sDQrCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQg
aW50IGZsYWdzLCB1bnNpZ25lZCBpbnQNCmNhY2hlX2ZsYWdzKTsNCi0jZGVmaW5lIGdudHRhYl9o
b3N0X21hcHBpbmdfZ2V0X3BhZ2VfdHlwZShybywgbGQsIHJkKSAoMCkNCisjZGVmaW5lIGdudHRh
Yl9ob3N0X21hcHBpbmdfZ2V0X3BhZ2VfdHlwZShybywgbGQsIHJkKSAocm8sIGxkLCByZCwgMCkN
CsKgaW50IHJlcGxhY2VfZ3JhbnRfaG9zdF9tYXBwaW5nKHVuc2lnbmVkIGxvbmcgZ3BhZGRyLCBt
Zm5fdCBtZm4sDQrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIG5ld19ncGFkZHIsIHVuc2lnbmVkIGludA0K
ZmxhZ3MpOw0KLSNkZWZpbmUgZ250dGFiX3JlbGVhc2VfaG9zdF9tYXBwaW5ncyhkb21haW4pIDEN
CisjZGVmaW5lIGdudHRhYl9yZWxlYXNlX2hvc3RfbWFwcGluZ3MoZG9tYWluKSAoZG9tYWluLCAx
KQ0KwqANCsKgLyoNCsKgICogVGhlIHJlZ2lvbiB1c2VkIGJ5IFhlbiBvbiB0aGUgbWVtb3J5IHdp
bGwgbmV2ZXIgYmUgbWFwcGVkIGluIERPTTANCg0KSXQncyBhYm91dCBwYXJhbWV0ZXIgZXZhbHVh
dGlvbiwgbm90IGFib3V0IGFkZGluZyBleHRyYSBjb2RlIHdoZW4gY29tcGlsZWQuDQoNCn5BbmRy
ZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 12:46:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 12:46:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314981.533284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njh3w-00059g-Ll; Wed, 27 Apr 2022 12:46:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314981.533284; Wed, 27 Apr 2022 12:46:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njh3w-00059Z-IN; Wed, 27 Apr 2022 12:46:32 +0000
Received: by outflank-mailman (input) for mailman id 314981;
 Wed, 27 Apr 2022 12:46:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njh3u-00059S-FT
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 12:46:30 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d2703a8-c628-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 14:46:28 +0200 (CEST)
Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 08:46:06 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB3115.namprd03.prod.outlook.com (2603:10b6:4:40::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 12:46:03 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 12:46:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d2703a8-c628-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651063588;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=C/xCsXnHU48xPDrrOzc7HqGD7bAkzzZVfEy+zRFi7I8=;
  b=Pm9/TG5rTSoEklFTsS2MHtvYp/aWYuznDzKUHSly5g6GIgX/Q6uzu33P
   dojq6VY3q4dHS1XhYskPX8wQf+h2lqCt4ak/Tn+oNerWL3w5w0OZIMjKL
   e7HVE2oL8+mxJAW5GkfBaYy1IW7O2Y+nEv4SnMK47WlImCwReHFto94Sk
   I=;
X-IronPort-RemoteIP: 104.47.55.177
X-IronPort-MID: 70442961
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:B+bkl6JHu5XElfBiFE+RppQlxSXFcZb7ZxGr2PjKsXjdYENS3zxSn
 DYfWDvQPfmON2anc4p0bYvk90MGvsLXy4VqTAplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQ32YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NJQ77+yUS50BZySqKMUbwVfLHtBBpQTrdcrIVDn2SCS52vvViK2ht9IXAQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM2FGvqVjTNb9G5YasRmB/HRa
 tBfcTNyRB/BfwdOKhEcD5dWcOKA2SGjL2cJ9gv9SawfzULwyV1B/7fUAoSJUPC2QOdEmWS5q
 TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL
 E4Z8TZoqrI9nGS0SvHtUhv+p2SL1iPwQPJVGuw+rQuLmqzd5l/DAnBeF2EeLts7qMUxWDomk
 EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWF76PzIbdYgXJJAzN
IronPort-HdrOrdr: A9a23:kh0yfKmongfGZjjcFFsWqwHOGozpDfO+imdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM
 tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq
 Z1saF81kedkDksH42GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR4Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqWneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87hecAotd/lq
 H5259T5cBzp/8tHNxA7dg6MLuK40z2MGXx2TGpUCLa/J9uAQO/l7fHpJMI2cqNRLskiLMPpb
 WpaiIriYd1QTOlNfGz
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="70442961"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fd4SpoWSAy5Blst4upFQLE/z0+XaEfvlnHzD/5ZZXmuX56XKvEXAAMPlDuOVArZjsyijHGsmo57CP9wke1zbo4GZO5WrfraEbj40G0fP7Hx0MmuM7+ha0mkrfbBa7dF5GykFwCqKAL+9RCppW4gvQEY5GruPp4iJ/Hxmgp2tjZ3XwHX2gsvHPekmA9xQfckopx5ESSHou0QBXGN1xuq3iSc35G/AqFeMVx8dMy6VX0rbKBGFYx6BhyX+idxPwemiPa0rKMO1qkuLjDM+Hfq0KUv7YxOPtlToBGeh9zaolzDjjbRjZ7Kd/FBomxBC9QXHvXj+IZpN8Z8rrA8zL9Xl1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MOwOXTimLWCWMUUjUw/YMFtiIYxCaNp6P297GhXxD0g=;
 b=Ol9GE2OELe8nFv+stCUolhBTY3t5rtJ2Nih4Kb4fnKE/lMxoRLUh41kztmNK4IP+F3JpVzmHFvxYLF4umjDAh7ETvhc/YMRYHP1NzuMtr5zGnjLaBftZGVh1l/CE/RSNdHLVlgvTwLxN7bByCsmz93l9/DXz3dqqVhfRDwBZNywKVjxsiRd70FSZ9hck+4n1oPlDpkV011TfvNDeRVHFV1qwUi7lLEbxO8gi6atGpAAf3u6YB7T8CHnDKlF4Q046/dix2JMtVX/b+m7FwD/Duj3GRw2WgRoPTI9NkVS3OlP5pbaB4lMnbagELVGr5ALNWsmDnTQZA8NPL2blf5JESw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MOwOXTimLWCWMUUjUw/YMFtiIYxCaNp6P297GhXxD0g=;
 b=VPFbTUyMu/pLaSITaXgNceCDJBuDce+PsntJj429imued39h++X3BuhrwYFBg1viupq5GlAMlAqjQ272NYbd1hWUpMnKNSj/Nvda4BAg9iUlyg6HsLoalkHF5qQo7YeHFvav/VkF7dkgr1FNOPmVloO63LjXe3KRtCIMm4xms80=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 14:45:58 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Message-ID: <Ymk7BjXdyiMUGoc8@Air-de-Roger>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
X-ClientProxiedBy: LO2P265CA0506.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1ef08335-d5b3-422a-a232-08da284be32c
X-MS-TrafficTypeDiagnostic: DM5PR03MB3115:EE_
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB31157B8DE398EEB667005F2A8FFA9@DM5PR03MB3115.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zaQEjrxzw/1hyiLSGG9LNmFzR1liwEVJnYu1o5IXgJE+qxXl4nLnBX/vCvVLp0bM5N24TvDkEsL3g8mw70V2BbK0gLzf8Cz25qmTxBgCr5s/I0c8b+XvihFRMIXgid1YlvPP9WD4W+dN7AXtzfxSlDUhtJ6spG1HPf9J4Zd7Ki8NKeqg/oUPYxCGnRlgaKHAOgwRspCCm01YWX0+VJFE5GLyIZydTj2hYxpCJY0MznuvRLKuMnpRLwNmWbRz5tF40Yn3RDSACdreMgB6q5svlz9NLWtTrLgbs7xg1kHkJhE5fWe72U5db3kpLhnZyz+5vJWfFJXCEaSRAuRNHy1F9eJEHV/PmWsUGNTqtJJpue/4Z8AN9uj0MYTl8/IinsHGO9P0A26n+t8g9GYoEd9bDsRKWZPEs9Gm/s4uPGNrGTWDcfoCzz9KOi3Xfz13SssHe9jLyJz/Vgh6B8JqHos9ND+mOcekzpea3Or6VCcYEKJ0ZpCrpBA4EEbRo71TG7aO2LnhHcW1pAzD/hmEavqDdp+A2GzPnxZJelNAGldvUeerSxfN/mdmSkjt3IUKEra2RUGQXdcIuvCxOkOMFlGy3BE5lJ6IUZA/oYthxD1hHyqM2iWBsfbb9v8OTdv/Z7W3alm3HQFkmAaabr5ivtNeIG7hSpkxR2Of5g1V0fX8r2F4wUR4Ld+96WRZc+Wf0h24qPth3Vlj+IxsjPyW+NlmTlQXpzeoov8uJcanF04JArc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(84970400001)(6486002)(508600001)(86362001)(9686003)(6512007)(6506007)(26005)(38100700002)(82960400001)(6666004)(186003)(66476007)(2906002)(66946007)(66556008)(316002)(33716001)(5660300002)(85182001)(8936002)(54906003)(4326008)(6916009)(83380400001)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V2swOGY1dWJlTUdXTTRXZ3pqY1RnVnhKWGMraHpDcm9UTTFMcXZjVC92dWhp?=
 =?utf-8?B?K2xXYWxwdFUxQkdQdWlVODdnZXZwM3FySU0wb2FTQWNMbkEwSkRPTzhHREFu?=
 =?utf-8?B?WEVBOHptbjZxN3h1S085dU5xK003WVpIeHFNRlhjNjRxUjNpTHo5Z1hvRVZr?=
 =?utf-8?B?TmwvVW5YY1hLSUNyN0pPSzBFOG9lREdwYkNqT094dFdXWTdIeGxOdEV2OHVm?=
 =?utf-8?B?VmsyWFpLRW5TWS9KTlA2R1BjRCtrVnpLa08vSjJEWVpBZjZVTnJlT3hRZFVz?=
 =?utf-8?B?djI5dHFxUHJpQnVzdnBMeWhPTUxKOVNUNE5aNFR1YStQQUYrWlJzeFllZVgy?=
 =?utf-8?B?ODR2RlhqVzZ3Z0c2Ykp2QjhmZHRGRGhwdmZzUmdxQll1ZGJ6NVNZZVlNVEh5?=
 =?utf-8?B?SU5HU1NYTnFMS3M3TGlrc0hHQlBWTHdjMFRwbVlGWmRnZmIyM0FsVmRPZUhm?=
 =?utf-8?B?WnVaRzJ6c2RGdTIrazZrZEhPVGl2OTRZTlNvcWJvWHNsTlA2Vm5TcnlNWEhW?=
 =?utf-8?B?Z2hBbnBqM25VUEw0bkhzRU5MeWdoVmhvM0JIcTkzb21PcUhSN1paMDBTZHRk?=
 =?utf-8?B?dFZSZ0YwZERITmpPZWJsYVBsdmFpY2F0WEZObUszSGxSQndzYTBCUmV2WSsz?=
 =?utf-8?B?U2NkTllZWUljcTRGaTM5NnRiUXcyWnBoRGhHMEFWdm52V0h5RzJUeUNBOU9Y?=
 =?utf-8?B?Wkl1U0I5WG00U3Y2WGJOWXc1TTFBK3JnOUlCMVhpK3BPY05HUlFLYmxXK0Fz?=
 =?utf-8?B?ekpBbkVzd1V6TythU0kxTzNydXE1azhBNm9tcGloQkxwL3NoY2VEYkxmbW8r?=
 =?utf-8?B?SU9ISjd1L1JPSHdaVHc4aDdnV0hIcFNrYTRXb2lkUCtjaTBPWUNpblJReEc2?=
 =?utf-8?B?MVB4TUJyL1pid3k0NzJkTEtPRk9sTnpySkdNMlVVTGh0NFhNZzk3RXVuNGhq?=
 =?utf-8?B?V1VBeGcyaTd2ZHhxaWN3ZUhQYjU0T3lNZlJVSEQ5SFo4UjVUWjVJYzZBMEI4?=
 =?utf-8?B?b1JhM1dVOVd0WEU2M2xZWU5qRVMzQWdMNmd2Sk5obGt5WGl3NCtNWnRqV1hW?=
 =?utf-8?B?dFROVENoY0FyNklTWXlXOFpjOEZKeGx5aHMrUUhvMkx4MlRFT3gvWklYTnNr?=
 =?utf-8?B?c0N2dEFXVmdoL2lxL3BoQUdpb1J0U1VjMHVhYU1ZcVRUZGk5SjA5TVhDZ3hm?=
 =?utf-8?B?V3JMZTF1bTJEZGJUZ0Y5NHRQVGhENWg2U2RSK3ZCdFhWQnh5YUQ1c1lSUWl4?=
 =?utf-8?B?TEFFVXR2NlJPenNyVVkwbUYraUFLeENwMmtmMWNIa3lSdTZVc3FNQXZGMWhs?=
 =?utf-8?B?SHJWdkY2YkdXWDNnQTJ0SlRsZ2gwNkFhZVVDQUkzbUpCVWVWbVY0cTdLN2xv?=
 =?utf-8?B?S1l4ajdmbnBCcDc0WjU5Mi9BNFRRaTE2dWNXOWJ3LzN6RFE5dTA5bkUwNmcz?=
 =?utf-8?B?V00yMkxmYTZqbm1zbVlwSDJXb0loZVpVdVFGWGJUSllwSXdUK2dtcVRUMlRF?=
 =?utf-8?B?N0ZGQUZaNGlFVG5TdElrZmFjY2Q2MTBTcTBvV2N5KzBEeDJGd0l1OHlTTUNo?=
 =?utf-8?B?TXdKcnQwNmhUcWFSb2VnazhZSXRwM0lUSGQrRTRuZVhRdmhxYXBTM1BIM291?=
 =?utf-8?B?RUR5bkVvb21mZ2xFK05YZ080eW0yZXF6djJpZ0FuVGkvb0lQNVRsbGFoNkFi?=
 =?utf-8?B?UzJ1TDdkQ3liUm1FcGxsVU5MWGc0SGs0UXNqZG5nblU4SldSUktyN0xZY1Fi?=
 =?utf-8?B?NElLeXJsMTlYdnc4bDJZQ0xlS0xKMUxjd0x5T3p3U29IWTlReWN0bUp4Wkxa?=
 =?utf-8?B?WjhERXJlOW1tQTM2OU14NjJtMVJSQ24xN3hqK0dBYnhubHRWK0ZyN21MTkZw?=
 =?utf-8?B?RitNZFY1ZFhPMHJsamN0Z3kwaTJodjRuNjhoZW1qZnlwVXhTeEllWTNlbDg1?=
 =?utf-8?B?RFQxREtQcnRpc0JVVk05eXA0UEZjc3kzYUFrTEt5WWtNMUQ4UFYrSFhWYTdD?=
 =?utf-8?B?S0tjQUR2TDlkZjduNWZBKy9YOG8xSk5ITFdMME82VzhSM1c5dmRjWFU0S2lv?=
 =?utf-8?B?RTgrUnVXeW5YamdmenZXR3oyYzhON053QW1rdW93b1JYekZMTFBwbGRaOVlu?=
 =?utf-8?B?VDhUTk9MOURGNUtMeTNQemdPRkc5bnFXVSt5ZGJRR0VPaExDY0Z2aXpCOHVP?=
 =?utf-8?B?bUc5VFkzdDJXQzU3U1VDK0VvNFBWaGNEZUQrSXg3YmtyeXRSamMvc2t4dGNk?=
 =?utf-8?B?dGlZQzlBcExwdExob29PandjeUhsNUZSalo5VFpOMlJOby9VVTBkblVxSnpa?=
 =?utf-8?B?ZTdyL2E3QloyekU1aTE4NjBlV251Qm91MmN1UVpQQ0lkdFhnTnppZTU2Y1F5?=
 =?utf-8?Q?1uZg/3dg9DVQOE5o=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ef08335-d5b3-422a-a232-08da284be32c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 12:46:02.7232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cQuSYPQIp+sN3opsKL/rCcJbdVlutDWv/dysumDokoom367XchjDdPExzGU42DE35cHsnK41XK9EruYrNyQyrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3115

On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually
> exclusive - only one of them can be enabled. By default, 'intel_idle' driver
> enables C1 and disables C1E. However, some users prefer to use C1E instead of
> C1, because it saves more energy.
> 
> This patch adds a new module parameter ('preferred_cstates') for enabling C1E
> and disabling C1. Here is the idea behind it.
> 
> 1. This option has effect only for "mutually exclusive" C-states like C1 and
>    C1E on SPR.
> 2. It does not have any effect on independent C-states, which do not require
>    other C-states to be disabled (most states on most platforms as of today).
> 3. For mutually exclusive C-states, the 'intel_idle' driver always has a
>    reasonable default, such as enabling C1 on SPR by default. On other
>    platforms, the default may be different.
> 4. Users can override the default using the 'preferred_cstates' parameter.
> 5. The parameter accepts the preferred C-states bit-mask, similarly to the
>    existing 'states_off' parameter.
> 6. This parameter is not limited to C1/C1E, and leaves room for supporting
>    other mutually exclusive C-states, if they come in the future.
> 
> Today 'intel_idle' can only be compiled-in, which means that on SPR, in order
> to disable C1 and enable C1E, users should boot with the following kernel
> argument: intel_idle.preferred_cstates=4
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git da0e58c038e6
> 
> Enable C1E (if requested) not only on the BSP's socket / package.

Maybe we should also add a note here that the command line option for
Xen is preferred-cstates instead of intel_idle.preferred_cstates?

I think this is a bad interface however, we should have a more generic
option (ie: cstate-mode = 'performance | powersave') so that users
don't have to fiddle with model specific C state masks.

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- unstable.orig/docs/misc/xen-command-line.pandoc	2022-04-25 17:59:42.123387258 +0200
> +++ unstable/docs/misc/xen-command-line.pandoc	2022-04-25 17:36:00.000000000 +0200
> @@ -1884,6 +1884,12 @@ paging controls access to usermode addre
>  ### ple_window (Intel)
>  > `= <integer>`
>  
> +### preferred-cstates (x86)
> +> `= <integer>`
> +
> +This is a mask of C-states which are to be use preferably.  This option is
> +applicable only oh hardware were certain C-states are exlusive of one another.
> +
>  ### psr (Intel)
>  > `= List of ( cmt:<boolean> | rmid_max:<integer> | cat:<boolean> | cos_max:<integer> | cdp:<boolean> )`
>  
> --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c	2022-04-25 17:17:05.000000000 +0200
> +++ unstable/xen/arch/x86/cpu/mwait-idle.c	2022-04-25 17:33:47.000000000 +0200
> @@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
>  
>  static unsigned int mwait_substates;
>  
> +/*
> + * Some platforms come with mutually exclusive C-states, so that if one is
> + * enabled, the other C-states must not be used. Example: C1 and C1E on
> + * Sapphire Rapids platform. This parameter allows for selecting the
> + * preferred C-states among the groups of mutually exclusive C-states - the
> + * selected C-states will be registered, the other C-states from the mutually
> + * exclusive group won't be registered. If the platform has no mutually
> + * exclusive C-states, this parameter has no effect.
> + */
> +static unsigned int __ro_after_init preferred_states_mask;
> +integer_param("preferred-cstates", preferred_states_mask);
> +
>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1. */
>  static unsigned int lapic_timer_reliable_states = (1 << 1);
> @@ -96,6 +108,7 @@ struct idle_cpu {
>  	unsigned long auto_demotion_disable_flags;
>  	bool byt_auto_demotion_disable_flag;
>  	bool disable_promotion_to_c1e;
> +	bool enable_promotion_to_c1e;

I'm confused by those fields, shouldn't we just have:
promotion_to_c1e = true | false?

As one field is the negation of the other:
enable_promotion_to_c1e = !disable_promotion_to_c1e

I know this is code from Linux, but would like to understand why two
fields are needed.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 12:48:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 12:48:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314988.533294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njh5p-0005mu-4q; Wed, 27 Apr 2022 12:48:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314988.533294; Wed, 27 Apr 2022 12:48:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njh5p-0005mn-25; Wed, 27 Apr 2022 12:48:29 +0000
Received: by outflank-mailman (input) for mailman id 314988;
 Wed, 27 Apr 2022 12:48:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTRx=VF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njh5o-0005mh-8o
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 12:48:28 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 54bc8949-c628-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 14:48:27 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C838ED1;
 Wed, 27 Apr 2022 05:48:26 -0700 (PDT)
Received: from [10.57.13.174] (unknown [10.57.13.174])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A1E4D3F73B;
 Wed, 27 Apr 2022 05:48:24 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54bc8949-c628-11ec-a405-831a346695d4
Message-ID: <e094cd19-72c4-6553-4843-96aa873b2f23@arm.com>
Date: Wed, 27 Apr 2022 14:48:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-4-michal.orzel@arm.com>
 <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
 <590d34a8-744f-4170-74a6-1b02013488df@arm.com>
 <0c067fff-32a9-0d21-2410-611ec9a2b91c@citrix.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <0c067fff-32a9-0d21-2410-611ec9a2b91c@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 27.04.2022 14:33, Andrew Cooper wrote:
> On 27/04/2022 12:06, Michal Orzel wrote:
>> Hi Jan,
>>
>> On 27.04.2022 11:59, Jan Beulich wrote:
>>> On 27.04.2022 11:49, Michal Orzel wrote:
>>>> Function unmap_common_complete defines and sets a variable ld that is
>>>> later on passed to a macro gnttab_host_mapping_get_page_type. On arm
>>>> this macro does not make use of any arguments causing a compiler to
>>>> warn about unused-but-set variable (when -Wunused-but-set-variable is
>>>> enabled). Fix this by removing ld and directly passing current->domain
>>>> to gnttab_host_mapping_get_page_type.
>>> I think we want to retain the ld / rd notation. Therefore I think it's
>>> rather the Arm macro which wants adjusting to not leave this argument
>>> unused.
>>>
>> I would agree provided that the ld variable was used in more than one place.
>> As it is not, it does not seem very beneficial to keep a variable that is used
>> just in one place and stores the macro value.
>>
>> When it comes to gnttab_host_mapping_get_page_type macro, on Arm it is defined as (0)
>> so modifying it seems to be a quite big overhead.
> 
> diff --git a/xen/arch/arm/include/asm/grant_table.h
> b/xen/arch/arm/include/asm/grant_table.h
> index d31a4d6805d6..9f68c2a37eb6 100644
> --- a/xen/arch/arm/include/asm/grant_table.h
> +++ b/xen/arch/arm/include/asm/grant_table.h
> @@ -31,10 +31,10 @@ static inline void gnttab_mark_dirty(struct domain
> *d, mfn_t mfn)
>  
>  int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>                                unsigned int flags, unsigned int
> cache_flags);
> -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0)
> +#define gnttab_host_mapping_get_page_type(ro, ld, rd) (ro, ld, rd, 0)
>  int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>                                 unsigned long new_gpaddr, unsigned int
> flags);
> -#define gnttab_release_host_mappings(domain) 1
> +#define gnttab_release_host_mappings(domain) (domain, 1)
>  
>  /*
>   * The region used by Xen on the memory will never be mapped in DOM0
> 
> It's about parameter evaluation, not about adding extra code when compiled.
> 
You're right, thanks. I will do it your way in v2.

> ~Andrew

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 12:53:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 12:53:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.314999.533306 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhAg-0007ET-P8; Wed, 27 Apr 2022 12:53:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 314999.533306; Wed, 27 Apr 2022 12:53:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhAg-0007EM-M6; Wed, 27 Apr 2022 12:53:30 +0000
Received: by outflank-mailman (input) for mailman id 314999;
 Wed, 27 Apr 2022 12:53:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njhAf-0007EC-Qd; Wed, 27 Apr 2022 12:53:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njhAf-0005s0-Ok; Wed, 27 Apr 2022 12:53:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njhAf-0003oZ-As; Wed, 27 Apr 2022 12:53:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njhAf-0007Kv-AO; Wed, 27 Apr 2022 12:53:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qzezzt67S2EMTMdLOAo/4CQeDO3aX3FgqrFQJspkbpk=; b=c20aQuNpKOpBhX727kGTu+p0Mf
	g5FD6u88m3ci/nbiCLbG89cIPfJ0IwYGIyA5x11twurNXV9ExChBEx1wH8BgSSz8G2XD7Xn2H2qHR
	r+GvydR/dsjhVIWNFM7g2X9Bueqoz1SydNeDaj6NwHI15AKUDyvMKbhBJMavkDXFeAto=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169780-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169780: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 12:53:29 +0000

flight 169780 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169780/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  661 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   33 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 12:57:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 12:57:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315007.533317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhEE-0007rv-9L; Wed, 27 Apr 2022 12:57:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315007.533317; Wed, 27 Apr 2022 12:57:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhEE-0007ro-6J; Wed, 27 Apr 2022 12:57:10 +0000
Received: by outflank-mailman (input) for mailman id 315007;
 Wed, 27 Apr 2022 12:57:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njhED-0007ri-AK
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 12:57:09 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a985559-c629-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 14:57:08 +0200 (CEST)
Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 08:57:05 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN6PR03MB2642.namprd03.prod.outlook.com (2603:10b6:404:5d::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 27 Apr
 2022 12:57:03 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 12:57:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a985559-c629-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651064228;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=6972KUR+YtcMrssGjSa81PZVKDNvm/yotEL+wE4r23s=;
  b=dYyYlE3SXF5NuhO/1iln/sJLELHY5+HiKCUpaRbDEsO0oAHTl0h5gelF
   nWwZ1iG8akqvWGg8Yq4QNPfTKCyOETFgxTG/7cNFvp6VXg5KkxPvcCtlq
   av/emUZwYAmtat3EQiW8nq9Xwup1zzHhzm9xxwKq1aifaM9F0GG/5IbX2
   o=;
X-IronPort-RemoteIP: 104.47.70.107
X-IronPort-MID: 70058907
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:3KSc/q83xDh9bZui0rfBDrUD9H+TJUtcMsCJ2f8bNWPcYEJGY0x3x
 2EcXGnVaf/cZjPyL4olaIXko0MHu8TWmoU2SVBu+yw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YLmW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbORdjwHO4fco8YUVSF6MC1aD5Beo6CSdBBTseTLp6HHW13F5qw2SWsQYsgf8OsxBnxS/
 /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHP2MvIcHtNszrpkm8fL2f
 c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGUA9QLE/fVfD277w1B6+rbRc/7pW8HaSf1b3RuVu
 DvG8DGsav0dHJnFodafyVqujOLSmSLwWKoJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvHiWzWorXjCuQQTM+e8CMU/4QCJj6DSvACQAzFcSiYbMYR58sgrWTYty
 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP46eEJpprUZwQ3N/
 g0=
IronPort-HdrOrdr: A9a23:/2AfE64k3uYh/yceJQPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN
 MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt
 gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd
 L6IRlliVI=
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="70058907"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lCW3EXQ/jw6rEd57P0ll3sfT52nRBZUX2gRIqgwU96mKlVBKyKZFlcdFfJZz8k+4vtPNQdyBHcbkLFCaRQcJrZEALjtK/6xyD6UR/76VD81ydmyd4hhuSKauBvE5ht8zWTx7lxjReMuM34i5VIf36gRrjiNUMwOxnBcwUDyAYPbHwPUuyI/Ow240SxfDxj7Th/xHKAc2CazQtTgbenO4b6sGo7obMWecd/UShQBwMY7Nb8/N26zmhO87WyUpAQVkevEfa0gHQA3zCtgzwXNvAzEnCvpNSZtSYVgiRNHNyONe+WPpLADqZ4/bGOb4NgkuglsvkhqLtzAd8GcQBa8e2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nPym3AwOH2ncTK5Ie3FreRs99Y5iNMLjcxQqDldAgpw=;
 b=WT3XgJG56S2gWfY7ozE3cxVxYxKZQqjWAjTx6NPISY+WONd8I6CaGkgOpduQpYePjs1AYTHJvgjIAjArY80wArqBh4ouuymgjBVJBQcPbM68U/rH8hX2bggpRZZRJ5AIoF1KgyTk0ctQdnkIsxHe2FtYlNlDZUGooouyo8zN2IMz3BK662aUlaSoQqzK6aw4bMN9pHSHUzhEyY2soWj++WAl8v+LyR+JEbXuVBPt5qpn5EBUh2jNF1wrLvu17vQR2oK9sDdUphC5wbDbgmtpvsex2WDkoXuxHaZ4x21KmCCCkcZC1z1tI7CNF5k2AJkLSz42nUwRAp+LvvsBDcAyBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nPym3AwOH2ncTK5Ie3FreRs99Y5iNMLjcxQqDldAgpw=;
 b=vigsqg/KSMmYhYqSY6s/5AIoA5/2j3rlmMmGLC1UnLt4Y20GJEtM4Sg87mL3XEEVOlLz60f8qICly2FGxiGPq9yOfn6B++VIusTXtY3IQ0JLXdT1jV2g0mU68i3XVNnKqpiYFVioL+JByw7T9f0lbjNL1NmZHj3HdzKyZ58hRaI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 14:56:58 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 4/4] mwait-idle: add core C6 optimization for SPR
Message-ID: <Ymk9mvqXfqMDzKVs@Air-de-Roger>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <002d7dbc-8290-10d3-6e6e-c5947c1ace82@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <002d7dbc-8290-10d3-6e6e-c5947c1ace82@suse.com>
X-ClientProxiedBy: LO4P265CA0061.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2af::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd008938-733b-4fe4-54ff-08da284d6cde
X-MS-TrafficTypeDiagnostic: BN6PR03MB2642:EE_
X-Microsoft-Antispam-PRVS:
	<BN6PR03MB2642DE9105E75811750C261C8FFA9@BN6PR03MB2642.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JlOCze4Rr1+Z8HZHpiEbmVBYz4nqPAfcRqNZWblImgni0tkqbgKC9qPHvRAPwTHYDE66pX8M4MyDC5XZoTTHR8YILjEUdd/KbAoMtRVRbHwld0TLUKVm470CMV1oxL01bQghuOu/tO+Du0iVAgtrvoWipVIwOupCg9IbFxGgzT0Nf+cITbtllkjDseef44mPfa3sSZccDKBINp2VSK/oJNCn7moa4BuRd7WjR7BEdgXxZDB9CuZ6rU21nPJQYT8U1b5MC6f24YIQRCVpliopYPi3ym7ulxtuGZYtca8GMrm1hvjNl0gKQHfJ8r01ZNUvDweBxAjPzoLEJ/nJNCUgKV2ssmjfhN4MXiDQHAojKwAjT5hgJt8gtwszs5jhSpdN4mT/UeXjOPKNFfsZQKAZsc4lhXG4OpixtAPeQH9SBnRbHRAB86qlVkRvN4xlo3j5zUWb71u3TeUUoZ1PSUOmKoeWqGVfkN7iCs85JQR0mzoJh3i+yKiVBPWCKFwNZWMW5Hm39vpadoytDbsxSAPBMmsaNL096t0CltsFSeemV0ji3fTVwWRI7xWD+qCTC3eByJSH9X4yJ4sCFylTWFV3QNCHzkICVz0ycZ2eeJDMFckjVzryHlEnHi5WL1KFZzncR3hEZ5oGpqmP4bNeTZLyiw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6512007)(9686003)(66476007)(83380400001)(186003)(26005)(6506007)(38100700002)(82960400001)(6916009)(316002)(4744005)(54906003)(2906002)(8676002)(4326008)(33716001)(5660300002)(8936002)(66946007)(66556008)(508600001)(6666004)(85182001)(6486002)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dHZpRnVNVnhWZDhJUk9xYkppNDlqRDJWZVpjaGI0V0NXZzlnNXh3YVlXWWJP?=
 =?utf-8?B?TTE5S01IQXp6Y2h2T2lxViswZTBENFQzTmxsUzJCUkJuMENUU3hXUlJQNVlU?=
 =?utf-8?B?S1YrTE5DNXNWdXNnYjc3RndZNzBMSkZ6SGNZS1VHMEt0MlNjdFVEb3BRaUxz?=
 =?utf-8?B?WWxFdGVjMS8wWjVNTjFqQTh5NE50c25XaExWWU04K3Jwc2J4cWt5bG94ZE5N?=
 =?utf-8?B?dzJxR3MxTzdPRFJlMkhQWjZzU3MyL2dkRzg0dTZDVVN1a09ZWlpBSFZ6enJa?=
 =?utf-8?B?bEJMeFMwNElkdlZoTDk0bGJPNDJRQi8wV1VTV0xwNVdOWWcrRzcwcmw3clBB?=
 =?utf-8?B?dUNvQWFQWnZtdFIxdDlMR0JhOTJHZUlYeUV1OUczVmpCT0hOVVRmVHFNdS8z?=
 =?utf-8?B?MFRjVHVzWWdtNU5KNnJJQldlWWMvbjNSZnpmd2lxUFhKYWszZ3BqTjNRdkFM?=
 =?utf-8?B?eDU0UkpnYTd5K25NS015SGNrenpXM0F1aHZ4QU8ycFFKSFdHTEx2RWdtUUZ4?=
 =?utf-8?B?a3pMZExnS3phTENFbHEwaXZHNmwvaC9DSkpKaU5ZTElGNUJJUHozNUtialVh?=
 =?utf-8?B?WENUekhFWUZ6UGErS0tVeFVjb2RkaGk0RkxRU2hQQmJQcmpDd2pubkNUWCtv?=
 =?utf-8?B?bkJxRkJOUGR3dldsay8rQTV4ZzdTNVg2Tk9GazExemFaclkrcStubEswRU1K?=
 =?utf-8?B?NSthRHdRSjUvdjdRNmR2YUU0NlE3SnhtZnVMK1VWbUIvb3NlM1hhZStPdjM3?=
 =?utf-8?B?SjFuYWdjVkxqWFBZbE5IaGdzNFhuYjBSNUJDaFhDWjhUMmNscU0zVFliSnZW?=
 =?utf-8?B?c0xZUThsV2dOeUgvQ0VMSDV6RDJOMEFBOUlETk85WDFhQTE0TVFaSXhIWnBJ?=
 =?utf-8?B?eXJQVFZaeEV5WFoyU09ZVHhPakNFUEtlWXdkN0RERGUvQXpSS1dJeWVpdlZs?=
 =?utf-8?B?NmxGamdRalRJbThLNlFpa0toYmt6RW40V2tKdGJzTFF0eGYzaVROQ0FmQ3BW?=
 =?utf-8?B?bGdxeXBjN1pETkhPZVZVc2xNVG91UVdnUlJmQnlpY29UTC84cUpBb21DeE1Y?=
 =?utf-8?B?NHVVVDN0eStpMDhJbXk3MjlqWHJjUWNrSFBKdkJCdkRtVUpwK1VwSE1MVEhQ?=
 =?utf-8?B?MFE5NGZWdUFNdU0rVE1QalNlMjhweDU5aG1GYldvZTFjYnBoVVNPVUdlclEr?=
 =?utf-8?B?RTk2elM5UXI2S2hjdXBNWTdiVkYwRjJWc2NPUlFGaGIyTzc3bThXbXJBRVl5?=
 =?utf-8?B?SmZrWVROZy9PcUdUbElvV0lvdGR4T0R5dURKaTFxb3pnSWxYR1kxakluVUs4?=
 =?utf-8?B?dmREdUNzSWRrN0RKY0R3c0JqVWlWekVzWUxRSjRjSTBoNkFzNUVES0xIQ3V3?=
 =?utf-8?B?UzBYazc2MXNPckUwUk9PclNWMWhwMWc2UW9WaWU0YzJKL2ZJRit0K1RtQnJG?=
 =?utf-8?B?Q25zZ2R3Z2d2S2kwL3dIMTNUeU9GUXJERzRMc0hKdEFJZFY4STcySDUxSXhs?=
 =?utf-8?B?WnFjcy9tbTRKSmNzTnNRTXJNdzhGYXhycVN6WW5JSG1LR3VWd0tGVGJYS3Vq?=
 =?utf-8?B?OVJ1U2h0YXFXSExGWHNzaHNTSjBqRERiaEJqNmVNcDYwRXkzYllRWGxwaG1i?=
 =?utf-8?B?NElNZzdFK1NXZmgzSGZFaE52NVJTTW5BK014UlFoaExNOVZPNmo4cFkrWDN2?=
 =?utf-8?B?VWZZVzBrMy9OR044anFHY3Rsci96cFBkVk1CdEdsWTdibk9Yc00wbjJsR2NI?=
 =?utf-8?B?c0M0RDBKZGNhMUFmYzI3aUhkaXZQMXJmUDFXN2tSRy9ZYkJxMXlWMzhkS24x?=
 =?utf-8?B?OW1hcEs0ZVBKbjhKZEp6SHhmalA0NVN6UEwwbUJHZUsvUmpDN3pROXY5YnJw?=
 =?utf-8?B?UmR1RW1IQWtTSzhGcDFBU3FMZlJIVy9hV2ZkTkVCaTRaRlYrWWhlY0tQajZ5?=
 =?utf-8?B?MnQ1OTFYM0o4Y25yb1ZsTlFIZDQwNndNQTlPMHdVcW03OGl0T2MwdjhDcUNx?=
 =?utf-8?B?YVIxU0pYTk1mNVBqWFlyUkdGOVNKOGlxdDRPS096cFdFUmpXRmlScGczQW1J?=
 =?utf-8?B?Ynk1T0NEUFBYeXJRSS85RkJFVlFreEhXaG5mNWpDMWdzSGpzSDFIOGYvV3F4?=
 =?utf-8?B?a2lkYTI3RkkxbVF1eWsydmNUQkY2U2FYOGc2WmVKRHpYd2FBWitiOW5QUjBZ?=
 =?utf-8?B?S1EvaU5CNEZNK3p4R1kxRTFIVHUrTVFBUFZqZVJmZDFNTzlrODgxK0VsY2ti?=
 =?utf-8?B?V2NpUEE1bE5KVGVPWGN1dURrakdRVWFVMUlDTU12cGtJRzY0SDM1disxZUk5?=
 =?utf-8?B?ekZWcnJqdGJxaFRodDRIKzZiYVNCSTQvakNvb1FXUlhySVl0eDg1ZnViNDVT?=
 =?utf-8?Q?g+UG90P7Tnv2Egzo=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd008938-733b-4fe4-54ff-08da284d6cde
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 12:57:03.1699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oh3kMTDmKG2j0KcHZ1iz4kjNU/BX/c71SoGdHYOIDgOARR0lIzsJgN/Rpz65EuGFvvKXwAPYY6tjh8mNhdjwZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2642

On Tue, Apr 26, 2022 at 12:06:14PM +0200, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> Add a Sapphire Rapids Xeon C6 optimization, similar to what we have for Sky Lake
> Xeon: if package C6 is disabled, adjust C6 exit latency and target residency to
> match core C6 values, instead of using the default package C6 values.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3a9cf77b60dc
> 
> Make sure a contradictory "preferred-cstates" wouldn't cause bypassing
> of the added logic.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:08:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:08:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315014.533328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhPJ-0000xB-BV; Wed, 27 Apr 2022 13:08:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315014.533328; Wed, 27 Apr 2022 13:08:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhPJ-0000x4-8B; Wed, 27 Apr 2022 13:08:37 +0000
Received: by outflank-mailman (input) for mailman id 315014;
 Wed, 27 Apr 2022 13:08:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8dk3=VF=citrix.com=prvs=109ad7ccf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njhPH-0000wy-Kg
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:08:35 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 217ab2da-c62b-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 15:08:30 +0200 (CEST)
Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 09:08:08 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MWHPR03MB3357.namprd03.prod.outlook.com (2603:10b6:301:42::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Wed, 27 Apr
 2022 13:08:04 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 13:08:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 217ab2da-c62b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651064913;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=4a1pylHtIyeLWeqdGrWIC/pytrCE33KvdLSOGCsb71Q=;
  b=FQsh3OXCajQ0LgYKCAtCfIiZ2Z8SfMbDtuJ1mgEN6GqpRcB6UmsA+oq8
   87IO2VRIM+Tgo3k4VaO2BMybTeAaFaUZKFZj8k1gJTWufTYjXLUPkWS9/
   24CBiu1w37AXOeTkL/89gGHY2VrdxLPSw2KhNkPXXxtVXm+0jWtXb+NwS
   Q=;
X-IronPort-RemoteIP: 104.47.66.48
X-IronPort-MID: 70038820
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:XDZQkaDlmVJTExVW/1viw5YqxClBgxIJ4kV8jS/XYbTApDIm3mdUz
 zQXXT/Sbq6PYGrxf4xxPt7l9EIPuMeAndQ2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj3dYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhIx
 u1QtIaRWD4lZKfXocQdVydYFjBHaPguFL/veRBTsOS15mifKT7J/K8rC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6h4B8yTK0nJzYYwMDMYr8ZCB/vBI
 eEebiJidk/oaBxTIFYHTpk5mY9Eg1GgK2UD+ALP/cLb5UDIyBNT9pfLMebFd9yBXP9amku6u
 kv/qjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDZsH0QhmQsHOC+BkGVLJt//YS7QiMzu/R/FyfD21dFDpZMoR65IkxWCAg0
 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLQcZZUvWd9enM/
 g23
IronPort-HdrOrdr: A9a23:4JqGN6r03SlT6D9WTdd5XOsaV5tyLNV00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcYtKLzOWwldAS7sSorcKogeQVhEWk9Qw6U
 4OSdkYNDSdNzlHZIPBkXGF+rUbsZe6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK
 Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInNy6IZn1V
 KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0WVjcVaKv+/VQIO0aWSAWUR4Z
 7xStAbToJOAkbqDySISN3WqlDdOXgVmiffIBSj8AbeSITCNU4H4ox69MNkm1LimjQdVJsX6t
 M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pXVFZ9l/1owKpuKuZIIMs60vFULM
 B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpT+OUP2nMbsJ4tQZhN4O
 rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOHl7fnpLEuoO26cp0By5U/3J
 zHTVNDrGY3P1njDMWftac7hSwlgF/NKQgF5vsul6SR4IeMNYYDGRfzO2wGgo+nv+gVBNHdVr
 K6JI9WasWTWFfTJQ==
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="70038820"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VmxMecN4vyCjET3oeJMa4Cwf1N/4px9acr0RveskWQhKcrQgxK8E6J5rjHkdXGZLbufYKXIjthGTs+Yi5Fnmhdo5i0tjtmatWCdK5HbyI9vth+oUFIsHWNjkrf40Gt2RFhrcV/6ttRlv4pMT1S8SE2scGzYy3t3M+Dud+tryvUYFrRxjt8c7q68A29CZJXOZ/Xn+jjFXko2tp4ed0b7NSfA5CfyVpl+r64McV/0REWD1ydcuyvAIbEGkz/+jNY8xr4ZOpoVUHSShK8Mrfp1bROr1KRqfI4rqOqTHy8HDNju4Hi+m8L28wKQ+D2fAGkw4HOSAbdaPQvtmbFuNrY290Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4a1pylHtIyeLWeqdGrWIC/pytrCE33KvdLSOGCsb71Q=;
 b=A+h0oLEbfAo7oVbq3Vds6mYR/x2z01VR13aelOZlnE1XgYS2DKmt9YzjMqU9c16CYSOwsOZhXIdasjIyuWo+U64QL9yw6y+398iYJkaIQKdtuS+z+irlnk7CMb64H0qWZV+j+rY1Dnu61pOkkIC3WasOiehGpKe5bml78XJbR1iIWtpdZlgZE5114SEM00jlB/AszHHzDIhq1C26nbUnsy2POMQuzNfeui6JKa4xudMqNWYHfnqyZ28H9XpmwhqVvFlWOZb1z0IReq6w4ihAbF+zhOS98N/XnFpowQtoJrVFh4H0R46AM99zuNWl7YbDKrQhHX/bOPPjKp8CJSC7cQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4a1pylHtIyeLWeqdGrWIC/pytrCE33KvdLSOGCsb71Q=;
 b=sUE1RnRXSvYrG6oaqp1a7K9aPX4Fqk6wlaow2IiqlALNbFFKAr83uk7e9eawR15d+qzxDM6sJlPUfoQPqEcgebMpSOydPPacyKkI4mjaYTO3iERaTy623H8faZhs2ryeta4VMHKbNPs3w1s+lgPHA6foQO9cSqrj80TDHcTRySw=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v4 01/21] AMD/IOMMU: correct potentially-UB shifts
Thread-Topic: [PATCH v4 01/21] AMD/IOMMU: correct potentially-UB shifts
Thread-Index: AQHYWH7CdQN8poxboEyKGipqz5RIIq0DvqqA
Date: Wed, 27 Apr 2022 13:08:04 +0000
Message-ID: <00d978cb-be83-79de-ef02-5b6ad1042f52@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
 <0dec8285-a348-53d4-f9fa-552c7c1c405f@suse.com>
In-Reply-To: <0dec8285-a348-53d4-f9fa-552c7c1c405f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d84f9115-3cba-47da-80f3-08da284ef700
x-ms-traffictypediagnostic: MWHPR03MB3357:EE_
x-microsoft-antispam-prvs:
 <MWHPR03MB33574FB84AB947863FCE353ABAFA9@MWHPR03MB3357.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 mH6NJSbgNvOdKy1nzucJUEORxtPdeLuW/1HIJmkF5HMgmZA8ZcpT3HU6r9Pc+8g7SzK1KZ+KZg1ZlxIiwB1S5KfJ206l9FuHwvE25zYTYYkzWP1SIJ30vTUY1o2hCT6Mi+t/q90gYesxjnWrLP5gPFlzZmaIJ9mSrydekzKI3W7l3TYK/qQYrJy679BLui6PLR8bBK/2T5AGrsO9r+udoOjeqYGdkLTbaJssm9O9apDV26C/spmyUAiGB2YW92cSvfZjROWlu6KDnSCuYyMiCwQMExv7AIibF3sZWwFFH/18dTfrA4SsLLRo0I4KVfhGXfpayjZn+B0fQN9Oi0xQ5iYK1LwOwD/Zp4gz4Xu4TsZbUBSj6/lv/2cqF86Xe2QjznXhXxOdNVPZnjERP53sSMdTq7XABBNA23FRSCAEx3lT8nv4KfNLMkC52OT0XgpG5V7xpxBE/FYyAQIIRw62qenII1us2j/Wlj6SWvLg/jcVZyP0up94XBwEA3mNJby6cPbo+Uh5Avlr3UofpLryEQ+obpU7hcQrnXuzpuIJLEXp8ZpB60pGvGk/LdfWc+5rcmLbiDpkNS3BkbziXz9iH9o/pIEIiEWdsYPdorq5ehyp6v4bcx+Za8bVeo81HXj8CsinCyaSErJ35SuTDms/xpFNdd/bGgbHQQU6RLBcXOXwFNnTaHXgY116YvFTh19Ywxi0c13XpJtuFKo6hk2ImohHObi3SZaNrZ404lnHKSyKzI8rE1hh7t/FA0DqVLyFuFrNnszvLS3cUgGt6bo5nA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(86362001)(31696002)(38100700002)(82960400001)(122000001)(5660300002)(508600001)(6486002)(31686004)(8936002)(2906002)(71200400001)(316002)(66946007)(76116006)(64756008)(66476007)(4326008)(8676002)(66446008)(91956017)(54906003)(110136005)(66556008)(186003)(83380400001)(53546011)(6506007)(107886003)(2616005)(6512007)(36756003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dlNHUElwN2QrVW96WXhTQytGNTVKQTZPNFVtTzVqZnlYVVBwUnhyR2E3WGMr?=
 =?utf-8?B?d2JZMWdmUG1IR2JzNTg3Y1I3dmZoRFMyMGNSejBsNHdtbGMvY1dCLzJyT1hS?=
 =?utf-8?B?VGYrTmhyL08vRlgzYkE4Mm1SL3JIbDFmQ1RNUkFCYWE4SmMrSnJpcFJxb3ZV?=
 =?utf-8?B?Yyt2T1kyT3c5RWNUWVZ2QmFpbXNySUx4NC9OZWpROFVoa0RseW5sWHVvTFlu?=
 =?utf-8?B?VjRLUHBTdm03ZU1ydk14K3hzKzdPVytuYVJ2a3g4bWN6ZWFqVDNFS3JiK2Zq?=
 =?utf-8?B?RzFGWmhmWEVlcU5CS3lzSU03WWN2cXMxK25lcGxxTi9YR012WTZmM1hVVFNB?=
 =?utf-8?B?b2VvUFAvU2pCdEpFaXExZDFKMElsWHR6VEowdjFqUndEeTlmSVNWRUN6ZlQr?=
 =?utf-8?B?MWNET3ZXM0YyU3ZqakdVenFQVXlrQkpldDZyckk0cWtZb3RmZnE4b283Zjl2?=
 =?utf-8?B?QU10Ymg1c1c5dHFVMk0rb29xakhLQWRkdVdwd3VsZFhnQVo0dC96a2h0ZVZJ?=
 =?utf-8?B?QWxWc3liVmxyTWQxczBmMFNMN2xLQjZtc3BxNnFEbk9Ld3Q3Q1NURnFiUEE3?=
 =?utf-8?B?L1VYYjJ0dUsxaEZQQjdrMmp1RXhkWDFtT3hOSXJUY1l6Rmh1aXk2MzFtSjl5?=
 =?utf-8?B?bjdPL0FDcU1SSFNocXIyRjNMVDc0QlppbjNOQVRrZDdtOXQrOS9EMG5RcVBR?=
 =?utf-8?B?SGhQdTNVRkNzczIxSlZDRHZRNzNEbmMrTUdFUkFONGdBRUExN084Si9tUHFM?=
 =?utf-8?B?Q2hMeVp6K3NaZGhtcVFoeVRpeEo0R3dneUExZmNLSWhRcFVzOElIVzNjUzR2?=
 =?utf-8?B?d0dNdkpxM1dwUWhUQVFsVldCREk4ZFF6NU0vcUtCMVlPbXNuOEU0bU1GaVFF?=
 =?utf-8?B?N2Rjd1dYSlhmM2dFQXc0Q1RHaVlReGJJWDdTaGxNQnhNZUU0QzJkc1F0SjhK?=
 =?utf-8?B?V09YSjNYekNPWEo4dGpmcDcyRW5OenA2UkcvWmx6VC8yWENhUUEvWlVQT1pp?=
 =?utf-8?B?djhIUUFGOEs1M3doZDZybU90b2dsRnJ1YU96L2RwZ3ViRlJBUENwVUI4TEZl?=
 =?utf-8?B?dDNwWUFXbzdtRFJJWCszMThueUtTRFpBMEVaSlNMUFB0aHNqTThCVXlFSnVY?=
 =?utf-8?B?V3lYa3BPUW45d3hzMG9iWEJIN2c2djZNdUplOVVHUlVKYzVBV3BGOU9IMEZm?=
 =?utf-8?B?VnZBblphWm1PVnIyQWxOejNyVjM4ajg0RHZuSEZQa0I4SERDVVplYXV5VnE1?=
 =?utf-8?B?V0xiZjh2M1BSbURhRTdEeGw1azNuT0pzd2FmVFcxOTNzQmUzeTg1QjVoNUp1?=
 =?utf-8?B?MjBnenVYaFV5eXZ6VnAvMnc2WkVnSGlKLzIyczgrTWNnVXpxT0lyQ2JtQjQ5?=
 =?utf-8?B?SWF4ZmlJNGpXMU9LK09jQmFFU3BrVzIvMDZZMWxQWThZK3JIOU5rZFhOcUFO?=
 =?utf-8?B?bEJRR1cxOEpuN3RTWDkvL0NyRWVDZm5rWnpMZ3BKdGJ2OTBiM1Jia1VnYlk3?=
 =?utf-8?B?NDZwc3RwTnNQbnZZZmVTVGFzSVd1NCtCL1VLSjF5SDZsUnJsenlBV1pSWmtM?=
 =?utf-8?B?VXZSdTV5d0JlSVJxdnFPcDU4dVF0dFQ4alRGS2JxanlpdGs3T3Z0eHlxYWZu?=
 =?utf-8?B?ZnpESXQ2YmV3ait4Tjh3N2FCVEVBTk03dTRudUVNRkVRSXlhVHN4UlBmMDk4?=
 =?utf-8?B?SkdMV1FLeDhvKy9PQnF5QjF3SmtDUEhOV3RqSnh1djRlSXpMZ21ueGhkRmxl?=
 =?utf-8?B?aXlNQWpQUVdnb1NXbVpLV2tLd3ZxNnM5U09acHZvQjE1WlYwKzFKdWN1b0Nk?=
 =?utf-8?B?eHdQNitLL1JXdzJmdWc5Y1dqeldhakR5cFdKMUN3OElQMU5kMHFyckE0VlJM?=
 =?utf-8?B?ZTEvV09TUzdpYWY2OFZqcVRrSXRlNjFuWDU2NnB1TU1pVGxaMm5IOGRBc2VP?=
 =?utf-8?B?UFIwbmlwMy9qTnhKKzZZNlRoOEJJZWR3QSsyNWNOOG04K293OU9XWU50WWp4?=
 =?utf-8?B?VUd1RTFPZm43aXlOWGsxU2FCMjJ0dUM3Wms2RjVQcUJxeG8wT1dCWGFQV2pl?=
 =?utf-8?B?RFhwK3ZHWVMzRE9UYW5RVEZSWUE0bDdaVDcwUFpPYk91VGdYZzJzWlRKZlRp?=
 =?utf-8?B?ZXQ3VzhIb2gxOUtYbmxIWFJxRHU0QlpPSTlYM2xRZmlMRDIzbWgwUHdnUW9n?=
 =?utf-8?B?aWpwNXRnbW9maW9DVnZudW1QYy9qRlZWdGVWQWxoeng1UU42cTlIVWUvbXJk?=
 =?utf-8?B?b2QyQWt3NWZZcEJETHpJVGxTbGM3blY4djdXanhaYTBWd3JnV1plcFIzMS8x?=
 =?utf-8?B?K2hReGlHZFF6b29tbS9SRGkxZ2xnNlk5U2tXSFFJRVdqQ21BMzFQcDMwZE1G?=
 =?utf-8?Q?cD1Gz1EmWUC6l400=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B33AAE417898FA4792015C0080E1ABEB@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d84f9115-3cba-47da-80f3-08da284ef700
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 13:08:04.2599
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ouEw6iKC5YoIuhunIwkw6kJ4RjAa3uZZaqGiIufzVSP346jImiFlQZOpC3IVkBF5QGEy71x4NtSXKrmEIsTLTusGO4ZOxqGruikzoTwAjIk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3357

T24gMjUvMDQvMjAyMiAwOTozMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFJlY2VudCBjaGFuZ2Vz
IChsaWtlbHkgNWZhZmE2Y2Y1MjlhIFsiQU1EL0lPTU1VOiBoYXZlIGNhbGxlcnMgc3BlY2lmeQ0K
PiB0aGUgdGFyZ2V0IGxldmVsIGZvciBwYWdlIHRhYmxlIHdhbGtzIl0pIGhhdmUgbWFkZSBDb3Zl
cml0eSBub3RpY2UgYQ0KPiBzaGlmdCBjb3VudCBpbiBpb21tdV9wZGVfZnJvbV9kZm4oKSB3aGlj
aCBtaWdodCBpbiB0aGVvcnkgZ3JvdyB0b28NCj4gbGFyZ2UuIFdoaWxlIHRoaXMgaXNuJ3QgYSBw
cm9ibGVtIGluIHByYWN0aWNlLCBhZGRyZXNzIHRoZSBjb25jZXJuDQo+IG5ldmVydGhlbGVzcyB0
byBub3QgbGVhdmUgZGFuZ2xpbmcgYnJlYWthZ2UgaW4gY2FzZSB2ZXJ5IGxhcmdlDQo+IHN1cGVy
cGFnZXMgd291bGQgYmUgZW5hYmxlZCBhdCBzb21lIHBvaW50Lg0KPg0KPiBDb3Zlcml0eSBJRDog
MTUwNDI2NA0KPg0KPiBXaGlsZSB0aGVyZSBhbHNvIGFkZHJlc3MgYSBzaW1pbGFyIGlzc3VlIGlu
IHNldF9pb21tdV9wdGVzX3ByZXNlbnQoKS4NCj4gSXQncyBub3QgY2xlYXIgdG8gbWUgd2h5IENv
dmVyaXR5IGhhc24ndCBzcG90dGVkIHRoYXQgb25lLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IC0tLQ0KPiB2NDogTmV3Lg0KPg0KPiAtLS0g
YS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMNCj4gKysrIGIveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jDQo+IEBAIC04OSwxMSArODksMTEgQEAg
c3RhdGljIHVuc2lnbmVkIGludCBzZXRfaW9tbXVfcHRlc19wcmVzZQ0KPiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgaXcsIGJvb2wgaXIpDQo+ICB7DQo+
ICAgICAgdW5pb24gYW1kX2lvbW11X3B0ZSAqdGFibGUsICpwZGU7DQo+IC0gICAgdW5zaWduZWQg
aW50IHBhZ2Vfc3osIGZsdXNoX2ZsYWdzID0gMDsNCj4gKyAgICB1bnNpZ25lZCBsb25nIHBhZ2Vf
c3ogPSAxVUwgPDwgKFBURV9QRVJfVEFCTEVfU0hJRlQgKiAocGRlX2xldmVsIC0gMSkpOw0KDQpU
aGVyZSdzIGFuIG9mZi1ieS0xMiBlcnJvciBzb21ld2hlcmUgaGVyZS4NCg0KSnVkZ2luZyBieSBp
dCdzIHVzZSwgaXQgc2hvdWxkIGJlIG5hbWVkIG1hcHBpbmdfZnJhbWVzIChvciBzaW1pbGFyKSBp
bnN0ZWFkLg0KDQpXaXRoIHRoYXQgZml4ZWQsIFJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxh
bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:16:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:16:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315022.533339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhWe-0002T9-8M; Wed, 27 Apr 2022 13:16:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315022.533339; Wed, 27 Apr 2022 13:16:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhWe-0002T2-5N; Wed, 27 Apr 2022 13:16:12 +0000
Received: by outflank-mailman (input) for mailman id 315022;
 Wed, 27 Apr 2022 13:16:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8dk3=VF=citrix.com=prvs=109ad7ccf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njhWd-0002Sw-2e
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:16:11 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 30ffde25-c62c-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 15:16:06 +0200 (CEST)
Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 09:16:06 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN7PR03MB4532.namprd03.prod.outlook.com (2603:10b6:408:3f::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.18; Wed, 27 Apr
 2022 13:16:03 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 13:16:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30ffde25-c62c-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651065369;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=CJoWPejBExPDOKG9sp5p2i6RGq9VkJy0n8vU+7Ak5ec=;
  b=U5aff2LxcORwF0Jui0iMDDPVF5hAbug65ELX88dQRf4PKUtE1kHonPCF
   79YaCJ6AN3y7UaFejySydwVZr3NPeqmgctRgdQn8kGjV1SScaPHpFyTAC
   a3dzQjLUQpOJPYcBjVKfTBBSKUZFy0WnUA6kWDaBLDizMZwYcxYKhM+tz
   M=;
X-IronPort-RemoteIP: 104.47.59.176
X-IronPort-MID: 69439457
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Zq7zoaidJ09lE3m2iLPgcL35X161HREKZh0ujC45NGQN5FlHY01je
 htvWjrXOPzcamv3ctEiYdnn80IF65fRn4cxGwBr/noxEXkb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nS4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YT0oDq7AwKcZbwV7EnFsfoFYoebIBXfq5KR/z2WeG5ft69NHKRhseKE9pKNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuI4ehWhu7ixNNa+2i
 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJpsjSInVAsj9ABNvLHR4eQaepflHyig
 Uz83m2iUh5BHsymnG/tHnWEw7WncTnAcIAYGaC89/VqqEaO3WFVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslgYVRt54A+A8rgaXxcLpDx2xA2EFSntNbYIgvcpvHzgyj
 AbWwZXuGCBlt6CTRTSF7LCIoDiuOC8Ta2gfeSsDSghD6N7myG0usi/yoh9YOPbdprXI9fvYm
 FhmcABWa20vsPM2
IronPort-HdrOrdr: A9a23:3m9LNq4dMrBaYGf6xAPXwZGCI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+843WBjB8bZYOCAghrmEGgC1/qu/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXerIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonis2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaQkEyzzYJriJaYfy+Azdk9vfr2rCV+
 O85SvICv4Drk85uFvF+CcFlTOQiArGoEWStGNwyUGT3fARAghKSvapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuKYlGclsRLYkjQpo+VY7bVDHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TpE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZeo6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z44HSKyGG4fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv
 fbAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="69439457"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VFD05PsyJNpB1bsIIKIV/+gUHeZJPNCKtlvEqmRY80unAv90pEZDDi+LGNjY7Sd9tvPN6CA/O6KI+adPUbxLehJRZGJDJPBvW00h59iaFEMRpn8y/V4NfcFxA6FjvUBuLN7nZgXCoOJdrpc9efvVBDZpbeaeLGQpHQlA5dcNGCdmfln3L/zYD3bpML1fJVxHig4B7w15KYs1Kzt5tkIWE/wgmjKd1CfGklXc0O7xtmNhO2GOFFnkVEcPQ6Q6TfYhwK6ibVWad87RVPjarlb3d5ksL+kh1ag8lJGSp4WIT5B9lQR26JLLwhmL8LA/cznlDQaOIZn/aQrMHIIkPCOK0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CJoWPejBExPDOKG9sp5p2i6RGq9VkJy0n8vU+7Ak5ec=;
 b=eqV/c78DPE7HoBF3s2NH9Ea62oNFONc4eyuA18KQyE+PDpwyZ/cNgGmoY0b6avjsWmK2sG0kNxl1o8BFAF5if8OZTtaUjsBijKqeWGTWGTB6K9m0qkYLlKDT0BoHAd6QUdkHMKKNMtV2kCCsQ3Z7xOiYohtAV1dN6AuHhjxcFgi6/ygYNcDBQWoL72AeXydJNG0oVGuCFCSakP902cqttY9k+GA2iKCyuhrT5+OoP48i00FyCAwHhx1c9IYhXCiga8LCWJ/61YjfpBV0egfUnSDZm51ln7SQlsPf8n7uT30ShHmOaG7OMG6K0H6rVD2v3mPrj2+Smh9bYxrRVpxMNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CJoWPejBExPDOKG9sp5p2i6RGq9VkJy0n8vU+7Ak5ec=;
 b=iDqHTZbwMzsiCipfWuugXvhA9I2czrkbYOmY5ye6GSM6rsU1rG1envlA9kNZxRQcOBaQCx8DzKOol+Pi3A84C7Db77P8pDWXPc3veScWTQtuH4APazWEGWHRq7DtixQORIaE9kOAC02L3eeqap1kAwfSO3x0aZdaB5rROYKU28A=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()
Thread-Topic: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()
Thread-Index: AQHYWH75zDdGe3+po0S/evA91QmE7q0DwOQA
Date: Wed, 27 Apr 2022 13:16:02 +0000
Message-ID: <f61ce2f9-ef08-6f50-29b4-e7e09e7059a6@citrix.com>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
 <cc4323b2-e074-f86f-eea0-9cd6a802bed8@suse.com>
In-Reply-To: <cc4323b2-e074-f86f-eea0-9cd6a802bed8@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b83b1842-c3c6-44ef-825d-08da2850144f
x-ms-traffictypediagnostic: BN7PR03MB4532:EE_
x-microsoft-antispam-prvs:
 <BN7PR03MB4532FD07BFCF275C07A69A95BAFA9@BN7PR03MB4532.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 o8wHua1KhtmuT8lR5jNUGqXPOfRLrGsBmlTWDw4w6upNOtNY7WaikyCn4LFtJvTxRnnqK7fmJmFWTevfkkGenjcyB2uoIaDuWCMTsYvDK0ZInWXyvQkr9alJUWzl4I89FA08sli+1pmrRNorLKeY2Ii/eKSBb2/TxjzX/ShBD1Ujy5Xrz+/eVe0AcSjnL/EOgVhrC7xv1FV7qb2uszSeDGX0pxwTCkMc85nC9Lg9oJb1Uc7poI+KnEXOsf7AAtGpW8chvkdgwzvPFV3tcUbYkO64dHG8rXKbud6wc4x0Di7IGwrY0tCWkSu0qIcPu5TKLr+tOX0NrJmV70CTGitHElPfQ8xAGL49JiCaPNVvx6Rd2KBgr4bU/tllgqoNOM4yCBhMnWEctQQkPQqGfF+rNlg1HlSq0YO8PdwxF1XtuExPTAJRtSRgIzMamxtXWtU6FubN6/140WP1CstCU0oY/DcY+OrEWxVXQPx3yWbpwbEw6JyDigPq30q2FOhkNhb2wsUJNN/KYrHu7+MEOWhQP6Tr83HmoTp1bVXSmVjm+R9pcBQtbUFsWKbmH43kTnI6LcM5R1rZeszX6SwHvIidNPZy5Oi1QRSrmzdfemagVOFJjxY6UoyQ1r64wmIlbXV+AhJgdfRa+By6Kvo4evDo6dWNwXhyN5XSsRcY1zqsr4XreB0l+eYV/In1ehHeNcW9Q7RX6nAAcYfCAHQ9pF3Us5UxxVToEWY6heTd+mxcKD/TviW1HmB/yLgey/YUOHiyhHUn87x/1L8E/mCTeCEOew==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(5660300002)(53546011)(82960400001)(38100700002)(122000001)(316002)(6506007)(71200400001)(6512007)(26005)(38070700005)(110136005)(54906003)(508600001)(186003)(6486002)(2906002)(8936002)(2616005)(4326008)(36756003)(66946007)(107886003)(91956017)(8676002)(66556008)(66446008)(64756008)(66476007)(76116006)(31686004)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?M3hob2lZcERPbXkrSWszeFlwL1dJeEhRYWVMWktwU1g5Z25jalpYTWJxd0JN?=
 =?utf-8?B?bTQwaUh2Y3B4N0R3b3JGNEZvazlZZzJXamVXMWN0WDJUeE5FblE0Q3JMOUVv?=
 =?utf-8?B?aVoxeFZMeG1BazJQRTAvRUdnUkZFUW4zZkdvdVQ0WWhSU2lkU3NwODMvRXVm?=
 =?utf-8?B?NnJxRGQxS0pka09raGZrZGM0UU01QmNUME9zTmlLRXdHbkJ0ZjZYRExUV05E?=
 =?utf-8?B?dHYvV3pTcS94VUwySy84Q1VKNDlyVldyVlVRZC9Eak1SUkhtZllHS1F5cU1r?=
 =?utf-8?B?ZVBWWE5MN2crUGRLNHZacmdNRlE2YUtVeW55Ym9GTXhnM1IweERqWmVyc1BH?=
 =?utf-8?B?YW5JaVNNRnlVc0Y2UGUyTHprR0NmcWNYQTZYUVhENWcwaERvdDBKMTc1NVhY?=
 =?utf-8?B?SXpTa2hEWkpCWVZiekdiaTBrbzA3VlZSVW9oN2R1RjB4OHFxRG5ZYjhVaGRC?=
 =?utf-8?B?RmE3SW44c2Fhdm54UjFGazByT1VyWThsOVNHSXRFU3NNRGRWbU9yMTF4WFF4?=
 =?utf-8?B?S2xBNnJrMnVTVUpYS0txUG1QT0JSeDBDZnE3eVpnQWp4MTA5eGlySVRnRzZ3?=
 =?utf-8?B?SUQ2Y3Qrbm11QitPRTd3ZVlzQitHQ0FFRVpPRU1mR2U2STBIRzR2d2VRcEw2?=
 =?utf-8?B?QWNra0FoUm9ZMlRnelNVaUhiSU41WUkyaDJkYU1JTWovYVVVTXpXWjIra0tJ?=
 =?utf-8?B?NUMzK3F4M1gzSFAxUUJTa2tzQUpMb0E1VkxGenloemtlQ3ZiQmlaaUZsb1dq?=
 =?utf-8?B?dnJ4MnN6WTY3RWZVZXhRR2xkM2lmT1R6MHVRcFY2U3JZenBlYWcyanFVVHhz?=
 =?utf-8?B?aWZxVUY3Y3pUNzdTR2E5QzEyNUJaSW5ITlpyRTZZSDcwWGRiQk15YlBEUXJU?=
 =?utf-8?B?M0x1L2NGZmNhRmJXY1RYS2JiUStCbEt6Y2E2Y0JJOHNNNE8xODQ2OWRFb0p4?=
 =?utf-8?B?Z2ROdlhhTHpWM1hGbU1iRWxMaXZDVjF1L0xjT3lWTUU5SVVXdTY5dGVMZ2dy?=
 =?utf-8?B?OUFYSVRhbkFha0s4SGtZVXF4SzBZbWEybytyWFc3SE9jU29BYzIyUzgwd1Fz?=
 =?utf-8?B?TVBUQThsMW0yaWxpZjNsY052V3JYeGFPZHpMUzY5VGlOUDFKVGNKekVUN1ds?=
 =?utf-8?B?QzA5dFhSblJ1SUpsZ0ZCUlpEQlZZUXMwQVlKOStSSFQ3NU1qK0o5SnZ1Y0FU?=
 =?utf-8?B?bndoK0tzT2llMUROdnR4QmY4Y2E1cFlWMEpScE8zanNRUlFjbTYzc2lGMDM0?=
 =?utf-8?B?R3hDb2lqSVB5Uitmc0dweG1GbTdZL1lzVm1JWlNiN3NoU1NJdjVJd3U4aG01?=
 =?utf-8?B?eEQyS0hsMkxRK081MlVpRCs1SGFXRzgxR0Jac0hEZWlJK0s3TUZoWFBudGg0?=
 =?utf-8?B?L0h2cXhnM2g4SGV5MlFScmU1d2lwQUdCZlhISTZZZWxXc2QyR0pTZWJCQSsy?=
 =?utf-8?B?OC91NXcxNWdjTGpkemFZTkJxcjBZQnBZRi9kWUhCdGZQQlhyNmpERVZoaVFT?=
 =?utf-8?B?RnEyc3E2K1VMRDhoUUVxcDIvZTQwamZvZDlKRkZ4YXdqZXJWYXowSHlxR2Zm?=
 =?utf-8?B?T0RtWnUwMUt3YXptUEVtN1RNMGJKZjgyOXkzQVZxMGNnSXAvVWloTFZWc2Vk?=
 =?utf-8?B?OVorQmJXeHVEcW9ZMTBkSElYMVNUdVZqdWlxQjU5VVZENUVyRkpPN2Y5Skh1?=
 =?utf-8?B?Yk43NWpiSHNycTlRWGF1Zzl4U3Q3RnRmNDRHVDlyTG9KZmh6UmhMcjFTdDNW?=
 =?utf-8?B?UWcxNCtRQ3BxWkN1aldCTnhzUDNhNGRJMHUya0pTQjFuaW5ETGFWRlZoMHJM?=
 =?utf-8?B?dkRqaVdRWmtick03MUVBM1ozMHNnMTQvd0VsOEVUazVhVkpjQ1BEMTNFMk9l?=
 =?utf-8?B?RXBRMXVTenJOUHNhL2ltMFlHUUdvdnlWRUNWaHpYb2cvekdaZTMyUWkxeHJT?=
 =?utf-8?B?SSs1R0Q5TmNsSDBDU0Nrck5LWWFjaFRUTTQveVNiZU1ET0VOOU92S09DS3hX?=
 =?utf-8?B?RU5JZnFBejhqMW5Lc3krU0pqNnQ0SlVlYllTU1Uybk8wMjBoc2xDWnZPbU1Z?=
 =?utf-8?B?cTJOdXd2QnBWYWF5Z2lnQjJVd1hMeVJLREIzVDV3M2hBbHZxSXVjTmNXbkYv?=
 =?utf-8?B?ejVobkdDejVYbUJSVDQ3bEZSWXdNUk1DWHVmVlBnNkJzWEtnUTU1SzFLSWpJ?=
 =?utf-8?B?bnh6azhKWmM2YmxGT1A5N0llV2t0QStQOEQ5elBqMHVPdWdndFZHdlA5SXJO?=
 =?utf-8?B?bzFweUo2RkxTRzU2eFFjc0w1d1lkRmxybEVibWpmSzZUMUtCWDIrYkJBa3Bp?=
 =?utf-8?B?a0ZkUmFRVHBUMVJReTNWSlJOVzRTcnEvY0VtWjh3eUU4REV6RGE1N0RJb0I0?=
 =?utf-8?Q?RKL76ROFQ9W9Ad40=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1BB23B597898634F98E9B23613285414@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b83b1842-c3c6-44ef-825d-08da2850144f
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 13:16:02.9283
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: alhT/UqQCv/8od9LdwGrPbNqM5HJMUdBo+jIhYThcQjXru7JzCOhfAroXCDqOroz/WmcAL2Mr40JdLVakmbmuClFrcoyIBtoavvxGxDcKYw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4532

T24gMjUvMDQvMjAyMiAwOTozMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEFzIG9mIDY4YThhYTVk
NzI2NCAoImlvbW11OiBtYWtlIG1hcCBhbmQgdW5tYXAgdGFrZSBhIHBhZ2UgY291bnQsDQo+IHNp
bWlsYXIgdG8gZmx1c2giKSB0aGVyZSdzIG5vIG5lZWQgYW55bW9yZSB0byBoYXZlIGEgbG9vcCBo
ZXJlLg0KPg0KPiBTdWdnZXN0ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRy
aXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+
DQo+IC0tLQ0KPiB2MzogTmV3Lg0KPg0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9p
b21tdS5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMNCj4gQEAgLTMw
OCwxMSArMzA4LDkgQEAgaW50IGlvbW11X21hcChzdHJ1Y3QgZG9tYWluICpkLCBkZm5fdCBkZg0K
PiAgICAgICAgICAgICAgICAgICAgIGQtPmRvbWFpbl9pZCwgZGZuX3goZGZuX2FkZChkZm4sIGkp
KSwNCj4gICAgICAgICAgICAgICAgICAgICBtZm5feChtZm5fYWRkKG1mbiwgaSkpLCByYyk7DQo+
ICANCj4gLSAgICAgICAgd2hpbGUgKCBpLS0gKQ0KPiAtICAgICAgICAgICAgLyogaWYgc3RhdGVt
ZW50IHRvIHNhdGlzZnkgX19tdXN0X2NoZWNrICovDQo+IC0gICAgICAgICAgICBpZiAoIGlvbW11
X2NhbGwoaGQtPnBsYXRmb3JtX29wcywgdW5tYXBfcGFnZSwgZCwgZGZuX2FkZChkZm4sIGkpLA0K
PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsdXNoX2ZsYWdzKSApDQo+IC0gICAgICAg
ICAgICAgICAgY29udGludWU7DQo+ICsgICAgICAgIC8qIHdoaWxlIHN0YXRlbWVudCB0byBzYXRp
c2Z5IF9fbXVzdF9jaGVjayAqLw0KPiArICAgICAgICB3aGlsZSAoIGlvbW11X3VubWFwKGQsIGRm
biwgaSwgZmx1c2hfZmxhZ3MpICkNCj4gKyAgICAgICAgICAgIGJyZWFrOw0KDQpIb3cgY2FuIHRo
aXMgcG9zc2libHkgYmUgY29ycmVjdD8NCg0KVGhlIG1hcF9wYWdlKCkgY2FsbHMgYXJlIG1hZGUg
b25lIDRrIHBhZ2UgYXQgYSB0aW1lLCBhbmQgdGhpcyB3aGlsZSBsb29wDQppcyB1bmRvaW5nIGV2
ZXJ5IGl0ZXJhdGlvbiwgb25lIDRrIHBhZ2UgYXQgYSB0aW1lLg0KDQpXaXRob3V0IHRoaXMgd2hp
bGUgbG9vcCwgYW55IGZhaWx1cmUgYWZ0ZXIgdGhlIGZpcnN0IHBhZ2Ugd2lsbCBlbmQgdXANCm5v
dCBiZWluZyB1bm1hcHBlZC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:21:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:21:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315029.533350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhbO-0003rT-Rv; Wed, 27 Apr 2022 13:21:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315029.533350; Wed, 27 Apr 2022 13:21:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhbO-0003rM-Oz; Wed, 27 Apr 2022 13:21:06 +0000
Received: by outflank-mailman (input) for mailman id 315029;
 Wed, 27 Apr 2022 13:21:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XDBb=VF=dingwall.me.uk=james-xen@srs-se1.protection.inumbo.net>)
 id 1njhbN-0003rG-Kb
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:21:05 +0000
Received: from smarthost01a.ixn.mail.zen.net.uk
 (smarthost01a.ixn.mail.zen.net.uk [212.23.1.20])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df779714-c62c-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 15:20:57 +0200 (CEST)
Received: from [217.155.64.189] (helo=mail0.xen.dingwall.me.uk)
 by smarthost01a.ixn.mail.zen.net.uk with esmtpsa
 (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1)
 (envelope-from <james-xen@dingwall.me.uk>)
 id 1njhbG-0002DE-FM; Wed, 27 Apr 2022 13:20:58 +0000
Received: from localhost (localhost [IPv6:::1])
 by mail0.xen.dingwall.me.uk (Postfix) with ESMTP id 2823F38D83F;
 Wed, 27 Apr 2022 14:20:58 +0100 (BST)
Received: from mail0.xen.dingwall.me.uk ([IPv6:::1])
 by localhost (mail0.xen.dingwall.me.uk [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id ChNz8o_Pf73n; Wed, 27 Apr 2022 14:20:57 +0100 (BST)
Received: from webmail.private.dingwall.me.uk (apache0.xen.dingwall.me.uk
 [IPv6:2a02:8010:698e:302::c0a8:123])
 by mail0.xen.dingwall.me.uk (Postfix) with ESMTPSA id C8E0E38D83A;
 Wed, 27 Apr 2022 14:20:57 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df779714-c62c-11ec-8fc2-03012f2f19d4
X-Virus-Scanned: Debian amavisd-new at dingwall.me.uk
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_d67c980548a7c71900f7f58f949ecdb6"
Content-Transfer-Encoding: 7bit
Date: Wed, 27 Apr 2022 14:20:53 +0100
From: James Dingwall <james-xen@dingwall.me.uk>
To: xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@citrix.com>, pdurrant@amazon.com
Subject: Re: [PATCH] fix invalid frontend path for set_mtu
In-Reply-To: <YmkKGVa1NeKBQV9M@perard.uk.xensource.com>
References: <20220301093513.GA3187840@dingwall.me.uk>
 <YlV4lXZHz52xPBzt@perard.uk.xensource.com>
 <20220419120418.GA232637@dingwall.me.uk>
 <YmkKGVa1NeKBQV9M@perard.uk.xensource.com>
Message-ID: <19d42d2f0981f0187508612011b847af@dingwall.me.uk>
X-Sender: james-xen@dingwall.me.uk
X-Originating-smarthost01a-IP: [217.155.64.189]
Feedback-ID: 217.155.64.189

--=_d67c980548a7c71900f7f58f949ecdb6
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2022-04-27 10:17, Anthony PERARD wrote:
> On Tue, Apr 19, 2022 at 01:04:18PM +0100, James Dingwall wrote:
>> Thank you for your feedback.  I've updated the patch as suggested.  
>> I've also
>> incorporated two other changes, one is a simple style change for 
>> consistency,
>> the other is to change a the test for a valid mtu from > 0 to >= 68.  
>> I can
>> resubmit the original patch if either of these are a problem.
> 
> The style change is fine, but I'd rather have the change to the
> mtu check in a different patch.
> 
> Otherwise, the patch looks better, thanks.

Here is a revised version of the patch that removes the mtu change.

Thanks,
James
--=_d67c980548a7c71900f7f58f949ecdb6
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=set-mtu-frontend-path.diff
Content-Disposition: attachment;
 filename=set-mtu-frontend-path.diff;
 size=1928

Y29tbWl0IGY2ZWM5MjcxNzUyMmU3NGI0Y2MzYWE0MTYwYjhhZDY4ODRlMGI1MGMKQXV0aG9yOiBK
YW1lcyBEaW5nd2FsbCA8amFtZXNAZGluZ3dhbGwubWUudWs+CkRhdGU6ICAgVHVlIEFwciAxOSAx
Mjo0NTozMSAyMDIyICswMTAwCgogICAgVGhlIHNldF9tdHUoKSBmdW5jdGlvbiBvZiB4ZW4tbmV0
d29yay1jb21tb24uc2ggY3VycmVudGx5IGhhcyB0aGlzIGNvZGU6CiAgICAKICAgICAgICAgICAg
aWYgWyAke3R5cGVfaWZ9ID0gdmlmIF0KICAgICAgICAgICAgdGhlbgogICAgICAgICAgICAgICAg
bG9jYWwgZGV2Xz0ke2RldiN2aWZ9CiAgICAgICAgICAgICAgICBsb2NhbCBkb21pZD0ke2Rldl8l
Lip9CiAgICAgICAgICAgICAgICBsb2NhbCBkZXZpZD0ke2Rldl8jKi59CiAgICAKICAgICAgICAg
ICAgICAgIGxvY2FsIEZST05URU5EX1BBVEg9Ii9sb2NhbC9kb21haW4vJGRvbWlkL2RldmljZS92
aWYvJGRldmlkIgogICAgCiAgICAgICAgICAgICAgICB4ZW5zdG9yZV93cml0ZSAiJEZST05URU5E
X1BBVEgvbXR1IiAke210dX0KICAgICAgICAgICAgZmkKICAgIAogICAgVGhpcyB3b3JrcyBmaW5l
IGlmIHRoZSBkZXZpY2UgaGFzIGl0cyBkZWZhdWx0IG5hbWUgYnV0IGlmIHRoZSB4ZW4gY29uZmln
CiAgICBkZWZpbmVzIHRoZSB2aWZuYW1lIHBhcmFtZXRlciB0aGUgRlJPTlRFTkRfUEFUSCBpcyBp
bmNvcnJlY3RseSBjb25zdHJ1Y3RlZC4KICAgIExlYXJuIHRoZSBmcm9udGVuZCBwYXRoIGJ5IHJl
YWRpbmcgdGhlIGFwcHJvcHJpYXRlIHZhbHVlIGZyb20gdGhlIGJhY2tlbmQuCiAgICAKICAgIEFs
c28gY2hhbmdlIHVzZSBvZiBgLi4uYCB0byAkKC4uLikgZm9yIGEgY29uc2lzdGVudCBzdHlsZSBp
biB0aGUgc2NyaXB0LgogICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBKYW1lcyBEaW5nd2FsbCA8amFt
ZXNAZGluZ3dhbGwubWUudWs+CgpkaWZmIC0tZ2l0IGEvdG9vbHMvaG90cGx1Zy9MaW51eC94ZW4t
bmV0d29yay1jb21tb24uc2ggYi90b29scy9ob3RwbHVnL0xpbnV4L3hlbi1uZXR3b3JrLWNvbW1v
bi5zaAppbmRleCA0MmZhNzA0ZThkLi43YTYzMzA4YTllIDEwMDY0NAotLS0gYS90b29scy9ob3Rw
bHVnL0xpbnV4L3hlbi1uZXR3b3JrLWNvbW1vbi5zaAorKysgYi90b29scy9ob3RwbHVnL0xpbnV4
L3hlbi1uZXR3b3JrLWNvbW1vbi5zaApAQCAtMTcxLDcgKzE3MSw3IEBAIHNldF9tdHUgKCkgewog
ICAgIGxvY2FsIG10dT0kKHhlbnN0b3JlX3JlYWRfZGVmYXVsdCAiJFhFTkJVU19QQVRIL210dSIg
IiIpCiAgICAgaWYgWyAteiAiJG10dSIgXQogICAgIHRoZW4KLSAgICAgICAgbXR1PSJgaXAgbGlu
ayBzaG93IGRldiAke2JyaWRnZX18IGF3ayAnL210dS8geyBwcmludCAkNSB9J2AiCisgICAgICAg
IG10dT0iJChpcCBsaW5rIHNob3cgZGV2ICR7YnJpZGdlfXwgYXdrICcvbXR1LyB7IHByaW50ICQ1
IH0nKSIKICAgICAgICAgaWYgWyAtbiAiJG10dSIgXQogICAgICAgICB0aGVuCiAgICAgICAgICAg
ICBsb2cgZGVidWcgIiRicmlkZ2UgTVRVIGlzICRtdHUiCkBAIC0xODQsMTEgKzE4NCw3IEBAIHNl
dF9tdHUgKCkgewogCiAgICAgICAgIGlmIFsgJHt0eXBlX2lmfSA9IHZpZiBdCiAgICAgICAgIHRo
ZW4KLSAgICAgICAgICAgIGxvY2FsIGRldl89JHtkZXYjdmlmfQotICAgICAgICAgICAgbG9jYWwg
ZG9taWQ9JHtkZXZfJS4qfQotICAgICAgICAgICAgbG9jYWwgZGV2aWQ9JHtkZXZfIyoufQotCi0g
ICAgICAgICAgICBsb2NhbCBGUk9OVEVORF9QQVRIPSIvbG9jYWwvZG9tYWluLyRkb21pZC9kZXZp
Y2UvdmlmLyRkZXZpZCIKKyAgICAgICAgICAgIGxvY2FsIEZST05URU5EX1BBVEg9IiQoeGVuc3Rv
cmVfcmVhZCAiJFhFTkJVU19QQVRIL2Zyb250ZW5kIikiCiAKICAgICAgICAgICAgIHhlbnN0b3Jl
X3dyaXRlICIkRlJPTlRFTkRfUEFUSC9tdHUiICR7bXR1fQogICAgICAgICBmaQo=
--=_d67c980548a7c71900f7f58f949ecdb6--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:22:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:22:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315039.533361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhd6-0004SS-7Z; Wed, 27 Apr 2022 13:22:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315039.533361; Wed, 27 Apr 2022 13:22:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhd6-0004SL-4e; Wed, 27 Apr 2022 13:22:52 +0000
Received: by outflank-mailman (input) for mailman id 315039;
 Wed, 27 Apr 2022 13:22:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njhd4-0004SC-Us
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:22:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njhd4-0006Pg-2N; Wed, 27 Apr 2022 13:22:50 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njhd3-000602-PT; Wed, 27 Apr 2022 13:22:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=R4xkNqTwt0kcG0EheB+qkncHGbovRkUehNDbKlxc9f4=; b=QvBSMV
	u6pzFR7c2wnI1OwTdRH44wU+NECi20YqydUqceXzGWtzRQrj7M0GZ86LBBkh76L2RiIW/Eq5BPZnE
	PGdz/SrJ13T6EPTRqir+Sb//ZcTDqLhm24tdoFtRs68V2UZiDAZCOp+8aaP2bTzQEE5lLaPHlfhu4
	ZUN2AHNe7wY=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] SUPPORT.MD: Correct the amount of physical memory supported for Arm
Date: Wed, 27 Apr 2022 14:22:46 +0100
Message-Id: <20220427132246.52715-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

As part of XSA-385, SUPPORT.MD gained a statement regarding the amount
of physical memory supported.

However, booting Xen on a Arm platform with that amount of memory would
result to a breakage because the frametable area is too small.

The wiki [1] (as of April 2022) claims we were able to support up to
5 TiB on Arm64 and 16 GiB. However, this is not the case because
the struct page_info has always been bigger than expected (56 bytes
for 64-bit and 32-bytes for 32-bit).

I don't have any HW with such amount of memory. So rather than
modifying the code, take the opportunity to use the limit that should
work on Arm (2 TiB for 64-bit and 12 GiB for 32-bit).

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 SUPPORT.md | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index 088dda9561c1..1e3c69a07615 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -50,9 +50,10 @@ For the Cortex A57 r0p0 - r1p1, see Errata 832075.
 
 ### Physical Memory
 
-    Status: Supported up to 8 TiB
-
-Hosts with more memory are supported, but not security supported.
+    Status, x86: Supported up to 8 TiB. Hosts with more memory are
+                 supported but not security support.
+    Status, Arm32: Supported up to 12 GiB
+    Status, Arm64: Supported up to 2 TiB
 
 ### Physical Memory Hotplug
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:25:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:25:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315045.533372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhfx-00054X-LE; Wed, 27 Apr 2022 13:25:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315045.533372; Wed, 27 Apr 2022 13:25:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhfx-00054Q-IA; Wed, 27 Apr 2022 13:25:49 +0000
Received: by outflank-mailman (input) for mailman id 315045;
 Wed, 27 Apr 2022 13:25:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njhfv-00054K-PV
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:25:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njhft-0006Tj-Fi; Wed, 27 Apr 2022 13:25:45 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njhft-00068R-9h; Wed, 27 Apr 2022 13:25:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=nMXH8l8MNnMvfSortO4ZHoY4ODmQBreP7ovBtrDD79I=; b=a+HIWdTJmeJOal/EIC9C1Za8lV
	m9sfMLTl6Zyp313LgPgbKSnX8WXJKpLVcTtYknp5ej+dZaYazSGuAXbZLV3EMhbIurd3R1PetCy1l
	2qjAQh2xLZeInXnA+0Yz5J+ZxsgAg9yBYW1EibIDZA0pNYaZVqBbHzgHMjluWEsMiGEc=;
Message-ID: <27f0e94c-b935-f898-5316-0f25d72785b2@xen.org>
Date: Wed, 27 Apr 2022 14:25:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH] SUPPORT.md: extend security support for hosts to 12 TiB
 of memory
From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4c49e4cf-9d86-e630-a1bb-37afdf091c99@suse.com>
 <6ec0e3d9-374c-1caa-9889-f091dcf894e3@xen.org>
 <44883899-a696-31e1-c134-019de999d796@suse.com>
 <26ca3b75-6bd2-008f-b393-45ba11f3d0ac@xen.org>
In-Reply-To: <26ca3b75-6bd2-008f-b393-45ba11f3d0ac@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 06/04/2022 16:23, Julien Grall wrote:
> On 06/04/2022 16:22, Jan Beulich wrote:
>> On 06.04.2022 17:15, Julien Grall wrote:
>>> On 06/04/2022 15:44, Jan Beulich wrote:
>>>> c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very
>>>> much memory"), as a result of XSA-385, restricted security support to
>>>> 8 TiB of host memory. Extend this to 12 TiB, putting in place a guest
>>>> restriction to 8 TiB in exchange.
>>>
>>> And this is even without CONFIG_BIGMEM?
>>
>> Yes. BIGMEM only matters when memory extends past the 16 TiB boundary
>> (i.e. when frame numbers with ore than 32 significant bits appear).
> 
> Thanks for the confirmation!
> 
>>
>>>> --- a/SUPPORT.md
>>>> +++ b/SUPPORT.md
>>>> @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra
>>>>    ### Physical Memory
>>>> -    Status: Supported up to 8 TiB
>>>> +    Status: Supported up to 12 TiB
>>>
>>> I am afraid this limit is going to be too high for Arm. Even the
>>> previous one was technically incorrect. From [1], it should be:
>>>     - 5TB for arm64
>>>     - 16GB for arm32
>>
>> May I ask that you submit a patch correcting this, and I'll rebase
>> on top of that? I can't really fit such an adjustment under the
>> umbrella of the title and purpose of this change.
> 
> Sure. I will submit one soon.

I have submitted a patch: 
https://lore.kernel.org/xen-devel/20220427132246.52715-1-julien@xen.org/T/#u

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:32:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:32:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315051.533383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhm4-0006YP-Ag; Wed, 27 Apr 2022 13:32:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315051.533383; Wed, 27 Apr 2022 13:32:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhm4-0006YI-73; Wed, 27 Apr 2022 13:32:08 +0000
Received: by outflank-mailman (input) for mailman id 315051;
 Wed, 27 Apr 2022 13:32:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nU4i=VF=redhat.com=thuth@srs-se1.protection.inumbo.net>)
 id 1njhm2-0006Y8-5h
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:32:06 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a5fd090-c62e-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 15:32:00 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-148-nK8wegdCPM-TDGnzXO5hFQ-1; Wed, 27 Apr 2022 09:31:59 -0400
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com
 [10.11.54.9])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B59E9804184;
 Wed, 27 Apr 2022 13:31:58 +0000 (UTC)
Received: from thuth.com (dhcp-192-232.str.redhat.com [10.33.192.232])
 by smtp.corp.redhat.com (Postfix) with ESMTP id B24C257AF7C;
 Wed, 27 Apr 2022 13:31:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a5fd090-c62e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1651066322;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding;
	bh=zYhgACUWQgq9l8pXl+6GzDv56SU2M/vIYGGXa0gaxtU=;
	b=fAnRZqzF7JoZgHHt0AvemjreflGrWGOcEkYe0hM2PplP2vLxvhhcvD4hC9/GdM5Bm/ncg3
	trHTGQLqXne9SnGww8rIGd9at9T8Z3jxSq8BIVrBLYS3upwwnYcAgBvgqw2IRMZ7wWvLqa
	omcGNp4SqgWCR00dLQXfO2R6kq4fp1w=
X-MC-Unique: nK8wegdCPM-TDGnzXO5hFQ-1
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-trivial@nongnu.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH] qemu-options: Limit the -xen options to x86 and arm
Date: Wed, 27 Apr 2022 15:31:56 +0200
Message-Id: <20220427133156.344418-1-thuth@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9

The Xen hypervisor is only available on x86 and arm - thus let's
limit the related options to these targets.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qemu-options.hx | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 1764eebfaf..cc3a39d21a 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -4184,16 +4184,17 @@ SRST
 ERST
 
 DEF("xen-domid", HAS_ARG, QEMU_OPTION_xen_domid,
-    "-xen-domid id   specify xen guest domain id\n", QEMU_ARCH_ALL)
+    "-xen-domid id   specify xen guest domain id\n",
+    QEMU_ARCH_ARM | QEMU_ARCH_I386)
 DEF("xen-attach", 0, QEMU_OPTION_xen_attach,
     "-xen-attach     attach to existing xen domain\n"
     "                libxl will use this when starting QEMU\n",
-    QEMU_ARCH_ALL)
+    QEMU_ARCH_ARM | QEMU_ARCH_I386)
 DEF("xen-domid-restrict", 0, QEMU_OPTION_xen_domid_restrict,
     "-xen-domid-restrict     restrict set of available xen operations\n"
     "                        to specified domain id. (Does not affect\n"
     "                        xenpv machine type).\n",
-    QEMU_ARCH_ALL)
+    QEMU_ARCH_ARM | QEMU_ARCH_I386)
 SRST
 ``-xen-domid id``
     Specify xen guest domain id (XEN only).
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:32:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:32:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315055.533393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhmO-0006xW-N1; Wed, 27 Apr 2022 13:32:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315055.533393; Wed, 27 Apr 2022 13:32:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhmO-0006xP-Jd; Wed, 27 Apr 2022 13:32:28 +0000
Received: by outflank-mailman (input) for mailman id 315055;
 Wed, 27 Apr 2022 13:32:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=y66U=VF=citrix.com=prvs=1094d0c61=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1njhmN-0006tm-4C
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:32:27 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7899e4f4-c62e-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 15:32:26 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7899e4f4-c62e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651066345;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=wrwKGNtKYufMgXXR3VkOrkrXHZN+6wnoyHeHuiDPaMA=;
  b=gDAxpkbPsiELuajgQrmkh2nAzlir9AjtKnG91s7C0g1am5kqPnB7SF8x
   9exebuoQNGU/IWqwYPDwt9EMuRXRiOChGYMbWjI5L7B3XDdsJzyOLFDH1
   rp6QtedbquT8bhK1XtrrcUItI9fsBSy2MSqJJpyXrv7HjPUgTU/yj4CEa
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69441042
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EGQwGqMWh3Ujq7/vrR2jl8FynXyQoLVcMsEvi/4bfWQNrUoq1TMAz
 GseXm6DOPuJYzSgLo13b4qx/EhUvJHWztc3QAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NEw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5
 Y9wjq2pa10QD6juvcsHXidXAzFfFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQTKqCP
 pJFM1KDajzZIF4UGQZMUaljs/64wX/fLRRghXKa8P9fD2/7k1UqjemF3MDuUsSGWN9Pl0CEj
 mvD9nb+BFcRM9n34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/C8h1X7S99ZA
 0AV/CUxpKw2skmmCMT+NyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEApFAN6WcUE7vYHQB4P+
 UWEodz5FR1G5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn
 mvU9HRWa6A715Zj6kmtwbzQb9tATLDtRxV92AjYV3nNAuhRNN/8PNzABbQ2AJ99wGelorup4
 SBsdyu2trlm4XSxeMulGrhlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG0O
 B6I5VkJu8QIZhNGiJObhKrrVawXIVXIT4y5Bpg4kPITCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnDO7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGKr95OdQxacSlT6FKfg5U/S9Nv6zFOQAkJY8I9C5t4E2C5t8y5Ttv1w
 0w=
IronPort-HdrOrdr: A9a23:Rs3h3KHQq78Z7RpJpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5
 uIGJIeNDSfNzdHsfo=
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="69441042"
Date: Wed, 27 Apr 2022 14:32:20 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: James Dingwall <james-xen@dingwall.me.uk>
CC: <xen-devel@lists.xenproject.org>, <pdurrant@amazon.com>
Subject: Re: [PATCH] fix invalid frontend path for set_mtu
Message-ID: <YmlF5OyrcxwcKwUz@perard.uk.xensource.com>
References: <20220301093513.GA3187840@dingwall.me.uk>
 <YlV4lXZHz52xPBzt@perard.uk.xensource.com>
 <20220419120418.GA232637@dingwall.me.uk>
 <YmkKGVa1NeKBQV9M@perard.uk.xensource.com>
 <19d42d2f0981f0187508612011b847af@dingwall.me.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <19d42d2f0981f0187508612011b847af@dingwall.me.uk>

On Wed, Apr 27, 2022 at 02:20:53PM +0100, James Dingwall wrote:
> commit f6ec92717522e74b4cc3aa4160b8ad6884e0b50c
> Author: James Dingwall <james@dingwall.me.uk>
> Date:   Tue Apr 19 12:45:31 2022 +0100
> 
>     The set_mtu() function of xen-network-common.sh currently has this code:
>     
>             if [ ${type_if} = vif ]
>             then
>                 local dev_=${dev#vif}
>                 local domid=${dev_%.*}
>                 local devid=${dev_#*.}
>     
>                 local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid"
>     
>                 xenstore_write "$FRONTEND_PATH/mtu" ${mtu}
>             fi
>     
>     This works fine if the device has its default name but if the xen config
>     defines the vifname parameter the FRONTEND_PATH is incorrectly constructed.
>     Learn the frontend path by reading the appropriate value from the backend.
>     
>     Also change use of `...` to $(...) for a consistent style in the script.
>     
>     Signed-off-by: James Dingwall <james@dingwall.me.uk>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks!


> diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh
> index 42fa704e8d..7a63308a9e 100644
> --- a/tools/hotplug/Linux/xen-network-common.sh
> +++ b/tools/hotplug/Linux/xen-network-common.sh
> @@ -171,7 +171,7 @@ set_mtu () {
>      local mtu=$(xenstore_read_default "$XENBUS_PATH/mtu" "")
>      if [ -z "$mtu" ]
>      then
> -        mtu="`ip link show dev ${bridge}| awk '/mtu/ { print $5 }'`"
> +        mtu="$(ip link show dev ${bridge}| awk '/mtu/ { print $5 }')"
>          if [ -n "$mtu" ]
>          then
>              log debug "$bridge MTU is $mtu"
> @@ -184,11 +184,7 @@ set_mtu () {
>  
>          if [ ${type_if} = vif ]
>          then
> -            local dev_=${dev#vif}
> -            local domid=${dev_%.*}
> -            local devid=${dev_#*.}
> -
> -            local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid"
> +            local FRONTEND_PATH="$(xenstore_read "$XENBUS_PATH/frontend")"
>  
>              xenstore_write "$FRONTEND_PATH/mtu" ${mtu}
>          fi


-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:35:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:35:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315064.533405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhoo-0007n3-51; Wed, 27 Apr 2022 13:34:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315064.533405; Wed, 27 Apr 2022 13:34:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhoo-0007mw-1D; Wed, 27 Apr 2022 13:34:58 +0000
Received: by outflank-mailman (input) for mailman id 315064;
 Wed, 27 Apr 2022 13:34:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njhom-0007mj-FY
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:34:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d02be7e7-c62e-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 15:34:50 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-dbXcQQGYPpelA_6uwElz9w-1; Wed, 27 Apr 2022 15:34:49 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM4PR0401MB2260.eurprd04.prod.outlook.com (2603:10a6:200:4b::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 27 Apr
 2022 13:34:48 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 13:34:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d02be7e7-c62e-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651066493;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hEBStFJ/uoGURVVIk+WdXrlLzR8PNzTyTLMEmgZey2Y=;
	b=U2/anU0IYUuEdJ+bVLX13BLqsRccmNl6Ookpk/tN+S/5kA3z5wrCX4tyR+HjgwCB6FVE7P
	FEMc+ybNtwQz1kYkmLmpMtb1R4rJYNQG95CdklpyqbWcI1LpdSV9SY0XZ6eAWM2PYPYs3E
	nER+zmO2BDezqcG1xZqUsY/XBPR6KoE=
X-MC-Unique: dbXcQQGYPpelA_6uwElz9w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MPXtkSfrFrk21KAhCqBNWg76LzJabOqfHhILY8G2nRBDlBg6ZJ4SkOM/bIlbKxS0ysjrkgzLm0P4sXutFd3GHsWyeMhhvj7suDrzIBI3oy1SQ3u1dxFE1dowah+CuApaHk/4ldi1LWotg3XUEBolnNXWg4Ea1dUKjhog85ITgO1cZAqIJk364odTHqZFYNUvgtKTFzj5PieYgsLgDRM75DIxX0o0WZrVKAORF6nBSkcj0n7RcmD8gYNyDxB4o1+Fid+RAYHL+qrKlJht/ww1vf2pwnf22SE9vWu2NKs0/mN0yoWbpSgJwT6Q+oNRpLKNBhbiJvJI8HB8I1yrl3wOww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hEBStFJ/uoGURVVIk+WdXrlLzR8PNzTyTLMEmgZey2Y=;
 b=AKucEPcka60mk8ke/bgG9KYBMkfzYTFRHqcBELmQ5BuwB2UGB06XkJYj+7RWNqvJBhsn/kPrbm7nMPnMGcDvonluN3Sv9kEMMwtO1IJASHRhd+JflJ4Xl7Jy3vKjpSde5zUWaAaYDUW2HC+VdqIk/WTTU4SBLYAx9QMUccISVaiG1rhOYr2UyI8eg5uqhanpNegMvHh8nGTbJz5MJIeTV/f8PMdOhWVaXcHygVIwJKSHEuUWWZTDMDe28O16BvlUugYijfcj1ekExxuWYCYw96XbZZgkMF1Y+1//ZUAn84eTxl53ejRiHO9u2q/sZtb6vlXn9v1OJhVFq88UV0lRUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <066202e1-f4c8-be2e-4eb0-45a977d1de5e@suse.com>
Date: Wed, 27 Apr 2022 15:34:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] SUPPORT.MD: Correct the amount of physical memory
 supported for Arm
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: bertrand.marquis@arm.com, Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220427132246.52715-1-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427132246.52715-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0100.eurprd04.prod.outlook.com
 (2603:10a6:20b:50e::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8d37e28c-b96f-47f4-11cc-08da2852b2cd
X-MS-TrafficTypeDiagnostic: AM4PR0401MB2260:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR0401MB22601D3666CC930B16007246B3FA9@AM4PR0401MB2260.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AX0xCYypKYSJZi/hRzWNCkvITc2Clbi8hcDtiWPRr44YNVEEnqqqBh8bmp4gynzp2fDBJgw87wpeDUKXBkBztI1e+gOApcR1wgNEXY4tg1+NtiI70S/yqbPhWJXg5XnboVo4D8725BMpltu/c2+vvjD/Wn/MXTaB1e4Byypi05B9HoFBSz9cWOvK70wPE4CxnNM228mjwvHLUWrComIlMbUOO8xJ/ccc69XMYHwOBIJ8EDOCaCCQmsLRpC9gPkfGvWFNNa5YiXMCbM4suZGzIfdpB8cpWyCgZKYGHwpHr7uLdGSfmKD7M3omEaCidHeUm84XOYnoE7q4to70M0RO2yPdK7VjJFYLXuv6sQC1dZtmaDI+1+bSkxMEeMz06V9nhTwoLPh42xxrRtjQkYj7t7byUJ5/bacw1WHtabJEpU93s1YPigVWnMdq6qhwdqgnK0l2lglbPJ4KKtJK7yzApy4NEcRevjrAzxid9gBG7LZZwqx+UNpmx5DGVqVa3R9bvSvC8cMQYJrZWHaJm2sNUHEYykA9xxSrnoriFq/Wf5DCchVp1ENx+Tq8ESTFt6kiGShrRfwP1wA7WGtkPwGhFfTWii+zLJicrDbSvI8r/AI8BD6lKNba7hzbBdQRC166CPGiK91AP+qS2nxrtiLYEX9SX3K4QNTSFcK9efpr8UucCzvUHGsm7GMh0TcCmgTbvqp1Z6Ex+2bNUqxzdOTNppkGmjcqG1p7ICG4RcSjsKk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(2906002)(6512007)(26005)(2616005)(31696002)(83380400001)(186003)(66556008)(66946007)(66476007)(5660300002)(4744005)(8676002)(4326008)(38100700002)(31686004)(508600001)(36756003)(6486002)(8936002)(6916009)(54906003)(316002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TUg3OEVGSzltQyt4RVpPZzkvblA0QzVPUXBPaE90WWw5UGJjR2NOVWZsNytY?=
 =?utf-8?B?bkhKWnRacTR2dVQ2S3k3dkRJYW01cmVtZ1BPM3lYYStwcHBKKzRLUkRGMmgw?=
 =?utf-8?B?VHRoR0VnWCtuY2dCRVRqVDAvTzdwQXBod0t5VmhMdEdZQitWZC9xMnBRMmdj?=
 =?utf-8?B?azY4bFA5UVNra2IvaGlRYlI0d0kzVlFIbmhPUGNPMEw3WmthbngreVNUL2VZ?=
 =?utf-8?B?M1hMMlFobmU3NGtlNk1zWTArQk9hVWdDWUYvUlY2cmswUE5LazNYbHZlL1p6?=
 =?utf-8?B?WHpXd2E1R2MvNVlxWkhESytabjZaSGtrU0xIbGczVlc1eGNLWWZJSXNaTVBa?=
 =?utf-8?B?OTlYQktUYkx6UUF4bzd6ZzJBUUh5Mm0xdk5LSkZ4YmdjMFVIS2U1SnVFUmRC?=
 =?utf-8?B?ZUtCMzBaVmJMUGtmekZkcXYwb09UUHJSeTBDU250ak8zTnYzSVFjNjNJbWRw?=
 =?utf-8?B?T0tsWTJ6OHUvOUc5ZUJUWklnTFovOWFQU0xRMFdQVGhHZGlqdWltd0JJdHRJ?=
 =?utf-8?B?OGlhcXhsdi82NmdQbWUvam54TjYwY011SmNJeURJbVhGZUVFRzlVN1RCNDZr?=
 =?utf-8?B?dCsxMEhOS1JiblQzUTJSd0xJbDk0YkdOWkNaU3pVb2VuN0Z0VDZvaWtyZDQ3?=
 =?utf-8?B?dzM2Qk5JS2JVUEJyb296OGcvL3VmcmVyeTd6UW1JSTlhaVBEc0p3d1NMeGIz?=
 =?utf-8?B?UkozZkQ5OVd3OHcyUzNCSmlSTXhjWk9QT1J2KzhmbFpsUU5GcktJSkZXZDRh?=
 =?utf-8?B?S2Fpd1Byc3VZelNNMklDN1RxYmhNVFc1K0l5ZzFaOGgzUUx5U1libjIwbnNH?=
 =?utf-8?B?d1hjL2pLaEliV25OWHNaL01DWWVvY1FWQ3B3bU1KMEVUYjlkdlh3Nlp4bmU1?=
 =?utf-8?B?Mzl2ZzVxajRvMys1MFViZFJJR0xpQ0I3VkpZQW14dXNpd1owZEFhMWJhWmo0?=
 =?utf-8?B?ZEZxV216eEE2d01SaXBTdWJ4eXB0dTJ4R3dUeHN1Z3dSQ0p2MzBsYWlyTEF5?=
 =?utf-8?B?VTFoS04zL0NmbDUyditrRmg3REpTcnRjYWFiemJ3VVhWSVAybkx2U0NyQlcv?=
 =?utf-8?B?ekw0clBFdWZRN09PdEw0SXMwTHU5VFlSbkcwQkM4cUJHQ2pOWVNCU3hQd1kw?=
 =?utf-8?B?NHoyNFBIM1h1eWRUak5Felg3RnlESmpHUlUrSVRZdVZNc25OWkcyOFV3YzBs?=
 =?utf-8?B?bXkrVU1YaGh0c2h2bHVUQlQwMkQvRFFnY0NpMndwMDJTZVBxcGJ1Y2ZZS1B2?=
 =?utf-8?B?OW1heVllTmpZTnFhcjBIMnNybEc0VTZyaFZqc1hETEltcUN1bHNJeE1WRjVZ?=
 =?utf-8?B?OStJRTcrcm90bzcyT1JyeGhmOUw0a2J1cUd2TnhyM0QySmI2cDFiMWtZdUIr?=
 =?utf-8?B?d0VZVmFGYkhadzhvRk1wYUtjaFFUUDZpcDU2d2VFK0doVGxKd3g4ck5hODg4?=
 =?utf-8?B?WkxmNVo4aVFWTGY0VVNRVDF0dWRVbFNWcUE1U0QrRmFScDRlUUpoK01zS01h?=
 =?utf-8?B?QnN6ejNSVU5SMW9JWGpER3lBbURvRVVZNXpRVHRSZ1JVdjFZMGJtSytiNGk1?=
 =?utf-8?B?M2JkSEtmWFI5WXJSN053blI5SFM2MURkb0xSRnA5RGVVNy94WlZZcTJCelpF?=
 =?utf-8?B?dGh6YWxPbWhwQTdhRjJXY1pVT05JTSs5K1hnTEZUR1UwazgxTUlkRGg4RDR0?=
 =?utf-8?B?VkVma3M3K0hnSGRnMmtaNHNHYW1oWnY1ZG5HdnRvazRvYUpRd3hvRWdpWjdQ?=
 =?utf-8?B?ak1QdGhIVmNJUHRDZGRLT0JxVWM0eGxYRVhYK1d1SGZMM3RJb2s3Ujd2MjVy?=
 =?utf-8?B?cVNZaWhtSXZ3N25DajFidnNTQ20ybFBPd01SMUxwL1hMZzBsclNoRGZDd1U0?=
 =?utf-8?B?K25MYkFaZitxUEVoMUpSMit6eldESW1VVGFQZHlQNFRobldxdXhlTnIrNG04?=
 =?utf-8?B?NlVUOFpxRjgyRm9rVzhUWVRFM20yc0h6YmtLUDdrMUpZZUxxa0Q4cDZ4SWlH?=
 =?utf-8?B?UGoxMjNWZHpSZTNhVjg4d2htSEdmeDgxbXRQa1lOaTFHeUpqdU9QRTdiN250?=
 =?utf-8?B?Y0FxbnNTNGNSY2t4bG0vVkVlNG82elU0V09icGpsdUJlWUxPeE44dVN6VHBU?=
 =?utf-8?B?VzBNQTBzam04ZlVZcURycWZHVm5ERlBrQmRqYTl1V2ZpL3BUZUNNdXBoUFhy?=
 =?utf-8?B?RDBBMXlSbTFIaUNzSU5sbzJrZ0NIaUM2NHE1YW03bGRlTGNjWDRUb1Q5NDBP?=
 =?utf-8?B?V0p0YkprTXdCUm02MVVHbVdZSzJwanFYVTUyQ0RLNm1Ec1Q1b3hDRGpyZDAr?=
 =?utf-8?B?ZExJZXZkYVJCTEk4WlB0QlR0dVNEQmZPQUx5YzU5MnA3R0lIMENiUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d37e28c-b96f-47f4-11cc-08da2852b2cd
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 13:34:47.9965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mR/3ZHPRme5UBdDgzItNw3Tpi1tRDIfVxKiMkSpVrcGg0DyQBddo+sA/ba8DxXPHHdWVPJyuRhf0GW8M+Xp0SQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2260

On 27.04.2022 15:22, Julien Grall wrote:
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -50,9 +50,10 @@ For the Cortex A57 r0p0 - r1p1, see Errata 832075.
>  
>  ### Physical Memory
>  
> -    Status: Supported up to 8 TiB
> -
> -Hosts with more memory are supported, but not security supported.
> +    Status, x86: Supported up to 8 TiB. Hosts with more memory are
> +                 supported but not security support.

Nit: "supported" also in the 2nd instance, as it was before. I think
retaining the comma would also be beneficial.

> +    Status, Arm32: Supported up to 12 GiB
> +    Status, Arm64: Supported up to 2 TiB

This really will need to be ack-ed by an Arm person, so I don't see
value in me providing an ack.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:39:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:39:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315071.533416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhsm-0008R9-Ly; Wed, 27 Apr 2022 13:39:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315071.533416; Wed, 27 Apr 2022 13:39:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhsm-0008R2-Iy; Wed, 27 Apr 2022 13:39:04 +0000
Received: by outflank-mailman (input) for mailman id 315071;
 Wed, 27 Apr 2022 13:39:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=y66U=VF=citrix.com=prvs=1094d0c61=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1njhsl-0008Qw-7e
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:39:03 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62b730a9-c62f-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 15:38:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62b730a9-c62f-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651066741;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=KEH0uihlxnEuFRyeMAETigwL92GSAiyMausO3tgEKXc=;
  b=aVUcHpD2/qymEeGtofl4juOI5g0V9aeuChsOlAdqnsMthv7uTIGNfLqR
   BaWmuaKGNyqYsGrUaCPlPyYEnTDeWAWYI0ARekEJOnK3RY6kIZOcRhmr8
   ZXHMkZjBYP/dpdMZoaF0f/y6777rPrFPJPCpUGtvg3TV5wauKb3g+g3zB
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69925381
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YUFkT6NsV8N8MLXvrR1El8FynXyQoLVcMsEvi/4bfWQNrUp01TBWy
 mMeWzuGaf+KZWagfNl0bI62pB5Tu5KHnN5lTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NEw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1
 tISsr6qRjUQHffxn/hNejBxIz9XMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQTKeEO
 pFJMFKDajzyehFwPnotCqgap7aMqViiTzFKknWs8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTQY8XCfik7P90gVSX7moUDhIQSB28u/bRola3RtZ3O
 0ESvC00osAa71e3R9PwWxm5pn+svRMGXddUVeog52ml06fR/kOVC3YJShZHb9opstJwQiYlv
 neVn871BRR1vbGVQG7b/bCRxRuxIyEFIGsqfyIITQIZpdLkpekblhjISMRiFq+dlND5GTjsh
 TuNqUADa6471JBRkf/hpBae3mzq9sOhohMJChv/QGX66SFja7ycRNaV7kSLxN9pHJiwQQzU1
 JQboPS24OcLBJCLsSWCRuQRAb2kj8q43C3gbU1HRMd4qWn0k5K3VcUJuWwleh81WioRUWWxC
 HI/rz+983O60JGCSaZsK7y8BM0xpUQLPYS0D6uEBjaij3UYSeNmwM2MTRPIt4wOuBJ1+U3aB
 Xt8WZzxZUv28Yw9kFKLqx41iNfHPBwWy2LJXozcxB+6y7eYb3P9Ye5bbQPfNbxjtPzf+1+9H
 zNj2yyikUs3bQEDSnOPrd57wa4icBDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/89qws8x
 VnkAhUw4AOm3RXvcFzaAlg+OOKHdcsu9hoTYH1zVWtELlB+OO5DGo9ELMBpFVTmncQ+pcNJo
 w4tJpvQX6wTGmiWk9nfBLGkxLFfmN2QrVrmF0KYjPIXJvaMmyShFgfYQzbS
IronPort-HdrOrdr: A9a23:XuoJnazq7VB1nUORQ7P1KrPwLL1zdoMgy1knxilNoRw8SKKlfu
 SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ
 0QFZSWY+eQMbEVt6nH3DU=
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="69925381"
Date: Wed, 27 Apr 2022 14:38:45 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Thomas Huth <thuth@redhat.com>
CC: <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>,
	<kraxel@redhat.com>, <qemu-trivial@nongnu.org>,
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled
 in
Message-ID: <YmlHZTcghklUZjok@perard.uk.xensource.com>
References: <20220427123316.329312-1-thuth@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220427123316.329312-1-thuth@redhat.com>

On Wed, Apr 27, 2022 at 02:33:16PM +0200, Thomas Huth wrote:
> The 'xenfb' parameter for the '-vga' command line option is currently
> always enabled unconditionally (since the xenfb is not a proper QOM
> device that could be tested via its class name). That means it also
> shows up if Xen is not enabled at all, e.g. like this:
> 
>  $ ./qemu-system-sparc -vga help
>  none                 no graphic card
>  xenfb                Xen paravirtualized framebuffer
>  tcx                  TCX framebuffer (default)
>  cg3                  CG3 framebuffer
> 
> Let's avoid this situation by fencing the parameter with the
> CONFIG_XEN_BACKEND switch.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:39:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:39:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315073.533427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhtG-0000Tp-Tp; Wed, 27 Apr 2022 13:39:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315073.533427; Wed, 27 Apr 2022 13:39:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhtG-0000Ti-Qo; Wed, 27 Apr 2022 13:39:34 +0000
Received: by outflank-mailman (input) for mailman id 315073;
 Wed, 27 Apr 2022 13:39:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njhtF-0000TX-IJ
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:39:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njhtA-0006iu-Ri; Wed, 27 Apr 2022 13:39:28 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njhtA-0007Fd-Ky; Wed, 27 Apr 2022 13:39:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=oQEdwBmNPJJr+RVjgIrjDpu6U+aAHy+3RVtHczzXuuE=; b=yhlKUhqpFGfsJGuKw56SehZ19J
	F+yavbpH8xXzvuOHZMN02i07DRBLLulyvMiMDZ9wQcK19GYmNpFNwgnWzD7NI7o8vEN/7K+Jie2PY
	TnlR4qccvMMvaK1iMU6PIGdxofNJjUmMwtHoDjlHNnIw29OxXAoxm1kZeBWNmxBo8+sY=;
Message-ID: <e55c5c99-f3e7-58ae-08be-76dee88e87c5@xen.org>
Date: Wed, 27 Apr 2022 14:39:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH] SUPPORT.MD: Correct the amount of physical memory
 supported for Arm
To: Jan Beulich <jbeulich@suse.com>
Cc: bertrand.marquis@arm.com, Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220427132246.52715-1-julien@xen.org>
 <066202e1-f4c8-be2e-4eb0-45a977d1de5e@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <066202e1-f4c8-be2e-4eb0-45a977d1de5e@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 27/04/2022 14:34, Jan Beulich wrote:
> On 27.04.2022 15:22, Julien Grall wrote:
>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -50,9 +50,10 @@ For the Cortex A57 r0p0 - r1p1, see Errata 832075.
>>   
>>   ### Physical Memory
>>   
>> -    Status: Supported up to 8 TiB
>> -
>> -Hosts with more memory are supported, but not security supported.
>> +    Status, x86: Supported up to 8 TiB. Hosts with more memory are
>> +                 supported but not security support.
> 
> Nit: "supported" also in the 2nd instance, as it was before. I think
> retaining the comma would also be beneficial.

Agree for both. Sorry, I rewrote the sentence rather than copying/pasting.

> 
>> +    Status, Arm32: Supported up to 12 GiB
>> +    Status, Arm64: Supported up to 2 TiB
> 
> This really will need to be ack-ed by an Arm person, so I don't see
> value in me providing an ack.

Bertrand and Stefanos should be CCed. I will wait input from them before 
resending a new version.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:41:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:41:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315083.533438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhvA-0001vt-9q; Wed, 27 Apr 2022 13:41:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315083.533438; Wed, 27 Apr 2022 13:41:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhvA-0001vm-6L; Wed, 27 Apr 2022 13:41:32 +0000
Received: by outflank-mailman (input) for mailman id 315083;
 Wed, 27 Apr 2022 13:41:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njhv8-0001vd-TW
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:41:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id be09ef1d-c62f-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 15:41:29 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-ylW9FP6ZNDCsgBXwYPmDtw-1; Wed, 27 Apr 2022 15:41:28 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR0402MB3924.eurprd04.prod.outlook.com (2603:10a6:208:7::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 13:41:26 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 13:41:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be09ef1d-c62f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651066889;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=B1MaTZqv83n78hfpNPMFFru7Eoqv0EEc5hXN5LJ0Q0c=;
	b=AH3KmLEf+YLmMbZgaS9L8KH8KppjtozHjZ0JcgFZ49bIgzNus96toNvtV3ZzkPRHbh4pNU
	y/SHrdXoB97OD+2aj2bjAaGehGH2jP/RjUxTA9u04kMHio5kvCYEt537RimgdKFEdCavlH
	ItDSo3CybIaGoWATO4WkVUsSMx9/HDY=
X-MC-Unique: ylW9FP6ZNDCsgBXwYPmDtw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hWciRfbw9ivg5I9llN29LMA25ZQM8GPB7LcnBoEjZGEKp7eYMlr75j3H2netaFIjU0Ap1q4LZ/5rE+cBkQeJIlpZ+/wo6mLsYkBWJ2yKIqmWX5UaqMXdWOnfhvwnjJSX3Y1uJK7aQbOqCe73J0/4fWW6XQogPPt6GQai7rCvtJKCc8NHqx3HDcCcfDsS2rC2pdOaEtnprCofZnB3+jHDmgkAHZZtxruC63Opn3ws2fRkJLc8Dx/3BGMBVeIs2Peyn+jSb5i6oGo5rLshR0F5/IYwtmvIyZF4kX9PdFSJftUSemZU4DS7hLRJOjolyK8nwQ4G4bfiF87vZPwZwit4hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hDt1QrWH1q4K1WrV0YJ+3InjJdZzI0wFqbANhOyodeI=;
 b=KeIToGRepSL+11LQ7vEBPOl5E+GUp/Lv7ZSXB16ORCHtkKgCVtVXYKJMIz9gtHHfLSURjCLH8wyrlRWngNbGZhIJCtYBFFfBea+Zt75N3KekaiW2k3n2TiPfGO9H9YptwCEpz746yVBbcWJy6bM8KHZ1VHZGN9j8IRicNLASpLk2bz3o/eKLzqFQtn2jy0Bkh5DEPtsJlHFiUdflAMub/25opI/vWmPYsAdUwOxN7hv1yDCjXdvmuOZdhKcRhRa5EpnI4U5WwN5KSG6NNM4I39Y7/hHKY16PVtBpnNuS9wmzqJVNtquNsLzj15I4dEU7lTIwlDM5RoBB4JadzXwZ2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <47b50c64-b8bd-df95-9de9-175780c50e0b@suse.com>
Date: Wed, 27 Apr 2022 15:41:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
 <Ymk7BjXdyiMUGoc8@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ymk7BjXdyiMUGoc8@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR04CA0010.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: efab0d4f-a92c-485e-c482-08da2853a03c
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3924:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB39243E0BDE62980EE5C5870DB3FA9@AM0PR0402MB3924.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3C2VRtAzHqyYsvxsuCKl+7Rzn13N8+XDTQBmkoDJP6GocnAePu2+g2SZTjOo4QeuJsFrsR0H8nOsS1u6S74opIWwLoUW7lPyTQ2rbiubT6f8hYk277rFgIrul8I7rg6HkjeyeFGqlsfFm0XRpHWNHkFmjusFuQn6vX4fFKVya72Lo7cPXp07/iFeoT+ibNSI7w6+XrpXSAYSHsAgd/BuD8+CVWBsESteH7Sj3S9nIjXVkhkSrRdQgxTySLrwsI0wfrWkjCcPiJwbFI7SsTcZDWR9X0LFkaM9f/N2rJAVK8TP/BdDyZqdGGWqfwbgTQtUQeVKCbw7NWHPLcI9DVwBkvVVgmmjW68AYKBVmyBtCoqF0iw+WEnWgdVf9srlgYEUqmVlH+otuXfv+K1LDeCK7Xh2ZcLwKCFTcz4wO8o92tLE5pMIL7EYK8aFHkpo6iDlhufEiinqub1TpXxoWZreS+Rl27TNIQxb2aFjJOzfFswtUj3KehzbZlqOMhhGWb3Nom5098T9mztY+TiPAfnKF1HeasMUhUn5C+Jt34NTJ6DvhtVGFAwjQy2JSCKqMtIVn1W8j3CJHWnJNzhByvJmWi8OjplmQggVKTm/fsEve/Sl7uT0+nzdMIRFM15pE5TIdK9WpwQm495ve5tmC0Dn183+VXXQ89y21hqy6M0g8UIdIXT+iXV+551bV3BITYjfi7D6Hi90T7/G/kJMfTEnRybj+ToYfc8HQ5JLDej9zwidD22UtzLcCj+GRS6pv7sB01169bRV2hvdu3W+1D4zNTNs2Xrjs2V303Cd9G4lxoAHbE+HWI8xkcGXBaUMwF9K4GSt4UE7RbKcqgXq5pW+lA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(8936002)(186003)(83380400001)(6486002)(31686004)(66946007)(6916009)(4326008)(66556008)(66476007)(2906002)(54906003)(8676002)(53546011)(316002)(26005)(38100700002)(2616005)(6512007)(31696002)(6506007)(508600001)(5660300002)(84970400001)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?S55C/O3LvyOrC6UgM3FNl43lSebtiwtORRVqQJAAWuGLDFJ4rWDf6rQwuc5Y?=
 =?us-ascii?Q?QcY71yeJklhiL6Iacyuz+X9QC9wALn5Od212Lh49Duenrta+9Yl53ctuS80G?=
 =?us-ascii?Q?eL4r5geFf19RDd7OPkhPNKMJxWHzq0yQyeh3eBK7LZoOGPCzg3BviNzeOaLc?=
 =?us-ascii?Q?6C66NhrSq69OzkGPRHFG+8QazizFtA/8PoUTlaWpmz46ivm2Bd3xRvMB2BOI?=
 =?us-ascii?Q?D76oSI1Mz+EGeGJk8vYLODCPQJHZpCNbU2tqKympAv1suMtknhbbRh2X5NMr?=
 =?us-ascii?Q?oV7WQc+CxKBoQkziDTRkbR0+KwKd9EcTkYNw0YmYBJQ096AcJ0pjX52z9Ybe?=
 =?us-ascii?Q?dxCPvYhSPGpjZ/zvHpLOdfLxnx9ywdAlq2X65k7LhIvb5aQYx6QmURbzWh5f?=
 =?us-ascii?Q?WCFcdhaRZ6oq3zYiQARY7LHF/L4lYxOIKVSXwNhnFr1G/v/Quft0cHSG9B+D?=
 =?us-ascii?Q?syDKiIvzmG8Sbn9pQu/H6aucXKsxQAfRXZJWatdlufUC5RSlrp/R2C26bwG8?=
 =?us-ascii?Q?JbglYs8Qr0Gf3OmIOuhU/AD7nSYhOckDexVz4uXVQvdr8Ydj4FzE2dJtTw3B?=
 =?us-ascii?Q?zUbyJwKzPrcaP+q2N+7PC3xMrM7GP9yyJh7JSLe82RBIN48ReGqmYwRTczIk?=
 =?us-ascii?Q?4LRqJgpDfkwEuvi54SS0MLTCXHgjiVDk0FtYzlZkqmV9oFraVhV/kF9e/vdh?=
 =?us-ascii?Q?fx/ptAUOpw+sXaZbAZh9u5ZLwk0LbITW7ubPvGBLktByJDHEFwrMqYDjPUE1?=
 =?us-ascii?Q?HB9Ai331MTDKtl3uIN76UucF3c7iR7tlS1PcZqDCwsYDUX9t4CKJ89LB0ris?=
 =?us-ascii?Q?1zlBOHRdcsggXqEafJ6bE2kyKjJNFUHVAT8y03Et4uIeWHREnf8xAkFqOfM8?=
 =?us-ascii?Q?AoY+xfG7WjV/4uQigkXGPlY8WwMGnhRG8jj9x5uOCC9/GOqhemK5JHR2/4yp?=
 =?us-ascii?Q?4AqtD/9O6aW9bXzzIBNwFfiQd08uoEkOZQd8oE1eSWuZU+n5M9sx/+JyuZhN?=
 =?us-ascii?Q?49NkxAhuw96G1sI1tvy+pvG7KNIvawnnb6YdOz0A0v5bpGNGX2nrPVMaGL5e?=
 =?us-ascii?Q?+M3mXdCk1XskmoAfa13aDcCUcZFJ1RR4JYiXZh91p8tPzovzsER/zg+34Qfo?=
 =?us-ascii?Q?h782AF9CKcGC2EbJ9kayyYEOF2BJpAtff5Q5r3YHoM5Udj0mkn86Smi3LyVw?=
 =?us-ascii?Q?AGPnZgY5hi+SC8fDujEUUu6GuuzLbAc+lEBaQLgKraKTFzW4R30djLK7HGjX?=
 =?us-ascii?Q?/gaYwAeE2NL2irTJmE/WAT8pmdo2CbZrBJtgC9JEDKtViv6Cwzip4VktO27h?=
 =?us-ascii?Q?IOVvDb+6gNfwv8cXB2BN/+Tmw2QcorODnrQMDeXACs0sqjOhazI/Mr9CPd2D?=
 =?us-ascii?Q?lNPKTxvPMQrlg9EQwxT08+083uGkx1roeIsxsUkSDsqXLukeUAjpAltvOZj8?=
 =?us-ascii?Q?U73Fzn7tpawiXlZxzjDjeCGMqKIMNWpH521PnVZ91dp7gLykcz/3d+tABcPu?=
 =?us-ascii?Q?aS8+SnCM/DgFlnZ1xl1w1+FPf2bhdyYxD219lUzxeMHlO4DJQTo6gqrFaEWM?=
 =?us-ascii?Q?3BgkDfVLVOKVW8enesbiufnoELv4khlYmqKKXQDA78AUllwiZY394nb43ZAN?=
 =?us-ascii?Q?jFgFFHoOTKS1/Nd3mPgywpLL1mLOpp9ZYhXI3VgJKFcLcfENGtOfsJUm7oP+?=
 =?us-ascii?Q?Nd8itQTM5oEe36dTX7v4sUedoNGaQzV+iGI5/cdfYZLlhkn1LRRYJC8LTFfx?=
 =?us-ascii?Q?QEyy1O2P6g=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efab0d4f-a92c-485e-c482-08da2853a03c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 13:41:26.3642
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yJkLMf3YqjxyANjwlIFpSCtQJ6mqWpI+mb9NCHsKwF6+ATrDQbjyaPuWvhcik1cDacp+g0TCjecFvtgW7yMzvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3924

On 27.04.2022 14:45, Roger Pau Monn=C3=A9 wrote:
> On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote:
>> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>>
>> On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutual=
ly
>> exclusive - only one of them can be enabled. By default, 'intel_idle' dr=
iver
>> enables C1 and disables C1E. However, some users prefer to use C1E inste=
ad of
>> C1, because it saves more energy.
>>
>> This patch adds a new module parameter ('preferred_cstates') for enablin=
g C1E
>> and disabling C1. Here is the idea behind it.
>>
>> 1. This option has effect only for "mutually exclusive" C-states like C1=
 and
>>    C1E on SPR.
>> 2. It does not have any effect on independent C-states, which do not req=
uire
>>    other C-states to be disabled (most states on most platforms as of to=
day).
>> 3. For mutually exclusive C-states, the 'intel_idle' driver always has a
>>    reasonable default, such as enabling C1 on SPR by default. On other
>>    platforms, the default may be different.
>> 4. Users can override the default using the 'preferred_cstates' paramete=
r.
>> 5. The parameter accepts the preferred C-states bit-mask, similarly to t=
he
>>    existing 'states_off' parameter.
>> 6. This parameter is not limited to C1/C1E, and leaves room for supporti=
ng
>>    other mutually exclusive C-states, if they come in the future.
>>
>> Today 'intel_idle' can only be compiled-in, which means that on SPR, in =
order
>> to disable C1 and enable C1E, users should boot with the following kerne=
l
>> argument: intel_idle.preferred_cstates=3D4
>>
>> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git=
 da0e58c038e6
>>
>> Enable C1E (if requested) not only on the BSP's socket / package.
>=20
> Maybe we should also add a note here that the command line option for
> Xen is preferred-cstates instead of intel_idle.preferred_cstates?
>=20
> I think this is a bad interface however, we should have a more generic
> option (ie: cstate-mode =3D 'performance |=C2=A0powersave') so that users
> don't have to fiddle with model specific C state masks.

Performance vs powersave doesn't cover it imo, especially if down
the road more states would appear which can be controlled this way.
I don't think there's a way around providing _some_ way to control
things one a per-state level. When porting this over, I too didn't
like this interface very much, but I had no good replacement idea.

>> --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c
>> +++ unstable/xen/arch/x86/cpu/mwait-idle.c
>> @@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
>> =20
>>  static unsigned int mwait_substates;
>> =20
>> +/*
>> + * Some platforms come with mutually exclusive C-states, so that if one=
 is
>> + * enabled, the other C-states must not be used. Example: C1 and C1E on
>> + * Sapphire Rapids platform. This parameter allows for selecting the
>> + * preferred C-states among the groups of mutually exclusive C-states -=
 the
>> + * selected C-states will be registered, the other C-states from the mu=
tually
>> + * exclusive group won't be registered. If the platform has no mutually
>> + * exclusive C-states, this parameter has no effect.
>> + */
>> +static unsigned int __ro_after_init preferred_states_mask;
>> +integer_param("preferred-cstates", preferred_states_mask);
>> +
>>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
>>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1. *=
/
>>  static unsigned int lapic_timer_reliable_states =3D (1 << 1);
>> @@ -96,6 +108,7 @@ struct idle_cpu {
>>  	unsigned long auto_demotion_disable_flags;
>>  	bool byt_auto_demotion_disable_flag;
>>  	bool disable_promotion_to_c1e;
>> +	bool enable_promotion_to_c1e;
>=20
> I'm confused by those fields, shouldn't we just have:
> promotion_to_c1e =3D true |=C2=A0false?
>=20
> As one field is the negation of the other:
> enable_promotion_to_c1e =3D !disable_promotion_to_c1e
>=20
> I know this is code from Linux, but would like to understand why two
> fields are needed.

This really is a tristate; Linux is now changing their global variable
to an enum, but we don't have an equivalent of that global variable.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:42:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:42:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315088.533449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhvl-0002Xa-MP; Wed, 27 Apr 2022 13:42:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315088.533449; Wed, 27 Apr 2022 13:42:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njhvl-0002XT-JG; Wed, 27 Apr 2022 13:42:09 +0000
Received: by outflank-mailman (input) for mailman id 315088;
 Wed, 27 Apr 2022 13:42:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=y66U=VF=citrix.com=prvs=1094d0c61=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1njhvk-0001vd-Hj
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:42:08 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3d27cee-c62f-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 15:42:07 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3d27cee-c62f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651066927;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=1EftjlPb2D5bL7c8oYZxtZPU4mzZ887UzPNIbQPwjq4=;
  b=Vuqj9yHe8z4ecevIFHOzI3ErcBcqOAUJaAdHAcsVt1RAnHYI6syru7Mk
   C8Pp2AspppJ/PQYyO8PZ6m4MRUWbe4CL2euYcE5nj9G1vkXY0cgPFqKFf
   RYeKGU/clB05kDsfpFWn54A3ICiCxgknSO9K5Fimbyob0wP1cF4aEPHJq
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69441940
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DQCqGapzxtXLq/t4U5DfJiBap9JeBmLMZRIvgKrLsJaIsI4StFCzt
 garIBmDbPqJZWb8etwja4Sx8hhXusLVnYJhSwM/qSo1RnhHoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 4yq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBFJDrw+cSFBpjLiBmLIlY2bzsOleOmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY
 qL1bBIxPUicOkwTYj/7Dro3gtyBqWPddwR0tRXEo/U++G6U0jBuhe2F3N39JYXRGJQ9clyjj
 nrM+GLrAxcbHMaSxTqM7jSngeqntTr2XZ9XCKe56P9jhHWVwWocDgBQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c8JZDukS+AyLjK3O7G6xGmgZUj5pctEqtMYqAzct0
 zehht7sGHljvaOYTVqb8bGbqy70PjIaRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65uAZAhmpn
 WrM9nJnwexO04hbjM1X4GwrnRqGm7+STQFy5T7qX3q0yh1YZ6W+SL2BvA2zAel7EK6VSVyIv
 X4hkseY7fwTAZzlqBFhUNnhD5nyua/bbWS0bUpHWsB4qm/zoyLLkZV4umkWGat/DioTldYFi
 mf3sBgZ2pJcNWDCgURfM9PoUJRCIUQN+L3YuhHogjhmP8AZmOyvpngGiausM4fFyhVErE3HE
 c3HGftA9F5DYUid8BK4Rv0GzZggzT0kyGXYSPjTlkr6ievFOCTNFuxeajNii9zVC4ve/m3oH
 yt3bZPWm32zrsWjCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJb9JIJUJfsLUcaU9U9xcx9z76Ql
 lnkAx8w4Aev1BXvdFTRAlg+OeyHYHqKhS9iVcDaFQ3zgCZLjEfGxPp3SqbbipF6qrw+laIkE
 6htlgfpKq0ndwkrMg81NfHVxLGOvjzx7e5SF0JJuAQCQqM=
IronPort-HdrOrdr: A9a23:DpnpmamqKWNV1nOW1Z4xPcpiZaLpDfIs3DAbv31ZSRFFG/Fxl6
 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79
 YCT0EXMqyXMbEQt6fHCWeDfOod/A==
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="69441940"
Date: Wed, 27 Apr 2022 14:41:52 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Thomas Huth <thuth@redhat.com>
CC: <qemu-devel@nongnu.org>, Stefano Stabellini <sstabellini@kernel.org>, Paul
 Durrant <paul@xen.org>, Paolo Bonzini <pbonzini@redhat.com>,
	<qemu-trivial@nongnu.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] qemu-options: Limit the -xen options to x86 and arm
Message-ID: <YmlIICWzw0wDBE31@perard.uk.xensource.com>
References: <20220427133156.344418-1-thuth@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220427133156.344418-1-thuth@redhat.com>

On Wed, Apr 27, 2022 at 03:31:56PM +0200, Thomas Huth wrote:
> The Xen hypervisor is only available on x86 and arm - thus let's
> limit the related options to these targets.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:51:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:51:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315098.533459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nji4d-00044d-Iz; Wed, 27 Apr 2022 13:51:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315098.533459; Wed, 27 Apr 2022 13:51:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nji4d-00044W-G5; Wed, 27 Apr 2022 13:51:19 +0000
Received: by outflank-mailman (input) for mailman id 315098;
 Wed, 27 Apr 2022 13:51:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bzB+=VF=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nji4b-00044Q-Gi
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:51:17 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on062e.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::62e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1ae1578b-c631-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 15:51:15 +0200 (CEST)
Received: from AS9P250CA0019.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::23)
 by DB6PR08MB2853.eurprd08.prod.outlook.com (2603:10a6:6:1d::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 27 Apr
 2022 13:51:12 +0000
Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:532:cafe::a7) by AS9P250CA0019.outlook.office365.com
 (2603:10a6:20b:532::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend
 Transport; Wed, 27 Apr 2022 13:51:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Wed, 27 Apr 2022 13:51:12 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Wed, 27 Apr 2022 13:51:11 +0000
Received: from cf7b74148849.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D8B14CDF-7017-473D-895E-EC4B16A79A3F.1; 
 Wed, 27 Apr 2022 13:51:05 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cf7b74148849.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 27 Apr 2022 13:51:05 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB4881.eurprd08.prod.outlook.com (2603:10a6:20b:c8::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 13:51:03 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 13:51:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ae1578b-c631-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=BeQzg3o7eIWyaWlEjxzow+/2ZIvElTHn1MxAwyYueq2dw3jwysaa8zocHbq//0sPoTNlhWwWGRKh05BLMiTbvRsNMAmJI5MyKRDV5BYFzHYQ9gfx4MmSOUsGfulrY8vz1zbTmaocLmX9WdWHluL/q22+iBSGSs1sOeXN2dKF1lPdfZthHdijOcpXUo+p5nB6HKTFV6Oc6rPVqXMMp0VbyDNV1d1wl3QIB3fYoD87ZwU1vG1pGDIlXeUqN3ZAd5TYZ28upidPfQM+9BLfcW90VbAdVC4pJd/wUrE5qEjA0PFx8658mDZohSQyLipOjnd+QuGYQI796vrQ8gegIWpDqQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D9Htmx+KZWw2gmZcWEuzpZEkvFES4J2c3eFst/alGYA=;
 b=fZcfg+akAJ7vM4xfld+T3r/S+87K+ZZw6scDIplbpXRDYd30+FBOamlbvECazEKUfx7cp1qm4XSdkUSn+2OgsGym45RB8zx36jR3BAAq5nZ0lm+OF8MbSAg9gVyP1MwYgp8Z63YhVygjD7GosiYn/B8LTV62OaJhGXpmCkL4+9evKw3xKLofEe8uftdpMIE9pSdTwqGoKWLekH/NuW36/+R/fDluekYTIjUK0BBypb6MMvZyihEwOOa0ClYOINw5FCSNGKva0HKCl9UiWQdmsZHA1Zhhl0AjDhH/GfwL8ddbnK9bF1Lxz8xgkVhtj+RB5M3AysC8Qde112q/2G/0Aw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D9Htmx+KZWw2gmZcWEuzpZEkvFES4J2c3eFst/alGYA=;
 b=Ihq1i0TkVUopbVFkj02ndHz/UkOPZF7T2c2cQn3CI0TD4/GsurooNYx8Bf4qtvqI2wh9w526XuCNEdtQAslCIg5edNpXj9XPLBLHA2mXewrGuhsdXY7qFaqPfEKLCGnpWDHvJIHBroZQb9Nd+2y3nAzJQ19SJBvlDHySuanyY3c=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 537a857bb6577d5e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UvcxBIBiBMj7/UUsPDG/wWB4NgdJsOEPPqwfFp3vA93RmiVp+ydo+RRKeqmWBcHYHAjbabN2/P+NP3xWC1yLTNZS3VjF7YYZHTpHodcK/DNZFurG/fF4zhi8bh6jeWVYAn6RvEgsY3MtUZDpz/yrQPvBcGM+s9wkYkB0dCO8cz9y6RtjQ066W8XsaahlaKvAREf9y8VP5MIHsXI6cymdoPiCTRLR4kG4paEBtzkpXryB5QAHxVtTNql9lIRNPmR9z8IVHhJy8YwNH0CLEhK1qqRX7OE9V5gJzI/HBqjDbWBJW2V+Ux1iRXpPDrWcVi5nEVLHDwYTi466C8ByvsfghQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D9Htmx+KZWw2gmZcWEuzpZEkvFES4J2c3eFst/alGYA=;
 b=YfNN8t+YcPmEI5mlVJj10vobQQ4EGLGiU8yQcAwWIsWVd59rlOgQ0DGe/hWy+RKO2j4fE5u1f/8Hv5T6gCiFpISbn2GXMyThn8RZUQkn6VgG/y6FWlte3UJth+PHfkj8d+9cD4iCwm6eX6f3aPk5G5vs3VXt5SroehfnXPTMfoZRf3nFj/5nwormzBDfwfpe4JSE13Q3HN2ndpX23ImJv9FMxNYIQ4VVV4sdvDlHOfkY+RHbwHIQl/sE3UDki5GmEO9e/t035m4FUueLzI+4dfE/qX21RfFC+IYTwxruxeO6G/f9asGfew1Z1A0IzRFqNjVZ64BK5R417Djr62YmGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D9Htmx+KZWw2gmZcWEuzpZEkvFES4J2c3eFst/alGYA=;
 b=Ihq1i0TkVUopbVFkj02ndHz/UkOPZF7T2c2cQn3CI0TD4/GsurooNYx8Bf4qtvqI2wh9w526XuCNEdtQAslCIg5edNpXj9XPLBLHA2mXewrGuhsdXY7qFaqPfEKLCGnpWDHvJIHBroZQb9Nd+2y3nAzJQ19SJBvlDHySuanyY3c=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall
	<jgrall@amazon.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] SUPPORT.MD: Correct the amount of physical memory
 supported for Arm
Thread-Topic: [PATCH] SUPPORT.MD: Correct the amount of physical memory
 supported for Arm
Thread-Index: AQHYWjoysOpjhra2zUGfwjKV6P+iV60DxzaA
Date: Wed, 27 Apr 2022 13:51:03 +0000
Message-ID: <2AFEFEE2-DDF7-42EB-A1AD-88642596152C@arm.com>
References: <20220427132246.52715-1-julien@xen.org>
In-Reply-To: <20220427132246.52715-1-julien@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 68ed816a-4d5e-477e-a639-08da2854fd85
x-ms-traffictypediagnostic:
	AM6PR08MB4881:EE_|VE1EUR03FT014:EE_|DB6PR08MB2853:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR08MB28532286C2183DBA017C2BCB9DFA9@DB6PR08MB2853.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NdzeYAgJkewWr+nD8SY6M2DTRDyQ1uezIqUnMMEahPLgi8Qvf+ZGiHmx8o1bD3IFb85HXop6P4rdi+xbu/qFolzrSUcZfRAgx1D47xc5Ii07JnrNWaae/2tt574ovqXW+83iimP6JkiAa7e6CDkCjqldNNc6lni3L69qpHy9KDje9CJol6PDi5wc0MYwQ925ndCkZCXnK6WpZkAnt5b3POfO9Zc7PjEOwk4HN55w0SAoumQi5x6OgHd9fVUR3Gxaiyggiy4H0Mo/gWQroDoOkKcRNmzVk5AARvsEBL37jl2L8X2+Jio5nmb5jqJRp/RUYeB6RF5CwRxItf/3XqXLnzfnriIFpK6HTGEI9sXMZcvSl1WyLko6OuEZoocnVCUgDE08o84W4PJ9MZ6dWZn2oiEKjsb7JC4NPQXXIWzQ5Rb8pOmn8B8avFj2cLT26wtuLUW2ZsDc0G6IrP40/bl/ca0wSJ3pgn46drdZ6exJBnDVgtT6HGCSjypDKruKyYIqGXP8qNmDlgGBKvHu//nQ2OQ1uqwBOpjidIqkLxOWjC9jzyJiL79RDGsKMUgkUPeXfc06UayQLJ0U1SnKBpVH1tiqRL/vojlsIO4o7ehCUe9OXAvuZEjAv9xD3F2gKEDT1jYXx1+rYT9kj2q7V+WK+Yq6aTka4fH+ThXD9sZevRlcJpETPU7oIltc9Ji1ecuJLyShhAyww4j6ktR6wcZsoy6/re1ZNMQqmXC6c0BPy/5HX5nm5DLD44xAKtiUBwHF
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(53546011)(5660300002)(6506007)(6916009)(38070700005)(54906003)(6512007)(26005)(38100700002)(36756003)(8936002)(2616005)(83380400001)(186003)(6486002)(508600001)(71200400001)(33656002)(76116006)(86362001)(66946007)(91956017)(316002)(64756008)(66446008)(66476007)(66556008)(8676002)(4326008)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <96D2F92452D08342BE70ABD88CB0E7A1@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4881
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6fb3a92c-e5e3-4e58-90ae-08da2854f868
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	v0SxaGDXT6n5s6m/0SQoa1ll/HzC4K2/MRYkS6Sm6KuLkUNnYtKQKOi2AYdzmFV59QYwQZuKHR2kg6t3qvI11oRVPHzO/kY3d8Rli6BSyhlG9B1fsUvsB0PVcgkA9rzUvfxMZX98HXNUTr68E7bUe16+lW3OFQ+NeSAvtSatVyIL9K0s1eSkS3FBwini6VxNP44Ec8m/YumKJKWr3KqGiD6mcpdWRYxlZRgZeKAnFJojVeN8C74wnStZlSBjNCGev/kFpCtX5VK/fdIl7aavKUHRiDG9UX3Ha4oEat7xvFy7V7+wJ2RTaR0AJx8EzGS6Kp64X5NyWS57aiMTwn+lj1LLTAXKr+msK+pUrhjyLchYOdd+wHwkhdPTLxHJR5rZaRXB3Glql7CKiBQL6PFBfIpy9YCZkXCdOdTq0ykJhwTBRxPuweATbvVie67M3O8TEn1qTMQc7M2c4x3bRnZ4xV7xZ8nIqWgw1VctAoC3SwYdYNUTmZtS3O4Fp5kyo0U49SkbQvKI1rCUv8Uj+EYPBjtLCmmXu8CFEF8jkZK/2muHOzgxbBmcdr24uEIHyT0oUgK/5sBe7+hckyqFC59KlIjq883P/07MKGMpqz3btwIm+QDS9ASRS1D7R5SghFbwounJzfkB6g/+ZMfByii0ITAdN3WlyzXGRjx7GdHME6PvmfZRreDwE0fYpZ5Esn95
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(2616005)(186003)(47076005)(86362001)(40460700003)(2906002)(33656002)(6486002)(8936002)(6862004)(36756003)(83380400001)(8676002)(54906003)(356005)(316002)(508600001)(336012)(82310400005)(81166007)(26005)(70206006)(70586007)(6506007)(6512007)(5660300002)(36860700001)(53546011)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 13:51:12.1011
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 68ed816a-4d5e-477e-a639-08da2854fd85
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2853

Hi Julien,

> On 27 Apr 2022, at 14:22, Julien Grall <julien@xen.org> wrote:
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> As part of XSA-385, SUPPORT.MD gained a statement regarding the amount
> of physical memory supported.
>=20
> However, booting Xen on a Arm platform with that amount of memory would
> result to a breakage because the frametable area is too small.
>=20
> The wiki [1] (as of April 2022) claims we were able to support up to
> 5 TiB on Arm64 and 16 GiB. However, this is not the case because
> the struct page_info has always been bigger than expected (56 bytes
> for 64-bit and 32-bytes for 32-bit).
>=20
> I don't have any HW with such amount of memory. So rather than
> modifying the code, take the opportunity to use the limit that should
> work on Arm (2 TiB for 64-bit and 12 GiB for 32-bit).

Sadly I have no hardware either even remotely near this capacity and
I think those limits are right for now so...

>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm part

Cheers
Bertrand

> ---
> SUPPORT.md | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>=20
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 088dda9561c1..1e3c69a07615 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -50,9 +50,10 @@ For the Cortex A57 r0p0 - r1p1, see Errata 832075.
>=20
> ### Physical Memory
>=20
> -    Status: Supported up to 8 TiB
> -
> -Hosts with more memory are supported, but not security supported.
> +    Status, x86: Supported up to 8 TiB. Hosts with more memory are
> +                 supported but not security support.
> +    Status, Arm32: Supported up to 12 GiB
> +    Status, Arm64: Supported up to 2 TiB
>=20
> ### Physical Memory Hotplug
>=20
> --=20
> 2.32.0
>=20



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:52:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:52:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315103.533470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nji5L-0004cg-T1; Wed, 27 Apr 2022 13:52:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315103.533470; Wed, 27 Apr 2022 13:52:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nji5L-0004cZ-QG; Wed, 27 Apr 2022 13:52:03 +0000
Received: by outflank-mailman (input) for mailman id 315103;
 Wed, 27 Apr 2022 13:52:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1GEo=VF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nji5J-0004PU-VN
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:52:01 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3432b235-c631-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 15:51:57 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 63019210E3;
 Wed, 27 Apr 2022 13:52:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 300EC13A39;
 Wed, 27 Apr 2022 13:52:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id BqN+CoBKaWLCZQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 27 Apr 2022 13:52:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3432b235-c631-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651067520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=n+/KEendKGadoDH+AX3puD7Zz06wWWTVBGohmKBxpbM=;
	b=FFW+6EOrcj/T3o1d5ar/qckvvuB+pph4yEN9XrrQOx7J9E/0DuCaH+N9a2XVLPuTjFxWty
	qIx0xy/GOnmJz27xF6BmiL+YNVUw7jB2bt39ef3WUZscznJYONq6BJLjTGcOHE8we4+HHs
	vrwrcmkCtmWPtxhPn8mMuGkg4vPQEM8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Raphael Ning <raphning@gmail.com>
Subject: [PATCH] tools/xenstore: don't let special watches be children of /
Date: Wed, 27 Apr 2022 15:51:56 +0200
Message-Id: <20220427135156.4605-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When firing special watches (e.g. "@releaseDomain"), they will be
regarded to be valid children of the "/" node. So a domain having
registered a watch for "/" and having the privilege to receive
the special watches will receive those special watch events for the
registered "/" watch.

Fix that by calling the related fire_watches() with the "exact"
parameter set to true, causing a mismatch for the "/" node.

Reported-by: Raphael Ning <raphning@gmail.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/xenstore/xenstored_domain.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index ae065fcbee..80ba1d627b 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -231,7 +231,7 @@ static int destroy_domain(void *_domain)
 			unmap_interface(domain->interface);
 	}
 
-	fire_watches(NULL, domain, "@releaseDomain", NULL, false, NULL);
+	fire_watches(NULL, domain, "@releaseDomain", NULL, true, NULL);
 
 	wrl_domain_destroy(domain);
 
@@ -282,7 +282,7 @@ void check_domains(void)
 	}
 
 	if (notify)
-		fire_watches(NULL, NULL, "@releaseDomain", NULL, false, NULL);
+		fire_watches(NULL, NULL, "@releaseDomain", NULL, true, NULL);
 }
 
 /* We scan all domains rather than use the information given here. */
@@ -495,7 +495,7 @@ static struct domain *introduce_domain(const void *ctx,
 
 		if (!is_master_domain && !restore)
 			fire_watches(NULL, ctx, "@introduceDomain", NULL,
-				     false, NULL);
+				     true, NULL);
 	} else {
 		/* Use XS_INTRODUCE for recreating the xenbus event-channel. */
 		if (domain->port)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 13:57:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 13:57:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315110.533481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njiAl-0005JX-HM; Wed, 27 Apr 2022 13:57:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315110.533481; Wed, 27 Apr 2022 13:57:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njiAl-0005JQ-EZ; Wed, 27 Apr 2022 13:57:39 +0000
Received: by outflank-mailman (input) for mailman id 315110;
 Wed, 27 Apr 2022 13:57:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njiAk-0005JK-Bk
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 13:57:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fca5118e-c631-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 15:57:33 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2055.outbound.protection.outlook.com [104.47.2.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-dhnpWpgRN5Ki8L9x4AT5vw-1; Wed, 27 Apr 2022 15:57:35 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB6439.eurprd04.prod.outlook.com (2603:10a6:20b:d8::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 13:57:33 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 13:57:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fca5118e-c631-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651067856;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZX6Q2qIw8ZWRtMMu00Avbk2WY4ydH0MH70DMP2my8sw=;
	b=C6/MzjzUARqWTnlMZCwPu8O8G67mL7ovD8PzLbCcCsl2tdqBkEKjMV4yGoxJGO9x8QFw/Q
	LqEffFDJqQayUK5dkve5Iu5vC6hxdF0980kW5WsIRth9kjObvyo82SHly93mUFUl8Zwmju
	rbGVjZCfR5vBhHnmtkmOUmTAHgSYiD4=
X-MC-Unique: dhnpWpgRN5Ki8L9x4AT5vw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=imZm/26SavVn/suYPXa15InEQQCaJ6QLY30Ps36dkNZCzqSlPg9GMCvy/2F5s5JUG+6SkAcS6+MlsbS8AmfLXvXsLR1caqBwWOKx0wQclAgoNFaUCri99tGYjN1FDWXdquyXCsHflsXvCo4O4nO9KVOjXcZl3gY1UWPouTyDTLB5GM7wls5IWvoZtPhk9JFMbdx2ysu3WwvaC+WaugF1Lv8uPEVTWFHmFeUSh2esoyGUI1xMrglz+nwaRSbcMEGtc/Q029HsEVT0rcJwtLUN3zAPkF2Oqiy3C23ABhw/UfwuW262HUCznVmgIkRx9kESPTZMdYv/D2UctsNR3LiFcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZX6Q2qIw8ZWRtMMu00Avbk2WY4ydH0MH70DMP2my8sw=;
 b=QDB11znjGPa/P/Vo2zUtKP/NcgXEgcs//gMtl9yzfIJLeJpRzuU03DjDTqoaUJlwL0Tq1/sRsVw+rLq7e/jqdnWrdZfo+L60V7HfKJkEyG/UkRgH69H58Hwd7Ymth7LdEWJ7wT6i6IgPTKEMrVItjHA57CwVSHP6+qUnC/L/P/IMBh64M44EC1OPWImntTxSLVorW2RnWTJck0g8NK/vtF0yreI0wg9njCQukW64yRvz9Bzi5ECQGDd3y2oHWcoKvVd71nN62B5n1CftJi8wyYbVMc9bI6FtB/Ka7p1P5/COtll/bd4QmkKVJMFmuOpUS2qXr/rotPIv7IJe0PrG6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f39020e9-f25f-bb82-ee49-fbf595b4d3c8@suse.com>
Date: Wed, 27 Apr 2022 15:57:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4 01/21] AMD/IOMMU: correct potentially-UB shifts
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
 <0dec8285-a348-53d4-f9fa-552c7c1c405f@suse.com>
 <00d978cb-be83-79de-ef02-5b6ad1042f52@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <00d978cb-be83-79de-ef02-5b6ad1042f52@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0075.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c3925af8-3da8-4dc8-b42c-08da2855e0ad
X-MS-TrafficTypeDiagnostic: AM6PR04MB6439:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6439C252C849B2E2E7504F01B3FA9@AM6PR04MB6439.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UuYgwz8QiNBM4r1WbK1zRvMYilHe7bFzKRekx+6t0OVVIb/FZzHJ9mD3rP1UUQfMKMPc6a0A2c4WuIexDexPKaAzhnl5FojnboEMsvTGCzCLOBlx4oVWBpXc55bpwGGvib4Lz0nCLpViFZta0rb47xW5Vnd6bNTQpAKDH3Y0MFjedmjwTudk7yEvMCFho4NBz8DHXw0BTS4fLilvMci9mRCAsZPzozKTib/dvtGJjPCuxVMDkJfNSkzruWk4ly1R1B0Uu6h9zYJfy7+K5QnxCbV2AJDnZOsiLuVeP/bOkSU449yUqdAKtJGA71mh3Q0/6fouY+GFfp9brcutdZ7pBEGRrYhy38XxamQAe+E80crUzHa9ZDzyX10iOqGwAv1YTWcgBp46In/I5xK9TRwnbZBGs8cAAhfW+7HAdWOEPFeNNRa/3XUWI7d8wOamTNcX2W5WNWZsk93cyA31HbBPNd+TEf/V/lsS5tgu2aGALhzh4TBSM7by3nF9RyeMCBEgNUkfHej0YWB/TCgRcmY8kKnPWJJSHDTwnt/op51/nnwh2oK9VClJvWKCmcIsO/BMhqljawJdxfY2MN4J2jujtl98a0vZn56zj34qRS6IXoaPd+QUwZwknIpxT/WQbyxW94Av305BMSvjKQITotcj2nwgj39WAwJisRsW9cRIPFt8ciP/sxjbcIBT1pS4tVY8VtitPiCyYMuOMhzgszS8fEN/DYsPJAcM9jHsymAs5wPjuI6xMn9msZO6ktbFmTuL
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(66476007)(66556008)(66946007)(53546011)(6512007)(26005)(8936002)(31686004)(6506007)(316002)(54906003)(4326008)(5660300002)(6486002)(31696002)(38100700002)(508600001)(86362001)(83380400001)(2616005)(8676002)(186003)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NHlFT09DOW9nMzlmYnd2cWdtUS9QbkFidUlPdXBFUkZibzhCM0VXUHhsNkc3?=
 =?utf-8?B?eXpCYzh1MnE0VjR2bVJmTGo5a1llNDRVUmlvT1NMcDkwZW1aS3ZURlUzMUdM?=
 =?utf-8?B?ZVhhSkczcXRRbmtnWUV5dFVvTG92ekNXcktmMHM4NDdIMVNLTTA4TGlnSWxv?=
 =?utf-8?B?UTFPL3Vub2FBd0pHZ1ZVMWQ2RVdLZnpRdFZ4UGZFL0p4b0hScVpiby8yQ3Zu?=
 =?utf-8?B?WmVlZEpqWVUyekZGTGlMSGtjWFQ5MEJ3SEtJbXE0Sy8zS21hQkV5b2JkRVU0?=
 =?utf-8?B?ZklubzJhYzVWMWZKRlhiRWxBKzZ2ZVllMkNQRThQRkFYYVhrWGt2WmdOQjI5?=
 =?utf-8?B?WmNEY1RvalNzNUp3c0FnWTRHdndZQW5KN0lkblNvWjJ0SnFoLzdiNnE3dmJC?=
 =?utf-8?B?Z01WS0RpVjFBajJDTmpacnBhcWg3RUtGWWlNZWtaRXUyZnhqb2FSMlBPRUUr?=
 =?utf-8?B?K20zaDBrYXpqMmwzdTlLU0cvVWZxL21zNGllQ0x5MGVjOVdhOFhpVTI2ay81?=
 =?utf-8?B?eWlKRjFJdFdLRTFkemJNVU53aEduUkZZanBSK3ZxOWlUNHpoYUk0QUhobERp?=
 =?utf-8?B?VzZ0N2txa0ZKKzhERTBKN0ppUDRuZDVLWlpvRWw1Y1FEWHgrOGQzTGZnVnlF?=
 =?utf-8?B?ZkVDdW0xWk9YTmZheXJUbXc4YlA4dHZMYkNJUHh1Y3c2Q3pqZnRQc3orK0hR?=
 =?utf-8?B?cURiK3FmV1FxVjFhOG5ObzZQNmhNa2hrb2U3b1F4aTlLdDJuOTZtdCtlaXpq?=
 =?utf-8?B?TzgwNGl3NC9ucENaZ2JrUFVid2hVM3NGS0xrRjZvMmFuTjVBNkJhQklMNHZk?=
 =?utf-8?B?UGx5alFJbjhIaGV4WmYzVEVvV2FON2xqaWhYRzRZUVJtbnFFSk1JMitycnBF?=
 =?utf-8?B?Ujh6WXNJSmdHeUJmZU5XYzRGcXlmNCtjNHZpRmU4alI4R2VpMEpDOGxUMzdP?=
 =?utf-8?B?WjlKNTZOZ2FnbGR5eW4yOWNIZmUwdS9xTW56czgzUG5aT2hVNDdGTGNLYUZv?=
 =?utf-8?B?RlZQSGljZ2ZXblU3VHlVeFErSnFNdGM0YnBlNCtIMFlvbkJDc0VvbHZQcFJI?=
 =?utf-8?B?UnVLdE80WlhrcXloaUZ1Mkd5Mng2SmdjRlNQWnV1eUQxcEJlTEd5L1lBUzlK?=
 =?utf-8?B?b3MzTnU1K2cyNDdKOHA1cGZZeTRlVURHWUhiMGdpOVR3Z05WdGk4SGFBQVY4?=
 =?utf-8?B?Z3ZQbmdOdTFITW9xMUlGV3RtaDVTQm9NeXl5VThjRm4xQmJKZjlPRGQvZWRR?=
 =?utf-8?B?b0FOZXJ3RnJySE9PNStxSXVFN2lVQnR4ZU9FR21jQ0YwenFMWVZLdWVjY1ZX?=
 =?utf-8?B?dW9GWTdESHZ6VTM2a3BLV2NFcTlFZ2t4RnVDNnpMWlpHRjVINUU3eEpKM3FG?=
 =?utf-8?B?T1BBdkt3VnI3VWF6Nld6M2VnTTNuTzZ1WVBsMVg1bWU3c0pYQ3VYOWtVL2tV?=
 =?utf-8?B?b29aMzYxWGNqam85eW1jQ0Q3ZjZPenkyd3F0YmU0ZTFtZTZyRVcyNXlIVk1D?=
 =?utf-8?B?c0U0K3FXcXh1dXY2eUdZMWIxNXZDazlaWWppbkFNREJDK0YxNVgwZ2ZJaXE0?=
 =?utf-8?B?cXMxN0JjQ3dOTERMWnFhT0lzYldqYlN5SUFRZ1dvZTJuTjlrcjcyWktsVnll?=
 =?utf-8?B?QndLZjY4TzVYdHduNjQwME1kamtQa0JLR3c0aHZtZ2czVGM0QVYwRkZhT2t5?=
 =?utf-8?B?ZkludFh4TFFoUFpwM1VIbVREUHUrbVBBRDVFVHlxRmQ5VjlaWEFFOFNWN3NO?=
 =?utf-8?B?WXU5MHNqZDl1bWhNRXZBazZxZFphQ0dYeVp2cVpncWtTREs4dHFNZFMxekJV?=
 =?utf-8?B?Z3JrdTNRZVZoZ3kvOGpNNFA0MlNwdDVja0MzR3E4R2ZLNndjSGxSQUpPVERV?=
 =?utf-8?B?elZNcllrUEJYUldOdDJ1d1BTamZyY3lJTVNNL1UvdFJXQ212QnBqdW5DeTRk?=
 =?utf-8?B?Y1dUaDRJYkNjL1lrUERpN2Z1WjRuNmRhYks0RzFpcXpuZ1V1K04xNUdUQ2Qx?=
 =?utf-8?B?OVl0N0FiWnljWGpiQXI1eDUweTdMQWNjWlVkRldYQW5vQUJScnBNaUhLVVlj?=
 =?utf-8?B?MEJOaytaMVB5OW5OS3RZNlJXaWtxV3g3cVRPQ1Zua29PVHRYa01YVXlJVVRu?=
 =?utf-8?B?dWtIMG5tcnpaWU53Sk4zNVZ1RGpNUTc2LzNzZW92UnRQWEJtVFk5YkFhNitT?=
 =?utf-8?B?Q3lvTjJabm1JcmgyS3B1Ymxob0tTelFaMmZacXIzZkJPcWZ2VDU5dVlqc0dZ?=
 =?utf-8?B?ZUNwZGgxcU8xTWFkZUVwYWFCbmdkdjZ6aWt0bHFHZ2tVdTNINEN5R2JWeVdw?=
 =?utf-8?B?STAxclhKOGc4VUFuOGZUNk12QWJLSkVWT2lJSmVtVGJSYWU3R05HZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3925af8-3da8-4dc8-b42c-08da2855e0ad
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 13:57:33.5032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fOtEkmQQ/mgOfv6XAd57BEEzLvFdw/ryokvKhS2Cs/XGJw3XPuEsPMmSKscTGpEb0J1dK3w0Po6Df/FyK+iwYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6439

On 27.04.2022 15:08, Andrew Cooper wrote:
> On 25/04/2022 09:30, Jan Beulich wrote:
>> Recent changes (likely 5fafa6cf529a ["AMD/IOMMU: have callers specify
>> the target level for page table walks"]) have made Coverity notice a
>> shift count in iommu_pde_from_dfn() which might in theory grow too
>> large. While this isn't a problem in practice, address the concern
>> nevertheless to not leave dangling breakage in case very large
>> superpages would be enabled at some point.
>>
>> Coverity ID: 1504264
>>
>> While there also address a similar issue in set_iommu_ptes_present().
>> It's not clear to me why Coverity hasn't spotted that one.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v4: New.
>>
>> --- a/xen/drivers/passthrough/amd/iommu_map.c
>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
>> @@ -89,11 +89,11 @@ static unsigned int set_iommu_ptes_prese
>>                                             bool iw, bool ir)
>>  {
>>      union amd_iommu_pte *table, *pde;
>> -    unsigned int page_sz, flush_flags = 0;
>> +    unsigned long page_sz = 1UL << (PTE_PER_TABLE_SHIFT * (pde_level - 1));
> 
> There's an off-by-12 error somewhere here.
> 
> Judging by it's use, it should be named mapping_frames (or similar) instead.

Hmm, I think the author meant "size of the (potentially large) page
in units of 4k (base) pages". That's still some form of "page size".

> With that fixed, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

If anything there could be another patch renaming the variable; that's
certainly not the goal here. But as said, I don't think the variable
name is strictly wrong. And with that it also doesn't feel entirely
right that I would be on the hook of renaming it. I also think that
"mapping_frames" isn't much better; it would need to be something
like "nr_frames_per_pte", which is starting to get longish.

So for the moment thanks for the R-b, but I will only apply it once
we've sorted the condition you provided it under.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 14:05:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 14:05:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315117.533492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njiHo-0006tu-CV; Wed, 27 Apr 2022 14:04:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315117.533492; Wed, 27 Apr 2022 14:04:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njiHo-0006tn-9b; Wed, 27 Apr 2022 14:04:56 +0000
Received: by outflank-mailman (input) for mailman id 315117;
 Wed, 27 Apr 2022 14:04:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8dk3=VF=citrix.com=prvs=109ad7ccf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njiHn-0006tg-69
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 14:04:55 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0196835d-c633-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 16:04:53 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0196835d-c633-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651068293;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=BekWr44zF1XcL3Qo54apOLEDFyPhI0/bSyWgIKNtiD4=;
  b=AvEl5zqf0tBB8ND76BGgpu1/1B9skIq4XDbYagRYhORoR6Y72mrX3N5Y
   VVtKTyN9RyekeUDGotKXFhwqaAjLHyMBXqrKOUya5k1Mcps6LID5Xc2qN
   GJ/1uGfMSUBXrwMiWAT05MUspNKkinHcwXhjsWbL2/9Vx5caBgxJCUHQm
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69928105
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iUuvxa6K0eHA4tn2F5mMOQxRtEnHchMFZxGqfqrLsTDasY5as4F+v
 jEdUTuEPP6MMWWmKN10Oo+ypEoE6JLSxoRjTgo+q3g3Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjXFvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurTzSik0LIvVod45EBdgOCB3N/Rv5J3IdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RIOGA/NUydC/FJEmkOUoxuhrutulbiXWUGjGO1vpQlumeGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyFvaS1D6E+XKEnfLUkGXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MSqwKj17jy+j+jIisKdhVAYdZ/ndMUSml/v
 rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWuoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvWkvfxszaplfImWBj
 KrvVeR5vsE7AZdXRfUvP9LZ5zoCkMAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPmL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3apXalk0DALGvCsQVmKZKRW03wbEALcieg6RqmiSreVcO9L0JYxMJ/Y4cRg==
IronPort-HdrOrdr: A9a23:DXzUK6smr7I/IZ8cnzi1Pd2F7skDjNV00zEX/kB9WHVpm6yj+v
 xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379
 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu
 v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="69928105"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()
Date: Wed, 27 Apr 2022 15:04:00 +0100
Message-ID: <20220427140400.20152-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for
speculative defence.  Avoid calling it redundantly, and just store the result
of the first call.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/mm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 72dbce43b13a..31b9f96dc0df 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -887,7 +887,7 @@ get_page_from_l1e(
     uint32_t l1f = l1e_get_flags(l1e);
     struct vcpu *curr = current;
     struct domain *real_pg_owner;
-    bool write;
+    bool write, valid;
 
     if ( unlikely(!(l1f & _PAGE_PRESENT)) )
     {
@@ -902,13 +902,15 @@ get_page_from_l1e(
         return -EINVAL;
     }
 
-    if ( !mfn_valid(_mfn(mfn)) ||
+    valid = mfn_valid(_mfn(mfn));
+
+    if ( !valid ||
          (real_pg_owner = page_get_owner_and_reference(page)) == dom_io )
     {
         int flip = 0;
 
         /* Only needed the reference to confirm dom_io ownership. */
-        if ( mfn_valid(_mfn(mfn)) )
+        if ( valid )
             put_page(page);
 
         /* DOMID_IO reverts to caller for privilege checks. */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 14:05:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 14:05:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315122.533504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njiIT-0007PU-Lr; Wed, 27 Apr 2022 14:05:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315122.533504; Wed, 27 Apr 2022 14:05:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njiIT-0007PN-IS; Wed, 27 Apr 2022 14:05:37 +0000
Received: by outflank-mailman (input) for mailman id 315122;
 Wed, 27 Apr 2022 14:05:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njiIS-0007J0-IE
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 14:05:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19ddde23-c633-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 16:05:32 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-vB3fFBK_MWWY2s2L366wEQ-1; Wed, 27 Apr 2022 16:05:34 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8841.eurprd04.prod.outlook.com (2603:10a6:20b:408::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 14:05:32 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 14:05:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19ddde23-c633-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651068335;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/n9Q++3q0pYQZYbGOt+1Me5LfJnrKYNu6hI876RpWg0=;
	b=cTOji2sFZHj0IEwiWtc/swDLx5euYrFnPdqBKLf5wFlrDmy2/bw6zdeERmgJVELwTCMjGj
	VlAaHYp+OgOk4Dyf3BCXJDzbbFCnvkLW3SXdWPArqC7eZX8MMzBBsR+xKSImbOUe2con+Z
	u+WT3oNXnfHw2DJNhuIfDsWH1sjlgcM=
X-MC-Unique: vB3fFBK_MWWY2s2L366wEQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=arJhKsAikM60e3EI4DbhOQZDjN4qyAWWrR25FJhSVqTh+C6aTc5DkSbvkdT6u6dpCTWcx6GbpqBINFEq/74Xax0eaCQsu97jxVi14JRVsNwsmg1J+nQCVjpKvjvEsuaMN8O7mRJ/EZTDJi8nCQyywG/M7Dic0NErYL0LvrsAM9FzBXDhShz2u1VU8w052BVOPDmjuGILKJ/8kygnYXIB2KwKQF4LWQOj9OrGJIuvCV96o5Acm+iSiSNx9L9aPcm2A3bpEETCmQWn1SKJ5QpBJA9ikuFEJHPkiffJs5+IJtnHz6Oi1Rco6p1AbXbXw5IwoiNF+XSn5Am3pb45jemZ1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/n9Q++3q0pYQZYbGOt+1Me5LfJnrKYNu6hI876RpWg0=;
 b=kR0dlUVRZC0z/WskbhjIA2mR26lctGlBWEV3SYgwVzE3bohvYQ+7j0uRLfRSndCCK+rzr8dQMcHkTFekX0YbV+w6qGxx57Ma/VQsDQRFKVOt/Yy/Jjs4t7YM6mXmAXIVsccJp8vbGtNhijPDFSXCRsgEi4O8icgTJRv6iDhav8aPOmQyzWcNVTn2ZFf810kICfder7B3VoGp0DFoedy4L2x82XLx+9Xb/HLFlY/4r1SzfQJ7c0709mkRlX80cVFyTlGJgBgZbRCM7jkGPDqwEyTM68Y+WDmTXd8m7Mq9nkr39b55ylWCRM/jxojQ74GiY17EyONV5bj6ihEIMHRNIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5d1b2626-84dc-a899-aab9-6b4f167c9d2b@suse.com>
Date: Wed, 27 Apr 2022 16:05:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <b92e294e-7277-d977-bb96-7c28d60000c6@suse.com>
 <cc4323b2-e074-f86f-eea0-9cd6a802bed8@suse.com>
 <f61ce2f9-ef08-6f50-29b4-e7e09e7059a6@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f61ce2f9-ef08-6f50-29b4-e7e09e7059a6@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0015.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6632ddf9-e780-4d33-6bfb-08da2856fe18
X-MS-TrafficTypeDiagnostic: AM9PR04MB8841:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB884186BEBA7BFCAF918C31FCB3FA9@AM9PR04MB8841.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cdlkBcgSFc2Bv7dVev6qowK5QHv8c5Yn0reHy4QFzdhh5AACc70V1DemlWQABf0RQNpV5vCHd8b5Si8SQXpuezpKvxnhIGoqoX/Nd8sq1y7mZZDFXCtZ7vDT+fHiPmlTsLUvzMMs5g4xXdA2Vdl1GH7pFtGH1HExALCUdEQw4IRunqz1VmyHz9NCnnwx8nQpWbLW7TkHCWHaxSGYgtL0OPAQO9sNiLqsH+5NPjcN5zXNFbP+LvfBjfwkrv8pm1LGN/EVG2fE+TEF7K7kAvSznZ2YVsg8f5ebSW1dlK/eKPSVSQ1BkVyjTw+EbuKxjMWBDIuQmeNyp5VQPvR2HMsgRuINl8XMHqZm+sDfwcBvqseMuEHZqbzcn6heGVt4MRigNrhU8nx3ah5/3i0ByEcGb5MkV76AjeVa7CNDpdtrYER441g6iAVLLjrwOzf584lZAmf//xnYp/lLD2BBcJ09lIMevGZhPs3QA4yYZZlL3Ii+P+nyBhmU2imjUfqTyIsp1C8hkrqe5nW4xVZ9d1e82m209F8R+x26Y8BKBveYHQP4uktDwhrvIzjEDMYKq3Rd7w31ewj54wf/3QAifDDq1mzSb8BCPd5fG89rNRDix5iYoN3a1m+vfG1LxgvN1WmqURrbaDrmqe09imkIYcyuaaF70IkVHPEdDCoOGYW65kVcgETxsNHDpyTIx+QkEZUAZg+xQxpoeQN/jRbaE3LrIMkWevlGZlbI0jcD95YYMjRN7nwZMs+bn1KClcqBoUnl
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(5660300002)(66946007)(8676002)(66556008)(4326008)(83380400001)(66476007)(2616005)(2906002)(6512007)(186003)(26005)(38100700002)(36756003)(53546011)(31686004)(8936002)(31696002)(6506007)(6916009)(54906003)(6486002)(316002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cVYxZldZbmVQRFQ0ckJ2T1h0elhoU0hLQlRHODBJd0JJTnc2Zzhkai9KakpK?=
 =?utf-8?B?Ym5vUXBBVFA2SXBVeTE3TFNxTlNvdGtNTG05cVFhR2pNWUxzQ3JpRGRTSW1M?=
 =?utf-8?B?U2NyUUt5SEtvVjAySmgrWUtCRmpJYzFtb1lHTkVCaTd2OGgwUFEvdUgxSFpx?=
 =?utf-8?B?VlNyY3ZhZHN6UndTRFIyMTE3SCtlSDBVaW53RTV4Q20yYyttNUpjK3ZReXhB?=
 =?utf-8?B?allTREtXOStiaVBEZkJVRS9ubGZzLzNzVHRzYmZ6V1BLRXZlUXcrVndtOEI0?=
 =?utf-8?B?NWJDVmhWYjRMRjN6N3BrRlFqLzVxblN0SlVJcGc2M1piNzhzcWFSZDhveXdp?=
 =?utf-8?B?M1RtSmxINWF0L1hraVFoTGRacTlMSzloZ3JFdllLdWhFTzYvUHNSNlZlUUNY?=
 =?utf-8?B?ckJCR01pMlkzanhvRkNtQUFFZFgyVnhHZEp3RytLTjU0cWpIMHgvZURCU01F?=
 =?utf-8?B?YldxZ1pMWW9td0E3dUkvb3BBMmp5ajUvTkdMaUZ3UFpRcldCc2tMUE9yb3FP?=
 =?utf-8?B?UEE4OWsrQUV5VEU5SlkxUHRMZ1BsSlV3NE1qUmt6WE54NTNPcElNc0llSlpF?=
 =?utf-8?B?ZkpldmlkSWVsTnRGNzRvbjBTYUR4ekFNT0QzNVpqU3loNFozNElVZ3pnZFND?=
 =?utf-8?B?Rm9lTVlwNzZzemEyVmEwTWxncUtoUGJTdFd0dmMzaE5VcVZkMXNxajV2TGg1?=
 =?utf-8?B?aG84OWFnZVFEUE9oVmsrcU1NbTNUUFhEUHFxTEw2dXZCME5OOWRuaW45SmNS?=
 =?utf-8?B?cXNEV2FET0RjV3BGbTV4eFBPUThSMW5nUzVxempxSXpkY2UwT05Maks5Z2Nx?=
 =?utf-8?B?QUFCME5KMm1GNm5mSm5VbFU5N3BNaWp2TjdJODF1K3VMb01NQlNaVFd6TWRS?=
 =?utf-8?B?QUhJUGwyakwzSXo5d1ZPZHU0UjVHdkFWQzJScDBaWUduTHhiSVN2OXpoWXhy?=
 =?utf-8?B?cGdvREVPRW9mSWdkNHRTem5GbFpxdjJNMmlFQ3lKZ1pnTWtQaVhabW8vb3lu?=
 =?utf-8?B?VGgwdkJpY0xhTTUyVnpwOW1TSEJaODJFVE1iVjdMYkVzTmY3aWl3VEt6UEVs?=
 =?utf-8?B?SS80Y1BrSnJoMW1FdFBPL216ZW91VERtZlFFM1dUbGFsVWVvMTlTZDBsbkJ6?=
 =?utf-8?B?dys0REhSQy9WaVI3Z0dIeWRHRCszWWYxUll5ODZSZHFuUUJhZmxPcldMeXlV?=
 =?utf-8?B?REJCdTFlbE5WNVEyNk1ZUEJUSEZVaVlCMXBUaWZxQVFuVnU3dS95Mm96VFNT?=
 =?utf-8?B?MytHeUVVd3F3Vlg5UldENWh5cnRNK3cwMS9weHF0YnNmZ3lDdlRvUTdYTFN2?=
 =?utf-8?B?Znd1WmxKNEJudGFVTURxMC8xTEFpMmErRzBDZExjcGx1L3B0bGVQNnpEU1gz?=
 =?utf-8?B?OTZ1emZhNWJmUW5sOVVVbkNLSElZS3QzaUFsSjRzZm5rWHlVc2NFejd5Y0Fk?=
 =?utf-8?B?SEgzMXJmYWxER2x6RU9TdEt6Q2NwQUp1ck9wcEMyUFV2L2xMSDVCZjZ2dnpa?=
 =?utf-8?B?L2dWalJsenc3Z3RpanF2RDRMUEt0K2U4RWo5U2xLK21BcmVxNFJaMnJadDhB?=
 =?utf-8?B?SmdjMVE5WEpReUlYTGdLMVdxVDB0V1ljR3ZpVmNuNzhCb0JqbjFZTlBSSFN0?=
 =?utf-8?B?amR2dFd0ZGJKU0htdERJa09kU1duNVZKUzcyRnU4ektWNnRJRHRIRURsT1FL?=
 =?utf-8?B?Ny80T3lvWWpKUEF0NEwxZnhXNzNoQTBRODRDQUNYOVQwMUkwVTRiU3NVdDQ5?=
 =?utf-8?B?eVVRSUpQQjAxOWlnQVVRY0VoVWV4M2VrcDUvcitTTXl3cXAxTDVmb2V4R0Fn?=
 =?utf-8?B?MEJ1Z1FDT2ZGR1dKRGtSTy9lbndyeExneXhFaFhzTUNPYWUwVERwNGJPcmw1?=
 =?utf-8?B?cXNxMk1XaFExQmhlS0pJc3ZqS0ljTmRtQjVDTFRIOEhQa29TRHYrS012TzU3?=
 =?utf-8?B?WFltRis0Wkh0eDJoZ2RCY1htWFo2cmkva0xRZ1U1cCt5Sy91bklCTXI5aDNR?=
 =?utf-8?B?VEUveUdtSmxuZmYyVmRkL0x2b3lGckNKMFFpZGplUFI3R3R0Zkx2Z2lWWDVz?=
 =?utf-8?B?SkhGdXFWeEZXeE80aDBhOGVmSUI5UCtXNnBiMkgvMmlCSFFiMGMvOFNYNDdC?=
 =?utf-8?B?bisvUmk3UCs1NGtCM21QZlhhWXZUSE1BUi9Dc01uQm93MFdZTFZxYUpseUJw?=
 =?utf-8?B?aytwMS9ibW05dmd3aU5qVTdhWVp1UmMwL2c0dzBmVzZLRW9raG50YStvNUtQ?=
 =?utf-8?B?Q2xXM1I2MnQ5dE5TYitPN3FNdnkxMnllYzlmZmQzOGhtMFd1dUlPZ3hRWkxH?=
 =?utf-8?B?eEVxWHBlNlN1U3VWbWRaSzB0NGE5cytiM016NzlObkdGZkhOc2lJdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6632ddf9-e780-4d33-6bfb-08da2856fe18
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 14:05:32.6501
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: irrFlsDpiYHyUEKWiR1AcUPJz36jew9DOS33yG3qRuQxRO2S1aioYfYoMjS1Et/lzlzhF7HkDOASHCOtZDwqdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8841

On 27.04.2022 15:16, Andrew Cooper wrote:
> On 25/04/2022 09:32, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/iommu.c
>> +++ b/xen/drivers/passthrough/iommu.c
>> @@ -308,11 +308,9 @@ int iommu_map(struct domain *d, dfn_t df
>>                     d->domain_id, dfn_x(dfn_add(dfn, i)),
>>                     mfn_x(mfn_add(mfn, i)), rc);
>>  
>> -        while ( i-- )
>> -            /* if statement to satisfy __must_check */
>> -            if ( iommu_call(hd->platform_ops, unmap_page, d, dfn_add(dfn, i),
>> -                            flush_flags) )
>> -                continue;
>> +        /* while statement to satisfy __must_check */
>> +        while ( iommu_unmap(d, dfn, i, flush_flags) )
>> +            break;
> 
> How can this possibly be correct?
> 
> The map_page() calls are made one 4k page at a time, and this while loop
> is undoing every iteration, one 4k page at a time.
> 
> Without this while loop, any failure after the first page will end up
> not being unmapped.

There's no real "while loop" here, it's effectively

        if ( iommu_unmap(d, dfn, i, flush_flags) )
            /* nothing */;

just that I wanted to avoid the empty body (but I could switch if
that's preferred).

Note that the 3rd argument to iommu_unmap() is i, not 1.

But I have to admit that I also have trouble interpreting your last
sentence - how would it matter if there was no code here at all? Or
did you maybe mean "With ..." instead of "Without ..."?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 14:07:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 14:07:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315129.533515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njiKR-000857-0y; Wed, 27 Apr 2022 14:07:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315129.533515; Wed, 27 Apr 2022 14:07:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njiKQ-000850-UB; Wed, 27 Apr 2022 14:07:38 +0000
Received: by outflank-mailman (input) for mailman id 315129;
 Wed, 27 Apr 2022 14:07:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njiKP-00084o-E9
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 14:07:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63dcdb45-c633-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 16:07:36 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2055.outbound.protection.outlook.com [104.47.2.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-3-qGGpmIM-uAlm0DW8e1bw-1; Wed, 27 Apr 2022 16:07:35 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8088.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 14:07:33 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 14:07:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63dcdb45-c633-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651068456;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fX2xapSIVLDWhfvYjgjQun4HG5R7CMqz5MySb6Y3TuU=;
	b=kAelnM7+rTVdLx2r2Ri8auwksjR308iG/uRzDJwHSrp3Wt9NE7/4wEGAZuG98l5NuBS92F
	vqJFo3QFohR92MYujOSI4w8BQOZ8vI9pu2t8D7qBuaXp92DqMD/ah1hOzVXZ+V7Wqdr3GW
	hDenwC6xe+E3H8He7N2kj+GTdjppJ2o=
X-MC-Unique: 3-qGGpmIM-uAlm0DW8e1bw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dymR0FWMzrUT+DN+tB4lO76A/UurR9ETi1Ey9+LaupAk/EJVRRVbImGl74Ggh2PScdRXZn6EE9Kx5mXXA0qnFC8zmqdmIjj/inINY2AcxjTBAQ9oNbG6R5VkyxkO7SXqSTS5mvsVQuWswTKwFwn3qyEfp3xIgj/jU5IOixNnEnsU/u1Fb6S3TCD3DjMLxs2nEMduHjGPgqt046xjkA9x03jwESY/dyDSgfLmdtax4HsM45E+IUcoB8/DOLf8eNJAJy/f7qFuXaJHQ+ojeXxT8EDmN3MNVJh/CV4r4qkEsQ/OpfW7FjhLUMTR3U1/vV+yPpQsIdLZWhKSERq23vvN0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fX2xapSIVLDWhfvYjgjQun4HG5R7CMqz5MySb6Y3TuU=;
 b=QUjA8SbnCszI9dSifgF4PykwGmEt0zZKoa08OiV4ZlGy/droR6uPXhxQjwBQ1R5HdDlP5uT19hMYPbdt2tfd44CAX8TF72S3knP2XvFE9BmmP5FLU+TMAfiJ8+5W79J3bXVVTx3F0rU2Tp4coMsxd5gggxXlAcZ2XeKxorjZinAQp4LuYXZ7KmrpleAbdhWoNcppm1C3o7Jrq71NYSKhlawYZWbzTLTaUNEbj1/SaN/CxZGn/8pu6lbsXkbsv+BeXq4JVSoyxyVQ6mLD3ki4A+9FAQwByrQy689I0BNWgvDYFJxi2NwZcB9+6dLUxA75A4KjWtG+yqNrS3D2ijVQiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3a3b482d-0ad2-bdf6-ccd9-176317cf8742@suse.com>
Date: Wed, 27 Apr 2022 16:07:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from
 get_page_from_l1e()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220427140400.20152-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427140400.20152-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0011.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::24) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3c9cefa7-1412-470b-423a-08da28574690
X-MS-TrafficTypeDiagnostic: AS8PR04MB8088:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB80884D686739706C869E3F81B3FA9@AS8PR04MB8088.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	syM+9lEdJcCJjJ+MeefEuJT95QAab4ZzY/fg6qJEQO4AO1s0X1LgfBM3QR2qb2LgOgzgs7wnd8bRWfa2LeeYx8/mvzY3DChTqma0Vg0Sj1IsaHogff62qUMZN+biZrZh9ybJ6SPpvSD5jH6hMEtowFjaj15gKM/1/KdaxabhzY8IKpfoaHc3SpxdGKqXrjR+PJOSigPXvMXXdLW4qi+dRp0+yDZusRUHo1naEoZ8ZxSMLvwX63qw7wKdZ4zJIL1eg+IIaIQ54D/87hhygf7Paqw0b4mMdMVNmrZ/hleZPcMbySMfvOmDw9qRIeqHMzdtJmW1IPxMYDPgMcPDW2hJ1u1prdkrvh+KeUVH6y1uByptGtkJe75/65pYqrfROxqnGpcusUcN15jk6evGwhG9bgmvkDLoafpHD0TLYRayMFtr1gjMDpxXjhZUrROBNbEVPds30RE5UHbEEagfKeNlH13EMvKVslUyc1jfeUrwloPBdk5fj6tkS08nQkiuiW3MtTFtQZrAYiZBJExHHFQ8GTmDm6pFGx4Kx61BaTAc0VlJxbhD5FMvU5/Z6jr5q7pZ558+gIlk6012FhywhzsxEdPv35H21dXcTafKTja4O4iTfN4XfksSeKEmLMenxI6QYPyabzgwouWmD8zQkd21IuD4iv4WjUejwmAVc3BBiFViQ8r9ex/eLqwvHXP/85cCM0yBfwNHrainT8gdVqGLGGbJP8rJL0I5LYklQa1m3kA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(316002)(5660300002)(8936002)(186003)(38100700002)(4744005)(53546011)(6506007)(31686004)(66476007)(6486002)(6512007)(2616005)(31696002)(66556008)(6916009)(66946007)(8676002)(4326008)(86362001)(54906003)(26005)(508600001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N21EMzl0NWYvZ1JxWEp0Z2c4T0tKNWJqTWdKdzV1TVkzc2F0cWU0UkFTVDB4?=
 =?utf-8?B?VVRsVU1sK2E1YmdKSjVCcWkwWW9VMUZaTTU2MHdNNVlqNC9vaVJWQVdRamdY?=
 =?utf-8?B?aHIzaGhSUzlKRDE5cXRiTDViTUFSRkJjazJyY2VUMW9qaFhrNVU5RDJrcFFS?=
 =?utf-8?B?ZVVPbi9SaG1NUC9aWUFXaTBNNE9xb0gyYjUwOEwvVWZaQXd5MXBKd0RheG92?=
 =?utf-8?B?SVpHV0JBKzJyR3F6OUdOcE5LUW5aQnBjd0VaNG4yay9LVEFubitLV24zNk5S?=
 =?utf-8?B?RDN2TmhnUTNIUUY1ZUxMZE9Ud1BYNnBiT3VSS0VSUDdWS21makFJN3UxZXBm?=
 =?utf-8?B?M1RzWlh4MTlJWW5jM2tJVDBvT3lmbUV4UzQ1QkNrL1NIMjgrMXcxbCs1aU1H?=
 =?utf-8?B?aEpXdHJEYUdBbFFROVdEVnBsUmp2Um8rejQzM2Q4WlI2RW14NitZck1yaE5k?=
 =?utf-8?B?cnArVGNpZHo4R3JOSFJ5QzhWMnduUDFkQ3BpZUhLOVB2SlB6cTlXaTFWM2lE?=
 =?utf-8?B?NUdKdVhBWXVqYVhCeTVTZjkvQnFmVEd3S3dYNHFFMDNtV1dMai9tUjExRnc1?=
 =?utf-8?B?YzB0Y0lBS2Y3c0g3SUhYQXRvR1FIYnI0akNqdUlHSWhFVmFYdkdkV3g5YXRF?=
 =?utf-8?B?dS91VFF6d3FYWHdkcW9iblhFcjBUdVdBTXErYk4xUUloNktjbmpDeU40NDc1?=
 =?utf-8?B?NUNuRlpscU5XNkFkcjJoa1Q5ZlkvU1NvVzIzZ3dzd21OTXIyR0NTOWRmZkZS?=
 =?utf-8?B?d282T2pZaVoyWWQ4Vjh0UDR5Q1plbFluSTBTRzd1aXplMkQ1MWNBM0xuVWg1?=
 =?utf-8?B?NldneHpOa2FiNjJrWS9uQ3RvSDF2SC9DTHBEUU12Mmk3ZktWMEZXS1NLbTln?=
 =?utf-8?B?bHhLZnRONmlXckU3eGVvcWlXeUI4U00zSERrYk83aGQ1bjhmSXk0WElnYlla?=
 =?utf-8?B?eXBiQjZmUHYzcGlBb1JVNTEzUnBjSTJPdkRDZHpabi85RWxqUlN1V29sUEtq?=
 =?utf-8?B?SnpLVzYxUFZnZnBNcVRsWUd2S3BELzBSRkFRR1ZMYytTYVMxOTMzaFZ5Ylpn?=
 =?utf-8?B?R2pxa2VqU3pWQ2ppUVV2bUUzWENGeFl1UjRtcXRJZmxWRmlxZFdWNGdqcmNU?=
 =?utf-8?B?TG5sUSt1ZFlMS094RGpqSUtaQkJ1WitGd2NtV2FMWXhTVkoyWUNLYVo5QzVz?=
 =?utf-8?B?WXJFelJYdGxpSm5PY2Y2YkRja1MvRENTZzBhRzR1Vlp3cVZhWFFYc1ZQWVR6?=
 =?utf-8?B?bmxnS0dPVE4xRE5WVlFuRXlBSTQwbzY0Yjh0THBNODN2ZURYbmp3MlkrOVVj?=
 =?utf-8?B?QWxDRGNGT3I5OTdqVGdKcWdqMmh3NXEwZy8rckJvZ2Zvbk56bUhMeGFxWGJU?=
 =?utf-8?B?eFNKNEhjdWx5VEFRVytyQ1doWWJ3dUk2dzF3azVrV2lFejZmcG1HR252eGpZ?=
 =?utf-8?B?RnE0VDdDMGFad1dydytYWlMzZXlnN1BxRDBINVE5ZkxYN0MyWGZzbzcwQ2Np?=
 =?utf-8?B?VWZJTWZ4OHVDV1l0Y3U0VU5VWUx4b0ljQTh6SDB6MFV4TnVkaGdlK2lvNlk5?=
 =?utf-8?B?RWFGeXRxd1NZM2lhWDhJRUlOeloxcnBrQjJwcjNRUzJpN0ZjVzFBNnBNcXNw?=
 =?utf-8?B?c1RNMm5KZGp2TU1TRlo2cEllbCsxeExKTjhWMm4wMS9ZZGhwbEVCOHIzOWVi?=
 =?utf-8?B?Y3dWU0JLYldNS0lkUVJ2d3hwSzd1U0hoenY0WW0vaWt2ZU90QXlnNExiRjBF?=
 =?utf-8?B?VW5IaDVSNnpDekFyT0tnQXFBVER3R0tIUk5RQldqRWw4R0xFV0lQWUhseFMz?=
 =?utf-8?B?Wi9xemd2c3NsZXM0dmx0Y2d3NWROOUIyNi9tcHZSVDkvSm1IR2kwZkNaNVps?=
 =?utf-8?B?QlBXVmRXUU5Qc3U1YTVFUFZ1TFhZRm82REhSM1ZDNUIyTmRpdkdkKzlpa09H?=
 =?utf-8?B?SjBOVE5ua04yak05L004N1BTaEltd1JlaDRCUDVrTU5hUzZuYm15SURqeU1l?=
 =?utf-8?B?djJ6T1FRL2dua1NpbitxV2g5akVlcGRldlBpcGVMVWRSUGRJazFNbDlDWUdI?=
 =?utf-8?B?Sks0NTQ5bmplQXo5SFdYSXlxMFVielNmS0xrcHpKN3M3bW9UQzhUYUdacUFx?=
 =?utf-8?B?RldsdTlxUDdqVXRyaFJReWk1WlIybHlvcG50TU02OUsrRWE2cWozZFozcC9T?=
 =?utf-8?B?Z2l1SHdyRW1WeDhlSlpoUVFnL1FHQisveTZ4RjUyamp0YXlpSExoVWdFY1BM?=
 =?utf-8?B?N3RHMm5DK0ZhSFVtbWhucTNnbkFVa2ZVRXZWWEhWVjduRlNHdUZjRDdKUGZt?=
 =?utf-8?B?blhhMkJmY0tvU0psTHZzS04rUHRyeGZ3aWE4dlVCUHBLZ3RLejNOZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c9cefa7-1412-470b-423a-08da28574690
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 14:07:33.9502
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eF0V7gBYmoeHyLBtUcwlS5N4aU0tratf6eLvQQVkKWNGkXFDvdUzOz9CLzhd65Q8FPmIHPJbrxxUY0QfSbJxzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8088

On 27.04.2022 16:04, Andrew Cooper wrote:
> mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for
> speculative defence.  Avoid calling it redundantly, and just store the result
> of the first call.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 14:25:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 14:25:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315136.533525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njibU-00023C-HH; Wed, 27 Apr 2022 14:25:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315136.533525; Wed, 27 Apr 2022 14:25:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njibU-000235-E4; Wed, 27 Apr 2022 14:25:16 +0000
Received: by outflank-mailman (input) for mailman id 315136;
 Wed, 27 Apr 2022 14:25:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XTkK=VF=gmail.com=raphning@srs-se1.protection.inumbo.net>)
 id 1njibT-00022z-3U
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 14:25:15 +0000
Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com
 [2a00:1450:4864:20::336])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d7dbc0a6-c635-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 16:25:10 +0200 (CEST)
Received: by mail-wm1-x336.google.com with SMTP id
 n126-20020a1c2784000000b0038e8af3e788so1301478wmn.1
 for <xen-devel@lists.xenproject.org>; Wed, 27 Apr 2022 07:25:13 -0700 (PDT)
Received: from [10.7.238.41] (54-240-197-226.amazon.com. [54.240.197.226])
 by smtp.gmail.com with ESMTPSA id
 z3-20020a1cf403000000b0037d1f4a2201sm1694942wma.21.2022.04.27.07.25.11
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 27 Apr 2022 07:25:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7dbc0a6-c635-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:to:cc:references
         :from:in-reply-to:content-transfer-encoding;
        bh=jnHRrtGDsL9+LlxuZjl9mC6I9iUXKYvIZLxsWqLj9cA=;
        b=mZ++LJ22sII79BMcErUQy3ijGBJ+i6fVy2n2IgY3PhU725JQHTdxhi1X0XJWd7yC9V
         jWnewu2Dqwg1Osvanr/Gj3uXx8vzbPAI7s+hCJFl3ZC/vvnPX0OwKQaKUQUeiHTspbrE
         R+Wd1BLgfuOXjW7bQPhudRRuH+0BQzJupBUYEAkapvF3B2slz5GYpREk7aXT9kcw0n6z
         7i8TRzqg0VrmU9ZSyRb/PQBpIYgd9RnxlayZqHcxnersZlW6f2rLgptwcHScvVBXwSkr
         PLT5WVW9eh6+eq9dP64XEllxWQdHARiV+ExY54JoWBPhDyVFP0xd1PNLLSVxmSeYbGs3
         wkZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :to:cc:references:from:in-reply-to:content-transfer-encoding;
        bh=jnHRrtGDsL9+LlxuZjl9mC6I9iUXKYvIZLxsWqLj9cA=;
        b=cTMIg+GABMTPuOzRmcaTZVHBaloChNdohne30GwiDCWqc+OM/gGrlTiLmPk9BLBSls
         e9+i4LQDOSNLT5B5QQS4Mo8onDkRyhyZ+Wix6UR98yLvaJPLvdoKY/Rpl8PnoQrxuVwY
         Y9Bm5pJE1QuVrqaw6l/BYqCOpM56jODFw03EycBXKFeE1V3wFhB9qWzJVOztTMp+qYSN
         WLXJxkkfSrFWfKYLBsBCqrB+gRldraXyHfhCb69dYSMhPQx4jYwKhgOS04icGJHepx9L
         qmW/s2ps/EHEwG93Awl5/oRR6vrTSR2nRZY8wVeP1TNl8jEokaJAN/Sc3dk0XfYCrp1d
         UK3g==
X-Gm-Message-State: AOAM533TutUB47NwPQhuYHvpnPashcjDnXkVGfqUUB3oKz6bwok852g7
	SY0bxQ+te57TcfrHya0Bqyp3c+NmA9nDxg==
X-Google-Smtp-Source: ABdhPJzoRVecWsHbvj1dwHBzggipZdmFQutDgrnzyz5JF6i1f/PT/FWXpO79JH1mR+rgJ12CKFNLdw==
X-Received: by 2002:a7b:cb84:0:b0:382:a9b9:2339 with SMTP id m4-20020a7bcb84000000b00382a9b92339mr36297816wmi.91.1651069512775;
        Wed, 27 Apr 2022 07:25:12 -0700 (PDT)
Message-ID: <a95fafbb-1910-7e3b-43f8-d507fcf162e8@gmail.com>
Date: Wed, 27 Apr 2022 15:25:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH] tools/xenstore: don't let special watches be children of
 /
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Julien Grall <julien@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20220427135156.4605-1-jgross@suse.com>
From: Raphael Ning <raphning@gmail.com>
In-Reply-To: <20220427135156.4605-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Juergen,


On 27/04/2022 14:51, Juergen Gross wrote:
> When firing special watches (e.g. "@releaseDomain"), they will be
> regarded to be valid children of the "/" node. So a domain having
> registered a watch for "/" and having the privilege to receive
> the special watches will receive those special watch events for the
> registered "/" watch.
>
> Fix that by calling the related fire_watches() with the "exact"
> parameter set to true, causing a mismatch for the "/" node.
>
> Reported-by: Raphael Ning <raphning@gmail.com>


Can I ask you to use my Amazon email instead:

Reported-by: Raphael Ning <raphning@amazon.com>

Sorry about the inconsistency. I work on Xen as part of my job, but I decided to use Gmail for posting on xen-devel, because I heard that it's a pain to make Amazon mail work properly with external mailing lists.


> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  tools/xenstore/xenstored_domain.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
> index ae065fcbee..80ba1d627b 100644
> --- a/tools/xenstore/xenstored_domain.c
> +++ b/tools/xenstore/xenstored_domain.c
> @@ -231,7 +231,7 @@ static int destroy_domain(void *_domain)
>  			unmap_interface(domain->interface);
>  	}
>  
> -	fire_watches(NULL, domain, "@releaseDomain", NULL, false, NULL);
> +	fire_watches(NULL, domain, "@releaseDomain", NULL, true, NULL);
>  
>  	wrl_domain_destroy(domain);
>  
> @@ -282,7 +282,7 @@ void check_domains(void)
>  	}
>  
>  	if (notify)
> -		fire_watches(NULL, NULL, "@releaseDomain", NULL, false, NULL);
> +		fire_watches(NULL, NULL, "@releaseDomain", NULL, true, NULL);
>  }
>  
>  /* We scan all domains rather than use the information given here. */
> @@ -495,7 +495,7 @@ static struct domain *introduce_domain(const void *ctx,
>  
>  		if (!is_master_domain && !restore)
>  			fire_watches(NULL, ctx, "@introduceDomain", NULL,
> -				     false, NULL);
> +				     true, NULL);
>  	} else {
>  		/* Use XS_INTRODUCE for recreating the xenbus event-channel. */
>  		if (domain->port)


Thanks, the patch looks good.

Reviewed-by: Raphael Ning <raphning@amazon.com>


Raphael



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 14:27:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 14:27:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315143.533537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njidK-0002lg-0J; Wed, 27 Apr 2022 14:27:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315143.533537; Wed, 27 Apr 2022 14:27:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njidJ-0002lZ-TN; Wed, 27 Apr 2022 14:27:09 +0000
Received: by outflank-mailman (input) for mailman id 315143;
 Wed, 27 Apr 2022 14:27:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1GEo=VF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njidI-0002lN-QN
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 14:27:08 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1bed02cf-c636-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 16:27:04 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1C69F210E4;
 Wed, 27 Apr 2022 14:27:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E5E9813A39;
 Wed, 27 Apr 2022 14:27:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id JCC4NrpSaWIqdgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 27 Apr 2022 14:27:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bed02cf-c636-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651069627; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=B/ZToLcmRVQdEqLq+h+9teJxIxexnemIN9E7TCopzUw=;
	b=WjKYEGyB2/r9WXYp1jbKvUojZIGo2fTz5fRvdlBCH5jmdvpMxshIeh5cHNFei8brGOLH6t
	97bzVz+H/zNFaUbMppD4vllL9F8r4/qFS4RGMICtvFoZkezytqKOFlFS9b1ha5BNqmqEI+
	QUnf5FyVg94oaSdWUg2/mEMstILii1Y=
Message-ID: <92715e65-da71-7fdd-96b7-0cc88a22f263@suse.com>
Date: Wed, 27 Apr 2022 16:27:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] tools/xenstore: don't let special watches be children of
 /
Content-Language: en-US
To: Raphael Ning <raphning@gmail.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Julien Grall <julien@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20220427135156.4605-1-jgross@suse.com>
 <a95fafbb-1910-7e3b-43f8-d507fcf162e8@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <a95fafbb-1910-7e3b-43f8-d507fcf162e8@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------LPivvrMEirKl0jSjq2f6Iyjs"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------LPivvrMEirKl0jSjq2f6Iyjs
Content-Type: multipart/mixed; boundary="------------jmexubG0KtPb0hdU7Odbq6jm";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Raphael Ning <raphning@gmail.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Julien Grall <julien@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <92715e65-da71-7fdd-96b7-0cc88a22f263@suse.com>
Subject: Re: [PATCH] tools/xenstore: don't let special watches be children of
 /
References: <20220427135156.4605-1-jgross@suse.com>
 <a95fafbb-1910-7e3b-43f8-d507fcf162e8@gmail.com>
In-Reply-To: <a95fafbb-1910-7e3b-43f8-d507fcf162e8@gmail.com>

--------------jmexubG0KtPb0hdU7Odbq6jm
Content-Type: multipart/mixed; boundary="------------uHpfSBYfhik5peSSj5RQY6yU"

--------------uHpfSBYfhik5peSSj5RQY6yU
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjcuMDQuMjIgMTY6MjUsIFJhcGhhZWwgTmluZyB3cm90ZToNCj4gSGkgSnVlcmdlbiwN
Cj4gDQo+IA0KPiBPbiAyNy8wNC8yMDIyIDE0OjUxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
Pj4gV2hlbiBmaXJpbmcgc3BlY2lhbCB3YXRjaGVzIChlLmcuICJAcmVsZWFzZURvbWFpbiIp
LCB0aGV5IHdpbGwgYmUNCj4+IHJlZ2FyZGVkIHRvIGJlIHZhbGlkIGNoaWxkcmVuIG9mIHRo
ZSAiLyIgbm9kZS4gU28gYSBkb21haW4gaGF2aW5nDQo+PiByZWdpc3RlcmVkIGEgd2F0Y2gg
Zm9yICIvIiBhbmQgaGF2aW5nIHRoZSBwcml2aWxlZ2UgdG8gcmVjZWl2ZQ0KPj4gdGhlIHNw
ZWNpYWwgd2F0Y2hlcyB3aWxsIHJlY2VpdmUgdGhvc2Ugc3BlY2lhbCB3YXRjaCBldmVudHMg
Zm9yIHRoZQ0KPj4gcmVnaXN0ZXJlZCAiLyIgd2F0Y2guDQo+Pg0KPj4gRml4IHRoYXQgYnkg
Y2FsbGluZyB0aGUgcmVsYXRlZCBmaXJlX3dhdGNoZXMoKSB3aXRoIHRoZSAiZXhhY3QiDQo+
PiBwYXJhbWV0ZXIgc2V0IHRvIHRydWUsIGNhdXNpbmcgYSBtaXNtYXRjaCBmb3IgdGhlICIv
IiBub2RlLg0KPj4NCj4+IFJlcG9ydGVkLWJ5OiBSYXBoYWVsIE5pbmcgPHJhcGhuaW5nQGdt
YWlsLmNvbT4NCj4gDQo+IA0KPiBDYW4gSSBhc2sgeW91IHRvIHVzZSBteSBBbWF6b24gZW1h
aWwgaW5zdGVhZDoNCj4gDQo+IFJlcG9ydGVkLWJ5OiBSYXBoYWVsIE5pbmcgPHJhcGhuaW5n
QGFtYXpvbi5jb20+DQoNClllcywgb2YgY291cnNlLg0KDQo+IA0KPiBTb3JyeSBhYm91dCB0
aGUgaW5jb25zaXN0ZW5jeS4gSSB3b3JrIG9uIFhlbiBhcyBwYXJ0IG9mIG15IGpvYiwgYnV0
IEkgZGVjaWRlZCB0byB1c2UgR21haWwgZm9yIHBvc3Rpbmcgb24geGVuLWRldmVsLCBiZWNh
dXNlIEkgaGVhcmQgdGhhdCBpdCdzIGEgcGFpbiB0byBtYWtlIEFtYXpvbiBtYWlsIHdvcmsg
cHJvcGVybHkgd2l0aCBleHRlcm5hbCBtYWlsaW5nIGxpc3RzLg0KPiANCj4gDQo+PiBTaWdu
ZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+
ICAgdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIHwgNiArKystLS0NCj4+ICAg
MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4+DQo+
PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9v
bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jDQo+PiBpbmRleCBhZTA2NWZjYmVlLi44
MGJhMWQ2MjdiIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv
bWFpbi5jDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMNCj4+
IEBAIC0yMzEsNyArMjMxLDcgQEAgc3RhdGljIGludCBkZXN0cm95X2RvbWFpbih2b2lkICpf
ZG9tYWluKQ0KPj4gICAJCQl1bm1hcF9pbnRlcmZhY2UoZG9tYWluLT5pbnRlcmZhY2UpOw0K
Pj4gICAJfQ0KPj4gICANCj4+IC0JZmlyZV93YXRjaGVzKE5VTEwsIGRvbWFpbiwgIkByZWxl
YXNlRG9tYWluIiwgTlVMTCwgZmFsc2UsIE5VTEwpOw0KPj4gKwlmaXJlX3dhdGNoZXMoTlVM
TCwgZG9tYWluLCAiQHJlbGVhc2VEb21haW4iLCBOVUxMLCB0cnVlLCBOVUxMKTsNCj4+ICAg
DQo+PiAgIAl3cmxfZG9tYWluX2Rlc3Ryb3koZG9tYWluKTsNCj4+ICAgDQo+PiBAQCAtMjgy
LDcgKzI4Miw3IEBAIHZvaWQgY2hlY2tfZG9tYWlucyh2b2lkKQ0KPj4gICAJfQ0KPj4gICAN
Cj4+ICAgCWlmIChub3RpZnkpDQo+PiAtCQlmaXJlX3dhdGNoZXMoTlVMTCwgTlVMTCwgIkBy
ZWxlYXNlRG9tYWluIiwgTlVMTCwgZmFsc2UsIE5VTEwpOw0KPj4gKwkJZmlyZV93YXRjaGVz
KE5VTEwsIE5VTEwsICJAcmVsZWFzZURvbWFpbiIsIE5VTEwsIHRydWUsIE5VTEwpOw0KPj4g
ICB9DQo+PiAgIA0KPj4gICAvKiBXZSBzY2FuIGFsbCBkb21haW5zIHJhdGhlciB0aGFuIHVz
ZSB0aGUgaW5mb3JtYXRpb24gZ2l2ZW4gaGVyZS4gKi8NCj4+IEBAIC00OTUsNyArNDk1LDcg
QEAgc3RhdGljIHN0cnVjdCBkb21haW4gKmludHJvZHVjZV9kb21haW4oY29uc3Qgdm9pZCAq
Y3R4LA0KPj4gICANCj4+ICAgCQlpZiAoIWlzX21hc3Rlcl9kb21haW4gJiYgIXJlc3RvcmUp
DQo+PiAgIAkJCWZpcmVfd2F0Y2hlcyhOVUxMLCBjdHgsICJAaW50cm9kdWNlRG9tYWluIiwg
TlVMTCwNCj4+IC0JCQkJICAgICBmYWxzZSwgTlVMTCk7DQo+PiArCQkJCSAgICAgdHJ1ZSwg
TlVMTCk7DQo+PiAgIAl9IGVsc2Ugew0KPj4gICAJCS8qIFVzZSBYU19JTlRST0RVQ0UgZm9y
IHJlY3JlYXRpbmcgdGhlIHhlbmJ1cyBldmVudC1jaGFubmVsLiAqLw0KPj4gICAJCWlmIChk
b21haW4tPnBvcnQpDQo+IA0KPiANCj4gVGhhbmtzLCB0aGUgcGF0Y2ggbG9va3MgZ29vZC4N
Cj4gDQo+IFJldmlld2VkLWJ5OiBSYXBoYWVsIE5pbmcgPHJhcGhuaW5nQGFtYXpvbi5jb20+
DQoNClRoYW5rcywNCg0KDQpKdWVyZ2VuDQoNCg==
--------------uHpfSBYfhik5peSSj5RQY6yU
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------uHpfSBYfhik5peSSj5RQY6yU--

--------------jmexubG0KtPb0hdU7Odbq6jm--

--------------LPivvrMEirKl0jSjq2f6Iyjs
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJpUroFAwAAAAAACgkQsN6d1ii/Ey9Q
dwf/SJuOytCgNUQ8u8e10B4Q7d/wBzv6Cg7x0qfKFbIU4dqqwn8ngaXUaQuq8f5iUTs/FQXa4Q2S
7Bg+e/Nm3E2PJJDebu0c3E0tqlBzy2HMwlhFktgENktl93fFgo94I1KbPEvzaBe0iIUgvrdEXYKA
HMOKl+8eCPVlGVf3ro37Aecx87ukSHzsYBGrw2IySgEHPoiH1VeaRE3gEAWw6ggv8l5LAcFpcuDB
Rlur0A50v8bUG0qTmsDcNy6T5FFbbVEmZLtDFIGVjM2biQ45/n32F95369ACzxPC7qosM8NQCSPi
bzpiogNnSNojzkHOWjQgCkpAxXcWJmm6tXfBZoImzA==
=IU9C
-----END PGP SIGNATURE-----

--------------LPivvrMEirKl0jSjq2f6Iyjs--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 14:31:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 14:31:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315149.533548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njihk-0004I0-Jn; Wed, 27 Apr 2022 14:31:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315149.533548; Wed, 27 Apr 2022 14:31:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njihk-0004Ht-G3; Wed, 27 Apr 2022 14:31:44 +0000
Received: by outflank-mailman (input) for mailman id 315149;
 Wed, 27 Apr 2022 14:31:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njihj-0004Hj-Ns; Wed, 27 Apr 2022 14:31:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njihj-0007ig-KT; Wed, 27 Apr 2022 14:31:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njihj-0001KC-9p; Wed, 27 Apr 2022 14:31:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njihj-0004df-9O; Wed, 27 Apr 2022 14:31:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=c4zSzLwPT7UmLspJ9pL7+6pHR9VR8hzvgeEXbVz98zI=; b=xFkce6+5i3bsx72aUn7nJE/SW2
	OIN6HQYdxrKFusLrr06uZjDRMVZw7BYailQronufELWQot88CDgEOSL24xh2kpAYIO07D+Lmigmx0
	fCcHW0YynVnoPTDuC8wy2mL+CRHmdS6TCicZEa+27nEJVrgJvdIX+/ypmP8g5qBZlnwg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169783-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169783: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 14:31:43 +0000

flight 169783 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169783/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  662 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   34 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:06:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:06:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315157.533559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjFE-0007fz-9j; Wed, 27 Apr 2022 15:06:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315157.533559; Wed, 27 Apr 2022 15:06:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjFE-0007fs-6q; Wed, 27 Apr 2022 15:06:20 +0000
Received: by outflank-mailman (input) for mailman id 315157;
 Wed, 27 Apr 2022 15:06:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njjFC-0007fm-0b
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:06:18 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94075de6-c63b-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 17:06:15 +0200 (CEST)
Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 11:06:11 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by MWHPR03MB2878.namprd03.prod.outlook.com (2603:10b6:300:11c::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 15:06:07 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 15:06:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94075de6-c63b-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651071974;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=dVd7fsA4q9gi4YYePSS3oTcb1iKc6Nw3qj1KYjAIJxM=;
  b=KCZ02wJL3j4Nw9F+9p7lYFYIz8gqJZM/GUit0VIX9v0ZlxUxnGBYBexR
   7kHxasLd7SfN6tr+1Q4gQDWUpy39fyV7tDrQkjmRzAUjGCshTLEt84D6/
   ZdncVkQxtS7pvCPBaV+xPp1PFtHiVjwVbcni1y1SBBwhLIcqiqbep6DFN
   4=;
X-IronPort-RemoteIP: 104.47.70.107
X-IronPort-MID: 70050771
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:8mKp6KjSbrHlePnnE+EwhjnvX161FBEKZh0ujC45NGQN5FlHY01je
 htvCjrQbviJYGb2LY1yYISx8k0F7JGGytRlHFRsqStjEy0b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nS4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YScMbq+ThNxMaj1RNxBVF6JH04D9Hnfq5KR/z2WeG5ft69NHKRhueKc+paNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuocehW9v7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wrN+PJovDG7IApZyuTuFYr1fISzbMhRj1qXq
 D+B/jvDO0RPXDCY4X/fmp62vcfNly7mXIMZFJWj6+VnxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzWnpFaUsxhaXMBfe9DW8ymIw6vQpgyfWW4NS2cZbMR87ZdpAzs3y
 lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obs5jEpMVkcG
 wy3kRU=
IronPort-HdrOrdr: A9a23:8NcYhKln22SkJRgsjPc87vXu6LHpDfO+imdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM
 tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq
 Z1saF81kedkDksH42GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR4Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqWneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87hecAotd/lq
 H5259T5cBzp/8tHNxA7dg6MLuK40z2MGXx2TGpUCLa/J9uAQO/l7fHpJMI2cqNRLskiLMPpb
 WpaiIriYd1QTOlNfGz
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="70050771"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kNrAxurjs4jzFgWet+FieXyE/uMQsKoGjP9/K6Z52K671LNk5w0pmW9aecKER5ywR1q2TFGpc7LqWVP7jt9uxFzhS1YymczfJc/pTVw7o4JQanI5IA5Fn+emJmVKTZjCEbnb9KP3KO+26m4KN1r5ZXtOMnMkbyAMAWQTlvJ1rSLHmjrBiq9LNTsZ7ow4zurxnFJ7AGfyZS2DlHwJ1PKiK5VE692xwNLLQeBjrRQvlkD7PTvGQT/Q77jCxJqjHEkvznqQMbNdH0BBxtxXSqX6suojd343mfCO45F4pZwBvfbiNxezXR2i0BjmJAdeasDQcWxOtYtximzMI+mXWQp0LA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dfNP0m9DqoUThoqo7gSB3LAmxV++NOd1on2h1xZxePM=;
 b=VGZiVyImU4G1mG7f0TcXfTZEcyuD28kx+nKtpsgdePuUi/4XTG4FYz5zZKvtqYzHY0fIZyy/DGc7vVzQj9DFZ2mbxxiUteTnH97FOdfqRTDR/c/+yzEPVlxkh1q2yckPwKos84g+oixSCfg+IyqLKZaPeS7gZ+I8bBaVe9w4y29hY2FYeg4+I1mzNe0FWfH87QfEHRO4pYQRx+5OGwuFGk8+gg2jl4KG3BUpJcG8djaormt0FNuUzfva6RvBjJZaSwxouY9CCbZQTmW+YZQ1bpcQs3dY/jNv+X1CLsQ6rQ+lI5DlDIA9E1B76oRrdKP/27rGf4maSC0sZKQSuv2b8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dfNP0m9DqoUThoqo7gSB3LAmxV++NOd1on2h1xZxePM=;
 b=RjCco+VEkqAZEqFufxsl5h5WQvk8aXcy3Bd6nmV11i0uhg2BPVE6IHsYV9rqQutBCruIKjwHm0JBlFob4xRUtJSUoFipU4snOfBc+vqlYGPd0hLGy+Bj0w6bJxTXOwiozziRt8g0bKA4fmmKLR/gz+g6YoZ2qJoCQViCQydbBmo=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 17:06:01 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Message-ID: <Ymlb2Wly25k9bF0z@Air-de-Roger>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
 <Ymk7BjXdyiMUGoc8@Air-de-Roger>
 <47b50c64-b8bd-df95-9de9-175780c50e0b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <47b50c64-b8bd-df95-9de9-175780c50e0b@suse.com>
X-ClientProxiedBy: LO2P265CA0227.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: da721a6a-ab26-4d0e-67b2-08da285f74b5
X-MS-TrafficTypeDiagnostic: MWHPR03MB2878:EE_
X-Microsoft-Antispam-PRVS:
	<MWHPR03MB2878643EAD470963F5564E658FFA9@MWHPR03MB2878.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8aKLTsZaFpke9qrC5ZJ4cKc/OkIhhnayO0kTr9J069Kah0UUjOdafp/cXZlxQoTK+3jYxeYaWCcE5KOI+/XPU7vcKyTH9l6BBNFzzNux+t4VtAERi7j6yQh6rE+wYaNVHvgfbh+affzxWyoawW6BKAutGKeZLV8sbeKRMuQ5aTlEdcbVNxioqj0pdxoZhOBBDd1zUEs8wtDeDgstgZTDqfEaR3rm5OgtpsoQJNexOBOPmLwdmwVDWPq9YJil3YwcTJjtCE7E3O8Bpw1t6Pynofuww46a4vjyHkF7SeE+fE2n0XK6wpxns7FK4I/pPawb6ggdvMkxcMmlp2iD9Mvtrai60zKU9J4dNdSrTYiacP/r60AVDLwbi8LK3OpEhZukqv9uH7uAw2DAmLlqi8g3URQzpa6nkKOVkq1vHgQruWs+xfUk9yP1sc0fDlAbV46SVyur+dO7ZbdbtZ6S6f9rzvGf3iQ6xOGJyAk7qlkHUTjd85lxWRlRw3LLGsdLFFVNXSNSGtDCgUQYu8tSw9Ea2qgHU1ArfzRi2W5j3SHh1MROj3Uq88Y7v3GrOVHEgK9tF4Lr1lBYNHroTmIyDaTTMRGgoUD8Hh7caVoyqUVAdxUvuxT3FpdWynq+J8D+novW/OXP4bJuCX47mMk7ZXTaK7rsi15Fsu1vNZmOweC2DTaHBOA8TaaFfefBhs1w9ukZM38rjFpCvl7uxPURtpJsgxj1Oq1KKSdyg5k24hxcSwQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(82960400001)(6506007)(6666004)(2906002)(53546011)(9686003)(84970400001)(6512007)(83380400001)(38100700002)(33716001)(186003)(26005)(8676002)(66556008)(66476007)(66946007)(4326008)(85182001)(508600001)(6486002)(8936002)(5660300002)(6916009)(316002)(86362001)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WnJxalBYUFk2VWZXaFlRR3BCbWN6WW5QS1g4L0NDNUtUUHN4OWxjL3orenBD?=
 =?utf-8?B?WUY2dXErRXVoUktuWk1IUEVrK2lUUmV5eVc0UExvdW5HMlEvRWpoRWlPdWRQ?=
 =?utf-8?B?ay9sR0NxOGtmUmNmQXpuZkJmME5KY0tlT2xsOE5xSjViVGY1SUs3UzduUmJr?=
 =?utf-8?B?dHdSdnY4Tk8wSVQzY3J3K2FiRjI3UGl1bGRVM0puQk5QVzY2QS9FbVZRb1g1?=
 =?utf-8?B?WXZOQW9jYmd1QTUwVlFrZlVaemFjSUJ1R1pxWW5hOGM1K3dJM2htS3Q0ZU8z?=
 =?utf-8?B?a2FwMThhd01hV052TDd6b21uSGx3OTJvbXNEbTduYno0YWdIemFYbTlIS0dR?=
 =?utf-8?B?cW9pVHMxeHFHQVNnbG4yODQ3c1Iwc25WOFNTbXh3K0FUUDVJMStkMGo5RXJ2?=
 =?utf-8?B?RWtZZGFpUWJrUzB4THhWN2lkcSt6eHJsM0VkOGpobnFDaFlIZ0VOcldqRkJH?=
 =?utf-8?B?Q2ZZY3NoTzdCTDRWUjBhMXNvMkg1NkJLbmdZVXZhUmZveTBiYzFOOVBmak5S?=
 =?utf-8?B?UGwyeGsvMEVnVTFqS3ovdXVCaW1JbjFML3IyRHErVUJTT3dtbWFjOCtlVjFs?=
 =?utf-8?B?NTRFak1VazNSRlc3dEpWcGl1dEtnM2RVcm9oQ1grcHZLRmpCazRzZEZPY2xu?=
 =?utf-8?B?RnQ5S1UzNmdkQ0tXcklWQmNndVRNQzB4cktiL1FFRWhXRlhhSnI4YjZ2YUg5?=
 =?utf-8?B?UlRudFBRYW9HWFR4dThiM3htaDhYUU5hK1VobUc1YWx5bEcxZlk5Y1lYTkkv?=
 =?utf-8?B?Q1NzenBxMU1JRElKRXhwcjlDYnB4ZzRNVVhUUFQvMkJNYTNnYzg5Yk1peVJY?=
 =?utf-8?B?NEVFeHM5MENJNDU2QVd0OSt3UWxuRnRtMElHOWVGaTVKczRDTGt6L0d3U1V5?=
 =?utf-8?B?VWt2WkRIbFNOaUZva3cyZmpaMFRnNmRoU2dRQzVmMENEZHpVWk9FcEd4c0Yv?=
 =?utf-8?B?NVVpNVB3SmNjNFM1K1dvVUZsQktYZEtpWWNGZHJtRFhCdEpRdnJyVUVIeTN6?=
 =?utf-8?B?V0RrSUJudllvL2xvNUdZQ015TDZON0VaSGVEOXJuTVZScnpielVoQVZ3TytB?=
 =?utf-8?B?RWhIeHV6bjVTSnVybHJ6VU9pRG9oOEEraTQ5eW1vWXVYNThXNmlyVDUyWDQr?=
 =?utf-8?B?a3N2TXRTbjMzK3JKejViclpBWUNOVXVEOXdkcXlNN1RmTzFUemNpWDBCYVU2?=
 =?utf-8?B?Vkh5bTNrOTdoaVVjalU0Y0IrazNVbi9VejRQQ2tzSkp0UnZwK1l6cy9idTdp?=
 =?utf-8?B?YVdRcEdZWGtOa01nV0J6MVQ0WGMybitTOGVTV1IrbmtveXZUd2dPeXBOTy9O?=
 =?utf-8?B?R0tOTmZrSEZQdm5lRUh5QXBWeTg0UFRiUGRVU2lVNStvUVF6Ymg4KzVpYitP?=
 =?utf-8?B?OUJZdHlhZ0RRaDdoNE9oNHR1aEZIcEJ5TzVXeUtpWmtMR0FwRE1xVXM2MGt2?=
 =?utf-8?B?M1dZcktpYnk4SFY0N3o1WDNXR2lGNldWdEw2Q0Y2L3pidEt5ekE1bVFzYm5K?=
 =?utf-8?B?RS94YTNINlErZERrREFpTmlLek9OL0VKd2JTQllZMllncmNZV24wclNvY3oz?=
 =?utf-8?B?b3RCTmhJY0ZRS3JPa3c4Zi9DaU81OWlTQy83cVFTcFBpS2VzY3liZ2ZkaUJZ?=
 =?utf-8?B?Mlg2Q2crQzl1RWRkVGc1T2REQk9jS2VXbGp2U0tJNHAwQkQxdWl0V3ZzSmlC?=
 =?utf-8?B?R281cmc2OEtxdk9ka1JMZ1NCUmtuOHZwT2NvUGxKOU11L3o4dk95NHRFejZz?=
 =?utf-8?B?VzFwakhTdDVpT0FaNGloWDZlVHpYVWJDclhNeEIzMURhK3NNMmgwNC92RHhh?=
 =?utf-8?B?NDZyblhNMGQwbDlxcmVPVWtDZ0plS3NMak0zUlplb0NYZ2ZhL2ZYVjRHUndZ?=
 =?utf-8?B?bXZyTVc4YTA3KzFXRmU4ZVBWUnN5YVpkU0xyVHRtaDZKeFlSZGZaUlFtN2U0?=
 =?utf-8?B?bWdIUDJwMnR2NzB5eE9XQU5zaUtabDg5UTVCSFUxSUwxNmdrM0hnL1R2cHlP?=
 =?utf-8?B?M1k3MXo5bFFpeDVjc0xRc05KWnMvSGJvSDFkdWxmUjJDRFZJWFYycG9UaFY2?=
 =?utf-8?B?djllaytYK0JnNm5kbU1CR2UxZlFtMGxkSHlTeTNDTDVsakZpTFdyM01oam9x?=
 =?utf-8?B?M1lzVHlHcXJWd0YvVXAyZWtQSGNuQTFONzA4V1YrL3g2K25PTVVZNS9xZEVz?=
 =?utf-8?B?b2pFWVBVYXdrMDlIb3p5V25KUjMxbURnT0psVjBnQ1RRVWV0VzJ0bnMwc2tX?=
 =?utf-8?B?Z2NaaWNsMVJiaVVVNEx4ZVNMdWFCay9UZHFScFh6VVVoWDFpNjVhQ2JZWmcw?=
 =?utf-8?B?VzJiR2dKS3hvd0VzQ29nSXhsMG95RVlNMmh3QVNxMzhQMURJd0VJZz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da721a6a-ab26-4d0e-67b2-08da285f74b5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 15:06:07.3284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K2QiyZ+YOa7zwzvtackVt5zWiB24FrlYRRJkq77E+cLjYEiNBxLpVcZDkLyg+XxmU9MyjGUGZE15MAmXqNxCKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2878

On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote:
> On 27.04.2022 14:45, Roger Pau Monné wrote:
> > On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote:
> >> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> >>
> >> On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually
> >> exclusive - only one of them can be enabled. By default, 'intel_idle' driver
> >> enables C1 and disables C1E. However, some users prefer to use C1E instead of
> >> C1, because it saves more energy.
> >>
> >> This patch adds a new module parameter ('preferred_cstates') for enabling C1E
> >> and disabling C1. Here is the idea behind it.
> >>
> >> 1. This option has effect only for "mutually exclusive" C-states like C1 and
> >>    C1E on SPR.
> >> 2. It does not have any effect on independent C-states, which do not require
> >>    other C-states to be disabled (most states on most platforms as of today).
> >> 3. For mutually exclusive C-states, the 'intel_idle' driver always has a
> >>    reasonable default, such as enabling C1 on SPR by default. On other
> >>    platforms, the default may be different.
> >> 4. Users can override the default using the 'preferred_cstates' parameter.
> >> 5. The parameter accepts the preferred C-states bit-mask, similarly to the
> >>    existing 'states_off' parameter.
> >> 6. This parameter is not limited to C1/C1E, and leaves room for supporting
> >>    other mutually exclusive C-states, if they come in the future.
> >>
> >> Today 'intel_idle' can only be compiled-in, which means that on SPR, in order
> >> to disable C1 and enable C1E, users should boot with the following kernel
> >> argument: intel_idle.preferred_cstates=4
> >>
> >> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git da0e58c038e6
> >>
> >> Enable C1E (if requested) not only on the BSP's socket / package.
> > 
> > Maybe we should also add a note here that the command line option for
> > Xen is preferred-cstates instead of intel_idle.preferred_cstates?
> > 
> > I think this is a bad interface however, we should have a more generic
> > option (ie: cstate-mode = 'performance | powersave') so that users
> > don't have to fiddle with model specific C state masks.
> 
> Performance vs powersave doesn't cover it imo, especially if down
> the road more states would appear which can be controlled this way.
> I don't think there's a way around providing _some_ way to control
> things one a per-state level. When porting this over, I too didn't
> like this interface very much, but I had no good replacement idea.

I think it's fine to have this more fine grained control of C states,
but it doesn't seem practical from a user (or distro) PoV.  But then I
also wonder how much of a difference this will make regarding power
consumption.

> >> --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c
> >> +++ unstable/xen/arch/x86/cpu/mwait-idle.c
> >> @@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
> >>  
> >>  static unsigned int mwait_substates;
> >>  
> >> +/*
> >> + * Some platforms come with mutually exclusive C-states, so that if one is
> >> + * enabled, the other C-states must not be used. Example: C1 and C1E on
> >> + * Sapphire Rapids platform. This parameter allows for selecting the
> >> + * preferred C-states among the groups of mutually exclusive C-states - the
> >> + * selected C-states will be registered, the other C-states from the mutually
> >> + * exclusive group won't be registered. If the platform has no mutually
> >> + * exclusive C-states, this parameter has no effect.
> >> + */
> >> +static unsigned int __ro_after_init preferred_states_mask;
> >> +integer_param("preferred-cstates", preferred_states_mask);
> >> +
> >>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
> >>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1. */
> >>  static unsigned int lapic_timer_reliable_states = (1 << 1);
> >> @@ -96,6 +108,7 @@ struct idle_cpu {
> >>  	unsigned long auto_demotion_disable_flags;
> >>  	bool byt_auto_demotion_disable_flag;
> >>  	bool disable_promotion_to_c1e;
> >> +	bool enable_promotion_to_c1e;
> > 
> > I'm confused by those fields, shouldn't we just have:
> > promotion_to_c1e = true | false?
> > 
> > As one field is the negation of the other:
> > enable_promotion_to_c1e = !disable_promotion_to_c1e
> > 
> > I know this is code from Linux, but would like to understand why two
> > fields are needed.
> 
> This really is a tristate; Linux is now changing their global variable
> to an enum, but we don't have an equivalent of that global variable.

So it would be: leave default, disable C1E promotion, enable C1E
promotion.

And Linux is leaving the {disable,enable}_promotion_to_c1e in
idle_cpu?

I guess there's not much we can do unless we want to diverge from
upstream.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:25:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:25:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315165.533570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjXz-0001d4-18; Wed, 27 Apr 2022 15:25:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315165.533570; Wed, 27 Apr 2022 15:25:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjXy-0001cx-UF; Wed, 27 Apr 2022 15:25:42 +0000
Received: by outflank-mailman (input) for mailman id 315165;
 Wed, 27 Apr 2022 15:25:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=PTsb=VF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njjXw-0001cr-Mr
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:25:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4aded9c8-c63e-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 17:25:39 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-qE0vR_wXP86vEupDu2Ayqg-1; Wed, 27 Apr 2022 17:25:37 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM7PR04MB6824.eurprd04.prod.outlook.com (2603:10a6:20b:10e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 15:25:36 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022
 15:25:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4aded9c8-c63e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651073138;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3L280cBLNfJqqp7w8xBdOA9a9TSEq0MWl1XZQLpotsE=;
	b=JB9wp6V1FBpTDznQ/WtSuFykiRaDMRcTzS50DzyPmmxCRTHU9uWVMYZOlhBp1RkDN7AkGs
	YoodzQ0sLB8r51WiPQVEgvbrYuiGKxSQRpsk4kohmucKSq7vsCcmLMCfh4Fst6uI7Nnut0
	Q4QCO/w/nxRc42OmZcuiDK9Tf+xbqIo=
X-MC-Unique: qE0vR_wXP86vEupDu2Ayqg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WazJxgv3RiFhRNMkTNVFnU+Z8rwE/r06XYyt+GCF4brwzmnz2q56hCdMUJeGVGohZc4ZZUUStJpLEs1uBykSB25/QU6rYgUM7oxNMmRmCcd2MXZKSpoUyVWGLWl5Eh5GiEJIKTAOIsgq8jdVW7oTpX8yq4P3mgVFwT/p7oqbHRMdy7Jloon4z6ttx8s4CaN00SpesTYNhisQLdSWzyAJJbeW7jiJTMoHuih8w8ZouMLiXziXUVPYoxQVHiD537a+gJfWcSGDv2sG1N+qKkA1Y1vKOSQTmP242kAPZdQFstUyN6vP4GF4u/0NVuHiZfJU73vWrm6qwF2vyCx3aUbM4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mcw5RbpZhysFabc4fPyBliDEyDRG8Lfq8DNGKuZXeNU=;
 b=W6nqK0E60e0RNXm8Fkk5cja9cq1+N1W3GEXVHFesfMXoUsP6+1cg8AESz6z0qKAeUZMr0rQxBnm67mZ7I5JzUoFx8Rlmhk4Y098YY1jtA7TBPl5PwRa+stdR1TwVACwpe4o4DgSGs98eZfuSM0WFOUCJKER2kkfQXDtzbVMoklyzaMSqmNdDnTbNduYQvuIV8yHzO0HFAk6qCUydgYdFBJQ1BqsBuETyqpqobOvPA7UE7+6IWCTPsqSIhQLc/g5BW8KxBdTwWEH0+6oDa/2eB1blApa13ZmsUVbclOjvtDtWaOIa+nTxLnctYcxx1Y+Fp9kTNbx9JukUi55phuC9iw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d9e797eb-5075-2c95-cfa9-959586577f98@suse.com>
Date: Wed, 27 Apr 2022 17:25:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
 <Ymk7BjXdyiMUGoc8@Air-de-Roger>
 <47b50c64-b8bd-df95-9de9-175780c50e0b@suse.com>
 <Ymlb2Wly25k9bF0z@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ymlb2Wly25k9bF0z@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0025.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::38) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f6f53e04-3894-43a5-9b28-08da28622d82
X-MS-TrafficTypeDiagnostic: AM7PR04MB6824:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB68242F6AA4B2760459467F6EB3FA9@AM7PR04MB6824.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MD3khuvU9A5oU/5Ln43Ha9SGPXZEPMrMJ6NQBCfA/txA3TPHuswLVqhGm6nPRhHbVHUyHUYdAXHSfW9s17DiS0rb2dYfLBotAkiF7XPnqbjzpD2doovT6s+LboPld5XJz7gE5F3QXFk98Xxc88MHi450W0VG+JwO1mMqBeBfzwjnMJZ0jusdEcL3JekTKl0xFnsKi/SR9JdguhrgZ3tbw6BXwIFZpEoE/BjAXsao7OzaCY2ze2J4dcNTcKAf8Utfx33tD2hhpRW95Rh2u8E3nmeONjTm6fCt/V2y/eS1BkLxHDVnoICH6L7N0e90ivGf3FPe6laqBSWteJbvL5aug8bxf2dzuZsZfHyp3Rjv3Fr0flm0npNZI5PhU1E0wCnRS3dcPtRlNInlsx5+daFo2C6KlSTu7lvAJJTA76EXt4Eev+1tBMr2qsGyvVgnPLVcgsGTJMmbS0jKCXg1k30d1rJW+VVzYGLbHcHQwouhotEYSRFaZlpbVl7AWxqgK8JqUhqq3ciOC9cGjvG4UQSSWLenwsnORUoOaKmciv1e+H9CyaVCl8LekQmV7zazwo7K3MBcQUNWpi2Mdez9Anblw11S9L85ZNmrAuO0e5fB3XTDeb3EhzubFtSUgB8a3iIXUVa889wDvhoPcYZL8r983Vo4WpXtwIijBZ6Hlri6wLmWVC/2Wa5TVmRcncxDfJObZXP+V4wCCYiFEOiIuJmNs8LCxbsXDgBt4W6gNAjlY3ieluD0waQ1BZHff9q2zmxgrWd1I3dgnWi/jRLHnaHeX61i2+lFruMffpVT2EE6XPb7taCxkg6zgZvj/6JkM7MI
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(186003)(26005)(84970400001)(2616005)(66556008)(8676002)(8936002)(5660300002)(53546011)(508600001)(6486002)(31696002)(54906003)(6916009)(6512007)(316002)(6506007)(31686004)(38100700002)(86362001)(2906002)(66476007)(4326008)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tw9j/tUjgrb+9WrdCVj1vm8o6JRPXpZ+l7xeCn+HhldUvYaay2D3NAGEi+C9?=
 =?us-ascii?Q?Dp84NA9t48NZUcaAzuGfQYG/7Wdq0ETiXDMGYWJC0qaA6AhlWmCE16Cn0GZ2?=
 =?us-ascii?Q?BzLToHA+NGIP3KDtTnOYvE0UNrQko9APAaAqLeGEw/rVvXzeqBZsf/WI2PZy?=
 =?us-ascii?Q?MFkelv1lD7Q6o/7tM2qCaEMH98gff2K4oXjNql9NkjVKksA2FzZjNlP4DPNi?=
 =?us-ascii?Q?mrQlshP5iq1ACZNH5Up7outIOLfgDupnlqmebDPx4nmaZI37tlLpRSmrPeSD?=
 =?us-ascii?Q?OwtrLB9f5rX+x1vpCNqcoqeQffyeCBl4VPibtnWrXaa5actqUHmsTWcwvnPY?=
 =?us-ascii?Q?0p2JQkazB05Z4AbbUDRYQ7gIwBQnLz7bXVh8F227pI/VK0RnWFeDO4bte8mq?=
 =?us-ascii?Q?VbHhahiC9L/Y4wC6FAewUfhRU7bj0sLtYuHxsO14nvq8FYd4vpDYQ3IBn9+1?=
 =?us-ascii?Q?QLo5GjJsZG590jNgqxYi2X388NXdYDPZsOC1nQ97PNEOIS+VchXRqbQs/RSf?=
 =?us-ascii?Q?ImYzmIADFLlna4W1Eyv8ED9CS8hNcsJ3+01bemXIFQd3v7BgWXsDZshhAkxx?=
 =?us-ascii?Q?jMa1X3oN7G6pHsFJpWXlZLcv9dOBdP+FzJ9HR6zK8zBdgNJD8QMYZCQR+Urj?=
 =?us-ascii?Q?9mK10LP6HsYrfcBBaMI+c9Uu3p48RFiI7kEsYO2xRNcKGx7M9Ls16npbyts+?=
 =?us-ascii?Q?q95Oe4FVUv1hGGLGrTHGs3EST17R1E9NE1RF2QU0QM0wrCJRQ1xB9RjgeQDh?=
 =?us-ascii?Q?Q4fsAUVoa9NbJzvuqyeJCqLeYthzodyQG6dYuBI7E/GZos0KMfoL0tNHzc/e?=
 =?us-ascii?Q?MPGUK2uMjFHojS1Y0ZstZZkVpUdO5GpRadEHvqXj4EfcdR5HOhyQ8uHbuwAz?=
 =?us-ascii?Q?Cek3izo/pbFbNOFSelhz/xYbHgWsCI0QNIVGMnWGr3TYmRkNGGApp926pf2l?=
 =?us-ascii?Q?j54yNZViNpcg1C8GZylzNs+EGP4bFR0iPNJmbEgm19PUtgbM+U7bun69O5QG?=
 =?us-ascii?Q?nYGT0OD/sFVKMQu5UMkk9LoD3Kpylj7aRgYf2F6ZTG9RSToGSjXs2EC11a93?=
 =?us-ascii?Q?jGb+DXHGVY+3QSvx5dm7IwhbiEVLvdkIXoKB2QV7d6oYKzSc0szf4A4uwCuu?=
 =?us-ascii?Q?0JwNvJQapEYlOGOCoLG73S0CU95bGjh+hnS3j63HF6tuBl7w8sH9VvG+l1Fv?=
 =?us-ascii?Q?p2vq1sMQrgdsuzEPdUHYyRXtcz15PGiN+XVYInb+wWbNTVRjce9mUCAwVdOh?=
 =?us-ascii?Q?imbOg8mWYki/BiveMrOXapwbxgP4fsOsk2lrI9Ejaj1sBDQixio8JjXTgILw?=
 =?us-ascii?Q?N2h52SP0BX9zhUB2l5c5JjwO6qfj3wHH2J7LFEichwE08UxNyJXdQbEjMGZR?=
 =?us-ascii?Q?d8f8ewI3sr+Y4RFR0Viy7sHMK/imnUKJnfaoNwXexx3A9RQmavrAknicsNtf?=
 =?us-ascii?Q?DQApmZQi3dXs33dnCaVM5O20nKEEl9fl41TZwLOUgkFzsHA+FFgKTGd97q8X?=
 =?us-ascii?Q?UiNgyZNWYw2PNzZPuP98pQVQEoizYL7EbUQobLz0Sb+VOdqt+hexTSlM4k4l?=
 =?us-ascii?Q?qt31lvT2xYuhU6FHrxtgAxmWWH7LgmDHYnhJcKF4aMQDPFEWGbLr95MW+BWJ?=
 =?us-ascii?Q?M8/FCXX1uGTJpWnbJ2FEvtPhI07LC9u+BJSR181l4VzL4YJdXPG7uAPS76dy?=
 =?us-ascii?Q?jJtc7gJq/ey20HHlQ4/5JKwT/GYGECe/MqjSQzYM/giUPWoqhcuBedWx7Nos?=
 =?us-ascii?Q?j83wzQbtjA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6f53e04-3894-43a5-9b28-08da28622d82
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 15:25:36.6785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RilFk7SEQ74tnGhgFWvNA+odDZkGhV1ZgGuNKcwkPPtTFfiluZ5RAuA3Hc8i/tp7sEFIf8SwSznS6qQwwxBtlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6824

On 27.04.2022 17:06, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote:
>> On 27.04.2022 14:45, Roger Pau Monn=C3=A9 wrote:
>>> On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote:
>>>> --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c
>>>> +++ unstable/xen/arch/x86/cpu/mwait-idle.c
>>>> @@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
>>>> =20
>>>>  static unsigned int mwait_substates;
>>>> =20
>>>> +/*
>>>> + * Some platforms come with mutually exclusive C-states, so that if o=
ne is
>>>> + * enabled, the other C-states must not be used. Example: C1 and C1E =
on
>>>> + * Sapphire Rapids platform. This parameter allows for selecting the
>>>> + * preferred C-states among the groups of mutually exclusive C-states=
 - the
>>>> + * selected C-states will be registered, the other C-states from the =
mutually
>>>> + * exclusive group won't be registered. If the platform has no mutual=
ly
>>>> + * exclusive C-states, this parameter has no effect.
>>>> + */
>>>> +static unsigned int __ro_after_init preferred_states_mask;
>>>> +integer_param("preferred-cstates", preferred_states_mask);
>>>> +
>>>>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
>>>>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1.=
 */
>>>>  static unsigned int lapic_timer_reliable_states =3D (1 << 1);
>>>> @@ -96,6 +108,7 @@ struct idle_cpu {
>>>>  	unsigned long auto_demotion_disable_flags;
>>>>  	bool byt_auto_demotion_disable_flag;
>>>>  	bool disable_promotion_to_c1e;
>>>> +	bool enable_promotion_to_c1e;
>>>
>>> I'm confused by those fields, shouldn't we just have:
>>> promotion_to_c1e =3D true |=C2=A0false?
>>>
>>> As one field is the negation of the other:
>>> enable_promotion_to_c1e =3D !disable_promotion_to_c1e
>>>
>>> I know this is code from Linux, but would like to understand why two
>>> fields are needed.
>>
>> This really is a tristate; Linux is now changing their global variable
>> to an enum, but we don't have an equivalent of that global variable.
>=20
> So it would be: leave default, disable C1E promotion, enable C1E
> promotion.
>=20
> And Linux is leaving the {disable,enable}_promotion_to_c1e in
> idle_cpu?

Iirc they only have disable_promotion_to_c1e there (as a struct field)
and keep it, but they convert the similarly named file-scope variable
to a tristate.

> I guess there's not much we can do unless we want to diverge from
> upstream.

We've diverged some from Linux here already - as said, for example we
don't have their file-scope variable. I could convert our struct field
to an enum, but that would be larger code churn for (I think) little
gain.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:32:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:32:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315171.533581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjeO-00034B-PU; Wed, 27 Apr 2022 15:32:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315171.533581; Wed, 27 Apr 2022 15:32:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjeO-000344-Lv; Wed, 27 Apr 2022 15:32:20 +0000
Received: by outflank-mailman (input) for mailman id 315171;
 Wed, 27 Apr 2022 15:32:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njjeO-00033y-7f
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:32:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njjeN-0000LV-Sd; Wed, 27 Apr 2022 15:32:19 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njjeN-0005sk-M0; Wed, 27 Apr 2022 15:32:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=037fCIaP1ub+eMYyOgxD8HkSmOOPv0L7+e7AyyzdqXQ=; b=ze9phzY/3fhJiDyqUBOQQKumP1
	PIQZ8j8BySNFWCtfDUJJUnUpmQmEGm69hbYCfKxfHSdXkIdXSrfl04azPgYEjt+vCkOmrPjwjnIuT
	nZGcHA1p1J5134+tPtbptQwwb/wKe04n9GKtDDRgPagHGzMLGMbJCXRDpPB/VzG30e/o=;
Message-ID: <572aee32-a533-6124-4a0b-546085da3cff@xen.org>
Date: Wed, 27 Apr 2022 16:32:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH v12] xen/arm64: io: Handle data abort due to cache
 maintenance instructions
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org, stefanos@xilinx.com,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 Ayan Kumar Halder <ayankuma@xilinx.com>
References: <20220324133705.37882-1-ayankuma@xilinx.com>
 <2a287b59-9ff2-6bd0-fa42-d95333fc1554@xen.org>
 <alpine.DEB.2.22.394.2204181402070.915916@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204181402070.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 18/04/2022 22:02, Stefano Stabellini wrote:
> On Fri, 1 Apr 2022, Julien Grall wrote:
>> On 24/03/2022 13:37, Ayan Kumar Halder wrote:
>>>        /*
>>>         * At this point, we know that the instruction is either valid or has
>>> been
>>>         * decoded successfully. Thus, Xen should be allowed to execute the
>>> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
>>> index 54167aebcb..87a6240f2a 100644
>>> --- a/xen/arch/arm/ioreq.c
>>> +++ b/xen/arch/arm/ioreq.c
>>> @@ -47,7 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>>>                                 struct vcpu *v, mmio_info_t *info)
>>>    {
>>>        struct vcpu_io *vio = &v->io;
>>> -    struct instr_details instr = info->dabt_instr;
>>> +    const struct instr_details instr = info->dabt_instr;
>>>        struct hsr_dabt dabt = info->dabt;
>>>        ioreq_t p = {
>>>            .type = IOREQ_TYPE_COPY,
>>> @@ -62,7 +62,6 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>>>             * memory access. So for now, we can safely always set to 0.
>>>             */
>>>            .df = 0,
>>> -        .data = get_user_reg(regs, info->dabt.reg),
>>>            .state = STATE_IOREQ_READY,
>>>        };
>>>        struct ioreq_server *s = NULL;
>>> @@ -74,12 +73,23 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>>>            return IO_ABORT;
>>>        }
>>>    +    if ( instr.state == INSTR_CACHE )
>>> +        p.size = dcache_line_bytes;
>> I think it would be best to only set the p.size when instr.state !=
>> INSTR_CACHE in the else here.
>>
>> I can do that on commit. I will also give a chance to Stefano to reply.
> 
> The patch looks OK to me, please go ahead and make the change on
> commit.

I have commited with my reviewed-by tag after folding the following diff:

For the record, I folded this diff:

diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
index 87a6240f2aa9..bdd536e873e5 100644
--- a/xen/arch/arm/ioreq.c
+++ b/xen/arch/arm/ioreq.c
@@ -52,7 +52,6 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
      ioreq_t p = {
          .type = IOREQ_TYPE_COPY,
          .addr = info->gpa,
-        .size = 1 << info->dabt.size,
          .count = 1,
          .dir = !info->dabt.write,
          /*
@@ -75,6 +74,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,

      if ( instr.state == INSTR_CACHE )
          p.size = dcache_line_bytes;
+    else
+        p.size = 1U << info->dabt.size;

      s = ioreq_server_select(v->domain, &p);
      if ( !s )

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:38:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:38:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315178.533596 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjjo-0003kZ-Dv; Wed, 27 Apr 2022 15:37:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315178.533596; Wed, 27 Apr 2022 15:37:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjjo-0003kS-Am; Wed, 27 Apr 2022 15:37:56 +0000
Received: by outflank-mailman (input) for mailman id 315178;
 Wed, 27 Apr 2022 15:37:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uVAb=VF=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1njjjm-0003kM-Kw
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:37:54 +0000
Received: from MTA-07-4.privateemail.com (mta-07-4.privateemail.com
 [68.65.122.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ff5796f8-c63f-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 17:37:52 +0200 (CEST)
Received: from mta-07.privateemail.com (localhost [127.0.0.1])
 by mta-07.privateemail.com (Postfix) with ESMTP id D572B18000AF
 for <xen-devel@lists.xenproject.org>; Wed, 27 Apr 2022 11:37:50 -0400 (EDT)
Received: from mail-oi1-f180.google.com (unknown [10.20.151.189])
 by mta-07.privateemail.com (Postfix) with ESMTPA id B07D218000A3
 for <xen-devel@lists.xenproject.org>; Wed, 27 Apr 2022 11:37:50 -0400 (EDT)
Received: by mail-oi1-f180.google.com with SMTP id 12so2330852oix.12
 for <xen-devel@lists.xenproject.org>; Wed, 27 Apr 2022 08:37:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff5796f8-c63f-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1651073870;
	bh=nFw4jYsyAisqJLzlqA1IidWP4jHuOs/pyKgg5MZ7yhs=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=JnHv/C/f/4koIQPLZ5uItrE1bg69zGg+9Nn89sB+LAL5056Wr07JcbV0Ao2eMMx9n
	 jueqlS2XA6MWZ7wqMIkdHjWMWIVRm4dIKm5bstbnmAm/HHGJmurOzJ5ofJaGjitiw9
	 MP4bTpRkJrsifgPtU6ToEzQucaEVsYWH/5niQDC5lXyCVKo0uqh6DMOm4IU20dsrVw
	 vlrp5QaxBl10TKW2Wzo3/q4SN7nL4snKOW2H4qzbIOxs61J+qV42SYl37vjC8iqEow
	 NUh5AnYfPtkbDv1aAQoyRIIAbzKQpIQv4XCMaXFEMP3a18OfSfCUVs5HoNbBYEqJut
	 rjxxXeaNY+bTA==
X-Gm-Message-State: AOAM530WA5cXSgq4U885yOf+X4OK6AA9M04/bQdJjRWeAI1B/pAWl/FY
	HmwaEOIEkwmluaGkSLmv5lB9yYDiTvjPOZgjdzI=
X-Google-Smtp-Source: ABdhPJxUHao9BLknQexAiIWtBtQzBWGn6svvl2JdDCVCUzT5qup2yemsRDiE83WQAC2Um00KBi7ZNf2vzygQvNkethw=
X-Received: by 2002:a05:6808:130e:b0:325:813d:a3f4 with SMTP id
 y14-20020a056808130e00b00325813da3f4mr1349743oiv.9.1651073870123; Wed, 27 Apr
 2022 08:37:50 -0700 (PDT)
MIME-Version: 1.0
References: <e57797cbc2c0706c03363cc7fa1b3e234921fee5.1648214955.git.tamas.lengyel@intel.com>
 <BN9PR11MB527638D2BE6087C1A4D796D48CFA9@BN9PR11MB5276.namprd11.prod.outlook.com>
 <d6c2b3b5-6eb4-e094-fc9f-5214f8c12df0@suse.com>
In-Reply-To: <d6c2b3b5-6eb4-e094-fc9f-5214f8c12df0@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Wed, 27 Apr 2022 11:37:14 -0400
X-Gmail-Original-Message-ID: <CABfawhnkf8_yFak9SdQJsLT6aXT64oS_yFkF9pAkbiU7TsQ5zQ@mail.gmail.com>
Message-ID: <CABfawhnkf8_yFak9SdQJsLT6aXT64oS_yFkF9pAkbiU7TsQ5zQ@mail.gmail.com>
Subject: Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state
To: Jan Beulich <jbeulich@suse.com>
Cc: "Lengyel, Tamas" <tamas.lengyel@intel.com>, "Nakajima, Jun" <jun.nakajima@intel.com>, 
	"Cooper, Andrew" <andrew.cooper3@citrix.com>, =?UTF-8?Q?Pau_Monn=C3=A9=2C_Roger?= <roger.pau@citrix.com>, 
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Tian, Kevin" <kevin.tian@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Wed, Apr 27, 2022 at 3:07 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 27.04.2022 05:46, Tian, Kevin wrote:
> >> From: Lengyel, Tamas <tamas.lengyel@intel.com>
> >> Sent: Friday, March 25, 2022 9:33 PM
> >>
> >> During VM forking and resetting a failed vmentry has been observed due
> >> to the guest non-register state going out-of-sync with the guest register
> >> state. For example, a VM fork reset right after a STI instruction can trigger
> >> the failed entry. This is due to the guest non-register state not being saved
> >> from the parent VM, thus the reset operation only copies the register state.
> >>
> >> Fix this by adding a new pair of hvm functions to get/set the guest
> >> non-register state so that the overall vCPU state remains in sync.
> >>
> >> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> >
> > Reviewed-by: Kevin Tian <kevin.tian@intel.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> with ...
>
> >> @@ -863,6 +892,17 @@ static inline void hvm_set_reg(struct vcpu *v,
> >> unsigned int reg, uint64_t val)
> >>      ASSERT_UNREACHABLE();
> >>  }
> >>
> >> +static inline void hvm_get_nonreg_state(struct vcpu *v,
> >> +                                        struct hvm_vcpu_nonreg_state *nrs)
> >> +{
> >> +    ASSERT_UNREACHABLE();
> >> +}
> >> +static inline void hvm_set_nonreg_state(struct vcpu *v,
> >> +                                        struct hvm_vcpu_nonreg_state *nrs)
> >> +{
> >> +    ASSERT_UNREACHABLE();
> >> +}
>
> ... these unnecessary stubs dropped (they should be introduced only
> once actually needed, i.e. when a caller appears in a file which is
> also built when !CONFIG_HVM), and ...
>
> >> --- a/xen/arch/x86/mm/mem_sharing.c
> >> +++ b/xen/arch/x86/mm/mem_sharing.c
> >> @@ -1643,6 +1643,13 @@ static int bring_up_vcpus(struct domain *cd,
> >> struct domain *d)
> >>      return 0;
> >>  }
> >>
> >> +static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu
> >> *cd_vcpu)
> >> +{
> >> +    struct hvm_vcpu_nonreg_state nrs = {};
> >> +    hvm_get_nonreg_state(d_vcpu, &nrs);
>
> ... this missing blank line inserted between these two lines. I'll
> make both adjustments while committing.

Thanks, both changes are fine from my side.

Tamas


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:41:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:41:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315184.533606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjnD-00058N-TF; Wed, 27 Apr 2022 15:41:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315184.533606; Wed, 27 Apr 2022 15:41:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjnD-00058G-QJ; Wed, 27 Apr 2022 15:41:27 +0000
Received: by outflank-mailman (input) for mailman id 315184;
 Wed, 27 Apr 2022 15:41:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=96F5=VF=kernel.org=kuba@srs-se1.protection.inumbo.net>)
 id 1njjnC-00058A-38
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:41:26 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7db785fe-c640-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 17:41:24 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 0B961617B7;
 Wed, 27 Apr 2022 15:41:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C186C385AD;
 Wed, 27 Apr 2022 15:41:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7db785fe-c640-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651074082;
	bh=rE+qwrcYq1YEDwagHt9bw0Dmvq2A/QwK2cQtgGYtZKA=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=t+rRpvTelqAmnOxdhSnJBNQ97HYVO1XodTEWwDfdhbxiVpvUs+NWkAu00L0KAWCjP
	 PcSQuS0lYSCwzFvNFQabbm9RTHxWFPt7HKSNJfJlwDdMEE8CRTiKRdFFSq1BcqRW5F
	 Mld1jCYk7HsQSNZXkm00T4qPUjKnsHAcRqBYRN6thrfPCsmggIfeRUpFL78tLsBd/n
	 RleASA3ke4E/qVXBqnOgH8c5zlPm8j0hYYNrt1nynlzoZRhN4Ol44vbGoMFmIhQXOL
	 36VdePnn7Vku9k2R4p7RdwiICc+qF+FVqkxEWAfz3MvAstn5GaB2tKbZOvn7vvx3G/
	 f8GLg0Qwv5hhA==
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net,
	pabeni@redhat.com
Cc: netdev@vger.kernel.org,
	Jakub Kicinski <kuba@kernel.org>,
	ulli.kroll@googlemail.com,
	linus.walleij@linaro.org,
	mlindner@marvell.com,
	stephen@networkplumber.org,
	nbd@nbd.name,
	john@phrozen.org,
	sean.wang@mediatek.com,
	Mark-MC.Lee@mediatek.com,
	matthias.bgg@gmail.com,
	grygorii.strashko@ti.com,
	wei.liu@kernel.org,
	paul@xen.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-omap@vger.kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH net-next 01/14] eth: remove copies of the NAPI_POLL_WEIGHT define
Date: Wed, 27 Apr 2022 08:40:58 -0700
Message-Id: <20220427154111.529975-2-kuba@kernel.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220427154111.529975-1-kuba@kernel.org>
References: <20220427154111.529975-1-kuba@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Defining local versions of NAPI_POLL_WEIGHT with the same
values in the drivers just makes refactoring harder.

Drop the special defines in a bunch of drivers where the
removal is relatively simple so grouping into one patch
does not impact reviewability.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: ulli.kroll@googlemail.com
CC: linus.walleij@linaro.org
CC: mlindner@marvell.com
CC: stephen@networkplumber.org
CC: nbd@nbd.name
CC: john@phrozen.org
CC: sean.wang@mediatek.com
CC: Mark-MC.Lee@mediatek.com
CC: matthias.bgg@gmail.com
CC: grygorii.strashko@ti.com
CC: wei.liu@kernel.org
CC: paul@xen.org
CC: prabhakar.mahadev-lad.rj@bp.renesas.com
CC: linux-arm-kernel@lists.infradead.org
CC: linux-mediatek@lists.infradead.org
CC: linux-omap@vger.kernel.org
CC: xen-devel@lists.xenproject.org
---
 drivers/net/ethernet/cortina/gemini.c         | 4 +---
 drivers/net/ethernet/marvell/skge.c           | 3 +--
 drivers/net/ethernet/marvell/sky2.c           | 3 +--
 drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 +--
 drivers/net/ethernet/ti/davinci_emac.c        | 3 +--
 drivers/net/ethernet/ti/netcp_core.c          | 5 ++---
 drivers/net/xen-netback/interface.c           | 3 +--
 7 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
index 8014eb33937c..9e6de2f968fa 100644
--- a/drivers/net/ethernet/cortina/gemini.c
+++ b/drivers/net/ethernet/cortina/gemini.c
@@ -68,7 +68,6 @@ MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
 #define DEFAULT_GMAC_RXQ_ORDER		9
 #define DEFAULT_GMAC_TXQ_ORDER		8
 #define DEFAULT_RX_BUF_ORDER		11
-#define DEFAULT_NAPI_WEIGHT		64
 #define TX_MAX_FRAGS			16
 #define TX_QUEUE_NUM			1	/* max: 6 */
 #define RX_MAX_ALLOC_ORDER		2
@@ -2472,8 +2471,7 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
 	netdev->max_mtu = 10236 - VLAN_ETH_HLEN;
 
 	port->freeq_refill = 0;
-	netif_napi_add(netdev, &port->napi, gmac_napi_poll,
-		       DEFAULT_NAPI_WEIGHT);
+	netif_napi_add(netdev, &port->napi, gmac_napi_poll, NAPI_POLL_WEIGHT);
 
 	ret = of_get_mac_address(np, mac);
 	if (!ret) {
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index cf03c67fbf40..c1e985416c0e 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -50,7 +50,6 @@
 #define PHY_RETRIES	        1000
 #define ETH_JUMBO_MTU		9000
 #define TX_WATCHDOG		(5 * HZ)
-#define NAPI_WEIGHT		64
 #define BLINK_MS		250
 #define LINK_HZ			HZ
 
@@ -3833,7 +3832,7 @@ static struct net_device *skge_devinit(struct skge_hw *hw, int port,
 		dev->features |= NETIF_F_HIGHDMA;
 
 	skge = netdev_priv(dev);
-	netif_napi_add(dev, &skge->napi, skge_poll, NAPI_WEIGHT);
+	netif_napi_add(dev, &skge->napi, skge_poll, NAPI_POLL_WEIGHT);
 	skge->netdev = dev;
 	skge->hw = hw;
 	skge->msg_enable = netif_msg_init(debug, default_msg);
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index ea16b1dd6a98..a1e907c85217 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -63,7 +63,6 @@
 #define TX_DEF_PENDING		63
 
 #define TX_WATCHDOG		(5 * HZ)
-#define NAPI_WEIGHT		64
 #define PHY_RETRIES		1000
 
 #define SKY2_EEPROM_MAGIC	0x9955aabb
@@ -4938,7 +4937,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		}
 	}
 
-	netif_napi_add(dev, &hw->napi, sky2_poll, NAPI_WEIGHT);
+	netif_napi_add(dev, &hw->napi, sky2_poll, NAPI_POLL_WEIGHT);
 
 	err = register_netdev(dev);
 	if (err) {
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
index 4cd0747edaff..95839fd84dab 100644
--- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
+++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
@@ -30,7 +30,6 @@
 #define MTK_STAR_WAIT_TIMEOUT			300
 #define MTK_STAR_MAX_FRAME_SIZE			1514
 #define MTK_STAR_SKB_ALIGNMENT			16
-#define MTK_STAR_NAPI_WEIGHT			64
 #define MTK_STAR_HASHTABLE_MC_LIMIT		256
 #define MTK_STAR_HASHTABLE_SIZE_MAX		512
 
@@ -1551,7 +1550,7 @@ static int mtk_star_probe(struct platform_device *pdev)
 	ndev->netdev_ops = &mtk_star_netdev_ops;
 	ndev->ethtool_ops = &mtk_star_ethtool_ops;
 
-	netif_napi_add(ndev, &priv->napi, mtk_star_poll, MTK_STAR_NAPI_WEIGHT);
+	netif_napi_add(ndev, &priv->napi, mtk_star_poll, NAPI_POLL_WEIGHT);
 
 	return devm_register_netdev(dev, ndev);
 }
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index 9d1e98db308b..2a3e4e842fa5 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -113,7 +113,6 @@ static const char emac_version_string[] = "TI DaVinci EMAC Linux v6.1";
 #define EMAC_DEF_RX_NUM_DESC		(128)
 #define EMAC_DEF_MAX_TX_CH		(1) /* Max TX channels configured */
 #define EMAC_DEF_MAX_RX_CH		(1) /* Max RX channels configured */
-#define EMAC_POLL_WEIGHT		(64) /* Default NAPI poll weight */
 
 /* Buffer descriptor parameters */
 #define EMAC_DEF_TX_MAX_SERVICE		(32) /* TX max service BD's */
@@ -1949,7 +1948,7 @@ static int davinci_emac_probe(struct platform_device *pdev)
 
 	ndev->netdev_ops = &emac_netdev_ops;
 	ndev->ethtool_ops = &ethtool_ops;
-	netif_napi_add(ndev, &priv->napi, emac_poll, EMAC_POLL_WEIGHT);
+	netif_napi_add(ndev, &priv->napi, emac_poll, NAPI_POLL_WEIGHT);
 
 	pm_runtime_enable(&pdev->dev);
 	rc = pm_runtime_resume_and_get(&pdev->dev);
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index 16507bff652a..21b0e961eab5 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -24,7 +24,6 @@
 #include "netcp.h"
 
 #define NETCP_SOP_OFFSET	(NET_IP_ALIGN + NET_SKB_PAD)
-#define NETCP_NAPI_WEIGHT	64
 #define NETCP_TX_TIMEOUT	(5 * HZ)
 #define NETCP_PACKET_SIZE	(ETH_FRAME_LEN + ETH_FCS_LEN)
 #define NETCP_MIN_PACKET_SIZE	ETH_ZLEN
@@ -2096,8 +2095,8 @@ static int netcp_create_interface(struct netcp_device *netcp_device,
 	}
 
 	/* NAPI register */
-	netif_napi_add(ndev, &netcp->rx_napi, netcp_rx_poll, NETCP_NAPI_WEIGHT);
-	netif_tx_napi_add(ndev, &netcp->tx_napi, netcp_tx_poll, NETCP_NAPI_WEIGHT);
+	netif_napi_add(ndev, &netcp->rx_napi, netcp_rx_poll, NAPI_POLL_WEIGHT);
+	netif_tx_napi_add(ndev, &netcp->tx_napi, netcp_tx_poll, NAPI_POLL_WEIGHT);
 
 	/* Register the network device */
 	ndev->dev_id		= 0;
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index fe8e21ad8ed9..8e035374a370 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -42,7 +42,6 @@
 #include <xen/balloon.h>
 
 #define XENVIF_QUEUE_LENGTH 32
-#define XENVIF_NAPI_WEIGHT  64
 
 /* Number of bytes allowed on the internal guest Rx queue. */
 #define XENVIF_RX_QUEUE_BYTES (XEN_NETIF_RX_RING_SIZE/2 * PAGE_SIZE)
@@ -739,7 +738,7 @@ int xenvif_connect_data(struct xenvif_queue *queue,
 	atomic_set(&queue->inflight_packets, 0);
 
 	netif_napi_add(queue->vif->dev, &queue->napi, xenvif_poll,
-			XENVIF_NAPI_WEIGHT);
+			NAPI_POLL_WEIGHT);
 
 	queue->stalled = true;
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:45:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:45:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315191.533618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjrH-0005ox-J1; Wed, 27 Apr 2022 15:45:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315191.533618; Wed, 27 Apr 2022 15:45:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjrH-0005oq-ES; Wed, 27 Apr 2022 15:45:39 +0000
Received: by outflank-mailman (input) for mailman id 315191;
 Wed, 27 Apr 2022 15:45:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njjrF-0005og-IB; Wed, 27 Apr 2022 15:45:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njjrF-0000b1-Da; Wed, 27 Apr 2022 15:45:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njjrE-0006ZZ-UT; Wed, 27 Apr 2022 15:45:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njjrE-00083D-U0; Wed, 27 Apr 2022 15:45:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wgZSP01NfbM80orYtgnqG6UUvM6VbiNomYtgYOf0ztc=; b=ewhLq6FeLCeVvIaCNroGW6jhXx
	gCJissLdfG9RtKbjF3DeLnFWfJlQC/isu+GKhT063gkTnoX/TM8MoiL2iHl9S0XJ0CofV0Sr/X1ZC
	faEGM+KEIkQoxH/p7FZ+loJ46gcey9xwWv5OxwLsnUDHgczz12S7bxpeRRtUPegiejfE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169768-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169768: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6975ed0a940401bd6ac5d75bbec758f340e7351c
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 15:45:36 +0000

flight 169768 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169768/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6975ed0a940401bd6ac5d75bbec758f340e7351c
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  656 days
Failing since        151818  2020-07-11 04:18:52 Z  655 days  637 attempts
Testing same since   169768  2022-04-27 04:18:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 106089 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:47:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:47:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315198.533629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjss-0006RG-Ut; Wed, 27 Apr 2022 15:47:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315198.533629; Wed, 27 Apr 2022 15:47:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjss-0006R9-Qy; Wed, 27 Apr 2022 15:47:18 +0000
Received: by outflank-mailman (input) for mailman id 315198;
 Wed, 27 Apr 2022 15:47:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njjss-0006R1-Fn
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:47:18 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4f7e5ddb-c641-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 17:47:16 +0200 (CEST)
Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 11:47:14 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by MWHPR03MB2957.namprd03.prod.outlook.com (2603:10b6:300:11c::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 15:47:12 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 15:47:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f7e5ddb-c641-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651074437;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=m8rPRt5THtYNJBlROCeNE8vtXEzP8FuWFMXOMasodM4=;
  b=H3cmvUbJiGOlosyZm83UwUiH5hBFUBIjtWyEItqUoISgh4kDkRkgoM6H
   AFKdJv9HH07jAsHgzbpJOmj2Nf6aFTg4bTnqERiKTqdxdjDtWcmfVj6j3
   OGoNIN/j5aRkFR2nR9uFqkz/CVFTTVQXR0pZhSR3JSXESgrr3ZgQrkCgH
   Y=;
X-IronPort-RemoteIP: 104.47.55.109
X-IronPort-MID: 70055435
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:sxMfG66FFxjfaTr040Sr1wxRtDnGchMFZxGqfqrLsTDasY5as4F+v
 mVOXz+DOvzcZ2Khfd91YYjk/B4D7JTVnYVjG1Nlr3g3Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjXFvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSeUEArZ4P0gtgtdDJlKgNbMq5d05TYdC3XXcy7lyUqclPK6tA3VAQTAtdd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YAjV/chegXdRraT
 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA8A/I+fFqi4TV5Cpu0YDzL+HVRo2xbIJOwU+9/
 kLc32usV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL
 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJ4Huw88wWA4rLU+xqDB3hCQjMpVTA9nMo/RDhv0
 0DTmdrsXGRrqOfMESPb8aqIpzSvPyRTNXUFeSIPUQoC5Z/kvZ03iRXMCN1kFcZZk+HIJN05+
 BjSxABWulnZpZRjO3mTlbwfvw+Rmw==
IronPort-HdrOrdr: A9a23:yevEta/VeaWTsTCe0YJuk+E+db1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYVYqN03IV+rwWpVoJkmsjaKdgLNhRItKOTOLhILGFvAH0WKP+V3d8k7Fh5NgPN
 lbAs9D4bTLZDAV7PoSiDPIaerIq+P3lZxA692urEuEGmpRGtpdBkpCe3GmO3wzYDMDKYsyFZ
 Ka6MYCjz28eU4PZsD+InUeReDMq/DCiZqjOHc9dlcawTjLqQntxK/xEhCe0BtbezRTwY06+W
 yAtwDi/K2sv9yy1xeZ/W7O6JZ9nsfn17J4dbqxo/lQDg+pphejZYxnVbHHlDcpoNu34FJvq9
 XIqwdIBbUA11rhOkWO5Tf90Qjp1zgjr1X4z0WDvHflqcvlABonFston+tiA1bkwntlmOs5/L
 NA3mqfuZYSJwjHhj7B69/BUAwvvlaooEAljfUYgxVkIMEjgYdq3MMiFX5uYdk99HqQ0vFnLA
 AuNrCW2B9uSyLXU5iD1VMfgOBFXRwIb2S7qwY5y4+oOgNt7Q9EJnsjtbAid0g7hewAouF/lo
 L524RT5cRzp5wtHNZA7Nloe7rHNkX9BTTxDUm1HXPLUIk6BlOlke+G3Fxy3pDjRKA1
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="70055435"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GEoWjckPRwNkMhZ7Wzk5zK/H+O8jlF01g3miLpAiXOZbHJQ87dad4UuwQta7HmTAPa3jRjzHmLY6QMI+8Cwn5UdnKz5VAB7LVxChapDJddgFVxetks6Q7qzVphnn6lci8pH5oJf3L+hORCdAWXGzPQPuVRdRcMvvEXJ5RTQhGU6cm/SnHiLHuBFV1J1fYRE0WfV7RKfqmAqy7VK1Gud4U+cFCtp82SkO39LcB3QPoJqDuuQXu9z4f01jOmdM5G6c/VLGvG/P+bGSNWnSwaGVbGKlYTZOanTPno+UuQewTF3KVbcuIujhMWCXhU3iI4vlbLsZJ2mMv/bHVBXC8tsusw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=unVUOTMEiGDOnk056OLERWvD7aIsW3mOlXPAuysFbsQ=;
 b=h0JMvSb8ybH6GpcsKus89Askc4ALb9Vket0+x3DT7BmEh7c9YDB1L8evB7KHR4EjEX2gLLLtwpUM+j8TXDO77Jdpanx9qO0euZFxd7iOo+I1jOj8T+e1ScjLstaXpb7heV5WX4e1TIQS07c/X08uu+uhaxSlyGRpcje9FPkEIHjlNtOvZxuEJhfNeWjEG6pnG0dQBKMMfOleszqvC7IKx6bmu4z65/PsWUCHGavI4z90Zp81ealYzppsCNq3N9Bm8Jx+ilxuZ7bDwklMqoezMA2S0jcpGQTspZTsWzaHrdBs85OGOSpDwxo5W+yRTv4+TbkL6rc4mIptSpe9EgD94Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=unVUOTMEiGDOnk056OLERWvD7aIsW3mOlXPAuysFbsQ=;
 b=iw/2ElKCchijxcgfJDeb4ggqupfFL1JFAu2gUqfZEwCsH0odezSFNCJT2aoqzUQXUULB+92pz2IOXR4KCPlSEP6xXcf5GAsy1fLZcIKt6efZWpCfeNiDL4jAitEnMK6YhInh8OELKky3/jBbbmy1kaH5Iq+D5MixROw4IexCdTY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>,
	Steffen Einsle <einsle@phptrix.de>
Subject: [PATCH] x86/msr: handle reads to MSR_P5_MC_ADDR
Date: Wed, 27 Apr 2022 17:47:01 +0200
Message-Id: <20220427154701.84315-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0057.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 77ebc2d9-5d82-44ed-8321-08da28653220
X-MS-TrafficTypeDiagnostic: MWHPR03MB2957:EE_
X-Microsoft-Antispam-PRVS:
	<MWHPR03MB295724FD31783BB145A907408FFA9@MWHPR03MB2957.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mKFo0nf3echJIToXYcgYJMnBvkkSiZcebtgLwO3YfG4bauTmHpxNm995mb4CXspXqo1FUiXm+JD7r/j7IEeu8yzui8hRnrnqAPKzGyIIlMqwHHuE8WEXx7714iZm4HYVrsc+9TBwEOhbGlJu500adZ/tTQU4eVPkvSxtN79CUwaZGTWlljR1LJn484Y4vzsl2Ov5yetcObFxv2caBwHoESUhJWxrcgUk2irmRot+Vo6ScV+kNhP8r5E23yyYiddjop2Sn/T5+n+ZwWMKVbcZem/+xMxWL3d+4h8tETd7DE9Lql475NKmGqKLJGLc/BO/mgdQdcd2rNPQFm1o+hUHzGxO7miUDwlUf6Gr58fviJ5v4kgk/jXpxgLdd/n9LwzwIpNG1bkJrIQFZDCpfn2Aq896JXH6KeuOFkNr2OixhI+7cLUdtHu7+k7qq1Wrn1/UzXQJKQsMkGuTKpGeKhT4PttW6SlOa+28iXy8vWPh/lqHlFPRJJdek8wWOLZMDHHINiZhBSfsb9HIXbGbI9/FDfKJ01yUx9liwBK2Q+gIKMpb7kEo087So40LzY1pPEHjUSdLTjnhRVbqi3s/oNZhOjh6YiYVAI0+83EbBKWsOpXArGOFbU0TJZAcybJGKI0CYKX7MNNvzlIUFXM+Usdqvg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(186003)(86362001)(1076003)(6512007)(508600001)(6666004)(6506007)(38100700002)(2616005)(8936002)(8676002)(36756003)(4326008)(5660300002)(2906002)(82960400001)(316002)(66556008)(66946007)(26005)(66476007)(54906003)(83380400001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SXBYS2ptU1ljQ1lPZHJ4RkRpNVliZXZtMldMZ0ljaUoxTmh1VnNCejBKZ3N1?=
 =?utf-8?B?Wm15MGxRZllZOHNZcWpTNDVJVm9TNS81T0h5Z2JjRGxiTFFYc2RoYzkxMzRB?=
 =?utf-8?B?aXZhSWY2M1hRbGNYN3pESHJQc0MvbkFPalBBY0JtVkRwVE5yRE8vUVN2RnJ6?=
 =?utf-8?B?ZmxOc2dqL2lDWVFmOW9uRFV5L0h2dWdlSlBxYitVVitjMGwydGZJOFB4aWIr?=
 =?utf-8?B?NGVucjVLT3JkWnFKZEgvbFYxSHBUR2k4bkVkWnNpODhrK1pTREloNXdiaEdj?=
 =?utf-8?B?bzJUbVpEYmxZVlJyOVpUUFRhRlFTd29pSUZUOWJua1N1NytCWThXTzFRUDZP?=
 =?utf-8?B?U3UvMi9zK1RqaWJpenlSZVZMSis2M1NkTkFMQVJsZWQxTW04SDROdFRCUC85?=
 =?utf-8?B?YVRqSzI1NDJIUGxGQldmTU9OajlycUtxTFp5akNiQU1PUVNvSTRSZThtV0lk?=
 =?utf-8?B?Vmx4ZzNWWkpxV3p3TlN4Z0VTS3Y0RE5PcnJYcTkvcmRTSXlsWjM1b3dhWjRs?=
 =?utf-8?B?OWRrQXhVV05mdDZVbnNqVGcya21XamRacVRhUGRvdHJOQVV4d0NFM2RwclZ4?=
 =?utf-8?B?YjlTL1BpTE9EaVBZc1c0M3A0Q2tlVklMQjJ1ZWZpTktBRm1Jem1QZVNURml6?=
 =?utf-8?B?SkpNL3k5V3JTWUo3NnVxVXltdld0UU1UaVhNTGdHTkJkckRsTnZLZkt6REhw?=
 =?utf-8?B?ei9sR0Q5STZVM2c3MGZIa0dud3Y1MCtTZit6TlRoOVdFV0tCemJLeXAzT1FC?=
 =?utf-8?B?NWZlMUxhL2hkVFBiZkFWZWl1Y1dibFY3bU9rQ21xS0JqTHlzZ1BQZW1Iclov?=
 =?utf-8?B?cVRPY2VmbmRVUnBMZDN3VXFDd2dhTEovK3FXS2tGVGVLTXNjT2FmM1Q2RzBz?=
 =?utf-8?B?c2svcU1nM3dBTU9CZXhUTHFScDVINTRnMm4yRTRiODBoRjRPamlveEdWNy8w?=
 =?utf-8?B?UzJNUnlPam5IeUxWTVBBN0FvaEdrZFR0UU51aXN0VEU0ZU1BUExGeGJwWWRy?=
 =?utf-8?B?UnVRanpJOWFRZjBobDhkakpqSzM3Q3pRM3k2ZlNQbnlTS0JNMmtkMW52OVpk?=
 =?utf-8?B?S0RqTitLMDNjakVibW5PeWlVZlRReEhEbUlKTFdLVGROUDg4YmV6U2YwRjVu?=
 =?utf-8?B?S0gyQlVMZWtWVVVoRG5XVkNDS1llZ0xXNDd0aktXc2x4WGxJS0pCY2RPdlZj?=
 =?utf-8?B?dzl0empJaEVRZkFJdlhZUnhTM3k0SEJQeUxyRzJpZmxCNUgrcmZ0MHgxS0Zk?=
 =?utf-8?B?TEwwc3BSSXZSU0J1TVZjZzBqaHdNVDNuU3piWDZucVdZUkR4THRWalRiL29P?=
 =?utf-8?B?eGxiQjZONFN0cEp5QUhEM096UDhDT3JLMnliMXZJSGxkREd1UThvRDQ0UUxT?=
 =?utf-8?B?aTFFNGVVS2Z6dUxMT0tSQ0k4WjF1dFNwYlZKQ0paL1JydUxUR3FLaUwrQTc5?=
 =?utf-8?B?NGs3Q3NUb2pXbXNXcHFnRTBuNVJaUmJmQnh6clhLNS9XZk1PN21xR2VGSVBv?=
 =?utf-8?B?MHZpWjllUW9oTEpER3ZxNDdGY2J3SVA4WVF3bGN2ZTAvbUJ5NThkenYrSFRn?=
 =?utf-8?B?QmJpMW1YdFg1RUtSTXhzQkVNVE1VcmlYTmNwS1pFcmMzVFd4d1Z2VXVneWF4?=
 =?utf-8?B?QkswU2crVGRXdDMraW1BV3MrM3NiY0xPT2g1Um53aURSRjM5K1ljbEhwSFpk?=
 =?utf-8?B?dmVGME1PeE5tcjVYbzRPZzNmQXJjU0hmUytQNEw5UnBXTS9EaUlpM21KQlBI?=
 =?utf-8?B?NGpWeEllZ01wbTZkKzFzTE1nRm5EWnVJSzAwei9UNnA3NjlDL293eHgvM2Y2?=
 =?utf-8?B?TlpFTWYwamZFakFjR3B4WEFIeHZJQ25ia2VRRjRkbmllaXo0MFpycEhwQ3ZC?=
 =?utf-8?B?eE5kdDNiYUdDem9wUUtXU1czZjJLRWNmeHdqYTNZVjRYaEpqN1FhaEkyUjJ2?=
 =?utf-8?B?a0VJZDNwZlo0R0hVTUtQQStweEhBZEF5TGliRC9lUkp6ZFFPTGcvUnBhMEFH?=
 =?utf-8?B?WnlhR1lMcEdsN0Q3TktjQUQwN0JQbStXekdtOThtOTlEcGxEZ2xtbGxReEhF?=
 =?utf-8?B?VjROYU9ldlcwZjJsYytlWVdDUWhvRTNQdDF4SWlHdXpzN0hoZWhTdGQ5SDd0?=
 =?utf-8?B?VE9LQzJ2dFZQTVVXNys5SlN4Ync2R1ZVSUxjWkhRYmp4dDdFdklORythdk1S?=
 =?utf-8?B?WngveXZ0NXlNRWZYUkZvZnhVV3NHR284eFQ4MkpXVUhqckFaWXRuRlgxVHph?=
 =?utf-8?B?NzhCU1VnQm9ydTEyQVQvWjk3ekp3YlUzWFIxeDlabW8rY3Q1ZU9NcHR2ME5a?=
 =?utf-8?B?U21VOCtUZzByNUNHOUJPZDRUUExZM05Kd2g0aTdxUFZRbC9EM1JEVGxRSzgy?=
 =?utf-8?Q?hN8Cyf5fYOeflygo=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77ebc2d9-5d82-44ed-8321-08da28653220
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 15:47:12.6173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v5NMb/vlkKHmBLJ3YOLEDbEhc8jY84s1s5/4i1hVOrcSSPNMQ76t9nTrSgpG0PuoXZFgoU6MGk//6clXurZs2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2957

Windows Server 2019 Essentials will unconditionally attempt to read
P5_MC_ADDR MSR at boot and throw a BSOD if injected a #GP.

Fix this by adding dummy handling that returns 0 for reads of
P5_MC_ADDR.  This seems to be enough to make Windows happy.

Reported-by: Steffen Einsle <einsle@phptrix.de>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
I've added it for CENTAUR and SHANGHAI because the MSR is there since
Pentium, so likely to be implemented by those vendors also, but have
no way to check.

I wonder how long it will take for Windows to also start poking at
MSR_IA32_MC0_ADDR or other MCE related registers.  For now this seems
to be enough.
---
 xen/arch/x86/include/asm/msr-index.h |  2 ++
 xen/arch/x86/msr.c                   | 13 +++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h
index 3e038db618..02af9dc039 100644
--- a/xen/arch/x86/include/asm/msr-index.h
+++ b/xen/arch/x86/include/asm/msr-index.h
@@ -15,6 +15,8 @@
  * abbreviated name.  Exceptions will be considered on a case-by-case basis.
  */
 
+#define MSR_P5_MC_ADDR                      0
+
 #define MSR_APIC_BASE                       0x0000001b
 #define  APIC_BASE_BSP                      (_AC(1, ULL) <<  8)
 #define  APIC_BASE_EXTD                     (_AC(1, ULL) << 10)
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index a1e268eea9..e50bbf466a 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -216,6 +216,19 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
     case MSR_AMD_PPIN:
         goto gp_fault;
 
+    case MSR_P5_MC_ADDR:
+        /*
+         * Windows Server 2019 Essentials will attempt to read the MSR and
+         * throw a BSOD if a #GP is raised, so just return 0 in order to make
+         * Windows happy.
+         */
+        if ( !(cp->x86_vendor & (X86_VENDOR_INTEL | X86_VENDOR_CENTAUR |
+                                 X86_VENDOR_SHANGHAI)) )
+            goto gp_fault;
+
+        *val = 0;
+        break;
+
     case MSR_IA32_FEATURE_CONTROL:
         /*
          * Architecturally, availability of this MSR is enumerated by the
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:50:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:50:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315207.533640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjw7-0007sD-G7; Wed, 27 Apr 2022 15:50:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315207.533640; Wed, 27 Apr 2022 15:50:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjw7-0007s6-D6; Wed, 27 Apr 2022 15:50:39 +0000
Received: by outflank-mailman (input) for mailman id 315207;
 Wed, 27 Apr 2022 15:50:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njjw6-0007rz-HA
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:50:38 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c6e094f7-c641-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 17:50:36 +0200 (CEST)
Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 11:50:34 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by CO6PR03MB6306.namprd03.prod.outlook.com (2603:10b6:5:35f::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr
 2022 15:50:33 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 15:50:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6e094f7-c641-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651074636;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=t2jJHmpPnn/fy8zsKnvrO6EytiJHwVLm7Gh0v9RApAk=;
  b=AuR4dzXkfJzI8c0wTyZHwVL73INbjaAhfc+EEWpxu1pkfjoP8LfbpI59
   5+ynsCyxI4QjtxumpJJ5WtPXCExnw4H+cFqGpjdD+Qz+naRJbjaIjsA3X
   50CDmgerrpTGhGv6h1gfM8UovAAGnuTxdpt/fVbWDxYCs0coRcWotkmYM
   E=;
X-IronPort-RemoteIP: 104.47.56.175
X-IronPort-MID: 70462325
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:JLJXp6OC9XviEmrvrR25lsFynXyQoLVcMsEvi/4bfWQNrUon0D0Cm
 DcdDD+Da67eZTT3e4x3Oovj/E4F75CDytA1GQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NEw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw
 tBWv525ciAVNIb1gMcHUEh4KBMlBPgTkFPHCSDXXc276WTjKiKp6NI3SUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7H9aaHPiiCdxwhV/cguhUGvnTf
 YwBYCdHZxXceRxffFwQDfrSmc/33iWhKWYC9Tp5o4ITuEzo71V17oHNbvCIaOOAasUIlRaX8
 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1a3E62StjwWTWorXjCuQQTM/JLCPEz4gyJzqvS4i6aC3ICQzoHb8Yp3OcpQRQ62
 1nPmMnmbQGDq5WQQHOZs7yT9DW7PHFMKXdYPHBZCwwY/9PkvYc/yArVScpuG7K0iduzHizsx
 zeNr241gLB7YdM36phXNGvv21qEzqUlhCZsjukLdgpJNj9EWbM=
IronPort-HdrOrdr: A9a23:uY6XtqPnvxb0JcBcTjGjsMiBIKoaSvp037BK7S1MoH1uA6ulfq
 WV9sjzuiWatN98Yh8dcJW7Scq9qBDnhPpICOsqXYtKNTOO0AeVxcNZnOnfKlXbcBEWndQtsJ
 uIHZIeNDXxZ2IK8foT4mODYqkdKA/sytHXuQ/cpU0dPD2Dc8tbnmFE4p7wKDwNeOFBb6BJba
 a01458iBeLX28YVci/DmltZZm/mzWa/KiWGSLvHnQcmXKzsQ8=
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="70462325"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=amehbEuHfr+NqzgIa72mFuW0/gAV0uqMD6BRDfF6xEbZrJQydCeuMzWf1Et3NoajH5CPpz9YjW7zS3UzESWdU5gHD8ug4GlpbwAubLV3AzVJxhrw4k9Gleo0vI3N6kCchp4cRkirBKyg+AlClAUm74cUNvfFIXtEf69cigjigMqNh6x0moOMGlgR002QvByC+jdvyDa6gCebGjj58Gmt7H/7CSScFhSfkgjiqCLIWJmPe2RabclOU5Ln+AchizczIKEzWOG4HDg8x1SeHsiVua9JeCP8fzlE2ktNTBVotTabYKjeFKjT0s8VF4zxBhe158eVnT/ra+Ov25XwDPmz9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v83QwxLu8ckEOBPEItK5bDOSrud7YU+ikNBd+lWDON4=;
 b=divKZ17nvMWuqxrgNblwgEHO9ufUdJg1BwIqyoVfmLknhxOBnesmb3osvxGbJBV79qcxru4btKs2JPcZc3MNo/9/UrEKFYuFYInwt5f8e60ARu4j0ulXI1q94Lka8Wpb2fWozTFR7SeMGRjjJFPq9G96ItZid4WZQM+WrT04zessGyU3ARrgErK0d4PNAEKi1EydNv3ZWgoBG71IrvLReFmFy0RjHGhuh9Fxg087BiKpq6nnKgU5Aweer3K0h8J6DHGolzfSwj1IceRWtWumXfdbxsIb/3U1hX8O85w/9bNuC0Wr+EYDm7jJTpkXKg/01wYRUPQo3SlZFz5GFtdGog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=v83QwxLu8ckEOBPEItK5bDOSrud7YU+ikNBd+lWDON4=;
 b=fPAB1xD3pixasvFFh/FVhkY3NVB3Y4B/zfwWonFxPvOS/x3plW6v+GIRh6SixktXS65SFkpvLcElKLfKDhKJ9AYYy7pcqzC8m/sb27DCp03Gxy7S7gCmRfeFv5LBWg3B41jzvo0d7Jv0+7oUbbmD6sAT5feH92oC4ti3tBlapiQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] cirrus-ci: add FreeBSD 14 task
Date: Wed, 27 Apr 2022 17:50:23 +0200
Message-Id: <20220427155023.84403-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0091.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:191::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b90dfef2-add5-4e11-6f86-08da2865a9a2
X-MS-TrafficTypeDiagnostic: CO6PR03MB6306:EE_
X-Microsoft-Antispam-PRVS:
	<CO6PR03MB6306D5EB21109C12BF375DF08FFA9@CO6PR03MB6306.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wdzut5saBnrouL7oQlEXvNzenYW9FPtH+PT3KFT7/3La8QxiBmI2X2ATuCnE45LP7CnMhTBY3GvV/lqNB7LJzoT1RwLQrGptcUW0GRR5PhntpUPdtxFDH2AYZ6FmibJYivPqL0xELdugyXjTWTtuoUeEA6CIYMbnS5hQ9kblom+JCehh9kbUDblNoViX73kdFmUmrWFQUY5aP5wHwxo2D7jI/ibPWEIFkDozYQHN4qW4Th6sR/5VwrWAe4C9hJrU+5Fu1ry7shTyxMMwMsJXFUrf1R6atpwxlRMh8cvcKUQCIs9rewftwyp9la6qpy5pu9xkraD/cYGK+LclqLkU5GME9jP+ZF4f99czvwmFo6XfFPvK3+12VccNJ+vZ2/fFhbWKxQrW1BrV7QtpNSaxpMZc3oHPYmK/fyPxcUlSLLJ2Npg1p9nLqLjgVTJpmlqyrBJPBqP88I5/0IUHlG2FwPEA1R0bQ5idxRFA08C6m41/s4ynV6lx18Bu9lgZETPg5DFsVKICjrhWlAo21eqUclMGjdwPSSZZTq1D0pDt32i0hqxOT3WZgEUff7xgJ48n+KsDEpEER/Ucc39be853TtXVNyAmS0QNiKqVXVVIOa1lDjkv2+Yudkw9YG3SB95RtZBIWpE5Zp+kGXgwJAWgaA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(508600001)(2616005)(86362001)(6512007)(6506007)(26005)(1076003)(38100700002)(82960400001)(6666004)(186003)(66476007)(2906002)(4744005)(66946007)(66556008)(316002)(36756003)(5660300002)(8936002)(54906003)(4326008)(6916009)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y3RrQmEzM2VEMjdjZzY0a014NEpEbVdLOEhzcnp5b2R3MFBwUDYzUWVhTTVE?=
 =?utf-8?B?Zkc4VncwcnJPZmIyVWtsc2FNZGQ5S0xpZGFqVm9obVNOV1B0ZCtwakh1Q0F5?=
 =?utf-8?B?b0s3WFRtMnpLblZFaWVqTytaN0d0M0ZUL1o1QmlvcWFJdm1RRkU2d3ZtaVkw?=
 =?utf-8?B?SkNsQWcwYkpQelRuaUFSQ1ZVbnpiWkd4RlMraFNCUHZHdC9EWE9IS1ZSbCt6?=
 =?utf-8?B?VzFTRllLWUpWMHRFY0pSTWI3amtpWGdia3FRK3M2Q2UrajhaT0tUMTFRY3h2?=
 =?utf-8?B?ZTY5bmhzdWlQc3JpTmtvSTJ6dUxFb3ZYOThPeVZvQ05teDlGKzhPeXVnZnl5?=
 =?utf-8?B?VU8wbkNnNk9SVXBNZm96SlBKZzh1VXlSd3RVdDc1Q0dCOWZLSlBmRkVHVEQw?=
 =?utf-8?B?bHZGNURvZUhuQUF0T2xsb3FDclpGNkhHMW1yWFJiVDA3Z2xGcGFYc0F3U3Vs?=
 =?utf-8?B?YTlxdVJWaDF1MFowU3dBM3ZvMG93N3piMHFEM3k2TkFoVUNTdEhvYkU5TVh4?=
 =?utf-8?B?WS9sRWhOMW5EdElyaUpVQW9NVU5Gcmp6NnlWU3g3YThoZHVvcE50UXNUYmo5?=
 =?utf-8?B?eFk0ZkNLU0YrdnBiZDdRR0swUkhXY21OUUNOQ2U3RnhENWFyT01kNkc4RmFx?=
 =?utf-8?B?VjdHWWdXUjlUcG5HRUQ5Zjg1TUJWckNUVHpCeTFET2lCQkNyeHVtbncxTXF0?=
 =?utf-8?B?WjVkQmtueDFSTi9HUnUyS0xxSVVHdmhSTHY5RnFENy96QXdsMjc3QlJRbktJ?=
 =?utf-8?B?M1hQUDZxSWREeDNaUjdjMGFoMEVOYnlJSmZRNXVaUWpKbFJleWExWUQ0UW5h?=
 =?utf-8?B?OXRqcXh5NFR1b1NFU2RRTDVMS0NlMnBPMzJ5YWdqT2xIaDRlK2R3VU53NjhZ?=
 =?utf-8?B?cjg1QWdNUU1SZU80Z1RyNFA2WGVHNGp2RkRiY1ljVmREeFByY01ra094Z0Fy?=
 =?utf-8?B?RERnOUhOR3VZbXdQbGVJNlhwUFlIN2xxU01Jd1lvQVFSazRBMlNJRGs0Zjc1?=
 =?utf-8?B?TWMyaW1rTmJGMUxxZldvOXZlbmxPR3BWZFZYTDVCYzlibmtxNUNnZytLOExS?=
 =?utf-8?B?VUVQZ29pNEw2ajdxM2Z3NjUvTGdYZkYvZW56K0V1UDN6cGkwUmtPNFRJakFM?=
 =?utf-8?B?eFFTUGljRFE3T0dJK0ZUVUs1WER4bS92MXdHd0dOdzVEUGRjdUsxVWN6THBN?=
 =?utf-8?B?SHJTSlFZNmlZakd1ZjZOQ0R0YWRJdm94SDlHeU5LVkRHb3JhV1UwUWpGMElz?=
 =?utf-8?B?N1puTEZ0czltdG1JRlBYcyt3bWtMQk5GcEtjam5uQTdmdktTV0tFaW1BNXFO?=
 =?utf-8?B?TlhDdDNVSkZMR1VzWWhqL1VCdW80VmMrbVp6VlVQd3grK01QcUVKbXJueVZv?=
 =?utf-8?B?ZW8wa0t3K0V5aDRxejZnTjBhVjlXdm00VnF2Z2lQdVUzN3FNRkpBLzUwYU5G?=
 =?utf-8?B?Z2wwQzJnZXdHM0I2WjREbEkvOFhQQlRYM0JCVEhWRCtIMkZ2QUtQcDFJaTBL?=
 =?utf-8?B?bDB3emZxclpNbEtjbUVJeGQ1TENlNVlrd2FjdndtWEoyWmdnejQ5QzR2djdr?=
 =?utf-8?B?RHUwZHBKeGhEclZLcDBObWhsVFhMT1J4WjlmMFYxYm9CV3IzYzR0SHFLL2dL?=
 =?utf-8?B?cHBoZ2FhdXorM2RHblEwaS9qNk82djRQOEkwZzFoQUljeFZkTnljaVVnUzRZ?=
 =?utf-8?B?Z25UdWp5Z0xmZkJ4dlg1am5zOW5xZ2hNbEx4cWdjMmlNSmN1TDlkY1dDV0E5?=
 =?utf-8?B?NUZYNWFlWXZSR0Zab0grd3loUzFUUklxRDZXelBJYTlLNExPV0xJQ2I2d0hR?=
 =?utf-8?B?TWlPQXZlTzlHeTlEd29SWFk0UjJ4cFZmRHd4SHExZlNObi90ZFcvQ1BPNjl3?=
 =?utf-8?B?Wk56M0lTWlcvRFBXdG9wMGdsZDB6SVZZZ2JMdE5CM0N0UXhKQy9wMk51di93?=
 =?utf-8?B?NGZKdm5zV05mU2JRZm5mRU0vWVM4bzJoNWpxZjliMEYrd1VScG9jSnN1YmdE?=
 =?utf-8?B?NW5haUUwaUxrWmtlYzZFRHhTRXlxZlBLU3ZYYVZGck9odHJpaWViVzRpbEdM?=
 =?utf-8?B?L2Q0RkgyeWhBZTNYYm1TcDluOXpuSmhiVVJ5b0N2Y2ZMVEFGaDRoT2ZsNXh6?=
 =?utf-8?B?eDdCTXpmRGQyTTg2T3RuWDQvUVdLRjlRaXd1eWo3RWR2OUg5UWtxVGkwYWdo?=
 =?utf-8?B?M0gzbGNyMHQ0dy9kTjBmMStBdko2MDFiRXZrRksvc1RMR1VxQlExRml6VFp4?=
 =?utf-8?B?WGxNbHBBUy9tLytYUlBxN2lUekN3U3Mybi85NnNtS1d5a2tFYzRoMmtrN0pn?=
 =?utf-8?B?SWZ6Q0M3c0RGeEkzOVJ1dCswaHI3UGtheHd5NFlQL3dTU1huMFlGTFpFb1BV?=
 =?utf-8?Q?uP3cWTzUex7F41Mc=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b90dfef2-add5-4e11-6f86-08da2865a9a2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 15:50:32.9943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZbtQPiGpTcWIR9g4gqNJngAV3gZU/Hn3uuqKZdDi/J5XSzmilNfgiKW5OhDQWGOMGnwgbFTgHFTgVy8tck9yA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6306

Introduce a task that uses a FreeBSD 14 (HEAD) snapshot.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 .cirrus.yml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.cirrus.yml b/.cirrus.yml
index 4ae719136e..c38333e736 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -24,3 +24,9 @@ task:
   freebsd_instance:
     image_family: freebsd-13-0
   << : *FREEBSD_TEMPLATE
+
+task:
+  name: 'FreeBSD 14'
+  freebsd_instance:
+    image_family: freebsd-14-0-snap
+  << : *FREEBSD_TEMPLATE
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:51:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:51:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315213.533662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjx1-0000FV-1b; Wed, 27 Apr 2022 15:51:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315213.533662; Wed, 27 Apr 2022 15:51:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjx0-0000FO-U1; Wed, 27 Apr 2022 15:51:34 +0000
Received: by outflank-mailman (input) for mailman id 315213;
 Wed, 27 Apr 2022 15:51:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CTGo=VF=intel.com=tamas.lengyel@srs-se1.protection.inumbo.net>)
 id 1njjwz-0007rz-Qm
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:51:33 +0000
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e8ecea52-c641-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 17:51:32 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Apr 2022 08:34:32 -0700
Received: from esimonso-mobl1.amr.corp.intel.com (HELO ubuntu.localdomain)
 ([10.212.23.42])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Apr 2022 08:34:31 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8ecea52-c641-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1651074692; x=1682610692;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=kbCPed86nvsBlhVS5WHzEURJPx5XQ+Bz2HXpoqkbpVg=;
  b=C8OpWO/D0yLDZ4ZQ+DAxRmYicSgCBvDwkA5P/ymKmuFbGa521DIIWBvB
   vnd85jFQPYrcfPur1X0S9/oznk8nkKH3W6njuIpJRcT8Om0N31CPRT6gl
   04eDJSaVj07FLzbzLCh0FptsIBxuf/HaaVf6jKogcJ8hkslbp/onhrr7k
   LH1hvEg/1RY7amH0vFPKzUuY1Rjtbt++G9gsuZWqxBkM+4HeS6j0JEdlR
   HSiRH8XU0VzsHD3HH02pK5wajziWhprv3qAxnKIjAWRyvXmcKPb6xGPT9
   X84BQEJtZygP4ACFfaZly0RSyozmVQc8imXg/dwRLFQo6r8XYhB08g+Ho
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="328915526"
X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; 
   d="scan'208";a="328915526"
X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; 
   d="scan'208";a="680854487"
From: Tamas K Lengyel <tamas.lengyel@intel.com>
To: xen-devel@lists.xenproject.org
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor
Date: Wed, 27 Apr 2022 11:34:19 -0400
Message-Id: <f3fdd4e99892549dc68e7511f2d84f51af446e86.1651073086.git.tamas.lengyel@intel.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com>
References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Need to separately specify if the reset is for the memory or for the VM state,
or both.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
---
v5: split from the hypervisor-side patch
---
 tools/include/xenctrl.h     | 3 ++-
 tools/libs/ctrl/xc_memshr.c | 7 ++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 95bd5eca67..1b089a2c02 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -2290,7 +2290,8 @@ int xc_memshr_fork(xc_interface *xch,
  *
  * With VMs that have a lot of memory this call may block for a long time.
  */
-int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain);
+int xc_memshr_fork_reset(xc_interface *xch, uint32_t forked_domain,
+                         bool reset_state, bool reset_memory);
 
 /* Debug calls: return the number of pages referencing the shared frame backing
  * the input argument. Should be one or greater.
diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c
index a6cfd7dccf..a0d0b894e2 100644
--- a/tools/libs/ctrl/xc_memshr.c
+++ b/tools/libs/ctrl/xc_memshr.c
@@ -257,12 +257,17 @@ int xc_memshr_fork(xc_interface *xch, uint32_t pdomid, uint32_t domid,
     return xc_memshr_memop(xch, domid, &mso);
 }
 
-int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid)
+int xc_memshr_fork_reset(xc_interface *xch, uint32_t domid, bool reset_state,
+                         bool reset_memory)
 {
     xen_mem_sharing_op_t mso;
 
     memset(&mso, 0, sizeof(mso));
     mso.op = XENMEM_sharing_op_fork_reset;
+    if ( reset_state )
+        mso.u.fork.flags |= XENMEM_FORK_RESET_STATE;
+    if ( reset_memory )
+        mso.u.fork.flags |= XENMEM_FORK_RESET_MEMORY;
 
     return xc_memshr_memop(xch, domid, &mso);
 }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:51:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:51:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315212.533651 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjwz-0008QU-Pz; Wed, 27 Apr 2022 15:51:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315212.533651; Wed, 27 Apr 2022 15:51:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjwz-0008QN-Mk; Wed, 27 Apr 2022 15:51:33 +0000
Received: by outflank-mailman (input) for mailman id 315212;
 Wed, 27 Apr 2022 15:51:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CTGo=VF=intel.com=tamas.lengyel@srs-se1.protection.inumbo.net>)
 id 1njjwy-0007rz-8f
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:51:32 +0000
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e6585bbd-c641-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 17:51:30 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Apr 2022 08:34:30 -0700
Received: from esimonso-mobl1.amr.corp.intel.com (HELO ubuntu.localdomain)
 ([10.212.23.42])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Apr 2022 08:34:28 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6585bbd-c641-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1651074690; x=1682610690;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=yu2lLCKrz9AND+oxXtfzZGp0tENLJ9h0P9FY5DkWhk4=;
  b=UOReKctzzFZ6jQLsHR1wFShRZnKkonFOha6THqaX2ZJK80Oogcfxt0Kv
   aA52qehMmpuPi1R5XgMyX7Exghra/G+b1tt5mulix4tkowPXbNEHPYLMZ
   utZNRmQNpslMiuaqF2m2DLe29H7hFRfmTTdiClbO2o9lqRO67hpPB4RBg
   Ho3ksn8WUFGxp9RLmtULeQw/9LFMAD8rZXTRqqJJrjyDr1ztWn6Car0FX
   JPnnoJaTvqnUywC9IxedbOQXhOmEPa1m4xmb/uRcxprTTvwvdCFYvVr36
   bsdoADOTcNrm7s78ykcygwVWXxgyZXhy1R30ZIWyKkeP+14+dvL9d15ib
   g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="328915505"
X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; 
   d="scan'208";a="328915505"
X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; 
   d="scan'208";a="680854404"
From: Tamas K Lengyel <tamas.lengyel@intel.com>
To: xen-devel@lists.xenproject.org
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>
Subject: [PATCH 1/3] x86/mem_sharing: make fork_reset more configurable
Date: Wed, 27 Apr 2022 11:34:18 -0400
Message-Id: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Alow specify distinct parts of the fork VM to be reset. This is useful when a
fuzzing operation involves mapping in only a handful of pages that are known
ahead of time. Throwing these pages away just to be re-copied immediately is
expensive, thus allowing to specify partial resets can speed things up.

Also allow resetting to be initiated from vm_event responses as an
optiomization.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com
---
v5: split toolstack part to separate patch and use ASSERT_UNREACHABLE
v4: No change
v3: Rebase on simpler approach after dropping empty_p2m feature
v2: address review comments and add more sanity checking
---
 xen/arch/x86/include/asm/mem_sharing.h |  9 +++++++++
 xen/arch/x86/mm/mem_sharing.c          | 24 +++++++++++++++++++-----
 xen/common/vm_event.c                  | 18 ++++++++++++++++++
 xen/include/public/memory.h            |  4 +++-
 xen/include/public/vm_event.h          |  8 ++++++++
 5 files changed, 57 insertions(+), 6 deletions(-)

diff --git a/xen/arch/x86/include/asm/mem_sharing.h b/xen/arch/x86/include/asm/mem_sharing.h
index cf7a12f4d2..2c00069bc9 100644
--- a/xen/arch/x86/include/asm/mem_sharing.h
+++ b/xen/arch/x86/include/asm/mem_sharing.h
@@ -85,6 +85,9 @@ static inline bool mem_sharing_is_fork(const struct domain *d)
 int mem_sharing_fork_page(struct domain *d, gfn_t gfn,
                           bool unsharing);
 
+int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                           bool reset_memory);
+
 /*
  * If called by a foreign domain, possible errors are
  *   -EBUSY -> ring full
@@ -148,6 +151,12 @@ static inline int mem_sharing_fork_page(struct domain *d, gfn_t gfn, bool lock)
     return -EOPNOTSUPP;
 }
 
+static inline int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                                         bool reset_memory)
+{
+    return -EOPNOTSUPP;
+}
+
 #endif
 
 #endif /* __MEM_SHARING_H__ */
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index a5c16b4429..1e1fb27c1a 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1881,15 +1881,21 @@ static int fork(struct domain *cd, struct domain *d)
  * footprints the hypercall continuation should be implemented (or if this
  * feature needs to be become "stable").
  */
-static int mem_sharing_fork_reset(struct domain *d)
+int mem_sharing_fork_reset(struct domain *d, bool reset_state,
+                           bool reset_memory)
 {
-    int rc;
+    int rc = 0;
     struct domain *pd = d->parent;
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     struct page_info *page, *tmp;
 
+    ASSERT(reset_state || reset_memory);
+
     domain_pause(d);
 
+    if ( !reset_memory )
+        goto state;
+
     /* need recursive lock because we will free pages */
     spin_lock_recursive(&d->page_alloc_lock);
     page_list_for_each_safe(page, tmp, &d->page_list)
@@ -1922,7 +1928,9 @@ static int mem_sharing_fork_reset(struct domain *d)
     }
     spin_unlock_recursive(&d->page_alloc_lock);
 
-    rc = copy_settings(d, pd);
+ state:
+    if ( reset_state )
+        rc = copy_settings(d, pd);
 
     domain_unpause(d);
 
@@ -2229,15 +2237,21 @@ int mem_sharing_memop(XEN_GUEST_HANDLE_PARAM(xen_mem_sharing_op_t) arg)
 
     case XENMEM_sharing_op_fork_reset:
     {
+        bool reset_state = mso.u.fork.flags & XENMEM_FORK_RESET_STATE;
+        bool reset_memory = mso.u.fork.flags & XENMEM_FORK_RESET_MEMORY;
+
         rc = -EINVAL;
-        if ( mso.u.fork.pad || mso.u.fork.flags )
+        if ( mso.u.fork.pad || (!reset_state && !reset_memory) )
+            goto out;
+        if ( mso.u.fork.flags &
+             ~(XENMEM_FORK_RESET_STATE | XENMEM_FORK_RESET_MEMORY) )
             goto out;
 
         rc = -ENOSYS;
         if ( !d->parent )
             goto out;
 
-        rc = mem_sharing_fork_reset(d);
+        rc = mem_sharing_fork_reset(d, reset_state, reset_memory);
         break;
     }
 
diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
index 84cf52636b..cc7d8bf565 100644
--- a/xen/common/vm_event.c
+++ b/xen/common/vm_event.c
@@ -28,6 +28,11 @@
 #include <asm/p2m.h>
 #include <asm/monitor.h>
 #include <asm/vm_event.h>
+
+#ifdef CONFIG_MEM_SHARING
+#include <asm/mem_sharing.h>
+#endif
+
 #include <xsm/xsm.h>
 #include <public/hvm/params.h>
 
@@ -394,6 +399,19 @@ static int vm_event_resume(struct domain *d, struct vm_event_domain *ved)
             if ( rsp.reason == VM_EVENT_REASON_MEM_PAGING )
                 p2m_mem_paging_resume(d, &rsp);
 #endif
+#ifdef CONFIG_MEM_SHARING
+            if ( mem_sharing_is_fork(d) )
+            {
+                bool reset_state = rsp.flags & VM_EVENT_FLAG_RESET_FORK_STATE;
+                bool reset_mem = rsp.flags & VM_EVENT_FLAG_RESET_FORK_MEMORY;
+
+                if ( (reset_state || reset_mem) &&
+                    mem_sharing_fork_reset(d, reset_state, reset_mem) )
+                {
+                    ASSERT_UNREACHABLE();
+                }
+            }
+#endif
 
             /*
              * Check emulation flags in the arch-specific handler only, as it
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index a1a0f0233a..f8d26fb77d 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -541,12 +541,14 @@ struct xen_mem_sharing_op {
                 uint32_t gref;     /* IN: gref to debug         */
             } u;
         } debug;
-        struct mem_sharing_op_fork {      /* OP_FORK */
+        struct mem_sharing_op_fork {      /* OP_FORK{,_RESET} */
             domid_t parent_domain;        /* IN: parent's domain id */
 /* Only makes sense for short-lived forks */
 #define XENMEM_FORK_WITH_IOMMU_ALLOWED (1u << 0)
 /* Only makes sense for short-lived forks */
 #define XENMEM_FORK_BLOCK_INTERRUPTS   (1u << 1)
+#define XENMEM_FORK_RESET_STATE        (1u << 2)
+#define XENMEM_FORK_RESET_MEMORY       (1u << 3)
             uint16_t flags;               /* IN: optional settings */
             uint32_t pad;                 /* Must be set to 0 */
         } fork;
diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
index bb003d21d0..1673bb8703 100644
--- a/xen/include/public/vm_event.h
+++ b/xen/include/public/vm_event.h
@@ -127,6 +127,14 @@
  * Reset the vmtrace buffer (if vmtrace is enabled)
  */
 #define VM_EVENT_FLAG_RESET_VMTRACE      (1 << 13)
+/*
+ * Reset the VM state (if VM is fork)
+ */
+#define VM_EVENT_FLAG_RESET_FORK_STATE   (1 << 14)
+/*
+ * Remove unshared entries from physmap (if VM is fork)
+ */
+#define VM_EVENT_FLAG_RESET_FORK_MEMORY  (1 << 15)
 
 /*
  * Reasons for the vm event request
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 15:51:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 15:51:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315214.533673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjx3-0000Xo-Ax; Wed, 27 Apr 2022 15:51:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315214.533673; Wed, 27 Apr 2022 15:51:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njjx3-0000Xb-6V; Wed, 27 Apr 2022 15:51:37 +0000
Received: by outflank-mailman (input) for mailman id 315214;
 Wed, 27 Apr 2022 15:51:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CTGo=VF=intel.com=tamas.lengyel@srs-se1.protection.inumbo.net>)
 id 1njjx1-0007rz-EW
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 15:51:35 +0000
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9a0b098-c641-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 17:51:34 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Apr 2022 08:34:35 -0700
Received: from esimonso-mobl1.amr.corp.intel.com (HELO ubuntu.localdomain)
 ([10.212.23.42])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Apr 2022 08:34:32 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9a0b098-c641-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1651074694; x=1682610694;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=9QOZkEq66mA2UNTUZObc+xS271mkkoHO67ux88g75ZU=;
  b=Vp5WoSznnl0zAFUSdUKedzAECMIKygk4icmG1bmcKVbqCgVgZWQIqT5p
   uRqAUqFGEzquZyRvolRCj05inFSPnSYsVxHVXLagulLaOYiuUvc+aUJ2Y
   T3wzITLAq1Hn7AJ8NFmvdjaDQ6bhGwKy26f8El5aTlVgNpeXL+rKB1XNo
   zHHqdAjV2XqClzQ8CjQ6XUj03P6s0QmXuIbZ2DBwKvxOvub4i8JLjT1/t
   IQiyRXYvBEz2v8Y6oUNe5Epljk84hokOSdfG6A7vo13F/6HI1FQ4ePDT1
   /Cd0l0slUsjpbJa+Ww72wS5vT63tw8WtMBeAZgaFc5VjvsS9Vg5/sEWN2
   w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="328915546"
X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; 
   d="scan'208";a="328915546"
X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; 
   d="scan'208";a="680854546"
From: Tamas K Lengyel <tamas.lengyel@intel.com>
To: xen-devel@lists.xenproject.org
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits
Date: Wed, 27 Apr 2022 11:34:20 -0400
Message-Id: <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com>
References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add monitor event that hooks the vmexit handler allowing for both sync and
async monitoring of events. With async monitoring an event is placed on the
monitor ring for each exit and the rest of the vmexit handler resumes normally.
If there are additional monitor events configured those will also place their
respective events on the monitor ring.

With the sync version an event is placed on the monitor ring but the handler
does not get resumed, thus the sync version is only useful when the VM is not
expected to resume normally after the vmexit. Our use-case is primarily with
the sync version with VM forks where the fork gets reset after sync vmexit
event, thus the rest of the vmexit handler can be safely skipped. This is
very useful when we want to avoid Xen crashing the VM under any circumstance,
for example during fuzzing. Collecting all vmexit information regardless of
the root cause makes it easier to reason about the state of the VM on the
monitor side, hence we opt to receive all events, even for external interrupt
and NMI exits and let the monitor agent decide how to proceed.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
---
v5: wrap vmexit fields in arch.vmx structures in the public vm_event ABI
---
 tools/include/xenctrl.h                |  2 ++
 tools/libs/ctrl/xc_monitor.c           | 15 +++++++++++++++
 xen/arch/x86/hvm/monitor.c             | 18 ++++++++++++++++++
 xen/arch/x86/hvm/vmx/vmx.c             | 12 ++++++++++++
 xen/arch/x86/include/asm/domain.h      |  2 ++
 xen/arch/x86/include/asm/hvm/monitor.h |  2 ++
 xen/arch/x86/include/asm/monitor.h     |  3 ++-
 xen/arch/x86/monitor.c                 | 14 ++++++++++++++
 xen/include/public/domctl.h            |  6 ++++++
 xen/include/public/vm_event.h          | 12 ++++++++++++
 10 files changed, 85 insertions(+), 1 deletion(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 1b089a2c02..159eaac050 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -2096,6 +2096,8 @@ int xc_monitor_privileged_call(xc_interface *xch, uint32_t domain_id,
                                bool enable);
 int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
                                   bool enable);
+int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
+                      bool sync);
 /**
  * This function enables / disables emulation for each REP for a
  * REP-compatible instruction.
diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.c
index 4ac823e775..c5fa62ff30 100644
--- a/tools/libs/ctrl/xc_monitor.c
+++ b/tools/libs/ctrl/xc_monitor.c
@@ -246,6 +246,21 @@ int xc_monitor_emul_unimplemented(xc_interface *xch, uint32_t domain_id,
     return do_domctl(xch, &domctl);
 }
 
+int xc_monitor_vmexit(xc_interface *xch, uint32_t domain_id, bool enable,
+                      bool sync)
+{
+    DECLARE_DOMCTL;
+
+    domctl.cmd = XEN_DOMCTL_monitor_op;
+    domctl.domain = domain_id;
+    domctl.u.monitor_op.op = enable ? XEN_DOMCTL_MONITOR_OP_ENABLE
+                                    : XEN_DOMCTL_MONITOR_OP_DISABLE;
+    domctl.u.monitor_op.event = XEN_DOMCTL_MONITOR_EVENT_VMEXIT;
+    domctl.u.monitor_op.u.vmexit.sync = sync;
+
+    return do_domctl(xch, &domctl);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
index b44a1e1dfe..a11cd76f4d 100644
--- a/xen/arch/x86/hvm/monitor.c
+++ b/xen/arch/x86/hvm/monitor.c
@@ -328,6 +328,24 @@ bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
     return monitor_traps(curr, true, &req) >= 0;
 }
 
+int hvm_monitor_vmexit(unsigned long exit_reason,
+                       unsigned long exit_qualification)
+{
+    struct vcpu *curr = current;
+    struct arch_domain *ad = &curr->domain->arch;
+    vm_event_request_t req = {};
+
+    ASSERT(ad->monitor.vmexit_enabled);
+
+    req.reason = VM_EVENT_REASON_VMEXIT;
+    req.u.vmexit.arch.vmx.reason = exit_reason;
+    req.u.vmexit.arch.vmx.qualification = exit_qualification;
+
+    set_npt_base(curr, &req);
+
+    return monitor_traps(curr, ad->monitor.vmexit_sync, &req);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index cc8c4e9f04..4320270aae 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -4008,6 +4008,18 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
         }
     }
 
+    if ( unlikely(currd->arch.monitor.vmexit_enabled) )
+    {
+        int rc;
+
+        __vmread(EXIT_QUALIFICATION, &exit_qualification);
+        rc = hvm_monitor_vmexit(exit_reason, exit_qualification);
+        if ( rc < 0 )
+            goto exit_and_crash;
+        if ( rc )
+            return;
+    }
+
     /* XXX: This looks ugly, but we need a mechanism to ensure
      * any pending vmresume has really happened
      */
diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
index 35898d725f..3aa0919fa6 100644
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -430,6 +430,8 @@ struct arch_domain
          */
         unsigned int inguest_pagefault_disabled                            : 1;
         unsigned int control_register_values                               : 1;
+        unsigned int vmexit_enabled                                        : 1;
+        unsigned int vmexit_sync                                           : 1;
         struct monitor_msr_bitmap *msr_bitmap;
         uint64_t write_ctrlreg_mask[4];
     } monitor;
diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h
index a75cd8545c..639f6dfa37 100644
--- a/xen/arch/x86/include/asm/hvm/monitor.h
+++ b/xen/arch/x86/include/asm/hvm/monitor.h
@@ -51,6 +51,8 @@ bool hvm_monitor_emul_unimplemented(void);
 
 bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
                            uint16_t kind);
+int hvm_monitor_vmexit(unsigned long exit_reason,
+                       unsigned long exit_qualification);
 
 #endif /* __ASM_X86_HVM_MONITOR_H__ */
 
diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/asm/monitor.h
index 01c6d63bb9..d8d54c5f23 100644
--- a/xen/arch/x86/include/asm/monitor.h
+++ b/xen/arch/x86/include/asm/monitor.h
@@ -89,7 +89,8 @@ static inline uint32_t arch_monitor_get_capabilities(struct domain *d)
                     (1U << XEN_DOMCTL_MONITOR_EVENT_DEBUG_EXCEPTION) |
                     (1U << XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG) |
                     (1U << XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED) |
-                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT));
+                    (1U << XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT) |
+                    (1U << XEN_DOMCTL_MONITOR_EVENT_VMEXIT));
 
     if ( hvm_is_singlestep_supported() )
         capabilities |= (1U << XEN_DOMCTL_MONITOR_EVENT_SINGLESTEP);
diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
index 3079726a8b..30ca71432c 100644
--- a/xen/arch/x86/monitor.c
+++ b/xen/arch/x86/monitor.c
@@ -332,6 +332,20 @@ int arch_monitor_domctl_event(struct domain *d,
         break;
     }
 
+    case XEN_DOMCTL_MONITOR_EVENT_VMEXIT:
+    {
+        bool old_status = ad->monitor.vmexit_enabled;
+
+        if ( unlikely(old_status == requested_status) )
+            return -EEXIST;
+
+        domain_pause(d);
+        ad->monitor.vmexit_enabled = requested_status;
+        ad->monitor.vmexit_sync = mop->u.vmexit.sync;
+        domain_unpause(d);
+        break;
+    }
+
     default:
         /*
          * Should not be reached unless arch_monitor_get_capabilities() is
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0..4803ed7afc 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -1057,6 +1057,7 @@ struct xen_domctl_psr_cmt_op {
 #define XEN_DOMCTL_MONITOR_EVENT_EMUL_UNIMPLEMENTED    10
 /* Enabled by default */
 #define XEN_DOMCTL_MONITOR_EVENT_INGUEST_PAGEFAULT     11
+#define XEN_DOMCTL_MONITOR_EVENT_VMEXIT                12
 
 struct xen_domctl_monitor_op {
     uint32_t op; /* XEN_DOMCTL_MONITOR_OP_* */
@@ -1107,6 +1108,11 @@ struct xen_domctl_monitor_op {
             /* Pause vCPU until response */
             uint8_t sync;
         } debug_exception;
+
+        struct {
+            /* Send event and don't process vmexit */
+            uint8_t sync;
+        } vmexit;
     } u;
 };
 
diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
index 1673bb8703..56b429a975 100644
--- a/xen/include/public/vm_event.h
+++ b/xen/include/public/vm_event.h
@@ -175,6 +175,8 @@
 #define VM_EVENT_REASON_DESCRIPTOR_ACCESS       13
 /* Current instruction is not implemented by the emulator */
 #define VM_EVENT_REASON_EMUL_UNIMPLEMENTED      14
+/* VMEXIT */
+#define VM_EVENT_REASON_VMEXIT                  15
 
 /* Supported values for the vm_event_write_ctrlreg index. */
 #define VM_EVENT_X86_CR0    0
@@ -394,6 +396,15 @@ struct vm_event_emul_insn_data {
     uint8_t data[16]; /* Has to be completely filled */
 };
 
+struct vm_event_vmexit {
+    struct {
+        struct {
+            uint64_t reason;
+            uint64_t qualification;
+        } vmx;
+    } arch;
+};
+
 typedef struct vm_event_st {
     uint32_t version;   /* VM_EVENT_INTERFACE_VERSION */
     uint32_t flags;     /* VM_EVENT_FLAG_* */
@@ -414,6 +425,7 @@ typedef struct vm_event_st {
         struct vm_event_debug                 software_breakpoint;
         struct vm_event_debug                 debug_exception;
         struct vm_event_cpuid                 cpuid;
+        struct vm_event_vmexit                vmexit;
         union {
             struct vm_event_interrupt_x86     x86;
         } interrupt;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:02:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:02:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315232.533684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njk7a-0003Jw-HM; Wed, 27 Apr 2022 16:02:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315232.533684; Wed, 27 Apr 2022 16:02:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njk7a-0003Jp-ED; Wed, 27 Apr 2022 16:02:30 +0000
Received: by outflank-mailman (input) for mailman id 315232;
 Wed, 27 Apr 2022 16:02:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njk7Y-0003JN-RK; Wed, 27 Apr 2022 16:02:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njk7Y-0001Rw-Pr; Wed, 27 Apr 2022 16:02:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njk7Y-0007JY-8r; Wed, 27 Apr 2022 16:02:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njk7Y-0001oI-6P; Wed, 27 Apr 2022 16:02:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3VP31MdEKDZhVUVjSnoK48c8kmaZArVMIZGWH4x7UqE=; b=ouj3QHEN2ASS0q72XpclATpIGo
	Od+/KUirAya7FLPnouho+mAp7FoTL2ZJDiCs5JeWr4TETfBuemPpInXC7cZYdqzjoJTB88WWgop9L
	LunkywlcjYMEb4WkXiKmbI91HfLbWDwGtNIeinJyx8evc5QPU8GBwVydXlHsjxuFUIrw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169784-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169784: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 16:02:28 +0000

flight 169784 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169784/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  663 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   35 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:03:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:03:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315236.533694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njk84-0003if-Qp; Wed, 27 Apr 2022 16:03:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315236.533694; Wed, 27 Apr 2022 16:03:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njk84-0003iY-O1; Wed, 27 Apr 2022 16:03:00 +0000
Received: by outflank-mailman (input) for mailman id 315236;
 Wed, 27 Apr 2022 16:02:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njk83-0003iG-Hv
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 16:02:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njk83-0001SL-55; Wed, 27 Apr 2022 16:02:59 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njk82-0007yr-Up; Wed, 27 Apr 2022 16:02:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=8oNkFj8jmw3Du7ovep81MmJhJqcTmyaj2BQnahSLOS8=; b=aaPpi8RkFE9SjUuoqJest/sNiz
	o2CP559sIk/jR2HZE5j+CJjJzEujvjvQj86kGX3EDO3Bfe/DCNzRpahLBnnldz+bhXg8mf7OcwDe6
	GY5cEjtRmiHaV1tOHTXDuP47/8zx1VgRZYcB6nhitkmtsPseCBcKmW5joXjM2VzPFjsM=;
Message-ID: <8dda4ad4-2211-1205-1933-8353f6649593@xen.org>
Date: Wed, 27 Apr 2022 17:02:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [RFC PATCH] xen/arm: p2m don't fall over on FEAT_LPA enabled hw
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
 xen-devel@lists.xenproject.org
Cc: stratos-dev@op-lists.linaro.org,
 Richard Henderson <richard.henderson@linaro.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220426160548.2020794-1-alex.bennee@linaro.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220426160548.2020794-1-alex.bennee@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Alex,

On 26/04/2022 17:05, Alex Bennée wrote:
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index fb71fa4c1c..e5a88095f8 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -2030,7 +2030,7 @@ void __init setup_virt_paging(void)
>           unsigned int root_order; /* Page order of the root of the p2m */
>           unsigned int sl0;    /* Desired SL0, maximum in comment */
>       } pa_range_info[] = {
> -        /* T0SZ minimum and SL0 maximum from ARM DDI 0487A.b Table D4-5 */
> +        /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */
>           /*      PA size, t0sz(min), root-order, sl0(max) */
>           [0] = { 32,      32/*32*/,  0,          1 },
>           [1] = { 36,      28/*28*/,  0,          1 },
> @@ -2038,7 +2038,7 @@ void __init setup_virt_paging(void)
>           [3] = { 42,      22/*22*/,  3,          1 },
>           [4] = { 44,      20/*20*/,  0,          2 },
>           [5] = { 48,      16/*16*/,  0,          2 },
> -        [6] = { 0 }, /* Invalid */
> +        [6] = { 52,      12/*12*/,  3,          3 },
>           [7] = { 0 }  /* Invalid */
>       };
>   
> @@ -2069,10 +2069,13 @@ void __init setup_virt_paging(void)
>           }
>       }
>   
> -    /* pa_range is 4 bits, but the defined encodings are only 3 bits */
> +    /* pa_range is 4 bits but we don't support all modes */
>       if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits )
>           panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", pa_range);
>   
> +    if ( pa_range > 5 )
> +        pa_range = 5;

I think it would be better to restrict the p2m_ipa_bits rather than the 
PA range. This can be done by initializing p2m_ipa_bits to PADDR_BITS (48).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:12:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:12:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315247.533706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkHG-0005ND-OH; Wed, 27 Apr 2022 16:12:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315247.533706; Wed, 27 Apr 2022 16:12:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkHG-0005N6-Kg; Wed, 27 Apr 2022 16:12:30 +0000
Received: by outflank-mailman (input) for mailman id 315247;
 Wed, 27 Apr 2022 16:12:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ll0K=VF=citrix.com=prvs=1097e264f=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njkHE-0005N0-Fu
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 16:12:28 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3036eec-c644-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 18:12:25 +0200 (CEST)
Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 12:12:23 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by MN2PR03MB4877.namprd03.prod.outlook.com (2603:10b6:208:aa::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 16:12:20 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 16:12:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3036eec-c644-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651075945;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=WgHBk5p+i9oC83s4p7hQ802LRS7nlB1pNsAlFsPx0RU=;
  b=BBi78MLHtUwLVc9oTHFH2nnBMVYq5Qyr0Pk0apnq0VLRcSS8IQ0Pi1ku
   NSEvHl+F96MkvaamjwX/rTMDZs+YRX31Rm9T8jHFd+Iv2FXjFrsH6eCSo
   eWVIxyWU6qw0AAJdXTzS1yaQBueY3Lb+nz/OFlfSrXMiY3aKKslVB4A0P
   c=;
X-IronPort-RemoteIP: 104.47.55.170
X-IronPort-MID: 72516553
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:e8tZZ6z46gyQ3XP2wdV6t+dDxyrEfRIJ4+MujC+fZmUNrF6WrkUPy
 mYeUD2CPf/ZYmfxKdsnbd7iph4OusTQx9M2QVM9riAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024fhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplmpO9RV8tOav3tstFdQJ4AgB6HPBJ5+qSSZS/mZT7I0zuVVLJmq8rJmdmeIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHuOTuocwMDQY36iiGd7EY
 MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKWAB9g/I/sLb5UDa0QMs24nMMOaPJMSwHsx5g2GAi
 VjZqjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDZsb5dw21pjiDpBF0ZjZLO+gz6QXIwKyE5Q+cXzIAVmQYN4Rgs9IqTzs30
 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZowL/HKd5jEtJQzN/
 g==
IronPort-HdrOrdr: A9a23:BFl2eK62Kj+61SSCRwPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN
 MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt
 gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd
 L6IRlliVI=
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="72516553"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bllBvTTBuG3ZHxm58i3JHUNTEugU/tZCwgBbJh/+mfO1jKjX80L0+QKqZImktOmXJxcajoIg/+98fCnHsns3Z+CTUMXpN9R82N8QU3fvsKPnw2TAZ4nDgg9OIatfL51iFxKxPjzCk2t+tTVsDRAnAb1rRpYQdNBMGKvbkbJ5qgqVrcLWrMQe3UkGOw0YaBpuYiIt/4W2aymdR6/zJxHH6rnszt52SJFLCh2Nn9Nbn/8b9J58OYe/GNVVNWPo/x7fgTmKqA9JpYXR0FePB1HhSDOjfsVh6U6Ox/8J2UCrcO4CmBhPMji9npmr/WJZtCaPBRzQFEEn0ZGle+MNr9AsWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FGoMGBVNu9dwfwIntFNzK41kXcpk2VmnGfHIW7epseU=;
 b=Zd1g46nETYVAQauZ9ajUkFBxFIw2WxQanmPvHeQiGiMyi5uLV507jsDH0FRFeERziyKjY0uOnLtEgCJwBNQruLLcMKAs+6S6OQ7rqysoiLrt0DtVLvZyDs3M1RIUW+myPtTPGPUrbVu64teaY+nN4bVOJhU/NtHMeP0fI/0viGpnqJOgUlyVGA/db1svrZfX1iwgAOqk6cPYo9M4ValiFatmyvjFg7Id1bdVIByQOFgJVl0r3Bh6cdaRIKsNV3cuVbPCyhrq6cqV9Dd8wbh6KwEJ2OUyRkoxCU9SugxyadC03sXhW/mt5E5LEBI+D+SJHpDQeqimZPA4S3EAIdeWPQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FGoMGBVNu9dwfwIntFNzK41kXcpk2VmnGfHIW7epseU=;
 b=tm5ZukSHiMmMHL+d9vRyH7ZhHytdG5uwBu9BApc9sGB72c3CH0J7ThoLQqQMlAvtpr7vApIHfgaPfrMGZGvJh1IDdF+mORGgZhdJ8zaowrybigZLbr055jxlaIpyKXZ8+FkdUQ1Z0DlrMlzUAp5uoXMmVO183/GCbTVagPzhK5E=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 27 Apr 2022 18:12:16 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Message-ID: <YmlrYNFI75wQlVlg@Air-de-Roger>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
 <Ymk7BjXdyiMUGoc8@Air-de-Roger>
 <47b50c64-b8bd-df95-9de9-175780c50e0b@suse.com>
 <Ymlb2Wly25k9bF0z@Air-de-Roger>
 <d9e797eb-5075-2c95-cfa9-959586577f98@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d9e797eb-5075-2c95-cfa9-959586577f98@suse.com>
X-ClientProxiedBy: LO2P265CA0051.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:60::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e66754ba-1713-4014-7872-08da2868b505
X-MS-TrafficTypeDiagnostic: MN2PR03MB4877:EE_
X-Microsoft-Antispam-PRVS:
	<MN2PR03MB4877336B9E6272491F71EBAD8FFA9@MN2PR03MB4877.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c4v9HAwAdKeGG53A8kHCNRIHHesvzsdgt59fzSrV2vS2GpvKK8omtySTAyIwQNNJI9ZU2ClN5e/E4TZ3OpTq6wfeUqRJLU93SZToZlPuvueHgCPaUsqECLuncLNCImL9Ulo9cXkAH2oWkgPcxTfNZCj8P4Ink5Nb4qAb2aexqbrTLUFgPn+j24o9jjENppRVH264VD9V30zVlX4sPiLz/qwehypcg5S4S2c/33FXz6Pky3l0fFremZMdHMnYRgjPz1QWhALl1cibBivpYN0BqHCArNeTYy5f0/L0Fo0IM0gJFx3dCZqpSN+J9QGngrN7rhZ7IXEO5EJOIr6Gx7pK4J4cU15McFMPRf4jtPzhSXsxfKjZ/7oe4G8W3zErY3HC3Wjvm15vUHj/YgsCWytZJI8tb1NKNKIvpyKGUPPatnSBaSm3GfzCBJqKrLZ1kCo4S+Plr2iPUHUwVn/wGikIDcSBOAKYyO6okbeUDP872w/LH1mehq1Xacq5d61uUctDddqBTNXGuyVN3fjV6AlwJ4wdqJlDsd8VZ55MvqQEWKCdMPoVoMmFV24MNYe9vdDt5B1GMFhvPndyiMotxNolc99sVwnBtKezXm/yOr3Fs71DscYpEUemEckUX0KbLiJ5HvjGDjN3oKDvcy6fKgpTmKITpGDS+V2MYa9AQEce5PqurxRPh4Y8OzT+qY2xpH8on3h0waCcOIsHhFn4v/Ye3ob9Yu6B9GnKXmiUClsKumo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(33716001)(66946007)(5660300002)(2906002)(53546011)(6916009)(316002)(6486002)(82960400001)(508600001)(8676002)(83380400001)(54906003)(86362001)(84970400001)(85182001)(26005)(6512007)(6506007)(9686003)(6666004)(8936002)(66476007)(4326008)(66556008)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eEx0MXpFY1FHMUhJUkdqNzA3WFh1U1hRT2JpcWFqTG9HWWZSb3RIa0tWRmxi?=
 =?utf-8?B?dE1NOGx4MUoweUZuRWdTeGZXK1JZU1pxYUJsdzJrZ3kxS0tTTXM4UG5LSTVw?=
 =?utf-8?B?MzlOK0M4R0I2WlR5QTVsVHZic0g3RFNFYXEyWDBTVmZiZnNnYmlQMmlwSk56?=
 =?utf-8?B?MCtKN21QZnBsWVo4eVQ5b0NSL1ZwTmdIbUp0cVZ6S210VmlmVlUzK2xWWjg0?=
 =?utf-8?B?czRwamZNNDJMbFNsV2d6cG9qdUlDaWZvMmlMcUIzeWhYRk93djZoc0ZLd056?=
 =?utf-8?B?QUo0NW5ZNDlrOXhTSDZza0tYT01qS085UDg0OFBhRE9jQzNaMFFkZWRLektp?=
 =?utf-8?B?eG92dlpjNUZyVithdEZCc1dicWFhSXJqQWZxSmp3dFBubVdEbFA4UW1qU1RV?=
 =?utf-8?B?a2JaVnZ5VjNlWm0yRHBvU3o3UXZsbFZXSmdWRkpZYkZlL3UyK015SmZvcTJ2?=
 =?utf-8?B?dVZBSXlRV0tycHhtQklWNkhMMTlrcnl6ekN4M1RZSW9jbHlreHg4UllLSU1l?=
 =?utf-8?B?S0R2dHZ5V0NRYnpvbEYzRi9uR3l1bk8zYjFFMXBtMTUrUUY4UWFzRmZUZ0F4?=
 =?utf-8?B?ankyaE95MHlDK3MyZ3lkaS82TmIwT1BreUZ0N0NSQUZVa1l0dFNUUTczTml0?=
 =?utf-8?B?cUNScHVZYnZlNDlrdlV6ZTNOS2g3M01rZUxaSDVHbmJwdEI5dm05TGg2cTk3?=
 =?utf-8?B?b1EyZHpyRWkvWjlWcEtLbitZL1RqYjlidFpWK2ViTkdmbkVkQXBtbEs2UC9u?=
 =?utf-8?B?eldRQkhFLytZeXUwWThJMmhyREZFZWlqK2Ficit2Y1V3YTZSZThmNVJjOFZQ?=
 =?utf-8?B?OWxhRTg4ekR6SGcwUkhkUDgycUVkdUIzUXFWb1BaNHJ0RXkrNUQ1TGMvVGoy?=
 =?utf-8?B?ektSSWdUbCt5QkozdTBmbmY2U2ErcHVkVjI5OU9VR0V0UWI3RXp6WDhDVnBW?=
 =?utf-8?B?NS9aY1pXMllQdTVPeFNkMWE5RkpTNnRzSXp4ZnpsQWNEWVZXTWp0SHJId1J5?=
 =?utf-8?B?VzYzYldld3B3dW0wb2VhTE9FOTRJN2w1Qi9yWTZHNTduR1RQR2pPOXM2aFZ6?=
 =?utf-8?B?b1dOU3A1Sm5ndnlETVI5ZExLQ0dsa0lscUZDbEw2cWpLU3IzaTBsVjNTMDd6?=
 =?utf-8?B?amdVVG9jaXptRk9RVG5lekQ5LzVCTTNXVmp2dS82eHVybWxhTzR1MlJiSkEv?=
 =?utf-8?B?WG1uVlVzRTBWSThqOTBSSXNPdnVyRitvTytZSE43L1lWcEpmZVk3NWNnVlN1?=
 =?utf-8?B?RlJpaEg2RnZPK2N6OVdDSXFjbW1XV2d3T3IyS3cyTmt0ZmI3M3hBSVpLR1ly?=
 =?utf-8?B?ZkJZSjVYOVo4cEE5eWpJdHZTM1JiRXBLQjAzY05aTlRPREdiRzhrRjdaTVlH?=
 =?utf-8?B?cUFsdVZDNkxMd0lFd21aaHA3dlc5S2pjRjhIZi96djZpbkZYdWRYdGhiL2d0?=
 =?utf-8?B?RVdBNFgwdVBsNmZGcWNkWmtQMFpRbHlFN1lRSlB2bnRYZ04vNDBpeFhoVS94?=
 =?utf-8?B?RGlSVEs4VTdVQWVzMForZFhQdTNUM2FzZmVhNkpVK0ErcGE2U2ZWOUd3WXpW?=
 =?utf-8?B?ZSs2dWp3QWJHUk5QWFIramRPcXpWZFUwZkV6WVUyQ3UramR3TlB5RCtuV2Uw?=
 =?utf-8?B?TjEvN0VqQWhPS3hyRVc5aWtGbTFSNWM0bEhIdWdRSkQ3Z3p6NW9XK2VnVFA4?=
 =?utf-8?B?WmtKbkE1ckNpczVnQkkwT0VyU3piejI0a3hEdHhQN0Y0QTFiVGlWVHJva1ZR?=
 =?utf-8?B?b3I0YUNpb05kNy9yT0ppYStHcEZvSUhkT1NkbWhoWGpNSVJ6aXJ1UmdXdWJC?=
 =?utf-8?B?dXJ4d3prdFFucGI2TlNCckJVWUZ2SlNIdVlGenpoaU1UU1hKYS83RnlqMnBI?=
 =?utf-8?B?UVVhTzdBRG9DZnU4bXRRQzJIYXZIdWlReDd4dzd0TTdGc0N5M2dLK1o1cE9N?=
 =?utf-8?B?S2JKMFUzSGI2S0M1YlJCVzBkbnZjK2QxM3FJdmVWd1ZiUnJmR3NBVzB5UW5a?=
 =?utf-8?B?SFc4bkNnZml1Wm5FQmUzUXhUTjJ3bm1ncitQWGg2YVJ0WGFuWHYzQlFBU0s3?=
 =?utf-8?B?Sm9UNXhTY2QrSERHNGRuTnh4Szc0NExvYnBTekM0c29xYXdvYlA5N1BIYUFt?=
 =?utf-8?B?bGZXSlBUYlBsRHhUME4wN0RIQ0J5cjBpN3U1ck5objl6QU1KdlFaZURmT2Iw?=
 =?utf-8?B?WXJHU0V6Tmx4Y21mc1NadFJuaTNvdm9QR081dHV3ZGFRcTRGSFlJMDkzOTdG?=
 =?utf-8?B?a3RXNm1YQnFXckxYMVVQRXEyZGt3MWxxdkZVV2J3YmduMHhHYUlIWVRnbXBz?=
 =?utf-8?B?WVFXUW1WWkMxSWNPSXdRQzJFclV6RDltSDE3eVVqamZQeVJycUwxUFpiY0Y2?=
 =?utf-8?Q?6VaoURtji2XgmMzw=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e66754ba-1713-4014-7872-08da2868b505
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 16:12:20.6653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wUZzrb/1p174fsD8t06STEEY4vbSkBAust4qBqT+fxOPBNBOA56WukGV1JAeza3Pps1D8P6grUFu+3Dmpfw+0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4877

On Wed, Apr 27, 2022 at 05:25:35PM +0200, Jan Beulich wrote:
> On 27.04.2022 17:06, Roger Pau Monné wrote:
> > On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote:
> >> On 27.04.2022 14:45, Roger Pau Monné wrote:
> >>> On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote:
> >>>> --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c
> >>>> +++ unstable/xen/arch/x86/cpu/mwait-idle.c
> >>>> @@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
> >>>>  
> >>>>  static unsigned int mwait_substates;
> >>>>  
> >>>> +/*
> >>>> + * Some platforms come with mutually exclusive C-states, so that if one is
> >>>> + * enabled, the other C-states must not be used. Example: C1 and C1E on
> >>>> + * Sapphire Rapids platform. This parameter allows for selecting the
> >>>> + * preferred C-states among the groups of mutually exclusive C-states - the
> >>>> + * selected C-states will be registered, the other C-states from the mutually
> >>>> + * exclusive group won't be registered. If the platform has no mutually
> >>>> + * exclusive C-states, this parameter has no effect.
> >>>> + */
> >>>> +static unsigned int __ro_after_init preferred_states_mask;
> >>>> +integer_param("preferred-cstates", preferred_states_mask);
> >>>> +
> >>>>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
> >>>>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1. */
> >>>>  static unsigned int lapic_timer_reliable_states = (1 << 1);
> >>>> @@ -96,6 +108,7 @@ struct idle_cpu {
> >>>>  	unsigned long auto_demotion_disable_flags;
> >>>>  	bool byt_auto_demotion_disable_flag;
> >>>>  	bool disable_promotion_to_c1e;
> >>>> +	bool enable_promotion_to_c1e;
> >>>
> >>> I'm confused by those fields, shouldn't we just have:
> >>> promotion_to_c1e = true | false?
> >>>
> >>> As one field is the negation of the other:
> >>> enable_promotion_to_c1e = !disable_promotion_to_c1e
> >>>
> >>> I know this is code from Linux, but would like to understand why two
> >>> fields are needed.
> >>
> >> This really is a tristate; Linux is now changing their global variable
> >> to an enum, but we don't have an equivalent of that global variable.
> > 
> > So it would be: leave default, disable C1E promotion, enable C1E
> > promotion.
> > 
> > And Linux is leaving the {disable,enable}_promotion_to_c1e in
> > idle_cpu?
> 
> Iirc they only have disable_promotion_to_c1e there (as a struct field)
> and keep it, but they convert the similarly named file-scope variable
> to a tristate.
> 
> > I guess there's not much we can do unless we want to diverge from
> > upstream.
> 
> We've diverged some from Linux here already - as said, for example we
> don't have their file-scope variable. I could convert our struct field
> to an enum, but that would be larger code churn for (I think) little
> gain.

Hm, OK, could gaining the file scope variable would make sense in order
to reduce divergences?  Or are the other roadblocks there?

I think this is ugly, but would make sense as long as it allows us to
keep closer to upstream.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:12:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:12:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315249.533717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkHd-0005jV-1S; Wed, 27 Apr 2022 16:12:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315249.533717; Wed, 27 Apr 2022 16:12:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkHc-0005jO-Tu; Wed, 27 Apr 2022 16:12:52 +0000
Received: by outflank-mailman (input) for mailman id 315249;
 Wed, 27 Apr 2022 16:12:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sRcl=VF=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1njkHb-0005N0-MW
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 16:12:51 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id e25d7fd9-c644-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 18:12:50 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79962ED1;
 Wed, 27 Apr 2022 09:12:49 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9072D3F5A1;
 Wed, 27 Apr 2022 09:12:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e25d7fd9-c644-11ec-a405-831a346695d4
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] arm/acpi: don't expose the ACPI IORT SMMUv3 entry to dom0
Date: Wed, 27 Apr 2022 17:12:33 +0100
Message-Id: <e11c57909782c60a6914d81e9c9893ff1712cc5b.1651075724.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Xen should control the SMMUv3 devices therefore, don't expose the
SMMUv3 devices to dom0. Deny iomem access to SMMUv3 address space for
dom0 and also make ACPI IORT SMMUv3 node type to 0xff.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
 xen/arch/arm/acpi/domain_build.c | 40 ++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c
index bbdc90f92c..ec0b5b261f 100644
--- a/xen/arch/arm/acpi/domain_build.c
+++ b/xen/arch/arm/acpi/domain_build.c
@@ -14,6 +14,7 @@
 #include <xen/acpi.h>
 #include <xen/event.h>
 #include <xen/iocap.h>
+#include <xen/sizes.h>
 #include <xen/device_tree.h>
 #include <xen/libfdt/libfdt.h>
 #include <acpi/actables.h>
@@ -30,6 +31,7 @@ static int __init acpi_iomem_deny_access(struct domain *d)
 {
     acpi_status status;
     struct acpi_table_spcr *spcr = NULL;
+    struct acpi_table_iort *iort;
     unsigned long mfn;
     int rc;
 
@@ -55,6 +57,44 @@ static int __init acpi_iomem_deny_access(struct domain *d)
         printk("Failed to get SPCR table, Xen console may be unavailable\n");
     }
 
+    status = acpi_get_table(ACPI_SIG_IORT, 0,
+                            (struct acpi_table_header **)&iort);
+
+    if ( ACPI_SUCCESS(status) )
+    {
+        int i;
+        struct acpi_iort_node *node, *end;
+        node = ACPI_ADD_PTR(struct acpi_iort_node, iort, iort->node_offset);
+        end = ACPI_ADD_PTR(struct acpi_iort_node, iort, iort->header.length);
+
+        for ( i = 0; i < iort->node_count; i++ )
+        {
+            if ( node >= end )
+                break;
+
+            switch ( node->type )
+            {
+                case ACPI_IORT_NODE_SMMU_V3:
+                {
+                    struct acpi_iort_smmu_v3 *smmu;
+                    smmu = (struct acpi_iort_smmu_v3 *)node->node_data;
+                    mfn = paddr_to_pfn(smmu->base_address);
+                    rc = iomem_deny_access(d, mfn, mfn + PFN_UP(SZ_128K));
+                    if ( rc )
+                        printk("iomem_deny_access failed for SMMUv3\n");
+                    node->type = 0xff;
+                    break;
+                }
+            }
+            node = ACPI_ADD_PTR(struct acpi_iort_node, node, node->length);
+        }
+    }
+    else
+    {
+        printk("Failed to get IORT table\n");
+        return -EINVAL;
+    }
+
     /* Deny MMIO access for GIC regions */
     return gic_iomem_deny_access(d);
 }
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:14:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:14:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315263.533727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkJK-0006ak-Fx; Wed, 27 Apr 2022 16:14:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315263.533727; Wed, 27 Apr 2022 16:14:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkJK-0006ad-D2; Wed, 27 Apr 2022 16:14:38 +0000
Received: by outflank-mailman (input) for mailman id 315263;
 Wed, 27 Apr 2022 16:14:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sRcl=VF=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1njkJJ-0006aX-Fi
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 16:14:37 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 20da3222-c645-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 18:14:35 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C28E6ED1;
 Wed, 27 Apr 2022 09:14:34 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC8B63F5A1;
 Wed, 27 Apr 2022 09:14:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20da3222-c645-11ec-8fc2-03012f2f19d4
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] arm/its: enable LPIs before mapping the collection table
Date: Wed, 27 Apr 2022 17:14:25 +0100
Message-Id: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

MAPC_LPI_OFF ITS command error can be reported to software if LPIs are
not enabled before mapping the collection table using MAPC command.

Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection
table.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
 xen/arch/arm/gic-v3.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 3c472ed768..8fb0014b16 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -812,11 +812,11 @@ static int gicv3_cpu_init(void)
     /* If the host has any ITSes, enable LPIs now. */
     if ( gicv3_its_host_has_its() )
     {
+        if ( !gicv3_enable_lpis() )
+            return -EBUSY;
         ret = gicv3_its_setup_collection(smp_processor_id());
         if ( ret )
             return ret;
-        if ( !gicv3_enable_lpis() )
-            return -EBUSY;
     }
 
     /* Set priority on PPI and SGI interrupts */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:16:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:16:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315273.533739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkKj-0007EV-QS; Wed, 27 Apr 2022 16:16:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315273.533739; Wed, 27 Apr 2022 16:16:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkKj-0007EO-NH; Wed, 27 Apr 2022 16:16:05 +0000
Received: by outflank-mailman (input) for mailman id 315273;
 Wed, 27 Apr 2022 16:16:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sRcl=VF=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1njkKi-0007EC-9I
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 16:16:04 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 556acb42-c645-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 18:16:03 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 827F8ED1;
 Wed, 27 Apr 2022 09:16:02 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DBD83F5A1;
 Wed, 27 Apr 2022 09:16:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 556acb42-c645-11ec-a405-831a346695d4
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device
Date: Wed, 27 Apr 2022 17:15:51 +0100
Message-Id: <a19f7238f428deb610df643944f60e1e79e273cf.1651075797.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When a device is deassigned from the domain it is required to remove the
iommu group.

If we don't remove the group, the next time when we assign
a device, SME and S2CR will not be setup correctly for the device
because of that SMMU fault will be observed.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
 xen/drivers/passthrough/arm/smmu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
index 5cacb2dd99..9a31c332d0 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -1690,6 +1690,8 @@ static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev)
 	if (cfg)
 		arm_smmu_master_free_smes(cfg);
 
+	iommu_group_put(dev_iommu_group(dev));
+	dev_iommu_group(dev) = NULL;
 }
 
 #if 0 /*
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:38:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:38:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315285.533749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkgh-0001C2-KP; Wed, 27 Apr 2022 16:38:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315285.533749; Wed, 27 Apr 2022 16:38:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkgh-0001Bv-HU; Wed, 27 Apr 2022 16:38:47 +0000
Received: by outflank-mailman (input) for mailman id 315285;
 Wed, 27 Apr 2022 16:38:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njkgg-0001Bl-04; Wed, 27 Apr 2022 16:38:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njkgf-00026P-UP; Wed, 27 Apr 2022 16:38:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njkgf-0001aT-5f; Wed, 27 Apr 2022 16:38:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njkgf-0003L0-5D; Wed, 27 Apr 2022 16:38:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/XOwyAwDuWYdDl01EHnYRYEeWFe1AQ38zgGgSUuj0lQ=; b=gAaMDkIOLN1uB/V+JwQoKWqMXp
	d31WN1MbiNEZKqnTq4EJe+FK5w5XPwiYZ/01TGL1ecEV8zDUUcx2sQn8IBD3R6DD8IOK0Ft9oWt5m
	sO9Yrw2yd7EOv7wBBJNgKe9Q/giJALmpeTh5gp7F2C3VB8EFO2cmt8/lMwYepwtsV+b0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169781-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169781: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
X-Osstest-Versions-That:
    xen=163071b1800304c962756789b4ef0ddb978059ba
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 16:38:45 +0000

flight 169781 xen-unstable-smoke real [real]
flight 169785 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169781/
http://logs.test-lab.xenproject.org/osstest/logs/169785/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 169773

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
baseline version:
 xen                  163071b1800304c962756789b4ef0ddb978059ba

Last test of basis   169773  2022-04-27 08:01:54 Z    0 days
Testing same since   169781  2022-04-27 12:01:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  David Vrabel <dvrabel@amazon.co.uk>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
Author: David Vrabel <dvrabel@amazon.co.uk>
Date:   Tue Apr 26 10:33:01 2022 +0200

    page_alloc: assert IRQs are enabled in heap alloc/free
    
    Heap pages can only be safely allocated and freed with interrupts
    enabled as they may require a TLB flush which may send IPIs (on x86).
    
    Normally spinlock debugging would catch calls from the incorrect
    context, but not from stop_machine_run() action functions as these are
    called with spin lock debugging disabled.
    
    Enhance the assertions in alloc_xenheap_pages() and
    alloc_domheap_pages() to check interrupts are enabled. For consistency
    the same asserts are used when freeing heap pages.
    
    As an exception, when only 1 PCPU is online, allocations are permitted
    with interrupts disabled as any TLB flushes would be local only. This
    is necessary during early boot.
    
    Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit fbd2445558beff90eb9607308f0845b18a7a2b5a
Author: Julien Grall <jgrall@amazon.com>
Date:   Tue Apr 26 21:06:29 2022 +0100

    xen/arm: alternative: Don't call vmap() within stop_machine_run()
    
    Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap
    alloc/free" extended the checks in the buddy allocator to catch
    any use of the helpers from context with interrupts disabled.
    
    Unfortunately, the rule is not followed in the alternative code and
    this will result to crash at boot with debug enabled:
    
    (XEN) Xen call trace:
    (XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
    (XEN)    [<00000000>] 00000000 (LR)
    (XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
    (XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
    (XEN)    [<00236864>] __vmap+0x400/0x4a4
    (XEN)    [<0026aee8>] arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
    (XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
    (XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
    (XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
    (XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c
    
    The interrupts will be disabled by the state machine in stop_machine_run(),
    hence why the ASSERT is hit.
    
    For now the patch extending the checks has been reverted, but it would
    be good to re-introduce it (allocation with interrupts disabled is not
    desirable).
    
    So move the re-mapping of Xen to the caller of stop_machine_run().
    
    Signed-off-by: Julien Grall <jgrall@amazon.com>
    Cc: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:39:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:39:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315289.533760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkh7-0001dH-Te; Wed, 27 Apr 2022 16:39:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315289.533760; Wed, 27 Apr 2022 16:39:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkh7-0001dA-Qg; Wed, 27 Apr 2022 16:39:13 +0000
Received: by outflank-mailman (input) for mailman id 315289;
 Wed, 27 Apr 2022 16:39:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pZpk=VF=citrix.com=prvs=1099d913e=ross.lagerwall@srs-se1.protection.inumbo.net>)
 id 1njkh6-0001cZ-9m
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 16:39:12 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c96bbe0-c648-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 18:39:08 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c96bbe0-c648-11ec-8fc2-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651077548;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=/p2UboelgEPz6mmmRfIqiNgIybPrPv35J75BEdqaQow=;
  b=PFh8CNOQUMqvixa8Xl99BYB0szltTeH68faZyxm49HX6tBcfr3MciGHn
   a3PmjSJ63dZ9+HiKFkDz6boee9E9uivHOa2yra9z6mV9taldfyS0U1s1B
   /VVwJqwCMpbnxpmOR/A6giPr5SYuswnx0Dw0XeB+RICsHzT6JZmdRDNwj
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70082323
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:z32bGKsBBhGJgcVpbdGA+BsgpOfnVEJeMUV32f8akzHdYApBsoF/q
 tZmKW6BPfzeY2WjfYhwOYrn9BhT6J7cy4IxGVM/+ygxHiJA+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X5
 ouryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8mHfDPwPhFcSJgLCdVILRU2Y3fPESg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yirCS/IvTp3ZXKzO4fdT3Ssqh9AIFvHbD
 yYcQWU3NESaOEcUUrsRILAfkOurg1jaSD0G9EKIvboO+XfN5iUkhdABN/KKI4fXFK25hH2wv
 mvb+0zpDxdcM8aQoRKc/3exw+PCgy7/cIQVErK+67htmlL77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVRAakqXSJuhodXdt4EOAg7gyJjK3O7G6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJHv57ISiqBrpWvlQy0EjUMP04wfTI4Ul5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1
 JTvs5jPtbteZX1hecHkfQnsIF1Lz6vdWNE/qQQ2d3XEy9hK0yT+Fb28GBkkeC9U3j8sIFcFm
 nP7twJL/4N0N3C3d6JxaI/ZI510kPCxToi/Dq+PNYAmjn1NmOivpn8GWKJt9zq1zBhEfV8XZ
 P93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7lphIvZ8FS92
 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1ORT9xVqeNke9wE2Gn9owM/tr1E
 riGchcw4DLCabfvdW1mtlgLhGvTYKtC
IronPort-HdrOrdr: A9a23:S4gKx6l1D04gKJCXSqLKeqzhNNnpDfIg3DAbv31ZSRFFG/Fxl6
 iV8sjzsiWE7Ar5OUtQ/+xoV5PhfZqxz/JICOoqTNKftWvdyQiVxehZhOOIqVDd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="70082323"
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard
	<anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
	<qemu-devel@nongnu.org>, Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: [PATCH] xen/pt: Avoid initializing BARs from the host ones
Date: Wed, 27 Apr 2022 17:38:12 +0100
Message-ID: <20220427163812.2461718-1-ross.lagerwall@citrix.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

The BAR emulated register definition does not set emu_mask because it
varies depending on bar_flag.  If emu_mask is not set, then the BAR is
initialized based on the host value which causes the BAR to be initially
mapped at whatever value the host device was using. Although it does
eventually get mapped at the correct location, it causes unnecessary
mapping/unmappings.

To fix this, initialize a per-register emu_mask in XenPTReg from the
initial value in XenPTRegInfo and then let the register's init() function
set/modify the emu_mask if necessary. Update the code to use emu_mask
in XenPTReg consistently and rename the existing emu_mask in
XenPTRegInfo to emu_mask_init to help with refactoring.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
 hw/xen/xen_pt.c             |   2 +-
 hw/xen/xen_pt.h             |   5 +-
 hw/xen/xen_pt_config_init.c | 221 ++++++++++++++++++------------------
 3 files changed, 115 insertions(+), 113 deletions(-)

diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 027190fa44..f0af1cfcec 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -327,7 +327,7 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr,
             uint32_t real_offset = reg_grp_entry->base_offset + reg->offset;
             uint32_t valid_mask = 0xFFFFFFFF >> ((4 - emul_len) << 3);
             uint8_t *ptr_val = NULL;
-            uint32_t wp_mask = reg->emu_mask | reg->ro_mask;
+            uint32_t wp_mask = reg_entry->emu_mask | reg->ro_mask;
 
             valid_mask <<= (find_addr - real_offset) << 3;
             ptr_val = (uint8_t *)&val + (real_offset & 3);
diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
index 6b8e13cdee..dbb917a46c 100644
--- a/hw/xen/xen_pt.h
+++ b/hw/xen/xen_pt.h
@@ -46,7 +46,7 @@ void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val);
 
 /* function type for config reg */
 typedef int (*xen_pt_conf_reg_init)
-    (XenPCIPassthroughState *, XenPTRegInfo *, uint32_t real_offset,
+    (XenPCIPassthroughState *, XenPTReg *, uint32_t real_offset,
      uint32_t *data);
 typedef int (*xen_pt_conf_dword_write)
     (XenPCIPassthroughState *, XenPTReg *cfg_entry,
@@ -117,7 +117,7 @@ struct XenPTRegInfo {
     /* reg read/write-1-clear field mask (ON:RW1C/RW1CS, OFF:other) */
     uint32_t rw1c_mask;
     /* reg emulate field mask (ON:emu, OFF:passthrough) */
-    uint32_t emu_mask;
+    uint32_t emu_mask_init;
     xen_pt_conf_reg_init init;
     /* read/write function pointer
      * for double_word/word/byte size */
@@ -146,6 +146,7 @@ struct XenPTReg {
         uint16_t *half_word;
         uint32_t *word;
     } ptr; /* pointer to dev.config. */
+    uint32_t emu_mask;
 };
 
 typedef const struct XenPTRegGroupInfo XenPTRegGroupInfo;
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index c5c4e943a8..2a934494ed 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -25,7 +25,7 @@
 
 /* prototype */
 
-static int xen_pt_ptr_reg_init(XenPCIPassthroughState *s, XenPTRegInfo *reg,
+static int xen_pt_ptr_reg_init(XenPCIPassthroughState *s, XenPTReg *reg_entry,
                                uint32_t real_offset, uint32_t *data);
 
 
@@ -98,9 +98,10 @@ XenPTReg *xen_pt_find_reg(XenPTRegGroup *reg_grp, uint32_t address)
 }
 
 static uint32_t get_throughable_mask(const XenPCIPassthroughState *s,
-                                     XenPTRegInfo *reg, uint32_t valid_mask)
+                                     XenPTReg *reg_entry, uint32_t valid_mask)
 {
-    uint32_t throughable_mask = ~(reg->emu_mask | reg->ro_mask);
+    XenPTRegInfo *reg = reg_entry->reg;
+    uint32_t throughable_mask = ~(reg_entry->emu_mask | reg->ro_mask);
 
     if (!s->permissive) {
         throughable_mask &= ~reg->res_mask;
@@ -116,10 +117,10 @@ static uint32_t get_throughable_mask(const XenPCIPassthroughState *s,
 /* register initialization function */
 
 static int xen_pt_common_reg_init(XenPCIPassthroughState *s,
-                                  XenPTRegInfo *reg, uint32_t real_offset,
+                                  XenPTReg *reg_entry, uint32_t real_offset,
                                   uint32_t *data)
 {
-    *data = reg->init_val;
+    *data = reg_entry->reg->init_val;
     return 0;
 }
 
@@ -128,12 +129,11 @@ static int xen_pt_common_reg_init(XenPCIPassthroughState *s,
 static int xen_pt_byte_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
                                 uint8_t *value, uint8_t valid_mask)
 {
-    XenPTRegInfo *reg = cfg_entry->reg;
     uint8_t valid_emu_mask = 0;
     uint8_t *data = cfg_entry->ptr.byte;
 
     /* emulate byte register */
-    valid_emu_mask = reg->emu_mask & valid_mask;
+    valid_emu_mask = cfg_entry->emu_mask & valid_mask;
     *value = XEN_PT_MERGE_VALUE(*value, *data, ~valid_emu_mask);
 
     return 0;
@@ -141,12 +141,11 @@ static int xen_pt_byte_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
 static int xen_pt_word_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
                                 uint16_t *value, uint16_t valid_mask)
 {
-    XenPTRegInfo *reg = cfg_entry->reg;
     uint16_t valid_emu_mask = 0;
     uint16_t *data = cfg_entry->ptr.half_word;
 
     /* emulate word register */
-    valid_emu_mask = reg->emu_mask & valid_mask;
+    valid_emu_mask = cfg_entry->emu_mask & valid_mask;
     *value = XEN_PT_MERGE_VALUE(*value, *data, ~valid_emu_mask);
 
     return 0;
@@ -154,12 +153,11 @@ static int xen_pt_word_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
 static int xen_pt_long_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
                                 uint32_t *value, uint32_t valid_mask)
 {
-    XenPTRegInfo *reg = cfg_entry->reg;
     uint32_t valid_emu_mask = 0;
     uint32_t *data = cfg_entry->ptr.word;
 
     /* emulate long register */
-    valid_emu_mask = reg->emu_mask & valid_mask;
+    valid_emu_mask = cfg_entry->emu_mask & valid_mask;
     *value = XEN_PT_MERGE_VALUE(*value, *data, ~valid_emu_mask);
 
     return 0;
@@ -173,11 +171,11 @@ static int xen_pt_byte_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
 {
     XenPTRegInfo *reg = cfg_entry->reg;
     uint8_t writable_mask = 0;
-    uint8_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
+    uint8_t throughable_mask = get_throughable_mask(s, cfg_entry, valid_mask);
     uint8_t *data = cfg_entry->ptr.byte;
 
     /* modify emulate register */
-    writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
 
     /* create value for writing to I/O device register */
@@ -192,11 +190,11 @@ static int xen_pt_word_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
 {
     XenPTRegInfo *reg = cfg_entry->reg;
     uint16_t writable_mask = 0;
-    uint16_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
+    uint16_t throughable_mask = get_throughable_mask(s, cfg_entry, valid_mask);
     uint16_t *data = cfg_entry->ptr.half_word;
 
     /* modify emulate register */
-    writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
 
     /* create value for writing to I/O device register */
@@ -211,11 +209,11 @@ static int xen_pt_long_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
 {
     XenPTRegInfo *reg = cfg_entry->reg;
     uint32_t writable_mask = 0;
-    uint32_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
+    uint32_t throughable_mask = get_throughable_mask(s, cfg_entry, valid_mask);
     uint32_t *data = cfg_entry->ptr.word;
 
     /* modify emulate register */
-    writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
 
     /* create value for writing to I/O device register */
@@ -229,7 +227,7 @@ static int xen_pt_long_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
 /* XenPTRegInfo declaration
  * - only for emulated register (either a part or whole bit).
  * - for passthrough register that need special behavior (like interacting with
- *   other component), set emu_mask to all 0 and specify r/w func properly.
+ *   other component), set emu_mask_init to all 0 and specify r/w func properly.
  * - do NOT use ALL F for init_val, otherwise the tbl will not be registered.
  */
 
@@ -238,21 +236,21 @@ static int xen_pt_long_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
  */
 
 static int xen_pt_vendor_reg_init(XenPCIPassthroughState *s,
-                                  XenPTRegInfo *reg, uint32_t real_offset,
+                                  XenPTReg *reg_entry, uint32_t real_offset,
                                   uint32_t *data)
 {
     *data = s->real_device.vendor_id;
     return 0;
 }
 static int xen_pt_device_reg_init(XenPCIPassthroughState *s,
-                                  XenPTRegInfo *reg, uint32_t real_offset,
+                                  XenPTReg *reg_entry, uint32_t real_offset,
                                   uint32_t *data)
 {
     *data = s->real_device.device_id;
     return 0;
 }
 static int xen_pt_status_reg_init(XenPCIPassthroughState *s,
-                                  XenPTRegInfo *reg, uint32_t real_offset,
+                                  XenPTReg *unused, uint32_t real_offset,
                                   uint32_t *data)
 {
     XenPTRegGroup *reg_grp_entry = NULL;
@@ -287,17 +285,17 @@ static int xen_pt_status_reg_init(XenPCIPassthroughState *s,
     return 0;
 }
 static int xen_pt_header_type_reg_init(XenPCIPassthroughState *s,
-                                       XenPTRegInfo *reg, uint32_t real_offset,
-                                       uint32_t *data)
+                                       XenPTReg *reg_entry,
+                                       uint32_t real_offset, uint32_t *data)
 {
     /* read PCI_HEADER_TYPE */
-    *data = reg->init_val | 0x80;
+    *data = reg_entry->reg->init_val | 0x80;
     return 0;
 }
 
 /* initialize Interrupt Pin register */
 static int xen_pt_irqpin_reg_init(XenPCIPassthroughState *s,
-                                  XenPTRegInfo *reg, uint32_t real_offset,
+                                  XenPTReg *reg_entry, uint32_t real_offset,
                                   uint32_t *data)
 {
     if (s->real_device.irq) {
@@ -313,7 +311,7 @@ static int xen_pt_cmd_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
 {
     XenPTRegInfo *reg = cfg_entry->reg;
     uint16_t writable_mask = 0;
-    uint16_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
+    uint16_t throughable_mask = get_throughable_mask(s, cfg_entry, valid_mask);
     uint16_t *data = cfg_entry->ptr.half_word;
 
     /* modify emulate register */
@@ -405,13 +403,13 @@ static inline uint32_t base_address_with_flags(XenHostPCIIORegion *hr)
     }
 }
 
-static int xen_pt_bar_reg_init(XenPCIPassthroughState *s, XenPTRegInfo *reg,
+static int xen_pt_bar_reg_init(XenPCIPassthroughState *s, XenPTReg *reg_entry,
                                uint32_t real_offset, uint32_t *data)
 {
     uint32_t reg_field = 0;
     int index;
 
-    index = xen_pt_bar_offset_to_index(reg->offset);
+    index = xen_pt_bar_offset_to_index(reg_entry->reg->offset);
     if (index < 0 || index >= PCI_NUM_REGIONS) {
         XEN_PT_ERR(&s->dev, "Internal error: Invalid BAR index [%d].\n", index);
         return -1;
@@ -423,6 +421,21 @@ static int xen_pt_bar_reg_init(XenPCIPassthroughState *s, XenPTRegInfo *reg,
         reg_field = XEN_PT_INVALID_REG;
     }
 
+     /* set emulate mask depend on BAR flag */
+     switch (s->bases[index].bar_flag) {
+     case XEN_PT_BAR_FLAG_MEM:
+         reg_entry->emu_mask = XEN_PT_BAR_MEM_EMU_MASK;
+         break;
+     case XEN_PT_BAR_FLAG_IO:
+         reg_entry->emu_mask = XEN_PT_BAR_IO_EMU_MASK;
+         break;
+     case XEN_PT_BAR_FLAG_UPPER:
+         reg_entry->emu_mask = XEN_PT_BAR_ALLF;
+         break;
+     default:
+         break;
+    }
+
     *data = reg_field;
     return 0;
 }
@@ -431,7 +444,6 @@ static int xen_pt_bar_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
 {
     XenPTRegInfo *reg = cfg_entry->reg;
     uint32_t valid_emu_mask = 0;
-    uint32_t bar_emu_mask = 0;
     int index;
 
     /* get BAR index */
@@ -444,23 +456,8 @@ static int xen_pt_bar_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
     /* use fixed-up value from kernel sysfs */
     *value = base_address_with_flags(&s->real_device.io_regions[index]);
 
-    /* set emulate mask depend on BAR flag */
-    switch (s->bases[index].bar_flag) {
-    case XEN_PT_BAR_FLAG_MEM:
-        bar_emu_mask = XEN_PT_BAR_MEM_EMU_MASK;
-        break;
-    case XEN_PT_BAR_FLAG_IO:
-        bar_emu_mask = XEN_PT_BAR_IO_EMU_MASK;
-        break;
-    case XEN_PT_BAR_FLAG_UPPER:
-        bar_emu_mask = XEN_PT_BAR_ALLF;
-        break;
-    default:
-        break;
-    }
-
     /* emulate BAR */
-    valid_emu_mask = bar_emu_mask & valid_mask;
+    valid_emu_mask = cfg_entry->emu_mask & valid_mask;
     *value = XEN_PT_MERGE_VALUE(*value, *cfg_entry->ptr.word, ~valid_emu_mask);
 
     return 0;
@@ -474,7 +471,6 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
     PCIDevice *d = PCI_DEVICE(s);
     const PCIIORegion *r;
     uint32_t writable_mask = 0;
-    uint32_t bar_emu_mask = 0;
     uint32_t bar_ro_mask = 0;
     uint32_t r_size = 0;
     int index = 0;
@@ -493,7 +489,6 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
     /* set emulate mask and read-only mask values depend on the BAR flag */
     switch (s->bases[index].bar_flag) {
     case XEN_PT_BAR_FLAG_MEM:
-        bar_emu_mask = XEN_PT_BAR_MEM_EMU_MASK;
         if (!r_size) {
             /* low 32 bits mask for 64 bit bars */
             bar_ro_mask = XEN_PT_BAR_ALLF;
@@ -502,13 +497,11 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
         }
         break;
     case XEN_PT_BAR_FLAG_IO:
-        bar_emu_mask = XEN_PT_BAR_IO_EMU_MASK;
         bar_ro_mask = XEN_PT_BAR_IO_RO_MASK | (r_size - 1);
         break;
     case XEN_PT_BAR_FLAG_UPPER:
         assert(index > 0);
         r_size = d->io_regions[index - 1].size >> 32;
-        bar_emu_mask = XEN_PT_BAR_ALLF;
         bar_ro_mask = r_size ? r_size - 1 : 0;
         break;
     default:
@@ -516,7 +509,7 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
     }
 
     /* modify emulate register */
-    writable_mask = bar_emu_mask & ~bar_ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~bar_ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
 
     /* check whether we need to update the virtual region address or not */
@@ -547,7 +540,7 @@ static int xen_pt_exp_rom_bar_reg_write(XenPCIPassthroughState *s,
     XenPTRegion *base = NULL;
     PCIDevice *d = PCI_DEVICE(s);
     uint32_t writable_mask = 0;
-    uint32_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
+    uint32_t throughable_mask = get_throughable_mask(s, cfg_entry, valid_mask);
     pcibus_t r_size = 0;
     uint32_t bar_ro_mask = 0;
     uint32_t *data = cfg_entry->ptr.word;
@@ -594,7 +587,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .ro_mask    = 0xFFFF,
-        .emu_mask   = 0xFFFF,
+        .emu_mask_init = 0xFFFF,
         .init       = xen_pt_vendor_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -605,7 +598,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .ro_mask    = 0xFFFF,
-        .emu_mask   = 0xFFFF,
+        .emu_mask_init = 0xFFFF,
         .init       = xen_pt_device_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -616,7 +609,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .res_mask   = 0xF880,
-        .emu_mask   = 0x0743,
+        .emu_mask_init = 0x0743,
         .init       = xen_pt_common_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_cmd_reg_write,
@@ -627,7 +620,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_ptr_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -643,7 +636,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .res_mask   = 0x0007,
         .ro_mask    = 0x06F8,
         .rw1c_mask  = 0xF900,
-        .emu_mask   = 0x0010,
+        .emu_mask_init = 0x0010,
         .init       = xen_pt_status_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -654,7 +647,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0x00,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_common_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -665,7 +658,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0x00,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_common_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -676,7 +669,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0x00,
+        .emu_mask_init = 0x00,
         .init       = xen_pt_header_type_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -687,7 +680,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0x00,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_common_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -698,7 +691,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_irqpin_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -764,7 +757,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] = {
         .size       = 4,
         .init_val   = 0x00000000,
         .ro_mask    = ~PCI_ROM_ADDRESS_MASK & ~PCI_ROM_ADDRESS_ENABLE,
-        .emu_mask   = (uint32_t)PCI_ROM_ADDRESS_MASK,
+        .emu_mask_init = (uint32_t)PCI_ROM_ADDRESS_MASK,
         .init       = xen_pt_bar_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
         .u.dw.write = xen_pt_exp_rom_bar_reg_write,
@@ -786,7 +779,7 @@ static XenPTRegInfo xen_pt_emu_reg_vpd[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_ptr_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -795,7 +788,7 @@ static XenPTRegInfo xen_pt_emu_reg_vpd[] = {
         .offset     = PCI_VPD_ADDR,
         .size       = 2,
         .ro_mask    = 0x0003,
-        .emu_mask   = 0x0003,
+        .emu_mask_init = 0x0003,
         .init       = xen_pt_common_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -817,7 +810,7 @@ static XenPTRegInfo xen_pt_emu_reg_vendor[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_ptr_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -854,9 +847,10 @@ static inline uint8_t get_device_type(XenPCIPassthroughState *s,
 
 /* initialize Link Control register */
 static int xen_pt_linkctrl_reg_init(XenPCIPassthroughState *s,
-                                    XenPTRegInfo *reg, uint32_t real_offset,
+                                    XenPTReg *reg_entry, uint32_t real_offset,
                                     uint32_t *data)
 {
+    XenPTRegInfo *reg = reg_entry->reg;
     uint8_t cap_ver = get_capability_version(s, real_offset - reg->offset);
     uint8_t dev_type = get_device_type(s, real_offset - reg->offset);
 
@@ -872,9 +866,10 @@ static int xen_pt_linkctrl_reg_init(XenPCIPassthroughState *s,
 }
 /* initialize Device Control 2 register */
 static int xen_pt_devctrl2_reg_init(XenPCIPassthroughState *s,
-                                    XenPTRegInfo *reg, uint32_t real_offset,
+                                    XenPTReg *reg_entry, uint32_t real_offset,
                                     uint32_t *data)
 {
+    XenPTRegInfo *reg = reg_entry->reg;
     uint8_t cap_ver = get_capability_version(s, real_offset - reg->offset);
 
     /* no need to initialize in case of cap_ver 1.x */
@@ -887,9 +882,10 @@ static int xen_pt_devctrl2_reg_init(XenPCIPassthroughState *s,
 }
 /* initialize Link Control 2 register */
 static int xen_pt_linkctrl2_reg_init(XenPCIPassthroughState *s,
-                                     XenPTRegInfo *reg, uint32_t real_offset,
+                                     XenPTReg *reg_entry, uint32_t real_offset,
                                      uint32_t *data)
 {
+    XenPTRegInfo *reg = reg_entry->reg;
     uint8_t cap_ver = get_capability_version(s, real_offset - reg->offset);
     uint32_t reg_field = 0;
 
@@ -921,7 +917,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_ptr_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -932,7 +928,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
         .size       = 4,
         .init_val   = 0x00000000,
         .ro_mask    = 0xFFFFFFFF,
-        .emu_mask   = 0x10000000,
+        .emu_mask_init = 0x10000000,
         .init       = xen_pt_common_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
         .u.dw.write = xen_pt_long_reg_write,
@@ -943,7 +939,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
         .size       = 2,
         .init_val   = 0x2810,
         .ro_mask    = 0x8400,
-        .emu_mask   = 0xFFFF,
+        .emu_mask_init = 0xFFFF,
         .init       = xen_pt_common_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -965,7 +961,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .ro_mask    = 0xFC34,
-        .emu_mask   = 0xFFFF,
+        .emu_mask_init = 0xFFFF,
         .init       = xen_pt_linkctrl_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -986,7 +982,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .ro_mask    = 0xFFE0,
-        .emu_mask   = 0xFFFF,
+        .emu_mask_init = 0xFFFF,
         .init       = xen_pt_devctrl2_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -997,7 +993,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .ro_mask    = 0xE040,
-        .emu_mask   = 0xFFFF,
+        .emu_mask_init = 0xFFFF,
         .init       = xen_pt_linkctrl2_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -1020,7 +1016,7 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_ptr_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -1031,7 +1027,7 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .ro_mask    = 0xFFFF,
-        .emu_mask   = 0xF9C8,
+        .emu_mask_init = 0xF9C8,
         .init       = xen_pt_common_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -1044,7 +1040,7 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] = {
         .res_mask   = 0x00F0,
         .ro_mask    = 0x610C,
         .rw1c_mask  = 0x8000,
-        .emu_mask   = 0x810B,
+        .emu_mask_init = 0x810B,
         .init       = xen_pt_common_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_word_reg_write,
@@ -1066,7 +1062,7 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] = {
 
 /* Message Control register */
 static int xen_pt_msgctrl_reg_init(XenPCIPassthroughState *s,
-                                   XenPTRegInfo *reg, uint32_t real_offset,
+                                   XenPTReg *reg_entry, uint32_t real_offset,
                                    uint32_t *data)
 {
     XenPTMSI *msi = s->msi;
@@ -1088,7 +1084,7 @@ static int xen_pt_msgctrl_reg_init(XenPCIPassthroughState *s,
     msi->initialized = false;
     msi->mapped = false;
 
-    *data = reg->init_val;
+    *data = reg_entry->reg->init_val;
     return 0;
 }
 static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,
@@ -1098,7 +1094,7 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,
     XenPTRegInfo *reg = cfg_entry->reg;
     XenPTMSI *msi = s->msi;
     uint16_t writable_mask = 0;
-    uint16_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
+    uint16_t throughable_mask = get_throughable_mask(s, cfg_entry, valid_mask);
     uint16_t *data = cfg_entry->ptr.half_word;
 
     /* Currently no support for multi-vector */
@@ -1107,7 +1103,7 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,
     }
 
     /* modify emulate register */
-    writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
     msi->flags |= *data & ~PCI_MSI_FLAGS_ENABLE;
 
@@ -1148,14 +1144,14 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,
 
 /* initialize Message Upper Address register */
 static int xen_pt_msgaddr64_reg_init(XenPCIPassthroughState *s,
-                                     XenPTRegInfo *reg, uint32_t real_offset,
+                                     XenPTReg *reg_entry, uint32_t real_offset,
                                      uint32_t *data)
 {
     /* no need to initialize in case of 32 bit type */
     if (!(s->msi->flags & PCI_MSI_FLAGS_64BIT)) {
         *data = XEN_PT_INVALID_REG;
     } else {
-        *data = reg->init_val;
+        *data = reg_entry->reg->init_val;
     }
 
     return 0;
@@ -1163,15 +1159,16 @@ static int xen_pt_msgaddr64_reg_init(XenPCIPassthroughState *s,
 /* this function will be called twice (for 32 bit and 64 bit type) */
 /* initialize Message Data register */
 static int xen_pt_msgdata_reg_init(XenPCIPassthroughState *s,
-                                   XenPTRegInfo *reg, uint32_t real_offset,
+                                   XenPTReg *reg_entry, uint32_t real_offset,
                                    uint32_t *data)
 {
+    XenPTRegInfo *reg = reg_entry->reg;
     uint32_t flags = s->msi->flags;
     uint32_t offset = reg->offset;
 
     /* check the offset whether matches the type or not */
     if (xen_pt_msi_check_type(offset, flags, DATA)) {
-        *data = reg->init_val;
+        *data = reg_entry->reg->init_val;
     } else {
         *data = XEN_PT_INVALID_REG;
     }
@@ -1181,9 +1178,10 @@ static int xen_pt_msgdata_reg_init(XenPCIPassthroughState *s,
 /* this function will be called twice (for 32 bit and 64 bit type) */
 /* initialize Mask register */
 static int xen_pt_mask_reg_init(XenPCIPassthroughState *s,
-                                XenPTRegInfo *reg, uint32_t real_offset,
+                                XenPTReg *reg_entry, uint32_t real_offset,
                                 uint32_t *data)
 {
+    XenPTRegInfo *reg = reg_entry->reg;
     uint32_t flags = s->msi->flags;
 
     /* check the offset whether matches the type or not */
@@ -1200,9 +1198,10 @@ static int xen_pt_mask_reg_init(XenPCIPassthroughState *s,
 /* this function will be called twice (for 32 bit and 64 bit type) */
 /* initialize Pending register */
 static int xen_pt_pending_reg_init(XenPCIPassthroughState *s,
-                                   XenPTRegInfo *reg, uint32_t real_offset,
+                                   XenPTReg *reg_entry, uint32_t real_offset,
                                    uint32_t *data)
 {
+    XenPTRegInfo *reg = reg_entry->reg;
     uint32_t flags = s->msi->flags;
 
     /* check the offset whether matches the type or not */
@@ -1227,7 +1226,7 @@ static int xen_pt_msgaddr32_reg_write(XenPCIPassthroughState *s,
     uint32_t *data = cfg_entry->ptr.word;
 
     /* modify emulate register */
-    writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
     s->msi->addr_lo = *data;
 
@@ -1261,7 +1260,7 @@ static int xen_pt_msgaddr64_reg_write(XenPCIPassthroughState *s,
     }
 
     /* modify emulate register */
-    writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
     /* update the msi_info too */
     s->msi->addr_hi = *data;
@@ -1301,7 +1300,7 @@ static int xen_pt_msgdata_reg_write(XenPCIPassthroughState *s,
     }
 
     /* modify emulate register */
-    writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
     /* update the msi_info too */
     msi->data = *data;
@@ -1343,7 +1342,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_ptr_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -1355,7 +1354,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .init_val   = 0x0000,
         .res_mask   = 0xFE00,
         .ro_mask    = 0x018E,
-        .emu_mask   = 0x017E,
+        .emu_mask_init = 0x017E,
         .init       = xen_pt_msgctrl_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_msgctrl_reg_write,
@@ -1366,7 +1365,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 4,
         .init_val   = 0x00000000,
         .ro_mask    = 0x00000003,
-        .emu_mask   = 0xFFFFFFFF,
+        .emu_mask_init = 0xFFFFFFFF,
         .init       = xen_pt_common_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
         .u.dw.write = xen_pt_msgaddr32_reg_write,
@@ -1377,7 +1376,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 4,
         .init_val   = 0x00000000,
         .ro_mask    = 0x00000000,
-        .emu_mask   = 0xFFFFFFFF,
+        .emu_mask_init = 0xFFFFFFFF,
         .init       = xen_pt_msgaddr64_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
         .u.dw.write = xen_pt_msgaddr64_reg_write,
@@ -1388,7 +1387,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .ro_mask    = 0x0000,
-        .emu_mask   = 0xFFFF,
+        .emu_mask_init = 0xFFFF,
         .init       = xen_pt_msgdata_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_msgdata_reg_write,
@@ -1399,7 +1398,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 2,
         .init_val   = 0x0000,
         .ro_mask    = 0x0000,
-        .emu_mask   = 0xFFFF,
+        .emu_mask_init = 0xFFFF,
         .init       = xen_pt_msgdata_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_msgdata_reg_write,
@@ -1410,7 +1409,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 4,
         .init_val   = 0x00000000,
         .ro_mask    = 0xFFFFFFFF,
-        .emu_mask   = 0xFFFFFFFF,
+        .emu_mask_init = 0xFFFFFFFF,
         .init       = xen_pt_mask_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
         .u.dw.write = xen_pt_mask_reg_write,
@@ -1421,7 +1420,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 4,
         .init_val   = 0x00000000,
         .ro_mask    = 0xFFFFFFFF,
-        .emu_mask   = 0xFFFFFFFF,
+        .emu_mask_init = 0xFFFFFFFF,
         .init       = xen_pt_mask_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
         .u.dw.write = xen_pt_mask_reg_write,
@@ -1432,7 +1431,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 4,
         .init_val   = 0x00000000,
         .ro_mask    = 0xFFFFFFFF,
-        .emu_mask   = 0x00000000,
+        .emu_mask_init = 0x00000000,
         .init       = xen_pt_pending_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
         .u.dw.write = xen_pt_long_reg_write,
@@ -1443,7 +1442,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
         .size       = 4,
         .init_val   = 0x00000000,
         .ro_mask    = 0xFFFFFFFF,
-        .emu_mask   = 0x00000000,
+        .emu_mask_init = 0x00000000,
         .init       = xen_pt_pending_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
         .u.dw.write = xen_pt_long_reg_write,
@@ -1460,7 +1459,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] = {
 
 /* Message Control register for MSI-X */
 static int xen_pt_msixctrl_reg_init(XenPCIPassthroughState *s,
-                                    XenPTRegInfo *reg, uint32_t real_offset,
+                                    XenPTReg *reg_entry, uint32_t real_offset,
                                     uint32_t *data)
 {
     uint16_t reg_field;
@@ -1479,7 +1478,7 @@ static int xen_pt_msixctrl_reg_init(XenPCIPassthroughState *s,
 
     s->msix->ctrl_offset = real_offset;
 
-    *data = reg->init_val;
+    *data = reg_entry->reg->init_val;
     return 0;
 }
 static int xen_pt_msixctrl_reg_write(XenPCIPassthroughState *s,
@@ -1488,12 +1487,12 @@ static int xen_pt_msixctrl_reg_write(XenPCIPassthroughState *s,
 {
     XenPTRegInfo *reg = cfg_entry->reg;
     uint16_t writable_mask = 0;
-    uint16_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
+    uint16_t throughable_mask = get_throughable_mask(s, cfg_entry, valid_mask);
     int debug_msix_enabled_old;
     uint16_t *data = cfg_entry->ptr.half_word;
 
     /* modify emulate register */
-    writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
+    writable_mask = cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;
     *data = XEN_PT_MERGE_VALUE(*val, *data, writable_mask);
 
     /* create value for writing to I/O device register */
@@ -1527,7 +1526,7 @@ static XenPTRegInfo xen_pt_emu_reg_msix[] = {
         .size       = 1,
         .init_val   = 0x00,
         .ro_mask    = 0xFF,
-        .emu_mask   = 0xFF,
+        .emu_mask_init = 0xFF,
         .init       = xen_pt_ptr_reg_init,
         .u.b.read   = xen_pt_byte_reg_read,
         .u.b.write  = xen_pt_byte_reg_write,
@@ -1539,7 +1538,7 @@ static XenPTRegInfo xen_pt_emu_reg_msix[] = {
         .init_val   = 0x0000,
         .res_mask   = 0x3800,
         .ro_mask    = 0x07FF,
-        .emu_mask   = 0x0000,
+        .emu_mask_init = 0x0000,
         .init       = xen_pt_msixctrl_reg_init,
         .u.w.read   = xen_pt_word_reg_read,
         .u.w.write  = xen_pt_msixctrl_reg_write,
@@ -1555,7 +1554,7 @@ static XenPTRegInfo xen_pt_emu_reg_igd_opregion[] = {
         .offset     = 0x0,
         .size       = 4,
         .init_val   = 0,
-        .emu_mask   = 0xFFFFFFFF,
+        .emu_mask_init = 0xFFFFFFFF,
         .u.dw.read   = xen_pt_intel_opregion_read,
         .u.dw.write  = xen_pt_intel_opregion_write,
     },
@@ -1817,7 +1816,7 @@ static const XenPTRegGroupInfo xen_pt_emu_reg_grps[] = {
 
 /* initialize Capabilities Pointer or Next Pointer register */
 static int xen_pt_ptr_reg_init(XenPCIPassthroughState *s,
-                               XenPTRegInfo *reg, uint32_t real_offset,
+                               XenPTReg *reg_entry, uint32_t real_offset,
                                uint32_t *data)
 {
     int i, rc;
@@ -1926,8 +1925,10 @@ static void xen_pt_config_reg_init(XenPCIPassthroughState *s,
         unsigned int offset;
         uint32_t val;
 
+        reg_entry->emu_mask = reg->emu_mask_init;
+
         /* initialize emulate register */
-        rc = reg->init(s, reg_entry->reg,
+        rc = reg->init(s, reg_entry,
                        reg_grp->base_offset + reg->offset, &data);
         if (rc < 0) {
             g_free(reg_entry);
@@ -1961,7 +1962,7 @@ static void xen_pt_config_reg_init(XenPCIPassthroughState *s,
         /* Set bits in emu_mask are the ones we emulate. The dev.config shall
          * contain the emulated view of the guest - therefore we flip the mask
          * to mask out the host values (which dev.config initially has) . */
-        host_mask = size_mask & ~reg->emu_mask;
+        host_mask = size_mask & ~reg_entry->emu_mask;
 
         if ((data & host_mask) != (val & host_mask)) {
             uint32_t new_val;
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 16:46:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 16:46:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315302.533775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkoQ-0003IW-Vw; Wed, 27 Apr 2022 16:46:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315302.533775; Wed, 27 Apr 2022 16:46:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njkoQ-0003IP-RS; Wed, 27 Apr 2022 16:46:46 +0000
Received: by outflank-mailman (input) for mailman id 315302;
 Wed, 27 Apr 2022 16:46:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=y66U=VF=citrix.com=prvs=1094d0c61=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1njkoP-0003IJ-Dp
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 16:46:45 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d8427f1-c649-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 18:46:44 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d8427f1-c649-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651078004;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=skXQWOW85Qc59F3aFRE2eu+rBo/OjDnk9C/8N+EWr2s=;
  b=M10hyQAyiFpIDcPJrt39D3zpvUDo59EZmQE6p9s7PXJfqCfBjwH7Fqwz
   t4X8QggB6a4e05VwNCyhgm1+r2mx366BWtn+xjtk1L1eEQWi4nVLiofuv
   srIm1WMokN+thp8/I9F1Gj8NmGAt530tDoegS8Asklap/E3S6I4HPnDlV
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 69461338
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:T4kFsKrVInTTAmPZVTC5JaT+C0teBmIZZRIvgKrLsJaIsI4StFCzt
 garIBnUOauNZWene491Ot7l8kJXupTRn4NnGwJsqnsyRi0Q+ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 4yq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBBYbspssndT9kKB4vPaxPoIOEA0qFmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY
 qL1bBIxPUieOkYUaj/7Drpjg/+FjX3jeQQHuUmT/YQHwkiK6zd+he2F3N39JYXRGJQ9clyjj
 n3C13T0BFcdLtP34TiK6HW3ncfUgDj2HokVEdWQ9PRnnVmSzWw7EwANWB2wpvzRol6zXZdTJ
 lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEefhcK6
 HCzufXVPgM+sLycEU7e1IWuhGbnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn
 W3TxMQqr/BK1JNQif3nlbzSq2j0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU
 ZVtpiR/0AzsJczV/MBuaL9UdF1M2xpiGGeB6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNYSP7NvMtO93qUJ5CIU3c+TPNDK68UzazSsIpKF/vEN9GOCZ8IFwBYGBzyPpia
 P93gO6nDGoACLQP8dZFb7x17FPf/QhnnTm7bcmil3yPiOPODFbIGeZtGAbfNYgRsfLbyDg5B
 v4CbqNmPT0EC7agCsQWmKZORW03wY8TWM6m9pQLJrLSSuekcUl4Y8LsLXoaU9QNt8xoei3gp
 BlRhmcwJILDuED6
IronPort-HdrOrdr: A9a23:QEiSM66Dnqmf4h8MLAPXwMjXdLJyesId70hD6qhwISY6TiW9rb
 HLoB17726QtN9/YhwdcLy7VJVoBEmskqKdgrNhX4tKPjOHhILAFugLhuHfKn/bak7DH4ZmpM
 FdmsNFaeEYY2IUsfrH
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="69461338"
Date: Wed, 27 Apr 2022 17:46:18 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH v3] x86+libxl: correct p2m (shadow) memory pool size
 calculation
Message-ID: <YmlzWqVm0lE6LriF@perard.uk.xensource.com>
References: <81ba388c-66ff-e191-0098-2f88a004105c@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <81ba388c-66ff-e191-0098-2f88a004105c@suse.com>

On Wed, Apr 27, 2022 at 12:57:17PM +0200, Jan Beulich wrote:
> The reference "to shadow the resident processes" is applicable to
> domains (potentially) running in shadow mode only. Adjust the
> calculations accordingly. This, however, requires further parameters.
> Since the original function is deprecated anyway, and since it can't be
> changed (for being part of a stable ABI), introduce a new (internal
> only) function, with the deprecated one simply becoming a wrapper.
> 
> In dom0_paging_pages() also take the opportunity and stop open-coding
> DIV_ROUND_UP().
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v3: Refine expression in dom0_paging_pages(). Update comment there as
>     well.
> v2: Introduce libxl__get_required_paging_memory().
> 
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -1017,7 +1017,7 @@ static bool ok_to_default_memkb_in_creat
>       * The result is that the behaviour with old callers is the same
>       * as in 4.13: no additional memory is allocated for shadow and
>       * iommu (unless the caller set shadow_memkb, eg from a call to
> -     * libxl_get_required_shadow_memory).
> +     * libxl__get_required_paging_memory).

I think in this comment, the "caller" is an application using libxl,
which might set shadow_memkb with a value from
libxl_get_required_shadow_memory(). So I don't think there's a need to
change the comment.


Otherwise, the patch looks good.
So with this chunk removed: Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:10:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:10:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315309.533785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlBP-0006Se-Rv; Wed, 27 Apr 2022 17:10:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315309.533785; Wed, 27 Apr 2022 17:10:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlBP-0006SX-P3; Wed, 27 Apr 2022 17:10:31 +0000
Received: by outflank-mailman (input) for mailman id 315309;
 Wed, 27 Apr 2022 17:10:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njlBO-0006SR-B4
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 17:10:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlBN-0002e5-0I; Wed, 27 Apr 2022 17:10:29 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlBM-0008QF-QD; Wed, 27 Apr 2022 17:10:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Cc:
	References:To:Subject:MIME-Version:Date:Message-ID;
	bh=Sdm7aF/zqtosI88SlSaLElO7E01lEWpPolZLCpOxVlo=; b=gPm1HJsTY/6I7vMeCQkswE8Shw
	yTvwoM5EA4MdoPmrWEHh03j9CnBIHELU+o0MgQM+U46Ny8/Rv/NF2LuUKYnYtJdRgRhLUfJPr9LRr
	9HEuWMN6ug5I0MlrBWp34x5iQKf8xIsnjHmtDP+Li35IyWvPUasjQiSi4mG8MJ9KNPkI=;
Message-ID: <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
Date: Wed, 27 Apr 2022 18:10:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
To: osstest service owner <osstest-admin@xenproject.org>,
 xen-devel@lists.xenproject.org
References: <osstest-169781-mainreport@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>, David Vrabel <dvrabel@amazon.co.uk>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <osstest-169781-mainreport@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/04/2022 17:38, osstest service owner wrote:
> flight 169781 xen-unstable-smoke real [real]
> flight 169785 xen-unstable-smoke real-retest [real]
> http://logs.test-lab.xenproject.org/osstest/logs/169781/
> http://logs.test-lab.xenproject.org/osstest/logs/169785/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>   test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 169773

Well, I was overly optimistic :(. This now breaks in the ITS code:

Apr 27 13:23:14.324831 (XEN) Xen call trace:
Apr 27 13:23:14.324855 (XEN)    [<000000000022a678>] 
alloc_xenheap_pages+0x178/0x194 (PC)
Apr 27 13:23:14.336856 (XEN)    [<000000000022a670>] 
alloc_xenheap_pages+0x170/0x194 (LR)
Apr 27 13:23:14.336886 (XEN)    [<0000000000237770>] _xmalloc+0x144/0x294
Apr 27 13:23:14.348773 (XEN)    [<00000000002378d4>] _xzalloc+0x14/0x30
Apr 27 13:23:14.348808 (XEN)    [<000000000027b4e4>] 
gicv3_lpi_init_rdist+0x54/0x324
Apr 27 13:23:14.348835 (XEN)    [<0000000000279898>] 
arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46c
Apr 27 13:23:14.360799 (XEN)    [<0000000000279bfc>] 
arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0x20/0x50
Apr 27 13:23:14.372796 (XEN)    [<0000000000277054>] 
gic_init_secondary_cpu+0x18/0x30
Apr 27 13:23:14.372829 (XEN)    [<0000000000284518>] 
start_secondary+0x1a8/0x234
Apr 27 13:23:14.372856 (XEN)    [<0000010722aa4200>] 0000010722aa4200
Apr 27 13:23:14.384793 (XEN)
Apr 27 13:23:14.384823 (XEN)
Apr 27 13:23:14.384845 (XEN) ****************************************
Apr 27 13:23:14.384869 (XEN) Panic on CPU 2:
Apr 27 13:23:14.384891 (XEN) Assertion '!in_irq() && 
(local_irq_is_enabled() || num_online_cpus() <= 1)' failed at 
common/page_alloc.c:2212
Apr 27 13:23:14.396805 (XEN) ****************************************

The GICv3 LPI code contains a few calls to xmalloc() that will be done 
while initializing the GIC CPU interface. I don't think we can delay the 
initialization of the LPI part past local_irq_enable(). So I think we 
will need to allocate the memory when preparing the CPU.

Any thoughts?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:15:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:15:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315315.533797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlGO-00076u-Gd; Wed, 27 Apr 2022 17:15:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315315.533797; Wed, 27 Apr 2022 17:15:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlGO-00076n-DV; Wed, 27 Apr 2022 17:15:40 +0000
Received: by outflank-mailman (input) for mailman id 315315;
 Wed, 27 Apr 2022 17:15:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njlGM-00076h-Ru
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 17:15:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlGM-0002kD-JC; Wed, 27 Apr 2022 17:15:38 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlGM-0000Lp-DB; Wed, 27 Apr 2022 17:15:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=dz4dbn3T1sjWaVu8fskGr2ocgzGZwh7MGqqS7N9SFmQ=; b=3ol0dSyOx8VQcCGrjx5zEOk3C1
	9afMnMgTzzHyBY60sE6SFfGenLV82LVKCmtKltFZkqk0WwJ13wFeEOJcPqVRv4bvDHs/yRPHQXBaU
	Md3xQwde/ZRXpn+2qGQmAcVRce5TCzmu9xvhoaQ3pNFahmiWSCn2TUQl4b7XF+w8pMC8=;
Message-ID: <2e348a81-08e0-0616-5a50-554a36704df6@xen.org>
Date: Wed, 27 Apr 2022 18:15:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH 1/8] xen/arm: bootfdt.c: Remove unused-but-set variable
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-2-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427094941.291554-2-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 27/04/2022 10:49, Michal Orzel wrote:
> Function device_tree_node_compatible defines and sets a variable
> mlen but does not make use of it. Remove this variable.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

> ---
>   xen/arch/arm/bootfdt.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index e318ef9603..29671c8df0 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -36,11 +36,8 @@ static bool __init device_tree_node_compatible(const void *fdt, int node,
>                                                  const char *match)
>   {
>       int len, l;
> -    int mlen;
>       const void *prop;
>   
> -    mlen = strlen(match);
> -
>       prop = fdt_getprop(fdt, node, "compatible", &len);
>       if ( prop == NULL )
>           return false;

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:17:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:17:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315321.533808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlID-0007hu-SC; Wed, 27 Apr 2022 17:17:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315321.533808; Wed, 27 Apr 2022 17:17:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlID-0007hn-P3; Wed, 27 Apr 2022 17:17:33 +0000
Received: by outflank-mailman (input) for mailman id 315321;
 Wed, 27 Apr 2022 17:17:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njlID-0007hh-0n
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 17:17:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlIC-0002lz-P5; Wed, 27 Apr 2022 17:17:32 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlIC-0000P3-JH; Wed, 27 Apr 2022 17:17:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=6MsSlH1KHgCDsJSjtF1avVUqRH+NgHJZe36m1UHeR80=; b=U65Sh2h2xamHJweGMzNYNNonaj
	qNxAxZTwMe2piKTxGxH4Z4gGYQYqoOkGOG2RWLTUZN9UtWMB7Fur/a4mK0SV610wDkStggiZ57N3d
	utmu9EVjbjfR/MZha0rAiVm/zBj59b5V2z/TsEmbDkTSegumtqAqmJctZQqA39wOzTj0=;
Message-ID: <b2a243a5-1a72-3307-1059-a54462ad73d0@xen.org>
Date: Wed, 27 Apr 2022 18:17:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH 4/8] xen/arm: smmu.c: Remove unused-but-set variable
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-5-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427094941.291554-5-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 27/04/2022 10:49, Michal Orzel wrote:
> Function arm_smmu_init_context_bank defines and sets a variable
> gr0_base but does not make use of it. Remove this variable.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:19:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:19:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315326.533819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlJm-0008IS-7e; Wed, 27 Apr 2022 17:19:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315326.533819; Wed, 27 Apr 2022 17:19:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlJm-0008IL-42; Wed, 27 Apr 2022 17:19:10 +0000
Received: by outflank-mailman (input) for mailman id 315326;
 Wed, 27 Apr 2022 17:19:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njlJk-0008I9-V3
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 17:19:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlJk-0002ol-Pf; Wed, 27 Apr 2022 17:19:08 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlJk-0000Ts-Jx; Wed, 27 Apr 2022 17:19:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=k+6a+z6IqYqkH03u6mNqqrKzgFosx49vDXG5+Q+pI7w=; b=QM6cEM8fkOAi4hPQ8CPzj6M8++
	T863d4PYw5W23VS56OqrKr3IbwdOHAeu5oGpRJZp0h/q2GA9jql2bb3wQ5Fczut7qMRoxNEmu5sJB
	+Hkz2uPlgje+SICTMX5J6079Gv1x54PxV4eovsiEN4morHuKFVHF/N4i0SxH2aVWLS+8=;
Message-ID: <e5f20ce6-ff7b-0877-c607-965abb68fbd2@xen.org>
Date: Wed, 27 Apr 2022 18:19:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH 6/8] platforms/xgene: Make use of dt_device_get_address
 return value
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-7-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427094941.291554-7-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/04/2022 10:49, Michal Orzel wrote:
> Currently function xgene_check_pirq_eoi assignes a return value of
Typo: s/assignes/assigns/ also I think s/a return/the return/

> dt_device_get_address to a variable res but does not make use of it.
> Fix it by making use of res in a condition checking the result of a

Typo: s/a condition/the condition/ I think.

> call to dt_device_get_address instead of checking the address
> stored in dbase.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
>   xen/arch/arm/platforms/xgene-storm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c
> index fced4d7c2c..befd0c3c2d 100644
> --- a/xen/arch/arm/platforms/xgene-storm.c
> +++ b/xen/arch/arm/platforms/xgene-storm.c
> @@ -51,7 +51,7 @@ static void __init xgene_check_pirq_eoi(void)
>           panic("%s: Can not find interrupt controller node\n", __func__);
>   
>       res = dt_device_get_address(node, 0, &dbase, NULL);
> -    if ( !dbase )
> +    if ( res )
>           panic("%s: Cannot find a valid address for the distributor\n", __func__);
>   
>       /*

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:20:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:20:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315333.533830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlLO-0001E4-J1; Wed, 27 Apr 2022 17:20:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315333.533830; Wed, 27 Apr 2022 17:20:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlLO-0001Dx-Fn; Wed, 27 Apr 2022 17:20:50 +0000
Received: by outflank-mailman (input) for mailman id 315333;
 Wed, 27 Apr 2022 17:20:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njlLN-0001Dn-59
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 17:20:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlLM-0002qO-R4; Wed, 27 Apr 2022 17:20:48 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlLM-0000Xn-Kg; Wed, 27 Apr 2022 17:20:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=XX/zrz1j2QLKRE2okFeGt9K2nh4J+RrtyptQ0NcHnZk=; b=a3PmdlUD2uOEymaQNa+cwL8RVm
	e+Wnv0EX7+UHQJQ05OBDSsSYQf7VA0CiADzmA6S/yLfdlWkrU2zj+ci0OrBwtT7WV9oAj/RxMnB7n
	r5jJzSEbMMxRBYF3edPhf4yUbfpiNg+oUpRBtdXmfxDG+hXQTa64bEwWBDe2wZ+sGdPk=;
Message-ID: <43ed32c2-b3fb-02ef-74e2-5815b21b5918@xen.org>
Date: Wed, 27 Apr 2022 18:20:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH 7/8] platforms/omap: Remove unused-but-set variable
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-8-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427094941.291554-8-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/04/2022 10:49, Michal Orzel wrote:
> Function omap5_init_time defines and sets a variable den but does not

s/a/the/ I think

> make use of it. Remove this variable.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:26:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:26:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315339.533840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlRB-0001v1-7R; Wed, 27 Apr 2022 17:26:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315339.533840; Wed, 27 Apr 2022 17:26:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlRB-0001uu-4T; Wed, 27 Apr 2022 17:26:49 +0000
Received: by outflank-mailman (input) for mailman id 315339;
 Wed, 27 Apr 2022 17:26:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njlRA-0001uo-2y
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 17:26:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlR9-0002wF-RN; Wed, 27 Apr 2022 17:26:47 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlR9-0000xS-LM; Wed, 27 Apr 2022 17:26:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=G/4lWYJrNfdUOGm/ldMF2kSuDkwr86rwdEE+I/9K1i0=; b=A7P48e++gjFwc2rRTxzmBoGoaO
	PvvsShBJ9HYgU0EveqwMJkfDpBVtP8uTtGiGxfU8amYuux2Z09RQMLOvB2CXeLoiJ/HIcn9aZCbYf
	QAOfXJne4gLJKnEAnK6GaazUCC/ahgSmzRKZRfW2wD6tvIdJxKPhZym6GMGWdYm4HtdY=;
Message-ID: <ce7b7364-553f-29b7-2cab-644930f4e143@xen.org>
Date: Wed, 27 Apr 2022 18:26:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH 8/8] drivers/exynos4210: Remove unused-but-set variable
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-9-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220427094941.291554-9-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/04/2022 10:49, Michal Orzel wrote:
> Function exynos4210_uart_init_preirq defines and sets a variable
> divisor but does not make use of it. Remove the definition and comment
> out the assignment as this function already has some TODOs.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
> Commenting out a code is a bad practise as well as using TODOs.

I disagree, having TODOs in the code is useful to track issues that are 
not critical or necessary to update the support state.

> However the only alternative would be to get rid of divisor variable
> and TODO comments. I'm open for solutions.

I am not overly happy with commented code, but I prefer it over removing 
the TODOs comment as you wouldn't address them and the issues are not fixed.

So for this patch:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:42:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:42:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315345.533851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlgV-0004Ck-Il; Wed, 27 Apr 2022 17:42:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315345.533851; Wed, 27 Apr 2022 17:42:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlgV-0004Cd-Fq; Wed, 27 Apr 2022 17:42:39 +0000
Received: by outflank-mailman (input) for mailman id 315345;
 Wed, 27 Apr 2022 17:42:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njlgT-0004CX-Mt
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 17:42:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlgT-0003CC-7c; Wed, 27 Apr 2022 17:42:37 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlgT-000293-1Y; Wed, 27 Apr 2022 17:42:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ne/X0zk45QcRzwkhQqLIg+WefE/eqhKLkWfYqAnfwtA=; b=C6uy1phy/SoyqmfELC1F6IfgON
	VrwdW9uF7FnAouiTYFIFrfXt9mbXHsauCDo3TggvllucbQ/bZnb+CYwhiphfoIKOzoZgr2mR4AIFn
	FCRRC8URpDdN6oTaY3Pe1JYDMsiojp81I52KB2U8hESXOy+ER0hswUUZelqWQS+I47UQ=;
Message-ID: <0c6fd5db-ffc7-893a-1ad0-d54f3974a45a@xen.org>
Date: Wed, 27 Apr 2022 18:42:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a
 device
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <a19f7238f428deb610df643944f60e1e79e273cf.1651075797.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <a19f7238f428deb610df643944f60e1e79e273cf.1651075797.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 27/04/2022 17:15, Rahul Singh wrote:
> When a device is deassigned from the domain it is required to remove the
> iommu group.

This read wrong to me. We should not need to re-create the IOMMU group 
(and call arm_smmu_add_device()) every time a device is re-assigned.

> 
> If we don't remove the group, the next time when we assign
> a device, SME and S2CR will not be setup correctly for the device
> because of that SMMU fault will be observed.

I think this is a bug fix for 0435784cc75dcfef3b5f59c29deb1dbb84265ddb. 
If so, please add a Fixes tag.

> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>   xen/drivers/passthrough/arm/smmu.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
> index 5cacb2dd99..9a31c332d0 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -1690,6 +1690,8 @@ static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev)
>   	if (cfg)
>   		arm_smmu_master_free_smes(cfg);
>   
> +	iommu_group_put(dev_iommu_group(dev));
> +	dev_iommu_group(dev) = NULL;
>   }

The goal of arm_smmu_detach_dev() is to revert the change made in 
arm_smmu_attach_dev(). But looking at the code, neither the IOMMU group 
nor the smes are allocated in arm_smmu_attach_dev().

Are the SMES meant to be re-allocated everytime we assign to a different 
domain? If yes, the allocation should be done in arm_smmu_attach_dev().

If not, then we should not free the SMES here

IIUC, the SMES have to be re-allocated every time a device is assigned. 
Therefore, I think we should move the call to 
arm_smmu_master_alloc_smes() out of the detach callback and in a helper 
that would be used when removing a device (not yet supported by Xen).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:47:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:47:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315352.533863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njll3-0004uD-AN; Wed, 27 Apr 2022 17:47:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315352.533863; Wed, 27 Apr 2022 17:47:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njll3-0004u6-7F; Wed, 27 Apr 2022 17:47:21 +0000
Received: by outflank-mailman (input) for mailman id 315352;
 Wed, 27 Apr 2022 17:47:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njll1-0004tw-Nc; Wed, 27 Apr 2022 17:47:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njll1-0003Hg-Mn; Wed, 27 Apr 2022 17:47:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njll1-0004rp-4f; Wed, 27 Apr 2022 17:47:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njll1-0001lY-4F; Wed, 27 Apr 2022 17:47:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NW7k+1znNLV3vk7lbRX7gBg1I4GDmZPSg2KAZST5ODE=; b=Z1nJlS4sDwQORbM7hhEEGgFz8x
	9ewTy07p1XIOPh+HgLZAzblj/Tab2l7x6KN8viKStMobtNjlczM6TiqyJyxYEZcCfIZ4uem+5pkZ+
	2z4p/OrE4fv5/WqrEz2w8jAUEmf0fpYzygWZzUi9Pdr0joxTbDteEettXvC3OnRC+jgY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169786-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169786: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 17:47:19 +0000

flight 169786 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169786/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  664 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   36 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 17:59:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 17:59:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315362.533880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlx5-0006Q6-GF; Wed, 27 Apr 2022 17:59:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315362.533880; Wed, 27 Apr 2022 17:59:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njlx5-0006Pz-DO; Wed, 27 Apr 2022 17:59:47 +0000
Received: by outflank-mailman (input) for mailman id 315362;
 Wed, 27 Apr 2022 17:59:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njlx4-0006Pt-FU
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 17:59:46 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlx4-0003V8-2l; Wed, 27 Apr 2022 17:59:46 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njlx3-0003HO-TG; Wed, 27 Apr 2022 17:59:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=zpowA/N27QqR0UQ34YRsqGoaNmzeDHr8vK0TiteJl4I=; b=p9I982PpARNn3KUvi1AlR3JwVo
	uEfCkQysR8rO23BqzyRg3x5ALYEDtwcwxXc5B/f/FZyHHIzx8kSEFBsj4NC2sqekjMvJzPXs2CChB
	sYBzdvFCrpWE2mZfh3BATuKovuzQmE9HdNKHmDVd8ul1VHlcMVkd6hB+g1NxRRCtHj7E=;
Message-ID: <a2bba079-0a26-8648-6f39-93148dbd5107@xen.org>
Date: Wed, 27 Apr 2022 18:59:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Rahul,

On 27/04/2022 17:14, Rahul Singh wrote:
> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are

Looking at the spec (ARM IHI 0069H), I can't find a command error named 
MAPC_LPI_OFF. Is it something specific to your HW?

> not enabled before mapping the collection table using MAPC command.
> 
> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection
> table.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>   xen/arch/arm/gic-v3.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 3c472ed768..8fb0014b16 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void)
>       /* If the host has any ITSes, enable LPIs now. */
>       if ( gicv3_its_host_has_its() )
>       {
> +        if ( !gicv3_enable_lpis() )
> +            return -EBUSY;
>           ret = gicv3_its_setup_collection(smp_processor_id());
>           if ( ret )
>               return ret;
> -        if ( !gicv3_enable_lpis() )
> -            return -EBUSY;

AFAICT, Linux is using the same ordering as your are proposing. It seems 
to have been introduced from the start, so it is not clear why we chose 
this approach.

However, given this works on some HW, can you clarify whether this is 
mandated by the spec or this is a bug in your HW?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 18:03:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 18:03:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315368.533891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njm15-00080W-1U; Wed, 27 Apr 2022 18:03:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315368.533891; Wed, 27 Apr 2022 18:03:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njm14-00080P-Uh; Wed, 27 Apr 2022 18:03:54 +0000
Received: by outflank-mailman (input) for mailman id 315368;
 Wed, 27 Apr 2022 18:03:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8dk3=VF=citrix.com=prvs=109ad7ccf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njm13-00080J-DH
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 18:03:53 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63c79712-c654-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 20:03:51 +0200 (CEST)
Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Apr 2022 14:03:46 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM6PR03MB3946.namprd03.prod.outlook.com (2603:10b6:5:48::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr
 2022 18:03:42 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 18:03:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63c79712-c654-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651082631;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=4/xXnZrT2P5saFsPgvZKuPcLIfigjqJ+KiYXcZ7HJ5I=;
  b=U/t3adGCATUwMzpWqHgZRGXcC6pv/pcUUnS9GoK+R2myFckFQdpcfQ+9
   GgjA1R1uBDFh65hd16iS/UEeNqWte+YQNz2zsOOiGa7CfCEebPWXNvJLn
   quMxTfPB1xZKCv9x3zgVK2aMdF4wGnQwRTEaxe8XH4L2RF/+doDVuD4U8
   4=;
X-IronPort-RemoteIP: 104.47.70.104
X-IronPort-MID: 69467497
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:TyCad6vTdOMxMpgrV4oJdgNDwufnVHNfMUV32f8akzHdYApBsoF/q
 tZmKT2AbKuPNjHzL9p2a9m+90kP6sPXytZjHQdpri8yFHhG+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X5
 ouryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8UO6/ioeUecCBkOCxmL59a1uDGYiSw5Jn7I03uKxMAwt1IJWRvZcgy3LkyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4AAmm5o2qiiHt6HD
 yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvTmPklMtgeeF3Nz9fPfRG9wEsh6kt
 jie3mPFHhwEDtmQ1m/Qmp6rrqqV9c/hY6oeCqex/PNuqFaawHAaAlsQWEfTiem0jAuyVsxSL
 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sZiFFQMwrsokxXzNC/
 lOXhdrjCDhHubicW3WbsLyT6y6xURX5NkcHbC4ACAEDvN/qpdhrigqVF44/VqmoktfyBDf8h
 SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTxgbQHxZ6s9Lqkc2Q=
IronPort-HdrOrdr: A9a23:14Rz+6mpAjnjIvrV4wbZbXiDqxXpDfLW3DAbv31ZSRFFG/Fw9/
 rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM
 xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv
 Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
X-IronPort-AV: E=Sophos;i="5.90,293,1643691600"; 
   d="scan'208";a="69467497"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MxKxBBZf75uWYVsD1dPur2gQJTudUljVdD1kCiJ0/hgQdl6tGqaf6tzhYMZUs7SAuRX73QyFbB47G33CRJzkAWeObetHbfe9loa1g6pJawcgDk5HFVVjdEWHbztHEzqbGNknaM9oyuzd728Twv7JYjoaXHyNvI4kEVmmFAidfwhNLvLgpSv7guyhcquZFg+JlxnK54MJFp9bMnM+MIouJtf117Nelz/+PP8fYDGdYPAfVtBy7BpYGY2LoCV9m0uWa1hcoNYvfMcazNVi0IY9VHuQ8x3BvvrRRyDizvsY9cEOzRNg+GCXcebMejPmcvMy2tdByVRejXDdZunOzKax0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4/xXnZrT2P5saFsPgvZKuPcLIfigjqJ+KiYXcZ7HJ5I=;
 b=CShnquIyHZp7/7mWA0K7yiP8yIdhZMj9LTaFzpg3kXOThq8JdBXsTkVokb3rfcH+A/SIrxDBqpfD+hRj3C20p1lgTXfzwldaQz0d+btxd+rUwRNqZTEaKa5QZKZE2FCHgCICCGniaBYDuyTKFRySVypyM5E+ttzLDIemspksIsNZRxJ/FlyLhFbvn/gNUIIa6RKWb6d+5NE0Z55fF2EU3DGwm7xJJWKiyiwen2v73BmOWJ3j6OAJ1Y4dheNIzT08hUlcFKNWy0IQ6EttaQGLjU8zFySLy0D2CECTp22wn4rLoCxv0STlyztKLSG4pL9KehWp/tEKz0s+xDBqquLBKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4/xXnZrT2P5saFsPgvZKuPcLIfigjqJ+KiYXcZ7HJ5I=;
 b=sX2KERvESQEXjXAgHgwxLoPO81G3Yacega/q5x/EZB82dqV5/siadCVWNYjPzZ+Q/CE1hzT4K8R3LK/h4+JL/wb0ev69cFtuCPvklfOJJcWuSW7c/prSRbDhgxvKZZUwaGiya839RNi3t7GweRpftYKJHoc/demwPOy7DGI6/yo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: David Vrabel <dvrabel@cantab.net>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, David Vrabel <dvrabel@amazon.co.uk>
Subject: Regression with CET: [PATCH v1] x86/mm: avoid inadvertently degrading
 a TLB flush to local only
Thread-Topic: Regression with CET: [PATCH v1] x86/mm: avoid inadvertently
 degrading a TLB flush to local only
Thread-Index: AQHYU/6tz3jdg/qffEGRsGMfdOOu1q0EGkOA
Date: Wed, 27 Apr 2022 18:03:42 +0000
Message-ID: <6076f458-a56f-448b-2001-6af38b998edb@citrix.com>
References: <20220419150320.64783-1-dvrabel@cantab.net>
In-Reply-To: <20220419150320.64783-1-dvrabel@cantab.net>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ed6e3109-2db9-45f3-ddae-08da287843a1
x-ms-traffictypediagnostic: DM6PR03MB3946:EE_
x-microsoft-antispam-prvs:
 <DM6PR03MB394680DCCED66673F7A6C9D7BAFA9@DM6PR03MB3946.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 iVAGEKTs7p+LR6fXUnfVOZ0LI+p4zqEJbOYDBivnXuix1gJ04p3HGGAsj7aJJ+DsT6QlNiUX43HGnnge4g7qIO2sTzQ2zrYmV6R1S6cWARTS8QorFXtlp6Uk89o8gFIl+kLW5DgtDc4II8vD1r/XOM7tH/HMR7dQsK0Mn9fEpZlqfBRSoDh3yQoxblceBVq2us1y7hpr+mQhP0mVRRPJajmi15mze7RjCGiRevQuF4FImW84EI1MOtCGnDYNNGzSimIjgen45QXLHfXRh35slUeBzVkmovRDhpLqP4zsaIcfi9RuqNvznOfP5QS/P8FLB6EeqfiedDqVT+T8L0YIktPoQA20SUr1p3MfI4sh/2EPZlwG6c1lpSdA6vh/I7KNrs+OWs2qAjrcSnjC5fEGWA85qmMdXjEwWXKsHDZ8VsT1MsHbkAUVMLzyJrMzxplMyu5Ndc1lBxeZMoQNrgs6xUAD8kVaj/14h+bO9EObZ+sE7Til/jodQgJ7K6tlrBWlC55r3V6ilda7pdTdPhhEEPYoY1sP1CnO1b6/DlFni14VYLMJhrn0QTmZ7Dc7cayP3Cs4oThR7q3Xxj83mAtOda3ZaD5eDb52dAUDK9IqAG/ZcDzOvHkD9/0aPdkaSGmr5KMctYkdK1DazfC2NeYfnKy2HjzNUT2C4Yyxjh0kCCixeFH6oIW+UshYMo4xj69S4prJX46mU6oQRg3TqRGutegMMbtwAiayvVeez5TVRtU/FkvZacLKA3ckoHRlWfaP8fIyqf1PSUwxVsxIOObBjg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(316002)(2906002)(86362001)(31696002)(5660300002)(8936002)(4326008)(8676002)(76116006)(66946007)(66556008)(66476007)(122000001)(38070700005)(64756008)(66446008)(82960400001)(83380400001)(2616005)(6512007)(91956017)(26005)(186003)(53546011)(6506007)(110136005)(71200400001)(54906003)(508600001)(6486002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?SElYak1YYTkzWENsR0RTN0RLTXZZdlpQOUt5N3lqRXZJTCt5aFdWT3QydmJQ?=
 =?utf-8?B?aERpK0lGdmdqUVFnejlJRmI4U3FUVkpTeW14U2dCMzh1WTJMYjVMTWc5Rzhn?=
 =?utf-8?B?aFVIaG1RaFNsbVdDQVhZUWxFeWJSV216NkNQRFNKOHpkWGR6UEdSOStlSTYy?=
 =?utf-8?B?UFNKZzh3K0pZSTIrTFRiQTFDVmRtTm96OHJqRmN2OS9lZEN5WGp4M0NiRGxt?=
 =?utf-8?B?TWJhdC9xN012R0YyY1NwSVZCU3ZlWFJMOERyUzdYU3l3Z1pTSEY2SEJ6cEdy?=
 =?utf-8?B?alhCR2NyZUVJSWFZZkZNMmszZlBQNDJ2MWJvTE1JZFJVUFA4RmUvb3dGeVds?=
 =?utf-8?B?dDhuQi9rTi9WVjFQZmF3VXBwU0V3d1VhZjJYMGt5TFNCME5hejJSVWZ5R29H?=
 =?utf-8?B?Y2tMZnpjQzg3cllLVGZiMGtiMFJyWTN0TU9GVzU2ZmV0WGVYemdZalhkWnJp?=
 =?utf-8?B?Z0dpZGUyZmVtdUxHT01Pam1Wb2xnaEdMZTFXbm9KK1I3UzR3b0xISXdsODlO?=
 =?utf-8?B?RkJhNDU0ZndaL0F0NHZva0dPM3NBdm01UTlWSWVETUxabFY3Sk4wd0UydXdR?=
 =?utf-8?B?ZmtBdnNYT2ozaW1FdTZIN2xNTmw2VDRGYTZBM28rVXdxRWw5QkJlc1kxUGZ3?=
 =?utf-8?B?cVd4clppaC9jdzd2VjZvbnBQcTBhQWVaSlJXNGlqZUhBWUorTE9NOTlYMHhu?=
 =?utf-8?B?U0RyaGlaTHRpQVNmNks2WXZMZEY5QVVNUDU0OHdMZnFUY0h0UEZuNlZUWDhy?=
 =?utf-8?B?SVZSU3FsRlA3QnlkQ3IzOWJRL0ZaUkJvMEdaSmFURlVrTGFrWXFpME84dm1t?=
 =?utf-8?B?TDB2RDIveDU1THYyUHRNMktUbmZvS3NGUEVvSkw5MEFrRGNJelB3WCt3SUZ5?=
 =?utf-8?B?bEZmSFk0MVg5SGtxR0NocDAvYktYcU1JOStXVUxTS3JlZGt4QjNmdVBNN2xr?=
 =?utf-8?B?MUZDU2l2Y0xYQUJ6NG1ISlRTUmdUUnE3V0hvNlNFNHRMMERyRXJpS1YyQUlZ?=
 =?utf-8?B?OTVsMC8wWFRpbWNLWjQ5ZEJjTzFoM1k2N0FYQlJ1bWdISlVNcmdsWTZMcTBN?=
 =?utf-8?B?UHRRaHdpeUxFbkpHSGxIdklPUGxVUDNLdndOVkZYUlRtS253SjNWRE8xMGlk?=
 =?utf-8?B?UVNSdk9NcGV6c1d2ZVBSUDdBSE1QdjhpMXF2ZEd2em43ajUwaDBvWmROTkcv?=
 =?utf-8?B?RHcycjZLUzkySm16aW10dDdrT2JENjlST256SmdWTlNmYTloQzJxS0pJdklF?=
 =?utf-8?B?dUFsK1Zrd0crb2VmbWZWcE02V3dPbjhuTWJKb0RxVWtxZ2l1NWUyYXpySElM?=
 =?utf-8?B?RXZtaTN2ZlU4c2V5UGhmWTJRSGdoVEVKODY2T1owUzRtcEZpY1VpUm84eXI5?=
 =?utf-8?B?RDNLK3VaWGgrMDE2MWNaUzMzSmloQlRaLzU4MnR1eUVSSW5SZ3RSRkRWT0Fn?=
 =?utf-8?B?RFR6YWk2V2g3czE2a1hJbXhqSzRMVWhQZ1Nzc1Q2eU9ZMkFJYzFubVozRDRj?=
 =?utf-8?B?Q3Y4Ujg2eUgvZHltUkx4WVhjbkFha0wrOXJNazUvYkk3OWhBOW41akJuOFBD?=
 =?utf-8?B?UnFUcTdid3BhODJSd2NNQmR1SnBjTU1ZdU4xYWkzOEJ1MXR6NFBIQ1ZFWGdr?=
 =?utf-8?B?Q2UxeSs5MnlqK2U0UWdhU0ZVZFFqWkpOQ1ArdWhZc29GWm42VFNQT2pUL000?=
 =?utf-8?B?SkcwNFFkQ0Roejd2S3pQU1BMMXVyU3hZRjZBcVVnRUNIU3VLWEtBY1M3K2Vn?=
 =?utf-8?B?UkFnSGNVQURDUW1wR1N2MGdJUUxkRHB6RUpTV3FTM25HcG51RERsendEdzE3?=
 =?utf-8?B?OWo5Y2VKdko3Syt6RTJVWEl0MEwzNEIxSVhxZ1BUVWkxWStWcWNUMW5YaWdo?=
 =?utf-8?B?OWhNUkVvbDNKSS9wN0tIeU5SNVJrTFFpVk5iZzFQQWdKS1doMW54OUkzYmo2?=
 =?utf-8?B?eHFHK1kzUC90OGJVVVJ2S205eU9QeGdiUzFUaVR2aTMvVGxQN1MvOUhGb2Nv?=
 =?utf-8?B?Y1ZIZkZWcjVWT25ia3JUcW41NExEaFFMOERDazRnaXNzZGJnV0wrRFFBMzBy?=
 =?utf-8?B?MkZrNzhmU21RRm4wL1BqbCtVaitpY0x3RTdYdFpNdlRzRWpKeXI2dUpNWmw3?=
 =?utf-8?B?M1Z0TUxWSW8vTk0rektwVmVxcklCdStrS3JqcTBTVGp5SFp3M1dicW9TdkNF?=
 =?utf-8?B?cVZNUFp4a2FPaTU0b3pKWHUzNzRadGZQWUZjU1lFSHlrTHFaS2hHdFVXK1hX?=
 =?utf-8?B?clJJbHo2UW5uVi9OQlcrNnpuall5TWt5ZndmN2pVYitKcTlxWEF1K2ZOdkRx?=
 =?utf-8?B?cWVqRlNQblFaU1dheEMzRmZ1QzJncnNLUWNNcUx5dzBuUzZaR3o4VzVDUDNX?=
 =?utf-8?Q?aLDAoRWtn7Bz56pU=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B8ABA3647D1BC84DAFD7177029A0D038@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed6e3109-2db9-45f3-ddae-08da287843a1
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 18:03:42.1902
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: K6WCHJBuapRwto2QLg6zELHkYB7+RVslLrHHM62Vz7pe/JLVNKK6j1aa8TyHUH1gmY5yVOzd1AHAQpzZ0eNSYs4rUrYaWeJ8Xu8Nh66PTKs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3946

T24gMTkvMDQvMjAyMiAxNjowMywgRGF2aWQgVnJhYmVsIHdyb3RlOg0KPiBGcm9tOiBEYXZpZCBW
cmFiZWwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPg0KPg0KPiBJZiB0aGUgZGlyZWN0IG1hcCBpcyBp
bmNvcnJlY3RseSBtb2RpZmllZCB3aXRoIGludGVycnVwdHMgZGlzYWJsZWQsDQo+IHRoZSByZXF1
aXJlZCBUTEIgZmx1c2hlcyBhcmUgZGVncmFkZWQgdG8gZmx1c2hpbmcgdGhlIGxvY2FsIENQVSBv
bmx5Lg0KPg0KPiBUaGlzIGNvdWxkIGxlYWQgdG8gdmVyeSBoYXJkIHRvIGRpYWdub3NlIHByb2Js
ZW1zIGFzIGRpZmZlcmVudCBDUFVzIHdpbGwNCj4gZW5kIHVwIHdpdGggZGlmZmVyZW50IHZpZXdz
IG9mIG1lbW9yeS4gQWx0aG91Z2gsIG5vIHN1Y2ggaXNzdWVzIGhhdmUgeWV0DQo+IGJlZW4gaWRl
bnRpZmllZC4NCj4NCj4gQ2hhbmdlIHRoZSBjaGVjayBpbiB0aGUgZmx1c2hfYXJlYSgpIG1hY3Jv
IHRvIGxvb2sgYXQgc3lzdGVtX3N0YXRlDQo+IGluc3RlYWQuIFRoaXMgZGVmZXJzIHRoZSBzd2l0
Y2ggZnJvbSBsb2NhbCB0byBhbGwgbGF0ZXIgaW4gdGhlIGJvb3QNCj4gKHNlZSB4ZW4vYXJjaC94
ODYvc2V0dXAuYzpfX3N0YXJ0X3hlbigpKS4gVGhpcyBpcyBmaW5lIGJlY2F1c2UNCj4gYWRkaXRp
b25hbCBQQ1BVcyBhcmUgbm90IGJyb3VnaHQgdXAgdW50aWwgYWZ0ZXIgdGhlIHN5c3RlbSBzdGF0
ZSBpcw0KPiBTWVNfU1RBVEVfc21wX2Jvb3QuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IERhdmlkIFZy
YWJlbCA8ZHZyYWJlbEBhbWF6b24uY28udWs+DQoNClRoaXMgZXhwbG9kZXMgb24gQ0VUIHN5c3Rl
bXM6DQoNCihYRU4pIEFzc2VydGlvbiAnbG9jYWxfaXJxX2lzX2VuYWJsZWQoKScgZmFpbGVkIGF0
IGFyY2gveDg2L3NtcC5jOjI2NQ0KKFhFTikgLS0tLVsgWGVuLTQuMTcuMC0xMC4yNC1kwqAgeDg2
XzY0wqAgZGVidWc9ecKgIE5vdCB0YWludGVkIF0tLS0tDQooWEVOKSBDUFU6wqDCoMKgIDANCihY
RU4pIFJJUDrCoMKgwqAgZTAwODpbPGZmZmY4MmQwNDAzNDUzMDA+XSBmbHVzaF9hcmVhX21hc2sr
MHg0MC8weDEzZQ0KPHNuaXA+DQooWEVOKSBYZW4gY2FsbCB0cmFjZToNCihYRU4pwqDCoMKgIFs8
ZmZmZjgyZDA0MDM0NTMwMD5dIFIgZmx1c2hfYXJlYV9tYXNrKzB4NDAvMHgxM2UNCihYRU4pwqDC
oMKgIFs8ZmZmZjgyZDA0MDMzOGE0MD5dIEYgbW9kaWZ5X3hlbl9tYXBwaW5ncysweGM1LzB4OTU4
DQooWEVOKcKgwqDCoCBbPGZmZmY4MmQwNDA0NDc0Zjk+XSBGDQphcmNoL3g4Ni9hbHRlcm5hdGl2
ZS5jI19hbHRlcm5hdGl2ZV9pbnN0cnVjdGlvbnMrMHhiNy8weGI5DQooWEVOKcKgwqDCoCBbPGZm
ZmY4MmQwNDA0NDc2Y2M+XSBGIGFsdGVybmF0aXZlX2JyYW5jaGVzKzB4Zi8weDEyDQooWEVOKcKg
wqDCoCBbPGZmZmY4MmQwNDA0NGUzN2Q+XSBGIF9fc3RhcnRfeGVuKzB4MWVmNC8weDI3NzYNCihY
RU4pwqDCoMKgIFs8ZmZmZjgyZDA0MDIwMzM0ND5dIEYgX19oaWdoX3N0YXJ0KzB4OTQvMHhhMA0K
KFhFTikNCihYRU4pDQooWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqDQooWEVOKSBQYW5pYyBvbiBDUFUgMDoNCihYRU4pIEFzc2VydGlvbiAnbG9jYWxfaXJxX2lz
X2VuYWJsZWQoKScgZmFpbGVkIGF0IGFyY2gveDg2L3NtcC5jOjI2NQ0KKFhFTikgKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKg0KKFhFTikNCg0KV2UgcmVhbGx5IGRpZCB3
YW50IGEgbG9jYWwtb25seSBmbHVzaCBoZXJlLCBiZWNhdXNlIHdlIHNwZWNpZmljYWxseQ0KaW50
ZW5kZWQgdG8gbWFrZSBzZWxmLW1vZGlmeWluZyBjaGFuZ2VzIGJlZm9yZSBicmluZ2luZyBzZWNv
bmRhcnkgQ1BVcyB1cC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 18:27:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 18:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315375.533901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njmN7-0001yP-TV; Wed, 27 Apr 2022 18:26:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315375.533901; Wed, 27 Apr 2022 18:26:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njmN7-0001yI-QP; Wed, 27 Apr 2022 18:26:41 +0000
Received: by outflank-mailman (input) for mailman id 315375;
 Wed, 27 Apr 2022 18:26:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njmN6-0001yC-PR
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 18:26:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njmN6-00041q-8M; Wed, 27 Apr 2022 18:26:40 +0000
Received: from [54.239.6.186] (helo=[192.168.24.58])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njmN6-0004w6-25; Wed, 27 Apr 2022 18:26:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=BkWPeO/X0Bd8Q1E+X1y5lZAXpa/TmLegk57P3zKxrvM=; b=4OsOf9ybO3BsE1f4+N+flQ5nRx
	pCIKckvVG4KMU6YxTzX+Mc6qxSaE3OLmhXxO/LuEEYRCLPP3Nacy5Qb7vjyYT3wEiAirihpxCgSY6
	ext4rk1C0zHv0xazAMbnVktyq4xx6OLbVRj1YhN2BaRmMRUcjst3gJOW+REeOsccZSYw=;
Message-ID: <c3b83cd4-7633-7aee-ab40-9eff26a4f801@xen.org>
Date: Wed, 27 Apr 2022 19:26:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH] arm/acpi: don't expose the ACPI IORT SMMUv3 entry to dom0
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <e11c57909782c60a6914d81e9c9893ff1712cc5b.1651075724.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e11c57909782c60a6914d81e9c9893ff1712cc5b.1651075724.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Rahul,

On 27/04/2022 17:12, Rahul Singh wrote:
> Xen should control the SMMUv3 devices therefore, don't expose the
> SMMUv3 devices to dom0. Deny iomem access to SMMUv3 address space for
> dom0 and also make ACPI IORT SMMUv3 node type to 0xff.

Looking at the IORT spec (ARM DEN 0049E), 255 (0xff) is marked as 
reserved. So I don't think we can "allocate" 0xff to mean invalid 
without updating the spec. Did you engage with whoever own the spec?

> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>   xen/arch/arm/acpi/domain_build.c | 40 ++++++++++++++++++++++++++++++++
>   1 file changed, 40 insertions(+)
> 
> diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c
> index bbdc90f92c..ec0b5b261f 100644
> --- a/xen/arch/arm/acpi/domain_build.c
> +++ b/xen/arch/arm/acpi/domain_build.c
> @@ -14,6 +14,7 @@
>   #include <xen/acpi.h>
>   #include <xen/event.h>
>   #include <xen/iocap.h>
> +#include <xen/sizes.h>
>   #include <xen/device_tree.h>
>   #include <xen/libfdt/libfdt.h>
>   #include <acpi/actables.h>
> @@ -30,6 +31,7 @@ static int __init acpi_iomem_deny_access(struct domain *d)
>   {
>       acpi_status status;
>       struct acpi_table_spcr *spcr = NULL;
> +    struct acpi_table_iort *iort;
>       unsigned long mfn;
>       int rc;
>   
> @@ -55,6 +57,44 @@ static int __init acpi_iomem_deny_access(struct domain *d)
>           printk("Failed to get SPCR table, Xen console may be unavailable\n");
>       }
>   
> +    status = acpi_get_table(ACPI_SIG_IORT, 0,
> +                            (struct acpi_table_header **)&iort);

At some point we will need to add support to hide the ARM SMMU device 
and possibly some devices. So I think it would be better to create a 
function that would deal with the IORT.

> +
> +    if ( ACPI_SUCCESS(status) )
> +    {
> +        int i;

Please use unsigned int.

> +        struct acpi_iort_node *node, *end;

Coding style: Please add a newline.

> +        node = ACPI_ADD_PTR(struct acpi_iort_node, iort, iort->node_offset);
> +        end = ACPI_ADD_PTR(struct acpi_iort_node, iort, iort->header.length);
> +
> +        for ( i = 0; i < iort->node_count; i++ )
> +        {
> +            if ( node >= end )

Wouldn't this only happen if the table is somehow corrupted? If so, I 
think we should print an error (or even panic).

> +                break;
> +
> +            switch ( node->type )
> +            {
> +                case ACPI_IORT_NODE_SMMU_V3:

Coding style: The keyword "case" should be aligned the the start of the 
keyword "switch".

> +                {
> +                    struct acpi_iort_smmu_v3 *smmu;

Coding style: Newline.

> +                    smmu = (struct acpi_iort_smmu_v3 *)node->node_data;
> +                    mfn = paddr_to_pfn(smmu->base_address);
> +                    rc = iomem_deny_access(d, mfn, mfn + PFN_UP(SZ_128K));
> +                    if ( rc )
> +                        printk("iomem_deny_access failed for SMMUv3\n");
> +                    node->type = 0xff;

'node' points to the Xen copy of the ACPI table. We should really not 
touch this copy. Instead, we should modify the version that will be used 
by dom0.

Furthermore, if we go down the road to update node->type, we should 0 
the node to avoid leaking the information to dom0.

> +                    break;
> +                }
> +            }
> +            node = ACPI_ADD_PTR(struct acpi_iort_node, node, node->length);
> +        }
> +    }
> +    else
> +    {
> +        printk("Failed to get IORT table\n");
> +        return -EINVAL;
> +    }

The IORT is not yet parsed by Xen and AFAIK is optional. So I don't 
think we should return an error.

> +
>       /* Deny MMIO access for GIC regions */
>       return gic_iomem_deny_access(d);
>   }

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 18:40:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 18:40:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315382.533913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njmad-0004HB-7j; Wed, 27 Apr 2022 18:40:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315382.533913; Wed, 27 Apr 2022 18:40:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njmad-0004H4-4k; Wed, 27 Apr 2022 18:40:39 +0000
Received: by outflank-mailman (input) for mailman id 315382;
 Wed, 27 Apr 2022 18:40:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njmac-0004Gu-EG; Wed, 27 Apr 2022 18:40:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njmac-0004G0-49; Wed, 27 Apr 2022 18:40:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njmab-0007Dj-KW; Wed, 27 Apr 2022 18:40:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njmab-0001DP-K6; Wed, 27 Apr 2022 18:40:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IUVDneSiMoKI4zS6cij7JPSbPYTUOTntQyNu/udYYxM=; b=qEmlxgN59efvU7bW6doabtvsIM
	ErdvuU2sPbpm6ZrLA2SsZQ82sfG6edmVLb11uaXfPkr1M8NoZQm65i0ZT96cQ1NUm6ry6JSDo0X7F
	sJE1e4Esine0tnhjhi6Qpt2CJBDzYZpsZ6fuNY3Ijg78bshMytDDiHt6DZGRo4RaNA0M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169767-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169767: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=46cf2c613f4b10eb12f749207b0fd2c1bfae3088
X-Osstest-Versions-That:
    linux=cf424ef014ac30b0da27125dd1fbdf10b0d3a520
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 18:40:37 +0000

flight 169767 linux-linus real [real]
flight 169789 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169767/
http://logs.test-lab.xenproject.org/osstest/logs/169789/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169789-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10  fail blocked in 169753
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169753
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169753
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169753
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169753
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169753
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169753
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169753
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169753
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                46cf2c613f4b10eb12f749207b0fd2c1bfae3088
baseline version:
 linux                cf424ef014ac30b0da27125dd1fbdf10b0d3a520

Last test of basis   169753  2022-04-26 19:11:57 Z    0 days
Testing same since   169767  2022-04-27 04:01:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Luca Ceresoli <luca.ceresoli@bootlin.com>
  Luca Weiss <luca.weiss@fairphone.com>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Marek Vasut <marex@denx.de>
  Mika Westerberg <mika.westerberg@linux.intel.com>
  Wells Lu <wellslutw@gmail.com>
  YueHaibing <yuehaibing@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   cf424ef014ac..46cf2c613f4b  46cf2c613f4b10eb12f749207b0fd2c1bfae3088 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 18:44:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 18:44:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315390.533923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njmeO-0004vH-PR; Wed, 27 Apr 2022 18:44:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315390.533923; Wed, 27 Apr 2022 18:44:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njmeO-0004vA-M6; Wed, 27 Apr 2022 18:44:32 +0000
Received: by outflank-mailman (input) for mailman id 315390;
 Wed, 27 Apr 2022 18:44:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7gAn=VF=cantab.net=dvrabel@srs-se1.protection.inumbo.net>)
 id 1njmeN-0004v4-Hb
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 18:44:31 +0000
Received: from smarthost01b.ixn.mail.zen.net.uk
 (smarthost01b.ixn.mail.zen.net.uk [212.23.1.21])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11f999a1-c65a-11ec-8fc2-03012f2f19d4;
 Wed, 27 Apr 2022 20:44:29 +0200 (CEST)
Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk)
 by smarthost01b.ixn.mail.zen.net.uk with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <dvrabel@cantab.net>)
 id 1njmeL-0002At-Jb; Wed, 27 Apr 2022 18:44:29 +0000
Received: from apple.davidvrabel.org.uk ([82.70.146.43])
 by pear.davidvrabel.org.uk with esmtp (Exim 4.94.2)
 (envelope-from <dvrabel@cantab.net>)
 id 1njmeB-001KKX-MR; Wed, 27 Apr 2022 19:44:28 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11f999a1-c65a-11ec-8fc2-03012f2f19d4
Message-ID: <b5234297-c70c-ffc8-9104-99eb6f5a0e24@cantab.net>
Date: Wed, 27 Apr 2022 19:44:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-GB
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, David Vrabel <dvrabel@amazon.co.uk>
References: <20220419150320.64783-1-dvrabel@cantab.net>
 <6076f458-a56f-448b-2001-6af38b998edb@citrix.com>
From: David Vrabel <dvrabel@cantab.net>
In-Reply-To: <6076f458-a56f-448b-2001-6af38b998edb@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 82.70.146.43
X-SA-Exim-Mail-From: dvrabel@cantab.net
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	pear.davidvrabel.org.uk
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,NICE_REPLY_A,
	SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no
	version=3.4.6
Subject: Re: Regression with CET: [PATCH v1] x86/mm: avoid inadvertently
 degrading a TLB flush to local only
X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000)
X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk)
X-Originating-smarthost01b-IP: [82.70.146.41]
Feedback-ID: 82.70.146.41



On 27/04/2022 19:03, Andrew Cooper wrote:
> On 19/04/2022 16:03, David Vrabel wrote:
>> From: David Vrabel <dvrabel@amazon.co.uk>
>>
>> If the direct map is incorrectly modified with interrupts disabled,
>> the required TLB flushes are degraded to flushing the local CPU only.
>>
>> This could lead to very hard to diagnose problems as different CPUs will
>> end up with different views of memory. Although, no such issues have yet
>> been identified.
>>
>> Change the check in the flush_area() macro to look at system_state
>> instead. This defers the switch from local to all later in the boot
>> (see xen/arch/x86/setup.c:__start_xen()). This is fine because
>> additional PCPUs are not brought up until after the system state is
>> SYS_STATE_smp_boot.
>>
>> Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
> 
> This explodes on CET systems:
> 
> (XEN) Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265
> (XEN) ----[ Xen-4.17.0-10.24-d  x86_64  debug=y  Not tainted ]----
> (XEN) CPU:    0
> (XEN) RIP:    e008:[<ffff82d040345300>] flush_area_mask+0x40/0x13e
> <snip>
> (XEN) Xen call trace:
> (XEN)    [<ffff82d040345300>] R flush_area_mask+0x40/0x13e
> (XEN)    [<ffff82d040338a40>] F modify_xen_mappings+0xc5/0x958
> (XEN)    [<ffff82d0404474f9>] F
> arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9
> (XEN)    [<ffff82d0404476cc>] F alternative_branches+0xf/0x12
> (XEN)    [<ffff82d04044e37d>] F __start_xen+0x1ef4/0x2776
> (XEN)    [<ffff82d040203344>] F __high_start+0x94/0xa0
> (XEN)
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265
> (XEN) ****************************************
> (XEN)
> 
> We really did want a local-only flush here, because we specifically
> intended to make self-modifying changes before bringing secondary CPUs up.

I think the transition to SYS_STATE_smp_boot system state should be 
later. i.e., the last point were only 1 PCPU is guaranteed.

David


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 19:00:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 19:00:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315400.533935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njmti-0007FI-3q; Wed, 27 Apr 2022 19:00:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315400.533935; Wed, 27 Apr 2022 19:00:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njmti-0007FB-0n; Wed, 27 Apr 2022 19:00:22 +0000
Received: by outflank-mailman (input) for mailman id 315400;
 Wed, 27 Apr 2022 19:00:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njmth-0007F1-0H; Wed, 27 Apr 2022 19:00:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njmtg-0004cR-Sm; Wed, 27 Apr 2022 19:00:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njmtg-0007iC-BJ; Wed, 27 Apr 2022 19:00:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njmtg-0008Fw-At; Wed, 27 Apr 2022 19:00:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rw5FKuwxWxfVD6G4ToLmo/SuI4Y6zfmCxVUWy+V2uDk=; b=h/XHfCDnSVVQJ/RyGFPBDLUkBN
	iF9fNyOCcbIBlt/cdJFkgiRs+TnFkX9oNyf021+tsHoG2V/KuIz4U/C8CPJ05J9FrYs9oyY9ffAlY
	7QnwOfpc/7N8qnxAfpo6WLLyYAap6CWkjH1rOjqeUqFv6wzHw4Z0kXUxNhCBoR8avGdA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169791-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169791: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 19:00:20 +0000

flight 169791 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169791/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  665 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   37 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 19:08:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 19:08:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315409.533946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njn1r-00080a-0N; Wed, 27 Apr 2022 19:08:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315409.533946; Wed, 27 Apr 2022 19:08:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njn1q-00080T-Sj; Wed, 27 Apr 2022 19:08:46 +0000
Received: by outflank-mailman (input) for mailman id 315409;
 Wed, 27 Apr 2022 19:08:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sNsI=VF=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1njn1o-00080N-Sj
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 19:08:45 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 73d8d129-c65d-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 21:08:43 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 9C70C5C0232;
 Wed, 27 Apr 2022 15:08:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Wed, 27 Apr 2022 15:08:41 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 27 Apr 2022 15:08:40 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73d8d129-c65d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651086521; x=
	1651172921; bh=fsebkSD5sPqk3pdhzdwrcbmGClEPrZ02djtT55h4Sbw=; b=b
	iI3XI8gLOa7mCyy8bgGGjXrD/11XxGfHfOhUziPBEf70ZxDo6x6WmEUK+d3zz3Zj
	K9AySLDAODlc3Rm9yNV95nw6HFdA9LcBmhDQ+3GpvLeXS01nUfANo9wAfQqCarRF
	QkDFge/InPYJD0Yz1dCRwWyQ5LN2nOw9dqWImgZc0LF1Uvu+Z7BpjbcTbdixBsz+
	bzLn7CE4n5Lm3/DZ1cGP6AVH0YuVaYa4IWQB407BWaqTwmdkd/VmOQQb+0nLxhWn
	sWCI9BDCMt7vspH7LeQ2NrAAvAU8T/JHOlofH+pyqBvWw49goRcsDfCTBkHlhRq4
	oeuv1lfD5HVUognwgdIDg==
X-ME-Sender: <xms:uZRpYqsVFFulJNK6G8Ez4dJlRr-UJebHboicJigjO-P3P-OaJBBotA>
    <xme:uZRpYvf3nl6lSQ6ApV78PeTMuxQ-26qa4nY0sZ_hQRKotJaXdAbSzNuaYHVLY24h5
    6sUi_1J8NygouY>
X-ME-Received: <xmr:uZRpYlzWi90X54F822fYN4Uvdhy0qqoSwv1WK2Ee_dgSHvhZGMUxTgnKDOsw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehgddufeduucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtroertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepiefgudefjedujeelvddtgfegueei
    hfeugfdtgfevkedtkefgledvtddvvdekheeknecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:uZRpYlNZ1KBZm0B_vNoelfqRfsJH7t1Mr2R14FLCNTD_qKVL5MzyCQ>
    <xmx:uZRpYq9ectGKHB5hWwJvSW-UIpOcNUvtQk7O-Hrr0SRZNRgaDpD1Ig>
    <xmx:uZRpYtUm_nozezwuZWV9wn4rzkskzLNyIAEgbvegY-PHc2TjZ5W1sw>
    <xmx:uZRpYhn69_wYZDn9r_b4Jc15tYDogca2lYnAFKm-xVev-zUugP3VzQ>
Date: Wed, 27 Apr 2022 15:08:36 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT
Message-ID: <YmmUtiBkhEYvXHUB@itl-email>
References: <Yl7aC2a+TtOaFtqZ@itl-email>
 <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="28Yvb+XBgtt99NWg"
Content-Disposition: inline
In-Reply-To: <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com>


--28Yvb+XBgtt99NWg
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 27 Apr 2022 15:08:36 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT

On Wed, Apr 27, 2022 at 10:56:34AM +0200, Jan Beulich wrote:
> On 19.04.2022 17:49, Demi Marie Obenour wrote:
> > This hypercall can be used to get the ESRT from the hypervisor.  It
> > returning successfully also indicates that Xen has reserved the ESRT and
> > it can safely be parsed by dom0.
>=20
> I'm not convinced of the need, and I view such an addition as inconsistent
> with the original intentions. The pointer comes from the config table,
> which Dom0 already has access to. All a Dom0 kernel may need to know in
> addition is whether the range was properly reserved. This could be achiev=
ed
> by splitting the EFI memory map entry in patch 2, instead of only splitti=
ng
> the E820 derivation, as then XEN_FW_EFI_MEM_INFO can be used to find out
> the range's type. Another way to find out would be for Dom0 to attempt to
> map this area as MMIO, after first checking that no part of the range is =
in
> its own memory allocation. This 2nd approach may, however, not really be
> suitable for PVH Dom0, I think.

On further thought, I think the hypercall approach is actually better
than reserving the ESRT.  I really do not want XEN_FW_EFI_MEM_INFO to
return anything other than the actual firmware-provided memory
information, and the current approach seems to require more and more
special-casing of the ESRT, not to mention potentially wasting memory
and splitting a potentially large memory region into two smaller ones.
By copying the entire ESRT into memory owned by Xen, the logic becomes
significantly simpler on both the Xen and dom0 sides.

Is using ebmalloc() to allocate a copy of the ESRT a reasonable option?
Is it possible that the ESRT is so large that this causes boot to fail?
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--28Yvb+XBgtt99NWg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJplLYACgkQsoi1X/+c
IsELRxAAiVq6ooCV4gTIqbiLlR5u2ESbwEYr4Zay7q6UkOJnosEMo97FGHHsjycp
MUMN3xPna+UXzf36EAz64CKlC9RVahhEIShnB7Dp2yQmBRvqURyD9VqrC2oSZq8M
2De7syyjEfINXRXBxR7TxSpljB0HKL5/OekmQ7t3Yz1KKF423PgG4nheepGgVjVd
DkNmKxPO1Ndi7myw3/O3S9JW+8hPbUCr0XswZOCyIZngN7RXTZ8GhcriYF8Ip2zT
GuhJg6BvNcZszScXwWj3X5Dnrj8B6/PrGinhPvs/oK3Il0MfHu+PcNsICo6o1B0Q
piRQ5Iql+ISSHlSse0rUlSAsc/YXP+jxVUBPZ44ZuuQFXIGiCedZ0k2UrWejWBGs
sYWwlCEXxr2q216RaNJfICZ9SeStb1PeWo0pCZouS3iC4KCVB0LzLOfTmbdNpzSi
PsXhZTC6f4gyjE+nSICLwtaEJl8Un8CUL49Nd6iJWMDsdOEqDKC01QgHU3Ica3Em
7c7hSE3/Nl3CfNL6yZyJsL97MzdmL0SYie3AsinhqfUIF7Jys9KKjtS/9ceu4DaP
Q/qa9JzJXZnIE2IxqvRAutJAIPLrwhmT5zTP8IFj2xEsqrzcX6z3lwVEBd5dDl1K
cLrX9ThWo7IHKIi4wNCyL9wJB+qIFDBjOD1owavuCuzYK5yM+5o=
=HSAP
-----END PGP SIGNATURE-----

--28Yvb+XBgtt99NWg--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 19:47:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 19:47:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315421.533963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njncv-0003hg-Sj; Wed, 27 Apr 2022 19:47:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315421.533963; Wed, 27 Apr 2022 19:47:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njncv-0003hZ-Pl; Wed, 27 Apr 2022 19:47:05 +0000
Received: by outflank-mailman (input) for mailman id 315421;
 Wed, 27 Apr 2022 19:47:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7Mu5=VF=redhat.com=hdegoede@srs-se1.protection.inumbo.net>)
 id 1njncu-0003hT-3s
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 19:47:04 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd44a602-c662-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 21:47:00 +0200 (CEST)
Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com
 [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-338-Q6qWz4bLP3axjlHEjGUQIg-1; Wed, 27 Apr 2022 15:46:57 -0400
Received: by mail-ej1-f71.google.com with SMTP id
 sh14-20020a1709076e8e00b006f3b7adb9ffso1707869ejc.16
 for <xen-devel@lists.xenproject.org>; Wed, 27 Apr 2022 12:46:57 -0700 (PDT)
Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81?
 (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl.
 [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81])
 by smtp.gmail.com with ESMTPSA id
 g16-20020a170906521000b006d58773e992sm7332748ejm.188.2022.04.27.12.46.55
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 27 Apr 2022 12:46:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd44a602-c662-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1651088819;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=v3OklSdyVLYyhlHQbDyM2Zei+HHJAielq60YtiKYkDc=;
	b=S655zj8L0osE31qdxiodeQrvMGpdcwvLSzV8elxnzQnRfJbSqLwG7hzKsHt7ki+UkFu1g6
	kg6/fqsIJ8fvg+jukimQ0B6TTM01VfYoGHDaZhESQGO9d21wvFZwRhLjtnl/FdDOkXTmOW
	XPEOhhJkIOIqaQ0aJZQFDSYY6/c5I9g=
X-MC-Unique: Q6qWz4bLP3axjlHEjGUQIg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=v3OklSdyVLYyhlHQbDyM2Zei+HHJAielq60YtiKYkDc=;
        b=KrjkkSTe6QdDgIHk2W5YTDV6BXuN30Y1BeQeX0GkZQQlnFYsSQjbwKB3SFVueicYFO
         rHc6lTOj7OaODLkuq+6ST0kpVVWImwk7A8Q/qD/PkfU/Y/CSJ2FNjh/0XBE7Dis2444j
         eRBO+3D+s/yS89CGhMnkbqzidcjRxFpCev4Ks9h5AVoOmtMKWkHzkn6lmMe10YBk8kHy
         GwqME1SxXjm6LH6pfiMtjAT0PKS9nnQQAEIMkreLkC2GBS29w/8SluZBhFb/3YOCX0Aw
         otvFXCVCJUzPZ5GSJS105ovjIlJAvsLxSEr2THv69sUVc5sYXRFUPLlfw0oaW58UBiXI
         sHMg==
X-Gm-Message-State: AOAM5328V33nVIwKEfAkjE8FUThiE2mZy4zuyK3JuWBL/gs/dOFcc5yj
	ASS/D21YG8LjGaZilG2DWKb0cdtI5ejSYFJFmQKy21WXfUoPV5pYNoiQ4hT4SFZRlLsjLsEVrDL
	oD05DCxjlUI2ihSMPESZSmhmj9AM=
X-Received: by 2002:a17:907:6da5:b0:6f3:c4b1:378b with SMTP id sb37-20020a1709076da500b006f3c4b1378bmr4979668ejc.307.1651088816606;
        Wed, 27 Apr 2022 12:46:56 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJymvr44AuMeVFSaW3C3BvlE0J5N9rDfBjLEZEqGt/VOJXE6CZNNVtdPgdZBiYcPPiYwnEi6UQ==
X-Received: by 2002:a17:907:6da5:b0:6f3:c4b1:378b with SMTP id sb37-20020a1709076da500b006f3c4b1378bmr4979648ejc.307.1651088816319;
        Wed, 27 Apr 2022 12:46:56 -0700 (PDT)
Message-ID: <a531d7e3-9481-3047-d7a0-c350e0596d53@redhat.com>
Date: Wed, 27 Apr 2022 21:46:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] platform/x86/dell: add buffer allocation/free functions
 for SMI calls
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Dell.Client.Kernel@dell.com
Cc: Stuart Hayes <stuart.w.hayes@gmail.com>, Mark Gross
 <markgross@kernel.org>, stable@vger.kernel.org
References: <20220318150950.16843-1-jgross@suse.com>
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220318150950.16843-1-jgross@suse.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 3/18/22 16:09, Juergen Gross wrote:
> The dcdbas driver is used to call SMI handlers for both, dcdbas and
> dell-smbios-smm. Both drivers allocate a buffer for communicating
> with the SMI handler. The physical buffer address is then passed to
> the called SMI handler via %ebx.
> 
> Unfortunately this doesn't work when running in Xen dom0, as the
> physical address obtained via virt_to_phys() is only a guest physical
> address, and not a machine physical address as needed by SMI.
> 
> The problem in dcdbas is easy to correct, as dcdbas is using
> dma_alloc_coherent() for allocating the buffer, and the machine
> physical address is available via the DMA address returned in the DMA
> handle.
> 
> In order to avoid duplicating the buffer allocation code in
> dell-smbios-smm, add a generic buffer allocation function to dcdbas
> and use it for both drivers. This is especially fine regarding driver
> dependencies, as dell-smbios-smm is already calling dcdbas to generate
> the SMI request.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/dell/dcdbas.c          | 127 +++++++++++---------
>  drivers/platform/x86/dell/dcdbas.h          |   9 ++
>  drivers/platform/x86/dell/dell-smbios-smm.c |  14 ++-
>  3 files changed, 87 insertions(+), 63 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c
> index 5e63d6225048..02bcac619018 100644
> --- a/drivers/platform/x86/dell/dcdbas.c
> +++ b/drivers/platform/x86/dell/dcdbas.c
> @@ -40,13 +40,10 @@
>  
>  static struct platform_device *dcdbas_pdev;
>  
> -static u8 *smi_data_buf;
> -static dma_addr_t smi_data_buf_handle;
> -static unsigned long smi_data_buf_size;
>  static unsigned long max_smi_data_buf_size = MAX_SMI_DATA_BUF_SIZE;
> -static u32 smi_data_buf_phys_addr;
>  static DEFINE_MUTEX(smi_data_lock);
>  static u8 *bios_buffer;
> +static struct smi_buffer smi_buf;
>  
>  static unsigned int host_control_action;
>  static unsigned int host_control_smi_type;
> @@ -54,23 +51,49 @@ static unsigned int host_control_on_shutdown;
>  
>  static bool wsmt_enabled;
>  
> +int dcdbas_smi_alloc(struct smi_buffer *smi_buffer, unsigned long size)
> +{
> +	smi_buffer->virt = dma_alloc_coherent(&dcdbas_pdev->dev, size,
> +					      &smi_buffer->dma, GFP_KERNEL);
> +	if (!smi_buffer->virt) {
> +		dev_dbg(&dcdbas_pdev->dev,
> +			"%s: failed to allocate memory size %lu\n",
> +			__func__, size);
> +		return -ENOMEM;
> +	}
> +	smi_buffer->size = size;
> +
> +	dev_dbg(&dcdbas_pdev->dev, "%s: phys: %x size: %lu\n",
> +		__func__, (u32)smi_buffer->dma, smi_buffer->size);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(dcdbas_smi_alloc);
> +
> +void dcdbas_smi_free(struct smi_buffer *smi_buffer)
> +{
> +	if (!smi_buffer->virt)
> +		return;
> +
> +	dev_dbg(&dcdbas_pdev->dev, "%s: phys: %x size: %lu\n",
> +		__func__, (u32)smi_buffer->dma, smi_buffer->size);
> +	dma_free_coherent(&dcdbas_pdev->dev, smi_buffer->size,
> +			  smi_buffer->virt, smi_buffer->dma);
> +	smi_buffer->virt = NULL;
> +	smi_buffer->dma = 0;
> +	smi_buffer->size = 0;
> +}
> +EXPORT_SYMBOL_GPL(dcdbas_smi_free);
> +
>  /**
>   * smi_data_buf_free: free SMI data buffer
>   */
>  static void smi_data_buf_free(void)
>  {
> -	if (!smi_data_buf || wsmt_enabled)
> +	if (!smi_buf.virt || wsmt_enabled)
>  		return;
>  
> -	dev_dbg(&dcdbas_pdev->dev, "%s: phys: %x size: %lu\n",
> -		__func__, smi_data_buf_phys_addr, smi_data_buf_size);
> -
> -	dma_free_coherent(&dcdbas_pdev->dev, smi_data_buf_size, smi_data_buf,
> -			  smi_data_buf_handle);
> -	smi_data_buf = NULL;
> -	smi_data_buf_handle = 0;
> -	smi_data_buf_phys_addr = 0;
> -	smi_data_buf_size = 0;
> +	dcdbas_smi_free(&smi_buf);
>  }
>  
>  /**
> @@ -78,39 +101,29 @@ static void smi_data_buf_free(void)
>   */
>  static int smi_data_buf_realloc(unsigned long size)
>  {
> -	void *buf;
> -	dma_addr_t handle;
> +	struct smi_buffer tmp;
> +	int ret;
>  
> -	if (smi_data_buf_size >= size)
> +	if (smi_buf.size >= size)
>  		return 0;
>  
>  	if (size > max_smi_data_buf_size)
>  		return -EINVAL;
>  
>  	/* new buffer is needed */
> -	buf = dma_alloc_coherent(&dcdbas_pdev->dev, size, &handle, GFP_KERNEL);
> -	if (!buf) {
> -		dev_dbg(&dcdbas_pdev->dev,
> -			"%s: failed to allocate memory size %lu\n",
> -			__func__, size);
> -		return -ENOMEM;
> -	}
> -	/* memory zeroed by dma_alloc_coherent */
> +	ret = dcdbas_smi_alloc(&tmp, size);
> +	if (ret)
> +		return ret;
>  
> -	if (smi_data_buf)
> -		memcpy(buf, smi_data_buf, smi_data_buf_size);
> +	/* memory zeroed by dma_alloc_coherent */
> +	if (smi_buf.virt)
> +		memcpy(tmp.virt, smi_buf.virt, smi_buf.size);
>  
>  	/* free any existing buffer */
>  	smi_data_buf_free();
>  
>  	/* set up new buffer for use */
> -	smi_data_buf = buf;
> -	smi_data_buf_handle = handle;
> -	smi_data_buf_phys_addr = (u32) virt_to_phys(buf);
> -	smi_data_buf_size = size;
> -
> -	dev_dbg(&dcdbas_pdev->dev, "%s: phys: %x size: %lu\n",
> -		__func__, smi_data_buf_phys_addr, smi_data_buf_size);
> +	smi_buf = tmp;
>  
>  	return 0;
>  }
> @@ -119,14 +132,14 @@ static ssize_t smi_data_buf_phys_addr_show(struct device *dev,
>  					   struct device_attribute *attr,
>  					   char *buf)
>  {
> -	return sprintf(buf, "%x\n", smi_data_buf_phys_addr);
> +	return sprintf(buf, "%x\n", (u32)smi_buf.dma);
>  }
>  
>  static ssize_t smi_data_buf_size_show(struct device *dev,
>  				      struct device_attribute *attr,
>  				      char *buf)
>  {
> -	return sprintf(buf, "%lu\n", smi_data_buf_size);
> +	return sprintf(buf, "%lu\n", smi_buf.size);
>  }
>  
>  static ssize_t smi_data_buf_size_store(struct device *dev,
> @@ -155,8 +168,8 @@ static ssize_t smi_data_read(struct file *filp, struct kobject *kobj,
>  	ssize_t ret;
>  
>  	mutex_lock(&smi_data_lock);
> -	ret = memory_read_from_buffer(buf, count, &pos, smi_data_buf,
> -					smi_data_buf_size);
> +	ret = memory_read_from_buffer(buf, count, &pos, smi_buf.virt,
> +					smi_buf.size);
>  	mutex_unlock(&smi_data_lock);
>  	return ret;
>  }
> @@ -176,7 +189,7 @@ static ssize_t smi_data_write(struct file *filp, struct kobject *kobj,
>  	if (ret)
>  		goto out;
>  
> -	memcpy(smi_data_buf + pos, buf, count);
> +	memcpy(smi_buf.virt + pos, buf, count);
>  	ret = count;
>  out:
>  	mutex_unlock(&smi_data_lock);
> @@ -306,11 +319,11 @@ static ssize_t smi_request_store(struct device *dev,
>  
>  	mutex_lock(&smi_data_lock);
>  
> -	if (smi_data_buf_size < sizeof(struct smi_cmd)) {
> +	if (smi_buf.size < sizeof(struct smi_cmd)) {
>  		ret = -ENODEV;
>  		goto out;
>  	}
> -	smi_cmd = (struct smi_cmd *)smi_data_buf;
> +	smi_cmd = (struct smi_cmd *)smi_buf.virt;
>  
>  	switch (val) {
>  	case 2:
> @@ -326,20 +339,20 @@ static ssize_t smi_request_store(struct device *dev,
>  		 * Provide physical address of command buffer field within
>  		 * the struct smi_cmd to BIOS.
>  		 *
> -		 * Because the address that smi_cmd (smi_data_buf) points to
> +		 * Because the address that smi_cmd (smi_buf.virt) points to
>  		 * will be from memremap() of a non-memory address if WSMT
>  		 * is present, we can't use virt_to_phys() on smi_cmd, so
>  		 * we have to use the physical address that was saved when
>  		 * the virtual address for smi_cmd was received.
>  		 */
> -		smi_cmd->ebx = smi_data_buf_phys_addr +
> +		smi_cmd->ebx = (u32)smi_buf.dma +
>  				offsetof(struct smi_cmd, command_buffer);
>  		ret = dcdbas_smi_request(smi_cmd);
>  		if (!ret)
>  			ret = count;
>  		break;
>  	case 0:
> -		memset(smi_data_buf, 0, smi_data_buf_size);
> +		memset(smi_buf.virt, 0, smi_buf.size);
>  		ret = count;
>  		break;
>  	default:
> @@ -356,7 +369,7 @@ EXPORT_SYMBOL(dcdbas_smi_request);
>  /**
>   * host_control_smi: generate host control SMI
>   *
> - * Caller must set up the host control command in smi_data_buf.
> + * Caller must set up the host control command in smi_buf.virt.
>   */
>  static int host_control_smi(void)
>  {
> @@ -367,14 +380,14 @@ static int host_control_smi(void)
>  	s8 cmd_status;
>  	u8 index;
>  
> -	apm_cmd = (struct apm_cmd *)smi_data_buf;
> +	apm_cmd = (struct apm_cmd *)smi_buf.virt;
>  	apm_cmd->status = ESM_STATUS_CMD_UNSUCCESSFUL;
>  
>  	switch (host_control_smi_type) {
>  	case HC_SMITYPE_TYPE1:
>  		spin_lock_irqsave(&rtc_lock, flags);
>  		/* write SMI data buffer physical address */
> -		data = (u8 *)&smi_data_buf_phys_addr;
> +		data = (u8 *)&smi_buf.dma;
>  		for (index = PE1300_CMOS_CMD_STRUCT_PTR;
>  		     index < (PE1300_CMOS_CMD_STRUCT_PTR + 4);
>  		     index++, data++) {
> @@ -405,7 +418,7 @@ static int host_control_smi(void)
>  	case HC_SMITYPE_TYPE3:
>  		spin_lock_irqsave(&rtc_lock, flags);
>  		/* write SMI data buffer physical address */
> -		data = (u8 *)&smi_data_buf_phys_addr;
> +		data = (u8 *)&smi_buf.dma;
>  		for (index = PE1400_CMOS_CMD_STRUCT_PTR;
>  		     index < (PE1400_CMOS_CMD_STRUCT_PTR + 4);
>  		     index++, data++) {
> @@ -450,7 +463,7 @@ static int host_control_smi(void)
>   * This function is called by the driver after the system has
>   * finished shutting down if the user application specified a
>   * host control action to perform on shutdown.  It is safe to
> - * use smi_data_buf at this point because the system has finished
> + * use smi_buf.virt at this point because the system has finished
>   * shutting down and no userspace apps are running.
>   */
>  static void dcdbas_host_control(void)
> @@ -464,18 +477,18 @@ static void dcdbas_host_control(void)
>  	action = host_control_action;
>  	host_control_action = HC_ACTION_NONE;
>  
> -	if (!smi_data_buf) {
> +	if (!smi_buf.virt) {
>  		dev_dbg(&dcdbas_pdev->dev, "%s: no SMI buffer\n", __func__);
>  		return;
>  	}
>  
> -	if (smi_data_buf_size < sizeof(struct apm_cmd)) {
> +	if (smi_buf.size < sizeof(struct apm_cmd)) {
>  		dev_dbg(&dcdbas_pdev->dev, "%s: SMI buffer too small\n",
>  			__func__);
>  		return;
>  	}
>  
> -	apm_cmd = (struct apm_cmd *)smi_data_buf;
> +	apm_cmd = (struct apm_cmd *)smi_buf.virt;
>  
>  	/* power off takes precedence */
>  	if (action & HC_ACTION_HOST_CONTROL_POWEROFF) {
> @@ -583,11 +596,11 @@ static int dcdbas_check_wsmt(void)
>  		return -ENOMEM;
>  	}
>  
> -	/* First 8 bytes is for a semaphore, not part of the smi_data_buf */
> -	smi_data_buf_phys_addr = bios_buf_paddr + 8;
> -	smi_data_buf = bios_buffer + 8;
> -	smi_data_buf_size = remap_size - 8;
> -	max_smi_data_buf_size = smi_data_buf_size;
> +	/* First 8 bytes is for a semaphore, not part of the smi_buf.virt */
> +	smi_buf.dma = bios_buf_paddr + 8;
> +	smi_buf.virt = bios_buffer + 8;
> +	smi_buf.size = remap_size - 8;
> +	max_smi_data_buf_size = smi_buf.size;
>  	wsmt_enabled = true;
>  	dev_info(&dcdbas_pdev->dev,
>  		 "WSMT found, using firmware-provided SMI buffer.\n");
> diff --git a/drivers/platform/x86/dell/dcdbas.h b/drivers/platform/x86/dell/dcdbas.h
> index c3cca5433525..942a23ddded0 100644
> --- a/drivers/platform/x86/dell/dcdbas.h
> +++ b/drivers/platform/x86/dell/dcdbas.h
> @@ -105,5 +105,14 @@ struct smm_eps_table {
>  	u64 num_of_4k_pages;
>  } __packed;
>  
> +struct smi_buffer {
> +	u8 *virt;
> +	unsigned long size;
> +	dma_addr_t dma;
> +};
> +
> +int dcdbas_smi_alloc(struct smi_buffer *smi_buffer, unsigned long size);
> +void dcdbas_smi_free(struct smi_buffer *smi_buffer);
> +
>  #endif /* _DCDBAS_H_ */
>  
> diff --git a/drivers/platform/x86/dell/dell-smbios-smm.c b/drivers/platform/x86/dell/dell-smbios-smm.c
> index 320c032418ac..4d375985c85f 100644
> --- a/drivers/platform/x86/dell/dell-smbios-smm.c
> +++ b/drivers/platform/x86/dell/dell-smbios-smm.c
> @@ -20,6 +20,7 @@
>  
>  static int da_command_address;
>  static int da_command_code;
> +static struct smi_buffer smi_buf;
>  static struct calling_interface_buffer *buffer;
>  static struct platform_device *platform_device;
>  static DEFINE_MUTEX(smm_mutex);
> @@ -57,7 +58,7 @@ static int dell_smbios_smm_call(struct calling_interface_buffer *input)
>  	command.magic = SMI_CMD_MAGIC;
>  	command.command_address = da_command_address;
>  	command.command_code = da_command_code;
> -	command.ebx = virt_to_phys(buffer);
> +	command.ebx = smi_buf.dma;
>  	command.ecx = 0x42534931;
>  
>  	mutex_lock(&smm_mutex);
> @@ -101,9 +102,10 @@ int init_dell_smbios_smm(void)
>  	 * Allocate buffer below 4GB for SMI data--only 32-bit physical addr
>  	 * is passed to SMI handler.
>  	 */
> -	buffer = (void *)__get_free_page(GFP_KERNEL | GFP_DMA32);
> -	if (!buffer)
> -		return -ENOMEM;
> +	ret = dcdbas_smi_alloc(&smi_buf, PAGE_SIZE);
> +	if (ret)
> +		return ret;
> +	buffer = (void *)smi_buf.virt;
>  
>  	dmi_walk(find_cmd_address, NULL);
>  
> @@ -138,7 +140,7 @@ int init_dell_smbios_smm(void)
>  
>  fail_wsmt:
>  fail_platform_device_alloc:
> -	free_page((unsigned long)buffer);
> +	dcdbas_smi_free(&smi_buf);
>  	return ret;
>  }
>  
> @@ -147,6 +149,6 @@ void exit_dell_smbios_smm(void)
>  	if (platform_device) {
>  		dell_smbios_unregister_device(&platform_device->dev);
>  		platform_device_unregister(platform_device);
> -		free_page((unsigned long)buffer);
> +		dcdbas_smi_free(&smi_buf);
>  	}
>  }



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 19:58:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 19:58:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315427.533974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njno8-0005Au-Vc; Wed, 27 Apr 2022 19:58:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315427.533974; Wed, 27 Apr 2022 19:58:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njno8-0005An-Sf; Wed, 27 Apr 2022 19:58:40 +0000
Received: by outflank-mailman (input) for mailman id 315427;
 Wed, 27 Apr 2022 19:58:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=83Ve=VF=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njno8-0005Ah-0e
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 19:58:40 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d6280a1-c664-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 21:58:38 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1D2F261C63;
 Wed, 27 Apr 2022 19:58:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D3A9C385A7;
 Wed, 27 Apr 2022 19:58:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d6280a1-c664-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651089515;
	bh=0skaRe9/dTpo0sKl70O40y9fwBoxLUIQiejabbKpoeM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZTunomGBONXA8LYD835RR55spnj95HGCcCIhPk1cw/B3kLg3/frNfIMiOgrvVC8x8
	 I4AXd9u6PGgxblzbyq1E1NVit+6/lkQe9uOPcUqPMMN35xIROBQVcplR0r2euLJU96
	 KJlPsiugvkDyTE/4xfblsEFxQVjNA3wViygvK4/ZCsUh6ii3lp3HYarZYz6l7rIfgu
	 zB+NEUp6qXBsWTseL8V4Op0fbClbh3TxjPrAT8Enzm+/WnJDHd4ogRJWR5oY+v7TYC
	 +RpTEvEGDQy3KyaimaMSVxh+ppiRXFM1f5in88dySPdBkaKDY2UGd7DKacFqoymJov
	 e8DX6gWsBh7RA==
Date: Wed, 27 Apr 2022 12:58:35 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Stefano Stabellini <sstabellini@kernel.org>
cc: jbeulich@suse.com, andrew.cooper3@citrix.com, julien@xen.org, 
    Bertrand.Marquis@arm.com, roger.pau@citrix.com, george.dunlap@citrix.com, 
    xen-devel@lists.xenproject.org, Artem_Mygaiev@epam.com
Subject: Re: Xen MISRA C meeting
In-Reply-To: <alpine.DEB.2.22.394.2204251730000.915916@ubuntu-linux-20-04-desktop>
Message-ID: <alpine.DEB.2.22.394.2204271255570.915916@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204251730000.915916@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 25 Apr 2022, Stefano Stabellini wrote:
> Hi all,
> 
> I would like to schedule a meeting to discuss Xen and MISRA C with the
> Xen community. I have a proposal on how to make progress in terms of
> MISRA C adoption in Xen and I would like to get your feedback on it.
> 
> The meeting is open to anybody. The Xen x86 and ARM maintainers' input
> is required to make progress, please fill the Doodle poll by the end of
> Wed Apr 27 if possible.
> 
> https://doodle.com/meeting/participate/id/elY67vja
> 
> If no slots work in the Doodle poll for everyone we could consider
> re-using the Xen Community call slot (it is one of the Doodle poll
> slots).

Thank you all for participating. The best option available is Tuesday
May 3 at 8AM California / 4PM UK / 5PM Europe. Sorry for the people that
are not going to be able to attend, but I'll make sure to send out
detailed notes to xen-devel after the meeting.

I'll send out a meeting invite with the Zoom link.

I am looking forward to it!


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 20:20:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 20:20:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315435.533985 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njo8i-0007d6-QB; Wed, 27 Apr 2022 20:19:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315435.533985; Wed, 27 Apr 2022 20:19:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njo8i-0007cz-NE; Wed, 27 Apr 2022 20:19:56 +0000
Received: by outflank-mailman (input) for mailman id 315435;
 Wed, 27 Apr 2022 20:19:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Dsuu=VF=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1njo8h-0007cq-7Q
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 20:19:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 65dbabfb-c667-11ec-8fc3-03012f2f19d4;
 Wed, 27 Apr 2022 22:19:53 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-ndzLvbzkNlO9NXZ2mmCAQw-1; Wed, 27 Apr 2022 22:19:52 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by HE1PR04MB3018.eurprd04.prod.outlook.com (2603:10a6:7:1f::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 27 Apr
 2022 20:19:50 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748%8]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 20:19:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65dbabfb-c667-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651090793;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=thk2/rwf99CaFUAXqJ+acGVwFGO06xrcN27Fi/Rj+rA=;
	b=GGDfYlCiLZsfJNwEtexnBkkCXOcyzxILp+U8cfP78sXJRstnx0+x8yIgSs5dNTGNhpM6Gv
	jhpv4o5sq5GpSFfXzc1mpt3qr3k9otoJJ/4BN99/CeeAY9/RwCZ0rs5DrEuP6rAlgSohZZ
	0dl9bcupomClBCIu6rXMtnlzfyExFlg=
X-MC-Unique: ndzLvbzkNlO9NXZ2mmCAQw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H2dIYbPT6X2wYVNsKidDhZ1Y9wqQzljqqi5YkKt2r3lkTNNUyEBn8k4uIT4AKzdIg+X8BPzU4v3diIRqGhkoi9IdwDbvIcwZ42Cv8QesJ0miLJxKApSwv6AJX2ep6GokyCfyC5iDk1lFiITRxEUba03bciMnG9+2DbDWDUMdL0qHQAlk8U0NOwcE5BD6kDfpEc+KDtZJN/31WRukeHHuH0MGcJ5QhL29wJGow+XuHSpFC0JSIjdr/ORf/ARq7/26onBpmpJN8B1pmw0AbLVIFASMFCuqa2VmraQ/JrUwxkti+IZbS5v/KDLVGP2Zy99BCQ/AEu8OG5NcLgvw2SAJOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=thk2/rwf99CaFUAXqJ+acGVwFGO06xrcN27Fi/Rj+rA=;
 b=ZysEHtLUHIPAfYkwFqb4mWMR5R6hwKD/grpI7AxVZSZ9UfCkcogC4V6txuESbnQgU6xw+SQI17M4BbtMaF3M1K0ZKz8uHaniqP4t9a6ighVN7H7xvvwbDwomyd6nt7OQsdsb+W/WSJ8mjcWwV2KzpMTG0Bvrta/cDG8LnI+smaWvz3fOFRXJiv/szhtkoeyJhzPEs9wWuI45xYPpcIf/+V+R9gkSpCDJ9N8o/JvLQuqW4+rzWZv5dklqIRSF8leCp2Du6agYMAtU74Np/uXDDJeCgcN+D417eajoYyLjtL6O7dl3D2IVLPRp+Bakc00G6XdC34RzLf6fC94hR71LyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: "michal.orzel@arm.com" <michal.orzel@arm.com>, Juergen Gross
	<JGross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "george.dunlap@citrix.com" <george.dunlap@citrix.com>
Subject: Re: [PATCH 5/8] xen/sched: Remove unused-but-set variable
Thread-Topic: [PATCH 5/8] xen/sched: Remove unused-but-set variable
Thread-Index: AQHYWhwsOZ14Vg/j7EG5g90dnN/IGq0DiJ+AgACrcQA=
Date: Wed, 27 Apr 2022 20:19:49 +0000
Message-ID: <5fdae4f46d8f66c136ed71a0737209e1fd0050b3.camel@suse.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
	 <20220427094941.291554-6-michal.orzel@arm.com>
	 <aa77a8a6-6ccc-89ec-ef27-9d685dc07ae9@suse.com>
In-Reply-To: <aa77a8a6-6ccc-89ec-ef27-9d685dc07ae9@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.1 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 11c20a51-96db-4e69-cf4c-08da288b4810
x-ms-traffictypediagnostic: HE1PR04MB3018:EE_
x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
x-microsoft-antispam-prvs:
 <HE1PR04MB3018017456428F3EAF25DD13C5FA9@HE1PR04MB3018.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Or27M6DZS1LmijAGq+DXCkL+jEyUCymUY7UNNA+pqtvX18JIA5jZaSEHZXwQMVfXf6tzpaO+C9G3s1p8RL6U+ZtlX0IRY1RQO1Q/3pXfaFKw1lFFZEMdpyM5WfDv/4lMpBOGJcS9D7HiH5XuGetkJniRx7/287hJBjEv3aPKPtsWEQEqCIBcEXlu/gmFZiJfJOgjuGGR3a3krIoA39CxJViF+y1jv2xb5b2UUjTZnizQOyQcug6YCGPooH2b80hhfDH1l76lFMCljyV7Cm4uNJmGuvM5SxzD1W3M2txW1GEnANzwICckIwmDDCe2Ae08M0KX2p08xh/e9KdQWcAwrH7qXZ3ZZWWc8UG51HKF8tZu8nGW8bCpoJW/omtT77qRxPQz91V8Gn/EOLDK540mtnHj+G83uksFHs6Peyw77OeGyNNpwXt1GaBLA5U6C8Ny0yEZstnj3G5DdH4IVLci0cHxQcoG/YIZdivnss38mlIKT6Xl/+G0LCRCBGVYkxuUIjUQMzq4bjR1WSbU44gHIv5uzsZsjox7BmkMv/d++vUCfPJEJJ9l3fsO0kq06zFevdw8g4O+1kUkIFJSMBpNM7PCPzKGvD4weiLIwsCQKP5Guv1uMr9UBDQH+zNuFU3Ucx7YwAIWX/Hnm6jVqcbkOdazc6fmPCgB6T0kB6NliRw3Iedf/35ka0rIzJbKJXgQZIyszpsmKH8j3SGif49IK2Q/l/G1nw1x5kSq5mg0iISgNNLjI1OcXM5f8TKmbS/wwV4AVbJwyxI01njh7sBkjqZsH1R8QO62BRmAFnBih77oZjUXTKIgPeO2RAe0ecIz
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(122000001)(26005)(36756003)(86362001)(6506007)(66446008)(8676002)(66946007)(76116006)(91956017)(2616005)(66476007)(53546011)(64756008)(66556008)(6512007)(4326008)(99936003)(38100700002)(4744005)(966005)(6486002)(38070700005)(508600001)(186003)(5660300002)(316002)(8936002)(2906002)(71200400001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VG9pL1NsU2h5aXVDK2lTWnhJN0FhQStCRExSSVJQN2RVVTgyUzdkZFE1VGda?=
 =?utf-8?B?V1ZpdEUxb2k2OWNraWhMajNZU09iSUtBeGdKTHBONjVtN0dRYTJZOGFMamxW?=
 =?utf-8?B?VDdTNjF6UUZJNnhYREJUbHRka21xNnliZjQxZ3ByQWpsWExSdm9VbDlDUFJW?=
 =?utf-8?B?VkdkRmdJNDZmTEFCdU0xL2dOYW5NOFRlWkUrUk9VNmlROXJrM2x0YWk0UmdV?=
 =?utf-8?B?c1YzaTM5RXNZYjRtTWozVERGMm55S3dCM3dENTIrUTVab1kySUo4ZXhLd1kr?=
 =?utf-8?B?Rmh2RHNJVEdsNTlKZ0kyNGxVK3VkUkRkUTE2OThOdDhieERxa042bDZHd2wv?=
 =?utf-8?B?VnJpa1N0U255dU0xQTVTczd1RWpyL2Z5Y1BqQmJKemJ1Uk83NzRtcEdyMmgz?=
 =?utf-8?B?UDliNyt1S3dWa3NCOHF1RUEyc1UxNzRpbU14NjlCREJwRlJ5VnV0ZHVWL1N2?=
 =?utf-8?B?TFNicW1JUURIaW8zQTliZDBnY1Q2dEFLMitEbFJmbGVpMDB2dXFlSXJwV1kz?=
 =?utf-8?B?cElJQjJTbVQremJsWmgxQ0p4aEdOOXhGK0Zaa1JJRnE2NVN0WTRnMnEyYk9Y?=
 =?utf-8?B?N2JNYWpiclV5K1p0NHBEV3NnOGtoYmwyZVpCdkN1Q3VZSUNxb3BlMytSWTVP?=
 =?utf-8?B?YURYTzdWcGhFNFRzNXp6N0FBTEVvTENGOWdEeVVyWk9qNjlndWJML1ZleC9K?=
 =?utf-8?B?MGhwOUVTVVVJSkoydzMyNnhPck1TcHJ3SEY4Snl2dVNpVmJNK2pVMEgwYXcw?=
 =?utf-8?B?eldwSEc1ZmpaK3A3RnNWTnM3dUhVMWNXam9SQVhVN3VzSGlXajRMZk5MZjZy?=
 =?utf-8?B?UDFVM1pBM1M0dVhaNnJvalUzUlFJY2ZUdEMzenpCMGdnZkFzdllENEdhdzVa?=
 =?utf-8?B?d0tiRVVLaDB0cWFUaUdEbG9uT1FvUkV5QVR4ZmhNYlFqMjd0Nzl3OGpBVVlU?=
 =?utf-8?B?VnlJaVgyRGVVWHgySitVVnc2UE1ra1VsQTVXSkJDb1o4cUFWbGNuTWExelgz?=
 =?utf-8?B?a014OWoxQkdWaWsvZUxndUxwd1poNWtpbFlUYTNLMWk0RmtDb29ISUtSY1Rr?=
 =?utf-8?B?LzVic05OK0tjaTdCNS8xRXB2and1QUtkbkhsN1VUd3Y0V0hKVyt3K0ZHcWEz?=
 =?utf-8?B?Qm9XYklSZU1qejJNS282WEEvYUFyNU4wL3JSTmZaNUFuL2RhT0tyOVUvSjFE?=
 =?utf-8?B?cVhJZVRtVzZHYmtZREIrY2w2VmZxTkFFcm0wZU12ZWRLRERPSVlGWjJtbVZC?=
 =?utf-8?B?OTdSckovVzdyRDdzNkZlUUh3QktnNlppOXhkNzhTdnJSbExQeS9BUFd5T05l?=
 =?utf-8?B?aWhBMjZDMkpYd3Z2eld3bTl4OEp5VUVtR21ISjZLQ1hHY3I4ZGx1SHplZkRG?=
 =?utf-8?B?aHBmb01NcVZRMU5Hd1lZNlJVczdkeG5kTmFJTHV5NVlJZzVwWjFxcWJqdTBt?=
 =?utf-8?B?NVRCRlFuY0lBeVpZcVh5aGhjSmV6SkxiNWV0UjEwQWVsNUJXRlVoOVNjZWpI?=
 =?utf-8?B?RFNZdHVVVTBkb2lLZUNjU09HL25USjZDNUZqeHVBYVhQcDBreVU1TSszRXZ1?=
 =?utf-8?B?RExDQnlSbTk5UWE0QWNnMGQwNzdaNmxrS0R2YnVnV1Eyekl1QjhlQ2F2RFJV?=
 =?utf-8?B?d05iQTUyRzZCWjRIVHpoL2VHR1ZtTzFqUjB1ZFNZTzRScTRtM3I4UE5MU3Fh?=
 =?utf-8?B?bUZ4aTNvdmcxYXpvWTZjcXJ4QkVOeHNmTU11QklmWUZyNE5ub01tU0NqOVdq?=
 =?utf-8?B?Y29sV3NJcjM0RFEwVnUwQk1SSXBXQlV5REFPUGJDL0lIRnQ1MUlWLzJ0bzdj?=
 =?utf-8?B?YjZmT1prODNLS2VjbTh6R0xCOUhWUWVCWUZZV012Ui9FekM3NzkzTmwxOTAw?=
 =?utf-8?B?MTY3d1RSa3EwaXIxUlJWMThCRkg0cE9YTkk2andkbk5nbDNBU3k5WFkxbC83?=
 =?utf-8?B?ZDhVeXkvemRzU0ltR1pieWRNSmpUMHkxcVFkZUJ5ZlZidnVQZmtoRmlUcnYr?=
 =?utf-8?B?OXJWcjhIcml2b2doWDV5ZnI1Nkh2K0hlNmhpSWtScGpKMHBaVEIxcDJlWGlv?=
 =?utf-8?B?akhORGNBdVczTE53S0ZDeE55b3RpeHZpQXdkTEtuZEFSbTNvYkgrME1sMDRE?=
 =?utf-8?B?SkwyRlpjU0hFZ0dTQUhjb1hFUnZZa2NMSTBncmJYWGZ1MWZUbDh6Q242SEl0?=
 =?utf-8?B?SGlsclRsYWNFa2NWMDZ0TjhDdlVYK0NjNDk0REY4S3Y2aVAza3BIOTEveGEv?=
 =?utf-8?B?aktSMlFQcUY2N0hkUDh1dFR6bGxsbU1QUXNCdmw5dWRrTERuUXJYek41KzNp?=
 =?utf-8?B?a0xzUVZKVUV3aEJBYTdtNzZZUlROWmJYZWZFRFE3TnNCTzV3SUNGUT09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-OGXwwZaaVOZMp8vfKfLn"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11c20a51-96db-4e69-cf4c-08da288b4810
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 20:19:50.0504
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ABRCKM1uZbqp1biSqcjJujESVi+2mMimTm2rM0qjDPj7Swl92h6DZrcBjrzy7HHu2RI2JwkicJyX/QamVslyEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3018

--=-OGXwwZaaVOZMp8vfKfLn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2022-04-27 at 12:06 +0200, Juergen Gross wrote:
> On 27.04.22 11:49, Michal Orzel wrote:
> > Function schedule_cpu_add defines and sets a variable old_unit but
> > does not make use of it. Remove this variable.
> >=20
> > Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>=20
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Acked-by: Dario Faggioli <dfaggioli@suse.com>

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-OGXwwZaaVOZMp8vfKfLn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJppWUACgkQFkJ4iaW4
c+6qphAAqfV2WX0utSzoBwSJJ72cgUufiGy4KM/UWozu3E3mGeze73nBzzq0Dr8r
G266KNfRoi7SFg9giBMsBfdzEp4br4Ha2kjCk9j/7JBROrBtmfwv2zEB4ya8qTwl
s5tNNW3P1aaBcQ+PvbR55XOI3SbgCqSrFBaKrep8fXY1NjVV5THXgeUMv55ge3LP
N4dIw9D5nlwlaMdPmlZAwkGGIuaDgCYzbGj+ZjhaDM9naY46RPW3lSwjBO1pFrpQ
fw8xVGHUEugGb/KQwizZyJIJG32jOwlhpFRx1s6oVY6JBbFj4mdx7hf+FUhFP/wD
pzmteKTYOZdWzJu1Qy/HhcRbETlShtFP89FjVA0NwOcfKjb8NscqNWj9PVxOi8WN
0nlv8NnrmSLP19KlKa2YyD7vHWGkGRjslAim3KkCERPWek03fPyLbvKafl6sKCRl
9LEApTZycPXnQ6nKCF1DA5nvnggcPVqUTye0aJxEIB+f8vYVUDE+TUrpp49393G+
BBNlvd4t2wuOL482a7oRVKpu6ouCp9Zs8m4IT+QBcedXwNP1YljPOPU6ImcHNXF1
7A4D6QgRLBvIeUyvoeED1ZSHbjukJ26kEWYk/bvivsYLVVTCNwLwRMvap4Di95dg
A/+EstApKMVdAZodisrY5YuBYSQPCmMR5xXBQmoxHERQ9GewgMg=
=5bR+
-----END PGP SIGNATURE-----

--=-OGXwwZaaVOZMp8vfKfLn--



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 20:48:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 20:48:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315444.533995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njoaK-0002XU-9G; Wed, 27 Apr 2022 20:48:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315444.533995; Wed, 27 Apr 2022 20:48:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njoaK-0002XN-6B; Wed, 27 Apr 2022 20:48:28 +0000
Received: by outflank-mailman (input) for mailman id 315444;
 Wed, 27 Apr 2022 20:48:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njoaJ-0002XD-R4; Wed, 27 Apr 2022 20:48:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njoaJ-0006Yu-Oc; Wed, 27 Apr 2022 20:48:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njoaJ-0004Hn-FJ; Wed, 27 Apr 2022 20:48:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njoaJ-0002JM-Ep; Wed, 27 Apr 2022 20:48:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zB1VfeePXKlGeaMwzoIxgQ1xN8z9/Apjp0X05yHpuG0=; b=eRmJd5QjViWpAssu1rlgAEJnns
	p7y1XWCg7rJ06N4pOUA1WWmgiS7F9+NZJhnzFFrf9X/rxxju15mz/I04hvv625c0TXAb6AlxExamz
	NT2p48yyGqpudLQbCyvS1Aes7Mbl+quyD80y+UpAjnEoxkx0J5p7mQ9mBzqfwsoCAaqY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169793-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169793: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 20:48:27 +0000

flight 169793 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169793/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  666 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    1 days   38 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 21:04:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 21:04:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315454.534013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njopV-0004sm-Mm; Wed, 27 Apr 2022 21:04:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315454.534013; Wed, 27 Apr 2022 21:04:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njopV-0004sf-HP; Wed, 27 Apr 2022 21:04:09 +0000
Received: by outflank-mailman (input) for mailman id 315454;
 Wed, 27 Apr 2022 21:04:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njopU-0004sP-SP; Wed, 27 Apr 2022 21:04:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njopU-0006qH-QX; Wed, 27 Apr 2022 21:04:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njopU-0005Aw-JA; Wed, 27 Apr 2022 21:04:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njopU-0000ge-Ik; Wed, 27 Apr 2022 21:04:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WemcyO6rDW2koBVp3TVD1D63k56XK/tl39sVvbLMaNQ=; b=cVHwaacHyrZi9JzhQpPvoG9Ks+
	vFSEfLxauPRS0/XuO0Be3iFbv1QeIzWBJCf3JT2i5mBVcVt0sPB0fuGQWZEOG4toWyY4CPpCskuDY
	vOHi87tKFR/pEphaoP4PFRu2cZqlU8ODxHkk2Ful45jkuw44zijEa4tsHvJJ3Te9Cfvg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169788-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169788: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=53b705d02cec03861044e673536586bd1b2443bd
X-Osstest-Versions-That:
    xen=163071b1800304c962756789b4ef0ddb978059ba
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 21:04:08 +0000

flight 169788 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169788/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  53b705d02cec03861044e673536586bd1b2443bd
baseline version:
 xen                  163071b1800304c962756789b4ef0ddb978059ba

Last test of basis   169773  2022-04-27 08:01:54 Z    0 days
Failing since        169781  2022-04-27 12:01:52 Z    0 days    2 attempts
Testing same since   169788  2022-04-27 17:01:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   163071b180..53b705d02c  53b705d02cec03861044e673536586bd1b2443bd -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 21:47:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 21:47:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315463.534027 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njpVK-0000dR-2Q; Wed, 27 Apr 2022 21:47:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315463.534027; Wed, 27 Apr 2022 21:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njpVJ-0000dK-Uq; Wed, 27 Apr 2022 21:47:21 +0000
Received: by outflank-mailman (input) for mailman id 315463;
 Wed, 27 Apr 2022 21:47:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njpVI-0000dA-Tw; Wed, 27 Apr 2022 21:47:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njpVI-0007VP-RU; Wed, 27 Apr 2022 21:47:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njpVI-0006R6-Jh; Wed, 27 Apr 2022 21:47:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njpVI-0007ma-JD; Wed, 27 Apr 2022 21:47:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Vbz9t8T530vgcT+2htdQZCNJ7O5anN+XA8dMi3IFpUg=; b=baloqeJOa0CJqCPqNvnlLXFHla
	UclDVJOYOMlIlihad2rCZpjFvGG+VaMWiq6SUuHeSkMpPQOK3cLPIfWh37C5ZTrKsXvsoBHLJGAiY
	jQJyERQqjTDxzLNwQJ7ZMzdAKSuomz63eXr9MhOtehW1TJcJDrTBsHeh0zgk4GWoDnzA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169796-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169796: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 21:47:20 +0000

flight 169796 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169796/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  667 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   39 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 22:13:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 22:13:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315506.534056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njpuS-0004zr-Fg; Wed, 27 Apr 2022 22:13:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315506.534056; Wed, 27 Apr 2022 22:13:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njpuS-0004zk-Ax; Wed, 27 Apr 2022 22:13:20 +0000
Received: by outflank-mailman (input) for mailman id 315506;
 Wed, 27 Apr 2022 22:13:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=83Ve=VF=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njpuQ-0004ze-GQ
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:13:18 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3caa90ca-c677-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:13:17 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id C5194B82AEA;
 Wed, 27 Apr 2022 22:13:15 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E88BC385A7;
 Wed, 27 Apr 2022 22:13:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3caa90ca-c677-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651097594;
	bh=8HG3IGpTV0uMVUVj8HuvUnBwaKHL1eRgjtJbwsIyR/M=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=QjIuwRYLl56Rq3cyIOIl3EiMmoOv0ujJPRXwGv9mwJYolu0csCqrkc1XUemakdHtE
	 h437uwUpgZDNTMYtiQzLdWvYt0getuBpxuFEr9QygdYUxouHLKqaPjat3PnQ4nA8Yg
	 c98bqhaZliD5zz8f5E7SFAk8HCRvnHgW1sHyFMoLC4mqsw05DAnwQRsvK1UDJGVUdt
	 U/QJnSAREr/f9ZQk/lLt5m+kUtVv1eWg/EZutNr2vc5dPyFOwb/pJlE5L+dn/75Wv7
	 78INbujsrG7gntSnuwRTou5QxNLXQIsWstZfinT+M4o6TE1yLR65Kc5WPp1sf30mW3
	 yBv+Iq0DJAQsg==
Date: Wed, 27 Apr 2022 15:13:13 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Roger Pau Monne <roger.pau@citrix.com>
cc: xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH] cirrus-ci: add FreeBSD 14 task
In-Reply-To: <20220427155023.84403-1-roger.pau@citrix.com>
Message-ID: <alpine.DEB.2.22.394.2204271512360.915916@ubuntu-linux-20-04-desktop>
References: <20220427155023.84403-1-roger.pau@citrix.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-2109456191-1651097594=:915916"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-2109456191-1651097594=:915916
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 27 Apr 2022, Roger Pau Monne wrote:
> Introduce a task that uses a FreeBSD 14 (HEAD) snapshot.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


Roger, should you add an entry to MAINTAINERS to set yourself as
maintainer of .cirrus.yml ?


> ---
>  .cirrus.yml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/.cirrus.yml b/.cirrus.yml
> index 4ae719136e..c38333e736 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -24,3 +24,9 @@ task:
>    freebsd_instance:
>      image_family: freebsd-13-0
>    << : *FREEBSD_TEMPLATE
> +
> +task:
> +  name: 'FreeBSD 14'
> +  freebsd_instance:
> +    image_family: freebsd-14-0-snap
> +  << : *FREEBSD_TEMPLATE
> -- 
> 2.35.1
> 
--8323329-2109456191-1651097594=:915916--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 22:29:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 22:29:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315514.534067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqA4-0006ai-QY; Wed, 27 Apr 2022 22:29:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315514.534067; Wed, 27 Apr 2022 22:29:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqA4-0006ab-NX; Wed, 27 Apr 2022 22:29:28 +0000
Received: by outflank-mailman (input) for mailman id 315514;
 Wed, 27 Apr 2022 22:29:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=83Ve=VF=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njqA4-0006aV-9D
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:29:28 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7e354513-c679-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:29:27 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D57F961DDD;
 Wed, 27 Apr 2022 22:29:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B47E5C385A9;
 Wed, 27 Apr 2022 22:29:23 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e354513-c679-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651098564;
	bh=kMi03hBeSV9xIMr6XmWomGlnlMewDhEalAJ2QeRe+3g=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=uZ1gnPAGJFxQ1sjeLUgykuG4PvUNGqmOJdBj4to/kubpIkC7NZ4u8BaulUPKy0TuO
	 hrEA2YOPoFQfy71FvjVf6WwZT6PZ4aqoh2XmAJi6LnETFEmiHjEcEVG3+gZKwfkaUZ
	 A8kfqzRsgnlXZ5wA3oL0Q3AZd2Jh97nP1ac0QFjfR+WZJLY7VtetcLILSUlOgrwCtJ
	 TKrltObplk7CNL6NInMszXvkqKnJ8YrldJ1pXb+vMvyI+mgOrxBJqjcdvsJl9dfWu2
	 sUhssw4O3oDLBHhtGE7UBuSGIUFcu+zUE9rA5xD2kATYWtWGBVgqv5a5w8gYe3RF9i
	 LPX2DeV6d/FFw==
Date: Wed, 27 Apr 2022 15:29:22 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 8/8] drivers/exynos4210: Remove unused-but-set variable
In-Reply-To: <ce7b7364-553f-29b7-2cab-644930f4e143@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204271528330.915916@ubuntu-linux-20-04-desktop>
References: <20220427094941.291554-1-michal.orzel@arm.com> <20220427094941.291554-9-michal.orzel@arm.com> <ce7b7364-553f-29b7-2cab-644930f4e143@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 27 Apr 2022, Julien Grall wrote:
> On 27/04/2022 10:49, Michal Orzel wrote:
> > Function exynos4210_uart_init_preirq defines and sets a variable
> > divisor but does not make use of it. Remove the definition and comment
> > out the assignment as this function already has some TODOs.
> > 
> > Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> > ---
> > Commenting out a code is a bad practise as well as using TODOs.
> 
> I disagree, having TODOs in the code is useful to track issues that are not
> critical or necessary to update the support state.
> 
> > However the only alternative would be to get rid of divisor variable
> > and TODO comments. I'm open for solutions.
> 
> I am not overly happy with commented code, but I prefer it over removing the
> TODOs comment as you wouldn't address them and the issues are not fixed.
> 
> So for this patch:
> 
> Acked-by: Julien Grall <jgrall@amazon.com>

I share the same opinion. I committed all patches except for patch #3
that requires further discussions/changes.


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 22:31:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 22:31:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315521.534077 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqCP-0007xM-73; Wed, 27 Apr 2022 22:31:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315521.534077; Wed, 27 Apr 2022 22:31:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqCP-0007x7-3o; Wed, 27 Apr 2022 22:31:53 +0000
Received: by outflank-mailman (input) for mailman id 315521;
 Wed, 27 Apr 2022 22:31:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njqCO-0007wm-0y; Wed, 27 Apr 2022 22:31:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njqCN-0008Fg-Tt; Wed, 27 Apr 2022 22:31:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njqCN-0007qd-Hb; Wed, 27 Apr 2022 22:31:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njqCN-00086I-HA; Wed, 27 Apr 2022 22:31:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=z2obk5cM67HLGJR5bCA4EDw10tDcwIViJlJdB5ZjSs8=; b=vaNsiCN1bE1BhyFsTo+DPzO6bn
	CWSj5ftOX9CuDbliRhjw++Ck7ylG5WgspHnuuNtinrfMc7CDZ6ac34zXoP7483fwIBR7WVzMpyhDr
	/toytpnwJytFeslZVuUJBHtD5IZs+ybvL/OkzqDZxYhgkH5Dk/pn1ryk69YsQ46TVI0s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169775-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169775: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3f5d61466345ed2213de2d7e391b6cd6d4b86015
X-Osstest-Versions-That:
    xen=2419a159fb943c24a6f2439604b9fdb1478fcd08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 22:31:51 +0000

flight 169775 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169775/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-pair     11 xen-install/dst_host fail in 169756 pass in 169775
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 169756 pass in 169775
 test-amd64-i386-migrupgrade  10 xen-install/src_host       fail pass in 169756
 test-amd64-i386-xl-shadow     7 xen-install                fail pass in 169756

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169723
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169723
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169723
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169723
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169723
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169723
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169723
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169723
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169723
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169723
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169723
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169723
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  3f5d61466345ed2213de2d7e391b6cd6d4b86015
baseline version:
 xen                  2419a159fb943c24a6f2439604b9fdb1478fcd08

Last test of basis   169723  2022-04-26 01:51:45 Z    1 days
Testing same since   169756  2022-04-26 20:07:56 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2419a159fb..3f5d614663  3f5d61466345ed2213de2d7e391b6cd6d4b86015 -> master


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 22:32:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 22:32:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315527.534088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqCh-0008Oa-Jd; Wed, 27 Apr 2022 22:32:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315527.534088; Wed, 27 Apr 2022 22:32:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqCh-0008OT-GU; Wed, 27 Apr 2022 22:32:11 +0000
Received: by outflank-mailman (input) for mailman id 315527;
 Wed, 27 Apr 2022 22:32:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=83Ve=VF=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njqCg-0008KC-6J
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:32:10 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dff0fb50-c679-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:32:09 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id EF1AAB8294B;
 Wed, 27 Apr 2022 22:32:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28CC7C385A9;
 Wed, 27 Apr 2022 22:32:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dff0fb50-c679-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651098727;
	bh=T7AIimEtBLbKGzAQJkMGx/guL8LGImB+9SfmyD7tXUs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DwmphQrdLJg9YUl7yMi2k1JibSTYQhs4uwEO3Ej5SJLShx6ZcoEWXaUcY9gQMP4dR
	 GXKQHnBWNp85+jhOdn9N5FafcNzcRE2sGL6NwJk3ChXna7+/LkRI4pqhxgTAlHP/wq
	 Z491AJZ8aPi0iJnju3sn96lvy8vwBL6iB5ZOAn0b9O02VL2OYiH+HZr0wJRQPsNSMJ
	 8jR/4Ym0STm5aL5A2TM0NKGkb2HMoeLgV14tm0D7vcdJMkk12ktxHntmf7+ssZqwJ8
	 V1oFvWDG974R0KpHbJBDDFvEtHP4FPhSw74vi41uXlXMg+46LrJnv7qoiI2MHKUYkG
	 APBnpuky72D+Q==
Date: Wed, 27 Apr 2022 15:32:06 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Penny Zheng <Penny.Zheng@arm.com>
cc: Julien Grall <julien@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>
Subject: RE: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is
 static
In-Reply-To: <DU2PR08MB73250C2576634910269805CFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2204271531410.915916@ubuntu-linux-20-04-desktop>
References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-6-Penny.Zheng@arm.com> <95b1d82e-92fa-7468-d3aa-038f0de937d9@xen.org> <DU2PR08MB73250D118F81DF1FF2C89DAFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com> <433f9e2a-9da7-662f-04b5-0379eca7496f@xen.org>
 <DU2PR08MB73250C2576634910269805CFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 27 Apr 2022, Penny Zheng wrote:
> > Hi Penny,
> > 
> > On 27/04/2022 11:19, Penny Zheng wrote:
> > >>> +/*
> > >>> + * Put free pages on the resv page list after having taken them
> > >>> + * off the "normal" page list, when pages from static memory  */
> > >>> +#ifdef CONFIG_STATIC_MEMORY
> > >>> +#define arch_free_heap_page(d, pg) ({                   \
> > >>> +    page_list_del(pg, page_to_list(d, pg));             \
> > >>> +    if ( (pg)->count_info & PGC_reserved )              \
> > >>> +        page_list_add_tail(pg, &(d)->resv_page_list);   \
> > >>> +})
> > >>> +#endif
> > >>
> > >> I am a bit puzzled how this is meant to work.
> > >>
> > >> Looking at the code, arch_free_heap_page() will be called from
> > >> free_domheap_pages(). If I am not mistaken, reserved pages are not
> > >> considered as xen heap pages, so we would go in the else which will
> > >> end up to call free_heap_pages().
> > >>
> > >> free_heap_pages() will end up to add the page in the heap allocator
> > >> and corrupt the d->resv_page_list because there are only one link list.
> > >>
> > >> What did I miss?
> > >>
> > >
> > > In my first commit "do not free reserved memory into heap", I've
> > > changed the behavior for reserved pages in free_heap_pages()
> > > +    if ( pg->count_info & PGC_reserved )that
> > > +        /* Reserved page shall not go back to the heap. */
> > > +        return free_staticmem_pages(pg, 1UL << order, need_scrub);
> > > +
> > 
> > Hmmm... somehow this e-mail is neither in my inbox nor in the archives on
> > lore.kernel.org.
> > 
> 
> Oh.... I just got email from tessian that they held my first commit, and needed my
> confirmation to send. So sorry about that!!!
> 
> I'll re-send my first commit ASAP.

Just FYI I still cannot see the first patch anywhere in my inbox


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 22:32:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 22:32:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315528.534099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqCl-0000K3-RR; Wed, 27 Apr 2022 22:32:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315528.534099; Wed, 27 Apr 2022 22:32:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqCl-0000Jw-OC; Wed, 27 Apr 2022 22:32:15 +0000
Received: by outflank-mailman (input) for mailman id 315528;
 Wed, 27 Apr 2022 22:32:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njqCj-0000IB-Q9; Wed, 27 Apr 2022 22:32:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njqCj-0008G9-PM; Wed, 27 Apr 2022 22:32:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njqCj-0007qn-J7; Wed, 27 Apr 2022 22:32:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njqCj-00086w-Ih; Wed, 27 Apr 2022 22:32:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xTEgNr4hVExDjEKnaFXpddBCdhXjHc1XVk53rqdvPIc=; b=o69JkGHsAVMPG+lKTA68oh92Sa
	N6UhcrF4y1Tb5OxwoZVdEB95Emhe7puvLAPJucdMAf3+WBeLTFQUT1azX/9RBWkImwMLDE6LbVPxQ
	6vCfGKOkSNr4SN3YwEnqpHkiRTu25Mc7PC2F3HqzOQhLZCDKzdRW5OFr1lHZSxs9fmos=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169797-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169797: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Apr 2022 22:32:13 +0000

flight 169797 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169797/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  668 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   40 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315620.534161 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqfk-000508-OS; Wed, 27 Apr 2022 23:02:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315620.534161; Wed, 27 Apr 2022 23:02:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqfk-000501-LL; Wed, 27 Apr 2022 23:02:12 +0000
Received: by outflank-mailman (input) for mailman id 315620;
 Wed, 27 Apr 2022 23:02:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=83Ve=VF=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njqfj-0004zv-7c
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 23:02:11 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 10168384-c67e-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 01:02:09 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8045C61EB1;
 Wed, 27 Apr 2022 23:02:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E312C385B3;
 Wed, 27 Apr 2022 23:02:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10168384-c67e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651100526;
	bh=2B0I6UKvUahmLNSo7IJecEPRSchsOYXKzGhpm2fjGfA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=iWBvdqT4Qbwoh8GS0FE0U+3z8IjbOdIrIB+iUg8neoPXQ/0gONGe+OhYJN+vMexTB
	 IAsa7lGrQ8KxXbqwxi8iA2tMb6cYDi3NyE374HAKBYxHXe9IxD9TV0gkAQmM8ZS9Z4
	 lxzOaUjoeoLvll8SKdhSqH6dFWAk1HZk6ibxPsW9oZl5Rr9TlylM39adOi91tW4kzM
	 h8FOt9hL48grw2OKXn2Wy2XjaChLVMLrcTsG8KbOFyzbUvxPZ42N4IJ3tvyS8P6Uff
	 OKbNTDYsY5ErNtrUxecTB/IVX3DJGW48T5wbtnk/ZZsaGMH+uBF3JMB87oScH9eKRO
	 lFFGSWaT4p9PA==
Date: Wed, 27 Apr 2022 16:02:05 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: osstest service owner <osstest-admin@xenproject.org>, 
    xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>, 
    David Vrabel <dvrabel@amazon.co.uk>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
In-Reply-To: <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop>
References: <osstest-169781-mainreport@xen.org> <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 27 Apr 2022, Julien Grall wrote:
> On 27/04/2022 17:38, osstest service owner wrote:
> > flight 169781 xen-unstable-smoke real [real]
> > flight 169785 xen-unstable-smoke real-retest [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/169781/
> > http://logs.test-lab.xenproject.org/osstest/logs/169785/
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >   test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs.
> > 169773
> 
> Well, I was overly optimistic :(. This now breaks in the ITS code:
> 
> Apr 27 13:23:14.324831 (XEN) Xen call trace:
> Apr 27 13:23:14.324855 (XEN)    [<000000000022a678>]
> alloc_xenheap_pages+0x178/0x194 (PC)
> Apr 27 13:23:14.336856 (XEN)    [<000000000022a670>]
> alloc_xenheap_pages+0x170/0x194 (LR)
> Apr 27 13:23:14.336886 (XEN)    [<0000000000237770>] _xmalloc+0x144/0x294
> Apr 27 13:23:14.348773 (XEN)    [<00000000002378d4>] _xzalloc+0x14/0x30
> Apr 27 13:23:14.348808 (XEN)    [<000000000027b4e4>]
> gicv3_lpi_init_rdist+0x54/0x324
> Apr 27 13:23:14.348835 (XEN)    [<0000000000279898>]
> arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46c
> Apr 27 13:23:14.360799 (XEN)    [<0000000000279bfc>]
> arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0x20/0x50
> Apr 27 13:23:14.372796 (XEN)    [<0000000000277054>]
> gic_init_secondary_cpu+0x18/0x30
> Apr 27 13:23:14.372829 (XEN)    [<0000000000284518>]
> start_secondary+0x1a8/0x234
> Apr 27 13:23:14.372856 (XEN)    [<0000010722aa4200>] 0000010722aa4200
> Apr 27 13:23:14.384793 (XEN)
> Apr 27 13:23:14.384823 (XEN)
> Apr 27 13:23:14.384845 (XEN) ****************************************
> Apr 27 13:23:14.384869 (XEN) Panic on CPU 2:
> Apr 27 13:23:14.384891 (XEN) Assertion '!in_irq() && (local_irq_is_enabled()
> || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212
> Apr 27 13:23:14.396805 (XEN) ****************************************
> 
> The GICv3 LPI code contains a few calls to xmalloc() that will be done while
> initializing the GIC CPU interface. I don't think we can delay the
> initialization of the LPI part past local_irq_enable(). So I think we will
> need to allocate the memory when preparing the CPU.
> 
> Any thoughts?


As a general principle I think the ASSERT is a good idea, and it should
make the code better and safer. I would not change the code to make the
ASSERT go away if not to improve the code.

In this case, gicv3_lpi_init_rdist and gicv3_lpi_allocate_pendtable
should be __init functions although they are not marked as __init at the
moment.

It seems to me that it is acceptable to allocate memory with interrupt
disabled during __init. I cannot see any drawbacks with it. I think we
should change the ASSERT to only trigger after __init: system_state ==
SYS_STATE_active.

What do you think?


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315433.534172 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgC-0005Q1-2X; Wed, 27 Apr 2022 23:02:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315433.534172; Wed, 27 Apr 2022 23:02:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgB-0005Pq-U1; Wed, 27 Apr 2022 23:02:39 +0000
Received: by outflank-mailman (input) for mailman id 315433;
 Wed, 27 Apr 2022 20:02:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uiE5=VF=xilinx.com=stefanos@srs-se1.protection.inumbo.net>)
 id 1njnrR-0006eW-VX
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 20:02:06 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
 (mail-bn7nam10on20610.outbound.protection.outlook.com
 [2a01:111:f400:7e8a::610])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7e78e8d-c664-11ec-a405-831a346695d4;
 Wed, 27 Apr 2022 22:02:04 +0200 (CEST)
Received: from MN2PR02MB6735.namprd02.prod.outlook.com (2603:10b6:208:1d7::9)
 by DM6PR02MB6202.namprd02.prod.outlook.com (2603:10b6:5:1f6::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr
 2022 20:02:00 +0000
Received: from MN2PR02MB6735.namprd02.prod.outlook.com
 ([fe80::644a:36a0:8412:7bf2]) by MN2PR02MB6735.namprd02.prod.outlook.com
 ([fe80::644a:36a0:8412:7bf2%7]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022
 20:02:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7e78e8d-c664-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UO17iOMgZgG9HZL22JUBhEhx3QsvPHB+rc8RRSq8c4eUWaeJmNg4JYBNu8W6Qru1OGEllsWoYtsfI8WGoWt024/2wdN0WXnX5x4cvGzqN3SpXG1pim7EzrxRJp2OFgaLONUpUJw8nhyk/iII9I8+K6nTakXK+aHCAWdydqmX8gsKkBtid5uEbwbHYhbUn5lEsmk2aPy8yIXpbjCxUJdA9xVAzWmZoe8dIVuN1DXh/K92oYxDo8eBNtsEggRlGo1bQyXk93jVKmy1dUfCFicL1c9xd0rWPGsrj3gdMA7Kry/YFlI7fnAbqYmCYF12tY4K5vaNMNrlFlbiea/MVihaSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pFBFzP+PLhAST/K7s7g7cso+IG34XV4WSITyCAz2l5Y=;
 b=oKImo8AY+UA1nf7w/CqAiOeXtpfJK+RPlbPeNcxd3MnbtpF1vfGPURFNQpxG3oMQqsIH4RZWxNHa5F029/QUnJVVXWp/K/qluc3uW0icEJ7u+olH1a5iaPAYqqI5+mVU7OOHkKA8o+pHj1LjX9c1790kOVDhYV9hYYXP3abC5beBIjSnfeJfgHzbakx9uEnzsFC9x2iutvsScVK/Y8NKRvl0pb+ZKntZJniZZ1gNSVqYicoBpcfRkx92Nh0K0ronOzZ3xisXS59+GYJkC5D0/IoFpzbYvHXQYiRxEyXSdSKLRqUP0qBJeiwIfKWbWCF2BGUyPpF0tsK0vUyW47ZiXg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com;
 dkim=pass header.d=xilinx.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pFBFzP+PLhAST/K7s7g7cso+IG34XV4WSITyCAz2l5Y=;
 b=GBf4vJ2VxpjEZk83LqZgAd/5dP6cKxdq8FCoQaBdrWuCTNnZhBEpqYiViEbNRdw7QAzZQzOvMdu/hDEFMviHOsCPoEFjIgilh950DwPK6KsbarfM1e2nKIxMAXOCvx4KChypHSPv10tAI8lGQ8I++5pKQkm7+EZvFK+AzKUhRHo=
From: Stefano Stabellini <stefanos@xilinx.com>
To: "jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "julien@xen.org" <julien@xen.org>,
	"Bertrand.Marquis@arm.com" <Bertrand.Marquis@arm.com>, "roger.pau@citrix.com"
	<roger.pau@citrix.com>, "jgrall@amazon.co.uk" <jgrall@amazon.co.uk>
CC: Artem Mygaiev <Artem_Mygaiev@epam.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Roberto Bagnara
	<roberto.bagnara@bugseng.com>
Subject: Xen and MISRA C
Thread-Topic: Xen and MISRA C
Thread-Index: AdhacUrlvS+VJZZQSkqstKYTX0mVww==
Date: Wed, 27 Apr 2022 20:02:00 +0000
Message-ID:
 <MN2PR02MB6735E566BE6BF5B740836111A0FA9@MN2PR02MB6735.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=xilinx.com;
x-ms-exchange-calendar-series-instance-id:
 BAAAAIIA4AB0xbcQGoLgCAAAAADx6M1KcVrYAQAAAAAAAAAAEAAAANOH5Ssr/q9GjEWLMGO4ivY=
x-ms-traffictypediagnostic:
 MN2PR02MB6735:EE_MeetingMessage|DM6PR02MB6202:EE_MeetingMessage
x-ms-office365-filtering-correlation-id: 9d8a64ae-de6b-4328-9158-08da2888ca66
x-microsoft-antispam-prvs:
 <DM6PR02MB620248FD2E967173069AE6E4A0FA9@DM6PR02MB6202.namprd02.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 /lRwVZlaG3FEYNF1zG/q11mt9U+JBYGtwCjO3vH1JlYX2Cm4nRUdWKMlYCwQq6+FvALUIh1HSLS9d60oFzG0hRPAIQOrAdeRhrQcw17uAre7/Vpek1UzPdZwTDnvGSrOwwFGzTJqwRrZ6jYPPoGvMaKTVjGZDvRx2obM2iWXqEh2l8+vqqbQDuMPvhC27GPnlN3ghgDuO2SaOZ1oqvrMOyf0ELKazmrYA3U120RAFhhG0iq1kLmFBomw6cA/vUmlpSpnEt5ApKGs1VLDJTZhy4DDKHxacFiSng/AU7J358vrLZ/nQaO2aI15C694gMdjuQi+6HaKVOs7JpoL4s1WNSc1yrCJBD5YjVrIM4UbuRrv0aBiPCDMtP+aesTzzBhkr8vuRIah29gmE0UzEXrAQWSwK3NCWT7IvGStjHPHipuc5dbmvhqsaAKftlLyKWkES5qouAMPRyzr1YuORZefGyzaG9ODgY+atotqSKzSYjy05IhtENP3yE0bg4/1ubJOjRbo4TJo7O/lGftvm68fgLf4qFftVubmcSgu21bPMM38CdYpfoXxspukY9PwRg1eBhEt/gHeeFD4SSbP6gA24AQVPjPIvM/hBmtO+dsvh/cS8EmNnfmZsBkUOQn+H20kV7sfkqc/kHxfl9dwRlRIm8p6uXUKm8g8a6MC/XMzTmSkZ6PKIE8Eoo4Cc3fmZMgGZ09p9bqRIaeCXJeaAUKn9tKWRNQBQBowpXUGeawDax0s0GTkRvpM4sMxRcBy3WVtAI77Gx0FHZvU76U3z0NMYznZfKYDa0/q5BfZpnJ+giV43vQZwaKrQtSxVAp2wVKkLastMo3QtZ8zfZ7Olh5Nsg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR02MB6735.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(38100700002)(4326008)(9686003)(64756008)(122000001)(66476007)(66556008)(66446008)(38070700005)(52536014)(76116006)(8676002)(26005)(966005)(166002)(71200400001)(316002)(55016003)(5660300002)(110136005)(3480700007)(91956017)(8936002)(508600001)(7416002)(86362001)(7696005)(6506007)(40140700001)(2906002)(186003)(33656002)(54906003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?/wmCrOySTcJgTOCS8HWNYoKwDAojnAppQtXxZRLaxlrR/1SANexSwLAiTP?=
 =?iso-8859-1?Q?iFjiHYaBleBVNo6i6VdM25P/VJ+CVagD4CgD6lOXukW+im1RVPrl8X5pOi?=
 =?iso-8859-1?Q?y7Jgt20HXNCQfPxcbTwAqtXzsGdyiJhNP8dQ3DFGh86XXwO9qgCa3GtCqJ?=
 =?iso-8859-1?Q?fr+JjwcElrEjLAnIflMH14PqrYhcB+IyGGm58KZ8n4MziIRXrBs7+fPUnH?=
 =?iso-8859-1?Q?60FQFXkey2+ODXpS2Sfh5lTaGwiWtZB2zJYM0vIKOasfgeys4L6AXzTQAj?=
 =?iso-8859-1?Q?a0KgfWov4Snw4sbh4cZvJ+YOazQRhM3DiNfMOFH6pZIr8fyG+hcg3bg2rk?=
 =?iso-8859-1?Q?FtAiSoNN8VOSBMy59KG46sY4EMRtC33D19nG5w83ozZPzv2dFG2h0RDYx1?=
 =?iso-8859-1?Q?54gPGq/LwTYOoBiBZuBV5fRowJ3oO9rQjc3rO6h9yQqQZY82T5xMZNNQsY?=
 =?iso-8859-1?Q?gSAYoVrsYsuf5WukTF5yREPZrYpx71P5Gpb/4Ci8bs9xvJAaCEDGfBvyGV?=
 =?iso-8859-1?Q?Nho3FhGbEUJfrMX8aF5+HQsKT98lKHMk4Com3aFAqgOQx9sRBdu/Sx+8g7?=
 =?iso-8859-1?Q?467OW+3sT5iMrxRsj35IJ6TpTWsqwXYHIL4dO4MSx7fZXRAgarg+ua6OF2?=
 =?iso-8859-1?Q?B4npXwGgchaDz+lF9ETDYhEOLGcin8xHgqdLOFo3YIyiMTVicR1vQOcScO?=
 =?iso-8859-1?Q?UdHC0byndIyYMfKhebIi1dfEWm38cc7iX7YZGTcr4Y2zb1JY39r44RhIGn?=
 =?iso-8859-1?Q?wBTq9rt3yEHi7Ee1K1MxFmfjnu050ZJ7OblvukLDwy8lgI4F/ilr6FRwvW?=
 =?iso-8859-1?Q?5DCzHFri56qIFRY3awKK0v1wU1jiIHQg4aggK+VtfPV3/c3sDoX3w1vumU?=
 =?iso-8859-1?Q?gB9ZHo/2M0/ew4vvAigBxPKK1IVLF96Tt3nrAXHJjW6WAA4oylTGIEqhRb?=
 =?iso-8859-1?Q?IA7tiRx5S+1Iyr4Sj2YKoF8GBGPwZe3NxC1lnleH/rHgHNw5WDiJLF5nSg?=
 =?iso-8859-1?Q?cMb3g3itEutueg9mxTu4yXyZ4mGo7T2P1HGKIwjZxtNDtC6qSySkdGo0eN?=
 =?iso-8859-1?Q?EPKyt8aUu4to12xHUzR2oGXpWrt2GE1I+V+0Ob2rPH6meG98g7iLYoGfWl?=
 =?iso-8859-1?Q?IHK6+U52ojbxOp3pWawaOJ3Tb9jkYSZ2zXpm42ftefyz1lUkXlcODf1x4d?=
 =?iso-8859-1?Q?wlQZz8gvQI32TQGbUD5O+4qShejI4fgBuDU1iUdYXCjLDUfQMzaLQ2sbvU?=
 =?iso-8859-1?Q?i+KEkaPIY2OZ210l3FbuVfQ1Dm1r9RLG0Tpoy6YtuF/c9izd4EmUqPXOzV?=
 =?iso-8859-1?Q?lEkllGtcphzLUYKIeKMKxbJIj4hr6yoGqWJShkBLS2g38aPCgB8ByvkKXe?=
 =?iso-8859-1?Q?yfOONHH3ZuIp4lW4+JcezQbAMm+yrC8aSjzDvLMrvwJcQBONvBbFJTGpyU?=
 =?iso-8859-1?Q?8DY86rfGRO+w4spvLrFmeIWKp/MctT2sRU7NC0gjEhHc5EysG91X+LUNu8?=
 =?iso-8859-1?Q?Mei5DUbefy07a/qOiXGfZIBTQQ7xqjFMyqo+VwZP/ab5VBzZj+1VoNa2lP?=
 =?iso-8859-1?Q?2FGHy+qvmhM3I47WJTO/g3gcLjUEzqlBib8vwlO5gXjy9IsYCl6LVIN8Pq?=
 =?iso-8859-1?Q?Z7e1qwdEFWnclMyCwyAHpEaw1JH+PPWT1INC8Y9LCS44yE4LL1HK8fUDri?=
 =?iso-8859-1?Q?ULc4Mo46n1qoY4GgMWqTcQ4MkDdYMXNCNoZZgSPOKQ2ZjFKKI6yQ11s7GF?=
 =?iso-8859-1?Q?r3cJwUj8PqehV9it74xi6moZhm12QV94QNMtJ9LLfkpY/HkC/iFaGU6t7w?=
 =?iso-8859-1?Q?7PoaRGWN4A=3D=3D?=
Content-Type: multipart/alternative;
	boundary="_000_MN2PR02MB6735E566BE6BF5B740836111A0FA9MN2PR02MB6735namp_"
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR02MB6735.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d8a64ae-de6b-4328-9158-08da2888ca66
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 20:02:00.2416
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +BGAsKQ+fJ8KpgJpNcjlRQISEXrwfoOxEPTBr2dSNL4DfINzbjXJbHPuaqzA7eFvq/g8YVRbEhOz7MHwczIRYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6202

--_000_MN2PR02MB6735E566BE6BF5B740836111A0FA9MN2PR02MB6735namp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable


 Xen Community meeting to discuss MISRA C adoption in Xen
[https://st2.zoom.us/static/6.1.6144/image/new/ZoomLogo_110_25.png] <https:=
//zoom.us>
Hi there,
Stefano Stabellini is inviting you to a scheduled Zoom meeting.
Join Zoom Meeting<https://xilinx.zoom.us/j/92403591689?from=3Daddon>
Phone one-tap:  US: +16699006833,,92403591689#<tel:+16699006833,,9240359168=
9#> or +17209289299,,92403591689#<tel:+17209289299,,92403591689#>
Meeting URL:    https://xilinx.zoom.us/j/92403591689?from=3Daddon
Meeting ID:     924 0359 1689
Join by Telephone
For higher quality, dial a number based on your current location.
Dial:
US: +1 669 900 6833 or +1 720 928 9299 or +1 929 205 6099 or 888 475 4499 (=
Toll Free) or 833 548 0276 (Toll Free) or 833 548 0282 (Toll Free) or 877 8=
53 5257 (Toll Free)
India: +91 226 480 2722 or +91 22 71 279 525 or +91 406 480 2722 or +91 446=
 480 2722 or +91 806 480 2722 or +91 80 71 279 440 or +91 116 480 2722 or +=
91 22 48 798 004 or +91 224 879 8012 or +91 225 097 2742 or +91 225 097 274=
3 or +91 225 097 2744 or +91 225 097 2745 or 000 800 050 5050 (Toll Free) o=
r 000 800 001 4002 (Toll Free)
Ireland: +353 1 653 3895 or +353 6 163 9031 or +353 1 536 9320 or 1800 943 =
965 (Toll Free) or 1800 949 238 (Toll Free) or 1800 901 561 (Toll Free)
Singapore: +65 3165 1065 or +65 3158 7288 or 800 101 3814 (Toll Free) or 80=
0 852 6054 (Toll Free) or 1800 407 5602 (Toll Free)
Meeting ID:     924 0359 1689
International numbers<https://xilinx.zoom.us/u/adNNo1nqsl>
Join from a Video Conference room system
Meeting ID:     924 0359 1689
US:     92403591689@global.zoomcrc.com
APAC:   92403591689@global.zoomcrc.com
India:  92403591689@global.zoomcrc.com
Europe:         92403591689@global.zoomcrc.com
SIP:    92403591689@zoomcrc.com

--_000_MN2PR02MB6735E566BE6BF5B740836111A0FA9MN2PR02MB6735namp_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
</head>
<body>
<span>
<div style=3D"font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12p=
t; color:rgb(0,0,0)">
<br>
</div>
</span>
<div class=3D"elementToProof"><span><a class=3D"x_MsoNormal">&nbsp;</a></sp=
an>Xen Community meeting to discuss MISRA C adoption in Xen</div>
<span>
<table border=3D"0" cellpadding=3D"0" cellspacing=3D"0" align=3D"center" st=
yle=3D"font-size:13px; color:#39394d; font-family:Arial; background-color:#=
f4f5f9; width:100%; height:100%; padding-bottom:10px">
<tbody>
<tr>
</tr>
</tbody>
</table>
<table border=3D"0" cellpadding=3D"0" cellspacing=3D"0" align=3D"center" st=
yle=3D"font-size:13px; color:#39394d; font-family:Arial; background-color:#=
f4f5f9; width:100%; height:100%; padding-bottom:10px">
<tbody>
<tr>
<td style=3D"vertical-align:top">
<table border=3D"0" cellpadding=3D"0" cellspacing=3D"0" align=3D"center" st=
yle=3D"width:592px">
<tbody>
<tr>
<td style=3D"">
<table border=3D"0" cellpadding=3D"0" cellspacing=3D"0" align=3D"center" st=
yle=3D"margin-left:0px; margin-right:0px; width:100%; background-color:#fff=
fff; padding-bottom:37px">
<tbody>
<tr>
<td style=3D"padding-top:30px; padding-bottom:10px; background-color:#f4f5f=
9"><a href=3D"https://zoom.us"><img width=3D"110" height=3D"25" border=3D"0=
" style=3D"border-style:solid" src=3D"https://st2.zoom.us/static/6.1.6144/i=
mage/new/ZoomLogo_110_25.png">
</a></td>
</tr>
<tr>
<td style=3D"padding-left:28px; padding-right:28px">
<table border=3D"0" cellpadding=3D"0" cellspacing=3D"0" align=3D"center" st=
yle=3D"width:100%; font-size:13px; color:#39394d; font-family:Arial">
<tbody>
<tr>
<td colspan=3D"2" style=3D"vertical-align:top; padding-top:57px; padding-bo=
ttom:10px">
Hi there,</td>
</tr>
<tr>
<td colspan=3D"2" style=3D"vertical-align:top; line-height:25px">Stefano St=
abellini is inviting you to a scheduled Zoom meeting.
</td>
</tr>
<tr>
<td colspan=3D"2" style=3D"background-color:#ffffff; padding-top:20px; line=
-height:34px; padding-bottom:8px">
<a href=3D"https://xilinx.zoom.us/j/92403591689?from=3Daddon" target=3D"_bl=
ank" style=3D"font-size:25px; font-weight:400; color:#2d8cff">Join Zoom Mee=
ting</a>
</td>
</tr>
<tr>
<td style=3D"height:18px; width:22%; vertical-align:top; line-height:20px">=
Phone one-tap:
</td>
<td style=3D"vertical-align:top; line-height:20px; padding-bottom:5px">US: =
<a href=3D"tel:+16699006833,,92403591689#">
+16699006833,,92403591689#</a> or <a href=3D"tel:+17209289299,,92403591689#=
">+17209289299,,92403591689#</a>
</td>
</tr>
<tr>
<td style=3D"height:18px; width:22%; vertical-align:top; line-height:20px">=
Meeting URL:
</td>
<td style=3D"vertical-align:top; line-height:20px"><a href=3D"https://xilin=
x.zoom.us/j/92403591689?from=3Daddon" target=3D"_blank" style=3D"font-size:=
13px; font-weight:400; color:#39394d">https://xilinx.zoom.us/j/92403591689?=
from=3Daddon</a>
</td>
</tr>
<tr>
<td style=3D"height:18px; width:22%; vertical-align:top">Meeting ID: </td>
<td style=3D"vertical-align:top">924 0359 1689</td>
</tr>
<tr>
<td colspan=3D"2" style=3D"font-family:Arial; font-size:16px; font-weight:6=
00; line-height:25px; color:#39394d; padding-top:20px; padding-bottom:9px">
Join by Telephone </td>
</tr>
<tr>
<td colspan=3D"2" style=3D"font-size:13px; color:#39394d; font-family:Arial=
; vertical-align:top; line-height:20px">
For higher quality, dial a number based on your current location. </td>
</tr>
<tr>
<td style=3D"width:22%; font-size:13px; color:#39394d; font-family:Arial; v=
ertical-align:top; line-height:20px">
Dial: </td>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; vertical-ali=
gn:top; line-height:20px; padding-bottom:10px">
<br>
US: +1 669 900 6833 or +1 720 928 9299 or +1 929 205 6099 or 888 475 4499 (=
Toll Free) or 833 548 0276 (Toll Free) or 833 548 0282 (Toll Free) or 877 8=
53 5257 (Toll Free)<br>
India: +91 226 480 2722 or +91 22 71 279 525 or +91 406 480 2722 or +91 446=
 480 2722 or +91 806 480 2722 or +91 80 71 279 440 or +91 116 480 2722 or +=
91 22 48 798 004 or +91 224 879 8012 or +91 225 097 2742 or +91 225 097 274=
3 or +91 225 097 2744 or +91 225
 097 2745 or 000 800 050 5050 (Toll Free) or 000 800 001 4002 (Toll Free)<b=
r>
Ireland: +353 1 653 3895 or +353 6 163 9031 or +353 1 536 9320 or 1800 943 =
965 (Toll Free) or 1800 949 238 (Toll Free) or 1800 901 561 (Toll Free)<br>
Singapore: +65 3165 1065 or +65 3158 7288 or 800 101 3814 (Toll Free) or 80=
0 852 6054 (Toll Free) or 1800 407 5602 (Toll Free)
</td>
</tr>
<tr>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; width:22%; v=
ertical-align:top; line-height:20px">
Meeting ID: </td>
<td style=3D"vertical-align:top; font-size:13px; color:#39394d; font-family=
:Arial; line-height:20px; padding-bottom:10px">
924 0359 1689</td>
</tr>
<tr>
<td colspan=3D"2" style=3D"font-size:13px; color:#39394d; font-family:Arial=
; vertical-align:top; line-height:20px">
<a href=3D"https://xilinx.zoom.us/u/adNNo1nqsl" target=3D"_blank" style=3D"=
font-size:13px; font-weight:400; color:#39394d">International numbers</a></=
td>
</tr>
<tr>
<td colspan=3D"2" style=3D"font-family:Arial; font-size:16px; font-weight:6=
00; line-height:25px; color:#39394d; padding-top:20px; padding-bottom:9px">
Join from a Video Conference room system </td>
</tr>
<tr>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; width:22%; v=
ertical-align:top; line-height:20px">
Meeting ID: </td>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; vertical-ali=
gn:top; line-height:20px; padding-bottom:5px">
924 0359 1689</td>
</tr>
<tr>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; width:22%; v=
ertical-align:top; line-height:20px">
US: </td>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; vertical-ali=
gn:top; line-height:20px; padding-bottom:5px">
92403591689@global.zoomcrc.com </td>
</tr>
<tr>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; width:22%; v=
ertical-align:top; line-height:20px">
APAC: </td>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; vertical-ali=
gn:top; line-height:20px; padding-bottom:5px">
92403591689@global.zoomcrc.com </td>
</tr>
<tr>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; width:22%; v=
ertical-align:top; line-height:20px">
India: </td>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; vertical-ali=
gn:top; line-height:20px; padding-bottom:5px">
92403591689@global.zoomcrc.com </td>
</tr>
<tr>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; width:22%; v=
ertical-align:top; line-height:20px">
Europe: </td>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; vertical-ali=
gn:top; line-height:20px; padding-bottom:5px">
92403591689@global.zoomcrc.com </td>
</tr>
<tr>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; width:22%; v=
ertical-align:top; line-height:20px">
SIP: </td>
<td style=3D"font-size:13px; color:#39394d; font-family:Arial; vertical-ali=
gn:top; line-height:20px; padding-bottom:5px">
92403591689@zoomcrc.com </td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
<a name=3D"x_zEnd"></a></span>
</body>
</html>

--_000_MN2PR02MB6735E566BE6BF5B740836111A0FA9MN2PR02MB6735namp_
Content-Type: text/calendar; charset="utf-8"; method=REQUEST
Content-Transfer-Encoding: base64

QkVHSU46VkNBTEVOREFSDQpNRVRIT0Q6UkVRVUVTVA0KUFJPRElEOk1pY3Jvc29mdCBFeGNoYW5n
ZSBTZXJ2ZXIgMjAxMA0KVkVSU0lPTjoyLjANCkJFR0lOOlZUSU1FWk9ORQ0KVFpJRDpQYWNpZmlj
IFN0YW5kYXJkIFRpbWUNCkJFR0lOOlNUQU5EQVJEDQpEVFNUQVJUOjE2MDEwMTAxVDAyMDAwMA0K
VFpPRkZTRVRGUk9NOi0wNzAwDQpUWk9GRlNFVFRPOi0wODAwDQpSUlVMRTpGUkVRPVlFQVJMWTtJ
TlRFUlZBTD0xO0JZREFZPTFTVTtCWU1PTlRIPTExDQpFTkQ6U1RBTkRBUkQNCkJFR0lOOkRBWUxJ
R0hUDQpEVFNUQVJUOjE2MDEwMTAxVDAyMDAwMA0KVFpPRkZTRVRGUk9NOi0wODAwDQpUWk9GRlNF
VFRPOi0wNzAwDQpSUlVMRTpGUkVRPVlFQVJMWTtJTlRFUlZBTD0xO0JZREFZPTJTVTtCWU1PTlRI
PTMNCkVORDpEQVlMSUdIVA0KRU5EOlZUSU1FWk9ORQ0KQkVHSU46VkVWRU5UDQpPUkdBTklaRVI7
Q049U3RlZmFubyBTdGFiZWxsaW5pOm1haWx0bzpzdGVmYW5vc0B4aWxpbnguY29tDQpBVFRFTkRF
RTtST0xFPVJFUS1QQVJUSUNJUEFOVDtQQVJUU1RBVD1ORUVEUy1BQ1RJT047UlNWUD1UUlVFO0NO
PWpiZXVsaWNoQHMNCiB1c2UuY29tOm1haWx0bzpqYmV1bGljaEBzdXNlLmNvbQ0KQVRURU5ERUU7
Uk9MRT1SRVEtUEFSVElDSVBBTlQ7UEFSVFNUQVQ9TkVFRFMtQUNUSU9OO1JTVlA9VFJVRTtDTj1h
bmRyZXcuY29vDQogcGVyM0BjaXRyaXguY29tOm1haWx0bzphbmRyZXcuY29vcGVyM0BjaXRyaXgu
Y29tDQpBVFRFTkRFRTtST0xFPVJFUS1QQVJUSUNJUEFOVDtQQVJUU1RBVD1ORUVEUy1BQ1RJT047
UlNWUD1UUlVFO0NOPWp1bGllbkB4ZW4NCiAub3JnOm1haWx0bzpqdWxpZW5AeGVuLm9yZw0KQVRU
RU5ERUU7Uk9MRT1SRVEtUEFSVElDSVBBTlQ7UEFSVFNUQVQ9TkVFRFMtQUNUSU9OO1JTVlA9VFJV
RTtDTj1CZXJ0cmFuZC5NDQogYXJxdWlzQGFybS5jb206bWFpbHRvOkJlcnRyYW5kLk1hcnF1aXNA
YXJtLmNvbQ0KQVRURU5ERUU7Uk9MRT1SRVEtUEFSVElDSVBBTlQ7UEFSVFNUQVQ9TkVFRFMtQUNU
SU9OO1JTVlA9VFJVRTtDTj1yb2dlci5wYXVADQogY2l0cml4LmNvbTptYWlsdG86cm9nZXIucGF1
QGNpdHJpeC5jb20NCkFUVEVOREVFO1JPTEU9UkVRLVBBUlRJQ0lQQU5UO1BBUlRTVEFUPU5FRURT
LUFDVElPTjtSU1ZQPVRSVUU7Q049amdyYWxsQGFtYQ0KIHpvbi5jby51azptYWlsdG86amdyYWxs
QGFtYXpvbi5jby51aw0KQVRURU5ERUU7Uk9MRT1PUFQtUEFSVElDSVBBTlQ7UEFSVFNUQVQ9TkVF
RFMtQUNUSU9OO1JTVlA9VFJVRTtDTj1BcnRlbSBNeWdhDQogaWV2Om1haWx0bzpBcnRlbV9NeWdh
aWV2QGVwYW0uY29tDQpBVFRFTkRFRTtST0xFPU9QVC1QQVJUSUNJUEFOVDtQQVJUU1RBVD1ORUVE
Uy1BQ1RJT047UlNWUD1UUlVFO0NOPWdlb3JnZS5kdW4NCiBsYXBAY2l0cml4LmNvbTptYWlsdG86
Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tDQpBVFRFTkRFRTtST0xFPU9QVC1QQVJUSUNJUEFOVDtQ
QVJUU1RBVD1ORUVEUy1BQ1RJT047UlNWUD1UUlVFO0NOPXhlbi1kZXZlbEANCiBsaXN0cy54ZW5w
cm9qZWN0Lm9yZzptYWlsdG86eGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQpBVFRFTkRF
RTtST0xFPU9QVC1QQVJUSUNJUEFOVDtQQVJUU1RBVD1ORUVEUy1BQ1RJT047UlNWUD1UUlVFO0NO
PVJvYmVydG8gQmENCiBnbmFyYTptYWlsdG86cm9iZXJ0by5iYWduYXJhQGJ1Z3NlbmcuY29tDQpE
RVNDUklQVElPTjtMQU5HVUFHRT1lbi1VUzpcbiBYZW4gQ29tbXVuaXR5IG1lZXRpbmcgdG8gZGlz
Y3VzcyBNSVNSQSBDIGFkb3ANCiB0aW9uIGluIFhlblxuW2h0dHBzOi8vc3QyLnpvb20udXMvc3Rh
dGljLzYuMS42MTQ0L2ltYWdlL25ldy9ab29tTG9nb18xMTBfMg0KIDUucG5nXSA8aHR0cHM6Ly96
b29tLnVzPlxuSGkgdGhlcmVcLFxuU3RlZmFubyBTdGFiZWxsaW5pIGlzIGludml0aW5nIHlvdSB0
DQogbyBhIHNjaGVkdWxlZCBab29tIG1lZXRpbmcuXG5Kb2luIFpvb20gTWVldGluZzxodHRwczov
L3hpbGlueC56b29tLnVzL2ovOTINCiA0MDM1OTE2ODk/ZnJvbT1hZGRvbj5cblBob25lIG9uZS10
YXA6ICBVUzogKzE2Njk5MDA2ODMzXCxcLDkyNDAzNTkxNjg5Izx0ZQ0KIGw6KzE2Njk5MDA2ODMz
XCxcLDkyNDAzNTkxNjg5Iz4gb3IgKzE3MjA5Mjg5Mjk5XCxcLDkyNDAzNTkxNjg5Izx0ZWw6KzE3
MjA5DQogMjg5Mjk5XCxcLDkyNDAzNTkxNjg5Iz5cbk1lZXRpbmcgVVJMOiAgICBodHRwczovL3hp
bGlueC56b29tLnVzL2ovOTI0MDM1OTENCiA2ODk/ZnJvbT1hZGRvblxuTWVldGluZyBJRDogICAg
IDkyNCAwMzU5IDE2ODlcbkpvaW4gYnkgVGVsZXBob25lXG5Gb3IgaGlnaA0KIGVyIHF1YWxpdHlc
LCBkaWFsIGEgbnVtYmVyIGJhc2VkIG9uIHlvdXIgY3VycmVudCBsb2NhdGlvbi5cbkRpYWw6XG5V
UzogKzEgDQogNjY5IDkwMCA2ODMzIG9yICsxIDcyMCA5MjggOTI5OSBvciArMSA5MjkgMjA1IDYw
OTkgb3IgODg4IDQ3NSA0NDk5IChUb2xsIEYNCiByZWUpIG9yIDgzMyA1NDggMDI3NiAoVG9sbCBG
cmVlKSBvciA4MzMgNTQ4IDAyODIgKFRvbGwgRnJlZSkgb3IgODc3IDg1MyA1Mg0KIDU3IChUb2xs
IEZyZWUpXG5JbmRpYTogKzkxIDIyNiA0ODAgMjcyMiBvciArOTEgMjIgNzEgMjc5IDUyNSBvciAr
OTEgNDA2IDQ4DQogMCAyNzIyIG9yICs5MSA0NDYgNDgwIDI3MjIgb3IgKzkxIDgwNiA0ODAgMjcy
MiBvciArOTEgODAgNzEgMjc5IDQ0MCBvciArOTENCiAgMTE2IDQ4MCAyNzIyIG9yICs5MSAyMiA0
OCA3OTggMDA0IG9yICs5MSAyMjQgODc5IDgwMTIgb3IgKzkxIDIyNSAwOTcgMjc0Mg0KICBvciAr
OTEgMjI1IDA5NyAyNzQzIG9yICs5MSAyMjUgMDk3IDI3NDQgb3IgKzkxIDIyNSAwOTcgMjc0NSBv
ciAwMDAgODAwIDA1DQogMCA1MDUwIChUb2xsIEZyZWUpIG9yIDAwMCA4MDAgMDAxIDQwMDIgKFRv
bGwgRnJlZSlcbklyZWxhbmQ6ICszNTMgMSA2NTMgMzgNCiA5NSBvciArMzUzIDYgMTYzIDkwMzEg
b3IgKzM1MyAxIDUzNiA5MzIwIG9yIDE4MDAgOTQzIDk2NSAoVG9sbCBGcmVlKSBvciAxOA0KIDAw
IDk0OSAyMzggKFRvbGwgRnJlZSkgb3IgMTgwMCA5MDEgNTYxIChUb2xsIEZyZWUpXG5TaW5nYXBv
cmU6ICs2NSAzMTY1IDEwDQogNjUgb3IgKzY1IDMxNTggNzI4OCBvciA4MDAgMTAxIDM4MTQgKFRv
bGwgRnJlZSkgb3IgODAwIDg1MiA2MDU0IChUb2xsIEZyZWUNCiApIG9yIDE4MDAgNDA3IDU2MDIg
KFRvbGwgRnJlZSlcbk1lZXRpbmcgSUQ6ICAgICA5MjQgMDM1OSAxNjg5XG5JbnRlcm5hdGlvbg0K
IGFsIG51bWJlcnM8aHR0cHM6Ly94aWxpbnguem9vbS51cy91L2FkTk5vMW5xc2w+XG5Kb2luIGZy
b20gYSBWaWRlbyBDb25mZXJlDQogbmNlIHJvb20gc3lzdGVtXG5NZWV0aW5nIElEOiAgICAgOTI0
IDAzNTkgMTY4OVxuVVM6ICAgICA5MjQwMzU5MTY4OUBnbG9iYWwNCiAuem9vbWNyYy5jb21cbkFQ
QUM6ICAgOTI0MDM1OTE2ODlAZ2xvYmFsLnpvb21jcmMuY29tXG5JbmRpYTogIDkyNDAzNTkxNjg5
QA0KIGdsb2JhbC56b29tY3JjLmNvbVxuRXVyb3BlOiAgICAgICAgIDkyNDAzNTkxNjg5QGdsb2Jh
bC56b29tY3JjLmNvbVxuU0lQOiAgDQogICA5MjQwMzU5MTY4OUB6b29tY3JjLmNvbVxuDQpVSUQ6
MDQwMDAwMDA4MjAwRTAwMDc0QzVCNzEwMUE4MkUwMDgwMDAwMDAwMEYxRThDRDRBNzE1QUQ4MDEw
MDAwMDAwMDAwMDAwMDANCiAwMTAwMDAwMDBEMzg3RTUyQjJCRkVBRjQ2OEM0NThCMzA2M0I4OEFG
Ng0KU1VNTUFSWTtMQU5HVUFHRT1lbi1VUzpYZW4gYW5kIE1JU1JBIEMNCkRUU1RBUlQ7VFpJRD1Q
YWNpZmljIFN0YW5kYXJkIFRpbWU6MjAyMjA1MDNUMDgwMDAwDQpEVEVORDtUWklEPVBhY2lmaWMg
U3RhbmRhcmQgVGltZToyMDIyMDUwM1QwOTAwMDANCkNMQVNTOlBVQkxJQw0KUFJJT1JJVFk6NQ0K
RFRTVEFNUDoyMDIyMDQyN1QyMDAxNTlaDQpUUkFOU1A6T1BBUVVFDQpTVEFUVVM6Q09ORklSTUVE
DQpTRVFVRU5DRTowDQpMT0NBVElPTjtMQU5HVUFHRT1lbi1VUzpodHRwczovL3hpbGlueC56b29t
LnVzL2ovOTI0MDM1OTE2ODk/ZnJvbT1hZGRvbg0KWC1NSUNST1NPRlQtQ0RPLUFQUFQtU0VRVUVO
Q0U6MA0KWC1NSUNST1NPRlQtQ0RPLU9XTkVSQVBQVElEOjIxMjA1Mzk2MzMNClgtTUlDUk9TT0ZU
LUNETy1CVVNZU1RBVFVTOlRFTlRBVElWRQ0KWC1NSUNST1NPRlQtQ0RPLUlOVEVOREVEU1RBVFVT
OkJVU1kNClgtTUlDUk9TT0ZULUNETy1BTExEQVlFVkVOVDpGQUxTRQ0KWC1NSUNST1NPRlQtQ0RP
LUlNUE9SVEFOQ0U6MQ0KWC1NSUNST1NPRlQtQ0RPLUlOU1RUWVBFOjANClgtTUlDUk9TT0ZULUVW
RU5UUFJPUEVSVElFU1RPREVMRVRFOjANClgtTUlDUk9TT0ZULURPTk9URk9SV0FSRE1FRVRJTkc6
RkFMU0UNClgtTUlDUk9TT0ZULURJU0FMTE9XLUNPVU5URVI6RkFMU0UNClgtTUlDUk9TT0ZULUxP
Q0FUSU9ORElTUExBWU5BTUU6aHR0cHM6Ly94aWxpbnguem9vbS51cy9qLzkyNDAzNTkxNjg5P2Zy
b209YQ0KIGRkb24NClgtTUlDUk9TT0ZULUxPQ0FUSU9OU09VUkNFOk5vbmUNClgtTUlDUk9TT0ZU
LUxPQ0FUSU9OUzpbeyJEaXNwbGF5TmFtZSI6Imh0dHBzOi8veGlsaW54Lnpvb20udXMvai85MjQw
MzU5MTY4OQ0KID9mcm9tPWFkZG9uIlwsIkxvY2F0aW9uQW5ub3RhdGlvbiI6IiJcLCJMb2NhdGlv
blVyaSI6IiJcLCJMb2NhdGlvblN0cmVldCI6DQogIiJcLCJMb2NhdGlvbkNpdHkiOiIiXCwiTG9j
YXRpb25TdGF0ZSI6IiJcLCJMb2NhdGlvbkNvdW50cnkiOiIiXCwiTG9jYXRpb24NCiBQb3N0YWxD
b2RlIjoiIlwsIkxvY2F0aW9uRnVsbEFkZHJlc3MiOiIifV0NCkJFR0lOOlZBTEFSTQ0KREVTQ1JJ
UFRJT046UkVNSU5ERVINClRSSUdHRVI7UkVMQVRFRD1TVEFSVDotUFQxNU0NCkFDVElPTjpESVNQ
TEFZDQpFTkQ6VkFMQVJNDQpFTkQ6VkVWRU5UDQpFTkQ6VkNBTEVOREFSDQo=

--_000_MN2PR02MB6735E566BE6BF5B740836111A0FA9MN2PR02MB6735namp_--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315558.534178 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgC-0005Rf-Dd; Wed, 27 Apr 2022 23:02:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315558.534178; Wed, 27 Apr 2022 23:02:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgC-0005R8-6e; Wed, 27 Apr 2022 23:02:40 +0000
Received: by outflank-mailman (input) for mailman id 315558;
 Wed, 27 Apr 2022 22:50:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqUg-0003gq-Id
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:50:46 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7817bed3-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:50:44 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqU9-0001ye-3z; Thu, 28 Apr 2022 00:50:14 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7817bed3-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=9bJIN4/MOEhLx8CsVfKAquGTzb1mVDbHr+j6ymCNHAs=; b=S+EoVVMbG0R6l0pBfRnMsKZosp
	2PXBHwhmghS5Lvs4v4GQMUSqpGyoQ5U6Zbnyj6sMhUP4BCGILxO7PkeMyVqV/H8eeh+l7ihT1MYQn
	6lRWijWvq/MbBgY8W5xo5rf6VIJ8bQ3A6HUNn+RlRorsijlroe/vsascbDWK+dCTLeTv/edmbXzZt
	IkkQl7Ezob0EK5zEWLgIk+XPPHoVSiw2Ov7kaRBDa36NQrRgmO2O3HFxvBLZEYb5QzmHEcsWLMOdr
	YdjDzKF3as62X+/HBzxjW/bJqz3Ux15HOHGOCZtJDgeQcPUWNNi8PdpLZsxk0QJWHs39xjqIBwc58
	XGSV7jaw==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Marc Zyngier <maz@kernel.org>,
	Russell King <linux@armlinux.org.uk>
Subject: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path
Date: Wed, 27 Apr 2022 19:48:56 -0300
Message-Id: <20220427224924.592546-3-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently the regular CPU shutdown path for ARM disables IRQs/FIQs
in the secondary CPUs - smp_send_stop() calls ipi_cpu_stop(), which
is responsible for that. This makes sense, since we're turning off
such CPUs, putting them in an endless busy-wait loop.

Problem is that there is an alternative path for disabling CPUs,
in the form of function crash_smp_send_stop(), used for kexec/panic
paths. This functions relies in a SMP call that also triggers a
busy-wait loop [at machine_crash_nonpanic_core()], but *without*
disabling interrupts. This might lead to odd scenarios, like early
interrupts in the boot of kexec'd kernel or even interrupts in
other CPUs while the main one still works in the panic path and
assumes all secondary CPUs are (really!) off.

This patch mimics the ipi_cpu_stop() interrupt disable mechanism
in the crash CPU shutdown path, hence disabling IRQs/FIQs in all
secondary CPUs in the kexec/panic path as well.

Cc: Marc Zyngier <maz@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/arm/kernel/machine_kexec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
index f567032a09c0..ef788ee00519 100644
--- a/arch/arm/kernel/machine_kexec.c
+++ b/arch/arm/kernel/machine_kexec.c
@@ -86,6 +86,9 @@ void machine_crash_nonpanic_core(void *unused)
 	set_cpu_online(smp_processor_id(), false);
 	atomic_dec(&waiting_for_crash_ipi);
 
+	local_fiq_disable();
+	local_irq_disable();
+
 	while (1) {
 		cpu_relax();
 		wfe();
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315559.534183 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgC-0005Vu-Ov; Wed, 27 Apr 2022 23:02:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315559.534183; Wed, 27 Apr 2022 23:02:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgC-0005Tw-Gn; Wed, 27 Apr 2022 23:02:40 +0000
Received: by outflank-mailman (input) for mailman id 315559;
 Wed, 27 Apr 2022 22:50:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqUh-0003gq-BQ
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:50:47 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7821122a-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:50:44 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqTd-0001ws-8P; Thu, 28 Apr 2022 00:49:41 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7821122a-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:
	Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:
	Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
	In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=bd3LEemhVeb7HF/IIMNoiSMnSaTUMrH2fhcorDNVPOw=; b=reO22ihKOd/dWO6JG74IZyl/Fc
	ZRgGILhVwwQGIlc0vj0pe06pAIL0f1YnsjmZwa63b3ABCQ9Dxtfk7lOpgjSlBlW3mvUPOXpeDqCPF
	Rai8aA64fPaaS3uA4lyDgYZD5XuD0ZsHxLRl7fSfIQRGLMJx5CN6hSSRnLDC2sMLyPhnDWIKyd1uN
	dkM7kUYrK18mk3Ol/CnE0I+ZYy1cZnsseboaTczRU6buuvnTvUyLu0/yD31d9xZSykLYiRZ87DJrn
	1QwYj7LfEwisoBpfk6PfijWzaR37ghlKX+i9oyA2xcheBwMVt8x9sPCGngmKdbeGAFrivKg5AfP0H
	0Qh1iRoA==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Alex Elder <elder@kernel.org>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Chris Zankel <chris@zankel.net>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Corey Minyard <minyard@acm.org>,
	David Gow <davidgow@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Dexuan Cui <decui@microsoft.com>,
	Doug Berger <opendmb@gmail.com>,
	Evan Green <evgreen@chromium.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Helge Deller <deller@gmx.de>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	James Morse <james.morse@arm.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Julius Werner <jwerner@chromium.org>,
	Justin Chen <justinpopo6@gmail.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Leo Yan <leo.yan@linaro.org>,
	Marc Zyngier <maz@kernel.org>,
	Markus Mayer <mmayer@broadcom.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Matt Turner <mattst88@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Mihai Carabas <mihai.carabas@oracle.com>,
	Mike Leach <mike.leach@linaro.org>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Neeraj Upadhyay <quic_neeraju@quicinc.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Pavel Machek <pavel@ucw.cz>,
	Richard Henderson <rth@twiddle.net>,
	Richard Weinberger <richard@nod.at>,
	Robert Richter <rric@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Scott Branden <scott.branden@broadcom.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Sebastian Reichel <sre@kernel.org>,
	Shile Zhang <shile.zhang@linux.alibaba.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>,
	Tony Luck <tony.luck@intel.com>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Wang ShaoBo <bobo.shaobowang@huawei.com>,
	Wei Liu <wei.liu@kernel.org>,
	Xiaoming Ni <nixiaoming@huawei.com>,
	zhenwei pi <pizhenwei@bytedance.com>
Subject: [PATCH 00/30] The panic notifiers refactor
Date: Wed, 27 Apr 2022 19:48:54 -0300
Message-Id: <20220427224924.592546-1-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hey folks, this is an attempt to improve/refactor the dated panic notifiers
infrastructure. This is strongly based in a suggestion made by Pter Mladek [0]
some time ago, and it's finally ready. Below I'll detail the patch ordering,
testing made, etc.
First, a bit about the reason behind this.

The panic notifiers list is an infrastructure that allows callbacks to execute
during panic time. Happens that anybody can add functions there, no ordering
is enforced (by default) and the decision to execute or not such notifiers
before kdump may lead to high risk of failure in crash scenarios - default is
not to execute any of them. There is a parameter acting as a switch for that.
But some architectures require some notifiers, so..it's messy.

The suggestion from Petr came after a patch submission to add a notifiers
filter, allowing the notifiers selection by function name, which was welcomed
by some people, but not by Petr, which claimed the code should indeed have a
refactor - and it made a lot of sense, his suggestion makes code more clear
and reliable.

So, this series might be split in 3 portions:

Part 1: the first 18 patches are mostly fixes (one or two might be considered
improvements), mostly replacing spinlocks/mutexes with safer alternatives for
atomic contexts, like spin_trylock, etc. We also focused on commenting
everything that is possible and clean-up code.

Part 2, the core: patches 19-25 are the main refactor, which splits the panic
notifiers list in three, introduce the concept of panic notifier level and
clean-up and highly comment the code, effectively leading to a more reliable
and clear, yet highly customizable panic path.

Part 3: The remaining 5 patches are fixes that _require the main refactor_
patches, they don't make sense without the core changes - but again, these are
small fixes and not part of the main goal of refactoring the panic code.

I've tried my best to make the patches the more "bisectable" as possible, so
they tend to be self-contained and easy to backport (specially patches from
part 1). Notice that the series is *based on 5.18-rc4* - usually a refactor
like this would be based on linux-next, but since we have many fixes in the
series, I kept it based on mainline tree. Of course I could change that in a
subsequent iteration, if desired.

Since this touches multiple architectures and drivers, it's very difficult to
test it really (by executing all touched code). So, my tests split in two
approaches: build tests and real tests, that involves panic triggering with
and without kdump, changing panic notifiers level, etc.

Build tests (using cross-compilers): alpha, arm, arm64, mips (sgi 22 and 32),
parisc, s390, sparc, um, x86_64 (couldn't get a functional xtensa cross
compiler).

Real/full tests: x86_64 (Hyper-V and QEMU guests) + PowerPC (pseries guest).

Here is the link with the .config files used: https://people.igalia.com/gpiccoli/panic_notifiers_configs/
(tried my best to build all the affected code).

Finally, a bit about my CCing strategy: I've included everybody present in the
original thread [0] plus some maintainers and other interested parties as CC
in the full series. But the patches have individual CC lists, for people that
are definitely related to them but might not care much for the whole series;
nevertheless, _everybody_ mentioned at least once in some patch is CCed in this
cover-letter. Hopefully I didn't forget to include anybody - all the mailing
lists were CCed in the whole series. Apologies in advance if (a) you received
emails you didn't want to or, (b) I forgot to include you but it was something
considered interesting by you.

Thanks in advance for reviews / comments / suggestions!
Cheers,

Guilherme

[0] https://lore.kernel.org/lkml/YfPxvzSzDLjO5ldp@alley/

Guilherme G. Piccoli (30):
  x86/crash,reboot: Avoid re-disabling VMX in all CPUs on crash/restart
  ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path
  notifier: Add panic notifiers info and purge trailing whitespaces
  firmware: google: Convert regular spinlock into trylock on panic path
  misc/pvpanic: Convert regular spinlock into trylock on panic path
  soc: bcm: brcmstb: Document panic notifier action and remove useless header
  mips: ip22: Reword PANICED to PANICKED and remove useless header
  powerpc/setup: Refactor/untangle panic notifiers
  coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier
  alpha: Clean-up the panic notifier code
  um: Improve panic notifiers consistency and ordering
  parisc: Replace regular spinlock with spin_trylock on panic path
  s390/consoles: Improve panic notifiers reliability
  panic: Properly identify the panic event to the notifiers' callbacks
  bus: brcmstb_gisb: Clean-up panic/die notifiers
  drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers
  tracing: Improve panic/die notifiers
  notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set
  panic: Add the panic hypervisor notifier list
  panic: Add the panic informational notifier list
  panic: Introduce the panic pre-reboot notifier list
  panic: Introduce the panic post-reboot notifier list
  printk: kmsg_dump: Introduce helper to inform number of dumpers
  panic: Refactor the panic path
  panic, printk: Add console flush parameter and convert panic_print to a notifier
  Drivers: hv: Do not force all panic notifiers to execute before kdump
  powerpc: Do not force all panic notifiers to execute before kdump
  panic: Unexport crash_kexec_post_notifiers
  powerpc: ps3, pseries: Avoid duplicate call to kmsg_dump() on panic
  um: Avoid duplicate call to kmsg_dump()

 .../admin-guide/kernel-parameters.txt         |  54 ++-
 Documentation/admin-guide/sysctl/kernel.rst   |   5 +-
 arch/alpha/kernel/setup.c                     |  40 +--
 arch/arm/kernel/machine_kexec.c               |   3 +
 arch/arm64/kernel/setup.c                     |   2 +-
 arch/mips/kernel/relocate.c                   |   2 +-
 arch/mips/sgi-ip22/ip22-reset.c               |  13 +-
 arch/mips/sgi-ip32/ip32-reset.c               |   3 +-
 arch/parisc/include/asm/pdc.h                 |   1 +
 arch/parisc/kernel/firmware.c                 |  27 +-
 arch/parisc/kernel/pdc_chassis.c              |   3 +-
 arch/powerpc/include/asm/bug.h                |   2 +-
 arch/powerpc/kernel/fadump.c                  |   8 -
 arch/powerpc/kernel/setup-common.c            |  76 ++--
 arch/powerpc/kernel/traps.c                   |   6 +-
 arch/powerpc/platforms/powernv/opal.c         |   2 +-
 arch/powerpc/platforms/ps3/setup.c            |   2 +-
 arch/powerpc/platforms/pseries/setup.c        |   2 +-
 arch/s390/kernel/ipl.c                        |   4 +-
 arch/s390/kernel/setup.c                      |  19 +-
 arch/sparc/kernel/setup_32.c                  |  27 +-
 arch/sparc/kernel/setup_64.c                  |  29 +-
 arch/sparc/kernel/sstate.c                    |   3 +-
 arch/um/drivers/mconsole_kern.c               |  10 +-
 arch/um/kernel/um_arch.c                      |  11 +-
 arch/x86/include/asm/cpu.h                    |   1 +
 arch/x86/kernel/crash.c                       |   8 +-
 arch/x86/kernel/reboot.c                      |  14 +-
 arch/x86/kernel/setup.c                       |   2 +-
 arch/x86/xen/enlighten.c                      |   2 +-
 arch/xtensa/platforms/iss/setup.c             |   4 +-
 drivers/bus/brcmstb_gisb.c                    |  28 +-
 drivers/char/ipmi/ipmi_msghandler.c           |  12 +-
 drivers/edac/altera_edac.c                    |   3 +-
 drivers/firmware/google/gsmi.c                |  10 +-
 drivers/hv/hv_common.c                        |  12 -
 drivers/hv/vmbus_drv.c                        | 113 +++---
 .../hwtracing/coresight/coresight-cpu-debug.c |  11 +-
 drivers/leds/trigger/ledtrig-activity.c       |   4 +-
 drivers/leds/trigger/ledtrig-heartbeat.c      |   4 +-
 drivers/leds/trigger/ledtrig-panic.c          |   3 +-
 drivers/misc/bcm-vk/bcm_vk_dev.c              |   6 +-
 drivers/misc/ibmasm/heartbeat.c               |  16 +-
 drivers/misc/pvpanic/pvpanic.c                |  14 +-
 drivers/net/ipa/ipa_smp2p.c                   |   5 +-
 drivers/parisc/power.c                        |  21 +-
 drivers/power/reset/ltc2952-poweroff.c        |   4 +-
 drivers/remoteproc/remoteproc_core.c          |   6 +-
 drivers/s390/char/con3215.c                   |  38 +-
 drivers/s390/char/con3270.c                   |  36 +-
 drivers/s390/char/raw3270.c                   |  18 +
 drivers/s390/char/raw3270.h                   |   1 +
 drivers/s390/char/sclp_con.c                  |  30 +-
 drivers/s390/char/sclp_vt220.c                |  44 +--
 drivers/s390/char/zcore.c                     |   5 +-
 drivers/soc/bcm/brcmstb/pm/pm-arm.c           |  18 +-
 drivers/soc/tegra/ari-tegra186.c              |   3 +-
 drivers/staging/olpc_dcon/olpc_dcon.c         |   6 +-
 drivers/video/fbdev/hyperv_fb.c               |  12 +-
 include/linux/console.h                       |   2 +
 include/linux/kmsg_dump.h                     |   7 +
 include/linux/notifier.h                      |   8 +-
 include/linux/panic.h                         |   3 -
 include/linux/panic_notifier.h                |  12 +-
 include/linux/printk.h                        |   1 +
 kernel/hung_task.c                            |   3 +-
 kernel/kexec_core.c                           |   8 +-
 kernel/notifier.c                             |  48 ++-
 kernel/panic.c                                | 335 +++++++++++-------
 kernel/printk/printk.c                        |  76 ++++
 kernel/rcu/tree.c                             |   1 -
 kernel/rcu/tree_stall.h                       |   3 +-
 kernel/trace/trace.c                          |  59 +--
 .../selftests/pstore/pstore_crash_test        |   5 +-
 74 files changed, 953 insertions(+), 486 deletions(-)

-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315560.534186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgD-0005gR-5x; Wed, 27 Apr 2022 23:02:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315560.534186; Wed, 27 Apr 2022 23:02:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgC-0005dR-Vw; Wed, 27 Apr 2022 23:02:40 +0000
Received: by outflank-mailman (input) for mailman id 315560;
 Wed, 27 Apr 2022 22:50:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqUi-0003h1-OT
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:50:48 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7891df90-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:50:45 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqTt-0001xj-VW; Thu, 28 Apr 2022 00:49:58 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7891df90-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=r/T7YOY0VHwWAfHSEqxJa3Wt3qfvSExYRCUKLKE/qpM=; b=XhhicIlaxPAENQgGkNSZu/8JWa
	MoKMtLET2WEey/cUMjdoOeeZp/qIHF9AnIAQ1U9UG9ceTx5YsNvbqlEug3W8sTqjMADP3kqZkWGXE
	81ePHhsZB9/Fl6O5VwXVIzqdUd2GxbFqpTJI3oISOjep5UHhEIJ1gEAyfbzeKWGz11qqm1H8SqNmy
	PIXViapEJaVN3g1qVA0ll8xOHoXY2Fth5HpQAgahG3Orvdyx32C20SUgZY0+6ymNqW2eIcskQ9hv0
	PnRYqaVu+GNdXU/wxDKHHXg22u4+P2b/VN7O5/RK6RnCNvbziWOBIpkgY1JIKXd1EMfFHtVMCWu3y
	LPmztM1w==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	"David P . Reed" <dpreed@deepplum.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>
Subject: [PATCH 01/30] x86/crash,reboot: Avoid re-disabling VMX in all CPUs on crash/restart
Date: Wed, 27 Apr 2022 19:48:55 -0300
Message-Id: <20220427224924.592546-2-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In the panic path we have a list of functions to be called, the panic
notifiers - such callbacks perform various actions in the machine's
last breath, and sometimes users want them to run before kdump. We
have the parameter "crash_kexec_post_notifiers" for that. When such
parameter is used, the function "crash_smp_send_stop()" is executed
to poweroff all secondary CPUs through the NMI-shootdown mechanism;
part of this process involves disabling virtualization features in
all CPUs (except the main one).

Now, in the emergency restart procedure we have also a way of
disabling VMX in all CPUs, using the same NMI-shootdown mechanism;
what happens though is that in case we already NMI-disabled all CPUs,
the emergency restart fails due to a second addition of the same items
in the NMI list, as per the following log output:

sysrq: Trigger a crash
Kernel panic - not syncing: sysrq triggered crash
[...]
Rebooting in 2 seconds..
list_add double add: new=<addr1>, prev=<addr2>, next=<addr1>.
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:29!
invalid opcode: 0000 [#1] PREEMPT SMP PTI

In order to reproduce the problem, users just need to set the kernel
parameter "crash_kexec_post_notifiers" *without* kdump set in any
system with the VMX feature present.

Since there is no benefit in re-disabling VMX in all CPUs in case
it was already done, this patch prevents that by guarding the restart
routine against doubly issuing NMIs unnecessarily. Notice we still
need to disable VMX locally in the emergency restart.

Fixes: ed72736183c4 ("x86/reboot: Force all cpus to exit VMX root if VMX is supported)
Fixes: 0ee59413c967 ("x86/panic: replace smp_send_stop() with kdump friendly version in panic path")
Cc: David P. Reed <dpreed@deepplum.com>
Cc: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/x86/include/asm/cpu.h |  1 +
 arch/x86/kernel/crash.c    |  8 ++++----
 arch/x86/kernel/reboot.c   | 14 ++++++++++++--
 3 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/cpu.h
index 86e5e4e26fcb..b6a9062d387f 100644
--- a/arch/x86/include/asm/cpu.h
+++ b/arch/x86/include/asm/cpu.h
@@ -36,6 +36,7 @@ extern int _debug_hotplug_cpu(int cpu, int action);
 #endif
 #endif
 
+extern bool crash_cpus_stopped;
 int mwait_usable(const struct cpuinfo_x86 *);
 
 unsigned int x86_family(unsigned int sig);
diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index e8326a8d1c5d..71dd1a990e8d 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -42,6 +42,8 @@
 #include <asm/crash.h>
 #include <asm/cmdline.h>
 
+bool crash_cpus_stopped;
+
 /* Used while preparing memory map entries for second kernel */
 struct crash_memmap_data {
 	struct boot_params *params;
@@ -108,9 +110,7 @@ void kdump_nmi_shootdown_cpus(void)
 /* Override the weak function in kernel/panic.c */
 void crash_smp_send_stop(void)
 {
-	static int cpus_stopped;
-
-	if (cpus_stopped)
+	if (crash_cpus_stopped)
 		return;
 
 	if (smp_ops.crash_stop_other_cpus)
@@ -118,7 +118,7 @@ void crash_smp_send_stop(void)
 	else
 		smp_send_stop();
 
-	cpus_stopped = 1;
+	crash_cpus_stopped = true;
 }
 
 #else
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index fa700b46588e..2fc42b8402ac 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -589,8 +589,18 @@ static void native_machine_emergency_restart(void)
 	int orig_reboot_type = reboot_type;
 	unsigned short mode;
 
-	if (reboot_emergency)
-		emergency_vmx_disable_all();
+	/*
+	 * We can reach this point in the end of panic path, having
+	 * NMI-disabled all secondary CPUs. This process involves
+	 * disabling the CPU virtualization technologies, so if that
+	 * is the case, we only miss disabling the local CPU VMX...
+	 */
+	if (reboot_emergency) {
+		if (!crash_cpus_stopped)
+			emergency_vmx_disable_all();
+		else
+			cpu_emergency_vmxoff();
+	}
 
 	tboot_shutdown(TB_SHUTDOWN_REBOOT);
 
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315564.534195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgD-0005oA-Mt; Wed, 27 Apr 2022 23:02:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315564.534195; Wed, 27 Apr 2022 23:02:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgD-0005m8-GT; Wed, 27 Apr 2022 23:02:41 +0000
Received: by outflank-mailman (input) for mailman id 315564;
 Wed, 27 Apr 2022 22:50:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqUr-0003gq-6D
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:50:57 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7f6c2872-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:50:56 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqUS-0001zw-SF; Thu, 28 Apr 2022 00:50:33 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f6c2872-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=jw69MD++mJtoVz+5OF/yDyT7SM6GG1QVsO5qZnTbfPY=; b=R4BaLs+44BYJptao8GvC8ttDH3
	QBY0eMxhKSzWFCpxMbR+Fbp293MCB3zvPYgTPMf/b3OkQdSjP24E3L8e4Mxpy4tg+aM7LX40+eANn
	E9NmhqtSLVcTKfq6OAtiABfZVuEeL7pK/Jggwsb0Z66SwiIPgUgdk8N8FAOWtcyDE4pUFXnvlOs4u
	KY15nvIzaU7LDhXzbLelthG04bdK8jQeGFwa+aWfBFuZkkmcHkGvkm9AzL5O497raBTZiIXIwFkMO
	bBhCSNyrOC33WN5GrpTyqWn82roSYAhC1Njfns6EapEQdXDs5qCmdq3kXZk6bj6zjDvwVdiy1jwJ3
	PjTlDVgw==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Arjan van de Ven <arjan@linux.intel.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Xiaoming Ni <nixiaoming@huawei.com>
Subject: [PATCH 03/30] notifier: Add panic notifiers info and purge trailing whitespaces
Date: Wed, 27 Apr 2022 19:48:57 -0300
Message-Id: <20220427224924.592546-4-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Although many notifiers are mentioned in the comments, the panic
notifiers infrastructure is not. Also, the file contains some
trailing whitespaces. This commit fix both issues.

Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Valentin Schneider <valentin.schneider@arm.com>
Cc: Xiaoming Ni <nixiaoming@huawei.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 include/linux/notifier.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index 87069b8459af..0589896fc7bd 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -201,12 +201,12 @@ static inline int notifier_to_errno(int ret)
 
 /*
  *	Declared notifiers so far. I can imagine quite a few more chains
- *	over time (eg laptop power reset chains, reboot chain (to clean 
+ *	over time (eg laptop power reset chains, reboot chain (to clean
  *	device units up), device [un]mount chain, module load/unload chain,
- *	low memory chain, screenblank chain (for plug in modular screenblankers) 
+ *	low memory chain, screenblank chain (for plug in modular screenblankers)
  *	VC switch chains (for loadable kernel svgalib VC switch helpers) etc...
  */
- 
+
 /* CPU notfiers are defined in include/linux/cpu.h. */
 
 /* netdevice notifiers are defined in include/linux/netdevice.h */
@@ -217,6 +217,8 @@ static inline int notifier_to_errno(int ret)
 
 /* Virtual Terminal events are defined in include/linux/vt.h. */
 
+/* Panic notifiers are defined in include/linux/panic_notifier.h. */
+
 #define NETLINK_URELEASE	0x0001	/* Unicast netlink socket released */
 
 /* Console keyboard events.
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315566.534205 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgE-000637-Fo; Wed, 27 Apr 2022 23:02:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315566.534205; Wed, 27 Apr 2022 23:02:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgE-0005yF-2J; Wed, 27 Apr 2022 23:02:42 +0000
Received: by outflank-mailman (input) for mailman id 315566;
 Wed, 27 Apr 2022 22:51:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqV0-0003gq-Lf
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:51:06 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8515796a-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:51:06 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqUi-00020p-0e; Thu, 28 Apr 2022 00:50:49 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8515796a-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=s8xeHJYGrg2PKjTPKivxQn37LuEP6tnBzN9Ru5ARxEw=; b=itLofTxVD3jMCMG1QHrJKsVczn
	vbwUlm+NWg0pMSOCtSjWETMXDXA/dO9ti0V72q001TMmb2gIzR2yZduw7qvMkCQ0akMjJfPi2/PQc
	iUqIhedKtPpwa0f3Qs25a8tdm2oshD1/KMZCL+mdxqH7vtpZXZFld+eSj+8owBfmLjMNmktzOqSfY
	dTb/ic9+j716feaFlMGDFCnVL8lNNI9bMH1gzqsKPsNg72iLmPQmwnJD7EfxHW7NQoAv8T+6Y8VEH
	2ohazyjoc9Z+MNXm7Lr7Bh3GLxJ6zmDCTC3SRdi9P8jirAP5MyZi4cLioUm7IG4Ag3/IwiKZ9+K4K
	3P27PVmg==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Ard Biesheuvel <ardb@kernel.org>,
	David Gow <davidgow@google.com>,
	Evan Green <evgreen@chromium.org>,
	Julius Werner <jwerner@chromium.org>
Subject: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path
Date: Wed, 27 Apr 2022 19:48:58 -0300
Message-Id: <20220427224924.592546-5-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently the gsmi driver registers a panic notifier as well as
reboot and die notifiers. The callbacks registered are called in
atomic and very limited context - for instance, panic disables
preemption, local IRQs and all other CPUs that aren't running the
current panic function.

With that said, taking a spinlock in this scenario is a
dangerous invitation for a deadlock scenario. So, we fix
that in this commit by changing the regular spinlock with
a trylock, which is a safer approach.

Fixes: 74c5b31c6618 ("driver: Google EFI SMI")
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: David Gow <davidgow@google.com>
Cc: Evan Green <evgreen@chromium.org>
Cc: Julius Werner <jwerner@chromium.org>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 drivers/firmware/google/gsmi.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index adaa492c3d2d..b01ed02e4a87 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -629,7 +629,10 @@ static int gsmi_shutdown_reason(int reason)
 	if (saved_reason & (1 << reason))
 		return 0;
 
-	spin_lock_irqsave(&gsmi_dev.lock, flags);
+	if (!spin_trylock_irqsave(&gsmi_dev.lock, flags)) {
+		rc = -EBUSY;
+		goto out;
+	}
 
 	saved_reason |= (1 << reason);
 
@@ -646,6 +649,7 @@ static int gsmi_shutdown_reason(int reason)
 
 	spin_unlock_irqrestore(&gsmi_dev.lock, flags);
 
+out:
 	if (rc < 0)
 		printk(KERN_ERR "gsmi: Log Shutdown Reason failed\n");
 	else
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315568.534215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgF-0006Gl-44; Wed, 27 Apr 2022 23:02:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315568.534215; Wed, 27 Apr 2022 23:02:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgE-0006CZ-PM; Wed, 27 Apr 2022 23:02:42 +0000
Received: by outflank-mailman (input) for mailman id 315568;
 Wed, 27 Apr 2022 22:51:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqVH-0003mC-A4
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:51:23 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ee2b89c-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:51:22 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqV1-000228-53; Thu, 28 Apr 2022 00:51:08 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ee2b89c-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=/X9VGFpkqSi0Xw+sb2fnqT5ti0fEX/+xmh5q7q7MhDY=; b=p3QOIFADQeeHCVp8bxPKwO62s+
	EGcZOVKN2qbhBt1Pf/EZXw+tkBx2x9DRVMO1uTp94JqIADubO77jiICP/E04L/nn99FEYBzZb+44L
	/kz24xVDrX4FFqomkvxzWUTFlHhE4ZhZCfkHWBQr0/Lzkqr3CE/w4r7fAtX83L8f0pEarK5Qx6XYH
	4zbdyCjIZQkKS6mh2t53k79tPqORut15Ek94GDPyIzx6i+d57M9a0UcH7EVEXkkbVPk2r+5s4ram2
	N0+1/N2WpK9qFZ8QFj+vJFSqHIZNJD4YgbbIqqLYxl+DJIQthPO2tybUvOHdIFVD8Tw3e7+DHlkve
	LuLH0yww==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Mihai Carabas <mihai.carabas@oracle.com>,
	Shile Zhang <shile.zhang@linux.alibaba.com>,
	Wang ShaoBo <bobo.shaobowang@huawei.com>,
	zhenwei pi <pizhenwei@bytedance.com>
Subject: [PATCH 05/30] misc/pvpanic: Convert regular spinlock into trylock on panic path
Date: Wed, 27 Apr 2022 19:48:59 -0300
Message-Id: <20220427224924.592546-6-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The pvpanic driver relies on panic notifiers to execute a callback
on panic event. Such function is executed in atomic context - the
panic function disables local IRQs, preemption and all other CPUs
that aren't running the panic code.

With that said, it's dangerous to use regular spinlocks in such path,
as introduced by commit b3c0f8774668 ("misc/pvpanic: probe multiple instances").
This patch fixes that by replacing regular spinlocks with the trylock
safer approach.

It also fixes an old comment (about a long gone framebuffer code) and
the notifier priority - we should execute hypervisor notifiers early,
deferring this way the panic action to the hypervisor, as expected by
the users that are setting up pvpanic.

Fixes: b3c0f8774668 ("misc/pvpanic: probe multiple instances")
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Mihai Carabas <mihai.carabas@oracle.com>
Cc: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Wang ShaoBo <bobo.shaobowang@huawei.com>
Cc: zhenwei pi <pizhenwei@bytedance.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 drivers/misc/pvpanic/pvpanic.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/pvpanic/pvpanic.c b/drivers/misc/pvpanic/pvpanic.c
index 4b8f1c7d726d..049a12006348 100644
--- a/drivers/misc/pvpanic/pvpanic.c
+++ b/drivers/misc/pvpanic/pvpanic.c
@@ -34,7 +34,9 @@ pvpanic_send_event(unsigned int event)
 {
 	struct pvpanic_instance *pi_cur;
 
-	spin_lock(&pvpanic_lock);
+	if (!spin_trylock(&pvpanic_lock))
+		return;
+
 	list_for_each_entry(pi_cur, &pvpanic_list, list) {
 		if (event & pi_cur->capability & pi_cur->events)
 			iowrite8(event, pi_cur->base);
@@ -55,9 +57,13 @@ pvpanic_panic_notify(struct notifier_block *nb, unsigned long code, void *unused
 	return NOTIFY_DONE;
 }
 
+/*
+ * Call our notifier very early on panic, deferring the
+ * action taken to the hypervisor.
+ */
 static struct notifier_block pvpanic_panic_nb = {
 	.notifier_call = pvpanic_panic_notify,
-	.priority = 1, /* let this called before broken drm_fb_helper() */
+	.priority = INT_MAX,
 };
 
 static void pvpanic_remove(void *param)
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315570.534225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgG-0006WF-1P; Wed, 27 Apr 2022 23:02:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315570.534225; Wed, 27 Apr 2022 23:02:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgF-0006Rr-Hv; Wed, 27 Apr 2022 23:02:43 +0000
Received: by outflank-mailman (input) for mailman id 315570;
 Wed, 27 Apr 2022 22:51:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqVV-0003mC-Ad
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:51:37 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 975e534f-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:51:36 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqVG-00023b-GJ; Thu, 28 Apr 2022 00:51:23 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 975e534f-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=5Wppui/4+4q1PWThaAiWQx32MHyg/obGwoGJE8vkLrA=; b=IRi7rvSSPrrOoy0S56lz2UJRtC
	W1l3fBj8xVxgLD6KW8zqEI0EfCOiXJW5ZsYXn2WVzqXNxfRkE81Vja/726PNP5gfd+ffe5+sSmine
	oDSQIDYY0LQtz/eUpNO/O3flF5w2323kd1e2RLGfs/+wuvi6OZjtA/cAWJ8y4DX82MWtYSxfkdu78
	HNn3Scwjr+UIudJHWW8i9wi/BmFAgD6nNrsW4GexdH6x6p4zIq9laE/2q1VZR7YM8s/7fvEfIhVyD
	gNu+c9943row/xgSKe8GkhslCs6aT6+524Fp09jB/vhA283Kkt9uCVO689z6MyVp8qdL3zZfdmmrO
	nvvrYfqw==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Brian Norris <computersforpeace@gmail.com>,
	Doug Berger <opendmb@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Justin Chen <justinpopo6@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Markus Mayer <mmayer@broadcom.com>
Subject: [PATCH 06/30] soc: bcm: brcmstb: Document panic notifier action and remove useless header
Date: Wed, 27 Apr 2022 19:49:00 -0300
Message-Id: <20220427224924.592546-7-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The panic notifier of this driver is very simple code-wise, just a memory
write to a special position with some numeric code. But this is not clear
from the semantic point-of-view, and there is no public documentation
about that either.

After discussing this in the mailing-lists [0] and having Florian explained
it very well, this patch just document that in the code for the future
generations asking the same questions. Also, it removes a useless header.

[0] https://lore.kernel.org/lkml/781cafb0-8d06-8b56-907a-5175c2da196a@gmail.com

Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)")
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Justin Chen <justinpopo6@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Markus Mayer <mmayer@broadcom.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 drivers/soc/bcm/brcmstb/pm/pm-arm.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c
index 3cbb165d6e30..870686ae042b 100644
--- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c
+++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c
@@ -25,7 +25,6 @@
 #include <linux/kernel.h>
 #include <linux/memblock.h>
 #include <linux/module.h>
-#include <linux/notifier.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/panic_notifier.h>
@@ -664,7 +663,20 @@ static void __iomem *brcmstb_ioremap_match(const struct of_device_id *matches,
 
 	return of_io_request_and_map(dn, index, dn->full_name);
 }
-
+/*
+ * The AON is a small domain in the SoC that can retain its state across
+ * various system wide sleep states and specific reset conditions; the
+ * AON DATA RAM is a small RAM of a few words (< 1KB) which can store
+ * persistent information across such events.
+ *
+ * The purpose of the below panic notifier is to help with notifying
+ * the bootloader that a panic occurred and so that it should try its
+ * best to preserve the DRAM contents holding that buffer for recovery
+ * by the kernel as opposed to wiping out DRAM clean again.
+ *
+ * Reference: comment from Florian Fainelli, at
+ * https://lore.kernel.org/lkml/781cafb0-8d06-8b56-907a-5175c2da196a@gmail.com
+ */
 static int brcmstb_pm_panic_notify(struct notifier_block *nb,
 		unsigned long action, void *data)
 {
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315572.534237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgH-0006kh-6s; Wed, 27 Apr 2022 23:02:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315572.534237; Wed, 27 Apr 2022 23:02:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgG-0006fM-DA; Wed, 27 Apr 2022 23:02:44 +0000
Received: by outflank-mailman (input) for mailman id 315572;
 Wed, 27 Apr 2022 22:51:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqVm-0003ne-Lg
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:51:54 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a18ffc0f-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:51:53 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqVW-000250-IT; Thu, 28 Apr 2022 00:51:39 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a18ffc0f-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=sBnzQEgOETevrWvoFDe4UXYaoyJvnokumNTnFd8nYd4=; b=C3WoMDzHemUiz3TJonrj4OLB2r
	FSxQF+F2lHHptNuVBTghKMJZClefE6Imxei6ehl090Dy2iIiwWYXrKfz8k6+wORL9DMg3LEbLg3HV
	Yy5IDocQKz78CwwV1x1BjunLLiApngptGwnQE+MM0c5kIHbxgr5QD1BtqzYPoELgJZUScA99Ow0T5
	DgoMAXPJxcpvr2MM73b5S2P6pfeIYXcyYWBlbiqaBO38Mb9qP/Auq8X4+iMlX3NAoRdIHY9DVHKc8
	OvjiTLZuxC2PHt1XEzIKelV5l8TbSCfHnuQVB2KdJOLt6lDAQzFhqrTn+CsXTsATCFcE2SPeUMfAC
	eC7wzCXg==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: [PATCH 07/30] mips: ip22: Reword PANICED to PANICKED and remove useless header
Date: Wed, 27 Apr 2022 19:49:01 -0300
Message-Id: <20220427224924.592546-8-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Many other place in the kernel prefer the latter, so let's keep
it consistent in MIPS code as well. Also, removes a useless header.

Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/mips/sgi-ip22/ip22-reset.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/arch/mips/sgi-ip22/ip22-reset.c b/arch/mips/sgi-ip22/ip22-reset.c
index 9028dbbb45dd..8f0861c58080 100644
--- a/arch/mips/sgi-ip22/ip22-reset.c
+++ b/arch/mips/sgi-ip22/ip22-reset.c
@@ -11,7 +11,6 @@
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/sched/signal.h>
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include <linux/pm.h>
 #include <linux/timer.h>
@@ -41,7 +40,7 @@
 static struct timer_list power_timer, blink_timer, debounce_timer;
 static unsigned long blink_timer_timeout;
 
-#define MACHINE_PANICED		1
+#define MACHINE_PANICKED		1
 #define MACHINE_SHUTTING_DOWN	2
 
 static int machine_state;
@@ -112,7 +111,7 @@ static void debounce(struct timer_list *unused)
 		return;
 	}
 
-	if (machine_state & MACHINE_PANICED)
+	if (machine_state & MACHINE_PANICKED)
 		sgimc->cpuctrl0 |= SGIMC_CCTRL0_SYSINIT;
 
 	enable_irq(SGI_PANEL_IRQ);
@@ -120,7 +119,7 @@ static void debounce(struct timer_list *unused)
 
 static inline void power_button(void)
 {
-	if (machine_state & MACHINE_PANICED)
+	if (machine_state & MACHINE_PANICKED)
 		return;
 
 	if ((machine_state & MACHINE_SHUTTING_DOWN) ||
@@ -167,9 +166,9 @@ static irqreturn_t panel_int(int irq, void *dev_id)
 static int panic_event(struct notifier_block *this, unsigned long event,
 		      void *ptr)
 {
-	if (machine_state & MACHINE_PANICED)
+	if (machine_state & MACHINE_PANICKED)
 		return NOTIFY_DONE;
-	machine_state |= MACHINE_PANICED;
+	machine_state |= MACHINE_PANICKED;
 
 	blink_timer_timeout = PANIC_FREQ;
 	blink_timeout(&blink_timer);
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315574.534244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgH-0006wg-UM; Wed, 27 Apr 2022 23:02:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315574.534244; Wed, 27 Apr 2022 23:02:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgH-0006sg-8L; Wed, 27 Apr 2022 23:02:45 +0000
Received: by outflank-mailman (input) for mailman id 315574;
 Wed, 27 Apr 2022 22:52:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqW2-0003ne-Pw
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:52:10 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ab1fdeb7-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:52:09 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqVm-00026W-Rl; Thu, 28 Apr 2022 00:51:55 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab1fdeb7-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=/cdg0sKCsuwzrOmixxbC1Q4JQ/fbIS+o0nd/6r3SqdQ=; b=Ms53zbjgbkvE/VbvvERWDhiSlK
	xnfSZ26duHs4sJGmX9AjyiOpVrZ24qlvncFPTQgx0Ak1/K+qg/q6M3lNqtXBQSywskWJGGXxxZsyH
	0ZCt9ADqjTi/3V+XCpSLOfo1kVbAL88rsa3CWloXQYrPcKcjm0fr5wkBOKZGIirx4MPHlXEq/lSP6
	Wauj7ki9eqiIN/DWOEVCrOIQ5CDDEHA0P4AiVRkbPc3MLQuGkkZQLCDxyedC8rV+CPmlMqMLZGK7O
	pj27Q1YpHqsziDeg78TsiM6RPMIm39rOPoY53108P/vAvRYTx1t1bv7hv+1+u3acH1fsI00wIEzlf
	mvZOITKg==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>
Subject: [PATCH 08/30] powerpc/setup: Refactor/untangle panic notifiers
Date: Wed, 27 Apr 2022 19:49:02 -0300
Message-Id: <20220427224924.592546-9-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The panic notifiers infrastructure is a bit limited in the scope of
the callbacks - basically every kind of functionality is dropped
in a list that runs in the same point during the kernel panic path.
This is not really on par with the complexities and particularities
of architecture / hypervisors' needs, and a refactor is ongoing.

As part of this refactor, it was observed that powerpc has 2 notifiers,
with mixed goals: one is just a KASLR offset dumper, whereas the other
aims to hard-disable IRQs (necessary on panic path), warn firmware of
the panic event (fadump) and run low-level platform-specific machinery
that might stop kernel execution and never come back.

Clearly, the 2nd notifier has opposed goals: disable IRQs / fadump
should run earlier while low-level platform actions should
run late since it might not even return. Hence, this patch decouples
the notifiers splitting them in three:

- First one is responsible for hard-disable IRQs and fadump,
should run early;

- The kernel KASLR offset dumper is really an informative notifier,
harmless and may run at any moment in the panic path;

- The last notifier should run last, since it aims to perform
low-level actions for specific platforms, and might never return.
It is also only registered for 2 platforms, pseries and ps3.

The patch better documents the notifiers and clears the code too,
also removing a useless header.

Currently no functionality change should be observed, but after
the planned panic refactor we should expect more panic reliability
with this patch.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Hari Bathini <hbathini@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

We'd like to thanks specially the MiniCloud infrastructure [0] maintainers,
that allow us to test PowerPC code in a very complete, functional and FREE
environment (there's no need even for adding a credit card, like many "free"
clouds require ¬¬ ).

[0] https://openpower.ic.unicamp.br/minicloud

 arch/powerpc/kernel/setup-common.c | 74 ++++++++++++++++++++++--------
 1 file changed, 54 insertions(+), 20 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 518ae5aa9410..52f96b209a96 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -23,7 +23,6 @@
 #include <linux/console.h>
 #include <linux/screen_info.h>
 #include <linux/root_dev.h>
-#include <linux/notifier.h>
 #include <linux/cpu.h>
 #include <linux/unistd.h>
 #include <linux/serial.h>
@@ -680,8 +679,25 @@ int check_legacy_ioport(unsigned long base_port)
 }
 EXPORT_SYMBOL(check_legacy_ioport);
 
-static int ppc_panic_event(struct notifier_block *this,
-                             unsigned long event, void *ptr)
+/*
+ * Panic notifiers setup
+ *
+ * We have 3 notifiers for powerpc, each one from a different "nature":
+ *
+ * - ppc_panic_fadump_handler() is a hypervisor notifier, which hard-disables
+ *   IRQs and deal with the Firmware-Assisted dump, when it is configured;
+ *   should run early in the panic path.
+ *
+ * - dump_kernel_offset() is an informative notifier, just showing the KASLR
+ *   offset if we have RANDOMIZE_BASE set.
+ *
+ * - ppc_panic_platform_handler() is a low-level handler that's registered
+ *   only if the platform wishes to perform final actions in the panic path,
+ *   hence it should run late and might not even return. Currently, only
+ *   pseries and ps3 platforms register callbacks.
+ */
+static int ppc_panic_fadump_handler(struct notifier_block *this,
+				    unsigned long event, void *ptr)
 {
 	/*
 	 * panic does a local_irq_disable, but we really
@@ -691,45 +707,63 @@ static int ppc_panic_event(struct notifier_block *this,
 
 	/*
 	 * If firmware-assisted dump has been registered then trigger
-	 * firmware-assisted dump and let firmware handle everything else.
+	 * its callback and let the firmware handles everything else.
 	 */
 	crash_fadump(NULL, ptr);
-	if (ppc_md.panic)
-		ppc_md.panic(ptr);  /* May not return */
+
 	return NOTIFY_DONE;
 }
 
-static struct notifier_block ppc_panic_block = {
-	.notifier_call = ppc_panic_event,
-	.priority = INT_MIN /* may not return; must be done last */
-};
-
-/*
- * Dump out kernel offset information on panic.
- */
 static int dump_kernel_offset(struct notifier_block *self, unsigned long v,
 			      void *p)
 {
 	pr_emerg("Kernel Offset: 0x%lx from 0x%lx\n",
 		 kaslr_offset(), KERNELBASE);
 
-	return 0;
+	return NOTIFY_DONE;
 }
 
+static int ppc_panic_platform_handler(struct notifier_block *this,
+				      unsigned long event, void *ptr)
+{
+	/*
+	 * This handler is only registered if we have a panic callback
+	 * on ppc_md, hence NULL check is not needed.
+	 * Also, it may not return, so it runs really late on panic path.
+	 */
+	ppc_md.panic(ptr);
+
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block ppc_fadump_block = {
+	.notifier_call = ppc_panic_fadump_handler,
+	.priority = INT_MAX, /* run early, to notify the firmware ASAP */
+};
+
 static struct notifier_block kernel_offset_notifier = {
-	.notifier_call = dump_kernel_offset
+	.notifier_call = dump_kernel_offset,
+};
+
+static struct notifier_block ppc_panic_block = {
+	.notifier_call = ppc_panic_platform_handler,
+	.priority = INT_MIN, /* may not return; must be done last */
 };
 
 void __init setup_panic(void)
 {
+	/* Hard-disables IRQs + deal with FW-assisted dump (fadump) */
+	atomic_notifier_chain_register(&panic_notifier_list,
+				       &ppc_fadump_block);
+
 	if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && kaslr_offset() > 0)
 		atomic_notifier_chain_register(&panic_notifier_list,
 					       &kernel_offset_notifier);
 
-	/* PPC64 always does a hard irq disable in its panic handler */
-	if (!IS_ENABLED(CONFIG_PPC64) && !ppc_md.panic)
-		return;
-	atomic_notifier_chain_register(&panic_notifier_list, &ppc_panic_block);
+	/* Low-level platform-specific routines that should run on panic */
+	if (ppc_md.panic)
+		atomic_notifier_chain_register(&panic_notifier_list,
+					       &ppc_panic_block);
 }
 
 #ifdef CONFIG_CHECK_CACHE_COHERENCY
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315576.534255 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgJ-0007BZ-3C; Wed, 27 Apr 2022 23:02:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315576.534255; Wed, 27 Apr 2022 23:02:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgI-00074J-5P; Wed, 27 Apr 2022 23:02:46 +0000
Received: by outflank-mailman (input) for mailman id 315576;
 Wed, 27 Apr 2022 22:52:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqWG-0003q5-N1
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:52:24 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b37aaf20-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:52:23 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqW1-000289-9r; Thu, 28 Apr 2022 00:52:10 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b37aaf20-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=seVlMlqj/OOgqWCw1tUxCfRyMjTeYr5Z28M++b51Xf4=; b=ZaOL9ZgN+EGmQho6+KGFZHTRbn
	OaOWIMR4M4pabKtnueiNn0ccKPcDo3HPhyU+dXv5cnfPUStBzfPFVl+jQM59vF4ZhACUpuR43IYXQ
	ZxDFWoPV6MSwPwBTAmhnCK48+3Rd3s3YxmPfJVkzBknJImEbRwxzoUg95gTvTUorv8vMDdjprmUy3
	YkS66FLAwKwDNOu8o7q4f4XVv/vUJe4PGzk68gQ9Mx3uMtXXVmK27/P4rcS4LEEam3214m5o7ahcQ
	5LKqcAxUSITnoTva0XbxnJK2lHjf45/V+xGb9BJP25J23hUhWNHPX2AXkANv1NANWHSZgkACdPcYF
	QXixtySQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Leo Yan <leo.yan@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Mike Leach <mike.leach@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH 09/30] coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier
Date: Wed, 27 Apr 2022 19:49:03 -0300
Message-Id: <20220427224924.592546-10-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The panic notifier infrastructure executes registered callbacks when
a panic event happens - such callbacks are executed in atomic context,
with interrupts and preemption disabled in the running CPU and all other
CPUs disabled. That said, mutexes in such context are not a good idea.

This patch replaces a regular mutex with a mutex_trylock safer approach;
given the nature of the mutex used in the driver, it should be pretty
uncommon being unable to acquire such mutex in the panic path, hence
no functional change should be observed (and if it is, that would be
likely a deadlock with the regular mutex).

Fixes: 2227b7c74634 ("coresight: add support for CPU debug module")
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 drivers/hwtracing/coresight/coresight-cpu-debug.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index 8845ec4b4402..1874df7c6a73 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -380,9 +380,10 @@ static int debug_notifier_call(struct notifier_block *self,
 	int cpu;
 	struct debug_drvdata *drvdata;
 
-	mutex_lock(&debug_lock);
+	/* Bail out if we can't acquire the mutex or the functionality is off */
+	if (!mutex_trylock(&debug_lock))
+		return NOTIFY_DONE;
 
-	/* Bail out if the functionality is disabled */
 	if (!debug_enable)
 		goto skip_dump;
 
@@ -401,7 +402,7 @@ static int debug_notifier_call(struct notifier_block *self,
 
 skip_dump:
 	mutex_unlock(&debug_lock);
-	return 0;
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block debug_notifier = {
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315578.534264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgK-0007Ud-13; Wed, 27 Apr 2022 23:02:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315578.534264; Wed, 27 Apr 2022 23:02:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgJ-0007Ph-7r; Wed, 27 Apr 2022 23:02:47 +0000
Received: by outflank-mailman (input) for mailman id 315578;
 Wed, 27 Apr 2022 22:52:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqWe-0003r1-6I
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:52:48 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c171f56d-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:52:47 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqWG-00029R-Tx; Thu, 28 Apr 2022 00:52:25 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c171f56d-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=BexKVXcxuZt34azQ5Muv1vJV6tgwpIcW3JsMthwMxfs=; b=BRT/sKLpYXau/Ji4ZqRLBh2wLe
	Ez82oN0tPhCaeccxvStT4dM/VXWT0UOTgVT7srxju4FTp1lIxHZgITVU09FPE0hwYIbUj79K3InFF
	c3u/lCG1AZZtsXeU+SEcK9u0pYYem+Sajrhv7s+jR5UPYROYW2E4rHsCktC7o7MuiSwumDe0KTw8O
	uv2vnGx/4l5xRolhC4zk2RH1ShfOhYp0567tBrYlkHX5Tuh9PS21K9iN1pNYOoy8D+KSBJrTAnUOx
	BdTF6VrcFln7xzJle98w0XT7WzPU38wHtKJVV73Cz5eypbAomXnD5JiFGfsNH5tWiuiFJ1HH5bqlk
	bHcrf8AQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Richard Henderson <rth@twiddle.net>
Subject: [PATCH 10/30] alpha: Clean-up the panic notifier code
Date: Wed, 27 Apr 2022 19:49:04 -0300
Message-Id: <20220427224924.592546-11-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The alpha panic notifier has some code issues, not following
the conventions of other notifiers. Also, it might halt the
machine but still it is set to run as early as possible, which
doesn't seem to be a good idea.

This patch cleans the code, and set the notifier to run as the
latest, following the same approach other architectures are doing.
Also, we remove the unnecessary include of a header already
included indirectly.

Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/alpha/kernel/setup.c | 36 +++++++++++++++---------------------
 1 file changed, 15 insertions(+), 21 deletions(-)

diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c
index b4fbbba30aa2..d88bdf852753 100644
--- a/arch/alpha/kernel/setup.c
+++ b/arch/alpha/kernel/setup.c
@@ -41,19 +41,11 @@
 #include <linux/sysrq.h>
 #include <linux/reboot.h>
 #endif
-#include <linux/notifier.h>
 #include <asm/setup.h>
 #include <asm/io.h>
 #include <linux/log2.h>
 #include <linux/export.h>
 
-static int alpha_panic_event(struct notifier_block *, unsigned long, void *);
-static struct notifier_block alpha_panic_block = {
-	alpha_panic_event,
-        NULL,
-        INT_MAX /* try to do it first */
-};
-
 #include <linux/uaccess.h>
 #include <asm/hwrpb.h>
 #include <asm/dma.h>
@@ -435,6 +427,21 @@ static const struct sysrq_key_op srm_sysrq_reboot_op = {
 };
 #endif
 
+static int alpha_panic_event(struct notifier_block *this,
+			     unsigned long event, void *ptr)
+{
+	/* If we are using SRM and serial console, just hard halt here. */
+	if (alpha_using_srm && srmcons_output)
+		__halt();
+
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block alpha_panic_block = {
+	.notifier_call = alpha_panic_event,
+	.priority = INT_MIN, /* may not return, do it last */
+};
+
 void __init
 setup_arch(char **cmdline_p)
 {
@@ -1427,19 +1434,6 @@ const struct seq_operations cpuinfo_op = {
 	.show	= show_cpuinfo,
 };
 
-
-static int
-alpha_panic_event(struct notifier_block *this, unsigned long event, void *ptr)
-{
-#if 1
-	/* FIXME FIXME FIXME */
-	/* If we are using SRM and serial console, just hard halt here. */
-	if (alpha_using_srm && srmcons_output)
-		__halt();
-#endif
-        return NOTIFY_DONE;
-}
-
 static __init int add_pcspkr(void)
 {
 	struct platform_device *pd;
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315580.534276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgL-0007lm-Co; Wed, 27 Apr 2022 23:02:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315580.534276; Wed, 27 Apr 2022 23:02:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgK-0007il-C9; Wed, 27 Apr 2022 23:02:48 +0000
Received: by outflank-mailman (input) for mailman id 315580;
 Wed, 27 Apr 2022 22:52:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqWj-0003q5-IE
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:52:53 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c4d6ec14-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:52:52 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqWU-0002B5-Ub; Thu, 28 Apr 2022 00:52:40 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4d6ec14-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=bCeC+folLkdyk3b6apumHxcRwMBwOys8pMRPpqSclew=; b=TqPRVvgSfmMVR610uLcwg2vC34
	pLIumny6UC9NAVKrJeC8kjbMxl/tivBCI9wjj++xXokR3qbvfCHXTOfrOaZezN2wYfsTeWwS7JgiC
	ST58COWgOj0NVLj/RM40gpf1tYeZ+3Akn0o3OOB9wnVZqXRK498bYXNcV51purgIjJ73eodK18ucj
	+Iyv87VDCsJruNsaOWJAaGmlYU1Av1XSojv9QPvuFZsys/hw7VJ6aN2N3d0SlURJabJe1PgCqptXF
	Xo2aIypAELGn+aiNCAnoOIj6PgcxN1C5aslHAtr3OG/wMakbb0/ORKtlMkkFaGzr7X86jahmQbl4p
	VjCzjD3g==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Richard Weinberger <richard@nod.at>
Subject: [PATCH 11/30] um: Improve panic notifiers consistency and ordering
Date: Wed, 27 Apr 2022 19:49:05 -0300
Message-Id: <20220427224924.592546-12-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently the panic notifiers from user mode linux don't follow
the convention for most of the other notifiers present in the
kernel (indentation, priority setting, numeric return).
More important, the priorities could be improved, since it's a
special case (userspace), hence we could run the notifiers earlier;
user mode linux shouldn't care much with other panic notifiers but
the ordering among the mconsole and arch notifier is important,
given that the arch one effectively triggers a core dump.

This patch fixes that by running the mconsole notifier as the first
panic notifier, followed by the architecture one (that coredumps).
Also, we remove a useless header inclusion.

Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Richard Weinberger <richard@nod.at>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/um/drivers/mconsole_kern.c | 8 +++-----
 arch/um/kernel/um_arch.c        | 8 ++++----
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/arch/um/drivers/mconsole_kern.c b/arch/um/drivers/mconsole_kern.c
index 8ca67a692683..2ea0421bcc3f 100644
--- a/arch/um/drivers/mconsole_kern.c
+++ b/arch/um/drivers/mconsole_kern.c
@@ -11,7 +11,6 @@
 #include <linux/list.h>
 #include <linux/mm.h>
 #include <linux/module.h>
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include <linux/reboot.h>
 #include <linux/sched/debug.h>
@@ -846,13 +845,12 @@ static int notify_panic(struct notifier_block *self, unsigned long unused1,
 
 	mconsole_notify(notify_socket, MCONSOLE_PANIC, message,
 			strlen(message) + 1);
-	return 0;
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block panic_exit_notifier = {
-	.notifier_call 		= notify_panic,
-	.next 			= NULL,
-	.priority 		= 1
+	.notifier_call	= notify_panic,
+	.priority	= INT_MAX, /* run as soon as possible */
 };
 
 static int add_notifier(void)
diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index 0760e24f2eba..4485b1a7c8e4 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -246,13 +246,13 @@ static int panic_exit(struct notifier_block *self, unsigned long unused1,
 	bust_spinlocks(0);
 	uml_exitcode = 1;
 	os_dump_core();
-	return 0;
+
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block panic_exit_notifier = {
-	.notifier_call 		= panic_exit,
-	.next 			= NULL,
-	.priority 		= 0
+	.notifier_call	= panic_exit,
+	.priority	= INT_MAX - 1, /* run as 2nd notifier, won't return */
 };
 
 void uml_finishsetup(void)
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315582.534287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgM-00089y-Sd; Wed, 27 Apr 2022 23:02:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315582.534287; Wed, 27 Apr 2022 23:02:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgL-00084v-Vi; Wed, 27 Apr 2022 23:02:49 +0000
Received: by outflank-mailman (input) for mailman id 315582;
 Wed, 27 Apr 2022 22:53:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqWz-0003q5-G2
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:53:09 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ce42759d-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:53:08 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqWj-0002CA-PR; Thu, 28 Apr 2022 00:52:54 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce42759d-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=Kr032SD5vU+3986AqF/gyJuhFfnr0rncUaszbIKwr2Y=; b=fBwyO/j+yxT2AymE7SizsCmDjX
	1r+REb2uiNLyOmmbv6Nh9J6FxLhB1bfvTpTjG3mgSTFTL8dz34enGcBQdaqLpKSF+I5gGd/nAJUMJ
	jfyQZXSy1JqEja03OmP72YQEOLiC8m3Lw1UsxeNTdyoogn1QFWiKLBkCPwl7A/i8ZlFDdHuwQzMA1
	jTKSmHNDM3VElo6fZPijCzvlYComyxyp1IGRSiaeBrih1Typo5NHSl5Gp5sEACObYkVVo4g3YPBCY
	BcFTyK5zLHDJeUb/agfenHI/ZzcT83HZfKlj9EnBYJpw9rKnDjMmdBRtHu3w1BfvP2PQydzd7nH74
	efngoTDg==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Helge Deller <deller@gmx.de>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: [PATCH 12/30] parisc: Replace regular spinlock with spin_trylock on panic path
Date: Wed, 27 Apr 2022 19:49:06 -0300
Message-Id: <20220427224924.592546-13-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The panic notifiers' callbacks execute in an atomic context, with
interrupts/preemption disabled, and all CPUs not running the panic
function are off, so it's very dangerous to wait on a regular
spinlock, there's a risk of deadlock.

This patch refactors the panic notifier of parisc/power driver
to make use of spin_trylock - for that, we've added a second
version of the soft-power function. Also, some comments were
reorganized and trailing white spaces, useless header inclusion
and blank lines were removed.

Cc: Helge Deller <deller@gmx.de>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/parisc/include/asm/pdc.h |  1 +
 arch/parisc/kernel/firmware.c | 27 +++++++++++++++++++++++----
 drivers/parisc/power.c        | 17 ++++++++++-------
 3 files changed, 34 insertions(+), 11 deletions(-)

diff --git a/arch/parisc/include/asm/pdc.h b/arch/parisc/include/asm/pdc.h
index b643092d4b98..7a106008e258 100644
--- a/arch/parisc/include/asm/pdc.h
+++ b/arch/parisc/include/asm/pdc.h
@@ -83,6 +83,7 @@ int pdc_do_firm_test_reset(unsigned long ftc_bitmap);
 int pdc_do_reset(void);
 int pdc_soft_power_info(unsigned long *power_reg);
 int pdc_soft_power_button(int sw_control);
+int pdc_soft_power_button_panic(int sw_control);
 void pdc_io_reset(void);
 void pdc_io_reset_devices(void);
 int pdc_iodc_getc(void);
diff --git a/arch/parisc/kernel/firmware.c b/arch/parisc/kernel/firmware.c
index 6a7e315bcc2e..0e2f70b592f4 100644
--- a/arch/parisc/kernel/firmware.c
+++ b/arch/parisc/kernel/firmware.c
@@ -1232,15 +1232,18 @@ int __init pdc_soft_power_info(unsigned long *power_reg)
 }
 
 /*
- * pdc_soft_power_button - Control the soft power button behaviour
- * @sw_control: 0 for hardware control, 1 for software control 
+ * pdc_soft_power_button{_panic} - Control the soft power button behaviour
+ * @sw_control: 0 for hardware control, 1 for software control
  *
  *
  * This PDC function places the soft power button under software or
  * hardware control.
- * Under software control the OS may control to when to allow to shut 
- * down the system. Under hardware control pressing the power button 
+ * Under software control the OS may control to when to allow to shut
+ * down the system. Under hardware control pressing the power button
  * powers off the system immediately.
+ *
+ * The _panic version relies in spin_trylock to prevent deadlock
+ * on panic path.
  */
 int pdc_soft_power_button(int sw_control)
 {
@@ -1254,6 +1257,22 @@ int pdc_soft_power_button(int sw_control)
 	return retval;
 }
 
+int pdc_soft_power_button_panic(int sw_control)
+{
+	int retval;
+	unsigned long flags;
+
+	if (!spin_trylock_irqsave(&pdc_lock, flags)) {
+		pr_emerg("Couldn't enable soft power button\n");
+		return -EBUSY; /* ignored by the panic notifier */
+	}
+
+	retval = mem_pdc_call(PDC_SOFT_POWER, PDC_SOFT_POWER_ENABLE, __pa(pdc_result), sw_control);
+	spin_unlock_irqrestore(&pdc_lock, flags);
+
+	return retval;
+}
+
 /*
  * pdc_io_reset - Hack to avoid overlapping range registers of Bridges devices.
  * Primarily a problem on T600 (which parisc-linux doesn't support) but
diff --git a/drivers/parisc/power.c b/drivers/parisc/power.c
index 456776bd8ee6..8512884de2cf 100644
--- a/drivers/parisc/power.c
+++ b/drivers/parisc/power.c
@@ -37,7 +37,6 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include <linux/reboot.h>
 #include <linux/sched/signal.h>
@@ -175,16 +174,21 @@ static void powerfail_interrupt(int code, void *x)
 
 
 
-/* parisc_panic_event() is called by the panic handler.
- * As soon as a panic occurs, our tasklets above will not be
- * executed any longer. This function then re-enables the 
- * soft-power switch and allows the user to switch off the system
+/*
+ * parisc_panic_event() is called by the panic handler.
+ *
+ * As soon as a panic occurs, our tasklets above will not
+ * be executed any longer. This function then re-enables
+ * the soft-power switch and allows the user to switch off
+ * the system. We rely in pdc_soft_power_button_panic()
+ * since this version spin_trylocks (instead of regular
+ * spinlock), preventing deadlocks on panic path.
  */
 static int parisc_panic_event(struct notifier_block *this,
 		unsigned long event, void *ptr)
 {
 	/* re-enable the soft-power switch */
-	pdc_soft_power_button(0);
+	pdc_soft_power_button_panic(0);
 	return NOTIFY_DONE;
 }
 
@@ -193,7 +197,6 @@ static struct notifier_block parisc_panic_block = {
 	.priority	= INT_MAX,
 };
 
-
 static int __init power_init(void)
 {
 	unsigned long ret;
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315584.534299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgP-00008P-9y; Wed, 27 Apr 2022 23:02:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315584.534299; Wed, 27 Apr 2022 23:02:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgN-0008Rm-Qv; Wed, 27 Apr 2022 23:02:51 +0000
Received: by outflank-mailman (input) for mailman id 315584;
 Wed, 27 Apr 2022 22:53:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqXD-0003q5-HV
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:53:23 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6632656-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:53:22 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqWy-0002D9-Gr; Thu, 28 Apr 2022 00:53:09 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6632656-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=TyVeNhVW0Rnl3U7SFjjiF4VJ6tQ4RncKJG9ElTcHS+U=; b=hvE2Pj35pHuqn6KDgSKo02+iOD
	gaZNRqkVbFn9vQ1y4MBHDanrICwEYbseYlrZHBUEFfY68VDZIQ086YHf/rCSUp+hPGKR8FYY9OK9v
	nYOOhcV6bCO8xGO+p+XNcPdbjxcGSaZZe5jlsSnm9qDCOj58ux/NyJ6hacLVBQ9lf2Np1cQmzz6Ne
	TKKibQQEw+thoGU6lpUAnc5gpYGmm9vwgSbtaH7Vh06JStgGFCN2k8m/ySu3R2fY0mjZnaQFnJp9F
	5MYFwY+RbtGzq1Awmj6tWKuAJuhkis/a6p5VVxSla36X0DRApqZ71nyvJTNmXiYqTaGH5nkcLaKsD
	z1NFv2eQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>
Subject: [PATCH 13/30] s390/consoles: Improve panic notifiers reliability
Date: Wed, 27 Apr 2022 19:49:07 -0300
Message-Id: <20220427224924.592546-14-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently many console drivers for s390 rely on panic/reboot notifiers
to invoke callbacks on these events. The panic() function disables local
IRQs, secondary CPUs and preemption, so callbacks invoked on panic are
effectively running in atomic context.

Happens that most of these console callbacks from s390 doesn't take the
proper care with regards to atomic context, like taking spinlocks that
might be taken in other function/CPU and hence will cause a lockup
situation.

The goal for this patch is to improve the notifiers reliability, acting
on 4 console drivers, as detailed below:

(1) con3215: changed a regular spinlock to the trylock alternative.

(2) con3270: also changed a regular spinlock to its trylock counterpart,
but here we also have another problem: raw3270_activate_view() takes a
different spinlock. So, we worked a helper to validate if this other lock
is safe to acquire, and if so, raw3270_activate_view() should be safe.

Notice though that there is a functional change here: it's now possible
to continue the notifier code [reaching con3270_wait_write() and
con3270_rebuild_update()] without executing raw3270_activate_view().

(3) sclp: a global lock is used heavily in the functions called from
the notifier, so we added a check here - if the lock is taken already,
we just bail-out, preventing the lockup.

(4) sclp_vt220: same as (3), a lock validation was added to prevent the
potential lockup problem.

Besides (1)-(4), we also removed useless void functions, adding the
code called from the notifier inside its own body, and changed the
priority of such notifiers to execute late, since they are "heavyweight"
for the panic environment, so we aim to reduce risks here.
Changed return values to NOTIFY_DONE as well, the standard one.

Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

As a design choice, the option used here to verify a given spinlock is taken
was the function "spin_is_locked()" - but we noticed that it is not often used.
An alternative would to take the lock with a spin_trylock() and if it succeeds,
just release the spinlock and continue the code. But that seemed weird...

Also, we'd like to ask a good validation of case (2) potential functionality
change from the s390 console experts - far from expert here, and in our naive
code observation, that seems fine, but that analysis might be missing some
corner case.

Thanks in advance!

 drivers/s390/char/con3215.c    | 36 +++++++++++++++--------------
 drivers/s390/char/con3270.c    | 34 +++++++++++++++------------
 drivers/s390/char/raw3270.c    | 18 +++++++++++++++
 drivers/s390/char/raw3270.h    |  1 +
 drivers/s390/char/sclp_con.c   | 28 +++++++++++++----------
 drivers/s390/char/sclp_vt220.c | 42 +++++++++++++++++++---------------
 6 files changed, 96 insertions(+), 63 deletions(-)

diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
index f356607835d8..192198bd3dc4 100644
--- a/drivers/s390/char/con3215.c
+++ b/drivers/s390/char/con3215.c
@@ -771,35 +771,37 @@ static struct tty_driver *con3215_device(struct console *c, int *index)
 }
 
 /*
- * panic() calls con3215_flush through a panic_notifier
- * before the system enters a disabled, endless loop.
+ * The below function is called as a panic/reboot notifier before the
+ * system enters a disabled, endless loop.
+ *
+ * Notice we must use the spin_trylock() alternative, to prevent lockups
+ * in atomic context (panic routine runs with secondary CPUs, local IRQs
+ * and preemption disabled).
  */
-static void con3215_flush(void)
-{
-	struct raw3215_info *raw;
-	unsigned long flags;
-
-	raw = raw3215[0];  /* console 3215 is the first one */
-	spin_lock_irqsave(get_ccwdev_lock(raw->cdev), flags);
-	raw3215_make_room(raw, RAW3215_BUFFER_SIZE);
-	spin_unlock_irqrestore(get_ccwdev_lock(raw->cdev), flags);
-}
-
 static int con3215_notify(struct notifier_block *self,
 			  unsigned long event, void *data)
 {
-	con3215_flush();
-	return NOTIFY_OK;
+	struct raw3215_info *raw;
+	unsigned long flags;
+
+	raw = raw3215[0];  /* console 3215 is the first one */
+	if (!spin_trylock_irqsave(get_ccwdev_lock(raw->cdev), flags))
+		return NOTIFY_DONE;
+
+	raw3215_make_room(raw, RAW3215_BUFFER_SIZE);
+	spin_unlock_irqrestore(get_ccwdev_lock(raw->cdev), flags);
+
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block on_panic_nb = {
 	.notifier_call = con3215_notify,
-	.priority = 0,
+	.priority = INT_MIN + 1, /* run the callback late */
 };
 
 static struct notifier_block on_reboot_nb = {
 	.notifier_call = con3215_notify,
-	.priority = 0,
+	.priority = INT_MIN + 1, /* run the callback late */
 };
 
 /*
diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
index e4592890f20a..476202f3d8a0 100644
--- a/drivers/s390/char/con3270.c
+++ b/drivers/s390/char/con3270.c
@@ -535,20 +535,29 @@ con3270_wait_write(struct con3270 *cp)
 }
 
 /*
- * panic() calls con3270_flush through a panic_notifier
- * before the system enters a disabled, endless loop.
+ * The below function is called as a panic/reboot notifier before the
+ * system enters a disabled, endless loop.
+ *
+ * Notice we must use the spin_trylock() alternative, to prevent lockups
+ * in atomic context (panic routine runs with secondary CPUs, local IRQs
+ * and preemption disabled).
  */
-static void
-con3270_flush(void)
+static int con3270_notify(struct notifier_block *self,
+			  unsigned long event, void *data)
 {
 	struct con3270 *cp;
 	unsigned long flags;
 
 	cp = condev;
 	if (!cp->view.dev)
-		return;
-	raw3270_activate_view(&cp->view);
-	spin_lock_irqsave(&cp->view.lock, flags);
+		return NOTIFY_DONE;
+
+	if (!raw3270_view_lock_unavailable(&cp->view))
+		raw3270_activate_view(&cp->view);
+
+	if (!spin_trylock_irqsave(&cp->view.lock, flags))
+		return NOTIFY_DONE;
+
 	con3270_wait_write(cp);
 	cp->nr_up = 0;
 	con3270_rebuild_update(cp);
@@ -560,23 +569,18 @@ con3270_flush(void)
 		con3270_wait_write(cp);
 	}
 	spin_unlock_irqrestore(&cp->view.lock, flags);
-}
 
-static int con3270_notify(struct notifier_block *self,
-			  unsigned long event, void *data)
-{
-	con3270_flush();
-	return NOTIFY_OK;
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block on_panic_nb = {
 	.notifier_call = con3270_notify,
-	.priority = 0,
+	.priority = INT_MIN + 1, /* run the callback late */
 };
 
 static struct notifier_block on_reboot_nb = {
 	.notifier_call = con3270_notify,
-	.priority = 0,
+	.priority = INT_MIN + 1, /* run the callback late */
 };
 
 /*
diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c
index dfde0d941c3c..7b87f9451508 100644
--- a/drivers/s390/char/raw3270.c
+++ b/drivers/s390/char/raw3270.c
@@ -830,6 +830,24 @@ raw3270_create_device(struct ccw_device *cdev)
 	return rp;
 }
 
+/*
+ * This helper just validates that it is safe to activate a
+ * view in the panic() context, due to locking restrictions.
+ */
+int
+raw3270_view_lock_unavailable(struct raw3270_view *view)
+{
+	struct raw3270 *rp = view->dev;
+
+	if (!rp)
+		return -ENODEV;
+
+	if (spin_is_locked(get_ccwdev_lock(rp->cdev)))
+		return -EBUSY;
+
+	return 0;
+}
+
 /*
  * Activate a view.
  */
diff --git a/drivers/s390/char/raw3270.h b/drivers/s390/char/raw3270.h
index c6645167cd2b..4cb6b5ee44ca 100644
--- a/drivers/s390/char/raw3270.h
+++ b/drivers/s390/char/raw3270.h
@@ -160,6 +160,7 @@ struct raw3270_view {
 };
 
 int raw3270_add_view(struct raw3270_view *, struct raw3270_fn *, int, int);
+int raw3270_view_lock_unavailable(struct raw3270_view *view);
 int raw3270_activate_view(struct raw3270_view *);
 void raw3270_del_view(struct raw3270_view *);
 void raw3270_deactivate_view(struct raw3270_view *);
diff --git a/drivers/s390/char/sclp_con.c b/drivers/s390/char/sclp_con.c
index fe5ee2646fcf..e5d947c763ea 100644
--- a/drivers/s390/char/sclp_con.c
+++ b/drivers/s390/char/sclp_con.c
@@ -220,30 +220,34 @@ sclp_console_device(struct console *c, int *index)
 }
 
 /*
- * Make sure that all buffers will be flushed to the SCLP.
+ * This panic/reboot notifier makes sure that all buffers
+ * will be flushed to the SCLP.
  */
-static void
-sclp_console_flush(void)
-{
-	sclp_conbuf_emit();
-	sclp_console_sync_queue();
-}
-
 static int sclp_console_notify(struct notifier_block *self,
 			       unsigned long event, void *data)
 {
-	sclp_console_flush();
-	return NOTIFY_OK;
+	/*
+	 * Perform the lock check before effectively getting the
+	 * lock on sclp_conbuf_emit() / sclp_console_sync_queue()
+	 * to prevent potential lockups in atomic context.
+	 */
+	if (spin_is_locked(&sclp_con_lock))
+		return NOTIFY_DONE;
+
+	sclp_conbuf_emit();
+	sclp_console_sync_queue();
+
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block on_panic_nb = {
 	.notifier_call = sclp_console_notify,
-	.priority = 1,
+	.priority = INT_MIN + 1, /* run the callback late */
 };
 
 static struct notifier_block on_reboot_nb = {
 	.notifier_call = sclp_console_notify,
-	.priority = 1,
+	.priority = INT_MIN + 1, /* run the callback late */
 };
 
 /*
diff --git a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
index 3b4e7e5d9b71..a32f34a1c6d2 100644
--- a/drivers/s390/char/sclp_vt220.c
+++ b/drivers/s390/char/sclp_vt220.c
@@ -769,21 +769,6 @@ __initcall(sclp_vt220_tty_init);
 
 #ifdef CONFIG_SCLP_VT220_CONSOLE
 
-static void __sclp_vt220_flush_buffer(void)
-{
-	unsigned long flags;
-
-	sclp_vt220_emit_current();
-	spin_lock_irqsave(&sclp_vt220_lock, flags);
-	del_timer(&sclp_vt220_timer);
-	while (sclp_vt220_queue_running) {
-		spin_unlock_irqrestore(&sclp_vt220_lock, flags);
-		sclp_sync_wait();
-		spin_lock_irqsave(&sclp_vt220_lock, flags);
-	}
-	spin_unlock_irqrestore(&sclp_vt220_lock, flags);
-}
-
 static void
 sclp_vt220_con_write(struct console *con, const char *buf, unsigned int count)
 {
@@ -797,22 +782,41 @@ sclp_vt220_con_device(struct console *c, int *index)
 	return sclp_vt220_driver;
 }
 
+/*
+ * This panic/reboot notifier runs in atomic context, so
+ * locking restrictions apply to prevent potential lockups.
+ */
 static int
 sclp_vt220_notify(struct notifier_block *self,
 			  unsigned long event, void *data)
 {
-	__sclp_vt220_flush_buffer();
-	return NOTIFY_OK;
+	unsigned long flags;
+
+	if (spin_is_locked(&sclp_vt220_lock))
+		return NOTIFY_DONE;
+
+	sclp_vt220_emit_current();
+
+	spin_lock_irqsave(&sclp_vt220_lock, flags);
+	del_timer(&sclp_vt220_timer);
+	while (sclp_vt220_queue_running) {
+		spin_unlock_irqrestore(&sclp_vt220_lock, flags);
+		sclp_sync_wait();
+		spin_lock_irqsave(&sclp_vt220_lock, flags);
+	}
+	spin_unlock_irqrestore(&sclp_vt220_lock, flags);
+
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block on_panic_nb = {
 	.notifier_call = sclp_vt220_notify,
-	.priority = 1,
+	.priority = INT_MIN + 1, /* run the callback late */
 };
 
 static struct notifier_block on_reboot_nb = {
 	.notifier_call = sclp_vt220_notify,
-	.priority = 1,
+	.priority = INT_MIN + 1, /* run the callback late */
 };
 
 /* Structure needed to register with printk */
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:02:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:02:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315586.534311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgS-0000fO-EB; Wed, 27 Apr 2022 23:02:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315586.534311; Wed, 27 Apr 2022 23:02:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgQ-0000Yc-JS; Wed, 27 Apr 2022 23:02:54 +0000
Received: by outflank-mailman (input) for mailman id 315586;
 Wed, 27 Apr 2022 22:53:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqXS-0003q5-2S
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:53:38 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df5f574c-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:53:37 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqXD-0002EK-E5; Thu, 28 Apr 2022 00:53:24 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df5f574c-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=mOzFWStqo1l1SFAwioSEW9cov+DtDc5WSMbZaYL5OFk=; b=jORyziNh7Mp7CJnb2ldBvIVUYT
	miqK/KwxTCDE0PrnGOVoO5V4xtjW+TEXZOKHxzyxZAzEuCslLE//gxMpeQbei+ydr8zg3pnWZUWxE
	L40pn68w+NUbAHLuqvLt2UI0hgcbpQZODu83KlzMI8qRKWoyX30oYob/b9pQLrf+6HFREi99ePbwb
	zW4TblodvYrIgJCYkkWUlwk3Cl/V3uSBOUWLD/GIZmkaB62kyu6wuslAaH0LxO2Qqyrw8rvwJQSXp
	vohmbyikfHUVSRBgOx4Bv9HUeJbAvmB/X4rw1kDURxjWp8eCgUztnLBZm1GN+7lilt+TPvGD7Gymp
	FQwd7uqA==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org
Subject: [PATCH 14/30] panic: Properly identify the panic event to the notifiers' callbacks
Date: Wed, 27 Apr 2022 19:49:08 -0300
Message-Id: <20220427224924.592546-15-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The notifiers infrastructure provides a way to pass an "id" to the
callbacks to determine what kind of event happened, i.e., what is
the reason behind they getting called.

The panic notifier currently pass 0, but this is soon to be
used in a multi-targeted notifier, so let's pass a meaningful
"id" over there.

Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 include/linux/panic_notifier.h | 5 +++++
 kernel/panic.c                 | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
index 41e32483d7a7..07dced83a783 100644
--- a/include/linux/panic_notifier.h
+++ b/include/linux/panic_notifier.h
@@ -9,4 +9,9 @@ extern struct atomic_notifier_head panic_notifier_list;
 
 extern bool crash_kexec_post_notifiers;
 
+enum panic_notifier_val {
+	PANIC_UNUSED,
+	PANIC_NOTIFIER = 0xDEAD,
+};
+
 #endif	/* _LINUX_PANIC_NOTIFIERS_H */
diff --git a/kernel/panic.c b/kernel/panic.c
index eb4dfb932c85..523bc9ccd0e9 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -287,7 +287,7 @@ void panic(const char *fmt, ...)
 	 * Run any panic handlers, including those that might need to
 	 * add information to the kmsg dump output.
 	 */
-	atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
+	atomic_notifier_call_chain(&panic_notifier_list, PANIC_NOTIFIER, buf);
 
 	panic_print_sys_info(false);
 
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315588.534321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgV-0001D7-9M; Wed, 27 Apr 2022 23:02:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315588.534321; Wed, 27 Apr 2022 23:02:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgT-00012x-EO; Wed, 27 Apr 2022 23:02:57 +0000
Received: by outflank-mailman (input) for mailman id 315588;
 Wed, 27 Apr 2022 22:53:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqXg-0003vS-Rg
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:53:52 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7ffcc3f-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:53:51 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqXT-0002FK-Kn; Thu, 28 Apr 2022 00:53:40 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7ffcc3f-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=LH6oQ+KUrT2+UZ27jtgU/PGKhQQ202wn79cJAeqj5IE=; b=N1tY0S0aaQeR9NcKuaJbTqnNXy
	9pcqa1SEZnYDO5/TLstJB48aWkEQ4PDoBYIETAyDlKfJL300Z2BuvN4dT08YXOJQkKQRfd88YbBla
	BhKcNiLHKco0hFkhYWPs6DIH4v+5YaEldHsDLnnpsbsgJuChEIxNDXB5/EzphACOoX7xqZH0abztl
	vLKxKzrcWguRmMXDmvcU5nsznWqZJ1nSmpm/gOBpgQqBxhdFVL/WA1XIODSmEAnbcKKqL8Xui+5p0
	wYd62C0elRAkgaFmQPZ2Uk5W3nR2kjl80X0bqLIyvZBOzCHJbiVCOEqqyvgKj3yUn8TPr60YsbPp0
	Lml85pLA==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Brian Norris <computersforpeace@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers
Date: Wed, 27 Apr 2022 19:49:09 -0300
Message-Id: <20220427224924.592546-16-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch improves the panic/die notifiers in this driver by
making use of a passed "id" instead of comparing pointer
address; also, it removes an useless prototype declaration
and unnecessary header inclusion.

This is part of a panic notifiers refactor - this notifier in
the future will be moved to a new list, that encompass the
information notifiers only.

Fixes: 9eb60880d9a9 ("bus: brcmstb_gisb: add notifier handling")
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 drivers/bus/brcmstb_gisb.c | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
index 183d5cc37d42..1ea7b015e225 100644
--- a/drivers/bus/brcmstb_gisb.c
+++ b/drivers/bus/brcmstb_gisb.c
@@ -19,7 +19,6 @@
 #include <linux/pm.h>
 #include <linux/kernel.h>
 #include <linux/kdebug.h>
-#include <linux/notifier.h>
 
 #ifdef CONFIG_MIPS
 #include <asm/traps.h>
@@ -347,25 +346,14 @@ static irqreturn_t brcmstb_gisb_bp_handler(int irq, void *dev_id)
 /*
  * Dump out gisb errors on die or panic.
  */
-static int dump_gisb_error(struct notifier_block *self, unsigned long v,
-			   void *p);
-
-static struct notifier_block gisb_die_notifier = {
-	.notifier_call = dump_gisb_error,
-};
-
-static struct notifier_block gisb_panic_notifier = {
-	.notifier_call = dump_gisb_error,
-};
-
 static int dump_gisb_error(struct notifier_block *self, unsigned long v,
 			   void *p)
 {
 	struct brcmstb_gisb_arb_device *gdev;
-	const char *reason = "panic";
+	const char *reason = "die";
 
-	if (self == &gisb_die_notifier)
-		reason = "die";
+	if (v == PANIC_NOTIFIER)
+		reason = "panic";
 
 	/* iterate over each GISB arb registered handlers */
 	list_for_each_entry(gdev, &brcmstb_gisb_arb_device_list, next)
@@ -374,6 +362,14 @@ static int dump_gisb_error(struct notifier_block *self, unsigned long v,
 	return NOTIFY_DONE;
 }
 
+static struct notifier_block gisb_die_notifier = {
+	.notifier_call = dump_gisb_error,
+};
+
+static struct notifier_block gisb_panic_notifier = {
+	.notifier_call = dump_gisb_error,
+};
+
 static DEVICE_ATTR(gisb_arb_timeout, S_IWUSR | S_IRUGO,
 		gisb_arb_get_timeout, gisb_arb_set_timeout);
 
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315590.534333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgY-0001yA-PC; Wed, 27 Apr 2022 23:03:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315590.534333; Wed, 27 Apr 2022 23:03:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgW-0001jA-Ka; Wed, 27 Apr 2022 23:03:00 +0000
Received: by outflank-mailman (input) for mailman id 315590;
 Wed, 27 Apr 2022 22:54:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqXv-0003q5-So
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:54:08 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f0d9b2b8-c67c-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:54:06 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqXh-0002GB-Ux; Thu, 28 Apr 2022 00:53:54 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0d9b2b8-c67c-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=jr6PPJ/atoVQEyGdnH+YsU0AoovP8gRpIrvldNTpl+c=; b=ZaESizBX6Rvr+B8MTwj+F1hsx0
	TWMp+gf9Io6e1FsR2UKJOjzbHs6qLm52XlDnoXO+RzNMu3SkomKypU9iwkVaK5Bqa7ShVw0pw00Kp
	fujm/8kyfH6iuIIDam6L6uEqfdWPgiVKAJ9VFDPPEEOuP114yBIfNVKo+BdDMswd4oQFFBy0f1ZLI
	mTRoQaTdP5jbR2QiHo9Su/NVNzsL7BHWKl9w6IpBA0zzwN/TL+4rwH7vQNft8J1AAGTDlFILy+oXN
	3VHdSwGj5OvLrvgNSuTRoQEPOGiiV4mpG60XBb4y5x9eVCckUZfRP0lJtx7j5o67sNcEn6v23HcoW
	LqvtZDZQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Andrea Parri <parri.andrea@gmail.com>,
	Dexuan Cui <decui@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>
Subject: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers
Date: Wed, 27 Apr 2022 19:49:10 -0300
Message-Id: <20220427224924.592546-17-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently Hyper-V guests are among the most relevant users of the panic
infrastructure, like panic notifiers, kmsg dumpers, etc. The reasons rely
both in cleaning-up procedures (closing a hypervisor <-> guest connection,
disabling a paravirtualized timer) as well as to data collection (sending
panic information to the hypervisor) and framebuffer management.

The thing is: some notifiers are related to others, ordering matters, some
functionalities are duplicated and there are lots of conditionals behind
sending panic information to the hypervisor. This patch, as part of an
effort to clean-up the panic notifiers mechanism and better document
things, address some of the issues/complexities of Hyper-V panic handling
through the following changes:

(a) We have die and panic notifiers on vmbus_drv.c and both have goals of
sending panic information to the hypervisor, though the panic notifier is
also responsible for a cleaning-up procedure.

This commit clears the code by splitting the panic notifier in two, one
for closing the vmbus connection whereas the other is only for sending
panic info to hypervisor. With that, it was possible to merge the die and
panic notifiers in a single/well-documented function, and clear some
conditional complexities on sending such information to the hypervisor.

(b) The new panic notifier created after (a) is only doing a single thing:
cleaning the vmbus connection. This procedure might cause a delay (due to
hypervisor I/O completion), so we postpone that to run late. But more
relevant: this *same* vmbus unloading happens in the crash_shutdown()
handler, so if kdump is set, we can safely skip this panic notifier and
defer such clean-up to the kexec crash handler.

(c) There is also a Hyper-V framebuffer panic notifier, which relies in
doing a vmbus operation that demands a valid connection. So, we must
order this notifier with the panic notifier from vmbus_drv.c, in order to
guarantee that the framebuffer code executes before the vmbus connection
is unloaded.

Also, this commit removes a useless header.

Although there is code rework and re-ordering, we expect that this change
has no functional regressions but instead optimize the path and increase
panic reliability on Hyper-V. This was tested on Hyper-V with success.

Fixes: 792f232d57ff ("Drivers: hv: vmbus: Fix potential crash on module unload")
Fixes: 74347a99e73a ("x86/Hyper-V: Unload vmbus channel in hv panic callback")
Cc: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Michael Kelley <mikelley@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Tested-by: Fabio A M Martins <fabiomirmar@gmail.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

Special thanks to Michael Kelley for the good information about the Hyper-V
panic path in email threads some months ago, and to Fabio for the testing
performed.

Michael and all Microsoft folks: a careful analysis to double-check our changes
and assumptions here is really appreciated, this code is complex and intricate,
it is possible some corner case might have been overlooked.

Thanks in advance!

 drivers/hv/vmbus_drv.c          | 109 ++++++++++++++++++++------------
 drivers/video/fbdev/hyperv_fb.c |   8 +++
 2 files changed, 76 insertions(+), 41 deletions(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 14de17087864..f37f12d48001 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -24,11 +24,11 @@
 #include <linux/sched/task_stack.h>
 
 #include <linux/delay.h>
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include <linux/ptrace.h>
 #include <linux/screen_info.h>
 #include <linux/kdebug.h>
+#include <linux/kexec.h>
 #include <linux/efi.h>
 #include <linux/random.h>
 #include <linux/kernel.h>
@@ -68,51 +68,75 @@ static int hyperv_report_reg(void)
 	return !sysctl_record_panic_msg || !hv_panic_page;
 }
 
-static int hyperv_panic_event(struct notifier_block *nb, unsigned long val,
+/*
+ * The panic notifier below is responsible solely for unloading the
+ * vmbus connection, which is necessary in a panic event. But notice
+ * that this same unloading procedure is executed in the Hyper-V
+ * crash_shutdown() handler [see hv_crash_handler()], which basically
+ * means that we can postpone its execution if we have kdump set,
+ * since it will run the crash_shutdown() handler anyway. Even more
+ * intrincated is the relation of this notifier with Hyper-V framebuffer
+ * panic notifier - we need vmbus connection alive there in order to
+ * succeed, so we need to order both with each other [for reference see
+ * hvfb_on_panic()] - this is done using notifiers' priorities.
+ */
+static int hv_panic_vmbus_unload(struct notifier_block *nb, unsigned long val,
 			      void *args)
+{
+	if (!kexec_crash_loaded())
+		vmbus_initiate_unload(true);
+
+	return NOTIFY_DONE;
+}
+static struct notifier_block hyperv_panic_vmbus_unload_block = {
+	.notifier_call	= hv_panic_vmbus_unload,
+	.priority	= INT_MIN + 1, /* almost the latest one to execute */
+};
+
+/*
+ * The following callback works both as die and panic notifier; its
+ * goal is to provide panic information to the hypervisor unless the
+ * kmsg dumper is gonna be used [see hv_kmsg_dump()], which provides
+ * more information but is not always available.
+ *
+ * Notice that both the panic/die report notifiers are registered only
+ * if we have the capability HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE set.
+ */
+static int hv_die_panic_notify_crash(struct notifier_block *nb,
+				     unsigned long val, void *args)
 {
 	struct pt_regs *regs;
+	bool is_die;
 
-	vmbus_initiate_unload(true);
-
-	/*
-	 * Hyper-V should be notified only once about a panic.  If we will be
-	 * doing hv_kmsg_dump() with kmsg data later, don't do the notification
-	 * here.
-	 */
-	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE
-	    && hyperv_report_reg()) {
+	/* Don't notify Hyper-V unless we have a die oops event or panic. */
+	switch (val) {
+	case DIE_OOPS:
+		is_die = true;
+		regs = ((struct die_args *)args)->regs;
+		break;
+	case PANIC_NOTIFIER:
+		is_die = false;
 		regs = current_pt_regs();
-		hyperv_report_panic(regs, val, false);
-	}
-	return NOTIFY_DONE;
-}
-
-static int hyperv_die_event(struct notifier_block *nb, unsigned long val,
-			    void *args)
-{
-	struct die_args *die = args;
-	struct pt_regs *regs = die->regs;
-
-	/* Don't notify Hyper-V if the die event is other than oops */
-	if (val != DIE_OOPS)
+		break;
+	default:
 		return NOTIFY_DONE;
+	}
 
 	/*
-	 * Hyper-V should be notified only once about a panic.  If we will be
-	 * doing hv_kmsg_dump() with kmsg data later, don't do the notification
-	 * here.
+	 * Hyper-V should be notified only once about a panic/die. If we will
+	 * be calling hv_kmsg_dump() later with kmsg data, don't do the
+	 * notification here.
 	 */
 	if (hyperv_report_reg())
-		hyperv_report_panic(regs, val, true);
+		hyperv_report_panic(regs, val, is_die);
+
 	return NOTIFY_DONE;
 }
-
-static struct notifier_block hyperv_die_block = {
-	.notifier_call = hyperv_die_event,
+static struct notifier_block hyperv_die_report_block = {
+	.notifier_call = hv_die_panic_notify_crash,
 };
-static struct notifier_block hyperv_panic_block = {
-	.notifier_call = hyperv_panic_event,
+static struct notifier_block hyperv_panic_report_block = {
+	.notifier_call = hv_die_panic_notify_crash,
 };
 
 static const char *fb_mmio_name = "fb_range";
@@ -1589,16 +1613,17 @@ static int vmbus_bus_init(void)
 		if (hyperv_crash_ctl & HV_CRASH_CTL_CRASH_NOTIFY_MSG)
 			hv_kmsg_dump_register();
 
-		register_die_notifier(&hyperv_die_block);
+		register_die_notifier(&hyperv_die_report_block);
+		atomic_notifier_chain_register(&panic_notifier_list,
+						&hyperv_panic_report_block);
 	}
 
 	/*
-	 * Always register the panic notifier because we need to unload
-	 * the VMbus channel connection to prevent any VMbus
-	 * activity after the VM panics.
+	 * Always register the vmbus unload panic notifier because we
+	 * need to shut the VMbus channel connection on panic.
 	 */
 	atomic_notifier_chain_register(&panic_notifier_list,
-			       &hyperv_panic_block);
+			       &hyperv_panic_vmbus_unload_block);
 
 	vmbus_request_offers();
 
@@ -2817,15 +2842,17 @@ static void __exit vmbus_exit(void)
 
 	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) {
 		kmsg_dump_unregister(&hv_kmsg_dumper);
-		unregister_die_notifier(&hyperv_die_block);
+		unregister_die_notifier(&hyperv_die_report_block);
+		atomic_notifier_chain_unregister(&panic_notifier_list,
+						&hyperv_panic_report_block);
 	}
 
 	/*
-	 * The panic notifier is always registered, hence we should
+	 * The vmbus panic notifier is always registered, hence we should
 	 * also unconditionally unregister it here as well.
 	 */
 	atomic_notifier_chain_unregister(&panic_notifier_list,
-					 &hyperv_panic_block);
+					&hyperv_panic_vmbus_unload_block);
 
 	free_page((unsigned long)hv_panic_page);
 	unregister_sysctl_table(hv_ctl_table_hdr);
diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
index c8e0ea27caf1..f3494b868a64 100644
--- a/drivers/video/fbdev/hyperv_fb.c
+++ b/drivers/video/fbdev/hyperv_fb.c
@@ -1244,7 +1244,15 @@ static int hvfb_probe(struct hv_device *hdev,
 	par->fb_ready = true;
 
 	par->synchronous_fb = false;
+
+	/*
+	 * We need to be sure this panic notifier runs _before_ the
+	 * vmbus disconnect, so order it by priority. It must execute
+	 * before the function hv_panic_vmbus_unload() [drivers/hv/vmbus_drv.c],
+	 * which is almost at the end of list, with priority = INT_MIN + 1.
+	 */
 	par->hvfb_panic_nb.notifier_call = hvfb_on_panic;
+	par->hvfb_panic_nb.priority = INT_MIN + 10,
 	atomic_notifier_chain_register(&panic_notifier_list,
 				       &par->hvfb_panic_nb);
 
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315592.534342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqga-0002Xc-Au; Wed, 27 Apr 2022 23:03:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315592.534342; Wed, 27 Apr 2022 23:03:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgZ-0002OT-1U; Wed, 27 Apr 2022 23:03:03 +0000
Received: by outflank-mailman (input) for mailman id 315592;
 Wed, 27 Apr 2022 22:54:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqYH-0003xM-8I
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:54:29 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fd6284e2-c67c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:54:27 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqY1-0002Ha-Aa; Thu, 28 Apr 2022 00:54:15 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd6284e2-c67c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=gwBR7P38mmxeEI4wWnwfuOo3Vx6Wo8buxtIoJ+/ueVE=; b=nwXMrZImrRof6aT4nflSriZWm8
	nV+2kfTnZMr3qMfu/pdKx8zdoFC6dPSZfgjMR8nrCqKQx0a9STr9zXRmf603LSCMYxoe/0rzj8WAX
	X04mzyflhbAneN3N3eqd1bEuJEgnFV2TubG1LTS2zdwee0DTxDCCfkp/jZLLefrxcRie9zAR6UkMF
	CbBI0mU22IJBGJ0ER3H7bHP1OaQk7bRcIVlpHROO0rfL6uLx6VUv9a0aPf+94uNbhp5w7FYgnWnfd
	FC3cJ2sUp+UEhn1teUMFvXk88fY0u++AP/ytEp5+rJzALI+oR2Quq3NLCvwKLKxi/cwHyaoyY3uHg
	LhfKC/tQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org
Subject: [PATCH 17/30] tracing: Improve panic/die notifiers
Date: Wed, 27 Apr 2022 19:49:11 -0300
Message-Id: <20220427224924.592546-18-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently the tracing dump_on_oops feature is implemented
through separate notifiers, one for die/oops and the other
for panic. With the addition of panic notifier "id", this
patch makes use of such "id" to unify both functions.

It also comments the function and changes the priority of the
notifier blocks, in order they run early compared to other
notifiers, to prevent useless trace data (like the callback
names for the other notifiers). Finally, we also removed an
unnecessary header inclusion.

Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 kernel/trace/trace.c | 57 +++++++++++++++++++++++++-------------------
 1 file changed, 32 insertions(+), 25 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index f4de111fa18f..c1d8a3622ccc 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -19,7 +19,6 @@
 #include <linux/kallsyms.h>
 #include <linux/security.h>
 #include <linux/seq_file.h>
-#include <linux/notifier.h>
 #include <linux/irqflags.h>
 #include <linux/debugfs.h>
 #include <linux/tracefs.h>
@@ -9767,38 +9766,46 @@ static __init int tracer_init_tracefs(void)
 
 fs_initcall(tracer_init_tracefs);
 
-static int trace_panic_handler(struct notifier_block *this,
-			       unsigned long event, void *unused)
+/*
+ * The idea is to execute the following die/panic callback early, in order
+ * to avoid showing irrelevant information in the trace (like other panic
+ * notifier functions); we are the 2nd to run, after hung_task/rcu_stall
+ * warnings get disabled (to prevent potential log flooding).
+ */
+static int trace_die_panic_handler(struct notifier_block *self,
+				unsigned long ev, void *unused)
 {
-	if (ftrace_dump_on_oops)
+	int do_dump;
+
+	if (!ftrace_dump_on_oops)
+		return NOTIFY_DONE;
+
+	switch (ev) {
+	case DIE_OOPS:
+		do_dump = 1;
+		break;
+	case PANIC_NOTIFIER:
+		do_dump = 1;
+		break;
+	default:
+		do_dump = 0;
+		break;
+	}
+
+	if (do_dump)
 		ftrace_dump(ftrace_dump_on_oops);
-	return NOTIFY_OK;
+
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block trace_panic_notifier = {
-	.notifier_call  = trace_panic_handler,
-	.next           = NULL,
-	.priority       = 150   /* priority: INT_MAX >= x >= 0 */
+	.notifier_call = trace_die_panic_handler,
+	.priority = INT_MAX - 1,
 };
 
-static int trace_die_handler(struct notifier_block *self,
-			     unsigned long val,
-			     void *data)
-{
-	switch (val) {
-	case DIE_OOPS:
-		if (ftrace_dump_on_oops)
-			ftrace_dump(ftrace_dump_on_oops);
-		break;
-	default:
-		break;
-	}
-	return NOTIFY_OK;
-}
-
 static struct notifier_block trace_die_notifier = {
-	.notifier_call = trace_die_handler,
-	.priority = 200
+	.notifier_call = trace_die_panic_handler,
+	.priority = INT_MAX - 1,
 };
 
 /*
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315594.534353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgc-00032q-74; Wed, 27 Apr 2022 23:03:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315594.534353; Wed, 27 Apr 2022 23:03:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqga-0002sz-To; Wed, 27 Apr 2022 23:03:04 +0000
Received: by outflank-mailman (input) for mailman id 315594;
 Wed, 27 Apr 2022 22:54:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqYU-0003xM-Qy
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:54:42 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 05e57058-c67d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:54:42 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqYG-0002IR-Ki; Thu, 28 Apr 2022 00:54:29 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05e57058-c67d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=oI9b5duO8OJ5vQDZCcg8/YSfwN8M5sfdHxH8XUnmtlk=; b=Dl2B7pSVJp25fe7IfIs24mmkq8
	hNWQZdfuE5b8NzwyHqbjR/6C1jbxbEv8wNNcNdcZK+x2mWiNzNr+u6ej0RkZPoYhNEHBCsZ6UD+6G
	UKVT1x0W1ctGqUC1Gq0pKfbBSIn3/AQDQpBwhuyH0wupCzlBVEy+S+oaSi7mTGACgenSYzi35Memm
	cwNrE6VLPhA8HIa6SL7ijwVZV/Cmf5guYFGY1etNEWb16ALz0OIjrK84zUZZaRulPOC47prAFsrmC
	8jtFSnfk5SwoqCho0RbgOB8YFry+V3AQ6FT8GxIeK9uuEGFeYv+qjRy2g8pgwIU4Wj4/dnNONMvQE
	5U+RG0NQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Arjan van de Ven <arjan@linux.intel.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Xiaoming Ni <nixiaoming@huawei.com>
Subject: [PATCH 18/30] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set
Date: Wed, 27 Apr 2022 19:49:12 -0300
Message-Id: <20220427224924.592546-19-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently we have a debug infrastructure in the notifiers file, but
it's very simple/limited. This patch extends it by:

(a) Showing all registered/unregistered notifiers' callback names;

(b) Adding a dynamic debug tuning to allow showing called notifiers'
function names. Notice that this should be guarded as a tunable since
it can flood the kernel log buffer.

Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Valentin Schneider <valentin.schneider@arm.com>
Cc: Xiaoming Ni <nixiaoming@huawei.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

We have some design decisions that worth discussing here:

(a) First of call, using C99 helps a lot to write clear and concise code, but
due to commit 4d94f910e79a ("Kbuild: use -Wdeclaration-after-statement") we
have a warning if mixing variable declarations with code. For this patch though,
doing that makes the code way clear, so decision was to add the debug code
inside brackets whenever this warning pops up. We can change that, but that'll
cause more ifdefs in the same function.

(b) In the symbol lookup helper function, we modify the parameter passed but
even more, we return it as well! This is unusual and seems unnecessary, but was
the strategy taken to allow embedding such function in the pr_debug() call.

Not doing that would likely requiring 3 symbol_name variables to avoid
concurrency (registering notifier A while calling notifier B) - we rely in
local variables as a serialization mechanism.

We're open for suggestions in case this design is not appropriate;
thanks in advance!

 kernel/notifier.c | 48 +++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 46 insertions(+), 2 deletions(-)

diff --git a/kernel/notifier.c b/kernel/notifier.c
index ba005ebf4730..21032ebcde57 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -7,6 +7,22 @@
 #include <linux/vmalloc.h>
 #include <linux/reboot.h>
 
+#ifdef CONFIG_DEBUG_NOTIFIERS
+#include <linux/kallsyms.h>
+
+/*
+ *	Helper to get symbol names in case DEBUG_NOTIFIERS is set.
+ *	Return the modified parameter is a strategy used to achieve
+ *	the pr_debug() functionality - with this, function is only
+ *	executed if the dynamic debug tuning is effectively set.
+ */
+static inline char *notifier_name(struct notifier_block *nb, char *sym_name)
+{
+	lookup_symbol_name((unsigned long)(nb->notifier_call), sym_name);
+	return sym_name;
+}
+#endif
+
 /*
  *	Notifier list for kernel code which wants to be called
  *	at shutdown. This is used to stop any idling DMA operations
@@ -34,20 +50,41 @@ static int notifier_chain_register(struct notifier_block **nl,
 	}
 	n->next = *nl;
 	rcu_assign_pointer(*nl, n);
+
+#ifdef CONFIG_DEBUG_NOTIFIERS
+	{
+		char sym_name[KSYM_NAME_LEN];
+
+		pr_info("notifiers: registered %s()\n",
+			notifier_name(n, sym_name));
+	}
+#endif
 	return 0;
 }
 
 static int notifier_chain_unregister(struct notifier_block **nl,
 		struct notifier_block *n)
 {
+	int ret = -ENOENT;
+
 	while ((*nl) != NULL) {
 		if ((*nl) == n) {
 			rcu_assign_pointer(*nl, n->next);
-			return 0;
+			ret = 0;
+			break;
 		}
 		nl = &((*nl)->next);
 	}
-	return -ENOENT;
+
+#ifdef CONFIG_DEBUG_NOTIFIERS
+	if (!ret) {
+		char sym_name[KSYM_NAME_LEN];
+
+		pr_info("notifiers: unregistered %s()\n",
+			notifier_name(n, sym_name));
+	}
+#endif
+	return ret;
 }
 
 /**
@@ -80,6 +117,13 @@ static int notifier_call_chain(struct notifier_block **nl,
 			nb = next_nb;
 			continue;
 		}
+
+		{
+			char sym_name[KSYM_NAME_LEN];
+
+			pr_debug("notifiers: calling %s()\n",
+				 notifier_name(nb, sym_name));
+		}
 #endif
 		ret = nb->notifier_call(nb, val, v);
 
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315596.534364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqge-0003TX-0y; Wed, 27 Apr 2022 23:03:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315596.534364; Wed, 27 Apr 2022 23:03:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgc-0003LP-GJ; Wed, 27 Apr 2022 23:03:06 +0000
Received: by outflank-mailman (input) for mailman id 315596;
 Wed, 27 Apr 2022 22:55:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqYv-0003yk-KE
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:55:09 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 14508282-c67d-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:55:06 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqYb-0002JS-Nh; Thu, 28 Apr 2022 00:54:50 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14508282-c67d-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=UhhPFJqW26A1a6soa6rznnjXRjwvDkXyweuhXfNQOVY=; b=MKBh56UTZ7JCBvBjxeK61V4jDM
	v7kwzQJKazlMRxSRc2ZqArefnMuAMvJRSN0Dm/n3rUqjfn87xJdCwCNZgYYInNcW7KLaZieSBQ8O6
	XsgLVHkw+gGyoqVfpHoR7HGpc4dRel8YFV0PNkyLnVjOtFb6zpg44r32e+Cy7IowfRZ1AwUGXIuJK
	ogEnepSyse/P/gSxYI2obKAoqpGM2oj0KXhOmKybDbZdIj++zZDEM0H4AKnIRoCEV72z/ad5u+yfX
	mziNZTi1DoyU2ltDkam4BhJMX4t8MGH4SNKViSUOE5Td2/P7EGuXXRrbm7W62coqKt68Zw2u7NGpT
	+e52kJVw==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Andrea Parri <parri.andrea@gmail.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	David Gow <davidgow@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Dexuan Cui <decui@microsoft.com>,
	Doug Berger <opendmb@gmail.com>,
	Evan Green <evgreen@chromium.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Julius Werner <jwerner@chromium.org>,
	Justin Chen <justinpopo6@gmail.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Lee Jones <lee.jones@linaro.org>,
	Markus Mayer <mmayer@broadcom.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Mihai Carabas <mihai.carabas@oracle.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Pavel Machek <pavel@ucw.cz>,
	Scott Branden <scott.branden@broadcom.com>,
	Sebastian Reichel <sre@kernel.org>,
	Shile Zhang <shile.zhang@linux.alibaba.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Wang ShaoBo <bobo.shaobowang@huawei.com>,
	Wei Liu <wei.liu@kernel.org>,
	zhenwei pi <pizhenwei@bytedance.com>
Subject: [PATCH 19/30] panic: Add the panic hypervisor notifier list
Date: Wed, 27 Apr 2022 19:49:13 -0300
Message-Id: <20220427224924.592546-20-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The goal of this new panic notifier is to allow its users to register
callbacks to run very early in the panic path. This aims hypervisor/FW
notification mechanisms as well as simple LED functions, and any other
simple and safe mechanism that should run early in the panic path; more
dangerous callbacks should execute later.

For now, the patch is almost a no-op (although it changes a bit the
ordering in which some panic notifiers are executed). In a subsequent
patch, the panic path will be refactored, then the panic hypervisor
notifiers will effectively run very early in the panic path.

We also defer documenting it all properly in the subsequent refactor
patch. While at it, we removed some useless header inclusions and
fixed some notifiers return too (by using the standard NOTIFY_DONE).

Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: David Gow <davidgow@google.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Evan Green <evgreen@chromium.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hari Bathini <hbathini@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Justin Chen <justinpopo6@gmail.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Markus Mayer <mmayer@broadcom.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Michael Kelley <mikelley@microsoft.com>
Cc: Mihai Carabas <mihai.carabas@oracle.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Scott Branden <scott.branden@broadcom.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Wang ShaoBo <bobo.shaobowang@huawei.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: zhenwei pi <pizhenwei@bytedance.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/mips/sgi-ip22/ip22-reset.c          | 2 +-
 arch/mips/sgi-ip32/ip32-reset.c          | 3 +--
 arch/powerpc/kernel/setup-common.c       | 2 +-
 arch/sparc/kernel/sstate.c               | 3 +--
 drivers/firmware/google/gsmi.c           | 4 ++--
 drivers/hv/vmbus_drv.c                   | 4 ++--
 drivers/leds/trigger/ledtrig-activity.c  | 4 ++--
 drivers/leds/trigger/ledtrig-heartbeat.c | 4 ++--
 drivers/misc/bcm-vk/bcm_vk_dev.c         | 6 +++---
 drivers/misc/pvpanic/pvpanic.c           | 4 ++--
 drivers/power/reset/ltc2952-poweroff.c   | 4 ++--
 drivers/s390/char/zcore.c                | 5 +++--
 drivers/soc/bcm/brcmstb/pm/pm-arm.c      | 2 +-
 include/linux/panic_notifier.h           | 1 +
 kernel/panic.c                           | 4 ++++
 15 files changed, 28 insertions(+), 24 deletions(-)

diff --git a/arch/mips/sgi-ip22/ip22-reset.c b/arch/mips/sgi-ip22/ip22-reset.c
index 8f0861c58080..3023848acbf1 100644
--- a/arch/mips/sgi-ip22/ip22-reset.c
+++ b/arch/mips/sgi-ip22/ip22-reset.c
@@ -195,7 +195,7 @@ static int __init reboot_setup(void)
 	}
 
 	timer_setup(&blink_timer, blink_timeout, 0);
-	atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
+	atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block);
 
 	return 0;
 }
diff --git a/arch/mips/sgi-ip32/ip32-reset.c b/arch/mips/sgi-ip32/ip32-reset.c
index 18d1c115cd53..9ee1302c9d13 100644
--- a/arch/mips/sgi-ip32/ip32-reset.c
+++ b/arch/mips/sgi-ip32/ip32-reset.c
@@ -15,7 +15,6 @@
 #include <linux/panic_notifier.h>
 #include <linux/sched.h>
 #include <linux/sched/signal.h>
-#include <linux/notifier.h>
 #include <linux/delay.h>
 #include <linux/rtc/ds1685.h>
 #include <linux/interrupt.h>
@@ -145,7 +144,7 @@ static __init int ip32_reboot_setup(void)
 	pm_power_off = ip32_machine_halt;
 
 	timer_setup(&blink_timer, blink_timeout, 0);
-	atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
+	atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block);
 
 	return 0;
 }
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 52f96b209a96..1468c3937bf4 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -753,7 +753,7 @@ static struct notifier_block ppc_panic_block = {
 void __init setup_panic(void)
 {
 	/* Hard-disables IRQs + deal with FW-assisted dump (fadump) */
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_hypervisor_list,
 				       &ppc_fadump_block);
 
 	if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && kaslr_offset() > 0)
diff --git a/arch/sparc/kernel/sstate.c b/arch/sparc/kernel/sstate.c
index 3bcc4ddc6911..82b7b68e0bdc 100644
--- a/arch/sparc/kernel/sstate.c
+++ b/arch/sparc/kernel/sstate.c
@@ -5,7 +5,6 @@
  */
 
 #include <linux/kernel.h>
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include <linux/reboot.h>
 #include <linux/init.h>
@@ -106,7 +105,7 @@ static int __init sstate_init(void)
 
 	do_set_sstate(HV_SOFT_STATE_TRANSITION, booting_msg);
 
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_hypervisor_list,
 				       &sstate_panic_block);
 	register_reboot_notifier(&sstate_reboot_notifier);
 
diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index b01ed02e4a87..ff0bebe2f444 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -1034,7 +1034,7 @@ static __init int gsmi_init(void)
 
 	register_reboot_notifier(&gsmi_reboot_notifier);
 	register_die_notifier(&gsmi_die_notifier);
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_hypervisor_list,
 				       &gsmi_panic_notifier);
 
 	printk(KERN_INFO "gsmi version " DRIVER_VERSION " loaded\n");
@@ -1061,7 +1061,7 @@ static void __exit gsmi_exit(void)
 {
 	unregister_reboot_notifier(&gsmi_reboot_notifier);
 	unregister_die_notifier(&gsmi_die_notifier);
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_hypervisor_list,
 					 &gsmi_panic_notifier);
 #ifdef CONFIG_EFI
 	efivars_unregister(&efivars);
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index f37f12d48001..901b97034308 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1614,7 +1614,7 @@ static int vmbus_bus_init(void)
 			hv_kmsg_dump_register();
 
 		register_die_notifier(&hyperv_die_report_block);
-		atomic_notifier_chain_register(&panic_notifier_list,
+		atomic_notifier_chain_register(&panic_hypervisor_list,
 						&hyperv_panic_report_block);
 	}
 
@@ -2843,7 +2843,7 @@ static void __exit vmbus_exit(void)
 	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) {
 		kmsg_dump_unregister(&hv_kmsg_dumper);
 		unregister_die_notifier(&hyperv_die_report_block);
-		atomic_notifier_chain_unregister(&panic_notifier_list,
+		atomic_notifier_chain_unregister(&panic_hypervisor_list,
 						&hyperv_panic_report_block);
 	}
 
diff --git a/drivers/leds/trigger/ledtrig-activity.c b/drivers/leds/trigger/ledtrig-activity.c
index 30bc9df03636..bbbcf3bc17e3 100644
--- a/drivers/leds/trigger/ledtrig-activity.c
+++ b/drivers/leds/trigger/ledtrig-activity.c
@@ -247,7 +247,7 @@ static int __init activity_init(void)
 	int rc = led_trigger_register(&activity_led_trigger);
 
 	if (!rc) {
-		atomic_notifier_chain_register(&panic_notifier_list,
+		atomic_notifier_chain_register(&panic_hypervisor_list,
 					       &activity_panic_nb);
 		register_reboot_notifier(&activity_reboot_nb);
 	}
@@ -257,7 +257,7 @@ static int __init activity_init(void)
 static void __exit activity_exit(void)
 {
 	unregister_reboot_notifier(&activity_reboot_nb);
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_hypervisor_list,
 					 &activity_panic_nb);
 	led_trigger_unregister(&activity_led_trigger);
 }
diff --git a/drivers/leds/trigger/ledtrig-heartbeat.c b/drivers/leds/trigger/ledtrig-heartbeat.c
index 7fe0a05574d2..a1ed25e83c8f 100644
--- a/drivers/leds/trigger/ledtrig-heartbeat.c
+++ b/drivers/leds/trigger/ledtrig-heartbeat.c
@@ -190,7 +190,7 @@ static int __init heartbeat_trig_init(void)
 	int rc = led_trigger_register(&heartbeat_led_trigger);
 
 	if (!rc) {
-		atomic_notifier_chain_register(&panic_notifier_list,
+		atomic_notifier_chain_register(&panic_hypervisor_list,
 					       &heartbeat_panic_nb);
 		register_reboot_notifier(&heartbeat_reboot_nb);
 	}
@@ -200,7 +200,7 @@ static int __init heartbeat_trig_init(void)
 static void __exit heartbeat_trig_exit(void)
 {
 	unregister_reboot_notifier(&heartbeat_reboot_nb);
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_hypervisor_list,
 					 &heartbeat_panic_nb);
 	led_trigger_unregister(&heartbeat_led_trigger);
 }
diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
index a16b99bdaa13..d9d5199cdb2b 100644
--- a/drivers/misc/bcm-vk/bcm_vk_dev.c
+++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
@@ -1446,7 +1446,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	/* register for panic notifier */
 	vk->panic_nb.notifier_call = bcm_vk_on_panic;
-	err = atomic_notifier_chain_register(&panic_notifier_list,
+	err = atomic_notifier_chain_register(&panic_hypervisor_list,
 					     &vk->panic_nb);
 	if (err) {
 		dev_err(dev, "Fail to register panic notifier\n");
@@ -1486,7 +1486,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	bcm_vk_tty_exit(vk);
 
 err_unregister_panic_notifier:
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_hypervisor_list,
 					 &vk->panic_nb);
 
 err_destroy_workqueue:
@@ -1559,7 +1559,7 @@ static void bcm_vk_remove(struct pci_dev *pdev)
 	usleep_range(BCM_VK_UCODE_BOOT_US, BCM_VK_UCODE_BOOT_MAX_US);
 
 	/* unregister panic notifier */
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_hypervisor_list,
 					 &vk->panic_nb);
 
 	bcm_vk_msg_remove(vk);
diff --git a/drivers/misc/pvpanic/pvpanic.c b/drivers/misc/pvpanic/pvpanic.c
index 049a12006348..233a71d89477 100644
--- a/drivers/misc/pvpanic/pvpanic.c
+++ b/drivers/misc/pvpanic/pvpanic.c
@@ -101,7 +101,7 @@ static int pvpanic_init(void)
 	INIT_LIST_HEAD(&pvpanic_list);
 	spin_lock_init(&pvpanic_lock);
 
-	atomic_notifier_chain_register(&panic_notifier_list, &pvpanic_panic_nb);
+	atomic_notifier_chain_register(&panic_hypervisor_list, &pvpanic_panic_nb);
 
 	return 0;
 }
@@ -109,7 +109,7 @@ module_init(pvpanic_init);
 
 static void pvpanic_exit(void)
 {
-	atomic_notifier_chain_unregister(&panic_notifier_list, &pvpanic_panic_nb);
+	atomic_notifier_chain_unregister(&panic_hypervisor_list, &pvpanic_panic_nb);
 
 }
 module_exit(pvpanic_exit);
diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c
index 65d9528cc989..fb5078ba3a69 100644
--- a/drivers/power/reset/ltc2952-poweroff.c
+++ b/drivers/power/reset/ltc2952-poweroff.c
@@ -279,7 +279,7 @@ static int ltc2952_poweroff_probe(struct platform_device *pdev)
 	pm_power_off = ltc2952_poweroff_kill;
 
 	data->panic_notifier.notifier_call = ltc2952_poweroff_notify_panic;
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_hypervisor_list,
 				       &data->panic_notifier);
 	dev_info(&pdev->dev, "probe successful\n");
 
@@ -293,7 +293,7 @@ static int ltc2952_poweroff_remove(struct platform_device *pdev)
 	pm_power_off = NULL;
 	hrtimer_cancel(&data->timer_trigger);
 	hrtimer_cancel(&data->timer_wde);
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_hypervisor_list,
 					 &data->panic_notifier);
 	return 0;
 }
diff --git a/drivers/s390/char/zcore.c b/drivers/s390/char/zcore.c
index 516783ba950f..768a8a3a9046 100644
--- a/drivers/s390/char/zcore.c
+++ b/drivers/s390/char/zcore.c
@@ -246,7 +246,7 @@ static int zcore_reboot_and_on_panic_handler(struct notifier_block *self,
 	if (hsa_available)
 		release_hsa();
 
-	return NOTIFY_OK;
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block zcore_reboot_notifier = {
@@ -322,7 +322,8 @@ static int __init zcore_init(void)
 					     NULL, &zcore_hsa_fops);
 
 	register_reboot_notifier(&zcore_reboot_notifier);
-	atomic_notifier_chain_register(&panic_notifier_list, &zcore_on_panic_notifier);
+	atomic_notifier_chain_register(&panic_hypervisor_list,
+				       &zcore_on_panic_notifier);
 
 	return 0;
 fail:
diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c
index 870686ae042b..babca66c7862 100644
--- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c
+++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c
@@ -814,7 +814,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev)
 		goto out;
 	}
 
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_hypervisor_list,
 				       &brcmstb_pm_panic_nb);
 
 	pm_power_off = brcmstb_pm_poweroff;
diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
index 07dced83a783..0bb9dc0dea04 100644
--- a/include/linux/panic_notifier.h
+++ b/include/linux/panic_notifier.h
@@ -6,6 +6,7 @@
 #include <linux/types.h>
 
 extern struct atomic_notifier_head panic_notifier_list;
+extern struct atomic_notifier_head panic_hypervisor_list;
 
 extern bool crash_kexec_post_notifiers;
 
diff --git a/kernel/panic.c b/kernel/panic.c
index 523bc9ccd0e9..ef76f3f9c44d 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -73,6 +73,9 @@ ATOMIC_NOTIFIER_HEAD(panic_notifier_list);
 
 EXPORT_SYMBOL(panic_notifier_list);
 
+ATOMIC_NOTIFIER_HEAD(panic_hypervisor_list);
+EXPORT_SYMBOL(panic_hypervisor_list);
+
 static long no_blink(int state)
 {
 	return 0;
@@ -287,6 +290,7 @@ void panic(const char *fmt, ...)
 	 * Run any panic handlers, including those that might need to
 	 * add information to the kmsg dump output.
 	 */
+	atomic_notifier_call_chain(&panic_hypervisor_list, PANIC_NOTIFIER, buf);
 	atomic_notifier_call_chain(&panic_notifier_list, PANIC_NOTIFIER, buf);
 
 	panic_print_sys_info(false);
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315598.534376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgg-00043c-0y; Wed, 27 Apr 2022 23:03:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315598.534376; Wed, 27 Apr 2022 23:03:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqge-0003sT-GK; Wed, 27 Apr 2022 23:03:08 +0000
Received: by outflank-mailman (input) for mailman id 315598;
 Wed, 27 Apr 2022 22:55:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqZC-0003yk-Ve
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:55:27 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1fee46cd-c67d-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:55:25 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqYq-0002L8-2E; Thu, 28 Apr 2022 00:55:04 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fee46cd-c67d-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=bXh7kiTIu/oy8MX/xHxFfh1fd2A2HdpodNy0n7WfBok=; b=jgBsYcG7VatVMQNKfpmMmj+KDF
	XkWdsJfK09vZ2R11ym0rJsLvtM7L6jFVra/wKw7Ru20Q3tXdmM07YvLIKve3XUICHAOg3XVnWAPnC
	QEU9pWc8Syz13kCBbzgQspePXfSisAbL6GFs+m41GGaRoAAhFREDnjG2ZxSQpo/Uwz68hg3pu2x/D
	E6IkumXzatKpQWO5lYMxPl1yMWzmsX3DQC96acG0StwdG2kMOMr4xmOgeGsgOcdwakQdld1rcVf3a
	toHhgvuQnGWFi2MNPNWRfSUHfV6qkAGZNsEtUXlHsz/Hx27noavbMwYx8Z2d6rixzJUQIGNVx4tvy
	GymC5HQQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Leo Yan <leo.yan@linaro.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Mike Leach <mike.leach@linaro.org>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Neeraj Upadhyay <quic_neeraju@quicinc.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: [PATCH 20/30] panic: Add the panic informational notifier list
Date: Wed, 27 Apr 2022 19:49:14 -0300
Message-Id: <20220427224924.592546-21-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The goal of this new panic notifier is to allow its users to
register callbacks to run earlier in the panic path than they
currently do. This aims at informational mechanisms, like dumping
kernel offsets and showing device error data (in case it's simple
registers reading, for example) as well as mechanisms to disable
log flooding (like hung_task detector / RCU warnings) and the
tracing dump_on_oops (when enabled).

Any (non-invasive) information that should be provided before
kmsg_dump() as well as log flooding preventing code should fit
here, as long it offers relatively low risk for kdump.

For now, the patch is almost a no-op, although it changes a bit
the ordering in which some panic notifiers are executed - specially
affected by this are the notifiers responsible for disabling the
hung_task detector / RCU warnings, which now run first. In a
subsequent patch, the panic path will be refactored, then the
panic informational notifiers will effectively run earlier,
before ksmg_dump() (and usually before kdump as well).

We also defer documenting it all properly in the subsequent
refactor patch. Finally, while at it, we removed some useless
header inclusions too.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Frederic Weisbecker <frederic@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Hari Bathini <hbathini@linux.ibm.com>
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: Neeraj Upadhyay <quic_neeraju@quicinc.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/arm64/kernel/setup.c                         | 2 +-
 arch/mips/kernel/relocate.c                       | 2 +-
 arch/powerpc/kernel/setup-common.c                | 2 +-
 arch/x86/kernel/setup.c                           | 2 +-
 drivers/bus/brcmstb_gisb.c                        | 2 +-
 drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 ++--
 drivers/soc/tegra/ari-tegra186.c                  | 3 ++-
 include/linux/panic_notifier.h                    | 1 +
 kernel/hung_task.c                                | 3 ++-
 kernel/panic.c                                    | 4 ++++
 kernel/rcu/tree.c                                 | 1 -
 kernel/rcu/tree_stall.h                           | 3 ++-
 kernel/trace/trace.c                              | 2 +-
 13 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 3505789cf4bd..ac2c7e8c9c6a 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -444,7 +444,7 @@ static struct notifier_block arm64_panic_block = {
 
 static int __init register_arm64_panic_block(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_info_list,
 				       &arm64_panic_block);
 	return 0;
 }
diff --git a/arch/mips/kernel/relocate.c b/arch/mips/kernel/relocate.c
index 56b51de2dc51..650811f2436a 100644
--- a/arch/mips/kernel/relocate.c
+++ b/arch/mips/kernel/relocate.c
@@ -459,7 +459,7 @@ static struct notifier_block kernel_location_notifier = {
 
 static int __init register_kernel_offset_dumper(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_info_list,
 				       &kernel_location_notifier);
 	return 0;
 }
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 1468c3937bf4..d04b8bf8dbc7 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -757,7 +757,7 @@ void __init setup_panic(void)
 				       &ppc_fadump_block);
 
 	if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && kaslr_offset() > 0)
-		atomic_notifier_chain_register(&panic_notifier_list,
+		atomic_notifier_chain_register(&panic_info_list,
 					       &kernel_offset_notifier);
 
 	/* Low-level platform-specific routines that should run on panic */
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index c95b9ac5a457..599b25346964 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1266,7 +1266,7 @@ static struct notifier_block kernel_offset_notifier = {
 
 static int __init register_kernel_offset_dumper(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_info_list,
 					&kernel_offset_notifier);
 	return 0;
 }
diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
index 1ea7b015e225..c64e087fba7a 100644
--- a/drivers/bus/brcmstb_gisb.c
+++ b/drivers/bus/brcmstb_gisb.c
@@ -486,7 +486,7 @@ static int __init brcmstb_gisb_arb_probe(struct platform_device *pdev)
 
 	if (list_is_singular(&brcmstb_gisb_arb_device_list)) {
 		register_die_notifier(&gisb_die_notifier);
-		atomic_notifier_chain_register(&panic_notifier_list,
+		atomic_notifier_chain_register(&panic_info_list,
 					       &gisb_panic_notifier);
 	}
 
diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index 1874df7c6a73..7b1012454525 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -535,7 +535,7 @@ static int debug_func_init(void)
 			    &debug_func_knob_fops);
 
 	/* Register function to be called for panic */
-	ret = atomic_notifier_chain_register(&panic_notifier_list,
+	ret = atomic_notifier_chain_register(&panic_info_list,
 					     &debug_notifier);
 	if (ret) {
 		pr_err("%s: unable to register notifier: %d\n",
@@ -552,7 +552,7 @@ static int debug_func_init(void)
 
 static void debug_func_exit(void)
 {
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_info_list,
 					 &debug_notifier);
 	debugfs_remove_recursive(debug_debugfs_dir);
 }
diff --git a/drivers/soc/tegra/ari-tegra186.c b/drivers/soc/tegra/ari-tegra186.c
index 02577853ec49..4ef05ebed739 100644
--- a/drivers/soc/tegra/ari-tegra186.c
+++ b/drivers/soc/tegra/ari-tegra186.c
@@ -73,7 +73,8 @@ static struct notifier_block tegra186_ari_panic_nb = {
 static int __init tegra186_ari_init(void)
 {
 	if (of_machine_is_compatible("nvidia,tegra186"))
-		atomic_notifier_chain_register(&panic_notifier_list, &tegra186_ari_panic_nb);
+		atomic_notifier_chain_register(&panic_info_list,
+					       &tegra186_ari_panic_nb);
 
 	return 0;
 }
diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
index 0bb9dc0dea04..7364a346bcb0 100644
--- a/include/linux/panic_notifier.h
+++ b/include/linux/panic_notifier.h
@@ -7,6 +7,7 @@
 
 extern struct atomic_notifier_head panic_notifier_list;
 extern struct atomic_notifier_head panic_hypervisor_list;
+extern struct atomic_notifier_head panic_info_list;
 
 extern bool crash_kexec_post_notifiers;
 
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index 52501e5f7655..1b2d7111d5ac 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -85,6 +85,7 @@ hung_task_panic(struct notifier_block *this, unsigned long event, void *ptr)
 
 static struct notifier_block panic_block = {
 	.notifier_call = hung_task_panic,
+	.priority = INT_MAX, /* run early to prevent potential log flood */
 };
 
 static void check_hung_task(struct task_struct *t, unsigned long timeout)
@@ -378,7 +379,7 @@ static int watchdog(void *dummy)
 
 static int __init hung_task_init(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
+	atomic_notifier_chain_register(&panic_info_list, &panic_block);
 
 	/* Disable hung task detector on suspend */
 	pm_notifier(hungtask_pm_notify, 0);
diff --git a/kernel/panic.c b/kernel/panic.c
index ef76f3f9c44d..73ca1bc44e30 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -76,6 +76,9 @@ EXPORT_SYMBOL(panic_notifier_list);
 ATOMIC_NOTIFIER_HEAD(panic_hypervisor_list);
 EXPORT_SYMBOL(panic_hypervisor_list);
 
+ATOMIC_NOTIFIER_HEAD(panic_info_list);
+EXPORT_SYMBOL(panic_info_list);
+
 static long no_blink(int state)
 {
 	return 0;
@@ -291,6 +294,7 @@ void panic(const char *fmt, ...)
 	 * add information to the kmsg dump output.
 	 */
 	atomic_notifier_call_chain(&panic_hypervisor_list, PANIC_NOTIFIER, buf);
+	atomic_notifier_call_chain(&panic_info_list, PANIC_NOTIFIER, buf);
 	atomic_notifier_call_chain(&panic_notifier_list, PANIC_NOTIFIER, buf);
 
 	panic_print_sys_info(false);
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index a4b8189455d5..d5a2674ae81c 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -35,7 +35,6 @@
 #include <linux/panic.h>
 #include <linux/panic_notifier.h>
 #include <linux/percpu.h>
-#include <linux/notifier.h>
 #include <linux/cpu.h>
 #include <linux/mutex.h>
 #include <linux/time.h>
diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
index 0c5d8516516a..d8a5840aad5d 100644
--- a/kernel/rcu/tree_stall.h
+++ b/kernel/rcu/tree_stall.h
@@ -97,11 +97,12 @@ static int rcu_panic(struct notifier_block *this, unsigned long ev, void *ptr)
 
 static struct notifier_block rcu_panic_block = {
 	.notifier_call = rcu_panic,
+	.priority = INT_MAX, /* run early to prevent potential log flood */
 };
 
 static int __init check_cpu_stall_init(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list, &rcu_panic_block);
+	atomic_notifier_chain_register(&panic_info_list, &rcu_panic_block);
 	return 0;
 }
 early_initcall(check_cpu_stall_init);
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index c1d8a3622ccc..7d02f7a66bb1 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -10138,7 +10138,7 @@ __init static int tracer_alloc_buffers(void)
 	/* All seems OK, enable tracing */
 	tracing_disabled = 0;
 
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_info_list,
 				       &trace_panic_notifier);
 
 	register_die_notifier(&trace_die_notifier);
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315600.534385 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgh-0004bN-RU; Wed, 27 Apr 2022 23:03:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315600.534385; Wed, 27 Apr 2022 23:03:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgg-0004To-Mj; Wed, 27 Apr 2022 23:03:10 +0000
Received: by outflank-mailman (input) for mailman id 315600;
 Wed, 27 Apr 2022 22:55:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqZZ-00040Q-SS
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:55:49 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2c51f6b0-c67d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:55:47 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqZ3-0002M7-VZ; Thu, 28 Apr 2022 00:55:19 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c51f6b0-c67d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=UUXOjzoPDzZBxDSM8+K/LI8aYgpN2c+7zHoVbuhOqsQ=; b=GGfx5lsx2iN56x4Z6fieodmwsm
	q5qfqcY1rIx/L0anA1ZhdBtfQ+C+QCp0EQXWthQC9bhiRHlIzjMM6Fai8Z+t+xthEq/n/fGHRhca/
	t9Tdct8qfeyGi9778oHb6Zp3iyEA8AXWsWrvXe98bM5ZSZw4rYAVPyzYJKBGFZSDrdbdRw4ILVA7u
	KrQ45Y/jrJev8kEITG8FJSs6FiCCu2Z5s5Ob31DxZ15wgRyUmwlyCjKzYxUnHRGrORvmLbjL/1wFO
	iOOLnSiYgX9k/pD9XDR6G4JrDmutJFroQFiYtMUVMnYe6vm1fC5e6345ak3oNfUcNqnNarGdGEYIA
	SoanUEvg==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Alex Elder <elder@kernel.org>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Chris Zankel <chris@zankel.net>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Corey Minyard <minyard@acm.org>,
	Dexuan Cui <decui@microsoft.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Helge Deller <deller@gmx.de>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	James Morse <james.morse@arm.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Matt Turner <mattst88@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Pavel Machek <pavel@ucw.cz>,
	Richard Henderson <rth@twiddle.net>,
	Richard Weinberger <richard@nod.at>,
	Robert Richter <rric@kernel.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Tony Luck <tony.luck@intel.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Wei Liu <wei.liu@kernel.org>
Subject: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list
Date: Wed, 27 Apr 2022 19:49:15 -0300
Message-Id: <20220427224924.592546-22-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This patch renames the panic_notifier_list to panic_pre_reboot_list;
the idea is that a subsequent patch will refactor the panic path
in order to better split the notifiers, running some of them very
early, some of them not so early [but still before kmsg_dump()] and
finally, the rest should execute late, after kdump. The latter ones
are now in the panic pre-reboot list - the name comes from the idea
that these notifiers execute before panic() attempts rebooting the
machine (if that option is set).

We also took the opportunity to clean-up useless header inclusions,
improve some notifier block declarations (e.g. in ibmasm/heartbeat.c)
and more important, change some priorities - we hereby set 2 notifiers
to run late in the list [iss_panic_event() and the IPMI panic_event()]
due to the risks they offer (may not return, for example).
Proper documentation is going to be provided in a subsequent patch,
that effectively refactors the panic path.

Cc: Alex Elder <elder@kernel.org>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Corey Minyard <minyard@acm.org>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Helge Deller <deller@gmx.de>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: James Morse <james.morse@arm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Juergen Gross <jgross@suse.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Richard Weinberger <richard@nod.at>
Cc: Robert Richter <rric@kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

Notice that, with this name change, out-of-tree code that relies in the global
exported "panic_notifier_list" will fail to build. We could easily keep the
retro-compatibility by making the old symbol to still exist and point to the
pre_reboot list (or even, keep the old naming).

But our design choice was to allow the breakage, making users rethink their
notifiers, adding them in the list that fits best. If that wasn't a good
decision, we're open to change it, of course.
Thanks in advance for the review!

 arch/alpha/kernel/setup.c             |  4 ++--
 arch/parisc/kernel/pdc_chassis.c      |  3 +--
 arch/powerpc/kernel/setup-common.c    |  2 +-
 arch/s390/kernel/ipl.c                |  4 ++--
 arch/um/drivers/mconsole_kern.c       |  2 +-
 arch/um/kernel/um_arch.c              |  2 +-
 arch/x86/xen/enlighten.c              |  2 +-
 arch/xtensa/platforms/iss/setup.c     |  4 ++--
 drivers/char/ipmi/ipmi_msghandler.c   | 12 +++++++-----
 drivers/edac/altera_edac.c            |  3 +--
 drivers/hv/vmbus_drv.c                |  4 ++--
 drivers/leds/trigger/ledtrig-panic.c  |  3 +--
 drivers/misc/ibmasm/heartbeat.c       | 16 +++++++++-------
 drivers/net/ipa/ipa_smp2p.c           |  5 ++---
 drivers/parisc/power.c                |  4 ++--
 drivers/remoteproc/remoteproc_core.c  |  6 ++++--
 drivers/s390/char/con3215.c           |  2 +-
 drivers/s390/char/con3270.c           |  2 +-
 drivers/s390/char/sclp_con.c          |  2 +-
 drivers/s390/char/sclp_vt220.c        |  2 +-
 drivers/staging/olpc_dcon/olpc_dcon.c |  6 ++++--
 drivers/video/fbdev/hyperv_fb.c       |  4 ++--
 include/linux/panic_notifier.h        |  2 +-
 kernel/panic.c                        |  9 ++++-----
 24 files changed, 54 insertions(+), 51 deletions(-)

diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c
index d88bdf852753..8ace0d7113b6 100644
--- a/arch/alpha/kernel/setup.c
+++ b/arch/alpha/kernel/setup.c
@@ -472,8 +472,8 @@ setup_arch(char **cmdline_p)
 	}
 
 	/* Register a call for panic conditions. */
-	atomic_notifier_chain_register(&panic_notifier_list,
-			&alpha_panic_block);
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
+					&alpha_panic_block);
 
 #ifndef alpha_using_srm
 	/* Assume that we've booted from SRM if we haven't booted from MILO.
diff --git a/arch/parisc/kernel/pdc_chassis.c b/arch/parisc/kernel/pdc_chassis.c
index da154406d368..0fd8d87fb4f9 100644
--- a/arch/parisc/kernel/pdc_chassis.c
+++ b/arch/parisc/kernel/pdc_chassis.c
@@ -22,7 +22,6 @@
 #include <linux/kernel.h>
 #include <linux/panic_notifier.h>
 #include <linux/reboot.h>
-#include <linux/notifier.h>
 #include <linux/cache.h>
 #include <linux/proc_fs.h>
 #include <linux/seq_file.h>
@@ -135,7 +134,7 @@ void __init parisc_pdc_chassis_init(void)
 				PDC_CHASSIS_VER);
 
 		/* initialize panic notifier chain */
-		atomic_notifier_chain_register(&panic_notifier_list,
+		atomic_notifier_chain_register(&panic_pre_reboot_list,
 				&pdc_chassis_panic_block);
 
 		/* initialize reboot notifier chain */
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index d04b8bf8dbc7..3518bebc10ad 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -762,7 +762,7 @@ void __init setup_panic(void)
 
 	/* Low-level platform-specific routines that should run on panic */
 	if (ppc_md.panic)
-		atomic_notifier_chain_register(&panic_notifier_list,
+		atomic_notifier_chain_register(&panic_pre_reboot_list,
 					       &ppc_panic_block);
 }
 
diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c
index 1cc85b8ff42e..4a88c5bb6e15 100644
--- a/arch/s390/kernel/ipl.c
+++ b/arch/s390/kernel/ipl.c
@@ -2034,7 +2034,7 @@ static int on_panic_notify(struct notifier_block *self,
 			   unsigned long event, void *data)
 {
 	do_panic();
-	return NOTIFY_OK;
+	return NOTIFY_DONE;
 }
 
 static struct notifier_block on_panic_nb = {
@@ -2069,7 +2069,7 @@ void __init setup_ipl(void)
 		/* We have no info to copy */
 		break;
 	}
-	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
+	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
 }
 
 void s390_reset_system(void)
diff --git a/arch/um/drivers/mconsole_kern.c b/arch/um/drivers/mconsole_kern.c
index 2ea0421bcc3f..21c13b4e24a3 100644
--- a/arch/um/drivers/mconsole_kern.c
+++ b/arch/um/drivers/mconsole_kern.c
@@ -855,7 +855,7 @@ static struct notifier_block panic_exit_notifier = {
 
 static int add_notifier(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
 			&panic_exit_notifier);
 	return 0;
 }
diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index 4485b1a7c8e4..fc6e443299da 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -257,7 +257,7 @@ static struct notifier_block panic_exit_notifier = {
 
 void uml_finishsetup(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
 				       &panic_exit_notifier);
 
 	uml_postsetup();
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 30c6e986a6cd..d4f4de239a21 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -290,7 +290,7 @@ static struct notifier_block xen_panic_block = {
 
 int xen_panic_handler_init(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list, &xen_panic_block);
+	atomic_notifier_chain_register(&panic_pre_reboot_list, &xen_panic_block);
 	return 0;
 }
 
diff --git a/arch/xtensa/platforms/iss/setup.c b/arch/xtensa/platforms/iss/setup.c
index d3433e1bb94e..eeeeb6cff6bd 100644
--- a/arch/xtensa/platforms/iss/setup.c
+++ b/arch/xtensa/platforms/iss/setup.c
@@ -13,7 +13,6 @@
  */
 #include <linux/init.h>
 #include <linux/kernel.h>
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include <linux/printk.h>
 #include <linux/string.h>
@@ -53,6 +52,7 @@ iss_panic_event(struct notifier_block *this, unsigned long event, void *ptr)
 
 static struct notifier_block iss_panic_block = {
 	.notifier_call = iss_panic_event,
+	.priority = INT_MIN, /* run as late as possible, may not return */
 };
 
 void __init platform_setup(char **p_cmdline)
@@ -81,5 +81,5 @@ void __init platform_setup(char **p_cmdline)
 		}
 	}
 
-	atomic_notifier_chain_register(&panic_notifier_list, &iss_panic_block);
+	atomic_notifier_chain_register(&panic_pre_reboot_list, &iss_panic_block);
 }
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index c59265146e9c..6c4770949c01 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -25,7 +25,6 @@
 #include <linux/slab.h>
 #include <linux/ipmi.h>
 #include <linux/ipmi_smi.h>
-#include <linux/notifier.h>
 #include <linux/init.h>
 #include <linux/proc_fs.h>
 #include <linux/rcupdate.h>
@@ -5375,10 +5374,13 @@ static int ipmi_register_driver(void)
 	return rv;
 }
 
+/*
+ * we should execute this panic callback late, since it involves
+ * a complex call-chain and panic() runs in atomic context.
+ */
 static struct notifier_block panic_block = {
 	.notifier_call	= panic_event,
-	.next		= NULL,
-	.priority	= 200	/* priority: INT_MAX >= x >= 0 */
+	.priority	= INT_MIN + 1,
 };
 
 static int ipmi_init_msghandler(void)
@@ -5406,7 +5408,7 @@ static int ipmi_init_msghandler(void)
 	timer_setup(&ipmi_timer, ipmi_timeout, 0);
 	mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES);
 
-	atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
+	atomic_notifier_chain_register(&panic_pre_reboot_list, &panic_block);
 
 	initialized = true;
 
@@ -5438,7 +5440,7 @@ static void __exit cleanup_ipmi(void)
 	if (initialized) {
 		destroy_workqueue(remove_work_wq);
 
-		atomic_notifier_chain_unregister(&panic_notifier_list,
+		atomic_notifier_chain_unregister(&panic_pre_reboot_list,
 						 &panic_block);
 
 		/*
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index e7e8e624a436..4890e9cba6fb 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -16,7 +16,6 @@
 #include <linux/kernel.h>
 #include <linux/mfd/altera-sysmgr.h>
 #include <linux/mfd/syscon.h>
-#include <linux/notifier.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <linux/of_platform.h>
@@ -2163,7 +2162,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
 		int dberror, err_addr;
 
 		edac->panic_notifier.notifier_call = s10_edac_dberr_handler;
-		atomic_notifier_chain_register(&panic_notifier_list,
+		atomic_notifier_chain_register(&panic_pre_reboot_list,
 					       &edac->panic_notifier);
 
 		/* Printout a message if uncorrectable error previously. */
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 901b97034308..3717c323aa36 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1622,7 +1622,7 @@ static int vmbus_bus_init(void)
 	 * Always register the vmbus unload panic notifier because we
 	 * need to shut the VMbus channel connection on panic.
 	 */
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
 			       &hyperv_panic_vmbus_unload_block);
 
 	vmbus_request_offers();
@@ -2851,7 +2851,7 @@ static void __exit vmbus_exit(void)
 	 * The vmbus panic notifier is always registered, hence we should
 	 * also unconditionally unregister it here as well.
 	 */
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
 					&hyperv_panic_vmbus_unload_block);
 
 	free_page((unsigned long)hv_panic_page);
diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c
index 64abf2e91608..34fd5170723f 100644
--- a/drivers/leds/trigger/ledtrig-panic.c
+++ b/drivers/leds/trigger/ledtrig-panic.c
@@ -7,7 +7,6 @@
 
 #include <linux/kernel.h>
 #include <linux/init.h>
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include <linux/leds.h>
 #include "../leds.h"
@@ -64,7 +63,7 @@ static long led_panic_blink(int state)
 
 static int __init ledtrig_panic_init(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
 				       &led_trigger_panic_nb);
 
 	led_trigger_register_simple("panic", &trigger);
diff --git a/drivers/misc/ibmasm/heartbeat.c b/drivers/misc/ibmasm/heartbeat.c
index 59c9a0d95659..d6acae88b722 100644
--- a/drivers/misc/ibmasm/heartbeat.c
+++ b/drivers/misc/ibmasm/heartbeat.c
@@ -8,7 +8,6 @@
  * Author: Max Asböck <amax@us.ibm.com>
  */
 
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include "ibmasm.h"
 #include "dot_command.h"
@@ -24,7 +23,7 @@ static int suspend_heartbeats = 0;
  * In the case of a panic the interrupt handler continues to work and thus
  * continues to respond to heartbeats, making the service processor believe
  * the OS is still running and thus preventing a reboot.
- * To prevent this from happening a callback is added the panic_notifier_list.
+ * To prevent this from happening a callback is added in a panic notifier list.
  * Before responding to a heartbeat the driver checks if a panic has happened,
  * if yes it suspends heartbeat, causing the service processor to reboot as
  * expected.
@@ -32,20 +31,23 @@ static int suspend_heartbeats = 0;
 static int panic_happened(struct notifier_block *n, unsigned long val, void *v)
 {
 	suspend_heartbeats = 1;
-	return 0;
+	return NOTIFY_DONE;
 }
 
-static struct notifier_block panic_notifier = { panic_happened, NULL, 1 };
+static struct notifier_block panic_notifier = {
+	.notifier_call = panic_happened,
+};
 
 void ibmasm_register_panic_notifier(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list, &panic_notifier);
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
+					&panic_notifier);
 }
 
 void ibmasm_unregister_panic_notifier(void)
 {
-	atomic_notifier_chain_unregister(&panic_notifier_list,
-			&panic_notifier);
+	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
+					&panic_notifier);
 }
 
 
diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
index 211233612039..92cdf6e0637c 100644
--- a/drivers/net/ipa/ipa_smp2p.c
+++ b/drivers/net/ipa/ipa_smp2p.c
@@ -7,7 +7,6 @@
 #include <linux/types.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
-#include <linux/notifier.h>
 #include <linux/panic_notifier.h>
 #include <linux/pm_runtime.h>
 #include <linux/soc/qcom/smem.h>
@@ -138,13 +137,13 @@ static int ipa_smp2p_panic_notifier_register(struct ipa_smp2p *smp2p)
 	smp2p->panic_notifier.notifier_call = ipa_smp2p_panic_notifier;
 	smp2p->panic_notifier.priority = INT_MAX;	/* Do it early */
 
-	return atomic_notifier_chain_register(&panic_notifier_list,
+	return atomic_notifier_chain_register(&panic_pre_reboot_list,
 					      &smp2p->panic_notifier);
 }
 
 static void ipa_smp2p_panic_notifier_unregister(struct ipa_smp2p *smp2p)
 {
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
 					 &smp2p->panic_notifier);
 }
 
diff --git a/drivers/parisc/power.c b/drivers/parisc/power.c
index 8512884de2cf..5bb0868f5f08 100644
--- a/drivers/parisc/power.c
+++ b/drivers/parisc/power.c
@@ -233,7 +233,7 @@ static int __init power_init(void)
 	}
 
 	/* Register a call for panic conditions. */
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
 			&parisc_panic_block);
 
 	return 0;
@@ -243,7 +243,7 @@ static void __exit power_exit(void)
 {
 	kthread_stop(power_task);
 
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
 			&parisc_panic_block);
 
 	pdc_soft_power_button(0);
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index c510125769b9..24799ff239e6 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -2795,12 +2795,14 @@ static int rproc_panic_handler(struct notifier_block *nb, unsigned long event,
 static void __init rproc_init_panic(void)
 {
 	rproc_panic_nb.notifier_call = rproc_panic_handler;
-	atomic_notifier_chain_register(&panic_notifier_list, &rproc_panic_nb);
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
+				       &rproc_panic_nb);
 }
 
 static void __exit rproc_exit_panic(void)
 {
-	atomic_notifier_chain_unregister(&panic_notifier_list, &rproc_panic_nb);
+	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
+					 &rproc_panic_nb);
 }
 
 static int __init remoteproc_init(void)
diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
index 192198bd3dc4..07379dd3f1f3 100644
--- a/drivers/s390/char/con3215.c
+++ b/drivers/s390/char/con3215.c
@@ -867,7 +867,7 @@ static int __init con3215_init(void)
 		raw3215[0] = NULL;
 		return -ENODEV;
 	}
-	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
+	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
 	register_reboot_notifier(&on_reboot_nb);
 	register_console(&con3215);
 	return 0;
diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
index 476202f3d8a0..e79bf3e7bde3 100644
--- a/drivers/s390/char/con3270.c
+++ b/drivers/s390/char/con3270.c
@@ -645,7 +645,7 @@ con3270_init(void)
 	condev->cline->len = 0;
 	con3270_create_status(condev);
 	condev->input = alloc_string(&condev->freemem, 80);
-	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
+	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
 	register_reboot_notifier(&on_reboot_nb);
 	register_console(&con3270);
 	return 0;
diff --git a/drivers/s390/char/sclp_con.c b/drivers/s390/char/sclp_con.c
index e5d947c763ea..7ca9d4c45d60 100644
--- a/drivers/s390/char/sclp_con.c
+++ b/drivers/s390/char/sclp_con.c
@@ -288,7 +288,7 @@ sclp_console_init(void)
 	timer_setup(&sclp_con_timer, sclp_console_timeout, 0);
 
 	/* enable printk-access to this driver */
-	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
+	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
 	register_reboot_notifier(&on_reboot_nb);
 	register_console(&sclp_console);
 	return 0;
diff --git a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
index a32f34a1c6d2..97cf9e290c28 100644
--- a/drivers/s390/char/sclp_vt220.c
+++ b/drivers/s390/char/sclp_vt220.c
@@ -838,7 +838,7 @@ sclp_vt220_con_init(void)
 	if (rc)
 		return rc;
 	/* Attach linux console */
-	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
+	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
 	register_reboot_notifier(&on_reboot_nb);
 	register_console(&sclp_vt220_console);
 	return 0;
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index 7284cb4ac395..cb50471f2246 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -653,7 +653,8 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	}
 
 	register_reboot_notifier(&dcon->reboot_nb);
-	atomic_notifier_chain_register(&panic_notifier_list, &dcon_panic_nb);
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
+				       &dcon_panic_nb);
 
 	return 0;
 
@@ -676,7 +677,8 @@ static int dcon_remove(struct i2c_client *client)
 	struct dcon_priv *dcon = i2c_get_clientdata(client);
 
 	unregister_reboot_notifier(&dcon->reboot_nb);
-	atomic_notifier_chain_unregister(&panic_notifier_list, &dcon_panic_nb);
+	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
+					 &dcon_panic_nb);
 
 	free_irq(DCON_IRQ, dcon);
 
diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
index f3494b868a64..ec21e63592be 100644
--- a/drivers/video/fbdev/hyperv_fb.c
+++ b/drivers/video/fbdev/hyperv_fb.c
@@ -1253,7 +1253,7 @@ static int hvfb_probe(struct hv_device *hdev,
 	 */
 	par->hvfb_panic_nb.notifier_call = hvfb_on_panic;
 	par->hvfb_panic_nb.priority = INT_MIN + 10,
-	atomic_notifier_chain_register(&panic_notifier_list,
+	atomic_notifier_chain_register(&panic_pre_reboot_list,
 				       &par->hvfb_panic_nb);
 
 	return 0;
@@ -1276,7 +1276,7 @@ static int hvfb_remove(struct hv_device *hdev)
 	struct fb_info *info = hv_get_drvdata(hdev);
 	struct hvfb_par *par = info->par;
 
-	atomic_notifier_chain_unregister(&panic_notifier_list,
+	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
 					 &par->hvfb_panic_nb);
 
 	par->update = false;
diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
index 7364a346bcb0..7912aacbc0e5 100644
--- a/include/linux/panic_notifier.h
+++ b/include/linux/panic_notifier.h
@@ -5,9 +5,9 @@
 #include <linux/notifier.h>
 #include <linux/types.h>
 
-extern struct atomic_notifier_head panic_notifier_list;
 extern struct atomic_notifier_head panic_hypervisor_list;
 extern struct atomic_notifier_head panic_info_list;
+extern struct atomic_notifier_head panic_pre_reboot_list;
 
 extern bool crash_kexec_post_notifiers;
 
diff --git a/kernel/panic.c b/kernel/panic.c
index 73ca1bc44e30..a9d43b98b05b 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -69,16 +69,15 @@ EXPORT_SYMBOL_GPL(panic_timeout);
 #define PANIC_PRINT_ALL_CPU_BT		0x00000040
 unsigned long panic_print;
 
-ATOMIC_NOTIFIER_HEAD(panic_notifier_list);
-
-EXPORT_SYMBOL(panic_notifier_list);
-
 ATOMIC_NOTIFIER_HEAD(panic_hypervisor_list);
 EXPORT_SYMBOL(panic_hypervisor_list);
 
 ATOMIC_NOTIFIER_HEAD(panic_info_list);
 EXPORT_SYMBOL(panic_info_list);
 
+ATOMIC_NOTIFIER_HEAD(panic_pre_reboot_list);
+EXPORT_SYMBOL(panic_pre_reboot_list);
+
 static long no_blink(int state)
 {
 	return 0;
@@ -295,7 +294,7 @@ void panic(const char *fmt, ...)
 	 */
 	atomic_notifier_call_chain(&panic_hypervisor_list, PANIC_NOTIFIER, buf);
 	atomic_notifier_call_chain(&panic_info_list, PANIC_NOTIFIER, buf);
-	atomic_notifier_call_chain(&panic_notifier_list, PANIC_NOTIFIER, buf);
+	atomic_notifier_call_chain(&panic_pre_reboot_list, PANIC_NOTIFIER, buf);
 
 	panic_print_sys_info(false);
 
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315602.534395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgj-00055P-DT; Wed, 27 Apr 2022 23:03:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315602.534395; Wed, 27 Apr 2022 23:03:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgi-0004vu-9Q; Wed, 27 Apr 2022 23:03:12 +0000
Received: by outflank-mailman (input) for mailman id 315602;
 Wed, 27 Apr 2022 22:56:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqZo-00040Q-C9
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:56:04 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3651e992-c67d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:56:03 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqZZ-0002Nv-Ix; Thu, 28 Apr 2022 00:55:50 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3651e992-c67d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=VYrOPrqDKiFUsTfjme0J+bb1QZ+0oMPMNlfIlQcQCIU=; b=esIQjYNUmn8XOAMCY8KOPnZ+c+
	YZlzZFZJpud7l5aihfe1Itrd6ZZ98nnyy8UW1vOI1POK9zaRsPqoo2RhL4mEx84eRCHYefMesX5mG
	VJrQ0svjjO9G7VgOzDpcDLV/ntiz5AJExQTPCtbTdt7JFiAMS9guj375T3WC2+gnc5gFYq3Gv7f9R
	ZGEBpB02C9AAgh+86UxcqyV3yEw/FrOPinej5D7IeCAr0QV77wv10T31rCvUIuA1DrjRAh9qz2P38
	INNgxs5Kiy35sxcHJ/zXmQv2S2dVW6xiWlXVQ/tXuVpNtfQbdJCWgDKWsqK11QKSPuRppT31lgGJ9
	pH1ZqjsQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	Heiko Carstens <hca@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>
Subject: [PATCH 22/30] panic: Introduce the panic post-reboot notifier list
Date: Wed, 27 Apr 2022 19:49:16 -0300
Message-Id: <20220427224924.592546-23-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently we have 3 notifier lists in the panic path, which will
be wired in a way to allow the notifier callbacks to run in
different moments at panic time, in a subsequent patch.

But there is also an odd set of architecture calls hardcoded in
the end of panic path, after the restart machinery. They're
responsible for late time tunings / events, like enabling a stop
button (Sparc) or effectively stopping the machine (s390).

This patch introduces yet another notifier list to offer the
architectures a way to add callbacks in such late moment on
panic path without the need of ifdefs / hardcoded approaches.

Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/s390/kernel/setup.c       | 19 ++++++++++++++++++-
 arch/sparc/kernel/setup_32.c   | 27 +++++++++++++++++++++++----
 arch/sparc/kernel/setup_64.c   | 29 ++++++++++++++++++++++++-----
 include/linux/panic_notifier.h |  1 +
 kernel/panic.c                 | 19 +++++++------------
 5 files changed, 73 insertions(+), 22 deletions(-)

diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c
index d860ac300919..d816b2045f1e 100644
--- a/arch/s390/kernel/setup.c
+++ b/arch/s390/kernel/setup.c
@@ -39,7 +39,6 @@
 #include <linux/kernel_stat.h>
 #include <linux/dma-map-ops.h>
 #include <linux/device.h>
-#include <linux/notifier.h>
 #include <linux/pfn.h>
 #include <linux/ctype.h>
 #include <linux/reboot.h>
@@ -51,6 +50,7 @@
 #include <linux/start_kernel.h>
 #include <linux/hugetlb.h>
 #include <linux/kmemleak.h>
+#include <linux/panic_notifier.h>
 
 #include <asm/boot_data.h>
 #include <asm/ipl.h>
@@ -943,6 +943,20 @@ static void __init log_component_list(void)
 	}
 }
 
+/*
+ * The following notifier executes as one of the latest things in the panic
+ * path, only if the restart routines weren't executed (or didn't succeed).
+ */
+static int panic_event(struct notifier_block *n, unsigned long ev, void *unused)
+{
+	disabled_wait();
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block post_reboot_panic_block = {
+	.notifier_call = panic_event,
+};
+
 /*
  * Setup function called from init/main.c just after the banner
  * was printed.
@@ -1058,4 +1072,7 @@ void __init setup_arch(char **cmdline_p)
 
 	/* Add system specific data to the random pool */
 	setup_randomness();
+
+	atomic_notifier_chain_register(&panic_post_reboot_list,
+				       &post_reboot_panic_block);
 }
diff --git a/arch/sparc/kernel/setup_32.c b/arch/sparc/kernel/setup_32.c
index c8e0dd99f370..4e2428972f76 100644
--- a/arch/sparc/kernel/setup_32.c
+++ b/arch/sparc/kernel/setup_32.c
@@ -34,6 +34,7 @@
 #include <linux/kdebug.h>
 #include <linux/export.h>
 #include <linux/start_kernel.h>
+#include <linux/panic_notifier.h>
 #include <uapi/linux/mount.h>
 
 #include <asm/io.h>
@@ -51,6 +52,7 @@
 
 #include "kernel.h"
 
+int stop_a_enabled = 1;
 struct screen_info screen_info = {
 	0, 0,			/* orig-x, orig-y */
 	0,			/* unused */
@@ -293,6 +295,24 @@ void __init sparc32_start_kernel(struct linux_romvec *rp)
 	start_kernel();
 }
 
+/*
+ * The following notifier executes as one of the latest things in the panic
+ * path, only if the restart routines weren't executed (or didn't succeed).
+ */
+static int panic_event(struct notifier_block *n, unsigned long ev, void *unused)
+{
+	/* Make sure the user can actually press Stop-A (L1-A) */
+	stop_a_enabled = 1;
+	pr_emerg("Press Stop-A (L1-A) from sun keyboard or send break\n"
+		"twice on console to return to the boot prom\n");
+
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block post_reboot_panic_block = {
+	.notifier_call = panic_event,
+};
+
 void __init setup_arch(char **cmdline_p)
 {
 	int i;
@@ -368,9 +388,10 @@ void __init setup_arch(char **cmdline_p)
 	paging_init();
 
 	smp_setup_cpu_possible_map();
-}
 
-extern int stop_a_enabled;
+	atomic_notifier_chain_register(&panic_post_reboot_list,
+				       &post_reboot_panic_block);
+}
 
 void sun_do_break(void)
 {
@@ -384,8 +405,6 @@ void sun_do_break(void)
 }
 EXPORT_SYMBOL(sun_do_break);
 
-int stop_a_enabled = 1;
-
 static int __init topology_init(void)
 {
 	int i, ncpus, err;
diff --git a/arch/sparc/kernel/setup_64.c b/arch/sparc/kernel/setup_64.c
index 48abee4eee29..9066c25ecc07 100644
--- a/arch/sparc/kernel/setup_64.c
+++ b/arch/sparc/kernel/setup_64.c
@@ -33,6 +33,7 @@
 #include <linux/module.h>
 #include <linux/start_kernel.h>
 #include <linux/memblock.h>
+#include <linux/panic_notifier.h>
 #include <uapi/linux/mount.h>
 
 #include <asm/io.h>
@@ -62,6 +63,8 @@
 #include "entry.h"
 #include "kernel.h"
 
+int stop_a_enabled = 1;
+
 /* Used to synchronize accesses to NatSemi SUPER I/O chip configure
  * operations in asm/ns87303.h
  */
@@ -632,6 +635,24 @@ void __init alloc_irqstack_bootmem(void)
 	}
 }
 
+/*
+ * The following notifier executes as one of the latest things in the panic
+ * path, only if the restart routines weren't executed (or didn't succeed).
+ */
+static int panic_event(struct notifier_block *n, unsigned long ev, void *unused)
+{
+	/* Make sure the user can actually press Stop-A (L1-A) */
+	stop_a_enabled = 1;
+	pr_emerg("Press Stop-A (L1-A) from sun keyboard or send break\n"
+		"twice on console to return to the boot prom\n");
+
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block post_reboot_panic_block = {
+	.notifier_call = panic_event,
+};
+
 void __init setup_arch(char **cmdline_p)
 {
 	/* Initialize PROM console and command line. */
@@ -691,9 +712,10 @@ void __init setup_arch(char **cmdline_p)
 	 * allocate the IRQ stacks.
 	 */
 	alloc_irqstack_bootmem();
-}
 
-extern int stop_a_enabled;
+	atomic_notifier_chain_register(&panic_post_reboot_list,
+				       &post_reboot_panic_block);
+}
 
 void sun_do_break(void)
 {
@@ -706,6 +728,3 @@ void sun_do_break(void)
 	prom_cmdline();
 }
 EXPORT_SYMBOL(sun_do_break);
-
-int stop_a_enabled = 1;
-EXPORT_SYMBOL(stop_a_enabled);
diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
index 7912aacbc0e5..bcf6a5ea9d7f 100644
--- a/include/linux/panic_notifier.h
+++ b/include/linux/panic_notifier.h
@@ -8,6 +8,7 @@
 extern struct atomic_notifier_head panic_hypervisor_list;
 extern struct atomic_notifier_head panic_info_list;
 extern struct atomic_notifier_head panic_pre_reboot_list;
+extern struct atomic_notifier_head panic_post_reboot_list;
 
 extern bool crash_kexec_post_notifiers;
 
diff --git a/kernel/panic.c b/kernel/panic.c
index a9d43b98b05b..bf792102b43e 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -78,6 +78,9 @@ EXPORT_SYMBOL(panic_info_list);
 ATOMIC_NOTIFIER_HEAD(panic_pre_reboot_list);
 EXPORT_SYMBOL(panic_pre_reboot_list);
 
+ATOMIC_NOTIFIER_HEAD(panic_post_reboot_list);
+EXPORT_SYMBOL(panic_post_reboot_list);
+
 static long no_blink(int state)
 {
 	return 0;
@@ -359,18 +362,10 @@ void panic(const char *fmt, ...)
 			reboot_mode = panic_reboot_mode;
 		emergency_restart();
 	}
-#ifdef __sparc__
-	{
-		extern int stop_a_enabled;
-		/* Make sure the user can actually press Stop-A (L1-A) */
-		stop_a_enabled = 1;
-		pr_emerg("Press Stop-A (L1-A) from sun keyboard or send break\n"
-			 "twice on console to return to the boot prom\n");
-	}
-#endif
-#if defined(CONFIG_S390)
-	disabled_wait();
-#endif
+
+	atomic_notifier_call_chain(&panic_post_reboot_list,
+				   PANIC_NOTIFIER, buf);
+
 	pr_emerg("---[ end Kernel panic - not syncing: %s ]---\n", buf);
 
 	/* Do not scroll important messages printed above */
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315604.534411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgl-0005YM-Sc; Wed, 27 Apr 2022 23:03:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315604.534411; Wed, 27 Apr 2022 23:03:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgk-0005Qs-6m; Wed, 27 Apr 2022 23:03:14 +0000
Received: by outflank-mailman (input) for mailman id 315604;
 Wed, 27 Apr 2022 22:56:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqa1-00040Q-Tl
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:56:18 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e8fd615-c67d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:56:17 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqZo-0002Om-0k; Thu, 28 Apr 2022 00:56:04 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e8fd615-c67d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=durrkKWmzUfzH9qHOG14tQL4R8NCjUjLsTL3Zd00Gek=; b=My7iXYZdsvmohLkJmMGImfYof2
	p5qkpSJIhXISH+Sbyoj7EeJcOzhmrD5DtjdC6ethktkBlGYO4OfumrpixOUOKLn0Yc0W3TzG54aQY
	qwtzEOPADTIziH/itInY9Ffg69Sdqh65llZVZNXQlNolBLE2NFdio5E/kUq6oVXX/i2DBK4KweBxr
	JYm/gjauE4ZVcDNk28sbO0j6B73HXBblZWGmkswBaL+iIGNqLKObr06z5uxWmvVGTIOTQmQ/deHWL
	LutJobNbiLmganjaFUa+PvHzE64AyIeADEi0jWz8oHx43nzynoDLyNtzoi4XrtuDHAtIno5r39V8q
	Qw3pgkkw==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org
Subject: [PATCH 23/30] printk: kmsg_dump: Introduce helper to inform number of dumpers
Date: Wed, 27 Apr 2022 19:49:17 -0300
Message-Id: <20220427224924.592546-24-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently we don't have a way to check if there are dumpers set,
except counting the list members maybe. This patch introduces a very
simple helper to provide this information, by just keeping track of
registered/unregistered kmsg dumpers. It's going to be used on the
panic path in the subsequent patch.

Notice that the spinlock guarding kmsg_dumpers list also guards
increment/decrement of the dumper's counter, but there's no need
for that when reading the counter in the panic path, since that is
an atomic path and there's no other (planned) user.

Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 include/linux/kmsg_dump.h |  7 +++++++
 kernel/printk/printk.c    | 14 ++++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/include/linux/kmsg_dump.h b/include/linux/kmsg_dump.h
index 906521c2329c..abea1974bff8 100644
--- a/include/linux/kmsg_dump.h
+++ b/include/linux/kmsg_dump.h
@@ -65,6 +65,8 @@ bool kmsg_dump_get_buffer(struct kmsg_dump_iter *iter, bool syslog,
 
 void kmsg_dump_rewind(struct kmsg_dump_iter *iter);
 
+bool kmsg_has_dumpers(void);
+
 int kmsg_dump_register(struct kmsg_dumper *dumper);
 
 int kmsg_dump_unregister(struct kmsg_dumper *dumper);
@@ -91,6 +93,11 @@ static inline void kmsg_dump_rewind(struct kmsg_dump_iter *iter)
 {
 }
 
+static inline bool kmsg_has_dumpers(void)
+{
+	return false;
+}
+
 static inline int kmsg_dump_register(struct kmsg_dumper *dumper)
 {
 	return -EINVAL;
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index da03c15ecc89..e3a1c429fbbc 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -3399,6 +3399,18 @@ EXPORT_SYMBOL(printk_timed_ratelimit);
 
 static DEFINE_SPINLOCK(dump_list_lock);
 static LIST_HEAD(dump_list);
+static int num_dumpers;
+
+/**
+ * kmsg_has_dumpers - inform if there is any kmsg dumper registered.
+ *
+ * Returns true if there's at least one registered dumper, or false
+ * if otherwise.
+ */
+bool kmsg_has_dumpers(void)
+{
+	return num_dumpers ? true : false;
+}
 
 /**
  * kmsg_dump_register - register a kernel log dumper.
@@ -3423,6 +3435,7 @@ int kmsg_dump_register(struct kmsg_dumper *dumper)
 		dumper->registered = 1;
 		list_add_tail_rcu(&dumper->list, &dump_list);
 		err = 0;
+		num_dumpers++;
 	}
 	spin_unlock_irqrestore(&dump_list_lock, flags);
 
@@ -3447,6 +3460,7 @@ int kmsg_dump_unregister(struct kmsg_dumper *dumper)
 		dumper->registered = 0;
 		list_del_rcu(&dumper->list);
 		err = 0;
+		num_dumpers--;
 	}
 	spin_unlock_irqrestore(&dump_list_lock, flags);
 	synchronize_rcu();
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315606.534420 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgo-00067E-EJ; Wed, 27 Apr 2022 23:03:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315606.534420; Wed, 27 Apr 2022 23:03:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgm-0005xz-FI; Wed, 27 Apr 2022 23:03:16 +0000
Received: by outflank-mailman (input) for mailman id 315606;
 Wed, 27 Apr 2022 22:56:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqaJ-00040Q-Q4
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:56:36 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 487ea9ed-c67d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:56:33 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqa3-0002Pf-2B; Thu, 28 Apr 2022 00:56:20 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 487ea9ed-c67d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=HBUuAr51OMuxJxYe3RD+OwNeXP+xs2hLWBMDzaZAVcU=; b=TdeuJAIDaqG7cwkqI4nHtdLny3
	iyCGAksOLbOqYUJhSHm7/jnC9FYcG7MIAOI+24axWzVXXtY5atDwJhF+jKUhXmqfua6SRtlM+APMM
	/pYrjZPc6jxGuTXcpWZNvCBeGuUVSbIdA+s5Wy3xFKjzxGB2gHwr9ssNf9AZuLz8yIIYL86UZuejU
	XVMh5xio++Mw71vSoYtvIu7OGOfqGzJUfFYq3P814XI3qfdU5eIZpgCj0gTmmOGhFHuiK0SwPAxTu
	lSlbzkU4S5i7NKFBbNSmypNtm9Lj4sjOaRZ0Un4K1h/t8X5QpXDk7e0wi3PVQ1JnV2KXISI4VvN0g
	bri/UK8A==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org
Subject: [PATCH 24/30] panic: Refactor the panic path
Date: Wed, 27 Apr 2022 19:49:18 -0300
Message-Id: <20220427224924.592546-25-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The panic() function is somewhat convoluted - a lot of changes were
made over the years, adding comments that might be misleading/outdated
now, it has a code structure that is a bit complex to follow, with
lots of conditionals, for example. The panic notifier list is something
else - a single list, with multiple callbacks of different purposes,
that run in a non-deterministic order and may affect hardly kdump
reliability - see the "crash_kexec_post_notifiers" workaround-ish flag.

This patch proposes a major refactor on the panic path based on Petr's
idea [0] - basically we split the notifiers list in three, having a set
of different call points in the panic path. Below a list of changes
proposed in this patch, culminating in the panic notifiers level
concept:

(a) First of all, we improved comments all over the function
and removed useless variables / includes. Also, as part of this
clean-up we concentrate the console flushing functions in a helper.

(b) As mentioned before, there is a split of the panic notifier list
in three, based on the purpose of the callback. The code contains
good documentation in form of comments, but a summary of the three
lists follows:

- the hypervisor list aims low-risk procedures to inform hypervisors
or firmware about the panic event, also includes LED-related functions;

- the informational list contains callbacks that provide more details,
like kernel offset or trace dump (if enabled) and also includes the
callbacks aimed at reducing log pollution or warns, like the RCU and
hung task disable callbacks;

- finally, the pre_reboot list is the old notifier list renamed,
containing the more risky callbacks that didn't fit the previous
lists. There is also a 4th list (the post_reboot one), but it's not
related with the original list - it contains late time architecture
callbacks aimed at stopping the machine, for example.

The 3 notifiers lists execute in different moments, hypervisor being
the first, followed by informational and finally the pre_reboot list.

(c) But then, there is the ordering problem of the notifiers against
the crash_kernel() call - kdump must be as reliable as possible.
For that, a simple binary "switch" as "crash_kexec_post_notifiers"
is not enough, hence we introduce here concept of panic notifier
levels: there are 5 levels, from 0 (no notifier executes before
kdump) until 4 (all notifiers run before kdump); the default level
is 2, in which the hypervisor and (iff we have any kmsg dumper)
the informational notifiers execute before kdump.

The detailed documentation of the levels is present in code comments
and in the kernel-parameters.txt file; as an analogy with the previous
panic() implementation, the level 0 is exactly the same as the old
behavior of notifiers, running all after kdump, and the level 4 is
the same as "crash_kexec_post_notifiers=Y" (we kept this parameter as
a deprecated one).

(d) Finally, an important change made here: we now use only the
function "crash_smp_send_stop()" to shut all the secondary CPUs
in the panic path. Before, there was a case of using the regular
"smp_send_stop()", but the better approach is to simplify the
code and try to use the function which was created exclusively
for the panic path. Experiments showed that it works fine, and
code was very simplified with that.

Functional change is expected from this refactor, since now we
call some notifiers by default before kdump, but the goal here
besides code clean-up is to have a better panic path, more
reliable and deterministic, but also very customizable.

[0] https://lore.kernel.org/lkml/YfPxvzSzDLjO5ldp@alley/

Suggested-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

Special thanks to Petr and Baoquan for the suggestion and feedback in a previous
email thread. There's some important design decisions that worth mentioning and
discussing:

* The default panic notifiers level is 2, based on Petr Mladek's suggestion,
which makes a lot of sense. Of course, this is customizable through the
parameter, but would be something worthwhile to have a KConfig option to set
the default level? It would help distros that want the old behavior
(no notifiers before kdump) as default.

* The implementation choice was to _avoid_ intricate if conditionals in the
panic path, which would _definitely_ be present with the panic notifiers levels
idea; so, instead of lots of if conditionals, the set/clear bits approach with
functions called in 2 points (but executing only in one of them) is much easier
to follow an was used here; the ordering helper function and the comments also
help a lot to avoid confusion (hopefully).

* Choice was to *always* use crash_smp_send_stop() instead of sometimes making
use of the regular smp_send_stop(); for most architectures they are the same,
including Xen (on x86). For the ones that override it, all should work fine,
in the powerpc case it's even more correct (see the subsequent patch
"powerpc: Do not force all panic notifiers to execute before kdump")

There seems to be 2 cases that requires some plumbing to work 100% right:
- ARM doesn't disable local interrupts / FIQs in the crash version of
send_stop(); we patched that early in this series;
- x86 could face an issue if we have VMX and do use crash_smp_send_stop()
_without_ kdump, but this is fixed in the first patch of the series (and
it's a bug present even before this refactor).

* Notice we didn't add a sysrq for panic notifiers level - should have it?
Alejandro proposed recently to add a sysrq for "crash_kexec_post_notifiers",
let me know if you feel the need here Alejandro, since the core parameters are
present in /sys, I didn't consider much gain in having a sysrq, but of course
I'm open to suggestions!

Thanks advance for the review!

 .../admin-guide/kernel-parameters.txt         |  42 ++-
 include/linux/panic_notifier.h                |   1 +
 kernel/kexec_core.c                           |   8 +-
 kernel/panic.c                                | 292 +++++++++++++-----
 .../selftests/pstore/pstore_crash_test        |   5 +-
 5 files changed, 252 insertions(+), 96 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 3f1cc5e317ed..8d3524060ce3 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -829,6 +829,13 @@
 			It will be ignored when crashkernel=X,high is not used
 			or memory reserved is below 4G.
 
+	crash_kexec_post_notifiers
+			This was DEPRECATED - users should always prefer the
+			parameter "panic_notifiers_level" - check its entry
+			in this documentation for details on how it works.
+			Setting this parameter is exactly the same as setting
+			"panic_notifiers_level=4".
+
 	cryptomgr.notests
 			[KNL] Disable crypto self-tests
 
@@ -3784,6 +3791,33 @@
 			timeout < 0: reboot immediately
 			Format: <timeout>
 
+	panic_notifiers_level=
+			[KNL] Set the panic notifiers execution order.
+			Format: <unsigned int>
+			We currently have 4 lists of panic notifiers; based
+			on the functionality and risk (for panic success) the
+			callbacks are added in a given list. The lists are:
+			- hypervisor/FW notification list (low risk);
+			- informational list (low/medium risk);
+			- pre_reboot list (higher risk);
+			- post_reboot list (only run late in panic and after
+			kdump, not configurable for now).
+			This parameter defines the ordering of the first 3
+			lists with regards to kdump; the levels determine
+			which set of notifiers execute before kdump. The
+			accepted levels are:
+			0: kdump is the first thing to run, NO list is
+			executed before kdump.
+			1: only the hypervisor list is executed before kdump.
+			2 (default level): the hypervisor list and (*if*
+			there's any kmsg_dumper defined) the informational
+			list are executed before kdump.
+			3: both the hypervisor and the informational lists
+			(always) execute before kdump.
+			4: the 3 lists (hypervisor, info and pre_reboot)
+			execute before kdump - this behavior is analog to the
+			deprecated parameter "crash_kexec_post_notifiers".
+
 	panic_print=	Bitmask for printing system info when panic happens.
 			User can chose combination of the following bits:
 			bit 0: print all tasks info
@@ -3814,14 +3848,6 @@
 	panic_on_warn	panic() instead of WARN().  Useful to cause kdump
 			on a WARN().
 
-	crash_kexec_post_notifiers
-			Run kdump after running panic-notifiers and dumping
-			kmsg. This only for the users who doubt kdump always
-			succeeds in any situation.
-			Note that this also increases risks of kdump failure,
-			because some panic notifiers can make the crashed
-			kernel more unstable.
-
 	parkbd.port=	[HW] Parallel port number the keyboard adapter is
 			connected to, default is 0.
 			Format: <parport#>
diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
index bcf6a5ea9d7f..b5041132321d 100644
--- a/include/linux/panic_notifier.h
+++ b/include/linux/panic_notifier.h
@@ -10,6 +10,7 @@ extern struct atomic_notifier_head panic_info_list;
 extern struct atomic_notifier_head panic_pre_reboot_list;
 extern struct atomic_notifier_head panic_post_reboot_list;
 
+bool panic_notifiers_before_kdump(void);
 extern bool crash_kexec_post_notifiers;
 
 enum panic_notifier_val {
diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 68480f731192..f8906db8ca72 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -74,11 +74,11 @@ struct resource crashk_low_res = {
 int kexec_should_crash(struct task_struct *p)
 {
 	/*
-	 * If crash_kexec_post_notifiers is enabled, don't run
-	 * crash_kexec() here yet, which must be run after panic
-	 * notifiers in panic().
+	 * In case any panic notifiers are set to execute before kexec,
+	 * don't run crash_kexec() here yet, which must run after these
+	 * panic notifiers are executed, in the panic() path.
 	 */
-	if (crash_kexec_post_notifiers)
+	if (panic_notifiers_before_kdump())
 		return 0;
 	/*
 	 * There are 4 panic() calls in make_task_dead() path, each of which
diff --git a/kernel/panic.c b/kernel/panic.c
index bf792102b43e..b7c055d4f87f 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -15,7 +15,6 @@
 #include <linux/kgdb.h>
 #include <linux/kmsg_dump.h>
 #include <linux/kallsyms.h>
-#include <linux/notifier.h>
 #include <linux/vt_kern.h>
 #include <linux/module.h>
 #include <linux/random.h>
@@ -52,14 +51,23 @@ static unsigned long tainted_mask =
 static int pause_on_oops;
 static int pause_on_oops_flag;
 static DEFINE_SPINLOCK(pause_on_oops_lock);
-bool crash_kexec_post_notifiers;
+
 int panic_on_warn __read_mostly;
+bool panic_on_taint_nousertaint;
 unsigned long panic_on_taint;
-bool panic_on_taint_nousertaint = false;
 
 int panic_timeout = CONFIG_PANIC_TIMEOUT;
 EXPORT_SYMBOL_GPL(panic_timeout);
 
+/* Initialized with all notifiers set to run before kdump */
+static unsigned long panic_notifiers_bits = 15;
+
+/* Default level is 2, see kernel-parameters.txt */
+unsigned int panic_notifiers_level = 2;
+
+/* DEPRECATED in favor of panic_notifiers_level */
+bool crash_kexec_post_notifiers;
+
 #define PANIC_PRINT_TASK_INFO		0x00000001
 #define PANIC_PRINT_MEM_INFO		0x00000002
 #define PANIC_PRINT_TIMER_INFO		0x00000004
@@ -109,10 +117,14 @@ void __weak nmi_panic_self_stop(struct pt_regs *regs)
 }
 
 /*
- * Stop other CPUs in panic.  Architecture dependent code may override this
- * with more suitable version.  For example, if the architecture supports
- * crash dump, it should save registers of each stopped CPU and disable
- * per-CPU features such as virtualization extensions.
+ * Stop other CPUs in panic context.
+ *
+ * Architecture dependent code may override this with more suitable version.
+ * For example, if the architecture supports crash dump, it should save the
+ * registers of each stopped CPU and disable per-CPU features such as
+ * virtualization extensions. When not overridden in arch code (and for
+ * x86/xen), this is exactly the same as execute smp_send_stop(), but
+ * guarded against duplicate execution.
  */
 void __weak crash_smp_send_stop(void)
 {
@@ -183,6 +195,112 @@ static void panic_print_sys_info(bool console_flush)
 		ftrace_dump(DUMP_ALL);
 }
 
+/*
+ * Helper that accumulates all console flushing routines executed on panic.
+ */
+static void console_flushing(void)
+{
+#ifdef CONFIG_VT
+	unblank_screen();
+#endif
+	console_unblank();
+
+	/*
+	 * In this point, we may have disabled other CPUs, hence stopping the
+	 * CPU holding the lock while still having some valuable data in the
+	 * console buffer.
+	 *
+	 * Try to acquire the lock then release it regardless of the result.
+	 * The release will also print the buffers out. Locks debug should
+	 * be disabled to avoid reporting bad unlock balance when panic()
+	 * is not being called from OOPS.
+	 */
+	debug_locks_off();
+	console_flush_on_panic(CONSOLE_FLUSH_PENDING);
+
+	panic_print_sys_info(true);
+}
+
+#define PN_HYPERVISOR_BIT	0
+#define PN_INFO_BIT		1
+#define PN_PRE_REBOOT_BIT	2
+#define PN_POST_REBOOT_BIT	3
+
+/*
+ * Determine the order of panic notifiers with regards to kdump.
+ *
+ * This function relies in the "panic_notifiers_level" kernel parameter
+ * to determine how to order the notifiers with regards to kdump. We
+ * have currently 5 levels. For details, please check the kernel docs for
+ * "panic_notifiers_level" at Documentation/admin-guide/kernel-parameters.txt.
+ *
+ * Default level is 2, which means the panic hypervisor and informational
+ * (unless we don't have any kmsg_dumper) lists will execute before kdump.
+ */
+static void order_panic_notifiers_and_kdump(void)
+{
+	/*
+	 * The parameter "crash_kexec_post_notifiers" is deprecated, but
+	 * valid. Users that set it want really all panic notifiers to
+	 * execute before kdump, so it's effectively the same as setting
+	 * the panic notifiers level to 4.
+	 */
+	if (panic_notifiers_level >= 4 || crash_kexec_post_notifiers)
+		return;
+
+	/*
+	 * Based on the level configured (smaller than 4), we clear the
+	 * proper bits in "panic_notifiers_bits". Notice that this bitfield
+	 * is initialized with all notifiers set.
+	 */
+	switch (panic_notifiers_level) {
+	case 3:
+		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
+		break;
+	case 2:
+		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
+
+		if (!kmsg_has_dumpers())
+			clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
+		break;
+	case 1:
+		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
+		clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
+		break;
+	case 0:
+		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
+		clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
+		clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits);
+		break;
+	}
+}
+
+/*
+ * Set of helpers to execute the panic notifiers only once.
+ * Just the informational notifier cares about the return.
+ */
+static inline bool notifier_run_once(struct atomic_notifier_head head,
+				     char *buf, long bit)
+{
+	if (test_and_change_bit(bit, &panic_notifiers_bits)) {
+		atomic_notifier_call_chain(&head, PANIC_NOTIFIER, buf);
+		return true;
+	}
+	return false;
+}
+
+#define panic_notifier_hypervisor_once(buf)\
+	notifier_run_once(panic_hypervisor_list, buf, PN_HYPERVISOR_BIT)
+
+#define panic_notifier_info_once(buf)\
+	notifier_run_once(panic_info_list, buf, PN_INFO_BIT)
+
+#define panic_notifier_pre_reboot_once(buf)\
+	notifier_run_once(panic_pre_reboot_list, buf, PN_PRE_REBOOT_BIT)
+
+#define panic_notifier_post_reboot_once(buf)\
+	notifier_run_once(panic_post_reboot_list, buf, PN_POST_REBOOT_BIT)
+
 /**
  *	panic - halt the system
  *	@fmt: The text string to print
@@ -198,32 +316,29 @@ void panic(const char *fmt, ...)
 	long i, i_next = 0, len;
 	int state = 0;
 	int old_cpu, this_cpu;
-	bool _crash_kexec_post_notifiers = crash_kexec_post_notifiers;
 
-	if (panic_on_warn) {
-		/*
-		 * This thread may hit another WARN() in the panic path.
-		 * Resetting this prevents additional WARN() from panicking the
-		 * system on this thread.  Other threads are blocked by the
-		 * panic_mutex in panic().
-		 */
-		panic_on_warn = 0;
-	}
+	/*
+	 * This thread may hit another WARN() in the panic path, so
+	 * resetting this option prevents additional WARN() from
+	 * re-panicking the system here.
+	 */
+	panic_on_warn = 0;
 
 	/*
 	 * Disable local interrupts. This will prevent panic_smp_self_stop
-	 * from deadlocking the first cpu that invokes the panic, since
-	 * there is nothing to prevent an interrupt handler (that runs
-	 * after setting panic_cpu) from invoking panic() again.
+	 * from deadlocking the first cpu that invokes the panic, since there
+	 * is nothing to prevent an interrupt handler (that runs after setting
+	 * panic_cpu) from invoking panic() again. Also disables preemption
+	 * here - notice it's not safe to rely on interrupt disabling to avoid
+	 * preemption, since any cond_resched() or cond_resched_lock() might
+	 * trigger a reschedule if the preempt count is 0 (for reference, see
+	 * Documentation/locking/preempt-locking.rst). Some functions called
+	 * from here want preempt disabled, so no point enabling it later.
 	 */
 	local_irq_disable();
 	preempt_disable_notrace();
 
 	/*
-	 * It's possible to come here directly from a panic-assertion and
-	 * not have preempt disabled. Some functions called from here want
-	 * preempt to be disabled. No point enabling it later though...
-	 *
 	 * Only one CPU is allowed to execute the panic code from here. For
 	 * multiple parallel invocations of panic, all other CPUs either
 	 * stop themself or will wait until they are stopped by the 1st CPU
@@ -266,73 +381,75 @@ void panic(const char *fmt, ...)
 	kgdb_panic(buf);
 
 	/*
-	 * If we have crashed and we have a crash kernel loaded let it handle
-	 * everything else.
-	 * If we want to run this after calling panic_notifiers, pass
-	 * the "crash_kexec_post_notifiers" option to the kernel.
+	 * Here lies one of the most subtle parts of the panic path,
+	 * the panic notifiers and their order with regards to kdump.
+	 * We currently have 4 sets of notifiers:
 	 *
-	 * Bypass the panic_cpu check and call __crash_kexec directly.
+	 *  - the hypervisor list is composed by callbacks that are related
+	 *  to warn the FW / hypervisor about panic, or non-invasive LED
+	 *  controlling functions - (hopefully) low-risk for kdump, should
+	 *  run early if possible.
+	 *
+	 *  - the informational list is composed by functions dumping data
+	 *  like kernel offsets, device error registers or tracing buffer;
+	 *  also log flooding prevention callbacks fit in this list. It is
+	 *  relatively safe to run before kdump.
+	 *
+	 *  - the pre_reboot list basically is everything else, all the
+	 *  callbacks that don't fit in the 2 previous lists. It should
+	 *  run *after* kdump if possible, as it contains high-risk
+	 *  functions that may break kdump.
+	 *
+	 *  - we also have a 4th list of notifiers, the post_reboot
+	 *  callbacks. This is not strongly related to kdump since it's
+	 *  always executed late in the panic path, after the restart
+	 *  mechanism (if set); its goal is to provide a way for
+	 *  architecture code effectively power-off/disable the system.
+	 *
+	 *  The kernel provides the "panic_notifiers_level" parameter
+	 *  to adjust the ordering in which these notifiers should run
+	 *  with regards to kdump - the default level is 2, so both the
+	 *  hypervisor and informational notifiers should execute before
+	 *  the __crash_kexec(); the info notifier won't run by default
+	 *  unless there's some kmsg_dumper() registered. For details
+	 *  about it, check Documentation/admin-guide/kernel-parameters.txt.
+	 *
+	 *  Notice that the code relies in bits set/clear operations to
+	 *  determine the ordering, functions *_once() execute only one
+	 *  time, as their name implies. The goal is to prevent too much
+	 *  if conditionals and more confusion. Finally, regarding CPUs
+	 *  disabling: unless NO panic notifier executes before kdump,
+	 *  we always disable secondary CPUs before __crash_kexec() and
+	 *  the notifiers execute.
 	 */
-	if (!_crash_kexec_post_notifiers) {
+	order_panic_notifiers_and_kdump();
+
+	/* If no level, we should kdump ASAP. */
+	if (!panic_notifiers_level)
 		__crash_kexec(NULL);
 
-		/*
-		 * Note smp_send_stop is the usual smp shutdown function, which
-		 * unfortunately means it may not be hardened to work in a
-		 * panic situation.
-		 */
-		smp_send_stop();
-	} else {
-		/*
-		 * If we want to do crash dump after notifier calls and
-		 * kmsg_dump, we will need architecture dependent extra
-		 * works in addition to stopping other CPUs.
-		 */
-		crash_smp_send_stop();
-	}
+	crash_smp_send_stop();
+	panic_notifier_hypervisor_once(buf);
 
-	/*
-	 * Run any panic handlers, including those that might need to
-	 * add information to the kmsg dump output.
-	 */
-	atomic_notifier_call_chain(&panic_hypervisor_list, PANIC_NOTIFIER, buf);
-	atomic_notifier_call_chain(&panic_info_list, PANIC_NOTIFIER, buf);
-	atomic_notifier_call_chain(&panic_pre_reboot_list, PANIC_NOTIFIER, buf);
+	if (panic_notifier_info_once(buf)) {
+		panic_print_sys_info(false);
+		kmsg_dump(KMSG_DUMP_PANIC);
+	}
 
-	panic_print_sys_info(false);
+	panic_notifier_pre_reboot_once(buf);
 
-	kmsg_dump(KMSG_DUMP_PANIC);
+	__crash_kexec(NULL);
 
-	/*
-	 * If you doubt kdump always works fine in any situation,
-	 * "crash_kexec_post_notifiers" offers you a chance to run
-	 * panic_notifiers and dumping kmsg before kdump.
-	 * Note: since some panic_notifiers can make crashed kernel
-	 * more unstable, it can increase risks of the kdump failure too.
-	 *
-	 * Bypass the panic_cpu check and call __crash_kexec directly.
-	 */
-	if (_crash_kexec_post_notifiers)
-		__crash_kexec(NULL);
+	panic_notifier_hypervisor_once(buf);
 
-#ifdef CONFIG_VT
-	unblank_screen();
-#endif
-	console_unblank();
-
-	/*
-	 * We may have ended up stopping the CPU holding the lock (in
-	 * smp_send_stop()) while still having some valuable data in the console
-	 * buffer.  Try to acquire the lock then release it regardless of the
-	 * result.  The release will also print the buffers out.  Locks debug
-	 * should be disabled to avoid reporting bad unlock balance when
-	 * panic() is not being callled from OOPS.
-	 */
-	debug_locks_off();
-	console_flush_on_panic(CONSOLE_FLUSH_PENDING);
+	if (panic_notifier_info_once(buf)) {
+		panic_print_sys_info(false);
+		kmsg_dump(KMSG_DUMP_PANIC);
+	}
 
-	panic_print_sys_info(true);
+	panic_notifier_pre_reboot_once(buf);
 
+	console_flushing();
 	if (!panic_blink)
 		panic_blink = no_blink;
 
@@ -363,8 +480,7 @@ void panic(const char *fmt, ...)
 		emergency_restart();
 	}
 
-	atomic_notifier_call_chain(&panic_post_reboot_list,
-				   PANIC_NOTIFIER, buf);
+	panic_notifier_post_reboot_once(buf);
 
 	pr_emerg("---[ end Kernel panic - not syncing: %s ]---\n", buf);
 
@@ -383,6 +499,15 @@ void panic(const char *fmt, ...)
 
 EXPORT_SYMBOL(panic);
 
+/*
+ * Helper used in the kexec code, to validate if any
+ * panic notifier is set to execute early, before kdump.
+ */
+inline bool panic_notifiers_before_kdump(void)
+{
+	return panic_notifiers_level || crash_kexec_post_notifiers;
+}
+
 /*
  * TAINT_FORCED_RMMOD could be a per-module flag but the module
  * is being removed anyway.
@@ -692,6 +817,9 @@ core_param(panic, panic_timeout, int, 0644);
 core_param(panic_print, panic_print, ulong, 0644);
 core_param(pause_on_oops, pause_on_oops, int, 0644);
 core_param(panic_on_warn, panic_on_warn, int, 0644);
+core_param(panic_notifiers_level, panic_notifiers_level, uint, 0644);
+
+/* DEPRECATED in favor of panic_notifiers_level */
 core_param(crash_kexec_post_notifiers, crash_kexec_post_notifiers, bool, 0644);
 
 static int __init oops_setup(char *s)
diff --git a/tools/testing/selftests/pstore/pstore_crash_test b/tools/testing/selftests/pstore/pstore_crash_test
index 2a329bbb4aca..1e60ce4501aa 100755
--- a/tools/testing/selftests/pstore/pstore_crash_test
+++ b/tools/testing/selftests/pstore/pstore_crash_test
@@ -25,6 +25,7 @@ touch $REBOOT_FLAG
 sync
 
 # cause crash
-# Note: If you use kdump and want to see kmesg-* files after reboot, you should
-#       specify 'crash_kexec_post_notifiers' in 1st kernel's cmdline.
+# Note: If you use kdump and want to see kmsg-* files after reboot, you should
+#       be sure that the parameter "panic_notifiers_level" is more than '2' (the
+#       default value for this parameter is '2') in the first kernel's cmdline.
 echo c > /proc/sysrq-trigger
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315608.534431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgq-0006is-E8; Wed, 27 Apr 2022 23:03:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315608.534431; Wed, 27 Apr 2022 23:03:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgo-0006ag-Rm; Wed, 27 Apr 2022 23:03:18 +0000
Received: by outflank-mailman (input) for mailman id 315608;
 Wed, 27 Apr 2022 22:56:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqaX-00040Q-Qy
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:56:50 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5149aaa8-c67d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:56:48 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqaG-0002Qg-Er; Thu, 28 Apr 2022 00:56:33 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5149aaa8-c67d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=jkYRHw7XLP9WroKS48pjCKf8DZNXzuNJkBrmx0UcVRc=; b=fbM2Fu2zuIxXnRnSKiwEiLyyJe
	XagaY4Y4i5sW6+W+epTqREIZ/ICl1Xi2oNzNqYSLfAiAeujQhcD2J6BRDpwqIfpK1aYn9B4Gepnqm
	UXEPwRAoI9LiYlvqP9hTq72CQIYynMwPnO/khrMA9H8ZW9ZKFbbeWjtIm9rBmVgqZX/xUmom+B8xi
	QY1BWJZFFIiYDwppo949ykglLrpZKKBYxdtwbkyN1uybFrzpdjMmPjKvulL2l2aogMZ8iE6aJcjTZ
	GbdvguHg7iZbdZllsoe1PY/R6t06HkFNrymWUR1pYeoyB7ORK7qb8BLpbexkNshwnkf274e7nAB6M
	ydSnW7kQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org
Subject: [PATCH 25/30] panic, printk: Add console flush parameter and convert panic_print to a notifier
Date: Wed, 27 Apr 2022 19:49:19 -0300
Message-Id: <20220427224924.592546-26-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently the parameter "panic_print" relies in a function called
directly on panic path; one of the flags the users can set for
panic_print triggers a console replay mechanism, to show the
entire kernel log buffer (from the beginning) in a panic event.

Two problems with that: the dual nature of the panic_print
isn't really appropriate, the function was originally meant
to allow users dumping system information on panic events,
and was "overridden" to also force a console flush of the full
kernel log buffer. It also turns the code a bit more complex
and duplicate than it needs to be.

This patch proposes 2 changes: first, we decouple panic_print
from the console flushing mechanism, in the form of a new kernel
core parameter (panic_console_replay); we kept the functionality
on panic_print to avoid userspace breakage, although we comment
in both code and documentation that this panic_print usage is
deprecated.

We converted panic_print function to a panic notifier too, adding
it on the panic informational notifier list, executed as the final
callback. This allows a more clear code and makes sense, as
panic_print_sys_info() is really a panic-time only function.
We also moved its code to kernel/printk.c, it seems to make more
sense given it's related to printing stuff.

Suggested-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 .../admin-guide/kernel-parameters.txt         | 12 +++-
 Documentation/admin-guide/sysctl/kernel.rst   |  5 +-
 include/linux/console.h                       |  2 +
 include/linux/panic.h                         |  1 -
 include/linux/printk.h                        |  1 +
 kernel/panic.c                                | 51 +++------------
 kernel/printk/printk.c                        | 62 +++++++++++++++++++
 7 files changed, 87 insertions(+), 47 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 8d3524060ce3..c99da8b2b216 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -3791,6 +3791,14 @@
 			timeout < 0: reboot immediately
 			Format: <timeout>
 
+	panic_console_replay
+			[KNL] Force a kernel log replay in the console on
+			panic event. Notice that there is already a flush
+			mechanism for pending messages; this option is meant
+			for users that wish to replay the *full* buffer.
+			It deprecates the bit 5 setting on "panic_print",
+			both having the same functionality.
+
 	panic_notifiers_level=
 			[KNL] Set the panic notifiers execution order.
 			Format: <unsigned int>
@@ -3825,12 +3833,14 @@
 			bit 2: print timer info
 			bit 3: print locks info if CONFIG_LOCKDEP is on
 			bit 4: print ftrace buffer
-			bit 5: print all printk messages in buffer
+			bit 5: print all printk messages in buffer (DEPRECATED)
 			bit 6: print all CPUs backtrace (if available in the arch)
 			*Be aware* that this option may print a _lot_ of lines,
 			so there are risks of losing older messages in the log.
 			Use this option carefully, maybe worth to setup a
 			bigger log buffer with "log_buf_len" along with this.
+			Also, notice that bit 5 was deprecated in favor of the
+			parameter "panic_console_replay".
 
 	panic_on_taint=	Bitmask for conditionally calling panic() in add_taint()
 			Format: <hex>[,nousertaint]
diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 1144ea3229a3..17b293a0e566 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -763,10 +763,13 @@ bit 1  print system memory info
 bit 2  print timer info
 bit 3  print locks info if ``CONFIG_LOCKDEP`` is on
 bit 4  print ftrace buffer
-bit 5  print all printk messages in buffer
+bit 5  print all printk messages in buffer (DEPRECATED)
 bit 6  print all CPUs backtrace (if available in the arch)
 =====  ============================================
 
+Notice that bit 5 was deprecated in favor of kernel core parameter
+"panic_console_replay" (see kernel-parameters.txt documentation).
+
 So for example to print tasks and memory info on panic, user can::
 
   echo 3 > /proc/sys/kernel/panic_print
diff --git a/include/linux/console.h b/include/linux/console.h
index 7cd758a4f44e..351c14f623ad 100644
--- a/include/linux/console.h
+++ b/include/linux/console.h
@@ -169,6 +169,8 @@ enum con_flush_mode {
 	CONSOLE_REPLAY_ALL,
 };
 
+extern bool panic_console_replay;
+
 extern int add_preferred_console(char *name, int idx, char *options);
 extern void register_console(struct console *);
 extern int unregister_console(struct console *);
diff --git a/include/linux/panic.h b/include/linux/panic.h
index f5844908a089..34175d0188d0 100644
--- a/include/linux/panic.h
+++ b/include/linux/panic.h
@@ -22,7 +22,6 @@ extern unsigned int sysctl_oops_all_cpu_backtrace;
 #endif /* CONFIG_SMP */
 
 extern int panic_timeout;
-extern unsigned long panic_print;
 extern int panic_on_oops;
 extern int panic_on_unrecovered_nmi;
 extern int panic_on_io_nmi;
diff --git a/include/linux/printk.h b/include/linux/printk.h
index 1522df223c0f..aee2e8ebd541 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -13,6 +13,7 @@
 extern const char linux_banner[];
 extern const char linux_proc_banner[];
 
+extern unsigned long panic_print;
 extern int oops_in_progress;	/* If set, an oops, panic(), BUG() or die() is in progress */
 
 #define PRINTK_MAX_SINGLE_HEADER_LEN 2
diff --git a/kernel/panic.c b/kernel/panic.c
index b7c055d4f87f..ff257bd8f81b 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -68,15 +68,6 @@ unsigned int panic_notifiers_level = 2;
 /* DEPRECATED in favor of panic_notifiers_level */
 bool crash_kexec_post_notifiers;
 
-#define PANIC_PRINT_TASK_INFO		0x00000001
-#define PANIC_PRINT_MEM_INFO		0x00000002
-#define PANIC_PRINT_TIMER_INFO		0x00000004
-#define PANIC_PRINT_LOCK_INFO		0x00000008
-#define PANIC_PRINT_FTRACE_INFO		0x00000010
-#define PANIC_PRINT_ALL_PRINTK_MSG	0x00000020
-#define PANIC_PRINT_ALL_CPU_BT		0x00000040
-unsigned long panic_print;
-
 ATOMIC_NOTIFIER_HEAD(panic_hypervisor_list);
 EXPORT_SYMBOL(panic_hypervisor_list);
 
@@ -168,33 +159,6 @@ void nmi_panic(struct pt_regs *regs, const char *msg)
 }
 EXPORT_SYMBOL(nmi_panic);
 
-static void panic_print_sys_info(bool console_flush)
-{
-	if (console_flush) {
-		if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG)
-			console_flush_on_panic(CONSOLE_REPLAY_ALL);
-		return;
-	}
-
-	if (panic_print & PANIC_PRINT_ALL_CPU_BT)
-		trigger_all_cpu_backtrace();
-
-	if (panic_print & PANIC_PRINT_TASK_INFO)
-		show_state();
-
-	if (panic_print & PANIC_PRINT_MEM_INFO)
-		show_mem(0, NULL);
-
-	if (panic_print & PANIC_PRINT_TIMER_INFO)
-		sysrq_timer_list_show();
-
-	if (panic_print & PANIC_PRINT_LOCK_INFO)
-		debug_show_all_locks();
-
-	if (panic_print & PANIC_PRINT_FTRACE_INFO)
-		ftrace_dump(DUMP_ALL);
-}
-
 /*
  * Helper that accumulates all console flushing routines executed on panic.
  */
@@ -218,7 +182,11 @@ static void console_flushing(void)
 	debug_locks_off();
 	console_flush_on_panic(CONSOLE_FLUSH_PENDING);
 
-	panic_print_sys_info(true);
+	/* In case users wish to replay the full log buffer... */
+	if (panic_console_replay) {
+		pr_warn("Replaying the log buffer from the beginning\n");
+		console_flush_on_panic(CONSOLE_REPLAY_ALL);
+	}
 }
 
 #define PN_HYPERVISOR_BIT	0
@@ -431,10 +399,8 @@ void panic(const char *fmt, ...)
 	crash_smp_send_stop();
 	panic_notifier_hypervisor_once(buf);
 
-	if (panic_notifier_info_once(buf)) {
-		panic_print_sys_info(false);
+	if (panic_notifier_info_once(buf))
 		kmsg_dump(KMSG_DUMP_PANIC);
-	}
 
 	panic_notifier_pre_reboot_once(buf);
 
@@ -442,10 +408,8 @@ void panic(const char *fmt, ...)
 
 	panic_notifier_hypervisor_once(buf);
 
-	if (panic_notifier_info_once(buf)) {
-		panic_print_sys_info(false);
+	if (panic_notifier_info_once(buf))
 		kmsg_dump(KMSG_DUMP_PANIC);
-	}
 
 	panic_notifier_pre_reboot_once(buf);
 
@@ -814,7 +778,6 @@ EXPORT_SYMBOL(__stack_chk_fail);
 #endif
 
 core_param(panic, panic_timeout, int, 0644);
-core_param(panic_print, panic_print, ulong, 0644);
 core_param(pause_on_oops, pause_on_oops, int, 0644);
 core_param(panic_on_warn, panic_on_warn, int, 0644);
 core_param(panic_notifiers_level, panic_notifiers_level, uint, 0644);
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index e3a1c429fbbc..ad91d4c04246 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -35,6 +35,7 @@
 #include <linux/memblock.h>
 #include <linux/syscalls.h>
 #include <linux/crash_core.h>
+#include <linux/panic_notifier.h>
 #include <linux/ratelimit.h>
 #include <linux/kmsg_dump.h>
 #include <linux/syslog.h>
@@ -3234,6 +3235,61 @@ void __init console_init(void)
 	}
 }
 
+#define PANIC_PRINT_TASK_INFO		0x00000001
+#define PANIC_PRINT_MEM_INFO		0x00000002
+#define PANIC_PRINT_TIMER_INFO		0x00000004
+#define PANIC_PRINT_LOCK_INFO		0x00000008
+#define PANIC_PRINT_FTRACE_INFO		0x00000010
+
+/* DEPRECATED - please use "panic_console_replay" */
+#define PANIC_PRINT_ALL_PRINTK_MSG	0x00000020
+
+#define PANIC_PRINT_ALL_CPU_BT		0x00000040
+
+unsigned long panic_print;
+bool panic_console_replay;
+
+static int panic_print_sys_info(struct notifier_block *self,
+				unsigned long ev, void *unused)
+{
+	if (panic_print & PANIC_PRINT_ALL_CPU_BT)
+		trigger_all_cpu_backtrace();
+
+	if (panic_print & PANIC_PRINT_TASK_INFO)
+		show_state();
+
+	if (panic_print & PANIC_PRINT_MEM_INFO)
+		show_mem(0, NULL);
+
+	if (panic_print & PANIC_PRINT_TIMER_INFO)
+		sysrq_timer_list_show();
+
+	if (panic_print & PANIC_PRINT_LOCK_INFO)
+		debug_show_all_locks();
+
+	if (panic_print & PANIC_PRINT_FTRACE_INFO)
+		ftrace_dump(DUMP_ALL);
+
+	/*
+	 * This is legacy/deprecated feature from panic_print,
+	 * the console force flushing. We have now the parameter
+	 * "panic_console_replay", but we need to keep the
+	 * retro-compatibility with the old stuff...
+	 */
+	if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG)
+		panic_console_replay = true;
+
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block panic_print_nb = {
+	.notifier_call = panic_print_sys_info,
+	.priority = INT_MIN, /* defer to run as late as possible */
+};
+
+core_param(panic_print, panic_print, ulong, 0644);
+core_param(panic_console_replay, panic_console_replay, bool, 0644);
+
 /*
  * Some boot consoles access data that is in the init section and which will
  * be discarded after the initcalls have been run. To make sure that no code
@@ -3253,6 +3309,12 @@ static int __init printk_late_init(void)
 	struct console *con;
 	int ret;
 
+	/*
+	 * Register the panic notifier to print user information
+	 * in case the user have that set.
+	 */
+	atomic_notifier_chain_register(&panic_info_list, &panic_print_nb);
+
 	for_each_console(con) {
 		if (!(con->flags & CON_BOOT))
 			continue;
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315610.534440 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgs-0007Ez-7b; Wed, 27 Apr 2022 23:03:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315610.534440; Wed, 27 Apr 2022 23:03:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgr-00076C-2o; Wed, 27 Apr 2022 23:03:21 +0000
Received: by outflank-mailman (input) for mailman id 315610;
 Wed, 27 Apr 2022 22:57:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqbI-00046D-Q8
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:57:36 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6d7f60b2-c67d-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:57:35 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqb3-0002Tm-Pi; Thu, 28 Apr 2022 00:57:22 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d7f60b2-c67d-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=Vlo9T2/mvIa7VmsgTZAplfpKcY639xSpi9Lsc7QD2sA=; b=ZiYAT8sJyiBNaHzrk2673FL4+8
	1oiyWalKP6LGmKEc9hZJWoXC6cS5nMMrcCw5Iicmmfaanay2XW+Ea9CLz93XJRZPptEPdWhd8bk0b
	rKw9muPDbsgcmhx+6dtX/C/iDyONNGYxGodf7FR5gZ6gaCx9CBSOMyg/WgkwloH6LwMYOPDHwMc9i
	DlZzPF1Rmfq/gUUioCECpXAnYQMmNjWP7xmmSjqLdHZxdMlvMlgrtO3h+d5FTnJJbisLeLao1OJx/
	z7mwY9pmIo/3ja9SO2+rtPXIxKaESObUyZjm7eg6MS41mJJ7ZAlwRmPdpw93iK7tmvwyFHIvecdrE
	ZFlVRrJg==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Andrea Parri <parri.andrea@gmail.com>,
	Dexuan Cui <decui@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>
Subject: [PATCH 26/30] Drivers: hv: Do not force all panic notifiers to execute before kdump
Date: Wed, 27 Apr 2022 19:49:20 -0300
Message-Id: <20220427224924.592546-27-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Since commit a11589563e96 ("x86/Hyper-V: Report crash register
data or kmsg before running crash kernel") Hyper-V forcibly sets
the kernel parameter "crash_kexec_post_notifiers"; with that, it
did enforce the execution of *all* panic notifiers before kdump.
The main reason behind that is that Hyper-V has an hypervisor
notification mechanism that has the ability of warning the
hypervisor when the guest panics.

Happens that after the panic notifiers refactor, we now have 3 lists
and a level mechanism that defines the ordering of the notifiers
execution with regards to kdump. And for Hyper-V, the specific
notifier to inform the hypervisor about a panic lies in the first
list, which *by default* is set to execute before kdump. Hence,
this patch removes the hardcoded setting, effectively reverting
the aforementioned commit.

One of the problems with the forced approach was greatly exposed by
commit d57d6fe5bf34 ("drivers: hv: log when enabling crash_kexec_post_notifiers")
which ended-up confusing the user that didn't expect the notifiers
to execute before kdump, since it's a user setting and wasn't
enabled by such user. With the patch hereby proposed, that kind
of issue doesn't happen anymore, the panic notifiers level is
well-documented and users can expect a predictable behavior.

Fixes: a11589563e96 ("x86/Hyper-V: Report crash register data or kmsg before running crash kernel")
Fixes: d57d6fe5bf34 ("drivers: hv: log when enabling crash_kexec_post_notifiers"
Cc: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Michael Kelley <mikelley@microsoft.com>
Cc: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Tested-by: Fabio A M Martins <fabiomirmar@gmail.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

Special thanks to Michael Kelley for the good information about the Hyper-V
panic path in email threads some months ago, and to Fabio for the testing
performed.

 drivers/hv/hv_common.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
index ae68298c0dca..af59793de523 100644
--- a/drivers/hv/hv_common.c
+++ b/drivers/hv/hv_common.c
@@ -73,18 +73,6 @@ int __init hv_common_init(void)
 {
 	int i;
 
-	/*
-	 * Hyper-V expects to get crash register data or kmsg when
-	 * crash enlightment is available and system crashes. Set
-	 * crash_kexec_post_notifiers to be true to make sure that
-	 * calling crash enlightment interface before running kdump
-	 * kernel.
-	 */
-	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) {
-		crash_kexec_post_notifiers = true;
-		pr_info("Hyper-V: enabling crash_kexec_post_notifiers\n");
-	}
-
 	/*
 	 * Allocate the per-CPU state for the hypercall input arg.
 	 * If this allocation fails, we will not be able to setup
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315612.534452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgu-0007fE-CA; Wed, 27 Apr 2022 23:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315612.534452; Wed, 27 Apr 2022 23:03:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgs-0007X7-Lb; Wed, 27 Apr 2022 23:03:22 +0000
Received: by outflank-mailman (input) for mailman id 315612;
 Wed, 27 Apr 2022 22:57:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqbb-000470-VI
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:57:55 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 78e61bec-c67d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 00:57:55 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqbL-0002UI-QD; Thu, 28 Apr 2022 00:57:40 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78e61bec-c67d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=C9iT/xJ8gF8J/f7SmqQO2c8pu+KvBPlFfkqGdYboS2I=; b=PMFgjQG40D4y0EE10+nqxAPHVI
	yNLZ1EZJdP0IH30iYafdBfM788VaINOAVfe8Gnevld0DclzQJRd8t+br/vJapdawGOEWHQTLdmHei
	1IQvYGZ//MLpN+QQDVtOXWSfDQyyspNE1J3gOgOC4NUam3dGx8JeBgJ9jpYRHFoaP71Y3fG1ERN+7
	JvwIb059Xf3lNBTrEP8JiyuPOh5ugwSvNao5NfaR+bMPV8BospKPkEU02jshVAtp1UBbOdjrRb2r2
	ze90RIwfaZigyOQntmQCmXs163wt4gsMUWHmf1nSoidLeEjFKj9WA7H531Eyz4iqvzof4LvLiIP9u
	dq8Lxg9g==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>
Subject: [PATCH 27/30] powerpc: Do not force all panic notifiers to execute before kdump
Date: Wed, 27 Apr 2022 19:49:21 -0300
Message-Id: <20220427224924.592546-28-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit 06e629c25daa ("powerpc/fadump: Fix inaccurate CPU state info in
vmcore generated with panic") introduced a hardcoded setting of kernel
parameter "crash_kexec_post_notifiers", effectively forcing all the
panic notifiers to execute earlier in the panic path, before kdump.

The reason for that was a fadump issue on collecting data accurately,
due to smp_send_stop() setting all CPUs offline, so the net effect
desired with this change was to avoid calling the regular CPU
shutdown function, and instead rely on crash_smp_send_stop(), which
copes fine with fadump. The collateral effect was to increase the
risk for kdump if fadump is not used, since it forces all panic
notifiers to execute early, before kdump.

Happens that, after a panic refactor, crash_smp_send_stop() is
now used by default in the panic path, so there is no reason to
mess with the notifiers ordering (which was also improved in the
refactor) from within arch code.

Fixes: 06e629c25daa ("powerpc/fadump: Fix inaccurate CPU state info in vmcore generated with panic")
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Hari Bathini <hbathini@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

We'd like to thanks specially the MiniCloud infrastructure [0] maintainers,
that allow us to test PowerPC code in a very complete, functional and FREE
environment.

[0] https://openpower.ic.unicamp.br/minicloud

 arch/powerpc/kernel/fadump.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 65562c4a0a69..35ae8c09af66 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -1649,14 +1649,6 @@ int __init setup_fadump(void)
 		register_fadump();
 	}
 
-	/*
-	 * In case of panic, fadump is triggered via ppc_panic_event()
-	 * panic notifier. Setting crash_kexec_post_notifiers to 'true'
-	 * lets panic() function take crash friendly path before panic
-	 * notifiers are invoked.
-	 */
-	crash_kexec_post_notifiers = true;
-
 	return 1;
 }
 /*
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315614.534463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgw-0008Av-Jc; Wed, 27 Apr 2022 23:03:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315614.534463; Wed, 27 Apr 2022 23:03:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgu-0007yl-ME; Wed, 27 Apr 2022 23:03:24 +0000
Received: by outflank-mailman (input) for mailman id 315614;
 Wed, 27 Apr 2022 22:58:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqbr-000483-RS
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:58:11 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 82680692-c67d-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:58:11 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqbZ-0002Uv-Ai; Thu, 28 Apr 2022 00:57:53 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82680692-c67d-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=jupyQNOg8qT8hQfxmdiNJNMjaTUz/u9LiRmSHTNez6Y=; b=p7drin3mWpI9T0ZfMOO6eJj4J8
	Szpgonvq7i/v524yc5jBLpbigKUiUN0wy7/WDOnlytx03+FGgGN1Adqusl4cOO6PJlw+seakKl4N4
	fX95EDE8pbxBc/NNWRr732wIqJtKKX/BphsJRWnwXH/62I6x/BTA0R4L8cWEa/lku3Ma0ky8B2K89
	MQrzxBf2Hm8tnWC5d0fBkJ7uMzqRE/yfr9AAId6oRoN4APimw2mDpSMEi6ZVrVuwLoacCVsSTBNQz
	KQprHSNi9G6RdCXwUMjprlLz6QcEgqvhkAE50juvJF1BOQucBso5epBizOEqf+g5ZQam3KuAFn9x9
	BasVHnnQ==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org
Subject: [PATCH 28/30] panic: Unexport crash_kexec_post_notifiers
Date: Wed, 27 Apr 2022 19:49:22 -0300
Message-Id: <20220427224924.592546-29-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There is no users anymore of this variable that requires
it to be "exported" in the headers; also, it was deprecated
by the kernel parameter "panic_notifiers_level".

Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 include/linux/panic.h          | 2 --
 include/linux/panic_notifier.h | 1 -
 2 files changed, 3 deletions(-)

diff --git a/include/linux/panic.h b/include/linux/panic.h
index 34175d0188d0..d301db07a8af 100644
--- a/include/linux/panic.h
+++ b/include/linux/panic.h
@@ -34,8 +34,6 @@ extern int sysctl_panic_on_rcu_stall;
 extern int sysctl_max_rcu_stall_to_panic;
 extern int sysctl_panic_on_stackoverflow;
 
-extern bool crash_kexec_post_notifiers;
-
 /*
  * panic_cpu is used for synchronizing panic() and crash_kexec() execution. It
  * holds a CPU number which is executing panic() currently. A value of
diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
index b5041132321d..8fda7045e2f7 100644
--- a/include/linux/panic_notifier.h
+++ b/include/linux/panic_notifier.h
@@ -11,7 +11,6 @@ extern struct atomic_notifier_head panic_pre_reboot_list;
 extern struct atomic_notifier_head panic_post_reboot_list;
 
 bool panic_notifiers_before_kdump(void);
-extern bool crash_kexec_post_notifiers;
 
 enum panic_notifier_val {
 	PANIC_UNUSED,
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315616.534471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgy-0008WK-8A; Wed, 27 Apr 2022 23:03:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315616.534471; Wed, 27 Apr 2022 23:03:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgw-0008Oq-5B; Wed, 27 Apr 2022 23:03:26 +0000
Received: by outflank-mailman (input) for mailman id 315616;
 Wed, 27 Apr 2022 22:58:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqcQ-00048k-TI
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:58:46 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9737c674-c67d-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:58:45 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqcA-0002Wy-Ov; Thu, 28 Apr 2022 00:58:31 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9737c674-c67d-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=1b6nDa/yJFcG5pUH/mG+iUzFXWwemhBkCT22/YaOiO0=; b=IjS2asgso9SNyNWZZrj9YMv/6F
	3eZOrVvzgLxKKIoWELAWIZ9Y/f7MmYlHtb0XsZyDOudfDUF9WfHu+qH6xY14Mwj7EyQY5AwmQNe6v
	QY9uiwZxhZ2WIvN3bSO5hXV0+d77+K43N8ixpf942Orfv5mroywKkDY+GQFZJrgwqxcot4GD1q5St
	xIFh8Z0iJkBMhioashEH7Fwugdlgq5hENhZTnH6U/1cjnuHRdJ6m3FerTWr+GWqdP086mvnqcs/YS
	tVMBMJxDz0U3rAU8T7vP+Z25rbMa7jiyVQO7/s07AaONn+Kin25YyTFL/3tub+/wmWut7UZN8xzJW
	BauGVfjA==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>
Subject: [PATCH 29/30] powerpc: ps3, pseries: Avoid duplicate call to kmsg_dump() on panic
Date: Wed, 27 Apr 2022 19:49:23 -0300
Message-Id: <20220427224924.592546-30-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently both pseries and ps3 are platforms that define special
panic notifiers that run as callbacks inside powerpc generic panic
notifier. In both cases kmsg_dump() is called, and the reason seems
to be that both of these callbacks aims to effectively stop the
machine, so nothing would execute after that - hence, both force
a series of console flushing related operations, after calling
the kmsg dumpers.

Happens that recently the panic path was refactored, and now
kmsg_dump() is *certainly* called before the pre_reboot panic
notifiers, category in which both pseries/ps3 callbacks belong.
In other words: kmsg_dump() will execute twice in both platforms,
on panic path.

This patch prevents that by disabling the kmsg_dump() for both
platform's notifiers. But worth to notice that PowerNV still
has a legit use for executing kmsg_dump() in its unrecoverable
error path, so we rely in parameter passing to differentiate
both cases. Also, since the pre_reboot notifiers still run
earlier than console flushing routines, we kept that for
both pseries and ps3 platforms, only skipping kmsg_dump().

Fixes: 35adacd6fc48 ("powerpc/pseries, ps3: panic flush kernel messages before halting system")
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Hari Bathini <hbathini@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---

We'd like to thanks specially the MiniCloud infrastructure [0] maintainers,
that allow us to test PowerPC code in a very complete, functional and FREE
environment.

[0] https://openpower.ic.unicamp.br/minicloud

 arch/powerpc/include/asm/bug.h         | 2 +-
 arch/powerpc/kernel/traps.c            | 6 ++++--
 arch/powerpc/platforms/powernv/opal.c  | 2 +-
 arch/powerpc/platforms/ps3/setup.c     | 2 +-
 arch/powerpc/platforms/pseries/setup.c | 2 +-
 5 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h
index ecbae1832de3..49e5f6f86869 100644
--- a/arch/powerpc/include/asm/bug.h
+++ b/arch/powerpc/include/asm/bug.h
@@ -166,7 +166,7 @@ extern void die(const char *, struct pt_regs *, long);
 void die_mce(const char *str, struct pt_regs *regs, long err);
 extern bool die_will_crash(void);
 extern void panic_flush_kmsg_start(void);
-extern void panic_flush_kmsg_end(void);
+extern void panic_flush_kmsg_end(bool dump);
 #endif /* !__ASSEMBLY__ */
 
 #endif /* __KERNEL__ */
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index a08bb7cefdc5..837a5ed98d62 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -169,9 +169,11 @@ extern void panic_flush_kmsg_start(void)
 	bust_spinlocks(1);
 }
 
-extern void panic_flush_kmsg_end(void)
+extern void panic_flush_kmsg_end(bool dump)
 {
-	kmsg_dump(KMSG_DUMP_PANIC);
+	if (dump)
+		kmsg_dump(KMSG_DUMP_PANIC);
+
 	bust_spinlocks(0);
 	debug_locks_off();
 	console_flush_on_panic(CONSOLE_FLUSH_PENDING);
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 55a8fbfdb5b2..d172ceedece2 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -641,7 +641,7 @@ void __noreturn pnv_platform_error_reboot(struct pt_regs *regs, const char *msg)
 		show_regs(regs);
 	smp_send_stop();
 
-	panic_flush_kmsg_end();
+	panic_flush_kmsg_end(true);
 
 	/*
 	 * Don't bother to shut things down because this will
diff --git a/arch/powerpc/platforms/ps3/setup.c b/arch/powerpc/platforms/ps3/setup.c
index 3de9145c20bc..7cb78e508fb3 100644
--- a/arch/powerpc/platforms/ps3/setup.c
+++ b/arch/powerpc/platforms/ps3/setup.c
@@ -102,7 +102,7 @@ static void ps3_panic(char *str)
 	printk("   System does not reboot automatically.\n");
 	printk("   Please press POWER button.\n");
 	printk("\n");
-	panic_flush_kmsg_end();
+	panic_flush_kmsg_end(false);
 
 	while(1)
 		lv1_pause(1);
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index 955ff8aa1644..d6eea473eafd 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -856,7 +856,7 @@ static void __init pSeries_setup_arch(void)
 
 static void pseries_panic(char *str)
 {
-	panic_flush_kmsg_end();
+	panic_flush_kmsg_end(false);
 	rtas_os_term(str);
 }
 
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:03:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:03:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315618.534480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqh0-0000iY-DF; Wed, 27 Apr 2022 23:03:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315618.534480; Wed, 27 Apr 2022 23:03:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqgy-0000X1-Mj; Wed, 27 Apr 2022 23:03:28 +0000
Received: by outflank-mailman (input) for mailman id 315618;
 Wed, 27 Apr 2022 22:58:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mIOA=VF=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1njqcc-00048k-L0
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 22:58:58 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9e790fe4-c67d-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 00:58:58 +0200 (CEST)
Received: from [179.113.53.197] (helo=localhost)
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
 id 1njqcO-0002Xa-TN; Thu, 28 Apr 2022 00:58:45 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e790fe4-c67d-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
	Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
	Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
	:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=hhYlsUbOeU+dOwRnxPZPUYbOytvtm3s9TOl//oHNJDA=; b=d0jf6vbMLbNOzh0eGG9B6/Px+6
	qkEUtrYepm4ucy/4pLos0iQRqgjXbtzxxFn26kSmjojOKmseLi3xGvVq3y13qqT30NTY0kTvl6DKc
	b6KKl04amU0+oieZ13497T1EMR69awT+qjyjGwR4D5aTKq4vZpRUj+GzWZO2UZDfeYATrEMziknBs
	TEMzSmzx206U+K28hnKwrx3+IjpI8ZztfEqS39tmb441zpVb+KuDwyZTgdwShziC74jYqn49bnQHG
	y/bSqJ0agKp8q0sRXPRW98dnPCHObluazUbKWH8Sqc1S7wQ8dewAG//hvPY5MrIv8zVHDor3/GUxI
	SaUMFP1g==;
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	gpiccoli@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Richard Weinberger <richard@nod.at>
Subject: [PATCH 30/30] um: Avoid duplicate call to kmsg_dump()
Date: Wed, 27 Apr 2022 19:49:24 -0300
Message-Id: <20220427224924.592546-31-gpiccoli@igalia.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20220427224924.592546-1-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently the panic notifier panic_exit() calls kmsg_dump() and
some console flushing routines - this makes sense since such
panic notifier exits UserMode Linux and never returns.

Happens that after a panic refactor, kmsg_dump() is now always
called *before* the pre_reboot list of panic notifiers, in which
panic_exit() belongs, leading to a double call situation.

This patch changes that by removing such call from the panic
notifier, but leaving the console flushing calls since the
pre_reboot list still runs before console flushing on panic().

Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Richard Weinberger <richard@nod.at>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
---
 arch/um/kernel/um_arch.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index fc6e443299da..651310e3e86f 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -241,7 +241,6 @@ static void __init uml_postsetup(void)
 static int panic_exit(struct notifier_block *self, unsigned long unused1,
 		      void *unused2)
 {
-	kmsg_dump(KMSG_DUMP_PANIC);
 	bust_spinlocks(1);
 	bust_spinlocks(0);
 	uml_exitcode = 1;
-- 
2.36.0



From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:13:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:13:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315729.534524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqqf-0000Oz-6e; Wed, 27 Apr 2022 23:13:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315729.534524; Wed, 27 Apr 2022 23:13:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njqqf-0000Os-3r; Wed, 27 Apr 2022 23:13:29 +0000
Received: by outflank-mailman (input) for mailman id 315729;
 Wed, 27 Apr 2022 23:13:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OIub=VF=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1njqqe-0000Om-E1
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 23:13:28 +0000
Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com
 [2a00:1450:4864:20::436])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4d5ed33-c67f-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 01:13:27 +0200 (CEST)
Received: by mail-wr1-x436.google.com with SMTP id u3so4474989wrg.3
 for <xen-devel@lists.xenproject.org>; Wed, 27 Apr 2022 16:13:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4d5ed33-c67f-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=SxiiRmMl5WBejmvqm2h9HANsI9aHhNewk5E5NijQr/o=;
        b=eivdzjr+bvYej3sqsPZTpahW99j1DDGQYv/x4hZi7RboztnxvKQ7F2tpzNqXB+l5qM
         ZYR1c25lB4TT0S+wSUnkLjdqsxlO2YnKAMVgChdzU84WdV49uGCQk6jJZh7nAxQnkf5b
         B0h+IPMup6u3hUC0R/Uz8qD5CWR4B7DVSrCOVhf75V2vluZ5xkLN6Xazj/kubgFQrOIQ
         35aK4WnVNMB+V+Y5c8Mpc2WKlflluuN3abRG0hpR5R6pOpRT5tfwuF3+Bc+Kkz1tCIpt
         HgOCSQgLZKTZmceJ1gdImMJREsuHsKB/4bQ8GchufK4NTq9QXORI7dnMX/iqrl68Ez89
         TI8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=SxiiRmMl5WBejmvqm2h9HANsI9aHhNewk5E5NijQr/o=;
        b=jpdpnFtFQOivKEm3HJEplrvAh4tCjiz1cXAOpDMuO5RVPJENGhweGYWVqL5hPxFLwO
         ZzLsdEAnn+kVN54Vngo5IYhgIn+erit1QQuTmOWHIyAki+q4fnsCD6aPaDg6udoGq37B
         VV2SQ4LmeP/UVXm0Turbtn4GektWJ/Fit5ZYIyw+DbiyichkkOE0BrdfK6ot+TMOtR2m
         B6dbYfb8d0jyddy8rYrPP0h8E6bLNAkcLeCfakCNvreg/hJRFqfynGvvqy1fPdUA3VK1
         X126tZZ9V/5nhRo5B3qlGF+EoYT6mGkjfS1t+2GGuZzNk0FC1j+9ava1nBdKQ0X37NxK
         o9aA==
X-Gm-Message-State: AOAM530zkIt7p34Ze/5GxB+4rvND0jGJkiskLHCnkEMgdWMB+Jk2TTT+
	C9QEih/yLQHQd1B0oCtx1BN7FkncR/DnAcNqItQ=
X-Google-Smtp-Source: ABdhPJy9FOnAe4DIcaJl8HsJwgR7U2znP40WqNsmOLagkLtS7SLE73VR7AXDPptJEB++DH7ueAUKVIVEVZIDWRx1Uf4=
X-Received: by 2002:a5d:4645:0:b0:20a:db5d:258f with SMTP id
 j5-20020a5d4645000000b0020adb5d258fmr13708827wrs.135.1651101206642; Wed, 27
 Apr 2022 16:13:26 -0700 (PDT)
MIME-Version: 1.0
References: <osstest-169781-mainreport@xen.org> <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
 <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Thu, 28 Apr 2022 00:13:15 +0100
Message-ID: <CAJ=z9a1bu=3sX0rvWy+T-ey4363DMUEJvzkSqkQkTnvOQtT0=A@mail.gmail.com>
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: osstest service owner <osstest-admin@xenproject.org>, 
	xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>, 
	David Vrabel <dvrabel@amazon.co.uk>, Bertrand Marquis <bertrand.marquis@arm.com>
Content-Type: multipart/alternative; boundary="000000000000e9040605ddaaf45e"

--000000000000e9040605ddaaf45e
Content-Type: text/plain; charset="UTF-8"

Hi Stefano,

On Thu, 28 Apr 2022, 00:02 Stefano Stabellini, <sstabellini@kernel.org>
wrote

> It seems to me that it is acceptable to allocate memory with interrupt
> disabled during __init. I cannot see any drawbacks with it. I think we
> should change the ASSERT to only trigger after __init: system_state ==
> SYS_STATE_active.
>
> What do you think?
>

This would solve the immediate problem but not the long term one (i.e cpu
hotplug).

So I think it would be better to properly fix it right away.

Cheers,

>

--000000000000e9040605ddaaf45e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Hi Stefano,<br><br><div class=3D"gmail_quote"><div d=
ir=3D"ltr" class=3D"gmail_attr">On Thu, 28 Apr 2022, 00:02 Stefano Stabelli=
ni, &lt;<a href=3D"mailto:sstabellini@kernel.org">sstabellini@kernel.org</a=
>&gt; wrote</div></div></div><div dir=3D"auto"><div class=3D"gmail_quote"><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex">
It seems to me that it is acceptable to allocate memory with interrupt<br>
disabled during __init. I cannot see any drawbacks with it. I think we<br>
should change the ASSERT to only trigger after __init: system_state =3D=3D<=
br>
SYS_STATE_active.<br>
<br>
What do you think?<br></blockquote></div></div><div dir=3D"auto"><br></div>=
<div dir=3D"auto">This would solve the immediate problem but not the long t=
erm one (i.e cpu hotplug).</div><div dir=3D"auto"><br></div><div dir=3D"aut=
o">So I think it would be better to properly fix it right away.</div><div d=
ir=3D"auto"><br></div><div dir=3D"auto">Cheers,</div><div dir=3D"auto"><div=
 class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 =
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--000000000000e9040605ddaaf45e--


From xen-devel-bounces@lists.xenproject.org Wed Apr 27 23:50:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Apr 2022 23:50:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315860.534535 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njrQ0-00044H-RA; Wed, 27 Apr 2022 23:50:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315860.534535; Wed, 27 Apr 2022 23:50:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njrQ0-00044A-N0; Wed, 27 Apr 2022 23:50:00 +0000
Received: by outflank-mailman (input) for mailman id 315860;
 Wed, 27 Apr 2022 23:50:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GCuR=VF=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org>)
 id 1njrQ0-000444-1U
 for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 23:50:00 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id be12a680-c684-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 01:49:57 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id DB40461EF7;
 Wed, 27 Apr 2022 23:49:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16778C385A9;
 Wed, 27 Apr 2022 23:49:55 +0000 (UTC)
Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000)
 id AA5975C0B07; Wed, 27 Apr 2022 16:49:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be12a680-c684-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651103395;
	bh=fUZjHYw9wwKZPDJTueMs+O0QpaDcmLmJGnfVK2U9fDA=;
	h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From;
	b=Je1aB/fze7iTbiS9iJu+ljdypRVlpSNOY2ApvQuQXPIJMcX561LCqFU5KD8NuzITn
	 axVegyGDng/no5zGX+N0XJaBX3eCl1u+MBfsPPSUCnAku/LeQQoNnLn0h3GPux3yBk
	 VOvYDvtIfUvjSSlCqhYbS9JVxA2AV5YZM/HgUioKVWSI+XcWSCErb9jz9UvrxK1pys
	 vStoYHEo4wQDcrF+2d88fEDoby5J66HLtUmYbV1qTrDo2OoFmaqWJaLLn5LoRnwbLY
	 cyOzSoD9WN0tR37CmdZFeQgXzlz5t3Jm6TM/uEaGXtF/lFjZIjpGv2bt25uLPFk53d
	 hyeP1plId9baA==
Date: Wed, 27 Apr 2022 16:49:54 -0700
From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org, sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
	fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
	corbet@lwn.net, d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com,
	gregkh@linuxfoundation.org, mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
	john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
	mhiramat@kernel.org, mingo@redhat.com, peterz@infradead.org,
	rostedt@goodmis.org, senozhatsky@chromium.org,
	stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
	vkuznets@redhat.com, will@kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Leo Yan <leo.yan@linaro.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Mike Leach <mike.leach@linaro.org>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Neeraj Upadhyay <quic_neeraju@quicinc.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 20/30] panic: Add the panic informational notifier list
Message-ID: <20220427234954.GA3204792@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-21-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220427224924.592546-21-gpiccoli@igalia.com>

On Wed, Apr 27, 2022 at 07:49:14PM -0300, Guilherme G. Piccoli wrote:
> The goal of this new panic notifier is to allow its users to
> register callbacks to run earlier in the panic path than they
> currently do. This aims at informational mechanisms, like dumping
> kernel offsets and showing device error data (in case it's simple
> registers reading, for example) as well as mechanisms to disable
> log flooding (like hung_task detector / RCU warnings) and the
> tracing dump_on_oops (when enabled).
> 
> Any (non-invasive) information that should be provided before
> kmsg_dump() as well as log flooding preventing code should fit
> here, as long it offers relatively low risk for kdump.
> 
> For now, the patch is almost a no-op, although it changes a bit
> the ordering in which some panic notifiers are executed - specially
> affected by this are the notifiers responsible for disabling the
> hung_task detector / RCU warnings, which now run first. In a
> subsequent patch, the panic path will be refactored, then the
> panic informational notifiers will effectively run earlier,
> before ksmg_dump() (and usually before kdump as well).
> 
> We also defer documenting it all properly in the subsequent
> refactor patch. Finally, while at it, we removed some useless
> header inclusions too.
> 
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Frederic Weisbecker <frederic@kernel.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Hari Bathini <hbathini@linux.ibm.com>
> Cc: Joel Fernandes <joel@joelfernandes.org>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: Neeraj Upadhyay <quic_neeraju@quicinc.com>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>

>From an RCU perspective:

Acked-by: Paul E. McKenney <paulmck@kernel.org>

> ---
>  arch/arm64/kernel/setup.c                         | 2 +-
>  arch/mips/kernel/relocate.c                       | 2 +-
>  arch/powerpc/kernel/setup-common.c                | 2 +-
>  arch/x86/kernel/setup.c                           | 2 +-
>  drivers/bus/brcmstb_gisb.c                        | 2 +-
>  drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 ++--
>  drivers/soc/tegra/ari-tegra186.c                  | 3 ++-
>  include/linux/panic_notifier.h                    | 1 +
>  kernel/hung_task.c                                | 3 ++-
>  kernel/panic.c                                    | 4 ++++
>  kernel/rcu/tree.c                                 | 1 -
>  kernel/rcu/tree_stall.h                           | 3 ++-
>  kernel/trace/trace.c                              | 2 +-
>  13 files changed, 19 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 3505789cf4bd..ac2c7e8c9c6a 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -444,7 +444,7 @@ static struct notifier_block arm64_panic_block = {
>  
>  static int __init register_arm64_panic_block(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_info_list,
>  				       &arm64_panic_block);
>  	return 0;
>  }
> diff --git a/arch/mips/kernel/relocate.c b/arch/mips/kernel/relocate.c
> index 56b51de2dc51..650811f2436a 100644
> --- a/arch/mips/kernel/relocate.c
> +++ b/arch/mips/kernel/relocate.c
> @@ -459,7 +459,7 @@ static struct notifier_block kernel_location_notifier = {
>  
>  static int __init register_kernel_offset_dumper(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_info_list,
>  				       &kernel_location_notifier);
>  	return 0;
>  }
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 1468c3937bf4..d04b8bf8dbc7 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -757,7 +757,7 @@ void __init setup_panic(void)
>  				       &ppc_fadump_block);
>  
>  	if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && kaslr_offset() > 0)
> -		atomic_notifier_chain_register(&panic_notifier_list,
> +		atomic_notifier_chain_register(&panic_info_list,
>  					       &kernel_offset_notifier);
>  
>  	/* Low-level platform-specific routines that should run on panic */
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index c95b9ac5a457..599b25346964 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -1266,7 +1266,7 @@ static struct notifier_block kernel_offset_notifier = {
>  
>  static int __init register_kernel_offset_dumper(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_info_list,
>  					&kernel_offset_notifier);
>  	return 0;
>  }
> diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
> index 1ea7b015e225..c64e087fba7a 100644
> --- a/drivers/bus/brcmstb_gisb.c
> +++ b/drivers/bus/brcmstb_gisb.c
> @@ -486,7 +486,7 @@ static int __init brcmstb_gisb_arb_probe(struct platform_device *pdev)
>  
>  	if (list_is_singular(&brcmstb_gisb_arb_device_list)) {
>  		register_die_notifier(&gisb_die_notifier);
> -		atomic_notifier_chain_register(&panic_notifier_list,
> +		atomic_notifier_chain_register(&panic_info_list,
>  					       &gisb_panic_notifier);
>  	}
>  
> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> index 1874df7c6a73..7b1012454525 100644
> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> @@ -535,7 +535,7 @@ static int debug_func_init(void)
>  			    &debug_func_knob_fops);
>  
>  	/* Register function to be called for panic */
> -	ret = atomic_notifier_chain_register(&panic_notifier_list,
> +	ret = atomic_notifier_chain_register(&panic_info_list,
>  					     &debug_notifier);
>  	if (ret) {
>  		pr_err("%s: unable to register notifier: %d\n",
> @@ -552,7 +552,7 @@ static int debug_func_init(void)
>  
>  static void debug_func_exit(void)
>  {
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> +	atomic_notifier_chain_unregister(&panic_info_list,
>  					 &debug_notifier);
>  	debugfs_remove_recursive(debug_debugfs_dir);
>  }
> diff --git a/drivers/soc/tegra/ari-tegra186.c b/drivers/soc/tegra/ari-tegra186.c
> index 02577853ec49..4ef05ebed739 100644
> --- a/drivers/soc/tegra/ari-tegra186.c
> +++ b/drivers/soc/tegra/ari-tegra186.c
> @@ -73,7 +73,8 @@ static struct notifier_block tegra186_ari_panic_nb = {
>  static int __init tegra186_ari_init(void)
>  {
>  	if (of_machine_is_compatible("nvidia,tegra186"))
> -		atomic_notifier_chain_register(&panic_notifier_list, &tegra186_ari_panic_nb);
> +		atomic_notifier_chain_register(&panic_info_list,
> +					       &tegra186_ari_panic_nb);
>  
>  	return 0;
>  }
> diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
> index 0bb9dc0dea04..7364a346bcb0 100644
> --- a/include/linux/panic_notifier.h
> +++ b/include/linux/panic_notifier.h
> @@ -7,6 +7,7 @@
>  
>  extern struct atomic_notifier_head panic_notifier_list;
>  extern struct atomic_notifier_head panic_hypervisor_list;
> +extern struct atomic_notifier_head panic_info_list;
>  
>  extern bool crash_kexec_post_notifiers;
>  
> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
> index 52501e5f7655..1b2d7111d5ac 100644
> --- a/kernel/hung_task.c
> +++ b/kernel/hung_task.c
> @@ -85,6 +85,7 @@ hung_task_panic(struct notifier_block *this, unsigned long event, void *ptr)
>  
>  static struct notifier_block panic_block = {
>  	.notifier_call = hung_task_panic,
> +	.priority = INT_MAX, /* run early to prevent potential log flood */
>  };
>  
>  static void check_hung_task(struct task_struct *t, unsigned long timeout)
> @@ -378,7 +379,7 @@ static int watchdog(void *dummy)
>  
>  static int __init hung_task_init(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
> +	atomic_notifier_chain_register(&panic_info_list, &panic_block);
>  
>  	/* Disable hung task detector on suspend */
>  	pm_notifier(hungtask_pm_notify, 0);
> diff --git a/kernel/panic.c b/kernel/panic.c
> index ef76f3f9c44d..73ca1bc44e30 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -76,6 +76,9 @@ EXPORT_SYMBOL(panic_notifier_list);
>  ATOMIC_NOTIFIER_HEAD(panic_hypervisor_list);
>  EXPORT_SYMBOL(panic_hypervisor_list);
>  
> +ATOMIC_NOTIFIER_HEAD(panic_info_list);
> +EXPORT_SYMBOL(panic_info_list);
> +
>  static long no_blink(int state)
>  {
>  	return 0;
> @@ -291,6 +294,7 @@ void panic(const char *fmt, ...)
>  	 * add information to the kmsg dump output.
>  	 */
>  	atomic_notifier_call_chain(&panic_hypervisor_list, PANIC_NOTIFIER, buf);
> +	atomic_notifier_call_chain(&panic_info_list, PANIC_NOTIFIER, buf);
>  	atomic_notifier_call_chain(&panic_notifier_list, PANIC_NOTIFIER, buf);
>  
>  	panic_print_sys_info(false);
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index a4b8189455d5..d5a2674ae81c 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -35,7 +35,6 @@
>  #include <linux/panic.h>
>  #include <linux/panic_notifier.h>
>  #include <linux/percpu.h>
> -#include <linux/notifier.h>
>  #include <linux/cpu.h>
>  #include <linux/mutex.h>
>  #include <linux/time.h>
> diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
> index 0c5d8516516a..d8a5840aad5d 100644
> --- a/kernel/rcu/tree_stall.h
> +++ b/kernel/rcu/tree_stall.h
> @@ -97,11 +97,12 @@ static int rcu_panic(struct notifier_block *this, unsigned long ev, void *ptr)
>  
>  static struct notifier_block rcu_panic_block = {
>  	.notifier_call = rcu_panic,
> +	.priority = INT_MAX, /* run early to prevent potential log flood */
>  };
>  
>  static int __init check_cpu_stall_init(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list, &rcu_panic_block);
> +	atomic_notifier_chain_register(&panic_info_list, &rcu_panic_block);
>  	return 0;
>  }
>  early_initcall(check_cpu_stall_init);
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index c1d8a3622ccc..7d02f7a66bb1 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -10138,7 +10138,7 @@ __init static int tracer_alloc_buffers(void)
>  	/* All seems OK, enable tracing */
>  	tracing_disabled = 0;
>  
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_info_list,
>  				       &trace_panic_notifier);
>  
>  	register_die_notifier(&trace_die_notifier);
> -- 
> 2.36.0
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 00:03:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 00:03:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315867.534546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njrcp-00071U-EN; Thu, 28 Apr 2022 00:03:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315867.534546; Thu, 28 Apr 2022 00:03:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njrcp-00071N-BO; Thu, 28 Apr 2022 00:03:15 +0000
Received: by outflank-mailman (input) for mailman id 315867;
 Thu, 28 Apr 2022 00:03:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njrcn-00071D-FS; Thu, 28 Apr 2022 00:03:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njrcn-0002Bv-AS; Thu, 28 Apr 2022 00:03:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njrcm-0001rU-R8; Thu, 28 Apr 2022 00:03:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njrcm-0000tK-Qg; Thu, 28 Apr 2022 00:03:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xglYBCxYeAdf3bUr2k67UiL71H28XHRpz1cnQmhWLg8=; b=g4JKDhKi6xVmneTYcPza7LO4a7
	bYvNnB2mIf43tOM3EV9SWRMh07gl3jsKbnSAJkc8HoWxz9xEUD0ruHt7KGLBEn1x16yjhu6QZxeom
	qsvqZyzQSkUTBLL1rEmyN70DMf74/R1H5xH/M1hqS0r0XotmNYkY0t+WLwdo/iY0I+JI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169779-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169779: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=34723f59371f3fd02ea59b94674314b875504426
X-Osstest-Versions-That:
    qemuu=a72d9008092e39c2c37e47a91bae4e170d0f1b33
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 00:03:12 +0000

flight 169779 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169779/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169762
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169762
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169762
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169762
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169762
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169762
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169762
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169762
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                34723f59371f3fd02ea59b94674314b875504426
baseline version:
 qemuu                a72d9008092e39c2c37e47a91bae4e170d0f1b33

Last test of basis   169762  2022-04-27 01:08:27 Z    0 days
Testing same since   169779  2022-04-27 10:34:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   a72d900809..34723f5937  34723f59371f3fd02ea59b94674314b875504426 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 00:15:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 00:15:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315875.534558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njrp0-0008Vf-KU; Thu, 28 Apr 2022 00:15:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315875.534558; Thu, 28 Apr 2022 00:15:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njrp0-0008VY-HW; Thu, 28 Apr 2022 00:15:50 +0000
Received: by outflank-mailman (input) for mailman id 315875;
 Thu, 28 Apr 2022 00:15:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njroz-0008VO-RA; Thu, 28 Apr 2022 00:15:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njroz-0002PL-Nx; Thu, 28 Apr 2022 00:15:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njroz-0002Mx-BC; Thu, 28 Apr 2022 00:15:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njroz-0008Pd-Ai; Thu, 28 Apr 2022 00:15:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=44eJwJLK5BslIVzzixDS/ibZYESmqi5a4FD55iTZm5Y=; b=L6szm+1JRtVFjFpe5TTE3fU9jW
	96dWktRdqyHbWChsXyjYcCENrAHF5P7rXjA9jYbM1Ux5rjZled7/9UrHp99hWd4Upr7UD4aCRAFT+
	65PAFnzy4rjeBlmT0zAH+kx2NqdvoJoEyHe/rAPv9sqXDhEoVoW+/HjAYzVahmMmJmls=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169799-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169799: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 00:15:49 +0000

flight 169799 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169799/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  669 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   41 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 00:29:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 00:29:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315887.534569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njs21-0001bf-Rs; Thu, 28 Apr 2022 00:29:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315887.534569; Thu, 28 Apr 2022 00:29:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njs21-0001bY-Om; Thu, 28 Apr 2022 00:29:17 +0000
Received: by outflank-mailman (input) for mailman id 315887;
 Thu, 28 Apr 2022 00:29:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SQtA=VG=infradead.org=rdunlap@srs-se1.protection.inumbo.net>)
 id 1njs1z-0001bS-VW
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 00:29:17 +0000
Received: from casper.infradead.org (casper.infradead.org
 [2001:8b0:10b:1236::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3a603863-c68a-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 02:29:13 +0200 (CEST)
Received: from [2601:1c0:6280:3f0::aa0b]
 by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1njs1D-00B2Sy-UA; Thu, 28 Apr 2022 00:28:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a603863-c68a-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type:
	In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender
	:Reply-To:Content-ID:Content-Description;
	bh=oTHdXx/bNqvs0tUKZg1jX0QKDhKts3seYpf9QVBefoo=; b=GN1/nse5iki/WFV8HZE7gnZx8M
	eJUoKq0F73m9M9r3NgIBqsY0+vw93A0bLY3hZk7W2z6ntNRxf9y3czUAh8lb6xtyiL6iRkCGoMbr3
	13t311Tat608CEGCcNXVW95sxa2A683FvRnnoYsLI49dqQLiYKn/y05pL/vMxI0Bf3XOAu94o11W+
	nn9qk8zdTyrvuFjTnWtZ6o7af2OgOBH9Lb3syZMjRdfGkSipXa4zeUfKnDbho+LORacM3SyNN4LMV
	DjLIUchKFzC9+E73n2pj1o853yXO/ZfWMQcrLme864qTb5ygY07AwvTErV57FcFGuv7kOYC61ZuBl
	QQvKsP1Q==;
Message-ID: <4fe85e9c-4e96-e9d5-9fd8-f062bafcda4f@infradead.org>
Date: Wed, 27 Apr 2022 17:28:11 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 24/30] panic: Refactor the panic path
Content-Language: en-US
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-25-gpiccoli@igalia.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220427224924.592546-25-gpiccoli@igalia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit



On 4/27/22 15:49, Guilherme G. Piccoli wrote:
> +	crash_kexec_post_notifiers
> +			This was DEPRECATED - users should always prefer the

			This is DEPRECATED - users should always prefer the

> +			parameter "panic_notifiers_level" - check its entry
> +			in this documentation for details on how it works.
> +			Setting this parameter is exactly the same as setting
> +			"panic_notifiers_level=4".

-- 
~Randy


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 00:47:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 00:47:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315895.534579 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njsJy-000412-Gx; Thu, 28 Apr 2022 00:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315895.534579; Thu, 28 Apr 2022 00:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njsJy-00040v-E4; Thu, 28 Apr 2022 00:47:50 +0000
Received: by outflank-mailman (input) for mailman id 315895;
 Thu, 28 Apr 2022 00:47:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NTp2=VG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1njsJx-00040p-Av
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 00:47:49 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d2c5253e-c68c-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 02:47:48 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D344561F17;
 Thu, 28 Apr 2022 00:47:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACA0CC385A9;
 Thu, 28 Apr 2022 00:47:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2c5253e-c68c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651106866;
	bh=3+gJ4Ng4DtJIAMyvKT20XOPQNDT7Tze15FEwFqKjeog=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dPFlWjkVJEZRA5gheen+n/ly97LwLx+GLO+H32yOrf9n3YFWZYe1yFJ+0S17ZZyiL
	 bf2peYekMwHeOt1sB8W36YKAUG3lC59meD4Fflf72e5n+WOcjMvLZrfN8qkYhNf0l2
	 JH3Z27WUSSaAv9DetBQ33V80rkpMALrowSUWgehoPVYbbqW94mjFc9XoSe3AVOcuxE
	 p6YihAIEeYJ1i1oHLuXGml0d/EuxOfX9qQLzHPCtWqtgkvbIgf8XqSGr5GdqCnkvcB
	 EPPIvFTTOyzt7BjG6wordqK7G47YzKuCA8OUgtk4dmilwK1hXt1kf9oOMVIRGaGKE2
	 kriCN4ZhiYmVg==
Date: Wed, 27 Apr 2022 17:47:45 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien.grall.oss@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    osstest service owner <osstest-admin@xenproject.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, David Vrabel <dvrabel@amazon.co.uk>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
In-Reply-To: <CAJ=z9a1bu=3sX0rvWy+T-ey4363DMUEJvzkSqkQkTnvOQtT0=A@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204271622520.915916@ubuntu-linux-20-04-desktop>
References: <osstest-169781-mainreport@xen.org> <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org> <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop> <CAJ=z9a1bu=3sX0rvWy+T-ey4363DMUEJvzkSqkQkTnvOQtT0=A@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 28 Apr 2022, Julien Grall wrote:
> Hi Stefano,
> 
> On Thu, 28 Apr 2022, 00:02 Stefano Stabellini, <sstabellini@kernel.org> wrote
>       It seems to me that it is acceptable to allocate memory with interrupt
>       disabled during __init. I cannot see any drawbacks with it. I think we
>       should change the ASSERT to only trigger after __init: system_state ==
>       SYS_STATE_active.
> 
>       What do you think?
> 
> 
> This would solve the immediate problem but not the long term one (i.e cpu hotplug).
> 
> So I think it would be better to properly fix it right away.

Yeah, you are right about cpu hotplug. I think both statements are true:

- it is true that this is supposed to work with cpu hotplug and these
  functions might be directly affected by cpu hotplug (by a CPU coming
  online later on)

- it is also true that it might not make sense to ASSERT at __init time
  if IRQs are disabled. There might be other places, not affected by cpu
  hotplug, where we do memory allocation at __init time with IRQ
  disabled. It might still be a good idea to add the system_state ==
  SYS_STATE_active check in the ASSERT, not to solve this specific
  problem but to avoid other issues.


In regard to gicv3_lpi_allocate_pendtable, I haven't thought about the
implications of cpu hotplug for LPIs and GICv3 before. Do you envision
that in a CPU hotplug scenario gicv3_lpi_init_rdist would be called when
the extra CPU comes online?

Today gicv3_lpi_init_rdist is called based on the number of
rdist_regions without checking if the CPU is online or offline (I think ?)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 01:29:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 01:29:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315903.534590 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njsxw-0006Uz-Mk; Thu, 28 Apr 2022 01:29:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315903.534590; Thu, 28 Apr 2022 01:29:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njsxw-0006Us-Js; Thu, 28 Apr 2022 01:29:08 +0000
Received: by outflank-mailman (input) for mailman id 315903;
 Thu, 28 Apr 2022 01:29:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njsxv-0006Ui-6t; Thu, 28 Apr 2022 01:29:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njsxv-0001S1-3z; Thu, 28 Apr 2022 01:29:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njsxu-0006EL-5K; Thu, 28 Apr 2022 01:29:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njsxu-00064D-4q; Thu, 28 Apr 2022 01:29:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9zZeE4gn2GmRJcNUhDldWVGN2XpcOUk3qlFT1Bzg+I8=; b=64FG7apK98sQinltpnmjOjShIw
	7v8r1OVopKcTK4D9o9rhv8ylnNroAvxoJmBHIOZYTuy5GyIkSrR0XREXYyO/TGyehkXekOHLlnma7
	yXlX5jLaUBUt6sSWCqumB0eo4i2NL0zLqmL0jKOd0u8CwA/06KKdGdeJ23PmtSvPTRR8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169802-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169802: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 01:29:06 +0000

flight 169802 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169802/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   57 days  670 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   42 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 03:00:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 03:00:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315915.534602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njuOQ-0007us-Fk; Thu, 28 Apr 2022 03:00:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315915.534602; Thu, 28 Apr 2022 03:00:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njuOQ-0007uk-9C; Thu, 28 Apr 2022 03:00:34 +0000
Received: by outflank-mailman (input) for mailman id 315915;
 Thu, 28 Apr 2022 03:00:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njuOO-0007ua-Ol; Thu, 28 Apr 2022 03:00:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njuOO-0003PT-Ni; Thu, 28 Apr 2022 03:00:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njuOO-0003Ro-BK; Thu, 28 Apr 2022 03:00:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njuOO-0003sb-As; Thu, 28 Apr 2022 03:00:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7AFjWeHuLAJz/eGbJXo5OWXpoIhpLnZn6rswrMtvWWI=; b=DFnDowfIxigWDCOBwZ5c6NYwBa
	jVYFHcYsbEukeNFnKpeDSAT5mOdUN9HSj3k1y2UEpWDL+S/X/RDzX9wqzGD4A/LyDLlsSmDfKXhD/
	ENrHOwxX9PhcE5fGeZe9IjZYASSPjqUN9n365z7WVrkwmoP5KVHFsWEsaiQ2ds18l9D4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169800-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169800: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=da28439ba55b8a571032b3358af567cff749f612
X-Osstest-Versions-That:
    xen=53b705d02cec03861044e673536586bd1b2443bd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 03:00:32 +0000

flight 169800 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169800/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  da28439ba55b8a571032b3358af567cff749f612
baseline version:
 xen                  53b705d02cec03861044e673536586bd1b2443bd

Last test of basis   169788  2022-04-27 17:01:44 Z    0 days
Testing same since   169800  2022-04-27 23:01:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dario Faggioli <dfaggioli@suse.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   53b705d02c..da28439ba5  da28439ba55b8a571032b3358af567cff749f612 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 03:02:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 03:02:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315923.534613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njuQH-0008V0-P1; Thu, 28 Apr 2022 03:02:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315923.534613; Thu, 28 Apr 2022 03:02:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njuQH-0008Ut-Lr; Thu, 28 Apr 2022 03:02:29 +0000
Received: by outflank-mailman (input) for mailman id 315923;
 Thu, 28 Apr 2022 03:02:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lwC7=VG=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njuQH-0008Un-Bo
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 03:02:29 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id a2931191-c69f-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 05:02:27 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93620ED1;
 Wed, 27 Apr 2022 20:02:26 -0700 (PDT)
Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com
 [10.169.190.94])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 454F43F774;
 Wed, 27 Apr 2022 20:02:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2931191-c69f-11ec-8fc3-03012f2f19d4
From: Penny Zheng <Penny.Zheng@arm.com>
To: xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com,
	Penny Zheng <Penny.Zheng@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Penny Zheng <penny.zheng@arm.com>
Subject: [PATCH v3 1/6] xen: do not free reserved memory into heap
Date: Thu, 28 Apr 2022 11:01:27 +0800
Message-Id: <20220428030127.998670-1-Penny.Zheng@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Pages used as guest RAM for static domain, shall be reserved to this
domain only.
So in case reserved pages being used for other purpose, users
shall not free them back to heap, even when last ref gets dropped.

free_staticmem_pages will be called by free_heap_pages in runtime
for static domain freeing memory resource, so let's drop the __init
flag.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
This is a reissued commit for patch serie "populate/unpopulate memory when 
domain on static allocation"(
https://patchwork.kernel.org/project/xen-devel/list/?series=636094).
This commit has been held by mail server, so sorry about that and also sorry
about this commit couldn't stay in the same thread with the others.
---
v3 changes:
- fix possible racy issue in free_staticmem_pages()
- introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case
- move the change to free_heap_pages() to cover other potential call sites
- fix the indentation
---
v2 changes:
- new commit
---
 xen/common/page_alloc.c | 17 ++++++++++++++---
 xen/include/xen/mm.h    |  2 +-
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..5e569a48a2 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1443,6 +1443,10 @@ static void free_heap_pages(
 
     ASSERT(order <= MAX_ORDER);
 
+    if ( pg->count_info & PGC_reserved )
+        /* Reserved page shall not go back to the heap. */
+        return free_staticmem_pages(pg, 1UL << order, need_scrub);
+
     spin_lock(&heap_lock);
 
     for ( i = 0; i < (1 << order); i++ )
@@ -2636,8 +2640,8 @@ struct domain *get_pg_owner(domid_t domid)
 
 #ifdef CONFIG_STATIC_MEMORY
 /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */
-void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
-                                 bool need_scrub)
+void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
+                          bool need_scrub)
 {
     mfn_t mfn = page_to_mfn(pg);
     unsigned long i;
@@ -2653,7 +2657,8 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
         }
 
         /* In case initializing page of static memory, mark it PGC_reserved. */
-        pg[i].count_info |= PGC_reserved;
+        if ( !(pg[i].count_info & PGC_reserved) )
+            pg[i].count_info |= PGC_reserved;
     }
 }
 
@@ -2762,6 +2767,12 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn,
 
     return 0;
 }
+#else
+void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
+                          bool need_scrub)
+{
+    ASSERT_UNREACHABLE();
+}
 #endif
 
 /*
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index 3be754da92..9fd95deaec 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -85,10 +85,10 @@ bool scrub_free_pages(void);
 } while ( false )
 #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0)
 
-#ifdef CONFIG_STATIC_MEMORY
 /* These functions are for static memory */
 void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
                           bool need_scrub);
+#ifdef CONFIG_STATIC_MEMORY
 int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns,
                             unsigned int memflags);
 #endif
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 03:10:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 03:10:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315933.534624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njuXU-0000nO-Hy; Thu, 28 Apr 2022 03:09:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315933.534624; Thu, 28 Apr 2022 03:09:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njuXU-0000nH-EG; Thu, 28 Apr 2022 03:09:56 +0000
Received: by outflank-mailman (input) for mailman id 315933;
 Thu, 28 Apr 2022 03:09:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lwC7=VG=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1njuXS-0000nB-To
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 03:09:55 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on062b.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::62b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac250a2b-c6a0-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 05:09:53 +0200 (CEST)
Received: from AM6PR04CA0052.eurprd04.prod.outlook.com (2603:10a6:20b:f0::29)
 by AM5PR0802MB2388.eurprd08.prod.outlook.com (2603:10a6:203:9f::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 28 Apr
 2022 03:09:50 +0000
Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:f0:cafe::65) by AM6PR04CA0052.outlook.office365.com
 (2603:10a6:20b:f0::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend
 Transport; Thu, 28 Apr 2022 03:09:50 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Thu, 28 Apr 2022 03:09:49 +0000
Received: ("Tessian outbound 2d401af10eb3:v118");
 Thu, 28 Apr 2022 03:09:49 +0000
Received: from 739725c40aa1.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1B7858F6-DAD2-40B9-AB8E-C9F2F54D25FC.1; 
 Thu, 28 Apr 2022 03:09:42 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 739725c40aa1.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 28 Apr 2022 03:09:42 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by PA4PR08MB6287.eurprd08.prod.outlook.com (2603:10a6:102:ef::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 03:09:40 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::a02d:1e5a:41b8:8635%9]) with mapi id 15.20.5186.021; Thu, 28 Apr 2022
 03:09:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac250a2b-c6a0-11ec-8fc3-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=f6JVItza79fDmpaIW/KjZs1fhKyLzRn3FDnwFTbY2sWoquzF02w6bgLtAPFA352uAUeXW7EhBLomV/h4oU2lLAUrZsxlWRznboiv4JrJ+bwmQOCBedYjl6w3cFmQOyS8u3Qz+a8pWHLM/vptvQ/ak9Fp1LyJ3whaFF1gY0ZXfYOyN7VLYNkqoj2qE0kau8Vj1LF/gKhy2v1BCajpFVW4Uldt2XjYYumj7ZcBOIcTSlhfHQJB3bcmv91gkxbsoWUWQ3GicmlDQOMWE50mNyiTVPaH22u2ap1l+wbr0ULUMn8UyTNI2K5ZnDF6BR1webyS4HrETpkrWo39oN9UFYuvGQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YgnqZybNVy3cW5Sb/DOu5q87BXbgnXw56tW293dCPME=;
 b=lmkyU5PTNQ1+Xxycsccg6tbl6LguZ2DdMspXywPCzxJO33kblNMaumqLPdVmzGzTehm+2Vo+71WvJ+Z21bIHUfI/5TkfaI2JeqEQnSf/ZbSoJ/G8ZUod4p6yEEmoSACvBlyLIvfDEmP56aqOfIVKGXvCSgCWPcB1mWosrnkLTiq7fVrfDrH2mTMJ/ccNiSPymLmN3pmpouv5z2rJP0zTbLxZRB71eCRZDLnmWLCzxY+Rcav9xPJhcZCzh6XHJXe5B9+5Ytkqhy4/88kXsEDEPz//TGwHYOiQZvebYQuYkO221vsPrseIi7NMlSohVh2TUeogtaaXQzAVg/28oWp3GA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YgnqZybNVy3cW5Sb/DOu5q87BXbgnXw56tW293dCPME=;
 b=EPnQsgw673x++6mgdF3JnZ1FC7x3qq6eKDbYTv0hQsaoJvVF3ApIizQSe/kPHlDNKBe69jTNIZ9pbr17ZR3YjgT6k15mHvBzBadw0K9qjFw7l5lJpOHrePQjMPA61elkgX4/vXD72L75WOHv76ebM76JaJ+SOTxUvceWyAiTBq8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RMNOjnogKfj+JgFuxZfdE31w1bu1jlfX7wSYOe/8AFY138pOuySBoUfA1+ANFT8N7UfFWdZFadFLE8KPs003DPnaPyu9mOyM2cHc/aileGeyGTLff/5bi5J+DRmP8LSnZNntM+pskpTnJqdzF4WbRYBQnXNdf22KN/i/WAwfh7EuhkunKdD3UJQfMtzcXZcs6brp3KBtTPCDUY8/VqpPYIKWH0oDPalzsvUr7p477lO15vzEdquPQeGIqyweC5muCybAi+Iw7KMKooaf/QrxMP860I/HkFssy6j+5A//0PICGctc5+6F5bi2EI41ILxGDdeCEviTBNS83wsce+WRqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YgnqZybNVy3cW5Sb/DOu5q87BXbgnXw56tW293dCPME=;
 b=c7XKCafVMh3K60HPaM1SWKxw3HnJm0DiW47wqHgplLg2gAZiKPbcufaKDAKw5OdQJqO2B69uLbcEkl8FlkhbdA1af8XQVIIrqDhenz5BHCpAuihr16y5d/djLdOdVg90t4VihBwezkub0HQgo/5DDDkl/ESEKU9MaIvUtkEld0ItosXYttqpGA7BzhNlVU76ihcyaMER+fKAI2IvaaDe3kQvnHW8Huc5deD8GoaoBebnOfe+DscRkz2e4MS2KePfxfgbBsNJ9/iDUwobyrM+YsKI/pLyYldLaBLI+jEzId0jWdYIlU9uUy6eaZRYeIR1WZx3uhrnhq+owXri5HIPQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YgnqZybNVy3cW5Sb/DOu5q87BXbgnXw56tW293dCPME=;
 b=EPnQsgw673x++6mgdF3JnZ1FC7x3qq6eKDbYTv0hQsaoJvVF3ApIizQSe/kPHlDNKBe69jTNIZ9pbr17ZR3YjgT6k15mHvBzBadw0K9qjFw7l5lJpOHrePQjMPA61elkgX4/vXD72L75WOHv76ebM76JaJ+SOTxUvceWyAiTBq8=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>, "julien@xen.org"
	<julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei
 Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>
Subject: RE: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
Thread-Topic: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static
Thread-Index:
 AQHYWhk9pvmpyYf9yk6PCG0TATWN+q0DifWAgAAAvZCAAALDgIAAAKBggADK+ACAAEzRYA==
Date: Thu, 28 Apr 2022 03:09:39 +0000
Message-ID:
 <DU2PR08MB7325AD0A6D2E65D6ADBF5598F7FD9@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20220427092743.925563-1-Penny.Zheng@arm.com>
 <20220427092743.925563-6-Penny.Zheng@arm.com>
 <95b1d82e-92fa-7468-d3aa-038f0de937d9@xen.org>
 <DU2PR08MB73250D118F81DF1FF2C89DAFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <433f9e2a-9da7-662f-04b5-0379eca7496f@xen.org>
 <DU2PR08MB73250C2576634910269805CFF7FA9@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2204271531410.915916@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2204271531410.915916@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F5907F57659E134FBA6F6FEB04016A38.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 11823219-f32d-46c7-8f70-08da28c48e9c
x-ms-traffictypediagnostic:
	PA4PR08MB6287:EE_|VE1EUR03FT025:EE_|AM5PR0802MB2388:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0802MB2388F67C60F8A25A5136D9FBF7FD9@AM5PR0802MB2388.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 QXf0QqWZIUPVqHTypvi7U373qyfghFoidtLp3YRKT0Rc7lTXchPlcIYtdu1j1f1RxhZSPTOp/AjubSRWUKRKpOTczjaRzXEyb1Dx8eaVs2N+O2v4B6EaYR3VIvUctCyKXbs9qze+lWHc19ooa5Z0THh7aou5gJa9SjOW53drYx4KJVtoNeRAM6lbctqkFZTuacoblTufuLChXVV/tI4qnI3ci1XWcc+AkQXg0sXVBrffVoa4qGSRGtBYYjgv1GQ0ltYLwMDyteVbmhm6ERYyAaPbbpM5GlXqn1dFYe3UFrG31mSZUpDtd0G3E8a5SHyHo7t5gModhPaY8UAV4WJ72DSA2XW/YcgGjzFgKz7AqZ0AJiK0JAZB0pfyvConSpRX2bCE6TzUOiZaZhsGicUjx1X53QIEG+ClAIWTj7M8rBX3Cafw/bsrN5rxvDR+2h7znuVFG2HwOm7q04s6ogh8X+UkMnOGn75AahszSuIx/vxUIB/5BU3hgBa1zqJ20wEfpCxvclDNMi4OO+n449S/UFEp6sTDIffAIMg5lEsbcx3Cr32EQkfInFo0m8q7lxWShXxOSTgCEBBPsz6awmbZbRKn/ntBk408MIgbaiq2UWer2JMKV4Wb0cA+it4tNxAUoAhxLdcqF0WEMvvdko5w+XmY/udC0qjxNqVYrw7D4GjU/++kL2uNS5Ss1htsy6Y2Ic18qkJfq+YhDupxl96VvkoWYW40hVp+/qPyO3ptMIgQEzQcEAVSRzQzIX1+BLmjuPi4j8KmXzSleTw1+Eh+mX7Mjtgv7RN4yYaenZE84sA=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(966005)(508600001)(71200400001)(86362001)(53546011)(122000001)(26005)(6506007)(9686003)(38100700002)(38070700005)(66476007)(316002)(76116006)(66946007)(66556008)(7696005)(186003)(33656002)(55016003)(2906002)(5660300002)(8936002)(110136005)(54906003)(4326008)(52536014)(64756008)(66446008)(83380400001)(8676002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6287
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	01fd391f-786d-4442-747d-08da28c488d4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qeU9Am2s17cOpxMN9O4pGezrJk4x9bQFrohkIM6WYeGfoimjRB+2sw+sc6na3QBUiSDpJ8EEvGPLeObcnLrdqps9HyDW8DCKoyKBroBGNJ4g9rt29Qd36DgKsv+HFqwqxbZwENIPQElTp1G5yYiui/AYNfMHu6vWAjuju8/zGx/KAWcxT1yOYQPnHrMg+7UU8urdWR+PdWvFc9ffmjArcvQ06mjZR4hcRujeN6trrhggiF0AHi6+PqhxRdMbn66+5gcihr7iQCRYkAL9KSD/CDuUmcuE6OKSw07rqcYsni6fhx5TuJXESCtTqDRlTcundDp7EqZOTexPR0AUuWu8SMVd8fsxr6AMCtd1iQDV8F0KudtrjmC/ryVzZJHwtB5/xNKNeiAl7/SqKrOj3EySjJbst0zacJJ7Dptul/eALsihrzudR6g4G5Dq0U0pwGbcIzyUltIAzDPVlzIimjNcI3tfKGN2TEG6F/ZHsxBeaGGj3wYP1O6EoXUOWU2UaIOyoeYGJ19Xk4HsYdVwbVwVCa0Ot39W0QOGciJe6xNmNS35MIgAj6OPBH2tyssLO/tLWToRCiGTK5l6sLmO8k+N3vtnHJ9xoTs+5iZDs5nz34IOWN0yE0qX/JjVmqaFlYiune4S5VfasUL2liGYp/e755ZnDSAP/B9iakS6mYRvJxCtHN8r1/Z47/kHXdztEiKuprVJT4ls/VuMP6NrDLoFHZEKnTjG6EZnO9N1ZSbgj16TxxogUVqzBop/l2tqKOV6Y92GRFdd0L5IVvYQ4RGeNg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(47076005)(82310400005)(26005)(6506007)(86362001)(7696005)(81166007)(9686003)(55016003)(70586007)(70206006)(316002)(54906003)(186003)(110136005)(336012)(4326008)(8936002)(8676002)(33656002)(508600001)(40460700003)(52536014)(966005)(83380400001)(2906002)(53546011)(5660300002)(36860700001)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 03:09:49.6578
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 11823219-f32d-46c7-8f70-08da28c48e9c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2388

Hi=20

> -----Original Message-----
> From: Stefano Stabellini <sstabellini@kernel.org>
> Sent: Thursday, April 28, 2022 6:32 AM
> To: Penny Zheng <Penny.Zheng@arm.com>
> Cc: Julien Grall <julien@xen.org>; xen-devel@lists.xenproject.org; Wei Ch=
en
> <Wei.Chen@arm.com>; Henry Wang <Henry.Wang@arm.com>; Stefano
> Stabellini <sstabellini@kernel.org>; Bertrand Marquis
> <Bertrand.Marquis@arm.com>; Volodymyr Babchuk
> <Volodymyr_Babchuk@epam.com>; Andrew Cooper
> <andrew.cooper3@citrix.com>; George Dunlap <george.dunlap@citrix.com>;
> Jan Beulich <jbeulich@suse.com>; Wei Liu <wl@xen.org>
> Subject: RE: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is
> static
>=20
> On Wed, 27 Apr 2022, Penny Zheng wrote:
> > > Hi Penny,
> > >
> > > On 27/04/2022 11:19, Penny Zheng wrote:
> > > >>> +/*
> > > >>> + * Put free pages on the resv page list after having taken them
> > > >>> + * off the "normal" page list, when pages from static memory
> > > >>> +*/ #ifdef CONFIG_STATIC_MEMORY
> > > >>> +#define arch_free_heap_page(d, pg) ({                   \
> > > >>> +    page_list_del(pg, page_to_list(d, pg));             \
> > > >>> +    if ( (pg)->count_info & PGC_reserved )              \
> > > >>> +        page_list_add_tail(pg, &(d)->resv_page_list);   \
> > > >>> +})
> > > >>> +#endif
> > > >>
> > > >> I am a bit puzzled how this is meant to work.
> > > >>
> > > >> Looking at the code, arch_free_heap_page() will be called from
> > > >> free_domheap_pages(). If I am not mistaken, reserved pages are
> > > >> not considered as xen heap pages, so we would go in the else
> > > >> which will end up to call free_heap_pages().
> > > >>
> > > >> free_heap_pages() will end up to add the page in the heap
> > > >> allocator and corrupt the d->resv_page_list because there are only=
 one
> link list.
> > > >>
> > > >> What did I miss?
> > > >>
> > > >
> > > > In my first commit "do not free reserved memory into heap", I've
> > > > changed the behavior for reserved pages in free_heap_pages()
> > > > +    if ( pg->count_info & PGC_reserved )that
> > > > +        /* Reserved page shall not go back to the heap. */
> > > > +        return free_staticmem_pages(pg, 1UL << order,
> > > > + need_scrub);
> > > > +
> > >
> > > Hmmm... somehow this e-mail is neither in my inbox nor in the
> > > archives on lore.kernel.org.
> > >
> >
> > Oh.... I just got email from tessian that they held my first commit,
> > and needed my confirmation to send. So sorry about that!!!
> >
> > I'll re-send my first commit ASAP.
>=20
> Just FYI I still cannot see the first patch anywhere in my inbox

So sorry about the mess again...
I've resend it just now, PLZ check https://patchwork.kernel.org/project/xen=
-devel/patch/20220428030127.998670-1-Penny.Zheng@arm.com/=20


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 03:12:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 03:12:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315940.534634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njua3-0002Fv-3t; Thu, 28 Apr 2022 03:12:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315940.534634; Thu, 28 Apr 2022 03:12:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njua3-0002Fo-0g; Thu, 28 Apr 2022 03:12:35 +0000
Received: by outflank-mailman (input) for mailman id 315940;
 Thu, 28 Apr 2022 03:12:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njua1-0002Fe-Dn; Thu, 28 Apr 2022 03:12:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njua1-0003bO-CF; Thu, 28 Apr 2022 03:12:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njua0-0003yC-Sz; Thu, 28 Apr 2022 03:12:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njua0-0001hR-SW; Thu, 28 Apr 2022 03:12:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZatzB/UVoRk5R1+LwZCnk53PanojFJj9G2sUiTvePoo=; b=z+0JjVMNLhygqCQqulEQWL7J5v
	e/DLQh67CUc7FUlFdB/l4d5x+oqbrOHXHUEwHygLkqgmVdyN0mIlFZxCPtviShMlX5Ez+jr2drYqB
	iOwdRh7zX5DHfb9nA53oys0tBMKoOZOrJlsR/7m2irXZC7LJRq5GAn0FgguPsQOLz1M8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169803-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169803: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 03:12:32 +0000

flight 169803 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169803/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  671 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   43 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 05:11:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 05:11:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315980.534664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njwQa-0006kY-1w; Thu, 28 Apr 2022 05:10:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315980.534664; Thu, 28 Apr 2022 05:10:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njwQZ-0006kR-VC; Thu, 28 Apr 2022 05:10:55 +0000
Received: by outflank-mailman (input) for mailman id 315980;
 Thu, 28 Apr 2022 05:10:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njwQZ-0006kE-0K; Thu, 28 Apr 2022 05:10:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njwQY-00063R-Pv; Thu, 28 Apr 2022 05:10:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njwQY-0003ct-BY; Thu, 28 Apr 2022 05:10:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njwQY-0008Jh-B7; Thu, 28 Apr 2022 05:10:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=k8booOwAV+7TQ0aRaX41lzeFCWUomxixqwggMJxhXrI=; b=tjL0HPc3sdvVPSxM4dBUpbDAxD
	HNDRTdyNlebQbKfrwCN+kvMqW06k4HBuVJX12HQ8dbxtBm1UcMPzsGQ2c9fIVtmZHRRIqT75bc6rh
	TcEAeHOGnW4F+iPJlixsyoqu+VsO4Ed6RYhlkq3aJ7rvWj3qxfyITHSILrO3bWNQfH7U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169782-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 169782: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4426e6017f73bbbd65270965ecc11b6b3ff4af4d
X-Osstest-Versions-That:
    linux=dc213ac85601199834e7f2d222a5e63d7076d971
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 05:10:54 +0000

flight 169782 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169782/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169563
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169563
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169563
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169563
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169563
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169563
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169563
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169563
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169563
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169563
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169563
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169563
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                4426e6017f73bbbd65270965ecc11b6b3ff4af4d
baseline version:
 linux                dc213ac85601199834e7f2d222a5e63d7076d971

Last test of basis   169563  2022-04-20 07:42:29 Z    7 days
Testing same since   169782  2022-04-27 12:13:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Kardashevskiy <aik@ozlabs.ru>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrew Morton <akpm@linux-foundation.org>
  Arend van Spriel <arend.vanspriel@broadcom.com>
  Athira Rajeev <atrajeev@linux.vnet.ibm.com>
  Bob Peterson <rpeterso@redhat.com>
  Borislav Petkov <bp@alien8.de>
  Borislav Petkov <bp@suse.de>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Corinna Vinschen <vinschen@redhat.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  David Ahern <dsahern@kernel.org>
  David Gibson <david@gibson.dropbear.id.au>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dragos-Marian Panait <dragos.panait@windriver.com>
  Eelco Chaudron <echaudro@redhat.com>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Guo Ren <guoren@kernel.org>
  Guo Ren <guoren@linux.alibaba.com>
  Hangbin Liu <liuhangbin@gmail.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hongbin Wang <wh_bin@126.com>
  Ido Schimmel <idosch@idosch.org>
  Ido Schimmel <idosch@nvidia.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamal Hadi Salim <jhs@mojatatu.com>
  James Hutchinson <jahutchinson99@googlemail.com>
  Jens Axboe <axboe@kernel.dk>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Joel Savitz <jsavitz@redhat.com>
  Jon Hunter <jonathanh@nvidia.com>
  Kalle Valo <kvalo@kernel.org>
  Karsten Graul <kgraul@linux.ibm.com>
  Kees Cook <keescook@chromium.org>
  Khazhismel Kumykov <khazhy@google.com>
  Kuniyuki Iwashima <kuniyu@amazon.co.jp>
  Lee Jones <lee.jones@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Liviu Dudau <liviu.dudau@arm.com>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Manish Rangankar <mrangankar@marvell.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marek Vasut <marex@denx.de>
  Mark Brown <broonie@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Max Filippov <jcmvbkbc@gmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Michal Hocko <mhocko@suse.com>
  Michal Simek <michal.simek@xilinx.com>
  Mike Christie <michael.christie@oracle.com>
  Mikulas Patocka <mpatocka@redhat.com>
  Naama Meir <naamax.meir@linux.intel.com>
  Nico Pache <npache@redhat.com>
  Paolo Abeni <pabeni@redhat.com>
  Paolo Valerio <pvalerio@redhat.com>
  Philipp Zabel <p.zabel@pengutronix.de>
  Ricardo Dias <rdias@singlestore.com>
  Rob Clark <robdclark@chromium.org>
  Rob Herring <robh@kernel.org>
  Sameer Pujar <spujar@nvidia.com>
  Sasha Levin <sashal@kernel.org>
  Sasha Neftin <sasha.neftin@intel.com>
  Sergey Matyukevich <sergey.matyukevich@synopsys.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Stefan Wahren <stefan.wahren@i2se.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Theodore Ts'o <tytso@mit.edu>
  Thierry Reding <treding@nvidia.com>
  Thomas Gleixner <tglx@linutronix.de>
  Tom Zanussi <zanussi@kernel.org>
  Tomas Melin <tomas.melin@vaisala.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Vineet Gupta <vgupta@kernel.org>
  Vinod Koul <vkoul@kernel.org>
  Wang Jianjian <wangjianjian3@huawei.com>
  wangjianjian (C) <wangjianjian3@huawei.com>
  Will Deacon <will@kernel.org>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xiaomeng Tong <xiam0nd.tong@gmail.com>
  Xiongwei Song <sxwjean@gmail.com>
  Ye Bin <yebin10@huawei.com>
  Zhang Qilong <zhangqilong3@huawei.com>
  zhangqilong <zhangqilong3@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   dc213ac85601..4426e6017f73  4426e6017f73bbbd65270965ecc11b6b3ff4af4d -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 05:11:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 05:11:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315901.534675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njwQm-000747-GV; Thu, 28 Apr 2022 05:11:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315901.534675; Thu, 28 Apr 2022 05:11:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njwQm-00073y-Ch; Thu, 28 Apr 2022 05:11:08 +0000
Received: by outflank-mailman (input) for mailman id 315901;
 Thu, 28 Apr 2022 01:01:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYj/=VG=huawei.com=nixiaoming@srs-se1.protection.inumbo.net>)
 id 1njsX4-0003u5-O3
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 01:01:22 +0000
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b60787b7-c68e-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 03:01:20 +0200 (CEST)
Received: from canpemm500006.china.huawei.com (unknown [172.30.72.57])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kpcgf1MZfzGpMl;
 Thu, 28 Apr 2022 08:58:38 +0800 (CST)
Received: from [10.67.110.83] (10.67.110.83) by canpemm500006.china.huawei.com
 (7.192.105.130) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Apr
 2022 09:01:14 +0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b60787b7-c68e-11ec-8fc3-03012f2f19d4
Subject: Re: [PATCH 18/30] notifier: Show function names on notifier routines
 if DEBUG_NOTIFIERS is set
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, <akpm@linux-foundation.org>,
	<bhe@redhat.com>, <pmladek@suse.com>, <kexec@lists.infradead.org>
CC: <linux-kernel@vger.kernel.org>, <bcm-kernel-feedback-list@broadcom.com>,
	<coresight@lists.linaro.org>, <linuxppc-dev@lists.ozlabs.org>,
	<linux-alpha@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-edac@vger.kernel.org>, <linux-hyperv@vger.kernel.org>,
	<linux-leds@vger.kernel.org>, <linux-mips@vger.kernel.org>,
	<linux-parisc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<linux-remoteproc@vger.kernel.org>, <linux-s390@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, <linux-um@lists.infradead.org>,
	<linux-xtensa@linux-xtensa.org>, <netdev@vger.kernel.org>,
	<openipmi-developer@lists.sourceforge.net>, <rcu@vger.kernel.org>,
	<sparclinux@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
	<x86@kernel.org>, <kernel-dev@igalia.com>, <kernel@gpiccoli.net>,
	<halves@canonical.com>, <fabiomirmar@gmail.com>,
	<alejandro.j.jimenez@oracle.com>, <andriy.shevchenko@linux.intel.com>,
	<arnd@arndb.de>, <bp@alien8.de>, <corbet@lwn.net>,
	<d.hatayama@jp.fujitsu.com>, <dave.hansen@linux.intel.com>,
	<dyoung@redhat.com>, <feng.tang@intel.com>, <gregkh@linuxfoundation.org>,
	<mikelley@microsoft.com>, <hidehiro.kawai.ez@hitachi.com>, <jgross@suse.com>,
	<john.ogness@linutronix.de>, <keescook@chromium.org>, <luto@kernel.org>,
	<mhiramat@kernel.org>, <mingo@redhat.com>, <paulmck@kernel.org>,
	<peterz@infradead.org>, <rostedt@goodmis.org>, <senozhatsky@chromium.org>,
	<stern@rowland.harvard.edu>, <tglx@linutronix.de>, <vgoyal@redhat.com>,
	<vkuznets@redhat.com>, <will@kernel.org>, Arjan van de Ven
	<arjan@linux.intel.com>, Cong Wang <xiyou.wangcong@gmail.com>, Sebastian
 Andrzej Siewior <bigeasy@linutronix.de>, Valentin Schneider
	<valentin.schneider@arm.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-19-gpiccoli@igalia.com>
From: Xiaoming Ni <nixiaoming@huawei.com>
Message-ID: <9f44aae6-ec00-7ede-ec19-6e67ceb74510@huawei.com>
Date: Thu, 28 Apr 2022 09:01:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.0.1
MIME-Version: 1.0
In-Reply-To: <20220427224924.592546-19-gpiccoli@igalia.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.110.83]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 canpemm500006.china.huawei.com (7.192.105.130)
X-CFilter-Loop: Reflected

On 2022/4/28 6:49, Guilherme G. Piccoli wrote:
> Currently we have a debug infrastructure in the notifiers file, but
> it's very simple/limited. This patch extends it by:
> 
> (a) Showing all registered/unregistered notifiers' callback names;
> 
> (b) Adding a dynamic debug tuning to allow showing called notifiers'
> function names. Notice that this should be guarded as a tunable since
> it can flood the kernel log buffer.
> 
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Cong Wang <xiyou.wangcong@gmail.com>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Xiaoming Ni <nixiaoming@huawei.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
> 
> We have some design decisions that worth discussing here:
> 
> (a) First of call, using C99 helps a lot to write clear and concise code, but
> due to commit 4d94f910e79a ("Kbuild: use -Wdeclaration-after-statement") we
> have a warning if mixing variable declarations with code. For this patch though,
> doing that makes the code way clear, so decision was to add the debug code
> inside brackets whenever this warning pops up. We can change that, but that'll
> cause more ifdefs in the same function.
> 
> (b) In the symbol lookup helper function, we modify the parameter passed but
> even more, we return it as well! This is unusual and seems unnecessary, but was
> the strategy taken to allow embedding such function in the pr_debug() call.
> 
> Not doing that would likely requiring 3 symbol_name variables to avoid
> concurrency (registering notifier A while calling notifier B) - we rely in
> local variables as a serialization mechanism.
> 
> We're open for suggestions in case this design is not appropriate;
> thanks in advance!
> 
>   kernel/notifier.c | 48 +++++++++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 46 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index ba005ebf4730..21032ebcde57 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -7,6 +7,22 @@
>   #include <linux/vmalloc.h>
>   #include <linux/reboot.h>
>   
> +#ifdef CONFIG_DEBUG_NOTIFIERS
> +#include <linux/kallsyms.h>
> +
> +/*
> + *	Helper to get symbol names in case DEBUG_NOTIFIERS is set.
> + *	Return the modified parameter is a strategy used to achieve
> + *	the pr_debug() functionality - with this, function is only
> + *	executed if the dynamic debug tuning is effectively set.
> + */
> +static inline char *notifier_name(struct notifier_block *nb, char *sym_name)
> +{
> +	lookup_symbol_name((unsigned long)(nb->notifier_call), sym_name);
> +	return sym_name;
> +}
> +#endif
> +
>   /*
>    *	Notifier list for kernel code which wants to be called
>    *	at shutdown. This is used to stop any idling DMA operations
> @@ -34,20 +50,41 @@ static int notifier_chain_register(struct notifier_block **nl,
>   	}
>   	n->next = *nl;
>   	rcu_assign_pointer(*nl, n);
> +
> +#ifdef CONFIG_DEBUG_NOTIFIERS
> +	{
> +		char sym_name[KSYM_NAME_LEN];
> +
> +		pr_info("notifiers: registered %s()\n",
> +			notifier_name(n, sym_name));
> +	}

Duplicate Code.

Is it better to use __func__ and %pS?

pr_info("%s: %pS\n", __func__, n->notifier_call);


> +#endif
>   	return 0;
>   }
>   
>   static int notifier_chain_unregister(struct notifier_block **nl,
>   		struct notifier_block *n)
>   {
> +	int ret = -ENOENT;
> +
>   	while ((*nl) != NULL) {
>   		if ((*nl) == n) {
>   			rcu_assign_pointer(*nl, n->next);
> -			return 0;
> +			ret = 0;
> +			break;
>   		}
>   		nl = &((*nl)->next);
>   	}
> -	return -ENOENT;
> +
> +#ifdef CONFIG_DEBUG_NOTIFIERS
> +	if (!ret) {
> +		char sym_name[KSYM_NAME_LEN];
> +
> +		pr_info("notifiers: unregistered %s()\n",
> +			notifier_name(n, sym_name));
> +	}
Duplicate Code.

Is it better to use __func__ and %pS?

pr_info("%s: %pS\n", __func__, n->notifier_call);
> +#endif
> +	return ret;
>   }
>   
>   /**
> @@ -80,6 +117,13 @@ static int notifier_call_chain(struct notifier_block **nl,
>   			nb = next_nb;
>   			continue;
>   		}
> +
Is the "#ifdef" missing here?
> +		{
> +			char sym_name[KSYM_NAME_LEN];
> +
> +			pr_debug("notifiers: calling %s()\n",
> +				 notifier_name(nb, sym_name));
Duplicate Code.

Is it better to use __func__ and %pS?

pr_info("%s: %pS\n", __func__, n->notifier_call);
> +		}
>   #endif
>   		ret = nb->notifier_call(nb, val, v);
>   
> 

Thanks
Xiaoming Ni


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 06:38:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 06:38:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.315999.534685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njxmw-0006pd-QV; Thu, 28 Apr 2022 06:38:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 315999.534685; Thu, 28 Apr 2022 06:38:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njxmw-0006pW-NW; Thu, 28 Apr 2022 06:38:06 +0000
Received: by outflank-mailman (input) for mailman id 315999;
 Thu, 28 Apr 2022 06:38:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njxmw-0006pQ-0V
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 06:38:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c187bb79-c6bd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 08:38:04 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-M9v1_0BcPFyke9_VRdr4iw-1; Thu, 28 Apr 2022 08:38:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Thu, 28 Apr
 2022 06:38:00 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 06:37:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c187bb79-c6bd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651127883;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9pZr5JenoXM4iIWaUGL3j4EdX8XWCwHxTDjLES1lDcI=;
	b=M0YjvNaAAswX3sPjR2Te+40SvaCZCneHsGpnRbpW2xMxyXYRkwLuuPN1z9/L46vfnJWYJV
	dhbrM7COhlfVejx2kSQKLimM8rz8wql9XnNEoEjReaMK1kCkha5LZi5E9dZToF/+xGyj9+
	O6reJx3AaD1ftHyjhVDp7mMIY/C0qGE=
X-MC-Unique: M9v1_0BcPFyke9_VRdr4iw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nLysDHRTylDYiJpTOZyK3AhTIXpTm0rYJ3UikcAN/BPMEhk4gq7MR52r3KW6jK0mFtPKv48Oo6296mg6EjGLSM3eYnFdV7N6AVjO98lXXmY8nwJuKOfnQ2pN0JhrjeFuky57dQ5AZb5/65iJVP51mWzuFDD75+v1Td9CWJoPeCI6JWnD/lHHgLR3Mb/Mw2gdTQTF4kAG8HC7tNgDnzoJxCyAHDM83SpNqjXajGUMZuk8X12WGz6BdNtAKoHvcfnFkd4P6yV0EUchLTyag/uPJzIlrue9/7wQm9lNvlg5UlSA/Ep3+I3L5AQor6QHiCK4z4Pf1vF4A/bFqE2DTUoNxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M6zh4VLUz3RDRWUv2f9VnJJHORSL5nQnQ67F8bY5sxs=;
 b=NIT3maZE2/oExfSbG/PyFrhWQ6fveRZIWSv78vyrQ1vb0tTFGXYK0H7lGOpiFrkYBrG251Av2vglWyH9JXlmymp2eeW+Ei7w94YMHb1FQgJE3fPWDydrTMGcOT5dstfp7pH88bLJ0ed1W8rs9WxAbDI/xlTDdaJ54kncY2PDzX9NeffKqSvUjvIncxyZbtcxKHlWHCbDYt8pqqz6FS/axa01c5XE3RmfmjNxR30QhCKNJ84ESZ44ZJQ+AhSjjUAMrIdNnPlB1Job1j41exsNDAhlcvD+SyR+adu8Y9o1V/DbBd2kvaeDadi7wLS1i2rKJkVOE7fUvM8I81G4jSxsDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9a4d1bec-321a-21da-6a11-4b4990c52895@suse.com>
Date: Thu, 28 Apr 2022 08:37:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
 <Ymk7BjXdyiMUGoc8@Air-de-Roger>
 <47b50c64-b8bd-df95-9de9-175780c50e0b@suse.com>
 <Ymlb2Wly25k9bF0z@Air-de-Roger>
 <d9e797eb-5075-2c95-cfa9-959586577f98@suse.com>
 <YmlrYNFI75wQlVlg@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmlrYNFI75wQlVlg@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P251CA0019.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::22) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 26d6d035-9185-41f7-0688-08da28e1a333
X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB82472E843547C41E473B0471B3FD9@AS8PR04MB8247.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A5jJTJE6qRNoL3YEQ5k+52R0V2IWv/2Va/57h4oVgeHBDkSO14f67IS6C7HmQNUPSxjXiULI9HbOtCEfHqMaYt7p8lj2dWAX5JekXATnvKS4ce4kk7i2QyngL85JtVns5/naGLe+YkE8cZUBKmzf1YUYL5V7gJS477UCWcPunFz1XoUjbQriHyJIwMO0u9MRTffQ3igbnU7VAxLAxjN+YUwupdLh0fZx/J8+v/1XHYsqhs7yb8lq3fceaK3qUQCvSnL/Kd8mdg2mLXNFDUx6/G1d2pn7lwZR8ca+6SSeM4+hPST4mevtu6IpkS0XChiRApU8TeJqH5qOfKBoFm+wuoYPZtF1oHlz5zW0wz69Ipicat3GtrMkcaa07PIGVvD8UnW0lUYZxpYAXOxBYleAhacXWH0gb4g9kTGYnKrAXCpJx8ip3kiesw+uu1iAN30kB7DBn3Yd0yOrhmXRoMQImAdxy1VcjUDa1QWGRV5ChzBs7d43yXRQwnjIb7WeaGzpINdgfCnkxvEZO5eT3X+LJ5j7V/YsleuVmkyZV5/8As1L4RHLyFNsIVw7N692R+ya9i8360S+fQ+HO8TgUxFaIqUblMnmd5gSe6q6aTX+HraRnZ7QCpWyVcKKGIEUZwXbJ84TY4AYhaGhtyjoNcABqJJ/Pyc6Ns2hJXOoGpU/4kXJVE5hOGfbdJ3HfLv0c7og80yPyGE7EnQjbCIImPez6JdDNsAlXn43I/i+SefNyqycQi1CGAGII4+UwO1QjbgrGYGGbTHSCVmwCiGQCpQa8zBeMsQzse8/NsXllXKbuzwLZ7uFea4/WKEsl0VXga0V
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(5660300002)(508600001)(84970400001)(8936002)(83380400001)(6486002)(8676002)(31696002)(186003)(6506007)(2906002)(86362001)(26005)(53546011)(6512007)(66556008)(66476007)(316002)(66946007)(54906003)(6916009)(36756003)(31686004)(4326008)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?dk/Fu8yGeARY8N1t3aLc7i4+PQ5gE/wVpYpzNA2wmkkLZe9XyS+sNFfmADAj?=
 =?us-ascii?Q?pqoszo7fB4EqIQXu4p8DdPjeBDSHhwKTEkulYoHQdZCTkSh4XKTgql7fnm2w?=
 =?us-ascii?Q?hWPEOzfSAg7b8V/TyyCRM2UZj5xc3qTISk5Zvnt7/2T3qp0f6vIdAedji0Cb?=
 =?us-ascii?Q?Y65m3hm6Q4nfnUcSdUe0hS7jN5VxGt094fJ0WgdtdO978564YCi24ekvxyTe?=
 =?us-ascii?Q?CV+HVRt9t4tQfqdEopj2zWjsEpdb28zMoMI5zJJT5pIxnEi6hG26dhBfUa+w?=
 =?us-ascii?Q?GBDIoOgxudgu/BmwzqtE46wR/+TDXisI7NDA/zslyUwBK3PUdrPWBACZhNxK?=
 =?us-ascii?Q?GbXtt3mecAdS/v9lBzoalT4PoT1+vyZed/ZJ1R/ReNojbcLH0TJ6x2b17+d6?=
 =?us-ascii?Q?DvtS3nFDX8FXx2FJbGVRsi2Z/SBk87E7RN/rC0RBMInmARt0IK9aVAW05Uee?=
 =?us-ascii?Q?m/dQY9+nWnBEa5N7Gos6enzF57VGocuqnhlMKLUPRvUXbgR5oVcqXQbq9Pwl?=
 =?us-ascii?Q?81LaiqJzzjpxLKrjDVi74NJyVmT+0gbznCwlPyqu63381XnUTMqQuLQvHSxm?=
 =?us-ascii?Q?e+iwa2IvC6t0hzgR3pvUKc3CeBxcooLJoP/L/mhF3H7aUCKUQtP8V3p61sGH?=
 =?us-ascii?Q?H5cNh8cko57007oQGYXE3b6Th0XzfzUltfB3ETVkqpG8tng7uYrPj6Wv/5gq?=
 =?us-ascii?Q?zmTgTtocXKF7l8gBYVSHDi5FIEe4UpuYEMU17KBXkMNRWZ5Hq+8dWqSrr8B0?=
 =?us-ascii?Q?E4FXxCxiQmzWEpahvOJgpk26hEiidj1T4P+GGKKpcg+8PLlyvlsA+ucNAxgk?=
 =?us-ascii?Q?YJj9hRIqcHiH+KNComGOZz6dO5lt53feBzt97O2ScMA0b8n5iQFf0npSrp/f?=
 =?us-ascii?Q?dLpzzUDR56xLWdCUbRoA0shAazoIWJssHygzZMTcnmJyXyeuczY2VeyH9B2U?=
 =?us-ascii?Q?qDPthSO5m7XkUA0so0A+O+M4qvvIl4GlQA+EaDuLdU2qVAHvqQv7ffw9DCt4?=
 =?us-ascii?Q?6+l6ikId+uTaC42UOicEKkmCtnxziK9tdVRk5VPWKERTj9l50OX55ATjZTja?=
 =?us-ascii?Q?UZmCvF+m/TePCIYQGAyIMmV9vO+JP/ynwYaoz91VkvBAtsBAuR7n+GHd8piO?=
 =?us-ascii?Q?eJhDPTbaKrYpgOrajAWUZslc+rPd/DBYkoR6fYv60aMz0bFvjw6EVQ5YXWgN?=
 =?us-ascii?Q?+UtH0agiEk+6A5RH8S2UNZ0w4PpmfGCAH4BQSel/0YSk8RScDecRNIhltmyv?=
 =?us-ascii?Q?AZfOPrixlcWg3lyDWvzRb+orfrp9TWkDSgFYSvAEg2CuughsvBoyIYMuK03n?=
 =?us-ascii?Q?cA1pFxej3bZPu+RT8oLBjtu4PCOIsPrPpMUIxpDfEqJjdqxNvBJUtzlz2D4M?=
 =?us-ascii?Q?D8dvJoPudKhCp0KoGBWlgs7+brokxST11RsYViOYsbVxCwKJfffBLooS281P?=
 =?us-ascii?Q?vk2As0edauuE5uQbFsEFvJuoQY94EoDnzU/rv+6Azc8vAJ8LFw0TES7YtFrf?=
 =?us-ascii?Q?+Xl9qHlBd4xiMpk/5Un5+jgnS2D6jgOUgH3OzbrHGDstg7Kdym0ElDGXseK3?=
 =?us-ascii?Q?idjauWXsuabBtE1tg8faropAtOptahnPtJVnVeAsG1SS2A88j0erOirZCghO?=
 =?us-ascii?Q?PH8/Mo3a/bkv0obmh/WgXBD6HSOkmzHHiX16cVnJaTHBjCNLqwhfqkFQggPc?=
 =?us-ascii?Q?40vZzj362HCQOGD4CFmn6Otac+u2kk5UBT3aF88Vp2xYtU28ZYc7ssh2JAQD?=
 =?us-ascii?Q?xWaTqu2VIQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26d6d035-9185-41f7-0688-08da28e1a333
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 06:37:59.9342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 01Aa25UTcAwFJfEC9UH/XOJwCek5Sbh2mVwP+geW2MUO0K4RqMny1OizyZteBgqWAyB7nYo3+ItOYzHhoei6UA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8247

On 27.04.2022 18:12, Roger Pau Monn=C3=A9 wrote:
> On Wed, Apr 27, 2022 at 05:25:35PM +0200, Jan Beulich wrote:
>> On 27.04.2022 17:06, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote:
>>>> On 27.04.2022 14:45, Roger Pau Monn=C3=A9 wrote:
>>>>> On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote:
>>>>>> --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c
>>>>>> +++ unstable/xen/arch/x86/cpu/mwait-idle.c
>>>>>> @@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
>>>>>> =20
>>>>>>  static unsigned int mwait_substates;
>>>>>> =20
>>>>>> +/*
>>>>>> + * Some platforms come with mutually exclusive C-states, so that if=
 one is
>>>>>> + * enabled, the other C-states must not be used. Example: C1 and C1=
E on
>>>>>> + * Sapphire Rapids platform. This parameter allows for selecting th=
e
>>>>>> + * preferred C-states among the groups of mutually exclusive C-stat=
es - the
>>>>>> + * selected C-states will be registered, the other C-states from th=
e mutually
>>>>>> + * exclusive group won't be registered. If the platform has no mutu=
ally
>>>>>> + * exclusive C-states, this parameter has no effect.
>>>>>> + */
>>>>>> +static unsigned int __ro_after_init preferred_states_mask;
>>>>>> +integer_param("preferred-cstates", preferred_states_mask);
>>>>>> +
>>>>>>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
>>>>>>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C=
1. */
>>>>>>  static unsigned int lapic_timer_reliable_states =3D (1 << 1);
>>>>>> @@ -96,6 +108,7 @@ struct idle_cpu {
>>>>>>  	unsigned long auto_demotion_disable_flags;
>>>>>>  	bool byt_auto_demotion_disable_flag;
>>>>>>  	bool disable_promotion_to_c1e;
>>>>>> +	bool enable_promotion_to_c1e;
>>>>>
>>>>> I'm confused by those fields, shouldn't we just have:
>>>>> promotion_to_c1e =3D true |=C2=A0false?
>>>>>
>>>>> As one field is the negation of the other:
>>>>> enable_promotion_to_c1e =3D !disable_promotion_to_c1e
>>>>>
>>>>> I know this is code from Linux, but would like to understand why two
>>>>> fields are needed.
>>>>
>>>> This really is a tristate; Linux is now changing their global variable
>>>> to an enum, but we don't have an equivalent of that global variable.
>>>
>>> So it would be: leave default, disable C1E promotion, enable C1E
>>> promotion.
>>>
>>> And Linux is leaving the {disable,enable}_promotion_to_c1e in
>>> idle_cpu?
>>
>> Iirc they only have disable_promotion_to_c1e there (as a struct field)
>> and keep it, but they convert the similarly named file-scope variable
>> to a tristate.
>>
>>> I guess there's not much we can do unless we want to diverge from
>>> upstream.
>>
>> We've diverged some from Linux here already - as said, for example we
>> don't have their file-scope variable. I could convert our struct field
>> to an enum, but that would be larger code churn for (I think) little
>> gain.
>=20
> Hm, OK, could gaining the file scope variable would make sense in order
> to reduce divergences?  Or are the other roadblocks there?

I don't recall. It might have originated from a change I decided to not
port over, or I might have dropped it while porting. To be honest I'm
not keen on putting time into researching this, the more that I would
generally try to avoid static variables.

What I would be willing to put time in is making a more user friendly
command line option, but as said - I can't think of any good alternative
(except perhaps "preferred-cstates=3Dc1e" or "cstates=3Dpreferred:c1e", wit=
h
internal translation of the strings into a bit mask, as long as (a) you
would think that's an improvement and (b) the further divergence from
Linux is not deemed a problem).

Jan

> I think this is ugly, but would make sense as long as it allows us to
> keep closer to upstream.
>=20
> Thanks, Roger.
>=20



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 06:48:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 06:48:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316005.534696 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njxwU-0008Ie-OC; Thu, 28 Apr 2022 06:47:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316005.534696; Thu, 28 Apr 2022 06:47:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njxwU-0008IX-LG; Thu, 28 Apr 2022 06:47:58 +0000
Received: by outflank-mailman (input) for mailman id 316005;
 Thu, 28 Apr 2022 06:47:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njxwT-0008IP-Cg
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 06:47:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 226ffb67-c6bf-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 08:47:56 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-d6EUPs3rPZuEjBbRe6kp_g-1; Thu, 28 Apr 2022 08:47:54 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB6832.eurprd04.prod.outlook.com (2603:10a6:803:139::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Thu, 28 Apr
 2022 06:47:52 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 06:47:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 226ffb67-c6bf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651128476;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rxcE4Bhw2fovnyvrz8+l7FQqIdIiB+G8LguTXUm4Neo=;
	b=UDZNxen1zKHhQvOCDs+tyeTNXIUEKRO425qUS6qGBQ1WFlQUCU96ZRNcpyj4TgI9O+XJ+J
	eUvYb/XF8ml7TCFVI/qoh57CT/fkcLfG1i6kIV3FC1GewV+nFitp/bPTjlVXJrmQRpLCx9
	GwpKtj83a5YHTvLZDD/5IIV0NRvfzhE=
X-MC-Unique: d6EUPs3rPZuEjBbRe6kp_g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bkKHBeBJR3JSph6SVPJL/W0xTbm/BMsGYhvE+AUFST73nE+Mi4ryaISl2Ud2CtnJ5WK/EItCyKKifGH+sk6MYLuOPfiN9wxaonjzWnomK/PEGgko3o8FXVZQ1TIZ0fBwfqbrgXldm2OoKvb2kg2xG68G/jSWivUSSucToAUe8a+qMBxTsrcnUr1by1EgZJYs6JTOsCwGMVNyePuRDH5YteZMz6Z/L2Q+fD8IbnFz5NLSl+FewTf1vLcNIgIjPzpRERCDEHkAfwUDSuTNOfLC34fKPY+Xr+7OnK6+ly6DEJpZ7afKpos3/4iTVafs8piSLKNGfMy+dtwFpa4j/kl5kw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rxcE4Bhw2fovnyvrz8+l7FQqIdIiB+G8LguTXUm4Neo=;
 b=EDfcCe5MwqttgMGDwpYhAUMqFAJJxg98ogJeV3QCDcZmWWWIzlknSxj7JWfojJoNYXAkU2ynZBSkOFQJuKHB64Z0D6c2He8g8NFWkYTNsQTZQXJM2v9Ah0Z795FGjjlNL2Vg0YpRyTSF/2Ykm4XO1dduyWIhuvwmX58zsge+2uJ7UVM/X/APWoPN0U22eKtNlOrMIMZ3GuWvqoc//wnnq8/QuG4pFf1nXjEW/HbExgGDm7auPHT05ZkiDHP17ncrTi25cXboLAv6doey8ygYSmULtCNrd1yB5BUFYLCAVkVSIS3Vlzr7GwXDrfd5aIbb3tEWYEf6ipxxUCdxGonOtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com>
Date: Thu, 28 Apr 2022 08:47:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <Yl7aC2a+TtOaFtqZ@itl-email>
 <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com> <YmmUtiBkhEYvXHUB@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmmUtiBkhEYvXHUB@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0076.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: be7efcf6-c8b4-4464-9923-08da28e30498
X-MS-TrafficTypeDiagnostic: VI1PR04MB6832:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB68328876C90F074774404ABBB3FD9@VI1PR04MB6832.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IYw3q2/t8gC7CaZNtDLK9pqjAYXndoPbEUiUM4mxGpvaJUs/AMmk/afxkIYK14jaaIl97r66UgHye/qQ13j7miu3viUtunIZWD3bPIKNq6dKYyvne0Z4qn75U8VqiYNQU7VE0GQRxaR1zCFBFMn6i2ZGG+UsAHZ56vLnZpKnx9aIiluLetzAP2V3jV9Nwhj2Es/DH5xBW+SV80N/gA5gRnncYe//rozssTkfUdbScwlgywGlSO6rFQmvfhGr4gfAQd7lf96HY6oWYpEGRa59rgBsf2G+dRNkDZbXVMpr5ucgXIkyALz/Hqi4kpzzZDKfF6KQOF3Qg4jZQ+1h7uFtiaRVCqnwAfnOeTN0m7fVRVgmhM4DZx3wQmpSDGuTi+M3ya4UOCo+TZpv2HH5+wlQerRqwtbFSUStJAQn0CV3TLRnTOoYK9oWYBKWQ2q+IhiG6eyi46R1aw8P52DQeHQZ09UI/rR9FrI7jpGLG7C/p99S3KxwqNdrtGBw788kvH3NBpDxUCEF536T8TSa+HTerDvYYwZhIsT2vWa0Xi1OLSN8+aGbQAlIF8czSenovkbRWmVVNjLX3Rm4nwlilgTlxf16+U11u1u8tedAEYrlaIX1wFimaIJQd+EQ5jUZ+fXLr8/xw2D3C8LEeMOzsVsh82DtzaJQOsTQ3ENsNdINGvYoJTyA6mrmK+RtHLrbkWn6pi4eLJiWzzcQRbYaele09ngojxNbenFzkptdEdHvvLlsTHJB0PkaijfjHZ2GWLpKYT7npA8zSHKsG1rw4w7K1A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(6512007)(26005)(54906003)(316002)(83380400001)(2906002)(31686004)(53546011)(36756003)(6666004)(6506007)(6916009)(8676002)(8936002)(66946007)(4326008)(186003)(31696002)(86362001)(66476007)(66556008)(5660300002)(2616005)(508600001)(6486002)(15583001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ODhHcW5xN045TXZjeFFodDdCdTFWMGpmdHpURTlGTUNHcnM3THZsTklJdWVz?=
 =?utf-8?B?L2RuS2RVZ0tIeTFpUUptdmlKbUw3YzV4OGlFcVcxOGZRMjNsT1ZqRGlqeUhJ?=
 =?utf-8?B?cVduUmh0OHM2NzlBcGhva2luNVcrdUxRRk5ieTRtUWFneVowbkV4Q01VNVJv?=
 =?utf-8?B?NWtENEVBTDVUZXlzdDFjMHhlN0pjRTBpSG9iRGJHNjIrL2RrNGJ1OXdBR3lu?=
 =?utf-8?B?Mjc4a2ZIUFcyTjhGQ1Z4TjNqUGd4QzFubGI4VkQrNU5Cb1h6cjBNL3VHUjlz?=
 =?utf-8?B?WG9GbG1OTW96NVgvYTUxT1ZkTzJ6WGVnYmxyTk05Q0VJcE5LOUtoSExjNVNI?=
 =?utf-8?B?L2ErOXZucTU3aW45MWM3RzB4V3Q2Q2JiSzB0U0pyL2pDQW1yZFJhVFQwNzRi?=
 =?utf-8?B?NFYrSzdXSW41bEU0N0VrUDFreDZHQ1d6UjFuNXZzTDg5dWprbnVQRzBKWWYr?=
 =?utf-8?B?L2hkbG5DWEJMdUxENndBNGM0R09nRTJOWVJ2bzZGa0JEWUdnenhEaXlpR3c2?=
 =?utf-8?B?M2V4b3RFTUZlbkVlbHJTeE9jUzZXNDgxMm9oNFV1UlQvUXZFdFNCQ1lGa2pu?=
 =?utf-8?B?bjJzMy9VNGs2YjRtbGRseS9IV3pwalRwdkx6VG9QZ2VNLzFoOUxLTlBQZmZa?=
 =?utf-8?B?V25GTGw0UGxBcGR5SGhORjNibVUrWllIZkh4UVk1NHdkODVPNnR2QkQ2U1V5?=
 =?utf-8?B?bXdUaWJVWEFxNng5UTBWSEVFRVVuTURrRW1WeU1nbVVtblh2YndFQVdBbG1T?=
 =?utf-8?B?Q0QxNjA5bUFhZ2EvRGNaRGZIQ0FSdUp4SUNUeHdCK0k0bnhKSEU0Q1Vsd3d5?=
 =?utf-8?B?MnNCRWsvMjl5WmNobTAyZEtlazQzNEpIM2ZrTkIzeGNvTzdGWUZ0Vk1yMXE5?=
 =?utf-8?B?SWZsb1o2ZW9ZdGhOMVczeGNQcjVDVWZHMjlLUUt4b0xHNmYyUnpRc0QvL1ZH?=
 =?utf-8?B?bjlwU0JSbk1IYytuUTFtZjRmaVVPMEMrNkRUcU9kemJxbnpYTVBZQjc0dFBG?=
 =?utf-8?B?dWtyM1lGYWlRSGF3WmRhY01PSE5yVXZNdUNEL1JWdHppem92RWJlNGZXSWpP?=
 =?utf-8?B?UUI0c1RUOFd4WjZkTFVKVjFxMTlmNE9wcnJvM0d5dDZlTkUyQ0htd0lwckw4?=
 =?utf-8?B?LzRDNDQrRUhHS3JxbitKMlN4b0R1SHo5di91V3c5RTVNcnMyVEp2VjkzS1dK?=
 =?utf-8?B?b1RDWmVPTUJUWUZOU09ENFJDdCtoWElDbEVoK1ZvV1RHTTBxVWVqVVVOTzhE?=
 =?utf-8?B?WWE5MDMzVE42RXc5M3l4VFEvY1J5VEJGVnZqdERCdzJUd0w0anYxS2ovMFpU?=
 =?utf-8?B?b3A3MEdiU3NGc0FDZmM0aFdnYk5IQndVRmdqZElMWlYybEZKMFdmRFdBNmU3?=
 =?utf-8?B?R01JN2xWTGdPWUt6VXpyQVBkdFF6bklJU1RYa3MyUG9ad1dWdUtrOHNuZVNr?=
 =?utf-8?B?NjNGc0V4RmUwcnczd0N3aEQ1OGZHd3hGcGtmVVdGc2RyQktVVDlDdEtPVjg5?=
 =?utf-8?B?ZjlNNjlXM3JwcUdkRldnWGU3ZDdjRUx3bnQyaGVMZGpGcVhWelBla0w3TjZs?=
 =?utf-8?B?Y2pmVlhTWUtITHNxcVBIQ2MxNmE4NmRCSU9qVmYyWHNUME1vVXZaMzRwTWF4?=
 =?utf-8?B?aTM0V3JGWjQrcUlURUYyNXNML0RnVmxQeEJWMmpRd3Y3eWljZ0dZZldCQ2hq?=
 =?utf-8?B?MkFYTVVRdloyd2JXWjNqK29MaklhWDAwcVliaVpKVUovL0V3bGpKVDAxZWR6?=
 =?utf-8?B?MUQ4eXNXZGExeVhpdmQ2elVEaHFMRTZkM29lWkRBWGNjWVJ0bWEvRmFLVmls?=
 =?utf-8?B?VnZ1d2s3MXVSRG5uNUFwVDBnZS9CampwdFN5eEJXdGh5LzVYeFdDaEZxOTFu?=
 =?utf-8?B?S3IxODBZUDVJUWt3Q0ZQelR1TDJncnJSdmFmVTJtRGZINThpbUNLRGpQQWJk?=
 =?utf-8?B?MnhabU1yc2daR2RaM29DQldXVjZzeVlpOVE4ZDh3bUpDZ3lNR0pldmNxMFIx?=
 =?utf-8?B?c2w3QmRqYVMrUlZVa0s3Q2R2T3Jid21WaFdpcEtXOEJ2aGpvd2RtZ3hNcWVs?=
 =?utf-8?B?eCtqSUpOWis4VVFySmg2RFpwZzhUOElBZjdmYXk1aUpoa3RLby84anpHbi9Q?=
 =?utf-8?B?MVB1TVltTzBYZ1dHWDBIMm1uR3A0UHgwd2xXV000SjU3MHJINmN4Yk9TZGUz?=
 =?utf-8?B?eTdsbmRFbjBJYXlMazJiTnVTZTg4QWUzeGcvdC9CR1FUYWJ4TzJNekNxU3JN?=
 =?utf-8?B?OVd4YkNySUluK3pDd1NCcUkwQ0lERlllRGNpNnpsTEtCc0k1L21FamdGQVNy?=
 =?utf-8?B?aEgxMVQyK2QrL1hpV2ZDWXVBcmtkN2M5cC9BenNXWkJ0SlBqVjFnQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be7efcf6-c8b4-4464-9923-08da28e30498
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 06:47:52.8017
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A05PlcuQ6zm+NB2zHHkPyxt5hWv574C1vbhGKgChMhfmHsPLbM/NZkpePQ+wS7YAsHufNHLk0tH4oipq1BBPvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6832

On 27.04.2022 21:08, Demi Marie Obenour wrote:
> On Wed, Apr 27, 2022 at 10:56:34AM +0200, Jan Beulich wrote:
>> On 19.04.2022 17:49, Demi Marie Obenour wrote:
>>> This hypercall can be used to get the ESRT from the hypervisor.  It
>>> returning successfully also indicates that Xen has reserved the ESRT and
>>> it can safely be parsed by dom0.
>>
>> I'm not convinced of the need, and I view such an addition as inconsistent
>> with the original intentions. The pointer comes from the config table,
>> which Dom0 already has access to. All a Dom0 kernel may need to know in
>> addition is whether the range was properly reserved. This could be achieved
>> by splitting the EFI memory map entry in patch 2, instead of only splitting
>> the E820 derivation, as then XEN_FW_EFI_MEM_INFO can be used to find out
>> the range's type. Another way to find out would be for Dom0 to attempt to
>> map this area as MMIO, after first checking that no part of the range is in
>> its own memory allocation. This 2nd approach may, however, not really be
>> suitable for PVH Dom0, I think.
> 
> On further thought, I think the hypercall approach is actually better
> than reserving the ESRT.  I really do not want XEN_FW_EFI_MEM_INFO to
> return anything other than the actual firmware-provided memory
> information, and the current approach seems to require more and more
> special-casing of the ESRT, not to mention potentially wasting memory
> and splitting a potentially large memory region into two smaller ones.
> By copying the entire ESRT into memory owned by Xen, the logic becomes
> significantly simpler on both the Xen and dom0 sides.

I actually did consider the option of making a private copy when you did
send the initial version of this, but I'm not convinced this simplifies
things from a kernel perspective: They'd now need to discover the table
by some entirely different means. In Linux at least such divergence
"just for Xen" hasn't been liked in the past.

There's also the question of how to propagate the information across
kexec. But I guess that question exists even outside of Xen, with the
area living in memory which the OS is expected to recycle.

> Is using ebmalloc() to allocate a copy of the ESRT a reasonable option?

I'd suggest to try hard to avoid ebmalloc(). It ought to be possible to
make the copy before ExitBootServices(), via normal EFI allocation. If
replacing a pointer in the config table was okay(ish), this could even
be utilized to overcome the kexec problem.

> Is it possible that the ESRT is so large that this causes boot to fail?

I don't know - that's a question firmware folks would need to answer.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316012.534707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyER-0002Ld-Dz; Thu, 28 Apr 2022 07:06:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316012.534707; Thu, 28 Apr 2022 07:06:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyER-0002LW-B9; Thu, 28 Apr 2022 07:06:31 +0000
Received: by outflank-mailman (input) for mailman id 316012;
 Thu, 28 Apr 2022 07:06:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njyEP-0002LQ-Q5
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:06:29 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b93d5dd4-c6c1-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 09:06:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0916A1F37F;
 Thu, 28 Apr 2022 07:06:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C490D13491;
 Thu, 28 Apr 2022 07:06:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4jyNLvM8amKXXwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 07:06:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b93d5dd4-c6c1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651129588; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iIl0kSrYwn7J67McRY3rj6P7/4D8GhVWuP0EZQDyNcc=;
	b=OzwPEuSvd/SxcnLPObUc+fL5oc0eLhd8EYMB3xD40ITgZrVB3OF/73YX/dS2t5HLwrzeAu
	6DsuLLy0tSyQBxEq4EAADLICRMA5tYvhaZNlBx2eD743xcs2he2bEDxJPY0Slp5eU24B2/
	wpSgv1NZF+3FC48hmlLqb1o89vyDzlk=
Message-ID: <239ae645-7fb1-ca8c-1b37-2238313d6d1f@suse.com>
Date: Thu, 28 Apr 2022 09:06:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
Content-Language: en-US
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-3-jgross@suse.com>
 <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
 <bf19c5f8-badd-5afb-fcaa-a16483783a27@suse.com>
 <d4d36fb2-a26a-9fbd-acc6-fe97ab93fa66@oracle.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <d4d36fb2-a26a-9fbd-acc6-fe97ab93fa66@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------W4XcMcPkdQvvBS00Fc09wj6a"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------W4XcMcPkdQvvBS00Fc09wj6a
Content-Type: multipart/mixed; boundary="------------VT11Vb06Hc6uJBuYS6rHFzIN";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <239ae645-7fb1-ca8c-1b37-2238313d6d1f@suse.com>
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-3-jgross@suse.com>
 <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
 <bf19c5f8-badd-5afb-fcaa-a16483783a27@suse.com>
 <d4d36fb2-a26a-9fbd-acc6-fe97ab93fa66@oracle.com>
In-Reply-To: <d4d36fb2-a26a-9fbd-acc6-fe97ab93fa66@oracle.com>

--------------VT11Vb06Hc6uJBuYS6rHFzIN
Content-Type: multipart/mixed; boundary="------------0IRJFSWGRfIdvbdiiR0qmSeH"

--------------0IRJFSWGRfIdvbdiiR0qmSeH
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMDQuMjIgMjI6NTYsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDQv
MjEvMjIgNDo0MCBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IE9uIDIwLjA0LjIyIDE4
OjEyLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6DQo+Pj4gQW5kIGFsc28gbG9va2luZyBhdCBp
bnZvY2F0aW9ucyBvZiBzY3NpYmFja19kb19yZXNwX3dpdGhfc2Vuc2UoKSBJIHRoaW5rIA0K
Pj4+IHRob3NlIG1heSBuZWVkIHRvIGJlIGFkanVzdGVkIGFzIHdlbGwuDQo+Pg0KPj4gTm8s
IHRoZSBpbnZvY2F0aW9ucyBhcmUgZmluZSwgYnV0IHNjc2liYWNrX3Jlc3VsdCgpIG5lZWRz
IHRvIHBhc3MgdGhyb3VnaA0KPj4gdGhlIGxvd2VzdCAxNiBiaXRzIGluc3RlYWQgb2Ygb25s
eSB0aGUgbG93ZXN0IDggYml0cyBvZiB0aGUgcmVzdWx0IHZhbHVlLg0KPj4NCj4gDQo+IFdo
YXQgSSB3YXMgdGhpbmtpbmcgd2FzIHRoYXQgdGhpcyBjb3VsZCB1c2UgdGhlIHJldmVyc2Ug
b2YgDQo+IFhFTl9WU0NTSUlGX1JTTFRfSE9TVCgpLCBpLmUuIHNvbWV0aGluZyBsaWtlDQo+
IA0KPiAjZGVmaW5lIFJTTFRfSE9TVF9UT19YRU5fVlNDU0lJRih4KcKgwqAgKCh4KTw8MTYp
DQo+IA0KPiB0byBiZSBleHBsaWNpdCBhYm91dCBuYW1lc3BhY2VzLg0KDQpJIGRvbid0IHRo
aW5rIHRoaXMgaXMgbmVlZGVkLg0KDQo+IEJUVywgc2hvdWxkIHNjc2liYWNrX3Jlc3VsdCgp
IHVzZSBYRU5fVlNDU0lJRl9SU0xUX0hPU1QoKSBhdCB0aGUgdG9wPw0KDQpZZXMsIEknbGwg
ZG8gdGhhdC4NCg0KDQpKdWVyZ2VuDQo=
--------------0IRJFSWGRfIdvbdiiR0qmSeH
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0IRJFSWGRfIdvbdiiR0qmSeH--

--------------VT11Vb06Hc6uJBuYS6rHFzIN--

--------------W4XcMcPkdQvvBS00Fc09wj6a
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJqPPMFAwAAAAAACgkQsN6d1ii/Ey98
0Af/cu4+aD/v3Zce3V2IKE9L12srwwjDIhtpEYBJMuvjnHTLV15NF2J7ePzUrbqO4tORvQ+RuCY4
otgC6p39v1tD1CGW/zdSd2asFuBEwqSYjmUq3gwvG2wB27O8wXPLFMFVfJG21s2ACRyP0w6zr0VK
fEV6HVBbDv1ldWnBLyv0rpm/cFvr0snC/TtvVwieEJ/n4FwSq+S82QaSaoMnUeVlQIuzD05bu+F7
mtSWK5S4ZUS+gCXQfSMFJ1jbOcE1Lsy3BAD4LKp7UeBN7+6/zu6jGTdTMUbf3O8bBa3E5eCFrAEN
Iohw/oSsL+a0bk51DqobJxslBmh9ZZYoBa/aDduvww==
=uOXA
-----END PGP SIGNATURE-----

--------------W4XcMcPkdQvvBS00Fc09wj6a--


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:16:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:16:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316018.534718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyOK-0003oS-CI; Thu, 28 Apr 2022 07:16:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316018.534718; Thu, 28 Apr 2022 07:16:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyOK-0003oL-9Z; Thu, 28 Apr 2022 07:16:44 +0000
Received: by outflank-mailman (input) for mailman id 316018;
 Thu, 28 Apr 2022 07:16:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dcPN=VG=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njyOJ-0003oF-Aw
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:16:43 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 2659b5cd-c6c3-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 09:16:41 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 60EE4ED1;
 Thu, 28 Apr 2022 00:16:40 -0700 (PDT)
Received: from [10.57.12.53] (unknown [10.57.12.53])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC2C03F73B;
 Thu, 28 Apr 2022 00:16:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2659b5cd-c6c3-11ec-a405-831a346695d4
Message-ID: <e59dfb31-e5dd-649b-d9f7-67bcc423ed80@arm.com>
Date: Thu, 28 Apr 2022 09:16:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-4-michal.orzel@arm.com>
 <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
 <590d34a8-744f-4170-74a6-1b02013488df@arm.com>
 <0c067fff-32a9-0d21-2410-611ec9a2b91c@citrix.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <0c067fff-32a9-0d21-2410-611ec9a2b91c@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Andrew, Jan

On 27.04.2022 14:33, Andrew Cooper wrote:
> On 27/04/2022 12:06, Michal Orzel wrote:
>> Hi Jan,
>>
>> On 27.04.2022 11:59, Jan Beulich wrote:
>>> On 27.04.2022 11:49, Michal Orzel wrote:
>>>> Function unmap_common_complete defines and sets a variable ld that is
>>>> later on passed to a macro gnttab_host_mapping_get_page_type. On arm
>>>> this macro does not make use of any arguments causing a compiler to
>>>> warn about unused-but-set variable (when -Wunused-but-set-variable is
>>>> enabled). Fix this by removing ld and directly passing current->domain
>>>> to gnttab_host_mapping_get_page_type.
>>> I think we want to retain the ld / rd notation. Therefore I think it's
>>> rather the Arm macro which wants adjusting to not leave this argument
>>> unused.
>>>
>> I would agree provided that the ld variable was used in more than one place.
>> As it is not, it does not seem very beneficial to keep a variable that is used
>> just in one place and stores the macro value.
>>
>> When it comes to gnttab_host_mapping_get_page_type macro, on Arm it is defined as (0)
>> so modifying it seems to be a quite big overhead.
> 
> diff --git a/xen/arch/arm/include/asm/grant_table.h
> b/xen/arch/arm/include/asm/grant_table.h
> index d31a4d6805d6..9f68c2a37eb6 100644
> --- a/xen/arch/arm/include/asm/grant_table.h
> +++ b/xen/arch/arm/include/asm/grant_table.h
> @@ -31,10 +31,10 @@ static inline void gnttab_mark_dirty(struct domain
> *d, mfn_t mfn)
>  
>  int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>                                unsigned int flags, unsigned int
> cache_flags);
> -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0)
> +#define gnttab_host_mapping_get_page_type(ro, ld, rd) (ro, ld, rd, 0)
>  int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>                                 unsigned long new_gpaddr, unsigned int
> flags);
> -#define gnttab_release_host_mappings(domain) 1
> +#define gnttab_release_host_mappings(domain) (domain, 1)
>  
>  /*
>   * The region used by Xen on the memory will never be mapped in DOM0
> 
> It's about parameter evaluation, not about adding extra code when compiled.
> 

Unfortunately, solution presented by Andrew does not work.
We will get the following error due to -Werror=unused-value:
"left-hand operand of comma expression has no effect"

If we want to keep this variable, how about using unused attribute?

struct domain *__maybe_unused ld

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:27:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:27:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316028.534730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyYe-0005I8-Bz; Thu, 28 Apr 2022 07:27:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316028.534730; Thu, 28 Apr 2022 07:27:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyYe-0005I1-8v; Thu, 28 Apr 2022 07:27:24 +0000
Received: by outflank-mailman (input) for mailman id 316028;
 Thu, 28 Apr 2022 07:27:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njyYd-0005Ht-0c
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:27:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a445b5e3-c6c4-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:27:21 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-z0lRdeVXNk26zi8dbPq4VA-1; Thu, 28 Apr 2022 09:27:20 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8636.eurprd04.prod.outlook.com (2603:10a6:20b:43f::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 07:27:18 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 07:27:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a445b5e3-c6c4-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651130841;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=v+2MRioiVUfFC6JaahT5pqXD/IdMyfdG3fLWbdwmFCw=;
	b=nbSMwNDzyolkADUVIu3Arc46PnjQkWmOtNaCm+9QrHgVA87r97+dYib0aUf4wwtFszh7n0
	YUa2TaZVYRDcuWdD0QlGg86ICFhW+YKiAImPLoiOWIp2icj0DZN1d4D6iT+rcQiLEYh6rz
	y2ya8D3f0KwlHWfYhb7GAdRQnLuFAdU=
X-MC-Unique: z0lRdeVXNk26zi8dbPq4VA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CMzw7vtvaotWaIwLikmDifKz63xK8l2raMmThnUd3j/G5SJw26qmDqJvggVBQqm7Rs2upfDEjroDwZHAS83/SSxdTGf0/zYKzV4+LOaOwU8yxEFuxvNzB5kearrRCSWzGNFD/EaW/J8UpZ0F6CJrPL19lQ7JNTZ892R0WzbALfExs0HwP8fj+8hD3FwD1cljzU9Czvr3m2XXHaBcB8MysutyOl2/uqbcSPKawEuFSPsIxZTIO1cYzbx8nYEij0ocvGkv2/xbT3xtsA5e8JN91k0TzxmqAK3L2WiovusdEEsRFabZ6YuDiugGw9qIizQwUp6JoDRMzPrly0HHbNsk2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nmlaLJ6caXKxLsGhAN3oS612Sc6Dfi4O4FgH/hA9zDI=;
 b=fpo8HdZxW5cYNeLK82X8WNcTLn9mOQcX0Eo/P9nORLGxaoFVY8uEVUsiwCjHbh3SV0F/WwXJLWu81wRi/9XMx57u+QgYu9RELLoxaWjO8KClyi2hqQx0uy23t/E/WGrMoiVR6lSSaSwPdjdbtOBergCYqhKNxeepkoLgBBvjBXENpRN0oH/ctYjTMVs+idB6bnL/aWUqCcWCv+nDZo5cZAbDMaDEo13/LBcRwVQVRpo34jP6k5gaA6oUdN998fZGX4zOrSijXsMhLYped1m5UFFA6xPeSS1hCAj9AD7tR9gtM8Dm9Aq0J42iJdGScuuFoA/cDsd9jAoH8iNkG4iovw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a95ab39e-f1a8-470c-735f-bf970a670b8a@suse.com>
Date: Thu, 28 Apr 2022 09:27:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-4-michal.orzel@arm.com>
 <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
 <590d34a8-744f-4170-74a6-1b02013488df@arm.com>
 <0c067fff-32a9-0d21-2410-611ec9a2b91c@citrix.com>
 <e59dfb31-e5dd-649b-d9f7-67bcc423ed80@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e59dfb31-e5dd-649b-d9f7-67bcc423ed80@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0150.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c546275-88b2-49cd-c31a-08da28e8867f
X-MS-TrafficTypeDiagnostic: AM9PR04MB8636:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8636B472FBB4C657E05C3A12B3FD9@AM9PR04MB8636.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EkTfWrGR6AI6XbkKlv4E+ATCdLwBCMbS7ZmV7lHJrOYIR3aYGL1GgZlyJAWDGXRIZhAgM1HxHjIFE2XA6dnioov+XUvwo9TzGF3DerYS7+ARBAaTEqfEi15PDWgQ4YBfkVvS6sInvXlBU79Lco1BfwoSf9fDWhyBOPPpp2uMI6VvZpkq3J9Y1G1p+wJUPMwMW3OOOpeoqAOFLnNJ/jAofytii4Gj1Ylyz2/rr0SLqqhGNqSQAjB+iFOaw9lqbLgMz0xWZegxwKz+fK8hZoBWvjynpDdk7d9bvsoc/gq70q9YE57QfS2Eqvgd0ssrCVlNsBgK2uuzcLSwumgfDd9YdYy8iiD21JfUZ3fwAZwo3N91L0+NdwanxWyYfFpSRKdUWhllI0IW/gRj0w1pwNp/kKXwy9Qb6C2y3OWyloIqJdzoC87Qdf2cUhClogBR2VsHO/W66K0cOFIIvOJJG7l0zQRNwZs93WNK0eeSZWPxeriu2u6nvLym54OGUpwQeIuPYzl3MtlfHgyOrKPJfNv+hikI8z28MfBN4eovxHVqT+MIwI3hFuzxmCvTz0i9EMlF5JzJ/vGvX+GQAUi6FuyepR1EB27gla/6S7ogJSOXPqU9TdUKo8U+ElC1XfNGOKaZJ+Q0AT9zAWr+70B2F9sOzYax0pTuJKhm170mz6RE+aSI9x1esJjSSAZyFzbRCpZBxdscZdMeRkRPaGNU3hDu7prbMt8xncOWv53fEqyz/sXHdniF5ma3dzO+nc33lqAc
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(6486002)(508600001)(86362001)(2616005)(26005)(6506007)(53546011)(6512007)(38100700002)(186003)(66476007)(316002)(2906002)(66946007)(36756003)(5660300002)(66556008)(8936002)(54906003)(31686004)(6916009)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fMVWxPZcUMz8c4WvpTjBqb73fbca80p0N/hdqt+BHZhbzkLTRU2MifarYRRr?=
 =?us-ascii?Q?QErRVinrk92b5tLSs9jnBwRoWsnGp187MpUY321CPrzwnv38FYhQanemD04u?=
 =?us-ascii?Q?hAXHpX14WJdQ7u2Q01CMxrUVeSkinwHfMsJZlxSroOnQdGjQzHF8n2YvD+cA?=
 =?us-ascii?Q?6IUbiAtWypcZ56+2Gk21UACPruCDE7TtGrs95TyNZiLu6ppl6jTs8NZhiMhD?=
 =?us-ascii?Q?zy68O27qDCkM9mBmCGZPJPHdPsT+LFS284oiGv4/u6G0Q8aolNqq7myZn8TZ?=
 =?us-ascii?Q?hjFYFmrEQFvI2fi3CqbvLySm9vgJD+5nfYDxFjGSY/qoQIG90DHeUSJD0ClQ?=
 =?us-ascii?Q?dTQ+YhtzGoiLBg2x3Xmia5h38CBStX8ekPOrh57OAmJyfdQx6phY8isp34az?=
 =?us-ascii?Q?2j6Yv3qjtO2EnKjXzljOGKbuEcNQgZ+EVEQlG0LDLHxAIwRxGawaBP8QfS34?=
 =?us-ascii?Q?IehiemUqRScc+4fqD9XeeCskIKHMp5SNE253xSe3N3uDXa0mnkqPuWyGOAJx?=
 =?us-ascii?Q?eAUCdMRYnBhql/uMZTNeRU2Xq/W72bVzCzhvAFR2L9sN+AFaPzCrRmgGeFT9?=
 =?us-ascii?Q?neTGaXd6YG722o7gSLoKNIX7aXmw46YcvgYJsfevzUyJw/hP+9y+kftXqJ2+?=
 =?us-ascii?Q?f1R1sqa3Em5JcjUtjlZ5oHaMkFVLWTB9zp768WTd883e8DJ7YOd19qy1jUh6?=
 =?us-ascii?Q?rLI6hUa+YXYWHPpUav2FiK5hfVmYTUA/mUZHHRYMQ0ajjfmjgT10X/AhqDZl?=
 =?us-ascii?Q?tzad5AAzw0TwtcCSF8vD1BxTBuEeLTgTcE5YQS/nfekHn//PnCPZ7+ZPVMc6?=
 =?us-ascii?Q?jNWEu4Ar6U4Mg4WaJB4P5U0hp6BEzkZlR9dC+WjiX5EwXeblYhjWDB1rDaEu?=
 =?us-ascii?Q?IoSg9bmQHttLNATFgP5OjbCEYpcLhYyq0YJGJqKyUTIRwYOaMdaa7WebNDAC?=
 =?us-ascii?Q?WiVUzYQm3ZcqFaw5jcZYzBqjUf1sW0ocNAVnWz3YtNywEErHkGzNhau0AWZO?=
 =?us-ascii?Q?MdqM+jwP3luqpKnAQb3wh/gg1/PpXZQJsBaLI+4fUYGGRPbErBygaRgvF+vH?=
 =?us-ascii?Q?9cyanwnLZezNUj8W6WKx3xLu1RcQ+B53Q+UP/LRYDs5C9UbQfHg0FtawEdKQ?=
 =?us-ascii?Q?DgD6kB9sid2wLJtOaeq0SV+4nT6Nze9pqlIaH4pWg2u6WaDcso0hZkoS2WQE?=
 =?us-ascii?Q?gvBp9Q9/ZmMyIBx7mjJQbWgfVVoxzBePI+puWd6JzPa3vsNvoQo4slm531zx?=
 =?us-ascii?Q?PR8OwlNjd/IxcttbF//2UlM9+iFBB+lkp9+OOQMcv5KwWt+zeOokGWAvZCzc?=
 =?us-ascii?Q?R8j5xMTgVWoYe5zrfeqSP3fSp40sE2/UucfUFdjtScGGjvB7D/aHCCtv0qRo?=
 =?us-ascii?Q?eijHrwy12oJyucMZ3ZE9HyUL5Y9WzBR28V6XZLX1TYxqKmLzhjCz7E9P+6x4?=
 =?us-ascii?Q?et+571WjV3wHbsW3BBqRSvEE4EopS2CWAw+yTVIW1CeBcneZgvW8ThtuuFqT?=
 =?us-ascii?Q?waTeuvY5yqb2z5e9xDE9xv+P6RUj2c/NBP4sLD0dk74kbOCOM4damnVsogC2?=
 =?us-ascii?Q?5Bv/Ppd126qT3esTyDn20J2Yx12w5/4we3N4c/PXhb0aGvJEZySS6grZafng?=
 =?us-ascii?Q?Chn3G0MbY/fsLrW8xb4IOGP2iG9w/ryRERLPBloYAXMCQx/GKvgzx74UkA+h?=
 =?us-ascii?Q?rmm+7VQTd0vH4NZ+Yp/ltFwc4kZc+NttKjW4lXD5XV3txgPzvCm1IDYUgsOc?=
 =?us-ascii?Q?jvsl3qK3DA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c546275-88b2-49cd-c31a-08da28e8867f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 07:27:18.1796
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5HCzRu/y1Ai4Gcf0mpdNsDxr2PsFXhGpu5zamSr313ip1lSX/SuZUUZ6ID3DKEhNgmV6tUF+AvM3ma7Y1NqptA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8636

On 28.04.2022 09:16, Michal Orzel wrote:
> Hi Andrew, Jan
>=20
> On 27.04.2022 14:33, Andrew Cooper wrote:
>> On 27/04/2022 12:06, Michal Orzel wrote:
>>> Hi Jan,
>>>
>>> On 27.04.2022 11:59, Jan Beulich wrote:
>>>> On 27.04.2022 11:49, Michal Orzel wrote:
>>>>> Function unmap_common_complete defines and sets a variable ld that is
>>>>> later on passed to a macro gnttab_host_mapping_get_page_type. On arm
>>>>> this macro does not make use of any arguments causing a compiler to
>>>>> warn about unused-but-set variable (when -Wunused-but-set-variable is
>>>>> enabled). Fix this by removing ld and directly passing current->domai=
n
>>>>> to gnttab_host_mapping_get_page_type.
>>>> I think we want to retain the ld / rd notation. Therefore I think it's
>>>> rather the Arm macro which wants adjusting to not leave this argument
>>>> unused.
>>>>
>>> I would agree provided that the ld variable was used in more than one p=
lace.
>>> As it is not, it does not seem very beneficial to keep a variable that =
is used
>>> just in one place and stores the macro value.
>>>
>>> When it comes to gnttab_host_mapping_get_page_type macro, on Arm it is =
defined as (0)
>>> so modifying it seems to be a quite big overhead.
>>
>> diff --git a/xen/arch/arm/include/asm/grant_table.h
>> b/xen/arch/arm/include/asm/grant_table.h
>> index d31a4d6805d6..9f68c2a37eb6 100644
>> --- a/xen/arch/arm/include/asm/grant_table.h
>> +++ b/xen/arch/arm/include/asm/grant_table.h
>> @@ -31,10 +31,10 @@ static inline void gnttab_mark_dirty(struct domain
>> *d, mfn_t mfn)
>> =C2=A0
>> =C2=A0int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int flags, unsigned int
>> cache_flags);
>> -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0)
>> +#define gnttab_host_mapping_get_page_type(ro, ld, rd) (ro, ld, rd, 0)
>> =C2=A0int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long new_gpaddr, unsigned =
int
>> flags);
>> -#define gnttab_release_host_mappings(domain) 1
>> +#define gnttab_release_host_mappings(domain) (domain, 1)
>> =C2=A0
>> =C2=A0/*
>> =C2=A0 * The region used by Xen on the memory will never be mapped in DO=
M0
>>
>> It's about parameter evaluation, not about adding extra code when compil=
ed.
>>
>=20
> Unfortunately, solution presented by Andrew does not work.
> We will get the following error due to -Werror=3Dunused-value:
> "left-hand operand of comma expression has no effect"

Perhaps

#define gnttab_host_mapping_get_page_type(ro, ld, rd) \
    ((void)(ro), (void)(ld), (void)(rd), 0)

?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:32:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:32:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316034.534740 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njydm-0006jL-Vv; Thu, 28 Apr 2022 07:32:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316034.534740; Thu, 28 Apr 2022 07:32:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njydm-0006jE-TA; Thu, 28 Apr 2022 07:32:42 +0000
Received: by outflank-mailman (input) for mailman id 316034;
 Thu, 28 Apr 2022 07:32:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dcPN=VG=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njydl-0006j7-UN
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:32:41 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 625eb518-c6c5-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:32:40 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF66BED1;
 Thu, 28 Apr 2022 00:32:39 -0700 (PDT)
Received: from [10.57.12.53] (unknown [10.57.12.53])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CA533F73B;
 Thu, 28 Apr 2022 00:32:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 625eb518-c6c5-11ec-8fc3-03012f2f19d4
Message-ID: <96682d17-9fec-0c00-5cba-55cd728c0646@arm.com>
Date: Thu, 28 Apr 2022 09:32:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-4-michal.orzel@arm.com>
 <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
 <590d34a8-744f-4170-74a6-1b02013488df@arm.com>
 <0c067fff-32a9-0d21-2410-611ec9a2b91c@citrix.com>
 <e59dfb31-e5dd-649b-d9f7-67bcc423ed80@arm.com>
 <a95ab39e-f1a8-470c-735f-bf970a670b8a@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
In-Reply-To: <a95ab39e-f1a8-470c-735f-bf970a670b8a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit



On 28.04.2022 09:27, Jan Beulich wrote:
>>> diff --git a/xen/arch/arm/include/asm/grant_table.h
>>> b/xen/arch/arm/include/asm/grant_table.h
>>> index d31a4d6805d6..9f68c2a37eb6 100644
>>> --- a/xen/arch/arm/include/asm/grant_table.h
>>> +++ b/xen/arch/arm/include/asm/grant_table.h
>>> @@ -31,10 +31,10 @@ static inline void gnttab_mark_dirty(struct domain
>>> *d, mfn_t mfn)
>>>  
>>>  int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>>>                                unsigned int flags, unsigned int
>>> cache_flags);
>>> -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0)
>>> +#define gnttab_host_mapping_get_page_type(ro, ld, rd) (ro, ld, rd, 0)
>>>  int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>>>                                 unsigned long new_gpaddr, unsigned int
>>> flags);
>>> -#define gnttab_release_host_mappings(domain) 1
>>> +#define gnttab_release_host_mappings(domain) (domain, 1)
>>>  
>>>  /*
>>>   * The region used by Xen on the memory will never be mapped in DOM0
>>>
>>> It's about parameter evaluation, not about adding extra code when compiled.
>>>
>>
>> Unfortunately, solution presented by Andrew does not work.
>> We will get the following error due to -Werror=unused-value:
>> "left-hand operand of comma expression has no effect"
> 
> Perhaps
> 
> #define gnttab_host_mapping_get_page_type(ro, ld, rd) \
>     ((void)(ro), (void)(ld), (void)(rd), 0)
> 
> ?
I already tried that and it won't work producing the following:
"error: void value not ignored as it ought to be"

Michal


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316044.534751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyg4-0007Nz-Fj; Thu, 28 Apr 2022 07:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316044.534751; Thu, 28 Apr 2022 07:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyg4-0007Ns-Cp; Thu, 28 Apr 2022 07:35:04 +0000
Received: by outflank-mailman (input) for mailman id 316044;
 Thu, 28 Apr 2022 07:35:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dcPN=VG=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1njyg2-0007Nk-H2
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:35:02 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id b65da805-c6c5-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 09:35:01 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB89AED1;
 Thu, 28 Apr 2022 00:35:00 -0700 (PDT)
Received: from [10.57.12.53] (unknown [10.57.12.53])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 09CE03F73B;
 Thu, 28 Apr 2022 00:34:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b65da805-c6c5-11ec-a405-831a346695d4
Message-ID: <9644d113-de8d-6afa-85fe-2b7bb6a018f6@arm.com>
Date: Thu, 28 Apr 2022 09:34:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
Content-Language: en-US
From: Michal Orzel <michal.orzel@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220427094941.291554-1-michal.orzel@arm.com>
 <20220427094941.291554-4-michal.orzel@arm.com>
 <313fdb48-9164-3165-365b-5073b09e68da@suse.com>
 <590d34a8-744f-4170-74a6-1b02013488df@arm.com>
 <0c067fff-32a9-0d21-2410-611ec9a2b91c@citrix.com>
 <e59dfb31-e5dd-649b-d9f7-67bcc423ed80@arm.com>
 <a95ab39e-f1a8-470c-735f-bf970a670b8a@suse.com>
 <96682d17-9fec-0c00-5cba-55cd728c0646@arm.com>
In-Reply-To: <96682d17-9fec-0c00-5cba-55cd728c0646@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 28.04.2022 09:32, Michal Orzel wrote:
> 
> 
> On 28.04.2022 09:27, Jan Beulich wrote:
>>>> diff --git a/xen/arch/arm/include/asm/grant_table.h
>>>> b/xen/arch/arm/include/asm/grant_table.h
>>>> index d31a4d6805d6..9f68c2a37eb6 100644
>>>> --- a/xen/arch/arm/include/asm/grant_table.h
>>>> +++ b/xen/arch/arm/include/asm/grant_table.h
>>>> @@ -31,10 +31,10 @@ static inline void gnttab_mark_dirty(struct domain
>>>> *d, mfn_t mfn)
>>>>  
>>>>  int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>>>>                                unsigned int flags, unsigned int
>>>> cache_flags);
>>>> -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0)
>>>> +#define gnttab_host_mapping_get_page_type(ro, ld, rd) (ro, ld, rd, 0)
>>>>  int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>>>>                                 unsigned long new_gpaddr, unsigned int
>>>> flags);
>>>> -#define gnttab_release_host_mappings(domain) 1
>>>> +#define gnttab_release_host_mappings(domain) (domain, 1)
>>>>  
>>>>  /*
>>>>   * The region used by Xen on the memory will never be mapped in DOM0
>>>>
>>>> It's about parameter evaluation, not about adding extra code when compiled.
>>>>
>>>
>>> Unfortunately, solution presented by Andrew does not work.
>>> We will get the following error due to -Werror=unused-value:
>>> "left-hand operand of comma expression has no effect"
>>
>> Perhaps
>>
>> #define gnttab_host_mapping_get_page_type(ro, ld, rd) \
>>     ((void)(ro), (void)(ld), (void)(rd), 0)
>>
>> ?
> I already tried that and it won't work producing the following:
> "error: void value not ignored as it ought to be"
> 
> Michal

Sorry about that but I was wrong. Your solution does work.
I did not enclose the params in parentheses.

Michal


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:38:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:38:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316055.534763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyiv-000822-Ux; Thu, 28 Apr 2022 07:38:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316055.534763; Thu, 28 Apr 2022 07:38:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyiv-00081v-RA; Thu, 28 Apr 2022 07:38:01 +0000
Received: by outflank-mailman (input) for mailman id 316055;
 Thu, 28 Apr 2022 07:38:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njyiu-00081p-EZ
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:38:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 20546926-c6c6-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 09:37:59 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-0a2SitAAMBazZ3E3fFe7GA-1; Thu, 28 Apr 2022 09:37:57 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Thu, 28 Apr
 2022 07:37:56 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 07:37:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20546926-c6c6-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651131478;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jpyXo+XNIcGRF8MJRnRZ2D7gULwPWD7uHEaNlOZyadc=;
	b=Xf7/jJW9cRhx0IsUzQbhF2SseB3ywOlE6excNgzAmFUs8APTVwyvCzBciY6avzyTYEQtbf
	j8TMJ+bVy0c9AFc6H32lwlpzPldGbLej66h2q6/KV87RNtpHl5kQTKulFUkP6fa7N/rE2F
	7UtmQQ/SuLsGhjXOLtapLF8PLJdptp0=
X-MC-Unique: 0a2SitAAMBazZ3E3fFe7GA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OERzuoFNYABhIV7SUm9xyJu0qrJSOJEFcHGg++hKM5IPIRpM3PGL6FZ6mTEN/oT8/H/dqnnzwsqaGRx68BRwXhgPIUI1xk+vtL+nePbbKI/usPXlP8GajveIRr4ehoiozGPzLV0QA65hyoSfmbOnHSu1HQ5hMW1LN18ry8/pY6Mag7zUYqJva/5Ul1Is6VWZnm9rHTro2uv/ocmEn+yuZg5SKNi9JjMgkYrA+9y1X5l9v4u6shtJcTMovBc/95pl2bNrDbUFteNx94DK1D8ZVkYHwXSwCTgKoOI3bkOsnwTbJzZmsEnIO8ewuPP/MrgSoqEB3i2QudVngN/KO7593Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FphS4XsfYHTG00AUkSQE2yNVd5XBhlXUgZVS3bwdTR8=;
 b=DoFZ+TLagRtjytAFD+v86GX+642Ztu/2mTdYM1G5darDGoW8VsCsTFgWPMqVStAa/5mdR/xIBTsLm8aIvV2SVHk3ErljFNUweJlimq9igPeY8vgEjvomOwVQiy7ve0xHBf+8te6epsB8IxS7dY0JEQH1jnbvEZluqlek2+wjBoLGSDba8FdTh0cbpH+WdAthaLah8dHju3DaE4kKkA0FTYadsnki5r8ptZJW6CRXlaL6iElyiTccv/xKCe9vEfNNe3Ty0PEhRzCBTBrfcETqDb7zvY9GQid/IQKLBGjoCihvnEnNE9nFvs4VJ7AAEw0HZKQnEoPvNlVBjEY++JV5Kg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <aaa32800-bcad-3a7d-34a3-2e51c4ad9aa1@suse.com>
Date: Thu, 28 Apr 2022 09:37:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: Regression with CET: [PATCH v1] x86/mm: avoid inadvertently
 degrading a TLB flush to local only
Content-Language: en-US
To: David Vrabel <dvrabel@cantab.net>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220419150320.64783-1-dvrabel@cantab.net>
 <6076f458-a56f-448b-2001-6af38b998edb@citrix.com>
 <b5234297-c70c-ffc8-9104-99eb6f5a0e24@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b5234297-c70c-ffc8-9104-99eb6f5a0e24@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0545.eurprd06.prod.outlook.com
 (2603:10a6:20b:485::15) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cf095346-ad28-4ad3-24fc-08da28ea02c5
X-MS-TrafficTypeDiagnostic: DU2PR04MB8631:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8631ADF7AABA136A4C169DE6B3FD9@DU2PR04MB8631.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2fQl3hXDu509UNAvQPwwiQePDYKfQVwb1ZXhnw/tjqZ0p9meu+uYqUK9FeWQAv1m6RgP/1DiE4Pzqixy1fpwPtPhlW/on5vWBTGA0vQMQHsSgGQ+ViSzI9P4DTRHaIiAyvRc0H0wkASQFBDItdrRIpVsSLYI5BOQMxlDfkOGRxuYgtsZCBdkn/C86HHEXV8KUZ7zHuYmIs9PZ8FG4JAjsmBknJDt1X7TamPwwq1brm5e2b5hqXH7zZM7R0EkpZs11RpuHkMIr2gR0VRpZhvTJWGUBXNwAITgk0RuMBl/Pj0JMEB50PMZ7iNs/EQArHtCpZr2if8bGGWyt2NVb1vHoOHHZABiApycgCkPPbuPT+738PJ/wDs6ieyf8mLx5JyHlsPo/FmLvw0xwXwsjf6r6SqULC4Ul73f/zIw67VsrsstbfoXyIdHpeRS2EB57AXSvykhaab+fWLNKgmDWzZPy4xOOA4BmhUQTmOR7ox9FB33AMlwWB/5uAWUOBWUcyZwfwNaZSKPmrW7puPoNgNVM2G8rALQSxN/iUslhEvK0wLNKEGcd6h9PpZT4O4qtMOZVie9MROwa6OfkEtBq7uapy1dTe0NqPzvZKHDdh9ivTWIzOgaLUJM/jcsgsfleFLtVVJEn/vn69YBukVzjcVa4HNKyEr9jG9cJP+dR5R+67kpLC/Suz/v0DkZGHrjHuUqEDe+SytgiO/QboIQ+suTTQSIBnmNn9CF1CYjASEvKUmZOI3iy6q09HlTzqrsq9yP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(26005)(66946007)(31696002)(31686004)(66556008)(83380400001)(6506007)(53546011)(66476007)(4326008)(8676002)(5660300002)(54906003)(6916009)(86362001)(2906002)(316002)(36756003)(38100700002)(8936002)(186003)(508600001)(2616005)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gyQKOUuqNHrzYx+JFIi91Yp6eQgANyvRVr+eixcz2ZMGal7CT1hiczZhc8ai?=
 =?us-ascii?Q?24B8t3N4oQhLtdMqdplHgxkqmc44m7n8T9DISsrOnlKrk+rIhIlNb6k1e5h4?=
 =?us-ascii?Q?7mWXDwQco2uxTmxYWRNq9lZH7yKJKAfdnr4/x7Y9UsDG6NtT5rhP89JaP1rN?=
 =?us-ascii?Q?dff00TMQJWCpXGHKPx7Pas3faOUW3yt6e5G57551mQbukZVpUZukGPZvn1x7?=
 =?us-ascii?Q?LTpn7Tfl1HFFGYDETUoArJkmzfd3yNRSaQwvxOaeqEYraWmyS1A2lVHjXlUt?=
 =?us-ascii?Q?CdaeLrjtRNWlUGQyzqR7uWPcAZ3lqCCoQqhQneFB3jrv+LP6MbupkZv6RRfY?=
 =?us-ascii?Q?nhz6ZKTqRhXxU0+b1wxLRIExRSF4RaF4rSb3VrVqMLbvS9C84GwoP4C5gvO2?=
 =?us-ascii?Q?79ahcfP42H+Z9KGrkJSU/yPPejpgGbxbVPmZ56a85B52exfUV4ks4XpgBSRo?=
 =?us-ascii?Q?liI9ohqu156ilBvbth7+225kMGesSA1pdciZFhAUQBVp/OScuRt9I+2hHvef?=
 =?us-ascii?Q?MVEI4hEj+YO67PEV6/Cz6IZ9qWp7rJx5CpHKnG7FagMRkifuW4CkzKe8NzzF?=
 =?us-ascii?Q?D2W2xzw1mKbup5wG+CCHp2Z6wU/mZbjuVZ7bsJ9Ru0Dr6UWS3BzJP2EtT6Er?=
 =?us-ascii?Q?8g+Duw1PVFJvCWA8N5lsckItOt9KlveWjGct2koIr8zkexonJNFh5mEjBKsS?=
 =?us-ascii?Q?/ABFr5HTt5FqLGOHp48Jd9yQMXWc/253jZWQbq2ADa/iiToFeakmOua51Soq?=
 =?us-ascii?Q?5ra0EYJFlPG1THK5qmEuhjQJ2aujOAYLXgGwLGaZmDmXoXvL53+r0Xu6DNxJ?=
 =?us-ascii?Q?kr60ly4/ITN1mWKFmpdRvaKpES3Xnq3TL0z+RdEUukHg8nnDy258Q+7KjotI?=
 =?us-ascii?Q?m2lqO5eJ1NviGKzmOWLb0NGgVtJN1L/bbbDHtzFX47htYMNLrFhkH9YD7n65?=
 =?us-ascii?Q?+A1p4A6PouzNAkCBpVK18nx5YYvbZEjgxsKC9bL6caaxKl/+ZCwE48t1ub8S?=
 =?us-ascii?Q?Wg/LkIXGDoRoRky04eCGm459S2AhMcGWVMfVaPiaKlHE0ob25gdFdWQ3Yr52?=
 =?us-ascii?Q?DQ2zKnWBm+uADqeUzGsocsymLEXx76TKpaAQuidzMRCh80VWT5cRGGOUU2jq?=
 =?us-ascii?Q?YFMhkgTUM5tagnl96YFquI6wjH7BrG30PbwwjeZ/dSQB8daVVEyMNrnxEzk2?=
 =?us-ascii?Q?vwo+Yt1+fQlGtznDq84fHCYgJ38AhwPqBOIjv3+cyQDM9skA1dV0NMOFAvjT?=
 =?us-ascii?Q?HfoSsLORk28YEqWH0zhQUg2nPRG7cR7v3Mco7ETZceJZDxIQJy68LtBn2Om9?=
 =?us-ascii?Q?H2H0B/C15W5MnI9PWtnFgoJrZqRbTv8JAtSIIRYtDQedVo5srqjcmUxudY7s?=
 =?us-ascii?Q?bYA7Mi60Dc2lFLE1v1tNylxg2sIGyZ3CjMaJt/GkwqW0VWe9/t7zZKziNOsX?=
 =?us-ascii?Q?vtKWSzRCGu2rYMgZkivd08E12mAKfMQaUQ9t4L5a86Ox9aAUgU9ueUzFCKzc?=
 =?us-ascii?Q?gR0BJ5I1KIxFb0FiKjZJMtjKuHe5aRyhvvEqvLtXvRcNpcsiKt2AfrUeJo5t?=
 =?us-ascii?Q?bpReGuejHJ1oaCbHSl7XCseCtcz6LfKsvUt8F+zglCjTmsDW9hPND+HQcmA6?=
 =?us-ascii?Q?BvUiYY+Kczc89epDV1SXAHol4/v2JzAYff4VAacl/vXVXqbI9m/JACYwisos?=
 =?us-ascii?Q?4PVxsxfPUqgI5sqwvWAs9tVt9j62btnJmuUQp8iMhVLnZaL2b39vLGC1rRZ4?=
 =?us-ascii?Q?7jHe4D7V6Q=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf095346-ad28-4ad3-24fc-08da28ea02c5
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 07:37:56.2127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t0rvHuukeBOMPKvsSbV2m0l4Ws3JSCKD/q8JJ9Lt8Vvj7Cpu0Mhkc/STwk4zwChn0j4SPc6nEpFtO71qkQq4FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631

On 27.04.2022 20:44, David Vrabel wrote:
>=20
>=20
> On 27/04/2022 19:03, Andrew Cooper wrote:
>> On 19/04/2022 16:03, David Vrabel wrote:
>>> From: David Vrabel <dvrabel@amazon.co.uk>
>>>
>>> If the direct map is incorrectly modified with interrupts disabled,
>>> the required TLB flushes are degraded to flushing the local CPU only.
>>>
>>> This could lead to very hard to diagnose problems as different CPUs wil=
l
>>> end up with different views of memory. Although, no such issues have ye=
t
>>> been identified.
>>>
>>> Change the check in the flush_area() macro to look at system_state
>>> instead. This defers the switch from local to all later in the boot
>>> (see xen/arch/x86/setup.c:__start_xen()). This is fine because
>>> additional PCPUs are not brought up until after the system state is
>>> SYS_STATE_smp_boot.
>>>
>>> Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
>>
>> This explodes on CET systems:
>>
>> (XEN) Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265
>> (XEN) ----[ Xen-4.17.0-10.24-d=C2=A0 x86_64=C2=A0 debug=3Dy=C2=A0 Not ta=
inted ]----
>> (XEN) CPU:=C2=A0=C2=A0=C2=A0 0
>> (XEN) RIP:=C2=A0=C2=A0=C2=A0 e008:[<ffff82d040345300>] flush_area_mask+0=
x40/0x13e
>> <snip>
>> (XEN) Xen call trace:
>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d040345300>] R flush_area_mask+0x40/0x13=
e
>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d040338a40>] F modify_xen_mappings+0xc5/=
0x958
>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d0404474f9>] F
>> arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9
>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d0404476cc>] F alternative_branches+0xf/=
0x12
>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d04044e37d>] F __start_xen+0x1ef4/0x2776
>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d040203344>] F __high_start+0x94/0xa0
>> (XEN)
>> (XEN)
>> (XEN) ****************************************
>> (XEN) Panic on CPU 0:
>> (XEN) Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265
>> (XEN) ****************************************
>> (XEN)
>>
>> We really did want a local-only flush here, because we specifically
>> intended to make self-modifying changes before bringing secondary CPUs u=
p.
>=20
> I think the transition to SYS_STATE_smp_boot system state should be=20
> later. i.e., the last point were only 1 PCPU is guaranteed.

I'm not sure there isn't code which assumes pre-SMP initcalls to happen
in this state already. So it may take addition of yet another state if
no other solution can be found. Additionally, how would you mean to
deal with the PV shim case then, which continues to be running UP quite
a bit further?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:40:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:40:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316061.534773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njykx-0000sA-Ad; Thu, 28 Apr 2022 07:40:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316061.534773; Thu, 28 Apr 2022 07:40:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njykx-0000s3-7S; Thu, 28 Apr 2022 07:40:07 +0000
Received: by outflank-mailman (input) for mailman id 316061;
 Thu, 28 Apr 2022 07:40:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njykw-0000jl-5v
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:40:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6ac155c5-c6c6-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:40:04 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-ltkeR-PMN6S8zyg4oTtvVg-1; Thu, 28 Apr 2022 09:40:00 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8759.eurprd04.prod.outlook.com (2603:10a6:10:2e2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Thu, 28 Apr
 2022 07:39:58 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 07:39:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ac155c5-c6c6-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651131603;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Odiby0lIs7X4yMFQcSfohiqhwYd8gHakN4kP6umWyoM=;
	b=CVGoEHL9OxZ0sg6103z3QvPw1L3D3F762lPSt5Hjc5G97EJxJa4S6JEPdlZCP7vMsS1p1M
	a6VQNuQMw0LAFuoW/7rMCvju1wKjgg4+KlY9VxP073DicpTqMPIG4UmRFNlDWQEnWbrLtY
	vW+hFRgfzgDfIKngnd3PjEI+4x71JkU=
X-MC-Unique: ltkeR-PMN6S8zyg4oTtvVg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HCqOu/kEb/lhnHRNfDdicFYe/vlwC2dXuoiu8+NtkhOrzrgFsNOYdu+TyMpjR1RYPj1dAvbu9GRcd888VLHEg26v3m/DVXNv5nMbDAUp1CeiOfHu5qssWffyocg3pP0yiK+Cz5s2x4vt1Z+TMRlu/Mwh89MO3LBFTJe//C85PFa/yGuecXP96z5QzaptUDA2h1URGVJ9Ogn3rBF5yAoSSjxWcAtnLxBVBIKKqZ9DPjVbhfu5UlaUTYtGgCLjl5eNrEdPByD2Ras49o5TUixI5vA/PnyQpsZamfItqi5wYRK86+NwfptFnF4VOfDlBYR3CgUmzeZJ429OCkQwRk81JA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aooAZuzOsOb9Y9yf3pU6UWpZIsTsKdMGT5uy357NJyA=;
 b=l2k81vm7qnoKk7lp22bW0Q/BJIYwCOhRbffxivtsrvBGaE5qHQfRCodry/WBe7ptGzADPr/zU6V2wTdk1qIDHvFVSyJX7t2y6Ek9hCrnEtZ31MTJpBoyYYPo3BDP5XmIWCooyOmjRlsfT+zVKRGe0CM6pS+478jTdfDdxn2tjKOIEOLFzMWSVs69JEVjvHXu3u9zy8Kr6hwTwtYO5ichNf9TUqGN/4wA6D1F60jXpq72wHgERZ1z2GLGugg5JUdw6jSwIKrh+itb+oXXjVyT7KW8byST2MzsUpMYaSpvF9PgdxjLrDenLzYLHvwzUTA0uezP5YdnMElSaY5jOnJDsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7835a3c3-7f27-fde1-87e7-bde558d9fefa@suse.com>
Date: Thu, 28 Apr 2022 09:39:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: Regression with CET: [PATCH v1] x86/mm: avoid inadvertently
 degrading a TLB flush to local only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: David Vrabel <dvrabel@cantab.net>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 David Vrabel <dvrabel@amazon.co.uk>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220419150320.64783-1-dvrabel@cantab.net>
 <6076f458-a56f-448b-2001-6af38b998edb@citrix.com>
 <b5234297-c70c-ffc8-9104-99eb6f5a0e24@cantab.net>
 <aaa32800-bcad-3a7d-34a3-2e51c4ad9aa1@suse.com>
In-Reply-To: <aaa32800-bcad-3a7d-34a3-2e51c4ad9aa1@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0068.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::32) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a25f533c-cf64-4011-9cb1-08da28ea4bce
X-MS-TrafficTypeDiagnostic: DU2PR04MB8759:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB87597E44F8A33DA6A491D144B3FD9@DU2PR04MB8759.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5zhDudwzPsBClBUHrv8cOrd0Uzf7pr1RLuGajT1dJJmOg9YwKLZrc6yEwhkYajWFgmJMMl+h0PPLQfMWDRmPl+qyGxaWFD5uQlfSFTHq5BYcH37Z2F+qzHqx5bXImBZZbdiHwucmUYWbezWG5rg4RrmJg1+q55khNul59tzQyInInQFTF3FDUgm83HaVCfIU2YXUrk+BPvT0NCCA5hQbMALpEyJcnjhTH7ZmQuR4WTE+d9gFeBo1nFZWkGM+XuGk8ZQdywkuKue5VlYffTn2aRgXgmkF/C6JEJ4doCrYydklZ8998/0mJn0mcKRIDl/7rVgQLvL03nJGpEeBL2IC+SmK2XQ2do/pp9bPuDMbvAdRkB2gcj72K8OtRCf3/cAe/C2ippACNkmSjiR5gJbd0ZaRAJy6fS/1tfA9n24FOuyfPOKTrWVHvYRCeiMJuuEce/DSBLO6SW87COOgmJOvFbJgwji0dC9Y9nAgSMn1rYTxG84bA05qHAXepDbIQ+mII1D+bjFjp6RiIO9AIx8gDJ19+6Aq3aib3FtH11WtXSbZCmX0E3t39K5ayK5LRBNI6rUpn9aXtPaChooSYWryRaLEX87qpZDTnG4C9CsSysgy6RLC4qlGvwMRmQX92kI1+2GM7xsqDFV0rRH7rr1Yt9t84KchGcpxfQQYRd8OkptLY1cPNIzk/0DPe43bZgzfuytAnYyPdQ7I6JA6BkKGE41AjLp4/qVlSkvo/KG2Cnt+uD3Yz3dzx449OAogyGHo
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(38100700002)(186003)(2616005)(31696002)(26005)(6512007)(8936002)(6506007)(5660300002)(53546011)(36756003)(54906003)(6486002)(6916009)(2906002)(31686004)(316002)(4326008)(66556008)(508600001)(8676002)(66946007)(66476007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?C9gxYsYsMGQYP4nDF3KudzNemN482zO8GOHnPHX7cZHfjt6kRJ0eMedXhkCM?=
 =?us-ascii?Q?uBKjQiOe0KTINCHfdhVdRXPwQCBb3H9HsxnLn6ydMGbnus0EA2Lp4RFbe7U1?=
 =?us-ascii?Q?O+8eob074sIm21kD2knBM+FvOr/udCkzRhq7l+VGH721Y9EKKozbfPHZe8vz?=
 =?us-ascii?Q?JUs1UcEnjh1/qcugdydjHDXIQhTRyXSLMuJ58TfBHA5x2sVfzV+FwXcd6+YY?=
 =?us-ascii?Q?FFlPtslmWYfZ8zw6rTbyHhsQaO5nby4Vu1reJ3NnK2/5Vxq4nAg1DUMlRmOS?=
 =?us-ascii?Q?Xb7REiJjIoc7bkdduBE4IMESL85B1aNUY4C8pBV7xR3DznSUBFm2zlKe7ti8?=
 =?us-ascii?Q?+q3r/ebwuTiv/P673bxnLA/FmD5evyiVG6CX7T4/30QvNRLx2Zwh7ZKKlPdH?=
 =?us-ascii?Q?iLZzTUNMyO0bK+uwfuVNWwhuZoQT0JL0fXQXnipgq7QMa0Mqc07T5aV77c79?=
 =?us-ascii?Q?cZE6h1d/cSDZri8CLYW3H02CRVXtPNoEAWpIXnL/8uQit8cJHCpw3GDe9hOT?=
 =?us-ascii?Q?j68X0BhcfuzAD72P2+q4AphHaSF0BFEXP8NTl/WvmTINFyt5hCsBnliQRv4F?=
 =?us-ascii?Q?jkTRo2ikqwCC95AAiKOpYBqU0DrtNaw5jvF4FI4GY1csEZckmoHazG6kGlrS?=
 =?us-ascii?Q?A6naJapcT/wcDqCiUGwOe8RJXitvbc+2xkH9/O60GDbLLmUoA5HrBvW/zCHc?=
 =?us-ascii?Q?FbY441AIPcYowNL11xvUv55kcrUOedlRHS/4Jv2wTolgXzN8yDWumBQASsx8?=
 =?us-ascii?Q?7vknO4iHUGEakv84D9bKgeP6SVh3tUTTEoeiLi7QT00A1PLeQw3TTZsHFJzh?=
 =?us-ascii?Q?8JLyB6f+tCX1jL4EbZM+6ZYeg4+qGKiu/Y4VrTq6mwcXGX32iEU9nzLGwIzO?=
 =?us-ascii?Q?KyubNvcf+z4cFzX2C3VZVexnfgvSz6Nsp2g7alcQTstABO9vgdvj2ewema56?=
 =?us-ascii?Q?IHs8HSpUJ8KAriiLKka1jM6UjUVpfBiEvwLvuqSwwVr4kZO12Y2kaMEvwuEk?=
 =?us-ascii?Q?rOothG4PzY3f/Hew5/S446bPkqueDp5MGVmhqv2cJ3dtpJOgUUbiPjeZNx/e?=
 =?us-ascii?Q?+7MsrTNkLw7XZqgtFVGnkcXhgS1IVwUCMp4FYcMkY9usgWTMb9xTvZvIWi2c?=
 =?us-ascii?Q?K7JgGAoTAKhhQYwdH4xz8axfhF+ckQPNac+sZqXgE7/X1WY5imd4jCZ+kOO2?=
 =?us-ascii?Q?nM3MGhx8tkCFpO6PyEL3jPmyqLSISj9cMT6pLZbsiNj4+pKZZzoZcCINS2xJ?=
 =?us-ascii?Q?qgdliWkO6oBmeR2I/O9BtaGQBfOT+RqCFM+b1ht9PzCExIKZGyh1DQeeZKj4?=
 =?us-ascii?Q?emDZDU+4bckzhcaY9ITOFrhxItrTdwjg6ef7ycmnd1q7uqRcav9eoDb+TKNe?=
 =?us-ascii?Q?RAW56vWAO9CytwgG5Di7y3+NKCjOy+sYIsYBoHrSB5mGFZyKxqP7G8Vi7tKe?=
 =?us-ascii?Q?cG7SR/OWyy/0ERYqyw4WxuOezzu0B5wGQQY5RBygKDlI6sU6MrIw1Ga+jJMj?=
 =?us-ascii?Q?9QiLw/MT1XjHIBnBYA1sjL9ZFv4YvuyE48YImwHCDFDneCHvSYJxZstT0yEr?=
 =?us-ascii?Q?9hBuHRf1MUUky3RYX0WmTKHy28wV4DdUPRThkpoBbrBkMVeBmLjJlMKoL7lT?=
 =?us-ascii?Q?VGyeM5HlAsXFDagJVNCRSOZz1McGUbGY2bFhbV75j8aOMg/1gyp8lF5+MwDo?=
 =?us-ascii?Q?LJizxvpresTc8rMCjOYQuvSLtLMXFiNgZau1BmScwHZ7WdahfFbCcwh+Asgi?=
 =?us-ascii?Q?dMfC1G+yUg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a25f533c-cf64-4011-9cb1-08da28ea4bce
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 07:39:58.7198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tPXDojlcuSaoniUPcvoBDIRBfvfqSVCDxTZhoBE35V8MFV127AEyBgFDL9gxmvlLj3ekvffcrhSNwQkgYYmwmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8759

On 28.04.2022 09:37, Jan Beulich wrote:
> On 27.04.2022 20:44, David Vrabel wrote:
>>
>>
>> On 27/04/2022 19:03, Andrew Cooper wrote:
>>> On 19/04/2022 16:03, David Vrabel wrote:
>>>> From: David Vrabel <dvrabel@amazon.co.uk>
>>>>
>>>> If the direct map is incorrectly modified with interrupts disabled,
>>>> the required TLB flushes are degraded to flushing the local CPU only.
>>>>
>>>> This could lead to very hard to diagnose problems as different CPUs wi=
ll
>>>> end up with different views of memory. Although, no such issues have y=
et
>>>> been identified.
>>>>
>>>> Change the check in the flush_area() macro to look at system_state
>>>> instead. This defers the switch from local to all later in the boot
>>>> (see xen/arch/x86/setup.c:__start_xen()). This is fine because
>>>> additional PCPUs are not brought up until after the system state is
>>>> SYS_STATE_smp_boot.
>>>>
>>>> Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
>>>
>>> This explodes on CET systems:
>>>
>>> (XEN) Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265
>>> (XEN) ----[ Xen-4.17.0-10.24-d=C2=A0 x86_64=C2=A0 debug=3Dy=C2=A0 Not t=
ainted ]----
>>> (XEN) CPU:=C2=A0=C2=A0=C2=A0 0
>>> (XEN) RIP:=C2=A0=C2=A0=C2=A0 e008:[<ffff82d040345300>] flush_area_mask+=
0x40/0x13e
>>> <snip>
>>> (XEN) Xen call trace:
>>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d040345300>] R flush_area_mask+0x40/0x1=
3e
>>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d040338a40>] F modify_xen_mappings+0xc5=
/0x958
>>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d0404474f9>] F
>>> arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9
>>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d0404476cc>] F alternative_branches+0xf=
/0x12
>>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d04044e37d>] F __start_xen+0x1ef4/0x277=
6
>>> (XEN)=C2=A0=C2=A0=C2=A0 [<ffff82d040203344>] F __high_start+0x94/0xa0
>>> (XEN)
>>> (XEN)
>>> (XEN) ****************************************
>>> (XEN) Panic on CPU 0:
>>> (XEN) Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265
>>> (XEN) ****************************************
>>> (XEN)
>>>
>>> We really did want a local-only flush here, because we specifically
>>> intended to make self-modifying changes before bringing secondary CPUs =
up.
>>
>> I think the transition to SYS_STATE_smp_boot system state should be=20
>> later. i.e., the last point were only 1 PCPU is guaranteed.
>=20
> I'm not sure there isn't code which assumes pre-SMP initcalls to happen
> in this state already. So it may take addition of yet another state if
> no other solution can be found.

Or maybe this again shouldn't be using system_state but num_online_cpus()?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:42:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:42:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316067.534785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njynW-0001aQ-OA; Thu, 28 Apr 2022 07:42:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316067.534785; Thu, 28 Apr 2022 07:42:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njynW-0001aJ-Kg; Thu, 28 Apr 2022 07:42:46 +0000
Received: by outflank-mailman (input) for mailman id 316067;
 Thu, 28 Apr 2022 07:42:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njynV-0001a9-PQ; Thu, 28 Apr 2022 07:42:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njynV-0000DO-Mu; Thu, 28 Apr 2022 07:42:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njynV-0000Mh-Bd; Thu, 28 Apr 2022 07:42:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njynV-0001w7-BB; Thu, 28 Apr 2022 07:42:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=anQnxTIzebAxlL8VEQs3LrWccwh+YuA9TbBRKnc3LYw=; b=2GuMddamJEfptJNNDHeMUAKmAB
	hNRDX5UmyRYgWeL7cG5S9518dbfCH/tu23RJBacVOZtDFAkwu1HQ5FEQuVLWeh28TUZNPP1HmlkQ2
	9DNCKsja3U1af82Aav0hrIFIb/YJhoIzaKSG2pktz6I02559ONbJp62hMPFZ4upT0gBE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169804-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169804: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 07:42:45 +0000

flight 169804 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169804/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  672 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   44 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:45:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:45:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316075.534795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njypw-0002Fk-83; Thu, 28 Apr 2022 07:45:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316075.534795; Thu, 28 Apr 2022 07:45:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njypw-0002Fd-5F; Thu, 28 Apr 2022 07:45:16 +0000
Received: by outflank-mailman (input) for mailman id 316075;
 Thu, 28 Apr 2022 07:45:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njypu-0002FG-HW
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:45:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 233ff87b-c6c7-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:45:13 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-nbhzx9b4MgKgCwLNOE32uQ-1; Thu, 28 Apr 2022 09:45:12 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB8147.eurprd04.prod.outlook.com (2603:10a6:20b:3e0::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Thu, 28 Apr
 2022 07:45:10 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 07:45:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 233ff87b-c6c7-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651131913;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=twdjcPLUi3FM+jhN/JK7zJIH+eOYabDtlTxL63eHsRo=;
	b=VPY3iQD94RjCUz/nzxyroYY4x6K4OcyJjyZIcushMFw8jG2keKn6R0IVkSaMC9hS6Bz0cU
	9uTcCBTUf2WvzJNKl9a9Meo0HcPIOelG3fiZ2T23iYqVHQ/VhOZryGVnOJsH/+H84ic2Re
	eBoCF6QXiQhUKvFiMe6SlWE8afzSTZc=
X-MC-Unique: nbhzx9b4MgKgCwLNOE32uQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MlBGQds2GRdb6Eu55Ib1xoYKh+n2z7jxkdQhhHW90scY2lTlDUcM4dMTHFDzayyT1OyR+3krLsLGvjPG/K4oFuUmSArlPc87aRUfoZ9puCGlsqXdgGd6G4e+SxCqhOtvF9FTiEbuOpcZpSFNcZ/s692AnwItrQzb6Jko4yLtymiChetG5MrOaC8LgqzznwI5ATqy/Uo2esvcnmXsIf1ZICiblOiOAzcrFDIXXqtNk5Id+FV6reHERokkMHyc+8/Fi1eZmbey01+fSePAaRM0yKqAq1xFLeUEJAkd9KDvRGPTbnjWhLxEU+ZC61OVka9G/vERCzOxTjki5a8WlWwhYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=twdjcPLUi3FM+jhN/JK7zJIH+eOYabDtlTxL63eHsRo=;
 b=h//M82UTQjh5KqB9ELa2hhN/fy4mhhJQ5Qf3PBlEbVwcqgqyjEamh5/pSf51MQksQ0yYLwqpHHJnE9L8L92XbcbtOqFY0o3uHc4RLD/t1GnKWde+gpkF1/Ed1rdD3gY/Bg2r5+YOIezR9dnqTMyyC4kQKlmSRMVdh3d9l4NEh2m1QDy8tWM99ICvVMtgPz2Bze5t9/GnMXx2HUOx7f4tKWJK4uV91NvwjG364GJ0agEYg87UnPZxViGcXml5jCEPhGZe2Y1RdLoPuE+oOs3zCrHZAl/vZwnzm+IMMD0RZH0c8kbE7Z4N7zdCaiOt85SGeYlWE6Lhxxnjq0D3ASp0yg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <34c7f008-a530-db45-cfb9-63b26944f03b@suse.com>
Date: Thu, 28 Apr 2022 09:45:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
Content-Language: en-US
To: Julien Grall <julien@xen.org>,
 osstest service owner <osstest-admin@xenproject.org>
Cc: David Vrabel <dvrabel@amazon.co.uk>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <osstest-169781-mainreport@xen.org>
 <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0059.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::28) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5343caec-b335-4cf8-9c2a-08da28eb05d7
X-MS-TrafficTypeDiagnostic: AM9PR04MB8147:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB81474B4B81F6589AEA154ECCB3FD9@AM9PR04MB8147.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fdnfvukqSyViMK7tNRasyVp99rhkpRRPDLLZ0CLg6jcaBXTmGMdggygXYzaiZ17iwga6vbtXktxoEKW3AJDw1bqUOmDwXGBuNSPvb9Q/FQOj7XnW4eM8XJSO3i6uYDUcWYUL+TZ17yNoughXyc3Uxbqo8Ejz/vyPka3qGHzDVyIziMzbYZVbIBVWj7/Jii6RVoMYIXlv9DDcxE/Ut0V4im2GypS3TRP7BYcKTjDnLXZTbqCdSco3zNxUlqwPEXB40zxTiYrKjBvxbW3l19ClNRQUNI0HHQPLPsFU5MoVEYuNg8TRFfOsVETcFej2dN+NLfn0mJCbjn1swkA1lTvMpmpUGsar3alNDP5gUwp1XFTvfNQ6vfH1V17+wOdWaue0vQqeXfAcsVmt3SioLURfw3ZTYHaWnppxXKyeM7i8n25Ufa5+zol2WaxHp8xx9VycEIsRUkXJ9yVjP0mf0u4XzyU9KqJMPL4fWfRsYBRnfJDZMKCwT+jMuRetZaBsb06Q4yTR4CFLAz+M7gcHBTyamIU7ZnxwbGfJtIqKYynWzyREtNfWj2Ik/cCu97UDLhPlEct0WUgNJea2IwopZ0BdmPWtjZRxALJMo3+0/jV6lA6WCswK3V58hLx1nWb+4uFIu45vG36feu52nhUz8zYFM9qRutQAIgH4vQUTq7nbf5X3eQgnqQUa41rfIdt1nsYCDt1l9S7MtYvIpnEd5k+wi9GMCfyeLbD982GdzPac+N50XgAJWq0wJm1y9pHefrns98E5K2u7HEuwj90iuqGBNyQccxm1auMoqSVkS8uSWcbwfhafiFr1d8df8tpnxMFtAGqa6J9Q6WcyU3MzAfR5yg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(66476007)(31696002)(66946007)(66556008)(86362001)(5660300002)(83380400001)(2616005)(6506007)(38100700002)(53546011)(966005)(26005)(2906002)(8676002)(6512007)(54906003)(110136005)(4326008)(36756003)(31686004)(8936002)(6486002)(508600001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MjhSWDQyY0tlQ0JIcnUrc254S1IwcG9lMHFzY2JLSVdUUmJublFGQ1RhQTl2?=
 =?utf-8?B?akFMbmVDQm45U3plQktOeDVrQTlhVjBLZ0x5c1dSa3JXTjFQai9LLzV2Zzh3?=
 =?utf-8?B?L0JIT3IzejUrd2ptdVRGVXQ2NDFGdHZJcE9QbEhCQXFxb2RIaEZLYWU5VFZ3?=
 =?utf-8?B?YnpnT1ZpUUE1RVpKdVdqdTFNOVY3SE52eXQvUjFYNVROejJqUUlRNElQRWdn?=
 =?utf-8?B?N1R4Nzh1dS9DNVhveEtXL09kMUZpRitNdENkZXlORDNhWjJoanRMcG9RbnBu?=
 =?utf-8?B?MnlJanNjNlU5YmM0S3dOZ0dtNHk4OU03K3pMeWZUR1BkZUJCOGV2VDNxQnRz?=
 =?utf-8?B?bDJBTEQ2N28xc2pHM280c0RoNVZKcGh4K1JCV3d5T2Q1TVBPVkphM3lNNWFw?=
 =?utf-8?B?UjEwclJwQk5VYkVBZ0pDd0trK2oyZHhkOW9FWVU2V3ZCdTlQZStISTlkZ0xL?=
 =?utf-8?B?Z1duVUpYTHJaTjM5Uk1NTnVmdlovOHFIdVVxQnphZ1hadjlxTWNWZjB0WDZZ?=
 =?utf-8?B?T1NZazVmM0ZEdnl1TE80bVJDcVIrMXNMTmMxSWcyMVdacUsrR24yY2VvVTNq?=
 =?utf-8?B?Qzg0bVVEcDFYSjEzVVk4STV0TUpHSW9jajBoWC91Qi9WSSt6U2w1VVJEZ0tp?=
 =?utf-8?B?dVdnZUpNNFp6dWt2aVY1dVBSSHFtN1ZEMUljUEpVcG40ZEkwQkRTbllXeGtX?=
 =?utf-8?B?UGVHTG8xVllkclIrU0pxSmlpWmRmVDhtd0svZzZOSU5IOXdqVnBFZjBwQTgw?=
 =?utf-8?B?QUtOVHR2b0ZoUk16OUVFOFlDSDFoUzFKQnlxQmcxS1FodE9yMndjVzN0L3FS?=
 =?utf-8?B?c2JoQWZMeGU2TlR1aGhuTUlJSHNEdkR0ZWJFTmtLSEJxanlVeFFYVWplVmYv?=
 =?utf-8?B?d1VyeGJvTEhhS1llZVo4YnhIbURxQVBTSUlCWGc3bzZKK2tIR0dFY3c3dU1y?=
 =?utf-8?B?MithRks3V1RUNlR5QUZpRVVwOHRKOHh6VmFpSVYyY3p2WGtDWVpkck1QRld0?=
 =?utf-8?B?WnpPdjJabjVHSTZtVzN4TnA0akZKQThuTE41QnNRaW9lZ0p1WXZ2L3QzMmxa?=
 =?utf-8?B?bzZONVpNcm95SlF6ODFTeTdSNWp4bWZBQ1FTUHplS3ZlTjUrYUlRaDk1YkQ3?=
 =?utf-8?B?dEg1VnBHek5ML2wrS1dvYzFGWW9kQm0vb3JndzVtNktVL2Zoc1EzNGRjQXEr?=
 =?utf-8?B?ZExFSGdTbkxEcHNtYzJLd3E1QzVDUlNpUG1QTXU4MjJHRndLaEJSUFZmRExD?=
 =?utf-8?B?bWp0bHRvUWd6bm9SNkdEcHlTWG5sOVd1TVZqYzg2WkhkUk5Pald4dGtXYmRj?=
 =?utf-8?B?MURraFlSTzVLWFArQTRXOW94eXk2RG1DcDBFa3FOMGFQUFlwZm00SlhUenJa?=
 =?utf-8?B?WGxUdzJvbnd3YklISVFMdTBDbjUxUFN3RDdKV2xWUmtYcDhkTU92ZnYxbVRx?=
 =?utf-8?B?amlhWlE1RDFHUUI5dC8yZTh0Syt6VHFUOGJWYml2bXg0cHRBam9ZT1JFblpG?=
 =?utf-8?B?YWRHS0ovRkNNR0tkc3JjRXZPUmxnSFc1UGRZc2tOODB4aWpsMXBYaWdLZ3ZE?=
 =?utf-8?B?aTlSekJHaG10aHBUTkZhemE2cWhuR3FGakdOV2JLNFZyTlRvRFNmWWg3djBj?=
 =?utf-8?B?My9zTDZheHhQUVBIdjl3U2VuTGh5YmNQeDB3NWF4S0h1QVJRR0k1TE9ZdkZt?=
 =?utf-8?B?UUtFOE5uZ3V1SHhvcWNvWVpIVHNkemJMa1A2QjE0am96YzFLL1lmRVZGZXpr?=
 =?utf-8?B?Y05yTmR1Y1kyN0EwcGJVZ0hCL3M5OVJERkZZejQycUxtL3hPVkkwRTRrSWFH?=
 =?utf-8?B?c0dwVUhRNlVTQjg4S0xaMmZ5VzVMSXNCekhGSjBFM1dkbUJodzNCaHgveXNN?=
 =?utf-8?B?ajZjelNFelZDOGMrUWNDYXM2MFJ0bmdCcnczeXRYVEZ5cUdGWnlzc1pDUkhB?=
 =?utf-8?B?b1gzQUpQYmxkTVdHbnlkNFFGODlQMHl2UUhlMzE4dzZhMWlNR2M2RC9DcDZC?=
 =?utf-8?B?R3RFT0ROeFRiLzUrWldqbXBtdkJST21KdEJLdTlacVo1ZDZ3YkFQN0pFQldu?=
 =?utf-8?B?SzVzdEtucERhZ3VndTgvNHVqWll5c0hBZHdrSkpQdW5kT2tnQUt1WklNV0t2?=
 =?utf-8?B?UnBDc0VUMytKbjFJZHBFVlZCTjJpdFJRckZMb1NaVmZVR3o4OE1mRmJKWTFF?=
 =?utf-8?B?aDVReS80ZGN4VERydUNINmt0MUt6SElrL0tQTWlYQWZiSmo5anhLL2tIVGd4?=
 =?utf-8?B?ZVU4bVM3YlNNc2J0KzcxMjNEMkdoeUJQSEI1bkE1Qk5QUFQ4T0x5VkYxZUNt?=
 =?utf-8?B?ejdKUndUNW51Ync4WlZXTWF0OVE4R2pMVjdmdzlHajUrVktnNS81Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5343caec-b335-4cf8-9c2a-08da28eb05d7
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 07:45:10.8038
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5OvE5P32bv2hDWgJKBjGN2njFam2ailNucai/KTIwz9CLnpbaQGQ8SsneFxU8qrOgLdqSVrj1g5U+0fLw/Uw1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8147

On 27.04.2022 19:10, Julien Grall wrote:
> Hi,
> 
> On 27/04/2022 17:38, osstest service owner wrote:
>> flight 169781 xen-unstable-smoke real [real]
>> flight 169785 xen-unstable-smoke real-retest [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/169781/
>> http://logs.test-lab.xenproject.org/osstest/logs/169785/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>>   test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 169773
> 
> Well, I was overly optimistic :(. This now breaks in the ITS code:
> 
> Apr 27 13:23:14.324831 (XEN) Xen call trace:
> Apr 27 13:23:14.324855 (XEN)    [<000000000022a678>] 
> alloc_xenheap_pages+0x178/0x194 (PC)
> Apr 27 13:23:14.336856 (XEN)    [<000000000022a670>] 
> alloc_xenheap_pages+0x170/0x194 (LR)
> Apr 27 13:23:14.336886 (XEN)    [<0000000000237770>] _xmalloc+0x144/0x294
> Apr 27 13:23:14.348773 (XEN)    [<00000000002378d4>] _xzalloc+0x14/0x30
> Apr 27 13:23:14.348808 (XEN)    [<000000000027b4e4>] 
> gicv3_lpi_init_rdist+0x54/0x324
> Apr 27 13:23:14.348835 (XEN)    [<0000000000279898>] 
> arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46c
> Apr 27 13:23:14.360799 (XEN)    [<0000000000279bfc>] 
> arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0x20/0x50
> Apr 27 13:23:14.372796 (XEN)    [<0000000000277054>] 
> gic_init_secondary_cpu+0x18/0x30
> Apr 27 13:23:14.372829 (XEN)    [<0000000000284518>] 
> start_secondary+0x1a8/0x234
> Apr 27 13:23:14.372856 (XEN)    [<0000010722aa4200>] 0000010722aa4200
> Apr 27 13:23:14.384793 (XEN)
> Apr 27 13:23:14.384823 (XEN)
> Apr 27 13:23:14.384845 (XEN) ****************************************
> Apr 27 13:23:14.384869 (XEN) Panic on CPU 2:
> Apr 27 13:23:14.384891 (XEN) Assertion '!in_irq() && 
> (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at 
> common/page_alloc.c:2212
> Apr 27 13:23:14.396805 (XEN) ****************************************
> 
> The GICv3 LPI code contains a few calls to xmalloc() that will be done 
> while initializing the GIC CPU interface. I don't think we can delay the 
> initialization of the LPI part past local_irq_enable(). So I think we 
> will need to allocate the memory when preparing the CPU.

Do you have an explanation why the next flight (169800) passed?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:53:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:53:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316085.534831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxw-0004E0-6k; Thu, 28 Apr 2022 07:53:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316085.534831; Thu, 28 Apr 2022 07:53:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxv-0004BL-Vj; Thu, 28 Apr 2022 07:53:31 +0000
Received: by outflank-mailman (input) for mailman id 316085;
 Thu, 28 Apr 2022 07:53:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njyxu-0003jr-I3
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:53:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4a2338bb-c6c8-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:53:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EF0AC1F88B;
 Thu, 28 Apr 2022 07:53:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B26F113AF8;
 Thu, 28 Apr 2022 07:53:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yDYnKvdHamIoHAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 07:53:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a2338bb-c6c8-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651132407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MG3xPy2sxwW3smkj4Gb01xXTe3bOEE9V2zLYcAQe4m4=;
	b=W2PKreHag+faFXtZey1DQtRyCfjXUvaiwNS4vQn8a9/RMSSRl4hUzerhLBlCJHRDA/Veop
	c47OwwShTQAf6Xz2U43FD86iGylFxlV1n1Nv4KUZtuKQzB1Nb66rGK+fbbjQHML7oBzImb
	oOOMnK/kvlNQZgqkYK3Uaheqd2NufII=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v2 3/4] xen/scsifront: use new command result macros
Date: Thu, 28 Apr 2022 09:53:22 +0200
Message-Id: <20220428075323.12853-4-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428075323.12853-1-jgross@suse.com>
References: <20220428075323.12853-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a translation layer for the command result values.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/scsi/xen-scsifront.c | 64 +++++++++++++++++++++++++++++++-----
 1 file changed, 56 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 12109e4c73d4..8511bfc62963 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -243,6 +243,56 @@ static void scsifront_gnttab_done(struct vscsifrnt_info *info,
 	kfree(shadow->sg);
 }
 
+static unsigned int scsifront_host_byte(int32_t rslt)
+{
+	switch (XEN_VSCSIIF_RSLT_HOST(rslt)) {
+	case XEN_VSCSIIF_RSLT_HOST_OK:
+		return DID_OK;
+	case XEN_VSCSIIF_RSLT_HOST_NO_CONNECT:
+		return DID_NO_CONNECT;
+	case XEN_VSCSIIF_RSLT_HOST_BUS_BUSY:
+		return DID_BUS_BUSY;
+	case XEN_VSCSIIF_RSLT_HOST_TIME_OUT:
+		return DID_TIME_OUT;
+	case XEN_VSCSIIF_RSLT_HOST_BAD_TARGET:
+		return DID_BAD_TARGET;
+	case XEN_VSCSIIF_RSLT_HOST_ABORT:
+		return DID_ABORT;
+	case XEN_VSCSIIF_RSLT_HOST_PARITY:
+		return DID_PARITY;
+	case XEN_VSCSIIF_RSLT_HOST_ERROR:
+		return DID_ERROR;
+	case XEN_VSCSIIF_RSLT_HOST_RESET:
+		return DID_RESET;
+	case XEN_VSCSIIF_RSLT_HOST_BAD_INTR:
+		return DID_BAD_INTR;
+	case XEN_VSCSIIF_RSLT_HOST_PASSTHROUGH:
+		return DID_PASSTHROUGH;
+	case XEN_VSCSIIF_RSLT_HOST_SOFT_ERROR:
+		return DID_SOFT_ERROR;
+	case XEN_VSCSIIF_RSLT_HOST_IMM_RETRY:
+		return DID_IMM_RETRY;
+	case XEN_VSCSIIF_RSLT_HOST_REQUEUE:
+		return DID_REQUEUE;
+	case XEN_VSCSIIF_RSLT_HOST_TRANSPORT_DISRUPTED:
+		return DID_TRANSPORT_DISRUPTED;
+	case XEN_VSCSIIF_RSLT_HOST_TRANSPORT_FAILFAST:
+		return DID_TRANSPORT_FAILFAST;
+	case XEN_VSCSIIF_RSLT_HOST_TARGET_FAILURE:
+		return DID_TARGET_FAILURE;
+	case XEN_VSCSIIF_RSLT_HOST_NEXUS_FAILURE:
+		return DID_NEXUS_FAILURE;
+	case XEN_VSCSIIF_RSLT_HOST_ALLOC_FAILURE:
+		return DID_ALLOC_FAILURE;
+	case XEN_VSCSIIF_RSLT_HOST_MEDIUM_ERROR:
+		return DID_MEDIUM_ERROR;
+	case XEN_VSCSIIF_RSLT_HOST_TRANSPORT_MARGINAL:
+		return DID_TRANSPORT_MARGINAL;
+	default:
+		return DID_ERROR;
+	}
+}
+
 static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
 				   struct vscsiif_response *ring_rsp)
 {
@@ -250,7 +300,6 @@ static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
 	struct scsi_cmnd *sc;
 	uint32_t id;
 	uint8_t sense_len;
-	int result;
 
 	id = ring_rsp->rqid;
 	shadow = info->shadow[id];
@@ -261,12 +310,8 @@ static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
 	scsifront_gnttab_done(info, shadow);
 	scsifront_put_rqid(info, id);
 
-	result = ring_rsp->rslt;
-	if (result >> 24)
-		set_host_byte(sc, DID_ERROR);
-	else
-		set_host_byte(sc, host_byte(result));
-	set_status_byte(sc, result & 0xff);
+	set_host_byte(sc, scsifront_host_byte(ring_rsp->rslt));
+	set_status_byte(sc, XEN_VSCSIIF_RSLT_STATUS(ring_rsp->rslt));
 	scsi_set_resid(sc, ring_rsp->residual_len);
 
 	sense_len = min_t(uint8_t, VSCSIIF_SENSE_BUFFERSIZE,
@@ -290,7 +335,10 @@ static void scsifront_sync_cmd_done(struct vscsifrnt_info *info,
 	shadow->wait_reset = 1;
 	switch (shadow->rslt_reset) {
 	case RSLT_RESET_WAITING:
-		shadow->rslt_reset = ring_rsp->rslt;
+		if (ring_rsp->rslt == XEN_VSCSIIF_RSLT_RESET_SUCCESS)
+			shadow->rslt_reset = SUCCESS;
+		else
+			shadow->rslt_reset = FAILED;
 		break;
 	case RSLT_RESET_ERR:
 		kick = _scsifront_put_rqid(info, id);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:53:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:53:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316083.534818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxv-0003zp-9h; Thu, 28 Apr 2022 07:53:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316083.534818; Thu, 28 Apr 2022 07:53:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxv-0003zi-6P; Thu, 28 Apr 2022 07:53:31 +0000
Received: by outflank-mailman (input) for mailman id 316083;
 Thu, 28 Apr 2022 07:53:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njyxt-0003js-47
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:53:29 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 49eb4655-c6c8-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 09:53:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id AACEE21870;
 Thu, 28 Apr 2022 07:53:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7707F13AF8;
 Thu, 28 Apr 2022 07:53:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id QDOoG/dHamIoHAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 07:53:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49eb4655-c6c8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651132407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=e7smBjs6Cs54j9gtj63aB2bUTDoqIo4j1UzSK6xvBWg=;
	b=rpwyrV9E6S/d9bU0Olq3d0lZ/V4hx2lhfq8AigAGZwgiad+EOGLOiKyt3wOw0lACnEj/Gr
	7XLQTGdTp6LuN7zjo3FEYVQEXr1TbhFcR68hqxGB320Bs6nK+htjcjCLxPBzEmSU/kYSB3
	PFGspBJj5GfMqbXPksQC1qLa2e2SWs0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 2/4] xen/scsiback: use new command result macros
Date: Thu, 28 Apr 2022 09:53:21 +0200
Message-Id: <20220428075323.12853-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428075323.12853-1-jgross@suse.com>
References: <20220428075323.12853-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using the kernel's values for the result of PV scsi
operations use the values of the interface definition.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- fix scsiback_result() to pass through lowest 16 bits of result
- use XEN_VSCSIIF_RSLT_HOST() instead of open coding it (Boris Ostrovsky)
---
 drivers/xen/xen-scsiback.c | 82 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 79 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index 0c5e565aa8cf..7a0c93acc2c5 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -280,6 +280,82 @@ static void scsiback_free_translation_entry(struct kref *kref)
 	kfree(entry);
 }
 
+static int32_t scsiback_result(int32_t result)
+{
+	int32_t host_status;
+
+	switch (XEN_VSCSIIF_RSLT_HOST(result)) {
+	case DID_OK:
+		host_status = XEN_VSCSIIF_RSLT_HOST_OK;
+		break;
+	case DID_NO_CONNECT:
+		host_status = XEN_VSCSIIF_RSLT_HOST_NO_CONNECT;
+		break;
+	case DID_BUS_BUSY:
+		host_status = XEN_VSCSIIF_RSLT_HOST_BUS_BUSY;
+		break;
+	case DID_TIME_OUT:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TIME_OUT;
+		break;
+	case DID_BAD_TARGET:
+		host_status = XEN_VSCSIIF_RSLT_HOST_BAD_TARGET;
+		break;
+	case DID_ABORT:
+		host_status = XEN_VSCSIIF_RSLT_HOST_ABORT;
+		break;
+	case DID_PARITY:
+		host_status = XEN_VSCSIIF_RSLT_HOST_PARITY;
+		break;
+	case DID_ERROR:
+		host_status = XEN_VSCSIIF_RSLT_HOST_ERROR;
+		break;
+	case DID_RESET:
+		host_status = XEN_VSCSIIF_RSLT_HOST_RESET;
+		break;
+	case DID_BAD_INTR:
+		host_status = XEN_VSCSIIF_RSLT_HOST_BAD_INTR;
+		break;
+	case DID_PASSTHROUGH:
+		host_status = XEN_VSCSIIF_RSLT_HOST_PASSTHROUGH;
+		break;
+	case DID_SOFT_ERROR:
+		host_status = XEN_VSCSIIF_RSLT_HOST_SOFT_ERROR;
+		break;
+	case DID_IMM_RETRY:
+		host_status = XEN_VSCSIIF_RSLT_HOST_IMM_RETRY;
+		break;
+	case DID_REQUEUE:
+		host_status = XEN_VSCSIIF_RSLT_HOST_REQUEUE;
+		break;
+	case DID_TRANSPORT_DISRUPTED:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TRANSPORT_DISRUPTED;
+		break;
+	case DID_TRANSPORT_FAILFAST:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TRANSPORT_FAILFAST;
+		break;
+	case DID_TARGET_FAILURE:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TARGET_FAILURE;
+		break;
+	case DID_NEXUS_FAILURE:
+		host_status = XEN_VSCSIIF_RSLT_HOST_NEXUS_FAILURE;
+		break;
+	case DID_ALLOC_FAILURE:
+		host_status = XEN_VSCSIIF_RSLT_HOST_ALLOC_FAILURE;
+		break;
+	case DID_MEDIUM_ERROR:
+		host_status = XEN_VSCSIIF_RSLT_HOST_MEDIUM_ERROR;
+		break;
+	case DID_TRANSPORT_MARGINAL:
+		host_status = XEN_VSCSIIF_RSLT_HOST_TRANSPORT_MARGINAL;
+		break;
+	default:
+		host_status = XEN_VSCSIIF_RSLT_HOST_ERROR;
+		break;
+	}
+
+	return (host_status << 16) | (result & 0x00ffff);
+}
+
 static void scsiback_send_response(struct vscsibk_info *info,
 			char *sense_buffer, int32_t result, uint32_t resid,
 			uint16_t rqid)
@@ -295,7 +371,7 @@ static void scsiback_send_response(struct vscsibk_info *info,
 	ring_res = RING_GET_RESPONSE(&info->ring, info->ring.rsp_prod_pvt);
 	info->ring.rsp_prod_pvt++;
 
-	ring_res->rslt   = result;
+	ring_res->rslt   = scsiback_result(result);
 	ring_res->rqid   = rqid;
 
 	if (sense_buffer != NULL &&
@@ -555,7 +631,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
 	struct scsiback_nexus *nexus = tpg->tpg_nexus;
 	struct se_cmd *se_cmd = &pending_req->se_cmd;
 	u64 unpacked_lun = pending_req->v2p->lun;
-	int rc, err = FAILED;
+	int rc, err = XEN_VSCSIIF_RSLT_RESET_FAILED;
 
 	init_completion(&pending_req->tmr_done);
 
@@ -569,7 +645,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
 	wait_for_completion(&pending_req->tmr_done);
 
 	err = (se_cmd->se_tmr_req->response == TMR_FUNCTION_COMPLETE) ?
-		SUCCESS : FAILED;
+		XEN_VSCSIIF_RSLT_RESET_SUCCESS : XEN_VSCSIIF_RSLT_RESET_FAILED;
 
 	scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
 	transport_generic_free_cmd(&pending_req->se_cmd, 0);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:53:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:53:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316084.534825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxv-00043Q-O1; Thu, 28 Apr 2022 07:53:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316084.534825; Thu, 28 Apr 2022 07:53:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxv-00042b-FO; Thu, 28 Apr 2022 07:53:31 +0000
Received: by outflank-mailman (input) for mailman id 316084;
 Thu, 28 Apr 2022 07:53:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njyxt-0003jr-I3
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:53:29 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49c964a4-c6c8-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:53:27 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6F77A1F88A;
 Thu, 28 Apr 2022 07:53:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3CDA913AF8;
 Thu, 28 Apr 2022 07:53:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id aAN4DfdHamIoHAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 07:53:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49c964a4-c6c8-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651132407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FZ3HQWGQIijrKpRTy/DK1bE6hLtaRKbTQP99RtUeXZU=;
	b=ECk+vYsxELyggamzu+fuy1Zg+vf3nxF8Xo8jfyaBEZ5MSiWoM3kjkusDS3n/hYiRHbrfRf
	Nf3kM6vz9MrZAUvcswEVd/h4c+g3zQxeLSzcaiBTOfK5cX0KozAVYCpMadi+hLPF/edAtj
	bo9+5HS5avOOL7Uemt9gJLBheTHiTYk=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 1/4] xen: update vscsiif.h
Date: Thu, 28 Apr 2022 09:53:20 +0200
Message-Id: <20220428075323.12853-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428075323.12853-1-jgross@suse.com>
References: <20220428075323.12853-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Update include/xen/interface/io/vscsiif.h to its newest version.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 include/xen/interface/io/vscsiif.h | 133 ++++++++++++++++++++++++++++-
 1 file changed, 129 insertions(+), 4 deletions(-)

diff --git a/include/xen/interface/io/vscsiif.h b/include/xen/interface/io/vscsiif.h
index 1f6047d3de44..7ea4dc9611c4 100644
--- a/include/xen/interface/io/vscsiif.h
+++ b/include/xen/interface/io/vscsiif.h
@@ -43,7 +43,7 @@
  *
  *      A string specifying the backend device: either a 4-tuple "h:c:t:l"
  *      (host, controller, target, lun, all integers), or a WWN (e.g.
- *      "naa.60014054ac780582").
+ *      "naa.60014054ac780582:0").
  *
  * v-dev
  *      Values:         string
@@ -87,6 +87,75 @@
  *      response structures.
  */
 
+/*
+ * Xenstore format in practice
+ * ===========================
+ *
+ * The backend driver uses a single_host:many_devices notation to manage domU
+ * devices. Everything is stored in /local/domain/<backend_domid>/backend/vscsi/.
+ * The xenstore layout looks like this (dom0 is assumed to be the backend_domid):
+ *
+ *     <domid>/<vhost>/feature-host = "0"
+ *     <domid>/<vhost>/frontend = "/local/domain/<domid>/device/vscsi/0"
+ *     <domid>/<vhost>/frontend-id = "<domid>"
+ *     <domid>/<vhost>/online = "1"
+ *     <domid>/<vhost>/state = "4"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/p-dev = "8:0:2:1" or "naa.wwn:lun"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/state = "4"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/v-dev = "0:0:0:0"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/p-dev = "8:0:2:2"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/state = "4"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/v-dev = "0:0:1:0"
+ *
+ * The frontend driver maintains its state in
+ * /local/domain/<domid>/device/vscsi/.
+ *
+ *     <vhost>/backend = "/local/domain/0/backend/vscsi/<domid>/<vhost>"
+ *     <vhost>/backend-id = "0"
+ *     <vhost>/event-channel = "20"
+ *     <vhost>/ring-ref = "43"
+ *     <vhost>/state = "4"
+ *     <vhost>/vscsi-devs/dev-0/state = "4"
+ *     <vhost>/vscsi-devs/dev-1/state = "4"
+ *
+ * In addition to the entries for backend and frontend these flags are stored
+ * for the toolstack:
+ *
+ *     <domid>/<vhost>/vscsi-devs/dev-1/p-devname = "/dev/$device"
+ *     <domid>/<vhost>/libxl_ctrl_index = "0"
+ *
+ *
+ * Backend/frontend protocol
+ * =========================
+ *
+ * To create a vhost along with a device:
+ *     <domid>/<vhost>/feature-host = "0"
+ *     <domid>/<vhost>/frontend = "/local/domain/<domid>/device/vscsi/0"
+ *     <domid>/<vhost>/frontend-id = "<domid>"
+ *     <domid>/<vhost>/online = "1"
+ *     <domid>/<vhost>/state = "1"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/p-dev = "8:0:2:1"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/state = "1"
+ *     <domid>/<vhost>/vscsi-devs/dev-0/v-dev = "0:0:0:0"
+ * Wait for <domid>/<vhost>/state + <domid>/<vhost>/vscsi-devs/dev-0/state become 4
+ *
+ * To add another device to a vhost:
+ *     <domid>/<vhost>/state = "7"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/p-dev = "8:0:2:2"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/state = "1"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/v-dev = "0:0:1:0"
+ * Wait for <domid>/<vhost>/state + <domid>/<vhost>/vscsi-devs/dev-1/state become 4
+ *
+ * To remove a device from a vhost:
+ *     <domid>/<vhost>/state = "7"
+ *     <domid>/<vhost>/vscsi-devs/dev-1/state = "5"
+ * Wait for <domid>/<vhost>/state to become 4
+ * Wait for <domid>/<vhost>/vscsi-devs/dev-1/state become 6
+ * Remove <domid>/<vhost>/vscsi-devs/dev-1/{state,p-dev,v-dev,p-devname}
+ * Remove <domid>/<vhost>/vscsi-devs/dev-1/
+ *
+ */
+
 /* Requests from the frontend to the backend */
 
 /*
@@ -117,7 +186,8 @@
  * (plus the set VSCSIIF_SG_GRANT bit), the number of scsiif_request_segment
  * elements referencing the target data buffers is calculated from the lengths
  * of the seg[] elements (the sum of all valid seg[].length divided by the
- * size of one scsiif_request_segment structure).
+ * size of one scsiif_request_segment structure). The frontend may use a mix of
+ * direct and indirect requests.
  */
 #define VSCSIIF_ACT_SCSI_CDB		1
 
@@ -154,12 +224,14 @@
 
 /*
  * based on Linux kernel 2.6.18, still valid
+ *
  * Changing these values requires support of multiple protocols via the rings
  * as "old clients" will blindly use these values and the resulting structure
  * sizes.
  */
 #define VSCSIIF_MAX_COMMAND_SIZE	16
 #define VSCSIIF_SENSE_BUFFERSIZE	96
+#define VSCSIIF_PAGE_SIZE		4096
 
 struct scsiif_request_segment {
 	grant_ref_t gref;
@@ -167,7 +239,8 @@ struct scsiif_request_segment {
 	uint16_t length;
 };
 
-#define VSCSIIF_SG_PER_PAGE (PAGE_SIZE / sizeof(struct scsiif_request_segment))
+#define VSCSIIF_SG_PER_PAGE	(VSCSIIF_PAGE_SIZE / \
+				 sizeof(struct scsiif_request_segment))
 
 /* Size of one request is 252 bytes */
 struct vscsiif_request {
@@ -207,6 +280,58 @@ struct vscsiif_response {
 	uint32_t reserved[36];
 };
 
+/* SCSI I/O status from vscsiif_response->rslt */
+#define XEN_VSCSIIF_RSLT_STATUS(x)  ((x) & 0x00ff)
+
+/* Host I/O status from vscsiif_response->rslt */
+#define XEN_VSCSIIF_RSLT_HOST(x)    (((x) & 0x00ff0000) >> 16)
+#define XEN_VSCSIIF_RSLT_HOST_OK                   0
+/* Couldn't connect before timeout */
+#define XEN_VSCSIIF_RSLT_HOST_NO_CONNECT           1
+/* Bus busy through timeout */
+#define XEN_VSCSIIF_RSLT_HOST_BUS_BUSY             2
+/* Timed out for other reason */
+#define XEN_VSCSIIF_RSLT_HOST_TIME_OUT             3
+/* Bad target */
+#define XEN_VSCSIIF_RSLT_HOST_BAD_TARGET           4
+/* Abort for some other reason */
+#define XEN_VSCSIIF_RSLT_HOST_ABORT                5
+/* Parity error */
+#define XEN_VSCSIIF_RSLT_HOST_PARITY               6
+/* Internal error */
+#define XEN_VSCSIIF_RSLT_HOST_ERROR                7
+/* Reset by somebody */
+#define XEN_VSCSIIF_RSLT_HOST_RESET                8
+/* Unexpected interrupt */
+#define XEN_VSCSIIF_RSLT_HOST_BAD_INTR             9
+/* Force command past mid-layer */
+#define XEN_VSCSIIF_RSLT_HOST_PASSTHROUGH         10
+/* Retry requested */
+#define XEN_VSCSIIF_RSLT_HOST_SOFT_ERROR          11
+/* Hidden retry requested */
+#define XEN_VSCSIIF_RSLT_HOST_IMM_RETRY           12
+/* Requeue command requested */
+#define XEN_VSCSIIF_RSLT_HOST_REQUEUE             13
+/* Transport error disrupted I/O */
+#define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_DISRUPTED 14
+/* Transport class fastfailed */
+#define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_FAILFAST  15
+/* Permanent target failure */
+#define XEN_VSCSIIF_RSLT_HOST_TARGET_FAILURE      16
+/* Permanent nexus failure on path */
+#define XEN_VSCSIIF_RSLT_HOST_NEXUS_FAILURE       17
+/* Space allocation on device failed */
+#define XEN_VSCSIIF_RSLT_HOST_ALLOC_FAILURE       18
+/* Medium error */
+#define XEN_VSCSIIF_RSLT_HOST_MEDIUM_ERROR        19
+/* Transport marginal errors */
+#define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_MARGINAL  20
+
+/* Result values of reset operations */
+#define XEN_VSCSIIF_RSLT_RESET_SUCCESS  0x2002
+#define XEN_VSCSIIF_RSLT_RESET_FAILED   0x2003
+
 DEFINE_RING_TYPES(vscsiif, struct vscsiif_request, struct vscsiif_response);
 
-#endif /*__XEN__PUBLIC_IO_SCSI_H__*/
+
+#endif  /*__XEN__PUBLIC_IO_SCSI_H__*/
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:53:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:53:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316082.534807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxu-0003kF-2z; Thu, 28 Apr 2022 07:53:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316082.534807; Thu, 28 Apr 2022 07:53:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxt-0003k8-Ut; Thu, 28 Apr 2022 07:53:29 +0000
Received: by outflank-mailman (input) for mailman id 316082;
 Thu, 28 Apr 2022 07:53:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njyxs-0003jr-OX
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:53:28 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49bd0ef9-c6c8-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:53:27 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 354692186F;
 Thu, 28 Apr 2022 07:53:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E100C13AF8;
 Thu, 28 Apr 2022 07:53:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qNCTNfZHamIoHAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 07:53:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49bd0ef9-c6c8-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651132407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=3E7uGHyVSRLlv1q/BP8AWtqLSArF2xlrVNvb53ZZO3Q=;
	b=r3XSYHwZGjPKGDDJnE8y1TzQDS660lC8ubSYtSgv3fDXdqTjp7PRW3yk4VmEGD0yYctRb6
	N2Cad7N/zT3wVToO0LIRMHi7Q5SA4KFmR6GDtMgWqzUho8hMvGo68rdSEeCKN5QsOTJ96V
	OTggVTVRIKMzc52CNcHY5fN1SxcXrG0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v2 0/4] xen/pv-scsi: update header and harden frontend
Date: Thu, 28 Apr 2022 09:53:19 +0200
Message-Id: <20220428075323.12853-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Update the Xen PV-scsi interface from the Xen tree and adapt the
related drivers to use the new definitions.

Harden the frontend driver to be no longer vulnerable to a malicious
backend.

Juergen Gross (4):
  xen: update vscsiif.h
  xen/scsiback: use new command result macros
  xen/scsifront: use new command result macros
  xen/scsifront: harden driver against malicious backend

 drivers/scsi/xen-scsifront.c       | 168 ++++++++++++++++++++++-------
 drivers/xen/xen-scsiback.c         |  82 +++++++++++++-
 include/xen/interface/io/vscsiif.h | 133 ++++++++++++++++++++++-
 3 files changed, 340 insertions(+), 43 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:53:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:53:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316086.534849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxx-0004jC-F7; Thu, 28 Apr 2022 07:53:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316086.534849; Thu, 28 Apr 2022 07:53:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njyxx-0004hU-Bi; Thu, 28 Apr 2022 07:53:33 +0000
Received: by outflank-mailman (input) for mailman id 316086;
 Thu, 28 Apr 2022 07:53:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njyxv-0003jr-I6
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:53:31 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4a4c4aef-c6c8-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:53:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 410E81F88C;
 Thu, 28 Apr 2022 07:53:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0412813AF8;
 Thu, 28 Apr 2022 07:53:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uGFaO/dHamIoHAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 07:53:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a4c4aef-c6c8-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651132408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wQy1x+fRNHgv0+hbA7kZO4avv6jlEcwjeAC24DRrSzI=;
	b=aT2gbQ4cLusb6bFR/NVvfh2fUPPiBfScImg4BQauGsfXBe4tL9IvgxoXAd1IB/RhKzgOdZ
	sJJ8KvFn5k04VCyST136HD4Mo7vqC1tdff9LRZ+bWfwxN0JB29OJLWU0Fim4lB8nn62eQK
	x71dMrdYjnsr0/Cra1B4XnCmpFJ8P8E=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v2 4/4] xen/scsifront: harden driver against malicious backend
Date: Thu, 28 Apr 2022 09:53:23 +0200
Message-Id: <20220428075323.12853-5-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428075323.12853-1-jgross@suse.com>
References: <20220428075323.12853-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of relying on a well behaved PV scsi backend verify all meta
data received from the backend and avoid multiple reads of the same
data from the shared ring page.

In case any illegal data from the backend is detected switch the
PV device to a new "error" state and deactivate it for further use.

Use the "lateeoi" variant for the event channel in order to avoid
event storms blocking the guest.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- only remove spurious flag from eoiflag (Boris Ostrovsky)
---
 drivers/scsi/xen-scsifront.c | 104 +++++++++++++++++++++++++----------
 1 file changed, 76 insertions(+), 28 deletions(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 8511bfc62963..56173beecbc6 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -83,6 +83,8 @@ struct vscsifrnt_shadow {
 	uint16_t rqid;
 	uint16_t ref_rqid;
 
+	bool inflight;
+
 	unsigned int nr_grants;		/* number of grants in gref[] */
 	struct scsiif_request_segment *sg;	/* scatter/gather elements */
 	struct scsiif_request_segment seg[VSCSIIF_SG_TABLESIZE];
@@ -104,7 +106,11 @@ struct vscsifrnt_info {
 	struct xenbus_device *dev;
 
 	struct Scsi_Host *host;
-	int host_active;
+	enum {
+		STATE_INACTIVE,
+		STATE_ACTIVE,
+		STATE_ERROR
+	}  host_active;
 
 	unsigned int evtchn;
 	unsigned int irq;
@@ -217,6 +223,8 @@ static int scsifront_do_request(struct vscsifrnt_info *info,
 	for (i = 0; i < (shadow->nr_segments & ~VSCSIIF_SG_GRANT); i++)
 		ring_req->seg[i] = shadow->seg[i];
 
+	shadow->inflight = true;
+
 	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(ring, notify);
 	if (notify)
 		notify_remote_via_irq(info->irq);
@@ -224,6 +232,13 @@ static int scsifront_do_request(struct vscsifrnt_info *info,
 	return 0;
 }
 
+static void scsifront_set_error(struct vscsifrnt_info *info, const char *msg)
+{
+	shost_printk(KERN_ERR, info->host, KBUILD_MODNAME "%s\n"
+		     "Disabling device for further use\n", msg);
+	info->host_active = STATE_ERROR;
+}
+
 static void scsifront_gnttab_done(struct vscsifrnt_info *info,
 				  struct vscsifrnt_shadow *shadow)
 {
@@ -234,9 +249,8 @@ static void scsifront_gnttab_done(struct vscsifrnt_info *info,
 
 	for (i = 0; i < shadow->nr_grants; i++) {
 		if (unlikely(!gnttab_try_end_foreign_access(shadow->gref[i]))) {
-			shost_printk(KERN_ALERT, info->host, KBUILD_MODNAME
-				     "grant still in use by backend\n");
-			BUG();
+			scsifront_set_error(info, "grant still in use by backend");
+			return;
 		}
 	}
 
@@ -308,6 +322,8 @@ static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
 	BUG_ON(sc == NULL);
 
 	scsifront_gnttab_done(info, shadow);
+	if (info->host_active == STATE_ERROR)
+		return;
 	scsifront_put_rqid(info, id);
 
 	set_host_byte(sc, scsifront_host_byte(ring_rsp->rslt));
@@ -348,9 +364,7 @@ static void scsifront_sync_cmd_done(struct vscsifrnt_info *info,
 			scsifront_wake_up(info);
 		return;
 	default:
-		shost_printk(KERN_ERR, info->host, KBUILD_MODNAME
-			     "bad reset state %d, possibly leaking %u\n",
-			     shadow->rslt_reset, id);
+		scsifront_set_error(info, "bad reset state");
 		break;
 	}
 	spin_unlock_irqrestore(&info->shadow_lock, flags);
@@ -361,28 +375,41 @@ static void scsifront_sync_cmd_done(struct vscsifrnt_info *info,
 static void scsifront_do_response(struct vscsifrnt_info *info,
 				  struct vscsiif_response *ring_rsp)
 {
-	if (WARN(ring_rsp->rqid >= VSCSIIF_MAX_REQS ||
-		 test_bit(ring_rsp->rqid, info->shadow_free_bitmap),
-		 "illegal rqid %u returned by backend!\n", ring_rsp->rqid))
+	struct vscsifrnt_shadow *shadow;
+
+	if (ring_rsp->rqid >= VSCSIIF_MAX_REQS ||
+	    !info->shadow[ring_rsp->rqid]->inflight) {
+		scsifront_set_error(info, "illegal rqid returned by backend!");
 		return;
+	}
+	shadow = info->shadow[ring_rsp->rqid];
+	shadow->inflight = false;
 
-	if (info->shadow[ring_rsp->rqid]->act == VSCSIIF_ACT_SCSI_CDB)
+	if (shadow->act == VSCSIIF_ACT_SCSI_CDB)
 		scsifront_cdb_cmd_done(info, ring_rsp);
 	else
 		scsifront_sync_cmd_done(info, ring_rsp);
 }
 
-static int scsifront_ring_drain(struct vscsifrnt_info *info)
+static int scsifront_ring_drain(struct vscsifrnt_info *info,
+				unsigned int *eoiflag)
 {
-	struct vscsiif_response *ring_rsp;
+	struct vscsiif_response ring_rsp;
 	RING_IDX i, rp;
 	int more_to_do = 0;
 
-	rp = info->ring.sring->rsp_prod;
-	rmb();	/* ordering required respective to dom0 */
+	rp = READ_ONCE(info->ring.sring->rsp_prod);
+	virt_rmb();	/* ordering required respective to backend */
+	if (RING_RESPONSE_PROD_OVERFLOW(&info->ring, rp)) {
+		scsifront_set_error(info, "illegal number of responses");
+		return 0;
+	}
 	for (i = info->ring.rsp_cons; i != rp; i++) {
-		ring_rsp = RING_GET_RESPONSE(&info->ring, i);
-		scsifront_do_response(info, ring_rsp);
+		RING_COPY_RESPONSE(&info->ring, i, &ring_rsp);
+		scsifront_do_response(info, &ring_rsp);
+		if (info->host_active == STATE_ERROR)
+			return 0;
+		*eoiflag &= ~XEN_EOI_FLAG_SPURIOUS;
 	}
 
 	info->ring.rsp_cons = i;
@@ -395,14 +422,15 @@ static int scsifront_ring_drain(struct vscsifrnt_info *info)
 	return more_to_do;
 }
 
-static int scsifront_cmd_done(struct vscsifrnt_info *info)
+static int scsifront_cmd_done(struct vscsifrnt_info *info,
+			      unsigned int *eoiflag)
 {
 	int more_to_do;
 	unsigned long flags;
 
 	spin_lock_irqsave(info->host->host_lock, flags);
 
-	more_to_do = scsifront_ring_drain(info);
+	more_to_do = scsifront_ring_drain(info, eoiflag);
 
 	info->wait_ring_available = 0;
 
@@ -416,20 +444,28 @@ static int scsifront_cmd_done(struct vscsifrnt_info *info)
 static irqreturn_t scsifront_irq_fn(int irq, void *dev_id)
 {
 	struct vscsifrnt_info *info = dev_id;
+	unsigned int eoiflag = XEN_EOI_FLAG_SPURIOUS;
+
+	if (info->host_active == STATE_ERROR) {
+		xen_irq_lateeoi(irq, XEN_EOI_FLAG_SPURIOUS);
+		return IRQ_HANDLED;
+	}
 
-	while (scsifront_cmd_done(info))
+	while (scsifront_cmd_done(info, &eoiflag))
 		/* Yield point for this unbounded loop. */
 		cond_resched();
 
+	xen_irq_lateeoi(irq, eoiflag);
+
 	return IRQ_HANDLED;
 }
 
 static void scsifront_finish_all(struct vscsifrnt_info *info)
 {
-	unsigned i;
+	unsigned int i, dummy;
 	struct vscsiif_response resp;
 
-	scsifront_ring_drain(info);
+	scsifront_ring_drain(info, &dummy);
 
 	for (i = 0; i < VSCSIIF_MAX_REQS; i++) {
 		if (test_bit(i, info->shadow_free_bitmap))
@@ -586,6 +622,9 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,
 	unsigned long flags;
 	int err;
 
+	if (info->host_active == STATE_ERROR)
+		return SCSI_MLQUEUE_HOST_BUSY;
+
 	sc->result = 0;
 
 	shadow->sc  = sc;
@@ -638,6 +677,9 @@ static int scsifront_action_handler(struct scsi_cmnd *sc, uint8_t act)
 	struct vscsifrnt_shadow *shadow, *s = scsi_cmd_priv(sc);
 	int err = 0;
 
+	if (info->host_active == STATE_ERROR)
+		return FAILED;
+
 	shadow = kzalloc(sizeof(*shadow), GFP_NOIO);
 	if (!shadow)
 		return FAILED;
@@ -709,6 +751,9 @@ static int scsifront_sdev_configure(struct scsi_device *sdev)
 	struct vscsifrnt_info *info = shost_priv(sdev->host);
 	int err;
 
+	if (info->host_active == STATE_ERROR)
+		return -EIO;
+
 	if (info && current == info->curr) {
 		err = xenbus_printf(XBT_NIL, info->dev->nodename,
 			      info->dev_state_path, "%d", XenbusStateConnected);
@@ -784,7 +829,7 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info)
 		goto free_gnttab;
 	}
 
-	err = bind_evtchn_to_irq(info->evtchn);
+	err = bind_evtchn_to_irq_lateeoi(info->evtchn);
 	if (err <= 0) {
 		xenbus_dev_fatal(dev, err, "bind_evtchn_to_irq");
 		goto free_gnttab;
@@ -914,7 +959,7 @@ static int scsifront_probe(struct xenbus_device *dev,
 		goto free_sring;
 	}
 	info->host = host;
-	info->host_active = 1;
+	info->host_active = STATE_ACTIVE;
 
 	xenbus_switch_state(dev, XenbusStateInitialised);
 
@@ -982,10 +1027,10 @@ static int scsifront_remove(struct xenbus_device *dev)
 	pr_debug("%s: %s removed\n", __func__, dev->nodename);
 
 	mutex_lock(&scsifront_mutex);
-	if (info->host_active) {
+	if (info->host_active != STATE_INACTIVE) {
 		/* Scsi_host not yet removed */
 		scsi_remove_host(info->host);
-		info->host_active = 0;
+		info->host_active = STATE_INACTIVE;
 	}
 	mutex_unlock(&scsifront_mutex);
 
@@ -1009,9 +1054,9 @@ static void scsifront_disconnect(struct vscsifrnt_info *info)
 	 */
 
 	mutex_lock(&scsifront_mutex);
-	if (info->host_active) {
+	if (info->host_active != STATE_INACTIVE) {
 		scsi_remove_host(host);
-		info->host_active = 0;
+		info->host_active = STATE_INACTIVE;
 	}
 	mutex_unlock(&scsifront_mutex);
 
@@ -1029,6 +1074,9 @@ static void scsifront_do_lun_hotplug(struct vscsifrnt_info *info, int op)
 	unsigned int hst, chn, tgt, lun;
 	struct scsi_device *sdev;
 
+	if (info->host_active == STATE_ERROR)
+		return;
+
 	dir = xenbus_directory(XBT_NIL, dev->otherend, "vscsi-devs", &dir_n);
 	if (IS_ERR(dir))
 		return;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 07:55:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 07:55:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316103.534862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njz01-0006g1-TX; Thu, 28 Apr 2022 07:55:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316103.534862; Thu, 28 Apr 2022 07:55:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njz01-0006fu-QY; Thu, 28 Apr 2022 07:55:41 +0000
Received: by outflank-mailman (input) for mailman id 316103;
 Thu, 28 Apr 2022 07:55:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njz00-0006fg-NG
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 07:55:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9885504a-c6c8-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 09:55:39 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-ULQB8c2APby272BHF4BDWw-1; Thu, 28 Apr 2022 09:55:37 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR04MB4592.eurprd04.prod.outlook.com (2603:10a6:803:75::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 07:55:35 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 07:55:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9885504a-c6c8-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651132539;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UH3WRMXNzMgz6xBZXjnATnCw0a/JPuWXgxwv0LToAC0=;
	b=WR+SCO8SSOBLXMbUhHBOcsiisqCeYUA0jMm4s2hM6frwNwJSfeoLbxtv9vT7v9OQ2WfAnd
	a5S2l8x4C0YqRZnGMPnFP1JzNTcB928jipzKWPzBsTmAtdx/IKA9698R/aqeFDsGKuRyB3
	viyhrQv8Vx3V5R2go+pOcM2INZdukaQ=
X-MC-Unique: ULQB8c2APby272BHF4BDWw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KdGsRI4Dds1FoCQ7Y66yQ+U0jNjMFRn9hFOLHjLTAWia2vxQWKQevSvzrWoEJKKoZuVPMfhWZuYj2Ak0ghYZcBAsCnRRPI0Pzb5rdbtR6n0cLzgBr4f5wIufH65vH7NNOSQhFP/PrBA/35jL3tL09AwZ/xQRga2Fo3dnTmq1Zcu0pjSLc5OHbZ99WC973vYeatI1VujvO7ShxjoNN8JtgizpsMRc+5MmZVWIH4TvkajmY+lbkOv6ZeuYob9e3eHPlCriykhz1y9vFY+XSXxi76VFlgJXvlat60eLeegoVSsM6CeZk/kr9v6fH5WFepfRi3V4IOlU1oZv5LF4i5bfbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UH3WRMXNzMgz6xBZXjnATnCw0a/JPuWXgxwv0LToAC0=;
 b=iJ3EFg1zQaIrfsX0L6GsXL/44KZCRaIXpZcIMDBkOXvgXXAW741nEEhgKOdSz8NuPMQ80k3sEzpLe6mC0MCxEjDoN6Y/qZjHeJgE9KR8KyhNB9QFTpIKBbjlt/QyTX0kkVKe1XSCjhwqWk0yoGC+zwGveehNFUBdbAVG2TYPKiL8m7s7pZBsp/buNQCjnZB09t4dct/DU059nRZJrTAneX+bnxCLMLtyUyZv8wU3h4l5TbKwZsjHNDIr2TScHq/lWi94MqhvSo6SojjMkaOlPLAoobX5JR+IqMI4ZB60gcDlG/dJH00mK30fOBnrwzppxMkB/fYJtBSwPTfhwX9lVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d0347cdf-046e-594c-80df-03b23d381d8e@suse.com>
Date: Thu, 28 Apr 2022 09:55:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86/msr: handle reads to MSR_P5_MC_ADDR
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Steffen Einsle <einsle@phptrix.de>, xen-devel@lists.xenproject.org
References: <20220427154701.84315-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427154701.84315-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0062.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::39) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 28a994bd-d6a6-4026-bbc7-08da28ec79bb
X-MS-TrafficTypeDiagnostic: VI1PR04MB4592:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4592A4E8047B323F0E80175BB3FD9@VI1PR04MB4592.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mhz3r71iovSAA1CjnrCQeXpabkjpz4pZuVMZD9UOCl+PrrVtiO17GVmWb/GQ+L/TEB8kYDhG+kvV0sFIRdET7bL4YVIR/aoO6sFcTjjfX1znBdwxdW07VPkQAZzi0kFvFya/NVLMMzeCs2tCs57FksH5NBux7YLi2hF+2YUSqknYEtydvX2i/hobBeZ+1dE/7xom9wxo+Z5XHs3uvrwskBz4FmEMO6RnhHWwPYA36sT1Sgpav0QtYQYy9bwHct/KJxML/dSi3NBSeNlHWUtHx239o0D1KusgOtEvOUlbFCbm6xdYRrRrZYKxT8NuuixZIyhQkyWJDPonSHyqaxTx5a0T88Xs8GCO8YNCxPMxMsBiuGA9eDYTk3WjIgn2uBqQ8DwJquWZ7OrIc8gkONBWnkKDrBxC5A4gldiFdzekhSEYZNbjYgmHh5gtizTFAI6RmgfOejA+B8Njnsmg+JguC6BQKsadkomdnjxBNjicp+EAxgbJJ1VQHSIqQbmpQVyRZMhP/w7lXCZc3BimD0UV37eeYk/W7//BGDeJfje186C4zxYmVy6UsCuNN1Wqg9gFkgFHXOZQJDiDeuqa7q8Yhkkxe5EksLwas2ox02vFuMfZwt9RK/U2bOCsoVeDqg0vFrzy6lwOImwXVq/GJgthU0rE7BQ9KBV70X1Mm+153fq5A3RN6f8bqs7rSm+sMQ2tzBT592h6meFOZK+kSFWJsXviVlvR9XDRphAk/fRo4mE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4744005)(8936002)(8676002)(5660300002)(316002)(6916009)(54906003)(36756003)(6486002)(26005)(6512007)(53546011)(6506007)(508600001)(31686004)(2906002)(66946007)(66556008)(66476007)(186003)(2616005)(86362001)(38100700002)(31696002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VmMxNDhtNFBXOGUrcFdXL3FlRGprcDFTMFZ0b2ErcE5zaE5OZ1I5UUtsdDEr?=
 =?utf-8?B?bVp4RnpkTHFYbHAydUFOQmpuNjhIN2xjUHBjRzZJZUMra3ZITDVnUXAwYmtP?=
 =?utf-8?B?ZHJCaUxmL2JxbHFlU0RWbk1hU1NnQmZkUzVvRHVFelEvYk1wQTZmSHZMZzBX?=
 =?utf-8?B?OUtZN2R0TEk2cWhlVzFRNXpUMzY3d0k4NmFOM1BhR083Mk9wZ1NuOUZqaGZT?=
 =?utf-8?B?QmE0bkt5V1JNdXV2cWxCVVIrRWI1eHpvT080K2QyaU5GRXBQOFNqclVhNWJx?=
 =?utf-8?B?VVJ5ZVd1MTEzQ0dsUmg5UFBqazZEaU5BZ1ZZUnlwTlhhV0cwejBqR1FjaDFS?=
 =?utf-8?B?dzhFaVF4ZXV1cWphci82T21kRVFZbG5uQWVYZUdqMzl5SG83QjJUSWgwWUJ1?=
 =?utf-8?B?d1M1NXlmZXc2WTNvVkNHMGJwNjRYVitKZy9JaUgyMWVHb0xxTW9GdnlmdmpJ?=
 =?utf-8?B?eUhXS2ZGdHZSR3dIbXAzM3pwZEs0TnEwVGhnOE9tRFVteUFtQ2pmOTB1S2Qy?=
 =?utf-8?B?Z3VrTnF2MU10UjV0ZFJvNHdWejVnU2U5elduNlBnUjIvK3RuWGxKZ2FTb1hV?=
 =?utf-8?B?elZnU2NCRXM5M2pEOWFxVmkxem5qV0QwRHhRdjhwT1RWck0rQWY3V0hIdDFa?=
 =?utf-8?B?Smk1RXF6QmM1M1FXQzJSZlR5K0EwR3F6dGVaMnZMcWtmSjhPTE5VZm1WOUI4?=
 =?utf-8?B?aXcwL254MHlHdWFVMW41TXREeUx2RzRNZUc3WmF6eldvY2xrZ2NaRENBemVT?=
 =?utf-8?B?dm9ta3VhWjcrWVloWXJJeTBlNzkyYzFxYXBWVHY5MWQrV29QK3ZkeUNLMlh4?=
 =?utf-8?B?alJwRllLcSs5VGw4VXQ0MGlWa2NJb1J2N3F3KzJnS0U4YTVxNzVQbFY1aWNC?=
 =?utf-8?B?UEZlL05FUVBqQ2w4cFE3RmZKL3BEYXYrUEMyUzhsZWZsNmMraDRzODJ6WWZw?=
 =?utf-8?B?SnlyQTNuazNBZ2JqakhuNDVaMm9GQ1JZeXhwd1JoTHJkN29RdXRsV3hkQ0xa?=
 =?utf-8?B?blBBS2hNbFlncXlSZ3RrdlZySm1Lckx6alF3MFFuR0grUnhvT0luVWRnK2Zy?=
 =?utf-8?B?TWlKRXhhUmE0UmI2OUVVYlpnUlViMytLNXBGdy80c253SzFmK3hVbFdGcUJJ?=
 =?utf-8?B?MCtrL0F0cHRaNU5jVGN3cy9RemUrZ1VmRUFhU0d1enNsa1R4OHRoNkl3T3pt?=
 =?utf-8?B?c3cvVC84bkEzSWZneHNQdXZCbVRPNXBjTWFZR2lYTDdPSnZVb3UzUkpWN1M5?=
 =?utf-8?B?QldYQXpOMitQUERQTmNNQ1Q2SVBGaFR4eGlxRElUNzhsWXZXVG1VMHBpUUJJ?=
 =?utf-8?B?US9abEhZZEk4cHhRZEVTaDRobnRVR2VydGM2M2ljYmwxVmhSNHZnaS8vOE5j?=
 =?utf-8?B?bldPaG5uSktjQnhQMTlhNkFrMHhCR29XVTgvUDI5WW5RR0FlN2FML3pKbHMr?=
 =?utf-8?B?dEdQMjArZklBd0RLazZpTm5ORWQ0Y0twL3kxcmpsc1RtcDBweXE3ZVkybll6?=
 =?utf-8?B?cFk2WEhVSDJROEw4ek4vVTd4UVhON3BOdVVZbysyaWIwOGNMRWt6SnF5Q1ls?=
 =?utf-8?B?YkpveUQvZEpVV1hZdENMSGtaRUZjenVCaXNzd2U5UWtCbW9nUC9jTzUzRS9o?=
 =?utf-8?B?Q2l1TkxmKzhaem9nM0lpMUxCemRHdC8wb1hTbEZnWHl5ckpteXMvUFhET3ZG?=
 =?utf-8?B?UGEyckRqck1UQ2NudGliY3EzMTBrZERiY0lHZDNpUjlxaWhrMkR1dmJmRG9I?=
 =?utf-8?B?V0dPUFlHYXZhREZNYW9LWDdKOHpmZ0pza2J5cUtqUDhmdW9GNWFaQzhDSi8y?=
 =?utf-8?B?RE1UZytrWktkeXI2N0NSNC90cDZKWG5wMGxaVzZwdWZSV3h3Rzk4QmpENGc2?=
 =?utf-8?B?NklMd2lmRWh3ZDFqWkRKZ0xUcGZqcUp0aEFSakZjUG01cEY5ZVlJV0ZsMXNB?=
 =?utf-8?B?aFpUL3p4dUd6NXpzQy9XNWZOWXJWT0YvaWd4V2VOMnhpSXhaRnpqaWpkazda?=
 =?utf-8?B?SXIvK1p0dkl5Q1UrTDJDVzNzN1pSUlFDaXM5ZDVHelV0SzRVZGR2dVVFa2dX?=
 =?utf-8?B?Vm1QSjNYZmhXUEJGeUtBSGpiUkkzVUhTME54WlY2blF0NkZnUWxEWUFYUUJ1?=
 =?utf-8?B?N3BsK042WDdvaytQQWVnUThuT2pqSGZMaktaenpSQkY4ZTlzQ1d6dHZjUjJV?=
 =?utf-8?B?YjhnV2RxbXZEc3VFSERUMi9nZ25TRE1xNFZZeTNCODZHUzBYS3hCY3lEaHM0?=
 =?utf-8?B?RnFZQnNmMEpNKzFYUFd1V2lURGxxQjlzSmNScXdPNmhmQUZLbGxQT2RpYXAy?=
 =?utf-8?B?QzJnc3NVSEJZZHJwR1B3YjVXdEFVTEpYcHdoWlB0MkdjMDQvS2RiQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28a994bd-d6a6-4026-bbc7-08da28ec79bb
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 07:55:34.8598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w514Blx3Z+8zmfaEW9jx5fgH1fH52fJauy/dOPR7OlcpkrH0FCknQ6OJzqq4xEx7CT83P8ksqsuhS0thEyLkkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4592

On 27.04.2022 17:47, Roger Pau Monne wrote:
> I've added it for CENTAUR and SHANGHAI because the MSR is there since
> Pentium, so likely to be implemented by those vendors also, but have
> no way to check.

I think that's fine.

> I wonder how long it will take for Windows to also start poking at
> MSR_IA32_MC0_ADDR or other MCE related registers.  For now this seems
> to be enough.

Those are handled by vmce_{rd,wr}msr(), aren't they? As a result I
wonder whether the MSR in question as well as its companion
P5_MC_TYPE wouldn't better also be handled (faked) there. (Even if
not, I don't think we should handle ADDR by not TYPE.)

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:06:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:06:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316126.534873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzAM-0000Ps-Fa; Thu, 28 Apr 2022 08:06:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316126.534873; Thu, 28 Apr 2022 08:06:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzAM-0000Pl-BY; Thu, 28 Apr 2022 08:06:22 +0000
Received: by outflank-mailman (input) for mailman id 316126;
 Thu, 28 Apr 2022 08:06:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njzAK-0000Pc-DM
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:06:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 157e522b-c6ca-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:06:19 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-jdfFi5klO8aS2kWLLhfhXg-1; Thu, 28 Apr 2022 10:06:17 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB6363.eurprd04.prod.outlook.com (2603:10a6:10:3d::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Thu, 28 Apr
 2022 08:06:15 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 08:06:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 157e522b-c6ca-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651133178;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/gemsHyzHFReyX638pDAq2GYKoO7Sivl1KCn+3UiyKk=;
	b=mqxpSgh5hPxaEkq57ULuLj3C2vX8eA/wEfKahCP0Je3Nddv0DdCl/+fbl7eoqMwnRHbtZ2
	X0rcOCfO7gJ4Noz9GgT2sAjjyDcnZkl2mQwzR3p7F6brNDC4IiYoqCgZza30R1SAShtprR
	Jnus6oHtqygP9imLEFkgs5UGQopvwFQ=
X-MC-Unique: jdfFi5klO8aS2kWLLhfhXg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CSxZ+2gDgptJE6ceEafNQpGfts/bDAAVTeoDctJCxw0+17tRnaCbsuzFrKaHBpcu6OE24mB+MYQuSnaZDU2dOM1YlYLuKB7HTyyV8p986RyQrl+nAbLplEB3b5OhBQat2mzfLhpJwGqwKT+NXPL+5cFcWFAlLLj46WM206WthoI8MIJL1R8/fTdcC/+Wqq7wHUCG6Ak4f2efn9VAQTvTkNUpQQ2L2YfXCImPNybN6ufBs06twjsh2brZmaJVchvY+m8xKevv6sXlMPeHL9WyZwZNfgbZj/k+MyV/e20fmAza/YAtx8LIqkECwexq0mjK5p3g6nXKNPQl47J22n+nMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O3kd+zNhcVFHNHDnYQEavuLTfd5FFTM9re4SHFaXEYU=;
 b=FUwXdBf8iXtt4j3xrRKAskeJgUDv6wGKVoIJ6PjFpkNmNYoTKNgfUJeLMnXrzuQXY0VcjYr7iJwN1IHSv51NMf76TO5xsJvJTMK5n/NGmWV/VJC0V5ybF5F/umZjUC+SYJ7BmopP8GU9o2gbkRWROt9sCOBH5tilYrKVHEop9XZfq+DKBm/npW9IthlfiHtYsWowaR6tFADqRNTbsLn8/VgxKPoGjIB4sosafFxrRLdSw4MRkaUXs/tndB6lbwG/QF6eGjk0wddG0Gmo36i9dSPT/9/1+a6smgSKrUJfmGYiZFEIvVZZblPFAHmmmqgtTvt8EHRtWxueJ/8lzpkCOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <06e25ac5-dc84-5a31-100a-493d5f88fa9c@suse.com>
Date: Thu, 28 Apr 2022 10:06:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 1/2] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>
CC: Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
 <6dd6719f-a05d-3f90-95b5-0ce9b5b0a2da@suse.com>
In-Reply-To: <6dd6719f-a05d-3f90-95b5-0ce9b5b0a2da@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0084.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::20) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b7ec5bb8-8c6b-4a1b-9b0c-08da28edf743
X-MS-TrafficTypeDiagnostic: DB8PR04MB6363:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6363BCF6B0A0F9B313B68043B3FD9@DB8PR04MB6363.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D1/waTDSFsQskVS7H0OQ5FI2k+eYTKy9P1jtJ+2Ii8zv9Ga6aW1xVypsRLpZAK5Lh9qRZjm2hkKlb/bCI/2rrmZz0GCCdeS9hNeBdijKcsK08E5mVNKZG/Q2jtP16nZiBtpyT+sJsqfNupyool1V7QJiC80vuDqvX+GcbecemHEv21X9AaIvtctg8Feo6Q1ZjHwB03bMZ9NxlDaZF4Cii7Nr+Sx6nkRTQ4wD9P/+DudYfuGdowAkgX/9pPHs3NZ0dJWMy6G00jwIhmDPFDHhj5c9BWrT46lqAXtYvzd+1tLPmjqq6lngRZWl+QYHPx93UNjlgdZ+ocCt0G3Hts+mbJhKwHbGtESsM1VAN6TWj6c0ZrYnvXuLA+JoVql2tdF0xI52UbCRfrYhqrYKi11XVA06lu/qdph69rXyA4Nyaa/SBA5OKuod/bPUx/7saWphdsSZxREgNl6V74Eau4jI59N3Uq4pwVHXFtLAsUatVaJJY5C2Yth4TgXbgB71ZBP220n9oOX0xYSGNoc4EnwaERQABxDq4Xy25fi1Zmk70yuiVctq3Vral4eTHhFXFLRpUnHAQPPferRynwrvVgwpapKE1wYwj6YXX7N7KwSKo4fRI9kpHbPCPLxQHT/mSjZYGf/ptZVBN1NFMmjgRtaq7RbOCT5vNwkMagVZN/G9wBDbTr7wck+w0nRwOwd+nOenOQCZJk9d2wX77TngkfKBJuxwoN3FArX8DPhBukpw5PY0TfHmWRTyrGgCEpBfcwLW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(8936002)(36756003)(6486002)(31696002)(2906002)(508600001)(7416002)(38100700002)(83380400001)(186003)(8676002)(66946007)(66476007)(66556008)(316002)(4326008)(6506007)(53546011)(54906003)(110136005)(2616005)(6512007)(26005)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?W6Dpb1b3QlvtbmL8O2q++2czhH4lTZut+QMxGhXkJ4V0qDdtPCfEkjM1aqwo?=
 =?us-ascii?Q?k9TmgI+uBucAv4zHvbCUOTsXRAmhVP7aHlPJvgGhizmz3BGkXcLDVErhPwWV?=
 =?us-ascii?Q?usUA5nL84gHpy3/LJ7fBe3emXk5wjEduyvTCrdYbcBAsukqNpkR16WmTdDLu?=
 =?us-ascii?Q?Qsg+mru1z1O06I5rDJFJDfhfnmPwHmIMmzOf50A2MfkmR6CoIneaTr+RpjY1?=
 =?us-ascii?Q?NTTlsjNlcWEKEOj1Y9mlwcVmflFWR7hQkl3t5DA9LY3Uq+NxW+3LwWZVKaXW?=
 =?us-ascii?Q?UCndtrCvF282YfJ540IfAT82gjCj4m707chwxZ2p8Iz5Rad9DXtyKunmW7Bc?=
 =?us-ascii?Q?ei5K0XFEcJsJpB8hxhsNmq+L/3B0FqERF8ihA2hsdqxhZPXnja9Y7q0UlvME?=
 =?us-ascii?Q?m1TLchLzRnwA0cZdGfibVtKXrMRvvxIzBUIIlaC1jFgTGgl8Z6bTKGVNEcIu?=
 =?us-ascii?Q?ip+BmulS7Z7RK7oXnwVmQIcoJ6clqbHsl6oiCgBGa4IzVhkhTzop8QdmJpAd?=
 =?us-ascii?Q?X9zyN8MyP5Jzxzhv5kRd/RPjv9V9hcvo7plNjqXezV1nIdjqHMoZvPsOABZQ?=
 =?us-ascii?Q?KaZaII+OVjjWIugSFFfaHFzmsyuChgi+U5BzmrdNNvGbjAwAcpslOdW6N2xu?=
 =?us-ascii?Q?NJ3hB1dZ28A9toeEmqEn/gXOA9DEKrkj0Rij9whyGpPqj5AQmf90xEoRQkef?=
 =?us-ascii?Q?2iFgWvEsFPwjqMu5w0in5Jt+gP0Zg7++ODkLqLhQde5ZZm9m/qPKynU5PGt9?=
 =?us-ascii?Q?pt2/k56HVjzTGoqE3Yu2x8G+7+9CjtpvWffIaJ0x6CYer3wup0mG423eBZla?=
 =?us-ascii?Q?26TpTyxydv6Kj+LxS1ELL2dmM3HNgK0S5ZQCUEst3bwxWIMlutVGmbC3Tscm?=
 =?us-ascii?Q?3j5gRQr1ebkFN5rTW9YN1RtEDwVCBX4fNhMyhS1pEELZ5nz8VIovtuK3mXbR?=
 =?us-ascii?Q?GweOHZdSUsLII9Kn7NxNAJBbLhznwhxBzpcw0poxlrC3fGWnEIhSXlPz1nVM?=
 =?us-ascii?Q?8JrmdcxImsjMrXdzXUQUFjXJEysYw57xvhI3Cl8iDXPpmB/8WTAXXI+jfP/q?=
 =?us-ascii?Q?7SQjZmuQauya2fBnkqWJS0xRWWyesZ8kqtk2UPk/CpqQo3g75z2AVYoXxqS0?=
 =?us-ascii?Q?tFt4rfw+TnR4cb7G3OZ9QJ0YTsU7z5N99AGjFKydhNug05Yqe0q0SuRM+U5P?=
 =?us-ascii?Q?PfrvHdtjZ2kD5uIKE6sXg7COf/mQDtVzfg0cGkfn7l3JxUS2AI0y+1QyzHvK?=
 =?us-ascii?Q?WxRJ53pb2wmBbFUiihd6ppJArf5ACSZtaRw03E0hI4FebMeHoynKH7ylpTb9?=
 =?us-ascii?Q?YEzr6rnfyS5MAWwYt8YBjluLZz3MKisrqL0VTxzLpjKu0jRUm4aNH53BhGw0?=
 =?us-ascii?Q?WH0/m8bJI/GVlvSrARDZQ2vHWlaAZ1/d00OqKkdPNhwWtLWS1AoH3/sFLe4d?=
 =?us-ascii?Q?5Bg+8CZWeEax7girbbCFTpxRWHfuhvfvuAaKzTscCoAhOIKSPwtsWADihgiC?=
 =?us-ascii?Q?pFXqxQ5H6rfc5KWawxrwfGPM5NQSOf8B7JI0+RLxe+brF5Wgv60oFIEGvIwi?=
 =?us-ascii?Q?OIbPgek8hQD3byS4wVBZOt0iAsGOH/pe6T6wCuTJr22hKI6TwRgOHlV/nhvI?=
 =?us-ascii?Q?aQkoFyyYpKobsVdZL7WwnpbFOn+JcBmHA+CpQ2lbd24Mqg7KpTnwiq+cY9Ys?=
 =?us-ascii?Q?ycvyRsTGBHiYXkZAzPIySWi6LStkpx5uzHiBQbQUQQesuff9d3vxEgwR3FsX?=
 =?us-ascii?Q?tzymp82yBw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7ec5bb8-8c6b-4a1b-9b0c-08da28edf743
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 08:06:14.9296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DQ+d8ceLso6fPSw1+wERqnIgRRIiMTzqf/78Xwt2rHd0u9Q4jblN5bb13rS+gvLi0sJgmkcr2F6HQhnAWNDo2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6363

On 21.04.2022 16:26, Jan Beulich wrote:
> There's no good reason to use these when we already have a pci_sbdf_t
> type object available. This extends to the use of PCI_BUS() in
> pci_ecam_map_bus() as well.
>=20
> No change to generated code (with gcc11 at least, and I have to admit
> that I didn't expect compilers to necessarily be able to spot the
> optimization potential on the original code).
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> ---
> Note that the Arm changes are "blind": I haven't been able to spot a way
> to at least compile test the changes there; the code looks to be
> entirely dead.
> ---
> v2: Arm build fix (for those who actually have ways to build the Arm
>     code being changed here).

May I please get an Arm side ack (or otherwise) here? Especially the
2nd, dependent patch better wouldn't remain pending for too long, or
else there's a fair risk for it to go stale.

Thanks, Jan

> --- a/xen/arch/arm/pci/ecam.c
> +++ b/xen/arch/arm/pci/ecam.c
> @@ -28,8 +28,7 @@ void __iomem *pci_ecam_map_bus(struct pc
>          container_of(bridge->ops, const struct pci_ecam_ops, pci_ops);
>      unsigned int devfn_shift =3D ops->bus_shift - 8;
>      void __iomem *base;
> -
> -    unsigned int busn =3D PCI_BUS(sbdf.bdf);
> +    unsigned int busn =3D sbdf.bus;
> =20
>      if ( busn < cfg->busn_start || busn > cfg->busn_end )
>          return NULL;
> @@ -37,7 +36,7 @@ void __iomem *pci_ecam_map_bus(struct pc
>      busn -=3D cfg->busn_start;
>      base =3D cfg->win + (busn << ops->bus_shift);
> =20
> -    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
> +    return base + (sbdf.devfn << devfn_shift) + where;
>  }
> =20
>  bool __init pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -839,7 +839,7 @@ static int msix_capability_init(struct p
>              pbus =3D dev->info.physfn.bus;
>              pslot =3D PCI_SLOT(dev->info.physfn.devfn);
>              pfunc =3D PCI_FUNC(dev->info.physfn.devfn);
> -            vf =3D PCI_BDF2(dev->bus, dev->devfn);
> +            vf =3D dev->sbdf.bdf;
>          }
> =20
>          table_paddr =3D read_pci_mem_bar(seg, pbus, pslot, pfunc, bir, v=
f);
> --- a/xen/drivers/passthrough/vtd/qinval.c
> +++ b/xen/drivers/passthrough/vtd/qinval.c
> @@ -267,7 +267,7 @@ int qinval_device_iotlb_sync(struct vtd_
>      qinval_entry->q.dev_iotlb_inv_dsc.lo.res_1 =3D 0;
>      qinval_entry->q.dev_iotlb_inv_dsc.lo.max_invs_pend =3D pdev->ats.que=
ue_depth;
>      qinval_entry->q.dev_iotlb_inv_dsc.lo.res_2 =3D 0;
> -    qinval_entry->q.dev_iotlb_inv_dsc.lo.sid =3D PCI_BDF2(pdev->bus, pde=
v->devfn);
> +    qinval_entry->q.dev_iotlb_inv_dsc.lo.sid =3D pdev->sbdf.bdf;
>      qinval_entry->q.dev_iotlb_inv_dsc.lo.res_3 =3D 0;
> =20
>      qinval_entry->q.dev_iotlb_inv_dsc.hi.size =3D size;
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:06:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:06:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316129.534884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzAg-0000qx-TR; Thu, 28 Apr 2022 08:06:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316129.534884; Thu, 28 Apr 2022 08:06:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzAg-0000qq-QE; Thu, 28 Apr 2022 08:06:42 +0000
Received: by outflank-mailman (input) for mailman id 316129;
 Thu, 28 Apr 2022 08:06:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1njzAf-0000Pc-Rr
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:06:42 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 214412af-c6ca-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:06:40 +0200 (CEST)
Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 04:06:37 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by PH0PR03MB6707.namprd03.prod.outlook.com (2603:10b6:510:112::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 08:06:31 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 08:06:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 214412af-c6ca-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651133200;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=g/PIQmNGDB3LfKlDC9ESR3NY1wR+stH9c77NVrkGaIE=;
  b=QhhSYaig6ve78qqz6zSbWXOIyjEndLkM88lS8vWu3aSsTVxS1WhODbSr
   s/N7Bb1HRiAZ5CpNNDHa8uVkLNZUCJ999k2ZKz9vP2v33IAAcZ/iPUNgt
   sK2xA+iriBVPTftbBcliP6L2nTZUFptaA5EXXAbk0MhQVB6aYaJMSkWcg
   s=;
X-IronPort-RemoteIP: 104.47.59.171
X-IronPort-MID: 70114762
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:/QVRYaALygs1wxVW/13iw5YqxClBgxIJ4kV8jS/XYbTApDIj3zcGz
 TYeWGiCPKyJMTPzKIglPtu09RxVuMfWzdI1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhxz
 I8clYGSaTwQP5DKpu8xdgdzTCZhaPguFL/veRBTsOS15mifKT7A5qsrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t3B8mcGs0m5vcBtNs0rtpJEvvEI
 dIQdBJkbQjaYg0JMVASYH47tLjw3yCjLGMCwL6TjaUdwm3i9RN96b3WHsDJX93NVZ5fj0nN8
 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAa60iDXtT7GRqirxa5UgU0XtNRF6g27V+Lw6+NuQKBXDFbF3hGdcAss9IwSXoyz
 FiVktj1BDtp9rqIVXaa8bTSpjS3UcQIEVI/ieY/ZVNty7HeTEsb0nojkv4L/HaJs+DI
IronPort-HdrOrdr: A9a23:b3ATOKDjt2d+S97lHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN
 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d
 enl4N6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1wjegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvW/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdb11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa
 hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj4lLYIk7zI9HakGOuh5Dt
 T/Q9pVfY51P78rhIJGdZA8qJiMexrwqSylChPgHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou
 WKbG9l
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="70114762"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JWsfZAnvZwdFAF/+tRbvucOqG1DSQYT9cHROAJe4h2uuwWbSMcHU8S7/9YqsY7cMjf3p4ydMYZHsvKWLBkLG6uBRvHTWFdj2q8jmFUjZWEfa7dZhOr/UqpA88shNVqiXClN+NpftDDHGgI/Oi3gYXZg4MD2mont3VTCfwk64BF2zoEAaX8B9TqOEukSCtR2mDgr7pYuGLuV1DUvv0X6LWgzeaxrQAXeUCsrImNixEicYWbGvSMOfd1/+kYsnkoa1F4tUbfapRxOlDE6XUtFhyGP9WaG+FB7EWjOIL823Bjf0ZHgVivMuMTwjLGC0q+fORgt8RJc9QPGegzBKyzgJog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aX9pNVCJbjAiUqScrtBfeRLTF+irJiIUFBKoTGvuesw=;
 b=OOPUhqrBPI6KYaqoIpgVwBkPzJT4wH6n3c5sC14lcxhCjLzFhSEr8OV7H2f9E0TewHhRll5YXpo61h0H7pU6RCQXzgNnT4KeoeFS6Y0c2T5Ctx2kh6MUdflcbXthEjJU2hNROK6yJNqXfBpSq4kjhzmCtOc/CyYFnT7llLp9b/InGGoNl97v28h0DZ3sD/gUUO7c2QsC9C/EYcbzn7Ryu8NAG8lm8V9vjmJdZ5Mlx7MEBzImD4yiN16KvHm4HMpQmyRu4EeUFlB31N6pkr5/hXJSgDT8t68LkqpBL2WvZmw7kwvivcO12PSYbrYaJi4t+2X0dfJMSIIBuRZ6ExvoLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aX9pNVCJbjAiUqScrtBfeRLTF+irJiIUFBKoTGvuesw=;
 b=mRz72rBYehAIYQI/aIpDAd0QPkqjGtGPLczF2FEI6Pvy7wwFJy+DHPXoZZSUpgMTevza0VG4JEQTyeFH8WRi5FvU7zO4Wi9nZOYTb283MSVC7yn7OgNh+f1XXuiOGUgIUNAFjHXjLkEOW8qCxiFqYCUxmkca44RxWO+lJkQcUGc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 28 Apr 2022 10:06:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Message-ID: <YmpLAoORo9uG1+yI@Air-de-Roger>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
 <Ymk7BjXdyiMUGoc8@Air-de-Roger>
 <47b50c64-b8bd-df95-9de9-175780c50e0b@suse.com>
 <Ymlb2Wly25k9bF0z@Air-de-Roger>
 <d9e797eb-5075-2c95-cfa9-959586577f98@suse.com>
 <YmlrYNFI75wQlVlg@Air-de-Roger>
 <9a4d1bec-321a-21da-6a11-4b4990c52895@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9a4d1bec-321a-21da-6a11-4b4990c52895@suse.com>
X-ClientProxiedBy: MR1P264CA0045.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 637a9135-581a-4dfc-438e-08da28ee0151
X-MS-TrafficTypeDiagnostic: PH0PR03MB6707:EE_
X-Microsoft-Antispam-PRVS:
	<PH0PR03MB6707E4E5438738D23A800AB38FFD9@PH0PR03MB6707.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MWKRAZeiwnk8O605K7DH682wmh/u2v3WJx8bjTqadwTHmEFpQNJ8pcstyzuGeRmRzev+0WXdMqsYl95sChKcNK2hyOitbXRO3RwQjHqKmZqPKSh2uZPrU4G2Epg3Fl0pxnQn0rdlPzhGKo326XGRM+v0wwLDUBlIa9QnsUn9XxTOPKkCK+X0jlujphY5yEuEnhzOmqxoZSltJRNexva/8bLLnVUpkHA3QJOwaNSRsa9lO1Gmg9E8exlbMtKjQGajGNZdYannxeJJHTorMOHqLWmA3MF8WgFkrjXI7WPiVEy1PJaHRvs2lz7AV4sFoayXE+R9opuSj0jWKdPhlMfcpqmznes33lqB3TYN64NSskXesPfBgl9geTT4zYFD4cFBfBDuuBEd3CHHWraM+qbURiUKxhdO5iXbEO3k070cZrWRlDFc3XOFxOF8rfmQAkiPySZioCwmuUAm9Cpzkyinwo4LUsw1UCsmFoJ5jeS55k2Hb+rzqyzNVRUqLT/EiyVkSb+syV4DLd6HkWejJeOVKRKBP03wWuL29UdPlsjv395rWPG6DxP0k5GDCDu62TqraJ0+DBQuUb+J1WCLXj1MkZ0z3EJEoeUv+7GstWSHiBGdbCnQK6hBOHhMLu9loaFW4/eMvTsaeVmXHaayOHIGAxtys/Exb7s5j8ZYPghYgVQJXqTvyOaeTlzY4TgpT+qmOQi6vaJC4OLh9U7lawx+iKXRMeN1VkbOPYr7Xf4zaLfVVpqQaGj6R0GSyqfLBCmL2jceIwQGcWDPpPGUoA2RUHJGlQLjUvVH0HQcm+V4pHQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(84970400001)(6486002)(508600001)(86362001)(26005)(6506007)(9686003)(6512007)(53546011)(38100700002)(82960400001)(6666004)(33716001)(66556008)(186003)(66476007)(316002)(2906002)(66946007)(5660300002)(8936002)(85182001)(54906003)(83380400001)(4326008)(6916009)(8676002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MzMwaWQxeGpzbUwxbndIUzd4SjFWVDJ3dWpxdVBzMC9SMXRIVWptd1VhN3FB?=
 =?utf-8?B?STJSeUM1cnVqUis3eml4RmRXS1kyVWxCd2kxRWc2NVgvNXk0RmVoSlNYaWJC?=
 =?utf-8?B?dGsrUHU1SWhkZVZTSVZ2djNmUnJrVk9xN0lCaXZ3eTl0L005NytOTC83NWxM?=
 =?utf-8?B?eHlqaTdxUjBKd0JCVm00NENXNmdZcFZWOEJGZkpHWTZyMURydng3a0pmeWZU?=
 =?utf-8?B?TkFXWDg5U0xYVU1XOWlSZlFOTGVrVk9TU2JaSXd1TnJFQnRjMkNpK2JYYXhH?=
 =?utf-8?B?aWVUeTNDVWJJTXNXbmRYOTJyQyt1QktDZzZuNkFEaUJUNXpwMDJDbElQV0xm?=
 =?utf-8?B?YkY3Rm40c3R4MzN0eHpQRUdsZW85S0M2amdYZm9Ic1l4MGprNXEwTzY3bDRY?=
 =?utf-8?B?Uk1XWmVOb0h1bzhPRHlLQXNmY3NyRDlhaTVTR1VyOHlqdjNBMk95QnBDcGpV?=
 =?utf-8?B?SkwwUFBxMzJjblhoa2RuM2NhcU9jYkdZakZhVGJ6SEJhQ2I2djczbGVBei9H?=
 =?utf-8?B?Tyt3REFXUDJsZkplU2Flb0xOZjBSclRNVFVvVUhLTkRoZEFpdmpOQW5TSTJr?=
 =?utf-8?B?QVk5OWJzdFRFZ3dscGJ0bkxrSjhUc1hzN24wVUhXZ1JJVFoxQXpPRlhNM2pB?=
 =?utf-8?B?NGd6RFFvRW11bTdZcndHNXdXM1hYRzdNMm1vSEZ5bU42ZUlPbjVnNmFidm1q?=
 =?utf-8?B?V1RvWUQ4QmFVUXZ1NnZmbXJhUHQxSURXcnozSkt5azc5dEMxT1VCUE5EVDFj?=
 =?utf-8?B?b2RQYklNclBicWhEaU51QlllaHh1M0VKRExSMjFMazV5dVB2V2oyUkFvMEhX?=
 =?utf-8?B?cEo1V3hCaDBoY1RqMmV3anJBSTVUb1VZd2paRi9HbmIrQ2FnWXRYdnY3bTZO?=
 =?utf-8?B?UU0rWW9OK3k5dWNtNTA0Slg0dG5sQVEzUUJWaHZFWE9CWVRoTUVEdVdVdVVD?=
 =?utf-8?B?TUFzb0pZMUFzVXlLZldEdE42cU4vRHVkMGNVUmhmU0NOa2I3bXJ6bnhhVVhn?=
 =?utf-8?B?YkhmRVcvODJxbnY2MU1lSnRyOUkyQXVaNG5ha2FieDJHYnM2WnMrUUN0eHE2?=
 =?utf-8?B?SzViTk5LRk41QnhQZDR3cWZEa3FwbDNjMjE1UldrN3FORExFTE1ScHNqTmJn?=
 =?utf-8?B?c3IyOHJ0RzRxakgzTkZPU2Y3WUljSDJ2ZXdMcUdrb1RWWUFHOG9rODR0amEr?=
 =?utf-8?B?b2FjVHFQbmpVMXpLMFhZWEFDNnhBcUpkTjdKWlZFeDJzQTRWN05BU1BkZnhG?=
 =?utf-8?B?Q1U1U2lHM1o4VDlEMGdiaVVFbzNQbmZtNTVjeFpIeExYalI2Z3NIOWJ5M3lm?=
 =?utf-8?B?RVd5T1QwSlhOemFUSFppVVlLMkNyVGV4YkhMZzg0NGpHR1grdlB1LzJnTXZi?=
 =?utf-8?B?bXE3QzZ6b3JnVmxsMnhzZ3c5MHJQOGJPT0d5RTFrblU4SXJtbTRMdGp2VjBC?=
 =?utf-8?B?Y1hVRy9BTnFQRTZLVTBVeERndmVvKzlsMXM3VHo2YVYwK0dmU0k2THFBLzlv?=
 =?utf-8?B?VXJieVFPS3owN1BBSEdNemlJL0lKRFd1NzNtU0xVZ3RaSzBLQnA1Y3hXdmQz?=
 =?utf-8?B?a0RFM1JseWNSMEZHR3dNc0EzWk9zWHk2ZGpWZ1lVZHdLYjRVODREd2ZoZDZI?=
 =?utf-8?B?NVJTUXdQMDZOYVdVTDhOTU1xZzZsUk5IdGlzUHVpRGI1SG5RZGxSakF5YmE0?=
 =?utf-8?B?MGlHckJQejRkeU5qK3N2ZmRQcys0SnhvMWZKdktyb0VwSVRJYUhxSU0vSTYv?=
 =?utf-8?B?Rmk3VDE4LzNGMHM0NU9OM1RYR08wZjV2S0d1TjNlcHpXYVBIMTJQbGVDZHpj?=
 =?utf-8?B?UEovbmR5dzBvQVZqK2RmU1hYYTNTQ2hwK054alhxUXFhdHlDOWZiZUxjYzRl?=
 =?utf-8?B?bHA5SG9VazNiSHhjQlpoRXFjTHF0WWVESk13MUkzN2lGOXhaRDZHb2tWTDRM?=
 =?utf-8?B?ckVoMVFFczFpQVgvSnRFRDdtR0JDbFNGTjVtTlQ0U0pnZ0hwZnlHTzVGYi9k?=
 =?utf-8?B?Z2RGb1FIVGRnQVJWUXFNSG9UWFI2dkRvYytFNUwrQk02d2RTSG1RaW16Q2No?=
 =?utf-8?B?bWlPVTh4T1ladXlTbkFJZy9JajNUTkdrM3BlL1J6UllMZkRPdUwyTk1kQnFo?=
 =?utf-8?B?dFBsa2lVUkJwSXI0ZmNmbzMreHJWOERGYXpXVDg1Q0hPWHhBNXFxc2hoOTBh?=
 =?utf-8?B?NVpLSmkrdzZsNHNyT2E0T0xGZGdXaklsOHc4VW5vSTZsVnBldHBmcm1FZits?=
 =?utf-8?B?K3ZQbXJMb0dTOXNBbUFidHZkNHpLMHZ0WW9IUXI3ejh5QXVFVlU1WUxhQXVO?=
 =?utf-8?B?N0hOa2Vlc2ZvZDRUWDNraEt4b0k2VmpUT1doWkxNdkZOdC85QzVkOWRwS0gw?=
 =?utf-8?Q?6LJEJ3yQMn42KC3w=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 637a9135-581a-4dfc-438e-08da28ee0151
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 08:06:31.7195
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fbD11UJ1RkmaNwE/cPhijTOXE4xGwvTMhG1h3pz5c2XwFOO9IkLyXyMfHyza5W0nRui2NyGIshPInssex7q6LA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6707

On Thu, Apr 28, 2022 at 08:37:58AM +0200, Jan Beulich wrote:
> On 27.04.2022 18:12, Roger Pau Monné wrote:
> > On Wed, Apr 27, 2022 at 05:25:35PM +0200, Jan Beulich wrote:
> >> On 27.04.2022 17:06, Roger Pau Monné wrote:
> >>> On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote:
> >>>> On 27.04.2022 14:45, Roger Pau Monné wrote:
> >>>>> On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote:
> >>>>>> --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c
> >>>>>> +++ unstable/xen/arch/x86/cpu/mwait-idle.c
> >>>>>> @@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
> >>>>>>  
> >>>>>>  static unsigned int mwait_substates;
> >>>>>>  
> >>>>>> +/*
> >>>>>> + * Some platforms come with mutually exclusive C-states, so that if one is
> >>>>>> + * enabled, the other C-states must not be used. Example: C1 and C1E on
> >>>>>> + * Sapphire Rapids platform. This parameter allows for selecting the
> >>>>>> + * preferred C-states among the groups of mutually exclusive C-states - the
> >>>>>> + * selected C-states will be registered, the other C-states from the mutually
> >>>>>> + * exclusive group won't be registered. If the platform has no mutually
> >>>>>> + * exclusive C-states, this parameter has no effect.
> >>>>>> + */
> >>>>>> +static unsigned int __ro_after_init preferred_states_mask;
> >>>>>> +integer_param("preferred-cstates", preferred_states_mask);
> >>>>>> +
> >>>>>>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
> >>>>>>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1. */
> >>>>>>  static unsigned int lapic_timer_reliable_states = (1 << 1);
> >>>>>> @@ -96,6 +108,7 @@ struct idle_cpu {
> >>>>>>  	unsigned long auto_demotion_disable_flags;
> >>>>>>  	bool byt_auto_demotion_disable_flag;
> >>>>>>  	bool disable_promotion_to_c1e;
> >>>>>> +	bool enable_promotion_to_c1e;
> >>>>>
> >>>>> I'm confused by those fields, shouldn't we just have:
> >>>>> promotion_to_c1e = true | false?
> >>>>>
> >>>>> As one field is the negation of the other:
> >>>>> enable_promotion_to_c1e = !disable_promotion_to_c1e
> >>>>>
> >>>>> I know this is code from Linux, but would like to understand why two
> >>>>> fields are needed.
> >>>>
> >>>> This really is a tristate; Linux is now changing their global variable
> >>>> to an enum, but we don't have an equivalent of that global variable.
> >>>
> >>> So it would be: leave default, disable C1E promotion, enable C1E
> >>> promotion.
> >>>
> >>> And Linux is leaving the {disable,enable}_promotion_to_c1e in
> >>> idle_cpu?
> >>
> >> Iirc they only have disable_promotion_to_c1e there (as a struct field)
> >> and keep it, but they convert the similarly named file-scope variable
> >> to a tristate.
> >>
> >>> I guess there's not much we can do unless we want to diverge from
> >>> upstream.
> >>
> >> We've diverged some from Linux here already - as said, for example we
> >> don't have their file-scope variable. I could convert our struct field
> >> to an enum, but that would be larger code churn for (I think) little
> >> gain.
> > 
> > Hm, OK, could gaining the file scope variable would make sense in order
> > to reduce divergences?  Or are the other roadblocks there?
> 
> I don't recall. It might have originated from a change I decided to not
> port over, or I might have dropped it while porting. To be honest I'm
> not keen on putting time into researching this, the more that I would
> generally try to avoid static variables.
> 
> What I would be willing to put time in is making a more user friendly
> command line option, but as said - I can't think of any good alternative
> (except perhaps "preferred-cstates=c1e" or "cstates=preferred:c1e", with
> internal translation of the strings into a bit mask, as long as (a) you
> would think that's an improvement and (b) the further divergence from
> Linux is not deemed a problem).

I think (b) won't be a problem as long as internally the user option
is translated into a bitmask.

Regarding (a) I do think it would be helpful to express this in a more
user friendly way, I'm not sure whether it would make sense to keep
Linux format also for compatibility reasons if users already have a
bitmask and want to use the same parameter for Xen and Linux, ie:

preferred-cstates = <string of c1e,c1,...> | <integer bitmask>

What I think we should fix is the naming of the two booleans:

bool disable_promotion_to_c1e;
bool enable_promotion_to_c1e;

I would rather translated this into an enum, as right now it's
confusing IMO.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:11:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:11:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316140.534895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzEt-0002Rv-Fw; Thu, 28 Apr 2022 08:11:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316140.534895; Thu, 28 Apr 2022 08:11:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzEt-0002Ro-C4; Thu, 28 Apr 2022 08:11:03 +0000
Received: by outflank-mailman (input) for mailman id 316140;
 Thu, 28 Apr 2022 08:11:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1njzEs-0002Ri-8L
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:11:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bda16243-c6ca-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:11:01 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-h5CcuQbjMz-BNdDQ-iU30Q-1; Thu, 28 Apr 2022 10:10:59 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB4439.eurprd04.prod.outlook.com (2603:10a6:20b:18::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Thu, 28 Apr
 2022 08:10:57 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 08:10:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bda16243-c6ca-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651133460;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OEupg5Z95395Bu7NP1udXgs5eMozR/+GBV8XSa41Mls=;
	b=bo/bMZTwskV3TFx2/gE0YJ3PESQ6a5nvo59CvPE5VD98WaKybRdmAX1m0YVq6yUvbgQ6Y7
	E9EdkoEPMATfDJKj1ryxHYAXno6PwTHlDMI0E8TxORjr+pGugyaVKPN9Y2yCln4g4Bm53o
	09Fu5UXx49MRQsi4SsH3zQA0T0G0Tns=
X-MC-Unique: h5CcuQbjMz-BNdDQ-iU30Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NsYdjTRmD0iGmaIShC3AeUa2jkR2ZvM0B/638BzpuiN5woGE2z9jvRaGRs8BqWsZ0+kZryVfxnZlDhOBDr9+AqycWY1vDDshJzn62cBKEVms/3v0sr/8PGDNhk/3hzOcEruT/pJqwBT3bAoafkaWdf2cNjXWia3e8otHGhrXwQ3Te1RPElrtHk3C9quiB2JLdaatvSC8SIb5sNgfQS/pIuurilC6NLeFvmEA2s3ggnV78Y+5MDnWxrTCzsMSzikD+zNy4e+0+lL6lSh8zZHKw3YRtJ60eNNPe45CpnZYC/PaZ5WdoW9eFpl2Rn7kZ5aQ9hskq1/sp/icsp06qUv4gQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8wSzMA2p0/jtSzHmJbmsc7/g1XLR1wYP8xbxa9wmVh4=;
 b=CUW4Oh1X9Nne/4tnxmg3JpDVdtOsSQBkolJnDA5qMomRCb/Aw9pBhj7oLBJtf1F+WgMkQuGNOM49yEwJwd2xCgd756YIGgOntUQ6mk17TQWF59CICydSOBS5+GYLMGV/lCa+mXqBI6OCT1by+HMBINPmL5mCLHZjIfoYJSJC8c8SH2e/gHiEMMEELOG5MTSUHBBUL0jfCqa7Pk4Tgw2KS2cSu3pvFXSlQOIK7dagrTD2M2bH13RLv9RtX1n3dKzJlL87E9T2qMQpW56XTNOzgQb4p4No6AA+cTup/HB+6Foc4hZr+ZwP2t9PFdiiQlHrA8AmWPZBixq7FDjs5sCK+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1114076d-b1d7-8653-0476-9e0e3a7d7845@suse.com>
Date: Thu, 28 Apr 2022 10:10:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <4eae5ab3-361c-4eac-619c-160147220be4@suse.com>
 <7c15016f-cc57-f128-4b79-79c820f3196c@suse.com>
 <Ymk7BjXdyiMUGoc8@Air-de-Roger>
 <47b50c64-b8bd-df95-9de9-175780c50e0b@suse.com>
 <Ymlb2Wly25k9bF0z@Air-de-Roger>
 <d9e797eb-5075-2c95-cfa9-959586577f98@suse.com>
 <YmlrYNFI75wQlVlg@Air-de-Roger>
 <9a4d1bec-321a-21da-6a11-4b4990c52895@suse.com>
 <YmpLAoORo9uG1+yI@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmpLAoORo9uG1+yI@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0156.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::13) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99adce60-0737-44e5-495a-08da28ee9fa1
X-MS-TrafficTypeDiagnostic: AM6PR04MB4439:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4439ACBBC9616D0049DCE16BB3FD9@AM6PR04MB4439.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PZZx1r1YNMnbgDxFHrKx23/DuoWDOHp4mrbP/LEd5Ei/VSdN/pBVRRb5wequ8eSbcrOe8CSAEJbTcgjtJNutdGbgd3I/6pCJVWHOSBMgXLZYweS8gLo0uIS4JsJJ6UK2UDAOZTwGDhP+ohmv1xWCYDWaYAtIa5O9rJNrnUZWwkCI6mm36HkQ8kdy9suKYaekE2ej7iaFfDzfVP2kpJp2FFcy6lMl01wqX0qJxM8d0pPXKsuIjADX4OlSLkt42tert5uNpSuIK26IsPCMs2yVPUagCM8bnOL/j0odG7/EaBuaJuYYddDo0Ah33WBdXVLmMZ8Vea1mM5Ba0tcqDZf0HVOGFsxmsociJ2YNzICW1L5ilyxJubNjo1y5WoRH3cS1gU54+HEpfZvC2dh6ROXrdi60yevxkhjqV19i56b0yWSJ42teISawLCS5LYqPA6UXxiqkDlLci1CCRVJBF5OWZANNyFYl4flNcmFCWmlvBW9HrR7PDTfj91D1EeAYr4rNwp4AR6wHbRtyYBsPyZnzIn68BcVFsSIIcCtkDTO74qmHzLDEMXPackxR20JAQXGmQtVIuPReTBVjLo7aCp0+8yGBddbgsDOhxbE0476N1+FR51e0JQ1cHSqvP8iJqUFYT6MOu8Vlx+Gb8u6XUkw66jjCwmk5fFohNeHJo8wviALHkX4F0pLlW1a4EiCygl39L20rzuTqA0cztnEcR6WDHpzEIngz/wmIuJkt/hsbOJasT7CyzhgO2SbREWJ0M3ynUnJiZIl9Cm0nQAh50Tic8mgace7Kpg3mIitjhbIWZhVH83fYDT3BsKfyx4EGIsKMq0g6uCxa8/HMJTlYV1h+vw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(316002)(84970400001)(54906003)(4326008)(8936002)(38100700002)(66946007)(508600001)(8676002)(5660300002)(66476007)(86362001)(6916009)(2906002)(66556008)(6486002)(31696002)(31686004)(26005)(6512007)(186003)(2616005)(36756003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?erCooSqDcSPYOJZXE3JDVUhVkKO6IskWnfEq2L4jgKg5ntc+fkhL+cCAKnw5?=
 =?us-ascii?Q?EV6tBPC1d8xna6WpzVCDl7C051/vls6z4BamPc/G65EkUDA0If5tnkm5IeZ6?=
 =?us-ascii?Q?gHsGkZdfW/54q3Ja+yOKxCGT3zo3W58kQkVCoH1XM/PS/mv9ZywZkp632XJh?=
 =?us-ascii?Q?H6+mpaHL5Ae41Y387VwnSW5Qx2AjAmAfl41ndCtMP7O0SfPiZA89+rW8B8rA?=
 =?us-ascii?Q?A20ltoCtva6Aw8OksgzaKs24ByuFn5jIhHR2ULqv5T15ok3jwDP8e4dVnXBD?=
 =?us-ascii?Q?UfSHis721mLaGFv1O3+5/5px0BWu4HvqS1H4qpmUIIc5XAVLWG5VVExElabd?=
 =?us-ascii?Q?E5cQhOk+Mn/GXSoF+pKVNmyGznHx9CiuLQWVneZLyVU5YP/iPonp3mY2b4JH?=
 =?us-ascii?Q?cWip6byqz6dr8iX2cil9juoYx7tbgSauY+965czdNL4fKk9CFipf1fv0LZmg?=
 =?us-ascii?Q?tfnpR5vLdTl6pP7e3eCgpbASU2+63dhldqUAKHpVN3loDeeFSjWOGjvw0pUe?=
 =?us-ascii?Q?50gyhvIIRm4DWXUsiT4F7LR6QgRtkiiumgJZUWXtRL00qBFWXslPdeFixO0n?=
 =?us-ascii?Q?/KFcQUPS6LydJssb4QhPaSUJG27ReYziKVoLTrNJbwoRs6z4KmbNk+Ri5b9k?=
 =?us-ascii?Q?iilBGx5YpUBINE0hZLXXHRyeuNlpmqEPBfFIQdEeI978bRPkr0djvnGokOzM?=
 =?us-ascii?Q?dx5A1A1RdWHDYG3JhEdJBc9xd+IuiTj1/iNt4KLg+xRGt+obgFA7am3KvRO9?=
 =?us-ascii?Q?H5rJrImqyDrL+2EB2uBvCGxTfF+7fWavRCqOVrfEXRMvGdtyznUaqj6FBSzJ?=
 =?us-ascii?Q?NUvmD7UlHd7XI9RtMvAMpI9nUy4s8TEh4PFZonCLDfUZ9UWshQM+9reIelR4?=
 =?us-ascii?Q?9eGZq1Dn0D3cFo8Pkfga4wZ+vaNFP3QerH5+AG+V0n2oziSi6Db3jCdHgl2Q?=
 =?us-ascii?Q?//Be/klLHf5Kg56IzhWFxgFbWbbFLO7OkIIIeGERteWEMsEPo9jcnhJxS5G0?=
 =?us-ascii?Q?AknJud84nY64t378kxHZxKcNDY+qnGB3Y84ivh/xVizLCIMAzdu6vPopkSPB?=
 =?us-ascii?Q?CegZ86NBVC3vzXpzNr9DaYCb9piGc+Ha/B5JR6PTOqy0kHB3uD2ProIdf6bS?=
 =?us-ascii?Q?+0ObwnP8Hd3YwAI3cHd0SI5GqMDBBBqSbplliblwSnD20dGcU8fkfpB4ItFf?=
 =?us-ascii?Q?HvP9pJa71A28gUB0LZ6B64JZQZfhqjwxvrqW3dkp20DmdmIuJ7BkkpGX8wXi?=
 =?us-ascii?Q?tkdPxhn64QOhEWLwyWB1pwMy+uonlgFSWLhu3ovEPAEne+bV0lef87j7uooI?=
 =?us-ascii?Q?uqM/AYYH6N0tmu3yA6VpVjaD5IiPe5nHbBV/qkYb9NF1gOQnvPyGg26rAaj/?=
 =?us-ascii?Q?LXG2EeFu26OJbJM1LlHrAvCpP9/YqenOAd0eTIW74HJ2TQnSJszFBFAyjzCt?=
 =?us-ascii?Q?/0G84mdQTvhk9pAepbpOU1qreyys9wyJPQKfqspMO+iHfr7cFor/25pJrywJ?=
 =?us-ascii?Q?Bjq8vky78/LHcmjMLKvBEhOocv6CuAh1orjO/El1k+Pf7LVrz9KpLtn8CHaf?=
 =?us-ascii?Q?yHaeWWZCvRwtsQu2roUh1/CniOAL/2fKqLWY/g4MZXONZ16zDoSsLtK3QojG?=
 =?us-ascii?Q?BMpBnADGAN+Buz44kPUWeXvnyEc3EbfJIGqKEwn3l902frN0qwh0lsp86gbn?=
 =?us-ascii?Q?T/NlkZzWdkFnsI8N0bvN/qsQJiJpMe+bj/qjibI0voN962KVNH7pNEHfBSQ6?=
 =?us-ascii?Q?fkb1WjBhVw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99adce60-0737-44e5-495a-08da28ee9fa1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 08:10:57.3383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HWfRF6zuGbzWqRwAPdmGYWW+/LKPXO94ZJfzEoRPyuDRqd4nwNi+apgfQxxolC0AtckSEnDhNxXugqjVFvRX/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4439

On 28.04.2022 10:06, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 28, 2022 at 08:37:58AM +0200, Jan Beulich wrote:
>> On 27.04.2022 18:12, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Apr 27, 2022 at 05:25:35PM +0200, Jan Beulich wrote:
>>>> On 27.04.2022 17:06, Roger Pau Monn=C3=A9 wrote:
>>>>> On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote:
>>>>>> On 27.04.2022 14:45, Roger Pau Monn=C3=A9 wrote:
>>>>>>> On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote:
>>>>>>>> --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c
>>>>>>>> +++ unstable/xen/arch/x86/cpu/mwait-idle.c
>>>>>>>> @@ -82,6 +82,18 @@ boolean_param("mwait-idle", opt_mwait_id
>>>>>>>> =20
>>>>>>>>  static unsigned int mwait_substates;
>>>>>>>> =20
>>>>>>>> +/*
>>>>>>>> + * Some platforms come with mutually exclusive C-states, so that =
if one is
>>>>>>>> + * enabled, the other C-states must not be used. Example: C1 and =
C1E on
>>>>>>>> + * Sapphire Rapids platform. This parameter allows for selecting =
the
>>>>>>>> + * preferred C-states among the groups of mutually exclusive C-st=
ates - the
>>>>>>>> + * selected C-states will be registered, the other C-states from =
the mutually
>>>>>>>> + * exclusive group won't be registered. If the platform has no mu=
tually
>>>>>>>> + * exclusive C-states, this parameter has no effect.
>>>>>>>> + */
>>>>>>>> +static unsigned int __ro_after_init preferred_states_mask;
>>>>>>>> +integer_param("preferred-cstates", preferred_states_mask);
>>>>>>>> +
>>>>>>>>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
>>>>>>>>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only=
 C1. */
>>>>>>>>  static unsigned int lapic_timer_reliable_states =3D (1 << 1);
>>>>>>>> @@ -96,6 +108,7 @@ struct idle_cpu {
>>>>>>>>  	unsigned long auto_demotion_disable_flags;
>>>>>>>>  	bool byt_auto_demotion_disable_flag;
>>>>>>>>  	bool disable_promotion_to_c1e;
>>>>>>>> +	bool enable_promotion_to_c1e;
>>>>>>>
>>>>>>> I'm confused by those fields, shouldn't we just have:
>>>>>>> promotion_to_c1e =3D true |=C2=A0false?
>>>>>>>
>>>>>>> As one field is the negation of the other:
>>>>>>> enable_promotion_to_c1e =3D !disable_promotion_to_c1e
>>>>>>>
>>>>>>> I know this is code from Linux, but would like to understand why tw=
o
>>>>>>> fields are needed.
>>>>>>
>>>>>> This really is a tristate; Linux is now changing their global variab=
le
>>>>>> to an enum, but we don't have an equivalent of that global variable.
>>>>>
>>>>> So it would be: leave default, disable C1E promotion, enable C1E
>>>>> promotion.
>>>>>
>>>>> And Linux is leaving the {disable,enable}_promotion_to_c1e in
>>>>> idle_cpu?
>>>>
>>>> Iirc they only have disable_promotion_to_c1e there (as a struct field)
>>>> and keep it, but they convert the similarly named file-scope variable
>>>> to a tristate.
>>>>
>>>>> I guess there's not much we can do unless we want to diverge from
>>>>> upstream.
>>>>
>>>> We've diverged some from Linux here already - as said, for example we
>>>> don't have their file-scope variable. I could convert our struct field
>>>> to an enum, but that would be larger code churn for (I think) little
>>>> gain.
>>>
>>> Hm, OK, could gaining the file scope variable would make sense in order
>>> to reduce divergences?  Or are the other roadblocks there?
>>
>> I don't recall. It might have originated from a change I decided to not
>> port over, or I might have dropped it while porting. To be honest I'm
>> not keen on putting time into researching this, the more that I would
>> generally try to avoid static variables.
>>
>> What I would be willing to put time in is making a more user friendly
>> command line option, but as said - I can't think of any good alternative
>> (except perhaps "preferred-cstates=3Dc1e" or "cstates=3Dpreferred:c1e", =
with
>> internal translation of the strings into a bit mask, as long as (a) you
>> would think that's an improvement and (b) the further divergence from
>> Linux is not deemed a problem).
>=20
> I think (b) won't be a problem as long as internally the user option
> is translated into a bitmask.
>=20
> Regarding (a) I do think it would be helpful to express this in a more
> user friendly way, I'm not sure whether it would make sense to keep
> Linux format also for compatibility reasons if users already have a
> bitmask and want to use the same parameter for Xen and Linux, ie:
>=20
> preferred-cstates =3D <string of c1e,c1,...> |=C2=A0<integer bitmask>

Yes, I would have been planning to accept both (but probably reject
mixing of both).

> What I think we should fix is the naming of the two booleans:
>=20
> bool disable_promotion_to_c1e;
> bool enable_promotion_to_c1e;
>=20
> I would rather translated this into an enum, as right now it's
> confusing IMO.

Okay, I can certainly do that. The more that I did consider doing
so already, breaking ties simply based on the "less code churn"
argument.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:19:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:19:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316153.534927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzNG-0003S2-1O; Thu, 28 Apr 2022 08:19:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316153.534927; Thu, 28 Apr 2022 08:19:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzNF-0003RG-T0; Thu, 28 Apr 2022 08:19:41 +0000
Received: by outflank-mailman (input) for mailman id 316153;
 Thu, 28 Apr 2022 08:14:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SwrA=VG=arm.com=suzuki.poulose@srs-se1.protection.inumbo.net>)
 id 1njzIA-0003Kw-Hq
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:14:26 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 36ff62bc-c6cb-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:14:24 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAD1D13D5;
 Thu, 28 Apr 2022 01:14:23 -0700 (PDT)
Received: from [10.57.12.231] (unknown [10.57.12.231])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 801DE3F774;
 Thu, 28 Apr 2022 01:14:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36ff62bc-c6cb-11ec-8fc3-03012f2f19d4
Message-ID: <7956ab00-66b6-bd89-dcc0-f10cf2741e4d@arm.com>
Date: Thu, 28 Apr 2022 09:14:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH 20/30] panic: Add the panic informational notifier list
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Catalin Marinas <catalin.marinas@arm.com>,
 Florian Fainelli <f.fainelli@gmail.com>,
 Frederic Weisbecker <frederic@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Hari Bathini <hbathini@linux.ibm.com>,
 Joel Fernandes <joel@joelfernandes.org>,
 Jonathan Hunter <jonathanh@nvidia.com>, Josh Triplett
 <josh@joshtriplett.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
 Leo Yan <leo.yan@linaro.org>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Michael Ellerman <mpe@ellerman.id.au>, Mike Leach <mike.leach@linaro.org>,
 Mikko Perttunen <mperttunen@nvidia.com>,
 Neeraj Upadhyay <quic_neeraju@quicinc.com>,
 Nicholas Piggin <npiggin@gmail.com>, Paul Mackerras <paulus@samba.org>,
 Thierry Reding <thierry.reding@gmail.com>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-21-gpiccoli@igalia.com>
From: Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <20220427224924.592546-21-gpiccoli@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 27/04/2022 23:49, Guilherme G. Piccoli wrote:
> The goal of this new panic notifier is to allow its users to
> register callbacks to run earlier in the panic path than they
> currently do. This aims at informational mechanisms, like dumping
> kernel offsets and showing device error data (in case it's simple
> registers reading, for example) as well as mechanisms to disable
> log flooding (like hung_task detector / RCU warnings) and the
> tracing dump_on_oops (when enabled).
> 
> Any (non-invasive) information that should be provided before
> kmsg_dump() as well as log flooding preventing code should fit
> here, as long it offers relatively low risk for kdump.
> 
> For now, the patch is almost a no-op, although it changes a bit
> the ordering in which some panic notifiers are executed - specially
> affected by this are the notifiers responsible for disabling the
> hung_task detector / RCU warnings, which now run first. In a
> subsequent patch, the panic path will be refactored, then the
> panic informational notifiers will effectively run earlier,
> before ksmg_dump() (and usually before kdump as well).
> 
> We also defer documenting it all properly in the subsequent
> refactor patch. Finally, while at it, we removed some useless
> header inclusions too.
> 
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Frederic Weisbecker <frederic@kernel.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Hari Bathini <hbathini@linux.ibm.com>
> Cc: Joel Fernandes <joel@joelfernandes.org>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: Neeraj Upadhyay <quic_neeraju@quicinc.com>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>   arch/arm64/kernel/setup.c                         | 2 +-
>   arch/mips/kernel/relocate.c                       | 2 +-
>   arch/powerpc/kernel/setup-common.c                | 2 +-
>   arch/x86/kernel/setup.c                           | 2 +-
>   drivers/bus/brcmstb_gisb.c                        | 2 +-
>   drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 ++--
>   drivers/soc/tegra/ari-tegra186.c                  | 3 ++-
>   include/linux/panic_notifier.h                    | 1 +
>   kernel/hung_task.c                                | 3 ++-
>   kernel/panic.c                                    | 4 ++++
>   kernel/rcu/tree.c                                 | 1 -
>   kernel/rcu/tree_stall.h                           | 3 ++-
>   kernel/trace/trace.c                              | 2 +-
>   13 files changed, 19 insertions(+), 12 deletions(-)
> 

...

> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> index 1874df7c6a73..7b1012454525 100644
> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> @@ -535,7 +535,7 @@ static int debug_func_init(void)
>   			    &debug_func_knob_fops);
>   
>   	/* Register function to be called for panic */
> -	ret = atomic_notifier_chain_register(&panic_notifier_list,
> +	ret = atomic_notifier_chain_register(&panic_info_list,
>   					     &debug_notifier);
>   	if (ret) {
>   		pr_err("%s: unable to register notifier: %d\n",
> @@ -552,7 +552,7 @@ static int debug_func_init(void)
>   
>   static void debug_func_exit(void)
>   {
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> +	atomic_notifier_chain_unregister(&panic_info_list,
>   					 &debug_notifier);
>   	debugfs_remove_recursive(debug_debugfs_dir);
>   }

Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:19:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:19:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316145.534922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzNF-0003PO-NI; Thu, 28 Apr 2022 08:19:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316145.534922; Thu, 28 Apr 2022 08:19:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzNF-0003PH-KN; Thu, 28 Apr 2022 08:19:41 +0000
Received: by outflank-mailman (input) for mailman id 316145;
 Thu, 28 Apr 2022 08:11:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SwrA=VG=arm.com=suzuki.poulose@srs-se1.protection.inumbo.net>)
 id 1njzFD-00033Q-GJ
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:11:23 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id ca03ed08-c6ca-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:11:21 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B87FED1;
 Thu, 28 Apr 2022 01:11:21 -0700 (PDT)
Received: from [10.57.12.231] (unknown [10.57.12.231])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E93F3F774;
 Thu, 28 Apr 2022 01:11:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca03ed08-c6ca-11ec-a405-831a346695d4
Message-ID: <3cafe4fd-8a0b-2633-44a3-2995abd6c38c@arm.com>
Date: Thu, 28 Apr 2022 09:11:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH 09/30] coresight: cpu-debug: Replace mutex with
 mutex_trylock on panic notifier
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org, Leo Yan <leo.yan@linaro.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Mike Leach <mike.leach@linaro.org>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-10-gpiccoli@igalia.com>
From: Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <20220427224924.592546-10-gpiccoli@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Guilherme,

On 27/04/2022 23:49, Guilherme G. Piccoli wrote:
> The panic notifier infrastructure executes registered callbacks when
> a panic event happens - such callbacks are executed in atomic context,
> with interrupts and preemption disabled in the running CPU and all other
> CPUs disabled. That said, mutexes in such context are not a good idea.
> 
> This patch replaces a regular mutex with a mutex_trylock safer approach;
> given the nature of the mutex used in the driver, it should be pretty
> uncommon being unable to acquire such mutex in the panic path, hence
> no functional change should be observed (and if it is, that would be
> likely a deadlock with the regular mutex).
> 
> Fixes: 2227b7c74634 ("coresight: add support for CPU debug module")
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>

How would you like to proceed with queuing this ? I am happy
either way. In case you plan to push this as part of this
series (I don't see any potential conflicts) :

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316174.534986 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVC-0006Lb-6Q; Thu, 28 Apr 2022 08:27:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316174.534986; Thu, 28 Apr 2022 08:27:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVB-0006HV-Pu; Thu, 28 Apr 2022 08:27:53 +0000
Received: by outflank-mailman (input) for mailman id 316174;
 Thu, 28 Apr 2022 08:27:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzV9-0005SM-Dw
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:51 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16b2dfeb-c6cd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:27:49 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3AA1321873;
 Thu, 28 Apr 2022 08:27:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0188D13491;
 Thu, 28 Apr 2022 08:27:48 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id EMGoOgRQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16b2dfeb-c6cd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tOhV6YQDouFKSF4kDrscgmAnoCYSHdFmpTsct9Kqzek=;
	b=h6hwiM9FHRpDwvATx8ZJwxdJgF4aQmHGQmkHLtLJrYUY3ATb3CYZi1lh3cJIcZpfglwM82
	FnnkX9Ux6gOptve9MuodDmBZFvSvzzfaQd9rtWom4I0jgM9qfoQTzXUk9eOHuFfhhQ3J0o
	Hsizgzz4vnGMgdDhowBzhKzpG3NUYfc=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: [PATCH v2 05/19] xen/drm: switch xen_drm_front to use INVALID_GRANT_REF
Date: Thu, 28 Apr 2022 10:27:29 +0200
Message-Id: <20220428082743.16593-6-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/gpu/drm/xen/xen_drm_front.h         | 9 ---------
 drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 4 ++--
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
index cefafe859aba..a987c78abe41 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.h
+++ b/drivers/gpu/drm/xen/xen_drm_front.h
@@ -80,15 +80,6 @@ struct drm_pending_vblank_event;
 /* timeout in ms to wait for backend to respond */
 #define XEN_DRM_FRONT_WAIT_BACK_MS	3000
 
-#ifndef GRANT_INVALID_REF
-/*
- * Note on usage of grant reference 0 as invalid grant reference:
- * grant reference 0 is valid, but never exposed to a PV driver,
- * because of the fact it is already in use/reserved by the PV console.
- */
-#define GRANT_INVALID_REF	0
-#endif
-
 struct xen_drm_front_info {
 	struct xenbus_device *xb_dev;
 	struct xen_drm_front_drm_info *drm_info;
diff --git a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
index 08b526eeec16..4006568b9e32 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
@@ -147,7 +147,7 @@ static void evtchnl_free(struct xen_drm_front_info *front_info,
 		xenbus_free_evtchn(front_info->xb_dev, evtchnl->port);
 
 	/* end access and free the page */
-	if (evtchnl->gref != GRANT_INVALID_REF)
+	if (evtchnl->gref != INVALID_GRANT_REF)
 		gnttab_end_foreign_access(evtchnl->gref, page);
 
 	memset(evtchnl, 0, sizeof(*evtchnl));
@@ -168,7 +168,7 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index,
 	evtchnl->index = index;
 	evtchnl->front_info = front_info;
 	evtchnl->state = EVTCHNL_STATE_DISCONNECTED;
-	evtchnl->gref = GRANT_INVALID_REF;
+	evtchnl->gref = INVALID_GRANT_REF;
 
 	page = get_zeroed_page(GFP_NOIO | __GFP_HIGH);
 	if (!page) {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316169.534944 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzV8-0005So-Pl; Thu, 28 Apr 2022 08:27:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316169.534944; Thu, 28 Apr 2022 08:27:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzV8-0005Sg-Mk; Thu, 28 Apr 2022 08:27:50 +0000
Received: by outflank-mailman (input) for mailman id 316169;
 Thu, 28 Apr 2022 08:27:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzV7-0005SL-Id
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:49 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1600e5e2-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:48 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id CDEBA2186F;
 Thu, 28 Apr 2022 08:27:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EF6F413491;
 Thu, 28 Apr 2022 08:27:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ApxEOAJQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1600e5e2-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134467; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=uHWa92vFc0VKwXbjUTC1XMh188o1HlT0uQD6qb0vP48=;
	b=ptsNFLPN4AOJ9HLpo2aUFC1C35GqsbNQmwQwd/cc0fkX9rwV4HLRJVj0WiG+95oGxsBYyw
	5reFV928fpI3wng15ZZWSf2aMaxIkut0k3dO9MjlmOJ7aHFGqGsaFIzVlip6U6aXsYeVwo
	KQjHMdo/P4x1VKzfCdDMkbEiS1Pfu8Q=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-integrity@vger.kernel.org,
	linux-pci@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org,
	Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH v2 00/19] xen: simplify frontend side ring setup
Date: Thu, 28 Apr 2022 10:27:24 +0200
Message-Id: <20220428082743.16593-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Many Xen PV frontends share similar code for setting up a ring page
(allocating and granting access for the backend) and for tearing it
down.

Create new service functions doing all needed steps in one go.

This requires all frontends to use a common value for an invalid
grant reference in order to make the functions idempotent.

Changes in V2:
- new patch 9 and related changes in patches 10-18

Juergen Gross (19):
  xen/blkfront: switch blkfront to use INVALID_GRANT_REF
  xen/netfront: switch netfront to use INVALID_GRANT_REF
  xen/scsifront: remove unused GRANT_INVALID_REF definition
  xen/usb: switch xen-hcd to use INVALID_GRANT_REF
  xen/drm: switch xen_drm_front to use INVALID_GRANT_REF
  xen/sound: switch xen_snd_front to use INVALID_GRANT_REF
  xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF
  xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF
  xen: update ring.h
  xen/xenbus: add xenbus_setup_ring() service function
  xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring()
  xen/xenbus: eliminate xenbus_grant_ring()

 drivers/block/xen-blkfront.c                | 57 +++++---------
 drivers/char/tpm/xen-tpmfront.c             | 18 +----
 drivers/gpu/drm/xen/xen_drm_front.h         |  9 ---
 drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 +++--------
 drivers/net/xen-netfront.c                  | 85 +++++++--------------
 drivers/pci/xen-pcifront.c                  | 19 +----
 drivers/scsi/xen-scsifront.c                | 31 ++------
 drivers/usb/host/xen-hcd.c                  | 65 ++++------------
 drivers/xen/gntdev-dmabuf.c                 | 13 +---
 drivers/xen/xen-front-pgdir-shbuf.c         | 17 +----
 drivers/xen/xenbus/xenbus_client.c          | 82 +++++++++++++++-----
 include/xen/interface/io/ring.h             | 19 +++--
 include/xen/xenbus.h                        |  4 +-
 sound/xen/xen_snd_front_evtchnl.c           | 44 +++--------
 sound/xen/xen_snd_front_evtchnl.h           |  9 ---
 15 files changed, 179 insertions(+), 336 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316173.534978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVB-0006Ed-IX; Thu, 28 Apr 2022 08:27:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316173.534978; Thu, 28 Apr 2022 08:27:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVB-0006AS-97; Thu, 28 Apr 2022 08:27:53 +0000
Received: by outflank-mailman (input) for mailman id 316173;
 Thu, 28 Apr 2022 08:27:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzV9-0005SL-AA
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:51 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 169b9424-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:49 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id ECFC21F899;
 Thu, 28 Apr 2022 08:27:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BDE1313491;
 Thu, 28 Apr 2022 08:27:48 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OFX/LARQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 169b9424-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7TSQqudTcVLuLhQNOY3wWT3BirutbrjVm/F1DYUL/Jc=;
	b=bXQFN0N+BgI1kmZyCngmvHVCA1I+1WiKiyl4AoNXMJlXEBLY1bscsQfLjv+ocbOnCYApPF
	Bj/5Cq72navU9MxLn+AfqK7WV3/FX3gM1bLJgJ28Gl0hLTxsS7SNqZ8qKkurAL6KoXX2bH
	6ofYmp6Du47LiNOIHekEpuVElAnDZSs=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v2 04/19] xen/usb: switch xen-hcd to use INVALID_GRANT_REF
Date: Thu, 28 Apr 2022 10:27:28 +0200
Message-Id: <20220428082743.16593-5-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/usb/host/xen-hcd.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c
index 3e487baf8422..9cbc7c2dab02 100644
--- a/drivers/usb/host/xen-hcd.c
+++ b/drivers/usb/host/xen-hcd.c
@@ -87,8 +87,6 @@ struct xenhcd_info {
 	bool error;
 };
 
-#define GRANT_INVALID_REF 0
-
 #define XENHCD_RING_JIFFIES (HZ/200)
 #define XENHCD_SCAN_JIFFIES 1
 
@@ -1100,17 +1098,17 @@ static void xenhcd_destroy_rings(struct xenhcd_info *info)
 		unbind_from_irqhandler(info->irq, info);
 	info->irq = 0;
 
-	if (info->urb_ring_ref != GRANT_INVALID_REF) {
+	if (info->urb_ring_ref != INVALID_GRANT_REF) {
 		gnttab_end_foreign_access(info->urb_ring_ref,
 					  (unsigned long)info->urb_ring.sring);
-		info->urb_ring_ref = GRANT_INVALID_REF;
+		info->urb_ring_ref = INVALID_GRANT_REF;
 	}
 	info->urb_ring.sring = NULL;
 
-	if (info->conn_ring_ref != GRANT_INVALID_REF) {
+	if (info->conn_ring_ref != INVALID_GRANT_REF) {
 		gnttab_end_foreign_access(info->conn_ring_ref,
 					  (unsigned long)info->conn_ring.sring);
-		info->conn_ring_ref = GRANT_INVALID_REF;
+		info->conn_ring_ref = INVALID_GRANT_REF;
 	}
 	info->conn_ring.sring = NULL;
 }
@@ -1123,8 +1121,8 @@ static int xenhcd_setup_rings(struct xenbus_device *dev,
 	grant_ref_t gref;
 	int err;
 
-	info->urb_ring_ref = GRANT_INVALID_REF;
-	info->conn_ring_ref = GRANT_INVALID_REF;
+	info->urb_ring_ref = INVALID_GRANT_REF;
+	info->conn_ring_ref = INVALID_GRANT_REF;
 
 	urb_sring = (struct xenusb_urb_sring *)get_zeroed_page(
 							GFP_NOIO | __GFP_HIGH);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316172.534970 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVA-00061L-Q3; Thu, 28 Apr 2022 08:27:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316172.534970; Thu, 28 Apr 2022 08:27:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVA-0005zo-HL; Thu, 28 Apr 2022 08:27:52 +0000
Received: by outflank-mailman (input) for mailman id 316172;
 Thu, 28 Apr 2022 08:27:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzV8-0005SM-Dv
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:50 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1632c798-c6cd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:27:48 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6132A21871;
 Thu, 28 Apr 2022 08:27:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1BC7913491;
 Thu, 28 Apr 2022 08:27:48 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0KaDBQRQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1632c798-c6cd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1+sLUcbyL72u2uT21oB5tsWX/EFozEKqCEXKzXzCiFA=;
	b=UnsC/U6cRAnvBqbXD65jZsvqsn6XqCQFhpOxRtYjKbTiLSNREIe8/ihMdRY93qVR4qiTmB
	rCJNq/A/60c+PxQpAn3nr/EmT1y0umP0H3kUFtXu8lzWdFOifhRD45y1sS0Z6sfcuDpnyr
	bbK/7Lz+zzWkM7Ld2KfJdNfwt4J5+eo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH v2 02/19] xen/netfront: switch netfront to use INVALID_GRANT_REF
Date: Thu, 28 Apr 2022 10:27:26 +0200
Message-Id: <20220428082743.16593-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/net/xen-netfront.c | 36 +++++++++++++++++-------------------
 1 file changed, 17 insertions(+), 19 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index e2b4a1893a13..af3d3de7d9fa 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -78,8 +78,6 @@ struct netfront_cb {
 
 #define RX_COPY_THRESHOLD 256
 
-#define GRANT_INVALID_REF	0
-
 #define NET_TX_RING_SIZE __CONST_RING_SIZE(xen_netif_tx, XEN_PAGE_SIZE)
 #define NET_RX_RING_SIZE __CONST_RING_SIZE(xen_netif_rx, XEN_PAGE_SIZE)
 
@@ -224,7 +222,7 @@ static grant_ref_t xennet_get_rx_ref(struct netfront_queue *queue,
 {
 	int i = xennet_rxidx(ri);
 	grant_ref_t ref = queue->grant_rx_ref[i];
-	queue->grant_rx_ref[i] = GRANT_INVALID_REF;
+	queue->grant_rx_ref[i] = INVALID_GRANT_REF;
 	return ref;
 }
 
@@ -432,7 +430,7 @@ static bool xennet_tx_buf_gc(struct netfront_queue *queue)
 			}
 			gnttab_release_grant_reference(
 				&queue->gref_tx_head, queue->grant_tx_ref[id]);
-			queue->grant_tx_ref[id] = GRANT_INVALID_REF;
+			queue->grant_tx_ref[id] = INVALID_GRANT_REF;
 			queue->grant_tx_page[id] = NULL;
 			add_id_to_list(&queue->tx_skb_freelist, queue->tx_link, id);
 			dev_kfree_skb_irq(skb);
@@ -1021,7 +1019,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
 		 * the backend driver. In future this should flag the bad
 		 * situation to the system controller to reboot the backend.
 		 */
-		if (ref == GRANT_INVALID_REF) {
+		if (ref == INVALID_GRANT_REF) {
 			if (net_ratelimit())
 				dev_warn(dev, "Bad rx response id %d.\n",
 					 rx->id);
@@ -1390,7 +1388,7 @@ static void xennet_release_tx_bufs(struct netfront_queue *queue)
 		gnttab_end_foreign_access(queue->grant_tx_ref[i],
 					  (unsigned long)page_address(queue->grant_tx_page[i]));
 		queue->grant_tx_page[i] = NULL;
-		queue->grant_tx_ref[i] = GRANT_INVALID_REF;
+		queue->grant_tx_ref[i] = INVALID_GRANT_REF;
 		add_id_to_list(&queue->tx_skb_freelist, queue->tx_link, i);
 		dev_kfree_skb_irq(skb);
 	}
@@ -1411,7 +1409,7 @@ static void xennet_release_rx_bufs(struct netfront_queue *queue)
 			continue;
 
 		ref = queue->grant_rx_ref[id];
-		if (ref == GRANT_INVALID_REF)
+		if (ref == INVALID_GRANT_REF)
 			continue;
 
 		page = skb_frag_page(&skb_shinfo(skb)->frags[0]);
@@ -1422,7 +1420,7 @@ static void xennet_release_rx_bufs(struct netfront_queue *queue)
 		get_page(page);
 		gnttab_end_foreign_access(ref,
 					  (unsigned long)page_address(page));
-		queue->grant_rx_ref[id] = GRANT_INVALID_REF;
+		queue->grant_rx_ref[id] = INVALID_GRANT_REF;
 
 		kfree_skb(skb);
 	}
@@ -1761,7 +1759,7 @@ static int netfront_probe(struct xenbus_device *dev,
 static void xennet_end_access(int ref, void *page)
 {
 	/* This frees the page as a side-effect */
-	if (ref != GRANT_INVALID_REF)
+	if (ref != INVALID_GRANT_REF)
 		gnttab_end_foreign_access(ref, (unsigned long)page);
 }
 
@@ -1798,8 +1796,8 @@ static void xennet_disconnect_backend(struct netfront_info *info)
 		xennet_end_access(queue->tx_ring_ref, queue->tx.sring);
 		xennet_end_access(queue->rx_ring_ref, queue->rx.sring);
 
-		queue->tx_ring_ref = GRANT_INVALID_REF;
-		queue->rx_ring_ref = GRANT_INVALID_REF;
+		queue->tx_ring_ref = INVALID_GRANT_REF;
+		queue->rx_ring_ref = INVALID_GRANT_REF;
 		queue->tx.sring = NULL;
 		queue->rx.sring = NULL;
 
@@ -1927,8 +1925,8 @@ static int setup_netfront(struct xenbus_device *dev,
 	grant_ref_t gref;
 	int err;
 
-	queue->tx_ring_ref = GRANT_INVALID_REF;
-	queue->rx_ring_ref = GRANT_INVALID_REF;
+	queue->tx_ring_ref = INVALID_GRANT_REF;
+	queue->rx_ring_ref = INVALID_GRANT_REF;
 	queue->rx.sring = NULL;
 	queue->tx.sring = NULL;
 
@@ -1978,17 +1976,17 @@ static int setup_netfront(struct xenbus_device *dev,
 	 * granted pages because backend is not accessing it at this point.
 	 */
  fail:
-	if (queue->rx_ring_ref != GRANT_INVALID_REF) {
+	if (queue->rx_ring_ref != INVALID_GRANT_REF) {
 		gnttab_end_foreign_access(queue->rx_ring_ref,
 					  (unsigned long)rxs);
-		queue->rx_ring_ref = GRANT_INVALID_REF;
+		queue->rx_ring_ref = INVALID_GRANT_REF;
 	} else {
 		free_page((unsigned long)rxs);
 	}
-	if (queue->tx_ring_ref != GRANT_INVALID_REF) {
+	if (queue->tx_ring_ref != INVALID_GRANT_REF) {
 		gnttab_end_foreign_access(queue->tx_ring_ref,
 					  (unsigned long)txs);
-		queue->tx_ring_ref = GRANT_INVALID_REF;
+		queue->tx_ring_ref = INVALID_GRANT_REF;
 	} else {
 		free_page((unsigned long)txs);
 	}
@@ -2020,7 +2018,7 @@ static int xennet_init_queue(struct netfront_queue *queue)
 	queue->tx_pend_queue = TX_LINK_NONE;
 	for (i = 0; i < NET_TX_RING_SIZE; i++) {
 		queue->tx_link[i] = i + 1;
-		queue->grant_tx_ref[i] = GRANT_INVALID_REF;
+		queue->grant_tx_ref[i] = INVALID_GRANT_REF;
 		queue->grant_tx_page[i] = NULL;
 	}
 	queue->tx_link[NET_TX_RING_SIZE - 1] = TX_LINK_NONE;
@@ -2028,7 +2026,7 @@ static int xennet_init_queue(struct netfront_queue *queue)
 	/* Clear out rx_skbs */
 	for (i = 0; i < NET_RX_RING_SIZE; i++) {
 		queue->rx_skbs[i] = NULL;
-		queue->grant_rx_ref[i] = GRANT_INVALID_REF;
+		queue->grant_rx_ref[i] = INVALID_GRANT_REF;
 	}
 
 	/* A grant for every tx ring slot */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316170.534948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzV9-0005Vo-2M; Thu, 28 Apr 2022 08:27:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316170.534948; Thu, 28 Apr 2022 08:27:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzV8-0005Uw-UV; Thu, 28 Apr 2022 08:27:50 +0000
Received: by outflank-mailman (input) for mailman id 316170;
 Thu, 28 Apr 2022 08:27:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzV7-0005SM-LA
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:49 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16110460-c6cd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:27:48 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 130A721870;
 Thu, 28 Apr 2022 08:27:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C8D3313AF9;
 Thu, 28 Apr 2022 08:27:47 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sECFLwNQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16110460-c6cd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8T6Z7jV+2E1LG0Lx6kFTGECOTx+ZZjBB+fMJq4VZyPo=;
	b=XZftGB6VP1qLXSlx4vJcQgEjy/RezPi5BrmURePrVfY6UngIHaNNnPVV044Jx1K2+Oqe3O
	Wh+Mc+ZK5OY1s62YkenGBJ01tTqaxK8XfJ9xRaxGeX13/aXHyh6u2s6U0EhwawiTbqYlUx
	rBrskyscjbFRnyRxb7/LrYMicon72ec=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: [PATCH v2 01/19] xen/blkfront: switch blkfront to use INVALID_GRANT_REF
Date: Thu, 28 Apr 2022 10:27:25 +0200
Message-Id: <20220428082743.16593-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/block/xen-blkfront.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 003056d4f7f5..7f35e30e626a 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -229,8 +229,6 @@ static unsigned int nr_minors;
 static unsigned long *minors;
 static DEFINE_SPINLOCK(minor_lock);
 
-#define GRANT_INVALID_REF	0
-
 #define PARTS_PER_DISK		16
 #define PARTS_PER_EXT_DISK      256
 
@@ -321,7 +319,7 @@ static int fill_grant_buffer(struct blkfront_ring_info *rinfo, int num)
 			gnt_list_entry->page = granted_page;
 		}
 
-		gnt_list_entry->gref = GRANT_INVALID_REF;
+		gnt_list_entry->gref = INVALID_GRANT_REF;
 		list_add(&gnt_list_entry->node, &rinfo->grants);
 		i++;
 	}
@@ -350,7 +348,7 @@ static struct grant *get_free_grant(struct blkfront_ring_info *rinfo)
 					  node);
 	list_del(&gnt_list_entry->node);
 
-	if (gnt_list_entry->gref != GRANT_INVALID_REF)
+	if (gnt_list_entry->gref != INVALID_GRANT_REF)
 		rinfo->persistent_gnts_c--;
 
 	return gnt_list_entry;
@@ -372,7 +370,7 @@ static struct grant *get_grant(grant_ref_t *gref_head,
 	struct grant *gnt_list_entry = get_free_grant(rinfo);
 	struct blkfront_info *info = rinfo->dev_info;
 
-	if (gnt_list_entry->gref != GRANT_INVALID_REF)
+	if (gnt_list_entry->gref != INVALID_GRANT_REF)
 		return gnt_list_entry;
 
 	/* Assign a gref to this page */
@@ -396,7 +394,7 @@ static struct grant *get_indirect_grant(grant_ref_t *gref_head,
 	struct grant *gnt_list_entry = get_free_grant(rinfo);
 	struct blkfront_info *info = rinfo->dev_info;
 
-	if (gnt_list_entry->gref != GRANT_INVALID_REF)
+	if (gnt_list_entry->gref != INVALID_GRANT_REF)
 		return gnt_list_entry;
 
 	/* Assign a gref to this page */
@@ -1221,7 +1219,7 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
 		list_for_each_entry_safe(persistent_gnt, n,
 					 &rinfo->grants, node) {
 			list_del(&persistent_gnt->node);
-			if (persistent_gnt->gref != GRANT_INVALID_REF) {
+			if (persistent_gnt->gref != INVALID_GRANT_REF) {
 				gnttab_end_foreign_access(persistent_gnt->gref,
 							  0UL);
 				rinfo->persistent_gnts_c--;
@@ -1283,9 +1281,9 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
 
 	/* Free resources associated with old device channel. */
 	for (i = 0; i < info->nr_ring_pages; i++) {
-		if (rinfo->ring_ref[i] != GRANT_INVALID_REF) {
+		if (rinfo->ring_ref[i] != INVALID_GRANT_REF) {
 			gnttab_end_foreign_access(rinfo->ring_ref[i], 0);
-			rinfo->ring_ref[i] = GRANT_INVALID_REF;
+			rinfo->ring_ref[i] = INVALID_GRANT_REF;
 		}
 	}
 	free_pages_exact(rinfo->ring.sring,
@@ -1475,7 +1473,7 @@ static int blkif_completion(unsigned long *id,
 			 * to the tail of the list, so it will not be picked
 			 * again unless we run out of persistent grants.
 			 */
-			s->grants_used[i]->gref = GRANT_INVALID_REF;
+			s->grants_used[i]->gref = INVALID_GRANT_REF;
 			list_add_tail(&s->grants_used[i]->node, &rinfo->grants);
 		}
 	}
@@ -1500,7 +1498,7 @@ static int blkif_completion(unsigned long *id,
 					indirect_page = s->indirect_grants[i]->page;
 					list_add(&indirect_page->lru, &rinfo->indirect_pages);
 				}
-				s->indirect_grants[i]->gref = GRANT_INVALID_REF;
+				s->indirect_grants[i]->gref = INVALID_GRANT_REF;
 				list_add_tail(&s->indirect_grants[i]->node, &rinfo->grants);
 			}
 		}
@@ -1687,7 +1685,7 @@ static int setup_blkring(struct xenbus_device *dev,
 	grant_ref_t gref[XENBUS_MAX_RING_GRANTS];
 
 	for (i = 0; i < info->nr_ring_pages; i++)
-		rinfo->ring_ref[i] = GRANT_INVALID_REF;
+		rinfo->ring_ref[i] = INVALID_GRANT_REF;
 
 	sring = alloc_pages_exact(ring_size, GFP_NOIO);
 	if (!sring) {
@@ -2544,13 +2542,13 @@ static void purge_persistent_grants(struct blkfront_info *info)
 
 		list_for_each_entry_safe(gnt_list_entry, tmp, &rinfo->grants,
 					 node) {
-			if (gnt_list_entry->gref == GRANT_INVALID_REF ||
+			if (gnt_list_entry->gref == INVALID_GRANT_REF ||
 			    !gnttab_try_end_foreign_access(gnt_list_entry->gref))
 				continue;
 
 			list_del(&gnt_list_entry->node);
 			rinfo->persistent_gnts_c--;
-			gnt_list_entry->gref = GRANT_INVALID_REF;
+			gnt_list_entry->gref = INVALID_GRANT_REF;
 			list_add_tail(&gnt_list_entry->node, &grants);
 		}
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316171.534966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVA-0005x9-By; Thu, 28 Apr 2022 08:27:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316171.534966; Thu, 28 Apr 2022 08:27:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVA-0005wk-7r; Thu, 28 Apr 2022 08:27:52 +0000
Received: by outflank-mailman (input) for mailman id 316171;
 Thu, 28 Apr 2022 08:27:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzV8-0005SL-9t
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:50 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1664d82d-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:49 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B68971F88B;
 Thu, 28 Apr 2022 08:27:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6A6DD13491;
 Thu, 28 Apr 2022 08:27:48 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mPaeGARQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1664d82d-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JgTSDzyFH4odL3+op3mwwaz3GF9HZ1rzMHlaax9H0jQ=;
	b=XJSEFs+iNetHUnKTGEZp1HsPSzQlTRyaGB3P+gTZL34FW8MH4Kl98mOgVnhzQzPxlxbka0
	5HWsPhR50wFcq9np7hRBIg2ejBAmi8i+QnKhcg4+gI+dWtaHjXhpi2cubxv4IcSVVPJlx2
	B/2ksRkjk3lAWibFGeQNovVIqq/4Ixc=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v2 03/19] xen/scsifront: remove unused GRANT_INVALID_REF definition
Date: Thu, 28 Apr 2022 10:27:27 +0200
Message-Id: <20220428082743.16593-4-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

GRANT_INVALID_REF isn't used in scsifront, so remove it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/scsi/xen-scsifront.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 56173beecbc6..4c55e479fc36 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -58,9 +58,6 @@
 
 #include <asm/xen/hypervisor.h>
 
-
-#define GRANT_INVALID_REF	0
-
 #define VSCSIFRONT_OP_ADD_LUN	1
 #define VSCSIFRONT_OP_DEL_LUN	2
 #define VSCSIFRONT_OP_READD_LUN	3
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316175.534995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVD-0006XV-20; Thu, 28 Apr 2022 08:27:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316175.534995; Thu, 28 Apr 2022 08:27:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVC-0006TJ-FI; Thu, 28 Apr 2022 08:27:54 +0000
Received: by outflank-mailman (input) for mailman id 316175;
 Thu, 28 Apr 2022 08:27:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVA-0005SL-AB
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:52 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 16dea835-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:49 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 804C41F8A8;
 Thu, 28 Apr 2022 08:27:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4287913491;
 Thu, 28 Apr 2022 08:27:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sDPlDgVQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16dea835-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nqfEAJYikez5yuRaJWQFVEnr7bTvqklH6kJ7XEyZeH4=;
	b=TYPIqdG6C2kNSXwfoxobkb0T7Qrlkecz89DW0NUUSRJk8G1Cl1McWKfb63f8rCvjK2Z1w9
	hltCqgILrPkBWZf7D6lZQrTVsQ9bYGNjEQQXo2D58+bj+Zbr/uJommfLuFr/ZVITaGpYKs
	3TdHSODcKkMVn6eBxvw3c05nJoauKJs=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH v2 06/19] xen/sound: switch xen_snd_front to use INVALID_GRANT_REF
Date: Thu, 28 Apr 2022 10:27:30 +0200
Message-Id: <20220428082743.16593-7-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 sound/xen/xen_snd_front_evtchnl.c | 4 ++--
 sound/xen/xen_snd_front_evtchnl.h | 9 ---------
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
index ecbc294fc59a..3e21369c8216 100644
--- a/sound/xen/xen_snd_front_evtchnl.c
+++ b/sound/xen/xen_snd_front_evtchnl.c
@@ -167,7 +167,7 @@ static void evtchnl_free(struct xen_snd_front_info *front_info,
 		xenbus_free_evtchn(front_info->xb_dev, channel->port);
 
 	/* End access and free the page. */
-	if (channel->gref != GRANT_INVALID_REF)
+	if (channel->gref != INVALID_GRANT_REF)
 		gnttab_end_foreign_access(channel->gref, page);
 	else
 		free_page(page);
@@ -207,7 +207,7 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 	channel->index = index;
 	channel->front_info = front_info;
 	channel->state = EVTCHNL_STATE_DISCONNECTED;
-	channel->gref = GRANT_INVALID_REF;
+	channel->gref = INVALID_GRANT_REF;
 	page = get_zeroed_page(GFP_KERNEL);
 	if (!page) {
 		ret = -ENOMEM;
diff --git a/sound/xen/xen_snd_front_evtchnl.h b/sound/xen/xen_snd_front_evtchnl.h
index cbe51fd1ec15..3675fba70564 100644
--- a/sound/xen/xen_snd_front_evtchnl.h
+++ b/sound/xen/xen_snd_front_evtchnl.h
@@ -15,15 +15,6 @@
 
 struct xen_snd_front_info;
 
-#ifndef GRANT_INVALID_REF
-/*
- * FIXME: usage of grant reference 0 as invalid grant reference:
- * grant reference 0 is valid, but never exposed to a PV driver,
- * because of the fact it is already in use/reserved by the PV console.
- */
-#define GRANT_INVALID_REF	0
-#endif
-
 /* Timeout in ms to wait for backend to respond. */
 #define VSND_WAIT_BACK_MS	3000
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316176.535002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVD-0006fp-T9; Thu, 28 Apr 2022 08:27:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316176.535002; Thu, 28 Apr 2022 08:27:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVD-0006eF-8r; Thu, 28 Apr 2022 08:27:55 +0000
Received: by outflank-mailman (input) for mailman id 316176;
 Thu, 28 Apr 2022 08:27:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVA-0005SM-EB
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:52 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 172293ae-c6cd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:27:50 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EE17421874;
 Thu, 28 Apr 2022 08:27:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BFF4713491;
 Thu, 28 Apr 2022 08:27:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mGl2LQVQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 172293ae-c6cd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=27ryrQ9/V3A+L0L1cMkzg+znNHks8+NEi42Ak1eCxTQ=;
	b=OuTXoWvhfYYiK6CpG+Xj3URKFgDVAutPiSkezySiwcZy5fZN/9LUWyECUUdJYzu/QyFtIK
	IlWEbdsvMavVm0S7cE2dMet6r3Ofm33wYWqZxXMaKMQ+q2ofTy2NzLxMYjglo8jdcdMQIn
	Gfl9iKNb3w0tnJ62vhff94o8tpqp+WM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF
Date: Thu, 28 Apr 2022 10:27:32 +0200
Message-Id: <20220428082743.16593-9-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/xen-front-pgdir-shbuf.c | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/drivers/xen/xen-front-pgdir-shbuf.c b/drivers/xen/xen-front-pgdir-shbuf.c
index a959dee21134..fa2921d4fbfc 100644
--- a/drivers/xen/xen-front-pgdir-shbuf.c
+++ b/drivers/xen/xen-front-pgdir-shbuf.c
@@ -21,15 +21,6 @@
 
 #include <xen/xen-front-pgdir-shbuf.h>
 
-#ifndef GRANT_INVALID_REF
-/*
- * FIXME: usage of grant reference 0 as invalid grant reference:
- * grant reference 0 is valid, but never exposed to a PV driver,
- * because of the fact it is already in use/reserved by the PV console.
- */
-#define GRANT_INVALID_REF	0
-#endif
-
 /**
  * This structure represents the structure of a shared page
  * that contains grant references to the pages of the shared
@@ -83,7 +74,7 @@ grant_ref_t
 xen_front_pgdir_shbuf_get_dir_start(struct xen_front_pgdir_shbuf *buf)
 {
 	if (!buf->grefs)
-		return GRANT_INVALID_REF;
+		return INVALID_GRANT_REF;
 
 	return buf->grefs[0];
 }
@@ -142,7 +133,7 @@ void xen_front_pgdir_shbuf_free(struct xen_front_pgdir_shbuf *buf)
 		int i;
 
 		for (i = 0; i < buf->num_grefs; i++)
-			if (buf->grefs[i] != GRANT_INVALID_REF)
+			if (buf->grefs[i] != INVALID_GRANT_REF)
 				gnttab_end_foreign_access(buf->grefs[i], 0UL);
 	}
 	kfree(buf->grefs);
@@ -355,7 +346,7 @@ static void backend_fill_page_dir(struct xen_front_pgdir_shbuf *buf)
 	}
 	/* Last page must say there is no more pages. */
 	page_dir = (struct xen_page_directory *)ptr;
-	page_dir->gref_dir_next_page = GRANT_INVALID_REF;
+	page_dir->gref_dir_next_page = INVALID_GRANT_REF;
 }
 
 /**
@@ -384,7 +375,7 @@ static void guest_fill_page_dir(struct xen_front_pgdir_shbuf *buf)
 
 		if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) {
 			to_copy = grefs_left;
-			page_dir->gref_dir_next_page = GRANT_INVALID_REF;
+			page_dir->gref_dir_next_page = INVALID_GRANT_REF;
 		} else {
 			to_copy = XEN_NUM_GREFS_PER_PAGE;
 			page_dir->gref_dir_next_page = buf->grefs[i + 1];
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316177.535011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVE-0006wj-V2; Thu, 28 Apr 2022 08:27:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316177.535011; Thu, 28 Apr 2022 08:27:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVE-0006q5-7F; Thu, 28 Apr 2022 08:27:56 +0000
Received: by outflank-mailman (input) for mailman id 316177;
 Thu, 28 Apr 2022 08:27:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVB-0005SL-AT
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:53 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1708cee3-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:50 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B78F51F88A;
 Thu, 28 Apr 2022 08:27:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8A17913491;
 Thu, 28 Apr 2022 08:27:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CFi8HwVQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1708cee3-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SPIngja7rfH6/X0ahWtYB7L7nX8NRl4zj/+cjR7xZr0=;
	b=b7TnDrRcZ8z68LrDQfaX1DqYfORj8ovWaBSLWfmePTyAcTrj7ib5gCErS/v1IQdBeh1X3M
	Qu5cD8Fe5euQgJsZU3TUwzQz/XM70bZA++EtW65/fPX/tHI910GU8H0Dh8g3F4RlQWAky9
	CV2BiAzCmMq6L8R2HrQyYiQ9FoU5Y7A=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 07/19] xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF
Date: Thu, 28 Apr 2022 10:27:31 +0200
Message-Id: <20220428082743.16593-8-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a private macro for an invalid grant reference use
the common one.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/gntdev-dmabuf.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
index d5bfd7b867fc..91073b4e4a20 100644
--- a/drivers/xen/gntdev-dmabuf.c
+++ b/drivers/xen/gntdev-dmabuf.c
@@ -24,15 +24,6 @@
 
 MODULE_IMPORT_NS(DMA_BUF);
 
-#ifndef GRANT_INVALID_REF
-/*
- * Note on usage of grant reference 0 as invalid grant reference:
- * grant reference 0 is valid, but never exposed to a driver,
- * because of the fact it is already in use/reserved by the PV console.
- */
-#define GRANT_INVALID_REF	0
-#endif
-
 struct gntdev_dmabuf {
 	struct gntdev_dmabuf_priv *priv;
 	struct dma_buf *dmabuf;
@@ -532,7 +523,7 @@ static void dmabuf_imp_end_foreign_access(u32 *refs, int count)
 	int i;
 
 	for (i = 0; i < count; i++)
-		if (refs[i] != GRANT_INVALID_REF)
+		if (refs[i] != INVALID_GRANT_REF)
 			gnttab_end_foreign_access(refs[i], 0UL);
 }
 
@@ -567,7 +558,7 @@ static struct gntdev_dmabuf *dmabuf_imp_alloc_storage(int count)
 	gntdev_dmabuf->nr_pages = count;
 
 	for (i = 0; i < count; i++)
-		gntdev_dmabuf->u.imp.refs[i] = GRANT_INVALID_REF;
+		gntdev_dmabuf->u.imp.refs[i] = INVALID_GRANT_REF;
 
 	return gntdev_dmabuf;
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:27:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:27:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316178.535021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVF-0007BX-SU; Thu, 28 Apr 2022 08:27:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316178.535021; Thu, 28 Apr 2022 08:27:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVF-00078K-CQ; Thu, 28 Apr 2022 08:27:57 +0000
Received: by outflank-mailman (input) for mailman id 316178;
 Thu, 28 Apr 2022 08:27:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVB-0005SM-EE
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 17755833-c6cd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:27:50 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7D74021876;
 Thu, 28 Apr 2022 08:27:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5049213491;
 Thu, 28 Apr 2022 08:27:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CKAEEgZQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17755833-c6cd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134470; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YDGIDWKPRWQB7unVe+D0Q46rvuLr6BdasgzAbPg2LQ4=;
	b=T5xs3W2ptqXsPfAvqIrcBVCVmeIIst8eIXsa6BQstyNsdU/WQh1htmsRml82tfTV2fGZ3M
	7cGIdDix3zSa2IetRSiHt7IZIEFkNcvniiOV1J8BaTLWaoZ1RioIq/s150J0i7xKAcImqK
	uRJEG3SHaqX4FP/qg/DOiCvut/Qn7YI=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 10/19] xen/xenbus: add xenbus_setup_ring() service function
Date: Thu, 28 Apr 2022 10:27:34 +0200
Message-Id: <20220428082743.16593-11-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Most PV device frontends share very similar code for setting up shared
ring buffers:

- allocate page(s)
- init the ring admin data
- give the backend access to the ring via grants

Tearing down the ring requires similar actions in all frontends again:

- remove grants
- free the page(s)

Provide service functions xenbus_setup_ring() and xenbus_teardown_ring()
for that purpose.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/xenbus/xenbus_client.c | 69 ++++++++++++++++++++++++++++++
 include/xen/xenbus.h               |  4 ++
 2 files changed, 73 insertions(+)

diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
index df6890681231..1a2e0d94ccd1 100644
--- a/drivers/xen/xenbus/xenbus_client.c
+++ b/drivers/xen/xenbus/xenbus_client.c
@@ -407,6 +407,75 @@ int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
 }
 EXPORT_SYMBOL_GPL(xenbus_grant_ring);
 
+/*
+ * xenbus_setup_ring
+ * @dev: xenbus device
+ * @vaddr: pointer to starting virtual address of the ring
+ * @nr_pages: number of pages to be granted
+ * @grefs: grant reference array to be filled in
+ *
+ * Allocate physically contiguous pages for a shared ring buffer and grant it
+ * to the peer of the given device. The ring buffer is initially filled with
+ * zeroes. The virtual address of the ring is stored at @vaddr and the
+ * grant references are stored in the @grefs array. In case of error @vaddr
+ * will be set to NULL and @grefs will be filled with INVALID_GRANT_REF.
+ */
+int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
+		      unsigned int nr_pages, grant_ref_t *grefs)
+{
+	unsigned long ring_size = nr_pages * XEN_PAGE_SIZE;
+	unsigned int i;
+	int ret;
+
+	*vaddr = alloc_pages_exact(ring_size, gfp | __GFP_ZERO);
+	if (!*vaddr) {
+		ret = -ENOMEM;
+		goto err;
+	}
+
+	ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs);
+	if (ret)
+		goto err;
+
+	return 0;
+
+ err:
+	if (*vaddr)
+		free_pages_exact(*vaddr, ring_size);
+	for (i = 0; i < nr_pages; i++)
+		grefs[i] = INVALID_GRANT_REF;
+	*vaddr = NULL;
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(xenbus_setup_ring);
+
+/*
+ * xenbus_teardown_ring
+ * @vaddr: starting virtual address of the ring
+ * @nr_pages: number of pages
+ * @grefs: grant reference array
+ *
+ * Remove grants for the shared ring buffer and free the associated memory.
+ * On return the grant reference array is filled with INVALID_GRANT_REF.
+ */
+void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages,
+			  grant_ref_t *grefs)
+{
+	unsigned int i;
+
+	for (i = 0; i < nr_pages; i++) {
+		if (grefs[i] != INVALID_GRANT_REF) {
+			gnttab_end_foreign_access(grefs[i], 0);
+			grefs[i] = INVALID_GRANT_REF;
+		}
+	}
+
+	if (*vaddr)
+		free_pages_exact(*vaddr, nr_pages * XEN_PAGE_SIZE);
+	*vaddr = NULL;
+}
+EXPORT_SYMBOL_GPL(xenbus_teardown_ring);
 
 /**
  * Allocate an event channel for the given xenbus_device, assigning the newly
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
index b13eb86395e0..b533b4adc835 100644
--- a/include/xen/xenbus.h
+++ b/include/xen/xenbus.h
@@ -226,6 +226,10 @@ int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch,
 int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state);
 int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
 		      unsigned int nr_pages, grant_ref_t *grefs);
+int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
+		      unsigned int nr_pages, grant_ref_t *grefs);
+void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages,
+			  grant_ref_t *grefs);
 int xenbus_map_ring_valloc(struct xenbus_device *dev, grant_ref_t *gnt_refs,
 			   unsigned int nr_grefs, void **vaddr);
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:28:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:28:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316180.535032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVH-0007cs-OX; Thu, 28 Apr 2022 08:27:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316180.535032; Thu, 28 Apr 2022 08:27:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVH-0007Y3-7K; Thu, 28 Apr 2022 08:27:59 +0000
Received: by outflank-mailman (input) for mailman id 316180;
 Thu, 28 Apr 2022 08:27:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVC-0005SM-ET
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:54 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 17a735bb-c6cd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:27:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C72351F88F;
 Thu, 28 Apr 2022 08:27:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 86DCA13491;
 Thu, 28 Apr 2022 08:27:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qJVhHwZQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17a735bb-c6cd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134470; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VDUTirs/68J75dLhVfxQ8SwGZggDnAgUBf0vqNCyldA=;
	b=uYPkEtI1D+dBDttNAMWwXe5ps2vwOgVNOH3jvmBtgFhBUy/z0IPKe2AMkUYo9qfXjXomlv
	eDi8P8+olYpzbp6RDG+C2VAYvNC2s/qwj3kH+fQ1mRdC6zeuKb69a8lZJCAUDt5w17TMiZ
	crrx8z21AJh4HirtTLTotjXWv2WOsT4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Subject: [PATCH v2 11/19] xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Thu, 28 Apr 2022 10:27:35 +0200
Message-Id: <20220428082743.16593-12-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify blkfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/block/xen-blkfront.c | 37 ++++++++----------------------------
 1 file changed, 8 insertions(+), 29 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 7f35e30e626a..bd7b34f29193 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1280,15 +1280,8 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
 	flush_work(&rinfo->work);
 
 	/* Free resources associated with old device channel. */
-	for (i = 0; i < info->nr_ring_pages; i++) {
-		if (rinfo->ring_ref[i] != INVALID_GRANT_REF) {
-			gnttab_end_foreign_access(rinfo->ring_ref[i], 0);
-			rinfo->ring_ref[i] = INVALID_GRANT_REF;
-		}
-	}
-	free_pages_exact(rinfo->ring.sring,
-			 info->nr_ring_pages * XEN_PAGE_SIZE);
-	rinfo->ring.sring = NULL;
+	xenbus_teardown_ring((void **)&rinfo->ring.sring, info->nr_ring_pages,
+			     rinfo->ring_ref);
 
 	if (rinfo->irq)
 		unbind_from_irqhandler(rinfo->irq, rinfo);
@@ -1679,30 +1672,16 @@ static int setup_blkring(struct xenbus_device *dev,
 			 struct blkfront_ring_info *rinfo)
 {
 	struct blkif_sring *sring;
-	int err, i;
+	int err;
 	struct blkfront_info *info = rinfo->dev_info;
 	unsigned long ring_size = info->nr_ring_pages * XEN_PAGE_SIZE;
-	grant_ref_t gref[XENBUS_MAX_RING_GRANTS];
-
-	for (i = 0; i < info->nr_ring_pages; i++)
-		rinfo->ring_ref[i] = INVALID_GRANT_REF;
 
-	sring = alloc_pages_exact(ring_size, GFP_NOIO);
-	if (!sring) {
-		xenbus_dev_fatal(dev, -ENOMEM, "allocating shared ring");
-		return -ENOMEM;
-	}
-	SHARED_RING_INIT(sring);
-	FRONT_RING_INIT(&rinfo->ring, sring, ring_size);
-
-	err = xenbus_grant_ring(dev, rinfo->ring.sring, info->nr_ring_pages, gref);
-	if (err < 0) {
-		free_pages_exact(sring, ring_size);
-		rinfo->ring.sring = NULL;
+	err = xenbus_setup_ring(dev, GFP_NOIO, (void **)&sring,
+				info->nr_ring_pages, rinfo->ring_ref);
+	if (err)
 		goto fail;
-	}
-	for (i = 0; i < info->nr_ring_pages; i++)
-		rinfo->ring_ref[i] = gref[i];
+
+	XEN_FRONT_RING_INIT(&rinfo->ring, sring, ring_size);
 
 	err = xenbus_alloc_evtchn(dev, &rinfo->evtchn);
 	if (err)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:28:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:28:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316179.535044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVJ-0007u6-3Y; Thu, 28 Apr 2022 08:28:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316179.535044; Thu, 28 Apr 2022 08:28:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVI-0007qQ-FX; Thu, 28 Apr 2022 08:28:00 +0000
Received: by outflank-mailman (input) for mailman id 316179;
 Thu, 28 Apr 2022 08:27:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVC-0005SL-Aj
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:54 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17541ed6-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:50 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 464531F8AC;
 Thu, 28 Apr 2022 08:27:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 038BE13491;
 Thu, 28 Apr 2022 08:27:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kIMQOwVQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17541ed6-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134470; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8veqePX7rdlWDFOqgS78jUbLrgjtOmHQWA4ds9ys4IE=;
	b=rlIU5c4XpDDC7FrePn4vUJzKDyXHqwBA/KrdUbuegUL/GMk4CbeRxuLFKYzRcV4h6uEH0R
	L0jIaXxjVS2Dr3TW9oriwnhhCWoUjTrAD4Ua6LmdjKnMAEecMlj3qMU8neAALFcwsCaTww
	qTn2D9U/CoxHhFQs9ltdPwvn5qwcNqw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH v2 09/19] xen: update ring.h
Date: Thu, 28 Apr 2022 10:27:33 +0200
Message-Id: <20220428082743.16593-10-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Update include/xen/interface/io/ring.h to its newest version.

Switch the two improper use cases of RING_HAS_UNCONSUMED_RESPONSES() to
XEN_RING_NR_UNCONSUMED_RESPONSES() in order to avoid the nasty
XEN_RING_HAS_UNCONSUMED_IS_BOOL #define.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- new patch
---
 drivers/net/xen-netfront.c      |  4 ++--
 include/xen/interface/io/ring.h | 19 ++++++++++++++-----
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index af3d3de7d9fa..966bee2a6902 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -866,7 +866,7 @@ static void xennet_set_rx_rsp_cons(struct netfront_queue *queue, RING_IDX val)
 
 	spin_lock_irqsave(&queue->rx_cons_lock, flags);
 	queue->rx.rsp_cons = val;
-	queue->rx_rsp_unconsumed = RING_HAS_UNCONSUMED_RESPONSES(&queue->rx);
+	queue->rx_rsp_unconsumed = XEN_RING_NR_UNCONSUMED_RESPONSES(&queue->rx);
 	spin_unlock_irqrestore(&queue->rx_cons_lock, flags);
 }
 
@@ -1498,7 +1498,7 @@ static bool xennet_handle_rx(struct netfront_queue *queue, unsigned int *eoi)
 		return false;
 
 	spin_lock_irqsave(&queue->rx_cons_lock, flags);
-	work_queued = RING_HAS_UNCONSUMED_RESPONSES(&queue->rx);
+	work_queued = XEN_RING_NR_UNCONSUMED_RESPONSES(&queue->rx);
 	if (work_queued > queue->rx_rsp_unconsumed) {
 		queue->rx_rsp_unconsumed = work_queued;
 		*eoi = 0;
diff --git a/include/xen/interface/io/ring.h b/include/xen/interface/io/ring.h
index 2470ec45ebb2..ba4c4274b714 100644
--- a/include/xen/interface/io/ring.h
+++ b/include/xen/interface/io/ring.h
@@ -72,9 +72,8 @@ typedef unsigned int RING_IDX;
  * of the shared memory area (PAGE_SIZE, for instance). To initialise
  * the front half:
  *
- *     mytag_front_ring_t front_ring;
- *     SHARED_RING_INIT((mytag_sring_t *)shared_page);
- *     FRONT_RING_INIT(&front_ring, (mytag_sring_t *)shared_page, PAGE_SIZE);
+ *     mytag_front_ring_t ring;
+ *     XEN_FRONT_RING_INIT(&ring, (mytag_sring_t *)shared_page, PAGE_SIZE);
  *
  * Initializing the back follows similarly (note that only the front
  * initializes the shared ring):
@@ -146,6 +145,11 @@ struct __name##_back_ring {                                             \
 
 #define FRONT_RING_INIT(_r, _s, __size) FRONT_RING_ATTACH(_r, _s, 0, __size)
 
+#define XEN_FRONT_RING_INIT(r, s, size) do {                            \
+    SHARED_RING_INIT(s);                                                \
+    FRONT_RING_INIT(r, s, size);                                        \
+} while (0)
+
 #define BACK_RING_ATTACH(_r, _s, _i, __size) do {                       \
     (_r)->rsp_prod_pvt = (_i);                                          \
     (_r)->req_cons = (_i);                                              \
@@ -170,16 +174,21 @@ struct __name##_back_ring {                                             \
     (RING_FREE_REQUESTS(_r) == 0)
 
 /* Test if there are outstanding messages to be processed on a ring. */
-#define RING_HAS_UNCONSUMED_RESPONSES(_r)                               \
+#define XEN_RING_NR_UNCONSUMED_RESPONSES(_r)                            \
     ((_r)->sring->rsp_prod - (_r)->rsp_cons)
 
-#define RING_HAS_UNCONSUMED_REQUESTS(_r) ({                             \
+#define XEN_RING_NR_UNCONSUMED_REQUESTS(_r) ({                          \
     unsigned int req = (_r)->sring->req_prod - (_r)->req_cons;          \
     unsigned int rsp = RING_SIZE(_r) -                                  \
         ((_r)->req_cons - (_r)->rsp_prod_pvt);                          \
     req < rsp ? req : rsp;                                              \
 })
 
+#define RING_HAS_UNCONSUMED_RESPONSES(_r) \
+    (!!XEN_RING_NR_UNCONSUMED_RESPONSES(_r))
+#define RING_HAS_UNCONSUMED_REQUESTS(_r)  \
+    (!!XEN_RING_NR_UNCONSUMED_REQUESTS(_r))
+
 /* Direct access to individual ring elements, by index. */
 #define RING_GET_REQUEST(_r, _idx)                                      \
     (&((_r)->sring->ring[((_idx) & (RING_SIZE(_r) - 1))].req))
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:28:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316181.535051 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVK-00082k-1t; Thu, 28 Apr 2022 08:28:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316181.535051; Thu, 28 Apr 2022 08:28:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVJ-000808-4k; Thu, 28 Apr 2022 08:28:01 +0000
Received: by outflank-mailman (input) for mailman id 316181;
 Thu, 28 Apr 2022 08:27:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVD-0005SM-Ey
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:55 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 17fa7363-c6cd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:27:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5F85421870;
 Thu, 28 Apr 2022 08:27:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27BFC13491;
 Thu, 28 Apr 2022 08:27:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2Fd3CAdQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17fa7363-c6cd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CI5eCbbUh0HTvUxNvVm6rOMW68v7G6W10HjxAtg/ngA=;
	b=plhuxsR5eHWXzBK0P+35/4qRW5X11ur7K+VFwBQHFjrUXz367eeCDl5N4tO+2yDtlkMhzg
	YYPWBfxbelagkQWT0RoqKtMDb6YfVYgzvvOjcOzLMU+1dV3acvtrEjUNtANR3KBuDqcv2V
	NXaoQzG58L0ZWkmi9psNZD7qJZerN9M=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-integrity@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>
Subject: [PATCH v2 13/19] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Thu, 28 Apr 2022 10:27:37 +0200
Message-Id: <20220428082743.16593-14-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify tpmfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/char/tpm/xen-tpmfront.c | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 69df04ae2401..379291826261 100644
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -253,20 +253,12 @@ static int setup_ring(struct xenbus_device *dev, struct tpm_private *priv)
 	struct xenbus_transaction xbt;
 	const char *message = NULL;
 	int rv;
-	grant_ref_t gref;
 
-	priv->shr = (void *)__get_free_page(GFP_KERNEL|__GFP_ZERO);
-	if (!priv->shr) {
-		xenbus_dev_fatal(dev, -ENOMEM, "allocating shared ring");
-		return -ENOMEM;
-	}
-
-	rv = xenbus_grant_ring(dev, priv->shr, 1, &gref);
+	rv = xenbus_setup_ring(dev, GFP_KERNEL, (void **)&priv->shr, 1,
+			       &priv->ring_ref);
 	if (rv < 0)
 		return rv;
 
-	priv->ring_ref = gref;
-
 	rv = xenbus_alloc_evtchn(dev, &priv->evtchn);
 	if (rv)
 		return rv;
@@ -331,11 +323,7 @@ static void ring_free(struct tpm_private *priv)
 	if (!priv)
 		return;
 
-	if (priv->ring_ref)
-		gnttab_end_foreign_access(priv->ring_ref,
-				(unsigned long)priv->shr);
-	else
-		free_page((unsigned long)priv->shr);
+	xenbus_teardown_ring((void **)&priv->shr, 1, &priv->ring_ref);
 
 	if (priv->irq)
 		unbind_from_irqhandler(priv->irq, priv);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:28:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:28:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316182.535061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVL-0008Iz-UE; Thu, 28 Apr 2022 08:28:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316182.535061; Thu, 28 Apr 2022 08:28:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVK-0008FY-HF; Thu, 28 Apr 2022 08:28:02 +0000
Received: by outflank-mailman (input) for mailman id 316182;
 Thu, 28 Apr 2022 08:27:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVD-0005SL-B3
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:55 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17d24682-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 213BC1F890;
 Thu, 28 Apr 2022 08:27:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CE03013491;
 Thu, 28 Apr 2022 08:27:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qCMIMQZQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17d24682-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bVl00wdBYeWK59DNgpTl+klU3KYXSfeQcCWUD7CZHgs=;
	b=k881eTR02k8w1RYRfM94bVRQVC+/P1KxAKK9Vr1oaKX1zwBgry4GKvMMbwXVTKe5Vz9u53
	NzzI2WgN10PupMpUlvxc/YqIEqnJiuFBZzXUZpOWrtSvAndR0+LlKR61OsCyf7F7A5Xfen
	LBx/pgfQle9bOdS54vpk7CkRnFKHe3g=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH v2 12/19] xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Thu, 28 Apr 2022 10:27:36 +0200
Message-Id: <20220428082743.16593-13-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify netfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/net/xen-netfront.c | 53 +++++++++-----------------------------
 1 file changed, 12 insertions(+), 41 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 966bee2a6902..65ab907aca5a 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1921,8 +1921,7 @@ static int setup_netfront(struct xenbus_device *dev,
 			struct netfront_queue *queue, unsigned int feature_split_evtchn)
 {
 	struct xen_netif_tx_sring *txs;
-	struct xen_netif_rx_sring *rxs = NULL;
-	grant_ref_t gref;
+	struct xen_netif_rx_sring *rxs;
 	int err;
 
 	queue->tx_ring_ref = INVALID_GRANT_REF;
@@ -1930,33 +1929,19 @@ static int setup_netfront(struct xenbus_device *dev,
 	queue->rx.sring = NULL;
 	queue->tx.sring = NULL;
 
-	txs = (struct xen_netif_tx_sring *)get_zeroed_page(GFP_NOIO | __GFP_HIGH);
-	if (!txs) {
-		err = -ENOMEM;
-		xenbus_dev_fatal(dev, err, "allocating tx ring page");
+	err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH, (void **)&txs,
+				1, &queue->tx_ring_ref);
+	if (err)
 		goto fail;
-	}
-	SHARED_RING_INIT(txs);
-	FRONT_RING_INIT(&queue->tx, txs, XEN_PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, txs, 1, &gref);
-	if (err < 0)
-		goto fail;
-	queue->tx_ring_ref = gref;
+	XEN_FRONT_RING_INIT(&queue->tx, txs, XEN_PAGE_SIZE);
 
-	rxs = (struct xen_netif_rx_sring *)get_zeroed_page(GFP_NOIO | __GFP_HIGH);
-	if (!rxs) {
-		err = -ENOMEM;
-		xenbus_dev_fatal(dev, err, "allocating rx ring page");
+	err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH, (void **)&rxs,
+				1, &queue->rx_ring_ref);
+	if (err)
 		goto fail;
-	}
-	SHARED_RING_INIT(rxs);
-	FRONT_RING_INIT(&queue->rx, rxs, XEN_PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, rxs, 1, &gref);
-	if (err < 0)
-		goto fail;
-	queue->rx_ring_ref = gref;
+	XEN_FRONT_RING_INIT(&queue->rx, rxs, XEN_PAGE_SIZE);
 
 	if (feature_split_evtchn)
 		err = setup_netfront_split(queue);
@@ -1972,24 +1957,10 @@ static int setup_netfront(struct xenbus_device *dev,
 
 	return 0;
 
-	/* If we fail to setup netfront, it is safe to just revoke access to
-	 * granted pages because backend is not accessing it at this point.
-	 */
  fail:
-	if (queue->rx_ring_ref != INVALID_GRANT_REF) {
-		gnttab_end_foreign_access(queue->rx_ring_ref,
-					  (unsigned long)rxs);
-		queue->rx_ring_ref = INVALID_GRANT_REF;
-	} else {
-		free_page((unsigned long)rxs);
-	}
-	if (queue->tx_ring_ref != INVALID_GRANT_REF) {
-		gnttab_end_foreign_access(queue->tx_ring_ref,
-					  (unsigned long)txs);
-		queue->tx_ring_ref = INVALID_GRANT_REF;
-	} else {
-		free_page((unsigned long)txs);
-	}
+	xenbus_teardown_ring((void **)&queue->rx.sring, 1, &queue->rx_ring_ref);
+	xenbus_teardown_ring((void **)&queue->tx.sring, 1, &queue->tx_ring_ref);
+
 	return err;
 }
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:28:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:28:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316183.535071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVO-0000Jp-0O; Thu, 28 Apr 2022 08:28:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316183.535071; Thu, 28 Apr 2022 08:28:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVM-0000Ee-Md; Thu, 28 Apr 2022 08:28:04 +0000
Received: by outflank-mailman (input) for mailman id 316183;
 Thu, 28 Apr 2022 08:27:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVE-0005SL-BP
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:56 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 184ea9a1-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:52 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id E750D21871;
 Thu, 28 Apr 2022 08:27:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ADCC013491;
 Thu, 28 Apr 2022 08:27:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2D3fKAdQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 184ea9a1-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4w7uCrVXVTwZfPuB483vIPp5pLFfFRyBD4Y2IYXR2Yk=;
	b=evJ5rg5sEto2aWIIjrjOQPgkeyr3Gle8wcN4/Jb29iscyKgXZmT4ie3JH0XrGFhJrMf8Lo
	Niu40LYPTvOu9bDwFznYsNaBdusaLXqoJQPPx7jd7ZSbB7j+czJkZkmZVN05Zs+VwpwZmz
	17Hj+h0lQQ7whUEHoJmdDH9U/WePsPM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH v2 15/19] xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Thu, 28 Apr 2022 10:27:39 +0200
Message-Id: <20220428082743.16593-16-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify pcifront's shared page creation and removal via
xenbus_setup_ring() and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/pci/xen-pcifront.c | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index 3edc1565a27c..689271c4245c 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -709,9 +709,8 @@ static struct pcifront_device *alloc_pdev(struct xenbus_device *xdev)
 	if (pdev == NULL)
 		goto out;
 
-	pdev->sh_info =
-	    (struct xen_pci_sharedinfo *)__get_free_page(GFP_KERNEL);
-	if (pdev->sh_info == NULL) {
+	if (xenbus_setup_ring(xdev, GFP_KERNEL, (void **)&pdev->sh_info, 1,
+			      &pdev->gnt_ref)) {
 		kfree(pdev);
 		pdev = NULL;
 		goto out;
@@ -729,7 +728,6 @@ static struct pcifront_device *alloc_pdev(struct xenbus_device *xdev)
 	spin_lock_init(&pdev->sh_info_lock);
 
 	pdev->evtchn = INVALID_EVTCHN;
-	pdev->gnt_ref = INVALID_GRANT_REF;
 	pdev->irq = -1;
 
 	INIT_WORK(&pdev->op_work, pcifront_do_aer);
@@ -754,11 +752,7 @@ static void free_pdev(struct pcifront_device *pdev)
 	if (pdev->evtchn != INVALID_EVTCHN)
 		xenbus_free_evtchn(pdev->xdev, pdev->evtchn);
 
-	if (pdev->gnt_ref != INVALID_GRANT_REF)
-		gnttab_end_foreign_access(pdev->gnt_ref,
-					  (unsigned long)pdev->sh_info);
-	else
-		free_page((unsigned long)pdev->sh_info);
+	xenbus_teardown_ring((void **)&pdev->sh_info, 1, &pdev->gnt_ref);
 
 	dev_set_drvdata(&pdev->xdev->dev, NULL);
 
@@ -769,13 +763,6 @@ static int pcifront_publish_info(struct pcifront_device *pdev)
 {
 	int err = 0;
 	struct xenbus_transaction trans;
-	grant_ref_t gref;
-
-	err = xenbus_grant_ring(pdev->xdev, pdev->sh_info, 1, &gref);
-	if (err < 0)
-		goto out;
-
-	pdev->gnt_ref = gref;
 
 	err = xenbus_alloc_evtchn(pdev->xdev, &pdev->evtchn);
 	if (err)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:28:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:28:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316184.535076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVP-0000c7-L0; Thu, 28 Apr 2022 08:28:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316184.535076; Thu, 28 Apr 2022 08:28:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVO-0000U1-5y; Thu, 28 Apr 2022 08:28:06 +0000
Received: by outflank-mailman (input) for mailman id 316184;
 Thu, 28 Apr 2022 08:27:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVE-0005SM-F9
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:56 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1827338a-c6cd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 10:27:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id A49C61F88C;
 Thu, 28 Apr 2022 08:27:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 695A913491;
 Thu, 28 Apr 2022 08:27:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id eDY0GAdQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1827338a-c6cd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pzS6PLrR2PHAizt1+i4tl6giJjA8snqDfs2l2Q2VBs0=;
	b=nFFFyryTPJUwSGLm0DOiWi5pBKFreuwVT6dtG6vv7wwwjuQBZiXQURV9kZVktg8KWsLx1t
	ilLRU/ya4Wl0h4xf0vilOs5Q1STs8uNfcYkc77DBM7WYb0v8XRhp6kV9DQJWf22LPv4YH4
	YeMQaNn8uOAEoouaJA49F3Fl0qU4Z08=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: [PATCH v2 14/19] xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Thu, 28 Apr 2022 10:27:38 +0200
Message-Id: <20220428082743.16593-15-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify drmfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 ++++++---------------
 1 file changed, 11 insertions(+), 32 deletions(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
index 4006568b9e32..e52afd792346 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
@@ -123,12 +123,12 @@ static irqreturn_t evtchnl_interrupt_evt(int irq, void *dev_id)
 static void evtchnl_free(struct xen_drm_front_info *front_info,
 			 struct xen_drm_front_evtchnl *evtchnl)
 {
-	unsigned long page = 0;
+	void *page = NULL;
 
 	if (evtchnl->type == EVTCHNL_TYPE_REQ)
-		page = (unsigned long)evtchnl->u.req.ring.sring;
+		page = evtchnl->u.req.ring.sring;
 	else if (evtchnl->type == EVTCHNL_TYPE_EVT)
-		page = (unsigned long)evtchnl->u.evt.page;
+		page = evtchnl->u.evt.page;
 	if (!page)
 		return;
 
@@ -147,8 +147,7 @@ static void evtchnl_free(struct xen_drm_front_info *front_info,
 		xenbus_free_evtchn(front_info->xb_dev, evtchnl->port);
 
 	/* end access and free the page */
-	if (evtchnl->gref != INVALID_GRANT_REF)
-		gnttab_end_foreign_access(evtchnl->gref, page);
+	xenbus_teardown_ring(&page, 1, &evtchnl->gref);
 
 	memset(evtchnl, 0, sizeof(*evtchnl));
 }
@@ -158,8 +157,7 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index,
 			 enum xen_drm_front_evtchnl_type type)
 {
 	struct xenbus_device *xb_dev = front_info->xb_dev;
-	unsigned long page;
-	grant_ref_t gref;
+	void *page;
 	irq_handler_t handler;
 	int ret;
 
@@ -168,44 +166,25 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index,
 	evtchnl->index = index;
 	evtchnl->front_info = front_info;
 	evtchnl->state = EVTCHNL_STATE_DISCONNECTED;
-	evtchnl->gref = INVALID_GRANT_REF;
 
-	page = get_zeroed_page(GFP_NOIO | __GFP_HIGH);
-	if (!page) {
-		ret = -ENOMEM;
+	ret = xenbus_setup_ring(xb_dev, GFP_NOIO | __GFP_HIGH, &page,
+				1, &evtchnl->gref);
+	if (ret)
 		goto fail;
-	}
 
 	if (type == EVTCHNL_TYPE_REQ) {
 		struct xen_displif_sring *sring;
 
 		init_completion(&evtchnl->u.req.completion);
 		mutex_init(&evtchnl->u.req.req_io_lock);
-		sring = (struct xen_displif_sring *)page;
-		SHARED_RING_INIT(sring);
-		FRONT_RING_INIT(&evtchnl->u.req.ring, sring, XEN_PAGE_SIZE);
-
-		ret = xenbus_grant_ring(xb_dev, sring, 1, &gref);
-		if (ret < 0) {
-			evtchnl->u.req.ring.sring = NULL;
-			free_page(page);
-			goto fail;
-		}
+		sring = page;
+		XEN_FRONT_RING_INIT(&evtchnl->u.req.ring, sring, XEN_PAGE_SIZE);
 
 		handler = evtchnl_interrupt_ctrl;
 	} else {
-		ret = gnttab_grant_foreign_access(xb_dev->otherend_id,
-						  virt_to_gfn((void *)page), 0);
-		if (ret < 0) {
-			free_page(page);
-			goto fail;
-		}
-
-		evtchnl->u.evt.page = (struct xendispl_event_page *)page;
-		gref = ret;
+		evtchnl->u.evt.page = page;
 		handler = evtchnl_interrupt_evt;
 	}
-	evtchnl->gref = gref;
 
 	ret = xenbus_alloc_evtchn(xb_dev, &evtchnl->port);
 	if (ret < 0)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:28:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:28:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316185.535091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVS-00017g-Mz; Thu, 28 Apr 2022 08:28:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316185.535091; Thu, 28 Apr 2022 08:28:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVQ-0000xd-MF; Thu, 28 Apr 2022 08:28:08 +0000
Received: by outflank-mailman (input) for mailman id 316185;
 Thu, 28 Apr 2022 08:27:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVF-0005SL-Bj
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:57 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 187ae0aa-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:52 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3C6951F88B;
 Thu, 28 Apr 2022 08:27:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EEBE613491;
 Thu, 28 Apr 2022 08:27:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id GGn6OAdQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 187ae0aa-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1OIhlvhpDf96xGkhA26yZf7pns1SEZ9vLk/EobSBf7U=;
	b=e4ZiNoI9Kk/vxF6WBGPMvTgtaqzePnrbSEgd3HhKF9fP7PEcYc6C3tzqPjkZsraNDBQpgQ
	Xh5BmiCZb69+V49nJ6MhqGTMRLvrWvGZekAggS1g0NOR11UvMZk2/S6Lwh9yw+93369n8K
	zuoWN8JagVvATERzOOkykaCGvpybBDs=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v2 16/19] xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Thu, 28 Apr 2022 10:27:40 +0200
Message-Id: <20220428082743.16593-17-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify scsifront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/scsi/xen-scsifront.c | 28 +++++++---------------------
 1 file changed, 7 insertions(+), 21 deletions(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 4c55e479fc36..51afc66e839d 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -798,27 +798,15 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info)
 {
 	struct xenbus_device *dev = info->dev;
 	struct vscsiif_sring *sring;
-	grant_ref_t gref;
-	int err = -ENOMEM;
+	int err;
 
 	/***** Frontend to Backend ring start *****/
-	sring = (struct vscsiif_sring *)__get_free_page(GFP_KERNEL);
-	if (!sring) {
-		xenbus_dev_fatal(dev, err,
-			"fail to allocate shared ring (Front to Back)");
+	err = xenbus_setup_ring(dev, GFP_KERNEL, (void **)&sring, 1,
+				&info->ring_ref);
+	if (err)
 		return err;
-	}
-	SHARED_RING_INIT(sring);
-	FRONT_RING_INIT(&info->ring, sring, PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, sring, 1, &gref);
-	if (err < 0) {
-		free_page((unsigned long)sring);
-		xenbus_dev_fatal(dev, err,
-			"fail to grant shared ring (Front to Back)");
-		return err;
-	}
-	info->ring_ref = gref;
+	XEN_FRONT_RING_INIT(&info->ring, sring, PAGE_SIZE);
 
 	err = xenbus_alloc_evtchn(dev, &info->evtchn);
 	if (err) {
@@ -847,8 +835,7 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info)
 free_irq:
 	unbind_from_irqhandler(info->irq, info);
 free_gnttab:
-	gnttab_end_foreign_access(info->ring_ref,
-				  (unsigned long)info->ring.sring);
+	xenbus_teardown_ring((void **)&sring, 1, &info->ring_ref);
 
 	return err;
 }
@@ -856,8 +843,7 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info)
 static void scsifront_free_ring(struct vscsifrnt_info *info)
 {
 	unbind_from_irqhandler(info->irq, info);
-	gnttab_end_foreign_access(info->ring_ref,
-				  (unsigned long)info->ring.sring);
+	xenbus_teardown_ring((void **)&info->ring.sring, 1, &info->ring_ref);
 }
 
 static int scsifront_init_ring(struct vscsifrnt_info *info)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:28:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:28:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316186.535101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVU-0001jE-P1; Thu, 28 Apr 2022 08:28:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316186.535101; Thu, 28 Apr 2022 08:28:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzVT-0001as-4i; Thu, 28 Apr 2022 08:28:11 +0000
Received: by outflank-mailman (input) for mailman id 316186;
 Thu, 28 Apr 2022 08:27:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVG-0005SL-C6
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:58 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 189c7fbc-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:52 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 7237D1F88A;
 Thu, 28 Apr 2022 08:27:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 43ED413491;
 Thu, 28 Apr 2022 08:27:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id QF5XDwhQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 189c7fbc-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7cqwaPLtFzhyk9LMWncXmAETsj1bDnyp+ydH1my5u10=;
	b=XTUSjtzPzruE8bhqvv73TtSTB50qK9+aNrXbuRtAJ9c6hvz9KnGSHEC+p8iV6zrfVFvbr7
	Me2MbBlNtrfCJ/FKyPE9+PGYOV6x5DQhu0AqYudjZTvyTvrfxBYt3eMH0Ldo8Fj7KYWYxl
	hQkceNSNaNLcPkHDy8rh2e1023pRJhY=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v2 17/19] xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Thu, 28 Apr 2022 10:27:41 +0200
Message-Id: <20220428082743.16593-18-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify xen-hcd's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/usb/host/xen-hcd.c | 61 ++++++++++----------------------------
 1 file changed, 15 insertions(+), 46 deletions(-)

diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c
index 9cbc7c2dab02..de1b09158318 100644
--- a/drivers/usb/host/xen-hcd.c
+++ b/drivers/usb/host/xen-hcd.c
@@ -1098,19 +1098,10 @@ static void xenhcd_destroy_rings(struct xenhcd_info *info)
 		unbind_from_irqhandler(info->irq, info);
 	info->irq = 0;
 
-	if (info->urb_ring_ref != INVALID_GRANT_REF) {
-		gnttab_end_foreign_access(info->urb_ring_ref,
-					  (unsigned long)info->urb_ring.sring);
-		info->urb_ring_ref = INVALID_GRANT_REF;
-	}
-	info->urb_ring.sring = NULL;
-
-	if (info->conn_ring_ref != INVALID_GRANT_REF) {
-		gnttab_end_foreign_access(info->conn_ring_ref,
-					  (unsigned long)info->conn_ring.sring);
-		info->conn_ring_ref = INVALID_GRANT_REF;
-	}
-	info->conn_ring.sring = NULL;
+	xenbus_teardown_ring((void **)&info->urb_ring.sring, 1,
+			     &info->urb_ring_ref);
+	xenbus_teardown_ring((void **)&info->conn_ring.sring, 1,
+			     &info->conn_ring_ref);
 }
 
 static int xenhcd_setup_rings(struct xenbus_device *dev,
@@ -1118,46 +1109,24 @@ static int xenhcd_setup_rings(struct xenbus_device *dev,
 {
 	struct xenusb_urb_sring *urb_sring;
 	struct xenusb_conn_sring *conn_sring;
-	grant_ref_t gref;
 	int err;
 
-	info->urb_ring_ref = INVALID_GRANT_REF;
 	info->conn_ring_ref = INVALID_GRANT_REF;
-
-	urb_sring = (struct xenusb_urb_sring *)get_zeroed_page(
-							GFP_NOIO | __GFP_HIGH);
-	if (!urb_sring) {
-		xenbus_dev_fatal(dev, -ENOMEM, "allocating urb ring");
-		return -ENOMEM;
-	}
-	SHARED_RING_INIT(urb_sring);
-	FRONT_RING_INIT(&info->urb_ring, urb_sring, PAGE_SIZE);
-
-	err = xenbus_grant_ring(dev, urb_sring, 1, &gref);
-	if (err < 0) {
-		free_page((unsigned long)urb_sring);
-		info->urb_ring.sring = NULL;
-		goto fail;
-	}
-	info->urb_ring_ref = gref;
-
-	conn_sring = (struct xenusb_conn_sring *)get_zeroed_page(
-							GFP_NOIO | __GFP_HIGH);
-	if (!conn_sring) {
-		xenbus_dev_fatal(dev, -ENOMEM, "allocating conn ring");
-		err = -ENOMEM;
-		goto fail;
+	err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH,
+				(void **)&urb_sring, 1, &info->urb_ring_ref);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "allocating urb ring");
+		return err;
 	}
-	SHARED_RING_INIT(conn_sring);
-	FRONT_RING_INIT(&info->conn_ring, conn_sring, PAGE_SIZE);
+	XEN_FRONT_RING_INIT(&info->urb_ring, urb_sring, PAGE_SIZE);
 
-	err = xenbus_grant_ring(dev, conn_sring, 1, &gref);
-	if (err < 0) {
-		free_page((unsigned long)conn_sring);
-		info->conn_ring.sring = NULL;
+	err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH,
+				(void **)&conn_sring, 1, &info->conn_ring_ref);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "allocating conn ring");
 		goto fail;
 	}
-	info->conn_ring_ref = gref;
+	XEN_FRONT_RING_INIT(&info->conn_ring, conn_sring, PAGE_SIZE);
 
 	err = xenbus_alloc_evtchn(dev, &info->evtchn);
 	if (err) {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:33:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:33:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316241.535142 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzaQ-0008W0-DG; Thu, 28 Apr 2022 08:33:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316241.535142; Thu, 28 Apr 2022 08:33:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzaQ-0008Vt-A1; Thu, 28 Apr 2022 08:33:18 +0000
Received: by outflank-mailman (input) for mailman id 316241;
 Thu, 28 Apr 2022 08:33:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVH-0005SL-Bm
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:27:59 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18eaf877-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:53 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EF2F21F88E;
 Thu, 28 Apr 2022 08:27:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C01E513491;
 Thu, 28 Apr 2022 08:27:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mIuaLQhQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18eaf877-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DySE+lWBPx7VwNEF3X1lwYDq+4S10O0jUUqyaBArCE0=;
	b=nbgsI2l8XvMPHhwykxKcjmjFm5ic18dsQ4iNKTc8cOED/bFxCbEf3NTRN8JBCmnMBKGyQ2
	qXLhAX68u5bD4eceSKKH1djjOsiFninHCccZsIkSwMsZEy1jxCtv8Ps2onc8BrAtqKGNng
	Yy+egfDuGQZXpsqZG2QPjJvI84+Pz7Q=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 19/19] xen/xenbus: eliminate xenbus_grant_ring()
Date: Thu, 28 Apr 2022 10:27:43 +0200
Message-Id: <20220428082743.16593-20-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There is no external user of xenbus_grant_ring() left, so merge it into
the only caller xenbus_setup_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- make error message more precise (Andrew Cooper)
---
 drivers/xen/xenbus/xenbus_client.c | 65 +++++++++---------------------
 include/xen/xenbus.h               |  2 -
 2 files changed, 19 insertions(+), 48 deletions(-)

diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
index 1a2e0d94ccd1..d6fdd2d209d3 100644
--- a/drivers/xen/xenbus/xenbus_client.c
+++ b/drivers/xen/xenbus/xenbus_client.c
@@ -363,50 +363,6 @@ static void xenbus_switch_fatal(struct xenbus_device *dev, int depth, int err,
 		__xenbus_switch_state(dev, XenbusStateClosing, 1);
 }
 
-/**
- * xenbus_grant_ring
- * @dev: xenbus device
- * @vaddr: starting virtual address of the ring
- * @nr_pages: number of pages to be granted
- * @grefs: grant reference array to be filled in
- *
- * Grant access to the given @vaddr to the peer of the given device.
- * Then fill in @grefs with grant references.  Return 0 on success, or
- * -errno on error.  On error, the device will switch to
- * XenbusStateClosing, and the error will be saved in the store.
- */
-int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
-		      unsigned int nr_pages, grant_ref_t *grefs)
-{
-	int err;
-	unsigned int i;
-	grant_ref_t gref_head;
-
-	err = gnttab_alloc_grant_references(nr_pages, &gref_head);
-	if (err) {
-		xenbus_dev_fatal(dev, err, "granting access to ring page");
-		return err;
-	}
-
-	for (i = 0; i < nr_pages; i++) {
-		unsigned long gfn;
-
-		if (is_vmalloc_addr(vaddr))
-			gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr));
-		else
-			gfn = virt_to_gfn(vaddr);
-
-		grefs[i] = gnttab_claim_grant_reference(&gref_head);
-		gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id,
-						gfn, 0);
-
-		vaddr = vaddr + XEN_PAGE_SIZE;
-	}
-
-	return 0;
-}
-EXPORT_SYMBOL_GPL(xenbus_grant_ring);
-
 /*
  * xenbus_setup_ring
  * @dev: xenbus device
@@ -424,6 +380,7 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
 		      unsigned int nr_pages, grant_ref_t *grefs)
 {
 	unsigned long ring_size = nr_pages * XEN_PAGE_SIZE;
+	grant_ref_t gref_head;
 	unsigned int i;
 	int ret;
 
@@ -433,9 +390,25 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
 		goto err;
 	}
 
-	ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs);
-	if (ret)
+	ret = gnttab_alloc_grant_references(nr_pages, &gref_head);
+	if (ret) {
+		xenbus_dev_fatal(dev, ret, "granting access to %u ring pages",
+				 nr_pages);
 		goto err;
+	}
+
+	for (i = 0; i < nr_pages; i++) {
+		unsigned long gfn;
+
+		if (is_vmalloc_addr(*vaddr))
+			gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr[i]));
+		else
+			gfn = virt_to_gfn(vaddr[i]);
+
+		grefs[i] = gnttab_claim_grant_reference(&gref_head);
+		gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id,
+						gfn, 0);
+	}
 
 	return 0;
 
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
index b533b4adc835..eaa932b99d8a 100644
--- a/include/xen/xenbus.h
+++ b/include/xen/xenbus.h
@@ -224,8 +224,6 @@ int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch,
 			 const char *pathfmt, ...);
 
 int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state);
-int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
-		      unsigned int nr_pages, grant_ref_t *grefs);
 int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
 		      unsigned int nr_pages, grant_ref_t *grefs);
 void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages,
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:33:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:33:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316266.535153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzap-0000hS-PO; Thu, 28 Apr 2022 08:33:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316266.535153; Thu, 28 Apr 2022 08:33:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzap-0000hL-Lv; Thu, 28 Apr 2022 08:33:43 +0000
Received: by outflank-mailman (input) for mailman id 316266;
 Thu, 28 Apr 2022 08:33:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KUQd=VG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1njzVI-0005SL-Bz
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:28:00 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18c93c4b-c6cd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:27:53 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B7E8F1F88D;
 Thu, 28 Apr 2022 08:27:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7BA3013491;
 Thu, 28 Apr 2022 08:27:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OLTnHAhQamIBLgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Apr 2022 08:27:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18c93c4b-c6cd-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1651134472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bFzOYs3GvoZ1bc2idQf8TBLq/Nc4sN1RlI7sPOTyE0I=;
	b=HNTQdnlj0qCLAqxzw388+FkheIAWG3gwHYAtRFSV9cIoUXwBDo2Iv94Cjlkxh2sI+LNuPe
	eLFVkOqNjIzUnhB/3qk/P9dSppkkTBWNGhorExasJlN0/U3whVT0HWJbZPavxKrAuaoTbs
	4daprI//vTA4Gg5FL9df8FOk1WsMij0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH v2 18/19] xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring()
Date: Thu, 28 Apr 2022 10:27:42 +0200
Message-Id: <20220428082743.16593-19-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428082743.16593-1-jgross@suse.com>
References: <20220428082743.16593-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Simplify sndfront's ring creation and removal via xenbus_setup_ring()
and xenbus_teardown_ring().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 sound/xen/xen_snd_front_evtchnl.c | 44 +++++++------------------------
 1 file changed, 10 insertions(+), 34 deletions(-)

diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
index 3e21369c8216..26d1b3987887 100644
--- a/sound/xen/xen_snd_front_evtchnl.c
+++ b/sound/xen/xen_snd_front_evtchnl.c
@@ -143,12 +143,12 @@ void xen_snd_front_evtchnl_flush(struct xen_snd_front_evtchnl *channel)
 static void evtchnl_free(struct xen_snd_front_info *front_info,
 			 struct xen_snd_front_evtchnl *channel)
 {
-	unsigned long page = 0;
+	void *page = NULL;
 
 	if (channel->type == EVTCHNL_TYPE_REQ)
-		page = (unsigned long)channel->u.req.ring.sring;
+		page = channel->u.req.ring.sring;
 	else if (channel->type == EVTCHNL_TYPE_EVT)
-		page = (unsigned long)channel->u.evt.page;
+		page = channel->u.evt.page;
 
 	if (!page)
 		return;
@@ -167,10 +167,7 @@ static void evtchnl_free(struct xen_snd_front_info *front_info,
 		xenbus_free_evtchn(front_info->xb_dev, channel->port);
 
 	/* End access and free the page. */
-	if (channel->gref != INVALID_GRANT_REF)
-		gnttab_end_foreign_access(channel->gref, page);
-	else
-		free_page(page);
+	xenbus_teardown_ring(&page, 1, &channel->gref);
 
 	memset(channel, 0, sizeof(*channel));
 }
@@ -196,8 +193,7 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 			 enum xen_snd_front_evtchnl_type type)
 {
 	struct xenbus_device *xb_dev = front_info->xb_dev;
-	unsigned long page;
-	grant_ref_t gref;
+	void *page;
 	irq_handler_t handler;
 	char *handler_name = NULL;
 	int ret;
@@ -207,12 +203,9 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 	channel->index = index;
 	channel->front_info = front_info;
 	channel->state = EVTCHNL_STATE_DISCONNECTED;
-	channel->gref = INVALID_GRANT_REF;
-	page = get_zeroed_page(GFP_KERNEL);
-	if (!page) {
-		ret = -ENOMEM;
+	ret = xenbus_setup_ring(xb_dev, GFP_KERNEL, &page, 1, &channel->gref);
+	if (ret)
 		goto fail;
-	}
 
 	handler_name = kasprintf(GFP_KERNEL, "%s-%s", XENSND_DRIVER_NAME,
 				 type == EVTCHNL_TYPE_REQ ?
@@ -226,33 +219,18 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 	mutex_init(&channel->ring_io_lock);
 
 	if (type == EVTCHNL_TYPE_REQ) {
-		struct xen_sndif_sring *sring = (struct xen_sndif_sring *)page;
+		struct xen_sndif_sring *sring = page;
 
 		init_completion(&channel->u.req.completion);
 		mutex_init(&channel->u.req.req_io_lock);
-		SHARED_RING_INIT(sring);
-		FRONT_RING_INIT(&channel->u.req.ring, sring, XEN_PAGE_SIZE);
-
-		ret = xenbus_grant_ring(xb_dev, sring, 1, &gref);
-		if (ret < 0) {
-			channel->u.req.ring.sring = NULL;
-			goto fail;
-		}
+		XEN_FRONT_RING_INIT(&channel->u.req.ring, sring, XEN_PAGE_SIZE);
 
 		handler = evtchnl_interrupt_req;
 	} else {
-		ret = gnttab_grant_foreign_access(xb_dev->otherend_id,
-						  virt_to_gfn((void *)page), 0);
-		if (ret < 0)
-			goto fail;
-
-		channel->u.evt.page = (struct xensnd_event_page *)page;
-		gref = ret;
+		channel->u.evt.page = page;
 		handler = evtchnl_interrupt_evt;
 	}
 
-	channel->gref = gref;
-
 	ret = xenbus_alloc_evtchn(xb_dev, &channel->port);
 	if (ret < 0)
 		goto fail;
@@ -279,8 +257,6 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
 	return 0;
 
 fail:
-	if (page)
-		free_page(page);
 	kfree(handler_name);
 	dev_err(&xb_dev->dev, "Failed to allocate ring: %d\n", ret);
 	return ret;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:44:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:44:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316293.535164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzkm-0002KV-OO; Thu, 28 Apr 2022 08:44:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316293.535164; Thu, 28 Apr 2022 08:44:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzkm-0002KO-K7; Thu, 28 Apr 2022 08:44:00 +0000
Received: by outflank-mailman (input) for mailman id 316293;
 Thu, 28 Apr 2022 08:43:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njzkk-0002KE-MS; Thu, 28 Apr 2022 08:43:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njzkk-0001yl-LN; Thu, 28 Apr 2022 08:43:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1njzkk-0001vf-EL; Thu, 28 Apr 2022 08:43:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1njzkk-0001tt-Dw; Thu, 28 Apr 2022 08:43:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qgQYSBBBZsvesDZW+MhzvcqOK9McsAcyWI7Iru0QeRE=; b=PfBjucicLjj/A2ytzBUCg4fTkh
	ePraQ+bN5CTgUU+PeMBOSdEu0qrgERMB4xRv4jWQKyyZimUWvJai4KGkpWrL/DKB8D0R/fa8BPFeE
	B0othv7dtTAe0G1TsDT7l0UijK3WyK5p5qhWWRj5W+bzxRbOj/uqg8SjGSkI+wAuGG+c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169806-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169806: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 08:43:58 +0000

flight 169806 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169806/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  673 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   45 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:45:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:45:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316300.535175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzmg-0002wO-3f; Thu, 28 Apr 2022 08:45:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316300.535175; Thu, 28 Apr 2022 08:45:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njzmg-0002wH-0R; Thu, 28 Apr 2022 08:45:58 +0000
Received: by outflank-mailman (input) for mailman id 316300;
 Thu, 28 Apr 2022 08:45:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1njzmf-0002w8-DH
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:45:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njzma-00021E-ED; Thu, 28 Apr 2022 08:45:52 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.193])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1njzma-0003xM-8L; Thu, 28 Apr 2022 08:45:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=GXGhOK+VQl3Tt8oqlgKDatLfuMeF2J9O0UEPz1BqcJ4=; b=oAxKbEu+S49nOpBG9/xl6IU+dF
	PTJObihaSYnqyFcgH+fUVdxl6slcA5o9aacK+Xg4RHlLg9v4Lbpz+dXY+lwlhyws5Im9YWZpXWNEQ
	O8VYklDIIv1euryvtMY+A+g6GJQVIQir+Bz0SitFVPulzukjIXpv19LAGI7zQkZykSZ8=;
Message-ID: <7a82f8ff-d696-9bc2-97b9-7965953cf8ea@xen.org>
Date: Thu, 28 Apr 2022 09:45:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
To: Jan Beulich <jbeulich@suse.com>,
 osstest service owner <osstest-admin@xenproject.org>
Cc: David Vrabel <dvrabel@amazon.co.uk>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <osstest-169781-mainreport@xen.org>
 <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
 <34c7f008-a530-db45-cfb9-63b26944f03b@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <34c7f008-a530-db45-cfb9-63b26944f03b@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 28/04/2022 08:45, Jan Beulich wrote:
> On 27.04.2022 19:10, Julien Grall wrote:
>> Hi,
>>
>> On 27/04/2022 17:38, osstest service owner wrote:
>>> flight 169781 xen-unstable-smoke real [real]
>>> flight 169785 xen-unstable-smoke real-retest [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/169781/
>>> http://logs.test-lab.xenproject.org/osstest/logs/169785/
>>>
>>> Regressions :-(
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>>    test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 169773
>>
>> Well, I was overly optimistic :(. This now breaks in the ITS code:
>>
>> Apr 27 13:23:14.324831 (XEN) Xen call trace:
>> Apr 27 13:23:14.324855 (XEN)    [<000000000022a678>]
>> alloc_xenheap_pages+0x178/0x194 (PC)
>> Apr 27 13:23:14.336856 (XEN)    [<000000000022a670>]
>> alloc_xenheap_pages+0x170/0x194 (LR)
>> Apr 27 13:23:14.336886 (XEN)    [<0000000000237770>] _xmalloc+0x144/0x294
>> Apr 27 13:23:14.348773 (XEN)    [<00000000002378d4>] _xzalloc+0x14/0x30
>> Apr 27 13:23:14.348808 (XEN)    [<000000000027b4e4>]
>> gicv3_lpi_init_rdist+0x54/0x324
>> Apr 27 13:23:14.348835 (XEN)    [<0000000000279898>]
>> arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46c
>> Apr 27 13:23:14.360799 (XEN)    [<0000000000279bfc>]
>> arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0x20/0x50
>> Apr 27 13:23:14.372796 (XEN)    [<0000000000277054>]
>> gic_init_secondary_cpu+0x18/0x30
>> Apr 27 13:23:14.372829 (XEN)    [<0000000000284518>]
>> start_secondary+0x1a8/0x234
>> Apr 27 13:23:14.372856 (XEN)    [<0000010722aa4200>] 0000010722aa4200
>> Apr 27 13:23:14.384793 (XEN)
>> Apr 27 13:23:14.384823 (XEN)
>> Apr 27 13:23:14.384845 (XEN) ****************************************
>> Apr 27 13:23:14.384869 (XEN) Panic on CPU 2:
>> Apr 27 13:23:14.384891 (XEN) Assertion '!in_irq() &&
>> (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at
>> common/page_alloc.c:2212
>> Apr 27 13:23:14.396805 (XEN) ****************************************
>>
>> The GICv3 LPI code contains a few calls to xmalloc() that will be done
>> while initializing the GIC CPU interface. I don't think we can delay the
>> initialization of the LPI part past local_irq_enable(). So I think we
>> will need to allocate the memory when preparing the CPU.
> 
> Do you have an explanation why the next flight (169800) passed?

The flight 169800 ran on laxtonX (Softiron) which doesn't have a GICv3 ITS.

I thought OSSTest would try to run the next flight on the same HW to 
check heisenbug, but maybe this doesn't happen for the smoke test?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 08:52:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 08:52:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316307.535186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njztD-0004OW-Q6; Thu, 28 Apr 2022 08:52:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316307.535186; Thu, 28 Apr 2022 08:52:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1njztD-0004OP-N4; Thu, 28 Apr 2022 08:52:43 +0000
Received: by outflank-mailman (input) for mailman id 316307;
 Thu, 28 Apr 2022 08:52:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8clo=VG=citrix.com=prvs=110d23c25=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1njztC-0004OE-CE
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 08:52:42 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e6673b8-c6d0-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 10:52:40 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e6673b8-c6d0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651135960;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=nlPhO5icSZyJwWgX0nfuCh5jsNzQNmMCZFNmur7hhFk=;
  b=Ibz0tmbqo89k9cUqFI0XElW158FChZPYMLnFccXWBHi4VGdwAyZQY+Xf
   mIiTsFAVIxBCT9EJi5xNSnD1ZytOAzjTqKGqz84ri2gC4FySEyThOgRof
   dvIeK+ZKZGDywHAjoAa+feLb3Sm/cEBbfWZkCV2Wsj+Wn2va1JSOfpS4/
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70117525
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8uvxQK6T5EyVYIyuZe1CvQxRtETHchMFZxGqfqrLsTDasY5as4F+v
 jccWT+FPvqMNDShKN9xaY+xpE8EuJPXm9BmSwE++ClgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjU1vU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSOWwwvI5fN2940UiV1QhB/IpVL5ebudC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5VBMGMwMU6dC/FJElEFObUMsfn4vSLyQRNWslDN/7YPyHeGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyFvaS1D6E+XKEnfLUkGXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MS1hOGzLfu4kWjL2k4Y29wacMeudJvbGl/v
 rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWuoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvWgnfB0wa51eIGKBj
 KrvVeV5vc470JyCN/IfXm5MI55ykfiI+SrNC5g4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ7rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3DbOuP3GLodJCRb3IRFBiba3LRwVsXrbrCmJb9KsJUZc9HZtJl1RZoplo
IronPort-HdrOrdr: A9a23:r2nDD6DAJ7BUN2XlHelW55DYdb4zR+YMi2TDt3oddfWaSKylfq
 GV7ZAmPHrP4gr5N0tOpTntAse9qBDnhPtICOsqTNSftWDd0QPFEGgL1+DfKlbbak/DH4BmtJ
 uJc8JFeaDN5VoRt7eH3OFveexQv+Vu88qT9JnjJ28Gd3AMV0n5hT0JcTpyFCdNNW97LKt8Lr
 WwzOxdqQGtfHwGB/7LfEXsD4D41qT2fIuNW29/OyIa
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="70117525"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/cet: Support cet=<bool> on the command line
Date: Thu, 28 Apr 2022 09:52:09 +0100
Message-ID: <20220428085209.15327-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

... as a shorthand for setting both suboptions at once.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

I think this wants backporting.  cet=0 is "so obviously" the way to turn off
both that I tried using it to debug a problem.  It's absence was an oversight
of the original CET logic.
---
 docs/misc/xen-command-line.pandoc |  4 +++-
 xen/arch/x86/setup.c              | 15 ++++++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 1dc7e1ca0706..1720cb216824 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -271,7 +271,7 @@ enough. Setting this to a high value may cause boot failure, particularly if
 the NMI watchdog is also enabled.
 
 ### cet
-    = List of [ shstk=<bool>, ibt=<bool> ]
+    = List of [ <bool>, shstk=<bool>, ibt=<bool> ]
 
     Applicability: x86
 
@@ -283,6 +283,8 @@ CET is incompatible with 32bit PV guests.  If any CET sub-options are active,
 they will override the `pv=32` boolean to `false`.  Backwards compatibility
 can be maintained with the pv-shim mechanism.
 
+*   An unqualified boolean is shorthand for setting all suboptions at once.
+
 *   The `shstk=` boolean controls whether Xen uses Shadow Stacks for its own
     protection.
 
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 53a73010e029..090abfd71754 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -117,7 +117,20 @@ static int __init cf_check parse_cet(const char *s)
         if ( !ss )
             ss = strchr(s, '\0');
 
-        if ( (val = parse_boolean("shstk", s, ss)) >= 0 )
+        if ( (val = parse_bool(s, ss)) >= 0 )
+        {
+#ifdef CONFIG_XEN_SHSTK
+            opt_xen_shstk = val;
+#else
+            no_config_param("XEN_SHSTK", "cet", s, ss);
+#endif
+#ifdef CONFIG_XEN_IBT
+            opt_xen_ibt = val;
+#else
+            no_config_param("XEN_IBT", "cet", s, ss);
+#endif
+        }
+        else if ( (val = parse_boolean("shstk", s, ss)) >= 0 )
         {
 #ifdef CONFIG_XEN_SHSTK
             opt_xen_shstk = val;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:09:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:09:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316314.535197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk09G-00060f-8L; Thu, 28 Apr 2022 09:09:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316314.535197; Thu, 28 Apr 2022 09:09:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk09G-00060Y-4Z; Thu, 28 Apr 2022 09:09:18 +0000
Received: by outflank-mailman (input) for mailman id 316314;
 Thu, 28 Apr 2022 09:09:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0mdi=VG=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nk09E-00060S-Ea
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 09:09:16 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0614.outbound.protection.outlook.com
 [2a01:111:f400:fe02::614])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dea3f131-c6d2-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 11:09:13 +0200 (CEST)
Received: from AS9PR06CA0147.eurprd06.prod.outlook.com (2603:10a6:20b:467::19)
 by AM0PR08MB5299.eurprd08.prod.outlook.com (2603:10a6:208:18d::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 28 Apr
 2022 09:09:10 +0000
Received: from VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:467:cafe::fa) by AS9PR06CA0147.outlook.office365.com
 (2603:10a6:20b:467::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend
 Transport; Thu, 28 Apr 2022 09:09:10 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT056.mail.protection.outlook.com (10.152.19.28) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Thu, 28 Apr 2022 09:09:10 +0000
Received: ("Tessian outbound ac9bb5dd84f6:v118");
 Thu, 28 Apr 2022 09:09:09 +0000
Received: from 6385f8487a9e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 06759B73-D107-4AFC-AEAF-13142CFFF3A0.1; 
 Thu, 28 Apr 2022 09:09:02 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6385f8487a9e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 28 Apr 2022 09:09:02 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM0PR08MB4177.eurprd08.prod.outlook.com (2603:10a6:208:132::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 09:09:00 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.021; Thu, 28 Apr 2022
 09:09:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dea3f131-c6d2-11ec-8fc3-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=hnXm77gFIcRR72cR1zBQzaj8L/yIX04bbSIb2IVpVHECdipG8s+jGIKVQvaBKWGxCIUd1m5x68/2NbIgYlu4SQViOlm0NU49uze7GkR6+OpWExs0gjb3CbaNITY3zuHdcHfBgVTqikGgDIgqsl2o7cY2augIEBRhDln2io/P0Wom0YhZ9eLrS/FWlWCioZ/79ewfdzd+TV/aNhCZWsbjB9Qq1/TRJcl52SkLy+6muXiZeIC3NMBul9RXXX9xosr/mMEGiY+SOmo3C96uBD2s+yZ+8LebAStWFW7UVvFsVpj03FS4Czt5HAiuMe479kjILoBukLuDZBEKinDTCoCZKg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7LxXuvm4zJHuHXb7mdtjidzZHZTaVj7hHHBohfoKEBg=;
 b=LFuBlIdpYlLNZ6MdZmtClZ3vvGGuhxzO8n/sL4BQZpT8NyfAqGHnamO03IE+hWaUXYOMckAy1llTisMxCkRs/nhxNQWQAee97lY/uWjOm2GDfurHoAiBkA+CyjLoQ+0Yla0hBLx1bqXHlNnATzL+luiLQKGrgWqicmxw67qnArpT2Ili4fS6HQ8tmdeh5llHYNIvO9ZyNPdeNrYdYzIuPuYoUZeXLlDXfL3avHibCmA0PLFIy/cMkH50Z2jRWEbznIdHjlxtfCry4Y9lR/FOOg3lLMJHual0d87fPt3fibApodw+KPR+nducCLQ8CzFRbL9p04NqjG4mO5qKJGR+nA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7LxXuvm4zJHuHXb7mdtjidzZHZTaVj7hHHBohfoKEBg=;
 b=TYvOnZR2j5EamKIzrAFquQbFtrEUt4x0c3OtcNTFfwrSMze8pUSE/y4Bo+tvxeeulN84T2k49dPaN7bBsSXOLR3xvDu2So0ezXrcvINKDAGexiYE2nVSdArKbDsdWhNlfmojYQSYmeVktgGL91M4nQlJjPW+1VSZsxPTWAxZtMg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7cc576c64a7b302e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IfmnG4u3YynRiGgEjpaTDCwn05ou59hnYlXPXEaEFeH+tICl4XJT9bZQCIp9SVmZXSjoxHkeu+Njjw/b16qLKa+V5CC04za/l+SIngCYPsenbjySy2yV+LflVfUA+5K9LnhY2tqjMbBLdI3u82TAA1H0AsjVwoHAESIj68vpUXSgivvL0eHRVBNjW/hwxbxtU+a4+Jfkjjt9GvGsrMgPPbJKgFYGZJ9oj/1Hq4RkqKqQaTw8AcjhgM9A/NA6vLCjebX+dyk76/N59KVxSAl4O8HdMYKpctPzWgvJ8WIzW3Kl7l2BCGL5wFeQbCi9lBKG3SRQiO7fLBwA6xhH8elhfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7LxXuvm4zJHuHXb7mdtjidzZHZTaVj7hHHBohfoKEBg=;
 b=WnhbBUCgN+SGnbk/KE4S7shqWYAUPCap2diizUM+xqxDTpIYTPuSEM/fQTD48rSF4yu0yGOLomXSFyL1+4pfg0/Nmmj7aW8sFaCSsszrq3VVDUkDUX8LNq+Tygn2RBn01JbM6V6SCFp720TNLqNZ5B5aW+z/YRoknzrFWPHoWBRJVnMT3mO0dzBnCsh5/hL4kcvJGO9KfapeR3krMCBJJlqV8U12NISVFeUk5/HEM5IdSdAPKh/rQKKLJOmJG+MZUsIVID8IeKu306uGuQ2o4Yypt6jGMN+yKlco3XJQ1XtPig7MvR8kKMcnw8TxT7cRunmeWCgk2Sv0lVVOtcxotw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7LxXuvm4zJHuHXb7mdtjidzZHZTaVj7hHHBohfoKEBg=;
 b=TYvOnZR2j5EamKIzrAFquQbFtrEUt4x0c3OtcNTFfwrSMze8pUSE/y4Bo+tvxeeulN84T2k49dPaN7bBsSXOLR3xvDu2So0ezXrcvINKDAGexiYE2nVSdArKbDsdWhNlfmojYQSYmeVktgGL91M4nQlJjPW+1VSZsxPTWAxZtMg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Kevin
 Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <volodymyr_babchuk@epam.com>
Subject: Re: [PATCH v2 1/2] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Thread-Topic: [PATCH v2 1/2] PCI: replace stray uses of PCI_{DEVFN,BDF}2()
Thread-Index: AQHYVYvat6E8kIbOXkmbFmJIRAA5Ka0FFBoA
Date: Thu, 28 Apr 2022 09:09:00 +0000
Message-ID: <EDF88376-47C1-426E-A6ED-A3A6365EFC8E@arm.com>
References: <9a471a5f-497b-1015-8554-68117863f48a@suse.com>
 <6dd6719f-a05d-3f90-95b5-0ce9b5b0a2da@suse.com>
In-Reply-To: <6dd6719f-a05d-3f90-95b5-0ce9b5b0a2da@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.80.82.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 16cc3d9d-9cea-4fcd-7177-08da28f6c1a4
x-ms-traffictypediagnostic:
	AM0PR08MB4177:EE_|VE1EUR03FT056:EE_|AM0PR08MB5299:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB5299DB4DEBD191C8AB95422D9DFD9@AM0PR08MB5299.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 nxXpXofU+m83izspC8tSW7QmK+rnNtfVoIErD0K/LAuRXCDaHoMr6X+G+GlBkqGMPN5p5u1oG/Ro00l+8m1/UhgwBIx/WZHIMyuwTdQQU2NEls295oWAgRA4aIKs0JlfMtgmi+aHc1+Gt0ZTVqJyTyoqz2YTfxo/YUnzdDAbMLptA6L0finIyZ8mboaCIv9h/VUhcDcV3P+pWhMQOicyOTyoiNvwjLZKPvNcaDgoY0dTrnpRk8RzOkCadYLBMu5UhZjz2fnv7Wq1KKlBs/FLaYQY1TgraWDdjTUP2xszdMpCf8wElAD+Rz3O7P5GbjzuLnFqqmHqHJtF49UHvZS/wSdiE4OtSf115eINdoAcxvVobGMz58KKsYYrloLRJ7n5+93B+7SS14ud7lm6VwdQYQe/2kbky1Y8wawmCyj8cNK6bSfHhgcNduEeAtWt6/TCcL3/X/QeLsxxkSZng4ov8oljKppO9Y91Mo9ZrvmAeIRcW1rkmEALMK1TEl9Lkywg7Xg0Zg090oNCQekjtID92OEgHpcC2hazv3p3qRMNBEJg/2t+LlZTOGqvRpWT0FwYv211KvApfQ8QsV/z917ZB7vs2yxtdSIvyGKq7FHSxq3UoHFw+5XcuiXvy+Z5ihSJ5+ZyJGciUeY8zo0us+yx31EUjJgmAk4V0fwIjvX1Wyh1rvnEp8X6U+XIdPgFSJsnVIJHRv/8AvbZ4QdqqQQ9D7j/TS1mwD/KJ3coi5lLjCmMIZZ2ffA2c1oCV59y4kvQ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(8676002)(8936002)(76116006)(7416002)(4326008)(64756008)(91956017)(66476007)(66556008)(6486002)(66946007)(122000001)(5660300002)(508600001)(38100700002)(2616005)(66446008)(71200400001)(54906003)(316002)(26005)(6506007)(6512007)(186003)(6916009)(38070700005)(2906002)(86362001)(53546011)(36756003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <F7C639B44D8DC04EB11E3DF67B1D9A77@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4177
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	18a9cdd3-8e4e-4ae9-95ed-08da28f6bbe4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Nnxkr/mT/iPxFl+RrujWLXLFRPjRv9YE9wsdF5ImdgDOHRuixciaZg762EyDEaAlqAY+Vf0lEQrjp57+GnXxZo+jLsY+zBTtlNt/3XdP4D9qNEomWCsLU68YjXeRBj7igL3EM7WPiTHf6kiEBLIl7RDjp9oX4VnA5rKDU4a6cGF7BsiVQSPhXcAEle6yO3ARTZf03fj92T7qLyQarcrHdYMLoNw89avQvsocUvmk8aQxO2K8drlJxQwHXr7V2jPLD812HqYGoLeAj5ZuMV8cAX2RugZUwAAskaw94sXOjFWOpdVbd+pJd/Rp525VwhDYlA0ykNmmPuK09wLyVEsU5zwgP6NUJDqlFI6vrl2b7kR/ZZGWUUP3tSgs0+py+RbrRomfZWPIHQo+5nYb9c16Z6t3yE7Yd4JifrWQooqWb4+QB4D0hhJYru0Kg9nierMT1yOR1iBAGRSLuJVj4zOoyGe5qeJPYW7jn4mgbJMsppQeYaEi9yi+EwW1Dd/FkU6Wzsos2uuhpvwr9sumI02GU2du4qcIXkvt5bedPDJTV27N/X/GxN9/1DSLCIb+4WIUnVVe04rEBUaosk5znoI17Y37DPXyyyKJ0DO9p5w6vNJ6ESZUyYttR/YiY6OzKiSON7Zn13E6cHnPyelV1yFMQZa/iUWGJ3pHlqAI8qoc41YDf6AQllwX6bdKluZvaakN
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(82310400005)(2906002)(81166007)(54906003)(70206006)(70586007)(356005)(8676002)(316002)(508600001)(4326008)(6862004)(40460700003)(5660300002)(8936002)(86362001)(47076005)(6486002)(53546011)(36860700001)(107886003)(6506007)(33656002)(186003)(6512007)(2616005)(26005)(36756003)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 09:09:10.1098
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 16cc3d9d-9cea-4fcd-7177-08da28f6c1a4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5299

SGkgSmFuLA0KDQo+IE9uIDIxIEFwciAyMDIyLCBhdCAxNToyNiwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IFRoZXJlJ3Mgbm8gZ29vZCByZWFzb24gdG8gdXNl
IHRoZXNlIHdoZW4gd2UgYWxyZWFkeSBoYXZlIGEgcGNpX3NiZGZfdA0KPiB0eXBlIG9iamVjdCBh
dmFpbGFibGUuIFRoaXMgZXh0ZW5kcyB0byB0aGUgdXNlIG9mIFBDSV9CVVMoKSBpbg0KPiBwY2lf
ZWNhbV9tYXBfYnVzKCkgYXMgd2VsbC4NCj4gDQo+IE5vIGNoYW5nZSB0byBnZW5lcmF0ZWQgY29k
ZSAod2l0aCBnY2MxMSBhdCBsZWFzdCwgYW5kIEkgaGF2ZSB0byBhZG1pdA0KPiB0aGF0IEkgZGlk
bid0IGV4cGVjdCBjb21waWxlcnMgdG8gbmVjZXNzYXJpbHkgYmUgYWJsZSB0byBzcG90IHRoZQ0K
PiBvcHRpbWl6YXRpb24gcG90ZW50aWFsIG9uIHRoZSBvcmlnaW5hbCBjb2RlKS4NCj4gDQo+IFNp
Z25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gUmV2aWV3ZWQt
Ynk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBSZXZpZXdlZC1i
eTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQpSZXZpZXdlZC1ieTogQmVydHJh
bmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29tPg0KDQpTb3JyeSBJIG1pc3NlZCBp
dC4NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQoNCj4gLS0tDQo+IE5vdGUgdGhhdCB0aGUgQXJtIGNo
YW5nZXMgYXJlICJibGluZCI6IEkgaGF2ZW4ndCBiZWVuIGFibGUgdG8gc3BvdCBhIHdheQ0KPiB0
byBhdCBsZWFzdCBjb21waWxlIHRlc3QgdGhlIGNoYW5nZXMgdGhlcmU7IHRoZSBjb2RlIGxvb2tz
IHRvIGJlDQo+IGVudGlyZWx5IGRlYWQuDQo+IC0tLQ0KPiB2MjogQXJtIGJ1aWxkIGZpeCAoZm9y
IHRob3NlIHdobyBhY3R1YWxseSBoYXZlIHdheXMgdG8gYnVpbGQgdGhlIEFybQ0KPiAgICBjb2Rl
IGJlaW5nIGNoYW5nZWQgaGVyZSkuDQo+IA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vcGNpL2VjYW0u
Yw0KPiArKysgYi94ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYw0KPiBAQCAtMjgsOCArMjgsNyBAQCB2
b2lkIF9faW9tZW0gKnBjaV9lY2FtX21hcF9idXMoc3RydWN0IHBjDQo+ICAgICAgICAgY29udGFp
bmVyX29mKGJyaWRnZS0+b3BzLCBjb25zdCBzdHJ1Y3QgcGNpX2VjYW1fb3BzLCBwY2lfb3BzKTsN
Cj4gICAgIHVuc2lnbmVkIGludCBkZXZmbl9zaGlmdCA9IG9wcy0+YnVzX3NoaWZ0IC0gODsNCj4g
ICAgIHZvaWQgX19pb21lbSAqYmFzZTsNCj4gLQ0KPiAtICAgIHVuc2lnbmVkIGludCBidXNuID0g
UENJX0JVUyhzYmRmLmJkZik7DQo+ICsgICAgdW5zaWduZWQgaW50IGJ1c24gPSBzYmRmLmJ1czsN
Cj4gDQo+ICAgICBpZiAoIGJ1c24gPCBjZmctPmJ1c25fc3RhcnQgfHwgYnVzbiA+IGNmZy0+YnVz
bl9lbmQgKQ0KPiAgICAgICAgIHJldHVybiBOVUxMOw0KPiBAQCAtMzcsNyArMzYsNyBAQCB2b2lk
IF9faW9tZW0gKnBjaV9lY2FtX21hcF9idXMoc3RydWN0IHBjDQo+ICAgICBidXNuIC09IGNmZy0+
YnVzbl9zdGFydDsNCj4gICAgIGJhc2UgPSBjZmctPndpbiArIChidXNuIDw8IG9wcy0+YnVzX3No
aWZ0KTsNCj4gDQo+IC0gICAgcmV0dXJuIGJhc2UgKyAoUENJX0RFVkZOMihzYmRmLmJkZikgPDwg
ZGV2Zm5fc2hpZnQpICsgd2hlcmU7DQo+ICsgICAgcmV0dXJuIGJhc2UgKyAoc2JkZi5kZXZmbiA8
PCBkZXZmbl9zaGlmdCkgKyB3aGVyZTsNCj4gfQ0KPiANCj4gYm9vbCBfX2luaXQgcGNpX2VjYW1f
bmVlZF9wMm1faHdkb21fbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkLA0KPiAtLS0gYS94ZW4vYXJj
aC94ODYvbXNpLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L21zaS5jDQo+IEBAIC04MzksNyArODM5
LDcgQEAgc3RhdGljIGludCBtc2l4X2NhcGFiaWxpdHlfaW5pdChzdHJ1Y3QgcA0KPiAgICAgICAg
ICAgICBwYnVzID0gZGV2LT5pbmZvLnBoeXNmbi5idXM7DQo+ICAgICAgICAgICAgIHBzbG90ID0g
UENJX1NMT1QoZGV2LT5pbmZvLnBoeXNmbi5kZXZmbik7DQo+ICAgICAgICAgICAgIHBmdW5jID0g
UENJX0ZVTkMoZGV2LT5pbmZvLnBoeXNmbi5kZXZmbik7DQo+IC0gICAgICAgICAgICB2ZiA9IFBD
SV9CREYyKGRldi0+YnVzLCBkZXYtPmRldmZuKTsNCj4gKyAgICAgICAgICAgIHZmID0gZGV2LT5z
YmRmLmJkZjsNCj4gICAgICAgICB9DQo+IA0KPiAgICAgICAgIHRhYmxlX3BhZGRyID0gcmVhZF9w
Y2lfbWVtX2JhcihzZWcsIHBidXMsIHBzbG90LCBwZnVuYywgYmlyLCB2Zik7DQo+IC0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xaW52YWwuYw0KPiArKysgYi94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC92dGQvcWludmFsLmMNCj4gQEAgLTI2Nyw3ICsyNjcsNyBAQCBpbnQgcWludmFs
X2RldmljZV9pb3RsYl9zeW5jKHN0cnVjdCB2dGRfDQo+ICAgICBxaW52YWxfZW50cnktPnEuZGV2
X2lvdGxiX2ludl9kc2MubG8ucmVzXzEgPSAwOw0KPiAgICAgcWludmFsX2VudHJ5LT5xLmRldl9p
b3RsYl9pbnZfZHNjLmxvLm1heF9pbnZzX3BlbmQgPSBwZGV2LT5hdHMucXVldWVfZGVwdGg7DQo+
ICAgICBxaW52YWxfZW50cnktPnEuZGV2X2lvdGxiX2ludl9kc2MubG8ucmVzXzIgPSAwOw0KPiAt
ICAgIHFpbnZhbF9lbnRyeS0+cS5kZXZfaW90bGJfaW52X2RzYy5sby5zaWQgPSBQQ0lfQkRGMihw
ZGV2LT5idXMsIHBkZXYtPmRldmZuKTsNCj4gKyAgICBxaW52YWxfZW50cnktPnEuZGV2X2lvdGxi
X2ludl9kc2MubG8uc2lkID0gcGRldi0+c2JkZi5iZGY7DQo+ICAgICBxaW52YWxfZW50cnktPnEu
ZGV2X2lvdGxiX2ludl9kc2MubG8ucmVzXzMgPSAwOw0KPiANCj4gICAgIHFpbnZhbF9lbnRyeS0+
cS5kZXZfaW90bGJfaW52X2RzYy5oaS5zaXplID0gc2l6ZTsNCj4gDQoNCg==


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:14:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:14:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316321.535208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0E2-0007V7-Uq; Thu, 28 Apr 2022 09:14:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316321.535208; Thu, 28 Apr 2022 09:14:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0E2-0007V0-Rn; Thu, 28 Apr 2022 09:14:14 +0000
Received: by outflank-mailman (input) for mailman id 316321;
 Thu, 28 Apr 2022 09:14:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nk0E0-0007Up-IL
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 09:14:12 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8f3f88c7-c6d3-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 11:14:10 +0200 (CEST)
Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 05:14:07 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by CH0PR03MB6195.namprd03.prod.outlook.com (2603:10b6:610:d2::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 09:14:06 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 09:14:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f3f88c7-c6d3-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651137250;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=IwvRMP6DtAWNEV9kp43n0C7X/1f/5JcMB6GfBpfSERo=;
  b=h9uyAlsjXARnrcff5HfN7CTW+gEAAOjDFpBmeumJmIXLqyOewfSVO68l
   kax2L/sWz2kBPQkLH7p8ZiXoG4Jfx6YLle+vAdoOu2xACpQe9cLPmK6+7
   eWIJlcAtMpMArUmi0mVDn+2S7bNfdg2Yp1mRY5YEVuo57uC7AoF/c6CK9
   A=;
X-IronPort-RemoteIP: 104.47.59.168
X-IronPort-MID: 70001656
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:D5U/Jq7wNHJvHX8jCZFhjQxRtDnGchMFZxGqfqrLsTDasY5as4F+v
 mBLCG2PP/uDZTT2e4gkPdm280lV6seEx99hSAo+riA1Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjU1vU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSccFgwGbeXoN8nCSYCIw1+ZpVN957udC3XXcy7lyUqclPK6tA3VgQaGNNd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfibo4YGjF/chegXdRraT
 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA8ArM+/dpi4TV5BB4juTLAf/5QYaLRN1FpVaoo
 m2c0musV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL
 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJ4Huw88wWA4rLU+xqDB3hCQjMpVTA9nMo/RDhv2
 lrXmdrsXGZrqOfMFyLb8aqIpzSvPyRTNXUFeSIPUQoC5Z/kvZ03iRXMCN1kFcZZk+HIJN05+
 BjSxABWulnZpZdjO3mTlbwfvw+Rmw==
IronPort-HdrOrdr: A9a23:Z2u+VajV1TR0blR5nbnsVdrh63BQXzx13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hoAV7CZniehILMFu1fBOTZslnd8kHFltK1tp
 0QDpSWdueAamSS5PySiGfYLz9J+qj8zEnCv5a6854Cd3AIV0k2hD0JcTpzX3cGMzVuNN4cLt
 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xA+A2frfKVy1zx0eWzRAzfML9n
 XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlXAnEu0KNXsBMSreCtDc6rKWG70srqs
 DFp1MaM8F6+xrqDxOIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8e1U4e
 Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh57D3xHklX6voIRiKprzOSI
 JVfYDhDbdtABinhknizyVSKIfGZAVyIv+EKnJyyfB9nQIm30yR9HFou/D3rk1wiK7VdKM0md
 gsSp4Y8o2mbvVmGJ6VV91xNfdeNAT2MGPxGVPXB2jbP4c6HF+Ig6LLwdwOlZGXkdozvdMPpK
 g=
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="70001656"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=InYlIov7E74igbQIPOkBEAfi6PRKKuFOLLdOQtPM3z8zvBy/HIQivJ3xw9Ds+HpQ11mzeJvs9PxFUiqZ7edxQRwgPjsHKpgnAxRMCxuod/tVkjz9nhGCJ0ETCz7t+q9ICiyIZpcw1s6NjqQ/WeFZ5KzqxfImWlPF4sDs7EQJdGN3mOuVaU1gHaajWGdAjnKWqDLdhIOZc0+Q1gpfWzSz2/3w9ewh+CEJgyDoEzV+XMvwWeWms8x0Rk/IjupgeAz6T6pzLOoeGwlKvSZLkvwqRR8cj8gIUTPw4XzDaN2XR7gBulsUPW7FbeoOZ1dVoJgM/ojNeynVm6OoVoO/vy3Jew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uMPpJobdVmI2GMEWNIesnqX4dCzhlyU70FoN8rwdvNA=;
 b=g2a3JQ/xn3K4joAXALuVdiYcwvs31vqAXY5T9mB9cnfofuc9RPnkYbfeaHaVmVp0QGnxYI+j0n1dUVXwvd7wY+P+KiU+3IHGAeCNb8GXBqlPYI/SwmuQTeN5v+tqaBedmJVH68WUzBfpRw3HUOexzVuWP1X5r/p0IH+AREJI/FQrEROg1a4z8/oFzvElpDvh4/ibSEWxjEY2hZw50KmEMPndVYtpcNOm0AEKIeJYHqqi5l6svWrXIDzZ+bPnt509Lkq4uuJrg0Ea+nVQjI4G/4Zi7DVV/2JbXqwvqhJ7NDhjmAsK4BbQa/TUZhdBRDMobxA8coQO6w6oPSQA5TIejA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uMPpJobdVmI2GMEWNIesnqX4dCzhlyU70FoN8rwdvNA=;
 b=Xy9Q7s3n3SPU9cbymjNMuYAGQ2Hwm52w8gBM+1VfjSlIO1wPP4YQ6AZbGSr1spnomHenmYqkpgUP00yqb0did2WcMugMP+FmvujTjcSn0SkFPukdDbGf77Dfp8vE1/TL+9kKRWtTWM0sxpt70q1z9fbyBpLjG9SngRBRxVq6QY8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>,
	Steffen Einsle <einsle@phptrix.de>
Subject: [PATCH v2] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}
Date: Thu, 28 Apr 2022 11:13:59 +0200
Message-Id: <20220428091359.90431-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 714333d7-120c-4529-eed1-08da28f771f8
X-MS-TrafficTypeDiagnostic: CH0PR03MB6195:EE_
X-Microsoft-Antispam-PRVS:
	<CH0PR03MB61958CE38BD06C64778F2A7E8FFD9@CH0PR03MB6195.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QlvPaZzKC8F1ry4h2Zj0hEYSM/Q+cGKE5+5b+CBTz6Eog7G1jiOvwgErV1XTwKs49AQSi1twW1TNA/s5+XP5PLN2TuNRxeb993jl/zYT71QInCnd+vUO52rnt2fvKcB+5eEBhYOqJqQEolRPmH31tn1o99qRQB/TUNzzzjKIq6IYxgcwxlFYZ1CqOBt4XGJpe2Pz2aP4P0SPRIPAO1GofV7o1HretmE3m7u5j+0jc74XbgqSwV2JbygsGwDmt9kmpGSc/RWI3LPGqCTpRVuUL9m1NuwhDl5X+OT35xMstbw/HejOtMSNPymc80IpoX1tL+BRiQihBn4h9OqNO8wM5w9mt+rvU5Kflo8DrGN652DFmgBJbD5/OfFfCziSAFRhEKnTtfhtb7SL4tm7QhTleyC+LuqKzf8/GRYxqCxzogdUK/Tv5ZbkQruEoKIBiy3kQRGjIgc1VdMYkh0phM9zxHcoUdfuPNKj/Cdty/+hOXGX5F3o5YZt3mAcu6MhKPCVNo2Ns1kQHSBInd9Y0BwMLYOTdG7fyuu7/drVj3S/dtgro9Q5gim8lOf7mAaxgUhTF3Inf8RQQt7IvyIDdB7+N8A5LWooX35nGGvN93ED7yIR79ZjVUTwNc+BXhPCBMun3kbAcC0ZPCC1C5UgIxAtFw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(66946007)(36756003)(5660300002)(186003)(66476007)(316002)(66556008)(83380400001)(8676002)(4326008)(6916009)(8936002)(54906003)(86362001)(2616005)(6486002)(508600001)(38100700002)(82960400001)(6666004)(1076003)(26005)(6512007)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?azZ0NXZyRTVJS0MwVDFwcWFKejRGN1I0ZERpNEVLazYzOE00T2tiRE1OTFc4?=
 =?utf-8?B?NGNKRDJDOFNvaVpIeEpFTXlNYTRVM2ptNXZ0ajBVT1NNeTlUa29Td1I4c0xz?=
 =?utf-8?B?ZnloVjBrbUJVcytmWHI2dnk0U0ErdXhvV1ljRzY0bVpuQnlYQzJKOHVjM1g0?=
 =?utf-8?B?RTRxaTU5N01hK29hRmlJUjIvZU5ZbEplOFZ5UVhRVDl2MlYybTVBWC8xMCs1?=
 =?utf-8?B?UXMweEtSZzhZQXpOUVZWeU9EWVgrZWJ6c2wrU3kxY1UxYklIS2IyUnFwSk9u?=
 =?utf-8?B?dmhTWXAyOHhJcGFTMnF4RXpQYlNONXJlS1ZMSi84TGp2M3YycEV5T0FYOFAr?=
 =?utf-8?B?R1A3Q05HdUVMR3R4QVZhdXBkVUMvRXovWk9nN3ViMjFxMDAwR1dvcE1rMjFB?=
 =?utf-8?B?MGJyTHMwVFZaei95Yjlkcmw5U0JlbVF1eHQyVFRNYXlJd1pGWVk5aXRhbDJh?=
 =?utf-8?B?V0NKL051amtyRmdsR1hSa3VYaFVYRDJUQWdhaDBRWldkakJoZmhOcFVYUkpm?=
 =?utf-8?B?c0ZMQm5JYjRSWVFCbnYrM0RRaGtlZlcwd1JkNDloalhicUI2T0dNdjBZalpj?=
 =?utf-8?B?WXg0Q3FEUnU2WWhjb1Q1Y2p3akxmMFVZVFNad2dsTHBYaEhmbzN6SE8yZ2NJ?=
 =?utf-8?B?a3E1Y3FzYVlSZnZhazNDMkxGZ2JObDEvRytBTzRuYjg4bUhBd2cvUXZFU0M2?=
 =?utf-8?B?K2Z0RVRKNW8xeVp5VmpSb3c3RytsT3IvTjFUdnhZSUpxWVRFUkxBNmt6VTlG?=
 =?utf-8?B?MmUyYTJ3OW5YSVRKSlFLZ1JucCt0TG94WnFFRU84bkY4bEE0cUNTanNqblV4?=
 =?utf-8?B?VzB3UGNHdEh4VVJQSS94cStVT3Ivak8vT2xlWmJtRmc0QVgxNnIwZUV0aTJI?=
 =?utf-8?B?R21DaWkrZlFiTEdyc0Z3Q2ZGVFVWWmlhUTV0MUFpdk00L01Sam1PeWlabFkw?=
 =?utf-8?B?WG1oZC9Hd2ZHV1N3UmJvSWRLMzhIbUhGRXllODdVUWM2OWpzZDZEaThhRjU0?=
 =?utf-8?B?VWlSeUV6WllYd0JESXVkTEQ1NGtyOVVtbkJvZGFRUWV6M3pwMXpkYmZncHhu?=
 =?utf-8?B?ZndMYThUSWVlZTRKd1RyTmVrc0hxOFBFYSs5WmIwV2xjZUNWOEZ2Q1d4TlNr?=
 =?utf-8?B?NGdsRi9EWEpFZHc5Sy9xeFBwSzBab2toakdtVVlQM2FTWU0rcGp0RWJqdGFh?=
 =?utf-8?B?Z01nVkRSVnYxbFNRZkM5Q0N6OTVzZE4xOXJjcHMvc3daTE5Jd211RUdDd1BL?=
 =?utf-8?B?Y3gzZjA1cjZsUlc4QlRyaXdGeFFnalRzRURSNHJWWmVsa2oyQ1dkWDU5a2lr?=
 =?utf-8?B?U3hKb08wTTNwYy9hbysvRXVzWW5DeDdaVWZ1eVVyajlWRWNwanlBQUlxVDhS?=
 =?utf-8?B?eXozYTFQL2U2WE1ScWM3UzAvOE9oRnQ0NDEvWSttMDAwUm14bmtrUU0weEt5?=
 =?utf-8?B?eGM4K21oR1Vzc3h3TEhBYTZ2Vno0SXlKVWNmZ0hIcmwzUnZ5M2FaV1JYNktO?=
 =?utf-8?B?OWFIa09QSG5pNEJYK3JIOXA0enNvcEUxcTFaRU45ejl2bWRzaVZQYk1WSjd3?=
 =?utf-8?B?K2VaZWVSb091TTJEMW83bG41SEoxdkFKbnFDcW5pNGRoQll4WGx2SVpna28y?=
 =?utf-8?B?ZTM2a0F2ZmVxOVREMm5xRUJvbWNKc1FQY0hXcjBYT0Y0WG1wOVR1cTNTTytZ?=
 =?utf-8?B?d25RWDZrRjRhQWtzcE04RzB0MGdrby9vdTJOOWp4NnJOVFRxalFlam5rZHJP?=
 =?utf-8?B?SmtES1hMendkTVhrbUtrUVpieXp0MTVlck1xVUdvRW4xNkRONEhPTFpacjNm?=
 =?utf-8?B?UE5IMkVQZFo3SGhQQ3dmUlpkRWZzZmZCQ1Arayt4bVU1TmhrejlCUUp3Q3c5?=
 =?utf-8?B?NUx1T3JWc2x4dTRsaDhxWUEwMktDOWgvYXJsQnBabFgraXNVN2JKTXJ2Mzll?=
 =?utf-8?B?QWV6MEphb1Fwd0ZmYXNaTE9OV2VLOHEwVFpKU1JGQmhSTDNHZlluWmtUblpT?=
 =?utf-8?B?TFhBZGJDSTByYi9rLzdDbU9jc0lJdnhFTmI5US9ROFp6amxpTFlkM3huSjVu?=
 =?utf-8?B?Qmp0eG82aERRYnQyc1RweDQyRHl3bXNNQXBzbVF4bUlFY1RISVlUNm4zME5G?=
 =?utf-8?B?TTAvTFRzd09obHNGMnc3S042ZFpVSE5DWFlEM2t5UkFFM2tnU3FUeGRSc2xu?=
 =?utf-8?B?d0dEYWw2ejRIVEsvM1dkTlhVQW92eG9YdlhWbXBDN1A5aERGWFI4ZjZBQUJR?=
 =?utf-8?B?MlZON1o3cWJQSmd6ektDMXhnVHdkTlFzSlVsb3JvSlU1NXBFdVQ2bHVjZkp2?=
 =?utf-8?B?VTEyUXdhNkc5NlEwemdYTld2bFcrU1dwR2Z1ZmlZb2RaNWpxVHpyVlZUWkcv?=
 =?utf-8?Q?mImLdMtKhmN5L1Ms=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 714333d7-120c-4529-eed1-08da28f771f8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 09:14:06.1768
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zmmczr8d0axC1js9/iPCJ7XX0563NorCGX+7JVvXak470nREfz8Op7Tj7okKBtwrHhfixfbsauVPi5yq50NVuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6195

Windows Server 2019 Essentials will unconditionally attempt to read
P5_MC_ADDR MSR at boot and throw a BSOD if injected a #GP.

Fix this by mapping MSR_P5_MC_{ADDR,TYPE} to
MSR_IA32_MCi_{ADDR,STATUS}, as reported also done by hardware in Intel
SDM "Mapping of the Pentium Processor Machine-Check Errors to the
Machine-Check Architecture" section.

Reported-by: Steffen Einsle <einsle@phptrix.de>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Implement in vmce_rdmsr.
---
 xen/arch/x86/cpu/mcheck/mce.h        |  5 +++++
 xen/arch/x86/cpu/mcheck/mce_intel.c  | 16 ++++++++++++++++
 xen/arch/x86/cpu/mcheck/vmce.c       |  2 ++
 xen/arch/x86/include/asm/msr-index.h |  3 +++
 xen/arch/x86/msr.c                   |  2 ++
 5 files changed, 28 insertions(+)

diff --git a/xen/arch/x86/cpu/mcheck/mce.h b/xen/arch/x86/cpu/mcheck/mce.h
index 535d0abf8f..7c6df6df7c 100644
--- a/xen/arch/x86/cpu/mcheck/mce.h
+++ b/xen/arch/x86/cpu/mcheck/mce.h
@@ -169,6 +169,11 @@ static inline int mce_vendor_bank_msr(const struct vcpu *v, uint32_t msr)
         if (msr >= MSR_IA32_MC0_CTL2 &&
             msr < MSR_IA32_MCx_CTL2(v->arch.vmce.mcg_cap & MCG_CAP_COUNT) )
             return 1;
+
+    case X86_VENDOR_CENTAUR:
+    case X86_VENDOR_SHANGHAI:
+        if (msr == MSR_P5_MC_ADDR || msr == MSR_P5_MC_TYPE)
+            return 1;
         break;
 
     case X86_VENDOR_AMD:
diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c
index 50198e0c29..63fedff418 100644
--- a/xen/arch/x86/cpu/mcheck/mce_intel.c
+++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
@@ -1008,8 +1008,24 @@ int vmce_intel_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
 
 int vmce_intel_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val)
 {
+    const struct cpuid_policy *cp = v->domain->arch.cpuid;
     unsigned int bank = msr - MSR_IA32_MC0_CTL2;
 
+    switch ( msr )
+    {
+    case MSR_P5_MC_ADDR:
+        /* Bank 0 is used for the 'bank 0 quirk' on older processors. */
+        *val = v->arch.vmce.bank[1].mci_addr;
+        return 1;
+
+    case MSR_P5_MC_TYPE:
+        *val = v->arch.vmce.bank[1].mci_status;
+        return 1;
+    }
+
+    if ( cp->x86_vendor & (X86_VENDOR_CENTAUR | X86_VENDOR_SHANGHAI) )
+        return 0;
+
     if ( bank < GUEST_MC_BANK_NUM )
     {
         *val = v->arch.vmce.bank[bank].mci_ctl2;
diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c
index 458120f9ad..af30811afd 100644
--- a/xen/arch/x86/cpu/mcheck/vmce.c
+++ b/xen/arch/x86/cpu/mcheck/vmce.c
@@ -150,6 +150,8 @@ static int bank_mce_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val)
     default:
         switch ( boot_cpu_data.x86_vendor )
         {
+        case X86_VENDOR_CENTAUR:
+        case X86_VENDOR_SHANGHAI:
         case X86_VENDOR_INTEL:
             ret = vmce_intel_rdmsr(v, msr, val);
             break;
diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h
index 3e038db618..31964b88af 100644
--- a/xen/arch/x86/include/asm/msr-index.h
+++ b/xen/arch/x86/include/asm/msr-index.h
@@ -15,6 +15,9 @@
  * abbreviated name.  Exceptions will be considered on a case-by-case basis.
  */
 
+#define MSR_P5_MC_ADDR                      0
+#define MSR_P5_MC_TYPE                      0x00000001
+
 #define MSR_APIC_BASE                       0x0000001b
 #define  APIC_BASE_BSP                      (_AC(1, ULL) <<  8)
 #define  APIC_BASE_EXTD                     (_AC(1, ULL) << 10)
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index a1e268eea9..d87317e989 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -283,6 +283,8 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
         *val = msrs->misc_features_enables.raw;
         break;
 
+    case MSR_P5_MC_ADDR:
+    case MSR_P5_MC_TYPE:
     case MSR_IA32_MCG_CAP     ... MSR_IA32_MCG_CTL:      /* 0x179 -> 0x17b */
     case MSR_IA32_MCx_CTL2(0) ... MSR_IA32_MCx_CTL2(31): /* 0x280 -> 0x29f */
     case MSR_IA32_MCx_CTL(0)  ... MSR_IA32_MCx_MISC(31): /* 0x400 -> 0x47f */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:19:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:19:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316328.535219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0JW-00089G-K5; Thu, 28 Apr 2022 09:19:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316328.535219; Thu, 28 Apr 2022 09:19:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0JW-000899-GO; Thu, 28 Apr 2022 09:19:54 +0000
Received: by outflank-mailman (input) for mailman id 316328;
 Thu, 28 Apr 2022 09:19:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nk0JV-000893-2C
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 09:19:53 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5aaad1cf-c6d4-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 11:19:51 +0200 (CEST)
Received: from mail-bn7nam10lp2106.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.106])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 05:19:49 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by CO1PR03MB5810.namprd03.prod.outlook.com (2603:10b6:303:6c::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 09:19:43 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 09:19:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5aaad1cf-c6d4-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651137591;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=on4u9PRmHuS6Cy2xkS3WAd4APyM/vnkSOu4pUPJoIDU=;
  b=bfZd83b8hSmejvDeo7VmkOnN6xt+zM9ldwvQamMILCqedvhzcJWp8J76
   Mq+WgMo8a5RucOjgFdnqlQmK1X4zdcrANbPqC98PAgobAeRODNpQ+WsuR
   OoFT5SvCGdUMRLA3PEOTFnWaAU5RiSIYnxuDQC7ZyHvFYa5x21zp5gOYg
   0=;
X-IronPort-RemoteIP: 104.47.70.106
X-IronPort-MID: 70002187
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:BHJ2Baq3ke7rcN+yQu/VXa6cNdBeBmJsZBIvgKrLsJaIsI4StFCzt
 garIBmDMq3eZ2ryfdB2PIm3pkhU7ZOAxoNgTwJv+ChhEiMSp5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 4Oq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBB4nOvc8PayVjLThXMpdBv6Hlf1XmmJnGp6HGWyOEL/RGKmgTZNVd0MAoRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkHhHFp3p4m8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK/fJvuTGDk2Sd1pDUK8iSVYWgTv55xB3I+
 knernXEGSoFYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3C
 WYZ5y4vpqga71GwQ5/2WBjQiGGAlg4RXZxXCeJS1e2W4q/d4gLcDG5bSDdEMYQirJVvHWJs0
 UKVldT0AzApqKeSVX+W6raTq3W1JDQRKmgBIyQDSGPp/uXenW36tTqXJv4LLUJ/poed9e3Yq
 9xSkBUDug==
IronPort-HdrOrdr: A9a23:niXbvqP8KKUcWsBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5
 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa
 Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd
 WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19
 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d
 78bG8=
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="70002187"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g52pR5Nhw6mlLJ4VIEVIBbeUsdKX3waWsLBTbgy+wd7TKHX8RpSkP+r7gsF5kUzgnNSXyFO3R6IGDPTWbc6aL70nKiudfn/JonjHGEf7Xb3CetRwUD1UPz8MttfAgaTDF0x7yyn+JmHxZMBmGqWzmxa71vK1zP5YtFQaOJKFtfxpQrKPOhzVc4BO1Z5SNybbIYdwV5tTs9QgX+RGK5O4DGI0uq++qUqu8SMtw79BWaA+ITel07L8s7LlwwmceE3nNTRcDChUBWgiDOLHBz+EacO4OCGP7F05Sl56o8cCoiBK10d6YF3LWS0X2YAgOz3PzSUBR5/FCwCLSbxciSuNKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hiubOYqk7kvuPVAlc3nTOPMPjLmvCQko52ntTUwl2Gw=;
 b=Fg1HFHh4w0dvdy5a5rwlQ1vwAG63wk8C9+gKhI2/l/TvtxIPxy6gT7jCrZ10iiPp8zaQId+Gb5kH4Q3ByGtBDTnMMC7Essd89J6nAejbnC52xDJVSrlWTz1L5pU3/NLDt+zpFCMCjfuFBU68lSvPhEkt7DQydN6eFaYPo+iQtF1L7/0MQXVnE1YnFaOu2ZMZys9Quir02xTggrwYKqujl8hYoRV2KFgkah0HAYYdSi6XVmQhOWtTthtXg6h4qtiuZVH/302CbUL+FQN7FVLS4eoXAU4kfiKzZjo6JpeCTknIQYafdATJoX2MlEpgWqDEyXTD7FQRF0xJrRfcOE/oeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hiubOYqk7kvuPVAlc3nTOPMPjLmvCQko52ntTUwl2Gw=;
 b=lZ01VX7+an4j7AGmH2dEzhY9wlC10iaZ2gojvf+eXRKHdKMUdF2XAwWB901HIkPIpdcmhMHfN5DAqQiBb3APNPdwj9/9I0uVzmyM2FlaQqY1pi6clFuoOsK1dcpAeFPR9GimmWGv71HWc2Jx7qz5TOnC57oucMW3f4s8XSTWBOw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 28 Apr 2022 11:19:38 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <JBeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/cet: Support cet=<bool> on the command line
Message-ID: <YmpcKmecShU2Mokz@Air-de-Roger>
References: <20220428085209.15327-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220428085209.15327-1-andrew.cooper3@citrix.com>
X-ClientProxiedBy: MR1P264CA0123.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:50::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 77a8c88d-a405-4bf6-d95f-08da28f83ae8
X-MS-TrafficTypeDiagnostic: CO1PR03MB5810:EE_
X-Microsoft-Antispam-PRVS:
	<CO1PR03MB58101EF4311CC23A9F6AA1408FFD9@CO1PR03MB5810.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F3ejNIThrnJn6RB815EPN1PFarDbFXDf5IAz/nC3WEOFv+9bvLnrCe3IO3hi0AKPQycqGGlgXBXNRx+i+pzs3pHaDnkew+D5sBIwUF8TjnEzFnz9uLb43iDnMIfB8VzGQQQ/pnnvjNWkLeHLuHUlJfDB1C1PyHMdQFVk8ICTtwy7ZH2Xn8aLxYBpCz2hI1fhFLS8ghzctQHFnGy7gKlZTS9ROtlOkYXQDc1zviK8Rn3iYnfEJaBmlF04r9RhoqSn7a4xbKhcbwCV040X0zBuytpRyD+oS6PBFx3rmreshDdyKD4oqG3EA9CTe6c8vtuEGOAQKxTr2CdLJMr/+/bNvhdUfYS6iWK0mmZLJKMAT1lg0tf9zHzeZ5azm07W+SSuKfC6yJEYdRJQVAerA/1RqKBiyoCOnR5ZADSGSF9y77DYd8vAXTRIe3UyJJP5bnSGzVz84Zvy7E+XmV7cPYmA4XVEipXlO99j3KCvCA39XO61e0zgJ/l6h5bZ/ySdJGKwbq9sn1NZA06VFSMLJ6OHtv6TKdwZ40j+rkJdDjfLEZomsdyEtMxSVxizZ5krikbB/5uylmYDgDxCQ6Qrh+u8zWKiDRBcYzrd3OjbE7Ldbar1R4AJLybC3eWny+PrD3YFn+vzEAXU68QrLq3RKUC/HQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(5660300002)(66476007)(508600001)(66556008)(66946007)(8936002)(4326008)(8676002)(86362001)(9686003)(6512007)(54906003)(26005)(186003)(6862004)(82960400001)(2906002)(38100700002)(4744005)(6666004)(33716001)(6506007)(316002)(6636002)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T3lFL29xUlJHWk5aK2Z6UWpzNGFOeGpMd0NlRXZQVUxBSFM2WEtMUURzUjNk?=
 =?utf-8?B?cDh0QWJpWndCZUJOZ1lkU3d2OEowTmxHc2RYOUtseWtLNjYvd3BxSUlUVHFp?=
 =?utf-8?B?blNJVndYdWViMkZXMnJrZ0VOeTNlb3J0Qnp3U3ZHa3JqNUJhNmlnMk1kM0RZ?=
 =?utf-8?B?RGtFS0QrMVlhUURxUmEvV21yeTBkNFV0eEUwajdXelpuckF3TFpvYno1ZThx?=
 =?utf-8?B?RVRYVmluZ0pIZ21qaExsNFU2OXNTRkJmYmxaaE42Skkwb3EzVlI2dFYxbldt?=
 =?utf-8?B?dEN5bkNqN3M4RHJCWjNReWNNcDJPMzd2WVJLanFaY0pOS2ZrK2xaUmdmeVRu?=
 =?utf-8?B?dVBtc013NGhjZVFoZVpEQ0txODRncUFvTWVjbG1SZVl6eUk1aHVaUlM5Qkxa?=
 =?utf-8?B?S1FoVzZrTXViZFh5QnQ5UEVIN0ljUmFrVm9ncy80WldKT294Zk5BSGZESzla?=
 =?utf-8?B?RHgzUmJzRlB6QlJONkZZSTZFRFc3WHkrTUpEYTJaV3NRSERXOWMyNHlHRWVJ?=
 =?utf-8?B?bFRVVGxLV0I4a0pGaWNScXBnZjg1RWUxaXYrMjNvSGtvelI4NEZlQVNKSUNt?=
 =?utf-8?B?NUt5MTlZZWwwdXQvOW4vWVZ6OCtVQlptTmtETDJxZVhEWWVMYktxeHF3VDB0?=
 =?utf-8?B?cUxib29zd2IvdGJkSFg2OWpwZDRjRXFNdVBJZksyWWlRd0M2aVdkeCtOOWU2?=
 =?utf-8?B?NjcrOUxpVm0zcTIxUDNlZS9uR2JYeTZLd0YrcXE4dG82cEQxNTNJNUlBQ0tl?=
 =?utf-8?B?eGJ4VFpUSE9USEZ4cS9sZGNoMyt4M2lXblh6WE5Qd1QvajJLbzVlTGMwL1Nj?=
 =?utf-8?B?QnkyN0RUTGhvRzVvMlArazFpck1xOThXZit6TFBlR2NRZkF6UUJ6VXlac3oz?=
 =?utf-8?B?bHkxQlZmeHVDZy9sRHp3WmJ5ckF6U3FWUllFM3ZmcjhmQVd4YS9sbFNwOHRQ?=
 =?utf-8?B?by8zUTFqdFlWbVg2R1IydGRyY0k2UmxldTFtSlN6N21QMGI3c2x5cUI5dkd4?=
 =?utf-8?B?UGhJZmVsZTJ5djBuWUFESW1qR0Q1M1NkWVhHRHZZQ2EwVjYrWmcxOS9kYTNS?=
 =?utf-8?B?QVIrWjNTWTZXamhUdERSOElWaU9jTEZZdFQ4SkpDeEMyWGJRakltYSs4QVBC?=
 =?utf-8?B?NU1DY2FjRitBL05zaWpBNnFwR0ZUUUNJTFg2Qkh3SXU4NFRBVjFBQU5pZ2x3?=
 =?utf-8?B?ZnpRbmJMTVRzTG00Qzljd3YrY2lKMFpYOTBtV0NHc0ZwMDdwOHBRSFVNcGRK?=
 =?utf-8?B?MjhTR0VDZ0orZCtZNktjRW84RHR3aUwvNmZDWGgzcjViU1ZSd2laLzhFSTJj?=
 =?utf-8?B?Wm5LcEI2R0YwSlFESml0MEF3bGJhRDJIMzA3OEVBdGJrRUtweDBwU0Nhb1Bh?=
 =?utf-8?B?QVVTVWIzd3YvZlRJVkxLeWFpNDV3RVdtcjZXQXgzaWtOZGQvN1ZjM3RmQ1Ay?=
 =?utf-8?B?MmtUamk5UjFNQzBwMG5hZi9vaGtKNWNJVE9rckN6V2J3aC85ZmFrSGxuZllS?=
 =?utf-8?B?d2F4SkVGc2NFbTJZbTNoVElUeStIMlZaREFkT0FMNFhLR0RML05Eb1NMQVZy?=
 =?utf-8?B?TFhXci81NmlqVjQxNzFwT2ZteHgyZCtJS2hmY3lUN2pjOHVla3NwbnRaNUho?=
 =?utf-8?B?SkU2VFZiY24yVzdXSTNKU3p2bDFST2swZmw5WHExMU1pMDNLeSt1VDVXUUtW?=
 =?utf-8?B?bzV5Y1dPSEw5RlZScDZ0QmFCb3BjL1VsbmxpbjlsRHJGR1hvaGg1eWNEd1I1?=
 =?utf-8?B?M1lGeE50K3dOMXFNQnB0Zk5jTHRraHZRWUFVQzYvSWx5cXdpbXlGY3RaZUl0?=
 =?utf-8?B?bm03UVQrUUVUNEdXb085ZVZISmswOFdFTVFqVjJ5VjFxcWovNDlSSXZzSyt6?=
 =?utf-8?B?QzM3bmsvRWhTdXFMQXBYQ3FGdUEzcHNkZ1NqQ0h6ajNkUFZvL01GSWhTSW9M?=
 =?utf-8?B?ZFVLZVlFaW9xbUdVQWUwcjdpMlNjZjlMTW11K1hOdk9EYnYveGVEL0VHaVRK?=
 =?utf-8?B?ZTJyZHV4cVFZYVpFRk9KTDhzbmlISzRISzFNcUFoTkhRSDErVlhGYzdDZDkv?=
 =?utf-8?B?YmU5R29HV09LOFM4b1FqOWYvMFFadzkyeHlNQWF2ZmhFeGYrOXJMdUJQZmdo?=
 =?utf-8?B?U2t2WkYyOEMvdTdPV3lSeW5JOG5WUXNOaVZOVjR1aUplZ2RobllmYTh6MVVD?=
 =?utf-8?B?OHV3Tlp4dkdBeGZlSUVyRTRDOWdOcXhuWmhFblhzSk8yVWZSWGFiRDlLMTBI?=
 =?utf-8?B?cTl3TXNQNUdwdm1kZjNGUjdZZ0RTTHFERVVaTlQ5VzdaSmVKanpnYnFKNFBv?=
 =?utf-8?B?RXhrcFRuYnVRL3hBWWVhUWY3Z1JzOUt1QXk0cUF5a3V2dHJJN2tRZkxMMFh3?=
 =?utf-8?Q?IS2/kBySmUIW892I=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77a8c88d-a405-4bf6-d95f-08da28f83ae8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 09:19:43.2779
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /M3Y1xV3og7XYvKB+ES3vjkqCRUNl4hQEwato7Lmfx95t8dK5632Evrd82CiaQ0C2fEbJjrk3sUG7yPHWO2wTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5810

On Thu, Apr 28, 2022 at 09:52:09AM +0100, Andrew Cooper wrote:
> ... as a shorthand for setting both suboptions at once.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

>From the implementation below we would support settings like:

cet=true,shstk=false

Which I think it's indented?  Have a global default for all options,
set some to a different value.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:39:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:39:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316337.535229 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0cI-000290-7b; Thu, 28 Apr 2022 09:39:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316337.535229; Thu, 28 Apr 2022 09:39:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0cI-00028t-4U; Thu, 28 Apr 2022 09:39:18 +0000
Received: by outflank-mailman (input) for mailman id 316337;
 Thu, 28 Apr 2022 09:39:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk0cG-00028j-UZ; Thu, 28 Apr 2022 09:39:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk0cG-0002va-QQ; Thu, 28 Apr 2022 09:39:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk0cG-0003J3-Ar; Thu, 28 Apr 2022 09:39:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk0cG-000663-AL; Thu, 28 Apr 2022 09:39:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DoQNGvWDV7VDSBjbwJSa/ZVPd/mk+/emr0QgKtT4mQA=; b=iEvWDZf+aZ9QSDbZ9ZZLxXj6+g
	LUa9g9Km+dGcZTgZB8hF8WqAcPD5sM7lEYZzY7fJFQpNrqBkDQ/np2iPuniqQ5oChRopm/WDbckk0
	1Olf0nZiUFMw4MD4kTzU9ceY157bBfOf/ys+SZgUHZ0RImLvkbi5RFlU0KbFJciZyzCo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169792-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169792: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e4d8a29997731b3bb14059024b24df9f784288d0
X-Osstest-Versions-That:
    linux=46cf2c613f4b10eb12f749207b0fd2c1bfae3088
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 09:39:16 +0000

flight 169792 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169792/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169767
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169767
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169767
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169767
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169767
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169767
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169767
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169767
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                e4d8a29997731b3bb14059024b24df9f784288d0
baseline version:
 linux                46cf2c613f4b10eb12f749207b0fd2c1bfae3088

Last test of basis   169767  2022-04-27 04:01:30 Z    1 days
Testing same since   169792  2022-04-27 19:09:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chuanhong Guo <gch981213@gmail.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Denis Efremov <efremov@linux.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Md Sadre Alam <quic_mdalam@quicinc.com>
  Miaoqian Lin <linmq006@gmail.com>
  Mikulas Patocka <mpatocka@redhat.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Oleksandr Ocheretnyi <oocheret@cisco.com>
  Sricharan R <quic_srichara@quicinc.com>
  Willy Tarreau <w@1wt.eu>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   46cf2c613f4b..e4d8a2999773  e4d8a29997731b3bb14059024b24df9f784288d0 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:43:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:43:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316346.535240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0gk-0003eN-Tx; Thu, 28 Apr 2022 09:43:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316346.535240; Thu, 28 Apr 2022 09:43:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0gk-0003eG-Qx; Thu, 28 Apr 2022 09:43:54 +0000
Received: by outflank-mailman (input) for mailman id 316346;
 Thu, 28 Apr 2022 09:43:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nk0gj-0003eA-R2
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 09:43:53 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b527977b-c6d7-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 11:43:52 +0200 (CEST)
Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 05:43:49 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SA1PR03MB6434.namprd03.prod.outlook.com (2603:10b6:806:1c1::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 09:43:45 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 09:43:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b527977b-c6d7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651139032;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=nY/fhfXoEN6pk13iNtnkZanHjQ+cKzCxEV70lvK196Y=;
  b=bGCVrCVqQm7vK3X006tq3ZXFuFrjEuCGh/nHdyWe1xwVI2XSIghcUpWD
   poPh4qQEidWhRmi+OBnnTBSj0+x7JQwRos7ZqJl8Yq4Za7aQUJ0vLHCvZ
   dZEcg+FnsrZ9hGrTXjt9QaM2JiklQlSjKNk1mHrqA+PajhoCDW5aVx+UA
   c=;
X-IronPort-RemoteIP: 104.47.66.42
X-IronPort-MID: 70121105
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:UbBr4KKIwBX8b7a4FE+RzJQlxSXFcZb7ZxGr2PjKsXjdYENS1TcAx
 2YWCm6EOK3eMDCkc9B0aoy2pEoHupDTzoNjTldlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tQ42YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MVo7ZrrEB8RBaPRsfkESygGLCVGGIQTrdcrIVDn2SCS52vvViK2htBRVgQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgH86FH/+iCdxwhV/cguhUGvnTf
 YwBYCdHZxXceRxffFwQDfrSmc/33iClKmQA9Tp5o4JuuEvL8BR3iYPpD/b5S+eze5hkk2WX8
 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1a3E62StjwWTWorXjCuQQTM/JLCPEz4gyJzqvS4i6aC3ICQzoHb8Yp3OcpQRQ62
 1nPmMnmbQGDq5WQQHOZs7KL9zW7PHFPKXdYPXNeCwwY/9PkvYc/yArVScpuG7K0iduzHizsx
 zeNr241gLB7YdM36phXNGvv21qEzqUlhCZvjukLdgpJNj9EWbM=
IronPort-HdrOrdr: A9a23:nVJblqGeR2sCbn2gpLqFepHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH
 PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w
 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q
 6xGm9liQ==
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="70121105"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EkRtr4zK6erKBtg/jrjMGK0l9YX8o5ymZUVsw4pLqvr0w+YJBtG4Cc7RUCN/ZjUwqP2vHH0t07OvS6lXnyKf8OjyqE7zYfswgPDkiN9B27TE/xClCdwktq+PZ2CwieQF3JKZI+ajehW311ei+OhiNkQ9dSOQxn8/laO8yegukR2zoro8CVfYIlC8wbYsn21Oix8ZGVxhpfh5a5ya7xSQ+p8BQqPNtdLdw4tkUPfZf+5GzQDg99V2Rjza+pPdJ7n8HSX/9mDj4IiQaTqXI9/EoMTu3Zb0P8Qgo7NHaA0YYZbZI96aRqn7Smh97f0deoJVyXan/gPMh4gECmqF5WU5Eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8gWzR/IKeJIEeqZ3Yxc4xmIEDHyeoCQY5xg7JAqb7Pw=;
 b=bTUwQYm7vUA0v9ptEt9jxl7o7h+qZ/mp/+FulKUI/FRhT/nMqapNMxP8JNo0pDHnOs8/Or0dw/W1PHnZBkC5uZlxuFumtD9/symjVsiaXQ8vQzxZIh1G89QNLye+p8HxK/sGRS1PPFoFfjX7pkKYDLYpj4nPMX0Ipxmt/vdzQAo/9WrTTOnKgeYRNyvfRQEm6brLJkMMbad42ijJjT/vrHI+iIT2TZsersvog6mwKU9pdIVdwT2Ufdz/3vAMEB+bEWFaf+Z65MR/8hP9vaUqs5EazR1MiUVxJCtQNhAJiabKdwDp9uwerUa+N5wn4VQ7I4e9Um0EUf9nLiY0RbD15Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8gWzR/IKeJIEeqZ3Yxc4xmIEDHyeoCQY5xg7JAqb7Pw=;
 b=nhPfexJPspE/OTtgJPUQEJDVDMWYQIlbuQgRYzHvASdw8xf/N9RNOXKof8l7iya8VlkvYzZ7HGzxbKVQ1inOvgrOXxKO2z6i+OZ9FZia7znIHp+KSScyGoNfF80QcMc0ufts/9VzFiAusQV8fR/BUB1Fyrs6rHEuCoWZHodViQI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 28 Apr 2022 11:43:39 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3] codeql: add support for analyzing C, Python and Go
Message-ID: <Ymphy9ZGelmpOEJc@Air-de-Roger>
References: <20220323101856.35992-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220323101856.35992-1-roger.pau@citrix.com>
X-ClientProxiedBy: MR2P264CA0096.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::36) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4412742f-4c7e-4959-7060-08da28fb9645
X-MS-TrafficTypeDiagnostic: SA1PR03MB6434:EE_
X-Microsoft-Antispam-PRVS:
	<SA1PR03MB6434759CEA718DB2015259A18FFD9@SA1PR03MB6434.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ch3fmu1UozIhrwF2q79y8C/wJpPLgYG6JG7gF0oLn3SAp9F+4eN9qOnCdlMN7H4osE34tUwAhiu4B4UI5Y3MflUf2uHt9L89zfyf1y+o6PS48nUEC+FjyxWZgk/aKZmha6ivdvkopkdicYwyH1yyqfXzLXUfDsR1BhZeudoZSpzUV50IMtkAJan3EhucFjDqSkTbtFhr5jp8zv+cy2V0CM9QLwA0j/VcgJEbsjUaB8A2fXSAMzJKEbqRxGhS6ieEPXsWGjos07r8TKp/OZnMXEuznX1hdSgJLXbNxc/QlXxBLlcCfML3hY0dXaIYEEGsBqb4E8ZOSh6ZhbnoRV4H5J7OIO2P8FS0PpPtswdgnrKfm6Ez1Qpu90rU1VFQyBCO/23+gwd1ryAh+eoxhPcXaGyhsBfk375e0QYrXEk/ynpQpfmUoK89eh87Ck/aN1Y/aUUEx/OHBLfMC+qRfgz0Ly+c/vX3ts8eq7S09FS0VcLc1gEjaBPNqDPRO+3M/DL6DxXQEDlgKuQLtSeciGEA6jt25zhiLwIR0q2QyrAxErzrQu/BFM5DZ0Cqdkd03gDcNtQ3PGCfsSPpK3xhD6uDw4buj0Fplue5h21uD3m3zgzf9LPmmHsGpIxSfqUgW/dOusj1hGRzrO/YyUt+2fChdQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(6916009)(83380400001)(86362001)(6506007)(508600001)(85182001)(6486002)(186003)(316002)(2906002)(66946007)(8676002)(4326008)(82960400001)(6666004)(38100700002)(33716001)(66476007)(66556008)(9686003)(26005)(6512007)(8936002)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0tjdEVRVjRkNjN5MUZCTEdXTnQ0VzlQbGZqYUFYWkpWRVMzR2JyVUY5bEYw?=
 =?utf-8?B?R3p6YWM5cDlSZWtuWC82ZVJuem5qVTBkTXg5dDNYZTVPY1diRktQb2JrUlhQ?=
 =?utf-8?B?SVUzS0Ixc2NKZVpvcWxJYTYwMzM4MkZ1V0R4UmVnRTdLRm45YXBaWVRPMU9O?=
 =?utf-8?B?WXN0akp2c0o0dmJYK2hGdDkzRVA2bE9TQWZRWTlmRjVqdmZLZTRBV0JEMVdH?=
 =?utf-8?B?Z1BHaE9TdWkwaEVjV1pRRlh6YzRzSTdoUVQ5dGxIcndvMU94Q0dKM0o2cXly?=
 =?utf-8?B?NGszeXYrYm9Seld4aVh6MGY0c1RRWVJBd2J0c2hWT1EzN1RBbzhSRCtGajF1?=
 =?utf-8?B?Mlh4Wk9tb0lmNVR5S09zNlJ0L3NXY3llQ3FDVTRwUkVGT1VoQVByODZuMkNE?=
 =?utf-8?B?TUtESUthckdNYktMWWtGTU1FSlFpUHBoTlB0UDdXS2U5aUZST2tXd0paUmZV?=
 =?utf-8?B?clFwbkpBSXpuemNHRWx4ZCttejVQUUcxZTlFZGg4U2p5empqRjF1Y2dKaVZP?=
 =?utf-8?B?Q011WHdaQUczWmh2ZldBUm8vQ053aEc4bTJRdWUzRXJjVkVvUVp3OEUvYXQw?=
 =?utf-8?B?MTkrNlZQUHpTVCszVWpDZjNHWFlCRmdWSUtFY3FzVnJKOXVNaEd2L2NCRml0?=
 =?utf-8?B?NWZESnR4Tm5sUGdabC9ubWROeUxONi8yNXdNN0NROFprU1NuK09UVTQ4RjNU?=
 =?utf-8?B?V1VocGdCZ0dPWDlQQ2hBV1plbU1qeTJ0RFlZbkIwS0x1NnhpbVdEMGF1YUdV?=
 =?utf-8?B?S05aVWM3eUUyVVRKWEdEWlFETHVRSk0wNnR2cWdvKzdHQ3dJdGFpQVpXanJh?=
 =?utf-8?B?ak0zczFFbHhlTFB4T2tvSUE2UGZmZkdZb1gvZDJmbC9qS2h1RVZ0ckxXNUdE?=
 =?utf-8?B?OUxtdmh5VkJCMFJ5QkNscVprQ09vaGEvb3hmL1kzQlVaUjI1WktkWU5jRUZv?=
 =?utf-8?B?WlFCazlxZU85WWMyOG5uaWsrRU1scTBIOVZQVUJOa0Y3UjRQVTFnSkxwbDEv?=
 =?utf-8?B?SFJid2ZTN01VVTBGVFcvcmkzMW1BbHpyL1JQY2NOaGN6WUx3RDlPcHdieWdS?=
 =?utf-8?B?SHlxeGJSOSsydlFqby9QTmNuWEdvQ08vWERUb0V0Q1pHd1BjSkJxVXBFREUz?=
 =?utf-8?B?YWFzdzdwWmk5eGhUUEtKYlFwMUFWNkJHeDh5TU54aWNXcTFSd01nNGdnVEdq?=
 =?utf-8?B?YXZqeEpHOXp1b21sUlZYc0ZSamxFMFB2dWVDbjZmalhGQjV5UkJxSHBpUHFY?=
 =?utf-8?B?aUhWelpMa09HVmRkMjR4S2x5eHpMSTR6bnZIKzNOK2xDTW5IcnljU3V5ak9L?=
 =?utf-8?B?dkVzZG13b25LVmhyNmtmQ1dyOFJsWlFiT01Bb0FsZ2R0dGpRN0I2RWxTVkR5?=
 =?utf-8?B?WXlzbnUwNTBpVjdqNWpDVUppL3VwTDZTZjc0SkZmaFkvQlpIVlRxZm9pcVY5?=
 =?utf-8?B?cDNaQ0M2dE90MjhMYXVQSkZOSVhEMkJpbGRQM3VyaE1ZSG9aQlk2R1RFOXgw?=
 =?utf-8?B?MTNTb2wvTmVYaUVCeCtRQUxZQ01QS1hXazJMRktmZ0pJSHJ1R0hvZE5PaVQy?=
 =?utf-8?B?ejF2cFJ4MkkyRG5saUsxdmVlSlE0Nkp2ZDhILytpbFJsMzVpRk1OMEZGWjRY?=
 =?utf-8?B?NTlGbW1pL2UvNXFpSEFFMmsrdlBqVGhGTHdlVk5DT0VyQmU2VFVML2lEZzRw?=
 =?utf-8?B?dHJxZGJpZ2ltNVpMRUtYOFU2Y0tJZTR0RjV1TllmRkRhZ0s0M21aVHhYMHBN?=
 =?utf-8?B?LyttQUh5MU43a01GNlFSN21EY0ZSSDk4Qy9IN0hDZnZ0REdhekdPdUJUWU5v?=
 =?utf-8?B?M3RCSDhDTTJXT0NBU3NkNXhCUkw1OWpuNk1JTmlTUm01V2RYMXA1WENWM09G?=
 =?utf-8?B?dkxicHplSzZxRmJlOTVtOVVJOFczQVhJUkk4cWswRk1YdmFtdHRHSUR6SVJR?=
 =?utf-8?B?Rld0MVBCMTBXeVZQalI4YnMxdVNtVzU4dWkyQU0vSDZTeWlMaTJWUkpBclNB?=
 =?utf-8?B?WllXODQ4MjQ4ZEFCNjc0aHMxaW03aExjL0NZR1ppZ096TCtKTVZPeisrM0cw?=
 =?utf-8?B?cDBoR0NHcktlWTdSUjhZT2ZtN21RZGUweTRUbm5qRFprZEsyOVJOVXpVSEx3?=
 =?utf-8?B?YnhDR21USU9MT1dyOVhEdzVNL1BheWwzL01DeUJxaTNQamlUZTBOZXRzQjdZ?=
 =?utf-8?B?cnQxajRlYnUvaDZvdGRpTlR1aVhHc09abXQxZFYxVGFlOTZZT2F6S25sNTQx?=
 =?utf-8?B?bVl4NElraW9HNUtSeG5hQ0ZhaXN2NzRvbXoyd1BjT01FdG4vMlFFOE1aZ3lz?=
 =?utf-8?B?enI2cDdJTThOL3RMZWsyQ1B3LzdWRmFwZGtrMk9ncmdiVTJBTXFmcWZzWTIw?=
 =?utf-8?Q?AKHIm4A1H9+eZm9k=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4412742f-4c7e-4959-7060-08da28fb9645
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 09:43:45.2193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DSkihxWsyUuhstmE+HrbBdC5MFN16v3V0m3qyiDDQXmEhDZk7pvY7NdLx2xg6r7SBunIA7oDZ04HrS9ipgJ1tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6434

Ping?

On Wed, Mar 23, 2022 at 11:18:56AM +0100, Roger Pau Monne wrote:
> Introduce CodeQL support for Xen and analyze the C, Python and Go
> files.
> 
> Note than when analyzing Python or Go we avoid building the hypervisor
> and only build the tools.
> 
> Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Changes since v2:
>  - Remove explicit 'staging' branch checkout.
>  - Remove explicit query.
>  - Remove ignored paths.
>  - Remove 'on schedule' trigger, or else it would be run against the
>    master branch instead of staging.
> 
> Changes since v1:
>  - Rename to note it's x86 specific right now.
>  - Merge the ignored path patch.
> ---
>  .github/workflows/codeql-x86.yml | 54 ++++++++++++++++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 .github/workflows/codeql-x86.yml
> 
> diff --git a/.github/workflows/codeql-x86.yml b/.github/workflows/codeql-x86.yml
> new file mode 100644
> index 0000000000..6ddd445c79
> --- /dev/null
> +++ b/.github/workflows/codeql-x86.yml
> @@ -0,0 +1,54 @@
> +name: CodeQL x86
> +
> +on:
> +  workflow_dispatch:
> +  push:
> +    branches: [staging]
> +
> +jobs:
> +  analyse:
> +
> +    strategy:
> +      matrix:
> +        language: [ 'cpp', 'python', 'go' ]
> +
> +    runs-on: ubuntu-latest
> +
> +    steps:
> +    - name: Install build dependencies
> +      run: |
> +        sudo apt-get install -y wget git \
> +          libbz2-dev build-essential \
> +          zlib1g-dev libncurses5-dev iasl \
> +          libbz2-dev e2fslibs-dev uuid-dev libyajl-dev \
> +          autoconf libtool liblzma-dev \
> +          python3-dev golang python-dev libsystemd-dev
> +
> +    - uses: actions/checkout@v2
> +
> +    - name: Configure Xen
> +      run: |
> +        ./configure --with-system-qemu=/bin/true \
> +                    --with-system-seabios=/bin/true \
> +                    --with-system-ovmf=/bin/true
> +
> +    - name: Pre build stuff
> +      run: |
> +        make -j`nproc` mini-os-dir
> +
> +    - uses: github/codeql-action/init@v1
> +      with:
> +        languages: ${{matrix.language}}
> +
> +    - if: matrix.language == 'cpp'
> +      name: Full Build
> +      run: |
> +        make -j`nproc` build-xen build-tools
> +        make -j`nproc` -C extras/mini-os/
> +
> +    - if: matrix.language == 'python' || matrix.language == 'go'
> +      name: Tools Build
> +      run: |
> +        make -j`nproc` build-tools
> +
> +    - uses: github/codeql-action/analyze@v1
> -- 
> 2.35.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:46:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:46:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316352.535252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0jR-0004Gs-B7; Thu, 28 Apr 2022 09:46:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316352.535252; Thu, 28 Apr 2022 09:46:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0jR-0004Gl-89; Thu, 28 Apr 2022 09:46:41 +0000
Received: by outflank-mailman (input) for mailman id 316352;
 Thu, 28 Apr 2022 09:46:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dcPN=VG=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nk0jQ-0004Gf-FN
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 09:46:40 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 19192d57-c6d8-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 11:46:38 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 510141474;
 Thu, 28 Apr 2022 02:46:37 -0700 (PDT)
Received: from e129167.arm.com (unknown [10.57.12.53])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4A353F774;
 Thu, 28 Apr 2022 02:46:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19192d57-c6d8-11ec-a405-831a346695d4
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2] xen/arm: gnttab: cast unused macro arguments to void
Date: Thu, 28 Apr 2022 11:46:25 +0200
Message-Id: <20220428094625.382970-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Function unmap_common_complete (common/grant_table.c) defines and sets
a variable ld that is later on passed to a macro:
gnttab_host_mapping_get_page_type().
On Arm this macro does not make use of any arguments causing a compiler
to warn about unused-but-set variable (when -Wunused-but-set-variable
is enabled). Fix it by casting the arguments to void in macro's body.

While there, take the opportunity to modify other macros in this file
that do not make use of all the arguments to prevent similar issues in
the future.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes since v1:
-standalone patch carved out from a series (other patches already merged)
-v1 was ([3/8] gnttab: Remove unused-but-set variable)
-modify macro on Arm instead of removing ld variable
---
 xen/arch/arm/include/asm/grant_table.h | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h
index d31a4d6805..5bcd1ec528 100644
--- a/xen/arch/arm/include/asm/grant_table.h
+++ b/xen/arch/arm/include/asm/grant_table.h
@@ -31,10 +31,11 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn)
 
 int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
                               unsigned int flags, unsigned int cache_flags);
-#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0)
+#define gnttab_host_mapping_get_page_type(ro, ld, rd) \
+    ((void)(ro), (void)(ld), (void)(rd), 0)
 int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
                                unsigned long new_gpaddr, unsigned int flags);
-#define gnttab_release_host_mappings(domain) 1
+#define gnttab_release_host_mappings(domain) ((void)(domain), 1)
 
 /*
  * The region used by Xen on the memory will never be mapped in DOM0
@@ -89,10 +90,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
 })
 
 #define gnttab_shared_gfn(d, t, i)                                       \
-    (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i])
+    ((void)(d),                                                          \
+     ((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i])
 
-#define gnttab_status_gfn(d, t, i)                                       \
-    (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i])
+#define gnttab_status_gfn(d, t, i)                                        \
+    ((void)(d),                                                           \
+     ((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i])
 
 #define gnttab_need_iommu_mapping(d)                    \
     (is_domain_direct_mapped(d) && is_iommu_enabled(d))
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:49:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:49:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316363.535263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0mI-0004sl-P6; Thu, 28 Apr 2022 09:49:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316363.535263; Thu, 28 Apr 2022 09:49:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0mI-0004se-M9; Thu, 28 Apr 2022 09:49:38 +0000
Received: by outflank-mailman (input) for mailman id 316363;
 Thu, 28 Apr 2022 09:49:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk0mG-0004sU-Uo; Thu, 28 Apr 2022 09:49:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk0mG-00037Z-Rh; Thu, 28 Apr 2022 09:49:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk0mG-0003X4-Gz; Thu, 28 Apr 2022 09:49:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk0mG-0001nX-GX; Thu, 28 Apr 2022 09:49:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eksCt3Ast1KhItQTadVT3chmaeLHNjMuGob19vv3elU=; b=m4CU2LiSmYVDA0hyzzp9lrzq5u
	t1v436+SyqGx3EsUhDAoGHMZyDmQrPrzAO2jNLDgkukWHM+yq4JZ/SmzTcWj9bbyYt4iLfwogOxh6
	Cilfw+zL7obp5Rp8K7msszbaU2TPDdiQpGtRtWFJJ+CPmJnIhWvxwlHDc2uDnOueRro8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169808-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169808: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 09:49:36 +0000

flight 169808 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169808/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   58 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  674 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   46 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:50:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:50:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316370.535274 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0nJ-0006CK-3G; Thu, 28 Apr 2022 09:50:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316370.535274; Thu, 28 Apr 2022 09:50:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0nI-0006CD-W9; Thu, 28 Apr 2022 09:50:40 +0000
Received: by outflank-mailman (input) for mailman id 316370;
 Thu, 28 Apr 2022 09:50:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nk0nH-0006Bx-8l
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 09:50:39 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a7000ea6-c6d8-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 11:50:37 +0200 (CEST)
Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 05:50:35 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by CY4PR03MB3237.namprd03.prod.outlook.com (2603:10b6:910:51::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Thu, 28 Apr
 2022 09:50:32 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 09:50:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7000ea6-c6d8-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651139437;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=5/JpxTgAEBJ9WeMLX3ZAVqGbSe68YWk4jEPGTb3d/WU=;
  b=duQf3+vv3tCIdD2sA5fn9w/kyb5JgDuu2PAeFzA4vvXZnst0bmPReIQP
   ZMZbM5rdshaMa8IS3/89mK/aegR0mcECwOjLTm5FnSmvtwaYCn9L3C9Qg
   W4QJPO2MndqGRicYaSolVyXQpMBEbXUcQ07s5CZuIhCQhntRJUHY7lWDJ
   Q=;
X-IronPort-RemoteIP: 104.47.55.103
X-IronPort-MID: 70003683
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:5wuUv68UC7o91MQid0a8DrUDnH+TJUtcMsCJ2f8bNWPcYEJGY0x3z
 WcbWTiEafqOa2GgctF1bt+2/UwCv8KEmNYwGQM5qC88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YLpW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnd/qZV4Xb73QovkEVkZ+NCJsY4586rCSdBBTseTLp6HHW13F5qw2SWQJZ8gf8OsxBnxS/
 /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHviMvIcDtNszrpkm8fL2f
 c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGUA8AnL9fFfD2774TxB6//GKoLvZfuhZNpZhwWDh
 mDcxjGsav0dHJnFodafyVq3nfPGly7/XIMUFZW7++RsjVnVwXYcYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHyOswMYWtFQO/Yn8wzLwa3Riy6bG2wFQzhpeNEg8sgsSlQCy
 Vuhj97vQzt1v9WopWm1876VqXa3JnITJGpbPSscF1JduJ/kvZ05iQ/JQpB7Cqmpg9bpGDb2h
 TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//BApJMisRiFaZWrGV
IronPort-HdrOrdr: A9a23:m+1QV6N3WmAx3cBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5
 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa
 Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd
 WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19
 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d
 78bG8=
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="70003683"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hwfgRYPVhOrw1MAtv+neq1HFn5XoTpNU4P3fyVEqF72EITPTYGMj5AWKGpgUATXfRGM/3oGq0w4peg95HzkueNZKxE6DuokegVXAolG6yk8mTVZKMdNXySs/4+28OAI+eyFhqY+ygEsK9Q46xk72M8u1seLHOufqsE5AdmWQqoDOCv8eXCMyKuLJ3loIMxo9YpO8+thIoRJhjRDJ53dNG8ZdUiz5T5ntiWV74WFPrnt6svCjtLDi5GQ5UWoiIrOnRtJ7BZiU3YhqcTewXD393xzGWwRwH/gQOMX+kb+pLOKVYEp9Wzd8KvW7fB66pPOhl8Dz/jMkrC3Xbvpk3+XBig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0tO1K1VH1jw+T0uiIAYVm1ppzO04oJCeN4ux2jaLTqA=;
 b=MgZkKdcEqLy93tJctXxZopbp62B0/jToD+eZKOJkJNH6pZXIWAHdw8utQiUZBv2xOVCYag3/Ory8TWFQP7yvzTFnvIj9NIFIDx67GUePD1sCjKeky0XHjLq/VRl6/dBVMeAzjDVez/yn4rTkEuwuJemnXklK5CL0A8stvbfGU98OPBfQzbkfTFQ6F7nIV+F7KC3Q/Zq/lKceMA79hvHrY0n6cuw+6DhVLJnlKMZeb2U8qvE3CO6BCHpqr0OpDIV8pZlyXlWLcZIY9BQmNDtpPvXrSL1ksSK3lL56y7SQqUyc3HgxAHIAj/T3ISfHnJiLnXEPUwXoTb0Taj6XbFmgrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0tO1K1VH1jw+T0uiIAYVm1ppzO04oJCeN4ux2jaLTqA=;
 b=QdumKUU4I/43YBimj5pA83MEzvL2M1j1xQK8udZHoVfTv7NJraOZq43ls2zm9mqveAo4WUUswNu+CnX0bVC+z8jtzkwjtq3jWPIlLWNDqf2fi2JA9Xk3FilG53z29FaA3X/c0J48mvlu6saIgyJZu2IRZFRZoILLEeSvC3MVTq0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 28 Apr 2022 11:50:28 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH] cirrus-ci: add FreeBSD 14 task
Message-ID: <YmpjZE1usk7feAzE@Air-de-Roger>
References: <20220427155023.84403-1-roger.pau@citrix.com>
 <alpine.DEB.2.22.394.2204271512360.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.22.394.2204271512360.915916@ubuntu-linux-20-04-desktop>
X-ClientProxiedBy: MR1P264CA0044.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 67be2238-9522-40b6-c1a8-08da28fc8934
X-MS-TrafficTypeDiagnostic: CY4PR03MB3237:EE_
X-Microsoft-Antispam-PRVS:
	<CY4PR03MB3237B7D4429D99445140E2DF8FFD9@CY4PR03MB3237.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ewbDvjxnxmcc/+Sr+pYoYZRo+wYx8rwiroTWYODR5fOo9WKjJ5WQBjsSmuHCQkGntuqoWPthFYBfrs0T29CYITc73/VG2cmYmXus2fFhLuke35ZknqHjtWxHp+S75gtAb2CBRBfplg7rfEzUnoS9a9oMMZcqtA9YbJXyuOioGoSnGwv8y0FUiVWdMoAYVkIcnQPdWYsLN+SEOK7mZ5hgWTb9VKFfYQRU81FNQsS7TKLeoVSic7rbRWfxSqbiXnSj64gcesglXedgEmt5MBAOqQcVotNZXmy2YrHo71cZK1y93wl2CnFVvRf8ZErGkbDcGdBCYickLiwMVZiG6fL1ZHadvdQy84k9+CNFGmZuwB3UkNK9AF8zmkV/p3qAo4aFcyy8af+KFnhgTor6cWjh5KAk7S0yq/IvG8mNWiVRhhFSqlz6hIqQPHTSJYuj1H7/b0UQ6dMUB7qpYma2TIWO1ybUygFZP2fDAeY+8xDdnjuf4QxBSxoWINuRpnF/1d9rtcOk1xQ+JoUmPeFP43TDMkioGMxNkAZadJuiqGvJcSnOcPamdP9sL7QIJDdrTX6mLAHa2NbYyvMVeV/Lq9q7m1RZcRgIWAeedGa3I6ii6a7RbO45mAaTqskB3KMfx0QOQE9TNbWnj9ioQTlPnUn4IQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6486002)(86362001)(54906003)(508600001)(8936002)(4744005)(2906002)(33716001)(82960400001)(4326008)(66946007)(8676002)(186003)(66476007)(66556008)(26005)(6506007)(6666004)(6512007)(6916009)(85182001)(9686003)(316002)(38100700002)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?czZoZ3ZpNFMxOGtnZ3dkMTdVQjRWTUxWVnEwMXV5TkJ3RUVxckF6YzJDZC9r?=
 =?utf-8?B?VVlyMEVvMkNmYUtPbHpZT240ZlFzK1VTb1B4N3JLTjVxa0Z2S2Y2VkUvUXh4?=
 =?utf-8?B?NkhaY0s0SXd2bFpjSi9PUDlKcThXcERWdDNNbmZ3OUpmYmdlQ1hsaUVlb3Fk?=
 =?utf-8?B?emtzeFRCekQrZHdyNWdrN0JFVUZHaVJ4bzlFR1hRV0lycDBEeVU3aForTjJj?=
 =?utf-8?B?NSszTDNGL1VsNWdlUXRzVERFVjgxbUxELzdQQ29NVUN0WWI0ZFhIMXBpKy9v?=
 =?utf-8?B?L2k0bjNiWWNtYWxRY29ZMitRWEhmNmNXeG13eGFWRFZ6V1UzdFBqcGxVM0RL?=
 =?utf-8?B?ZlIraHZSS3hGeFRKNWM0T21OQjY2T3lYWGxLLzVRTFBJUFgzZGpKK3JaVTBs?=
 =?utf-8?B?M2RGbExxam5BQ0pySWF4NHQzUlYxeWQzWHI0emFwblZIMDVYbmhZNTVxOW9m?=
 =?utf-8?B?dldYTkZSTjlOQVE1S0hQT3hNeks5RFdHY3NMMUVYR0Q3cEd4ZEMwWmZha3li?=
 =?utf-8?B?NjhKUkdxKzFhWXhBS0VJSlpGbk9NNTZXZTRDWmNDczV2K242MGVVQXUvc1VU?=
 =?utf-8?B?SWxucjd2K0hQTTE3YzJBaFVKYnFBR01YRGtLQ1ZJL0tkWVlqUW9VQWlHM01T?=
 =?utf-8?B?dGhMTWZFMmsxYUIrdW1TajZ1U1lLcVIyUHQ4NzRKWXBvdGg2TmtFUUlORDBG?=
 =?utf-8?B?dzJDWDlkeVdOTlhPbTRzODF4b0Jzak1WWnM4WXhhanUvbm5QNFphSHBVVEhH?=
 =?utf-8?B?aE1OTlBiYXRjMWdwdDNQSHgxZkRQT3NJa3B5dGk2Q2IxWEdpcDFycjV4RVE2?=
 =?utf-8?B?U3RZMW9mMkU2bWx4UEVXd2oxT1hSQ01nazc3N3BNdlR3SS9PUFlIUHR2WGlo?=
 =?utf-8?B?bXlIYmpxVnJrNUtYYUVXcUxxQ2VJRmxLZGVtdE40VEE3K2k1Wi9MNHBudjc1?=
 =?utf-8?B?Z0wvTDhDZ0tzc0Z6RnhKRkVWVzg5UzdRSFcyTUlIQTl5cG4rZXN6anJyNmgx?=
 =?utf-8?B?bWhpQWQ3K2h6NkRGN05KckZwUGh2RGl1RWhncXRiS2w3RlFxNTJ2bWd0U1pO?=
 =?utf-8?B?M1RGRFE5OUtuMGtDUTY2amdIdGgrT04xdUNreGNZWUZhZHBaL1lSS2FIZEIy?=
 =?utf-8?B?UHRMWU03eWw2Z3BDbjJ2SEpCbzFzZkttbThaZlVtTXRFeVk5RFlvRFd5ODN2?=
 =?utf-8?B?dkVjNDkzVXdWRDhmR1czVHlOdWxZczEyWVRIOWRqYjlNT2lXK2J0dGlid1R3?=
 =?utf-8?B?YVpaS2k3WGx0Q1VMNXVSWURncmJpZU8xTXFPL2NNUHh0Z2RjRVBDejJyV2xV?=
 =?utf-8?B?RFVuMlI5am04cVVrU3hxNkl0ZUJ6YVNOUmVSM0NQK3FHM3RMS2lCMHpXVGs2?=
 =?utf-8?B?ckR2YnMrb2pGeVZDUGlVNGdBcDNhWDQrSlZUZy9yMGRFMmpWL0pkRHJlTzNh?=
 =?utf-8?B?UnlGNkxnVEh1aURHKzVCSG1KTjlBcVRtaEp5NW1DQTZwNVQ3aEllRnhpbm4w?=
 =?utf-8?B?bTZaZE0rNFd0Sk5vZU04NVdHaEdQdGh2cW9OTnZKNlpNZ3VHZThFeSs2YkJp?=
 =?utf-8?B?aW0zdGQrVVNrcTB1RTdtZFNKVjFITndQaFF1OVZlTk41UjEvQ0RUTGNUaXZa?=
 =?utf-8?B?ZjhzTU9UN3o4L2ZTcE1Lc2h3bnhHcXplbk8wdVl0R0pTRlZ5dkpzRGRZdHgx?=
 =?utf-8?B?b1N6MVNhc2JYWGF2MkhnbmJWaWoxZ0VXUVI2b01PQnlYc1dVOWZGUU9xM1h1?=
 =?utf-8?B?d1c1QTdaalVSQnhPWU12VXJjUE1tN2Q3cW9ORFZ4d2JtN0kyM2hsOTJIcmsv?=
 =?utf-8?B?S1VQT0JaNXljOStDckNCN2JoYUQ3UE5iWHduWW9MOWdib3BIS3BNaTZKcEhr?=
 =?utf-8?B?ZFM2RU5vbC96OHM5MG9ycEhEaEdCbFgvTlhWeklSWnF5YUVrQjM1U3owMm5D?=
 =?utf-8?B?MjdQVFVnQjFnQzNzRURQTDkrS2d4dkpmYXJ1VW5OWTZ4NkVHbDJXNGxWU25u?=
 =?utf-8?B?R0lIU3VwM2RlZU1QTjlxR3ZsS0Z0cjNTcm5zUVRCWFBNVWVUbEg0cFVtR0JT?=
 =?utf-8?B?akFQYTdNcUdpVUtHUzc2QXROK29aTnRDSGwzOEhsZVNSMFpORmFEWHh5L0FX?=
 =?utf-8?B?cUJpUUM4Z1Bta0JOVzU2eVpWVDF5SExTS2RlVytVNHBiQTJycVhYM1R0TktF?=
 =?utf-8?B?L2E1ZXNodnZsdjNzUzN1QlVvSDEvTFl5K0YyVlRleSsrZVhlb21SdUEyc3NL?=
 =?utf-8?B?YnU5UE11RkZyYzdEcnVpQ2hpKzJjbXZvc3dGTDIwdHpObXh6SXRvTEtzSkNG?=
 =?utf-8?B?alp1R01UejVyNFoxUjhvV1pBK0VSOXB6K0JRZGpLU2VDcGpXQVUxY3RDODhw?=
 =?utf-8?Q?lOlFLBOiffsUaSis=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67be2238-9522-40b6-c1a8-08da28fc8934
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 09:50:32.7025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qcAqYY9ZjoH255crdw2ZCPg9hF0LDLJp+dgDwReWhroTR6jx5Zg2GKvYMAecW+uBVDOMye4fkXAWQzKsKHKlOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3237

On Wed, Apr 27, 2022 at 03:13:13PM -0700, Stefano Stabellini wrote:
> On Wed, 27 Apr 2022, Roger Pau Monne wrote:
> > Introduce a task that uses a FreeBSD 14 (HEAD) snapshot.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> 
> Roger, should you add an entry to MAINTAINERS to set yourself as
> maintainer of .cirrus.yml ?

It would seem a natural fit to place it in the "Continuous Integration
(CI)" section, but then it being FreeBSD only (at least ATM) I assume
current maintainers won't feel comfortable having it there.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 09:56:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 09:56:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316379.535285 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0sn-00070N-Sd; Thu, 28 Apr 2022 09:56:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316379.535285; Thu, 28 Apr 2022 09:56:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0sn-00070G-PF; Thu, 28 Apr 2022 09:56:21 +0000
Received: by outflank-mailman (input) for mailman id 316379;
 Thu, 28 Apr 2022 09:56:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nk0sn-000709-9Y
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 09:56:21 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7315abed-c6d9-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 11:56:19 +0200 (CEST)
Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 05:56:01 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN6PR03MB2996.namprd03.prod.outlook.com (2603:10b6:404:10e::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 28 Apr
 2022 09:55:59 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 09:55:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7315abed-c6d9-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651139779;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=Raw+g6TTZToe1RwUMkEjFiMHn/nBcUKghfPuQrRNOdc=;
  b=H5NSTZNHEtG++inIZE5P41KNbxPDn3RaqwTsWH2cpWuvQOfPst76toVp
   XxLZsXb2o4T5gO7Akf5X9gtgsvKcrWbSiANrbyKiCP5QRTp+nIF9MsOZo
   DoKCuIMGwzuK0MOjBSVJBtawSDadwlDkM1zDQ6fkAu/yoTahfy29w7fmb
   0=;
X-IronPort-RemoteIP: 104.47.59.177
X-IronPort-MID: 72582664
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:XRjd9aqs5wa/1ZpkBLYPLZufAmdeBmIHZBIvgKrLsJaIsI4StFCzt
 garIBnQaPqJNDbzfIgjaIzipkpX75OHnYRqHgNprHsxEioR8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4
 4Oq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBM4yWqs0XYzBiDDwgHa1t0pzoGHXmrpnGp6HGWyOEL/RGKmgTZNdd1sMpRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjXFp2Z8m8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK//dnuTaNkGSd1pDMENrKYsCBfv9fuVuym
 j6F70/VABIVYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3K
 UYZ5y4vpqga71GwQ5/2WBjQiHyZuh8RXfJAHut87xuCooLP+BqQDGUASj9HafQludUwSDhs0
 UWG9/v2ARR/vbvTTmiSnop4thu3MCkRaGMHOykNSFJf58G5+d5syBXSUtxkDai5yMXvHi39y
 CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsiPOZJu6TABYDn0Mt9
IronPort-HdrOrdr: A9a23:MXE8eq50ScrWEhhQWwPXwS6BI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5
 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfTqzIwlTfk1rFJA5HJ
 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2TiIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S
 zgnxbi7quunvmnwlv31nPV7b5RhNz9o+EzcvCku4wwEHHBmwyobINuV/mruy00mvim7BIQnN
 zFs34bTrZOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpPyfx2g4FhpVRwa
 hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvG7f2UIUh4rD3wXklXqvpREnBmcEa+a
 hVfYrhDc9tAB+nhyuzhBgu/DSuNk5DbStuDHJy+fB96AIm40yR/3FouPD3oU1wiq7VM6M0gd
 gsEp4Y4Y2mHfVmGZ6UOo86MLqKI12IZy7wG0SvBnmiPJ07Ghv22u7KCfMOlamXRKA=
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="72582664"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M8GeFZrqi9u4ppELnzN9+GRoaAYMgfVqmLri3VcEj1PJ1zGEALcywsAV0Sd+X6KuuIszYvXPw0qRsmIqWpZm2kJThHH17Xvp82Qg2aVlvawj1ZvvLpQ/iAfascFLBUy/X8QbDxT9Y+TTRjGLdThxUj75Va1lYXTtWRFIepCAo765YukmsEo65T+IsBlDd8hY51wIhdAWtJqn2c5/T3Hv7NAA6YeP9gqQltBkQQER0eOiaLo+CRaF4SFyYoB/Mf029msY1dGylFCQ8TMfF/cXLavzFy3t+sZC1dTcgOCXfFKFHDN0+B/QH+kxdA7vt3bCNjPSb5fgZ1wdTVxBs18eBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i9qiD5d3iCh0zV6WjSfSq9O796H2teWRahF43wEAtNU=;
 b=nafb+ByVkX2uxjNEJcBcc584wBB+V2gCocgykahBugslAZvLgPbDRN/stCrs2BkDuJv3K3UDxVp9f3z4tRmsmVla3YeEpAWQlUmws2BRhvYzyu/4yzWA0aoRkD/lFoxCARNJw9G/VZc79jPYbOEv34y5tCk5OxTHsFj+mbda0z6+wjJ75tCnRY34Q4AV8tWEBxK0KQVuwiHnUZn5ZPn9YncSi+9z2XyUKq210TIhL4SjaFsgWRmXBSNTvsAv0GJL0Bd6Mui74208nopPNSqKkFvZA2WzUSJ/cdt5ZPcqPtKBiA6I0YYD7pnGHHxb1XC1XFAY+lfCyTQQKdBuWPPH5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i9qiD5d3iCh0zV6WjSfSq9O796H2teWRahF43wEAtNU=;
 b=C5dBF5CiWeoTUn9d5/+D8i06+I5pYbpO5Y3J+4V9tzKd8nlt0yPsaIUrQY3N9bYvvUSV1otD/9AV3Zog17qjnHF8uQ6MwHW00CNyueU3y+JlAoKy6dvoKOQywehSrMf5gOYOcXSQo2hVqBANYPo2p8ucLeyazYyAXqNEAro4nSc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] cirrus-ci: add myself as maintainer
Date: Thu, 28 Apr 2022 11:55:49 +0200
Message-Id: <20220428095549.91409-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9f70bbb7-8d79-4c27-924d-08da28fd4c22
X-MS-TrafficTypeDiagnostic: BN6PR03MB2996:EE_
X-Microsoft-Antispam-PRVS:
	<BN6PR03MB29968D53D72E995956BA796F8FFD9@BN6PR03MB2996.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D1ue59A/cSdmYN1ko7BXiVYbfib/A74zGIaFwk/kEBDmUvLgrAk/xIBpoddTLg80U1d6fGXSrVae2GVi9XtG0N0gFEeDnLsMk/jBS7SyB5tR8WYvFePiFWJyy0tlZcYxSw2NXG1HI9slUJRTTeukd8mgmcNEGMEmvQ5aDPc1fxiIpdtttgEwJtrgLWALSo0Iwz7snvrsZKYSwhJeN3V4d09AJhs/Kt0etw9kOH7XYMZeEOmfaKG+DRQgjJOBvGDxHtEbHGUikPXesotysFBii+jE29cBM0BLDq70sVK42t/GAnCTHGxlAqOVIuaO+Qk5OsTB7Hu9fDszytLniHTAUV/chVSRE5mZp4daUE9qP1farY7ElR/KJa+jxQIx5hplPF9fI2HfP3Ls3DH2z649QWw/fHErS7/r6tnwVrj7cpWuhpDJcJ1HuBhpDxxi9m9wBbypbahrgn4uIN/HnZpXUP3/K32CYKC8aNEBqV9y7HkgPqJVYaJ3jWqx1mIIp++k4f01f37YTx2SLI1Qo07VMPCYbQ4aVA9wrwARfBNBFQAMlXFKfnHDLQqRjIsHNlPqUFVdAwmi+zOcYh3exJxwvm5aZr4f23Xcu/TO7syBQrzKvhMgf66nQiiVUuutw7n33FjrHZeVIJlsZWpm4vTklA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(316002)(82960400001)(54906003)(6916009)(186003)(38100700002)(86362001)(2616005)(66946007)(1076003)(4326008)(8676002)(66556008)(66476007)(508600001)(6486002)(6512007)(26005)(6666004)(6506007)(36756003)(5660300002)(2906002)(8936002)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TVpCQmpkQ21abWhxVzJWOHBEVndQSlRkblpjMkYzaE5qNk1OQWxhTmRWT0pq?=
 =?utf-8?B?Q3BjUmJmODB4R0NOcG44elBJWjJlOWFrMllJekcyWktTZlMwT3lpcHhmaE5y?=
 =?utf-8?B?SUVrcWNMMjBsQmRwN3BBZytkVlVtZW5tbUhJL0dIdWRWUzk4eWxkbDV4Nk85?=
 =?utf-8?B?MFYvNzkwTS90angyVnlRT1NhZWVLVURnV1ZwSStUV1pLZkJzTldzRWQ3aHg2?=
 =?utf-8?B?N2duNUg2ckV6OUp4YU81aVlDaVVuUHJOT3NKRUU4YmtvYVZGZFZpQWlLRGpB?=
 =?utf-8?B?S05LdnBxVWxxUVBNeXFPK3UvUVdhR2RKQnNaOWZtVlFoVlM2aHpVY3BhUHdC?=
 =?utf-8?B?NlhjOGFyVlFia1dVbndkS1hHZ2xTMXA5WE1SWW5MdDV5T3NIcTJCazU0c2VQ?=
 =?utf-8?B?azdtdTBUMWx1bzlvSVZqTEROK3JXelNkWDVhdjNjNldjQ2Jyd0ptci9zRTc0?=
 =?utf-8?B?a3g0RUtIWWQveFN0c0MyK2ttVGozNlMyTUs5ZlNHMWVSWlpTMkM4UzI4UnVY?=
 =?utf-8?B?L0VTTnpHbjFWTEZqZnJzd29VL043VUw5aiswMUZuMkpiNk9pckYxZHBqSVRB?=
 =?utf-8?B?SWJLRG5Ja3NWUzQ0a2NMMlJqV0xlZTlVTjVYOWdubXpCcmtma2pGN2w1ZW9Q?=
 =?utf-8?B?QzdZdzdvVDdEYlpzaE5ZQ1NlaDVveE5VMVIwa1Bybk1wTExrUm9RUHI3Nndo?=
 =?utf-8?B?cE83WkJkcmtGY21NRThKT3UzemNjWUprS1N6WWg1ZkZDdk9GN3FjMmRya3B6?=
 =?utf-8?B?ZVBWVkhNMUtZRzNvazJyTlU1dXVudWdzRHV3bm5ueUQwNlBUbHEvNTBMZi9x?=
 =?utf-8?B?VXQ1eWpQVHFsNm9ZaUFBa2h2ZVRwMk5GZ0JxYlN1RlpiaFhJNHRHMFhDa2xx?=
 =?utf-8?B?ZmtmekZuM1lQNlEweXJWMjRMbHpkeE9NaGp5UTQyMkxiR0p2LzQ1ZTdGVThL?=
 =?utf-8?B?VXcwZzF1WWsyRmlITTg0V0RrY1VoNVZZM0lMZWQzSXhycjVMUGlXWjdNbEpL?=
 =?utf-8?B?YnZNRngrMGlUZ0FmcXlyQU1xRXVZTE9TT3ZzVEJGNDdwd25VdmF2SXdGVWky?=
 =?utf-8?B?MU0vWVdOVGJmVU9XMXAxcU55bjA0bmVna3VMTmRQMm9ha3J3a0RQaXJRa3Vh?=
 =?utf-8?B?Y1RJcTZoUE1Lcm5yaVZBSVpaa1lHUTE4VlJYZytaakxtWENRakEyK3BIckxi?=
 =?utf-8?B?QjZBTzJsM1JYcGpyNWgrU2NsZk1XaFRHN1FqK3I2d0VxdlE4Y3JCS0o4blVl?=
 =?utf-8?B?RmFaQUU4ankrY01Nb0cxMnQ5VzhKUEZtUXR4RmlIcEpnTWQrdEY0dDg3a3FQ?=
 =?utf-8?B?aC80d0xmSWhQQ3FWa1V6NngxbTRtaXk1UDlmamJ3WWxsUFlaQVpQWk1hUzJv?=
 =?utf-8?B?TXVWSXYweWVSRGhLbHJyWDZONnZyVHZPZWJ1R2g3MWxlaTZEZXBmYTM0Rm5B?=
 =?utf-8?B?YnUwUHpVZkcyY2dWVmwvRlVMR3hRMko2L3BsRnI1bWgwaGlFdnlsUSs2Mk9w?=
 =?utf-8?B?UkJqdTRoY21qWmppMzJ6QmllcG1BcUJsNDJwcVhlWEhOZEt1ZjhHWFFYQUV1?=
 =?utf-8?B?aDdNdzFJQW93eEJFV1psQ3BSMFQ3Y2R2THhoYW1aOENJaDNTNEJ0U1lGcUlm?=
 =?utf-8?B?bzUrdmtXOHJ5b1BuTDY4S0NFNFp6c3JrZnk3aCtBQ3pLVzVTeHlBeE15NDdB?=
 =?utf-8?B?ZVpkODRNRUJ4VHNwK3FqeEtMZjhIc0RpZ0duNnhMNnROL2tpZHFlYzlMbUdQ?=
 =?utf-8?B?UHRpL3JLOTZHU2xCUVBHY2NwT1JaZ3VYY1lraDU0RmR2d295akoxY21LRG9v?=
 =?utf-8?B?ek8ybzhmbHphUTFVZThzVUxTS0VDWFJOMFBPOFRmUFRLSTlWeFVjV2g5Q1FH?=
 =?utf-8?B?OWdHbW95cHRhYkhQZDZjeVZZdCtZVEozV0ZQV2doaGg2RDlnazdoVUFPa1ZJ?=
 =?utf-8?B?TGFpQmhmZDgyT294UHRNWTNLanM1M1hIZXp6dFpTNU52OXFYTmtYRU9MNmVU?=
 =?utf-8?B?MmdRNkxGdXZBdFlVV0tON2FHdEFtUWoyRTRCbTFpcDRKS0tyaHZxMy96RjZJ?=
 =?utf-8?B?RUIyT2NhTW1DWSsyai9DY0ptNFlOYVFBa1JoZklKaEpmS3J0aFVkQ09aSjFY?=
 =?utf-8?B?Z1JaNE56bEpvRXp3cTRZenZTVmJRc2NuM1NZWVU2UVpzeEdzR2R5enlNa1dt?=
 =?utf-8?B?UTN0SEMyc2Z4c3dqakltTXFWS015ODhQV3pIeG53TU0vOHIvODJQOHc4OHlR?=
 =?utf-8?B?Y0o3UlluMFR0THFtNDQ3YmcxTU9nRnR4S2phUnc3V1pMbUFRc092ZVk2NVdq?=
 =?utf-8?B?dkVsRkxHTzVBbVk5RHpmUFM5bEVTb0xQQkQwYm9KT0p0MVZjWW1samRWcjlL?=
 =?utf-8?Q?PkbdMO9hh7go0DKE=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f70bbb7-8d79-4c27-924d-08da28fd4c22
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 09:55:59.7235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y5C//Mk+BCw0slc7efYwaJpQNOW9JF+EPemI8F1qX1iOJNdkk/pUYabJhipaXaGco31V+69kLj12eocyqyi1Cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2996

Given the testing done by Cirrus-CI is FreeBSD only introduce a new
section in the MAINTAINERS file to cover it and add myself as the
maintainer.

Requested-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
FWIW, I wouldn't mind it being part of the "Continuous Integration
(CI)" section, but I understand maintainers there could prefer a
separate section since this is ATM FreeBSD only testing.
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2a47fafe85..6248d07aea 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -260,6 +260,11 @@ R:	Community Manager <community.manager@xenproject.org>
 S:	Maintained
 F:	CHANGELOG.md
 
+Cirrus-CI Integration
+M:	Roger Pau Monné <roger.pau@citrix.com>
+S:	Supported
+F:	.cirrus.yml
+
 Continuous Integration (CI)
 M:	Doug Goldstein <cardoe@cardoe.com>
 M:	Stefano Stabellini <sstabellini@kernel.org>
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 10:00:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 10:00:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316386.535296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0wm-0008Rg-Em; Thu, 28 Apr 2022 10:00:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316386.535296; Thu, 28 Apr 2022 10:00:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk0wm-0008RZ-Al; Thu, 28 Apr 2022 10:00:28 +0000
Received: by outflank-mailman (input) for mailman id 316386;
 Thu, 28 Apr 2022 10:00:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IJsv=VG=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nk0wk-0008RT-MA
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 10:00:26 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0631.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::631])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 060e6e32-c6da-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 12:00:25 +0200 (CEST)
Received: from AS9PR07CA0003.eurprd07.prod.outlook.com (2603:10a6:20b:46c::16)
 by HE1PR0801MB1995.eurprd08.prod.outlook.com (2603:10a6:3:52::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Thu, 28 Apr
 2022 10:00:14 +0000
Received: from AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46c:cafe::37) by AS9PR07CA0003.outlook.office365.com
 (2603:10a6:20b:46c::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.6 via Frontend
 Transport; Thu, 28 Apr 2022 10:00:14 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT057.mail.protection.outlook.com (10.152.17.44) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Thu, 28 Apr 2022 10:00:13 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Thu, 28 Apr 2022 10:00:13 +0000
Received: from 8b20d8ed092f.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 38C27C0B-6F4F-47F6-848C-DEE44EB704DB.1; 
 Thu, 28 Apr 2022 10:00:07 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8b20d8ed092f.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 28 Apr 2022 10:00:07 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM7PR08MB5335.eurprd08.prod.outlook.com
 (2603:10a6:20b:101::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Thu, 28 Apr
 2022 10:00:05 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5206.014; Thu, 28 Apr 2022
 10:00:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 060e6e32-c6da-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=O/coY/XWyR1R71Ak1ErV4HhhBvn/wRHmtMks3+AIg8t/EQBk94DgEmLAGZZwfMNXgxCb8TKvQBMeoTWHFabcBKTV9MLEx5gZX8B9IK5sp9VoDeIVimKVSkPLIIdEReVGc6lrnZIcCmxz0s7xC0ftLO2479cLwqLyZKQCFMyE0O8L+yV6cgtR2nMweah9gh5AttXaZnl5hF7xGqPg+kYA3kKBypUZbXhp+uJwnSi6zLlZON5dXa+kbbaJ8krz180IGCTfBpqC5toElWjVriX5tgME/NWFY78uSd3M4MnTpHPYnhjQrUO9gOXfJ8fNCaeBaLje3OFy4I8603EVbJPmdQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q28z8uYe4B+DUst1RH+487OG7SWT8BA/xjb2pd1xLvs=;
 b=QoZfKJMQ+6RBhG5hlyxX4nUrL8W1l0XQTneBGITgbskJ7BzCT/mXdRidQGFkQdEEAyDsjMxP8eepO6TjZ/PxmNJLclfBxP22ESf/cxBbt+7UfLsNiieVb0x3xrk35h5BPoMW6kmoAo7/Dmh/d6XiNErK+8xh0MprHhoCX8uxyHj1AwQ0SeEU53RPwDzidPqUh+7hitOgkpIUmiE9FN3RAIoKkimvlTmKLfnazATnIpfFWMU3ww5OomVjCy8YDXNVKK7rfAaxMwyeebuoJtWDaTBvCr1W7OrCk1y8pnr/E7aVJDufnoXQrg7iPNT3bzjHaaCUV1qMxYtpDRmvPGxYrw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Q28z8uYe4B+DUst1RH+487OG7SWT8BA/xjb2pd1xLvs=;
 b=ySkMGvHUxDRNCjQPMS8KPCesZJfbvjFhqOQQkqWf8M3koKdFijodH3ZLwOXOkm4lzFEDYmG25gP9/AW5GT4mVsKzebP8TrNS2Ohc1D02L+me9CezaVlArI4LEzABSUDanoql9seRy3wwq/Kw+Hl46RwGeHnIWhiFk4DQAJq/Xdc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2c6e87385e4174da
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dAkTW5dDGWYPlIuqAdKVkXXsaCzjVFWuzQEvqSiFS7ArzfCa+rG/cHhYuxqnY7kcJE4yZrkq8aNvCCY6e1IWeS8TWtnzKfXNMGos4LORQVKH/nfWLHRy0Oqmcka5pRdiLhLi5MVUwygJlh7gcVczoCbxpCb07mbgIB8Z4yWCcbqq0fZx8TC/A/+WHvusVpFUAsPmgujCZO3FM1R8gOUfl6EJrFwFSIq44U28yCiOdgV/1zEeJrEsJ/hFq7rgV9BtYxL/GmLqUenXWxJgpwdtpDP+r4oguerVkVmS6lWRkf3OzGSrqEnzY65L8idnIxTl8g037+UXzetOmqyzxhkHGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q28z8uYe4B+DUst1RH+487OG7SWT8BA/xjb2pd1xLvs=;
 b=PFH84WHrTaU3s5WH5dTa4oUeqiV5vgKXunV/V/rdYCPa3lczNqYiWzsf2arLuwzD3s6fxymBi2qg/GflIP61GB+KN/3MxvsqZT5dcYH8pg9MgNmPqDH8O3qp6uIqe2ovgkgRb9YpUYgJLwF4RGI1tI7WdEGHax5lmXK3es0RdsBQe85OCm07sjOCPwAQw1vcOY/iBvbgXHyoYJCjcaj2Q/Ed85efaeVVDoT75xgCvEqP2HeyUk6tHGe6NYjcdHsieStceM9hDTXhk4hNr0ahUdab9q4IG126HG/zj5wKxTu6rD978g6oG3CYERHaudjCiYWWjWETg8fU8+EnqpRVQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Q28z8uYe4B+DUst1RH+487OG7SWT8BA/xjb2pd1xLvs=;
 b=ySkMGvHUxDRNCjQPMS8KPCesZJfbvjFhqOQQkqWf8M3koKdFijodH3ZLwOXOkm4lzFEDYmG25gP9/AW5GT4mVsKzebP8TrNS2Ohc1D02L+me9CezaVlArI4LEzABSUDanoql9seRy3wwq/Kw+Hl46RwGeHnIWhiFk4DQAJq/Xdc=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table
Thread-Topic: [PATCH] arm/its: enable LPIs before mapping the collection table
Thread-Index: AQHYWlHsf41jIOfeQ0mX6M++noloAq0EDIIAgAEMUAA=
Date: Thu, 28 Apr 2022 10:00:05 +0000
Message-ID: <73BA5CB5-8B01-41BF-B967-15886554C230@arm.com>
References:
 <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com>
 <a2bba079-0a26-8648-6f39-93148dbd5107@xen.org>
In-Reply-To: <a2bba079-0a26-8648-6f39-93148dbd5107@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 199d60cc-7513-4eaa-4073-08da28fde3ca
x-ms-traffictypediagnostic:
	AM7PR08MB5335:EE_|AM5EUR03FT057:EE_|HE1PR0801MB1995:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0801MB1995A69DC364EB6C46E51EDBFCFD9@HE1PR0801MB1995.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 W5j1Cj/yHzz/dRgLRvhQqJWHxilpby/wi76+66l+txtJKVVO7IP1DdJH/7uP5oDabrysRzbScq/5JUuzzB/EGoakbW0G68arSgcuHuedcwQGhcm/CbzNj7+LX7lqdcAbdzhjSYhaaLE3ofBtWwQpzjNkeIHZ6f9bY//pMjIWw9X+ByqEGI7V3BlBBanueSKUG8WwkDeBBwjtlg2uSspRqnHZfPvUG3ErhJBJ3hCzcIsOX24SNNnUKNKhAK+obeNiYJ5n59BPIi0NsXtrVptmOY5nO3MAaHMiYhtp3c+eUHOz2W6rp8pKVHAZ3ka/0Ej7hiNK/Nl2wPfyVuA3UI6DqN8qt5xwhZK6KCBvtKnSKo/3AyW8gs01wEtrAyis3wP/zG6172Ldiy/M8AXr1ka5JG2XTVpcZ7txBpPn1DQGjkegY23S8K2VN5kQXStVq6qfKYPfso7LtqXG451owuzW3QcLwjkNcmzpCCm+J4EWmmklTVDyWGZ/cjjcyMhpw27ZioE15ybmVYjdsoZd1oDg1kpRSRk4xF6vwwG1yKI4KwSeVbyN8/ON49bfOlowcwKICLGD+Dok5vuUOi6faEDiif09zKJubSyEoVN8Q36asgxqb0+/WZYD+FudK+qlQvp5dS0CJ9V4bu/n+6s5l5m3VvSVBT21mu2zJ2ANww0O4bJeQvsFNDwO8GuGbFr5YWQAPpLBrGunIf5EjIi74Teurb4KKEo1ukgdBNBc+ltwirwRXjFVZvCoGozJpi16iWo2DT5gQ+9GpyPVyH8ezCxgx1NWLIuC0XfK8XCal4g0Hh4Rj5G0jOaeiPjzmT/JLJss
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(6916009)(8676002)(5660300002)(66476007)(86362001)(66446008)(966005)(6486002)(2906002)(66556008)(36756003)(2616005)(83380400001)(122000001)(26005)(6512007)(186003)(54906003)(33656002)(316002)(6506007)(53546011)(71200400001)(508600001)(91956017)(66946007)(38070700005)(76116006)(8936002)(4326008)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EB6FC66C4AD900439B45DC7C520FF8C7@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5335
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6f3de6ae-5f00-466a-d9e0-08da28fdde89
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EQgvk0NXs7AgSGKGNUTaU71DSweqqwDkFqSVK8omTlx4Cu0mGFoBptz+WUEcjIX9KaUC+oex6eI+vREJ0TgskdwlEwpzKt0flKQ/gcH0JpnCNjD3jyTz27a65LVRYA30/DmaoD0nzX1ukawWqCfLfI8QHRr6H9YWITUtNthUAZR+Qb3rw68IAatx5JLgK/7sbYRdvuwfxziwGAtnDge3vQVhcGLVSugfxRGGDX+SqZzt51EmqIqCxQg9+tDGlS9W21nFW8OIvKbLpvhLQ/Vv7+YPk22ZQKsf3xm2FbWw4Onu1QFNG+vS1/H3rvymV2s3bv+tbbIR0piQeYVphg0C2E7plIhE1v6N/QOqt7L05WuzioZpb3bRwtS6iAeeaASH+d6ebLeM3+Zc6fnyPuhGvTzF5fMKA4ARDAbJCdPlU+hvxywJX02yOzwf+SWMuq/BQlJsfQysrqS8AsL7+DV2+OFgnENRwUi5EPYps8WgBEVFwZhGApRrVpLeybGzq8bUKRuK9PyWIkAm+GLU3ILZtn3aAUdOl0W5oLRLgLs7fpTaIr9jcR2db2VPi+l4Pn3sB70rxNdA9NY2OMbdS/IZOEJBU2+kltEQ33F0PalunqBn68rGjJLfuhtXo0KKS1j1g8vqwpklrZIOkTaDY2INyH56QTqifH0pWsA/D0DhEH41bo2rejf8vRm+P8tCdVsC9dpGT96mFjXZEy72mue1pL5h7f7E+pu1Q60+MuozJH3F0Dtlw07+jBmDOzW+al9T
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(36756003)(47076005)(186003)(82310400005)(336012)(2616005)(36860700001)(83380400001)(107886003)(6506007)(53546011)(86362001)(316002)(54906003)(6512007)(40460700003)(26005)(70586007)(33656002)(356005)(6486002)(4326008)(8676002)(6862004)(2906002)(8936002)(70206006)(966005)(81166007)(508600001)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 10:00:13.9227
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 199d60cc-7513-4eaa-4073-08da28fde3ca
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1995

Hi Julien,

> On 27 Apr 2022, at 6:59 pm, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Rahul,
>=20
> On 27/04/2022 17:14, Rahul Singh wrote:
>> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are
>=20
> Looking at the spec (ARM IHI 0069H), I can't find a command error named M=
APC_LPI_OFF. Is it something specific to your HW?

I found the issue on HW that implements GIC-600 and GIC-600 TRM specify the=
 MAPC_LPI_OFF its command error.

https://developer.arm.com/documentation/100336/0106/introduction/about-the-=
gic-600
{Table 3-15 ITS command and translation errors, records 13+ page 3-89}

>=20
>> not enabled before mapping the collection table using MAPC command.
>> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection
>> table.
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> ---
>> xen/arch/arm/gic-v3.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>> index 3c472ed768..8fb0014b16 100644
>> --- a/xen/arch/arm/gic-v3.c
>> +++ b/xen/arch/arm/gic-v3.c
>> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void)
>> /* If the host has any ITSes, enable LPIs now. */
>> if ( gicv3_its_host_has_its() )
>> {
>> + if ( !gicv3_enable_lpis() )
>> + return -EBUSY;
>> ret =3D gicv3_its_setup_collection(smp_processor_id());
>> if ( ret )
>> return ret;
>> - if ( !gicv3_enable_lpis() )
>> - return -EBUSY;
>=20
> AFAICT, Linux is using the same ordering as your are proposing. It seems =
to have been introduced from the start, so it is not clear why we chose thi=
s approach.

Yes I also confirmed that before sending the patch for review. I think this=
 is okay if we enable the enable LPIs before mapping the collection table.
>=20
> However, given this works on some HW, can you clarify whether this is man=
dated by the spec or this is a bug in your HW?


Regards,
Rahul
 =


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 10:09:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 10:09:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316394.535307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk15P-0000jg-9b; Thu, 28 Apr 2022 10:09:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316394.535307; Thu, 28 Apr 2022 10:09:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk15P-0000jZ-6X; Thu, 28 Apr 2022 10:09:23 +0000
Received: by outflank-mailman (input) for mailman id 316394;
 Thu, 28 Apr 2022 10:09:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nk15N-0000jT-Oc
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 10:09:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 452ce775-c6db-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 12:09:20 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-r6gYEBsUNIeyUNzat4y1RQ-1; Thu, 28 Apr 2022 12:09:18 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB5898.eurprd04.prod.outlook.com (2603:10a6:10:b1::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Thu, 28 Apr
 2022 10:09:17 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 10:09:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 452ce775-c6db-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651140560;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=paNOND5mRbm7gq6v/DVUXy3uVWjx5CvEVEg+RVMRvKA=;
	b=MnW7fm/tyOanFWWRWQ+PMkg3n+VxyrJTlGIyKEWIea2SisvxiGiGKpGfUUZECo0ComBAki
	iIM3NaNdVaTQwPnHeHvKd1ZTgHLk1fl+d7BoyYV+Ucr1HDeqKy8Ys+UBg4/iirBNpMlEqu
	L78n68/W9dZUS8MGfgnXUsHBofcEYBs=
X-MC-Unique: r6gYEBsUNIeyUNzat4y1RQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JhlN4IkUPySJW5QS8V3LGNUxqlIMJ07d2bHV3g4Bw5CXyoaWGG+tCUMsT71q34KdBlSMZeBW8N+Lf19GAi/cw+9MlYXasbPq2Sf5i8LuoDZqPWzY+hVzf/6B89cYys/HKr1MtFNsUo6uhm9GNS+Fa/ensiFpsPUPdNOkuRTkVtp2dPIVQTAihjoBuLy4dpWx0YjlFoizlk5EIQXy+uoTsj4Vkk+8YL1eUDBZWUusaQM4DAB5hpxIZgazAy+aMySf1VwEwWMblCzy/FSOzIeX/kO5/ubEvfBv9yedv6x0PkQzWvGInKOKVuKcZ8hv9Ni8LwJeci4ASy2m7/ZMsPg+WQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=paNOND5mRbm7gq6v/DVUXy3uVWjx5CvEVEg+RVMRvKA=;
 b=jhm+IQFJdNpY2LkpLnEuOXBTmXTSTL49R4vmSl4k9n1W1lthzccBGefPlDPKqz5whyYXmihmMP7VLjZSeb5EEEIngn3FYI8p2fH0YyNK2ZLwzH9KClOqCtWOYNDA9y4/NXWYjqrfSLo/AifLvLVRfS8ZLDa+LWXHJEZRfbsH93wDnPFj91cq2t1YrjF4tkbjuK8s0gdZV4gXxBmtE1FPUiUityJ1tRhoSjf9UX5KwOQzVWFgmzWDpQSdrljAVYL0LwfkUAHcloJtimkUgT1wUlzBEdG/CfcPsJX+A5zmGpeSYKeKop9DAJpCj3a8gGA8fxYjQdaWn2e/mA2ghqUCdA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f3e51bb2-4445-21b4-a1ca-3ac3b513affe@suse.com>
Date: Thu, 28 Apr 2022 12:09:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2] xen/arm: gnttab: cast unused macro arguments to void
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220428094625.382970-1-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220428094625.382970-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9P251CA0014.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:50f::18) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2146eb19-8309-446a-d378-08da28ff2748
X-MS-TrafficTypeDiagnostic: DB8PR04MB5898:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB58982DB8984ACB220BF7FE02B3FD9@DB8PR04MB5898.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hxyMUa35Q5WPodCmShw0hwcLkKZvmgRAExcG+TILwD8uvwHrGYcNHvk/dIWhIY2S31MAORsSXJZZTZir3o1xyokvoNDxBM10QdsI4SfCB66yVYpmg/7bosJ7srPn6V+XdM2Ndd57mdSeG48ZvqnRjQ5zufj3/esw4hNuxbiiBAYZOOVK7fNlfimzRltkuw0RJfgjQvg24S8VlXinD3Aw7RzVXIXCAPcyA01ATB3ERUdKCgjGrxidIttuvz7YCXF1p/zrLd/xQ0zxnvawNdCp8q2MvELigzDc/7VGVvr7Fy9gphYfhfh0IwQd8AEaBONn3q8XskAwdGSwL4MttxXWL0t7oEhJEDjABJvXFhQwn8Upw8gGSiY5v0KxQYD2g41q93GYSVRO8k831IrOM6gtG72ZFnX2IiRLfpOvjt+tMAjb14l7cdI1dh9/hui/XGSwLZfF5gG8wRtiZf5Y0pX/SEIr2KMscehZjlBTsS9/nNDrC0pq/h7yrUeMHF3Db55MYSlvjX8qdi0omWji+iIo56mwSoEYuvjU/5rVDxMOncAbXZI5QbWpjc14hvINL8/FuS9CF3GQJj2aGnvIYg5jD19aIUQFKM7GOFzNLAkHvrwatDehamAEMoherAgT1jnfSAJmRrk6g0/xyzoggEKgTBnNjfVOzd+oIg+Lcp51d8i8nk5Zu9UUdRVvbFgZNjJYZwwZEbcaXlpX7ZAwQwaGF+kwtW4+XQ3rcjTCtEFOLrA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(6916009)(54906003)(316002)(508600001)(31696002)(38100700002)(5660300002)(2616005)(186003)(4744005)(8936002)(31686004)(2906002)(36756003)(6512007)(6506007)(53546011)(26005)(86362001)(66476007)(66556008)(8676002)(66946007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Sjd2dWI0aWZVeEViRWhXNjFRNndOUjJrLzlBRmVQL0NvT2cwTHJrTS92dVhZ?=
 =?utf-8?B?bkdhZ1VUMXBZbzJPeXB5cnVJWUt0NGY4QlZ5eFIwNEpnOEdrY3d1bFdGaG8z?=
 =?utf-8?B?Q2R0aE9Ed25JdHU2SzJlWXZSYnZyMGlVVDVJQnhkV1hkUVRTdmI3SGQwT2VS?=
 =?utf-8?B?TUlpT01qdzFoZVFRTXdHZ1IxanIvOVloRDdjeWNsNlE4aC9zR0FuZUdNOUxm?=
 =?utf-8?B?WHQzNlI3Z2VXUkVSc3QvTXA0Sk02TWl6ZVJxSWxVVXY0QXAwblM3Q0xlZDVE?=
 =?utf-8?B?QnluRHplZG9DR1lWaUVLdVFhYTJxUS9rTUhoY09ORHlaTUxBRFVEL0pmaHJ2?=
 =?utf-8?B?NXAxQ0Izam9PZjdLS284UlB4blZhUlU2c0I2emV5cy9CREN3ZGc0aEcrM3Q4?=
 =?utf-8?B?QUdWMXkyK056Y1FCZjk0Y3hxeXdEd3ozNVVQc3lrSDFHZStHbXhXYXFnK0Z3?=
 =?utf-8?B?TGRVTktqNEFhNFZEcUVxbjE2WG1qdk9KQ3pXcjR3SkMzdWJHZU9PVVZqSFhw?=
 =?utf-8?B?YmNoaGc0bjIzY29tODFlanYyQjNEcFRrYUpOZGxHclVhdWNJN0UybXMrT0Z5?=
 =?utf-8?B?a1J1Qy81WU1lbmVqZEVoam1BYU8yREducUxjWTZhZVl5VzZkUVZzSnZVVFF0?=
 =?utf-8?B?OU1RZDFSTGxiQnlOUW9hWjhNUVc1ay9kSSs5bURRR3JKZjBYRkovVFdOQWFO?=
 =?utf-8?B?K2EyejlTbUtlQUx1T1FESnArbFdQaTVJdi9hTCs4ZUtjalQzU1UyRjBaeE1X?=
 =?utf-8?B?VFJ4RExDUFB1V01sY1YzaWZvR0RDM3hvbmxmRVR1N1k2dHo3Nm1yaUxpMndW?=
 =?utf-8?B?VnFtTkl4REIvTy9wWHZlVUNqVlBTeWFRM25aQWZRZDc0SWMwbTJSMG9pYzR3?=
 =?utf-8?B?UUxBRnh2NUVTSzF1cnJVQUkvK0VHQjR3RS81dTZHbFdPTW5VTE14clpDOWd2?=
 =?utf-8?B?akN2QU83VnY1T3JNOWQvZEdSUTlVWEdRWmxjUlpRSGlwNWViTHJwaFJ6VnRn?=
 =?utf-8?B?eEUvSTJLR3IzMEdzUWNqRUpVWWFXZVVYQk5rTThUUkM2S2x1eTVQRHZKS05E?=
 =?utf-8?B?N1lqbWpKcDZvMU5RREJGbDB5VXowbzZ6b0ZIczNxWnd3ZVFaSUxFWmRtZ2VN?=
 =?utf-8?B?RVRZakJnbGtqRnIwbFVpUlY1UFBjN0dVRGRKajhaRFpYY1pTd2xzWHVzR1M2?=
 =?utf-8?B?bnkwUUdpdnh3YmthNzFGL3ZISnBLRVhCaStaelhycDdHV3ZhYXlENjFGTnRC?=
 =?utf-8?B?RHV4VTZaZTgzRENjYVBYbTN6dkIxb0l0WndtUFUra28rc3ptbzdVa0R6ZVVk?=
 =?utf-8?B?dktyWlVBU3krcVJaMUtEdDVySk9abTFkWUtscWxMM29QdmpLYzk0NzN4UkFU?=
 =?utf-8?B?aVJtTlBPTDM4YkgzSDdxM1hNcGlnZjVJUDltVzhsY3BaSmpRTnhqTHlsZ2Jz?=
 =?utf-8?B?NHUxalU0bUk4eEVuWEhkRFh3MTA2dndjbHZsMDVVclB1YWRVQ0NCb0VKdndU?=
 =?utf-8?B?eTkyak9YTEE4cUZHaHNTaXkvN21pQ2RsV3Y4ak9UNy9RUE9mSFJrUEppOEZz?=
 =?utf-8?B?R2VuSkpUVFFpRUUva2IwVSttM3N4OUh3Slh0bTRZT3p3YjBWWnhJTDNtSXo4?=
 =?utf-8?B?NVZMa2U2SFRVcWkxWUtWa1hZNGM3ZFJJN1l0aVQ4SXB3dGtzbHdOaWZIc1I5?=
 =?utf-8?B?bUE4VDR5M0RGazQ3azZnSnhDZ0JYNDdtM3JBc1pSY0JTYjR5a0NUelZKVFJJ?=
 =?utf-8?B?VTFVb3MxdEhXM1R1VGJlUEVSa1pkWXZSYWNCanprb2MydmlwSWhoRTVCTmhq?=
 =?utf-8?B?QnY4OVJMakhUWXdJbzFJbk84cWw0dmZsckxYdVBhcERyR28zZ0kvSDd0L0pz?=
 =?utf-8?B?QmxQMkRwc3o4UnRWSWszOTkwaWlTZkQrcEN2MmVNK2dnRjkzRkFBTHFFckNN?=
 =?utf-8?B?bUJvN1d1c0UwYkx5UnZRRXh6SThBc0ZFaEZhVFJrTG5QMmkwVzZOc1l1dTlx?=
 =?utf-8?B?d3B4a21vS0lNbVhRQ3NjVTZLcm5hKzc3QVB6bXFZSmkvcTliajBKR251TVdN?=
 =?utf-8?B?SEtzOHNXT080YkRjRFlhVWxZZUF5cGtzWHg0a3pCN2ZuWjk0bk12bGxQeWwr?=
 =?utf-8?B?NHBLMTNwY2NYREc4NU1xZVF4ditWY3lRS3ltK0Y1OVIrczZCc29EQ1d3Y0pL?=
 =?utf-8?B?OHNkV3V5ZFJjV2Q4dDNNL0c4Nys1d2RXdEtlTnMwNDJ3YUxibnNveWFHQmQz?=
 =?utf-8?B?V0E5UlNETyt4Z01rWE9Fd1loU3J1OEJlWjNFUnJoWmlSaHNPMnJ1cjlJektn?=
 =?utf-8?B?L3RWeHYvWkRsL2F5U0JqOUZ4alJvSU4rMTdlUTR1ejNzajR1ZFhsQT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2146eb19-8309-446a-d378-08da28ff2748
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 10:09:16.9233
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iq9WOgmXAuAuPPNh0t/4GtHi4Fdbc2V7n3lRvJlOVCZ+9bilF9U19stIpi2hGRTye3F1Nz7IYLzmppfHA+4FNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5898

On 28.04.2022 11:46, Michal Orzel wrote:
> @@ -89,10 +90,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>  })
>  
>  #define gnttab_shared_gfn(d, t, i)                                       \
> -    (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i])
> +    ((void)(d),                                                          \
> +     ((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i])
>  
> -#define gnttab_status_gfn(d, t, i)                                       \
> -    (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i])
> +#define gnttab_status_gfn(d, t, i)                                        \
> +    ((void)(d),                                                           \
> +     ((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i])

Just as a note (I don't mind changing these too): If a macro cares to
evaluate all its arguments, I think it should also care to evaluate all
of them exactly once.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 10:13:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 10:13:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316402.535318 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk19V-0002Cn-Ue; Thu, 28 Apr 2022 10:13:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316402.535318; Thu, 28 Apr 2022 10:13:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk19V-0002Cg-RJ; Thu, 28 Apr 2022 10:13:37 +0000
Received: by outflank-mailman (input) for mailman id 316402;
 Thu, 28 Apr 2022 10:13:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nk19V-0002CF-89
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 10:13:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ddce7183-c6db-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 12:13:36 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-mFdMtEgJMIC2iSxVsFTofw-1; Thu, 28 Apr 2022 12:13:34 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB5972.eurprd04.prod.outlook.com (2603:10a6:208:120::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 10:13:33 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 10:13:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ddce7183-c6db-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651140816;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SOylW/xOk1biFGmAmJblj3puGUp0ilc0fo9TwKsdZDk=;
	b=XTDkRMMIz/volerpIX+ZknoGr4hltTSEshOUbw1+VCVIBpJuz0wXE7AXmXMfM9ZzvoKGAP
	W0uERRTBFVlNaJgFyiopheKtt07JQQPLpxbIbt/kXjOfr7dFByk8mhA0ZSYUBqGWumOcKP
	TU9qBphTm0ET8uKRSnraE23BOPE6NcI=
X-MC-Unique: mFdMtEgJMIC2iSxVsFTofw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gCWFQGUfP9PZQ0v8FXb8NqF3wlsPaumai7ngoYiauu6QPduUBjjmjHhI72TN4FK8O5GjqQLEUgZi05c0qgKwNijKCb4Bv0ISJxUVYbUNf2OvVhwc3tIGXnEz4cYS/dLw1yJUPBrN/DTh5D7u0Rxovgj92GBzBAiHVm4mx6Y4RBj16piyL90W7zBbl+e67k2FTvYgLsRuQaYyJ1AnR7nUqIK8G0JKB7k8JSptKsP4JePOXDK/FwZe5OOPXhpFbL2Ult2tmFsK4l1HFxqxYXKeFu10rfMLJ2MdVszNrl+VkvB4BSlY8Bwlc9jqADgpzoDfX6K7x/UfP8vRGBQm4bCFdQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SOylW/xOk1biFGmAmJblj3puGUp0ilc0fo9TwKsdZDk=;
 b=m9q1rSo1QdJ6/9QrUYZsaPF0SFSy2OCqnp/aQqFOjjTcZ7ChYjONfQaMVEVyM6+0NAlv4yfxwIjB4IIrD5+Nm6R/QCF7SoPsDnKQeuuE9dXCrx35/J8KRxT2nhHhVx/SIjTqS8S4DdrKAt+GTiJAbPWgVNseyB7wi4+hVDCuK0Xkz0TVaCLEHFAEZGHLW1VAop7dSpnsPfhjvD0emS9oB6ELHOoKR90GQDIQAiGooXk2zpF1SnVYtexzQpWgOQj5K20eoxPeudNAyOwEgdWCb2BSng/Qb4TrK3mmDGdkPRAWlb/goOXvCQnizJwCS9vDdRm7d2wVwpXWzITIB84lXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
Date: Thu, 28 Apr 2022 12:13:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86/cet: Support cet=<bool> on the command line
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220428085209.15327-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220428085209.15327-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0028.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::34) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b38a0e3-f476-4ee1-463e-08da28ffbfe6
X-MS-TrafficTypeDiagnostic: AM0PR04MB5972:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5972A22C86B80D7332EB884BB3FD9@AM0PR04MB5972.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AljA8z7Zmq+UqYnkGKxMayJHYi1Kx0T2XE5RV0/RYwKa1H0VN/Txz2eV6XpBXOZisbToVireBE5vIQYdcjWaiwk25l921Ycpv737lXnUtuUnwfKbqOArzcFKXIK9SJCqx7OXGfau6fhaZGlBbyMOJr+TnKyOkjma54EI0JzHDvGxMe4Jpyrrs8IoHM5wvKXkfbkPQXRKYDS/w7SeDQcYCq9WFEnFJyx5BBxZ47huI0aNfSNjiwjvNzus+952DLrXcdMproIEx18erQOTehjHY3xOQQMLIdHI+CTMk70226sJielIsQPL+fIwsC54VbWDb/saLrMNn6+omKlzhDLdXLG5HLDmV0DkfWEVrIRbZLwfFC+P5VcbftdYGZlRHjbfMo0i1W9w4iDBmjNpnPjK8ytVJKw9J2uvtMg1lMMHxn9Chcs8x0dMi5mubZ7LU3RRVfjmnaBW88vh+U4kXbF5E5dXKRYFddIy6KwkWiXTlu+XJ27BOGTcxAQUtJamk5f5TvDGvq8pG69lSoj3sUF6UQEjAyHUcurdIg8D9G5dpLLRL1WlfGZy+HCQl4onW8Zq6ezsSbuF1HFjD/DTGYyY9LEjCAH6fvivOJ1kRAMD6JFmwU+HHm8kLHH6AKVWgDres6/QOggAgmZ3eLx1pnufbbkEd/rdK4b9tExXt5SxzinuvFllRygPuWkTqkLyrQv9EYsDPtNpEInWOeWP5n+GBEwhjBDkeGDX+B76QFAIhewRLkdcejUU+PSwVXHsEDDr
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(316002)(186003)(2906002)(2616005)(86362001)(36756003)(6506007)(31696002)(6512007)(53546011)(26005)(5660300002)(8936002)(4326008)(8676002)(38100700002)(6916009)(54906003)(31686004)(66556008)(66476007)(66946007)(508600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V05Kci9wajViSlFHZ0ZTdnA4N052Q1lvSktYN2I2V05VUG5JOVlxeWR0cXMr?=
 =?utf-8?B?Yzl5Z1BHN1BiRk5qNWJpV21nc3BWYzBMSkQ3Smd4MFFBckhJay9wcG5jMFZz?=
 =?utf-8?B?Y1oxbWhIcC9hb0x0VlQ3amlDWWlkUXhQVkVmMlpYVUEyTjdseVl2R2Rxa2da?=
 =?utf-8?B?Z0V2N3VFNndia0lLc2FYZE9EaUlrUTV5Z1dTL2gzYXJ6MGFwR3AyQXk1Mm1Y?=
 =?utf-8?B?YlVoRVVXTTExUWxpdjhMY1dZSVJhR2k2NVlWa0QwckpFZ0YrS0dCSUlGWis3?=
 =?utf-8?B?TlB1UUtXOFpwMTc3SmVacm12UlhBVXFGM25TaGZ5YmUwakZyWkd5ckhsczN0?=
 =?utf-8?B?S1d0RHpiQS9May9uZHlwTFhheUlXN1Mxd29MdlhLSU9UazhvRGpIbWpGaFph?=
 =?utf-8?B?ZXErdUdiTmVRMVVHcGg3T2VPZG1PbEhoc0NHQ1FQcjBDYTB5WU10eS8zakNK?=
 =?utf-8?B?UGV5TVltRnpyUjBkdkl2YmlUQzh3eFlCRnZlRmwydUNnbXo5UlV0WGhsZ1hM?=
 =?utf-8?B?ZjNRUkhRVzZVL1BRaFpFZmdta25oUW1QcFV1bjlBOWdMZmsveDBraUhsc2lo?=
 =?utf-8?B?MWpKUi9hZDJZUkFEWjNDVVBzR0U2ZW9BNkExNm5VYkIyaE15TjNUVGwrc3c3?=
 =?utf-8?B?U3RIQjhFcEdMQ0lhYTZIS212Y3JTY3EwVjkyV0FNVmw3Y1FEdGdZdmtHMkFt?=
 =?utf-8?B?N2s1UGNTU2Y2ay9iSGpVNHVpY3ZBTVRjdXpSNGgxSGVnMW5uUUtRcmpvYm4r?=
 =?utf-8?B?bWVQbk5BekVsYkRuUVRMcUJyalN0U0tzN0JzcGZDcDhpK2dXbmgzZm51QWYy?=
 =?utf-8?B?MlljT0t1bTdXeGNEZFlsNVd1d2lnNUlERElPWnNpNkhkcUJvRXhsTDhvaC9v?=
 =?utf-8?B?Rmo0b29QSytlRW9jaXRpS1ZWaTJjek1lempCRnNaSEwweEZVWTdrNmNFRXpN?=
 =?utf-8?B?WW93YU5CSlVNeGZSOXR0Q2lUTEF4bUwrQ2JyMUVleEw0L1BoNEJ2M05ONytq?=
 =?utf-8?B?TCtXaEQxWUFBWnlZdzdpTkFXUzR3Ym1udVVIYVAzTElielhRN1VUSTNyenM0?=
 =?utf-8?B?M25sQ2pPeGUxaFl2Z1hWZG9OamY4OWdRcEtoMmhaM2Y4eE9haHMyajNhMDlE?=
 =?utf-8?B?SzZaY2pINkZQSUFBVHhXWTVVQVRWK3RSNW5acklyWWVvL0I5cjFiZC9GRUZi?=
 =?utf-8?B?WnFKMXZkTkJTMkNlNDRRZmxMbWl4bWFDbElFdkIzeWNCdXNISnZBUkE1ekdu?=
 =?utf-8?B?cklkYlRweUdiQ2tVMkZ5a09ZaCt4YjErSFV2dGRwdzJxNy9oNFZNd3BxRDFh?=
 =?utf-8?B?UXRlVmFoRE55ZkNyK2xzTUV5Q0U0UkdsQkE2THJKaGFGRVJDUCtrYkRFb3Z6?=
 =?utf-8?B?YWVUK3QzblVOZnFWay9SNFJsZUt6VE9CVWlhOHFuaGt1alhzeEcrTk5zdmFV?=
 =?utf-8?B?d2RkcDdJb25sMkpNSlV5aFk0MlBsaW1vcEo4bkQ2WHNaYWw1cXAzY1E2YmNz?=
 =?utf-8?B?NnVnYlppbTJSN1M5blBDNzBMV2ZMTEVDbkV0S2NlZDVKcjh0dDZOK0JiajV6?=
 =?utf-8?B?QkhicFBpZG5SNG5FOTQ3SjRtQmpyMzRNSUppalZSQ0dEbnhIbS9kSVRuYjg4?=
 =?utf-8?B?WFBQVDBiVGtndjBZaEpFOWhkcFUvUGVUYUd4WXVhQi9Oc2tlSCtlV3NqVi9x?=
 =?utf-8?B?Sndra0dsUndtSUxHRWh3a3lKV0JHWVVjbTJCREtkTkVhSE1qK3Y2UjRGMVpM?=
 =?utf-8?B?bjNQNzNuQnd4YXV1V25RRmxiZTFZWXJlVGZ5dysyc0JBREw0OTFGMERYMFlh?=
 =?utf-8?B?MjhsTVpLSHBpbmpnQVJiOUpjU3FFajg1L2VaaGJXMmRJdmtIUXcwQlJpWlpK?=
 =?utf-8?B?M1QzTjJoRnNLSVNpVlVxemdtb1dobXY4YnFqMUVkSzRhQkpqRitGaS8rWVlr?=
 =?utf-8?B?cjZLUjBBenlHMFczbVZVNS9SS2dlbmhYMkpmUWRlam9leEpZbklFaDN5YXVR?=
 =?utf-8?B?djdvKzZvaGxEWG4rZ3djT1ZWbHIyVWRrWTdmM3doVVN2bXo5QStFcFN0OXBH?=
 =?utf-8?B?RWxkZUdIbFJMazh6NzFWSFFnaTE1VU9NVlFtR2Rjc3JuRkU4OEZxSXVLM211?=
 =?utf-8?B?ZnRLdUtTMjBqQWNXb2g1VVFLc3NQbWg5MUQvVnFZM0VTMXNjRmdwYTV0czc3?=
 =?utf-8?B?bTVCOXl5eTFOcWFxcVlTdXc0Vmk1Z2NZRWl2a2RVSlR6Y0hiN00yUUJDM01y?=
 =?utf-8?B?bFdqekFmeXBTcWxzdzJSeksvWDYxMzBvNHlXdFRVa2VFd0ZMdkNoVzI0ZGd3?=
 =?utf-8?B?YWhjK0F3UnVXWkhmaitsR2hqR1VDUWxCUVFheCtYTUVwQjA2aEE1QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b38a0e3-f476-4ee1-463e-08da28ffbfe6
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 10:13:32.9063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q4gDc/2sLMMXa6C6N3LJGS1YOAJDjrEQZ80z9CAI5xBLJyk6LwLmI0JyI2s9hKHXLAuCzgjIjqbRwOWjOlnDdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5972

On 28.04.2022 10:52, Andrew Cooper wrote:
> @@ -283,6 +283,8 @@ CET is incompatible with 32bit PV guests.  If any CET sub-options are active,
>  they will override the `pv=32` boolean to `false`.  Backwards compatibility
>  can be maintained with the pv-shim mechanism.
>  
> +*   An unqualified boolean is shorthand for setting all suboptions at once.

You're the native speaker, but I wonder whether there an "a" missing
before "shorthand".

> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -117,7 +117,20 @@ static int __init cf_check parse_cet(const char *s)
>          if ( !ss )
>              ss = strchr(s, '\0');
>  
> -        if ( (val = parse_boolean("shstk", s, ss)) >= 0 )
> +        if ( (val = parse_bool(s, ss)) >= 0 )
> +        {
> +#ifdef CONFIG_XEN_SHSTK
> +            opt_xen_shstk = val;
> +#else
> +            no_config_param("XEN_SHSTK", "cet", s, ss);
> +#endif
> +#ifdef CONFIG_XEN_IBT
> +            opt_xen_ibt = val;
> +#else
> +            no_config_param("XEN_IBT", "cet", s, ss);
> +#endif

There shouldn't be two invocations of no_config_param() here; imo if
either CONFIG_* is defined, use of the option shouldn't produce any
warning at all.

> +        }
> +        else if ( (val = parse_boolean("shstk", s, ss)) >= 0 )
>          {
>  #ifdef CONFIG_XEN_SHSTK
>              opt_xen_shstk = val;

Having seen Roger's reply, I'd like to make explicit that I don't
mind us allowing strange option combinations to be used, so long as
what we do matches the sequence in which they were provided.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 10:34:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 10:34:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316411.535329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk1Tb-0004bm-NK; Thu, 28 Apr 2022 10:34:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316411.535329; Thu, 28 Apr 2022 10:34:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk1Tb-0004bf-K1; Thu, 28 Apr 2022 10:34:23 +0000
Received: by outflank-mailman (input) for mailman id 316411;
 Thu, 28 Apr 2022 10:34:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oMo3=VG=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1nk1Ta-0004bZ-Sk
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 10:34:22 +0000
Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com
 [2a00:1450:4864:20::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c408c76a-c6de-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 12:34:21 +0200 (CEST)
Received: by mail-ej1-x630.google.com with SMTP id g6so8691581ejw.1
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 03:34:21 -0700 (PDT)
Received: from zen.linaroharston ([51.148.130.216])
 by smtp.gmail.com with ESMTPSA id
 z19-20020aa7cf93000000b0042617ba63a6sm1321952edx.48.2022.04.28.03.34.19
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 28 Apr 2022 03:34:19 -0700 (PDT)
Received: from zen.lan (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 1460B1FFB7;
 Thu, 28 Apr 2022 11:34:19 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c408c76a-c6de-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=b+QXBSMsT4vIBjhfjMiEyj5eYLbGz4qzg2d34+w60ac=;
        b=gnuxFjU6+xf1chs27XrAO54xQu1FL3sXqQaRSduZ/7xTfQmiOltGyx3Fe2p6Vifbox
         gIx6u+9a3HeZpgyE74w/j9rDFMOlI980fsMbawkgtZA26GTYhsAh1tlzytBxW/Tlj6BC
         uuoPxP40Xu7Y1u0YrTvh1t5NE1Ozs1XXfxgrYHIZyhT3dbs5Q0YMiIwvvEWfV/s04FTS
         kiOV+fwJK9MJ4wT8pb4GA4C0VgXqWlWtFzV4qEO5+/cQoyBSpdLD8F8/2DPjclFWavnu
         ln4XRkjo762TVyfcpGiiM0MRzQV76G36t+p8J+gazAOg27tZttAlymxYG26qMJyN0epZ
         CVEQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=b+QXBSMsT4vIBjhfjMiEyj5eYLbGz4qzg2d34+w60ac=;
        b=utpPeA39bSv3bVzjNrMwOEpHmmU6BD+cfvh0LT1Iy69DcasiDshZPcQpe/oaByP29d
         NA4Rpxd6opaHh9P2ZjYobIkhKdLnmjWPtcFIfH5c9eFsL+SArKeaHAmYxfHmCfh08u0B
         BNFmmPCqYiWTUKbF3WeAij49E0+IFGC0d6W9KRyJleve8OdjVd/SiWv33xz6s1Yw9s+l
         Xlrcs/IDJPKn/2EpqM50gqDMYBOyuRHdIMmF87KeuiFj4D8ODy/wd/DI2QZxX/41crs8
         m5fPXdkVR4tmC9YAMEscgAidLfIm10eeY7+jLs8LM4Okz0rNC9aoTMXyjbDmALA6ohkU
         2Tbg==
X-Gm-Message-State: AOAM531wBJOI/dopKakCHQ8QidlcSjaepHnGlMzVgLEnlRTrdSDhu4Bf
	6B74bdYC9nFFaQ3S/DN9pESTPA==
X-Google-Smtp-Source: ABdhPJwsC25T+v0zCyeGasMm2dh3B+mS7qseNHEWvP654mvQ/Yvlek5ctOOAPIognlHMvbnzt6vI1Q==
X-Received: by 2002:a17:906:d288:b0:6f3:cb6f:428f with SMTP id ay8-20020a170906d28800b006f3cb6f428fmr6979307ejb.332.1651142061244;
        Thu, 28 Apr 2022 03:34:21 -0700 (PDT)
From: =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: stratos-dev@op-lists.linaro.org,
	=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw
Date: Thu, 28 Apr 2022 11:34:10 +0100
Message-Id: <20220428103410.2723837-1-alex.bennee@linaro.org>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When we introduced FEAT_LPA to QEMU's -cpu max we discovered older
kernels had a bug where the physical address was copied directly from
ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commits
the same error by blindly copying across the max supported range.

Unsurprisingly when the page tables aren't set up for these greater
ranges hilarity ensues and the hypervisor crashes fairly early on in
the boot-up sequence. This happens when we write to the control
register in enable_mmu().

Attempt to fix this the same way as the Linux kernel does by gating
PARange to the maximum the hypervisor can handle. I also had to fix up
code in p2m which panics when it sees an "invalid" entry in PARange.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>

---
v2
  - clamp p2m_ipa_bits = PADDR_BIT instead
---
 xen/arch/arm/arm64/head.S |  6 ++++++
 xen/arch/arm/p2m.c        | 10 +++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index aa1f88c764..057dd5d925 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -473,6 +473,12 @@ cpu_init:
         ldr   x0, =(TCR_RES1|TCR_SH0_IS|TCR_ORGN0_WBWA|TCR_IRGN0_WBWA|TCR_T0SZ(64-48))
         /* ID_AA64MMFR0_EL1[3:0] (PARange) corresponds to TCR_EL2[18:16] (PS) */
         mrs   x1, ID_AA64MMFR0_EL1
+        /* Limit to 48 bits, 256TB PA range (#5) */
+        ubfm  x1, x1, #0, #3
+        mov   x2, #5
+        cmp   x1, x2
+        csel  x1, x1, x2, lt
+
         bfi   x0, x1, #16, #3
 
         msr   tcr_el2, x0
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index fb71fa4c1c..3349b464a3 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -32,10 +32,10 @@ static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT;
 #define P2M_ROOT_PAGES    (1<<P2M_ROOT_ORDER)
 
 /*
- * Set larger than any possible value, so the number of IPA bits can be
+ * Set to the maximum configured support for IPA bits, so the number of IPA bits can be
  * restricted by external entity (e.g. IOMMU).
  */
-unsigned int __read_mostly p2m_ipa_bits = 64;
+unsigned int __read_mostly p2m_ipa_bits = PADDR_BITS;
 
 /* Helpers to lookup the properties of each level */
 static const paddr_t level_masks[] =
@@ -2030,7 +2030,7 @@ void __init setup_virt_paging(void)
         unsigned int root_order; /* Page order of the root of the p2m */
         unsigned int sl0;    /* Desired SL0, maximum in comment */
     } pa_range_info[] = {
-        /* T0SZ minimum and SL0 maximum from ARM DDI 0487A.b Table D4-5 */
+        /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */
         /*      PA size, t0sz(min), root-order, sl0(max) */
         [0] = { 32,      32/*32*/,  0,          1 },
         [1] = { 36,      28/*28*/,  0,          1 },
@@ -2038,7 +2038,7 @@ void __init setup_virt_paging(void)
         [3] = { 42,      22/*22*/,  3,          1 },
         [4] = { 44,      20/*20*/,  0,          2 },
         [5] = { 48,      16/*16*/,  0,          2 },
-        [6] = { 0 }, /* Invalid */
+        [6] = { 52,      12/*12*/,  3,          3 },
         [7] = { 0 }  /* Invalid */
     };
 
@@ -2069,7 +2069,7 @@ void __init setup_virt_paging(void)
         }
     }
 
-    /* pa_range is 4 bits, but the defined encodings are only 3 bits */
+    /* pa_range is 4 bits but we don't support all modes */
     if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits )
         panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", pa_range);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 10:39:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 10:39:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316419.535340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk1YU-0005FY-AQ; Thu, 28 Apr 2022 10:39:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316419.535340; Thu, 28 Apr 2022 10:39:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk1YU-0005FR-7I; Thu, 28 Apr 2022 10:39:26 +0000
Received: by outflank-mailman (input) for mailman id 316419;
 Thu, 28 Apr 2022 10:39:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nk1YT-0005FL-Cv
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 10:39:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 783a1ac2-c6df-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 12:39:24 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-yb0f5BHSO_iZvZtG0dn_Qg-1; Thu, 28 Apr 2022 12:39:21 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DBAPR04MB7415.eurprd04.prod.outlook.com (2603:10a6:10:1aa::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 10:39:21 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 10:39:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 783a1ac2-c6df-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651142363;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lEDezbWKENeWgQHA+ZYebJ9iu3swu/0Z4wX2q7pOqQY=;
	b=c9YyUhr7uynaebmZ1tmE4unbAsdzPieQ/k3CYIk2Bsy4vhtbn5MEsi0iXw4DnM4Yc/277b
	E6/twqy7UAVEKCVuN1SVTrZzc8KEHHgz+RmyUqRmHap1GCyVPNIshtwVMTGhixrKG98xrc
	Td2G1GDlZPHpkUMUOXa+6TovnolSRrE=
X-MC-Unique: yb0f5BHSO_iZvZtG0dn_Qg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m1OWSYfBkdWhWbcnyu+2zvMO23/E2cHPCOcPN0bNRKZ7nYuTRjObJnstOJYazGzioHufJ7orUMtDXCXmrCLVsZyo44Za3ph5lWnUO81hUEfGoWL3rGD3kVVVv0DZljGBdCY80eifYzUfOgYJeRdwUJYmlOum7kaaxx0HiJ0VU8aII2cSZ7lCuAwT9QysYs6tlDuBXwVUI1YZ6q+qKHj8DWZQvNZMOpc2lbtAzGE1s3WJwNUNBtQ+kqmxdZH5LqQjAwOvTD265iBoVS2bT9/dyG7QTQoIjfISGXuhgpA+2DgdMbBj70/HwRyBVYis74oggzwK1M6UM1ng7M81ah93mg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lEDezbWKENeWgQHA+ZYebJ9iu3swu/0Z4wX2q7pOqQY=;
 b=MklIyz2Ph/jN/OoBvgxjqvv9zs0yp8xNX43Da+lh2nBCKFphxGPQoHRenohtr3sjiHpUenBSGFNjjzrlPnjCPerDpybNiMbYXouj2CkQF6dsfzivz2RK/WKgCjUnKfmwMcK6dDCdsg9djbBoRwZGyEoKCRbC8sks7YZ3qxa7jnUxz2FVH3jS3vt6GMfxJSjigBHaLKCFNNWTISlf17w1X36800soUi2gAC36msItoZ2OGSzhri9Bq8Iff9hknn4vKY1Fb+GoGsLPHkOvHHUnF1OwOzVdrsCXdnu5kKPELjIoojNeLxs0YuPSBzVFjee389AQiSnflZQ5CHcMX/gnVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4843821d-4e9b-f57d-cf84-375f0b8a3ff2@suse.com>
Date: Thu, 28 Apr 2022 12:39:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Steffen Einsle <einsle@phptrix.de>, xen-devel@lists.xenproject.org
References: <20220428091359.90431-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220428091359.90431-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0033.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 372bb576-5222-4955-de94-08da29035a82
X-MS-TrafficTypeDiagnostic: DBAPR04MB7415:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB7415B86AA231D065F305EE84B3FD9@DBAPR04MB7415.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KnkRFYt+wXkRA8lPfAAOryMKddEyss05JppshC0GRwtMuF9Hh8xUlMWPrmrq+QC9C1cnNr9dKz/ykBaWopREh+Buep0qY/xMHhkAzKq/zi/4HNtI9SQ/CiOXRJRIp6Ibf3es4/QzgdAqzzuhXH5VImC7HIxMkb3LL7Y9bWdf/MVz+8zmpVoe0FnZxscxlVWzvaP/DuixfTNIZ16b7jveDPw/WZHwIWNA+2upSOQo927ILcsPSWb8eAxxAWVQoksSYz1NJmGs69S2kuZNiD1vJbJxABeRzpm6Pe0S0uB2PDMJM4CJCcSE4hUDcMm8HWKjdee4+2KndvFqeZHmP+DLBEy8GwaW0fqxX9ESCRXOYRq6lUDzgoks0Tib2Mau/HCsoK3anq9LyPieRK6mF/B/aNmx2FJrI4IpYrAkXTsDlhFuFeS7lNbQYjC8pMfYzax7mj5F4dgTEZ620AmloV0jQhftkzoHg0GY++8XNaZ9R5mbIakxjdDqXQ2W8SaJdhiT1/NRqOCs66SRzdoj64FLZ2rHDYnCZrg18iymZli2/FVfrfhLRA3g3DcmOApR22goSFJPp1BSQCW4OBOelz1+R+56n028SBJPtfMSRhQCPjBgau+ztjXQtNOVmp6gczhIOOso2AKmmD4meeH7e/uvLnVUqWN1u0M9IS9+MkXKyFPzXkc1CBLJDLyl4yPo521hD9vCW/HH1Meh9IDpmUyEahZcx8CZGW9PqEZxWa+WJwk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(66946007)(36756003)(66556008)(2906002)(186003)(316002)(8676002)(4326008)(83380400001)(66476007)(6916009)(54906003)(31686004)(8936002)(2616005)(86362001)(6486002)(31696002)(508600001)(38100700002)(26005)(53546011)(6512007)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWphd05FL2JTdGdDVExUZHNJOGFKS2xsU1VkUUJDaU9qMk9YSWY3a3dDNkhI?=
 =?utf-8?B?bllzZVBsSExWNEdEK05uV2dNV3dhWFI2RlU1U0MweDNqR1k4SjdmdU8raDFO?=
 =?utf-8?B?cG4xQlZUN1dDMFlpaXFNZHFFZlNvVW0yemI4cXh4VGhpUFIyR3diYmUzRVIy?=
 =?utf-8?B?bHFNYWNMK1Y1bXR6M0dZRVJJcHN5T1hkSTZCN3pYNXo4TjNDaWlJQXJNZE9i?=
 =?utf-8?B?UnhEY3lVUmN5TUJSZWxiQUVjeFZlQy9VU05DL0JaN21ZZGNuRTBqalB6Umpm?=
 =?utf-8?B?Qk5VVW9Sb3h4Yjc5aU42Ky9qbmVmbE1jeUhRSjJ5M3lxM0h0UklRbjE2NVJN?=
 =?utf-8?B?ODBsc21sQVFmSGt0OWxBRjAyQTNCVDM3dkttbERmdUlVbHlVSXYyUGhQcGRT?=
 =?utf-8?B?RWdNUkNMdXgrQW0rMDVkZmhCSENRenZRVUw2RE0zVC9BaEVockNvZzJpN1I2?=
 =?utf-8?B?MEp2WVR6dXhmQnllNmRqbWVJUlVwUEFZUHJOTkNWTkhVQ0s3NlM0aXE1QVpB?=
 =?utf-8?B?YktldjlaUHdseGZad0l4dERPbWVvaTdoWnc5ZlhXUnNXbldPeFk1blVQSlRU?=
 =?utf-8?B?VXFGSlA3S1hIZWlmQi9sK2hGZU5HOHBsL3c2ZTR0cXlMYTBTOGcycDRha3Bp?=
 =?utf-8?B?WWpyTFlpS3NNa0dqL0ZqdHUvQnJKMWlHNFBjNGlrV1I3WHQrVkI2SFhMZVlM?=
 =?utf-8?B?TGZ0bE9Cd2pDZFFubHhBdVhUQzN3UVVsZ3lrV3dlWnZPT3psUnFzR0hOd095?=
 =?utf-8?B?TmZZU21IWWh1dGQrVzBuNFlYdU9Eb2FNbGxHTDZVZFgwZEJyd0h4Wk52S3Ny?=
 =?utf-8?B?Y0pjeDUrbFhUQUZBWmlaWnRrWlNMUmI4YUlramMvZy9sb24zV3dVTHhKOXkx?=
 =?utf-8?B?VFJFR01hbjdBQVlCd042TWN6aTNNM09EVGVZVytvOURHU0Fhd0NYZHJxbm5x?=
 =?utf-8?B?QkgrOU1TUEFnTUM3MUEyWUhUMnlnRDBxRUFJQy94YXRnV2xNRkZTb0Vkc3FP?=
 =?utf-8?B?OWdGVkc4bloyS3ZiaTY2b0l1N1dtUDBGREVncFRZK0JjS2FubWpRMFBMdHBa?=
 =?utf-8?B?M3FjLzlHVjcreVVGeDd5M3FqSndZQi9zbGphQVAvODZSbkdqc3lmSGNmc096?=
 =?utf-8?B?bk1XWHcvYTZuV3l1YVBHa2MwWmljZXNxSStvTlRyby9PM3EwQmJ1Q2lLSHoy?=
 =?utf-8?B?Y25LaGZic2RWRGR3bE40elk0cURvbUR6R05mcGtXazQrQjVEVW9zWkN4d2lY?=
 =?utf-8?B?ZjloQUZCWUEvNllEeGYrbCtQVHBZRWw2d0h3czErcktMaTJJeDZaZzRsZVov?=
 =?utf-8?B?RjRyT3dBWjYyV2NpOE1JU1pSTEJaTU1mS1VleVlLclNxbTYrdEFGSkluQVRl?=
 =?utf-8?B?MURlTlg2cUIydWVic0l4Tm96ZU1IMlljOWNVTENUcGRqYVA2RUljeUx0ZVBK?=
 =?utf-8?B?NXBWODNkTkZGdmVRSFBEbzEyMnh4ZDFnb0Nqc1pVN2h4cUdYZ25xTXVGSnpH?=
 =?utf-8?B?UTVUKy9FMFBaL2FoaGIvL2MxVGRmSk45V3pHT3k1MEx3RDZnOGhNMEdwaThp?=
 =?utf-8?B?Ymo5VWlnTktVcXJhendacHBDalFWTDA4Rm51dEpsUE1hWXV2eitqaWVVdml5?=
 =?utf-8?B?bW14TmRqa1lnb1lVdEJFQXIzeEt4ZXMxWVhIZjVVbEZiU1Y0LzFKZU83WENB?=
 =?utf-8?B?QlQ2YzdSS080K0RwYUZlZU1mWm9PZFJSaFcvQWJBNWlBa3p5N3JyWGJHQTJU?=
 =?utf-8?B?cUd4UG1FbmU5SlNlN1B1eHoxZTU0NlJhTFVVUlNnOVFDWmxpaTdPb2Q0MnBk?=
 =?utf-8?B?NGlNNDFxYmlySTBxYm15dnJDRVIrL24xbEs5SW0vK2VqaWdrZmV3SUFueTlj?=
 =?utf-8?B?aENOQjMrNldRbzhmb2ZaYTVNQS9OOXdDSVZtaHVDcGJMWnhIL1M4OTdtWVVZ?=
 =?utf-8?B?aXhFSmZLMGhvNTYvdVVyYXBXNGZWWGRPVzQ0c2JXb240UW5mVnZmLy9kVTBa?=
 =?utf-8?B?Q053dzM4b3I4WlhZdlBRNkc4Tmg1Nmt0T2t4NHRXSGhPMjdyd2JmcnE4cVFS?=
 =?utf-8?B?dmVYTEZ1NmR4bytHTWpldmd0NnN1NVhDdEV2dU54NC9Pd0hHbVEyd3ZnYnNL?=
 =?utf-8?B?ZklCam1EcTB5MEdKWEh4UUpxWmx4WGt3a1pyMFV2L0RIdGRVQXdYZjdNZ2FX?=
 =?utf-8?B?ajBsdldDUGtlRExrenArVlNJNFNIMzJoczZCTVBPQ08zOGJBWkgrYUluR3BW?=
 =?utf-8?B?c0F5TTF3aUZkN2VFenZBYUkzdUhodFBlcnhRaWZZSVhFRENqRXRWUDU1R1dT?=
 =?utf-8?B?OVI5d3BueEExRXpURm81SXk3RlpzbUI4VVZoeU9YYnRrSmQ1NSthUT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 372bb576-5222-4955-de94-08da29035a82
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 10:39:20.7919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i7e4awNuBFJrTEtzPPXCmGcLMGrsxgoEvPGwFfpMLMIhphqV7TRtT2qH6eZSX7uKbeKEsqjsVSvdXfEE7bUFzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7415

On 28.04.2022 11:13, Roger Pau Monne wrote:
> --- a/xen/arch/x86/cpu/mcheck/mce.h
> +++ b/xen/arch/x86/cpu/mcheck/mce.h
> @@ -169,6 +169,11 @@ static inline int mce_vendor_bank_msr(const struct vcpu *v, uint32_t msr)
>          if (msr >= MSR_IA32_MC0_CTL2 &&
>              msr < MSR_IA32_MCx_CTL2(v->arch.vmce.mcg_cap & MCG_CAP_COUNT) )
>              return 1;
> +
> +    case X86_VENDOR_CENTAUR:
> +    case X86_VENDOR_SHANGHAI:
> +        if (msr == MSR_P5_MC_ADDR || msr == MSR_P5_MC_TYPE)
> +            return 1;
>          break;

You want to have some fall-through annotation there, perhaps preferably
the pseudo-keyword one.

> --- a/xen/arch/x86/cpu/mcheck/mce_intel.c
> +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
> @@ -1008,8 +1008,24 @@ int vmce_intel_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
>  
>  int vmce_intel_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val)
>  {
> +    const struct cpuid_policy *cp = v->domain->arch.cpuid;
>      unsigned int bank = msr - MSR_IA32_MC0_CTL2;
>  
> +    switch ( msr )
> +    {
> +    case MSR_P5_MC_ADDR:
> +        /* Bank 0 is used for the 'bank 0 quirk' on older processors. */
> +        *val = v->arch.vmce.bank[1].mci_addr;
> +        return 1;
> +
> +    case MSR_P5_MC_TYPE:
> +        *val = v->arch.vmce.bank[1].mci_status;
> +        return 1;
> +    }

Could I ask you to add a reference to vcpu_fill_mc_msrs() in the comment?

> +    if ( cp->x86_vendor & (X86_VENDOR_CENTAUR | X86_VENDOR_SHANGHAI) )
> +        return 0;

I think this better would be !(cp->x86_vendor & X86_VENDOR_INTEL).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 10:53:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 10:53:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316436.535355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk1lg-0007gh-OJ; Thu, 28 Apr 2022 10:53:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316436.535355; Thu, 28 Apr 2022 10:53:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk1lg-0007ga-Ke; Thu, 28 Apr 2022 10:53:04 +0000
Received: by outflank-mailman (input) for mailman id 316436;
 Thu, 28 Apr 2022 10:53:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nk1le-0007gK-6z
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 10:53:02 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5db9c68c-c6e1-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 12:53:00 +0200 (CEST)
Received: from mail-bn8nam12lp2175.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 06:52:57 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SN6PR03MB4255.namprd03.prod.outlook.com (2603:10b6:805:bc::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 10:52:54 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 10:52:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5db9c68c-c6e1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651143180;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Z61ehkT4y0mzG0gbmx+gOfonJoFan/0VGSVnm2X9FE4=;
  b=QsQ1SAP/ZEYjPoJnBNy9KQKvLXpP3IGHpbi8jOym7EnZnTwvhgRH6K9q
   Pl9gC7BTKddF+aVozdc1Mf+mHaAHrLcEFrRlf5BKBa++9ON5Urf0dipaN
   FZnWrHhr14ctbM3VahSc/boA59vrGfK39NKejdqhcWEvxBt2rf4sdmyQH
   I=;
X-IronPort-RemoteIP: 104.47.55.175
X-IronPort-MID: 70531904
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:MPRQaqhXKkHs+T+ZrDbZNfhEX161YREKZh0ujC45NGQN5FlHY01je
 htvW26GO6yOMTH1c9B0OYqz9EgDuJTUmtRmTQZr/yljE3wb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nd4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YVw2BpbFx91aahtJVCEiJK5Ev+DsYlHq5KR/z2WeG5ft69NHKRhseKc+qqNwC2wI8
 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehWht7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wrI/vNmuzS7IApZ0aDEFsuMQdmzBtRJx32dl
 FOYzVTnDURPXDCY4X/fmp62vcfNly7mXIMZFJWj6+VnxlaUwwQ7Fxk+RVa95/6jhSaWVtNZM
 EgZ0jIutbQo9VztQtSVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QbWNQeQDUr0
 hqDmYPvDDk26rmNEyvCq/GTsC+4PjUTISkafygYQAAZ4t7l5oYukhbISdUlG6mw5jHoJQzNL
 /mxhHBWr90uYQQjjs1XIXivb+qQm6X0
IronPort-HdrOrdr: A9a23:IFQ0X6zWZWu/fORnXdZ/KrPxsOskLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICOgqTM6ftWzd1FdAQ7sD0WKP+UyCJ8S6zJ8n6U
 4CSdkDNDSTNykcsS+S2mDRfbcdKZu8gcaVbI/lvgpQpGpRGsVdBmlCe2Sm+hocfng9OXN1Lu
 vr2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnR4j4uFxd0hZsy+2
 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUpZ5Sy+BQO5M2/4lcjl9
 fB5z8mIsRI8nvUOlq4pBP8sjOQpQoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L
 gj5RPUi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZMIMvD0vFoLA
 BSNrCc2B4PGmnqL0wx/1MfiuBEZ05DUStvGSM5y4+oOzs/pgEK86JX/r1cop46zuNCd3B13Z
 W6Dk1WrsA+ciY3V9MIOA5Te7rBNoTyKSi8QF66EBDAKJwtHU7rhtre3IgVjdvaC6DgiqFC06
 j8bA==
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="70531904"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lEQAkElepIYxpTRyVDqC5/qbBdBXHLZHgjVkHWBd+891ocxeTGeQyG01ZGp88VzAHsWTH8a5z1I+ZC5K4gzePNFoejkmc7F2g1jarQm/1l/SDA444ORyg2Vx7Qnp91hljLZWNKZsv98NDFtye7olvBmRCoZdw3q2joG23sHiV3IXA9nx79VNFRtCnmzKVfPvF+0c3tvy5KXsCb8Uu84zrcExYOkH9WaYjSuSVcx06b+w6VBUNBgjtrtgjnrJUM2AL9wOloWODn6BicVAxi/muBqnUDgEMF46ZYE44vBu9BhUHrDrh+PiRRaTYmsYnS+gQrm5/VlosXA5uJ5gsjoAWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LX8f38mpLEajZFN110opSJeEK9TsOBhL4snGced19tU=;
 b=U+Z55g9Dq7AK/VNftslW/g/UnQy2FIaLXqrLU2pVH57fS5sk2spYre4MDiUilqKv1BFbTf20SVlOJ4mHrL3/DJYkpLAyYYcjIlTFJai9I+WwbjfyW/n/BTOXqk06Dn95zGsSIofpBrfpHlC8/9fEtBkNtXLHvqF8vVHDEQ2VadWw20C4Bfa/egbdshIq0OdCY/zfu7cXREx+BG1v4143E/0VkEMNVfgstXgDvF5D/oLhkwcESVL49AwY9OuSfc+ejfEoNV+qfpj4NNbhLkzG4U7oxzVp2Bx0eujiwGlmPX/1qSTYjzZ+zL35mVYUDnwIrKUyH+afvIG2/j5H8RxXWA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LX8f38mpLEajZFN110opSJeEK9TsOBhL4snGced19tU=;
 b=BAVW2UY+N1gWVyy3Vk8kUl0GH+GeB/XgWhKc0VlyEGxnSs6b3JVfFI/m6px0xhTjmRY2ZXhJ+y37RUhCS7mImq/TsK7LteoD9te5mS1lyzifd21uQ163bZQmcLakMqpDuRsgmKeeLQSRfm2DlojyT1h2QaPApHnXWh/R824eh+c=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 28 Apr 2022 12:52:50 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Steffen Einsle <einsle@phptrix.de>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}
Message-ID: <YmpyAkgmqphvI9oQ@Air-de-Roger>
References: <20220428091359.90431-1-roger.pau@citrix.com>
 <4843821d-4e9b-f57d-cf84-375f0b8a3ff2@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4843821d-4e9b-f57d-cf84-375f0b8a3ff2@suse.com>
X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 64ddddc2-6411-467e-935c-08da29053f61
X-MS-TrafficTypeDiagnostic: SN6PR03MB4255:EE_
X-Microsoft-Antispam-PRVS:
	<SN6PR03MB4255EF9269E1863865F051108FFD9@SN6PR03MB4255.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	864GAOUhD9wDvKNOYSwvQ3074CQXa0XKpYa8IlIZD49jsYbUR3fuFJPcUX0cjNYy6tvjKyMgVc/qaN56oM6GmOOxatnAvrmeZ7iREVHitzELvv/qWbkYTqXMfdlli0W38OtR1SmfPsBCnZGBHcNhD4A5ri31HVzYEBZIuR3f2IQ473X0UdY/mUC6684RjmZSDlY4FbL9UiKcK+IEQkaEmbldw475jIvrUE92/QydaMj5CWafUSRxoHpe0jsttfAq2iRRmxkpC5WzpPp1D0JHy/Zjf1Lfivvk8gTRnKdrqw96m0+7a4KUYSTP9sCTHrgQB2OYO08igbwSLa9Zcr85tJp3ASYNcRDfpaCNDrzmsOAdP2coSK+BcM/AIYJDaWH9s5WRbvijbXIJT/y3K9/3g/QaLwTvDMe4N0kBZTpbFmS2uWXN9B0aHkhVE33EcWlqaV35l2zU6ylhTKuK7jIX2rISMhSsCftbBReHK91SY8jQGEU3sPOq8l89PC/dGOvwMxjWniPaZ60jBDxiUnNOc5p6A7/4i2SfWZ0ygM6uIvf8I0N2Z32igFWIe8b2CF3j7ki44zP7NX1yJWmehmzcTWeGAmyDvSO3QDWMg46aVbyfmA8KbGUn2JyDIdELfaxfq5qWssiAB3uauvI46Wdzyw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(508600001)(6916009)(33716001)(6666004)(85182001)(54906003)(53546011)(6512007)(9686003)(6486002)(26005)(4744005)(66556008)(5660300002)(82960400001)(8676002)(86362001)(4326008)(316002)(66946007)(8936002)(66476007)(2906002)(186003)(38100700002)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dGV0eUNacVJkMzZ5T2pSaUlLYkp5S1Q0d3U4NlJzczdDRHpyaHJmL0QwUUph?=
 =?utf-8?B?MGt6YWhZYWFNSjdiNjRUVjF1a0tOTjBOV2QzYS9jRE95RElGcG42UmM2djJy?=
 =?utf-8?B?MnVmVXMvVWEwL0lEL002ZGZrRUpscy9lWFh5OEFXNWhJN3Jwc0ZIazlzcGt1?=
 =?utf-8?B?bUt4K1pERVpmVDNPVUVwQzdNWmVadTlhUk9kckVheVZyMjM1T1VIMHdwRFAz?=
 =?utf-8?B?UjhnR3dDc3FVTkN6eHhoVzZRK2tDeXR6M3BkR21kK3g0eVEwMktmRm5BUWZV?=
 =?utf-8?B?VlIyVnV5N1VVTllqUXJmUmg4TU1HWmdpZXhmcVRkdy9VMkc2VTlXWVNiNlBx?=
 =?utf-8?B?OWpLRndkM2hya1FUdmVReWdBd3hLYTBRUzNLcG9lSU94M055YVd0TTJQMjZS?=
 =?utf-8?B?TkNGZ0ZaemhxUDN0cmExRnVzNnovSnZFaFhVUmhwR1huRWN4eUU0RjdCVkdR?=
 =?utf-8?B?WXFwVGRob28rWmFRaDFIUVJsZ1NJTytrcnRWdWNXTkZwYW1vV2VJTlYzKzlo?=
 =?utf-8?B?cVNnS2NkbkJJNFRQOFlyeElFQUhGenM0MG1jaUgrRGNpcUNXcU1naHl6ZmFT?=
 =?utf-8?B?cGNJYkNUYnhsa1MxYng1cHJnVTJFLzFpUHdranJkdXpIbzZ5Z2NDbmF0Z2JP?=
 =?utf-8?B?d1JTTGVmTk1ub3QxQ3hxVDBoLzFpTUExYzJ5ZVZZWERBeDA5dTBSMDJCeFA2?=
 =?utf-8?B?STVJQ1V1eFVLSllzdHVERlljdXFMSVZPM20xdDJqOUlMUjMzSUxZSndSVWNS?=
 =?utf-8?B?S2RhYVJjVldLSjQ4dklHR3I0NUpza25hTmQwYXlDZXd6c0czRUVGZis0TVc0?=
 =?utf-8?B?TGpmSm5sL0h3dmdvSjZGWVNTZ0trRHpRQmcvcjJrR3ZvdEpvYy9mV0J3cFFp?=
 =?utf-8?B?Z3VoOSs1Yk8wMm15RUdwNHZKeFVqd24zbnBIcy9WZllDcGxwWkVZbTlxOHVV?=
 =?utf-8?B?Rno3RjRkNGMwenNXK3FESzM4cUwxbWFQZE1TU28xN3dXTDZ6KytFY0JydmJy?=
 =?utf-8?B?ZmpOaE54MG0zaXJUeDhkdXVwTjBZcVREbk9KVmU3ZjFSOENZdDhTSzhDbytB?=
 =?utf-8?B?Z3V6eTBKOGJDVVVzSWZ6VkN6MFdUUndzSlBwRldHcHFYdG9mWHFTOFZMS0Rm?=
 =?utf-8?B?ZmVhcEVkOUFPYVpiN2t2czlEcThNdS9YRDFyVStaOEJrNXpVd1BkUnRVTkpi?=
 =?utf-8?B?VXg1TEJPZGRNdi9CeWcxQW85ZmxXMW1keDN6N1drYmNjR0FSZWZieWIyRUNC?=
 =?utf-8?B?eC9ZUjdyMk40cmttdWlsTEhseU8wbXZ6Rml5VGZSa0REVTVSNmxBekdFZEpS?=
 =?utf-8?B?K1I2cndMSDdQWWtieEdrUGh6QllHUFUxbGdiUTc4ZWpnV0tER29leG5weUpk?=
 =?utf-8?B?QmVZSmRTQkNXZUJRK0ZjMXFQKzJnQVdVTWxVRzZVVkpzak1Gb2k2elhwN0VD?=
 =?utf-8?B?b0wycEtZbDJtTUFJVlJHMFpwZGpxYVdENFcyUDF3ZWU3WEQ1RUszVlNsTWlE?=
 =?utf-8?B?a2l2c1ZmMW83RmxHSXU4aVFTdlZTcUc2Tk9DYitybXl6cXY4b04rVjZDNUpj?=
 =?utf-8?B?MEhBWEdiaDhrMy82L3pWMkpJWDV5NXRNNU5TKzdJZkhXeGlaK0F3S2tISUNy?=
 =?utf-8?B?ZnQwYTh6VXNXTmxCek9ES0ZReG40UmQ1WTdwei9DWCtpZzVQR0ZzRGpmNGFz?=
 =?utf-8?B?NVhaeFhFdnRJSkxiOXIremZHbWRQTmVXK0lQeHdJTC9weEQ0dWRydTYwRXFY?=
 =?utf-8?B?TXJmSWthVmtIa0piSXZxaHB5d2p1bWptNHBGTktUQWp1TjFzL0RXK2tsVDdO?=
 =?utf-8?B?QytMNm5SK2ZTamN2dU8wcVNkdEJPTVdTMjQ4TWtRS3hjVTBWN0tDQklJajZz?=
 =?utf-8?B?N0N4Y3ByZ1M4TzNQYnh4YU1KLyt0VE1CMnI0WHRtQXpWM3BobUhxNk1WWWVD?=
 =?utf-8?B?N2JkMy9YUFlsN2pZVjFMMFR0UHFTeDhWRjhjWHg1RHdQTWZFOW55MDB4bDFZ?=
 =?utf-8?B?ajVNTTY1OWY4S3FLeDZCS2NlSHRuS0NqTStsNFdGQ09yNFF6S01KSVN6ZXFs?=
 =?utf-8?B?VlRQR0FYUlhJcm1ubUZ5OTl1eWhYWXU1V015S1YxajlUeFd0aVVGK05vNGkr?=
 =?utf-8?B?eXFUTm5nVURZejFTalRaVFBjVlM1c3RFSUZiRjNRMHB3K1duRWwzN3dwUU1Z?=
 =?utf-8?B?bmNSQ3ZaZmRhUm15QXBkbFk2ZTY5c1RmeEdWNklRK0dGLzAvajJnZFEzUTBi?=
 =?utf-8?B?Wnh3eCtQMHpzTHpZRkNQV001K2lRUnpmK1JiOWRVbmZFTWNnWWtROG5VczVr?=
 =?utf-8?B?cjVTd0N6ai9UMHArNkZXNHVZSWtuMnJmdnYxQWtveFBoRzU3RHNuZUwvZjRz?=
 =?utf-8?Q?LhmH0IsDS4ptOsuc=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64ddddc2-6411-467e-935c-08da29053f61
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 10:52:54.2062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fOBsa9OeBA4OgJxcTFS7YVCMpWkqJwA0cMEzKq8exIOmOA6h2JDrGdzGZQ6DF/vkuXGXYVR+/S1t3vXK2rlxwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4255

On Thu, Apr 28, 2022 at 12:39:19PM +0200, Jan Beulich wrote:
> On 28.04.2022 11:13, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/cpu/mcheck/mce_intel.c
> > +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
> > @@ -1008,8 +1008,24 @@ int vmce_intel_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
> >  
> >  int vmce_intel_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val)
> >  {
> > +    const struct cpuid_policy *cp = v->domain->arch.cpuid;
> >      unsigned int bank = msr - MSR_IA32_MC0_CTL2;
> >  
> > +    switch ( msr )
> > +    {
> > +    case MSR_P5_MC_ADDR:
> > +        /* Bank 0 is used for the 'bank 0 quirk' on older processors. */
> > +        *val = v->arch.vmce.bank[1].mci_addr;
> > +        return 1;
> > +
> > +    case MSR_P5_MC_TYPE:
> > +        *val = v->arch.vmce.bank[1].mci_status;
> > +        return 1;
> > +    }
> 
> Could I ask you to add a reference to vcpu_fill_mc_msrs() in the comment?

Sure.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 11:07:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 11:07:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316446.535366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk1zJ-0000oT-1N; Thu, 28 Apr 2022 11:07:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316446.535366; Thu, 28 Apr 2022 11:07:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk1zI-0000oM-SW; Thu, 28 Apr 2022 11:07:08 +0000
Received: by outflank-mailman (input) for mailman id 316446;
 Thu, 28 Apr 2022 11:07:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk1zH-0000oC-Lp; Thu, 28 Apr 2022 11:07:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk1zH-0004Xc-JK; Thu, 28 Apr 2022 11:07:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk1zH-0005ip-Cr; Thu, 28 Apr 2022 11:07:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk1zH-0006qD-CR; Thu, 28 Apr 2022 11:07:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YHO0XmuYrg2jkd+jSYTn9BJ3PXLI5EglcI5LHhGVApk=; b=KQUQCpitrC1YKKHFCUrjFT3Yr3
	WGgK2QYbyDxQ1x1KbGe9XpAenVq5DdqqccMqRZ4kgx7+DzgJ1/l1abdm4Nvf2JYQ8oKS97w+ji62X
	z1u/pKpzDKMoXmlD96P4ty+K5gWZh+IQlX6HaJn/FA1XQn2+hvJwTJT0sCfViYFCR9dI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169810-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169810: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 11:07:07 +0000

flight 169810 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169810/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  675 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   47 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 11:20:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 11:20:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316454.535376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk2Bi-0002Iw-4q; Thu, 28 Apr 2022 11:19:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316454.535376; Thu, 28 Apr 2022 11:19:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk2Bi-0002Ip-1N; Thu, 28 Apr 2022 11:19:58 +0000
Received: by outflank-mailman (input) for mailman id 316454;
 Thu, 28 Apr 2022 11:19:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nk2Bh-0002Ij-Ad
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 11:19:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nk2Be-0004lg-IS; Thu, 28 Apr 2022 11:19:54 +0000
Received: from [54.239.6.184] (helo=[192.168.2.126])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nk2Be-0005zu-B1; Thu, 28 Apr 2022 11:19:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Ir5WfQaotsNJRraYYm7+8sJwxZ8rQOOCK6X29GsDf3I=; b=6sUo4Ye+6KRDAGf3akO0OSkHfL
	h398fLGX6eI77F6IqydH0X+jqOHQeyq82cf2gNmfU35Ugu2H2IUU0A4nH3u0+NfinYthbydfv7WwD
	brf8F3dufN9WDL0qP3uY0yHUPYbt0PWKusIqM6m1stY4eaKlKwmX5E5+q/DIkqVScV5k=;
Message-ID: <ac0a0bf0-81a8-63c7-6a62-377672e24069@xen.org>
Date: Thu, 28 Apr 2022 12:19:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
To: Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien.grall.oss@gmail.com>
Cc: osstest service owner <osstest-admin@xenproject.org>,
 xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>,
 David Vrabel <dvrabel@amazon.co.uk>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <osstest-169781-mainreport@xen.org>
 <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
 <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop>
 <CAJ=z9a1bu=3sX0rvWy+T-ey4363DMUEJvzkSqkQkTnvOQtT0=A@mail.gmail.com>
 <alpine.DEB.2.22.394.2204271622520.915916@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204271622520.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 28/04/2022 01:47, Stefano Stabellini wrote:
> On Thu, 28 Apr 2022, Julien Grall wrote:
>> Hi Stefano,
>>
>> On Thu, 28 Apr 2022, 00:02 Stefano Stabellini, <sstabellini@kernel.org> wrote
>>        It seems to me that it is acceptable to allocate memory with interrupt
>>        disabled during __init. I cannot see any drawbacks with it. I think we
>>        should change the ASSERT to only trigger after __init: system_state ==
>>        SYS_STATE_active.
>>
>>        What do you think?
>>
>>
>> This would solve the immediate problem but not the long term one (i.e cpu hotplug).
>>
>> So I think it would be better to properly fix it right away.
> 
> Yeah, you are right about cpu hotplug. I think both statements are true:
> 
> - it is true that this is supposed to work with cpu hotplug and these
>    functions might be directly affected by cpu hotplug (by a CPU coming
>    online later on)
> 
> - it is also true that it might not make sense to ASSERT at __init time
>    if IRQs are disabled. There might be other places, not affected by cpu
>    hotplug, where we do memory allocation at __init time with IRQ
>    disabled. It might still be a good idea to add the system_state ==
>    SYS_STATE_active check in the ASSERT, not to solve this specific
>    problem but to avoid other issues.

AFAIU, it is not safe on x86 to do TLB flush with interrupts disabled 
*and* multiple CPUs running. So we can't generically relax the check.

Looking at the OSSTest results, both Arm32 and Arm64 without GICv3 ITS 
tests have passed. So it seems unnecessary to me to preemptively relax 
the check just for Arm.

> 
> 
> In regard to gicv3_lpi_allocate_pendtable, I haven't thought about the
> implications of cpu hotplug for LPIs and GICv3 before. Do you envision
> that in a CPU hotplug scenario gicv3_lpi_init_rdist would be called when
> the extra CPU comes online?

It is already called per-CPU. See gicv3_secondary_cpu_init() -> 
gicv3_cpu_init() -> gicv3_populate_rdist().

> 
> Today gicv3_lpi_init_rdist is called based on the number of
> rdist_regions without checking if the CPU is online or offline (I think ?)

The re-distributors are not banked and therefore accessible by everyone. 
However, in Xen case, each pCPU will only touch its own re-distributor 
(well aside TYPER to figure out the ID).

The loop in gicv3_populate_rdist() will walk throught all the
re-distributor to find which one corresponds to the current pCPU. Once 
we found it, we will call gicv3_lpi_init_rdist() to fully initialize the 
re-distributor.

I don't think we want to populate the memory for each re-distributor in 
advance.

Cheers,


-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 11:20:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 11:20:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316458.535387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk2CK-0003Zy-E3; Thu, 28 Apr 2022 11:20:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316458.535387; Thu, 28 Apr 2022 11:20:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk2CK-0003Zr-B1; Thu, 28 Apr 2022 11:20:36 +0000
Received: by outflank-mailman (input) for mailman id 316458;
 Thu, 28 Apr 2022 11:20:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nk2CJ-0003OV-9x
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 11:20:35 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 378df62e-c6e5-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 13:20:34 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 07:20:31 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BN6PR03MB2721.namprd03.prod.outlook.com (2603:10b6:404:5a::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Thu, 28 Apr
 2022 11:20:29 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 11:20:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 378df62e-c6e5-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651144834;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=MK0Pt5bMm3eDfoFrgFqkKaQgL8YWZjd+beQNr0UHrW0=;
  b=a1EGU4P29XVMfGGiuhHH0+YFog9jEvA09hyTajby2fKL9+kvbNc7mQU9
   GSfvjIRYpkxRduICvIfktAC6isX7dOQCsYs622U2NvaHsCLzlO2lV/Knh
   xlbEbg+a6DfD/2FQpTDjHujcwMqGU5HE7tYYjQGU4TaaQdCt4c3UI7OQk
   4=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 70149174
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:yHexe6ylVdIbACHRpQt6t+c2xyrEfRIJ4+MujC+fZmUNrF6WrkVRz
 WFLWD2EPayJZWLxKdp0YY++oUMAsJfVzdc3TgA9qSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024jhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplrYaoeS0MB/Xwg88DUkVSLw0uIPxL9+qSSZS/mZT7I0zuVVLJmqwrJmdmeIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeE+OTu48wMDQY36iiGd7EY
 MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgK2QE+QvK+cLb5UCLygtBj4nXC+bMUYG6e9lapGOBp
 WzJqjGR7hYycYb3JSC+2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiESzRtZeI
 Ew84Tc1oO4580nDZsb5dw21pjiDpBF0c9dRFfY+5SmVyrLI+QeJQGQJJgOtc/Qjvc4yADYsh
 lmAmoqwASQ16ePFD3WA6r2TsDW+fzAPKnMPbjMFSg1D5MT/pIY0jVTESdML/LOJs+AZ0ArYm
 1iixBXSTZ1J5SLX/81XJWz6vg8=
IronPort-HdrOrdr: A9a23:bMxjwKHu0IfN7S1QpLqFDpHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LK90c67MAvhHP9OkPAs1NKZMDUO11HYSL2KgbGD/9SCIVyCygci79
 YGT0EWMrSZYzlHZK7BkXOF+r0bsby6Gc6T9ITjJyAHd3AQV0gs1XYPNi+rVmlNACVWD5swE5
 SRouJBujqbYHwSKuC2HGMMUeTvr8DC0MuOW29OOzcXrC21yR+44r/zFBaVmj8YTjN02L8ntU
 zIiRbw6KmPu+yyjjXcy2jQxZJLn8aJ8Ko0OOW8zuwubhn8gAehY4psH5WEoTAOuemqrG0nld
 Hdyi1QTfhb2jf0RCWYsBHt0w7v3HIF8Hn502KVhnPlvIjQWC86I9Apv/MVTjLpr24b+P1s2q
 NC2GyU87BNCwnboSj779/UEzl3i0uPp2Y4m+J7tQ0UbWInUs4fkWUjxjIaLH9ZdxiKqbzPUd
 MeR/003cwmPW9zNBvizylSKN/FZAVBIv7JeDlAhiWv6UkooJlI9Tpl+CUhpAZ/yHtEcegj2w
 3lCNUcqFgcdL5jUUpCbN1xMPefOyjqfS/mFl60DBDOKJwnUki926Ifpo9FrN2XRA==
X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; 
   d="scan'208";a="70149174"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fcHDROX84ZtwP/aovoj/EspmNuUJlK0y72adpZDurQD8lmE64faCuA/S2ZatKCU2mmruREI5uJUzki0tOPGb0P9nqYVqGpaUD++5kxwb/cnWa5Wxtj9D67+hMK8/s7lrMKRgUMhxrtEIw/GgfDWrjZxMpRvMDOir0JqkyWDjyRXUMnTAszRICge50ECTun9Fy3toMyqGNWwNRoMNBNbXbswgUwOvBaK0uPpwlL99fygrS8VznpzyclQg3+YjEv5qr25rI63yPbltw80jAc9cIeu/CL/Z7T09zhbVPuO/+E91YDggKktvjARxX1U+yJpEDn9as2czU9BrK1lWszcIhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GryavTxYR6LKXF2Iv/E8mX3vooppy/oYJi74mU6x3YQ=;
 b=Z+uv0f0AfwQBcfBVOOcgn9W6QePgxHohCoBtuIvBYYaXMoZaWEgg+yTdmF/MeDh2sRBLwVrooejasNGLfFYZiPPRUm8Sdhof8eoG62Md4zDkvRrCfCUuhBsAzHjF/lDNWjMnSwzbc8Iri0KRGIx7pY5H1wetUpUnOkrgzwSvZ6olEdWqxQfmSogcbKCdyV6XhCVMoeCKok57C+6dbgmti7lXjsYYKWfivWSQNs+MGICYjLrhpHfBkAcTbDDCr1SUiSBo3hVhg/QvJlssM3Z1wyXhCwcGPaI94UAeQJu8ULLiM4lzRC5xR8fRmxtxi26SC/6ArXmUyuPMTBCgvOhrOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GryavTxYR6LKXF2Iv/E8mX3vooppy/oYJi74mU6x3YQ=;
 b=aY6X64QGPXsCy1RF03uGMQIEo5HgWa9lsuIKqsLpN6b4B4zqKOsgQuryUFX2cOvGusTrgThF9FKbFqIqsgWpK4EwXTei6tenmPQzf34J36sFhnw56/fQwl+MdHYBLjtgNbrfK9M6lbPCWId5YjsCFCUi2hGx/lq0OqkWbC0W5ec=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>,
	Steffen Einsle <einsle@phptrix.de>
Subject: [PATCH v3] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}
Date: Thu, 28 Apr 2022 13:20:23 +0200
Message-Id: <20220428112023.93195-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR1P264CA0031.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2f::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 55184def-b63f-4536-8ca3-08da2909199c
X-MS-TrafficTypeDiagnostic: BN6PR03MB2721:EE_
X-Microsoft-Antispam-PRVS:
	<BN6PR03MB2721E0BC99CD9D9033D32C0A8FFD9@BN6PR03MB2721.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dHFXawJGjcMfGMv4TbCe1AWP8Khc+MPV4aAK81sjY81CAjOyIwmxDca7eCsbHyfoklX5Ke1GdLv3TEq+OaEIQPgCGG6JPFKwjkNmFajoIayehxe7wDYbWEF9xthMQB7TC8l6j4pb2KNz0z8ASHU44RTLk+7wxALbue9t8LzyycwMuha8IyQUDa4G642TNk3B4WW2uX5ke7uaQzZ/VoskBbM08ECPeO7mDdDZ8B25flX8WyXRHt6HiFlkhVkP5nx68JROuuAdJU1mYCDJrvpA4iaFdRlx7V4HWVnjw4jSFuebVCbLdjPTODgyeTrJUEpuNEssUGyKb+kVx/4xtwVH4L30ku0RrfrYQ0nP3UtnvnxWa1p+hgbP0k346TBI6cXkUMxmL54CS3hPRnftt2caqYynQSAC3FDGkMB71WC8Xq0/KJg14zFQVkYFkweOGb3C638qSINYnLEnNx7KAZP5mEWGz/I7ThhhVn/qq0f514s1Wrzev4/CwbrcAYs2FhjNJKKCnwpJ4JkkdBwZFj0HKJ9MN5x+4P1itH4caotmVWVhYDGH17H5h/BGqPpaYVLzNP7d/4PwXIbGoVHjqixFZRt78K+OZKfgTXZsP+vd44EuZknI3+QjE0UAkwdFhKmxY3svqsX80uARhZ65FlhPYw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(316002)(54906003)(6666004)(4326008)(8936002)(82960400001)(38100700002)(66946007)(508600001)(5660300002)(86362001)(66476007)(6916009)(2906002)(66556008)(6486002)(6512007)(26005)(186003)(1076003)(36756003)(83380400001)(2616005)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aG1DOURTeiszUCtuZk52cm5FWlJWOTB5U2xDTGp2S1NFUWRoTGVDN1d6ckZ3?=
 =?utf-8?B?RnkwVzdJeUdMdmJkL1RKVlBTdVRVSzVPeEdqSmNkZ3B0Wmt5UlkxSUIyNjBr?=
 =?utf-8?B?d0Exb2tpajhjNmZ0M05weGRGck9ZbUZ3ZWFDWklsL2lqdUZlcGFyZllDajJT?=
 =?utf-8?B?STBwVk5XWkpoWDBKcmRNQkFrNXVtZ2JJcW1ORExURmdaM1Azak9OSkxob0VT?=
 =?utf-8?B?Nk9EL3JqWER0Wjdza3VyejBFOEFPd1U1UENreno4c2E5V2ExRlRvenZ2ajYr?=
 =?utf-8?B?c2JUMkQ3aEhtZGh4YUdCenhIeVUvRGJUQ2lhSURmN2VaR29RcjB5MHBaMHRD?=
 =?utf-8?B?UHJqM1hHdW1PSWhiSUVIYmJFRWVlQzQ0NnozZ2dwVStGV2c0Q0drcVh1QmpS?=
 =?utf-8?B?T1hGZ1VqdXZSOWpTeWh4azFtNStMVWpkc1hyWmNNMUs4ZHRobzk0Y2o4WXd0?=
 =?utf-8?B?UlV4c0UvYXB4SnhvWTNHTXRLSkZkK25oT3VxMW9RdlFxRklmRzdUQStmMi92?=
 =?utf-8?B?ays3bVpXSDNTVnVrQlZ2TDBzb0dMTUxqRXRVTk1yYlNEblM3a1pVMGErbkE1?=
 =?utf-8?B?RWh4Wmw5SHI2WGZ6bVlUbGU4Q1NNU01NU0RvK0tTejJncXJBbkVocXR1cHJ0?=
 =?utf-8?B?aFpmeE52ZEV1d2N1N3FYZ3FIVFQ5QW5mcWM5dTRyQVhnNXAvclRoN3MxYUVj?=
 =?utf-8?B?NzFFdTJHY29YcW5BSUo5L0srNWNkdFE0dHFmbVNuR3NaN2hRc0xaTlUzdzRv?=
 =?utf-8?B?RE9wNUlOVGJ4bDJjaUU0ejF1c3ZzbW1yK2tKWDJQREU2dUozVXMvZnQwZGhw?=
 =?utf-8?B?dFF0S2JZMEpqU2NvbytFYVI3eGZFNnFnSk4rL3ZzZUtFUjB4bFNOL05jVzJQ?=
 =?utf-8?B?ZDgyUTVQVTZ5ZytKZ05aLzVJOTlHM3MzZ2pYbCt2aDN2alBqaG5hc0w1RkxH?=
 =?utf-8?B?WEVsVHlyeWRETU91Q05GbXFORXVSMUd4cG4rLy9WUjFjanBsWUVTK3hueWRU?=
 =?utf-8?B?TFZxaU9pTUgzRWFpMjA4dkswQXVMZ3lFZ2tsQjNRVXloS2dUUmRvV3VuMkdY?=
 =?utf-8?B?a0doc0poQkVXSWdJeENUNzNabFNKY2QvdzJ1aGFoVW81ZW9rSWJLRUoxSVdB?=
 =?utf-8?B?WktpbDRXS3ZGMGNxbUdaT1gramI3b3N0WjZaSmdDQ0dOajFwY3k1ck0vZjhm?=
 =?utf-8?B?U2RmbWp6aDJBanR5SGU1TFllNXBzKzc0UjArbSt0MGNJd3ZQcTFnNWMzNGUy?=
 =?utf-8?B?ckJjWWhzZmVpYkNzZ3NkenRkYWVhN01pbTJOS1FhdzFSRDlzT1B5MHI5WVBw?=
 =?utf-8?B?V3FFSWFUWWlobjhDWTFhdTBOUHBiMEkweC9CcWlvUWxpS1dwVXJsS3pNYzNh?=
 =?utf-8?B?SmRNT3YyRWY3eDBuOVU4TUNQWENrVm9XSXVIcXZQK0R4ZTZpZCtsNDFweC9q?=
 =?utf-8?B?dEhFWTcxR0NHbTdrdkxQK25YdEQ2bzVtNmt1cm1MaklYdTI4ME5DN3ZmRzUz?=
 =?utf-8?B?NVBtSC9ZUkM2NzFNQnZjd2k1YitEc0ZpZ3hDZ0c0aXNHWHVZaW16SUhjQm1w?=
 =?utf-8?B?SSsxWVBUdFJKaTZBMkQ5am9WQVdlM2RiTGFHeENnWUJZUzdQRVpDRVZOQ0U3?=
 =?utf-8?B?NzhBVVhwVmtVOENyUDVOTFdjWlBtRGhuM0Z5ZnluUFJ4WUtKSnlqV2NyU2dX?=
 =?utf-8?B?ZXUvMFJUZWV1b0l1RCtPQm02c3Z3ZVNZQVFQSWFaTS9kWXhCTlJGbU1PdGx4?=
 =?utf-8?B?UUpETmpSMm1YTHpIYWo1L2VvOEFxK0xJVkxweW1nejFvVlRiUDNrRUJwUmJE?=
 =?utf-8?B?M3h4R1FjWi82R2FNTWJUT1NXczBxeFNoSHhjUkk0M2grd2djejcyL3BYSG5L?=
 =?utf-8?B?THV6NHhYR2JyY3hLRFByUFIyWlZZV3JnVHdPdGJjQ2U3Qm55dFpQR1NRd1Bq?=
 =?utf-8?B?aUlxR1VxNjczU0RhclZzRmlqS3ZyTEp5cU41UDlRZ2NUVWF5ejVGTHJDTUdR?=
 =?utf-8?B?MzZQS3AzWExzc0graVo0Qmt1aVBVck4zY0tESnFjNnZqOEMySTN4M3FiM2NR?=
 =?utf-8?B?bHFLTjVZckY2SzNJTXp5ak05ZTYwdUVKTVpVcXFYd21ZYnZvM1RnYlhyMTFV?=
 =?utf-8?B?ZGlPTjVXV1BGWStaOVZENFVPNmVyQW02L3dSdjlKdDVzbmVzakJnY3NPU2lY?=
 =?utf-8?B?bTJDQmRjdkpIMERPMlZ3MmZuRjMrN0RkZ2MzMUY2K2N3T2xsWTZISFVBRGM5?=
 =?utf-8?B?ZFpjRHRCRWpGdHFVdWNyU09lS3Z0NExPTXF4SFpycVU4VXJhZGFQUnQzcGc1?=
 =?utf-8?B?cEZ1M1BHYjZRL20wRytQMXNTTFpmZFYxaVIxMm8ySENwV2NsN2FQNmowcWJj?=
 =?utf-8?Q?k3lih2GE4GK46jjs=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55184def-b63f-4536-8ca3-08da2909199c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 11:20:28.9199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ME8JBhfxxpKXzxTctrS7Suu5KE539rTHgw+v+fcajtROajLOGaVfGKRvZbp2A2IaQUapObup+LTPHww43Me9wA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2721

Windows Server 2019 Essentials will unconditionally attempt to read
P5_MC_ADDR MSR at boot and throw a BSOD if injected a #GP.

Fix this by mapping MSR_P5_MC_{ADDR,TYPE} to
MSR_IA32_MCi_{ADDR,STATUS}, as reported also done by hardware in Intel
SDM "Mapping of the Pentium Processor Machine-Check Errors to the
Machine-Check Architecture" section.

Reported-by: Steffen Einsle <einsle@phptrix.de>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v2:
 - Use fallthrough pseudo keyword.
 - Expand comment about bank 0 quirk.
 - Change condition for early exit from vmce_intel_rdmsr.

Changes since v1:
 - Implement in vmce_rdmsr.
---
 xen/arch/x86/cpu/mcheck/mce.h        |  6 ++++++
 xen/arch/x86/cpu/mcheck/mce_intel.c  | 19 +++++++++++++++++++
 xen/arch/x86/cpu/mcheck/vmce.c       |  2 ++
 xen/arch/x86/include/asm/msr-index.h |  3 +++
 xen/arch/x86/msr.c                   |  2 ++
 5 files changed, 32 insertions(+)

diff --git a/xen/arch/x86/cpu/mcheck/mce.h b/xen/arch/x86/cpu/mcheck/mce.h
index 535d0abf8f..bea08bdc74 100644
--- a/xen/arch/x86/cpu/mcheck/mce.h
+++ b/xen/arch/x86/cpu/mcheck/mce.h
@@ -169,6 +169,12 @@ static inline int mce_vendor_bank_msr(const struct vcpu *v, uint32_t msr)
         if (msr >= MSR_IA32_MC0_CTL2 &&
             msr < MSR_IA32_MCx_CTL2(v->arch.vmce.mcg_cap & MCG_CAP_COUNT) )
             return 1;
+        fallthrough;
+
+    case X86_VENDOR_CENTAUR:
+    case X86_VENDOR_SHANGHAI:
+        if (msr == MSR_P5_MC_ADDR || msr == MSR_P5_MC_TYPE)
+            return 1;
         break;
 
     case X86_VENDOR_AMD:
diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c
index 50198e0c29..28a605a5cb 100644
--- a/xen/arch/x86/cpu/mcheck/mce_intel.c
+++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
@@ -1008,8 +1008,27 @@ int vmce_intel_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
 
 int vmce_intel_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val)
 {
+    const struct cpuid_policy *cp = v->domain->arch.cpuid;
     unsigned int bank = msr - MSR_IA32_MC0_CTL2;
 
+    switch ( msr )
+    {
+    case MSR_P5_MC_ADDR:
+        /*
+         * Bank 0 is used for the 'bank 0 quirk' on older processors.
+         * See vcpu_fill_mc_msrs() for reference.
+         */
+        *val = v->arch.vmce.bank[1].mci_addr;
+        return 1;
+
+    case MSR_P5_MC_TYPE:
+        *val = v->arch.vmce.bank[1].mci_status;
+        return 1;
+    }
+
+    if ( !(cp->x86_vendor & X86_VENDOR_INTEL) )
+        return 0;
+
     if ( bank < GUEST_MC_BANK_NUM )
     {
         *val = v->arch.vmce.bank[bank].mci_ctl2;
diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c
index 458120f9ad..af30811afd 100644
--- a/xen/arch/x86/cpu/mcheck/vmce.c
+++ b/xen/arch/x86/cpu/mcheck/vmce.c
@@ -150,6 +150,8 @@ static int bank_mce_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val)
     default:
         switch ( boot_cpu_data.x86_vendor )
         {
+        case X86_VENDOR_CENTAUR:
+        case X86_VENDOR_SHANGHAI:
         case X86_VENDOR_INTEL:
             ret = vmce_intel_rdmsr(v, msr, val);
             break;
diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h
index 3e038db618..31964b88af 100644
--- a/xen/arch/x86/include/asm/msr-index.h
+++ b/xen/arch/x86/include/asm/msr-index.h
@@ -15,6 +15,9 @@
  * abbreviated name.  Exceptions will be considered on a case-by-case basis.
  */
 
+#define MSR_P5_MC_ADDR                      0
+#define MSR_P5_MC_TYPE                      0x00000001
+
 #define MSR_APIC_BASE                       0x0000001b
 #define  APIC_BASE_BSP                      (_AC(1, ULL) <<  8)
 #define  APIC_BASE_EXTD                     (_AC(1, ULL) << 10)
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index a1e268eea9..d87317e989 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -283,6 +283,8 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
         *val = msrs->misc_features_enables.raw;
         break;
 
+    case MSR_P5_MC_ADDR:
+    case MSR_P5_MC_TYPE:
     case MSR_IA32_MCG_CAP     ... MSR_IA32_MCG_CTL:      /* 0x179 -> 0x17b */
     case MSR_IA32_MCx_CTL2(0) ... MSR_IA32_MCx_CTL2(31): /* 0x280 -> 0x29f */
     case MSR_IA32_MCx_CTL(0)  ... MSR_IA32_MCx_MISC(31): /* 0x400 -> 0x47f */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 11:39:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 11:39:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316468.535399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk2Ub-0005IW-65; Thu, 28 Apr 2022 11:39:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316468.535399; Thu, 28 Apr 2022 11:39:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk2Ub-0005IP-2H; Thu, 28 Apr 2022 11:39:29 +0000
Received: by outflank-mailman (input) for mailman id 316468;
 Thu, 28 Apr 2022 11:39:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nk2UZ-0005IJ-Dw
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 11:39:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id db4340e8-c6e7-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 13:39:26 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-c_HwlbJ1NoSLqIeaJzva5Q-1; Thu, 28 Apr 2022 13:39:24 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU2PR04MB8968.eurprd04.prod.outlook.com (2603:10a6:10:2e3::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Thu, 28 Apr
 2022 11:39:23 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 11:39:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db4340e8-c6e7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651145965;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JDiPNos+68/9J4493kepJtR+PFwigh4PUSUR13yHyVI=;
	b=FeRGHM+IdGN8fegHx5bdQRMOaTH/07Iaj9pAe/kQ6Kn3S6ulNqRYOcAsVG7t/B3CuO1qum
	n0VkGE3t/HeJzne38Ij3ljc4XIp2iPhp6H5VPXQNH2gIKj1XvBYszdxoAr07W2Uc2i/se3
	3Q7F+WI7fGJ+bqLgfsNFS/m0xNUBtx4=
X-MC-Unique: c_HwlbJ1NoSLqIeaJzva5Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QokDpTDAwlrAIyUOIyNszEioRRRW8NS8CKo2Bka8ljK/eKvs1mSdwbP6Cb5O5WID8Vq/iP75kCQTYDL13Ma17Mq2yQroAujVBny/SbN586HTWx4rZAKXGbFnXtucqBvSZhHo9wnnKRiq1YnngdFyqEHhXtcZjXiy1K1G0hr86HdF0UIdmJuzCXm7OX0PwM3lqIwZydXNIyJYpPVLXcUu7Q1LsgsJ+pNIECshcTf7NJedWsi1yTwgZQO2s+2QKKAkxDH0ykYLzvjMRnlguocY6Ng9dapNXjrCv31plBWEG6WoC5ZdR3QgEmIyPnMrQr2xRmo1SHLu++9REgL8zuwkmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ALl+eZdq6+PE9Lary6hVHXdG015SneK6tZ0GF3LsgOk=;
 b=GigG5yzrF6RYJg1nX0rd1RYOsa3uDzy00ttMxPumVKQchNzxcHktH2buJfMSAJzK/q/0P3S4g1tcInPJDllxdcempLp6Ft0ohvT8J+QyHQGSWwRI0iZUi+RyuCDDloUt0Rk+SLanUG6dNecBpOUYt0hTqS2CKRntD/Rxm7JOa0Mk5X/qRkUkcqDgfsAEnI/yAyFzWNHyznfCCGyrqRbvBVazAP2lie70OMyP7OPQhahMhH3YDRYBKFp3BlwxxmbKaSGXLfPpFdqg+N8W+v8+ocY0G87XwXWRmKOrW23Tf84UXO1ePkPyirnmllmgb6SZC6Otlf4BMmCn85mMa4rGGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3aef3bfd-f873-ef44-9503-46ed89eb587f@suse.com>
Date: Thu, 28 Apr 2022 13:39:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Steffen Einsle <einsle@phptrix.de>, xen-devel@lists.xenproject.org
References: <20220428112023.93195-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220428112023.93195-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR0301CA0012.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c0fac28a-ec03-439e-1909-08da290bbde4
X-MS-TrafficTypeDiagnostic: DU2PR04MB8968:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8968889A974D8225380158A4B3FD9@DU2PR04MB8968.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	od0v6P/qhdyAjcyM5zuegylecafaAJXN+vZPF5y8kWUUbvr/NS+eIypN5TRScp3qID2cIxHAWarDjINgnL25u3YfPa94puY2LVcq56PUGcCTjmRTyU7415hiyrQG0v+89kLWhtHUqcAoz2CPoVUCPkBD/4V8WGC7MfyT9536/L5/SChUGgYFnpu4vec5CulACofoF1aVoaK31y/f/3qnB/5OfNnjIDX8FEAEKM/CRUgYF4HKt5K0hDKmw4nvNTDHKQO3I5Rc+NlTQPwV0SkJXM567QigIEeu/nUu0B9LnkUg447wfJ2f8CjIzBinldrtUiI/78I9WCHbhN4Y1IHVf/s95e3Aks29W9r4TBxQUjQ0fNpK2Rr+3++QpqFi4IvLZ2eB2AXU1sKjxiZ5i6m9xQpKxgb9mFJQMvbLuCxgU5fVns/yzKEmeWs9Wy2OMUBYbv6LY8wvZ6xKoiCQ2Igj7FjfxSDafllgbgXeybZim/ci4YCdy5nSMqXKv8gTD8s/Sh84caZtp2OWY6+Ru/huO2E61HB15Yq4G0/PLXk/n3TcBT2eVIovPw6LaWOI+DC4dWXrEBOk4wVOX6AudVcCD4CX3+BJ0ACzYCYV0Zs0lEAEGi0+/Q+KHqISRFFKwh6OiEh+cGJFWrmSUm3IA7WPnAFzfstoKsMwoHqD7bfgJaz6bfdOAIqO3j1Vc2wZs81iYHnKSRS9ZfRwXx+aT+z0bQzfz0IS5NwLlSCHK+AuyUs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(36756003)(186003)(6512007)(8676002)(66476007)(66556008)(66946007)(6506007)(2906002)(5660300002)(2616005)(53546011)(31686004)(508600001)(54906003)(6916009)(6486002)(31696002)(4744005)(86362001)(316002)(38100700002)(4326008)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YiQF9/pC/6OsXNuTrFd8E7WIwAnHGTxrDP0FCGMBDKVucUjwrtHkB7y0iRAR?=
 =?us-ascii?Q?dxEXOidAwOphBKp9KuHm0GQu69Wxx6aFmoP7PKUzbr0C770O84gp+e5dA94U?=
 =?us-ascii?Q?AGOlxVe9cfvXZBABGWnjDjzix2v7I8R589joHt3laY44NYfTgD6utT8E0UlY?=
 =?us-ascii?Q?ZKAfsGtU2rssanNc+8lIKdk6N+Ydg5sYx+y8PpB0AzjNz70pcIKFkMI+kfEV?=
 =?us-ascii?Q?qM3cm2K/c/m8ul+1+y/TMPbxjQQ3NOjnEGMIFt9nnC6kyq9N2d1WnbyKnPN3?=
 =?us-ascii?Q?qnRGucFxUweI0z5wsELxMEcOdjqYjVVprIuQE/MJsOflIeS3j+vqinCryQf+?=
 =?us-ascii?Q?rIVynaIzVVjWdlp7OvqA9FyqQF850vLlzndBgMt5gTwSr3Pj7e4NqVZ6bexJ?=
 =?us-ascii?Q?D7kn71tzweLWhehfpXRs+lBub0KwElynCaSWNd0yl3qpLHi6+au7L7q9frqS?=
 =?us-ascii?Q?ZojrTr484dOthZ8xAv6saby2St8MB5+o603cLerAXj5sspeuM/LHIZSbXNBB?=
 =?us-ascii?Q?Zp5lE+YPJVoBOJPbB+IcVdbUydA59yxPtOc8YnmiUepXrA80gr1xT9JTyB5R?=
 =?us-ascii?Q?MzLTG4qD1WVuCbMwgi3hmLHQV1/ZpSKHkBigvJGpwKiiWLi9b5x1417U073P?=
 =?us-ascii?Q?j3M49jLO/VT7B6uQgHrQCQiLRJBZ9KjTLtQzqo9Y4gk/FgY+mBYNd+5M81Q7?=
 =?us-ascii?Q?BBFx813SBKrgmvEcEqMj2mKzySsyh4aCtkmM7SZHgj6lIGSqqX6fp6nDKxNd?=
 =?us-ascii?Q?cHOfsNmV0AZx6jKWW12T9q5qVWsAeh4/b6M0B51mGyAjQehjge2eZzE6iHli?=
 =?us-ascii?Q?QIDKZXO/2oJH7nislb7I1HFhuqrakadjVijeD0IbStPCrEWJR7PyskAw3Ec/?=
 =?us-ascii?Q?zIAi8pP4aM3RwvUuDHCAQZG0r34MVtIh5sLKbKAxutTg0N5ENfcYSzG+iTb9?=
 =?us-ascii?Q?uHi/p7vnu2nxemI0U/LLLB5O9E3iV1ECH5bcJpB3jnpPfRA7BsoHMZCzpf9X?=
 =?us-ascii?Q?BYysYI2cRWlUmCpF9+qa8Q+8nqCR02Z86ZRD+/IZ7B8M8Zv7WA4h18liE3Gi?=
 =?us-ascii?Q?OAxIW5cM5JG+Me/s+n03OMkxeorkMi3cYe+utAAJLjTtEWwmcqwSuJXk8w/R?=
 =?us-ascii?Q?0H0Vswj1dWU+wmmGzqGaQ8CAcCb0rS3xc4SYULBJoW4J/0ZFnUSBKNvNwKg+?=
 =?us-ascii?Q?KQ4hGyAt+gI9M+dLqBuTs8q+iplchoSKKm17JsVLdRq7B2rFd0+CqzFwRXrF?=
 =?us-ascii?Q?iBJg9vYJmIzzgq4I8gHVMnaLgdazXiJLVI7I0+ciUmo6/FahsczR4Z/pCWBc?=
 =?us-ascii?Q?ZvGSDEEDWUJCgAoMzH8NdR/pZo/ljWXi/F7UNdfjp1+hl9rhSUZpqgscpwkL?=
 =?us-ascii?Q?2pDxq/33xxs81+TEL5RUGCjGZWSgKcJZyPKFbwZPHHNVCQu+ZSKHK9HzZg1A?=
 =?us-ascii?Q?HonfmJEuPfMoqIWS0iM3Zc9ZFE08c7YFJVtjeNMSEFqrDgFv/xurfiMYeNOy?=
 =?us-ascii?Q?A4n8Mq3itCRwXPxKDkZrYfBM5GG6lsCh7q7vXFZ+S7wwi/kcpwDjClVMVIWL?=
 =?us-ascii?Q?XmrtNQX6u/h4q+xL8+P5RUiMnuNN5q55pclirVhDur6uGmcdiUXKnZUD4geb?=
 =?us-ascii?Q?I3TyH9dkh2h2K0Yix40YApBlQnL1RJpv1N4XWXtKac3h5HVR+u05JJLzvhUH?=
 =?us-ascii?Q?67giWW5412srwecq+7L+uo3QpWjSMikSXHwmwqaCo4IMAWaWq4ziTgs6Fakx?=
 =?us-ascii?Q?jLOIiekJBA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0fac28a-ec03-439e-1909-08da290bbde4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 11:39:23.5130
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T3M6SXc90T+q/xNYv0HKMIlt9NlflNj+AgGlP64SW/E2Ioo479LPD0dAgUBZF5h6r1FlnLwCuVHOCJGRFI7o+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8968

On 28.04.2022 13:20, Roger Pau Monne wrote:
> Windows Server 2019 Essentials will unconditionally attempt to read
> P5_MC_ADDR MSR at boot and throw a BSOD if injected a #GP.
>=20
> Fix this by mapping MSR_P5_MC_{ADDR,TYPE} to
> MSR_IA32_MCi_{ADDR,STATUS}, as reported also done by hardware in Intel
> SDM "Mapping of the Pentium Processor Machine-Check Errors to the
> Machine-Check Architecture" section.
>=20
> Reported-by: Steffen Einsle <einsle@phptrix.de>
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 11:59:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 11:59:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316476.535410 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk2nM-0007h1-Qh; Thu, 28 Apr 2022 11:58:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316476.535410; Thu, 28 Apr 2022 11:58:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk2nM-0007gu-Nm; Thu, 28 Apr 2022 11:58:52 +0000
Received: by outflank-mailman (input) for mailman id 316476;
 Thu, 28 Apr 2022 11:58:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk2nM-0007gk-54; Thu, 28 Apr 2022 11:58:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk2nM-0005R6-0T; Thu, 28 Apr 2022 11:58:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk2nL-0000RV-9v; Thu, 28 Apr 2022 11:58:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk2nL-00042e-9T; Thu, 28 Apr 2022 11:58:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4XB0HdrKiVMAfiK6w2X/uOjF1gMeA3hE2gANEdJz2P4=; b=X1Ol7a1lQGRLRw3tdcMJqAzWgN
	3xxDvkmlq8epz3ktvIpHoQ2QMuQ3pKJfoCMhtbnDaTNcjR95P894V3a3mQhsl5z2+x+xBxZobUxWO
	JynfIQvFWXI47OFkv6UuN+xQlVaDqHGA45j61JFVVg4JP7vnA4ekSz9crwe2rGV1b4+c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169811-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169811: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 11:58:51 +0000

flight 169811 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169811/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  676 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   48 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 12:45:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 12:45:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316502.535425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk3Wd-0004ah-Nv; Thu, 28 Apr 2022 12:45:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316502.535425; Thu, 28 Apr 2022 12:45:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk3Wd-0004aa-JN; Thu, 28 Apr 2022 12:45:39 +0000
Received: by outflank-mailman (input) for mailman id 316502;
 Thu, 28 Apr 2022 12:45:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk3Wc-0004aQ-47; Thu, 28 Apr 2022 12:45:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk3Wc-0006EH-10; Thu, 28 Apr 2022 12:45:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk3Wb-0002EZ-FQ; Thu, 28 Apr 2022 12:45:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk3Wb-0004hn-Ev; Thu, 28 Apr 2022 12:45:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8VDUWomdlveeCKW5GNfN33iiZaVYDvp2Ke0G1sm/9TQ=; b=B02DxKcPxC8JjdqV75vW2H3lNd
	OZ7Ck0V8lmHxWBnIWEKjkb++OY0AgF7Y2yO0wWKeowER914z42wOAStsg56gvRoTLESuNa8Dj39AU
	ebIuB9Shcx6RGR+c3YiXdu1NpPbFRz53y4YEIm5dHWd7s1ZODiZlJIlsJYlkbg3iKAso=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169812-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169812: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 12:45:37 +0000

flight 169812 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169812/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  677 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   49 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 12:59:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 12:59:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316510.535435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk3k1-00067k-Tp; Thu, 28 Apr 2022 12:59:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316510.535435; Thu, 28 Apr 2022 12:59:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk3k1-00067d-Qw; Thu, 28 Apr 2022 12:59:29 +0000
Received: by outflank-mailman (input) for mailman id 316510;
 Thu, 28 Apr 2022 12:59:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nk3k0-00067W-BY
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 12:59:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nk3k0-0006SX-3v; Thu, 28 Apr 2022 12:59:28 +0000
Received: from [54.239.6.184] (helo=[192.168.2.126])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nk3jz-0003fX-Tl; Thu, 28 Apr 2022 12:59:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=vuFgT9Y2joI5bZRvrXmv2sl62aqJNMlLAjfd3k+HU50=; b=JXV5RN51ryVVhaeKIkHAVUrNIb
	Mk0hAuCXDdi7TffAaUycP07IuNLozwGt2ibzu0sv9RvZHeUAJzVXTS8uNQ4zFFh6rWgQbGh9Ezwjc
	JgdKjSkqIf4CxHbq3qrb+GPmXgDGurp71RYI4ZpMkzKvN4wYywFxH6ZehrEInpaYYY8o=;
Message-ID: <fd2492da-0980-2dd4-f8d8-e2b86e9444ef@xen.org>
Date: Thu, 28 Apr 2022 13:59:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com>
 <a2bba079-0a26-8648-6f39-93148dbd5107@xen.org>
 <73BA5CB5-8B01-41BF-B967-15886554C230@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <73BA5CB5-8B01-41BF-B967-15886554C230@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 28/04/2022 11:00, Rahul Singh wrote:
> Hi Julien,
> 
>> On 27 Apr 2022, at 6:59 pm, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Rahul,
>>
>> On 27/04/2022 17:14, Rahul Singh wrote:
>>> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are
>>
>> Looking at the spec (ARM IHI 0069H), I can't find a command error named MAPC_LPI_OFF. Is it something specific to your HW?
> 
> I found the issue on HW that implements GIC-600 and GIC-600 TRM specify the MAPC_LPI_OFF its command error.
> 
> https://developer.arm.com/documentation/100336/0106/introduction/about-the-gic-600
> {Table 3-15 ITS command and translation errors, records 13+ page 3-89}

Please provide a pointer to the spec in the commit message. This would 
help the reviewer to know where MAPC_LPI_OFF come from.

> 
>>
>>> not enabled before mapping the collection table using MAPC command.
>>> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection
>>> table.
>>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>>> ---
>>> xen/arch/arm/gic-v3.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>>> index 3c472ed768..8fb0014b16 100644
>>> --- a/xen/arch/arm/gic-v3.c
>>> +++ b/xen/arch/arm/gic-v3.c
>>> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void)
>>> /* If the host has any ITSes, enable LPIs now. */
>>> if ( gicv3_its_host_has_its() )
>>> {
>>> + if ( !gicv3_enable_lpis() )
>>> + return -EBUSY;
>>> ret = gicv3_its_setup_collection(smp_processor_id());
>>> if ( ret )
>>> return ret;
>>> - if ( !gicv3_enable_lpis() )
>>> - return -EBUSY;
>>
>> AFAICT, Linux is using the same ordering as your are proposing. It seems to have been introduced from the start, so it is not clear why we chose this approach.
> 
> Yes I also confirmed that before sending the patch for review. I think this is okay if we enable the enable LPIs before mapping the collection table.

In general, I expect change touching the GICv3 code based on the 
specification rather than "we think this is okay". This reduce the risk 
to make modification that could break other platforms (we can't possibly 
test all of them).

Reading through the spec, the definition of GICR.EnableLPIs contains the 
following:

"
0b0 LPI support is disabled. Any doorbell interrupt generated as a 
result of a write to a virtual LPI register must be discarded, and any 
ITS translation requests or commands involving LPIs in this 
Redistributor are ignored.

0b1 LPI support is enabled.
"

So your change is correct. But the commit message needs to be updated 
with more details on which GIC HW the issue was seen and why your 
proposal is correct (i.e. quoting the spec).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 13:27:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 13:27:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316536.535456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4BN-0001Ez-9w; Thu, 28 Apr 2022 13:27:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316536.535456; Thu, 28 Apr 2022 13:27:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4BN-0001Es-5C; Thu, 28 Apr 2022 13:27:45 +0000
Received: by outflank-mailman (input) for mailman id 316536;
 Thu, 28 Apr 2022 13:27:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2LgV=VG=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1nk4BL-0001Em-Px
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 13:27:43 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fb51b3da-c6f6-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 15:27:42 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id C602768C7B; Thu, 28 Apr 2022 15:27:38 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb51b3da-c6f6-11ec-8fc3-03012f2f19d4
Date: Thu, 28 Apr 2022 15:27:38 +0200
From: Christoph Hellwig <hch@lst.de>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, jgross@suse.com,
	xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	iommu@lists.linux-foundation.org, Rahul Singh <Rahul.Singh@arm.com>
Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
Message-ID: <20220428132737.GA13999@lst.de>
References: <20220423171422.1831676-1-hch@lst.de> <alpine.DEB.2.22.394.2204261605420.915916@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2204261605420.915916@ubuntu-linux-20-04-desktop>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote:
> > Reported-by: Rahul Singh <Rahul.Singh@arm.com>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Do you want to take this through the Xen tree or should I pick it up?
Either way I'd love to see some testing on x86 as well.


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 13:29:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 13:29:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316546.535466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4D4-0001on-Kd; Thu, 28 Apr 2022 13:29:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316546.535466; Thu, 28 Apr 2022 13:29:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4D4-0001og-Hr; Thu, 28 Apr 2022 13:29:30 +0000
Received: by outflank-mailman (input) for mailman id 316546;
 Thu, 28 Apr 2022 13:29:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk4D3-0001oW-0p; Thu, 28 Apr 2022 13:29:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk4D2-00072E-VM; Thu, 28 Apr 2022 13:29:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk4D2-0003Yr-Oe; Thu, 28 Apr 2022 13:29:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk4D2-0004NH-OD; Thu, 28 Apr 2022 13:29:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hO+oaUfZ3v0S9w6jU8ouO+haVvi62ndgzzVj7JPFuD8=; b=En4ZfQYMDGgfxvgywD+IR2UyHB
	X3zcjnG3jiUbMgvM/4mosjOvmGi3NyweiQsW4/zZIMzusi7HFlwY/faxruMxLzoRh0VZMlAfzm9If
	2DSrnHI1GAWprQ1sysshjcIv797e9e+aI2v+DxQWbC93RD06YOlUYXJYIYQObrKtW6bs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169814-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169814: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 13:29:28 +0000

flight 169814 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169814/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  678 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   50 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 13:52:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 13:52:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316554.535478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4ZZ-000519-I1; Thu, 28 Apr 2022 13:52:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316554.535478; Thu, 28 Apr 2022 13:52:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4ZZ-000512-El; Thu, 28 Apr 2022 13:52:45 +0000
Received: by outflank-mailman (input) for mailman id 316554;
 Thu, 28 Apr 2022 13:52:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50wr=VG=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nk4ZY-00050w-Bs
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 13:52:44 +0000
Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com
 [2607:f8b0:4864:20::f34])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7926d5a9-c6fa-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 15:52:42 +0200 (CEST)
Received: by mail-qv1-xf34.google.com with SMTP id ke5so3234598qvb.5
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 06:52:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7926d5a9-c6fa-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=oybHSEJN5rbrfr7rn1pvKcaIkYCpRZydZZR0fWUyxhs=;
        b=ptWg7xcaAv5C7IhJXz0y/Cl7gb/Cxczy6X8u+Sf2RKQ/F5eDMSEOJjsF9F90+om/7H
         CLSUVxCHUU7KUaf5H6uJsTIzTADgRt3iict5qyLE5zTToj0BE0GOMkGKE+8FlYURU9FC
         5x5e9OgeDjrY0Tumi7KPk4pyTF5Ucm0utdzVBfxVj3tucgDd8QPHfX79fT8xQ9+ql3XQ
         EqEimdjjhFOuZ85Y46z36y8qjqTt2qM0PLmm9WwQHOZ4VUKCAxzBzABvPFDeD3K+o/m+
         lTeoJyI2Lg+fATFZTVj1id85dt46E4v8q0jNNo4Uy+BotLHcxSYcVrbjkefTfkzh2aub
         AaAw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=oybHSEJN5rbrfr7rn1pvKcaIkYCpRZydZZR0fWUyxhs=;
        b=iG0oIEQw5AG1M7trVV9NefdNa/oUrsMROItKwtucYM1jy1goHKH8rl9+PsbQPWuNOK
         y0wZYTWaIkXrn8GZaBlLnKdF/klVlGUOOrTzjZssNucbEFW7H8FFU5zVv1SXwnf1zhok
         iCCQC9yCYKFS2uRJgsvf/OLjpMOe0sbBBVmQ0QdlrMWn0fhI7KNcbPQc3ysS6jlGUOw1
         O3X8GUMNVYidIpwHTpSP6RSPNxMqadVyClLd41CC4IaPCzjetat7U8s2ZklkcIVudfXA
         gKn+ABP6/tJ5mOLg2Zrihss5VnfXhxyxRmcMM3+cJVIprwGt+AQvivJ/1Ej7MWLoEYUO
         z4Qg==
X-Gm-Message-State: AOAM530NsiijxLTxrxRJF1dOTXqpJ18P1l+K+MoBMsvHdsDCSKasGEqs
	GIhdf0m3m1Sw4TPx8aGFViduwvkbdAWWF8zX/mE=
X-Google-Smtp-Source: ABdhPJznUe1W4EMGIQrUCGWEGOQoJTO66BiefiHz3+nmNxkR80aqcxKhGkV1ihEBF7H2wXEs+jO3zKwBSd0GdswfvEI=
X-Received: by 2002:a05:6214:19cc:b0:458:bd2:19a8 with SMTP id
 j12-20020a05621419cc00b004580bd219a8mr953456qvc.98.1651153961361; Thu, 28 Apr
 2022 06:52:41 -0700 (PDT)
MIME-Version: 1.0
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
In-Reply-To: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Thu, 28 Apr 2022 16:52:29 +0300
Message-ID: <CAPD2p-ks4ZxWB8YT0pmX1sF_Mu2H+n_SyvdzE8LwVP_k_+Biog@mail.gmail.com>
Subject: Re: Virtio on Xen with Rust
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Stratos Mailing List <stratos-dev@op-lists.linaro.org>, 
	=?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, 
	Stefano Stabellini <stefano.stabellini@xilinx.com>, 
	Mathieu Poirier <mathieu.poirier@linaro.com>, Vincent Guittot <vincent.guittot@linaro.org>, 
	Mike Holmes <mike.holmes@linaro.org>, Wei Liu <wl@xen.org>, 
	xen-devel <xen-devel@lists.xenproject.org>, Juergen Gross <jgross@suse.com>, 
	Julien Grall <julien@xen.org>
Content-Type: multipart/alternative; boundary="0000000000005622e205ddb73d9e"

--0000000000005622e205ddb73d9e
Content-Type: text/plain; charset="UTF-8"

On Thu, Apr 14, 2022 at 12:15 PM Viresh Kumar <viresh.kumar@linaro.org>
wrote:

> Hello,
>

Hello Viresh

[Cc Juergen and Julien]

[sorry for the possible format issues and for the late response]



>
> We verified our hypervisor-agnostic Rust based vhost-user backends with
> Qemu
> based setup earlier, and there was growing concern if they were truly
> hypervisor-agnostic.
>
> In order to prove that, we decided to give it a try with Xen, a type-1
> bare-metal hypervisor.
>
> We are happy to announce that we were able to make progress on that front
> and
> have a working setup where we can test our existing Rust based backends,
> like
> I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.
>

Great work!



>
> Key components:
> --------------
>
> - Xen: https://github.com/vireshk/xen
>
>   Xen requires MMIO and device specific support in order to populate the
>   required devices at the guest. This tree contains four patches on the
> top of
>   mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C).
>

I skimmed through your toolstack patches, awesome, you created a completely
new virtual device "I2C".
FYI, I have updated "Virtio support for toolstack on Arm" [1] since (to
make it more generic), now V7 is available and I have a plan to push V8
soon.



>
> - libxen-sys: https://github.com/vireshk/libxen-sys
>
>   We currently depend on the userspace tools/libraries provided by Xen,
> like
>   xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates provides
> Rust
>   wrappers over those calls, generated automatically with help of bindgen
>   utility in Rust, that allow us to use the installed Xen libraries.
> Though we
>   plan to replace this with Rust based "oxerun" (find below) in longer run.


> - oxerun (WIP): https://gitlab.com/mathieupoirier/oxerun/-/tree/xen-ioctls
>
>   This is Rust based implementations for Ioctl and hypercalls to Xen. This
> is WIP
>   and should eventually replace "libxen-sys" crate entirely (which are C
> based
>   implementation of the same).
>


FYI, currently we are working on one feature to restrict memory access
using Xen grant mappings based on xen-grant DMA-mapping layer for Linux [1].
And there is a working PoC on Arm based on an updated virtio-disk. As for
libraries, there is a new dependency on "xengnttab" library. In comparison
with Xen foreign mappings model (xenforeignmemory),
the Xen grant mappings model is a good fit into the Xen security model,
this is a safe mechanism to share pages between guests.



>
> - vhost-device: https://github.com/vireshk/vhost-device
>
>   These are Rust based vhost-user backends, maintained inside the rust-vmm
>   project. This already contain support for I2C and RNG, while GPIO is
> under
>   review. These are not required to be modified based on hypervisor and are
>   truly hypervisor-agnostic.
>
>   Ideally the backends are hypervisor agnostic, as explained earlier, but
>   because of the way Xen maps the guest memory currently, we need a minor
> update
>   for the backends to work. Xen maps the memory via a kernel file
>   /dev/xen/privcmd, which needs calls to mmap() followed by an ioctl() to
> make
>   it work. For this a hack has been added to one of the rust-vmm crates,
>   vm-virtio, which is used by vhost-user.
>
>
> https://github.com/vireshk/vm-memory/commit/54b56c4dd7293428edbd7731c4dbe5739a288abd
>
>   The update to vm-memory is responsible to do ioctl() after the already
> present
>   mmap().
>

With Xen grant mappings, if I am not mistaken, it is going to be almost the
same: mmap() then ioctl(). But the file will be "/dev/xen/gntdev".



>
> - vhost-user-master (WIP): https://github.com/vireshk/vhost-user-master
>
>   This implements the master side interface of the vhost protocol, and is
> like
>   the vhost-user-backend (https://github.com/rust-vmm/vhost-user-backend)
> crate
>   maintained inside the rust-vmm project, which provides similar
> infrastructure
>   for the backends to use. This shall be hypervisor independent and
> provide APIs
>   for the hypervisor specific implementations. This will eventually be
>   maintained inside the rust-vmm project and used by all Rust based
> hypervisors.
>
> - xen-vhost-master (WIP): https://github.com/vireshk/xen-vhost-master
>
>   This is the Xen specific implementation and uses the APIs provided by
>   "vhost-user-master", "oxerun" and "libxen-sys" crates for its
> functioning.
>
>   This is designed based on the EPAM's "virtio-disk" repository
>   (https://github.com/xen-troops/virtio-disk/) and is pretty much similar
> to it.
>

FYI, new branch "virtio_grant" besides supporting Xen grant mappings also
supports virtio-mmio modern transport.



>
>   One can see the analogy as:
>
>   Virtio-disk == "Xen-vhost-master" + "vhost-user-master" + "oxerun" +
> "libxen-sys" + "vhost-device".
>
>
>
> Test setup:
> ----------
>
> 1. Build Xen:
>
>   $ ./configure --libdir=/usr/lib --build=x86_64-unknown-linux-gnu
> --host=aarch64-linux-gnu --disable-docs --disable-golang
> --disable-ocamltools
> --with-system-qemu=/root/qemu/build/i386-softmmu/qemu-system-i386;
>   $ make -j9 debball CROSS_COMPILE=aarch64-linux-gnu- XEN_TARGET_ARCH=arm64
>
> 2. Run Xen via Qemu on X86 machine:
>
>   $ qemu-system-aarch64 -machine virt,virtualization=on -cpu cortex-a57
> -serial mon:stdio \
>         -device virtio-net-pci,netdev=net0 -netdev
> user,id=net0,hostfwd=tcp::8022-:22 \
>         -device virtio-scsi-pci -drive
> file=/home/vireshk/virtio/debian-bullseye-arm64.qcow2,index=0,id=hd0,if=none,format=qcow2
> -device scsi-hd,drive=hd0 \
>         -display none -m 8192 -smp 8 -kernel /home/vireshk/virtio/xen/xen \
>         -append "dom0_mem=5G,max:5G dom0_max_vcpus=7 loglvl=all
> guest_loglvl=all" \
>         -device
> guest-loader,addr=0x46000000,kernel=/home/vireshk/kernel/barm64/arch/arm64/boot/Image,bootargs="root=/dev/sda2
> console=hvc0 earlyprintk=xen" \
>         -device ds1338,address=0x20     # This is required to create a
> virtual I2C based RTC device on Dom0.
>
>   This should get Dom0 up and running.
>
> 3. Build rust crates:
>
>   $ cd /root/
>   $ git clone https://github.com/vireshk/xen-vhost-master
>   $ cd xen-vhost-master
>   $ cargo build
>
>   $ cd ../
>   $ git clone https://github.com/vireshk/vhost-device
>   $ cd vhost-device
>   $ cargo build
>
> 4. Setup I2C based RTC device
>
>   $ echo ds1338 0x20 > /sys/bus/i2c/devices/i2c-0/new_device; echo 0-0020
> > /sys/bus/i2c/devices/0-0020/driver/unbind
>
> 5. Lets run everything now
>
>   # Start the I2C backend in one terminal (open new terminal with "ssh
>   # root@localhost -p8022"). This tells the I2C backend to hook up to
>   # "/root/vi2c.sock0" socket and wait for the master to start transacting.
>   $ /root/vhost-device/target/debug/vhost-device-i2c -s /root/vi2c.sock -c
> 1 -l 0:32
>
>   # Start the xen-vhost-master in another terminal. This provides the path
> of
>   # the socket to the master side and the device to look from Xen, which
> is I2C
>   # here.
>   $ /root/xen-vhost-master/target/debug/xen-vhost-master --socket-path
> /root/vi2c.sock0 --name i2c
>
>   # Start guest in another terminal, i2c_domu.conf is attached. The guest
> kernel
>   # should have Virtio related config options enabled, along with
> i2c-virtio
>   # driver.
>   $ xl create -c  i2c_domu.conf
>
>   # The guest should boot fine now. Once the guest is up, you can create
> the I2C
>   # RTC device and use it. Following will create /dev/rtc0 in the guest,
> which
>   # you can configure with 'hwclock' utility.
>
>   $ echo ds1338 0x20 > /sys/bus/i2c/devices/i2c-0/new_device
>

Thanks for the detailed instruction.



>
>
> Hope this helps.
>
> --
> viresh
>

[1]
https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/
[2]
https://lore.kernel.org/xen-devel/1650646263-22047-1-git-send-email-olekstysh@gmail.com/


-- 
Regards,

Oleksandr Tyshchenko

--0000000000005622e205ddb73d9e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Apr 14, 2022 at 12:15 PM Vire=
sh Kumar &lt;<a href=3D"mailto:viresh.kumar@linaro.org">viresh.kumar@linaro=
.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1=
ex">Hello,<br></blockquote><div><br></div><div>Hello=C2=A0Viresh</div><div>=
<br></div><div>[Cc Juergen and Julien]</div><div><br></div><div>[sorry for =
the possible format issues and for the late response]</div><div><br></div><=
div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
We verified our hypervisor-agnostic Rust based vhost-user backends with Qem=
u<br>
based setup earlier, and there was growing concern if they were truly<br>
hypervisor-agnostic.<br>
<br>
In order to prove that, we decided to give it a try with Xen, a type-1<br>
bare-metal hypervisor.<br>
<br>
We are happy to announce that we were able to make progress on that front a=
nd<br>
have a working setup where we can test our existing Rust based backends, li=
ke<br>
I2C, GPIO, RNG (though only I2C is tested as of now) over Xen.<br></blockqu=
ote><div><br></div><div>Great work!</div><div><br></div><div>=C2=A0</div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Key components:<br>
--------------<br>
<br>
- Xen: <a href=3D"https://github.com/vireshk/xen" rel=3D"noreferrer" target=
=3D"_blank">https://github.com/vireshk/xen</a><br>
<br>
=C2=A0 Xen requires MMIO and device specific support in order to populate t=
he<br>
=C2=A0 required devices at the guest. This tree contains four patches on th=
e top of<br>
=C2=A0 mainline Xen, two from Oleksandr (mmio/disk) and two from me (I2C).<=
br></blockquote><div><br></div><div>I skimmed through your toolstack patche=
s, awesome, you created a completely new virtual device=C2=A0&quot;I2C&quot=
;.=C2=A0</div><div>FYI, I have updated &quot;Virtio support for toolstack o=
n Arm&quot; [1] since (to make it more generic), now V7 is available and I =
have a plan to push V8 soon.</div><div><br></div><div>=C2=A0</div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">
<br>
- libxen-sys: <a href=3D"https://github.com/vireshk/libxen-sys" rel=3D"nore=
ferrer" target=3D"_blank">https://github.com/vireshk/libxen-sys</a><br>
<br>
=C2=A0 We currently depend on the userspace tools/libraries provided by Xen=
, like<br>
=C2=A0 xendevicemodel, xenevtchn, xenforeignmemory, etc. This crates provid=
es Rust<br>
=C2=A0 wrappers over those calls, generated automatically with help of bind=
gen<br>
=C2=A0 utility in Rust, that allow us to use the installed Xen libraries. T=
hough we<br>
=C2=A0 plan to replace this with Rust based &quot;oxerun&quot; (find below)=
 in longer run.</blockquote><blockquote class=3D"gmail_quote" style=3D"marg=
in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e=
x">
<br>
- oxerun (WIP): <a href=3D"https://gitlab.com/mathieupoirier/oxerun/-/tree/=
xen-ioctls" rel=3D"noreferrer" target=3D"_blank">https://gitlab.com/mathieu=
poirier/oxerun/-/tree/xen-ioctls</a><br>
<br>
=C2=A0 This is Rust based implementations for Ioctl and hypercalls to Xen. =
This is WIP<br>
=C2=A0 and should eventually replace &quot;libxen-sys&quot; crate entirely =
(which are C based<br>
=C2=A0 implementation of the same).<br></blockquote><div>=C2=A0</div><div><=
br></div><div>FYI, currently we are working on one feature to=C2=A0restrict=
 memory access using Xen grant mappings based on=C2=A0xen-grant DMA-mapping=
 layer for Linux [1].</div><div>And there is a working PoC on Arm based on =
an updated virtio-disk. As for libraries, there is a new dependency=C2=A0on=
 &quot;xengnttab&quot;=C2=A0library. In comparison with Xen foreign mapping=
s model (xenforeignmemory),</div><div>the=C2=A0Xen grant mappings model is =
a good fit into the Xen security model, this is a safe mechanism to share p=
ages between guests.</div><div><br></div><div>=C2=A0</div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">
<br>
- vhost-device: <a href=3D"https://github.com/vireshk/vhost-device" rel=3D"=
noreferrer" target=3D"_blank">https://github.com/vireshk/vhost-device</a><b=
r>
<br>
=C2=A0 These are Rust based vhost-user backends, maintained inside the rust=
-vmm<br>
=C2=A0 project. This already contain support for I2C and RNG, while GPIO is=
 under<br>
=C2=A0 review. These are not required to be modified based on hypervisor an=
d are<br>
=C2=A0 truly hypervisor-agnostic.<br>
<br>
=C2=A0 Ideally the backends are hypervisor agnostic, as explained earlier, =
but<br>
=C2=A0 because of the way Xen maps the guest memory currently, we need a mi=
nor update<br>
=C2=A0 for the backends to work. Xen maps the memory via a kernel file<br>
=C2=A0 /dev/xen/privcmd, which needs calls to mmap() followed by an ioctl()=
 to make<br>
=C2=A0 it work. For this a hack has been added to one of the rust-vmm crate=
s,<br>
=C2=A0 vm-virtio, which is used by vhost-user.<br>
<br>
=C2=A0 <a href=3D"https://github.com/vireshk/vm-memory/commit/54b56c4dd7293=
428edbd7731c4dbe5739a288abd" rel=3D"noreferrer" target=3D"_blank">https://g=
ithub.com/vireshk/vm-memory/commit/54b56c4dd7293428edbd7731c4dbe5739a288abd=
</a><br>
<br>
=C2=A0 The update to vm-memory is responsible to do ioctl() after the alrea=
dy present<br>
=C2=A0 mmap().<br></blockquote><div><br></div><div>With Xen grant mappings,=
 if I am not mistaken, it is going to be almost the same: mmap() then ioctl=
(). But the file will be=C2=A0&quot;/dev/xen/gntdev&quot;.</div><div><br></=
div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
- vhost-user-master (WIP): <a href=3D"https://github.com/vireshk/vhost-user=
-master" rel=3D"noreferrer" target=3D"_blank">https://github.com/vireshk/vh=
ost-user-master</a><br>
<br>
=C2=A0 This implements the master side interface of the vhost protocol, and=
 is like<br>
=C2=A0 the vhost-user-backend (<a href=3D"https://github.com/rust-vmm/vhost=
-user-backend" rel=3D"noreferrer" target=3D"_blank">https://github.com/rust=
-vmm/vhost-user-backend</a>) crate<br>
=C2=A0 maintained inside the rust-vmm project, which provides similar infra=
structure<br>
=C2=A0 for the backends to use. This shall be hypervisor independent and pr=
ovide APIs<br>
=C2=A0 for the hypervisor specific implementations. This will eventually be=
<br>
=C2=A0 maintained inside the rust-vmm project and used by all Rust based hy=
pervisors.<br>
<br>
- xen-vhost-master (WIP): <a href=3D"https://github.com/vireshk/xen-vhost-m=
aster" rel=3D"noreferrer" target=3D"_blank">https://github.com/vireshk/xen-=
vhost-master</a><br>
<br>
=C2=A0 This is the Xen specific implementation and uses the APIs provided b=
y<br>
=C2=A0 &quot;vhost-user-master&quot;, &quot;oxerun&quot; and &quot;libxen-s=
ys&quot; crates for its functioning.<br>
<br>
=C2=A0 This is designed based on the EPAM&#39;s &quot;virtio-disk&quot; rep=
ository<br>
=C2=A0 (<a href=3D"https://github.com/xen-troops/virtio-disk/" rel=3D"noref=
errer" target=3D"_blank">https://github.com/xen-troops/virtio-disk/</a>) an=
d is pretty much similar to it.<br></blockquote><div><br></div><div>FYI, ne=
w branch &quot;virtio_grant&quot; besides supporting Xen grant mappings als=
o supports virtio-mmio modern transport.</div><div><br></div><div>=C2=A0</d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
=C2=A0 One can see the analogy as:<br>
<br>
=C2=A0 Virtio-disk =3D=3D &quot;Xen-vhost-master&quot; + &quot;vhost-user-m=
aster&quot; + &quot;oxerun&quot; + &quot;libxen-sys&quot; + &quot;vhost-dev=
ice&quot;.<br>
<br>
<br>
<br>
Test setup:<br>
----------<br>
<br>
1. Build Xen:<br>
<br>
=C2=A0 $ ./configure --libdir=3D/usr/lib --build=3Dx86_64-unknown-linux-gnu=
 --host=3Daarch64-linux-gnu --disable-docs --disable-golang --disable-ocaml=
tools --with-system-qemu=3D/root/qemu/build/i386-softmmu/qemu-system-i386;<=
br>
=C2=A0 $ make -j9 debball CROSS_COMPILE=3Daarch64-linux-gnu- XEN_TARGET_ARC=
H=3Darm64<br>
<br>
2. Run Xen via Qemu on X86 machine:<br>
<br>
=C2=A0 $ qemu-system-aarch64 -machine virt,virtualization=3Don -cpu cortex-=
a57 -serial mon:stdio \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -device virtio-net-pci,netdev=3Dnet0 -netdev us=
er,id=3Dnet0,hostfwd=3Dtcp::8022-:22 \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -device virtio-scsi-pci -drive file=3D/home/vir=
eshk/virtio/debian-bullseye-arm64.qcow2,index=3D0,id=3Dhd0,if=3Dnone,format=
=3Dqcow2 -device scsi-hd,drive=3Dhd0 \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -display none -m 8192 -smp 8 -kernel /home/vire=
shk/virtio/xen/xen \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -append &quot;dom0_mem=3D5G,max:5G dom0_max_vcp=
us=3D7 loglvl=3Dall guest_loglvl=3Dall&quot; \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -device guest-loader,addr=3D0x46000000,kernel=
=3D/home/vireshk/kernel/barm64/arch/arm64/boot/Image,bootargs=3D&quot;root=
=3D/dev/sda2 console=3Dhvc0 earlyprintk=3Dxen&quot; \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -device ds1338,address=3D0x20=C2=A0 =C2=A0 =C2=
=A0# This is required to create a virtual I2C based RTC device on Dom0.<br>
<br>
=C2=A0 This should get Dom0 up and running.<br>
<br>
3. Build rust crates:<br>
<br>
=C2=A0 $ cd /root/<br>
=C2=A0 $ git clone <a href=3D"https://github.com/vireshk/xen-vhost-master" =
rel=3D"noreferrer" target=3D"_blank">https://github.com/vireshk/xen-vhost-m=
aster</a><br>
=C2=A0 $ cd xen-vhost-master<br>
=C2=A0 $ cargo build<br>
<br>
=C2=A0 $ cd ../<br>
=C2=A0 $ git clone <a href=3D"https://github.com/vireshk/vhost-device" rel=
=3D"noreferrer" target=3D"_blank">https://github.com/vireshk/vhost-device</=
a><br>
=C2=A0 $ cd vhost-device<br>
=C2=A0 $ cargo build<br>
<br>
4. Setup I2C based RTC device<br>
<br>
=C2=A0 $ echo ds1338 0x20 &gt; /sys/bus/i2c/devices/i2c-0/new_device; echo =
0-0020 &gt; /sys/bus/i2c/devices/0-0020/driver/unbind<br>
<br>
5. Lets run everything now<br>
<br>
=C2=A0 # Start the I2C backend in one terminal (open new terminal with &quo=
t;ssh<br>
=C2=A0 # root@localhost -p8022&quot;). This tells the I2C backend to hook u=
p to<br>
=C2=A0 # &quot;/root/vi2c.sock0&quot; socket and wait for the master to sta=
rt transacting.<br>
=C2=A0 $ /root/vhost-device/target/debug/vhost-device-i2c -s /root/vi2c.soc=
k -c 1 -l 0:32<br>
<br>
=C2=A0 # Start the xen-vhost-master in another terminal. This provides the =
path of<br>
=C2=A0 # the socket to the master side and the device to look from Xen, whi=
ch is I2C<br>
=C2=A0 # here.<br>
=C2=A0 $ /root/xen-vhost-master/target/debug/xen-vhost-master --socket-path=
 /root/vi2c.sock0 --name i2c<br>
<br>
=C2=A0 # Start guest in another terminal, i2c_domu.conf is attached. The gu=
est kernel<br>
=C2=A0 # should have Virtio related config options enabled, along with i2c-=
virtio<br>
=C2=A0 # driver.<br>
=C2=A0 $ xl create -c=C2=A0 i2c_domu.conf<br>
<br>
=C2=A0 # The guest should boot fine now. Once the guest is up, you can crea=
te the I2C<br>
=C2=A0 # RTC device and use it. Following will create /dev/rtc0 in the gues=
t, which<br>
=C2=A0 # you can configure with &#39;hwclock&#39; utility.<br>
<br>
=C2=A0 $ echo ds1338 0x20 &gt; /sys/bus/i2c/devices/i2c-0/new_device<br></b=
lockquote><div><br></div><div>Thanks for the detailed instruction.=C2=A0</d=
iv><div><br></div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">
<br>
<br>
Hope this helps.<br>
<br>
-- <br>
viresh<br></blockquote><div><br></div><div>[1]=C2=A0=C2=A0<a href=3D"https:=
//lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmai=
l.com/">https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-=
olekstysh@gmail.com/</a></div><div>[2]=C2=A0<a href=3D"https://lore.kernel.=
org/xen-devel/1650646263-22047-1-git-send-email-olekstysh@gmail.com/">https=
://lore.kernel.org/xen-devel/1650646263-22047-1-git-send-email-olekstysh@gm=
ail.com/</a></div><div><br></div></div><div><br></div>-- <br><div dir=3D"lt=
r" class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><d=
iv dir=3D"ltr"><span style=3D"background-color:rgb(255,255,255)"><font size=
=3D"2"><span style=3D"color:rgb(51,51,51);font-family:Arial,sans-serif">Reg=
ards,</span></font></span></div><div dir=3D"ltr"><br></div><div dir=3D"ltr"=
><div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2">Ol=
eksandr Tyshchenko</font></span></div></div></div></div></div></div></div><=
/div>

--0000000000005622e205ddb73d9e--


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 13:55:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 13:55:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316561.535488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4ce-0005hS-3j; Thu, 28 Apr 2022 13:55:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316561.535488; Thu, 28 Apr 2022 13:55:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4ce-0005hL-0q; Thu, 28 Apr 2022 13:55:56 +0000
Received: by outflank-mailman (input) for mailman id 316561;
 Thu, 28 Apr 2022 13:55:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O/gZ=VG=citrix.com=prvs=110729f0c=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nk4cc-0005hC-L2
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 13:55:54 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9f02385-c6fa-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 15:55:52 +0200 (CEST)
Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 09:55:48 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM5PR03MB2524.namprd03.prod.outlook.com (2603:10b6:3:74::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Thu, 28 Apr
 2022 13:55:46 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 13:55:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9f02385-c6fa-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651154152;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ZKfrRMDGfehBxx8jdH+CW02p0Zwoxh+fzEBPnPCTDI0=;
  b=b1XeqUaaTunAmcFdBYrt1OSADQpxKt3j/TkPFnGIegCsJwaclgJXo4Th
   Nr+iTM75r1/4pELzSYse7wLjteiU7V+WomUXy9hBzsE+Q/HKNaNSjbBO+
   IAsafC5ldM3CTxazG2CQvhy4+IsFAHYzVhK2kuUGVi2qRoHoyZ8FEprxr
   o=;
X-IronPort-RemoteIP: 104.47.70.108
X-IronPort-MID: 70141024
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:gpNeXqDkMof0DxVW/5fiw5YqxClBgxIJ4kV8jS/XYbTApGlz0mBUm
 zBMWmvVPv2LNGvze9gjPYzg9htX6pfTm9M3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Jj0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhLz
 c9i6L6WTzwpFZ3x274bbhVTLj9HaPguFL/veRBTsOS15mifKz7G5aorC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6l+B8mbE80m5vcBtNs0rtpJEvvEI
 dIQdBJkbQjaYg0JMVASYH47tLjw3yWmK2cEwL6TjfYI7TfI3DBO6YPsa4vVdeSKGtcPk1nN8
 woq+Ey8WHn2Lue31TOA+2nqguLJkjL2XKoTEqG18rhhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVQBmQsHOC+BkGVLJ4EeIg7xqW4rHJ+AvfDW8BJhZDYtE7sM49RRQxy
 0SE2djuAFRHsqCRSH+b3qeZq3W1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdpsH8HDjr6
 yyJqCU4iKQeiYgA0KDT1VnGmDutopHhRA8p6gjZU2Sp4xk/b4mgD6Sw8VnB5v9EJYyEZlOAo
 HQJlcWY4O0US5qKkUSlQvgLWreg5P+HMTjVqV9pA5QlsT+q/haLfo1O4Tc4OEZgNO4FfyPkZ
 AnYvgY52XNIFH6jbKsyaYTuDc0vlPDkDY68DqCSacdSaJ9scgPB5DtpeUObw2Hqlg4rjL07P
 pCYN82rCB72FJha8dZ/fM9FuZdD+8z07Tq7qUzTp/h/7YejWQ==
IronPort-HdrOrdr: A9a23:NUKg4aFalbjIIkW1pLqFYZHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH
 PQ3LsOm9LmEk5nHfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wgK7VBaM0o9
 gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ny4kY1jiaGgOKsk8SgDwgq+yxokJz8eXX7FN5KcOuf
 36ISZlXCgJCg/TNfE=
X-IronPort-AV: E=Sophos;i="5.91,295,1647316800"; 
   d="scan'208";a="70141024"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e2h/cxzUS/6rY2fO03OR8yODD+z0Ctg7He74iyD6yIo8mUHjOhug4H30AIWCDq521PmFF22bMv0pqBRYUP/mbynR1+qms+pF9gR2iQL8gVdC48yyyG4CD4N7brJA1w3g64dJhSSVpTEbiwq4MQRtVefoGQ5/XOdDVWhs+0moVh9xxAHb0u7Nq655xv1EmdZwhi88lTT6ev14opaA6tyabtQDO915yY5v8fI5/lca5QQ9SZDK9l1TNV4ClrxSfEQMCvuaomNwGtloJ2/uAQwzSv4Hgr59ieiAtV7CIcYlpYa75aGaT8j1VFANKRTLRpe6gJNhLPp/cN8bJXq2xxethw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=831BCFKGRs77SzyJAQwsYxavlgU7q1opZXsFukVE0JY=;
 b=kmZ3U+7IqQDukWr1sxmmiq1x7qsXqSjS7j2TjTlrYi9OIZpkWH63De+/yCeDNLrkabqzVE72HQ10N6JvAc9Piaw4S4I1q33wKTQZTulWRSlUGURbYmlPiZxc2+erWMw9SNd1bnhFkYrYv0s4Ob3GFuYoOfjPqeWXYzxJOECobZ+4s4rUI6eRQkMLDZw4g70G5mBg+eWkKRAH1VqjrR7jZOtqT/fQFvfd6Lgl3R89IBJGMX//ATJYU8lKcuffVPXhc6u5J8KnejInH06JXng/f9IfP0VGpqC7/Sn3tZaPyUqJjHu4Pe+hbzu2NmEz3DM22WM9prep3qrcvtwtNWw+5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=831BCFKGRs77SzyJAQwsYxavlgU7q1opZXsFukVE0JY=;
 b=CsD/qD8TV7aT/ISRtr1n+stCIbi76RiNKQ05315Sx341Axb/p2uZ4Uw2lkaWBex442uiUBIk4kxbaxg2U8pUemLsUBgRUQz0tYWzrf5Z6gorBliOeQNDDnw2QVHTPZ7EabYD9UkJPgomP7awk6nLKq9C4DT/7MaJv8P5zi62JRA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 28 Apr 2022 15:55:41 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH 3/3] x86/monitor: Add new monitor event to catch all
 vmexits
Message-ID: <Ymqc3dtLq4yTxmg5@Air-de-Roger>
References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com>
 <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com>
X-ClientProxiedBy: LO4P123CA0472.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6d087c89-fb8f-40ef-d800-08da291ecaef
X-MS-TrafficTypeDiagnostic: DM5PR03MB2524:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS:
	<DM5PR03MB2524A24F43528A0DE13572368FFD9@DM5PR03MB2524.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	81YNlq40R7fX/2EXkQh2R6UbKIDi0r4Nf/3fW6ro6M0LuGDWgNr6stWLGDEwageDBlF31uGAr62F4xSeehdMr2UUICS9Kk3V7D9yw5odf5wO+8KXfla5xUND9SRdhDqdlHaYiuR/U+kL6XIdSDS+5Z9c8e4+2CupGkxcDPopm1ClkVR9jwp1joHaWLrsZzSPC2fYRMvU1Pd4qIMOcZ7oJQ/5Yfqd8P6xn4zbGKicquozduaoAIaqxWL2blgokR9i+7AzEKvv5Myl08njeHLqC8q6KQu6afyYPq7CyAIX38qmlSY1MYYxm8fv7nyEoyWdR6a5Hh3PnXVDh/vyqZkKV4N37snTdi/GWkAZWWL9qByXEj4lU+Bx9fllLIzBoPftfmIqif+mjQxQEOjG2RWgkkYbn+Uv5igGH1VRyshkLIY9EmYWnKFKc68teOwmH0ftlYSPIZI0IAE1sCTqWq/bz6CRh1H2UdUgaY+dA8SekzRbML0UIbq8Bd5qmTfP1h8t5KcmczqYI29Obsfj6gIjsr7xMsQKEHTzvUTGh6om84cwxD8kq+mSvm7AuFgEwoHcF6OcuGodfemo/6K7qys+gkjGE6JzrFEQK4yTnaKhgIq7mYufraAVCkrfh5vFhAwOmAkZMv+47V3nrLZdC7Ow0A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(2906002)(9686003)(66476007)(66556008)(508600001)(6486002)(86362001)(38100700002)(85182001)(26005)(33716001)(6512007)(186003)(4326008)(8676002)(66946007)(82960400001)(6506007)(54906003)(6916009)(8936002)(316002)(5660300002)(7416002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eVh2cEV4aS9mMmQxakxkU01VNzVkcDFONEVhTXczSEg0d0xCN3BnamVwbTV1?=
 =?utf-8?B?a1ZMV0lSK00wRUdGczBXLzdWb1kxUHdEYkplM1k3YS9SV2FRUHZLNi8wM3Zp?=
 =?utf-8?B?NXF2T1N2enVkKyt3N3oveENwN1J4ODI5RWlaODdENW1ZSXBnWFFiMGNocnlM?=
 =?utf-8?B?cms4T3JVRGNXaHNOQzg1enlRYTVLNHlBei9tVVZ5YWpiamgwc1NCVG5jSm1J?=
 =?utf-8?B?RWt6Mi9SemRZUHpuOXkwRUszaFZzd0drb0U4bGhpZDZHNGdkdEJ0WUd4U1dr?=
 =?utf-8?B?YVIweXhuQlR4UnJWZXNFVTIzRSt3c1N0UzBmc3hRQ2VNWkkvdHdNYjRTRFlC?=
 =?utf-8?B?U0x3dGxaOEllVjBOS0FjejFlZEcyNWRZY3JWVVd4em5RTFphWGp0UVAyYXFV?=
 =?utf-8?B?SXVaMXpxRnFkNjZnT1lFc3pocGpwSlJrdVBEMGtXZ3Zmb1N5RkRGTnJEVlB4?=
 =?utf-8?B?SUR6SDZxQzF6Q0FKT0FkT0x0eFFkb3pTbHBEblJaMjkxVVBKR2ZGenZUUmd1?=
 =?utf-8?B?b3VPTGVMQzZDMTJaNnYwbmVhWDZPTm9DVUE3L2hmdW10c3ZPV3dkYmRxdUZm?=
 =?utf-8?B?YlQ0dDZ1ZmhnV0R4eG1VQTNlNkZCQ25sOG9BME81M2VFS2hRWnloQVpxNVJ0?=
 =?utf-8?B?MEZpaUh3ZFpNNlZleE1VN0h5SzB1MUZjM3RhNnJ1WmY5V3JyWVdza2dLcnpL?=
 =?utf-8?B?RGl2SEs5cm84NjBKZ24zK2JvVUFsWE5rclJtUWZPdzl3bWFjVi9wNlhmTWQ5?=
 =?utf-8?B?azk3ODluUHBvZGV5S2tmV0prZStoaCtPRjE4cmoxN0tpNXVSRTZXTUJucDdT?=
 =?utf-8?B?a3JwQ2lPUVZiOUwwMW5QRHhtSzkybmt2S0E3eWN0V0NxMG0wRkdBOWFoMm51?=
 =?utf-8?B?M1lWTmxwMG5HanNEZTJQbFNYeE5uczBSOGp2K3FzTmJLQ1R4NkdNVmxmZ29L?=
 =?utf-8?B?NlY1amVnMnZjVzJXcTljY3VkcEJNUXJhZThrZ0QyWlBWZXVaMFV6ZEdCaUtp?=
 =?utf-8?B?NGFEVDd4ZDNRbnVzalB3TTVPRVgxQ2F4Zm5Sc0twSUF3aDZQb0pETiszSk1a?=
 =?utf-8?B?aUNsQjhoQTgvOXpzRnFWUURaKzhQTlRGSkdsc1pxa2htL3NrcWkvUExmdDVE?=
 =?utf-8?B?MjUwVTFtUHZZRHNjZFp0TVd1cEo1TVF3eDRjdEdrNURQYTdJcUVpM3NZKzdB?=
 =?utf-8?B?a2d4RjZvVWhvSE9FYWdqN25vNkkyOHpuVXRGMENpbjBGdTh2S1N6Tlh2amla?=
 =?utf-8?B?RzlXcnhrQTVqZndWR2pmdmRVaHV5dDg3NVF0V3F4WXZZUjQ2QlZiQU11UWVh?=
 =?utf-8?B?YVhyUUp0TGF3dzJML1pGVDdhdnpxTXJvQzJUcVdWT1J1NzY5cUFqUS9CaERt?=
 =?utf-8?B?cTJQbXIxYWxqbjNxM0hIRThwTC9HR0p0YWpHRzJ0UTJOdjZmL2xVaVZpanVw?=
 =?utf-8?B?UXhoL2RlU2RSUXcvdWVDU3Y1VC9taXliYkJEL2hMZW15SGh2SDNoZjlyZHBZ?=
 =?utf-8?B?OGZXNEkwd0lJczI4SEhLUnlXWmoyaFhycGFRTVVGK1FmUm1qZi9MY1VkSVdr?=
 =?utf-8?B?Vjl6NEdHNWQyd1pZVzI2SFVDekdGNjdMZlNsVGFLdDB0Ynp6NmNVRUZQSGx3?=
 =?utf-8?B?c3Vma3AvVVR5ekFSbkNRRWI4RUI3ZXlUaFJYNS9EVnBnNzhKYTErTjgvQm1z?=
 =?utf-8?B?TXE5VHlJSmhTVkJFTjJnRVlsZmtWU1FPWTYrbmFXd2hsN0VqTkJJMVVkbFRs?=
 =?utf-8?B?TlNScG85dkNTWTdTQmJ2VlRRMzlsaEpqVkhueTZ6WHphUWEyczQ3QVVMbzBP?=
 =?utf-8?B?MGpxNGFCaFBWWUtSZkFET3dyRGgzQytiNXpqZENQNDhhZWtCRnVtcTdrd1pN?=
 =?utf-8?B?MEtFM1NGeEJ5dnNzcEJDSE5YVTZLdFZaeHlBNy85cS8wRXB5bURPWC83akNS?=
 =?utf-8?B?bjNWUTRXdlVHWTQ2ZjM0b3l1bWlWbFZRRUxJcEZwaWdQRHpTVExlOW5RWmFY?=
 =?utf-8?B?bW95eEo0RmNwNGdRUmtIRjMwenE0UFBiaENLOHczaUNKSXBldWZHdUh2eXZO?=
 =?utf-8?B?c0dVTjdxQ3YweHJGbllwWE1nYmx4KzZRbWs3L0IrdkJQMFdqZzRHNXZvSmJI?=
 =?utf-8?B?Z0l6SlVJbVpKY1BxK01qTVpGVmdyMWQ1L1hHV2xCaS9JSWJSUnFXbklqeENO?=
 =?utf-8?B?ZGtGVDRFUDgvL0ZIRHJRdW5JUExIV01rUGZ4M3ExdUFHZWVLYmZ3Q2ZnSkpl?=
 =?utf-8?B?TlNieVcyWFlxd0hGTDdmTUxqcW53QXoydjVxTFg4OGIrYURQSFFJZ2xkZzBD?=
 =?utf-8?B?NWxkSVZnNlpoMld4VDBaWEpYZXU3NzhUQ3FiOE9tOXFMdEc4Sjl0RG12VUdC?=
 =?utf-8?Q?Ff4qeeSiNirGk9k8=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d087c89-fb8f-40ef-d800-08da291ecaef
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 13:55:45.9319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iNkylKSOEdR+E7MyHg2ZXsp1+PdAHaBP3QoaaAFfiux67v8mHGzIcAsBbVy+8ejyj0F/aepiykZ05vQUdJ5hCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2524

On Wed, Apr 27, 2022 at 11:34:20AM -0400, Tamas K Lengyel wrote:
> Add monitor event that hooks the vmexit handler allowing for both sync and
> async monitoring of events. With async monitoring an event is placed on the
> monitor ring for each exit and the rest of the vmexit handler resumes normally.
> If there are additional monitor events configured those will also place their
> respective events on the monitor ring.
> 
> With the sync version an event is placed on the monitor ring but the handler
> does not get resumed, thus the sync version is only useful when the VM is not
> expected to resume normally after the vmexit. Our use-case is primarily with
> the sync version with VM forks where the fork gets reset after sync vmexit
> event, thus the rest of the vmexit handler can be safely skipped. This is
> very useful when we want to avoid Xen crashing the VM under any circumstance,
> for example during fuzzing. Collecting all vmexit information regardless of
> the root cause makes it easier to reason about the state of the VM on the
> monitor side, hence we opt to receive all events, even for external interrupt
> and NMI exits and let the monitor agent decide how to proceed.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 14:03:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 14:03:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316568.535500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4jZ-0007E5-Sb; Thu, 28 Apr 2022 14:03:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316568.535500; Thu, 28 Apr 2022 14:03:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4jZ-0007Dy-PA; Thu, 28 Apr 2022 14:03:05 +0000
Received: by outflank-mailman (input) for mailman id 316568;
 Thu, 28 Apr 2022 14:03:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vr1S=VG=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nk4jY-0007Ds-An
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 14:03:04 +0000
Received: from MTA-07-4.privateemail.com (mta-07-4.privateemail.com
 [68.65.122.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ea663450-c6fb-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 16:03:02 +0200 (CEST)
Received: from mta-07.privateemail.com (localhost [127.0.0.1])
 by mta-07.privateemail.com (Postfix) with ESMTP id B900B18000A4
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 10:03:00 -0400 (EDT)
Received: from mail-oi1-f175.google.com (unknown [10.20.151.188])
 by mta-07.privateemail.com (Postfix) with ESMTPA id 92B5918000AC
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 10:03:00 -0400 (EDT)
Received: by mail-oi1-f175.google.com with SMTP id a10so5403764oif.9
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 07:03:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea663450-c6fb-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1651154580;
	bh=cjZMWTYdL2qt+00bX/PWyTd5ChKGhDO3djSqfRWv2xQ=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=RKYzi63/pkv0MdTsXxrBvdII4+ky2OgAN/6lZPGkKrgJLBXbMwg89rRxnB1ebps+y
	 hY5Y84k/eegr8u+VhjtS1tuHrClEpj1iJKB2MOVgMreR2h4gM8gaYcZOxCP+p9/VEM
	 qS0m+wvasvXmiWZ9dwrP24bhZHPGXuM8XhT4FYT9xPTh+hQKdSWRNHc1qFApAXYikn
	 qTcqVaDUlQvpWQ6VJWXKLLsX1KuF9SjB5bIXbBmpUkpU/2c1AA+WNjqm85cg8cdfrZ
	 vW6eb0VhA3iMk7CGp09U03ZSuzvje6kDXHg6TxyIuWUge0iL/0miFfev4YZ9puZhpt
	 Vz7YiitToJZZw==
X-Gm-Message-State: AOAM530ChJOLNZ5WujTRLKI2JFSXAez8EjN38KqteKZYjwt6rgpZuKns
	dSxLsvnEYJa5AMbrtC5yS3ypPho+JMQoxFspu7E=
X-Google-Smtp-Source: ABdhPJy62p2qGmO2M4uD6wcboE6BbwQp8Ew5Wz6sebUDFmlp3oSlJHHt67t3hEx5oegX/dqvBfr/H9SEKEptfm/EcQU=
X-Received: by 2002:a05:6808:302b:b0:2f9:eeef:f03 with SMTP id
 ay43-20020a056808302b00b002f9eeef0f03mr20352239oib.128.1651154579945; Thu, 28
 Apr 2022 07:02:59 -0700 (PDT)
MIME-Version: 1.0
References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com>
 <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com>
 <Ymqc3dtLq4yTxmg5@Air-de-Roger>
In-Reply-To: <Ymqc3dtLq4yTxmg5@Air-de-Roger>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Thu, 28 Apr 2022 10:02:24 -0400
X-Gmail-Original-Message-ID: <CABfawhnkBO_JNQ7JajX8LvE4gPCc55Bn6+3TW5hVKWM5qTtqPw@mail.gmail.com>
Message-ID: <CABfawhnkBO_JNQ7JajX8LvE4gPCc55Bn6+3TW5hVKWM5qTtqPw@mail.gmail.com>
Subject: Re: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, xen-devel@lists.xenproject.org, 
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Alexandru Isaila <aisaila@bitdefender.com>, 
	Petre Pircalabu <ppircalabu@bitdefender.com>, Jun Nakajima <jun.nakajima@intel.com>, 
	Kevin Tian <kevin.tian@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP

On Thu, Apr 28, 2022 at 9:56 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.com>=
 wrote:
>
> On Wed, Apr 27, 2022 at 11:34:20AM -0400, Tamas K Lengyel wrote:
> > Add monitor event that hooks the vmexit handler allowing for both sync =
and
> > async monitoring of events. With async monitoring an event is placed on=
 the
> > monitor ring for each exit and the rest of the vmexit handler resumes n=
ormally.
> > If there are additional monitor events configured those will also place=
 their
> > respective events on the monitor ring.
> >
> > With the sync version an event is placed on the monitor ring but the ha=
ndler
> > does not get resumed, thus the sync version is only useful when the VM =
is not
> > expected to resume normally after the vmexit. Our use-case is primarily=
 with
> > the sync version with VM forks where the fork gets reset after sync vme=
xit
> > event, thus the rest of the vmexit handler can be safely skipped. This =
is
> > very useful when we want to avoid Xen crashing the VM under any circums=
tance,
> > for example during fuzzing. Collecting all vmexit information regardles=
s of
> > the root cause makes it easier to reason about the state of the VM on t=
he
> > monitor side, hence we opt to receive all events, even for external int=
errupt
> > and NMI exits and let the monitor agent decide how to proceed.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>
> Thanks, Roger.

Thank you!
Tamas


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 14:12:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 14:12:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316574.535511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4sD-0000Fl-Og; Thu, 28 Apr 2022 14:12:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316574.535511; Thu, 28 Apr 2022 14:12:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4sD-0000Fe-KO; Thu, 28 Apr 2022 14:12:01 +0000
Received: by outflank-mailman (input) for mailman id 316574;
 Thu, 28 Apr 2022 14:12:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IJsv=VG=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nk4sC-0000FY-0b
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 14:12:00 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0622.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::622])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29abb170-c6fd-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 16:11:58 +0200 (CEST)
Received: from AS9PR06CA0723.eurprd06.prod.outlook.com (2603:10a6:20b:487::6)
 by AM0PR08MB5025.eurprd08.prod.outlook.com (2603:10a6:208:15e::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 28 Apr
 2022 14:11:54 +0000
Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:487:cafe::14) by AS9PR06CA0723.outlook.office365.com
 (2603:10a6:20b:487::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.18 via Frontend
 Transport; Thu, 28 Apr 2022 14:11:54 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Thu, 28 Apr 2022 14:11:53 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Thu, 28 Apr 2022 14:11:53 +0000
Received: from f025c8e05fc3.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D2482549-1089-40CE-9699-240DFC9E130D.1; 
 Thu, 28 Apr 2022 14:11:47 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f025c8e05fc3.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 28 Apr 2022 14:11:47 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM5PR0802MB2451.eurprd08.prod.outlook.com
 (2603:10a6:203:9d::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Thu, 28 Apr
 2022 14:11:44 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::9464:cc9:b4b4:bf8%4]) with mapi id 15.20.5206.014; Thu, 28 Apr 2022
 14:11:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29abb170-c6fd-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ebl/vFDBlQVmoc4HnV+1tuKBMsVpUHh28hZz/1U1QBh0cswPv2cHUIKeD4oIZMGYiXtLZsSZ9ngMqJqd8eQ+o6Ba7YSExjkvvXQY4Dh9sbjjBLCoSl07Ca5hXl6vnDK6Rwf0wEM34bo8XumokDIUnvnr4xGt3MkcIR9i9Y5M1y1GhAMQIscchjjLm4z/iP65j+KZBw3Vxf9UwBA8UgVB8JZ+x3560mTlK5A+zgKJtc7o3NoSf5Bzn1243V68p6+rEAEkQTq768YuSBcUkyHCWcii8z2yLAOL9pY1zIkBFA+HcY3sVAPup77U9E9OLC66YVLe75WkgoMMItrKB1/SKQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=77OWjqVdYfLEVpwINV7v8sHTg257aks75YpSleBQXNY=;
 b=R/y7QNnWVyA+QxLCTb+0PpOjxTd21xG9ofW5QapyC2TBJBFAaGOs90ZBG6/+wD3dn1mest9KBBGke5bgHsrzL5NfiyU/o3UrIYkbJxREmQbR9sWGM2pdbbqa1PEv7aiGXtv7rX2/CDm3IXwEyXEd1cy/G9K4k1ay/dsiJaFKWw+EazawdU9tZyK9sj8vneAnYmsabqgmYspP8o4STegPbyDFrRd4r/Thrax1FMHid9IRG0M0M8SHiRxiOdB9xuOzgaTxQnZGMaEiAEry/l54JPZytup8B4Ks+LALtCd6OoQ1YYX0skRzZPkWFymsJhZwftGaRA1mQllhdXf3yOb40w==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=77OWjqVdYfLEVpwINV7v8sHTg257aks75YpSleBQXNY=;
 b=DK95kwJYgjjgguuP586vJHjuDxB64OoUqqFci/zuBUPkICJQJmVEQ2wqpPYMe3uPgpfs6/24szDG2EcG42gN2yIHW2InQ9U1DooTSWfG6FIxHyOriF/y5SK+IuDJU5sDVc9d8ICOVwC0nUQr7vlXa7dA5N/+gEzFSbCxdI7AjL8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: dc7d2eb5cba73a0a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nT3hc6IW/grXr5ZVMtum5qK1dGQAwlD0mzLXmIfUvsfs3gGsQuy9GU1AGMVv6N5NXQ1XvHwBzHu7oPyj3sSUAQ8fTGhB22+wc9po/m0xCK0D6glXM+GCtlAm+jwgu4HPDTLikfOdL6RFqIfv2qgnVkl1XlICiHpsF1/MGlrG9VYwQkrvDRiHX38q479+MrJboUlpV11GsRcm9Bx+IYRURomJeKVIdxEGXPodoBC/4RUhVZutRvTGZwE1qxkV8xZ01wNLsYWWP73C1vTO1k+TKuX5LlA2pmOsloDj5Gt/ACFUbY26qYcqShyOd+DIy5lYCC5KiH9biYYZ4CJMObhPaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=77OWjqVdYfLEVpwINV7v8sHTg257aks75YpSleBQXNY=;
 b=JHKmMH2jOUQ2KXywFRMzpPj/Ax2NihMkPcRSmraqLjs8YxAyACB0PZxPTePRFE1ZdDVqVzh8x/Q6tCp/gpjiuCf3wGsSgLeyd8MVGwvCouabhYFDkiBUxS0iqiRXDC7Z9pPM6+OgPUCX0YJQqjPMfu502ofVj1qFTJLrqHGOipGSfNt23/GGsB/Fbr3vMp36BrGrg4Mtk9gIte/HEa1FvEjF/mnS2R6naHZwC2Vtpz3ndMFRWub3RwwxTnx0h9Qvbi8rl/AojpeTxHpPzfwuRa5RNlP3T6w8D6Eq8XwDPcxJf9WAy2IoFricZggCQY35bGN/+857haE7UjJgI18X8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=77OWjqVdYfLEVpwINV7v8sHTg257aks75YpSleBQXNY=;
 b=DK95kwJYgjjgguuP586vJHjuDxB64OoUqqFci/zuBUPkICJQJmVEQ2wqpPYMe3uPgpfs6/24szDG2EcG42gN2yIHW2InQ9U1DooTSWfG6FIxHyOriF/y5SK+IuDJU5sDVc9d8ICOVwC0nUQr7vlXa7dA5N/+gEzFSbCxdI7AjL8=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table
Thread-Topic: [PATCH] arm/its: enable LPIs before mapping the collection table
Thread-Index: AQHYWlHsf41jIOfeQ0mX6M++noloAq0EDIIAgAEMUACAADIdgIAAFDQA
Date: Thu, 28 Apr 2022 14:11:44 +0000
Message-ID: <92ECC32D-DA6E-4DC8-B0E2-8EC758471C4B@arm.com>
References:
 <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com>
 <a2bba079-0a26-8648-6f39-93148dbd5107@xen.org>
 <73BA5CB5-8B01-41BF-B967-15886554C230@arm.com>
 <fd2492da-0980-2dd4-f8d8-e2b86e9444ef@xen.org>
In-Reply-To: <fd2492da-0980-2dd4-f8d8-e2b86e9444ef@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: ec501664-cdcf-479a-b000-08da29210bde
x-ms-traffictypediagnostic:
	AM5PR0802MB2451:EE_|VE1EUR03FT041:EE_|AM0PR08MB5025:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB50255E15ACCF42BE3A88913EFCFD9@AM0PR08MB5025.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 HdIvHvkLEKicXbUldg5ZyT6BqAf1RogJ7gREyJelfKddjdxAoPRVHcbeqwQsNlYOyaVCuFYKOI661YIhpb6Vu70R7JkiaMZooKY3LWroAM8SqT3Uutzp1EcxwqRl1ETuZ/RgJ6KUarl5LcoDfaqE69TcOAbLbVXTLbKIbFa9rHSaidMYMkDTThVl2ICX50P/CfvwrEnJo+NTJGh2sfPLipO5ZkTfvOu3ogzYVEvj2ZWm5+vxR8AB+08XHGc1TKtIb7gZB/3VSCj4TdzaBvMGztid1JefqBVO0Kyw4F8wfZ8bk6wQZdqxlLQsY8eESis67X5PdaU/ltJARK5z99oaucdxj539LY5gdat8iFEtvn88t4uJ1kYC/ZweX9fjA2+eGJkvYAjycaoVCDHsiqEICX0ISJUrQqO/g1uzn66+rpVEflNgoA2U9B3goS7tnaZd6ApyVmvWvreMiYA2rYrS+oyuovdJH++TjBKjU5jIhZOAr8fPxHn9NQ/N6jJX1zkUvOYIhT7esX4GK8jirrTPTy4TN8F3zGkYziW+EpybRVjl3pqkxoccfQFYMAyHEmmgWTwFXNSyawV85kl7d2JFVf6PO1iOvgGkXSMNdcQwAWNhfogHqpJNV5KbxCx2thogsdjA76Ak+zDZiZ4AH4EAsF9CZVu4SbguQuMl2B6k1M3LqxBPwBRf4Vrf723dCGf3kYB4sOvoaPHnPDNjnp6K9vVk8PjOJa7vogQBCNYsRjeDa6D4LB5vyffwebYx5LpscGfTc8R2kasqL+9oOt9lntiJY0Ns/t/n55WMW/olTyeXNFJS8SxvRsJaZ3rGq8/Q
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(2906002)(6916009)(86362001)(66476007)(66556008)(66446008)(5660300002)(6486002)(966005)(6512007)(36756003)(83380400001)(2616005)(8676002)(26005)(186003)(122000001)(54906003)(33656002)(316002)(6506007)(53546011)(71200400001)(91956017)(66946007)(38070700005)(76116006)(508600001)(8936002)(4326008)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2DC7E70CF076E64F89F9465E8EE1B4E9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2451
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9f990983-d3fa-4293-8268-08da29210686
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pNcK5fU57l0rdDAYd3HbmOT1NdbYJVXkIkeWiLiFTImzXr4EoAJ5a1u0WEfxisT1F/9npqX9EkpqAxhlbp0wx0B5j1IImP2YJpjIgwaHAdWUNHml4JRZfBGwqOOJ9Wv0Ccb64oruadYtsO22oR55x9L0PVb8ml0VEJq7v7qkM+R53pSM5ZHkiGhhKGIJqAvxfO7+Rtda4Uv9fcOJ458fOU/fgc/NSZYUJ/ky4NxtJVqu1Vz+bN6pWiqOiGd5rGdfWdmeAOVHEz99+8AUByAzMCSQfLsXTJ/+ylnmUvSVp3fJPGwIutGOdFBzSXAGTwzrfSJVmfzAsF0ZqfllW52RxAkdVHHF21ZJvq4i+QWlzFnAgPYyxIYKHmKbTsZT+Nf+vc5Sl+YEQAi1B6Q4Y+j30ZwkoG/0C5xEgrNb+CizkHaF7ELD7+g332FSLykfv94rGzsRkx5uRKRRKUDQ4M3uR+m7Ql3aSZ0CqCUJx/zvRcGHJ7kWnVtQ8Er1+Wswu7WMJ+4MqhPxJpb00ko9v5d8FMs47ENpouJ3rQFfbvQnX8M7F78CNaXkFrrCbEYB1OzJ79hdwndj2sulfrZPxbMXDSlJaDx9w7Zaoc6VEdJ0cCFto6TfJKbHsAiqhDFVjzXbRwC0FVTDmL3hp38ZsQhHB2JyEYBPRmysXcFRKVlup/OymqNK8rrE2kphU7k21dCu3izZTQqH6BUtBtet26SV1+OAaZXnQenihHKgShMbzt+puiu+iiqKwsO1MXdbcF7I
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(53546011)(33656002)(966005)(81166007)(36756003)(82310400005)(2906002)(5660300002)(70586007)(54906003)(70206006)(316002)(6486002)(508600001)(8676002)(86362001)(36860700001)(83380400001)(26005)(6512007)(6506007)(356005)(8936002)(6862004)(40460700003)(4326008)(186003)(336012)(47076005)(107886003)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 14:11:53.5061
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ec501664-cdcf-479a-b000-08da29210bde
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5025

Hi Julien,

> On 28 Apr 2022, at 1:59 pm, Julien Grall <julien@xen.org> wrote:
>=20
>=20
>=20
> On 28/04/2022 11:00, Rahul Singh wrote:
>> Hi Julien,
>>> On 27 Apr 2022, at 6:59 pm, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> Hi Rahul,
>>>=20
>>> On 27/04/2022 17:14, Rahul Singh wrote:
>>>> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are
>>>=20
>>> Looking at the spec (ARM IHI 0069H), I can't find a command error named=
 MAPC_LPI_OFF. Is it something specific to your HW?
>> I found the issue on HW that implements GIC-600 and GIC-600 TRM specify =
the MAPC_LPI_OFF its command error.
>> https://developer.arm.com/documentation/100336/0106/introduction/about-t=
he-gic-600
>> {Table 3-15 ITS command and translation errors, records 13+ page 3-89}
>=20
> Please provide a pointer to the spec in the commit message. This would he=
lp the reviewer to know where MAPC_LPI_OFF come from.
Ok.
>=20
>>>=20
>>>> not enabled before mapping the collection table using MAPC command.
>>>> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collecti=
on
>>>> table.
>>>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>>>> ---
>>>> xen/arch/arm/gic-v3.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>>>> index 3c472ed768..8fb0014b16 100644
>>>> --- a/xen/arch/arm/gic-v3.c
>>>> +++ b/xen/arch/arm/gic-v3.c
>>>> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void)
>>>> /* If the host has any ITSes, enable LPIs now. */
>>>> if ( gicv3_its_host_has_its() )
>>>> {
>>>> + if ( !gicv3_enable_lpis() )
>>>> + return -EBUSY;
>>>> ret =3D gicv3_its_setup_collection(smp_processor_id());
>>>> if ( ret )
>>>> return ret;
>>>> - if ( !gicv3_enable_lpis() )
>>>> - return -EBUSY;
>>>=20
>>> AFAICT, Linux is using the same ordering as your are proposing. It seem=
s to have been introduced from the start, so it is not clear why we chose t=
his approach.
>> Yes I also confirmed that before sending the patch for review. I think t=
his is okay if we enable the enable LPIs before mapping the collection tabl=
e.
>=20
> In general, I expect change touching the GICv3 code based on the specific=
ation rather than "we think this is okay". This reduce the risk to make mod=
ification that could break other platforms (we can't possibly test all of t=
hem).
>=20
> Reading through the spec, the definition of GICR.EnableLPIs contains the =
following:
>=20
> "
> 0b0 LPI support is disabled. Any doorbell interrupt generated as a result=
 of a write to a virtual LPI register must be discarded, and any ITS transl=
ation requests or commands involving LPIs in this Redistributor are ignored=
.
>=20
> 0b1 LPI support is enabled.
> "
>=20
> So your change is correct. But the commit message needs to be updated wit=
h more details on which GIC HW the issue was seen and why your proposal is =
correct (i.e. quoting the spec).

Ok. I will modify the commit msg as below.Please let me know if it is okay.

arm/its: enable LPIs before mapping the collection table

When Xen boots on the platform that implements the GIC 600, ITS
MAPC_LPI_OFF uncorrectable command error issue is oberved.

As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can
be reported if the ITS MAPC command has tried to map a collection to a core
that does not have LPIs enabled.

To fix this issue, enable the LPIs using GICR_CTLR.EnableLPIs before
mapping the collection table.

Regards,
Rahul=


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 14:12:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 14:12:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316576.535522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4sS-0000aQ-4K; Thu, 28 Apr 2022 14:12:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316576.535522; Thu, 28 Apr 2022 14:12:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4sS-0000aJ-1C; Thu, 28 Apr 2022 14:12:16 +0000
Received: by outflank-mailman (input) for mailman id 316576;
 Thu, 28 Apr 2022 14:12:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk4sQ-0000Zn-Tg; Thu, 28 Apr 2022 14:12:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk4sQ-0007pN-QY; Thu, 28 Apr 2022 14:12:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk4sQ-0004l8-BJ; Thu, 28 Apr 2022 14:12:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk4sQ-0007wL-Aq; Thu, 28 Apr 2022 14:12:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ajYUx92hlhyEHRfqmgDHDPY8DbeJl0JpUqI2ce6CY2o=; b=1ttIy0saUCBWuwi1h6ecagB8/3
	J4VpxaX6Ow0h/QU7O1sg1WONcUXcsOmNRaCwN4O33tVnYJeleV2QQlldR8qokuO7q1iNFRm4JzFgm
	CkZdxSTQC4IdCCOQ0SjHmr8x6DydpUSEs7mYgMHesUP78pvDrJbgjiZgigXs8hhJVN/o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169815-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169815: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 14:12:14 +0000

flight 169815 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169815/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  679 attempts
Testing same since   169718  2022-04-25 21:41:52 Z    2 days   51 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5828 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 14:13:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 14:13:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316587.535533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4te-0001Qf-G5; Thu, 28 Apr 2022 14:13:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316587.535533; Thu, 28 Apr 2022 14:13:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk4te-0001QY-CS; Thu, 28 Apr 2022 14:13:30 +0000
Received: by outflank-mailman (input) for mailman id 316587;
 Thu, 28 Apr 2022 14:13:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/SSK=VG=ieee.org=elder@srs-se1.protection.inumbo.net>)
 id 1nk4tc-0000yD-E2
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 14:13:28 +0000
Received: from mail-il1-x130.google.com (mail-il1-x130.google.com
 [2607:f8b0:4864:20::130])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d4d27e4-c6fd-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 16:13:24 +0200 (CEST)
Received: by mail-il1-x130.google.com with SMTP id g10so2055293ilf.6
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 07:13:25 -0700 (PDT)
Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net.
 [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id
 y21-20020a6bc415000000b00648da092c8esm4431ioa.14.2022.04.28.07.13.19
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 28 Apr 2022 07:13:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d4d27e4-c6fd-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=ieee.org; s=google;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=bCT2JlxzOcDaE6ycYVbjB0p6hzfQxFS5OmPVl0XHT4A=;
        b=ByPVeKDwQRcuSB47O0Zefv/dFt5S0aRWMNs2oJF7maE4wXnsormuysnBE3KE+1D9p9
         PB3FB3BjkOR/97x+74MBqA5RA9WqHK53ukE6KnmiwNvHyxwXKz6iLxoZSM4bciItAhHz
         gddQYhhdQpsolBOdwDYZPGvNMFMyqb4ql/QD0=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=bCT2JlxzOcDaE6ycYVbjB0p6hzfQxFS5OmPVl0XHT4A=;
        b=agqo5ToYGDYiPPynIpg5HMBY0XFQm9D1ccVgSVEfxgm+s8jDrSDEOk+cnIi3IMfh7O
         iBcmPxvPWk+WVU2kn+aMIbx/uGwUh4shqjPlxP4oo7LL4dqpVck0y24ztMd/DzKVyfzt
         KDi8TUFYH/jIkn13o1TBI4+maJgvPg3j8XEFnRhADDRIAz+1E7qqlT7uGBMloZKWiST4
         sGvImVa5Ma7ta+U+aaQJNgVeey5CwQ4AlKeMzAOXj8/Pp6OOvOg85shIuN6L8sbYoOxM
         B01sahC8uIS55oFWcvFAv6beLYcF4jHOhwGtDIsg99mibumQf9M+/56IRjJS2fuP51mx
         mfFw==
X-Gm-Message-State: AOAM530BTyR4nesLu/zLMa+95g2uIBJz1gzAHonfZKtvtGwF4QxxX305
	hQ+6esw1eZQOVYgN0SQXfnQokw==
X-Google-Smtp-Source: ABdhPJw448TngRonNTsTASYhGkruvfda4Cqi/x7py0vOs1UkbxiFSjNKZ9c5oG5pi/4oeINikW5dJA==
X-Received: by 2002:a92:cac3:0:b0:2c9:a265:4cab with SMTP id m3-20020a92cac3000000b002c9a2654cabmr13504351ilq.241.1651155203895;
        Thu, 28 Apr 2022 07:13:23 -0700 (PDT)
Message-ID: <4cae140c-982a-6b9f-661c-4e0fdfa3297b@ieee.org>
Date: Thu, 28 Apr 2022 09:13:19 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list
Content-Language: en-US
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org, Alex Elder <elder@kernel.org>,
 Alexander Gordeev <agordeev@linux.ibm.com>,
 Anton Ivanov <anton.ivanov@cambridgegreys.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Bjorn Andersson <bjorn.andersson@linaro.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Chris Zankel
 <chris@zankel.net>, Christian Borntraeger <borntraeger@linux.ibm.com>,
 Corey Minyard <minyard@acm.org>, Dexuan Cui <decui@microsoft.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>,
 Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 James Morse <james.morse@arm.com>, Johannes Berg
 <johannes@sipsolutions.net>, "K. Y. Srinivasan" <kys@microsoft.com>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Matt Turner <mattst88@gmail.com>, Mauro Carvalho Chehab
 <mchehab@kernel.org>, Max Filippov <jcmvbkbc@gmail.com>,
 Michael Ellerman <mpe@ellerman.id.au>, Paul Mackerras <paulus@samba.org>,
 Pavel Machek <pavel@ucw.cz>, Richard Henderson <rth@twiddle.net>,
 Richard Weinberger <richard@nod.at>, Robert Richter <rric@kernel.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Stephen Hemminger <sthemmin@microsoft.com>,
 Sven Schnelle <svens@linux.ibm.com>, Tony Luck <tony.luck@intel.com>,
 Vasily Gorbik <gor@linux.ibm.com>, Wei Liu <wei.liu@kernel.org>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-22-gpiccoli@igalia.com>
From: Alex Elder <elder@ieee.org>
In-Reply-To: <20220427224924.592546-22-gpiccoli@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/27/22 5:49 PM, Guilherme G. Piccoli wrote:
> This patch renames the panic_notifier_list to panic_pre_reboot_list;
> the idea is that a subsequent patch will refactor the panic path
> in order to better split the notifiers, running some of them very
> early, some of them not so early [but still before kmsg_dump()] and
> finally, the rest should execute late, after kdump. The latter ones
> are now in the panic pre-reboot list - the name comes from the idea
> that these notifiers execute before panic() attempts rebooting the
> machine (if that option is set).
> 
> We also took the opportunity to clean-up useless header inclusions,
> improve some notifier block declarations (e.g. in ibmasm/heartbeat.c)
> and more important, change some priorities - we hereby set 2 notifiers
> to run late in the list [iss_panic_event() and the IPMI panic_event()]
> due to the risks they offer (may not return, for example).
> Proper documentation is going to be provided in a subsequent patch,
> that effectively refactors the panic path.
> 
> Cc: Alex Elder <elder@kernel.org>

For "drivers/net/ipa/ipa_smp2p.c":

Acked-by: Alex Elder <elder@kernel.org>

> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Corey Minyard <minyard@acm.org>
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Matt Turner <mattst88@gmail.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Robert Richter <rric@kernel.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Wei Liu <wei.liu@kernel.org>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
> 

. . .


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 14:23:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 14:23:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316598.535556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk53I-00038A-K4; Thu, 28 Apr 2022 14:23:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316598.535556; Thu, 28 Apr 2022 14:23:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk53I-000382-GH; Thu, 28 Apr 2022 14:23:28 +0000
Received: by outflank-mailman (input) for mailman id 316598;
 Thu, 28 Apr 2022 14:23:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk53I-00037t-4s; Thu, 28 Apr 2022 14:23:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk53I-00083p-3C; Thu, 28 Apr 2022 14:23:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk53H-00053C-Oc; Thu, 28 Apr 2022 14:23:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk53H-0002Jl-O9; Thu, 28 Apr 2022 14:23:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=du2M/frstZkskYFLyKbmrdGrmA6JCBACRT7vfW9hoHg=; b=4P+UyzmivxudoLtqIQOV8zDQT9
	oaGh+Pa/7owTWRBcltqOfjSVsLY3u03+Glydz55j//ZlI3syct9aq48uVmarALeXkBC0a3CHS6c5g
	aHOQs2BincCJ5SZFf1J9ffJ3u4N2Iek849H9xbEF+4PRO+LVmfYn/Co+YG6nNQ2OPoqc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169805-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169805: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=381498796cb45dfa80cbfe3f9834072808c691f6
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 14:23:27 +0000

flight 169805 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169805/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              381498796cb45dfa80cbfe3f9834072808c691f6
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  657 days
Failing since        151818  2020-07-11 04:18:52 Z  656 days  638 attempts
Testing same since   169805  2022-04-28 04:20:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 106112 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 14:50:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 14:50:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316607.535567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk5TY-0006U9-UP; Thu, 28 Apr 2022 14:50:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316607.535567; Thu, 28 Apr 2022 14:50:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk5TY-0006U2-RE; Thu, 28 Apr 2022 14:50:36 +0000
Received: by outflank-mailman (input) for mailman id 316607;
 Thu, 28 Apr 2022 14:50:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nk5TX-0006Tv-Mk
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 14:50:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8ea16d21-c702-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 16:50:34 +0200 (CEST)
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03lp2168.outbound.protection.outlook.com [104.47.51.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-0qg2GuooMEW1WEZFkg4Qnw-1; Thu, 28 Apr 2022 16:50:32 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB8PR04MB5849.eurprd04.prod.outlook.com (2603:10a6:10:af::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Thu, 28 Apr
 2022 14:50:31 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 14:50:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ea16d21-c702-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651157433;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=A8stDmbfCiVRa3vsDBlpsWtwv/Zq4Potk7/5iOXXUcg=;
	b=CWdru/tsk/P1o50C0hbiL5mfOUgEsBRnlleb8RkqKDscfyg0kZeIXuz/Gs4OrOqL5D10BL
	JSbiIBlbowZzMLpxnTuue9Bh67BuwWoxvrtNBwGfbE5keje9n9LD/S7YJjaHrAo6Oi0GMY
	bfi1CxikmqpokP0yx/86iFIxsyWUmqI=
X-MC-Unique: 0qg2GuooMEW1WEZFkg4Qnw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m2h+kAAQPHL4xIewzr3NRvSjnLptGoM7xR11LrxyaADvdA1u39WLRPJxqr26w2U575LvsaZR0fyorsgyZXLbMMzV598LcPK4As3bneo8/gbauhqa5L7UadX6fJuNA3bX1KmT9s+huEL/gfA4wla8QCycP9yWFczcyLs8aoBX53l8iBa/6xSmv/l/kPVvMXIfS74qAPjfCpe+w1X36t0Zurnkes6V6ukqxEABPPxx8MKKR2nRUZhzhZ8ri3UAeJ+eXG3J3LW6dtgFVAbQGqdslRQEn0s2T7ug71rcLQHYwS1ESgKiSbmL/f67ubL0aV/V5tyz5TOWpOcyPQDGf6avkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A8stDmbfCiVRa3vsDBlpsWtwv/Zq4Potk7/5iOXXUcg=;
 b=YYOBJkdWb0WXvvko1jgTtbzyftqORJnlMdP6V3gIhrxe/Fx28W7Tmb5GqU9N+X7r5P5lHaBVS8JcKZvsRDE0sdOYeWBzKPYxIXst6p5eVskC8eXcTztJ2HVaW67NQxiMLSLTUZmJzIQjDqbeFi/hnRrFzr/hBo/dlwTOrZjJoZsllUpSYfJ1KNP+WbG6IxeE09EqpWmpJ3p3w2o7pgBqvaEhbsEiL3B25vWfg1+WjAjg/PcDcWldOz9qv7Xn4gDmvXXj5ogx92MjTQCvCe4b7JYS1PDJ35PFhxbWdo0j1op2qFMr3yyyJE+lJxx3FASn5KiSFpQsVhCpfW6iPLh4DA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com>
Date: Thu, 28 Apr 2022 16:50:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: Andrew Lutomirski <luto@kernel.org>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 Peter Zijlstra <peterz@infradead.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/PAT: have pat_enabled() properly reflect state when
 running on e.g. Xen
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0120.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::35) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d1f523ec-68eb-4443-86a6-08da2926712d
X-MS-TrafficTypeDiagnostic: DB8PR04MB5849:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB58491B0CCDD54404C13B3C33B3FD9@DB8PR04MB5849.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eNEtXfzIfXfvCzquEglnq94qvjStgpj31QQ+xz6tqAhmqg9V9s/nIn6jXeGVQrX8ABQgB33jky9eKhCsxAuJyA3qfxFz2MrWGi3n0NzrZ80saf1PtDJrasT4GXEWm5FcirGqe9rT69WQUUXtzuPJgNuT6lnktgvRuEZGTZf/AsRJBmbefZHRLxz8kDJN5WRezPzLt55eyaGaZB0lQik9nKE9tipP8OsOByso3Ep3hyYsYQKQcsvv6m1VtnokhRytKKMflUNlG+DTSjFZswgjL67iJMpERCWB0h84AqmjHaRF1aDZtuvf/baMvvtwbzUYvb/G3ezQWYU0kmmrsSbfVNbUCHKo72RSjcdWDH+dhskhmCLEO8b2o288jF98uRLyCPqid7GkULqzu0xVkoGgFVSmdyXvmVTDOb3/agPvR+3VIXtq0qN0L282yzMejPSbCb0G3EIDzK9oBpWpBuzvOXjJ6Od+/GXyd/qI5b6D5ySGJg18V3nHCbpt1KDZhwXGKhLXMUoFdNezVjqkDNtuLqjugNFriC67KTTWk9vZb/y9VegAdidyZC4WOpTUll16+hvmWcps2s2ADNZ9I/KoKiPtRYl8+mLVmVQTlQV99okbcR94EQ1CLINzNQza+sW/zZ++WAH+P/oXoBSirdLnnQE/qs+MpW6ZsxQmj3Uve9RRSkrCm0nqZRHWblqNcmWMEcjuNGRGgpI0hlClLv1VfjEiDZqOh954KPFU5H3xC64=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(6506007)(54906003)(316002)(4326008)(8936002)(38100700002)(508600001)(66946007)(8676002)(86362001)(66476007)(66556008)(6486002)(5660300002)(31696002)(31686004)(2906002)(26005)(6512007)(186003)(36756003)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dHdwSDRXN1RXaFRSYi9UZG9QQjNudVZJRUk0TzBDVkhlYWp2V21jN05UZzlV?=
 =?utf-8?B?VmVCOEIrbjRScXVibkE2NmlHTnJlbnJMMXZ6a01zZGJqaHhtRm91WDMyc2dM?=
 =?utf-8?B?VWtONnYxVFZKMEZhMXRwbzZ3bk5sZ2kyTlRMblJHZEZuemZ0RC9rTk85UVdl?=
 =?utf-8?B?UW8yWE1acGY5b2xQTlVudW9QZVloM1RyQTNCb2JzVEYybWNyMHI5Tml4Z0RZ?=
 =?utf-8?B?dFRmNXlYSWVlYU53KzRVNHlkQjNwUGRpcDlPL2FNTFR0Y1MwTzlBNWRCYjA5?=
 =?utf-8?B?RXdqNkVWSUlvaTBrVE9ZcmxRb1RlWUxTOWJZeWljQWZQa2tyQUtXaWdhMVJa?=
 =?utf-8?B?eUFnWUMxZHloQ2hKZ2dna2tiOW9laUFzR0c3MDl1NEErZGFhZ3hya0tlMW1W?=
 =?utf-8?B?bjNDcVF4TUN1YldYTUhqaUE0WDZCTXhEL1R1dUJORngzTHRDOFVQb3g0bXRY?=
 =?utf-8?B?bEwyeXVQd3N3UGtDdGp2NWxEWHZyNG9LOEcvN0Q2anpFZmsrckNRSXFrem5q?=
 =?utf-8?B?cFJJcEp5MTNxK0M5TGJQTCthaFUySFVWM1NqNHVRekN5VGE4NERWNTd4QU52?=
 =?utf-8?B?OTJXMmFYbzQ3K0xlL1R3V1IrNDNaTmZLRWtiNkpBZVV1VUpSMElwcXpCaWp3?=
 =?utf-8?B?dEdCNEFYUlEyNHRQclVtOWhtaS9XY0VVVnhrbVpUN0FwZ0JHTHVMdWZveDht?=
 =?utf-8?B?dEVpWlhoMTR1aTl5cnpJcjI3WnJPZVVFZVJ3SVVCZFYwRTVlMktueFJtL2RG?=
 =?utf-8?B?REFWU1JoZlNwVVJ1RWtuUDJUS3B6UGFRK1RqUUpES3RHNk1nb2d4SHdKSEp2?=
 =?utf-8?B?NUN6cEQwYjI0cFNkTVdYY09YbGJiSWwybmgxSDRtcjhNU25DUU9CYnhtakJW?=
 =?utf-8?B?dmFvNVR1YnVreGxOTHZWcTc5Qzh0aEhDdmU3RVVpZVdBbVdXbnRnWG9DUDA4?=
 =?utf-8?B?RmxXaXE1UE4xa3F1bXlmZ09JZUo0OVlPTFZFY3U0QVhVL2JRSm5jTTVPdFBX?=
 =?utf-8?B?cjdJd2V0WXdBLzVYUHpNWGVTcFV6S0RYeUs1RUM4bmhLQmI1Z2tvdURVTWt3?=
 =?utf-8?B?S3R5NDZXYTlGNTJ5VHo0c0N0c2l4dXM2UFB5M3R1bit2dVE0V3dCZnZXK2Fk?=
 =?utf-8?B?KzVGREwrekZZdzRZelZmTlNob3llQXpWTjBaR3FreVB0YnBwcUFKN1IvVnZ6?=
 =?utf-8?B?dklET3BEbjhJRTBDUGJvT3ZQcUNpbU1oYkVvYXEvdmVuVG9sSnkvZ3hwaXRY?=
 =?utf-8?B?S2REc0UzVVp4cU1UbU92L3poQXlqMzluUmFsTjU0UE1ZOVVEeVFGeFg3K1lJ?=
 =?utf-8?B?ZE1sQTJrQlVQWnozRTNGVm12OUg2ZUtVUk9uTHZXS3ZURTMxamJpVEQ3RWNj?=
 =?utf-8?B?Z1p1QkJ1V0ttZHZKNENCbFFsZzNFcjZNVkFlMzByd25XZ3FGSnlqRXFvaFZ6?=
 =?utf-8?B?d082ZVBwdFE3YXBuY2NYbEZleS9GZ3B5NzEveStHVjNJdWorMUVGMDd4NXFR?=
 =?utf-8?B?RnN4QUVQRllzQW9IUVJwK0tyL3BXR3ZDQjh4dVl0SzVFS2dPSlB0cnlNTGc0?=
 =?utf-8?B?NnlMazA4WVFVYmNLbU1HL0JNUytEV3EvWjZGMDUzenVxYVFhalFHalU2aGU1?=
 =?utf-8?B?bXFCSm5YNlNtNWJJVGVrR3doazFnSnFEamY0S1JsM0tsbzRVcWM1a2IxczdQ?=
 =?utf-8?B?U2Q2NS9vTnNFbXk3NGdKNTZvM2NqVm5NVEszVHVrUkR2QUx2RnRESlQxVGg5?=
 =?utf-8?B?TlViMXo5ajJKc0JNRXVRMkZ0THQzS1gzSFc4RHpPeXoxUjZLYnhjaWZ6V3ZS?=
 =?utf-8?B?eGZNSWtKVncwUzNkRzFwREwxNzhRWklydkpJaDk1V1UrcGxzMExiRzFkYTNL?=
 =?utf-8?B?clhGNTlKcHhUVk9jZ1BobmFOYkxRK0NPaDRRUXB6Z3RrTnQzT0VXK243UHgy?=
 =?utf-8?B?K3lFRXkySDJvSjY3Zy81NEJ1dTc0OGRFeDJVMGtUVGtwZDBhNDhhTVVSWmxo?=
 =?utf-8?B?YnlOYzFYcUlkVFhFWTRkNVlrRGxyT1RoMmVLSG1tM2I0RElTQ0V3SkZDTUJ0?=
 =?utf-8?B?Q0RHdmZBbnRGeEdIVmNKZ3FIUCtYR0FPNVFHUkV2NFlBTWM0MGpCTU9vL2pL?=
 =?utf-8?B?c2dXbUVYaktnVTRYTkNFS0xDTTFBNkwycGYwUUJHQzFEeU5EMUhoTERwbjli?=
 =?utf-8?B?ZDVYcUV2YU5QWFNGWjFFV3ZzSmhUS1RYY0JTWG5IK3pnczhDVHZxOEtjSnVv?=
 =?utf-8?B?MHhFZEE1bU12SVoyYzV1ZkZib1RrZjBIeVloOVdRdkFERk9ybHdIU0NoUTBJ?=
 =?utf-8?B?YVN5RWtlUFFxUFFYVjFOSnBlTloxTEFNVmJDKzRoankrcW9uY2g2Zz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1f523ec-68eb-4443-86a6-08da2926712d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 14:50:31.1889
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zbpWWv14azCdUJpNnfE75pXOgbQy2OrAI4hXRb53mRLSGkxEBTRYZwAWFt7kNnI9kPpR7+b0vmSf6kEB6nncJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5849

The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT
with pat_enabled()") pat_enabled() returning false (because of PAT
initialization being suppressed in the absence of MTRRs being announced
to be available) has become a problem: The i915 driver now fails to
initialize when running PV on Xen (i915_gem_object_pin_map() is where I
located the induced failure), and its error handling is flaky enough to
(at least sometimes) result in a hung system.

Yet even beyond that problem the keying of the use of WC mappings to
pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular
graphics frame buffer accesses would have been quite a bit less
performant than possible.

Arrange for the function to return true in such environments, without
undermining the rest of PAT MSR management logic considering PAT to be
disabled: Specifically, no writes to the PAT MSR should occur.

For the new boolean to live in .init.data, init_cache_modes() also needs
moving to .init.text (where it could/should have lived already before).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
On the system where I observed the issue, a knock-on effect of driver
initialization failing was that the SATA-controller also started to
report failures.

--- a/arch/x86/mm/pat/memtype.c
+++ b/arch/x86/mm/pat/memtype.c
@@ -62,6 +62,7 @@
 
 static bool __read_mostly pat_bp_initialized;
 static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT);
+static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT);
 static bool __read_mostly pat_bp_enabled;
 static bool __read_mostly pat_cm_initialized;
 
@@ -86,6 +87,7 @@ void pat_disable(const char *msg_reason)
 static int __init nopat(char *str)
 {
 	pat_disable("PAT support disabled via boot option.");
+	pat_force_disabled = true;
 	return 0;
 }
 early_param("nopat", nopat);
@@ -272,7 +274,7 @@ static void pat_ap_init(u64 pat)
 	wrmsrl(MSR_IA32_CR_PAT, pat);
 }
 
-void init_cache_modes(void)
+void __init init_cache_modes(void)
 {
 	u64 pat = 0;
 
@@ -313,6 +315,13 @@ void init_cache_modes(void)
 		 */
 		pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) |
 		      PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC);
+	} else if (!pat_force_disabled &&
+	           boot_cpu_has(X86_FEATURE_HYPERVISOR)) {
+		/*
+		 * Clearly PAT is enabled underneath. Allow pat_enabled() to
+		 * reflect this.
+		 */
+		pat_bp_enabled = true;
 	}
 
 	__init_cache_modes(pat);



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 14:57:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 14:57:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316613.535577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk5Zm-0007Bx-JT; Thu, 28 Apr 2022 14:57:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316613.535577; Thu, 28 Apr 2022 14:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk5Zm-0007Bq-Gd; Thu, 28 Apr 2022 14:57:02 +0000
Received: by outflank-mailman (input) for mailman id 316613;
 Thu, 28 Apr 2022 14:57:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8clo=VG=citrix.com=prvs=110d23c25=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nk5Zl-0007Bk-4c
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 14:57:01 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 73203b94-c703-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 16:56:58 +0200 (CEST)
Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Apr 2022 10:56:38 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BL0PR03MB4210.namprd03.prod.outlook.com (2603:10b6:208:67::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 28 Apr
 2022 14:56:36 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 14:56:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73203b94-c703-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651157818;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=zQq7jPN4PSfooRiQESdK2XDAx4HJIEsTRtF8aJ8I+5I=;
  b=T+Dy9Q38D1FjQ6msUbk7fdJ0OJIjU6A45n35REadUPUl3O4fw/R3VSRM
   1p1op5S3VC23ALoxUbn1dEb7czXjI1s980q9NUKIIVLQvIFb9xKvSM3ay
   ffzR6abXZmS31XzOcyI10hNC70DMnUtbQ0+yvv6gVJWWfgjfhdOIvJocO
   U=;
X-IronPort-RemoteIP: 104.47.70.101
X-IronPort-MID: 72609497
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:9KPa7arZZAZmQjJDsmIWLys4wiFeBmICZBIvgKrLsJaIsI4StFCzt
 garIBnQM/uKMGTweNFxYI2/o0NQsJCGmtI2QVFppCg0EyxAp5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvR4
 4Oq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBP5H2mtsmayFjNxpBOLVcyZ/1Jn3vvpnGp6HGWyOEL/RGKmgTZNVd0MAoRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkHhHFp3pkm8fX2P
 qL1bRJGahjabgIJEVAQEJ8kx8+jh2Xlci0eo1WQzUYyyzeJklQgjOmyWDbTUpuQZslavGO5m
 n/hwTnUKBQ9Efuh6RPQpxpAgceKx0sXQrk6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0WcdUEuA8wBGAzOzT+QnxLnMfUjdLZdgitck3bT8nz
 FmEm5XuHzMHmKKRYWKQ8PGTtzzaBMQOBWoLZCtBRw1a5dDm+dk3lkiWFo8lF7OphNroHz222
 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XzgbQHxZ6s9Lqkc2Q=
IronPort-HdrOrdr: A9a23:6Km52ak9XDQ3C3wRBwt6FrV354DpDfN1iWdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee
 r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp
 gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e
 XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5
 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe
 q1NdZfH+LjRFGebLp04w==
X-IronPort-AV: E=Sophos;i="5.91,295,1647316800"; 
   d="scan'208";a="72609497"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=chx+E7hzjrQ7Gm6TjqWp+SMwgfp1qLTYwmpR5Qzewfq917qOaadX0A1EXJYPUd7UzARxvCfpriSCzvQY3nBSRW3lXJu+5RBGEgJMyXbebvlcV996NZl16cLGn/gVVnEKS0hAgHXxxI5Eizd9Vtb47t21o2yAmp4weSycvIYGMWDuZPn/2ZtzLuiIH1QffbM8TneTt1uFxDnKhhagim5fyYvrfKPts1tpsPANGzbJY3dogl8SuFYUDZ8DCyxnbtt3z3ygSz238CJFfq2I3+kVp8xdQAGpTqdgPx8Et8FWRnipXl+L7kPPaM+KCZu84L5B/IaBlBYYqQSVRLG1nIY+EA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zQq7jPN4PSfooRiQESdK2XDAx4HJIEsTRtF8aJ8I+5I=;
 b=Wi2f3+6u2jmdluUXzpI3m3iBefl/NkYnPkKsIYPBa8o1jOrAz/m4dI2YrLF5vv+acfq9FSXsGIcUrCDIadjYGQeBEt+s7+zJBZ/AHJCZ3rjeu3mmYJw/5wD1A9Hn1IPP5BC022iCG1E4vL3HZkj+wXf62wCkF15bktSt7d9LahuFNbo9WagSqk3HwndREZDLFKIa7L5fLvcugrOZSGz699UWN8/RjSKghZJw8L8SmdP/Cuw9/rzsM5kxI+uiRgV4AbDBz58v/Wa8NkvAlTFdz7KHo2zQXYGtduKqtRQM6i8b0bjzhlFwOayKzg2WvxCsRewmxAWwn8Fdcm4QGQd1Qg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zQq7jPN4PSfooRiQESdK2XDAx4HJIEsTRtF8aJ8I+5I=;
 b=MYiHGf2lndQJlnqTKcZ8tHwLaDxYJJkrFtVNeOmHLboGchQE+Z5o0PLM6fQG81P77TAwaJK8lAWVVqJ2ifV0+HXe1/rQno0X/7MjSzMA0eZ5S9hijA5vDgWZwxbI35mCtEZuH12dpEs/p97R282+SJWr5fSNMeWreyQXBUFabWE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH] cirrus-ci: add myself as maintainer
Thread-Topic: [PATCH] cirrus-ci: add myself as maintainer
Thread-Index: AQHYWuYqOQefIDC6vUKpGhVltmZJKK0FaoKA
Date: Thu, 28 Apr 2022 14:56:36 +0000
Message-ID: <e140ff85-184a-e642-6850-3a14c9ff597f@citrix.com>
References: <20220428095549.91409-1-roger.pau@citrix.com>
In-Reply-To: <20220428095549.91409-1-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 819f18e9-6173-4d7e-cfb2-08da29274ad5
x-ms-traffictypediagnostic: BL0PR03MB4210:EE_
x-microsoft-antispam-prvs:
 <BL0PR03MB4210A0979B3D91D3F2850A4FBAFD9@BL0PR03MB4210.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 an/VvNGqkXf539i6AnkXVm4rqt/M0wz1M2poRfJojsq6KsIgeSeVhMLmIQu8cDAO5t/JW1UTfYyIMg6TA75v5Ddygg2cXc0UJZ2SRIIViYfnZyrF1Ijc4//1qzN/sLAIN+1mbp7VV+HV4Qb2xyOTMK5dguJR9Ubor2ix5FMzFnFKrqFobIaveWBeA1DpRBvFPTjFzLo/rC1yOCplBAezGRczOh74boRMag/HyiwHam3yaycrobWi5TpsPuGWhumUMc/pG7JHZB1oifuktWePxKLeS0SKuVkOLjaClH9D+CK43OUX7L+gBKxaHuFv7rRRGljA7gokAp9I57kc4lurcxeAsnQ3uIYhJKVD+rX/j6HM8OwDIfbzlrsfZAoRoeJ4g6sqUyvAKYYpLqc0u62iJBI07cP+1xZJfzn2gzRZ98izvP5lqxFnYe5uUX4Ie0HYl44fg6s7dKBamznI4JSi9U3OMEicO4neq6hVn7x+zJZQEbQxyPBtGcavxYO3tZ1EVD8hOyK1oCuhVeo1Bofh+0ZjEjakncTl7DPntNahPF7ygkVHOb98cOsrqWZxM+rh2Q3fBrOHNKKCY4ka7Toh1OJQABxc4poByW4Xh7AoA759qcZz+2fK4JtNOwbGQSAkdyVavXTTeC0GoEUpHoQc1lONt0LQnO/mPmHrRDwHlsssPtOvGmCMYENH38MQKrTQw1Kq8bOkrgBys8aaxCpsl6uAtH1SXCptCQPUs7i8BVQ8JI12XYWx3wZ8aZ8/QMrrI85muUKQLnUsB8oAsjjo0g==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(36756003)(186003)(2616005)(110136005)(31686004)(86362001)(6512007)(2906002)(53546011)(6506007)(82960400001)(4744005)(508600001)(31696002)(8936002)(5660300002)(6486002)(83380400001)(26005)(38100700002)(122000001)(316002)(54906003)(71200400001)(8676002)(66446008)(66476007)(64756008)(66556008)(91956017)(66946007)(76116006)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?b3NJZ2REdlNjdERqZlBtODhLYnhxNXdhNmZFQUk4ZWtlcGlyK1Ixam1oVWRq?=
 =?utf-8?B?cGhFQjNiMjNUaU5tV3o1YnBIZ0ZjNVlKa0lZVjZNTnljMnJ1QXljK3Zua3I0?=
 =?utf-8?B?SmhzOHBHNlIxWVNhSGt5dWJaeUJJSXpkdG0xbzRJcjgwVStRcFh2VFFENG1h?=
 =?utf-8?B?aTEwTEV5aGRHRHZEdFE4WXVFWU1ta3FZblBvQ3I2b3VYVi9mYzB0QVNYQzJD?=
 =?utf-8?B?My92V2IxNXJ3NGRWRVdPd0RHR2dQMmcxUG50TXNJS01Hb01wWjB1Ty9EcFov?=
 =?utf-8?B?VVpHM1ZNRVo2QnZvNE1EUmI3R2l5eDRmeWo4bG1KV1E2VDBnY2ZHZmlZWjZz?=
 =?utf-8?B?dWVSekhjZlVuZ0FzeFVWd3F2NnBCVWlVdEVuOWNIN2pQK1Q4ZWhpSjg5VjNG?=
 =?utf-8?B?ZkhrOENWb2lVandhQmZxZytCZTA4Z1FBdDdLWVgyR2wwSVFjL3VHR0VEWWZu?=
 =?utf-8?B?eFlBaGRYWmNnSVFvMXd4UDFZZ29hWm40Zzk2R0dyTnluaEZwUWlwTDEwN1hU?=
 =?utf-8?B?bTA1K0lYSDM3RVFlKzdqckhiZnZuaFg2Y2tJQzR0Wnpya2VHZE45L29OaExM?=
 =?utf-8?B?ZGpTVld1R3VZV0RxcklHK2hQM0pJTllEWS85di85ODFxVDlobDdyMUpzMGlD?=
 =?utf-8?B?S0JiTktPYThUaHlGMXlQU2FsWEFXRzdpR0hDcTA2L2FHbmR4YkdWd3p0MWVs?=
 =?utf-8?B?SE5lUzVoVlpFUG0xNGt3WkM4bzdEVFYxTjMxeEVTNTJJWlRDWXlGWFdWU3dO?=
 =?utf-8?B?aTVYM21tazh6Z3pMUjhkaEpqREZSbDd2WjFZTDJ1NlAvSlVIUHdzdVBGeTZF?=
 =?utf-8?B?ZmpiVCt1RkErNU9iV1VpZS9MRHBXYzJOdUpKazVPUUc4VlNlL1hFeDVBdFQy?=
 =?utf-8?B?RW5UQVpJU0xydDE3TmNJTThFR2pZWFFhTEVQaU4rWVVpQ1A5eEtJb3krTzNS?=
 =?utf-8?B?LzJmVkFBY2RldW1ab3ZMUHBydW9PK3c0T2NSSlF4OEMwQVJMbTd5Wmh3VU56?=
 =?utf-8?B?Mjd0M3FsN0lyYXROdldyWllMNE92WGtmRmxrOFp0VE5laEpuKzVhNHBGTmNE?=
 =?utf-8?B?NVlPOHZ1dVJ6UndXbW40ZUNoeE5adzFMYUhEZXcrK0s0UFRyMHoyZlVzaE9T?=
 =?utf-8?B?cUhkb281cXA1cjduQWxNSnBjeTQ3VVM2N2FjcC9VUG9IcVhzaGJSZDAwNUNi?=
 =?utf-8?B?R0JxZDA4V1ZDbkhVRkxjNDh0VTBhUTlHblpSUC9BMjFtMzFzTGZrUEY2M3RH?=
 =?utf-8?B?Zi90MTBKTWkyZ3RYTTlKakRHeUxXa0F4WHE1eStFWnAwT05wTDkwZDdnM2lP?=
 =?utf-8?B?RlFEYUl1TWUvTklSdk5mRmQvYXB4Z2RSK3Fsa1A4MGhwN1hGbzBVaFFkR1JQ?=
 =?utf-8?B?ZU1TVHljbjB6clR0MENaQ3h4Z0FiblliRVkxTnZ3RGRIYVFZRzc1VWJOd1d3?=
 =?utf-8?B?NkdFR3hSZCtLN3piNld1aEw0VVlNRWlZSUJxcmluT1R2RlZ4MXNpM2FuN0RE?=
 =?utf-8?B?K3FPNDNsSmlFR1dSanlvL2NjcEM3ODBmQWxidzlWQ1dMYlZuaXVXTGdyS1FO?=
 =?utf-8?B?OG9IblRrNUZFS2U1YXVPQ0dJM3NFbS9LZXlqc3lsUnlpbEt1SUdzcURtcE40?=
 =?utf-8?B?VlNaZFhrUjBDcWJhWHJjdWZERTNWajFBeEI0eWhtL0w2VEE1anUrVStuem1s?=
 =?utf-8?B?QXRlQ1czYzk3MXVMcU9JbXd3blJVd3gzWG13VUpTTzc2bDBnT054QVBsQURy?=
 =?utf-8?B?Qlk1V3NXZC9RNXVjdFcrTjNJMWkwUE8zVjdac0VFa3BsTFpPdUFwbTZDSDZi?=
 =?utf-8?B?TDVRWE9PV0dzaDJBaVZyMHJWWllWRk9pVFdMVU9vZTIxa0ovU3lveDhTMi8z?=
 =?utf-8?B?Zm1XYi8rRk9QQ2JTNjhnS3lGVW9OdDNjL2F2Q2hBTjZWR25UZVRNd2NTb2Vx?=
 =?utf-8?B?cWc3OUxyTmRHYXJaajVXM05MM001a1licnI3Q3pqUmpBQllMaHNYaGJYWXVN?=
 =?utf-8?B?dFZzYWRQNDl2em93cnVKYXJlNkVnMUQ1SUo3NXEyRm94TnJLeUpxV3dwS3Mz?=
 =?utf-8?B?KzYzcEZ5UEg3ekZMQWxoZU0rWDNhQ0ZML1FLYzVWRE9TYS9PQWg4TllQbTBa?=
 =?utf-8?B?T3E5Tlo4em1QWHhSOHNxcFFrUDVsVlljbzFRN1diWmhSZFgzcUdRRXorSy9W?=
 =?utf-8?B?bWI2clpIVXFxN0F6NExpczhiZmZ3RTBnZXdIMGlHeGh4dnpPWWFBYkJ6RFZX?=
 =?utf-8?B?L2crMC9hYkt6R2JJdDExQjJCVklFQ2JMajc0bkdzZmpIZHBlSW5PYkF1MW9H?=
 =?utf-8?B?N3N1aXVFaWQ2T3lLc2JLTGg0U1owQ0ROcURYbyt1azF4MW5KdHdBK3hEbC8v?=
 =?utf-8?Q?4fQS7go0G8godNC4=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7C466DC6DBE19E4E8A3929C637B0042B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 819f18e9-6173-4d7e-cfb2-08da29274ad5
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2022 14:56:36.2023
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /3HuWMjI9Nol6Rfe/k2jgwicGWSrRJN20WzYtWdJECHi6FxN4NiC3cmLTmQG5l0xQwlKREg5MN0y5wg3NyLErvmr7KHXvpBT8njRZNf/eZM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4210

T24gMjgvMDQvMjAyMiAxMDo1NSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBHaXZlbiB0aGUg
dGVzdGluZyBkb25lIGJ5IENpcnJ1cy1DSSBpcyBGcmVlQlNEIG9ubHkgaW50cm9kdWNlIGEgbmV3
DQo+IHNlY3Rpb24gaW4gdGhlIE1BSU5UQUlORVJTIGZpbGUgdG8gY292ZXIgaXQgYW5kIGFkZCBt
eXNlbGYgYXMgdGhlDQo+IG1haW50YWluZXIuDQo+DQo+IFJlcXVlc3RlZC1ieTogU3RlZmFubyBT
dGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dl
ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gLS0tDQo+IEZXSVcsIEkgd291
bGRuJ3QgbWluZCBpdCBiZWluZyBwYXJ0IG9mIHRoZSAiQ29udGludW91cyBJbnRlZ3JhdGlvbg0K
PiAoQ0kpIiBzZWN0aW9uLCBidXQgSSB1bmRlcnN0YW5kIG1haW50YWluZXJzIHRoZXJlIGNvdWxk
IHByZWZlciBhDQo+IHNlcGFyYXRlIHNlY3Rpb24gc2luY2UgdGhpcyBpcyBBVE0gRnJlZUJTRCBv
bmx5IHRlc3RpbmcuDQoNCkkgZG9uJ3QgdGhpbmsgd2UgaGF2ZSBlbm91Z2ggcmV2aWV3IGJhbmR3
aWR0aCB0byBzZXBhcmF0ZSB0aGluZ3MgbGlrZQ0KdGhpcy7CoCBQbGVudHkgb2YgY2hhbmdlcyB0
byBDSSBhcmUgZGVwZW5kZW5jeSB0d2Vha3Mgd2hpY2ggY292ZXIgYWxsIENJDQpmaWxlcyBpbiBv
bmUgZ28sIHNvIHdvdWxkbid0IGJlIGRpcmVjdGx5IHJlbGV2YW50IHRvIGJlaW5nIEZyZWVCU0Qu
wqANCkFsc28gc29tZSBDSSBjaGFuZ2VzIG5lZWQgc3VwZXJwb3dlcnMgaW4gb3RoZXIgc3lzdGVt
cy4NCg0KSSdkIGp1c3QgYWRkIHlvdXJzZWxmIHRvIHRoZSBnZW5lcmFsIHNlY3Rpb24uwqAgSXQn
cyBub3QgYXMgaWYgeW91J3JlIGFuDQp1bmtub3duIHBlcnNvbiB0byB0aGUgcHJvamVjdC4uLsKg
IChhbmQgdGJoLCBJIHNob3VsZCBiZSBpbiB0aGVpciB0b28uKQ0KDQpUYW5nZW50aWFsbHksIHdl
IHNob3VsZCBwcnVuZSB0aGUgZmluYWwgYml0cyBvZiBUcmF2aXMsIGFuZCBhZGQgLmdpdGh1Yi8u
DQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 14:58:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 14:58:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316618.535588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk5bU-0007m4-VL; Thu, 28 Apr 2022 14:58:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316618.535588; Thu, 28 Apr 2022 14:58:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk5bU-0007lx-SH; Thu, 28 Apr 2022 14:58:48 +0000
Received: by outflank-mailman (input) for mailman id 316618;
 Thu, 28 Apr 2022 14:58:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/G+0=VG=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nk5bT-0007lo-AO
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 14:58:47 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b28d46cf-c703-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 16:58:45 +0200 (CEST)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1651157914028481.97361180260066;
 Thu, 28 Apr 2022 07:58:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b28d46cf-c703-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; t=1651157918; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=kUN4qZwXHSk16GyzF5Wgr4Kox0LT88ZlRFQupoFuo11KibElIPNXrWrdgdOneFEVMD/sIWf1Fdhl3PQ7MXM+mW1Yvxz+KnJhrhMCrCC/2kJRoQ/VRgh4XXeBP9C8fxW2TSySQ/UupmsXn6wgXP3G5jk1RaN/Brvzjt8W9mqGXfM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1651157918; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=9hru1+aW0ch8vZJB9MIWv8TsZ6cxrZrBX0IuaDA7QPA=; 
	b=WEvB8tQBJx0IDUStREQdV24e1JlwSxWlI6z2T6V9+WWimR9uhQ5nuBJxFU2mNq2jJg9sWtbm2j9TbJJ17hhPWLe4IZR37/0OTH3ZVl+td16Y2zDQJ4rDkrtnFwptLgFEroGlzRMZxIwILZ7KFHJcc4/9eO8p4KKoflqg41Ez2aE=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651157918;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
	bh=9hru1+aW0ch8vZJB9MIWv8TsZ6cxrZrBX0IuaDA7QPA=;
	b=AAYFzJIreogAWUmINLKBxBM1HlUr3rTjxQ04QYvGZ60/DNGjUb0/xtwrHFKp6Pg6
	S/K5PZBqQx51CCXc4Hi2gZuFvuhrwHYFRTLkIf2rKtaRWkca+Yn/4etaVavT6qqeVjY
	NNMAX4khlvULfILmmMYpk/WssEWARWJY5jJ1tQx4=
Message-ID: <c872d5c4-9a6b-b955-556c-7974382fc4c4@apertussolutions.com>
Date: Thu, 28 Apr 2022 10:57:42 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 scott.davis@starlab.io, jandryuk@gmail.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Jan Beulich
 <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
 <20220422163458.30170-2-dpsmith@apertussolutions.com>
 <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
 <25e701d4-62ae-278d-b165-2201459c7cee@apertussolutions.com>
 <YmebdccTfa7wKc9U@Air-de-Roger>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote
 after setup
In-Reply-To: <YmebdccTfa7wKc9U@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 4/26/22 03:12, Roger Pau Monné wrote:
> On Mon, Apr 25, 2022 at 12:39:17PM -0400, Daniel P. Smith wrote:
>> On 4/25/22 05:44, Roger Pau Monné wrote:
>>> On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
>>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>>>> index d5d0792ed4..e71fa3f860 100644
>>>> --- a/xen/arch/arm/setup.c
>>>> +++ b/xen/arch/arm/setup.c
>>>> @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset,
>>>>      /* Hide UART from DOM0 if we're using it */
>>>>      serial_endboot();
>>>>  
>>>> +    if ( xsm_set_system_active() != 0)
>>>> +        panic("xsm: unable to set hypervisor to SYSTEM_ACTIVE privilege\n");
>>>> +
>>>>      system_state = SYS_STATE_active;
>>>>  
>>>>      for_each_domain( d )
>>>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
>>>> index 6f20e17892..a3ce288ef9 100644
>>>> --- a/xen/arch/x86/setup.c
>>>> +++ b/xen/arch/x86/setup.c
>>>> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
>>>>      void *va;
>>>>      unsigned long start, end;
>>>>  
>>>> +    if ( xsm_set_system_active() != 0)
>>>            ^ extra space.
>>>
>>> Since the function returns an error code you might as well add it to
>>> the panic message, or else just make the function return bool instead.
>>>
>>> Or just make the function void and panic in the handler itself (like
>>> in previous versions), as I don't think it's sensible to continue
>>> normal execution if xsm_set_system_active fails.
>>
>> After reflecting on it, I believe that was not the correct action. The
>> policy should handle setting/checking all access control state and fail
>> with an error of why and then allow the hypervisor logic decided what to
>> do with that failure. For the policies that are present today, yes it is
>> an immediate panic. Ultimately this will future proof the interface
>> should a future policy type be introduced with a more varied result that
>> could allow the hypervisor to continue to boot, for instance to a
>> limited and/or debug state.
> 
> That's all fine, but if you return an error code, please print it as
> part of the panic message.  The more information we can add in case of
> panic, the better.

Ack.

>>>> diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
>>>> index 8c044ef615..e6ffa948f7 100644
>>>> --- a/xen/xsm/dummy.c
>>>> +++ b/xen/xsm/dummy.c
>>>> @@ -14,6 +14,7 @@
>>>>  #include <xsm/dummy.h>
>>>>  
>>>>  static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
>>>> +    .set_system_active             = xsm_set_system_active,
>>>>      .security_domaininfo           = xsm_security_domaininfo,
>>>>      .domain_create                 = xsm_domain_create,
>>>>      .getdomaininfo                 = xsm_getdomaininfo,
>>>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
>>>> index 0bf63ffa84..8a62de2fd6 100644
>>>> --- a/xen/xsm/flask/hooks.c
>>>> +++ b/xen/xsm/flask/hooks.c
>>>> @@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>>>>      return 0;
>>>>  }
>>>>  
>>>> +static int cf_check flask_set_system_active(void)
>>>> +{
>>>> +    struct domain *d = current->domain;
>>>
>>> Nit: you should also add the assert for d->is_privileged, I don't see
>>> a reason for the xsm and flask functions to differ in that regard.
>>
>> This goes back to an issued I have raised before, is_privileged really
>> encompasses two properties of a domain. Whether the domain is filling
>> the special control domain role versus what accesses the domain has
>> based on the context under which is_control_domain() is called. For
>> instance the function init_domain_msr_policy() uses is_control_domain()
>> not to make an access control decision but configure behavior. Under
>> flask is_privileged no longer reflects the accesses a domain with it set
>> will have, thus whether it is cleared when flask is enabled is
>> irrelevant as far as flask is concerned. For the ASSERT, what matters is
>> that the label was set to xenboot_t on construction and that it was not
>> changed before reaching this point. Or in a short form, when under the
>> default policy the expected state is concerned with is_privilege while
>> for flask it is only the SID.
> 
> I certainly don't care that much, but you do set d->is_privileged =
> false in flask_set_system_active, hence it would seem logic to expect
> d->is_privileged == true also?

Yes, I did this just for consistency not because there is any
significance of is_privilege on the idle domain, in both contexts for
which is_privileged is used, when flask is the enforcing policy.

> If not for anything else, just to assert that the function is not
> called twice.

Under this patch flask_set_system_active() is effectively a no-op, so
calling it twice has no effect. In the next patch flask_set_system()
becomes a real check and there is an ASSERT on the SID as that is the
relevant context under flask and will ensure calling only once.

In the end I can add the ASSERT but it would be adding it for the sake
of adding it as it would not be protecting the hypervisor from moving
into an incorrect state.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 15:26:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 15:26:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316635.535607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk62U-0002r4-8Y; Thu, 28 Apr 2022 15:26:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316635.535607; Thu, 28 Apr 2022 15:26:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk62U-0002qx-5a; Thu, 28 Apr 2022 15:26:42 +0000
Received: by outflank-mailman (input) for mailman id 316635;
 Thu, 28 Apr 2022 15:26:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk62T-0002qn-7n; Thu, 28 Apr 2022 15:26:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk62T-0000hb-5B; Thu, 28 Apr 2022 15:26:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk62S-0006da-Pz; Thu, 28 Apr 2022 15:26:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk62S-0002Pj-PZ; Thu, 28 Apr 2022 15:26:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=n+xivQEsVI7NgmCvP7TxoRar/CSw7IRgY7AXGLeVf3w=; b=pbIyABuU2zLSorfZmhetc1XJ0/
	KZ0+xSELOFrRN9TFMDQ0Q+N9OkyuIVjhlNqINFMB3PRtWnHkfMo2HkufavxL7f1HHRUIgXQuLoFTN
	5G0N5cZPvcY8q7eb8Hq0e9QfqoBgxLCEXyy8TwJF7tPb8et7l52j72+wnWClgwJs3R+A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169798-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169798: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-examine:reboot:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl-thunderx:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    xen-unstable:test-amd64-i386-examine:xen-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=53b705d02cec03861044e673536586bd1b2443bd
X-Osstest-Versions-That:
    xen=3f5d61466345ed2213de2d7e391b6cd6d4b86015
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 15:26:40 +0000

flight 169798 xen-unstable real [real]
flight 169813 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169798/
http://logs.test-lab.xenproject.org/osstest/logs/169813/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 169775
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl-thunderx  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 169775

Tests which are failing intermittently (not blocking):
 test-amd64-i386-examine       6 xen-install         fail pass in 169813-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169775

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169775
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169775
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169775
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169775
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169775
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169775
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169775
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169775
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169775
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169775
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169775
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169775
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  53b705d02cec03861044e673536586bd1b2443bd
baseline version:
 xen                  3f5d61466345ed2213de2d7e391b6cd6d4b86015

Last test of basis   169775  2022-04-27 08:15:40 Z    1 days
Testing same since   169798  2022-04-27 22:39:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Tamas K Lengyel <tamas.lengyel@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      fail    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 53b705d02cec03861044e673536586bd1b2443bd
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Thu Mar 24 13:37:05 2022 +0000

    xen/arm64: io: Handle data abort due to cache maintenance instructions
    
    When the data abort is caused due to cache maintenance for an address,
    there are three scenarios:-
    
    1. Address belonging to a non emulated region - For this, Xen should
    set the corresponding bit in the translation table entry to valid and
    return to the guest to retry the instruction. This can happen sometimes
    as Xen need to set the translation table entry to invalid. (for eg
    'Break-Before-Make' sequence). Xen returns to the guest to retry the
    instruction.
    
    2. Address belongs to an emulated region - Xen should ignore the
    instruction (ie increment the PC) and return to the guest.
    
    3. Address is invalid - Xen should forward the data abort to the guest.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    [julien: Don't initialize p.size to 1 << info->dabt.size]
    Reviewed-by: Julien Grall <jgrall@amazon.com>

commit fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
Author: David Vrabel <dvrabel@amazon.co.uk>
Date:   Tue Apr 26 10:33:01 2022 +0200

    page_alloc: assert IRQs are enabled in heap alloc/free
    
    Heap pages can only be safely allocated and freed with interrupts
    enabled as they may require a TLB flush which may send IPIs (on x86).
    
    Normally spinlock debugging would catch calls from the incorrect
    context, but not from stop_machine_run() action functions as these are
    called with spin lock debugging disabled.
    
    Enhance the assertions in alloc_xenheap_pages() and
    alloc_domheap_pages() to check interrupts are enabled. For consistency
    the same asserts are used when freeing heap pages.
    
    As an exception, when only 1 PCPU is online, allocations are permitted
    with interrupts disabled as any TLB flushes would be local only. This
    is necessary during early boot.
    
    Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit fbd2445558beff90eb9607308f0845b18a7a2b5a
Author: Julien Grall <jgrall@amazon.com>
Date:   Tue Apr 26 21:06:29 2022 +0100

    xen/arm: alternative: Don't call vmap() within stop_machine_run()
    
    Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap
    alloc/free" extended the checks in the buddy allocator to catch
    any use of the helpers from context with interrupts disabled.
    
    Unfortunately, the rule is not followed in the alternative code and
    this will result to crash at boot with debug enabled:
    
    (XEN) Xen call trace:
    (XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
    (XEN)    [<00000000>] 00000000 (LR)
    (XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
    (XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
    (XEN)    [<00236864>] __vmap+0x400/0x4a4
    (XEN)    [<0026aee8>] arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
    (XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
    (XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
    (XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
    (XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c
    
    The interrupts will be disabled by the state machine in stop_machine_run(),
    hence why the ASSERT is hit.
    
    For now the patch extending the checks has been reverted, but it would
    be good to re-introduce it (allocation with interrupts disabled is not
    desirable).
    
    So move the re-mapping of Xen to the caller of stop_machine_run().
    
    Signed-off-by: Julien Grall <jgrall@amazon.com>
    Cc: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit 163071b1800304c962756789b4ef0ddb978059ba
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Apr 27 09:15:03 2022 +0200

    EFI: don't mistakenly delete a file we never installed
    
    Just like for "install", make dealing with xen.efi on the EFI partition
    dependent upon mount point and vendor directory being known.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

commit 0f4fd6b6d805c89d19843c7ad70adc772a7d1203
Author: Jason Andryuk <jandryuk@gmail.com>
Date:   Wed Apr 27 09:14:30 2022 +0200

    libxl: retry QMP PCI device_add
    
    PCI device assignment to an HVM with stubdom is potentially racy.  First
    the PCI device is assigned to the stubdom via the PV PCI protocol.  Then
    QEMU is sent a QMP command to attach the PCI device to QEMU running
    within the stubdom.  However, the sysfs entries within the stubdom may
    not have appeared by the time QEMU receives the device_add command
    resulting in errors like:
    
    libxl_qmp.c:1838:qmp_ev_parse_error_messages:Domain 10:Could not open '/sys/bus/pci/devices/0000:00:1f.3/config': No such file or directory
    
    This patch retries the device assignment up to 10 times with a 1 second
    delay between.  That roughly matches the overall hotplug timeout for
    pci_add_timeout.  pci_add_timeout's initialization is moved to
    do_pci_add since retries call into pci_add_qmp_device_add again.
    
    The qmp_ev_parse_error_messages error is still printed since it happens
    at a lower level than the pci code controlling the retries.  With that,
    the "Retrying PCI add %d" message is also printed at ERROR level to
    clarify what is happening.
    
    Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
    Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

commit 010bc50adaf58c78db4ad1329b0130d96e13f8e2
Author: Tamas K Lengyel <tamas.lengyel@intel.com>
Date:   Wed Apr 27 09:13:39 2022 +0200

    x86/vmx: add hvm functions to get/set non-register state
    
    During VM forking and resetting a failed vmentry has been observed due
    to the guest non-register state going out-of-sync with the guest register
    state. For example, a VM fork reset right after a STI instruction can trigger
    the failed entry. This is due to the guest non-register state not being saved
    from the parent VM, thus the reset operation only copies the register state.
    
    Fix this by adding a new pair of hvm functions to get/set the guest
    non-register state so that the overall vCPU state remains in sync.
    
    Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
    Reviewed-by: Kevin Tian <kevin.tian@intel.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 15:30:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 15:30:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316644.535618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk65o-0004DW-Oi; Thu, 28 Apr 2022 15:30:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316644.535618; Thu, 28 Apr 2022 15:30:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk65o-0004DP-Le; Thu, 28 Apr 2022 15:30:08 +0000
Received: by outflank-mailman (input) for mailman id 316644;
 Thu, 28 Apr 2022 15:30:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk65n-00048u-Hv; Thu, 28 Apr 2022 15:30:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk65n-0000lu-FS; Thu, 28 Apr 2022 15:30:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk65m-0006he-RW; Thu, 28 Apr 2022 15:30:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk65m-0003yW-R5; Thu, 28 Apr 2022 15:30:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t7xgqtBgyBiCBpt8qMuMuypQGYbq+2DtSbZOKi8LyWc=; b=eBLtSBqXXocirnyAplpga4Hl/N
	azBG8g27YXC3KmDZftacWF+l0I95JTwTriFk4mO1iELun/wkLoLF9iQYG/X6/R9tOX7GXP1yzX2de
	V1IG1vjXACrf48xN7z3TRsONinmL742yrhq5z1TnyeTlKfUuhPeq8STGRVe2mgQHS0zw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169816-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169816: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 15:30:06 +0000

flight 169816 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169816/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  680 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 15:34:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 15:34:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316652.535629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk69f-0004xZ-Eb; Thu, 28 Apr 2022 15:34:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316652.535629; Thu, 28 Apr 2022 15:34:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk69f-0004xS-9q; Thu, 28 Apr 2022 15:34:07 +0000
Received: by outflank-mailman (input) for mailman id 316652;
 Thu, 28 Apr 2022 15:34:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk69e-0004xI-Cm; Thu, 28 Apr 2022 15:34:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk69e-0000qQ-BS; Thu, 28 Apr 2022 15:34:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk69e-0006nF-0Q; Thu, 28 Apr 2022 15:34:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk69e-0004Ul-00; Thu, 28 Apr 2022 15:34:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xFuxd+txDThp6hr31UoPgEM/14hkbCirZpvaipyi8l4=; b=zmviVfWTlL/HiUYi0w5ZRKbgB3
	DurBSU1uJH9HM2uAXVx+fRsfTpVzGUqal27j4KZ6/TSvYaBjPmdi7ETIWbmewbtrDz9OGA3wmUN7M
	NQAK0p/UzJ5+P3M1IqT2G1z2wS2z81Z936R+fS2b4O5uXQNf2hW6hxFxb2LyngGU9GSQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169807-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169807: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2c992810854a15b41be920519ce83a4a328d5168
X-Osstest-Versions-That:
    xen=da28439ba55b8a571032b3358af567cff749f612
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 15:34:06 +0000

flight 169807 xen-unstable-smoke real [real]
flight 169817 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169807/
http://logs.test-lab.xenproject.org/osstest/logs/169817/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 169800

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2c992810854a15b41be920519ce83a4a328d5168
baseline version:
 xen                  da28439ba55b8a571032b3358af567cff749f612

Last test of basis   169800  2022-04-27 23:01:43 Z    0 days
Testing same since   169807  2022-04-28 09:01:41 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 2c992810854a15b41be920519ce83a4a328d5168
Author: Jan Beulich <jbeulich@suse.com>
Date:   Thu Apr 28 10:00:49 2022 +0200

    x86+libxl: correct p2m (shadow) memory pool size calculation
    
    The reference "to shadow the resident processes" is applicable to
    domains (potentially) running in shadow mode only. Adjust the
    calculations accordingly. This, however, requires further parameters.
    Since the original function is deprecated anyway, and since it can't be
    changed (for being part of a stable ABI), introduce a new (internal
    only) function, with the deprecated one simply becoming a wrapper.
    
    In dom0_paging_pages() also take the opportunity and stop open-coding
    DIV_ROUND_UP().
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

commit 9c432b876bf518866d431bda73f2be1250f688eb
Author: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Date:   Thu Apr 28 10:00:18 2022 +0200

    x86/mwait-idle: add SPR support
    
    Add Sapphire Rapids Xeon support.
    
    Up until very recently, the C1 and C1E C-states were independent, but this
    has changed in some new chips, including Sapphire Rapids Xeon (SPR). In these
    chips the C1 and C1E states cannot be enabled at the same time. The "C1E
    promotion" bit in 'MSR_IA32_POWER_CTL' also has its semantics changed a bit.
    
    Here are the C1, C1E, and "C1E promotion" bit rules on Xeons before SPR.
    
    1. If C1E promotion bit is disabled.
       a. C1  requests end up with C1  C-state.
       b. C1E requests end up with C1E C-state.
    2. If C1E promotion bit is enabled.
       a. C1  requests end up with C1E C-state.
       b. C1E requests end up with C1E C-state.
    
    Here are the C1, C1E, and "C1E promotion" bit rules on Sapphire Rapids Xeon.
    1. If C1E promotion bit is disabled.
       a. C1  requests end up with C1 C-state.
       b. C1E requests end up with C1 C-state.
    2. If C1E promotion bit is enabled.
       a. C1  requests end up with C1E C-state.
       b. C1E requests end up with C1E C-state.
    
    Before SPR Xeon, the 'intel_idle' driver was disabling C1E promotion and was
    exposing C1 and C1E as independent C-states. But on SPR, C1 and C1E cannot be
    enabled at the same time.
    
    This patch adds both C1 and C1E states. However, C1E is marked as with the
    "CPUIDLE_FLAG_UNUSABLE" flag, which means that in won't be registered by
    default. The C1E promotion bit will be cleared, which means that by default
    only C1 and C6 will be registered on SPR.
    
    The next patch will add an option for enabling C1E and disabling C1 on SPR.
    
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9edf3c0ffef0
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>

commit 3f6aef8a7a371ce35e83c4a85022ff0e6295d91a
Author: Jan Beulich <jbeulich@suse.com>
Date:   Thu Apr 28 09:59:14 2022 +0200

    x86/mwait-idle: switch to asm/intel-family.h naming
    
    This brings us (back) closer to the original Linux source.
    
    While touching mwait_idle_state_table_update() also drop a stray leading
    blank.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>

commit 6cf1398ba9e3f8ea64d58930288a6dffbdb7c207
Author: Juergen Gross <jgross@suse.com>
Date:   Thu Apr 28 09:58:42 2022 +0200

    xen/public: add new macro to ring.h
    
    For the initialization of a ring page by the frontend two macros are
    available in ring.h: SHARED_RING_INIT() and FRONT_RING_INIT().
    
    All known users use always both of them in direct sequence.
    
    Add another macro XEN_FRONT_RING_INIT() combining the two macros.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 15:53:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 15:53:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316664.535646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk6SM-0007LL-30; Thu, 28 Apr 2022 15:53:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316664.535646; Thu, 28 Apr 2022 15:53:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk6SL-0007LE-Vi; Thu, 28 Apr 2022 15:53:25 +0000
Received: by outflank-mailman (input) for mailman id 316664;
 Thu, 28 Apr 2022 15:53:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nk6SK-0007L8-RR
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 15:53:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 55429a5c-c70b-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 17:53:23 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-HEeXGrkwO9S8Ud3w0c6Hxg-2; Thu, 28 Apr 2022 17:53:22 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB6135.eurprd04.prod.outlook.com (2603:10a6:20b:bf::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 15:53:19 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 15:53:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55429a5c-c70b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651161203;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Ld1CduOnWj6XqXB/pFD5zwrf4+DheELc0rJWhZpFBgQ=;
	b=Hv46Ao3VVqxbkC6jvtkjzFykCSdl52wJQVThFF6dvAk8JAnZOlaiX1b1rSME2vSHEOVSxs
	tqdWYRDxwN4bT06dwj3cX+B8H2rxnkjJ0BXVdVn5uJtOO1aqMghdv9C4MBztd33LolV6VW
	fQ1D2axW/wOY9fO+O6WrOCTuymVocUc=
X-MC-Unique: HEeXGrkwO9S8Ud3w0c6Hxg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YhllZctf+heGjrAj0aK1pnUN04a1iNzGbYBmMHnDS8+ekKIpUxvXbjrXgVESvTMbS9hxygV3CRmI3HvVG210VjHwfyQogkmNYbp0BQ8oINAH3vqt4XcnBDROqAyqfUdpcTZJ9oXldEq3ImvB9QFxEHCz/N3wc9EMWITlEr32f+VwPOiJxEH2CZ3hBWJ5+A82Uy8K4wqBRQOQbl64tHPahTlN1xXhQ6wzEaf4602rAdLbMLA+9Bs7H0tfO0MoTCEne3gpOeIw5fBTgIAcL+9k9d4I3n77S+j2WDe3BIWY50EBfi8nWWet7/l5K6zuLO3HjwnQuZq5EzB2JdTWVPQ+mA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ld1CduOnWj6XqXB/pFD5zwrf4+DheELc0rJWhZpFBgQ=;
 b=jBP8zeR9MRXysRpQwJIBukw5ctpczJh/wF02N0qsK65nPm0TR3ijsG+53Mwsf6pOiWxrIRY21/nXca2L1OfENAnzrhgvZlnqV7b5EH+jsCMcpntSYB96j+p1rIYNcHawadBm52+NoTWL2DP4VF0JOacMgk2P3v9uN6Rfb+u0aBL2lzoFGGxTXXLCv1tuwHq89f0k4EQ61HZpXpZn/lT4MlCsHoA8M5K72SS7vwkLF3Y2ke3mIz6Q9cYReodsNVlTyzWwGPeMrEBoRNqEqTE2CEP9Zqvbbqt3YiHEGVeQ695hPkDyrMPIQA5vwdcu7/BJ5hZw+ztvjNjt9XAgj0yZSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
Date: Thu, 28 Apr 2022 17:53:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Juergen Gross <jgross@suse.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: x86/PV: (lack of) MTRR exposure
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0204.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::29) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 512658aa-9ee7-4f54-fee4-08da292f36f9
X-MS-TrafficTypeDiagnostic: AM6PR04MB6135:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB61353D0E8F770CA47F46E48EB3FD9@AM6PR04MB6135.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qyNWVVYiUaKCU4LGOZJjBrNYdSRPWnj7PKb6PSOdzoKxGTcYlek36GzpXQEBc48l5StZpKG4WeYSTb5Ox6OTbswvCDAVagEG69RLCF/RpBTa40pbqOkeHSP+rtfAig3F3JA1bmIpJQ9She81Z7wHIHusowH0PKLjIIg9sU7Tki5Ejt2I2xXzxMdwAM87RokBw6ah9c2N4Wfjsgc7QNZmIe7kVIdMhB3R37HD+DY90glXR9Ndv8ZCiW4IBF6nJJoTYRCviKjhPaffC5SfhbxHIOvR5E0mmFTYY3JM4MefrTJZAEIMkJIpFj4NNWAapRuMJsTbmAX6W+Q1YVN8i1uCbWPxqW4fz2JG0JjCePbpkCIXZHnUHrnG+H9udEarF6Hfc5vGkM5lGmgG5zKZVvKkfgoDKxBCPJv2Szxda+bTq3uqrpK6oOEQMt1W0c0Od9h9a6ZDNvVBeqJRHKBG91FgieFHhp3aMiRuXJrigcfGsXfCHI0iOix1npTpX5ug7mPe3xR1WYtj3JVCW437G5yrwlqyVkyCUW6uXCJw5p3yAhIMstz4MGkolDB8WxKS+BcxLrqtxI+tEFuYTtQo6vCX3txlhdjo40PFbKjFpgaMFjphl9FLAMMaWEgFnEz8XGMzM+VRCcXaaz8Aqv2cML9TgS2SwgdSBNbr8gYiehHvCngKt5jqcv4vum/yysqg80mR4QxoLGNtNZdyZClq/BmpugfNFpyB0edBVFp/TxtzQnJWUJYDWZdORSTtID2fPcBMzLbigoQZaFq64OF3X0wHppKsCQp2AFoiZ1jNHpqP1XWsKzoBSJ5sasbS/2wWB7UY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(36756003)(66946007)(5660300002)(316002)(66476007)(186003)(66556008)(83380400001)(8676002)(4326008)(6916009)(8936002)(54906003)(31686004)(86362001)(2616005)(6486002)(966005)(31696002)(508600001)(38100700002)(26005)(6512007)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MU91ckJoMEhYU3hLQTNmM1p1bnhRQW93OG5VM0Q2L0lHNitoejRQOHQrSGNX?=
 =?utf-8?B?ZHJCcE5OS3lrb2JmQjhDaWVjdGRhb1ZobTBkSnRuK2xtTlZnU3BGYUsxMnUv?=
 =?utf-8?B?RjJJNjZPeExUemdNZmZTY2tsMGR4dDUyUE9zRFZqK0Zob1FudXd0MVRBL3J6?=
 =?utf-8?B?VEJzc0JpQzVqb3B2cTNtNkl6aGZIbUJzYkN2MkxWUEdRM2x0NlQzT01QVjNB?=
 =?utf-8?B?RTRpeVM1OXFObzM1SDN0b3l5d0pyb1RIMVovK3dwYUkrYko0UUxRenh1MjR2?=
 =?utf-8?B?U01iRVBXMzNNSU5xeVkvYWtxM1k2N3N3eWZXTERZcTcwVEI3eklkdnZMcVYx?=
 =?utf-8?B?dEZrNEdZQWhqVzVpaW5TSDNRaE85aWZYRkw0Zm9COVhLd0NrVllYRmlVYm4z?=
 =?utf-8?B?dlhqR0VUMFp6THZVMTZjTmxUT25BOWJZLytWd1VxRE14K2RhS3pYajY5ZTVV?=
 =?utf-8?B?TFdKWU1Ic2pXNmlBV1p3bFVnSDVrWDUrZEJjV2F5T1R0bGJlckcxVzZRVDJ0?=
 =?utf-8?B?R0x6QVphUmtieGg5MVNhL3VHQkNSMUJwMkRMUlgzUythWHdsYlU4SU53QVRY?=
 =?utf-8?B?RlhUb2NZUjRySVNMRFVjM3N3VDcySGJqZkxHOERKTlhUTjdRTEpGVUF2dDNV?=
 =?utf-8?B?VkZkb1J5dlZDRUZrN0xZelEwaFM1UnBIUXVtSzNhNENTVFZiY0R2dkJBVGtq?=
 =?utf-8?B?N29PYUlER00yMUFkNXAwanF0c2RnZUNYRVlMYko4d2oyWk1WNGpmNWxLYUhm?=
 =?utf-8?B?anA1Mk5BVnBubnN5VmdIZkxxN1JmN21Fd3BlS01tQnBPQ3ExVFN6VmYwdGox?=
 =?utf-8?B?c2ZYZmFPdnRZWFg5b0txTDNkNWRYYllkUC9LdE1iem9XNUtyKzR2Tk5GRk1G?=
 =?utf-8?B?SDJ4djZaV0hHaG85TUR0TjdDMEtWQlRsL3M2dlpoeSs2Z0Jid21GTC9WaEI5?=
 =?utf-8?B?dFBKd0w2Yitza0JHa3FPOVYveHdvOU9xWjhBNWl5TXh4TFFvbGhBcFJKR1VG?=
 =?utf-8?B?M2VmeUxCUTBzcTgzcHlVY1dscUdhaFRMOWU5U3M0bkpuTzQ0YTJFRVRUOEgv?=
 =?utf-8?B?Y0psK3hTclYvYkR3YUpNWVdZS1JLbnQ4eEE4VytXTlJybHcrMDVpbDVKNXM3?=
 =?utf-8?B?MHVBaS9nL1VxT0gxMDZVa0hEdWFnd3dDWmRwc2VWZDF2dWlYdXNjOGUwUWZn?=
 =?utf-8?B?Skh3NVYycXVSNm9lUUFCZmJic05OU3lRMkpKd1dDYW9UR0VjYjhVM3k1bWkx?=
 =?utf-8?B?Wnd6NzhjelNKV1RtaDlQNVJhbjNWUGpRTUFpbGVjZHVSZDRHMnFmayswUEpQ?=
 =?utf-8?B?YTA2MGFpS2JEdnlZL09ObHZQVXpWNjhxZTdUWVljMjNhUkRFOGlOcjdlaUJs?=
 =?utf-8?B?RllNNUdYMjVBUVFLSHVLSWxzUnQrMmxzbUxmbEx5OXdJV0lRN3A5Sk0rSjIx?=
 =?utf-8?B?MkZSVG9ZUGwzMjhVQmhhVFVFUU5lb0EvTUNnYXVHUDhJNE5CMS9MTU1jSGR2?=
 =?utf-8?B?RjFKczBEQ0MzaDhIZXRuTmFlckg4NzJPbE90U2t3bU9JMCtiQjlYSVNIVXVm?=
 =?utf-8?B?czBtZWk3RHJlL0ZaeVI4L0NhWmVIYlVsYzBpc0tNZG9WLzU1NmljMGJMcWRY?=
 =?utf-8?B?U29xdXJVNjRnQVB6OFM4ZUtKVTFub2NXUGV0eGx2Z0JndGtkTmJxMEV6TjZ4?=
 =?utf-8?B?VnZ2TkxlR3BTZVNjMUFzZWdPSWJHMDB6RVRDUjdGemdEQ3JLQVhNU2EvSkV1?=
 =?utf-8?B?ZVNqYlVta3pYK0pxMHFxNXZhd0tyRzkxandqMTVyZlUxN0JBYnlNYlpLRE5C?=
 =?utf-8?B?OTViZUg2WE9DSGk0aWJNUnlWVE03dkFIR0g0TVQ3SWhsTjM0NFRnU3lZVGxp?=
 =?utf-8?B?MWNyL3lESWoySjdoeHNyL1VHcmNhQTBJNktkcXE3UUpRVDJCdFlVK0FnMlNj?=
 =?utf-8?B?SWZESU5UdlkvQjAvOVIwK0pzbFBXQ3daZzE3aklzMFczNHBiY3dlZnVpTEJI?=
 =?utf-8?B?a0RJdDdOTjQ0QSs4V2NMVTcvcUthMGc5RTdVQ3MrRDRKU0xOWFZKTksrZjBj?=
 =?utf-8?B?RVdRUTc4djZOVXZUZkJEL1MvSVV4aE9NZm1QbEpKL0d0V0RSOHV5R2dEQ0wx?=
 =?utf-8?B?S0wvYXFVeDQzUEE2R3FaR3JHaDgzU1lyaXZvaVduOThtMFc3dnk1SmZWZ0hr?=
 =?utf-8?B?QmNaMjlLNzg2V2cyYm4vVVg3bzVCUndyZG85UnRTM1UwYTV2dzRlaVBLKyt3?=
 =?utf-8?B?NDBzVTNUdVBtTVhDVjIvUm9lMldkNjdyZ2QzY2tvTHhQZnNnWDVWZ0I0bGNF?=
 =?utf-8?B?WTdxcnFMSjFLKzhJSVZydndmUnlyVlNtRGNnT041dld4UXBGU0NDdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 512658aa-9ee7-4f54-fee4-08da292f36f9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 15:53:18.9995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h7o7ZO8TK0UCzE+4XFLjvPmB/GQnEPNfG2j4yaNRPPaH+YUj/rbguPymsF2IhWrB7tJ/uGp3d1KWgkgyf23Esw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6135

Hello,

in the course of analyzing the i915 driver causing boot to fail in
Linux 5.18 I found that Linux, for all the years, has been running
in PV mode as if PAT was (mostly) disabled. This is a result of
them tying PAT initialization to MTRR initialization, while we
offer PAT but not MTRR in CPUID output. This was different before
our moving to CPU featuresets, and as such one could view this
behavior as a regression from that change.

The first question here is whether not exposing MTRR as a feature
was really intended, in particular also for PV Dom0. The XenoLinux
kernel and its forward ports did make use of XENPF_*_memtype to
deal with MTRRs. That's functionality which (maybe for a good
reason) never made it into the pvops kernel. Note that PVH Dom0
does have access to the original settings, as the host values are
used as initial state there.

The next question would be how we could go about improving the
situation. For the particular issue in 5.18 I've found a relatively
simple solution [1] (which also looks to help graphics performance
on other systems, according to my initial observations with using
the change), albeit its simplicity likely means it either is wrong
in some way, or might not be liked for looking hacky and/or abusive.
We can't, for example, simply turn on the MTRR bit in CPUID, as that
would implicitly lead to the kernel trying to write the PAT MSR (if,
see below, it didn't itself zap the bit). We also can't simply
ignore PAT MSR writes, as the kernel won't check whether writes
actually took effect. (All of that did work on top of old Xen
apparently only because xen_init_capabilities() itself also forces
the MTRR feature to off.)

Jan

[1] https://lists.xen.org/archives/html/xen-devel/2022-04/msg02392.html



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 16:12:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 16:12:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316687.535667 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk6kO-0001wN-QV; Thu, 28 Apr 2022 16:12:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316687.535667; Thu, 28 Apr 2022 16:12:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk6kO-0001wG-Mc; Thu, 28 Apr 2022 16:12:04 +0000
Received: by outflank-mailman (input) for mailman id 316687;
 Thu, 28 Apr 2022 16:12:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h8bM=VG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nk6kN-0001wA-68
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 16:12:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ec4a1bd7-c70d-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 18:11:55 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-nHhje7pSOlCQmclBwrVyVg-1; Thu, 28 Apr 2022 18:12:00 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR04MB4753.eurprd04.prod.outlook.com (2603:10a6:208:c2::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr
 2022 16:11:58 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 16:11:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec4a1bd7-c70d-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651162321;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1pWQ8sl50bGczjzwPUI2eQhwcUqWGZpu0wy1+0ahT7g=;
	b=hpW/KlzwpDsN9vZpDbd3cy3NTUQc9/7lSUgutKJ1w6VKZdncgySsm/qCCYRzYkMei0K25g
	I/La8aRE5xYkWleaxyrSkrWat2F03e436ai+crUfslsc6gobAr8yZliZp/MNNKpB6AbQjn
	SqyDIsEBZnAVFCbKDGR3fn2ttkewQ8Y=
X-MC-Unique: nHhje7pSOlCQmclBwrVyVg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N85UBAU0JgoEh3IDXl2koyOVvqJcMVysMsiRL9iM6oGfZGZX9W+TktVViiSCs7BozrAbHNX1XyikJWVskuuo5FpPJLMRvqftZ80jEaia+Oe1zoEJcW1ruOOpjgsLNVluleNx6+xddWt9X1JMoVWChS+GysgYK+yDth46WOlbUDaSuCAzJX8eustAbh2TfO9P6jkN67BLOxWY9uGBPE4OrcddX0AWCyAT1w21btqxjQeZgMT7eYZ5xtNDwea/7HSAMTpWQg05StEUa8MJ2TgTbqtiWH9aK5H/shbW0HIn3VPM3GYg22MAFrOlRaMw0tHvHrvP7DDjhKTOC+sU/6th2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WaPDVnSXappEMMzZTDMOrxrg6wKA8NC0+9iz9XAOuzc=;
 b=cfqGBAOwmcEYyRby48+jp6RPw1f8rt9a0Bmf7Qt/h3Qyup/FRAwAbMKGoWQt212Gz8x22SjjpTmfBdkqT+w0EXr7sc9uPWAMR9334fCqS9L6bq3QNWqfn1fUQbHrwEogV6JtEoSAus2ZMAD4Hu0SoIiyULK653RQ7z0FCqhnYa6e0QVm8wtx1Jco43Lqb0BvG1SFS78T6JKn1nOPsPgquQn6p5poSFgM3GMv1+XarL8jpsoz5GdiFBLBxgcNblIsz4OUC9/Buv8Q5xgOOWeJZIFk3gFumhA9PTnwLjgM9LRoNH/AeW6z1crvtj4OkFOHHncbqsd4Pe+AKX/ZzjpeNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <228903dd-0878-ae24-33a7-228059c290ef@suse.com>
Date: Thu, 28 Apr 2022 18:11:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 on top of SPEC_CTRL
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220427104718.81342-1-roger.pau@citrix.com>
 <20220427104718.81342-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427104718.81342-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0105.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::46) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2bf4cc1b-65db-451c-6a0e-08da2931d252
X-MS-TrafficTypeDiagnostic: AM0PR04MB4753:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4753A3C8D4460E1F10630157B3FD9@AM0PR04MB4753.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tBzqd/Ldqcbwu3EymzwMCBAVIBb89vdnHF1jvn9j16X+zdn6YysqZydu/rkYfCZptDn2N/I0A3po3jsOvRDUAJht5ToZts9De8otb37/zmr7tJF7JC7UHbLwQYWCATk+XnX/mqETt2y1i2vxGAs5qQxGL6lYwKj4HoDQm30anI69ng8tDvZ6YfBoXfTLOG2UjF4zgXB5S88AeUV6aNtXVg+j1urOG06QQoS4o7kYyZ7etC1vXVCTLfEpF2Y8qNn8swK6LMvrJWEYPQyCGPQoUWgLduKiYTZnswNjIxojgMTT6cVnUB0GSrjhYYPJlMKZGtgRp36+MVvk0E64GV6vUYju7Gg+1dWRvXvmgGLv/2Fz/0fpot2O3926++QM1DcEHPQgBUqopPozO1+yINvmPFO00Rht2ZStA7Y7m67Cawx3gGViI7k8Xla3/XWd1KN70zDsmH+AcGjaaT12p4Y20vlZe5p9gSquPUTVXnVajNIoEG9lz0j2vm8+1Ufe6QipM543KcL8Ds5E4oIGm2c+NJDJ6kKIOJm+uTLo/gu/wpdvHE4QTnfvz6IfQHBRDhrvAWPEqXvFMNpzNe0pAjpjqVhLaf64LCrFb3wTZzEai5GwaibV+/yyAFlnd3q1vDN2iXxRns8uUeqMTXbPpecPwjhwxzNkgOlXkBWd96kCGOIwnrh6ylwScJgoengDvnA/rxBVhaL9yhV4vnhg26n01CUsHVchWq7ej237UcxxEug=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(8676002)(83380400001)(66946007)(8936002)(54906003)(5660300002)(66556008)(66476007)(6916009)(316002)(4326008)(508600001)(6486002)(31686004)(6506007)(4744005)(186003)(2616005)(2906002)(53546011)(38100700002)(6512007)(26005)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ocwkW3kKCzNE2e5qWkKc+gVy8iF0OVEynMtMLYg/1vLmTNSQ3tK0hcpC/qLn?=
 =?us-ascii?Q?IZTdjUA66Cw/m6VCeJy6m96MR13PHV34c32SX46rJZSBdOKjCXHJ7UcC0xuz?=
 =?us-ascii?Q?z/bWkulq0UzDsib1DlG/fANKo/IF69SdaRyi2gf5CLy9H2BoMIa0utu0Dwt1?=
 =?us-ascii?Q?U8VPQaTJfTPj4nGLBLyMNdzKm8wlFlvGg4+01bw6jm5E2DTqQ2bgxr5q84a6?=
 =?us-ascii?Q?ZY5eAKZhfFPU4ZJLeZW0fhttn+ju/kwmfzElg0hZfpDFCHRhjZJu30mPqih7?=
 =?us-ascii?Q?AG4Le+c3QBZtlcs10stbXG2PaH9DRuYTXdHFyQAuuw1RVzMOqBDgFMMLbX98?=
 =?us-ascii?Q?mTgH2UY7IbOCL7GoCDyf6oFHORv0A58owPsc6ZQB7SzH3GTJno+6d1Hxfe3B?=
 =?us-ascii?Q?0J+SuM+GoVJwx5tzr8PRjxU4UthIXc6WW3MjPdjP3AiHrGtPsErZpSG9oj8o?=
 =?us-ascii?Q?7FKOcFyYxp0ta8WfhPui9VdDsuQLD026VP7+o/mF/3PzoN7HYnPdfjKM5nPB?=
 =?us-ascii?Q?cKT0GQKoXaF8wEk4foYIzw4BCLO2DZuupQKWqRn6nAJRk5JEblIvvgbm7Shf?=
 =?us-ascii?Q?itgOOJFzqfLnPFhxNzepDMUzvlTephD5Q1W38mevTukihXDV3klNB0IZHMrg?=
 =?us-ascii?Q?LsiemoEo7ukTrc8+zCBms/3M7wbwBa6xTCJ4KWXaRZ1QB7cheEPKYJmZIsP0?=
 =?us-ascii?Q?/GjiSS91UeKeEJPXzwXtlCaE4StgJdZ1HLDQO6QjQYEJkTYcOHwqTKcu4YGT?=
 =?us-ascii?Q?v3tB8qlupu0vDwq8RWIkk7txSOT9MKhf+n8aK9eAtYE1p04HaPe+A/P8V243?=
 =?us-ascii?Q?9CmK6pOkzhbeB/K+xc8kFxWpHyu2OnpF7aNe5QtxhXU2ChyNDRQHiIFTzvSx?=
 =?us-ascii?Q?JqCQMWhrib5CnnZi8YFghzyypOERTktqFOXh8qu3OxRAtOLTSQKVPXmuA1al?=
 =?us-ascii?Q?uokDA+7Hfz6sp2dT9GkUWPr5u+FzBo2cGXb5Sjpn60qZo85RzkO7b7TUvAaU?=
 =?us-ascii?Q?IhQQaJ8w+wBe+Cgzs5Atu3Ne6XjvjCHMUaki2MsM/ge4Wss0A2EkKnqwHw9Q?=
 =?us-ascii?Q?yaLKuPMzaOiYTHgcxFIiEpWYOnI/MmgMRXodPS49zefvvG8VrA5XqSukNzmW?=
 =?us-ascii?Q?SGotsOh5uvoOp0frosFZkIbKeOG5y4lBTqZGcRn2RApnk6O4onrRdoqTJxu4?=
 =?us-ascii?Q?75rKBL9GE+afTrwfgLDj/gcNM5lrGsLQGN3ry1g+2KMdhSfrBWg4psgiH9O1?=
 =?us-ascii?Q?LtRYnaZtxm/PyLcKHolpDWOFjUHvrWb4c1pGhpbz2J2v63KqsSuCfXtwGP8s?=
 =?us-ascii?Q?fMrJ5mRE7XYQ2ynni04bbKNh42R4gsmCF6gNRoTv+VXWMPxlJ/oqQCcsS+vi?=
 =?us-ascii?Q?P4hilkZRH5p/VRgotIWQ5BI+PSBWWF+Dnqh52ZOiSpUvNY2XZ/+wq9skt0dz?=
 =?us-ascii?Q?7DYG0CgAhjo45pAKFlL9Vrhfqqgkz5MN/JojHfBEeECjNE9G12vtjokUyeJd?=
 =?us-ascii?Q?7RUtY2IAXLKGCaH4glXlM5mxiu1nUdV0suDKKakvITkY6zTSiT0XQ/16xLHK?=
 =?us-ascii?Q?G45qjQUyrU26erPxltBLV60b0XWNH5S+vLRdahUH/y9+JPyzvrTy0CTK7l9Y?=
 =?us-ascii?Q?wRb8noSt4IT3PxYBDxpkCiOk7SLDuFgxx+BJ1bwV3YbUPSUN4RT6ZsQkjp9W?=
 =?us-ascii?Q?pVbSscSW50m7/CKVKhPmlcm7vOLT5uOMv3bDe8CnV1gLWfhVPlxXOD9G6PRF?=
 =?us-ascii?Q?HlCy9daZ2Q=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bf4cc1b-65db-451c-6a0e-08da2931d252
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 16:11:58.7286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kh+obhb77dnO8+a2zBsKXUHltZ2L3gLdGwFVtFpThoZV5FwslsmBaTh7o/DDBl4ZDwH8wu7RWV/NDdDV8Kp4HA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4753

On 27.04.2022 12:47, Roger Pau Monne wrote:
> Use the logic to set shadow SPEC_CTRL values in order to implement
> support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM
> guests. This includes using the spec_ctrl vCPU MSR variable to store
> the guest set value of VIRT_SPEC_CTRL.SSBD, which will be OR'ed with
> any SPEC_CTRL values being set by the guest.
>=20
> On hardware having SPEC_CTRL VIRT_SPEC_CTRL will not be offered by
> default to guests. VIRT_SPEC_CTRL will only be part of the max CPUID
> policy so it can be enabled for compatibility purposes.
>=20
> Use '!' to annotate the feature in order to express that the presence
> of the bit is not directly tied to its value in the host policy.
>=20
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 16:13:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 16:13:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316692.535679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk6lL-0002XG-9J; Thu, 28 Apr 2022 16:13:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316692.535679; Thu, 28 Apr 2022 16:13:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk6lL-0002X9-5m; Thu, 28 Apr 2022 16:13:03 +0000
Received: by outflank-mailman (input) for mailman id 316692;
 Thu, 28 Apr 2022 16:13:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nk6lK-0002Wy-7y
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 16:13:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nk6lJ-00022z-Tx; Thu, 28 Apr 2022 16:13:01 +0000
Received: from [54.239.6.184] (helo=[192.168.2.126])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nk6lJ-00005Z-No; Thu, 28 Apr 2022 16:13:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=D1mVx8EYfUXQI5cZRgHeVXiQAhNwiRXrmwLySF+p3SY=; b=PiVKGfxjzujdDINBxxKPEWdB7p
	S8A5hld/upElBgkVn2RbfhlhOpGXrpe7v8CbuzZMRHc5L3zE134aajAtAQY2QnZ9lmUKlD6pWimiL
	J6AG0Xp2awWJWTP+pKibDhMYduDxWFpBIXXfBgFm1McS6YslZJu6v8UCI9/Cr9XQE7Tc=;
Message-ID: <2177f384-51f3-50d5-d44e-9a98498dba5f@xen.org>
Date: Thu, 28 Apr 2022 17:12:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: rahul.singh@arm.com, Bertrand.Marquis@arm.com
References: <alpine.DEB.2.22.394.2204261323430.915916@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204261323430.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 26/04/2022 21:27, Stefano Stabellini wrote:
> Add Rahul as ARM SMMU maintainer. Create a new explicit entry for "ARM
> SMMU" also with Julien which is the original contributor of the code and
> continues to maintain it.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

Acked-by: Julien Grall <julien@xen.org>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 16:26:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 16:26:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316700.535690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk6yJ-00048f-Fv; Thu, 28 Apr 2022 16:26:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316700.535690; Thu, 28 Apr 2022 16:26:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk6yJ-00048Y-D0; Thu, 28 Apr 2022 16:26:27 +0000
Received: by outflank-mailman (input) for mailman id 316700;
 Thu, 28 Apr 2022 16:26:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GBVy=VG=gmail.com=tcminyard@srs-se1.protection.inumbo.net>)
 id 1nk6yH-00048S-C3
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 16:26:25 +0000
Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com
 [2607:f8b0:4864:20::833])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb85845d-c70f-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 18:26:13 +0200 (CEST)
Received: by mail-qt1-x833.google.com with SMTP id p4so3303470qtq.12
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 09:26:20 -0700 (PDT)
Received: from serve.minyard.net ([47.184.144.75])
 by smtp.gmail.com with ESMTPSA id
 b9-20020a05620a0f8900b0069e84c5352asm169843qkn.47.2022.04.28.09.26.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 28 Apr 2022 09:26:19 -0700 (PDT)
Received: from minyard.net (unknown
 [IPv6:2001:470:b8f6:1b:ccae:2ff0:f27f:9218])
 by serve.minyard.net (Postfix) with ESMTPSA id 993C41800BB;
 Thu, 28 Apr 2022 16:26:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: eb85845d-c70f-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=sender:date:from:to:cc:subject:message-id:reply-to:references
         :mime-version:content-disposition:content-transfer-encoding
         :in-reply-to;
        bh=X61ynYOTK5MLCYojT5d+ysrbHRt63RIFwyQAXjqYUNE=;
        b=RB+bl5iS3eKUU1+cjBBmoZPJ1GgbW8A749d7YnZ5vNC1ZTUNv7WuO8EMH81G6FfKTS
         ULk5loh6t/tF8m/LAK3UZqNRLeu4MFN0UjekospklQvLFm841ye1F/VzC3oleDitZ9O1
         cvCfYdbM5VdBWJyGeksEVUvI/wAmKaB1Xib5pllqvVtHqYCR321S43b6ZumXK649aRhK
         zYDyDYBYNmM0JL+Vo7iNHObeaqoFD1y1D4cNFPF7xZzMMMNiqfQKAckfc8DPi2gZdtiq
         5S67VXHmy+E6AUijmYawjpiuSvLWVR0T3rL6kGpPqkjomB2poiuXMcy1kF9nEqMyvOX9
         Yn4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:sender:date:from:to:cc:subject:message-id
         :reply-to:references:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to;
        bh=X61ynYOTK5MLCYojT5d+ysrbHRt63RIFwyQAXjqYUNE=;
        b=HCElDdyz9BLSWtkix1tDaKMKwL8pEBm13Cf2EK8wfNpQe/hh/Vk2X1JX/xqU8w4QSa
         aM2ICmWaeQ6oVNpQyh7NfCngx90SReWCPRfGqFGxaMnj9at4XFBYxV458N+NUcRz+h8m
         13v7OIHIpC/ZnKDO4flPDOcROKxoDdCyMMz0h8PJ6nIalmGZFvFO/M9J8wGE02vmHeoh
         qaRcRVRCs8IztZiWKg9Cl/isij9SUyg4K29q9XPwLYNk9Lc2vqtgJc63101nHS5f++6n
         mGMg0Rbrthjm7dnC96Q8nqXsxyD5TwEtsPyBA87hX3qsY4nZt0SNi1lB7A0qZvZfo14X
         i3xg==
X-Gm-Message-State: AOAM532OAXavP+bs/6TT6r/tfITqJ6jAOtnW/3H+HqftYNabQ1W9tBr+
	XL8nm9YB8KPKIF2HjjM53A==
X-Google-Smtp-Source: ABdhPJwQWmh1NckrL0EIJZ1oxySS8ak8a2nTI4RkzvZKUWaPk/92sofmAHiS6iQOI6gZ/iWH6wc1qw==
X-Received: by 2002:a05:622a:587:b0:2f3:7dd7:d0e0 with SMTP id c7-20020a05622a058700b002f37dd7d0e0mr9703420qtb.438.1651163179631;
        Thu, 28 Apr 2022 09:26:19 -0700 (PDT)
Sender: Corey Minyard <tcminyard@gmail.com>
Date: Thu, 28 Apr 2022 11:26:16 -0500
From: Corey Minyard <minyard@acm.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org, sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
	fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
	corbet@lwn.net, d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com,
	gregkh@linuxfoundation.org, mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
	john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
	mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
	peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
	stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
	vkuznets@redhat.com, will@kernel.org, Alex Elder <elder@kernel.org>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Chris Zankel <chris@zankel.net>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Dexuan Cui <decui@microsoft.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	James Morse <james.morse@arm.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Matt Turner <mattst88@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>, Pavel Machek <pavel@ucw.cz>,
	Richard Henderson <rth@twiddle.net>,
	Richard Weinberger <richard@nod.at>,
	Robert Richter <rric@kernel.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Tony Luck <tony.luck@intel.com>, Vasily Gorbik <gor@linux.ibm.com>,
	Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list
Message-ID: <20220428162616.GE442787@minyard.net>
Reply-To: minyard@acm.org
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-22-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220427224924.592546-22-gpiccoli@igalia.com>

On Wed, Apr 27, 2022 at 07:49:15PM -0300, Guilherme G. Piccoli wrote:
> This patch renames the panic_notifier_list to panic_pre_reboot_list;
> the idea is that a subsequent patch will refactor the panic path
> in order to better split the notifiers, running some of them very
> early, some of them not so early [but still before kmsg_dump()] and
> finally, the rest should execute late, after kdump. The latter ones
> are now in the panic pre-reboot list - the name comes from the idea
> that these notifiers execute before panic() attempts rebooting the
> machine (if that option is set).
> 
> We also took the opportunity to clean-up useless header inclusions,
> improve some notifier block declarations (e.g. in ibmasm/heartbeat.c)
> and more important, change some priorities - we hereby set 2 notifiers
> to run late in the list [iss_panic_event() and the IPMI panic_event()]
> due to the risks they offer (may not return, for example).
> Proper documentation is going to be provided in a subsequent patch,
> that effectively refactors the panic path.

For the IPMI portion:

Acked-by: Corey Minyard <cminyard@mvista.com>

Note that the IPMI panic_event() should always return, but it may take
some time, especially if the IPMI controller is no longer functional.
So the risk of a long delay is there and it makes sense to move it very
late.

-corey

> 
> Cc: Alex Elder <elder@kernel.org>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Corey Minyard <minyard@acm.org>
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Matt Turner <mattst88@gmail.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Robert Richter <rric@kernel.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Wei Liu <wei.liu@kernel.org>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
> 
> Notice that, with this name change, out-of-tree code that relies in the global
> exported "panic_notifier_list" will fail to build. We could easily keep the
> retro-compatibility by making the old symbol to still exist and point to the
> pre_reboot list (or even, keep the old naming).
> 
> But our design choice was to allow the breakage, making users rethink their
> notifiers, adding them in the list that fits best. If that wasn't a good
> decision, we're open to change it, of course.
> Thanks in advance for the review!
> 
>  arch/alpha/kernel/setup.c             |  4 ++--
>  arch/parisc/kernel/pdc_chassis.c      |  3 +--
>  arch/powerpc/kernel/setup-common.c    |  2 +-
>  arch/s390/kernel/ipl.c                |  4 ++--
>  arch/um/drivers/mconsole_kern.c       |  2 +-
>  arch/um/kernel/um_arch.c              |  2 +-
>  arch/x86/xen/enlighten.c              |  2 +-
>  arch/xtensa/platforms/iss/setup.c     |  4 ++--
>  drivers/char/ipmi/ipmi_msghandler.c   | 12 +++++++-----
>  drivers/edac/altera_edac.c            |  3 +--
>  drivers/hv/vmbus_drv.c                |  4 ++--
>  drivers/leds/trigger/ledtrig-panic.c  |  3 +--
>  drivers/misc/ibmasm/heartbeat.c       | 16 +++++++++-------
>  drivers/net/ipa/ipa_smp2p.c           |  5 ++---
>  drivers/parisc/power.c                |  4 ++--
>  drivers/remoteproc/remoteproc_core.c  |  6 ++++--
>  drivers/s390/char/con3215.c           |  2 +-
>  drivers/s390/char/con3270.c           |  2 +-
>  drivers/s390/char/sclp_con.c          |  2 +-
>  drivers/s390/char/sclp_vt220.c        |  2 +-
>  drivers/staging/olpc_dcon/olpc_dcon.c |  6 ++++--
>  drivers/video/fbdev/hyperv_fb.c       |  4 ++--
>  include/linux/panic_notifier.h        |  2 +-
>  kernel/panic.c                        |  9 ++++-----
>  24 files changed, 54 insertions(+), 51 deletions(-)
> 
> diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c
> index d88bdf852753..8ace0d7113b6 100644
> --- a/arch/alpha/kernel/setup.c
> +++ b/arch/alpha/kernel/setup.c
> @@ -472,8 +472,8 @@ setup_arch(char **cmdline_p)
>  	}
>  
>  	/* Register a call for panic conditions. */
> -	atomic_notifier_chain_register(&panic_notifier_list,
> -			&alpha_panic_block);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
> +					&alpha_panic_block);
>  
>  #ifndef alpha_using_srm
>  	/* Assume that we've booted from SRM if we haven't booted from MILO.
> diff --git a/arch/parisc/kernel/pdc_chassis.c b/arch/parisc/kernel/pdc_chassis.c
> index da154406d368..0fd8d87fb4f9 100644
> --- a/arch/parisc/kernel/pdc_chassis.c
> +++ b/arch/parisc/kernel/pdc_chassis.c
> @@ -22,7 +22,6 @@
>  #include <linux/kernel.h>
>  #include <linux/panic_notifier.h>
>  #include <linux/reboot.h>
> -#include <linux/notifier.h>
>  #include <linux/cache.h>
>  #include <linux/proc_fs.h>
>  #include <linux/seq_file.h>
> @@ -135,7 +134,7 @@ void __init parisc_pdc_chassis_init(void)
>  				PDC_CHASSIS_VER);
>  
>  		/* initialize panic notifier chain */
> -		atomic_notifier_chain_register(&panic_notifier_list,
> +		atomic_notifier_chain_register(&panic_pre_reboot_list,
>  				&pdc_chassis_panic_block);
>  
>  		/* initialize reboot notifier chain */
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index d04b8bf8dbc7..3518bebc10ad 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -762,7 +762,7 @@ void __init setup_panic(void)
>  
>  	/* Low-level platform-specific routines that should run on panic */
>  	if (ppc_md.panic)
> -		atomic_notifier_chain_register(&panic_notifier_list,
> +		atomic_notifier_chain_register(&panic_pre_reboot_list,
>  					       &ppc_panic_block);
>  }
>  
> diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c
> index 1cc85b8ff42e..4a88c5bb6e15 100644
> --- a/arch/s390/kernel/ipl.c
> +++ b/arch/s390/kernel/ipl.c
> @@ -2034,7 +2034,7 @@ static int on_panic_notify(struct notifier_block *self,
>  			   unsigned long event, void *data)
>  {
>  	do_panic();
> -	return NOTIFY_OK;
> +	return NOTIFY_DONE;
>  }
>  
>  static struct notifier_block on_panic_nb = {
> @@ -2069,7 +2069,7 @@ void __init setup_ipl(void)
>  		/* We have no info to copy */
>  		break;
>  	}
> -	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
>  }
>  
>  void s390_reset_system(void)
> diff --git a/arch/um/drivers/mconsole_kern.c b/arch/um/drivers/mconsole_kern.c
> index 2ea0421bcc3f..21c13b4e24a3 100644
> --- a/arch/um/drivers/mconsole_kern.c
> +++ b/arch/um/drivers/mconsole_kern.c
> @@ -855,7 +855,7 @@ static struct notifier_block panic_exit_notifier = {
>  
>  static int add_notifier(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
>  			&panic_exit_notifier);
>  	return 0;
>  }
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> index 4485b1a7c8e4..fc6e443299da 100644
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -257,7 +257,7 @@ static struct notifier_block panic_exit_notifier = {
>  
>  void uml_finishsetup(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
>  				       &panic_exit_notifier);
>  
>  	uml_postsetup();
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index 30c6e986a6cd..d4f4de239a21 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -290,7 +290,7 @@ static struct notifier_block xen_panic_block = {
>  
>  int xen_panic_handler_init(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list, &xen_panic_block);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list, &xen_panic_block);
>  	return 0;
>  }
>  
> diff --git a/arch/xtensa/platforms/iss/setup.c b/arch/xtensa/platforms/iss/setup.c
> index d3433e1bb94e..eeeeb6cff6bd 100644
> --- a/arch/xtensa/platforms/iss/setup.c
> +++ b/arch/xtensa/platforms/iss/setup.c
> @@ -13,7 +13,6 @@
>   */
>  #include <linux/init.h>
>  #include <linux/kernel.h>
> -#include <linux/notifier.h>
>  #include <linux/panic_notifier.h>
>  #include <linux/printk.h>
>  #include <linux/string.h>
> @@ -53,6 +52,7 @@ iss_panic_event(struct notifier_block *this, unsigned long event, void *ptr)
>  
>  static struct notifier_block iss_panic_block = {
>  	.notifier_call = iss_panic_event,
> +	.priority = INT_MIN, /* run as late as possible, may not return */
>  };
>  
>  void __init platform_setup(char **p_cmdline)
> @@ -81,5 +81,5 @@ void __init platform_setup(char **p_cmdline)
>  		}
>  	}
>  
> -	atomic_notifier_chain_register(&panic_notifier_list, &iss_panic_block);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list, &iss_panic_block);
>  }
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index c59265146e9c..6c4770949c01 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -25,7 +25,6 @@
>  #include <linux/slab.h>
>  #include <linux/ipmi.h>
>  #include <linux/ipmi_smi.h>
> -#include <linux/notifier.h>
>  #include <linux/init.h>
>  #include <linux/proc_fs.h>
>  #include <linux/rcupdate.h>
> @@ -5375,10 +5374,13 @@ static int ipmi_register_driver(void)
>  	return rv;
>  }
>  
> +/*
> + * we should execute this panic callback late, since it involves
> + * a complex call-chain and panic() runs in atomic context.
> + */
>  static struct notifier_block panic_block = {
>  	.notifier_call	= panic_event,
> -	.next		= NULL,
> -	.priority	= 200	/* priority: INT_MAX >= x >= 0 */
> +	.priority	= INT_MIN + 1,
>  };
>  
>  static int ipmi_init_msghandler(void)
> @@ -5406,7 +5408,7 @@ static int ipmi_init_msghandler(void)
>  	timer_setup(&ipmi_timer, ipmi_timeout, 0);
>  	mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES);
>  
> -	atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list, &panic_block);
>  
>  	initialized = true;
>  
> @@ -5438,7 +5440,7 @@ static void __exit cleanup_ipmi(void)
>  	if (initialized) {
>  		destroy_workqueue(remove_work_wq);
>  
> -		atomic_notifier_chain_unregister(&panic_notifier_list,
> +		atomic_notifier_chain_unregister(&panic_pre_reboot_list,
>  						 &panic_block);
>  
>  		/*
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index e7e8e624a436..4890e9cba6fb 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -16,7 +16,6 @@
>  #include <linux/kernel.h>
>  #include <linux/mfd/altera-sysmgr.h>
>  #include <linux/mfd/syscon.h>
> -#include <linux/notifier.h>
>  #include <linux/of_address.h>
>  #include <linux/of_irq.h>
>  #include <linux/of_platform.h>
> @@ -2163,7 +2162,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>  		int dberror, err_addr;
>  
>  		edac->panic_notifier.notifier_call = s10_edac_dberr_handler;
> -		atomic_notifier_chain_register(&panic_notifier_list,
> +		atomic_notifier_chain_register(&panic_pre_reboot_list,
>  					       &edac->panic_notifier);
>  
>  		/* Printout a message if uncorrectable error previously. */
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 901b97034308..3717c323aa36 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1622,7 +1622,7 @@ static int vmbus_bus_init(void)
>  	 * Always register the vmbus unload panic notifier because we
>  	 * need to shut the VMbus channel connection on panic.
>  	 */
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
>  			       &hyperv_panic_vmbus_unload_block);
>  
>  	vmbus_request_offers();
> @@ -2851,7 +2851,7 @@ static void __exit vmbus_exit(void)
>  	 * The vmbus panic notifier is always registered, hence we should
>  	 * also unconditionally unregister it here as well.
>  	 */
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> +	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
>  					&hyperv_panic_vmbus_unload_block);
>  
>  	free_page((unsigned long)hv_panic_page);
> diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c
> index 64abf2e91608..34fd5170723f 100644
> --- a/drivers/leds/trigger/ledtrig-panic.c
> +++ b/drivers/leds/trigger/ledtrig-panic.c
> @@ -7,7 +7,6 @@
>  
>  #include <linux/kernel.h>
>  #include <linux/init.h>
> -#include <linux/notifier.h>
>  #include <linux/panic_notifier.h>
>  #include <linux/leds.h>
>  #include "../leds.h"
> @@ -64,7 +63,7 @@ static long led_panic_blink(int state)
>  
>  static int __init ledtrig_panic_init(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
>  				       &led_trigger_panic_nb);
>  
>  	led_trigger_register_simple("panic", &trigger);
> diff --git a/drivers/misc/ibmasm/heartbeat.c b/drivers/misc/ibmasm/heartbeat.c
> index 59c9a0d95659..d6acae88b722 100644
> --- a/drivers/misc/ibmasm/heartbeat.c
> +++ b/drivers/misc/ibmasm/heartbeat.c
> @@ -8,7 +8,6 @@
>   * Author: Max Asböck <amax@us.ibm.com>
>   */
>  
> -#include <linux/notifier.h>
>  #include <linux/panic_notifier.h>
>  #include "ibmasm.h"
>  #include "dot_command.h"
> @@ -24,7 +23,7 @@ static int suspend_heartbeats = 0;
>   * In the case of a panic the interrupt handler continues to work and thus
>   * continues to respond to heartbeats, making the service processor believe
>   * the OS is still running and thus preventing a reboot.
> - * To prevent this from happening a callback is added the panic_notifier_list.
> + * To prevent this from happening a callback is added in a panic notifier list.
>   * Before responding to a heartbeat the driver checks if a panic has happened,
>   * if yes it suspends heartbeat, causing the service processor to reboot as
>   * expected.
> @@ -32,20 +31,23 @@ static int suspend_heartbeats = 0;
>  static int panic_happened(struct notifier_block *n, unsigned long val, void *v)
>  {
>  	suspend_heartbeats = 1;
> -	return 0;
> +	return NOTIFY_DONE;
>  }
>  
> -static struct notifier_block panic_notifier = { panic_happened, NULL, 1 };
> +static struct notifier_block panic_notifier = {
> +	.notifier_call = panic_happened,
> +};
>  
>  void ibmasm_register_panic_notifier(void)
>  {
> -	atomic_notifier_chain_register(&panic_notifier_list, &panic_notifier);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
> +					&panic_notifier);
>  }
>  
>  void ibmasm_unregister_panic_notifier(void)
>  {
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> -			&panic_notifier);
> +	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
> +					&panic_notifier);
>  }
>  
>  
> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index 211233612039..92cdf6e0637c 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -7,7 +7,6 @@
>  #include <linux/types.h>
>  #include <linux/device.h>
>  #include <linux/interrupt.h>
> -#include <linux/notifier.h>
>  #include <linux/panic_notifier.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/soc/qcom/smem.h>
> @@ -138,13 +137,13 @@ static int ipa_smp2p_panic_notifier_register(struct ipa_smp2p *smp2p)
>  	smp2p->panic_notifier.notifier_call = ipa_smp2p_panic_notifier;
>  	smp2p->panic_notifier.priority = INT_MAX;	/* Do it early */
>  
> -	return atomic_notifier_chain_register(&panic_notifier_list,
> +	return atomic_notifier_chain_register(&panic_pre_reboot_list,
>  					      &smp2p->panic_notifier);
>  }
>  
>  static void ipa_smp2p_panic_notifier_unregister(struct ipa_smp2p *smp2p)
>  {
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> +	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
>  					 &smp2p->panic_notifier);
>  }
>  
> diff --git a/drivers/parisc/power.c b/drivers/parisc/power.c
> index 8512884de2cf..5bb0868f5f08 100644
> --- a/drivers/parisc/power.c
> +++ b/drivers/parisc/power.c
> @@ -233,7 +233,7 @@ static int __init power_init(void)
>  	}
>  
>  	/* Register a call for panic conditions. */
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
>  			&parisc_panic_block);
>  
>  	return 0;
> @@ -243,7 +243,7 @@ static void __exit power_exit(void)
>  {
>  	kthread_stop(power_task);
>  
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> +	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
>  			&parisc_panic_block);
>  
>  	pdc_soft_power_button(0);
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index c510125769b9..24799ff239e6 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -2795,12 +2795,14 @@ static int rproc_panic_handler(struct notifier_block *nb, unsigned long event,
>  static void __init rproc_init_panic(void)
>  {
>  	rproc_panic_nb.notifier_call = rproc_panic_handler;
> -	atomic_notifier_chain_register(&panic_notifier_list, &rproc_panic_nb);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
> +				       &rproc_panic_nb);
>  }
>  
>  static void __exit rproc_exit_panic(void)
>  {
> -	atomic_notifier_chain_unregister(&panic_notifier_list, &rproc_panic_nb);
> +	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
> +					 &rproc_panic_nb);
>  }
>  
>  static int __init remoteproc_init(void)
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index 192198bd3dc4..07379dd3f1f3 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -867,7 +867,7 @@ static int __init con3215_init(void)
>  		raw3215[0] = NULL;
>  		return -ENODEV;
>  	}
> -	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
>  	register_reboot_notifier(&on_reboot_nb);
>  	register_console(&con3215);
>  	return 0;
> diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
> index 476202f3d8a0..e79bf3e7bde3 100644
> --- a/drivers/s390/char/con3270.c
> +++ b/drivers/s390/char/con3270.c
> @@ -645,7 +645,7 @@ con3270_init(void)
>  	condev->cline->len = 0;
>  	con3270_create_status(condev);
>  	condev->input = alloc_string(&condev->freemem, 80);
> -	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
>  	register_reboot_notifier(&on_reboot_nb);
>  	register_console(&con3270);
>  	return 0;
> diff --git a/drivers/s390/char/sclp_con.c b/drivers/s390/char/sclp_con.c
> index e5d947c763ea..7ca9d4c45d60 100644
> --- a/drivers/s390/char/sclp_con.c
> +++ b/drivers/s390/char/sclp_con.c
> @@ -288,7 +288,7 @@ sclp_console_init(void)
>  	timer_setup(&sclp_con_timer, sclp_console_timeout, 0);
>  
>  	/* enable printk-access to this driver */
> -	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
>  	register_reboot_notifier(&on_reboot_nb);
>  	register_console(&sclp_console);
>  	return 0;
> diff --git a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
> index a32f34a1c6d2..97cf9e290c28 100644
> --- a/drivers/s390/char/sclp_vt220.c
> +++ b/drivers/s390/char/sclp_vt220.c
> @@ -838,7 +838,7 @@ sclp_vt220_con_init(void)
>  	if (rc)
>  		return rc;
>  	/* Attach linux console */
> -	atomic_notifier_chain_register(&panic_notifier_list, &on_panic_nb);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list, &on_panic_nb);
>  	register_reboot_notifier(&on_reboot_nb);
>  	register_console(&sclp_vt220_console);
>  	return 0;
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index 7284cb4ac395..cb50471f2246 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -653,7 +653,8 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  	}
>  
>  	register_reboot_notifier(&dcon->reboot_nb);
> -	atomic_notifier_chain_register(&panic_notifier_list, &dcon_panic_nb);
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
> +				       &dcon_panic_nb);
>  
>  	return 0;
>  
> @@ -676,7 +677,8 @@ static int dcon_remove(struct i2c_client *client)
>  	struct dcon_priv *dcon = i2c_get_clientdata(client);
>  
>  	unregister_reboot_notifier(&dcon->reboot_nb);
> -	atomic_notifier_chain_unregister(&panic_notifier_list, &dcon_panic_nb);
> +	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
> +					 &dcon_panic_nb);
>  
>  	free_irq(DCON_IRQ, dcon);
>  
> diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
> index f3494b868a64..ec21e63592be 100644
> --- a/drivers/video/fbdev/hyperv_fb.c
> +++ b/drivers/video/fbdev/hyperv_fb.c
> @@ -1253,7 +1253,7 @@ static int hvfb_probe(struct hv_device *hdev,
>  	 */
>  	par->hvfb_panic_nb.notifier_call = hvfb_on_panic;
>  	par->hvfb_panic_nb.priority = INT_MIN + 10,
> -	atomic_notifier_chain_register(&panic_notifier_list,
> +	atomic_notifier_chain_register(&panic_pre_reboot_list,
>  				       &par->hvfb_panic_nb);
>  
>  	return 0;
> @@ -1276,7 +1276,7 @@ static int hvfb_remove(struct hv_device *hdev)
>  	struct fb_info *info = hv_get_drvdata(hdev);
>  	struct hvfb_par *par = info->par;
>  
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> +	atomic_notifier_chain_unregister(&panic_pre_reboot_list,
>  					 &par->hvfb_panic_nb);
>  
>  	par->update = false;
> diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
> index 7364a346bcb0..7912aacbc0e5 100644
> --- a/include/linux/panic_notifier.h
> +++ b/include/linux/panic_notifier.h
> @@ -5,9 +5,9 @@
>  #include <linux/notifier.h>
>  #include <linux/types.h>
>  
> -extern struct atomic_notifier_head panic_notifier_list;
>  extern struct atomic_notifier_head panic_hypervisor_list;
>  extern struct atomic_notifier_head panic_info_list;
> +extern struct atomic_notifier_head panic_pre_reboot_list;
>  
>  extern bool crash_kexec_post_notifiers;
>  
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 73ca1bc44e30..a9d43b98b05b 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -69,16 +69,15 @@ EXPORT_SYMBOL_GPL(panic_timeout);
>  #define PANIC_PRINT_ALL_CPU_BT		0x00000040
>  unsigned long panic_print;
>  
> -ATOMIC_NOTIFIER_HEAD(panic_notifier_list);
> -
> -EXPORT_SYMBOL(panic_notifier_list);
> -
>  ATOMIC_NOTIFIER_HEAD(panic_hypervisor_list);
>  EXPORT_SYMBOL(panic_hypervisor_list);
>  
>  ATOMIC_NOTIFIER_HEAD(panic_info_list);
>  EXPORT_SYMBOL(panic_info_list);
>  
> +ATOMIC_NOTIFIER_HEAD(panic_pre_reboot_list);
> +EXPORT_SYMBOL(panic_pre_reboot_list);
> +
>  static long no_blink(int state)
>  {
>  	return 0;
> @@ -295,7 +294,7 @@ void panic(const char *fmt, ...)
>  	 */
>  	atomic_notifier_call_chain(&panic_hypervisor_list, PANIC_NOTIFIER, buf);
>  	atomic_notifier_call_chain(&panic_info_list, PANIC_NOTIFIER, buf);
> -	atomic_notifier_call_chain(&panic_notifier_list, PANIC_NOTIFIER, buf);
> +	atomic_notifier_call_chain(&panic_pre_reboot_list, PANIC_NOTIFIER, buf);
>  
>  	panic_print_sys_info(false);
>  
> -- 
> 2.36.0
> 


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 16:52:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 16:52:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316709.535707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk7Nh-0007PU-PG; Thu, 28 Apr 2022 16:52:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316709.535707; Thu, 28 Apr 2022 16:52:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk7Nh-0007PN-Ls; Thu, 28 Apr 2022 16:52:41 +0000
Received: by outflank-mailman (input) for mailman id 316709;
 Thu, 28 Apr 2022 16:52:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk7Nf-0007PA-K3; Thu, 28 Apr 2022 16:52:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk7Nf-0002lP-Ga; Thu, 28 Apr 2022 16:52:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk7Nf-0000aa-9Z; Thu, 28 Apr 2022 16:52:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk7Nf-0006Hv-6x; Thu, 28 Apr 2022 16:52:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+SGYe0tdijZY/zXna3JHVCSHADx1F4Pzcjm20ejPn7k=; b=ZDBp1S4TyRvUwUvUba1Ai1VdcE
	xg2/L5ePe6I8+65g8mJvdOQ8mmHlJppExmNjHsgt8E9EUBQ8vdHgmHtMXcXLIA54QHjiLThhHc27K
	hqmlP8bJupi/uhtvB4i6xlQPdK2V/p75LwY0UQP5sCc8jxeVPynVP27o1bH1TBjVon/k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169801-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169801: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-coresched-i386-xl:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=cf6f26d6f9b2015ee12b4604b79359e76784163a
X-Osstest-Versions-That:
    qemuu=34723f59371f3fd02ea59b94674314b875504426
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 16:52:39 +0000

flight 169801 qemu-mainline real [real]
flight 169825 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169801/
http://logs.test-lab.xenproject.org/osstest/logs/169825/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-coresched-i386-xl 14 guest-start         fail pass in 169825-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169779
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169779
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169779
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169779
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169779
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169779
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169779
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169779
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                cf6f26d6f9b2015ee12b4604b79359e76784163a
baseline version:
 qemuu                34723f59371f3fd02ea59b94674314b875504426

Last test of basis   169779  2022-04-27 10:34:36 Z    1 days
Testing same since   169801  2022-04-28 00:08:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Carwyn Ellis <carwynellis@gmail.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Kshitij Suri <kshitij.suri@nutanix.com>
  Markus Armbruster <armbru@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
  Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
  Xiaoyao Li <xiaoyao.li@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   34723f5937..cf6f26d6f9  cf6f26d6f9b2015ee12b4604b79359e76784163a -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 16:56:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 16:56:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316717.535718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk7Rj-00082h-Ae; Thu, 28 Apr 2022 16:56:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316717.535718; Thu, 28 Apr 2022 16:56:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk7Rj-00082a-7Y; Thu, 28 Apr 2022 16:56:51 +0000
Received: by outflank-mailman (input) for mailman id 316717;
 Thu, 28 Apr 2022 16:56:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4Y7a=VG=gmx.de=deller@srs-se1.protection.inumbo.net>)
 id 1nk7Ri-00082P-13
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 16:56:50 +0000
Received: from mout.gmx.net (mout.gmx.net [212.227.15.15])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2d370fe4-c714-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 18:56:41 +0200 (CEST)
Received: from [192.168.20.60] ([92.116.133.159]) by mail.gmx.net (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MzyuS-1o6TNU3b1S-00x2R3; Thu, 28
 Apr 2022 18:56:03 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d370fe4-c714-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
	s=badeba3b8450; t=1651164963;
	bh=DUb16bHT8ZVVcSBzzE8lnieko2RHZpG2zbwsEWdWo2c=;
	h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To;
	b=TrwFfhoA2P1jqiZSh6qbThQbWQ3kajZ2U+JQrRL/jSZxckwFV1BopRKv6DRaeQSKC
	 DM8QpY2fv9fsoSq055uYb4MCMz8e9HvG+guo2m9xr29cJoYbxYguo2PwZIKFp/JXdB
	 qy9XbYXMKcmj9vbKxczpPpGqEow6LzKi+qj1B+ao=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Message-ID: <6a7c924a-54a9-c5ea-8a9d-3ea92987b436@gmx.de>
Date: Thu, 28 Apr 2022 18:55:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 12/30] parisc: Replace regular spinlock with spin_trylock
 on panic path
Content-Language: en-US
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-13-gpiccoli@igalia.com>
From: Helge Deller <deller@gmx.de>
In-Reply-To: <20220427224924.592546-13-gpiccoli@igalia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:5vdTXh07+igNuefls5XBW8Vnc+iEgtAi7WYk6EGDKuqY95FwGMe
 QwcWZKzUaEoh4UB+55vjZve/tYEaItgGsgQfOqHuHHkvtwYyxsf6YShgZsftQKYSmO6WQ+T
 ZC1GiQE33MbntUGomNddrKZxDF5sJxGJRqGlvPVNWYXBnGaRnQV/WvjdEKXY9QfAk5iDfpf
 2SF7pYcym4psStLDUUMNQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:seIPaj7dpZM=:yycTg0fvdDhrITiv3IZXzI
 e4yFHTYHbrGUy0XcNvNSnWURkRH0CwdNhQ3CWNfifJgMcKrsF971kE1ZPU9NMQWdlbTy3YHHQ
 kdbLaclaoLvW+e4KLLE5yocf48/EeAYglXhY84PxWcp1QGdF7y7nXLElZka6kp2R0F8+61JyB
 loph7JvlvHMoA0h4saDhDgOi28CBTeWf2mZxC+/EkMY8v85s5wN3/znVOlOIi2kLzQZEdEUxg
 qZqRAEH0zpZWVc5jenddLnwtNUslbH1ysbnT6Jz+8m3SINHv4Rwqo8qzXPYlIEhtABEOB2CCo
 zGH68oxcPKpqrqbFPSUrvmevYIsFthSN4Qa4ESwcyflnmJb/H2yYOm3idKBPcHZoAc7MXpKFp
 RR3P6Q1355mAy9N9Htg1IQRALV21oxx1PunXwbHOYiOH77jvrab76cf+pliKkaIi4EdHQpQqw
 9mxPXAGH7PZiMiQ7xVCBiONFGbdiXxNWW9WgP8A6pz6E89Sx90IwrTRc9D73bLfwpGwDmjWxi
 fFfVa4k8dmCqUPhBM1VhxPpxNRnj9QzEWrSQ0xThSfPtnfKEaiZ6CAhESljw6d2UOOHcDSLiC
 pYk2Il0xe7DktL7r83T2I0B8fYcU06QnK7MXlbmtGkMbQFBGucQc+IB7UEgTcN0uT8ZaS6/FI
 jkfGMBIY2eSkyrlErzq+vnajUsa0b9zENmsHS55RE7h43gLxmwE2UNFRUH8bWmdFhfJcUWhCo
 0TAcvRyne9VEKfs0HrQjTEdgbmSa875UQ1egzran3Xhi4XGH8Atz9id4q//uvXHDPEYGUcpM1
 1jCttDZecf4rq/B12RMkoMxP6zY3FZKwK7quDBpUSTid+jJEDxaXtx0XaeJ0Hg0rDMgviRyZ9
 HzUcPocKiz/LqCSxQKJ+5LacyVgyzC2Eg/QV5UE+RmBe/a0+mK1ccbKXN/YmWVo5xcoOe11r/
 LQC+womcGp8ubOddU8soGYLdecjhj+rpnt5TdzsPY9fawi7HlwarnA+ConVoG4a/SWDHYon/e
 QtxJhYG5A/NQ3aDfGGrPKFQkR4D9mAqQmSL7oHO9wv65NzEickiapaFqe4ZYqD4oBbohP/rOw
 OHyJm5CjSYyJJQ=

On 4/28/22 00:49, Guilherme G. Piccoli wrote:
> The panic notifiers' callbacks execute in an atomic context, with
> interrupts/preemption disabled, and all CPUs not running the panic
> function are off, so it's very dangerous to wait on a regular
> spinlock, there's a risk of deadlock.
>
> This patch refactors the panic notifier of parisc/power driver
> to make use of spin_trylock - for that, we've added a second
> version of the soft-power function. Also, some comments were
> reorganized and trailing white spaces, useless header inclusion
> and blank lines were removed.
>
> Cc: Helge Deller <deller@gmx.de>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>

You may add:
Acked-by: Helge Deller <deller@gmx.de> # parisc

Helge


> ---
>  arch/parisc/include/asm/pdc.h |  1 +
>  arch/parisc/kernel/firmware.c | 27 +++++++++++++++++++++++----
>  drivers/parisc/power.c        | 17 ++++++++++-------
>  3 files changed, 34 insertions(+), 11 deletions(-)
>
> diff --git a/arch/parisc/include/asm/pdc.h b/arch/parisc/include/asm/pdc=
.h
> index b643092d4b98..7a106008e258 100644
> --- a/arch/parisc/include/asm/pdc.h
> +++ b/arch/parisc/include/asm/pdc.h
> @@ -83,6 +83,7 @@ int pdc_do_firm_test_reset(unsigned long ftc_bitmap);
>  int pdc_do_reset(void);
>  int pdc_soft_power_info(unsigned long *power_reg);
>  int pdc_soft_power_button(int sw_control);
> +int pdc_soft_power_button_panic(int sw_control);
>  void pdc_io_reset(void);
>  void pdc_io_reset_devices(void);
>  int pdc_iodc_getc(void);
> diff --git a/arch/parisc/kernel/firmware.c b/arch/parisc/kernel/firmware=
.c
> index 6a7e315bcc2e..0e2f70b592f4 100644
> --- a/arch/parisc/kernel/firmware.c
> +++ b/arch/parisc/kernel/firmware.c
> @@ -1232,15 +1232,18 @@ int __init pdc_soft_power_info(unsigned long *po=
wer_reg)
>  }
>
>  /*
> - * pdc_soft_power_button - Control the soft power button behaviour
> - * @sw_control: 0 for hardware control, 1 for software control
> + * pdc_soft_power_button{_panic} - Control the soft power button behavi=
our
> + * @sw_control: 0 for hardware control, 1 for software control
>   *
>   *
>   * This PDC function places the soft power button under software or
>   * hardware control.
> - * Under software control the OS may control to when to allow to shut
> - * down the system. Under hardware control pressing the power button
> + * Under software control the OS may control to when to allow to shut
> + * down the system. Under hardware control pressing the power button
>   * powers off the system immediately.
> + *
> + * The _panic version relies in spin_trylock to prevent deadlock
> + * on panic path.
>   */
>  int pdc_soft_power_button(int sw_control)
>  {
> @@ -1254,6 +1257,22 @@ int pdc_soft_power_button(int sw_control)
>  	return retval;
>  }
>
> +int pdc_soft_power_button_panic(int sw_control)
> +{
> +	int retval;
> +	unsigned long flags;
> +
> +	if (!spin_trylock_irqsave(&pdc_lock, flags)) {
> +		pr_emerg("Couldn't enable soft power button\n");
> +		return -EBUSY; /* ignored by the panic notifier */
> +	}
> +
> +	retval =3D mem_pdc_call(PDC_SOFT_POWER, PDC_SOFT_POWER_ENABLE, __pa(pd=
c_result), sw_control);
> +	spin_unlock_irqrestore(&pdc_lock, flags);
> +
> +	return retval;
> +}
> +
>  /*
>   * pdc_io_reset - Hack to avoid overlapping range registers of Bridges =
devices.
>   * Primarily a problem on T600 (which parisc-linux doesn't support) but
> diff --git a/drivers/parisc/power.c b/drivers/parisc/power.c
> index 456776bd8ee6..8512884de2cf 100644
> --- a/drivers/parisc/power.c
> +++ b/drivers/parisc/power.c
> @@ -37,7 +37,6 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/kernel.h>
> -#include <linux/notifier.h>
>  #include <linux/panic_notifier.h>
>  #include <linux/reboot.h>
>  #include <linux/sched/signal.h>
> @@ -175,16 +174,21 @@ static void powerfail_interrupt(int code, void *x)
>
>
>
> -/* parisc_panic_event() is called by the panic handler.
> - * As soon as a panic occurs, our tasklets above will not be
> - * executed any longer. This function then re-enables the
> - * soft-power switch and allows the user to switch off the system
> +/*
> + * parisc_panic_event() is called by the panic handler.
> + *
> + * As soon as a panic occurs, our tasklets above will not
> + * be executed any longer. This function then re-enables
> + * the soft-power switch and allows the user to switch off
> + * the system. We rely in pdc_soft_power_button_panic()
> + * since this version spin_trylocks (instead of regular
> + * spinlock), preventing deadlocks on panic path.
>   */
>  static int parisc_panic_event(struct notifier_block *this,
>  		unsigned long event, void *ptr)
>  {
>  	/* re-enable the soft-power switch */
> -	pdc_soft_power_button(0);
> +	pdc_soft_power_button_panic(0);
>  	return NOTIFY_DONE;
>  }
>
> @@ -193,7 +197,6 @@ static struct notifier_block parisc_panic_block =3D =
{
>  	.priority	=3D INT_MAX,
>  };
>
> -
>  static int __init power_init(void)
>  {
>  	unsigned long ret;



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 17:07:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 17:07:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316723.535729 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk7bS-00017w-8O; Thu, 28 Apr 2022 17:06:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316723.535729; Thu, 28 Apr 2022 17:06:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk7bS-00017p-4J; Thu, 28 Apr 2022 17:06:54 +0000
Received: by outflank-mailman (input) for mailman id 316723;
 Thu, 28 Apr 2022 17:06:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk7bR-00017f-Ji; Thu, 28 Apr 2022 17:06:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk7bR-00031v-Hu; Thu, 28 Apr 2022 17:06:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk7bR-0001en-Bu; Thu, 28 Apr 2022 17:06:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk7bR-00030q-9B; Thu, 28 Apr 2022 17:06:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Mmv5jxhU0f5GTpJ2jXLQZfrFhJjLH/LUpEP/GMOWqaA=; b=ikjBmN+T7VmpxWi7ARmLGHk7mk
	3/SzQwYducQ2Bb3XYES3enUlRD8/blNziij7UaEV2+Om3W4G/Y0hUob1Hc2xfgV/CFwCVqCnMDDFo
	UBCnx4OVivW6FYh9fVxbQIIl+naVY/6O4dhRP1ZUpJa7heyqZ9GzThMpvpfbU03SH1zQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169821-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169821: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 17:06:53 +0000

flight 169821 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169821/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  681 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 18:04:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 18:04:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316736.535752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk8Uy-0007BT-JD; Thu, 28 Apr 2022 18:04:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316736.535752; Thu, 28 Apr 2022 18:04:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk8Uy-0007BM-Fc; Thu, 28 Apr 2022 18:04:16 +0000
Received: by outflank-mailman (input) for mailman id 316736;
 Thu, 28 Apr 2022 18:04:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50wr=VG=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nk8Uw-0007BG-Ju
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 18:04:14 +0000
Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com
 [2607:f8b0:4864:20::833])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9bca2d86-c71d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 20:04:13 +0200 (CEST)
Received: by mail-qt1-x833.google.com with SMTP id ay11so4071876qtb.4
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 11:04:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bca2d86-c71d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=jecZhItbx7VnRnOJqkUVUsRQR95GKWnZvs6DE4Ykza8=;
        b=LduMzDYJEXfPb+CjNbrlTSBZ0el2LdoB31flxf/T97/WQYSY+aZQEgFi8rOgjiJk1f
         YgmzWKJYWkSdHq4FFZPaSCvsA2NnrLettKtWBoOSbEpxS3JYKHoh6Xk0eErRNnuEyWfc
         2n/rVlvey60r5hDqUBU0ZZfVrMVkE/nN8WjypOYFqWNYxiJGCsbZvMBNCmG9iNv7hP5v
         QBo4rVXdLKxXMKDvpnItrPaybdKn3rzUw+UVPqy3cwXJr4ecDg2E6AA2SKQgrjY1Pp6k
         PYIDJYRlugKyIbVR1/PiaR5CBVw4Vm79LVHG65pLdUdNZpfB4cC+K8Ny0ikY2zgy8/ML
         P+GA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=jecZhItbx7VnRnOJqkUVUsRQR95GKWnZvs6DE4Ykza8=;
        b=HGOsOl/Jzt4VUiT/8vU+pzzg7jv6hUMJMb2jk3R5W29PyL6EaKLkr8rO4XdSTPs7h2
         NBxYbWeGbS7OOma1HgHL5VUkkwXtM6XX6JE8X3b3+l2+8/z/AwNzPWCGA3l9cAZQsxnU
         GS2zmSOx3j+M0FokYLfv0mtZ2OP6JeRlSSKcMHuUcMb/3Mjqo1rwadr+jVAuwSaNCJdl
         xsWdQupy9KE0/6DSJAo1tEjSPvxJHOiQxqaroku6GhoNk17qHQl8tmyvvkFBBYH8uGLg
         lZF0xoXWLJwtjeAWLaqPEe/H8FB0DBAF3tn81dCy3ardr8NzUjrJXBFrz/mextk5PXLn
         gcrA==
X-Gm-Message-State: AOAM531dnUNE9BXQuYBfIi+1Ey4u2bE1gkq6HnT/NAqJ+ytIR6xW5+Sd
	gsI5b7Uvllsemt0Bcb5ArmX5SxlC5Q9SmR6a5KY=
X-Google-Smtp-Source: ABdhPJwWqWOOIthvQMcxh+SHWcOxHZ+QsTCUdnObEXwaDJo685Zyi78MnucQndd3bgLVNozgAZ47qi1G4SBUUvF5dso=
X-Received: by 2002:ac8:5d8e:0:b0:2f3:6073:7514 with SMTP id
 d14-20020ac85d8e000000b002f360737514mr19388343qtx.534.1651169051831; Thu, 28
 Apr 2022 11:04:11 -0700 (PDT)
MIME-Version: 1.0
References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-9-jgross@suse.com>
In-Reply-To: <20220428082743.16593-9-jgross@suse.com>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Thu, 28 Apr 2022 21:03:59 +0300
Message-ID: <CAPD2p-nisRgMOzy+w2jx5ULfZTyv4MqtG0wkV9jNn3wNg415sQ@mail.gmail.com>
Subject: Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Stefano Stabellini <sstabellini@kernel.org>
Content-Type: multipart/alternative; boundary="000000000000cc734505ddbac07d"

--000000000000cc734505ddbac07d
Content-Type: text/plain; charset="UTF-8"

On Thu, Apr 28, 2022 at 11:28 AM Juergen Gross <jgross@suse.com> wrote:

Hello Juergen

[sorry for the possible format issue]

Instead of using a private macro for an invalid grant reference use
> the common one.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  drivers/xen/xen-front-pgdir-shbuf.c | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/xen/xen-front-pgdir-shbuf.c
> b/drivers/xen/xen-front-pgdir-shbuf.c
> index a959dee21134..fa2921d4fbfc 100644
> --- a/drivers/xen/xen-front-pgdir-shbuf.c
> +++ b/drivers/xen/xen-front-pgdir-shbuf.c
> @@ -21,15 +21,6 @@
>
>  #include <xen/xen-front-pgdir-shbuf.h>
>
> -#ifndef GRANT_INVALID_REF
> -/*
> - * FIXME: usage of grant reference 0 as invalid grant reference:
> - * grant reference 0 is valid, but never exposed to a PV driver,
> - * because of the fact it is already in use/reserved by the PV console.
> - */
> -#define GRANT_INVALID_REF      0
> -#endif
> -
>  /**
>   * This structure represents the structure of a shared page
>   * that contains grant references to the pages of the shared
> @@ -83,7 +74,7 @@ grant_ref_t
>  xen_front_pgdir_shbuf_get_dir_start(struct xen_front_pgdir_shbuf *buf)
>  {
>         if (!buf->grefs)
> -               return GRANT_INVALID_REF;
> +               return INVALID_GRANT_REF;
>
>         return buf->grefs[0];
>  }
> @@ -142,7 +133,7 @@ void xen_front_pgdir_shbuf_free(struct
> xen_front_pgdir_shbuf *buf)
>                 int i;
>
>                 for (i = 0; i < buf->num_grefs; i++)
> -                       if (buf->grefs[i] != GRANT_INVALID_REF)
> +                       if (buf->grefs[i] != INVALID_GRANT_REF)
>                                 gnttab_end_foreign_access(buf->grefs[i],
> 0UL);
>         }
>         kfree(buf->grefs);
> @@ -355,7 +346,7 @@ static void backend_fill_page_dir(struct
> xen_front_pgdir_shbuf *buf)
>         }
>         /* Last page must say there is no more pages. */
>         page_dir = (struct xen_page_directory *)ptr;
> -       page_dir->gref_dir_next_page = GRANT_INVALID_REF;
> +       page_dir->gref_dir_next_page = INVALID_GRANT_REF;
>  }
>
>  /**
> @@ -384,7 +375,7 @@ static void guest_fill_page_dir(struct
> xen_front_pgdir_shbuf *buf)
>
>                 if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) {
>                         to_copy = grefs_left;
> -                       page_dir->gref_dir_next_page = GRANT_INVALID_REF;
> +                       page_dir->gref_dir_next_page = INVALID_GRANT_REF;
>


I faced an issue with testing PV Sound with the current series.

root@salvator-x-h3-4x2g-xt-domu:~# aplay /media/MoodyLoop.wav
Playing WAVE '/media/MoodyLoop.wav' : Signed 16 bit Little Endian, Rate
44100 Hz, Stereo
(XEN) common/grant_table.c:1053:d1v2 Bad ref 0xffffffff for d6

Here we have an interesting situation. PV Sound frontend uses this
xen-front-pgdir-shbuf framework. Technically, this patch changes
page_dir->gref_dir_next_page (reference to the next page describing page
directory) from 0 to 0xffffffff here.
#define INVALID_GRANT_REF  ((grant_ref_t)-1)

But according to the protocol (sndif.h), "0" means that there are no more
pages in the list and the user space backend expects only that value. So
receiving 0xffffffff it assumes there are pages in the list and trying to
process...
https://elixir.bootlin.com/linux/v5.18-rc4/source/include/xen/interface/io/sndif.h#L650


I think, the same is relevant to backend_fill_page_dir() as well.

                } else {
>                         to_copy = XEN_NUM_GREFS_PER_PAGE;
>                         page_dir->gref_dir_next_page = buf->grefs[i + 1];
> --
> 2.34.1
>
>
>

-- 
Regards,

Oleksandr Tyshchenko

--000000000000cc734505ddbac07d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Apr 28, 2022 at 11:28 AM Juer=
gen Gross &lt;<a href=3D"mailto:jgross@suse.com">jgross@suse.com</a>&gt; wr=
ote:<br></div><div dir=3D"ltr" class=3D"gmail_attr"><br></div><div class=3D=
"gmail_attr">Hello=C2=A0Juergen</div><div dir=3D"ltr" class=3D"gmail_attr">=
<br></div><div class=3D"gmail_attr">[sorry for the possible format issue]</=
div><div dir=3D"ltr" class=3D"gmail_attr"><br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex">Instead of using a private macro for an invalid =
grant reference use<br>
the common one.<br>
<br>
Signed-off-by: Juergen Gross &lt;<a href=3D"mailto:jgross@suse.com" target=
=3D"_blank">jgross@suse.com</a>&gt;<br>
---<br>
=C2=A0drivers/xen/xen-front-pgdir-shbuf.c | 17 ++++-------------<br>
=C2=A01 file changed, 4 insertions(+), 13 deletions(-)<br>
<br>
diff --git a/drivers/xen/xen-front-pgdir-shbuf.c b/drivers/xen/xen-front-pg=
dir-shbuf.c<br>
index a959dee21134..fa2921d4fbfc 100644<br>
--- a/drivers/xen/xen-front-pgdir-shbuf.c<br>
+++ b/drivers/xen/xen-front-pgdir-shbuf.c<br>
@@ -21,15 +21,6 @@<br>
<br>
=C2=A0#include &lt;xen/xen-front-pgdir-shbuf.h&gt;<br>
<br>
-#ifndef GRANT_INVALID_REF<br>
-/*<br>
- * FIXME: usage of grant reference 0 as invalid grant reference:<br>
- * grant reference 0 is valid, but never exposed to a PV driver,<br>
- * because of the fact it is already in use/reserved by the PV console.<br=
>
- */<br>
-#define GRANT_INVALID_REF=C2=A0 =C2=A0 =C2=A0 0<br>
-#endif<br>
-<br>
=C2=A0/**<br>
=C2=A0 * This structure represents the structure of a shared page<br>
=C2=A0 * that contains grant references to the pages of the shared<br>
@@ -83,7 +74,7 @@ grant_ref_t<br>
=C2=A0xen_front_pgdir_shbuf_get_dir_start(struct xen_front_pgdir_shbuf *buf=
)<br>
=C2=A0{<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!buf-&gt;grefs)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return GRANT_INVALI=
D_REF;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return INVALID_GRAN=
T_REF;<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 return buf-&gt;grefs[0];<br>
=C2=A0}<br>
@@ -142,7 +133,7 @@ void xen_front_pgdir_shbuf_free(struct xen_front_pgdir_=
shbuf *buf)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 int i;<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for (i =3D 0; i &lt=
; buf-&gt;num_grefs; i++)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0if (buf-&gt;grefs[i] !=3D GRANT_INVALID_REF)<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0if (buf-&gt;grefs[i] !=3D INVALID_GRANT_REF)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gnttab_end_foreign_access(buf-&gt;gr=
efs[i], 0UL);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 kfree(buf-&gt;grefs);<br>
@@ -355,7 +346,7 @@ static void backend_fill_page_dir(struct xen_front_pgdi=
r_shbuf *buf)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Last page must say there is no more pages. *=
/<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 page_dir =3D (struct xen_page_directory *)ptr;<=
br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0page_dir-&gt;gref_dir_next_page =3D GRANT_INVAL=
ID_REF;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0page_dir-&gt;gref_dir_next_page =3D INVALID_GRA=
NT_REF;<br>
=C2=A0}<br>
<br>
=C2=A0/**<br>
@@ -384,7 +375,7 @@ static void guest_fill_page_dir(struct xen_front_pgdir_=
shbuf *buf)<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (grefs_left &lt;=
=3D XEN_NUM_GREFS_PER_PAGE) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 to_copy =3D grefs_left;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0page_dir-&gt;gref_dir_next_page =3D GRANT_INVALID_REF;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0page_dir-&gt;gref_dir_next_page =3D INVALID_GRANT_REF;<br></block=
quote><div>=C2=A0</div><div><br></div><div>I faced an issue with testing PV=
 Sound with the current=C2=A0series.</div><div><br></div><div>root@salvator=
-x-h3-4x2g-xt-domu:~# aplay /media/MoodyLoop.wav<br>Playing WAVE &#39;/medi=
a/MoodyLoop.wav&#39; : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo</=
div><div>(XEN) common/grant_table.c:1053:d1v2 Bad ref 0xffffffff for d6<br>=
</div><div><br></div><div>Here we have an interesting situation. PV Sound f=
rontend=C2=A0uses this xen-front-pgdir-shbuf framework. Technically, this p=
atch changes page_dir-&gt;gref_dir_next_page (reference to the next page de=
scribing page directory) from 0 to=C2=A00xffffffff here.</div><div>#define =
INVALID_GRANT_REF=C2=A0 ((grant_ref_t)-1)<br></div><div><br></div><div>But =
according to the protocol (sndif.h), &quot;0&quot; means that there are no =
more pages in the list and the user space backend expects only that value. =
So receiving=C2=A00xffffffff it assumes there are pages in the list and try=
ing to process...=C2=A0=C2=A0</div><div><a href=3D"https://elixir.bootlin.c=
om/linux/v5.18-rc4/source/include/xen/interface/io/sndif.h#L650">https://el=
ixir.bootlin.com/linux/v5.18-rc4/source/include/xen/interface/io/sndif.h#L6=
50</a><br></div><div><br></div><div><br></div><div>I think, the=C2=A0same i=
s relevant to=C2=A0backend_fill_page_dir() as well.</div><div><br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef=
t:1px solid rgb(204,204,204);padding-left:1ex">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 to_copy =3D XEN_NUM_GREFS_PER_PAGE;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 page_dir-&gt;gref_dir_next_page =3D buf-&gt;grefs[i + 1];<br>
-- <br>
2.34.1<br>
<br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><span style=3D"background-color:rgb(255,255,255)"><font size=
=3D"2"><span style=3D"color:rgb(51,51,51);font-family:Arial,sans-serif">Reg=
ards,</span></font></span></div><div dir=3D"ltr"><br></div><div dir=3D"ltr"=
><div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2">Ol=
eksandr Tyshchenko</font></span></div></div></div></div></div></div></div><=
/div>

--000000000000cc734505ddbac07d--


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 18:13:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 18:13:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316742.535763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk8dn-0000Di-Fj; Thu, 28 Apr 2022 18:13:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316742.535763; Thu, 28 Apr 2022 18:13:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk8dn-0000Db-CN; Thu, 28 Apr 2022 18:13:23 +0000
Received: by outflank-mailman (input) for mailman id 316742;
 Thu, 28 Apr 2022 18:13:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk8dl-0000DR-Tf; Thu, 28 Apr 2022 18:13:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk8dl-0004CI-Rj; Thu, 28 Apr 2022 18:13:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk8dl-00079m-Km; Thu, 28 Apr 2022 18:13:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk8dl-0001WI-KI; Thu, 28 Apr 2022 18:13:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NgfUr7JLHrSu90beRzvwAZ40mtQUFBaFQyGjvBZKxuQ=; b=IhBic5t2BaTw9DH7t4KahFIki6
	Y4tKL0Mq6qYN3+DmPg+S8Vp3dHeFYxQcgNwyQKa+DemTO8a8XK3XmqHNuUQ9Ii1UAnOUhc+K9tqdk
	ZDILbix+p1BU+VutMDRGN4B8YD5w91K8yk3vhp6/o2cdECnVl11gnAH1KP+FRICY/guQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169828-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169828: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 18:13:21 +0000

flight 169828 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169828/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  682 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 19:11:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 19:11:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316752.535779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk9Xa-0006B3-Pk; Thu, 28 Apr 2022 19:11:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316752.535779; Thu, 28 Apr 2022 19:11:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nk9Xa-0006Aw-Mu; Thu, 28 Apr 2022 19:11:02 +0000
Received: by outflank-mailman (input) for mailman id 316752;
 Thu, 28 Apr 2022 19:11:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk9XZ-0006Am-0m; Thu, 28 Apr 2022 19:11:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk9XY-0005An-Vw; Thu, 28 Apr 2022 19:11:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nk9XY-0001zA-DT; Thu, 28 Apr 2022 19:11:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nk9XY-0002On-D2; Thu, 28 Apr 2022 19:11:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cu+7elJyLIFFlFfjO000YWxNKK1fLf1zrDpGOu/G6fI=; b=q/O1PLnbCGXbuIXntc07pL6xwx
	/bSxsFcLcUYi6E+SW3+qxN3d0b6lyzKoulG/fiMrA4LEaIlXXtemUlnbzdcHZUU/hZ+ws8HQmV5MT
	/r8UsrgLso8QZbJlHhL/5kFhnO1ojJPCX/T3lm7Y1w2034zPBmpx0sfz7lbTF98zR4r0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169824-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169824: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
X-Osstest-Versions-That:
    xen=da28439ba55b8a571032b3358af567cff749f612
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 19:11:00 +0000

flight 169824 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169824/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
baseline version:
 xen                  da28439ba55b8a571032b3358af567cff749f612

Last test of basis   169800  2022-04-27 23:01:43 Z    0 days
Failing since        169807  2022-04-28 09:01:41 Z    0 days    2 attempts
Testing same since   169824  2022-04-28 16:00:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tamas K Lengyel <tamas.lengyel@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   da28439ba5..d711a8e527  d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 21:02:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 21:02:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316763.535799 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkBHH-0008Ir-1E; Thu, 28 Apr 2022 21:02:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316763.535799; Thu, 28 Apr 2022 21:02:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkBHG-0008Ik-Ua; Thu, 28 Apr 2022 21:02:18 +0000
Received: by outflank-mailman (input) for mailman id 316763;
 Thu, 28 Apr 2022 21:02:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkBHF-0008Ia-K2; Thu, 28 Apr 2022 21:02:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkBHF-0007Dc-HS; Thu, 28 Apr 2022 21:02:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkBHF-0008Mc-2w; Thu, 28 Apr 2022 21:02:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkBHF-0007xn-2R; Thu, 28 Apr 2022 21:02:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6iCBQwfLagUsITzj2wWq2yBMQqt9E+nFPvuQSnTSrJ0=; b=lRh7+24LYUM4+WXY+S6HIZobIG
	0TqSA7qwEvL+uHv0KGf1r955zpZD4bowy+QsiMY71k/iATYOZB1XlM71qdGUP0V7G/i3VNQLkrn9R
	zeI1TItBkWJayc16+Yr7u1WENa0gG9eJyYJ7I+9XvyQY/pSd0VoCbKn8BL7IC5q2THzg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169832-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169832: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 21:02:17 +0000

flight 169832 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169832/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  683 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 21:23:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 21:23:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316772.535810 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkBby-0002Iv-VK; Thu, 28 Apr 2022 21:23:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316772.535810; Thu, 28 Apr 2022 21:23:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkBby-0002Io-SS; Thu, 28 Apr 2022 21:23:42 +0000
Received: by outflank-mailman (input) for mailman id 316772;
 Thu, 28 Apr 2022 21:23:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=b9z+=VG=kernel.org=kuba@srs-se1.protection.inumbo.net>)
 id 1nkBbx-0002Ii-AS
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 21:23:41 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 779aabb6-c739-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 23:23:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 0A2B561F02;
 Thu, 28 Apr 2022 21:23:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC2C6C385AF;
 Thu, 28 Apr 2022 21:23:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 779aabb6-c739-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651181016;
	bh=rE+qwrcYq1YEDwagHt9bw0Dmvq2A/QwK2cQtgGYtZKA=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=no38TJlgb9U2gYSmWW3vbaA67LL/vJLFz33ioGRUtsTQaNukvebyzJoIbnzNysdva
	 KeVy11OYbLms0RZ3OCVWmC+xIzqOfn4cjMDm4pXEPUwGkf5Vh/bq6EPFVjSZNRi8Gv
	 K0WQ0lU2C5coSTjh5mQUdihnE//IYsjUA9LCDzrZFBxUJp2TzIWq64l/nWeuA3hX63
	 ypdEVKeHmETEcBZWCrCA0t0YyCZK0T00ECwMMAFGHOBmb2U//n3oKsH9UQUKdcXHS8
	 YHwwOB9lDtjTbcbbhd9xkPV/5sO9bBltmTYBA0FJ6W+7hZe90XuCDtJphHHUX3s+mY
	 OpuwIG7FYctqA==
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net,
	pabeni@redhat.com
Cc: edumazet@google.com,
	netdev@vger.kernel.org,
	Jakub Kicinski <kuba@kernel.org>,
	ulli.kroll@googlemail.com,
	linus.walleij@linaro.org,
	mlindner@marvell.com,
	stephen@networkplumber.org,
	nbd@nbd.name,
	john@phrozen.org,
	sean.wang@mediatek.com,
	Mark-MC.Lee@mediatek.com,
	matthias.bgg@gmail.com,
	grygorii.strashko@ti.com,
	wei.liu@kernel.org,
	paul@xen.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-omap@vger.kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH net-next v2 01/15] eth: remove copies of the NAPI_POLL_WEIGHT define
Date: Thu, 28 Apr 2022 14:23:09 -0700
Message-Id: <20220428212323.104417-2-kuba@kernel.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220428212323.104417-1-kuba@kernel.org>
References: <20220428212323.104417-1-kuba@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Defining local versions of NAPI_POLL_WEIGHT with the same
values in the drivers just makes refactoring harder.

Drop the special defines in a bunch of drivers where the
removal is relatively simple so grouping into one patch
does not impact reviewability.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: ulli.kroll@googlemail.com
CC: linus.walleij@linaro.org
CC: mlindner@marvell.com
CC: stephen@networkplumber.org
CC: nbd@nbd.name
CC: john@phrozen.org
CC: sean.wang@mediatek.com
CC: Mark-MC.Lee@mediatek.com
CC: matthias.bgg@gmail.com
CC: grygorii.strashko@ti.com
CC: wei.liu@kernel.org
CC: paul@xen.org
CC: prabhakar.mahadev-lad.rj@bp.renesas.com
CC: linux-arm-kernel@lists.infradead.org
CC: linux-mediatek@lists.infradead.org
CC: linux-omap@vger.kernel.org
CC: xen-devel@lists.xenproject.org
---
 drivers/net/ethernet/cortina/gemini.c         | 4 +---
 drivers/net/ethernet/marvell/skge.c           | 3 +--
 drivers/net/ethernet/marvell/sky2.c           | 3 +--
 drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 +--
 drivers/net/ethernet/ti/davinci_emac.c        | 3 +--
 drivers/net/ethernet/ti/netcp_core.c          | 5 ++---
 drivers/net/xen-netback/interface.c           | 3 +--
 7 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
index 8014eb33937c..9e6de2f968fa 100644
--- a/drivers/net/ethernet/cortina/gemini.c
+++ b/drivers/net/ethernet/cortina/gemini.c
@@ -68,7 +68,6 @@ MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
 #define DEFAULT_GMAC_RXQ_ORDER		9
 #define DEFAULT_GMAC_TXQ_ORDER		8
 #define DEFAULT_RX_BUF_ORDER		11
-#define DEFAULT_NAPI_WEIGHT		64
 #define TX_MAX_FRAGS			16
 #define TX_QUEUE_NUM			1	/* max: 6 */
 #define RX_MAX_ALLOC_ORDER		2
@@ -2472,8 +2471,7 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
 	netdev->max_mtu = 10236 - VLAN_ETH_HLEN;
 
 	port->freeq_refill = 0;
-	netif_napi_add(netdev, &port->napi, gmac_napi_poll,
-		       DEFAULT_NAPI_WEIGHT);
+	netif_napi_add(netdev, &port->napi, gmac_napi_poll, NAPI_POLL_WEIGHT);
 
 	ret = of_get_mac_address(np, mac);
 	if (!ret) {
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index cf03c67fbf40..c1e985416c0e 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -50,7 +50,6 @@
 #define PHY_RETRIES	        1000
 #define ETH_JUMBO_MTU		9000
 #define TX_WATCHDOG		(5 * HZ)
-#define NAPI_WEIGHT		64
 #define BLINK_MS		250
 #define LINK_HZ			HZ
 
@@ -3833,7 +3832,7 @@ static struct net_device *skge_devinit(struct skge_hw *hw, int port,
 		dev->features |= NETIF_F_HIGHDMA;
 
 	skge = netdev_priv(dev);
-	netif_napi_add(dev, &skge->napi, skge_poll, NAPI_WEIGHT);
+	netif_napi_add(dev, &skge->napi, skge_poll, NAPI_POLL_WEIGHT);
 	skge->netdev = dev;
 	skge->hw = hw;
 	skge->msg_enable = netif_msg_init(debug, default_msg);
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index ea16b1dd6a98..a1e907c85217 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -63,7 +63,6 @@
 #define TX_DEF_PENDING		63
 
 #define TX_WATCHDOG		(5 * HZ)
-#define NAPI_WEIGHT		64
 #define PHY_RETRIES		1000
 
 #define SKY2_EEPROM_MAGIC	0x9955aabb
@@ -4938,7 +4937,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		}
 	}
 
-	netif_napi_add(dev, &hw->napi, sky2_poll, NAPI_WEIGHT);
+	netif_napi_add(dev, &hw->napi, sky2_poll, NAPI_POLL_WEIGHT);
 
 	err = register_netdev(dev);
 	if (err) {
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
index 4cd0747edaff..95839fd84dab 100644
--- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
+++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
@@ -30,7 +30,6 @@
 #define MTK_STAR_WAIT_TIMEOUT			300
 #define MTK_STAR_MAX_FRAME_SIZE			1514
 #define MTK_STAR_SKB_ALIGNMENT			16
-#define MTK_STAR_NAPI_WEIGHT			64
 #define MTK_STAR_HASHTABLE_MC_LIMIT		256
 #define MTK_STAR_HASHTABLE_SIZE_MAX		512
 
@@ -1551,7 +1550,7 @@ static int mtk_star_probe(struct platform_device *pdev)
 	ndev->netdev_ops = &mtk_star_netdev_ops;
 	ndev->ethtool_ops = &mtk_star_ethtool_ops;
 
-	netif_napi_add(ndev, &priv->napi, mtk_star_poll, MTK_STAR_NAPI_WEIGHT);
+	netif_napi_add(ndev, &priv->napi, mtk_star_poll, NAPI_POLL_WEIGHT);
 
 	return devm_register_netdev(dev, ndev);
 }
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index 9d1e98db308b..2a3e4e842fa5 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -113,7 +113,6 @@ static const char emac_version_string[] = "TI DaVinci EMAC Linux v6.1";
 #define EMAC_DEF_RX_NUM_DESC		(128)
 #define EMAC_DEF_MAX_TX_CH		(1) /* Max TX channels configured */
 #define EMAC_DEF_MAX_RX_CH		(1) /* Max RX channels configured */
-#define EMAC_POLL_WEIGHT		(64) /* Default NAPI poll weight */
 
 /* Buffer descriptor parameters */
 #define EMAC_DEF_TX_MAX_SERVICE		(32) /* TX max service BD's */
@@ -1949,7 +1948,7 @@ static int davinci_emac_probe(struct platform_device *pdev)
 
 	ndev->netdev_ops = &emac_netdev_ops;
 	ndev->ethtool_ops = &ethtool_ops;
-	netif_napi_add(ndev, &priv->napi, emac_poll, EMAC_POLL_WEIGHT);
+	netif_napi_add(ndev, &priv->napi, emac_poll, NAPI_POLL_WEIGHT);
 
 	pm_runtime_enable(&pdev->dev);
 	rc = pm_runtime_resume_and_get(&pdev->dev);
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index 16507bff652a..21b0e961eab5 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -24,7 +24,6 @@
 #include "netcp.h"
 
 #define NETCP_SOP_OFFSET	(NET_IP_ALIGN + NET_SKB_PAD)
-#define NETCP_NAPI_WEIGHT	64
 #define NETCP_TX_TIMEOUT	(5 * HZ)
 #define NETCP_PACKET_SIZE	(ETH_FRAME_LEN + ETH_FCS_LEN)
 #define NETCP_MIN_PACKET_SIZE	ETH_ZLEN
@@ -2096,8 +2095,8 @@ static int netcp_create_interface(struct netcp_device *netcp_device,
 	}
 
 	/* NAPI register */
-	netif_napi_add(ndev, &netcp->rx_napi, netcp_rx_poll, NETCP_NAPI_WEIGHT);
-	netif_tx_napi_add(ndev, &netcp->tx_napi, netcp_tx_poll, NETCP_NAPI_WEIGHT);
+	netif_napi_add(ndev, &netcp->rx_napi, netcp_rx_poll, NAPI_POLL_WEIGHT);
+	netif_tx_napi_add(ndev, &netcp->tx_napi, netcp_tx_poll, NAPI_POLL_WEIGHT);
 
 	/* Register the network device */
 	ndev->dev_id		= 0;
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index fe8e21ad8ed9..8e035374a370 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -42,7 +42,6 @@
 #include <xen/balloon.h>
 
 #define XENVIF_QUEUE_LENGTH 32
-#define XENVIF_NAPI_WEIGHT  64
 
 /* Number of bytes allowed on the internal guest Rx queue. */
 #define XENVIF_RX_QUEUE_BYTES (XEN_NETIF_RX_RING_SIZE/2 * PAGE_SIZE)
@@ -739,7 +738,7 @@ int xenvif_connect_data(struct xenvif_queue *queue,
 	atomic_set(&queue->inflight_packets, 0);
 
 	netif_napi_add(queue->vif->dev, &queue->napi, xenvif_poll,
-			XENVIF_NAPI_WEIGHT);
+			NAPI_POLL_WEIGHT);
 
 	queue->stalled = true;
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 21:30:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 21:30:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316778.535822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkBiS-0003i2-NK; Thu, 28 Apr 2022 21:30:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316778.535822; Thu, 28 Apr 2022 21:30:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkBiS-0003hv-Jd; Thu, 28 Apr 2022 21:30:24 +0000
Received: by outflank-mailman (input) for mailman id 316778;
 Thu, 28 Apr 2022 21:30:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=noDR=VG=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nkBiQ-0003hU-N0
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 21:30:23 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 67395c57-c73a-11ec-8fc3-03012f2f19d4;
 Thu, 28 Apr 2022 23:30:20 +0200 (CEST)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23SJjjNs015405;
 Thu, 28 Apr 2022 21:30:16 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmb9aw6yv-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Apr 2022 21:30:15 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23SLFCpP012117; Thu, 28 Apr 2022 21:30:14 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3fm7w7a5su-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Apr 2022 21:30:14 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by DS7PR10MB5182.namprd10.prod.outlook.com (2603:10b6:5:38f::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 28 Apr
 2022 21:30:12 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022
 21:30:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67395c57-c73a-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=wR1muW8sQEWzfVvqyniF2laqh35oLxdZteeYDYHZRW4=;
 b=LNMzmDwNivdInQtq5bzJKyQLGC/mgYnOoFOXoOJ51rqxqhMUFUHGirgP9RYO3KGEUuC6
 fM4lpnxuLGjgB5UIp+DQoe/xuBNJ77cOOAzsp0nrrFL6PtuwZh4nQIuMPzQC5Pmz1QRk
 YbnZUYRTlkxoBu8gRqFvAu+B+OCKssvKby6TlWcLAvtSi2OIrtZ8mhP2sa9g0MnHMPk9
 IHwfjOi9XR6jcGuHiOv2cDVoV8g8yokvdhUnUQXJbKbQzdnWjy4QNWbi9ZwDor0f7RA1
 rC3L8NDZeIkQ0wRAAkLxJx7ExCcb0kuZxipC14eaJh+UZN6i1TG+umHPFF98edqBThn3 2w== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K0vTOd7meOALC6F9TUO1WChJSUs0R2RyMVHNtZA1bY0ySTgjODzeS7MYKuoVRy+SeZ+fuQfds/m+baLoPt3koXHJf6+fW2HH/vBaTyJrlft5qyJld237LCAxI7krsjflovUlD9QQxl1Aavwq4LCKN+iV0vrn1/1SWhdS0EBI5vi5OfTLJznqJTdBNxcJyf24/ROLMQbj8TUmtRv6KrRWybU4XxxnV1IsheXuhHdjQLYQbVU7ihF3sXSbd1S4unfINC0wk8dmcvMx7f7i5/FrxR+qAPBe2AmrTLY6cARIxE1RUztvqYgV9QtHS5FTZe41xvdM6VUJkZH7OxXK7yZiXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wR1muW8sQEWzfVvqyniF2laqh35oLxdZteeYDYHZRW4=;
 b=SrsvsQCMNHdrK0S1qoYhhmH/KlmFYzbkT4BUplZk6p9J2g9VznKFm1VLfe95I7BPZR/hqH3hT39ngtp2oIxvprtVZIzD+h/6FEk1UX8/nnBOqpczpxQ9O3pS/hw32vfA7RNsApScXMaWch+YFFWiHQysL8bmQ2FZohnKdP3wFucjAUblio1bej9qSdPXW1sasQ3YR54Xj0kXrV/tvLa8EIczq5zDFSrQilvCjUaW34NTUyjv36XOBfF4GFSFYDTSnxWOiUGn793n/OlVidI62NnlU9rXKwBABcr0T3GsilOdKUClmkbrz81heYwD/K0WzDAgLVWf9+zXno2nCsb/LQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wR1muW8sQEWzfVvqyniF2laqh35oLxdZteeYDYHZRW4=;
 b=lsOowuyuDxmLSVI3mW0tSm5QoY7yQ5b4vTQn6T03HdSO6PNJbfs/bH5jklCsFr5hI9od0epraGNZ8gWYyVr9bw/6nVjfJtzbQz8OICB1MVOEF5PEWuTXvP/HMoy/lJwpmXEj/PMF2qVH2C5VgwimXg8ZPQn3XHg2dYS83pFFIHE=
Message-ID: <309bea05-2247-d451-3548-c824333a83f9@oracle.com>
Date: Thu, 28 Apr 2022 17:30:09 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: x86/PV: (lack of) MTRR exposure
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
        =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>
References: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: MN2PR08CA0028.namprd08.prod.outlook.com
 (2603:10b6:208:239::33) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5e3fe2c9-db6d-4356-ec75-08da295e46e1
X-MS-TrafficTypeDiagnostic: DS7PR10MB5182:EE_
X-Microsoft-Antispam-PRVS: 
	<DS7PR10MB5182634CFC25F64E126F9F4E8AFD9@DS7PR10MB5182.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	jvxYozBL6OawxmFqY5HIN+rbVz3Ip2omv8rlDSSDFnAoan8k04eehxr1aFiDK/08jD0OSgY1opcpuQRnWAhWXWDtQNkCJITERwlcaxlscNLEzquinqbq3YJ7Ueb5u4wTB2hv6FykhkU54mmycX3H2s7l//J1K5QuESZd2BhY9STVx7mpHcUib5QKX0Qa+8FdjJZxub4vPJzCLHnJgs9/2T5TGOXXJVFZRTojRID7xnurLRt9M2E5odaDIAmjs6HWdmgjHFFA6wfnCHiWfF8zA6WPVnZ6WrpTh/eYPsKTabK5HVC5RSR5ZlXDCbgaMv1JWNP27u3RSQ/HFN0GXY5CtpqlS+QchNZlV/mp1bGKX9679TC7viQhd/tctnqQrCJ97LkKfIW0pHXpZkByog0VtNZ9xJZw84fs044DEtj2fJpN30MyP5nJh11RUlfRaPxwlT0GYpemZY8VNW3+EaNwye2Vw5I0dJtLcp21qsz9dIU9/AKC+7JIbOapFPONw7koipRnudHfRh5E0Li8234L5Hr1kgVpV924Ksxv22HS24c8JTrk83yN9FEb3y43xSTts4uis6vtTxBsGLLsk9ZrJ+go5ktXU54Z7bYnPVOIvRQJ3H4onAj5iuwN21CBbvsAKYcIo/i3FX5UG+vru7ngMCykQTzrVx1R+v2W3I/3j8Txtby8HTO2LdF2RzxkuZ/KsC++SXjaeDygVN5U2H2yaFY5T/y9hE1Feh34z3NCBkJk+VyRwZdkOAI0hYafyJvzbysQzyAfTvorr3iPV3BD/MDsDzvqU/1r6rdQeh8jI1Zp5lx873zf7RDxK70N+r8ebMBJt2S1lxAOGfVApdq79w==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6486002)(6506007)(2616005)(44832011)(8936002)(5660300002)(36756003)(31686004)(83380400001)(186003)(86362001)(26005)(31696002)(38100700002)(6512007)(6666004)(966005)(8676002)(508600001)(66556008)(66946007)(66476007)(2906002)(4326008)(316002)(110136005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Zk5EZ1JhN2JjbzRVUGJIKzF3TGNOblYrUVRsSklKR2UzNGpkNHlETENLSDJV?=
 =?utf-8?B?azNQejZiNnZFekRIOXFnQzdWbFg1L3loSjljVllZQ256bW0walJpcWFnNkFk?=
 =?utf-8?B?UnBPNG1OajNTcHVTVGtXY3BMTUpacy9XOUF2Y2I3YVZEbXVkY2I3eXk5bkZV?=
 =?utf-8?B?NVlib01RQXZsWnpyanF1czBVRFdCNjU3NVVDS0hjem1CZzB6Nk9oUG9JQ05i?=
 =?utf-8?B?NjJJREs2eDZUcng1SUUvMktzVDNLdXo1cTZYcTB0Z0pOVUZMSDYrVmRkZ3py?=
 =?utf-8?B?L2FRQ2F0VG4yZHV5aHdFM2pENW9zYk1HbVVUM3d3UzFFWFdXZWN6cGx5eER3?=
 =?utf-8?B?OThWL3ZoT1RZbU43RTFwTnpZdkVTSTh5UEtUWW1OcjJEZUx5WE1SSFJ1bHFI?=
 =?utf-8?B?M0NvM3ZBZ3ZYc1J3U1FGSVZiN1E3c3dpbnROSmFub0x3Y2ZaT2wzamY3U044?=
 =?utf-8?B?NUliZDdMZ3JVNWNIR09uUktrRDM1SHk4VGV0Y0J0eGdNNCtkZ2xhU1EyWE5y?=
 =?utf-8?B?VFIrMy9hZCs4LzFnRGQwcVpJUGlqdUk4WmQwNGFlZ1huNmpzbml6b3BudWdy?=
 =?utf-8?B?M1h5U3NpTFBQQk5xTElkMThaRVYwK1pqWjl4Y2JyM0ZFaDB1V2FBNzZEUjlY?=
 =?utf-8?B?MUZmRTlQS29aVHV2VWpVeTFxeGVBMXBqS1FPMUk3SnlBMW1YV1pTTkU2bnU1?=
 =?utf-8?B?SnBvamx4TXRJY1JRcnNQOFZJQzdZVUNmUTErZ1p0dm1UVnZHU3pPS2hscEls?=
 =?utf-8?B?U3NtdHFwUlhsd2o5SnZKdEZsRFV3KzRFdzNlMm5SYm1PTGZHczVsQWJ0cVAv?=
 =?utf-8?B?dDlKUE9vN2Q4VzdybnJuSDgxcVdVU2I2QkpvZ1ZYaE5KZVo2ZDVkOFp0akg4?=
 =?utf-8?B?akwrTm81cFNIL0hNVGdHMEJsZE5kclNxMFRiTmxlQVYydzFrSHZZRFRPaEY2?=
 =?utf-8?B?N0ZJUmxsUG4waDJIekxuWi9leG82RGl0K0J0TEd6dHlvZ3JBMHlqbU5SNnR1?=
 =?utf-8?B?cHExQ0JwSUtqUGdUcmhlZE5DNllWckRXemdJQkhISmRnTW9iUUt3WkhxM2Na?=
 =?utf-8?B?aGlDYVFkdmpyY2lUclJwNkpqN2lKbW5yS3I4VmF5RkszcjFGYmMyTXFhNDR5?=
 =?utf-8?B?VXFEdDFuQ2h4Q01tNjBFajkrUlVVWXhSelowOWEzY2ZqOHZRRklpanh5alNX?=
 =?utf-8?B?N2xwZ2t3MkFHdmNzN3phbzNKcTVGRnB2UEVrTnphMHR4ZzljRUc5WTJpN2J3?=
 =?utf-8?B?ZGN4TXhDQ3VKa3VPQnBzZmt4MEQ4R3ZrYWc2WlpFdC9GSG5WdlgyTHN0SG9s?=
 =?utf-8?B?bHlQSTVtV2RpdC83YTgvV25sRWFnZ2dGU202QS9jMzZLZS90bUR6bzR3VXdT?=
 =?utf-8?B?Wno4eFFaTnBZNTdCOExYcnNsMnhJUzMrbm1McVlOMk95SU9kZ2w2T0NoTkJh?=
 =?utf-8?B?aEt5amNDaEVDMmk5SElGcDVJL0hBYWlSWVQxajgxYXJaYytQWkJsanpnVisx?=
 =?utf-8?B?OHFnWXRzdGtXM3ZsY1hrY0RDTDlQRzUvV1JOZ2RjankzQkFoTnJ5aktLNXlY?=
 =?utf-8?B?cy9tVmV6enpRMGdOeU5lWW5kcTE5ZXVTSDV2RE51TTBSRHJFWUpxYk8wWWdR?=
 =?utf-8?B?U0JXUHNFLzFwMnE1cTFadVkyZTVMTytxNzM1RCtCUS9rT0VmTG5YQ0FHN0Q3?=
 =?utf-8?B?WEpVczJ2RGJucDJzSUxqZFBKeGJwdGU3bFRqczlDTU84OGtGKy9JakpWdjNQ?=
 =?utf-8?B?c1ZwbDZQV0M4dEQ1QzhiQlNjenpOSVUxUWhKQjliT0hhOVQxRTZuR0FsMjVq?=
 =?utf-8?B?TEN1RFdNQ1prR0REQnV4RGxmWitLaVNSWlZaM2dhbXpMNzJDTi9oR0dHbUpS?=
 =?utf-8?B?UFE4aktOTUwvaXJnMFhUTTFXTkhRRTVZazdBekJEN01zRU5MKzMzQi81TFFq?=
 =?utf-8?B?ME1Kb3AvSDVYcVlMbjJDWnFiLzBOWnFBRzBvU21HaDZNYkVYNWExdFo4TytK?=
 =?utf-8?B?eXNGYkU0NG40QkFLQ3ZUN01kM09LUGE2VlpzUTVSZnAwY2JMcHEzdm9TWWhR?=
 =?utf-8?B?Ujh1MHY1ZG9vd3AvbEgxV2lzbzNmMHNJUFVFaTJhWE9HS0hFUGdIN2FGVXZB?=
 =?utf-8?B?Q280RDJZTFdrdU5LNjdaUkJCSEJjbzJEVnE2bytBWktIZnZGeHdEbmVjcWxo?=
 =?utf-8?B?b3pub0lvbjBFRWlRMVJFSlpSbHVUajlTQVd6TERoZGNkd0RNNC9YWGloN21Q?=
 =?utf-8?B?NFdQdElCWE0zdEY2VjhqZWNTQ3RrQVpsUlRJYXpHUkliNjJhNXlqdzJEU1o1?=
 =?utf-8?B?R2t6MFppVk1iZ1N1WnFhZGJXRzdPMVNHTXZGbmFUSWVVNnBCd01MZ21WdE5o?=
 =?utf-8?Q?A/ujgNWXVNCvw4Dk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e3fe2c9-db6d-4356-ec75-08da295e46e1
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 21:30:12.0315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: csqvwkSIVawYjmlXEfaSe7e7jYvqTtgTjrLhsuSOBdO5bv5HE4LTKUDW6J66TBLLtbWBlhnXwG4+C3hYpyo9AY+sM8UHAE+MxZJj0x6n5/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5182
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-28_04:2022-04-28,2022-04-28 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204280126
X-Proofpoint-ORIG-GUID: vcPi40YZTQFp2_4FffQjvFCbarquqMSj
X-Proofpoint-GUID: vcPi40YZTQFp2_4FffQjvFCbarquqMSj


On 4/28/22 11:53 AM, Jan Beulich wrote:
> Hello,
>
> in the course of analyzing the i915 driver causing boot to fail in
> Linux 5.18 I found that Linux, for all the years, has been running
> in PV mode as if PAT was (mostly) disabled. This is a result of
> them tying PAT initialization to MTRR initialization, while we
> offer PAT but not MTRR in CPUID output. This was different before
> our moving to CPU featuresets, and as such one could view this
> behavior as a regression from that change.
>
> The first question here is whether not exposing MTRR as a feature
> was really intended, in particular also for PV Dom0. The XenoLinux
> kernel and its forward ports did make use of XENPF_*_memtype to
> deal with MTRRs. That's functionality which (maybe for a good
> reason) never made it into the pvops kernel. Note that PVH Dom0
> does have access to the original settings, as the host values are
> used as initial state there.


Initially MTRR was supposed to be supported but it was shot down by x86 maintainers who strongly suggested to use PAT.


https://lists.xen.org/archives/html/xen-devel/2010-09/msg01634.html


-boris


>
> The next question would be how we could go about improving the
> situation. For the particular issue in 5.18 I've found a relatively
> simple solution [1] (which also looks to help graphics performance
> on other systems, according to my initial observations with using
> the change), albeit its simplicity likely means it either is wrong
> in some way, or might not be liked for looking hacky and/or abusive.
> We can't, for example, simply turn on the MTRR bit in CPUID, as that
> would implicitly lead to the kernel trying to write the PAT MSR (if,
> see below, it didn't itself zap the bit). We also can't simply
> ignore PAT MSR writes, as the kernel won't check whether writes
> actually took effect. (All of that did work on top of old Xen
> apparently only because xen_init_capabilities() itself also forces
> the MTRR feature to off.)
>
> Jan
>
> [1] https://lists.xen.org/archives/html/xen-devel/2022-04/msg02392.html
>


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 21:44:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 21:44:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316784.535833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkBwJ-0005Fz-Tv; Thu, 28 Apr 2022 21:44:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316784.535833; Thu, 28 Apr 2022 21:44:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkBwJ-0005Fs-Qw; Thu, 28 Apr 2022 21:44:43 +0000
Received: by outflank-mailman (input) for mailman id 316784;
 Thu, 28 Apr 2022 21:44:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkBwI-0005Fi-Lc; Thu, 28 Apr 2022 21:44:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkBwI-0007yZ-HS; Thu, 28 Apr 2022 21:44:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkBwH-0001i1-U1; Thu, 28 Apr 2022 21:44:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkBwH-0000Fd-TY; Thu, 28 Apr 2022 21:44:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=REGr7b6DA7idb0Tim+lWOyQ85QNFPX2ih78uTLc+oAI=; b=D8JG+FUJIkwFqP22+vTQ73VZFa
	7oxJSeHTBDsyHiZbBrZHXHvHuxZo95lwMWGqBI59RDmRf+zTUbT05upqKT22v+FYDKq9rlWWupS0B
	EKxdtGC9kECcJkNOtuoTyBEH+o4km3HjuH8K5Ka0ED5AcOiNr++Tkq1oTgASBEcI5khg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169809-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169809: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=8f4dd16603ce834d1c5c4da67803ea82dd282511
X-Osstest-Versions-That:
    linux=e4d8a29997731b3bb14059024b24df9f784288d0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 21:44:41 +0000

flight 169809 linux-linus real [real]
flight 169833 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169809/
http://logs.test-lab.xenproject.org/osstest/logs/169833/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169833-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169792
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169792
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169792
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169792
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169792
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169792
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169792
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169792
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                8f4dd16603ce834d1c5c4da67803ea82dd282511
baseline version:
 linux                e4d8a29997731b3bb14059024b24df9f784288d0

Last test of basis   169792  2022-04-27 19:09:50 Z    1 days
Testing same since   169809  2022-04-28 09:42:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akira Yokosawa <akiyks@gmail.com>
  Andrew Morton <akpm@linux-foundation.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Zqiang <qiang1.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e4d8a2999773..8f4dd16603ce  8f4dd16603ce834d1c5c4da67803ea82dd282511 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 21:49:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 21:49:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316793.535843 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkC0j-0005xx-LI; Thu, 28 Apr 2022 21:49:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316793.535843; Thu, 28 Apr 2022 21:49:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkC0j-0005xq-ID; Thu, 28 Apr 2022 21:49:17 +0000
Received: by outflank-mailman (input) for mailman id 316793;
 Thu, 28 Apr 2022 21:49:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NTp2=VG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkC0i-0005xk-Dh
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 21:49:16 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0b864178-c73d-11ec-a405-831a346695d4;
 Thu, 28 Apr 2022 23:49:15 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C0C6E61F8C;
 Thu, 28 Apr 2022 21:49:13 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A082EC385AD;
 Thu, 28 Apr 2022 21:49:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b864178-c73d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651182552;
	bh=N7ZQRSxaxRoMXrt1DERfRx93WB3JcFzn7TVVB0S9qmw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=aNKDR2lwKqqTjZzHIfPg3iPMrs4H0KuqbdLlT/nvVSOTZ7MivpG44bUt6Czd5lkJU
	 1rGVYKsyXEY+5EvR9fdWwk14DhvVPsqJ57IhUp7KLUL8p+1SYGiBwsMckVcQ6865FL
	 VnJ3PKysn2MJwr3sURNXf1JCJc7Dt/yBD7oMjH0VncXglu7gWWixMJpgXZGaukPc/J
	 aLvu6wiQI7SLTpiJNsBE68CHAJOMV/3bhZAIQmLyS1nvEWL2MsIxSaK8nuYPvwMFTR
	 1AF7toPAqGQneikfdGm54reUsJLy4w0ZccgDiGAaTc/FtSjXMVsmlx9w3IhvcPxkt2
	 +OkWezDq+J65Q==
Date: Thu, 28 Apr 2022 14:49:11 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Christoph Hellwig <hch@lst.de>
cc: Stefano Stabellini <sstabellini@kernel.org>, jgross@suse.com, 
    xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, 
    iommu@lists.linux-foundation.org, Rahul Singh <Rahul.Singh@arm.com>, 
    boris.ostrovsky@oracle.com
Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
In-Reply-To: <20220428132737.GA13999@lst.de>
Message-ID: <alpine.DEB.2.22.394.2204281449060.915916@ubuntu-linux-20-04-desktop>
References: <20220423171422.1831676-1-hch@lst.de> <alpine.DEB.2.22.394.2204261605420.915916@ubuntu-linux-20-04-desktop> <20220428132737.GA13999@lst.de>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 28 Apr 2022, Christoph Hellwig wrote:
> On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote:
> > > Reported-by: Rahul Singh <Rahul.Singh@arm.com>
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> Do you want to take this through the Xen tree or should I pick it up?
> Either way I'd love to see some testing on x86 as well.

I agree on the x86 testing. Juergen, Boris?

I'd say to take this patch via the Xen tree but Juergen has just sent a
Xen pull request to Linux last Saturday. Juergen do you plan to send
another one? Do you have something else lined up? If not, it might be
better to let Christoph pick it up.


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 22:34:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 22:34:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316799.535854 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkCiK-0002W9-W9; Thu, 28 Apr 2022 22:34:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316799.535854; Thu, 28 Apr 2022 22:34:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkCiK-0002W2-Su; Thu, 28 Apr 2022 22:34:20 +0000
Received: by outflank-mailman (input) for mailman id 316799;
 Thu, 28 Apr 2022 22:34:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkCiJ-0002Vs-Mh; Thu, 28 Apr 2022 22:34:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkCiJ-0000PX-JQ; Thu, 28 Apr 2022 22:34:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkCiJ-0003df-52; Thu, 28 Apr 2022 22:34:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkCiJ-0002vE-4c; Thu, 28 Apr 2022 22:34:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0RcZug5daahI6LmG3C2c+bDd8r7xZI+6Td9R4eC5nb0=; b=sYKUazf58m6s+MynfDQjkVs5xn
	5YY8w439U2gIifzuwzzHEorAiYerr0KE06h7cVtZVsJadDyh6hPRbNP8i1o1LbuOWPWI8ySY8CNPm
	sLNW1GDNn9CcOA5cAWuBbAgCACYKJXolVI2Lz8nttgfeaqQlInM5mKvdUF8ylmP4fqek=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169835-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169835: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 22:34:19 +0000

flight 169835 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169835/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  684 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 22:47:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 22:47:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316808.535869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkCux-00043G-6A; Thu, 28 Apr 2022 22:47:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316808.535869; Thu, 28 Apr 2022 22:47:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkCux-000439-2v; Thu, 28 Apr 2022 22:47:23 +0000
Received: by outflank-mailman (input) for mailman id 316808;
 Thu, 28 Apr 2022 22:47:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=noDR=VG=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nkCuv-000433-Iy
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 22:47:21 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 27a93110-c745-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 00:47:18 +0200 (CEST)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23SIUvo3032115;
 Thu, 28 Apr 2022 22:47:07 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmb104sur-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Apr 2022 22:47:07 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23SMUdnV002558; Thu, 28 Apr 2022 22:47:05 GMT
Received: from nam10-bn7-obe.outbound.protection.outlook.com
 (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3fp5yph5ax-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Apr 2022 22:47:05 +0000
Received: from CH0PR10MB5020.namprd10.prod.outlook.com (2603:10b6:610:c0::22)
 by DM5PR10MB1740.namprd10.prod.outlook.com (2603:10b6:4:8::18) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.15; Thu, 28 Apr 2022 22:47:03 +0000
Received: from CH0PR10MB5020.namprd10.prod.outlook.com
 ([fe80::597f:1669:9247:7737]) by CH0PR10MB5020.namprd10.prod.outlook.com
 ([fe80::597f:1669:9247:7737%7]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022
 22:47:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27a93110-c745-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=RaQyqZm/KdFVXB0j5behBlzj3ppa9vPPyMzTd64Jn9I=;
 b=jpKVauZazIgLAdqgA6kuI+KQtPfWYu7Es4uIbNfW5Yg5Xj1YDkOnmeGqR05qJGYKCc/T
 vDhYb6CGYB6df6Ct0VrNOSZhmmiHGSJhZ+NAk+VtmF3dJ4gJNleRZVjjLG5+WrnR5JEW
 LE2rKpKhjZI/oHJlNB4llDku/Cw05Jgi3EmmYWEDbl4x5Or1LfOfz61t1CeEL9UXfQid
 o7wCyTnviZjow7PjiP58CzSy35cseWMkaHv9coiHNrOu/KhxA+AQU4fT8lEwj/cir4A6
 ky54qu+mRixKM1LuGpAXuao84+MOOz2jJe41ZYbe8gzClGRGKHhzETs8bs0zoJNjtQ/r Iw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UgSPkZ31SKLotI2wwz0xnj8pZi4HiOmG79F5/yhNVspVjp+24t54pbHKn4kVGQB+8UFN+iGvIK9l5ORoLud/PlEB7/4JTuoIMNUTvmiYqC8O9sjzto/JZKWByu5EPaVpN1R/PRAOXkY+PLcMfPMdZ7w6M73uWiNFQYD69Wi+UemzEkrgTxbml8cug7ZcvIUcp2zW/eY+jgH4xc6C8me8Niq7RGzpdn2Anc0GVLKV/10kP4q/+ldURAOz2HBVyQHS8HHKQJI88GIF8/BwNWen1G2/Ws6TAaFGzcREB0tWppbf/5C6SW9qd22rtGAmlaPSB3AHd7kOO7qp9Hp0GLHimg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RaQyqZm/KdFVXB0j5behBlzj3ppa9vPPyMzTd64Jn9I=;
 b=I/A6gSPJSggJZ/GcBfcKt2uwJqKH9ILJXlvRCjME4jE/GxRwK9PhS+hg/6SUVlK6l+mO7nYBbwKQxGehJs2hYgdpbVOIsvAUxjIf95cO4aqD6IqgclRgBBXG8IiMg71JeJjDJF7Dyz1eJBMl/SVQEDb2z9OPL8Pa+ZGdI8ES1bFVnYiyYSXctQCFI/mC0yIUro1KWS+a6UyDncNyM8REjyZGiPykmSWp176oZO9FTzx9luux6CWabhUr7CVHX1RnZtlTQhyNVdBVd7UoyXQaNPgj+17Hh72zNgpE1kTrub9UCwem49/g7Unwqq3IX3RE22rhIPQYYW7xAVZ2JwvCqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RaQyqZm/KdFVXB0j5behBlzj3ppa9vPPyMzTd64Jn9I=;
 b=BUIYMf2hXtcWUpAPjWlvhwVDWTbp2RMm5BLC+IgJPWjl7mwfFG5vJid2ibTVKSzggxEkaK36C33GKhhTqJRNvK0hRfY+7Q8CojSeWtRsJgn561zQQdnkAq0wdqxgdq7XHU9Gr+VvjHy1RZN2S/EDUK/2DNpnOdJ/7XfXlNrFx9k=
Message-ID: <27d39d5a-3b79-bdda-b7e4-f4477667919f@oracle.com>
Date: Thu, 28 Apr 2022 18:47:00 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
        Christoph Hellwig <hch@lst.de>
Cc: jgross@suse.com, xen-devel@lists.xenproject.org,
        linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org,
        Rahul Singh <Rahul.Singh@arm.com>
References: <20220423171422.1831676-1-hch@lst.de>
 <alpine.DEB.2.22.394.2204261605420.915916@ubuntu-linux-20-04-desktop>
 <20220428132737.GA13999@lst.de>
 <alpine.DEB.2.22.394.2204281449060.915916@ubuntu-linux-20-04-desktop>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <alpine.DEB.2.22.394.2204281449060.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: MN2PR06CA0007.namprd06.prod.outlook.com
 (2603:10b6:208:23d::12) To CH0PR10MB5020.namprd10.prod.outlook.com
 (2603:10b6:610:c0::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cdacc79e-b164-429c-14fd-08da29690344
X-MS-TrafficTypeDiagnostic: DM5PR10MB1740:EE_
X-Microsoft-Antispam-PRVS: 
	<DM5PR10MB1740508C662D3FFACDDE4E8D8AFD9@DM5PR10MB1740.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	QpsZTpP6qyKqCaoEAaI/jXTncRen3gwXmAaB+BM90gjt6/IC8u2o3KTxrPgkfz+zUtyyX/ICml4Btb8W+FOxmQMNpvShUrjD+jogRWBtlqItNEXMKmDZn1h43NXSZ9mPt8GQV8gPozF57ojzrltgA2raJZEhGts8hdE1gqNFE83IvBf+fmKScrxxOUpPYvufMeT8sk8Err+L1C5X7nT0fUZUSfabFjr4caVflVxyT4IvIiGWluqpsIUbotKnl7HYy4fpnhmZH6cSr91Gtzw/z/H7TPf9+Mv4LT7N1JLUFDs83X6rZXhnKgaAyx95hYefWMS8Whfb8sanefrjAT5RKHNVpw4maLgCllTteIiZEJFNVK21FnFBO4mUWL50PCY508wW4R5EvaEbtP6ghKM4LZqI0kRO0OpypaAU0YBylc1KLvfz6LPltJmpBM5kIjvqlVAgxT/WhopjZQp/32Y/dzajqcsh1rfAGLhDOpN0RmpjGjIS+2zwXbw4beuWDs3NBjTQIJZ1Dlw3ZkhhudQJbh9a7cDJbuFN7oaR/sbYfrrP5dzYgh2zv7qLbu3L1tG/BZCXQIyUVPHERnjHZFUIWKPhKnGuWg0Bfriv7izOxhoHxsc8f4QPMhBJaTxIOE2IxmLepe8R5r6ApKpPwTZS59Xa92lELKxz1Q+ev205XtesgjCtRF1OJLXezeXsrEu5wjvqQ5iF51BREu16pN2kn7DnhHFiye5Er0wM2Fddpyc=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR10MB5020.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(83380400001)(6512007)(36756003)(4744005)(31696002)(8936002)(110136005)(6506007)(44832011)(66946007)(66556008)(4326008)(5660300002)(66476007)(8676002)(508600001)(26005)(2616005)(38100700002)(31686004)(2906002)(186003)(6486002)(316002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?L1dodEVTTXF4VmNrblRIQldKdXExeEg1d0xFRWdCbnpMNGNYaWMrL3lsdU54?=
 =?utf-8?B?Y25PVnRrcTNGN0x4TW9LbThNdktqNVl1VXhGbUdvUk0wa1pkajJxQXVkVVlu?=
 =?utf-8?B?N2RCRGxESnovQXVkYWN5VTJmTzZ0dXBrNzRyOEV6dk5UNm5BbUhDVEFLN3Zs?=
 =?utf-8?B?aVRFK1RhYk0zUUY1N0ZzR1d1NlRSUG94d0NJZmR4aDdlbUFDaDQ1UTdZcWFi?=
 =?utf-8?B?aCtPSk9RdUY2M1A2UEphb2ZFb2M1YkhLN3daWlR0SHVra2RTQk1pYjB5dlpK?=
 =?utf-8?B?NENwNnpXS01ySDFhZ2tGQlhDQ2w0NXZ5cWEzOHJLbXhBMWh2ZmRRNjF6bnNP?=
 =?utf-8?B?c2swSW1vSDBRMG92eXlrOW1kelBDRFN0cGJMWVgzc2dTVU9vWlVoT0NSL0dS?=
 =?utf-8?B?Mks5bjcyZm0wQlJrTTg2eG41RUJETG5qcCt6Tm85NGRPZUkyYnZKNTNacSty?=
 =?utf-8?B?SGxnWDFyakJFYk53cS85akowS3JxbWJmUFg5b3VrQytaOU1xTmFJejlGLzh4?=
 =?utf-8?B?TWphb0cxZUlUV2x1Nm1vTm1YeEcyZkMwRFpJM0tIQ0REWXVRSDlMVkNWOWNN?=
 =?utf-8?B?cjRoUjA1YTlHS3ZvVGRObGxYcHM4TlphTyt0VVRiU095bGI0ZXRYeXFNbVdE?=
 =?utf-8?B?OEdPeFc2bitLN0MrTW5sREZpcTVLRnQxTkM2RDAxWTBGUEczZXVETkltcUdX?=
 =?utf-8?B?ZDFHTm10dVZvKzRneHEyKzFsV3BvWUlnV3hqcGZ4MjRwOCtITEJQOUM4dlVa?=
 =?utf-8?B?cjU3b2xibzBSZjNxNzE1MkxQRGJNdXRFVmlkSE1BY1htTnBjSUxRbG5WcGI2?=
 =?utf-8?B?cFdwYmV0M1BmcFZpM1N5eFVoZkpjaU5RMjR5RlppZXR6VER4OEt5TWg5OXlJ?=
 =?utf-8?B?cUNWa0JwUlRaV3g4eGc3dVJlemRyalRhcVVKU3lBWHZ2b3lpZ0JGQmtrRFNY?=
 =?utf-8?B?VnJVWUFBby8vejlFYWsrbDRGVkJCWEhwVDREa2pTeEU1Zjd4Ny81NHpDeWVq?=
 =?utf-8?B?SVdURnNiSU1WVGxJKzN1SzhaQ1UzM1BnYVpGbXpibGwrV3A2SHVlZkt3ZHQ3?=
 =?utf-8?B?c1U5V1RLWUxPZ2gzZnNuVVhydjFNT3hKMWxmYjZraVpyUmd3M3pyMkFtZTNx?=
 =?utf-8?B?dUdIZTRSRnhBZUtieElUTm45UW5EVEdLa3l3ZDl5WklNM0crODJzbng2Q2p1?=
 =?utf-8?B?SXZiYVV2WHJHYWNkNy9MVDRsVGpVWGVCVmNXUkQxUVlaZVZSRFVkbjB3NEJZ?=
 =?utf-8?B?WEJ1Q29lSy9LWXA2VTVtZWlrWG9ubVFCU0xudmRtZUFncFNMZHBsK1BwbFp3?=
 =?utf-8?B?eG1HZytuR2dzUVBId0NMRHdwRUFMTEV3U2FFVUVCZkZqUXhUS1pIT2ZoUkNB?=
 =?utf-8?B?SkJGU2RDTVowdEpGWmk5SEJYYUpKcTMrVm9xM0tSSUtLTVBMMlZwbXExRTRT?=
 =?utf-8?B?WGtNYllGMStSMTc1d0JRdkE3eXhwYmJINU9CRnRvN1JRTDU4RXlIbVpHS3d1?=
 =?utf-8?B?TEZaamFiL0x5YTI3aXZUbE13UXFxaUZvRUtqbEllei9XWTNXaXRKeFRINVdr?=
 =?utf-8?B?YUF6cE9aZEUrdk5hQjFwekJrNHkvMElGakZIOHk2NHExVkRsbEh5b1lmNHk3?=
 =?utf-8?B?VTVmdEQ1NzR0dUh0bnV2dW9xYnNteUd3cThqK0IraXlpWFkxbnpJWnpRVGgv?=
 =?utf-8?B?bHdWUUZpRnIyVWxzQjBIaGVqSG5TNjV2bzVZWEhJM3pTekpCZFdPd3pOQjd0?=
 =?utf-8?B?MGpPM1BPRkJnMStVTU1qYmR1YkMrbjN3WUJJbW95cFFEMzBrZVdJWlNmd1hS?=
 =?utf-8?B?YkZ5cm5zcWFiR0xIOEljOVpYdGJ2UXJPR1JkTzZiYmJ2bEprTlpkZ3lhSUtZ?=
 =?utf-8?B?QU5veUVKTnF4VG9SZEZpYnN6aHoyc1h5dkdPVnpsN1djeVVGTEpWSHArNXE4?=
 =?utf-8?B?Q05QaUFBbWtIeVpGQ20yanh4eUVmS0ZabGpYTTgvTnFpdHdJZityNFBSOWlH?=
 =?utf-8?B?eWsvTlZseDNVYUdpUElxNDJZZm5yUjcxWkZuOC9rUncyNzZzQjFUNWZSMktt?=
 =?utf-8?B?aW1sRzBwVjBrTk4yQWtKQWFHWjJkaGdkeEtHV3RiN243THRrUzlOLzZZTWs4?=
 =?utf-8?B?OW9sZldjMXlFRmdEVnNwRXM0VWUzQThmK1A3b2xPeGc4WHNzbjVPTHFoeGp0?=
 =?utf-8?B?aEx2RVNXemxGaWFvVVErY2t6cnREand2N09wa3dRK1phWGg1T015ekxuQnFu?=
 =?utf-8?B?Z1BhTTEyMHBSTnJ5eUxuOFZyRGFUUEwvMVhrU0o3R3RNTzBMK29zaDVwK2pP?=
 =?utf-8?B?ZVNQR1NrL0FBaDNpVW90VEIrNmcyMi9GS2R6bmZ6UklRUms3bzR3N0h4OGtQ?=
 =?utf-8?Q?DJ3IMaRUAnkJkua8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdacc79e-b164-429c-14fd-08da29690344
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5020.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 22:47:03.0382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ezlsJdKjaWedZYEPIcnlEnV/WEOKoADgJ3m39r6HU1EthRq3N4G9KLbo+Qgrr3w6n1tF2FxWpAORD1yuIGO3ToofVkZ5tFd8M0w7zhI5L6E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1740
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-28_05:2022-04-28,2022-04-28 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=994 mlxscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204280130
X-Proofpoint-ORIG-GUID: zTCihHKElX2Q78BIphPErBC54OnRTVQF
X-Proofpoint-GUID: zTCihHKElX2Q78BIphPErBC54OnRTVQF


On 4/28/22 5:49 PM, Stefano Stabellini wrote:
> On Thu, 28 Apr 2022, Christoph Hellwig wrote:
>> On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote:
>>>> Reported-by: Rahul Singh <Rahul.Singh@arm.com>
>>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>> Do you want to take this through the Xen tree or should I pick it up?
>> Either way I'd love to see some testing on x86 as well.
> I agree on the x86 testing. Juergen, Boris?
>
> I'd say to take this patch via the Xen tree but Juergen has just sent a
> Xen pull request to Linux last Saturday. Juergen do you plan to send
> another one? Do you have something else lined up? If not, it might be
> better to let Christoph pick it up.


We don't have anything pending.


I can test it but at best tomorrow so not sure we can get this into rc5. Do you consider this an urgent fix or can we wait until 5.19? Because it's a bit too much IMO for rc6.


-boris



From xen-devel-bounces@lists.xenproject.org Thu Apr 28 22:50:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 22:50:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316815.535883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkCxU-0004t9-Lg; Thu, 28 Apr 2022 22:50:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316815.535883; Thu, 28 Apr 2022 22:50:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkCxU-0004t1-H8; Thu, 28 Apr 2022 22:50:00 +0000
Received: by outflank-mailman (input) for mailman id 316815;
 Thu, 28 Apr 2022 22:49:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NTp2=VG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkCxS-0004sY-TX
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 22:49:58 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 869f98fa-c745-11ec-8fc3-03012f2f19d4;
 Fri, 29 Apr 2022 00:49:57 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 64532B82FE1;
 Thu, 28 Apr 2022 22:49:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5850C385AE;
 Thu, 28 Apr 2022 22:49:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 869f98fa-c745-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651186195;
	bh=HtpdNELwTjJdkzcKexRq3PpFYibX+KiI+5Mg9QQTkoc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=qpnUhybQuZLy2kl5npv3kFgzmULOTQo3x+KWc+vYnSGDZb4qA1fs7ljiiaDFHcXkl
	 W8Iue9Wbe6NSFlErp2AUlL+GjaOm1JH/2oxNMJk7GDr4vf4CAIw/1uuz7UaHFtQKSB
	 Jkxfi5FmAvSNglLS7NuBynzEeNADzROAmozt9AO0TIw5hmRxxowE88n/TkZSf1zgei
	 4fEC1O9iMPBHWxQSH58CH0G5sW/E1HBTsCvhGSXEeYgSvWalYsCRyQ5aTZOKPDs70I
	 1JuLqQORKpSQWfXIzCaNitKkYJ/zsX/eVaeQ9lKdq2D4PmQhrq/WQxg2RN/6plnx9y
	 rItdeGgUSRaHw==
Date: Thu, 28 Apr 2022 15:49:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Christoph Hellwig <hch@lst.de>, jgross@suse.com, 
    xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, 
    iommu@lists.linux-foundation.org, Rahul Singh <Rahul.Singh@arm.com>
Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
In-Reply-To: <27d39d5a-3b79-bdda-b7e4-f4477667919f@oracle.com>
Message-ID: <alpine.DEB.2.22.394.2204281548320.915916@ubuntu-linux-20-04-desktop>
References: <20220423171422.1831676-1-hch@lst.de> <alpine.DEB.2.22.394.2204261605420.915916@ubuntu-linux-20-04-desktop> <20220428132737.GA13999@lst.de> <alpine.DEB.2.22.394.2204281449060.915916@ubuntu-linux-20-04-desktop>
 <27d39d5a-3b79-bdda-b7e4-f4477667919f@oracle.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 28 Apr 2022, Boris Ostrovsky wrote:
> On 4/28/22 5:49 PM, Stefano Stabellini wrote:
> > On Thu, 28 Apr 2022, Christoph Hellwig wrote:
> > > On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote:
> > > > > Reported-by: Rahul Singh <Rahul.Singh@arm.com>
> > > > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > > Do you want to take this through the Xen tree or should I pick it up?
> > > Either way I'd love to see some testing on x86 as well.
> > I agree on the x86 testing. Juergen, Boris?
> > 
> > I'd say to take this patch via the Xen tree but Juergen has just sent a
> > Xen pull request to Linux last Saturday. Juergen do you plan to send
> > another one? Do you have something else lined up? If not, it might be
> > better to let Christoph pick it up.
> 
> 
> We don't have anything pending.
> 
> 
> I can test it but at best tomorrow so not sure we can get this into rc5. Do
> you consider this an urgent fix or can we wait until 5.19? Because it's a bit
> too much IMO for rc6.

On one hand, Linux doesn't boot on a platform without this fix. On the
other hand, I totally see that this patch could introduce regressions on
x86 so I think it is fair that we are careful with it.

>From my point of view, it might be better to wait for 5.19 and mark it
as backport.


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 22:54:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 22:54:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316821.535894 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkD1e-0006vD-58; Thu, 28 Apr 2022 22:54:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316821.535894; Thu, 28 Apr 2022 22:54:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkD1e-0006v6-1e; Thu, 28 Apr 2022 22:54:18 +0000
Received: by outflank-mailman (input) for mailman id 316821;
 Thu, 28 Apr 2022 22:54:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zsa2=VG=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1nkD1c-0006uh-El
 for xen-devel@lists.xenproject.org; Thu, 28 Apr 2022 22:54:16 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1f6e2f49-c746-11ec-8fc3-03012f2f19d4;
 Fri, 29 Apr 2022 00:54:14 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 181053200990;
 Thu, 28 Apr 2022 18:54:11 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Thu, 28 Apr 2022 18:54:11 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 28 Apr 2022 18:54:09 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f6e2f49-c746-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651186450; x=
	1651272850; bh=9l1HAiN7ppV23U31n5tXhB2CzREcaX0xYpVhVkV94Lc=; b=h
	OfJWukQtTrbcnysv8lTje2tKyfYEk1gXTDA/QZnSZPY4yWrV/OnkfwQ2r3zcXys5
	MDzdBmLCCdODBADYA5aS1E0LQwS1d9VtI5fO1fTmtJc0ADbv9mRaA71Js7PPj7zF
	/cQB15LxpdyGrEjQnvl55KAOxXSo0JVNt6Fr1Uh3seuTxT1ztW6zquhoDEjusLkm
	aFSw1ybho0r0/8jjh1qiHxkfmkJVXNwZX/x4Z2LVjpp2NRkoveRVdUryRnbEVYQk
	PHeQzm5osgj4t4hB+VuTx/HsVvQ5uhb5UsIHzCIZ5hexlz69ngBqB35LqCcivm8m
	nEMH7mrjmYr9DpOHItWHw==
X-ME-Sender: <xms:EhtrYobJmNiqPfUVM1ctTfnb-NboFc08d5fS3PH-tEELN6jwhFSbNQ>
    <xme:EhtrYjZOmsFvEoKwzJ2MQyZDli6JPWHyFan-oW7_3Biu-aOx9SX6mYWFPVs-kxcGj
    ibcgr2vsM_8E9A>
X-ME-Received: <xmr:EhtrYi8pIPa7lGTv-uCwyiZiBaSb9yr9qi5Mj8kAn0X2nkPShA8fSJF6-qPW>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekgddufecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu
    ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh
    hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg
    uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf
    grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl
    rggsrdgtohhm
X-ME-Proxy: <xmx:EhtrYiov6a5R1QGNYfX-md8YUUyw8ZeYedGltlI9ULvq0_GJRpMGvA>
    <xmx:EhtrYjqVpBzf8mKfjdikSbziXEg7JUckz4ZnKhDoAd_s_DFY2TXOlA>
    <xmx:EhtrYgRChG6_AQ2ixra5XhVPP0PWoMCtTUJ7uGgUhTDu93e595BkrQ>
    <xmx:EhtrYkCYu2t0ZATakRMQC5crcYgqJlM5nb4LUHsmUob6dHd7Q7_MbQ>
Date: Thu, 28 Apr 2022 18:54:03 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT
Message-ID: <YmsbD9ktQqB4U33o@itl-email>
References: <Yl7aC2a+TtOaFtqZ@itl-email>
 <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com>
 <YmmUtiBkhEYvXHUB@itl-email>
 <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="d8nYrWvw8D75UqvP"
Content-Disposition: inline
In-Reply-To: <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com>


--d8nYrWvw8D75UqvP
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Thu, 28 Apr 2022 18:54:03 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT

On Thu, Apr 28, 2022 at 08:47:49AM +0200, Jan Beulich wrote:
> On 27.04.2022 21:08, Demi Marie Obenour wrote:
> > On Wed, Apr 27, 2022 at 10:56:34AM +0200, Jan Beulich wrote:
> >> On 19.04.2022 17:49, Demi Marie Obenour wrote:
> >>> This hypercall can be used to get the ESRT from the hypervisor.  It
> >>> returning successfully also indicates that Xen has reserved the ESRT =
and
> >>> it can safely be parsed by dom0.
> >>
> >> I'm not convinced of the need, and I view such an addition as inconsis=
tent
> >> with the original intentions. The pointer comes from the config table,
> >> which Dom0 already has access to. All a Dom0 kernel may need to know in
> >> addition is whether the range was properly reserved. This could be ach=
ieved
> >> by splitting the EFI memory map entry in patch 2, instead of only spli=
tting
> >> the E820 derivation, as then XEN_FW_EFI_MEM_INFO can be used to find o=
ut
> >> the range's type. Another way to find out would be for Dom0 to attempt=
 to
> >> map this area as MMIO, after first checking that no part of the range =
is in
> >> its own memory allocation. This 2nd approach may, however, not really =
be
> >> suitable for PVH Dom0, I think.
> >=20
> > On further thought, I think the hypercall approach is actually better
> > than reserving the ESRT.  I really do not want XEN_FW_EFI_MEM_INFO to
> > return anything other than the actual firmware-provided memory
> > information, and the current approach seems to require more and more
> > special-casing of the ESRT, not to mention potentially wasting memory
> > and splitting a potentially large memory region into two smaller ones.
> > By copying the entire ESRT into memory owned by Xen, the logic becomes
> > significantly simpler on both the Xen and dom0 sides.
>=20
> I actually did consider the option of making a private copy when you did
> send the initial version of this, but I'm not convinced this simplifies
> things from a kernel perspective: They'd now need to discover the table
> by some entirely different means. In Linux at least such divergence
> "just for Xen" hasn't been liked in the past.
>=20
> There's also the question of how to propagate the information across
> kexec. But I guess that question exists even outside of Xen, with the
> area living in memory which the OS is expected to recycle.

Indeed it does.  A simple rule might be, =E2=80=9COnly trust the ESRT if it=
 is
in memory of type EfiRuntimeServicesData.=E2=80=9D  That is easy to achieve=
 by
monkeypatching the config table as you suggested below.

I *am* worried that the config table might be mapped read-only on some
systems, in which case the overwrite would cause a fatal page fault.  Is
there a way for Xen to check for this?  It could also be undefined
behavior to modify it.

> > Is using ebmalloc() to allocate a copy of the ESRT a reasonable option?
>=20
> I'd suggest to try hard to avoid ebmalloc(). It ought to be possible to
> make the copy before ExitBootServices(), via normal EFI allocation. If
> replacing a pointer in the config table was okay(ish), this could even
> be utilized to overcome the kexec problem.

What type should I use for the allocation?  EfiLoaderData looks like the
most consistent choice, but I am not sure if memory so allocated remains
valid when Xen hands off to the OS, so EfiRuntimeServicesData might be a
better choice.  To avoid memory leaks from repeated kexec(), this could
be made conditional on the ESRT not being in memory of type
EfiRuntimeServicesData to begin with.

--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--d8nYrWvw8D75UqvP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJrGxAACgkQsoi1X/+c
IsE/rxAAnZ5LGXqdmgaE2of9KvKMKieXq3b6bGj8gVNow63OyPhSN5W3KwI+9OoH
Cf+vuW3f88CK18PkIqfjAuhsvdEgj7iXVCv3tvcQSZcjvFj6ALnMMoe7RUMzUhse
8g+F3cZqBVRDNQ3dkQVRIbtQn/LMyv1N1QyahQ4rJJmlQKsMF+az8M2cUSL59rU7
FJntKbYq9edyWNhwcDn2Iw7PZsyMKXiqRt5huXVi7wdJGskFJsRVs5il2JSVzsGA
FvNGZqBBb/o5V3PAz/w2yBJQXodEZdgHORsUbHk9EqzZSpuzT2Lt7T07RVwn5+SW
rx9P4tcgtqUGu63zVvmd+N+JvSTp4BGKbl+3U/0vmZlJyqgFB5qLWHAZVotO5jo9
Wp45glY9WWvvvWOcRd98sk8PeWSU/kPCJpsWoQzHkYk8IBKk7PGYgwdu0wYD09x/
Vl0/S0AULJuYQf/nGTR4s6sa00TeFB0ZNa2jnZasNllXf8utGDu7qGfVh0JhyXln
oecXPMLQHNq/xPOsCr2g6Sm/w01KN6bOp6zLejhH8xUrIhe1bgAk2B/jSw520X2x
pdAO9KE6XqzDI4KSMBwoVpYgsggVWx08JzSo5UBU8Ign8tN/oBipYMxdM22FTqus
tnakVeRYXKL/DoVhU0/cz1JLgmHz0xV1UU/d6nZXs7ntnEsjCuc=
=7V/z
-----END PGP SIGNATURE-----

--d8nYrWvw8D75UqvP--


From xen-devel-bounces@lists.xenproject.org Thu Apr 28 23:28:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Apr 2022 23:28:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316832.535905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkDYn-0002t6-Uv; Thu, 28 Apr 2022 23:28:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316832.535905; Thu, 28 Apr 2022 23:28:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkDYn-0002sz-QY; Thu, 28 Apr 2022 23:28:33 +0000
Received: by outflank-mailman (input) for mailman id 316832;
 Thu, 28 Apr 2022 23:28:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkDYn-0002sp-2H; Thu, 28 Apr 2022 23:28:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkDYm-0001N3-UA; Thu, 28 Apr 2022 23:28:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkDYm-0005Q4-Kx; Thu, 28 Apr 2022 23:28:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkDYm-0002j1-KX; Thu, 28 Apr 2022 23:28:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Kyzesor+bI+cb3LtDFt24o/BbmStlsUtHJDx0lMcg4g=; b=y3TQetOIjpCo1ai+hK2TaRCzOm
	ihooodAXUOrCOW2+nuiNG7LbOu/bF9pO1WeNA0VErAeqkjJdyZ8EecJtQH8z+KeOsIE5wnS3Bu204
	tsxyNlnHj+GYDJT4ayZNg+EaLm31zuISXMyjw7V4Mtj2aO0q6kKfoc4N25bQCnULPQWk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169837-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169837: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Apr 2022 23:28:32 +0000

flight 169837 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169837/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  685 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 00:41:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 00:41:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316841.535920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkEhA-0002iZ-GX; Fri, 29 Apr 2022 00:41:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316841.535920; Fri, 29 Apr 2022 00:41:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkEhA-0002iS-C6; Fri, 29 Apr 2022 00:41:16 +0000
Received: by outflank-mailman (input) for mailman id 316841;
 Fri, 29 Apr 2022 00:41:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkEh8-0002iM-BE
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 00:41:14 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 10ef8493-c755-11ec-8fc3-03012f2f19d4;
 Fri, 29 Apr 2022 02:41:12 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C9FD8621A0;
 Fri, 29 Apr 2022 00:41:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5AF6C385A9;
 Fri, 29 Apr 2022 00:41:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10ef8493-c755-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651192870;
	bh=mKEymw8KHvNr0gMWZtrppwrbSLOzYD3jOEAZWtclph0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Ioc3nJuVy+OjaUHRXuGcts27MuXrrmWCvT3gyeJGA+x5cqRGaqT1nLplTNlMt0a4W
	 L++oaeEKbkSfFahXC+SvDRKQDJObPwo5wTnAMsxZdfCbfScXpEtiu2cB3AsPZc4H8v
	 qefi3OifidS2PdGs+oj+emAKnVZgZ1aTDTTwXoXb2MhPCQ9Bik9S77Mr83+xEcIjGF
	 2o6fef31q3CKm1NStEidubA8XdQyJ9GrI5xk4xSgXmZp35jY7T9UDFR8T3dCD5G4P9
	 /2Vqle+RGF4CsyfojhlXLr5CGwShCToZ01MBC4Mi353FZEaavwdLmLI1ofnPtWfmM6
	 1ftJEyckDv33w==
Date: Thu, 28 Apr 2022 17:41:09 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien.grall.oss@gmail.com>, 
    osstest service owner <osstest-admin@xenproject.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, David Vrabel <dvrabel@amazon.co.uk>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
In-Reply-To: <ac0a0bf0-81a8-63c7-6a62-377672e24069@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204281647540.915916@ubuntu-linux-20-04-desktop>
References: <osstest-169781-mainreport@xen.org> <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org> <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop> <CAJ=z9a1bu=3sX0rvWy+T-ey4363DMUEJvzkSqkQkTnvOQtT0=A@mail.gmail.com>
 <alpine.DEB.2.22.394.2204271622520.915916@ubuntu-linux-20-04-desktop> <ac0a0bf0-81a8-63c7-6a62-377672e24069@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 28 Apr 2022, Julien Grall wrote:
> On 28/04/2022 01:47, Stefano Stabellini wrote:
> > On Thu, 28 Apr 2022, Julien Grall wrote:
> > > Hi Stefano,
> > > 
> > > On Thu, 28 Apr 2022, 00:02 Stefano Stabellini, <sstabellini@kernel.org>
> > > wrote
> > >        It seems to me that it is acceptable to allocate memory with
> > > interrupt
> > >        disabled during __init. I cannot see any drawbacks with it. I think
> > > we
> > >        should change the ASSERT to only trigger after __init: system_state
> > > ==
> > >        SYS_STATE_active.
> > > 
> > >        What do you think?
> > > 
> > > 
> > > This would solve the immediate problem but not the long term one (i.e cpu
> > > hotplug).
> > > 
> > > So I think it would be better to properly fix it right away.
> > 
> > Yeah, you are right about cpu hotplug. I think both statements are true:
> > 
> > - it is true that this is supposed to work with cpu hotplug and these
> >    functions might be directly affected by cpu hotplug (by a CPU coming
> >    online later on)
> > 
> > - it is also true that it might not make sense to ASSERT at __init time
> >    if IRQs are disabled. There might be other places, not affected by cpu
> >    hotplug, where we do memory allocation at __init time with IRQ
> >    disabled. It might still be a good idea to add the system_state ==
> >    SYS_STATE_active check in the ASSERT, not to solve this specific
> >    problem but to avoid other issues.
> 
> AFAIU, it is not safe on x86 to do TLB flush with interrupts disabled *and*
> multiple CPUs running. So we can't generically relax the check.
> 
> Looking at the OSSTest results, both Arm32 and Arm64 without GICv3 ITS tests
> have passed. So it seems unnecessary to me to preemptively relax the check
> just for Arm.

It is good news that it works already (GICv3 aside) on ARM. If you
prefer not to relax it, I am OK with it (although it makes me a bit
worried about future breakages).

 
> > In regard to gicv3_lpi_allocate_pendtable, I haven't thought about the
> > implications of cpu hotplug for LPIs and GICv3 before. Do you envision
> > that in a CPU hotplug scenario gicv3_lpi_init_rdist would be called when
> > the extra CPU comes online?
> 
> It is already called per-CPU. See gicv3_secondary_cpu_init() ->
> gicv3_cpu_init() -> gicv3_populate_rdist().

Got it, thanks!


> > Today gicv3_lpi_init_rdist is called based on the number of
> > rdist_regions without checking if the CPU is online or offline (I think ?)
> 
> The re-distributors are not banked and therefore accessible by everyone.
> However, in Xen case, each pCPU will only touch its own re-distributor (well
> aside TYPER to figure out the ID).
> 
> The loop in gicv3_populate_rdist() will walk throught all the
> re-distributor to find which one corresponds to the current pCPU. Once we
> found it, we will call gicv3_lpi_init_rdist() to fully initialize the
> re-distributor.
> 
> I don't think we want to populate the memory for each re-distributor in
> advance.

I agree.

Currently we do:

    start_secondary
        [...]
        gic_init_secondary_cpu()
            [...]
            gicv3_lpi_init_rdist()
        [...]
        local_irq_enable();

Which seems to be the right sequence to me. There must be an early boot
phase where interrupts are disabled on a CPU but memory allocations are
possible. If this was x86 with the tlbflush limitation, I would suggest
to have per-cpu memory mapping areas so that we don't have to do any
global tlb flushes with interrupts disabled.

On ARM, we don't have the tlbflush limitation so we could do that but we
wouldn't have much to gain from it.

Also, this seems to be a bit of a special case, because in general we
can move drivers initializations later after local_irq_enable(). But
this is the interrupt controller driver itself -- we cannot move it
after local_irq_enable().

So maybe an ad-hoc solution could be acceptable?

The only one I can think of is to check on system_state ==
SYS_STATE_active now. In the future for CPU hotplug we could have a
per-CPU system_state, like cpu_system_state, and do a similar check.

I am totally open to other ideas, I couldn't come up with anything
better at the moment.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 00:41:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 00:41:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316842.535931 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkEhD-0002yB-N9; Fri, 29 Apr 2022 00:41:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316842.535931; Fri, 29 Apr 2022 00:41:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkEhD-0002y4-Jr; Fri, 29 Apr 2022 00:41:19 +0000
Received: by outflank-mailman (input) for mailman id 316842;
 Fri, 29 Apr 2022 00:41:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkEhC-0002iM-PR
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 00:41:18 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 14814c0a-c755-11ec-8fc3-03012f2f19d4;
 Fri, 29 Apr 2022 02:41:18 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D6FED62199;
 Fri, 29 Apr 2022 00:41:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2F9BC385AD;
 Fri, 29 Apr 2022 00:41:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14814c0a-c755-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651192876;
	bh=3p95qHdfTWDwcx/Qc1VWcALBiwNRhOcOPNJRRosJ71A=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=nE1EoPNL0VK+o/v90Mx3rHJDcwRf1HlspdQwtVBsJf7k+mpyKmK8frZ1iTRFF6Ns3
	 IIjBkkUMuFzsyVtPg69RBJBlRjxAC5Xzqk+7fBaeJe8TIYu4QZpd6Lc5Ym1MoKh6H7
	 GILkAWC4bB31he/LHESKP78ycssQdOzwI6W80gGDFolVSfew1TEM7hne8juhMjBFQt
	 sBEzDe8fWl/lYrXZFY+UWrynjMibEB4QQX0orJKbugRjOzsCikxS7WDkBEBVtez55H
	 G42+PYsNFAR1qW3FJrPM+P9aIIp51apnj+GHbNzmxUInpeQ7qAnY5xPLzVQp6B78gN
	 7mk3zYZq0xI+g==
Date: Thu, 28 Apr 2022 17:41:15 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
cc: Roger Pau Monne <roger.pau@citrix.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH] cirrus-ci: add myself as maintainer
In-Reply-To: <e140ff85-184a-e642-6850-3a14c9ff597f@citrix.com>
Message-ID: <alpine.DEB.2.22.394.2204281315420.915916@ubuntu-linux-20-04-desktop>
References: <20220428095549.91409-1-roger.pau@citrix.com> <e140ff85-184a-e642-6850-3a14c9ff597f@citrix.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1958550992-1651177243=:915916"
Content-ID: <alpine.DEB.2.22.394.2204281324350.915916@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1958550992-1651177243=:915916
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2204281324351.915916@ubuntu-linux-20-04-desktop>

On Thu, 28 Apr 2022, Andrew Cooper wrote:
> On 28/04/2022 10:55, Roger Pau Monne wrote:
> > Given the testing done by Cirrus-CI is FreeBSD only introduce a new
> > section in the MAINTAINERS file to cover it and add myself as the
> > maintainer.
> >
> > Requested-by: Stefano Stabellini <sstabellini@kernel.org>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > FWIW, I wouldn't mind it being part of the "Continuous Integration
> > (CI)" section, but I understand maintainers there could prefer a
> > separate section since this is ATM FreeBSD only testing.
> 
> I don't think we have enough review bandwidth to separate things like
> this.  Plenty of changes to CI are dependency tweaks which cover all CI
> files in one go, so wouldn't be directly relevant to being FreeBSD. 
> Also some CI changes need superpowers in other systems.


Today, gitlab-ci and cirrus-ci are entirely different systems: they
don't share any containers or any other artifacts. So my preference is
to have a separate entry in the MAINTAINERS file as Roger did in this
patch. That would be more accurate in terms of roles, responsibilities
and expectations. If someone sends a patch for .cirrus.yml, I definitely
think Roger should be the one to have a look. My recommendation is to go
ahead with this patch. We can always merge the sections in the future if
the CI systems become more integrated.

Acked-by: Stefano Stabellini <sstabellini@kernel.org>
--8323329-1958550992-1651177243=:915916--


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 00:44:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 00:44:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316853.535942 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkEk4-0003td-6g; Fri, 29 Apr 2022 00:44:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316853.535942; Fri, 29 Apr 2022 00:44:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkEk4-0003tW-3A; Fri, 29 Apr 2022 00:44:16 +0000
Received: by outflank-mailman (input) for mailman id 316853;
 Fri, 29 Apr 2022 00:44:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkEk2-0003tM-Em; Fri, 29 Apr 2022 00:44:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkEk2-0003Ko-Bo; Fri, 29 Apr 2022 00:44:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkEk2-0001HD-02; Fri, 29 Apr 2022 00:44:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkEk1-0001SZ-Vq; Fri, 29 Apr 2022 00:44:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1iZyWYiHKw0lKsGCYvwzx4QgZenMnTkvBvAmrIjl2ew=; b=gniqoF50tQKQ6XWLKYpqfptGgZ
	NJ95RZ6WRm32xGzmumGwgBlcaRCquFa/brDOwRUB8JkPz88OlA7zdiZKHIBWmMyUozYMTPWTJkDE8
	fQfnzqQn8m7zr/oPFwAqhvi4n4WAIhvA8GMYskO8YGKrZkL+5Xl0uUXJcEowMCgwNauw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169839-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169839: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 00:44:13 +0000

flight 169839 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169839/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   58 days  686 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 02:04:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 02:04:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316897.535971 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkFzK-0002t9-Dw; Fri, 29 Apr 2022 02:04:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316897.535971; Fri, 29 Apr 2022 02:04:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkFzK-0002t1-8O; Fri, 29 Apr 2022 02:04:06 +0000
Received: by outflank-mailman (input) for mailman id 316897;
 Fri, 29 Apr 2022 02:04:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkFzI-0002sr-EN; Fri, 29 Apr 2022 02:04:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkFzI-00034N-CX; Fri, 29 Apr 2022 02:04:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkFzH-0003rT-TM; Fri, 29 Apr 2022 02:04:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkFzH-0003ob-Sr; Fri, 29 Apr 2022 02:04:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Qltu+rrZxYqG7VDB08vCX8JZ7X7BNEX3+k+/nCj/Sk4=; b=EFAeZtpn8gECcVtS3/w/55+STl
	cbvX6RUsc3Rr7jMwWS99tr/Rp4OABuoVHeo8iYo3RyFFRnlrdxbrJwYPCGJwSyx5YxxfWxFIdp0DX
	HsJfE1l0vF3b/qqMRBc0YC++5XkHCA+bu/iumUTh+Lx4RkYmHuxactxf0PkxdA/UsYJ4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169841-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169841: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 02:04:03 +0000

flight 169841 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169841/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  687 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 02:36:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 02:36:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316908.535988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkGV2-0006GY-65; Fri, 29 Apr 2022 02:36:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316908.535988; Fri, 29 Apr 2022 02:36:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkGV2-0006GR-2e; Fri, 29 Apr 2022 02:36:52 +0000
Received: by outflank-mailman (input) for mailman id 316908;
 Fri, 29 Apr 2022 02:36:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkGV0-0006GH-PT; Fri, 29 Apr 2022 02:36:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkGV0-0003d1-N0; Fri, 29 Apr 2022 02:36:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkGUz-0004tZ-Tl; Fri, 29 Apr 2022 02:36:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkGUz-0001mZ-TG; Fri, 29 Apr 2022 02:36:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YtCFks1losQKtseOkTn9O2c4PyDWB7FCPuEO9RIfY2k=; b=jDXmCuJ+3YqtzXHWdD4SMou/le
	P3vUnGptMMUk/bMth9gu6XK+zifGilnUmPjXxox0EjxjB8uHjfcadaqignxtkgT/2FutFG3/jDxTw
	1Gb966pNWT6trYoxDtsg6oKSg4xtb+TdLsRe/aYPHVT/yuKVLPUq874bGTSooE+8zQKI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169842-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169842: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 02:36:49 +0000

flight 169842 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169842/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  688 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 03:13:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 03:13:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316916.535999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkH4U-0001yR-Vh; Fri, 29 Apr 2022 03:13:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316916.535999; Fri, 29 Apr 2022 03:13:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkH4U-0001yK-SV; Fri, 29 Apr 2022 03:13:30 +0000
Received: by outflank-mailman (input) for mailman id 316916;
 Fri, 29 Apr 2022 03:13:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkH4T-0001yA-EH; Fri, 29 Apr 2022 03:13:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkH4T-0004T1-BM; Fri, 29 Apr 2022 03:13:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkH4S-0005x4-Uk; Fri, 29 Apr 2022 03:13:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkH4S-0001Tn-UH; Fri, 29 Apr 2022 03:13:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=un+aNVnmVdRIxNwV/RjLJLV8Wo/3Dd3KAv+GvkeFsuY=; b=NoLMEN4QFM/bPVmgLHWPcooxc1
	XtbhhqSxirucCqb+jBV9VbcVwmdRFxY2dxRixXamJzDGp7DFWZI7V3pWlDYydx+WXpbFIW3ENnKGK
	WnuutZ4BuEissLXUmASO9Q6BuIu0UzzQZW85up7AVAH8JL8n+sMiXyOlvQkiQJ1QBaB0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169845-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169845: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 03:13:28 +0000

flight 169845 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169845/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  689 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 03:43:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 03:43:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316924.536010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkHX3-0005Da-Ct; Fri, 29 Apr 2022 03:43:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316924.536010; Fri, 29 Apr 2022 03:43:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkHX3-0005DT-8d; Fri, 29 Apr 2022 03:43:01 +0000
Received: by outflank-mailman (input) for mailman id 316924;
 Fri, 29 Apr 2022 03:42:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkHX1-0005DJ-NR; Fri, 29 Apr 2022 03:42:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkHX1-0004uS-K1; Fri, 29 Apr 2022 03:42:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkHX0-0006gw-Us; Fri, 29 Apr 2022 03:42:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkHX0-00012D-UN; Fri, 29 Apr 2022 03:42:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hpNOCfb6SQT5W2Pt7Lx2JSsZQOrtM+WNdqDpdCrMD5Y=; b=6yd7AgxP96hwW6MXoXSrs9ru9A
	YBg8Bjv2mVhX7XyQk/uLS/ykLF8fTQvP5/4nNmpuTNtejPSp8lQMcIFlC/nn8z6+mZvsaQJq6BGFr
	ykcrNIBxcBcBywzPskcZRAGjs5xS1GYmN21mJ01Uk5MIDU5wYlb3C2Np7xSQ7xfYb35o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169827-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169827: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=6071ff6087208bf1d8e488dca43037b41d5ad764
X-Osstest-Versions-That:
    qemuu=cf6f26d6f9b2015ee12b4604b79359e76784163a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 03:42:58 +0000

flight 169827 qemu-mainline real [real]
flight 169846 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169827/
http://logs.test-lab.xenproject.org/osstest/logs/169846/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail pass in 169846-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 169801

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169801
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169801
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169801
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169801
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169801
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169801
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169801
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169801
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                6071ff6087208bf1d8e488dca43037b41d5ad764
baseline version:
 qemuu                cf6f26d6f9b2015ee12b4604b79359e76784163a

Last test of basis   169801  2022-04-28 00:08:30 Z    1 days
Testing same since   169827  2022-04-28 16:55:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Haiyue Wang <haiyue.wang@intel.com>
  Michael Tokarev <mjt@tls.msk.ru>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Brook <paul@nowt.org>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   cf6f26d6f9..6071ff6087  6071ff6087208bf1d8e488dca43037b41d5ad764 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 03:48:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 03:48:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316933.536021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkHc7-0005vI-51; Fri, 29 Apr 2022 03:48:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316933.536021; Fri, 29 Apr 2022 03:48:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkHc7-0005vB-26; Fri, 29 Apr 2022 03:48:15 +0000
Received: by outflank-mailman (input) for mailman id 316933;
 Fri, 29 Apr 2022 03:48:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FbCp=VH=linaro.org=viresh.kumar@srs-se1.protection.inumbo.net>)
 id 1nkHc6-0005v5-KC
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 03:48:14 +0000
Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com
 [2607:f8b0:4864:20::529])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 316924b2-c76f-11ec-8fc3-03012f2f19d4;
 Fri, 29 Apr 2022 05:48:13 +0200 (CEST)
Received: by mail-pg1-x529.google.com with SMTP id 15so5579132pgf.4
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 20:48:13 -0700 (PDT)
Received: from localhost ([122.162.207.161]) by smtp.gmail.com with ESMTPSA id
 q2-20020a17090a064200b001cd498dc152sm14241761pje.2.2022.04.28.20.48.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 28 Apr 2022 20:48:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 316924b2-c76f-11ec-8fc3-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=gZjXmVBe8S8Suaw/jkB5ne7RxJmRF1KeOvaTkzClLWE=;
        b=pVw779UmSnnKKLbe02OBNHcj51RAUblPOOSUjlQ/H/eFL+cHtIr+9z6icu3XsV6Qqd
         zINBIhfLseGhIWfV5OIRdh8t1Ev+Leuz+ujeoGa4yi0ESUrDRInGBp2XMKAS/1i261ST
         i/ZuKA3CIGWB6kdLZ7b6w+GnwBjwYzMnzk6frMHdcUMqLR/s0TTwp1GMsre6b2Vkpp+3
         4lwgyvuw4NA2V7lGmCPPMNzoguZM59R7OUvwIVXrvOH7Im/LjL3DTTctHypTBC2+MKbf
         2PP3svf6e/47l+7REyCz7I1x26K8qe3JIahux/Lb5IUM62ZmpbNrc0Ivq5iOVuyXhT0O
         D+pg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=gZjXmVBe8S8Suaw/jkB5ne7RxJmRF1KeOvaTkzClLWE=;
        b=7mHXB5muB3tij0vFpdUDf2GnvBWGbf0/t4Hiwb5l2HXp3Kx42glqsviGhJ5Pk9U2ZI
         edeWtCxyj/gYMnTq4HLlTvBQj6avxU3Ru9QrDO+KtTrNTK+nYRZpwGt/kHn2l771bsTz
         shGf6X+sAYHGwMDy2fRZGPN8GS8cjbxSHxol9PomqpqQbyuk2VnVd5pidJ5T47pjDkmL
         ys7gM8VRYOwts7uNsBknRk05yNNGWff2SmrgFYYHFa/edV5IvE4ATvYdmDaT2sDjZMhP
         vz00740CtPD8Hvefp+o1sRGT8Tp2nkZGOD8tsUaqBLZcBEoJXFXCMcINEn4DDTDaQKoP
         cA3Q==
X-Gm-Message-State: AOAM531FmpJ71pCIXXDnCJsczs1pfau3/gimFXcwG+nEWJveJLI/xKhp
	T5HA+ZDUc9KjKHltMqCvZ731Hw==
X-Google-Smtp-Source: ABdhPJyoinGCEYWjbt2wYNom0qZ7Tc/0Nl7copu9nksgeB/5cuKCenTnIAB8Ujcg1U13YJ5Zsj7Aqg==
X-Received: by 2002:a05:6a00:1895:b0:50a:de86:b4b0 with SMTP id x21-20020a056a00189500b0050ade86b4b0mr37933439pfh.28.1651204091937;
        Thu, 28 Apr 2022 20:48:11 -0700 (PDT)
Date: Fri, 29 Apr 2022 09:18:08 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Stratos Mailing List <stratos-dev@op-lists.linaro.org>,
	Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Mathieu Poirier <mathieu.poirier@linaro.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Mike Holmes <mike.holmes@linaro.org>, Wei Liu <wl@xen.org>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: Virtio on Xen with Rust
Message-ID: <20220429034808.dr647727dphnx6zk@vireshk-i7>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <CAPD2p-ks4ZxWB8YT0pmX1sF_Mu2H+n_SyvdzE8LwVP_k_+Biog@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPD2p-ks4ZxWB8YT0pmX1sF_Mu2H+n_SyvdzE8LwVP_k_+Biog@mail.gmail.com>
User-Agent: NeoMutt/20180716-391-311a52

On 28-04-22, 16:52, Oleksandr Tyshchenko wrote:
> Great work!

Thanks Oleksandr.

> I skimmed through your toolstack patches, awesome, you created a completely
> new virtual device "I2C".

I have also created GPIO now :)

What should I do about these patches ? Send them to xen list ? I can at least
send the stuff which doesn't depend on your series ?

> FYI, I have updated "Virtio support for toolstack on Arm" [1] since (to
> make it more generic), now V7 is available and I have a plan to push V8
> soon.

I will surely have a look, thanks.

> FYI, currently we are working on one feature to restrict memory access
> using Xen grant mappings based on xen-grant DMA-mapping layer for Linux [1].
> And there is a working PoC on Arm based on an updated virtio-disk. As for
> libraries, there is a new dependency on "xengnttab" library. In comparison
> with Xen foreign mappings model (xenforeignmemory),
> the Xen grant mappings model is a good fit into the Xen security model,
> this is a safe mechanism to share pages between guests.

Right, I was aware of this work but didn't dive into it yet. We will surely need
to do that eventually, lets see when I will be able to get to that. The current
focus is the get the solution a bit more robust (so it can be used with any
device) and upstream it to rust-vmm space on github.

> With Xen grant mappings, if I am not mistaken, it is going to be almost the
> same: mmap() then ioctl(). But the file will be "/dev/xen/gntdev".

Okay, the problem (for us) still exists then :)
 
> FYI, new branch "virtio_grant" besides supporting Xen grant mappings also
> supports virtio-mmio modern transport.

Somehow the timing of your emails have been spot on.

Last time, when you told me about the "dev" branch, I have already started to
reinvent the wheel and your branch really helped.

Now, it was just yesterday that I started looking into MMIO modern stuff as the
GPIO device needs it and you sent me working code to look how to do it as well.
You saved at least 1-2 days of my time :)

Thanks Oleksandr.

-- 
viresh


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 03:59:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 03:59:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316939.536032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkHmt-0007Ph-4b; Fri, 29 Apr 2022 03:59:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316939.536032; Fri, 29 Apr 2022 03:59:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkHmt-0007Pa-1e; Fri, 29 Apr 2022 03:59:23 +0000
Received: by outflank-mailman (input) for mailman id 316939;
 Fri, 29 Apr 2022 03:59:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FbCp=VH=linaro.org=viresh.kumar@srs-se1.protection.inumbo.net>)
 id 1nkHms-0007PU-9A
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 03:59:22 +0000
Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com
 [2607:f8b0:4864:20::1032])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf652929-c770-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 05:59:21 +0200 (CEST)
Received: by mail-pj1-x1032.google.com with SMTP id
 l11-20020a17090a49cb00b001d923a9ca99so6214650pjm.1
 for <xen-devel@lists.xenproject.org>; Thu, 28 Apr 2022 20:59:21 -0700 (PDT)
Received: from localhost ([122.162.207.161]) by smtp.gmail.com with ESMTPSA id
 gw20-20020a17090b0a5400b001cd4989fee5sm12178852pjb.49.2022.04.28.20.59.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 28 Apr 2022 20:59:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf652929-c770-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=oCrSxnAZqQfOSqNt8oa74aLKF77ckW2txQTjvHW0lrY=;
        b=AjXUwFFcgo5WGPbVJYlIQupUvT7GbE6qbJXvsfDu4z+iwKoBsPFC07vOXjK/Qb/auN
         o/VY5FcJ3xcuMHMfRvJTZHqQhGf6D9OW7y3JZ5Wj1/I+PKUkwZFusoSy83btxj36x+P4
         TI0l9duk7kQORW9hXSok50CEDc7pEGZmop+ZN2yNerlCv5BmreZxqKZ2U8inyylr3M4+
         BrYiJ2O97OTbQMPD8zIidYk+NSkukDHib1pof9uWSn7TJiWeVaydhP6mmE9U5CGtXYEm
         NuDmG1K/nlXNyEHvznp7T1q6Wx9nrbbeRhole3J3s09wh6+g0hoZTcBQw6WozWt7SY9R
         Kt3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=oCrSxnAZqQfOSqNt8oa74aLKF77ckW2txQTjvHW0lrY=;
        b=QAp8MR7j77rSlsAFcHwvkRwI+bOzYe9Nl4kfY23URqx7KXv83iuLy2qjMbPwmqSni9
         NUGl0OjOm1R+JyNH/uMRL8G4jQqPtTt9DrNYtWmFnAAM7avK7RsDcZRaZTwy7kMrf6f3
         ZblPfBkk4xKYBJ0I8ohygJwou3Mtulh0YyDKunMse4Da+lLdWvToFfuaw5Z9KZiXU5dR
         QWH5fLzfBYCdJUK5Pm2aUXihWwdanvWPLdyvv+ZHCXQoGSOJHhgP3s1IIE/rMOGLP0gw
         A49R2xn/D2aW5rO2TvbayH6sXTwRv0RCIBOVfLuazcs1nxIpT6xZGI6s2DQ7gHn/fuKV
         lFdw==
X-Gm-Message-State: AOAM531ey6ZJSt1wlGBYZsA9BxRxbgw7zdy2QDwSaajFwydEwKy1/t/g
	becwpsqXA7ZZRCx8YoE2ro9mHg==
X-Google-Smtp-Source: ABdhPJyxxC3NG5a2FYFCVGTGEgZPjpgalWTx3Y9qSFmR/nMhSP/S6O3tbgUkTL1IvLUTN22eRP1rkA==
X-Received: by 2002:a17:90b:3ec3:b0:1c7:24c4:e28f with SMTP id rm3-20020a17090b3ec300b001c724c4e28fmr1755466pjb.191.1651204759772;
        Thu, 28 Apr 2022 20:59:19 -0700 (PDT)
Date: Fri, 29 Apr 2022 09:29:17 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Stratos Mailing List <stratos-dev@op-lists.linaro.org>,
	Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Mathieu Poirier <mathieu.poirier@linaro.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Mike Holmes <mike.holmes@linaro.org>, Wei Liu <wl@xen.org>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: Virtio on Xen with Rust
Message-ID: <20220429035917.xu5ecgldwzfnxbos@vireshk-i7>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <CAPD2p-ks4ZxWB8YT0pmX1sF_Mu2H+n_SyvdzE8LwVP_k_+Biog@mail.gmail.com>
 <20220429034808.dr647727dphnx6zk@vireshk-i7>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220429034808.dr647727dphnx6zk@vireshk-i7>
User-Agent: NeoMutt/20180716-391-311a52

On 29-04-22, 09:18, Viresh Kumar wrote:
> Now, it was just yesterday that I started looking into MMIO modern stuff as the
> GPIO device needs it and you sent me working code to look how to do it as well.
> You saved at least 1-2 days of my time :)

One question though, do we need to support Legacy mode at all in the work we are
doing ?

-- 
viresh


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 04:24:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 04:24:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316945.536043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkIAy-0002SV-3G; Fri, 29 Apr 2022 04:24:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316945.536043; Fri, 29 Apr 2022 04:24:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkIAx-0002SO-WE; Fri, 29 Apr 2022 04:24:16 +0000
Received: by outflank-mailman (input) for mailman id 316945;
 Fri, 29 Apr 2022 04:24:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkIAw-0002SE-S3; Fri, 29 Apr 2022 04:24:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkIAw-0005sr-Pc; Fri, 29 Apr 2022 04:24:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkIAw-0007bD-By; Fri, 29 Apr 2022 04:24:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkIAw-0005FZ-BV; Fri, 29 Apr 2022 04:24:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XOpWVPqqNVl4dE4nbJPTiUh0lQOnyvrU4/l8GlOuJtA=; b=5XNTJvpXxhw36bWBrjyQMqh4wh
	JYTvDEd9hkNbY00AHXueTsyRDwYO0oP4dxmZG1dWBWhm5VtABCzdH6TYCCOFlsBST/3K+uKb8TZ3G
	2hl65tz5zijlZ2MwMUbb2o9NB+vlh/x459oDjw8+GpXZhnKNzS1q8lnlOXdWc/kSliFU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169840-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169840: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e57477359071ab91429b0ebcbf7ff162242e2831
X-Osstest-Versions-That:
    xen=d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 04:24:14 +0000

flight 169840 xen-unstable-smoke real [real]
flight 169847 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169840/
http://logs.test-lab.xenproject.org/osstest/logs/169847/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 169824

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e57477359071ab91429b0ebcbf7ff162242e2831
baseline version:
 xen                  d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed

Last test of basis   169824  2022-04-28 16:00:24 Z    0 days
Testing same since   169840  2022-04-29 00:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <julien@xen.org>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit e57477359071ab91429b0ebcbf7ff162242e2831
Author: Stefano Stabellini <sstabellini@kernel.org>
Date:   Tue Apr 26 13:27:32 2022 -0700

    MAINTAINERS: add Rahul as SMMU maintainer
    
    Add Rahul as ARM SMMU maintainer. Create a new explicit entry for "ARM
    SMMU" also with Julien which is the original contributor of the code and
    continues to maintain it.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
    Acked-by: Rahul Singh <rahul.singh@arm.com>
    Acked-by: Julien Grall <julien@xen.org>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 05:04:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 05:04:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316956.536063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkInn-0006yR-BE; Fri, 29 Apr 2022 05:04:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316956.536063; Fri, 29 Apr 2022 05:04:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkInn-0006yK-7C; Fri, 29 Apr 2022 05:04:23 +0000
Received: by outflank-mailman (input) for mailman id 316956;
 Fri, 29 Apr 2022 05:04:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkInl-0006yA-Nv; Fri, 29 Apr 2022 05:04:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkInl-0006rh-HK; Fri, 29 Apr 2022 05:04:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkInk-0000Eq-W6; Fri, 29 Apr 2022 05:04:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkInk-0004bQ-Ts; Fri, 29 Apr 2022 05:04:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fdsV42WC6ViSY6nfBMi8v5NQ8l1q8JwQDK1h/PWQ/Fw=; b=MOJJBItZ5pxpgU+riDOGJOiQv2
	bWep6zOTeApVUVrgtY0pTMw1rlKgsRqzMYmvBXgePyXO5CbRowWULwhEnkuxx/abBDCi9tRgKu1qR
	AXrUUZbWLFgNMsQN4ltyUiSJWDY3wUVc81T7wjZIUrMlyTSxQyFIlfpVJZC5G2cOd3GY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169848-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169848: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 05:04:20 +0000

flight 169848 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169848/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  690 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 06:53:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 06:53:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316967.536080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkKV6-0000ep-1b; Fri, 29 Apr 2022 06:53:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316967.536080; Fri, 29 Apr 2022 06:53:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkKV5-0000ei-UL; Fri, 29 Apr 2022 06:53:11 +0000
Received: by outflank-mailman (input) for mailman id 316967;
 Fri, 29 Apr 2022 06:53:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkKV3-0000eY-TW; Fri, 29 Apr 2022 06:53:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkKV3-0000Ld-Rr; Fri, 29 Apr 2022 06:53:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkKV3-0005D5-GE; Fri, 29 Apr 2022 06:53:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkKV3-0000ET-Fk; Fri, 29 Apr 2022 06:53:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CDxJWTppIeJ6Il3gCxrFYTLd77tUj8YjcwiSDxryU5o=; b=7P9B5gl6R0c5v/AkwX2TycKaX5
	UZBXM84xBW/ZJ/igJ+n2FLrSKCgvPq0vO+YHYz9A5Zd137IRZssfN6H8Q0BHl5CAOK5dHNGRnrj7u
	Ai+sg1NajmK7hNyH1yQ6bZllGnelvt5ZRKpxvxmswLhX9LvOwClhfyj2wUUmsvpPZoYc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169854-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169854: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 06:53:09 +0000

flight 169854 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169854/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  691 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 07:12:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 07:12:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316978.536097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkKnl-0003AF-RC; Fri, 29 Apr 2022 07:12:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316978.536097; Fri, 29 Apr 2022 07:12:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkKnl-0003A8-OC; Fri, 29 Apr 2022 07:12:29 +0000
Received: by outflank-mailman (input) for mailman id 316978;
 Fri, 29 Apr 2022 07:12:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkKnk-0003A2-Fq
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 07:12:28 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4fcd26d-c78b-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 09:12:21 +0200 (CEST)
Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 03:12:22 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by CH2PR03MB5365.namprd03.prod.outlook.com (2603:10b6:610:a1::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Fri, 29 Apr
 2022 07:12:21 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 07:12:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4fcd26d-c78b-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651216346;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=WnpnSBuc1gVvz86m0gEDq9P6arpJ6v8lOmnnFgInYfg=;
  b=NrnLwO1dNMnF5cm/Aao+ZbnyH4vVB27M6UdSYaWEFO7PzRkcQseTmj7Q
   ltoF43iCZNEtXJJ9zVQlataNz3KQKrafANvkFz3ZfggABVOFDXMfBx+Zs
   vDSOKsgfYmf86L0WBJ+0i2x+bTkwzMoUvaS9WHz3yhzdJ7DIsjgZJliBw
   U=;
X-IronPort-RemoteIP: 104.47.66.46
X-IronPort-MID: 70614046
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:xXmRjKLHXq/I/Gq8FE+Rl5UlxSXFcZb7ZxGr2PjKsXjdYENShWdWz
 zMXWD2HPvjcambwLdoia9mwpBgA75HQn4JmGQZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh3tQ52YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MxM6oy6ETwDBaTzws1NSjMCCQxCGLITrdcrIVDn2SCS52vvViK2htBRVgQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgH86FH/uiCdxwhV/cguhUGvnTf
 YwBYCdHZxXceRxffFwQDfrSmc/33iemL2UE9jp5o4Ir2Xf3zChowYSuH9nHJ5+oGOFVjG2H8
 zeuE2PRR0ty2Mak4Tad6Xetmu/nlDv2Qp4PD6a/8uN2gVqV3SoYDxh+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxasgBkYXNZBFvwg3yuEwKHU/gWxC3ANS3hKb9lOnNAybSwn0
 BmOhdyBLSdkt6GJD36U6LaPhSiuMDIRJGVEZChsZQkM5dX5sZwwph3KR9dnVqWyi7XdAirsy
 jqHqCw/gbQ7jsMR0ai/u1fdjFqEpIXNTwMzzhXaWCSi9AwRTISofZCy4F7Xq/NJNp+ET0Kpt
 WIB3cOZ6YgmD5uAiSiMS+UlB6yy6rCONzi0qVJhFpYu9jOp+la4YJtdpjp5IS9BPskIdDDza
 WfPqAhR49lVJ3LsYqhpC79dEOwvxKnkUNH6DPbda4MUZoArLFPZuiZzeUSXwmbh1lA2lr0yM
 ouadsDqCmsGDaNgz3y9QOJ1PaIX+x3SDFj7HfjTpylLG5LEDJJJYd/p6GezU90=
IronPort-HdrOrdr: A9a23:MwEuFKHslMDvjic2pLqFYZHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79
 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH
 PQ3LsOmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZVbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczIgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxenEMLZTej8AjeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wgK7VBaM0o9
 gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ny4kY1jiaGgOKsk8SgDwgq+yxokJz8eXX7FN5KcOuf
 36ISZlXCgJCg/TNfE=
X-IronPort-AV: E=Sophos;i="5.91,297,1647316800"; 
   d="scan'208";a="70614046"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MPWu9VjjGhQwnEHUekevohaLkIGWxX8ZC9jJ3de+cpEzbdqYY5Pev1pcjn2qGz3ZRjffJVkJFiugRSSNcc7Vuqd9753gjc8LRR/J57xInsEglzeOs/AZAfiWLjtC5bPv7VRbIu84GpazdM6AjwPHsUgCvEis+tbdX+orJXf+1eYP17PhTlbgBTSxITkmIDdPf5w2QP8kPyUMBa8KgKRP9uH3qmz/AAyMNvSiFOEBHaZcwwN5s/QkG3nJLjJ9mX+1UPUtaR9RrVa9NGpdNxkCs3XdCOpoqUizyraulHGVYj1f2V2zltrCztdRtwb5Yru1jr12kDozChgd/bTzKOZVzw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E6AzNnw/PMQ8kbmS8HmtG0ziHAI8nDGsmIYY/bdJPAk=;
 b=XkLYo4y5thOd86KjuwhXlfMk83zG2V+RDWDSHh7xdYRYXYl+f4t/ZjuzPU2XAzukBmRjAzu2gKzQFzzmU26xXpVrOORKi0s+sKbMiCH31KeIDigsDeHOb+7iE3Cser/305CfjpRApTn2m9jz05Wl19Apl8Ip7ldxz01hJK5SAv0z17wizDhQ3aei8X+OOP07lb/U1G4mgZymtLkHDHUVEzBfaG3GAZlKRDND91Rgct50LvfEs7t0+pGr3B874hWKe3wfRVjiCvWoM0oYo35PTsaXO9snRzLfpjDUch6OizrMowYSu8Jlz2V5odrj4SvPJJOEeoft04uH81Qzy/kQNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E6AzNnw/PMQ8kbmS8HmtG0ziHAI8nDGsmIYY/bdJPAk=;
 b=a1jnYFdsVfb2n3IeTHM+NHezFh4Uvc2PjaX2YNPBTUzR2U29z9UjR0DaFGpGH/ydt2B+4HC0o8Mka3oaYUaG2TNVjPqli4nrrGNw7CFkR2M1awZtGPvLSYQxmhX9sfbIuDF781O4EH4AHq6QfvVm9/gZ2Dg4nXBTxxONZJpbYBI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 09:12:15 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Wei Liu <wl@xen.org>, scott.davis@starlab.io, jandryuk@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote
 after setup
Message-ID: <YmuPz1Oe1ranStXe@Air-de-Roger>
References: <20220422163458.30170-1-dpsmith@apertussolutions.com>
 <20220422163458.30170-2-dpsmith@apertussolutions.com>
 <YmZtiJ5Jf1CNOpeZ@Air-de-Roger>
 <25e701d4-62ae-278d-b165-2201459c7cee@apertussolutions.com>
 <YmebdccTfa7wKc9U@Air-de-Roger>
 <c872d5c4-9a6b-b955-556c-7974382fc4c4@apertussolutions.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c872d5c4-9a6b-b955-556c-7974382fc4c4@apertussolutions.com>
X-ClientProxiedBy: MR1P264CA0037.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 163cf798-9af8-4bb8-b0c5-08da29af9a3e
X-MS-TrafficTypeDiagnostic: CH2PR03MB5365:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<CH2PR03MB5365F433F9D20AE3B406E90B8FFC9@CH2PR03MB5365.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o0WcZ9saLL0OtzyTTBMSgT9qOHYm4zO/KcFP5VIA6tO/F0C64mjIXNRS6goRybZU+7paJB+egNa7cdTPSYUBazS4xhJqrRmNoiRdxIuXpI1S5i7r+UthAmJMCU668DJU+KlWgxhCv0vs8wLJPcR7jNmCiwZ1nJmUJfgvHuEo79xfKQEV+vcjB9+IsKLN8N1RUluLQ/mwwwLAQOxiWtF6r/bULKCua/YjsbxbuRIj93xYicD4wW9ZjFleBCost/y9kIQ/uVDWWZwExOW3AFZhSGK9uWDp5MGIFnZcKOMuYKGFtLoxcHTouTxpTMZTBqhSvOWAItaIh6pMFCmSIxt+wED0W8zYcavUDsdWQ0imLhp4JdPIzVYippTmHyVCtiosD/CSvkikVu6q1/Jd8J1LyiXzXivCisQ0SoJag6EP4Rvqr5KKR2p1AXP7/q0g7LKXXT4vzRjR8YvzN0I98hTG2KNrerjMwsr03T4INFgaAohcxvKNN5M4LlAaWqtnFpCOm+vpGJV1e955J6cL0Dg7Yywh9doomzIrEjBN4HxRcYjM0Jyte3ldAT6xireKdNWSHrHMV2EeWENO8GmjrkSkgdloplChBZt6XOlwwtqkDnNnuRctcKctUVgtNrgy6q8OGQt1CTZNY/NpNwk9Q5p6YQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(53546011)(26005)(66556008)(66946007)(6486002)(6506007)(33716001)(6512007)(6666004)(66476007)(9686003)(316002)(6916009)(86362001)(508600001)(82960400001)(38100700002)(83380400001)(186003)(2906002)(7416002)(8936002)(5660300002)(85182001)(4326008)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K0ZVL0NFbG1yZTdFQkordWxLR1hZdmhZQ1J5MGJiNHVmWnVIKzNCeDFpYlhy?=
 =?utf-8?B?ZG8rdEpZQ3NOVXRBK3NoSE9ZelZHV2JIQ0lUTmNSUG13dWsrZmxYT0prRXdE?=
 =?utf-8?B?V2g3N2xDWWZjYkZQUDdjcnhFUTRwZU1pYk5jQkdpTnM0aHdvZFUvamR0ckV4?=
 =?utf-8?B?bDFWWGxIcFRyb1JiU05Vb1lHc2I0UkpRRXpBZE5Ta1d2M0dCdjV1RERpUHJl?=
 =?utf-8?B?Vld6ck12d1hUcUdGcU1EMzBGV2VKdEhjYkdqbTRSaWZzZm9hK2hPZUx2N1I2?=
 =?utf-8?B?SS9WamdCNlNUT0FZcVhNNnJRSTFIUmNzOXB3OTl1d2RtSUwrVE01NEs5NzNL?=
 =?utf-8?B?QUhEcExXdmhyVWhKWnNmazlJY3BTd2xmNmFnTUpNS1MrN0hsQVg2L2V3RGNz?=
 =?utf-8?B?cW1YYjFFSzBLcmJrQXF6VGU5aUdVSnAveklRRTc4RXpGeVBZUUpDbDBOYUFU?=
 =?utf-8?B?dEd6czRsOWpuTEJLREt3RzIzQWFOZ1ZUK2cwV05SU1JaNEoxSERlb2dwZksx?=
 =?utf-8?B?bC9hSTRGeEVETzIvTmlYUmFaQlByWlRqMyt6cTltSEdLRDBpMW5jMC9sMDI4?=
 =?utf-8?B?VHJuK0VkMzcwczYyWmVmc0RXYW9xWHZFbGNhU3llMmFUdGtoaHJnNVpNTnh6?=
 =?utf-8?B?RTFObkdacE5WY1U2bWFsZGJmRFhRMGhrT05pVWhPV1poaUJNTnpjYVlvOVg5?=
 =?utf-8?B?cWN2WTNoWklFd3N6TDBzdHBGU0tRRlBhT1hBRXBFQW1Fc0RONzZsZ1d3ZVFQ?=
 =?utf-8?B?Q2pkeXFnUFhzV01lcjhVS09MYmsvUmlOSUZHUVR1R3k3NHc0a0xZZjdXU2hq?=
 =?utf-8?B?djY3NFVMcGhmSzBGem8zUWFiQk5ZSlhzR2srcFpRSWE1ZnNTOWI5TDNnYm8y?=
 =?utf-8?B?WEF0QithQ1M2WHhlSVBGNzdPRGkra3hTSmNoQUgwNXowZUNaQ3JhQ2hYMGUv?=
 =?utf-8?B?RVFoWDhjbnNCVWs3L1Z3eCtTY1NkMy8wbE1ZUGhhL1VrL20xc3VrQnByRnpv?=
 =?utf-8?B?MjVza3JrTEtwaFJjY0pqWitYeFZ4Wi9vanh0MkxiblJTYjJjZEtBZENURWtD?=
 =?utf-8?B?RlR3eW5IRzE2dmx1QVlmWUlTbFV1UVlrTTVIRDRIZHhQODZZbzA1U0MyRndl?=
 =?utf-8?B?bGhZcDNhRXIrWFN6R2NGck12VTcwdTJ0dWo3d1g3Wk9SNEtmTVlHR2EyQlBW?=
 =?utf-8?B?ZHJTUEJLQ0FURVBhM1B6UkhzY2hIdjJJV1ZTRkI5cHpabWRHRElsS00waW4w?=
 =?utf-8?B?bk9QcUtDaUY4eGRaZTE1TkNRcXdkdjRhdmtrOTBNNExzMjZ0VUZ6N3RpWFdk?=
 =?utf-8?B?K1ZMVjJWbVZqZ0dnUW1PaXI1N1JWd3lJcGR2c0QrMTdQVGR3WFdYY3VUWHRS?=
 =?utf-8?B?R0JBZHp3VnZwR0ZJSUFSSURrS0tXRitkQWhxa3RLOE9ud2Rwek5wUkx0aklJ?=
 =?utf-8?B?a3VXeEV4RTljckY5UzhndWg0dDA5N2tqM045aFRCNmFnTTVlQzkrcnR0RXl2?=
 =?utf-8?B?VmdvNmxvYlRVSSs0ZkF0UU8zU1pvQTVLMkordkNpWDU1anArREhTWElyZDJh?=
 =?utf-8?B?Ri9sWFJPR2o5dlFxRHZwVTdsd2ZhNVd6VzhXazZUTUlTOTlGTlp0QlVEVDZO?=
 =?utf-8?B?U1JXbGZrWTZTWGc2V0RyRkJBdEFWTzRVemRudkhxcVlPNisxUlNIaTNmODRQ?=
 =?utf-8?B?TFlKNDQ0cmMvQk5rRW93SEhMUDJCNDE4MGFxa0t2MU1xRWNKVGk4akp3V1U1?=
 =?utf-8?B?dmFwTkJVUXRXYmdFb1dITFNSV1UvZ3M2ak83S3lIV0NqbVFuZWtpeVd5VUM4?=
 =?utf-8?B?Zy93eFpBZmNleVFEOGY2UXhlTmllK0ppdU5LbFphZUtnUzJPNFV4MVNock5a?=
 =?utf-8?B?bnlUOVdMYnhSVmYyalFYS294bVpJNTIwTWJwajJodU13ZHdvSHlvNW5CT1Rx?=
 =?utf-8?B?U25pcWpSd2krMmFEL095VGZya3RzMExDb3dzREIwUEdGdFliK0QwMXZ2aXNz?=
 =?utf-8?B?WklFUDFyM3ZhdXloaEdPWmV0SytMWG9SckdPVDZoR25XcW5LRmhrZXdxZG0r?=
 =?utf-8?B?NFlqd0h3T3E5MjVJMEdTNE4raHpFSXVZUW14TlI1MUdOK2NQblZRN1VGQ0hn?=
 =?utf-8?B?azhPRnVVRGxHQUUxTGR4dXU3VGZGU1lwaHREaU8zYnNyaVZUUlhJa2NrOHVX?=
 =?utf-8?B?ZUo4eEhhTFYzOFFGczlQWlc4ZFVRbDcrbTZDMUpBaGRqOTEvak5CckdRQ1Bl?=
 =?utf-8?B?ZS8zbFhLWnJNNk9WZENXODdpT2l4YzYwMUZkbGUrSEt4MVh5UFV2OE1zSGV0?=
 =?utf-8?B?Nk5Ld2hrNEtmbytHdW5tMWxNejRKWHpuVmRXMnlZZ0JkZGVsZXJoNEk5ZDBO?=
 =?utf-8?Q?WiDS9PgoN21Izsb4=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 163cf798-9af8-4bb8-b0c5-08da29af9a3e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 07:12:21.2192
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sTvzmpkfTfMihzusuYQsfg6zMNBavXMKEjoxu9IBJa7u2JSrFb0rPHsPBuYC0sUPPIG0CA+MJn7UXiHLmPZ1vA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5365

On Thu, Apr 28, 2022 at 10:57:42AM -0400, Daniel P. Smith wrote:
> On 4/26/22 03:12, Roger Pau Monné wrote:
> > On Mon, Apr 25, 2022 at 12:39:17PM -0400, Daniel P. Smith wrote:
> >> On 4/25/22 05:44, Roger Pau Monné wrote:
> >>> On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
> >>>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> >>>> index 0bf63ffa84..8a62de2fd6 100644
> >>>> --- a/xen/xsm/flask/hooks.c
> >>>> +++ b/xen/xsm/flask/hooks.c
> >>>> @@ -186,6 +186,26 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
> >>>>      return 0;
> >>>>  }
> >>>>  
> >>>> +static int cf_check flask_set_system_active(void)
> >>>> +{
> >>>> +    struct domain *d = current->domain;
> >>>
> >>> Nit: you should also add the assert for d->is_privileged, I don't see
> >>> a reason for the xsm and flask functions to differ in that regard.
> >>
> >> This goes back to an issued I have raised before, is_privileged really
> >> encompasses two properties of a domain. Whether the domain is filling
> >> the special control domain role versus what accesses the domain has
> >> based on the context under which is_control_domain() is called. For
> >> instance the function init_domain_msr_policy() uses is_control_domain()
> >> not to make an access control decision but configure behavior. Under
> >> flask is_privileged no longer reflects the accesses a domain with it set
> >> will have, thus whether it is cleared when flask is enabled is
> >> irrelevant as far as flask is concerned. For the ASSERT, what matters is
> >> that the label was set to xenboot_t on construction and that it was not
> >> changed before reaching this point. Or in a short form, when under the
> >> default policy the expected state is concerned with is_privilege while
> >> for flask it is only the SID.
> > 
> > I certainly don't care that much, but you do set d->is_privileged =
> > false in flask_set_system_active, hence it would seem logic to expect
> > d->is_privileged == true also?
> 
> Yes, I did this just for consistency not because there is any
> significance of is_privilege on the idle domain, in both contexts for
> which is_privileged is used, when flask is the enforcing policy.
> 
> > If not for anything else, just to assert that the function is not
> > called twice.
> 
> Under this patch flask_set_system_active() is effectively a no-op, so
> calling it twice has no effect. In the next patch flask_set_system()
> becomes a real check and there is an ASSERT on the SID as that is the
> relevant context under flask and will ensure calling only once.
> 
> In the end I can add the ASSERT but it would be adding it for the sake
> of adding it as it would not be protecting the hypervisor from moving
> into an incorrect state.

If flask_set_system_active() is really a no-op then just adding a
comment in that regard and not touching is_privileged would be OK to
me, as otherwise I think it's confusing.

In any case I would leave that to the flask maintainers to decide.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 07:46:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 07:46:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.316985.536108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLKz-0006St-DS; Fri, 29 Apr 2022 07:46:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 316985.536108; Fri, 29 Apr 2022 07:46:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLKz-0006Sm-A9; Fri, 29 Apr 2022 07:46:49 +0000
Received: by outflank-mailman (input) for mailman id 316985;
 Fri, 29 Apr 2022 07:46:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkLKy-0006Sc-13; Fri, 29 Apr 2022 07:46:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkLKx-0001Xn-SM; Fri, 29 Apr 2022 07:46:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkLKx-00007g-Fn; Fri, 29 Apr 2022 07:46:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkLKx-0004TT-FM; Fri, 29 Apr 2022 07:46:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t4HUCZzIf3hZpr3dLo27S+3RwJEUARso85VllNE12t8=; b=ZQx69VV2FUwqYAGS1eAuagJJnA
	HCQvFkTE+m2DGkH+3FaSJx6J5eM+EEAgw90I7GxDLnPpH8VgIXQI2Fwpe6C++lt0yvIbLBLzo5puU
	soM4pxM9TuY4ZSD9W9+64v/xnucJWDkBNBalOoDMJ5xSeFrJvRJU2YJ3+xi30xltdYA8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169819-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169819: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-examine:reboot:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl-thunderx:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl:xen-boot:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=da28439ba55b8a571032b3358af567cff749f612
X-Osstest-Versions-That:
    xen=3f5d61466345ed2213de2d7e391b6cd6d4b86015
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 07:46:47 +0000

flight 169819 xen-unstable real [real]
flight 169843 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169819/
http://logs.test-lab.xenproject.org/osstest/logs/169843/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 169775
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl-thunderx  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 169775

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169843-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169775
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169775
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169775
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169775
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169775
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169775
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169775
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169775
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169775
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169775
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169775
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169775
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  da28439ba55b8a571032b3358af567cff749f612
baseline version:
 xen                  3f5d61466345ed2213de2d7e391b6cd6d4b86015

Last test of basis   169775  2022-04-27 08:15:40 Z    1 days
Failing since        169798  2022-04-27 22:39:22 Z    1 days    2 attempts
Testing same since   169819  2022-04-28 15:28:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Dario Faggioli <dfaggioli@suse.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit da28439ba55b8a571032b3358af567cff749f612
Author: Michal Orzel <michal.orzel@arm.com>
Date:   Wed Apr 27 11:49:41 2022 +0200

    drivers/exynos4210: Remove unused-but-set variable
    
    Function exynos4210_uart_init_preirq defines and sets a variable
    divisor but does not make use of it. Remove the definition and comment
    out the assignment as this function already has some TODOs.
    
    Signed-off-by: Michal Orzel <michal.orzel@arm.com>
    Acked-by: Julien Grall <jgrall@amazon.com>
    Acked-by: Stefano Stabellini <sstabellini@kernel.org>

commit 1f71c11b882ac2b6d32260e929a3f9f19d97fdf7
Author: Michal Orzel <michal.orzel@arm.com>
Date:   Wed Apr 27 11:49:40 2022 +0200

    platforms/omap: Remove unused-but-set variable
    
    Function omap5_init_time defines and sets the variable den but does not
    make use of it. Remove this variable.
    
    Signed-off-by: Michal Orzel <michal.orzel@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>

commit 1afe55905427b7e25936388c65a29c2bbb280bc8
Author: Michal Orzel <michal.orzel@arm.com>
Date:   Wed Apr 27 11:49:39 2022 +0200

    platforms/xgene: Make use of dt_device_get_address return value
    
    Currently function xgene_check_pirq_eoi assigns the return value of
    dt_device_get_address to a variable res but does not make use of it.
    Fix it by making use of res in the condition checking the result of a
    call to dt_device_get_address instead of checking the address stored in
    dbase.
    
    Signed-off-by: Michal Orzel <michal.orzel@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>

commit 4026c0d4c4811b8337b4eab3cdea7037cbfb0eb4
Author: Michal Orzel <michal.orzel@arm.com>
Date:   Wed Apr 27 11:49:38 2022 +0200

    xen/sched: Remove unused-but-set variable
    
    Function schedule_cpu_add defines and sets a variable old_unit but
    does not make use of it. Remove this variable.
    
    Signed-off-by: Michal Orzel <michal.orzel@arm.com>
    Reviewed-by: Juergen Gross <jgross@suse.com>
    Acked-by: Dario Faggioli <dfaggioli@suse.com>

commit 2845588e398d8e631f08d304e80c5f94f52c3643
Author: Michal Orzel <michal.orzel@arm.com>
Date:   Wed Apr 27 11:49:37 2022 +0200

    xen/arm: smmu.c: Remove unused-but-set variable
    
    Function arm_smmu_init_context_bank defines and sets a variable
    gr0_base but does not make use of it. Remove this variable.
    
    Signed-off-by: Michal Orzel <michal.orzel@arm.com>
    Acked-by: Julien Grall <jgrall@amazon.com>

commit 9b4f9b9af235e21568f8882e8137397af7f86414
Author: Michal Orzel <michal.orzel@arm.com>
Date:   Wed Apr 27 11:49:35 2022 +0200

    efi/boot.c: Remove unused-but-set variable
    
    Function efi_start defines and sets a variable size but does not
    make use of it. Remove this variable.
    
    Signed-off-by: Michal Orzel <michal.orzel@arm.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 2a2de68a60f4ff8f322c0ad7873c1e6048c6fca4
Author: Michal Orzel <michal.orzel@arm.com>
Date:   Wed Apr 27 11:49:34 2022 +0200

    xen/arm: bootfdt.c: Remove unused-but-set variable
    
    Function device_tree_node_compatible defines and sets a variable
    mlen but does not make use of it. Remove this variable.
    
    Signed-off-by: Michal Orzel <michal.orzel@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>

commit 53b705d02cec03861044e673536586bd1b2443bd
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Thu Mar 24 13:37:05 2022 +0000

    xen/arm64: io: Handle data abort due to cache maintenance instructions
    
    When the data abort is caused due to cache maintenance for an address,
    there are three scenarios:-
    
    1. Address belonging to a non emulated region - For this, Xen should
    set the corresponding bit in the translation table entry to valid and
    return to the guest to retry the instruction. This can happen sometimes
    as Xen need to set the translation table entry to invalid. (for eg
    'Break-Before-Make' sequence). Xen returns to the guest to retry the
    instruction.
    
    2. Address belongs to an emulated region - Xen should ignore the
    instruction (ie increment the PC) and return to the guest.
    
    3. Address is invalid - Xen should forward the data abort to the guest.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    [julien: Don't initialize p.size to 1 << info->dabt.size]
    Reviewed-by: Julien Grall <jgrall@amazon.com>

commit fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
Author: David Vrabel <dvrabel@amazon.co.uk>
Date:   Tue Apr 26 10:33:01 2022 +0200

    page_alloc: assert IRQs are enabled in heap alloc/free
    
    Heap pages can only be safely allocated and freed with interrupts
    enabled as they may require a TLB flush which may send IPIs (on x86).
    
    Normally spinlock debugging would catch calls from the incorrect
    context, but not from stop_machine_run() action functions as these are
    called with spin lock debugging disabled.
    
    Enhance the assertions in alloc_xenheap_pages() and
    alloc_domheap_pages() to check interrupts are enabled. For consistency
    the same asserts are used when freeing heap pages.
    
    As an exception, when only 1 PCPU is online, allocations are permitted
    with interrupts disabled as any TLB flushes would be local only. This
    is necessary during early boot.
    
    Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit fbd2445558beff90eb9607308f0845b18a7a2b5a
Author: Julien Grall <jgrall@amazon.com>
Date:   Tue Apr 26 21:06:29 2022 +0100

    xen/arm: alternative: Don't call vmap() within stop_machine_run()
    
    Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap
    alloc/free" extended the checks in the buddy allocator to catch
    any use of the helpers from context with interrupts disabled.
    
    Unfortunately, the rule is not followed in the alternative code and
    this will result to crash at boot with debug enabled:
    
    (XEN) Xen call trace:
    (XEN)    [<0022a510>] alloc_xenheap_pages+0x120/0x150 (PC)
    (XEN)    [<00000000>] 00000000 (LR)
    (XEN)    [<002736ac>] arch/arm/mm.c#xen_pt_update+0x144/0x6e4
    (XEN)    [<002740d4>] map_pages_to_xen+0x10/0x20
    (XEN)    [<00236864>] __vmap+0x400/0x4a4
    (XEN)    [<0026aee8>] arch/arm/alternative.c#__apply_alternatives_multi_stop+0x144/0x1ec
    (XEN)    [<0022fe40>] stop_machine_run+0x23c/0x300
    (XEN)    [<002c40c4>] apply_alternatives_all+0x34/0x5c
    (XEN)    [<002ce3e8>] start_xen+0xcb8/0x1024
    (XEN)    [<00200068>] arch/arm/arm32/head.o#primary_switched+0xc/0x1c
    
    The interrupts will be disabled by the state machine in stop_machine_run(),
    hence why the ASSERT is hit.
    
    For now the patch extending the checks has been reverted, but it would
    be good to re-introduce it (allocation with interrupts disabled is not
    desirable).
    
    So move the re-mapping of Xen to the caller of stop_machine_run().
    
    Signed-off-by: Julien Grall <jgrall@amazon.com>
    Cc: David Vrabel <dvrabel@amazon.co.uk>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit 163071b1800304c962756789b4ef0ddb978059ba
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Apr 27 09:15:03 2022 +0200

    EFI: don't mistakenly delete a file we never installed
    
    Just like for "install", make dealing with xen.efi on the EFI partition
    dependent upon mount point and vendor directory being known.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

commit 0f4fd6b6d805c89d19843c7ad70adc772a7d1203
Author: Jason Andryuk <jandryuk@gmail.com>
Date:   Wed Apr 27 09:14:30 2022 +0200

    libxl: retry QMP PCI device_add
    
    PCI device assignment to an HVM with stubdom is potentially racy.  First
    the PCI device is assigned to the stubdom via the PV PCI protocol.  Then
    QEMU is sent a QMP command to attach the PCI device to QEMU running
    within the stubdom.  However, the sysfs entries within the stubdom may
    not have appeared by the time QEMU receives the device_add command
    resulting in errors like:
    
    libxl_qmp.c:1838:qmp_ev_parse_error_messages:Domain 10:Could not open '/sys/bus/pci/devices/0000:00:1f.3/config': No such file or directory
    
    This patch retries the device assignment up to 10 times with a 1 second
    delay between.  That roughly matches the overall hotplug timeout for
    pci_add_timeout.  pci_add_timeout's initialization is moved to
    do_pci_add since retries call into pci_add_qmp_device_add again.
    
    The qmp_ev_parse_error_messages error is still printed since it happens
    at a lower level than the pci code controlling the retries.  With that,
    the "Retrying PCI add %d" message is also printed at ERROR level to
    clarify what is happening.
    
    Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
    Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

commit 010bc50adaf58c78db4ad1329b0130d96e13f8e2
Author: Tamas K Lengyel <tamas.lengyel@intel.com>
Date:   Wed Apr 27 09:13:39 2022 +0200

    x86/vmx: add hvm functions to get/set non-register state
    
    During VM forking and resetting a failed vmentry has been observed due
    to the guest non-register state going out-of-sync with the guest register
    state. For example, a VM fork reset right after a STI instruction can trigger
    the failed entry. This is due to the guest non-register state not being saved
    from the parent VM, thus the reset operation only copies the register state.
    
    Fix this by adding a new pair of hvm functions to get/set the guest
    non-register state so that the overall vCPU state remains in sync.
    
    Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
    Reviewed-by: Kevin Tian <kevin.tian@intel.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 08:01:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 08:01:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317002.536124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLZR-0000z4-9j; Fri, 29 Apr 2022 08:01:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317002.536124; Fri, 29 Apr 2022 08:01:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLZR-0000yx-6d; Fri, 29 Apr 2022 08:01:45 +0000
Received: by outflank-mailman (input) for mailman id 317002;
 Fri, 29 Apr 2022 08:01:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkLZP-0000yr-K4
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 08:01:43 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 947468a3-c792-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 10:01:40 +0200 (CEST)
Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 04:01:06 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by MN2PR03MB4990.namprd03.prod.outlook.com (2603:10b6:208:1a3::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 29 Apr
 2022 08:01:01 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 08:01:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 947468a3-c792-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651219300;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=OyGadDYn6zemyI5WxiYTOtgtE57hG7h4gq/cGghy8gI=;
  b=gkZ/CuKHs8p1kD7zsg+IlawG8imXGxsOgVoJgbjZw8kku9+nD7VOAHwR
   FGPp1XIwUpkmkNRatikqv3llWIOcdStTFJW2KZ2weiukh6A2b29FhND6+
   BXNjolGDD/DjuZCyBd5b+D42A69pJ1J9K4PDD/MZ330ulT9+bh8Zf1Jyx
   s=;
X-IronPort-RemoteIP: 104.47.55.172
X-IronPort-MID: 70616881
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:FPY93aozmNirz/4KLtvYZe5z3NdeBmIOZBIvgKrLsJaIsI4StFCzt
 garIBnVbPaLNGb2et9/aoy18RtS7ZXRx9VgTgZkqHg2HnlB9puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvR4
 4Kq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBO5XigbwwaytjSn9ePq5d9b7HeCicrpnGp6HGWyOEL/RGKmgTZNdd0MAnRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFgXFp2Zom8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK/fRuvTiDlWSd1pDtbdnTcOzaa/l2l2W8/
 j38xUvULA0FYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHyLpBkHQPJLDvY3rgqKz8L86QGDB3NCSSVdcts4r8wnbTsw3
 1SNkpXiAjkHjVGOYXeU97PRpzXiPyEQdDUGfXVdElFD5MT/qoYuiB6JVsxkDKO+ktzyH3f33
 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zlyGNo55xmuVvLKYWrE=
IronPort-HdrOrdr: A9a23:sVLBDa0gvxEsEHb/nwkdnAqjBTRyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4exoS5PwOk80kqQFq7X5XI3SFzUO3VHFEGgM1/qH/9SNIUzDH6tmpN
 5dmstFeZDN5DpB/KHHCWCDer5OruVvsprY49s2pE0dLj2CHpsQijuRfTzrcHGeKjMnObMJUL
 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63
 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR
 /30lMd1opImjTslyqO0GHQMkHboUsTAjnZuBOlaDLY0LPErD5WMbs8uatJNhTe8EYup9d6ze
 ZC2H+YrYNeCVfakD36/MWgbWAdqqOYmwtXrQcotQ0pbWLeUs4jkaUPuEdOVJsQFiPz744qVO
 FoEcHH/f5TNVeXdWrQsGVjyMGlGi1bJGbPfmES/siOlzRGlnFwyEUVgMQZg3cb7Zo4D51J/f
 7NPKhknKxHCsUWcaV+DuEcRtbfMB2FfTvcdGaJZVj3HqAOPHzA75bx/bUu/emvPIcFyZMj8a
 6xJW+wdVRCCX4GJff+raGjqCq9PllVdQ6duv1j2w==
X-IronPort-AV: E=Sophos;i="5.91,297,1647316800"; 
   d="scan'208";a="70616881"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V5peLV+w86OqGW35mE9hkx7E/vIkZ+07RbKqx1/ESh3r7R4+JnU4K1mwPO5uZCgrgl+asqdxeAjHFD1PBI16JwT4DKfW5xI3cHdXRL8cScZXJZEcffwOT3nQhbatZHdTCgeu8h4wCVQYtPX2pNu9JXbG5t2H/WHTfiX3mlgr8xLeif5V1e1y3rq660+YJ7p91GAxLXb6bkOW+QUOS1gbwh36j0ZayrE0GIAtpg+Qmy/GaSO1mNX9wmgeY4nJOTeQ4v6z88YPMvPVhDQkOBJvroep/lbqwD4q5YCf7Wd6HyknRWSggQj1Iga14LxLQVTsd9Vm7O3UCuY7b6IsSJqgbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=14SMqwalnV57Nv6T3dFcisW08hHEupf+aMwPQGT0INA=;
 b=HunJynxUEHxHoKtRt1sZavBrvqMAgAry6JvZPV5KR2D7YMw+kgTQ0fPC/6BHZXPKQpOkMbU9AqxeOfRg7576e9fwqJ1C2Ijyk7oj6u2nFH3YX3VPRYk+n4ASTm2ru+orMzqDv87LZGhcptWoaDLyZESopBHUnTBebCtGY3bwTS/ugQU9LePBjkx4j9GayRvttsV3JhIxklCuxfcTIlC+jhLTJEr7dFVL7+9FVtgejfl2iHbC3kggosYaqob+seif+6F8UD2qqrlrJtV4Nb3UOg6kTH6cOoryn6ounNoL1pNl3uSUVSV3LAlu9rGjKpoB2XuXxx1MG1CBJiSX1rezkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=14SMqwalnV57Nv6T3dFcisW08hHEupf+aMwPQGT0INA=;
 b=rUe4bHMFUu14eZ/78/Wp/wZhEhzx5j4LxRbHR2aWwVl2D+hAjggOkwgTf34XwzV92goXSiAQCKx9r10Ia833lc9zL2yB+dFvJPlRyNsE0rgveKaAqR/a7N+JN9tVZPNG9jh2QPw0IOMXjKgNT8Rgks9wIuJ/IlbjZyX3LJ6lR10=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 10:00:57 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: x86/PV: (lack of) MTRR exposure
Message-ID: <YmubOeYPqW5mBNy4@Air-de-Roger>
References: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
X-ClientProxiedBy: MR1P264CA0032.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2f::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 25cda98d-e31e-4e73-7f81-08da29b666ff
X-MS-TrafficTypeDiagnostic: MN2PR03MB4990:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<MN2PR03MB49907C4DDA5328C6613C79D18FFC9@MN2PR03MB4990.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HbAAQTqLMjalbFKBlRFN79Aplm7/p04kHuTBLCHo5Bk11p5iecOuC89CNwESDunTHBsek9+4Cpbj5VIKOjeTh5p309zwfbPn4omtILV00+pfLMn5ICfLmgxw9BiEiDvIxmn5JT07M3+xubuEeO4VeFJK4gJ6lE/hXS8nJc/QDZWxfO7Lv41an1kl//poR6xBXfP1h59HauxG+gSXLR7LtZ2IltXkIAYwLVb+FggD6ZSXavCoqY8/ZkkrVHydVGCpZv9K4WkdjFoh7UGwE+tD2TLoJlY0R/5yMrTREUzBfUfawWB5R1sMN8M60Fr0u93zSaExVgswitP7rCJsXqaPYA/Bynpz0tYzOv2EuUvsWkVDa7/Ns64ZCr9CrPPvgiieRl9h3R8W5sIuy5qd+eSlonOmp0UwhO8yVgBbMiVbR7V6GAp8rV2tfHDRRfJTstgxKBKKfiztCzVbB1WjXAMgU1JG4rZRIyI7UvlEKz/ZEhppFh3zYFTBhsW4PYPO4ksIwaRTVz6xk+3+eH06kPRdZNnzBd/ufjTNXyY0oe7Esmsa4tpKByy9s62gn8S2SbaAl/RwmkDZmQN4Xxl3+qpq1BLIV/a0BJltKQHoqm1Dtag4YEQHq6U3O9J/PS4xkIVZ7sbo/cr6gAFfmBSa/9dJ3A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(6666004)(85182001)(8676002)(33716001)(4326008)(66556008)(66476007)(5660300002)(66946007)(508600001)(82960400001)(8936002)(6486002)(6916009)(2906002)(83380400001)(38100700002)(86362001)(316002)(9686003)(6512007)(26005)(54906003)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ci9mdUIxV1Z4RnAyb2tvMUtOT2hPNmVOUjNiYm5ZdTk5WDU1MWdybUREK3J3?=
 =?utf-8?B?bSsvQUNkNS9OaDcxclBERkRFTHVPcUtHYmR0b3d3T3ZxcGdNWVlUMTJHMXky?=
 =?utf-8?B?SWladzVNQVVwSGZPS3k0UHlVNVlyY3dxUTNtV3o2WnJmRXp2REFCbERXWTVz?=
 =?utf-8?B?QjN5eG80UDVXL1FqQzhCTU92eXRmSGFYejhNbXRBT1l2aHd1Q21INC9wWS95?=
 =?utf-8?B?QWIxdzRucE5RUlhKUWFWVkJsbGp0YjhiUW1JMW5GNkovNExEbkhJUHRSMGlv?=
 =?utf-8?B?dnBJMnkwb1ZrTCs3QUNNZDN5YXZuQXhIbzlWWllGK1BXL2QwSWt3dWloa1gy?=
 =?utf-8?B?UHhiTmJiSU8xZlFQaFlrRzRTc2VpZnZQTXZLeDBGMUY1UlRYVytJbjhpT1Jt?=
 =?utf-8?B?NTJqZVgrbmNWRTlwY3gvTGVWZ0FQOXFzeDlmb3JMLytBTUgzOWErUTU2Zlc2?=
 =?utf-8?B?aWhnZ2svVWJiMkhqT2YyY01pckorSEFOVTlZeW1ncldQYVE2L1VzTVYvU2g2?=
 =?utf-8?B?bGN1cFBrejRKN1IrZ3JSb0hvS2k1NlQ1eGhCWXRJVVJsOFpJTUxBLzh2K3Nl?=
 =?utf-8?B?MlJTS29Od1dzL0JwUG5tMjdJb29CbTRITVZUbndNSmljOUU0bTFKQ3ZQcFlN?=
 =?utf-8?B?Y3NmWWpNUmFQUCtFckFibHEzUEZVcWd5TzY4cW8wZk84cnNXUjZLelo2Znl5?=
 =?utf-8?B?U0w2dzVoc3RJR0xQREtZZkZJNGsySGpackJnWEFNU1IyY3dKZDZpV1VlV0Fz?=
 =?utf-8?B?VDZ5eFNuMk45Z3RpT2d4cm14ejZMV2hhdWFhbng2NUJCQUxlZzYwZHk5SnFV?=
 =?utf-8?B?bWFWU1N3L2dxNzhjTDYzaVp0bVF6MU93RXU0MUlBVnpzanRnTWd0R24wdFAr?=
 =?utf-8?B?SjlLM3N1dk93aHJ2dHU3MjBSQmZxOFBXWHYxSjRmazRuZHNpai9ET004Q3Ji?=
 =?utf-8?B?dVNmL24vUEtNZUdxeHMzUVlIRWFOb3Q5NVd2cHVPVGozRHpZd094ZS93aDcw?=
 =?utf-8?B?akJXU2ppSGNzQSswRUhGcndQMlhPeDFvUWZSMERjbVMwTVpERFZCcXJBd3h1?=
 =?utf-8?B?UVVnYnZhZ2crV2FIYWtSQmllTXhHUXhjK1hwQTF2UWZENE54QzlnSXVGdTQ4?=
 =?utf-8?B?SmlNNCtzcVMyM2RNRXNQZURyYWJqcThrL1d3L2RqazhyeW1PWStIRGZTR0VV?=
 =?utf-8?B?cHVManFrb09FKzNQbEdwVDJZYTgyTmlRWTVmMmlzYTBQUU5qRHdVZlZKVmM2?=
 =?utf-8?B?bW96REZUUVR0VjZPSmFJZmx5YzhZU1F2a0hXRm5Td3h6Q0p5WVNjdlhVVHpX?=
 =?utf-8?B?ak41T1J3R1JYRm1yNXRhVGw0RHU1R3VlRzg5VEpTM05TNnJRWlUzVytRa2Ir?=
 =?utf-8?B?U25QYUQ5akhxTytwQXZTOXZsaFVDUVZBalZvaFRJZ2dtRm5YcWgxS2psSW1O?=
 =?utf-8?B?UjVOZkIxRnd1OE5Sd21HOGlRY2JnQ0JVUHIrYjZGQThTbjJMS2t5SllwSGdK?=
 =?utf-8?B?bUpnMGlOY0pjTFIrUHAvVXN3bmdnRVVvY0ZpNDh4TDhVc1FlMDlRbjVpcXQx?=
 =?utf-8?B?anM3SzExOVI4YzEzbWw0d1g2QTM5K2ZBVXNRNnRuZ2dGNEJTVG40L2I3K1NU?=
 =?utf-8?B?WUcrUC9yYU5Ud1NOQUFtNUhpTGNXOXRNTUFIM09UWGp5ZlNseEptOUxyMHhB?=
 =?utf-8?B?QjZINUhSa2RsMHUxeXpwT2dacm1EUXVWRUpYbWk2VWlUdHpoY20vMjVPMTRn?=
 =?utf-8?B?dDNuTWxHSklOUlFtQ3YvMGcybWU2SzJWaUJFUERadFQvOHB4QVdrU3Q0SzZl?=
 =?utf-8?B?RkRrS3VqbHBDSzhYb0Fkb0JQa1RDSmUzQUVYN3dNWDNNMng1Sm5WdmQ4Wm93?=
 =?utf-8?B?VnpzclRXMS8xSTI2SGNuTUtUU1JrV3VVVGlJTWo1UlVzM05tMnplTHZ6T0py?=
 =?utf-8?B?V3c2cE04Y0V4anhTTkRMWnFHaTNkV2ZrNXhmdGlNQXBIVmhOUTBmZmI1R2ZE?=
 =?utf-8?B?Mnc5Skd4RlpXRks1S0VRSTVaUVZKemRlOFlVNXVITDJVenBJL2RaR3VCUSt1?=
 =?utf-8?B?eGJTSHhkM21sdHJwR1BsSDJtNERuV1Fkd2FvRzNGQWVlOHE3NEVxblVTYTRl?=
 =?utf-8?B?SWRsZ2YzZmRUR29kNjRrYXNJOERUQlFqREpVTGgwQ2RBN2ZVQVk3VUFzdWFq?=
 =?utf-8?B?TEcrU2lVSWJDdGh4eGpEMGNxcks5RUh1MlIvT0QrcDV4aG1lQW1jYklYaHc3?=
 =?utf-8?B?OUxOV1J5dGJHcXU2d3p5OXYxcEN0ME4zRG9OVVZHd0tRMUhNT2dTY3NQUWVo?=
 =?utf-8?B?ajJma2M4U1hRQU9NaDVwZmZvWWEvUGpQL1kwOEVOQXVsc1lldGZuMlZ1SzIw?=
 =?utf-8?Q?SIgHsoBxkhqFm5Y0=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25cda98d-e31e-4e73-7f81-08da29b666ff
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:01:01.7184
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cWkLmOCV2txPKZOyZACCvLWZtKde3egO/DBipo1YVIJkxPmHfLFuwvfyeZ1DA1+Akt75hpYZLokxIUg3scfK5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4990

On Thu, Apr 28, 2022 at 05:53:17PM +0200, Jan Beulich wrote:
> Hello,
> 
> in the course of analyzing the i915 driver causing boot to fail in
> Linux 5.18 I found that Linux, for all the years, has been running
> in PV mode as if PAT was (mostly) disabled. This is a result of
> them tying PAT initialization to MTRR initialization, while we
> offer PAT but not MTRR in CPUID output. This was different before
> our moving to CPU featuresets, and as such one could view this
> behavior as a regression from that change.
> 
> The first question here is whether not exposing MTRR as a feature
> was really intended, in particular also for PV Dom0. The XenoLinux
> kernel and its forward ports did make use of XENPF_*_memtype to
> deal with MTRRs. That's functionality which (maybe for a good
> reason) never made it into the pvops kernel. Note that PVH Dom0
> does have access to the original settings, as the host values are
> used as initial state there.
> 
> The next question would be how we could go about improving the
> situation. For the particular issue in 5.18 I've found a relatively
> simple solution [1] (which also looks to help graphics performance
> on other systems, according to my initial observations with using
> the change), albeit its simplicity likely means it either is wrong
> in some way, or might not be liked for looking hacky and/or abusive.

I wonder whether the patch needs to be limited to the CPUID Hypervisor
bit being present.  If the PAT MSR is readable and returns a value !=
0 then PAT should be available?

I guess we should instead check that the current PAT value matches
what Linux expects, before declaring PAT enabled?

Note there's already a comment in init_cache_modes that refers to Xen
in the check for PAT CPUID bit.  We might want to expand that comment
(or add one to the new check you are adding).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 08:10:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 08:10:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317009.536136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLhm-0002QB-67; Fri, 29 Apr 2022 08:10:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317009.536136; Fri, 29 Apr 2022 08:10:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLhm-0002Q4-1e; Fri, 29 Apr 2022 08:10:22 +0000
Received: by outflank-mailman (input) for mailman id 317009;
 Fri, 29 Apr 2022 08:10:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkLhl-0002Py-3N
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 08:10:21 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cdef817a-c793-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 10:10:19 +0200 (CEST)
Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 04:10:16 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BL0PR03MB4178.namprd03.prod.outlook.com (2603:10b6:208:67::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 08:10:12 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 08:10:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdef817a-c793-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651219819;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=I4k0WBWYj+5b9sQGJpTwboduel8P7U3Y7PIZAQosLJg=;
  b=Gm2UxnvLsdxD5HMONB7LyijRbfU2PRycSoWypz2wysz9ziY3QEnkHYRx
   TxWSeQBIZdmw+ONjFaNFEukQvZlioCeOnOx2xPRy8R1UgANFpL3G5fRT1
   H7VvTfvLcyYdK1almNb3XANRp95ri23uIBQ42vuL3shywH/1Jw2BvsCXG
   Y=;
X-IronPort-RemoteIP: 104.47.58.107
X-IronPort-MID: 69608566
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:U7g7+avBo7k2hr9GG2x6VRpaAOfnVCJfMUV32f8akzHdYApBsoF/q
 tZmKT+OM/aDZGf3fd13aN+2pE8B7ZTSy4QyTApuqXwwRHgQ+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW1/X6
 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi9yOpPFqbsxbiNKTRNVBIoX95rpInSg5Jn7I03uKxMAwt1IJWRvZcg037gyBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5o2aiiHt6HD
 yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgAzE+/JnvjaNpOB3+KHUHsTLZc2HfNRcumfIn
 zqd7UO+Ow5PYbRzzhLAqBpAnNTnnyn2RYYTH72Q7eNxjRuYwWl7IAISfUu2p7++kEHWc8JSL
 QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUHBBqlz6PV50OVAzYCRzsYMNg+7pZuGnoty
 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd17UZxRmYL
 +i2kRUD
IronPort-HdrOrdr: A9a23:vFSlYqBBxXzwwRjlHeg/sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80lKQFmLX5WI3PYOCIgguVxe1ZnOjfKnjbalbDH41mpN
 tdmspFebrN5DFB5K6VgTVQUexQpuVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dNMEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfXHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+06VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qY5+FNuAxem0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg72w
 31CNUWqFhwdL5mUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q
 6xGm9liQ==
X-IronPort-AV: E=Sophos;i="5.91,297,1647316800"; 
   d="scan'208";a="69608566"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=irGbea6lB8ijBfIcamUvlgeBRnSR0pSSL/qDdP98Fi2RYVyUI7Rh8vU3guFcGCt37CtS67zrNi9JQpyf9jd4CJf6HIjM/VAdAlYHPLZzZ68r/Y+giRg/1bocK7TkwCXMH3i/mvDPEM/OUgG5Bpv0WuBvVM/RjKg88EpkTqgFLCDT9FANQvMpsFq56IvJQE1xSRuznYFPoAfBYuss3eiQrWOps/KYUunEWmDV9qfnKiOdVwpYSSgK+LELow8ioSZUsZNT1Lc62KGqQMDPr4CFvPxNkl76CsoEsYo48A7CcVXRlqxpY48YxKUuw+DSCrYwsdmPtRyvsjJkoZbsEyH1jg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VfXZbNMjIvgW4jqo0FcHbguhQKNiLhEPP2OQCR7DD7I=;
 b=k/KVpRB6elItLBTE7QrQ75nHAmhneQxR5C2f0OYMknNhg067KXwvi52DlYWa4JzHIVbUAImiXp8pgXbij4hyTbxoFUu6GiQu6JTamABIvE0MO19A1SRbBi4GsI6ZxrRxihRWH9mG43mVXm/RnIENIIO2eg+xhtzfHK9w4I9batHgKNkkwOsbsoc2HE8DvMXb06xH/jEYMRztXner16gjlLyYj11jv3LqzyKOxC6DRCOdhq3wSd4oFNbDGEKV7ob7GcM02EnNCPtZEp07+W4CqOEI9HMQwQxwqCT0aL+Jrny06ErPuz1Knjk/ThkTWg61k9S8UVqUMecM3+KwN7ExFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VfXZbNMjIvgW4jqo0FcHbguhQKNiLhEPP2OQCR7DD7I=;
 b=BIWijIhVB9pEo6LsFKCxe6kFC7srekjKyzzshZANLOFTYvYUKnU9nib/GRUsgEoB3xTWhEakL0pKfqOo4VLa6EsU46D21MF3a6SWk9OoZj7dRcgMY3VnN/XvQHG0HMMNGmoCLNRdSVXsNBa5cKwjxCJIfUNIPiKWZdL1czyBVfk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 10:10:07 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/cet: Support cet=<bool> on the command line
Message-ID: <YmudX/vwbBTxNhMw@Air-de-Roger>
References: <20220428085209.15327-1-andrew.cooper3@citrix.com>
 <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
X-ClientProxiedBy: MR2P264CA0155.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97186cc9-eb7b-4ab3-ad2f-08da29b7af1f
X-MS-TrafficTypeDiagnostic: BL0PR03MB4178:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<BL0PR03MB417878C3252A3F5972360DF68FFC9@BL0PR03MB4178.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	I0CpyWEKLwLjaqcLnUvK2h/qQyQWC+eKSuuhxyirrtVITdDwvbtANOJstaNmikcet3+L0VE011YomM2R43KyNF8bOwZL6zk8YpAOVvAI0hX83QsUgMrip7zi95RNY+1BJBb4hZ9EVN+GlRn7h7B6e6FUq9VFWEQ98xiA7Z/ZH4qnaBxF8yh2HWaquJf4Zxokx1j61KQ/aIsd9AfF06eBZMgGFtAzkpb2MURU6cS8/y+7V5DUmPFGE0LVvGhhdsG7HxEkNiP2FuOX9u9CS/6PFBqNzlMvi1QgGaQV8PqREfXMyjpOyqTjQ5aye0u6cHCa0+2Ia1rCaMNeaIEGb3FN45qFQbMvtlkGcsshGdwS4O3CHhVn9SxZrYN7ZBew2iV689zrd5nEU1+Wjl5rsD+z7rxN8OYP3u0rDiKBsLMeIqxfB6i5qO6V5+rzbRqLOugVoIDPf1GL2Ih90jf0AfLKxUYpVqZ9eIFbbbNu0iL6xyJjVIob+Pmpj5M0blmADcdyfv1oVdKJ8ukxZYcceIZAr4M/3to7tJOQ3DCSMIW+6yy6a9ao6yKUFoljuJMyCIy7fDQbw6T4Sg/ABGGweFCLt9jCRldMxMqaoRQM24l2riDMW9jNuVVASNPyfaWwUmJlH+1zSUWmtgmn2txut3sVpw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(508600001)(86362001)(53546011)(26005)(6512007)(6506007)(9686003)(38100700002)(82960400001)(6666004)(66476007)(316002)(2906002)(33716001)(66946007)(66556008)(186003)(5660300002)(85182001)(8936002)(54906003)(4326008)(6916009)(83380400001)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N1AxbnBTZEpqbC85TWhvZHJvUlJlOVVpdXdiSlpqUnBxTVFRTXlFbWttUVhQ?=
 =?utf-8?B?bzdzWTRaRjVxSEJhTVpxWUNubHV3STE5RFplbktsYnRGSFlyY3hnR2xYTnBk?=
 =?utf-8?B?dWQzeFFTTVl5ODRxUi9NbEtRTnFtUmYwQ0x5ejlhK0ZFYno0NVVFd0U2Ui9I?=
 =?utf-8?B?eDdsRExWSWc4QlpoMmpQdnFBcW04aWhPU1d5cWNZK2poYUdrZmZQbjFnNmpR?=
 =?utf-8?B?ZFo3K3h1ZVJPZllleUQ3S3k3UmJtcWltaDVaTzZZcUh4Nnc1RnoxclNkeFFu?=
 =?utf-8?B?M3VvY0J2RGpneW9lR0ovTCtJdUlPRE42Um1iNU9ZWjdEN3ZuS1JJcEY0RnU4?=
 =?utf-8?B?NlB2LzljcDUzZXNHVW9MN0F5b0Nad2ZxTlZDTWEzaCtLN0doZmxIaWNsWFBQ?=
 =?utf-8?B?M1NEbnhkcEh3UE5MZ091dmZPVmMyWndCYy9SaUUybUtjTlJjK0NNTVNZb0t4?=
 =?utf-8?B?bEk1ZUJEQlArSjdzWEV6cEd1d1pYLzROc25HRytaZHlRRzhPSkVNWG9sLzhY?=
 =?utf-8?B?VXhaTFhHWEdibjVYZWxQU1FHZWRBVkd3K3VHbXlsSUxPZnFkOXBOVWxnZFh3?=
 =?utf-8?B?UmwzNFFPUHo2ZnZuckFXTmo0Znh4WURmcXp2YVR2cGRUUEpFK2gzekdaODlj?=
 =?utf-8?B?OW0rSTRVcnhrNGdmQWV2RXBvNGwveUhPY1hvU3BLZVlzaC9DUnZ2eFhqY3I5?=
 =?utf-8?B?Z1IxT2oyalBINmJnSVFxMk9KYzk4eXh4Zms1cTB6NktpWHNmM2xXNkplWExT?=
 =?utf-8?B?aXdhTGV0OHhHNExVaEgvWTFWTXVJdXg4ZHZpZzg0ekwrOFBncU1PWWI1UDNS?=
 =?utf-8?B?eTRLOGVCajRLZzRmY044b0JEbmFYd1dSRzUwb2xFcGlGUjZRbDg3SjVESVAy?=
 =?utf-8?B?TzQycnJoY0JJd0xIQjZVaXNDRTRXRnA5dHVvUjJ3SEtMb3ZkUzFDdGl1aU82?=
 =?utf-8?B?dDc4QjBtd29rK0IrUWdpWU5lOUdncTNVWFQrUUovZHREQlFhS2hiTno5b2Ri?=
 =?utf-8?B?Z2l1MDlwbUZFL21YNkZGQ0J4KzZEaTZsRkk3cU5hVnlCTDNuKzVxTU53MUpL?=
 =?utf-8?B?dUtjVkdTOHEydDgxbWJxTyt3NmJOWFRWbytvS2V0cWV2MktRdzNjMDV1MC9R?=
 =?utf-8?B?K1c5WHlyMmR5UDBVeFRzQnBVVERVeEdhSjVhcGIyY1p5VllpQ2IzamlyUHlq?=
 =?utf-8?B?UDREVHhEVndnRFhaMTBMOEpsaG1IM24yT09PeURvSEVWWER4S1BPTkp2T091?=
 =?utf-8?B?djJYVE9maCtTVytBUXo5MDFnSzVjWElTcXpITmRWdkJiYXJ6ZzJvUjJXOFk3?=
 =?utf-8?B?M3dYdDVMRkNtZU16UkljUHUxbnFHT2dkUVlveFJXOVExY3grbGxrUXpwdWk5?=
 =?utf-8?B?bFJMQVY1MldqL3YrYk8rRkFTNHZRc1hhaVlzZU01YVJJRU5qaDM0cmxRT0Yz?=
 =?utf-8?B?bE9QeGJXanJyQnZMa0VIQjFDd3c5YmFIVDhSQkV2SW5zL3NBVUl5Tno3V1BH?=
 =?utf-8?B?c2p6V1BKTUI1ZTdaSjdzLzc5R0MvU2x1NzFveHpuS2pzOVlPblNtZ0dRQThF?=
 =?utf-8?B?SFZBTjI2RDVOeE5WMVBIcjk1N3U3bzlMd2lnK3R5dGdZUVJiTmNaSmdsN016?=
 =?utf-8?B?SERCRFJXQUEyVWlEbEV5Wm1EU1hLWWhwdndlWTFoS3VFbktFR3p5NnJ5QUto?=
 =?utf-8?B?NkR1bDJuVVZJbUIrbTFXREtvVXkyL0ZPUVNxQ2dscjQ3QjFjOGpiTjY4T1Jr?=
 =?utf-8?B?MmtMdjZHcGl1N2RqT1VaaUlpNXpFNEhFSG12eEpUaTJ4MmhlWDc5ZmQ2N3dI?=
 =?utf-8?B?K0laTzJkaDM5Q3Z0Q1pFTmNxM0ZGZENFVGxhdVVEbEx4OWZPYWVZUEJXUVV3?=
 =?utf-8?B?c3V5SlVCTkU1bjVKamR1LzlNZ0dLOWlmQUdlWkJnZTg5UWNvQVZwV2hGcTVZ?=
 =?utf-8?B?NmRGVmxhUEUvRUJvdGpOOEkydW5KcHVFVHVxTmdHSnVOTDU2SmgvWXdvdUlE?=
 =?utf-8?B?b3pxSXZ1SFJlU2svNnFpeUJSdCs5dXlkZnhxWUVwK0s2V1M1R1VqS3hxdEZU?=
 =?utf-8?B?NFRyeFNCcEFBN1pFczRyelZ5U2tya1ZTVGtJVWlBZ3RkeTZNa2dDaDRtWUJa?=
 =?utf-8?B?QWVhbitmTjdLUFpOMFY2aFF1d0E3MXJCM1Z1OUwrTGtnVzZHRjlKR3BrVWpN?=
 =?utf-8?B?VFlOczBCencxYTNhK081aWNsMHU4eGdINzJnbGpmMjJjL0tYWDVNZ1NOcHBn?=
 =?utf-8?B?L3JuK2lIVUxWL3hjN0FXQW9yOERScmdnMUtnbHFUcXVPU01zYjlKejViVnZp?=
 =?utf-8?B?bnBmNTVrdnpyeUU1ZGdqR0lkUUh2MCt2T3MzNzJXem9kMktueGFsYjd3WVY0?=
 =?utf-8?Q?riQTwYWy3uotp6Ug=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97186cc9-eb7b-4ab3-ad2f-08da29b7af1f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:10:12.2844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VJMdInr66qdFFLAMqTbBHqgTriNIVsW+DqPMxSkgCHuGUEq3Btn9HJbz/L9YGa92WxFiLYoLifJ8Y0HW2J66bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4178

On Thu, Apr 28, 2022 at 12:13:31PM +0200, Jan Beulich wrote:
> On 28.04.2022 10:52, Andrew Cooper wrote:
> > @@ -283,6 +283,8 @@ CET is incompatible with 32bit PV guests.  If any CET sub-options are active,
> >  they will override the `pv=32` boolean to `false`.  Backwards compatibility
> >  can be maintained with the pv-shim mechanism.
> >  
> > +*   An unqualified boolean is shorthand for setting all suboptions at once.
> 
> You're the native speaker, but I wonder whether there an "a" missing
> before "shorthand".
> 
> > --- a/xen/arch/x86/setup.c
> > +++ b/xen/arch/x86/setup.c
> > @@ -117,7 +117,20 @@ static int __init cf_check parse_cet(const char *s)
> >          if ( !ss )
> >              ss = strchr(s, '\0');
> >  
> > -        if ( (val = parse_boolean("shstk", s, ss)) >= 0 )
> > +        if ( (val = parse_bool(s, ss)) >= 0 )
> > +        {
> > +#ifdef CONFIG_XEN_SHSTK
> > +            opt_xen_shstk = val;
> > +#else
> > +            no_config_param("XEN_SHSTK", "cet", s, ss);
> > +#endif
> > +#ifdef CONFIG_XEN_IBT
> > +            opt_xen_ibt = val;
> > +#else
> > +            no_config_param("XEN_IBT", "cet", s, ss);
> > +#endif
> 
> There shouldn't be two invocations of no_config_param() here; imo if
> either CONFIG_* is defined, use of the option shouldn't produce any
> warning at all.

Hm, I think we would want to warn if someone sets cet=1 but some of
the options have not been built in?  Or else a not very conscious
administrator might believe that all CET options are enabled when some
might not be present in the build.  This would also assume that all
options are positive.

IMO the current approach doesn't seem bad to me, I think it's always
better to error on the side of printing too verbose information rather
than omitting it, specially when it's related to user input on the
command line and security sensitive options.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 08:12:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 08:12:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317014.536146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLjL-00031p-H3; Fri, 29 Apr 2022 08:11:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317014.536146; Fri, 29 Apr 2022 08:11:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLjL-00031i-Dm; Fri, 29 Apr 2022 08:11:59 +0000
Received: by outflank-mailman (input) for mailman id 317014;
 Fri, 29 Apr 2022 08:11:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U+GC=VH=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1nkLjK-00031a-8G
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 08:11:58 +0000
Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com
 [2a00:1450:4864:20::32a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 091e2afc-c794-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 10:11:56 +0200 (CEST)
Received: by mail-wm1-x32a.google.com with SMTP id
 v64-20020a1cac43000000b0038cfd1b3a6dso6572600wme.5
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 01:11:57 -0700 (PDT)
Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227])
 by smtp.gmail.com with ESMTPSA id
 q16-20020a1ce910000000b0038eabd31749sm2222371wmc.32.2022.04.29.01.11.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 29 Apr 2022 01:11:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 091e2afc-c794-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=XqvrYci+95js6f4mZtp9h/yUnthzubPuS18nX3bTZPY=;
        b=Agh0hWfNWOLsgMtRQM7cd5+lULJfekaq2Bdh3j5NJrn8b77Zijoq0Lzu+L84ZM2LVz
         wt1r36bJC8X6sII7aa0Y1uCvfy4g0T+Wg9D0SorY0VU7U5eyo+kztqsvp/jueHRWzWzq
         Clcs/GPXTwguYJs/ySHdd4cVkPfhD7usB5qc1a4HNTnkYp8PYLFPtPSZ0K7NsQXyHsce
         TMHr7eRmKAKhHpRhZdf9P8Yc0fC+6ukgaRo55rChtq9CrWhXGHGrwvZl7oJXgq9/ekOV
         ejIe2PNvw6G5fOikA75aBhkkFGyeLnA85N/DohY9YkAcFI/QMcwRGVZXPcl/thf+D2TZ
         1wJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=XqvrYci+95js6f4mZtp9h/yUnthzubPuS18nX3bTZPY=;
        b=c//HKzxK8gYrND187unyiedkbwEHnYsPthUdKOCdSeO2oxF6s9B2J+WesIbDWylZlm
         b9Vm0/kg47n5AjisPxDihy8Q/yvzRlMaohdgMmCB4pfldqaXQQZMB0lVETTHWiNfqCpr
         iXv2xpIIRFEUk90Lz7WP6gDrRKR1xDx5LV+AIjT36DR3BbsD5xjcirjV+YdIF/IN/M81
         BGdyfgASPwEHil7eMExeKMVL5X/yEifR/IVs6W/Ucjqn+b2jt2DfPwmG5saz14cDABMk
         8NXxRKEEVlCJWcnDJafw9zOTUA1jMlfBqT+ji2jCIJgyvIbAhjm9sWkMnR8UFF3GPpKq
         i+Xg==
X-Gm-Message-State: AOAM530oNZcSUT83b/FrZ24gt8UprnDiw5A6EZFzInbhmWpeR3fTGZ8C
	YD9H4nSJbMKDwyIyuDNYr2A=
X-Google-Smtp-Source: ABdhPJzYf70fG27iHwc3wFbKY4QIqsyyUy9X0QI973D1I4SxhcbTK5uGUHInLMnygbTBJgrDh3XA3g==
X-Received: by 2002:a7b:cbc2:0:b0:388:faec:2036 with SMTP id n2-20020a7bcbc2000000b00388faec2036mr2089539wmi.190.1651219916786;
        Fri, 29 Apr 2022 01:11:56 -0700 (PDT)
Message-ID: <c962f441-05b8-8aa1-5186-c85251f3e0ba@gmail.com>
Date: Fri, 29 Apr 2022 09:11:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Reply-To: paul@xen.org
Subject: Re: [PATCH net-next v2 01/15] eth: remove copies of the
 NAPI_POLL_WEIGHT define
Content-Language: en-US
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net, pabeni@redhat.com
Cc: edumazet@google.com, netdev@vger.kernel.org, ulli.kroll@googlemail.com,
 linus.walleij@linaro.org, mlindner@marvell.com, stephen@networkplumber.org,
 nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com,
 Mark-MC.Lee@mediatek.com, matthias.bgg@gmail.com, grygorii.strashko@ti.com,
 wei.liu@kernel.org, paul@xen.org, prabhakar.mahadev-lad.rj@bp.renesas.com,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 linux-omap@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20220428212323.104417-1-kuba@kernel.org>
 <20220428212323.104417-2-kuba@kernel.org>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <20220428212323.104417-2-kuba@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 28/04/2022 22:23, Jakub Kicinski wrote:
> Defining local versions of NAPI_POLL_WEIGHT with the same
> values in the drivers just makes refactoring harder.
> 
> Drop the special defines in a bunch of drivers where the
> removal is relatively simple so grouping into one patch
> does not impact reviewability.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: ulli.kroll@googlemail.com
> CC: linus.walleij@linaro.org
> CC: mlindner@marvell.com
> CC: stephen@networkplumber.org
> CC: nbd@nbd.name
> CC: john@phrozen.org
> CC: sean.wang@mediatek.com
> CC: Mark-MC.Lee@mediatek.com
> CC: matthias.bgg@gmail.com
> CC: grygorii.strashko@ti.com
> CC: wei.liu@kernel.org
> CC: paul@xen.org
> CC: prabhakar.mahadev-lad.rj@bp.renesas.com
> CC: linux-arm-kernel@lists.infradead.org
> CC: linux-mediatek@lists.infradead.org
> CC: linux-omap@vger.kernel.org
> CC: xen-devel@lists.xenproject.org
> ---
>   drivers/net/ethernet/cortina/gemini.c         | 4 +---
>   drivers/net/ethernet/marvell/skge.c           | 3 +--
>   drivers/net/ethernet/marvell/sky2.c           | 3 +--
>   drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 +--
>   drivers/net/ethernet/ti/davinci_emac.c        | 3 +--
>   drivers/net/ethernet/ti/netcp_core.c          | 5 ++---
>   drivers/net/xen-netback/interface.c           | 3 +--
>   7 files changed, 8 insertions(+), 16 deletions(-)
> 

xen-netback patch...

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 08:25:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 08:25:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317033.536162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLvv-0004h5-SH; Fri, 29 Apr 2022 08:24:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317033.536162; Fri, 29 Apr 2022 08:24:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkLvv-0004gy-Ow; Fri, 29 Apr 2022 08:24:59 +0000
Received: by outflank-mailman (input) for mailman id 317033;
 Fri, 29 Apr 2022 08:24:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkLvt-0004go-SS; Fri, 29 Apr 2022 08:24:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkLvt-00030F-Qs; Fri, 29 Apr 2022 08:24:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkLvt-0001BC-GN; Fri, 29 Apr 2022 08:24:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkLvt-0007Cx-Fx; Fri, 29 Apr 2022 08:24:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=loNI+bYbtdvbqcAmMqFJyAeWPybAA5aHTx2I3GG3WxI=; b=6q0H2oWdSsacrZYTp8689xNzs0
	eiwiik/eN+6c1crVhCRPG+7LE9tFXHQHGZJyJ540++2y3eehZ1zYM6aP8vHXpLnuOltvMkk8mq7Jy
	hOx/EbSM+D+qk1qWyAa5Ecac7lhBFGgangeKP3XF3EFl3AqtrYIv49UmLP4p3f2mQjnM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169853-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169853: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e57477359071ab91429b0ebcbf7ff162242e2831
X-Osstest-Versions-That:
    xen=d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 08:24:57 +0000

flight 169853 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169853/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e57477359071ab91429b0ebcbf7ff162242e2831
baseline version:
 xen                  d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed

Last test of basis   169824  2022-04-28 16:00:24 Z    0 days
Testing same since   169840  2022-04-29 00:00:26 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <julien@xen.org>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d711a8e527..e574773590  e57477359071ab91429b0ebcbf7ff162242e2831 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 08:32:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 08:32:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317042.536176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkM2y-0006A2-LQ; Fri, 29 Apr 2022 08:32:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317042.536176; Fri, 29 Apr 2022 08:32:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkM2y-00069v-IJ; Fri, 29 Apr 2022 08:32:16 +0000
Received: by outflank-mailman (input) for mailman id 317042;
 Fri, 29 Apr 2022 08:32:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkM2x-00069p-5E
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 08:32:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id da3b2a82-c796-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 10:32:06 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-6yQ6SPMjOmKM0ZmSHdLBtQ-1; Fri, 29 Apr 2022 10:32:12 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM9PR04MB7490.eurprd04.prod.outlook.com (2603:10a6:20b:2d9::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Fri, 29 Apr
 2022 08:32:10 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 08:32:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da3b2a82-c796-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651221133;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=n1yXW5zzYWgNz6U0A1mmEp8lCC+DKM7KUC4Dxh/boSo=;
	b=VBSSP8fAfYM8lpYh+L0TKRJGcvNq3BuWZVxIngn/jFKS2HK3JDhV75uzue1KCFqIJni4tT
	eDTyx5cpGK1apZGoCiai7+ZVLw8jwkZl/bf9ikJI6e0uRSBT1R0ohmYYWxLXVyNYUDr7/s
	+7s/hc0vsm8ta7c1vn82umJYivOignU=
X-MC-Unique: 6yQ6SPMjOmKM0ZmSHdLBtQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J5+KsQqvCInDP88FVkkf1gOxeFt8oMq55Qo3oqEwdosT2ccm9YijNMyWoUkrOnmSe9oNibPsTVXqaC/3Jujdg2VspAa4P2NoAh5KeCYZ8XEq2fLvjQattyyTVOiOEdazrTiRzgWzY+7xAseEXMoBmGfYBkRUmA+aO4Ec7OkgHHGbpajzmRfY7sAA9OZFt+kTRlPOJ68Wm18EqavKXapxf6Mzs0QM4J1tO1kp9S8wDzJdXekW0WYOKpPytj7ZxkQWl17g//gUEAbCi/meXx/TdpmLoA0TaGvzL/Y2gZtAokiPuXpMYCeQ14Ji8OxCsYWgR8lL/q6GayAqEqzLj6mZmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mlbk9ut8eUH5gWtSNYWolKdxyBzeQNPSWCWCG7iRPEk=;
 b=J73Gd/JJkHWa92Bupb+C3giLKd4a65gIUoGDByqYKfDsQ3kQSEprao4Sp6drEQJ2LKns/5vqnG997vc5h4YekoSpSUFh9pmfGuvR9Dm+glmJRlVD52Ime4sCoBlkuappILh8DXOUduBdeUWXsL1Vrj54qLgcL2uHia1y4uIVMv2uN9YAqHz5pbCS2Q0Nc2dPq4BXN916+S79HsrXZyD/5E9RByT3/zKFcZKlOQ21ozV/o3LnwXZQoLHcuqd2lwFNtLrmAqh/qeC/XAceSurzAsb5rGutzeAszM/5c0qgjBNWZRp3Llg8iLuZEFaG6jvRM6PKY4doi0tmGHdRMK1tog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <67e02fac-a382-0cb1-e2ca-dadef36718c1@suse.com>
Date: Fri, 29 Apr 2022 10:32:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86/cet: Support cet=<bool> on the command line
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220428085209.15327-1-andrew.cooper3@citrix.com>
 <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
 <YmudX/vwbBTxNhMw@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmudX/vwbBTxNhMw@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0314.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d1094e9a-21ba-47ad-d474-08da29bac09f
X-MS-TrafficTypeDiagnostic: AM9PR04MB7490:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB7490D5148361156A035E255DB3FC9@AM9PR04MB7490.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fClMqBU0LXoXXvEJOZTPCGKT1YzzGUx43fehHnlG78Ig6RJq2e84Xll1gzO6eXxBMrjEdwJV6XUVQD88Ko8ZoSy0mr8Nw6dBHcMZwuyh2h0wzwGo94YFWecaSKV4sNynv3a0eySL7SqGH8EEr+TK+3jhR/a6J9xoW/8wNtBeb1BH8V0Hta7vt2OCDyUkax74AyUpUbeKfPmFUvqrvCZzSYJWdI7rRG8ZqSExKM9ZCxsFE3raZ5DcrkDPpjSbOgx/nu6kmhjiv+yBMPz+5GlmNhxxQ5UxkdciYNZcKAvE4KmLDLjlYcmpb8odqaoMRy+qlH6DwQdtPwKADrauzoIwESHhzLOG9bE/xs2itNWyv6gMZZhGCbK0V08ve41AnGSEs8RRbRorK2a1PMuSaPzcpl7dQ3ldLQ89e7tkqqgh+v6Y+l59j7NU3VfMWI34BxhkaQ/29ttKGaCCBWHpB6xP1YBLflD3KdxFek8TQAmEhUqrW0ACjrhbscYO9xm2+Buqkt/VAnfILljVi/c1UO4hOzoF2t8uCUWhp9mJEt6BzBCcyLuX33v3tpIf34Y4HAcEOsJArk9etvwjRnlUx38kwS69VFwPteXImOfLHKB97ttrxYpc7qfb+z2LN93utafemJquDE0zg4n083/1NPtdsXzRep8XozvTtp6fukO3A/FJrUwJLxdHcOzztJwQ4OaThvW07FTpmNFha/WL/ophzPSbnuVHa7v9+s6TgjX4AxM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6506007)(36756003)(8676002)(66476007)(83380400001)(2906002)(66946007)(66556008)(186003)(31696002)(6512007)(31686004)(2616005)(86362001)(316002)(26005)(38100700002)(8936002)(6486002)(6916009)(54906003)(508600001)(5660300002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UWt5sjo6W1QCL4uSzdv5rkSXf8TRAkyR64VxYwIlzqaP2pumtm95JwEriVX1?=
 =?us-ascii?Q?3YxHQggvuc/WawOv4suqiOeaCEdVuxX8gIw7k5Sc0iSDWZOn9rwEoc5UL4hp?=
 =?us-ascii?Q?rvkO5oxRyNWIeqhi84hvScC4YPGY3INrAeLxXDnG8Ipv1tweOkgEMg/rLOBu?=
 =?us-ascii?Q?3+tFzds0sQtkV26JXl22aucQJw3EqHBNPpUeAGlSch0Rv5AmSQTy4opcY9AW?=
 =?us-ascii?Q?4mXuO6IjvAYYWKsbreyqpBBeDEGFBu9HJXIs4j8zZU98R6cbeSBe8/WVH1aI?=
 =?us-ascii?Q?BimBbCM3Dtg4r3SOE5mmOurDdo6G9XPyZ8EIiVUSRGJy9xHeQb5528VCraqP?=
 =?us-ascii?Q?GB+819YFMK+7197I+WFdF9EBZqokUtRrPNP3Jd2trugCGKM8ito6+0dgJDij?=
 =?us-ascii?Q?0o2OD4OXlfJXA5YDZHncxyYIlS8XrxlHdAxionSlzK8koZGMcpce7PdPgvhZ?=
 =?us-ascii?Q?m2umjfcPNwt4VSbNw3RJ3Qe3O4e+UzYSsMs6peRd0ALL6IxlFlq4xoru2hsx?=
 =?us-ascii?Q?PGv5s8xW3JrfGG13LScFeaaInUAuVD5+PZb86Ca44PiQqnfyFoWFSWXxYvQI?=
 =?us-ascii?Q?QoFBPrMR5S6q9QwZqrXZK6teFY5+J7X99MpuV33A21N/iwCegYnitArslwat?=
 =?us-ascii?Q?xEbuW/OdoI1QxAQT12xE6dvQYElWeWGJmXfy93qeahohdB6iZXs0zsk3UvKn?=
 =?us-ascii?Q?QI/1dcdZ7HSWJTlZP9T9qa8MZ/cj495JFJpboV1yTTRq6iP2wYnf8lDEJNIp?=
 =?us-ascii?Q?G0S+oRiyzgrtZMnpTvApu+ri3W6avDLeE2hXVfjF0H71QU5Vq1mLUzRMbdcX?=
 =?us-ascii?Q?jUh1h5QJPLnU1/lhZaLLqSxmv8FwZO2C/H6LjIGOD7E4d+XLolVbNyNsGF5V?=
 =?us-ascii?Q?krHObbMplHWD00e4n90H/Ukl9qt33Q0VOeCVj0jwPxso6Mr3SMAhmKFx3+bY?=
 =?us-ascii?Q?ZeHKVz2vZl7H0lHUi1C4pK6TpkWBIhg3VV8srCpplueLo9YGN9FUoVm9ifIZ?=
 =?us-ascii?Q?I+z+LP4hyFFWwrQtviHUN8DrzVI3WsbZHPIVU3oiJ0vj7ENLRnepDWJ01qA3?=
 =?us-ascii?Q?t4FNvqSgVK44sDUaS3u3XHsf3U6SKw3FSDIXvGQGdGQJwpNf/IJshXr2pI8o?=
 =?us-ascii?Q?vakiU5DptHBlf6yV4R+/h95BFg8SADSnPFwec6gbQCuY+Rj5FSS2ZR8pGPu1?=
 =?us-ascii?Q?9BRU7scQvs74dpVcZe2vOitxRGdE+aNeji8ZDCzbIHqNRE+p9VARYRF5vV5a?=
 =?us-ascii?Q?zH86Vs5iXasGBxIcAzO5H7b+bieXCF2++63mzBWSvsFbvOBTjNztYtSJ3Pvc?=
 =?us-ascii?Q?Va3L9WcEC7WsyDVGAhNGXRMvaT/BbOav/ndqYi+qbGkw2q/cIb9bfw4oZi/K?=
 =?us-ascii?Q?COVFjbZ4B1FAiCB3tHlvYTFfB29wtw5seFOMtknASpdEx5juJlB4tapd6n5P?=
 =?us-ascii?Q?mlT6zqWad9jD/Z+SpWiovWE5ImQvYiKXutmEvYMbcheLro5emX8jIMO46eZR?=
 =?us-ascii?Q?jcCOjKTTKstKLAEXwL5M3rlGGSnsRohTHw4e/pojlgkfAiivKfJ2CSHtx1zG?=
 =?us-ascii?Q?GRiiWM1Jkr5b3bnA3NG0UmtSi/aLAIt8IUs/l5JmPs21Xmlu1SdFFJWWdiZl?=
 =?us-ascii?Q?pKDBKhoyJFTW3Rg4CvU+4YpZvAOxWiw7SjD6MVVX31LydhgPZMh0U217kIhy?=
 =?us-ascii?Q?4Os3RLWBvw2r0h6Mu0+JoIboBHOfuMAaR0+QAsDBID3qtK30gQ8uiFIvrBoB?=
 =?us-ascii?Q?EreYjLodwg=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1094e9a-21ba-47ad-d474-08da29bac09f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:32:10.0889
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IuuJApDHfPtTV41QQqf317DNfOJFTdzGw4phvOSuc75GUOo+URXLRDfF5TR1pbq0ysDNodOAdlFJuTxRO2/STg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7490

On 29.04.2022 10:10, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 28, 2022 at 12:13:31PM +0200, Jan Beulich wrote:
>> On 28.04.2022 10:52, Andrew Cooper wrote:
>>> @@ -283,6 +283,8 @@ CET is incompatible with 32bit PV guests.  If any C=
ET sub-options are active,
>>>  they will override the `pv=3D32` boolean to `false`.  Backwards compat=
ibility
>>>  can be maintained with the pv-shim mechanism.
>>> =20
>>> +*   An unqualified boolean is shorthand for setting all suboptions at =
once.
>>
>> You're the native speaker, but I wonder whether there an "a" missing
>> before "shorthand".
>>
>>> --- a/xen/arch/x86/setup.c
>>> +++ b/xen/arch/x86/setup.c
>>> @@ -117,7 +117,20 @@ static int __init cf_check parse_cet(const char *s=
)
>>>          if ( !ss )
>>>              ss =3D strchr(s, '\0');
>>> =20
>>> -        if ( (val =3D parse_boolean("shstk", s, ss)) >=3D 0 )
>>> +        if ( (val =3D parse_bool(s, ss)) >=3D 0 )
>>> +        {
>>> +#ifdef CONFIG_XEN_SHSTK
>>> +            opt_xen_shstk =3D val;
>>> +#else
>>> +            no_config_param("XEN_SHSTK", "cet", s, ss);
>>> +#endif
>>> +#ifdef CONFIG_XEN_IBT
>>> +            opt_xen_ibt =3D val;
>>> +#else
>>> +            no_config_param("XEN_IBT", "cet", s, ss);
>>> +#endif
>>
>> There shouldn't be two invocations of no_config_param() here; imo if
>> either CONFIG_* is defined, use of the option shouldn't produce any
>> warning at all.
>=20
> Hm, I think we would want to warn if someone sets cet=3D1 but some of
> the options have not been built in?  Or else a not very conscious
> administrator might believe that all CET options are enabled when some
> might not be present in the build.  This would also assume that all
> options are positive.

But the positive options aren't really the interesting ones here, as
things are enabled by default anyway. I would expect "cet=3D0" to be
silent unless neither CONFIG_* is enabled in the build - it simply
means "disable whatever CET support there is".

I can agree that "cet=3D1" may indeed be useful to warn, though, but I
wonder whether the logic here then wouldn't become unduly complicated.

> IMO the current approach doesn't seem bad to me, I think it's always
> better to error on the side of printing too verbose information rather
> than omitting it, specially when it's related to user input on the
> command line and security sensitive options.

While fundamentally I agree, too verbose output can also raise
unnecessary questions or induce unnecessary investigations.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 08:40:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 08:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317048.536187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkMBH-0007ak-IT; Fri, 29 Apr 2022 08:40:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317048.536187; Fri, 29 Apr 2022 08:40:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkMBH-0007ad-Ei; Fri, 29 Apr 2022 08:40:51 +0000
Received: by outflank-mailman (input) for mailman id 317048;
 Fri, 29 Apr 2022 08:40:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkMBG-0007aX-LO
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 08:40:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 11fa5d75-c798-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 10:40:49 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-6ypN7JseNmqecmUMUKnU-Q-1; Fri, 29 Apr 2022 10:40:45 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by PA4PR04MB8048.eurprd04.prod.outlook.com (2603:10a6:102:c4::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Fri, 29 Apr
 2022 08:40:44 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 08:40:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11fa5d75-c798-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651221649;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vMvDhquD3XfZHOdvjxFCaGSCwFQ6pAo0esprgo/AOBE=;
	b=ZYkpd7j5RhTNQyLz0A0hFs76cO3Sykh/Z+Ya87IVB8C1TR22ZI8EW/SPbEGJ5S4KhuuA57
	G8TeUiB3IeyVZFcsednPszCbFzc7xkc8QD5+SLwwaK1LgLPSxWeaacC4XOIO/zPSmD81fb
	Ea0Qkk6ZSsGIxsqPQXpjNaoUlUESnd4=
X-MC-Unique: 6ypN7JseNmqecmUMUKnU-Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HeFOc0R6/CBEHcEhgs123FrOc18eBozKovCfv5nK/ou1TVOPhpqdsvk2XKCVLaTVuuxg3Crd1Axi0uofYdonSfrPCGA5fqTBhyy3bWb+l1r9WYIwrUKmpPv+TogzYw3h0IyIfy+F+kUx+zMfFrZaVGAtKLkFXUETKEDOovav6Xe17dfyjKhksws/lp+plP2Opm+2qVBNmX39w4XTnoGOi/aqBOcDuTtUM6lpxQxgSRYpVn6CUwseOcz/ndVMm84L+h1IlKHVvrti5uS5KWsZnT4xLLtrS3GJFJMr7SmWdgaHRNi2GhbG+4noPnH9WwXittfzxEqJV8lae/chnHms6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7ZZnOsWbaDgbFjkhszMZ2wDIIRO4kUdz62Qo7Hykl74=;
 b=L73xXj/CpYEFVT7bUFRSGSEIf/V181FZi6g4CG0aNTjsV7pf5D1+9gfmnQo3i4ppoCVa86usqGykv0M6Kj2K8tlzAEfOBKqacH1TecfWzwmPZCUTU6nCgVBYEdq/nAQ4WNotZew6lgpDlqMf2SbHxKpG5/2EAeyxuinfBL+JiqOhATIB9enyuDHGgwC28dBAA0QtXKYXyf9lD/NyFRCTBOQHvV9EfUST4Di6bh3CHcYKgTP37JBA5JRWwugndAhYlCEtZGb/UVNBP3jpSQEUJiWc0OIeGGVBbOtJ+IEQkILRs6bRfkmUQSywbCgui+uc2Yh9jZJQz8uohC+NZKZZSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c9a57c65-05f4-b566-10cb-92ce9ffe9e0d@suse.com>
Date: Fri, 29 Apr 2022 10:40:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <Yl7aC2a+TtOaFtqZ@itl-email>
 <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com> <YmmUtiBkhEYvXHUB@itl-email>
 <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com> <YmsbD9ktQqB4U33o@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmsbD9ktQqB4U33o@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0351.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::17) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d97bcb9a-b74d-4c7a-6835-08da29bbf2d9
X-MS-TrafficTypeDiagnostic: PA4PR04MB8048:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB8048F61A575E502C7DCFA550B3FC9@PA4PR04MB8048.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KgJacxSAtM4YyJhtxz3zn434BjjIJsJcVyVY+g9jWFsMfR3Aas3jIbxJzbjEQ6jExhbLeejKE4kzTA1z1l6mpsw/+q9016pHkzy1kxeFwonbijqwpeAwcIvprxFwjmCUZw3O0D4++QFTO3namzNgecM8A9XfiH6THhAWMiesUtDtO+z0oZZ+m8bbPtdGqhGNVAGz4wCA5k392ca4P0V4y/tkejUmltDxpU/7Wp5RNDFQ6TEaq1lAmjnolTYlps/j+vWUHc3InYtqBZYbTRjY8fYhvragedK/KpuTwgbg9+2evg/nzRrYYfvu5775aGTLSqP7024PR9oDjIBlQaNNlvjOEexT4TIkUUPrG2OBbJjU4gCHsQIeO6FExWIkcxxFYDW2QPuyMuzaXclkW1kuzbt/dXiFOLrvo9Elf0TZtaoVsblcsN3fD2Y3M9m6Cbb7eJVGraE6UKUlNOnsGLbsIYlt7L6rkpEOP+RYviVJy7Z6gmHvAxJJu/FF/zLgaemlvRM61AjQhsz2CyYr0WOXq1FTHAQBFWNwvUk6Gg00bZhTPVAUGNnZT7Y7uO/LnH/xtmEdY60TSN3ReFzbsvuzUgPDGf5+CdRsMI0o9f2KcL1BwNfzhPQCqPB4HEaHmQ651wzcFAsYDdBhqS1agToytXOnt5i0YJAeY+cFhoRfjsaO5BdLPvIXM0Oy0ZqCPMjaxLWOYU0HgrlHgSikSPN4WHrOxzXuKS8FME5gDwV5eI/ftG4R0RSKGxJGFnW5lu6/SFhSfZYLVJxIcqWrEs+m8A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(186003)(8936002)(31686004)(2616005)(86362001)(8676002)(66556008)(66476007)(4326008)(66946007)(26005)(83380400001)(53546011)(6506007)(36756003)(6512007)(5660300002)(6916009)(316002)(6486002)(508600001)(54906003)(38100700002)(31696002)(15583001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qUl5Ga+Xx6Ya19nDWHVPYUVpHRyilqnH/AEDU9zY480htB+wC3FcmFOJ3/xg?=
 =?us-ascii?Q?RCgOQ2tL1J1CHd2S0o420XAOWYxi3ZmQM5dLsL0Qoiu85D3QE8dv/Wjd0bir?=
 =?us-ascii?Q?Mk/LI320tHpWaMbaVAnmBY3bw0fUX31vRq74cWbCGiEbpoVBch2omsJTeTGd?=
 =?us-ascii?Q?6xJ3bjt+v82keJavydUORX4ELKqj9Rs3PxQleWoY1U9xn8apxgi3ZC8SOfsB?=
 =?us-ascii?Q?rSShi81gYLOgpFa6Z0MrYGAb7obw+JqIi9cUFzjcgCfWvLBO6DBqzmmtfH9k?=
 =?us-ascii?Q?wtOQHGGJdWImnd+IQkm40zAzBPo8952ThKGcTv0kDsHNeYjdTq/AS5btvoeo?=
 =?us-ascii?Q?gPnVqp9o+Sgvdf/ZN6Xp0KR2d9FPFLxU2FY/7eqb5DKunxDBoq9bDJKpoz0f?=
 =?us-ascii?Q?uSW30lHUu+P+goT5cmtJ48S4xYJsFuLc8QIEqfc4pGtODwlMCVMde12cuL/6?=
 =?us-ascii?Q?wlr7apWMn9C7Sn5DhSC2j4u4RGk0auwYFv5JI8NWGH8DZXNEVERk5cax5vLL?=
 =?us-ascii?Q?mOuOXiKU4a24rSUI1EWauSzIgUBzmAM7asUKwAM6lfOvOlCxYt2mJd+iiBLx?=
 =?us-ascii?Q?rqkfIXU2tu0gLgq4+QVAprpZMjKiId2UeljSnThZVxZJKGXJIRprT5nTy9nz?=
 =?us-ascii?Q?Li69hVoUqobXYOLIlymWogZnrOf+Fm+dj2Ffk5urGpicKZyzmSbiEEVfO/Ib?=
 =?us-ascii?Q?j7z0375GWu8S6DPaKlmACJC8kz49vrFGKe/18YL4HymHhJoRGNx9P+E8hxWd?=
 =?us-ascii?Q?2EpVzxeA7mTTmsb5jGrZjZ+PZJ2qm4OD0qysfTDPdb2VK1KQhaFDU5t+rQPn?=
 =?us-ascii?Q?tFqgmxG6JF2yHXOoyCm54q+GBZmUg3iQWzHPzZKF4NI145jD7/FWYT1RRplT?=
 =?us-ascii?Q?jY6Hy/jcQbZtgLokQ5MUOwgoa5yls5RzmkzNANy/LcEhZimxQk+AFNDoIlyD?=
 =?us-ascii?Q?A+v0hgIxtvysd8O2pJQZIPnTonPv20+L7LF30rPMnBt+orTbNiR5FElNAKz6?=
 =?us-ascii?Q?8ZYVEQwXzCK0mRq4e21a3H9MiRzK09ZOUhV1TQrbaBzYyDZxBwNY2Jtu9flE?=
 =?us-ascii?Q?cgPBhfitxmgAWvntRoPRqKwFiPg9tDYfB4E3UAIJ1bB0yKNCfleX7V7Xxgrq?=
 =?us-ascii?Q?PiUQ56WzI1SsWNlLTc4QkkDPV5kFrQ9Y3dXJ6M2ZyAE+zPz/MJVQl5HmFaaY?=
 =?us-ascii?Q?jQGe4NlbxJDEre9dDAylqA0h8yBQ9cXthGlkTktPwhByq+O70PqEDkiXbii/?=
 =?us-ascii?Q?/M9Li+93AUu9dw0mh64GB1lbVvmwoaYenl6yPUlrPdRRKMxN8bJNbMPkaKzA?=
 =?us-ascii?Q?tF+7wx55KMpjOL+wtU3Xm7a5WiTP2SepZc/kwq2/kajU0KCnhj67vC4zoe5F?=
 =?us-ascii?Q?BERiKZJgCxUUVYyLxyRiSlqLkm4BqH5fZOmtZFmAyEi47KSNEo/CM8kyadMA?=
 =?us-ascii?Q?amMTXTQjdTYP8M5E0ZxGBqnN51lxv/SbJ1mfPQB9rIqctqZTeUnTGPRFhBrr?=
 =?us-ascii?Q?DVh69Ds52bw/O3i6trqs8j70BL20VUzX6aI2pAPm3j4HwgM/0GUUvfVuD9IN?=
 =?us-ascii?Q?WM5R2V71V+O8Vz9tcfOBDZqkA0fQYTZt1RT35RaUfXqjkktJiqaME95j2SGu?=
 =?us-ascii?Q?8Tkjkp9fDz+Dd9f/snMS0t8hjJffsIz3BQPFFScgEbWDq/GlLPVunOJeFzoU?=
 =?us-ascii?Q?LYFeu9KoHxQIH79ZgCrWXvA5Px0H01rlIhr429QXq1VJCAGKcdkxSfijFvsR?=
 =?us-ascii?Q?dUaDRCf+AQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d97bcb9a-b74d-4c7a-6835-08da29bbf2d9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:40:43.7553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gxo1/XSm1JKAT/Rp2SCtx8YKtycWwu4FbKh6cuYKn92xtC4KftOaRb9nRRcTXUyXfOPD3B0eaT4ODL4v3Nzxlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8048

On 29.04.2022 00:54, Demi Marie Obenour wrote:
> On Thu, Apr 28, 2022 at 08:47:49AM +0200, Jan Beulich wrote:
>> On 27.04.2022 21:08, Demi Marie Obenour wrote:
>>> On Wed, Apr 27, 2022 at 10:56:34AM +0200, Jan Beulich wrote:
>>>> On 19.04.2022 17:49, Demi Marie Obenour wrote:
>>>>> This hypercall can be used to get the ESRT from the hypervisor.  It
>>>>> returning successfully also indicates that Xen has reserved the ESRT =
and
>>>>> it can safely be parsed by dom0.
>>>>
>>>> I'm not convinced of the need, and I view such an addition as inconsis=
tent
>>>> with the original intentions. The pointer comes from the config table,
>>>> which Dom0 already has access to. All a Dom0 kernel may need to know i=
n
>>>> addition is whether the range was properly reserved. This could be ach=
ieved
>>>> by splitting the EFI memory map entry in patch 2, instead of only spli=
tting
>>>> the E820 derivation, as then XEN_FW_EFI_MEM_INFO can be used to find o=
ut
>>>> the range's type. Another way to find out would be for Dom0 to attempt=
 to
>>>> map this area as MMIO, after first checking that no part of the range =
is in
>>>> its own memory allocation. This 2nd approach may, however, not really =
be
>>>> suitable for PVH Dom0, I think.
>>>
>>> On further thought, I think the hypercall approach is actually better
>>> than reserving the ESRT.  I really do not want XEN_FW_EFI_MEM_INFO to
>>> return anything other than the actual firmware-provided memory
>>> information, and the current approach seems to require more and more
>>> special-casing of the ESRT, not to mention potentially wasting memory
>>> and splitting a potentially large memory region into two smaller ones.
>>> By copying the entire ESRT into memory owned by Xen, the logic becomes
>>> significantly simpler on both the Xen and dom0 sides.
>>
>> I actually did consider the option of making a private copy when you did
>> send the initial version of this, but I'm not convinced this simplifies
>> things from a kernel perspective: They'd now need to discover the table
>> by some entirely different means. In Linux at least such divergence
>> "just for Xen" hasn't been liked in the past.
>>
>> There's also the question of how to propagate the information across
>> kexec. But I guess that question exists even outside of Xen, with the
>> area living in memory which the OS is expected to recycle.
>=20
> Indeed it does.  A simple rule might be, =E2=80=9COnly trust the ESRT if =
it is
> in memory of type EfiRuntimeServicesData.=E2=80=9D  That is easy to achie=
ve by
> monkeypatching the config table as you suggested below.
>=20
> I *am* worried that the config table might be mapped read-only on some
> systems, in which case the overwrite would cause a fatal page fault.  Is
> there a way for Xen to check for this?

While in boot mode, aiui page tables aren't supposed to be enforcing
access restrictions. Recall that on other architectures EFI even runs
with paging disabled; this simply is not possible for x86-64. So
portable firmware shouldn't map anything r/o. In principle the pointer
could still be in ROM; I consider this unlikely, but we could check
for that (just like we could do a page table walk to figure out
whether a r/o mapping would prevent us from updating the field).

>  It could also be undefined behavior to modify it.

That's the bigger worry I have.

>>> Is using ebmalloc() to allocate a copy of the ESRT a reasonable option?
>>
>> I'd suggest to try hard to avoid ebmalloc(). It ought to be possible to
>> make the copy before ExitBootServices(), via normal EFI allocation. If
>> replacing a pointer in the config table was okay(ish), this could even
>> be utilized to overcome the kexec problem.
>=20
> What type should I use for the allocation?  EfiLoaderData looks like the
> most consistent choice, but I am not sure if memory so allocated remains
> valid when Xen hands off to the OS, so EfiRuntimeServicesData might be a
> better choice.

It definitely is. We do recycle EfiLoaderData ourselves.

>  To avoid memory leaks from repeated kexec(), this could
> be made conditional on the ESRT not being in memory of type
> EfiRuntimeServicesData to begin with.

Of course - there's no point relocating the blob when it already is
immune to recycling.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:04:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:04:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317055.536198 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkMXn-0001hM-F8; Fri, 29 Apr 2022 09:04:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317055.536198; Fri, 29 Apr 2022 09:04:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkMXn-0001hF-Bt; Fri, 29 Apr 2022 09:04:07 +0000
Received: by outflank-mailman (input) for mailman id 317055;
 Fri, 29 Apr 2022 09:04:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nkMXl-0001gz-Nd
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:04:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nkMXi-0003h1-JN; Fri, 29 Apr 2022 09:04:02 +0000
Received: from [54.239.6.189] (helo=[192.168.23.31])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nkMXi-0003fu-Cr; Fri, 29 Apr 2022 09:04:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=qSuXf/Px7iSHyMuIBSOmSTZ/yccocniHl5nPOPEA/X8=; b=n+dEbDUOSZ9rdy50B6v7TiYU3B
	eO1pTHjPqza4R2lUXXgXSKqrTdoHuATOiV42of6w8y/DAzMRZ6JSoKDW91QwXFTf87aeN2uLMOhs0
	e6n+z5+oKh12Oy+jW7JK5FywdE0wd9x/wt8tAnPaOkQPjVrLeGyR5ti6IVJZl2HZY0KU=;
Message-ID: <cc097cb8-d04d-6441-d0f8-4027c7d0dc8e@xen.org>
Date: Fri, 29 Apr 2022 10:04:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall.oss@gmail.com>,
 osstest service owner <osstest-admin@xenproject.org>,
 xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>,
 David Vrabel <dvrabel@amazon.co.uk>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <osstest-169781-mainreport@xen.org>
 <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
 <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop>
 <CAJ=z9a1bu=3sX0rvWy+T-ey4363DMUEJvzkSqkQkTnvOQtT0=A@mail.gmail.com>
 <alpine.DEB.2.22.394.2204271622520.915916@ubuntu-linux-20-04-desktop>
 <ac0a0bf0-81a8-63c7-6a62-377672e24069@xen.org>
 <alpine.DEB.2.22.394.2204281647540.915916@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204281647540.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 29/04/2022 01:41, Stefano Stabellini wrote:
> On Thu, 28 Apr 2022, Julien Grall wrote:
>> On 28/04/2022 01:47, Stefano Stabellini wrote:
>>> On Thu, 28 Apr 2022, Julien Grall wrote:
>>>> Hi Stefano,
>>>>
>>>> On Thu, 28 Apr 2022, 00:02 Stefano Stabellini, <sstabellini@kernel.org>
>>>> wrote
>>>>         It seems to me that it is acceptable to allocate memory with
>>>> interrupt
>>>>         disabled during __init. I cannot see any drawbacks with it. I think
>>>> we
>>>>         should change the ASSERT to only trigger after __init: system_state
>>>> ==
>>>>         SYS_STATE_active.
>>>>
>>>>         What do you think?
>>>>
>>>>
>>>> This would solve the immediate problem but not the long term one (i.e cpu
>>>> hotplug).
>>>>
>>>> So I think it would be better to properly fix it right away.
>>>
>>> Yeah, you are right about cpu hotplug. I think both statements are true:
>>>
>>> - it is true that this is supposed to work with cpu hotplug and these
>>>     functions might be directly affected by cpu hotplug (by a CPU coming
>>>     online later on)
>>>
>>> - it is also true that it might not make sense to ASSERT at __init time
>>>     if IRQs are disabled. There might be other places, not affected by cpu
>>>     hotplug, where we do memory allocation at __init time with IRQ
>>>     disabled. It might still be a good idea to add the system_state ==
>>>     SYS_STATE_active check in the ASSERT, not to solve this specific
>>>     problem but to avoid other issues.
>>
>> AFAIU, it is not safe on x86 to do TLB flush with interrupts disabled *and*
>> multiple CPUs running. So we can't generically relax the check.
>>
>> Looking at the OSSTest results, both Arm32 and Arm64 without GICv3 ITS tests
>> have passed. So it seems unnecessary to me to preemptively relax the check
>> just for Arm.
> 
> It is good news that it works already (GICv3 aside) on ARM. If you
> prefer not to relax it, I am OK with it (although it makes me a bit
> worried about future breakages).

Bear in mind this is a debug only breakage, production build will work 
fines with any ASSERT() affecting large code base, it is going to be 
difficult to find all the potential misuse. So we have to rely on wider 
testing and fix it as it gets reported.

If we relax the check, then we are never going to be able to harden the 
code in timely maneer.

>>> In regard to gicv3_lpi_allocate_pendtable, I haven't thought about the
>>> implications of cpu hotplug for LPIs and GICv3 before. Do you envision
>>> that in a CPU hotplug scenario gicv3_lpi_init_rdist would be called when
>>> the extra CPU comes online?
>>
>> It is already called per-CPU. See gicv3_secondary_cpu_init() ->
>> gicv3_cpu_init() -> gicv3_populate_rdist().
> 
> Got it, thanks!
> 
> 
>>> Today gicv3_lpi_init_rdist is called based on the number of
>>> rdist_regions without checking if the CPU is online or offline (I think ?)
>>
>> The re-distributors are not banked and therefore accessible by everyone.
>> However, in Xen case, each pCPU will only touch its own re-distributor (well
>> aside TYPER to figure out the ID).
>>
>> The loop in gicv3_populate_rdist() will walk throught all the
>> re-distributor to find which one corresponds to the current pCPU. Once we
>> found it, we will call gicv3_lpi_init_rdist() to fully initialize the
>> re-distributor.
>>
>> I don't think we want to populate the memory for each re-distributor in
>> advance.
> 
> I agree.
> 
> Currently we do:
> 
>      start_secondary
>          [...]
>          gic_init_secondary_cpu()
>              [...]
>              gicv3_lpi_init_rdist()
>          [...]
>          local_irq_enable();
> 
> Which seems to be the right sequence to me. There must be an early boot
> phase where interrupts are disabled on a CPU but memory allocations are
> possible. If this was x86 with the tlbflush limitation, I would suggest
> to have per-cpu memory mapping areas so that we don't have to do any
> global tlb flushes with interrupts disabled.
> 
> On ARM, we don't have the tlbflush limitation so we could do that but we
> wouldn't have much to gain from it.
> 
> Also, this seems to be a bit of a special case, because in general we
> can move drivers initializations later after local_irq_enable(). But
> this is the interrupt controller driver itself -- we cannot move it
> after local_irq_enable().
> 
> So maybe an ad-hoc solution could be acceptable?

We don't need any ad-hoc solution here. We can register a CPU notifier 
that will notify us when a CPU will be prepared. Something like below 
should work (untested yet):

diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
index e1594dd20e4c..ccf4868540f5 100644
--- a/xen/arch/arm/gic-v3-lpi.c
+++ b/xen/arch/arm/gic-v3-lpi.c
@@ -18,6 +18,7 @@
   * along with this program; If not, see <http://www.gnu.org/licenses/>.
   */

+#include <xen/cpu.h>
  #include <xen/lib.h>
  #include <xen/mm.h>
  #include <xen/param.h>
@@ -234,18 +235,13 @@ void gicv3_lpi_update_host_entry(uint32_t 
host_lpi, int domain_id,
      write_u64_atomic(&hlpip->data, hlpi.data);
  }

-static int gicv3_lpi_allocate_pendtable(uint64_t *reg)
+static int gicv3_lpi_allocate_pendtable(unsigned int cpu)
  {
-    uint64_t val;
      void *pendtable;

-    if ( this_cpu(lpi_redist).pending_table )
+    if ( per_cpu(lpi_redist, cpu).pending_table )
          return -EBUSY;

-    val  = GIC_BASER_CACHE_RaWaWb << 
GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
-    val |= GIC_BASER_CACHE_SameAsInner << 
GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT;
-    val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT;
-
      /*
       * The pending table holds one bit per LPI and even covers bits for
       * interrupt IDs below 8192, so we allocate the full range.
@@ -265,13 +261,38 @@ static int gicv3_lpi_allocate_pendtable(uint64_t *reg)
      clean_and_invalidate_dcache_va_range(pendtable,
                                           lpi_data.max_host_lpi_ids / 8);

-    this_cpu(lpi_redist).pending_table = pendtable;
+    per_cpu(lpi_redist, cpu).pending_table = pendtable;

-    val |= GICR_PENDBASER_PTZ;
+    return 0;
+}
+
+static int gicv3_lpi_set_pendtable(void __iomem *rdist_base)
+{
+    const void *pendtable = this_cpu(lpi_redist).pending_table;
+    uint64_t val;
+
+    if ( !pendtable )
+        return -ENOMEM;

+    ASSERT(virt_to_maddr(pendtable) & ~GENMASK(51, 16));
+
+    val  = GIC_BASER_CACHE_RaWaWb << 
GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
+    val |= GIC_BASER_CACHE_SameAsInner << 
GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT;
+    val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT;
+    val |= GICR_PENDBASER_PTZ;
      val |= virt_to_maddr(pendtable);

-    *reg = val;
+    writeq_relaxed(val, rdist_base + GICR_PENDBASER);
+    val = readq_relaxed(rdist_base + GICR_PENDBASER);
+
+    /* If the hardware reports non-shareable, drop cacheability as well. */
+    if ( !(val & GICR_PENDBASER_SHAREABILITY_MASK) )
+    {
+        val &= ~GICR_PENDBASER_INNER_CACHEABILITY_MASK;
+        val |= GIC_BASER_CACHE_nC << 
GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
+
+        writeq_relaxed(val, rdist_base + GICR_PENDBASER);
+    }

      return 0;
  }
@@ -340,7 +361,6 @@ static int gicv3_lpi_set_proptable(void __iomem * 
rdist_base)
  int gicv3_lpi_init_rdist(void __iomem * rdist_base)
  {
      uint32_t reg;
-    uint64_t table_reg;
      int ret;

      /* We don't support LPIs without an ITS. */
@@ -352,24 +372,33 @@ int gicv3_lpi_init_rdist(void __iomem * rdist_base)
      if ( reg & GICR_CTLR_ENABLE_LPIS )
          return -EBUSY;

-    ret = gicv3_lpi_allocate_pendtable(&table_reg);
+    ret = gicv3_lpi_set_pendtable(rdist_base);
      if ( ret )
          return ret;
-    writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER);
-    table_reg = readq_relaxed(rdist_base + GICR_PENDBASER);

-    /* If the hardware reports non-shareable, drop cacheability as well. */
-    if ( !(table_reg & GICR_PENDBASER_SHAREABILITY_MASK) )
-    {
-        table_reg &= ~GICR_PENDBASER_INNER_CACHEABILITY_MASK;
-        table_reg |= GIC_BASER_CACHE_nC << 
GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
+    return gicv3_lpi_set_proptable(rdist_base);
+}
+
+static int cpu_callback(struct notifier_block *nfb, unsigned long action,
+                        void *hcpu)
+{
+    unsigned long cpu = (unsigned long)hcpu;
+    int rc = 0;

-        writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER);
+    switch ( action )
+    {
+    case CPU_UP_PREPARE:
+        rc = gicv3_lpi_allocate_pendtable(cpu);
+        break;
      }

-    return gicv3_lpi_set_proptable(rdist_base);
+    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
  }

+static struct notifier_block cpu_nfb = {
+    .notifier_call = cpu_callback,
+};
+
  static unsigned int max_lpi_bits = 20;
  integer_param("max_lpi_bits", max_lpi_bits);

@@ -381,6 +410,7 @@ integer_param("max_lpi_bits", max_lpi_bits);
  int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)
  {
      unsigned int nr_lpi_ptrs;
+    int rc;

      /* We rely on the data structure being atomically accessible. */
      BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long));
@@ -413,7 +443,14 @@ int gicv3_lpi_init_host_lpis(unsigned int 
host_lpi_bits)

      printk("GICv3: using at most %lu LPIs on the host.\n", 
MAX_NR_HOST_LPIS);

-    return 0;
+    /* Register the CPU notifier and allocate memory for the boot CPU */
+    register_cpu_notifier(&cpu_nfb);
+    rc = gicv3_lpi_allocate_pendtable(smp_processor_id());
+    if ( rc )
+        printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n",
+               smp_processor_id());
+
+    return rc;
  }

  static int find_unused_host_lpi(uint32_t start, uint32_t *index)

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:24:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:24:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317064.536213 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkMra-00048C-6m; Fri, 29 Apr 2022 09:24:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317064.536213; Fri, 29 Apr 2022 09:24:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkMra-000485-3d; Fri, 29 Apr 2022 09:24:34 +0000
Received: by outflank-mailman (input) for mailman id 317064;
 Fri, 29 Apr 2022 09:24:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H4Mb=VH=citrix.com=prvs=111705440=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nkMrZ-00047z-0r
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:24:33 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2acdb368-c79e-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 11:24:30 +0200 (CEST)
Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 05:24:22 -0400
Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27)
 by SJ0PR03MB6600.namprd03.prod.outlook.com (2603:10b6:a03:389::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Fri, 29 Apr
 2022 09:24:20 +0000
Received: from BN7PR03MB3618.namprd03.prod.outlook.com
 ([fe80::159a:f6a4:c03:227a]) by BN7PR03MB3618.namprd03.prod.outlook.com
 ([fe80::159a:f6a4:c03:227a%5]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 09:24:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2acdb368-c79e-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651224270;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=HdFr8Kc9VqJtpgK/0qyp9Qiw85M3ULywxuFXxlSrkPo=;
  b=UgB83aCP2tagwc1cmsa2efA53FS79LwrxCFMqok5V5NQtt9oEz+5dyyc
   EYqQlc9dkmHm71jcCtkwd53j+XjrpeSI8eXHQEO6jUMMnsiYb4zAG8MLK
   R5rlwUGcs66KPNiy+zBp0BNZNDnLkYAAAV08h/cHf4psmQ2noiZOelsGo
   c=;
X-IronPort-RemoteIP: 104.47.55.173
X-IronPort-MID: 70216186
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:YJGmP6DFJauuVhVW/1viw5YqxClBgxIJ4kV8jS/XYbTApD8n0GEBm
 GQYCG6DP63eYDTxf4x2OY22/E0BsJXcz99hQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Jj09Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhQ8
 dl/vq2/TT0bHfeXmOE2eUkbMiVHaPguFL/veRBTsOS15mifKT7G5aUrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t7B8mcGM0m5vcBtNs0rulIEezTe
 Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLGUC8QzM9fRfD2774gpQzr/tDufpZuOVHZhZjAHGu
 WbMxjGsav0dHJnFodafyVq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRomyUVs9bK
 kcU0jEztqV0/0uuJvHiWzWorXjCuQQTM+e8CMU/4QCJj6DSswCQAzFeSiYbMYN98sgrWTYty
 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP46TMZZUvWd9enM/
 g23
IronPort-HdrOrdr: A9a23:l0vuA6B7olVY6FrlHej8sseALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuqKdkrNhR4tKOzOW9ldATbsSobcKpgeNJ8SQzJ876U
 4NSclD4ZjLfCBHZKXBkUiF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca
 Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlul9yZbdwkK7aYp8G
 DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4oow3TX+0OVjbZaKvq/VQMO0aeSAZER4Y
 DxSiIbToBOArXqDzmISFXWqlLdOX0VmgLfIBej8AfeSIrCNXIH4oN69PxkmlGy0TtegPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59Zs5Vza/pWVFZql/1WwKqVKuZ0IAvqrIQ8VO
 V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkaoFlpi08DgMAPlHYJ85wwD5FC+u
 TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWsKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ
 zEFEhVsGYjEnief/FnkPZwg2LwqaWGLEPQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP
 v2MI5KApbYXB/TJbo=
X-IronPort-AV: E=Sophos;i="5.91,297,1647316800"; 
   d="scan'208";a="70216186"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LhePOq1uKf5GQFTAkPcjlS21E8dKpLUBQpkJZqxScpsTm1KjJx5kFLYCcLoCSki/BUcmVHaO1b50of7L7KN9RWHJnhGeZ5aiq5QykcIKDl1JAp0AJx1DBmh7PwA+hBlknl+cUOr8nNSqUu1G6nA10fmyzVsOwKawjfuMazeVg3Wg4xkS+dg+H4GFkiohqghbEpWA+VTgTccY1HLSaH4kneA0SL82oALHS28HuectDa7ce0zigBzG4o3DY0XZ6jE4hutxdkX5J2qwHC75leGLg51BXLwykNyhsxtFBQGICSq/6Hu+bgHDp8Y4P/pbMmRL/h86WAVJktEaL4Ltwqpi3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HdFr8Kc9VqJtpgK/0qyp9Qiw85M3ULywxuFXxlSrkPo=;
 b=fOmap+Q+JxCyPPOgY7RguqyG5EV1UEMmDV1gYo1iahxJyePEf7jI9JzysIJvxKoCsyIRiydFEuUUlRGbQ28U82tXxpcHQPftDHg1Sj/uSwoeGHL4BiTYAB/TsNmSdpR/ebj2bbAbC4WE/glt0ZPDYDm4FwIYPCyg8RhabryIRfDbxRAljBO3MZnRXj2mpbSUXmmAmkLCUrtYWUTnp3nkx7WU5P+RPSPPSgQ1OkqaLcH/r+5s6TAuvgvVY0rD9mdHZl+GeIyiK7RGdeNk1PZM4WgndwGyccJw9Px3RBnt0ZQaIx/3mXN3RXjM19yBF25mYNisdjtL+k8JLOztp4cR3A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HdFr8Kc9VqJtpgK/0qyp9Qiw85M3ULywxuFXxlSrkPo=;
 b=JNnCCqVpCvoL4QhAnaA1e702CMRMv1hxzz5HNPo57OrX1wUVhoex+0WMhQj8oogY2jGmj3vGnjyyGQer9fB7UIc1hcbgL88rSKwk1DYxN8kJsSfIn7e1BuVcPGGnJhVazARlwMGOa1I27AgmgWCpMKNfJdvPiGqTt7h7TtREEkc=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/cet: Support cet=<bool> on the command line
Thread-Topic: [PATCH] x86/cet: Support cet=<bool> on the command line
Thread-Index: AQHYWt1N9h0ywB7VLke90Ph7I2J/jK0FDHAAgAGTo4A=
Date: Fri, 29 Apr 2022 09:24:19 +0000
Message-ID: <1fbac5d6-ac4c-64e3-3201-b3e2165e0100@citrix.com>
References: <20220428085209.15327-1-andrew.cooper3@citrix.com>
 <YmpcKmecShU2Mokz@Air-de-Roger>
In-Reply-To: <YmpcKmecShU2Mokz@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 92a794d7-97e7-49ac-6573-08da29c20a3d
x-ms-traffictypediagnostic: SJ0PR03MB6600:EE_
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
 <SJ0PR03MB6600195F1CD4C82268CB2514BAFC9@SJ0PR03MB6600.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 AvyVV51BrUw6iNI4y022ER2yKGnwSAtg/1ge7yONWklooqo7cTBVsBSCpV2tcf64xiffLiflUun6+wgBY/4xUowdP1MglAPBuglmqfvB5SEKkzMfDjz443ke7C3lOBBQ/v3o0fzaA1p2QcNjILDOt+u32yopXyjr/GD1oXKX+lFLNIhGAPyk5qFpQA2pEzqCXzD8yBzPVSIDTeoLTwltyNgaEfXO92c+Ra7baCzOvEhumYG86Ud0gAb9ebdITtSLzsBW2VFOclRvRgTfgDtxFFsQ6F8KROWmkpIIvE8tl8hBZmk7Il+wpO6pcxvN9S7X/Qv6OcePksVLHltp1XwH0kzcHafQLqY601ylErdNHT8BVCuNVKs3qdoBC6RU9BzJFt3GQZ+qfr3VwT96YHS6CTMctj5lgZoP2D2gqs7DbsK+3AVsYjv5BmzEtQ7ZTbcf4b0dZc/+aEoG7Kfda+Ds5PMVxTzjlxyEHNDVEeO5JqeulQxF28EZklCrf+SmCOYcgnJ95FDwsAVCuMj/fm9sHiHTHIVB/qd5GndXB7afQ/4xveRFfsxb+M3HxAuO41LB7p5yW66p5py0v2T1V2T/jKcgrmCc0b+1OGSn/F11E+H1VSr5LFou8jEcfe1lhqQqT4W1cr8khQY9MFD4RyKbqt6mpxSJ2oZGLUXHDGAjncEyo6pCYNqNOEagmsanpSaPqO90TKtrXCnESlQiIdBKGTrvAIokK4zQkG0sHixWkX9AcGY5D1PY8Xf6kvRmbxDBglR9EVPH5kIyFBTvWh/PZw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2616005)(186003)(6636002)(2906002)(31686004)(4744005)(71200400001)(26005)(6486002)(122000001)(6512007)(5660300002)(54906003)(8936002)(316002)(37006003)(64756008)(66476007)(53546011)(66556008)(66446008)(91956017)(66946007)(76116006)(6862004)(4326008)(508600001)(8676002)(82960400001)(6506007)(38100700002)(86362001)(31696002)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?M0xzSjdOdlVWc2Q1cjhpUEVjMDJSeFB6OFcyL2tEYUVydytXK1pCbUcwdjls?=
 =?utf-8?B?bnhtY0lIVjFMWURoYVkwT0lQUkZDR2hTN0Z2VzF2WHJIUWUzUkozZHJhV2Vq?=
 =?utf-8?B?eGJINW1kT1g1dXgxeXQ4YWhlZXFBSTEyc0pPcXRKaVdsMXFwOWN5UTdCYnZh?=
 =?utf-8?B?L0F5eEtJNW5wYkU0MGNqOUppajI1Mjkyckhlcko2eTBPeFZST3RFVzAweGlD?=
 =?utf-8?B?TmF0TXErWVNOcFJkK2l2bGNrTjFMK09RUVhJZVMxN1krRmNpRWJSRDFWUkhY?=
 =?utf-8?B?bEZsdkJINVJkeGtXa0xnOUt5a3lhb3FadU5xb3hnNGRlbmVZOFpubDNOUXB2?=
 =?utf-8?B?eW5vcFZEUEFRV1p5ZWFZejRWdmE2Yi9XQitxa05LZWFmQkg2ZS9jSklBVEVR?=
 =?utf-8?B?T3dCTmtFTmIrL1Z0WmNoQTlsenhBb0ZaUW1UNWlXZVVCOGYxemc3ZytPRENa?=
 =?utf-8?B?aWVYOE1CN1Z3enRlSGt5dFpDSHhKWGhXVFJhOUhXQnQySzVXZ3ZmQmdQTCs2?=
 =?utf-8?B?b00yUHEveVNwZk5TdSszY2tCTzROYWx3aWdST281eTBzcWtLSjl0MHNwbk9X?=
 =?utf-8?B?WGRqazQ5R2xXWWZ5Y0xFeWhpcE8yNUwzUkxLL29oYXYyUXk0UkFxWTFCcHlN?=
 =?utf-8?B?N1BXY0RIS01pcUQxdVN6T0RBelVsSWJUbk9ITEpaVE1zTTFMbVBoTmFrSGho?=
 =?utf-8?B?SnJuOEJoNWxMMkhkOEViOXR3QU4xSTBReVdIanduOFFSV1B1VUdvSEZPVW0v?=
 =?utf-8?B?Rm51N0hjNUhjb2hjaVhpSjRpT3p5cDEwNkhlc1Zxbmdtb3Z5WE5QMWV2c0ZG?=
 =?utf-8?B?M2lqVmNvbEJxdGdFMHRvUGMvL25JUzI1bWlOZmhyRXUzWVl2REZiUWs1TW9Q?=
 =?utf-8?B?b3dSYmxITVBqN2YzRHlqeG51bGFaRHkzbGdkbVV4Nmg3RFlSaUZ4YXlqei9k?=
 =?utf-8?B?cGZBdnJpeXhoZlhjYTNDcDNxV2w3cEZVd01nQ3l0aWQwK3c0ZDY4RVNlZUww?=
 =?utf-8?B?UWU2TXhtVGdBRmRqZGdHZDdMMlg4ck92enNOYzByRHFnTDE5NWluV1VGWS9h?=
 =?utf-8?B?YW9lOHkyZlhEVXJOZlRsNXlxR3JZWUpFRDFvQWE0dTVod2RWWDdGeXpqZitv?=
 =?utf-8?B?Y2R4aTZlSWhtVWd5d0tTQ0ljZDZidHlQaVVlNnFMcUlpVGQ5VkhES3dDcGFO?=
 =?utf-8?B?MlFweVk2eDU5TlcxaFNRQldUWkRIOVZkUDAyTHVYcG5NeTF4RUZCajNuM3ZF?=
 =?utf-8?B?UjlPd3NsV3NlSmYyT3hjYSthMkFnNEZMakNUenR1Y29jQ2JPdndDUEhIS2lZ?=
 =?utf-8?B?bVdsVjN1UkNOK3JoV1hBdzFtUi92WVc5UEpWWUU1MjJ6T2psUVFOTnZmaERS?=
 =?utf-8?B?a29oVCt3dVMwK1lLeEZSQWd0bTR6YnMwa1hJWUdsT05KcTBqL2F0Q01XSEhk?=
 =?utf-8?B?WHhpMHRMRDU4ZHRSMFFCbFdudkltdnhoV1NLNUVzSnRuTUZZTVhBU1RsWi9w?=
 =?utf-8?B?M2oxREkvZCtQbGJBYUdOZTFzNHRJSUowVm5DVXlXdlBSL1o4Mno4R0F0aFB6?=
 =?utf-8?B?dGlIbWJGVktEV2hoT1dqOVhCKzhJZkRYVVU0enZkTHU0Yk83VG96ckpIMlIz?=
 =?utf-8?B?UVAraWRkV09zQUg2VFJNeGJPMkt4dEJuS2hjc2Y3c0xvdGZpcEFZcW51bDhH?=
 =?utf-8?B?bHFtVjd0aWZxL1FIUGprM200eElyM0dSOWJHNnFsUDRXVHdhSEVRV1pYZHU4?=
 =?utf-8?B?QitMaUZmL0VYWEh0Y3BvSlMvZG1ucXlaeUZSM2tnU25HZlplWmNrWVpuajBz?=
 =?utf-8?B?cnZUZlRtQkVjN09BQ1lrYmN0ckM1RkZYbW8zMzhKclRnNS9aem1WbVBUSVVi?=
 =?utf-8?B?MWVtWXVITzVCYmpSMlc1NW9TU1dWOSsvcEFUUkFrbTd2djVkYUhDT0V6ajZK?=
 =?utf-8?B?S2g1TEkvVTZJSjk1QnY2YjhKS3llN0Z0U3Irc1ljUkltWVhzN21nT0ZhQytL?=
 =?utf-8?B?clRYNWR3QTdiQitSUXpVZlVXcmdDVUZST3IwY01wMFAzN0UzWnd2d2g1Rks0?=
 =?utf-8?B?WUZOdFprNWVWYzg0eG5seTJFVWFaY1NPZWswVmZWbU0vSWYvOWQyWlR6RWd3?=
 =?utf-8?B?V3lXMG9Pd2NZTm5PeWdjS1pXZldEWVdDRDE1d1k1MlJjSkpUdUxDWkJ3NlNZ?=
 =?utf-8?B?UzBEeDZCaWtBSXNyY1NFcGw3WWdYOFJ1bE1GRmkwUWJzdnhLVVZpWll0NGRG?=
 =?utf-8?B?WVhNWXpPL1BGWDdTRzR0SEJZV1VuTndSUTlldTVueUdBZnNPci96NnF2YmFW?=
 =?utf-8?B?KzY3ZlFkVklxSVl2cFc3eU5UYXpiZDA2cjN6dnJjM3dSb01nMXB6QT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6E7BAA84EE2A78488F8A360C9208286E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92a794d7-97e7-49ac-6573-08da29c20a3d
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 09:24:19.8224
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: n/kDwrcE58uzm1OumyF56dbZ+pv7/JpxFO7NWMDHqXdROoo2mvwB7XLaqXD/MqaRQenT+7Jgx+mebKtVhcveZ1IseieWQK/jk1nlQU8kW5A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6600

T24gMjgvMDQvMjAyMiAxMDoxOSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gVGh1LCBB
cHIgMjgsIDIwMjIgYXQgMDk6NTI6MDlBTSArMDEwMCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+
IC4uLiBhcyBhIHNob3J0aGFuZCBmb3Igc2V0dGluZyBib3RoIHN1Ym9wdGlvbnMgYXQgb25jZS4N
Cj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRy
aXguY29tPg0KPiBSZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp
eC5jb20+DQoNClRoYW5rcy4NCg0KPg0KPiBGcm9tIHRoZSBpbXBsZW1lbnRhdGlvbiBiZWxvdyB3
ZSB3b3VsZCBzdXBwb3J0IHNldHRpbmdzIGxpa2U6DQo+DQo+IGNldD10cnVlLHNoc3RrPWZhbHNl
DQo+DQo+IFdoaWNoIEkgdGhpbmsgaXQncyBpbmRlbnRlZD8gIEhhdmUgYSBnbG9iYWwgZGVmYXVs
dCBmb3IgYWxsIG9wdGlvbnMsDQo+IHNldCBzb21lIHRvIGEgZGlmZmVyZW50IHZhbHVlLg0KDQpU
aGF0J3MgaG93IGFsbCBsaXN0IG9wdGlvbnMgd29yaywgYW5kIGl0J3MgYWxzbyBlcXVpdmFsZW50
IHRvDQoNCmNldD10cnVlIGNldD1zaHN0az1mYWxzZQ0KDQpPcHRpb25zIGNhbiBiZSBnaXZlbiBt
dWx0aXBsZSB0aW1lLCBhbmQgYXJlIHBhcnNlZCBsZWZ0IHRvIHJpZ2h0IHdpdGgNCnRoZSBsYXRl
c3Qgc2V0dGluZyB0YWtpbmcgcHJlY2VkZW5jZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:37:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:37:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317072.536235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN3n-0005uV-Jf; Fri, 29 Apr 2022 09:37:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317072.536235; Fri, 29 Apr 2022 09:37:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN3n-0005uM-Gg; Fri, 29 Apr 2022 09:37:11 +0000
Received: by outflank-mailman (input) for mailman id 317072;
 Fri, 29 Apr 2022 09:37:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkN3m-0005tt-Hb
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:37:10 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eab22048-c79f-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 11:37:00 +0200 (CEST)
Received: from mail-sn1anam02lp2046.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.46])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 05:37:06 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM6PR03MB4825.namprd03.prod.outlook.com (2603:10b6:5:187::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr
 2022 09:37:04 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 09:37:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eab22048-c79f-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651225028;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=ORJMMvNnQVmZ7HWFk8JpgJ9yxSYZYozVFklh81N88pA=;
  b=FiZuov9L7peqGibSfeKs170ntzCxuzsTazDBS9kt9K6HNn4PtdgAokvD
   j91CqvUw/Yq5cXFEQ8qjN8DCEno/UPyOSdIk0KR8/TRZ+GY1Agvx5LZ4s
   +AJwbUQD95kVHBxjqWa64GVSyuMkJvGMtlbECW7y5QPe88iay2coqA1+f
   U=;
X-IronPort-RemoteIP: 104.47.57.46
X-IronPort-MID: 70098537
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:BhmC/6qIEAPOLQaXdd4PrFhAXjBeBmIyZBIvgKrLsJaIsI4StFCzt
 garIBnSO62Iamv9Ko0jYYS08UgP75DXydRrHQM4pCs8ESIRoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvR4
 4Kq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBfbDFmu4/dDlkOjAlIpAe4qHZHD+imJnGp6HGWyOEL/RGKmgTZdddwcAuRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFg3Fs2KiiHt6HD
 yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3N/ftnvjOMpOB3+LWzb9TTZYKkfNpMmmOJq
 0v5/ULzDR5PYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWQomOAvxMac8pdFas98g7l4rHP/w+TC2wATzhAQN8rrsk7QXotz
 FDht8ztLSxitvuSU3313rKVpjO7PW4SN30PYQcNVw5D6N7myLzflTrKR9dnVbWz19TzEDSom
 TSS9nBi2fMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U
 LIswqByMMhm4UmxqRGw
IronPort-HdrOrdr: A9a23:p1zsXqlBl2S2ft28g7Q41UoI/mbpDfOlimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhR4tKPTOWw1dASbsP0WKM+UyFJ8STzI5gPO
 JbAtFD4b7LfCdHZLjBkW6F+r8bqbHokZxAx92ut0uFJTsaF52IhD0JbzpzfHcGJzWvUvECZe
 ehD4d81nKdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInly6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXsIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6U9bc16UGT0vDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNId3AL3Z
 WBDk1SrsA+ciYnV9MCOA4/e7rGNoW0e2OrDIuzGyWQKEhVAQOFl3bIiI9Flt2CSdgv8KYYvq
 jnfRdxiVMSEniefPFmmqc7vyzwfA==
X-IronPort-AV: E=Sophos;i="5.91,297,1647316800"; 
   d="scan'208";a="70098537"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eiQiqoyzttdTj8MO3eamdXC9fyp13+9fsfF4/55v9Fp01qJf0fj/d9dcBfQ395HruJhSeNSkHy+TET31hSAZjAT0b/kelYg+rshyFiMyLkCRtiLLYnk/nCvpn1AyRRcJoJjkkBcn11DOgD4Mc+lID7NNWH3mDIWnGdU/du3GMSJNffU7B5NS3ytemNbw0KnCPzaUGOMJ5tbDWQKUjTIGngAhSQsxv/zsQsDjegEJYpdRgDF5O4jhZKVEUEGJXv0YyDs9J4t/FZL2XyOak4/d0m4EqgG+OlDGMTJtdR4U6pbPyuFnwFEdaql67QLGWFtj7vSXeDm1AMt8qhVQEk7TXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ma9YKJQlDCAv1sCb57FfMX4fSZLJmr+FZCfb9h8i2+U=;
 b=XZJkJi+1GT4SQJg3p86IGNdze5lbEKfSnRy2RZY9GHOb8tdOBD/zgSd+7DA5oX2FNkX6brXjY2yVvwRL0ah3w8O1h89C4NY7NkpgN7e2QmYfOtAnViuQTb8SJdBpQ6bV7xyasTXYyFRPRh2I/5I3Sn8kDH41vNOW3+C1ATPejiud8ryS45XDLAS2+e9lAGpnhnCvWK1yyFxw5KMgYHgaIY9uZcauFHFyKc2SasbuMI0tRqS4deh2sMjNJujuv6SUJBiiBpqhTG3kmq2hevkXLC2wTbIHFEX0G3rwvNDBhzT1lp61sbbNNAlCikG3pVQyyKkHsx0obAff412TC8K6Ww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ma9YKJQlDCAv1sCb57FfMX4fSZLJmr+FZCfb9h8i2+U=;
 b=GtilG0b8ateTKW+H9qvOIlPM9mBcrZFUf1MzzNzTkxJHKVfoxpRkb+ER4epzn/wSmB/gcbJhRwsJdFoR37pWINjHuWbT+KYiWyBoZz8/2q92wLr+6TSBsX5ILm60POOXm8iYrWLWVZe/cS2WRyskazAIDpGolyLJM1txZMs98jY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Michal Orzel <michal.orzel@arm.com>
Subject: [PATCH 1/2] kconfig: detect LD implementation
Date: Fri, 29 Apr 2022 11:36:43 +0200
Message-Id: <20220429093644.99574-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220429093644.99574-1-roger.pau@citrix.com>
References: <20220429093644.99574-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0031.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::19)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5b6bf585-9f29-4a12-4a35-08da29c3d1f3
X-MS-TrafficTypeDiagnostic: DM6PR03MB4825:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<DM6PR03MB48257348179265D07105DE7C8FFC9@DM6PR03MB4825.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Qg1HGnCNZiC/Sc8rBJDhgnxyyvYTyPpdE0DW7JlzYDLbr5xaihEAFF7pezE2KfBiU9UnOkFoIxPDY7cj9h30UPCnfcNZvLJNZ38sHrTt6ueI7hKZwjBw2/qX7EW3cDC2BEVZmkti9vIeF8IC0ui5pJfhK0fXcUfDnTQ6qmYPT6eAWIv+E4rl3x8BunfR/XKnhZk4uDU4oOfLAo6KHdm/P//DVXKEbDAI3TEvuyPdSVeNrltwhniorQcYbeu2w1fTgQLzHAiJs8BAJJrX0SbYdceONjWeJw26G6qlgNFX5hGof2DSjDUJ5rm3oWqaC83PkVp+N9RoFtSupW6+CSGoH9SDVCfH7Dpsnq+SVm0pl6cLFDH1KD24NU5LVzdXAThJB2cuMm+1qzaNivDxyZsIR6GjCmWg9/jKCoqbg96LJGJ5xRN09RgOXASuo4vHSgKmpgmwD/3rmVX9m80JsXdp87I8lea8vd2OAURgo4pAcZiBuP9cdCA/Jog1SSBKvKy03XUIKe/F4dEXPSWvhbgOMYmNNUD9PbcnS5E5M8pnIOKhhhosPaVqMBvRCcLUuDI9OFdRsJ9wI0axe5X1h9LkNSU/dVX1CpVTEUzk1LalXxwFI1BwezdB0SCHFr+qzYNahrbwdepTU0Qbd238OcrKWk7LZ0nWbM3TMT44XLa11CFeUHMKDiNbr/rSxcE9r4tggPXmOQl07ANvf/BjtWnVpjzIM3JIFcXsC7icMy4BLGc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(6916009)(508600001)(8936002)(36756003)(66476007)(4326008)(8676002)(66946007)(316002)(82960400001)(54906003)(66556008)(26005)(2616005)(6512007)(6666004)(2906002)(1076003)(6506007)(966005)(6486002)(186003)(83380400001)(86362001)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?STZINDRlbThuVEExakFQSjRyZGZDWGExMEY0SXZVMTlneFJxMFoyOWUvaHdU?=
 =?utf-8?B?R2llcDJvclZFcjJwNnZHelZyVGpjYjgwcVduWVByWTVydzBMb2p4K01BNExN?=
 =?utf-8?B?Smt5WTl3STU2K01EdzVMNnQ2T3VKMUxaNGN2V0REbGt6cTBDVTQwa3o4dGdj?=
 =?utf-8?B?QzZ6akZNNWk4bnI3ODNZeTZ3cjNmQiszWDhYUXdPUzRvOE12V1dVMTYwNUk3?=
 =?utf-8?B?ZXhVK1o3NjFYYllwcklGZFQ1QXBJcVNXZTZLNXFpZEYxSGxyYnYzeW0vcnha?=
 =?utf-8?B?cWQrWVowLytSOWFybDdnNnZrcTVXeFZOdXhOTXZnakVSWEVVY0hVOXM5QnFS?=
 =?utf-8?B?NUZlZ1hrVkp1L054ZlVsR2hPeDlNUXFYTnAxaHF5QU5vbmNsQTJlbk4xRWh1?=
 =?utf-8?B?V1lDMWQ2ZHN2RXF5U1R6OTJ6OUNQZTVVdTBPSXZqN21rNklhM3V6REVJZmMv?=
 =?utf-8?B?R3dodkhqaHZtenpPSzBGQnRpNks2L0laSU5mSGJjWFo0VkgrOFptS2ZWbkRa?=
 =?utf-8?B?Mi9BQ1N4ekpUY2RZU3N6QWJ5eDdMWXRDRUEyR0Vsc09ZRjhZKzBTTTJWUzh0?=
 =?utf-8?B?WDIwOEw0NFlRbjVyUXFIb3VZME5XQ2pMRy9MRG1pK3ZjZUdrTXdzMldTU3lZ?=
 =?utf-8?B?Z0Q1WTNUT2dCRGxBY2xtY3dvc3JaYWtxSkdyWmlIVkZwblRCaXFTYkRRTWFw?=
 =?utf-8?B?Rmdxd2VGRlhTTCt1T0toTnMrOERselRrVVNCNjRRVmRHRU1DaTYzT1B5ZzFq?=
 =?utf-8?B?YmRsdEJEdDVqbUkyZit3bDdiUFdmSmRYQXdtc1pVY2FrNzFXSGFOUWx4TCsr?=
 =?utf-8?B?OG85MnE0RVZhb2NkWjhybVdsVnoybVFsdVZndjdJRmRuVWIzTW5OdW1udTRC?=
 =?utf-8?B?ZW9DYXNXTG1BejFUVzFYZDZFN0g5WXJaeThuSm1sSG9Jd3hSa2wwWUlVSWVv?=
 =?utf-8?B?Ty9wYnZvUWlHVExWYTE2d3JxeUxESUhIYWV5eVR5MUM2YndlNDBVTjM3QUha?=
 =?utf-8?B?UGhBZTZNSitoQ0l4bGJCd0piQjd0bFpnZzFOZVVxRW56S0R5L2hmeThmdGNo?=
 =?utf-8?B?ODFNL2gxa21PaGF4MWF2bTRtcGxrWGdnRDBpMTNBMXZCNWJ0bHFYU3JZa0xx?=
 =?utf-8?B?RzNBek12L0x4d1BpNWV6UGVrUExPcGFjUElZUEhlOUNPWDZXcVoyK2tYV1hZ?=
 =?utf-8?B?K1NMS0poVWlqTTBrallRa3RvMjRERlc0aTIrR2MwRGJDZ0tqWjcveEJLcUpT?=
 =?utf-8?B?Y092U1BRSVAzRytiTytLMDJUMG5SdHNlS01LY2Qva1VuZnhSWmErcHJpaStS?=
 =?utf-8?B?SXBWNXVKQlJYQStWdHpPMHV5ZERHWStiZGhpL2ZCNjQ5Q0NRdU4ydHpuSW01?=
 =?utf-8?B?MTNzV1BMOVZGUUwwTWJEY3lXSGNMazRwYmlsbTdOSmQwN2VjanpiS3F1NU1N?=
 =?utf-8?B?ald1QzZMM1VDZDZqc3MwY2szcXp1eUU5eHc5VWw3L2pFMWRKaXZNZ2ZXZzFu?=
 =?utf-8?B?N0lENkttbDlXdjhVZmgvYVN2Z2xuZEZPbHc0UjJVd21VNkhRczR5ZzV0MXdS?=
 =?utf-8?B?NXFDTHBpVVJHTng0L0Nkcm9SL3hLeDYxazhJTm03d1BLc3RFTktHMmhwVEVy?=
 =?utf-8?B?VDlOZ1huaUxOTXhlb2UwMWs0SElENGdFNDg2OUcxVGhqbkdLZUt4cjdHRmZs?=
 =?utf-8?B?TzdvWDY3Qm0wYUJCd3pDNFN0YzRYUXJYN1FRQkhlUURpSm1JbXJQZWNLYU9j?=
 =?utf-8?B?Q1BYVjdhVDhaQzZlQ0RIcGcveW44ZjRJV1NRZG5hVVpZVnNsdlowcEhKSXkz?=
 =?utf-8?B?aGl3TGU5VTlMSGhpNjhhb2FUZ1F0Z3NiRURIc1JNR1hoSU5TNlYxa3lXekdQ?=
 =?utf-8?B?eXlRZGNqckw1WlpVU2c3emphb0NNcHdUbXV3L054Vnd4bGx5RFZzYThKbDBR?=
 =?utf-8?B?REFFb2d3Y1VYb0FsUXBUOVRCRlFPMDB0N3lIOU1TaFhGaUZzYVFOR1VhTDdP?=
 =?utf-8?B?bWZ4UEo0VE1SZ3RPSE9WV0xaclpoNlF1WnMraEF5S04yb3UzU2hIQi9zMXJ4?=
 =?utf-8?B?d3lobDE1dWxRLzJUVHB2S1g1TnJjUnR0Qmk2NkZYZmVyamRuY1FWLytqZDg2?=
 =?utf-8?B?KzhrR1BMbS9PT09EVjBCNms4a0lvSjBGVHFqd0RQQTdkNGFEakVSS0E2Rysz?=
 =?utf-8?B?R0cwKzJrUUNTRFRXRSt3TjdBQjhvQnBZNzIvblp3bzhENzhNRXhScnVrcUNh?=
 =?utf-8?B?aWRqV2RmTlFjQ0c4RTVwQWJWNG9wZkw2aDlxVjZoVlE3bno3VUhxdWV3WmNs?=
 =?utf-8?B?ZjV6N1pKSDNGeDgyd0JDSjRMMWE2SDZyNW1La1Q1NUJVLzcycDFJVmU5eUZX?=
 =?utf-8?Q?V2J0GWn6zNRlhYkY=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b6bf585-9f29-4a12-4a35-08da29c3d1f3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 09:37:04.5965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tcl7RJOl9Rqr8mSSfRNjYxrjn7Bk1/82jqlQ4xkzAgjOfMXJVyqIiUQdHMg6hHmlxIDo6PwyZWbZFkP7aEyxEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4825

Detect GNU and LLVM ld implementations. This is required for further
patches that will introduce diverging behaviour depending on the
linker implementation in use.

Note that LLVM ld returns "compatible with GNU linkers" as part of the
version string, so be on the safe side and use '^' to only match at
the start of the line in case LLVM ever decides to change the text to
use "compatible with GNU ld" instead.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Michal Orzel <michal.orzel@arm.com>
---
This was discussed with Jan in:

https://lore.kernel.org/xen-devel/fbe0e0f0-85dd-434b-aca5-fa513b720c0b@suse.com/

While he would be fine to use the option if it was present, he isn't
convinced tools capabilities should be recorded in Kconfig, and hence
doesn't want to introduce the option himself (I hope I got this worded
right).
---
 xen/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/xen/Kconfig b/xen/Kconfig
index ec2bd9fbcf..134e6e68ad 100644
--- a/xen/Kconfig
+++ b/xen/Kconfig
@@ -23,6 +23,12 @@ config CLANG_VERSION
 	int
 	default $(shell,$(srctree)/scripts/clang-version.sh $(CC))
 
+config LD_IS_GNU
+	def_bool $(success,$(LD) --version | head -n 1 | grep -q "^GNU ld")
+
+config LD_IS_LLVM
+	def_bool $(success,$(LD) --version | head -n 1 | grep -q "^LLD")
+
 # -fvisibility=hidden reduces -fpic cost, if it's available
 config CC_HAS_VISIBILITY_ATTRIBUTE
 	def_bool $(cc-option,-fvisibility=hidden)
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:37:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:37:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317071.536224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN3k-0005e1-98; Fri, 29 Apr 2022 09:37:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317071.536224; Fri, 29 Apr 2022 09:37:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN3k-0005du-46; Fri, 29 Apr 2022 09:37:08 +0000
Received: by outflank-mailman (input) for mailman id 317071;
 Fri, 29 Apr 2022 09:37:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkN3i-0005do-Jq
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:37:06 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ed1c12c3-c79f-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 11:37:05 +0200 (CEST)
Received: from mail-sn1anam02lp2047.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 05:37:02 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM6PR03MB4825.namprd03.prod.outlook.com (2603:10b6:5:187::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr
 2022 09:36:59 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 09:36:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed1c12c3-c79f-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651225024;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=Rop4v5R40LGeUzCkE8sILGrwn1lXGmJdPUUUxOkBq90=;
  b=Y1zvaa15Obj5LgGdHBe9bcnh2s8SKwZRqeOg/JnDN4l2pQjU5PAYuVRZ
   yPzczcrmbSyrpxf8pzkMSFk3NZy+wCMmQ136yWhWB5C3P7//s0bKNfT/e
   od2XHwxUMZqdsEmMIf7oLfqsO4KN11fMZX8REFNAfyByrST3xsAwVRjvD
   A=;
X-IronPort-RemoteIP: 104.47.57.47
X-IronPort-MID: 70238441
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:H4ItIatledGlUf7Lbhf3+Aq66+fnVEpfMUV32f8akzHdYApBsoF/q
 tZmKTrTbKuCYWD2L9pya4nn/BkD6JTVmtRhHlQ/+Hg3FHsU+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW1/X6
 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8QfY6Xw/tHQyBmKH93J/IcwI39ISmw5Jn7I03uKxMAwt1IJWRuZ8gj3L8yBmtDs
 /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IHmmtv7ixNNa+2i
 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wrP/vprvzG7IApZybK2KsP3XMCwfcBvgn2Ar
 WTEpkTkHURPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BVJ
 lEQ+yEuhbMv70HtRd74NzW6vXqFsxg0S9dWVeog52ml0bHI6gyUAmwFSD9pa9E8ssIyAzsw2
 TehgNfBFTFp9rqPRhqgGqy8qDqzPW0OKzYLYyYBFVEB+4O7/N51iQ/TRNF+FqLzlsfyBTz73
 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A==
IronPort-HdrOrdr: A9a23:qAkMnqD5WOrc4THlHegxsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ++xoX5PwOU80lKQFmLX5WI3PYOCIghrNEGgP1+vfKl7balDDH5BmpM
 BdmsFFYbWfbGSS5fyKmjVQeOxQpeVvnprY5ts3mBxWPHpXguxbnnFEIzfeNnczaBhNBJI/Gp
 bZzs1bpwC4cXBSSsigHHEKU8XKutWOzfvdEFY7Li9izDPLoSKj6bb8HRTd9hACUwlXybNn1W
 TeiQT26oiqrvn+4B7B0G346YhQhbLau5J+Lf3JrvJQBiTniw6uaogkc7qevAotqOXq01oumM
 mkmWZUAyzeg0mhD12dkF/I4U3NwTwu43jtxRuzmn34u/H0Qzo8Fo5omZ9ZWgGx0TttgPhMlI
 Zwm06JvZteCh3N2A7n4cLTah1snk2o5VI/jO8oiWBFW4d2Us4dkWUmxjIaLH48JlO61Gh+e9
 MeTP00pcwmO29yVkqp8VWGm7eXLzcO9hTveDlxhiXa6UkVoJlD9Tpm+CUupAZ9yHsDceg72w
 29CNUPqFhvdL5jUUsvPpZ3fSOIYla9MS7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.91,297,1647316800"; 
   d="scan'208";a="70238441"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ITQXWxpe0ImC3GChbfaXl7/lB2XfWAOQ3N40ArVPEPrnlrzw0H5puQOj1nbmYZIPaeTVwO+LotZ9WborQq4BHUDmpP2kHuE09u5vdF2xebBsL9iV5iWJ7/XVgcS2iRQ48V9kRT26cdSa1zsFugNI4Nbv1ctCkzlpscXrEfKBOOQPrTqVLnzSv956IqQUgNlADXQd6MfYgv2lqkDH5OoUgELBNzuwvcUYa68AIg+NhgzfMrnF9/y+exhRZtHmnO9rm6nRSdwsfF8cYniNFqBgB1cS0GJQQtn3hBFsZiMrvhGP0FE2+i8+xM7E8VxjzE/5EIgPCTSsntYkK1ZAKIV1wA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=L930wC+Zn/2IbXAp8S80W4g1JAnY9tSi/j7OYIXn7tA=;
 b=RRyIBPAglkhFs2vWbF+TemvKWRFaYY1z6a4s+y/cxaTeOLFqXK1mWyp8J00octoh5LUguUUOJV/+7m1Ji1UTaOZvTtARn3j3qQpBMIpFGZudsKusQb7GzAbFkhN0NiBuixMb7TDvz4YbOknig1+CA1knebEOJkTBUPhu1CA/qOam54LIh0aNxho8Xt4avFlUesGH2XUmnIwBf6jAYFbszQfLz/l7YsYFUfgpjcwnQQajQ+bBNB29JjcfY1Sp92/PYWGM72SYRn1ort0GjT5x+MqGSqoLK62qiEe+UcGescA5E0oG5OBabhxkJaaj6nmRO1qP5USuHIqNQ9j4MvIEkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=L930wC+Zn/2IbXAp8S80W4g1JAnY9tSi/j7OYIXn7tA=;
 b=OMafc+poJSof5ACOZI/4UJiiw7qv8hcEa0eblkOXca8GQqGdMTYswFNc8ZQWpOD6TzjIIRAOcOveTOBk5iq1uX8wi+8YFNdvJ/F7z16PyBRg19TqVO5Kjj9Is5WzFCgsWVo3IX9s2rFO1sKTOagKfs0XyRaqWn/nQ7Wh+7w47pQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 0/2] linker: fix build with LLVM LD
Date: Fri, 29 Apr 2022 11:36:42 +0200
Message-Id: <20220429093644.99574-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR1P264CA0043.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 710ed1b9-a2a4-4e5c-6e1a-08da29c3cf17
X-MS-TrafficTypeDiagnostic: DM6PR03MB4825:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<DM6PR03MB4825914A9B66C92F08CC30508FFC9@DM6PR03MB4825.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DwssLMqMXkl5/PpPawZpCJMt1yPX656IOMbSZTFkxHvY96VirEgQBU7O9g74QdU9eM0q9TYt3okLMWnxsww51DlIznG4eNYOKjxorGZu/+Pr2+ggX+1KvtkYJyZ+EshcQwc9u2LvhHE7PsX24icKlX1kwu5J5U25/zF3ERVVKMxI+N7bV9lEfocHeKqtjF7FygZmrw8oD17Ngy/DduRq3tSpPf23nocGRTR0YO8CQXEh1loD+2yp6OX2020QCOxcVYuz4ydDBspxF2mHQ/HPAVrr05Ne09yzguALkyorHPqwf1h+ZWutMZKn07vf4ktszOf8g2jOUFK1faL+CmQhmoyi0CBpcs/DjGvIjaaCyX+s9i/jH68JzP4li6/GuubNMdV2qqtDjB0K54i0xb8LHPNGQdzdzkmmSHVoapyj+hk+V815HAYBxBNoLYfQBBeWBPB3Fa7SAKNoIF4yxbXgrb6yGCCsj4raT4AKXrKM7BYDhyF42nHZ7pVNUMqbuiKJgW6dajDLgexl/3zdACfZax5tFqI2NnjC9C/dNYL9Z4DLlBOBl4VjsHOe4aqSGdcCmwgp6HoIHpo+/btU5Eaz07ygIhEPj3Mu5DcaeZVj7y2RoUjHeZoFpibne+UWTPEkGeRrQ0Pi3iv0D68+pSpwvQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(6916009)(508600001)(8936002)(36756003)(66476007)(4326008)(8676002)(66946007)(316002)(82960400001)(54906003)(66556008)(26005)(2616005)(6512007)(6666004)(2906002)(1076003)(6506007)(6486002)(186003)(83380400001)(4744005)(86362001)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VkhzUFVHTkRaVFNqMkVPNFlvdGVrMnk2TmROSzBPMnFxdlR4Zkp4Q1VzdGpC?=
 =?utf-8?B?cE5ZZmZIOW0xV0Zrd2RtT1lOWW9sWlNIaDN1b0JIOGFNUFVIVFVYelhUdmhv?=
 =?utf-8?B?YSt4V1czNWQyRjlDclNyb2FoYUZBTFhxZ1FoVEhucnI0cGwrVDUrZE96Nnoz?=
 =?utf-8?B?WldYL2Q1azhsbU9UOHpRWGlnMEJQNmVZOWdTeDlpRHdoSlhWR3F6aHZEZzAz?=
 =?utf-8?B?Nlk3QWRuUmwvMlR4U3dqN1RYREE0eGYrc3lTdnM1NTQ0a1dIMzNTN1JLbksr?=
 =?utf-8?B?UE1CblBMQmVybDJHb3FTWnhyaWxoZ09Yb1h0czN6TmlCR0hhWlRwMExrQ1B0?=
 =?utf-8?B?aTJLaEhISTZyaDBtQjJmOWI3ZTQ0WG5uTjg3ZkY1U3R3bWlLMDNRdFhVdnJu?=
 =?utf-8?B?UUUwait0NUpUYTVSR2ladkpqOXVwV2YrRy9JZnd6UGR0Z0ZyZGpOdHdzbmRV?=
 =?utf-8?B?WnNtTDkvSWJIaFlxYUgyeEEwdWE1WWdJYTAyTlZMMGI5VGM4WWxBakVHR0JC?=
 =?utf-8?B?b3dBYTFKcjEyWmc2TWRlZGxidWhPYW1ZbnNQTjZQTVlhSENiOHRjUWplNUpW?=
 =?utf-8?B?SE5YVDc4YlMraHhpZmpEa2grR1d0NU1SNWpkRllvY1BaamtsRVZ2OEhRTFJi?=
 =?utf-8?B?QkUzdG1ZSGdxWWRtRTJqSkRoV0JDbzFVQVRUOVRTc0NKT3J5N2tlcVhLMVo3?=
 =?utf-8?B?NlJoQzRBVEpZSDZhLzdyb1dLN1gveXZVMnVRRW4xd0w0dFk5MCtzNEJ5aU90?=
 =?utf-8?B?cnVKT0gvdFI4bHhSVTkvL293NFM2L1lxNFZqd2lDNFM2SmhBWXU2ZldKRXVR?=
 =?utf-8?B?MmJrN2ZQYnZtNGZRa3ZGNkgwRHRvbmVwNUNmd283b3dtTDgwQUpyMkVTZ2FI?=
 =?utf-8?B?MDhiZlliWmJDSjF5R0NreTNHQ0ZsVlNybWFSRWRQcUhFZHVMeXZPVzlzZmZZ?=
 =?utf-8?B?Z1hxYSs3bVhlMUlJYVNQU3lEcEFta1ZXV1BodHZHOUJZMkhjaHZZVlJHQTM0?=
 =?utf-8?B?aWJZN21kbGJtN1g0TXA0dmxEVGlkTVdkOXhYdUljVk1vWU1OelRQVW9Xa1NT?=
 =?utf-8?B?djVsZGt6bUEzYWgrbTdNdXNZYzN5OXZoSDhpaFhPeE1YSi9PYitDYUVBc0Nw?=
 =?utf-8?B?T2taU2xMRDU2Z1U0a0VsSUcvNXJ2V0xLZy96R1I2ZkRMQ0dXZnJncW1mTFla?=
 =?utf-8?B?ZkI5NVdKMGZTdFNaSm1xcVZSWkZvSzNpVXFuWUF1MnRTbUVBR2dqbDNkZlVo?=
 =?utf-8?B?OVAxM2lVVXFuMys5MmN0YlErMTYxTzRLejZ6L1JzTjJvVTJDUHBxQ21qTmRY?=
 =?utf-8?B?Mmw5UXRZNUFQUmp0RXlTNW55eFZzdnpOZDdWdHNsbGZYeC9FTER4ZWVJRVJu?=
 =?utf-8?B?Zmg2NDBzemZNTHlGcjVid0hycjN1UzZvUUMrVlh2Z0RiVTFDZ3NBQlhDbk50?=
 =?utf-8?B?ZVFnTVpzOExieU1oUytWT1pzTk1yN0o5N2s2M3c1YjF3d0tOR0ZJRjdYWG02?=
 =?utf-8?B?ZUJzdzhnREh1d0FyenZJTHVEdWt0RzRucVJCOHFyNWZjWE9ZdGlrcitaaE1P?=
 =?utf-8?B?a3R4a1lxc1I0d050UFA1MnovQnFSZHplNWVSRXNxSW5od0xTVEhqYmNGRUs0?=
 =?utf-8?B?ZUtKZ1hvbm4xa3JCR2VHQ2VHNm5oU1htdExRdlVFYVhOTE56TStieURXNDg0?=
 =?utf-8?B?ZmNEYU0zUmRhSDRYdTd0aEl3VUFBWVgwdzZBZzhiWEowOS8rQkZtdktsSkpa?=
 =?utf-8?B?ZG5MY1dvYWdpRXRORlNOU3RSVEc0L3FtTUY1dmJnOUtRSW54MzdJeEp2UUVP?=
 =?utf-8?B?Kzc5Yms4ZFFuUXpra3BYcmRaeURmYkdMNG1uU3dLWjZRSTNXeXFXUThGVE1Y?=
 =?utf-8?B?YStuUk5UNTNXVXA2YTl6bWpDbm5hM3E3djUydzlPOXJmZFdyTWFkY09OT3F1?=
 =?utf-8?B?ei9SOExNNFlibjRUQVEva3ZPeVg2bHVRUGFyQ09pZHdLdmNhSHVjeFRnT3JG?=
 =?utf-8?B?ejJVMGhyR2gwYi9GWDVSM2Q1azlBeEIyOE44QmhTV1cwclg1NjI1ZUVSa1B2?=
 =?utf-8?B?bk9JYm50dlBMM3ZNUzVlUmxRUlptSi9tNm1EMlJ6bEVtbE5Ob2t1b1NXWE83?=
 =?utf-8?B?UEsyNFY3Z2Y3NmFzeGs5SW9IQThWNWlmdDBIS0R0dDVxZDBXQnVMZDFpYmtE?=
 =?utf-8?B?d1hyR3BhQVZuajhQQ2F5ak51d09ieVNkVktPTW1JMjhqblM3Z3lzYmk1UFFo?=
 =?utf-8?B?WlMwNzdERFhNTldwNHV1dzhTZ0dFSGJ6NVNHUEtJT29ybldmbGowOUdaVmNu?=
 =?utf-8?B?Y09LYWJtbFdUMTlPYjB1b1BkTXRFbDNyUTE3dnJOUEJza09RdW9FUEtxZklv?=
 =?utf-8?Q?cTuCZMM7BmvKYfx0=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 710ed1b9-a2a4-4e5c-6e1a-08da29c3cf17
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 09:36:59.6921
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s3vntZj3fEEx8byB0TIzeG6ZMbQTWwDwqPYhhCpXi6ipT2NOb6HPSloE91nhw2lo7SC7ISw9WPA47O1HniCEsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4825

Hello,

LLVM LD doesn't remove quotes from sections names, and thus the
resulting binary cannot be parsed by some tools due to the quoted
sections names.

First patch has already been posted independently and got not enough
Acks/RB, second patch depends on the first one and is the actual fix for
the issue.

Thanks, Roger.

Roger Pau Monne (2):
  kconfig: detect LD implementation
  linker/lld: do not generate quoted section names

 xen/Kconfig               | 6 ++++++
 xen/arch/x86/xen.lds.S    | 6 +++++-
 xen/include/xen/xen.lds.h | 8 ++++----
 3 files changed, 15 insertions(+), 5 deletions(-)

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:37:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:37:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317073.536246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN3q-0006DB-UP; Fri, 29 Apr 2022 09:37:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317073.536246; Fri, 29 Apr 2022 09:37:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN3q-0006D0-Qc; Fri, 29 Apr 2022 09:37:14 +0000
Received: by outflank-mailman (input) for mailman id 317073;
 Fri, 29 Apr 2022 09:37:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkN3p-0005tt-Vq
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:37:14 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed10e22e-c79f-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 11:37:04 +0200 (CEST)
Received: from mail-sn1anam02lp2044.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 05:37:10 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM6PR03MB4825.namprd03.prod.outlook.com (2603:10b6:5:187::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr
 2022 09:37:09 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 09:37:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed10e22e-c79f-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651225032;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=TvmAqsUTGDPD43B73PPYjQV948fkcZfmfIipPMxthuY=;
  b=XCDm0mqG+YruCRLzS/ufAVnT/8Q30BZfomWsKJRW2zsM//iE5QrmguKh
   LlLIEEnjwaGFUE76Wl+XGxvL+BGhrHEKO74bjlCp4gwXprGNniI1dqyrF
   k1RUNsNMN673v2/z/5lrkwfVBbwpZhlPQ6fxp3vcXgH+YalWVr5aBba28
   Q=;
X-IronPort-RemoteIP: 104.47.57.44
X-IronPort-MID: 70238449
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:KHuZ46Kje+VUgiYoFE+RzZQlxSXFcZb7ZxGr2PjKsXjdYENS1D1Rn
 WBODDjUbPaKMzD8c9x2b9/g9kMEsJPRn4JjHAZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh3tQ52YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NlA5JLhDkQIBIySxrQiDyRaQg9SIJQTrdcrIVDn2SCS52vvViO2hs5IVQQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM+FH/miCdxwhV/cguhUGvnTf
 YwBYCdHZxXceRxffFwQDfrSmc/33iOkI2EE+Tp5o4I7xDP24RQs9IP/OYrzQN2ARcZ+lFqh8
 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1a3FOvZsnwWVu/unHslhwBX9tdFcUq5QfLzbDbiy6CHXQNRDNFbN0gtec1SCYs2
 1vPmMnmbQGDq5WQQHOZs6yS9Dq0MC1Nd2saP3dYEU0C/sXpp5w1glTXVNF/HaWpj9rzXzbt3
 zSNqyt4jLIW5SIW65iGEZn8q2rEjvD0osQdv207gkrNAttFWbOY
IronPort-HdrOrdr: A9a23:VzXUkK0S3R65vHD6tNsk7AqjBTtyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8O3WBxB8bYYOCCggeVxe5ZnO/fKlHbexEWs9QtrJ
 uIEJIOd+EYc2IK6voSiTPQe7hA/DDEytHRuQ639QYQcegAUdAE0+4WMHf5LqUgLzM2eKbRWa
 DsrvZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolCs2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REIGqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUETA9OL8y7qvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wM9HdwGOt15Dt
 //Q9VVfYF1P7ErhJ1GdZc8qLOMewrwqDL3QRSvyAfcZeg600ykke+E3JwFoMeXRbcv8Lwe3L
 z8bXIwjx9GR6upM7zC4KF2
X-IronPort-AV: E=Sophos;i="5.91,297,1647316800"; 
   d="scan'208";a="70238449"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N6AZhgU6YyzcKRZs+OGU9iRXWeJPhkxyTdMjGfAzcV3x+O1ZXxV1kvRw0pZsc3gmOu3hGfSq7s5WBfmS7K8wX/aKw+LJUEli6l+7ZJ1okzUAAOXH9zd7rzdtEg7/J50JUtP5oJdL6I1E3Qzr+TDPdQj0KAve49BrX982PKarySkp1k6coNMEmnBmDAthRECaAzfA6bbSccTqEj0JneFrNBbVufr3BEd6YTAMdWXbqDqgxThpHxZskdn4VIWWaRpqFAmNp58iIAhsNtq/e8S3RJ4zCeyH60CNEEeiIvob6o/8LL8BbQKiCIKsnQzXx4oqvaaYkfq+jvZ8vf0uj1axpw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ym6N3M5LNo8FbySG9wQ5XDzt5zU2d2LaWp3GmRtJ71I=;
 b=DtaiZDXcmZJRN72T90Cwlx6QPaLXuYIwKkOHpuVjQUIN/R+GE97PvOt8VYcvBlBeR7VS7e8sgo7ZLrB0vvn+4zisGW3vxQ/VddpZmZxRbj0uy5rdgJjBJzvsLcpsshLw6FJoNJd4t2aALG7D4J+RaTH0IIRHkDpgwBfTJw8xeBa57W4qfasmu90Host2swV+/deNSSJTbXtQeB54NnWn4/ZGQ2+mOb3fLLkcAtez22iVobKkTusCgbZE8lRndyWuiztXwEQSkO1+uSxoGOYtP8wM3cqvh+G+lPGzlwBhh2oa+XPUZwO29hqb5Z02/CEZIl12efm17Cx4dIDVrX64yA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ym6N3M5LNo8FbySG9wQ5XDzt5zU2d2LaWp3GmRtJ71I=;
 b=c/ED5V8nC1aRxjjey5JgtBtfZF8AfwlzIX7buUADnGXT6zJ/Q0Gnvlon/yCup77V7gtdbhnfzesrHQLvnVVN1W1pcLFxE55hNKyY3tbp6RfcJNa+gCexzyMw+P6HQ9qFVC127pJMPuCL9bmV7RTkKe+/wPY8s+fsi0GyU2sQiyw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 2/2] linker/lld: do not generate quoted section names
Date: Fri, 29 Apr 2022 11:36:44 +0200
Message-Id: <20220429093644.99574-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220429093644.99574-1-roger.pau@citrix.com>
References: <20220429093644.99574-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0171.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::10)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a660e286-a746-4674-7e81-08da29c3d4b7
X-MS-TrafficTypeDiagnostic: DM6PR03MB4825:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<DM6PR03MB482504A9075E17B216DFBC398FFC9@DM6PR03MB4825.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t7U7xp2AOme4nHG1QWw7SdMZgr/4CR0kFhhBmJPFD3ukq/ouuOhW6gJSC2s+AkxEOEZnzD44AItvW/WVOQcIArUFWe2qrdZPTNlS2vWCH6J3ZIbst6uqlAAS+9h5ToIi3oH/situsS3C1X7jRFemCp9TQ2kCKwGdlEquQK6igFz6qqsr8pc6fI3JLfj1gnzZF1/BCbpZp8NV7QxxL4PupJYb15hJz+M9H1h+q+aZOJdg4ql25S+hk6lsFrHuO066jYNmjApmdZ2XyIOUCzQEgOIexmHRmww27FFxqGV0P++jcJSBDTCBXp4uUrR7m8jVCH7+At3Q8AvEfUoUJi38V/fSUTJn72fZQ0zrQRbqf2N7WkrAl7FTjLWoZ7amDgHSV4nDmhLSlfspcpnw69KNLOizFjH2hvSTOcpyDLVu3F63shTtYyEIEg1B691O4gK7lJ3Zet9giONsNOhFr/v1DpNHlbBXJ5Z46+kij4bZkSExptDvv7FOsTWGnuB7DVwux/+ApsPUUNzgyoYcQVFlfNmLOQecLjY8S+bcicWK1MYYmTSt4Q5HjHxZpDO9IPszi2Py6s9APUXeaFh37OymcWtAomFx18xBsRoPLklVrW+RYvsh622juBtyM4NX0q2t6fsRGyOW+jjEaTPPXAB/tCEgZ2ArnRU3XqkdndexFW/YAQ7POPmN+MD9RHcQhYKfNfsZCGC06jPGdiZ10K2fZlb6DWNBnOpPs36P4K5HTNg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(6916009)(508600001)(8936002)(36756003)(66476007)(4326008)(8676002)(66946007)(316002)(82960400001)(54906003)(66556008)(26005)(2616005)(6512007)(6666004)(2906002)(1076003)(6506007)(966005)(6486002)(186003)(83380400001)(86362001)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VEhJSUxUV01rVnRTcXAvYzVzejUvODRSRFUwdFZPUzBJS05PTndtcUswSTNQ?=
 =?utf-8?B?Q2hGejhIL3hqTHQ1UThaM1ZQSW84K3l0bjREKzJNRGY5VCtlaS9PVzBjK2p3?=
 =?utf-8?B?R2IyWk10Nm9XZ0xYZHZUNk45ZSt2cStVNkpSNWNOQXNkODlPMm50aFRWT0xE?=
 =?utf-8?B?N2ZNa1p6SmVqTXFsbUF1NFZSb1FYSURDeU5ZTzFVOXNPcGU2b2E1RGxzZm81?=
 =?utf-8?B?Y05wYTh5bDVaV294QXEyNnlkVHBuQTFjNmdPSFllRm9xdnFWR3gvQWlramhE?=
 =?utf-8?B?eVVVWi9FZ3RwM0s1bjM2SUgvU3JBMzdqMGVZdUg2OU1QVmhTR2xaMjlTRG5J?=
 =?utf-8?B?azhDY3RmNjRTY3pBdEtWTEMvVlBIU0ViR3BzYWFKdzhOTXpicjFKMTVqcmpo?=
 =?utf-8?B?TVlHTjRRSE92SkNmTW05YkFHTnNNajZLV0tUb0dJc1VOUHE5MEpzeFFTYVNr?=
 =?utf-8?B?ZGZGYkhpZnhQVUhvMUQ4YVljSjJOWldxZGZudmF0YVE3TEFjdkhWS0s5ZGJN?=
 =?utf-8?B?U0JYZVhmSEtIT1NVM3luQXBielJGdEJNU1h0bG9vcW05V3JlN1VoWDJ0L0ZB?=
 =?utf-8?B?SjhBeFlQQUR6RldHU2tUc3JITkNtSWYwWWs2QytZTGhzRE5wWWNzOEtEZGJp?=
 =?utf-8?B?NVovOUkvS0FrK0ZNdGcwUDF1aHp0WUh1MGpzM1g2YWNIb25ZVlBRUG5zQ3Rj?=
 =?utf-8?B?cHdFTUZDMmJ6YW9hOG9tdE9NdlBIaHBwRVpNVXhhMnlzdkhObkhIWFQ3dWpr?=
 =?utf-8?B?UU5oaCtEM1M3ZTZWOFhXbytKeDFZRmNncTY4S2UvcUFtNlkxSy9hOExPVHo2?=
 =?utf-8?B?WTB0Sm9lYmgxYTNJcWNMdXAwOWpYS0pWMVZobDNKc0Y2QWpRUjRQbWNPQTVG?=
 =?utf-8?B?eldLQzArdW52M2hWTHFsWTJIYm1jSytRVzlWSHlEOTExVnhrQ3RWU3k3d21O?=
 =?utf-8?B?Y1laeUVDdmpuVmNTSkxORXhLcHBMN1hLdkNncVdYZUZ3QkFtYlpZR20xS0dh?=
 =?utf-8?B?Um0yNFIxQzdSemY5VHBlU2p3Tmp1THYxS2Njam5lRGplRUlNTHZmeUJoMGd0?=
 =?utf-8?B?Vk0yMk92NTBCazI3NlB3YVIzYm02cEJnNTNVVjhkOVg1STVxZkdOTEFvYUFZ?=
 =?utf-8?B?QkxPbkVxSWh6dmhiN1FPZFk2UGdrNndtZFdEREdIWW1rcHZuejBTTk83MVZj?=
 =?utf-8?B?L3pzRTBONVY4bno3RXh4bVV1bldCYmYreU0wa3pPU1gyWHA5TVJ6N1JRcklQ?=
 =?utf-8?B?clBYVGs4eTg2YzVPcDNhTk91NTBGK3I1MysvVXNuTUtoR2NMY0Y3NWhRZ1lr?=
 =?utf-8?B?aUxyR2FMYUVaV3VNMDY5dDR6RHc2NDlWUyswMXV4bjFRcjd3QW9HU3o2UnBQ?=
 =?utf-8?B?ZGdCN05NdWtDY0dWUXllRzZEbmVjd0E4aTQvK1I4dXpIWlJ6bzZlYVBXdXBY?=
 =?utf-8?B?MFRpdDBiaWZ5cGYzTnN1elRHMXUyU1lXTlhLenE5MGM4RjFqWWdpTlR0MkUv?=
 =?utf-8?B?eW9Yb1VrMEk5cmJtSDVYcVZRYU9BTWlIVWYxOUJWYm02NmdyT2FWSVFXQmpV?=
 =?utf-8?B?c01yM3htWDNxU0V1OWtheUJEcUNFbXRVcDdVODRaMU1VUThDZHVlQ2ptZWFk?=
 =?utf-8?B?VjU3cGJrL09KQ3lLZFRtZGtmZHMxTThoNFlYbTYzeEJpaU1jUk1pempQVlRv?=
 =?utf-8?B?UE5zQzhoOW1MVUp1dzRvd3dMUlVSY2FzM0xBbXFlcGFYYjQ1R2NpYzlNWjla?=
 =?utf-8?B?Uzc0TTFzSHo4Tmd6UDU4UGgzMGZrR3hOWnJ0V0J5ZHZVSE4vbmE4YkJjSzZ0?=
 =?utf-8?B?ejRiUFRralI0ZStzSUo2MXF0cm5ibXg3bFU3UERMWXh2ZGFWNlJrK3pWVmpm?=
 =?utf-8?B?bUdFTG1SZmxyL3Jva0F6UGlqN3RPeTJNdWx3bXFvZTJsNE5ISkZkZ2xESzd3?=
 =?utf-8?B?d0RZeUNmak8ramxKMTRlYkpoS2R5R3gwZHBpVnRWUkdJb21KOU9Nd3lXSjgy?=
 =?utf-8?B?WHZOZ3A1NUNvb29TREs0bDRsOFlya1FMSCtuRXFuOWlNbGdDQWxlZXFhWW5B?=
 =?utf-8?B?S3ljRHNWT3dZU0pyZllvaFFYVkpzaTlxMnMvRjQ2UmYvU1dMdVFONkVndU0x?=
 =?utf-8?B?L2VPT25PaUVjeEc5eFY2b3NoeWhKM2ZDTlgwYmN3SFFlTHhCZDFENzVXYjBr?=
 =?utf-8?B?czdwL2dsVTBidjdlYndEdmxMb04xZUkremtFSFJOc0hpMHVOaXBGS1Y2RzU4?=
 =?utf-8?B?ZC95LzhhazJwL2JGWHQyTG83cFdPWmNYdjQ3YndOejJTTTQ3R1pzdjZBWWhn?=
 =?utf-8?B?UkJTTHpaYnUydmRxcU5MWGxod0dBZmk5a3Nkam9Pc2hvVGI1UXBSZUcvamdT?=
 =?utf-8?Q?tYIai0bZpDbusvvA=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a660e286-a746-4674-7e81-08da29c3d4b7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 09:37:09.2377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ltEPECmoFMr/xXWpJpXTTgtz/enXC1V9E5eilleDZGBPYGuKQ6whCQ0/DeRfLzGQ186zJjgOdNpB+Le1kpo75A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4825

LLVM LD doesn't strip the quotes from the section names, and so the
resulting binary ends up with section names like:

  [ 1] ".text"           PROGBITS         ffff82d040200000  00008000
       000000000018cbc1  0000000000000000  AX       0     0     4096

This confuses some tools (like gdb) and prevents proper parsing of the
binary.

The issue has already been reported and is being fixed in LLD.  In
order to workaround this issue and keep the GNU ld support define
different DECL_SECTION macros depending on the used ld
implementation.

Drop the quotes from the definitions of the debug sections in
DECL_DEBUG{2}, as those quotes are not required for GNU ld either.

Fixes: 6254920587c3 ('x86: quote section names when defining them in linker script')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Reference to the patch for LLD:
https://reviews.llvm.org/D124266
---
 xen/arch/x86/xen.lds.S    | 6 +++++-
 xen/include/xen/xen.lds.h | 8 ++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 6e4abbc1ce..d94915ea7d 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -20,7 +20,11 @@ ENTRY(efi_start)
 #else /* !EFI */
 
 #define FORMAT "elf64-x86-64"
-#define DECL_SECTION(x) #x : AT(ADDR(#x) - __XEN_VIRT_START)
+#ifdef CONFIG_LD_IS_GNU
+# define DECL_SECTION(x) x : AT(ADDR(#x) - __XEN_VIRT_START)
+#else
+# define DECL_SECTION(x) x : AT(ADDR(x) - __XEN_VIRT_START)
+#endif
 
 ENTRY(start_pa)
 
diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h
index fc47bb1ccc..06b7110837 100644
--- a/xen/include/xen/xen.lds.h
+++ b/xen/include/xen/xen.lds.h
@@ -18,11 +18,11 @@
  * for PE output, in order to record that we'd prefer these sections to not
  * be loaded into memory.
  */
-#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) }
-#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) }
+#define DECL_DEBUG(x, a) x ALIGN(a) (NOLOAD) : { *(x) }
+#define DECL_DEBUG2(x, y, a) x ALIGN(a) (NOLOAD) : { *(x) *(y) }
 #else
-#define DECL_DEBUG(x, a) #x 0 : { *(x) }
-#define DECL_DEBUG2(x, y, a) #x 0 : { *(x) *(y) }
+#define DECL_DEBUG(x, a) x 0 : { *(x) }
+#define DECL_DEBUG2(x, y, a) x 0 : { *(x) *(y) }
 #endif
 
 /*
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:39:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:39:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317090.536256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN6M-0007SX-CI; Fri, 29 Apr 2022 09:39:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317090.536256; Fri, 29 Apr 2022 09:39:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN6M-0007SQ-9Q; Fri, 29 Apr 2022 09:39:50 +0000
Received: by outflank-mailman (input) for mailman id 317090;
 Fri, 29 Apr 2022 09:39:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xZxz=VH=citrix.com=prvs=111f028e5=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nkN6K-0007SI-SA
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:39:48 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 48bce012-c7a0-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 11:39:39 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48bce012-c7a0-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651225187;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Qx15oLQAIXPIdeDCoSNYEx2nHBETrR/0j/6F2fxLnUg=;
  b=I8ugoRzR6LH9i2pk48WzSfGGYeBxkJ3i6ur8ZLzsw3ZrivTxL2/3q1aM
   3NKKSUQHXYTMq1bD3+tT3njnoMshA96CVy9SK114uXWWz5SNgZ6DQPl16
   T4Ui+WRK3gBm8MSL4mXVIyqrq793jUm4QL/bCpklrNKpUvbLB+efNr39D
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70623567
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MTDrL6qzqn5F3Vx/BHhkLg9e/ZxeBmJkZRIvgKrLsJaIsI4StFCzt
 garIBmFPayLY2D0KN5wbIjn8kIFuJWHn9EyHgJtqXg2QngX9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvR4
 4Kq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBHKncx+dGXkZhCiR5Pb9gxLiafnehiJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY
 qL1bBIwNEqaOEARZT/7DrocoNm2qF2ibwdGl1GbuvQK01X8/Cp+he2F3N39JYXRGJQ9clyjj
 n3C13T0BFcdLtP34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTrPm0jw2uVtR3L
 hEMvCEpqMAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l6K7EvAXCCzc9VztGaM4AiMhrGjM07
 wrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6
 2rSxBXSkYn/miLiO0+T2VncywyhqZHSJuLezlWGBzn1hu+ViWPMWmBJ1bQ5xasYRGp6ZgPY1
 JThpyR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeR4wapxdIGSzO
 RK7VeZtCHl7ZSrCgUhfOd/ZNijX5fK4SYSNug78M7KinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lurUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWP3eHrNZPfQxbRZX5bLivw/Fqmie4ClIOMAkc5zX5mOpJl1BN90iNqtr1w
 w==
IronPort-HdrOrdr: A9a23:EVz1BakhcloPqgbXspYuotM4LNzpDfIs3DAbv31ZSRFFG/Fxl6
 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79
 YCT0EXMqyXMbEQt6fHCWeDfOod/A==
X-IronPort-AV: E=Sophos;i="5.91,297,1647316800"; 
   d="scan'208";a="70623567"
Date: Fri, 29 Apr 2022 10:39:27 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] tools/xl: Sort create command options
Message-ID: <YmuyT0/8Mfa0eM1b@perard.uk.xensource.com>
References: <cover.1650422517.git.ehem+xen@m5p.com>
 <c145a7648025e9bbc2f47ab8bd5839c80c01933f.1650422518.git.ehem+xen@m5p.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c145a7648025e9bbc2f47ab8bd5839c80c01933f.1650422518.git.ehem+xen@m5p.com>

On Tue, Apr 19, 2022 at 06:56:03PM -0700, Elliott Mitchell wrote:
> Hopefully simplify future changes by sorting options lists for
> `xl create`.

I'm not sure that sorting options make changes easier, as it would mean
one has to make sure the new option is sorted as well ;-). But sorting
the options in the help message is probably useful; I've looked at a few
linux utilities and they tend to have them sorted so doing this for xl
create sound fine.

> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> ---
> diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
> index 435155a033..2ec4140258 100644
> --- a/tools/xl/xl_vmcontrol.c
> +++ b/tools/xl/xl_vmcontrol.c
> @@ -1169,13 +1169,13 @@ int main_create(int argc, char **argv)
>      int paused = 0, debug = 0, daemonize = 1, console_autoconnect = 0,
>          quiet = 0, monitor = 1, vnc = 0, vncautopass = 0, ignore_masks = 0;
>      int opt, rc;
> -    static struct option opts[] = {
> +    static const struct option opts[] = {

Could you add a note in the commit message that "opts" is now
const?

> +        {"defconfig", 1, 0, 'f'},
>          {"dryrun", 0, 0, 'n'},
> +        {"ignore-global-affinity-masks", 0, 0, 'i'},
>          {"quiet", 0, 0, 'q'},
> -        {"defconfig", 1, 0, 'f'},
>          {"vncviewer", 0, 0, 'V'},
>          {"vncviewer-autopass", 0, 0, 'A'},
> -        {"ignore-global-affinity-masks", 0, 0, 'i'},
>          COMMON_LONG_OPTS
>      };
>  
> @@ -1186,12 +1186,15 @@ int main_create(int argc, char **argv)
>          argc--; argv++;
>      }
>  
> -    SWITCH_FOREACH_OPT(opt, "Fnqf:pcdeVAi", opts, "create", 0) {
> -    case 'f':
> -        filename = optarg;
> +    SWITCH_FOREACH_OPT(opt, "Ffnq:AVcdeip", opts, "create", 0) {

The list of short options aren't really sorted here. Also -q doesn't
take an argument, but -f should keep requiring one.

Thanks,


-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:42:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:42:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317101.536268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN9I-0000WU-V1; Fri, 29 Apr 2022 09:42:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317101.536268; Fri, 29 Apr 2022 09:42:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkN9I-0000WN-Rm; Fri, 29 Apr 2022 09:42:52 +0000
Received: by outflank-mailman (input) for mailman id 317101;
 Fri, 29 Apr 2022 09:42:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkN9H-0000WE-Oi
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:42:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b700b560-c7a0-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 11:42:42 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-GRfyjdiXPDuNtnKq5JXlOQ-2; Fri, 29 Apr 2022 11:42:46 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR0402MB2871.eurprd04.prod.outlook.com (2603:10a6:4:99::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 09:42:45 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 09:42:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b700b560-c7a0-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651225370;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NqhyRjJEkBPZixM2EI5UcQI6uqOO1aQFKdxncf3UlWk=;
	b=UPEamEMW2TRMAq6BokXTUg/weC8Bv4RK4hgRO3mOuJsQYGQRZ3awUjcG1sxRpwQUALSwi6
	ELAFhMtiUn7+1yf8cAfmwv7iI88s+r2NK/q/7ysBnuKPdsed+dTS/xnZFQ8+Mw81SgnXx6
	8eGzgRLzTftRaoybfreFNJIJsbvBwZY=
X-MC-Unique: GRfyjdiXPDuNtnKq5JXlOQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WpRNnSK5Tx0uO60ynl1/3iXhbsigd0F8ySZFlmaqQcLOZSKAVtH09dqenLhQ0KKaTLKiihBdWoZ4Tu8JJ9+eQJJG4/TiNXM6/YBiJFWtsSMAoRfJb0v/VvIPgYNCBiN62eNrnG/OdT0Mti0BfWteGrr+HdIjYlmxl1+EHIUEBQJ/EZDNfobhWGuxXWyj0zhaUJDX/4ohZB0isoe5r9CAJE1dJo1LmRBe0rxRnRHtPA82bjhQPziLupUBPWyP2kg4fXGLr7WGRj5g+QsDbVuHAM2yb4mwbI5xJ6bPJQHgu4IWw6SiQFiBcRooBx6rdBEA3xgJ9LZCTQZVqzGQhNPF9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3n3bJocTB8QXinYCxVTEgtjyEaluQ1aFfAmH4tH+ccs=;
 b=RIqB2kpXWrjty6YinNW3y2/rfUIwku64N5ojZPJJEAyUxnKZIsd/xSOXIuP47IGDuR+almvB5IgGzLXpgYOsxZqTfq5+c+jnvLv9JVBJ6GMdQ5FofFREY7MBatbslf2auRWxrzkfpkHNHTZWFP0TBev3q/2Q1VVtN3YvmtjV5fOcYzJuSqy2Bo2rmEpAUfL5B8C7EwvQGH5LCVWeFDWuRFklQvZko7BGNt9MYwKSI01P9AnvdcOzXT/h1+Y9vbMKKTRIyImnWTWnth5hSVH4HRqzr+4QcbN7s502Nvct//YJp00KSVX6uBpSKDJpJyDuJkppvm93ejMEhWxgHd4u0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2308e187-0174-132b-0ad9-6025e4c43f3a@suse.com>
Date: Fri, 29 Apr 2022 11:42:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 2/2] linker/lld: do not generate quoted section names
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220429093644.99574-1-roger.pau@citrix.com>
 <20220429093644.99574-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220429093644.99574-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0098.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::39) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bb4a521b-24d6-496e-20df-08da29c49cec
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2871:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0402MB287148D0C0D9D4928B793F11B3FC9@DB6PR0402MB2871.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MuKOVHiu/e+3lvwjdbQBRv+yVDXWaaqsQbRDG03EioMX1XyM36S4/MuT17aRxeUYl3ZNXWyyh95YDGgJHGD0K1nvNnvl6T2kpANJVwfVYqdiFHJQPHw8Th05NNUQ6xDLWEhibBOxOzTKp1emNQyDHRRXWoiFSnzCyThBy3APvT+7soxvoYuZrT9P7SR+eSfVLKuBOwLo8xmKeBtExJaqawrA0r6a1Xx8QUq9XD9B6qSaepO/uB4Xfpc0aNA47ujbhOzVayvpUIr1aihBvzrxGMhA4jwdLJ5jWOdp9Rm7yysvsSWQPCyVfpXYlpLEQYFlbXo9nhnzrsOJ9RF72gzyfeeCr4Hk0OBfdOw/u3+BcvqbsPrssSJtKubJp+AenDGGFau4RVWCLlCBF0uSjsI0W3YLVhO71B1W7SNWlBfWT+bD3W6HclSvmotEZ4RlFcJiRtBMYPnDjxkan3YJ5yDrpLy7Kefd06ROekXDxZcpnu+jvL6FxvcbNxYtVzyZl3u6PNwhJ/XKCcyRtDlb5UgHZgHGALs8WrytgXnPF3n7RXlmsATWkuVPgpibnU8M52fv0dSmYuUbgM1BZisTjvMwXoESUCyp14Mq1zeIV7jx1sCFY/E8j4ZlLsEFnih35BTDkV0w2z46aQ9CvpF+b/7fl038jYzaVmyi0FgGrgRVaQ45aEUFcK1cxpuB/zyYaUAMrl4mhmBXoQNF2fs6X9k3q1z3VtbupNxJHVKCf9JzMus=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(186003)(83380400001)(86362001)(38100700002)(31696002)(4326008)(5660300002)(54906003)(36756003)(6916009)(316002)(4744005)(8936002)(8676002)(66556008)(66476007)(66946007)(2906002)(508600001)(6512007)(53546011)(31686004)(26005)(6506007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KWulDnZbTBCe88fyG9zsP++nixSsCC8dvPkW891WoGBO6nyJKNPc/sw8HaTy?=
 =?us-ascii?Q?AYEHu9RHp5Q2rS6WIH3dZ9ctSGDGvFtR00ZfIOuLq8WuG4j71Jdw3O9xCtZa?=
 =?us-ascii?Q?Nc0l4p1hhv/OxWMIH2TNNO0VUJZQSMQ+J7NzOvtfUDU2EqleRnVWnC+PovjI?=
 =?us-ascii?Q?4UiqK/6jCArWqyCGRljZjvwst9UR5FCRIh0pfu9sAIz0KfyT187tMXnrN/Fy?=
 =?us-ascii?Q?gg4T9WxqTTFzfMt9WiowBVahYs4CvysebSAdD8oxB8lSRJ8Ts0A2aWukBf+i?=
 =?us-ascii?Q?g3XuEVLNetNhoayipYgwfR/Wjlg2lEMFUJaKGTRHz/6o2jl9GbLGkox29GoM?=
 =?us-ascii?Q?Y3XP/gvipZWPnVZeKdOhwUhutuLc1TKppDsHb2ftTWgAN75GJZWY/IDUErM9?=
 =?us-ascii?Q?5IAwhybWCuJCsdJ+BPN50FhKcZiUgx9g+Abwp43XLgMdW6AN5Crw5+SWxJju?=
 =?us-ascii?Q?o5XuNuGQ1StDTylPr4Kn3uVW9cXdisQsDSgrPehzY54PKc0Wd9bdTPDQZ5Hm?=
 =?us-ascii?Q?krS9THFoVH7qAOjhlL1ql9Gr8LjTvLDm2PBH/ltJWIGVAA8nIabytqcpw55h?=
 =?us-ascii?Q?0TgXVTy4m9OZ2TRcY4zC7E7Qso3+HvuJQbiCcQ3pPnjq4VNR0qh4IXyVBn06?=
 =?us-ascii?Q?JkDy0BGuMsJFsqtOw5emh93FWZ5fncazB297ERUVIAcBSDxXvZXm/691X2ki?=
 =?us-ascii?Q?Vung0ZQU3D/FAPfSEac3AvXhhcZsPPfj/eTWyKNRwvqbQv4DIebU/fFEp7QL?=
 =?us-ascii?Q?2x6zN9Eewk828XhukEviqk2BpkeU3tWi9fVIXsMPwIbv/rh/rLiQD5JEktQ8?=
 =?us-ascii?Q?G2SUGAanebXuY8x4/yIATSpMLr2n8EqhqlhFZSGFUv8+vzq3o/1LZG1sZcO2?=
 =?us-ascii?Q?HCx1jgsfi0ubD51KuE/jTvJQ+taTzK8Ye+GGZyd3jIPGcTjHeoa55DkYnD2X?=
 =?us-ascii?Q?L0140VUVOqUDpVp34chKO2nZ9hFQLTZ5aLmVeGYZ7qmmdNAeSC2rChleNIcU?=
 =?us-ascii?Q?7fw6IVl3dIkwlagyh8ziTKB088i+RDQwB6TvBbmLC6DeaAiE4udx2ne7EwBC?=
 =?us-ascii?Q?iIjc77dA2mQQIFaccgIf64w3e/Web6n3JrgK3qMT7dQMyrSdpiSeVlsJNvTC?=
 =?us-ascii?Q?+5I+bvMpV9EGKcr+BpbyFv3bjEmNwn/U8GKQwar9ZOs+DdHiNxgZo9/NBhBv?=
 =?us-ascii?Q?O8A9fqIrKoVjcpNz08dJYyFwi1o4evYXYZSD7B+HMVSchWSETMTwYd4V38V8?=
 =?us-ascii?Q?XsVZ9uZI0MhnvrC+0DNydlgYw1Roak4DQ70ggEQBZLs5ubrAcAEOCpmwg4/G?=
 =?us-ascii?Q?pcTS7Ypn8bQCcYS8uyo3grPvd9eKnbU3NAAu73sFVrVbFf5EKf2jD5sKIWBo?=
 =?us-ascii?Q?UAb+EULFsa8sqOiLZrOnoBwKyZrPBmkuPBTzbJ1gV844sq7qBkijdli3FKhx?=
 =?us-ascii?Q?ERTsVVbtdMnuH/5mK86LQjFBgMqjtoygjLhbtgk51F3DbyJBiLhnw1wOWvBf?=
 =?us-ascii?Q?/BURi6LJwCwLfCozpoNGBHCj5BEOXVNuNNGTGbXRrjOjy1l69wpXTlbS2b33?=
 =?us-ascii?Q?9JKe55quNmors/vO2VVTNIAPK/EASnssbZSiBoAVgD69IZM9047Dk2c+EZ+g?=
 =?us-ascii?Q?zJY3jBD6/JQw3C9dbfU+3zQF873an+6bzEAjuvfBzzSzGOCxmy9D+eulOtD/?=
 =?us-ascii?Q?pCRTp/VTTAxhzXcsQMsGHgkTSve+gslfMfh9Wygkp3/B4uPIS1a/UO0mEJ09?=
 =?us-ascii?Q?lPGFXaEawA=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb4a521b-24d6-496e-20df-08da29c49cec
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 09:42:45.0489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mUw8TiaB9CB0TVYvMnytoy2s7rjA89AapCRG2zcnVjo9idsF3SyFxkcb7zwzuqZgnvspgqpFPpue3E9bSV5jqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2871

On 29.04.2022 11:36, Roger Pau Monne wrote:
> LLVM LD doesn't strip the quotes from the section names, and so the
> resulting binary ends up with section names like:
>=20
>   [ 1] ".text"           PROGBITS         ffff82d040200000  00008000
>        000000000018cbc1  0000000000000000  AX       0     0     4096
>=20
> This confuses some tools (like gdb) and prevents proper parsing of the
> binary.
>=20
> The issue has already been reported and is being fixed in LLD.  In
> order to workaround this issue and keep the GNU ld support define
> different DECL_SECTION macros depending on the used ld
> implementation.
>=20
> Drop the quotes from the definitions of the debug sections in
> DECL_DEBUG{2}, as those quotes are not required for GNU ld either.
>=20
> Fixes: 6254920587c3 ('x86: quote section names when defining them in link=
er script')
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:46:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:46:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317107.536278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNCq-0001Bj-Fj; Fri, 29 Apr 2022 09:46:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317107.536278; Fri, 29 Apr 2022 09:46:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNCq-0001Bc-CU; Fri, 29 Apr 2022 09:46:32 +0000
Received: by outflank-mailman (input) for mailman id 317107;
 Fri, 29 Apr 2022 09:46:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNCp-0001B9-A2; Fri, 29 Apr 2022 09:46:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNCp-0004cm-6j; Fri, 29 Apr 2022 09:46:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNCo-000514-R0; Fri, 29 Apr 2022 09:46:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNCo-00063s-QY; Fri, 29 Apr 2022 09:46:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rNZRk3TaEho3Dg5vhbKzHj8m6a8bNCECKsneEPQsLG0=; b=44F2dShDzCJISUBcUwCb2KLBjy
	IQr3flGO3F0of0Hrbhq9o0ij/KecPkVwOu7w4QZMq+KOZHCHcHeWgndd3Fhp0mIYQgL38Zp+hd4TM
	DR/LRy2JUSYD3eHdyuOOzmtVVxlXEmkmHbeTNOQaaEnm1khLdLWIDE2Vxx/7wE//x72c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169836-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169836: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl:host-ping-check-xen:fail:heisenbug
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=249aca0d3d631660aa3583c6a3559b75b6e971b4
X-Osstest-Versions-That:
    linux=8f4dd16603ce834d1c5c4da67803ea82dd282511
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 09:46:30 +0000

flight 169836 linux-linus real [real]
flight 169861 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169836/
http://logs.test-lab.xenproject.org/osstest/logs/169861/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl          10 host-ping-check-xen fail pass in 169861-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl         15 migrate-support-check fail in 169861 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 169861 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169809
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169809
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169809
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169809
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169809
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169809
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169809
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169809
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                249aca0d3d631660aa3583c6a3559b75b6e971b4
baseline version:
 linux                8f4dd16603ce834d1c5c4da67803ea82dd282511

Last test of basis   169809  2022-04-28 09:42:57 Z    0 days
Testing same since   169836  2022-04-28 22:11:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adam Zabrocki <pi3@pi3.com.pl>
  Andreas Gruenbacher <agruenba@redhat.com>
  Ariel Elior <aelior@marvell.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Arınç ÜNAL <arinc.unal@arinc9.com>
  Baruch Siach <baruch.siach@siklu.com>
  ChiYuan Huang <cy_huang@richtek.com>
  Clément Léger <clement.leger@bootlin.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Dany Madden <drt@linux.ibm.com>
  Darryn Anton Jordan <darrynjordan@icloud.com>
  Dave Chinner <david@fromorbit.com>
  Dave Chinner <dchinner@redhat.com>
  David Christensen <drc@linux.vnet.ibm.com>
  David E. Box <david.e.box@linux.intel.com>
  David S. Miller <davem@davemloft.net>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Eric Dumazet <edumazet@google.com>
  Eyal Birger <eyal.birger@gmail.com>
  Fei Liu <feliu@redhat.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Francesco Ruggeri <fruggeri@arista.com>
  Gabriele Mazzotta <gabriele.mzt@gmail.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
  Hans de Goede <hdegoede@redhat.com>
  Hao Chen <chenhao288@hisilicon.com>
  Hauke Mehrtens <hauke@hauke-m.de>
  Herton R. Krzesinski <herton@redhat.com>
  Ivan Vecera <ivecera@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  Jakub Kicinski <kuba@kernel.org>
  Jan "Yenya" Kasprzak <kas@fi.muni.cz>
  Jan Hoffmann <jan@3e8.eu>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <jasowang@redhat.com>
  Jeremy Kerr <jk@codeconstruct.com.au>
  Jian Shen <shenjian15@huawei.com>
  Jie Wang <wangjie125@huawei.com>
  Jonathan Lemon <jonathan.lemon@gmail.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Julian Anastasov <ja@ssi.bg>
  Karsten Graul <kgraul@linux.ibm.com>
  Kees Cook <keescook@chromium.org>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Leon Romanovsky <leonro@nvidia.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  liuyacan <liuyacan@corp.netease.com>
  Luiz Angelo Daros de Luca <luizluca@gmail.com>
  Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Magnus Karlsson <magnus.karlsson@intel.com>
  Manish Chopra <manishc@marvell.com>
  Marcel Holtmann <marcel@holtmann.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin Willi <martin@strongswan.org>
  Masami Hiramatsu <mhiramat@kernel.org>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael S. Tsirkin <mst@redhat.com>
  Nathan Rossi <nathan@nathanrossi.com>
  Neal Cardwell <ncardwell@google.com>
  Nikolay Aleksandrov <razor@blackwall.org>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Abeni <pabeni@redhat.com>
  Peilin Ye <peilin.ye@bytedance.com>
  Peng Li <lipeng321@huawei.com>
  Peng Wu <wupeng58@huawei.com>
  Pengcheng Yang <yangpc@wangsu.com>
  Petr Oros <poros@redhat.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rongguang Wei <weirongguang@kylinos.cn>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  Simon Horman <horms@verge.net.au>
  Soheil Hassas Yeganeh <soheil@google.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Thomas Weißschuh <thomas@weissschuh.net>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Toke Høiland-Jørgensen <toke@redhat.com>
  Tom Rix <trix@redhat.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
  Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
  Wen Gu <guwen@linux.alibaba.com>
  William Tu <u9012063@gmail.com>
  Woody Suwalski <wsuwalski@gmail.com>
  Xiaobing Luo <luoxiaobing0926@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   8f4dd16603ce..249aca0d3d63  249aca0d3d631660aa3583c6a3559b75b6e971b4 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:47:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:47:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317115.536290 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNE5-0001nZ-0R; Fri, 29 Apr 2022 09:47:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317115.536290; Fri, 29 Apr 2022 09:47:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNE4-0001nS-Se; Fri, 29 Apr 2022 09:47:48 +0000
Received: by outflank-mailman (input) for mailman id 317115;
 Fri, 29 Apr 2022 09:47:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNE4-0001nE-7N; Fri, 29 Apr 2022 09:47:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNE4-0004eW-5k; Fri, 29 Apr 2022 09:47:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNE3-00055j-Rm; Fri, 29 Apr 2022 09:47:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNE3-0007BW-RL; Fri, 29 Apr 2022 09:47:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DfGdHkVqj4i3sfscTtGN/0vJJR/4vcXzd2He+Zogvbo=; b=6wAVo4UKDNO8KHGMygKhUWbbVz
	l0V2ucB9602kmhkiZNDaKBrQ4o1kL6In4DE7vnvWN1gOGkunyZJCQcG9hf6mDEo18iTVDPkNt2mwM
	gyM4neGh17tcXLacZsbsV8cWCrF1jKypyTYgtnlXGHNmseGKIBFBHkcjahpLqbEoSobY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169850-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169850: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=a055308668d007cdd6795ab42b8530efa2e49a95
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 09:47:47 +0000

flight 169850 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169850/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              a055308668d007cdd6795ab42b8530efa2e49a95
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  658 days
Failing since        151818  2020-07-11 04:18:52 Z  657 days  639 attempts
Testing same since   169850  2022-04-29 04:18:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 106161 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:50:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:50:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317125.536304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNGx-0003DL-Hj; Fri, 29 Apr 2022 09:50:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317125.536304; Fri, 29 Apr 2022 09:50:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNGx-0003DE-Du; Fri, 29 Apr 2022 09:50:47 +0000
Received: by outflank-mailman (input) for mailman id 317125;
 Fri, 29 Apr 2022 09:50:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkNGw-0003D4-7B
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:50:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6a7e690-c7a1-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 11:50:45 +0200 (CEST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2058.outbound.protection.outlook.com [104.47.9.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-t5uktGsUPYqYNkYjb90KZQ-1; Fri, 29 Apr 2022 11:50:43 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR0402MB2726.eurprd04.prod.outlook.com (2603:10a6:4:94::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Fri, 29 Apr
 2022 09:50:40 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 09:50:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6a7e690-c7a1-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651225844;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=q2uInj1+3QL4S8VeHriMl/dzGQBL/14Nyl7gywqKjc4=;
	b=N19uwOLJf52/G8DSSr1J2bw4+gujjD5WYV2sC6jTln5jstkFrQ8Bu1PeA8KSgDXtrnlhD0
	kAW9de+dv5WT4vuY9n+oj6/zi+nHp3uUURgwK7WV4Ye/BAQmYs4MMvW8psj+ZtvP9BHEo/
	64xRgiOOU00lVIHnGZ8h/qS9y57gzro=
X-MC-Unique: t5uktGsUPYqYNkYjb90KZQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OYJtM1Oene1LbHKoY4coXuK42anuu3a+dl29ZkfKTOB+c3IGWM51N1/1tAtAqzj41lWZTFQtx21VdSnCEKwCu0zEJStMErT/Ze0w6D7F6L+hKyV9L6j9lPGbqEPJjj+UZDhDRYMUBgVNrzP5Y7yuBrWeqKZ90kMncm2pmkfezFYC4tdSeJsisVLH45FAbr2IoVc4ibCF9PDLl+WcG5HDcxiZUEtTU1idNnzEEPphk98GUllq4fSPiNnC1roh6HFrjmCbum1J5mWGy/LolDc7a8C23rHh9tk6zOPKY1rGgEn2wffu/b6eQ7muNgQrdqK+areaQxpgZz5rujZ1fPvgSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q2uInj1+3QL4S8VeHriMl/dzGQBL/14Nyl7gywqKjc4=;
 b=Ii0X1dEbdDS5b2QCbQa5jQFJubg8BwceHt2aCnezwpcgAxHO5HEau1vyM0zu+dFPbXdGpW+/8PTjS5cP2SmxYNk48xCcJwNZ1jMhJ0LZIu7KEscC6+j6mWBZThpqoK3HI+hZYm2DF0Qp6tXJcMg6kCz+rsMqfY/7Db/0seduQoIRh0GXjFHxEpKpf8WEoGjl+dkXX4k4/Fat784yiFtuoviT4oKbV4Kg5X7w4WaWrGwfyGijDro7aUrVo/gHlXop2dBhpm6vBje/5qMNv/MAKUCWHUXqdxHEe1pyz8hZW+zVLJid+FznitYses37iNCaQN47bGmPmaWto5e9GFdXZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8432d9b6-0aad-01b7-9ffb-e38ade602719@suse.com>
Date: Fri, 29 Apr 2022 11:50:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: x86/PV: (lack of) MTRR exposure
Content-Language: en-US
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
 <309bea05-2247-d451-3548-c824333a83f9@oracle.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <309bea05-2247-d451-3548-c824333a83f9@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0023.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::36) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 645a9364-3ef5-4f69-8f18-08da29c5b837
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2726:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR0402MB2726AF8E76429A0EA40C5A53B3FC9@DB6PR0402MB2726.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/IbiDbLfDYRAhbuyLWdu48FwozliX0jo8L0YEQkNjeLCE7h9xu5GFqst29rKZu2r1fJdCXBUT+Q/XgJ/3q08HEJbQ8oMYf7xcx0JhFvFT2SL/GtZIBik4UvIqHz16dWxkqkH6OFW67FC2Scbjd6H5VHDR6gIM8ldmZ4pFFpaA0o1Ny/AP6dnQcwPE+WTaxq+VjzDyW89wwrqEqc+9lloAWhR7N3XMZquq6vuQmsJRxVVZQEvNu361yTUq/aKsZqdVeHCiJY1Wvb398R1z7d4vDy1q0rD0eGLGr/6Hs1IpUW9RfL7A0Tw9qVcAIGnJWnRRV0X3zESUMcM3SrgGcYXLudYTGg+R0xm/33Bk7SYaQlgDG4oUUyibd/xGVJH20AzXUyKZqwXSs0e8BMHG6NE2qLbcLpgPX45UQfoPKte+OYi2SpESZLJzfS/exHt4ywgEaIjxQgRlfxNQmHzgY/nAcXKNoZgciBpf2Hy+smAo9QPHL7qSBZmLKKnFf59sDat6Y32b7rSc1gFZg18YD5ZqnQ4vqcNQkJP9SfWGRRop8U3jTVE2GYkG1rvwvYKsi+yu8Smn2pJAGmcPomWmFo4Se/TdYOypEpG2mOkgWL4D8V8cAqsEpC0NDXX6C2Oa/Flv4AxbRt0wRY1Gsj145vijmZHn9htwVvELH324z1SxMUZ7oBl/KAAyOSfTw5mjiSd+K2vIg+xzgrIjTmQd2DWtqFLT2Cg6pY8DdldUzy8wXG1eHrsScume3Tl8OoO2ilSZ3xQOhmK2qXwEglwOfM51XqhfXCGq9pxVXwSfgMChSIfq4Xxu/wa6RPIdknqyVpgHsGnjmpNW4UhydslqwnyLQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(8936002)(31696002)(966005)(6486002)(2906002)(36756003)(508600001)(38100700002)(83380400001)(66946007)(66476007)(66556008)(4326008)(8676002)(316002)(186003)(53546011)(6506007)(54906003)(6916009)(2616005)(6512007)(26005)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M3hhaDUwUEZkTGg0OUpCQXRnZWhYR2N1ZXJLSC9WbW9jN0hhZ2U0eWJRd0pH?=
 =?utf-8?B?ekg0QzlGVFFhYkNCSWp3aTF1MHNlNW9HQkdOcU9QZkVuYm1OT0JiYXZTdkN4?=
 =?utf-8?B?YjI5cmNqMGZ0UmRzeGxxUVpESEJKS2YyckxXcWNDeXZSRElFdG8yTFNIb0dp?=
 =?utf-8?B?T0owWHd3TjVSZTF1U1A2MFkyV1R0SStmZm1yVWcrV256QXhjL0dhT1psVTNZ?=
 =?utf-8?B?aGNYMGhJT1laMmxMY1ZJbS9NRmZRSUVjUGZPQmJqMXBjblNPTytvMkJ6VEx4?=
 =?utf-8?B?UFVaU0RkSnFOQ2RTa0VMTUo1dGVXNHNHRVdSdTVCUnM4OWdwclVsNnZ6UHVC?=
 =?utf-8?B?cytpQXNYVHpJQ3d5QVRqTU9pWlJPSEVNUktqVWM4Q3ltQ2xIWnUyNStBVitF?=
 =?utf-8?B?aFc2RFdtbUJsOTFlTVFNTWVTUjJUMFpqVG9ZTkJaN0Q2d0Z4SFZ6YW54c1pa?=
 =?utf-8?B?N0laYjhGZWYrNW9rcExYTWJYT3N0TWtlcDBkMmNSTWY5TEVBOUxHdmVueGV0?=
 =?utf-8?B?Qk8vTEZhSy96ODd1K0ZVZ0VZWWEzb3I2c2U5RnVOdldWaGNZMVdzZ3pnVFYv?=
 =?utf-8?B?Zms5a3Z5WTRZWklqV0tCbGc2NWQwU29IaHZmamdZdmR3MjM1UE5xWnk2MnBZ?=
 =?utf-8?B?ZXVLYXl2YnpKVDdhdE5nNkk0MGRFTGJFWFAyejluRzVhK01PdnRhSFp2cENH?=
 =?utf-8?B?RG5GK3IyRXdZL0U2WUpPQ2MxblhuY3YzNmZKL2UyT3FBNE8rOFRSc0hQWGdz?=
 =?utf-8?B?bDdoNXM2M3R6MVRMR2JXUlVCeGpSYXhlZENtMHIvQ0NycHJzVktEaCtIOXQ0?=
 =?utf-8?B?ck5Fay9FZldTN0lRT2tOT3BkcTlkZHQwSDBsV2xDTFlyV3MxSHB1emNPZUZY?=
 =?utf-8?B?T1VIa2diT1lUMmR5a1BCQ3cvRWp6VTFaNTJNSWlvUlBtWk9rMHppOWc0aCsw?=
 =?utf-8?B?bU1LYWpZdlBoOUl3eDhQeXRrNHVvTDdxZ2dQOWpuVEgzdzFtdnIxWXlsbVNK?=
 =?utf-8?B?cXpleXFMYU13RVZRUHFQbUExMFl1ZStJampzdVBVc0pzTHVib2dEVUlWWTFz?=
 =?utf-8?B?Q29BWnpRYVJsQ0RKTUFNdHVmdXFtOUN5Rkwzd1N0NXZ1eFg0ZUlDOUx5VUpp?=
 =?utf-8?B?MDRmVnlHekl0SUUzUjRDQ3RZVVdtQXBjcEZ0dzBoR0RaWGVNUm5aeTdUbHYr?=
 =?utf-8?B?WmY4NFdDaXVyZnJWcUFnOTJyVXRHRzhFVFN3UU50WlNpbi9nRkhQSUZqbDla?=
 =?utf-8?B?M0RxaXh1akVCcXlaZ2JDcXZYejZHUlQvNnhMOTlKN01DdytseThTeFZFOWdT?=
 =?utf-8?B?cmd1a21Pb1pMTXo5b3FLNUVSL0ZCUElvZjNwMWtoK3VFRjFhVlZSSXZCajA2?=
 =?utf-8?B?RVV3SXNNZ1QxWkp2dVR2a3BMOHJIVmUzSTNyc0hxOTFubDdUYTEydE5vTHhM?=
 =?utf-8?B?Smg2SGpSQVJablRFL203cExqYVBoSktYVk9La0l1Z0pUcFR3VjhNT3BuTmc3?=
 =?utf-8?B?K05ra3NCTUQxNGlzdWhLNDNjZjcyRkkzOXpCNmFJT1pnODQxc3I3RXpoMlJC?=
 =?utf-8?B?YVp4dHNmMXZKWlM5eVpUNWlpcnZVQkhYZlpQUzBqWG4yK0VRdDdTRmtNSUhY?=
 =?utf-8?B?WjcwWFJOby9GRkZURERXZHhKQUNIUlZ4Q2Y1NTByQkFMZ1p2ZnlYcTAxNmM4?=
 =?utf-8?B?WS8wK01GNCtVN0M0b00wSy9FUHZvOWdoYjVja0NaSDQrVHJidU9QeGRZYWxy?=
 =?utf-8?B?V3EyMGJaUllIS1I3d2JJVzNBVmNOclZqSWJjaE5UMDFMeFdtQ2JlVUN0bVNS?=
 =?utf-8?B?TnRkRWJYY09aOVhzTWV0aEVmYTM4aEtKSGxkY2NwYTl3K2NJWXVBVjlaOVRO?=
 =?utf-8?B?N3FzdVptTllpa2NyUjZ1amlnanBWblJBYllTeHl6UWxzckF0QnhKZWRtY3Jr?=
 =?utf-8?B?MzNXdnJFL2hHZGNTL3ZoSVNSRVgxRnVHSDYwVS9qSWpGaDR3V21Sc0Npck5m?=
 =?utf-8?B?bXVoN2RsSm5pb3hIY0FZNmFpdmlaZkZGOFNTSkJBN1JuK2x1RVIyZEU5RGhW?=
 =?utf-8?B?cDB6ZVorMDJoZklRSE9qRXJ5dDczRm1haVJ2V2IxNGw1dE5zVmJxT29sR2ZU?=
 =?utf-8?B?dWh5MVlDdkhrRDJac2RvRzZFbktvWUhlb1dqbGhzTzRhNVVnVjlPbnkrWDBa?=
 =?utf-8?B?WTNrc3U0M2pJbHZSZzJEeW43Umd1ZXh6MkhNZDE4cnV0cnF3RUdUdnBCZ1BS?=
 =?utf-8?B?cytCQUExTENHdUpnZjEyUWhpL0cyd1FYVDB2YUVsVk1ISkM0Y3prcHMvQjVZ?=
 =?utf-8?B?VE1jV2lKb0lWaWpYOHdleUxSRWpmWHdpb2dCdTMwaDFCM1psNWF6dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 645a9364-3ef5-4f69-8f18-08da29c5b837
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 09:50:40.5415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v9O634hNXLOZ/lKDIXa3Kc/MadQ0G7tcp4J7CBi6nqJUaG2h6eyTPlNDJvSiyCXXsiozsmHNZGg/N3hrmKpyEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2726

On 28.04.2022 23:30, Boris Ostrovsky wrote:
> 
> On 4/28/22 11:53 AM, Jan Beulich wrote:
>> Hello,
>>
>> in the course of analyzing the i915 driver causing boot to fail in
>> Linux 5.18 I found that Linux, for all the years, has been running
>> in PV mode as if PAT was (mostly) disabled. This is a result of
>> them tying PAT initialization to MTRR initialization, while we
>> offer PAT but not MTRR in CPUID output. This was different before
>> our moving to CPU featuresets, and as such one could view this
>> behavior as a regression from that change.
>>
>> The first question here is whether not exposing MTRR as a feature
>> was really intended, in particular also for PV Dom0. The XenoLinux
>> kernel and its forward ports did make use of XENPF_*_memtype to
>> deal with MTRRs. That's functionality which (maybe for a good
>> reason) never made it into the pvops kernel. Note that PVH Dom0
>> does have access to the original settings, as the host values are
>> used as initial state there.
> 
> 
> Initially MTRR was supposed to be supported but it was shot down by x86 maintainers who strongly suggested to use PAT.
> 
> 
> https://lists.xen.org/archives/html/xen-devel/2010-09/msg01634.html

I recall Ingo's dislike, yes. But them suggesting to use PAT when
PAT depends on MTRR internally is, well, odd. Plus there continues
to be the question why PVH Dom0 should see (and be able to play
with) MTRRs, when PV Dom0 can't even learn their values.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 09:53:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 09:53:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317131.536315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNJU-0003r5-09; Fri, 29 Apr 2022 09:53:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317131.536315; Fri, 29 Apr 2022 09:53:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNJT-0003qy-Ra; Fri, 29 Apr 2022 09:53:23 +0000
Received: by outflank-mailman (input) for mailman id 317131;
 Fri, 29 Apr 2022 09:53:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNJS-0003qo-C5; Fri, 29 Apr 2022 09:53:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNJS-0004pY-9a; Fri, 29 Apr 2022 09:53:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNJR-0005KL-Sw; Fri, 29 Apr 2022 09:53:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkNJR-0002yu-SS; Fri, 29 Apr 2022 09:53:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HaFV9j2U1mWgax741mm3UDBRC3dS00MyFBhK625tvOM=; b=638FCnSeVDsEcvqciI/odDcuwk
	6q49B3GS2ZZqyZWSu/5TjEkyOd/NHqWpvvjv0GfdBQJscjvSVOhsJ063pIshP08xjPrPhHY5N90sq
	XWQo8mW5hIJH4NX03pZcVola27s+G1BsEjiYgtezvM98OTdi4qNFxr3ceGlYgn+OH4Dk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169858-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169858: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 09:53:21 +0000

flight 169858 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169858/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   59 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  692 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:00:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:00:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317141.536329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNQO-0005Qi-Sf; Fri, 29 Apr 2022 10:00:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317141.536329; Fri, 29 Apr 2022 10:00:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNQO-0005Qb-PP; Fri, 29 Apr 2022 10:00:32 +0000
Received: by outflank-mailman (input) for mailman id 317141;
 Fri, 29 Apr 2022 10:00:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkNQN-0005QC-Oj
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:00:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 33414eda-c7a3-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 12:00:29 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-fPU9DSkmOsCnn96CAf-0Bg-1; Fri, 29 Apr 2022 12:00:27 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DB6PR04MB2952.eurprd04.prod.outlook.com (2603:10a6:6:b::12) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.13; Fri, 29 Apr 2022 10:00:24 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 10:00:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33414eda-c7a3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651226429;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BTJsUJAPEIuQXyp98P3XftmWrZw49yvkYUB7KnqPkeg=;
	b=CtsRf5ofcCVTA0sl9OTL9/TBhCeR5qPviC9MIZ9jIloAS7hn+/Q9b64bxp2Brb5ifq+ELG
	SUtk9c9eQllTW5hXYSPBP1Da8audDY5WtSFRTbdYRrEi39GqQvSVhVGEm3co3eUYOBhqMC
	6hJV/aZtxd+LiGpZowL0ZK4lJ8NpvTw=
X-MC-Unique: fPU9DSkmOsCnn96CAf-0Bg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IgW7GMaoU17Najrg4oMUZxVuRbSz6btVj3Thnz2085Ay05i609/z1weMaPgNfQIG9yKcPX1FDl/a5GsmASdvOfURyZl2LqfyVVfa3yhxqcWbRyLAEg8WlitjjTcrdkfbUnjkS+ryDQ+G3AZvrFbjOyq9fjrN8ZvUJE26oLh8sAbKe3K7orFZZ3UauxCpigiWdeCMvsdjq0BiJkkP/m3cFpEFH1ny9pdPnZyawTyT9tuV/JDXVPuH0Iek9zsdwpXQQdbjUo05NupzqztNMeRX+xtHIjN3uDutvchXu7CNoU5QfHOH53aufda5k4mJH86Dyl1x7uEKce+QBvcNLp/7KA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2RPmWF+WLhZ49qd/qXvvWeU0bAoV+1Ztkr8p0t6aoOo=;
 b=Aw/YZTCc7ks0m4ZujqUf4sYkPaaVM8WJ8REF/zCvdvYNLrjDcQ39kNoEIPNAh1BamwVyPFYhre949bubadvQhbLxxYI/tFwK2xgJdPm2oZv+gKMAij8DKdjT2MD+8GpueWpq4MYMJKxyxqingM7Nptg6YQDJK8RpNEt2gl1yKBBRRuKC84vYgCq3Oush1XpS90osRukcSOdk8tgPoibuzzWU1nTTgXVXWD4SvHpS4R2/KiooxH53XqI+XajVQFwm4WSwsuV8xqd2bMcmilh3+PVOCejjidJyB9oNcLHPB8F22ktc6C+2/dFUxwTAt47KQiFXtcty1T1gbnnhEKqGJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2a229df5-c341-9ff0-ae5c-cc0d848d7cea@suse.com>
Date: Fri, 29 Apr 2022 12:00:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: x86/PV: (lack of) MTRR exposure
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
References: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
 <YmubOeYPqW5mBNy4@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YmubOeYPqW5mBNy4@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0072.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::23) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8183452c-82c7-494c-c992-08da29c7142e
X-MS-TrafficTypeDiagnostic: DB6PR04MB2952:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB2952A17C217E0EAC2D3FA812B3FC9@DB6PR04MB2952.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZLhPUkV/+cyvsJGoIgHP0ykoSz7GodTMzhtYeL7zChK1ddN8ydRSztTZhxB4VUctjJWjksmIfRkzmzlLsYc/L//2QZyz7B60V01YL04A3cJV04ONRuwrzZR/DFUO0Oy5VLyrxVFzsWh/21kqWiTa6Ui5qmXgG4lkuikiods7DjlqJi90vrRKnGB5oNML1vL/fc9QcBu+fxhk2XxORvpRxiMtvVjAdRlVVOJLjnOgoCK6EEAvV7nMJkSCYbEkkpAazt+rCtiDO30ZKb2W71gwxjkSxKyp8o1a2zADnbE5FtosZFrP5ULU9ojJI62bswN5Q9o2GEBe1kPh32kDgrzPTFAMvsd+gOGTb/lSLMVyk2rRSKz6Imi+pTDmb1C0GsN2BH5aTG9PT1YKL7oeZxSLG7Muq58BFXTsi8GaCI913nA5NFO4wQ3EB/LEG3NViyfQMnqKgcw9iPwa38OvHXz3Uw79YAZM+5JI9Z3yRrkbPAcPYcPNW0qAU48JlicLEyQr5J+0Vk7SpIk2nCdxqP4wyTvacX/Qu7n4nch/7JGAPeLWZmvW+N+yqRPzX1+hEdsECUMq8rn+YCf2k6vNAqfF2eXfx9uhlutjwoNIgLwnWi+iYeXAdMWoEi1xqc8dqOVpqZcHEeb6dn9MylQlPJCj/ZbVL/7v8jIfnsWYsmBZ74Kw2De47MJq5QSs4nEPb7OX82+lFFFFQK6hn6y7jfkwnjXRX9/dP57taWzadM0o3v1+cDL9FY/THD2ifkxtls5Y
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6666004)(5660300002)(36756003)(6506007)(186003)(83380400001)(8676002)(66476007)(66946007)(66556008)(2906002)(31696002)(4326008)(316002)(31686004)(2616005)(86362001)(26005)(6512007)(38100700002)(8936002)(54906003)(6486002)(6916009)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?iHCcdGUKxQi9gnr0P0wmrX65j5xzAqY0/IIKB/NH4pB8bYtW+1/mB0ZW3f4m?=
 =?us-ascii?Q?ZrScB5a1puTN0rIsMwx9nLrCjKLd7yusy38MzZuYSNsuw8QtoaPwa8Wd1la/?=
 =?us-ascii?Q?VRBH57kvTJZd9wqQhsMUCbH80DecKIkl+lmOS1YWEL408SEKi23n788EzeFw?=
 =?us-ascii?Q?owCUCHArHYBJlwTIIPR+7yyJu05uv4LdmTrTFPrWHlcqxq5FYPNJxHJ5yMqq?=
 =?us-ascii?Q?XVySaS/u8JwE03sCSflh5BARoFQ2fvfW+TvSushH4O/4EIg9cPAHF6rmQItC?=
 =?us-ascii?Q?a0jQr5vAvhJZSPU1IdBZOy1CHO/kf3x3Mlmd2kkZFlV+5qnlaJE12VXB7sbj?=
 =?us-ascii?Q?9HlzN3HcUA6O2EE2dCn06rY4odWH/+Sz/W5rSfRLw+WS3q7REbW1q0+vg37Q?=
 =?us-ascii?Q?dMi0xreO3+ao4mU7oSHD+Vzptto9qOyDjKUbZE5lKSTjP7avBSMFJpx4GqBY?=
 =?us-ascii?Q?IFLn539lOS02aJxW3+7KLQ5uQoAIW7sqt5LDUeL5SVpkOOExt5bcZFNywboR?=
 =?us-ascii?Q?ZEfGeCS8mH1yYy62wqHhEAPlFvXA2zF1hm1LC1jsLeYsDg1afZOszq69xb0g?=
 =?us-ascii?Q?NHKZoC6ljEDnLF/xq0dkh62wYT+x514hCT5P7/6NOZPa9WPnzjbxQCHOVRuB?=
 =?us-ascii?Q?LjX/snPXWHKMxtFHzzdqEjfyvgzWmtu32deKh6YR0s45TK7H9+1Z9KVtlES0?=
 =?us-ascii?Q?qe6H5X0fLBf1KZHRrL6yqGTjHHWhD5kfF432esLL95V8Zu/m2Sp+Iim/v9Ba?=
 =?us-ascii?Q?8FeAXdDWsE6GfdmCuTxMOixHGG9TbplQt478aHqbM6EyhKp6yiprfCWSiCjW?=
 =?us-ascii?Q?sNHgz4gDO8HfGmcMGHihHew1ycTVP0psNgNq6Cndovr1LeWHx0qEBrymU1UO?=
 =?us-ascii?Q?ktgoQMlHb/AjgUqJzNKYeU7PkC9KwEFK7Bkl8OkifUC3FjPKplXlEiTayr0i?=
 =?us-ascii?Q?E40HVhBKsGo4gXWIyMq+AXkkl81P8oR5hnyh8BXDWTQu2tnH+hP/BUZQdrJP?=
 =?us-ascii?Q?+r+ITvjRbIs4FrwKT2iQrCg3c0b0l8hqXyTQFPrq+gZXZ7i19YHPFHvfcMdh?=
 =?us-ascii?Q?zg3Z3yAcck980KohkEGay8AS5IZhyLsfR1WHQlhz8WlorMhxaeb9tSvcvAiN?=
 =?us-ascii?Q?aD9d0c5ISU/rkxPeKZdx79+Dp3U6f9pUuelFZwbwyAiArpzFommdRxoraREv?=
 =?us-ascii?Q?fJnAj/PSKsQnny6zGatOgFNASMKOiZPellMOTBsMzs0YtpUlU2q7wtO2bcEC?=
 =?us-ascii?Q?ubEnCF/7mOraMfmRbn73dE8sVnhJhaTyg+mC0wGGnMewc64TfVTYZeYkkSzw?=
 =?us-ascii?Q?tMikZLCAbF9Y7+4CE40DWhFzzyQgb35V2ICM8EM9J1EQCuMBzs0+fmOLC0eI?=
 =?us-ascii?Q?O8PtPwBnfovZCSg+ueN0QWKdqXyu69mOBqE1epqfUTEQX0XWHdsiCvEMgOje?=
 =?us-ascii?Q?a0IcBNFH0k9E/WdcykDGXVk3Aj3R1wz3XPUsvunwgX3RjA3IpuyLyDhVGGdz?=
 =?us-ascii?Q?LOaPxuWp8Ndgg9k+a/dd/SUbh6Sto1e4Xi/i3oSngQ4KvsJQ4U/KsBGHjrZN?=
 =?us-ascii?Q?ZQWmsNXlqI6lCXTVV7f373qUfMndxRz9++EjvCuDwo+zhhrHOX+8AGcBKQg4?=
 =?us-ascii?Q?95E0wgmNUrfQ5JKj9nRZ6DEBLLWJy9DkY5aq9Gh28hjFfExG9LqgEyvQ3yMx?=
 =?us-ascii?Q?XGq+IXNti425qNcfttlXjJMY6YOLUoN8fIfCMCAXBaAZKq3viF8T1guByn4A?=
 =?us-ascii?Q?egqZhsHj0g=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8183452c-82c7-494c-c992-08da29c7142e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:00:24.1281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kq33KtlA/85MGTvR7IAvXMPySiaL8UJdHSrcCMOwpgdzCCe5uU0ph7IcEQZ5HXb3ZOYFAB2dCm1m9udeCoJaPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB2952

On 29.04.2022 10:00, Roger Pau Monn=C3=A9 wrote:
> On Thu, Apr 28, 2022 at 05:53:17PM +0200, Jan Beulich wrote:
>> Hello,
>>
>> in the course of analyzing the i915 driver causing boot to fail in
>> Linux 5.18 I found that Linux, for all the years, has been running
>> in PV mode as if PAT was (mostly) disabled. This is a result of
>> them tying PAT initialization to MTRR initialization, while we
>> offer PAT but not MTRR in CPUID output. This was different before
>> our moving to CPU featuresets, and as such one could view this
>> behavior as a regression from that change.
>>
>> The first question here is whether not exposing MTRR as a feature
>> was really intended, in particular also for PV Dom0. The XenoLinux
>> kernel and its forward ports did make use of XENPF_*_memtype to
>> deal with MTRRs. That's functionality which (maybe for a good
>> reason) never made it into the pvops kernel. Note that PVH Dom0
>> does have access to the original settings, as the host values are
>> used as initial state there.
>>
>> The next question would be how we could go about improving the
>> situation. For the particular issue in 5.18 I've found a relatively
>> simple solution [1] (which also looks to help graphics performance
>> on other systems, according to my initial observations with using
>> the change), albeit its simplicity likely means it either is wrong
>> in some way, or might not be liked for looking hacky and/or abusive.
>=20
> I wonder whether the patch needs to be limited to the CPUID Hypervisor
> bit being present.  If the PAT MSR is readable and returns a value !=3D
> 0 then PAT should be available?

I simply didn't want to be too "aggressive". There may be reasons why
they want things to be the way they are on native. All I really care
about is that things are broken on PV Xen; as such I wouldn't even
mind tightening the check to xen_pv_domain(). But first I need
feedback from the maintainers there anyway.

> I guess we should instead check that the current PAT value matches
> what Linux expects, before declaring PAT enabled?

I don't think such a check is needed, the code ...

> Note there's already a comment in init_cache_modes that refers to Xen
> in the check for PAT CPUID bit.

... in __init_cache_modes() already does it the other way around:
Adapt behavior to what is found in PAT.

>  We might want to expand that comment
> (or add one to the new check you are adding).

I don't see what further information you would want to put there.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:00:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:00:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317142.536340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNQh-0005oK-4f; Fri, 29 Apr 2022 10:00:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317142.536340; Fri, 29 Apr 2022 10:00:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNQh-0005oA-1h; Fri, 29 Apr 2022 10:00:51 +0000
Received: by outflank-mailman (input) for mailman id 317142;
 Fri, 29 Apr 2022 10:00:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nkNQf-0005lA-Kg
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:00:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nkNQf-00053e-8c; Fri, 29 Apr 2022 10:00:49 +0000
Received: from [54.239.6.189] (helo=[192.168.23.31])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nkNQf-0007DJ-2R; Fri, 29 Apr 2022 10:00:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=L7qjBGLy7IlNpCb2oBNOhu5gWb8966blZbRHZ/mUusQ=; b=X/PFVxrisF5gABjq9/Y1flUoev
	PyRsVYkhnm1dQQtraUInoy815F3GhGviW4K6rDE0Gaddti91kayVCV6mqdd8bAY7JHs902jIcZBHc
	OMgm2tju9c4nnyTgrd8599KXFyGeSTUKzdMjhwYIAgZIZsJsMINmLAqTrCOxSMXjEI8Y=;
Message-ID: <21f302e7-3e02-6ad1-de1d-55e6bf05be0b@xen.org>
Date: Fri, 29 Apr 2022 11:00:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH 1/2] kconfig: detect LD implementation
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Michal Orzel <michal.orzel@arm.com>
References: <20220429093644.99574-1-roger.pau@citrix.com>
 <20220429093644.99574-2-roger.pau@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220429093644.99574-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Roger,

On 29/04/2022 10:36, Roger Pau Monne wrote:
> Detect GNU and LLVM ld implementations. This is required for further
> patches that will introduce diverging behaviour depending on the
> linker implementation in use.
> 
> Note that LLVM ld returns "compatible with GNU linkers" as part of the
> version string, so be on the safe side and use '^' to only match at
> the start of the line in case LLVM ever decides to change the text to
> use "compatible with GNU ld" instead.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:08:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:08:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317153.536350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNXT-0006ir-T2; Fri, 29 Apr 2022 10:07:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317153.536350; Fri, 29 Apr 2022 10:07:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNXT-0006ik-Q9; Fri, 29 Apr 2022 10:07:51 +0000
Received: by outflank-mailman (input) for mailman id 317153;
 Fri, 29 Apr 2022 10:07:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkNXS-0006ib-9y
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:07:50 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 36e57bb3-c7a4-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 12:07:46 +0200 (CEST)
Received: from mail-bn8nam11lp2176.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 06:07:45 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by SN2PR03MB2174.namprd03.prod.outlook.com (2603:10b6:804:c::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr
 2022 10:07:37 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 10:07:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36e57bb3-c7a4-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651226867;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=e0Fl6XZ8kgXcYYnk3gslwDNK2cN/ST6N0U+WIjjJTaU=;
  b=ABKY2KGhCB6dGkM4FVCZqmF/3tHIFkqWjmODe5Zt9NqeIi4wf7pk2pAq
   U/Pv3xe0pDOe/+Bgeri0AGpOroF7F5aSPyf4e4QqPaHXb5tDp2fQT0qiZ
   jvDBIcS4YNJe2uzIQ792nawCxFWQ1sTrYCL+XLoSq+pFWnQf6XWaTUvhh
   I=;
X-IronPort-RemoteIP: 104.47.58.176
X-IronPort-MID: 70625210
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:xBkFeq1K4JF3OvFZkvbD5fxwkn2cJEfYwER7XKvMYLTBsI5bpzAGz
 GcdWWyGM62NNzSke94lbo2x/B4A7MWAn4I1Tws4pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tIy0IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0VkMeoU140Y5fXs8kabThVOnp1OopZreqvzXiX6aR/zmXgWl61mrBEKhFzOocVvOFqHWtJ6
 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82TBfyVu7e03x9p7ixKNezZa
 McDLyJmcTzLYgFVO0dRA5U79AutrianLWcF8gvNzUYxy1rOi1xN6L3fCdzqXobXHMdqtXbfo
 22TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqFeU3G0IThoNSUG8v+K6m2a5QdtUL
 0FS8S0rxYAw+1asVcLVRACjrTiPuRt0c8FLD+Qw5QWJy6zVywWUHG4JSnhGctNOnN87Q3km2
 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgc/iTQsSAIE55zpptE1hxeWF9J7Svfq0JvyBC36x
 C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztp6s8K7xooG9g
 UU5
IronPort-HdrOrdr: A9a23:ItGFHKBiZEvPQ27lHeg/sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80lKQFmLX5WI3PYOCIgguVxe1ZnOjfKnjbalbDH41mpN
 tdmspFebrN5DFB5K6VgTVQUexQpuVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dNMEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfXHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+06VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qY5+FNuAxem0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg72w
 31CNUWqFhwdL5mUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q
 6xGm9liQ==
X-IronPort-AV: E=Sophos;i="5.91,298,1647316800"; 
   d="scan'208";a="70625210"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kWkxp4r+XIPhg6iXX2Tm3a6t4pdEe9VzUyiemzHUeBIwcrnrVlC7E6pgU9pojWTFlos6kzAlTbeqh1g8K9Ov8afrNJV8kayYeVYq08AK5sTkQKK6q5LW0ucgg96fpLuTDuHFM+New2jCmacIkRfe4yu2T+v99jKslXH2VkQU6kJxIRJfArHwCLI6Pc9nKp5bqgJ1wk+cta3AMB/OtMFrjULHZmgh52P7yCR1aJU5cov/PbKsx4YBWOfW5FUcqZVb6SdAkn3cKZqbeQ7+7uQdHwy7JArf8HUsBAuepsiGex0n/wggFKBweIZYs/bvdz0taMp0wJPWasx+2z7RDOUjlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k2H+bL2KcMUVVnQEklaMinDUUpUYPRANCBMMCDnBRL4=;
 b=DwE6/q5oAz+xJ6hLdqWGy9lbyNmUOtlSotJq0b+asJXYXwNQytNG/ZOZl8P1ULSNzWU6sSf8oy5ezcACySb6BZDIaTGSTXGzpJkleMmzaj2Za7FPkQMGE9ujYZJmq/YoDDfCAyFtGbB2l/LEvW9pCmPnqkw8/BxaVyZ+FTSP1jWEDGHEAcJFWXcDM9h7audhzMdg/wlNrbpg+eWWI1Ssd/qoiCk2dYLAr/uSd0y23p55Yy8QfOnUAXx0+1beCgTtHPubAquclXmSp9iBj4oqTRtpw03aecoPIHHj308cnnZxbVojhG9LQRVhx0/DzbNghcVcoNlXciYnNqu1Yw3jIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k2H+bL2KcMUVVnQEklaMinDUUpUYPRANCBMMCDnBRL4=;
 b=bRpDFji3oGVNwNISVuRG/ClC6rCi5ZvPGeGuFuRi0hyUW6SzSzslE3XpD/AUNNnXbaMcFiSZsb2dLavmdvKTUY6VbgEhEtMoloAQpW3bmG7/fPRZxG/NZXebbZbZySol1P41yOkaR/hnLnS65z3G2RWMvkcPBnZ3FQrnEOCqoFA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 12:07:33 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: x86/PV: (lack of) MTRR exposure
Message-ID: <Ymu45ZVA2Mwmu40q@Air-de-Roger>
References: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
 <309bea05-2247-d451-3548-c824333a83f9@oracle.com>
 <8432d9b6-0aad-01b7-9ffb-e38ade602719@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8432d9b6-0aad-01b7-9ffb-e38ade602719@suse.com>
X-ClientProxiedBy: LO4P123CA0234.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6e95c7e0-48e6-4502-7131-08da29c8164f
X-MS-TrafficTypeDiagnostic: SN2PR03MB2174:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<SN2PR03MB2174E02044CC9A84DE410E1B8FFC9@SN2PR03MB2174.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pF9ueL/CBFX3p+peAoDM+bOtr9+4d+ay3qblJvrBi+dPJcFlAWg25tcJRdlqahyLMPKEW3KIbzz3CSIkk3mGzUT94fQzzpHygqE7O3Qv6Aqwvs6gTDCoxBGWYlO+ffFyLEKQtsYOwAR/6+c0N4pMpvaGhoQVLeZ03xq5LzlJxy2Q2dbroBO+xFtEGk8yb2b0pyBUCjB+1xLSCCt8uHupQohJg8j3YemVBXaY9daHlh1gducFNGXmP8FMtlt5vypEVNVpNARtdGrjcnC9Y3llxiKNe5PDkdViH7cxHcd/kTt/c0cPDdB7EsaZeDlFhkvJtjTeBqZrmlDJRSNwJsBoKqR9DzPn1iy0uyWxhdCZel2ZccF4EsGsCDgeDoXJLYTkY7+ISv+bSOTfhLIm+30ssOcMISVR+Fy2hJ1mauwDRhEtf73EXQuzZaudD+NPcT7tNhU4ooeyCWRPxuFptCADQFPzucmrh2TKLeqbdZSH7rsT+9zQSh23iHHFjYCDYBXhRZXETcl3MLjflbjg/Pw2a1SuTcY76Yv4gTMAr7ARcsyBdo0n3j44zZVVWlCsvYx0ICjJ+vbUVj4SlOY+7osR7Fp/15mubD5xLkReZeKoCVxoWQ9FDVmcEBpKtClvMdh3evRI6l/PE4UQHtnc1oouVarPTdjU57svXcU4UIZAHI7/BFfmeHNcYf9UOaaceF29IhERkD9oCDenp50qSugWmhAnfX/jm6o9HJ/oA8nUHsA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(9686003)(6512007)(82960400001)(6486002)(966005)(6506007)(6666004)(33716001)(8936002)(5660300002)(26005)(53546011)(186003)(38100700002)(6916009)(316002)(85182001)(54906003)(2906002)(83380400001)(4326008)(66556008)(66946007)(8676002)(86362001)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SGJhR3ZrSWp0R0FramJSOE1jSHRYd0FOeS9vbC92akpHYUc2MU1iM2FvQURG?=
 =?utf-8?B?MkoyZmxxRUtlZFF3N1REUlJYRGd2aTRqdTgrckZpL2k3SWMwcUN3eXI2eFMw?=
 =?utf-8?B?T2lMcnZ0NmNLUjR6OE9QcldNMmFXZUN0WmVMM1VNY09oQ1kzWEhlODhKbDZX?=
 =?utf-8?B?R281RGgvYUlGZlVIRldhNS9nZ1RLUUdmNzBWZm1VRWRwOEU4UGZiMUlmN2hl?=
 =?utf-8?B?bFZjL3VrbmZmUFlMQXhvRlpKVUxXVXhxdU5MWkRnU29DbGRpMUw3cWZHZkVD?=
 =?utf-8?B?VUtUVElnZ3VMZVRBbm9ycDVCZ2NlVU1YMkdpWEVmSXZWa0F2TGkrRDZnTUFh?=
 =?utf-8?B?em80Z09mNU1wOTE0bjV4OUxPM1F1R2lkU2Y4UzZkU1J2T2tKMlRCQThjWmFz?=
 =?utf-8?B?UkdabmVRMUhnV1RCVXZHVUcrZ212eSs4R0Z0VUJ5dWl6N1lLaDZGSnZhY2lU?=
 =?utf-8?B?VHE1TFI0Z3VMSzE1bVJ6WFJadTM5em5tamNCbGdsLzFsMjlmd1BPUnMxeXAw?=
 =?utf-8?B?aXkwNFF1TDI2VExWclF6WVZhekREWkZ1b3NSbnpNZENONWFXbjJEd25NaEp3?=
 =?utf-8?B?dHBDVXFjQy9xYjR0UzgwNWFrVE1XTWxZYUJwbnZMQk9qNVBTTlEvK3pQRzVW?=
 =?utf-8?B?YmVnNFhjZWF4MXhvd2E0bEpnaUM4Y3k4cjBKTnpFS0dDczhlRFIrYlhjb0pB?=
 =?utf-8?B?ZDlTM2VtR21mZm5ndG1naCtjTVh5N3p0YzNlb3FaSmJLUm5xaSt6R3ZDYVJT?=
 =?utf-8?B?VlpYMHg2d0JmTFM2Y1dHamJrVVh5SGgrZWFNZ0ZEOGRRQ1k5WG83cHlUSmt0?=
 =?utf-8?B?dDR1QU56cVRKQzJHdUl0YlN6NmhZTmZRVEVFcGpUQlRFWFVtZ1hoc0E2Umpj?=
 =?utf-8?B?dklIYXBHSUJQYklTdkRMd3BkejA0SHVzTGY2YVRUOUlnMTRnT042c0xPaEIv?=
 =?utf-8?B?ZjJvK05zdXlpWFIwSTVFT0ZzQ3d6eU9UbVFsYWsxV3lUN3g5SlQwL2VnSHor?=
 =?utf-8?B?WWc1am5SclRBSjBIUGxDaWtRektqUWhBbGVEZll3NXdxVW9IK1hiMEVuZ21l?=
 =?utf-8?B?cmo0VVQ3VDJCTlhpY01BZjV1ZDJWVUZzQklmVG5Lb1JYYiszR1h0WTRKSWJV?=
 =?utf-8?B?MXpwejRCb1BUOXpmRTZRZU5WVlBmTTNkNVhmeldnRjU1aGJjOVU0SmFQTUU1?=
 =?utf-8?B?SWNxeFBqSmhOczlEYnFLVjVnamo2Wlo4NmhJL1ZlQjVRRGxYYWtvUGJYdHZP?=
 =?utf-8?B?VWo5MU5udG13NTVUcVgyVFpPcDBqRlpZTjVUdzRGMG5VV1pmdFk2WWNsd0Fh?=
 =?utf-8?B?eVkyVm5jTFkvcVJZQkJCVkNxOGx3RHhzc0swQVA5ZTRIaWRRdE1qSWorNFY4?=
 =?utf-8?B?SzJFNmxxa1N4QXdQc2hqZmFwSEtldW00dkFRRkUxVW1KMUlzYzQ3M1MrdXhZ?=
 =?utf-8?B?OG82dzk2bEZxdTBhaDdkZWxHZ2VXdU83Y1lpc3h5aGhBNTlEMG1sTG1kZ0oy?=
 =?utf-8?B?ekIvWVcwWnh2VzZIRDA3c0NaMS8vcEdDUWpGUC9kMVVyaFZYbTk2RUorcFF3?=
 =?utf-8?B?TXV3VXVZNUJMWHFONGZEWlVjYURSMjFQYk94aEdtSVVEcmVDc3M4dnZQd0Nx?=
 =?utf-8?B?QzRvQmdBays3Q3JhdXRYNHJhVEtGMTFvTVJyVXplSklLbGtaRm5XQTZManBX?=
 =?utf-8?B?TlZtL1hTaU50K0prZWkxKzRVbGNzQnVtSDJqamdCaCtOdGJmM3A4V1d5a0pz?=
 =?utf-8?B?Vk8yejNPZk5zTS9EUVdPSkRQMGt6U3NhWTQ2MkJEOC9JSjhIMDdzZ2FodUJv?=
 =?utf-8?B?OVR4MnRZdUZHOXVNSHo0d0JXRUlDVE1adDc0L1ZkQmw1S0JuUHBZSHFQb21o?=
 =?utf-8?B?NGxtekZvZ2hvV2lVeElUTkp2dUpOWVZrLzZWRTF5aHAzN0cwYXRNK0VZVVp2?=
 =?utf-8?B?aEtzUHVOWkhTWUZ2MS9JbjQyNGhCVnJYdEV0b0ZDSlozb0ZPZnhVdWdOVS9p?=
 =?utf-8?B?V05WU01STUZOOWtxeVNhZm5MZy8rQ2htVThsNU00WUlRblV1MVFUb1pZZEYy?=
 =?utf-8?B?UGVnM012SWd0TFhadGlxZUFvRE1ScUt2aXJJZUpuV09GQ2tObUUzM1FvaEhN?=
 =?utf-8?B?M09ZQkRWQnVTTGFvN0dCdWMwazlEOUh2a3E5dlBINEFwYkZZeHpHTXZMcWdV?=
 =?utf-8?B?Rm9xNkVTaXVQQ2RZUHZLOHJtYXJWN09yaXA5d3g1NVlacWZmNEQwV2lqU1Nx?=
 =?utf-8?B?UkM5ejhRS3VqTStkN3kxc0RLZkxKMEVBKzU1Z0VCb1Y4c0lXbXhRemRGbHJF?=
 =?utf-8?B?Q1NRb3A3My8yVjJOelpsQmQ0dlZBTHlnb2s4cXdRU0theEM1UUNXV0ViZnFw?=
 =?utf-8?Q?2PS3CTDDBLCvh4rI=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e95c7e0-48e6-4502-7131-08da29c8164f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:07:37.2568
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UgtCOHYH2VG+bf65/dvXDa98mZN8xbQuu+3kLJmujUoXC9LmpbUYZJaqZ66VTA5tw3IikAdAhgAEEwEeTCLJEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2174

On Fri, Apr 29, 2022 at 11:50:39AM +0200, Jan Beulich wrote:
> On 28.04.2022 23:30, Boris Ostrovsky wrote:
> > 
> > On 4/28/22 11:53 AM, Jan Beulich wrote:
> >> Hello,
> >>
> >> in the course of analyzing the i915 driver causing boot to fail in
> >> Linux 5.18 I found that Linux, for all the years, has been running
> >> in PV mode as if PAT was (mostly) disabled. This is a result of
> >> them tying PAT initialization to MTRR initialization, while we
> >> offer PAT but not MTRR in CPUID output. This was different before
> >> our moving to CPU featuresets, and as such one could view this
> >> behavior as a regression from that change.
> >>
> >> The first question here is whether not exposing MTRR as a feature
> >> was really intended, in particular also for PV Dom0. The XenoLinux
> >> kernel and its forward ports did make use of XENPF_*_memtype to
> >> deal with MTRRs. That's functionality which (maybe for a good
> >> reason) never made it into the pvops kernel. Note that PVH Dom0
> >> does have access to the original settings, as the host values are
> >> used as initial state there.
> > 
> > 
> > Initially MTRR was supposed to be supported but it was shot down by x86 maintainers who strongly suggested to use PAT.
> > 
> > 
> > https://lists.xen.org/archives/html/xen-devel/2010-09/msg01634.html
> 
> I recall Ingo's dislike, yes. But them suggesting to use PAT when
> PAT depends on MTRR internally is, well, odd. Plus there continues
> to be the question why PVH Dom0 should see (and be able to play
> with) MTRRs, when PV Dom0 can't even learn their values.

Oh, I didn't realize the handling of MTRR in PVH dom0 was a question,
sorry.

I don't think it makes sense to limit PVH dom0 access to MTRR if that
then implies changes to Linux when running in PVH mode so it can use
PAT, and likely changes to Xen in order to avoid using MTRR when
calculating the effective cache types (ie: in epte_get_entry_emt).

I also don't think there's a need to have this kind of feature parity
between PVH and PV dom0s.  IMO we should expose whatever is required
or makes the implementation of guests easier.  For PVH we could always
stop reporting the CPUID MTRR bit and thus stop exposing MTRRs and
guests should cope.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:09:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:09:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317158.536362 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNZ9-0007IT-8u; Fri, 29 Apr 2022 10:09:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317158.536362; Fri, 29 Apr 2022 10:09:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNZ9-0007IM-5t; Fri, 29 Apr 2022 10:09:35 +0000
Received: by outflank-mailman (input) for mailman id 317158;
 Fri, 29 Apr 2022 10:09:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H4Mb=VH=citrix.com=prvs=111705440=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nkNZ7-0007IC-MK
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:09:33 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 75f2694c-c7a4-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 12:09:32 +0200 (CEST)
Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 06:09:29 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MWHPR03MB2960.namprd03.prod.outlook.com (2603:10b6:300:11a::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr
 2022 10:09:27 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 10:09:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75f2694c-c7a4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651226972;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=v4aGH0LY7DSQXbQ4BBcNhOcB0d8ZThMhBieDrvBzbmI=;
  b=GsTGmA0RYPnTlQ4gSk43TnQ6NcN2XizBmEsJf3b5V52BJ+/RLwlGCxaD
   F6kNyEMTbyF1t0uFifU3i5frLhkjZqcteYEnvSml35WYOykBTlGM1qfjw
   9ZjWYixOQHT26+3j4G27GLHaNKL2Kg06Nmen4dideQlLoguRFdZ/IgbhG
   8=;
X-IronPort-RemoteIP: 104.47.59.168
X-IronPort-MID: 70240214
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:gvE706A7sD9ZtBVW/1riw5YqxClBgxIJ4kV8jS/XYbTApDkhgzwOm
 jcWWTrUOP2PYTfzeo1/Yd+0/RkDvpDSyNM3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Jj09Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhcz
 8pmibeWTz4HJ4bivqcBDxJgOnBHaPguFL/veRBTsOS15mifKT7A5qsrC0s7e4oF5uxwHGdCs
 +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t3B8mdE80m5vcBtNs0rulIEezTe
 Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLGUC9ArP/PZfD2779AJAz7ayFNrpJfuRaMlwp0yG/
 m/G4DGsav0dHJnFodafyVqujOLSmSLwWKoJCaa1sPVthTW72Wg7GBAQE1yhrpGRmkO4Ht5SN
 UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM+e8CMU/4QCJj6bRvQCQAzFeSiYbMYJ28sgrWTYty
 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP45eEJpprUZwQ3N/
 g0=
IronPort-HdrOrdr: A9a23:+1so76sl9nQylxJyTuQMR4bl7skCJoAji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPiftXrdyRGVxeZZnMXfKlzbamHDH4tmuZ
 uIHJIOb+EYYWIasS++2njBLz9C+qjHzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf
 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIN/Z4StU
 z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfrWG0hYczGgNkGmpDp1L8Yqq
 iLn/7mBbUr15rlRBDwnfIq4Xi57N9h0Q649bbSuwqfnSWwfkNHNyMGv/MYTvKR0TtfgDk3up
 g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuI4O5gLZvtX+9Kq1wVB4SKbpXZd
 VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFoifA3jzMF7tYwWpNE7+
 PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94aLf8fEw/qWnaZYIxJw9lN
 DIV05Zr3c7fwb0BciHzPRwg2bwqCnXZ0We9iif3ekPhlTRfsuaDcTYciFeryKJmYRtPuTLH/
 CuJZlRH/jvaWPzBIch5XyLZ6Vv
X-IronPort-AV: E=Sophos;i="5.91,298,1647316800"; 
   d="scan'208";a="70240214"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SfQxH6pEdWSYqxMJOQnXqUr2g6ojscb8btb+cOxjaNrRRc6B9hvJqWafXI8hVeJeejaYdKyoRRH6ZgG/Rl0Ne+MCrzi7giu2YngrMnZo+//ZZoFxdChL/a2OI7RoyaqgC8z3l582YD4h6gRScATS/fttUSD7D42zj0ZsLoWf/JkKVQrBchZd/S81Q3hOX587AMxki+pAJN1Dc1/6kSvrtGCyec8vG6XxrKOr57eTgzcsZ48cANBT5pBy23zIXWpTeULCyjkhzx0S0XbTHsjn5UUBE3zJprDoTTF1WssB2RblA3EYmnVK4Mt2L625LfkI7DuVfFxHoo2YmdubI/MB/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v4aGH0LY7DSQXbQ4BBcNhOcB0d8ZThMhBieDrvBzbmI=;
 b=jjebge+MZtres0tXQu+NQQ1wEwAFWNPFQtJsMj/7hs2KP0Yy1W93CtuHceTNxKq3/xqFqfR62KLkRL9rVGfDn0lRVna46lbJNMinFqIHUpB5E67xaYqGILDUlR45DFuYVUO6ZeZHNcrq7rbOKPKpr/FotGPFGpuHwX1OIL8zd4OWf+1CIm4+83TXyAyNyStGHYDwQKCJ8jLI8wXF/kUY1PsOCGOZe3stGgWRnIxyWXorgTAhA7G+xmB9smujzCgo+ZkrvqwT1njuMk8OdOn7VwrQN5z3uXiG438LU4tAL4jQZvnZyyZErFOtR/fLowix1779DsezHeRA8U6YYxnnxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=v4aGH0LY7DSQXbQ4BBcNhOcB0d8ZThMhBieDrvBzbmI=;
 b=w4sPz0fGlzN76NU23N7J4f6HtUHn09NMjWwqs6GI1ieT/Msvcs0ATDOfQ8p94ERkEcH4H8DHjFCGcyaNnfME/W8T8dh6pb5h4vvFEBwY4RQ8RHZQp0sG3j3u3BM6USNGfFI7wx//s7qOhkzSdbi+qt9Ake5BpLe/lCU7Svay4KY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/cet: Support cet=<bool> on the command line
Thread-Topic: [PATCH] x86/cet: Support cet=<bool> on the command line
Thread-Index: AQHYWt1N9h0ywB7VLke90Ph7I2J/jK0FG36AgAGRL4A=
Date: Fri, 29 Apr 2022 10:09:26 +0000
Message-ID: <47e0a51e-e443-9ac6-fd22-33adeca4ee86@citrix.com>
References: <20220428085209.15327-1-andrew.cooper3@citrix.com>
 <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
In-Reply-To: <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4d745954-5228-4460-93e5-08da29c857a0
x-ms-traffictypediagnostic: MWHPR03MB2960:EE_
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
 <MWHPR03MB2960A4FD4E8BE07D72EAE81DBAFC9@MWHPR03MB2960.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 akX3xa5QA/tDu3YOXNX8VWh/g5TkMT0jRwlhzUCUwV1Y0UuxWbpMf159+82LMq8BTqoipIY7PQJVDcQtDksy8SSa0rok2wpxEP5gqROy14oDg5K8j4qrGI0kZSS1rEe3O3SgX0CuXMhxS4exW6jyiczQCNLKfxb2Y74dxe9bW1RsPKAJYs6QqEaAZXV/dYEckMOX5qO9A+4LWAdToLyY4Z5wNQtiBpfhRcUNKoOZ712/oNjKpy9IkWI7Vdrf9Gl+awbrdPMVTl7H6y/0yatbYA+C6Jp81OQWbe3uujDujjwn12BVp/eveJtbBAvlayS0n88teSyyX208qAKJsOPagw9U5j0/TVtdmkLviufIF1tfVBpYqo5OtduO6roQ/KtHBuL4s7ZOUykiha314Jyg83P0K3y4uIItuie5JwTfGOb2O13IXuYMVAMJLXKiHegnVLHRljDk/P4spIm60mH5KEaVMAcmjLkvAW6kLtJ4sIhw+kaVgfx36L6r5mGApqBO5DAFVPI3ewIIDU81APEWLC8ZdFbWkvZ5tHFV0XVlcWlF9PK5VM+r9/AdX0+L7GBICDZQWm5xvqXa9uH+y+epo/Fbm79gl4qh4Oz8jz9RqSVH5GwMH8b4bXm+O/v0o0FLUGE/9XhArOV1Cg8zwphk6ySaOdgIIMannXNMF9xE3wn1LDwzrNGNGJmsNiv1G/sdvUyBXFBcQt43Rz8X0hEhf7fRoj+fSkEKQsEZMH1OoiwLa1IuIaegeJv2rR5OquMt9LemYDi9//gh4XJDUIjZqQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(38070700005)(66476007)(66556008)(4326008)(66946007)(76116006)(6506007)(31686004)(53546011)(36756003)(31696002)(64756008)(6486002)(186003)(8676002)(91956017)(66446008)(71200400001)(54906003)(4744005)(6916009)(6512007)(2906002)(5660300002)(508600001)(316002)(86362001)(8936002)(82960400001)(122000001)(38100700002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Q1dQZGNvODRaQUZkRDBYYVN0TW05UllMVUtSTXFIR2VzSStnUXBhRlozOVlm?=
 =?utf-8?B?UzFKV3dVRnZ1MXBQN1JwOGNvVjUyM0ExVWx3NWI5RFNTUDl3bmY5UWpSQ1Jx?=
 =?utf-8?B?dVBSa1BOZWZOdVpkdUVFTnhWWXR1UTh6RWtIM2ZuT2FUYlVhR2dLblhzZDND?=
 =?utf-8?B?djROSU9QSFRCZ0pwUlY5Vm4zcFUyM09tYnByUTd2c3BmaWptdGJtTjAwMXRP?=
 =?utf-8?B?YWdtbnNhYWJQMzNFSnpVOWJVWk9Ecm1GMGc2dkpRL3pEcEd0Uk16amxHTFcy?=
 =?utf-8?B?eVM4RVMrQ1FrODVFOEVIaGdJdEJMQ2tBSE1yVXFoMlFOaTZONlVpeWpQcmcr?=
 =?utf-8?B?SzVjdDVHZXovdXB3RHZTSVQ4elRjZlZrb29uWlhRZ2VOdkQvSWRjTlRheFdX?=
 =?utf-8?B?VEw3ZmFiOTZTdTc0NkhzZzZzNmQydnlnRzVwSWh1K1VtTk5Ub24zbk8rV2Fr?=
 =?utf-8?B?d1QzeUJVOGZJVE9HcEZQc1A5ciswYmJmbzRjbm5wNTlBV21CSitvYWtTVU40?=
 =?utf-8?B?emE4OG5qSEk0QVFDa28rdlRneUNMeHo1aTlaelFsT0ViK21Bb2dGQXB4K3BE?=
 =?utf-8?B?dzZPbDhETHp4MTNEY2tmWnRYUkVBcTZOOW15YnJNa3VaVzAyR05STDhxS0tL?=
 =?utf-8?B?UkZMcFhIU3NiTldBNjZ6NHVOcys5b1F0RjVlRXdUMEdJV0F6ZDZ3eWZOUDdB?=
 =?utf-8?B?bEZQUXNrcy9yK3I1TUEvRkI1c1NrQzBFNEhtNGVIVGpmMG9IbndkcHhiWjRh?=
 =?utf-8?B?QmJhajgxTDVsRndZcW5oZGh1aEVxTEduTlBGbXh1dnRjRVBqS21RL3NybVNq?=
 =?utf-8?B?NHZPeTBjRWFmNzJDL1M3dlpvSi9TdDNRd0VpcGt0eGZSclU2KzlqZUswQTFs?=
 =?utf-8?B?ZUR2MmV2ejN2OExndkYxdGVET3FTaGdJWVBmV2tMNUdMazFWOW53ZmZObzNN?=
 =?utf-8?B?bE1pNTdqTVA5dHdwSUZnQ0lqV0EvTzAwY0pBWGd4ZDdaUlVlUmJTMCtuZzlu?=
 =?utf-8?B?S1RreXgwRGFybTRVSFpHam0yU3ZJbnFjTGZ6RWQ2Zk5oeHJoYW9OL1ZFWjNK?=
 =?utf-8?B?ekxGRmhwK1BpaTBpSEt2Z2IxMmdRYmdrWFVzaGQ2RS8vMmh5cksyRktaYS9j?=
 =?utf-8?B?TlJ4b3lLZUJHM2g5enNmSnBqSGc4U3o3b3hxYVcwSWE3QzlCZTlGamUzQ3Rh?=
 =?utf-8?B?bUNhdUVXU2U5U2U3MlRRQ2FOZ2FVekU4QXlXRGh6RE81cGZuSVJFcE5QVmpK?=
 =?utf-8?B?STFkMGNGRXVtNmNpQlUzNW1GRkJBTDdNV2t0cWNPakNHRk9nTzZlVC9xMW9T?=
 =?utf-8?B?L0xsUmNPdFBPQVhrS3N5NzVvaWJ4aVpEUEs5UVpzdTR2WnA3RXIzMVRrSXow?=
 =?utf-8?B?d1dDeGZIOW5vV0pTWWsvSURoVE1aZWMwV0ZjMWw5eEJ0NFFoQVFQb294THJV?=
 =?utf-8?B?eU9MTmFmV1RveldGRlZ6NDZtdzdDbzNQZ3UvcFA4eDdTRzB0Yjg0cEd1cEw3?=
 =?utf-8?B?VGRQMTNMNG1MbEpNVXJRNFJtTXR5d0c3SDBKNDlDTERTMVhIN1hXNGgxQVBR?=
 =?utf-8?B?SHl2NmZLWXRWUm5Zd1NUdDVjUHJVZk1haGx5dGI0YVhCbDJ1aFN1ZHpLNk8w?=
 =?utf-8?B?VlR6aE50cHRJWTdQdGpuTTB4SkhvbmZWYkNtMHhVeWxxR09Kb3hOTFBsS01j?=
 =?utf-8?B?amFqNnFGU2lzQlg1MHFyVS9OYnV4M1A5U01YYktrUnp1VXZheFR5cHhxaDkw?=
 =?utf-8?B?dm9aZEI0WUs3N09qZnNPTmxqYUJYdXRLUVNwOWpGT1RuWUI5RzhDcW5RZktk?=
 =?utf-8?B?UWkvbXhuUWxEb04zZGNwekszZC9YODd2WTMvalVPb1pDcUhPRG1QWTRTUWRa?=
 =?utf-8?B?L24xSkZ0cmZsWjdibzNkYlA3Qk9Fc0RhNng4cGdPcFdFSTIzYWdZUnc5QmFK?=
 =?utf-8?B?WmFwK0lxQlM2N3M2bUZkZFdPYVBYWWFGZENqTEdPVjh5Q2VTNlM5Y09wL1F1?=
 =?utf-8?B?OXgyenljR3E1eDFHa0tmU0JERTh3WE15UjROeGtwVDIyUlN3bHRxRjBiRFRQ?=
 =?utf-8?B?N014YlIvVlVkckI1WE9xcEdqUVVZMmpDTUJYZnhwOFIvcFZPc0Nsc1hqOE9q?=
 =?utf-8?B?aTRaM01IcXdINllBMDc3RFVoaXRZNlBneGhDVE1Ia2hqTWROUEZRcW9MVndE?=
 =?utf-8?B?Tk5oZUlOZTlLZDFuZ2pibmVxNTNjZXdvWTdoUUpIZXNFMHRlZVZYVGFtTGhu?=
 =?utf-8?B?R2ltM0lmaUZHZWluZ093cUtTZ3VzSTVhZ1dVY0dLMnNqRmtyZFpGSkhMWFN0?=
 =?utf-8?B?V2tmZlF4Y3JYVFFyaGlEVnorSE05eWN4NERsaFlPOUdJMTlxYWhOdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4F9EB8C34F3EEC46A766412490FC3D91@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d745954-5228-4460-93e5-08da29c857a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 10:09:26.6060
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ttLP/fzpj+6uzhOskCkc2aYFg2fiUKKMe2Tv4yWTKxqHq/L8gY6kWaZPNE8CTJ6gtz7TJZ6++oKnoswF7omcbZVZT14YVGA0fRei510a16A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2960

T24gMjgvMDQvMjAyMiAxMToxMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI4LjA0LjIwMjIg
MTA6NTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBAQCAtMjgzLDYgKzI4Myw4IEBAIENFVCBp
cyBpbmNvbXBhdGlibGUgd2l0aCAzMmJpdCBQViBndWVzdHMuICBJZiBhbnkgQ0VUIHN1Yi1vcHRp
b25zIGFyZSBhY3RpdmUsDQo+PiAgdGhleSB3aWxsIG92ZXJyaWRlIHRoZSBgcHY9MzJgIGJvb2xl
YW4gdG8gYGZhbHNlYC4gIEJhY2t3YXJkcyBjb21wYXRpYmlsaXR5DQo+PiAgY2FuIGJlIG1haW50
YWluZWQgd2l0aCB0aGUgcHYtc2hpbSBtZWNoYW5pc20uDQo+PiAgDQo+PiArKiAgIEFuIHVucXVh
bGlmaWVkIGJvb2xlYW4gaXMgc2hvcnRoYW5kIGZvciBzZXR0aW5nIGFsbCBzdWJvcHRpb25zIGF0
IG9uY2UuDQo+IFlvdSdyZSB0aGUgbmF0aXZlIHNwZWFrZXIsIGJ1dCBJIHdvbmRlciB3aGV0aGVy
IHRoZXJlIGFuICJhIiBtaXNzaW5nDQo+IGJlZm9yZSAic2hvcnRoYW5kIi4NCg0KSSB3YXMgZ29p
bmcgdG8gc2F5IGl0IHdhcyBjb3JyZWN0IGFzIGlzLCBidXQgaXQgdHVybiBvdXQgYm90aCBhcmUN
CmFjY2VwdGFibGUuwqAgInNob3J0aGFuZCIgaXMgYm90aCBhIGNvdW50YWJsZSBhbmQgdW5jb3Vu
dGFibGUgcXVhbnRpdHksDQphbmQgYm90aCAic291bmQiIHJpZ2h0Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:13:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:13:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317167.536373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNcb-0000M8-T6; Fri, 29 Apr 2022 10:13:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317167.536373; Fri, 29 Apr 2022 10:13:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNcb-0000Lz-PM; Fri, 29 Apr 2022 10:13:09 +0000
Received: by outflank-mailman (input) for mailman id 317167;
 Fri, 29 Apr 2022 10:13:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H4Mb=VH=citrix.com=prvs=111705440=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nkNca-0000Lr-0I
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:13:08 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f5b102ae-c7a4-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 12:13:06 +0200 (CEST)
Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 06:13:03 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BL0PR03MB4289.namprd03.prod.outlook.com (2603:10b6:208:6c::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Fri, 29 Apr
 2022 10:13:00 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 10:13:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5b102ae-c7a4-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651227186;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=DGh/0byfFRU8xIAivoRv58VSMlQk9CbyKKjdEbA8ltc=;
  b=B96CEZ8IUCyKcbG4zff+rdsjVJ0pt51/pLe/05kV9IMGOXAiSeOaseaK
   nclaMbkRQvtZQnfbRaNaKkIvNS1Cni28WLku4k3TUS4kvfBEteh+Wk1jf
   yf3c94TUMWWapdWRu6qaiiOVWjMSKbSutmsKpoaXuXKhwNJKdx+r3OWwz
   Q=;
X-IronPort-RemoteIP: 104.47.55.103
X-IronPort-MID: 70240393
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:orY6U6nWKtKGDgtcPaeijSbo5gzyJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIfWWiGO/fZMTT0L490a42/ox5Q6JbXz4dgHldl+Xw0QiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DlWVLV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYURlyL5zspOchYwBYIzhEYYBFybqXGC3q2SCT5xWun3rE5dxLVRlzGLJCv+F9DCdJ6
 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBhGxYasNmRJ4yY
 +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVvuTSLl10quFTrGNmLauKEZYYPokWnh
 jKZ+ETlKTocZOXKnFJp9Vrp3IcjhxjTWogfCbm5/f5Cm0CIyyoYDxh+fUS/iem0jAi5Qd03A
 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52mwJrH85g+YAi0BUWRHYdl/7MsuH2Vyj
 RmOgs/jAiFpvPuNU3WB+7yIrDS0fy8IMWsFYixCRgwAizX+nLwOYtv0Zo4LOMaIYhfdQ1kcH
 xjiQPACuogu
IronPort-HdrOrdr: A9a23:lWGCEqHlWSrLp8XfpLqFuJLXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNFICPoqTM2ftW7dySWVxeBZnMffKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj4Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWna4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlWFtyssHfsWG1SYczEgNkHmpDo1L/sqq
 iUn/4UBbU215oWRBDsnfKi4Xi67N9k0Q6e9bbRuwqenSW+fkN7NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxEC3fLFuIYO5l7ZvtH+90a1waR7S+cQiCq
 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm0UxR3g8d3ogSj30A/JUyR91N4P
 nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXp0vKjbIsdr68b817OaldNgBy4Yzgo
 3IVBdCuWs7ayvVeLuzNNEhyGG+fIx8Z0Wb9ihz3ekIhlSnfsubDcSqciFcr+Kw5/MCH8bcR/
 G/fJpLHv6LFxqbJbp0
X-IronPort-AV: E=Sophos;i="5.91,298,1647316800"; 
   d="scan'208";a="70240393"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TpbhQn83+6ZaWx2h7X5cLGGRcxpSFXjbyNfGrFGLPA3uSwsMwk4i7inlJOYJduzxbpFg23fDdeEPshwmwI8kz/+iHNAo0fuzCRlgt8TqLBx5DlCuIzsqjCMrcv6b4/BGCXcgdxG8FAf5BhEyv5cKho6p3xWgGEE4tSMML860wGHzR05n4j044xcP5Qz5ZvtFCJ1VB2HR+e9+PbI534WIT4OMigGNZSQ0NkYakk7hxo+5dwCu4R9Amuv1M6pfCAELEWZdtdtaxbugcDWRfm9ueOOSgFYg+6Qs47fGnsKNqMu6hxUHKmkvz066Vlpyj40NbWzNEq5yDPdF8/48oM+1+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DGh/0byfFRU8xIAivoRv58VSMlQk9CbyKKjdEbA8ltc=;
 b=Rej+ccy/s+xkhwNoi2LlHlmzXGy3FIFKLSXcKKV83zk8JcY8OfwYEgd+4FA3S+/eXVtWahtL23bMcIkfOeRbK1sGPOcTLFRApk3lp8d4o8HhsnQ/NLuunEEytIo9kGg0y8Bbl6p298l6SCG50J3Cx6lsszivDgdx2bbTW2N+kjYFm+FuYno6O3BDcjxeHFIHpQfU7nWulAbX6fGbJgbzX2tWe52CGoTtyBAv3TC9cAXeQU3qW5aVnd9d1IgayO7i2ZhYVlrDWcTad16PD+ugeytT8Pzpjbzrpo6FtKMLVrAQe3HQz4wu7lqEe78Gx5QAvMPCFq0X6LXuITMC5hkFdg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DGh/0byfFRU8xIAivoRv58VSMlQk9CbyKKjdEbA8ltc=;
 b=gznAyn9zSzP7kPTZl82UGK7xRleXJ6AyHhi4txg+kSFS/BV6NPI3nqwXTQzQ17j75UAI0j2SHel0iiWq46yjQ0GzE1yePKH76Ij7pSCptqCtNBGvdAb8d1cdW0/yiJIbCt65GyNdOXlmcZYTGN9kQFgzsrW8mxHbBb7n+8UHSn0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/cet: Support cet=<bool> on the command line
Thread-Topic: [PATCH] x86/cet: Support cet=<bool> on the command line
Thread-Index: AQHYWt1N9h0ywB7VLke90Ph7I2J/jK0FG36AgAGSMAA=
Date: Fri, 29 Apr 2022 10:13:00 +0000
Message-ID: <26f1d8e3-597d-31a7-00bc-f17efeeb3e55@citrix.com>
References: <20220428085209.15327-1-andrew.cooper3@citrix.com>
 <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
In-Reply-To: <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 94c3b591-e933-41f5-67ed-08da29c8d70f
x-ms-traffictypediagnostic: BL0PR03MB4289:EE_
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
 <BL0PR03MB428902A25259850F9F9CBE03BAFC9@BL0PR03MB4289.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 o0tcrBpNWDG1Bxps95s9CyWc+RNvtgqRYLYJpE/Y39gWcMVhvdJmkSL83J47IgnYp90atNAvi5ilAfN1eqge+I0Uv5fG23llR7AY5fYFV5GO2kq9v2azVTFPDE6sVA+5nszY7F9tS9w9ctFnRBjzgrrIG2DhelUB/cVGK+8EkHo3ZmrSKYD6PPOSxuMG+5HuEWMT1AXP8aaapA9NxqDHHlAKaCAvQ1EuvaoGInrpy4kgQ8N/tRxVhfh9hYGPPW9xbaOgWFLu/z6wVn4tuE3vT2YECGHhfiVBDRdTWRBYwrZgKfWMIug+eVHFgZNblkLIqR2RQfmQ5/tZOIzckwC3s1mqj/54QFHSaZEfsQokHdmYGHV6pf9s9IYQBexc71O+tSrfZMqi5CwwIpFVblWanREuKQkBKFF9CGRNVMXceQ6vfAXOnlCQYME+Z7pXx4yTTK4tfQcJbXEtr+gkV+9CS8mTPgrTBaoUeqP30oguPJUUkVfdyQVu6mCeBx97MrNxJ7pv7q+ZOdA7coSy11LATW5p1pnugCuO7tCYmIOThxpmMQYrULAxZOVjDqDRP6Vj3+Lg6j5C8e/JA7aHQEra4S4Upitq764kW6DRglMMVyDNP6/d6aJP7AvOO+R6gCToVfxptnCKnu8v7EpUBJJsdkFpoGzAOz/ROqQnAUsHOZebDbeJ/UzzBvrF6NSNYIdGzSgECsC80quROyEthvbv+u/EpHkECflVnNfI2Qq1WfPmg7XP32VVk1/8R8qxCmKoOz8q7R0vL2bkkCMue/+x3A==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(71200400001)(31686004)(508600001)(2906002)(8676002)(6506007)(66556008)(66476007)(64756008)(66946007)(66446008)(8936002)(76116006)(54906003)(6916009)(4326008)(38070700005)(2616005)(82960400001)(86362001)(38100700002)(316002)(186003)(31696002)(53546011)(83380400001)(5660300002)(6486002)(26005)(6512007)(122000001)(91956017)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MGFzc0hBNVdOZXhaZjFDSUtpaUtsbk13Y1o2QXdPdVp4K2xsbll0Myt2eURr?=
 =?utf-8?B?Skxpek5RbXp0VVdKVHR0RTQxME1EbVdQMzllak83MnB3WVRzZW41NnE0aGl3?=
 =?utf-8?B?b1p6M1BSa2dhejVUaHlMNWZMQ3krYXRrREM1bWxneHZJSXRZaFZRbFFQaW1q?=
 =?utf-8?B?VzZGZ3EvMnA5TDNIVGdPb0cwS255dXhnMlZiT3h6VzNrWEU3UlB0YXVuODNL?=
 =?utf-8?B?RldDbE9UdFJpN2RKSTlUYUR1SEtkdzNXSmEzL3c4Q1dXS01pbU51a2ZYZmtp?=
 =?utf-8?B?K1hXbmZBT0hFY0Njejdrc25abkJrcnBDeHh5RjBUcFJ0MWN0M21NVGEyYzdj?=
 =?utf-8?B?K1V4U1hnL2N4UTVxRERxUVJ2ZUtyazRwNjlqUzk1RW5lMUNFWXd0V05ZQWpN?=
 =?utf-8?B?Sis0Yzh3WUNEajNDWDRWM0F4UENkMXdRZFptZENRdTdZTzRFNmh4QklVTVFo?=
 =?utf-8?B?V1VKWjJvQklLVGVndEN0Zlo2RWhtV0xNQ2JHR2pvTnp1OVNiZnFheUcyWjZi?=
 =?utf-8?B?MHR1NU5CSThINFRHMm05YkkrcGEveXZWZXZZTHBmbSsyb2JPTFhQOFovaUh0?=
 =?utf-8?B?NmFjZmNIckdrRkdrK0pEcjJlejBNV0tVTERsbWdnelFDdEJRNE9ReVJXUUVr?=
 =?utf-8?B?YVNOWlVISG5rQ1VyZElBNUltOWdueVNIVVdieUdpUkwzU1JXTkxNdk9Fdmpl?=
 =?utf-8?B?aTc5UXNpamFLRjkwQWxlMm4rRG5TQkZ1ZTduWTlEUXAwQXZRYS9oaWUrUGdq?=
 =?utf-8?B?ZGxxMTROcWlyd2dPU1RWVHdjUW5vSmJJNW1qb0xQd0tPOUFjdTR6ZS9wK28w?=
 =?utf-8?B?L0xadnhiRGMwek80SldHelN3a1dZQTJjdHVKS1A3SzU4aHZsdmU5R2tsWXE4?=
 =?utf-8?B?ZnhrY2EvT05YdE1YWmYzSHBDVThxaFc2S0Qycy96VFBCRCtPSXp3enN2V1gr?=
 =?utf-8?B?L00xeUVad2dFTlBUTVhoZ3M2bW1xMlg3T1o3c21HekNMVSsxanArbmRNaEI2?=
 =?utf-8?B?MDUrREtQdkZ4M0xDaW8xZFVlNUVzcHpFMjhrSGZDM3RBWW54elRJbVVBNWpl?=
 =?utf-8?B?T01pTDNraFcvakoyWnpJZ3hVQUdTVG9iUnBUMjB5NFZtODQxeFh4WmJGREhS?=
 =?utf-8?B?TzlSWjRwVVVCQ1pMaTFHV2xZNm9HaVcrRGhmV1l1b2tyUzZxRGtMcVFGanJv?=
 =?utf-8?B?dzV1eGlWQ2ZFRW0wQ3JHNG5oMnh3SmRyVDkyeWNTYlhidU9kN0hiOHJVRThr?=
 =?utf-8?B?ZTIraVhSYmp6R0RwVEJ0TjVSYVFmdDVBaldzSitHSnRLMHNNSXZQbGc3TENt?=
 =?utf-8?B?Q2Z6RHFnUnpMTkdSQldnSmdiMXJlcU9vcjNvbFZHMWJpZVJoRUFYclNIKytW?=
 =?utf-8?B?bXdpQURPU3YyTGt5VHkvbHphN0g0SkY3dkZ2T3dmeGFMK05ScTBkNjlkNnFU?=
 =?utf-8?B?V290Wnk5ZXRldEJLdFF5S3NDUEVnaWdhYXVnWmdweHJGU1F6TVBWN2Y5bURo?=
 =?utf-8?B?YlFTblZxTjZoMGdzTlIzek8wYk0wWEtwYjF1YmdPUk1OWWg1SkhzMWJ6dFpq?=
 =?utf-8?B?a1R4QUlJZjBBczZKMExZZVZibmdKVTR4OGVrN2NCRGtXT3o3eDFSb2hXVnlN?=
 =?utf-8?B?Y0dTV3o4UDB1RTJEcVhWelNtVTBtZnFCUi8yYUFCcmx6ZXhzNHJ0MFR6cVlu?=
 =?utf-8?B?M1ZIN0VER0ZWQWFQSEpQNjJGWkI4ZERnUHppNzVQN3ZhSCtKd3NXY0hBM0Uy?=
 =?utf-8?B?Z3FoWGhVMnlUeXhUVEgzWlhVWmQvcGV3d2k2Z1ZsVlAwOGpUL0ZmRFYrODZW?=
 =?utf-8?B?Zkp4eUNsZXhsbWhzYVUyTyt3QzVDa2hXcW45eDgxQXJBSmNpWjJUb2VyRGxa?=
 =?utf-8?B?YWhLbSt4ajE3K2tpbUthRHFjT1MrbTdiOFVhek5pVVNhME9OZzVCbFdGMzBB?=
 =?utf-8?B?aGRsNUdWcEtRU2twMkVzQlZhWGlZQytFS2N1S0Zoc0txM1B6ekh0NmVXc2xo?=
 =?utf-8?B?RGdrczdham5pMlhaZldYUEY4YzhDRktQWk90Vlpuc2l5eU5Kc0dlTmZCUG9n?=
 =?utf-8?B?VGJkNkJLa3l6TnNZRXlVZDd4NVhCakphYWd3Y3Z0Wkg4dXhTWHVURFl6RXg1?=
 =?utf-8?B?TS9vSXNVZ3VoVTNoUXJlZm1aZXN3UDdHVlNQT0pnLzBhbzhMTmJ1YWQ0aUY0?=
 =?utf-8?B?Z3pBMnNmZS8reFBvdjlTZ2k5L25mNXgxTW1QZXVUMlRrdVlGcTZreGJZODE3?=
 =?utf-8?B?ajlvdlNzOHJGLzY2ckg3TExST2F1aXQ2bituRVNpNytqem93RnFNQlpHWFlK?=
 =?utf-8?B?Yk5xNnNCTTlMTHZFUWRHVDV6WkEwdVlKV21hbFZ1SXU3a21IaXRHZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F4AAAA6C00B7CB488CA38F0E4CE541C9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94c3b591-e933-41f5-67ed-08da29c8d70f
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 10:13:00.4343
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DmG3hwSpA0HXH/IH0ZUmCmq5R/NkQwcN0CbO7DnI6FfxIa8HUQfrUtECJ7crT9jk0ooEtdT1rqJiNvVbB8+A/nzar+em2rqCFyHNigN+EAs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4289

T24gMjgvMDQvMjAyMiAxMToxMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiAtLS0gYS94ZW4vYXJj
aC94ODYvc2V0dXAuYw0KPj4gKysrIGIveGVuL2FyY2gveDg2L3NldHVwLmMNCj4+IEBAIC0xMTcs
NyArMTE3LDIwIEBAIHN0YXRpYyBpbnQgX19pbml0IGNmX2NoZWNrIHBhcnNlX2NldChjb25zdCBj
aGFyICpzKQ0KPj4gICAgICAgICAgaWYgKCAhc3MgKQ0KPj4gICAgICAgICAgICAgIHNzID0gc3Ry
Y2hyKHMsICdcMCcpOw0KPj4gIA0KPj4gLSAgICAgICAgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVh
bigic2hzdGsiLCBzLCBzcykpID49IDAgKQ0KPj4gKyAgICAgICAgaWYgKCAodmFsID0gcGFyc2Vf
Ym9vbChzLCBzcykpID49IDAgKQ0KPj4gKyAgICAgICAgew0KPj4gKyNpZmRlZiBDT05GSUdfWEVO
X1NIU1RLDQo+PiArICAgICAgICAgICAgb3B0X3hlbl9zaHN0ayA9IHZhbDsNCj4+ICsjZWxzZQ0K
Pj4gKyAgICAgICAgICAgIG5vX2NvbmZpZ19wYXJhbSgiWEVOX1NIU1RLIiwgImNldCIsIHMsIHNz
KTsNCj4+ICsjZW5kaWYNCj4+ICsjaWZkZWYgQ09ORklHX1hFTl9JQlQNCj4+ICsgICAgICAgICAg
ICBvcHRfeGVuX2lidCA9IHZhbDsNCj4+ICsjZWxzZQ0KPj4gKyAgICAgICAgICAgIG5vX2NvbmZp
Z19wYXJhbSgiWEVOX0lCVCIsICJjZXQiLCBzLCBzcyk7DQo+PiArI2VuZGlmDQo+IFRoZXJlIHNo
b3VsZG4ndCBiZSB0d28gaW52b2NhdGlvbnMgb2Ygbm9fY29uZmlnX3BhcmFtKCkgaGVyZTsgaW1v
IGlmDQo+IGVpdGhlciBDT05GSUdfKiBpcyBkZWZpbmVkLCB1c2Ugb2YgdGhlIG9wdGlvbiBzaG91
bGRuJ3QgcHJvZHVjZSBhbnkNCj4gd2FybmluZyBhdCBhbGwuDQoNCkl0J3MgdGhpcywgb3I6DQoN
CsKgwqDCoMKgwqDCoMKgIGlmICggKHZhbCA9IHBhcnNlX2Jvb2wocywgc3MpKSA+PSAwICkNCsKg
wqDCoMKgwqDCoMKgIHsNCiNpZiAhZGVmaW5lZChDT05GSUdfWEVOX1NIU1RLKSAmJiAhZGVmaW5l
ZChDT05GSUdfWEVOX0lCVCkNCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbm9fY29uZmlnX3BhcmFt
KCJYRU5fe1NIU1RLLElCVH0iLCAiY2V0Iiwgcywgc3MpOw0KI2VuZGlmDQojaWZkZWYgQ09ORklH
X1hFTl9TSFNUSw0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvcHRfeGVuX3Noc3RrID0gdmFsOw0K
I2VuZGlmDQojaWZkZWYgQ09ORklHX1hFTl9JQlQNCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgb3B0
X3hlbl9pYnQgPSB2YWw7DQojZW5kaWYNCsKgwqDCoMKgwqDCoMKgIH0NCg0KSSdtIG5vdCB0ZXJy
aWJseSBmdXNzZWQuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:31:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:31:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317175.536384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNtw-0002mZ-Eh; Fri, 29 Apr 2022 10:31:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317175.536384; Fri, 29 Apr 2022 10:31:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNtw-0002mS-BT; Fri, 29 Apr 2022 10:31:04 +0000
Received: by outflank-mailman (input) for mailman id 317175;
 Fri, 29 Apr 2022 10:31:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkNtv-0002mI-3L
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:31:03 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 758b9ed7-c7a7-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 12:31:00 +0200 (CEST)
Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 06:30:57 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BY5PR03MB5202.namprd03.prod.outlook.com (2603:10b6:a03:220::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 29 Apr
 2022 10:30:54 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 10:30:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 758b9ed7-c7a7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651228260;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=PgjE1s4K8ADDAB0sRXajJd/m9wMCDG44D/TvRHrN3lY=;
  b=JXWSNQc66yjiNeGjOGtADfMlhrRqnYbmzmlfT4rwLa8iKjjTI5VV9b3e
   Ebcv2ukbz/0rxbIITS+wIVizuGfoE4D8um2kndDiLtA4/48UHRCh2TpKa
   cNScFA2ciCHpuBGaqAFM6ANS+jEyvnyp+KinOeS8s+euVR5O06Vv95ibW
   4=;
X-IronPort-RemoteIP: 104.47.59.173
X-IronPort-MID: 70219840
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ErFHU67Y4xAfzphC8KrZngxRtA3GchMFZxGqfqrLsTDasY5as4F+v
 mQfCD/Xb63fNjT3KI9/bYzn8k9XuJDWnYM3TAE4qy8yHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YTjUlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSMVAgJIfLRvtgwDT9JLgVbPoF/9YPYdC3XXcy7lyUqclPK6tA3VgQaGNNd/ex6R2ZT6
 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfibo4YHh1/chegXdRraT
 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA8gvE9fZvi4TV5Alv6IPzHPrxQPrQQpVXukPJ+
 j3v1l2sV3n2M/Tak1Jp6EmEgfTUgS7gRMcbGLi58NZ6jVuL3GsRBRYKE1yhrpGRmkO4Ht5SN
 UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JSHPc98xql0bfP7kCSAW1sZhxrZcEitcQ2bSc3z
 VLPlNTsbRRlt6eUUjSa7auOqi2pOjk9KnULbisJCwAC5rHeTJobixvOSpNvFfCzh9isQzXom
 WnV9245mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5
 xDoR+D2ADgyMKyw
IronPort-HdrOrdr: A9a23:k3Tw8KDK9LQt4cjlHej+sseALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPEfP+UwssQIb6K290ci7MD7hHPtOgLX5Uo3SJTUPNgGTXflfBOfZsl/d8k7Fh6JgPM
 VbAtND4bTLZDAQ56ubkWqF+r0bsb26GdWT9IHjJgBWPGZXgs9bnmJEIzfeNnczaBhNBJI/Gp
 bZzNFAvSCcdXMeadn+LmUZXsDYzue7267OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFqQrk/a+u2svLhCM0llWjrqi+quGRieerN/b8yPT97Q+czzpAUb4RG4FqegpF5N1Hpmxa1+
 Uk6C1QQ/ibo0mhAV1d5yGdnTUJFF0VmiffIZjyuwq7nSWxfkNFN+NRwY1eaRfX8EwmoZV117
 9KxXuQs95NAQrHhzmV3amAa/hGrDvCnZMZq59ks5Wfa/ptVJZB6YgEuE9FGpYJGyz3rIghDe
 l1FcnZoPJba0mTYXzVtnRmhIXEZAV5Ij6WBkwZ/sCF2Tlfm350i0Me2cwEh38FsJYwUYNN6e
 jIOrlh0OkmdL5dUYttQOMaBcenAG3ERhzBdGqUPFT8DakCf3bAsYT+7rk57PyjPJYI0Jwxkp
 LcV04wjx97R2v+TcmVmJFb+BHER2uwGTzr18FF/pB8/qbxQbL6WBfzPGzGU/HQ1sn3LverK8
 pbYqgmcsMLBVGearp04w==
X-IronPort-AV: E=Sophos;i="5.91,298,1647316800"; 
   d="scan'208";a="70219840"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ocQSFPZjQCXIqcDto1YuPQ2IECsabOm3TjqvGPJL+ddCcvnzvpPVAsRJUk0PlwJJTYJTqa9GG9K2Z2k6hAApO2zxzizydcEduCj1QS9LgBpRAXVyY07uyUoJXM/eYKAwJIq2pTl0UFHVG8DGyYj8obPp+Cdq/WzilNSfjUNYHjZCMa6/jjgq2S+naXuHq1MmzoxZ2snoxv7ZtIVj1cqQ81KtwdYdxKIuAkvcCLIugrATkZeOY1Q5ohMh7oB75hUKtRbv42raOCjueHnXYE4JnWApEbGVvEIklqeBmRBmVp+wxR9lMlLXKtzgKA+OAaHMLAh+azcSvfk2LGPZ9EWxcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=59j5mz3u8ZF0PqWfok6mKKzC3zhHwI576gux0R3uzmE=;
 b=QI1B9wihTjO4HNRmYznzyTshjEyFNEB3m+4df7MxDWfivTXIOZXfZAVxRuNK3sOyYH/jJAT5rRaC8taY8mPyPeI2cHze7fAURa7FoyAB73HikytvXIcBMQPeRHlKR1cTl+kBxHtnzO8cQ0FlME8aBbNH+sitzLdxUkM8udzHzcMG8TAwuAzFuRRvqIKrKxHp3ulRZ415pWOtvfzgrAYiFDkif7dI5WP2xLUejCpv6rP4sdPVO3Xdh/6JXE/C9wBVXcm+LnV8aUPARWrFgiYj4vIkkK5YSARwZQzryT9vLXfxGDGbK+4Jq3nUn4wcRER1r8HrNNXCaQ1MjfrSreWZCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=59j5mz3u8ZF0PqWfok6mKKzC3zhHwI576gux0R3uzmE=;
 b=UEK+zURLFAFMUC8vnbrjhi8Fx+hYLCYcOf4SowZ9dhAOnsS1QFS2hXuNBJlIY2HHQXElfXSqtcWDkGdRIZxjNMfq6VU0kmo5fFCreRABuRNvtStbm/svLeFfvMg25Z5PsMLX8+gqmxfMf9l5+XpDq9l+Jl/NxmNNHtcO3a9FM4A=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 12:30:50 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: osstest service owner <osstest-admin@xenproject.org>
Cc: xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Jan Beulich <JBeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [xen-unstable test] 169819: regressions - FAIL
Message-ID: <Ymu+WnVjTANHk+na@Air-de-Roger>
References: <osstest-169819-mainreport@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <osstest-169819-mainreport@xen.org>
X-ClientProxiedBy: LO4P123CA0347.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 12a2ae01-0281-412c-6ea4-08da29cb572c
X-MS-TrafficTypeDiagnostic: BY5PR03MB5202:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<BY5PR03MB520200750D0344EA1E547E8F8FFC9@BY5PR03MB5202.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iwEm3ndKTlTk3XnoTf1BABuidrGLg9rwMyeJR6FnRWg26vYZr/DcqKCC8b8BHyXccvcLyoJAmUD/AoePsUw9sK5CKz8glovazd23xlH3LUic967BivjKcE16ZJ5D3IcfUOWIuUWKgkfFoXgomiSCy8O9e20UHSP6dnKcCxfOcKHZVTLYI6RGDJWxaODYT0hVm0AduU8bqOpioPwKHnKYR6nZBgRxbfGbUhaajFd58i6PSKADPaOC30YPSsurgHaR83Atp9UiWH0hPY1Uj3piZGo8gE/RQLo/6SfeqZAOklaJ4PIqgPUgqK1ulVBT2FFu1Z9P3XPlsQA9TlvgGhmnOUjM/qIx1Szcs5Msx6kj0eWaZVbwEts6ffiO2AeqAG+MKUWAlSd5doT6sMQlDWAU58ZHUcCJhVYs7WkT7ZJECkQsxLSmGVJBI4W4Okk4RAPHVsh9PxhHLpPcZHaqsqgGPMuwRfWSXKtmmq5jVu5wKPQtUzqLN1902NfB2/cNDmybTdjkjktzXxJrK0xBz6KuDBBqKtaPctQJxFpbanikVV99RgickrSVHK4jB5u03+zbnYwamFC8cLRkP+LLDPwgZkdKaFW4mXEOYvUJmSA7+NWbtNuhPUIn3lyRf+izJ8Q7drEuXp7gzWTQEb4ikdQr469yi2ShwJ1i6zIUhvBb+6aNNVuguxd0SuK8jgdtG5SGNT2jO0CQQ0xfLssMgLLtdm/z7j+YL/rLUSzmoiy7RfM1OY8/NqOWp/cyXpLwJx37zah0KXCh2yHOM4OgiQLpxA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(9686003)(54906003)(6512007)(6916009)(86362001)(966005)(316002)(83380400001)(508600001)(6486002)(6506007)(6666004)(26005)(33716001)(4326008)(66946007)(85182001)(66556008)(66476007)(38100700002)(8676002)(2906002)(82960400001)(5660300002)(186003)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?akMxRE9UaWw5cHAzU0s3WFYwWkxGcmFxZ0dYWHozaUVyZEx5RERURnIwZ0VZ?=
 =?utf-8?B?VVIxWkVLOXRWNFQzVmdBMUo2SzJBaklLcmtrYTZnZlM1d0tRS3ZIb0syaWJh?=
 =?utf-8?B?OUlDbVZPcytwQi9JbVFaQ2VMd0gxV2NocDN4dUJyRW9OV1VZSmN2emtjaGNK?=
 =?utf-8?B?d1lGY3F0NU1aK0lnVEl6eHdxUTd3S1doRS91azlaSmhGbTlQc2p0dkdmQ1R2?=
 =?utf-8?B?UVpSdXV4aUl0VzhmdEFNZWUyTVNEK2FyTi9TWklkWjhpUVV1Wi9IZjZJQ3By?=
 =?utf-8?B?cVp5WHlsRllLTWRuaVdYUXV2dmJjOGVnWkhabmhqQWkrb1VCSFNpS2dFdktS?=
 =?utf-8?B?cHhoVE5Fa0I2blJVRGlCQW5pSkxvaEtDRURIME1PaDJnU1hmTG00SnRoVE8y?=
 =?utf-8?B?Mm5pZXF2KzFFZGc5MjA5NGxFYUhFTVdsL29idDlsME9UWWpENTJYY2NpcVlT?=
 =?utf-8?B?UkZRa256dHlEeGUwd09qdTU2RW9GS3ZkZWpiVi92c0xvVmhVR3hIcGg2V05S?=
 =?utf-8?B?T0FaY0VtZndRejh5K1ZuR0FFU0lVTjdTSXp6TEZuby9Semd5YnVNbzltbU15?=
 =?utf-8?B?KzNjbE1SSU1uOWsvazk2bFJqR1hUNDFHOHU0RGgrTlhnNjBINXUyU1ErMzZo?=
 =?utf-8?B?UlVvWjZUM2dkT29kUTAzWmlkd2ErN2VPdUplSXhWUklnRzhPSGZIMXVnT2V0?=
 =?utf-8?B?UEtkRkdHRk9LMmU3Smp3elVQQy83bXVSZjhmbHRkV2pHUDNsR0FXUHRnOUg2?=
 =?utf-8?B?V0ppWTA5MGJCMGdHRGRvWGd0RmxMMkQ0SXBaVXNIZi9kMXRteVN1TmsrcEpz?=
 =?utf-8?B?dDRtR3dvWVM5WTNEU0xKRlMyS0c2UGFuNVYvOHVwR1JxVUhrZkEvaGpoRVVX?=
 =?utf-8?B?OElpVVU5ZWE4SFB3WVlESUJ6THZuMlFrNnNnSVA5a1VhSjRUVXZYTUJKcEtD?=
 =?utf-8?B?ZEMwbG1IOFJtb1VZTEVuYlo3aFhEeVR4cit6NTZMT0FEUzJRNWlpUHVjU3RI?=
 =?utf-8?B?dHhoMEZvTnVOK3ZvS25xTWtkbVlxMFYvTEh3dEZVV0ZhemtmTWl0anFRM0Zz?=
 =?utf-8?B?RUxPZVJSdko0bTIwMzFVOC9jSXFhakVjRmNCMDdSSlZnelJUbkx3R1I5V1c4?=
 =?utf-8?B?V3h5dEF6OFMzNGJSOXBRVjcvVUh0UnVWK0hTemVUQzMvZXM1VzZoU3NBVXkr?=
 =?utf-8?B?YnVMZUE0cTcrRmUwTkd0cWdEU3IrQnNNWTVPREMvZFBhQUZIRTR5aU1nOWho?=
 =?utf-8?B?d0ZpeXJqdGFvMkYwQzVJU3ltUm1hVjUxRDBsckJlNmh5aEI2eHptYnVYZk5G?=
 =?utf-8?B?N2dUT1N5TEhmWHhDR0RncHB3Tm05SXZJb1NucU0wZ1R1bk5weGUwOEh3eU5o?=
 =?utf-8?B?Wi9pWGE2Rkx5MG1mOThEY1NHWmxNdTNQSkFXTWluZWhPL1VobVphVDRTQmcr?=
 =?utf-8?B?c3d6OG1Bd0VDc3cwcHEyVUtzVDNycFA5eVlDeHNIMzF0dlZncFZTM0VSTXNG?=
 =?utf-8?B?VkM0RkJOSHVXZ0hENnlWaG1hdjFIVnUvcndxaDk3RnpPMUZ5ODd3L3RhUEdK?=
 =?utf-8?B?UUpPYnExMWxlWDhyUFpnOVRLSG5qN3BFZUJEK2JsclZPUmhlc1RGZHJrVzV3?=
 =?utf-8?B?RVlBWVZQNDF3VjRkWTRGd0xIMG42S3N5Yk03QVgzd1g3ZG9pWERwOEQ1MVYv?=
 =?utf-8?B?WlpwOCtET3lXcTIzeTI4bVV2dlBvUzJWMGlqb0ZsVWJqa1FoT01rM0NmSXFh?=
 =?utf-8?B?emE5dVBvR3FLeFBZNkdhbTNJVUxFZ0g3R3h3aFBZSlRDUzAvM3I0dmZOQWc2?=
 =?utf-8?B?UWw4ODBaU2FtQUlOMHpYMGJweE9hQWQ0VW9HcmM0ZXZXdVBzQ0o1OE95RFd3?=
 =?utf-8?B?d24yODVVUFFyVTBWVi9IbzhjdEpRYlUrTmFiL2M3SjdDODJieUJmT3NBRUY5?=
 =?utf-8?B?L1V1WXJ6L0NiTlg2Y01kMWNjaDl2bEVjVEJQMDVBQ04vc0F0WS9iOHBYL21o?=
 =?utf-8?B?cjFtVXQwTitOd000MDEzT0cvRG1kaTVPS3N2b0NYeTk0R2toZUlucDBvemRV?=
 =?utf-8?B?RE5TU3dlL2pIUkJNYlFIbmhSOEdvZU5SQjVneVNlMkJxdmVyNngyOXViNmJF?=
 =?utf-8?B?dWhraFZ2bUxZem43YzAyVXhNRkFuSlZIeFJqSk5Lek9GQTJ1d0JIaHBWZVFj?=
 =?utf-8?B?dWFMRGVYd1J4S2pzbjdaY1VQbTRBZWRhempDVFZOaVk2c0VnZm82VXA1ZTNw?=
 =?utf-8?B?THFyWmlhWGxKWWN2Z2xBeStROGIrdDhVditKUHNQd2lGWEZxTWFlLzM3OStC?=
 =?utf-8?B?V0ozNnlNaHVTU3A0RWtkRjJWem9GU2Z5TmRCaUZpS3E0SUJhNE1iNENuazhw?=
 =?utf-8?Q?7OdV0RkCouqTzwGc=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12a2ae01-0281-412c-6ea4-08da29cb572c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:30:54.5224
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nFdo1WXgPaUxUB/ODVQ1fr4w1McLY4XOngfe+YODoLV3phH2HLb0A4Rkby6IBqQ0YIUgxf2Y+U9EtLa/+PLBJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5202

On Fri, Apr 29, 2022 at 07:46:47AM +0000, osstest service owner wrote:
> flight 169819 xen-unstable real [real]
> flight 169843 xen-unstable real-retest [real]
> http://logs.test-lab.xenproject.org/osstest/logs/169819/
> http://logs.test-lab.xenproject.org/osstest/logs/169843/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 169775
>  test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 169775
>  test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 169775
>  test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 169775
>  test-arm64-arm64-xl-thunderx  8 xen-boot                 fail REGR. vs. 169775
>  test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 169775
> 
> Tests which are failing intermittently (not blocking):
>  test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169843-retest

Looked into this one, and it's slightly concerning, guest seems to be
stuck at installation:

Select and install software  [  481.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[  509.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[  545.093820] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  573.093809] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  609.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[  637.093836] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[  673.093957] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  701.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  733.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  761.093817] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  797.093898] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[  825.093863] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  861.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  889.093945] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[  925.093974] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  953.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[  985.093832] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1013.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1049.094031] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1077.093860] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1113.093938] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1141.093803] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1177.094051] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1205.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1237.093955] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1265.094004] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1301.093835] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1329.094039] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1365.093883] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1393.094167] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1429.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1457.093900] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1489.094026] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1517.093997] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1553.093996] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1581.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1617.094076] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1645.093882] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1681.093896] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1709.094022] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1741.093870] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1769.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1805.094017] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1833.093837] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1869.094043] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1897.094101] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1933.093879] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 1961.093933] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 1997.093952] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2025.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2057.093895] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2085.094172] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2121.094018] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2149.094021] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2185.093931] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2213.093864] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2249.093951] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2277.093899] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2309.094054] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2337.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2373.094111] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2401.094132] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2437.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2465.094003] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2501.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2529.094050] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2561.094027] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2589.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2625.093999] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2653.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2689.094024] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2717.094093] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2753.093913] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2781.094095] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2813.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2841.094117] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2877.094041] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2905.094009] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 2941.093893] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 2969.094085] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
[ 3005.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 3033.093917] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
[ 3065.094060] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]

debina1 is one of the boxes I've put into production recently.

Full logs at:

http://logs.test-lab.xenproject.org/osstest/logs/169819/test-amd64-amd64-xl-qemut-debianhvm-i386-xsm/info.html

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:35:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:35:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317183.536395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNya-0003VM-6D; Fri, 29 Apr 2022 10:35:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317183.536395; Fri, 29 Apr 2022 10:35:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkNya-0003V5-1g; Fri, 29 Apr 2022 10:35:52 +0000
Received: by outflank-mailman (input) for mailman id 317183;
 Fri, 29 Apr 2022 10:35:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkNyZ-0003Uc-0S
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:35:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 22c40019-c7a8-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 12:35:49 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-rnbOR1yoO5KOP4YvR8VN1A-1; Fri, 29 Apr 2022 12:35:48 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AS8PR04MB7654.eurprd04.prod.outlook.com (2603:10a6:20b:290::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 10:35:46 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 10:35:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22c40019-c7a8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651228549;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lPrOjayVsy3Kq2sWARRiRreSlaE+Mdnbbq6qDxzjrYU=;
	b=ASNIcQN3/9Pdhe063P/AfJFTI1ADamSjg+4L67jI4ubZ59q8akX/aDruFtz+acQKbJg7ux
	b+IHo1McOi4QCKNyrhtluoVlV7HLwS8cqoAlhB6Mka/Zo01VNWfOxbH/5LCas5fnRUpscm
	Xc9IR7fqF/0pxuKGpIUqdB1rXDqkoFQ=
X-MC-Unique: rnbOR1yoO5KOP4YvR8VN1A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R99VKT0mbqOcr8NfS5Ey+VDQx1uMyFT8TzmCfesdkcmQYv/MZfeY7R8hLnAunZyYix9KuL2liyxo4P9c5uLJd2j/e1lBmbl7mQQX1g5mldqQq7ZGAVFkS7Q4DLS7cwOO0RF4R3+uBtyeCrTM1lkYRiatS/O2XSYPHWD3BAFSnO14H58KL09m4uDrUGp5H/jc/59/A0QR07UFuw0IGfPQPa9ASPtjkDIWbXSxttbSjFT3EoyZ9CVJRZ1UsF3XM16ASfkVK5Wx4nJSEbP9/jwZPKGQZdJA05ogXHZT3N2UtLlynjDoCtntwWDuE0DSk3pJWLJq8hydT9raObzRYR5y1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lPrOjayVsy3Kq2sWARRiRreSlaE+Mdnbbq6qDxzjrYU=;
 b=iMWh/pBqBDvU3hcQZ1i/od9fSEJjFOHcOCMjLeZTq5+Ei4X+2H8m09TDuZWj1yKcmp9lcGQcsFl3sQ6IVYC8QdhI7SB576c+pGRyMZc4GT8sQXkOoph7EFcw+Tn3ZehvusDHJdirtpL3huvSUJhUZgntMA9BccJLkwL3HgGLM07rrnHuPkXdzwUoEZOaIZjFM0VfP0rDQdE7cOkrMN3XRKihW0YcOrrN5bXrnfkZIKye6RjwRFOTmNXZpBDA6olTJTiyXgSBA7prr1IDAiPQn7G3moVAZOUzbL7qbQX+DgiBz8PaqJHiGB0ZzssGD/SIRjIldhbecMMMnHdaOBlSEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5be2e13e-fe3b-2a53-d404-8df6a80a149e@suse.com>
Date: Fri, 29 Apr 2022 12:35:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for
 HVM guests
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220427104718.81342-1-roger.pau@citrix.com>
 <20220427104718.81342-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427104718.81342-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0054.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2059c40f-0d17-42f4-e788-08da29cc0509
X-MS-TrafficTypeDiagnostic: AS8PR04MB7654:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB7654960D00BCA5425D0D8997B3FC9@AS8PR04MB7654.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KOxAKxOI69EgGyTOTz60wF1Z21cN3sC0dbapXJmeRqThP6c5Lc2Z9lYg2aA1fwWQJRCVrPJW2jiPBbnnyWmMe2YrP/mwAHBuriMjxBy/usIJ2b/VbQ7s3S+CtQ3DfCjCg5gLCKJ7L21hfT5jCmKokunk2ropaJO9NC+ApMqdUiCb0AndRGJth5Qu5s0INykkqRGb05HyDrcexhwc1KbTHQurtzdTVrDL58pYByX0+spIYqoMRTCLrCgtHaO/jZlgOzQYrJCytg36lddkG1ZrNOIZtmaYP4eUuZBEQvp85rzUB+jQLbVxBW5iT6FFWSMuyFDCGaSM8jWNeALrqqwxkLnNRNd8Me4lWrm7LephrMyQRMx7nUZYMF8mV38vH1UxHj5et8DZJ9/EFGckt8ssJgOMekurgI9gkniehewMSY4EwTJFCWOTr+Rd1SY63rETKur+2rCW10tyi4irTrtZRxO1PnLPHr936RiG7+/uo5+6cW7lSJETfMue76a1pB6Gj/OkgukdLXNm13NggyleWcWzpA5jGlZKxhcuP5KmxpAhQGdofUFuIcxoJ6AxLaW4d9rGD5yavAdZm5ce3Q6o+kMmlUxbikdTXvbaYEDdtKJLCu3Fy5ITAg9hZccH5VlfjMMpM7+bE2vVvFtodmsikirWLC27g/udXIdnKzYG6CRx6xKga9RL7G2m52jwHhkkQ8d4GeD9julaee8T/wLM73IXrsqDabi16waEWD6WfyM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(508600001)(31686004)(6486002)(8936002)(53546011)(6506007)(316002)(5660300002)(36756003)(26005)(2906002)(31696002)(8676002)(4326008)(83380400001)(186003)(66946007)(66476007)(66556008)(2616005)(86362001)(38100700002)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dUlQMkhLVlVMeDVNU2QzeUhNMlRDRDlsdGZ5RDU5M1d0WUxGbmQ5bFZBSDdP?=
 =?utf-8?B?dnliSFh4MHFyUTdjYnhKL2Fwc0ppaGF0MFNPUDREa2NGdmtqbXI0NVN6ZzZq?=
 =?utf-8?B?TFY5MnpoM2tSTHJTd1A1d29uR0ZaQTB2UHFjU0xOVXMrcHF1aTdzb2VWd05N?=
 =?utf-8?B?R1ZnSVYrc1Y3WTBETklvdkZRcGlZenYxUm9WTVhHRHphKzJJNmVkYTdMbmJv?=
 =?utf-8?B?T3RFZk9saHpIZWtBMFdJcVpGR3E4QjRBODFVM3NmMUEwTm1USHI1cC9OM2Q5?=
 =?utf-8?B?dTZDZFltaUdVNTgweHBKSGNrZ0tESVpLQ2gzbFRpQ0w5bVMzeUVxWW5PcjFM?=
 =?utf-8?B?T0hzcjdkcElzSHZ3Nlo5UWsxQXVNV2R6S3ZDV0cxS3dSYXZMbUpoVEhDNzZX?=
 =?utf-8?B?TWh0Y21SWGNrZ0Jhakd2TVg3aDVldHQ5SExzU3Bqb1UzSVpDSEx4cklBZ08w?=
 =?utf-8?B?Z1B4UnFWRWNRbko0NkI0VnQzanJ1QWlBYW5VZ0JMcDVJUlRXbWRtQmFBTEQz?=
 =?utf-8?B?RElSM2dFVE5PRmg1YWhLTFRKNkVwOG9UN0x5WjZWdS9tL0M0Z3hTT0JCK1h2?=
 =?utf-8?B?cUVmenBWd2NiUTNzUmx6SHdnRmtxRkFkMUl3STlUU2hrVlhXVElLMW5RdXF3?=
 =?utf-8?B?TExOVzFFTzgrUnMwcm9yWnRaUHM1aEdmTHJ4WUMvMEdYVFN3bEVPWlVUZFpq?=
 =?utf-8?B?VGxoUzhVdDJxN013Z2JMcDJxak85UFhqUUU1dHhuMkQxTzNWSXNWck9wUnZS?=
 =?utf-8?B?ZEVza0tPbVZwYjYxQnpwdzlDalJ1VEVJM3QxQVdXU3dGZndRSmVzbGtNbEY1?=
 =?utf-8?B?cUNOTTNhQmh3WFphTkRXUm9Od25PRy9YWnhpRGNJUndJTHk5dmFmdDlxZk45?=
 =?utf-8?B?OHNsMWpmWFZPeHJyVU9OSHlYTGNUTU45aHJac3FGc2M0Q0J2SUU4a29PWFBL?=
 =?utf-8?B?WjhOUFhDdWplTmlCZUYxeCtsNUZFTmd2TURZRHBENGJlMENHNk9XdkV4R0FI?=
 =?utf-8?B?NnBhWmg5YUsyOG14MVREWVBYOEszUUxWWCtMTjJKZ29IWTZXc1kzR2dTWGwz?=
 =?utf-8?B?NDJnUzZxVStMZE1QZ1dYbXdOb3I3RUlWU1dtNkJraDNza0Z6UHJLVlRmN2J4?=
 =?utf-8?B?TjU1MThiZ29lSm5iTlN5dHdJSExIZWRnTFd4QS9zT3RoYmRNbkhKRWxmUWNo?=
 =?utf-8?B?SEJKQTU3YmYxVWZzbUxFKzRnbWliTkpLeEk4SklDS1NGbThuL095c0lpeXRh?=
 =?utf-8?B?K3lxaXJrMlgvWHNwUHpYZUhqUWlyYzRtQmRPK21vVFJNdWwzTkpUc2FPWXNr?=
 =?utf-8?B?T2pBbTFJUjVhZXpWb1BuSE5vWFZEU0QvdW1TVHZIeGg3NEFXY2lORWYzRlJk?=
 =?utf-8?B?WkFSNkZkYmI3d0ROS2llS2VBQjJLblk0OUtUTUpUaUZzN1JNcUJsZ1pLNjRQ?=
 =?utf-8?B?ZzVrVi9YUWlaU3R1ZnhPMmlra2NyY3p5YVdxY2VIVXYwUVk2UmtBbWk5RFRG?=
 =?utf-8?B?d3JmZ2UzTWxRZkNZSXpCRTluOHg4MDJvbm1HVHk5MVN2QWkyUkxVNUZlc2JW?=
 =?utf-8?B?M09RdlgyWDVYb0dDVlZBYllaV2RkZ3hOR0pBRG1mRGlQUWFHNEw3REpSeVNq?=
 =?utf-8?B?VEdtLy93ck5WcTVhSUVRVnpWK2ZwNUFBL2lnOTczbW5MVndzNkZkbmN4cnBF?=
 =?utf-8?B?b1J4LzJTL2ZoOCtTUG1KbVhxYTZIRStZOVJDcEVaR0V6azlOaGsvTDlJOVJh?=
 =?utf-8?B?OTI2Qm4xK21ScHlLRVZ4dTVzS1VwY0ZzTUZBNFByM25mOEFWVWg1a3BsOElr?=
 =?utf-8?B?QXRxaUd0eTA3dnpjTmJ2QUVSWG9OM2pzL1VkajVtWHBjOWRROEs4MmN2RVhC?=
 =?utf-8?B?NUpmRHQ3NW1hUGlzZ2RURU5JaXBiR1ozcDBrTjBmNDRUSGJxbUlJRnhUUHpD?=
 =?utf-8?B?OEdFelNPREZ2aE9OS1pEVk1ndEx1UmZ2Tm1oSW0wbjQvMHRDQU00dStHM3Uy?=
 =?utf-8?B?M2JZQXFUM1Q4VGFiWVZUT0hoN2tQZitxVXRQM1hqNCtoR2R3RzUwOG5RTHc4?=
 =?utf-8?B?VU1KSGV0bnQ1WXhmTC9Oa0x0WEhhUjBqZ3JKbnE5eTVOenZLVCtvN0FSWk5l?=
 =?utf-8?B?Qk9UODFkcmtMcEt3MU5EMG8wemlmRHZHcUkrM3h4UGIxMjdLb1pvZ1VQV2NK?=
 =?utf-8?B?V0RJTEc0MGNrN0VaM1UwNXQ4VEZRL2hhVm5LSW5WdWV2Qm1kTG9RMU0rWlpM?=
 =?utf-8?B?Y3MwSDN6Z0pZUkxiMnliUVpSYjI3ZHRpc3JJVzhRZ0E3R0NtODN6MlRKMTkv?=
 =?utf-8?B?M1NBK3Vrc2VVamVKdkdlL01td0NoZitsdFlCYnhiekFtMjNPVWRFdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2059c40f-0d17-42f4-e788-08da29cc0509
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:35:46.2042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EkATRrrpOx9RPtlkxFHBFzJyT5pEcbGauy0hBUfzFxa7gbrA71blGIf+QPLURx5s/Zp4nZsQ7VAxNpZOa6L5kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7654

On 27.04.2022 12:47, Roger Pau Monne wrote:
> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -541,6 +541,10 @@ static void __init calculate_hvm_max_policy(void)
>           raw_cpuid_policy.basic.sep )
>          __set_bit(X86_FEATURE_SEP, hvm_featureset);
>  
> +    if ( !boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
> +        /* Clear VIRT_SSBD if VIRT_SPEC_CTRL is not exposed to guests. */
> +        __clear_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
> +
>      /*
>       * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional
>       * availability, or admin choice), hide the feature.
> @@ -597,6 +601,13 @@ static void __init calculate_hvm_def_policy(void)
>      guest_common_feature_adjustments(hvm_featureset);
>      guest_common_default_feature_adjustments(hvm_featureset);
>  
> +    /*
> +     * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus
> +     * VIRT_SC_MSR_HVM is set.
> +     */
> +    if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
> +        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);

The earlier patch sets the bit in "max" when SC_MSR_HVM && AMD_SSBD.
This patch doesn't set the bit in "max" at all (it only clears it in
one case as per the earlier hunk), thus leading to "def" holding a
set bit which supposedly cannot be set. Irrespective of the feature's
'!' annotation I think we'd better not violate "max" >= "def".

Everything else in this patch looks good to me.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:37:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:37:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317188.536405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkO00-00045k-Fh; Fri, 29 Apr 2022 10:37:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317188.536405; Fri, 29 Apr 2022 10:37:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkO00-00045d-Ci; Fri, 29 Apr 2022 10:37:20 +0000
Received: by outflank-mailman (input) for mailman id 317188;
 Fri, 29 Apr 2022 10:37:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkNzy-00045V-Hk
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:37:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 56fedc9e-c7a8-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 12:37:17 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-SDKgxzxyPX2xZ3nUGRKlzg-1; Fri, 29 Apr 2022 12:37:15 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VI1PR0401MB2287.eurprd04.prod.outlook.com (2603:10a6:800:2e::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 10:37:14 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 10:37:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56fedc9e-c7a8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651228636;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vBeehNNKcALOn2Ccw1VujC7JXL/3wwRgg/Da3YSULbY=;
	b=lQleSZtZTV/vPNQzz1ClyBp4l//2hpBpM+KKzbMerV0i6nhjCxIq6DAxRyX53YXfVA3YCx
	KNN8/lubUcXmD016ySXIheHMQaGTh+ede55vr22xXPDgQutAcrn9La7lQFITqGQFihYiF5
	1UXIbraLkQ2Wkl5HUXCofK9oFl4C69c=
X-MC-Unique: SDKgxzxyPX2xZ3nUGRKlzg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jbPCcu5XfafbjepqgsdFYWgH0HaFgNbSYBkyv6NJhM/0ycYBkLgbMh5kLNOaAqVtuv0f98oxvwp61gyDUigJC/BfH5izoBCGS1PZlZYeJCKrMmSxLsufr034jZbUVs+H3pkOcm+IpgbaOLqeY08Wfm7i17+TicYr+8nKNwsS4BSZ8IwDjyjQQeof08wkrZGnXeFlWhP0Ru7CEr0tcfeVCzxzaKiEeNdzwUI2ha5g0lq0WebDjXQEaOjasRyg7qzReyOalqYStYu/7xVwLEfV69UZ6sSAIsk3Vrd0E6ky9NiZiuV3KvukxyPtVPF2azZIb9GkL6ZgkyQFzWt2hxXKiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Epzp5HkR9KkZW4E2jKSKxyhqnnGDanuZ6PAHXAylqII=;
 b=amvsW8mwfINVI1pTKCDabU5Kk3v+G19nO9rixnw6nV38NbgFT+YHeMbdNtvfgQA/xYeNc6WiOKzVeUG6PfdNCZepJ/8nWGCbkUCEb/6EZKJ9ZG/DJehlBhF8Uu/07fzxwjhbV5uHfr1OHhwoa+jKoQUPrq6k7jTKNaguB7YkMFqIwdxRZGxsX7SyvU6WBqgZi47Y3squyzoFw3Qnl1Z2fJY5nwNzgILoH3mN7veTpm67/SQdcuSc4oxMid0bzvK+ksj2N2GanxBHEz8pi6JWgjCvyW02/kitlvw+xyCXf7btuGmwXTKc2oWKE47uDBvFSAcZF4Noh4UziadLWqKrUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <25a16b3e-e235-698a-452e-bb87920adc89@suse.com>
Date: Fri, 29 Apr 2022 12:37:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [xen-unstable test] 169819: regressions - FAIL
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 osstest service owner <osstest-admin@xenproject.org>
References: <osstest-169819-mainreport@xen.org>
 <Ymu+WnVjTANHk+na@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ymu+WnVjTANHk+na@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0099.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::14) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f7bbfe8a-f609-49a6-e6e9-08da29cc396b
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2287:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB22879D5604A91E7F090D8FB9B3FC9@VI1PR0401MB2287.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SD5WN8+T1OHUQXpQC73Vj5JCShK9jV7Q5xy9rROn6f7Y2Lvjj4l4jgGxnYZyi+NmO6cw9HbFiWCpteUu+r1oKp1mqg309vAfg3D9Hg9woGPgZSYaTfda+oK6ffxbkcmghD1sSochBMQoqGsOnan5BsUnk+ueOmTP3YIhfT4eiC0xmG9sPeZmki+e/YFxVkm21M/itNsn34vYMEbwIgl9CE8owsVBFg08aGZQ4RdwHv55S17IKrRh5u9gmjawjC8MDOhXq5GSYESoPzlgdj9RSf8aMQ6uaf3vtQ/GHtAcWjiNtBYn6n2/EfbY103sl5LRCd/FBG4Wpt/vdKCUeHO74PN+2xpftTOwqdfgGWLCat4QLv71VbymWtZebFH1regszTK9R1577kLuDP0+P/Jz53TbsBXRUz8eNmXJ5p3qGamIUVhR8IL2xLxYFcI4Fgp2LB7u4Q9TAubX4K3OxnRscP9xQn9PS+izHTtvYg9D2sCWQ+Si9v72Qz+BQIdsJL4yTa7S7UztAMBrgclvgQtjIp6iIbn9IQZCGEbRJaI+jwod9iITOVJH031ZcC6AFcZuoWp4uJt5mK9AW+FcCPqijED+VlC9YAhUx9awaiXyjuybG0bcEhhNwRja8ohc1azYUCLW12oQEkbWyXVMZNf8HtKphX26vWrGJAYfVxqIA4N7AXY8ImH7CFAC2SVfFXRQVICvxx2h3oYsnMZSHR5X5Z1yQO1jH7NqaBkfgJJU+a/qZ9JPZv9aHP4kmk5spPai/AzimLVA1LXydL/SD3mR1FdpsrSspvCCdVYjWhl6l3Xf4cNSJcWydJcT6nLbxyHhH9PsJTEkUyl+7dco0Myw5dOMC7w5Lbmh+NnO8tvLebDdslj12XoQ/6vPZCYd/uIe
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6506007)(31696002)(38100700002)(26005)(31686004)(54906003)(6916009)(53546011)(6512007)(83380400001)(4326008)(66476007)(86362001)(8676002)(66946007)(66556008)(36756003)(2906002)(508600001)(316002)(8936002)(186003)(966005)(2616005)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?DBV83JLqA+fXhIheHdm3a88+CIwXzAfiPNUq8Ya03GsNQ/pocsg3CgU97ZN9?=
 =?us-ascii?Q?n/nAZiAO//gf1S1xtmbjemMV0xCtdmAV0L8HoCAIVPMrJ0Bn6c0Ni3AszFIy?=
 =?us-ascii?Q?y0QQggEF0XAejLmbM1fNPEDkid7tizlvbuvH4fDI4fBEZs0VyrU8Ju5cx5fv?=
 =?us-ascii?Q?nqKKKzXr/1SqQe7PfU9Gscffwlb50aUqTE/M1678HgwZbThID5PdUcF/8b45?=
 =?us-ascii?Q?i8I1phW1q6SF6/xqYU50R01ivSMaAfjNd4VJaCOMRvpxPvYgebkxJTUwDky+?=
 =?us-ascii?Q?kxuaoP0sLA9lLZiQcJ0D6/ea7kGLGcMoPzQtHEvNIoYyT6Bz2Sb9ycq5q9ei?=
 =?us-ascii?Q?BtITyGIHBVYQMIOS/yWzScbNQBtzJ70ctEpMWGiyS9eEYmQwRp6/0X/V0K//?=
 =?us-ascii?Q?fhhWTPrWpqpSrDFfSqmKP+5xf5RWSJS8K+DtPKkM0oRbyivE24tILjGse7oE?=
 =?us-ascii?Q?fvkeog+RIXqYV332fl5VDeMhuMBpcX/53J49HCgmocjaP1MrHV+MUkpxJB8j?=
 =?us-ascii?Q?qK7DEFc4h1RG0zHaYnYADfnvYTMWwJh89+0qYnqpu72SuPinYwYiqsfHLn8f?=
 =?us-ascii?Q?ViCagg6YAUBvMLkLoQMhKcCHCXrv6tir+a84t8WpmBeON3kiFNvHROjMfPpH?=
 =?us-ascii?Q?/qndLSfQ2zNmBBk5XZvN1Ypnp9riuK9G26FMIOqMIFyIYSklN8GjEwnzK8Sq?=
 =?us-ascii?Q?b6BDj/PtaLkG99Y09FPpnYCbyH/PRFZuXl3Tb7NnBUdqD+KZpwM+/2onP2fW?=
 =?us-ascii?Q?5t6T9lPr5/OPQpZCBgy33BkpxmcGXqJfJoRlU/JByp4Uf8JlhO49voJAAZZH?=
 =?us-ascii?Q?mjqBpXRFhDprIdAf/yqoUHglXKQKYqJ0PjZGgh5xGg2X5CMka3vwXGW2wOa9?=
 =?us-ascii?Q?VUOqiFBwbSNesPu7+uwgSYnsUdEIqRYAOJ+B3mbHro/tngaJXw9H2mo3T4Pr?=
 =?us-ascii?Q?x+9YXm13OIWRX21U1bOnoFJPjphXL6Ifys8ElvN6LaOFWtO7p0d6svmB2aFf?=
 =?us-ascii?Q?+3neDljO3yNA5x/gAJZeSZIFYEsiylwm7AjttyfCLzxGnfmLLNOHDosGCBwe?=
 =?us-ascii?Q?RS06nxTlL3COaOZXDqW6ctT4KkEU5eSiuWh7QWclpgreufl7liL+lXpDIP6M?=
 =?us-ascii?Q?hgsnczcMqx5jAYcU/V2JmZEw1KySn0l05qNjYyNd7kT4B2+zbs4cF1aa3iaJ?=
 =?us-ascii?Q?TrrygMIhSfiCVi7mnMYm2uMr/PUwzoeXIpUlA9C5N8jy1JJHwsGw9iLo0x67?=
 =?us-ascii?Q?DPosz2NXsPiFATIAQxnJY80JR92d5RiNsEZ4C2Zyisx4NurAPNx5DqmC/wA1?=
 =?us-ascii?Q?YoN5PIZQtM3RVTXPCZraf87B071wJSo9mvws27+FYZ/Dzb6qnd82iH85XRQV?=
 =?us-ascii?Q?djD4lCsmJgnb829DEz3O6RMS0yuiXw7AurV4MD2uATJN/4xGGKlqDNw2Gsrl?=
 =?us-ascii?Q?Uxc8ntcgRzwdweBMmGZDBt4OJZ4e5nDyxEUfgS/IDLzBezXvh7knXfwqLYJC?=
 =?us-ascii?Q?XooZ0bDP24dUI+PT9bkuZnNKroZX7MA1UE/kzBA1D1KZAB21GIkyebHIsJH5?=
 =?us-ascii?Q?0KqLy1cKfOaw+s34yBjV+xvl6jQAEUfjWs8bFpM2Sy98FFJ19ywUqHolTsPp?=
 =?us-ascii?Q?J+PIVkoJVk5NK9tY4znJP0yG4aa0T4rnD3RtO+7nFJBs+ABdjMhdFWsTZ1p0?=
 =?us-ascii?Q?vFGe6MkEls0VDQrC7XeZTmOHtQ2qY+mBgeyIt9yRzKIA1ck6czt/wQ+yzgKQ?=
 =?us-ascii?Q?QhYnsG9sfQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7bbfe8a-f609-49a6-e6e9-08da29cc396b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:37:14.0567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dr1eF1bGL6OzGgPA57KIIqtpGwZNeRyFrkVrnyEFRvZaqhdPk6PrEqrEFTIViF9qFcSjoPOeOJCkMn0Mr8bntA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2287

On 29.04.2022 12:30, Roger Pau Monn=C3=A9 wrote:
> On Fri, Apr 29, 2022 at 07:46:47AM +0000, osstest service owner wrote:
>> flight 169819 xen-unstable real [real]
>> flight 169843 xen-unstable real-retest [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/169819/
>> http://logs.test-lab.xenproject.org/osstest/logs/169843/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>>  test-arm64-arm64-examine      8 reboot                   fail REGR. vs.=
 169775
>>  test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs.=
 169775
>>  test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs.=
 169775
>>  test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs.=
 169775
>>  test-arm64-arm64-xl-thunderx  8 xen-boot                 fail REGR. vs.=
 169775
>>  test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs.=
 169775
>>
>> Tests which are failing intermittently (not blocking):
>>  test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail=
 pass in 169843-retest
>=20
> Looked into this one, and it's slightly concerning, guest seems to be
> stuck at installation:
>=20
> Select and install software  [  481.093857] watchdog: BUG: soft lockup - =
CPU#1 stuck for 23s! [ksoftirqd/1:17]
> [  509.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [  545.093820] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  573.093809] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  609.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [  637.093836] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [  673.093957] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  701.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  733.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  761.093817] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  797.093898] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [  825.093863] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  861.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  889.093945] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [  925.093974] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  953.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [  985.093832] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1013.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1049.094031] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1077.093860] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1113.093938] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1141.093803] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1177.094051] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1205.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1237.093955] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1265.094004] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1301.093835] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1329.094039] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1365.093883] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1393.094167] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1429.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1457.093900] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1489.094026] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1517.093997] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1553.093996] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1581.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1617.094076] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1645.093882] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1681.093896] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1709.094022] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1741.093870] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1769.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1805.094017] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1833.093837] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1869.094043] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1897.094101] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1933.093879] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 1961.093933] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 1997.093952] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2025.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2057.093895] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2085.094172] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2121.094018] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2149.094021] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2185.093931] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2213.093864] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2249.093951] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2277.093899] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2309.094054] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2337.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2373.094111] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2401.094132] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2437.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2465.094003] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2501.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2529.094050] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2561.094027] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2589.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2625.093999] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2653.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2689.094024] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2717.094093] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2753.093913] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2781.094095] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2813.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2841.094117] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2877.094041] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2905.094009] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 2941.093893] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 2969.094085] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftir=
qd/1:17]
> [ 3005.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 3033.093917] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
> [ 3065.094060] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftir=
qd/1:17]
>=20
> debina1 is one of the boxes I've put into production recently.

ISTR this issue having surfaced randomly before. With the randomness making
it difficult to investigate.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:45:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:45:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317195.536416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkO7M-0005XZ-8B; Fri, 29 Apr 2022 10:44:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317195.536416; Fri, 29 Apr 2022 10:44:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkO7M-0005XS-58; Fri, 29 Apr 2022 10:44:56 +0000
Received: by outflank-mailman (input) for mailman id 317195;
 Fri, 29 Apr 2022 10:44:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R1X1=VH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nkO7L-0005XM-HM
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:44:55 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 66c3f84e-c7a9-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 12:44:53 +0200 (CEST)
Received: by mail-lf1-x134.google.com with SMTP id bu29so13366554lfb.0
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 03:44:54 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 f12-20020a05651c02cc00b0024f3d1dae85sm240897ljo.13.2022.04.29.03.44.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 29 Apr 2022 03:44:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66c3f84e-c7a9-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=nWVhfCJXVelcPeO/G6jDbgAGKRJ2brFr6z/qTwXN+Wo=;
        b=IDvmnEHpfcP58KNEuQSeY64SwDcooAwuUPbBzyb4yv1DggY1GzqL7r7Bq136Ugogbm
         HHn762IFJ+rQgNX6T4f+vmdMeZd5rxz9FrtpfDGR9BiOv2fuiw4CL85ubu/k9m6sAOBA
         Ch+ifMSZADe3DshR0MxOdiMfWSR42L7NK9UJng72e3p/2jxkFclTrl9vaBtruqJv7BhR
         9iaD9gJksrZJRwk3RIn7CiEekgKjAgAk7ETt/Lg43HqjUtqebuekkDp8TAMcFECUoKBh
         5+0oAj1HC6DzInwPajLU68+014b1pavawDDwsX2/YNyTPN1Q1MjI6Ik2z/KwptPlUN1C
         u6qQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=nWVhfCJXVelcPeO/G6jDbgAGKRJ2brFr6z/qTwXN+Wo=;
        b=0T7Rvo2uCnnUwQt00lfeYAl6hPJfGwNRpxlwc6k6bESGVsjA2GWu/q3XQ84+2PrO2E
         s4ezPOFZtToIXQ2jn1cjpF8zIXKXP+RPf2eCEZQC6idWCdyjytJm6RgseH1rAcAaew4g
         yOtzVQ7nI3fwThY704sJT/MdR2jMgpP7UvEG2CFZiI7Feo/nnYVERdaqRR942cozpXvp
         KFhv5STb9Iet6RuWpkSYAQvXKT71+sGQxGJjhfrdNyBJdMjOocRsViUmgx9ogpzMCEQ9
         rlO/whTJ1mMKG/i1fBhuUJmWt9S9weIwRNxCnDaL7dZuLJ7/qPbCmDyN5j5gQcsTgGgf
         mTdA==
X-Gm-Message-State: AOAM533EDJORz9mfqVNSp2myY/4pKTWGRYMCk5she+ERNwvTjmexEcN6
	KWIVwd2bZi7ov4WuY9tGwnGJa28pJ8U=
X-Google-Smtp-Source: ABdhPJywaDyP7t0OKyLxVG1I5PC+KmhE0jvOKO39oal5xED7cnvL24VSa6HovwFqn76tNet2OHmUbg==
X-Received: by 2002:a05:6512:3b2c:b0:472:e6c:929 with SMTP id f44-20020a0565123b2c00b004720e6c0929mr15194625lfv.505.1651229093826;
        Fri, 29 Apr 2022 03:44:53 -0700 (PDT)
Subject: Re: Virtio on Xen with Rust
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Stratos Mailing List <stratos-dev@op-lists.linaro.org>,
 =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>,
 Mathieu Poirier <mathieu.poirier@linaro.com>,
 Vincent Guittot <vincent.guittot@linaro.org>,
 Mike Holmes <mike.holmes@linaro.org>, Wei Liu <wl@xen.org>,
 xen-devel <xen-devel@lists.xenproject.org>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <CAPD2p-ks4ZxWB8YT0pmX1sF_Mu2H+n_SyvdzE8LwVP_k_+Biog@mail.gmail.com>
 <20220429034808.dr647727dphnx6zk@vireshk-i7>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <f9aeb25d-ba47-ec1f-d157-fa51ec23fdb5@gmail.com>
Date: Fri, 29 Apr 2022 13:44:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220429034808.dr647727dphnx6zk@vireshk-i7>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 29.04.22 06:48, Viresh Kumar wrote:


Hello Viresh

> On 28-04-22, 16:52, Oleksandr Tyshchenko wrote:
>> Great work!
> Thanks Oleksandr.
>
>> I skimmed through your toolstack patches, awesome, you created a completely
>> new virtual device "I2C".
> I have also created GPIO now :)

Awesome!


>
> What should I do about these patches ? Send them to xen list ? I can at least
> send the stuff which doesn't depend on your series ?

Below my understanding, which might be wrong)


I think, the best case scenario - is to try to get these features 
upstreamed. I expect a possible interest to virtulized I2C/GPIO devices 
on Xen,
especially in embedded environment where the passthrough of dedicated 
I2C/GPIO controller to the guest is not possible for some reason 
(clocks, pins, power domains, etc).
But I do understand it most likely takes some time. If upsteaming this 
stuff is not your primary target, then I think, such patch series 
deserves to be sent to the Xen mailing list anyway for someone who is 
interested in the topic to give it a try. For example, you can send RFC 
version saying in cover letter that it depends on non-upsteamed yet 
stuff to start discussion.



>
>> FYI, I have updated "Virtio support for toolstack on Arm" [1] since (to
>> make it more generic), now V7 is available and I have a plan to push V8
>> soon.
> I will surely have a look, thanks.
>
>> FYI, currently we are working on one feature to restrict memory access
>> using Xen grant mappings based on xen-grant DMA-mapping layer for Linux [1].
>> And there is a working PoC on Arm based on an updated virtio-disk. As for
>> libraries, there is a new dependency on "xengnttab" library. In comparison
>> with Xen foreign mappings model (xenforeignmemory),
>> the Xen grant mappings model is a good fit into the Xen security model,
>> this is a safe mechanism to share pages between guests.
> Right, I was aware of this work but didn't dive into it yet. We will surely need
> to do that eventually, lets see when I will be able to get to that. The current
> focus is the get the solution a bit more robust (so it can be used with any
> device) and upstream it to rust-vmm space on github.

ok, I see. I understand your point, your primary target is 
hypervisor-agnostic Rust based backend(s) to be applicable for any device.



>
>> With Xen grant mappings, if I am not mistaken, it is going to be almost the
>> same: mmap() then ioctl(). But the file will be "/dev/xen/gntdev".
> Okay, the problem (for us) still exists then :)

It seems, yes.


>   
>> FYI, new branch "virtio_grant" besides supporting Xen grant mappings also
>> supports virtio-mmio modern transport.
> Somehow the timing of your emails have been spot on.
>
> Last time, when you told me about the "dev" branch, I have already started to
> reinvent the wheel and your branch really helped.
>
> Now, it was just yesterday that I started looking into MMIO modern stuff as the
> GPIO device needs it and you sent me working code to look how to do it as well.
> You saved at least 1-2 days of my time :)

Great, I'm glad to hear it.


>
> Thanks Oleksandr.
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:52:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:52:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317202.536428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOEX-000746-6e; Fri, 29 Apr 2022 10:52:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317202.536428; Fri, 29 Apr 2022 10:52:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOEX-00073z-3W; Fri, 29 Apr 2022 10:52:21 +0000
Received: by outflank-mailman (input) for mailman id 317202;
 Fri, 29 Apr 2022 10:52:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7mBs=VH=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1nkOEV-00073t-Vs
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:52:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 701e2f59-c7aa-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 12:52:18 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-JBLqOkFDPHe_OhB-Dr5bFg-1; Fri, 29 Apr 2022 12:52:16 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by PA4PR04MB8032.eurprd04.prod.outlook.com (2603:10a6:102:ba::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Fri, 29 Apr
 2022 10:52:14 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748%8]) with mapi id 15.20.5186.021; Fri, 29 Apr 2022
 10:52:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 701e2f59-c7aa-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651229538;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=EJ7dwpD3/yQ/oMxzERgbv1XefYeW7lPcwO5gGHqHWK8=;
	b=ArRPkJUsRAZqJgm5qx+PHaMeMGt41htCUle977QD8M/l/VapWcMnmAhHYwIia+lfdmYV94
	w1lPV7QGBPpnqTgo1BZXWurpBLSEG7nMi+6hEewz4oayI1x/hnKNrbMssZQLyQwbjodqjr
	lwxk4zUJ3jzzpo0EAzkWWcp0whnUi7Y=
X-MC-Unique: JBLqOkFDPHe_OhB-Dr5bFg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O25d6xmlJpDCQyrLLhWn+2NHC70wNqoTC8TE9tgUVF/3iqYxf2ehFbsdqzFFIdoEQV0ceewsLl5YaimV72bsi1DIicdueHkq46b8GjHuvyFOQg0JV6GpKHLMHlUJhIEhbU+AJLFJy93F3CF6ueCs55Wc9FXhzgz7783WHdUUcNGfXDm64n7auHGLeawYyBixVwRSWkDLuzY1autuP69byD7xo9uA54oBZp4LB4cLb54Bmjx4NEY2PpjYSFRP7MI9LBT5ESJC6Dlt7Vd6wBjsc+pVboaFvhD99kl4pA8ywwb7Pf2uab5O+mliKgfzKpWRiZTZ2WHpvVpryv/6Ry/rTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EJ7dwpD3/yQ/oMxzERgbv1XefYeW7lPcwO5gGHqHWK8=;
 b=TgWydtpD2PDMyk4Z/m24l54/2dU/m7fBA8a6xKyyF14QCkWzsLfHHs0FXc2aNkD3wX3JzpMlVjw3TUvJaR2Pr4w0w3LR/Yfk1WCZ4hFpCyMvqVpWXj0oRBhnX/xkUHb5SAjv2Z9NR55E9nr5UuTPh+IaJwsjarkn8j/n6tpxJ4T6AA86EIk/HXPASPh1YcMRDFLBi92RYUou66w8NsCXr3uMvvPGTcJ4jHICp5DAomAWfmmA3LRwE3iiha6yosf+TQqS6wiDKZFPtshgnNq5wcnKiXaw0TOEvmbZk2A6CdK4G73SZARTykczuIyvmX/VGfTt6oqJnqf5Pl3lVLeFtg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>, "ohering@suse.de"
	<ohering@suse.de>, "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Topic: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Index:
 AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgAAVUwCABn7lAIAABpgAgAEqhACAGTPWgA==
Date: Fri, 29 Apr 2022 10:52:14 +0000
Message-ID: <fd07c28fad352a476544258f2ac4d652062b2701.camel@suse.com>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
	 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
	 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
	 <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
	 <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
	 <35599105-b441-96cf-7537-ccf9dfac0934@suse.com>
In-Reply-To: <35599105-b441-96cf-7537-ccf9dfac0934@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.1 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cf87798d-a086-49f2-b6f2-08da29ce5225
x-ms-traffictypediagnostic: PA4PR04MB8032:EE_
x-microsoft-antispam-prvs:
 <PA4PR04MB80323E5A596D65943CCDD400C5FC9@PA4PR04MB8032.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 oRemdF/KbmHIFXyjCv78gVTvErWds81p/xNFsA2bgvHiJ+pbStZCqkmgjwEkVRfOZnb7JkQ1uehcljpoZGDb4/t381XWy1EeZ7kA5FUZNJelLkYSCHmowx3+2V9Ji+klcpv+s+OMJGGCFo5soLpbSjbpMLQFdr12rk/yxDjGLv+qNnsPlMqq02J3bjppZfH5YkEet02iMrCRecVNNbv18ni/QBIdaIMwkti+hyFxjkWkxDoQdmFRTh9KwJ1XJd2Ik2dzKf1/mwrjOa3ECH1h3zqUv8jGG/VzlmJoxtuFeeR50i8hcAS0K9ZF0bzebTmiQsgt+PjDsqB5ZT3u9XO1sCUJaYTxJwaFL+bxPHnRT3iKhuoabjbIGOKMnrRC616eN1Zt6lGirVBjGB6m80WU3ZzflVvpNZinAc3dJxhX/PoJh1QRNQZoagWHtqMB8eLuKXD8nanCU+uFdc4hsTk3eu9kg3zhW4gwDgRP6Lt2ZdxVtB/6N4zEW8EU1UxhhiaKDAu2Xv7fSiMfLO8k817QYiEISCZVfq+193rAeNengzeilOsBzbnOUamXOAYI6KSXECExRg5CVEp7R2zBmno9tXzZlFA4k/aW67N8EMacs+uuHZkK8VGE46532kMAJgWGUDcaDFrdG7IqedCDIkRI5rHadYXrh14tp/YT2kAaoSHSghw6t5Nf6EGtOfMzxqjneQKLBaZpcQkgLEGr4uqbuiee8NdevzQ4o9crvkEMvu+69kvDAxp3+R4ArTgL7zks9OPOspnjLjRIvN5O0ELepCToYz+LmLJirUhq2z3UgT4aWTT/eJUxVMBpCNIBCFWm0bvtbUUAKp45USVNSzU/TQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(8676002)(6862004)(508600001)(36756003)(316002)(64756008)(99936003)(8936002)(91956017)(54906003)(76116006)(37006003)(6636002)(186003)(38100700002)(38070700005)(86362001)(66446008)(4326008)(66476007)(66556008)(2616005)(71200400001)(6512007)(2906002)(966005)(122000001)(6486002)(83380400001)(26005)(53546011)(6506007)(5660300002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VXF6cHF1Z3NUaUR2RlJKblZDTGVoTXlTcE01Zit6QWlIVWZ1NWI2dDRHWUp4?=
 =?utf-8?B?U1lHTm5NVWxXdndsZi9UVXZXbEYyaTZhbWI0L1FMZEo3TTRDVlFiOVRKck5u?=
 =?utf-8?B?ZWtsUWpZZUNpNFZXc1hHQ3BuVzF6WXpDdnB3ZDhNT0VLdTVLOUh0RmdOWDFK?=
 =?utf-8?B?RXFjWWtpSk1qdWQ5WDJCN0tBRmxFRXlEL1NwRUVPb1pOekMwRGt0akdpUVJk?=
 =?utf-8?B?MXRvRGZxQ0Vac21XRGViK0d3UVBNTkp2N09zSEltMmFCbUZhQ1ZKL3VyODR5?=
 =?utf-8?B?K0xRQVloQ1UxVnY0UWw1MHdUWkVKYjllZW9PU2tYYWpsNmZGVUZlY3FCeTJl?=
 =?utf-8?B?UVo3S2lsVTJaNVFlNm5rYnpyT3hsdFdBckVSQ1NkK096Sk45aDlCNTlrZXJH?=
 =?utf-8?B?TkcvdStBVllzS1QydnpmR1lSeE5pQUtmc1NjMmhLdmhscWRiaFVyc0FyYjFC?=
 =?utf-8?B?QWZvZGZ5dmhEL1FNcGFtZzZsY3lYcm9vNE5XenloTFBYUDBzY1h1WDFXZmFD?=
 =?utf-8?B?dmFBUzFrTU1wSjVIUUROM1hUTEJ1SzFyK3ErQTNuL3czeGVUeEhJdnE5VnFV?=
 =?utf-8?B?Z3BoL29xdnRwS3ZNaXY4ZlpEVWJ1MUpEZnVRVDF5T2M1ZmlmZ0RtVk5XcjFE?=
 =?utf-8?B?TktHUTRyUTd6NHFudGgva1JkZ0VRVHh5SElrMlFvd1pDbWVPZyt4ZE1ZS29C?=
 =?utf-8?B?OUhYWGhEQW51Snd1MnN0a3dhZnZIZ3RsbnhKU0hkTnlGTlZCWHE3S1B5VVdz?=
 =?utf-8?B?RTlhZTZSMXduS2d3b2Uzc2d0UWlqVE1pTVF5a2RSWnVKNkJMdElueXRZWGhN?=
 =?utf-8?B?bGp6ZVRuOWt2UmYvbVVHSlkySnZFbUJ3M2FHSFBoL2pOUkhmeTRtUmdNaFpn?=
 =?utf-8?B?RFZBNnhWMFV5alhkY1pJRGd1MTU1S2Zva1JWQi9KbjU0N3J5RG1RclVVUllR?=
 =?utf-8?B?UWpjYzJCT3BxcUhWKzQ5SmI3S0xERVBsQTdDK0RGU3ZpYkhlOW93dncyUTR4?=
 =?utf-8?B?YWF0dWhvSUZzWFVuSlcvaU9nNm1rQXkwdEdURGhZRmJTWER4R2hDRk5mSnh0?=
 =?utf-8?B?RFdiQW52WUpXNVdRRGJOYXZERnl2UmJqTUR3cTR4c2o2MVprOFJQb0QvVUFO?=
 =?utf-8?B?UlU3S3F0Q0dFeDNHejF6MGN5bHU0Smtmak5NS2FEbUhuTHNnQStPeFQ0azRq?=
 =?utf-8?B?cnIvOE5BcWhKdHR3Y2lTTWd3cjR0Q212WWN4NjdTQWE1QkJSRkVsUUxNSzYr?=
 =?utf-8?B?YXBHRng2TDBBRDhLcGdVVkNxc0xJRTdacWR0VGZ5Um91dDVwZGFmVUd5Q3JK?=
 =?utf-8?B?YXdiWW1kZGdaYmNOLzhjRGZoR3ZtZm0rcXdxR21LcXArWHVCaEtlSmdodmhl?=
 =?utf-8?B?SWx1V3hSc0ZoV0hkWGtienkyclFvTzQ3UmtOT0FodjBWQW9iVFZjYUtXeHZo?=
 =?utf-8?B?TmpuYUo3dnJxSlIvdkViakgrOHc3Zy9FSDFPc25GZlZyWkdMSHFjQ3FsYTZq?=
 =?utf-8?B?Y0ZCSVhtNWZCQWF4dklkYnAzWXhvTmNwKzJ1QmR3TWRjeDljREZlMmQ1WmND?=
 =?utf-8?B?c0pmNW1XMk91c3RibTE2SDJTRmNobXVrNWVXYjg2c2w5WE92bmZoK2w2WUlJ?=
 =?utf-8?B?WkM2R3FGNFRNZlBHd3JqNXR5TkNKNE9vRHlpdjdoZGhQT0VyUnNYNTZWUTJi?=
 =?utf-8?B?NWo5cFNsSzVhQkVrOEMwS2pJK3FINVJ4MkpjazlYYnR3dkUwUzE5RHlFT2hD?=
 =?utf-8?B?TEdJVHNRN2JQNXIwVnpQZEF3R2gyZEpUdmlVZS9TemtyRU5uQ1hBWUhmd3R0?=
 =?utf-8?B?ZEpSV2xIb1pSeWdsaVgxVlBXOWdrT0ZmbnpUclNWVDdDRjQ2bTROM1c1aUd2?=
 =?utf-8?B?K3Q5SVRXNE9wd3IxdVJLQllMMnRqNnVsOU43WWFmd2thZ0xNNG9Dc0U5SmtH?=
 =?utf-8?B?VGpWalo5b3l6bk1yMGdSK1ZVajlFOEZRNW05cjR2U0R6bTZ4WSs5cU4wdkRt?=
 =?utf-8?B?QmtNcjRvTnZaS2RnUEx1b1RvbGx5b01ySVJkT1BFUmcrdWo1aUp1cmxkNUQ0?=
 =?utf-8?B?cXdUd0hJTGUwcnNnQTI1d1lPb09taWl0ZWFFVHlzRktiejF3cWIxOWVUakQr?=
 =?utf-8?B?NUE0ZEJVbjVZUWRucEZDaUdRUWp3VFRJak1KK2F1eDFmTGNHTTE5blg5byti?=
 =?utf-8?B?SktEYVdKcG95Yi96QUt4KzlQY2tFMnlVbi9rWlFNdjAzODlWZHptZDdkVUdE?=
 =?utf-8?B?MHllR1ZuUEhYSkhnc1kzSFdBSjhCSHlnajg1OHM2MnNveVdDSEpuaHRzdHA3?=
 =?utf-8?B?Zkpwa2psNGowWm5yOW5QY3lJRHgzYzRaM2lrSGFmWFExK3h5L2xuUT09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-D7RItezdWtSVYneCKvpg"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf87798d-a086-49f2-b6f2-08da29ce5225
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 10:52:14.3926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2klgh05FdoBT55TaYzJdA4ELHOXDBp1H0UoAL/5men1iz9SM7kypb8w1Wk3BDe2hKntONTsbSo79Qovrgdx2PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8032

--=-D7RItezdWtSVYneCKvpg
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2022-04-13 at 12:00 +0200, Jan Beulich wrote:
> On 12.04.2022 18:11, Dario Faggioli wrote:
> > --- a/xen/common/sched/core.c
> > +++ b/xen/common/sched/core.c
> > @@ -572,11 +572,41 @@ int sched_init_vcpu(struct vcpu *v)
> > =C2=A0=C2=A0=C2=A0=C2=A0 }
> > =C2=A0
> > =C2=A0=C2=A0=C2=A0=C2=A0 /*
> > -=C2=A0=C2=A0=C2=A0=C2=A0 * Initialize affinity settings. The idler, an=
d potentially
> > -=C2=A0=C2=A0=C2=A0=C2=A0 * domain-0 VCPUs, are pinned onto their respe=
ctive physical
> > CPUs.
> > +=C2=A0=C2=A0=C2=A0=C2=A0 * Initialize affinity settings. By doing this=
 before the unit
> > is
> > +=C2=A0=C2=A0=C2=A0=C2=A0 * inserted in the scheduler runqueues (by the=
 call to
> > sched_insert_unit(),
> > +=C2=A0=C2=A0=C2=A0=C2=A0 * at the end of the function, we are sure tha=
t it will be put
> > on an
> > +=C2=A0=C2=A0=C2=A0=C2=A0 * appropriate CPU.
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
> > -=C2=A0=C2=A0=C2=A0 if ( is_idle_domain(d) || (is_hardware_domain(d) &&
> > opt_dom0_vcpus_pin) )
> > +=C2=A0=C2=A0=C2=A0 if ( pv_shim && v->vcpu_id =3D=3D 0 )
>=20
> I don't think you can handle the shim case first, as then you'd also
> have
> its CPU0 idle vCPU take this path. The difference _may_ only be
> cosmetic,
> but I think it would be odd for CPU0's idle vCPU to have a soft
> affinity
> of just CPU0, while all others use cpumask_all.
>=20
Ok, yes, I didn't think to that. I'll reshuffle the if-s order.

>=20
> > +=C2=A0=C2=A0=C2=A0 {
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * The idler, and pote=
ntially domain-0 VCPUs, are pinned
> > onto their
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * respective physical=
 CPUs.
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sched_set_affinity(uni=
t, cpumask_of(processor),
> > &cpumask_all);
> > +=C2=A0=C2=A0=C2=A0 }
> > +=C2=A0=C2=A0=C2=A0 else if ( is_hardware_domain(d) )
>=20
> ... here I wonder: Shouldn't this be limited to Dom0 (for the
> purposes here
> !=3D hwdom)? Any special affinity for a late hwdom ought to be
> specified by
> the logic creating that domain imo, not by command line options
> concerning
> Dom0 only.
>=20
I think this makes sense. I'll add a patch for changing it.

> I also have a more general question here: sched.h says "Bitmask of
> CPUs
> on which this VCPU may run" for hard affinity and "Bitmask of CPUs on
> which this VCPU prefers to run" for soft affinity. Additionally
> there's
> soft_aff_effective. Does it make sense in the first place for one to
> be
> a proper subset of the of the other in _both_ directions?=C2=A0
>
I'm not sure I'm 100% getting what you're asking. In particular, I'm
not sure what you mean with "for one to be a propper subset of the
other in both directions"?

Anyway, soft and hard affinity are under the complete control of the
user (I guess we can say that they're policy), so we tend to accept
pretty much everything that comes from the user.

That is, the user can set an hard affinity to 1-6 and a soft affinity
of (a) 2-3, (b) 0-2, (c) 7-12, etc.

Case (a), i.e., soft is a strict subset of hard, is the one that makes
the most sense, of course. With this configuration, the vCPU(s) can run
on CPUs 1, 2, 3, 4, 5 and 6, but the scheduler will prefer to run it
(them) on 2 and/or 3.

Case (b), i.e., no strict subset, but there's some overlap, also means
that soft-affinity is going to be considered and have an effect. In
fact, vCPU(s) will prefer to run on CPUs 1 and/or 2, but of course it
(they) will never run on CPU 0. Of course, the user can, at a later
point in time, change the hard affinity so that it includes CPU 0, and
we'll be back to the strict-subset case. So that's way we want to keep
0 in the mast, even if it causes soft to not be a strict subset of
hard.

In case (c), soft affinity is totally useless. However, again, the user
can later change hard to include some or all CPUs 7-12, so we keep it.
We do, however, print a warning. And we also use the soft_aff_effective
flag to avoid going through the soft-affinity balancing step in the
scheduler code. This is, in fact, why we also check whether hard is not
a strict subset of soft. As, if it is, there's no need to do anything
about soft, as honoring hard will automatically take care of that as
well.

> Is that mainly
> to have a way to record preferences even when all preferred CPUs are
> offline, to be able to go back to the preferences once CPUs come back
> online?
>=20
That's another example/use case, yes. We want to record the user's
preference, whatever the status of the system (and of other aspects of
the configuration) is.

But I'm not really sure I've answered... Have I?

> Then a follow-on question is: Why do you use cpumask_all for soft
> affinity in the first of the two calls above? Is this to cover for
> the
> case where all CPUs in dom0_cpus would go offline?
>=20
Mmm... what else should I be using? If dom0_nodes is in "strict" mode,
we want to control hard affinity only. So we set soft to the default,
which is "all". During operations, since hard is a subset of "all",
soft-affinity will be just ignored.

So I'm using "all" because soft-affinity is just "all", unless someone
sets it differently.

But I am again not sure that I fully understood and properly addressed
your question. :-(


> > +=C2=A0=C2=A0=C2=A0 }
> > =C2=A0=C2=A0=C2=A0=C2=A0 else
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sched_set_affinity(uni=
t, &cpumask_all, &cpumask_all);
>=20
> Hmm, you leave this alone. Wouldn't it be better to further
> generalize
> things, in case domain affinity was set already? I was referring to
> the mask calculated by sched_select_initial_cpu() also in this
> regard.
> And when I did suggest to re-use the result, I did mean this
> literally.
>=20
Technically, I think we can do that. Although, it's probably cumbersome
to do, without adding at least one cpumask on the stack, or reshuffle
the locking between sched_select_initial_cpu() and sched_init_vcpu(),
in a way that I (personally) don't find particularly pretty.

Also, I don't think we gain much from doing that, as we probably still
need to have some special casing of dom0, for handling dom0_vcpus_pin.

And again, soft and hard affinity should be set to what the user wants
and asks for. And if, for instance, he/she passes
dom0_nodes=3D"1,strict", soft-affinity should just be all. If, e.g., we
set both hard and soft affinity to the CPUs of node 1, and if later
hard affinity is manually changed to "all", soft affinity will remain
to node 1, even if it was never asked for it to be that way, and the
user will need to change that explicitly as well. (Of course, it's not
particularly clever to boot with dom0_nodes=3D"1,strict" and then change
dom0's vCPUs' hard affinity to node 0... but the user is free to do
that.)

> > --- a/xen/common/sched/credit2.c
> > +++ b/xen/common/sched/credit2.c
> > @@ -749,10 +749,12 @@ static int get_fallback_cpu(struct
> > csched2_unit *svc)
> > =C2=A0
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * This is cases =
2 or 4 (depending on bs): v->processor
> > isn't there
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * any longer, check i=
f we at least can stay in our
> > current runq.
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * any longer, check i=
f we at least can stay in our
> > current runq,
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * if we have any (e.g., we =
don't yet, if we get here when
> > a unit
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * is inserted for the very =
first time).
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( likely(cpumask_interse=
cts(cpumask_scratch_cpu(cpu),
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 &svc->rqd->active)) )
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( likely(svc->rqd &&
> > cpumask_intersects(cpumask_scratch_cpu(cpu),
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 &svc->rqd-
> > >active)) )
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 cpumask_and(cpumask_scratch_cpu(cpu),
> > cpumask_scratch_cpu(cpu),
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 &svc->rqd->active);
>=20
> This change is not covered by anything in the description, and I
> wonder why
> you're making the code adjustment. If svc->rqd was NULL, wouldn't Xen
> have
> crashed prior to the adjustment? I can't spot how it being NULL here
> could
> be the effect of any of the other changes you're making.
>=20
It was crashing on me, with the above changes applied, but it's not any
longer. It's certainly something that, whether it's related or not,
should be addressed in its own patch, so I'll get rid of it and keep
looking.

Thanks and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-D7RItezdWtSVYneCKvpg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJrw10ACgkQFkJ4iaW4
c+48aBAAi/uUqg/uL1InvU+g0/Gz3SHq+KVpoEH06n8cFi0k9bfS1tPjk7wLliJv
EfVOcaihflM+mE+qGAPvkAJK5C2T0fJ8yLLxF4PMIghdtTh90wIGk9bU08ZUrr4S
at/mHiEVi2j4C62AER+XLcPbXuseL/wpFIlx0MGoXxUAIT8STycEwPyMB4+n5JpL
mXbUCrf1RXy8CYSIM1WlpFSWRME8xgIoXdWQ7ZNqi2xL8jJtfrWmXJxZtpNyQb6S
JyO8XkSKPeVEeNDqL8f96XYUAn1N6OjQ8urjk7xxtngzQ1qnNP7p89M06L8sO4eE
uuYJ8XJpLNUDoQeqFc9SUdf0t+GpQbSFSVYSfoP6CIC3KmAJseHy3whn1JHJK0B4
dJ+N2g/HLZojv0s0ACYbN28KNS+xvkuHCpJkFXb8K+40zooSI3eH/NKoEEvTUsNV
Dr3IoI26NvPKMWqZBYZ6+tro6rJoRNiRsYemZBNZ/AFDrQzpeKO5rgLm8LEvPKka
nq3733/UqmJTwZTnb+Mop/xThihLi+RLJsegn5NjFRTCLrfyEuMCEMtG+gAxvzAk
RX+rVe+fuvrczZnoZRxHanUWsB6YhNciSlXQraQQ8ZlmVq87fG6M7rhXVVPg820h
8+poiXlH8x0lH3HHQ2PhB4NBoScGhhGVkxXzEvKQYMswbqNt+IA=
=04yJ
-----END PGP SIGNATURE-----

--=-D7RItezdWtSVYneCKvpg--



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 10:53:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 10:53:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317207.536439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOFO-0007bU-HE; Fri, 29 Apr 2022 10:53:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317207.536439; Fri, 29 Apr 2022 10:53:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOFO-0007bN-Dq; Fri, 29 Apr 2022 10:53:14 +0000
Received: by outflank-mailman (input) for mailman id 317207;
 Fri, 29 Apr 2022 10:53:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkOFM-0007Ts-Ic
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 10:53:12 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8d8a7dbc-c7aa-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 12:53:09 +0200 (CEST)
Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 06:53:07 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BYAPR03MB3830.namprd03.prod.outlook.com (2603:10b6:a03:68::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Fri, 29 Apr
 2022 10:53:05 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 10:53:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d8a7dbc-c7aa-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651229590;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=rn8HoirgIUtMGhmXEOM+O02eDFwQQ6tUdewazmDcdEo=;
  b=WennZqCx5fI5uUt3Qi6pofGyCRjEjvrHekmC0j7f/N30cnmNacfQxbxz
   HTB36yM/YFgslvhfBWsZV6eEaDEuSPR45Ftay6dQSBxEIXwoRkHp3DLWh
   P9tfZ5l033F2kK+7mpE6cPUi4t3usMKD5FIAf+Suv3/MUyOAqY6PxdizK
   A=;
X-IronPort-RemoteIP: 104.47.56.176
X-IronPort-MID: 72685141
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:INWSv68zl8IdTOUtTNclDrUDl3+TJUtcMsCJ2f8bNWPcYEJGY0x3m
 DYdDGzQM62PNzTzeI8ga9zl9E4DuZ/Xy9ZjGgM5qy48E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3YLoW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaa9VAp5P7XNofwieit4FCshHohl04aSdBBTseTLp6HHW13F5qw3SWoRZMgf8OsxBnxS/
 /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvuMvIAGtNszrpkm8fL2f
 c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGcG+A/M+fNfD2776F0v26e3bsfpc4bSAv18r2Kdl
 2Dl4DGsav0dHJnFodafyVqujOLSmSLwWKoJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvH/UAe/u2WspQMHVpxbFOhSwAuK0KvPpQGCGnIDUCVCefQhrsY9QTFs3
 ViM9+4FHhRqubyRDHmar7GdqGrrPTBPdDBcIygZUQEC/t/v5pkpiQ7CRcpiF6jzicDpHTb3w
 HaBqy1Wa6gvsPPnHp6TpTjv6w9AbLCQJuLpzm07hl6Y0z4=
IronPort-HdrOrdr: A9a23:aCKcEKAqONs8r8TlHeglsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN
 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d
 enl4J6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr10jegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKva/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdY15dPoWXo8kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ1yHtycegB2w
 3+CNUYqFh/dL5pUUtDPpZwfSKWMB26ffueChPaHbzYfJt3SU7lmtrQ3Igfwt2MVdgh8KYS8a
 6xJW+w81RCNn7TNQ==
X-IronPort-AV: E=Sophos;i="5.91,298,1647316800"; 
   d="scan'208";a="72685141"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fqgyWQpg0jp4pmSi5wPaznPxjBa8ORa0TjOdM8yocDozNZLt886c5afBYT9gLtdyUWi7miwbwwiFOSnkB94PLHnPLIWpVncER7GZOKl4nOBxZBhaCyPSjTmwFFSpMkKAldpd1RCP/hzhb17iF7C2nkgTMpufQ8hFWXKXHUqszNTK8zw7qm7cRlt/bAsYxX5Lm4YRC77VmY2SXD/bEsmDnMvg5MyExbwpe0tf0qTPubiy1e6UVdQ1ooYimzgd8XNZaxLl85WoD0b56BomRYQbViVDxNp4OKCPVmpXIPxDkr9AtHEhnySLG19tHPaZjdduPk2MoiQ5edans4iZwI8x0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aDds1ie+iWLIsDLC6wx3t+BDr0rs9GWxIhLkxGO0BiE=;
 b=hhChodlEkQr3bRt3pER7HZic4JGCt1F0tbOEY3ZE+ZHuNjQOb3T2/EZoheXcpuXXPoZ2VOVASDPnzvXfm/U/JIKsuZlyT/fl6ZBLmQJx8KcQKVzmFVXI3pWTsytL1IGHtMVgQGM/TQ69iODfqa7qR9VJC2MAWc+k3C3VGdGHblgIdcKc42e5tqAqsxqXZzVj+8KqF9V5HAqIyM8DFLg1N3R2VIuC2j2lpkyTxwoR5GK/AwYKPcfaUahf1qwi99ImCtpkuQ+D/vCU073RyaCN8YWNNWOW5h5R78jNn7Daa9Vp4Ax+2AJDmgKnIq/o0DA1THq/rNzxzoAR99LVtgCbZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aDds1ie+iWLIsDLC6wx3t+BDr0rs9GWxIhLkxGO0BiE=;
 b=t/yZet6lMCrr40uMe83uLOZ18kHxwT4zze9mDpuhqwASy3Og+Cft800ZxNeDRscmmlRePcjeMS3T5qVXwyhsP8u7i8Oxs4UAQckGiTbBSNGvNz8hliM8tccVLqVrKWngWoaCuHTuJilWnttZzGE8POAMJe0gJluOgQ6KUOq/gLA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 12:53:00 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: x86/PV: (lack of) MTRR exposure
Message-ID: <YmvDjI4hmmhZ90fi@Air-de-Roger>
References: <b3f07165-67f0-3d50-e249-2618a2dc862c@suse.com>
 <YmubOeYPqW5mBNy4@Air-de-Roger>
 <2a229df5-c341-9ff0-ae5c-cc0d848d7cea@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2a229df5-c341-9ff0-ae5c-cc0d848d7cea@suse.com>
X-ClientProxiedBy: LO4P265CA0011.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6be91ef1-1e40-46f9-7175-08da29ce70ae
X-MS-TrafficTypeDiagnostic: BYAPR03MB3830:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<BYAPR03MB38303958BDE3EAC808A5CE7D8FFC9@BYAPR03MB3830.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AipcQYtc/qHVyTWUy2Mbmtm3glM30fUmavztfdN0Oa+Ay3vArUktNMougfCHF9VKGfWEvUuMn4KGvIXE71QL95+jMKM4MB1S3AiNtumRdSWgrJiyE+yHaItQpeihVpk/leNECIwnkQwJaGSjInK254SqhnRW2JXA6rH6PQnr7dpjKRK/oZXAgWxBauR7VCsHZkQkCv0OMOQNKZyut7uxhOwFVASM9qDrqOaqCCm+E8sqqbfvIjTN3s8HR9jdh9I3CdGTiVh579dHYvxj1ZkJbUjjs57WMYWkZCDxx4jBOSuCAMF91qbOBWvCxDtvRvkh9gt9ohOg2hxHWM5/PVe8HKYw6eMz2p97/z10jFZslw9liDxJixia4pJ/hlZ/jXWeuvZktiy5BG/+9Xr+IdNucDAPo5c7NA7XijlWouKSm3paUnoOo4MUiNoh7rHa/7DNZVN/51ZbrpALiQ0HFmWHRSmCKitOBfEbPAAbwHoZ63NQ5jk489z+Rmg4QWXbF6b8LRzeNr8H3ruj/UtlPpAVLC9Xnl0XELY2juXOWi8B8Y/sHKQJJcUnABYqHUXZS3NNJSpmL0Mz0H9vPaLGZicwinBj952gkaEOeLJKfyXY4yuKx12MRc1Oz8oVBXqAWpMlxMh0VMgADCi8pKFzQaXqhA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(4326008)(66476007)(2906002)(66946007)(66556008)(5660300002)(85182001)(8936002)(83380400001)(316002)(53546011)(186003)(508600001)(26005)(6506007)(6512007)(6666004)(9686003)(8676002)(6486002)(6916009)(54906003)(82960400001)(86362001)(38100700002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TzZndXkwWjdUdVkvWWNUUWZna0pVS0QydXowVy9rRXFabmV4RTMrcndyc3Zw?=
 =?utf-8?B?ZUFlalNyYnpLV3c4NGw5TG9Jd09mQTR0WnI2ck5IZW1nUXBUUlNyRlpTclFM?=
 =?utf-8?B?cWwrTlVoTHhuakcvQXF1K0J1eUZER2JmRTZkdnNDUXVoQnZ3QUhkMzk3Wjk2?=
 =?utf-8?B?OW5DMytUTHJid3hUWE96NWpaMm44czhUQ0hjLzFvQkJWcm1DUElEWFJQQXV0?=
 =?utf-8?B?RHlrTDJNUk1xMlgyQU9DK2lDSEFBRlI0OEFvd2FQM0pkNVA0UVBtbFNLa2dk?=
 =?utf-8?B?WWtBRGpOdEhNamR6azh2NTRRT3lSaHIvWHg5aHF5MmMwMm4rUGJGMHYxZDF0?=
 =?utf-8?B?dElFdWg1d0pGMWErMlFHcUdhNEkwa1JzanFUQm1mUmdsbCtmaWpCczVJaDVD?=
 =?utf-8?B?cFBpZW1naEZ6cU83eWdxYUpuVzlHV01HbUJBU3NHSnB1N201ZTV0Y2hySnZv?=
 =?utf-8?B?TEZ1YVBMNVM5Q0xpZGFtcHhsUVh0UTRUQmsrU2hpOGN6TVNCQ1R5dzNEOHgr?=
 =?utf-8?B?bzljZGY5c1RiNTNtMG9VYW5WV2RLQ09WM0svQ0dLc3Brd0ZYQVVRWWtDWG1k?=
 =?utf-8?B?Vy9pNEFxamt4a2EwelFKZ2R5M3Q0eWRIUkpOUzN2dWR3MEhBWGtNNkZJbU11?=
 =?utf-8?B?MmJmbmZDaFFsYmoyUWppVEEzK1dRQWpIZno4VHZLaDNUcitGYWw1RWsycEJt?=
 =?utf-8?B?REhHdEhDbWE2bXN1aFBvRHJTRkk4RUUrSVoxRmdPZlpCY1VJcUhKSm1qN1Bs?=
 =?utf-8?B?QlM2cG5PZUx4YmVpbS9jWW9mcEtpM09TYWNpYXorUEx1OG1VcVBEeUJlRDRR?=
 =?utf-8?B?WnA0WCtwLy9lL3NwTTMyTERIS05ETkwzOGNBcEpQa1creWtXb2dhdTNwbEcx?=
 =?utf-8?B?WE9uMDB2NGVSOE1SSmFQaENMVk01eEg1bENIMm9YN3lDNnBlOXB2SnYxRVU1?=
 =?utf-8?B?eFNXYzRVMDhDbUZDUnVJYXYxbU95c0p5K0FucGk0bFRzVGRCZ0F4eUNhK2ho?=
 =?utf-8?B?SHJ0Sjc5SGZ4TUo5YlJyTEhiYlpMMitxOGswZ3JPU0tUZmpYcnZCTUYrL3k1?=
 =?utf-8?B?SDRjUG1GWHdCclNwcW9mZkhKRCtmclltbk5xQlE4bHY4OTF2QnlDTjZUTGhN?=
 =?utf-8?B?ZVBYNGFDTGh4REtHc1g4MTlpUE1sWmp1NWhCNk0yU3gzOEgrZTg3RTlkczdl?=
 =?utf-8?B?RnEvZFB4YTdxMjVBUVdiTUpSUHJmcGFudklnbzRhZUcxektaa1lmRjB1ZGgy?=
 =?utf-8?B?QlhaMjVyQk5IeXZKbFY3dmt3Z0ZnMW5XR2lZK0ZLWjBVTUU4c3FuK1ozYVMx?=
 =?utf-8?B?RzBDeUZVSzZhVSt0Yk5CelYwQmxscWNCMXNKelh0blpZai9MRGVLSGlmbEhq?=
 =?utf-8?B?NmlGUkdQeFFuVG9hQ1BGMmVlbkFrYzVjbVFyWlRqU0hUYTJVakNjcXl4RXdp?=
 =?utf-8?B?aGRxRlZrTUVra0NPaTFWRDh3Wk1EZ1UxUUpGbVRUNlZHZnJMVFBCZThtdHAx?=
 =?utf-8?B?Z3RxeENsdmVnU3ZVN2tFdUJZU29peGVXVjNheTlDQmg1THRITVNjd2lwMDd2?=
 =?utf-8?B?RU93enFZUkVsUWZnbnZldm1pdzVBSnQ5VUFxWXkxc0F5clVla2VaanJ6VGNH?=
 =?utf-8?B?S0ZWSXEyelVKYUpEcHRKYm1BV1RGTjZxclZHV01lQnJNZFZNM1drK3VEdzB1?=
 =?utf-8?B?aXJTQVpuanhoOC9lZTl0Nk1KRk9sYkxQakdvMVJqU1graWp3VkhGYUZDb3dJ?=
 =?utf-8?B?N29VbHc4MDVzeUhESWNWbU5hU25tdU5BNHJSVkYxdXkyTXNDbU9pVDRKMGNY?=
 =?utf-8?B?WHpEWFV3elg5OU5BcmtDUUpiSjBDb2V4dHUzQmhiaW0yYzRmbjdEdjJDVXlQ?=
 =?utf-8?B?VEFrSGEySE1kdDVUbG5rTHRXbmVHaXc0V3hUeEZXbjV2c0hiNTl2ejhUK05W?=
 =?utf-8?B?WThkcE1zUGQ1T3ZDNytOU2VXOWhVdzVVc2RNblQraEdpbWFNeTYwZ3ZSblQ0?=
 =?utf-8?B?K0p2WHBSOXNFemlPVDlwNzRKa2hHeTBBdTRjQkFMVFdqbDdnM3kxTUpTQ29S?=
 =?utf-8?B?UGs0RTZaM1hRZnk5QUEyKzlIUUJPQ3RaNGQ4SW1xdnN5WVVVZGN2b0xuUVY1?=
 =?utf-8?B?SGJaTGc0c01nb1lEQlZVMkU0Q1p5L3g2a1o1THh2eEc2S3R5RVlLU0J5cytD?=
 =?utf-8?B?ZHZPNk5MTzJUY3JJVWhBdXk5QWZsMHBOdnA3cW9RaEZzY2RCUkZNcjZZS0ps?=
 =?utf-8?B?TFNOL0VEN0xkbkRjVUxXaDFNNFMrUjV4VkJSZFk0ckQwYy9lM1M0TkZmOU1h?=
 =?utf-8?B?bUVSeHVCeTY4dFlzeVRwVFREWE5xSnZVc3d0c0luQzB4UFJsN05tRDBSS3BN?=
 =?utf-8?Q?pyAfX+a1XoF/+kZg=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6be91ef1-1e40-46f9-7175-08da29ce70ae
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:53:05.8234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iW5NT7O6sn6P7rv3axfJy1uKm/8fHwZuJyaNAlwUo90WXS4JWaT9k5IAYrxcKkMhfOD9cdSlEQxX5DZ2MS04gQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3830

On Fri, Apr 29, 2022 at 12:00:21PM +0200, Jan Beulich wrote:
> On 29.04.2022 10:00, Roger Pau Monné wrote:
> > On Thu, Apr 28, 2022 at 05:53:17PM +0200, Jan Beulich wrote:
> >> Hello,
> >>
> >> in the course of analyzing the i915 driver causing boot to fail in
> >> Linux 5.18 I found that Linux, for all the years, has been running
> >> in PV mode as if PAT was (mostly) disabled. This is a result of
> >> them tying PAT initialization to MTRR initialization, while we
> >> offer PAT but not MTRR in CPUID output. This was different before
> >> our moving to CPU featuresets, and as such one could view this
> >> behavior as a regression from that change.
> >>
> >> The first question here is whether not exposing MTRR as a feature
> >> was really intended, in particular also for PV Dom0. The XenoLinux
> >> kernel and its forward ports did make use of XENPF_*_memtype to
> >> deal with MTRRs. That's functionality which (maybe for a good
> >> reason) never made it into the pvops kernel. Note that PVH Dom0
> >> does have access to the original settings, as the host values are
> >> used as initial state there.
> >>
> >> The next question would be how we could go about improving the
> >> situation. For the particular issue in 5.18 I've found a relatively
> >> simple solution [1] (which also looks to help graphics performance
> >> on other systems, according to my initial observations with using
> >> the change), albeit its simplicity likely means it either is wrong
> >> in some way, or might not be liked for looking hacky and/or abusive.
> > 
> > I wonder whether the patch needs to be limited to the CPUID Hypervisor
> > bit being present.  If the PAT MSR is readable and returns a value !=
> > 0 then PAT should be available?
> 
> I simply didn't want to be too "aggressive". There may be reasons why
> they want things to be the way they are on native. All I really care
> about is that things are broken on PV Xen; as such I wouldn't even
> mind tightening the check to xen_pv_domain(). But first I need
> feedback from the maintainers there anyway.

Right, I did also consider suggesting to limit this to PV at first,
but I was unsure why native wouldn't also want such behavior.  Maybe
there's no hardware that has PAT but not MTRR, and hence this was
never considered.

> > I guess we should instead check that the current PAT value matches
> > what Linux expects, before declaring PAT enabled?
> 
> I don't think such a check is needed, the code ...
> 
> > Note there's already a comment in init_cache_modes that refers to Xen
> > in the check for PAT CPUID bit.
> 
> ... in __init_cache_modes() already does it the other way around:
> Adapt behavior to what is found in PAT.
> 
> >  We might want to expand that comment
> > (or add one to the new check you are adding).
> 
> I don't see what further information you would want to put there.

It would depend on how the check ends up looking I think.  If the
enabling is limited to also having the Hypervisor CPUID bit set then
the comment should likely mention why setting it on native is not
safe.

Anyway, let's see what maintainers think.

The other option would be to set some kind of hooks for Xen PV to be
able to report PAT as enabled (maybe a Xen PV implementation of
mtrr_ops?), but that seems like over-engineering it.  My main concern
with setting pat_bp_enabled to true is whether in the future such
setting could be used to gate PAT MSR writes.  It's already like this
for APs (in pat_init() -> pat_ap_init()), but we avoid that path
because we don't report MTRR support AFAICT.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 11:00:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 11:00:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317216.536451 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOM1-0000aF-E7; Fri, 29 Apr 2022 11:00:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317216.536451; Fri, 29 Apr 2022 11:00:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOM1-0000a8-8W; Fri, 29 Apr 2022 11:00:05 +0000
Received: by outflank-mailman (input) for mailman id 317216;
 Fri, 29 Apr 2022 11:00:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkOM0-0000M7-7b
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 11:00:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 851bd576-c7ab-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 13:00:03 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-ev0zMhsoOlmHcHOJjS7JdQ-1; Fri, 29 Apr 2022 13:00:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM0PR0402MB3506.eurprd04.prod.outlook.com (2603:10a6:208:17::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 11:00:00 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 11:00:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 851bd576-c7ab-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651230002;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XCNHfbP1+2Osqn+Qk2ZaU3/aNHtjuqChHD0R3hCrAPE=;
	b=Tt3FcuWsAiXqmcvwF1qqAvOv+dezRlpS16FMxJ25DgfHJF9reowF2gNYeUDCdmJixTROE/
	wVrIwg/IOMu8t5cPreBJhM7u2I+UM05L4iSz0vhQx1i/nD4WwWJTTUBTJ+ejKtmzHL4QrS
	mbnQGJvZGExZsstkmoBm9ovui9m0kc4=
X-MC-Unique: ev0zMhsoOlmHcHOJjS7JdQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YDYd8bCUKvf20KHg0xrujZlqT8LIpO5F+m83rZgBXNknDwPUtGj9JLU+IAEhqZ+2QHa6EvxAbr0NzavZ9FV6RVjXSLYV5VT9lsmAu2gj1wdSaDlZtnUAyy0w4rQ3cHZQ5YX1FPGRO9E7AodRAI6Lyj4M94O167vOIJc2i3CEGudvSvSbt/Ku1nA/BKYiGe67BVsBRlDw6IZrOebuPCTRA3zmkOWS7/5/g8jFQcPEKaJqQhsCiTf3rccjM2+u1AjqIFcpNWV3i1q8t5Ob2aqDBEtDCyu9CyqZQfpt5BKY93oJSQOxt4nv2YvJv6W2BhacMZRb0QE+nQLAmwPn9Xph2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XCNHfbP1+2Osqn+Qk2ZaU3/aNHtjuqChHD0R3hCrAPE=;
 b=O9rTPch+PKJQKRQsLsn8tQ286EwwC1SvAkJHYEPIZ0p/z2iE9h3UEMkUWjiuWjA6NRXuTzCFG/Zym4959mVmXGREqBNTW+qbN5L6Qv+O1dUtK3MzXh/JZVwDB/M1+fSH2hsWjgn9Opwnc+ZDL8+UlC+rFBjBLqh+VbVpdizBFNOlnu8WLuLNh/Kw88WuxRZD2nxJ76x2q91ka3Zplu5fDFzFX+idqsiTfe8JH82Cs+oNoFb4A8+y3Qs34/4GL7qAEBB7dq8xpZM8o3reoS8QbkLdM7J5etLar6EvFbGIfgiuqVOFoUwghlYR/Tl9Ex2wX/Kg3KsVJhv/ZfcHZ09AEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <38f0e56e-f72f-698f-c4c3-5973ec9e46a3@suse.com>
Date: Fri, 29 Apr 2022 12:59:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220427104718.81342-1-roger.pau@citrix.com>
 <20220427104718.81342-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220427104718.81342-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9P251CA0001.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:50f::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 644d2b14-9ffd-4839-3a8e-08da29cf678c
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3506:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB350698FF385BB1492828BDE5B3FC9@AM0PR0402MB3506.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DL85ujGkMsCW/9p0fGYFlgPZi6axce7sAh/oqjCXqHRK+Z+FHxlQqnWBTkrSqnAaScxrR6Sy93YqGsU/oXgc+tW0eLRjoS0NUKOA8bbHYznPcUyhrPitcamiMbFRaZ11mpE7ZgAYH9ym+L3ThzlEVMjWjt40lwrWoVoTsVe2zoMJUxna7KivErclqgT+MLEEWzBLXB7c2TssQ1rLYi0zXJPKa8rVmjUqkEq3S3wcNLp0bnoDd4U43RiPqtOku17kOdqiS3ThQpK+tA+Z6iRn5cXFX6hNy0ZpbEh9e98q5/g4ZJ1bs9nOkaXALvDGVb6sJuWvVnqIry2UeGTW8GfcZ/hjrVJ2YeRIuMi34KY867gTM7cKNrzpIwn1Dn7TuM673gBwsKKZGCcz8z5/1YzMku41p4CQVY41WniTzmeo8+WAPS5VOQMCKt0ssb0XDi9cv8sC37vifzNmflIPCs73Dnj9eaUzLTg/DGFvX9yQpOrbegMfMm43rImcpLrrs6ageJ04Yr43yhcjUsLI37+iBAG/a0iClKx9vgzux45zpUAvCrEIf1b8b1PF4deV7Hxk1jJmRnX4EKiV2S/SMAkTi0ANEP+GVbbQCtWCS99WuRbkBOp5Z4sXrIFG1isY2Vmbp/lIAWBkiVipgtQCFvwIQyvE7CYiIc95cS86VliMABkPYYMtWAOjNiByZkVj0wDZxuXGWWKthPV2pUr/UhulvM6PckD/HtWhdftsX+RRFHw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(83380400001)(2906002)(26005)(6506007)(66946007)(6512007)(8676002)(4326008)(66556008)(66476007)(5660300002)(186003)(38100700002)(31696002)(316002)(86362001)(36756003)(8936002)(6486002)(31686004)(6916009)(54906003)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N05pTjVYaG5hUkxTSyt1NFoxc21lRmU0WDlvK3lXaXpDbXRWbmZmMmZJMjN6?=
 =?utf-8?B?SklpcEFCei9zOENJald2eTlwTGlINVh6SURtOThRNXlXQkpiR2N4M2xQai9C?=
 =?utf-8?B?VU41YmkzVG4raWgraFhrR2c1amdpT2d4ckRUalplOFBDR1lRMTZnVUo5czZR?=
 =?utf-8?B?OHI1TUJzbGFPcDA3N2orcHBtYkw0cUlDaHRQWGpKV0hSMGp4MnFzZkJIVWlj?=
 =?utf-8?B?dkExR05FOGdpeThlZ1pSN3FyLzZENC9BUnJhbm5JVDJUYklQZmgyU09heEZ0?=
 =?utf-8?B?dzdnYzFYOWgvYVQ0bTNHRTVTT2VDUXdiSjBScWRkUExiaFlIREZuT3Arb2pZ?=
 =?utf-8?B?UmpyZmdRbEJSMDNnSzMzc0hiVXgwNWgzbldQWTQ0RkI4c2tScmxxTzdZNjlP?=
 =?utf-8?B?cWxtYXE1MlFFdnBsMC8rSnhwTE0yaDF5dUt3dVFHWGZ0ZU05TW9DUmVWYnpk?=
 =?utf-8?B?aHB4NGpSbnd1bFVKUW1JMXVVQllBbGU2M2JnTkhzNEl5ZHRaSDRMVllJRUov?=
 =?utf-8?B?cmxudi96Z3haL1lQZzQzMWdxZStHME85aVNhSi9pS29wQk0wL1h6OEpIY0xv?=
 =?utf-8?B?dFBzVkV4TDZMdkxCalJtVHg4Q3BVZ3RkMG90cTJDY29yRnBWRzRLaHRKd1Vz?=
 =?utf-8?B?d3BEbmdNRkpmOFRveXBRRFVFY0wrQzk3SGtzbUNrU0wzakZ4Nk8xUVpZNmRh?=
 =?utf-8?B?QkVWUkUvYVF0T3hBeUVGcDdQdEsxUnJvM0JjQU9LQ0ZZS1E3TnE0RGpQdGdq?=
 =?utf-8?B?Qkg3L29teStoWUltRmlTekFRbmRENkoweVN6TDh1bkY1NmJlRFdZUkRJVVpK?=
 =?utf-8?B?K3BXZ1kxUjdsZzNLeXFxNklFR0xUeUwrdTBvbUdVbkFFdTM4Z2ZjbU4xMDFi?=
 =?utf-8?B?TWpuMEhNckMxV2p6Qm9hSzFERFhVSVRpak9zMWNzNVloSDdnSVdyc0JKbHJS?=
 =?utf-8?B?Rlg2RFYyNWQ4OWQvRHdPZGpuYUlOYURuazFOalB6c2I0MTVkcTFuUUlwaERR?=
 =?utf-8?B?NTZWQ2VtcVhwcG5zaCtLZzQyRU1VbHNINkM2R0wvL3dIV3JwV0I5a1ZJazdk?=
 =?utf-8?B?OU5HRFRrWXMwamhuOUdUbFhadWp1clVTTld4U0cvczNPU1lOVW5meWtodmtG?=
 =?utf-8?B?WjJlcDZKZHBuQW8rdnV5WDdyWDJFMXNlTWRMWkd1VlI1VU5hc2hibXRvdC85?=
 =?utf-8?B?aEtmZDdMUjA2dmF1Ylpvc1RsbWZ0WXEzTXQvemY4TCtWUnNpSFN4R3pYanJT?=
 =?utf-8?B?WDRndXJEN1pNTi9jRTJwZ3ZpVDBSelczRTlFcTFiK1AzOTVPMnB5MlpvcDgy?=
 =?utf-8?B?TXhYRk14bytDSmVEdGt0RUxrYVR0NlNJZCtrMmxNdWpXMlVDWEZoeFRmSkxJ?=
 =?utf-8?B?TUliaU0xOGFhKzJGc1FqYldES3k2QlViOXk2VEFjSXNmekcvcWpuNVFZMFdU?=
 =?utf-8?B?SlkxUExUbGVKNndpQ0ZjOFdXeWJqSGtxOUNhREhOeWtOWml3aUpZZDVXcjBK?=
 =?utf-8?B?MG4xSk5YRUVpaHFoZkh0V1hObXVnbndPOC8vb0I4aWQySGhVcmt1QXZpUmRR?=
 =?utf-8?B?Y20yb0ZTOWhQZVBsMVNoOTdjS3pTWE1PaEFyaFhORnRXV0F1V29xSmp5YUJh?=
 =?utf-8?B?d2xiK2tmQlNwOXUwaFUyMnhZM1FLbmNGNGNveHRiSFc1RjFJSWpxWlBqd2l2?=
 =?utf-8?B?ZGJSUlIwa2VlRTZ3eHpBVU5RTW1sM1ZZUmo0d05vT09URXBBSTQrOGxxRkRS?=
 =?utf-8?B?YjZNOTZmRzBSZDk1MnpOOU43MkF2L2RnUjhURnlyeTFkRUk2UVN2VlpXYmxr?=
 =?utf-8?B?R2FqOGhiV2FwOHVvM1NiTDF5aGZ6cmhqOVg5cGEwaWIrNTY0c251alFxM1V0?=
 =?utf-8?B?Zjd2Z1plbjIzRTZKUUlWNXJsZTNBTUV6S1AzcTRUMExLbHZXaGdwVTBwaFVq?=
 =?utf-8?B?YjIvYWRzMHlXZmpDK1FFM1BmMXpWWlQ0dmlmZjhSNzFRdHdzQmFxL3RpVkd2?=
 =?utf-8?B?cmxrTk5GSXNCMlU1em16bld0a0s0SzBoZ25PbGl6NmVYU1ljR0tZaCs3Y0dH?=
 =?utf-8?B?dU9DMmRwRDBnYVdwakhEaEF6M0ZZUGtua1lxdzIrdmhNZFFoV09CdUhuRFMv?=
 =?utf-8?B?WnkreDJZbit5dmRqRzBQK1RVOEhSOXJjL2pPdEJLZUxDMHFLVzZQTnFhMkh4?=
 =?utf-8?B?dnlENDZ3ckYvSkZVZDd5NUtHdGZ1RHhtMEY1TFBhRUU4T01qT0NUZjRCWWw0?=
 =?utf-8?B?WnczbVdHZ0Q3eUpESk9xc0VLZDNDZXk1RlJWNDl2KzgvWHEzbVFIdlNaREd1?=
 =?utf-8?B?NWVNT2NGaStZZlo0OS9TWmozK0hKVmI0eC9BQlhYOVpBYmJVZStzdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 644d2b14-9ffd-4839-3a8e-08da29cf678c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:59:59.9808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: grkC3Mx4B6VTdOSWh+vpAM+GDci9HixwNxVMcRFeTxbmHJaU7gbZoV7i/bTBNrMgTwk5FK7Ngnr4kMtV3QmD1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3506

On 27.04.2022 12:47, Roger Pau Monne wrote:> Changes since v3:>  - Align ssbd per-core struct to a cache line.>  - Open code a simple spinlock to avoid playing tricks with the lock>    detector.>  - s/ssbd_core/ssbd_ls_cfg/.>  - Fix log message wording.>  - Fix define name and remove comment.>  - Also handle Hygon processors (Fam18h).>  - Add changelog entry.
What is this last line about?

> +bool __init amd_setup_legacy_ssbd(void)
> +{
> +	unsigned int i;
> +
> +	if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) ||
> +	    boot_cpu_data.x86_num_siblings <= 1)
> +		return true;
> +
> +	/*
> +	 * One could be forgiven for thinking that c->x86_max_cores is the
> +	 * correct value to use here.
> +	 *
> +	 * However, that value is derived from the current configuration, and
> +	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
> +	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
> +	 */
> +	if (boot_cpu_data.extended_cpuid_level >= 0x80000008) {
> +		ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
> +		ssbd_max_cores /= boot_cpu_data.x86_num_siblings;
> +	}
> +	if (!ssbd_max_cores)
> +		return false;
> +
> +	ssbd_ls_cfg = xzalloc_array(struct ssbd_ls_cfg,
> +	                            ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS);
> +	if (!ssbd_ls_cfg)
> +		return false;
> +
> +	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
> +		/* Record initial state, also applies to any hotplug CPU. */
> +		if (opt_ssbd)
> +			ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings;

Perhaps flip if() and for()?

> +void amd_set_legacy_ssbd(bool enable)
> +{
> +	const struct cpuinfo_x86 *c = &current_cpu_data;
> +	struct ssbd_ls_cfg *status;
> +
> +	if (c->x86 != 0x17 || c->x86_num_siblings <= 1) {
> +		BUG_ON(!set_legacy_ssbd(c, enable));
> +		return;
> +	}
> +
> +	BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS);
> +	BUG_ON(c->cpu_core_id >= ssbd_max_cores);
> +	status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores +
> +	                      c->cpu_core_id];
> +
> +	/*
> +	 * Open code a very simple spinlock: this function is used with GIF==0
> +	 * and different IF values, so would trigger the checklock detector.
> +	 * Instead of trying to workaround the detector, use a very simple lock
> +	 * implementation: it's better to reduce the amount of code executed
> +	 * with GIF==0.
> +	 */
> +	while ( test_and_set_bool(status->locked) )
> +	    cpu_relax();
> +	status->count += enable ? 1 : -1;
> +	ASSERT(status->count <= c->x86_num_siblings);
> +	if (enable ? status->count == 1 : !status->count)
> +		BUG_ON(!set_legacy_ssbd(c, enable));

What are the effects of ASSERT() or BUG_ON() triggering in a GIF=0
region?

> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -544,6 +544,16 @@ static void __init calculate_hvm_max_policy(void)
>      if ( !boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
>          /* Clear VIRT_SSBD if VIRT_SPEC_CTRL is not exposed to guests. */
>          __clear_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
> +    else
> +        /*
> +         * Expose VIRT_SSBD if VIRT_SPEC_CTRL is supported, as that implies the
> +         * underlying hardware is capable of setting SSBD using
> +         * non-architectural way or VIRT_SSBD is available.
> +         *
> +         * Note that if the hardware supports VIRT_SSBD natively this setting
> +         * will just override an already set bit.
> +         */
> +        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);

With the 's' annotation gone from the public header, is this last
sentence of the comment actually true? Aiui code near the top of
the function would have zapped the bit from hvm_featureset[].

> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -3126,6 +3126,8 @@ void vmexit_virt_spec_ctrl(void)
>  
>      if ( cpu_has_virt_ssbd )
>          wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
> +    else
> +         amd_set_legacy_ssbd(opt_ssbd);

Nit: Indentation is off by one here. Of course this alone could
easily be adjusted while committing.

> @@ -3138,6 +3140,9 @@ void vmentry_virt_spec_ctrl(void)
>  
>      if ( cpu_has_virt_ssbd )
>          wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, 0);
> +    else
> +        amd_set_legacy_ssbd(current->arch.msrs->virt_spec_ctrl.raw &
> +                            SPEC_CTRL_SSBD);

Would seem cheaper to use !val here (and then val for symmetry in
the other function).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 11:01:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 11:01:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317220.536460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOMw-0001Hm-LV; Fri, 29 Apr 2022 11:01:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317220.536460; Fri, 29 Apr 2022 11:01:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOMw-0001Hf-IY; Fri, 29 Apr 2022 11:01:02 +0000
Received: by outflank-mailman (input) for mailman id 317220;
 Fri, 29 Apr 2022 11:01:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkOMv-0000M7-2K
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 11:01:01 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a5dba272-c7ab-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 13:00:59 +0200 (CEST)
Received: from mail-bn1nam07lp2040.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.40])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 07:00:56 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by CO1PR03MB5890.namprd03.prod.outlook.com (2603:10b6:303:93::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 11:00:52 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 11:00:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5dba272-c7ab-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651230059;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=WkM3ixq46/QmwfU/kwCbY4buNEDzge4GV9K1E5SHmGw=;
  b=BVxroKriES6DGZMrZ+WNJzICYKp8MUiy7PI5LwYLBTmZJ7udU4en0l/+
   nSj+nh9Ant+8CQ8ir9S36O3AXnoojllH0cXsvV7Yr6CcwKEz8q26SXpG+
   vqwqrRxDsa+IgZqI4j5iMfBX5qKuI4fVysQZXW2nEguolONczVgZhr9q+
   A=;
X-IronPort-RemoteIP: 104.47.51.40
X-IronPort-MID: 70102867
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:zMWEx682LWq4xQPMRFM5DrUDqn+TJUtcMsCJ2f8bNWPcYEJGY0x3y
 GsXDW6Abqzfa2T2ftkga4/i8koPu5ODmoJiGVA6rn08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3YLoW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYbzUgQKPKDlpMoiChMbUB5xZ6dZ3qCSdBBTseTLp6HHW13F5q00SWsQZMgf8OsxBnxS/
 /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvyMuYcwMDQY36iiGd7EY
 MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgK2QA8gLL+sLb5UDOyD1t07XJauH/IOKDX+lIoUSCi
 nv/qjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDZtvyRRqju1afowURHdFXFoUS4gaXy7GS5B2FHG8aVT1QQNs8vcQySHoh0
 Vrht9TyHiBiq6HQQH6Y97G8vT60ITISL2IJeWkDVwRt3jX4iIQ6jxaKRNA6Fqew1oLxAWuon
 2jMqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgDpU
 KQs8yRG0N0zMA==
IronPort-HdrOrdr: A9a23:1xkBdqkbMl0CNyYf4/rNpEGRuvPpDfOlimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM
 tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq
 Z1saF81kedkDksH4yGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVnSRULAhKePZptMZ8SF/0+kAgtNZz3O
 ZgxGSCradaChvGgWDU+8XIfwsCrDv7nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De
 hVCt3G7vo+SyLUU5nghBgu/DWQZAVxIv/fKXJy+PB9kgIm0EyR9nFohfD2xRw7hdcAo5ot3Z
 WxDk0nrsALciYsV9MNOA4we7rINoXze2O9DIuzGyWQKEhVAQOFl3bIiI9Flt2CSdgv8KYYvq
 jnfRdxiVMSEniefPFmmqc7vyzwfA==
X-IronPort-AV: E=Sophos;i="5.91,298,1647316800"; 
   d="scan'208";a="70102867"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cV86LSp1n+Wut6d3N3d+8tHPOK2YAaU148iu+Ust8oJiPn/rYtkDkBZ4htQnIzYR1fEeWw0cKTNUkurmQxCdttjuM618CsPnfAvUpK6If2ftD1rFmjtUb28JlXKBRUeADZ479NbQ2P4t22xowWOVzO5SoV1Nx+3QCJCHHN9r1wKVj0Utdr0THjzoXhm/NIGpSpS1pCFVdylJYnvOEchjpBYMvUWuqubZbibUG21aRAcXzhiIfg38ml9EHk/Kidmlue7c3AYyvS63ZKi8BMuRvOOwAYynLN1/KEI5PA/DNKbxEZ6jkf/OavHSWZ/QQAM/S1RomPqab57R0+pbJyF/DQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z9JDzMPrfVicYGsXcEMPT0UKo3t69Qo+iV+CC3lJ88Y=;
 b=B4p3UXE8Q5eg+0K0WtLH0sDySgIRLlPuGB0wmm3NYkPUDT+mbtasSRXlsgsW1Rd88o7+rCSm9uEEHAcwLkhgK6atAVM1iBHKuwXlahK+Tb+vkXlK3RfBJv7jlI6Vynyjj9s0PpX7imZZNj0hsJuVX4zJTNUtYCcKzgBDjlgXKHnjoFThyj+vCQV7DTVKvPBrn/80cOjgBcv6omxQUaymMUOgC6OYc8uh7awNz5ZTmKw0zzdwbFqSo+JFMK10sFhWHF2jAmmdLbPh7y/Bp03DKk8VgMYkkH00574pu27Cfp/L/RdVknBmCsJpCnWFbBRF3K5kFPHLDEv1f3s/M8yQLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z9JDzMPrfVicYGsXcEMPT0UKo3t69Qo+iV+CC3lJ88Y=;
 b=SnJLURV987O1PFCN18c7HNIle7Htb3/a682q83e74EILEC0ihx0sH439qidGI85gvjDlhixtudLEmC+ZEyYBynPnorAmKPMOy1udkaevXxFDs/laUFMV0Rns8lcLaClKliUxKhIaXbs6l1dujfNjKHI3NRm/ecuaL/THVsM5M4w=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 13:00:48 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	osstest service owner <osstest-admin@xenproject.org>
Subject: Re: [xen-unstable test] 169819: regressions - FAIL
Message-ID: <YmvFYK7tk2174HwB@Air-de-Roger>
References: <osstest-169819-mainreport@xen.org>
 <Ymu+WnVjTANHk+na@Air-de-Roger>
 <25a16b3e-e235-698a-452e-bb87920adc89@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <25a16b3e-e235-698a-452e-bb87920adc89@suse.com>
X-ClientProxiedBy: LO4P123CA0503.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 712020fd-22d2-4beb-da58-08da29cf86f7
X-MS-TrafficTypeDiagnostic: CO1PR03MB5890:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<CO1PR03MB589074E82920F3229790C4308FFC9@CO1PR03MB5890.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q7MPlvE5wQgYuOAkQdL6wX6q3UPmqdn81Aray6ydKHMOrJMjI+DvoA//XVpZP7j3woPfAow2VOw0T+Vr5cTk3kfq3iyGwzCMg3XUZYQ9Ggy8B4FZFYF7Dhg8zC0XG5paa3cGebRMlMHO2VinmbDH/NKS/nFz3H7yPo+/RGGOOlSGcnYzu3IplN0D2MMnfJCFZyTAVEBVAj3Kpe9i+pFkLREAu0L/6yjdmb2Rq8mEmsK6itXJ4dHvxlndoHc1HA/cKwkWhNfhq2w0Pi1xe6/33PcBU19m7yoLY4hLhJ/ae+pUkFtAPSjw28flCjOP1zioObmG1KIkdn7NhYLxdBG4LvUFMHcjoI+XRwN7o5BuZFY6IZ10WhSjKFuHOHGyD3ArPJ5QbHRt630oNmRGwoJSfXiIGRxYzlI5xEBNPlFIcU1f8G5KSVn3KBZ+IzZ9hzXzt2FeeDDhG1R9iFFddBdVWG6Y6S0E+X7yVNafZqlp18ykr9V3hhNmnxuT6GBEjYGViVzBv4t6jVdxgrHbEDjle4XcP/h5ZJnJkbYPz+2KjbJJzpODxXzJcV6agHWbLWLh/CqpEWDmusYeZ5t4cZbLq9nKKvVghFrzG0Xzl/nu6UnDu5oSELaDHSqBa4NzTsBLEhJ9269bGNFVfZPgmdguJvpG8U+86mi4WV3ei/KSar9oCfCO3f/TneV3WhxOvcSXbEV8Qz9mR68FlvWdPlsWttTDwsDoFsFsXTOdr4WwPdQ5DGvk4PJEvUvuFGxxxzv79eB1v4EreuJ953qFd3ue5Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(66556008)(66946007)(5660300002)(2906002)(33716001)(66476007)(316002)(4326008)(6916009)(8676002)(83380400001)(85182001)(8936002)(54906003)(86362001)(966005)(6486002)(508600001)(82960400001)(38100700002)(6666004)(26005)(53546011)(9686003)(6512007)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?alBONi9oV3VBRkJNMUdsMUVMVnpTMnBGcUV1SlN4N3dlSksvN1RoditUMm5u?=
 =?utf-8?B?YzFkSHROc3BqVGMzTUxPWHdMYzNDcmpFaFc1YzVneG1QRFNaWVFDc3ZiV1lz?=
 =?utf-8?B?Y3hFR0JJaG5iZWVtMnhjTnBRMG5MZXlwRjFNcXV3MHdBbUtPZWhqYWhrdTJm?=
 =?utf-8?B?azNkMVREMUI0UFg4N0M0VFJoUUp0eUhNSTA3cm9lOHR6OVZVWDdjSGdRZnp4?=
 =?utf-8?B?UnRpT3lkYWprM2E3S1Z5dXpHcndKMXllbWE1MnFSVm5zYU5CM0wrVmh3anBG?=
 =?utf-8?B?VFZSQktnT1lBTVp1Z216WjlIQWk3bjEzNWtzR1JMbjMyTS92N2xjdVJVNEMz?=
 =?utf-8?B?QlB5YWZxVEg1YkU5M3hDQUttT1V2TzdLSlVTZ1F4MVAyR2UxVmZmV2xndjQr?=
 =?utf-8?B?YkRKNDVKbHZSbmtDOURYUVJwYUtNSjl1MXJxMGlEcUpEMXcxdGhURitFMkMy?=
 =?utf-8?B?TytxQ29jdTNhallKYm9EZEhVc0Vsdmowa0R0SGE4ckJpdGJtRjZQcThJd0Nm?=
 =?utf-8?B?eHlrMVY1UmcyNGRucUJaTFM3S1pIVkQyU1F3WUt3bzNKQXo4dG8vN1RxWEJZ?=
 =?utf-8?B?RnVSZE15all5eTNaYkxqT0FEOXRxSklPeVBPenQzTE9ldW1BMGdINjJhdExB?=
 =?utf-8?B?NmRnODFPWE0xckpxdFBmSHlzQmhHVStyT2xCT0h2eXZzSGNLejRJaXFHUGVX?=
 =?utf-8?B?MHZzMzcxYWQ5OEN2MnBUVHdzcjlBaVBQRFJZZFZoV0x2Z2pYbWZjMDB2S0FS?=
 =?utf-8?B?blVsbFZZQi9vZ0ROUDVoeHZ4czVjbWNQUGVOdFBxbEZ4d1JhYmFtT2p3VXBK?=
 =?utf-8?B?V0gxK3hUNmE0K2t0NVRoQjFycVVZby9sQlZ4c29ON09ZbFBybkxkSDlNc2hE?=
 =?utf-8?B?c0FGblRDNEFqS3EySVF4K1RmZHR1cmdRVTFvUDE1T1VCdzZ6RG5rcUIyV3hy?=
 =?utf-8?B?M3hBU3pZSzBsQXFrVDVocWZnbEZ4dEFEMFZGU2tIL0tkQll0OFkrekk2Z2dr?=
 =?utf-8?B?SmRIQ3FmQ041YzlTVHlrWlNRVHh1aWQwekRLazZVNmZmVDJvdGl6aHpPUnhw?=
 =?utf-8?B?K0E0TzJGbHI2OUhDZTlGQkl2RDJwUm0yUlVRRXZ4aHNOVEVCaHA4UTlyaDZr?=
 =?utf-8?B?eHNwTCtsem1iWXhQNnEzS0xHdXRGakFsRFFQQ3RBdDVFcWRZS3VBRnQrUFRs?=
 =?utf-8?B?WDN5cVFzUGhlZ2krOWozb0Fjejc5K2tjVkZPM3VvdXZZcmF0RHFzU1NYSjd2?=
 =?utf-8?B?dmxSaUswN1F1aXhnbkNPZGxZdEJEN2ZkY28yenZoaFBJVW1BZG1Sa0w2cDN1?=
 =?utf-8?B?NUVaR0RWNlpldHFCZVpYZ2xUOXM0N000ZW5oMGFvZklIUVJXcHg3dFQ1dGpm?=
 =?utf-8?B?S0xnNjFjc3djcHl4VGFsWTlPYWI1V0JPSUQxRm5sRW5TSnJhNnkrdHVZM0JS?=
 =?utf-8?B?SFZBVm5OUWpoakFJSUgxYlZlSnAyV3BsTTQ2UDZUcjB5a3FvMUs3aUJuZVI1?=
 =?utf-8?B?QjQ5RGtOUHl3TW1QMXh2aVZORjYwUmFseEkrQU5sUFpVRXVwUUpyZXRzdWY3?=
 =?utf-8?B?TnlXcytKK2pNaUNaS3lNdDNsTk9DT3FINHc1RkJXYmF5NEM4Z0VzUDdhSEF1?=
 =?utf-8?B?dnFSWGZYdGlMVzZQbEVFYlI1MTVrMGpTMHh1M1B1aGh3My82L29VSVBOQTQ3?=
 =?utf-8?B?cTRGSGZYRXVvSUVaTUNpeGVEczg2NlpQUENhOXFibkl0WWU4cEdjUTFkQVBu?=
 =?utf-8?B?bVFCZllJcDVSaXdpVCtUTWN5T0luZyt5VFB2YlA5WEJPRWVtcUYvNUxMZHVj?=
 =?utf-8?B?aldZOTJkVGpBbHVFdE9aREpwMUxUOW9DTlJOSGdXUitTUUxjS291czdZMzY5?=
 =?utf-8?B?cHpMRlhVRmxqNVpyOExHalMyT1RtZXM0MlByRE45Kzl1ZklOZmNvYlp3REdj?=
 =?utf-8?B?YnJoYVFpY0I5NDRFQ0lQWERLN2U0T1RKUUp3elBkeEhzUkJ3VFpENlp2WVNL?=
 =?utf-8?B?RXNUbTNlZUwrNjhJWnZPemVIa1ZsUklVSG4ycnIzL1ZNM2c0ODlQZHRNVFRE?=
 =?utf-8?B?OG9oWHc2SGZNM1o2OWR3dWRPK0NoUWVDVHVmSStqb3g2KzJQYVBZcE4reWpE?=
 =?utf-8?B?czhMQlQ0NFA3RGZWK2J3cjYzYnYwMjhtM2FBNUdTRW5sZGpEemlHWkJvdkYx?=
 =?utf-8?B?NWV0eGVSRnBBY25ZVjBYUkZIUWFRK1NpeENMQytSSmdKYjdVd2lKdWY0dTNP?=
 =?utf-8?B?WnJTVkJUOTFISGdHanNrNzhucWgzYldUVG1mY0s0aWcrVlU0VUhuZ0JQNUZ6?=
 =?utf-8?B?Q2FkZFVjUEVNUFJCdzBsellSaUQ5OXhXbEF3YUMvZll5THc5Q0Z6Y09BajB4?=
 =?utf-8?Q?NvWUBs5C31PlUdC4=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 712020fd-22d2-4beb-da58-08da29cf86f7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 11:00:52.6956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pOmLnaYgF5Xqi7cAUGSFNglPYsL/ZrRaIeqd3HQBUiipgj6W0M8i251H50ymqRGexfuocHv4Ava2iL4ZQKsVug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5890

On Fri, Apr 29, 2022 at 12:37:13PM +0200, Jan Beulich wrote:
> On 29.04.2022 12:30, Roger Pau Monné wrote:
> > On Fri, Apr 29, 2022 at 07:46:47AM +0000, osstest service owner wrote:
> >> flight 169819 xen-unstable real [real]
> >> flight 169843 xen-unstable real-retest [real]
> >> http://logs.test-lab.xenproject.org/osstest/logs/169819/
> >> http://logs.test-lab.xenproject.org/osstest/logs/169843/
> >>
> >> Regressions :-(
> >>
> >> Tests which did not succeed and are blocking,
> >> including tests which could not be run:
> >>  test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 169775
> >>  test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 169775
> >>  test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 169775
> >>  test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 169775
> >>  test-arm64-arm64-xl-thunderx  8 xen-boot                 fail REGR. vs. 169775
> >>  test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 169775
> >>
> >> Tests which are failing intermittently (not blocking):
> >>  test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169843-retest
> > 
> > Looked into this one, and it's slightly concerning, guest seems to be
> > stuck at installation:
> > 
> > Select and install software  [  481.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [  509.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [  545.093820] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  573.093809] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  609.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [  637.093836] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [  673.093957] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  701.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  733.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  761.093817] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  797.093898] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [  825.093863] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  861.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  889.093945] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [  925.093974] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  953.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [  985.093832] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1013.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1049.094031] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1077.093860] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1113.093938] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1141.093803] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1177.094051] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1205.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1237.093955] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1265.094004] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1301.093835] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1329.094039] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1365.093883] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1393.094167] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1429.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1457.093900] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1489.094026] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1517.093997] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1553.093996] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1581.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1617.094076] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1645.093882] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1681.093896] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1709.094022] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1741.093870] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1769.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1805.094017] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1833.093837] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1869.094043] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1897.094101] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1933.093879] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 1961.093933] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 1997.093952] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2025.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2057.093895] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2085.094172] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2121.094018] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2149.094021] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2185.093931] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2213.093864] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2249.093951] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2277.093899] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2309.094054] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2337.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2373.094111] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2401.094132] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2437.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2465.094003] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2501.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2529.094050] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2561.094027] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2589.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2625.093999] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2653.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2689.094024] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2717.094093] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2753.093913] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2781.094095] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2813.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2841.094117] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2877.094041] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2905.094009] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 2941.093893] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 2969.094085] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17]
> > [ 3005.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 3033.093917] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > [ 3065.094060] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17]
> > 
> > debina1 is one of the boxes I've put into production recently.
> 
> ISTR this issue having surfaced randomly before. With the randomness making
> it difficult to investigate.

Indeed, it seems to happen on other boxes also:

http://logs.test-lab.xenproject.org/osstest/results/history/test-amd64-amd64-xl-qemut-debianhvm-i386-xsm/xen-unstable.html

At least doesn't seem to be explicitly related to debinas.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 11:14:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 11:14:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317228.536471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOa4-0002vF-0H; Fri, 29 Apr 2022 11:14:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317228.536471; Fri, 29 Apr 2022 11:14:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkOa3-0002v8-Tb; Fri, 29 Apr 2022 11:14:35 +0000
Received: by outflank-mailman (input) for mailman id 317228;
 Fri, 29 Apr 2022 11:14:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R1X1=VH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nkOa2-0002v2-OZ
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 11:14:34 +0000
Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com
 [2a00:1450:4864:20::22c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8bba5812-c7ad-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 13:14:33 +0200 (CEST)
Received: by mail-lj1-x22c.google.com with SMTP id q185so10098341ljb.5
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 04:14:33 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 bd25-20020a05651c169900b0024f3d1daea9sm248921ljb.49.2022.04.29.04.14.31
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 29 Apr 2022 04:14:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bba5812-c7ad-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=24Yu851L+dS2yEvP/EMPHQtSULte7iLzPxRBpYBqDEY=;
        b=YBE2bmybOlQIbBR8yW2m1tU+shkpzVmJbD8mYmt6TDhH1Zk1vU/8RkxPKQF+hXw79n
         zFe5GhmIzQEuzMT/bpLzofXP4kv11QMyPiwJ36NM7ePhPCfSXtvd0h9Ab3V4UswUf4Qw
         86q1xqcHL0jWhlCgnfQ3RGpaTdluTLe06Qi/IQBcsduQHFY4P4Foc1lJSA6qzt7gGhDz
         PCvG6kbUAv20pru1dFqGX4MWJK2GsfuuolWNbNqYpzkFtJG0AzYlbkwIeEccNMlGIc9w
         OzTGw8HLwrP2n27u5sSLpSwso82sjXDUve2OKBApY10iJ+Ff4zQaOOOGvQhf8//a/F1h
         p3RQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=24Yu851L+dS2yEvP/EMPHQtSULte7iLzPxRBpYBqDEY=;
        b=nGV16s+hXMqZBaJyuD3QSz/w1+//+seuSfRgZC2mLX44iJZCaumWxZNvKlt/GDqw/o
         yI+yDHfgY8xui9Jjvlt/PHQBvzU4Zv9tWxKEbcFk4TPKhkbv8VwdiZF9Tdv9SkBxxAWR
         uZhnaSPWBqSvEqw5ymC8bqeANwSeQXW4A5d4Qes4GI43n2s43AxgB/TDCJvK4uJ6/rIe
         7mDVclR6rg3gTs3yISSC0u8Ubf/Ha2kBzjV/ErMfFvn5ikVz+qQ2q9JFDKeebTzGOiuh
         GZTha54jDk+VMs+gzHDBmyrlepMPeJnfJfu9BvFB2AbVRsBOhylM5T1YiPJdkC4k9r3V
         /UTw==
X-Gm-Message-State: AOAM532OnJWX/oejWiy9t5gWQCfEybVifTqvwpDjAFSsoTsQptRSJ+Pm
	kmqmxChZ4jqJtBWotzySqU8=
X-Google-Smtp-Source: ABdhPJzrKftalINu7jCLWocTUmyljWcsSyLXxDTZBnqFWEcP3kASnELbeSx9y5Q0htvxAD7qjDbn8w==
X-Received: by 2002:a2e:9f49:0:b0:24f:a4f:955a with SMTP id v9-20020a2e9f49000000b0024f0a4f955amr19407945ljk.374.1651230872469;
        Fri, 29 Apr 2022 04:14:32 -0700 (PDT)
Subject: Re: Virtio on Xen with Rust
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Stratos Mailing List <stratos-dev@op-lists.linaro.org>,
 =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>,
 Mathieu Poirier <mathieu.poirier@linaro.com>,
 Vincent Guittot <vincent.guittot@linaro.org>,
 Mike Holmes <mike.holmes@linaro.org>, Wei Liu <wl@xen.org>,
 xen-devel <xen-devel@lists.xenproject.org>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>
References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7>
 <CAPD2p-ks4ZxWB8YT0pmX1sF_Mu2H+n_SyvdzE8LwVP_k_+Biog@mail.gmail.com>
 <20220429034808.dr647727dphnx6zk@vireshk-i7>
 <20220429035917.xu5ecgldwzfnxbos@vireshk-i7>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <ca4c642d-a218-26f2-0661-c356f79d15e5@gmail.com>
Date: Fri, 29 Apr 2022 14:14:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220429035917.xu5ecgldwzfnxbos@vireshk-i7>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 29.04.22 06:59, Viresh Kumar wrote:


Hello Viresh


> On 29-04-22, 09:18, Viresh Kumar wrote:
>> Now, it was just yesterday that I started looking into MMIO modern stuff as the
>> GPIO device needs it and you sent me working code to look how to do it as well.
>> You saved at least 1-2 days of my time :)
> One question though, do we need to support Legacy mode at all in the work we are
> doing ?


I am not 100% sure I can answer precisely here. virtio-disk backend 
worked perfectly fine in legacy virtio-mmio transport mode
with the latest vanilla Linux. For the "restricted memory access using 
Xen grant mappings" feature to work I had to switch it to use modern 
virtio-mmio transport.
CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS requires the virtio 
devices to support VIRTIO_F_VERSION_1. In addition, we do need 64-bit 
addresses in the virtqueue.

BTW, the virtio-iommu also requires VIRTIO_F_VERSION_1.



>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 11:16:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 11:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317233.536483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkObv-0003Vd-Cz; Fri, 29 Apr 2022 11:16:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317233.536483; Fri, 29 Apr 2022 11:16:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkObv-0003VW-9d; Fri, 29 Apr 2022 11:16:31 +0000
Received: by outflank-mailman (input) for mailman id 317233;
 Fri, 29 Apr 2022 11:16:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkObt-0003VB-El; Fri, 29 Apr 2022 11:16:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkObt-0006S8-DB; Fri, 29 Apr 2022 11:16:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkObt-0002Km-2W; Fri, 29 Apr 2022 11:16:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkObt-0005CW-22; Fri, 29 Apr 2022 11:16:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KHDXJ24JtUt3OOEEF6hypNIxinAXUuljOZ4ux5AxkRg=; b=AoS7kEjog/A70kRRDw41eqElZw
	J6VFkAayzg6Mzln9UQmr9rD3Kmr5aJq3dVj5ySZPUz8p+Au4qzcSUlefTF/nXijHUev2xf9CUfVPW
	DevkvzQs8NFsAKAQ+T9D01WiF4uZFXhs8Olgks/Q7ZsgPNSvNikmK87RNKZO3kZIUJ8E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169865-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169865: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 11:16:29 +0000

flight 169865 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169865/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  693 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 12:16:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 12:16:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317256.536499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkPXc-0001O5-Uo; Fri, 29 Apr 2022 12:16:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317256.536499; Fri, 29 Apr 2022 12:16:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkPXc-0001Ny-Ru; Fri, 29 Apr 2022 12:16:08 +0000
Received: by outflank-mailman (input) for mailman id 317256;
 Fri, 29 Apr 2022 12:16:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkPXc-0001Ns-86
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 12:16:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 24c081f0-c7b6-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 14:16:06 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-SiqG93IWMI-8IY4GDlkBkg-1; Fri, 29 Apr 2022 14:16:04 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by DU0PR04MB9465.eurprd04.prod.outlook.com (2603:10a6:10:359::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Fri, 29 Apr
 2022 12:16:01 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 12:16:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24c081f0-c7b6-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651234565;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WejTJcsDIC5Q7p1zbuIqZfgtE5WTXLAMIFgW6M5Nm9I=;
	b=DXsazA9bKmJWQjwdl3EszlFaB0d5EXmwTWQXhzAKIV84oJNiXoIafqBK0xNGfp48LrBjrE
	mtyg+FTE9yAT0hUO3rOnNy0PWhGFO+F7kq23+rsJagpzS604J1O3zM4yPlSlyhTfjet5P7
	RdzxQG0ORGYcCE9Cx21QFGil3979WFQ=
X-MC-Unique: SiqG93IWMI-8IY4GDlkBkg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MiC23CgbcKEYZUYEfV2t6QwMtD4H9XYQ5Y2QxVukO5GzT+jOUSIHYWWcZbThxyk7z8SETAaRPazL+IZnJ1oVYUxsn8iiQQinhCo0QMlrJTaPY3P35efe3Y6yhaCDmE2HaDQOLLy82K70OS+MuEvIP0tsyaF5/O8afCl2CGSlvPURb1x8LvetMOwPlw9k+abB0nrzSJISR4hszJVCAHDqYxTGIzWRXoLQE697thZuFyvSnqOvIyI0qrCM6ia7fGlArehfb36GVz9pC8yHHHA7gMiEzroulurNgjzh9NBRaR3mWytajU7y25VH709nTMWXmLBM/s1P6nxd8s8qfVwWxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IJ5RuXG8WItrBhM/uQ9rlzRMbGZNqSxGBHKHzUt6TOw=;
 b=LyXfBwvDnh9y+1IWhVdgLLVZChZfWKG7G8bMm7J+oyjpRatqPSkaR0H0/CpPhfKct0Ge1NgZz2g5YiiSPmTJCsv6hW3wqMh3OP9LaAE2R6G5L3xzupSKS+l/3zChcdHWG66UCvzGu0xLFzBLDle0/ZkMj6nJU1983VsS1avJIRL3MJbuLZNqTcqtud+9UIV9Xhf7/kT9KvmF7M/xl2n8CxqoBMZnIom/jSPLOW+U9iWPC0QQMry6Q4/an7sie+5MNdDDFu07t5xeSR3ADh9Lo0JakO0DCFkL0KwIW4irJXezm0trIhFIF0P7AxI+o8s4R7ny1VbtfZSFvRDOzU25Jg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <85c55676-b21f-1eb4-0471-19ca9b6de39f@suse.com>
Date: Fri, 29 Apr 2022 14:16:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Content-Language: en-US
To: Dario Faggioli <dfaggioli@suse.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "ohering@suse.de" <ohering@suse.de>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
 <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
 <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
 <35599105-b441-96cf-7537-ccf9dfac0934@suse.com>
 <fd07c28fad352a476544258f2ac4d652062b2701.camel@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <fd07c28fad352a476544258f2ac4d652062b2701.camel@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR02CA0004.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::14) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b9f074ba-d6fd-47ed-b5f5-08da29da064c
X-MS-TrafficTypeDiagnostic: DU0PR04MB9465:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DU0PR04MB9465ABEFB4936766A35C7E87B3FC9@DU0PR04MB9465.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AWn19TCuL+SpfJRy6ulbCKZlMOlaSe9SudPB+wYbfrvckBx9fDWIlGiZlRT1afxDcJetbIDZQ4NfeJJ8Hezs91M2iwA8xCgMeJ3t3yl0f4eRg+FjqKsuou5dkSWU5r+lloSiqCGNTfeKzea6opLho8Qu3U1PzRsFykRxsTnOJIkTR1SZvyqqZh/SJ1xK66fVYWo63Ut+DELS3SCqnZ3k7Syr58NnWNsxBRx3u2ojQy6xzhECgxp/qhrIklxWO5BpGUenF35rct8EWeN7+LcCyszW0A+O85CrYROZPGyra4Ag0AR13yglzVjJoNhQDe0TgpA50Dva8LDemyV6yRUK/CPcHSpK/6k6/byMJXwEWpNC1fhXtFw6VPzr2Ptc44/bCSAGn88Br03MqwLNP7+5gEHiEoz+WShlfIz4BINJoYpuXg+jZj1suS+h4f1JR7mwSAlvaWi1ecxQXsib7VIlBDe/Hk60tSjXpyYPCIq4Nj8YlKLyvSAzzRZcMxmMq8uXojKSz58ch89ebVxRpu8Nl/lHJwUsal6BgeJHkmjdbqqxqs/n5HLpEQzMeT/K7cChEPPjpA3gPN3C7k2288R6aMzf0Or4Xu18QqzA1x2aBOxUDVBc7JpeyTGJiFb3fwhYjkyKhAILDHnB8vW4jDJVR935LTR27aDi6wri13UV8mlhskHatCtDyV7eqy+v2eTO1keiGQjpzr1EjTfk3HQPiY1UlnfqVT1PYvPdG9E/DsI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(8936002)(5660300002)(8676002)(86362001)(2616005)(66476007)(316002)(31686004)(6636002)(54906003)(37006003)(66556008)(66946007)(38100700002)(6862004)(4326008)(31696002)(36756003)(83380400001)(53546011)(26005)(186003)(6486002)(6506007)(6512007)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?uNh+ENphwdk1bM6zKZj5K/IQZbIT0OlQwNyiEdTjV9DPRRgnNDGmlrFAf9U8?=
 =?us-ascii?Q?NIBgoM7N959YIslmqDTPCcWBKKOJYvVUBAe4aoRGaE2FQl+IUfmpxCmOWAt3?=
 =?us-ascii?Q?FXz/BoVSgK7rDarZXHZ97a5EKMpi++OMvceMIFMK/Q7XqgXvYBUjhadd8hyd?=
 =?us-ascii?Q?nctFNUC+KbwOks5XAoyDSq9nz/67FsAA2GIxoNhVCUKTqjqpA5EiVR1ivBAc?=
 =?us-ascii?Q?21CrAIAhFCxGFfATZRvfED2bROjDum04lOnX9MAOAv/prtSbg/JGKX2oZdnI?=
 =?us-ascii?Q?3Mz/tdEePCyRXt81gYCi/yGQ7jWXjXqG+K1FgdgNl7VvmU8Rq8hd/ILXolku?=
 =?us-ascii?Q?J/dsH/oVgpRLPu7UDxyrPjvkQ3KFo5xEm0Fg5rNpPIqeynpaMpr/FGM6e/mV?=
 =?us-ascii?Q?TW+G3abf3KrrR3g9SW2q7xRM2TyduKiplb5+1DoQYc5vswC0A+YP2RNeKI0k?=
 =?us-ascii?Q?8NS6bvwssUWwDS9uqRc1LaatPe1y18MZyRKndFIe218kWDEAD48w2BrvDWXT?=
 =?us-ascii?Q?R2gLf19cF0N3+5h/X4rDp+4h9yfi8vU+mmhwxEGRZZtM6M3Y2RXcAIZ6E9+r?=
 =?us-ascii?Q?mazs/pyziBAT/TQcz5DG/1NYhf9wz/OrOjqNXJ5XwziU+oScM/WQZs7oJBsj?=
 =?us-ascii?Q?DhafxG48j43nXY9GDAYYzKyorDgjGQrykhI4A2+qGPjB5y7cGqo6Jb6Rv3P2?=
 =?us-ascii?Q?R5BwwAEoxgf2x65M5NKOdUhaFD7POwyXVGT3lNH1Ly6545IW+wjaq5g645Xc?=
 =?us-ascii?Q?1WfspGtYCyh6Y5T01R/LHMbkWL2W3NnjkUK42wPmmEV6S5XzNKPUQI9EhLOo?=
 =?us-ascii?Q?Clmm9tgveLUWbhD0Q1uc5a2cLP/NWcQMFURztdhT7LyJOfOvGzOFnXG0JIYr?=
 =?us-ascii?Q?tMVbcG1onGFH1Y7QhdNdq+KNPHQIdqGYvfH5oOct0mFntJm2oCIwoZ3wRF+N?=
 =?us-ascii?Q?/Blyx1C6ivLWYa+wAmoaySHQXYPBzaF+sgN/Ogb253/zNiDAYuzpR45yGudQ?=
 =?us-ascii?Q?ggHTIJRwoAxrFIZGxi0CpcjvNdeRE/R7bK1Mpoh2tFVvY89bpEG6Y3LxCrtC?=
 =?us-ascii?Q?s3miJKhcqeSImVzwGjoLIITDlCbSyvC4IQwWzHffQB/rQkWoYkewYXOwTavL?=
 =?us-ascii?Q?MzlIJ6kgPhdJ0aJCvl3nudi+fFi6trOFQ5WBVLFEPOQJ7J3rNFwVuy26tujG?=
 =?us-ascii?Q?dnxTbjRhrC8FfAFvnxSEKJacOpXz7a0BTRZM1T2cMF84a6Mvs6+dh9A00GwX?=
 =?us-ascii?Q?FflQkEZ5gmwBZj7EbaHRYHCJXKrWr+T61ac/rOcS7916z1VUBpVm68emC1uG?=
 =?us-ascii?Q?WAzcKzELi9FX0UmYFBIrGJq2Qof+iPYmHnoFb1DJg9gmhcKgcX1grqj6Y1Lh?=
 =?us-ascii?Q?78VqbK07+5qlskCkEga+mK4ABo7xSGmXoYj+2oRdHEGVR4uaT8WV13xnGAPL?=
 =?us-ascii?Q?5MaULPHf/3UalEGKk82gwNFtpZ/f8e/3kGOaxxN6OP/KgDMajXwHVxiQwvCj?=
 =?us-ascii?Q?m8SmvaO/+1HZQwHUorzbYKiO9PyLLsiy4/2MFTw64bTZdABvYf6mIzl50l5P?=
 =?us-ascii?Q?nHpOA4EgBGA3jseahT8uW4efuVa6wCepHpiHDMGun890znnesrluTncLVpAG?=
 =?us-ascii?Q?1mx6aBVo/R9O5Lxyg2/kOm2g0u04zxXHkhXiEOh27SyQmeiEl0gVOuGMXaM1?=
 =?us-ascii?Q?gdAFzNX2jxdKTQ8ybV6hVjpFnVbEWI21uMToCCsGds4TYlO/b+PJ6Am64i58?=
 =?us-ascii?Q?nV4EiEi8sQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9f074ba-d6fd-47ed-b5f5-08da29da064c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 12:16:01.3364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oI6XQ0Shk5QDGn4zVJYQSQyX5ZtYkYMdg+8xoC0skOV/KZEv8k9+pBWRLd0UwO+bi/PjYU5OCMzka057osy51w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9465

On 29.04.2022 12:52, Dario Faggioli wrote:
> On Wed, 2022-04-13 at 12:00 +0200, Jan Beulich wrote:
>> I also have a more general question here: sched.h says "Bitmask of
>> CPUs
>> on which this VCPU may run" for hard affinity and "Bitmask of CPUs on
>> which this VCPU prefers to run" for soft affinity. Additionally
>> there's
>> soft_aff_effective. Does it make sense in the first place for one to
>> be
>> a proper subset of the of the other in _both_ directions?=C2=A0
>>
> I'm not sure I'm 100% getting what you're asking. In particular, I'm
> not sure what you mean with "for one to be a propper subset of the
> other in both directions"?
>=20
> Anyway, soft and hard affinity are under the complete control of the
> user (I guess we can say that they're policy), so we tend to accept
> pretty much everything that comes from the user.
>=20
> That is, the user can set an hard affinity to 1-6 and a soft affinity
> of (a) 2-3, (b) 0-2, (c) 7-12, etc.
>=20
> Case (a), i.e., soft is a strict subset of hard, is the one that makes
> the most sense, of course. With this configuration, the vCPU(s) can run
> on CPUs 1, 2, 3, 4, 5 and 6, but the scheduler will prefer to run it
> (them) on 2 and/or 3.
>=20
> Case (b), i.e., no strict subset, but there's some overlap, also means
> that soft-affinity is going to be considered and have an effect. In
> fact, vCPU(s) will prefer to run on CPUs 1 and/or 2, but of course it
> (they) will never run on CPU 0. Of course, the user can, at a later
> point in time, change the hard affinity so that it includes CPU 0, and
> we'll be back to the strict-subset case. So that's way we want to keep
> 0 in the mast, even if it causes soft to not be a strict subset of
> hard.
>=20
> In case (c), soft affinity is totally useless. However, again, the user
> can later change hard to include some or all CPUs 7-12, so we keep it.
> We do, however, print a warning. And we also use the soft_aff_effective
> flag to avoid going through the soft-affinity balancing step in the
> scheduler code. This is, in fact, why we also check whether hard is not
> a strict subset of soft. As, if it is, there's no need to do anything
> about soft, as honoring hard will automatically take care of that as
> well.
>=20
>> Is that mainly
>> to have a way to record preferences even when all preferred CPUs are
>> offline, to be able to go back to the preferences once CPUs come back
>> online?
>>
> That's another example/use case, yes. We want to record the user's
> preference, whatever the status of the system (and of other aspects of
> the configuration) is.
>=20
> But I'm not really sure I've answered... Have I?

You did. My question really only was whether there are useful scenarios
for proper-subset cases in both possible directions.

>> Then a follow-on question is: Why do you use cpumask_all for soft
>> affinity in the first of the two calls above? Is this to cover for
>> the
>> case where all CPUs in dom0_cpus would go offline?
>>
> Mmm... what else should I be using?

I was thinking of dom0_cpus.

> If dom0_nodes is in "strict" mode,
> we want to control hard affinity only. So we set soft to the default,
> which is "all". During operations, since hard is a subset of "all",
> soft-affinity will be just ignored.

Right - until such point that all (original) Dom0 CPUs have gone
offline. Hence my 2nd question.

> So I'm using "all" because soft-affinity is just "all", unless someone
> sets it differently.

How would "someone set it differently"? Aiui you can't control both
affinities at the same time.

> But I am again not sure that I fully understood and properly addressed
> your question. :-(
>=20
>=20
>>> +=C2=A0=C2=A0=C2=A0 }
>>> =C2=A0=C2=A0=C2=A0=C2=A0 else
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sched_set_affinity(uni=
t, &cpumask_all, &cpumask_all);
>>
>> Hmm, you leave this alone. Wouldn't it be better to further
>> generalize
>> things, in case domain affinity was set already? I was referring to
>> the mask calculated by sched_select_initial_cpu() also in this
>> regard.
>> And when I did suggest to re-use the result, I did mean this
>> literally.
>>
> Technically, I think we can do that. Although, it's probably cumbersome
> to do, without adding at least one cpumask on the stack, or reshuffle
> the locking between sched_select_initial_cpu() and sched_init_vcpu(),
> in a way that I (personally) don't find particularly pretty.

Locking? sched_select_initial_cpu() calculates into a per-CPU variable,
which I sincerely hope cannot be corrupted by another CPU.

> Also, I don't think we gain much from doing that, as we probably still
> need to have some special casing of dom0, for handling dom0_vcpus_pin.

dom0_vcpus_pin is likely always going to require special casing, until
such point where we drop support for it.

> And again, soft and hard affinity should be set to what the user wants
> and asks for. And if, for instance, he/she passes
> dom0_nodes=3D"1,strict", soft-affinity should just be all. If, e.g., we
> set both hard and soft affinity to the CPUs of node 1, and if later
> hard affinity is manually changed to "all", soft affinity will remain
> to node 1, even if it was never asked for it to be that way, and the
> user will need to change that explicitly as well. (Of course, it's not
> particularly clever to boot with dom0_nodes=3D"1,strict" and then change
> dom0's vCPUs' hard affinity to node 0... but the user is free to do
> that.)

I can certainly accept this as justification for using "all" further up.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 12:19:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 12:19:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317262.536511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkPao-0001yM-EO; Fri, 29 Apr 2022 12:19:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317262.536511; Fri, 29 Apr 2022 12:19:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkPao-0001yF-BR; Fri, 29 Apr 2022 12:19:26 +0000
Received: by outflank-mailman (input) for mailman id 317262;
 Fri, 29 Apr 2022 12:19:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkPan-0001y7-0j
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 12:19:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ae26ff5-c7b6-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 14:19:24 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-QtCnAODaNzyERZOU-Cw8sQ-1; Fri, 29 Apr 2022 14:19:15 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by VE1PR04MB7408.eurprd04.prod.outlook.com (2603:10a6:800:1b3::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Fri, 29 Apr
 2022 12:19:14 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 12:19:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ae26ff5-c7b6-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651234763;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+tGRg8avUf/UV8NaH7tx6SmJT/3Uy0XEx4P6G94YfJI=;
	b=gWNLZVHI48KYwZwxHHvJRC/8f3HeX/3qrCaw9aNFEPyt7HB7PRJx6H7+1F7E/VmSygkibT
	8wevD9zxgj+skHoWEIDg9xyUHUuLStvmbSDpxq6xKvUEvqfk5ugVewN+b+MSZkVOHQWMbo
	ISgOo+aFQzoErPCb9u9D8CVClfqNvdU=
X-MC-Unique: QtCnAODaNzyERZOU-Cw8sQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gHfZ+Kpsbx7sVs0Hs0GWsOPMe18TNmbQf7jI5n42hMHVrzc18KQvoluQ0kbrmixjwx5glC43o78LTzx5OyN9vw9TSZg1rzoH4+u0F9i+fPnz66LAYwhDlFAOTNmZ6mudHLVHwZOGFBiMFJzWgXU1+xmI1/+meZ4lXO5rZ9gwqe9CxTOhDPxCm4yGPUhSKi+6Ygm7KmZWaNdIEMjTUVPJ/0RlBo4m4/417eY+0hDCVDmknmEAmHdp2zv4VexhuyPzlivY4lgtkQD7d/5UBZOHXl/NkrMbRbJafgKDFd1Iw7U24brUGGqYScN5LQ+1YFT9wHmDdWg97maT+SrxIJFJ4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CMJl31QMUmWvI3ZVEWFpCoZWm8sYiGkGGdC+ZWzrNog=;
 b=YJpveBf6UHkLhgJbwSa/DV/ve4B1AFlAx82ghcldKKTi+cXJjaIiGlllDinPCRG5bP46CcQdoG2gyRFODjc8BqYZZ7bF6oe69JovNH43BXaArHZESyEQuh3droL1iW3qM7WG3dvGYKCRmv4CcYWQdWEKZEseOVMHugKCAUObQZ4a7lllrBbcPLqaXLt1A4t6X9dcGaNppN72zbNythnV6ImIS0sklJ/2D/FvN64GaUqAWRtuIuJp8I+8ReE+x/+GPiDShjb6X/1WuzZHkh3rikpaj8i2+GxPY++7DjMUJkQXhRpu2vunZ4e3Jxh80pcLNrBjvRBih6z3XBtmz7Jhow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d42cb692-a749-5d6b-4a37-fb03898c499f@suse.com>
Date: Fri, 29 Apr 2022 14:19:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86/cet: Support cet=<bool> on the command line
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220428085209.15327-1-andrew.cooper3@citrix.com>
 <d23258dc-3837-ebe4-26b1-75b0f32477e9@suse.com>
 <26f1d8e3-597d-31a7-00bc-f17efeeb3e55@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <26f1d8e3-597d-31a7-00bc-f17efeeb3e55@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0050.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::25) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe09d26a-1b95-425b-4f67-08da29da794e
X-MS-TrafficTypeDiagnostic: VE1PR04MB7408:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7408FD60CCC737EAE6A7181BB3FC9@VE1PR04MB7408.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6UG0xg7BBX/49Apv7BLsJJMpa+zogfRwfMqsECIGIfVkPUx0hdTPnSl1lb0XxYrzjxv9zKoh9fbHi8VcKS1Q0hVaNyZZRrCOKuAx1/ELyX+Wv9vozr96WPDIfWP2fTJkilLmqibe4fsofb5W6Cc/FoTIYQlbENmZQ5+woCCMScO/geFqhJcuJ8FIrJcs2hCP1hKMDBumTS0AOOvO0ZRq7l3p0anOg/fJLoDq/sccCFmThrxNdA5LR9JitsaS+FR2u3yLDH7HAvWsnbmDfbL/x90gql2Wz1kE82LUgdSpQaFimlFtdCbw4q2Mbbkvmi4HKoDsgT5RXja1Q8Wwxu4NMJVHTjXbsHB3FOGuigmodoeFNDlCqY+VkKzKRgGdJB/hsVu42kT9C2ILBBrR6XhBIQKCRZaB8mzNh3QgRkhSq03Zj9A1dAKmd/tbWuJR3P3MKgc4zjmzMs0qyI06IpOS7rK7q+18iPcXxWmGmd2zkDzFTpIIQxn60ptP9Qm+3ruUfDRunDgzWYn63TIZ7Z3EhlpFtjEb3EsS56DSmh4G4y4lsTfYUtpJBWBKp5n8EyNVoBBPTx5wU0y/AX2ZUgwnEGGN9slylwzYdCHYJhtPLBT05MpGb9eeQvs6sZIt2X9eD5h9jGgw1jx0/Q4azexWzuAF3Vd3ERR7fFi2En3BcxqnENij0kTfgFgHe3LSJ+zQOBH8ARhBxB3pnWXNqnsT4Akm3Qj49WZJ7sUAQHrjJOZj0cSVQ+x2r3gf4NKPXgKY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(26005)(316002)(31686004)(6512007)(2616005)(6486002)(5660300002)(508600001)(4326008)(54906003)(6916009)(38100700002)(8936002)(6506007)(36756003)(53546011)(186003)(31696002)(83380400001)(66476007)(8676002)(66946007)(66556008)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GWCYG1LRknJ5dmWIwdU9mA4jxW9bSJkzqVLdKNiy5dfhe62IWX9HkX1KxZo7?=
 =?us-ascii?Q?bbDUNlJ/4AkpZVfSzMkclVcOzkVCrStv0kPH+IcavfHEsGHD6GanBnICZvzf?=
 =?us-ascii?Q?EPUFxvJiQgMj5LToo/YjA8bdqNKM4xZusdFKc33pmfE2FUGCVDo4HnL1vtaM?=
 =?us-ascii?Q?dFKk0Acv4sTnZTJ773r8grm66dZ3cnfwELwrY/BRIt0kLP88pOC4VXpJ16S0?=
 =?us-ascii?Q?J8Mln0EL/g4JI3fzD68BCS6Wwc+aZWkGl/r8ykkzEWGYZhsnObtNFI3x53Fx?=
 =?us-ascii?Q?0Ebl0TYyi3FkU3CqI/l89HVRNulXzELBYBFO/TXxcz+1smuO9jGqzLIIIYRn?=
 =?us-ascii?Q?yFhCAtsE6DOEqFYo5u9JHz05pKVStjoI2B3Yvr7KzRt5Alxvq8QfINOqHDDx?=
 =?us-ascii?Q?8fLWrZShAX30CRQK+UQyh7TkYl0chaoQIQ46W0VfPUB3tqMst/mqdMGnUabD?=
 =?us-ascii?Q?LQUKluILFdtj4/02ef04LjqDNPYk2u5S5Tjf1Cm29ID6pDqcvDPt4w+9dATN?=
 =?us-ascii?Q?WJixKyiyqJxVfMSWRlJ+J6TcBE3QMrycA4oiGZa5D9ERl1HsbENDBXW2mLy6?=
 =?us-ascii?Q?jw14JUwlFC6W3PSKo0OLjZJDiqM57XIVshl8ZQeGnW5tC+6Yin8vOb3qWzlg?=
 =?us-ascii?Q?x9Pv4a8hy/LIZWzpA72MhyIhpwba5btl1qOoJo60xDrc+gQjCT9z8im8qXKu?=
 =?us-ascii?Q?+aOWvYnzLaD1sdUt6kWA9+ggSxTeUyr7i00kUjZSCxjxsrKmGAg+b6WehAp1?=
 =?us-ascii?Q?4jzlNB1p+qIKj0ujO43FYlS8RpObIJJ8OQD6KUfFfCyO+Fqn7OsRGI93HZtA?=
 =?us-ascii?Q?EpBvmyX08T2oxYURMKLf0wc+MDSQ+7w23NQtMQUzHsGWkGL2ROXPnYkYOVAN?=
 =?us-ascii?Q?5EH86k9sfFfdu/YYblf+cPmrPT8O/n5gaYtncsj2mLqP3HcuxjxU7pZ6xMt6?=
 =?us-ascii?Q?VTIVK3LibPVTwLN0a3BWgYR9VPIPda1C4rcmurwctLKyDiFDrquoPX5ub0eM?=
 =?us-ascii?Q?ExPHH08nD1rrKBFTpu7/XU0BNqseHKgU+PVdxP1Ap50dG/EnsrtAj+gbtvIB?=
 =?us-ascii?Q?RhrJTTOG8s/RpaI0cwD0+icba5ySsZL706faPay+NxnpzK4rf19LpTKl7RzF?=
 =?us-ascii?Q?0PdjFPezTUXnV2+1s7yjVYUKew82+iCRNCeS6iEKDPZbSO+FK+4M9GOs15io?=
 =?us-ascii?Q?SlSOQtYEXAdubNE4oqK9+198jsEBgyj2cFyPdYMUFmC3K+Tn+LUzV7OV8L4l?=
 =?us-ascii?Q?hPWdLiOOCS9CUlGnno88aUwuJAdWKl4qr4iVbFi1gmPTTYA2Ty7y+6KOtXyM?=
 =?us-ascii?Q?ykzyjVs79OFYjbEKTCl7DAHyklZlK83Tm7EwBwPXbLcBLVEc5j2JIIR5GHaF?=
 =?us-ascii?Q?xaCjnrI9RxIvpDPfCTJ6bo90oFQasIPPOVbRFeC1wEMmj79Zj6iRemcZJ2wX?=
 =?us-ascii?Q?T9K6hqDB2xp25jLcGMcQIXBB9JclUwVbUxYosG7dlkimbT54YqcFvrfVbkwu?=
 =?us-ascii?Q?XFYML5Cu6oUJkCd4ReqSI3SVtEz7oH9eycuH7eV6K4JoQeLvo7UKsm8v7ufQ?=
 =?us-ascii?Q?qhXmW8ARv/bSFJpUg9qF5jkh2pKhY4u7NupR9vH3VSUsvb9JdE8n3ZlcjrZY?=
 =?us-ascii?Q?po7/1fbJoEvpF0aUWNnYJT8VT3abHmWC3vBoOoC8aSl5jDHprVQVKaI35owj?=
 =?us-ascii?Q?huINtuTnUl9HPyT4h6FyFcCo5RJXqaEHKNaYVW+eD/0+X6LSrCcMFrg8+0W9?=
 =?us-ascii?Q?bE34ebEhAQ=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe09d26a-1b95-425b-4f67-08da29da794e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 12:19:14.1912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LJwm34636XlCYgoDkXArQ9RgtG9FtBBNH9N+xLDEhGt3RV5qH1WGsLjf6QyGF607B3gjalkuITBWyIWGrbSquQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7408

On 29.04.2022 12:13, Andrew Cooper wrote:
> On 28/04/2022 11:13, Jan Beulich wrote:
>>> --- a/xen/arch/x86/setup.c
>>> +++ b/xen/arch/x86/setup.c
>>> @@ -117,7 +117,20 @@ static int __init cf_check parse_cet(const char *s=
)
>>>          if ( !ss )
>>>              ss =3D strchr(s, '\0');
>>> =20
>>> -        if ( (val =3D parse_boolean("shstk", s, ss)) >=3D 0 )
>>> +        if ( (val =3D parse_bool(s, ss)) >=3D 0 )
>>> +        {
>>> +#ifdef CONFIG_XEN_SHSTK
>>> +            opt_xen_shstk =3D val;
>>> +#else
>>> +            no_config_param("XEN_SHSTK", "cet", s, ss);
>>> +#endif
>>> +#ifdef CONFIG_XEN_IBT
>>> +            opt_xen_ibt =3D val;
>>> +#else
>>> +            no_config_param("XEN_IBT", "cet", s, ss);
>>> +#endif
>> There shouldn't be two invocations of no_config_param() here; imo if
>> either CONFIG_* is defined, use of the option shouldn't produce any
>> warning at all.
>=20
> It's this, or:
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( (val =3D parse_bool(s, ss=
)) >=3D 0 )
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
> #if !defined(CONFIG_XEN_SHSTK) && !defined(CONFIG_XEN_IBT)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 no_con=
fig_param("XEN_{SHSTK,IBT}", "cet", s, ss);
> #endif
> #ifdef CONFIG_XEN_SHSTK
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 opt_xe=
n_shstk =3D val;
> #endif
> #ifdef CONFIG_XEN_IBT
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 opt_xe=
n_ibt =3D val;
> #endif
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>=20
> I'm not terribly fussed.

I'd prefer the alternative variant; hopefully Roger doesn't strongly
prefer the other one. And then
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 12:35:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 12:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317268.536521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkPq0-0004IB-Nm; Fri, 29 Apr 2022 12:35:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317268.536521; Fri, 29 Apr 2022 12:35:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkPq0-0004I4-Kq; Fri, 29 Apr 2022 12:35:08 +0000
Received: by outflank-mailman (input) for mailman id 317268;
 Fri, 29 Apr 2022 12:35:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xZxz=VH=citrix.com=prvs=111f028e5=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nkPpz-0004Hy-1L
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 12:35:07 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cac05772-c7b8-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 14:35:05 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cac05772-c7b8-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651235704;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=j7VY6uzq3Gf+9w6ZGEsdVEoRlQbbe7j2kbmZoluxX4Y=;
  b=cMN0qAbSrHXjkNwGh43Yv1gbStIK5zDDMEpxckkFRqEt24a1Dc5VchaP
   QPcgBKtxdNMjXaAp+OUYDjwFNQexF1eNb2P8ok7pMMRHadtPtDGZtSiMD
   vlctAWXv2rIVQiszoX71yC8BLdALWTpRN1+Ae2XPab18smbukoxqsK0pQ
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70108997
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9D4fsqPaaxEhVbPvrR3Yl8FynXyQoLVcMsEvi/4bfWQNrUp2hTIPz
 mRLUT/UOveMZjSneIx+a9nip0kHvZ+BnYMyTwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZl2N8w2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1
 d4UiceaETcTObDentgzDyRgGi9QBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gRRa+GN
 5tINlKDajzcTAdVIG40Iq4hv9mMliP4eAVb8nWs8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7y2weDV4GWF2TpKShzEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0RtEJL7YQsDG3zbfG5Tq3WlU8RzBvUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPTt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp+ZgPc1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpif6JdoJuWokfRoB3iM4ldnBO
 R67VeR5vsI7AZdXRfUvP9LZ5zoCkMAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPmL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3apXalk0DALGvCsQVmKZKRW03wbEALcieg6RqmiSreGKKxElJ5yft/I4c
IronPort-HdrOrdr: A9a23:zdOLRa2d47yVU/omrdJlFgqjBLIkLtp133Aq2lEZdPRUGvb3qy
 mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM
 9bAs5D4bbLbGSS4/yU3DWF
X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; 
   d="scan'208";a="70108997"
Date: Fri, 29 Apr 2022 13:34:40 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/2] tools/xl: Allow specifying JSON for domain
 configuration file format
Message-ID: <YmvbYHbmfXYx47r2@perard.uk.xensource.com>
References: <cover.1650422517.git.ehem+xen@m5p.com>
 <09213ac26738ee51401b454534c6b437766481b7.1650422518.git.ehem+xen@m5p.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <09213ac26738ee51401b454534c6b437766481b7.1650422518.git.ehem+xen@m5p.com>

On Tue, Apr 19, 2022 at 06:23:41PM -0700, Elliott Mitchell wrote:
> JSON is currently used when saving domains to mass storage.  Being able
> to use JSON as the normal input to `xl create` has potential to be
> valuable.  Add the functionality.

"potential", right, but it isn't hasn't been really tested. When
implemented, I think the intend of the json format was for libxl to
communicate with itself while migrating a guest (or save/restore). It
would be nice to know if it actually can work.

> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> ---
> diff --git a/tools/xl/xl.h b/tools/xl/xl.h
> index c5c4bedbdd..a0c03f96df 100644
> --- a/tools/xl/xl.h
> +++ b/tools/xl/xl.h
> @@ -49,6 +49,11 @@ struct domain_create {
>      int migrate_fd; /* -1 means none */
>      int send_back_fd; /* -1 means none */
>      char **migration_domname_r; /* from malloc */
> +    enum {
> +        FORMAT_DEFAULT,
> +        FORMAT_JSON,
> +        FORMAT_LEGACY,
> +    } format;

I think the name "format" here is too generic, we are in the struct
"domain_create" and this new format field isn't intended to specify the
format of the domain. I think "config_file_format" would be better, as
it is only used for the format of the config_file.

Also I don't think having "_DEFAULT" would be useful, we need to know
what the format is intended to be before starting to parse the file, and
I don't think changing the default is going to work. So for the enum, we
could have "_LEGACY = 0".

The prefix "FORMAT_" feels a bit generic, maybe "CONFIG_FORMAT_" would
be better, or something else.

>  };
>  
>  int create_domain(struct domain_create *dom_info);
> diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
> index f546beaceb..04d579a596 100644
> --- a/tools/xl/xl_cmdtable.c
> +++ b/tools/xl/xl_cmdtable.c
> @@ -31,6 +31,8 @@ const struct cmd_spec cmd_table[] = {
>        "-h                      Print this help.\n"
>        "-p                      Leave the domain paused after it is created.\n"
>        "-f FILE, --defconfig=FILE\n                     Use the given configuration file.\n"
> +      "-j, --json              Interpret configuration file as JSON format\n"
> +      "-J                      Use traditional configuration file format (current default)\n"

I don't think this new "-J" option would be useful, just the "-j" should be
enough.

>        "-n, --dryrun            Dry run - prints the resulting configuration\n"
>        "                         (deprecated in favour of global -N option).\n"
>        "-q, --quiet             Quiet.\n"
> diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
> index 2ec4140258..41bd919d1d 100644
> --- a/tools/xl/xl_vmcontrol.c
> +++ b/tools/xl/xl_vmcontrol.c
> @@ -789,7 +789,7 @@ int create_domain(struct domain_create *dom_info)
>                  extra_config);
>          }
>          config_source=config_file;
> -        config_in_json = false;
> +        config_in_json = dom_info.format == FORMAT_JSON ? true : false;

This doesn't build, "dom_info" is a pointer.

Also, "? true : false;" is weird in C.


>      } else {
>          if (!config_data) {
>              fprintf(stderr, "Config file not specified and"
> @@ -1173,6 +1173,7 @@ int main_create(int argc, char **argv)
>          {"defconfig", 1, 0, 'f'},
>          {"dryrun", 0, 0, 'n'},
>          {"ignore-global-affinity-masks", 0, 0, 'i'},
> +        {"json", 0, 0, 'j'},
>          {"quiet", 0, 0, 'q'},
>          {"vncviewer", 0, 0, 'V'},
>          {"vncviewer-autopass", 0, 0, 'A'},
> @@ -1181,18 +1182,23 @@ int main_create(int argc, char **argv)
>  
>      dom_info.extra_config = NULL;
>  
> +    dom_info.format = FORMAT_DEFAULT;
> +
>      if (argv[1] && argv[1][0] != '-' && !strchr(argv[1], '=')) {
>          filename = argv[1];
>          argc--; argv++;
>      }
>  
> -    SWITCH_FOREACH_OPT(opt, "Ffnq:AVcdeip", opts, "create", 0) {
> +    SWITCH_FOREACH_OPT(opt, "FJfjnq:AVcdeip", opts, "create", 0) {
>      case 'A':
>          vnc = vncautopass = 1;
>          break;
>      case 'F':
>          daemonize = 0;
>          break;
> +    case 'J':
> +        dom_info.format = FORMAT_LEGACY;
> +        break;
>      case 'V':
>          vnc = 1;
>          break;
> @@ -1212,6 +1218,9 @@ int main_create(int argc, char **argv)
>      case 'i':
>          ignore_masks = 1;
>          break;
> +    case 'j':
> +        dom_info.format = FORMAT_JSON;

This setting is ignored, as "dom_info" is reset later.

> +        break;
>      case 'n':
>          dryrun_only = 1;
>          break;

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 12:55:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 12:55:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317276.536533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQ9o-0006iP-KF; Fri, 29 Apr 2022 12:55:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317276.536533; Fri, 29 Apr 2022 12:55:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQ9o-0006iI-GD; Fri, 29 Apr 2022 12:55:36 +0000
Received: by outflank-mailman (input) for mailman id 317276;
 Fri, 29 Apr 2022 12:55:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkQ9m-0006i8-Gt; Fri, 29 Apr 2022 12:55:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkQ9m-00088O-F6; Fri, 29 Apr 2022 12:55:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkQ9m-000107-3f; Fri, 29 Apr 2022 12:55:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkQ9m-0000tT-3D; Fri, 29 Apr 2022 12:55:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KkGw96VsZhjeL+3QWBJ/GkjQXvN3DiJ+1a64JdHvBHE=; b=xPKEuVyfmrr4yTo4L3w36WCHPc
	hhAQbzTCulakYrV0TR1Vqy+H/ZAkuwZ5WUJNkckRV9eiTSyjB+YL+Bj6HDRbqEbhSvGsddmCiN5rq
	2HZUekvxymzu1jN7RqVlMTMV//y735c4+df+DMgaRCFiCjkOn39Uu8ilUzrUEjpZWTLU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169866-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169866: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 12:55:34 +0000

flight 169866 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169866/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  694 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:05:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:05:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317284.536544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQJa-0008EH-Jp; Fri, 29 Apr 2022 13:05:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317284.536544; Fri, 29 Apr 2022 13:05:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQJa-0008EA-FW; Fri, 29 Apr 2022 13:05:42 +0000
Received: by outflank-mailman (input) for mailman id 317284;
 Fri, 29 Apr 2022 13:05:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkQJZ-0008E4-0s
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:05:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 115f0688-c7bd-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 15:05:39 +0200 (CEST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2056.outbound.protection.outlook.com [104.47.1.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-Ap0OAm-4O7uM4Mx6DFDhbQ-1; Fri, 29 Apr 2022 15:05:36 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM7PR04MB6824.eurprd04.prod.outlook.com (2603:10a6:20b:10e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Fri, 29 Apr
 2022 13:05:35 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 13:05:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 115f0688-c7bd-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651237539;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=s5jGIOq+SY8wUKwZIKC3ATH/uVXY4XNucamYnYy/Jyw=;
	b=kfQA+GXCnhRieoLicuf0bReTLwz+92PInd/w2K1HAUlAG6mp5FADEgL5wtuS9iv/XiIk7u
	P5hf0nUi/wzdMiALx/NsCxzqgYa4iXraIyvJCCbQqv8ZdE4rTOy4AKjHzLmqez46xt2esF
	+LXUU3h77Q+90NqnVe76b6sZL+wifrU=
X-MC-Unique: Ap0OAm-4O7uM4Mx6DFDhbQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KDkcIwaotuPqquktLULUPN2CVzOTdEa3zWbc61kPmRY+W66DkJVzgBkDfP/QMuJLGH9XUnicU4BwyCRqK7sX8Ids6h4eJrroKSudMcWvgtQabAZ09nIP0moFeAof4fKeEaMOvJFIXmubLYXpxUXrf+r8Sn0uNPnz+9XP4MslK2MWihFdQM60DyTKlV/h1MbzK1gsi7aR4DTAe2Mw044kudKbu5hXBm1oH+bXSxw7MjbxSGgUMetzT7eGOyc60Gib3e8ESADFWD7xN3BijTY2QLGM6qAVEbol8/9W5PpZU0l8SmKYgvqfxmbOglnnGDPVTlkKdwI0y+rksF20CMhKwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s5jGIOq+SY8wUKwZIKC3ATH/uVXY4XNucamYnYy/Jyw=;
 b=lezfqVLYcSQPdxpC/85sWnLoLmUGTXuWzoVWCeMQjUvQe3i7I/wYJPmfl9PiYqJ/CAoLER6C/N7pfJL8/aJFWxvHVsfOw9f9pTCWxJyuLoqE460rS9rHj51/RpJT61xZ0GJ75QBPlsZrrtzsV+NPsKmfd8Co13c5CjsCPtdPKEazuTsuEv4pQfWJGb/hoZAliBP6OXaRdWJcT89xCoF1xtg77cMTOrHOos/k3o4Zo6bqICZDRwo8/4ZBybXwTSYWW+waOv9mRyJYeOeFEkjV0lmO6LXtvMweDLWX6bvGTbgm5hUogSoPHHthG9cGyeA7YBQJ0nzLXB9IUijZAnbcQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com>
Date: Fri, 29 Apr 2022 15:05:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as
 phantom functions
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0150.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::16) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 120da4a1-03cd-42e4-2af2-08da29e0f29d
X-MS-TrafficTypeDiagnostic: AM7PR04MB6824:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB6824C1B6043E015F66BC30B2B3FC9@AM7PR04MB6824.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	p2HgWZ88yGxEM4bAYKIYhDO/acDKnc3FMo5GEFb0jjVd3IEfEkIGRtOWI8n6nLf/GlJkEO2DqdEaj04f9+qxDQSHwXK6Ie+SOLcdW1RrWFKIU+uYfAyFbMvyLrvnIKL2zVYqNskDzWURmLhJGK8Qs0RhYVrHDJc4i2P9VLukNgtKbnjBRGDwK0M8zT+SBC3QsBIUFSmp9DZ+BJMYdbvyWeg3GruvN5+XwzhMVcwJtZGT+h69Jt2FHpbYlkpvtWlF/M86hvML+oIg/c3BZtweEFPJww0TyU2fdRrbL/lWrM98EO9owmQ71s/AfQFyaKInIEJ2Q27giXOBKjFbPS0aC39uZ1PFd+KH42qV/eANvULZ+f+CKZp/6N9nqgEau2MzhTqiSV/OJfQhG3sG35xcUrJHKVs2rp67bGlaCslDVlA78kQdQoxqLM8co0Gprr34pKv18U30IZrAO0cN2ceW8W4MxWgW95c4JO1wnEV89fJom9EAJ1t8iFUSN964fAdqOjczOmGnMNtuMtZqBVpq3m9bMfUBK4kDPzWIq3RV6S9XIFdSnCGpuSm11TtId2bLIZMmV/rRO2CIGA96GcITNaXzo2l6vwGRtkpGm76jFWWkNymrTFbs2i2ZQQDkpINQ+v8nO52QOWF867jedQQX33OEesC9TufUiYi32F7xP1gQNA+g7MBJrpbhwGXPdcCiPl2lG7Zs/L98KdOZ+2xqyVtlJuCj4kHwYLVTMnb/e4c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(316002)(5660300002)(54906003)(6916009)(26005)(31686004)(83380400001)(8936002)(6486002)(36756003)(508600001)(6512007)(86362001)(31696002)(186003)(2906002)(8676002)(66476007)(4326008)(66556008)(66946007)(6506007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NDZ1b0xMT2NLeUdEeFQxWmt4TU16TjgvNU5HS0x3MFZKcTRoY2xYOWJZejBr?=
 =?utf-8?B?LzVNQnpjSElzTmVxVGRQOWg4cGxJUXQzZkRuZXN6SkhhcDdENkVuMnBtTElS?=
 =?utf-8?B?WkVpMlVyalB1cXNJdVZmcnNPd1ZHekpPUmhKbzBMMG9pUmlXMHZFK1pVUGdz?=
 =?utf-8?B?SFZFTGt1bWRZTy80b0RHYXJDWWEvdm9iOEFvNjBLc0F6Qm1BcmVGajVUbGh5?=
 =?utf-8?B?NDY1SG1NSGhhVnI0OFQ2N2JVZzgzQUJPd1ljdkVvSGFWSzZydXd4TndSb0pY?=
 =?utf-8?B?R1prNEFkcWNNK1ZYL2E5ekN4aU5ZeDhka1Azbk9USUovdW44dE1hQSs3R244?=
 =?utf-8?B?QnRrbGI2TEFabmRUR2p0ak91NXhSVmtTUVR3T3BWTTYvbm9DVzlXUDhwczVQ?=
 =?utf-8?B?djY3N2tSS3h5aEVOY1dmVCtkOXZGaTFFSlBPSVRUckZxYjByRHBsMFdnak5o?=
 =?utf-8?B?OW55S3JwNHV3NTRwM1Q1OTlyUTFFQjJyMUJVNmRzWDIxd0dwdzRXd2I5VzZJ?=
 =?utf-8?B?UXBOZzZSb2dpODhCT2tMdEM2VDE0V3dDRlBSV3M2T2c2cG9vd2dTZzlBZnls?=
 =?utf-8?B?RXRqWExRcGUwVUxMVzFPWlR5b2ZwTE5tOVdjdkRMdXowS3Q3S3o4ZjVuWEdO?=
 =?utf-8?B?ZG0zTTRrMEk4enJzeDltMGRCZkNCUkpJM01FQ240OWxXUG9VcVZ4VElSZXM1?=
 =?utf-8?B?cHdVVysvQzZhaUtyMlN4SnRWM2d2QVliZGw0dzJCUzltdWg2dE5xdVB2N296?=
 =?utf-8?B?b3VaMStKT0ZER0VZOUQ5VWUzbGVGS0VqbUEraUJpcnhnbFNFTWVuS3FMUUty?=
 =?utf-8?B?dVE2NDhMazg3K2NnWWpQamNPQzlmRXNzelhyWElKVklyZExFVnBFZkF3M3FK?=
 =?utf-8?B?QTMyQ0gvWUR4UVp5eDRrRHYyWGpXWml5N1FIaTFnU2RTY1JNSG0wM3lQQnlr?=
 =?utf-8?B?cEoybEkwaVhZRVFVbnViZWNaMytvRzJaU2hId1NxYWpNejZtZmJKSFVGK3Qv?=
 =?utf-8?B?aVlmZGF5OTFLYUVPMmo3NUdTQnlXYklyWnBtcThTTVM4V1Z6QjRkeklCb2tp?=
 =?utf-8?B?aE5STWU1MkhSeDFIQUVIWmNubjhCc2lJQ21NTnNHUW1xT2ZZNzN6L2I1NjM5?=
 =?utf-8?B?T1d5VFN4Zk92UElGVm81Qk11dlpnY3EvTjNrenltQTd3VStFemZDcDJtZWw1?=
 =?utf-8?B?WmpNY3pYYVlqbDdCRDFvbnFMSnJOQjdoZGdmUWtrUFhLemVaZlo4RFpCSGdU?=
 =?utf-8?B?UFR2cStlVDRyanZtV0xaVWtiNnpUeDI0U1dQekRoNW9sbEk4Z2plVi96bXZH?=
 =?utf-8?B?RlR2UmVHTzlncUk3bkNIaS93dWxqRENTWUM4RG83by9ZakNaQU5FSzhPMFVP?=
 =?utf-8?B?Um1LV0pGUUg1elRlbFBsMWhFUS9HemJJUlp3dG5PaXYvVUxCQ2I5dC9Rc2dk?=
 =?utf-8?B?TFBXRGFyS0NadEc1S3pOYmlaYWZ2bmlFZnRwQkYxbUlqUmJodkh2S0VXeU9I?=
 =?utf-8?B?ZTR3K1lJc3NMY3ZDWWtadjdMeSt4MTRFUHlMOGFoNHBCaVJRSGI5WGZ2VVhP?=
 =?utf-8?B?emhyUXdWbENCSjY0Q1JjdWlxSkYzL00raWZOYjlrVkoyd1hVVDJMMjdHVnRu?=
 =?utf-8?B?MXM3cHBMeE55S2xlQzM2VnN0K0hDMUNqQWZ2WU9XZHlMSk5uR1Bnd05tcXg4?=
 =?utf-8?B?bEVrRm1oL0dXcmM0WTVXdHhvTHcrUUhXb1VGaWtWekRmZTdBcmd0ejF6bUlG?=
 =?utf-8?B?ZHFuRWZ5OWtRSFdzTG9Mbmt6U2VPdTI0dUZKaUtwK1VnSlR0cm84OXl1MWt6?=
 =?utf-8?B?dkZFUXBwRTF3RXFsZ3NVbnZwS1lobEdCK2xpUVF2THphL3JsbGhPNXFBQmll?=
 =?utf-8?B?QVY4NmxMeFp6dUNMNHYwSXhWUmRBQWZjblUrdURLaEg1dVRwWUNvcGNDbnJJ?=
 =?utf-8?B?RFhsQy90Y0oyZEw1clQxbjVSTWdvV1BVR29SN1R5L2lZV3RmUU5vSmVDeXNC?=
 =?utf-8?B?ampqbVBtMFRuWGJhUUJYQ05qN01vQnpVTmJPdUZkRUFXRVFMNkhCMzdIZm4r?=
 =?utf-8?B?eS81a0dvR2RxR2htS1ZCNVRqMlZPQUlqalR3ejBnQ0I4RUtpRm12dEswcisr?=
 =?utf-8?B?TlY2NTI1d3hsa3VsOGVST1JROGF2ZXBSdEZmTEsxM2NKRUVXVzMwa05Va3lO?=
 =?utf-8?B?U2pkSkJlakFSRHlqUGVJMloyUVhDdHF3ZVV4OW9VV0o0MUQvY050QWhqai92?=
 =?utf-8?B?cXIyb2p5cjBlNFZtcW92bmY3dThPTW1MS1NkeTZzTnEwUlJDSytrSHcwMGxC?=
 =?utf-8?B?eEhoQnhqRE9LdlF2SGlEZkhRM2R5RE5YdURtTFJaWmNjbFd1TnQ2QT09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 120da4a1-03cd-42e4-2af2-08da29e0f29d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 13:05:34.7552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iHfugmuCghoARn+PJYgX1iKyzyEIkCnpIVcqExC1ywRz3e5M92H0WH72T707N8OOc7ifo72U/a17WlzTtGMtNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6824

IOMMU code mapping / unmapping devices and interrupts will misbehave if
a wrong command line option declared a function "phantom" when there's a
real device at that position. Warn about this and adjust the specified
stride (in the worst case ignoring the option altogether).

Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -451,7 +451,24 @@ static struct pci_dev *alloc_pdev(struct
                          phantom_devs[i].slot == PCI_SLOT(devfn) &&
                          phantom_devs[i].stride > PCI_FUNC(devfn) )
                     {
-                        pdev->phantom_stride = phantom_devs[i].stride;
+                        pci_sbdf_t sbdf = pdev->sbdf;
+                        unsigned int stride = phantom_devs[i].stride;
+
+                        while ( (sbdf.fn += stride) > PCI_FUNC(devfn) )
+                        {
+                            if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) == 0xffff &&
+                                 pci_conf_read16(sbdf, PCI_DEVICE_ID) == 0xffff )
+                                continue;
+                            stride <<= 1;
+                            printk(XENLOG_WARNING
+                                   "%pp looks to be a real device; bumping %04x:%02x:%02x stride to %u\n",
+                                   &sbdf, phantom_devs[i].seg,
+                                   phantom_devs[i].bus, phantom_devs[i].slot,
+                                   stride);
+                            sbdf = pdev->sbdf;
+                        }
+                        if ( PCI_FUNC(stride) )
+                           pdev->phantom_stride = stride;
                         break;
                     }
             }



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:21:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:21:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317290.536555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQYT-00026X-TH; Fri, 29 Apr 2022 13:21:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317290.536555; Fri, 29 Apr 2022 13:21:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQYT-00026Q-QJ; Fri, 29 Apr 2022 13:21:05 +0000
Received: by outflank-mailman (input) for mailman id 317290;
 Fri, 29 Apr 2022 13:21:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkQYT-00026K-7Z
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:21:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37bbf62a-c7bf-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 15:21:03 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-ouXjSra1M7WTHTVbutst6g-1; Fri, 29 Apr 2022 15:21:01 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5223.eurprd04.prod.outlook.com (2603:10a6:20b:3::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Fri, 29 Apr
 2022 13:20:59 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 13:20:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37bbf62a-c7bf-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651238462;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=7ZzJDH6f8FIiK74a5RGH7pg8PNMuStwl3xMqiFiX1TU=;
	b=HGqYJtJHzA43echm53PrircyQhNjc2TvWR2uNh3BPUIioXFG61nIBJll+FK6gx/rTGxEU8
	lTFgv/btFlqV7gVlrf9eUPBHABGVVrUSQqUWWTBe4ygxIHLYvhX0Gd0HxzydeUvijskwNZ
	2gnS81aIblNF/kNL6motdobZaV1opXU=
X-MC-Unique: ouXjSra1M7WTHTVbutst6g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PX1ffaPNRK1FY2CHsOsxhQnhq9KRAuuqr5Oiy+kS1DNAsRbwcHISqIhtKxBt1zApsmm9ocipgcp/mSEv9z9ph8nkc0SiLNF/gEjPCJuK3G+8UWbBgnizsepEvrHupEgal2S+4+N1b6mTKDpzsrfgix4+7ss9yMrbGSGoji1m3xK3t2k+9E15WmKhm5KTkMCBK/ztg/xalGNODaINcA1vVQuqrmqXW2hRHa0ScHVehYG0yWjjckRG458GCepGC2fj/N0IA2rgV3Y/LnNS9RkbXW9fSr+OlnQO/0QjE/J4Y6wr7RGM3hVWS1n5TA2UC2vKRqEQhZ3uMLf84BF+7NH5NQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7ZzJDH6f8FIiK74a5RGH7pg8PNMuStwl3xMqiFiX1TU=;
 b=DCJZM5XhBDBTgamUX/1yL/sH2pSg/hs1/Ha3RRrTRX/nbgKv96W3SyJy0hRvE9nhecpe3gIIlRKVmLYJYz4bJQsiLzZ/cNvN5t6yeIjoqdR99YqJEkARIRPm9IW3nis5fcJG+ielv1nTP8RpF0jaocJG2z3SE4S0yO/H9B2oHV41ZEdnBNZn0Z1mmKEVsJCSkwrnrJgPgO2gXu/uTUmUdeab9Z6ReuhRoVyDZrPeBPpZyulojIWKnxa3p01/Oc9Ip4NIB/j/BrX4NHq+qqOk0nx33iROQIw5Y5KkCBJsWAmDVOFvO1uy6aJ2cPs/l34KHhBGgIlByC9LDP397/gR6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ad64e3c6-9f89-c0ea-05a9-cff995ac200f@suse.com>
Date: Fri, 29 Apr 2022 15:20:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 David Vrabel <dvrabel@cantab.net>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/mm: slightly relax TLB-flush-local check again
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0018.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::31) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ee6d385-f352-44c9-ba5b-08da29e319ee
X-MS-TrafficTypeDiagnostic: AM6PR04MB5223:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5223C2F6060171F62AEF7309B3FC9@AM6PR04MB5223.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NIPYmRLCUCww0xKBIibWtF7p1zPWagotU+91lHEtAIDHiCyJNdsJ/zbM3chmcavI/hGlPRnYRbRXYb8D+xpRzsjEB3lqniLBzZxq0jnFqZKsxNr1ZJsF2LuXEb9tguLpBeZxy1FLelV+4cFzBt6cZ/u9kzFR8Wilmk7ZbOQ6J2Cl3ZpXVvdUOZuBlt3YwHFcHsidOmAreWshKwnMkZoLaTAB7ymlplLiv9UD/jwnEc9WxUwJBwEGnXcp5MvAZHxL2ByKyvECu+KmTE53x1/+OTdBn2YlnU+69VON5JoaN6TDdxJFtIUWrWV9L4baT82iaXnkSjADmFN5xpXGt1ZU7SMDD4TKNXdHal3QgJHf/gUQcdq3Ms7kGHJXW0S2pdzKQa3dX1it/XcNxhHM5kPQcD8ejJy9wHW645Ffm0iry4eESRPjkxunOeKC5BV4ZB7UB2VDUuMAkgwmNcE4X9HY5kbP3mY6GljqmQkipxaExQAddbB6XhOTG5tvqbop7p77MPVAymNuJunuT6c/GtoGYnn9eBFWkp0KqVgSw4lc2K6h+D9KbUIjd0ii7HdlKO8whqJ5oy6m4jpcRAmbpeaJAF0mjjDjUqtKj6khD3ZHkrnWpdmGGz+gPJw4Qu72ISssgm+Oi0zY7Cz5jI8Vav76R2Pwnd21lwgLFploDYUS3nLNl9gtLLVl4JlVIm4WTN+Oy3zI68Ir87y9FhUKmzBjguTu92966fU0bhU0Ik3KGpY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(26005)(6506007)(2906002)(6512007)(6486002)(8936002)(508600001)(38100700002)(36756003)(5660300002)(4326008)(83380400001)(8676002)(66556008)(66476007)(66946007)(31686004)(316002)(186003)(6916009)(54906003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RTdTWXJsTHBwWldSQ1VUejVyc1Z1TEpaTTE0R3NMRXN6OXVWd2kwMU5GT2xI?=
 =?utf-8?B?dHdHRldTRlZrNThMckh1TWROYmRiMm5yb0dOYndzdFhsVFdPWndyQWE5ZGEv?=
 =?utf-8?B?RTA3Sm1nQmh5aGNDZVdXT2hmeEdHRTBha0JoeWZYREZDSXpmWFl6bXI4aXFL?=
 =?utf-8?B?cHhhYjV6eDBuc0w2UWF3d2o0UnkrbGxGV1FudjU1MVN5RkU1SmdGbmpYVUho?=
 =?utf-8?B?R2ZKZ3NYbHVHb29mYWRRWnhXZGV6Q2FuSlBlWFZlZG9OL0NnbkNtOEI0NS9L?=
 =?utf-8?B?engzbENaSk5HamFMWkVUdTlGaHpEMDVQeWtvN2UxcjltZnMySEMyM3drZFFO?=
 =?utf-8?B?V1UrclpnWDBvVXNVaHFJcW9LV1lmM2JoY0N0Z09GdThvZTF4eVRwUmhRWXJD?=
 =?utf-8?B?cnZXMHY3dVpkYUFidHFXTUJ5K0xvYkcwVy96MmtYY3N4MVl4Qk90VTBScnRG?=
 =?utf-8?B?ZWhha3ZsUHZBSEF6d2hXK2lNVG1yNHFHb214bEtvc2orM0NacnVVcklweXRn?=
 =?utf-8?B?ZDRmMDYraXVkYnVvNnhHQ3hBTHJpVGVhL0pOR0t4Y2xISXNUUGNHS0RGVW9i?=
 =?utf-8?B?SExhMjUySkFaZkVGeUxkZGxTSlRYYTVaMm91MFFlMTRRK1ZGZzZ3STQzQk1p?=
 =?utf-8?B?UC9DbjkzZHBDdkpxM3IwRGwwcytxRGZxTmxtTjNVK0UyU3dCNUtKZnNNVGFs?=
 =?utf-8?B?RmFKb1RmdjNYNUg0S0o5UityTHY4STh2aFRXWXZheHVRSEhBc2Qxd3duL0ZT?=
 =?utf-8?B?SUlPSzh0RFJqb2Z6L0dPTTdRSWUzS3pnZC9DL3VjUk9oN3UvQUZUcHhDdU5W?=
 =?utf-8?B?ZERIOWpaR1BzY1Q4TTFyeHZIQTI2SzN3eWJVbUVqWHBRampYcTZxejI5c2dq?=
 =?utf-8?B?S0RCbFpvQ2hXaDBmSWt1QVowbEp5QjJSOFJmV2pWSW5sR3NnU0kyK0NOYWlS?=
 =?utf-8?B?M3NYS0c1NlNvNEx5bDdnT0pRVXYxVThTR0MxZXNYM3JWdTI5ZElqSXQzNjlN?=
 =?utf-8?B?d04veDRKUkN6amVPOW5vQVhZOTZPS0RxaFFVVFIzbjByVlVtQnBJSjVrSzJz?=
 =?utf-8?B?emduaWxrUXdsbkRrSU41eWpMNFpWa0FnRHZBeEQ4MjJlSXBkNTZtc3dGWlVt?=
 =?utf-8?B?VkZFa1FGK2phUGdVcFgzNkhTbEdGbXd4cUs0cjRnNUd6bFNXSzZvak04QVNM?=
 =?utf-8?B?Z2prWWhFQVFRQU0rcm1iMzhmS3dUUStCYWlnSFpVRXd4cTMyb0hmVFhRNmZX?=
 =?utf-8?B?QlovRlQ4ZWxOVU5NZFlXTlZtc2l5QzY1ZUpqSUwyUTBwNHhJUU1sRFVtNUtO?=
 =?utf-8?B?VmlBbWdIVGkydlBWQ0F6eWw1blFiTEo5YWpqaGlOSEczSmxHYkxZaG5uTEgx?=
 =?utf-8?B?Q09XclpwVFNuMnlSYTZtdVJ6YmVPdEg3dGs3VlQ3TmtrWURuNkRVSHIxeDBu?=
 =?utf-8?B?bjhWcyt1R3U3Z202SThMbzRtU0k4WkgwblpFZUlQSmF6dzc5Z1pYUExvRVAy?=
 =?utf-8?B?OERZZnFZdjAvUWo5bnNpWUwrbnU2bkg0aGtPRzdKOW0zL1VYRFVIeWtTRWgr?=
 =?utf-8?B?RjFVMDVOU1d1ckxwOHN3SDZQcmFMNXlDMG1jL2orMjhVZXdheFZLRm82L25N?=
 =?utf-8?B?dVdNQVVOOHZVaTJMU1d3RkZTWVVCbTNFUEFKZDRaOUdMTWY1NWsvNXQ1MElI?=
 =?utf-8?B?NmFDSjJCYmI3YXA3LzJoVmZIZk9sZ1IyUkVOL09xdzg1K3lHc2RtNUEwSFUz?=
 =?utf-8?B?R2VlZUNsQkp4b3hmWDc1NkwzN0FhRWN5ZjQwNjFINklSYXlFVTl1T3YwZFVx?=
 =?utf-8?B?QVZweVB2NlRHMU5oMzh2K3o5VG1GRGJxdTEzYWJENXFuUzdpd3FndVhYSVJ3?=
 =?utf-8?B?aFNoUnl1dUxxbDFWQ0VLUmcrN1llZHVCNDZXeGI0UmVZWnpSTUd1ZnluN2JG?=
 =?utf-8?B?MEN3OGZHbVI3RjJwU2R0R2JWL3hLM2VNZ0QxV3JHU2pTM0pvejJweHlyaXkx?=
 =?utf-8?B?ZUNqMFc3cjk3di85dzdmSCtzaTM5MC9lK0F5L050RGI0RWJlalU1a3hPbDF2?=
 =?utf-8?B?UU0zSGxGSGhqUlh1Sml1OTdjWG16VjdBVTdOazlpeGpBbzhkc0pOTnBQdSsx?=
 =?utf-8?B?TGlrRjZOSHUzSWRaTG4vK1puV01RREJ0eXUweFY3K0tPUk8yMU1vcXpVd0FN?=
 =?utf-8?B?TDhHdmErSVljeS9PdXhwL2NhbWhlMVRnRDkvV2JJQVJtVUZWY2NXUStFeEkv?=
 =?utf-8?B?UjJmMXJOZmY1Z0ZhRk5JdXhLZTlRa2FMYWdqcmxLV2dXeHpWbWdxdzI5NFN2?=
 =?utf-8?B?eGJDOE44cFZRTW9sL3JOYVV2N3gxRmUyQnlIZ2lPcDlaWU5nekVGZz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee6d385-f352-44c9-ba5b-08da29e319ee
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 13:20:59.6674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r0HJBganPe56/hvQqhWK0yf1D3F8x2LPY/GDmt//vJFUj/rcam1nC7iBvW8KkHtZ0qgpTmkN/eLyM799L4stlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5223

system_state changes to SYS_STATE_smp_boot before alternative_branches()
is invoked, yet that function, with CET-SS enabled, needs to invoke
modify_xen_mappings(). Convert to check for the number of online CPUs,
just like was done also in 88a037e2cfe1 / fa6dc0879ffd ("page_alloc:
assert IRQs are enabled in heap alloc/free", both instance of which
needed reverting for other reasons).

Fixes: 78e072bc3750 ("x86/mm: avoid inadvertently degrading a TLB flush to local only")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Only build-tested, as I don't have suitable hardware at hand.

--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -5074,7 +5074,7 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned l
  * map_pages_to_xen() can be called early in boot before any other
  * CPUs are online. Use flush_area_local() in this case.
  */
-#define flush_area(v,f) (system_state < SYS_STATE_smp_boot ?    \
+#define flush_area(v,f) (num_online_cpus() <= 1 ?               \
                          flush_area_local((const void *)v, f) : \
                          flush_area_all((const void *)v, f))
 



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:24:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:24:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317297.536567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQbM-0002lO-Im; Fri, 29 Apr 2022 13:24:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317297.536567; Fri, 29 Apr 2022 13:24:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQbM-0002lH-CT; Fri, 29 Apr 2022 13:24:04 +0000
Received: by outflank-mailman (input) for mailman id 317297;
 Fri, 29 Apr 2022 13:24:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xag3=VH=goodmis.org=rostedt@kernel.org>)
 id 1nkQbK-0002lB-RF
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:24:02 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a13f4a51-c7bf-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 15:24:00 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 617476229C;
 Fri, 29 Apr 2022 13:23:59 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1EA1C385A4;
 Fri, 29 Apr 2022 13:23:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a13f4a51-c7bf-11ec-8fc4-03012f2f19d4
Date: Fri, 29 Apr 2022 09:23:51 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org,
 linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu,
 tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org
Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
Message-ID: <20220429092351.10bca4dd@gandalf.local.home>
In-Reply-To: <b8771b37-01f5-f50b-dbb3-9db4ee26e67e@gmail.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
	<20220427224924.592546-18-gpiccoli@igalia.com>
	<b8771b37-01f5-f50b-dbb3-9db4ee26e67e@gmail.com>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 29 Apr 2022 12:22:44 +0300
Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote:

> > +	switch (ev) {
> > +	case DIE_OOPS:
> > +		do_dump = 1;
> > +		break;
> > +	case PANIC_NOTIFIER:
> > +		do_dump = 1;
> > +		break;  
> 
>    Why not:
> 
> 	case DIE_OOPS:
> 	case PANIC_NOTIFIER:
> 		do_dump = 1;
> 		break;

Agreed.

Other than that.

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:26:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:26:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317307.536576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQdf-0003PC-SH; Fri, 29 Apr 2022 13:26:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317307.536576; Fri, 29 Apr 2022 13:26:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQdf-0003P5-PP; Fri, 29 Apr 2022 13:26:27 +0000
Received: by outflank-mailman (input) for mailman id 317307;
 Fri, 29 Apr 2022 13:26:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xZxz=VH=citrix.com=prvs=111f028e5=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nkQde-0003Oz-CG
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:26:26 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6c8713c-c7bf-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 15:26:24 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6c8713c-c7bf-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651238784;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=FsRfEudeWOVVBwaVoaNrZWypJ2Ns2oqixSfA9Jj1aOY=;
  b=XyoC0VMs3E+bBkFrlqMq2Fvb0L2gThLNKKIeci4hiAIsJvcE4HYTPWWz
   C8u1lPUTm9FNxqy8ycWMzJwQv/WRjN1l9jrYd8zyV/eM4SxoV0iUm1GKH
   qAZeroZmoJExQydrT+P6M2iJE33uUkBtvXjkKVk0bZCq8ZTOot4qatJsx
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70114345
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xQGhy6vVUid0CYYY4oVH7P78V+fnVMVeMUV32f8akzHdYApBsoF/q
 tZmKTqPM/2OYGumLdsgbNy/9hgP657dx9MyTANpqXhnEisb+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW1/X6
 IupyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8uLIPUt8oRCyN6MCAvHJRLyK/MAn6g5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD
 yYcQWU3NU2cOEESUrsRIJRkgtrvnl/ySABZuUqWoYQ4zTHV0hMkhdABN/KKI4fXFK25hH2wm
 GXC+GjoBwAAA/aWwzGF73GEi/fGmGXwX4d6PKaj6vdgjVmXx2oSIB4bT122pb++kEHWc9hSM
 VAO8ywi66077lW2T8LVVge95nWDu3Y0WNdOEut89ACEzILV5RqUAi4PSTspQN47sokwTD8j1
 F6MlvvoAyBitPueTnf13qiQhSO/P24SN2BqTT8JS04J7sfupKk3jwnTVZBzHaitlNr3FDrsh
 TeQo0AWhboJitUQ/76m5l2BiDWpzrDLUwo06wP/Tm+jqARja+aNZYal9Fza5vZoN5uCQx+Ku
 31spiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqVl9MYEO2Tj1wVyAfNFx2TxONExKNNlRLFcFf
 3TvkQ9W4ZZSOl6jYql2f5+9BqwW8ETwKTj2fquKN4QTO/CdYCfCpXgzPhDIgwgBhWB2yckC1
 YGnndFA5JrwIYBu13KISugUytfHLQhulDqIFfgXI/lKuIdyhUJ5q59YaDNijchjtctoRTk5F
 P4FaqO3J+13CrGWX8Uu2dd7wao2BXY6H4vqjMdca/SOJAFrcEl4VaKImOt7ItU+xf0I/gstw
 p1bchYJoLYYrSeaQThml1g5MO+/NXqBhS9T0dMQ0aaAhCF4PNfHAFY3fJorZ7g3nNGPPtYvJ
 8Tpj/6oW6wVIhyeomx1RcCk/ORKKUT67SrTbnHNSGVuIPZdq/nhp4aMkv3Hr3JVUEJadKIW/
 tWd6+8sacddF1k6UJaKOZpCDTqZ5BAgpQ67ZGOQSvE7Rakm2NECx/DZ5hPvH/wxFA==
IronPort-HdrOrdr: A9a23:D1f8JqnHxccSqaEHTlEJBzqwRLfpDfIU3DAbv31ZSRFFG/Fxl6
 iV/cjz8SWE7wr5P0tQ/+xoWZPwJU80mqQY3WB8B9iftUzdyRKVxeJZnO7fKl/bak7DH4dmvM
 8KGcVD4Z/LfDpHZK7BkXGF+r0boOVvnprHudvj
X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; 
   d="scan'208";a="70114345"
Date: Fri, 29 Apr 2022 14:26:07 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v10 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <Ymvnb9la58CzrGaZ@perard.uk.xensource.com>
References: <20220413112111.30675-1-jane.malalane@citrix.com>
 <20220413112111.30675-2-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220413112111.30675-2-jane.malalane@citrix.com>

On Wed, Apr 13, 2022 at 12:21:10PM +0100, Jane Malalane wrote:
> Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and
> XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and
> x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization
> can subsequently be enabled on a per-domain basis.
> No such features are currently implemented on AMD hardware.
> 
> HW assisted xAPIC virtualization will be reported if HW, at the
> minimum, supports virtualize_apic_accesses as this feature alone means
> that an access to the APIC page will cause an APIC-access VM exit. An
> APIC-access VM exit provides a VMM with information about the access
> causing the VM exit, unlike a regular EPT fault, thus simplifying some
> internal handling.
> 
> HW assisted x2APIC virtualization will be reported if HW supports
> virtualize_x2apic_mode and, at least, either apic_reg_virt or
> virtual_intr_delivery. This also means that
> sysctl follows the conditionals in vmx_vlapic_msr_changed().
> 
> For that purpose, also add an arch-specific "capabilities" parameter
> to struct xen_sysctl_physinfo.
> 
> Note that this interface is intended to be compatible with AMD so that
> AVIC support can be introduced in a future patch. Unlike Intel that
> has multiple controls for APIC Virtualization, AMD has one global
> 'AVIC Enable' control bit, so fine-graining of APIC virtualization
> control cannot be done on a common interface.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> Reviewed-by: "Roger Pau Monn�" <roger.pau@citrix.com>

No changes in the tools since v9, so my tag still stand:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> # tools

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:27:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:27:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317312.536588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQep-0003yl-6r; Fri, 29 Apr 2022 13:27:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317312.536588; Fri, 29 Apr 2022 13:27:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQep-0003ye-3R; Fri, 29 Apr 2022 13:27:39 +0000
Received: by outflank-mailman (input) for mailman id 317312;
 Fri, 29 Apr 2022 13:27:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xZxz=VH=citrix.com=prvs=111f028e5=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nkQen-0003iw-34
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:27:37 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 210de3df-c7c0-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 15:27:36 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 210de3df-c7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651238855;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=skkYtrnScwGLZ9ZnrOPk2R2LIXD+n3PS4wQvYmhXiak=;
  b=g0JT6WGQz2Mx5jLnl19pIg8bLlAVDGoioESPkOZZInaraltKKxhCaJ4l
   jE5eN0xblV1ULQ9py4ViCEbEStQTXuVAs9qYly174/yDkupmBRypzE65X
   MY1offh891GtBAY/kjyC3KL0NE1HaCN0jPKKtszgkwsF1jKbSOtxXkgut
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70254362
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:agy0sa5+NeQIozx5ECnrcQxRtOLHchMFZxGqfqrLsTDasY5as4F+v
 moWWmGHMvmINmamL98nYN+2/U0Hu5HQz9E2TAVp+3tkHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YTjUlvW0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSzSCsreYjVyN0cECUAKiYgfvdY05/udC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsWvG1gyjfIS+4rW5nZT43B5MNC3Sd2jcdLdRrbT
 5VBM2czN0qaC/FJEmYHGogUpuSDv2HAXjxTgVipgfUNyFGGmWSd15CyaYGIK7RmX/59hV2Er
 2jL+2D4BBAyN9GFzzeBtHW2iYfnnz7/WY8UPK218LhtmlL77lIUDBoaRF6qu86Tg0S1W89cA
 0EM8y9opq83nGSnR8fwdwe1q3mFulgbQdU4O/I+wBGAzOzT+QnxLngJSHtNZcIrsOcyRCc2z
 RmZktXxHzttvbaJD3WH+d+8rzm/JCwUJm8qfjIfQE0O5NyLiIM8lBXUVf54DbW4yNbyHFnNL
 yui9XZkwe9J1IhSivv9rQuvby+QSobhTQ8Z5ELyRzKc70BFPLeiOc/y93P7xKMVRGqGdWWps
 H8BksmYyekBC5CRiSCAKNkw8KGVC+Wta2OF3wM2d3U133H0oiP4I9gMiN1rDB0xWvvobwMFd
 6M6Vel5wJZIdEWnYqZsC25aI5R7lPOwfTgJux29UzavXnSTXFLflM2NTRTJt4wIrKTLuftiU
 ap3ie72UR4n5V1PlVJavds1374x3TwZzmjOX539xBnP+ePAOSfMEe1caQDUN71RAEa4TOP9q
 oc32yyikUg3bQEDSnOPrd57wa4icBDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/89qws8x
 VnkAhUw4AOm3RXvcFzaAlg+OOKHdcsu9hoTYH1zVWtELlB+OO5DGo9ELMBpFVTmncQ+pcNJo
 w4tJpvQX6wTGmiWk9nfBLGkxLFfmN2QrVrmF0KYjPIXJfaMmyShFgfYQzbS
IronPort-HdrOrdr: A9a23:zIVIUqufc9P9oT/BPGUUDlj47skDTtV00zEX/kB9WHVpmszxra
 GTddAgpHjJYVEqKRcdcLG7Sc29qBznmaKdjbN/AV7mZniehILKFvAG0WKB+UyCJ8SWzIc0vs
 0MT0E9MqyTMbETt7eD3ODSKbYdKbe8npyVuQ==
X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; 
   d="scan'208";a="70254362"
Date: Fri, 29 Apr 2022 14:27:19 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v10 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <Ymvnt0mVPSAXrppS@perard.uk.xensource.com>
References: <20220413112111.30675-1-jane.malalane@citrix.com>
 <20220413112111.30675-3-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220413112111.30675-3-jane.malalane@citrix.com>

On Wed, Apr 13, 2022 at 12:21:11PM +0100, Jane Malalane wrote:
> Introduce a new per-domain creation x86 specific flag to
> select whether hardware assisted virtualization should be used for
> x{2}APIC.
> 
> A per-domain option is added to xl in order to select the usage of
> x{2}APIC hardware assisted virtualization, as well as a global
> configuration option.
> 
> Having all APIC interaction exit to Xen for emulation is slow and can
> induce much overhead. Hardware can speed up x{2}APIC by decoding the
> APIC access and providing a VM exit with a more specific exit reason
> than a regular EPT fault or by altogether avoiding a VM exit.
> 
> On the other hand, being able to disable x{2}APIC hardware assisted
> virtualization can be useful for testing and debugging purposes.
> 
> Note:
> 
> - vmx_install_vlapic_mapping doesn't require modifications regardless
> of whether the guest has "Virtualize APIC accesses" enabled or not,
> i.e., setting the APIC_ACCESS_ADDR VMCS field is fine so long as
> virtualize_apic_accesses is supported by the CPU.
> 
> - Both per-domain and global assisted_x{2}apic options are not part of
> the migration stream, unless explicitly set in the respective
> configuration files. Default settings of assisted_x{2}apic done
> internally by the toolstack, based on host capabilities at create
> time, are not migrated.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> Reviewed-by: "Roger Pau Monn�" <roger.pau@citrix.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> # tools

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:32:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:32:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317321.536598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQjI-0005PW-Ou; Fri, 29 Apr 2022 13:32:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317321.536598; Fri, 29 Apr 2022 13:32:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQjI-0005PP-Ln; Fri, 29 Apr 2022 13:32:16 +0000
Received: by outflank-mailman (input) for mailman id 317321;
 Fri, 29 Apr 2022 13:32:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H4Mb=VH=citrix.com=prvs=111705440=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nkQjH-0005PJ-8K
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:32:15 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c66a7ce0-c7c0-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 15:32:13 +0200 (CEST)
Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 09:32:10 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CO3PR03MB6726.namprd03.prod.outlook.com (2603:10b6:303:17d::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 13:32:08 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 13:32:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c66a7ce0-c7c0-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651239133;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=PQCU5W/XQD8n875J67ZnsOMiXLk2xOSxnSLeiIlvM8c=;
  b=cqVFEFQz1v0EH9sSENb4QGo1se2X0QeORnXZaUyrC4UDnZ5F9aICRlCu
   l82gtWH1yG4FY7tHHk2ts/4yi1oRtb+qeaB/qU9/wXa48pjplUFz7af7N
   MXYuvijWCayZ+nPmOY7jtg+cBkXfUTbkv2IwWN0CQmdqotJCbiNH4xGFN
   g=;
X-IronPort-RemoteIP: 104.47.57.174
X-IronPort-MID: 72697748
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:mmXQv6OBAx8EUKPvrR2qlsFynXyQoLVcMsEvi/4bfWQNrUoi0DdVn
 WcfCz2EOvqKZzeme4x0Od6+8UMFv5eEz4AwHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZl2N8w2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1
 vtkk8eMTSoQF6Ts2+4WEAFiKj17BPgTkFPHCSDXXc276WTjKiKp79AwSUY8MMsf5/p9BnxI+
 boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HtaaHPmiCdxwhV/cguhnG/rEa
 tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2IC9gPK+vZni4TV5BRJ/J7pbfvWRoK1XsRfoUexr
 Fzg23usV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVQBmQsHOC+BkGVLJ4H/Mg4QuAzoLf6gCFD2JCSDNdAOHKr+czTD0uk
 1OMwdXgAGU2tKXPEC3BsLCJsTm1JC4Za3cYYjMJRhcE5N+lp5wvihXITZBoF6vdYsDJJAwcC
 gui9EAW74j/R+ZQv0ln1TgrWw6Rm6U=
IronPort-HdrOrdr: A9a23:+JDPBaj/CNL4jMOlhxpnTdtdxXBQX4p23DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bsYOCUghrTEGgE1/qt/9SAIVyzygc578
 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3sZxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu
 v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gosKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJriJGofy+Qzdktvfr2rCo+
 O85SvI+P4Dsk85S1vF5ScFHTOQiArGpUWSkmNwykGT3PARDAhKd/apw7gpMicxonBQwu2Vms
 hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfRsRKEkjQpo+a07bWrHAUEcYZ
 xTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYEit2ZF8Ih4R4hP5u
 zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tTKyaRw4PvvdI0DzZM0lp
 iEWFREtXQqc0arEsGK1I0jyGG6fI3wNg6duP22J6IJzYEUaICbQRFrEmpe4vdIi89vcfHzSr
 K0JI9cBePlIC/nBZtJtjeOL6VvFQ==
X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; 
   d="scan'208";a="72697748"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lMjgqo9j6ct2ng95QjtdKQ26crI4AJNKY9O8iWjIMm76SoK5DZTk4+Yz3MilNY9My6WGOEarukvuXA8xHaIRO5hbaDpjC/AH0Ijwdav4O/KviYsYREkI3KAOzul6QQgCUP7xWFHEzPpMBDIBeBqbEXqm0oASkiFXkjS8JLZhntWZNPC2Xmi6u6SImndw0nu6deIGxCba8lZg5ZJuZh48GIJ0p+3IVRBTc4DQoF4UDpZzJg9HFryxIRQb/nFuPpftStO75xqhKJe4NqIjSybvq2Zo+Rlhe60qXnyMjAqSlglbsSLWnuD/KoYQZFQhg7jXOAx2yCo6yGHmKCfYwIF4sQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PQCU5W/XQD8n875J67ZnsOMiXLk2xOSxnSLeiIlvM8c=;
 b=AY4GUapjOc6+eiUE1meabYSKsPdYNctGDsr1zW2D1NitO6quRxz3jbJRITSvMxUnVzt9Gxmz/lZliqVwn/kx6srUtLlDPLinbUZzht2ph/vM9cYmqMDb4Xm/yGSLxeE8DTcmETRwhPwsa3G3gUgsF5Rs4FdCzJhsQhhpLBALsVEdf0gURQRqJcl+h5l+YHEd/gkhX/aglv6a6fGblu+872AqE8EiCr69KQX94is0T4Rodt8SRIGGVIbUc/t6PJVSINIESlg6mSZaIcw12qEl12CPIjYprdDikyE/2QmWsc9yyJZyCQ/v+V0HgZz3l/0JnDTwu2rNS0yZYZ6jBBXApw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PQCU5W/XQD8n875J67ZnsOMiXLk2xOSxnSLeiIlvM8c=;
 b=u3MncwH0dhpI1z1lXKqM/aXPyLU1F8C51Xu1Fsu1LUjxVSDH3HF/Tqrf3lnA/w9zmEU4b7Bw0vHusZNdaKD2rJuAdhgbRqdwOdZR1UIq6GQ8ZoLIXQ9AzSRVI/MRk1XTo6hsVT8OfUbdS7EzBO1Xm+Nws3OVvV0mzeWGO5/unyg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, David Vrabel
	<dvrabel@cantab.net>
Subject: Re: [PATCH] x86/mm: slightly relax TLB-flush-local check again
Thread-Topic: [PATCH] x86/mm: slightly relax TLB-flush-local check again
Thread-Index: AQHYW8v8fFOL6ISSr0eHNQGjo+Jqyq0G43KA
Date: Fri, 29 Apr 2022 13:32:08 +0000
Message-ID: <2e0c3b57-5117-e222-587a-b2261101bf58@citrix.com>
References: <ad64e3c6-9f89-c0ea-05a9-cff995ac200f@suse.com>
In-Reply-To: <ad64e3c6-9f89-c0ea-05a9-cff995ac200f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0a71c73c-186b-408a-6600-08da29e4a890
x-ms-traffictypediagnostic: CO3PR03MB6726:EE_
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
 <CO3PR03MB6726F4BB4955B716AFD5062EBAFC9@CO3PR03MB6726.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 ZNfDIwlb5fOwljlwX6fSd1HM56bdeYnIJPlQVHdSS5JgG4rxtgvRAd1va1wNMC8ZiwDZB1RDfHDbxprb2cyVA7qgTsY8Tc2v8U5gst9IRu6fxpRy/bxITrJEkNXZGIILXU3BW00e+TpR5drCrlJvF5b1zHlwhS1yOvrNyu+5UaUNey4QfQ5OHx/Fjn+146Zq8QjpfT/CnGOCKBHAE8nutE/bYDQp/O1+qBY4lydrsRp1JrJ+lqyfFr8MMB772Im20LOMtEczmXTuKaeSAvxfGSzs1VxSQo18ODNNIKW1rPUBUb0r2hP7CirXIf3TjI8YEUo9KGi0fBaZ6EfWmr9LjQoMb7btXKNMqVXRgDZCqOdZp6dMydLcWTS5ZSngln0xLKySuTKNkLjGuFC/OHdVhe99yLEpXaBKWWv6zgcP2Da8SnwOmfEj+NpNnK4Q6F1ii1d8ofBfCkl4ty62XN9S4IukivrfsoEQsgETyMKG8s7x1RDfC5sVvb/LGGUWCz3YLUDk/ZXKGNoJdAlO82jwkgPnoYJ14EXXSf+q25UiPVBiqO8XgG0LlmPRtkNJLiyuyWyvl1IuWFYzwYviNtkRepYScN5vN1QUUzqSROy3LSY30zwBKbu6DXEyKOTNPOQVxdGp5bkDqKmt1cHPXIIJlEWpHmXP4kci+MQ6CR/WOqaEQCPPeHTXy3heFte/SGCyn5fyKUboCQ3ZXlyTAXR697cwxen2v4oBACO69n1GrhAN6AET1CH3muRWZ4p4kbBsMh9X7MTcU2m5g+EBI0wA3A==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(66556008)(36756003)(5660300002)(2906002)(76116006)(66946007)(91956017)(66476007)(316002)(4326008)(66446008)(83380400001)(8676002)(64756008)(8936002)(54906003)(31686004)(110136005)(2616005)(31696002)(71200400001)(6486002)(86362001)(508600001)(38070700005)(82960400001)(38100700002)(26005)(122000001)(53546011)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?TFdEUHR6c21aZzV5VFAxRjFJTlpDenZqaW9WWmU1dGttUDRJdEJpZDFiUmEw?=
 =?utf-8?B?KytldFlJd21zcXZSQVlSUFBLbVRpNlZqejR2ZGt3ODdRcUtlQ1lzUWdoS1pv?=
 =?utf-8?B?MVEwdE9GN2VXTlMzazg1YWJ2TmIwVG1nbnluK2tZdWxtUEdBZEVZWWQ2alMx?=
 =?utf-8?B?ekdnWnd4dy82MkhYUEROTXVaT0xzbFVXaG1wQ2RKWEFacW04a2VVVW8xSGJC?=
 =?utf-8?B?bFJzdzNIUnFxczB3dHcvc2IrcU5xNENGdHhlMW5qb3FVcWt1TG16QkdUZG1H?=
 =?utf-8?B?MWlGOHBzQWlzYkNkREtiaFdJMXlUbzNPcmdRMDE4eVVlejVETzVnd3R5QkhL?=
 =?utf-8?B?eWpDYWdGcVJFQy9lNFJmSjRrb2R1KzFEY1VlR1ViaUFpNTh6ZnFibXNCb2R0?=
 =?utf-8?B?b0dkTkpTdGtTTVZMNkxqeXBVOTJqbHBkRU1FaWV6YUMyUDNRb1M1NTlpV0FT?=
 =?utf-8?B?SU5adlpZWGw4YzkwZ0ZWLzk4YSt4bSs4OHZwYjU2akhjNmJhQVhtdExxL0ht?=
 =?utf-8?B?U092c2RaV0ZpTHg1UkVpQXB5TjhURmRmUk5QSCtmVVp2a0tOdjF1N0E1Nnkw?=
 =?utf-8?B?R2tLMVJDNG1wUDJoaFFjRDVqd2FQWjlBMVVzN3g5SnhZdTNRTG9vQjNZUm9V?=
 =?utf-8?B?c0ZkODJkZW1qeTY3ZHNzS2xxckJra3NzU2JoM3VHdTJJd2Rvd0pkczRLTlY1?=
 =?utf-8?B?T0h1ODV6elVYMmkxcVRyaWdOa3c0M1JLK0RFRmM5Y1hqRng2c2hSVHJlV2Vp?=
 =?utf-8?B?SndSOGI4cUw0N0hudGg4b1psUE5Ebkg4S3U3K2xNZUdCZStsWmxscVdiTHZ4?=
 =?utf-8?B?R1lGQ0Z2M0hIbUlJVEN4bU9hZllDZGtxU0o0MFpNWlJyVElHL215eW51KzJB?=
 =?utf-8?B?V1JNdjVuODNZSVEySGFsS2wxWU9xeXlIOGI1eSs1R1NydXUrMGRIOXJpdmtP?=
 =?utf-8?B?ZDNmdU0yZEJDdllyT1E2WEp3bndHdGVzQTYxdkErNm1ReEk2ZFQvYWdKZ21n?=
 =?utf-8?B?R2s5bXVpVGxOYUpuRjU5Q0J5bGNTcGFWRWFhSk1kaDArNHpZYUQvM1RTUVpm?=
 =?utf-8?B?ckNTaDVSc0xTUVFGUVpTZjJzcGx0ODV3T2UrNHZjNnBxZXYwb0R4bUJZdDdT?=
 =?utf-8?B?elE0aGVRNk5oMDJyc2VIQ2hzVkFhYUp5UTRWQ3daVnpkL20wL1ozMis1dFlP?=
 =?utf-8?B?TnMvWG5SSjFoU1Z3bGdITkE5a0RSbzRBYjkySkw1dUEwSVJWb29VaGF2RGth?=
 =?utf-8?B?d1dzcjVsZU5FWGNNVDk3NG5vV0h4SytaNFFTNVloZGtLazdxVFJwUytjSXU3?=
 =?utf-8?B?aEFUMkFVNEhlVVNXcHB2Q1Z2QlVCSTBtMHNtVG1ib2duZG5GTk9uV25UMTRx?=
 =?utf-8?B?TGJ1U1dIT2M1U21SMVhNTmw3Sm5GbkpvVmgrNzdiSUdHb0ZIRmpCSTJmL3lF?=
 =?utf-8?B?OTJSdmRlb3JJcGZiemhuR3VvNUt3bG5BWENTU3kwZzMyeFlreXA5NGpXTGFT?=
 =?utf-8?B?dVE4S2xYeVJ6bTVHSk9mS2pXQWNhUXdRUjIyN2oxUXFvMzdMUHBKdjQwenFi?=
 =?utf-8?B?V1gxR3FWeW1oQnVib2NaVG5YN1MzZzFnYjFHR2hXd2htTk1lRnNONXRSUkpk?=
 =?utf-8?B?U2ZFQ1FJSDlRZlF1U2lzdU0raVhob1Vaall2cTY0SHJ1VGIyNWtUMDdoU29T?=
 =?utf-8?B?ZkFteDlJTUZQbUNKZVJNZnhJdkZwNTQxa09RS0FkUFMwQ1o2TXFhSURYQ2ly?=
 =?utf-8?B?MWludjl2L0N1WHg0SzFDTTFDWElrd3pDT2lSUm9MT2pTYXZKdUdKYmlYMVNL?=
 =?utf-8?B?cDJ6SUdmWWFhSWZXVFRqRi9hcEhPT0EwSjlCOElHWGw5eHVkYVhDOXRmQXJE?=
 =?utf-8?B?UWZHbWI1ZXM4RTRkblUwbzcycmQxYWVtTWttMVplWWVtcGZnOU1RM3RKT2Vz?=
 =?utf-8?B?aGp2WXRBZFdPRENQT1ZyV1lLdDRlSmlIVTIzczBrbHdxcU9ydHJ5QWtSVjVy?=
 =?utf-8?B?V2xUbXc2eUplVlNGbndWWG5ic0VTaGhjSXZxdi95akdQZ28wRzBZRUJzczZ2?=
 =?utf-8?B?Z0swaHlhQXF5eHgrb05neDBuK1crbzVUbkpKejllOG5RZEllR3ZjRnJ4d3JQ?=
 =?utf-8?B?dURFdk43ZW9ydDBIV3c1Vkt1QTdZTUt4d2pVM0plbFFtK3RKVEcrMDNWN2pZ?=
 =?utf-8?B?Y1BuV0t4cFlHbS9HN1RNTWdGNUtna1dLZ25yeC9UV0UyTklVNElucTR1YUhZ?=
 =?utf-8?B?UWpuYStMUis4NDIyZ2xHOEJmaExRMjlKSHIrNHNkUFZDU3ZuYWpNcGJueGhU?=
 =?utf-8?B?dVlpVDkveXcvdGcwQklKWDloZGdWTGtkZkJ5dEtLaFZEdHVmbzRqWVI3V1My?=
 =?utf-8?Q?PWUthlhz6YDi3acM=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D62D6A42CA45824788E5466E75D4FFB5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a71c73c-186b-408a-6600-08da29e4a890
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 13:32:08.3351
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YsW1TtSzAOMo1VXlH88avSqtrWP7wUJT+tML75jF71POzJxj7OoAtmjWztFsfixfoz52IwM3aN2SJxep2gfLm56tLQ5JiTzLa9hwhkCpDYE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6726

T24gMjkvMDQvMjAyMiAxNDoyMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IHN5c3RlbV9zdGF0ZSBj
aGFuZ2VzIHRvIFNZU19TVEFURV9zbXBfYm9vdCBiZWZvcmUgYWx0ZXJuYXRpdmVfYnJhbmNoZXMo
KQ0KPiBpcyBpbnZva2VkLCB5ZXQgdGhhdCBmdW5jdGlvbiwgd2l0aCBDRVQtU1MgZW5hYmxlZCwg
bmVlZHMgdG8gaW52b2tlDQo+IG1vZGlmeV94ZW5fbWFwcGluZ3MoKS4gQ29udmVydCB0byBjaGVj
ayBmb3IgdGhlIG51bWJlciBvZiBvbmxpbmUgQ1BVcywNCj4ganVzdCBsaWtlIHdhcyBkb25lIGFs
c28gaW4gODhhMDM3ZTJjZmUxIC8gZmE2ZGMwODc5ZmZkICgicGFnZV9hbGxvYzoNCj4gYXNzZXJ0
IElSUXMgYXJlIGVuYWJsZWQgaW4gaGVhcCBhbGxvYy9mcmVlIiwgYm90aCBpbnN0YW5jZSBvZiB3
aGljaA0KPiBuZWVkZWQgcmV2ZXJ0aW5nIGZvciBvdGhlciByZWFzb25zKS4NCj4NCj4gRml4ZXM6
IDc4ZTA3MmJjMzc1MCAoIng4Ni9tbTogYXZvaWQgaW5hZHZlcnRlbnRseSBkZWdyYWRpbmcgYSBU
TEIgZmx1c2ggdG8gbG9jYWwgb25seSIpDQo+IFJlcG9ydGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxh
bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8
amJldWxpY2hAc3VzZS5jb20+DQo+IC0tLQ0KPiBPbmx5IGJ1aWxkLXRlc3RlZCwgYXMgSSBkb24n
dCBoYXZlIHN1aXRhYmxlIGhhcmR3YXJlIGF0IGhhbmQuDQoNCkknbGwgZ2l2ZSBpdCBhIHRlc3Qg
aW4ganVzdCBhIG1vbWVudCwgYW5kIHdoaWxlIHNlbWFudGljYWxseSBJIHRoaW5rDQppdCdzIHBy
b2JhYmx5IHJpZ2h0LCBJIGRvbid0IHRoaW5rIHdlIHdhbnQgdG8gZXhwcmVzcyB0aGUgbG9naWMg
bGlrZSB0aGlzLg0KDQpudW1fb25saW5lX2NwdXMoKSBpcyBjcHVtYXNrX3dlaWdodCgmY3B1X29u
bGluZV9tYXApIGJlaGluZCB0aGUgc2NlbmVzDQp3aGljaCBpcyBvYm5veGlvdXNseSBleHBlbnNp
dmUgZm9yIHdoYXQgd2Ugd2FudC4NCg0KRm9yIGNhc2VzIHdoZXJlIHdlIGNhcmUganVzdCBhYm91
dCBVUCB2cyBTTVAtbmVzcywgY2FuJ3Qgd2UganVzdCBoYXZlIGFuDQpib29sIHdoaWNoIGlzIHJl
LWV2YWx1YXRlZCBlYWNoIHRpbWUgd2UgdGFrZSBhIENQVSBvbmxpbmUvb2ZmbGluZT/CoCBUaGF0
DQpzaG91bGQgYmUgZmFyIGxvd2VyIG92ZXJoZWFkLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:38:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:38:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317329.536609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQp5-00067Z-HC; Fri, 29 Apr 2022 13:38:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317329.536609; Fri, 29 Apr 2022 13:38:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQp5-00067S-EO; Fri, 29 Apr 2022 13:38:15 +0000
Received: by outflank-mailman (input) for mailman id 317329;
 Fri, 29 Apr 2022 13:38:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iTs9=VH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nkQp4-00067M-Ej
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:38:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9db34165-c7c1-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 15:38:13 +0200 (CEST)
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03lp2172.outbound.protection.outlook.com [104.47.51.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-OFwDRiO0M3GtGmiGOlPZpA-1; Fri, 29 Apr 2022 15:38:11 +0200
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16)
 by AM6PR04MB5400.eurprd04.prod.outlook.com (2603:10a6:20b:9d::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 13:38:09 +0000
Received: from DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com
 ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022
 13:38:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9db34165-c7c1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651239492;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MonGnlx51ZfJ/X86MVmN17LvmvRMBIkCORuGQAAP7+w=;
	b=Dj7PjQ991VoYfZgR68sGv0JmSFCZiJRt1sp/jkncYHnAYfRfoFqvjdQIUyW+Fc8PIIhNEF
	HArgMEL8GWY+eEJ8W8SAJprtASNaFqGVjitG53jj9mRfq9l8RFLGr0gsnxGbdd7hHNl73I
	90+K2zcTmYGVsxBxZjcgAF/zi4rCI/I=
X-MC-Unique: OFwDRiO0M3GtGmiGOlPZpA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aw1dc7VUzKQxZjMAxGuA3clnUxdEDK6NILKtfxCFHVqHg82L9U7rRbPjtpLrVuqF3yrcLTV+ODjkQwHR51L1MgCBh3u/yLEirfsKhu8PBMpFD/W9kekEvgT/CcNjwnNZzKy36vS7YoN1JgSlrbYKqMhcEaiuzlP93ml8+LZkhtYzL1gc3dPbYcS1HjSbo+J0hV8uJ87MOg3iLOzHSe4GQcJgT8MnSB0GgB4jMiaKhuykAg2Px0bdyqfqCkynsbn8qUjPLJqIwrRR5GLseotbmyCpaKL7BrGs3WnG6JgUWtiSzImBQJRtob+FY+O2XVuyNb244zzMhkXy3yGL3DBZJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ASbVOOqJ46tYjj2FWN5KqziuUCuTnjB+Pfz6dFMuL9o=;
 b=dq2Lq5/wIshBndVTKideIdeSvkyRT3zIQRYiiUJg5SNAKdWpzMVthUHhoark3refqt3y6Me7VFWNv+IPb7SqCpcaoEqUGiXx/allwxVsBlTXnFJsjiLYS6R9somwnqC9dtDVDejM7DqFzF7psPau0DIY7YWuFcezP1QpIstz3LgJKSJoLKIwOJ8TKH+K69AMKaKoMsrvjIWcTKARkVXpIT87nvsjaYJvgdZdOqj4Za7WF0Cbp5rmGoRayjjFr0IuqTcVlmHoE5y0iofRNNRHh3KH9FY3vGHaY17MHqcyEMOUuC1AjTc1aHfNMsTeKOjJ5zYK1Qf+7qLs/GUrto5Srg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <21005eb6-0520-a09f-662e-d893ebd9d964@suse.com>
Date: Fri, 29 Apr 2022 15:38:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86/mm: slightly relax TLB-flush-local check again
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 David Vrabel <dvrabel@cantab.net>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <ad64e3c6-9f89-c0ea-05a9-cff995ac200f@suse.com>
 <2e0c3b57-5117-e222-587a-b2261101bf58@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2e0c3b57-5117-e222-587a-b2261101bf58@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0412.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::6) To DU2PR04MB8616.eurprd04.prod.outlook.com
 (2603:10a6:10:2db::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0c9a30dc-067a-4767-18f9-08da29e57fe0
X-MS-TrafficTypeDiagnostic: AM6PR04MB5400:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB54001042FECB23667D166739B3FC9@AM6PR04MB5400.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gCjBwzFpBWwyq2aSI8E1+sKCkeXNhb750Nb0pOOH7vMlt6LXn3J1UdjWnpXpXN7fpGm5dAaYTO7xcf9iKI/wcBB55xh6VSMZqv55WGmTYilwx+NKh3NKsxBMm12fKJuiyTU7z5n8PYMSaW+Y6+QRzGFa+l5u578Tm5deezyf9l4p4vcxfhBIUiJvyGcJA1ZIljzAhsh9eRByG3jiS9jsF6muznCVACqofcjERlS1UWVUUzdCjiKF3CSgwk9TGnmjlFl4VlYcoI+vD6Hw/CxgHN2YnrCIcEkzjEmuo8xN3o9QmHCQqyVVrByBoI9B5czqJw9SEdfQoRAtHdEnQ8+M/VwiZBWN48PT8Vmw0UCtMYa9llcmy5VGnawmEL3GAGhk1/TZTAyZqDoTMNazpQKXhIDSmY4amm3GSXZS+Er7uKdaUI/iMr5ImzQ7nqWj9bx55zYibJd4+uYqE+pOE/f9XlU64gZQ3mA5c/8RJuRiJcfiFT8OipV1VXFpE+FyUHxe7OQazdr3+em7ZMKDQGwZWo6GsXK3Jk4AV3rrBY3BtuDhjjJPwUmRD9M5dKiUi9/Ufu56H4GxChaKXcNx1uBlM0MYQeSSsK5TBeQiv+bZB+cidc1Wefy4nsOaf3p0ITr8DJe9ApdkZ8IbIq6tJPJX14Gl+oxrPaMdFagOm/1eFjiH+2vSG5eMDWGYZ0BzUQBaNStALQ/fRmQKLhJW28wJTbdVPTAgufAyqT7eR/CYIfQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(6486002)(54906003)(6916009)(86362001)(6512007)(66946007)(66476007)(66556008)(8676002)(31696002)(4326008)(26005)(508600001)(36756003)(83380400001)(5660300002)(316002)(38100700002)(2906002)(8936002)(186003)(53546011)(31686004)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rM5/Q0Xh60uheW688aJr4r8nkOTM7sOrPCwNR6CJrWZonSiiQIPW0Hatg60+?=
 =?us-ascii?Q?Rvs5prIDQ/gFxtIPC3/ai+ynQf9sJTVWtNL0JoFNTbF09bdoV0IOQyCIP2eg?=
 =?us-ascii?Q?jN2Wji0FCQi9phClDVLrXE48qcIriQ6kWBbEmQ3Bkpm94suNrJAmiT+b3GBX?=
 =?us-ascii?Q?uGt0YefKuDrg+hbS/dvRxc3+B3/5+4b8uH/Jnn3XykrQTCJMRE3JpQ3IOryn?=
 =?us-ascii?Q?x/v/iYhFqfTmgFESbMhfGQrmAC94zo//AFBFMECWn1fMsjAKa5aESEm9TwHP?=
 =?us-ascii?Q?5U0QKrVPHhgpKBVc4KkWOmBawrIlJzAjLbZbv4f7wxk4MjBWD8LsPsqIKVAe?=
 =?us-ascii?Q?YaXagdvWKXrfx80cOkskQIQgW3Xdw8LXnCoFY429LW9lONK6W7QBJGhd2s4j?=
 =?us-ascii?Q?14CQGLutIoaHvTRt5lf/pGruuMmPJekOTIG6oWMiy09TqxSL4y817FPKFrmN?=
 =?us-ascii?Q?Bp5TCOpGVNFasgt+ZYD5kDf5EkBmVZkuDbK2sS3F3eaEziS0SYAMPk/mQe3X?=
 =?us-ascii?Q?C/a0x/rg4FG1/WlEsqvtOH2eXkr+SwDn3aR23ZO7hPyC7MPWWj+ftTRSAtII?=
 =?us-ascii?Q?4nHv8VrlKFCkcyDa3F6N5GVN1ojF2LNd9T0h8fMcSmmH5N2D7PjC1F5vQV5g?=
 =?us-ascii?Q?X1pM3RsRhnrrkGGikUZL/VNUwICVd/868sGYNLVLH0shDF0zsH+tHLpM4Tja?=
 =?us-ascii?Q?I0aoS0rhzTwbgk79lDY5GQLcXhlEVQ9qanO27qyfu2O5/WN4ESaGHcqAJPXB?=
 =?us-ascii?Q?6n4XwmcGjllSdLggC10eZbH/pZl+QSWrFSq2uB0QXRs+LiPKXoDbQ8JeUQRC?=
 =?us-ascii?Q?bO9sr3sYDAiLAdOQLaknOvg3pGsjDu6wdkoPYSuuV6jnJDyGzQyOSzLwxOLF?=
 =?us-ascii?Q?Ap8kxjKBIBc7eruKY8Z+X60Bv5zAgjc34tNfWy+qWG1aQEKr7rX4fec6ncTf?=
 =?us-ascii?Q?RF1joMNAWu+NrA+bOzGdSOM18zL4/OT88XxRKz/5DZ5VfBcT/YcfDIQNdHH4?=
 =?us-ascii?Q?oT5f4n2ds5DV9oGHY5Q4YuOiADdzcly8pgwF6QOugwFG5TafpA1XarLofMBS?=
 =?us-ascii?Q?eiEtaAi6ItjFS1aZOtPpjHwFROgip6ALt0HAeF7zFMtsrYXnRrtuYQFZj8GR?=
 =?us-ascii?Q?56t+nvD1FbSbr6Tj6mOJ/2DHakrQnbWA81Pfs8JWxLLd1JE/YWI0diCY6rJj?=
 =?us-ascii?Q?kJZd4tQKCYm06GNMgIgAHyHM8GAx6WkVIiMcfzTpe2CN0qTpUf3YoOEQAxFf?=
 =?us-ascii?Q?Q1Qp14wL1SeDTebfgKdXN9wPBNqfalwJ62+gmmaaLU3aC0uTlVoJ0cCrpBCr?=
 =?us-ascii?Q?a5yKjUbEN+UYMukQicr7KyGboOB3iJl/3jsfUikqh7tXRuV+OjnKFQ2oeGKT?=
 =?us-ascii?Q?w5Lfhjgcj3UY1IpTFn/2NZ0Mju3F+7mwMJMIX+zrx587oz+qbiXEOKjenGIO?=
 =?us-ascii?Q?tIfP08/4fF9jMYut3RW1B9da8zLkWupP9YVRtX9hJxEcFfIKzl9QgvaWEoCV?=
 =?us-ascii?Q?hnyRACjnXAGRAs+RC8Fd5IbDykGKq1cgcTT04bisgBJHRDBpLsj0f/Y+eU2f?=
 =?us-ascii?Q?7ndVvEecbReNfYG8+U15oNXVMrKphtHQIZWNDWZPtifKn7GbDz4dEP1+jKxU?=
 =?us-ascii?Q?PkwXYjqFlvCAXHB4dVV62O1ktjCwstA5IEAu8E5psMieWdyRjsxiDq31PNnq?=
 =?us-ascii?Q?f+qZ3ZAyIguKC1JxrBH0WsCDW5iAucQ/DCdgZnIeHumttaofMJt+z7IdCBRq?=
 =?us-ascii?Q?l+DNYVsuyw=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c9a30dc-067a-4767-18f9-08da29e57fe0
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 13:38:09.6926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +PETu9AioAHja80wWlwXNNHeSGwD6y0CR2E+T67+m1VO8VA5H/hqT+yu9KeHgzfKKkChqAB7pCASErr7LzFs0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5400

On 29.04.2022 15:32, Andrew Cooper wrote:
> On 29/04/2022 14:20, Jan Beulich wrote:
>> system_state changes to SYS_STATE_smp_boot before alternative_branches()
>> is invoked, yet that function, with CET-SS enabled, needs to invoke
>> modify_xen_mappings(). Convert to check for the number of online CPUs,
>> just like was done also in 88a037e2cfe1 / fa6dc0879ffd ("page_alloc:
>> assert IRQs are enabled in heap alloc/free", both instance of which
>> needed reverting for other reasons).
>>
>> Fixes: 78e072bc3750 ("x86/mm: avoid inadvertently degrading a TLB flush =
to local only")
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Only build-tested, as I don't have suitable hardware at hand.
>=20
> I'll give it a test in just a moment, and while semantically I think
> it's probably right, I don't think we want to express the logic like this=
.
>=20
> num_online_cpus() is cpumask_weight(&cpu_online_map) behind the scenes
> which is obnoxiously expensive for what we want.
>=20
> For cases where we care just about UP vs SMP-ness, can't we just have an
> bool which is re-evaluated each time we take a CPU online/offline?=C2=A0 =
That
> should be far lower overhead.

Perhaps, but then I'd immediately ask: Why boolean? We could then as well
have a variable holding the count, such that num_online_cpus() wouldn't
need to invoke cpumask_weight() anymore at all.

In any event I view this as an orthogonal change. It's not entirely without
risk, as all updates to cpu_online_map would now also need to update the
variable. There shouldn't be too many right now; my main concern would be
with future additions.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:48:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:48:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317353.536635 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQyT-0007mJ-Jj; Fri, 29 Apr 2022 13:47:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317353.536635; Fri, 29 Apr 2022 13:47:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkQyT-0007mC-GZ; Fri, 29 Apr 2022 13:47:57 +0000
Received: by outflank-mailman (input) for mailman id 317353;
 Fri, 29 Apr 2022 13:47:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkQyP-0007m6-B4
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:47:56 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f5daac61-c7c2-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 15:47:51 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkQxe-0007JF-GW; Fri, 29 Apr 2022 15:47:06 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5daac61-c7c2-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=C2OEpCl3NbPTnDM8xzX2S4IX9JfHaO7AlvKh6b2mc6o=; b=pqe8NQsff608mhiYOzk5PDnm3n
	SqpJEt2cMOf7fKd9x6EBmHDeHOX5PyCqZaiQd+rsoiJqYRJfq3hy0YC1K+f5G6E1EYGyBkHkky/4o
	A4sr1jLh/ZiZsTRb8VvM35RQhf4WjzvO8x5RrxtfBf8C8C5PVdUgz7Ik51+zFewe+U63oi8LhMtjA
	jsMfNQ3e75qfSDrR+BCOQg4pDZsV5C5nFo1cAeFeQ7vSqL72QRCGkkh8ptmyZp43zUawgc2bKvA+V
	5dpGhl6WFgQXUob6WnQm5VHnfuqrvgLJ/w/gTZOEZRu0JtLeyWnhBKRg4Xfo6FA1ZDb4qCsQBNlya
	WoHGALzQ==;
Message-ID: <832eecc5-9569-1d95-6ab8-f029b660dfcb@igalia.com>
Date: Fri, 29 Apr 2022 10:46:35 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
Content-Language: en-US
To: Steven Rostedt <rostedt@goodmis.org>,
 Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
 kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
 bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org,
 linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
 linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org,
 linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
 netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net,
 rcu@vger.kernel.org, sparclinux@vger.kernel.org,
 xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com,
 kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com,
 alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com,
 arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com,
 dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com,
 gregkh@linuxfoundation.org, mikelley@microsoft.com,
 hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de,
 keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org,
 mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org,
 senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de,
 vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-18-gpiccoli@igalia.com>
 <b8771b37-01f5-f50b-dbb3-9db4ee26e67e@gmail.com>
 <20220429092351.10bca4dd@gandalf.local.home>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <20220429092351.10bca4dd@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/04/2022 10:23, Steven Rostedt wrote:
> On Fri, 29 Apr 2022 12:22:44 +0300
> Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote:
> 
>>> +	switch (ev) {
>>> +	case DIE_OOPS:
>>> +		do_dump = 1;
>>> +		break;
>>> +	case PANIC_NOTIFIER:
>>> +		do_dump = 1;
>>> +		break;  
>>
>>    Why not:
>>
>> 	case DIE_OOPS:
>> 	case PANIC_NOTIFIER:
>> 		do_dump = 1;
>> 		break;
> 
> Agreed.
> 
> Other than that.
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve

Thanks Sergei and Steven, good idea! I thought about the switch change
you propose, but I confess I got a bit confused by the "fallthrough"
keyword - do I need to use it?

About the s/int/bool, for sure! Not sure why I didn't use bool at
first...heheh

Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:53:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:53:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317359.536646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkR3n-0000lH-6L; Fri, 29 Apr 2022 13:53:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317359.536646; Fri, 29 Apr 2022 13:53:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkR3n-0000lA-2K; Fri, 29 Apr 2022 13:53:27 +0000
Received: by outflank-mailman (input) for mailman id 317359;
 Fri, 29 Apr 2022 13:53:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=T5vS=VH=citrix.com=prvs=111d7c57d=christian.lindig@srs-se1.protection.inumbo.net>)
 id 1nkR3l-0000l4-75
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:53:25 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bbb8ffd8-c7c3-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 15:53:23 +0200 (CEST)
Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 09:53:20 -0400
Received: from MW4PR03MB6539.namprd03.prod.outlook.com (2603:10b6:303:126::9)
 by MN2PR03MB4880.namprd03.prod.outlook.com (2603:10b6:208:107::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 29 Apr
 2022 13:53:18 +0000
Received: from MW4PR03MB6539.namprd03.prod.outlook.com
 ([fe80::d49d:81a4:d819:f0b7]) by MW4PR03MB6539.namprd03.prod.outlook.com
 ([fe80::d49d:81a4:d819:f0b7%7]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 13:53:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbb8ffd8-c7c3-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651240403;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=PPiJeAhnisUHiKxeeNNo+S5piX9KinYgaxBep2dSmZA=;
  b=THC2VMDRxQoot0ATGe9LTvOtbDKOEBt9D3I2docK3YpIr0LYGTKXRt/S
   zEDQrSE2cTvILLAiR1LfRlK5HukRa52na/6jvl/ldG1kwZerZyILUJUAy
   qdsYrz06BweQhROovv3JV8njZDcxt/xtq04ed9oTwk8L9aWG7l7ptumvE
   Q=;
X-IronPort-RemoteIP: 104.47.56.175
X-IronPort-MID: 70256599
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:W2IkB6yhmtB/D6fyRmd6t+fsxyrEfRIJ4+MujC+fZmUNrF6WrkUDz
 GIaCj2EM/iOa2v0edAiaITjoRkAu8XXnIRjHVA/riAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY024nhWGthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpllpbodCIMee73hstEcF4JFxFmNvx/weqSSZS/mZT7I0zuVVLJmqwrJ2ZveIoS96BwHH1E8
 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHeOTuoIwMDQY36iiGd7VZ
 9AYciZuZRKGZxxJNlYYIJk/gP2plj/0dDgwRFe9+vJtvjaOnV0ZPL7FCcLFPcaKdcNuvmGhp
 zLp32XBOBMVK4nKodaC2jf27gPVpgvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A
 1MQ0jojq+417kPDZtvyRRqju1afowURHdFXFoUS6guA167V6AaxHXUfQ3hKb9lOnM0rQT0n0
 HeZktWvAiZg2JWOUm6U/LqQqTK0OAAWIHUEaCtCShEKi/HvqZ8+pgjCRdFiFOiylNKdMQ/3x
 zeGvS0vnYI5hMQA17i41V3fijfqrZ/MJjPZ/S3SV2Ohqwh+PYisYtXx7UCBtKkdaoGEUlOGo
 X4I3dCE6/wDBo2MkyrLR/gRGLau5LCONzi0bUNTIqTNPg+FoxaLFb28KhkkTKu1Gq7ooQPUX
 XI=
IronPort-HdrOrdr: A9a23:Fk2l9KsYtoMUfNmXhQfRdwEt7skC9YMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJh5o6H5BEGBKUm9yXcH2/hrAV7CZnishILGFvAH0WKP+VPd8mjFh5dgPM
 RbAuJD4b/LfD9HZK/BiWHVfOrIguP3lpxA7t2urEuFODsaDp2ImD0JaDpzfHcWeCB2Qb4CUL
 aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlIawTjLqQntxK/xEhCe0BtbeShI260e/W
 /MlBG8zrm/ssu81gTX2wbonttrcZrau5V+7f63+4gowwbX+0WVjbFaKvy/VX4O0aOSAR0R4a
 PxSl8bTrlOAjXqDyyISFLWqnbd+Sdr4GTlzV+FhT/mu8L4SVsBerZ8rJMcfR3D50U6utZglK
 pNwmKCrpJSSQjNhSLn+rHzJmdXf2eP0A4feNQo/gtiuEolGcxshJ1a+FkQHIYLHSr85oxiGO
 5yDNvE7PITdV+BdXjWsmRm3dTpBx0Ib1+7a1lHvtbQ3yldnXh/wUddzMsDnm0Y/JZ4T5Vf/e
 zLPqlhibkLRM4LaqB2AvsHXKKMeyXwaAOJNHjXLUXsFakBNX6Io5nr4K8t7OXvY5AMxItaou
 W1bLqZjx9BR6vDM7z+4HQQyGGyfIyUZ0Wc9v1j
X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; 
   d="scan'208,217";a="70256599"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lUFt//iQEM9mi66Zhx55a8ppvUqGz2wnuRQruz1W6SDsYNVx5RIP+2/t+ZqlVkFP3WJ9vGTxUvFcKnFu/FMZ+OnegySDgVlsrGb778NHBcQTtIlseyMhjFxlYBSLu+JssJlcY94fvKsQMM/lVDicoXLUqP0zDAxftbxT7nhH28RwH49ot18GcqfVP1AH4ASxQR/dnKFuQ8buw/Bpm6yvXPch4W0CyB23891VoMAVL9ds+xYo+M2nDq/07sIYmH0Xey2UY5yPbhbTCvAqjsgSWFwANXTY3qgIY9EtNoLXQ263HY5agdAnueE1I2dMyll3aPOKj+gSWcJlRYk9UEPRmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PPiJeAhnisUHiKxeeNNo+S5piX9KinYgaxBep2dSmZA=;
 b=mfeja/x/RGdUi1Q0eGLXAI8dMMs0MYJR+y8cWmbJppu3iCm15kZAG+/VU8X+j6Xt5T19QgB6Pa7uuzp8DgQdDfmkvx9cVoEyfelVrhsuQHGpU27qYwU8ccqC5j2hL9y8H2PvOlZJdYBqhbMFHuWK3/6QKsKiaAx1a3YUuGSk5gQ1rjOzRP+rkTNgQ80BnJWtup4ZHzVqYDGU4pu/z5ryPFhrhL+mhmAuA9FjlnfZEKiWF4oU/fSRZkG1In9RTLnSYlS/Mh/E4/LOCjjJ0YeH+upeiR9EnEyrQcd76qJLOI1PS72dmRa7+FImxVee1YmPkPdTDA93uoB8v4zO7AXiIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PPiJeAhnisUHiKxeeNNo+S5piX9KinYgaxBep2dSmZA=;
 b=glzf7FXzpHVV97nvDeLOcej9/sJJpD9n5ReklxjjJxAcgtpMb1kd+9APzfie2SOpd9RHFyfE/TY0QHhkgeJI1mLoAzTPavEiwYoIhQ7bvdwuY+NXDytMb2Fu2ck/Osb984PNMFhpnq7+cuRAhIqcz1TTQm0g6ztvnRze2u5NrH8=
From: Christian Lindig <christian.lindig@citrix.com>
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>, George Dunlap <George.Dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, David Scott <dave@recoil.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v10 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH v10 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYTyjL38kQmqRZL0SL+QslP1pV6q0HAqQA
Date: Fri, 29 Apr 2022 13:53:18 +0000
Message-ID: <9C41A8D5-FE5F-4713-86F4-780EE20F9103@citrix.com>
References: <20220413112111.30675-1-jane.malalane@citrix.com>
 <20220413112111.30675-3-jane.malalane@citrix.com>
In-Reply-To: <20220413112111.30675-3-jane.malalane@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.7)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9cc7c2f3-2784-4ef3-669e-08da29e79d92
x-ms-traffictypediagnostic: MN2PR03MB4880:EE_
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
 <MN2PR03MB488023516C74E6943DD4B3A8F6FC9@MN2PR03MB4880.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 YI8DSINnUlerPYjF1yaZ8dvPNZs/m0lOv5G0EczMQ1myNiy62tkiBmfz+0uoAeMDgD60tts0Ok0WBTLZttUBbfxZ0tHqer6u/yDpGtS2X9cuxDTapnh0IEGHeQ8CGowkDdYcgYzGD0b4Ylo2EENylRXDhCsxudgY40orO3FqTZBhNHi0pjUQiC5yyxWwNgl0ZKN9gDU4wEZmLHEDGGLXidG46uZSVVvRYhM8YXn1Hz9jsaTADawY0G0xveU39LPy88CzL08Vx19rhXRJkjqbOu//Vwaf84DJjBY6UGoTdwXTX+sS8aC5MzH6MoDz7qHmXOajWU0Ou8/MO5/3/RwKHv/TJPokrRZd/nDoy1qb95SxQNmeKZ5RfQEBpBskZuKbVxrHXZ/FiEvBNE4azLRciDJTgJ9LZIjHXInvDn5b8NLu9eLrlHm5qa4NOLK6hjoWxKAXYs02ZT7zJSyvmAvfi5JqlT2M0sK7pHY0ExEgGBJ+vRDb+OgrkLlT6E/3VjZjx9aJdvzKnGwZVTDVrL+Yia65tIi67KtG9CriAARNMsAxnNLT9w4WDz0FqL2eunZg2LEvNHc40J2m7ipeYl5dsvJUL4Hyw2iBJ94kdpBmwTH12NO1kkHkkcI7LKKPEJl7Hu9uaBhN9V2K61m0H265g4DwrN3VkYLEoC80YgUHF9792JQASF9gSaiKkR+cLanz6GHvnErMZ29teg9dGQumHQeXKh3m9V/iq1IJSsazHII=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6539.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(2616005)(107886003)(38070700005)(38100700002)(186003)(82960400001)(6512007)(122000001)(86362001)(6862004)(66446008)(64756008)(76116006)(316002)(8936002)(8676002)(66476007)(66946007)(66556008)(4326008)(91956017)(4744005)(44832011)(5660300002)(2906002)(36756003)(508600001)(6506007)(6636002)(53546011)(37006003)(33656002)(6486002)(54906003)(71200400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?U3JONFZtd1JvcFVlNXZ4cTZmeERJWEVSOVdCckpBb1NHdkI0RDZrb0dvK1F2?=
 =?utf-8?B?R0pnYWw0TWREMWR6d1VLQm55SFpuWWhDbkN3a2Z3NmRqRUJsN1Z5aytObHpU?=
 =?utf-8?B?K0tQeWxjV09nSXpjTGtNM2hLeGFUeE1sbWZ0TnpQM2hBWSs0K3NhYUhVUTlj?=
 =?utf-8?B?dlp2RWtvSmFHbUJ6S3ZvNkZDMkU5UDlFeXkzdTdvSUpkR1IxNUVZTjVPSzl2?=
 =?utf-8?B?NlRTRmpVNnBidHhLLzNhb3JpL1BXSWVuRnFTL0IvZW90dkRiejE3T1BCb2NX?=
 =?utf-8?B?VGFVUGJSU1cxWkVnU3dnTFlBbmtxRXNmdEI4S2djaWgrRkdTb3RyaHV1THhG?=
 =?utf-8?B?dmhxTThpeG1ZWnVkajJYcC9kTHpIR0Vmbm5XU2hkMUp4QUVWdnJldFZod3RI?=
 =?utf-8?B?a0ExQlVyL3JQZHZ0cU05QjBDWjhYU0V2QVJCVzExVmZsVTAydHBYYktodkNq?=
 =?utf-8?B?MC90RzBDRDllbWhEU1Q3UkdFNnN4K1BHUkRsZlBPNWJ0UzR0REJwLzQyL0pP?=
 =?utf-8?B?LytBRlVhQ3RPV1l2Y0JTaGo3RCtmZDVlQTFrZzVpV2tKejNTKzgyR0ZXUnBm?=
 =?utf-8?B?WGFqeFZlT2NpN2xtRzAzdDNlZjFKYW9jU2lrUG9EVUFWakhEY2JVcnNzeUpN?=
 =?utf-8?B?RnJkcWZQMzRNSHJpZHhvUFI4dGJJUnN0SVZzblU0NWx5KzNzSE5LNHZ3M0Ni?=
 =?utf-8?B?dzNKRkdPUkRkODNlb3gzZ2U0MG11TllzdnIyL2lRR2VwM0FEZDNJMHRBMUZ1?=
 =?utf-8?B?eGJ5SWZhaWV2YTB1N0dkc2szYWZiSEJER1ByTXdGTEF1L0ZUTTQ3djlLRlh4?=
 =?utf-8?B?NGhtWUZUUDhqVVNFZHlNK2psaENDNkhGd0d1dWcyc2h4WEdIVDhHbEYvOEpH?=
 =?utf-8?B?UVVPck9RZWE5SlJ3TDlPVzJ1cmlWa3F5ZWJ3VTQ2MU93dzJCMWZCdWdmQzQr?=
 =?utf-8?B?UVdLcnQzWEl5R2xFdzNaYzlBQXNLdHNBMkJxODVPUlRQckJLeHlnTTdicjdn?=
 =?utf-8?B?WFpVWlYwZVRnRmk4MUw4TXVNNXhsT21SWkQ1RFJqR1dvUUt6VXM4SUlMeHI4?=
 =?utf-8?B?WHZuaTR3TFZtY0ZMSUk5ZytzQUFheDkvMEN5QWQwb3JPaHEzZVY5RjJYQ0wr?=
 =?utf-8?B?clZleW5BZ0FFV3JqUno0V0k0UDZXMEhSdzVSdDFEcW9YQk84QXBtZUFsc1lV?=
 =?utf-8?B?UDExb0F4QUNQODNtQUtpZnFhVmxXU1c2ZVVRT3Fad2VETm1DZG1zeVVzNkkz?=
 =?utf-8?B?dEJUTkhCMko3SUFjNEZkelFBb3Z2UXNydG9HQmlBUGpSYTRFQXNDTVpscG4r?=
 =?utf-8?B?dFhFUHRqZ1NSQ0o1akFIS3h5L3hHOXZ4K0JCVzZ6MmJWQVZ6ZnZZMldlUUIy?=
 =?utf-8?B?VTE1SEc3NkJnZFFhTXJBYUpWZnNTYkcxTFdSUVRXcXQ3QXNzeWxOSDJ6UXhv?=
 =?utf-8?B?Tm1UYUI4djBLMmp6bWN5b25lT255T04rWFowemc5K1dlVHAyMk9laEtBR0lx?=
 =?utf-8?B?Q2szcVYyV3cxOUZuMzNVQXVVWURLUjkwcUM4V1hRYjk5WHZZZHExSmJVSEhi?=
 =?utf-8?B?UFM5NDdBVTE0VWEvaW5aRHRrbXovVFhHYlFiemJKa2ROTk50ZnRGWHovN0Z0?=
 =?utf-8?B?THhta0N0SHJlbXY2OGVQMHZld1ZheUp6UUI3TzJ0UE03SVNDalV3cUc1UUN1?=
 =?utf-8?B?N1lGQ212bjFxVFVvbnhXNENwMjRFL2grT3F0c2huSUwySjAyVEJQemtzc2FS?=
 =?utf-8?B?WWZxUklQZWpZazV5T2ZFQk56SHNHLzFFUDVuTVM3ajdkNWJ0bUI2RTgvM1RP?=
 =?utf-8?B?TzdINndxMElwMUowenNWUXZwM3hHV1VzaDFhYldGV3RrbFF0SWIzZ0dzVWRO?=
 =?utf-8?B?K3Z5b211V0lJc0oxM2FxaFVFdHdrYUlqRE96eituck94aVMzOC81SW16U29l?=
 =?utf-8?B?M3YxOFZ5SXc4NGZ6NjBIaUEyTmRwelpDZXhDN1BwMWQ0NTN3V09CYVB0TmJJ?=
 =?utf-8?B?UldLTUZRWUdCbm9HZ1gvSnhBZDNzalRaWVVrd3labDJWdWtDdmZ0aUpzSkds?=
 =?utf-8?B?OEoyaCtlS3g3OEtCaWNML1dHbGdnVWxMbE5xak9LMlNBd3luVWRka0FCbVlL?=
 =?utf-8?B?Sk1FQUFaWm5FZWhva1NOTlJ3Ymh3OFpkVm11ejFrN0tkOEpFazhQN2ZIMUpr?=
 =?utf-8?B?MkVtRjQvbVpKZ3M2SXp2VG0veGhpQ0FOSSs4cWQvYXRpVkQvV0dxS2Rsbmpk?=
 =?utf-8?B?eERHYVhKaTgxRkhqYUEyZldKRGxzUHVQSVBDdjRUZ1BwNjZ5Y2RtRVBGczRD?=
 =?utf-8?B?YldFZERwUWt0ajB1bitFQUhrdlJDaUQreUl4YjZ6ZWUzeUJKUWtFTzV5SVNi?=
 =?utf-8?Q?71+V4WLj7Mm+U3wtbOxyYD3NPVHkEJEuBZJoe?=
Content-Type: multipart/alternative;
	boundary="_000_9C41A8D5FE5F471386F4780EE20F9103citrixcom_"
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6539.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cc7c2f3-2784-4ef3-669e-08da29e79d92
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 13:53:18.3991
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3yAhTpSduP102N84dKCR+Agl9FhuonoQafLscKGVT6C/50vEvpS+FwISrLp1i5a8MCfbKPn05IZCskNmXCkzPo4T+qW2cmrthAtqw40POW4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4880

--_000_9C41A8D5FE5F471386F4780EE20F9103citrixcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

DQoNCk9uIDEzIEFwciAyMDIyLCBhdCAxMjoyMSwgSmFuZSBNYWxhbGFuZSA8SmFuZS5NYWxhbGFu
ZUBjaXRyaXguY29tPG1haWx0bzpKYW5lLk1hbGFsYW5lQGNpdHJpeC5jb20+PiB3cm90ZToNCg0K
SW50cm9kdWNlIGEgbmV3IHBlci1kb21haW4gY3JlYXRpb24geDg2IHNwZWNpZmljIGZsYWcgdG8N
CnNlbGVjdCB3aGV0aGVyIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uIHNob3VsZCBi
ZSB1c2VkIGZvcg0KeHsyfUFQSUMuDQoNCnRvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbCAg
ICAgICAgfCAgMiArKw0KdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saSAgICAgICB8ICAy
ICsrDQp0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyAgIHwgIDIgKy0NCg0KQWNr
ZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbTxtYWls
dG86Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPj4NCg0KVGhlIGNoYW5nZXMgaGVyZSBhcmUg
bWluaW1hbCAtIEkgaGFkIGFja+KAmWVkIGFuIGVhcmxpZXIgaXRlcmF0aW9uLg0KDQrigJQgQ2hy
aXN0aWFuDQoNCg0KDQoNCg==

--_000_9C41A8D5FE5F471386F4780EE20F9103citrixcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <CB33BEFF607D2B488E18EF9FAE36BBA7@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy
YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0
ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz
PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u
IDEzIEFwciAyMDIyLCBhdCAxMjoyMSwgSmFuZSBNYWxhbGFuZSAmbHQ7PGEgaHJlZj0ibWFpbHRv
OkphbmUuTWFsYWxhbmVAY2l0cml4LmNvbSIgY2xhc3M9IiI+SmFuZS5NYWxhbGFuZUBjaXRyaXgu
Y29tPC9hPiZndDsgd3JvdGU6PC9kaXY+DQo8YnIgY2xhc3M9IkFwcGxlLWludGVyY2hhbmdlLW5l
d2xpbmUiPg0KPGRpdiBjbGFzcz0iIj4NCjxkaXYgY2xhc3M9IiI+SW50cm9kdWNlIGEgbmV3IHBl
ci1kb21haW4gY3JlYXRpb24geDg2IHNwZWNpZmljIGZsYWcgdG88YnIgY2xhc3M9IiI+DQpzZWxl
Y3Qgd2hldGhlciBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBzaG91bGQgYmUgdXNl
ZCBmb3I8YnIgY2xhc3M9IiI+DQp4ezJ9QVBJQy48YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9IiI+
DQp0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwgJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7fCAmbmJzcDsyICsrPGJyIGNsYXNzPSIiPg0KdG9vbHMvb2NhbWwv
bGlicy94Yy94ZW5jdHJsLm1saSAmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDt8
ICZuYnNwOzIgKys8YnIgY2xhc3M9IiI+DQp0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1
YnMuYyAmbmJzcDsmbmJzcDt8ICZuYnNwOzIgKy08YnIgY2xhc3M9IiI+DQo8L2Rpdj4NCjwvZGl2
Pg0KPC9ibG9ja3F1b3RlPg0KPGJyIGNsYXNzPSIiPg0KPC9kaXY+DQo8ZGl2PkFja2VkLWJ5OiBD
aHJpc3RpYW4gTGluZGlnICZsdDs8YSBocmVmPSJtYWlsdG86Y2hyaXN0aWFuLmxpbmRpZ0BjaXRy
aXguY29tIiBjbGFzcz0iIj5jaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208L2E+Jmd0OzwvZGl2
Pg0KPGRpdj48YnIgY2xhc3M9IiI+DQo8L2Rpdj4NCjxkaXY+VGhlIGNoYW5nZXMgaGVyZSBhcmUg
bWluaW1hbCAtIEkgaGFkIGFja+KAmWVkIGFuIGVhcmxpZXIgaXRlcmF0aW9uLjwvZGl2Pg0KPGRp
dj48YnIgY2xhc3M9IiI+DQo8L2Rpdj4NCjxkaXY+4oCUIENocmlzdGlhbjwvZGl2Pg0KPGRpdj48
YnIgY2xhc3M9IiI+DQo8L2Rpdj4NCjxkaXY+PGJyIGNsYXNzPSIiPg0KPC9kaXY+DQo8ZGl2Pjxi
ciBjbGFzcz0iIj4NCjwvZGl2Pg0KPGJyIGNsYXNzPSIiPg0KPC9ib2R5Pg0KPC9odG1sPg0K

--_000_9C41A8D5FE5F471386F4780EE20F9103citrixcom_--


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 13:57:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 13:57:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317367.536656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkR7L-0001Si-P0; Fri, 29 Apr 2022 13:57:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317367.536656; Fri, 29 Apr 2022 13:57:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkR7L-0001Sb-M4; Fri, 29 Apr 2022 13:57:07 +0000
Received: by outflank-mailman (input) for mailman id 317367;
 Fri, 29 Apr 2022 13:57:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xag3=VH=goodmis.org=rostedt@kernel.org>)
 id 1nkR7K-0001SV-KZ
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:57:06 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3fcd50dc-c7c4-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 15:57:04 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 83DDCB83563;
 Fri, 29 Apr 2022 13:57:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78159C385A7;
 Fri, 29 Apr 2022 13:56:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fcd50dc-c7c4-11ec-a405-831a346695d4
Date: Fri, 29 Apr 2022 09:56:54 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org,
 linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu,
 tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org
Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
Message-ID: <20220429095654.26d00b79@gandalf.local.home>
In-Reply-To: <832eecc5-9569-1d95-6ab8-f029b660dfcb@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
	<20220427224924.592546-18-gpiccoli@igalia.com>
	<b8771b37-01f5-f50b-dbb3-9db4ee26e67e@gmail.com>
	<20220429092351.10bca4dd@gandalf.local.home>
	<832eecc5-9569-1d95-6ab8-f029b660dfcb@igalia.com>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 29 Apr 2022 10:46:35 -0300
"Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:

> Thanks Sergei and Steven, good idea! I thought about the switch change
> you propose, but I confess I got a bit confused by the "fallthrough"
> keyword - do I need to use it?

No. The fallthrough keyword is only needed when there's code between case
labels. As it is very common to list multiple cases for the same code path.
That is:

	case DIE_OOPS:
 	case PANIC_NOTIFIER:
 		do_dump = 1;
 		break;

Does not need a fall through label, as there's no code between the DIE_OOPS
and the PANIC_NOTIFIER. But if you had:

	case DIE_OOPS:
		x = true;
 	case PANIC_NOTIFIER:
 		do_dump = 1;
 		break;

Then you do.

-- Steve


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:02:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:02:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317376.536667 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRCs-0002wf-D8; Fri, 29 Apr 2022 14:02:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317376.536667; Fri, 29 Apr 2022 14:02:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRCs-0002wY-9z; Fri, 29 Apr 2022 14:02:50 +0000
Received: by outflank-mailman (input) for mailman id 317376;
 Fri, 29 Apr 2022 14:02:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkRCr-0002wS-6q
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 14:02:49 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0ca2caea-c7c5-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 16:02:48 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkRCW-0007vi-1F; Fri, 29 Apr 2022 16:02:28 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ca2caea-c7c5-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=kwZz8z1ErGu8KMfXFyk29Ho8CQRFEY51B59OF6or4Ek=; b=PV6iGrw6a2PVwUqtN4K8zn62B4
	AVOvfuxpf+YqiDNw4wPls4rd7BZZRLk+DlIthCPmmpYzWeS6x1CxEGIJ+6ftYWBgJvBFfwGJOqCh5
	xlyk58zJVRPZef1SLet0zp5ibM7QDVVnOlmapmbP9P5ItPWzgMAPliAvmIbKMRpx1ZzLU5PWVzzn/
	sHvml72t32exF/AwwtKJVJzJexH4h9oxDHF0YV+DR3EbrkMYfXiYu6ewm7xFOm0g961CiqJr+h+xh
	qH6hC6fDAmncBkbOEiIY7tl+ZJgFaXJC+Qr6IL6xzP0mvIw9YmD61TykJP9krK0bs+lwyGwpmSvki
	syiNIcrw==;
Message-ID: <79472351-c6ce-a060-ef24-f64b6dce1637@igalia.com>
Date: Fri, 29 Apr 2022 11:01:59 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 09/30] coresight: cpu-debug: Replace mutex with
 mutex_trylock on panic notifier
Content-Language: en-US
To: Suzuki K Poulose <suzuki.poulose@arm.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org, Leo Yan <leo.yan@linaro.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Mike Leach <mike.leach@linaro.org>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-10-gpiccoli@igalia.com>
 <3cafe4fd-8a0b-2633-44a3-2995abd6c38c@arm.com>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <3cafe4fd-8a0b-2633-44a3-2995abd6c38c@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 28/04/2022 05:11, Suzuki K Poulose wrote:
> Hi Guilherme,
> [...] 
> How would you like to proceed with queuing this ? I am happy
> either way. In case you plan to push this as part of this
> series (I don't see any potential conflicts) :
> 
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Thanks for your review Suzuki, much appreciated!

About your question, I'm not sure yet - in case the core changes would
take a while (like if community find them polemic, require many changes,
etc) I might split this series in 2 parts, the fixes part vs the
improvements per se. Either way, a V2 is going to happen for sure, and
in that moment, I'll let you know what I think it's best.

But either way, any choice you prefer is fine by me as well (like if you
want to merge it now or postpone to get merged in the future), this is
not an urgent fix I think =)
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317383.536678 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRJm-0003cC-4M; Fri, 29 Apr 2022 14:09:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317383.536678; Fri, 29 Apr 2022 14:09:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRJm-0003c5-1O; Fri, 29 Apr 2022 14:09:58 +0000
Received: by outflank-mailman (input) for mailman id 317383;
 Fri, 29 Apr 2022 14:09:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7mBs=VH=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1nkRJk-0003bz-9S
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 14:09:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0b12c012-c7c6-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 16:09:54 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-dQOIlikzNAmDMx1vPnB7TQ-1; Fri, 29 Apr 2022 16:09:53 +0200
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10)
 by VI1PR04MB3199.eurprd04.prod.outlook.com (2603:10a6:802:3::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 14:09:51 +0000
Received: from DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748]) by DU2PR04MB9067.eurprd04.prod.outlook.com
 ([fe80::249d:2d32:4f2a:f748%8]) with mapi id 15.20.5186.021; Fri, 29 Apr 2022
 14:09:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b12c012-c7c6-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1651241394;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=zZ2JvjYipBvzOZWaySmotetEPlbA3iJbOqtDc/S9194=;
	b=WGPlI7KKAKPksNJ7klW7tq4QwjFdbdtAYygFB8NUgWoaouoAx4FnBI2z4BHP/R+AVbsHTo
	84puIU1x0yipGd1GMJtK6ghnT/DVO/K+FfwYKznLpc7HFN41skUdzEoPig+E6/apbraRZh
	+Dinlv5sHPN6s7Z+fFmaucxXkNvOY6k=
X-MC-Unique: dQOIlikzNAmDMx1vPnB7TQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qgtqz/eBEW2a0IuHTkfaUJ+PeFp5qFhvrN4bGRlD0+7c+QHQVyxdUgJAWgw05JskgGGTtg+PuezDDNgPwem233L3ZfgR+PZmaPhr8YDNPi0+COEOWvz+KgnaXuTuN7YUSdp+k4BjMTWmIkuDKzS8LIvlsY9hYnTY0NOVNNPx3dfLm77TBQevlFiMiGanb7wrOnpG2osjMHIUU1kaKTqDH9I5AifmwqHxIOZ0evuUrM5qxO7Dvl+k7d9y62c2UPuKh0lNW6UhkOK7CpdQAOM9J9aaxmiPOfmg7jIIPLYLrQBKhsgSRZ+wuIfea1m9pUNJySCRZG2+g0BViKdpczcqBg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zZ2JvjYipBvzOZWaySmotetEPlbA3iJbOqtDc/S9194=;
 b=lvWCF7Cn8L/Ok6fHM1NcAKpYuDCTjthDs75HKe1RyQ5IfkDtCSvB60wzF86lUJnizYa2sg321Hsuy3OFgeQk2OAH91hubkg/YmrcVABVgxByI7TjjXpD23b7qQ3t8Uq0aRcc2K8yz3pR1ltI2uLBvM9hKkvz4OwnzdSoHkKWy/En8TSK1QRNqPJ+Ij5I0IjY5BxP5i03U+dlOct6GWVU0nyi+AldcjYOhXF+PSbhs+ufG5THEyr7J6r/2WKGoOqOLQi4WQgB540F4sD525HDpV7gnZzAifPV9Y8G+TO9Diq9a/I6SHCv39SqeRvSjllhHRZ9k5EQkXopU2q3qfHPeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>, "ohering@suse.de"
	<ohering@suse.de>, "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Topic: [PATCH] x86: make "dom0_nodes=" work with credit2
Thread-Index:
 AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgAAVUwCABn7lAIAABpgAgAEqhACAGTPWgIAAF2gAgAAfzYA=
Date: Fri, 29 Apr 2022 14:09:50 +0000
Message-ID: <a8ce120ee64165ac7b08de90e6786bb871541af3.camel@suse.com>
References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com>
	 <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com>
	 <b41009b4-fea4-826f-f36f-7dd9f4edd1bb@suse.com>
	 <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com>
	 <e061a647cd77a36834e2085a96a07caa785c5066.camel@suse.com>
	 <35599105-b441-96cf-7537-ccf9dfac0934@suse.com>
	 <fd07c28fad352a476544258f2ac4d652062b2701.camel@suse.com>
	 <85c55676-b21f-1eb4-0471-19ca9b6de39f@suse.com>
In-Reply-To: <85c55676-b21f-1eb4-0471-19ca9b6de39f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.44.1 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 87cca63e-8f30-4cb8-dad8-08da29e9ed1c
x-ms-traffictypediagnostic: VI1PR04MB3199:EE_
x-microsoft-antispam-prvs:
 <VI1PR04MB3199F983324FA932A78E2E32C5FC9@VI1PR04MB3199.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 0cEkQnYygalFm7b+Lv7gk1M398z1tLMr40ujm3YbFAVrvslkJgFma7s7l+QayqGOYc7z+/ZOEfrFqZeRp1yajxwYcVTm/zylAP6/VCTOj20cWD2WUJ03T5S+wgVR/EZyw6VzwdM32ky7bO98csQHBj0V649s4sqkfeWDGtD5x8M/eHYOCBJkGn7NizXBacYpuJmdeBKj5N8XiBj9IeV3hE4xU2thF/Y6HdZR9JuKRCriGpTWlYzcMM+vDu/WX2fPiK3e6fPtTWQr2M0AJzVrYPLjaXffHAx3IkdoaaOH+YJfJHhYtSmneilI4PmPt3qjKLpdjkmwPFJAGkROd91BLjIqU5hvCuPHi3BYDJE3+cAvTR+WFFyrohgXOhHOkQIeqdNYdvy7WqYtFKXFqUCIWGnpoWPxVIEo7c+Kn+ty0fwrudPHluDJiD/tpFfHksP5qfzTuN3tHo+QMf0ilSNX9u6wgkK/rG5M2TahsN9oLBBxM61AkRILCGhMwD7N7zDm2X+U0RaIOUjTn4eeO7rNiUhwzdm0yQQu5sJgsfN5pL+4tsXBTk41NhO0Qkod86oLO40bgdAbrUqCENOQm8x6N5w8AfNNNnTvw7zW7KhHImWBMTlF3rM/kbjNwmOxLzWSkfdoamYR/sHVhOWWmDsOuto5N50PaU59/OsnUsG7PlgKu3n9hZBUKBIsr4m65bDucgaFWmId1N/jWrecsXgLJM2hlTT5sK+dDz9Pc/PA0B51gfXakQ5mVQZ4VhDvhNFpexw40J8g9yVLWVRZZ3muvw+/IoE2N5BQq9sZgA1L/QNoW6t21E3kn3rpl7RP1oio4V2aVpp5a9/LOrFrQbD0kg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9067.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(6506007)(5660300002)(86362001)(83380400001)(2906002)(53546011)(91956017)(64756008)(66556008)(8676002)(66476007)(76116006)(2616005)(66946007)(4326008)(6862004)(66446008)(36756003)(186003)(8936002)(38100700002)(38070700005)(71200400001)(6636002)(37006003)(966005)(498600001)(54906003)(99936003)(6486002)(122000001)(6512007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?NFVWUFUvWmhoOXNZdEY3WjNZa2tFSWFuMnE0d3Vobk56RHloTXhaSzNWeDN1?=
 =?utf-8?B?cEFNZldWUzBBN3VXM2JmVG1SQWdsRXpIYk9GbndzSVltUFRyWVlYR0xKYVNl?=
 =?utf-8?B?YkdjM0dGZTRIMTVmYnBwMlM1dTdHanB3L21DL0lZUytDUVpVSUoyZXhxSS82?=
 =?utf-8?B?YjZEbjcxb1dOaWxTL1NoZDBQSW9pd2kza2dKb2hYc2FoV0xTYnIyVlZtNkRS?=
 =?utf-8?B?d3NRa2hKV2dOQTNzb2hMRm5XK2plaDVnZDVpdzZYNUxnMUJUb1JLdUhiYmxT?=
 =?utf-8?B?UU9kU21JUEZqMXhMOXZLN2VjbDlaejdHaDhBakREUFhtYVljQ2VjNHptOUkx?=
 =?utf-8?B?ZXVQdTZmc05neHJMVFVScnVoOXZFdW12YnkrTmFvbzVTQWhTWHN0Y1lMODA0?=
 =?utf-8?B?RSsyVU45NlMvbzc2S1d1cGhqRTZyejFZNXpJNWhVNmM4a3VnYjFkYlFQdWVX?=
 =?utf-8?B?WmZLTm1NTUpMZDYwM1ZNRHZ5WXovOFVrcG9YNHZrMy9vcEJOZEpETHZPdWg4?=
 =?utf-8?B?a1R5L2RSSlM1OEFqVFZObEhWOFNaMkhsN25KODd3SXZGNDl5eWkvY3RPMnpJ?=
 =?utf-8?B?Z2EzN3RNcy9ZVTljV2FhMjUraW1qTFhlM0d3Q05VS05JbmxoazJNdGxPWnk0?=
 =?utf-8?B?Z3JhUnVBS2VkTG81NE5qTDBsUUJQY2VDdkNRNnEzVE1rb2xic25WcE5HMUxr?=
 =?utf-8?B?L1gwMHZqQU91Um4wOGNsMG9HRXJaNWdyMy83RExxOCtUbUcxT2RoUW41K2Z3?=
 =?utf-8?B?TnQ4bCt5YW1EUVdwcTRiNDZpOVFsbXY1MUxvd00wdEd2Yk5ENXlFRldjUDgz?=
 =?utf-8?B?RE9BaWlsOFkwa1k3aTV6bHhYYjY0blZLaXJtSkVqR3AvMlJoeHVJN3Zaam5x?=
 =?utf-8?B?dnJ3WTFsOEQ5TFg4T0tIcFEwenhFQ0djNm96NDNGUXZxcmZXQXg5dmNQVWI2?=
 =?utf-8?B?ZlJkYm0yZWVYTDlpajM4U2NHQ09oaEFraVJDTXdUOVh1OXB1MjhzQkx1Z2M3?=
 =?utf-8?B?ZXlkeVlkVTNWTnpxZDdKVm1tNnhub0pZY0lzZ3I5aDNiRUxnR21GZG9Ob0xJ?=
 =?utf-8?B?MVluTmRLNU56V04zTW9Ud252OXVFTEwyWldkbHRWWjdCWEFPYkFHNDQ3anNK?=
 =?utf-8?B?WlVhazhOT2lVb1hWM09NL2h1ZTZudlNzY0RaU055M2JhdVRaeWU1eGRDNXJW?=
 =?utf-8?B?ZEQ1MjREWXFZeERtaTNmSzQ0OGFsTGxKbU8rUGtmbGlxZ015bHZGSWNBVCtJ?=
 =?utf-8?B?TUJwZkJRbmk4a3hubjhtV2tTeU9WQXVCelpINDgzSE0xOFJqY2VEd3RvMkw5?=
 =?utf-8?B?TnN5eDdFM2dPbGFOMnI1bmxQTmFiQ2UyY2l3eVBIMDJ0eC9WOGRnQWtsdjJO?=
 =?utf-8?B?Qm9GdEFsOWh5V1cvQjNvT1pQZVJpUy9xR0trRGUrQWQ0aGdHaStKWWJwNjJR?=
 =?utf-8?B?SzB4QjFXbHJTSHd5YlEzc1hwVVN4MUY3UFZEOWVya1VkZHYxMFhpdzduZjZm?=
 =?utf-8?B?cmg0T2p1eWprQkxLODgwaFVRbHZHcklaRGZzeVdydjFjWTZkUVh2RWhVNXRV?=
 =?utf-8?B?SE51azAxM0VXMENYTWNROXA1Z29BbWl4UTZPTTgxUlkxbWJoWThKNS9KRHlF?=
 =?utf-8?B?TkFhOWxwZ2lZdlBpenJOWHdFQjZTcjlxR0Fta2NZR0JpbVNCMG1BU09jWnJ5?=
 =?utf-8?B?c1VobFZlTUU0RGZGdnlubjRUUDUvWm9VVXNBZWczRmhKd0xmSHA3T29nLy9N?=
 =?utf-8?B?VHpkNVBqVXU3RmpoZTJTcm5CcHFlVWZZMitzamJ5ekNaT1M5ZU9MWUhaQlNa?=
 =?utf-8?B?R1F0cnk5TUZVMWVFZEdGOEdtYnlBaU56T0Evc0UvRktCdmsxTXQzUGtjZ2Ri?=
 =?utf-8?B?WDhKNC9Yb3l5WCt3Yk83MG5oblpMS2FPVWxUdms2b09abjM3Z2JqM1NCSHlC?=
 =?utf-8?B?UnhhY1ZwRmtEcFhXN0FBeldSaGkrWVpNVWU4dG9xQjkweFl5dE9uSTVPSkdT?=
 =?utf-8?B?cTVjSld6b3hPUkJkUjRmd0FTbFNoeW43dHRPNndJUFdHbDZXaWlpZkF1ZkYv?=
 =?utf-8?B?MU1ERGg0QVhSMVZteEcxSS9XL0hMcVZhUXNON0tzamdEQ2NVYlNlNWtCV0lU?=
 =?utf-8?B?am1yZ01TL05GTXpVVDlTS29hL3dpN2l3Y1B1Y3JzbFd2YVovWWw4NFFCR2tI?=
 =?utf-8?B?bVlOaEtsaHByVEFCUWxmMUpKR01CQkpjTUdDNDFFTjg2Ymp6TkRtTGVjdUxz?=
 =?utf-8?B?N0dIRU9reU5SdHZhOTZZaVBCT1ZrSE5DZ3B4Sjk4SWJIOGNZRytqWjJzeCtU?=
 =?utf-8?B?TFNoczhTWVRPK1Z6N3JnbjNJVC83TXJaRFhHYmNIRTc5TnIwQXRxQT09?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-7/4pZg/mM9KmhfVVd3SQ"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9067.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87cca63e-8f30-4cb8-dad8-08da29e9ed1c
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 14:09:50.7931
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HYjU7ko4DjEO5z2anNBDVXOVbjt1/omc29eMcQA0busisZoX/rOYoFSy1kybmMmEMH2PL6DlpKm8Iv9aUjlAXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3199

--=-7/4pZg/mM9KmhfVVd3SQ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2022-04-29 at 14:16 +0200, Jan Beulich wrote:
> On 29.04.2022 12:52, Dario Faggioli wrote:
> > > Is that mainly
> > > to have a way to record preferences even when all preferred CPUs
> > > are
> > > offline, to be able to go back to the preferences once CPUs come
> > > back
> > > online?
> > >=20
> > That's another example/use case, yes. We want to record the user's
> > preference, whatever the status of the system (and of other aspects
> > of
> > the configuration) is.
> >=20
> > But I'm not really sure I've answered... Have I?
>=20
> You did.=C2=A0
>
Ok, great! :-)

> >=20
> > If dom0_nodes is in "strict" mode,
> > we want to control hard affinity only. So we set soft to the
> > default,
> > which is "all". During operations, since hard is a subset of "all",
> > soft-affinity will be just ignored.
>=20
> Right - until such point that all (original) Dom0 CPUs have gone
> offline. Hence my 2nd question.
>=20
> > So I'm using "all" because soft-affinity is just "all", unless
> > someone
> > sets it differently.
>=20
> How would "someone set it differently"? Aiui you can't control both
> affinities at the same time.
>=20
Yeah, the argument here is basically the one that I put below, and that
you say you understand. I guess I could have put it a bit more upfront,
sorry about that. :-)

> > >=20
> > > Hmm, you leave this alone. Wouldn't it be better to further
> > > generalize
> > > things, in case domain affinity was set already? I was referring
> > > to
> > > the mask calculated by sched_select_initial_cpu() also in this
> > > regard.
> > > And when I did suggest to re-use the result, I did mean this
> > > literally.
> > >=20
> > Technically, I think we can do that. Although, it's probably
> > cumbersome
> > to do, without adding at least one cpumask on the stack, or
> > reshuffle
> > the locking between sched_select_initial_cpu() and
> > sched_init_vcpu(),
> > in a way that I (personally) don't find particularly pretty.
>=20
> Locking? sched_select_initial_cpu() calculates into a per-CPU
> variable,
> which I sincerely hope cannot be corrupted by another CPU.
>=20
No, not by another CPU, hopefully.

And this is probably fine, during boot, when there should be no (other)
scheduling activity. However, during normal operation, a vCPU being
scheduled on CPU X, or in general having X in v->processor, could be
using the scratch cpumask of X already. So, if we use it without
locking, we'd risk using the wrong mask.

Therefore, we require the scheduler lock to be held, for playing with
the scratch cpumasks:

/*
 * Scratch space, for avoiding having too many cpumask_t on the stack.
 * Within each scheduler, when using the scratch mask of one pCPU:
 * - the pCPU must belong to the scheduler,
 * - the caller must own the per-pCPU scheduler lock (a.k.a. runqueue
 *   lock).
 */
DECLARE_PER_CPU(cpumask_t, cpumask_scratch);
#define cpumask_scratch        (&this_cpu(cpumask_scratch))
#define cpumask_scratch_cpu(c) (&per_cpu(cpumask_scratch, c))

And sched_init_vcpu() (and hence sched_select_initial_cpu()) can be
called during normal operation.

In fact, sched_select_initial_cpu() does pcpu_schedule_lock_irqsave()
before starting using it.

>=20
> > And again, soft and hard affinity should be set to what the user
> > wants
> > and asks for. And if, for instance, he/she passes
> > dom0_nodes=3D"1,strict", soft-affinity should just be all. If, e.g.,
> > we
> > set both hard and soft affinity to the CPUs of node 1, and if later
> > hard affinity is manually changed to "all", soft affinity will
> > remain
> > to node 1, even if it was never asked for it to be that way, and
> > the
> > user will need to change that explicitly as well. (Of course, it's
> > not
> > particularly clever to boot with dom0_nodes=3D"1,strict" and then
> > change
> > dom0's vCPUs' hard affinity to node 0... but the user is free to do
> > that.)
>=20
> I can certainly accept this as justification for using "all" further
> up.
>=20
Good then.

Do you think some of this exchange we had should end somewhere
(comments? changelogs?), to make it clearer to both future us and new
contributors why things are done this way?

Thanks and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-7/4pZg/mM9KmhfVVd3SQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmJr8a0ACgkQFkJ4iaW4
c+5F4RAAo3Frs1dSt1I4avpihybWRPGs1GXdDTsEAJyHz03Tf/GSV81+viO5pcA8
hzQGO5fVxT6JZXMp016zBzcCd6DsaBFYvPj4FxowBWFMjW4Prcs750q91GD1jdOW
Bko4vKFqgnpF8qF7oZMEpleXC4rUdI07XEi1Cj4sAaT7HE2dnXdKol6k/2c7RhOY
CFG8boYrInllmTFJTUf5g5yHqwdFjNSSIezS7w40BkHT9kWZOmgNTuzfOVNdoHHQ
gVgCWzR1aQPpYebyGuT7eo2CDhHLE6wJks/EAj74YBuJ3FTt6E0RlZmgH3sp2rht
+1gBjakubdf0bdBWM1iD/cADrzoE4xJ7c3j/drwN9bzTpoLS6bflQuzObo3+zmZI
mu8weG2DqNSTvtR44u7UBVV5wSiIkO2P1/1xwlQyHNsPi+4qIe2t8dhp6KZTv2/P
8DYnOZPwWi40WAxRVj76nS6xeXkXMeCpQ6K2BD6odVs7w2JV6OwMsbJMS7PUYNV9
Fv8I3g1uM8Z0iwFR/GbgtugqSZj+rIriEgsw6cKRh2ERV++RnBY1bjNppkOCCjSK
Fbk+/mjvjlfJg/d48Kr0QOoV6ieGa9BJ939Hzr7Ctli+Uc1D4Ud9u2swV3SWcsEe
hhdMHtpXlMYXCP8NUrjQVCrbkIu9wuoJ/IxiOPgTw8aNYdb6fZ4=
=zetz
-----END PGP SIGNATURE-----

--=-7/4pZg/mM9KmhfVVd3SQ--



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:22:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:22:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317389.536690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRVh-0005sm-56; Fri, 29 Apr 2022 14:22:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317389.536690; Fri, 29 Apr 2022 14:22:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRVh-0005sf-1S; Fri, 29 Apr 2022 14:22:17 +0000
Received: by outflank-mailman (input) for mailman id 317389;
 Fri, 29 Apr 2022 14:22:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkRVf-0005sV-Ob; Fri, 29 Apr 2022 14:22:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkRVf-0001L5-LV; Fri, 29 Apr 2022 14:22:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkRVf-0004eE-4N; Fri, 29 Apr 2022 14:22:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkRVf-0006tQ-2x; Fri, 29 Apr 2022 14:22:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+NDYGu+zDw+M3CrdcoYHOWjGrYEBHHYlq1oT/GkH22I=; b=mZswhJeMuO/jqjJhsbQgZPjQgr
	hcftfNvt0Qx7oKbQKSlY2Sh+3kuj4Msm7KgtBdAV27VLUNcTrNF9a150LgS4faA9wKWKcG6ROj1nz
	umrt37m/WqG0WtfcrV/17i+a1Qgr6yqk/+iOdLybvIraizsLF+vkA+Q8Dz5hFx/GHXQs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169849-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169849: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl:xen-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=f22833602095b05733bceaddeb20f3edfced3c07
X-Osstest-Versions-That:
    qemuu=6071ff6087208bf1d8e488dca43037b41d5ad764
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 14:22:15 +0000

flight 169849 qemu-mainline real [real]
flight 169869 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169849/
http://logs.test-lab.xenproject.org/osstest/logs/169869/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl            7 xen-install         fail pass in 169869-retest
 test-armhf-armhf-xl-arndale   8 xen-boot            fail pass in 169869-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 169869 never pass
 test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 169869 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169827
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169827
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169827
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169827
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169827
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169827
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169827
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169827
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                f22833602095b05733bceaddeb20f3edfced3c07
baseline version:
 qemuu                6071ff6087208bf1d8e488dca43037b41d5ad764

Last test of basis   169827  2022-04-28 16:55:00 Z    0 days
Testing same since   169849  2022-04-29 03:46:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Damien Hedde <damien.hedde@greensocs.com>
  Jean-Philippe Brucker <jean-philippe@linaro.org>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   6071ff6087..f228336020  f22833602095b05733bceaddeb20f3edfced3c07 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:33:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:33:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317398.536701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRgk-0007SN-DY; Fri, 29 Apr 2022 14:33:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317398.536701; Fri, 29 Apr 2022 14:33:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRgk-0007SG-8z; Fri, 29 Apr 2022 14:33:42 +0000
Received: by outflank-mailman (input) for mailman id 317398;
 Fri, 29 Apr 2022 14:33:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CdjT=VH=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nkRgi-0007SA-Um
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 14:33:41 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on062f.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::62f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c201b8f-c7c9-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 16:33:39 +0200 (CEST)
Received: from DB6PR07CA0006.eurprd07.prod.outlook.com (2603:10a6:6:2d::16) by
 AM4PR08MB2836.eurprd08.prod.outlook.com (2603:10a6:205:d::30) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12; Fri, 29 Apr 2022 14:33:34 +0000
Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2d:cafe::7c) by DB6PR07CA0006.outlook.office365.com
 (2603:10a6:6:2d::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.6 via Frontend
 Transport; Fri, 29 Apr 2022 14:33:34 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 14:33:34 +0000
Received: ("Tessian outbound 9511859e950a:v118");
 Fri, 29 Apr 2022 14:33:34 +0000
Received: from deeca7ce46bb.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0ECFA33F-1C97-41F0-82C1-B35527895F47.1; 
 Fri, 29 Apr 2022 14:33:26 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id deeca7ce46bb.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 29 Apr 2022 14:33:26 +0000
Received: from DB6PR0801MB2022.eurprd08.prod.outlook.com (2603:10a6:4:76::15)
 by AM6PR08MB4166.eurprd08.prod.outlook.com (2603:10a6:20b:a6::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr
 2022 14:33:18 +0000
Received: from DB6PR0801MB2022.eurprd08.prod.outlook.com
 ([fe80::556f:106a:aa3:42f6]) by DB6PR0801MB2022.eurprd08.prod.outlook.com
 ([fe80::556f:106a:aa3:42f6%3]) with mapi id 15.20.5186.025; Fri, 29 Apr 2022
 14:33:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c201b8f-c7c9-11ec-a405-831a346695d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=OTCuXrZY6D9pq/oNQQdI4cvkjYc77y8Ukf5/TB37fkXDoPQjT4OMbVgKoooKRwHQ0uifvG/sOOa2fQNOBrVaMFlVe0vY2Pfqjy45ro6fuDqy55eal9GZhosbmK7Jm/ylcvrLkHbx1a9Fi0trBO7/FRCyal4FJTkCSF73HfKi/59kf2gIxfPvZzgtlIbQPpUQebxUTTJNIjhIyRB3rdL52amQqCOmJ1h2ZPHBmmEwwqhLbkscfQgiJiPvbRAMEFnw1NshxBe8sBHtXsayT2G8Z+v1PMS02RVUmCMMNdULocq8ZTAkwxm/VeRIw2mFEj2ja7my2WxAY+JZpR7O5+g9JA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B8UqTu4o0IYoUCHO1jrwbDByB81Vgr7jktqWisZeiy4=;
 b=BlGTa6g8XwJJ85u9/YC7rAqZX8CY73KNcCjF8GWw1wbzh7oS9K65PmoraKGjP1aKbhpHthkrlBsX4xOtaTyEPNG2cMGCU8GwCJoyty0uIbzlTnLPiOvGKCu3GuCH06c8VYoeG2fTOkI76vNRGqUNDsacGhFBLIBTxVQ8KePOhFHyyAMjFkZafTODlQEgw2QvKV+U9xWWkeqLJDfsr7+DywgF0iBeW1TubK8cud89PnJAFRgiwONbpTvnwBQZUVkWi8LR/539h4B+TRuPHyZaUGZhy8v673IAcuYex4P14k7/wvNTuj4hlVJ5dEtEFVFutWwnEjfjrYdBP4mlrS5yBQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=B8UqTu4o0IYoUCHO1jrwbDByB81Vgr7jktqWisZeiy4=;
 b=j1gHED3Vcal/HezkW5a1MGlUdJE5wow0JPVxNh64YN0oXRG6pLREimSwGcMv83Bv8P7ene722IHxZF2Ab5xmykaBSQ2MrUkOTK6eyOWG2RqCFDOcv5NfjkqvZegtoR+JrrBfIB4RFu2VjZvb5VS9M0i+TXPCCaLamL/BZMVCt80=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1b5e74b37100d3c1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fPwBPnT7mPIhZYL1KVu9/ue2+6K2twuUfUjK0kVfxsjRtG/2irHv7hyyh2jeNMyEF5PbJu8BzDVCofBcqI/b/QxnWnCUnXDTZ0b+eM1eVuEMeSeg3aqgxwUiPsDavtya8YyQqsvoUwcClGkYPHix6SoPQ1pvjMiFu+b23eN1W0fpoIZ6IBv+QA+xhqWESsLBjBy5fKmSNPEHS+d72Xkz8eD2eNmnNGGQmcx2PBKs6vk1MlD67QU/AGH0z46+vRXgW4/hqArOHWO5MX8Ids3fK84JHVNuVhSkauMYIWe27LNJWvZYivv6ZHZvULeNePTZC2RovdVCFooFTB+N4cW+Ig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B8UqTu4o0IYoUCHO1jrwbDByB81Vgr7jktqWisZeiy4=;
 b=G6jnIf9fFzEzCDVTesWwX5zCdlDoTywY4F+gAO9h661rKECutgsxKGresAMD7+Hvm0CJBp3nry6i+evmc0ts+qB7+yXtEIed/EYwWD58CLHd6V+SiuhLlgrPUCEXEESUHmcVEuLXD5wwtHthxY0OpQjKKcy5aw3GWC2ND4vGuuPqwtMLK5l2Xu6jlqO1u7NgzR+7/9hoSjXpCbdnm0WnZfwMC7blhY25/C13Y68yHRKjjEQExbbdwCgfy9uroorn9vZl8ZhY08mGae95sHRUYhwLiU3042kjIVaxqNjTSkDpdhxNtu5aiVnCS4vFXNXcMctWeFTf36JBBoXbAhF2WA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=B8UqTu4o0IYoUCHO1jrwbDByB81Vgr7jktqWisZeiy4=;
 b=j1gHED3Vcal/HezkW5a1MGlUdJE5wow0JPVxNh64YN0oXRG6pLREimSwGcMv83Bv8P7ene722IHxZF2Ab5xmykaBSQ2MrUkOTK6eyOWG2RqCFDOcv5NfjkqvZegtoR+JrrBfIB4RFu2VjZvb5VS9M0i+TXPCCaLamL/BZMVCt80=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a
 device
Thread-Topic: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a
 device
Thread-Index: AQHYWlIekEFYa4Z+ZkOKg6prrRxnv60EB7eAgALvxoA=
Date: Fri, 29 Apr 2022 14:33:17 +0000
Message-ID: <004BB439-72CA-4543-8CEA-C3BADC7D98CF@arm.com>
References:
 <a19f7238f428deb610df643944f60e1e79e273cf.1651075797.git.rahul.singh@arm.com>
 <0c6fd5db-ffc7-893a-1ad0-d54f3974a45a@xen.org>
In-Reply-To: <0c6fd5db-ffc7-893a-1ad0-d54f3974a45a@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 86e719eb-b81f-49cf-101c-08da29ed3d74
x-ms-traffictypediagnostic:
	AM6PR08MB4166:EE_|DBAEUR03FT031:EE_|AM4PR08MB2836:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR08MB283630D7B00DEB23B8F72E00FCFC9@AM4PR08MB2836.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 3GUqMQmsPFJgukEu+wgulObbVRJOw7vf8JWf7bKS6v2DVpn/Yp2vCkHEshxaqOm9CqI9ULqtQc0y2F2n8pjr83AhG6D4M4Hr5+eAaJ34SE6VP1/gCmkv8BmioVCfc1fFERbgZ/BI3Agssd8HNDjxRXJClaV/9qO4lVDHVN2y5fqmP4xMUDoymUu7YLnvz+tMon/m3ABrbSDRzJu2AGDjRzTgBYBg0AMt0LxBbe8YCU1oqNW0brincV/3XzAQ1sY8gR46LIXyS4jRQ35Ukbs31ZuA1lTwWI5eFj0I5wxLDoh7CAOPKWt1U/808r1imnsaqTLcA1Dj9hIARcIIT//BH+LyVEQNtBN211LSvpaVW6k70ggBNdqWdOLifWhhjX02aFko2rocWhedFQXNhm9BJ2LzilGZVGp7DIZCSYn1URsiFoCdKoi+/qmGHNNlFDW6lVF5M7RHWDtvCVwdgSo6IWe3GIa3i8gPcaJL1NMMmsrnNPdhmeeSyyIlBNH6gmhmzTkr+daKHoSx0lGgJch7a9uCCzh94lx9UOZJwQ6V+h2Jf0lA1tGn/ZSZ/3l2ta2g4/25RJdB3cN7GPy3O581y7M7c1jKsz2cOpX/mj0cIZ2L0AM1RTtnusGZoZoUgSfM1xqV1hXiN83GDCYz6OOjEEaMuEF6jLkfT/yzmDZLEQm2aKOALcxDpDoH2dudUKhzzZ9XO22IuVwtd4zQczEW78eerxvd5OIzgP5/rxt/Y59dekxASwPraa82RRMXeQ8J
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2022.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(36756003)(6506007)(33656002)(53546011)(4326008)(26005)(6512007)(5660300002)(71200400001)(508600001)(6486002)(66946007)(91956017)(66556008)(66446008)(8676002)(66476007)(64756008)(54906003)(76116006)(86362001)(122000001)(316002)(2616005)(6916009)(186003)(38100700002)(38070700005)(2906002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <704152574B971B41B177957346D74610@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4166
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	496a317e-fa1a-4c31-f270-08da29ed33a9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XBQaJ88j7ifrRTI4WSGkiwhp1ZawI/cOU1Tuz1ICGUZOBTvvATgP+MhUdIGq9nOZyuhrfoEnCSSL1mUf3maoTOCAVwDs+Sbm6rodSnOGmELECv2mZoqpLueBYUVza67vgNKXwOKo4cjVy6y4sDdx49vsNHm9L9ZN4c1P7s8iXsZnriYIIaPaS+lotEX30OfzDK/ex7gZbIx713q7Q+04LzBnxoadms1NghwHmeOi1H5NrUesyI6V7bX3DuTVzILLfqc6wUl3uE+HsK7gmH7npc4fB/Wap5VNtnK29z55L4lAUyhqzTvn0eLYoKOzIhMklBYpmvC1NosjEJC0qR5TI/Zyl/vGn5Q+Et385bQ5CLvrEt5aEHZWGgk4TdoRXD4tlA6y01Jhp8NNwmC0cGp0o2fVIFJZYM6OlZpWKbpFBSvYQ+Q5MPaA+nFTDWG7EiLcuCuDztrL29WgsUjYIxI/F6zTDTPN/UlFt/WA7zqQ+K++AiDSqZBIo13R+MGJWw/vyWMhyXA746sJLZqNl/U8hBDy9cBzVcvyCDcjTpdD++vNQ2nJ+kxphXs8WxMDO5y4tEAJnbEQckKKPbTdckEkVvSkIeTRVZ7OgTiugytkeeUE37DuPvw0fyPCCnWPKSN9xYEQ8vEtytUhuPn7hTVa7ocRshdYKPZSuxcczuh4TrB3H9YsRBNNfvLti7/93QKq
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(316002)(54906003)(336012)(2906002)(5660300002)(81166007)(8936002)(356005)(40460700003)(6862004)(8676002)(4326008)(70586007)(82310400005)(86362001)(36860700001)(70206006)(6512007)(186003)(107886003)(2616005)(33656002)(508600001)(53546011)(6486002)(36756003)(26005)(6506007)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 14:33:34.1194
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 86e719eb-b81f-49cf-101c-08da29ed3d74
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2836

SGkgSnVsaWVuLA0KDQo+IE9uIDI3IEFwciAyMDIyLCBhdCA2OjQyIHBtLCBKdWxpZW4gR3JhbGwg
PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpLA0KPiANCj4gT24gMjcvMDQvMjAyMiAx
NzoxNSwgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiBXaGVuIGEgZGV2aWNlIGlzIGRlYXNzaWduZWQg
ZnJvbSB0aGUgZG9tYWluIGl0IGlzIHJlcXVpcmVkIHRvIHJlbW92ZSB0aGUNCj4+IGlvbW11IGdy
b3VwLg0KPiANCj4gVGhpcyByZWFkIHdyb25nIHRvIG1lLiBXZSBzaG91bGQgbm90IG5lZWQgdG8g
cmUtY3JlYXRlIHRoZSBJT01NVSBncm91cCAoYW5kIGNhbGwgYXJtX3NtbXVfYWRkX2RldmljZSgp
KSBldmVyeSB0aW1lIGEgZGV2aWNlIGlzIHJlLWFzc2lnbmVkLg0KT2suDQo+IA0KPj4gSWYgd2Ug
ZG9uJ3QgcmVtb3ZlIHRoZSBncm91cCwgdGhlIG5leHQgdGltZSB3aGVuIHdlIGFzc2lnbg0KPj4g
YSBkZXZpY2UsIFNNRSBhbmQgUzJDUiB3aWxsIG5vdCBiZSBzZXR1cCBjb3JyZWN0bHkgZm9yIHRo
ZSBkZXZpY2UNCj4+IGJlY2F1c2Ugb2YgdGhhdCBTTU1VIGZhdWx0IHdpbGwgYmUgb2JzZXJ2ZWQu
DQo+IA0KPiBJIHRoaW5rIHRoaXMgaXMgYSBidWcgZml4IGZvciAwNDM1Nzg0Y2M3NWRjZmVmM2I1
ZjU5YzI5ZGViMWRiYjg0MjY1ZGRiLiBJZiBzbywgcGxlYXNlIGFkZCBhIEZpeGVzIHRhZy4NCg0K
T2sgTGV0IG1lIGFkZCB0aGUgRml4ZXMgdGFnIGluIG5leHQgdmVyc2lvbi4NCj4gDQo+PiBTaWdu
ZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+IC0tLQ0KPj4g
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYXJtL3NtbXUuYyB8IDIgKysNCj4+IDEgZmlsZSBjaGFu
Z2VkLCAyIGluc2VydGlvbnMoKykNCj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9hcm0vc21tdS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYXJtL3NtbXUuYw0KPj4g
aW5kZXggNWNhY2IyZGQ5OS4uOWEzMWMzMzJkMCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL2FybS9zbW11LmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L2FybS9zbW11LmMNCj4+IEBAIC0xNjkwLDYgKzE2OTAsOCBAQCBzdGF0aWMgdm9pZCBhcm1fc21t
dV9kZXRhY2hfZGV2KHN0cnVjdCBpb21tdV9kb21haW4gKmRvbWFpbiwgc3RydWN0IGRldmljZSAq
ZGV2KQ0KPj4gCWlmIChjZmcpDQo+PiAJCWFybV9zbW11X21hc3Rlcl9mcmVlX3NtZXMoY2ZnKTsN
Cj4+ICsJaW9tbXVfZ3JvdXBfcHV0KGRldl9pb21tdV9ncm91cChkZXYpKTsNCj4+ICsJZGV2X2lv
bW11X2dyb3VwKGRldikgPSBOVUxMOw0KPj4gfQ0KPiANCj4gVGhlIGdvYWwgb2YgYXJtX3NtbXVf
ZGV0YWNoX2RldigpIGlzIHRvIHJldmVydCB0aGUgY2hhbmdlIG1hZGUgaW4gYXJtX3NtbXVfYXR0
YWNoX2RldigpLiBCdXQgbG9va2luZyBhdCB0aGUgY29kZSwgbmVpdGhlciB0aGUgSU9NTVUgZ3Jv
dXAgbm9yIHRoZSBzbWVzIGFyZSBhbGxvY2F0ZWQgaW4gYXJtX3NtbXVfYXR0YWNoX2RldigpLg0K
PiANCj4gQXJlIHRoZSBTTUVTIG1lYW50IHRvIGJlIHJlLWFsbG9jYXRlZCBldmVyeXRpbWUgd2Ug
YXNzaWduIHRvIGEgZGlmZmVyZW50IGRvbWFpbj8gSWYgeWVzLCB0aGUgYWxsb2NhdGlvbiBzaG91
bGQgYmUgZG9uZSBpbiBhcm1fc21tdV9hdHRhY2hfZGV2KCkuDQoNClllcyBTTUVTIGhhdmUgdG8g
YmUgcmUtYWxsb2NhdGVkIGV2ZXJ5IHRpbWUgYSBkZXZpY2UgaXMgYXNzaWduZWQuDQoNCklzIHRo
YXQgb2theSBpZiBJIHdpbGwgbW92ZSB0aGUgZnVuY3Rpb24gYXJtX3NtbXVfbWFzdGVyX2FsbG9j
X3NtZXMoKSBmcm9tIGFybV9zbW11X2FkZF9kZXZpY2UoKSB0byBhcm1fc21tdV9hdHRhY2hfZGV2
KCkuDQpJbiB0aGlzIGNhc2Ugd2UgZG9u4oCZdCBuZWVkIHRvIHJlbW92ZSB0aGUgSU9NTVUgZ3Jv
dXAgYW5kIGFsc28gYXJtX3NtbXVfZGV0YWNoX2RldigpIHdpbGwgYWxzbyByZXZlcnQgdGhlICBj
aGFuZ2UgbWFkZSBpbiBhcm1fc21tdV9hdHRhY2hfZGV2KCkuDQoNCmRpZmYgLS1naXQgYS94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC9hcm0vc21tdS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
YXJtL3NtbXUuYw0KaW5kZXggNWNhY2IyZGQ5OS4uZmYxYjczZDNkOCAxMDA2NDQNCi0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FybS9zbW11LmMNCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL2FybS9zbW11LmMNCkBAIC0xNjgwLDYgKzE2ODAsMTAgQEAgc3RhdGljIGludCBhcm1f
c21tdV9hdHRhY2hfZGV2KHN0cnVjdCBpb21tdV9kb21haW4gKmRvbWFpbiwgc3RydWN0IGRldmlj
ZSAqZGV2KQ0KICAgICAgICBpZiAoIWNmZykNCiAgICAgICAgICAgICAgICByZXR1cm4gLUVOT0RF
VjsNCiANCisgICAgICAgcmV0ID0gYXJtX3NtbXVfbWFzdGVyX2FsbG9jX3NtZXMoZGV2KTsNCisg
ICAgICAgaWYgKHJldCkNCisgICAgICAgICAgICAgICByZXR1cm4gcmV0Ow0KKw0KICAgICAgICBy
ZXR1cm4gYXJtX3NtbXVfZG9tYWluX2FkZF9tYXN0ZXIoc21tdV9kb21haW4sIGNmZyk7DQogfQ0K
IA0KQEAgLTIwNzUsNyArMjA3OSw3IEBAIHN0YXRpYyBpbnQgYXJtX3NtbXVfYWRkX2RldmljZShz
dHJ1Y3QgZGV2aWNlICpkZXYpDQogICAgICAgIGlvbW11X2dyb3VwX2FkZF9kZXZpY2UoZ3JvdXAs
IGRldik7DQogICAgICAgIGlvbW11X2dyb3VwX3B1dChncm91cCk7DQogDQotICAgICAgIHJldHVy
biBhcm1fc21tdV9tYXN0ZXJfYWxsb2Nfc21lcyhkZXYpOw0KKyAgICAgICByZXR1cm4gMDsNCiB9
DQoNClJlZ2FyZHMsDQpSYWh1bA0KPiANCj4gSWYgbm90LCB0aGVuIHdlIHNob3VsZCBub3QgZnJl
ZSB0aGUgU01FUyBoZXJlDQo+IA0KPiBJSVVDLCB0aGUgU01FUyBoYXZlIHRvIGJlIHJlLWFsbG9j
YXRlZCBldmVyeSB0aW1lIGEgZGV2aWNlIGlzIGFzc2lnbmVkLiBUaGVyZWZvcmUsIEkgdGhpbmsg
d2Ugc2hvdWxkIG1vdmUgdGhlIGNhbGwgdG8gYXJtX3NtbXVfbWFzdGVyX2FsbG9jX3NtZXMoKSBv
dXQgb2YgdGhlIGRldGFjaCBjYWxsYmFjayBhbmQgaW4gYSBoZWxwZXIgdGhhdCB3b3VsZCBiZSB1
c2VkIHdoZW4gcmVtb3ZpbmcgYSBkZXZpY2UgKG5vdCB5ZXQgc3VwcG9ydGVkIGJ5IFhlbikuDQo+
IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:34:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:34:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317403.536712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRhc-0007yK-Mf; Fri, 29 Apr 2022 14:34:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317403.536712; Fri, 29 Apr 2022 14:34:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRhc-0007yD-IL; Fri, 29 Apr 2022 14:34:36 +0000
Received: by outflank-mailman (input) for mailman id 317403;
 Fri, 29 Apr 2022 14:34:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkRhb-0007xz-H7; Fri, 29 Apr 2022 14:34:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkRhb-0001YU-FK; Fri, 29 Apr 2022 14:34:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkRhb-00059d-47; Fri, 29 Apr 2022 14:34:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkRhb-0005wV-3Z; Fri, 29 Apr 2022 14:34:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yNfSnppewsUnKC23XTgtZalfRBzvZhNtJnNaJiXIPck=; b=zwW65uzww/QVZB29cZOnRURJjB
	gbPIPU5IQmRZVKSaEB+h7BX65kDUPLBSHj2Lx+4BU/e+I+VUKJVUal0As0fgvqOeXPzTU2cf0536b
	6b2jxnuMOdevAokdife22A48rg36++si1Y2kyWGnWZL25pCZdsejMDWFpwHxGOOT+J48=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169864-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 169864: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd
X-Osstest-Versions-That:
    xen=e57477359071ab91429b0ebcbf7ff162242e2831
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 14:34:35 +0000

flight 169864 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169864/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  fe234237b6fc8afc5d8265850169ceeb3d2f81fd
baseline version:
 xen                  e57477359071ab91429b0ebcbf7ff162242e2831

Last test of basis   169853  2022-04-29 05:00:25 Z    0 days
Testing same since   169864  2022-04-29 10:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e574773590..fe234237b6  fe234237b6fc8afc5d8265850169ceeb3d2f81fd -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:36:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:36:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317412.536722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRjN-0000Cn-2G; Fri, 29 Apr 2022 14:36:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317412.536722; Fri, 29 Apr 2022 14:36:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRjM-0000Ce-VR; Fri, 29 Apr 2022 14:36:24 +0000
Received: by outflank-mailman (input) for mailman id 317412;
 Fri, 29 Apr 2022 14:36:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkRjJ-0000CV-2b
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 14:36:23 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id badb301f-c7c9-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 16:36:18 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkRiK-0009WD-3O; Fri, 29 Apr 2022 16:35:20 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: badb301f-c7c9-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=ZdZBPtTkXvskvklO0DqGHW3vJ6Arb57ZyicMdsmwPPs=; b=Id0YxwZLmWV943xSSctc382COx
	slYd+Mbgd8mluBGRTtubiqJcFH7Jw+KCfrIBUuJ6IBjkEi3jycQJ/GZIWCNzfYdJZGxOzIKlAq9i5
	NGU7dMo+j6aXXuC9zPnllvKUmp4j7d1NBQPsBNjzH1goO9ZNvF9j+05V5SxGqrz8IpFC/ke6Hqou9
	ZUhvlX5vvgSwWpU57PqA3cf0RcC09NkmKHiXH92FbdJDx27V/PJs6cBfrjjyUhrMtQCOhvF+z0Tsu
	zF1ocWG4HwYZ0G6pmdbbbK4PGRnRNWBCGP+4DKIndhzsOY9kfvz7NjpBrTKt1RM1gSIvJ0Gc9QwYA
	dmc3mStA==;
Message-ID: <4a7d9670-92f8-3e12-a619-aaa64adca093@igalia.com>
Date: Fri, 29 Apr 2022 11:34:51 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 12/30] parisc: Replace regular spinlock with spin_trylock
 on panic path
Content-Language: en-US
To: Helge Deller <deller@gmx.de>, akpm@linux-foundation.org, bhe@redhat.com,
 pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-13-gpiccoli@igalia.com>
 <6a7c924a-54a9-c5ea-8a9d-3ea92987b436@gmx.de>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <6a7c924a-54a9-c5ea-8a9d-3ea92987b436@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 28/04/2022 13:55, Helge Deller wrote:
> [...]
> You may add:
> Acked-by: Helge Deller <deller@gmx.de> # parisc
> 
> Helge

Thanks Helge, added!
Cheers,


Guilherme

> 
> 
>> ---
>>  arch/parisc/include/asm/pdc.h |  1 +
>>  arch/parisc/kernel/firmware.c | 27 +++++++++++++++++++++++----
>>  drivers/parisc/power.c        | 17 ++++++++++-------
>>  3 files changed, 34 insertions(+), 11 deletions(-)
>>
>> diff --git a/arch/parisc/include/asm/pdc.h b/arch/parisc/include/asm/pdc.h
>> index b643092d4b98..7a106008e258 100644
>> --- a/arch/parisc/include/asm/pdc.h
>> +++ b/arch/parisc/include/asm/pdc.h
>> @@ -83,6 +83,7 @@ int pdc_do_firm_test_reset(unsigned long ftc_bitmap);
>>  int pdc_do_reset(void);
>>  int pdc_soft_power_info(unsigned long *power_reg);
>>  int pdc_soft_power_button(int sw_control);
>> +int pdc_soft_power_button_panic(int sw_control);
>>  void pdc_io_reset(void);
>>  void pdc_io_reset_devices(void);
>>  int pdc_iodc_getc(void);
>> diff --git a/arch/parisc/kernel/firmware.c b/arch/parisc/kernel/firmware.c
>> index 6a7e315bcc2e..0e2f70b592f4 100644
>> --- a/arch/parisc/kernel/firmware.c
>> +++ b/arch/parisc/kernel/firmware.c
>> @@ -1232,15 +1232,18 @@ int __init pdc_soft_power_info(unsigned long *power_reg)
>>  }
>>
>>  /*
>> - * pdc_soft_power_button - Control the soft power button behaviour
>> - * @sw_control: 0 for hardware control, 1 for software control
>> + * pdc_soft_power_button{_panic} - Control the soft power button behaviour
>> + * @sw_control: 0 for hardware control, 1 for software control
>>   *
>>   *
>>   * This PDC function places the soft power button under software or
>>   * hardware control.
>> - * Under software control the OS may control to when to allow to shut
>> - * down the system. Under hardware control pressing the power button
>> + * Under software control the OS may control to when to allow to shut
>> + * down the system. Under hardware control pressing the power button
>>   * powers off the system immediately.
>> + *
>> + * The _panic version relies in spin_trylock to prevent deadlock
>> + * on panic path.
>>   */
>>  int pdc_soft_power_button(int sw_control)
>>  {
>> @@ -1254,6 +1257,22 @@ int pdc_soft_power_button(int sw_control)
>>  	return retval;
>>  }
>>
>> +int pdc_soft_power_button_panic(int sw_control)
>> +{
>> +	int retval;
>> +	unsigned long flags;
>> +
>> +	if (!spin_trylock_irqsave(&pdc_lock, flags)) {
>> +		pr_emerg("Couldn't enable soft power button\n");
>> +		return -EBUSY; /* ignored by the panic notifier */
>> +	}
>> +
>> +	retval = mem_pdc_call(PDC_SOFT_POWER, PDC_SOFT_POWER_ENABLE, __pa(pdc_result), sw_control);
>> +	spin_unlock_irqrestore(&pdc_lock, flags);
>> +
>> +	return retval;
>> +}
>> +
>>  /*
>>   * pdc_io_reset - Hack to avoid overlapping range registers of Bridges devices.
>>   * Primarily a problem on T600 (which parisc-linux doesn't support) but
>> diff --git a/drivers/parisc/power.c b/drivers/parisc/power.c
>> index 456776bd8ee6..8512884de2cf 100644
>> --- a/drivers/parisc/power.c
>> +++ b/drivers/parisc/power.c
>> @@ -37,7 +37,6 @@
>>  #include <linux/module.h>
>>  #include <linux/init.h>
>>  #include <linux/kernel.h>
>> -#include <linux/notifier.h>
>>  #include <linux/panic_notifier.h>
>>  #include <linux/reboot.h>
>>  #include <linux/sched/signal.h>
>> @@ -175,16 +174,21 @@ static void powerfail_interrupt(int code, void *x)
>>
>>
>>
>> -/* parisc_panic_event() is called by the panic handler.
>> - * As soon as a panic occurs, our tasklets above will not be
>> - * executed any longer. This function then re-enables the
>> - * soft-power switch and allows the user to switch off the system
>> +/*
>> + * parisc_panic_event() is called by the panic handler.
>> + *
>> + * As soon as a panic occurs, our tasklets above will not
>> + * be executed any longer. This function then re-enables
>> + * the soft-power switch and allows the user to switch off
>> + * the system. We rely in pdc_soft_power_button_panic()
>> + * since this version spin_trylocks (instead of regular
>> + * spinlock), preventing deadlocks on panic path.
>>   */
>>  static int parisc_panic_event(struct notifier_block *this,
>>  		unsigned long event, void *ptr)
>>  {
>>  	/* re-enable the soft-power switch */
>> -	pdc_soft_power_button(0);
>> +	pdc_soft_power_button_panic(0);
>>  	return NOTIFY_DONE;
>>  }
>>
>> @@ -193,7 +197,6 @@ static struct notifier_block parisc_panic_block = {
>>  	.priority	= INT_MAX,
>>  };
>>
>> -
>>  static int __init power_init(void)
>>  {
>>  	unsigned long ret;
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:45:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:45:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317423.536734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRsC-0001k7-W2; Fri, 29 Apr 2022 14:45:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317423.536734; Fri, 29 Apr 2022 14:45:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRsC-0001k0-Sq; Fri, 29 Apr 2022 14:45:32 +0000
Received: by outflank-mailman (input) for mailman id 317423;
 Fri, 29 Apr 2022 14:45:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkRsB-0001ju-Vm
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 14:45:31 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0426b75b-c7cb-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 16:45:31 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkRru-0009vz-Hw; Fri, 29 Apr 2022 16:45:14 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0426b75b-c7cb-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=cEz0jvzYMJy/+PnSroZ/Hi6xu9Xg7ihjZ6KqkMsyEVA=; b=TtjJWVYR2YAsPylCOEsPMfdeP3
	uewJTDxZvNwqz8faFaLHrMu4SGCc7XKgfqXs0N9Eqi4GqpadVMfaDxlWZzVPKQLi8ni/s2ddxpu3K
	tP6hsTWVLR98QNCsrf0212qd1xvVl1Ei20QGO6x8V4HGcJkkz3V8HTUpxBZ8YdMeJOhwfqc/a8/uJ
	6uvHWRRLoq8CaJRaw2R8nKQ6rT+OEKWXBb4ItDaXeeq0xIrWs1dLGM6n+SsKoTqhKb432TBldb0L4
	ADdMsHTu5tPPflo8jyg6MaAv6SnfkenTNCGCscDeHdEnB08Cvtm9IbN9EZtdJb4wh68LkWeJPFXS4
	x01q8OQw==;
Message-ID: <b81cf509-60d5-a733-0b06-374d9c146559@igalia.com>
Date: Fri, 29 Apr 2022 11:44:43 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
Content-Language: en-US
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org,
 linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu,
 tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-18-gpiccoli@igalia.com>
 <b8771b37-01f5-f50b-dbb3-9db4ee26e67e@gmail.com>
 <20220429092351.10bca4dd@gandalf.local.home>
 <832eecc5-9569-1d95-6ab8-f029b660dfcb@igalia.com>
 <20220429095654.26d00b79@gandalf.local.home>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <20220429095654.26d00b79@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/04/2022 10:56, Steven Rostedt wrote:
> [...]
> No. The fallthrough keyword is only needed when there's code between case
> labels. As it is very common to list multiple cases for the same code path.
> That is:
> 
> 	case DIE_OOPS:
>  	case PANIC_NOTIFIER:
>  		do_dump = 1;
>  		break;
> 
> Does not need a fall through label, as there's no code between the DIE_OOPS
> and the PANIC_NOTIFIER. But if you had:
> 
> 	case DIE_OOPS:
> 		x = true;
>  	case PANIC_NOTIFIER:
>  		do_dump = 1;
>  		break;
> 
> Then you do.
> 
> -- Steve

Thanks a bunch for the clarification, changed that for V2 =)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:51:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:51:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317433.536745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRy1-0003BA-Ks; Fri, 29 Apr 2022 14:51:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317433.536745; Fri, 29 Apr 2022 14:51:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRy1-0003B3-HW; Fri, 29 Apr 2022 14:51:33 +0000
Received: by outflank-mailman (input) for mailman id 317433;
 Fri, 29 Apr 2022 14:51:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkRxz-0003Ax-P3
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 14:51:31 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id da8dd4a2-c7cb-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 16:51:30 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkRxT-000A9L-NU; Fri, 29 Apr 2022 16:51:00 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da8dd4a2-c7cb-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=Cjm9Suf796xRefBryIv3VFGXEqCg0nq87G3JemtP6KI=; b=bOkvcmrOB4yWUf0ctf6A3r5C4o
	aGPNIkUqTShj3NXe1fQ9QnabHeBC5wUw85w3lcbzp41YUx6lI64SyTBc+R9iDEVFjkoDKQQTgPy7h
	273qYkEvGo09cqDCBxJ/qx7PIhv1bF1QhE39mt6cGaKYQ3WbFc+SFQq5LvAEXFJkLusPN7e5Q2PZK
	roci1iw1YHbfVmH13T9qkHZElt6ySbfsFxOd+T6mw3OVW5ydz5FagyqIAlf4Yk69T4v6GBs3z1SwV
	dFo6XNp8moGQFWImiZj9BmwXekz/oeTAh8/7Imc9/VjCAhGKmOrC5yxOD82kD1wVNeFw+T4dSUWnI
	V5zt266A==;
Message-ID: <e169f964-2cd7-b9c5-7080-0505d52caa12@igalia.com>
Date: Fri, 29 Apr 2022 11:50:24 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 20/30] panic: Add the panic informational notifier list
Content-Language: en-US
To: Suzuki K Poulose <suzuki.poulose@arm.com>, paulmck@kernel.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
 bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org,
 linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 kexec@lists.infradead.org, linux-leds@vger.kernel.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
 linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org,
 linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
 netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net,
 rcu@vger.kernel.org, sparclinux@vger.kernel.org,
 xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com,
 kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com,
 alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com,
 arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com,
 dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com,
 gregkh@linuxfoundation.org, mikelley@microsoft.com,
 hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de,
 keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org,
 mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org,
 senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de,
 vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Catalin Marinas <catalin.marinas@arm.com>,
 Florian Fainelli <f.fainelli@gmail.com>,
 Frederic Weisbecker <frederic@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Hari Bathini <hbathini@linux.ibm.com>,
 Joel Fernandes <joel@joelfernandes.org>,
 Jonathan Hunter <jonathanh@nvidia.com>, Josh Triplett
 <josh@joshtriplett.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
 Leo Yan <leo.yan@linaro.org>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Michael Ellerman <mpe@ellerman.id.au>, Mike Leach <mike.leach@linaro.org>,
 Mikko Perttunen <mperttunen@nvidia.com>,
 Neeraj Upadhyay <quic_neeraju@quicinc.com>,
 Nicholas Piggin <npiggin@gmail.com>, Paul Mackerras <paulus@samba.org>,
 Thierry Reding <thierry.reding@gmail.com>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>, pmladek@suse.com,
 bhe@redhat.com
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-21-gpiccoli@igalia.com>
 <7956ab00-66b6-bd89-dcc0-f10cf2741e4d@arm.com>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <7956ab00-66b6-bd89-dcc0-f10cf2741e4d@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Thanks Paul and Suzuki for the ACKs.
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 14:53:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 14:53:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317438.536756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRzR-0003ku-W4; Fri, 29 Apr 2022 14:53:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317438.536756; Fri, 29 Apr 2022 14:53:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkRzR-0003kn-SE; Fri, 29 Apr 2022 14:53:01 +0000
Received: by outflank-mailman (input) for mailman id 317438;
 Fri, 29 Apr 2022 14:53:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xZxz=VH=citrix.com=prvs=111f028e5=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nkRzR-0003ef-Cn
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 14:53:01 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0f1d796a-c7cc-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 16:52:59 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f1d796a-c7cc-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651243979;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=xdhjm0VfALfwk2tX/QcBYmgcVuJpDyaGyPZzlGF2914=;
  b=OOYgpE/U5DzkeC0snv2GiwkANT0arR6dQD2KDKqfK+sL45ovSoDs0JrL
   9ICsxHPU2CCA+JNAqqi0fXPJwYXPQr/mYkqgWfpfuLVxRqxvSgfhQsccU
   KRVv8IgDuAUJ0LzwbFbIa7yOBSuY/g1HPWgRlSDYO1JImaTcp84JyxO1h
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 70241562
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8zwqGKk/L3WB0K6BrZc1eJPo5gzzJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLC2zQb/7bamameYtxO9+zoxhXupPQzddnGgNk+H0xHiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DlWVLV4
 rsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYVDkmJYTOg+8kfRxYIh10HKNv0q3gLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJGMWAzNUmeOXWjPH8GVc80of2XuUXnbiVitUOwvfcr2jLMmVkZPL/Fb4OOJ43iqd9utlmcj
 nLL+SL+GB5yHMySz3+J/2yhgsfLnDjnQ8QCGbug7PlojVaPgGsJB3U+V1ShpuKiolWjQN8ZI
 EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUn1g6W46jP6D+3A2g1cjRgZvUMpug5EGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdQ2mY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J8swZX20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4NuWgmfh4waZxdJFcFh
 XM/XysItfe/21PwMMdKj3+ZUZx2ncAM6/y4PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiO9D7n1ulAv7GMGgpzz6gOX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0CDr2jOnWHrd97wJJjBSFTOK0aYvd/LoarSjeK0kl6YxMN6dvNo7BYopk=
IronPort-HdrOrdr: A9a23:ePJbm6DG9d3p07rlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/
 xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U
 4KSclD4bPLYmRHsQ==
X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; 
   d="scan'208";a="70241562"
Date: Fri, 29 Apr 2022 15:52:44 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] tools/libs/light: update xenstore entry when setting
 max domain memory
Message-ID: <Ymv7vAEuiG3/IO3C@perard.uk.xensource.com>
References: <20220420080426.7036-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220420080426.7036-1-jgross@suse.com>

On Wed, Apr 20, 2022 at 10:04:26AM +0200, Juergen Gross wrote:
> libxl_domain_setmaxmem() called during "xl mem-max" should update the
> domain's memory/static-max Xenstore node, as otherwise "xl mem-set"
> won't be able to set the memory size to the new maximum.

Setting domain's memory higher than the original mem-max only works on
PV and maybe PVH guest, right? Because on HVM, QEMU is told about
maxmem when starting a guest, and allocates some stuff from this address
(vga buffer, pci rom I think) so trying to give HVM guest more memory
after the fact is probably not going to go smoothly.

> Adjust the related comments and documentation accordingly.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> V2:
> - adjust comments and docs (Anthony Perard)

Maybe `man xl` should be updated as well. In the section about `xl
mem-max`, there is:
    "Note however that the initial maxmem value is still used as an
    upper limit for xl mem-set.  Also note that calling xl mem-set will
    reset this value."

That wouldn't be true anymore with this patch.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 15:10:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 15:10:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317448.536772 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSGg-0006E6-G2; Fri, 29 Apr 2022 15:10:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317448.536772; Fri, 29 Apr 2022 15:10:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSGg-0006Dz-DH; Fri, 29 Apr 2022 15:10:50 +0000
Received: by outflank-mailman (input) for mailman id 317448;
 Fri, 29 Apr 2022 15:10:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R1X1=VH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nkSGf-0006Dt-B2
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 15:10:49 +0000
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com
 [2a00:1450:4864:20::233])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ca95f61-c7ce-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 17:10:48 +0200 (CEST)
Received: by mail-lj1-x233.google.com with SMTP id y19so10889768ljd.4
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 08:10:47 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 i14-20020a198c4e000000b0044a279d25d2sm258572lfj.244.2022.04.29.08.10.46
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 29 Apr 2022 08:10:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ca95f61-c7ce-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=pBiFdJVBK7XJGcpZMBcNpezNa6QIqErstaAn3kJpmDo=;
        b=dZwSRZ2uUt8/WpZywemY6gH9zX1bSy62uuhUOu5pOWQT+dn18k2SDQQu6GJeCR1fmI
         B9i/eUnvM463HnUn9gPQ4mIHvkU2iyDkHZb6gVT4C6czaSHmrvBGn8LgplqbU9XWyyGU
         J4w9GZKmjIVcfqj51GhpnuXtNWhRwHVmfxq8rrhs2c+yKxtv/p5YTOUohXke7TESuHwl
         ngFhgzPPHRJotN6GR9+KG4f0FM0F+tyMW9UsJtBUtKHgKcdM7uXUD7PlGvKOFStGFvkC
         ZRhqVMfg6QSxwiqmYL54PQdkBEtWRtax0cv5wzeGjGXGRBFFqty9gQWjVObdZ5Jwma+l
         W+wA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=pBiFdJVBK7XJGcpZMBcNpezNa6QIqErstaAn3kJpmDo=;
        b=fVmAtgogCXBZtrGUTA3Uh76gguBh8+ucm9Yzj4jRvNmDfPke5ZfUvTTQ5+NZkiwgF6
         XNY4pcEgRs85ebCrbh3mOZVYDx3OVWrhr6kltPfWCVjUBWKOVYprzA3zJzZAoaNomtgv
         3TP4ZNUbVekAo56SQfgqB8ppbZNr8oSdIyVIFRiQ7vyqYBwCjJeUWCi293KZCt7julUf
         weQPC1O7hmWqNd4rljJwa2FT3I01BVvT9HOXSmGrXmariwXcxy2OeEzTXryNmhV8qpWM
         gdcIw+9OF8ZAhFYNRxkkmW2LqfUyj7Jmajm20B5DwVOjgiP93tGJNIENWSYDnTNtf5ng
         U46g==
X-Gm-Message-State: AOAM531+6BdLPT7KNPtEjJZ/3eV41/LXtXQAsEplWicREPPrW8RWqvEB
	srYeeARDNpI+Nbrio6mtVlc=
X-Google-Smtp-Source: ABdhPJwIjn/TgfjiVJ+PFQMmSwVNO9odm3G/qZjzSdU0Ck0X7LMwl8OoTfIdYYrpdzx9s+oxgWnlKg==
X-Received: by 2002:a2e:9e8e:0:b0:24a:d2d4:4509 with SMTP id f14-20020a2e9e8e000000b0024ad2d44509mr24544459ljk.69.1651245047368;
        Fri, 29 Apr 2022 08:10:47 -0700 (PDT)
Subject: Re: [PATCH v2 19/19] xen/xenbus: eliminate xenbus_grant_ring()
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20220428082743.16593-1-jgross@suse.com>
 <20220428082743.16593-20-jgross@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <bf14e3e1-fc4d-1eee-1dfb-1ba3423f0b6f@gmail.com>
Date: Fri, 29 Apr 2022 18:10:45 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220428082743.16593-20-jgross@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 28.04.22 11:27, Juergen Gross wrote:


Hello Juergen


> There is no external user of xenbus_grant_ring() left, so merge it into
> the only caller xenbus_setup_ring().
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> V2:
> - make error message more precise (Andrew Cooper)
> ---
>   drivers/xen/xenbus/xenbus_client.c | 65 +++++++++---------------------
>   include/xen/xenbus.h               |  2 -
>   2 files changed, 19 insertions(+), 48 deletions(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
> index 1a2e0d94ccd1..d6fdd2d209d3 100644
> --- a/drivers/xen/xenbus/xenbus_client.c
> +++ b/drivers/xen/xenbus/xenbus_client.c
> @@ -363,50 +363,6 @@ static void xenbus_switch_fatal(struct xenbus_device *dev, int depth, int err,
>   		__xenbus_switch_state(dev, XenbusStateClosing, 1);
>   }
>   
> -/**
> - * xenbus_grant_ring
> - * @dev: xenbus device
> - * @vaddr: starting virtual address of the ring
> - * @nr_pages: number of pages to be granted
> - * @grefs: grant reference array to be filled in
> - *
> - * Grant access to the given @vaddr to the peer of the given device.
> - * Then fill in @grefs with grant references.  Return 0 on success, or
> - * -errno on error.  On error, the device will switch to
> - * XenbusStateClosing, and the error will be saved in the store.
> - */
> -int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
> -		      unsigned int nr_pages, grant_ref_t *grefs)
> -{
> -	int err;
> -	unsigned int i;
> -	grant_ref_t gref_head;
> -
> -	err = gnttab_alloc_grant_references(nr_pages, &gref_head);
> -	if (err) {
> -		xenbus_dev_fatal(dev, err, "granting access to ring page");
> -		return err;
> -	}
> -
> -	for (i = 0; i < nr_pages; i++) {
> -		unsigned long gfn;
> -
> -		if (is_vmalloc_addr(vaddr))
> -			gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr));
> -		else
> -			gfn = virt_to_gfn(vaddr);
> -
> -		grefs[i] = gnttab_claim_grant_reference(&gref_head);
> -		gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id,
> -						gfn, 0);
> -
> -		vaddr = vaddr + XEN_PAGE_SIZE;
> -	}
> -
> -	return 0;
> -}
> -EXPORT_SYMBOL_GPL(xenbus_grant_ring);
> -
>   /*
>    * xenbus_setup_ring
>    * @dev: xenbus device
> @@ -424,6 +380,7 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
>   		      unsigned int nr_pages, grant_ref_t *grefs)
>   {
>   	unsigned long ring_size = nr_pages * XEN_PAGE_SIZE;
> +	grant_ref_t gref_head;
>   	unsigned int i;
>   	int ret;
>   
> @@ -433,9 +390,25 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
>   		goto err;
>   	}
>   
> -	ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs);
> -	if (ret)
> +	ret = gnttab_alloc_grant_references(nr_pages, &gref_head);
> +	if (ret) {
> +		xenbus_dev_fatal(dev, ret, "granting access to %u ring pages",
> +				 nr_pages);
>   		goto err;
> +	}
> +
> +	for (i = 0; i < nr_pages; i++) {
> +		unsigned long gfn;
> +
> +		if (is_vmalloc_addr(*vaddr))
> +			gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr[i]));
> +		else
> +			gfn = virt_to_gfn(vaddr[i]);
> +
> +		grefs[i] = gnttab_claim_grant_reference(&gref_head);

gnttab_claim_grant_reference() can return error if no free grant 
reference remains.

I understand this patch only moves the code, but probably it would be 
better to add a missing check here (and likely rollback already 
processed grants if any?).



> +		gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id,
> +						gfn, 0);
> +	}
>   
>   	return 0;
>   
> diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
> index b533b4adc835..eaa932b99d8a 100644
> --- a/include/xen/xenbus.h
> +++ b/include/xen/xenbus.h
> @@ -224,8 +224,6 @@ int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch,
>   			 const char *pathfmt, ...);
>   
>   int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state);
> -int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
> -		      unsigned int nr_pages, grant_ref_t *grefs);
>   int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr,
>   		      unsigned int nr_pages, grant_ref_t *grefs);
>   void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages,

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 15:20:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 15:20:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317454.536783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSPb-0007Gc-BW; Fri, 29 Apr 2022 15:20:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317454.536783; Fri, 29 Apr 2022 15:20:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSPb-0007G6-8b; Fri, 29 Apr 2022 15:20:03 +0000
Received: by outflank-mailman (input) for mailman id 317454;
 Fri, 29 Apr 2022 15:20:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkSPZ-0006x7-2i
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 15:20:02 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d4e51ca0-c7cf-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 17:19:59 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkSOj-000BaQ-FP; Fri, 29 Apr 2022 17:19:09 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4e51ca0-c7cf-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=PkGMRtr7ZOpuAUYdkK5YcnBWQgNByIkM+TF/PhPSt00=; b=McsgIEmWszU/NtZ864aphbd05/
	AA+Hs7uyIJtJtMr4867fKRnrcDZ/B0ve7meILjRDqPYrpj2SCcZq87R4becMzN/EmmpSkGxa2bXfq
	pUhMsFJRA7hiMl/hulL8uwaQ3NgTviAzyrP9F3cuPytnlSXUcQgJY1SVDx/EfT4PyEI3blubrtgBl
	Y/qFy6eJFuUH765RC4uiwWYgWdDuIIe2xttNarhTtSLeO0f5vFGPmxPe8sb1rSPH9MLQ8MhCgLKVk
	8Yh9XWbluokYf/vW7/yQXLp3HdC2BoK3CBL6+DlGPNeddie6sMCK3FiVbeA/PpCZCA2PeX8k9qatt
	P0Tqe4Tg==;
Message-ID: <31248811-d3ed-63dd-e255-c3be07fb1434@igalia.com>
Date: Fri, 29 Apr 2022 12:18:29 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list
Content-Language: en-US
To: minyard@acm.org, elder@ieee.org, Alex Elder <elder@kernel.org>,
 cminyard@mvista.com
Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
 kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
 bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
 linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org,
 linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
 netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net,
 rcu@vger.kernel.org, sparclinux@vger.kernel.org,
 xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com,
 kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com,
 alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com,
 arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com,
 dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com,
 gregkh@linuxfoundation.org, mikelley@microsoft.com,
 hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de,
 keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org,
 mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org,
 rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu,
 tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org,
 Alexander Gordeev <agordeev@linux.ibm.com>,
 Anton Ivanov <anton.ivanov@cambridgegreys.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Bjorn Andersson <bjorn.andersson@linaro.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Chris Zankel
 <chris@zankel.net>, Christian Borntraeger <borntraeger@linux.ibm.com>,
 Dexuan Cui <decui@microsoft.com>, "H. Peter Anvin" <hpa@zytor.com>,
 Haiyang Zhang <haiyangz@microsoft.com>, Heiko Carstens <hca@linux.ibm.com>,
 Helge Deller <deller@gmx.de>, Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 James Morse <james.morse@arm.com>, Johannes Berg
 <johannes@sipsolutions.net>, "K. Y. Srinivasan" <kys@microsoft.com>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Matt Turner <mattst88@gmail.com>, Mauro Carvalho Chehab
 <mchehab@kernel.org>, Max Filippov <jcmvbkbc@gmail.com>,
 Michael Ellerman <mpe@ellerman.id.au>, Paul Mackerras <paulus@samba.org>,
 Pavel Machek <pavel@ucw.cz>, Richard Henderson <rth@twiddle.net>,
 Richard Weinberger <richard@nod.at>, Robert Richter <rric@kernel.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Stephen Hemminger <sthemmin@microsoft.com>,
 Sven Schnelle <svens@linux.ibm.com>, Tony Luck <tony.luck@intel.com>,
 Vasily Gorbik <gor@linux.ibm.com>, Wei Liu <wei.liu@kernel.org>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-22-gpiccoli@igalia.com>
 <20220428162616.GE442787@minyard.net>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <20220428162616.GE442787@minyard.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 28/04/2022 13:26, Corey Minyard wrote:
> [...]
> 
> For the IPMI portion:
> 
> Acked-by: Corey Minyard <cminyard@mvista.com>

Thanks Alex and Corey for the ACKs!

> 
> Note that the IPMI panic_event() should always return, but it may take
> some time, especially if the IPMI controller is no longer functional.
> So the risk of a long delay is there and it makes sense to move it very
> late.
> 

Thanks, I agree - the patch moves it to the (latest - 1) position, since
some arch code might run as the latest and effectively stops the machine.
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 15:28:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 15:28:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317459.536795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSXw-0008Pp-13; Fri, 29 Apr 2022 15:28:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317459.536795; Fri, 29 Apr 2022 15:28:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSXv-0008Pi-UG; Fri, 29 Apr 2022 15:28:39 +0000
Received: by outflank-mailman (input) for mailman id 317459;
 Fri, 29 Apr 2022 15:28:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R1X1=VH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nkSXu-0008Pc-FN
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 15:28:38 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 09a87750-c7d1-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 17:28:36 +0200 (CEST)
Received: by mail-lj1-x236.google.com with SMTP id 4so10894013ljw.11
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 08:28:36 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 a17-20020a05651c211100b0024f3d1daeffsm296467ljq.135.2022.04.29.08.28.35
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 29 Apr 2022 08:28:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09a87750-c7d1-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=bhq9Edgd4TreDu6ZZX1wON0xSU1SZwVBqK/SEM+ml3E=;
        b=B3xMcLPAdNIn9uq2hakHPIlS8jvWBspKPqlkNh7vmKOaxKyaL3MczjXBPc9hVIXgb1
         SlB7eFrdt9btBjddlOdddK+/PmXIeU3GNfb8PNgtu+RtZWanbwMO8BJlHjIEMhfmyu/T
         Yz9yA4QKZjJ0yuLILO6MXxuVhhMZC27HA09vKdW5kBBW03uApgo+MylQXsOBwVr/Av/O
         WCZXKN5nHBdMVFcX7SWG+NB5ndonYXbRPW1G1aTeJNvNvL24WQsXVfK0szPmNTtarEjx
         5cQ5QxyNDKEDTiWR9DzKsYLtudCV/5shn5aipbTP45CTmfARLAAmoL6iXuGUHzwn8TS+
         6WeA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=bhq9Edgd4TreDu6ZZX1wON0xSU1SZwVBqK/SEM+ml3E=;
        b=bVCGcNrqiv2LEHlfvohHcMqBY3jXfAnnbw8/fvCQRiu9trgfvGzQqi41135e89LlvF
         6MQxNGCNYbPlHuwxKC7Z1ZaACYmMoQ26r+/wwcT7uF7f3BDvwW31gEUD4m6LocRb9+Gj
         +NMjB/RP5J+xHujcO/o3q+dOBzTwktiS+sHxS99As3AbXC2CzSrbUTXhdDnJThfz/V78
         xweLygTP3q/gejNxLfpj5p5EuQgiEr5zpGTvWUglZn+x9ty2jEe+SMKDTb+Sg3vrfnK1
         3+AIV5eukvHi1xZFU4ZIAP3LfUwahtDHAe51mA2NlfOdwzYsuPJ8ZshU4Kl1zcpdhO/C
         dAsA==
X-Gm-Message-State: AOAM532Fo2kcZ+aDzLlWUpO+wqbqsA+okTQd9+ENpPaaulrVZVxpZIr4
	0ajX5ITKtPy+nkyhlly8yJU=
X-Google-Smtp-Source: ABdhPJwohhuXeqggDcgYROZEOtgIKa51kUFPDtQnKaRDo5KPeapt3KOaEM3V1qCKDEH1jMSMEdtQUA==
X-Received: by 2002:a2e:87cb:0:b0:24f:81c:8940 with SMTP id v11-20020a2e87cb000000b0024f081c8940mr20554318ljj.423.1651246116210;
        Fri, 29 Apr 2022 08:28:36 -0700 (PDT)
Subject: Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use
 INVALID_GRANT_REF
From: Oleksandr <olekstysh@gmail.com>
To: Juergen Gross <jgross@suse.com>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20220428082743.16593-1-jgross@suse.com>
 <20220428082743.16593-9-jgross@suse.com>
 <CAPD2p-nisRgMOzy+w2jx5ULfZTyv4MqtG0wkV9jNn3wNg415sQ@mail.gmail.com>
Message-ID: <b05fe983-8f9e-da3d-1bf0-e121ba969ae3@gmail.com>
Date: Fri, 29 Apr 2022 18:28:34 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAPD2p-nisRgMOzy+w2jx5ULfZTyv4MqtG0wkV9jNn3wNg415sQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hello Juergen


On 28.04.22 21:03, Oleksandr Tyshchenko wrote:
>
>
> On Thu, Apr 28, 2022 at 11:28 AM Juergen Gross <jgross@suse.com 
> <mailto:jgross@suse.com>> wrote:
>
> Hello Juergen
>
> [sorry for the possible format issue]
>
>     Instead of using a private macro for an invalid grant reference use
>     the common one.
>
>     Signed-off-by: Juergen Gross <jgross@suse.com
>     <mailto:jgross@suse.com>>
>     ---
>      drivers/xen/xen-front-pgdir-shbuf.c | 17 ++++-------------
>      1 file changed, 4 insertions(+), 13 deletions(-)
>
>     diff --git a/drivers/xen/xen-front-pgdir-shbuf.c
>     b/drivers/xen/xen-front-pgdir-shbuf.c
>     index a959dee21134..fa2921d4fbfc 100644
>     --- a/drivers/xen/xen-front-pgdir-shbuf.c
>     +++ b/drivers/xen/xen-front-pgdir-shbuf.c
>     @@ -21,15 +21,6 @@
>
>      #include <xen/xen-front-pgdir-shbuf.h>
>
>     -#ifndef GRANT_INVALID_REF
>     -/*
>     - * FIXME: usage of grant reference 0 as invalid grant reference:
>     - * grant reference 0 is valid, but never exposed to a PV driver,
>     - * because of the fact it is already in use/reserved by the PV
>     console.
>     - */
>     -#define GRANT_INVALID_REF      0
>     -#endif
>     -
>      /**
>       * This structure represents the structure of a shared page
>       * that contains grant references to the pages of the shared
>     @@ -83,7 +74,7 @@ grant_ref_t
>      xen_front_pgdir_shbuf_get_dir_start(struct xen_front_pgdir_shbuf
>     *buf)
>      {
>             if (!buf->grefs)
>     -               return GRANT_INVALID_REF;
>     +               return INVALID_GRANT_REF;
>
>             return buf->grefs[0];
>      }
>     @@ -142,7 +133,7 @@ void xen_front_pgdir_shbuf_free(struct
>     xen_front_pgdir_shbuf *buf)
>                     int i;
>
>                     for (i = 0; i < buf->num_grefs; i++)
>     -                       if (buf->grefs[i] != GRANT_INVALID_REF)
>     +                       if (buf->grefs[i] != INVALID_GRANT_REF)
>     gnttab_end_foreign_access(buf->grefs[i], 0UL);
>             }
>             kfree(buf->grefs);
>     @@ -355,7 +346,7 @@ static void backend_fill_page_dir(struct
>     xen_front_pgdir_shbuf *buf)
>             }
>             /* Last page must say there is no more pages. */
>             page_dir = (struct xen_page_directory *)ptr;
>     -       page_dir->gref_dir_next_page = GRANT_INVALID_REF;
>     +       page_dir->gref_dir_next_page = INVALID_GRANT_REF;
>      }
>
>      /**
>     @@ -384,7 +375,7 @@ static void guest_fill_page_dir(struct
>     xen_front_pgdir_shbuf *buf)
>
>                     if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) {
>                             to_copy = grefs_left;
>     -                       page_dir->gref_dir_next_page =
>     GRANT_INVALID_REF;
>     +                       page_dir->gref_dir_next_page =
>     INVALID_GRANT_REF;
>
>
> I faced an issue with testing PV Sound with the current series.
>
> root@salvator-x-h3-4x2g-xt-domu:~# aplay /media/MoodyLoop.wav
> Playing WAVE '/media/MoodyLoop.wav' : Signed 16 bit Little Endian, 
> Rate 44100 Hz, Stereo
> (XEN) common/grant_table.c:1053:d1v2 Bad ref 0xffffffff for d6
>
> Here we have an interesting situation. PV Sound frontend uses this 
> xen-front-pgdir-shbuf framework. Technically, this patch changes 
> page_dir->gref_dir_next_page (reference to the next page describing 
> page directory) from 0 to 0xffffffff here.
> #define INVALID_GRANT_REF  ((grant_ref_t)-1)
>
> But according to the protocol (sndif.h), "0" means that there are no 
> more pages in the list and the user space backend expects only that 
> value. So receiving 0xffffffff it assumes there are pages in the list 
> and trying to process...
> https://elixir.bootlin.com/linux/v5.18-rc4/source/include/xen/interface/io/sndif.h#L650
>
>
> I think, the same is relevant to backend_fill_page_dir() as well.


In addition to what I said yesterday:

PV Display also uses this xen-front-pgdir-shbuf framework. It's protocol 
(displif.h) also mentions the same as sndif.h if the context of 
gref_dir_next_page:

  * gref_dir_next_page - grant_ref_t, reference to the next page describing
  *   page directory. Must be 0 if there are no more pages in the list.


With that local change both PV devices work in my environment.

diff --git a/drivers/xen/xen-front-pgdir-shbuf.c 
b/drivers/xen/xen-front-pgdir-shbuf.c
index fa2921d..ad4a88e 100644
--- a/drivers/xen/xen-front-pgdir-shbuf.c
+++ b/drivers/xen/xen-front-pgdir-shbuf.c
@@ -346,7 +346,7 @@ static void backend_fill_page_dir(struct 
xen_front_pgdir_shbuf *buf)
         }
         /* Last page must say there is no more pages. */
         page_dir = (struct xen_page_directory *)ptr;
-       page_dir->gref_dir_next_page = INVALID_GRANT_REF;
+       page_dir->gref_dir_next_page = 0;
  }

  /**
@@ -375,7 +375,7 @@ static void guest_fill_page_dir(struct 
xen_front_pgdir_shbuf *buf)

                 if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) {
                         to_copy = grefs_left;
-                       page_dir->gref_dir_next_page = INVALID_GRANT_REF;
+                       page_dir->gref_dir_next_page = 0;
                 } else {
                         to_copy = XEN_NUM_GREFS_PER_PAGE;
                         page_dir->gref_dir_next_page = buf->grefs[i + 1];
(END)



>
>                     } else {
>                             to_copy = XEN_NUM_GREFS_PER_PAGE;
>                             page_dir->gref_dir_next_page =
>     buf->grefs[i + 1];
>     -- 
>     2.34.1
>
>
>
>
> -- 
> Regards,
>
> Oleksandr Tyshchenko

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 15:47:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 15:47:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317469.536806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSq9-0002PC-Nm; Fri, 29 Apr 2022 15:47:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317469.536806; Fri, 29 Apr 2022 15:47:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSq9-0002P5-Kn; Fri, 29 Apr 2022 15:47:29 +0000
Received: by outflank-mailman (input) for mailman id 317469;
 Fri, 29 Apr 2022 15:47:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkSq8-0002Ov-06; Fri, 29 Apr 2022 15:47:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkSq7-0002sn-UU; Fri, 29 Apr 2022 15:47:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkSq7-0000AH-IW; Fri, 29 Apr 2022 15:47:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkSq7-0004O8-I3; Fri, 29 Apr 2022 15:47:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FxSmBYgnW9tqPXeMXGiluuyMUFdCFJVGlTMHEnmg05k=; b=L8XcStPmd5e2ck5j4fCGSjbFY3
	pPV9qjlIwTHmSsGze2w7a2XfOjL9Ccsh3Q3JltS8udsLu+qLbyAZwEJHRUkgFTwbh69mINRVEHc0c
	VrfyJgonXCdNOMhQbvTl8M6XLeqf6lBnL5pXx/ep3rCuahh2v8/Xo7yJUOtL+/d6nOxc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169868-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169868: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 15:47:27 +0000

flight 169868 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169868/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  695 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 15:49:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 15:49:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317477.536817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSsW-0002zr-72; Fri, 29 Apr 2022 15:49:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317477.536817; Fri, 29 Apr 2022 15:49:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkSsW-0002zk-2X; Fri, 29 Apr 2022 15:49:56 +0000
Received: by outflank-mailman (input) for mailman id 317477;
 Fri, 29 Apr 2022 15:49:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkSsU-0002ze-Tg
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 15:49:55 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0141dc46-c7d4-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 17:49:52 +0200 (CEST)
Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 11:49:49 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by BYAPR03MB4853.namprd03.prod.outlook.com (2603:10b6:a03:138::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr
 2022 15:49:47 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 15:49:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0141dc46-c7d4-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651247392;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=gfm93Iow1XlI7W8OE9eMiTHaj1VPxEntJ+JhVXCXesA=;
  b=Ag/3+SuM6TQdzJ7qI4Jny4y88zk10EqHQyW5sm4xj+w9jXtb0+SaRD95
   LDfKndZF89ZUuEBbdlr6vKp4llMj6pwoMdIl9MNUBWEVAE7pm3kVQifaT
   UQ9JicZC0i4YGKrOMqmyIJ3z93qcn49g1iceTt9ocIH9E98mMfzqjczNx
   U=;
X-IronPort-RemoteIP: 104.47.57.168
X-IronPort-MID: 70126961
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:2oUmzKL2EzfG3NMZFE+RpZQlxSXFcZb7ZxGr2PjKsXjdYENShDRUz
 DRNUTyHMqmLYmanKdB+b9nk9RgOvsDRx4JjSFZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh3tQ52YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PhQq9++Ey4sApeSgeQQbR50HX9MLaITrdcrIVDn2SCS52vvViK1htlLUgQxN4Be/ftrC2ZT8
 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM+FGvuajTNb9G5YasRmB/HRa
 tBfcTNyRB/BfwdOKhEcD5dWcOKA2SGmKWMJ9gv9Sawfxnfu4i4rjZ7XDf3nJseTWvVqnl6Ju
 TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCn1m71mEVThoMWjOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1iPwQPJVGuw+rQ2IlKzd5l/AAnBeF2ARLts7qMUxWDomk
 EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw=
IronPort-HdrOrdr: A9a23:KR5nV636yZe05OSioeWmCAqjBSFyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtrp
 uIEJIOdOEYb2IK6voSiTPQe7hA/DDEytHPuQ639QYRcegAUdAF0+4WMHf4LqUgLzM2f6bRWa
 Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUITA9OL8y7pvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt
 //Q9pVfYF1P7ArhJ1GdZY8qOuMexvwqEH3QRSvyWqOLtB1B1v977jK3Z4S2MaGPLQ18bpaou
 WybLofjx95R37T
X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; 
   d="scan'208";a="70126961"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T0at7XvN6Dsj1W8u+FhSV8AdTmzu7cBAP4uYhhowny7MsM8jzEMyjhoJPBeSG3VchZ1Sqhq2YnQgEETQkgf9IdyccXWCp/KsUzS2sXo99Hf94FyXhYi91dp8TwPIbFxYCypplnZ+OgFMWu1GJJm1ujOkDm8mxLCDiHSyba0+XJ8/CWvh1Mty1zoAMrgiB2hSFmjtaciZFjWjkBGGCitPIY0JfRnMNSYv+H/N/2mbR2V/USPi2cvzhuMfCIl2APQTtBdeoSh+S2QXap0T14lpfInaBM93jFHsOX55RjgBW3zK7PVGkP59RV6nfM0fRlU91KIG+tu36gXog2kwcJbTDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BqwtYr9MbPq26BhjSG4A0OamkZZIVBOEQ7KVXnMEnCY=;
 b=hPGzwDExYT7yhZZ6wRX3+OUDSYiKVyFOoHjp35EXwI4sxTl5XFgaY5pFkufvcxyrLunn0cP8IYjhr+gnGjPuRhbmNXiB0Z2RjkS4K1eIg7eADEswDsUYhX9qVbR2vKIVPsXQu0IbGiYXov/CaK9IDT/Xvl3A0bweVADQgIgN0WOnmoEZ3GF5Bhtt70ZWTxXKWhkE4u6/XQNI0xaSn71r7j9Ip6+edtrCkxGrwDvwuN9+Y9R3erlgWfjxMYHd51BfO0bbPhNx5C7ORFhsKMoJw4ifzXXt7Z7UYwT54KvVXjhEzcuH0i/OmCaeYeyYyq0wGy3viLf5ZL90eXpY6Ehiqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BqwtYr9MbPq26BhjSG4A0OamkZZIVBOEQ7KVXnMEnCY=;
 b=JxgEd2EgHqg9kygohNS9w0Zb5vXz/ItmAVhZluDlKVopEca8GxOkZhp/bOgIGVLGwtBd+tZ7mXhWd+tEOXT45ceQWe1fiOirqeJlpDshl1Rnx4vD6PqvXDgE9n/4FU1/oHy1SdqNVdnkeVEe9bptlngNHfbXauJ8b10zUHp3xBE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 17:49:42 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Message-ID: <YmwJFqcfOX8oFcyI@Air-de-Roger>
References: <20220427104718.81342-1-roger.pau@citrix.com>
 <20220427104718.81342-4-roger.pau@citrix.com>
 <38f0e56e-f72f-698f-c4c3-5973ec9e46a3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <38f0e56e-f72f-698f-c4c3-5973ec9e46a3@suse.com>
X-ClientProxiedBy: LO4P123CA0194.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8a0c71c5-201d-4027-ec24-08da29f7e35f
X-MS-TrafficTypeDiagnostic: BYAPR03MB4853:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<BYAPR03MB4853252B9CBDA25A9D1AB34F8FFC9@BYAPR03MB4853.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LjPf4BcYJJH/lwFfHhBrsqki5YyGnBYPJ5lk30OmG0szc2V2ZxYvPuC8JJyQEviSTRAilHvpQ9lecEKVtFURMf8tpgoLQC2ZFZuFXwlA2CzHMn1PjM/hGB/uJbvF8J2aWrCFgfS54s1aIu5atpCBaZPBcD3CsWhlUFjhS8q7IeQfxpzMkyJ1FpkEWpyCUzPqIJm27zrPl6ckkhStlYqOYfRw0ylnPmEGNO5dlH7qvH8141i3ITSBT1ggx+a8idjBQ9e8r2wKDuNO3oSejCPV5VOfn/h/dbcKavsriQozGJuawSPW7lD33kQv/8/QARgd3G+Rp+o3P41XC0C0I9EMG62QmfO3Oq8x+DdJlSj+hAT3tbBppKX2r0IzQYu1q5O9hK3uqOBMuvTd5P5OcRePw4sNMTJyVctfUpJKnrDg6EDtbzRkzXlUsvGZU18dxwhP9eT1SAjvxlbVpjwBMAgMNXHwIUpCwMZzLlp31uD1sIDbTIO9fravRJOJQ4KJxQ40YvWRG2ilf44WwhoftnhvtkxzZlQbLEkxlYVwb3QW3piCQGpZzAvwqWAzCX1Zv76lMXDeIdkQxvvL4n+KZ1iLyf93lh5XhwV4Vbo975t2eB5kyIf9hLzCqEa0VNm0y2CyPoOm9HCP9eZtbAuhqzmbpQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(26005)(82960400001)(4326008)(316002)(66556008)(6666004)(66946007)(6512007)(5660300002)(8936002)(33716001)(2906002)(86362001)(38100700002)(508600001)(6486002)(54906003)(66476007)(8676002)(83380400001)(9686003)(6916009)(186003)(6506007)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OEt3UUxRMVFWQzRSR3R4ZkJJeGNxYU5LN0lIa1dDVGtycVJiMEVEVzd3RVRw?=
 =?utf-8?B?cldqMWRkWks2ckhGOXU0Nmh0cHZBbStkYzJNMUhZMEVPcDUvbVlVblFHUk5U?=
 =?utf-8?B?V1ZRVWVNc1hDcGNjbUZCNWpQUnI4NmdGeFNqQXgzTUNQR1F0MXVFQWUvMFRz?=
 =?utf-8?B?ZENFNW1lMEluMEdBSGFONVRPKzF5VmlaeWplTHZGQkZMeFBBSVkvWDRHMXdM?=
 =?utf-8?B?L2tIaDhhUEFQeC9FZ0xoWGowTGdWNGtUWGZON2o0aDBFdlorRnFrTGtWTGIx?=
 =?utf-8?B?eE9xWldhaEtHcHlTZWdlWEx6M3AzbUFDbHQvcDBpMnpudFF1YVE1OE5Wa0NV?=
 =?utf-8?B?ZWhCMWF5aVBTdWlRYldWNUNxOXJBRzM3L1pibitQNG41OWR4SGpJRUZlTXJJ?=
 =?utf-8?B?dnhhb0QvUTRTN3dNNmFDR01aTURYRjFoWm02OVBzNmthUFVoMUlHLzF4TjJS?=
 =?utf-8?B?OWpLc1EwRjJ0bnI5V09jTmIwU3hFYkNvYTZRMHZpakJWTVBocDZuSXVNOGg3?=
 =?utf-8?B?S3RRSkFlTWFwRWJ4RW5TenFidDNTbk5KdEQzVDBIMktsMlNCZ1pBOFY0aSs4?=
 =?utf-8?B?M0xmVE9GYnZDcnlvTm5XSUpWZk1ZM3NQYlYzemVqOTN5SSt4bStockw2WmVF?=
 =?utf-8?B?bnA4MTNjN3RGQ0dxRXo5T1RsSUpQRlNhdmlNcmtHRDZ0U2VadVo1TVg3b0hw?=
 =?utf-8?B?YVFycjFTRU44ZWZIOUFyRHo4S3MwWWV4Yk1hamxkY3kyQzdldDVqMlN4aUZV?=
 =?utf-8?B?K1FmYVc2M1VWZDNwWlZHdUxxbmRZZytZREFLVkdBMWlTMnZSTmJoc3crUmU3?=
 =?utf-8?B?enptbGV2TCs2UVVJOEMvSjJJWG1FK3JERU1DZHZEYXZ4dWVITUJiKzc1N3J3?=
 =?utf-8?B?YW1meUwrOHpoNTBtaDNUWkkxaUh6TG5WSFFKeDhIdU1yYzliMFVHU1N1Mnp1?=
 =?utf-8?B?TmQ5VGlIcGU4eHQ3SWdzT00yRkhWdmlzMU5saWxzVkJmRmo2Mk1ST20vWU5Y?=
 =?utf-8?B?SjNwUmhUNzYzSWtCbTVoWXBkaWRaS3JMbXRKYVB6VVhhcitxZnBWVzllak5K?=
 =?utf-8?B?QzZ1VUpqdDY1c00xcjRRVFB5cTBTQTJOZkdPL2luTGtQR1BrOXVCOXpyVXpZ?=
 =?utf-8?B?RmZKUXFqVFF1eDRqMVVLZG4vM1JzTFlYdkV4M25VWXRWS2gxaldGanpQU3Rh?=
 =?utf-8?B?T01tZFBudWMwOENSbldLaFVaWEpGUWpib1F6T0lwQjB1bUhCOVJYajJrbXF4?=
 =?utf-8?B?OEozMzhZRForTEhCN01yU3hLdjByWmMrRkltVDlWSldXOU9hOUd1TUFVUEpz?=
 =?utf-8?B?Tk8yRm9qMndORVBlb2RSdnJ5VytXdkpVdFdHM2pGNkJORy9mejNCUzlYZ0oz?=
 =?utf-8?B?WFlvdWRrem8zcWZrSnU0dmx6Ky9TYS9xNGdnSnhVQURFRjNzWkloVWxrdXl0?=
 =?utf-8?B?VElEbFFJT2xBR0hFQU5POE1lRElSbXUyMVNKcDREUmlJSDM4RzI5WW1jSzJF?=
 =?utf-8?B?Rk9vK3dWUXZhYnl5NHFHbU96dEVrNW0xWEdPNUZFT0ozRDRXNnA4UEwvQTlJ?=
 =?utf-8?B?dnhueS91THNjL3hHZ21XeDRTdysvbU1mZ3pBQ3hUMWovOUc2T1pkZTc3ZklK?=
 =?utf-8?B?aEg1Szkrb0ZQQitpRXlkZFdzQ3p1MkZ4YndZK3lvaXlmTVkvZENWM21oS0x2?=
 =?utf-8?B?bUpIUkJ6aXM2VWRhUDhEV2w5dXhqc3duNGdCMGNYTlZnTTk4eUtLRFphVUNx?=
 =?utf-8?B?NmZDcXZLL1B5VWI3MHlrcHVKTEhxMTF6NGdCUTZzbUxFMDI1VHJ5Vmdrem1S?=
 =?utf-8?B?VGRvdVo4U2p5L1NVclc2dU5MWWgxTmpHUnRzKzZWWWFEQ2lHWTE3R2JlWXFa?=
 =?utf-8?B?KzRHOUE5MDhNQ0tJcDBFbldsZW9vaTRQbkZub3E0TjFyMXVXY1FMeWZrSWMv?=
 =?utf-8?B?aTZHK3RFOHNwbGV2bldsVDFPZXRGUDE3R2k5dkh6dkZKNGgxQjFYSHNPbGFl?=
 =?utf-8?B?NGNwLzI3ZGtNRFJzaXJiaURsK1UwSnN1TEpYblpuMUV2Tk1ibU96UjJIUDRk?=
 =?utf-8?B?cDBld3AxWTFac2VWeHdKSzFacmE4Z1JucE0zWlhuenZhZ1FpUzlXNnF1WURY?=
 =?utf-8?B?cS9GL0NYZmIvK0hhRm02bVlVRnptYlhXMVhpQzM5blRKMzZQQTJMdnBra3RS?=
 =?utf-8?B?ZklWSGhEaUorbzZ0N21rMld5STNKOCtKTTBtb0UrNklVdVE5c1NYTE9sazM4?=
 =?utf-8?B?cTIydUt4SWkxb0dRMzR0bk96NVNMTTJ1TmczK0VTMytsN3NSdW45aTRpeXhC?=
 =?utf-8?B?TUJMRktqVUgreStYZ1k5RUx1OTBJQitSRGZESXBaVFZZRWlpN3JFQT09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a0c71c5-201d-4027-ec24-08da29f7e35f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 15:49:47.6440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JZLrAmzYU+53xWmredixELGe7Ld5eFCG2G0A5GCDW/BkDoHxCUOSQLqPHEaeMfEAILJUEaSLnbLmKRY2znhkIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4853

On Fri, Apr 29, 2022 at 12:59:58PM +0200, Jan Beulich wrote:
> On 27.04.2022 12:47, Roger Pau Monne wrote:> Changes since v3:>  - Align ssbd per-core struct to a cache line.>  - Open code a simple spinlock to avoid playing tricks with the lock>    detector.>  - s/ssbd_core/ssbd_ls_cfg/.>  - Fix log message wording.>  - Fix define name and remove comment.>  - Also handle Hygon processors (Fam18h).>  - Add changelog entry.
> What is this last line about?

Hm, seems like I forgot to do a patch refresh... So new version will
have an entry about adding VIRT_SSBD support to HVM guests. Sorry for
spoiling the surprise.

> > +bool __init amd_setup_legacy_ssbd(void)
> > +{
> > +	unsigned int i;
> > +
> > +	if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) ||
> > +	    boot_cpu_data.x86_num_siblings <= 1)
> > +		return true;
> > +
> > +	/*
> > +	 * One could be forgiven for thinking that c->x86_max_cores is the
> > +	 * correct value to use here.
> > +	 *
> > +	 * However, that value is derived from the current configuration, and
> > +	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
> > +	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
> > +	 */
> > +	if (boot_cpu_data.extended_cpuid_level >= 0x80000008) {
> > +		ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
> > +		ssbd_max_cores /= boot_cpu_data.x86_num_siblings;
> > +	}
> > +	if (!ssbd_max_cores)
> > +		return false;
> > +
> > +	ssbd_ls_cfg = xzalloc_array(struct ssbd_ls_cfg,
> > +	                            ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS);
> > +	if (!ssbd_ls_cfg)
> > +		return false;
> > +
> > +	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
> > +		/* Record initial state, also applies to any hotplug CPU. */
> > +		if (opt_ssbd)
> > +			ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings;
> 
> Perhaps flip if() and for()?

Indeed, thanks.

> > +void amd_set_legacy_ssbd(bool enable)
> > +{
> > +	const struct cpuinfo_x86 *c = &current_cpu_data;
> > +	struct ssbd_ls_cfg *status;
> > +
> > +	if (c->x86 != 0x17 || c->x86_num_siblings <= 1) {
> > +		BUG_ON(!set_legacy_ssbd(c, enable));
> > +		return;
> > +	}
> > +
> > +	BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS);
> > +	BUG_ON(c->cpu_core_id >= ssbd_max_cores);
> > +	status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores +
> > +	                      c->cpu_core_id];
> > +
> > +	/*
> > +	 * Open code a very simple spinlock: this function is used with GIF==0
> > +	 * and different IF values, so would trigger the checklock detector.
> > +	 * Instead of trying to workaround the detector, use a very simple lock
> > +	 * implementation: it's better to reduce the amount of code executed
> > +	 * with GIF==0.
> > +	 */
> > +	while ( test_and_set_bool(status->locked) )
> > +	    cpu_relax();
> > +	status->count += enable ? 1 : -1;
> > +	ASSERT(status->count <= c->x86_num_siblings);
> > +	if (enable ? status->count == 1 : !status->count)
> > +		BUG_ON(!set_legacy_ssbd(c, enable));
> 
> What are the effects of ASSERT() or BUG_ON() triggering in a GIF=0
> region?

So AFAICT the BUG itself works, the usage of a crash kernel however
won't work as it's booted with GIF==0.

Maybe we need to issue an stgi as part of BUG_FRAME if required?
(maybe that's too naive...)

> > --- a/xen/arch/x86/cpuid.c
> > +++ b/xen/arch/x86/cpuid.c
> > @@ -544,6 +544,16 @@ static void __init calculate_hvm_max_policy(void)
> >      if ( !boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
> >          /* Clear VIRT_SSBD if VIRT_SPEC_CTRL is not exposed to guests. */
> >          __clear_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
> > +    else
> > +        /*
> > +         * Expose VIRT_SSBD if VIRT_SPEC_CTRL is supported, as that implies the
> > +         * underlying hardware is capable of setting SSBD using
> > +         * non-architectural way or VIRT_SSBD is available.
> > +         *
> > +         * Note that if the hardware supports VIRT_SSBD natively this setting
> > +         * will just override an already set bit.
> > +         */
> > +        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
> 
> With the 's' annotation gone from the public header, is this last
> sentence of the comment actually true? Aiui code near the top of
> the function would have zapped the bit from hvm_featureset[].

This comment is now gone, and there are no changes to
calculate_hvm_max_policy in this patch anymore.

> > --- a/xen/arch/x86/hvm/svm/svm.c
> > +++ b/xen/arch/x86/hvm/svm/svm.c
> > @@ -3126,6 +3126,8 @@ void vmexit_virt_spec_ctrl(void)
> >  
> >      if ( cpu_has_virt_ssbd )
> >          wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
> > +    else
> > +         amd_set_legacy_ssbd(opt_ssbd);
> 
> Nit: Indentation is off by one here. Of course this alone could
> easily be adjusted while committing.
> 
> > @@ -3138,6 +3140,9 @@ void vmentry_virt_spec_ctrl(void)
> >  
> >      if ( cpu_has_virt_ssbd )
> >          wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, 0);
> > +    else
> > +        amd_set_legacy_ssbd(current->arch.msrs->virt_spec_ctrl.raw &
> > +                            SPEC_CTRL_SSBD);
> 
> Would seem cheaper to use !val here (and then val for symmetry in
> the other function).

I could even use !opt_ssbd, and that would be more similar to what's
done in vmexit_virt_spec_ctrl?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:04:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:04:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317484.536828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkT70-0005rk-Fv; Fri, 29 Apr 2022 16:04:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317484.536828; Fri, 29 Apr 2022 16:04:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkT70-0005rd-CP; Fri, 29 Apr 2022 16:04:54 +0000
Received: by outflank-mailman (input) for mailman id 317484;
 Fri, 29 Apr 2022 16:04:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Wc9h=VH=gmail.com=jcmvbkbc@srs-se1.protection.inumbo.net>)
 id 1nkT6z-0005rV-4i
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 16:04:53 +0000
Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com
 [2607:f8b0:4864:20::235])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19dde46a-c7d6-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 18:04:52 +0200 (CEST)
Received: by mail-oi1-x235.google.com with SMTP id l203so9020820oif.0
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 09:04:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19dde46a-c7d6-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=MQcZ21ZXrJjtfh7JWVyd82OFreqrUf57vyzG9uXB95s=;
        b=NQuHjq75yTcETqoe5MFxchlZ/6p7R23s4Uh/eK6M8cjCLKjgK4aZLK94enM9k42z9z
         9olN5ZP+vAQmeXTs3TpSIt0NzvMdqABegG4qz96TEt/HS/xzZxrOdtT3s38HXa8rxQCC
         //y1nGWR49pl0bI4BXJikvhyEOuRN9x7yyhQG6wmlGrFanhXAWznrpMOX2TZU06+jYUn
         nIWU94QXvKkXMgCPv2tcj5gD6bKy2psqRCjrFUOKa8Bl/tDHLN4JOX0rshY1mFgS6Dj8
         yb9QNW2JBzYk707yzx4X/QadG8x7UesXEXLRQ21ibqXwVr/gFDYqh338pCxNErks0fTt
         i5PQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=MQcZ21ZXrJjtfh7JWVyd82OFreqrUf57vyzG9uXB95s=;
        b=bpLrP6bJwl13mwe9N1viAlqkadMQpqrWJoPw6Df/cOA6EU8QusQKHjNnts3DQ+9iIC
         yoGOBgSrVno4ydiTerNXn3i3H7dQv62I2ryB97ibYcbcLr4SfraYOlmCtlh6zSyvedN4
         SQSEg90R+pjjq/nT1W0qBDPsaNx5HYTsSPUr0RdCvvrXWrSc/yldzHBiI0okotdgBv4L
         e+WxJQ38jjOFcCf54tKCCjlace4D98vU9kBPauROZRDDABqCJ06TzYICDGirGmz+skEg
         WYYqqSdjrPmarGY19pYoE1CGyt9VkoCyuVIp4oFWFhTy0x/tMUJhzG3VrOX2N0b/tZh6
         RGjg==
X-Gm-Message-State: AOAM533QOq3G9Ux6L6OoIc0EG3pvP/O1uO1iY6tJ0bA4WXiFOx/krpWE
	VmkrZ/zILQ8ae5rnD8bAWVds1ttWAzbhXJ2FYwM=
X-Google-Smtp-Source: ABdhPJysHLlZfOKGv6xFakU0zwsYHpphdLaC+QwvkTPAsD1DKrMZHBdjgWt7xXjXQ23jsIbpf+qT2AhQ4uRAgVD8DGA=
X-Received: by 2002:a05:6808:1202:b0:2f9:c7b4:fd56 with SMTP id
 a2-20020a056808120200b002f9c7b4fd56mr15139oil.55.1651248290317; Fri, 29 Apr
 2022 09:04:50 -0700 (PDT)
MIME-Version: 1.0
References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com>
In-Reply-To: <20220427224924.592546-22-gpiccoli@igalia.com>
From: Max Filippov <jcmvbkbc@gmail.com>
Date: Fri, 29 Apr 2022 09:04:39 -0700
Message-ID: <CAMo8BfKzA+oy-Qun9-aO3xCr4Jy_rfdjYqMX=W9xONCSX8O51Q@mail.gmail.com>
Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, bhe@redhat.com, 
	Petr Mladek <pmladek@suse.com>, kexec@lists.infradead.org, 
	LKML <linux-kernel@vger.kernel.org>, bcm-kernel-feedback-list@broadcom.com, 
	coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, 
	"open list:ALPHA PORT" <linux-alpha@vger.kernel.org>, linux-arm-kernel@lists.infradead.org, 
	linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, 
	linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, 
	"open list:PARISC ARCHITECTURE" <linux-parisc@vger.kernel.org>, linux-pm@vger.kernel.org, 
	linux-remoteproc@vger.kernel.org, linux-s390 <linux-s390@vger.kernel.org>, 
	linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, 
	"open list:TENSILICA XTENSA PORT (xtensa)" <linux-xtensa@linux-xtensa.org>, netdev <netdev@vger.kernel.org>, 
	openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, 
	"open list:SPARC + UltraSPAR..." <sparclinux@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>, kernel-dev@igalia.com, kernel@gpiccoli.net, 
	halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>, 
	Borislav Petkov <bp@alien8.de>, Jonathan Corbet <corbet@lwn.net>, d.hatayama@jp.fujitsu.com, 
	Dave Hansen <dave.hansen@linux.intel.com>, dyoung@redhat.com, feng.tang@intel.com, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, mikelley@microsoft.com, 
	hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, 
	Kees Cook <keescook@chromium.org>, Andrew Lutomirski <luto@kernel.org>, 
	Masami Hiramatsu <mhiramat@kernel.org>, Ingo Molnar <mingo@redhat.com>, paulmck@kernel.org, 
	Peter Zijlstra <peterz@infradead.org>, Steven Rostedt <rostedt@goodmis.org>, 
	Sergey Senozhatsky <senozhatsky@chromium.org>, stern@rowland.harvard.edu, 
	Thomas Gleixner <tglx@linutronix.de>, vgoyal@redhat.com, vkuznets@redhat.com, 
	Will Deacon <will@kernel.org>, Alex Elder <elder@kernel.org>, 
	Alexander Gordeev <agordeev@linux.ibm.com>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, 
	Benjamin Herrenschmidt <benh@kernel.crashing.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, 
	Boris Ostrovsky <boris.ostrovsky@oracle.com>, Chris Zankel <chris@zankel.net>, 
	Christian Borntraeger <borntraeger@linux.ibm.com>, Corey Minyard <minyard@acm.org>, 
	Dexuan Cui <decui@microsoft.com>, "H. Peter Anvin" <hpa@zytor.com>, 
	Haiyang Zhang <haiyangz@microsoft.com>, Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>, 
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, James Morse <james.morse@arm.com>, 
	Johannes Berg <johannes@sipsolutions.net>, "K. Y. Srinivasan" <kys@microsoft.com>, 
	Mathieu Poirier <mathieu.poirier@linaro.org>, Matt Turner <mattst88@gmail.com>, 
	Mauro Carvalho Chehab <mchehab@kernel.org>, Michael Ellerman <mpe@ellerman.id.au>, 
	Paul Mackerras <paulus@samba.org>, Pavel Machek <pavel@ucw.cz>, Richard Henderson <rth@twiddle.net>, 
	Richard Weinberger <richard@nod.at>, Robert Richter <rric@kernel.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Stephen Hemminger <sthemmin@microsoft.com>, 
	Sven Schnelle <svens@linux.ibm.com>, Tony Luck <tony.luck@intel.com>, 
	Vasily Gorbik <gor@linux.ibm.com>, Wei Liu <wei.liu@kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 27, 2022 at 3:55 PM Guilherme G. Piccoli
<gpiccoli@igalia.com> wrote:
>
> This patch renames the panic_notifier_list to panic_pre_reboot_list;
> the idea is that a subsequent patch will refactor the panic path
> in order to better split the notifiers, running some of them very
> early, some of them not so early [but still before kmsg_dump()] and
> finally, the rest should execute late, after kdump. The latter ones
> are now in the panic pre-reboot list - the name comes from the idea
> that these notifiers execute before panic() attempts rebooting the
> machine (if that option is set).
>
> We also took the opportunity to clean-up useless header inclusions,
> improve some notifier block declarations (e.g. in ibmasm/heartbeat.c)
> and more important, change some priorities - we hereby set 2 notifiers
> to run late in the list [iss_panic_event() and the IPMI panic_event()]
> due to the risks they offer (may not return, for example).
> Proper documentation is going to be provided in a subsequent patch,
> that effectively refactors the panic path.

[...]

>  arch/xtensa/platforms/iss/setup.c     |  4 ++--For xtensa:

For xtensa:
Acked-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:05:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:05:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317485.536839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkT79-0006AL-RH; Fri, 29 Apr 2022 16:05:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317485.536839; Fri, 29 Apr 2022 16:05:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkT79-0006AE-O8; Fri, 29 Apr 2022 16:05:03 +0000
Received: by outflank-mailman (input) for mailman id 317485;
 Fri, 29 Apr 2022 16:05:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkT78-0005rV-7l
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 16:05:02 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1f364bfe-c7d6-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 18:05:01 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkT6a-0001BR-MS; Fri, 29 Apr 2022 18:04:28 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f364bfe-c7d6-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=QQI5zmi1djYWNz2i53I6KuQGatDa49BWqjEk2Pav1i4=; b=dYOwdCYz8mfW6uRaErWUoCqmdx
	5T0+vzZBt6UK85jUK/bYBffPO6pHVBukVXgw40Mng8+hfEFyxsYupbDv17vw0eY73RVtJNUJhZeIk
	wjL2oPNMg0UJQkop2tznLUBtpwTgs2tJTFrh96RXyi3iI9oJ7Xg0HjOO5wFLxxatzCt/a1kjKIm+q
	GG90XSMTUteF9uAfx+0HJjQF0T7y90PJaZRFs3aM6M51tA02d53awi4I7n5GpC6cVQif5RrGFpU1r
	QhiVEfyVqroi50IPYPzYRbjvCqabrqPiHclqX4UZkfFE4tLq7njetpvB7ea+qAjYTdFscbWw6lpa8
	5AxSRVRQ==;
Message-ID: <7518924e-5bb4-e6e9-0e3e-3f5cb03bf946@igalia.com>
Date: Fri, 29 Apr 2022 13:04:01 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 24/30] panic: Refactor the panic path
Content-Language: en-US
To: Randy Dunlap <rdunlap@infradead.org>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-25-gpiccoli@igalia.com>
 <4fe85e9c-4e96-e9d5-9fd8-f062bafcda4f@infradead.org>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <4fe85e9c-4e96-e9d5-9fd8-f062bafcda4f@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 27/04/2022 21:28, Randy Dunlap wrote:
> 
> 
> On 4/27/22 15:49, Guilherme G. Piccoli wrote:
>> +	crash_kexec_post_notifiers
>> +			This was DEPRECATED - users should always prefer the
> 
> 			This is DEPRECATED - users should always prefer the
> 
>> +			parameter "panic_notifiers_level" - check its entry
>> +			in this documentation for details on how it works.
>> +			Setting this parameter is exactly the same as setting
>> +			"panic_notifiers_level=4".
> 

Thanks Randy, for your suggestion - but I confess I couldn't understand
it properly. It's related to spaces/tabs, right? What you suggest me to
change in this formatting? Just by looking the email I can't parse.

Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:10:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:10:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317499.536850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTC4-0007qR-G0; Fri, 29 Apr 2022 16:10:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317499.536850; Fri, 29 Apr 2022 16:10:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTC4-0007qK-Av; Fri, 29 Apr 2022 16:10:08 +0000
Received: by outflank-mailman (input) for mailman id 317499;
 Fri, 29 Apr 2022 16:10:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R1X1=VH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nkTC2-0007qE-UX
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 16:10:06 +0000
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com
 [2a00:1450:4864:20::12e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d505ab50-c7d6-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 18:10:05 +0200 (CEST)
Received: by mail-lf1-x12e.google.com with SMTP id j4so14867084lfh.8
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 09:10:05 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 p5-20020a19f105000000b0047221ec7b81sm270471lfh.58.2022.04.29.09.10.03
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 29 Apr 2022 09:10:04 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d505ab50-c7d6-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=Nf28pFd42ZVnx38GcwQNtFtPrZ2oJjcyAQfdnNyRvpE=;
        b=fBOD+RUJw6jb8ujbNpt4X/z3b2lEiqyBtNhbQTqnLKV1Hv5LELIt/O35QYauUOa+Y8
         yjFoGTDq8hBuP8gTnS3hLaW+iByildqbsRJmTmNUEMKI6svBxrL6Xo98iTYMLxpzAbRR
         Xg1C68nUJ8nnjOXdGtG0OUYB34rhartiXferve+7X6gHKPV0CIFqOYsHhYfBDVETmUhE
         oKvvMVMR50gSfnhWJ4ZwkoETODH4mZZT0UzDCmvZlr+aPiOr4RKevfeCBMLQUCynZWoJ
         8PjmTa1dOuBCry/6nPI9bTul5qfWzt4i5mwMIItO+yQYOIiMybZab1dkEAfMYLfVwYAX
         qLOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=Nf28pFd42ZVnx38GcwQNtFtPrZ2oJjcyAQfdnNyRvpE=;
        b=KP5DbJhgCO2HJ4ZP4PzUjTlPs/8IYhDgB0N0mQNmfMpjYjm5iu7HFPG4ESaF6ldc2r
         cbzxuwl18DHzwuEsauvpY6e/BzufFRkJiPLzkzX5h+BhYeN1mFOlTbKrVRhHFxKNJXmI
         FPYY6PioUQAUmBclb60vTfVVHbPbByWdmq7CTCbOVN7zr3WqIpf/1My2+lo1Red+1jJ2
         CD7iR/HBMQNinBYS+5JLANYpy5/yw/CCRGTlv72bWqMaXMaG3RSx+euEjAK/pUHRADbn
         ahyb69nWNamBvdCUKLPUAtubnLvb6hvoNZV+Z79iiR1p+6f0n6WhfY1BfbPLuqKbviWQ
         P+vg==
X-Gm-Message-State: AOAM531cNc167WxeeZlUtdCoLAYRkbGcINH8lKjvXTS+DPXwQoW9IVV4
	5tohI3olylCHNzy46vsvRIM=
X-Google-Smtp-Source: ABdhPJwllqzcKcjS+nPZ+FQBW2m6FasElP+Juc0817U3hQVDb/GqYyG8BJA/OSRRz6v/XNeQxQk7Ag==
X-Received: by 2002:a05:6512:1504:b0:44b:36e:b50d with SMTP id bq4-20020a056512150400b0044b036eb50dmr28105186lfb.558.1651248604731;
        Fri, 29 Apr 2022 09:10:04 -0700 (PDT)
Subject: Re: [PATCH v2 14/19] xen/drmfront: use xenbus_setup_ring() and
 xenbus_teardown_ring()
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
References: <20220428082743.16593-1-jgross@suse.com>
 <20220428082743.16593-15-jgross@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <e2e1f5c0-e78e-fa1e-bdee-54b5aeaba957@gmail.com>
Date: Fri, 29 Apr 2022 19:10:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220428082743.16593-15-jgross@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 28.04.22 11:27, Juergen Gross wrote:

Hello Juergen, all

> Simplify drmfront's ring creation and removal via xenbus_setup_ring()
> and xenbus_teardown_ring().
>
> Signed-off-by: Juergen Gross <jgross@suse.com>


I am not familiar with DRM bits of this driver, but a little bit 
familiar with Xen bits this patch only touches and I have environment to 
test.

Xen specific changes looks good to me. Also I didn't see any specific to 
this series issues when testing virtulized display driver except one I 
have already pointed out in PATCH v2 08/19.

root@salvator-x-h3-4x2g-xt-domu:~# dmesg | grep drm
[    0.158190] [drm] Registering XEN PV vdispl
[    0.159620] [drm] Connector device/vdispl/0/0: resolution 1920x1080
[    0.159888] [drm] Have 1 connector(s)
[    0.289069] [drm] Creating Xen PV DRM Display Unit
[    0.289873] [drm] Initialized xendrm-du 1.0.0 20180221 for vdispl-0 
on minor 0
[    0.289918] [drm] Initialized xendrm-du 1.0.0 20180221 on minor 0


root@generic-armv8-xt-dom0:~# xenstore-ls -f | grep vdispl
/local/domain/1/backend/vdispl = ""
/local/domain/1/backend/vdispl/2 = ""
/local/domain/1/backend/vdispl/2/0 = ""
/local/domain/1/backend/vdispl/2/0/frontend = 
"/local/domain/2/device/vdispl/0"
/local/domain/1/backend/vdispl/2/0/frontend-id = "2"
/local/domain/1/backend/vdispl/2/0/online = "1"
/local/domain/1/backend/vdispl/2/0/state = "4"
/local/domain/2/device/vdispl = ""
/local/domain/2/device/vdispl/0 = ""
/local/domain/2/device/vdispl/0/backend = 
"/local/domain/1/backend/vdispl/2/0"
/local/domain/2/device/vdispl/0/backend-id = "1"
/local/domain/2/device/vdispl/0/state = "4"
/local/domain/2/device/vdispl/0/be-alloc = "0"
/local/domain/2/device/vdispl/0/0 = ""
/local/domain/2/device/vdispl/0/0/resolution = "1920x1080"
/local/domain/2/device/vdispl/0/0/unique-id = "HDMI-A-1"
/local/domain/2/device/vdispl/0/0/req-ring-ref = "8"
/local/domain/2/device/vdispl/0/0/req-event-channel = "7"
/local/domain/2/device/vdispl/0/0/evt-ring-ref = "9"
/local/domain/2/device/vdispl/0/0/evt-event-channel = "8"
/libxl/2/device/vdispl = ""
/libxl/2/device/vdispl/0 = ""
/libxl/2/device/vdispl/0/frontend = "/local/domain/2/device/vdispl/0"
/libxl/2/device/vdispl/0/backend = "/local/domain/1/backend/vdispl/2/0"
/libxl/2/device/vdispl/0/frontend-id = "2"
/libxl/2/device/vdispl/0/online = "1"
/libxl/2/device/vdispl/0/state = "1"


It worth mentioning I noticed one issue, but I believe it is not related 
to your series.

root@salvator-x-h3-4x2g-xt-domu:~# modetest -M xendrm-du -s 31:1920x1080
[   62.431887] ------------[ cut here ]------------
[   62.431940] WARNING: CPU: 0 PID: 244 at 
drivers/gpu/drm/drm_gem.c:1055 drm_gem_mmap_obj+0x16c/0x180
[   62.432000] Modules linked in:
[   62.432025] CPU: 0 PID: 244 Comm: modetest Tainted: G W         
5.18.0-rc4-yocto-standard-00096-g936342d8fae2 #1
[   62.432067] Hardware name: XENVM-4.17 (DT)
[   62.432089] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS 
BTYPE=--)
[   62.432126] pc : drm_gem_mmap_obj+0x16c/0x180
[   62.432153] lr : drm_gem_mmap_obj+0x78/0x180
[   62.432178] sp : ffff800009da3bb0
[   62.432196] x29: ffff800009da3bb0 x28: 0000000000000008 x27: 
ffff0001c3a56780
[   62.432237] x26: ffff0001c3a56f00 x25: 00000000000007e9 x24: 
ffff0001c23dec00
[   62.432279] x23: ffff0001c0c98000 x22: ffff0001c2162b80 x21: 
0000000000000000
[   62.432320] x20: ffff0001c3a56780 x19: ffff0001c23dea00 x18: 
0000000000000001
[   62.432355] x17: 0000000000000000 x16: 0000000000000000 x15: 
000000000003603c
[   62.432394] x14: 0000000000000000 x13: 0000000000000000 x12: 
0000000000000000
[   62.432430] x11: 0000000000100000 x10: 0000ffff88071000 x9 : 
ffff0001c0f17e70
[   62.432470] x8 : ffff8001f65ce000 x7 : 0000000000000001 x6 : 
ffff0001c388a000
[   62.432505] x5 : ffff800009da3a10 x4 : 0000000000000090 x3 : 
0000000010046400
[   62.432539] x2 : 00000000000007e9 x1 : 9b0023a536f4f400 x0 : 
00000000100000fb
[   62.432579] Call trace:
[   62.432593]  drm_gem_mmap_obj+0x16c/0x180
[   62.432617]  drm_gem_mmap+0x128/0x228
[   62.432641]  mmap_region+0x384/0x5a0
[   62.432667]  do_mmap+0x354/0x4f0
[   62.432687]  vm_mmap_pgoff+0xdc/0x108
[   62.432710]  ksys_mmap_pgoff+0x1b8/0x208
[   62.432734]  __arm64_sys_mmap+0x30/0x48
[   62.432760]  invoke_syscall+0x44/0x108
[   62.432783]  el0_svc_common.constprop.0+0xcc/0xf0
[   62.432811]  do_el0_svc+0x24/0x88
[   62.432831]  el0_svc+0x2c/0x88
[   62.432855]  el0t_64_sync_handler+0xb0/0xb8
[   62.432875]  el0t_64_sync+0x18c/0x190
[   62.432898] ---[ end trace 0000000000000000 ]---
setting mode 1920x1080-60.00Hz@XR24 on connectors 31, crtc 34


Although we see that WARNING, the application still works. Looking into 
the code, I assume that problem is that frontend doesn't set the 
VM_DONTEXPAND flag in mmap callback.

This diff fixes an issue in my environment:

index 5a5bf4e..e31554d 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -71,7 +71,7 @@ static int xen_drm_front_gem_object_mmap(struct 
drm_gem_object *gem_obj,
          * the whole buffer.
          */
         vma->vm_flags &= ~VM_PFNMAP;
-       vma->vm_flags |= VM_MIXEDMAP;
+       vma->vm_flags |= VM_MIXEDMAP | VM_DONTEXPAND;
         vma->vm_pgoff = 0;

         /*


I am not 100% sure whether it is a proper fix, so I would kindly ask DRM 
folks to confirm. I will be able to send a formal patch then.


> ---
>   drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 ++++++---------------
>   1 file changed, 11 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
> index 4006568b9e32..e52afd792346 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c
> @@ -123,12 +123,12 @@ static irqreturn_t evtchnl_interrupt_evt(int irq, void *dev_id)
>   static void evtchnl_free(struct xen_drm_front_info *front_info,
>   			 struct xen_drm_front_evtchnl *evtchnl)
>   {
> -	unsigned long page = 0;
> +	void *page = NULL;
>   
>   	if (evtchnl->type == EVTCHNL_TYPE_REQ)
> -		page = (unsigned long)evtchnl->u.req.ring.sring;
> +		page = evtchnl->u.req.ring.sring;
>   	else if (evtchnl->type == EVTCHNL_TYPE_EVT)
> -		page = (unsigned long)evtchnl->u.evt.page;
> +		page = evtchnl->u.evt.page;
>   	if (!page)
>   		return;
>   
> @@ -147,8 +147,7 @@ static void evtchnl_free(struct xen_drm_front_info *front_info,
>   		xenbus_free_evtchn(front_info->xb_dev, evtchnl->port);
>   
>   	/* end access and free the page */
> -	if (evtchnl->gref != INVALID_GRANT_REF)
> -		gnttab_end_foreign_access(evtchnl->gref, page);
> +	xenbus_teardown_ring(&page, 1, &evtchnl->gref);
>   
>   	memset(evtchnl, 0, sizeof(*evtchnl));
>   }
> @@ -158,8 +157,7 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index,
>   			 enum xen_drm_front_evtchnl_type type)
>   {
>   	struct xenbus_device *xb_dev = front_info->xb_dev;
> -	unsigned long page;
> -	grant_ref_t gref;
> +	void *page;
>   	irq_handler_t handler;
>   	int ret;
>   
> @@ -168,44 +166,25 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index,
>   	evtchnl->index = index;
>   	evtchnl->front_info = front_info;
>   	evtchnl->state = EVTCHNL_STATE_DISCONNECTED;
> -	evtchnl->gref = INVALID_GRANT_REF;
>   
> -	page = get_zeroed_page(GFP_NOIO | __GFP_HIGH);
> -	if (!page) {
> -		ret = -ENOMEM;
> +	ret = xenbus_setup_ring(xb_dev, GFP_NOIO | __GFP_HIGH, &page,
> +				1, &evtchnl->gref);
> +	if (ret)
>   		goto fail;
> -	}
>   
>   	if (type == EVTCHNL_TYPE_REQ) {
>   		struct xen_displif_sring *sring;
>   
>   		init_completion(&evtchnl->u.req.completion);
>   		mutex_init(&evtchnl->u.req.req_io_lock);
> -		sring = (struct xen_displif_sring *)page;
> -		SHARED_RING_INIT(sring);
> -		FRONT_RING_INIT(&evtchnl->u.req.ring, sring, XEN_PAGE_SIZE);
> -
> -		ret = xenbus_grant_ring(xb_dev, sring, 1, &gref);
> -		if (ret < 0) {
> -			evtchnl->u.req.ring.sring = NULL;
> -			free_page(page);
> -			goto fail;
> -		}
> +		sring = page;
> +		XEN_FRONT_RING_INIT(&evtchnl->u.req.ring, sring, XEN_PAGE_SIZE);
>   
>   		handler = evtchnl_interrupt_ctrl;
>   	} else {
> -		ret = gnttab_grant_foreign_access(xb_dev->otherend_id,
> -						  virt_to_gfn((void *)page), 0);
> -		if (ret < 0) {
> -			free_page(page);
> -			goto fail;
> -		}
> -
> -		evtchnl->u.evt.page = (struct xendispl_event_page *)page;
> -		gref = ret;
> +		evtchnl->u.evt.page = page;
>   		handler = evtchnl_interrupt_evt;
>   	}
> -	evtchnl->gref = gref;
>   
>   	ret = xenbus_alloc_evtchn(xb_dev, &evtchnl->port);
>   	if (ret < 0)


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:11:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:11:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317504.536861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTDX-0008W0-PF; Fri, 29 Apr 2022 16:11:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317504.536861; Fri, 29 Apr 2022 16:11:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTDX-0008Vt-M8; Fri, 29 Apr 2022 16:11:39 +0000
Received: by outflank-mailman (input) for mailman id 317504;
 Fri, 29 Apr 2022 16:11:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IHQo=VH=citrix.com=prvs=11116ec15=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nkTDV-0008Vk-Tp
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 16:11:38 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 09f8cb76-c7d7-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 18:11:35 +0200 (CEST)
Received: from mail-bn8nam11lp2173.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Apr 2022 12:11:32 -0400
Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
 by DM8PR03MB6229.namprd03.prod.outlook.com (2603:10b6:8:24::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5186.14; Fri, 29 Apr 2022 16:11:30 +0000
Received: from DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com
 ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 16:11:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09f8cb76-c7d7-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1651248695;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=pnmiXEdkPy+j/yyXERPZ2YcxcYtBea7dAQcsZ3jmo1M=;
  b=cUbrrb8/7dxjFurPS4K7YRuXcT3ruNLN6icfLP/HKuAEWbKuNJmUhJUp
   Ayg5ZftKzyQ6np4y/MNMB2cr505TQgNUwilO/t/FQQZTf4XT+AmF/zk6u
   l5dBrlfJ/tnErfnOrEO5CsLFDLwUgdQrhD2WhvWIggDHpiersZSptadHg
   g=;
X-IronPort-RemoteIP: 104.47.58.173
X-IronPort-MID: 69646308
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:/NDqUarAfB83wlPnXTQV0fLprDxeBmJsZBIvgKrLsJaIsI4StFCzt
 garIBnXM/feNzb1LYt0boy29kwD65TTydAwTgRkriA3QSwT8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvR4
 4Kq+KUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBIL/PgKMgfEdjLyxPF78Y8+DKemGlmJnGp6HGWyOEL/RGKmgTZNRd0MAnRGZE+
 LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp2Zsm8fX2P
 qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrL9PRrvTOLnGSd1pCzM8PcIMOpXvxKl2Gdv
 UTd5Um+GVIFYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3K
 UYZ5y4vpqga71GwQ5/2WBjQiGGAlg4RXZxXCeJS1e2W4q/d4gLcDG5USDdEMYUirJVvGmds0
 UKVldT0AzApqKeSVX+W6raTq3W1JDQRKmgBIyQDSGPp/uXenW36tTqXJv4LLUJ/poed9e3Yq
 9xSkBUDug==
IronPort-HdrOrdr: A9a23:D06Iyq9VVmzpgm402Z1uk+FRdb1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO
 JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe
 ehD4d81nKdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInly6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXsIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6U9bc16UGT0vDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNId3AL3Z
 WBDk1SrsA+ciYnV9MCOA4/e7rGNoXse2O7DIvAGyWvKEk4U0i92aLf0fES2NyAXqAu4d8bpK
 nhOWkowFLaPXieRPGz4A==
X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; 
   d="scan'208";a="69646308"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XcECdsA++g/oSAh3At5bVxQPm0R03chN5+XLr9I/g0m1CHZL1wnSHhmV/dXMIulallWWmXfuZSH20Phw7B9PNfDF/2VwzyRijQ7//KrG7p7QhDI7BFe5/ty/k0BStfRULu3aQB7d+/jypeonGeaMqAvCve7L9zmVj+V/ApZ7nxqUsgIytVIcoE43eurnRR62QrOJmzbG1YX6AFHx8JPW0C+lX1nEjBMWNKcNJ1zmaBIZ9sopKt9vFrhZraO8bj9YF64IKrWRQ+EJ8EaPydOfpmSEAw1EU2t5y1qU6g3S0yoNEwOSRd6cfN5PK/JJqcIBiP44Z+Yx+REoiVfPF46Z3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2t1EP7t4LaXUWLbcjhMeSu/sj0eW1jRKE9liAsTWpIs=;
 b=DYMina32b7Gc7s3Tps36QBgaDfkjtsDT7AMZbGf5JSZeNyB8RZVQc8OiuIs64sd4TvkDRcqk2NI5prNp4zU6G4imDTv3kUdpM9dKjxxf+GiqPmh+MSFrKpKHn3RjkdxrjMQTp3Zcnt1C9zv6DOr+NZbqMOR6vrLFu3RwJs4k6pASzm+bWb6IdgqzB/2gN6hAp8rJ5iWu3OgFEHWAiYfLPqYHAjrbLNN5JpgZytGvcGMZxmaqItLpNEuREhbNcXhPmttrcpNcrfosO8vvUw36JHD+xI9Awitdgl4xYJmq/mXvdrxHdzE6tqbFkUopq5o6O5TjWyEkUW/CrDXkE+GL7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2t1EP7t4LaXUWLbcjhMeSu/sj0eW1jRKE9liAsTWpIs=;
 b=L5DQfTdVGbVYB4f9SbAgjtRyotQjFE+uy4ktZwGbnUqrrmDy0da7CjEhFwKUqbZT+re31SSJymbyaC/8mZAekRCh8/FMzB4QG71UY/NTIZG2HsuSUdgkc/epOz2gn+wIMFTEFvh5m4YHTfI8DkamV3o4FAgiuXX+BX2zcbKIRF0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 29 Apr 2022 18:11:25 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Message-ID: <YmwOLRUz/mgjOBt6@Air-de-Roger>
References: <20220427104718.81342-1-roger.pau@citrix.com>
 <20220427104718.81342-4-roger.pau@citrix.com>
 <38f0e56e-f72f-698f-c4c3-5973ec9e46a3@suse.com>
 <YmwJFqcfOX8oFcyI@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YmwJFqcfOX8oFcyI@Air-de-Roger>
X-ClientProxiedBy: LO2P265CA0465.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 11760ffd-541e-4a79-666e-08da29faebaa
X-MS-TrafficTypeDiagnostic: DM8PR03MB6229:EE_
X-MS-Exchange-AtpMessageProperties: SA|SL
X-Microsoft-Antispam-PRVS:
	<DM8PR03MB6229EC80D1A708F1B6AB319F8FFC9@DM8PR03MB6229.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jn4M/V2zfv4072o2ZDdj3gXzuQSzpnzkAWWEyJijQZlsn+0rNcuMzXzFVlhTXLVxKqPUpAl1rvRcB/Hel0VrNc98ykthTVaFyKanrUXXDOnbWCB043OrlgRHDjVv+iIu48MATkgXbD3p93czD9rfavgsB/YbDDDmaMEc5uHVIVc4YOOvCtH1zOLg/YtEXXx91pSUbLqDeuBrk5iBHvtt+WjKhtIE2FVQcbSjkqAoA8KvRgJ4+Nchrd9wFiMcjElEL6ZeT5dw6AyvLCrPG9ZwF+uxTB7ySSZkvIqhtnH5tQeFtK4t53m/9+Co4kusyRtkrkbV8KdZwnG5wQ8/FUdFw0Zzzt1h0nnn6KMaG6Tz3DsKIOspnW16sr8P/XtLSXGbkOpx8WlKZsIpL1112fwnYQnrNqoKeg4b4tSogNJLyDNtXtIAIp05UCHt2M3ne/QyCBIFyquGk2pALtS+KSrrOObl/G2zBI6KOA+Qmv1QWUvXrvRVFnjGfHx1TeBxNOA5zyG0IjvcRCNtmkgni1tvDiob3umlPIO89XvwOw6sul3Vm0btD+4CDxspMe/3ocgPdKdog7apgmdzqjEHGyFc8y2pqe9nv27gm1U5Cy79FKb962QwddnaCSmGZ2nqvc5Lp1FKW+ZqJ8zRZLsQvcjkGA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(2906002)(4326008)(83380400001)(316002)(54906003)(8936002)(6916009)(8676002)(6486002)(5660300002)(66556008)(66946007)(66476007)(85182001)(26005)(6506007)(6512007)(9686003)(186003)(6666004)(86362001)(38100700002)(33716001)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U0Uyb044Q1c4cHhZUURpc2NRR2tNSVNadTRCZ1hjVG92QXp1S2FXbXJJZThn?=
 =?utf-8?B?cysybU0yeUxmRTRXRCtENml5VHdlQ2NnVk5MZk1CdkcxWUJmTmpNUElZSHJL?=
 =?utf-8?B?cmozZU55Yk5ZYTM2V3o3ckpOZERGUFB0QjEva25iSWpQWjl1akcrQzMyQlQ5?=
 =?utf-8?B?QVV3UmlIR0VSNVhKdDV1L3pmdTlhRjJBWkMwc1FPK09KTkR2Q2x4dDFKL25I?=
 =?utf-8?B?VnlNTENYZFRRd3ppMmt4SjJCamNJYnExYngzdlZjRjZ0NW9uY1NnYnZWMXVQ?=
 =?utf-8?B?TERrb2JxV3pqOUZJTXBXNjFOM1B6dXgxSWNIYXRGUzJVYWFLbEl0MEpobE1K?=
 =?utf-8?B?ODZFanpUUGpneGVpcTl2bThrOU94cGVwaVM5SHdLeThuci9pOVBiSG5sY0hr?=
 =?utf-8?B?ZUJtb2x6bkIvYjR3eS9kSWhFazhGM2ZZVWNnekd2eGNOWHdKeUFRUHlOaEo5?=
 =?utf-8?B?eVV3KzVrTVV0eUhXVHFYTXRoMXd2QXRWbUNEcXlxbFczNU1wZk8zb2ZkY25N?=
 =?utf-8?B?bExhL1RvMTNzQWRwMmpzS3l4TmlmazhjdG53emVNUVl5RlFyT2U5aDJaOG1x?=
 =?utf-8?B?RUJLd2tUaFJzSFJoSlo2UHJqbWxmenFIUWRtZGRUenhZcVhQc0Fsejk5OHJq?=
 =?utf-8?B?WGQ2SDJGMEwzaW83dXdYamg4THFHUEJXOWFpYzRPRk51anY3RnJ5WUdYMll4?=
 =?utf-8?B?aFBaY3gwSldHTTF4eTR5MjZINUhkS2cyRzQ5TUJMUXZUSjhxYld4RVlyNXpF?=
 =?utf-8?B?MnB5ay9tREhmbkRQSmhkZEJaQlEyYWQ2OHlQdXJBTnJlVnFEWUdyS0lCRkJi?=
 =?utf-8?B?blpieDY1MDhxS1hOLzA2RFcycmVrY2h4cTc5UUlDVHVjenVST0lZZjB0eTBj?=
 =?utf-8?B?MGNFL3ZwWGgvbkRzc3N6M0xhQnhkZ0xuWGNsS1pFYmxDT1JMTENrVTNtU1pX?=
 =?utf-8?B?aWYvalJlTzVsMFZ1Ukl0NFd5L3M5SnN4RDRWOVE1OEx2S2ttZmoxWjhhanFV?=
 =?utf-8?B?YlRWVWY0TW8rZjJmOXZpRDJ5V0R5ZE1LbmJJdUFqanRpc3NWM2JSYWpGSGI5?=
 =?utf-8?B?dnpiVHdxL0d3MFdOdFBSRTFxK0s2emVPdlQ5SGl5S1MrN2tzM0x2RmdnTHNt?=
 =?utf-8?B?U0JFZ1RxV20yNWdKZWVPZ2Q1U0FmckhQdnI4WmVMdkpPTzhGa3Q4S1pFNGpY?=
 =?utf-8?B?MEVEbnBmWDMxd1VOcnk5T0RIUm1kemVIck9tWCtmeDRReXZ6QWQ2dmtrMXd4?=
 =?utf-8?B?cUlzWlNDZU9ibnVxZzlmUDF4QTNYSVQrUVVDeFNFZi9ZTmV3YkhlNjBrWnp6?=
 =?utf-8?B?WUlldm9mMHNuZGs2RVFPT0E0TlB0WDJoWnllSUVmSDRycGIwTkZkUi9icUVT?=
 =?utf-8?B?TitFVVBodXZFZjdWRHhTTHJLQXhFRWRqZXk0ZS9oQlc3a01EakVNL0EwOGE3?=
 =?utf-8?B?Sy9QaC85ZEE3eGlGWW9iVTFWSUY2cHMrSDNvNEFDZTRFd3M2RFEzbHU1UlV2?=
 =?utf-8?B?VkJBeEFwQjZnYmdhV1cwbmVvQlRPWWtkc0JLVExMS21vVGxUVUpEclVzU20v?=
 =?utf-8?B?NXEyUmZkeVhVWVI4WnBybUE2STVjTXJIR1NLU2RVeWpEd3d6VWxDaXFKRENs?=
 =?utf-8?B?N2wwRXFJLzFuT3BObUdXWXdGcWhTTEFyWmwwQnRCMXIrQUtRQ2FGb2dSVmJ1?=
 =?utf-8?B?NHpQM2s5RXZnb3FxZEw2WitvZGNyQnkxMmZzenQrc3QzNDBVbGZhRzV5NDQ1?=
 =?utf-8?B?MFNGUnJOT3puK2lTd2JZTVNDN213NC9PS1FXcDhNM3p1NE4zSG9KNS9rTVJj?=
 =?utf-8?B?V0xIdm1YRHJLdWVZZ0laQlovS0FGOHJXanBjS21mZkovekJWQW44MzcwQWIx?=
 =?utf-8?B?RkU0L3FWL0pOMEZBVlNzMFZHQnY1dVkrbVh5UFFNWTQ3bFJlYVV6T0cvM1dN?=
 =?utf-8?B?R2F1d1pIbnZBcnZhTlN5dXQxS1lxTkhHSGZENlB1ajVwQkJ5endRNFMzUkJz?=
 =?utf-8?B?Q09ibVV3WG1EUzVndnovNFpXWGUxQkVXSlhFenNyVnRaa2NnczFwcHh0V0Vq?=
 =?utf-8?B?eG13T1R4YXhiRGkxMGkrQmJHUEJRZmJjYmNueDFQbSt4STV1RDdpUXZVbno5?=
 =?utf-8?B?b05JVTkxYXVmSzdjaWFhak5FbGxlVFlwVTV3MS9pWE4yT0R6aUxsZ2E0K3hq?=
 =?utf-8?B?VlpJZzRWamxuUXAwcjhUazBhbEY0emMyNnRRT0JYMDhNb0tJbWdQZlA4akVK?=
 =?utf-8?B?RlgxVjRrNlQ5RFpCUDJVenltMzZlNjN2YlFGNzVRK3pLbXNrWnRmSlF6WWFK?=
 =?utf-8?B?eWVNZWxMRjRXY3FXdEh1R2k0eG1JTENjRWsxT3MyWEpaUXYxVDRVUml2Umx6?=
 =?utf-8?Q?RWtZ6UFE2YCIxPq4=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11760ffd-541e-4a79-666e-08da29faebaa
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 16:11:30.0284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tqinjmRj/OexvRkjXNKhl5SfrWuVfwS6NMIdBrIeRjAYb5GHNsfrUgWufsJy5LdLp2gtTUz4HeEhMH5SUpV4Ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6229

On Fri, Apr 29, 2022 at 05:49:42PM +0200, Roger Pau Monné wrote:
> On Fri, Apr 29, 2022 at 12:59:58PM +0200, Jan Beulich wrote:
> > On 27.04.2022 12:47, Roger Pau Monne wrote:> Changes since v3:>  - Align ssbd per-core struct to a cache line.>  - Open code a simple spinlock to avoid playing tricks with the lock>    detector.>  - s/ssbd_core/ssbd_ls_cfg/.>  - Fix log message wording.>  - Fix define name and remove comment.>  - Also handle Hygon processors (Fam18h).>  - Add changelog entry.
> > What is this last line about?
> 
> Hm, seems like I forgot to do a patch refresh... So new version will
> have an entry about adding VIRT_SSBD support to HVM guests. Sorry for
> spoiling the surprise.
> 
> > > +bool __init amd_setup_legacy_ssbd(void)
> > > +{
> > > +	unsigned int i;
> > > +
> > > +	if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) ||
> > > +	    boot_cpu_data.x86_num_siblings <= 1)
> > > +		return true;
> > > +
> > > +	/*
> > > +	 * One could be forgiven for thinking that c->x86_max_cores is the
> > > +	 * correct value to use here.
> > > +	 *
> > > +	 * However, that value is derived from the current configuration, and
> > > +	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
> > > +	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
> > > +	 */
> > > +	if (boot_cpu_data.extended_cpuid_level >= 0x80000008) {
> > > +		ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
> > > +		ssbd_max_cores /= boot_cpu_data.x86_num_siblings;
> > > +	}
> > > +	if (!ssbd_max_cores)
> > > +		return false;
> > > +
> > > +	ssbd_ls_cfg = xzalloc_array(struct ssbd_ls_cfg,
> > > +	                            ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS);
> > > +	if (!ssbd_ls_cfg)
> > > +		return false;
> > > +
> > > +	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
> > > +		/* Record initial state, also applies to any hotplug CPU. */
> > > +		if (opt_ssbd)
> > > +			ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings;
> > 
> > Perhaps flip if() and for()?
> 
> Indeed, thanks.
> 
> > > +void amd_set_legacy_ssbd(bool enable)
> > > +{
> > > +	const struct cpuinfo_x86 *c = &current_cpu_data;
> > > +	struct ssbd_ls_cfg *status;
> > > +
> > > +	if (c->x86 != 0x17 || c->x86_num_siblings <= 1) {
> > > +		BUG_ON(!set_legacy_ssbd(c, enable));
> > > +		return;
> > > +	}
> > > +
> > > +	BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS);
> > > +	BUG_ON(c->cpu_core_id >= ssbd_max_cores);
> > > +	status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores +
> > > +	                      c->cpu_core_id];
> > > +
> > > +	/*
> > > +	 * Open code a very simple spinlock: this function is used with GIF==0
> > > +	 * and different IF values, so would trigger the checklock detector.
> > > +	 * Instead of trying to workaround the detector, use a very simple lock
> > > +	 * implementation: it's better to reduce the amount of code executed
> > > +	 * with GIF==0.
> > > +	 */
> > > +	while ( test_and_set_bool(status->locked) )
> > > +	    cpu_relax();
> > > +	status->count += enable ? 1 : -1;
> > > +	ASSERT(status->count <= c->x86_num_siblings);
> > > +	if (enable ? status->count == 1 : !status->count)
> > > +		BUG_ON(!set_legacy_ssbd(c, enable));
> > 
> > What are the effects of ASSERT() or BUG_ON() triggering in a GIF=0
> > region?
> 
> So AFAICT the BUG itself works, the usage of a crash kernel however
> won't work as it's booted with GIF==0.
> 
> Maybe we need to issue an stgi as part of BUG_FRAME if required?
> (maybe that's too naive...)

Well, better in panic() or kexec_crash() likely.

Roger.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:15:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:15:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317515.536872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTHa-0000o2-DO; Fri, 29 Apr 2022 16:15:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317515.536872; Fri, 29 Apr 2022 16:15:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTHa-0000nv-AC; Fri, 29 Apr 2022 16:15:50 +0000
Received: by outflank-mailman (input) for mailman id 317515;
 Fri, 29 Apr 2022 16:15:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkTHZ-0000np-Ar
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 16:15:49 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org
 [2604:1380:40e1:4800::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ffbd37d-c7d7-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 18:15:47 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id C735CCE333E;
 Fri, 29 Apr 2022 16:15:44 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F206C385A4;
 Fri, 29 Apr 2022 16:15:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ffbd37d-c7d7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651248943;
	bh=a/+dkukeDALgqHfGdiz6eovII65+V4YzhOih++eUC1Q=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=K066LHmpgwOmHxnA8x1rpupH8y65w62bYJUmD94t91Ck/7hmI1b8kAfzxj37eM693
	 P6hVw3E2jNUELwBtgo7ncrdoYFmZAJvKukJ+UB2pt+XMFE+LdMYosM7lX82c6HQymk
	 BhsFwdtbGQOAYy01vI11kuTteIm5KD0yBFK5XeSyZwSURv/zteDQzPhN2T+cVu3uaP
	 rUlKQ390jZHc1XzO+3JekubEbXCuGBswrfhMXdPXY905pPVbC/FgbdDnhk4zzMgdhy
	 bV8KgdhIC75Se3dU7x2RCni2g3Dd8MPG3YpX20EifUpOkkdD5klAw3eNiFQBzgOGby
	 FztC07m+1wr8g==
Date: Fri, 29 Apr 2022 09:15:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien.grall.oss@gmail.com>, 
    osstest service owner <osstest-admin@xenproject.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, David Vrabel <dvrabel@amazon.co.uk>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
In-Reply-To: <cc097cb8-d04d-6441-d0f8-4027c7d0dc8e@xen.org>
Message-ID: <alpine.DEB.2.22.394.2204290912150.1947187@ubuntu-linux-20-04-desktop>
References: <osstest-169781-mainreport@xen.org> <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org> <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop> <CAJ=z9a1bu=3sX0rvWy+T-ey4363DMUEJvzkSqkQkTnvOQtT0=A@mail.gmail.com>
 <alpine.DEB.2.22.394.2204271622520.915916@ubuntu-linux-20-04-desktop> <ac0a0bf0-81a8-63c7-6a62-377672e24069@xen.org> <alpine.DEB.2.22.394.2204281647540.915916@ubuntu-linux-20-04-desktop> <cc097cb8-d04d-6441-d0f8-4027c7d0dc8e@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 29 Apr 2022, Julien Grall wrote:
> On 29/04/2022 01:41, Stefano Stabellini wrote:
> > On Thu, 28 Apr 2022, Julien Grall wrote:
> > > On 28/04/2022 01:47, Stefano Stabellini wrote:
> > > > On Thu, 28 Apr 2022, Julien Grall wrote:
> > > > > Hi Stefano,
> > > > > 
> > > > > On Thu, 28 Apr 2022, 00:02 Stefano Stabellini,
> > > > > <sstabellini@kernel.org>
> > > > > wrote
> > > > >         It seems to me that it is acceptable to allocate memory with
> > > > > interrupt
> > > > >         disabled during __init. I cannot see any drawbacks with it. I
> > > > > think
> > > > > we
> > > > >         should change the ASSERT to only trigger after __init:
> > > > > system_state
> > > > > ==
> > > > >         SYS_STATE_active.
> > > > > 
> > > > >         What do you think?
> > > > > 
> > > > > 
> > > > > This would solve the immediate problem but not the long term one (i.e
> > > > > cpu
> > > > > hotplug).
> > > > > 
> > > > > So I think it would be better to properly fix it right away.
> > > > 
> > > > Yeah, you are right about cpu hotplug. I think both statements are true:
> > > > 
> > > > - it is true that this is supposed to work with cpu hotplug and these
> > > >     functions might be directly affected by cpu hotplug (by a CPU coming
> > > >     online later on)
> > > > 
> > > > - it is also true that it might not make sense to ASSERT at __init time
> > > >     if IRQs are disabled. There might be other places, not affected by
> > > > cpu
> > > >     hotplug, where we do memory allocation at __init time with IRQ
> > > >     disabled. It might still be a good idea to add the system_state ==
> > > >     SYS_STATE_active check in the ASSERT, not to solve this specific
> > > >     problem but to avoid other issues.
> > > 
> > > AFAIU, it is not safe on x86 to do TLB flush with interrupts disabled
> > > *and*
> > > multiple CPUs running. So we can't generically relax the check.
> > > 
> > > Looking at the OSSTest results, both Arm32 and Arm64 without GICv3 ITS
> > > tests
> > > have passed. So it seems unnecessary to me to preemptively relax the check
> > > just for Arm.
> > 
> > It is good news that it works already (GICv3 aside) on ARM. If you
> > prefer not to relax it, I am OK with it (although it makes me a bit
> > worried about future breakages).
> 
> Bear in mind this is a debug only breakage, production build will work fines
> with any ASSERT() affecting large code base, it is going to be difficult to
> find all the potential misuse. So we have to rely on wider testing and fix it
> as it gets reported.
> 
> If we relax the check, then we are never going to be able to harden the code
> in timely maneer.
> 
> > > > In regard to gicv3_lpi_allocate_pendtable, I haven't thought about the
> > > > implications of cpu hotplug for LPIs and GICv3 before. Do you envision
> > > > that in a CPU hotplug scenario gicv3_lpi_init_rdist would be called when
> > > > the extra CPU comes online?
> > > 
> > > It is already called per-CPU. See gicv3_secondary_cpu_init() ->
> > > gicv3_cpu_init() -> gicv3_populate_rdist().
> > 
> > Got it, thanks!
> > 
> > 
> > > > Today gicv3_lpi_init_rdist is called based on the number of
> > > > rdist_regions without checking if the CPU is online or offline (I think
> > > > ?)
> > > 
> > > The re-distributors are not banked and therefore accessible by everyone.
> > > However, in Xen case, each pCPU will only touch its own re-distributor
> > > (well
> > > aside TYPER to figure out the ID).
> > > 
> > > The loop in gicv3_populate_rdist() will walk throught all the
> > > re-distributor to find which one corresponds to the current pCPU. Once we
> > > found it, we will call gicv3_lpi_init_rdist() to fully initialize the
> > > re-distributor.
> > > 
> > > I don't think we want to populate the memory for each re-distributor in
> > > advance.
> > 
> > I agree.
> > 
> > Currently we do:
> > 
> >      start_secondary
> >          [...]
> >          gic_init_secondary_cpu()
> >              [...]
> >              gicv3_lpi_init_rdist()
> >          [...]
> >          local_irq_enable();
> > 
> > Which seems to be the right sequence to me. There must be an early boot
> > phase where interrupts are disabled on a CPU but memory allocations are
> > possible. If this was x86 with the tlbflush limitation, I would suggest
> > to have per-cpu memory mapping areas so that we don't have to do any
> > global tlb flushes with interrupts disabled.
> > 
> > On ARM, we don't have the tlbflush limitation so we could do that but we
> > wouldn't have much to gain from it.
> > 
> > Also, this seems to be a bit of a special case, because in general we
> > can move drivers initializations later after local_irq_enable(). But
> > this is the interrupt controller driver itself -- we cannot move it
> > after local_irq_enable().
> > 
> > So maybe an ad-hoc solution could be acceptable?
> 
> We don't need any ad-hoc solution here. We can register a CPU notifier that
> will notify us when a CPU will be prepared. Something like below should work
> (untested yet):

The CPU notifier is a good idea. It looks like the patch below got
corrupted somehow by the mailer. If you send it as a proper patch I am
happy to have a look.


> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
> index e1594dd20e4c..ccf4868540f5 100644
> --- a/xen/arch/arm/gic-v3-lpi.c
> +++ b/xen/arch/arm/gic-v3-lpi.c
> @@ -18,6 +18,7 @@
>   * along with this program; If not, see <http://www.gnu.org/licenses/>.
>   */
> 
> +#include <xen/cpu.h>
>  #include <xen/lib.h>
>  #include <xen/mm.h>
>  #include <xen/param.h>
> @@ -234,18 +235,13 @@ void gicv3_lpi_update_host_entry(uint32_t host_lpi, int
> domain_id,
>      write_u64_atomic(&hlpip->data, hlpi.data);
>  }
> 
> -static int gicv3_lpi_allocate_pendtable(uint64_t *reg)
> +static int gicv3_lpi_allocate_pendtable(unsigned int cpu)
>  {
> -    uint64_t val;
>      void *pendtable;
> 
> -    if ( this_cpu(lpi_redist).pending_table )
> +    if ( per_cpu(lpi_redist, cpu).pending_table )
>          return -EBUSY;
> 
> -    val  = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
> -    val |= GIC_BASER_CACHE_SameAsInner <<
> GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT;
> -    val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT;
> -
>      /*
>       * The pending table holds one bit per LPI and even covers bits for
>       * interrupt IDs below 8192, so we allocate the full range.
> @@ -265,13 +261,38 @@ static int gicv3_lpi_allocate_pendtable(uint64_t *reg)
>      clean_and_invalidate_dcache_va_range(pendtable,
>                                           lpi_data.max_host_lpi_ids / 8);
> 
> -    this_cpu(lpi_redist).pending_table = pendtable;
> +    per_cpu(lpi_redist, cpu).pending_table = pendtable;
> 
> -    val |= GICR_PENDBASER_PTZ;
> +    return 0;
> +}
> +
> +static int gicv3_lpi_set_pendtable(void __iomem *rdist_base)
> +{
> +    const void *pendtable = this_cpu(lpi_redist).pending_table;
> +    uint64_t val;
> +
> +    if ( !pendtable )
> +        return -ENOMEM;
> 
> +    ASSERT(virt_to_maddr(pendtable) & ~GENMASK(51, 16));
> +
> +    val  = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
> +    val |= GIC_BASER_CACHE_SameAsInner <<
> GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT;
> +    val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT;
> +    val |= GICR_PENDBASER_PTZ;
>      val |= virt_to_maddr(pendtable);
> 
> -    *reg = val;
> +    writeq_relaxed(val, rdist_base + GICR_PENDBASER);
> +    val = readq_relaxed(rdist_base + GICR_PENDBASER);
> +
> +    /* If the hardware reports non-shareable, drop cacheability as well. */
> +    if ( !(val & GICR_PENDBASER_SHAREABILITY_MASK) )
> +    {
> +        val &= ~GICR_PENDBASER_INNER_CACHEABILITY_MASK;
> +        val |= GIC_BASER_CACHE_nC << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
> +
> +        writeq_relaxed(val, rdist_base + GICR_PENDBASER);
> +    }
> 
>      return 0;
>  }
> @@ -340,7 +361,6 @@ static int gicv3_lpi_set_proptable(void __iomem *
> rdist_base)
>  int gicv3_lpi_init_rdist(void __iomem * rdist_base)
>  {
>      uint32_t reg;
> -    uint64_t table_reg;
>      int ret;
> 
>      /* We don't support LPIs without an ITS. */
> @@ -352,24 +372,33 @@ int gicv3_lpi_init_rdist(void __iomem * rdist_base)
>      if ( reg & GICR_CTLR_ENABLE_LPIS )
>          return -EBUSY;
> 
> -    ret = gicv3_lpi_allocate_pendtable(&table_reg);
> +    ret = gicv3_lpi_set_pendtable(rdist_base);
>      if ( ret )
>          return ret;
> -    writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER);
> -    table_reg = readq_relaxed(rdist_base + GICR_PENDBASER);
> 
> -    /* If the hardware reports non-shareable, drop cacheability as well. */
> -    if ( !(table_reg & GICR_PENDBASER_SHAREABILITY_MASK) )
> -    {
> -        table_reg &= ~GICR_PENDBASER_INNER_CACHEABILITY_MASK;
> -        table_reg |= GIC_BASER_CACHE_nC <<
> GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
> +    return gicv3_lpi_set_proptable(rdist_base);
> +}
> +
> +static int cpu_callback(struct notifier_block *nfb, unsigned long action,
> +                        void *hcpu)
> +{
> +    unsigned long cpu = (unsigned long)hcpu;
> +    int rc = 0;
> 
> -        writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER);
> +    switch ( action )
> +    {
> +    case CPU_UP_PREPARE:
> +        rc = gicv3_lpi_allocate_pendtable(cpu);
> +        break;
>      }
> 
> -    return gicv3_lpi_set_proptable(rdist_base);
> +    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
>  }
> 
> +static struct notifier_block cpu_nfb = {
> +    .notifier_call = cpu_callback,
> +};
> +
>  static unsigned int max_lpi_bits = 20;
>  integer_param("max_lpi_bits", max_lpi_bits);
> 
> @@ -381,6 +410,7 @@ integer_param("max_lpi_bits", max_lpi_bits);
>  int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)
>  {
>      unsigned int nr_lpi_ptrs;
> +    int rc;
> 
>      /* We rely on the data structure being atomically accessible. */
>      BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long));
> @@ -413,7 +443,14 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)
> 
>      printk("GICv3: using at most %lu LPIs on the host.\n", MAX_NR_HOST_LPIS);
> 
> -    return 0;
> +    /* Register the CPU notifier and allocate memory for the boot CPU */
> +    register_cpu_notifier(&cpu_nfb);
> +    rc = gicv3_lpi_allocate_pendtable(smp_processor_id());
> +    if ( rc )
> +        printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n",
> +               smp_processor_id());
> +
> +    return rc;
>  }
> 
>  static int find_unused_host_lpi(uint32_t start, uint32_t *index)
> 
> Cheers,
> 
> -- 
> Julien Grall
> 


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:26:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:26:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317521.536883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTRl-0002J8-D6; Fri, 29 Apr 2022 16:26:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317521.536883; Fri, 29 Apr 2022 16:26:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTRl-0002J1-9s; Fri, 29 Apr 2022 16:26:21 +0000
Received: by outflank-mailman (input) for mailman id 317521;
 Fri, 29 Apr 2022 16:26:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E21X=VH=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1nkTRj-0002Iu-Oc
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 16:26:19 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20728.outbound.protection.outlook.com
 [2a01:111:f400:7e88::728])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1835cf71-c7d9-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 18:26:18 +0200 (CEST)
Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21)
 by CH2PR21MB1525.namprd21.prod.outlook.com (2603:10b6:610:5f::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.6; Fri, 29 Apr
 2022 16:26:02 +0000
Received: from PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df]) by PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df%6]) with mapi id 15.20.5227.006; Fri, 29 Apr 2022
 16:26:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1835cf71-c7d9-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TnYPKv6cHHooKkxX4CyAInmQOVJL+OziIpN/GllKamJdLXKN9pgc0JLdxdyG5o4Udhig25LbpjMkGVtiJr3BpTywkbrXXha1jvswAm+XYWeYOXi2gjn2dH2uAgTMtLT2jbOTqtuSqOTs6HSmhzLD+7iFYQFUMSmQ2HhcdRz0tckq7wSnmWoEnae03PlAp81C/6Y7A5elDA7JXOm/ubJjoq+tF7vHcRy9sLmepWaqrALujROI2plEhRBl02SgmI6ETipuH8J6Xub66Nv/IDNQ0T1gxK8T1a1OaaPRk9S8MH5BuCJwTRspF9IdY2rGjJfLqh3Y9lm3CV0zLYpvT+I6Ig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zTfneMsIYF8YteyonKPHoonZYmHV8hcH1Ru2q+6fv+0=;
 b=a8eu4ttDG+sEYNKvY+Uwg1P3RBiTiU+aBz6zRlC/6rvyoDzx60kk6vFEe/s42qfutMsEoCQXf26saUU5449UKwK24BAbhL91IpoY51JezhYp+GEiVnxQbqE/iZ+SOACRPpdsYFcOSEYUXdTrLeAFwJtGMnzA7bO3UfPp3ObxWmkMQaJkQa4bt+JR5CbdrtRreISsi/oI8XylYkH3pby6kSXQe+vmLXgJq9WyZhPChMkc4r6YxiCxevLqMJpaBn5Kytf9c8vT5PNtVTGx+ODEAb1aYyH/lQREUWAzeu7eEEE5pR4fiwrhZcFwzS5Xz3T5pA8yf4n50TM4AZeFGPKBZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zTfneMsIYF8YteyonKPHoonZYmHV8hcH1Ru2q+6fv+0=;
 b=d+Tijt2euluzrQi71IhaI2QKQVJzCEGzhvDpVQFylauvgmvb+PUHN72mLRXMSu63F1AMA4wWXKpgR7C192SolLu8YaJCvcwzHALT2WPLFSkGE8ihloRhKEhReubWrxbSHp5AZDEZSpJUcCoV3iPIyf5/QVdRfkXrHI+cydNTodI=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>, "bhe@redhat.com" <bhe@redhat.com>,
	"pmladek@suse.com" <pmladek@suse.com>, "kexec@lists.infradead.org"
	<kexec@lists.infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>, "coresight@lists.linaro.org"
	<coresight@lists.linaro.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "linux-alpha@vger.kernel.org"
	<linux-alpha@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-leds@vger.kernel.org"
	<linux-leds@vger.kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linux-parisc@vger.kernel.org"
	<linux-parisc@vger.kernel.org>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-xtensa@linux-xtensa.org"
	<linux-xtensa@linux-xtensa.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "openipmi-developer@lists.sourceforge.net"
	<openipmi-developer@lists.sourceforge.net>, "rcu@vger.kernel.org"
	<rcu@vger.kernel.org>, "sparclinux@vger.kernel.org"
	<sparclinux@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "x86@kernel.org" <x86@kernel.org>,
	"kernel-dev@igalia.com" <kernel-dev@igalia.com>, "kernel@gpiccoli.net"
	<kernel@gpiccoli.net>, "halves@canonical.com" <halves@canonical.com>,
	"fabiomirmar@gmail.com" <fabiomirmar@gmail.com>,
	"alejandro.j.jimenez@oracle.com" <alejandro.j.jimenez@oracle.com>,
	"andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
	"arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
	"corbet@lwn.net" <corbet@lwn.net>, "d.hatayama@jp.fujitsu.com"
	<d.hatayama@jp.fujitsu.com>, "dave.hansen@linux.intel.com"
	<dave.hansen@linux.intel.com>, "dyoung@redhat.com" <dyoung@redhat.com>,
	"feng.tang@intel.com" <feng.tang@intel.com>, "gregkh@linuxfoundation.org"
	<gregkh@linuxfoundation.org>, "hidehiro.kawai.ez@hitachi.com"
	<hidehiro.kawai.ez@hitachi.com>, "jgross@suse.com" <jgross@suse.com>,
	"john.ogness@linutronix.de" <john.ogness@linutronix.de>,
	"keescook@chromium.org" <keescook@chromium.org>, "luto@kernel.org"
	<luto@kernel.org>, "mhiramat@kernel.org" <mhiramat@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>, "paulmck@kernel.org"
	<paulmck@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>, "senozhatsky@chromium.org"
	<senozhatsky@chromium.org>, "stern@rowland.harvard.edu"
	<stern@rowland.harvard.edu>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>, vkuznets <vkuznets@redhat.com>,
	"will@kernel.org" <will@kernel.org>, Marc Zyngier <maz@kernel.org>, Russell
 King <linux@armlinux.org.uk>
Subject: RE: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs
 shutdown path
Thread-Topic: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs
 shutdown path
Thread-Index: AQHYWolciKXO2fn1XUueFH8wz+psXK0HFf6Q
Date: Fri, 29 Apr 2022 16:26:02 +0000
Message-ID:
 <PH0PR21MB3025F5AADF3CCEF714585912D7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-3-gpiccoli@igalia.com>
In-Reply-To: <20220427224924.592546-3-gpiccoli@igalia.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=da7688d4-abf9-471b-8371-b8d1f4f7a276;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-04-29T16:24:00Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 12d2e652-94f5-4275-caf3-08da29fcf3a3
x-ms-traffictypediagnostic: CH2PR21MB1525:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs:
 <CH2PR21MB1525A56096F29DA35274DF06D7FC9@CH2PR21MB1525.namprd21.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 wB8XZ1/NZe0RxqPcMyP9Fl0jn5spPmxDwsu1zSlW6C0kyE5ykFkLFABY5ragQHHt4qFaO6+geen2Ziig93fScW0al/m8IHVYIsiAab4ANv6Po4YsCkZ+eD2CMdpIZqo2H3/NBWooxmu7ohtHxciOfGYLHiAcHjO3yTaMe7NkhERBhAkla1wJ3WTY5b4GnGVMBKdmBhXs038s3YC8KBQBChzYwORF2w+j5eypjrRxQ/hungUzeBkm8NgF/SZVuGFgPKlpagUj8AV9O2n+y203gTS7Q3axk1bs9Vry0snJOw5dIZgOSmNF8sXtOqCxX7t5Qff59Qv6eS2ETSnQZ+Jn14GG0hX7Lb5Dw8hgyHu8i92nY0GH1DLFB/fe1WIZES0JyYvE8jFKYN5sViiLIo4ZyC1IH7IFNC+G+jdTIv/2zffnpmRdJ5s8QmGQL93vWotrzk+UzVXQU+nJ3aMUrmYQrApWY5L6BH9NeHgXmtgEfoKGjdt+LDt7m/ONjF5umDYj8PCEzxX7jwKXP1ukzcjGKglLSE5LkvERS+PCB5fOAaBFqdNfctPErxc5ftlkdrgmBhbZMIGVCzZJVdgajqAdVm5Gh4a5z41n0pvweuQjq0ptieR5IivpdIn8d3MA3WAmwPD8MZ8xQvNINpM5HJa9vMtpk/PGHSsNyIUjUY9RSpRgYogXTnaPjfU33i+sSXmpGaGlMdirdlcwIYQ88kqcCkhtwOlnm8I4QvjnWfjwhmSsqf7DJ13MfqHMkBe2YAC2
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(10290500003)(86362001)(26005)(54906003)(2906002)(83380400001)(186003)(316002)(38100700002)(38070700005)(33656002)(8936002)(55016003)(5660300002)(110136005)(8990500004)(64756008)(4326008)(52536014)(8676002)(82960400001)(82950400001)(122000001)(7406005)(6506007)(508600001)(7696005)(76116006)(9686003)(66446008)(7366002)(7416002)(66946007)(66556008)(66476007)(71200400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?HOVOBMjGnBhzww+fSAuwt5Y26ag/vTm7WJsA/0I+lrHqOX4Kij7UXrUK9ioi?=
 =?us-ascii?Q?Apfoi6F26pG/5LFLJ6/sVCcXGpmG8Szt0yI2g6I87VtbMuNFixlFmlAts5Kp?=
 =?us-ascii?Q?juzfxPQr8QSJsvRkR1FCEBWX7zDFGljJEmkOuhvWZA5iu95GzHEl9smQupkQ?=
 =?us-ascii?Q?uA1vkvhMWl3SN2UtN8Re01sF69mYEyvKEoq5OeH3RYS/9dAMLsbAoCG64hkr?=
 =?us-ascii?Q?yWa1lBi9LU2n+8TPjAIiu/xsEMXrZL92OmZnVWGPEUBkziTcpTCTVmPJHuDH?=
 =?us-ascii?Q?trWdGcvtEnuDI2OqJqEsTUfBBaYMcW+NTMhpaG+I+y0koUVV5JEoRh4J4SVc?=
 =?us-ascii?Q?4gJ5Tb6edzw7Aww0E9SBwOx0OIJzqZ3T0zdt211/2sSx2hG+vGGna5Ep/fZx?=
 =?us-ascii?Q?FzmXpK2rWabCCg1tSzk87qixyQjNHWTDrzoZPsfu4aCUZIRQsst+gOimR9FM?=
 =?us-ascii?Q?7x+ffC3s93rLaKZdUqKPMMnb6PmqoG/hcxmoMAT7j8YoUyHenRzCc1Vv7Q3i?=
 =?us-ascii?Q?SQNSOyH7lw8R3ZlHVbQcqk/BkpNfJunTf6v1V+4/yoXhMGLVdP0NEqoGmSkW?=
 =?us-ascii?Q?oiBKZ1I/ksmYecWTsu5aI4ZMylDc7mPHzOSNypIyncccCthwKLfgL5zE2pmc?=
 =?us-ascii?Q?Bsqfdovl3XaYF9zRCZWFnwiN5FUUsKuWQOtW/SxKtHxipD85E7gTtdEjp0hB?=
 =?us-ascii?Q?eezovK8Dqv02f72andbcnbhslU6/CIaDGkpdF+rxxO0t9FLkmx0HzdrCQ6m9?=
 =?us-ascii?Q?PYM4UMY5gCzR72PVLPooj7dZQ9ORhxxarnRAsqkPx+OoZlJxdpZLm5Xlnn8h?=
 =?us-ascii?Q?ejv/fRH9oYEB0YT3wVYMufGEdETBE6lIuS4e1CQn8btX6+N6lqNr/sDwrzoK?=
 =?us-ascii?Q?yG/kNL/WyW+pWnmlD73aGxBm3oTlfy92yh7mFiGx3XoP1H67xibXilHvjHeq?=
 =?us-ascii?Q?CIQ9jSr1Yml4yr9Ze4AZSarYeEkA51U+ZYqM2WsPJxtslTIjdOn9VrMmfC+c?=
 =?us-ascii?Q?Un9f8WuFOi4FrffZLKk7eV56OScnFML7IH1frQOE/TVLYyY4S+zsEAoxutET?=
 =?us-ascii?Q?7vtA97Tev2KRlXwu7g8i9dpLRscID48LCT9WdFTpdrDcrQCA9X+4U3HLVaEy?=
 =?us-ascii?Q?bvDwUxLjCXV5E7MX6B0iIdxqMeLZJHDcLIsE3BkMSFZ0eRBw9tqvixK5ITek?=
 =?us-ascii?Q?KEcQ9L/MHgkugZs/5SXapjVC2M+tW6029NxUWMMRr6cYdz5WJJN/xL4fuXGr?=
 =?us-ascii?Q?reNb1So3iGx9/B4i2r6GbXK8QiV1VdL+cmrYuXNzspThAeIVevwZsZixA5wp?=
 =?us-ascii?Q?5Qj8MYvb7BUV6ie9V0iec61TynvQ/w3V5kg9Wsfj4s2rlxFsuP5c5E/LfdKm?=
 =?us-ascii?Q?AGMRFARkVLGBAuACPa4Z+rEwWjWn9eO0FnNg6W+yjyG1tZ/2FU5PwKw96fo3?=
 =?us-ascii?Q?zhJKN9CaUFHYrMwnYpS6v1LQEhx9OJ49Z8LplX4t/xvLeOETvjp07zOztXY8?=
 =?us-ascii?Q?yWTDOzSQv2FjyFjGVPzqtRHm7xg9uDRC3DzC+aWpNFiEh6KvdQZ1v5OwR3m0?=
 =?us-ascii?Q?OnN8mIndbJhD97RCmboNmOMpBSpaI1JPK7DI4PB/6oonTzc1omct6SDMFM4p?=
 =?us-ascii?Q?/tVAjdpQ1ctoAmWKB8CBMjVxEofkH9ri48pnp4FraSGWIwUp4jQPX3POvr72?=
 =?us-ascii?Q?BRZcCEMDdJWPVsq3pJZvDpAhyaHOx0b45Z7m1cE9VAHlAi5dc/L8k9VGYwOF?=
 =?us-ascii?Q?l3tv1fE1Q8ybciN7k3D85UcPN2nclxk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12d2e652-94f5-4275-caf3-08da29fcf3a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 16:26:02.2141
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iO+PqzIAdZZfIpEhplUNNDiJF+yGhuHwl3BsWuuQSH2Wxe1HA34Es/xn0LzDD3atpaDnvY9htz4Fd+iXjEy5lQqxIugHEad6MWW3aMA9kUE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR21MB1525

From: Guilherme G. Piccoli <gpiccoli@igalia.com> Sent: Wednesday, April 27,=
 2022 3:49 PM
>=20
> Currently the regular CPU shutdown path for ARM disables IRQs/FIQs
> in the secondary CPUs - smp_send_stop() calls ipi_cpu_stop(), which
> is responsible for that. This makes sense, since we're turning off
> such CPUs, putting them in an endless busy-wait loop.
>=20
> Problem is that there is an alternative path for disabling CPUs,
> in the form of function crash_smp_send_stop(), used for kexec/panic
> paths. This functions relies in a SMP call that also triggers a

s/functions relies in/function relies on/

> busy-wait loop [at machine_crash_nonpanic_core()], but *without*
> disabling interrupts. This might lead to odd scenarios, like early
> interrupts in the boot of kexec'd kernel or even interrupts in
> other CPUs while the main one still works in the panic path and
> assumes all secondary CPUs are (really!) off.
>=20
> This patch mimics the ipi_cpu_stop() interrupt disable mechanism
> in the crash CPU shutdown path, hence disabling IRQs/FIQs in all
> secondary CPUs in the kexec/panic path as well.
>=20
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>  arch/arm/kernel/machine_kexec.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_ke=
xec.c
> index f567032a09c0..ef788ee00519 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -86,6 +86,9 @@ void machine_crash_nonpanic_core(void *unused)
>  	set_cpu_online(smp_processor_id(), false);
>  	atomic_dec(&waiting_for_crash_ipi);
>=20
> +	local_fiq_disable();
> +	local_irq_disable();
> +
>  	while (1) {
>  		cpu_relax();
>  		wfe();
> --
> 2.36.0



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:28:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:28:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317526.536893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTTO-0002sZ-Of; Fri, 29 Apr 2022 16:28:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317526.536893; Fri, 29 Apr 2022 16:28:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTTO-0002sS-Lg; Fri, 29 Apr 2022 16:28:02 +0000
Received: by outflank-mailman (input) for mailman id 317526;
 Fri, 29 Apr 2022 16:28:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E21X=VH=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1nkTTN-0002sJ-7u
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 16:28:01 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-eus2azlp170100001.outbound.protection.outlook.com
 [2a01:111:f403:c110::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 54d9a3b2-c7d9-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 18:28:00 +0200 (CEST)
Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21)
 by CH2PR21MB1525.namprd21.prod.outlook.com (2603:10b6:610:5f::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.6; Fri, 29 Apr
 2022 16:27:43 +0000
Received: from PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df]) by PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df%6]) with mapi id 15.20.5227.006; Fri, 29 Apr 2022
 16:27:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54d9a3b2-c7d9-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iiRnmDCv6QXvKP6MuSaJUsvdzjZ3+bKaim7DUV10U2RiYluMwndhB0+g8eo922omk91MoEzA5kDdABC/GDoEv3leu6fH3rTynjbp8ShDwocs6lESLqrQOBe45W94OtVawEoGRoYT04sxfBK5UmK+jhWXC37iVR1y1ZfAA5nND1Bq2a3KpDt3+MSKVXZfTh40yd142ycwEhIUhQj1RRHwAG9bbggAYPj8giZffS8/E9zWXF5crw0TpK8RjJyZDWuLBELTkv4p05hsHHu0xUmzL6krU9rVi2NQNWDazBYiV+5Mniw+4AfTVmsrGQ6jt+fcMCab43DLOIl+vtEQ2gAhGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vuwI3s0/uzAI4p0El6C+ADHa0t+3Aw9/kpVyepipcnA=;
 b=l9uL7cPI8dCubco6QGE8scXjG37TX2AlQuD6kVVSaJZHZiAoJyZaqg8RLI40iqDR0GyF38DTpURbAfKZuoKeLOnm6j3tzS2gL3IBYVV5Fx33SE2OAHyunm21z8JXr16QveJjzaMoX7Va/kf1Ap/vSk7+95TCHIktVFjpQIwtOZ6OqsNW9S0SpPO2GbxB4nguU2r26VDfGrx7BamF5XBhdTpmjPbxYyKhuAyTSo6N3QUdY2DgRmT4bocM0soKQaLPi/R2qfUZ/mGo3jy2ehlbqu5bH2qggAjnGaWXMifxsuGnZPwoaRDw4a3jK8Y2fsgK0I0JhR9+67RoL/3ALtY24A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vuwI3s0/uzAI4p0El6C+ADHa0t+3Aw9/kpVyepipcnA=;
 b=VzDdgrQMZRKbNdrTfG4H0EgQQZm9srzi3KTcMWDcx0QMyQJjlYJUETWoCvFt03HvABO693gAaXqwwB+XZny5SSYqYwbMqlCORP1fIwl6HwwCA6DE776swKqJM8h0Rupd24eO8rdzvEprRQHh+mJyC65QdQbRnylWrYA9BefsKuI=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>, "bhe@redhat.com" <bhe@redhat.com>,
	"pmladek@suse.com" <pmladek@suse.com>, "kexec@lists.infradead.org"
	<kexec@lists.infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>, "coresight@lists.linaro.org"
	<coresight@lists.linaro.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "linux-alpha@vger.kernel.org"
	<linux-alpha@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-leds@vger.kernel.org"
	<linux-leds@vger.kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linux-parisc@vger.kernel.org"
	<linux-parisc@vger.kernel.org>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-xtensa@linux-xtensa.org"
	<linux-xtensa@linux-xtensa.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "openipmi-developer@lists.sourceforge.net"
	<openipmi-developer@lists.sourceforge.net>, "rcu@vger.kernel.org"
	<rcu@vger.kernel.org>, "sparclinux@vger.kernel.org"
	<sparclinux@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "x86@kernel.org" <x86@kernel.org>,
	"kernel-dev@igalia.com" <kernel-dev@igalia.com>, "kernel@gpiccoli.net"
	<kernel@gpiccoli.net>, "halves@canonical.com" <halves@canonical.com>,
	"fabiomirmar@gmail.com" <fabiomirmar@gmail.com>,
	"alejandro.j.jimenez@oracle.com" <alejandro.j.jimenez@oracle.com>,
	"andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
	"arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
	"corbet@lwn.net" <corbet@lwn.net>, "d.hatayama@jp.fujitsu.com"
	<d.hatayama@jp.fujitsu.com>, "dave.hansen@linux.intel.com"
	<dave.hansen@linux.intel.com>, "dyoung@redhat.com" <dyoung@redhat.com>,
	"feng.tang@intel.com" <feng.tang@intel.com>, "gregkh@linuxfoundation.org"
	<gregkh@linuxfoundation.org>, "hidehiro.kawai.ez@hitachi.com"
	<hidehiro.kawai.ez@hitachi.com>, "jgross@suse.com" <jgross@suse.com>,
	"john.ogness@linutronix.de" <john.ogness@linutronix.de>,
	"keescook@chromium.org" <keescook@chromium.org>, "luto@kernel.org"
	<luto@kernel.org>, "mhiramat@kernel.org" <mhiramat@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>, "paulmck@kernel.org"
	<paulmck@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>, "senozhatsky@chromium.org"
	<senozhatsky@chromium.org>, "stern@rowland.harvard.edu"
	<stern@rowland.harvard.edu>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>, vkuznets <vkuznets@redhat.com>,
	"will@kernel.org" <will@kernel.org>, Arjan van de Ven
	<arjan@linux.intel.com>, Cong Wang <xiyou.wangcong@gmail.com>, Sebastian
 Andrzej Siewior <bigeasy@linutronix.de>, Valentin Schneider
	<valentin.schneider@arm.com>, Xiaoming Ni <nixiaoming@huawei.com>
Subject: RE: [PATCH 18/30] notifier: Show function names on notifier routines
 if DEBUG_NOTIFIERS is set
Thread-Topic: [PATCH 18/30] notifier: Show function names on notifier routines
 if DEBUG_NOTIFIERS is set
Thread-Index: AQHYWonZ3NInIg4txEiT4R4E8VEqwq0HFqRA
Date: Fri, 29 Apr 2022 16:27:42 +0000
Message-ID:
 <PH0PR21MB302584B93A9F44AF5BA016EAD7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-19-gpiccoli@igalia.com>
In-Reply-To: <20220427224924.592546-19-gpiccoli@igalia.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=581a9fba-2d25-46d7-8cfa-60e93c53f88c;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-04-29T16:26:20Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f7493ad1-6244-43f8-39f8-08da29fd2fb9
x-ms-traffictypediagnostic: CH2PR21MB1525:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs:
 <CH2PR21MB1525388946C29048BEA6F12AD7FC9@CH2PR21MB1525.namprd21.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 EEuDxsnbcRtf/919apm2/HjD95AM6NKjKok91cmfnIdnCg31LBsDlsrydGEeQlMiyweum3K6/Ly/NmiL4TQt7P1hnFHiUWCIgywMxqj3LADrC/6/WTfHQsH9Lc2Kct8tqHmrrjTLHoX4semApWXgeTaAEyaH4i0n9HfleXSNeVY/uIWb95ED0+P63tPZvfTg4eTtGjhkzXpfLsOxKZBCIafYyBpcZEpiiZL+CM7I0x3qlrx+rX4O666DNfjNzu8fv6ClykGAOfMahCE+x8OGw3zF3uaVipnSwWlXOheAUa9FMg6SGUWEh+OYTfVxb/iRE+rrtNAIpZDLK8wdr2KBfdoDajAEiRaquPXxuPzT1L4NooHKU/hmtVp/ukS8qYko61xnqZo+pADQqK/pEu1QvQ5+PXt7AIG5I+wvOLE2Jb0ygAGq6fSAojZlIMBdivpP0KFAycBK1gvaujZpHqn9hvVDk/yGEQs7Ij/38uh4M1fRildvQeDsxwvaJVItQNlb88fzUTbCqjnlZw1BA1PpACi22ntrdOJyKyHyjj4C+dOuZQmHJp3XkSEkoJUcYCch4rb+il7Lb2UCDjJtlhwKVrPmWY7fm5h3KaK3VvUU6ICntxH/UKuJ6R/lMXQJIUuXcvIQWMVmgIjlNu2y31aOdvZb9imBJV+zqwxDqpU0CaiCSqh05Isosw7BA/AnzY06OSlybAnHSf5bCSAOw4hq2VJU74vlUrrurzmRL6esy6IuYCGIkFkWCghKw5aFflP7
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(10290500003)(86362001)(26005)(54906003)(2906002)(83380400001)(186003)(316002)(38100700002)(38070700005)(33656002)(8936002)(55016003)(5660300002)(110136005)(8990500004)(64756008)(4326008)(52536014)(8676002)(82960400001)(82950400001)(122000001)(7406005)(6506007)(508600001)(7696005)(76116006)(9686003)(66446008)(7366002)(7416002)(66946007)(66556008)(66476007)(71200400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?gccw+CTOC+7AOYb6PGUwR7Aqrl2d5R/okQD/abZi31DrunoEdaPhnaHNsDzE?=
 =?us-ascii?Q?Nnx4slwru0hCszBG8DTL4D8DdtQKgazWJk2v3DtnXRF0tqUq2SYf2/1mrjef?=
 =?us-ascii?Q?YxDTimGr0QqcG2ms9jnyPzWUZuUVOplpWwuA/aN9hxwPHGCdFF2KkdeaRiH6?=
 =?us-ascii?Q?BLP8a6gBt448eRKGiWvzKUJMqmWd4Ohps0NkGVYKuW4qM1F1mYFE7bQ1lwLO?=
 =?us-ascii?Q?0GGrtymGgORtukcPOVP3yEa4eT7lmvlFEviAI3m9QNXH7z7mbnTugre8KYOq?=
 =?us-ascii?Q?XybIsUit9tu+R3s45WkINtZVCquyFSTQiSL651l4OEaabKJ2wJy97vr2kgEh?=
 =?us-ascii?Q?b0XZKuFeRU2OeeUV68VA2mPnXymBTwcwHWu7CLL2z2yot1h1tn2szTf6MmwD?=
 =?us-ascii?Q?ok6nw2a3uztUvwqr5TfgyPixi3BZ17QXUcytA9WYvyKPjQf6ccvSstlljnlw?=
 =?us-ascii?Q?J0NkwIxgLQdEkkILXV8lc3P42/a8jF8gkbvg5aZuOUAspLNIFEWNKbJW4arx?=
 =?us-ascii?Q?YminuCMEciitH3ciZsuKHv+kZblXd6X1DJNf3QxqnRy1See9yv6gfHwf7Tq9?=
 =?us-ascii?Q?IFdrmELmjyzs31muu4qVz7nRx9BLw1uVDcDu4SjVKsRW87Q+VuvFvRMUl1f8?=
 =?us-ascii?Q?JKQnSS9XEFUZXA554pWaVfnXyon4AWXbHYsinX6QSxUcD1TLA1c7BB7m+55m?=
 =?us-ascii?Q?W3CBeLcRwx2yvgmUfXmF+SlvjyE6G7Y7lklGfjOYwCz9s1k7Dc0JUUBps3ch?=
 =?us-ascii?Q?sLoHPPJdrfvJl1UjbvjY9UQDyYOC8rsBWlaQKJ/vdV+UMb2Xcmz/m6Dcow2T?=
 =?us-ascii?Q?OjHeb1cJ39GUANrBr4MrOU0cT3CpKN0ZyGjm0O2iIp/gbEYM048d+dnIhO+v?=
 =?us-ascii?Q?yeY9Hk3VFfEx3IybE9nLgmI7X6DMNSfumpbXB3wd8IGaiz9uoIvW3V28rE2+?=
 =?us-ascii?Q?jWojKELW/Insfki3aOHwKuBdA5wjxl/aU6CmrZAjsr7IyvQ6XHi6xi1GF9dj?=
 =?us-ascii?Q?CVlkJMeAaleGor8PGEeIQE6Iz/M5e98ytxB6GLdJUAOgAAyyjo6kK8ybTr6W?=
 =?us-ascii?Q?rIGXJ0St74v6eOfp4MxTNawtCoaXpmn9C8u2QcM3kmoT/tE4V4L3q3DX1SAR?=
 =?us-ascii?Q?MfmdxkLpHMgGKmqlhSTtfRo09idix97FrwCBMapUtP0jNLG0WgcAMKVKd0zM?=
 =?us-ascii?Q?gjd17WlW1JZ7Fifxcr4TIdyDkRwSc/Pt8mQOFskRcI7wh0tGnd+ThtebmQw0?=
 =?us-ascii?Q?ImM/GS/FqYE0/Ap1Ha5/KtRRe3/4wotgGsjmcbsF4eaemW0NbbCHabp9kTu9?=
 =?us-ascii?Q?T0DKvT9y9cjZE3XTCziaVp69hZSKwvOfmAROqwWMQkVVA1/TDkGv+caV+Yvm?=
 =?us-ascii?Q?i7Pu68XE0QvA1B7UWuKzlVqL9m1wqPz2JguQMWPuzvzGFoKR42O8/JL8MV/0?=
 =?us-ascii?Q?NC2cE/EzeGx8KRqr0VgKRCZ4k0oKuw+Kpw4gDShftCnn5hdN0fPpsEo8V/jV?=
 =?us-ascii?Q?gH20+Ya1YGBSnW+vstXbDJRpdpVpO4FTaPIV0ccrEmg4Ts1ZFQpw7u+e279b?=
 =?us-ascii?Q?K0IsRjWLxni8JwljD8euR9NG4Ue8ePkX7kvm1Kuqbx4hu58PIN054JsMkIVJ?=
 =?us-ascii?Q?WN+ME2m1G8X4ECEsW3kFp8DQpZ/VIizw8cuJdO3zwQ7ziJp6x6Ir3F+jdlv/?=
 =?us-ascii?Q?mDTGyPH1M7FIsYDyFlONUTDF57vbxtSJP23uR7dYIz1T4UkrorpVnyKny55L?=
 =?us-ascii?Q?SLhFyajMwu3jezZKui9sF5w6gqe8VqM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7493ad1-6244-43f8-39f8-08da29fd2fb9
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 16:27:42.9879
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Qv5pQigZxtVKekUCXVeuIxlpJfXwibvP1dG2GPswXH69jjb0KEcwAGhQTpo9IA+UdAubLUWTSa32lRHN32wrD/QH0hF726uOqqNa6DjTmNo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR21MB1525

From: Guilherme G. Piccoli <gpiccoli@igalia.com> Sent: Wednesday, April 27,=
 2022 3:49 PM
>=20
> Currently we have a debug infrastructure in the notifiers file, but
> it's very simple/limited. This patch extends it by:
>=20
> (a) Showing all registered/unregistered notifiers' callback names;
>=20
> (b) Adding a dynamic debug tuning to allow showing called notifiers'
> function names. Notice that this should be guarded as a tunable since
> it can flood the kernel log buffer.
>=20
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Cong Wang <xiyou.wangcong@gmail.com>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Xiaoming Ni <nixiaoming@huawei.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>=20
> We have some design decisions that worth discussing here:
>=20
> (a) First of call, using C99 helps a lot to write clear and concise code,=
 but

s/call/all/

> due to commit 4d94f910e79a ("Kbuild: use -Wdeclaration-after-statement") =
we
> have a warning if mixing variable declarations with code. For this patch =
though,
> doing that makes the code way clear, so decision was to add the debug cod=
e
> inside brackets whenever this warning pops up. We can change that, but th=
at'll
> cause more ifdefs in the same function.
>=20
> (b) In the symbol lookup helper function, we modify the parameter passed =
but
> even more, we return it as well! This is unusual and seems unnecessary, b=
ut was
> the strategy taken to allow embedding such function in the pr_debug() cal=
l.
>=20
> Not doing that would likely requiring 3 symbol_name variables to avoid
> concurrency (registering notifier A while calling notifier B) - we rely i=
n
> local variables as a serialization mechanism.
>=20
> We're open for suggestions in case this design is not appropriate;
> thanks in advance!
>=20
>  kernel/notifier.c | 48 +++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 46 insertions(+), 2 deletions(-)
>=20
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index ba005ebf4730..21032ebcde57 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -7,6 +7,22 @@
>  #include <linux/vmalloc.h>
>  #include <linux/reboot.h>
>=20
> +#ifdef CONFIG_DEBUG_NOTIFIERS
> +#include <linux/kallsyms.h>
> +
> +/*
> + *	Helper to get symbol names in case DEBUG_NOTIFIERS is set.
> + *	Return the modified parameter is a strategy used to achieve
> + *	the pr_debug() functionality - with this, function is only
> + *	executed if the dynamic debug tuning is effectively set.
> + */
> +static inline char *notifier_name(struct notifier_block *nb, char *sym_n=
ame)
> +{
> +	lookup_symbol_name((unsigned long)(nb->notifier_call), sym_name);
> +	return sym_name;
> +}
> +#endif
> +
>  /*
>   *	Notifier list for kernel code which wants to be called
>   *	at shutdown. This is used to stop any idling DMA operations
> @@ -34,20 +50,41 @@ static int notifier_chain_register(struct notifier_bl=
ock **nl,
>  	}
>  	n->next =3D *nl;
>  	rcu_assign_pointer(*nl, n);
> +
> +#ifdef CONFIG_DEBUG_NOTIFIERS
> +	{
> +		char sym_name[KSYM_NAME_LEN];
> +
> +		pr_info("notifiers: registered %s()\n",
> +			notifier_name(n, sym_name));
> +	}
> +#endif
>  	return 0;
>  }
>=20
>  static int notifier_chain_unregister(struct notifier_block **nl,
>  		struct notifier_block *n)
>  {
> +	int ret =3D -ENOENT;
> +
>  	while ((*nl) !=3D NULL) {
>  		if ((*nl) =3D=3D n) {
>  			rcu_assign_pointer(*nl, n->next);
> -			return 0;
> +			ret =3D 0;
> +			break;
>  		}
>  		nl =3D &((*nl)->next);
>  	}
> -	return -ENOENT;
> +
> +#ifdef CONFIG_DEBUG_NOTIFIERS
> +	if (!ret) {
> +		char sym_name[KSYM_NAME_LEN];
> +
> +		pr_info("notifiers: unregistered %s()\n",
> +			notifier_name(n, sym_name));
> +	}
> +#endif
> +	return ret;
>  }
>=20
>  /**
> @@ -80,6 +117,13 @@ static int notifier_call_chain(struct notifier_block =
**nl,
>  			nb =3D next_nb;
>  			continue;
>  		}
> +
> +		{
> +			char sym_name[KSYM_NAME_LEN];
> +
> +			pr_debug("notifiers: calling %s()\n",
> +				 notifier_name(nb, sym_name));
> +		}
>  #endif
>  		ret =3D nb->notifier_call(nb, val, v);
>=20
> --
> 2.36.0



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:31:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:31:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317534.536905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTWJ-0004Lt-BC; Fri, 29 Apr 2022 16:31:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317534.536905; Fri, 29 Apr 2022 16:31:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTWJ-0004Lm-8E; Fri, 29 Apr 2022 16:31:03 +0000
Received: by outflank-mailman (input) for mailman id 317534;
 Fri, 29 Apr 2022 16:31:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkTWI-0004Lc-Mq; Fri, 29 Apr 2022 16:31:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkTWI-0004CW-Lp; Fri, 29 Apr 2022 16:31:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkTWI-0001HN-AC; Fri, 29 Apr 2022 16:31:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkTWI-0003Jy-9o; Fri, 29 Apr 2022 16:31:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=saXnXRd9/jgNnAreWO05QMuR8otCKkrCDIgw+W32KCU=; b=OnfrJkrf6OSgSa8L/c+A84CpoS
	DQlUXfA2jATSIsGzqYMa5yktUyLiiAGZSE6fDeiTDDS9MtoS9rvO1SzP90Klw1c9yD7p/mXZEDGmE
	iOi266wylUZb7h4g4ILTvGdHR/dJVP8Tndm05WOBir1d+SwfmEf7IliM6xbFzU01XPzM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169872-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169872: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 16:31:02 +0000

flight 169872 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169872/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  696 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 16:47:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 16:47:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317542.536916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTm9-0005vR-Pa; Fri, 29 Apr 2022 16:47:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317542.536916; Fri, 29 Apr 2022 16:47:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTm9-0005vK-Ma; Fri, 29 Apr 2022 16:47:25 +0000
Received: by outflank-mailman (input) for mailman id 317542;
 Fri, 29 Apr 2022 16:47:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nkTm8-0005vE-55
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 16:47:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nkTm5-0004TU-P4; Fri, 29 Apr 2022 16:47:21 +0000
Received: from [54.239.6.189] (helo=[192.168.23.31])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nkTm5-0005AP-IX; Fri, 29 Apr 2022 16:47:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=6WNeOAuoVJX4b2K3RXMDurWp1ef33gch2WL59XaXl+8=; b=w9B09G9uLvaaA7UhGGaicAs5BB
	o9Ha3ZiLALwLrybNdLGNZxCtEfIFN3qSiNKCvOKZynFCcLSy15HZ0WpD7Rq1kkt0jTOT0on6xowcS
	VCv836wVO1O3FbUctUJyWrVaDAZMCnGjcxLBBLRnecCB875T+We19m9ZEhN3JeVMmN0s=;
Message-ID: <b24e8250-1a69-3b1c-d535-b9f8ac02e2db@xen.org>
Date: Fri, 29 Apr 2022 17:47:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [xen-unstable-smoke test] 169781: regressions - FAIL
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall.oss@gmail.com>,
 osstest service owner <osstest-admin@xenproject.org>,
 xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>,
 David Vrabel <dvrabel@amazon.co.uk>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <osstest-169781-mainreport@xen.org>
 <d1d3d81e-fe1d-fc1c-11b3-781263d8ba84@xen.org>
 <alpine.DEB.2.22.394.2204271556110.915916@ubuntu-linux-20-04-desktop>
 <CAJ=z9a1bu=3sX0rvWy+T-ey4363DMUEJvzkSqkQkTnvOQtT0=A@mail.gmail.com>
 <alpine.DEB.2.22.394.2204271622520.915916@ubuntu-linux-20-04-desktop>
 <ac0a0bf0-81a8-63c7-6a62-377672e24069@xen.org>
 <alpine.DEB.2.22.394.2204281647540.915916@ubuntu-linux-20-04-desktop>
 <cc097cb8-d04d-6441-d0f8-4027c7d0dc8e@xen.org>
 <alpine.DEB.2.22.394.2204290912150.1947187@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2204290912150.1947187@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 29/04/2022 17:15, Stefano Stabellini wrote:
>>> Which seems to be the right sequence to me. There must be an early boot
>>> phase where interrupts are disabled on a CPU but memory allocations are
>>> possible. If this was x86 with the tlbflush limitation, I would suggest
>>> to have per-cpu memory mapping areas so that we don't have to do any
>>> global tlb flushes with interrupts disabled.
>>>
>>> On ARM, we don't have the tlbflush limitation so we could do that but we
>>> wouldn't have much to gain from it.
>>>
>>> Also, this seems to be a bit of a special case, because in general we
>>> can move drivers initializations later after local_irq_enable(). But
>>> this is the interrupt controller driver itself -- we cannot move it
>>> after local_irq_enable().
>>>
>>> So maybe an ad-hoc solution could be acceptable?
>>
>> We don't need any ad-hoc solution here. We can register a CPU notifier that
>> will notify us when a CPU will be prepared. Something like below should work
>> (untested yet):
> 
> The CPU notifier is a good idea. It looks like the patch below got
> corrupted somehow by the mailer. If you send it as a proper patch I am
> happy to have a look.

Doh. I will send a proper patch once I have done some testing.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 17:00:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 17:00:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317548.536927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTyR-00089n-UH; Fri, 29 Apr 2022 17:00:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317548.536927; Fri, 29 Apr 2022 17:00:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkTyR-000897-RI; Fri, 29 Apr 2022 17:00:07 +0000
Received: by outflank-mailman (input) for mailman id 317548;
 Fri, 29 Apr 2022 17:00:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkTyR-00088R-4D; Fri, 29 Apr 2022 17:00:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkTyR-0004ix-0r; Fri, 29 Apr 2022 17:00:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkTyQ-0002Xe-GJ; Fri, 29 Apr 2022 17:00:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkTyQ-0005do-Fp; Fri, 29 Apr 2022 17:00:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=29PdUhK5NPjrMS6qtHUTmbR/NsDVytt1x/PvbiHXSB0=; b=KCUrMgFWVhf+KcqifxST8tHnwm
	zGTBw1hXUEKp5zKVdHjdkqOSiJn59w6PAhkjvQ5PACwsAzse96IxcfL/DOfUhtEmKN2m7ckDVP6lP
	pzD5dsWieWcqAEEp+211B7+X1a+lwsa5iytNlK2r2pzvuExgks/Y63iTt6YwAQvpxEFg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169873-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169873: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 17:00:06 +0000

flight 169873 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169873/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  697 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 17:07:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 17:07:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317556.536938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkU58-0000Tw-NU; Fri, 29 Apr 2022 17:07:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317556.536938; Fri, 29 Apr 2022 17:07:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkU58-0000Tp-J0; Fri, 29 Apr 2022 17:07:02 +0000
Received: by outflank-mailman (input) for mailman id 317556;
 Fri, 29 Apr 2022 17:07:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a2mH=VH=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1nkU56-0000Tj-PM
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 17:07:00 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c53f0d3a-c7de-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 19:06:58 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 6916F5C01AA;
 Fri, 29 Apr 2022 13:06:54 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Fri, 29 Apr 2022 13:06:54 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 29 Apr 2022 13:06:53 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c53f0d3a-c7de-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651252014; x=
	1651338414; bh=hoPTvo6B+AouZhrb2AIwb48FaEgvVx1kJ0prQGY283w=; b=N
	nRGLfFiXKKL5KSTX32rl+ZivpSRu3shaAwkqXvoOEZBKxDNyDwLAL+wI1i09v+YM
	pq5vdMUqe/RgIdr83BLFLo+MdqdZ5ZJ4bFHRJO1rpkbKqZNI1MCOFpL/iYIndxpa
	iPyWWCNEyCuNaGtNbffepaoZpV8QEqQmdbXF2VAhdSd8FT1DHviseDNL83jnqRgH
	pP16bkagfhrb4ghdTCWhOE6rFzmgvMBHkBg2TqzpEfAZ4e0OZz2nQf+XpDowjZWo
	neq9nteVUEb6EPyMwjuHxmMGYbO+gtJARtLI40tV0M0Q15BNv2flrF2ldS9fmuJk
	pdSdb5WdS1/VC/4rvFkbQ==
X-ME-Sender: <xms:LRtsYsj9D5xtmOmo1LW5PLMjXy0oTcXoeplxuVD6UkJsqzPOXLQepw>
    <xme:LRtsYlDaJn3AG_YBszi7OMsN0w53asTNUGH-udz62z44r63b-OUVwGCD1pYiOv0Ch
    FNa_layXQwsDWo>
X-ME-Received: <xmr:LRtsYkEsz8qCg9VW5xcBSgoRgyotuzYApUD4kFiZJCzsaJuNbKBx_EcKun6J>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudelgddutdejucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff
    gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:LRtsYtSpx-rB6nXM_v9RzxxM9hAJjhDQL5F1O9s1LwCh2-M2ZF0SUQ>
    <xmx:LRtsYpyLS_23q5--j25k1Ne85HpiNOPoXwigg4anJ0_FJImEggfSiw>
    <xmx:LRtsYr41TzVzzEOnM_8Ev01bgcF1u6RKxvHoKRKCn7ILwzlJzEvkRA>
    <xmx:LhtsYsoyK6oR6sgdCi1NYbLD3cv8YwEOd2c8Gl3f2zQCW4GvkJ6aBQ>
Date: Fri, 29 Apr 2022 13:06:42 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT
Message-ID: <YmwbKwJh1Fft2F1H@itl-email>
References: <Yl7aC2a+TtOaFtqZ@itl-email>
 <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com>
 <YmmUtiBkhEYvXHUB@itl-email>
 <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com>
 <YmsbD9ktQqB4U33o@itl-email>
 <c9a57c65-05f4-b566-10cb-92ce9ffe9e0d@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Cuhxi4/sgGauzhkg"
Content-Disposition: inline
In-Reply-To: <c9a57c65-05f4-b566-10cb-92ce9ffe9e0d@suse.com>


--Cuhxi4/sgGauzhkg
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 29 Apr 2022 13:06:42 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT

On Fri, Apr 29, 2022 at 10:40:42AM +0200, Jan Beulich wrote:
> On 29.04.2022 00:54, Demi Marie Obenour wrote:
> > On Thu, Apr 28, 2022 at 08:47:49AM +0200, Jan Beulich wrote:
> >> On 27.04.2022 21:08, Demi Marie Obenour wrote:
> >>> On Wed, Apr 27, 2022 at 10:56:34AM +0200, Jan Beulich wrote:
> >>>> On 19.04.2022 17:49, Demi Marie Obenour wrote:
> >>>>> This hypercall can be used to get the ESRT from the hypervisor.  It
> >>>>> returning successfully also indicates that Xen has reserved the ESR=
T and
> >>>>> it can safely be parsed by dom0.
> >>>>
> >>>> I'm not convinced of the need, and I view such an addition as incons=
istent
> >>>> with the original intentions. The pointer comes from the config tabl=
e,
> >>>> which Dom0 already has access to. All a Dom0 kernel may need to know=
 in
> >>>> addition is whether the range was properly reserved. This could be a=
chieved
> >>>> by splitting the EFI memory map entry in patch 2, instead of only sp=
litting
> >>>> the E820 derivation, as then XEN_FW_EFI_MEM_INFO can be used to find=
 out
> >>>> the range's type. Another way to find out would be for Dom0 to attem=
pt to
> >>>> map this area as MMIO, after first checking that no part of the rang=
e is in
> >>>> its own memory allocation. This 2nd approach may, however, not reall=
y be
> >>>> suitable for PVH Dom0, I think.
> >>>
> >>> On further thought, I think the hypercall approach is actually better
> >>> than reserving the ESRT.  I really do not want XEN_FW_EFI_MEM_INFO to
> >>> return anything other than the actual firmware-provided memory
> >>> information, and the current approach seems to require more and more
> >>> special-casing of the ESRT, not to mention potentially wasting memory
> >>> and splitting a potentially large memory region into two smaller ones.
> >>> By copying the entire ESRT into memory owned by Xen, the logic becomes
> >>> significantly simpler on both the Xen and dom0 sides.
> >>
> >> I actually did consider the option of making a private copy when you d=
id
> >> send the initial version of this, but I'm not convinced this simplifies
> >> things from a kernel perspective: They'd now need to discover the table
> >> by some entirely different means. In Linux at least such divergence
> >> "just for Xen" hasn't been liked in the past.
> >>
> >> There's also the question of how to propagate the information across
> >> kexec. But I guess that question exists even outside of Xen, with the
> >> area living in memory which the OS is expected to recycle.
> >=20
> > Indeed it does.  A simple rule might be, =E2=80=9COnly trust the ESRT i=
f it is
> > in memory of type EfiRuntimeServicesData.=E2=80=9D  That is easy to ach=
ieve by
> > monkeypatching the config table as you suggested below.
> >=20
> > I *am* worried that the config table might be mapped read-only on some
> > systems, in which case the overwrite would cause a fatal page fault.  Is
> > there a way for Xen to check for this?
>=20
> While in boot mode, aiui page tables aren't supposed to be enforcing
> access restrictions. Recall that on other architectures EFI even runs
> with paging disabled; this simply is not possible for x86-64.

Yikes!  No wonder firmware has nonexistent exploit mitigations.  They
really ought to start porting UEFI to Rust, with ASLR, NX, stack
canaries, a hardened allocator, and support for de-priviliged services
that run in user mode.

That reminds me: Can Xen itself run from ROM?  Xen is being ported to
POWER for use in Qubes OS, and one approach under consideration is to
have Xen and a mini-dom0 be part of the firmware.  Personally, I really
like this approach, as it makes untrusted storage domains much simpler.
If this should be a separate email thread, let me know.

> So
> portable firmware shouldn't map anything r/o. In principle the pointer
> could still be in ROM; I consider this unlikely, but we could check
> for that (just like we could do a page table walk to figure out
> whether a r/o mapping would prevent us from updating the field).

Is there a utility function that could be used for this?

> >  It could also be undefined behavior to modify it.
>=20
> That's the bigger worry I have.

Turns out that it is *not* undefined behavior, so long as
ExitBootServices() has not been called.  This is becaues EFI drivers
will modify the config table, so firmware cannot assume it to be
read-only.

> >>> Is using ebmalloc() to allocate a copy of the ESRT a reasonable optio=
n?
> >>
> >> I'd suggest to try hard to avoid ebmalloc(). It ought to be possible to
> >> make the copy before ExitBootServices(), via normal EFI allocation. If
> >> replacing a pointer in the config table was okay(ish), this could even
> >> be utilized to overcome the kexec problem.
> >=20
> > What type should I use for the allocation?  EfiLoaderData looks like the
> > most consistent choice, but I am not sure if memory so allocated remains
> > valid when Xen hands off to the OS, so EfiRuntimeServicesData might be a
> > better choice.
>=20
> It definitely is. We do recycle EfiLoaderData ourselves.

I wonder why the ESRT was not in EfiRuntimeServicesData to begin with.

> >  To avoid memory leaks from repeated kexec(), this could
> > be made conditional on the ESRT not being in memory of type
> > EfiRuntimeServicesData to begin with.
>=20
> Of course - there's no point relocating the blob when it already is
> immune to recycling.

Yup.  Is it reasonable for dom0 to check that the ESRT is in
EfiRuntimeServicesData when under Xen?

--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--Cuhxi4/sgGauzhkg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJsGysACgkQsoi1X/+c
IsHpiQ/9GcBfC/ZkYxkylp/rUR3BTDUMY8rF79DbBwa99MbZIkL2ztsRdSzq4hlc
jWsFsxNc06iBXoTDc/kTR82/LwYlJ8S6NtpV4nA13Ied60UqSk/TNa0LKe3r/F5j
BFgqIGHz4cdJ+ypE8WErONX/PniIFKEoctQzcOdxu8hL30fGNTWpIpl0RoxCeC14
hJVtlfNcSYUxSTs7innKFbY01osBWTzOa8F2N9EN95aGznSyahAbNWeCKF83NPto
XDlhVlYSMwMkgC9piYj92uMs/XZEL8A9g2ttGNqqXFK8UGM+Jz/7pnkii3y+8XlL
PI8O8zwAE7eyVaUqyu1GrjlQi3NKXsXMHQMwWmor2b5IENhVU2cVrPdWTpqmbTwX
JX/7TvPHg6jT++i8jakfmk2G2IIuw9cFZOihQIVQDJXXYqXDDWgvat6xSSt9qZXz
OeaQ0YtbxRFlgoU4qzUDAkohofUW0KpJcETJgtP8Yi3q5R6KJZ9vzez5sJFDZq08
obA+AWRQKQoEq0vRjZ8aOvewrSRH6vNm6KXS+gBSz7p5Yf7fR1CPrx21Hu5Xurx2
YzcMoeSs7WXzpo37+YVD5yDRXPYeWx/mGYdaAYQeJgBf+9oqx5yGbHVb/IBntUAQ
bKKOu8eyOQ3J0gvvBbJQy8/byiyKlzM8iXaxMywQmxjzLnIpl7U=
=m+lH
-----END PGP SIGNATURE-----

--Cuhxi4/sgGauzhkg--


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 17:10:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 17:10:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317567.536948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkU8c-0001uT-8D; Fri, 29 Apr 2022 17:10:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317567.536948; Fri, 29 Apr 2022 17:10:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkU8c-0001uM-5M; Fri, 29 Apr 2022 17:10:38 +0000
Received: by outflank-mailman (input) for mailman id 317567;
 Fri, 29 Apr 2022 17:10:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkU8a-0001tt-I5; Fri, 29 Apr 2022 17:10:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkU8a-0004td-FZ; Fri, 29 Apr 2022 17:10:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkU8a-0002rK-4t; Fri, 29 Apr 2022 17:10:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkU8a-00008s-4P; Fri, 29 Apr 2022 17:10:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=I05VGxE7Wzk+9HGMCMUFxBZ2jonm0V0MJWRcgJWQBbo=; b=uLkBfyZ+9x6nRbBU5RstdsIFeF
	mIf9nYpQWKgppS3MVxU3R9A+uzfLLm1WmZPZbnw1pNTaKvFQ9RDbsn4T/NHbfMvUH9Isy+mYslWwW
	xL4G0SiepnlwLqcODjKmYFDBeotXzEQxrU+Je1PJEWQQJg4Cw46aEnQb3pk568aWswyU=;
To: xen-devel@lists.xenproject.org
Subject: [xen-unstable bisection] complete test-arm64-arm64-libvirt-raw
Message-Id: <E1nkU8a-00008s-4P@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 17:10:36 +0000

branch xen-unstable
xenbranch xen-unstable
job test-arm64-arm64-libvirt-raw
testid xen-boot

Tree: libvirt git://xenbits.xen.org/libvirt.git
Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
  Bug not present: fbd2445558beff90eb9607308f0845b18a7a2b5a
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169871/


  commit fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
  Author: David Vrabel <dvrabel@amazon.co.uk>
  Date:   Tue Apr 26 10:33:01 2022 +0200
  
      page_alloc: assert IRQs are enabled in heap alloc/free
      
      Heap pages can only be safely allocated and freed with interrupts
      enabled as they may require a TLB flush which may send IPIs (on x86).
      
      Normally spinlock debugging would catch calls from the incorrect
      context, but not from stop_machine_run() action functions as these are
      called with spin lock debugging disabled.
      
      Enhance the assertions in alloc_xenheap_pages() and
      alloc_domheap_pages() to check interrupts are enabled. For consistency
      the same asserts are used when freeing heap pages.
      
      As an exception, when only 1 PCPU is online, allocations are permitted
      with interrupts disabled as any TLB flushes would be local only. This
      is necessary during early boot.
      
      Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
      Reviewed-by: Jan Beulich <jbeulich@suse.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-arm64-arm64-libvirt-raw.xen-boot.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-arm64-arm64-libvirt-raw.xen-boot --summary-out=tmp/169871.bisection-summary --basis-template=169775 --blessings=real,real-bisect,real-retry xen-unstable test-arm64-arm64-libvirt-raw xen-boot
Searching for failure / basis pass:
 169819 fail [host=rochester0] / 169775 [host=rochester1] 169756 [host=laxton1] 169723 [host=laxton1] 169694 [host=rochester1] 169666 ok.
Failure / basis pass flights: 169819 / 169666
Tree: libvirt git://xenbits.xen.org/libvirt.git
Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 da28439ba55b8a571032b3358af567cff749f612
Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 2419a159fb943c24a6f2439604b9fdb1478fcd08
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\
 dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen.git#a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42-a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 git://xenbits.xen.org/xen.git#2419a159fb943c24a6f2439604b9fdb1478fcd08-da28439ba55b8a571032b3358af567cff749f612
Loaded 5001 nodes in revision graph
Searching for test results:
 169635 [host=laxton1]
 169666 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 2419a159fb943c24a6f2439604b9fdb1478fcd08
 169694 [host=rochester1]
 169723 [host=laxton1]
 169756 [host=laxton1]
 169775 [host=rochester1]
 169798 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 53b705d02cec03861044e673536586bd1b2443bd
 169823 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 2419a159fb943c24a6f2439604b9fdb1478fcd08
 169829 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 53b705d02cec03861044e673536586bd1b2443bd
 169834 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 3f5d61466345ed2213de2d7e391b6cd6d4b86015
 169819 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 da28439ba55b8a571032b3358af567cff749f612
 169838 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 163071b1800304c962756789b4ef0ddb978059ba
 169844 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 da28439ba55b8a571032b3358af567cff749f612
 169852 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a
 169860 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
 169863 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a
 169867 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
 169870 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a
 169871 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
Searching for interesting versions
 Result found: flight 169666 (pass), for basis pass
 For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a, results HASH(0x5597e5c33e70) HASH(0x5597e5c38da8) HASH(0x5597e5c3e968) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f\
 7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 163071b1800304c962756789b4ef0ddb978059ba, results HASH(0x5597e5c2b6a8) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 3f5d61466345ed2213de2d7e391b6cd6d4b86015, results HASH(0x5597e5c3\
 56f8) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 2419a159fb943c24a6f2439604b9fdb1478fcd08, results HASH(0x5597e5c2b9a8) HASH(0x5597e5c2d0b0) Result found: flight 169798 (fail), for basis failure (at ancestor ~57)
 Repro found: flight 169823 (pass), for basis pass
 Repro found: flight 169844 (fail), for basis failure
 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a
No revisions left to test, checking graph state.
 Result found: flight 169852 (pass), for last pass
 Result found: flight 169860 (fail), for first failure
 Repro found: flight 169863 (pass), for last pass
 Repro found: flight 169867 (fail), for first failure
 Repro found: flight 169870 (pass), for last pass
 Repro found: flight 169871 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
  Bug not present: fbd2445558beff90eb9607308f0845b18a7a2b5a
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169871/


  commit fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
  Author: David Vrabel <dvrabel@amazon.co.uk>
  Date:   Tue Apr 26 10:33:01 2022 +0200
  
      page_alloc: assert IRQs are enabled in heap alloc/free
      
      Heap pages can only be safely allocated and freed with interrupts
      enabled as they may require a TLB flush which may send IPIs (on x86).
      
      Normally spinlock debugging would catch calls from the incorrect
      context, but not from stop_machine_run() action functions as these are
      called with spin lock debugging disabled.
      
      Enhance the assertions in alloc_xenheap_pages() and
      alloc_domheap_pages() to check interrupts are enabled. For consistency
      the same asserts are used when freeing heap pages.
      
      As an exception, when only 1 PCPU is online, allocations are permitted
      with interrupts disabled as any TLB flushes would be local only. This
      is necessary during early boot.
      
      Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
      Reviewed-by: Jan Beulich <jbeulich@suse.com>

Revision graph left in /home/logs/results/bisect/xen-unstable/test-arm64-arm64-libvirt-raw.xen-boot.{dot,ps,png,html,svg}.
----------------------------------------
169871: tolerable FAIL

flight 169871 xen-unstable real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/169871/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw  8 xen-boot                fail baseline untested


jobs:
 build-arm64-libvirt                                          pass    
 test-arm64-arm64-libvirt-raw                                 fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 17:17:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 17:17:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317576.536963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUEy-0002cP-1p; Fri, 29 Apr 2022 17:17:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317576.536963; Fri, 29 Apr 2022 17:17:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUEx-0002cI-US; Fri, 29 Apr 2022 17:17:11 +0000
Received: by outflank-mailman (input) for mailman id 317576;
 Fri, 29 Apr 2022 17:17:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E21X=VH=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1nkUEw-0002cC-TH
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 17:17:11 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-cusazlp170100000.outbound.protection.outlook.com
 [2a01:111:f403:c111::])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3275c36e-c7e0-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 19:17:09 +0200 (CEST)
Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21)
 by PH7PR21MB3044.namprd21.prod.outlook.com (2603:10b6:510:1e0::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.1; Fri, 29 Apr
 2022 17:16:59 +0000
Received: from PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df]) by PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df%6]) with mapi id 15.20.5227.006; Fri, 29 Apr 2022
 17:16:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3275c36e-c7e0-11ec-8fc4-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=URt1keDbmBYpByak8BMw2WLHo2bkoLNKsyAqefiLdx4hcDh+VaWHHr/IrnwKxtuwyWvonjTN7LNBD4ywp3IUkZtg3fLTBzc03nkASHfSBaLKiY9txUkZGTYizwG/bljAw1XgI7zDOp+Ltm2PBHQwuet/bgAgcycp+FnQXrE9tGuLxsSfzl9WSDOrbTjre+mvldRx8oS/9KThf2H9OzphMR3ZbHlB33XoUh3i4RpaxuFrhpJPhRNP+NFW2e5dc8C+bT8+8SE/p63rmUfijzQOFTJ4dm/pMJw6F/KMhXQ9f+oTSeh0RCRwvKAhtLb8EwzoNeQdbmCqox+npnAHmhVfhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z1MSaduGN1AEz6gGdbjAeFMSbDhhPZ73iNsd4tjQN9I=;
 b=k/3c/R2wdnbzLU/OcdhOUbhlE5FrxBN4OZBtNLQVN9r5snmxzPZBdl+XYEUVUPkkr97EmA6lxq+ZPVP1MOARmOsLC2hcEvVIIP5YYa4LfrS0tx98M6XHPrzqIteeyXrbotwEcNcmYnIfwiMNZqK5t+8d+pMODVq95oDkBqljSL2O70QPckEBDgIJKxlneoyB/MsSiXDrAhoPpTYuDG1nmYHA68IubyI72MSjS0zE7eS8H7jGsFyL3YjdiEwGgbVd6fG/Xa4KoKvGxjc/x5CbfDxQduPmrRvYXCEzz4fCMSXBZsSeVf2KvjWWg+vmJU8I3RoBlzjNDXTtViDmpoZ4Jg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z1MSaduGN1AEz6gGdbjAeFMSbDhhPZ73iNsd4tjQN9I=;
 b=cS9+179RG/61x4VdHipVPHqqRTJBnmdfe6m8GNL4SybzXHAHGDXPPpyHqr8XdYPz6jNfk4L58J6vQvT4W0sPT6R4oBVYiW0q20tFmK4wguWLRFEkPwtqH1JMI4Cn4bqUNJuds1zkHPNsQvZEKKZt7StxIoQLPjh78p6FPwwvEXg=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>, "bhe@redhat.com" <bhe@redhat.com>,
	"pmladek@suse.com" <pmladek@suse.com>, "kexec@lists.infradead.org"
	<kexec@lists.infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>, "coresight@lists.linaro.org"
	<coresight@lists.linaro.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "linux-alpha@vger.kernel.org"
	<linux-alpha@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-leds@vger.kernel.org"
	<linux-leds@vger.kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linux-parisc@vger.kernel.org"
	<linux-parisc@vger.kernel.org>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-xtensa@linux-xtensa.org"
	<linux-xtensa@linux-xtensa.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "openipmi-developer@lists.sourceforge.net"
	<openipmi-developer@lists.sourceforge.net>, "rcu@vger.kernel.org"
	<rcu@vger.kernel.org>, "sparclinux@vger.kernel.org"
	<sparclinux@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "x86@kernel.org" <x86@kernel.org>,
	"kernel-dev@igalia.com" <kernel-dev@igalia.com>, "kernel@gpiccoli.net"
	<kernel@gpiccoli.net>, "halves@canonical.com" <halves@canonical.com>,
	"fabiomirmar@gmail.com" <fabiomirmar@gmail.com>,
	"alejandro.j.jimenez@oracle.com" <alejandro.j.jimenez@oracle.com>,
	"andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
	"arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
	"corbet@lwn.net" <corbet@lwn.net>, "d.hatayama@jp.fujitsu.com"
	<d.hatayama@jp.fujitsu.com>, "dave.hansen@linux.intel.com"
	<dave.hansen@linux.intel.com>, "dyoung@redhat.com" <dyoung@redhat.com>,
	"feng.tang@intel.com" <feng.tang@intel.com>, "gregkh@linuxfoundation.org"
	<gregkh@linuxfoundation.org>, "hidehiro.kawai.ez@hitachi.com"
	<hidehiro.kawai.ez@hitachi.com>, "jgross@suse.com" <jgross@suse.com>,
	"john.ogness@linutronix.de" <john.ogness@linutronix.de>,
	"keescook@chromium.org" <keescook@chromium.org>, "luto@kernel.org"
	<luto@kernel.org>, "mhiramat@kernel.org" <mhiramat@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>, "paulmck@kernel.org"
	<paulmck@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>, "senozhatsky@chromium.org"
	<senozhatsky@chromium.org>, "stern@rowland.harvard.edu"
	<stern@rowland.harvard.edu>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>, vkuznets <vkuznets@redhat.com>,
	"will@kernel.org" <will@kernel.org>, Andrea Parri <parri.andrea@gmail.com>,
	Dexuan Cui <decui@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, KY
 Srinivasan <kys@microsoft.com>, Stephen Hemminger <sthemmin@microsoft.com>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>, Wei Liu <wei.liu@kernel.org>
Subject: RE: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and
 refactor Hyper-V panic notifiers
Thread-Topic: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and
 refactor Hyper-V panic notifiers
Thread-Index: AQHYWonHTKAKlsJlK0mi6B2rKp5WnK0HF4GA
Date: Fri, 29 Apr 2022 17:16:59 +0000
Message-ID:
 <PH0PR21MB30250C9246FFF36AFB1DFDECD7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-17-gpiccoli@igalia.com>
In-Reply-To: <20220427224924.592546-17-gpiccoli@igalia.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=5894e0d7-48ac-4694-a612-22bf4cd0226a;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-04-29T16:29:25Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7ee08c10-8795-4ffb-8d36-08da2a0411b3
x-ms-traffictypediagnostic: PH7PR21MB3044:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs:
 <PH7PR21MB30444C7AF44CF950E0362EC8D7FC9@PH7PR21MB3044.namprd21.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 uv/yl6f/BdJJwj8MKE54LMCpY16sv/VMkBm5Bux19qb9yZFrMo9werEEvN+0ub2kM1sB+PlTVhjAKNi7/fAUcGChJ7882bpNX/5eNWYRxEU2nPTyROmnPjCO3rMdBW03Gfo3GhFCSqUf2N679RELIWadFJLXkHDjI09/tT8nHupgY9maWtlGoafg653LSsQMecJ2dqfViZIJPIA5buIfNLkfZvoCHchqHyXx3MgF69kRm/AlkA/oomMEc0jADv3X00DdbQermZhuvSUPLpRQFsrn+i5VBHkfzA+0C1IMmAk5gFfY3yFNYXETPPSvJnIewiA2i9WbTbpIiPknKzh7ZCgi6O+YewZimrgwuRVXoM3uyhtAGYp0J3dSbNL/WCFmYCosfJyWyt/OAqswR0d8FYpJBwDeJ4y4fFMji/s+9cA+0JSVh8ZTzLqsnZ5URa1DFUy5Byj7ZJFFcUPe5n/8vmKCvqc2xCIQ7w4KkA7xY/SVhIe/OoC4UvaR+LU4oaLhwmYw7MBFAtzRLfOfUeywHgCWd2I/egtIb31EuvqNY/H3gYQf1Jk7tMZrYgIUjP1b0S8diKZm+BMHaprLTTbxbrCVF++LNp9HSVDZLP+GxhmiD2C425/smPWmAZvZVetnj8WAwXjCqxYLRcy8jXhSgugUTMdJYu0BHOYNI1aRnfbAdTYG60e9hFN7/n/NFgvFkCI/t2nDZ4HgVul8vHdv7V8PsMJGF4ncet9B/nPiBjh10lp9xXhtYTi0gG1H7JYQ
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(2906002)(186003)(4326008)(66446008)(66946007)(76116006)(66476007)(64756008)(8676002)(5660300002)(316002)(26005)(7696005)(6506007)(66556008)(55016003)(86362001)(33656002)(9686003)(71200400001)(508600001)(7416002)(122000001)(8990500004)(83380400001)(110136005)(8936002)(54906003)(52536014)(10290500003)(38070700005)(38100700002)(30864003)(7406005)(7366002)(82950400001)(82960400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?xaf3lHKNZ0TtwG8wQrQ8tlZwWch2tizm/QDdnEDkq6EX57mCLA2YJFCxqIZo?=
 =?us-ascii?Q?/CiZ2Wp7M+/9M/RMUZeQNDuunS7CgGnS7veCbONC6g780Sycjb9YsaA4s/Pl?=
 =?us-ascii?Q?hbioPJaCLOxELo4NhFekChWnbffzm/8SyQbP0B3b/SwpPEQynEywZ9T9EgN8?=
 =?us-ascii?Q?nVDMcl+gOQpToDUZP7guhbueiRbTuKnpv42BoYbUUk5cJptHKkt3gcnWlKbF?=
 =?us-ascii?Q?FNzFpJEfMewlRPxEYu4pOFtBohCAtJ7ngQnzzSClgslx9PBpAuJQOISuf4Q8?=
 =?us-ascii?Q?5FCiDeskIfldEO3cPhEfDGNW7OK4qYUE6z1MhNiz0Ze/jKtWM2HmfdjHPdMN?=
 =?us-ascii?Q?JSdV45AoPuxl1kVQzAKZ7YmwTuf2XjN0p/D3XO6Cim21s7iTi5rqIw9Kmzlv?=
 =?us-ascii?Q?uKpmGyuce/qMehcSEQK0ZvPny4o5LA/cqwV+FmcPlsw04kSJ5Wj+4Mi8Nv8Y?=
 =?us-ascii?Q?ME60uS7JIkR4YuR7D+5kzNQVsHSgtLCGrGGA1pbZ0rng6XAy4ysv3azC1CFP?=
 =?us-ascii?Q?fi5HYxL3dYUVWyT9ZRsKmYBQ2jaPenexEzDBprEkhmBisxUnwd18U8dQaLvh?=
 =?us-ascii?Q?flPcRN1fqjCs82TJFxe86kVYnGopY8jCmrW1NZZm+uTPgLGoPn7AAog/7UQy?=
 =?us-ascii?Q?xpJV/hGNZ2M5LbzKFil3wL4WbW9BJYrJZ+sh7qZ4wG0U7NACvCE2T29EI2TY?=
 =?us-ascii?Q?F+/gZE8msGZOCQlmoDnzqGaX3K42HrR1KHWaCvRVy0WpUiQi+PkRTq2haB/x?=
 =?us-ascii?Q?z3hd/rOLlyLyQvMfgSSGWcL2dCIQntOCQzdi1FzIhvbGg6Uqqj4gFD94S+La?=
 =?us-ascii?Q?azrzqYdWvV64BMdgHHO3hiV+PDyZ850oaA/IVIQDbyYo6UoKLCjeHcB6dOsC?=
 =?us-ascii?Q?ExwBv7rOmH5WAgWxvSWs7uCEmf2hPjHkXXFutxNc6oZF0NQTm6ZLe2US3kV1?=
 =?us-ascii?Q?2dBv7i2lYHEWtEZHYuRMjqI0eoQjmgMtSFMK2nyvB6wGjDJQnQJnzCZJzu+k?=
 =?us-ascii?Q?8X/tmGO5a/QXrvo8DAOZDXRF8yHMAtW2qbOSHh/f0N/Kr/5wmi5kq66298Vg?=
 =?us-ascii?Q?8F9zr2wKnP7RmZoW1RLpUofCKw7CRwzK/3h4oJlWC/YBloHR+PtmiI+lFTHj?=
 =?us-ascii?Q?0Q7RPLTqPND5oJNPnGNVTtO82ypCISGnOAPhX+I8iAp4xt8GikiYT3/zOzyo?=
 =?us-ascii?Q?My24qDFKD9+w7NefTZumfuOW4veQKD9Sz/ZTpC7/M3HSKSOgAh864XoJ7hEr?=
 =?us-ascii?Q?C+rwnaGCChVvzEJvtXrvNg1Gb+HMAYmlurj90jmdmxJuRZsP8HvzRspvb77S?=
 =?us-ascii?Q?QAqiNF7J3kXU2eV4M2FvGorefimM0Kd1EVf01/cA1gHB6RupvcUx7q0rQDRC?=
 =?us-ascii?Q?kwyO3cCxyt/dlg7Cywpgili6yGcb9sSsp8l4bOeQdGWbQg7F7ufP2dZ8T6Ex?=
 =?us-ascii?Q?ZVpSfM/PJGqMnIlPp/M2RiTLvV2cQa7rNEDxcwrSOe9wG0UETJsRlM5yY8Vb?=
 =?us-ascii?Q?cZd2InecTanmGqrZn8ovT7yWLiknKtoCLaAI084lTiE0xZhnmwyA5/SpPBeJ?=
 =?us-ascii?Q?FYik20mn3+zMwimzMeSaoN434cXne+xZ2gUMAKwOzDrB++oZk+qUDjSI9uTG?=
 =?us-ascii?Q?5kId3mU1gxwsyYmNcOeq/m5aGZlqw4SkObPDGXzlAJELgp+LVvVAY5nwIBS2?=
 =?us-ascii?Q?MvMluW0c9uKvW3opqyw6mG65vTKGcoCygp7Wlcgnp7avbIHQj302J+WTNjSb?=
 =?us-ascii?Q?rjUdg07eny+pqvz9K0cc8XoH4Y64Epw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ee08c10-8795-4ffb-8d36-08da2a0411b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 17:16:59.0862
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9qRMIqeGqCT6lpOJ0z77u+sW/YCPHCtrfjizxejds1UxGOcvlUAbEteC59UC9TmkcRx/jSQ3DPCoipx7zC8pg4LKbOtmgrY8pLvBUZL2IBQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR21MB3044

From: Guilherme G. Piccoli <gpiccoli@igalia.com> Sent: Wednesday, April 27,=
 2022 3:49 PM
>=20
> Currently Hyper-V guests are among the most relevant users of the panic
> infrastructure, like panic notifiers, kmsg dumpers, etc. The reasons rely
> both in cleaning-up procedures (closing a hypervisor <-> guest connection=
,
> disabling a paravirtualized timer) as well as to data collection (sending
> panic information to the hypervisor) and framebuffer management.
>=20
> The thing is: some notifiers are related to others, ordering matters, som=
e
> functionalities are duplicated and there are lots of conditionals behind
> sending panic information to the hypervisor. This patch, as part of an
> effort to clean-up the panic notifiers mechanism and better document
> things, address some of the issues/complexities of Hyper-V panic handling
> through the following changes:
>=20
> (a) We have die and panic notifiers on vmbus_drv.c and both have goals of
> sending panic information to the hypervisor, though the panic notifier is
> also responsible for a cleaning-up procedure.
>=20
> This commit clears the code by splitting the panic notifier in two, one
> for closing the vmbus connection whereas the other is only for sending
> panic info to hypervisor. With that, it was possible to merge the die and
> panic notifiers in a single/well-documented function, and clear some
> conditional complexities on sending such information to the hypervisor.
>=20
> (b) The new panic notifier created after (a) is only doing a single thing=
:
> cleaning the vmbus connection. This procedure might cause a delay (due to
> hypervisor I/O completion), so we postpone that to run late. But more
> relevant: this *same* vmbus unloading happens in the crash_shutdown()
> handler, so if kdump is set, we can safely skip this panic notifier and
> defer such clean-up to the kexec crash handler.

While the last sentence is true for Hyper-V on x86/x64, it's not true for
Hyper-V on ARM64.  x86/x64 has the 'machine_ops' data structure
with the ability to provide a custom crash_shutdown() function, which
Hyper-V does in the form of hv_machine_crash_shutdown().  But ARM64
has no mechanism to provide such a custom function that will eventually
do the needed vmbus_initiate_unload() before running kdump.

I'm not immediately sure what the best solution is for ARM64.  At this
point, I'm just pointing out the problem and will think about the tradeoffs
for various possible solutions.  Please do the same yourself. :-)

>=20
> (c) There is also a Hyper-V framebuffer panic notifier, which relies in
> doing a vmbus operation that demands a valid connection. So, we must
> order this notifier with the panic notifier from vmbus_drv.c, in order to
> guarantee that the framebuffer code executes before the vmbus connection
> is unloaded.

Patch 21 of this set puts the Hyper-V FB panic notifier on the pre_reboot
notifier list, which means it won't execute before the VMbus connection
unload in the case of kdump.   This notifier is making sure that Hyper-V
is notified about the last updates made to the frame buffer before the
panic, so maybe it needs to be put on the hypervisor notifier list.  It
sends a message to Hyper-V over its existing VMbus channel, but it
does not wait for a reply.  It does, however, obtain a spin lock on the
ring buffer used to communicate with Hyper-V.   Unless someone has
a better suggestion, I'm inclined to take the risk of blocking on that
spin lock.

>=20
> Also, this commit removes a useless header.
>=20
> Although there is code rework and re-ordering, we expect that this change
> has no functional regressions but instead optimize the path and increase
> panic reliability on Hyper-V. This was tested on Hyper-V with success.
>=20
> Fixes: 792f232d57ff ("Drivers: hv: vmbus: Fix potential crash on module u=
nload")
> Fixes: 74347a99e73a ("x86/Hyper-V: Unload vmbus channel in hv panic callb=
ack")

The "Fixes:" tags imply that these changes should be backported to older
longterm kernel versions, which I don't think is the case.  There is a
dependency on Patch 14 of your series where PANIC_NOTIFIER is
introduced.

> Cc: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> Cc: Michael Kelley <mikelley@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>
> Cc: Wei Liu <wei.liu@kernel.org>
> Tested-by: Fabio A M Martins <fabiomirmar@gmail.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>=20
> Special thanks to Michael Kelley for the good information about the Hyper=
-V
> panic path in email threads some months ago, and to Fabio for the testing
> performed.
>=20
> Michael and all Microsoft folks: a careful analysis to double-check our c=
hanges
> and assumptions here is really appreciated, this code is complex and intr=
icate,
> it is possible some corner case might have been overlooked.
>=20
> Thanks in advance!
>=20
>  drivers/hv/vmbus_drv.c          | 109 ++++++++++++++++++++------------
>  drivers/video/fbdev/hyperv_fb.c |   8 +++
>  2 files changed, 76 insertions(+), 41 deletions(-)
>=20
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 14de17087864..f37f12d48001 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -24,11 +24,11 @@
>  #include <linux/sched/task_stack.h>
>=20
>  #include <linux/delay.h>
> -#include <linux/notifier.h>
>  #include <linux/panic_notifier.h>
>  #include <linux/ptrace.h>
>  #include <linux/screen_info.h>
>  #include <linux/kdebug.h>
> +#include <linux/kexec.h>
>  #include <linux/efi.h>
>  #include <linux/random.h>
>  #include <linux/kernel.h>
> @@ -68,51 +68,75 @@ static int hyperv_report_reg(void)
>  	return !sysctl_record_panic_msg || !hv_panic_page;
>  }
>=20
> -static int hyperv_panic_event(struct notifier_block *nb, unsigned long v=
al,
> +/*
> + * The panic notifier below is responsible solely for unloading the
> + * vmbus connection, which is necessary in a panic event. But notice
> + * that this same unloading procedure is executed in the Hyper-V
> + * crash_shutdown() handler [see hv_crash_handler()], which basically
> + * means that we can postpone its execution if we have kdump set,
> + * since it will run the crash_shutdown() handler anyway. Even more
> + * intrincated is the relation of this notifier with Hyper-V framebuffer

s/intrincated/intricate/

> + * panic notifier - we need vmbus connection alive there in order to
> + * succeed, so we need to order both with each other [for reference see
> + * hvfb_on_panic()] - this is done using notifiers' priorities.
> + */
> +static int hv_panic_vmbus_unload(struct notifier_block *nb, unsigned lon=
g val,
>  			      void *args)
> +{
> +	if (!kexec_crash_loaded())

I'm not clear on the purpose of this condition.  I think it means
we will skip the vmbus_initiate_unload() if a panic occurs in the
kdump kernel.  Is there a reason a panic in the kdump kernel
should be treated differently?  Or am I misunderstanding?

> +		vmbus_initiate_unload(true);
> +
> +	return NOTIFY_DONE;
> +}
> +static struct notifier_block hyperv_panic_vmbus_unload_block =3D {
> +	.notifier_call	=3D hv_panic_vmbus_unload,
> +	.priority	=3D INT_MIN + 1, /* almost the latest one to execute */
> +};
> +
> +/*
> + * The following callback works both as die and panic notifier; its
> + * goal is to provide panic information to the hypervisor unless the
> + * kmsg dumper is gonna be used [see hv_kmsg_dump()], which provides
> + * more information but is not always available.
> + *
> + * Notice that both the panic/die report notifiers are registered only
> + * if we have the capability HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE set.
> + */
> +static int hv_die_panic_notify_crash(struct notifier_block *nb,
> +				     unsigned long val, void *args)
>  {
>  	struct pt_regs *regs;
> +	bool is_die;
>=20
> -	vmbus_initiate_unload(true);
> -
> -	/*
> -	 * Hyper-V should be notified only once about a panic.  If we will be
> -	 * doing hv_kmsg_dump() with kmsg data later, don't do the notification
> -	 * here.
> -	 */
> -	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE
> -	    && hyperv_report_reg()) {
> +	/* Don't notify Hyper-V unless we have a die oops event or panic. */
> +	switch (val) {
> +	case DIE_OOPS:
> +		is_die =3D true;
> +		regs =3D ((struct die_args *)args)->regs;
> +		break;
> +	case PANIC_NOTIFIER:
> +		is_die =3D false;
>  		regs =3D current_pt_regs();
> -		hyperv_report_panic(regs, val, false);
> -	}
> -	return NOTIFY_DONE;
> -}
> -
> -static int hyperv_die_event(struct notifier_block *nb, unsigned long val=
,
> -			    void *args)
> -{
> -	struct die_args *die =3D args;
> -	struct pt_regs *regs =3D die->regs;
> -
> -	/* Don't notify Hyper-V if the die event is other than oops */
> -	if (val !=3D DIE_OOPS)
> +		break;
> +	default:
>  		return NOTIFY_DONE;
> +	}
>=20
>  	/*
> -	 * Hyper-V should be notified only once about a panic.  If we will be
> -	 * doing hv_kmsg_dump() with kmsg data later, don't do the notification
> -	 * here.
> +	 * Hyper-V should be notified only once about a panic/die. If we will
> +	 * be calling hv_kmsg_dump() later with kmsg data, don't do the
> +	 * notification here.
>  	 */
>  	if (hyperv_report_reg())
> -		hyperv_report_panic(regs, val, true);
> +		hyperv_report_panic(regs, val, is_die);
> +
>  	return NOTIFY_DONE;
>  }
> -
> -static struct notifier_block hyperv_die_block =3D {
> -	.notifier_call =3D hyperv_die_event,
> +static struct notifier_block hyperv_die_report_block =3D {
> +	.notifier_call =3D hv_die_panic_notify_crash,
>  };
> -static struct notifier_block hyperv_panic_block =3D {
> -	.notifier_call =3D hyperv_panic_event,
> +static struct notifier_block hyperv_panic_report_block =3D {
> +	.notifier_call =3D hv_die_panic_notify_crash,
>  };
>=20
>  static const char *fb_mmio_name =3D "fb_range";
> @@ -1589,16 +1613,17 @@ static int vmbus_bus_init(void)
>  		if (hyperv_crash_ctl & HV_CRASH_CTL_CRASH_NOTIFY_MSG)
>  			hv_kmsg_dump_register();
>=20
> -		register_die_notifier(&hyperv_die_block);
> +		register_die_notifier(&hyperv_die_report_block);
> +		atomic_notifier_chain_register(&panic_notifier_list,
> +						&hyperv_panic_report_block);
>  	}
>=20
>  	/*
> -	 * Always register the panic notifier because we need to unload
> -	 * the VMbus channel connection to prevent any VMbus
> -	 * activity after the VM panics.
> +	 * Always register the vmbus unload panic notifier because we
> +	 * need to shut the VMbus channel connection on panic.
>  	 */
>  	atomic_notifier_chain_register(&panic_notifier_list,
> -			       &hyperv_panic_block);
> +			       &hyperv_panic_vmbus_unload_block);
>=20
>  	vmbus_request_offers();
>=20
> @@ -2817,15 +2842,17 @@ static void __exit vmbus_exit(void)
>=20
>  	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) {
>  		kmsg_dump_unregister(&hv_kmsg_dumper);
> -		unregister_die_notifier(&hyperv_die_block);
> +		unregister_die_notifier(&hyperv_die_report_block);
> +		atomic_notifier_chain_unregister(&panic_notifier_list,
> +						&hyperv_panic_report_block);
>  	}
>=20
>  	/*
> -	 * The panic notifier is always registered, hence we should
> +	 * The vmbus panic notifier is always registered, hence we should
>  	 * also unconditionally unregister it here as well.
>  	 */
>  	atomic_notifier_chain_unregister(&panic_notifier_list,
> -					 &hyperv_panic_block);
> +					&hyperv_panic_vmbus_unload_block);
>=20
>  	free_page((unsigned long)hv_panic_page);
>  	unregister_sysctl_table(hv_ctl_table_hdr);
> diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv=
_fb.c
> index c8e0ea27caf1..f3494b868a64 100644
> --- a/drivers/video/fbdev/hyperv_fb.c
> +++ b/drivers/video/fbdev/hyperv_fb.c
> @@ -1244,7 +1244,15 @@ static int hvfb_probe(struct hv_device *hdev,
>  	par->fb_ready =3D true;
>=20
>  	par->synchronous_fb =3D false;
> +
> +	/*
> +	 * We need to be sure this panic notifier runs _before_ the
> +	 * vmbus disconnect, so order it by priority. It must execute
> +	 * before the function hv_panic_vmbus_unload() [drivers/hv/vmbus_drv.c]=
,
> +	 * which is almost at the end of list, with priority =3D INT_MIN + 1.
> +	 */
>  	par->hvfb_panic_nb.notifier_call =3D hvfb_on_panic;
> +	par->hvfb_panic_nb.priority =3D INT_MIN + 10,
>  	atomic_notifier_chain_register(&panic_notifier_list,
>  				       &par->hvfb_panic_nb);
>=20
> --
> 2.36.0



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 17:31:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 17:31:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317583.536973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUSW-0004x6-Bz; Fri, 29 Apr 2022 17:31:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317583.536973; Fri, 29 Apr 2022 17:31:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUSW-0004wz-90; Fri, 29 Apr 2022 17:31:12 +0000
Received: by outflank-mailman (input) for mailman id 317583;
 Fri, 29 Apr 2022 17:31:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E21X=VH=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1nkUSV-0004wt-52
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 17:31:11 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-eus2azlp170100001.outbound.protection.outlook.com
 [2a01:111:f403:c110::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 279b1139-c7e2-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 19:31:09 +0200 (CEST)
Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21)
 by DM5PR21MB0761.namprd21.prod.outlook.com (2603:10b6:3:a3::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.6; Fri, 29 Apr
 2022 17:30:45 +0000
Received: from PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df]) by PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df%6]) with mapi id 15.20.5227.006; Fri, 29 Apr 2022
 17:30:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 279b1139-c7e2-11ec-a405-831a346695d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XTnYIoTyFDjM5JUklkUkeZSVHdB/KbpjWUKMrwxPKtMBCELnhwwVxh3SyOWp+1En+lBB80Pmi2MOFKxrdFIAO1tVkwmz31aHf3c0WXJgTJO4H8WZ8wWDi+ZLogiDuQYv43MvDvBMsiShc3M4W6FuR/wPAy1Edr9Ejm4EmMmHgoezg8BixUKBI7OUSVmU0/dlrFC57AU3xqY9yjnUIy1vXdv9nlj9XWZBE29iaC+cnW5L/0PZPRadrHbf3+g4UC7EMWCusYpZlk+0nFrTbZZbgil9754PaHuq87Xs5x2NPKguVl+xJisWMMhTPBDhnZUpXDwN8SYDRRPJVsZL70yHUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1lb7HJaoovhC6aIWP9rKJ4VgGH06NMpJYC4i1j5JxsI=;
 b=cllHTkoF7/QGmRKVAfZLbB2EINE8+FyPVK/DhZU1IvHmvPGKiv37XAYsy2ztQQZBV0S2wCJT80Qzf+ODT8pn9hxUAriFcnDhg0MQtoQDmk99sbR4eoHjIBnESHA8RFpDL0QZ9TQIFYrTQ1sa0LxWuC2wFr9KEoOKWkswbeTWdtT8qAKyinjpnI2y79/6J5xxB374yWzqyHNG2OYd8Xse8Q49miwVkxuAjSdxGMc/d6kQcSSLV+ETreRF9TXQzVouszl+GMZqY9q76aTtD+gRUELbgbQQXH756uY5Jmx8Y7/63+0pYcIqxk4hn9ecg4cqgoQJyCOfZkljvQwjcZgnhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1lb7HJaoovhC6aIWP9rKJ4VgGH06NMpJYC4i1j5JxsI=;
 b=QSQxqWpJqa0hyyFA2XDVFvIF6LUCH46zWRApVCGDtXYWI6H38+ofNY2enqE+SH/qIy3nfoGgoNGiAJVzByKlaoklJK7MeqAmDXe2OQgK7UNp04ELgeYfkgc7YvIny43HOtGavqk6L/OU2tQ5UUDZXTksZysdcEpxlosr405yQD8=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>, "bhe@redhat.com" <bhe@redhat.com>,
	"pmladek@suse.com" <pmladek@suse.com>, "kexec@lists.infradead.org"
	<kexec@lists.infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>, "coresight@lists.linaro.org"
	<coresight@lists.linaro.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "linux-alpha@vger.kernel.org"
	<linux-alpha@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-leds@vger.kernel.org"
	<linux-leds@vger.kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linux-parisc@vger.kernel.org"
	<linux-parisc@vger.kernel.org>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-xtensa@linux-xtensa.org"
	<linux-xtensa@linux-xtensa.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "openipmi-developer@lists.sourceforge.net"
	<openipmi-developer@lists.sourceforge.net>, "rcu@vger.kernel.org"
	<rcu@vger.kernel.org>, "sparclinux@vger.kernel.org"
	<sparclinux@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "x86@kernel.org" <x86@kernel.org>,
	"kernel-dev@igalia.com" <kernel-dev@igalia.com>, "kernel@gpiccoli.net"
	<kernel@gpiccoli.net>, "halves@canonical.com" <halves@canonical.com>,
	"fabiomirmar@gmail.com" <fabiomirmar@gmail.com>,
	"alejandro.j.jimenez@oracle.com" <alejandro.j.jimenez@oracle.com>,
	"andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
	"arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
	"corbet@lwn.net" <corbet@lwn.net>, "d.hatayama@jp.fujitsu.com"
	<d.hatayama@jp.fujitsu.com>, "dave.hansen@linux.intel.com"
	<dave.hansen@linux.intel.com>, "dyoung@redhat.com" <dyoung@redhat.com>,
	"feng.tang@intel.com" <feng.tang@intel.com>, "gregkh@linuxfoundation.org"
	<gregkh@linuxfoundation.org>, "hidehiro.kawai.ez@hitachi.com"
	<hidehiro.kawai.ez@hitachi.com>, "jgross@suse.com" <jgross@suse.com>,
	"john.ogness@linutronix.de" <john.ogness@linutronix.de>,
	"keescook@chromium.org" <keescook@chromium.org>, "luto@kernel.org"
	<luto@kernel.org>, "mhiramat@kernel.org" <mhiramat@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>, "paulmck@kernel.org"
	<paulmck@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>, "senozhatsky@chromium.org"
	<senozhatsky@chromium.org>, "stern@rowland.harvard.edu"
	<stern@rowland.harvard.edu>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>, vkuznets <vkuznets@redhat.com>,
	"will@kernel.org" <will@kernel.org>, Alexander Gordeev
	<agordeev@linux.ibm.com>, Andrea Parri <parri.andrea@gmail.com>, Ard
 Biesheuvel <ardb@kernel.org>, Benjamin Herrenschmidt
	<benh@kernel.crashing.org>, Brian Norris <computersforpeace@gmail.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>, Christophe JAILLET
	<christophe.jaillet@wanadoo.fr>, David Gow <davidgow@google.com>, "David S.
 Miller" <davem@davemloft.net>, Dexuan Cui <decui@microsoft.com>, Doug Berger
	<opendmb@gmail.com>, Evan Green <evgreen@chromium.org>, Florian Fainelli
	<f.fainelli@gmail.com>, Haiyang Zhang <haiyangz@microsoft.com>, Hari Bathini
	<hbathini@linux.ibm.com>, Heiko Carstens <hca@linux.ibm.com>, Julius Werner
	<jwerner@chromium.org>, Justin Chen <justinpopo6@gmail.com>, KY Srinivasan
	<kys@microsoft.com>, Lee Jones <lee.jones@linaro.org>, Markus Mayer
	<mmayer@broadcom.com>, Michael Ellerman <mpe@ellerman.id.au>, Mihai Carabas
	<mihai.carabas@oracle.com>, Nicholas Piggin <npiggin@gmail.com>, Paul
 Mackerras <paulus@samba.org>, Pavel Machek <pavel@ucw.cz>, Scott Branden
	<scott.branden@broadcom.com>, Sebastian Reichel <sre@kernel.org>, Shile Zhang
	<shile.zhang@linux.alibaba.com>, Stephen Hemminger <sthemmin@microsoft.com>,
	Sven Schnelle <svens@linux.ibm.com>, Thomas Bogendoerfer
	<tsbogend@alpha.franken.de>, Tianyu Lan <Tianyu.Lan@microsoft.com>, Vasily
 Gorbik <gor@linux.ibm.com>, Wang ShaoBo <bobo.shaobowang@huawei.com>, Wei Liu
	<wei.liu@kernel.org>, zhenwei pi <pizhenwei@bytedance.com>
Subject: RE: [PATCH 19/30] panic: Add the panic hypervisor notifier list
Thread-Topic: [PATCH 19/30] panic: Add the panic hypervisor notifier list
Thread-Index: AQHYWonjjKMtrubrvUiw63ryI2yC7q0HJOjg
Date: Fri, 29 Apr 2022 17:30:44 +0000
Message-ID:
 <PH0PR21MB30256260CCF4CAB713BBB11ED7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-20-gpiccoli@igalia.com>
In-Reply-To: <20220427224924.592546-20-gpiccoli@igalia.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=ffbe4afc-a779-4ef6-ac4b-fe8bbe7e97a6;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-04-29T17:17:23Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: eeb8e09c-7f93-4457-468d-08da2a05fdd8
x-ms-traffictypediagnostic: DM5PR21MB0761:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs:
 <DM5PR21MB076153F3B23BA9EDA94AA480D7FC9@DM5PR21MB0761.namprd21.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 ODUHNdNoyMm3+AjwwTGZa1uU+b7TzZfWBoAD8U4KhH1PO+xsXH02vwPBpyB/mIWIIZLzexbTDM4Vu/gZXstTguCwFin3jx/rAWvym7fQtAAg7bf3LoRbUADVs29tsGDy7+TAF7XXuJ2XtQpxtKth+FDvvHqKkOMz6t9UN3qxlX6X2/8DIw+GSljUyUj0tBw+/yPNu/lWy8bf/Am8dAdq1sDNbEC96RfsPekPyfP+ABzhwQ7PYKa/WylVKbqc6qF9DBAiGkEhIue/W/buwkdT7hYfHatG+zYOokfeiF3mlfl6KUzf5D5VNniM5lrQaX04V1qe1DNhDfiM2zUJp+UaaATU3lWntWn8XhQuwQ43saBb+whCvgo88zwSOnEtmfyXyJ7jSHr1E4zfj918Eh9wqTjnj+ly+wc+lrYnrbxMrLnOqL7bIfdILybyElXp12gbfm2vduDRh4SqY47pT+etRXV897ZE09O7/kJq3qYvGYtzXFoW19u/PKLiR28Z4TH/0eiE3v99EQFM/nm9qKWOIJz0AQ2aN9R7RyGMJ2el+s3C9YrtAh+XKMmCa/DuIpJihY98t7SoGzymQzR/oWmks7/DWMg11/eTBUSMF7oGyj/sryAvEYyImB8qi3eqsEWUoi0UGVpgJYUtiNLHN8PgE27Kl/BKSUCkJOXB2SWOuZP/2y/mimDRuhjjLgpCS8XKOFW4CADcxyTlrPyV6BZvcWd8nLypxsa6tVzXjuIb6HQVUSBs7DXSfR7irbmoVbPr
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(26005)(508600001)(8936002)(9686003)(86362001)(5660300002)(122000001)(66556008)(76116006)(66946007)(4326008)(64756008)(8676002)(66476007)(66446008)(52536014)(55016003)(7696005)(2906002)(83380400001)(33656002)(8990500004)(7366002)(6506007)(71200400001)(186003)(7336002)(7416002)(7406005)(110136005)(38100700002)(38070700005)(54906003)(82960400001)(82950400001)(316002)(10290500003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?TlM1hb7C2zMfewQaGJedC++RJRP9D1fk9jo5g85b/VbEJjlvhufD/+3GvsdT?=
 =?us-ascii?Q?2RVoig3NgPv+9kMAhzt2yayxBFL+XC6TKbfh6r5z8+a3Ialq4pqnl+61min4?=
 =?us-ascii?Q?AQUbYZF6RM2WxWAWaWbmf4pZvHkqxCNxh2tBKbbAZG7zTWlGRE0yrn46CpjQ?=
 =?us-ascii?Q?Kg+FF3RMjkh0xhKb7YhWVGFRR4cUFfDwAE8Y0u/ayL9EvN7YfHgvbTwnFibg?=
 =?us-ascii?Q?wxrs8ZKT9gyje95TfWsysjrlEo2AMhjijQYf+wk++uxUxKjFMFcFM0TK/o0U?=
 =?us-ascii?Q?SkFo0xaTlF5faRiiVtJr3loo9S/Ku6rNW972dcU4pAdU566LuvrnO7MFZjdh?=
 =?us-ascii?Q?AFmbPsT2BzLJiaocFxkmdlQu7LQAu7OqTCRt6l+PZ9/gSfZuPhUus2hHDtrB?=
 =?us-ascii?Q?SDM9omiIG+Hxx9v9sHNTsQnym8IgjtRHARJqPiuuOrhzGW6rnMAOXglrCflV?=
 =?us-ascii?Q?Rov5f0XftngP4p/15HVk/xZ3U6CF21Y8wkL46j9LuXmnR1XoUchKnTl+E2LX?=
 =?us-ascii?Q?HVGrWe5ghuEiAOI2CIdLYYiZOLMOSKHkPVS5tEsF0puhwsUw4JMbLD+YZac+?=
 =?us-ascii?Q?XngxLj2g0ToSfUytDuBtW/xckOvI92+dCx8pO+ZAYP+e0eVn9cwp1Kvm1xNb?=
 =?us-ascii?Q?rAV5CaVoCci7b8QWoR2QN+Fu5dk7/CqjmTz1tOeFdsuqD6uz1SRGrS1d03HL?=
 =?us-ascii?Q?xDH9ipJZ+o8EfvcxNjL+NjflstJUNBTDD179PIJ02lIR/lqudf7+UQyDID84?=
 =?us-ascii?Q?q6tjz0iN9UUKGwVqgivgZXrsYwAytqrnKmINVNW4wb3XLk5w9neXRmUH+j78?=
 =?us-ascii?Q?KsamX4Pm+/ES4p923iT/O1j8Dc0iz2HIDjQusOUqKqy+1Cmv74o7qNPXqarR?=
 =?us-ascii?Q?SV+zg4wh7LaN+6mQPM9GRAC/fCDGlfCRDE0pObSvJCER5gHColet4D4oXi/M?=
 =?us-ascii?Q?whLKv3In3ycb8NG9SfzBHT6UBBuTXzlk8Z1cOw5HxwbJpQLcoJRyOznkhaFh?=
 =?us-ascii?Q?puB+TPg2v7gG43STuXsZuBPdxeBcD8t22uNy09Tm5VdFwD19dW7BANqzNvjE?=
 =?us-ascii?Q?6ltEeCK6kZsWlNtZnhZXzDkWfGec7QKD5T4837WQofWzk4AFyNmw3P07gbzW?=
 =?us-ascii?Q?DPRwU0bZQmEfow5pS46fZjnBJLIMizPbjOrxqQF88Hjdw7YkIlxIIPy9nOq5?=
 =?us-ascii?Q?rkOk+PDUI9sQbFgNvnFlRVqa5M9e8Cy3bVoX1i0e+J8fFasucl92zOySG7x1?=
 =?us-ascii?Q?dB0URJnSLwBlrJmIq2kHvmFM17BCiSIY6KmZnlsYBBc1zFLorv7VM7LxtvfK?=
 =?us-ascii?Q?eWEn4xu8Zu2XCbhm1RGjyA5mb3yJm+3MMLIWqa+D7mjqfMW4n/WDwOBGp4aX?=
 =?us-ascii?Q?7QIVcVDS2FQO8HGQtL0ZKsEXbyBGRrNCLrnSGQeM3c6sITs7FuMznsa3uTQ1?=
 =?us-ascii?Q?RzaG53kxTddhkwnYFMCH33OZDDS2VRKVGp0nCTknijgA/sd/pqAgBqx5FXNZ?=
 =?us-ascii?Q?LATiyW6hMVS3IQCBsELFD/kPKZZBR2r77QSiuWPyw2p8Pov/AXvouaHqr3Ks?=
 =?us-ascii?Q?aS3oN5XL5IHgKsiBu9N05s7MHrTT+fYH1fgDf196dY2Y2fYMpnG/9O22tFVZ?=
 =?us-ascii?Q?lsqy47lRHWMZ83W8zC+zPLhsXx6hfG0s/4A7rNIm78PqkrB2VME1eEucYCy8?=
 =?us-ascii?Q?YLC3m+W9TrKfxD8jKOYF9JNku02hxJAdCmjBpA8ShRZwpe21dzNz+uH7NKFr?=
 =?us-ascii?Q?FMBdMIBAEVrPX2S6uKBKGZRc/W3b2C8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eeb8e09c-7f93-4457-468d-08da2a05fdd8
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 17:30:44.8209
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w0NqD7w01G3MX0hLhA/dcwb32L6tMn458kJlZ8pEiHHtKKqoR4vHWxkneKizeI4TFabvPMLpsqtoLF7uJprzpME6TmOX5LZO5vkLMC+rFzs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0761

From: Guilherme G. Piccoli <gpiccoli@igalia.com> Sent: Wednesday, April 27,=
 2022 3:49 PM
>=20
> The goal of this new panic notifier is to allow its users to register
> callbacks to run very early in the panic path. This aims hypervisor/FW
> notification mechanisms as well as simple LED functions, and any other
> simple and safe mechanism that should run early in the panic path; more
> dangerous callbacks should execute later.
>=20
> For now, the patch is almost a no-op (although it changes a bit the
> ordering in which some panic notifiers are executed). In a subsequent
> patch, the panic path will be refactored, then the panic hypervisor
> notifiers will effectively run very early in the panic path.
>=20
> We also defer documenting it all properly in the subsequent refactor
> patch. While at it, we removed some useless header inclusions and
> fixed some notifiers return too (by using the standard NOTIFY_DONE).
>=20
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Cc: David Gow <davidgow@google.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: Doug Berger <opendmb@gmail.com>
> Cc: Evan Green <evgreen@chromium.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Hari Bathini <hbathini@linux.ibm.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Julius Werner <jwerner@chromium.org>
> Cc: Justin Chen <justinpopo6@gmail.com>
> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Markus Mayer <mmayer@broadcom.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Michael Kelley <mikelley@microsoft.com>
> Cc: Mihai Carabas <mihai.carabas@oracle.com>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Scott Branden <scott.branden@broadcom.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Shile Zhang <shile.zhang@linux.alibaba.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Wang ShaoBo <bobo.shaobowang@huawei.com>
> Cc: Wei Liu <wei.liu@kernel.org>
> Cc: zhenwei pi <pizhenwei@bytedance.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>  arch/mips/sgi-ip22/ip22-reset.c          | 2 +-
>  arch/mips/sgi-ip32/ip32-reset.c          | 3 +--
>  arch/powerpc/kernel/setup-common.c       | 2 +-
>  arch/sparc/kernel/sstate.c               | 3 +--
>  drivers/firmware/google/gsmi.c           | 4 ++--
>  drivers/hv/vmbus_drv.c                   | 4 ++--
>  drivers/leds/trigger/ledtrig-activity.c  | 4 ++--
>  drivers/leds/trigger/ledtrig-heartbeat.c | 4 ++--
>  drivers/misc/bcm-vk/bcm_vk_dev.c         | 6 +++---
>  drivers/misc/pvpanic/pvpanic.c           | 4 ++--
>  drivers/power/reset/ltc2952-poweroff.c   | 4 ++--
>  drivers/s390/char/zcore.c                | 5 +++--
>  drivers/soc/bcm/brcmstb/pm/pm-arm.c      | 2 +-
>  include/linux/panic_notifier.h           | 1 +
>  kernel/panic.c                           | 4 ++++
>  15 files changed, 28 insertions(+), 24 deletions(-)

[ snip]

>=20
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index f37f12d48001..901b97034308 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1614,7 +1614,7 @@ static int vmbus_bus_init(void)
>  			hv_kmsg_dump_register();
>=20
>  		register_die_notifier(&hyperv_die_report_block);
> -		atomic_notifier_chain_register(&panic_notifier_list,
> +		atomic_notifier_chain_register(&panic_hypervisor_list,
>  						&hyperv_panic_report_block);
>  	}
>=20
> @@ -2843,7 +2843,7 @@ static void __exit vmbus_exit(void)
>  	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) {
>  		kmsg_dump_unregister(&hv_kmsg_dumper);
>  		unregister_die_notifier(&hyperv_die_report_block);
> -		atomic_notifier_chain_unregister(&panic_notifier_list,
> +		atomic_notifier_chain_unregister(&panic_hypervisor_list,
>  						&hyperv_panic_report_block);
>  	}
>=20

Using the hypervisor_list here produces a bit of a mismatch.  In many cases
this notifier will do nothing, and will defer to the kmsg_dump() mechanism
to notify the hypervisor about the panic.   Running the kmsg_dump()
mechanism is linked to the info_list, so I'm thinking the Hyper-V panic rep=
ort
notifier should be on the info_list as well.  That way the reporting behavi=
or
is triggered at the same point in the panic path regardless of which
reporting mechanism is used.





From xen-devel-bounces@lists.xenproject.org Fri Apr 29 17:45:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 17:45:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317589.536985 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUft-0006T9-Jl; Fri, 29 Apr 2022 17:45:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317589.536985; Fri, 29 Apr 2022 17:45:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUft-0006T2-Gg; Fri, 29 Apr 2022 17:45:01 +0000
Received: by outflank-mailman (input) for mailman id 317589;
 Fri, 29 Apr 2022 17:44:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkUfr-0006Ss-U0; Fri, 29 Apr 2022 17:44:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkUfr-0005Wd-RY; Fri, 29 Apr 2022 17:44:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkUfr-0003lK-EQ; Fri, 29 Apr 2022 17:44:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkUfr-0003j1-Dy; Fri, 29 Apr 2022 17:44:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TO1wq6yJyFG0YRoilbpSiCKomBgyEAGkV6RT88tlVmA=; b=grbLnpyJ3cWrVBqOH1WEDZxZzZ
	0/0ckfSBXI6YJ2quFjarttXaS41U1dDlUzaJ+Z90frYGRLKtVQsdHEMqqhGyMgAfqNoZWgBjc0/qV
	Jmmwo4Ww4p/vzFwqmH71X3Ph7RmeCgQOM1JI/Jl/EEMigW1Q4BsejKNGcpAppu+1/s9Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169874-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169874: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 17:44:59 +0000

flight 169874 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169874/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  698 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 17:54:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 17:54:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317597.536996 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUos-0007x3-FM; Fri, 29 Apr 2022 17:54:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317597.536996; Fri, 29 Apr 2022 17:54:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUos-0007ww-CC; Fri, 29 Apr 2022 17:54:18 +0000
Received: by outflank-mailman (input) for mailman id 317597;
 Fri, 29 Apr 2022 17:54:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E21X=VH=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1nkUoq-0007wq-QZ
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 17:54:17 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-eus2azlp170110002.outbound.protection.outlook.com
 [2a01:111:f403:c110::2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 60a9e734-c7e5-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 19:54:13 +0200 (CEST)
Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21)
 by DM5PR21MB0283.namprd21.prod.outlook.com (2603:10b6:3:a7::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.6; Fri, 29 Apr
 2022 17:53:59 +0000
Received: from PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df]) by PH0PR21MB3025.namprd21.prod.outlook.com
 ([fe80::dd77:2d4d:329e:87df%6]) with mapi id 15.20.5227.006; Fri, 29 Apr 2022
 17:53:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60a9e734-c7e5-11ec-8fc4-03012f2f19d4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XH0C4rSCtp0BuJGNStAnN/El02rVrUFI6jbfyR3tyhwMLIEjU7MfYXWONJj7ZT//BfeKz+ELIB87gYgzRP4lYCQzTneN4mU5YYZguQyjvkhmmZm/mKANBJX3p0AhI1AGsSpaM3YtnqEY7PC5fCb3P7ZY5Yx4YnDvMNHdgffsVX0JhWa/OP0nGesQn1YDQNGe+LUhlQuGTU+iZ4s8v6O5KpAc8e05GOYD2J6cokTT1sRkeCdRyBhylX5wKOk0qShCQRlqz1EF8b2QYVS6BA/0+9IgPJehvOKYSQozr0fS1m/3DYcJX6uHpd+i7A7/18BdsChlbF0tjKk/DuwWyOQa6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4kHDNPF7kz3dFxPBmLKlbWmKcOhs7PG72U55Ici1hAw=;
 b=K/4ChrkKE/FW/CyWMds6SviFVCOKaODFOE23Rk6bWe1u2wBTTRJFHvFQ083IDUXuVYs3OuMNPvWSKzZjKW5z7uO+SN5iX4hqwHiUSbPk/5DdR97qK4G+yoK+Lq/DsbDrR/g88DvjDnLESZfiOloNrjFa2Fpc7jkdV3DdcxrfMqQUy/mwSiLPTyTSgrJ9UrU7w/Lr0xLpOZOwX/0cQrvshGoBPpJEcjBlDwKwLEb6wB7WOVveo27O6hosOvOT+Z3Y1FtL2dBOj8hDt5+81KH0rV0T3rYivkInWA2YPmfaakOqpr7QOBpp9XQmMt84nW9KM9lKXpnJmX3hBW1JE9yf+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4kHDNPF7kz3dFxPBmLKlbWmKcOhs7PG72U55Ici1hAw=;
 b=RemXXQlQOagzgtJmguOxYn8DaupNwaBBazr9olOff8TLE1yMB6GJylHgSdETuXZaZy7u3lmSSY1a7hHaG8IPdfizIT1vuMXmhxP5jsmjxiX08VL7icMuA0LTLtTqmC7ZdGyDIbPCxx7Rj6Qr8wokI8sYlbUWVlPmGB1+wwHDt3A=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>, "bhe@redhat.com" <bhe@redhat.com>,
	"pmladek@suse.com" <pmladek@suse.com>, "kexec@lists.infradead.org"
	<kexec@lists.infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>, "coresight@lists.linaro.org"
	<coresight@lists.linaro.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "linux-alpha@vger.kernel.org"
	<linux-alpha@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-leds@vger.kernel.org"
	<linux-leds@vger.kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linux-parisc@vger.kernel.org"
	<linux-parisc@vger.kernel.org>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-um@lists.infradead.org"
	<linux-um@lists.infradead.org>, "linux-xtensa@linux-xtensa.org"
	<linux-xtensa@linux-xtensa.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "openipmi-developer@lists.sourceforge.net"
	<openipmi-developer@lists.sourceforge.net>, "rcu@vger.kernel.org"
	<rcu@vger.kernel.org>, "sparclinux@vger.kernel.org"
	<sparclinux@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "x86@kernel.org" <x86@kernel.org>,
	"kernel-dev@igalia.com" <kernel-dev@igalia.com>, "kernel@gpiccoli.net"
	<kernel@gpiccoli.net>, "halves@canonical.com" <halves@canonical.com>,
	"fabiomirmar@gmail.com" <fabiomirmar@gmail.com>,
	"alejandro.j.jimenez@oracle.com" <alejandro.j.jimenez@oracle.com>,
	"andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
	"arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
	"corbet@lwn.net" <corbet@lwn.net>, "d.hatayama@jp.fujitsu.com"
	<d.hatayama@jp.fujitsu.com>, "dave.hansen@linux.intel.com"
	<dave.hansen@linux.intel.com>, "dyoung@redhat.com" <dyoung@redhat.com>,
	"feng.tang@intel.com" <feng.tang@intel.com>, "gregkh@linuxfoundation.org"
	<gregkh@linuxfoundation.org>, "hidehiro.kawai.ez@hitachi.com"
	<hidehiro.kawai.ez@hitachi.com>, "jgross@suse.com" <jgross@suse.com>,
	"john.ogness@linutronix.de" <john.ogness@linutronix.de>,
	"keescook@chromium.org" <keescook@chromium.org>, "luto@kernel.org"
	<luto@kernel.org>, "mhiramat@kernel.org" <mhiramat@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>, "paulmck@kernel.org"
	<paulmck@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>, "senozhatsky@chromium.org"
	<senozhatsky@chromium.org>, "stern@rowland.harvard.edu"
	<stern@rowland.harvard.edu>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>, vkuznets <vkuznets@redhat.com>,
	"will@kernel.org" <will@kernel.org>
Subject: RE: [PATCH 24/30] panic: Refactor the panic path
Thread-Topic: [PATCH 24/30] panic: Refactor the panic path
Thread-Index: AQHYWooewzaZJbWMbkqYc1HZNUkdQa0HKRAQ
Date: Fri, 29 Apr 2022 17:53:58 +0000
Message-ID:
 <PH0PR21MB30252C55EB4F97F3D78021BDD7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-25-gpiccoli@igalia.com>
In-Reply-To: <20220427224924.592546-25-gpiccoli@igalia.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=09c09848-5fcd-42f8-8ae4-c341f8d127ce;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-04-29T17:32:16Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ce4dd8e9-4a0f-4c33-34fc-08da2a093ccf
x-ms-traffictypediagnostic: DM5PR21MB0283:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs:
 <DM5PR21MB0283A12953F48381A81673E4D7FC9@DM5PR21MB0283.namprd21.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 +DwXnfIUrmRLwxKXD3QaYPbQQB/sEqUo0mYsUpixiPkVdiPKMv8mUXLw209PItldFbOppmxVv5WRDbCuhFDzG6fyzPIKc4SBxihNwJdO364D+u7z6u8R79sfF/7/QxUdtPe+wsdcPyywPmSFiWhT03hMR6hhVHph6eiVSwWY/OJCS0aUvL6iDOf05UoEhqTBLKi7y+uwSWqD2ZakSWibLiyHVu2YLzBcuRHU+gpEWal+pBmhOPE034Dxpahp6mQQflcq2E3UIBuVWkxXGQS0wKPrpjP7YVfgjhX25umBzJCbVgJvo7incaRJOtk6ciKDrk2ohex4BGHzvc6pTI7mVb5t7ReGCTxHtmDTR6vrQA77jCy5a8rPOfipUatEUXmicS+dr+b5XSniGRaH+YHhncrj//ho3BLkSwZuc0FcygKxrvQx7P/2aXV/JamLFFxTer1iwapXNU+wjVrfQpDYvBEaHqJEm/sx9EGUEcUqJH5o3z56eRfzd0fdPS80FTGqafZSHdd2xW/yUrsBXGvGM74zmkheRC2WZ/7C19ZGRH3IQz7CCOt9inrv7RH3A73Kf341xhl1aiPLxdzDO6knMustq/QZnu7LvkbYkD7BupkwyzpXpE3sBEn6DhNfXJaMlqo7J9BA49wDBBaPGO6wpGUDORU6YozF7sJ5dSOnUYxR6U/i51AEdMZ4/Mm57O/PpLBRzhOMPhGtHN2t2Z6KBNYwK/Zub+t0aKn59fbSGpRyKEK93HhO94zWvdug5rHpI6Br4Hxdgtc+Mbi4H3mTbSR8cEpsWXbTS1y5jLzdDZcBn7vmyO6LGBdVrIV6PPgEL3X8nSBgbvfg5o7BlcF3SA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(122000001)(66446008)(82950400001)(82960400001)(38070700005)(7696005)(38100700002)(2906002)(316002)(10290500003)(71200400001)(110136005)(54906003)(83380400001)(966005)(33656002)(508600001)(52536014)(76116006)(8990500004)(86362001)(64756008)(6506007)(4326008)(8676002)(30864003)(8936002)(55016003)(186003)(66476007)(66556008)(9686003)(66946007)(7406005)(7416002)(7366002)(26005)(5660300002)(579004)(559001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?qLQwJIizb4GTKmjZvKz5RdF0ggwlESmOIZby2Ta8yQPiVgEKzjuIAibqgZBw?=
 =?us-ascii?Q?bFytXytvBoGPEAqd7aoKw4+rhcgkh7BG0AYn++z5pAeZpkAMoSJ4saKpNzOS?=
 =?us-ascii?Q?UiEsjWohRaFelB98fR8K79sNHRtlVRv3P8+jY4Gdv9JbPZDPhkIPsxZIoDq1?=
 =?us-ascii?Q?yCM9ok6Xw/gBRJRkwCfroYUmaWfjfrZVUY0b47OPZQe65LTXQ0zmRZqEQImu?=
 =?us-ascii?Q?bXxxseVUhUBHI3YuGG8hItPrNiRY0U724T9CBmfxNcquKo8GhGq12xdwaHY3?=
 =?us-ascii?Q?6zaY672eqTwBfAB5uLbcMZ0RyY1G/GJIIkkIAneYqejgZkllUqFoCaggvgu8?=
 =?us-ascii?Q?M9NxxGTSSlnrBGByQbj2ByUuiSuyaWJZDu9Xde/4XrfyL3jF801Gh4FGWOYg?=
 =?us-ascii?Q?iklocYNnyxxCHAlkgROuFAUdC+UWenUMULNnGhpZjlzVVI0L7UfXW7mBzLh1?=
 =?us-ascii?Q?qAY4SnV+OwbU9gMHFQmdZtHyf/TCVmFdBIgqRNobmZXHIjLoT+hE04ZClQ5J?=
 =?us-ascii?Q?K59XbeD6pU6X3W6TcbWJSBceixAWxYToEkSSxOmdxliMg0qfFUxn8wE6Tkzs?=
 =?us-ascii?Q?olYaFazylCqWio+w0S1Rs+FvUiSsfpk3/DOG+w6GPun+vISxNaO5kLWkbLVZ?=
 =?us-ascii?Q?+jOVhtSL1lko7D6iyyArNkIwWQ4hhRPSBwvwG9IgSeACoBHsJtJlj52DHfGb?=
 =?us-ascii?Q?iBlLVI2yy36kuO2RIBUnCy3zjQUZYTOyOScaeEgH7HR34doxL/jbQxmrJlB3?=
 =?us-ascii?Q?/PGUeYA3UV3FRBboAksOmyNLTH0s6Yu9iaNr/qDF3gQzj6GMkLWE5r6TyiYC?=
 =?us-ascii?Q?GrLmPaDmKOJChFbEpDeHrCZFVEeOtbL2tUIVr0S+YYMLGiIJvT32UyUtUWIH?=
 =?us-ascii?Q?+1wKDt66BtZa/jau4WnSXgnEroVa0CfeLgY1JHl/V+ZclEgCx1WcgvIrfQ+n?=
 =?us-ascii?Q?gnDau1xijQu2ZomgCgtj14nUHsMEar9/zPyce+BmZPcSQHVC5X25T4xjgbfx?=
 =?us-ascii?Q?iQHBgUUURtpHYKKuX7Gw+6yjlUYJVasVhMSB3JldJQiolo1inH65eTdlao0B?=
 =?us-ascii?Q?pL5TGUuxZ/O7NRU9iPaip10KX3H8EhhiVr6qujixnh7Pig5Ehyb4Hyma64ft?=
 =?us-ascii?Q?XY4vP09x1rZqPfbrHaZNgHkQKKm/iBPgQF5mOjnw2EdMvUH6S3m1sdsBDM2F?=
 =?us-ascii?Q?Cxfr5cgyMBcMdcjY4PCOcQsRnkLk84cGQ063vAnNytCxlzdgCyjW+66+83Ao?=
 =?us-ascii?Q?LG7Qv0TJ94AU6+qI3KO9Wt5TUrsmtcBf9o9YUXfnd4JKMiEKG7l+Am2hJVny?=
 =?us-ascii?Q?iQDZ6w7N0I87fu/JiCBEDkKJLEhIX6HNnbb0w0M8UUl75fk8Uw5dG/zi8o1o?=
 =?us-ascii?Q?kvGnlrIP4V9QCiQGbjQbXSFfHqiBh1AwiQxOPWCuZ3f1LAMTIjKNZUoB5+2X?=
 =?us-ascii?Q?A71MaP4oO1GIAYq63ENvzSR34B1n3fjMbRvvvx2G02yed/15r+ry/JfcqGgp?=
 =?us-ascii?Q?fO5nB/sYFhdMP9ONOwXKyTwWXKvWXbA977A7c7pROzJ5ENqkBzcn9xzX3iHK?=
 =?us-ascii?Q?/upU7TKsaBFZT0cBIPp7uW5pbrdKT1PoDevWoQb7hkqL3qIdsR9md3vPZd73?=
 =?us-ascii?Q?LyUZt8Gwsb71Y5S0ho0GbvO5CcuARAhsJmSvWgD5RHs3RbbjtTEFtY7uFzvb?=
 =?us-ascii?Q?PJ57Ie7V6iBiphUQKh8Ac89taMSlu5pD2FvlXP95RudY9md7K5JMfFvekoLV?=
 =?us-ascii?Q?muIkJGKc7ONZ1Xk3cn7DmP+JekNNc8w=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce4dd8e9-4a0f-4c33-34fc-08da2a093ccf
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 17:53:58.9431
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CvvuzEye8juVuC2zQbbNasVNJZRlmcQO+doaBmpgYwubJRr+j3OYcKrg8u5RvHxE9vwht230UO+aGdtf0HfXKeJwgp9Q67J1b+bAA7u/ITQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0283

From: Guilherme G. Piccoli <gpiccoli@igalia.com> Sent: Wednesday, April 27,=
 2022 3:49 PM
>=20
> The panic() function is somewhat convoluted - a lot of changes were
> made over the years, adding comments that might be misleading/outdated
> now, it has a code structure that is a bit complex to follow, with
> lots of conditionals, for example. The panic notifier list is something
> else - a single list, with multiple callbacks of different purposes,
> that run in a non-deterministic order and may affect hardly kdump
> reliability - see the "crash_kexec_post_notifiers" workaround-ish flag.
>=20
> This patch proposes a major refactor on the panic path based on Petr's
> idea [0] - basically we split the notifiers list in three, having a set
> of different call points in the panic path. Below a list of changes
> proposed in this patch, culminating in the panic notifiers level
> concept:
>=20
> (a) First of all, we improved comments all over the function
> and removed useless variables / includes. Also, as part of this
> clean-up we concentrate the console flushing functions in a helper.
>=20
> (b) As mentioned before, there is a split of the panic notifier list
> in three, based on the purpose of the callback. The code contains
> good documentation in form of comments, but a summary of the three
> lists follows:
>=20
> - the hypervisor list aims low-risk procedures to inform hypervisors
> or firmware about the panic event, also includes LED-related functions;
>=20
> - the informational list contains callbacks that provide more details,
> like kernel offset or trace dump (if enabled) and also includes the
> callbacks aimed at reducing log pollution or warns, like the RCU and
> hung task disable callbacks;
>=20
> - finally, the pre_reboot list is the old notifier list renamed,
> containing the more risky callbacks that didn't fit the previous
> lists. There is also a 4th list (the post_reboot one), but it's not
> related with the original list - it contains late time architecture
> callbacks aimed at stopping the machine, for example.
>=20
> The 3 notifiers lists execute in different moments, hypervisor being
> the first, followed by informational and finally the pre_reboot list.
>=20
> (c) But then, there is the ordering problem of the notifiers against
> the crash_kernel() call - kdump must be as reliable as possible.
> For that, a simple binary "switch" as "crash_kexec_post_notifiers"
> is not enough, hence we introduce here concept of panic notifier
> levels: there are 5 levels, from 0 (no notifier executes before
> kdump) until 4 (all notifiers run before kdump); the default level
> is 2, in which the hypervisor and (iff we have any kmsg dumper)
> the informational notifiers execute before kdump.
>=20
> The detailed documentation of the levels is present in code comments
> and in the kernel-parameters.txt file; as an analogy with the previous
> panic() implementation, the level 0 is exactly the same as the old
> behavior of notifiers, running all after kdump, and the level 4 is
> the same as "crash_kexec_post_notifiers=3DY" (we kept this parameter as
> a deprecated one).
>=20
> (d) Finally, an important change made here: we now use only the
> function "crash_smp_send_stop()" to shut all the secondary CPUs
> in the panic path. Before, there was a case of using the regular
> "smp_send_stop()", but the better approach is to simplify the
> code and try to use the function which was created exclusively
> for the panic path. Experiments showed that it works fine, and
> code was very simplified with that.
>=20
> Functional change is expected from this refactor, since now we
> call some notifiers by default before kdump, but the goal here
> besides code clean-up is to have a better panic path, more
> reliable and deterministic, but also very customizable.
>=20
> [0] https://lore.kernel.org/lkml/YfPxvzSzDLjO5ldp@alley/
>=20
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>=20
> Special thanks to Petr and Baoquan for the suggestion and feedback in a p=
revious
> email thread. There's some important design decisions that worth mentioni=
ng and
> discussing:
>=20
> * The default panic notifiers level is 2, based on Petr Mladek's suggesti=
on,
> which makes a lot of sense. Of course, this is customizable through the
> parameter, but would be something worthwhile to have a KConfig option to =
set
> the default level? It would help distros that want the old behavior
> (no notifiers before kdump) as default.
>=20
> * The implementation choice was to _avoid_ intricate if conditionals in t=
he
> panic path, which would _definitely_ be present with the panic notifiers =
levels
> idea; so, instead of lots of if conditionals, the set/clear bits approach=
 with
> functions called in 2 points (but executing only in one of them) is much =
easier
> to follow an was used here; the ordering helper function and the comments=
 also
> help a lot to avoid confusion (hopefully).
>=20
> * Choice was to *always* use crash_smp_send_stop() instead of sometimes m=
aking
> use of the regular smp_send_stop(); for most architectures they are the s=
ame,
> including Xen (on x86). For the ones that override it, all should work fi=
ne,
> in the powerpc case it's even more correct (see the subsequent patch
> "powerpc: Do not force all panic notifiers to execute before kdump")
>=20
> There seems to be 2 cases that requires some plumbing to work 100% right:
> - ARM doesn't disable local interrupts / FIQs in the crash version of
> send_stop(); we patched that early in this series;
> - x86 could face an issue if we have VMX and do use crash_smp_send_stop()
> _without_ kdump, but this is fixed in the first patch of the series (and
> it's a bug present even before this refactor).
>=20
> * Notice we didn't add a sysrq for panic notifiers level - should have it=
?
> Alejandro proposed recently to add a sysrq for "crash_kexec_post_notifier=
s",
> let me know if you feel the need here Alejandro, since the core parameter=
s are
> present in /sys, I didn't consider much gain in having a sysrq, but of co=
urse
> I'm open to suggestions!
>=20
> Thanks advance for the review!
>=20
>  .../admin-guide/kernel-parameters.txt         |  42 ++-
>  include/linux/panic_notifier.h                |   1 +
>  kernel/kexec_core.c                           |   8 +-
>  kernel/panic.c                                | 292 +++++++++++++-----
>  .../selftests/pstore/pstore_crash_test        |   5 +-
>  5 files changed, 252 insertions(+), 96 deletions(-)
>=20
> diff --git a/Documentation/admin-guide/kernel-parameters.txt
> b/Documentation/admin-guide/kernel-parameters.txt
> index 3f1cc5e317ed..8d3524060ce3 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -829,6 +829,13 @@
>  			It will be ignored when crashkernel=3DX,high is not used
>  			or memory reserved is below 4G.
>=20
> +	crash_kexec_post_notifiers
> +			This was DEPRECATED - users should always prefer the
> +			parameter "panic_notifiers_level" - check its entry
> +			in this documentation for details on how it works.
> +			Setting this parameter is exactly the same as setting
> +			"panic_notifiers_level=3D4".
> +
>  	cryptomgr.notests
>  			[KNL] Disable crypto self-tests
>=20
> @@ -3784,6 +3791,33 @@
>  			timeout < 0: reboot immediately
>  			Format: <timeout>
>=20
> +	panic_notifiers_level=3D
> +			[KNL] Set the panic notifiers execution order.
> +			Format: <unsigned int>
> +			We currently have 4 lists of panic notifiers; based
> +			on the functionality and risk (for panic success) the
> +			callbacks are added in a given list. The lists are:
> +			- hypervisor/FW notification list (low risk);
> +			- informational list (low/medium risk);
> +			- pre_reboot list (higher risk);
> +			- post_reboot list (only run late in panic and after
> +			kdump, not configurable for now).
> +			This parameter defines the ordering of the first 3
> +			lists with regards to kdump; the levels determine
> +			which set of notifiers execute before kdump. The
> +			accepted levels are:
> +			0: kdump is the first thing to run, NO list is
> +			executed before kdump.
> +			1: only the hypervisor list is executed before kdump.
> +			2 (default level): the hypervisor list and (*if*
> +			there's any kmsg_dumper defined) the informational
> +			list are executed before kdump.
> +			3: both the hypervisor and the informational lists
> +			(always) execute before kdump.

I'm not clear on why level 2 exists.  What is the scenario where
execution of the info list before kdump should be conditional on the
existence of a kmsg_dumper?   Maybe the scenario is described
somewhere in the patch set and I just missed it.

> +			4: the 3 lists (hypervisor, info and pre_reboot)
> +			execute before kdump - this behavior is analog to the
> +			deprecated parameter "crash_kexec_post_notifiers".
> +
>  	panic_print=3D	Bitmask for printing system info when panic happens.
>  			User can chose combination of the following bits:
>  			bit 0: print all tasks info
> @@ -3814,14 +3848,6 @@
>  	panic_on_warn	panic() instead of WARN().  Useful to cause kdump
>  			on a WARN().
>=20
> -	crash_kexec_post_notifiers
> -			Run kdump after running panic-notifiers and dumping
> -			kmsg. This only for the users who doubt kdump always
> -			succeeds in any situation.
> -			Note that this also increases risks of kdump failure,
> -			because some panic notifiers can make the crashed
> -			kernel more unstable.
> -
>  	parkbd.port=3D	[HW] Parallel port number the keyboard adapter is
>  			connected to, default is 0.
>  			Format: <parport#>
> diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifie=
r.h
> index bcf6a5ea9d7f..b5041132321d 100644
> --- a/include/linux/panic_notifier.h
> +++ b/include/linux/panic_notifier.h
> @@ -10,6 +10,7 @@ extern struct atomic_notifier_head panic_info_list;
>  extern struct atomic_notifier_head panic_pre_reboot_list;
>  extern struct atomic_notifier_head panic_post_reboot_list;
>=20
> +bool panic_notifiers_before_kdump(void);
>  extern bool crash_kexec_post_notifiers;
>=20
>  enum panic_notifier_val {
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 68480f731192..f8906db8ca72 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -74,11 +74,11 @@ struct resource crashk_low_res =3D {
>  int kexec_should_crash(struct task_struct *p)
>  {
>  	/*
> -	 * If crash_kexec_post_notifiers is enabled, don't run
> -	 * crash_kexec() here yet, which must be run after panic
> -	 * notifiers in panic().
> +	 * In case any panic notifiers are set to execute before kexec,
> +	 * don't run crash_kexec() here yet, which must run after these
> +	 * panic notifiers are executed, in the panic() path.
>  	 */
> -	if (crash_kexec_post_notifiers)
> +	if (panic_notifiers_before_kdump())
>  		return 0;
>  	/*
>  	 * There are 4 panic() calls in make_task_dead() path, each of which
> diff --git a/kernel/panic.c b/kernel/panic.c
> index bf792102b43e..b7c055d4f87f 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -15,7 +15,6 @@
>  #include <linux/kgdb.h>
>  #include <linux/kmsg_dump.h>
>  #include <linux/kallsyms.h>
> -#include <linux/notifier.h>
>  #include <linux/vt_kern.h>
>  #include <linux/module.h>
>  #include <linux/random.h>
> @@ -52,14 +51,23 @@ static unsigned long tainted_mask =3D
>  static int pause_on_oops;
>  static int pause_on_oops_flag;
>  static DEFINE_SPINLOCK(pause_on_oops_lock);
> -bool crash_kexec_post_notifiers;
> +
>  int panic_on_warn __read_mostly;
> +bool panic_on_taint_nousertaint;
>  unsigned long panic_on_taint;
> -bool panic_on_taint_nousertaint =3D false;
>=20
>  int panic_timeout =3D CONFIG_PANIC_TIMEOUT;
>  EXPORT_SYMBOL_GPL(panic_timeout);
>=20
> +/* Initialized with all notifiers set to run before kdump */
> +static unsigned long panic_notifiers_bits =3D 15;
> +
> +/* Default level is 2, see kernel-parameters.txt */
> +unsigned int panic_notifiers_level =3D 2;
> +
> +/* DEPRECATED in favor of panic_notifiers_level */
> +bool crash_kexec_post_notifiers;
> +
>  #define PANIC_PRINT_TASK_INFO		0x00000001
>  #define PANIC_PRINT_MEM_INFO		0x00000002
>  #define PANIC_PRINT_TIMER_INFO		0x00000004
> @@ -109,10 +117,14 @@ void __weak nmi_panic_self_stop(struct pt_regs *reg=
s)
>  }
>=20
>  /*
> - * Stop other CPUs in panic.  Architecture dependent code may override t=
his
> - * with more suitable version.  For example, if the architecture support=
s
> - * crash dump, it should save registers of each stopped CPU and disable
> - * per-CPU features such as virtualization extensions.
> + * Stop other CPUs in panic context.
> + *
> + * Architecture dependent code may override this with more suitable vers=
ion.
> + * For example, if the architecture supports crash dump, it should save =
the
> + * registers of each stopped CPU and disable per-CPU features such as
> + * virtualization extensions. When not overridden in arch code (and for
> + * x86/xen), this is exactly the same as execute smp_send_stop(), but
> + * guarded against duplicate execution.
>   */
>  void __weak crash_smp_send_stop(void)
>  {
> @@ -183,6 +195,112 @@ static void panic_print_sys_info(bool console_flush=
)
>  		ftrace_dump(DUMP_ALL);
>  }
>=20
> +/*
> + * Helper that accumulates all console flushing routines executed on pan=
ic.
> + */
> +static void console_flushing(void)
> +{
> +#ifdef CONFIG_VT
> +	unblank_screen();
> +#endif
> +	console_unblank();
> +
> +	/*
> +	 * In this point, we may have disabled other CPUs, hence stopping the
> +	 * CPU holding the lock while still having some valuable data in the
> +	 * console buffer.
> +	 *
> +	 * Try to acquire the lock then release it regardless of the result.
> +	 * The release will also print the buffers out. Locks debug should
> +	 * be disabled to avoid reporting bad unlock balance when panic()
> +	 * is not being called from OOPS.
> +	 */
> +	debug_locks_off();
> +	console_flush_on_panic(CONSOLE_FLUSH_PENDING);
> +
> +	panic_print_sys_info(true);
> +}
> +
> +#define PN_HYPERVISOR_BIT	0
> +#define PN_INFO_BIT		1
> +#define PN_PRE_REBOOT_BIT	2
> +#define PN_POST_REBOOT_BIT	3
> +
> +/*
> + * Determine the order of panic notifiers with regards to kdump.
> + *
> + * This function relies in the "panic_notifiers_level" kernel parameter
> + * to determine how to order the notifiers with regards to kdump. We
> + * have currently 5 levels. For details, please check the kernel docs fo=
r
> + * "panic_notifiers_level" at Documentation/admin-guide/kernel-parameter=
s.txt.
> + *
> + * Default level is 2, which means the panic hypervisor and informationa=
l
> + * (unless we don't have any kmsg_dumper) lists will execute before kdum=
p.
> + */
> +static void order_panic_notifiers_and_kdump(void)
> +{
> +	/*
> +	 * The parameter "crash_kexec_post_notifiers" is deprecated, but
> +	 * valid. Users that set it want really all panic notifiers to
> +	 * execute before kdump, so it's effectively the same as setting
> +	 * the panic notifiers level to 4.
> +	 */
> +	if (panic_notifiers_level >=3D 4 || crash_kexec_post_notifiers)
> +		return;
> +
> +	/*
> +	 * Based on the level configured (smaller than 4), we clear the
> +	 * proper bits in "panic_notifiers_bits". Notice that this bitfield
> +	 * is initialized with all notifiers set.
> +	 */
> +	switch (panic_notifiers_level) {
> +	case 3:
> +		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
> +		break;
> +	case 2:
> +		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
> +
> +		if (!kmsg_has_dumpers())
> +			clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
> +		break;
> +	case 1:
> +		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
> +		clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
> +		break;
> +	case 0:
> +		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
> +		clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
> +		clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits);
> +		break;
> +	}

I think the above switch statement could be done as follows:

if (panic_notifiers_level <=3D 3)
	clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
if (panic_notifiers_level <=3D 2)
	if (!kmsg_has_dumpers())
		clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
if (panic_notifiers_level <=3D1)
	clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
if (panic_notifiers_level =3D=3D 0)
	clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits);

That's about half the lines of code.  It's somewhat a matter of style,
so treat this as just a suggestion to consider.  I just end up looking
for a better solution when I see the same line of code repeated
3 or 4 times!

> +}
> +
> +/*
> + * Set of helpers to execute the panic notifiers only once.
> + * Just the informational notifier cares about the return.
> + */
> +static inline bool notifier_run_once(struct atomic_notifier_head head,
> +				     char *buf, long bit)
> +{
> +	if (test_and_change_bit(bit, &panic_notifiers_bits)) {
> +		atomic_notifier_call_chain(&head, PANIC_NOTIFIER, buf);
> +		return true;
> +	}
> +	return false;
> +}
> +
> +#define panic_notifier_hypervisor_once(buf)\
> +	notifier_run_once(panic_hypervisor_list, buf, PN_HYPERVISOR_BIT)
> +
> +#define panic_notifier_info_once(buf)\
> +	notifier_run_once(panic_info_list, buf, PN_INFO_BIT)
> +
> +#define panic_notifier_pre_reboot_once(buf)\
> +	notifier_run_once(panic_pre_reboot_list, buf, PN_PRE_REBOOT_BIT)
> +
> +#define panic_notifier_post_reboot_once(buf)\
> +	notifier_run_once(panic_post_reboot_list, buf, PN_POST_REBOOT_BIT)
> +
>  /**
>   *	panic - halt the system
>   *	@fmt: The text string to print
> @@ -198,32 +316,29 @@ void panic(const char *fmt, ...)
>  	long i, i_next =3D 0, len;
>  	int state =3D 0;
>  	int old_cpu, this_cpu;
> -	bool _crash_kexec_post_notifiers =3D crash_kexec_post_notifiers;
>=20
> -	if (panic_on_warn) {
> -		/*
> -		 * This thread may hit another WARN() in the panic path.
> -		 * Resetting this prevents additional WARN() from panicking the
> -		 * system on this thread.  Other threads are blocked by the
> -		 * panic_mutex in panic().
> -		 */
> -		panic_on_warn =3D 0;
> -	}
> +	/*
> +	 * This thread may hit another WARN() in the panic path, so
> +	 * resetting this option prevents additional WARN() from
> +	 * re-panicking the system here.
> +	 */
> +	panic_on_warn =3D 0;
>=20
>  	/*
>  	 * Disable local interrupts. This will prevent panic_smp_self_stop
> -	 * from deadlocking the first cpu that invokes the panic, since
> -	 * there is nothing to prevent an interrupt handler (that runs
> -	 * after setting panic_cpu) from invoking panic() again.
> +	 * from deadlocking the first cpu that invokes the panic, since there
> +	 * is nothing to prevent an interrupt handler (that runs after setting
> +	 * panic_cpu) from invoking panic() again. Also disables preemption
> +	 * here - notice it's not safe to rely on interrupt disabling to avoid
> +	 * preemption, since any cond_resched() or cond_resched_lock() might
> +	 * trigger a reschedule if the preempt count is 0 (for reference, see
> +	 * Documentation/locking/preempt-locking.rst). Some functions called
> +	 * from here want preempt disabled, so no point enabling it later.
>  	 */
>  	local_irq_disable();
>  	preempt_disable_notrace();
>=20
>  	/*
> -	 * It's possible to come here directly from a panic-assertion and
> -	 * not have preempt disabled. Some functions called from here want
> -	 * preempt to be disabled. No point enabling it later though...
> -	 *
>  	 * Only one CPU is allowed to execute the panic code from here. For
>  	 * multiple parallel invocations of panic, all other CPUs either
>  	 * stop themself or will wait until they are stopped by the 1st CPU
> @@ -266,73 +381,75 @@ void panic(const char *fmt, ...)
>  	kgdb_panic(buf);
>=20
>  	/*
> -	 * If we have crashed and we have a crash kernel loaded let it handle
> -	 * everything else.
> -	 * If we want to run this after calling panic_notifiers, pass
> -	 * the "crash_kexec_post_notifiers" option to the kernel.
> +	 * Here lies one of the most subtle parts of the panic path,
> +	 * the panic notifiers and their order with regards to kdump.
> +	 * We currently have 4 sets of notifiers:
>  	 *
> -	 * Bypass the panic_cpu check and call __crash_kexec directly.
> +	 *  - the hypervisor list is composed by callbacks that are related
> +	 *  to warn the FW / hypervisor about panic, or non-invasive LED
> +	 *  controlling functions - (hopefully) low-risk for kdump, should
> +	 *  run early if possible.
> +	 *
> +	 *  - the informational list is composed by functions dumping data
> +	 *  like kernel offsets, device error registers or tracing buffer;
> +	 *  also log flooding prevention callbacks fit in this list. It is
> +	 *  relatively safe to run before kdump.
> +	 *
> +	 *  - the pre_reboot list basically is everything else, all the
> +	 *  callbacks that don't fit in the 2 previous lists. It should
> +	 *  run *after* kdump if possible, as it contains high-risk
> +	 *  functions that may break kdump.
> +	 *
> +	 *  - we also have a 4th list of notifiers, the post_reboot
> +	 *  callbacks. This is not strongly related to kdump since it's
> +	 *  always executed late in the panic path, after the restart
> +	 *  mechanism (if set); its goal is to provide a way for
> +	 *  architecture code effectively power-off/disable the system.
> +	 *
> +	 *  The kernel provides the "panic_notifiers_level" parameter
> +	 *  to adjust the ordering in which these notifiers should run
> +	 *  with regards to kdump - the default level is 2, so both the
> +	 *  hypervisor and informational notifiers should execute before
> +	 *  the __crash_kexec(); the info notifier won't run by default
> +	 *  unless there's some kmsg_dumper() registered. For details
> +	 *  about it, check Documentation/admin-guide/kernel-parameters.txt.
> +	 *
> +	 *  Notice that the code relies in bits set/clear operations to
> +	 *  determine the ordering, functions *_once() execute only one
> +	 *  time, as their name implies. The goal is to prevent too much
> +	 *  if conditionals and more confusion. Finally, regarding CPUs
> +	 *  disabling: unless NO panic notifier executes before kdump,
> +	 *  we always disable secondary CPUs before __crash_kexec() and
> +	 *  the notifiers execute.
>  	 */
> -	if (!_crash_kexec_post_notifiers) {
> +	order_panic_notifiers_and_kdump();
> +
> +	/* If no level, we should kdump ASAP. */
> +	if (!panic_notifiers_level)
>  		__crash_kexec(NULL);
>=20
> -		/*
> -		 * Note smp_send_stop is the usual smp shutdown function, which
> -		 * unfortunately means it may not be hardened to work in a
> -		 * panic situation.
> -		 */
> -		smp_send_stop();
> -	} else {
> -		/*
> -		 * If we want to do crash dump after notifier calls and
> -		 * kmsg_dump, we will need architecture dependent extra
> -		 * works in addition to stopping other CPUs.
> -		 */
> -		crash_smp_send_stop();
> -	}
> +	crash_smp_send_stop();
> +	panic_notifier_hypervisor_once(buf);
>=20
> -	/*
> -	 * Run any panic handlers, including those that might need to
> -	 * add information to the kmsg dump output.
> -	 */
> -	atomic_notifier_call_chain(&panic_hypervisor_list, PANIC_NOTIFIER, buf)=
;
> -	atomic_notifier_call_chain(&panic_info_list, PANIC_NOTIFIER, buf);
> -	atomic_notifier_call_chain(&panic_pre_reboot_list, PANIC_NOTIFIER, buf)=
;
> +	if (panic_notifier_info_once(buf)) {
> +		panic_print_sys_info(false);
> +		kmsg_dump(KMSG_DUMP_PANIC);
> +	}
>=20
> -	panic_print_sys_info(false);
> +	panic_notifier_pre_reboot_once(buf);
>=20
> -	kmsg_dump(KMSG_DUMP_PANIC);
> +	__crash_kexec(NULL);
>=20
> -	/*
> -	 * If you doubt kdump always works fine in any situation,
> -	 * "crash_kexec_post_notifiers" offers you a chance to run
> -	 * panic_notifiers and dumping kmsg before kdump.
> -	 * Note: since some panic_notifiers can make crashed kernel
> -	 * more unstable, it can increase risks of the kdump failure too.
> -	 *
> -	 * Bypass the panic_cpu check and call __crash_kexec directly.
> -	 */
> -	if (_crash_kexec_post_notifiers)
> -		__crash_kexec(NULL);
> +	panic_notifier_hypervisor_once(buf);
>=20
> -#ifdef CONFIG_VT
> -	unblank_screen();
> -#endif
> -	console_unblank();
> -
> -	/*
> -	 * We may have ended up stopping the CPU holding the lock (in
> -	 * smp_send_stop()) while still having some valuable data in the consol=
e
> -	 * buffer.  Try to acquire the lock then release it regardless of the
> -	 * result.  The release will also print the buffers out.  Locks debug
> -	 * should be disabled to avoid reporting bad unlock balance when
> -	 * panic() is not being callled from OOPS.
> -	 */
> -	debug_locks_off();
> -	console_flush_on_panic(CONSOLE_FLUSH_PENDING);
> +	if (panic_notifier_info_once(buf)) {
> +		panic_print_sys_info(false);
> +		kmsg_dump(KMSG_DUMP_PANIC);
> +	}
>=20
> -	panic_print_sys_info(true);
> +	panic_notifier_pre_reboot_once(buf);
>=20
> +	console_flushing();
>  	if (!panic_blink)
>  		panic_blink =3D no_blink;
>=20
> @@ -363,8 +480,7 @@ void panic(const char *fmt, ...)
>  		emergency_restart();
>  	}
>=20
> -	atomic_notifier_call_chain(&panic_post_reboot_list,
> -				   PANIC_NOTIFIER, buf);
> +	panic_notifier_post_reboot_once(buf);
>=20
>  	pr_emerg("---[ end Kernel panic - not syncing: %s ]---\n", buf);
>=20
> @@ -383,6 +499,15 @@ void panic(const char *fmt, ...)
>=20
>  EXPORT_SYMBOL(panic);
>=20
> +/*
> + * Helper used in the kexec code, to validate if any
> + * panic notifier is set to execute early, before kdump.
> + */
> +inline bool panic_notifiers_before_kdump(void)
> +{
> +	return panic_notifiers_level || crash_kexec_post_notifiers;
> +}
> +
>  /*
>   * TAINT_FORCED_RMMOD could be a per-module flag but the module
>   * is being removed anyway.
> @@ -692,6 +817,9 @@ core_param(panic, panic_timeout, int, 0644);
>  core_param(panic_print, panic_print, ulong, 0644);
>  core_param(pause_on_oops, pause_on_oops, int, 0644);
>  core_param(panic_on_warn, panic_on_warn, int, 0644);
> +core_param(panic_notifiers_level, panic_notifiers_level, uint, 0644);
> +
> +/* DEPRECATED in favor of panic_notifiers_level */
>  core_param(crash_kexec_post_notifiers, crash_kexec_post_notifiers, bool,=
 0644);
>=20
>  static int __init oops_setup(char *s)
> diff --git a/tools/testing/selftests/pstore/pstore_crash_test
> b/tools/testing/selftests/pstore/pstore_crash_test
> index 2a329bbb4aca..1e60ce4501aa 100755
> --- a/tools/testing/selftests/pstore/pstore_crash_test
> +++ b/tools/testing/selftests/pstore/pstore_crash_test
> @@ -25,6 +25,7 @@ touch $REBOOT_FLAG
>  sync
>=20
>  # cause crash
> -# Note: If you use kdump and want to see kmesg-* files after reboot, you=
 should
> -#       specify 'crash_kexec_post_notifiers' in 1st kernel's cmdline.
> +# Note: If you use kdump and want to see kmsg-* files after reboot, you =
should
> +#       be sure that the parameter "panic_notifiers_level" is more than =
'2' (the
> +#       default value for this parameter is '2') in the first kernel's c=
mdline.
>  echo c > /proc/sysrq-trigger
> --
> 2.36.0



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 18:05:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 18:05:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317606.537013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUzz-0001AG-MU; Fri, 29 Apr 2022 18:05:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317606.537013; Fri, 29 Apr 2022 18:05:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkUzz-0001A9-JN; Fri, 29 Apr 2022 18:05:47 +0000
Received: by outflank-mailman (input) for mailman id 317606;
 Fri, 29 Apr 2022 18:05:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkUzy-0001A3-CZ
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 18:05:46 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fca0ee22-c7e6-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 20:05:44 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkUzF-0006RF-Du; Fri, 29 Apr 2022 20:05:01 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fca0ee22-c7e6-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=CfgJSltNTETfm69VgWZeJ1xxMOJuVJJeVDaV1//hOM4=; b=slyIgXmeUq77MnrSUr5lBtJx9z
	m86cp15BT6gKICc3jCqWbY2B0tpa99u5bAed7DYYXL/rMf6XHJRMLSIrTGUcJCHpVtGl/+APLcmrh
	RXQpa9HZXWVydxhVU95+hp+ZiaA0uHFZXPx5zEc5qg8trUY5PT1GKrapnos8zeTpFOAoQJEAx9vvn
	efpqnWK3jhpJIbXy7DD12LOMiGnr6GupNgQCAiVUmjcrI2J6NMnifvEjcuVQUbIlOFxyQL8HlLyj5
	ydadfwYuZkTNnyuPFseli5ffoVSkxD0MS5bvuilrJblEdywU2jKWaFEjPPnVXRJf3ScYrp3fr3KhT
	ij4JQKSA==;
Message-ID: <0147d038-571b-0802-c210-ccd4d52cd5dd@igalia.com>
Date: Fri, 29 Apr 2022 15:04:22 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list
Content-Language: en-US
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
 "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
 "bhe@redhat.com" <bhe@redhat.com>, "pmladek@suse.com" <pmladek@suse.com>,
 "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "bcm-kernel-feedback-list@broadcom.com"
 <bcm-kernel-feedback-list@broadcom.com>,
 "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
 "linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
 "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
 "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
 "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
 "linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
 "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
 "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
 "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
 "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
 "linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
 "linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 "openipmi-developer@lists.sourceforge.net"
 <openipmi-developer@lists.sourceforge.net>,
 "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
 "sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "x86@kernel.org" <x86@kernel.org>,
 "kernel-dev@igalia.com" <kernel-dev@igalia.com>,
 "kernel@gpiccoli.net" <kernel@gpiccoli.net>,
 "halves@canonical.com" <halves@canonical.com>,
 "fabiomirmar@gmail.com" <fabiomirmar@gmail.com>,
 "alejandro.j.jimenez@oracle.com" <alejandro.j.jimenez@oracle.com>,
 "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
 "arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
 "corbet@lwn.net" <corbet@lwn.net>,
 "d.hatayama@jp.fujitsu.com" <d.hatayama@jp.fujitsu.com>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 "dyoung@redhat.com" <dyoung@redhat.com>,
 "feng.tang@intel.com" <feng.tang@intel.com>,
 "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
 "hidehiro.kawai.ez@hitachi.com" <hidehiro.kawai.ez@hitachi.com>,
 "jgross@suse.com" <jgross@suse.com>,
 "john.ogness@linutronix.de" <john.ogness@linutronix.de>,
 "keescook@chromium.org" <keescook@chromium.org>,
 "luto@kernel.org" <luto@kernel.org>,
 "mhiramat@kernel.org" <mhiramat@kernel.org>,
 "mingo@redhat.com" <mingo@redhat.com>,
 "paulmck@kernel.org" <paulmck@kernel.org>,
 "peterz@infradead.org" <peterz@infradead.org>,
 "rostedt@goodmis.org" <rostedt@goodmis.org>,
 "senozhatsky@chromium.org" <senozhatsky@chromium.org>,
 "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
 "tglx@linutronix.de" <tglx@linutronix.de>,
 "vgoyal@redhat.com" <vgoyal@redhat.com>, vkuznets <vkuznets@redhat.com>,
 "will@kernel.org" <will@kernel.org>,
 Alexander Gordeev <agordeev@linux.ibm.com>,
 Andrea Parri <parri.andrea@gmail.com>, Ard Biesheuvel <ardb@kernel.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Brian Norris <computersforpeace@gmail.com>,
 Christian Borntraeger <borntraeger@linux.ibm.com>,
 Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 David Gow <davidgow@google.com>, "David S. Miller" <davem@davemloft.net>,
 Dexuan Cui <decui@microsoft.com>, Doug Berger <opendmb@gmail.com>,
 Evan Green <evgreen@chromium.org>, Florian Fainelli <f.fainelli@gmail.com>,
 Haiyang Zhang <haiyangz@microsoft.com>, Hari Bathini
 <hbathini@linux.ibm.com>, Heiko Carstens <hca@linux.ibm.com>,
 Julius Werner <jwerner@chromium.org>, Justin Chen <justinpopo6@gmail.com>,
 KY Srinivasan <kys@microsoft.com>, Lee Jones <lee.jones@linaro.org>,
 Markus Mayer <mmayer@broadcom.com>, Michael Ellerman <mpe@ellerman.id.au>,
 Mihai Carabas <mihai.carabas@oracle.com>, Nicholas Piggin
 <npiggin@gmail.com>, Paul Mackerras <paulus@samba.org>,
 Pavel Machek <pavel@ucw.cz>, Scott Branden <scott.branden@broadcom.com>,
 Sebastian Reichel <sre@kernel.org>,
 Shile Zhang <shile.zhang@linux.alibaba.com>,
 Stephen Hemminger <sthemmin@microsoft.com>,
 Sven Schnelle <svens@linux.ibm.com>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Tianyu Lan <Tianyu.Lan@microsoft.com>, Vasily Gorbik <gor@linux.ibm.com>,
 Wang ShaoBo <bobo.shaobowang@huawei.com>, Wei Liu <wei.liu@kernel.org>,
 zhenwei pi <pizhenwei@bytedance.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-20-gpiccoli@igalia.com>
 <PH0PR21MB30256260CCF4CAB713BBB11ED7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <PH0PR21MB30256260CCF4CAB713BBB11ED7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/04/2022 14:30, Michael Kelley (LINUX) wrote:
> From: Guilherme G. Piccoli <gpiccoli@igalia.com> Sent: Wednesday, April 27, 2022 3:49 PM
>> [...]
>>
>> @@ -2843,7 +2843,7 @@ static void __exit vmbus_exit(void)
>>  	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) {
>>  		kmsg_dump_unregister(&hv_kmsg_dumper);
>>  		unregister_die_notifier(&hyperv_die_report_block);
>> -		atomic_notifier_chain_unregister(&panic_notifier_list,
>> +		atomic_notifier_chain_unregister(&panic_hypervisor_list,
>>  						&hyperv_panic_report_block);
>>  	}
>>
> 
> Using the hypervisor_list here produces a bit of a mismatch.  In many cases
> this notifier will do nothing, and will defer to the kmsg_dump() mechanism
> to notify the hypervisor about the panic.   Running the kmsg_dump()
> mechanism is linked to the info_list, so I'm thinking the Hyper-V panic report
> notifier should be on the info_list as well.  That way the reporting behavior
> is triggered at the same point in the panic path regardless of which
> reporting mechanism is used.
> 

Hi Michael, thanks for your feedback! I agree that your idea could work,
but...there is one downside: imagine the kmsg_dump() approach is not set
in some Hyper-V guest, then we would rely in the regular notification
mechanism [hv_die_panic_notify_crash()], right?
But...you want then to run this notifier in the informational list,
which...won't execute *by default* before kdump if no kmsg_dump() is
set. So, this logic is convoluted when you mix it with the default level
concept + kdump.

May I suggest something? If possible, take a run with this patch set +
DEBUG_NOTIFIER=y, in *both* cases (with and without the kmsg_dump()
set). I did that and they run almost at the same time...I've checked the
notifiers called, it's like almost nothing runs in-between.

I feel the panic notification mechanism does really fit with a
hypervisor list, it's a good match with the nature of the list, which
aims at informing the panic notification to the hypervisor/FW.
Of course we can modify it if you prefer...but please take into account
the kdump case and how it complicates the logic.

Let me know your considerations, in case you can experiment with the
patch set as-is.
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 18:07:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 18:07:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317614.537024 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkV1N-0001kJ-3P; Fri, 29 Apr 2022 18:07:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317614.537024; Fri, 29 Apr 2022 18:07:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkV1M-0001kC-UR; Fri, 29 Apr 2022 18:07:12 +0000
Received: by outflank-mailman (input) for mailman id 317614;
 Fri, 29 Apr 2022 18:07:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=R1X1=VH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nkV1L-0001k4-Cn
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 18:07:11 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 30263f15-c7e7-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 20:07:10 +0200 (CEST)
Received: by mail-lf1-x12f.google.com with SMTP id x33so15454621lfu.1
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 11:07:10 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 r16-20020a2eb890000000b0024f3d1daf00sm332318ljp.136.2022.04.29.11.07.08
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 29 Apr 2022 11:07:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30263f15-c7e7-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=2Bod++nC0Kk+aQssi3umh6aHjPXr2Qr5aaJpsWFhO1I=;
        b=GXQX2nKZwVNheR4CvTVkfcyO6lHX51/Xa8Z3jo9Rs+MwSdf6Ja6EizxFGdQ5akg63G
         1XXwO5x34IveFMiIjnaMD9MRrfMwMALEKJamNTYMJYNnLayjMcmUot1IzOcySEwN7Ays
         C4M3QABL5Xvd6h7CRVxGzkaSRLjWgFFt9Psnr0AuqA/A83Lav0T4GrxnLdbC+u9lsDWf
         Xp5kQVhSXloD4OG5usw9qu8JQrJvOJn0wsCPgSxJsQkmWqFRUSx261TtS3OZflHr2vQW
         sFTlklvrhzlBkP5YqeKFFF0NSwZWRxDz9/gH4Qr7iGKE5haIG2FgokKaQVVNw2OlHMJX
         tqDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=2Bod++nC0Kk+aQssi3umh6aHjPXr2Qr5aaJpsWFhO1I=;
        b=xyK2Wq7TTuRccO1M1areFs9rCdh8GiGgQYXmHr48EI7qQ6T6hnqRDfvQZyPEsLJdws
         G0YpjJptyV9tYtCmXETvg69DOIQOW4gMCJHAxdaOk1nrxgg5z+p4DMH0t+w8fTh8FVk+
         gvs+/ZQcpf/OtmGon+XvmEEn5x9aWQEh8JLKna99ui1P/Xg7WCqUNEDn9rINHTi6qcfz
         vxfQmSIUvhJk1LxPyy8H6cKDPR+YDsvy0QxN9vZFuO6GeeESyZ3TquatCqR3AqSPPlLT
         ZdkoT6LSUSttv2k3oKJfokly4xSxwmV4e/SrGNiu6nSQs/YD/J8rJOhnzL0PgT9skZ+M
         vHow==
X-Gm-Message-State: AOAM532xfPCvKDTsUR8QpxLlc3SWOaaaTywdgZBChPcQzaHbZYykh4zo
	NNLqLZrTRiSTXkhSKyidiw8=
X-Google-Smtp-Source: ABdhPJwxdZIYiQZIv5z+o6u5Pjt2obFs9wpBIYt6fLDmJl64mXj5FdMnWGjm935gx8cthCrX5x5YQg==
X-Received: by 2002:a19:ca06:0:b0:472:3b31:1ade with SMTP id a6-20020a19ca06000000b004723b311ademr314003lfg.162.1651255629583;
        Fri, 29 Apr 2022 11:07:09 -0700 (PDT)
Subject: Re: [PATCH v2 18/19] xen/sndfront: use xenbus_setup_ring() and
 xenbus_teardown_ring()
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
 alsa-devel@alsa-project.org
References: <20220428082743.16593-1-jgross@suse.com>
 <20220428082743.16593-19-jgross@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <91b8b63c-46f0-326e-4092-5bb6c8f681db@gmail.com>
Date: Fri, 29 Apr 2022 21:07:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220428082743.16593-19-jgross@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 28.04.22 11:27, Juergen Gross wrote:

Hello Juergen, all

> Simplify sndfront's ring creation and removal via xenbus_setup_ring()
> and xenbus_teardown_ring().
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

I am not familiar with SOUND bits of this driver, but a little bit
familiar with Xen bits this patch only touches and I have environment to
test.

Xen specific changes looks good to me. Also I didn't see any issues when 
testing virtulized sound driver with current series except one I have 
already pointed out in PATCH v2 08/19.


root@salvator-x-h3-4x2g-xt-domu:~# dmesg | grep vsnd
[    0.432181] Initialising Xen vsnd frontend driver


root@salvator-x-h3-4x2g-xt-domu:~# aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: vsnd [], device 0: dev1 [Virtual card PCM]
   Subdevices: 1/1
   Subdevice #0: subdevice #0

root@generic-armv8-xt-dom0:~# xenstore-ls -f | grep vsnd
/local/domain/1/backend/vsnd = ""
/local/domain/1/backend/vsnd/6 = ""
/local/domain/1/backend/vsnd/6/0 = ""
/local/domain/1/backend/vsnd/6/0/frontend = "/local/domain/6/device/vsnd/0"
/local/domain/1/backend/vsnd/6/0/frontend-id = "6"
/local/domain/1/backend/vsnd/6/0/online = "1"
/local/domain/1/backend/vsnd/6/0/state = "4"
/local/domain/6/device/vsnd = ""
/local/domain/6/device/vsnd/0 = ""
/local/domain/6/device/vsnd/0/backend = "/local/domain/1/backend/vsnd/6/0"
/local/domain/6/device/vsnd/0/backend-id = "1"
/local/domain/6/device/vsnd/0/state = "4"
/local/domain/6/device/vsnd/0/long-name = "Virtual sound card"
/local/domain/6/device/vsnd/0/short-name = "VCard"
/local/domain/6/device/vsnd/0/sample-rates = 
"8000,11025,16000,22050,32000,44100,48000"
/local/domain/6/device/vsnd/0/sample-formats = "s16_le"
/local/domain/6/device/vsnd/0/buffer-size = "65536"
/local/domain/6/device/vsnd/0/0 = ""
/local/domain/6/device/vsnd/0/0/name = "dev1"
/local/domain/6/device/vsnd/0/0/0 = ""
/local/domain/6/device/vsnd/0/0/0/unique-id = "pulse"
/local/domain/6/device/vsnd/0/0/0/type = "p"
/local/domain/6/device/vsnd/0/0/0/ring-ref = "2070"
/local/domain/6/device/vsnd/0/0/0/event-channel = "18"
/local/domain/6/device/vsnd/0/0/0/evt-ring-ref = "2071"
/local/domain/6/device/vsnd/0/0/0/evt-event-channel = "19"
/libxl/6/device/vsnd = ""
/libxl/6/device/vsnd/0 = ""
/libxl/6/device/vsnd/0/frontend = "/local/domain/6/device/vsnd/0"
/libxl/6/device/vsnd/0/backend = "/local/domain/1/backend/vsnd/6/0"
/libxl/6/device/vsnd/0/frontend-id = "6"
/libxl/6/device/vsnd/0/online = "1"
/libxl/6/device/vsnd/0/state = "1"


> ---
>   sound/xen/xen_snd_front_evtchnl.c | 44 +++++++------------------------
>   1 file changed, 10 insertions(+), 34 deletions(-)
>
> diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
> index 3e21369c8216..26d1b3987887 100644
> --- a/sound/xen/xen_snd_front_evtchnl.c
> +++ b/sound/xen/xen_snd_front_evtchnl.c
> @@ -143,12 +143,12 @@ void xen_snd_front_evtchnl_flush(struct xen_snd_front_evtchnl *channel)
>   static void evtchnl_free(struct xen_snd_front_info *front_info,
>   			 struct xen_snd_front_evtchnl *channel)
>   {
> -	unsigned long page = 0;
> +	void *page = NULL;
>   
>   	if (channel->type == EVTCHNL_TYPE_REQ)
> -		page = (unsigned long)channel->u.req.ring.sring;
> +		page = channel->u.req.ring.sring;
>   	else if (channel->type == EVTCHNL_TYPE_EVT)
> -		page = (unsigned long)channel->u.evt.page;
> +		page = channel->u.evt.page;
>   
>   	if (!page)
>   		return;
> @@ -167,10 +167,7 @@ static void evtchnl_free(struct xen_snd_front_info *front_info,
>   		xenbus_free_evtchn(front_info->xb_dev, channel->port);
>   
>   	/* End access and free the page. */
> -	if (channel->gref != INVALID_GRANT_REF)
> -		gnttab_end_foreign_access(channel->gref, page);
> -	else
> -		free_page(page);
> +	xenbus_teardown_ring(&page, 1, &channel->gref);
>   
>   	memset(channel, 0, sizeof(*channel));
>   }
> @@ -196,8 +193,7 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
>   			 enum xen_snd_front_evtchnl_type type)
>   {
>   	struct xenbus_device *xb_dev = front_info->xb_dev;
> -	unsigned long page;
> -	grant_ref_t gref;
> +	void *page;
>   	irq_handler_t handler;
>   	char *handler_name = NULL;
>   	int ret;
> @@ -207,12 +203,9 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
>   	channel->index = index;
>   	channel->front_info = front_info;
>   	channel->state = EVTCHNL_STATE_DISCONNECTED;
> -	channel->gref = INVALID_GRANT_REF;
> -	page = get_zeroed_page(GFP_KERNEL);
> -	if (!page) {
> -		ret = -ENOMEM;
> +	ret = xenbus_setup_ring(xb_dev, GFP_KERNEL, &page, 1, &channel->gref);
> +	if (ret)
>   		goto fail;
> -	}
>   
>   	handler_name = kasprintf(GFP_KERNEL, "%s-%s", XENSND_DRIVER_NAME,
>   				 type == EVTCHNL_TYPE_REQ ?
> @@ -226,33 +219,18 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
>   	mutex_init(&channel->ring_io_lock);
>   
>   	if (type == EVTCHNL_TYPE_REQ) {
> -		struct xen_sndif_sring *sring = (struct xen_sndif_sring *)page;
> +		struct xen_sndif_sring *sring = page;
>   
>   		init_completion(&channel->u.req.completion);
>   		mutex_init(&channel->u.req.req_io_lock);
> -		SHARED_RING_INIT(sring);
> -		FRONT_RING_INIT(&channel->u.req.ring, sring, XEN_PAGE_SIZE);
> -
> -		ret = xenbus_grant_ring(xb_dev, sring, 1, &gref);
> -		if (ret < 0) {
> -			channel->u.req.ring.sring = NULL;
> -			goto fail;
> -		}
> +		XEN_FRONT_RING_INIT(&channel->u.req.ring, sring, XEN_PAGE_SIZE);
>   
>   		handler = evtchnl_interrupt_req;
>   	} else {
> -		ret = gnttab_grant_foreign_access(xb_dev->otherend_id,
> -						  virt_to_gfn((void *)page), 0);
> -		if (ret < 0)
> -			goto fail;
> -
> -		channel->u.evt.page = (struct xensnd_event_page *)page;
> -		gref = ret;
> +		channel->u.evt.page = page;
>   		handler = evtchnl_interrupt_evt;
>   	}
>   
> -	channel->gref = gref;
> -
>   	ret = xenbus_alloc_evtchn(xb_dev, &channel->port);
>   	if (ret < 0)
>   		goto fail;
> @@ -279,8 +257,6 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index,
>   	return 0;
>   
>   fail:
> -	if (page)
> -		free_page(page);
>   	kfree(handler_name);
>   	dev_err(&xb_dev->dev, "Failed to allocate ring: %d\n", ret);
>   	return ret;

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 18:18:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 18:18:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317622.537035 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkVCW-0003GG-3I; Fri, 29 Apr 2022 18:18:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317622.537035; Fri, 29 Apr 2022 18:18:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkVCV-0003G9-WD; Fri, 29 Apr 2022 18:18:44 +0000
Received: by outflank-mailman (input) for mailman id 317622;
 Fri, 29 Apr 2022 18:18:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CdjT=VH=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nkVCU-0003G3-Nt
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 18:18:42 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2060b.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::60b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb3b58bc-c7e8-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 20:18:40 +0200 (CEST)
Received: from AS9PR06CA0235.eurprd06.prod.outlook.com (2603:10a6:20b:45e::34)
 by VI1PR08MB3600.eurprd08.prod.outlook.com (2603:10a6:803:85::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 18:18:35 +0000
Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45e:cafe::1d) by AS9PR06CA0235.outlook.office365.com
 (2603:10a6:20b:45e::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend
 Transport; Fri, 29 Apr 2022 18:18:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 18:18:34 +0000
Received: ("Tessian outbound facaf1373bbd:v118");
 Fri, 29 Apr 2022 18:18:34 +0000
Received: from b60667392f89.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CBBDCFC8-4861-4EEB-93C1-60C863EF024C.1; 
 Fri, 29 Apr 2022 18:18:27 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b60667392f89.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 29 Apr 2022 18:18:27 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by VE1PR08MB4752.eurprd08.prod.outlook.com
 (2603:10a6:802:a4::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr
 2022 18:18:24 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::6c39:76a0:c05c:2938]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::6c39:76a0:c05c:2938%11]) with mapi id 15.20.5186.026; Fri, 29 Apr
 2022 18:18:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb3b58bc-c7e8-11ec-8fc4-03012f2f19d4
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=NJijWWK2bj0bW3SVosC2DiKliVNoKzON6Ci1MY6ERzpmEPWIcMsqc5EnMGn5bcQ2vwNOc3KitLb+x9XWtjmTB204Q/TfSIDRi4SNcJqQDgMd+CRVIlzVCtFbNGOufOcm6FcjVt6d3orCI/784Z6V7bs7M70JR25s/W4jB++UGU/5DVR6yMFZGtCRiocOiwT3zO6baOxw2enTalHgFN9c9rEhXJr+40dmjxhv5J835xCTePYXRwEAI3iMyTRZFiKWoV0Ebo//IsXVyLx1rKaI/hNZBX4z3dQA8hicXhEhcICu1kXR85hQ/y+z9ofRjLP63kuOpEC0fWEXz1LTSu5JwQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qsTGaAa0fiIKj3RJZoNLhnEkA6ti42zy9E1mk+YvjfE=;
 b=Rq7YIQkf7ZZDXQt1QZi5hJkPJxf9Db3IwnV3VHJJ0KA5kePm8SZiGzw0UuxjJagDyUGQWNiHduHGR62vZ8YMCHpnppyc9P+G1jvU3s6XUKMhUYTIA+9s7Z924vStr8iLMsza5nk5nsHPyRDfk/1h4CoHtqurCKkVQsidNBlpwyllWyuWG5iZyuF47GEUsClJDaCmbtjwsqaUdp5Nif6MgOvl+cxQiNTG0l49JaUwDSQPDtZ/XBgs7IF2Pwb/bbhUa/Wtp1Sd1tWINmPmHkJS4MUdeOZ6zMu71QyvqJ4XaIFcBcvvX06pVAtN2gyV+5xMzPVPfCi6/Jhqj2uky1h1ng==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qsTGaAa0fiIKj3RJZoNLhnEkA6ti42zy9E1mk+YvjfE=;
 b=jPPmFP1q5cXxzDbZdoqsHiiV771aXO6+sUGRSD3qXNlJe0dt94AT/BxWGK4bEZj4YccFbuwuZDCTAnbtOQB2RLL8l6dV1+Te97z4temUgbTMJjcJdkNxSTxf51GqdOiYg0v+VuNaB7RgqUqsEu3FijcA7iv1iuFdOizfe2LWtYM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 06f721cd32c5e485
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DOs3pnVo7S5P/bGoAbK48r+l7NaKDVmFZ4VOJ76Ge7+kwAQxuCswHl1HbI7z8pfyfK6qVldjHoAI/scLJAYEIywTccYa7zplt4Qgpc3UMbK1e4WTS5odMzC8ZRxj1gLP97RnlE0ogxMi7KlwK+EHwDn6JowNElgMGIJan1OrbzaefzPP/4pYQsgM4i2AIgMIeD7S3DKirvxNMq5n8jF0A2r0A8KCJRFBMxy6VKz34t7ppGJMpdm+0kwBXb8Z7pzJMfRH+z8i3aHQuXKHpWKmay02NU6TvO8IKZW3pyzGhNIIrTXd4t/m83c8FPtTH6KFIaWYM0CIbaJfjaEke2vm0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qsTGaAa0fiIKj3RJZoNLhnEkA6ti42zy9E1mk+YvjfE=;
 b=EyFY5OhbJRPvoV9HW1yh8IeXeSblxNqwCxB06yFKheyqrJxeP/9IyxiO2YlCGvmLTnh8aqWY6PWwRp7WHTX94A8e1NriNBJlZjVVkOn7wyrM9VfDe+Ypvw5QJeZz+cwnZEhC6zXwnW8F3HwDI7tsUSgHCQ1g6HB68v54BV2DFdBZuJuJN6qdyJNSLDdKVozLohBamvr/5XEVLBHQ3DsLAKUolTxzUAVKP6dfbl/byBf5gETrBZCOV1CyiBRRd/1QCwTupI6Z77fFiGBK9/tl5IKzD87ZHB9103qwcNLZfBgf9K2dSmEROwO+OV3S9NtUTfaogYnFzskxjkv1SFSU7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qsTGaAa0fiIKj3RJZoNLhnEkA6ti42zy9E1mk+YvjfE=;
 b=jPPmFP1q5cXxzDbZdoqsHiiV771aXO6+sUGRSD3qXNlJe0dt94AT/BxWGK4bEZj4YccFbuwuZDCTAnbtOQB2RLL8l6dV1+Te97z4temUgbTMJjcJdkNxSTxf51GqdOiYg0v+VuNaB7RgqUqsEu3FijcA7iv1iuFdOizfe2LWtYM=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] arm/acpi: don't expose the ACPI IORT SMMUv3 entry to dom0
Thread-Topic: [PATCH] arm/acpi: don't expose the ACPI IORT SMMUv3 entry to
 dom0
Thread-Index: AQHYWlGqg8d+SR8SokCgQy1GM9ERN60EFAcAgAMiW4A=
Date: Fri, 29 Apr 2022 18:18:24 +0000
Message-ID: <780400E5-C22A-471E-BB19-C2F3B24112F1@arm.com>
References:
 <e11c57909782c60a6914d81e9c9893ff1712cc5b.1651075724.git.rahul.singh@arm.com>
 <c3b83cd4-7633-7aee-ab40-9eff26a4f801@xen.org>
In-Reply-To: <c3b83cd4-7633-7aee-ab40-9eff26a4f801@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: dac9cf9d-b3e1-4ee3-44a2-08da2a0cac55
x-ms-traffictypediagnostic:
	VE1PR08MB4752:EE_|VE1EUR03FT054:EE_|VI1PR08MB3600:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB36000EA9BBCCF50138C17CEDFCFC9@VI1PR08MB3600.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 7lseIDxMvUaTEzHlobO+3ipEcDZRju1ovzHwZLLnFTvvoJWsUB9WvaFEOU1h5HZM+AuWZWdibg1dq/edA+gIKwHmH29L9jeB5u2fheaUh+3NoFB6cp+ThxfOhXQ75Zf8il9owJLedF64Py11NWKq6+el662kCLS5VsrzFr1CkIm76DUbpw8Zuy9bR7ri2aQGTYjw/t7rruS1zD5BtJJjeHxDCRpiksmIKjWbN8153SO9ZpgQNKbTwJyxiUiRjlbIqstE8sGng47br+HV5AaJl05oV4RgpaykGiduyP2+I7hVyVrVMCRiu0nSaQpGJ4O6KLXNXAH0SO3V5Xr5ydoMYMM7/JPE6BaUhXSRS8G1v3tHdfjUUAlkBqstG1jYVSfo+NgMh+N28SJ1fbcv2dFcEn9f6R1zFBt08WxeWi6P5rCGMxebehz2R23SdvDBVGgbZE4/VF5A94Mse660yNvTrPHgajMQ8olbyWJu2yLkTQgPjpS2v/8PG8RoyEo84RpeadixfxmY1eBwQGnAmjo/WKWi93Y5gCaFqKoxhL1Q0beVP0gLA3SfLWvz1MlAOm9iKXXrzVRpYXCZMi0IKQLAGa1dad3izaOxAvSvsZF68d1bE022PCg8xVTIyqB+GHIER5HuOI9kgvXRNzzET5U+5wvQm0DdDZOAgjhJPeq5AST8T5qtC53557+zr/HF2Jwe6cMcNuTIM4yfwjEQPvE2sJFuRmd63psmj4HISSWiJOctNehioqOKIGiNPnqmmZ+m
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8936002)(66446008)(66476007)(66946007)(71200400001)(66556008)(64756008)(76116006)(91956017)(508600001)(6486002)(38070700005)(8676002)(38100700002)(6916009)(54906003)(316002)(5660300002)(86362001)(83380400001)(36756003)(2616005)(2906002)(186003)(6512007)(53546011)(6506007)(26005)(33656002)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <721FDC76CDBC234BA3BE69E036D8AA4B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4752
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7413aa9d-6932-4308-8c71-08da2a0ca661
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jYqP0gdgbtbu12n8C4NSaa7lWHb+TIhbwcAWLJer+JK99swZiY0r5j66WKKHLW20km8phDwKFtUJs0GoBpmhOvBvGu96G2ZRGK11IdEz/BOX6jHI7TVf18GkpfWG81tpnxFDO1ZBj83ktsPIgEVJBZ2nVXiuOgVEuIbh8Jv7/UowB+wDe4X9aCEcRfTohGitjHbUk4z+N8kFvN/L4kPNU2Q1WXec015AJ9EL7hP8NGQ+yrzptfADVEuR3nvRdAsMBxGRYP8MitrXtu/OXGygaFlVRRsty/BzE+3HQlstK23sPhPdm/ufiWxoYdKKkEhYAVcGkpAizghJFyiBA2vgVhStVJlho3gXIsvY5nDbuFK7j5oEQhxCVTsqiJclYAKsA5NaO9RstVVgE04pOequyAmLM0rIQuUAoQmXyXF9t/TEfphdOl0D8s5xj/c4RpvmY1/XVnXtgV5aQXFaHkhh6jdBOeBIqaYSLX/+TJVq5Pvo5AAFffDnlXTU+mYYLm/HhzmMETSL9WGYDAyb0qTnV/FYUvFgN1+orpY5jlh27BHU92SUMAHNhLPC+ANhKiQupQSA3i1NFxF4dVB9qw+sGeqtA5xEi9wByBph/802pypwpwKU+f4KOeQCCVbLsU5WdJO4e/OA4ioQIO/7SWJ+wDFlxq7hBfp3rN84UfdfncU8fpbL/gw1HBBzmPFl55MD
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(186003)(36756003)(5660300002)(36860700001)(70206006)(2906002)(33656002)(316002)(83380400001)(8676002)(4326008)(6862004)(70586007)(8936002)(54906003)(2616005)(40460700003)(336012)(107886003)(6486002)(86362001)(47076005)(508600001)(82310400005)(81166007)(356005)(26005)(6512007)(53546011)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 18:18:34.4192
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dac9cf9d-b3e1-4ee3-44a2-08da2a0cac55
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3600

SGkgSnVsaWVuLA0KDQo+IE9uIDI3IEFwciAyMDIyLCBhdCA3OjI2IHBtLCBKdWxpZW4gR3JhbGwg
PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIFJhaHVsLA0KPiANCj4gT24gMjcvMDQv
MjAyMiAxNzoxMiwgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiBYZW4gc2hvdWxkIGNvbnRyb2wgdGhl
IFNNTVV2MyBkZXZpY2VzIHRoZXJlZm9yZSwgZG9uJ3QgZXhwb3NlIHRoZQ0KPj4gU01NVXYzIGRl
dmljZXMgdG8gZG9tMC4gRGVueSBpb21lbSBhY2Nlc3MgdG8gU01NVXYzIGFkZHJlc3Mgc3BhY2Ug
Zm9yDQo+PiBkb20wIGFuZCBhbHNvIG1ha2UgQUNQSSBJT1JUIFNNTVV2MyBub2RlIHR5cGUgdG8g
MHhmZi4NCj4gDQo+IExvb2tpbmcgYXQgdGhlIElPUlQgc3BlYyAoQVJNIERFTiAwMDQ5RSksIDI1
NSAoMHhmZikgaXMgbWFya2VkIGFzIHJlc2VydmVkLiBTbyBJIGRvbid0IHRoaW5rIHdlIGNhbiAi
YWxsb2NhdGUiIDB4ZmYgdG8gbWVhbiBpbnZhbGlkIHdpdGhvdXQgdXBkYXRpbmcgdGhlIHNwZWMu
IERpZCB5b3UgZW5nYWdlIHdpdGggd2hvZXZlciBvd24gdGhlIHNwZWM/DQoNClllcyBJIGFncmVl
IHdpdGggeW91IDB4ZmYgaXMgcmVzZXJ2ZWQgZm9yIGZ1dHVyZSB1c2UuIEkgZGlkbuKAmXQgZmlu
ZCBhbnkgb3RoZXIgdmFsdWUgdG8gbWFrZSBub2RlIGludmFsaWQuIA0KTGludXgga2VybmVsIGlz
IG1vc3RseSB1c2luZyB0aGUgbm9kZS0+dHlwZSB0byBwcm9jZXNzIHRoZSBTTU1VdjMgb3Igb3Ro
ZXIgSU9SVCBub2RlIHNvIEkgdGhvdWdodCB0aGlzIGlzIHRoZSBvbmx5IHBvc3NpYmxlIHNvbHV0
aW9uIHRvIGhpZGUgU01NVXYzIGZvciBkb20wDQoNCklmIHlvdSBoYXZlIGFueSBvdGhlciBzdWdn
ZXN0aW9uIHRvIGhpZGUgdGhlIFNNTVV2MyBub2RlIEkgYW0gb2theSB0byB1c2UgdGhhdC4NCj4g
DQo+PiBTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+
IC0tLQ0KPj4geGVuL2FyY2gvYXJtL2FjcGkvZG9tYWluX2J1aWxkLmMgfCA0MCArKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKw0KPj4gMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMo
KykNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYWNwaS9kb21haW5fYnVpbGQuYyBiL3hl
bi9hcmNoL2FybS9hY3BpL2RvbWFpbl9idWlsZC5jDQo+PiBpbmRleCBiYmRjOTBmOTJjLi5lYzBi
NWIyNjFmIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2FjcGkvZG9tYWluX2J1aWxkLmMN
Cj4+ICsrKyBiL3hlbi9hcmNoL2FybS9hY3BpL2RvbWFpbl9idWlsZC5jDQo+PiBAQCAtMTQsNiAr
MTQsNyBAQA0KPj4gI2luY2x1ZGUgPHhlbi9hY3BpLmg+DQo+PiAjaW5jbHVkZSA8eGVuL2V2ZW50
Lmg+DQo+PiAjaW5jbHVkZSA8eGVuL2lvY2FwLmg+DQo+PiArI2luY2x1ZGUgPHhlbi9zaXplcy5o
Pg0KPj4gI2luY2x1ZGUgPHhlbi9kZXZpY2VfdHJlZS5oPg0KPj4gI2luY2x1ZGUgPHhlbi9saWJm
ZHQvbGliZmR0Lmg+DQo+PiAjaW5jbHVkZSA8YWNwaS9hY3RhYmxlcy5oPg0KPj4gQEAgLTMwLDYg
KzMxLDcgQEAgc3RhdGljIGludCBfX2luaXQgYWNwaV9pb21lbV9kZW55X2FjY2VzcyhzdHJ1Y3Qg
ZG9tYWluICpkKQ0KPj4gew0KPj4gYWNwaV9zdGF0dXMgc3RhdHVzOw0KPj4gc3RydWN0IGFjcGlf
dGFibGVfc3BjciAqc3BjciA9IE5VTEw7DQo+PiArIHN0cnVjdCBhY3BpX3RhYmxlX2lvcnQgKmlv
cnQ7DQo+PiB1bnNpZ25lZCBsb25nIG1mbjsNCj4+IGludCByYzsNCj4+IEBAIC01NSw2ICs1Nyw0
NCBAQCBzdGF0aWMgaW50IF9faW5pdCBhY3BpX2lvbWVtX2RlbnlfYWNjZXNzKHN0cnVjdCBkb21h
aW4gKmQpDQo+PiBwcmludGsoIkZhaWxlZCB0byBnZXQgU1BDUiB0YWJsZSwgWGVuIGNvbnNvbGUg
bWF5IGJlIHVuYXZhaWxhYmxlXG4iKTsNCj4+IH0NCj4+ICsgc3RhdHVzID0gYWNwaV9nZXRfdGFi
bGUoQUNQSV9TSUdfSU9SVCwgMCwNCj4+ICsgKHN0cnVjdCBhY3BpX3RhYmxlX2hlYWRlciAqKikm
aW9ydCk7DQo+IA0KPiBBdCBzb21lIHBvaW50IHdlIHdpbGwgbmVlZCB0byBhZGQgc3VwcG9ydCB0
byBoaWRlIHRoZSBBUk0gU01NVSBkZXZpY2UgYW5kIHBvc3NpYmx5IHNvbWUgZGV2aWNlcy4gU28g
SSB0aGluayBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gY3JlYXRlIGEgZnVuY3Rpb24gdGhhdCB3b3Vs
ZCBkZWFsIHdpdGggdGhlIElPUlQuDQoNCk9rLiBMZXQgbWUgYWRkIHRoZSBmdW5jdGlvbiBpbiBu
ZXh0IHZlcnNpb24uDQo+IA0KPj4gKw0KPj4gKyBpZiAoIEFDUElfU1VDQ0VTUyhzdGF0dXMpICkN
Cj4+ICsgew0KPj4gKyBpbnQgaTsNCj4gDQo+IFBsZWFzZSB1c2UgdW5zaWduZWQgaW50Lg0KQWNr
Lg0KPiANCj4+ICsgc3RydWN0IGFjcGlfaW9ydF9ub2RlICpub2RlLCAqZW5kOw0KPiANCj4gQ29k
aW5nIHN0eWxlOiBQbGVhc2UgYWRkIGEgbmV3bGluZS4NCg0KQWNrLiANCj4gDQo+PiArIG5vZGUg
PSBBQ1BJX0FERF9QVFIoc3RydWN0IGFjcGlfaW9ydF9ub2RlLCBpb3J0LCBpb3J0LT5ub2RlX29m
ZnNldCk7DQo+PiArIGVuZCA9IEFDUElfQUREX1BUUihzdHJ1Y3QgYWNwaV9pb3J0X25vZGUsIGlv
cnQsIGlvcnQtPmhlYWRlci5sZW5ndGgpOw0KPj4gKw0KPj4gKyBmb3IgKCBpID0gMDsgaSA8IGlv
cnQtPm5vZGVfY291bnQ7IGkrKyApDQo+PiArIHsNCj4+ICsgaWYgKCBub2RlID49IGVuZCApDQo+
IA0KPiBXb3VsZG4ndCB0aGlzIG9ubHkgaGFwcGVuIGlmIHRoZSB0YWJsZSBpcyBzb21laG93IGNv
cnJ1cHRlZD8gSWYgc28sIEkgdGhpbmsgd2Ugc2hvdWxkIHByaW50IGFuIGVycm9yIChvciBldmVu
IHBhbmljKS4NCg0KT2suDQo+IA0KPj4gKyBicmVhazsNCj4+ICsNCj4+ICsgc3dpdGNoICggbm9k
ZS0+dHlwZSApDQo+PiArIHsNCj4+ICsgY2FzZSBBQ1BJX0lPUlRfTk9ERV9TTU1VX1YzOg0KPiAN
Cj4gQ29kaW5nIHN0eWxlOiBUaGUga2V5d29yZCAiY2FzZSIgc2hvdWxkIGJlIGFsaWduZWQgdGhl
IHRoZSBzdGFydCBvZiB0aGUga2V5d29yZCAic3dpdGNo4oCdLg0KQWNrLiANCj4gDQo+PiArIHsN
Cj4+ICsgc3RydWN0IGFjcGlfaW9ydF9zbW11X3YzICpzbW11Ow0KPiANCj4gQ29kaW5nIHN0eWxl
OiBOZXdsaW5lLg0KDQpBY2suIA0KPj4gKyBzbW11ID0gKHN0cnVjdCBhY3BpX2lvcnRfc21tdV92
MyAqKW5vZGUtPm5vZGVfZGF0YTsNCj4+ICsgbWZuID0gcGFkZHJfdG9fcGZuKHNtbXUtPmJhc2Vf
YWRkcmVzcyk7DQo+PiArIHJjID0gaW9tZW1fZGVueV9hY2Nlc3MoZCwgbWZuLCBtZm4gKyBQRk5f
VVAoU1pfMTI4SykpOw0KPj4gKyBpZiAoIHJjICkNCj4+ICsgcHJpbnRrKCJpb21lbV9kZW55X2Fj
Y2VzcyBmYWlsZWQgZm9yIFNNTVV2M1xuIik7DQo+PiArIG5vZGUtPnR5cGUgPSAweGZmOw0KPiAN
Cj4gJ25vZGUnIHBvaW50cyB0byB0aGUgWGVuIGNvcHkgb2YgdGhlIEFDUEkgdGFibGUuIFdlIHNo
b3VsZCByZWFsbHkgbm90IHRvdWNoIHRoaXMgY29weS4gSW5zdGVhZCwgd2Ugc2hvdWxkIG1vZGlm
eSB0aGUgdmVyc2lvbiB0aGF0IHdpbGwgYmUgdXNlZCBieSBkb20wLg0KDQpBcyBvZiBub3cgSU9S
VCBpcyB1bnRvdWNoZWQgYnkgWGVuIGFuZCBtYXBwZWQgdG8gZG9tMC4gSSB3aWxsIGNyZWF0ZSB0
aGUgSU9SVCB0YWJsZSBmb3IgZG9tMCBhbmQgbW9kaWZ5IHRoZSBub2RlIFNNTVV2MyB0aGF0IHdp
bGwgYmUgdXNlZCBieSBkb20wLg0KPiANCj4gRnVydGhlcm1vcmUsIGlmIHdlIGdvIGRvd24gdGhl
IHJvYWQgdG8gdXBkYXRlIG5vZGUtPnR5cGUsIHdlIHNob3VsZCAwIHRoZSBub2RlIHRvIGF2b2lk
IGxlYWtpbmcgdGhlIGluZm9ybWF0aW9uIHRvIGRvbTAuDQoNCkkgYW0gbm90IHN1cmUgaWYgd2Ug
Y2FuIHplcm8gdGhlIG5vZGUsIGxldCBtZSBjaGVjayBhbmQgY29tZSBiYWNrIHRvIHlvdS4gDQo+
IA0KPj4gKyBicmVhazsNCj4+ICsgfQ0KPj4gKyB9DQo+PiArIG5vZGUgPSBBQ1BJX0FERF9QVFIo
c3RydWN0IGFjcGlfaW9ydF9ub2RlLCBub2RlLCBub2RlLT5sZW5ndGgpOw0KPj4gKyB9DQo+PiAr
IH0NCj4+ICsgZWxzZQ0KPj4gKyB7DQo+PiArIHByaW50aygiRmFpbGVkIHRvIGdldCBJT1JUIHRh
YmxlXG4iKTsNCj4+ICsgcmV0dXJuIC1FSU5WQUw7DQo+PiArIH0NCj4gDQo+IFRoZSBJT1JUIGlz
IG5vdCB5ZXQgcGFyc2VkIGJ5IFhlbiBhbmQgQUZBSUsgaXMgb3B0aW9uYWwuIFNvIEkgZG9uJ3Qg
dGhpbmsgd2Ugc2hvdWxkIHJldHVybiBhbiBlcnJvci4NCg0KQWNrLiANCg0KUmVnYXJkcywNClJh
aHVsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 18:20:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 18:20:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317628.537046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkVEM-0004dR-Im; Fri, 29 Apr 2022 18:20:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317628.537046; Fri, 29 Apr 2022 18:20:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkVEM-0004dK-FR; Fri, 29 Apr 2022 18:20:38 +0000
Received: by outflank-mailman (input) for mailman id 317628;
 Fri, 29 Apr 2022 18:20:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=930Y=VH=kernel.org=maz@srs-se1.protection.inumbo.net>)
 id 1nkVEK-0004ct-JX
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 18:20:36 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0fb808e5-c7e9-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 20:20:35 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id DB7C1B8376C;
 Fri, 29 Apr 2022 18:20:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C6C7C385A7;
 Fri, 29 Apr 2022 18:20:32 +0000 (UTC)
Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org)
 by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <maz@kernel.org>)
 id 1nkVED-0080Zl-Vn; Fri, 29 Apr 2022 19:20:30 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fb808e5-c7e9-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651256432;
	bh=7UlwWJyNgO5O8HAPQY4CevoguxGtN71USDYsxCC4Y1I=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=u0+tCCPLMcAPDoyXRHMoixV/Z0LeuwRRZuVV6YJqDPXCMAyu6bp1HqrLhdZjG9Cyh
	 QYJFW5R7kiAcrSezRCwm7ENodSCUhCJjtpqzm8cd/HFpkS4sMGegRRQASH5n2SihkJ
	 71HJ1xTMFivjTVqgd4DPNTs7LM6lfZnZ8DzEzNE0oyYqPlKCdTvIv23u3eGTMBYaOt
	 2wiCePOny8nv8PLW7e+Nz32vtmsDfQhUnorB1/3LgjVu9HRSU6K6LoPIEjrMtXRAwq
	 gSkSxWg9xur9RU7CW+BnHL/qWaY7Tt1AlSEuqbaVhcTiKCDIrzlj5v67mhP4+8Bla0
	 PK6vOCY0vQL6g==
Date: Fri, 29 Apr 2022 19:20:29 +0100
Message-ID: <87mtg392fm.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	coresight@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path
In-Reply-To: <20220427224924.592546-3-gpiccoli@igalia.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
	<20220427224924.592546-3-gpiccoli@igalia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: gpiccoli@igalia.com, akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbe
 t@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, linux@armlinux.org.uk
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Wed, 27 Apr 2022 23:48:56 +0100,
"Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:
> 
> Currently the regular CPU shutdown path for ARM disables IRQs/FIQs
> in the secondary CPUs - smp_send_stop() calls ipi_cpu_stop(), which
> is responsible for that. This makes sense, since we're turning off
> such CPUs, putting them in an endless busy-wait loop.
> 
> Problem is that there is an alternative path for disabling CPUs,
> in the form of function crash_smp_send_stop(), used for kexec/panic
> paths. This functions relies in a SMP call that also triggers a
> busy-wait loop [at machine_crash_nonpanic_core()], but *without*
> disabling interrupts. This might lead to odd scenarios, like early
> interrupts in the boot of kexec'd kernel or even interrupts in
> other CPUs while the main one still works in the panic path and
> assumes all secondary CPUs are (really!) off.
> 
> This patch mimics the ipi_cpu_stop() interrupt disable mechanism
> in the crash CPU shutdown path, hence disabling IRQs/FIQs in all
> secondary CPUs in the kexec/panic path as well.
> 
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>  arch/arm/kernel/machine_kexec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index f567032a09c0..ef788ee00519 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -86,6 +86,9 @@ void machine_crash_nonpanic_core(void *unused)
>  	set_cpu_online(smp_processor_id(), false);
>  	atomic_dec(&waiting_for_crash_ipi);
>  
> +	local_fiq_disable();
> +	local_irq_disable();
> +

My expectations would be that, since we're getting here using an IPI,
interrupts are already masked. So what reenabled them the first place?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 18:30:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 18:30:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317635.537056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkVNM-0005Nm-Fu; Fri, 29 Apr 2022 18:29:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317635.537056; Fri, 29 Apr 2022 18:29:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkVNM-0005Nf-Cz; Fri, 29 Apr 2022 18:29:56 +0000
Received: by outflank-mailman (input) for mailman id 317635;
 Fri, 29 Apr 2022 18:29:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkVNL-0005NV-GU; Fri, 29 Apr 2022 18:29:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkVNL-0006PZ-Ew; Fri, 29 Apr 2022 18:29:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkVNL-00055f-3r; Fri, 29 Apr 2022 18:29:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkVNL-00040Q-3S; Fri, 29 Apr 2022 18:29:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qDd1kAzoddZEzi8nrfbat1vlqUcVukn5qM2Pp660ueg=; b=sBnUWyMNEwVjABTkD6ifxXcaNC
	Zz0nxj4YsoULfUFlCEk8ji2+mux6xa+7Haexvfc3XzqUhv8hunoaFtzfOI0bHZ7KRm/0Ua/Go4rMA
	tq/IWuQ5psG62Th8ORMkAbBPWFEWmevvspOdf/Ka1uxam+RBKMBcTCv/xDZl343R2kHk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169878-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169878: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 18:29:55 +0000

flight 169878 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169878/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  699 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 18:48:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 18:48:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317643.537067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkVel-0007kS-R8; Fri, 29 Apr 2022 18:47:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317643.537067; Fri, 29 Apr 2022 18:47:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkVel-0007kL-OK; Fri, 29 Apr 2022 18:47:55 +0000
Received: by outflank-mailman (input) for mailman id 317643;
 Fri, 29 Apr 2022 18:47:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5Ilx=VH=linux.ibm.com=hca@srs-se1.protection.inumbo.net>)
 id 1nkVej-0007kF-GB
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 18:47:53 +0000
Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com
 [148.163.158.5]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id de1adc90-c7ec-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 20:47:50 +0200 (CEST)
Received: from pps.filterd (m0098419.ppops.net [127.0.0.1])
 by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23TIhYbi008240;
 Fri, 29 Apr 2022 18:46:47 GMT
Received: from pps.reinject (localhost [127.0.0.1])
 by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3frnhvg21h-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 29 Apr 2022 18:46:47 +0000
Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1])
 by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 23TIjCZm012916;
 Fri, 29 Apr 2022 18:46:46 GMT
Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com
 [159.122.73.71])
 by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3frnhvg20t-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 29 Apr 2022 18:46:45 +0000
Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1])
 by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23TIcqwO026358;
 Fri, 29 Apr 2022 18:46:43 GMT
Received: from b06cxnps3074.portsmouth.uk.ibm.com
 (d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
 by ppma02fra.de.ibm.com with ESMTP id 3fpuygbgfw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 29 Apr 2022 18:46:43 +0000
Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com
 [9.149.105.59])
 by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
 23TIkenH33554928
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Apr 2022 18:46:40 GMT
Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id 153A4A4057;
 Fri, 29 Apr 2022 18:46:40 +0000 (GMT)
Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id EA594A4053;
 Fri, 29 Apr 2022 18:46:37 +0000 (GMT)
Received: from osiris (unknown [9.145.187.229])
 by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS;
 Fri, 29 Apr 2022 18:46:37 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de1adc90-c7ec-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc :
 subject : message-id : references : mime-version : content-type :
 in-reply-to; s=pp1; bh=CmQcpniDwe+mXgnPI+CYX47gDa+lF4VP2K5Tb10PSgo=;
 b=bTNrOnkDXh09pnCHUKCfVTj5O7a2rMkLSO1DAFMikxnzlOk842BnVGNnlxjbavr8wxSm
 aOP4oPacZVwhk2+nACPTWiDhwPxyd0jlejF5h74fWWI1oIVsbhF16gpgLRcULgtREdDE
 ZVJN5BEU2k3dT7ownrQWfbB7t+hMkUYaYJeBX/g91k8XSQa3Vre/7LGhk8wcXzDf1kiv
 oQ2iUNVOdBVbKDS9SyEcnVmbm4ZhnqmtglnqQQ9AIucI/CNGWOo+s+8TbDE7Hi7pEpcO
 DHP4bZPnfDn7+LocgB0sqZLpX0rqcpBhSBx8Sg3u1bbgRievtyCZGncSkoY2WOU7WhmC jw== 
Date: Fri, 29 Apr 2022 20:46:36 +0200
From: Heiko Carstens <hca@linux.ibm.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
        kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org,
        linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
        linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org,
        linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
        netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net,
        rcu@vger.kernel.org, sparclinux@vger.kernel.org,
        xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com,
        kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com,
        alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com,
        arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com,
        dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com,
        gregkh@linuxfoundation.org, mikelley@microsoft.com,
        hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
        john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
        mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
        peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
        stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
        vkuznets@redhat.com, will@kernel.org,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH 13/30] s390/consoles: Improve panic notifiers reliability
Message-ID: <YmwyjMtT7QTZiHaa@osiris>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-14-gpiccoli@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220427224924.592546-14-gpiccoli@igalia.com>
X-TM-AS-GCONF: 00
X-Proofpoint-GUID: ot_aQO11mG-F1A04tqv6Sk5P4k7ltRIu
X-Proofpoint-ORIG-GUID: vOdOmdbQUdbprpYu7qwc87i31NSF1LbM
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-29_09,2022-04-28_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=368 impostorscore=0 clxscore=1011
 spamscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204290095

On Wed, Apr 27, 2022 at 07:49:07PM -0300, Guilherme G. Piccoli wrote:
> Currently many console drivers for s390 rely on panic/reboot notifiers
> to invoke callbacks on these events. The panic() function disables local
> IRQs, secondary CPUs and preemption, so callbacks invoked on panic are
> effectively running in atomic context.
> 
> Happens that most of these console callbacks from s390 doesn't take the
> proper care with regards to atomic context, like taking spinlocks that
> might be taken in other function/CPU and hence will cause a lockup
> situation.
> 
> The goal for this patch is to improve the notifiers reliability, acting
> on 4 console drivers, as detailed below:
> 
> (1) con3215: changed a regular spinlock to the trylock alternative.
> 
> (2) con3270: also changed a regular spinlock to its trylock counterpart,
> but here we also have another problem: raw3270_activate_view() takes a
> different spinlock. So, we worked a helper to validate if this other lock
> is safe to acquire, and if so, raw3270_activate_view() should be safe.
> 
> Notice though that there is a functional change here: it's now possible
> to continue the notifier code [reaching con3270_wait_write() and
> con3270_rebuild_update()] without executing raw3270_activate_view().
> 
> (3) sclp: a global lock is used heavily in the functions called from
> the notifier, so we added a check here - if the lock is taken already,
> we just bail-out, preventing the lockup.
> 
> (4) sclp_vt220: same as (3), a lock validation was added to prevent the
> potential lockup problem.
> 
> Besides (1)-(4), we also removed useless void functions, adding the
> code called from the notifier inside its own body, and changed the
> priority of such notifiers to execute late, since they are "heavyweight"
> for the panic environment, so we aim to reduce risks here.
> Changed return values to NOTIFY_DONE as well, the standard one.
> 
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
> 
> As a design choice, the option used here to verify a given spinlock is taken
> was the function "spin_is_locked()" - but we noticed that it is not often used.
> An alternative would to take the lock with a spin_trylock() and if it succeeds,
> just release the spinlock and continue the code. But that seemed weird...
> 
> Also, we'd like to ask a good validation of case (2) potential functionality
> change from the s390 console experts - far from expert here, and in our naive
> code observation, that seems fine, but that analysis might be missing some
> corner case.
> 
> Thanks in advance!
> 
>  drivers/s390/char/con3215.c    | 36 +++++++++++++++--------------
>  drivers/s390/char/con3270.c    | 34 +++++++++++++++------------
>  drivers/s390/char/raw3270.c    | 18 +++++++++++++++
>  drivers/s390/char/raw3270.h    |  1 +
>  drivers/s390/char/sclp_con.c   | 28 +++++++++++++----------
>  drivers/s390/char/sclp_vt220.c | 42 +++++++++++++++++++---------------
>  6 files changed, 96 insertions(+), 63 deletions(-)

Code looks good, and everything still seems to work. I applied this
internally for the time being, and if it passes testing, I'll schedule
it for the next merge window.

Thanks!


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 19:14:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 19:14:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317649.537079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkW4b-0002gC-0Y; Fri, 29 Apr 2022 19:14:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317649.537079; Fri, 29 Apr 2022 19:14:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkW4a-0002g4-So; Fri, 29 Apr 2022 19:14:36 +0000
Received: by outflank-mailman (input) for mailman id 317649;
 Fri, 29 Apr 2022 19:14:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkW4Z-0002fu-Up; Fri, 29 Apr 2022 19:14:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkW4Z-0007Cv-T7; Fri, 29 Apr 2022 19:14:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkW4Z-0006jI-IS; Fri, 29 Apr 2022 19:14:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkW4Z-0008V9-I0; Fri, 29 Apr 2022 19:14:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sYnyXz6ZTIu+JRrLScy1J8DZkePZFsYV1/jj1BP12fQ=; b=6+rVRVyBSusycVxtAbiU873tOf
	HBiys7Ma5hRve9g+chHXVYtM3J8ykIxo/lWM5shCr2AEDoXNrp6gbkka83uWrJR22+YsNWpgx4Kdn
	PuyMafmrlijDETbtjPwmCMusASGid9Xj/nrjb2jhKL0z1z3YOnaiBd5gO0LJjRJaeWUw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169879-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169879: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 19:14:35 +0000

flight 169879 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169879/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  700 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   21 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 19:32:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 19:32:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317658.537090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkWLU-00055w-Jd; Fri, 29 Apr 2022 19:32:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317658.537090; Fri, 29 Apr 2022 19:32:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkWLU-00055p-G5; Fri, 29 Apr 2022 19:32:04 +0000
Received: by outflank-mailman (input) for mailman id 317658;
 Fri, 29 Apr 2022 19:32:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkWLS-00055j-6O
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 19:32:03 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 09a92712-c7f3-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 21:32:00 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkWKu-000A9h-7O; Fri, 29 Apr 2022 21:31:28 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09a92712-c7f3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=juYOl8ucSjuSHKXBe+1Ir5OPZr6pZdgx66h4OReE1Ko=; b=pi8CeEHRcdz9D2M05lfyhONNOe
	Il5P/FNtKNDpfNnQvQkUO53LGYEhZ3HsOKcMT79tXUkEM7BDaPWYeiTRxruHlFJpgYZGLdkNZ+Vsx
	oyZivn3CQn+HYfOJsn02OXmy5/HYryfVse/FM/IqF31FwAMG26clpYwK7OV3zBWRhtbMoUne9k8x/
	cgyBslKy2FDshbzCm4dWwDcEIOqWM+BTXUAPCGsxBvDFlTKuVtiafdc18oTYk2LsBlxeiWqHf76sU
	fr20/x47wOCPaQYIMtyh+VGeHVXZk4bWHmVx7ebZUj8zme4Hs0U5M9F5U1lcdb0DAeivSR+YRjiw8
	sBGOVwOQ==;
Message-ID: <039cdf14-efc5-383b-3f3d-294a5ed9243e@igalia.com>
Date: Fri, 29 Apr 2022 16:31:00 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 13/30] s390/consoles: Improve panic notifiers reliability
Content-Language: en-US
To: Heiko Carstens <hca@linux.ibm.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
 kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
 bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
 linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org,
 linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
 netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net,
 rcu@vger.kernel.org, sparclinux@vger.kernel.org,
 xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com,
 kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com,
 alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com,
 arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com,
 dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com,
 gregkh@linuxfoundation.org, mikelley@microsoft.com,
 hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de,
 keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org,
 mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org,
 rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu,
 tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org,
 Alexander Gordeev <agordeev@linux.ibm.com>,
 Christian Borntraeger <borntraeger@linux.ibm.com>,
 Sven Schnelle <svens@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-14-gpiccoli@igalia.com> <YmwyjMtT7QTZiHaa@osiris>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <YmwyjMtT7QTZiHaa@osiris>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/04/2022 15:46, Heiko Carstens wrote:
> [...]
> 
> Code looks good, and everything still seems to work. I applied this
> internally for the time being, and if it passes testing, I'll schedule
> it for the next merge window.
> 
> Thanks!

Perfect Heiko, thanks a bunch for your review and tests!
Let me know if anything breaks heh
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 19:35:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 19:35:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317668.537101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkWOt-0005hB-3i; Fri, 29 Apr 2022 19:35:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317668.537101; Fri, 29 Apr 2022 19:35:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkWOs-0005h4-Vf; Fri, 29 Apr 2022 19:35:34 +0000
Received: by outflank-mailman (input) for mailman id 317668;
 Fri, 29 Apr 2022 19:35:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkWOr-0005gy-9i
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 19:35:33 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 88118ffb-c7f3-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 21:35:32 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkWOO-000AEq-R6; Fri, 29 Apr 2022 21:35:05 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88118ffb-c7f3-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=lwmIjCyQy1cvf/HfruQUsqg2HO2zLsQJj36FVBjRlMY=; b=FMeK+qaOrNt+CW3KPA3fG+Sm88
	9dOTCLRIKwFZQHJ+4m/FuvGgtzWqdtsbg7jNNtnRqzh6mH5yhN/kcNgqlSXGFzr+Is403C8lKfeIe
	GFE0d2xZtQSLJr4I8RU79yspLu2jmEMkBcLB9rf7ILb4vrthTaqCp6aHTQGFnReVgkS13mVrLfnHx
	HX+CWHd9YGmcd+hSxhVaiC1N67Jxo0tAWbskOVNhQbgFNnliiB3BK9xH4rhhSehlShKQIEHmaxjCC
	oWiRKIIVo1UNa1pRoT5oqrZz7cmRkXzPYEYIQdMbmHXt76jbfgPiC/AOizH1U1QXiwvnp20pJNRvp
	Fw18KdiA==;
Message-ID: <5af45ed0-7b0a-5664-a9d3-c53ea001a35e@igalia.com>
Date: Fri, 29 Apr 2022 16:34:23 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list
Content-Language: en-US
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, bhe@redhat.com,
 Petr Mladek <pmladek@suse.com>, kexec@lists.infradead.org,
 LKML <linux-kernel@vger.kernel.org>, bcm-kernel-feedback-list@broadcom.com,
 linuxppc-dev@lists.ozlabs.org,
 "open list:ALPHA PORT" <linux-alpha@vger.kernel.org>,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 "open list:PARISC ARCHITECTURE" <linux-parisc@vger.kernel.org>,
 linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
 linux-s390 <linux-s390@vger.kernel.org>, linux-tegra@vger.kernel.org,
 linux-um@lists.infradead.org,
 "open list:TENSILICA XTENSA PORT (xtensa)" <linux-xtensa@linux-xtensa.org>,
 netdev <netdev@vger.kernel.org>, openipmi-developer@lists.sourceforge.net,
 rcu@vger.kernel.org,
 "open list:SPARC + UltraSPAR..." <sparclinux@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 "maintainer:X86 ARCHITECTURE..." <x86@kernel.org>, kernel-dev@igalia.com,
 kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com,
 alejandro.j.jimenez@oracle.com,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Arnd Bergmann <arnd@arndb.de>, Borislav Petkov <bp@alien8.de>,
 Jonathan Corbet <corbet@lwn.net>, d.hatayama@jp.fujitsu.com,
 Dave Hansen <dave.hansen@linux.intel.com>, dyoung@redhat.com,
 feng.tang@intel.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, Kees Cook <keescook@chromium.org>,
 Andrew Lutomirski <luto@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>,
 Ingo Molnar <mingo@redhat.com>, paulmck@kernel.org,
 Peter Zijlstra <peterz@infradead.org>, Steven Rostedt <rostedt@goodmis.org>,
 Sergey Senozhatsky <senozhatsky@chromium.org>, stern@rowland.harvard.edu,
 Thomas Gleixner <tglx@linutronix.de>, vgoyal@redhat.com,
 vkuznets@redhat.com, Will Deacon <will@kernel.org>,
 Alex Elder <elder@kernel.org>, Alexander Gordeev <agordeev@linux.ibm.com>,
 Anton Ivanov <anton.ivanov@cambridgegreys.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Bjorn Andersson <bjorn.andersson@linaro.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Chris Zankel
 <chris@zankel.net>, Christian Borntraeger <borntraeger@linux.ibm.com>,
 Corey Minyard <minyard@acm.org>, Dexuan Cui <decui@microsoft.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>,
 Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 James Morse <james.morse@arm.com>, Johannes Berg
 <johannes@sipsolutions.net>, "K. Y. Srinivasan" <kys@microsoft.com>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Matt Turner <mattst88@gmail.com>, Mauro Carvalho Chehab
 <mchehab@kernel.org>, Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>, Pavel Machek <pavel@ucw.cz>,
 Richard Henderson <rth@twiddle.net>, Richard Weinberger <richard@nod.at>,
 Robert Richter <rric@kernel.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Stephen Hemminger <sthemmin@microsoft.com>,
 Sven Schnelle <svens@linux.ibm.com>, Tony Luck <tony.luck@intel.com>,
 Vasily Gorbik <gor@linux.ibm.com>, Wei Liu <wei.liu@kernel.org>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-22-gpiccoli@igalia.com>
 <CAMo8BfKzA+oy-Qun9-aO3xCr4Jy_rfdjYqMX=W9xONCSX8O51Q@mail.gmail.com>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <CAMo8BfKzA+oy-Qun9-aO3xCr4Jy_rfdjYqMX=W9xONCSX8O51Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/04/2022 13:04, Max Filippov wrote:
> [...]
>>  arch/xtensa/platforms/iss/setup.c     |  4 ++--For xtensa:
> 
> For xtensa:
> Acked-by: Max Filippov <jcmvbkbc@gmail.com>
> 

Perfect, thanks Max!
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 19:38:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 19:38:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317674.537113 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkWS5-0006Ka-IZ; Fri, 29 Apr 2022 19:38:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317674.537113; Fri, 29 Apr 2022 19:38:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkWS5-0006KT-Di; Fri, 29 Apr 2022 19:38:53 +0000
Received: by outflank-mailman (input) for mailman id 317674;
 Fri, 29 Apr 2022 19:38:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkWS3-0006KN-Nn
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 19:38:51 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fde2502e-c7f3-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 21:38:50 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkWRh-000ALj-Dz; Fri, 29 Apr 2022 21:38:29 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fde2502e-c7f3-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=+2llGFga5QkASn4XVi2aetavO7ILP6dASiYzMijceyQ=; b=UOUUrMszI73hVVDlQl0qMGKpgi
	SURYnynivwToxWlxRFNHZuJUlYACg3pOlToF9uePQZKQj9Jh28x9HqFS+8ma2UKNqqfTZIoq5qPoX
	ZjKu0SXAHcAaL5fBZDxiontPvDun5f7GYgdbt4dCuiMpqF5UK3BAq1NYYAup9oZJISpA3f/6msVNv
	KxEGWm1/bKbhG1suPPcwhVBlVUZnIQWEhpqD+ct/zjPgjlzryTF/5q8gZE+Q8KVJ4Te371qBOe3Ly
	SxwsyKvT3lKFnIB4YpgxZ/QTp4/T994RncLE2AybyAnDHh154KcaeR4cHIlVzuqXykPOlGP9iLWEL
	6VZKIX4Q==;
Message-ID: <88b19a1c-7cea-9a28-3770-e235c286efed@igalia.com>
Date: Fri, 29 Apr 2022 16:38:02 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 18/30] notifier: Show function names on notifier routines
 if DEBUG_NOTIFIERS is set
Content-Language: en-US
To: Xiaoming Ni <nixiaoming@huawei.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org,
 Arjan van de Ven <arjan@linux.intel.com>,
 Cong Wang <xiyou.wangcong@gmail.com>,
 Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
 Valentin Schneider <valentin.schneider@arm.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-19-gpiccoli@igalia.com>
 <9f44aae6-ec00-7ede-ec19-6e67ceb74510@huawei.com>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <9f44aae6-ec00-7ede-ec19-6e67ceb74510@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 27/04/2022 22:01, Xiaoming Ni wrote:
> [...]
> Duplicate Code.
> 
> Is it better to use __func__ and %pS?
> 
> pr_info("%s: %pS\n", __func__, n->notifier_call);
> 
> 

This is a great suggestion Xiaoming, much appreciated!
I feel like reinventing the wheel here - with your idea, code was super
clear and concise, very nice suggestion!!

The only 2 things that diverge from your idea: I'm using '%ps' (not
showing offsets) and also, kept the wording "(un)registered/calling",
not using __func__ - I feel it's a bit odd in the output.
OK for you?

I'm definitely using your idea in V2 heh
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:26:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:26:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317686.537129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXC9-00031m-4h; Fri, 29 Apr 2022 20:26:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317686.537129; Fri, 29 Apr 2022 20:26:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXC9-00031f-07; Fri, 29 Apr 2022 20:26:29 +0000
Received: by outflank-mailman (input) for mailman id 317686;
 Fri, 29 Apr 2022 20:26:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkXC8-00031V-93; Fri, 29 Apr 2022 20:26:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkXC8-00005C-41; Fri, 29 Apr 2022 20:26:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkXC7-0008TS-Sz; Fri, 29 Apr 2022 20:26:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkXC7-0004PZ-SY; Fri, 29 Apr 2022 20:26:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9UDXE/dzMc83/ReWgZqhTk6ON+oCrbpmUBXMB3eRksU=; b=Y7b+86fVz8ROXsm3P356L5zKkk
	OmXOya7Cx8Wvp2ydjo0R+g6K+Hu8/dyWl6iNwo3+HwYJ/UAqb2i4iviBRpJRlkeolkyD9qoEQ/zxI
	NuM8Hz0e4lSjZoVK1XNLUqTmbjvGoHK3YmAKRiXm/ksWZ/REZJTgTeR/baw+0Jh+7vJ8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169880-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169880: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 20:26:27 +0000

flight 169880 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169880/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  701 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   22 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:39:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:39:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317694.537140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXOe-0004WD-AS; Fri, 29 Apr 2022 20:39:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317694.537140; Fri, 29 Apr 2022 20:39:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXOe-0004W6-6k; Fri, 29 Apr 2022 20:39:24 +0000
Received: by outflank-mailman (input) for mailman id 317694;
 Fri, 29 Apr 2022 20:39:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkXOa-0004W0-AR
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:39:23 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7048cb39-c7fc-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 22:39:17 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkXNs-000CEn-5h; Fri, 29 Apr 2022 22:38:36 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7048cb39-c7fc-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=9LhFYA+MjEc96AcZxxeEKFjkU9Lk82GaxnYYVWnVk68=; b=XwGE93aX+1E0t3pByj3j/O+5Ga
	K3u/NbvWUIPTGWXFFUF5/S8bghnnop1aApPsPGKNCX+XA1bvvH3EQ0PcLpFJhLHgKjy3gTmHDpRZx
	xpeiw9TV1dPXB2YSqRvo3agu2ikjDsTWOdpgS/WgDbAttd/ff7K6VJQNlrO38xJTdLOWq3LaiPpb7
	BCxPsp9BBfFRjEJDD6TJuu/Y8uUcnXFJiNLt6QIOyD0DFBtRwQdBNCscMgnx+i0qVThLJVg3KcgFz
	9afxev7tVqQLuY2Z0izXtjt9I1wawTaSR9Ugp7AvNWX4ugYt89qxijRM6XzCj5d2MXRHOn6SprLRr
	LWTDMVqw==;
Message-ID: <50178dfb-8e94-f35f-09c3-22fe197550ef@igalia.com>
Date: Fri, 29 Apr 2022 17:38:08 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 24/30] panic: Refactor the panic path
Content-Language: en-US
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
 "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
 "bhe@redhat.com" <bhe@redhat.com>, "pmladek@suse.com" <pmladek@suse.com>,
 "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "bcm-kernel-feedback-list@broadcom.com"
 <bcm-kernel-feedback-list@broadcom.com>,
 "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
 "linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
 "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
 "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
 "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
 "linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
 "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
 "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
 "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
 "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
 "linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
 "linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 "openipmi-developer@lists.sourceforge.net"
 <openipmi-developer@lists.sourceforge.net>,
 "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
 "sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "x86@kernel.org" <x86@kernel.org>,
 "kernel-dev@igalia.com" <kernel-dev@igalia.com>,
 "kernel@gpiccoli.net" <kernel@gpiccoli.net>,
 "halves@canonical.com" <halves@canonical.com>,
 "fabiomirmar@gmail.com" <fabiomirmar@gmail.com>,
 "alejandro.j.jimenez@oracle.com" <alejandro.j.jimenez@oracle.com>,
 "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
 "arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
 "corbet@lwn.net" <corbet@lwn.net>,
 "d.hatayama@jp.fujitsu.com" <d.hatayama@jp.fujitsu.com>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 "dyoung@redhat.com" <dyoung@redhat.com>,
 "feng.tang@intel.com" <feng.tang@intel.com>,
 "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
 "hidehiro.kawai.ez@hitachi.com" <hidehiro.kawai.ez@hitachi.com>,
 "jgross@suse.com" <jgross@suse.com>,
 "john.ogness@linutronix.de" <john.ogness@linutronix.de>,
 "keescook@chromium.org" <keescook@chromium.org>,
 "luto@kernel.org" <luto@kernel.org>,
 "mhiramat@kernel.org" <mhiramat@kernel.org>,
 "mingo@redhat.com" <mingo@redhat.com>,
 "paulmck@kernel.org" <paulmck@kernel.org>,
 "peterz@infradead.org" <peterz@infradead.org>,
 "rostedt@goodmis.org" <rostedt@goodmis.org>,
 "senozhatsky@chromium.org" <senozhatsky@chromium.org>,
 "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
 "tglx@linutronix.de" <tglx@linutronix.de>,
 "vgoyal@redhat.com" <vgoyal@redhat.com>, vkuznets <vkuznets@redhat.com>,
 "will@kernel.org" <will@kernel.org>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-25-gpiccoli@igalia.com>
 <PH0PR21MB30252C55EB4F97F3D78021BDD7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <PH0PR21MB30252C55EB4F97F3D78021BDD7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/04/2022 14:53, Michael Kelley (LINUX) wrote:
> From: Guilherme G. Piccoli <gpiccoli@igalia.com> Sent: Wednesday, April 27, 2022 3:49 PM
>> [...]
>> +	panic_notifiers_level=
>> +			[KNL] Set the panic notifiers execution order.
>> +			Format: <unsigned int>
>> +			We currently have 4 lists of panic notifiers; based
>> +			on the functionality and risk (for panic success) the
>> +			callbacks are added in a given list. The lists are:
>> +			- hypervisor/FW notification list (low risk);
>> +			- informational list (low/medium risk);
>> +			- pre_reboot list (higher risk);
>> +			- post_reboot list (only run late in panic and after
>> +			kdump, not configurable for now).
>> +			This parameter defines the ordering of the first 3
>> +			lists with regards to kdump; the levels determine
>> +			which set of notifiers execute before kdump. The
>> +			accepted levels are:
>> +			0: kdump is the first thing to run, NO list is
>> +			executed before kdump.
>> +			1: only the hypervisor list is executed before kdump.
>> +			2 (default level): the hypervisor list and (*if*
>> +			there's any kmsg_dumper defined) the informational
>> +			list are executed before kdump.
>> +			3: both the hypervisor and the informational lists
>> +			(always) execute before kdump.
> 
> I'm not clear on why level 2 exists.  What is the scenario where
> execution of the info list before kdump should be conditional on the
> existence of a kmsg_dumper?   Maybe the scenario is described
> somewhere in the patch set and I just missed it.
> 

Hi Michael, thanks for your review/consideration. So, this idea started
kind of some time ago. It all started with a need of exposing more
information on kernel log *before* kdump and *before* pstore -
specifically, we're talking about panic_print. But this cause some
reactions, Baoquan was very concerned with that [0]. Soon after, I've
proposed a panic notifiers filter (orthogonal) approach, to which Petr
suggested instead doing a major refactor [1] - it finally is alive in
the form of this series.

The theory behind the level 2 is to allow a scenario of kdump with the
minimum amount of notifiers - what is the point in printing more
information if the user doesn't care, since it's going to kdump? Now, if
there is a kmsg dumper, it means that there is likely some interest in
collecting information, and that might as well be required before the
potential kdump (which is my case, hence the proposal on [0]).

Instead of forcing one of the two behaviors (level 1 or level 3), we
have a middle-term/compromise: if there's interest in collecting such
data (in the form of a kmsg dumper), we then execute the informational
notifiers before kdump. If not, why to increase (even slightly) the risk
for kdump?

I'm OK in removing the level 2 if people prefer, but I don't feel it's a
burden, quite opposite - seems a good way to accommodate the somewhat
antagonistic ideas (jump to kdump ASAP vs collecting more info in the
panicked kernel log).

[0] https://lore.kernel.org/lkml/20220126052246.GC2086@MiWiFi-R3L-srv/

[1] https://lore.kernel.org/lkml/YfPxvzSzDLjO5ldp@alley/


>[...]
>> +	 * Based on the level configured (smaller than 4), we clear the
>> +	 * proper bits in "panic_notifiers_bits". Notice that this bitfield
>> +	 * is initialized with all notifiers set.
>> +	 */
>> +	switch (panic_notifiers_level) {
>> +	case 3:
>> +		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
>> +		break;
>> +	case 2:
>> +		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
>> +
>> +		if (!kmsg_has_dumpers())
>> +			clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
>> +		break;
>> +	case 1:
>> +		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
>> +		clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
>> +		break;
>> +	case 0:
>> +		clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
>> +		clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
>> +		clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits);
>> +		break;
>> +	}
> 
> I think the above switch statement could be done as follows:
> 
> if (panic_notifiers_level <= 3)
> 	clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits);
> if (panic_notifiers_level <= 2)
> 	if (!kmsg_has_dumpers())
> 		clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
> if (panic_notifiers_level <=1)
> 	clear_bit(PN_INFO_BIT, &panic_notifiers_bits);
> if (panic_notifiers_level == 0)
> 	clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits);
> 
> That's about half the lines of code.  It's somewhat a matter of style,
> so treat this as just a suggestion to consider.  I just end up looking
> for a better solution when I see the same line of code repeated
> 3 or 4 times!
> 

It's a good idea - I liked your code. The switch seems more
natural/explicit for me, even duplicating some lines, but in case more
people prefer your way, I can definitely change the code - thanks for
the suggestion.
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:57:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:57:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317701.537151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXg6-0006wD-Tb; Fri, 29 Apr 2022 20:57:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317701.537151; Fri, 29 Apr 2022 20:57:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXg6-0006w6-QW; Fri, 29 Apr 2022 20:57:26 +0000
Received: by outflank-mailman (input) for mailman id 317701;
 Fri, 29 Apr 2022 20:57:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXg4-0006w0-PK
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:57:24 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7a3d077-c7fe-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 22:57:23 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A2511B837C2;
 Fri, 29 Apr 2022 20:57:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D33EC385A7;
 Fri, 29 Apr 2022 20:57:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7a3d077-c7fe-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651265841;
	bh=PLq+6PDPp1BOsHws04vd9QA2FOt1CAQN/nNG1+129tM=;
	h=Date:From:To:cc:Subject:From;
	b=XOY/I975F0X0B/7jqfKnmPVe3eE0vk/+7B2oDI9+5TTO39sYy5LLf7qXOYuKvWiCG
	 Ai7eje6yDWHZ0BRwr/NhZv2twJISRHlbaCC5lHabN3FxI75ioBl0XRU41p4SMuiu6w
	 B6x52mlIz0z90oFxla0DC9UPMBRN2gezF1MAQYHAVrZ42zcggnbry9qXfwn22Nn/QD
	 hbPygArg7R62k15WBnz68EFeSNgU6UADRMk9fmspbVAieBen5sq7MKyfmWKqvWaMGB
	 2XChT1onzQWW2l00OzeVdMyyS6o1pdmMOZeFLAxyqZb9ehmTSYNIr+rHc5jVWEMrU0
	 GTiKjLF/E3WCQ==
Date: Fri, 29 Apr 2022 13:57:20 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, 
    julien@xen.org, Volodymyr_Babchuk@epam.com
Subject: [PATCH v5 0/7] dom0less PV drivers
Message-ID: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi all,

Currently dom0less guests cannot use PV drivers because they don't have
access to xenstore. Also, the hypervisor node in device tree is missing
so they don't detect that they are running on Xen (thus, they don't try
to enable PV interfaces.)

This patch series enables dom0less guests (on ARM) to use PV drivers.

Instead of initializing xenstore immediately at boot, dom0less guests
get access to xenstore later. They delay the initialization until they
receive a notification via the xenstore event channel (which is
available at boot.)

An example workflow is as follows:
- all domains start in parallel, dom0less guests are immediately running
- when dom0 is up and running, the init-dom0less application is called
- dom0less guests receive the notification and initialize xenstore
- now xl network-attach/disk-attach works as expected for dom0less domUs

The patch series introduces a new dom0less device tree option
"xen,enhanced" (in the Xen device tree) to specify whether PV interfaces
should be enabled/disabled for the dom0less guest.

This patch series is based on Daniel P. Smith's "Adds starting the idle
domain privileged".

A important change in v5 is the usage of
XS_CONNECTION_STATE_RECONNECTING to signal that the xenstore interface
is not ready.

Cheers,

Stefano

Luca Miccio (3):
      xen/arm: configure dom0less domain for enabling xenstore after boot
      xenstored: send an evtchn notification on introduce_domain
      tools: add example application to initialize dom0less PV drivers

Stefano Stabellini (4):
      xen/dt: of_property_read_string return -ENODATA when !length
      xen/arm: implement domU extended regions
      xen: introduce xen,enhanced dom0less property
      docs: document dom0less + PV drivers

 docs/features/dom0less.pandoc         |  43 ++++-
 docs/misc/arm/device-tree/booting.txt |  18 ++
 tools/helpers/Makefile                |  13 ++
 tools/helpers/init-dom0less.c         | 341 ++++++++++++++++++++++++++++++++++
 tools/xenstore/xenstored_domain.c     |   4 +
 xen/arch/arm/domain_build.c           | 100 +++++++++-
 xen/arch/arm/include/asm/kernel.h     |   3 +
 xen/common/device_tree.c              |   2 +-
 xen/common/event_channel.c            |   2 +-
 xen/include/xen/device_tree.h         |   3 +
 xen/include/xen/event.h               |   3 +
 11 files changed, 519 insertions(+), 13 deletions(-)
 create mode 100644 tools/helpers/init-dom0less.c


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:57:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:57:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317702.537162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgI-0007Em-4z; Fri, 29 Apr 2022 20:57:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317702.537162; Fri, 29 Apr 2022 20:57:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgI-0007Ed-1n; Fri, 29 Apr 2022 20:57:38 +0000
Received: by outflank-mailman (input) for mailman id 317702;
 Fri, 29 Apr 2022 20:57:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXgH-0006w0-EI
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:57:37 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ff03d556-c7fe-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 22:57:36 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 11385621A2;
 Fri, 29 Apr 2022 20:57:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 176B1C385A4;
 Fri, 29 Apr 2022 20:57:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff03d556-c7fe-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651265854;
	bh=qNbBe6vmVEA5q4kiVCAEwgFL1a6sen9A+xt7fWqSkOE=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=t2mf+d5+Yl/YFI//MIfxpyddVMpFHSoViMkxkhbAmDwvfKyySCDMqzGohssrt7ivY
	 dGauxPXjx5u3tlE9B18X3/JlC3bHpAIipY+jo8jkg+OzH2nW4vDL7XlYSvHLOtkYPi
	 l5KP0rEb7gpOO+5lwJt2pYF9+3UrXtM3Oi4lR6f5c1OY3f0YDAp2tGDqt+yO8GPqgV
	 bG1s0MkVYB8DLMlfidkTNYlU1/XXdZ9FKZxQ7HLd7hd4cWuvoAwrnDvfp72Uzoem4Z
	 63+bzRRT5+/IZ3n5SrYay0iNl3kq9iNeuLz97MSjZPUgVFnHdSVmJkXCRNOCJ07O2C
	 wRlbOjpoQCUuA==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v5 1/7] xen/dt: of_property_read_string return -ENODATA when !length
Date: Fri, 29 Apr 2022 13:57:26 -0700
Message-Id: <20220429205732.2030094-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

When the length of the string is zero of_property_read_string should
return -ENODATA according to the description of the function.

However, of_property_read_string doesn't check prop->length. If
prop->length is zero, return -ENODATA.

Without this patch the following command in u-boot:

fdt set /chosen/node property-name

results in of_property_read_string returning -EILSEQ when attempting to
read property-name. With this patch, it returns -ENODATA as expected.

This commit is a backport of:
https://lore.kernel.org/xen-devel/20220416003028.1315268-1-sstabellini@kernel.org/

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
Changes in v5:
- backport from Linux, I don't have the commit id yet so I used an LKML
  link instead for now
---
 xen/common/device_tree.c      | 2 +-
 xen/include/xen/device_tree.h | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 4aae281e89..0e8798bd24 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -198,7 +198,7 @@ int dt_property_read_string(const struct dt_device_node *np,
 
     if ( !pp )
         return -EINVAL;
-    if ( !pp->value )
+    if ( !pp->length )
         return -ENODATA;
     if ( strnlen(pp->value, pp->length) >= pp->length )
         return -EILSEQ;
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index fd6cd00b43..430a1ef445 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -451,6 +451,9 @@ static inline bool_t dt_property_read_bool(const struct dt_device_node *np,
  * doest not have value, and -EILSEQ if the string is not
  * null-terminated with the length of the property data.
  *
+ * Note that the empty string "" has length of 1, thus -ENODATA cannot
+ * be interpreted as an empty string.
+ *
  * The out_string pointer is modified only if a valid string can be decoded.
  */
 int dt_property_read_string(const struct dt_device_node *np,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:57:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:57:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317703.537173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgJ-0007Vh-EQ; Fri, 29 Apr 2022 20:57:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317703.537173; Fri, 29 Apr 2022 20:57:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgJ-0007VW-Ar; Fri, 29 Apr 2022 20:57:39 +0000
Received: by outflank-mailman (input) for mailman id 317703;
 Fri, 29 Apr 2022 20:57:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXgI-0006w0-EP
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:57:38 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ff3d3a40-c7fe-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 22:57:36 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8F3BE621D7;
 Fri, 29 Apr 2022 20:57:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1047C385AE;
 Fri, 29 Apr 2022 20:57:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff3d3a40-c7fe-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651265855;
	bh=xYtT+6HeBjKFPCtYs7kjkhcpxb7ruFyZ0/KuV9mvqgI=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=VzCyC431VGEgRMAeJTo4H/YQpKqJQitqJvGPFJzWM0Nwpr2wqrcb1fuzxTRoaJk3g
	 glXXrff9lyuceNjIjfNeVYuXP4AM8+Kee00ocMsYXTV9tsX9PZPMV7yWS0Ao47TAKH
	 J/76RDLM4o8EZf8y4C8j2H0/C9yV+Nu9zokeMUhuwbsiaAkxKwQWA9neM56UeobIGS
	 30C5eRmTmrRzaN2nTj1uqg0AE8ZsAk/jj2J0S9snnSTCjtV6CNF2banTjHKEYkJIkQ
	 AHkuVrUDwus7KQ+9SDsfmEb07U8jCAUrmbPBGJ8drCi7R4Ed0vlEZm0q4oASruA1nY
	 vN9Yu1bP44d4Q==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v5 2/7] xen/arm: implement domU extended regions
Date: Fri, 29 Apr 2022 13:57:27 -0700
Message-Id: <20220429205732.2030094-2-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Implement extended regions for dom0less domUs. The implementation is
based on the libxl implementation.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
Changes in v5:
- print the domain
- coding style
- simplify the code in find_domU_holes
- return error if no regions allocated in find_domU_holes
- use ROUNDUP
- uint64_t/paddr_t
---
 xen/arch/arm/domain_build.c | 56 +++++++++++++++++++++++++++++++------
 1 file changed, 48 insertions(+), 8 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8be01678de..34d3e5ce30 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1324,6 +1324,37 @@ out:
     return res;
 }
 
+static int __init find_domU_holes(const struct kernel_info *kinfo,
+                                  struct meminfo *ext_regions)
+{
+    unsigned int i;
+    paddr_t bankend;
+    const paddr_t bankbase[] = GUEST_RAM_BANK_BASES;
+    const paddr_t banksize[] = GUEST_RAM_BANK_SIZES;
+    int res = -ENOENT;
+
+    for ( i = 0; i < GUEST_RAM_BANKS; i++ )
+    {
+        struct membank *ext_bank = &(ext_regions->bank[ext_regions->nr_banks]);
+
+        ext_bank->start = ROUNDUP(bankbase[i] + kinfo->mem.bank[i].size,
+                                  SZ_2M);
+
+        bankend = ~0ULL >> (64 - p2m_ipa_bits);
+        bankend = min(bankend, bankbase[i] + banksize[i] - 1);
+        if ( bankend > ext_bank->start )
+            ext_bank->size = bankend - ext_bank->start + 1;
+
+        /* 64MB is the minimum size of an extended region */
+        if ( ext_bank->size < MB(64) )
+            continue;
+        ext_regions->nr_banks++;
+        res = 0;
+    }
+
+    return res;
+}
+
 static int __init make_hypervisor_node(struct domain *d,
                                        const struct kernel_info *kinfo,
                                        int addrcells, int sizecells)
@@ -1360,12 +1391,13 @@ static int __init make_hypervisor_node(struct domain *d,
 
     if ( !opt_ext_regions )
     {
-        printk(XENLOG_INFO "The extended regions support is disabled\n");
+        printk(XENLOG_INFO "%pd: extended regions support is disabled\n", d);
         nr_ext_regions = 0;
     }
     else if ( is_32bit_domain(d) )
     {
-        printk(XENLOG_WARNING "The extended regions are only supported for 64-bit guest currently\n");
+        printk(XENLOG_WARNING "%pd: extended regions are only supported for 64-bit guest currently\n",
+               d);
         nr_ext_regions = 0;
     }
     else
@@ -1374,13 +1406,21 @@ static int __init make_hypervisor_node(struct domain *d,
         if ( !ext_regions )
             return -ENOMEM;
 
-        if ( !is_iommu_enabled(d) )
-            res = find_unallocated_memory(kinfo, ext_regions);
+        if ( is_domain_direct_mapped(d) )
+        {
+            if ( !is_iommu_enabled(d) )
+                res = find_unallocated_memory(kinfo, ext_regions);
+            else
+                res = find_memory_holes(kinfo, ext_regions);
+        }
         else
-            res = find_memory_holes(kinfo, ext_regions);
+        {
+            res = find_domU_holes(kinfo, ext_regions);
+        }
 
         if ( res )
-            printk(XENLOG_WARNING "Failed to allocate extended regions\n");
+            printk(XENLOG_WARNING "%pd: failed to allocate extended regions\n",
+                   d);
         nr_ext_regions = ext_regions->nr_banks;
     }
 
@@ -1401,8 +1441,8 @@ static int __init make_hypervisor_node(struct domain *d,
         u64 start = ext_regions->bank[i].start;
         u64 size = ext_regions->bank[i].size;
 
-        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
-               i, start, start + size);
+        printk("%pd: extended region %d: %#"PRIx64"->%#"PRIx64"\n",
+               d, i, start, start + size);
 
         dt_child_set_range(&cells, addrcells, sizecells, start, size);
     }
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:57:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:57:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317704.537184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgK-0007lm-P3; Fri, 29 Apr 2022 20:57:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317704.537184; Fri, 29 Apr 2022 20:57:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgK-0007lP-Kw; Fri, 29 Apr 2022 20:57:40 +0000
Received: by outflank-mailman (input) for mailman id 317704;
 Fri, 29 Apr 2022 20:57:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXgJ-0007P4-Cb
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:57:39 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0041747c-c7ff-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 22:57:38 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4DD73B83794;
 Fri, 29 Apr 2022 20:57:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5E9EC385B0;
 Fri, 29 Apr 2022 20:57:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0041747c-c7ff-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651265856;
	bh=mE2HS7cDM2V9DWF5yzqxb8sXkvTRkVIrepnZA+OkhKg=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=G4HvHg9HPiKKsbtcHa7IGELkoLHK9uN02Pbp1q123bahHC1v2EDOjAD8y1VRvK8pd
	 6A0/a7cg8Rh+bMtslA9g3G51G1lEKr/823JV+w1HIRzWqR23c8J3XNIbaIqCf8FjO1
	 28D3qS370JWOgtWaFlt3D/9FbTtxTO6gPQHFXFfG3KHhUCTB8U3sN803YsuNa1gflz
	 cHPNSjHUcBkdt3OJiRgyG1vRMbLT29nlE6C1GUp/WSfqAAVdl5fA/lSeIkzur3K+t3
	 ncvdrcAeefYBH1S763t56I9typP+lgODqFmX0yGdqvBDn3OxksKKCP4FkHQf08B7Ss
	 3ITQqIj+bJhlw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Luca Miccio <lucmiccio@gmail.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v5 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot
Date: Fri, 29 Apr 2022 13:57:29 -0700
Message-Id: <20220429205732.2030094-4-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

Export evtchn_alloc_unbound and make it __must_check.

If "xen,enhanced" is enabled, then add to dom0less domains:

- the hypervisor node in device tree
- the xenstore event channel

The xenstore event channel is also used for the first notification to
let the guest know that xenstore has become available.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Jan Beulich <jbeulich@suse.com>

---
I removed Bertrand's reviewed-by due to merging this patch with "xen:
export evtchn_alloc_unbound"

Changes in v5:
- merge with "xen: export evtchn_alloc_unbound"
- __must_check

Changes in v3:
- use evtchn_alloc_unbound

Changes in v2:
- set HVM_PARAM_STORE_PFN to ~0ULL at domain creation
- in alloc_xenstore_evtchn do not call _evtchn_alloc_unbound

xen: export evtchn_alloc_unbound

It will be used during dom0less domains construction.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 xen/arch/arm/domain_build.c | 37 +++++++++++++++++++++++++++++++++++++
 xen/common/event_channel.c  |  2 +-
 xen/include/xen/event.h     |  3 +++
 3 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index a877ccf585..249efbf804 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -27,6 +27,7 @@
 #include <asm/setup.h>
 #include <asm/cpufeature.h>
 #include <asm/domain_build.h>
+#include <xen/event.h>
 
 #include <xen/irq.h>
 #include <xen/grant_table.h>
@@ -2809,6 +2810,8 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo)
     int ret;
 
     kinfo->phandle_gic = GUEST_PHANDLE_GIC;
+    kinfo->gnttab_start = GUEST_GNTTAB_BASE;
+    kinfo->gnttab_size = GUEST_GNTTAB_SIZE;
 
     addrcells = GUEST_ROOT_ADDRESS_CELLS;
     sizecells = GUEST_ROOT_SIZE_CELLS;
@@ -2883,6 +2886,13 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo)
             goto err;
     }
 
+    if ( kinfo->dom0less_enhanced )
+    {
+        ret = make_hypervisor_node(d, kinfo, addrcells, sizecells);
+        if ( ret )
+            goto err;
+    }
+
     ret = fdt_end_node(kinfo->fdt);
     if ( ret < 0 )
         goto err;
@@ -3149,6 +3159,25 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo)
     return 0;
 }
 
+static int __init alloc_xenstore_evtchn(struct domain *d)
+{
+    evtchn_alloc_unbound_t alloc;
+    int rc;
+
+    alloc.dom = d->domain_id;
+    alloc.remote_dom = hardware_domain->domain_id;
+    rc = evtchn_alloc_unbound(&alloc);
+    if ( rc )
+    {
+        printk("Failed allocating event channel for domain\n");
+        return rc;
+    }
+
+    d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port;
+
+    return 0;
+}
+
 static int __init construct_domU(struct domain *d,
                                  const struct dt_device_node *node)
 {
@@ -3213,6 +3242,14 @@ static int __init construct_domU(struct domain *d,
     if ( rc < 0 )
         return rc;
 
+    if ( kinfo.dom0less_enhanced )
+    {
+        rc = alloc_xenstore_evtchn(d);
+        if ( rc < 0 )
+            return rc;
+        d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL;
+    }
+
     return rc;
 }
 
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index ffb042a241..2f6a89f52d 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -289,7 +289,7 @@ void evtchn_free(struct domain *d, struct evtchn *chn)
     xsm_evtchn_close_post(chn);
 }
 
-static int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc)
+int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc)
 {
     struct evtchn *chn;
     struct domain *d;
diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h
index 21c95e14fd..f3021fe304 100644
--- a/xen/include/xen/event.h
+++ b/xen/include/xen/event.h
@@ -71,6 +71,9 @@ void evtchn_free(struct domain *d, struct evtchn *chn);
 /* Allocate a specific event channel port. */
 int evtchn_allocate_port(struct domain *d, unsigned int port);
 
+/* Allocate a new event channel */
+int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc);
+
 /* Unmask a local event-channel port. */
 int evtchn_unmask(unsigned int port);
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:57:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:57:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317705.537189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgL-0007qZ-6z; Fri, 29 Apr 2022 20:57:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317705.537189; Fri, 29 Apr 2022 20:57:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgL-0007pf-14; Fri, 29 Apr 2022 20:57:41 +0000
Received: by outflank-mailman (input) for mailman id 317705;
 Fri, 29 Apr 2022 20:57:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXgJ-0006w0-EY
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:57:39 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ff7c0e05-c7fe-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 22:57:37 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1178362197;
 Fri, 29 Apr 2022 20:57:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 267C3C385A7;
 Fri, 29 Apr 2022 20:57:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff7c0e05-c7fe-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651265855;
	bh=6m3CZlBC4jLi1cx+SFKdE9IMqKeQVNwLUZ2DmiQZgwE=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=lbrADBwSTXHRicxGA7BKm/+C4Zz3/c38hf5hyKfbPuwxwDCPaybhjNf6IIVYAaBsH
	 s9pqrMoykdwN/mMvk+wrA5loKcoThdulaLA+Bbm+OP2a7dH/AUKgUv32/8Gw1gvsKi
	 tMxfhbNIy1hyiyI0fap/CFjW+bzeQ8Eeip6hTwTZm2WB54PBJBDc4BwJOyc6tyrdpR
	 Nqt7bm7lz9vTJ8z0U0cXnLNh5kpqC5NQJ6xAdA/+Cv13VOsMeW2H0BlgyTKfCV2fJu
	 sr55G82ZjIvaKS+2xuW7sFGCvKgm5frL1Fom1W8GI2lYxepU4tAfFkPWVOuxxMNciH
	 59r6YceC3V2Jw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v5 3/7] xen: introduce xen,enhanced dom0less property
Date: Fri, 29 Apr 2022 13:57:28 -0700
Message-Id: <20220429205732.2030094-3-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Introduce a new "xen,enhanced" dom0less property to enable/disable PV
driver interfaces for dom0less guests. Currently only "enabled" and
"disabled" are supported property values (and empty). Leave the option
open to implement further possible values in the future (e.g.
"xenstore" to enable only xenstore.)

The configurable option is for domUs only. For dom0 we always set the
corresponding property in the Xen code to true (PV interfaces enabled.)

This patch only parses the property. Next patches will make use of it.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v4:
- move xen,enhanced to the bottom of the list
- do not set kinfo.dom0less_enhanced for dom0

Changes in v3:
- improve commit message

Changes in v2:
- rename kinfo.enhanced to kinfo.dom0less_enhanced
- set kinfo.dom0less_enhanced to true for dom0
- handle -ENODATA in addition to -EILSEQ
---
 docs/misc/arm/device-tree/booting.txt | 18 ++++++++++++++++++
 xen/arch/arm/domain_build.c           |  7 +++++++
 xen/arch/arm/include/asm/kernel.h     |  3 +++
 3 files changed, 28 insertions(+)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index a94125394e..92097c4969 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -188,6 +188,24 @@ with the following properties:
     An empty property to request the memory of the domain to be
     direct-map (guest physical address == physical address).
 
+- xen,enhanced
+
+    A string property. Possible property values are:
+
+    - "enabled" (or missing property value)
+    Xen PV interfaces, including grant-table and xenstore, will be
+    enabled for the VM.
+
+    - "disabled"
+    Xen PV interfaces are disabled.
+
+    If the xen,enhanced property is present with no value, it defaults
+    to "enabled". If the xen,enhanced property is not present, PV
+    interfaces are disabled.
+
+    In the future other possible property values might be added to
+    enable only selected interfaces.
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 34d3e5ce30..a877ccf585 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3153,6 +3153,7 @@ static int __init construct_domU(struct domain *d,
                                  const struct dt_device_node *node)
 {
     struct kernel_info kinfo = {};
+    const char *dom0less_enhanced;
     int rc;
     u64 mem;
 
@@ -3168,6 +3169,12 @@ static int __init construct_domU(struct domain *d,
 
     kinfo.vpl011 = dt_property_read_bool(node, "vpl011");
 
+    rc = dt_property_read_string(node, "xen,enhanced", &dom0less_enhanced);
+    if ( rc == -EILSEQ ||
+         rc == -ENODATA ||
+         (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) )
+        kinfo.dom0less_enhanced = true;
+
     if ( vcpu_create(d, 0) == NULL )
         return -ENOMEM;
 
diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h
index 874aa108a7..c4dc039b54 100644
--- a/xen/arch/arm/include/asm/kernel.h
+++ b/xen/arch/arm/include/asm/kernel.h
@@ -36,6 +36,9 @@ struct kernel_info {
     /* Enable pl011 emulation */
     bool vpl011;
 
+    /* Enable PV drivers */
+    bool dom0less_enhanced;
+
     /* GIC phandle */
     uint32_t phandle_gic;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:57:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:57:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317706.537196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgL-00081L-SS; Fri, 29 Apr 2022 20:57:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317706.537196; Fri, 29 Apr 2022 20:57:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgL-0007yB-LE; Fri, 29 Apr 2022 20:57:41 +0000
Received: by outflank-mailman (input) for mailman id 317706;
 Fri, 29 Apr 2022 20:57:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXgK-0007P4-6K
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:57:40 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00591aee-c7ff-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 22:57:38 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6BEB4621E4;
 Fri, 29 Apr 2022 20:57:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEB37C385A7;
 Fri, 29 Apr 2022 20:57:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00591aee-c7ff-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651265857;
	bh=btLZXtaxl9qWeM6CyJYOjZEoxyC1CnI0BUVRGmnQUKM=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=pt7N1gLJEnAAM8jQvYRp1WVXDZ9gHpl+i4uvjOVZlc+K62tGeONq9uLmFmBoBgRQ/
	 YhPL+Gc+Q5QGdlDujmEmsqtTe1LcLnL4/JaaH25iDoJ0+JMu/TQEzVpvM6blIkKB1Z
	 dXiaiDuzQ7QQElLt8bBsSxo1hNEUixejrumOuIzktD7u3WQIOKgQ4n/WNyAHcHIGyt
	 uqJSba1XJdBUFLdzUHUDKgxchK+YWP4X7AE9WyW4K021mZRiI7xQA/MWO5e2luZC5D
	 mGNXcBuvDdpzsLAU6KN7f9QkGyS/KXmI//juUwfnndfw0AXxJIi0vex4u/AcgzvjkM
	 kMGz/MXX8febw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Luca Miccio <lucmiccio@gmail.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v5 6/7] tools: add example application to initialize dom0less PV drivers
Date: Fri, 29 Apr 2022 13:57:31 -0700
Message-Id: <20220429205732.2030094-6-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

Add an example application that can be run in dom0 to complete the
dom0less domains initialization so that they can get access to xenstore
and use PV drivers.

The application sets XS_CONNECTION_STATE_RECONNECTING on the xenstore
page before calling xs_introduce_domain to signal that the connection is
not ready yet to be used. XS_CONNECTION_STATE_RECONNECTING is reset soon
after by xenstored.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
---
Changes in v5:
- set XS_CONNECTION_STATE_RECONNECTING before xs_introduce_domain

Changes in v4:
- only alloc xs page (no other magic pages)
- add xenstore permissions
- check all return values
- rename restore_xenstore to create_xenstore
- set target_memkb
- set start_time properly
- close xs transaction on error
- call xc_dom_gnttab_seed instead of xc_dom_gnttab_init
- xs_open instead of xs_daemon_open

Changes in v3:
- handle xenstore errors
- add an in-code comment about xenstore entries
- less verbose output
- clean-up error path in main

Changes in v2:
- do not set HVM_PARAM_STORE_EVTCHN twice
- rename restore_xenstore to create_xenstore
- increase maxmem

connection reconnecting
---
 tools/helpers/Makefile        |  13 ++
 tools/helpers/init-dom0less.c | 341 ++++++++++++++++++++++++++++++++++
 2 files changed, 354 insertions(+)
 create mode 100644 tools/helpers/init-dom0less.c

diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile
index 7f6c422440..8d78ab1e90 100644
--- a/tools/helpers/Makefile
+++ b/tools/helpers/Makefile
@@ -10,6 +10,9 @@ ifeq ($(CONFIG_Linux),y)
 ifeq ($(CONFIG_X86),y)
 PROGS += init-xenstore-domain
 endif
+ifeq ($(CONFIG_ARM),y)
+PROGS += init-dom0less
+endif
 endif
 
 XEN_INIT_DOM0_OBJS = xen-init-dom0.o init-dom-json.o
@@ -26,6 +29,13 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h
 
+INIT_DOM0LESS_OBJS = init-dom0less.o init-dom-json.o
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxentoollog)
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenstore)
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenlight)
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenctrl)
+$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenevtchn)
+
 .PHONY: all
 all: $(PROGS)
 
@@ -35,6 +45,9 @@ xen-init-dom0: $(XEN_INIT_DOM0_OBJS)
 init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS)
 	$(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS)
 
+init-dom0less: $(INIT_DOM0LESS_OBJS)
+	$(CC) $(LDFLAGS) -o $@ $(INIT_DOM0LESS_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenevtchn) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(LDLIBS_libxenguest) $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS)
+
 .PHONY: install
 install: all
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c
new file mode 100644
index 0000000000..a99398e928
--- /dev/null
+++ b/tools/helpers/init-dom0less.c
@@ -0,0 +1,341 @@
+#include <stdbool.h>
+#include <syslog.h>
+#include <stdio.h>
+#include <err.h>
+#include <stdlib.h>
+#include <sys/time.h>
+#include <xenstore.h>
+#include <xenctrl.h>
+#include <xenguest.h>
+#include <libxl.h>
+#include <xenevtchn.h>
+#include <xenforeignmemory.h>
+
+#include "init-dom-json.h"
+
+#define XS_CONNECTION_STATE_OFFSET       (2068/4)
+#define XS_CONNECTION_STATE_RECONNECTING 0x1
+#define XENSTORE_PFN_OFFSET 1
+#define STR_MAX_LENGTH 64
+
+static int alloc_xs_page(struct xc_interface_core *xch,
+                         libxl_dominfo *info,
+                         uint64_t *xenstore_pfn)
+{
+    int rc;
+    const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT;
+    xen_pfn_t p2m = (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET;
+
+    rc = xc_domain_setmaxmem(xch, info->domid,
+                             info->max_memkb + (XC_PAGE_SIZE/1024));
+    if (rc < 0)
+        return rc;
+
+    rc = xc_domain_populate_physmap_exact(xch, info->domid, 1, 0, 0, &p2m);
+    if (rc < 0)
+        return rc;
+
+    *xenstore_pfn = base + XENSTORE_PFN_OFFSET;
+    rc = xc_clear_domain_page(xch, info->domid, *xenstore_pfn);
+    if (rc < 0)
+        return rc;
+
+    return 0;
+}
+
+static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t,
+                            domid_t domid, char *path, char *val)
+{
+    char full_path[STR_MAX_LENGTH];
+    struct xs_permissions perms[2];
+
+    perms[0].id = domid;
+    perms[0].perms = XS_PERM_NONE;
+    perms[1].id = 0;
+    perms[1].perms = XS_PERM_READ;
+
+    if (snprintf(full_path, STR_MAX_LENGTH,
+                 "/local/domain/%u/%s", domid, path) < 0)
+        return false;
+    if (!xs_write(xsh, t, full_path, val, strlen(val)))
+        return false;
+    return xs_set_permissions(xsh, t, full_path, perms, 2);
+}
+
+static bool do_xs_write_libxl(struct xs_handle *xsh, xs_transaction_t t,
+                              domid_t domid, char *path, char *val)
+{
+    char full_path[STR_MAX_LENGTH];
+
+    if (snprintf(full_path, STR_MAX_LENGTH,
+                 "/libxl/%u/%s", domid, path) < 0)
+        return false;
+    return xs_write(xsh, t, full_path, val, strlen(val));
+}
+
+static bool do_xs_write_vm(struct xs_handle *xsh, xs_transaction_t t,
+                           libxl_uuid uuid, char *path, char *val)
+{
+    char full_path[STR_MAX_LENGTH];
+
+    if (snprintf(full_path, STR_MAX_LENGTH,
+                 "/vm/" LIBXL_UUID_FMT "/%s", LIBXL_UUID_BYTES(uuid), path) < 0)
+        return false;
+    return xs_write(xsh, t, full_path, val, strlen(val));
+}
+
+/*
+ * The xenstore nodes are the xenstore nodes libxl writes at domain
+ * creation.
+ *
+ * The list was retrieved by running xenstore-ls on a corresponding
+ * domain started by xl/libxl.
+ */
+static int create_xenstore(struct xs_handle *xsh,
+                           libxl_dominfo *info, libxl_uuid uuid,
+                           evtchn_port_t xenstore_port)
+{
+    domid_t domid;
+    unsigned int i;
+    char uuid_str[STR_MAX_LENGTH];
+    char dom_name_str[STR_MAX_LENGTH];
+    char vm_val_str[STR_MAX_LENGTH];
+    char id_str[STR_MAX_LENGTH];
+    char max_memkb_str[STR_MAX_LENGTH];
+    char target_memkb_str[STR_MAX_LENGTH];
+    char cpu_str[STR_MAX_LENGTH];
+    char xenstore_port_str[STR_MAX_LENGTH];
+    char ring_ref_str[STR_MAX_LENGTH];
+    xs_transaction_t t;
+    struct timeval start_time;
+    char start_time_str[STR_MAX_LENGTH];
+    int rc;
+
+    if (gettimeofday(&start_time, NULL) < 0)
+        return -errno;
+    rc = snprintf(start_time_str, STR_MAX_LENGTH, "%jd.%02d",
+            (intmax_t)start_time.tv_sec, (int)start_time.tv_usec / 10000);
+    if (rc < 0)
+        return rc;
+
+    domid = info->domid;
+    rc = snprintf(id_str, STR_MAX_LENGTH, "%u", domid);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(dom_name_str, STR_MAX_LENGTH, "dom0less-%u", domid);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(uuid_str, STR_MAX_LENGTH, LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid));
+    if (rc < 0)
+        return rc;
+    rc = snprintf(vm_val_str, STR_MAX_LENGTH,
+                  "vm/" LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid));
+    if (rc < 0)
+        return rc;
+    rc = snprintf(max_memkb_str, STR_MAX_LENGTH, "%lu", info->max_memkb);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(target_memkb_str, STR_MAX_LENGTH, "%lu", info->current_memkb);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(ring_ref_str, STR_MAX_LENGTH, "%lld",
+                  (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET);
+    if (rc < 0)
+        return rc;
+    rc = snprintf(xenstore_port_str, STR_MAX_LENGTH, "%u", xenstore_port);
+    if (rc < 0)
+        return rc;
+
+retry_transaction:
+    t = xs_transaction_start(xsh);
+    if (t == XBT_NULL)
+        return -errno;
+
+    rc = -EIO;
+    /* /vm */
+    if (!do_xs_write_vm(xsh, t, uuid, "name", dom_name_str)) goto err;
+    if (!do_xs_write_vm(xsh, t, uuid, "uuid", uuid_str)) goto err;
+    if (!do_xs_write_vm(xsh, t, uuid, "start_time", start_time_str)) goto err;
+
+    /* /domain */
+    if (!do_xs_write_dom(xsh, t, domid, "vm", vm_val_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "name", dom_name_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "cpu", "")) goto err;
+    for (i = 0; i < info->vcpu_max_id; i++) {
+        rc = snprintf(cpu_str, STR_MAX_LENGTH, "cpu/%u/availability/", i);
+        if (rc < 0)
+            goto err;
+        rc = -EIO;
+        if (!do_xs_write_dom(xsh, t, domid, cpu_str,
+                             (info->cpupool & (1 << i)) ? "online" : "offline"))
+            goto err;
+    }
+
+    if (!do_xs_write_dom(xsh, t, domid, "memory", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "memory/static-max", max_memkb_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "memory/target", target_memkb_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "memory/videoram", "-1")) goto err;
+
+    if (!do_xs_write_dom(xsh, t, domid, "device", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "device/suspend", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "device/suspend/event-channel", "")) goto err;
+
+    if (!do_xs_write_dom(xsh, t, domid, "control", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/shutdown", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/feature-poweroff", "1")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/feature-reboot", "1")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/feature-suspend", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/sysrq", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-multiprocessor-suspend", "1")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-xs_reset_watches", "1")) goto err;
+
+    if (!do_xs_write_dom(xsh, t, domid, "domid", id_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "data", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "drivers", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "feature", "")) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "attr", "")) goto err;
+
+    if (!do_xs_write_dom(xsh, t, domid, "store/port", xenstore_port_str)) goto err;
+    if (!do_xs_write_dom(xsh, t, domid, "store/ring-ref", ring_ref_str)) goto err;
+
+    if (!do_xs_write_libxl(xsh, t, domid, "type", "pvh")) goto err;
+    if (!do_xs_write_libxl(xsh, t, domid, "dm-version", "qemu_xen")) goto err;
+
+    if (!xs_transaction_end(xsh, t, false)) {
+        if (errno == EAGAIN)
+            goto retry_transaction;
+        else
+            return -errno;
+    }
+
+    return 0;
+
+err:
+    xs_transaction_end(xsh, t, true);
+    return rc;
+}
+
+static int init_domain(struct xs_handle *xsh,
+                       struct xc_interface_core *xch,
+                       xenforeignmemory_handle *xfh,
+                       libxl_dominfo *info)
+{
+    libxl_uuid uuid;
+    uint64_t xenstore_evtchn, xenstore_pfn;
+    int rc;
+    uint32_t *page;
+
+    printf("Init dom0less domain: %u\n", info->domid);
+
+    rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN,
+                          &xenstore_evtchn);
+    if (rc != 0) {
+        printf("Failed to get HVM_PARAM_STORE_EVTCHN\n");
+        return 1;
+    }
+
+    /* Alloc xenstore page */
+    if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) {
+        printf("Error on alloc magic pages\n");
+        return 1;
+    }
+
+    page = xenforeignmemory_map(xfh, info->domid, XS_READ | XS_WRITE, 1,
+                                &xenstore_pfn, NULL);
+    if (!page) {
+        printf("Error mapping xenstore page\n");
+        return 1;
+    }
+    page[XS_CONNECTION_STATE_OFFSET] = XS_CONNECTION_STATE_RECONNECTING;
+    xenforeignmemory_unmap(xfh, page, 1);
+
+    rc = xc_dom_gnttab_seed(xch, info->domid, true,
+                            (xen_pfn_t)-1, xenstore_pfn, 0, 0);
+    if (rc)
+        err(1, "xc_dom_gnttab_seed");
+
+    libxl_uuid_generate(&uuid);
+    xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid));
+
+    rc = gen_stub_json_config(info->domid, &uuid);
+    if (rc)
+        err(1, "gen_stub_json_config");
+
+    /* Now everything is ready: set HVM_PARAM_STORE_PFN */
+    rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN,
+                          xenstore_pfn);
+    if (rc < 0)
+        return rc;
+
+    rc = create_xenstore(xsh, info, uuid, xenstore_evtchn);
+    if (rc)
+        err(1, "writing to xenstore");
+
+    rc = xs_introduce_domain(xsh, info->domid,
+            (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET,
+            xenstore_evtchn);
+    if (!rc)
+        err(1, "xs_introduce_domain");
+    return 0;
+}
+
+/* Check if domain has been configured in XS */
+static bool domain_exists(struct xs_handle *xsh, int domid)
+{
+    return xs_is_domain_introduced(xsh, domid);
+}
+
+int main(int argc, char **argv)
+{
+    libxl_dominfo *info = NULL;
+    libxl_ctx *ctx;
+    int nb_vm = 0, rc = 0, i;
+    struct xs_handle *xsh = NULL;
+    struct xc_interface_core *xch = NULL;
+    xenforeignmemory_handle *xfh = NULL;
+
+    /* TODO reuse libxl xsh connection */
+    xsh = xs_open(0);
+    xch = xc_interface_open(0, 0, 0);
+    xfh = xenforeignmemory_open(0, 0);
+    if (xsh == NULL || xch == NULL || xfh == NULL) {
+        fprintf(stderr, "Cannot open xc/xs/xenforeignmemory interfaces");
+        rc = -errno;
+        goto out;
+    }
+
+    rc = libxl_ctx_alloc(&ctx, LIBXL_VERSION, 0, NULL);
+    if (rc) {
+        fprintf(stderr, "cannot init xl context\n");
+        goto out;
+    }
+
+    info = libxl_list_domain(ctx, &nb_vm);
+    if (!info) {
+        fprintf(stderr, "libxl_list_vm failed.\n");
+        rc = -1;
+        goto out;
+    }
+
+    for (i = 0; i < nb_vm; i++) {
+        domid_t domid = info[i].domid;
+
+        /* Don't need to check for Dom0 */
+        if (!domid)
+            continue;
+
+        printf("Checking domid: %u\n", domid);
+        if (!domain_exists(xsh, domid)) {
+            rc = init_domain(xsh, xch, xfh, &info[i]);
+            if (rc < 0) {
+                fprintf(stderr, "init_domain failed.\n");
+                goto out;
+            }
+        } else {
+            printf("Domain %u has already been initialized\n", domid);
+        }
+    }
+out:
+    libxl_dominfo_list_free(info, nb_vm);
+    return rc;
+}
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:57:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:57:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317707.537203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgM-0008AM-EY; Fri, 29 Apr 2022 20:57:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317707.537203; Fri, 29 Apr 2022 20:57:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgM-00087X-5x; Fri, 29 Apr 2022 20:57:42 +0000
Received: by outflank-mailman (input) for mailman id 317707;
 Fri, 29 Apr 2022 20:57:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXgK-0006w0-Ey
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:57:40 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0046ac0c-c7ff-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 22:57:38 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 30ABC621E0;
 Fri, 29 Apr 2022 20:57:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46767C385AC;
 Fri, 29 Apr 2022 20:57:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0046ac0c-c7ff-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651265856;
	bh=6seieTR73PH0f82Y34HYb9MpClaXG8oJYvBYPMoiaDI=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=k5GRPcr8GP3K8y0qny7p1zb6YiGMIlCW9P+OME3kKPshu/LxqKY8B59ApDF+m5mee
	 pNo+Bu5sC2SVSLwgUDi0wnTVvua5iZkt9eHCR416wok+K592gYw0wv2ZWUabyKJIp6
	 AdjPt2r7iLnNwCHpZnTq/aq+dmryD07R4jgweqsCm/iryHUxxWDV67dp2XIJhEX8P3
	 t844yfb6M+fyZ7E1zDYZUM2m4mIZNdeJElapXrCxxWY8ivabovwVipl5ewltATtG5E
	 BuXgm+2gstcKjkwEI1SzTluY3VMD018j96/LrrUNXCdkG1D3sPcgaBPPWlsFqbOtAI
	 6edhDcAgFtn0Q==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Luca Miccio <lucmiccio@gmail.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v5 5/7] xenstored: send an evtchn notification on introduce_domain
Date: Fri, 29 Apr 2022 13:57:30 -0700
Message-Id: <20220429205732.2030094-5-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

When xs_introduce_domain is called, send out a notification on the
xenstore event channel so that any (dom0less) domain waiting for the
xenstore interface to be ready can continue with the initialization.
Before sending the notification, clear XS_CONNECTION_STATE_RECONNECTING.

The extra notification is harmless for domains that don't require it.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
CC: Juergen Gross <jgross@suse.com>
CC: Julien Grall <julien@xen.org>
---
I dropped the Reviewed-by tags due to the connect = 0 change. Julien
also suggested it would be a good idea to add a clarification statement
about the usage of XS_CONNECTION_STATE_RECONNECTING in the header files
but I wasn't sure what to write. Please advise and I am happy to include
a statement in the next version.

Changes in v5:
- reset XS_CONNECTION_STATE_RECONNECTING before notifying the domU

Changes in v2:
- drop the new late_init parameter
---
 tools/xenstore/xenstored_domain.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index ae065fcbee..7bb8c64d33 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -493,6 +493,10 @@ static struct domain *introduce_domain(const void *ctx,
 		/* Now domain belongs to its connection. */
 		talloc_steal(domain->conn, domain);
 
+		/* Notify the domain that xenstore is available */
+		interface->connection = 0x0;
+		xenevtchn_notify(xce_handle, domain->port);
+
 		if (!is_master_domain && !restore)
 			fire_watches(NULL, ctx, "@introduceDomain", NULL,
 				     false, NULL);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:57:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:57:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317708.537209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgN-0008HO-03; Fri, 29 Apr 2022 20:57:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317708.537209; Fri, 29 Apr 2022 20:57:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXgM-0008FH-Lc; Fri, 29 Apr 2022 20:57:42 +0000
Received: by outflank-mailman (input) for mailman id 317708;
 Fri, 29 Apr 2022 20:57:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXgK-0007P4-Sv
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 20:57:40 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00b7edbe-c7ff-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 22:57:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id DCFE2621EF;
 Fri, 29 Apr 2022 20:57:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66E02C385A4;
 Fri, 29 Apr 2022 20:57:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00b7edbe-c7ff-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651265857;
	bh=SyJ8d/AZr5XFzu3v/AGdBw4+YWs6wkcRBAD8+aGiIR8=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=cFwoZ1jZoKmm0fIaLPrBdtVpQwmMmWQuOMdhpElQ86ZHxbI24kfpM2w8tfWDMsEDU
	 6RX0FiuvfZ2cG+CbZpXwL1gZ+9GVFj+OnZnDMSrfvJ2iKEyimlXmlwrCsdZXtFZhzk
	 nL4ixopKip//3f+DvViNCdLEIumFn8pGVZskMeMyjhmTXmuZj626QBtug9B5xn+Zax
	 GBkq/K6uaiAGXY1A/Inc9TwQB5GL1c5DxgGTRi7ZuoTgbQk05I5BXA8twZagiuQhmL
	 6++0+3rQyWkkTNSobTdT+jkokKUYCFrOiifVEyZQFZUUUMYQjY2IpusJUhe6Fw2BHT
	 wxR5rj8UQul7g==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	jgross@suse.com,
	Bertrand.Marquis@arm.com,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v5 7/7] docs: document dom0less + PV drivers
Date: Fri, 29 Apr 2022 13:57:32 -0700
Message-Id: <20220429205732.2030094-7-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2204291354050.1947187@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Document how to use the feature and how the implementation works.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 docs/features/dom0less.pandoc | 43 ++++++++++++++++++++++++++++++++---
 1 file changed, 40 insertions(+), 3 deletions(-)

diff --git a/docs/features/dom0less.pandoc b/docs/features/dom0less.pandoc
index c9edb529e1..725afa0558 100644
--- a/docs/features/dom0less.pandoc
+++ b/docs/features/dom0less.pandoc
@@ -90,6 +90,46 @@ Otherwise, they may be unusable in Xen (for instance if they are compressed).
 
 See docs/misc/arm/device-tree/booting.txt for more information.
 
+PV Drivers
+----------
+
+It is possible to use PV drivers with dom0less guests with some
+restrictions:
+
+- dom0less domUs that want to use PV drivers support should have the
+  "xen,enhanced" property set under their device tree nodes (see
+  docs/misc/arm/device-tree/booting.txt)
+- a dom0 must be present (or another domain with enough privileges to
+  run the toolstack)
+- after dom0 is booted, the utility "init-dom0less" must be run
+- do not run "init-dom0less" while creating other guests with xl
+
+After the execution of init-dom0less, it is possible to use "xl" to
+hotplug PV drivers to dom0less guests. E.g. xl network-attach domU.
+
+The implementation works as follows:
+- Xen allocates the xenstore event channel for each dom0less domU that
+  has the "xen,enhanced" property, and sets HVM_PARAM_STORE_EVTCHN
+- Xen does *not* allocate the xenstore page and sets HVM_PARAM_STORE_PFN
+  to ~0ULL (invalid)
+- Dom0less domU kernels check that HVM_PARAM_STORE_PFN is set to invalid
+    - Old kernels will continue without xenstore support (Note: some old
+      buggy kernels might crash because they don't check the validity of
+      HVM_PARAM_STORE_PFN before using it! Disable "xen,enhanced" in
+      those cases)
+    - New kernels will wait for a notification on the xenstore event
+      channel (HVM_PARAM_STORE_EVTCHN) before continuing with the
+      initialization
+- Once dom0 is booted, init-dom0less is executed:
+    - it allocates the xenstore shared page and sets HVM_PARAM_STORE_PFN
+    - it calls xs_introduce_domain
+- Xenstored notices the new domain, initializes interfaces as usual, and
+  sends an event channel notification to the domain using the xenstore
+  event channel (HVM_PARAM_STORE_EVTCHN)
+- The Linux domU kernel receives the event channel notification, checks
+  HVM_PARAM_STORE_PFN again and continue with the initialization
+
+
 Limitations
 -----------
 
@@ -107,9 +147,6 @@ limitations:
   information, the GIC version exposed to the domains started by Xen at
   boot is the same as the native GIC version.
 
-- No PV drivers. There is no support for PV devices at the moment. All
-  devices need to be statically assigned to guests.
-
 - Pinning vCPUs of domains started by Xen at boot can be
   done from the control domain, using `xl vcpu-pin` as usual. It is not
   currently possible to configure vCPU pinning without a control domain.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 20:59:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 20:59:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317729.537239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXiJ-00033B-Jm; Fri, 29 Apr 2022 20:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317729.537239; Fri, 29 Apr 2022 20:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXiJ-000334-GL; Fri, 29 Apr 2022 20:59:43 +0000
Received: by outflank-mailman (input) for mailman id 317729;
 Fri, 29 Apr 2022 20:59:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkXiH-00032u-UC; Fri, 29 Apr 2022 20:59:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkXiH-0000g7-SW; Fri, 29 Apr 2022 20:59:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkXiH-0000od-I0; Fri, 29 Apr 2022 20:59:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkXiH-0005Zd-HY; Fri, 29 Apr 2022 20:59:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=p/NwGLJzHj0bp84AeC5XNA5/U0/nzB0Ze1qDeBjJklA=; b=AdWBylM9WYu968tHbNHgqbUnl3
	uT34h9hZBxbCoj3HvsxN9GlwWcTTvHOykMiwJAW3/LDojgEpUNGqv4SNNn8G2cYk1XDB647FBeBrq
	ynk++Tikzek7OUIBIxXWKbFJbPQ9kpoFOTxiq3sJ6aPnDukKVbTVCmqvAi9HkdDsyk/Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169882-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169882: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 20:59:41 +0000

flight 169882 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169882/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  702 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   23 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 21:10:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 21:10:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317758.537250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXsn-0005Z7-RV; Fri, 29 Apr 2022 21:10:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317758.537250; Fri, 29 Apr 2022 21:10:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkXsn-0005Z0-N0; Fri, 29 Apr 2022 21:10:33 +0000
Received: by outflank-mailman (input) for mailman id 317758;
 Fri, 29 Apr 2022 21:10:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkXsn-0005Yu-BJ
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 21:10:33 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cd00835f-c800-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 23:10:31 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 48B056222F;
 Fri, 29 Apr 2022 21:10:30 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0BDFC385A4;
 Fri, 29 Apr 2022 21:10:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd00835f-c800-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651266630;
	bh=KmdTjeuSqmh9CE/tUKpNwFrF67mIaEHHOltqgoCVtxU=;
	h=From:To:Cc:Subject:Date:From;
	b=PzF6qHNaUB/VAMyIG0sbhyLAUhcomOyqMW5RBsN/PwMcQx8Onu6SZGUaqqtlrdSfL
	 wXYHCcb5v6M9tfxr1jcujJLv/WFIZvEN/DVe+tWMb+ULLDqSynkSzMngh5KVSImNTc
	 AA01tsxJXXdWhN5hxqNcIwlUo+DcQXNA84G38YdeJ6zAg4rK3aqv2XoiNwY7tlsOef
	 DpYpi17UELRvIy7FP7qtK7DfzCeFmOVwr2vvQJHEnS5+rFRjj/M5qUSu9hB9UCXQ67
	 3vmjesrEkA4OfY42Q17o1JqVX6L5xqMPs1vpNrOqqUvUUETVYvPmZETLkoHXsihGuZ
	 rcK06oCBG+tDA==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	Luca Miccio <lucmiccio@gmail.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	jgross@suse.com,
	boris.ostrovsky@oracle.com
Subject: [LINUX PATCH v3] xen: add support for initializing xenstore later as HVM domain
Date: Fri, 29 Apr 2022 14:10:27 -0700
Message-Id: <20220429211027.2034134-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

When running as dom0less guest (HVM domain on ARM) the xenstore event
channel is available at domain creation but the shared xenstore
interface page only becomes available later on.

In that case, wait for a notification on the xenstore event channel,
then complete the xenstore initialization later, when the shared page
is actually available.

The xenstore page has few extra field. Add them to the shared struct.
One of the field is "connection", when the connection is ready, it is
zero. If the connection is not-zero, wait for a notification.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
CC: jgross@suse.com
CC: boris.ostrovsky@oracle.com
---
Changes in v3:
- check for the connection field, if it is not zero, wait for event

Changes in v2:
- remove XENFEAT_xenstore_late_init
---
 drivers/xen/xenbus/xenbus_probe.c  | 86 +++++++++++++++++++++++-------
 include/xen/interface/io/xs_wire.h |  3 ++
 2 files changed, 70 insertions(+), 19 deletions(-)

diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
index fe360c33ce71..dc046d25789e 100644
--- a/drivers/xen/xenbus/xenbus_probe.c
+++ b/drivers/xen/xenbus/xenbus_probe.c
@@ -65,6 +65,7 @@
 #include "xenbus.h"
 
 
+static int xs_init_irq;
 int xen_store_evtchn;
 EXPORT_SYMBOL_GPL(xen_store_evtchn);
 
@@ -750,6 +751,17 @@ static void xenbus_probe(void)
 {
 	xenstored_ready = 1;
 
+	if (!xen_store_interface) {
+		xen_store_interface = xen_remap(xen_store_gfn << XEN_PAGE_SHIFT,
+						XEN_PAGE_SIZE);
+		/*
+		 * Now it is safe to free the IRQ used for xenstore late
+		 * initialization. No need to unbind: it is about to be
+		 * bound again.
+		 */
+		free_irq(xs_init_irq, &xb_waitq);
+	}
+
 	/*
 	 * In the HVM case, xenbus_init() deferred its call to
 	 * xs_init() in case callbacks were not operational yet.
@@ -798,20 +810,22 @@ static int __init xenbus_probe_initcall(void)
 {
 	/*
 	 * Probe XenBus here in the XS_PV case, and also XS_HVM unless we
-	 * need to wait for the platform PCI device to come up.
+	 * need to wait for the platform PCI device to come up or
+	 * xen_store_interface is not ready.
 	 */
 	if (xen_store_domain_type == XS_PV ||
 	    (xen_store_domain_type == XS_HVM &&
-	     !xs_hvm_defer_init_for_callback()))
+	     !xs_hvm_defer_init_for_callback() &&
+	     xen_store_interface != NULL))
 		xenbus_probe();
 
 	/*
-	 * For XS_LOCAL, spawn a thread which will wait for xenstored
-	 * or a xenstore-stubdom to be started, then probe. It will be
-	 * triggered when communication starts happening, by waiting
-	 * on xb_waitq.
+	 * For XS_LOCAL or when xen_store_interface is not ready, spawn a
+	 * thread which will wait for xenstored or a xenstore-stubdom to be
+	 * started, then probe.  It will be triggered when communication
+	 * starts happening, by waiting on xb_waitq.
 	 */
-	if (xen_store_domain_type == XS_LOCAL) {
+	if (xen_store_domain_type == XS_LOCAL || xen_store_interface == NULL) {
 		struct task_struct *probe_task;
 
 		probe_task = kthread_run(xenbus_probe_thread, NULL,
@@ -907,10 +921,25 @@ static struct notifier_block xenbus_resume_nb = {
 	.notifier_call = xenbus_resume_cb,
 };
 
+static irqreturn_t xenbus_late_init(int irq, void *unused)
+{
+	int err = 0;
+	uint64_t v = 0;
+
+	err = hvm_get_parameter(HVM_PARAM_STORE_PFN, &v);
+	if (err || !v || !~v)
+		return IRQ_HANDLED;
+	xen_store_gfn = (unsigned long)v;
+
+	wake_up(&xb_waitq);
+	return IRQ_HANDLED;
+}
+
 static int __init xenbus_init(void)
 {
 	int err;
 	uint64_t v = 0;
+	bool wait = false;
 	xen_store_domain_type = XS_UNKNOWN;
 
 	if (!xen_domain())
@@ -959,23 +988,42 @@ static int __init xenbus_init(void)
 		 *
 		 * Also recognize all bits set as an invalid value.
 		 */
-		if (!v || !~v) {
+		if (!v) {
 			err = -ENOENT;
 			goto out_error;
 		}
-		/* Avoid truncation on 32-bit. */
+		if (v == ~0ULL) {
+			wait = true;
+		} else {
+			/* Avoid truncation on 32-bit. */
 #if BITS_PER_LONG == 32
-		if (v > ULONG_MAX) {
-			pr_err("%s: cannot handle HVM_PARAM_STORE_PFN=%llx > ULONG_MAX\n",
-			       __func__, v);
-			err = -EINVAL;
-			goto out_error;
-		}
+			if (v > ULONG_MAX) {
+				pr_err("%s: cannot handle HVM_PARAM_STORE_PFN=%llx > ULONG_MAX\n",
+						__func__, v);
+				err = -EINVAL;
+				goto out_error;
+			}
 #endif
-		xen_store_gfn = (unsigned long)v;
-		xen_store_interface =
-			xen_remap(xen_store_gfn << XEN_PAGE_SHIFT,
-				  XEN_PAGE_SIZE);
+			xen_store_gfn = (unsigned long)v;
+			xen_store_interface =
+				xen_remap(xen_store_gfn << XEN_PAGE_SHIFT,
+					  XEN_PAGE_SIZE);
+			if (xen_store_interface->connection != 0)
+				wait = true;
+		}
+		if (wait) {
+			err = bind_evtchn_to_irqhandler(xen_store_evtchn,
+							xenbus_late_init,
+							0, "xenstore_late_init",
+							&xb_waitq);
+			if (err < 0) {
+				pr_err("xenstore_late_init couldn't bind irq err=%d\n",
+				       err);
+				return err;
+			}
+
+			xs_init_irq = err;
+		}
 		break;
 	default:
 		pr_warn("Xenstore state unknown\n");
diff --git a/include/xen/interface/io/xs_wire.h b/include/xen/interface/io/xs_wire.h
index d40a44f09b16..cd7ae5ebb133 100644
--- a/include/xen/interface/io/xs_wire.h
+++ b/include/xen/interface/io/xs_wire.h
@@ -87,6 +87,9 @@ struct xenstore_domain_interface {
     char rsp[XENSTORE_RING_SIZE]; /* Replies and async watch events. */
     XENSTORE_RING_IDX req_cons, req_prod;
     XENSTORE_RING_IDX rsp_cons, rsp_prod;
+    uint32_t server_features; /* Bitmap of features supported by the server */
+    uint32_t connection;
+    uint32_t error;
 };
 
 /* Violating this is very bad.  See docs/misc/xenstore.txt. */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 21:19:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 21:19:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317765.537261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkY1T-0006I7-Lh; Fri, 29 Apr 2022 21:19:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317765.537261; Fri, 29 Apr 2022 21:19:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkY1T-0006I0-IY; Fri, 29 Apr 2022 21:19:31 +0000
Received: by outflank-mailman (input) for mailman id 317765;
 Fri, 29 Apr 2022 21:19:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkX=VH=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nkY1S-0006Hu-Fd
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 21:19:30 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c629d78-c802-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 23:19:28 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23TLJ8rI060470
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 29 Apr 2022 17:19:14 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23TLJ7RB060469;
 Fri, 29 Apr 2022 14:19:07 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c629d78-c802-11ec-8fc4-03012f2f19d4
Date: Fri, 29 Apr 2022 14:19:07 -0700
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] tools/xl: Sort create command options
Message-ID: <YmxWS8DZcUKuDZw0@mattapan.m5p.com>
References: <cover.1650422517.git.ehem+xen@m5p.com>
 <c145a7648025e9bbc2f47ab8bd5839c80c01933f.1650422518.git.ehem+xen@m5p.com>
 <YmuyT0/8Mfa0eM1b@perard.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YmuyT0/8Mfa0eM1b@perard.uk.xensource.com>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

On Fri, Apr 29, 2022 at 10:39:27AM +0100, Anthony PERARD wrote:
> On Tue, Apr 19, 2022 at 06:56:03PM -0700, Elliott Mitchell wrote:
> > Hopefully simplify future changes by sorting options lists for
> > `xl create`.
> 
> I'm not sure that sorting options make changes easier, as it would mean
> one has to make sure the new option is sorted as well ;-). But sorting
> the options in the help message is probably useful; I've looked at a few
> linux utilities and they tend to have them sorted so doing this for xl
> create sound fine.

This ends up revolving around the question, is the work involved in
keeping things sorted more or less than the annoyance caused by having
them unsorted?  I tend towards keep them sorted since I find trying to
identify available option letters when they're in random order is rather
troublesome.

> > Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> > ---
> > diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
> > index 435155a033..2ec4140258 100644
> > --- a/tools/xl/xl_vmcontrol.c
> > +++ b/tools/xl/xl_vmcontrol.c
> > @@ -1169,13 +1169,13 @@ int main_create(int argc, char **argv)
> >      int paused = 0, debug = 0, daemonize = 1, console_autoconnect = 0,
> >          quiet = 0, monitor = 1, vnc = 0, vncautopass = 0, ignore_masks = 0;
> >      int opt, rc;
> > -    static struct option opts[] = {
> > +    static const struct option opts[] = {
> 
> Could you add a note in the commit message that "opts" is now
> const?

Okay.

> > +        {"defconfig", 1, 0, 'f'},
> >          {"dryrun", 0, 0, 'n'},
> > +        {"ignore-global-affinity-masks", 0, 0, 'i'},
> >          {"quiet", 0, 0, 'q'},
> > -        {"defconfig", 1, 0, 'f'},
> >          {"vncviewer", 0, 0, 'V'},
> >          {"vncviewer-autopass", 0, 0, 'A'},
> > -        {"ignore-global-affinity-masks", 0, 0, 'i'},
> >          COMMON_LONG_OPTS
> >      };
> >  
> > @@ -1186,12 +1186,15 @@ int main_create(int argc, char **argv)
> >          argc--; argv++;
> >      }
> >  
> > -    SWITCH_FOREACH_OPT(opt, "Fnqf:pcdeVAi", opts, "create", 0) {
> > -    case 'f':
> > -        filename = optarg;
> > +    SWITCH_FOREACH_OPT(opt, "Ffnq:AVcdeip", opts, "create", 0) {
> 
> The list of short options aren't really sorted here. Also -q doesn't
> take an argument, but -f should keep requiring one.

Needed to reread the documentation on getopt() behavior.  I remembered
it being group before the colon didn't take options, ones after colon
did take options.  Instead it is colon for every option with argument.

Other issue is dictionary sort versus ASCII sort.  ie "AaBbCcDdEeFf..."
versus "A-Za-z".


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Fri Apr 29 21:30:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 21:30:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317771.537272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYCD-00005r-Md; Fri, 29 Apr 2022 21:30:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317771.537272; Fri, 29 Apr 2022 21:30:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYCD-00005k-J9; Fri, 29 Apr 2022 21:30:37 +0000
Received: by outflank-mailman (input) for mailman id 317771;
 Fri, 29 Apr 2022 21:30:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkYCB-00005Z-Un; Fri, 29 Apr 2022 21:30:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkYCB-0001GM-T0; Fri, 29 Apr 2022 21:30:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkYCB-0001Yy-I8; Fri, 29 Apr 2022 21:30:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkYCB-00065z-Hj; Fri, 29 Apr 2022 21:30:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hs+PNTUsSV8CWkZX1ro04MHYAQwFHjPKKHLclKiH4NA=; b=HC9GcjqOawxAcEwOABvWuYKaiq
	nVcO2HJb6ys+wzkbpwG4gLl+y1wZoI6FoIaQck4wkyFcUr6VcZscHSZ3lb/tBVwjJl9QO2oNSlpjr
	VXvKL/PsRVYgW2MrZ4rZhXDvsukMWrq5tEkbJEQ9wyPOk2UtmCqsZzzYyX+sQG6q49w4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169883-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169883: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 21:30:35 +0000

flight 169883 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169883/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  703 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   24 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 21:39:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 21:39:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317781.537289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYKm-0000r4-LC; Fri, 29 Apr 2022 21:39:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317781.537289; Fri, 29 Apr 2022 21:39:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYKm-0000qv-Hu; Fri, 29 Apr 2022 21:39:28 +0000
Received: by outflank-mailman (input) for mailman id 317781;
 Fri, 29 Apr 2022 21:39:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkYKi-0000qp-Fc
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 21:39:27 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d4fd1e6e-c804-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 23:39:22 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkYK9-0001bD-CM; Fri, 29 Apr 2022 23:38:49 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4fd1e6e-c804-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=zaZR6AionffdB1xNnJGX+2SLzxIRGHxmDTzkdAsF8Lw=; b=f2se15ohqCxFdZ9Cbwp90MFGzT
	jTOap9gxEPPT4aTyNt5E3ZHiiiT+V3lzyiVXivZvxSS+ElUToKTRjGns0j7W5gu+rUZwjHaY5hGeN
	otkXyAwqu6HD3avUoXVIxjGs+UlKUlBOe/StJroDKFugT/kZL7npThsCdsHpDWufEk+wh4fOOIDQw
	l7OyKb0Jm89RaQG7TSk5bTRs2tlRpACA1IvBqK2eiZLAu6g1+MyYc/cQwPm5SUuYLGV0bPXJdES3s
	lnyV4bPi3phdA0er49wiR1R3K1IMQcdtRi5k8Pou9s9nypOSId//IHiPuzLjmzkdZNlZyJjIhfVzV
	toxHByUQ==;
Message-ID: <71d829c4-b280-7d6e-647d-79a1baf9408b@igalia.com>
Date: Fri, 29 Apr 2022 18:38:19 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs
 shutdown path
Content-Language: en-US
To: Marc Zyngier <maz@kernel.org>,
 "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
 kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
 bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de,
 keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org,
 mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org,
 rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu,
 tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org,
 Russell King <linux@armlinux.org.uk>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-3-gpiccoli@igalia.com> <87mtg392fm.wl-maz@kernel.org>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <87mtg392fm.wl-maz@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Thanks Marc and Michael for the review/discussion.

On 29/04/2022 15:20, Marc Zyngier wrote:
> [...]

> My expectations would be that, since we're getting here using an IPI,
> interrupts are already masked. So what reenabled them the first place?
> 
> Thanks,
> 
> 	M.
> 

Marc, I did some investigation in the code (and tried/failed in the ARM
documentation as well heh), but this is still not 100% clear for me.

You're saying IPI calls disable IRQs/FIQs by default in the the target
CPUs? Where does it happen? I'm a bit confused if this a processor
mechanism, or it's in code.

Looking the smp_send_stop() in arch/arm/, it does IPI the CPUs, with the
flag IPI_CPU_STOP, eventually calling ipi_cpu_stop(), and the latter
does disable IRQ/FIQ in code - that's where I stole my code from.

But crash_smp_send_stop() is different, it seems to IPI the other CPUs
with the flag IPI_CALL_FUNC, which leads to calling
generic_smp_call_function_interrupt() - does it disable interrupts/FIQs
as well? I couldn't find it.

Appreciate your clarifications about that, thanks again.
Cheers,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 21:46:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 21:46:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317791.537300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYRJ-0002PZ-CW; Fri, 29 Apr 2022 21:46:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317791.537300; Fri, 29 Apr 2022 21:46:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYRJ-0002PS-9Z; Fri, 29 Apr 2022 21:46:13 +0000
Received: by outflank-mailman (input) for mailman id 317791;
 Fri, 29 Apr 2022 21:46:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SVeO=VH=armlinux.org.uk=linux+xen-devel=lists.xenproject.org@srs-se1.protection.inumbo.net>)
 id 1nkYRH-0002PM-8h
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 21:46:11 +0000
Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk
 [2001:4d48:ad52:32c8:5054:ff:fe00:142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c54d74c4-c805-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 23:46:08 +0200 (CEST)
Received: from shell.armlinux.org.uk
 ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58452)
 by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <linux@armlinux.org.uk>)
 id 1nkYQk-0004ZT-FQ; Fri, 29 Apr 2022 22:45:38 +0100
Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2)
 (envelope-from <linux@shell.armlinux.org.uk>)
 id 1nkYQM-0002I9-Ul; Fri, 29 Apr 2022 22:45:14 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: c54d74c4-c805-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type:
	MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
	Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
	List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=cwWnO80Ui/d685UGUuBb6P6W/VqQxrK3NU0KyxunMME=; b=NuAZTGtLYYcfk4IaGz8kBTT5Di
	0khQT6RBBrfoMfADRQoh55tLUZAAxvGzbf+CHwsG5aHW/I0aPMt9IcQreT+TXN6tVft3fhHxppW6e
	0gRrhT6oZwWHTdNRt+hsETMwNeSqJUbKiJvdYcPS0Tel4JSlQtazcO1PKvgS3i7ssm2Wvg6CHs/7o
	pj47XlfT3VRnDJ1t48UzNo9OiptPRH+9FkqQXagZ6uncBzcJGMl/PQwNLpM91GK25wc70TaaRl3MI
	17OaYSYBFRj1A/+iiCNfQT0GNRF/9G3lza+liz2omEugL6i4QHflxUFmrjvLEVlv51bSj77G0/dOg
	tubfbwug==;
Date: Fri, 29 Apr 2022 22:45:14 +0100
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: Marc Zyngier <maz@kernel.org>,
	"Michael Kelley (LINUX)" <mikelley@microsoft.com>,
	akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org, sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
	fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
	corbet@lwn.net, d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com,
	gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org,
	luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com,
	paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org,
	senozhatsky@chromium.org, stern@rowland.harvard.edu,
	tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com,
	will@kernel.org
Subject: Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs
 shutdown path
Message-ID: <Ymxcaqy6DwhoQrZT@shell.armlinux.org.uk>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-3-gpiccoli@igalia.com>
 <87mtg392fm.wl-maz@kernel.org>
 <71d829c4-b280-7d6e-647d-79a1baf9408b@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <71d829c4-b280-7d6e-647d-79a1baf9408b@igalia.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Fri, Apr 29, 2022 at 06:38:19PM -0300, Guilherme G. Piccoli wrote:
> Thanks Marc and Michael for the review/discussion.
> 
> On 29/04/2022 15:20, Marc Zyngier wrote:
> > [...]
> 
> > My expectations would be that, since we're getting here using an IPI,
> > interrupts are already masked. So what reenabled them the first place?
> > 
> > Thanks,
> > 
> > 	M.
> > 
> 
> Marc, I did some investigation in the code (and tried/failed in the ARM
> documentation as well heh), but this is still not 100% clear for me.
> 
> You're saying IPI calls disable IRQs/FIQs by default in the the target
> CPUs? Where does it happen? I'm a bit confused if this a processor
> mechanism, or it's in code.

When we taken an IRQ, IRQs will be masked, FIQs will not. IPIs are
themselves interrupts, so IRQs will be masked while the IPI is being
processed. Therefore, there should be no need to re-disable the
already disabled interrupts.

> But crash_smp_send_stop() is different, it seems to IPI the other CPUs
> with the flag IPI_CALL_FUNC, which leads to calling
> generic_smp_call_function_interrupt() - does it disable interrupts/FIQs
> as well? I couldn't find it.

It's buried in the architecture behaviour. When the CPU takes an
interrupt and jumps to the interrupt vector in the vectors page, it is
architecturally defined that interrupts will be disabled. If they
weren't architecturally disabled at this point, then as soon as the
first instruction is processed (at the interrupt vector, likely a
branch) the CPU would immediately take another jump to the interrupt
vector, and this process would continue indefinitely, making interrupt
handling utterly useless.

So, you won't find an explicit instruction in the code path from the
vectors to the IPI handler that disables interrupts - because it's
written into the architecture that this is what must happen.

IRQs are a lower priority than FIQs, so FIQs remain unmasked.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 21:47:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 21:47:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317801.537310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYSw-00033c-TD; Fri, 29 Apr 2022 21:47:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317801.537310; Fri, 29 Apr 2022 21:47:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYSw-00033V-QC; Fri, 29 Apr 2022 21:47:54 +0000
Received: by outflank-mailman (input) for mailman id 317801;
 Fri, 29 Apr 2022 21:47:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkYSv-00033C-Dd; Fri, 29 Apr 2022 21:47:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkYSv-0001Yg-AK; Fri, 29 Apr 2022 21:47:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkYSv-00021x-01; Fri, 29 Apr 2022 21:47:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkYSu-0001c2-Vn; Fri, 29 Apr 2022 21:47:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aJe846bQyNR0dsXN+OXHt5qE5AgUKyQGXN3hYe3ksAI=; b=PkxWYURKJ1bMV/QPKMTZ1UpCkZ
	wGTY/GkQD7Ux6+V0Eoanb3sZxrtjpm5oiEqWIoIl+KmVUfcysHr7GzaTQuV2uIsvK0ZIYWJ7UL08M
	YclVI1jR8a8KsSeZ7SJSJLy4mwYU4A13DbdNR9jbC75iHk+qT7Xxk8SjCzfTCf2S4ZPM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169862-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169862: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=38d741cb70b30741c0e802cbed7bd9cf4fd15fa4
X-Osstest-Versions-That:
    linux=249aca0d3d631660aa3583c6a3559b75b6e971b4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 21:47:52 +0000

flight 169862 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169862/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169836
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169836
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169836
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169836
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169836
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169836
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169836
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169836
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                38d741cb70b30741c0e802cbed7bd9cf4fd15fa4
baseline version:
 linux                249aca0d3d631660aa3583c6a3559b75b6e971b4

Last test of basis   169836  2022-04-28 22:11:22 Z    0 days
Testing same since   169862  2022-04-29 09:52:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Deucher <alexander.deucher@amd.com>
  Dave Airlie <airlied@redhat.com>
  David Yat Sin <david.yatsin@amd.com>
  Evan Quan <evan.quan@amd.com>
  Hans de Goede <hdegoede@redhat.com>
  Imre Deak <imre.deak@intel.com>
  Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
  Jouni Högander <jouni.hogander@intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
  Maxime Ripard <maxime@cerno.tech>
  Miaoqian Lin <linmq006@gmail.com>
  Michele Ballabio <ballabio.m@gmail.com>
  Prike Liang <Prike.Liang@amd.com>
  Samuel Holland <samuel@sholland.org>
  Ville Syrjälä <ville.syrjala@linux.intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   249aca0d3d63..38d741cb70b3  38d741cb70b30741c0e802cbed7bd9cf4fd15fa4 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 21:57:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 21:57:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317812.537322 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYc6-0004Xq-QS; Fri, 29 Apr 2022 21:57:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317812.537322; Fri, 29 Apr 2022 21:57:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYc6-0004Xj-Nd; Fri, 29 Apr 2022 21:57:22 +0000
Received: by outflank-mailman (input) for mailman id 317812;
 Fri, 29 Apr 2022 21:57:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkYc5-0004Xd-B9
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 21:57:21 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 56ad44ec-c807-11ec-a405-831a346695d4;
 Fri, 29 Apr 2022 23:57:19 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkYbf-00026w-BA; Fri, 29 Apr 2022 23:56:55 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56ad44ec-c807-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=eS25PhwvZQoNO/vrdkaYeu8w1J4I4bLwd4ZTs99JyTA=; b=ECdoj8MPrPw94rqNJkzG67Xg6u
	5w3+r9FZKL3W6Sz5zRa77JB5F86agKTzGYxwlLLEiZXrXTSk2m+k2FuOzlO52C0njkoCAxgy+FOi4
	NbVcSL4Lztxu2l4Ffp2YNwJJ/Y8NKCykCEJYOFD8NTX9U/x1OlE0AF3cSiTkk6ArLGAdmnn9RzvKe
	+YDGf9dxyEhvGPz5vqubLFDl4xc7G7O1n7kxIDUk0ceOUg9ZGVixjcU3/TKND9q/DVjCWl1sG0kaE
	cUjiBbJ/0Gd+0GoqtFAQ2G5bnqvlp008GZC0sOTWOBCZAoUh5dk2HlkdBig7SM6f3egXphVF+FJ+M
	iEBg1fYA==;
Message-ID: <32495ca6-d79a-a932-a8e3-19ef54c44c48@igalia.com>
Date: Fri, 29 Apr 2022 18:56:24 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs
 shutdown path
Content-Language: en-US
To: "Russell King (Oracle)" <linux@armlinux.org.uk>,
 Marc Zyngier <maz@kernel.org>
Cc: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
 akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com,
 kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
 bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de,
 keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org,
 mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org,
 rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu,
 tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-3-gpiccoli@igalia.com> <87mtg392fm.wl-maz@kernel.org>
 <71d829c4-b280-7d6e-647d-79a1baf9408b@igalia.com>
 <Ymxcaqy6DwhoQrZT@shell.armlinux.org.uk>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <Ymxcaqy6DwhoQrZT@shell.armlinux.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/04/2022 18:45, Russell King (Oracle) wrote:
> [...]
>> Marc, I did some investigation in the code (and tried/failed in the ARM
>> documentation as well heh), but this is still not 100% clear for me.
>>
>> You're saying IPI calls disable IRQs/FIQs by default in the the target
>> CPUs? Where does it happen? I'm a bit confused if this a processor
>> mechanism, or it's in code.
> 
> When we taken an IRQ, IRQs will be masked, FIQs will not. IPIs are
> themselves interrupts, so IRQs will be masked while the IPI is being
> processed. Therefore, there should be no need to re-disable the
> already disabled interrupts.
> 
>> But crash_smp_send_stop() is different, it seems to IPI the other CPUs
>> with the flag IPI_CALL_FUNC, which leads to calling
>> generic_smp_call_function_interrupt() - does it disable interrupts/FIQs
>> as well? I couldn't find it.
> 
> It's buried in the architecture behaviour. When the CPU takes an
> interrupt and jumps to the interrupt vector in the vectors page, it is
> architecturally defined that interrupts will be disabled. If they
> weren't architecturally disabled at this point, then as soon as the
> first instruction is processed (at the interrupt vector, likely a
> branch) the CPU would immediately take another jump to the interrupt
> vector, and this process would continue indefinitely, making interrupt
> handling utterly useless.
> 
> So, you won't find an explicit instruction in the code path from the
> vectors to the IPI handler that disables interrupts - because it's
> written into the architecture that this is what must happen.
> 
> IRQs are a lower priority than FIQs, so FIQs remain unmasked.
> 

Thanks a lot for the *great* explanation Russell, much appreciated.
So, this leads to the both following questions:

a) Shall we then change the patch to only disable FIQs, since it's panic
path and we don't want secondary CPUs getting interrupted, but only
spinning quietly "forever"?

b) How about cleaning ipi_cpu_stop() then, by dropping the call to
local_irq_disable() there, to avoid the double IRQ disabling?

Thanks,


Guilherme


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 22:00:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 22:00:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317822.537333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYf7-0005vf-91; Fri, 29 Apr 2022 22:00:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317822.537333; Fri, 29 Apr 2022 22:00:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkYf7-0005vY-63; Fri, 29 Apr 2022 22:00:29 +0000
Received: by outflank-mailman (input) for mailman id 317822;
 Fri, 29 Apr 2022 22:00:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=930Y=VH=kernel.org=maz@srs-se1.protection.inumbo.net>)
 id 1nkYf6-0005vP-1M
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 22:00:28 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c64a4566-c807-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 00:00:26 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4CD3AB835F2;
 Fri, 29 Apr 2022 22:00:25 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDC10C385A7;
 Fri, 29 Apr 2022 22:00:23 +0000 (UTC)
Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org)
 by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <maz@kernel.org>)
 id 1nkYez-0082vp-Lb; Fri, 29 Apr 2022 23:00:21 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c64a4566-c807-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651269624;
	bh=yNgvZ1w6j0wn0gJjn3Jaaz8UA8LJOCaxNlCblYsp6Fs=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=Ey/m78Y6tu0GBqTH6NyWHzaC7vgRNJhEY6Vw+hMPcj4Fiq4wF8lLbYXSJID6UbS61
	 3qfdckpr3iC4r/Day5Vxaq6phJAcWANrxyoTmiYG1UpeUOvuCECA8JWjDSUmjQNVeX
	 //qNOhJwNmYbbQLZRcm0DHusz0JaLv/dWrmLzW2Wgv1yO4UhSlC4XbHTgdaXFO+dOB
	 K8/k23uG5cTkWPZKYDhSGFzjNLXWZHlHJLxc5WmfxL+dYPfyClhuAsqZafdYrm47Su
	 hkvrUQWMqSJRPNSqY6gnHqelGJDkuHvsu0DZZC5HFsjW59Ot7eIOwvaowmb9LaKSuE
	 kes/J6RG3f/Hw==
Date: Fri, 29 Apr 2022 23:00:21 +0100
Message-ID: <87ilqr8s96.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	"Michael Kelley (LINUX)" <mikelley@microsoft.com>,
	akpm@linux-foundation.org,
	bhe@redhat.com,
	pmladek@suse.com,
	kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linuxppc-dev@lists.ozlabs.org,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	linux-s390@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-um@lists.infradead.org,
	linux-xtensa@linux-xtensa.org,
	netdev@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	rcu@vger.kernel.org,
	sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	x86@kernel.org,
	kernel-dev@igalia.com,
	kernel@gpiccoli.net,
	halves@canonical.com,
	fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	andriy.shevchenko@linux.intel.com,
	arnd@arndb.de,
	bp@alien8.de,
	corbet@lwn.net,
	d.hatayama@jp.fujitsu.com,
	dave.hansen@linux.intel.com,
	dyoung@redhat.com,
	feng.tang@intel.com,
	gregkh@linuxfoundation.org,
	hidehiro.kawai.ez@hitachi.com,
	jgross@suse.com,
	john.ogness@linutronix.de,
	keescook@chromium.org,
	luto@kernel.org,
	mhiramat@kernel.org,
	mingo@redhat.com,
	paulmck@kernel.org,
	peterz@infradead.org,
	rostedt@goodmis.org,
	senozhatsky@chromium.org,
	stern@rowland.harvard.edu,
	tglx@linutronix.de,
	vgoyal@redhat.com,
	vkuznets@redhat.com,
	will@kernel.org
Subject: Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path
In-Reply-To: <Ymxcaqy6DwhoQrZT@shell.armlinux.org.uk>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
	<20220427224924.592546-3-gpiccoli@igalia.com>
	<87mtg392fm.wl-maz@kernel.org>
	<71d829c4-b280-7d6e-647d-79a1baf9408b@igalia.com>
	<Ymxcaqy6DwhoQrZT@shell.armlinux.org.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: linux@armlinux.org.uk, gpiccoli@igalia.com, mikelley@microsoft.com, akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, 
 bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Fri, 29 Apr 2022 22:45:14 +0100,
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
> 
> On Fri, Apr 29, 2022 at 06:38:19PM -0300, Guilherme G. Piccoli wrote:
> > Thanks Marc and Michael for the review/discussion.
> > 
> > On 29/04/2022 15:20, Marc Zyngier wrote:
> > > [...]
> > 
> > > My expectations would be that, since we're getting here using an IPI,
> > > interrupts are already masked. So what reenabled them the first place?
> > > 
> > > Thanks,
> > > 
> > > 	M.
> > > 
> > 
> > Marc, I did some investigation in the code (and tried/failed in the ARM
> > documentation as well heh), but this is still not 100% clear for me.
> > 
> > You're saying IPI calls disable IRQs/FIQs by default in the the target
> > CPUs? Where does it happen? I'm a bit confused if this a processor
> > mechanism, or it's in code.
> 
> When we taken an IRQ, IRQs will be masked, FIQs will not. IPIs are
> themselves interrupts, so IRQs will be masked while the IPI is being
> processed. Therefore, there should be no need to re-disable the
> already disabled interrupts.
> 
> > But crash_smp_send_stop() is different, it seems to IPI the other CPUs
> > with the flag IPI_CALL_FUNC, which leads to calling
> > generic_smp_call_function_interrupt() - does it disable interrupts/FIQs
> > as well? I couldn't find it.
> 
> It's buried in the architecture behaviour. When the CPU takes an
> interrupt and jumps to the interrupt vector in the vectors page, it is
> architecturally defined that interrupts will be disabled. If they
> weren't architecturally disabled at this point, then as soon as the
> first instruction is processed (at the interrupt vector, likely a
> branch) the CPU would immediately take another jump to the interrupt
> vector, and this process would continue indefinitely, making interrupt
> handling utterly useless.
> 
> So, you won't find an explicit instruction in the code path from the
> vectors to the IPI handler that disables interrupts - because it's
> written into the architecture that this is what must happen.
> 
> IRQs are a lower priority than FIQs, so FIQs remain unmasked.

Ah, you're of course right. That's one of the huge differences between
AArch32 and AArch64, where the former has per target mode masking
rules, and the later masks everything on entry...

	M.

-- 
Without deviation from the norm, progress is not possible.


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 22:22:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 22:22:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317829.537343 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZ0k-0008Qk-5C; Fri, 29 Apr 2022 22:22:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317829.537343; Fri, 29 Apr 2022 22:22:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZ0k-0008Qd-1M; Fri, 29 Apr 2022 22:22:50 +0000
Received: by outflank-mailman (input) for mailman id 317829;
 Fri, 29 Apr 2022 22:22:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkZ0i-0008QT-US; Fri, 29 Apr 2022 22:22:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkZ0i-0002BS-O9; Fri, 29 Apr 2022 22:22:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkZ0i-0002rN-7j; Fri, 29 Apr 2022 22:22:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkZ0i-0003kH-7L; Fri, 29 Apr 2022 22:22:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WL57rWZAgdQa2OduUitALB6H/BxXYN8r5IJk/uTFyBk=; b=py6m3fsSRMvNWbXx7TIzVYygMc
	dLO37mJ2yIIPW2rcAo5gCZNXgktscgIRjBC3+dsiX2qE3EsRwh2b2kilW4yusimSh1rv6KnpBYmrq
	Xc8p55/6cluI5YB4jm2wJ/XMS5Cb4b9V5uGvVKeI7dZHbxYTmyMbLWIoMTuMwNq/iOu4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169859-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169859: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-examine:reboot:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl-thunderx:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    xen-unstable:test-arm64-arm64-xl:xen-boot:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
X-Osstest-Versions-That:
    xen=3f5d61466345ed2213de2d7e391b6cd6d4b86015
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 22:22:48 +0000

flight 169859 xen-unstable real [real]
flight 169876 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169859/
http://logs.test-lab.xenproject.org/osstest/logs/169876/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 169775
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl-thunderx  8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 169775
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 169775

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169775
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169775
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169775
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169775
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169775
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169775
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169775
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169775
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169775
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169775
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169775
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169775
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
baseline version:
 xen                  3f5d61466345ed2213de2d7e391b6cd6d4b86015

Last test of basis   169775  2022-04-27 08:15:40 Z    2 days
Failing since        169798  2022-04-27 22:39:22 Z    1 days    3 attempts
Testing same since   169859  2022-04-29 07:50:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Dario Faggioli <dfaggioli@suse.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 395 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 22:26:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 22:26:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317837.537355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZ3o-0000cm-Lh; Fri, 29 Apr 2022 22:26:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317837.537355; Fri, 29 Apr 2022 22:26:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZ3o-0000cb-IL; Fri, 29 Apr 2022 22:26:00 +0000
Received: by outflank-mailman (input) for mailman id 317837;
 Fri, 29 Apr 2022 22:25:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GAsh=VH=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nkZ3m-0000cV-IM
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 22:25:59 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5591541a-c80b-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 00:25:56 +0200 (CEST)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23TI2Xuo032179;
 Fri, 29 Apr 2022 22:25:50 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmb107740-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Apr 2022 22:25:49 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23TMLWUc034181; Fri, 29 Apr 2022 22:25:48 GMT
Received: from nam11-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam11lp2174.outbound.protection.outlook.com [104.47.58.174])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3fp5yqp12m-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Apr 2022 22:25:48 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by PH0PR10MB5625.namprd10.prod.outlook.com (2603:10b6:510:f8::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 29 Apr
 2022 22:25:46 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 22:25:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5591541a-c80b-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=5F9bg2FC7c56ALiLt08UT5vmAe5mNv6uzmnEuIJ9B98=;
 b=A9W1amgm95nznP8j3nFwuHPjUE43aUCSg0CP3TQSEYE6PLaJ+yOauNmyxwyVU2uHsdtd
 cXwzbKfzqhTQQ/HfJT2JOTgEwupZk7c2f39gYm4R+r2kYi8Rp7TQXdXbQcf8IR0jq+NB
 DRNUdpIjdneNY0CwSOZDV+Mwt8jCL09zj4V4xw0kT2LL/2fYfKaJRUJmEspPw5mkOqN0
 RFO4oe1fqS/BbiGORbYO7lToSdPAfHnHhO/M2DoinbaHKiOSRP4oF3R/B97bRgzvRbDj
 sqSU1VXOViSC7o2nLfVUgHJa2lzBeAC2t2nR2Ee3FoVbBoLAiEX4QdkYhy0nDG631dHQ 6A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cghBGt2BK49uTEYKeHlBWOwMygurdTtTAE0FIm8S24o/VkufzbuE3cYOOlTMTAamv7WOfVj4aoN4FKIruY200PA3Iqh49c3Jo7WNv+DUi8T1+/rnNGbtj4BTVxoDLLgTfPO/TnbAcbJXUyjeVymFergkmRVKyIkLDjCMtNL09g0W6UV8kyoFhLk9NAlzyKY/iAodw1TGxzbCfR8uzx/u4gJDuLaICnOxxmlZn1U07K8v9ZfjUSe8QjqjcxHlEXg2B+lS010izRno7/5QvN/W8WsvS5GkndqaVx3UmisCiiO3TtHYK/vA6eV/QcNiBEvWL2bHftsidC7UVGTnLAzOww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5F9bg2FC7c56ALiLt08UT5vmAe5mNv6uzmnEuIJ9B98=;
 b=mMnU8KYdc8oNfw4Qas3m9I8Q48ddaM8fwA5CMQAr44EO8ORhqsYLAY9Watb5wncAXqcjA/ve919MSZuKbMsIWZ3Sd0eWXoYX4zQYK3Jrwz3fMX9+kTCbsfEgHl7zhOx1x8e21oIi/oadJGEiO0JAn3mOLhT1ZhW/m1+qMtHvb057d/7g0S8Jvj2In0ziQsNodyrCCkdAwRM/YftwE7lL9U3X4DBpfnZZL/ZkXjAd5VEcLNPXFf6CK0Mirp9g7XgU48hWrc4GihaOGlc4e0WubCWdsUb1wA6AnvphR4VdrIXWl7+VVk+BXoBTlOrN8/++D2BFhWVdLL2oa1q5Pz0Mdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5F9bg2FC7c56ALiLt08UT5vmAe5mNv6uzmnEuIJ9B98=;
 b=UALCwT4NSvmU5KJxUcTQXM5sh06yX0aZoDvdRR1UhQjfN1iW6tpwBIIL/v05A8wpzSmsp8UkudyRvSQgv6JdYzXZgRxByna4DXVXI/bNySUTH4C6mCC8nIMGVxgGDDI63ILLg2DphQNpewV0yNbcqw1DvPGnte15iwU6IamQRzg=
Message-ID: <fdb13c95-acde-ebac-9864-e661d7daeeb7@oracle.com>
Date: Fri, 29 Apr 2022 18:25:42 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH v2 0/4] xen/pv-scsi: update header and harden frontend
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
References: <20220428075323.12853-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220428075323.12853-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0PR03CA0071.namprd03.prod.outlook.com
 (2603:10b6:a03:331::16) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 779b4171-c5cd-4402-fac5-08da2a2f34c7
X-MS-TrafficTypeDiagnostic: PH0PR10MB5625:EE_
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB5625E112099D6B6F7F9EE3458AFC9@PH0PR10MB5625.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	Gu6j0r+Ek6iOY7p62xaec9GBCmduokHhW6tMv28qh1HMmwUXjEZrtZAm1t0oGmNHsmp6PpdDK6I6V2RUgJLv3KGEsckjhvBI7t3llaOYjYlUKt7Vih180iIno8dzj80RKwBu35s1vzzhW2pbr4Rrmgtodxal150Wm7aSGvXKQSpxwCtDwlCVgqJvFDJ0/0mh4diKCD3XvnOoC7Uvbu4Z9Lv65voTMP3PAsGcMOB1Q4XvT5i3PqNFiw2XgjkfoNrXob+8W5lzX/D+T+IPvBUAb7oewVaF3LSfjmZssNOF7HVu5AUmyALPhitsHC05ndaZ5yICHc8sQ8CosGLAAOIEEx9xYAUgP2SFPNjVvSNI/30gqGHMYf5S8Y50NxYAr7CWYdZfakibWxUghQHdzX1mD9bfCw7qT1eX7jttcgWXJELkk/isQhjs9Ah5gcBwM3RFQeX1njzAyEMYbmcdu6o79rWx5Tcot6zJ3GHD8NPCPbpMYeNvU9dgj1B+d5+LxbtLhRi/FquwSbxsyTs1xKJvYkgJtWieOPNFouxwhYQU0JAiHCM8l5fgqh8TPqh3hLmUuvVkn2mAx4DoWc25qcGLxXD7EIeYmPPVzjK8bGDzCqstW6YVFlpXDZYm6g1eLw64AkRF41EsC1Ultl+TqU+U4YutW9RpPOnkFOtGDj/uTiwLlurdV3bhfR+cNMhJlq+DzaFg3MWx3WkRsAKnfwqpc7JbRpu7Uch1UW2r5tH/PaX87HXRpujPRIkQpZ2pk3fZ
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(8676002)(53546011)(6506007)(15650500001)(38100700002)(44832011)(2906002)(2616005)(66476007)(66556008)(107886003)(66946007)(26005)(31686004)(4326008)(6512007)(36756003)(4744005)(6666004)(316002)(54906003)(5660300002)(6486002)(83380400001)(31696002)(8936002)(186003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?WVVCWUltK24yS1A1Nm1QUUFOazNPRWRlZnlIdU5WbGp1bnh0MjhZc0ZDS1Uw?=
 =?utf-8?B?SlFpeW9kT0VkSEZVQWlTY1JKK1NyblpIY3dPa01Gd3p1ajNTQ0Y5V1VnQmRm?=
 =?utf-8?B?MHh2Z0d1KzE5ZlNIaVR5T3FUeUQxM2s4THZOMGpQSE9zRUk2ckttUXVvaHhZ?=
 =?utf-8?B?SDZLRkJQTEVWRkRvWmZUdldJNXBrdGl0b1lLQ1lwYVdkb3NYZ2xvRjRJeVJt?=
 =?utf-8?B?ZHVPb1Y2Q2xxR09tVWZyUDcrTktkME1uenpRcytSUHcvMk44S2J1VE9tczhj?=
 =?utf-8?B?dGFGZ2xPd3d6ak1jMmlOajNQQ1ZaWWVhaUVUVDhHTXQrbEVyZlMyb3ZlNEhU?=
 =?utf-8?B?STA2RjM4VXV5V3hGRTZCNWNwM1hvbDJ6eFVaN0NqejY3VktHUVFkK1MxSWR0?=
 =?utf-8?B?M25XaWZDVS9zTHEyUTVDUkp1NjV1ckIxWkxsaHdxaE1ZZ2pXNzY1dEFzQkl0?=
 =?utf-8?B?SkVlNXhmT1RZeTUzUUJjcW9hZ2JHMnpXWUU4bmV6c2phSkgrMDRRZ0NvWTk5?=
 =?utf-8?B?bFhqNnU4UGo5N1dQbjFUYlR5YnhRL3JFMmx1TkYwb1k5aVUwZnVFL2pYbEVS?=
 =?utf-8?B?VUxkbEdsT1ZEK3E2a1dWaVd5WGlvLytKTlVkUG5ZMEtvYkMyQTM5NS94am9x?=
 =?utf-8?B?QTRaVng2U2pCQzhlMnRQNzdBNE9SMG9qMUVidWdoMzZ1WHBjWXpvdHZPVG5M?=
 =?utf-8?B?S3AxYWJRSzJHa1l4dVBiamNIMHFhVE42NllzMkVqd2dQaXNycENkamdQeG5T?=
 =?utf-8?B?K3hHVzM2ZUJJVk1vREwvRFh0alRZWjFmQXBwTm0rZGhCdkVPdE8zM1pWQkhM?=
 =?utf-8?B?VFNwb3QyS0JHaFMzRmRXQnpmK0lBTWpxbUVDSEpnb0c1TFVVeEVWNUhQZTFZ?=
 =?utf-8?B?allGOVlDWnJGVjBZUGxVUi9DR2JwV3BXN0YrektNTFprbWhNMis3THlST0Mv?=
 =?utf-8?B?S1Jqak41UlBxR0hJbkpKTXM1QUhQREpON2Z2Q202dXZiTnQxMDdiWTk0TlJl?=
 =?utf-8?B?Qk1MejFCbEhIZVlVU3BkYy81ajFvQUZPdllsdjZYU3RKWXlvbi9CQnF4QmRS?=
 =?utf-8?B?eUFTa3ZmNktPQmhyQ2Vua3BlTEUvODdmWk9KYmJiUmlRKzEzeVFPK3pvd3Qy?=
 =?utf-8?B?YUZXTnhFOEs1ZFZXaWJmRzM3bjNlYXFSWGxiQ09hUWtSa1ZKSE92c3hHVHVL?=
 =?utf-8?B?Y0x6dVRKdnNKRTJKKzBpb3VaTkxCYU5XM0V0OUQ5TXQ3bVpDZXZiZktSK1Bo?=
 =?utf-8?B?akFVSTg3NlNIbHlxdnAzalFIenZMNkFjNElYbklZUzNWRVdnUFJNWGJjUnBs?=
 =?utf-8?B?S0RQQytkWDhXZG95MUNoS3JYdGJlL0E2V3laelZiWXZyU1ZFQ1NQMjdRUVJt?=
 =?utf-8?B?ancvQUFJakZscUR3bmVkYlkvamtOcWwvRkpQRmdVK3FYbE5rakJaeHJ5Undz?=
 =?utf-8?B?L2xwRGhBd3NLcXF2YUpwOC9peXoyUUxqdUIyTjlBNlFUb3VnNFpNYXhETHE1?=
 =?utf-8?B?Y3RtaDNqRkUybUNxeHRpOWxuZW1qMVRXT0I2dUNjUjU3bVlzcmFGV3lJL3ln?=
 =?utf-8?B?Mi9DY3BtUmRLbFN5Nk9KRUF2YU05ZjNmbFFSN2FJS090bmRIaThPdkVmWnE2?=
 =?utf-8?B?TG83bTJjM2lrR3cwRmoxanc0K0tvbmJFL25aRHVaSEZmem9YSzJRd09KR09Q?=
 =?utf-8?B?b3FIbUljOUxXM3g1TVVaQWNpSkIrUmwzWTVEVWhOK3JreXBXYmF0ZmFFbTVV?=
 =?utf-8?B?SHJhSmNNQlNkR29UK2pkNmMxUXdXNjExdEtlRHJCTGd1RS9VanRvNnEyYktp?=
 =?utf-8?B?TndpUUNnbW9pUkpuWW1rNUI0MTd6eXUyWG5YL1FWdjk3SmpEcERsTWJnbk15?=
 =?utf-8?B?aWhHeFlraEhnSFJqUFN1eUhubkZKUlRXemRtVG0zcVdWeUREbGRUekFmcjRT?=
 =?utf-8?B?Y2lZMGlTbUNvT2lZcW9rN0R3OFB2UG9vTi9KLzJXZHdkeDRJZkJZM1NObkFJ?=
 =?utf-8?B?TUJFMmtya1BUNGxIWi9hNmwxY0FjNlplTzBDWXNSVkViSjduQlFTdFAwRlVH?=
 =?utf-8?B?YUZhNURYVnE5Mk1iRVdkSEV1YTdCOWw2RmZDZ1NDZUEzVkhLMmpkMmpSa2lw?=
 =?utf-8?B?SG9PS1prR1E4bzYrV1Y4RWRhVDFCQU1MMmVNbE92SUNqMVhzU0FkR2xURGli?=
 =?utf-8?B?aVVuVStveU5TQ1NQdGVQa2YyNWhocHREa3R4R0NidUk3em5ZMEhjd29zODVs?=
 =?utf-8?B?S0liQW1rK2h0MURRa00xLzZUTS9jVXlXK3hjbXNNSnJ1SmdnbG1CUHNJK1Zs?=
 =?utf-8?B?cXE5V090NVFLSW9rSlVWdU1Pa0E4bDBlSUJQcGVtcXZqSmNvRjlOSFdHb2pw?=
 =?utf-8?Q?xJBkuFt7PY/ReJqU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 779b4171-c5cd-4402-fac5-08da2a2f34c7
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 22:25:46.4946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O7lEWRXoqGSzGscaMZWLhdpSem2r176eqqtQAiFnWjDAgGNra/wmAuZTz4ZKwPLdmOyJ1jPDnj6Q3oD/WoHz3S5cZ5ApNgzo4EmuJVpNQrQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5625
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-29_08:2022-04-28,2022-04-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204290119
X-Proofpoint-ORIG-GUID: n6uDPHv0HCE4EXJNLMHQXfznGGp7wYD0
X-Proofpoint-GUID: n6uDPHv0HCE4EXJNLMHQXfznGGp7wYD0


On 4/28/22 3:53 AM, Juergen Gross wrote:
> Update the Xen PV-scsi interface from the Xen tree and adapt the
> related drivers to use the new definitions.
>
> Harden the frontend driver to be no longer vulnerable to a malicious
> backend.
>
> Juergen Gross (4):
>    xen: update vscsiif.h
>    xen/scsiback: use new command result macros
>    xen/scsifront: use new command result macros
>    xen/scsifront: harden driver against malicious backend
>
>   drivers/scsi/xen-scsifront.c       | 168 ++++++++++++++++++++++-------
>   drivers/xen/xen-scsiback.c         |  82 +++++++++++++-
>   include/xen/interface/io/vscsiif.h | 133 ++++++++++++++++++++++-
>   3 files changed, 340 insertions(+), 43 deletions(-)


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 22:29:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 22:29:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317844.537366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZ7W-0001Ir-Bn; Fri, 29 Apr 2022 22:29:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317844.537366; Fri, 29 Apr 2022 22:29:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZ7W-0001Ik-8V; Fri, 29 Apr 2022 22:29:50 +0000
Received: by outflank-mailman (input) for mailman id 317844;
 Fri, 29 Apr 2022 22:29:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkZ7V-0001Ia-Dy; Fri, 29 Apr 2022 22:29:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkZ7V-0002JQ-Ae; Fri, 29 Apr 2022 22:29:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkZ7U-00030W-Vr; Fri, 29 Apr 2022 22:29:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkZ7U-00089C-VR; Fri, 29 Apr 2022 22:29:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sWFUFfw2nOUxpRCqNa3IHqB8ZnBhIWaGGIrZhwsuiHQ=; b=c9uvRE3bqZFoBO5NfvZIoZd2Lo
	qBrhSMoPyFpVR9AywY5yPL3cN2NpOy5Yeo5fmyoMvZ1qQ4NsbwgXgxC3MuCNHD0hTJaxmELSH2wG6
	BpFb2P3UdmxW6vMZiWLqZvyRs4x1lytbLiArUKuog1MXeFHbM79M3zMc3nH+4ICckw4o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169885-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169885: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Apr 2022 22:29:48 +0000

flight 169885 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169885/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  704 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   25 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 22:36:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 22:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317852.537377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZDm-0002kG-1m; Fri, 29 Apr 2022 22:36:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317852.537377; Fri, 29 Apr 2022 22:36:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZDl-0002k9-UV; Fri, 29 Apr 2022 22:36:17 +0000
Received: by outflank-mailman (input) for mailman id 317852;
 Fri, 29 Apr 2022 22:36:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BV3H=VH=igalia.com=gpiccoli@srs-se1.protection.inumbo.net>)
 id 1nkZDi-0002k3-Fa
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 22:36:17 +0000
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c461767e-c80c-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 00:36:11 +0200 (CEST)
Received: from [179.113.53.197] (helo=[192.168.1.60])
 by fanzine2.igalia.com with esmtpsa 
 (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim)
 id 1nkZD8-0003TG-7D; Sat, 30 Apr 2022 00:35:38 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c461767e-c80c-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
	s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=KYNDBRYGzikXjzeP27ZJ4t/kgY9V1S1pNOCPI8BnGe8=; b=JT0K6BBCWKsaQymCLnJQaj/kvq
	7Y1QKfar8fCW1mBanEmBmavL+D5scKDYAiv+Of/1HRFoX5MBCl5YZC28TmWOdUUkF79M5XuV0xuXA
	v1gbxygEk8ExNgZKIAJmst62yXS49qdhdclQ0HpxXcHSkInmueEoQ8sxt8GK1dgkp3lrFANactIr6
	owme4UXa4bPRXwJl27nOJHEpmMOv8h6kOal3gO6YkUDEDSWCgod9VcuYizHGTaTCXAhQFrHVOF1Fo
	gyvc6I1Xl1Nz4QEoDGGy6DcOx8hQdBZ3SL8vuhOA2s2+e+h8l4Dvo0+AMgZTV5lbKle4rwJcb9Bd/
	P9qftm1A==;
Message-ID: <2787b476-6366-1c83-db80-0393da417497@igalia.com>
Date: Fri, 29 Apr 2022 19:35:09 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and
 refactor Hyper-V panic notifiers
Content-Language: en-US
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
 "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
 "bhe@redhat.com" <bhe@redhat.com>, "pmladek@suse.com" <pmladek@suse.com>,
 "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "bcm-kernel-feedback-list@broadcom.com"
 <bcm-kernel-feedback-list@broadcom.com>,
 "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
 "linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
 "linux-arm-kernel@lists.infradead.org"
 <linux-arm-kernel@lists.infradead.org>,
 "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
 "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
 "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
 "linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
 "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
 "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
 "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
 "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
 "linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
 "linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 "openipmi-developer@lists.sourceforge.net"
 <openipmi-developer@lists.sourceforge.net>,
 "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
 "sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "x86@kernel.org" <x86@kernel.org>,
 "kernel-dev@igalia.com" <kernel-dev@igalia.com>,
 "kernel@gpiccoli.net" <kernel@gpiccoli.net>,
 "halves@canonical.com" <halves@canonical.com>,
 "fabiomirmar@gmail.com" <fabiomirmar@gmail.com>,
 "alejandro.j.jimenez@oracle.com" <alejandro.j.jimenez@oracle.com>,
 "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
 "arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
 "corbet@lwn.net" <corbet@lwn.net>,
 "d.hatayama@jp.fujitsu.com" <d.hatayama@jp.fujitsu.com>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 "dyoung@redhat.com" <dyoung@redhat.com>,
 "feng.tang@intel.com" <feng.tang@intel.com>,
 "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
 "hidehiro.kawai.ez@hitachi.com" <hidehiro.kawai.ez@hitachi.com>,
 "jgross@suse.com" <jgross@suse.com>,
 "john.ogness@linutronix.de" <john.ogness@linutronix.de>,
 "keescook@chromium.org" <keescook@chromium.org>,
 "luto@kernel.org" <luto@kernel.org>,
 "mhiramat@kernel.org" <mhiramat@kernel.org>,
 "mingo@redhat.com" <mingo@redhat.com>,
 "paulmck@kernel.org" <paulmck@kernel.org>,
 "peterz@infradead.org" <peterz@infradead.org>,
 "rostedt@goodmis.org" <rostedt@goodmis.org>,
 "senozhatsky@chromium.org" <senozhatsky@chromium.org>,
 "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
 "tglx@linutronix.de" <tglx@linutronix.de>,
 "vgoyal@redhat.com" <vgoyal@redhat.com>, vkuznets <vkuznets@redhat.com>,
 "will@kernel.org" <will@kernel.org>, Andrea Parri <parri.andrea@gmail.com>,
 Dexuan Cui <decui@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 KY Srinivasan <kys@microsoft.com>, Stephen Hemminger
 <sthemmin@microsoft.com>, Tianyu Lan <Tianyu.Lan@microsoft.com>,
 Wei Liu <wei.liu@kernel.org>
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-17-gpiccoli@igalia.com>
 <PH0PR21MB30250C9246FFF36AFB1DFDECD7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <PH0PR21MB30250C9246FFF36AFB1DFDECD7FC9@PH0PR21MB3025.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Michael, first of all thanks for the great review, much appreciated.
Some comments inline below:

On 29/04/2022 14:16, Michael Kelley (LINUX) wrote:
> [...]
>> hypervisor I/O completion), so we postpone that to run late. But more
>> relevant: this *same* vmbus unloading happens in the crash_shutdown()
>> handler, so if kdump is set, we can safely skip this panic notifier and
>> defer such clean-up to the kexec crash handler.
> 
> While the last sentence is true for Hyper-V on x86/x64, it's not true for
> Hyper-V on ARM64.  x86/x64 has the 'machine_ops' data structure
> with the ability to provide a custom crash_shutdown() function, which
> Hyper-V does in the form of hv_machine_crash_shutdown().  But ARM64
> has no mechanism to provide such a custom function that will eventually
> do the needed vmbus_initiate_unload() before running kdump.
> 
> I'm not immediately sure what the best solution is for ARM64.  At this
> point, I'm just pointing out the problem and will think about the tradeoffs
> for various possible solutions.  Please do the same yourself. :-)
> 

Oh, you're totally right! I just assumed ARM64 would the the same, my
bad. Just to propose some alternatives, so you/others can also discuss
here and we can reach a consensus about the trade-offs:

(a) We could forget about this change, and always do the clean-up here,
not relying in machine_crash_shutdown().
Pro: really simple, behaves the same as it is doing currently.
Con: less elegant/concise, doesn't allow arm64 customization.

(b) Add a way to allow ARM64 customization of shutdown crash handler.
Pro: matches x86, more customizable, improves arm64 arch code.
Con: A tad more complex.

Also, a question that came-up: if ARM64 has no way of calling special
crash shutdown handler, how can you execute hv_stimer_cleanup() and
hv_synic_disable_regs() there? Or are they not required in ARM64?


>>
>> (c) There is also a Hyper-V framebuffer panic notifier, which relies in
>> doing a vmbus operation that demands a valid connection. So, we must
>> order this notifier with the panic notifier from vmbus_drv.c, in order to
>> guarantee that the framebuffer code executes before the vmbus connection
>> is unloaded.
> 
> Patch 21 of this set puts the Hyper-V FB panic notifier on the pre_reboot
> notifier list, which means it won't execute before the VMbus connection
> unload in the case of kdump.   This notifier is making sure that Hyper-V
> is notified about the last updates made to the frame buffer before the
> panic, so maybe it needs to be put on the hypervisor notifier list.  It
> sends a message to Hyper-V over its existing VMbus channel, but it
> does not wait for a reply.  It does, however, obtain a spin lock on the
> ring buffer used to communicate with Hyper-V.   Unless someone has
> a better suggestion, I'm inclined to take the risk of blocking on that
> spin lock.

The logic behind that was: when kdump is set, we'd skip the vmbus
disconnect on notifiers, deferring that to crash_shutdown(), logic this
one refuted in the above discussion on ARM64 (one more Pro argument to
the idea of refactoring aarch64 code to allow a custom crash shutdown
handler heh). But you're right, for the default level 2, we skip the
pre_reboot notifiers on kdump, effectively skipping this notifier.

Some ideas of what we can do here:

I) we could change the framebuffer notifier to rely on trylocks, instead
of risking a lockup scenario, and with that, we can execute it before
the vmbus disconnect in the hypervisor list;

II) we ignore the hypervisor notifier in case of kdump _by default_, and
if the users don't want that, they can always set the panic notifier
level to 4 and run all notifiers prior to kdump; would that be terrible
you think? Kdump users might don't care about the framebuffer...

III) we go with approach (b) above and refactor arm64 code to allow the
custom crash handler on kdump time, then [with point (I) above] the
logic proposed in this series is still valid - seems more and more the
most correct/complete solution.

In any case, I guess we should avoid workarounds if possible and do the
things the best way we can, to encompass all (or almost all) the
possible scenarios and don't force things on users (like enforcing panic
notifier level 4 for Hyper-V or something like this...)

More feedback from you / Hyper-V folks is pretty welcome about this.


> 
>> [...]
> The "Fixes:" tags imply that these changes should be backported to older
> longterm kernel versions, which I don't think is the case.  There is a
> dependency on Patch 14 of your series where PANIC_NOTIFIER is
> introduced.
> 

Oh, this was more related with archeology of the kernel. When I'm
investigating stuff, I really want to understand why code was added and
that usually require some time git blaming stuff, so having that pronto
in the commit message is a bonus.

But of course we don't need to use the Fixes tag for that, easy to only
mention it in the text. A secondary benefit by using this tag is to
indicate this is a _real fix_ to some code, and not an improvement, but
as you say, I agree we shouldn't backport it to previous releases having
or not the Fixes tag (AFAIK it's not mandatory to backport stuff with
Fixes tag).


>> [...]
>> + * intrincated is the relation of this notifier with Hyper-V framebuffer
> 
> s/intrincated/intricate/

Thanks, fixed in V2!


>
>> [...]
>> +static int hv_panic_vmbus_unload(struct notifier_block *nb, unsigned long val,
>>  			      void *args)
>> +{
>> +	if (!kexec_crash_loaded())
> 
> I'm not clear on the purpose of this condition.  I think it means
> we will skip the vmbus_initiate_unload() if a panic occurs in the
> kdump kernel.  Is there a reason a panic in the kdump kernel
> should be treated differently?  Or am I misunderstanding?

This is really related with the point discussed in the top of this
response - I assumed both ARM64/x86_64 would behave the same and
disconnect the vmbus through the custom crash handler when kdump is set,
so worth skipping it here in the notifier. But that's not true for ARM64
as you pointed, so this guard against kexec is really part of the
decision/discussion on what to do with ARM64 heh

Cheers!


From xen-devel-bounces@lists.xenproject.org Fri Apr 29 23:12:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 23:12:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317874.537394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZn4-0006uB-QA; Fri, 29 Apr 2022 23:12:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317874.537394; Fri, 29 Apr 2022 23:12:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZn4-0006u4-Ln; Fri, 29 Apr 2022 23:12:46 +0000
Received: by outflank-mailman (input) for mailman id 317874;
 Fri, 29 Apr 2022 23:12:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GAsh=VH=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nkZn3-0006ty-NS
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 23:12:45 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df78cc84-c811-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 01:12:44 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23TK7lpg025802;
 Fri, 29 Apr 2022 23:12:26 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmb1n030y-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Apr 2022 23:12:26 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23TNAfD8011477; Fri, 29 Apr 2022 23:12:24 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3fp5yqpsch-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Apr 2022 23:12:24 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BYAPR10MB3240.namprd10.prod.outlook.com (2603:10b6:a03:155::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr
 2022 23:12:22 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.026; Fri, 29 Apr 2022
 23:12:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df78cc84-c811-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=Lz98BJlElMHq36e9Hz8KKUh019n0TcAOzbEM6bFURX8=;
 b=V5E/9fkBs5tswRDHdco2SnGsBR/ZPlrR3WM8XcqvZKsGkxEPCSjaTvwz1FYY4f8WqiEy
 l6jqnqgT6OVASlnWNd9y78QDUdCF34KREwitDunagX4pFSpCwZKO7Qwo7oH8j4bY+1vK
 Lqu/jQWkNFw5P3UmAJJS8ksXghB5nPMlC22kR0NdfeT5twx+/Iy7EMmvPiQiHY0vTPAu
 9iMp75P0+Xrg0OWkfccstZlFSIBmi7+DBqenT7Ea9rtajOAjiu4Kw3OnpB4URiFcuPng
 2xVAxFRheZvERuYBqdZ/ZOI5le+geUgmYhF7piBtTzOuL8moUmzb8S33fNr3xs8BEMQi 2Q== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PJPlUdTVNd+w9JuSiacPs8W06oKuGD5vvxr207QIpztF9/bIx1sPtv1vfba+hFoQHHGQneKR59o72H5qoLsMpfdj1ywROjQYnUJJSOGOHBocfPDwpW9RqWtfbTC8uwOzB2CwIY/T5S+hx9X8cFWWAyTQu6kOiOfJ1ktqAMqmFwW1xr/GD9fm2Wo8M0GFn7QpcfoXf7gF1twQHBQmbxeS+OCh0Yo64/O4TjezxFZO/f3eQphpY7xdxM02leF85lq7naS+q4vMo5uxlTnffGZEeTyFiJgZxmIHh1HEXXxmEsPgaGcjkWTXrWY6/wBz8w0yKuT02WeZsKpZ9OXS0j3xGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lz98BJlElMHq36e9Hz8KKUh019n0TcAOzbEM6bFURX8=;
 b=RmXt58etNZcpQyQYnbr9X/qTx2vvBYV33ee7vrDed4ktaEY4neLl0nD8MKv97/0yaAKUQ9uBicHLVqKR7Oe3ADmIgf2PmgUcdOKHC4D1XnNUosC/p8A08wqlhw4XH8jFhZhbGDXP/NGMSquYp5ShGam8yC8ugdNLDCHLAuJ7QvsAbkvXyV9kIgt9ligBwXIgBVyUAaCucqUM2WNK8hJtMxoICHlSHgdCVlNHUMxds78TwuNc0jrLyoqfa2KZ24lQ86/OPJElrFQN/jpOhZIJdnVwKqPry2uyCyJwcSZA0QvcZ3N9DG27cX9pt4RyUIPSUKeus9NxpoFzRgx8EygIGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Lz98BJlElMHq36e9Hz8KKUh019n0TcAOzbEM6bFURX8=;
 b=uHDHNaS+090jkGyQaixWzSXbrbarIZBiAAJJsTMSVeOJx/YjS1MCmdDG1HPmKxqhy+EHVa8XJNQYp37jNMz0Fk3f9f1V4NhDU+kfBH9QDmE0lJ9ZAj52Qa7N1Opzylxme59Jl1AOiyaEYvr2TSh+bh46cI+o4w8/eJoUn3F5dc4=
Message-ID: <41c2483c-ab54-41be-7815-9d4a98e0249e@oracle.com>
Date: Fri, 29 Apr 2022 19:12:19 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, jgross@suse.com,
        xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux-foundation.org, Rahul Singh <Rahul.Singh@arm.com>
References: <20220423171422.1831676-1-hch@lst.de>
 <alpine.DEB.2.22.394.2204261605420.915916@ubuntu-linux-20-04-desktop>
 <20220428132737.GA13999@lst.de>
 <alpine.DEB.2.22.394.2204281449060.915916@ubuntu-linux-20-04-desktop>
 <27d39d5a-3b79-bdda-b7e4-f4477667919f@oracle.com>
 <alpine.DEB.2.22.394.2204281548320.915916@ubuntu-linux-20-04-desktop>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <alpine.DEB.2.22.394.2204281548320.915916@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7PR18CA0018.namprd18.prod.outlook.com
 (2603:10b6:806:f3::10) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54e65ddd-6345-4410-bf6b-08da2a35b735
X-MS-TrafficTypeDiagnostic: BYAPR10MB3240:EE_
X-Microsoft-Antispam-PRVS: 
	<BYAPR10MB3240369FA95AF7066109C0568AFC9@BYAPR10MB3240.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	pcdIrQ+QN9t/dKPwagQLm6siAUG4cTr6Jr8VXBYipTAnvDOUdQt33pUc6qkRr7836lIgipEwkJw1PbmQour2qD/kh+0LkXt8EK+QURy/8c3OOe7nJ2EhD2gq3fmuSXecCy7W0Ai+N8OD8FP2JqbmwBHH9SYue42UkqauCBpAFuLkPFyKxkATbS2+dAAD+Qsvw7yDJAtqRpdYPRsqHcZ9J5phKofIut4FPuFj1o2XF+BIt46hrXuZ8w4VwYLMbyzlw7Br75n6/6bstFHwKKaQNp02tDv0dUxdrPhbANSio9vYiQLbbWZ7eaZSatynzqbrKdF/FfIVr+z7aK5I4PFdiqX1xI9vZQn0flGqnJ6AEXrbilFcXOUo3Fz+9fSzts+HwcMYjGBB7+EyEJYgAn3QHQjvBDSIs/AaDDTt+BSVffnZSB20XiKpx6bFsKZEQ7cqwIGLbA3bLW//g3dAGW0pVatD9tayDFY0DwNvC8Dd/QatFqr6DVNoML/HGWawKa4a9vXJs9zMmLAaMEQYg/uIjwLpYGfuRtwuSma5MRfPh4lWasR78hUsTFYypmA9naBNYwxnh/Z1ayKkT5VETp4pzKbzv90vb0UfvbW+kj5ksHGn2FLynD94veLzJpid/82A4FP1II12m/cvUOFWNFC+K+HsfL+j0E7ioAitV7UxJj24UtPpx1s/z6xz2bak06mR4+ztWSyIlTFG4+ZQq/ZuFyJjpG/CyiiaYwnHIc42U9144ikh54YC8Un/y7BZDsBG
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(36756003)(2906002)(38100700002)(5660300002)(53546011)(54906003)(6916009)(316002)(6486002)(508600001)(8676002)(31686004)(26005)(83380400001)(86362001)(6506007)(6512007)(6666004)(8936002)(44832011)(66476007)(66556008)(4326008)(2616005)(186003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?aFJhWmJOVnIxLzZzelFHNzBkemp3QjBnSUJwN0ViQnhxcXAwWXNQVG9DTS8x?=
 =?utf-8?B?MWFFQkFiYnNHSUhtclFQVzZCQmJrRWpacFB1ZllvR3hxZ3o4cCs1WlhHUndy?=
 =?utf-8?B?SDA1WmlmUnhjUWR3eGJrbCtUUUNTWlJzeEtOQzA0OWN1Z2xicVNHYUgrWnBM?=
 =?utf-8?B?UWFMbkExWHI0S1B2OGdNL0xHaWNNaThMU0lpYXhQSmVsL2k1OXBGOXFGdGdQ?=
 =?utf-8?B?c3BCOVJZUVBPYThRc2xyd1lpZmJpOGNtK0svRTZ6M2F0QmFrMFZsTVhFbzRR?=
 =?utf-8?B?OEZ2eUhhKzViT2ZlMHpkTEtSTWhCSEo2TUpVcjY2MnIzVlpkQ0VPRGdaZmlW?=
 =?utf-8?B?VTlBM3hpaHdmdWo1SXBReFZPdWtRbk9HeEZMcWQwakx0YU1UQWpDR2dML0gy?=
 =?utf-8?B?R21XODlQSGl4WFFmbGJReVREUDErOWRJbWdsOHQvazZiR3RBWDR4Q0Z5WXpo?=
 =?utf-8?B?UmVsYTBVNDc4VHVZREtIRFZZT1VJOHlsYXE2VkVRcTJsYmdGcXlwY21TTnB0?=
 =?utf-8?B?UHkxODdTektsVzVEMHUwWCs0a2JUdFFNYytKdDV0S216YSszL1lpdlg2b3lR?=
 =?utf-8?B?Tld2T1lmTXVObGx3akhiYWpMOTlpS2tFUkVBOWo2UkRPNHNTMW9wVVExdmJm?=
 =?utf-8?B?c0dacXdpdHdNeGR2c1ZWN2UwU3o1VmtGUUQzVkJoRHN2Q3VEcU14dmpnejlx?=
 =?utf-8?B?NC95dTBHeGswV2kzUkJ6QzRnVDA1SFJpQndubTQvcVRiazRaazkxRDN6Z2Zt?=
 =?utf-8?B?RXYzZWxGUFJLZmU3cFU4WHVhK1JRVit1WTA0Y09OamNYV2g3NWc1L0NBbFBr?=
 =?utf-8?B?a2ZWNjc4NndMRmt5VDdjQmYvcHRNN0tIalJKZnc4VVdrYy9Na3RNTVRYY0dv?=
 =?utf-8?B?TXlYNGNIMHZVMlRMamx5M0lZcWNzeFRtdUxFZXh5dURiaUdtRGZ4RzBQUWtX?=
 =?utf-8?B?V3dHNHdzM2l5Tzd0akQ5ejN2OHczUlFweDF4TThveEhHc2JWcWpJbldJTDl3?=
 =?utf-8?B?ZzlIbFAyZGVJTHpOWC93dThKZUxtQ29Vd3p6dkVGbFF5NzRHZDVZbW0wTnIy?=
 =?utf-8?B?WEw5QUp1T3Zad0o4WVdKOWZqV3oxajZWa1VuUmdLYm5NR1NGalhaZjBoK2VC?=
 =?utf-8?B?dFY3YzJBNFBQUkxwdnpMN2x6TmNxaXFLZzFwOVRBcmd0MU5NQVNWTE0yUGVu?=
 =?utf-8?B?WEFmajRwWXF0VUtOSVFnQnZxTU5NeVh2NXU5ZjVuNWJraU5YdmdXNW5Bd01u?=
 =?utf-8?B?Sjc1M0taZmgzRmVoR1lxL3B1VVV4YW5aQ0NHSnNTUXRMY1k5RUwvaWNQYThz?=
 =?utf-8?B?NE90N3JjOExleUFlamdSU3pSeHJHSEdQSjExWlVDTk1mclNGTExBU3c1K2ZS?=
 =?utf-8?B?Z0J2VDJZRWQ5MWh5eG9udUdIMk94YXh2UEg1THcwcWp5V1BLTjUya2V6bXFJ?=
 =?utf-8?B?TVFHek5RMkI4VUw2Wm83WXNQWUNZZzkySFdXRHBJOW9ER0hRbndNTGFuRDk0?=
 =?utf-8?B?Mkx1bFY1NFd3Y3hyYTljLzRzUmdxTHFDcjgrdkVYd0JpWW1XdHBMSmZPd2c4?=
 =?utf-8?B?d1AvTy9hbDBrTm00VDc5WnFzbVpnWFptcCtqb3Jyb3pzcWtUU3RvVXVxcGNE?=
 =?utf-8?B?QVhWM1NMRFVGVUtHRVM5TndQdFBNMjJLbC8zNWp1RFh6cTJZWi84Z3FRUlQ0?=
 =?utf-8?B?NVRBV2JWZWpSZWFaaW5YZ0M2UEE1eWd5RjZBWDFQTkVqYm1EaHFKUEV0Mmk2?=
 =?utf-8?B?d3JGNFZnSGkySGM3bm5VRmlMVVQvL3RiTGYrNzFUMTlWZjcxRS9oZDYwM0F0?=
 =?utf-8?B?UDJUR3p2Wk0rZ3NjUzR5WnNPM0xhMTNKM0NIV2hCL0FhU2VobWZvRE4yb1Nh?=
 =?utf-8?B?N3RMUzhFNGpPV1VFNEV6VnlPay9nNW1qWkRJSHVNQWRWNzFWTm4wREhsb2p0?=
 =?utf-8?B?d2JYYW9ud0h5YmkzVGNIN1BuR051NWtTeE44YTlqUTNUeSs0d3FEQUtSMkVs?=
 =?utf-8?B?OVRaMkNSYUQ3dlQ1WEtJakVqalp6clMwNWlMbkJsT3FRTGpXdkVPZU14NDhz?=
 =?utf-8?B?MzNmdURNajZmK3ByTTh6WWpuQVZ1V2h1NjNNeStkVzBkYnQvZ28rY1Erb3Fl?=
 =?utf-8?B?Q3kxdWxkUnRBcURvR2pOKzFIRm8wakdkQkp4SGY4ei9UbzFqMlhlY0VpN2tm?=
 =?utf-8?B?UXF4ejd2R2x3cHhaenNtcDgvT2IvT3lkUERaa1d2cDdxbTVjWnJwclp4YmFu?=
 =?utf-8?B?dWlhZSt3Lzl3MDhrSUxqRTc4RGsxcVdOeGpSN0VGOUpUZU1MUXFHRFdHd1Zi?=
 =?utf-8?B?QlRiL2tRTFlMcTF6Nit4Wm5HNURUMnovUi9JRU5IaUlPTlBhSlFYQ3A1QjBs?=
 =?utf-8?Q?UiEUmnlu/p6ljwDc=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54e65ddd-6345-4410-bf6b-08da2a35b735
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 23:12:22.2982
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DE7kAFmT7ScE/HH2p0uJ6vvZ0fcQzg3edZGnLK3WI39PVa+gDGjCEG7atH5KBt7LzoQQu9VAigJ0fRY2rX9G0CS6t8bLiT0k/3S6i2Y1sCU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3240
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-29_08:2022-04-28,2022-04-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=969 mlxscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204290124
X-Proofpoint-GUID: 3RMxt3kjG13ZLCVJQXzd6Ph-dzYDBUHx
X-Proofpoint-ORIG-GUID: 3RMxt3kjG13ZLCVJQXzd6Ph-dzYDBUHx


On 4/28/22 6:49 PM, Stefano Stabellini wrote:
> On Thu, 28 Apr 2022, Boris Ostrovsky wrote:
>> On 4/28/22 5:49 PM, Stefano Stabellini wrote:
>>> On Thu, 28 Apr 2022, Christoph Hellwig wrote:
>>>> On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote:
>>>>>> Reported-by: Rahul Singh <Rahul.Singh@arm.com>
>>>>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>>> Do you want to take this through the Xen tree or should I pick it up?
>>>> Either way I'd love to see some testing on x86 as well.
>>> I agree on the x86 testing. Juergen, Boris?
>>>
>>> I'd say to take this patch via the Xen tree but Juergen has just sent a
>>> Xen pull request to Linux last Saturday. Juergen do you plan to send
>>> another one? Do you have something else lined up? If not, it might be
>>> better to let Christoph pick it up.
>>
>> We don't have anything pending.
>>
>>
>> I can test it but at best tomorrow so not sure we can get this into rc5. Do
>> you consider this an urgent fix or can we wait until 5.19? Because it's a bit
>> too much IMO for rc6.
> On one hand, Linux doesn't boot on a platform without this fix. On the
> other hand, I totally see that this patch could introduce regressions on
> x86 so I think it is fair that we are careful with it.
>
>  From my point of view, it might be better to wait for 5.19 and mark it
> as backport.


No problems uncovered during testing.


-boris



From xen-devel-bounces@lists.xenproject.org Fri Apr 29 23:15:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Apr 2022 23:15:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317882.537405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZpw-0007Yg-E8; Fri, 29 Apr 2022 23:15:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317882.537405; Fri, 29 Apr 2022 23:15:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkZpw-0007YZ-9M; Fri, 29 Apr 2022 23:15:44 +0000
Received: by outflank-mailman (input) for mailman id 317882;
 Fri, 29 Apr 2022 23:15:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FlFr=VH=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nkZpu-0007YT-TY
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 23:15:42 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 493fc147-c812-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 01:15:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 15EE1623B1;
 Fri, 29 Apr 2022 23:15:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2CB2C385A4;
 Fri, 29 Apr 2022 23:15:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 493fc147-c812-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1651274139;
	bh=elqH2Ff8eBloOqEP96qiH80wO36PP21s6y+XTLp+enQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZHx10dC2uYiU9hpRuYyFhaRjHDl2mx8JQrxkHwwfcxcU8kIjVZwHY6oPAx5ruUqMm
	 9LGLGarvn440A377DUk+FLghxuZLqScNQXrYOuaoR4yZaGTm8Yo2+VoJ0l6a/tR7hf
	 E6QYw0PtTF7Yty5mlkrLvfnn7GtN9kC4B1fKJHohrefvOVZLMXe+jzQjTvokzWTeOi
	 4Wq5k3+9NZa+6ZFkkUF/URXKfmbgkR6qBM1ASjZa6eH/kxjqkV94qR+ywfCQI+PRug
	 yPfaiPT49IYBy3Z9hqelOY/kPqi7s6b3fNKLXQh6AfbHOOSuRZ9g3uoLlb7ALxyyql
	 3cUqFyTUpUMNA==
Date: Fri, 29 Apr 2022 16:15:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Christoph Hellwig <hch@lst.de>, jgross@suse.com, 
    xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, 
    iommu@lists.linux-foundation.org, Rahul Singh <Rahul.Singh@arm.com>
Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm
In-Reply-To: <41c2483c-ab54-41be-7815-9d4a98e0249e@oracle.com>
Message-ID: <alpine.DEB.2.22.394.2204291615130.1947187@ubuntu-linux-20-04-desktop>
References: <20220423171422.1831676-1-hch@lst.de> <alpine.DEB.2.22.394.2204261605420.915916@ubuntu-linux-20-04-desktop> <20220428132737.GA13999@lst.de> <alpine.DEB.2.22.394.2204281449060.915916@ubuntu-linux-20-04-desktop> <27d39d5a-3b79-bdda-b7e4-f4477667919f@oracle.com>
 <alpine.DEB.2.22.394.2204281548320.915916@ubuntu-linux-20-04-desktop> <41c2483c-ab54-41be-7815-9d4a98e0249e@oracle.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 29 Apr 2022, Boris Ostrovsky wrote:
> On 4/28/22 6:49 PM, Stefano Stabellini wrote:
> > On Thu, 28 Apr 2022, Boris Ostrovsky wrote:
> > > On 4/28/22 5:49 PM, Stefano Stabellini wrote:
> > > > On Thu, 28 Apr 2022, Christoph Hellwig wrote:
> > > > > On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote:
> > > > > > > Reported-by: Rahul Singh <Rahul.Singh@arm.com>
> > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > > > > Do you want to take this through the Xen tree or should I pick it up?
> > > > > Either way I'd love to see some testing on x86 as well.
> > > > I agree on the x86 testing. Juergen, Boris?
> > > > 
> > > > I'd say to take this patch via the Xen tree but Juergen has just sent a
> > > > Xen pull request to Linux last Saturday. Juergen do you plan to send
> > > > another one? Do you have something else lined up? If not, it might be
> > > > better to let Christoph pick it up.
> > > 
> > > We don't have anything pending.
> > > 
> > > 
> > > I can test it but at best tomorrow so not sure we can get this into rc5.
> > > Do
> > > you consider this an urgent fix or can we wait until 5.19? Because it's a
> > > bit
> > > too much IMO for rc6.
> > On one hand, Linux doesn't boot on a platform without this fix. On the
> > other hand, I totally see that this patch could introduce regressions on
> > x86 so I think it is fair that we are careful with it.
> > 
> >  From my point of view, it might be better to wait for 5.19 and mark it
> > as backport.
> 
> 
> No problems uncovered during testing.

Great! Christoph you can go ahead and pick it up in your tree if you are
up for it.


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 00:36:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 00:36:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317893.537422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkb6H-0007Ts-HZ; Sat, 30 Apr 2022 00:36:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317893.537422; Sat, 30 Apr 2022 00:36:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkb6H-0007Tl-EM; Sat, 30 Apr 2022 00:36:41 +0000
Received: by outflank-mailman (input) for mailman id 317893;
 Sat, 30 Apr 2022 00:36:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkb6F-0007Tb-W6; Sat, 30 Apr 2022 00:36:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkb6F-00053i-Nl; Sat, 30 Apr 2022 00:36:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkb6F-0001xS-Dg; Sat, 30 Apr 2022 00:36:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkb6F-0004u3-DF; Sat, 30 Apr 2022 00:36:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wWhhv9abNlx7ArzMcvcO6HKKnZ8CMZNUe05FiZFNyNU=; b=nyP9OmrdrmesbKnSsol4+8LtD+
	tq6W4i4+usgenbUP4jP26DGBjA4mhA7Y/3Ehd2+ujVpQ4EcNfIog1boTG1MajsAHgTX8ZEFUnuJN2
	vfJqWPADAlvfd8URO/Frh/5PkKiK/JyJ9VSEqC6FT0TAiB4qL3sqBRtyFGz8EWVAKdcE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169889-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169889: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 00:36:39 +0000

flight 169889 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169889/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  705 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   26 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 00:39:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 00:39:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317901.537432 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkb8c-00083i-VI; Sat, 30 Apr 2022 00:39:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317901.537432; Sat, 30 Apr 2022 00:39:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkb8c-00083b-SH; Sat, 30 Apr 2022 00:39:06 +0000
Received: by outflank-mailman (input) for mailman id 317901;
 Sat, 30 Apr 2022 00:39:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ySBZ=VI=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nkb8b-00083V-Nl
 for xen-devel@lists.xenproject.org; Sat, 30 Apr 2022 00:39:05 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eea57611-c81d-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 02:39:03 +0200 (CEST)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23TMK76T032115;
 Sat, 30 Apr 2022 00:38:58 GMT
Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta02.appoci.oracle.com [147.154.18.20])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmb107ava-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 30 Apr 2022 00:38:57 +0000
Received: from pps.filterd
 (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2)
 with SMTP id 23U0aF4k017882; Sat, 30 Apr 2022 00:38:56 GMT
Received: from nam02-bn1-obe.outbound.protection.outlook.com
 (mail-bn1nam07lp2047.outbound.protection.outlook.com [104.47.51.47])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id
 3fm7w8k0vv-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 30 Apr 2022 00:38:56 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by DM6PR10MB4396.namprd10.prod.outlook.com (2603:10b6:5:21e::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Sat, 30 Apr
 2022 00:38:54 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::4455:2c02:503:a182%8]) with mapi id 15.20.5186.028; Sat, 30 Apr 2022
 00:38:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eea57611-c81d-11ec-a405-831a346695d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=ecMtXW53/xzCpVSwp4tjdVjzK/KMTTlyprf6mBmeHCk=;
 b=FSMtcORG55gUE2qLXV0k3x92AvXgMIXLBfXcQrABOuOlUjSxtBeqIwcY0LnCFmLz+vt/
 Fde5/c0YsYqRzDT28Mcu5IV96wIxsofaZrmS1tg7wZZvEclEPHIFVB5Y3w+X591sd/wh
 ga56gZeDs3ANUPXDOfBbpxVaQd3AP89ymcb2Qcuy/f2gncZpd7lZGJ+UShhX258VPBPF
 DnE2kFGfND3PzutqPfocz+U2waUy/ltwVVObf+cjJ/TUfQt/9GK5FDPBHvrLXuA7sQRk
 ciighKhShBlsM0/+4dStaGwsdKScCGUQ6JfyzpowcbuBWJoy/F8aZR0B455NcNHIIRP9 RA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YSnQMKCrPdgJ54bqZCK47nHr7qx7eXIC0ijD+JWs5LrJ4Kt+Yqv5WEwuQGC0qY7VvVGTnfkmslCYO0kLIo8sXOBl9locPXWexz3qyKEgUWVyMbW3+1XrjHaU63DNZu+EL580is73E5IPFa1A23NpzcrB8IIg0d5sxRPVvN0C1ffNlSPHAnBei28Olpm5x3jJbktrle7kt94Zw1xaHj2MhroQ3VeTnqi0CGOxzY5q96ruTBy0PDt2f5wd3fJphXBWAfnupkiMOvb4kVcxtHeAXCVdlYLmsa0FpXYKiKjkgDQ50IuLt14UjMdvVxraG/J+2ruZnT4SmqM4i/ugiHPU+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ecMtXW53/xzCpVSwp4tjdVjzK/KMTTlyprf6mBmeHCk=;
 b=FYeK0CKYzLwEZTkPS60+jK+1uDIXHlzFuHkWTXRAajHb0/JvXm/lXB/d9uJRZrhb+f06rw/ySjG9sjIMMvJfx8HcUPFDfO0/MgeQEXMGs7EbTzpe0cpSAE5wGlfe/w8rns6UmKpXFCBf+5Zta0y5lcJ37BFXtNvBtl6YbHM7cizqJcJ9Zsj9flKJY9bQLQpC6LZoe2yEvN4ev9zA5rgvYp+20XVX4/BsaDbxL9v1I0C3VOmkREMxEKDWaWccn4TIzLLTnSIZxx8OffT53+pVupJQjOlc+fqlaK6JFw5OOR0G0xloB4uMBi31XukX0S5AQW5U3r0Zc+2DokNY/nRLiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ecMtXW53/xzCpVSwp4tjdVjzK/KMTTlyprf6mBmeHCk=;
 b=TlA+NaQ1v3t0TFm8499o0u9t/JyZbKWf3o2ofEsldhpt7+Fs27Wdse224aCmonktGu5JCTgS4ozW05kKAJyYlB4rUIyRfLoI1vY47hy4sQ8q8H/z1/joI8a3+zXXD6DJw8xlcWirk+FEw/S9XBAiZvgjaD/PvsjBeyWpy+oJYJU=
Message-ID: <e9c87df2-3677-52a9-1a17-1314ee3d9950@oracle.com>
Date: Fri, 29 Apr 2022 20:38:51 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [LINUX PATCH v3] xen: add support for initializing xenstore later
 as HVM domain
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
        xen-devel@lists.xenproject.org
Cc: Luca Miccio <lucmiccio@gmail.com>,
        Stefano Stabellini <stefano.stabellini@xilinx.com>, jgross@suse.com
References: <20220429211027.2034134-1-sstabellini@kernel.org>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220429211027.2034134-1-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA9PR13CA0137.namprd13.prod.outlook.com
 (2603:10b6:806:27::22) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c15e123f-4f74-4be6-193c-08da2a41cdf5
X-MS-TrafficTypeDiagnostic: DM6PR10MB4396:EE_
X-Microsoft-Antispam-PRVS: 
	<DM6PR10MB4396D4D34D61E9D683785A268AFF9@DM6PR10MB4396.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	za8RO77W8xI9olIDpWnSloZgHvR0x3B6vEVifNgL8gI0e3N8K/YH4B7jokBeSwIeedehBU+nObA2QRtE7LPajkqI4FyGwdB18G7Lp+t0wUwMpMHhxopRNjl+IOCmW6WwYpLO1gU/J7XKq7neO4OZrg/DCAVHXMK/6Y5J4mJK4zYpfIqH0dw4RRuiT+AKokqG5cE+G3A0oAS9zja2RwKJ8oDgwFF0DRzWJc9lL2NSpULz9DNxYfIciNju1PTqdLXc2picdV/V/awyHoPa7l9OFI5dUOsdrhAxUHE8ePj6LxrRoOQV8oopfzWX79DFH3L8Yb/RDUo0puMP6fgG8y8IbQVc2p9d2Uw0hqju/p5a6mj3HpZo0tS8kkoUzvtI0h3/aNGR+dtwzrRHqy2p3Q32Mg7iZ5nkJbn2tZisHWGUm4MfR+mOIJaCGX0Zpz2fXqDUbxQvaunxjVhLaMCo7SKf/mFEMjQhopLT3NSHP9UUlRFTcnQgTp+FsrTyRDaTl4ERSlk5iJ9jCM1t+7ssGjhsRg08X4FaIosNhpFxUEosAL868KqhKpzf8uWR/tqzpV99XWCswIvwzroYNkvB9KalUWmoXR3nXYvAApSfeVkZWEyT8e6FyIjm17f1SB3SfyBOSUd8S3fF1zexmT+kUUqqF3EboBBUWhuCD82nSGQ43B3jw/VVF1/CRCa6Dwd3EWWZVYgqjmF8ANuDo4WY78vMZyyjAc5jwSApmSWeFOVfnfLDC2BewGUODjN+9lVdUQRI
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(6486002)(508600001)(2906002)(2616005)(6512007)(6506007)(53546011)(26005)(38100700002)(6666004)(66476007)(316002)(31696002)(186003)(66556008)(66946007)(44832011)(5660300002)(36756003)(8936002)(54906003)(31686004)(83380400001)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?RWxLY3pCZXBDV2FXWlY2ekk2MGtZbkhuNFp3K3FKbnVwd2EwbVJFWU5xcitQ?=
 =?utf-8?B?OWVnc1puc1VpMktzcUhwZkg3b0oxZ3ZEeFl0QUFHZGtWMzRQbXMxTEJqUnEw?=
 =?utf-8?B?UWVtTGg3NDRSWE5rMk9GOHNEWnZVMUFWSVYrVEJOcFpYaC8vVS9IVmpyZHll?=
 =?utf-8?B?LzFNTkU2ejBrdmQxNEk3WkMremhnK0NGVEU4RGREWFJ2WWNCMjg4TFhuanQ4?=
 =?utf-8?B?VFJEVnNvbzJBVXppTTJCdmpUdEpneTlMUWt5Z1J3aW5ZbXRnWTBUbmt6S0ts?=
 =?utf-8?B?WTdaeW85bTBLQnZRME1DNWRYQjVZMkIrUUcvWGJXOWlySnZnbFJjMDBYWXhm?=
 =?utf-8?B?cGVzdkJMcXIrQlFOekxoYnBLREd4Mzd4Q3hPVDN5TFIyb2RNQlJKYkFuVUJ3?=
 =?utf-8?B?S0tkRG5Dc0k3c095N0IrV2paV0hJOGVkRXYxY0huQ1hyUWx4SWZLaVB6NkNp?=
 =?utf-8?B?UDZjcG5lQitWQ0NjYUFxcVlYZmFKSXRVeHdRRUIyK2FMY1MrS2tlQUZYczhl?=
 =?utf-8?B?UGFwWCtpdExhaDRCY3ZkZmJ4K0pjRk1FZWduQUJNbTFGb3Rha1ljY0dXQlQw?=
 =?utf-8?B?OVMzNE9nWWNhSVFoZTZ0UU1OK3lzUHZodHVwVm1QNGlWUE1WSkxtUFNhSXdx?=
 =?utf-8?B?eEFzTmtJNThha245N29PV05jVExEQVZmeDFDQStFWDlWMmhWTHlSdVZCcnV5?=
 =?utf-8?B?alJ5bEMrejYyL0l6ZXdEYWlVem1KUWV1dVZFVzkya3dtTXBRVC85UG95YmF1?=
 =?utf-8?B?anZIa1haRGdwbksvd3QwU3dHTE9DK1ZpNTR2MHE2bnpLR2ovaEFBWFpnd2Ra?=
 =?utf-8?B?eC9RVjFDWWhRQXhMNklUWkVwNnA1R2IrMk1Ccmx6NC9OWjZzazBSOUtZVWY5?=
 =?utf-8?B?YjZhRUJRMkNEZU0ycVozUXJndlpSSGEvU1BuaTlxTUk3TzRUaE4wd1FTUzVk?=
 =?utf-8?B?bWVTVC9RYXVuTG5IaWZDVkE4cnBKM2Y3eU5tb0hCSXVIN0hJMXFqVkhEWmor?=
 =?utf-8?B?T1gwb0M2eVhmVEZIVEx0SU8wNGtWMTNKRjd5SmVydGlpMUxoVENQaTZUU3hF?=
 =?utf-8?B?Rm0zVGJjTHpFVVY1Mkt4eEMvU0ZWdVV4aGlkYXRpVEZpSkFvZXZickFteGZH?=
 =?utf-8?B?UGdvajlwd1hkTzY4LzNXQ09QUkJJQnlMRUZadUxndWw1bU53eld0bFNlb2Rh?=
 =?utf-8?B?S3RJVEJiWTZ5QlM0RkphMnkwTmxncGVYK3N1QXptTUNsUHNnV0NoR0pJWlRp?=
 =?utf-8?B?YnVpelVMRmU0bk1rZTdoaDh1eEVjQU10VjRyaXQ0bDFJNEFkNEFUNmdOVEdQ?=
 =?utf-8?B?U3VjSG1NUERzTTg3dVcrRDN4d3RFVDZyaHZINm81RG96RVlsdXNBdUI0UkY2?=
 =?utf-8?B?cFgvM1pRbXQ4UlRqZXptVFEzRmNucUdmTWRDNnlEeDhhQmlPcUZJbllnbjVQ?=
 =?utf-8?B?RjhHY29yUTl5bjRkOXhGd3JGSkFiSE81YjZZb2FkUnozMUNLSDVhbjU3eGtG?=
 =?utf-8?B?R0JMbEtaNjY5QUFQTzJRTzE4MEZ6UkRjc0RhV241TTRsb1RGQS9QTzAwMk9z?=
 =?utf-8?B?UDhnU3NtZDUrN0xBRWJQSVVpeDhKbUNXcHR1WlJHSHQrTWdGazFKRUJ0VldQ?=
 =?utf-8?B?UTBqVXRNT0lRcWkrUmxid3l1TEpjb2xXZUVHb3oxTzNwaGxiUDlIZUhWcDZK?=
 =?utf-8?B?a285d01JK3FUWlVhVlc4WDB3MFc4aGZaSGorS2lETlVuWVpod29PcVRGRnU3?=
 =?utf-8?B?SzlDUWdrQ2lzTWhaM2ZrbWNla2tJVGNrcEdkUTBOUXM5NHN5blZIMm1ZeTR6?=
 =?utf-8?B?blh1bFpTK3kzWHRRTmZEVE8wU2d5aFI4L0NITnZ5OTdjdk5td2prcUlKTWZU?=
 =?utf-8?B?SkpHVUxzVkdpOVlMcFU3bEE1b2xTRWY4aGNVN2U1NDkvdXpjM3k0U0hvUUVh?=
 =?utf-8?B?cjYrazE2bk82U2VtZ21ZQ0ZTcnhOUUlORCt0aWMxR3VCblJRUUdGc0dHWHhB?=
 =?utf-8?B?NTBXaVU2QjlXN2UvcktHbHVoTkEyVWJOWk8vK2JBeWRHL2o5MjJjN0NFd3Ry?=
 =?utf-8?B?eld0alY1Z2hTOHg4VXlqZkdxR1ZGZnhOb1JBTDNPYmtFYW8xd2NHREowTXNv?=
 =?utf-8?B?QTJmUU8rNEJYaUdlYkVpeDNOUzN0UWRPZWU4R3RJaXdRYjhFWWFwMXFmaUFO?=
 =?utf-8?B?cUFBQlc5ZDh6bi82eUlMeXNhWGZ0RFVZMExtMk9oYXFZNlZvSFBQVGkvMktx?=
 =?utf-8?B?RUdPcW9JenZKd2N1SGtVbVNtSnQxZTdKWTh6TEdCS0hvU01GZzN3b2RMdFFj?=
 =?utf-8?B?L1JiamN5Ulg5ejJsa29TM3F2ZnpxSnV0QUIvVmxQMGxtdkRoSWtjQmhRL2Rl?=
 =?utf-8?Q?31waSiV7SBqMXK+o=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c15e123f-4f74-4be6-193c-08da2a41cdf5
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2022 00:38:54.5634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F3YzCs8WDU75MGtVeisZA0cS/JVnHbtXz4Ql8Bj9A4IPCf6kiaf7z+WInCzT9Z1sCysE3cngkCILul4NBg1ZOkwIipYE/zpxJaooDpuoxpI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4396
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-29_08:2022-04-28,2022-04-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204300001
X-Proofpoint-ORIG-GUID: wtwt_kdt8th5nc_GX5aj7igiOhrKcPxJ
X-Proofpoint-GUID: wtwt_kdt8th5nc_GX5aj7igiOhrKcPxJ


On 4/29/22 5:10 PM, Stefano Stabellini wrote:
> From: Luca Miccio <lucmiccio@gmail.com>
>
> When running as dom0less guest (HVM domain on ARM) the xenstore event
> channel is available at domain creation but the shared xenstore
> interface page only becomes available later on.
>
> In that case, wait for a notification on the xenstore event channel,
> then complete the xenstore initialization later, when the shared page
> is actually available.
>
> The xenstore page has few extra field. Add them to the shared struct.
> One of the field is "connection", when the connection is ready, it is
> zero. If the connection is not-zero, wait for a notification.
>
> Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> CC: jgross@suse.com
> CC: boris.ostrovsky@oracle.com
> ---
> Changes in v3:
> - check for the connection field, if it is not zero, wait for event
>
> Changes in v2:
> - remove XENFEAT_xenstore_late_init
> ---
>   drivers/xen/xenbus/xenbus_probe.c  | 86 +++++++++++++++++++++++-------
>   include/xen/interface/io/xs_wire.h |  3 ++
>   2 files changed, 70 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index fe360c33ce71..dc046d25789e 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -65,6 +65,7 @@
>   #include "xenbus.h"
>   
>   
> +static int xs_init_irq;
>   int xen_store_evtchn;
>   EXPORT_SYMBOL_GPL(xen_store_evtchn);
>   
> @@ -750,6 +751,17 @@ static void xenbus_probe(void)
>   {
>   	xenstored_ready = 1;
>   
> +	if (!xen_store_interface) {
> +		xen_store_interface = xen_remap(xen_store_gfn << XEN_PAGE_SHIFT,
> +						XEN_PAGE_SIZE);
> +		/*
> +		 * Now it is safe to free the IRQ used for xenstore late
> +		 * initialization. No need to unbind: it is about to be
> +		 * bound again.


This assumes knowledge of bind/unbind internals. I think we should unbind.


> +		 */
> +		free_irq(xs_init_irq, &xb_waitq);
> +	}
> +



> @@ -959,23 +988,42 @@ static int __init xenbus_init(void)
>   		 *
>   		 * Also recognize all bits set as an invalid value.


Is this comment still correct?


>   		 */
> -		if (!v || !~v) {
> +		if (!v) {
>   			err = -ENOENT;
>   			goto out_error;
>   		}
> -		/* Avoid truncation on 32-bit. */
> +		if (v == ~0ULL) {
> +			wait = true;
> +		} else {
> +			/* Avoid truncation on 32-bit. */
>


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 01:06:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 01:06:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317909.537450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkbZ3-0001Aj-7e; Sat, 30 Apr 2022 01:06:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317909.537450; Sat, 30 Apr 2022 01:06:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkbZ3-0001Ac-4S; Sat, 30 Apr 2022 01:06:25 +0000
Received: by outflank-mailman (input) for mailman id 317909;
 Sat, 30 Apr 2022 01:06:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=yLwW=VI=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nkbZ1-0001AW-I6
 for xen-devel@lists.xenproject.org; Sat, 30 Apr 2022 01:06:23 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id be3da917-c821-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 03:06:21 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23U1678B061213
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 29 Apr 2022 21:06:13 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23U1643g061212;
 Fri, 29 Apr 2022 18:06:04 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be3da917-c821-11ec-a405-831a346695d4
Date: Fri, 29 Apr 2022 18:06:04 -0700
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/2] tools/xl: Allow specifying JSON for domain
 configuration file format
Message-ID: <YmyLfNB07ff81e6n@mattapan.m5p.com>
References: <cover.1650422517.git.ehem+xen@m5p.com>
 <09213ac26738ee51401b454534c6b437766481b7.1650422518.git.ehem+xen@m5p.com>
 <YmvbYHbmfXYx47r2@perard.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YmvbYHbmfXYx47r2@perard.uk.xensource.com>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

On Fri, Apr 29, 2022 at 01:34:40PM +0100, Anthony PERARD wrote:
> On Tue, Apr 19, 2022 at 06:23:41PM -0700, Elliott Mitchell wrote:
> > JSON is currently used when saving domains to mass storage.  Being able
> > to use JSON as the normal input to `xl create` has potential to be
> > valuable.  Add the functionality.
> 
> "potential", right, but it isn't hasn't been really tested. When
> implemented, I think the intend of the json format was for libxl to
> communicate with itself while migrating a guest (or save/restore). It
> would be nice to know if it actually can work.

What I wonder is why the behind the scenes format is flexible enough to
fully handle domain configuration, yet wasn't reused for domain
configuration.  Then I look at the parser for domain configuration files
and it isn't really that great.

Add those two together and moving towards domain configuration files
being JSON seems natural.  Look at the "vif" and "disk" sections.  Those
could be very naturally handled as JSON, while the current parser isn't
rather limited.

There may be need to modify libxl_domain_config_from_json() to ensure it
gives good error messages.

> > Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> > ---
> > diff --git a/tools/xl/xl.h b/tools/xl/xl.h
> > index c5c4bedbdd..a0c03f96df 100644
> > --- a/tools/xl/xl.h
> > +++ b/tools/xl/xl.h
> > @@ -49,6 +49,11 @@ struct domain_create {
> >      int migrate_fd; /* -1 means none */
> >      int send_back_fd; /* -1 means none */
> >      char **migration_domname_r; /* from malloc */
> > +    enum {
> > +        FORMAT_DEFAULT,
> > +        FORMAT_JSON,
> > +        FORMAT_LEGACY,
> > +    } format;
> 
> I think the name "format" here is too generic, we are in the struct
> "domain_create" and this new format field isn't intended to specify the
> format of the domain. I think "config_file_format" would be better, as
> it is only used for the format of the config_file.

What about "config_format" to match below?

> Also I don't think having "_DEFAULT" would be useful, we need to know
> what the format is intended to be before starting to parse the file, and
> I don't think changing the default is going to work. So for the enum, we
> could have "_LEGACY = 0".
> 
> The prefix "FORMAT_" feels a bit generic, maybe "CONFIG_FORMAT_" would
> be better, or something else.

Okay.

Over time the default can be changed.  Document plans to move to JSON
exclusively.  Then after a few versions switch the default.  Then after
more versions remove the old format.

> >  };
> >  
> >  int create_domain(struct domain_create *dom_info);
> > diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
> > index f546beaceb..04d579a596 100644
> > --- a/tools/xl/xl_cmdtable.c
> > +++ b/tools/xl/xl_cmdtable.c
> > @@ -31,6 +31,8 @@ const struct cmd_spec cmd_table[] = {
> >        "-h                      Print this help.\n"
> >        "-p                      Leave the domain paused after it is created.\n"
> >        "-f FILE, --defconfig=FILE\n                     Use the given configuration file.\n"
> > +      "-j, --json              Interpret configuration file as JSON format\n"
> > +      "-J                      Use traditional configuration file format (current default)\n"
> 
> I don't think this new "-J" option would be useful, just the "-j" should be
> enough.

I was thinking of this as a transition mechanism.  Have "-J" for when the
default has been changed, but the code to handle the original format
hasn't been removed.

> >        "-n, --dryrun            Dry run - prints the resulting configuration\n"
> >        "                         (deprecated in favour of global -N option).\n"
> >        "-q, --quiet             Quiet.\n"
> > diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
> > index 2ec4140258..41bd919d1d 100644
> > --- a/tools/xl/xl_vmcontrol.c
> > +++ b/tools/xl/xl_vmcontrol.c
> > @@ -789,7 +789,7 @@ int create_domain(struct domain_create *dom_info)
> >                  extra_config);
> >          }
> >          config_source=config_file;
> > -        config_in_json = false;
> > +        config_in_json = dom_info.format == FORMAT_JSON ? true : false;
> 
> This doesn't build, "dom_info" is a pointer.
> 
> Also, "? true : false;" is weird in C.

Uh, yeah.  Too many different coding standards.  Plus things being
passed around.  Erk.  %-/

> >      } else {
> >          if (!config_data) {
> >              fprintf(stderr, "Config file not specified and"
> > @@ -1173,6 +1173,7 @@ int main_create(int argc, char **argv)
> >          {"defconfig", 1, 0, 'f'},
> >          {"dryrun", 0, 0, 'n'},
> >          {"ignore-global-affinity-masks", 0, 0, 'i'},
> > +        {"json", 0, 0, 'j'},
> >          {"quiet", 0, 0, 'q'},
> >          {"vncviewer", 0, 0, 'V'},
> >          {"vncviewer-autopass", 0, 0, 'A'},
> > @@ -1181,18 +1182,23 @@ int main_create(int argc, char **argv)
> >  
> >      dom_info.extra_config = NULL;
> >  
> > +    dom_info.format = FORMAT_DEFAULT;
> > +
> >      if (argv[1] && argv[1][0] != '-' && !strchr(argv[1], '=')) {
> >          filename = argv[1];
> >          argc--; argv++;
> >      }
> >  
> > -    SWITCH_FOREACH_OPT(opt, "Ffnq:AVcdeip", opts, "create", 0) {
> > +    SWITCH_FOREACH_OPT(opt, "FJfjnq:AVcdeip", opts, "create", 0) {
> >      case 'A':
> >          vnc = vncautopass = 1;
> >          break;
> >      case 'F':
> >          daemonize = 0;
> >          break;
> > +    case 'J':
> > +        dom_info.format = FORMAT_LEGACY;
> > +        break;
> >      case 'V':
> >          vnc = 1;
> >          break;
> > @@ -1212,6 +1218,9 @@ int main_create(int argc, char **argv)
> >      case 'i':
> >          ignore_masks = 1;
> >          break;
> > +    case 'j':
> > +        dom_info.format = FORMAT_JSON;
> 
> This setting is ignored, as "dom_info" is reset later.

Uh huh.  Indeed.  I saw the "dom_info.extra_config = NULL;" and figured
dom_info was valid at that point, but the memset() is later.  Certainly
need to remedy that.

Having looked, that has gotten pretty awful.  That really needs some
rework to avoid confusion.  Next version...


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Sat Apr 30 01:14:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 01:14:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317920.537461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkbh8-0002fw-4i; Sat, 30 Apr 2022 01:14:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317920.537461; Sat, 30 Apr 2022 01:14:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkbh8-0002fp-1n; Sat, 30 Apr 2022 01:14:46 +0000
Received: by outflank-mailman (input) for mailman id 317920;
 Sat, 30 Apr 2022 01:14:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkbh6-0002ff-Jk; Sat, 30 Apr 2022 01:14:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkbh6-0003bX-Dr; Sat, 30 Apr 2022 01:14:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkbh6-0004hx-2d; Sat, 30 Apr 2022 01:14:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkbh6-0005W6-29; Sat, 30 Apr 2022 01:14:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wh8CqPU+DZJCLr5TkW4uqWjxpYOX/g5jpCHPtYVvJ38=; b=GE53Cl8LuwdIHHwzekvBBwNh9z
	7eLqUakF9Yf0x263IooUITUqYmF2nZRB0nv9jED36LJqc3mXHhNTBum3XONKgdjcn3fQ0+mLNUoss
	4UCtySvP9fHRpGAUQ2l1ZNEC3OOKwi1y0yAAWj/t/3CkOpukhxMzF+zgEpE/WIbx4KR4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169892-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169892: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 01:14:44 +0000

flight 169892 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169892/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   59 days  706 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   27 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 02:40:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 02:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317933.537478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkd2A-00039m-LO; Sat, 30 Apr 2022 02:40:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317933.537478; Sat, 30 Apr 2022 02:40:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkd2A-00039T-GC; Sat, 30 Apr 2022 02:40:34 +0000
Received: by outflank-mailman (input) for mailman id 317933;
 Sat, 30 Apr 2022 02:40:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=yLwW=VI=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nkd29-00039N-Ux
 for xen-devel@lists.xenproject.org; Sat, 30 Apr 2022 02:40:33 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e725aba5-c82e-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 04:40:32 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23U2eKJQ061600
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 29 Apr 2022 22:40:26 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23U2eHq2061599;
 Fri, 29 Apr 2022 19:40:17 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e725aba5-c82e-11ec-a405-831a346695d4
Message-Id: <cover.1651285313.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Fri, 29 Apr 2022 19:21:53 -0700
Subject: [PATCH v2 0/3] Allow use of JSON in domain configuration files
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

While the traditional domain configuration file format works acceptably,
I can see uses for having full JSON support.  As such add "-j" and "-J"
to `xl create` to specify format.  The traditional format is the current
default.

While attempting this, it came up that options for `xl create` aren't in
a consistent order.  I'm concerned about moving the VNC options apart,
but the others have been sorted.

Due to one issue in the previous round I ended up examing the dom_info
variable in main_create().  The situation there is a bit tangled.  There
were shadow variables for everything in dom_info.  Unfortunately the
short-hand serves to confuse, so I believe the appropriate action is to
remove the shadows.  Appears .dry_run had effectively been deprecated,
but not fully removed; as such now fully remove it.

Rename everything "format" to "config_format".

Elliott Mitchell (3):
  tools/xl: Sort create command options
  tools/xl: Use sparse init for dom_info, remove duplicate vars
  tools/xl: Allow specifying JSON for domain configuration file format

 tools/xl/xl.h           |   6 ++-
 tools/xl/xl_cmdtable.c  |  14 ++---
 tools/xl/xl_vmcontrol.c | 114 +++++++++++++++++++++-------------------
 3 files changed, 73 insertions(+), 61 deletions(-)

-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 30 02:41:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 02:41:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317939.537489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkd2y-0003fs-SJ; Sat, 30 Apr 2022 02:41:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317939.537489; Sat, 30 Apr 2022 02:41:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkd2y-0003fl-PJ; Sat, 30 Apr 2022 02:41:24 +0000
Received: by outflank-mailman (input) for mailman id 317939;
 Sat, 30 Apr 2022 02:41:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=yLwW=VI=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nkd2x-0003dd-99
 for xen-devel@lists.xenproject.org; Sat, 30 Apr 2022 02:41:23 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04d03138-c82f-11ec-8fc4-03012f2f19d4;
 Sat, 30 Apr 2022 04:41:22 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23U2fBa7061612
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 29 Apr 2022 22:41:17 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23U2fBmE061611;
 Fri, 29 Apr 2022 19:41:11 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04d03138-c82f-11ec-8fc4-03012f2f19d4
Message-Id: <f9a50602c6bfdab31b9aad6849195d955bce144c.1651285313.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1651285313.git.ehem+xen@m5p.com>
References: <cover.1651285313.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Tue, 19 Apr 2022 18:56:03 -0700
Subject: [PATCH v2 1/3] tools/xl: Sort create command options
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Hopefully simplify future changes by sorting options lists for
`xl create`.  While at it, declare the options list constant.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
v2:
Adding mention of making the list constant.

Fix the getopt list sorting
---
 tools/xl/xl_cmdtable.c  | 12 ++++++------
 tools/xl/xl_vmcontrol.c | 40 ++++++++++++++++++++--------------------
 2 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
index 661323d488..35182ca196 100644
--- a/tools/xl/xl_cmdtable.c
+++ b/tools/xl/xl_cmdtable.c
@@ -24,16 +24,16 @@ const struct cmd_spec cmd_table[] = {
       &main_create, 1, 1,
       "Create a domain from config file <filename>",
       "<ConfigFile> [options] [vars]",
-      "-h                      Print this help.\n"
-      "-p                      Leave the domain paused after it is created.\n"
       "-c                      Connect to the console after the domain is created.\n"
+      "-d                      Enable debug messages.\n"
+      "-e                      Do not wait in the background for the death of the domain.\n"
+      "-F                      Run in foreground until death of the domain.\n"
       "-f FILE, --defconfig=FILE\n                     Use the given configuration file.\n"
-      "-q, --quiet             Quiet.\n"
+      "-h                      Print this help.\n"
       "-n, --dryrun            Dry run - prints the resulting configuration\n"
       "                         (deprecated in favour of global -N option).\n"
-      "-d                      Enable debug messages.\n"
-      "-F                      Run in foreground until death of the domain.\n"
-      "-e                      Do not wait in the background for the death of the domain.\n"
+      "-p                      Leave the domain paused after it is created.\n"
+      "-q, --quiet             Quiet.\n"
       "-V, --vncviewer         Connect to the VNC display after the domain is created.\n"
       "-A, --vncviewer-autopass\n"
       "                        Pass VNC password to viewer via stdin.\n"
diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
index 435155a033..d081c6c290 100644
--- a/tools/xl/xl_vmcontrol.c
+++ b/tools/xl/xl_vmcontrol.c
@@ -1169,13 +1169,13 @@ int main_create(int argc, char **argv)
     int paused = 0, debug = 0, daemonize = 1, console_autoconnect = 0,
         quiet = 0, monitor = 1, vnc = 0, vncautopass = 0, ignore_masks = 0;
     int opt, rc;
-    static struct option opts[] = {
+    static const struct option opts[] = {
+        {"defconfig", 1, 0, 'f'},
         {"dryrun", 0, 0, 'n'},
+        {"ignore-global-affinity-masks", 0, 0, 'i'},
         {"quiet", 0, 0, 'q'},
-        {"defconfig", 1, 0, 'f'},
         {"vncviewer", 0, 0, 'V'},
         {"vncviewer-autopass", 0, 0, 'A'},
-        {"ignore-global-affinity-masks", 0, 0, 'i'},
         COMMON_LONG_OPTS
     };
 
@@ -1186,12 +1186,15 @@ int main_create(int argc, char **argv)
         argc--; argv++;
     }
 
-    SWITCH_FOREACH_OPT(opt, "Fnqf:pcdeVAi", opts, "create", 0) {
-    case 'f':
-        filename = optarg;
+    SWITCH_FOREACH_OPT(opt, "AFVcdef:inpq", opts, "create", 0) {
+    case 'A':
+        vnc = vncautopass = 1;
         break;
-    case 'p':
-        paused = 1;
+    case 'F':
+        daemonize = 0;
+        break;
+    case 'V':
+        vnc = 1;
         break;
     case 'c':
         console_autoconnect = 1;
@@ -1199,28 +1202,25 @@ int main_create(int argc, char **argv)
     case 'd':
         debug = 1;
         break;
-    case 'F':
-        daemonize = 0;
-        break;
     case 'e':
         daemonize = 0;
         monitor = 0;
         break;
+    case 'f':
+        filename = optarg;
+        break;
+    case 'i':
+        ignore_masks = 1;
+        break;
     case 'n':
         dryrun_only = 1;
         break;
+    case 'p':
+        paused = 1;
+        break;
     case 'q':
         quiet = 1;
         break;
-    case 'V':
-        vnc = 1;
-        break;
-    case 'A':
-        vnc = vncautopass = 1;
-        break;
-    case 'i':
-        ignore_masks = 1;
-        break;
     }
 
     memset(&dom_info, 0, sizeof(dom_info));
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 30 02:42:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 02:42:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317947.537500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkd3a-0004H0-4k; Sat, 30 Apr 2022 02:42:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317947.537500; Sat, 30 Apr 2022 02:42:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkd3a-0004Gt-1B; Sat, 30 Apr 2022 02:42:02 +0000
Received: by outflank-mailman (input) for mailman id 317947;
 Sat, 30 Apr 2022 02:42:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=yLwW=VI=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nkd3Y-0004Ge-LJ
 for xen-devel@lists.xenproject.org; Sat, 30 Apr 2022 02:42:00 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1a890cc2-c82f-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 04:41:58 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23U2fm87061622
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 29 Apr 2022 22:41:54 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23U2fmBJ061621;
 Fri, 29 Apr 2022 19:41:48 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a890cc2-c82f-11ec-a405-831a346695d4
Message-Id: <a444edf57dbb1ea45ce4af471bf2c5f9b362bbde.1651285313.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1651285313.git.ehem+xen@m5p.com>
References: <cover.1651285313.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Fri, 29 Apr 2022 15:45:25 -0700
Subject: [PATCH v2 2/3] tools/xl: Use sparse init for dom_info, remove duplicate
 vars
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=1.5 required=10.0 tests=DATE_IN_PAST_03_06,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Rather than having shadow variables for every element of dom_info, it is
better to properly initialize dom_info at the start.  This also removes
the misleading memset() in the middle of main_create().

Remove the dryrun element of domain_create as that has been displaced
by the global "dryrun_only" variable.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
v2:
This was added due to the confusing situation with dom_info.
---
 tools/xl/xl.h           |  1 -
 tools/xl/xl_vmcontrol.c | 76 ++++++++++++++++++++---------------------
 2 files changed, 37 insertions(+), 40 deletions(-)

diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index c5c4bedbdd..72538d6a81 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -34,7 +34,6 @@ struct domain_create {
     int daemonize;
     int monitor; /* handle guest reboots etc */
     int paused;
-    int dryrun;
     int quiet;
     int vnc;
     int vncautopass;
diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
index d081c6c290..4bf041fb01 100644
--- a/tools/xl/xl_vmcontrol.c
+++ b/tools/xl/xl_vmcontrol.c
@@ -854,8 +854,8 @@ int create_domain(struct domain_create *dom_info)
         }
     }
 
-    if (debug || dom_info->dryrun) {
-        FILE *cfg_print_fh = (debug && !dom_info->dryrun) ? stderr : stdout;
+    if (debug || dryrun_only) {
+        FILE *cfg_print_fh = (debug && !dryrun_only) ? stderr : stdout;
         if (default_output_format == OUTPUT_FORMAT_SXP) {
             printf_info_sexp(-1, &d_config, cfg_print_fh);
         } else {
@@ -873,7 +873,7 @@ int create_domain(struct domain_create *dom_info)
 
 
     ret = 0;
-    if (dom_info->dryrun)
+    if (dryrun_only)
         goto out;
 
 start:
@@ -1164,10 +1164,26 @@ out:
 
 int main_create(int argc, char **argv)
 {
-    const char *filename = NULL;
-    struct domain_create dom_info;
-    int paused = 0, debug = 0, daemonize = 1, console_autoconnect = 0,
-        quiet = 0, monitor = 1, vnc = 0, vncautopass = 0, ignore_masks = 0;
+    struct domain_create dom_info = {
+        /* Command-line options */
+        .config_file = NULL,
+        .console_autoconnect = 0,
+        .debug = 0,
+        .daemonize = 1,
+        .ignore_global_affinity_masks = 0,
+        .monitor = 1,
+        .paused = 0,
+        .quiet = 0,
+        .vnc = 0,
+        .vncautopass = 0,
+
+        /* Extra configuration file settings */
+        .extra_config = NULL,
+
+        /* FDs, initialize to invalid */
+        .migrate_fd = -1,
+        .send_back_fd = -1,
+    };
     int opt, rc;
     static const struct option opts[] = {
         {"defconfig", 1, 0, 'f'},
@@ -1179,58 +1195,54 @@ int main_create(int argc, char **argv)
         COMMON_LONG_OPTS
     };
 
-    dom_info.extra_config = NULL;
-
     if (argv[1] && argv[1][0] != '-' && !strchr(argv[1], '=')) {
-        filename = argv[1];
+        dom_info.config_file = argv[1];
         argc--; argv++;
     }
 
     SWITCH_FOREACH_OPT(opt, "AFVcdef:inpq", opts, "create", 0) {
     case 'A':
-        vnc = vncautopass = 1;
+        dom_info.vnc = dom_info.vncautopass = 1;
         break;
     case 'F':
-        daemonize = 0;
+        dom_info.daemonize = 0;
         break;
     case 'V':
-        vnc = 1;
+        dom_info.vnc = 1;
         break;
     case 'c':
-        console_autoconnect = 1;
+        dom_info.console_autoconnect = 1;
         break;
     case 'd':
-        debug = 1;
+        dom_info.debug = 1;
         break;
     case 'e':
-        daemonize = 0;
-        monitor = 0;
+        dom_info.daemonize = 0;
+        dom_info.monitor = 0;
         break;
     case 'f':
-        filename = optarg;
+        dom_info.config_file = optarg;
         break;
     case 'i':
-        ignore_masks = 1;
+        dom_info.ignore_global_affinity_masks = 1;
         break;
     case 'n':
         dryrun_only = 1;
         break;
     case 'p':
-        paused = 1;
+        dom_info.paused = 1;
         break;
     case 'q':
-        quiet = 1;
+        dom_info.quiet = 1;
         break;
     }
 
-    memset(&dom_info, 0, sizeof(dom_info));
-
     for (; optind < argc; optind++) {
         if (strchr(argv[optind], '=') != NULL) {
             string_realloc_append(&dom_info.extra_config, argv[optind]);
             string_realloc_append(&dom_info.extra_config, "\n");
-        } else if (!filename) {
-            filename = argv[optind];
+        } else if (!dom_info.config_file) {
+            dom_info.config_file = argv[optind];
         } else {
             help("create");
             free(dom_info.extra_config);
@@ -1238,20 +1250,6 @@ int main_create(int argc, char **argv)
         }
     }
 
-    dom_info.debug = debug;
-    dom_info.daemonize = daemonize;
-    dom_info.monitor = monitor;
-    dom_info.paused = paused;
-    dom_info.dryrun = dryrun_only;
-    dom_info.quiet = quiet;
-    dom_info.config_file = filename;
-    dom_info.migrate_fd = -1;
-    dom_info.send_back_fd = -1;
-    dom_info.vnc = vnc;
-    dom_info.vncautopass = vncautopass;
-    dom_info.console_autoconnect = console_autoconnect;
-    dom_info.ignore_global_affinity_masks = ignore_masks;
-
     rc = create_domain(&dom_info);
     if (rc < 0) {
         free(dom_info.extra_config);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 30 02:42:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 02:42:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317958.537511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkd4A-0004qE-EE; Sat, 30 Apr 2022 02:42:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317958.537511; Sat, 30 Apr 2022 02:42:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkd4A-0004q5-AJ; Sat, 30 Apr 2022 02:42:38 +0000
Received: by outflank-mailman (input) for mailman id 317958;
 Sat, 30 Apr 2022 02:42:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=yLwW=VI=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nkd48-0004Ge-Kg
 for xen-devel@lists.xenproject.org; Sat, 30 Apr 2022 02:42:36 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 30a69f7b-c82f-11ec-a405-831a346695d4;
 Sat, 30 Apr 2022 04:42:35 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 23U2gPBT061633
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 29 Apr 2022 22:42:31 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 23U2gPka061632;
 Fri, 29 Apr 2022 19:42:25 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30a69f7b-c82f-11ec-a405-831a346695d4
Message-Id: <9aa6160b2664a52ff778fad67c366d67d3a0f8ab.1651285313.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1651285313.git.ehem+xen@m5p.com>
References: <cover.1651285313.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Tue, 19 Apr 2022 18:23:41 -0700
Subject: [PATCH v2 3/3] tools/xl: Allow specifying JSON for domain configuration
 file format
To: xen-devel@lists.xenproject.org
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

JSON is currently used when saving domains to mass storage.  Being able
to use JSON as the normal input to `xl create` has potential to be
valuable.  Add the functionality.

Move the memset() earlier so to allow use of the structure sooner.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
v2:
Removing the UUOC situation.  Correct the comparison to match the correct
variable type.  Rename to "config_format" from "format".

Rename everything from "format" to "config_format".
---
 tools/xl/xl.h           |  5 +++++
 tools/xl/xl_cmdtable.c  |  2 ++
 tools/xl/xl_vmcontrol.c | 12 ++++++++++--
 3 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index 72538d6a81..4b0828431f 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -48,6 +48,11 @@ struct domain_create {
     int migrate_fd; /* -1 means none */
     int send_back_fd; /* -1 means none */
     char **migration_domname_r; /* from malloc */
+    enum {
+        CONFIG_FORMAT_DEFAULT,
+        CONFIG_FORMAT_JSON,
+        CONFIG_FORMAT_LEGACY,
+    } config_format; /* format specified for configuration */
 };
 
 int create_domain(struct domain_create *dom_info);
diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
index 35182ca196..8a791d8c49 100644
--- a/tools/xl/xl_cmdtable.c
+++ b/tools/xl/xl_cmdtable.c
@@ -30,6 +30,8 @@ const struct cmd_spec cmd_table[] = {
       "-F                      Run in foreground until death of the domain.\n"
       "-f FILE, --defconfig=FILE\n                     Use the given configuration file.\n"
       "-h                      Print this help.\n"
+      "-j, --json              Interpret configuration file as JSON format\n"
+      "-J                      Use traditional configuration file format (current default)\n"
       "-n, --dryrun            Dry run - prints the resulting configuration\n"
       "                         (deprecated in favour of global -N option).\n"
       "-p                      Leave the domain paused after it is created.\n"
diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
index 4bf041fb01..dd8b3f81a6 100644
--- a/tools/xl/xl_vmcontrol.c
+++ b/tools/xl/xl_vmcontrol.c
@@ -789,7 +789,7 @@ int create_domain(struct domain_create *dom_info)
                 extra_config);
         }
         config_source=config_file;
-        config_in_json = false;
+        config_in_json = dom_info->config_format == CONFIG_FORMAT_JSON;
     } else {
         if (!config_data) {
             fprintf(stderr, "Config file not specified and"
@@ -1167,6 +1167,7 @@ int main_create(int argc, char **argv)
     struct domain_create dom_info = {
         /* Command-line options */
         .config_file = NULL,
+        .config_format = CONFIG_FORMAT_DEFAULT,
         .console_autoconnect = 0,
         .debug = 0,
         .daemonize = 1,
@@ -1189,6 +1190,7 @@ int main_create(int argc, char **argv)
         {"defconfig", 1, 0, 'f'},
         {"dryrun", 0, 0, 'n'},
         {"ignore-global-affinity-masks", 0, 0, 'i'},
+        {"json", 0, 0, 'j'},
         {"quiet", 0, 0, 'q'},
         {"vncviewer", 0, 0, 'V'},
         {"vncviewer-autopass", 0, 0, 'A'},
@@ -1200,13 +1202,16 @@ int main_create(int argc, char **argv)
         argc--; argv++;
     }
 
-    SWITCH_FOREACH_OPT(opt, "AFVcdef:inpq", opts, "create", 0) {
+    SWITCH_FOREACH_OPT(opt, "AFJVcdef:ijnpq", opts, "create", 0) {
     case 'A':
         dom_info.vnc = dom_info.vncautopass = 1;
         break;
     case 'F':
         dom_info.daemonize = 0;
         break;
+    case 'J':
+        dom_info.config_format = CONFIG_FORMAT_LEGACY;
+        break;
     case 'V':
         dom_info.vnc = 1;
         break;
@@ -1226,6 +1231,9 @@ int main_create(int argc, char **argv)
     case 'i':
         dom_info.ignore_global_affinity_masks = 1;
         break;
+    case 'j':
+        dom_info.config_format = CONFIG_FORMAT_JSON;
+        break;
     case 'n':
         dryrun_only = 1;
         break;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Apr 30 06:45:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 06:45:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317990.537534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkgqt-0002W3-TI; Sat, 30 Apr 2022 06:45:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317990.537534; Sat, 30 Apr 2022 06:45:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkgqt-0002Vw-Pn; Sat, 30 Apr 2022 06:45:11 +0000
Received: by outflank-mailman (input) for mailman id 317990;
 Sat, 30 Apr 2022 06:45:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkgqs-0002Vm-St; Sat, 30 Apr 2022 06:45:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkgqs-0001qd-PU; Sat, 30 Apr 2022 06:45:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkgqs-0004fd-7i; Sat, 30 Apr 2022 06:45:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkgqs-0003Er-7F; Sat, 30 Apr 2022 06:45:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=m+B8nKTihBdEUWLR5PXf7DQtz4xW2PQDmQnMbR8BC0g=; b=jTrp4x/AQqqPGAGYr5C9RggpDM
	Acj9kAcI4BcwYuYiqMuD7AmkyIVr4bYla3W+bPuCD7deW+h4TgzM13g1yzp2aCRVKUJlR7Xv/lQZ0
	A+F8426zAO+G0bJxNI8ZxWwJtmDhiRTqP4bboByMGDH21m6vRClMYLZ0YSuxy45crg6Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169886-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 169886: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug
    qemu-mainline:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=731340813fdb4cb8339edb8630e3f923b7d987ec
X-Osstest-Versions-That:
    qemuu=f22833602095b05733bceaddeb20f3edfced3c07
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 06:45:10 +0000

flight 169886 qemu-mainline real [real]
flight 169898 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169886/
http://logs.test-lab.xenproject.org/osstest/logs/169898/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail pass in 169898-retest
 test-amd64-i386-libvirt-xsm   7 xen-install         fail pass in 169898-retest

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 169898 never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 169898 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169849
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169849
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169849
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169849
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169849
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169849
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169849
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169849
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                731340813fdb4cb8339edb8630e3f923b7d987ec
baseline version:
 qemuu                f22833602095b05733bceaddeb20f3edfced3c07

Last test of basis   169849  2022-04-29 03:46:10 Z    1 days
Testing same since   169886  2022-04-29 22:08:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Bin Meng <bin.meng@windriver.com>
  Frank Chang <frank.chang@sifive.com>
  Jiatai He <jiatai2021@iscas.ac.cn>
  Junqiang Wang <wangjunqiang@iscas.ac.cn>
  Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>
  Richard Henderson <richard.henderson@linaro.org>
  Weiwei Li <liweiwei@iscas.ac.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   f228336020..731340813f  731340813fdb4cb8339edb8630e3f923b7d987ec -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 06:49:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 06:49:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317998.537545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkgv6-0003A7-GB; Sat, 30 Apr 2022 06:49:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317998.537545; Sat, 30 Apr 2022 06:49:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkgv6-0003A0-Bk; Sat, 30 Apr 2022 06:49:32 +0000
Received: by outflank-mailman (input) for mailman id 317998;
 Sat, 30 Apr 2022 06:49:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkgv5-00039m-BR; Sat, 30 Apr 2022 06:49:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkgv5-0001v4-9h; Sat, 30 Apr 2022 06:49:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkgv4-0004sD-US; Sat, 30 Apr 2022 06:49:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkgv4-00042V-U2; Sat, 30 Apr 2022 06:49:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=4lq2+Zgncz/UlLx0it4HEvClD7O0eUgi2w8yoCefifE=; b=GDh/DK5YI1fMgRaAY8CIa9mmA9
	EN9uYbnwBfFl0BzzxwGAUZM1omsm+uWspUoxWBVvMoZguOyuTZB/z6g+fSLm3jJElHZO9hJAn5cyT
	JsWuG/+AxeLXVRfRJZdJu25xXu65Qr+fdKhuXX2veBIOphMzHgPaVICsS2+foW7PYQYE=;
To: xen-devel@lists.xenproject.org
Subject: [xen-unstable bisection] complete test-arm64-arm64-xl-credit1
Message-Id: <E1nkgv4-00042V-U2@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 06:49:30 +0000

branch xen-unstable
xenbranch xen-unstable
job test-arm64-arm64-xl-credit1
testid xen-boot

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
  Bug not present: fbd2445558beff90eb9607308f0845b18a7a2b5a
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169899/


  commit fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
  Author: David Vrabel <dvrabel@amazon.co.uk>
  Date:   Tue Apr 26 10:33:01 2022 +0200
  
      page_alloc: assert IRQs are enabled in heap alloc/free
      
      Heap pages can only be safely allocated and freed with interrupts
      enabled as they may require a TLB flush which may send IPIs (on x86).
      
      Normally spinlock debugging would catch calls from the incorrect
      context, but not from stop_machine_run() action functions as these are
      called with spin lock debugging disabled.
      
      Enhance the assertions in alloc_xenheap_pages() and
      alloc_domheap_pages() to check interrupts are enabled. For consistency
      the same asserts are used when freeing heap pages.
      
      As an exception, when only 1 PCPU is online, allocations are permitted
      with interrupts disabled as any TLB flushes would be local only. This
      is necessary during early boot.
      
      Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
      Reviewed-by: Jan Beulich <jbeulich@suse.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-arm64-arm64-xl-credit1.xen-boot.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-arm64-arm64-xl-credit1.xen-boot --summary-out=tmp/169899.bisection-summary --basis-template=169775 --blessings=real,real-bisect,real-retry xen-unstable test-arm64-arm64-xl-credit1 xen-boot
Searching for failure / basis pass:
 169859 fail [host=rochester1] / 169775 [host=laxton1] 169756 [host=laxton1] 169723 ok.
Failure / basis pass flights: 169859 / 169723
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
Basis pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 2419a159fb943c24a6f2439604b9fdb1478fcd08
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen.git#a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42-a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 git://xenbits.xen.org/xen.git#2419a159fb943c24a6f2439604b9fdb1478fcd08-d711a8e\
 5279d830d2e4f0f55246ed0c6e4a6bbed
Loaded 5001 nodes in revision graph
Searching for test results:
 169635 [host=laxton1]
 169666 [host=rochester0]
 169694 [host=laxton1]
 169723 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 2419a159fb943c24a6f2439604b9fdb1478fcd08
 169756 [host=laxton1]
 169775 [host=laxton1]
 169798 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 53b705d02cec03861044e673536586bd1b2443bd
 169819 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 da28439ba55b8a571032b3358af567cff749f612
 169895 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
 169859 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
 169875 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 2419a159fb943c24a6f2439604b9fdb1478fcd08
 169877 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d711a8e5279d830d2e4f0f55246ed0c6e4a6bbed
 169881 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 3f5d61466345ed2213de2d7e391b6cd6d4b86015
 169884 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 163071b1800304c962756789b4ef0ddb978059ba
 169890 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a
 169891 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
 169893 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a
 169896 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a
 169899 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
Searching for interesting versions
 Result found: flight 169723 (pass), for basis pass
 For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a, results HASH(0x55dded89b268) HASH(0x55dded916f00) HASH(0x55dded917e00) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 163071b1800304c962756789b4ef0ddb978059ba, results \
 HASH(0x55dded8b03b0) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 3f5d61466345ed2213de2d7e391b6cd6d4b86015, results HASH(0x55dded8a4058) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 2419a159fb943c24a6f2439604b9fdb1478fcd08, results HASH(0x55dded89be90) H\
 ASH(0x55dded8ad420) Result found: flight 169798 (fail), for basis failure (at ancestor ~64)
 Repro found: flight 169875 (pass), for basis pass
 Repro found: flight 169877 (fail), for basis failure
 0 revisions at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 fbd2445558beff90eb9607308f0845b18a7a2b5a
No revisions left to test, checking graph state.
 Result found: flight 169890 (pass), for last pass
 Result found: flight 169891 (fail), for first failure
 Repro found: flight 169893 (pass), for last pass
 Repro found: flight 169895 (fail), for first failure
 Repro found: flight 169896 (pass), for last pass
 Repro found: flight 169899 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
  Bug not present: fbd2445558beff90eb9607308f0845b18a7a2b5a
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169899/


  commit fa6dc0879ffd3dffffaea2837953c7a8761a9ba0
  Author: David Vrabel <dvrabel@amazon.co.uk>
  Date:   Tue Apr 26 10:33:01 2022 +0200
  
      page_alloc: assert IRQs are enabled in heap alloc/free
      
      Heap pages can only be safely allocated and freed with interrupts
      enabled as they may require a TLB flush which may send IPIs (on x86).
      
      Normally spinlock debugging would catch calls from the incorrect
      context, but not from stop_machine_run() action functions as these are
      called with spin lock debugging disabled.
      
      Enhance the assertions in alloc_xenheap_pages() and
      alloc_domheap_pages() to check interrupts are enabled. For consistency
      the same asserts are used when freeing heap pages.
      
      As an exception, when only 1 PCPU is online, allocations are permitted
      with interrupts disabled as any TLB flushes would be local only. This
      is necessary during early boot.
      
      Signed-off-by: David Vrabel <dvrabel@amazon.co.uk>
      Reviewed-by: Jan Beulich <jbeulich@suse.com>

Revision graph left in /home/logs/results/bisect/xen-unstable/test-arm64-arm64-xl-credit1.xen-boot.{dot,ps,png,html,svg}.
----------------------------------------
169899: tolerable ALL FAIL

flight 169899 xen-unstable real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/169899/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-arm64-arm64-xl-credit1   8 xen-boot                fail baseline untested


jobs:
 test-arm64-arm64-xl-credit1                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Sat Apr 30 06:55:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 06:55:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318008.537559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkh0L-0004gD-8z; Sat, 30 Apr 2022 06:54:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318008.537559; Sat, 30 Apr 2022 06:54:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkh0L-0004g6-5M; Sat, 30 Apr 2022 06:54:57 +0000
Received: by outflank-mailman (input) for mailman id 318008;
 Sat, 30 Apr 2022 06:54:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkh0J-0004fw-I7; Sat, 30 Apr 2022 06:54:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkh0J-00020P-HD; Sat, 30 Apr 2022 06:54:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkh0J-0005De-40; Sat, 30 Apr 2022 06:54:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkh0J-00075E-3a; Sat, 30 Apr 2022 06:54:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ugx8feWghyjl1nW/nVwoWSS9khofIAM71NZhaModTes=; b=lEn6gRP9a7bgxAAu74z9HPPcO6
	/siuoUF73+FnCB/WEbXFYH9XgRV2vn6/3UkJja2BQ0LdZ5EooUsQONMzdC/gw68umzhroJvEv//cc
	Pzjpt00eWpaVGSQ2jUPo6JDZ7EIrk2r8bPgNNLQyEO0jscjPHazT1+AaE5sNgtywYkhA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169894-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169894: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 06:54:55 +0000

flight 169894 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169894/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  707 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   28 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 07:29:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 07:29:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318016.537569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkhXE-00082H-Sr; Sat, 30 Apr 2022 07:28:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318016.537569; Sat, 30 Apr 2022 07:28:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkhXE-00082A-Q0; Sat, 30 Apr 2022 07:28:56 +0000
Received: by outflank-mailman (input) for mailman id 318016;
 Sat, 30 Apr 2022 07:28:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkhXD-000820-BU; Sat, 30 Apr 2022 07:28:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkhXD-0002d0-0O; Sat, 30 Apr 2022 07:28:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkhXC-0006ao-Jd; Sat, 30 Apr 2022 07:28:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkhXC-0003HM-JF; Sat, 30 Apr 2022 07:28:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VLr7k5yVjql0CYtNwI1p32rwWvTccrOGT1F/cPSG9x4=; b=FmrT/0H9+DThj5JleOVyIylVBU
	j1SdmgiVOpsR79aP1/wrNuiAok2R/1wzOu+7i/RmwZ0Sohiw2WWX5xN1TmykjBJQS9qmUngXSjSAh
	Qs2JAu7X/Ye7nyKPTt8JNLqAtyyooWTnyTZtQ9DTrMpvuQGRhx1j1hGSUtFTSDuYiWtI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169887-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169887: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3e71713c9e75c34fc03f55ea86b381856ca952ee
X-Osstest-Versions-That:
    linux=38d741cb70b30741c0e802cbed7bd9cf4fd15fa4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 07:28:54 +0000

flight 169887 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169887/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169862
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169862
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169862
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169862
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169862
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169862
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169862
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169862
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3e71713c9e75c34fc03f55ea86b381856ca952ee
baseline version:
 linux                38d741cb70b30741c0e802cbed7bd9cf4fd15fa4

Last test of basis   169862  2022-04-29 09:52:04 Z    0 days
Testing same since   169887  2022-04-29 22:10:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Guo Ren <guoren@kernel.org>
  Guo Ren <guoren@linux.alibaba.com>
  Ian Rogers <irogers@google.com>
  Leo Yan <leo.yan@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Namhyung Kim <namhyung@kernel.org>
  Palmer Dabbelt <palmer@rivosinc.com>
  Timothy Hayes <timothy.hayes@arm.com>
  Will Deacon <will@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   38d741cb70b3..3e71713c9e75  3e71713c9e75c34fc03f55ea86b381856ca952ee -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 07:47:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 07:47:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318024.537581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkhp4-0001xm-FH; Sat, 30 Apr 2022 07:47:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318024.537581; Sat, 30 Apr 2022 07:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkhp4-0001xf-BM; Sat, 30 Apr 2022 07:47:22 +0000
Received: by outflank-mailman (input) for mailman id 318024;
 Sat, 30 Apr 2022 07:47:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkhp2-0001xV-HM; Sat, 30 Apr 2022 07:47:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkhp2-0002wW-FW; Sat, 30 Apr 2022 07:47:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkhp2-0007DX-4V; Sat, 30 Apr 2022 07:47:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkhp2-0000Ji-45; Sat, 30 Apr 2022 07:47:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=syWs4HbZpks64VIE7h+1+BP/va55E1WKyAGaqXoD/j4=; b=ZKgG8MceLeU9jxls5JJRw9EQ9h
	2CM1vMH6VSwD9QO9UylCU581wdasoWyUxnoO9Kj5kvHkeceUMI9g3LJHY4MHCYSQwpBAlR1svdSEy
	goQhi9kvvImpvgyYN3TbsKiRCE3X6uSue2UE85Y9QUjgNP5lM5BzGvJTgajx5ObOiKLk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169901-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169901: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=d372ab585a2cdc5348af5f701c56c631235fe698
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 07:47:20 +0000

flight 169901 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169901/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 d372ab585a2cdc5348af5f701c56c631235fe698
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  708 attempts
Testing same since   169816  2022-04-28 14:41:38 Z    1 days   29 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5844 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 09:26:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 09:26:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318044.537597 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkjMj-0003lc-Cd; Sat, 30 Apr 2022 09:26:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318044.537597; Sat, 30 Apr 2022 09:26:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkjMj-0003lV-9H; Sat, 30 Apr 2022 09:26:13 +0000
Received: by outflank-mailman (input) for mailman id 318044;
 Sat, 30 Apr 2022 09:26:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkjMh-0003lL-HL; Sat, 30 Apr 2022 09:26:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkjMh-0005Dn-Et; Sat, 30 Apr 2022 09:26:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkjMh-000431-5b; Sat, 30 Apr 2022 09:26:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkjMh-0008QB-59; Sat, 30 Apr 2022 09:26:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dRnIDz/Eeq+vaSo5W2a/gKGTMhGI6BM/WcEaKre/eV4=; b=4/phcAOXQuqUWimnElR4/xYMSt
	O245+PZ95i1T2eUF5Udr4ds2aK0CSC9Wa4qQ8zdM5zNUHN8YZMYNqQX9XdPCObh30C4eQOr5rSa5p
	AV1YvG0Rj72XLSDVdCQWr1TSxMAWky4taxYN3rFn24CnKzIjvYERSwEe4JVl3z4HFT5k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169904-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169904: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 09:26:11 +0000

flight 169904 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169904/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   60 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  709 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 09:49:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 09:49:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318053.537612 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkjjY-0006C0-Cs; Sat, 30 Apr 2022 09:49:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318053.537612; Sat, 30 Apr 2022 09:49:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkjjY-0006Bt-8F; Sat, 30 Apr 2022 09:49:48 +0000
Received: by outflank-mailman (input) for mailman id 318053;
 Sat, 30 Apr 2022 09:49:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkjjX-0006BT-04; Sat, 30 Apr 2022 09:49:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkjjW-0005dY-Uc; Sat, 30 Apr 2022 09:49:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkjjW-00053i-G7; Sat, 30 Apr 2022 09:49:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkjjW-0007W6-Fh; Sat, 30 Apr 2022 09:49:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FdZTOyXnKHcEFstsdRimGTQvLnX1h70NBWX3/vyDZeU=; b=1UoW0Zv/7M0P543o/oH6imKOi+
	PwCE2iu7e/ykAuPpj0PLN9zLhf7nGpdyajaee8TtuMKr8rCWm5W8vOLQf8Y1SlPDDOSl6/GoDvR6t
	VKrte/Rzs/63xOm8KaGocYBolhyixiF7n1JXvZkntqgZ6ZgBL3fbOy+0yEVyTXHsZT64=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169897-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 169897: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=d0289cfa0e77f5db524393802eb5c58216b38db6
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 09:49:46 +0000

flight 169897 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169897/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              d0289cfa0e77f5db524393802eb5c58216b38db6
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  659 days
Failing since        151818  2020-07-11 04:18:52 Z  658 days  640 attempts
Testing same since   169897  2022-04-30 04:20:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Amneesh Singh <natto@weirdnatto.in>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Andrew Melnychenko <andrew@daynix.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Claudio Fontana <cfontana@suse.de>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Haonan Wang <hnwanga1@gmail.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  John Levon <john.levon@nutanix.com>
  John Levon <levon@movementarian.org>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Lena Voytek <lena.voytek@canonical.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Martin Pitt <mpitt@debian.org>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Maxim Nestratov <mnestratov@virtuozzo.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Moteen Shah <codeguy.moteen@gmail.com>
  Moteen Shah <moteenshah.02@gmail.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nikolay.shirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@openvz.org>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tom Wieczorek <tom@bibbu.net>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 106203 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 11:02:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 11:02:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318062.537626 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkkrD-0005Xq-L1; Sat, 30 Apr 2022 11:01:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318062.537626; Sat, 30 Apr 2022 11:01:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkkrD-0005Xj-GS; Sat, 30 Apr 2022 11:01:47 +0000
Received: by outflank-mailman (input) for mailman id 318062;
 Sat, 30 Apr 2022 11:01:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkkrC-0005XZ-T3; Sat, 30 Apr 2022 11:01:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkkrC-0006vt-Q8; Sat, 30 Apr 2022 11:01:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkkrC-0007EB-Cs; Sat, 30 Apr 2022 11:01:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkkrC-00054k-CP; Sat, 30 Apr 2022 11:01:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cdelPhs30oZZR7HB5W3EWsKof4uUW+wjn+MON5bfSXk=; b=aYlEk/TsG9kZ5pl/8iNEIUdVFD
	xSDfFBQhtChIh8MoPbg0Dkcmf+Po2+5tZwFFVOgoBA9Dmd7h2LOHHT30CwBVE6C0ZOWP6eUfE3yXP
	DiRjJWOuSV4cOGl1rbJUbalUVoXxZcek96DjoGr4DvPjePdF7r69fGLqAAhKuQks1+rc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169905-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169905: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 11:01:46 +0000

flight 169905 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169905/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  710 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 11:38:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 11:38:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318071.537636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nklQH-0000aM-Jm; Sat, 30 Apr 2022 11:38:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318071.537636; Sat, 30 Apr 2022 11:38:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nklQH-0000aF-Gm; Sat, 30 Apr 2022 11:38:01 +0000
Received: by outflank-mailman (input) for mailman id 318071;
 Sat, 30 Apr 2022 11:37:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nklQF-0000a5-Sy; Sat, 30 Apr 2022 11:37:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nklQF-0007Wy-MK; Sat, 30 Apr 2022 11:37:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nklQF-00086W-6a; Sat, 30 Apr 2022 11:37:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nklQF-00034H-67; Sat, 30 Apr 2022 11:37:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IQ0ne3bivbnd7+qcYcRmdLxQGfUGSANBFHfyEz8D/QQ=; b=ltCWN5tpU67UFJAf4v3SyUTrPK
	SrbJw1ZVhOqcM+fJLr0s7hwAzSsd/IrM/mq9cNm87nSBMzOMJgaonlwpbbpDT02rYN/MeeReKBQVp
	wn7oIJJaIVWA0NcdC9UE4RSVepix5iS7/Zn1WGv2WH3dtBNUhsGwhNO8rmri4RVQrsZ4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169908-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169908: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 11:37:59 +0000

flight 169908 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169908/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  711 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 12:29:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 12:29:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318085.537656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkmDZ-0005oa-Nz; Sat, 30 Apr 2022 12:28:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318085.537656; Sat, 30 Apr 2022 12:28:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkmDZ-0005oT-KZ; Sat, 30 Apr 2022 12:28:57 +0000
Received: by outflank-mailman (input) for mailman id 318085;
 Sat, 30 Apr 2022 12:28:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkmDY-0005oJ-CW; Sat, 30 Apr 2022 12:28:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkmDY-0008SY-AA; Sat, 30 Apr 2022 12:28:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkmDY-00013V-2f; Sat, 30 Apr 2022 12:28:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkmDY-0002FE-2C; Sat, 30 Apr 2022 12:28:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BupEFk7+q4EGUQP8ukScdB25C14z06N/IEFb1mL+C3A=; b=fNhT4VEVabQzxgo2Jdao7nhHbA
	GkVCRu1fS0QHLDS0WctTdwcZ9b17iHVcUJ8FNJ2TeZKy3Sogh9ldazDsMFDV1viuV7fY+EfnOKD2t
	Oa2B8ikcC4PSCKBf8lUYAApaV644ZqdILHqo0Nby0nBQo5mhCHPHLpjDvPMEvooR+wg8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169910-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169910: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 12:28:56 +0000

flight 169910 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169910/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  712 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 12:36:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 12:36:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318112.537744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkmKc-00089g-Fv; Sat, 30 Apr 2022 12:36:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318112.537744; Sat, 30 Apr 2022 12:36:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkmKc-00089Y-Co; Sat, 30 Apr 2022 12:36:14 +0000
Received: by outflank-mailman (input) for mailman id 318112;
 Sat, 30 Apr 2022 12:36:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkmKa-00089C-NX; Sat, 30 Apr 2022 12:36:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkmKa-0000AW-LA; Sat, 30 Apr 2022 12:36:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkmKa-0001He-4f; Sat, 30 Apr 2022 12:36:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkmKa-0005oW-47; Sat, 30 Apr 2022 12:36:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RnWmcwuoLx4mD5VDIQdJNgk+FhvuUhrAymCIWyJfGAc=; b=Hla+u2ODi1aChoWpBYzK5Hkfzh
	gHZf1lnwMlJD6wSthLF8eEOPGwwlLIQ3j4DjEMCyiWGJ8XftWXyYDjhi/fv6WpE0zOn94hWNQmJiF
	5gIwlY2bMQjViA5xIkzVquv7ks6lhxoLaeaXb0mm75qmm6exoouR6BDWAQ0me38ybTTY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169888-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169888: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-vhd:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd
X-Osstest-Versions-That:
    xen=3f5d61466345ed2213de2d7e391b6cd6d4b86015
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 12:36:12 +0000

flight 169888 xen-unstable real [real]
flight 169907 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/169888/
http://logs.test-lab.xenproject.org/osstest/logs/169907/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-vhd        7 xen-install         fail pass in 169907-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169775
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169775
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169775
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169775
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169775
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169775
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169775
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169775
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169775
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169775
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169775
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169775
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  fe234237b6fc8afc5d8265850169ceeb3d2f81fd
baseline version:
 xen                  3f5d61466345ed2213de2d7e391b6cd6d4b86015

Last test of basis   169775  2022-04-27 08:15:40 Z    3 days
Failing since        169798  2022-04-27 22:39:22 Z    2 days    4 attempts
Testing same since   169888  2022-04-29 22:40:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Dario Faggioli <dfaggioli@suse.com>
  David Vrabel <dvrabel@amazon.co.uk>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Julien Grall <julien@xen.org>
  Michal Orzel <michal.orzel@arm.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Tamas K Lengyel <tamas.lengyel@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   3f5d614663..fe234237b6  fe234237b6fc8afc5d8265850169ceeb3d2f81fd -> master


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 14:00:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 14:00:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318124.537766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkndZ-0007y1-KY; Sat, 30 Apr 2022 13:59:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318124.537766; Sat, 30 Apr 2022 13:59:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkndZ-0007xu-He; Sat, 30 Apr 2022 13:59:53 +0000
Received: by outflank-mailman (input) for mailman id 318124;
 Sat, 30 Apr 2022 13:59:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkndY-0007xk-Fd; Sat, 30 Apr 2022 13:59:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkndY-0001dX-Ds; Sat, 30 Apr 2022 13:59:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkndY-00047a-5h; Sat, 30 Apr 2022 13:59:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkndY-0001yn-5E; Sat, 30 Apr 2022 13:59:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CHA5RMkE+S4CLC+dRh/n85J16hykzdQDIqCtQy/dIHo=; b=bBgt+SLo/VNsHczJgYNKhlxsl+
	Oda+PMVfgOKJFAWpt9j7f2+47jC2/t1Mb3dcThIV2uLbNr1dDeGOh9q35ZI+Wegp8fR13ufGpG5uq
	xKQ7kJI4MghY9njiZvm8FEGicGZn58oJVfdj3kfwCbFF0ugkOW8BpcNlKfc/g5hn+Ux4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169913-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169913: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 13:59:52 +0000

flight 169913 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169913/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  713 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 15:03:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 15:03:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318134.537778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkodF-0006ew-8x; Sat, 30 Apr 2022 15:03:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318134.537778; Sat, 30 Apr 2022 15:03:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkodF-0006ep-5c; Sat, 30 Apr 2022 15:03:37 +0000
Received: by outflank-mailman (input) for mailman id 318134;
 Sat, 30 Apr 2022 15:03:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkodD-0006ef-Oe; Sat, 30 Apr 2022 15:03:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkodD-0002p6-Jh; Sat, 30 Apr 2022 15:03:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkodD-0006xS-Bn; Sat, 30 Apr 2022 15:03:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkodD-0002wE-BL; Sat, 30 Apr 2022 15:03:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Zo7Uku7EODNgbYbbHDBqNoVdC1gG5+F68NmIPdBfVyc=; b=ILojDyazJMoUaEU9BnPMqf56U7
	qYZ8uStlkqDBHbKC1FflIaCBo6+Wzz+dtCpol/zhgon540SmlxskJTN3Oqoj5Xzm9aYNS2LqRfyjP
	CtqUuAe4CrFmgwL6avp1FqLz180eG9dQvnBQdPqlDaYRdM0yhDByDJGPxape54qWtpUY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169914-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169914: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 15:03:35 +0000

flight 169914 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169914/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  714 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 15:36:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 15:36:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.317062.537789 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkp8e-0001cR-Dt; Sat, 30 Apr 2022 15:36:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 317062.537789; Sat, 30 Apr 2022 15:36:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkp8e-0001cK-AK; Sat, 30 Apr 2022 15:36:04 +0000
Received: by outflank-mailman (input) for mailman id 317062;
 Fri, 29 Apr 2022 09:22:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=47nD=VH=gmail.com=sergei.shtylyov@srs-se1.protection.inumbo.net>)
 id 1nkMpv-00046R-D5
 for xen-devel@lists.xenproject.org; Fri, 29 Apr 2022 09:22:51 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb504a23-c79d-11ec-8fc4-03012f2f19d4;
 Fri, 29 Apr 2022 11:22:42 +0200 (CEST)
Received: by mail-lf1-x12c.google.com with SMTP id bu29so13029540lfb.0
 for <xen-devel@lists.xenproject.org>; Fri, 29 Apr 2022 02:22:49 -0700 (PDT)
Received: from [192.168.1.103] ([178.176.73.25])
 by smtp.gmail.com with ESMTPSA id
 e1-20020a196741000000b0046bc4be1d60sm192072lfj.123.2022.04.29.02.22.45
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 29 Apr 2022 02:22:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb504a23-c79d-11ec-8fc4-03012f2f19d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=bhPxd6svpKOboxST/6guS4MOSMze/71rIJIgOQA8rZo=;
        b=CcHlI3Au6GCo1UVzpXVov/h1wYElTNB9KLySGMMq2ve/a+TtvK5YlNIE1buiqFG4Nl
         u/yJNPitTZt8sIeOJjB65Ui/1u355v1A2H7rivfKbBLHtHs+twE1aeJijeY6w74gk/C9
         beognAtlmiiMUVoRPY2P2xBjOD5kn8WzXajIeBHjp2IbcVFILkaLGvvcgQymLNFVLX7W
         O2NCAewH21dEqhwgYIy8zCJ1hXEDN8sGRLk/bc4Oj4c5AC8PD4Xjq19cf3SOi69El8Xe
         CE7Bw/RGpPKDZ+W4HqGQMjQxaF5kblB25nziyJo7yUSAzUuWVoHRSngnqULHAZHmFVOo
         K43A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=bhPxd6svpKOboxST/6guS4MOSMze/71rIJIgOQA8rZo=;
        b=gDO8tT3U8pHr8MiqWpiRkQfzQdKr/FR8DFvuGPq5QR/t6SAe44LiRhv+M7e3D5vhrj
         IBPVqApijizeyyU6EALKPPSK0BgkTrAJGpUgBVhtQOzDsJzoLew05xf7/5MMFNWyO89X
         62f8Bzd1LZHccYdczhUBhTixpPeoJScuO4fGgKcIcUgosgrhbQJjvmBBJcySBXBY47w2
         7QY7Spig3dPjeyxOeiGSLEZ8lJSzs8ANsc+c/1LvnAaT88GiQ269m0B6eFSNAQPdwkcp
         157Msy2TkdXUcZG6fyz9vr8FWDzoUyHMa+JOzLgbFQIOw6mWxWoS5vh4XIS3bn9SF/6g
         D4WA==
X-Gm-Message-State: AOAM532eYctRb4gXAUv8wa6Whuw7DoCWH+JJ+/arYyBOWrhhb3RBTRwe
	2ix+ZMETdaUlyqNKwikcFDo=
X-Google-Smtp-Source: ABdhPJzFja3bmADODH1fdpoqaNJXuuCGiOo+I2PKC036x77KFxdRqfAwbMVEMu8UhB/GID87ZxayFg==
X-Received: by 2002:a05:6512:3ba0:b0:472:49f2:a752 with SMTP id g32-20020a0565123ba000b0047249f2a752mr1049387lfv.374.1651224168844;
        Fri, 29 Apr 2022 02:22:48 -0700 (PDT)
Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>, akpm@linux-foundation.org,
 bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
 coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
 linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-leds@vger.kernel.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-um@lists.infradead.org,
 linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org,
 openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org,
 sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org,
 kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com,
 fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com,
 andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de,
 corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
 dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org,
 mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
 john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org,
 mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org,
 peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org,
 stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com,
 vkuznets@redhat.com, will@kernel.org
References: <20220427224924.592546-1-gpiccoli@igalia.com>
 <20220427224924.592546-18-gpiccoli@igalia.com>
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Message-ID: <b8771b37-01f5-f50b-dbb3-9db4ee26e67e@gmail.com>
Date: Fri, 29 Apr 2022 12:22:44 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20220427224924.592546-18-gpiccoli@igalia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hello!

On 4/28/22 1:49 AM, Guilherme G. Piccoli wrote:

> Currently the tracing dump_on_oops feature is implemented
> through separate notifiers, one for die/oops and the other
> for panic. With the addition of panic notifier "id", this
> patch makes use of such "id" to unify both functions.
> 
> It also comments the function and changes the priority of the
> notifier blocks, in order they run early compared to other
> notifiers, to prevent useless trace data (like the callback
> names for the other notifiers). Finally, we also removed an
> unnecessary header inclusion.
> 
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>  kernel/trace/trace.c | 57 +++++++++++++++++++++++++-------------------
>  1 file changed, 32 insertions(+), 25 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index f4de111fa18f..c1d8a3622ccc 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
[...]
> @@ -9767,38 +9766,46 @@ static __init int tracer_init_tracefs(void)
>  
>  fs_initcall(tracer_init_tracefs);
>  
> -static int trace_panic_handler(struct notifier_block *this,
> -			       unsigned long event, void *unused)
> +/*
> + * The idea is to execute the following die/panic callback early, in order
> + * to avoid showing irrelevant information in the trace (like other panic
> + * notifier functions); we are the 2nd to run, after hung_task/rcu_stall
> + * warnings get disabled (to prevent potential log flooding).
> + */
> +static int trace_die_panic_handler(struct notifier_block *self,
> +				unsigned long ev, void *unused)
>  {
> -	if (ftrace_dump_on_oops)
> +	int do_dump;

   bool?

> +
> +	if (!ftrace_dump_on_oops)
> +		return NOTIFY_DONE;
> +
> +	switch (ev) {
> +	case DIE_OOPS:
> +		do_dump = 1;
> +		break;
> +	case PANIC_NOTIFIER:
> +		do_dump = 1;
> +		break;

   Why not:

	case DIE_OOPS:
	case PANIC_NOTIFIER:
		do_dump = 1;
		break;

> +	default:
> +		do_dump = 0;
> +		break;
> +	}
> +
> +	if (do_dump)
>  		ftrace_dump(ftrace_dump_on_oops);
> -	return NOTIFY_OK;
> +
> +	return NOTIFY_DONE;
>  }
[...]

MBR, Sergey


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 15:37:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 15:37:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318145.537800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkp9d-00029Q-Ng; Sat, 30 Apr 2022 15:37:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318145.537800; Sat, 30 Apr 2022 15:37:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkp9d-00029J-KC; Sat, 30 Apr 2022 15:37:05 +0000
Received: by outflank-mailman (input) for mailman id 318145;
 Sat, 30 Apr 2022 15:37:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkp9b-000293-K4; Sat, 30 Apr 2022 15:37:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkp9b-0003Lx-G7; Sat, 30 Apr 2022 15:37:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkp9b-0001Pl-1f; Sat, 30 Apr 2022 15:37:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkp9a-0006ED-VG; Sat, 30 Apr 2022 15:37:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rkZIFYMUHFWV/fa8BbesGAi3iuk3BdPOkPfFA+mPP5k=; b=OZVl/YrJPJkSsLDID6NRA8dxhK
	4TIe7Tpg5b3FK8i8i8G+Zx1ceX8kvi2BSYJD8KYBPE97M3OQ9fMC3DhAPCFWSbB5ir2nzVhY62ry2
	zJyAq+GJj0hosLrLGJHlRtgyAM0h2h3FEMVGYFDQPJE/ribeyTUUt/ZIukxe6Ts4yn/A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169902-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 169902: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=8013d1d3d2e33236dee13a133fba49ad55045e79
X-Osstest-Versions-That:
    linux=3e71713c9e75c34fc03f55ea86b381856ca952ee
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 15:37:02 +0000

flight 169902 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169902/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 169887

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169887
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169887
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169887
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169887
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169887
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169887
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169887
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169887
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                8013d1d3d2e33236dee13a133fba49ad55045e79
baseline version:
 linux                3e71713c9e75c34fc03f55ea86b381856ca952ee

Last test of basis   169887  2022-04-29 22:10:45 Z    0 days
Testing same since   169902  2022-04-30 07:31:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Tomlin <atomlin@redhat.com>
  Adam Ford <aford173@gmail.com>
  Ajay Kathat <ajay.kathat@microchip.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Arnd Bergmann <arnd@arndb.de>
  Bagas Sanjaya <bagasdotme@gmail.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Conor Dooley <conor.dooley@microchip.com>
  Denys Drozdov <denys.drozdov@toradex.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Osipenko <digetx@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eugen Hristev <eugen.hristev@microchip.com>
  Eugene Syromiatnikov <esyr@redhat.com>
  Fabio Estevam <festevam@denx.de>
  Fabio Estevam <festevam@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Guillaume Giraudon <ggiraudon@prism19.com>
  H. Nikolaus Schaller <hns@goldelico.com>
  Ilya Dryomov <idryomov@gmail.com>
  Ivan Bornyakov <i.bornyakov@metrotek.ru>
  Jan Kara <jack@suse.cz>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jens Axboe <axboe@kernel.dk>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Johan Hovold <johan@kernel.org>
  Jonathan Corbet <corbet@lwn.net>
  Joseph Ravichandran <jravi@mit.edu>
  Kevin Hilman <khilman@baylibre.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Ying <victor.liu@nxp.com>
  Marcel Ziswiler <marcel.ziswiler@toradex.com>
  Marek Vasut <marex@denx.de>
  Mark Brown <broonie@kernel.org>
  Max Krummenacher <max.krummenacher@toradex.com>
  Miaoqian Lin <linmq006@gmail.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Neil Armstrong <narmstrong@baylibre.com>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Niels Dossche <dossche.niels@gmail.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Rob Herring <robh@kernel.org>
  Samuel Holland <samuel@sholland.org>
  Sergiu Moga <sergiu.moga@microchip.com>
  Shawn Guo <shawnguo@kernel.org>
  Stephen Boyd <sboyd@kernel.org>
  Tejun Heo <tj@kernel.org>
  Thierry Reding <treding@nvidia.com>
  Tim Harvey <tharvey@gateworks.com>
  Tony Lindgren <tony@atomide.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Wan Jiabing <wanjiabing@vivo.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  Xianwei Zhao <xianwei.zhao@amlogic.com>
  Xiubo Li <xiubli@redhat.com>
  Yang Yingliang <yangyingliang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   3e71713c9e75..8013d1d3d2e3  8013d1d3d2e33236dee13a133fba49ad55045e79 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 16:07:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 16:07:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318157.537810 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkpcM-00069b-4Q; Sat, 30 Apr 2022 16:06:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318157.537810; Sat, 30 Apr 2022 16:06:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkpcM-00069U-1Z; Sat, 30 Apr 2022 16:06:46 +0000
Received: by outflank-mailman (input) for mailman id 318157;
 Sat, 30 Apr 2022 16:06:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkpcK-00069K-8L; Sat, 30 Apr 2022 16:06:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkpcK-0004QD-5j; Sat, 30 Apr 2022 16:06:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkpcJ-0003IJ-Nq; Sat, 30 Apr 2022 16:06:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkpcJ-0008Qw-NN; Sat, 30 Apr 2022 16:06:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VXR9wMp3Z3apydnCyciDDx71xYktlVRLrE/DuYQZIls=; b=Kla4qMCqWhiW9x5drF7/GTcMNd
	HPnjaTiqCfZQN2kf9FAV5nagKn5XmAtk/0WAe+CodGyRhf18HIbU/JRUK2jHVTtwcNbuV9t714osX
	hXU4Q/LXoYg9nhEX7IQZZFF3MpcdFyexXw3H4SKRci0+bTIqRY0cTrjSiPa6z+ON6+h8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169915-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169915: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 16:06:43 +0000

flight 169915 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169915/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  715 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 17:05:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 17:05:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318165.537821 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkqXW-0003oW-IT; Sat, 30 Apr 2022 17:05:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318165.537821; Sat, 30 Apr 2022 17:05:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkqXW-0003oP-FV; Sat, 30 Apr 2022 17:05:50 +0000
Received: by outflank-mailman (input) for mailman id 318165;
 Sat, 30 Apr 2022 17:05:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkqXV-0003oF-IA; Sat, 30 Apr 2022 17:05:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkqXV-0005Se-CK; Sat, 30 Apr 2022 17:05:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkqXU-0005Dp-Tv; Sat, 30 Apr 2022 17:05:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkqXU-00020z-TW; Sat, 30 Apr 2022 17:05:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=n9iBTvzhtWIYsMsNWmJr9f7uAJjnIsGC2lHoF0UstoE=; b=GNMzV/bd7Cz7ZDhGuDsdvBjkOh
	mlBS15Ft9+UsKK2Wq6X7QNJRhv5mn0GwvyylS+uSyLcP6/jVmQINCFyPrfPU1/DzO2MyrAgHXn04C
	WNXukDA2UePxJQKNkT2ch/tezIl373PK8zd3Xk/QGFEe5U7SJ75W8bLtVgDYowoxaxGI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169916-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169916: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 17:05:48 +0000

flight 169916 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169916/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  716 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 17:44:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 17:44:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318173.537833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkr8c-00085o-Fa; Sat, 30 Apr 2022 17:44:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318173.537833; Sat, 30 Apr 2022 17:44:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkr8c-00085h-CO; Sat, 30 Apr 2022 17:44:10 +0000
Received: by outflank-mailman (input) for mailman id 318173;
 Sat, 30 Apr 2022 17:44:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkr8b-00085R-1W; Sat, 30 Apr 2022 17:44:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkr8a-00068Q-R3; Sat, 30 Apr 2022 17:44:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkr8a-0006X5-Fm; Sat, 30 Apr 2022 17:44:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkr8a-0007Gn-FK; Sat, 30 Apr 2022 17:44:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Uj/Tjt95ttN3zniEdqIWwASucHhKwMq1QS1wc2kDj14=; b=NDPTO3RRgTywavaF9QBhxS/tuC
	NVrgoy4MKZuasaEpYkP7pzjChCS7l+VWV7ZBv5Pti/SgFRoj1Z+XrYjUCDyTe8Vvc4Um/W0mLw2Ql
	7o/lrXihNrN4u1c+vII6uSwVUiW0nyzX9taY7eY6b7ea73GQT6xnljXdRnGhAwNgucSk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169917-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169917: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 17:44:08 +0000

flight 169917 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169917/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  717 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 19:20:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 19:20:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318181.537844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nksdD-0000HX-Hd; Sat, 30 Apr 2022 19:19:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318181.537844; Sat, 30 Apr 2022 19:19:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nksdD-0000HQ-Es; Sat, 30 Apr 2022 19:19:51 +0000
Received: by outflank-mailman (input) for mailman id 318181;
 Sat, 30 Apr 2022 19:19:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nksdC-0000HG-3s; Sat, 30 Apr 2022 19:19:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nksdC-0007pz-1U; Sat, 30 Apr 2022 19:19:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nksdB-0003Jl-Mv; Sat, 30 Apr 2022 19:19:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nksdB-0005N2-MU; Sat, 30 Apr 2022 19:19:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BCsGW0zirsPRV1F29qQg1qYJ6bztiKABUnnAZM350Yo=; b=oDhgfFj4H8fAt95iWVbm0l4n+d
	8fBG20hlz1RIucPFm90M43/RrAcUCB0DDmG+BXKJca+JdGhjJ7sW9wf/wYbpq8oSUW7APVCDSUMQT
	VcBTkBZGf/ehurBfbKYdnkQTzxcMsxWTiJDu9NYZ886fUqbhuHb56Npqmpil6FoF0/H0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169919-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169919: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 19:19:49 +0000

flight 169919 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169919/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  718 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 19:47:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 19:47:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318190.537854 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkt3v-0003gc-PV; Sat, 30 Apr 2022 19:47:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318190.537854; Sat, 30 Apr 2022 19:47:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkt3v-0003gV-MQ; Sat, 30 Apr 2022 19:47:27 +0000
Received: by outflank-mailman (input) for mailman id 318190;
 Sat, 30 Apr 2022 19:47:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkt3v-0003gL-3g; Sat, 30 Apr 2022 19:47:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkt3u-0008IS-TG; Sat, 30 Apr 2022 19:47:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkt3u-0004OZ-Dr; Sat, 30 Apr 2022 19:47:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkt3u-0000cc-DN; Sat, 30 Apr 2022 19:47:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KbkA8UdpbU5zx/6Y3n0+aeO0UPwxorphfrpV4dOnJA8=; b=Jwptsfw0rEWu7WFc+z+uxfxAmp
	kLuRSueNc53kpzGUYUOQcgdWt6dcglvQVL/gvHQW9jBlbydblDE6/wI6iXTGUc+xEaLl8N6DN29md
	7PSsApkUdApeyUc0aC3wUlYc3/DCOEo8fhkZooBUeHWxoJmNmJg5TbKdJy5KkQ7UG8g4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169912-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 169912: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd
X-Osstest-Versions-That:
    xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 19:47:26 +0000

flight 169912 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169912/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 169888
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 169888
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169888
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 169888
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 169888
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 169888
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 169888
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 169888
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 169888
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 169888
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 169888
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 169888
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  fe234237b6fc8afc5d8265850169ceeb3d2f81fd
baseline version:
 xen                  fe234237b6fc8afc5d8265850169ceeb3d2f81fd

Last test of basis   169912  2022-04-30 12:38:30 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Apr 30 20:19:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 20:19:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318198.537865 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nktZH-00078m-9P; Sat, 30 Apr 2022 20:19:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318198.537865; Sat, 30 Apr 2022 20:19:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nktZH-00078f-6V; Sat, 30 Apr 2022 20:19:51 +0000
Received: by outflank-mailman (input) for mailman id 318198;
 Sat, 30 Apr 2022 20:19:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nktZG-00078V-Bc; Sat, 30 Apr 2022 20:19:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nktZG-0000WQ-9o; Sat, 30 Apr 2022 20:19:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nktZF-0005qD-TD; Sat, 30 Apr 2022 20:19:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nktZF-0004Go-Sp; Sat, 30 Apr 2022 20:19:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=awGetHz0QKPne3xQo4yT97wisFEyE7SUyEwyEnHgusI=; b=5Sqk8LHEIyQ6f9JEdUpzS1Ne+9
	EI5zpDxk7zln1GyTBvwXUMWz76dFqdZjTwEgb9HybovnoN0uTaJ6er65yqwIbBA1l0lw1/0YQD9CZ
	XmptjzU6cNnEprLzM8rYdGqOl5oTTOOx0COT7m3Dwh1qA3n14zICYp5qsOCA0h+rAJOA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169920-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169920: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 20:19:49 +0000

flight 169920 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169920/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  719 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 21:07:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 21:07:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318206.537876 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkuIp-0003vU-Sd; Sat, 30 Apr 2022 21:06:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318206.537876; Sat, 30 Apr 2022 21:06:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkuIp-0003vN-PT; Sat, 30 Apr 2022 21:06:55 +0000
Received: by outflank-mailman (input) for mailman id 318206;
 Sat, 30 Apr 2022 21:06:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkuIo-0003ur-8i; Sat, 30 Apr 2022 21:06:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkuIo-0001KY-6s; Sat, 30 Apr 2022 21:06:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkuIn-0007lt-Qo; Sat, 30 Apr 2022 21:06:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkuIn-0000gn-QF; Sat, 30 Apr 2022 21:06:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hz18Ta85r4nLbgsPZGQGk2/uqFQxsiBE6EmIXvNe6AU=; b=DJNU55/SaSOmFxuB0SptDLXojo
	cKgiee8958+Jxld3WWGbSktNSs0WoYrswoT3go2ZJySDimt+PpxQs8tLyszXNQYI4kaESQqE5Rwsg
	jAZMJWEwFsZ+rVRKFedHB2vxsQ3DMDZZxCsMTMzkRh0vulborb7xsrwtCZxkjuylC+YY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169921-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169921: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 21:06:53 +0000

flight 169921 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169921/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  720 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 21:58:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 21:58:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318215.537888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkv6s-0000qI-UX; Sat, 30 Apr 2022 21:58:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318215.537888; Sat, 30 Apr 2022 21:58:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkv6s-0000qB-RV; Sat, 30 Apr 2022 21:58:38 +0000
Received: by outflank-mailman (input) for mailman id 318215;
 Sat, 30 Apr 2022 21:58:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkv6r-0000q1-Fi; Sat, 30 Apr 2022 21:58:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkv6r-0002FP-Ck; Sat, 30 Apr 2022 21:58:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkv6r-0000sa-1r; Sat, 30 Apr 2022 21:58:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkv6r-00071n-1O; Sat, 30 Apr 2022 21:58:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=e7+OsO+BLIABNJBmdOZKZklFB5SntMLeFhQNKQT9ZDo=; b=B4nnoG+0smsIp/utOwsiixEEcX
	Mh4x7oRWXoKObK+VHt70tGRVOfXIUZrhHpht8qrrXGn1RvV521k0tTRRecdvKJ/b0KH+G+wwclUng
	P50n+hqjyKElY3JyX/LB1FRmMv1PNjhkRG3ngDn69qOZB0CLyk8BdWfMMqEFgHKuhICw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169922-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169922: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 21:58:37 +0000

flight 169922 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169922/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  721 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 22:35:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 22:35:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318229.537899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkvgP-00057b-SD; Sat, 30 Apr 2022 22:35:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318229.537899; Sat, 30 Apr 2022 22:35:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkvgP-00057U-Np; Sat, 30 Apr 2022 22:35:21 +0000
Received: by outflank-mailman (input) for mailman id 318229;
 Sat, 30 Apr 2022 22:35:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkvgN-00057K-Hb; Sat, 30 Apr 2022 22:35:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkvgN-0002sa-BM; Sat, 30 Apr 2022 22:35:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkvgM-0001q2-V9; Sat, 30 Apr 2022 22:35:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkvgM-0001ki-Uf; Sat, 30 Apr 2022 22:35:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yGgmZ3D2oTFfdDiymPIUIeqfNsS89MQvrl5z/HljNfs=; b=R1mZR5GHZU/8p4zKA8Ma5tYEDQ
	pD64oVAf9S3CWU9ZNqGVYMH7cScN4TGcgYam4cBKLr842ecTZcuhnyj8ktRli9uYZJR32TBi/9d9k
	TlKt5dMSClqJzPvjJwmGe6UjxEQzzeF4YwWlQhnZLyA3+rXUpK+NyGcpNZyO09BLGmOY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169923-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169923: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 22:35:18 +0000

flight 169923 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169923/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  722 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 23:05:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 23:05:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318237.537910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkw9I-0008UR-7l; Sat, 30 Apr 2022 23:05:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318237.537910; Sat, 30 Apr 2022 23:05:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkw9I-0008UK-3T; Sat, 30 Apr 2022 23:05:12 +0000
Received: by outflank-mailman (input) for mailman id 318237;
 Sat, 30 Apr 2022 23:05:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkw9H-0008UA-AR; Sat, 30 Apr 2022 23:05:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkw9H-0003PP-8b; Sat, 30 Apr 2022 23:05:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkw9G-0002eP-Kh; Sat, 30 Apr 2022 23:05:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkw9G-0001Ub-KE; Sat, 30 Apr 2022 23:05:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gNWwle1ttkWTfWtFGMqCLphQFaUAz7+ST51krOM9qLA=; b=m4Sag+idB6msChjf8DZWaRIoIJ
	fqcjrgcYIFFBf5e9tFS5V/LhlF6OndqNFn8a0rUPo/lXyRb+11P+BE0b1pZiD4IHinYixIwM9+2LC
	ZCOrrXldT5jNnOO3CEqQTip6rqWRPnPvePE1iCk9gBVfDsXuR5OLsEhvV9oy8wuGTAF0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169924-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169924: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 23:05:10 +0000

flight 169924 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169924/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  723 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Apr 30 23:47:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Apr 2022 23:47:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.318245.537921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkwnb-0004O0-Cj; Sat, 30 Apr 2022 23:46:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 318245.537921; Sat, 30 Apr 2022 23:46:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nkwnb-0004Nt-9M; Sat, 30 Apr 2022 23:46:51 +0000
Received: by outflank-mailman (input) for mailman id 318245;
 Sat, 30 Apr 2022 23:46:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkwna-0004Nj-L5; Sat, 30 Apr 2022 23:46:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkwna-00048g-Gw; Sat, 30 Apr 2022 23:46:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nkwna-0003cd-1P; Sat, 30 Apr 2022 23:46:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nkwna-0001dq-0u; Sat, 30 Apr 2022 23:46:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fx3F093Mk3/f/IZ0HPaYqFEY80KLy+C9GmBegE+ddM0=; b=ieOP6Pk4HNMkVyaghY8GJ7hJvB
	bfcBJ54Ut0yXYCeu/fBuuJKBanhQGiQFy98OEyI1nDN7IITVtDrEwO5AnrinATyMj/J6Eh36wER9I
	QXqc7GQmKWaBTBzWC02s7/jklcAfDWgg2PtiATcwdRUDWPbmWe9h72Dadl6D3nguLVSQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-169925-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 169925: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec
X-Osstest-Versions-That:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Apr 2022 23:46:50 +0000

flight 169925 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/169925/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-xsm               6 xen-build                fail REGR. vs. 168254
 build-amd64                   6 xen-build                fail REGR. vs. 168254
 build-i386-xsm                6 xen-build                fail REGR. vs. 168254
 build-i386                    6 xen-build                fail REGR. vs. 168254

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 cabd96ad03603a63a97e701fb30a03341ca0e2ec
baseline version:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70

Last test of basis   168254  2022-02-28 10:41:46 Z   61 days
Failing since        168258  2022-03-01 01:55:31 Z   60 days  724 attempts
Testing same since   169904  2022-04-30 08:10:33 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <abdattar@amd.com>
  Abdul Lateef Attar via groups.io <abdattar=amd.com@groups.io>
  Abner Chang <abner.chang@hpe.com>
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Anthony PERARD <anthony.perard@citrix.com
  Bandaru, Purna Chandra Rao <Purna.Chandra.Rao.Bandaru@intel.com>
  Bo Chang Ke <bo-changx.ke@intel.com>
  Bob Feng <bob.c.feng@intel.com>
  Chen Lin Z <lin.z.chen@intel.com>
  Chen, Lin Z <lin.z.chen@intel.com>
  Dandan Bi <dandan.bi@intel.com>
  Dun Tan <dun.tan@intel.com>
  Feng, Bob C <bob.c.feng@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Guo Dong <guo.dong@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Hao A Wu <hao.a.wu@intel.com>
  Heng Luo <heng.luo@intel.com>
  Hua Ma <hua.ma@intel.com>
  Huang, Li-Xia <lisa.huang@intel.com>
  Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Jason <yun.lou@intel.com>
  Jason Lou <yun.lou@intel.com>
  Ke, Bo-ChangX <bo-changx.ke@intel.com>
  Ken Lautner <kenlautner3@gmail.com>
  Kenneth Lautner <kenlautner3@gmail.com>
  Kuo, Ted <ted.kuo@intel.com>
  Laszlo Ersek <lersek@redhat.com>
  Lean Sheng Tan <sheng.tan@9elements.com>
  Leif Lindholm <quic_llindhol@quicinc.com
  Leif Lindholm <quic_llindhol@quicinc.com>
  Li, Yi1 <yi1.li@intel.com>
  Li, Zhihao <zhihao.li@intel.com>
  Liming Gao <gaoliming@byosoft.com.cn>
  Liu <yun.y.liu@intel.com>
  Liu Yun <yun.y.liu@intel.com>
  Liu Yun Y <yun.y.liu@intel.com>
  Lixia Huang <lisa.huang@intel.com>
  Lou, Yun <Yun.Lou@intel.com>
  Ma, Hua <Hua.Ma@intel.com>
  Mara Sophie Grosch <littlefox@lf-net.org>
  Mara Sophie Grosch via groups.io <littlefox=lf-net.org@groups.io>
  Matt DeVillier <matt.devillier@gmail.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Michael Kubacki <mikuback@microsoft.com>
  Min Xu <min.m.xu@intel.com>
  Oliver Steffen <osteffen@redhat.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Purna Chandra Rao Bandaru <purna.chandra.rao.bandaru@intel.com>
  Ray Ni <ray.ni@intel.com>
  Rebecca Cran <quic_rcran@quicinc.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Sean Rhodes <sean@starlabs.systems>
  Sean Rhodes sean@starlabs.systems
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Sunny Wang <sunny.wang@arm.com>
  Tan, Dun <dun.tan@intel.com>
  Ted Kuo <ted.kuo@intel.com>
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
  Xiaolu.Jiang <xiaolu.jiang@intel.com>
  Xie, Yuanhao <yuanhao.xie@intel.com>
  Yi Li <yi1.li@intel.com>
  yi1 li <yi1.li@intel.com>
  Yuanhao Xie <yuanhao.xie@intel.com>
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5855 lines long.)